From xen-devel-bounces@lists.xenproject.org Thu Sep 01 00:50:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 00:50:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396131.636146 (Exim 4.92) (envelope-from ) id 1oTYPG-0002Rl-Vw; Thu, 01 Sep 2022 00:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396131.636146; Thu, 01 Sep 2022 00:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYPG-0002Re-RO; Thu, 01 Sep 2022 00:50:06 +0000 Received: by outflank-mailman (input) for mailman id 396131; Thu, 01 Sep 2022 00:50:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYPF-00022m-5c for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 00:50:05 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2058.outbound.protection.outlook.com [40.107.105.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02a012b5-2990-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 02:50:01 +0200 (CEST) Received: from DB6PR07CA0074.eurprd07.prod.outlook.com (2603:10a6:6:2b::12) by AS8PR08MB6647.eurprd08.prod.outlook.com (2603:10a6:20b:38e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 00:50:00 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2b:cafe::1b) by DB6PR07CA0074.outlook.office365.com (2603:10a6:6:2b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Thu, 1 Sep 2022 00:50:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 00:49:59 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 01 Sep 2022 00:49:59 +0000 Received: from a8ca1eae88da.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D69792EE-278E-40B3-B285-ECDDC0329704.1; Thu, 01 Sep 2022 00:49:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8ca1eae88da.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 00:49:48 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com (2603:10a6:150:a9::12) by GVXPR08MB7702.eurprd08.prod.outlook.com (2603:10a6:150:6c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Thu, 1 Sep 2022 00:49:46 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::a809:872b:d8c7:5aa2]) by GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::a809:872b:d8c7:5aa2%3]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 00:49:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02a012b5-2990-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iDGlN40hriIz/ezX+FbsCtw+ZGm3b2S3xF+6slT7cpU5YLnmda5J+i+ZdmHPZTuX4q38mdhwWCrhMj2HOB3tRzx1dEzF9sLxq52jdcPXx0RAnxid9wXAMNm1EgGw+Hf1zYzXpFwlndap4drONvBV4zf89Pk+elRusMxeWBWvhCeRANmu1jGnU/an0npxoHW7xrwoBp5zHfVxjJa/0Qa9tzAxvr1RIfwfDKeS/z4am0BmrpHh68Q7CeTC8zZMhvRJSSGVYhZypSTL9f+lgQ4LouBT5NqVk+pVj2NCpRF1dfyn3/MWneIUDuT/YUiI/Y796x1bksIENCW0mkygXffGEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vOmcfg2WB89T/2XD5I94nVy4clbXGlsYiw7qjYX7GvA=; b=cORyBXRM+hVUrDCS9sj9HBNDCqxd7F4+KusV3Ui91XhLAzh8wU4Y4il2TnZ3A0ZOr2huy7/KRb0/dfm4v3nJ8tOuVYeoUDnN+Gv5FJJ0JXxlq1lGuZLwvB8Xo+4s6S7n7EvSwq5Wd3jXqhVMSIrn1jGdXP91FYR7lG/c5/owwmE/ZqQyQQfNYOPLniid9Gn7YxFa/b+JzXj0YbPU7Gg/I7lpqPAr3l9B+aNp67MszROmoiS5WOp2Es/xYv7o3lcQynkFVOnz+6BOUg4u9VJ64vo70FwyGbMs4N1G7mE8BPHmFYU2lBcjURwA3KzYjPiEask+mdMOwy0FYargC0wfTg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOmcfg2WB89T/2XD5I94nVy4clbXGlsYiw7qjYX7GvA=; b=MmDjEyXANKVMchyEypaP6AxNoiDCigzOUN/b3uTZ3WoAYg+hbfY+SN/T4hRJoysk2h94RGyr4S0rnXurb7zUWyjBXWJkXs49AfA6qPGzd8x0GMqd7GYOCOkWNjGpDlf+dW8cpNrxrLPyp5pqc/0TT5SNIACMwHK8c6nQ52AzZXY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDNg44pY1W+QEFIuWCqqHXS54OMsnn81eeulwjTwgqV7ltNwnTEzJvK+dN5WzhES7KLnIxNV6JhgvUt/uxbDT08hsY3k66yshmEzobl/uZnarf3F5tr4y3l+9bcLRmw4ZwB50m4dAAviBSBpwfnPAGXPbf0Ti+vrpuDnrRS3l0GCfQw5jmSCcnrwQrQfjdapBsyV7ETIW/Vnk+H50Dwbr41yOqqbXm5Qm/SWQ7LeMf6PHr5Wa1mheKFrTUhI5eQuh2Vq22Y30sQ3Y7jg0LSGEUpNhtOuGSzcwGjUjbESNZb0kMpqMM5fVxIcmm/vzbbfDAbT6K2NsK0ucFh+AZCqOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vOmcfg2WB89T/2XD5I94nVy4clbXGlsYiw7qjYX7GvA=; b=eKI2hADDueQYcWmjeWM5QOIrH9KX2uzKMht52pvj2TeSpoaoNxdEjdKJE5z5qQ5bT+0hH4SacYSZ3AMtX8FSNu+F2+/9zE6vj8H2DGPZPvBidnLmTq8LmewiGuBjMOeWxcprKlJLqtStM8Q/TvH7UyEKalpMuNtT5XRQPYBqqOfS+LA2ATkedlkeA4aulSsuugjGatyS8sr1j6OiHFjS3nBfPxawEYAJAzZf4Xp0CVPWFayGSvveIwzcGsOST643OpRNw97aVE5XK2N2gq81je/Y79z4Zyde/DhgDy1yGj83XtUkq2oIsbFhMOEDCOopBnLSR0dPN8amW/fuyPTfuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOmcfg2WB89T/2XD5I94nVy4clbXGlsYiw7qjYX7GvA=; b=MmDjEyXANKVMchyEypaP6AxNoiDCigzOUN/b3uTZ3WoAYg+hbfY+SN/T4hRJoysk2h94RGyr4S0rnXurb7zUWyjBXWJkXs49AfA6qPGzd8x0GMqd7GYOCOkWNjGpDlf+dW8cpNrxrLPyp5pqc/0TT5SNIACMwHK8c6nQ52AzZXY= From: Henry Wang To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q3GqcQAgABmBoCAAKwSgIAAgPtwgAFuhYCAAB5nAA== Date: Thu, 1 Sep 2022 00:49:46 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AB03E5CCFF36ED48AC32048EFCC90B1B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 42556220-ce62-4609-a90b-08da8bb3e5b8 x-ms-traffictypediagnostic: GVXPR08MB7702:EE_|DBAEUR03FT059:EE_|AS8PR08MB6647:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QBOrX/P9ELC7E0TVBrDHFJbOqGC08NgxQ0EUQMs5v/rszf+a5PmRBWZ0dwAF2OQ+JA1EBJoJEk8aZyC1DizKRZFuc+Nt9wTw/FsaavmDLixjtzTuWh1UOnuVd8BdyjVSvUQZrXNnqWv/XqkCVBzAL3YR8KBi+pCABTrL+3VkeK421J/ngLocFE/c74Wwp+VTbSbkNMWPkQBukNKTkZCQ5bzTp097cmRLjSz+hbfrXw98uSYa6yJklWsP2izxqg0BwTIx3HFynsqwopf4JfY9QUACreA7I1I+KBBH6ADKYGcr42ftbHlyXEZ5vYRhw9wzKhw8IsVmWGnucq9juybSVIAojsiEVwaRj5Pzo3wcEwKPgdxJhwrhKpgKp0uXQpzv+53s9fhk5mSyc7i+0s7yRSQ6NFvApzQo8tS7/8sksN7zsABNRs6OUNk/lj+t07bP3lqX88HJihEhTKQegDsmkjRW8udkPTI16zeJQUznW4DffF/xC3Y3vNG7Nhpw3AMW9axhxdDMqLE5JgJA6vx9UMUrjIG1O5oXN83ygLH9ppNrCKlvA4kmKjYXknCMnPySmtZKqqBZyx5KUDUm6Z9wyI+N6FZaeeamTghW8A/w0tL7uC01v6bptZ9Ad6vL2XksrxxHd/Qzwu4myt6gjLUgpMq2ZbK6cbZGBa8pDU6pslrm7NZKzktaJvt8yZ5UWpXrBlcMyqw0vE16gwJ4tvcAL2F1qzqdIfsCB+do1gFILlrCea9DV/ne7ygPwoo1cQ8tdra0OLfszwjL3afgvBPgRg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8001.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(186003)(33656002)(71200400001)(6916009)(316002)(9686003)(26005)(7696005)(83380400001)(6506007)(2906002)(38070700005)(66446008)(5660300002)(8936002)(66476007)(478600001)(54906003)(8676002)(52536014)(122000001)(55016003)(41300700001)(86362001)(38100700002)(66946007)(4326008)(76116006)(64756008)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7702 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e2a2633a-f1cf-4509-1911-08da8bb3ddf7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GugJ7t+42f35R3O19r/x2OUfBdgD957ObWiNGw3ysHPD06yj2oGNmMtaUuB5wBZ+Hv+ZeulA6DhaWR7kFnShs/7qdu61frctJRtfZTeJax0FutOzgCwkJlRFAu3b+WXXpU823iRqL4UJ2nnFCPjHMQJLwG9WWtiYtNOl6duLpYaYnqiLJxKIXQtNPsRAy7L8LVvnrNQLtuRqgqHxdeenXKwpezKkc2qpo0TRB22LxQB1HyWffTvIUTEdqMliQC8jwZWHKg+sAxanuEDp8ks9SRa/GxARbDXRz2kZndpBCeG/+Op3LTdf9BljGhBW+Y83WVj2YAGywwbNm3WBlh0oMzkyoF8h06zQ+J1XO/zql7AaTnisyNtLEsocvcYTVvUbu2u+WmVQMC/H73zcrEPugd9rJrWg6wDKCovDnvAY0QJHxVZdiHTRVF1i+/1q83MfQuxIXhMeUjSahW5oCMRie51hiztLqvMb0y+5kAB7M6ZM7KDyuOLgNC1tqM1+N7nK2mQ9bwR7TG8bG50FJoef/8elz4FvaL3ricoHt2oRXH9qvDD2Wqsw9fYJAT6asElDmenwsnq2mcNI1YVRIVL2iqZrvYVqgBFsvFOlQi8hXbqsQP5rRHkPFsPITL8mXBw4+jt5svbErg2tj0SzKf2BODS4Pv6eimWIpnANFZjvQ+pqCTXPJpx7ACFsgu2C2ybcGryJm37As3emCo2kEjnWWk1ca2alBQSQ12OD6YXwaqNHUX5/F3FbWImVPIwH1/cSMMspcR++gjbj4Ga4f0m0oA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(346002)(376002)(36840700001)(40470700004)(46966006)(6862004)(41300700001)(5660300002)(8936002)(52536014)(33656002)(40460700003)(26005)(9686003)(107886003)(82740400003)(2906002)(6506007)(7696005)(86362001)(55016003)(36860700001)(40480700001)(82310400005)(186003)(336012)(47076005)(81166007)(356005)(83380400001)(54906003)(478600001)(4326008)(70206006)(316002)(8676002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 00:49:59.5681 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42556220-ce62-4609-a90b-08da8bb3e5b8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6647 Hi Stefano, > -----Original Message----- > From: Stefano Stabellini > > > But also it looks like that on arm32 we have specific requirements fo= r > > > Xen heap: > > > > > > * - must be 32 MiB aligned > > > * - must not include Xen itself or the boot modules > > > * - must be at most 1GB or 1/32 the total RAM in the system if = less > > > * - must be at least 32M > > > > ...here, with the "1/32 the total RAM" now being "1/32 of the total res= erved > > heap region", since heap_pages is now reserved_heap_pages. >=20 > I see. I didn't realize the full implications of the memory being used > for both xenheap and domheap on arm32. In that case, I would simply do > the following: >=20 >=20 > heap_pages =3D !reserved_heap ? ram_pages : reserved_heap_pages; >=20 > if ( opt_xenheap_megabytes ) > xenheap_pages =3D opt_xenheap_megabytes << (20-PAGE_SHIFT); > else > { > xenheap_pages =3D (heap_pages/32 + 0x1fffUL) & ~0x1fffUL; > xenheap_pages =3D max(xenheap_pages, 32UL<<(20-PAGE_SHIFT)); > xenheap_pages =3D min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); > } >=20 > if ( reserved_heap ) > e =3D reserved_heap_end; > else > { > do > { > e =3D consider_modules(ram_start, ram_end, > pfn_to_paddr(xenheap_pages), > 32<<20, 0); >=20 > if ( e ) > break; >=20 > xenheap_pages >>=3D 1; > } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20- > PAGE_SHIFT) ); > } >=20 > if ( ! e || > ( reserved_heap && reserved_heap_pages < 32<<(20-PAGE_SHIFT) ) ) > panic("Not enough space for xenheap\n"); >=20 > domheap_pages =3D heap_pages - xenheap_pages; Thanks very much for your time and patience. I will follow this way - with the comment also updated of course (I didn't realize the comment needs to be changed until yesterday when I sent the reply to your last comment.) Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Sep 01 00:50:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 00:50:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396137.636157 (Exim 4.92) (envelope-from ) id 1oTYPu-0002xJ-7i; Thu, 01 Sep 2022 00:50:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396137.636157; Thu, 01 Sep 2022 00:50:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYPu-0002xC-4X; Thu, 01 Sep 2022 00:50:46 +0000 Received: by outflank-mailman (input) for mailman id 396137; Thu, 01 Sep 2022 00:50:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYPt-0002x0-14; Thu, 01 Sep 2022 00:50:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYPs-0003Q6-Vg; Thu, 01 Sep 2022 00:50:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYPs-0008E1-L6; Thu, 01 Sep 2022 00:50:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTYPs-0005rX-Ka; Thu, 01 Sep 2022 00:50:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cyA88cQ7zuiVC8/d8EXk54gcBiZpx4wBIQ33zw2pJrM=; b=w4AH+Vz83JORXGTwi/sBC/ryqt SntcUzNkHJvh8UdT73zgHacWFOE3q6Q7Zogx7KHvhUZLYDkimu5QFsnzP4a0Ku9v4lLe14osXCzwD g2Ap8AmcDnJs2XbS9dC/YQWO5HkJc/88InisKezrpYAGSW29t7SFqPi3HH2CfnsWH01w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172899: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e997d055929665b12246e89eb092dc79c65de9a4 X-Osstest-Versions-That: xen=ace403022358b736755e3042e949540e775c65f1 From: osstest service owner Date: Thu, 01 Sep 2022 00:50:44 +0000 flight 172899 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172899/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172897 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e997d055929665b12246e89eb092dc79c65de9a4 baseline version: xen ace403022358b736755e3042e949540e775c65f1 Last test of basis 172897 2022-08-31 19:01:51 Z 0 days Testing same since 172899 2022-08-31 22:01:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ace4030223..e997d05592 e997d055929665b12246e89eb092dc79c65de9a4 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Sep 01 01:08:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 01:08:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396145.636168 (Exim 4.92) (envelope-from ) id 1oTYgY-0002uV-Mz; Thu, 01 Sep 2022 01:07:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396145.636168; Thu, 01 Sep 2022 01:07:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYgY-0002uO-Iz; Thu, 01 Sep 2022 01:07:58 +0000 Received: by outflank-mailman (input) for mailman id 396145; Thu, 01 Sep 2022 01:07:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYgX-0002uI-8V for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 01:07:57 +0000 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [2607:f8b0:4864:20::b30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 826c974b-2992-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 03:07:55 +0200 (CEST) Received: by mail-yb1-xb30.google.com with SMTP id p204so6579183yba.3 for ; Wed, 31 Aug 2022 18:07:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 826c974b-2992-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=MRPzoJhQ6jRX3IlC8DX7IgvLpQbZlMnsgnvZKuuei8w=; b=FN6oNUdWK/epLWx1TsL9yA3judc8GEWbPUlFBZx3N+obm1zvmXwKLTgA0C+din1hae QL+aeoxudtTxFElhfOjbFrb5XsjBAilaB08Ldofl1XN7K/KLlXYDWHTq4s13vSXmuj5f DKOIAo7JDYtLr+88kw7IWfUfQEtwzvbREYO0F51ITJHJcS5BlsMkaJFVMWN04WfbWge0 QaMLxE28PQcRoEcCdCRT5hYYcc5qJq1t6S50Lj3dBP+TXgyTlXN6pUj2nAiR7uqNJFnz LBjn/+WoYkZm8EFAaPai3sk01dRp3NFnU9eS/Pc/JsqSX+SuHO7G2QXvivbbuPpvEXP7 8nRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=MRPzoJhQ6jRX3IlC8DX7IgvLpQbZlMnsgnvZKuuei8w=; b=u4ail2qdqQyUaKx+TELG+9hmzA6SZUdzd7w+sF/IihaU8XF8aH3zBn911K6jVerDx+ Z8WmouBa9qWFATlqjvJCmsLTjlQJJI9ceDD03JCv4sN3GNxU1eIIczKfH80G/BavJ5Eq 15acQgSzkh28UCJIKwAbQwclnJ6/wheyA9BV0G3H2X1BDHHRq3BbwOpULCAVLwfB7ISN AMO5BcBOskGZxkC/xscZcAoOnwwyVlMOsyg2HTlsI4jKr8QcRV5xb/iVuwVPbOyqSFBv 1RjTEgfREm4bVCwB+88CZzDTG1caEkgwhHDgtNcUCWDbxe6wo5Jxxa6cSEQGSwP9lh/j MH7A== X-Gm-Message-State: ACgBeo12YTUtayOVKgdYQerve9n1d7eQaEx3YXiOmVQvfy4H+WV5oy5G eMOqqbYGaeNby0IeLnYATsh6jxSR2HI2TW4eiZV+tQ== X-Google-Smtp-Source: AA6agR7ANRZu1y3V5ec1pN1knn4GFpXcEWezad8yEa+jyRtwuxFDik/95LNfhWenWi2n9p8vw7Ebn9CJDR6Mcs4MSyE= X-Received: by 2002:a05:6902:4c7:b0:69a:9e36:debe with SMTP id v7-20020a05690204c700b0069a9e36debemr14531815ybs.543.1661994474639; Wed, 31 Aug 2022 18:07:54 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-11-surenb@google.com> <20220831101103.fj5hjgy3dbb44fit@suse.de> <20220831174629.zpa2pu6hpxmytqya@moria.home.lan> In-Reply-To: <20220831174629.zpa2pu6hpxmytqya@moria.home.lan> From: Suren Baghdasaryan Date: Wed, 31 Aug 2022 18:07:43 -0700 Message-ID: Subject: Re: [RFC PATCH 10/30] mm: enable page allocation tagging for __get_free_pages and alloc_pages To: Kent Overstreet Cc: Mel Gorman , Andrew Morton , Michal Hocko , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Peter Zijlstra , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Wed, Aug 31, 2022 at 10:46 AM Kent Overstreet wrote: > > On Wed, Aug 31, 2022 at 11:11:03AM +0100, Mel Gorman wrote: > > On Tue, Aug 30, 2022 at 02:48:59PM -0700, Suren Baghdasaryan wrote: > > > Redefine alloc_pages, __get_free_pages to record allocations done by > > > these functions. Instrument deallocation hooks to record object freeing. > > > > > > Signed-off-by: Suren Baghdasaryan > > > +#ifdef CONFIG_PAGE_ALLOC_TAGGING > > > + > > > #include > > > #include > > > > > > @@ -25,4 +27,37 @@ static inline void pgalloc_tag_dec(struct page *page, unsigned int order) > > > alloc_tag_sub(get_page_tag_ref(page), PAGE_SIZE << order); > > > } > > > > > > +/* > > > + * Redefinitions of the common page allocators/destructors > > > + */ > > > +#define pgtag_alloc_pages(gfp, order) \ > > > +({ \ > > > + struct page *_page = _alloc_pages((gfp), (order)); \ > > > + \ > > > + if (_page) \ > > > + alloc_tag_add(get_page_tag_ref(_page), PAGE_SIZE << (order));\ > > > + _page; \ > > > +}) > > > + > > > > Instead of renaming alloc_pages, why is the tagging not done in > > __alloc_pages()? At least __alloc_pages_bulk() is also missed. The branch > > can be guarded with IS_ENABLED. > > It can't be in a function, it has to be in a wrapper macro. Ah, right. __FILE__, __LINE__ and others we use to record the call location would point to include/linux/gfp.h instead of the location allocation is performed at. > > alloc_tag_add() is a macro that defines a static struct in a special elf > section. That struct holds the allocation counters, and putting it in a special > elf section is how the code to list it in debugfs finds it. > > Look at the dynamic debug code for prior precedence for this trick in the kernel > - that's how it makes pr_debug() calls dynamically controllable at runtime, from > debugfs. We're taking that method and turning it into a proper library. > > Because all the counters are statically allocated, without even a pointer deref > to get to them in the allocation path (one pointer deref to get to them in the > deallocate path), that makes this _much, much_ cheaper than anything that could > be done with tracing - cheap enough that I expect many users will want to enable > it in production. > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > From xen-devel-bounces@lists.xenproject.org Thu Sep 01 01:19:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 01:19:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396151.636179 (Exim 4.92) (envelope-from ) id 1oTYrv-0004Qh-OZ; Thu, 01 Sep 2022 01:19:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396151.636179; Thu, 01 Sep 2022 01:19:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYrv-0004Qa-Kd; Thu, 01 Sep 2022 01:19:43 +0000 Received: by outflank-mailman (input) for mailman id 396151; Thu, 01 Sep 2022 01:19:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTYru-0004QU-8q for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 01:19:42 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130054.outbound.protection.outlook.com [40.107.13.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26adf8f1-2994-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 03:19:39 +0200 (CEST) Received: from AS9PR06CA0726.eurprd06.prod.outlook.com (2603:10a6:20b:487::8) by GV2PR08MB8025.eurprd08.prod.outlook.com (2603:10a6:150:ad::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Thu, 1 Sep 2022 01:03:52 +0000 Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::ca) by AS9PR06CA0726.outlook.office365.com (2603:10a6:20b:487::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Thu, 1 Sep 2022 01:03:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 01:03:52 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 01 Sep 2022 01:03:51 +0000 Received: from bbb180d4c6ca.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D442AFD9-15E9-430F-B58D-7ED9D8157217.1; Thu, 01 Sep 2022 01:03:46 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bbb180d4c6ca.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 01:03:46 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com (2603:10a6:150:a9::12) by PAWPR08MB9447.eurprd08.prod.outlook.com (2603:10a6:102:2e5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Thu, 1 Sep 2022 01:03:44 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::a809:872b:d8c7:5aa2]) by GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::a809:872b:d8c7:5aa2%3]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 01:03:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26adf8f1-2994-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b0D1u/kIBrfrMQq8X2uAfYeCEPoWk/MIKYo2flGw6ESNklcgkaE0iiyeZjjPZosCD/eXwBg1XMIWr/4pn4s6RUYZNTKtgVXD4WNaZyzBcTwEMOpfpObck/fiktYbxl5oTiM63dubJNF8GJDayLvZFdms2EyCRQ2ZaxkIMUZWyQizfSlX/pwuDrTInJXbMU47ePYnsxoAQi0g/W32etDjSb3d9d0Bf+mJBm2XQaNF49N+shibdqYxbxFd8GN8MlP4Vk218BGIDELrLnqiUhr2bN3Ns2C2umTV5oLS76lWtmVFeZp8E9mHaW9J13BW+wEj6yeTvdCnv65xz0Gm/TMVMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LcbC8kkJvMSKdojttAwGwtjlVEAJaFx+DC4gz7xzm+Y=; b=De7aioC45ciCBpwuKzJBiiTXBzJ7MR40E6aw/5cMORJDl21cBm7NTb3C0UzVVB7CRDBGmdyMcR02s1+G4XkiNw1/MIDAKiSGe2MDFH4BuZ03y2dHoZmPvidD1/z2dEZbQ06i8PtHOBeqUuEcbUNNmlv2V5CPyMAEGdeHTiRykbD653gz4Lk+NTmaQVOtH1zc60pYjGY6nbToQbtQQgaLihPKYo66ZsLN6K7NHLjRaf8Y16O4113mpZusCE1kZK2gI8tYIBCoE2C2Pk51pt1FX39LWURsK/7R7UVKR47QLVFZapl4+qSkYimOl483PyeUxisMSxIf6S+U2Zxz1pPzOA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LcbC8kkJvMSKdojttAwGwtjlVEAJaFx+DC4gz7xzm+Y=; b=mHmrLhFnrAoeOB9gDZ9amFAFrxR/MNflb2E4cDQYf0ApYqWH457yYBhNrxgISd2xU/BNvi+rP/1wLLyFSDjgdqWY/97gv3EPOJGwkWvfAuIxxi60LyLlRvzEdKmA+7KZ+ide7tK20giWw2/MEAr3KGo6bz1KAFpO/W3ZnBsiLtE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgqLxZiyop9RMTT98xssl6j8jdQxqcjc0m+TNpRnBdQadGOfo3Jd+yUob+PjXmp3SFw7Cb+kvLDYhGoWhK97ur51xy1ez+D8uGdWQERF9IwScz/GHSmdd7O4mLnTxQaVkoEXPC2Vm1o+vPXNAtjnNuVgbUFif1hQMZ6VjfnGd/t86Vhw/vWLs50jXlW6ErjnHZFUIjRkyQhtYfHewhr3Uw5pWUArZIr0kA34Tb2THJaGiPbYJmRLCUS2fRRqm9BimrRNZ1iVY109Hui75ZUgDi+Dq975qhx4elspwPBkCh7WB3TirCGBQ3zhy4XlXYIM4bSHIxjcPQsPgiDvd7yUbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LcbC8kkJvMSKdojttAwGwtjlVEAJaFx+DC4gz7xzm+Y=; b=QdLlXEvu5tiHAHAp5grWV8T0vCTHg01aMUNa0cx28PmTciwNVhO83ZtHcE5EEpomDMPkDeXavO8JKB9zdJk1uqPFDDPPxiAXXCCng/QCU01acdD9r6xrMENnxQQ7tFkZD9mmODQjrbQGyXS3jEmK2ShKROv1oanqCMSDKYyKgdiDGT9AgiK2r6r0yR/S6o/3Q/6JnTuOvTGlemWudUj7w+/u+IDiDd/MFKFXZ0lgQ70gjPRY1XJCEVo8nvL/0IgFbz870Dd0SpsplvmpbpXJxb3A9GkCC8ryNDjMb/HBb5k+zPE6kL2BU6iIP/0Pt0Uxcza5RH/6eaACiNe9c6lWbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LcbC8kkJvMSKdojttAwGwtjlVEAJaFx+DC4gz7xzm+Y=; b=mHmrLhFnrAoeOB9gDZ9amFAFrxR/MNflb2E4cDQYf0ApYqWH457yYBhNrxgISd2xU/BNvi+rP/1wLLyFSDjgdqWY/97gv3EPOJGwkWvfAuIxxi60LyLlRvzEdKmA+7KZ+ide7tK20giWw2/MEAr3KGo6bz1KAFpO/W3ZnBsiLtE= From: Henry Wang To: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Bertrand Marquis CC: Wei Chen , Volodymyr Babchuk , Michal Orzel Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q2/e0SAgAeAsxCAABaogIACundA Date: Thu, 1 Sep 2022 01:03:43 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <59f69736-a18c-9d08-94dd-791bd264d671@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7CE5F7DD7971084B9E240009A0C1CF57.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9d18511b-a308-4c7b-f982-08da8bb5d5fe x-ms-traffictypediagnostic: PAWPR08MB9447:EE_|AM7EUR03FT042:EE_|GV2PR08MB8025:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E8vCqgqv2MdCoLSkwwoEtXDAcRLv8UXRFCiHr8YeucTda6e+2ygjSLtdqufdL0Ksc5oU13uMD3vKGVK9kb4S/W6Ygc5HDplZTOX0KqA1XDUQHqOFWjYZ4HVUw64nVQLzbGHCPN3pLPokG32j2I40ZurqqJPC0GOgsny4hG7AXbGA8saKZVUl6f0iYyMS9+wz+gQjd3E4i4hXhjWS89SFRkoX97N7cot7yQ46VxWBJZNe+bCZj+RFaitLtEx4j1Rgp8hji1IjdKIhg/gCystUnS9rOkYcgJITvNtHwiwTEyBXb+ab32lDrGii4CtXMqhiOODlRijHK7OFShath8NE87cNcOe/vg4tWkFzyLmiqRj+CHc+WQ+g2JHIBsg8FUYsKDlVWp9ClZ5o8TW3MtCXKQBAE9DcVoNn5yiCheIXa+FylZ9ZbbOpp01Yph4XQAlcmP1Zfimd9ivP8RhSoy377L5XZmprQv6bXR+AOY/TfKzvfyORRMhsBsIDs4gFYfUMfhq/O741AO+A+QGwr+zfycOOedzD8dgPMJlS5QzNgAU7X/WxU8WsGZRdH29urLR+Ij7Y+et8xAbR9zxBlf3waMOTjlGzeDFvSgOD7AA8Vpjdn3O6Mxb0aA43HeDhsK2us5NglwvkVoLMICL0c3F23keRw1H9OCU3Uq3yExAuJM9O0/w58XnC8lBn2ybNkI58alGO3xGiORY1oSB7T3rqie7tqVNPmwxNJpQ0IIJ2I1lSW+MARWsKvSy6lQxw22xQ80VyMZY/knl9oEHXVW78ow== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8001.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(39860400002)(366004)(346002)(53546011)(76116006)(64756008)(66476007)(41300700001)(66556008)(6506007)(7696005)(52536014)(8676002)(8936002)(5660300002)(66946007)(86362001)(55016003)(83380400001)(186003)(4326008)(478600001)(66446008)(33656002)(9686003)(26005)(2906002)(122000001)(38100700002)(38070700005)(71200400001)(110136005)(54906003)(316002)(6636002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9447 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b13fee9e-7dba-4520-9c16-08da8bb5d0df X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qm7CwS4GghRu9qcrz0NRCbfxKZIhuo2liWkLtJ3VSY2lJbR1O4rUYGDmIbExX7t6iM6PDpSVwSUGBtrA4xPKeymd5imXx/ynNqYx7kdD4QFRTz6Jfpdrj7VqVaw/8UH8AK5tympREWYzxo/u5qlZnQfvKKlsxOpbmXxLqHcr2E8PUA9X6vI3VfPJaHSJXQbjfq6JbzG2kvxCggeMr9VFkph3+pZeGX6Dz0MI001gl+yO5YBbqZBS8i3XDyQ0Fl1aZ7GuTji5M28s4rt1rL0loZgNyyFgwJtWrcA9vpE63NQgKij+iZ67TI5kDHKZyePzJ3cHO1ODLnXcDO4o5C1TbOnRrWk3s0tZOT2K5wTPh74zmCeJgORyM5HRBT3DtVAp/SU23nPxCBP2UsneAu1ChIQtheICabauXZ+h6T9H3bV7CQn6h/97mz/7IrFUdjcL1BJ+yki1uIW5S4y/mKo1nLTqjZcGGOjZUqrdp9N2bbXCSyBPHWc6sXNkPxHC93j2FnAxj/3Vuiv5zAUDv3Zr5eRezQ/TcgpbUppJBsoEGU9lF0WmcUXh19n9dPCKr1JTel5aqFTEa8p78Il1kz13iaVpBBx2HZ0qZdM80p+CODUQ2edNu5zvjIVU01VqZAqTvEE0yIQX8N71ofqUYCRKZr+VS/VMNBscZSWri95ky/pGGbejy7A8EfDUlbkPhuqijzzZNu2oVkTlnDZTrgszwi/p51rO7Oni/1szYXhPam/LqO/BhiQdGCKaP5nk+6j0VjshVSVuctw3H+yh48WjBQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(46966006)(40470700004)(36840700001)(53546011)(2906002)(82310400005)(82740400003)(7696005)(83380400001)(6506007)(55016003)(9686003)(336012)(33656002)(186003)(47076005)(40480700001)(36860700001)(4326008)(86362001)(70206006)(8676002)(40460700003)(70586007)(110136005)(26005)(81166007)(6636002)(316002)(54906003)(52536014)(41300700001)(356005)(5660300002)(8936002)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 01:03:52.1320 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d18511b-a308-4c7b-f982-08da8bb5d5fe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8025 SGkgQXJtIG1haW50YWluZXJzLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEhp IEhlbnJ5LA0KPiANCj4gT24gMzAvMDgvMjAyMiAwODoxMSwgSGVucnkgV2FuZyB3cm90ZToNCj4g Pg0KPiA+IEhpIE1pY2hhbCwNCj4gPg0KPiA+IFNvcnJ5IGFib3V0IHRoZSBsYXRlIHJlcGx5IC0g SSBoYWQgYSBjb3VwbGUgb2YgZGF5cyBvZmYuIFRoYW5rIHlvdSB2ZXJ5DQo+ID4gbXVjaCBmb3Ig dGhlIHJldmlldyEgSSB3aWxsIGFkZCBteSByZXBseSBhbmQgYW5zd2VyIHNvbWUgb2YgeW91cg0K PiA+IHF1ZXN0aW9ucyBiZWxvdy4NCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KPiA+PiBGcm9tOiBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPiA+PiBT dWJqZWN0OiBSZTogW1BBVENIIDIvMl0geGVuL2FybTogSGFuZGxlIHJlc2VydmVkIGhlYXAgcGFn ZXMgaW4gYm9vdA0KPiBhbmQNCj4gPj4gaGVhcCBhbGxvY2F0b3INCj4gPj4NCj4gPj4+IFRoaXMg Y29tbWl0IGZpcnN0bHkgYWRkcyBhIGdsb2JhbCB2YXJpYWJsZSBgcmVzZXJ2ZWRfaGVhcGAuDQo+ ID4+PiBUaGlzIG5ld2x5IGludHJvZHVjZWQgZ2xvYmFsIHZhcmlhYmxlIGlzIHNldCBhdCB0aGUg ZGV2aWNlIHRyZWUNCj4gPj4+IHBhcnNpbmcgdGltZSBpZiB0aGUgcmVzZXJ2ZWQgaGVhcCByYW5n ZXMgYXJlIGRlZmluZWQgaW4gdGhlIGRldmljZQ0KPiA+Pj4gdHJlZSBjaG9zZW4gbm9kZS4NCj4g Pj4+DQo+ID4+IERpZCB5b3UgY29uc2lkZXIgcHV0dGluZyByZXNlcnZlZF9oZWFwIGludG8gYm9v dGluZm8gc3RydWN0dXJlPw0KPiA+DQo+ID4gQWN0dWFsbHkgSSBkaWQsIGJ1dCBJIHNhdyBjdXJy ZW50IGJvb3RpbmZvIG9ubHkgY29udGFpbnMgc29tZSBzdHJ1Y3RzIHNvDQo+ID4gSSB3YXMgbm90 IHN1cmUgaWYgdGhpcyBpcyB0aGUgcHJlZmVycmVkIHdheSwgYnV0IHNpbmNlIHlvdSBhcmUgcmFp c2luZyB0aGlzDQo+ID4gcXVlc3Rpb24sIEkgd2lsbCBmb2xsb3cgdGhpcyBtZXRob2QgaW4gdjIu DQo+DQo+IFRoaXMgaXMgd2hhdCBJIHRoaW5rIHdvdWxkIGJlIGJldHRlciBidXQgbWFpbnRhaW5l cnMgd2lsbCBoYXZlIGEgZGVjaXNpdmUgdm90ZS4NCg0KSSB0aGluayB0aGlzIGlzIHRoZSBvbmx5 IHVuY2VydGFpbiBjb21tZW50IHRoYXQgSSByZWNlaXZlZCBkdXJpbmcgdGhlIGxhdGVzdA0KcmV2 aWV3IG9mIHRoaXMgc2VyaWVzLiBJIGFncmVlIHRoYXQgTWljaGFsIGlzIG1ha2luZyBhIGdvb2Qg cG9pbnQgKFRoYW5rcyEpIGJ1dCB3ZQ0KYXJlIGN1cmlvdXMgYWJvdXQgd2hhdCBtYWludGFpbmVy cyB0aGluay4gQ291bGQgeW91IHBsZWFzZSBraW5kbHkgc2hhcmUgeW91cg0Kb3BpbmlvbiBvbiB0 aGUgbW9yZSBwcmVmZXJyZWQgYXBwcm9hY2g/IEkgd2lsbCBkbyB0aGF0IGluIHYyLiBUaGFua3Mg dmVyeSBtdWNoIQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 01 01:36:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 01:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396159.636190 (Exim 4.92) (envelope-from ) id 1oTZ7p-0006oj-9E; Thu, 01 Sep 2022 01:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396159.636190; Thu, 01 Sep 2022 01:36:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTZ7p-0006oc-5u; Thu, 01 Sep 2022 01:36:09 +0000 Received: by outflank-mailman (input) for mailman id 396159; Thu, 01 Sep 2022 01:36:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTZ7n-0006oS-GM; Thu, 01 Sep 2022 01:36:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTZ7n-0002W6-BS; Thu, 01 Sep 2022 01:36:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTZ7m-0002Dl-Oj; Thu, 01 Sep 2022 01:36:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTZ7m-0006s4-Ni; Thu, 01 Sep 2022 01:36:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bxu7LOANk0Mw2vnhnKL6WDdqvD8UmBXCtTS27wuLB6k=; b=cFIR9WfA0ndWmNnJyUQKEk3+f8 qzIKwlTtFAqAK/rbi+IixbjuUKSRNeugTJxVEQQ6kWI9u/AnMTaWISV2UqZpey8KNojThgNOfuCET cOF3stKjYv6rFXXOa+pvp+0q/gJzMOPgufCZ2ULdTtoXQPbXncILHGOqKxJ3epgM/dWs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172894: regressions - FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Thu, 01 Sep 2022 01:36:06 +0000 flight 172894 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172894/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken in 172884 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 5 host-install(5) broken in 172884 pass in 172894 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 172884 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 172884 blocked in 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 172884 like 172128 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 172884 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 172884 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 172884 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 172884 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 27 days Failing since 172384 2022-08-11 11:13:58 Z 20 days 43 attempts Testing same since 172776 2022-08-25 17:42:45 Z 6 days 14 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 02:35:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 02:35:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396167.636200 (Exim 4.92) (envelope-from ) id 1oTa30-0003y5-Lo; Thu, 01 Sep 2022 02:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396167.636200; Thu, 01 Sep 2022 02:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTa30-0003xy-In; Thu, 01 Sep 2022 02:35:14 +0000 Received: by outflank-mailman (input) for mailman id 396167; Thu, 01 Sep 2022 02:35:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTa2z-0003xs-0o for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 02:35:13 +0000 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [2607:f8b0:4864:20::72b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1f74a81-299e-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 04:35:09 +0200 (CEST) Received: by mail-qk1-x72b.google.com with SMTP id f14so12309764qkm.0 for ; Wed, 31 Aug 2022 19:35:09 -0700 (PDT) Received: from smtpclient.apple ([87.249.134.31]) by smtp.gmail.com with ESMTPSA id k17-20020a05620a143100b006bb83e2e65fsm10502390qkj.42.2022.08.31.19.35.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 19:35:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1f74a81-299e-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc; bh=HvAnqh6oLQZyoeHCbOzg6Bi01dtZi6A0ssMqdIvSvXw=; b=MNEBo+Zsxwbetrquwiayil07AvrTnYMSCBrvmU38nzsham4ud4J34GIxLB4AjenhSC Ma2cGOmU6aWBguXvPY+e12cpy/e87kfuTb16KBtDJ+Yd1HxdDfObYhSKYmrB3dp7f1O4 DrGn5t9GIykC+JrHFu9bYJj5LtY0VW3LFe2G8c4gI3joQnR/PRft8687VHVSNyA0sTU7 RzEzuhuolx2LnhbHDg7QfJ8faMDn1x0erS3MSWTHHt85y8VAGTFbAg/5W9fBFGGuygbZ n+udgfyQjwInwZhukqZn52WGg042RJqwZ+cjh1YQfyv/MolyeY37Ns/z/adUB4lKtseD YoWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc; bh=HvAnqh6oLQZyoeHCbOzg6Bi01dtZi6A0ssMqdIvSvXw=; b=OoWcpDMeSwW95WZoMl8AHxD+hiNFJWvMrsWhBBV2fYxy8Q7/GDxl8g7ZZT0TnGmGde 9KFRandjXjT2n5usc1bXAmLEHleko9uZCSDA96F7Lbt0quDv3gOflLSoek1An7W1xoqM JXM99Gug7Y73ErT7Lywz6WLcCuNxHAzAEenaGhmn8HOkB7fgjQTknV0Emp8hyDY0DdbG MQULqX4SsAf/YCYHVa6Z+zTuhzBqEMhH60Hqj49FMvWCU4wg2zWU4JNjE1s6ALeL0AsX xu1Yi3xVXFhRYYXMWw32ftvT/D5wifvsK81zDgnmKrFO0kiuw6wfv6ckXEv2YrI+IeyE Cpjg== X-Gm-Message-State: ACgBeo1hF0hSvzbc8h/3TSpb1PE2RJ8/Xr+juQSKQD7uc0+XYqj1Hjfl 1CvFH50wn4ZYFj60bCsCbMQ= X-Google-Smtp-Source: AA6agR6KXYuUK62Dl1PGX+4IdTEpnv41poGFatJelFOad0HJkABM+PVXqMsd/jk/2Udq60jOOoRkNQ== X-Received: by 2002:a37:a84e:0:b0:6bb:bf0a:5be7 with SMTP id r75-20020a37a84e000000b006bbbf0a5be7mr17080767qke.213.1661999708126; Wed, 31 Aug 2022 19:35:08 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Rich Persaud Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state Date: Wed, 31 Aug 2022 22:35:06 -0400 Message-Id: <31F127F6-A096-4991-9D4C-1B2E032689A1@gmail.com> References: <20220829151536.8578-1-jandryuk@gmail.com> Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Bjorn Helgaas , xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220829151536.8578-1-jandryuk@gmail.com> To: Jason Andryuk X-Mailer: iPad Mail (19G82) On Aug 29, 2022, at 11:16 AM, Jason Andryuk wrote: >=20 > =EF=BB=BFAn HVM guest with linux stubdom and 2 PCI devices failed to start= as > libxl timed out waiting for the PCI devices to be added. It happens > intermittently but with some regularity. libxl wrote the two xenstore > entries for the devices, but then timed out waiting for backend state 4 > (Connected) - the state stayed at 7 (Reconfiguring). (PCI passthrough > to an HVM with stubdomain is PV passthrough to the stubdomain and then > HVM passthrough with the QEMU inside the stubdomain.) >=20 > The stubdom kernel never printed "pcifront pci-0: Installing PCI > frontend", so it seems to have missed state 4 which would have > called pcifront_try_connect -> pcifront_connect_and_init_dma Is there a state machine doc/flowchart for LibXL and Xen PCI device passthro= ugh to Linux? This would be a valuable addition to Xen's developer docs, eve= n as a whiteboard photo in this thread. Rich= From xen-devel-bounces@lists.xenproject.org Thu Sep 01 02:45:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 02:45:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396172.636212 (Exim 4.92) (envelope-from ) id 1oTaCS-0005Qs-ID; Thu, 01 Sep 2022 02:45:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396172.636212; Thu, 01 Sep 2022 02:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTaCS-0005Ql-F9; Thu, 01 Sep 2022 02:45:00 +0000 Received: by outflank-mailman (input) for mailman id 396172; Thu, 01 Sep 2022 02:45:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTaCR-0005Qf-VH for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 02:45:00 +0000 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [2607:f8b0:4864:20::f2f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1031cd7e-29a0-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 04:44:58 +0200 (CEST) Received: by mail-qv1-xf2f.google.com with SMTP id y15so9210513qvn.2 for ; Wed, 31 Aug 2022 19:44:57 -0700 (PDT) Received: from smtpclient.apple ([87.249.134.31]) by smtp.gmail.com with ESMTPSA id r19-20020ac87953000000b003438a8e842fsm9147695qtt.44.2022.08.31.19.44.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 19:44:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1031cd7e-29a0-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc; bh=foeN+XUZn/u/JnPvfBjtGYGQ36AAShh/VZnPRVJHm1Q=; b=J/XftMDXDEkhrZqRELDF4KEZYH81x3bZ/TEUCc/BJe8XHcsaqMNVs4Nkea5er3gUGw SJr2iluNDzRvGXFdu5u6hbFooqIJO/I/xz5HPlKEwchxumwpnOiuHW2ZoJYLiykFDzSR tD1zE+yTirNgyrP+83R+PlnbNHHJzHtoCtaRuXUR4Wfa9cBm4VQJF+bzWhakf7oXWUtT 9n7CwCFSj2qyKKP5b6cijnMYo4uAu0UM8mG37A45ne3gWruITr6zqo44P9nM0amfWvo7 c/l1vGLkE2VKHkNYdNvvTQlYrxAQhqbacHZxNAGyT5kOMt2MC/f/uq2dAg2OMBDh40pB FVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc; bh=foeN+XUZn/u/JnPvfBjtGYGQ36AAShh/VZnPRVJHm1Q=; b=tF8SPQQ3SlWX1AjTQS5JJbw7e/jGaaixgamhd09loxT/Y2vHdRUKMf26Sal6kUySBW Zvq8iAPJe0HMbe9OkZM5ildRoiXUUzQqqI3ZG3r4PLzfA6mEtRo076MKKxgN+rUZ3SwK U5PFYnv2Rrw4dO1NpQ1fZ48vLS0M2Et+mVCz1KH/I4SOZQdR9pmj38BGcNiO1CoVNynq Yda/Dumj19f+vXMyHvWb/eV3QzBURO5WGcdam0OexTKciekm6LTaJ9PBnHZDURaNpSOJ Ukk+bCR419gaD4zbqjaDTiwi52+rSjkXE1xS0NNf4U6yBQirAVCZ+ZAf94TvUYHGEC6H dPKA== X-Gm-Message-State: ACgBeo1nFfV19KfKXaTIX0zJ0r0nkYF7amdwzF5dtv15qWmcavFNZ5UG QwXngXTJOlh66I7x7NnYNSaQJ6DIkIQ= X-Google-Smtp-Source: AA6agR4bUiWVYXX0Js9zMCXLvCzHB2ccFk177vlMRrzqAtO7zEfs8emQ/eHL1RC7qnv7mDYARED6oQ== X-Received: by 2002:a0c:e082:0:b0:498:f8ed:9a94 with SMTP id l2-20020a0ce082000000b00498f8ed9a94mr19922158qvk.0.1662000295577; Wed, 31 Aug 2022 19:44:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Rich Persaud Mime-Version: 1.0 (1.0) Subject: Re: How to isolate vital part of a host with the Xen Hypervisor? Date: Wed, 31 Aug 2022 22:44:54 -0400 Message-Id: References: <1677353127.432967.1661060142000@mail.yahoo.com> Cc: Xen-devel In-Reply-To: <1677353127.432967.1661060142000@mail.yahoo.com> To: Jason Long X-Mailer: iPad Mail (19G82) On Aug 21, 2022, at 1:36 AM, Jason Long wrote: >=20 > =EF=BB=BFHello, > Is it possible to install the Xen Hypervisor for just isolate my host OS a= nd disable its Virtualization features (Install guest OS)? You can often disable hardware virtualization via a UEFI/BIOS setting. Even= if hardware virtualization support was disabled in UEFI/BIOS or already cla= imed by a bare-metal hypervisor like Xen or ESXi, it would still be possible= to create a guest VM using software-only virtualization, e.g. VMware Workst= ation. Rich= From xen-devel-bounces@lists.xenproject.org Thu Sep 01 03:45:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 03:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396181.636223 (Exim 4.92) (envelope-from ) id 1oTb8Y-000373-41; Thu, 01 Sep 2022 03:45:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396181.636223; Thu, 01 Sep 2022 03:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTb8Y-00036w-02; Thu, 01 Sep 2022 03:45:02 +0000 Received: by outflank-mailman (input) for mailman id 396181; Thu, 01 Sep 2022 03:45:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTb8X-00036m-9z; Thu, 01 Sep 2022 03:45:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTb8X-0001eS-6l; Thu, 01 Sep 2022 03:45:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTb8W-00024V-Fg; Thu, 01 Sep 2022 03:45:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTb8W-0007jH-Da; Thu, 01 Sep 2022 03:45:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rY/WHdbdkFbEx1hhQlKIAvkitKcnt21Ux00LqQP7PIk=; b=5wbWAEGvUBLPY3GpREd3FWc/HR yJmMnTpXWqazKLuMlazJCwyKdOLeQq7WCRri+F5+k8Xk5SywuiXuz1jW3CkVtG56J8SLgJtcI2Wbv qv8j5FKmNf7eVgpQAIMwkvbhnQxlEU89+FsLRqOSfn6TcWdifr4dS/RMI3HU4cDfbdv4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172895: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=93fac696d241dccb04ebb9d23da55fc1e9d8ee36 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Thu, 01 Sep 2022 03:45:00 +0000 flight 172895 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172895/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail in 172877 pass in 172895 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 172877 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 172886 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 93fac696d241dccb04ebb9d23da55fc1e9d8ee36 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 28 days Failing since 172148 2022-08-04 21:39:38 Z 27 days 62 attempts Testing same since 172877 2022-08-30 19:10:25 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Andrea Bolognani BALATON Zoltan Bin Meng Cornelia Huck Daniel Henrique Barboza Daniel P. Berrangé Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Jason Wang John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Marc-André Lureau Mark Cave-Ayland Markus Armbruster Michael S. Tsirkin Paolo Bonzini Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Xiaojuan Yang Yonggang Luo Zenghui Yu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2511 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 03:58:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 03:58:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396188.636234 (Exim 4.92) (envelope-from ) id 1oTbL5-0004bU-93; Thu, 01 Sep 2022 03:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396188.636234; Thu, 01 Sep 2022 03:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTbL5-0004bN-68; Thu, 01 Sep 2022 03:57:59 +0000 Received: by outflank-mailman (input) for mailman id 396188; Thu, 01 Sep 2022 03:57:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTbL4-0004bD-04; Thu, 01 Sep 2022 03:57:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTbL3-0001qT-SD; Thu, 01 Sep 2022 03:57:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTbL3-0002jq-F4; Thu, 01 Sep 2022 03:57:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTbL3-0002Es-Ea; Thu, 01 Sep 2022 03:57:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=msu11/sxe6TsPQQZd+XsnoWyzWtL9M6BNQtTJcmHAdg=; b=nIzOJrJOJ0walRam4eeCdUQf8U XVhoDK6RM1YXSOjri/dwlG02JpYvv7zDMd93pV0nvtu4cCByM2OLw2lWt90IJHpyOAMT8Q81UZJ0h WrdEDWDGouVyPSPMMH0iEeF3LKui8jPIhLR6l74fLA2kXhPOfGx85aAP/iNiKCfiK87A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172903: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=31a94f7fba2a2c1244fc35b6f631e235e267715b X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 01 Sep 2022 03:57:57 +0000 flight 172903 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172903/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 31a94f7fba2a2c1244fc35b6f631e235e267715b baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 27 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 216 attempts Testing same since 172896 2022-08-31 17:13:15 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Ray Ni Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1231 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 04:53:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 04:53:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396197.636245 (Exim 4.92) (envelope-from ) id 1oTcCM-0002Hs-DH; Thu, 01 Sep 2022 04:53:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396197.636245; Thu, 01 Sep 2022 04:53:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTcCM-0002Hl-9l; Thu, 01 Sep 2022 04:53:02 +0000 Received: by outflank-mailman (input) for mailman id 396197; Thu, 01 Sep 2022 04:53:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTcCK-0002He-TJ for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 04:53:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2e6fa2f-29b1-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 06:52:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4811C221FE; Thu, 1 Sep 2022 04:52:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 67DE3139C4; Thu, 1 Sep 2022 04:52:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id E7aqFqY6EGPsewAAMHmgww (envelope-from ); Thu, 01 Sep 2022 04:52:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2e6fa2f-29b1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662007977; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eTDe59i5UNhXbLPqqFo4WrMbXbqRlxGLfSkkAQ8Fk/c=; b=MXuVo2yVstAVCBS1varMecEXswz7FuXIDAQoWezwenAAYl9Y3PpRhbQ5He3NmYqXLh+xPX jn8EotqxdKlpoHsOLAGA9/hldaOwN5qgNQ9dGNBfKhsAkMyZOy8dG2wdiqd/dEPEUn2GH3 2GWaydR4UCkectkbjmLF+pOVJTedvZg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662007977; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eTDe59i5UNhXbLPqqFo4WrMbXbqRlxGLfSkkAQ8Fk/c=; b=g2uWhOe8Agl2O5OiQ5uOLDZi7V4xateLoucVNLb1+2O63J77RwR9Dmx9Wxfg3YF3VCD9bc vcZMMEi8r2KuRXCg== Date: Thu, 1 Sep 2022 06:52:52 +0200 From: Oscar Salvador To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830214919.53220-1-surenb@google.com> On Tue, Aug 30, 2022 at 02:48:49PM -0700, Suren Baghdasaryan wrote: > =========================== > Code tagging framework > =========================== > Code tag is a structure identifying a specific location in the source code > which is generated at compile time and can be embedded in an application- > specific structure. Several applications of code tagging are included in > this RFC, such as memory allocation tracking, dynamic fault injection, > latency tracking and improved error code reporting. > Basically, it takes the old trick of "define a special elf section for > objects of a given type so that we can iterate over them at runtime" and > creates a proper library for it. > > =========================== > Memory allocation tracking > =========================== > The goal for using codetags for memory allocation tracking is to minimize > performance and memory overhead. By recording only the call count and > allocation size, the required operations are kept at the minimum while > collecting statistics for every allocation in the codebase. With that > information, if users are interested in mode detailed context for a > specific allocation, they can enable more in-depth context tracking, > which includes capturing the pid, tgid, task name, allocation size, > timestamp and call stack for every allocation at the specified code > location. > Memory allocation tracking is implemented in two parts: > > part1: instruments page and slab allocators to record call count and total > memory allocated at every allocation in the source code. Every time an > allocation is performed by an instrumented allocator, the codetag at that > location increments its call and size counters. Every time the memory is > freed these counters are decremented. To decrement the counters upon free, > allocated object needs a reference to its codetag. Page allocators use > page_ext to record this reference while slab allocators use memcg_data of > the slab page. > The data is exposed to the user space via a read-only debugfs file called > alloc_tags. Hi Suren, I just posted a patch [1] and reading through your changelog and seeing your PoC, I think we have some kind of overlap. My patchset aims to give you the stacktrace <-> relationship information and it is achieved by a little amount of extra code mostly in page_owner.c/ and lib/stackdepot. Of course, your works seems to be more complete wrt. the information you get. I CCed you in case you want to have a look [1] https://lkml.org/lkml/2022/9/1/36 Thanks -- Oscar Salvador SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 05:05:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 05:05:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396205.636256 (Exim 4.92) (envelope-from ) id 1oTcOd-0004B3-L2; Thu, 01 Sep 2022 05:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396205.636256; Thu, 01 Sep 2022 05:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTcOd-0004Aw-IA; Thu, 01 Sep 2022 05:05:43 +0000 Received: by outflank-mailman (input) for mailman id 396205; Thu, 01 Sep 2022 05:05:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTcOb-0004Aq-Vo for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 05:05:42 +0000 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [2607:f8b0:4864:20::1129]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b920f14f-29b3-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 07:05:40 +0200 (CEST) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-324ec5a9e97so325787997b3.7 for ; Wed, 31 Aug 2022 22:05:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b920f14f-29b3-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ktZOhU9M+eiBxoPfSKrBwsk5VZxY64ML34Vei/rqz2s=; b=UnvyXVMIRiciK0rqi4Rla4SS9BjEhBuxvGCuhtbiGji3fDuHUeDlC2C4TbCLRZRSwR +328Kj0pV/r/xNPqU1581dA9M6WZOvrs39FcqOg6hNQT5ifEu0MLEP+Zz/2G+jRm7WMN 7axpEQrwYULoaAc5UOWeK4pidUhWzYApn91X0NwQTEXfOOrYw3wXsfjb2f2S21BvY7t3 Zg1V8M6rEvRQMEwY0dY+iYzvNIKUl0aPxff0C2lbwvD8YaEzrAOwphxkhABpA5cqFwfx wpTyALvpTmRkdUhm9RVjdaatnoaqYeLhUBKhA4+4MYeMDI/E+7MF6YajUpv+RJVJmtfD MOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ktZOhU9M+eiBxoPfSKrBwsk5VZxY64ML34Vei/rqz2s=; b=ok2Y1ZcBzssYxMgjRC9mDrLtVAu/eNbP37+GBW2rfaAVDeDYyBJU3kjfjZ4mHQjfX0 dPKCsYtbSOqILMrWf/6QGKkCm4p/xohjV0zvKA3+pvzw5T+UAinLsU04zHTsrsl3E3qS G/g1qCjgrkq8X2z9mw6Ekc78TSMS0td44yrO5hnUiimNNB6+0stGgQXN4LsDb1nVJaYS 5Jwp/VBisHI2zrzkUWj4bjNVbKo/VraoBNtlQ3JCPpfJDIFJ67QaPl9Hqnv1/D/GGK7G THcb3eyqgIHuvqLq8KYXab4YMzRiB1g8AMVRYQyvjtk7oiKuQbhxPkQxi6VjB/KKp6yr Ya6A== X-Gm-Message-State: ACgBeo2mwTKHHMT1LTN9hQEDnNYP+rYFR5H1gi48fez4Xu+jCKn/UDpF mM9OOJvyn7uNsRpYEIVjSJO5MQZbuV/N7yHnPYNScA== X-Google-Smtp-Source: AA6agR6X7FU4pvrjt5vMDUM/DC2IsE6vILG7I4DBJ25hoCu+6BelY82RpFQkl53Zm+EyPsuJsyRbi+nPLdvdkyesITk= X-Received: by 2002:a81:a04c:0:b0:340:4c27:dfc6 with SMTP id x73-20020a81a04c000000b003404c27dfc6mr20996289ywg.507.1662008739346; Wed, 31 Aug 2022 22:05:39 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 31 Aug 2022 22:05:28 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Oscar Salvador Cc: Andrew Morton , Kent Overstreet , Michal Hocko , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Peter Zijlstra , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Wed, Aug 31, 2022 at 9:52 PM Oscar Salvador wrote: > > On Tue, Aug 30, 2022 at 02:48:49PM -0700, Suren Baghdasaryan wrote: > > =========================== > > Code tagging framework > > =========================== > > Code tag is a structure identifying a specific location in the source code > > which is generated at compile time and can be embedded in an application- > > specific structure. Several applications of code tagging are included in > > this RFC, such as memory allocation tracking, dynamic fault injection, > > latency tracking and improved error code reporting. > > Basically, it takes the old trick of "define a special elf section for > > objects of a given type so that we can iterate over them at runtime" and > > creates a proper library for it. > > > > =========================== > > Memory allocation tracking > > =========================== > > The goal for using codetags for memory allocation tracking is to minimize > > performance and memory overhead. By recording only the call count and > > allocation size, the required operations are kept at the minimum while > > collecting statistics for every allocation in the codebase. With that > > information, if users are interested in mode detailed context for a > > specific allocation, they can enable more in-depth context tracking, > > which includes capturing the pid, tgid, task name, allocation size, > > timestamp and call stack for every allocation at the specified code > > location. > > Memory allocation tracking is implemented in two parts: > > > > part1: instruments page and slab allocators to record call count and total > > memory allocated at every allocation in the source code. Every time an > > allocation is performed by an instrumented allocator, the codetag at that > > location increments its call and size counters. Every time the memory is > > freed these counters are decremented. To decrement the counters upon free, > > allocated object needs a reference to its codetag. Page allocators use > > page_ext to record this reference while slab allocators use memcg_data of > > the slab page. > > The data is exposed to the user space via a read-only debugfs file called > > alloc_tags. > > Hi Suren, > > I just posted a patch [1] and reading through your changelog and seeing your PoC, > I think we have some kind of overlap. > My patchset aims to give you the stacktrace <-> relationship information and it is > achieved by a little amount of extra code mostly in page_owner.c/ and lib/stackdepot. > > Of course, your works seems to be more complete wrt. the information you get. > > I CCed you in case you want to have a look > > [1] https://lkml.org/lkml/2022/9/1/36 Hi Oscar, Thanks for the note. I'll take a look most likely on Friday and will follow up with you. Thanks, Suren. > > Thanks > > > -- > Oscar Salvador > SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 05:12:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 05:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396054.636267 (Exim 4.92) (envelope-from ) id 1oTcVY-0005b3-Bw; Thu, 01 Sep 2022 05:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396054.636267; Thu, 01 Sep 2022 05:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTcVY-0005aw-8V; Thu, 01 Sep 2022 05:12:52 +0000 Received: by outflank-mailman (input) for mailman id 396054; Wed, 31 Aug 2022 20:56:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTUlT-00084y-Ds for xen-devel@lists.xenproject.org; Wed, 31 Aug 2022 20:56:47 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c537492-296f-11ed-934f-f50d60e1c1bd; Wed, 31 Aug 2022 22:56:45 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id v16so17066498wrm.8 for ; Wed, 31 Aug 2022 13:56:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c537492-296f-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=Q+TlttOrTWNB3q3o6Zbb04N1wsFemMMzZbBDHk1hdbY=; b=VyP3SbNsuyxc5blP2FoCVyjA1CBQu5fk1qPBiWwHnsN7KbhALhPVRs+hdxfauKkrjN HjpFIvR9qflpc5b/NaZbUp4Qe+yoyJx8jmIG71feNwOicipxd4Z45zOK95SSSmFlFqg1 JlDxmSa+dos6d565oincRG6QsILc3r0lbpSqflqmVfv9TWNY+mQW2VINkINO6wGxloda V9BbsnXdjx9TWnVhm9AxW/SNuwlNLiahxr1xh25VEX0zm/Rv6sxPCVqP3nUxZGj48fmq 8freUAXARJQoL1m1MzSBuxjvucYwjbHks6tBHAAViJ2OqT1E6YeDUp+dfTHOL3fNg2CJ OS0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=Q+TlttOrTWNB3q3o6Zbb04N1wsFemMMzZbBDHk1hdbY=; b=aScYRrzKjXmnMKh3KqntjY+w/zKnEICIEmuX+ZDreBJODWvZsgpP/X1wGrrvpS3ern EP+RXJsb1AXquHrAT/wkxMSGhmwQhElJyoFKXT2446pxmjJvYmMYInFoH7qJawXWxR8p hSp/TFHtgimDTPKj11DYUpcT+qWnxlNhq40kW95JJ9jYSuNTYb6uqiFL8ESNGbEd25rO SbCJNUaD/lF1LrAuwGkCMomTFE10YXuNMYlwCsk/ex0/e3D7r8Np2ijVIkuc1L8gnpqD nqzY2oTmfqlBDHne5EdFq7rmR5okMBODp2HIyXPjsewUgv1A+SeTbsQiCWNrh4tVtbsZ LFMQ== X-Gm-Message-State: ACgBeo1mpR/u7wKJk2zrHSalIzx7eug65q/RbIsnAoR0UyMqjGth3AhW X/wnR9loyOYP0GuQTKjKi9UxMz+rTfay9rEBhQcecA== X-Google-Smtp-Source: AA6agR7XK78VXHUjktIpBA+ayr5Wvv6QyZC54NZbTQlygRhYLtBkkgViGprvNovg9YVhzd6mrhctznnyhI9ADAmQ4D4= X-Received: by 2002:a05:6000:1188:b0:220:6c20:fbf6 with SMTP id g8-20020a056000118800b002206c20fbf6mr13193874wrx.372.1661979404912; Wed, 31 Aug 2022 13:56:44 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> From: Yosry Ahmed Date: Wed, 31 Aug 2022 13:56:08 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Kent Overstreet Cc: Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Wed, Aug 31, 2022 at 12:02 PM Kent Overstreet wrote: > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > Whatever asking for an explanation as to why equivalent functionality > > > cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > > > > Fully agreed and this is especially true for a change this size > > 77 files changed, 3406 insertions(+), 703 deletions(-) > > In the case of memory allocation accounting, you flat cannot do this with ftrace > - you could maybe do a janky version that isn't fully accurate, much slower, > more complicated for the developer to understand and debug and more complicated > for the end user. > > But please, I invite anyone who's actually been doing this with ftrace to > demonstrate otherwise. > > Ftrace just isn't the right tool for the job here - we're talking about adding > per callsite accounting to some of the fastest fast paths in the kernel. > > And the size of the changes for memory allocation accounting are much more > reasonable: > 33 files changed, 623 insertions(+), 99 deletions(-) > > The code tagging library should exist anyways, it's been open coded half a dozen > times in the kernel already. > > And once we've got that, the time stats code is _also_ far simpler than doing it > with ftrace would be. If anyone here has successfully debugged latency issues > with ftrace, I'd really like to hear it. Again, for debugging latency issues you > want something that can always be on, and that's not cheap with ftrace - and > never mind the hassle of correlating start and end wait trace events, builting > up histograms, etc. - that's all handled here. > > Cheap, simple, easy to use. What more could you want? > This is very interesting work! Do you have any data about the overhead this introduces, especially in a production environment? I am especially interested in memory allocations tracking and detecting leaks. (Sorry if you already posted this kind of data somewhere that I missed) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 06:11:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 06:11:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396216.636278 (Exim 4.92) (envelope-from ) id 1oTdQ7-0003Eb-Jb; Thu, 01 Sep 2022 06:11:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396216.636278; Thu, 01 Sep 2022 06:11:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTdQ7-0003EU-GH; Thu, 01 Sep 2022 06:11:19 +0000 Received: by outflank-mailman (input) for mailman id 396216; Thu, 01 Sep 2022 06:11:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTdQ5-0003EO-Nl for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 06:11:17 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1ec7e6b-29bc-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 08:11:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 85EDA2220C; Thu, 1 Sep 2022 06:11:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3CBB813316; Thu, 1 Sep 2022 06:11:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8pIuDQNNEGOzFgAAMHmgww (envelope-from ); Thu, 01 Sep 2022 06:11:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1ec7e6b-29bc-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662012675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VwjjEEWAmElauXQdmYGb6IgD2uIj2ZCJy8zgBooVDS0=; b=BLuvu2/+KDFypumEfAm+6++gOqXyzbDQLToURHouElPTocYbazdQZKpnRQt+UI1e9zIcTZ kgZJ0fw/8aI2hwOBXgp1N3g35nZcjCv6uIhhpy7OiVuffLAKw6T5c9xOqUAgluyV0bFRvt U+8DaXUTQupfLDonBLPIvlcE9Z1QS6Q= Message-ID: <94576d45-39c2-a786-2fe2-5effb16caf68@suse.com> Date: Thu, 1 Sep 2022 08:11:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-4-jgross@suse.com> <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> From: Juergen Gross Subject: Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug In-Reply-To: <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------iD8FTriwzHoF0WFS9Mgi5KHi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------iD8FTriwzHoF0WFS9Mgi5KHi Content-Type: multipart/mixed; boundary="------------YWTmxJ1cljQfebUQjAm5lWlk"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich Message-ID: <94576d45-39c2-a786-2fe2-5effb16caf68@suse.com> Subject: Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-4-jgross@suse.com> <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> In-Reply-To: <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> --------------YWTmxJ1cljQfebUQjAm5lWlk Content-Type: multipart/mixed; boundary="------------nKkNO7wJwbBBjIG6dh3OuPqV" --------------nKkNO7wJwbBBjIG6dh3OuPqV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDkuMjIgMDA6NTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDE2LzA4LzIw MjIgMTE6MTMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBDcHUgY3B1IHVucGx1Z2dpbmcg aXMgY2FsbGluZyBzY2hlZHVsZV9jcHVfcm0oKSB2aWEgc3RvcF9tYWNoaW5lX3J1bigpDQo+ IA0KPiBDcHUgY3B1Lg0KPiANCj4+IHdpdGggaW50ZXJydXB0cyBkaXNhYmxlZCwgdGh1cyBh bnkgbWVtb3J5IGFsbG9jYXRpb24gb3IgZnJlZWluZyBtdXN0DQo+PiBiZSBhdm9pZGVkLg0K Pj4NCj4+IFNpbmNlIGNvbW1pdCA1MDQ3Y2QxZDVkZWEgKCJ4ZW4vY29tbW9uOiBVc2UgZW5o YW5jZWQNCj4+IEFTU0VSVF9BTExPQ19DT05URVhUIGluIHhtYWxsb2MoKSIpIHRoaXMgcmVz dHJpY3Rpb24gaXMgYmVpbmcgZW5mb3JjZWQNCj4+IHZpYSBhbiBhc3NlcnRpb24sIHdoaWNo IHdpbGwgbm93IGZhaWwuDQo+Pg0KPj4gQmVmb3JlIHRoYXQgY29tbWl0IGNwdSB1bnBsdWdn aW5nIGluIG5vcm1hbCBjb25maWd1cmF0aW9ucyB3YXMgd29ya2luZw0KPj4ganVzdCBieSBj aGFuY2UgYXMgb25seSB0aGUgY3B1IHBlcmZvcm1pbmcgc2NoZWR1bGVfY3B1X3JtKCkgd2Fz IGRvaW5nDQo+PiBhY3RpdmUgd29yay4gV2l0aCBjb3JlIHNjaGVkdWxpbmcgZW5hYmxlZCwg aG93ZXZlciwgZmFpbHVyZXMgY291bGQNCj4+IHJlc3VsdCBmcm9tIG1lbW9yeSBhbGxvY2F0 aW9ucyBub3QgYmVpbmcgcHJvcGVybHkgcHJvcGFnYXRlZCB0byBvdGhlcg0KPj4gY3B1cycg VExCcy4NCj4gDQo+IFRoaXMgaXNuJ3QgYWNjdXJhdGUsIGlzIGl0P8KgIFRoZSBwcm9ibGVt IHdpdGggaW5pdGlhdGluZyBhIFRMQiBmbHVzaA0KPiB3aXRoIElSUXMgZGlzYWJsZWQgaXMg dGhhdCB5b3UgY2FuIGRlYWRsb2NrIGFnYWluc3QgYSByZW1vdGUgQ1BVIHdoaWNoDQo+IGlz IHdhaXRpbmcgZm9yIHlvdSB0byBlbmFibGUgSVJRcyBmaXJzdCB0byB0YWtlIGEgVExCIGZs dXNoIElQSS4NCg0KQXMgbG9uZyBhcyBvbmx5IG9uZSBjcHUgaXMgdHJ5aW5nIHRvIGFsbG9j YXRlL2ZyZWUgbWVtb3J5IGR1cmluZyB0aGUNCnN0b3BfbWFjaGluZV9ydW4oKSBhY3Rpb24g dGhlIGRlYWRsb2NrIHdvbid0IGhhcHBlbi4NCg0KPiBIb3cgZG9lcyBhIG1lbW9yeSBhbGxv Y2F0aW9uIG91dCBvZiB0aGUgeGVuaGVhcCByZXN1bHQgaW4gYSBUTEIgZmx1c2g/DQo+IEV2 ZW4gd2l0aCBzcGxpdCBoZWFwcywgeW91J3JlIG9ubHkgcG90ZW50aWFsbHkgYWxsb2NhdGlu ZyBpbnRvIGEgbmV3DQo+IHNsb3Qgd2hpY2ggd2FzIHVudXNlZC4uLg0KDQpZZWFoLCB5b3Ug YXJlIHJpZ2h0LiBUaGUgbWFpbiBwcm9ibGVtIHdvdWxkIG9jY3VyIG9ubHkgd2hlbiBhIHZp cnR1YWwNCmFkZHJlc3MgaXMgY2hhbmdlZCB0byBwb2ludCBhdCBhbm90aGVyIHBoeXNpY2Fs IGFkZHJlc3MsIHdoaWNoIHNob3VsZCBiZQ0KcXVpdGUgdW5saWtlbHkuDQoNCkkgY2FuIGRy b3AgdGhhdCBwYXJhZ3JhcGgsIGFzIGl0IGRvZXNuJ3QgcmVhbGx5IGhlbHAuDQoNCj4gDQo+ PiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMgYi94ZW4vY29tbW9uL3Nj aGVkL2NvcmUuYw0KPj4gaW5kZXggMjI4NDcwYWM0MS4uZmZiMmQ2MjAyYiAxMDA2NDQNCj4+ IC0tLSBhL3hlbi9jb21tb24vc2NoZWQvY29yZS5jDQo+PiArKysgYi94ZW4vY29tbW9uL3Nj aGVkL2NvcmUuYw0KPj4gQEAgLTMyNjAsNiArMzI2MCwxNyBAQCBzdGF0aWMgc3RydWN0IGNw dV9ybV9kYXRhICpzY2hlZHVsZV9jcHVfcm1fYWxsb2ModW5zaWduZWQgaW50IGNwdSkNCj4+ ICAgICAgIGlmICggIWRhdGEgKQ0KPj4gICAgICAgICAgIGdvdG8gb3V0Ow0KPj4gICANCj4+ ICsgICAgaWYgKCBhZmZfYWxsb2MgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBpZiAoICF1 cGRhdGVfbm9kZV9hZmZfYWxsb2MoJmRhdGEtPmFmZmluaXR5KSApDQo+IA0KPiBJIHNwZW50 IGFnZXMgdHJ5aW5nIHRvIGZpZ3VyZSBvdXQgd2hhdCB0aGlzIHdhcyBkb2luZywgYmVmb3Jl IHJlYWxpc2luZw0KPiB0aGUgcHJvYmxlbSBpcyB0aGUgZnVuY3Rpb24gbmFtZS4NCj4gDQo+ IGFsbG9jIChhcyB3aXRoIGZyZWUpIGlzIHRoZSBjcml0aWNhbCBwaWVjZSBvZiBpbmZvcm1h dGlvbiBhbmQgbmVlZHMgdG8NCj4gY29tZSBmaXJzdC7CoCBUaGUgZmFjdCB3ZSB0eXBpY2Fs bHkgcGFzcyB0aGUgcmVzdWx0IHRvDQo+IHVwZGF0ZV9ub2RlX2FmZihpbml0eSkgaXNuJ3Qg cmVsZXZhbnQsIGFuZCBiZWNvbWVzIGFjdGl2ZWx5IHdyb25nIGhlcmUNCj4gd2hlbiB3ZSdy ZSBub3doZXJlIG5lYXIuDQo+IA0KPiBQYXRjaCAxIG5lZWRzIHRvIG5hbWUgdGhlc2UgaGVs cGVyczoNCj4gDQo+IGJvb2wgYWxsb2NfYWZmaW5pdHlfbWFza3Moc3RydWN0IGFmZmluaXR5 X21hc2tzICphZmZpbml0eSk7DQo+IHZvaWQgZnJlZV9hZmZpbml0eV9tYXNrcyhzdHJ1Y3Qg YWZmaW5pdHlfbWFza3MgKmFmZmluaXR5KTsNCj4gDQo+IGFuZCB0aGVuIHBhdGNoZXMgMiBh bmQgMyBiZWNvbWUgZmFyIGVhc2llciB0byBmb2xsb3cuDQo+IA0KPiBTaW1pbGFybHkgaW4g cGF0Y2ggMiwgdGhlIG5ldyBoZWxwZXJzIG5lZWQgdG8gYmUNCj4ge2FsbG9jLGZyZWV9X2Nw dV9ybV9kYXRhKCkgdG8gbWFrZSBzZW5zZS7CoCBUaGVzZSBoYXZlIG5vdGhpbmcgdG8gZG8g d2l0aA0KPiBzY2hlZHVsaW5nLg0KPiANCj4gQWxzbywgeW91IHNob3VsZG4ndCBpbnRyb2R1 Y2UgdGhlIGhlbHBlcnMgc3RhdGljIGluIHBhdGNoIDIgYW5kIHRoZW4NCj4gdHVybiB0aGVt IG5vbi1zdGF0aWMgaW4gcGF0Y2ggMy7CoCBUaGF0IGp1c3QgYWRkcyB1bm5lY2Vzc2FyeSBj aHVybiB0bw0KPiB0aGUgY29tcGxpY2F0ZWQgcGF0Y2guDQoNCk9rYXkgdG8gYWxsIG9mIGFi b3ZlLg0KDQo+IA0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIFhGUkVFKGRhdGEp Ow0KPj4gKyAgICAgICAgICAgIGdvdG8gb3V0Ow0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICB9 DQo+PiArICAgIGVsc2UNCj4+ICsgICAgICAgIG1lbXNldCgmZGF0YS0+YWZmaW5pdHksIDAs IHNpemVvZihkYXRhLT5hZmZpbml0eSkpOw0KPiANCj4gSSBob25lc3RseSBkb24ndCB0aGlu ayBpdCBpcyB3b3J0aCBvcHRpbWlzaW5nIHh6YWxsb2MoKSAtPiB4bWFsbG9jKCkNCj4gZm9y IHRoZSBjb2duaXRpdmUgY29tcGxleGl0eSBvZiBoYXZpbmcgdGhpcyBsb2dpYyBoZXJlLg0K DQpJIGRvbid0IG1pbmQgZWl0aGVyIHdheS4gVGhpcyBsb2dpYyBpcyB0aGUgcmVzdWx0IG9m IG9uZSBvZiBKYW4ncyBjb21tZW50cy4NCg0KPiANCj4+IGRpZmYgLS1naXQgYS94ZW4vY29t bW9uL3NjaGVkL2NwdXBvb2wuYyBiL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jDQo+PiBp bmRleCA1OGUwODJlYjRjLi4yNTA2ODYxZTRmIDEwMDY0NA0KPj4gLS0tIGEveGVuL2NvbW1v bi9zY2hlZC9jcHVwb29sLmMNCj4+ICsrKyBiL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5j DQo+PiBAQCAtNDExLDIyICs0MTEsMjggQEAgaW50IGNwdXBvb2xfbW92ZV9kb21haW4oc3Ry dWN0IGRvbWFpbiAqZCwgc3RydWN0IGNwdXBvb2wgKmMpDQo+PiAgIH0NCj4+ICAgDQo+PiAg IC8qIFVwZGF0ZSBhZmZpbml0aWVzIG9mIGFsbCBkb21haW5zIGluIGEgY3B1cG9vbC4gKi8N Cj4+IC1zdGF0aWMgdm9pZCBjcHVwb29sX3VwZGF0ZV9ub2RlX2FmZmluaXR5KGNvbnN0IHN0 cnVjdCBjcHVwb29sICpjKQ0KPj4gK3N0YXRpYyB2b2lkIGNwdXBvb2xfdXBkYXRlX25vZGVf YWZmaW5pdHkoY29uc3Qgc3RydWN0IGNwdXBvb2wgKmMsDQo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgYWZmaW5pdHlfbWFza3MgKm1hc2tz KQ0KPj4gICB7DQo+PiAtICAgIHN0cnVjdCBhZmZpbml0eV9tYXNrcyBtYXNrczsNCj4+ICsg ICAgc3RydWN0IGFmZmluaXR5X21hc2tzIGxvY2FsX21hc2tzOw0KPj4gICAgICAgc3RydWN0 IGRvbWFpbiAqZDsNCj4+ICAgDQo+PiAtICAgIGlmICggIXVwZGF0ZV9ub2RlX2FmZl9hbGxv YygmbWFza3MpICkNCj4+IC0gICAgICAgIHJldHVybjsNCj4+ICsgICAgaWYgKCAhbWFza3Mg KQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBpZiAoICF1cGRhdGVfbm9kZV9hZmZfYWxsb2Mo JmxvY2FsX21hc2tzKSApDQo+PiArICAgICAgICAgICAgcmV0dXJuOw0KPj4gKyAgICAgICAg bWFza3MgPSAmbG9jYWxfbWFza3M7DQo+PiArICAgIH0NCj4+ICAgDQo+PiAgICAgICByY3Vf cmVhZF9sb2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+PiAgIA0KPj4gICAgICAgZm9yX2Vh Y2hfZG9tYWluX2luX2NwdXBvb2woZCwgYykNCj4+IC0gICAgICAgIGRvbWFpbl91cGRhdGVf bm9kZV9hZmYoZCwgJm1hc2tzKTsNCj4+ICsgICAgICAgIGRvbWFpbl91cGRhdGVfbm9kZV9h ZmYoZCwgbWFza3MpOw0KPj4gICANCj4+ICAgICAgIHJjdV9yZWFkX3VubG9jaygmZG9tbGlz dF9yZWFkX2xvY2spOw0KPj4gICANCj4+IC0gICAgdXBkYXRlX25vZGVfYWZmX2ZyZWUoJm1h c2tzKTsNCj4+ICsgICAgaWYgKCBtYXNrcyA9PSAmbG9jYWxfbWFza3MgKQ0KPj4gKyAgICAg ICAgdXBkYXRlX25vZGVfYWZmX2ZyZWUobWFza3MpOw0KPj4gICB9DQo+PiAgIA0KPj4gICAv Kg0KPiANCj4gV2h5IGRvIHdlIG5lZWQgdGhpcyBhdCBhbGw/wqAgZG9tYWluX3VwZGF0ZV9u b2RlX2FmZigpIGFscmVhZHkga25vd3Mgd2hhdA0KPiB0byBkbyB3aGVuIHBhc3NlZCBOVUxM LCBzbyB0aGlzIHNlZW1zIGxpa2UgYW4gYXdmdWxseSBjb21wbGljYXRlZCBuby1vcC4NCg0K WW91IGRvIHJlYWxpemUgdGhhdCB1cGRhdGVfbm9kZV9hZmZfZnJlZSgpIHdpbGwgZG8gc29t ZXRoaW5nIGluIGNhc2UgbWFza3MNCndhcyBpbml0aWFsbHkgTlVMTD8NCg0KPiANCj4+IEBA IC0xMDA4LDEwICsxMDE2LDIxIEBAIHN0YXRpYyBpbnQgY2ZfY2hlY2sgY3B1X2NhbGxiYWNr KA0KPj4gICB7DQo+PiAgICAgICB1bnNpZ25lZCBpbnQgY3B1ID0gKHVuc2lnbmVkIGxvbmcp aGNwdTsNCj4+ICAgICAgIGludCByYyA9IDA7DQo+PiArICAgIHN0YXRpYyBzdHJ1Y3QgY3B1 X3JtX2RhdGEgKm1lbTsNCj4+ICAgDQo+PiAgICAgICBzd2l0Y2ggKCBhY3Rpb24gKQ0KPj4g ICAgICAgew0KPj4gICAgICAgY2FzZSBDUFVfRE9XTl9GQUlMRUQ6DQo+PiArICAgICAgICBp ZiAoIHN5c3RlbV9zdGF0ZSA8PSBTWVNfU1RBVEVfYWN0aXZlICkNCj4+ICsgICAgICAgIHsN Cj4+ICsgICAgICAgICAgICBpZiAoIG1lbSApDQo+PiArICAgICAgICAgICAgew0KPiANCj4g U28sIHRoaXMgZG9lcyBjb21waWxlIChhbmQgaW5kZWVkIEkndmUgdGVzdGVkIHRoZSByZXN1 bHQpLCBidXQgSSBjYW4ndA0KPiBzZWUgaG93IGl0IHNob3VsZC4NCj4gDQo+IG1lbSBpcyBn dWFyYW50ZWVkIHRvIGJlIHVuaW5pdGlhbGlzZWQgYXQgdGhpcyBwb2ludCwgYW5kIC4uLg0K DQouLi4gaXQgaXMgZGVmaW5lZCBhcyAic3RhdGljIiwgc28gaXQgaXMgY2xlYXJseSBOVUxM IGluaXRpYWxseS4NCg0KPiANCj4+ICsgICAgICAgICAgICAgICAgc2NoZWR1bGVfY3B1X3Jt X2ZyZWUobWVtLCBjcHUpOw0KPj4gKyAgICAgICAgICAgICAgICBtZW0gPSBOVUxMOw0KPj4g KyAgICAgICAgICAgIH0NCj4+ICsgICAgICAgICAgICByYyA9IGNwdXBvb2xfY3B1X2FkZChj cHUpOw0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiAgICAgICBjYXNl IENQVV9PTkxJTkU6DQo+PiAgICAgICAgICAgaWYgKCBzeXN0ZW1fc3RhdGUgPD0gU1lTX1NU QVRFX2FjdGl2ZSApDQo+PiAgICAgICAgICAgICAgIHJjID0gY3B1cG9vbF9jcHVfYWRkKGNw dSk7DQo+PiBAQCAtMTAxOSwxMiArMTAzOCwzMSBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIGNw dV9jYWxsYmFjaygNCj4+ICAgICAgIGNhc2UgQ1BVX0RPV05fUFJFUEFSRToNCj4+ICAgICAg ICAgICAvKiBTdXNwZW5kL1Jlc3VtZSBkb24ndCBjaGFuZ2UgYXNzaWdubWVudHMgb2YgY3B1 cyB0byBjcHVwb29scy4gKi8NCj4+ICAgICAgICAgICBpZiAoIHN5c3RlbV9zdGF0ZSA8PSBT WVNfU1RBVEVfYWN0aXZlICkNCj4+ICsgICAgICAgIHsNCj4+ICAgICAgICAgICAgICAgcmMg PSBjcHVwb29sX2NwdV9yZW1vdmVfcHJvbG9ndWUoY3B1KTsNCj4+ICsgICAgICAgICAgICBp ZiAoICFyYyApDQo+PiArICAgICAgICAgICAgew0KPj4gKyAgICAgICAgICAgICAgICBBU1NF UlQoIW1lbSk7DQo+IA0KPiAuLi4gaGVyZSwgYW5kIGVhY2ggc3Vic2VxdWVudCBhc3NlcnRp b24gdG9vLg0KPiANCj4gR2l2ZW4gdGhhdCBJIHRlc3RlZCB0aGUgcGF0Y2ggYW5kIGl0IGRv ZXMgZml4IHRoZSBJUlEgYXNzZXJ0aW9uLCBJIGNhbg0KPiBvbmx5IGltYWdpbmUgdGhhdCBp dCB3b3JrcyBieSBkZXRlcm1pbmlzdGljYWxseSBmaW5kaW5nIHN0YWNrIHJ1YmJsZQ0KPiB3 aGljaCBoYXBwZW5zIHRvIGJlIDAuDQoNCk5vdCByZWFsbHksIGFzIG1lbSBpc24ndCBvbiB0 aGUgc3RhY2suIDotKQ0KDQoNCkp1ZXJnZW4NCg== --------------nKkNO7wJwbBBjIG6dh3OuPqV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------nKkNO7wJwbBBjIG6dh3OuPqV-- --------------YWTmxJ1cljQfebUQjAm5lWlk-- --------------iD8FTriwzHoF0WFS9Mgi5KHi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMQTQIFAwAAAAAACgkQsN6d1ii/Ey+l IAf/f2QOgi6jLDcwLuIFyWAgb0wgX+ZrlMJ/GZow4dOX1n60rf+blnNTbCzKfjHZV6v7n2aGN0l3 qNitUdamy/o6WKgE6toUiw7d0lLlsGfVrjP/KczrAFue9b6Vy5EFpGRQndhOTKf+kPoD2MU7l6ns HGNqdUMHzcjZQOPmjnjEe2MlD7L58NpqDkPeP4Sc16maf5prdCNhuaDHmXwZdY/DEN/yAb4D/A0T nkWAGn4nEn94c8N41XA3AURxQAwPcf/HKZOSAa6vsb7JUO/LdiGdLmVp+CoYJ/Fn2tjykMCC3/Iu NRe8l5Jvwh9iX7hetHvfwdlZ0BpSegyobQ4jytO7Bw== =9PwV -----END PGP SIGNATURE----- --------------iD8FTriwzHoF0WFS9Mgi5KHi-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 06:29:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 06:29:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396224.636289 (Exim 4.92) (envelope-from ) id 1oTdhH-0004rk-6H; Thu, 01 Sep 2022 06:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396224.636289; Thu, 01 Sep 2022 06:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTdhH-0004rd-3G; Thu, 01 Sep 2022 06:29:03 +0000 Received: by outflank-mailman (input) for mailman id 396224; Thu, 01 Sep 2022 06:29:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTdhF-0004rS-7J for xen-devel@lists.xen.org; Thu, 01 Sep 2022 06:29:01 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5bbf93fc-29bf-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 08:28:57 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C7F551FAA9; Thu, 1 Sep 2022 06:28:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 65B9F13316; Thu, 1 Sep 2022 06:28:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id X71PFypREGMJHgAAMHmgww (envelope-from ); Thu, 01 Sep 2022 06:28:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bbf93fc-29bf-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662013738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OlY9nmK3diDQwat6lv3sfUDYuceybSJWubnvy/ap0OM=; b=KyMWIyJuSJcVBd4DBC/89MwCEUCJq04rNGyDEIg/Gsv2UmekFS/41I/ou7mUjFt8iUlUXq csWNlPb+zME6OVXdFDRolze+qrfPmPi8RKNMzDOCaX79M0C1pPUvEhjv+uLQpJsIshP7Ix rNE8Df6hRTg72mPg/3Ygu1i2ubuzbww= Message-ID: <69ef73a8-ecfd-4163-19a6-bc74e2e15711@suse.com> Date: Thu, 1 Sep 2022 08:28:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: Understanding osdep_xenforeignmemory_map mmap behaviour Content-Language: en-US To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: Andrew Cooper , Viresh Kumar , Stefano Stabellini , "xen-devel@lists.xen.org" , "Stratos-dev@op-lists.linaro.org" , "mathieu.poirier@linaro.com" , "christopher.w.clark@gmail.com" , "boris.ostrovsky@oracle.com" , "gregkh@linuxfoundation.org" , "vincent.guittot@linaro.org" , "olekstysh@gmail.com" References: <57549560-879d-f705-8693-9bfdc73e3f7f@suse.com> <20220824091918.szrd6e6ll6h6u2pw@vireshk-i7> <63eecf7a-aa69-28bf-9664-8ee8554a161f@citrix.com> <877d2xj23o.fsf@linaro.org> <87y1vdh9or.fsf@linaro.org> <9697a559-fe42-3efb-5715-1f6bc631f57d@suse.com> <875yi8pfhc.fsf@linaro.org> From: Juergen Gross In-Reply-To: <875yi8pfhc.fsf@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------7ii8U7UcB0T0rKiGWIa0mw0W" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------7ii8U7UcB0T0rKiGWIa0mw0W Content-Type: multipart/mixed; boundary="------------clnhdyorXixPgreZBK3F8k99"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: Andrew Cooper , Viresh Kumar , Stefano Stabellini , "xen-devel@lists.xen.org" , "Stratos-dev@op-lists.linaro.org" , "mathieu.poirier@linaro.com" , "christopher.w.clark@gmail.com" , "boris.ostrovsky@oracle.com" , "gregkh@linuxfoundation.org" , "vincent.guittot@linaro.org" , "olekstysh@gmail.com" Message-ID: <69ef73a8-ecfd-4163-19a6-bc74e2e15711@suse.com> Subject: Re: Understanding osdep_xenforeignmemory_map mmap behaviour References: <57549560-879d-f705-8693-9bfdc73e3f7f@suse.com> <20220824091918.szrd6e6ll6h6u2pw@vireshk-i7> <63eecf7a-aa69-28bf-9664-8ee8554a161f@citrix.com> <877d2xj23o.fsf@linaro.org> <87y1vdh9or.fsf@linaro.org> <9697a559-fe42-3efb-5715-1f6bc631f57d@suse.com> <875yi8pfhc.fsf@linaro.org> In-Reply-To: <875yi8pfhc.fsf@linaro.org> --------------clnhdyorXixPgreZBK3F8k99 Content-Type: multipart/mixed; boundary="------------kLVUhaep4LdBLZwdlKRDD324" --------------kLVUhaep4LdBLZwdlKRDD324 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzEuMDguMjIgMTg6MDIsIEFsZXggQmVubsOpZSB3cm90ZToNCj4gDQo+IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4gd3JpdGVzOg0KPiANCj4+IFtbUEdQIFNpZ25lZCBQ YXJ0OlVuZGVjaWRlZF1dDQo+PiBPbiAyNC4wOC4yMiAxNzo1OCwgQWxleCBCZW5uw6llIHdy b3RlOg0KPj4+IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4gd3JpdGVzOg0KPj4+ DQo+Pj4+IFtbUEdQIFNpZ25lZCBQYXJ0OlVuZGVjaWRlZF1dDQo+Pj4+IE9uIDI0LjA4LjIy IDEzOjIyLCBBbGV4IEJlbm7DqWUgd3JvdGU6DQo+Pj4+PiBBbmRyZXcgQ29vcGVyIDxBbmRy ZXcuQ29vcGVyM0BjaXRyaXguY29tPiB3cml0ZXM6DQo+Pj4+Pg0KPj4+Pj4+IE9uIDI0LzA4 LzIwMjIgMTA6MTksIFZpcmVzaCBLdW1hciB3cm90ZToNCj4+Pj4+Pj4gT24gMjQtMDMtMjIs IDA2OjEyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+Pj4gRm9yIGEgcmF0aGVyIGxv bmcgdGltZSB3ZSB3ZXJlIHVzaW5nICJub3JtYWwiIHVzZXIgcGFnZXMgZm9yIHRoaXMgcHVy cG9zZSwNCj4+Pj4+Pj4+IHdoaWNoIHdlcmUganVzdCBsb2NrZWQgaW50byBtZW1vcnkgZm9y IGRvaW5nIHRoZSBoeXBlcmNhbGwuDQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4gVW5mb3J0dW5hdGVs eSB0aGVyZSBoYXZlIGJlZW4gdmVyeSByYXJlIHByb2JsZW1zIHdpdGggdGhhdCBhcHByb2Fj aCwgYXMNCj4+Pj4+Pj4+IHRoZSBMaW51eCBrZXJuZWwgY2FuIHNldCBhIHVzZXIgcGFnZSBy ZWxhdGVkIFBURSB0byBpbnZhbGlkIGZvciBzaG9ydA0KPj4+Pj4+Pj4gcGVyaW9kcyBvZiB0 aW1lLCB3aGljaCBsZWQgdG8gRUZBVUxUIGluIHRoZSBoeXBlcnZpc29yIHdoZW4gdHJ5aW5n IHRvDQo+Pj4+Pj4+PiBhY2Nlc3MgdGhlIGh5cGVyY2FsbCBkYXRhLg0KPj4+Pj4+Pj4NCj4+ Pj4+Pj4+IEluIExpbnV4IHRoaXMgY2FuIGF2b2lkZWQgb25seSBieSB1c2luZyBrZXJuZWwg bWVtb3J5LCB3aGljaCBpcyB0aGUNCj4+Pj4+Pj4+IHJlYXNvbiB3aHkgdGhlIGh5cGVyY2Fs bCBidWZmZXJzIGFyZSBhbGxvY2F0ZWQgYW5kIG1tYXAoKS1lZCB0aHJvdWdoIHRoZQ0KPj4+ Pj4+Pj4gcHJpdmNtZCBkcml2ZXIuDQo+Pj4+Pj4+IEhpIEp1ZXJnZW4sDQo+Pj4+Pj4+DQo+ Pj4+Pj4+IEkgdW5kZXJzdGFuZCB3aHkgd2UgbW92ZWQgZnJvbSB1c2VyIHBhZ2VzIHRvIGtl cm5lbCBwYWdlcywgYnV0IEkgZG9uJ3QNCj4+Pj4+Pj4gZnVsbHkgdW5kZXJzdGFuZCB3aHkg d2UgbmVlZCB0byBtYWtlIHR3byBzZXBhcmF0ZSBjYWxscyB0byBtYXAgdGhlDQo+Pj4+Pj4+ IGd1ZXN0IG1lbW9yeSwgaS5lLiBtbWFwKCkgZm9sbG93ZWQgYnkgaW9jdGwoSU9DVExfUFJJ VkNNRF9NTUFQQkFUQ0gpLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBXaHkgYXJlbid0IHdlIGRvaW5n IGFsbCBvZiBpdCBmcm9tIG1tYXAoKSBpdHNlbGYgPyBJIGhhY2tlZCBpdCB1cCB0bw0KPj4+ Pj4+PiBjaGVjayBvbiBpdCBhbmQgaXQgd29ya3MgZmluZSBpZiB3ZSBkbyBpdCBhbGwgZnJv bSBtbWFwKCkgaXRzZWxmLg0KPj4+Pj4gQXMgSSB1bmRlcnN0YW5kIGl0IHRoZSBNTUFQQkFU Q0ggaW9jdGwgaXMgYmVpbmcgdHJlYXRlZCBsaWtlIGV2ZXJ5DQo+Pj4+PiBvdGhlcg0KPj4+ Pj4gaHlwZXJjYWxsIHByb3h5IHRocm91Z2ggdGhlIGlvY3RsIGludGVyZmFjZS4gV2hpY2gg bWFrZXMgc2Vuc2UgZnJvbSB0aGUNCj4+Pj4+IHBvaW50IG9mIHZpZXcgb2YgaGF2aW5nIGEg Y29uc2lzdGVudCBpbnRlcmZhY2UgdG8gdGhlIGh5cGVydmlzb3IgYnV0IG5vdA0KPj4+Pj4g ZnJvbSBwb2ludCBvZiB2aWV3IG9mIHByb3ZpZGluZyBhIGNvbnNpc3RlbnQgdXNlcnNwYWNl IGludGVyZmFjZSBmb3INCj4+Pj4+IG1hcHBpbmcgbWVtb3J5IHdoaWNoIGRvZXNuJ3QgY2Fy ZSBhYm91dCB0aGUgaHlwZXJ2aXNvciBkZXRhaWxzLg0KPj4+Pj4gVGhlIHByaXZjbWRfbW1h cGJhdGNoX3YyIGludGVyZmFjZSBpcyBzbGlnaHRseSByaWNoZXIgdGhhbiB3aGF0IHlvdQ0K Pj4+Pj4gY291bGQgZXhwb3NlIHZpYSBtbWFwKCkgYmVjYXVzZSBpdCBhbGxvd3MgdGhlIGhh bmRsaW5nIG9mIHBhcnRpYWwNCj4+Pj4+IG1hcHBpbmdzIHdpdGggd2hhdCBJIHByZXN1bWUg aXMgYSBwZXItcGFnZSAqZXJyIGFycmF5LiBJZiB5b3UgaXNzdWVkIHRoZQ0KPj4+Pj4gaHlw ZXJjYWxsIGRpcmVjdGx5IGZyb20gdGhlIG1tYXAoKSBhbmQgb25lIG9mIHRoZSBwYWdlcyB3 YXNuJ3QgbWFwcGVkIGJ5DQo+Pj4+PiB0aGUgaHlwZXJ2aXNvciB5b3Ugd291bGQgaGF2ZSB0 byB1bndpbmQgZXZlcnl0aGluZyBiZWZvcmUgcmV0dXJuaW5nDQo+Pj4+PiBFRkFVTFQgdG8g dGhlIHVzZXIuDQo+Pj4+Pg0KPj4+Pj4+PiBBcmVuJ3Qgd2UgYWJ1c2luZyB0aGUgTGludXgg dXNlcnNwYWNlIEFCSSBoZXJlID8gQXMgc3RhbmRhcmQgdXNlcnNwYWNlDQo+Pj4+Pj4+IGNv ZGUgd291bGQgZXhwZWN0IGp1c3QgbW1hcCgpIHRvIGJlIGVub3VnaCB0byBtYXAgdGhlIG1l bW9yeS4gWWVzLCB0aGUNCj4+Pj4+Pj4gY3VycmVudCB1c2VyLCBYZW4gaXRzZWxmLCBpcyBh ZGFwdGVkIHRvIG1ha2UgdHdvIGNhbGxzLCBidXQgaXQgYnJlYWtzDQo+Pj4+Pj4+IGFzIHNv b24gYXMgd2Ugd2FudCB0byB1c2Ugc29tZXRoaW5nIHRoYXQgcmVsaWVzIG9uIExpbnV4IHVz ZXJzcGFjZQ0KPj4+Pj4+PiBBQkkuDQo+Pj4+Pj4+DQo+Pj4+Pj4+IEZvciBpbnN0YW5jZSwg aW4gb3VyIGNhc2UsIHdoZXJlIHdlIGFyZSBsb29raW5nIHRvIGNyZWF0ZQ0KPj4+Pj4+PiBo eXBlcnZpc29yLWFnbm9zdGljIHZpcnRpbyBiYWNrZW5kcywgdGhlIHJ1c3Qtdm1tIGxpYnJh cnkgWzFdIGlzc3Vlcw0KPj4+Pj4+PiBtbWFwKCkgb25seSBhbmQgZXhwZWN0cyBpdCB0byB3 b3JrLiBJdCBkb2Vzbid0IGtub3cgaXQgaXMgcnVubmluZyBvbiBhDQo+Pj4+Pj4+IFhlbiBz eXN0ZW0sIGFuZCBpdCBzaG91bGRuJ3Qga25vdyB0aGF0IGFzIHdlbGwuDQo+Pj4+Pj4NCj4+ Pj4+PiBVc2UgL2Rldi94ZW4vaHlwZXJjYWxsIHdoaWNoIGhhcyBhIHNhbmUgQUJJIGZvciBn ZXR0aW5nICJzYWZlIiBtZW1vcnkuDQo+Pj4+Pj4gcHJpdmNtZCBpcyB2ZXJ5IG11Y2ggbm90 IHNhbmUuDQo+Pj4+Pj4NCj4+Pj4+PiBJbiBwcmFjdGljZSB5b3UnbGwgbmVlZCB0byB1c2Ug Ym90aC7CoCAvZGV2L3hlbi9oeXBlcmNhbGwgZm9yIGdldHRpbmcNCj4+Pj4+PiAic2FmZSIg bWVtb3J5LCBhbmQgL2Rldi94ZW4vcHJpdmNtZCBmb3IgaXNzdWluZyBoeXBlcmNhbGxzIGZv ciBub3cuDQo+Pj4+PiBJJ20gdW5zdXJlIHdoYXQgaXMgbWVhbnQgYnkgc2FmZSBtZW1vcnkg aGVyZS4gcHJpdmNtZF9idWZfbW1hcCgpDQo+Pj4+PiBsb29rcw0KPj4+Pj4gbGlrZSBpdCBq dXN0IGFsbG9jYXRlcyBhIGJ1bmNoIG9mIEdGUF9LRVJORUwgcGFnZXMgcmF0aGVyIHRoYW4N Cj4+Pj4+IGludGVyYWN0aW5nIHdpdGggdGhlIGh5cGVydmlzb3IgZGlyZWN0bHkuIEFyZSB0 aGVzZSB0aGUgc2FtZSBwYWdlcyB0aGF0DQo+Pj4+PiBnZXQgdXNlZCB3aGVuIHlvdSBldmVu dHVhbGx5IGNhbGwgcHJpdmNtZF9pb2N0bF9tbWFwX2JhdGNoKCk/DQo+Pj4+DQo+Pj4+IHBy aXZjbWRfYnVmX21tYXAoKSBpcyBhbGxvY2F0aW5nIGtlcm5lbCBwYWdlcyB3aGljaCBhcmUg dXNlZCBmb3IgZGF0YSBiZWluZw0KPj4+PiBhY2Nlc3NlZCBieSB0aGUgaHlwZXJ2aXNvciB3 aGVuIGRvaW5nIHRoZSBoeXBlcmNhbGwgbGF0ZXIuIFRoaXMgaXMgYSBnZW5lcmljDQo+Pj4+ IGludGVyZmFjZSBiZWluZyB1c2VkIGZvciBhbGwgaHlwZXJjYWxscywgbm90IG9ubHkgZm9y DQo+Pj4+IHByaXZjbWRfaW9jdGxfbW1hcF9iYXRjaCgpLg0KPj4+Pg0KPj4+Pj4gVGhlIGZh Y3QgdGhhdCAvZGV2L3hlbi9oeXBlcmNhbGwgaXMgc3BlY2lmaWVkIGJ5IHhlbl9wcml2Y21k YnVmX2RldiBpcyBhDQo+Pj4+PiBsaXR0bGUgY29uZnVzaW5nIFRCSC4NCj4+Pj4+IEFueXdh eSB0aGUgZ29hbCBoZXJlIGlzIHRvIHByb3ZpZGUgYSBub24teGVuIGF3YXJlIHVzZXJzcGFj ZSB3aXRoDQo+Pj4+PiBzdGFuZGFyZCB1c2Vyc3BhY2UgQVBJIHRvIGFjY2VzcyB0aGUgZ3Vl c3RzIG1lbW9yeS4gUGVyaGFwcyBtZXNzaW5nDQo+Pj4+DQo+Pj4+IFRoaXMgaXMgd2hhdCB0 aGUgWGVuIHJlbGF0ZWQgbGlicmFyaWVzIGFyZSBtZWFudCBmb3IuIFlvdXIgZGVjaXNpb24g dG8NCj4+Pj4gaWdub3JlIHRob3NlIGlzIGZpcmluZyBiYWNrIG5vdy4NCj4+PiBXZSBkaWRu J3QgaWdub3JlIHRoZW0gLSB0aGUgaW5pdGlhbCB2ZXJzaW9uIG9mIHRoZSB4ZW4tdmhvc3Qt bWFzdGVyDQo+Pj4gYmluYXJ5IHdhcyBidWlsdCB3aXRoIHRoZSBydXN0IGFuZCBsaW5raW5n IHRvIHRoZSBYZW4gbGlicmFyaWVzLiBXZSBhcmUNCj4+PiBob3dldmVyIGluIHRoZSBwcm9j ZXNzIG9mIG1vdmluZyB0byBtb3JlIHB1cmUgcnVzdCAod2l0aCB0aGUgeGVuLXN5cw0KPj4+ IGNyYXRlIGJlaW5nIGEgcHVyZSBydXN0IGlvY3RsL2h5cGVyY2FsbCB3cmFwcGVyKS4NCj4+ DQo+PiBBaCwgb2theSwgSSB3YXNuJ3QgYXdhcmUgb2YgdGhpcy4NCj4+DQo+Pj4gSG93ZXZl ciBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGVyZSB3aGVyZSB0d28gY2xhc3NlcyBv Zg0KPj4+IGh5cGVyY2FsbHMuIEFCSSBzdGFibGUgb25lcyB3aGljaCB3b24ndCBjaGFuZ2Ug KHdoaWNoIGlzIGFsbCB3ZSBhcmUNCj4+PiBwbGFubmluZyB0byBpbXBsZW1lbnQgZm9yIHhl bi1zeXMpIGFuZCBub24tc3RhYmxlIEFCSXMgd2hpY2ggd291bGQgbmVlZA0KPj4+IG1lZGlh dGluZyBieSB0aGUgeGVuIGxpYnMuIFdlIGFyZSBob3Bpbmcgd2UgY2FuIGRvIGFsbCBvZiBW aXJ0SU8gd2l0aA0KPj4+IGp1c3QgdGhlIHN0YWJsZSBBQkkuDQo+Pg0KPj4gT2theS4NCj4+ DQo+Pj4NCj4+Pj4+IGFyb3VuZCB3aXRoIHRoZSBzZW1hbnRpY3Mgb2YgdGhlIC9kZXYveGVu L1toeXBlcmNhbGx8cHJpdmNtZF0gZGV2aWNlcw0KPj4+Pj4gbm9kZXMgaXMgdG9vIGNvbmZ1 c2luZy4NCj4+Pj4+IE1heWJlIHdlIGNvdWxkIGluc3RlYWQ6DQo+Pj4+PiAgICAgMS4gSGF2 ZSB0aGUgWGVuIGF3YXJlIFZNTSBhc2sgdG8gbWFrZSB0aGUgZ3Vlc3RzIG1lbW9yeSB2aXNp YmxlIHRvDQo+Pj4+PiB0aGUNCj4+Pj4+ICAgICAgICBob3N0IGtlcm5lbHMgYWRkcmVzcyBz cGFjZS4NCj4+Pj4NCj4+Pj4gVXJnaC4gVGhpcyB3b3VsZCBiZSBhIG1ham9yIGJyZWFjaCBv ZiB0aGUgWGVuIHNlY3VyaXR5IGNvbmNlcHQuDQo+Pj4+DQo+Pj4+PiAgICAgMi4gV2hlbiB0 aGlzIGlzIGRvbmUgZXhwbGljaXRseSBjcmVhdGUgYSBkZXZpY2Ugbm9kZSB0byByZXByZXNl bnQgaXQgKC9kZXYveGVuL2RvbS0lZC1tZW0/KQ0KPj4+Pj4gICAgIDMuIFBhc3MgdGhpcyBu ZXcgZGV2aWNlIHRvIHRoZSBub24tWGVuIGF3YXJlIHVzZXJzcGFjZSB3aGljaCB1c2VzIHRo ZQ0KPj4+Pj4gICAgICAgIHN0YW5kYXJkIG1tYXAoKSBjYWxsIHRvIG1ha2UgdGhlIGtlcm5l bCBwYWdlcyB2aXNpYmxlIHRvIHVzZXJzcGFjZQ0KPj4+Pj4gRG9lcyB0aGF0IG1ha2Ugc2Vu c2U/DQo+Pj4+DQo+Pj4+IE1heWJlIGZyb20geW91ciBwb2ludCBvZiB2aWV3LCBidXQgbm90 IGZyb20gdGhlIFhlbiBhcmNoaXRlY3R1cmFsIHBvaW50DQo+Pj4+IG9mIHZpZXcgSU1ITy4g WW91IGFyZSByZW1vdmluZyBiYXNpY2FsbHkgdGhlIG1haW4gc2VjdXJpdHkgYWR2YW50YWdl cyBvZg0KPj4+PiBYZW4gYnkgZ2VuZXJhdGluZyBhIGtlcm5lbCBpbnRlcmZhY2UgZm9yIG1h cHBpbmcgYXJiaXRyYXJ5IGd1ZXN0IG1lbW9yeQ0KPj4+PiBlYXNpbHkuDQo+Pj4gV2UgYXJl IG5vdCB0YWxraW5nIGFib3V0IGRvaW5nIGFuIGVuZC1ydW4gYXJvdW5kIHRoZSBYZW4NCj4+ PiBhcmNoaXRlY3R1cmUuDQo+Pj4gVGhlIGd1ZXN0IHN0aWxsIGhhcyB0byBpbnN0cnVjdCB0 aGUgaHlwZXJ2aXNvciB0byBncmFudCBhY2Nlc3MgdG8gaXRzDQo+Pj4gbWVtb3J5LiBDdXJy ZW50bHkgdGhpcyBpcyBhIGdsb2JhbCB0aGluZyAoaS5lLiB3aG9sZSBhZGRyZXNzIHNwYWNl IG9yDQo+Pj4gbm90aGluZykgYnV0IG9idmlvdXNseSBtb3JlIGZpbmUgZ3JhaW5lZCBncmFu dHMgY2FuIGJlIGRvbmUgb24gYQ0KPj4+IHRyYW5zYWN0aW9uIGJ5IHRyYW5zYWN0aW9uIGJh c2lzIGFsdGhvdWdoIHdlIGFyZSBleHBsb3JpbmcgbW9yZQ0KPj4+IGVmZmljaWVudCBtZWNo YW5pc21zIGZvciB0aGlzIChzaGFyZWQgcG9vbHMgYW5kIGNhcnZlIG91dHMpLg0KPj4NCj4+ IEhhcHB5IHRvIGhlYXIgdGhhdC4NCj4+DQo+Pj4gVGhpcyBkb2VzIHJhaXNlIHF1ZXN0aW9u cyBmb3IgdGhlIG1tYXAgaW50ZXJmYWNlIHRob3VnaCAtIGVhY2gNCj4+PiBpbmRpdmlkdWFs bHkgZ3JhbnRlZCByZWdpb24gd291bGQgbmVlZCB0byBiZSBtYXBwZWQgaW50byB0aGUgZG9t MA0KPj4+IHVzZXJzcGFjZSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2Ugb3IgcGVyaGFwcyBhIG5l dyBmbGFnIGZvciBtbWFwKCkgc28gd2UNCj4+PiBjYW4gbWFwIHRoZSB3aG9sZSBhZGRyZXNz IHNwYWNlIGJ1dCBleHBlY3QgU0lHQlVTIGZhdWx0cyBpZiB3ZSBhY2Nlc3MNCj4+PiBzb21l dGhpbmcgdGhhdCBoYXNuJ3QgYmVlbiBncmFudGVkLg0KPj4NCj4+IERvIEkgdW5kZXJzdGFu ZCB0aGF0IGNvcnJlY3RseT8gWW91IHdhbnQgdGhlIGd1ZXN0IHRvIGdyYW50IGEgbWVtb3J5 DQo+PiByZWdpb24gdG8gdGhlIGJhY2tlbmQsIGFuZCB0aGUgYmFja2VuZCBzaG91bGQgYmUg YWJsZSB0byBtYXAgdGhpcyByZWdpb24NCj4+IG5vdCB1c2luZyBncmFudHMsIGJ1dCB0aGUg Z3Vlc3QgcGh5c2ljYWwgYWRkcmVzc2VzPw0KPiANCj4gWWVzIC0gYWx0aG91Z2ggaXQgZG9l c24ndCBoYXZlIHRvIGJlIHRoZSB3aG9sZSBHUEEgcmFuZ2UuIFRoZSB2aG9zdC11c2VyDQo+ IHByb3RvY29sIGNvbW11bmljYXRlcyB3aGF0IG9mZnNldCBpbnRvIHRoZSBHUEEgc3BhY2Ug dGhlIHZhcmlvdXMgbWVtb3J5DQo+IHJlZ2lvbnMgZXhpc3QgYXQuDQoNCkhvdyB3b3VsZCB0 aGUgaW50ZXJmYWNlIHdpdGggdGhlIGh5cGVydmlzb3IgbG9vayBsaWtlIHRoZW4/DQoNCklu IG9yZGVyIHRvIG1ha2UgdGhpcyBzZWN1cmUsIHRoZSBoeXBlcnZpc29yIHdvdWxkIG5lZWQg dG8gc2NhbiB0aGUNCmdyYW50IHRhYmxlIG9mIHRoZSBndWVzdCB0byBsb29rIGZvciBhIHBo eXNpY2FsIGFkZHJlc3MgdGhlIGJhY2tlbmQNCndhbnRzIHRvIG1hcC4gSSBkb24ndCB0aGlu ayB0aGlzIGlzIGFuIGFjY2VwdGFibGUgaW50ZXJmYWNlLg0KDQoNCkp1ZXJnZW4NCg== --------------kLVUhaep4LdBLZwdlKRDD324 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------kLVUhaep4LdBLZwdlKRDD324-- --------------clnhdyorXixPgreZBK3F8k99-- --------------7ii8U7UcB0T0rKiGWIa0mw0W Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMQUSoFAwAAAAAACgkQsN6d1ii/Ey9G 8gf9GLje1vvhlPVddYNZhRvG59Z1ex8Bf81iG5RSrO4j570atIJOtfXTyh34txy92YkSaIozxP9L 2zEVC7pZ6lTl1FvZYlHnmZWykhuW923TZLY+99T/ZJv2TA81u4wSTNDgzjt3YhBj7Nqh7qvHAeKJ /LH4X9wp+C8bVdm1Ld5Sm7LYuuCAn1DUj4mFf9W1U82QJsoTQKhZUoshD4L/gNuCPI4LoZeDDSY1 zY08ACggolukYi9CA9TX+MeldzO3IpQEoZibWOQ+ZiXWm7vzv20m9PhedyXxbaeRhEQiTUxMuejz qQhk9ID6/rnQb1y8y+3va+yMCenfDP3TYoL+hf3siQ== =fzKA -----END PGP SIGNATURE----- --------------7ii8U7UcB0T0rKiGWIa0mw0W-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 06:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 06:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396230.636299 (Exim 4.92) (envelope-from ) id 1oTe3u-00082O-Tm; Thu, 01 Sep 2022 06:52:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396230.636299; Thu, 01 Sep 2022 06:52:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTe3u-00082H-RC; Thu, 01 Sep 2022 06:52:26 +0000 Received: by outflank-mailman (input) for mailman id 396230; Thu, 01 Sep 2022 06:52:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTe3s-00082A-JC for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 06:52:25 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9fe7c480-29c2-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 08:52:22 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTe36-005oCV-6V; Thu, 01 Sep 2022 06:51:36 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id EFD5E300431; Thu, 1 Sep 2022 08:51:31 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CFCAB20981381; Thu, 1 Sep 2022 08:51:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fe7c480-29c2-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qvwvxWbXfnEQ3IUNjSPCWfkqNnnfffGD2A+a/tILXCw=; b=eDO+GXurFPPTEhSILm/ZJtBNxQ B/9JFPYXpVAQVWUcHDCKnIJB1CdMNaXyZHSoxVVCmiz4jck+Zph/Hso4OWj1yo59UkEI+TuSjs/0x 4BG2flE2PwSfLX89dYyD5r9GR/8VhGNI0N1wP4bgU/qL1SOlI1eG/E3m2lqxC2LJi2W5e2ZJJ7zFM 9WEyIPPuONeD1Tk8Yc6NZe7o+Iy919N/s3xHO7Z59aKE7A91A4yWodHn2+/k4lX6bmEaKbqBQMFS3 J++P7dbtRWHNfytn2lcsT7UoR+667IJI0PRpmXC+glH+3s6vtPuXP6y5P4CsaHrdycBcwdGm7XaxS LoVTq62g==; Date: Thu, 1 Sep 2022 08:51:31 +0200 From: Peter Zijlstra To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/30] Lazy percpu counters Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830214919.53220-4-surenb@google.com> On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > +static void lazy_percpu_counter_switch_to_pcpu(struct raw_lazy_percpu_counter *c) > +{ > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__GFP_NOWARN); Realize that this is incorrect when used under a raw_spinlock_t. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:00:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:00:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396237.636311 (Exim 4.92) (envelope-from ) id 1oTeC1-00016c-Ng; Thu, 01 Sep 2022 07:00:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396237.636311; Thu, 01 Sep 2022 07:00:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeC1-00016V-Kh; Thu, 01 Sep 2022 07:00:49 +0000 Received: by outflank-mailman (input) for mailman id 396237; Thu, 01 Sep 2022 07:00:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeC0-00016P-4o for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:00:48 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbe34964-29c3-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 09:00:44 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTeBY-005ocA-Jf; Thu, 01 Sep 2022 07:00:20 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id CF2673004C7; Thu, 1 Sep 2022 09:00:17 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A749520981381; Thu, 1 Sep 2022 09:00:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbe34964-29c3-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lP/axgW6wVbLw99T8GY0xIMHkeiyf6aNs2WovZZWBOY=; b=DsovPIHjiTzLDFEHMUZax6kdiz YmrmwM4nfhUlXHU6+jwtzeSmRIqJzuk4utR6vlplHXI5NoTsSiI6NPT6mQ1h/o6UlCxpUVBSYBOGF mAwUrbTARvU58QmTx2lzLaDbpKSsvApZwYA684cbuuNFGxM7GOsrIGOTXXVvQaBIhlfCdGZ/9loBM L3IgWlK3G+key+g2ORNzZ1jfQX4w6GwCWwHdxGrO4bIeb/Qje5accP3+IyavFM2jCZdaLz1F3Z14t Fw+hvjFeYcySCXoo9Bh3TdJ8voxVMcJyDg7RBGMnnwLLPADNOXfsqH/S6AwZDXh9BZoWO7rjOM3mx f18fOvcQ==; Date: Thu, 1 Sep 2022 09:00:17 +0200 From: Peter Zijlstra To: Mel Gorman Cc: Kent Overstreet , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831101948.f3etturccmp5ovkl@suse.de> On Wed, Aug 31, 2022 at 11:19:48AM +0100, Mel Gorman wrote: > It's also unclear *who* would enable this. It looks like it would mostly > have value during the development stage of an embedded platform to track > kernel memory usage on a per-application basis in an environment where it > may be difficult to setup tracing and tracking. Would it ever be enabled > in production? Afaict this is developer only; it is all unconditional code. > Would a distribution ever enable this? I would sincerely hope not. Because: > If it's enabled, any overhead cannot be disabled/enabled at run or > boot time so anyone enabling this would carry the cost without never > necessarily consuming the data. this. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:06:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:06:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396245.636322 (Exim 4.92) (envelope-from ) id 1oTeH6-0001li-CI; Thu, 01 Sep 2022 07:06:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396245.636322; Thu, 01 Sep 2022 07:06:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeH6-0001lb-89; Thu, 01 Sep 2022 07:06:04 +0000 Received: by outflank-mailman (input) for mailman id 396245; Thu, 01 Sep 2022 07:06:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeH5-0001lV-NX for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:06:03 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a1b07e9-29c4-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 09:06:02 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTeGh-005oq6-Bs; Thu, 01 Sep 2022 07:05:39 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 417C030041D; Thu, 1 Sep 2022 09:05:36 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 110AE20981381; Thu, 1 Sep 2022 09:05:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a1b07e9-29c4-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PMcMlRof4aBmW9ZRc+eOO/2dgQwguo+jd6/zOIwkXz4=; b=CRTVAsmAK2cWYW898rb6ABFc5M uLACuGzlIMyaVe8YmnHdnMTCzaRgU/yORC/GoxdMYsKfSqUkdBcV9CHFquRDxtBp1mrHH1Ek8iUcr mn1JgrUbBdWhUq0dshggnSScCFSCXwzSSm1KuWPF7x5mOnsP+VDfpzlLoRknLlMRFYgTP9KQNHlgH CH7qbZF+ZmtxkOzs27I6vkqhMH23AuEUp5/xcLcIfVX3lpAkPrSHOObJikPLlUvDymQfq9PPQJW2d ahsXPS2phTb5F2Rtarg5EDnzM/T3m8B4GVcztEaB4FRglzTR7JDiDhZuuZYYAbZtb5/Iw4ZAPbP6X Wmout+LA==; Date: Thu, 1 Sep 2022 09:05:35 +0200 From: Peter Zijlstra To: Kent Overstreet Cc: Mel Gorman , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831155941.q5umplytbx6offku@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831155941.q5umplytbx6offku@moria.home.lan> On Wed, Aug 31, 2022 at 11:59:41AM -0400, Kent Overstreet wrote: > Also, ftrace can drop events. Not really ideal if under system load your memory > accounting numbers start to drift. You could attach custom handlers to tracepoints. If you were to replace these unconditional code hooks of yours with tracepoints then you could conditionally (say at boot) register custom handlers that do the accounting you want. Nobody is mandating you use the ftrace ringbuffer to consume tracepoints. Many people these days attach eBPF scripts to them and do whatever they want. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:12:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:12:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396256.636332 (Exim 4.92) (envelope-from ) id 1oTeMk-0003FX-3g; Thu, 01 Sep 2022 07:11:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396256.636332; Thu, 01 Sep 2022 07:11:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeMk-0003FQ-19; Thu, 01 Sep 2022 07:11:54 +0000 Received: by outflank-mailman (input) for mailman id 396256; Thu, 01 Sep 2022 07:11:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeMi-0003FK-06 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:11:52 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 587bf2ca-29c5-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 09:11:49 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTeMD-005p99-An; Thu, 01 Sep 2022 07:11:21 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D2B58300431; Thu, 1 Sep 2022 09:11:17 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B51EF20981381; Thu, 1 Sep 2022 09:11:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 587bf2ca-29c5-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0alPrNIyXUGsDd/lDjKfjoAzSlLEpkpL3yJZZ94RPpk=; b=neTNuYxorlf1E6lqksEri7ob9s +fOEKml0dypX1VPsk71Al83+X/wCWVLA2v8MAkyhFFTF2iv7nIDbg8DLeKDx/Rohb0D/WGiowcdyF 0922P6Ye6aFkRzhuFME6aeUZzKEon4H+p5J4aJUsUfyeUn3pphhfCCpeODAoqUXD8D3vBJsTb3KKg i0elKtC2iCCloFyRF8muS9N3Uom/PTE/NlgZ/EuB/5pL3cvoO8AeT2wg/ELDQb4daJgt/gZxAtlcx +BB0kImmBciB+hA72jxFiegxOnV9t9ymgmWDAn4pa1ntPYvLXdkppEVbVbS9dT3KZirOXj99594dd nqw0a9fg==; Date: Thu, 1 Sep 2022 09:11:17 +0200 From: Peter Zijlstra To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830214919.53220-28-surenb@google.com> On Tue, Aug 30, 2022 at 02:49:16PM -0700, Suren Baghdasaryan wrote: > From: Kent Overstreet > > This adds the ability to easily instrument code for measuring latency. > To use, add the following to calls to your code, at the start and end of > the event you wish to measure: > > code_tag_time_stats_start(start_time); > code_tag_time_stats_finish(start_time); > > Stastistics will then show up in debugfs under > /sys/kernel/debug/time_stats, listed by file and line number. > > Stastics measured include weighted averages of frequency, duration, max > duration, as well as quantiles. > > This patch also instruments all calls to init_wait and finish_wait, > which includes all calls to wait_event. Example debugfs output: How can't you do this with a simple eBPF script on top of trace_sched_stat_* and friends? From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396264.636344 (Exim 4.92) (envelope-from ) id 1oTeTT-0003vE-Qa; Thu, 01 Sep 2022 07:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396264.636344; Thu, 01 Sep 2022 07:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeTT-0003v7-No; Thu, 01 Sep 2022 07:18:51 +0000 Received: by outflank-mailman (input) for mailman id 396264; Thu, 01 Sep 2022 07:18:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeTR-0003v0-RF for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:18:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 517743ad-29c6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 09:18:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 43E1B1FB16; Thu, 1 Sep 2022 07:18:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 098CC13A89; Thu, 1 Sep 2022 07:18:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HuA6ANhcEGMwCAAAMHmgww (envelope-from ); Thu, 01 Sep 2022 07:18:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 517743ad-29c6-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662016728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=syKqR2otOp+SJa2emYsY57+bVX7vmPgl46yq0SOCcY4=; b=XxPpqvq/CprurzzyArGBkJW5SqAQWQkVT69xczpmMcnZD1oRn53SBe3Vor5qXAepnNw6HZ eJdNzUUUyBCLltPNTrvvxdfpcBBHT8aPch+MIclCvWmw3ouoq0E0fd3IBYzv+2TVw5SAGP eKsPIajcu9OwC55K4pFTrVjv2HlxcBc= Date: Thu, 1 Sep 2022 09:18:47 +0200 From: Michal Hocko To: Kent Overstreet Cc: Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> On Wed 31-08-22 15:01:54, Kent Overstreet wrote: > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > Whatever asking for an explanation as to why equivalent functionality > > > cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > > > > Fully agreed and this is especially true for a change this size > > 77 files changed, 3406 insertions(+), 703 deletions(-) > > In the case of memory allocation accounting, you flat cannot do this with ftrace > - you could maybe do a janky version that isn't fully accurate, much slower, > more complicated for the developer to understand and debug and more complicated > for the end user. > > But please, I invite anyone who's actually been doing this with ftrace to > demonstrate otherwise. > > Ftrace just isn't the right tool for the job here - we're talking about adding > per callsite accounting to some of the fastest fast paths in the kernel. > > And the size of the changes for memory allocation accounting are much more > reasonable: > 33 files changed, 623 insertions(+), 99 deletions(-) > > The code tagging library should exist anyways, it's been open coded half a dozen > times in the kernel already. > > And once we've got that, the time stats code is _also_ far simpler than doing it > with ftrace would be. If anyone here has successfully debugged latency issues > with ftrace, I'd really like to hear it. Again, for debugging latency issues you > want something that can always be on, and that's not cheap with ftrace - and > never mind the hassle of correlating start and end wait trace events, builting > up histograms, etc. - that's all handled here. > > Cheap, simple, easy to use. What more could you want? A big ad on a banner. But more seriously. This patchset is _huge_ and touching a lot of different areas. It will be not only hard to review but even harder to maintain longterm. So it is completely reasonable to ask for potential alternatives with a smaller code footprint. I am pretty sure you are aware of that workflow. So I find Peter's question completely appropriate while your response to that not so much! Maybe ftrace is not the right tool for the intented job. Maybe there are other ways and it would be really great to show that those have been evaluated and they are not suitable for a), b) and c) reasons. E.g. Oscar has been working on extending page_ext to track number of allocations for specific calltrace[1]. Is this 1:1 replacement? No! But it can help in environments where page_ext can be enabled and it is completely non-intrusive to the MM code. If the page_ext overhead is not desirable/acceptable then I am sure there are other options. E.g. kprobes/LivePatching framework can hook into functions and alter their behavior. So why not use that for data collection? Has this been evaluated at all? And please note that I am not claiming the presented work is approaching the problem from a wrong direction. It might very well solve multiple problems in a single go _but_ the long term code maintenance burden really has to to be carefully evaluated and if we can achieve a reasonable subset of the functionality with an existing infrastructure then I would be inclined to sacrifice some portions with a considerably smaller code footprint. [1] http://lkml.kernel.org/r/20220901044249.4624-1-osalvador@suse.de -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:28:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396271.636355 (Exim 4.92) (envelope-from ) id 1oTecx-0005Ou-Od; Thu, 01 Sep 2022 07:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396271.636355; Thu, 01 Sep 2022 07:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTecx-0005On-La; Thu, 01 Sep 2022 07:28:39 +0000 Received: by outflank-mailman (input) for mailman id 396271; Thu, 01 Sep 2022 07:28:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTecv-0005OX-8Y for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:28:37 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab78f8f7-29c7-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 09:28:29 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM6PR12MB4895.namprd12.prod.outlook.com (2603:10b6:5:1bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 07:28:23 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d%4]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 07:28:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab78f8f7-29c7-11ed-934f-f50d60e1c1bd ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvINhQIA3TixUc4CSCMv554bTNt8F+uQwxjsSjCpxeAntmwFCA0rqywcO7smecd4/cgDq4KCzqVlZY0xguQKw4BqyuUpziBjUp89myPSIB1rzUcYJx5nGIUckSbUsQI6UF+34qAbH3jLzIZD2Bi3stdGb0BHqWorofNXul6kRwYFfmeHjKSvskXfcLf9DVomwhI+lyeEme60zUH48zi5PmsC0/EHaGpKErPvwtDlrtcyDIOSU08PQWQv5n6qoBNaUR+VVYBPurspEkjhdcWwiPSHzjgBv9y+tWb5mHBOjSnmvHJ45LeVpxcf27aEJPjaIarXtMfJI0ZacKFtTwqTxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JEKSLfwZAq7iQkGB4+0/b2lBVSiSXeDzTqT6Xa4qD3o=; b=fiZ6V/IKbI7aIlHhyWprUSebUMvzlCBX+VGrEzlEKEmoLgwrOw/EWlcqFhHA68TbBfF0P3pkc7Gsmnom0FUdvA/cx54WWWFoUXOvo04kSst5K4fAjc2xbilLtdxPaz86W7rV4/5eE3VigKrqj3E5QPq4gH4cGtp+THZzbThjuzjtXyPaG1O7EvrcnB03XnA0JVPG5J47LYzidaHUdKo7ogE5MCUkOmATw31bvrjs7OFhxGUMUYGSunLf1v4XPenhCTJXNdHwLGPR2eSgArMuZPmjQ4raILNvLmPzsz3R1IiC/FUiVfHBm78J47DhOMUD/b1LRyxIC3I+qcPUmQ1eOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JEKSLfwZAq7iQkGB4+0/b2lBVSiSXeDzTqT6Xa4qD3o=; b=vNhyBgQIOEofoISmufGMzqttZ4TmWlJNPWf3Ut4LTBgJ3P+fPSnLd4OQ9m83/bO5xCl3tc50gOWyernSF4QfuESAltf70onnmuQs3MroNU0TI9AtxaoVlcwAsT5BuGXsaN7l2nisr3qRtrb4DT4miRAZ92QNoo4YP0eZ6k4PCaI= From: "SHARMA, JYOTIRMOY" To: "olekstysh@gmail.com" CC: "SHARMA, JYOTIRMOY" , "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "Stabellini, Stefano" , "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" Subject: Re: Enable audio virtualization in Xen Thread-Topic: Re: Enable audio virtualization in Xen Thread-Index: Adi90T6igslulYXKSAmzK1cf1eJLCw== Date: Thu, 1 Sep 2022 07:28:22 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-01T07:28:18Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7535a506-875a-4b17-b548-d72cff19ce63; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6529a9c2-ee3e-4ea5-11ed-08da8beb8d3b x-ms-traffictypediagnostic: DM6PR12MB4895:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yVjWv5R3cEWmceYfqlGATloxc7TsgpsJfNB6Wke/kWCg3liMcxrUBGht+no+B+4L9smzHdXaspVb82EsZdti0FCP8eCoffo9O+bpGFicMgF4TUcHXbzK4tCXPUE8MbPAdA94kQOJHiWvDIfXALhthbaimr5GqhMgXH29M0P907g29r/yoxhwZxD1P2rtbQ1Qxk8xIn7cSUfVFGfPSrSlreCBnDZSlwrCPCkfw5x3x4f0Umggew+BZ4rbVlH2Avy3jdZFHCnQHCrgeSmZNZKuJt7db3mqxgGzvTWkqtsL8ggzKIVsKRLL79uxMju+lB3daGmrNOqN6DjHKtg067Z1JKHPrFdqq6BaPgw4VbaIDVQ5hUDqfpag38i26/WZdJBaO8PWD5ium0Hn0GAto2k4rz7uGhNZpiq0j3/yNEXye2p8MCy4eE571da6AlgDT+kylPL7QcQGW8N2YeLz+EGJB4k9T9TH3vsk1AIA+d8FziJXGJeWLOmdTycsxAzOwyJrTn3QMI3z/iZgHbrQ8+9I9agqGcq7ls4dvK6NHs32lBJeEQ0amPneCYhWng61VWC4PJ9NMHU9exg7DQE9RjIfb8LEbeocJpEX4dLQyW04zKp4vnJzEpwcfxpKcyJ3WMMyJAgoEtMMAdmkM3RmEI1NLPSNAvkrT/8rNpGVqqXn2zLqcQA/BlThFBLH/4aN99lls0ffsBKqIq68LFRAaqi15OyLuKlH/7RXO6lKR3RF7ouonsbtl7BpCGTD0mKXJAjjcDtY1wfsHThiyOfPdYgl7Do40it6uc5LUvmQgb9t+ZLsETBBclBk4IDhuv6F3taCDJTZLpml/igfMcln437gCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(84040400005)(166002)(4326008)(8676002)(66556008)(64756008)(86362001)(66446008)(66946007)(76116006)(54906003)(6916009)(38070700005)(66476007)(316002)(6506007)(7696005)(83380400001)(41300700001)(9686003)(26005)(186003)(122000001)(38100700002)(71200400001)(55016003)(478600001)(30864003)(2906002)(8936002)(52536014)(5660300002)(33656002)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RCrA4YGlZJbFuBf2hzY+FzPW+K88JcY4z0Ny8aVB/fV5oDbToSpzglUv00Ll?= =?us-ascii?Q?/+K9x7DGQ6SHMnlEuYtSso9lTjEhzzWc1mTfvIqXUPD7vYWVfO8AQTpMzrWI?= =?us-ascii?Q?Ef9+TeFJNfFxCyms1S2bAldEhYD5VvKbPxrlcGKOFsp425qJ6y46FL8cxfnI?= =?us-ascii?Q?Mb2LDorWVuChHYQjLXpEoTZj50W4xSZX+pNRUxBni4YzOSZ8cc7hBI81ejr5?= =?us-ascii?Q?NRo1DBHnv5eVVzFW9kajZnQ8t3HyJOf0P0cu6w+hgsnAJukXixNLyvT3yTIi?= =?us-ascii?Q?ldzQJP8v5hcAXGfrYLdWN2KFdYZxFXpPk6YBSxXj3euUdVUL6uICJRl/pO9V?= =?us-ascii?Q?TIqXb+CDFJpBncMvqT7RwHdtO3kzhhdHJAjNf0TUlz6QLU7kP4Z+P2i9KgUh?= =?us-ascii?Q?GyNbY+BgN37NutG4Gc0XULFvkU/ie4JprwDHJ7wQcRJPpwzfcbIm+H1uT+kg?= =?us-ascii?Q?/LyIQc5V1IUZcN/JAOUK2/7W70RhvAOwpVLGDpsuwIWesJ3ezMT/U0q5URQ2?= =?us-ascii?Q?mCaFGfFSeC4asMAGX5/Iug6+2Fe1ZMMPT/BErWCsrMXkRslV5H1JBdvMJY0S?= =?us-ascii?Q?2oO4F1GTDF/W9rdv6udkXlPif9AdsK8oNtTkjIF4qbWeQEB6bPaGvr0ymhxI?= =?us-ascii?Q?wf8PtCUyugrpT5zSmVWBZMyq73wEdkiIQ9MkDfxqdLfzeUFHlmxW/r87kFoF?= =?us-ascii?Q?sf6reJIINNBhxNOwKsJaDDbd//a1xZMZbI9he1lmElT9Pge3BmUaFYlhbexl?= =?us-ascii?Q?IBEJZFUvB9gDYI99H3PuQqm6fKAowZoCLk7NzVc8dglo+NP/Sonzot/bQsGi?= =?us-ascii?Q?REP2kATqp3xhcFyIA+g7NhfyPzRUuHl5rFTcAPJHw/zYpLBOHHrLx8vZYSjt?= =?us-ascii?Q?tTk94hoWR3Xm2RGv8CFI7PlM97t32+cQ9ZtQ4GrtF+nABc1JfH9Hhd/Y/E4h?= =?us-ascii?Q?r1IkHVnCKayFBu2h8haESum53UpHXU/CNT7gjr+9+Iz03F1j/kdUvcbdVSgA?= =?us-ascii?Q?XwkIDA/bALse8G8d2mZZSRD5i1ne2EMffk8K6QA5ePjYqvbioLptHZCcqS7y?= =?us-ascii?Q?46aBpyHxc94urqzL73W2wvXc+kXjrqbyv56TESux7Igg+0wlMKYNm5pK/X5H?= =?us-ascii?Q?eO3DsiwEdBC/Za79tc22VU8uLiJ4vmpsTua/4/G2PoaiIAD7sNKcEn1JOpWm?= =?us-ascii?Q?hOa3ERsqLFp5nDz5LFu8crqOjNDxLDpQOYDq9DuwKbtCvdnKDvssC4q0h75n?= =?us-ascii?Q?MYLTgEc/esrjDzC+FOvuoj9y2Ihx+Urb8+mgaZBkGHvvyaC3F6FrxHTTr7ll?= =?us-ascii?Q?m+JjczpV6SBUkszgPgSy3CSbgK7thWXV4/pEHwOO7IO9EvD+mbFVUXt330Fe?= =?us-ascii?Q?H4qkOsks6pAkqDBLaQ6JKuU3Y9SqAfGMFubfUhpDXf2ClieflVtBK8XNVMzN?= =?us-ascii?Q?337RUljyxUh3RPvfJbEA9REzQAsvgcPLXEpWBNsF/z+MnS9PtWkerZCRUoa8?= =?us-ascii?Q?a3cY64iDhdlbkML4uXGV7IE7uOl9RWBZ07D9oPdijo6JiZEWowsCYXsUErAl?= =?us-ascii?Q?UAPKI8G5saOpKz5zWrZyg0Pm14jMPhZItUZKmzDO?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB4297D06B82525583A22B58E19F7B9DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6529a9c2-ee3e-4ea5-11ed-08da8beb8d3b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 07:28:22.9068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i2o1lOYbDCUt4jvGfjt/iOlMQ0MJK8ZzTR3ZjOBkDiukcbt9cRICBrWd/1DPTQNxX47ibG0J4XiPjZJBnBg4IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4895 --_000_DM6PR12MB4297D06B82525583A22B58E19F7B9DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Oleksandr, Christopher and others, I am trying to enable audio playback from HVM guest as per discussion above= using ALSA as back end. I have compiled and installed libxenbe (https://github.com/xen-troops/libxe= nbe) and snd_be (https://github.com/xen-troops/snd_be). Following is my vsnd detail in the HVM configuration file: vsnd =3D [[ 'card, backend=3DDomain-0, buffer-size=3D65536, short-name=3DVC= ard, long-name=3DVirtual sound card, sample-rates=3D44100, sample-formats= =3Ds16_le', 'pcm, name=3Ddev1', 'stream, unique-id=3Dalsa, type=3D= P' ]] Here is the virtual card listed in HVM guest: amd@amd-HVM-domU:~$ aplay -l **** List of PLAYBACK Hardware Devices **** card 0: vsnd [], device 0: dev1 [Virtual card PCM] Subdevices: 0/1 Subdevice #0: subdevice #0 I am trying to play audio in guest HVM using aplay command: aplay sample.wa= v. However, I am not able to hear any audio in this case. Please note that if I play the wave file from dom 0 using the same command,= audio can be heard. This means that audio is working fine in the dom 0 usi= ng default card. Below is the log from snd_be. Has anyone tried ALSA back end before? If yes= , can you help me in understanding the issue here? 01.09.22 12:46:37.240 | Main | INF - backend version: v0.2.1-6-gb276 01.09.22 12:46:37.240 | Main | INF - libxenbe version: v0.2.1-11-g2e55-dirt= y 01.09.22 12:46:37.240 | XenStore | DBG - Create xen store 01.09.22 12:46:37.240 | XenStore | DBG - Read string domid : 0 01.09.22 12:46:37.240 | XenStore | DBG - Read int domid : 0 01.09.22 12:46:37.241 | SndBackend | DBG - Create backend, device: vsnd, do= m Id: 0 01.09.22 12:46:37.241 | XenStore | DBG - Start 01.09.22 12:46:37.241 | XenStore | DBG - Set watch: /local/domain/0/backe= nd/vsnd 01.09.22 12:46:37.241 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.469 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.470 | XenStore | DBG - Set watch: /local/domain/0/backe= nd/vsnd/1 01.09.22 12:46:50.470 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.470 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.471 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.471 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.471 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd 01.09.22 12:46:50.472 | XenStore | DBG - Watch triggered: /local/domain/0= /backend/vsnd/1 01.09.22 12:46:50.472 | SndBackend | DBG - New frontend found, domid: 1, de= vid: 0 01.09.22 12:46:50.472 | XenStore | DBG - Create xen store 01.09.22 12:46:50.472 | SndFrontend | DBG - Dom(1/0) Create frontend handle= r 01.09.22 12:46:50.473 | XenStore | DBG - Read string /local/domain/1/dev= ice/vsnd/0/backend : /local/domain/0/backend/vsnd/1/0 01.09.22 12:46:50.473 | SndFrontend | DBG - Frontend path: /local/domain/1/= device/vsnd/0 01.09.22 12:46:50.473 | SndFrontend | DBG - Backend path: /local/domain/0/= backend/vsnd/1/0 01.09.22 12:46:50.473 | XenStore | DBG - Read string /local/domain/0/bac= kend/vsnd/1/0/state : 1 01.09.22 12:46:50.473 | XenStore | DBG - Read int /local/domain/0/backen= d/vsnd/1/0/state : 1 01.09.22 12:46:50.473 | SndFrontend | INF - Close 01.09.22 12:46:50.473 | SndFrontend | INF - Dom(1/0) Set backend state to: = [Closing] 01.09.22 12:46:50.473 | XenStore | DBG - Write int /local/domain/0/backe= nd/vsnd/1/0/state : 5 01.09.22 12:46:50.473 | XenStore | DBG - Write string /local/domain/0/ba= ckend/vsnd/1/0/state : 5 01.09.22 12:46:50.473 | SndFrontend | INF - Dom(1/0) Set backend state to: = [Closed] 01.09.22 12:46:50.473 | XenStore | DBG - Write int /local/domain/0/backe= nd/vsnd/1/0/state : 6 01.09.22 12:46:50.474 | XenStore | DBG - Write string /local/domain/0/ba= ckend/vsnd/1/0/state : 6 01.09.22 12:46:50.474 | SndFrontend | INF - Dom(1/0) Set backend state to: = [Initializing] 01.09.22 12:46:50.474 | XenStore | DBG - Write int /local/domain/0/backe= nd/vsnd/1/0/state : 1 01.09.22 12:46:50.474 | XenStore | DBG - Write string /local/domain/0/ba= ckend/vsnd/1/0/state : 1 01.09.22 12:46:50.474 | PulseMainloop | DBG - Init 01.09.22 12:46:50.477 | PulseMainloop | DBG - Context is ready 01.09.22 12:46:50.477 | XenStore | DBG - Set watch: /local/domain/0/ba= ckend/vsnd/1/0 01.09.22 12:46:50.477 | XenStore | DBG - Set watch: /local/domain/1/de= vice/vsnd/0/state 01.09.22 12:46:50.478 | XenStore | DBG - Set watch: /local/domain/0/ba= ckend/vsnd/1/0/state 01.09.22 12:46:50.478 | XenStore | DBG - Start 01.09.22 12:46:50.478 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd 01.09.22 12:46:50.478 | XenStore | DBG - Watch triggered: /local/domai= n/1/device/vsnd/0/state 01.09.22 12:46:50.478 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1 01.09.22 12:46:50.478 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/state : 1 01.09.22 12:46:50.478 | XenStore | DBG - Read int /local/domain/1/devi= ce/vsnd/0/state : 1 01.09.22 12:46:50.478 | SndFrontend | INF - Dom(1/0) Frontend state chang= ed to: [Initializing] 01.09.22 12:46:50.478 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd 01.09.22 12:46:50.478 | SndFrontend | INF - Dom(1/0) Set backend state to= : [InitWait] 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1 01.09.22 12:46:50.479 | XenStore | DBG - Write int /local/domain/0/bac= kend/vsnd/1/0/state : 2 01.09.22 12:46:50.479 | XenStore | DBG - Write string /local/domain/0/= backend/vsnd/1/0/state : 2 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1/0/state 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1 01.09.22 12:46:50.479 | XenStore | DBG - Read string /local/domain/0/b= ackend/vsnd/1/0/state : 2 01.09.22 12:46:50.479 | XenStore | DBG - Read int /local/domain/0/back= end/vsnd/1/0/state : 2 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1/0/state 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1/0 01.09.22 12:46:50.479 | SndBackend | DBG - Frontend path changed: /local= /domain/0/backend/vsnd/1/0 01.09.22 12:46:50.479 | XenStore | DBG - Read string /local/domain/0/b= ackend/vsnd/1/0/state : 2 01.09.22 12:46:50.479 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd 01.09.22 12:46:50.480 | XenStore | DBG - Read int /local/domain/0/back= end/vsnd/1/0/state : 2 01.09.22 12:46:50.480 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1 01.09.22 12:46:50.480 | XenStore | DBG - Watch triggered: /local/domai= n/0/backend/vsnd/1/0 01.09.22 12:46:50.480 | SndBackend | DBG - Frontend path changed: /local= /domain/0/backend/vsnd/1/0 01.09.22 12:47:03.021 | XenStore | DBG - Watch triggered: /local/domai= n/1/device/vsnd/0/state 01.09.22 12:47:03.022 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/state : 3 01.09.22 12:47:03.022 | XenStore | DBG - Read int /local/domain/1/devi= ce/vsnd/0/state : 3 01.09.22 12:47:03.022 | SndFrontend | INF - Dom(1/0) Frontend state chang= ed to: [Initialized] 01.09.22 12:47:03.022 | SndFrontend | DBG - onBind 01.09.22 12:47:03.022 | SndFrontend | DBG - Found device: 0 01.09.22 12:47:03.022 | SndFrontend | DBG - Found stream: 0 01.09.22 12:47:03.022 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/0/0/unique-id : alsa 01.09.22 12:47:03.022 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/0/0/type : p 01.09.22 12:47:03.023 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/0/0/event-channel : 31 01.09.22 12:47:03.023 | XenStore | DBG - Read int /local/domain/1/devi= ce/vsnd/0/0/0/event-channel : 31 01.09.22 12:47:03.023 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/0/0/ring-ref : 321 01.09.22 12:47:03.023 | XenStore | DBG - Read int /local/domain/1/devi= ce/vsnd/0/0/0/ring-ref : 321 01.09.22 12:47:03.023 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/0/0/evt-event-channel : 32 01.09.22 12:47:03.023 | XenStore | DBG - Read int /local/domain/1/devi= ce/vsnd/0/0/0/evt-event-channel : 32 01.09.22 12:47:03.023 | XenStore | DBG - Read string /local/domain/1/d= evice/vsnd/0/0/0/evt-ring-ref : 1437 01.09.22 12:47:03.023 | XenStore | DBG - Read int /local/domain/1/devi= ce/vsnd/0/0/0/evt-ring-ref : 1437 01.09.22 12:47:03.024 | XenEvtchn | DBG - Create event channel, dom: 1,= remote port: 32, local port: 76 01.09.22 12:47:03.024 | XenGnttabBuffer | DBG - Create grant table buffer, = dom: 1, count: 1, ref: 1437, buffer offset: 0 01.09.22 12:47:03.024 | RingBuffer | DBG - Create ring buffer, port: 3= 2, ref: 1437 01.09.22 12:47:03.024 | SndFrontend | INF - Dom(1/0) Add ring buffer, r= ef: 1437, port: 32 01.09.22 12:47:03.024 | XenEvtchn | DBG - Start event channel, port: = 76 01.09.22 12:47:03.024 | SndFrontend | DBG - Parse stream id: alsa 01.09.22 12:47:03.024 | SndFrontend | DBG - Create pcm device, type: AL= SA, device: default, propName: , propValue: 01.09.22 12:47:03.024 | AlsaPcm | DBG - Create pcm device: default 01.09.22 12:47:03.024 | XenEvtchn | DBG - Event received, port: 76 01.09.22 12:47:03.024 | XenEvtchn | DBG - Create event channel, dom: = 1, remote port: 31, local port: 77 01.09.22 12:47:03.024 | XenGnttabBuffer | DBG - Create grant table buffer, = dom: 1, count: 1, ref: 321, buffer offset: 0 01.09.22 12:47:03.024 | RingBuffer | DBG - Create ring buffer, port: 3= 1, ref: 321 01.09.22 12:47:03.024 | CommandHandler | DBG - Create command handler, dom= : 1 01.09.22 12:47:03.024 | StreamRing | DBG - Create stream ring buffer, = id: alsa 01.09.22 12:47:03.024 | SndFrontend | INF - Dom(1/0) Add ring buffer, r= ef: 321, port: 31 01.09.22 12:47:03.024 | XenEvtchn | DBG - Start event channel, port: = 77 01.09.22 12:47:03.024 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:03.025 | SndFrontend | INF - Dom(1/0) Set backend state = to: [Connected] 01.09.22 12:47:03.025 | XenStore | DBG - Write int /local/domain/0/b= ackend/vsnd/1/0/state : 4 01.09.22 12:47:03.025 | XenStore | DBG - Write string /local/domain/= 0/backend/vsnd/1/0/state : 4 01.09.22 12:47:03.026 | XenStore | DBG - Watch triggered: /local/dom= ain/0/backend/vsnd/1/0/state 01.09.22 12:47:03.026 | XenStore | DBG - Watch triggered: /local/dom= ain/0/backend/vsnd 01.09.22 12:47:03.026 | XenStore | DBG - Watch triggered: /local/dom= ain/0/backend/vsnd/1 01.09.22 12:47:03.026 | XenStore | DBG - Read string /local/domain/0= /backend/vsnd/1/0/state : 4 01.09.22 12:47:03.026 | XenStore | DBG - Read int /local/domain/0/ba= ckend/vsnd/1/0/state : 4 01.09.22 12:47:03.026 | XenStore | DBG - Watch triggered: /local/dom= ain/0/backend/vsnd/1/0 01.09.22 12:47:03.026 | SndBackend | DBG - Frontend path changed: /loc= al/domain/0/backend/vsnd/1/0 01.09.22 12:47:03.034 | XenStore | DBG - Watch triggered: /local/dom= ain/1/device/vsnd/0/state 01.09.22 12:47:03.034 | XenStore | DBG - Read string /local/domain/1= /device/vsnd/0/state : 4 01.09.22 12:47:03.034 | XenStore | DBG - Read int /local/domain/1/de= vice/vsnd/0/state : 4 01.09.22 12:47:03.034 | SndFrontend | INF - Dom(1/0) Frontend state cha= nged to: [Connected] 01.09.22 12:47:04.390 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.390 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.390 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.390 | AlsaPcm | DBG - Opening pcm device for quer= ies: default 01.09.22 12:47:04.395 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.395 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.395 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.395 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.395 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.395 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.395 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.395 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.395 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.395 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.395 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.395 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.395 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.395 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.395 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.396 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.396 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.396 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.396 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.396 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.396 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.396 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.396 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.396 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.396 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.396 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.396 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.396 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.396 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.396 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.396 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.396 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.396 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.396 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.396 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.396 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.396 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.396 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.396 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.396 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.397 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.397 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.397 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.397 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.397 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.397 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.397 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.397 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.397 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.397 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.397 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.397 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.397 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.397 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.397 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.397 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.397 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.397 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.397 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.397 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.397 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.397 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.397 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.397 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.397 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.397 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.398 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.398 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.398 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.398 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.398 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.398 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.398 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.398 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.398 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.398 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.398 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.398 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.398 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.398 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.398 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.398 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.398 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.398 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.398 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.398 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.398 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.398 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.398 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.398 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.398 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.398 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.398 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.398 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.398 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.399 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.399 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.399 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.399 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.399 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.399 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.399 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.399 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.399 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.399 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.399 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.399 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.399 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.399 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.399 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.399 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.399 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.399 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.399 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.399 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.399 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.399 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.399 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.399 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.399 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.399 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.399 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.399 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.402 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.402 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.402 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.402 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.402 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.402 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.406 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.406 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.406 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.406 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.406 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.406 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.408 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.408 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:0 01.09.22 12:47:04.408 | CommandHandler | DBG - Handle command [OPEN] 01.09.22 12:47:04.408 | CommandHandler | DBG - Get buffer refs, directory:= 316, size: 17632, in grefs: 5 01.09.22 12:47:04.408 | XenGnttabBuffer | DBG - Create grant table buffer, = dom: 1, count: 1, ref: 316, buffer offset: 0 01.09.22 12:47:04.409 | CommandHandler | DBG - Gref address: 0x7fd1ea11200= 4, numGrefs 5 01.09.22 12:47:04.409 | XenGnttabBuffer | DBG - Delete grant table buffer 01.09.22 12:47:04.409 | CommandHandler | DBG - Get buffer refs, num refs: = 5 01.09.22 12:47:04.409 | XenGnttabBuffer | DBG - Create grant table buffer, = dom: 1, count: 5, ref: 1485, buffer offset: 0 01.09.22 12:47:04.409 | AlsaPcm | DBG - Open pcm device: default 01.09.22 12:47:04.409 | AlsaPcm | DBG - Close pcm query device: def= ault 01.09.22 12:47:04.410 | AlsaPcm | DBG - Format: S16_LE, rate: 44100= , channels: 2, period: 4408, buffer: 17632 01.09.22 12:47:04.666 | AlsaPcm | DBG - Playback supports audio def= ault timestamps 01.09.22 12:47:04.668 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.669 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.681 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.681 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:1 01.09.22 12:47:04.681 | CommandHandler | DBG - Handle command [CLOSE] 01.09.22 12:47:04.681 | XenGnttabBuffer | DBG - Delete grant table buffer 01.09.22 12:47:04.681 | AlsaPcm | DBG - Close pcm device: default 01.09.22 12:47:04.684 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.685 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.689 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.689 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.689 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.689 | AlsaPcm | DBG - Opening pcm device for quer= ies: default 01.09.22 12:47:04.691 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.691 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.691 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.694 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.694 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.694 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.694 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.694 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.694 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.695 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.696 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.696 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.696 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.696 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.696 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.699 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.699 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.699 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.699 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.699 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.699 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.699 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.699 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.700 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.700 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.700 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.700 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.700 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.700 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.700 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.700 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.700 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.700 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.700 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.700 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.700 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.700 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.701 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.701 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.701 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.701 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.701 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.701 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.701 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.701 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.701 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.701 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.701 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.701 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.701 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.701 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.701 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.701 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.701 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.701 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.702 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.702 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.702 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.702 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.702 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.702 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.702 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.702 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.702 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.702 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.702 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.702 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.702 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.702 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.703 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.703 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.703 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.703 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.703 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.703 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.703 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.703 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.703 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.703 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.703 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.703 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.703 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.703 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.704 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.704 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.704 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.704 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.704 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.704 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.704 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.704 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.704 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.704 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.704 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.704 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.704 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.704 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.704 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.704 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.704 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.704 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.704 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.704 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.704 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.704 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.705 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.705 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.705 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.705 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.705 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.705 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.705 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.705 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.705 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.705 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.705 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.705 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.705 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.705 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.705 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.705 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.705 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.705 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.705 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.705 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.705 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.705 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.706 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.706 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.706 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.706 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.706 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.706 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.706 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.706 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.706 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.706 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:0 01.09.22 12:47:04.706 | CommandHandler | DBG - Handle command [OPEN] 01.09.22 12:47:04.706 | CommandHandler | DBG - Get buffer refs, directory:= 326, size: 17632, in grefs: 5 01.09.22 12:47:04.706 | XenGnttabBuffer | DBG - Create grant table buffer, = dom: 1, count: 1, ref: 326, buffer offset: 0 01.09.22 12:47:04.706 | CommandHandler | DBG - Gref address: 0x7fd1ea11200= 4, numGrefs 5 01.09.22 12:47:04.707 | XenGnttabBuffer | DBG - Delete grant table buffer 01.09.22 12:47:04.707 | CommandHandler | DBG - Get buffer refs, num refs: = 5 01.09.22 12:47:04.707 | XenGnttabBuffer | DBG - Create grant table buffer, = dom: 1, count: 5, ref: 319, buffer offset: 0 01.09.22 12:47:04.707 | AlsaPcm | DBG - Open pcm device: default 01.09.22 12:47:04.707 | AlsaPcm | DBG - Close pcm query device: def= ault 01.09.22 12:47:04.708 | AlsaPcm | DBG - Format: S16_LE, rate: 44100= , channels: 2, period: 4408, buffer: 17632 01.09.22 12:47:04.710 | AlsaPcm | DBG - Playback supports audio def= ault timestamps 01.09.22 12:47:04.712 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.712 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.712 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.712 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.712 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.712 | AlsaPcm | DBG - Opening pcm device for quer= ies: default 01.09.22 12:47:04.715 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.715 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.715 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.715 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.715 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.715 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.715 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.715 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.715 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.715 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.715 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.715 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.715 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.715 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.715 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.716 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.716 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.716 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.716 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.716 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.716 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.716 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.716 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.716 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.716 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.716 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.716 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.716 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.716 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.716 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.716 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.716 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.716 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.716 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.716 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.716 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.717 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.717 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.717 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.717 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.717 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.717 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.717 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.717 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.717 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.717 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.717 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.717 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.717 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.717 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.717 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.718 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.718 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.718 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.718 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.718 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.718 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.718 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.718 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.718 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.718 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.718 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.718 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.718 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.718 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:9 01.09.22 12:47:04.718 | CommandHandler | DBG - Handle command [QUERY_HW_PA= RAM] 01.09.22 12:47:04.718 | AlsaPcm | DBG - Query pcm device default fo= r HW parameters 01.09.22 12:47:04.718 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.718 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.727 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.727 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:3 01.09.22 12:47:04.727 | CommandHandler | DBG - Handle command [WRITE] 01.09.22 12:47:04.727 | AlsaPcm | DBG - Write to pcm device: defaul= t, size: 4408 01.09.22 12:47:04.727 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.727 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.729 | XenEvtchn | DBG - Event received, port: 77 01.09.22 12:47:04.729 | StreamRing | DBG - Request received, id: alsa<= default>, cmd:8 01.09.22 12:47:04.729 | CommandHandler | DBG - Handle command [TRIGGER][ST= ART] 01.09.22 12:47:04.729 | AlsaPcm | DBG - Start 01.09.22 12:47:04.731 | CommandHandler | DBG - Return status: [0] 01.09.22 12:47:04.731 | XenEvtchn | DBG - Notify event channel, port:= 77 01.09.22 12:47:04.756 | AlsaPcm | DBG - Frame: 0, bytes: 17632, sta= te: 4 01.09.22 12:47:04.756 | RingBuffer | DBG - Send event, port: 32, prod:= 0, cons: 0, num events: 63 01.09.22 12:47:04.756 | XenEvtchn | DBG - Notify event channel, port:= 76 01.09.22 12:47:04.780 | AlsaPcm | DBG - Frame: 0, bytes: 17632, sta= te: 4 01.09.22 12:47:04.780 | RingBuffer | DBG - Send event, port: 32, prod:= 1, cons: 1, num events: 63 01.09.22 12:47:04.780 | XenEvtchn | DBG - Notify event channel, port:= 76 Regards, Jyotirmoy --_000_DM6PR12MB4297D06B82525583A22B58E19F7B9DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


Hi Oleksandr, Christopher and others,

 

I am trying to enable audio playback from HVM guest = as per discussion above using ALSA as back end.

 

I have compiled and installed libxenbe (https://github.com/xen-troops/libxen= be) and snd_be (https:= //github.com/xen-troops/snd_be).

Following is my vsnd detail in the HVM configuration= file:

 

vsnd =3D [[ 'card, backend=3DDomain-0, buffer-size= =3D65536, short-name=3DVCard, long-name=3DVirtual sound card, sample-rates= =3D44100, sample-formats=3Ds16_le', 'pcm, name=3Ddev1', 'stream, unique-id= =3Dalsa<default>, type=3DP' ]]

 

Here is the virtual card listed in HVM guest:

amd@amd-HVM-domU:~$ aplay -l

**** List of PLAYBACK Hardware Devices ****

card 0: vsnd [], device 0: dev1 [Virtual card PCM]

  Subdevices: 0/1

  Subdevice #0: subdevice #0

 

I am trying to play audio in guest HVM using aplay c= ommand: aplay sample.wav. However, I am not able to hear any audio in this = case.

 

Please note that if I play the wave file from dom 0 = using the same command, audio can be heard. This means that audio is workin= g fine in the dom 0 using default card.

 

Below is the log from snd_be. Has anyone tried ALSA = back end before? If yes, can you help me in understanding the issue here?

 

01.09.22 12:46:37.240 | Main | INF - backend version= :  v0.2.1-6-gb276

01.09.22 12:46:37.240 | Main | INF - libxenbe versio= n: v0.2.1-11-g2e55-dirty

01.09.22 12:46:37.240 | XenStore | DBG - Create xen = store

01.09.22 12:46:37.240 | XenStore | DBG - Read string= domid : 0

01.09.22 12:46:37.240 | XenStore | DBG - Read int do= mid : 0

01.09.22 12:46:37.241 | SndBackend | DBG - Create ba= ckend, device: vsnd, dom Id: 0

01.09.22 12:46:37.241 | XenStore   | DBG -= Start

01.09.22 12:46:37.241 | XenStore   | DBG -= Set watch: /local/domain/0/backend/vsnd

01.09.22 12:46:37.241 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.469 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.470 | XenStore   | DBG -= Set watch: /local/domain/0/backend/vsnd/1

01.09.22 12:46:50.470 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.470 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.471 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.471 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.471 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd

01.09.22 12:46:50.472 | XenStore   | DBG -= Watch triggered: /local/domain/0/backend/vsnd/1

01.09.22 12:46:50.472 | SndBackend | DBG - New front= end found, domid: 1, devid: 0

01.09.22 12:46:50.472 | XenStore   | DBG -= Create xen store

01.09.22 12:46:50.472 | SndFrontend | DBG - Dom(1/0)= Create frontend handler

01.09.22 12:46:50.473 | XenStore    |= DBG - Read string /local/domain/1/device/vsnd/0/backend : /local/domain/0/= backend/vsnd/1/0

01.09.22 12:46:50.473 | SndFrontend | DBG - Frontend= path: /local/domain/1/device/vsnd/0

01.09.22 12:46:50.473 | SndFrontend | DBG - Backend = path:  /local/domain/0/backend/vsnd/1/0

01.09.22 12:46:50.473 | XenStore    |= DBG - Read string /local/domain/0/backend/vsnd/1/0/state : 1

01.09.22 12:46:50.473 | XenStore    |= DBG - Read int /local/domain/0/backend/vsnd/1/0/state : 1

01.09.22 12:46:50.473 | SndFrontend | INF - Close

01.09.22 12:46:50.473 | SndFrontend | INF - Dom(1/0)= Set backend state to: [Closing]

01.09.22 12:46:50.473 | XenStore    |= DBG - Write int /local/domain/0/backend/vsnd/1/0/state : 5

01.09.22 12:46:50.473 | XenStore    |= DBG - Write string /local/domain/0/backend/vsnd/1/0/state : 5

01.09.22 12:46:50.473 | SndFrontend | INF - Dom(1/0)= Set backend state to: [Closed]

01.09.22 12:46:50.473 | XenStore    |= DBG - Write int /local/domain/0/backend/vsnd/1/0/state : 6

01.09.22 12:46:50.474 | XenStore    |= DBG - Write string /local/domain/0/backend/vsnd/1/0/state : 6

01.09.22 12:46:50.474 | SndFrontend | INF - Dom(1/0)= Set backend state to: [Initializing]

01.09.22 12:46:50.474 | XenStore    |= DBG - Write int /local/domain/0/backend/vsnd/1/0/state : 1

01.09.22 12:46:50.474 | XenStore    |= DBG - Write string /local/domain/0/backend/vsnd/1/0/state : 1

01.09.22 12:46:50.474 | PulseMainloop | DBG - Init

01.09.22 12:46:50.477 | PulseMainloop | DBG - Contex= t is ready

01.09.22 12:46:50.477 | XenStore   &n= bsp;  | DBG - Set watch: /local/domain/0/backend/vsnd/1/0

01.09.22 12:46:50.477 | XenStore   &n= bsp;  | DBG - Set watch: /local/domain/1/device/vsnd/0/state

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Set watch: /local/domain/0/backend/vsnd/1/0/state

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Start

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd=

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/1/device/vsnd/0/state

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/state : 1=

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Read int /local/domain/1/device/vsnd/0/state : 1

01.09.22 12:46:50.478 | SndFrontend   | IN= F - Dom(1/0) Frontend state changed to: [Initializing]

01.09.22 12:46:50.478 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd=

01.09.22 12:46:50.478 | SndFrontend   | IN= F - Dom(1/0) Set backend state to: [InitWait]

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Write int /local/domain/0/backend/vsnd/1/0/state : 2

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Write string /local/domain/0/backend/vsnd/1/0/state : 2<= o:p>

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1/0/state<= o:p>

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd=

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Read string /local/domain/0/backend/vsnd/1/0/state : 2

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Read int /local/domain/0/backend/vsnd/1/0/state : 2=

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1/0/state<= o:p>

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1/0

01.09.22 12:46:50.479 | SndBackend   = | DBG - Frontend path changed: /local/domain/0/backend/vsnd/1/0=

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Read string /local/domain/0/backend/vsnd/1/0/state : 2

01.09.22 12:46:50.479 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd=

01.09.22 12:46:50.480 | XenStore   &n= bsp;  | DBG - Read int /local/domain/0/backend/vsnd/1/0/state : 2=

01.09.22 12:46:50.480 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1

01.09.22 12:46:50.480 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/0/backend/vsnd/1/0

01.09.22 12:46:50.480 | SndBackend   = | DBG - Frontend path changed: /local/domain/0/backend/vsnd/1/0=

01.09.22 12:47:03.021 | XenStore   &n= bsp;  | DBG - Watch triggered: /local/domain/1/device/vsnd/0/state

01.09.22 12:47:03.022 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/state : 3=

01.09.22 12:47:03.022 | XenStore   &n= bsp;  | DBG - Read int /local/domain/1/device/vsnd/0/state : 3

01.09.22 12:47:03.022 | SndFrontend   | IN= F - Dom(1/0) Frontend state changed to: [Initialized]

01.09.22 12:47:03.022 | SndFrontend   | DB= G - onBind

01.09.22 12:47:03.022 | SndFrontend   | DB= G - Found device: 0

01.09.22 12:47:03.022 | SndFrontend   | DB= G - Found stream: 0

01.09.22 12:47:03.022 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/0/0/unique-id = : alsa<default>

01.09.22 12:47:03.022 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/0/0/type : p

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/0/0/event-chan= nel : 31

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read int /local/domain/1/device/vsnd/0/0/0/event-channel= : 31

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/0/0/ring-ref := 321

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read int /local/domain/1/device/vsnd/0/0/0/ring-ref : 32= 1

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/0/0/evt-event-= channel : 32

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read int /local/domain/1/device/vsnd/0/0/0/evt-event-cha= nnel : 32

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read string /local/domain/1/device/vsnd/0/0/0/evt-ring-r= ef : 1437

01.09.22 12:47:03.023 | XenStore   &n= bsp;  | DBG - Read int /local/domain/1/device/vsnd/0/0/0/evt-ring-ref = : 1437

01.09.22 12:47:03.024 | XenEvtchn   &= nbsp; | DBG - Create event channel, dom: 1, remote port: 32, local port: 76=

01.09.22 12:47:03.024 | XenGnttabBuffer | DBG - Crea= te grant table buffer, dom: 1, count: 1, ref: 1437, buffer offset: 0

01.09.22 12:47:03.024 | RingBuffer   =    | DBG - Create ring buffer, port: 32, ref: 1437

01.09.22 12:47:03.024 | SndFrontend   = ;  | INF - Dom(1/0) Add ring buffer, ref: 1437, port: 32

01.09.22 12:47:03.024 | XenEvtchn   &= nbsp;   | DBG - Start event channel, port: 76

01.09.22 12:47:03.024 | SndFrontend   = ;  | DBG - Parse stream id: alsa<default>

01.09.22 12:47:03.024 | SndFrontend   = ;  | DBG - Create pcm device, type: ALSA, device: default, propName: ,= propValue:

01.09.22 12:47:03.024 | AlsaPcm   &nb= sp;     | DBG - Create pcm device: default

01.09.22 12:47:03.024 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 76

01.09.22 12:47:03.024 | XenEvtchn   &= nbsp;   | DBG - Create event channel, dom: 1, remote port: 31, lo= cal port: 77

01.09.22 12:47:03.024 | XenGnttabBuffer | DBG - Crea= te grant table buffer, dom: 1, count: 1, ref: 321, buffer offset: 0

01.09.22 12:47:03.024 | RingBuffer   =    | DBG - Create ring buffer, port: 31, ref: 321

01.09.22 12:47:03.024 | CommandHandler  | DBG -= Create command handler, dom: 1

01.09.22 12:47:03.024 | StreamRing   =    | DBG - Create stream ring buffer, id: alsa<default>

01.09.22 12:47:03.024 | SndFrontend   = ;  | INF - Dom(1/0) Add ring buffer, ref: 321, port: 31

01.09.22 12:47:03.024 | XenEvtchn   &= nbsp;   | DBG - Start event channel, port: 77

01.09.22 12:47:03.024 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:03.025 | SndFrontend   = ;  | INF - Dom(1/0) Set backend state to: [Connected]

01.09.22 12:47:03.025 | XenStore   &n= bsp;    | DBG - Write int /local/domain/0/backend/vsnd/1/0/s= tate : 4

01.09.22 12:47:03.025 | XenStore   &n= bsp;    | DBG - Write string /local/domain/0/backend/vsnd/1/= 0/state : 4

01.09.22 12:47:03.026 | XenStore   &n= bsp;    | DBG - Watch triggered: /local/domain/0/backend/vsn= d/1/0/state

01.09.22 12:47:03.026 | XenStore   &n= bsp;    | DBG - Watch triggered: /local/domain/0/backend/vsn= d

01.09.22 12:47:03.026 | XenStore   &n= bsp;    | DBG - Watch triggered: /local/domain/0/backend/vsn= d/1

01.09.22 12:47:03.026 | XenStore   &n= bsp;    | DBG - Read string /local/domain/0/backend/vsnd/1/0= /state : 4

01.09.22 12:47:03.026 | XenStore   &n= bsp;    | DBG - Read int /local/domain/0/backend/vsnd/1/0/st= ate : 4

01.09.22 12:47:03.026 | XenStore   &n= bsp;    | DBG - Watch triggered: /local/domain/0/backend/vsn= d/1/0

01.09.22 12:47:03.026 | SndBackend   =    | DBG - Frontend path changed: /local/domain/0/backend/vsnd/1/= 0

01.09.22 12:47:03.034 | XenStore   &n= bsp;    | DBG - Watch triggered: /local/domain/1/device/vsnd= /0/state

01.09.22 12:47:03.034 | XenStore   &n= bsp;    | DBG - Read string /local/domain/1/device/vsnd/0/st= ate : 4

01.09.22 12:47:03.034 | XenStore   &n= bsp;    | DBG - Read int /local/domain/1/device/vsnd/0/state= : 4

01.09.22 12:47:03.034 | SndFrontend   = ;  | INF - Dom(1/0) Frontend state changed to: [Connected]<= /p>

01.09.22 12:47:04.390 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.390 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.390 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.390 | AlsaPcm   &nb= sp;     | DBG - Opening pcm device for queries: default=

01.09.22 12:47:04.395 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.395 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.395 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.395 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.395 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.395 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.395 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.395 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.395 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.395 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.395 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.395 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.395 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.395 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.395 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.396 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.396 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.396 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.396 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.396 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.396 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.396 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.396 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.396 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.396 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.397 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.397 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.397 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.397 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.397 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.397 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.397 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.397 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.397 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.397 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.397 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.398 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.398 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.398 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.398 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.398 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.398 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.398 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.398 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.398 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.398 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.398 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.398 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.399 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.399 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.399 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.399 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.399 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.399 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.399 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.399 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.399 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.399 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.399 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.402 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.402 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.402 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.402 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.402 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.402 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.406 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.406 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.406 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.406 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.406 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.406 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.408 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.408 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:0<= /o:p>

01.09.22 12:47:04.408 | CommandHandler  | DBG -= Handle command [OPEN]

01.09.22 12:47:04.408 | CommandHandler  | DBG -= Get buffer refs, directory: 316, size: 17632, in grefs: 5

01.09.22 12:47:04.408 | XenGnttabBuffer | DBG - Crea= te grant table buffer, dom: 1, count: 1, ref: 316, buffer offset: 0

01.09.22 12:47:04.409 | CommandHandler  | DBG -= Gref address: 0x7fd1ea112004, numGrefs 5

01.09.22 12:47:04.409 | XenGnttabBuffer | DBG - Dele= te grant table buffer

01.09.22 12:47:04.409 | CommandHandler  | DBG -= Get buffer refs, num refs: 5

01.09.22 12:47:04.409 | XenGnttabBuffer | DBG - Crea= te grant table buffer, dom: 1, count: 5, ref: 1485, buffer offset: 0

01.09.22 12:47:04.409 | AlsaPcm   &nb= sp;     | DBG - Open pcm device: default

01.09.22 12:47:04.409 | AlsaPcm   &nb= sp;     | DBG - Close pcm query device: default

01.09.22 12:47:04.410 | AlsaPcm   &nb= sp;     | DBG - Format: S16_LE, rate: 44100, channels: = 2, period: 4408, buffer: 17632

01.09.22 12:47:04.666 | AlsaPcm   &nb= sp;     | DBG - Playback supports audio default timesta= mps

01.09.22 12:47:04.668 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.669 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.681 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.681 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:1<= /o:p>

01.09.22 12:47:04.681 | CommandHandler  | DBG -= Handle command [CLOSE]

01.09.22 12:47:04.681 | XenGnttabBuffer | DBG - Dele= te grant table buffer

01.09.22 12:47:04.681 | AlsaPcm   &nb= sp;     | DBG - Close pcm device: default

01.09.22 12:47:04.684 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.685 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.689 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.689 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.689 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.689 | AlsaPcm   &nb= sp;     | DBG - Opening pcm device for queries: default=

01.09.22 12:47:04.691 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.691 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.691 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.694 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.694 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.694 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.694 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.694 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.694 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.695 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.696 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.696 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.696 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.696 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.696 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.699 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.699 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.699 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.699 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.699 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.699 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.699 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.699 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.700 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.700 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.700 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.700 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.700 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.700 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.700 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.700 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.700 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.700 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.700 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.700 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.700 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.700 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.701 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.701 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.701 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.701 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.701 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.701 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.701 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.701 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.701 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.701 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.701 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.701 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.701 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.701 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.701 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.701 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.701 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.701 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.702 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.702 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.702 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.702 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.702 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.702 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.702 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.702 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.702 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.702 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.702 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.702 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.702 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.702 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.703 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.703 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.703 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.703 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.703 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.703 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.703 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.703 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.703 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.703 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.703 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.703 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.703 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.703 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.704 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.704 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.704 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.704 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.704 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.704 | StreamRing    = ;  | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.704 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.704 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.704 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.705 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.705 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.705 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.705 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.705 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.705 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.705 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.705 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.705 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.705 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.706 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.706 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.706 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.706 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.706 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.706 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.706 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.706 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.706 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.706 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:0<= /o:p>

01.09.22 12:47:04.706 | CommandHandler  | DBG -= Handle command [OPEN]

01.09.22 12:47:04.706 | CommandHandler  | DBG -= Get buffer refs, directory: 326, size: 17632, in grefs: 5

01.09.22 12:47:04.706 | XenGnttabBuffer | DBG - Crea= te grant table buffer, dom: 1, count: 1, ref: 326, buffer offset: 0

01.09.22 12:47:04.706 | CommandHandler  | DBG -= Gref address: 0x7fd1ea112004, numGrefs 5

01.09.22 12:47:04.707 | XenGnttabBuffer | DBG - Dele= te grant table buffer

01.09.22 12:47:04.707 | CommandHandler  | DBG -= Get buffer refs, num refs: 5

01.09.22 12:47:04.707 | XenGnttabBuffer | DBG - Crea= te grant table buffer, dom: 1, count: 5, ref: 319, buffer offset: 0

01.09.22 12:47:04.707 | AlsaPcm   &nb= sp;     | DBG - Open pcm device: default

01.09.22 12:47:04.707 | AlsaPcm   &nb= sp;     | DBG - Close pcm query device: default

01.09.22 12:47:04.708 | AlsaPcm   &nb= sp;     | DBG - Format: S16_LE, rate: 44100, channels: = 2, period: 4408, buffer: 17632

01.09.22 12:47:04.710 | AlsaPcm   &nb= sp;     | DBG - Playback supports audio default timesta= mps

01.09.22 12:47:04.712 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.712 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.712 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.712 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.712 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.712 | AlsaPcm   &nb= sp;     | DBG - Opening pcm device for queries: default=

01.09.22 12:47:04.715 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.715 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.715 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.715 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.715 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.715 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.715 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.715 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.715 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.715 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.715 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.715 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.715 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.715 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.715 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.716 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.716 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.716 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.716 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.716 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.716 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.716 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.716 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.716 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.717 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.717 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.717 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.717 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.717 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.717 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.717 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.717 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.717 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.717 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.717 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.717 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.717 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.717 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.717 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.718 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.718 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.718 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.718 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.718 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.718 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.718 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.718 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.718 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.718 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.718 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.718 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.718 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.718 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:9<= /o:p>

01.09.22 12:47:04.718 | CommandHandler  | DBG -= Handle command [QUERY_HW_PARAM]

01.09.22 12:47:04.718 | AlsaPcm   &nb= sp;     | DBG - Query pcm device default for HW paramet= ers

01.09.22 12:47:04.718 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.718 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.727 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.727 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:3<= /o:p>

01.09.22 12:47:04.727 | CommandHandler  | DBG -= Handle command [WRITE]

01.09.22 12:47:04.727 | AlsaPcm   &nb= sp;     | DBG - Write to pcm device: default, size: 440= 8

01.09.22 12:47:04.727 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.727 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.729 | XenEvtchn   &= nbsp;   | DBG - Event received, port: 77

01.09.22 12:47:04.729 | StreamRing   =    | DBG - Request received, id: alsa<default>, cmd:8<= /o:p>

01.09.22 12:47:04.729 | CommandHandler  | DBG -= Handle command [TRIGGER][START]

01.09.22 12:47:04.729 | AlsaPcm   &nb= sp;     | DBG - Start

01.09.22 12:47:04.731 | CommandHandler  | DBG -= Return status: [0]

01.09.22 12:47:04.731 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 77

01.09.22 12:47:04.756 | AlsaPcm   &nb= sp;     | DBG - Frame: 0, bytes: 17632, state: 4

01.09.22 12:47:04.756 | RingBuffer   =    | DBG - Send event, port: 32, prod: 0, cons: 0, num events: 63=

01.09.22 12:47:04.756 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 76

01.09.22 12:47:04.780 | AlsaPcm   &nb= sp;     | DBG - Frame: 0, bytes: 17632, state: 4

01.09.22 12:47:04.780 | RingBuffer   =    | DBG - Send event, port: 32, prod: 1, cons: 1, num events: 63=

01.09.22 12:47:04.780 | XenEvtchn   &= nbsp;   | DBG - Notify event channel, port: 76

 

 

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB4297D06B82525583A22B58E19F7B9DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:41:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:41:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396279.636365 (Exim 4.92) (envelope-from ) id 1oTepT-0007ln-4B; Thu, 01 Sep 2022 07:41:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396279.636365; Thu, 01 Sep 2022 07:41:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTepT-0007lg-1V; Thu, 01 Sep 2022 07:41:35 +0000 Received: by outflank-mailman (input) for mailman id 396279; Thu, 01 Sep 2022 07:37:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTelB-0006uW-61 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:37:09 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0c24e2e-29c8-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 09:37:07 +0200 (CEST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-606-AEx0cldFPCGqgVkYkJxgAQ-1; Thu, 01 Sep 2022 03:37:02 -0400 Received: by mail-ej1-f70.google.com with SMTP id qf22-20020a1709077f1600b00741638c5f3cso5352653ejc.23 for ; Thu, 01 Sep 2022 00:37:02 -0700 (PDT) Received: from [192.168.0.198] (host-87-8-60-205.retail.telecomitalia.it. [87.8.60.205]) by smtp.gmail.com with ESMTPSA id u24-20020aa7d998000000b0043a61f6c389sm898086eds.4.2022.09.01.00.36.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 00:37:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0c24e2e-29c8-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662017825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w/uTT8lnpogUVhwkYNDxdhGZzOyBXG3eWWImkgPiyoM=; b=U7yVPFohHFIyKhWjeD/a2FQMSEWaNaw1al34+kWnpCjsE8xHB0FjQFiRDLCyLVRvPuKYci Tl7ncjw8hAbtETyDdMGEBzMElgsOZ5CInRgP6qgC1VPIHKoh3sJomAFPgDOn1dzCXG30tI qACbc4Vs13n3W5g3iWCQqcwYlsKBNeM= X-MC-Unique: AEx0cldFPCGqgVkYkJxgAQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=w/uTT8lnpogUVhwkYNDxdhGZzOyBXG3eWWImkgPiyoM=; b=iYFoMMK0HAgka1mEzT9S1P6wyKtfJN7t4xjN7QEDQq2G2YUfS5yaBXwB2JlbQXgIo8 pO022JnkY5hhlb/s1n+QVuTEg5S5oYM/72zFzeHfHdm86bqDhgIpBZSkCl47BhsHIBoG SGTHJBsZuwh+minZJgXWev3npt9YyYG7qurHlzsz23JQJR5E3eEFWD6sdUu/UnV6zqoA eCpWg8up+UHJDqot1J23DAZPkXdTUilIs6LrTQEyAhFhHyrhQa+ETA47paCegTNSXBeY qbKGLTxkJwPJVtBKgzBU/nDZ/xxuagYrVatxi0Vo29cFaQhZdQ6GEeLT+xWZ/N2TPFeD +BeA== X-Gm-Message-State: ACgBeo3BPwWEispbyasTV03RPClFEqF5U3K7v5GDvkrt0k+9rKC6+p2J 7ufnYo+QWOUfBRL1z5qm3PeRqXfyvBL/Y5qs9Z+Mlf23G+O/pwVvYzeacZRZCuGgwfGGVOCe/6W A8ELbjpt2LKiWj98fH/RVRAfOfqQ= X-Received: by 2002:aa7:d90e:0:b0:447:986d:b71e with SMTP id a14-20020aa7d90e000000b00447986db71emr27210707edr.235.1662017821491; Thu, 01 Sep 2022 00:37:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR6JkW4ed1WqDsotybL6CAAiG40VbkLtzaIPBaAypGnjlWDX5j26Jhqen11PzZwUzZ8Rc1KOjQ== X-Received: by 2002:aa7:d90e:0:b0:447:986d:b71e with SMTP id a14-20020aa7d90e000000b00447986db71emr27210669edr.235.1662017821253; Thu, 01 Sep 2022 00:37:01 -0700 (PDT) Message-ID: <37a66a8d-859d-5a8b-e298-d0c32e2028e7@redhat.com> Date: Thu, 1 Sep 2022 09:36:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Peter Zijlstra , Kent Overstreet Cc: Mel Gorman , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831155941.q5umplytbx6offku@moria.home.lan> From: Daniel Bristot de Oliveira In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/1/22 09:05, Peter Zijlstra wrote: >> Also, ftrace can drop events. Not really ideal if under system load your memory >> accounting numbers start to drift. > You could attach custom handlers to tracepoints. If you were to replace > these unconditional code hooks of yours with tracepoints then you could > conditionally (say at boot) register custom handlers that do the > accounting you want. That is strategy in RV (kernel/trace/rv/). It is in C, but I am also adding support for monitors in bpf. The osnoise/timerlat tracers work this way too, and they are enabled on Fedora/Red Hat/SUSE... production. They will also be enabled in Ubuntu and Debian (the interwebs say). The overhead of attaching code to tracepoints (or any "attachable thing") and processing data in kernel is often lower than consuming it in user-space. Obviously, when it is possible, e.g., when you respect locking rules, etc. This paper (the basis for RV) shows a little comparison: https://bristot.me/wp-content/uploads/2019/09/paper.pdf By doing so, we also avoid problems of losing events... and you can also generate other events from your attached code. (It is also way easier to convince a maintainer to add a tracepoints or a trace events than to add arbitrary code... ;-) -- Daniel From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:41:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:41:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396282.636377 (Exim 4.92) (envelope-from ) id 1oTepq-0008Cg-Bn; Thu, 01 Sep 2022 07:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396282.636377; Thu, 01 Sep 2022 07:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTepq-0008CZ-96; Thu, 01 Sep 2022 07:41:58 +0000 Received: by outflank-mailman (input) for mailman id 396282; Thu, 01 Sep 2022 07:41:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTepn-00089g-Q6 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:41:56 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b3ba9bb-29c9-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 09:41:54 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTeoz-008LsS-Eb; Thu, 01 Sep 2022 07:41:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B9A783004C7; Thu, 1 Sep 2022 09:41:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 925E52B871FC0; Thu, 1 Sep 2022 09:41:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b3ba9bb-29c9-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qqD5irythXcXnrZi3fFnP54DNBcaxZAOs7bCGWArgiE=; b=JPARXCy/ktCTNTsI4fBC7IcPd9 h1Ve8e9JJlcq/HUSsnxiSLh1XoPZfbVU1rdEQodlDC9+02aj+Bcxsw6rWsIXY7oMM/OiD2IQxzNyg 5Jk5Da6y/GziQxfBTbJ7IyXOAmmA32b8DVnPqmNQnhPUh1azIt9r45Z7iftJFNLGQ6Q6LYgo4Bm8P MTlFFtLHpqiwrd4d92yZiDd7Q7cVpMbZRSrW5DjTv+6lzgrYGDN59E5Rt+hh2/XVBaRSLgThHqCSy HseLcL993B/RKuvpE5FDbemPV2dWr+H5GBs5aHL9ajh2cHPNHxrOHPXrU/0MhKYPqqT/RQ18mwJzs J7A2D+Bw==; Date: Thu, 1 Sep 2022 09:41:02 +0200 From: Peter Zijlstra To: Kent Overstreet Cc: Mel Gorman , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 10/30] mm: enable page allocation tagging for __get_free_pages and alloc_pages Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-11-surenb@google.com> <20220831101103.fj5hjgy3dbb44fit@suse.de> <20220831174629.zpa2pu6hpxmytqya@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831174629.zpa2pu6hpxmytqya@moria.home.lan> On Wed, Aug 31, 2022 at 01:46:29PM -0400, Kent Overstreet wrote: > Because all the counters are statically allocated, without even a pointer deref > to get to them in the allocation path (one pointer deref to get to them in the > deallocate path), that makes this _much, much_ cheaper than anything that could > be done with tracing - cheap enough that I expect many users will want to enable > it in production. You're contributing to death-by-a-thousand-cuts here. By making all this unconditional you're putting distros in a bind. Most of their users will likely not care about this, but if they enable it, they'll still pay the price for having it. Even static counters will have cache misses etc.. So yes, for the few people that actually care about this stuff, this might be a bit faster, but IMO it gets the econimics all backwards, you're making everybody pay the price instead of only those that care. Also note that you can have your tracepoint based handler have statically allocated data just fine. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 07:43:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 07:43:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396294.636388 (Exim 4.92) (envelope-from ) id 1oTeqw-0000TD-Le; Thu, 01 Sep 2022 07:43:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396294.636388; Thu, 01 Sep 2022 07:43:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeqw-0000T6-IE; Thu, 01 Sep 2022 07:43:06 +0000 Received: by outflank-mailman (input) for mailman id 396294; Thu, 01 Sep 2022 07:43:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTeqv-0000Ss-Ho for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 07:43:05 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b467620a-29c9-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 09:43:04 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTeqK-008Lun-Me; Thu, 01 Sep 2022 07:42:29 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 42B7B3004C3; Thu, 1 Sep 2022 09:42:27 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 344DD2B871FC3; Thu, 1 Sep 2022 09:42:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b467620a-29c9-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3R95H7o4Ps0Xt8Fb2RGRK8ftexUpMSTfRccKzarlwv8=; b=cEnZuv0S8882sMY0V4idR0aM/6 NqpoeC6HiiPZCRZB+q7pbcmjTYQVGKdLFuTqWdD9tmZbQHkl7gb/6TKBz1e8MgkX++zFc6yHPCNUW bF6DamNCBPgsv8c5UHXFsxGkgdo7kirLBRuOzs8d0ba612Y0O3wFEdbPjoyu0lGF3zXvBlqZddz+S SWvUETxD7iVku0Jt2FQC4wu6ha6Jn/Ir6zDNcVvdMDjBBsn19vlk5tNNqFTmcAHigv3R4+n+4+5j8 xTOiNNQQ6LoUNOPzLwFnQUrP5b7WKw+VwsS5V6FUynhnpOpiazug3AhcURUgxPCTLrmgmxVUKs64W VGRwP+zg==; Date: Thu, 1 Sep 2022 09:42:27 +0200 From: Peter Zijlstra To: Kent Overstreet Cc: Mel Gorman , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831155941.q5umplytbx6offku@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 01, 2022 at 09:05:36AM +0200, Peter Zijlstra wrote: > On Wed, Aug 31, 2022 at 11:59:41AM -0400, Kent Overstreet wrote: > > > Also, ftrace can drop events. Not really ideal if under system load your memory > > accounting numbers start to drift. > > You could attach custom handlers to tracepoints. If you were to replace > these unconditional code hooks of yours with tracepoints then you could > conditionally (say at boot) register custom handlers that do the > accounting you want. > > Nobody is mandating you use the ftrace ringbuffer to consume tracepoints. > Many people these days attach eBPF scripts to them and do whatever they > want. Look at kernel/trace/blktrace.c for a fine in-kernel !BFP example of this. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 08:01:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 08:01:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396312.636402 (Exim 4.92) (envelope-from ) id 1oTf91-0003TG-PA; Thu, 01 Sep 2022 08:01:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396312.636402; Thu, 01 Sep 2022 08:01:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTf91-0003T9-Lo; Thu, 01 Sep 2022 08:01:47 +0000 Received: by outflank-mailman (input) for mailman id 396312; Thu, 01 Sep 2022 08:01:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTf90-0003T3-RQ for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 08:01:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTf8z-00071U-Lu; Thu, 01 Sep 2022 08:01:45 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTf8z-00068V-DH; Thu, 01 Sep 2022 08:01:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/4YkO97ZB0+YoJBbEkhrVQnDzircAx4hOywRswGhpL0=; b=NKRnPbdEsufPgxbDJTF5oFMu2G 0muY5gJRVLICZiX6yQbY9fez6n70lesv7burqiCyFLRr3DI60m6G6BHqe4lDXujhwqQukwDNu//l/ QZWydy9lzdQuHkVttRsxmWt79A54Zk9ORzLWvUnm9vBHA8Y6UAt6FslD3S5oj9YZA3pM=; Message-ID: <93678e83-cec1-7e5f-89da-074480efa9d5@xen.org> Date: Thu, 1 Sep 2022 09:01:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v11 0/6] populate/unpopulate memory when domain on static allocation To: Stefano Stabellini , Penny Zheng Cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220831024041.468757-1-Penny.Zheng@arm.com> Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 31/08/2022 23:44, Stefano Stabellini wrote: > I looked at the series and patches 1-5 are ready to be committed. > > Patch 6 needs an Ack, preferably from Jan as Jan had questions on this > patch in v9. > > I plan to commit patches 1-5 in the next couple of days (and ideally > patch 6 too if an Ack comes from Jan). IIRC Jan is away this week. So I will have a look at the patch later today. Please don't commit patch #1-5 until patch #6 is ready as they don't make sense to be merged alone. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 08:05:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 08:05:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396318.636412 (Exim 4.92) (envelope-from ) id 1oTfCM-00044q-6x; Thu, 01 Sep 2022 08:05:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396318.636412; Thu, 01 Sep 2022 08:05:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfCM-00044j-4C; Thu, 01 Sep 2022 08:05:14 +0000 Received: by outflank-mailman (input) for mailman id 396318; Thu, 01 Sep 2022 08:05:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfCK-00044b-W2 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 08:05:12 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ccf2f8c7-29cc-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 10:05:11 +0200 (CEST) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-515-u-dYLgivMEqUsEiZhqSvVg-1; Thu, 01 Sep 2022 04:05:07 -0400 Received: by mail-wr1-f69.google.com with SMTP id h3-20020adfa4c3000000b002266f5ef273so2827227wrb.14 for ; Thu, 01 Sep 2022 01:05:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9e00:fec0:7e96:15cb:742? (p200300cbc7079e00fec07e9615cb0742.dip0.t-ipconnect.de. [2003:cb:c707:9e00:fec0:7e96:15cb:742]) by smtp.gmail.com with ESMTPSA id b8-20020adff908000000b00223a50b1be8sm14023827wrr.50.2022.09.01.01.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 01:05:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccf2f8c7-29cc-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662019510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fAYRQilXBeVPqddsxUYpdqrwWan1aH9ZFdN7uQibkcg=; b=CKGQGhYp0OzEWICOOMjhOTqvbuhCf81dUcj+HORrFde1xoDrqG7bxLijd7CbyWwddRQBxp av5qudocy7U2fL1sRN5Taf1MMLFggXVgi2qJ16L+FKfD0deyuWNJkD/L8IykcF/cW+oaUI jq7FU0r3tZlDSVigYNuvYFTHc5D//KQ= X-MC-Unique: u-dYLgivMEqUsEiZhqSvVg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=fAYRQilXBeVPqddsxUYpdqrwWan1aH9ZFdN7uQibkcg=; b=yncPs2ggaDz3a0ElvM+zG8RVmECk6zb9gfxTF5vuGNSuO/a1C6zbjGUISotsbgrRjj L4LKx1RZ8PlU8z9Ps/unsrayGh0Zl7ux/G7T0d1XsWZ4n4HxOttuXYILSeljsaHa0/V4 A/U/jdsxbZ1cJQUMnpiQfobyn9sJvh+ZhdyL/9JZjJWTa9oiqa4d/SiJWx/iusI4jxqV BQo+3xjs0AMPxGFR8vj3ZfTNkz4d5ORDyIVWrXFMFoCWJSoGQdAHPwmf7QVm0DVt8CBp kBOc47MNYlCDxIvQ/zDKsth1zijxNRxrVdHXSgbW+/RJwaLe5WYGFK0B60vnOljRsAGb bEWw== X-Gm-Message-State: ACgBeo1qISlkQ/qg0GCNlzjhpx40WAoYv6Ftq7UVpVYqB+p1OiUvCGfh MQIX6kSk9EuP/BBPzrLsoC2TWH5t+IJFkaXYKJ3O2nXd+s1MmN2sJfau5EFBIUqY0YwddHy8J7f yTzLzeNzTVzDyfB4xZe5TwcvKuK0= X-Received: by 2002:a05:6000:1e02:b0:226:f21c:e192 with SMTP id bj2-20020a0560001e0200b00226f21ce192mr2042384wrb.7.1662019506249; Thu, 01 Sep 2022 01:05:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5QM6ydwWB1hA+IwFTy9+Av+xz2gk8FSGg7uVj19TAsR85EeUD5rGAvr1bryTm2SFDb+vhc5g== X-Received: by 2002:a05:6000:1e02:b0:226:f21c:e192 with SMTP id bj2-20020a0560001e0200b00226f21ce192mr2042345wrb.7.1662019505980; Thu, 01 Sep 2022 01:05:05 -0700 (PDT) Message-ID: <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> Date: Thu, 1 Sep 2022 10:05:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Kent Overstreet , Michal Hocko Cc: Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications In-Reply-To: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31.08.22 21:01, Kent Overstreet wrote: > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: >> On Wed 31-08-22 11:19:48, Mel Gorman wrote: >>> Whatever asking for an explanation as to why equivalent functionality >>> cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. >> >> Fully agreed and this is especially true for a change this size >> 77 files changed, 3406 insertions(+), 703 deletions(-) > > In the case of memory allocation accounting, you flat cannot do this with ftrace > - you could maybe do a janky version that isn't fully accurate, much slower, > more complicated for the developer to understand and debug and more complicated > for the end user. > > But please, I invite anyone who's actually been doing this with ftrace to > demonstrate otherwise. > > Ftrace just isn't the right tool for the job here - we're talking about adding > per callsite accounting to some of the fastest fast paths in the kernel. > > And the size of the changes for memory allocation accounting are much more > reasonable: > 33 files changed, 623 insertions(+), 99 deletions(-) > > The code tagging library should exist anyways, it's been open coded half a dozen > times in the kernel already. Hi Kent, independent of the other discussions, if it's open coded already, does it make sense to factor that already-open-coded part out independently of the remainder of the full series here? [I didn't immediately spot if this series also attempts already to replace that open-coded part] -- Thanks, David / dhildenb From xen-devel-bounces@lists.xenproject.org Thu Sep 01 08:34:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 08:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396325.636423 (Exim 4.92) (envelope-from ) id 1oTfec-0007Mj-Ee; Thu, 01 Sep 2022 08:34:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396325.636423; Thu, 01 Sep 2022 08:34:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfec-0007Mc-Be; Thu, 01 Sep 2022 08:34:26 +0000 Received: by outflank-mailman (input) for mailman id 396325; Thu, 01 Sep 2022 08:34:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfeb-0007MS-44; Thu, 01 Sep 2022 08:34:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfeb-0007X6-2A; Thu, 01 Sep 2022 08:34:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfea-0003qc-M4; Thu, 01 Sep 2022 08:34:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTfea-0001e9-Lh; Thu, 01 Sep 2022 08:34:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WCUyqdclcFogqYkLb4n4Y+bgaa5VS0DLxJHG10qWR8o=; b=ZydD4zhO/JEo/63bFpMJljGb8k WaFR1EU91CCxTqkDRQ3AJJLqhV5IBefiTDxPngp6UM42IZ2zBeOmYIbJcpcmNvug0nvD35qa4powe tjuAmCjzjkHMsNc4QyZQz7kZ4ZOnbkFHjckTFBq4IR9Ce8qN8Zxrn8jk8/yW0lYK80SQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172906: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=31a94f7fba2a2c1244fc35b6f631e235e267715b X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 01 Sep 2022 08:34:24 +0000 flight 172906 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172906/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 31a94f7fba2a2c1244fc35b6f631e235e267715b baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 217 attempts Testing same since 172896 2022-08-31 17:13:15 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Ray Ni Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1231 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 08:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 08:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396335.636435 (Exim 4.92) (envelope-from ) id 1oTfna-0000TL-GG; Thu, 01 Sep 2022 08:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396335.636435; Thu, 01 Sep 2022 08:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfna-0000TE-Ct; Thu, 01 Sep 2022 08:43:42 +0000 Received: by outflank-mailman (input) for mailman id 396335; Thu, 01 Sep 2022 08:43:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTfnY-0000T8-Sd for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 08:43:41 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d08a153-29d2-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 10:43:39 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id y10so13995550ljq.0 for ; Thu, 01 Sep 2022 01:43:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d08a153-29d2-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=VH72CkJdWHRYjuIFqG3YYZtTrJw2Fhi5jnFxkucPCHY=; b=q7AjWjhmnd64a4Ge80aSMXzM40DYISK3cXmW/EibDBVwJ+8k/kXbGydZOb9luK+PIZ Ht/KjsMCWD5TF/twQCHm6itfvd6g64oIsvl5c5eKge4E9VhNnF7iOxqToHuyozIfoFb1 5I88bd1UfHObAquK0acXH+XbI6Py13HNPo09dD+NGiTxpVgIr43RQcU5305AlaqKPpll qwKybw5Q2+9d/Onlv8u1vDEdJlLQ1JUMSCRevC4eAiHePyL2wzZzh3KSvr/OLrTmD05T eLyu3SeubEOLjLKn16wG4v4TsahkBmU2CrHwp0/PiiByarcOmjtEcsv6KWve7EKHFu99 DiuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=VH72CkJdWHRYjuIFqG3YYZtTrJw2Fhi5jnFxkucPCHY=; b=lsmsfhCTiXH+cDpwDje+ReDMHEd02H9nyT0tUUjF5q1rNxBukv9TOMLloSZHOGF2pL HOZDvWi6yQ3emDmB/nAlqIfs2urnchlyPmMulEKcAjsFiDkqQRVtg4EVAoOvDrLDWRMb LjYYtequGpkSnsXSqVHw4uULEK8vuUhYLi47HyOrKddjU/l8SrtTDAXaaEt+8FVcLV0b r0WuhMsUhAq+bN0MfTNV1qQWPi9MwYGTam8HmBOM/hAzqhdvT71wrckDVwnEZr4Pqvef TELVFfw3ku31k1ZgnXgMhOnQHOYeNplsQ5FgOCsEbBUo7UlFYIbZFPjRVhgxMMKcRx0K /rng== X-Gm-Message-State: ACgBeo3Ll3LDqZtPDpBq8dwjYAeDYvQLb7PUhDERIYB7TkXsoPGp5zG3 7Te1mZO4fH5cb+VVloWSWto3dl/VEy5MEoytPyyLQQ== X-Google-Smtp-Source: AA6agR4BjD3DwjS+CZ4CCVxEVQ6+miy/r1+fo/IQYDRJogJb7LowD/eAhVezdlkQzk6xOh63IrvI7g9qP1YqXlNutus= X-Received: by 2002:a2e:be88:0:b0:25f:e9a8:44b8 with SMTP id a8-20020a2ebe88000000b0025fe9a844b8mr8851946ljr.92.1662021818766; Thu, 01 Sep 2022 01:43:38 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-23-surenb@google.com> <20220831173010.wc5j3ycmfjx6ezfu@moria.home.lan> In-Reply-To: <20220831173010.wc5j3ycmfjx6ezfu@moria.home.lan> From: Dmitry Vyukov Date: Thu, 1 Sep 2022 10:43:26 +0200 Message-ID: Subject: Re: [RFC PATCH 22/30] Code tagging based fault injection To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, 31 Aug 2022 at 19:30, Kent Overstreet wrote: > > > From: Kent Overstreet > > > > > > This adds a new fault injection capability, based on code tagging. > > > > > > To use, simply insert somewhere in your code > > > > > > dynamic_fault("fault_class_name") > > > > > > and check whether it returns true - if so, inject the error. > > > For example > > > > > > if (dynamic_fault("init")) > > > return -EINVAL; > > > > Hi Suren, > > > > If this is going to be used by mainline kernel, it would be good to > > integrate this with fail_nth systematic fault injection: > > https://elixir.bootlin.com/linux/latest/source/lib/fault-inject.c#L109 > > > > Otherwise these dynamic sites won't be tested by testing systems doing > > systematic fault injection testing. > > That's a discussion we need to have, yeah. We don't want two distinct fault > injection frameworks, we'll have to have a discussion as to whether this is (or > can be) better enough to make a switch worthwhile, and whether a compatibility > interface is needed - or maybe there's enough distinct interesting bits in both > to make merging plausible? > > The debugfs interface for this fault injection code is necessarily different > from our existing fault injection - this gives you a fault injection point _per > callsite_, which is huge - e.g. for filesystem testing what I need is to be able > to enable fault injection points within a given module. I can do that easily > with this, not with our current fault injection. > > I think the per-callsite fault injection points would also be pretty valuable > for CONFIG_FAULT_INJECTION_USERCOPY, too. > > OTOH, existing kernel fault injection can filter based on task - this fault > injection framework doesn't have that. Easy enough to add, though. Similar for > the interval/probability/ratelimit stuff. > > fail_function is the odd one out, I'm not sure how that would fit into this > model. Everything else I've seen I think fits into this model. > > Also, it sounds like you're more familiar with our existing fault injection than > I am, so if I've misunderstood anything about what it can do please do correct > me. What you are saying makes sense. But I can't say if we want to do a global switch or not. I don't know how many existing users there are (by users I mean automated testing b/c humans can switch for one-off manual testing). However, fail_nth that I mentioned is orthogonal to this. It's a different mechanism to select the fault site that needs to be failed (similar to what you mentioned as "interval/probability/ratelimit stuff"). fail_nth allows to fail the specified n-th call site in the specified task. And that's the only mechanism we use in syzkaller/syzbot. And I think it can be supported relatively easily (copy a few lines to the "does this site needs to fail" check). I don't know how exactly you want to use this new mechanism, but I found fail_nth much better than any of the existing selection mechanisms, including what this will add for specific site failing. fail_nth allows to fail every site in a given test/syscall one-by-one systematically. E.g. we can even have strace-like utility that repeats the given test failing all sites in to systematically: $ fail_all ./a_unit_test This can be integrated into any CI system, e.g. running all LTP tests with this. For file:line-based selection, first, we need to get these file:line from somewhere; second, lines are changing over time so can't be hardcoded in tests; third, it still needs to be per-task, since unrelated processes can execute the same code. One downside of fail_nth, though, is that it does not cover background threads/async work. But we found that there are so many untested synchronous error paths, that moving to background threads is not necessary at this point. > Interestingly: I just discovered from reading the code that > CONFIG_FAULT_INJECTION_STACKTRACE_FILTER is a thing (hadn't before because it > depends on !X86_64 - what?). That's cool, though. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 08:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 08:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396342.636446 (Exim 4.92) (envelope-from ) id 1oTg1b-00020s-Oe; Thu, 01 Sep 2022 08:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396342.636446; Thu, 01 Sep 2022 08:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTg1b-00020l-Jy; Thu, 01 Sep 2022 08:58:11 +0000 Received: by outflank-mailman (input) for mailman id 396342; Thu, 01 Sep 2022 08:58:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTg1a-00020a-7V for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 08:58:10 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31a698a4-29d4-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 10:58:07 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by PH7PR12MB7019.namprd12.prod.outlook.com (2603:10b6:510:1b9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 08:58:04 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d%4]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 08:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31a698a4-29d4-11ed-934f-f50d60e1c1bd ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2K65Hx2NGMftvP15LTp5HKyllDvXqjuTN1v7Dbnwfhe/C0qnW6xrqvBe/7nJvFSHqFvupl+BxU45CNj2eIAEfFxVq9cDuCmyzud2O4vOO+gZZC2ebvlNNG3wgcIN1IT5VhgSYe7IPUCoOXmAcoNzhhGtf8jsPW3ipbmu9kOKE16TlOZ/HFqb2VGpeZgbxU3zgSL5Cwo7FtkknnD/0DXVlcLPmNDv4Wry6zMq7OMiyIeSmegB8xsOu8D1zM0IC9fhGi8bBNlzBPo9uDfyhqoxbJGzmdlbeWXb4nvwvC1DsCZWq4Zihx7uwp7t1Qy6FUGdYIdDXYfGQpFzvzJwVE/bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZmSdwmjuOadBollNkjGyMebwChLzyTxxrhqg6v+V48=; b=gaR71plVDEuC8Is1rPtxuXPEZCD0WVth2zBUmLlOwSh0yoe0D8ViISpnYKc1PX8nKvj73qlStH50ibffZs0J9/MBOImBVtX3u22amRleVV9nPHPwdR965G0W1OdjzE4fZjMz26d61dpMrszJWoe+NNnNJzS1ADPwqUpW8KwUHizLoiqwKw+LgZZJEzH9eFT9JPw/2COW1A2YM8OKOGI0th61IeXWiucGtdEottyvEHlUA8sLK01BcaQXEhyOpXJTdqQGrNfmtdZX9Kengd6wDAy0oaOwrMFRI2wjA084TAs6Ehw8KkDI4kEGX4NUsINSkbqT1ki+p0glilt3UHc+nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PZmSdwmjuOadBollNkjGyMebwChLzyTxxrhqg6v+V48=; b=G7Wm5pqE2xhN8Yn133Khv+WD6AulahYXNqpTxLMqu2GuSwNWDlB2RIIK1PBy9VgIoCKsVg+CVIsg1/SzAMrVXYxENLXW7ziEB2NxRCEZms5zfPJF/nPz1JFPtUo54ZeRJ0xi4Ljee9Yzyo+NZMhWDmEgvJWjmS1B5PocnIjVeTA= From: "SHARMA, JYOTIRMOY" To: "SHARMA, JYOTIRMOY" CC: "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "olekstysh@gmail.com" , "Stabellini, Stefano" , "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" Subject: Re: Enable audio virtualization in Xen Thread-Topic: Re: Enable audio virtualization in Xen Thread-Index: Adi94EXouXveB4LpT0u/A4RVLH5W1g== Date: Thu, 1 Sep 2022 08:58:04 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-01T08:58:02Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=92e77bf1-b390-4127-ac4b-079d8e040c26; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c338d8d6-8dab-4043-3fd8-08da8bf814ce x-ms-traffictypediagnostic: PH7PR12MB7019:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +dkJc6hbOHpQXLaszFmvU918+LPwvHZaSp+9RGJ9MHtzMvTzEPEFIiIRO9xZWtleIs0qsKv8QKVNCB7LnpQ8n0ZGgrB3vx1dsA5KZg6Ey6AS69kb8vkdqrZSzemkcn6jCdh3RT8MNeXgrbMFT9sjb1BwUSLXRV6PaCChdP3x1jH3wq4Sz/fp5/hBTJSrhNaHho0o8MWox6tC36XlQ5mKNbIByP7ctnMEFeA9bOkorkCHnASHAEm4bEMBau2NxqF01NUFy16KuGS/YDjciiV1Z5hV8wja1ZKaooFNOp5eN53wpk9x8n8vruqeyBQQ/zvt1V7DcJjo0VdjUh61Z/t2yZBomnHJoZe6kIZ8bG2EfF/mW75xBQuk135dOBWAKUkv/X9v+PciyLQ2E13tmOgYe7X3vjgQ8hoFN4nxSlUnQS2GW6z9Y0nLCZmw3R3iyL/9X/xVsQ+mcfv3padDrkcVkJYu5+hx0hhsnbrMoKY726RzpJQaQrK1I/gUzXY6q031/wyH2UkwEQZe9MRSkBs+bhFrr5JtvisXiicJmxpUi4g4tIfBVgoKhEoruD3Vn+7KQxBPpP9KpSsijLYX1BjGpUAhd0VyDOe/vXVDDeK9+FaJfTyZH14KfYCpU8CFbpYK5+gJ3FrAN/2NW0NDqDdGAUZUsyAk2K1BPO15DQN7zbMkvY8HzJGoCQ0Vc+dBgT5m2lg/5dj3fmynZQYRfHehiM5eaiH2osBVx8jAMi67Pz9GUJ8gTwV0NNQvKAc0m+wv1tMuEiXm91SYtwy9fcKINw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(71200400001)(9686003)(6506007)(33656002)(26005)(41300700001)(186003)(38100700002)(86362001)(38070700005)(478600001)(7696005)(66946007)(55016003)(5660300002)(6200100001)(8676002)(76116006)(6862004)(66446008)(64756008)(122000001)(54906003)(316002)(4326008)(52536014)(8936002)(66476007)(66556008)(4744005)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IV6urucgFdueE/u4T2ZM4YB/8RcXjyG5IE4PgI2eqz+ecF/K3ViMul2pQhIP?= =?us-ascii?Q?I9Zzt9VyjKruOIQG+VJXrIZc09/JyyrU/ykAV7RHKSPMPRYST/rTweyDoq8E?= =?us-ascii?Q?bHoqNuPA8ScIJKnWrBmKLpAJqjSW6aIC4yXojH4wI83GC5fsMUdHGc/z3uHk?= =?us-ascii?Q?fAAsfKnoEe9xhx2RXFicRFIpFkXQ8dDN0Lt1GWTL+YICQeMPrzztt/SYNM14?= =?us-ascii?Q?RCF6pWCRaH64aNd3hJIuDy99T3/n9DeuLbxzyE3NSG4N+Xebd3cn4kpFOd84?= =?us-ascii?Q?oZ7O/Lbs95vS/VMW32DJu/WB/eKzZ3RM+HqHdxzw9Cy9wkcTL09jpU+z4XMY?= =?us-ascii?Q?Gcm99uL6nb4EEeBn/lMRaQN5n8FI5vPMgxsIdic8+sj75IFwbZ8YNRNmi1Ud?= =?us-ascii?Q?VvdQTlRmxzX4pdTzLD6YJNt9L1WurZAEEACE8sq8kJGqOVuGFfZDPIMAB68V?= =?us-ascii?Q?xvQvhwYJA7bm3EM309m272/Twc34di2w9JO3k0u9h0dX0qYSi1k2IIPsu8T5?= =?us-ascii?Q?r7LDdNK1rwR5puF0d0FLjpNL5R4hcNyrz3MhdiHwSMMAKX5nLhZLmsMZzzHR?= =?us-ascii?Q?XsTl35eq9Hn6SrcEZJwJ46VMY0vBRSd2FoOT0HKL+jIVwaSo/Y6l9Qa0h9HA?= =?us-ascii?Q?DB1yE5Eha19tvbqPypmAv+DpaklLnfykfuiCxsgf7jsJXG7AkgV8m4F7suB8?= =?us-ascii?Q?u/bgDeAZmgT3rg6tpkNU4xnb5WnHKgbWJKUBzRCuD5nMP8hLAnWghLvdwu2C?= =?us-ascii?Q?5Imj0aaAxR9oO5z4M5J20RmkGjqaiQjkgkdFOHiPHaQ9qEVtg+OiWB8kjhxQ?= =?us-ascii?Q?wGrBjp+Z41t1v+lmgPsYpTgQ8uSb5+fKIgDHNtnZokpz+wa7ZjiNH0o/uEra?= =?us-ascii?Q?UKUbji8BSrsoIPx8L2bOTmC9NjfN2bXDNH7s5nyad2S7juwxGLHRYVm+Gr2K?= =?us-ascii?Q?Zbn/Cag32h4nE/Rb9bFqX54d/AevdrijBhgbFYE1YT9d4Xbp/1cLAaqatokf?= =?us-ascii?Q?5ag/Hg/nrFmL5PI9NHbT1nJa4oRU+t/uoSaD8gtpRKj66qruEELA75F9sZ/U?= =?us-ascii?Q?CpW7RX+ZvYWaMXNVSAV3SOKHXb67US4xeFkY1v3Cy+Do0x7xs0ts+36uHA2z?= =?us-ascii?Q?dYDFT4A3XS3+4j4Z6YVrqhyhHtyYTehksUWEeyS2A8UQKLyUo+hOFtLdBwxd?= =?us-ascii?Q?SXWX2849wf79x2EcjKhDZJV7maJCkCEVQhY1U5NPl5bEPQv1MTMnY4VvkmRe?= =?us-ascii?Q?MKNgiH1HlfchmyIEUYanilB1mG9IoAsV5KV/UApNQfUCPeQ2BkTG5WbBiBdq?= =?us-ascii?Q?9stNtSO0pM++GNfm9yO7f6gXTcuzpJPK/ndWGoeOcJbN4Hvy71QdDDtM8fms?= =?us-ascii?Q?HeqReSN2xNDCi/5EDsYckDaO1/4k6R/9C18J2JZfyTpiF/UEhWJzls9+CW1v?= =?us-ascii?Q?UOFYInAN7iML+6rygb/UAzPOaLw+ZhjE5WVdKefoS1+vCcP7UM6gt+fvhvQi?= =?us-ascii?Q?Cj6rXEnkMuuOnxYYLa9sfeleCtm7TtdbVY12+6JAy/R9PLKSqP5BpSOxWsRR?= =?us-ascii?Q?lJ1YBgdvQTb7uL5qkEBl/Hi3tnC8nCpH1xsfmz+q?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB42978C6A0680DD661E24D1E59F7B9DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c338d8d6-8dab-4043-3fd8-08da8bf814ce X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 08:58:04.3085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ltH2DVxBZtnxPpST7ugVBRWT8Sc+UgzNuuOraloUqlOzvD3DOXnlxkOC6S2/d+nTPVX/Fsq7d/c80aZjrDK9vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7019 --_000_DM6PR12MB42978C6A0680DD661E24D1E59F7B9DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi all, Forgot to mention that I am able to play audio from HVM guest with Pulse Au= dio as back end. Here is the corresponding HVM configuration: vsnd =3D [[ 'card, backend=3DDomain-0, buffer-size=3D65536, short-name=3DVC= ard, long-name=3DVirtual sound card, sample-rates=3D44100, sample-formats= =3Ds16_le', 'pcm, name=3Ddev1', 'stream, unique-id=3Dpulse, type=3DP' ]] I have used xen front end and snd_be (along with libxenbe) as back end as s= uggested by Christopher earlier in this thread. Only when I change unique-id=3Dalsa, audio is not working from HVM guest. If anyone has tried ALSA back end (instead of PA), please let me know what = I am missing. Regards, Jyotirmoy --_000_DM6PR12MB42978C6A0680DD661E24D1E59F7B9DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


Hi all,

 

Forgot to mention that I am able to play audio from = HVM guest with Pulse Audio as back end. Here is the corresponding HVM confi= guration:

 

vsnd =3D [[ 'card, backend=3DDomain-0, buffer-size= =3D65536, short-name=3DVCard, long-name=3DVirtual sound card, sample-rates= =3D44100, sample-formats=3Ds16_le', 'pcm, name=3Ddev1', 'stream, unique-id= =3Dpulse, type=3DP' ]]

 

I have used xen front end and snd_be (along with lib= xenbe) as back end as suggested by Christopher earlier in this thread.=

 

Only when I change unique-id=3Dalsa, audio is not wo= rking from HVM guest.

 

If anyone has tried ALSA back end (instead of PA), p= lease let me know what I am missing.

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB42978C6A0680DD661E24D1E59F7B9DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:02:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:02:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396350.636461 (Exim 4.92) (envelope-from ) id 1oTg5Q-0003TM-BI; Thu, 01 Sep 2022 09:02:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396350.636461; Thu, 01 Sep 2022 09:02:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTg5Q-0003TF-8I; Thu, 01 Sep 2022 09:02:08 +0000 Received: by outflank-mailman (input) for mailman id 396350; Thu, 01 Sep 2022 09:02:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTg5P-0003T5-CE; Thu, 01 Sep 2022 09:02:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTg5P-00082c-9m; Thu, 01 Sep 2022 09:02:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTg5O-0005je-Qo; Thu, 01 Sep 2022 09:02:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTg5O-00041n-QJ; Thu, 01 Sep 2022 09:02:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/S2varV2i8c97mQ7mngc1t4n8z5ZJULYDbsb4NtMG4A=; b=QxIFgvurwl+zRYzsfu5vigDG7r nxCg4wiWFO9r85H9eT9Nc3cATn6brrzgPhyj8Vd0a8HCjxu0y9xZq79sJCJQN4l3yjXMcc++AVO4f uptQpUP8RH9baiMr3LdOWxnY8wd6b3v9mtFJei61YpM/qoWPCkeTkf6ZQ7lHXihFFy34=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 172901: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ace403022358b736755e3042e949540e775c65f1 X-Osstest-Versions-That: xen=cbb35e72802f3a285c382a995ef647b59e5caf2f From: osstest service owner Date: Thu, 01 Sep 2022 09:02:06 +0000 flight 172901 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172901/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172882 build-i386-libvirt 6 libvirt-build fail like 172882 build-arm64-libvirt 6 libvirt-build fail like 172882 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172882 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172882 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172882 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172882 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172882 build-armhf-libvirt 6 libvirt-build fail like 172882 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172882 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172882 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172882 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172882 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ace403022358b736755e3042e949540e775c65f1 baseline version: xen cbb35e72802f3a285c382a995ef647b59e5caf2f Last test of basis 172882 2022-08-31 01:53:15 Z 1 days Testing same since 172901 2022-08-31 22:08:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git cbb35e7280..ace4030223 ace403022358b736755e3042e949540e775c65f1 -> master From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:13:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396359.636471 (Exim 4.92) (envelope-from ) id 1oTgGH-00052K-F7; Thu, 01 Sep 2022 09:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396359.636471; Thu, 01 Sep 2022 09:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgGH-00052D-CU; Thu, 01 Sep 2022 09:13:21 +0000 Received: by outflank-mailman (input) for mailman id 396359; Thu, 01 Sep 2022 09:13:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgGF-000527-Tj for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:13:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 503a7b53-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:13:16 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4955D6E; Thu, 1 Sep 2022 02:13:22 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C395D3F766; Thu, 1 Sep 2022 02:13:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 503a7b53-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: [PATCH v3 0/7] xen/evtchn: implement static event channel signaling Date: Thu, 1 Sep 2022 10:12:59 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The purpose of this patch series is to add the static event channel signaling support to Xen on Arm based on design doc [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg01160.html Julien Grall (1): xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Rahul Singh (6): xen/evtchn: Add an helper to reserve/allocate a port xen/evtchn: restrict the maximum number of evtchn supported for domUs xen/evtchn: modify evtchn_alloc_unbound to allocate specified port xen/evtchn: modify evtchn_bind_interdomain to support static evtchn xen/arm: introduce xen-evtchn dom0less property xen/arm: introduce new xen,enhanced property value docs/misc/arm/device-tree/booting.txt | 68 +++++++++++- xen/arch/arm/domain_build.c | 148 +++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 3 + xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 2 + xen/common/event_channel.c | 121 +++++++++++++-------- xen/include/xen/device_tree.h | 13 +++ xen/include/xen/event.h | 8 +- 8 files changed, 313 insertions(+), 51 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:13:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:13:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396361.636483 (Exim 4.92) (envelope-from ) id 1oTgGc-0005T3-NE; Thu, 01 Sep 2022 09:13:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396361.636483; Thu, 01 Sep 2022 09:13:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgGc-0005Sw-K8; Thu, 01 Sep 2022 09:13:42 +0000 Received: by outflank-mailman (input) for mailman id 396361; Thu, 01 Sep 2022 09:13:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgGb-000527-3D for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:13:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5dbec31a-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:13:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91EC6D6E; Thu, 1 Sep 2022 02:13:45 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1AEC63F766; Thu, 1 Sep 2022 02:13:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dbec31a-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Date: Thu, 1 Sep 2022 10:13:00 +0100 Message-Id: <2b7be7ea9f2f06939ebc185490196f20614b6a3b.1662023183.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event channels code assumes that all the buckets below d->valid_evtchns are always allocated. This assumption hold in most of the situation because a guest is not allowed to chose the port. Instead, it will be the first free from port 0. When static event channel support will be added for dom0less domains user can request to allocate the evtchn port numbers that are scattered in nature. The existing implementation of evtchn_allocate_port() is not able to deal with such situation and will end up to override bucket or/and leave some bucket unallocated. The latter will result to a droplet crash if the event channel belongs to an unallocated bucket. This can be solved by making sure that all the buckets below d->valid_evtchns are allocated. There should be no impact for most of the situation but LM/LU as only one bucket would be allocated. For LM/LU, we may end up to allocate multiple buckets if ports in use are sparse. A potential alternative is to check that the bucket is valid in is_port_valid(). This should still possible to do it without taking per-domain lock but will result a couple more of memory access. Signed-off-by: Julien Grall Signed-off-by: Rahul Singh --- Changes in v3: - fix comments in commit msg. - modify code related to d->valid_evtchns and {read,write}_atomic() Changes in v2: - new patch in this version to avoid the security issue --- xen/common/event_channel.c | 55 ++++++++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 20 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index c2c6f8c151..80b06d9743 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -193,6 +193,15 @@ static struct evtchn *alloc_evtchn_bucket(struct domain *d, unsigned int port) return NULL; } +/* + * Allocate a given port and ensure all the buckets up to that ports + * have been allocated. + * + * The last part is important because the rest of the event channel code + * relies on all the buckets up to d->valid_evtchns to be valid. However, + * event channels may be sparsed when restoring a domain during Guest + * Transparent Migration and Live Update. + */ int evtchn_allocate_port(struct domain *d, evtchn_port_t port) { if ( port > d->max_evtchn_port || port >= max_evtchns(d) ) @@ -207,30 +216,36 @@ int evtchn_allocate_port(struct domain *d, evtchn_port_t port) } else { - struct evtchn *chn; - struct evtchn **grp; + unsigned int alloc_port = read_atomic(&d->valid_evtchns); - if ( !group_from_port(d, port) ) + do { - grp = xzalloc_array(struct evtchn *, BUCKETS_PER_GROUP); - if ( !grp ) - return -ENOMEM; - group_from_port(d, port) = grp; - } + struct evtchn *chn; + struct evtchn **grp; - chn = alloc_evtchn_bucket(d, port); - if ( !chn ) - return -ENOMEM; - bucket_from_port(d, port) = chn; + if ( !group_from_port(d, alloc_port) ) + { + grp = xzalloc_array(struct evtchn *, BUCKETS_PER_GROUP); + if ( !grp ) + return -ENOMEM; + group_from_port(d, alloc_port) = grp; + } - /* - * d->valid_evtchns is used to check whether the bucket can be - * accessed without the per-domain lock. Therefore, - * d->valid_evtchns should be seen *after* the new bucket has - * been setup. - */ - smp_wmb(); - write_atomic(&d->valid_evtchns, d->valid_evtchns + EVTCHNS_PER_BUCKET); + chn = alloc_evtchn_bucket(d, alloc_port); + if ( !chn ) + return -ENOMEM; + bucket_from_port(d, alloc_port) = chn; + + /* + * d->valid_evtchns is used to check whether the bucket can be + * accessed without the per-domain lock. Therefore, + * d->valid_evtchns should be seen *after* the new bucket has + * been setup. + */ + smp_wmb(); + alloc_port += EVTCHNS_PER_BUCKET; + write_atomic(&d->valid_evtchns, alloc_port); + } while ( port >= alloc_port ); } write_atomic(&d->active_evtchns, d->active_evtchns + 1); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:14:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396371.636494 (Exim 4.92) (envelope-from ) id 1oTgH3-00064C-Vy; Thu, 01 Sep 2022 09:14:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396371.636494; Thu, 01 Sep 2022 09:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgH3-000645-Si; Thu, 01 Sep 2022 09:14:09 +0000 Received: by outflank-mailman (input) for mailman id 396371; Thu, 01 Sep 2022 09:14:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgH2-000527-8t for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:14:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6e0f5312-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:14:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09029D6E; Thu, 1 Sep 2022 02:14:13 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B4363F766; Thu, 1 Sep 2022 02:14:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e0f5312-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Stanislav Kinsburskii , Julien Grall Subject: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port Date: Thu, 1 Sep 2022 10:13:01 +0100 Message-Id: <4f8f5abdb7d9dfb241794375d3705524b5b53490.1662023183.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In a follow-up patch we will want to either reserve or allocate a port for various event channel helpers. A new wrapper is introduced to either reserve a given port or allocate a fresh one if zero. Take the opportunity to replace the open-coded version in evtchn_bind_virq(). Signed-off-by: Stanislav Kinsburskii Signed-off-by: Julien Grall Signed-off-by: Rahul Singh Acked-by: Jan Beulich --- Changes in v3: - minor comments in commit msg Changes in v2: - new patch in this version --- xen/common/event_channel.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 80b06d9743..ef4da0781d 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -305,6 +305,18 @@ void evtchn_free(struct domain *d, struct evtchn *chn) xsm_evtchn_close_post(chn); } +static int evtchn_get_port(struct domain *d, evtchn_port_t port) +{ + int rc; + + if ( port != 0 ) + rc = evtchn_allocate_port(d, port); + else + rc = get_free_port(d); + + return rc ?: port; +} + int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) { struct evtchn *chn; @@ -462,19 +474,10 @@ int evtchn_bind_virq(evtchn_bind_virq_t *bind, evtchn_port_t port) if ( read_atomic(&v->virq_to_evtchn[virq]) ) ERROR_EXIT(-EEXIST); - if ( port != 0 ) - { - if ( (rc = evtchn_allocate_port(d, port)) != 0 ) - ERROR_EXIT(rc); - } - else - { - int alloc_port = get_free_port(d); - - if ( alloc_port < 0 ) - ERROR_EXIT(alloc_port); - port = alloc_port; - } + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; chn = evtchn_from_port(d, port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:14:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396374.636505 (Exim 4.92) (envelope-from ) id 1oTgHL-0006YX-6T; Thu, 01 Sep 2022 09:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396374.636505; Thu, 01 Sep 2022 09:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgHL-0006YQ-3P; Thu, 01 Sep 2022 09:14:27 +0000 Received: by outflank-mailman (input) for mailman id 396374; Thu, 01 Sep 2022 09:14:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgHJ-000527-UK for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:14:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 789bd957-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:14:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8EE1D6E; Thu, 1 Sep 2022 02:14:30 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C9DF3F766; Thu, 1 Sep 2022 02:14:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 789bd957-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Date: Thu, 1 Sep 2022 10:13:02 +0100 Message-Id: <4ae16201df27aee274a3d740128812b118c252b3.1662023183.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Set the default value of max_evtchn_port to 1023. The value of 1023 should be sufficient for domUs guests because on ARM we don't bind physical interrupts to event channels. The only use of the evtchn port is inter-domain communications. Signed-off-by: Rahul Singh --- Changes in v3: - added in commit msg why we set the max_evtchn_port value to 1023. - added the comment in code also why we set the max_evtchn_port to 1023 - remove the define and set the value to 1023 in code directly. Changes in v2: - new patch in the version --- xen/arch/arm/domain_build.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..fde133cd94 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3277,7 +3277,13 @@ void __init create_domUs(void) struct xen_domctl_createdomain d_cfg = { .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - .max_evtchn_port = -1, + /* + * The default of 1023 should be sufficient for domUs guests + * because on ARM we don't bind physical interrupts to event + * channels. The only use of the evtchn port is inter-domain + * communications. + */ + .max_evtchn_port = 1023, .max_grant_frames = -1, .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:19:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396387.636520 (Exim 4.92) (envelope-from ) id 1oTgLl-0007So-0j; Thu, 01 Sep 2022 09:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396387.636520; Thu, 01 Sep 2022 09:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgLk-0007Ro-St; Thu, 01 Sep 2022 09:19:00 +0000 Received: by outflank-mailman (input) for mailman id 396387; Thu, 01 Sep 2022 09:19:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgI5-000527-2e for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:15:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 949126c1-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:15:11 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BC8ED6E; Thu, 1 Sep 2022 02:15:17 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23B3F3F766; Thu, 1 Sep 2022 02:15:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 949126c1-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v3 5/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn Date: Thu, 1 Sep 2022 10:13:04 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Static event channel support will be added for dom0less domains. Modify evtchn_bind_interdomain to support static evtchn. It is necessary to have access to the evtchn_bind_interdomain function to do that, so make evtchn_bind_interdomain global and also make it __must_check. Currently evtchn_bind_interdomain() always allocates the next available local port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_bind_interdomain to accept the port number as an argument and allocate the specified port if available. If the port number argument is zero, the next available port will be allocated. Currently evtchn_bind_interdomain() finds the local domain from "current->domain" pointer. evtchn_bind_interdomain() will be called from the XEN to create static event channel during domain creation. "current" pointer is not valid at that time, therefore modify the evtchn_bind_interdomain() to pass domain as an argument. Signed-off-by: Rahul Singh Acked-by: Jan Beulich Reviewed-by: Julien Grall --- Changes in v3: - fix minor comments in commit msg Changes in v2: - Merged patches related to evtchn_bind_interdomain in one patch --- xen/common/event_channel.c | 20 ++++++++++++++------ xen/include/xen/event.h | 5 +++++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index b464f09d2a..19832002aa 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -381,11 +381,16 @@ static void double_evtchn_unlock(struct evtchn *lchn, struct evtchn *rchn) evtchn_write_unlock(rchn); } -static int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) +/* + * If lport is zero get the next free port and allocate. If port is non-zero + * allocate the specified lport. + */ +int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, struct domain *ld, + evtchn_port_t lport) { struct evtchn *lchn, *rchn; - struct domain *ld = current->domain, *rd; - int lport, rc; + struct domain *rd; + int rc; evtchn_port_t rport = bind->remote_port; domid_t rdom = bind->remote_dom; @@ -405,8 +410,11 @@ static int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) write_lock(&ld->event_lock); } - if ( (lport = get_free_port(ld)) < 0 ) - ERROR_EXIT(lport); + lport = rc = evtchn_get_port(ld, lport); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; + lchn = evtchn_from_port(ld, lport); rchn = _evtchn_from_port(rd, rport); @@ -1239,7 +1247,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) struct evtchn_bind_interdomain bind_interdomain; if ( copy_from_guest(&bind_interdomain, arg, 1) != 0 ) return -EFAULT; - rc = evtchn_bind_interdomain(&bind_interdomain); + rc = evtchn_bind_interdomain(&bind_interdomain, current->domain, 0); if ( !rc && __copy_to_guest(arg, &bind_interdomain, 1) ) rc = -EFAULT; /* Cleaning up here would be a mess! */ break; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index f31963703f..8eae9984a9 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -75,6 +75,11 @@ int evtchn_allocate_port(struct domain *d, unsigned int port); int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, evtchn_port_t port); +/* Bind an event channel port to interdomain */ +int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, + struct domain *ld, + evtchn_port_t port); + /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:19:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396386.636516 (Exim 4.92) (envelope-from ) id 1oTgLk-0007Px-PG; Thu, 01 Sep 2022 09:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396386.636516; Thu, 01 Sep 2022 09:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgLk-0007Pq-Lq; Thu, 01 Sep 2022 09:19:00 +0000 Received: by outflank-mailman (input) for mailman id 396386; Thu, 01 Sep 2022 09:19:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgJ1-000527-8K for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:16:11 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b7533f13-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:16:09 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 08D65D6E; Thu, 1 Sep 2022 02:16:16 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F099D3F766; Thu, 1 Sep 2022 02:16:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7533f13-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Date: Thu, 1 Sep 2022 10:13:06 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to disable xenstore interface for dom0less guests. Signed-off-by: Rahul Singh --- Changes in v3: - new patch in this version --- docs/misc/arm/device-tree/booting.txt | 4 ++++ xen/arch/arm/domain_build.c | 10 +++++++--- xen/arch/arm/include/asm/kernel.h | 3 +++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index edef98e6d1..87f57f8889 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -204,6 +204,10 @@ with the following properties: - "disabled" Xen PV interfaces are disabled. + - no-xenstore + Xen PV interfaces, including grant-table will be enabled for the VM but + xenstore will be disabled for the VM. + If the xen,enhanced property is present with no value, it defaults to "enabled". If the xen,enhanced property is not present, PV interfaces are disabled. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4b24261825..8dd9984225 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3336,10 +3336,14 @@ static int __init construct_domU(struct domain *d, (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) { if ( hardware_domain ) - kinfo.dom0less_enhanced = true; + kinfo.dom0less_xenstore = true; else - panic("Tried to use xen,enhanced without dom0\n"); + panic("Tried to use xen,enhanced without dom0 without no-xenstore\n"); } + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) + kinfo.dom0less_xenstore = false; + + kinfo.dom0less_enhanced = true; if ( vcpu_create(d, 0) == NULL ) return -ENOMEM; @@ -3379,7 +3383,7 @@ static int __init construct_domU(struct domain *d, if ( rc < 0 ) return rc; - if ( kinfo.dom0less_enhanced ) + if ( kinfo.dom0less_xenstore ) { ASSERT(hardware_domain); rc = alloc_xenstore_evtchn(d); diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index c4dc039b54..3d7fa94910 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -39,6 +39,9 @@ struct kernel_info { /* Enable PV drivers */ bool dom0less_enhanced; + /* Enable Xenstore */ + bool dom0less_xenstore; + /* GIC phandle */ uint32_t phandle_gic; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:19:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396390.636538 (Exim 4.92) (envelope-from ) id 1oTgLm-0007tP-A3; Thu, 01 Sep 2022 09:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396390.636538; Thu, 01 Sep 2022 09:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgLm-0007s2-4m; Thu, 01 Sep 2022 09:19:02 +0000 Received: by outflank-mailman (input) for mailman id 396390; Thu, 01 Sep 2022 09:19:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgIW-000527-N5 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:15:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a4e5316f-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:15:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E65E3D6E; Thu, 1 Sep 2022 02:15:44 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF0D23F766; Thu, 1 Sep 2022 02:15:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4e5316f-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property Date: Thu, 1 Sep 2022 10:13:05 +0100 Message-Id: <3899ada4cc8217b45eab4f8d85492b0d5a6a9580.1662023183.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send notifications to each other. Signed-off-by: Rahul Singh --- Changes in v3: - use device-tree used_by to find the domain id of the evtchn node. - add new static_evtchn_create variable in struct dt_device_node to hold the information if evtchn is already created. - fix minor comments Changes in v2: - no change --- docs/misc/arm/device-tree/booting.txt | 64 ++++++++++++- xen/arch/arm/domain_build.c | 128 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 2 + xen/include/xen/device_tree.h | 13 +++ 5 files changed, 207 insertions(+), 1 deletion(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..edef98e6d1 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -212,7 +212,7 @@ with the following properties: enable only selected interfaces. Under the "xen,domain" compatible node, one or more sub-nodes are present -for the DomU kernel and ramdisk. +for the DomU kernel, ramdisk and static event channel. The kernel sub-node has the following properties: @@ -254,11 +254,44 @@ The ramdisk sub-node has the following properties: property because it will be created by the UEFI stub on boot. This option is needed only when UEFI boot is used. +The static event channel sub-node has the following properties: + +- compatible + + "xen,evtchn" + +- xen,evtchn + + The property is tuples of two numbers + (local-evtchn link-to-foreign-evtchn) where: + + local-evtchn is an integer value that will be used to allocate local port + for a domain to send and receive event notifications to/from the remote + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. + It is recommended to use low event channel IDs. + + link-to-foreign-evtchn is a single phandle to a remote evtchn to which + local-evtchn will be connected. Example ======= chosen { + + module@0 { + compatible = "multiboot,kernel", "multiboot,module"; + xen,uefi-binary = "..."; + bootargs = "..."; + + }; + + /* one sub-node per local event channel */ + ec1: evtchn@1 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec2>; + }; + domU1 { compatible = "xen,domain"; #address-cells = <0x2>; @@ -277,6 +310,23 @@ chosen { compatible = "multiboot,ramdisk", "multiboot,module"; reg = <0x0 0x4b000000 0xffffff>; }; + + /* one sub-node per local event channel */ + ec2: evtchn@2 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec1>; + }; + + ec3: evtchn@3 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xb &ec5>; + }; + + ec4: evtchn@4 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xc &ec6>; + }; }; domU2 { @@ -296,6 +346,18 @@ chosen { compatible = "multiboot,ramdisk", "multiboot,module"; reg = <0x0 0x4d000000 0xffffff>; }; + + /* one sub-node per local event channel */ + ec5: evtchn@5 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xb &ec3>; + }; + + ec6: evtchn@6 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xd &ec4>; + }; }; }; diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 707e247f6a..4b24261825 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -33,6 +33,8 @@ #include #include +#define STATIC_EVTCHN_NODE_SIZE_CELLS 2 + static unsigned int __initdata opt_dom0_max_vcpus; integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); @@ -3052,6 +3054,131 @@ void __init evtchn_allocate(struct domain *d) d->arch.hvm.params[HVM_PARAM_CALLBACK_IRQ] = val; } +static int __init get_evtchn_dt_property(const struct dt_device_node *np, + uint32_t *port, uint32_t *phandle) +{ + const __be32 *prop = NULL; + uint32_t len; + + prop = dt_get_property(np, "xen,evtchn", &len); + if ( !prop ) + { + printk(XENLOG_ERR "xen,evtchn property should not be empty.\n"); + return -EINVAL; + } + + if ( !len || len < dt_cells_to_size(STATIC_EVTCHN_NODE_SIZE_CELLS) ) + { + printk(XENLOG_ERR "xen,evtchn property value is not valid.\n"); + return -EINVAL; + } + + *port = dt_next_cell(1, &prop); + *phandle = dt_next_cell(1, &prop); + + return 0; +} + +static int __init alloc_domain_evtchn(struct dt_device_node *node) +{ + int rc; + uint32_t domU1_port, domU2_port, remote_phandle; + struct dt_device_node *remote_node; + struct evtchn_alloc_unbound alloc_unbound; + struct evtchn_bind_interdomain bind_interdomain; + struct domain *d1 = NULL, *d2 = NULL; + + if ( dt_device_static_evtchn_created(node) ) + return 0; + + rc = get_evtchn_dt_property(node, &domU1_port, &remote_phandle); + if ( rc ) + return rc; + + remote_node = dt_find_node_by_phandle(remote_phandle); + if ( !remote_node ) + { + printk(XENLOG_ERR + "evtchn: could not find remote evtchn phandle\n"); + return -EINVAL; + } + + rc = get_evtchn_dt_property(remote_node, &domU2_port, &remote_phandle); + if ( rc ) + return rc; + + if ( node->phandle != remote_phandle ) + { + printk(XENLOG_ERR "xen,evtchn property is not setup correctly.\n"); + return -EINVAL; + } + + d1 = get_domain_by_id(dt_get_parent(node)->used_by); + d2 = get_domain_by_id(dt_get_parent(remote_node)->used_by); + + if ( !d1 || !d2 ) + { + printk(XENLOG_ERR "evtchn: could not find domains\n" ); + return -EINVAL; + } + + alloc_unbound.dom = d1->domain_id; + alloc_unbound.remote_dom = d2->domain_id; + + rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); + if ( rc < 0 ) + { + printk(XENLOG_ERR + "evtchn_alloc_unbound() failure (Error %d) \n", rc); + return rc; + } + + bind_interdomain.remote_dom = d1->domain_id; + bind_interdomain.remote_port = domU1_port; + + rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port); + if ( rc < 0 ) + { + printk(XENLOG_ERR + "evtchn_bind_interdomain() failure (Error %d) \n", rc); + return rc; + } + + dt_device_set_static_evtchn_created(node); + dt_device_set_static_evtchn_created(remote_node); + + return 0; +} + +void __init process_static_evtchn_node(struct dt_device_node *node) +{ + if ( dt_device_is_compatible(node, "xen,evtchn-v1") ) + { + if ( alloc_domain_evtchn(node) != 0 ) + panic("Could not set up domains evtchn\n"); + } +} + +void __init alloc_static_evtchn(void) +{ + struct dt_device_node *node, *evtchn_node; + struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); + + BUG_ON(chosen == NULL); + + if ( hardware_domain ) + dt_device_set_used_by(chosen, hardware_domain->domain_id); + + dt_for_each_child_node(chosen, node) + { + if ( hardware_domain ) + process_static_evtchn_node(node); + + dt_for_each_child_node(node, evtchn_node) + process_static_evtchn_node(evtchn_node); + } +} + static void __init find_gnttab_region(struct domain *d, struct kernel_info *kinfo) { @@ -3364,6 +3491,7 @@ void __init create_domUs(void) panic("Error creating domain %s\n", dt_node_name(node)); d->is_console = true; + dt_device_set_used_by(node, d->domain_id); if ( construct_domU(d, node) != 0 ) panic("Could not set up domain %s\n", dt_node_name(node)); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..5ee28b270f 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -106,6 +106,7 @@ int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); void create_domUs(void); void create_dom0(void); +void alloc_static_evtchn(void); void discard_initial_modules(void); void fw_unreserved_regions(paddr_t s, paddr_t e, diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 6e0398f3f6..cf15d359d2 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1077,6 +1077,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); + alloc_static_evtchn(); + /* * This needs to be called **before** heap_init_late() so modules * will be scrubbed (unless suppressed). diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 430a1ef445..5579c875d2 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -82,6 +82,7 @@ struct dt_device_node { dt_phandle phandle; char *full_name; domid_t used_by; /* By default it's used by dom0 */ + bool_t static_evtchn_created; struct dt_property *properties; struct dt_device_node *parent; @@ -317,6 +318,18 @@ static inline bool_t dt_property_name_is_equal(const struct dt_property *pp, return !dt_prop_cmp(pp->name, name); } +static inline void +dt_device_set_static_evtchn_created(struct dt_device_node *device) +{ + device->static_evtchn_created = true; +} + +static inline bool_t +dt_device_static_evtchn_created(const struct dt_device_node *device) +{ + return device->static_evtchn_created; +} + /** * dt_find_compatible_node - Find a node based on type and one of the * tokens in its "compatible" property -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:19:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396391.636543 (Exim 4.92) (envelope-from ) id 1oTgLm-0007zA-OH; Thu, 01 Sep 2022 09:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396391.636543; Thu, 01 Sep 2022 09:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgLm-0007yP-Fb; Thu, 01 Sep 2022 09:19:02 +0000 Received: by outflank-mailman (input) for mailman id 396391; Thu, 01 Sep 2022 09:19:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgHj-000527-FP for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:14:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 87ac2b65-29d6-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:14:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E92B5D6E; Thu, 1 Sep 2022 02:14:55 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 580393F766; Thu, 1 Sep 2022 02:14:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87ac2b65-29d6-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Julien Grall Subject: [PATCH v3 4/7] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Date: Thu, 1 Sep 2022 10:13:03 +0100 Message-Id: <1327a2cf71f7d3b38a57124831e057f18685d24a.1662023183.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently evtchn_alloc_unbound() always allocates the next available port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_alloc_unbound() to accept the port number as an argument and allocate the specified port if available. If the port number argument is zero, the next available port will be allocated. Signed-off-by: Rahul Singh Reviewed-by: Julien Grall Acked-by: Jan Beulich --- Changes in v3: - fix minor comments in commit msg Changes in v2: - fix minor comments --- xen/arch/arm/domain_build.c | 2 +- xen/common/event_channel.c | 17 ++++++++++++----- xen/include/xen/event.h | 3 ++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fde133cd94..707e247f6a 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3171,7 +3171,7 @@ static int __init alloc_xenstore_evtchn(struct domain *d) alloc.dom = d->domain_id; alloc.remote_dom = hardware_domain->domain_id; - rc = evtchn_alloc_unbound(&alloc); + rc = evtchn_alloc_unbound(&alloc, 0); if ( rc ) { printk("Failed allocating event channel for domain\n"); diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index ef4da0781d..b464f09d2a 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -317,11 +317,15 @@ static int evtchn_get_port(struct domain *d, evtchn_port_t port) return rc ?: port; } -int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) +/* + * If port is zero get the next free port and allocate. If port is non-zero + * allocate the specified port. + */ +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, evtchn_port_t port) { struct evtchn *chn; struct domain *d; - int port, rc; + int rc; domid_t dom = alloc->dom; d = rcu_lock_domain_by_any_id(dom); @@ -330,8 +334,11 @@ int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) write_lock(&d->event_lock); - if ( (port = get_free_port(d)) < 0 ) - ERROR_EXIT_DOM(port, d); + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; + chn = evtchn_from_port(d, port); rc = xsm_evtchn_unbound(XSM_TARGET, d, chn, alloc->remote_dom); @@ -1222,7 +1229,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) struct evtchn_alloc_unbound alloc_unbound; if ( copy_from_guest(&alloc_unbound, arg, 1) != 0 ) return -EFAULT; - rc = evtchn_alloc_unbound(&alloc_unbound); + rc = evtchn_alloc_unbound(&alloc_unbound, 0); if ( !rc && __copy_to_guest(arg, &alloc_unbound, 1) ) rc = -EFAULT; /* Cleaning up here would be a mess! */ break; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index f3021fe304..f31963703f 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -72,7 +72,8 @@ void evtchn_free(struct domain *d, struct evtchn *chn); int evtchn_allocate_port(struct domain *d, unsigned int port); /* Allocate a new event channel */ -int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc); +int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, + evtchn_port_t port); /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:27:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396428.636564 (Exim 4.92) (envelope-from ) id 1oTgU3-0002I3-N8; Thu, 01 Sep 2022 09:27:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396428.636564; Thu, 01 Sep 2022 09:27:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgU3-0002Hw-KF; Thu, 01 Sep 2022 09:27:35 +0000 Received: by outflank-mailman (input) for mailman id 396428; Thu, 01 Sep 2022 09:27:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgU2-0002Hq-As for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:27:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgU1-0008U8-S5; Thu, 01 Sep 2022 09:27:33 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTgU1-0001nd-He; Thu, 01 Sep 2022 09:27:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lx54AIdaCQA8yNx3PXlyogqS+7PauHF3Hum8ZTPekEI=; b=eFDC3p22pDA6+cJwGAkMlQjrQt 8he4Gqw51pXB7XVTqTJuPBDihERrtv/F8tgaBW8CeTNKRi+zPpcGG1iWXJi23hcpaP3BFrUEfkyFC 1IpQsOnNpcFbmliJf2wamLcmJH8/8Oy8B3xRusgrt495jLFLGceAo9ZsvpW0uzxW+L20=; Message-ID: Date: Thu, 1 Sep 2022 10:27:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Stanislav Kinsburskii , Julien Grall References: <4f8f5abdb7d9dfb241794375d3705524b5b53490.1662023183.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: <4f8f5abdb7d9dfb241794375d3705524b5b53490.1662023183.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 01/09/2022 10:13, Rahul Singh wrote: > In a follow-up patch we will want to either reserve or allocate a port > for various event channel helpers. > > A new wrapper is introduced to either reserve a given port or allocate > a fresh one if zero. > > Take the opportunity to replace the open-coded version in > evtchn_bind_virq(). > > Signed-off-by: Stanislav Kinsburskii Usually, the "From:" match the first signed-off-by. This is not the case here. Can you clarify whether you effectively rewrite the patch or simply took it? If the former, then I would suggest to write: "Based on ..." If the latter, then please update the "From:". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:28:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:28:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396432.636575 (Exim 4.92) (envelope-from ) id 1oTgUR-0002mG-VX; Thu, 01 Sep 2022 09:27:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396432.636575; Thu, 01 Sep 2022 09:27:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgUR-0002m9-Sp; Thu, 01 Sep 2022 09:27:59 +0000 Received: by outflank-mailman (input) for mailman id 396432; Thu, 01 Sep 2022 09:27:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgUQ-0002iv-De for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:27:58 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d5cccec-29d8-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 11:27:57 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id s11so21708532edd.13 for ; Thu, 01 Sep 2022 02:27:57 -0700 (PDT) Received: from [192.168.1.10] (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.gmail.com with ESMTPSA id r26-20020a056402019a00b0044402ac02f7sm997261edv.67.2022.09.01.02.27.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 02:27:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d5cccec-29d8-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=9Fj0oh9Yyp5FSKztr1IsxguBpjpyadMGxN0s2mi4j0g=; b=NQScdxVvH6WTMkv+CoFSfal2Wm2ISjDdoED7ZRNsYInW09P6MkCnQv7SC5Pl7N36Bq kVeONK47dDS+lmvM5lGaM5ywyO6z0O61qsF6S/IJ2OV4QhLNjSIxFqfLdj8QwLPlb2Rl dBvx+oes38I7DkOydhRfaQ5cmT1bg1/tJdVGkVwGoj4/AAKofQryj6LWLJZrCw7SDGja C2hwGh+ICKMhBjuJ2IX7tZqn6/2+vYveIUyX1PeH731zO+yMC9hlfOxneoOQRfUMjQf4 AvSSseWfHUBqb1WCsxaoqc4hECKcDVh/4K804gSjdheX9oHcfzrunl1ukMI5YbDKsEg5 0xpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=9Fj0oh9Yyp5FSKztr1IsxguBpjpyadMGxN0s2mi4j0g=; b=k168h3huI/4WlowunE+c1Dh7/bc99DreCNn9AZ+VJFvu0y209rQTU8uSI85HV4Ai5v A/kGzgG8EfjEI/m8fh4nXcUIZtVrQ+wJXu+0x+ufgPuDbe496rw51EiCnVEYVuMcMSpo +SbPGKvfCBqzElq/Tbp7Ey6lZvIm0XFtwq+tT2L0Ql6BaGIlSs0N2Ys9pUsSv0cEyLyO cOAfApU2HpLm6bvDQA7AIW6c9NrN7V75RLGEbqP7ShOm7ukvkS5s/xrJuknYNMfG2xIO whns2sspacoCDM73ENNL6bGBkt7ste44HkDPjID7BktLZGYpHuIBq2+UmWjII6WWU9OF KHMA== X-Gm-Message-State: ACgBeo1yAAzdXYbSX1rxX8FJU0s9krtj40b94cetJn5uht04Vr8w+io8 +9wsQnpPLXljwNJlazQbpwYxJlZgmZs= X-Google-Smtp-Source: AA6agR4Ly6XRZCAWCsu5UKIv0W2xL05PlHIXM7uiiMTjmbk3AxkRKgIlO6wziQ5OcWWdGBz1Jh8U6w== X-Received: by 2002:a05:6402:40cb:b0:448:627d:90d6 with SMTP id z11-20020a05640240cb00b00448627d90d6mr16534007edb.233.1662024476957; Thu, 01 Sep 2022 02:27:56 -0700 (PDT) Message-ID: <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> Date: Thu, 1 Sep 2022 12:27:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220819194359.1196539-1-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/1/22 01:35, Stefano Stabellini wrote: > Patches 1, 4, and 6 are already committed. I plan to commit patches 2, 3 > and 5 in the next couple of days. > > Patch 7 needs further discussions and it is best addressed during the > next MISRA C sync-up. > I would like to share here, before the next MISRA C sync, my understandings that will hopefully resolve a wrong impression of mine, that I may have spread around, regarding this rule. There was a misunderstanding regarding the rule 20.7 from my part and I think that Jan is absolutely right that parenthesizing macro parameters used as function arguments is not required by the rule. The rule 20.7 states "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses" and in the rationale of the rule states "If a macro parameter is not being used as an expression then the parentheses are not necessary because no operators are involved.". Initially, based on the title, my understanding was that it requires for the expression resulting from the expansion of the macro to be enclosed in parentheses. Then, based on the rule explanation and the examples given, my understanding was that it requires the macro parameters that are used as expressions to be enclosed in parentheses. But, after re-thinking about it, the most probable and what makes more sense, is that it require parentheses around the macro parameters that are part of an expression and not around those that are used as expressions. Therefore, macro parameters being used as function arguments are not required to be enclosed in parentheses, because the function arguments are part of an expression list, not of an expression (comma is evaluated as separator, not as operator). While, macro parameters used as rhs and lhs expressions of the assignment operator are required to be enclosed in parentheses because they are part of an assignment expression. I verified that the violation reported by cppcheck is not due to missing parentheses around the function argument (though still I have not understood the origin of the warning). Also, Eclair does not report it. Hence, it was a misunderstanding of mine and there is no inconsistency, with respect to this rule, in adding parentheses around macro parameters used as rhs of assignments. The rule does not require adding parentheses around macro parameters used as function arguments and neither cppcheck nor Eclair report violation for missing parentheses around macro parameters used as function arguments. > > On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: >> Xenia Ragiadakou (7): >> xen/arm: gic_v3_its: Fix MISRA C 2012 Rule 20.7 violations >> xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations >> xen/elf: Fix MISRA C 2012 Rule 20.7 violations >> xen/vgic: Fix MISRA C 2012 Rule 20.7 violation >> xen/rbtree: Fix MISRA C 2012 Rule 20.7 violation >> xen/arm: processor: Fix MISRA C 2012 Rule 20.7 violations >> xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations >> >> xen/arch/arm/include/asm/gic_v3_its.h | 10 +++++----- >> xen/arch/arm/include/asm/new_vgic.h | 2 +- >> xen/arch/arm/include/asm/processor.h | 4 ++-- >> xen/include/xen/device_tree.h | 6 +++--- >> xen/include/xen/elfstructs.h | 4 ++-- >> xen/lib/rbtree.c | 2 +- >> xen/xsm/flask/ss/sidtab.c | 8 ++++---- >> 7 files changed, 18 insertions(+), 18 deletions(-) >> >> -- >> 2.34.1 >> -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:29:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:29:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396440.636586 (Exim 4.92) (envelope-from ) id 1oTgW0-0003Sy-9z; Thu, 01 Sep 2022 09:29:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396440.636586; Thu, 01 Sep 2022 09:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgW0-0003Sr-74; Thu, 01 Sep 2022 09:29:36 +0000 Received: by outflank-mailman (input) for mailman id 396440; Thu, 01 Sep 2022 09:29:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgVy-0003Si-Me for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:29:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9642183b-29d8-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 11:29:33 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9FA0ED6E; Thu, 1 Sep 2022 02:29:38 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02D843F766; Thu, 1 Sep 2022 02:29:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9642183b-29d8-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v3 0/2] xen/pci: implement is_memory_hole for ARM Date: Thu, 1 Sep 2022 10:29:20 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 +++- xen/arch/arm/pci/pci-host-common.c | 47 ++++++++++++++++++++++++++++-- xen/arch/x86/include/asm/pci.h | 10 +++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 63 insertions(+), 7 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:30:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:30:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396448.636596 (Exim 4.92) (envelope-from ) id 1oTgXB-0004q6-LP; Thu, 01 Sep 2022 09:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396448.636596; Thu, 01 Sep 2022 09:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgXB-0004pz-IS; Thu, 01 Sep 2022 09:30:49 +0000 Received: by outflank-mailman (input) for mailman id 396448; Thu, 01 Sep 2022 09:30:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgX9-0004pr-Ir for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:30:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c1538d10-29d8-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:30:45 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2810D6E; Thu, 1 Sep 2022 02:30:51 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7AD263F766; Thu, 1 Sep 2022 02:30:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1538d10-29d8-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: [PATCH v3 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev Date: Thu, 1 Sep 2022 10:29:21 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Oleksandr Tyshchenko --- Changes in v3: - no changes --- xen/arch/arm/include/asm/pci.h | 3 ++- xen/arch/arm/pci/pci-host-common.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 7c7449d64f..80a2431804 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -106,7 +106,8 @@ bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d, struct pci_host_bridge *bridge, uint64_t addr); struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus); -struct dt_device_node *pci_find_host_bridge_node(struct device *dev); +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev); int pci_get_host_bridge_segment(const struct dt_device_node *node, uint16_t *segment); diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index fd8c0f837a..89ef30028e 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -243,10 +243,10 @@ err_exit: /* * Get host bridge node given a device attached to it. */ -struct dt_device_node *pci_find_host_bridge_node(struct device *dev) +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev) { struct pci_host_bridge *bridge; - struct pci_dev *pdev = dev_to_pci(dev); bridge = pci_find_host_bridge(pdev->seg, pdev->bus); if ( unlikely(!bridge) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:31:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:31:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396450.636608 (Exim 4.92) (envelope-from ) id 1oTgXT-0005GO-Uk; Thu, 01 Sep 2022 09:31:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396450.636608; Thu, 01 Sep 2022 09:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgXT-0005GH-Rl; Thu, 01 Sep 2022 09:31:07 +0000 Received: by outflank-mailman (input) for mailman id 396450; Thu, 01 Sep 2022 09:31:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgXT-00058u-2f for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:31:07 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cd859225-29d8-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 11:31:05 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57F37D6E; Thu, 1 Sep 2022 02:31:11 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7F463F766; Thu, 1 Sep 2022 02:31:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd859225-29d8-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Date: Thu, 1 Sep 2022 10:29:22 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memory_hole which will check if BAR is not overlapping with any memory region defined in the memory map. On ARM, pci_check_bar will go through the host bridge ranges and check if the BAR is in the range of defined ranges. Signed-off-by: Rahul Singh --- Changes in v3: - fix minor comments --- xen/arch/arm/include/asm/pci.h | 2 ++ xen/arch/arm/pci/pci-host-common.c | 43 ++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/pci.h | 10 +++++++ xen/drivers/passthrough/pci.c | 8 +++--- 4 files changed, 59 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 80a2431804..8cb46f6b71 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, int pci_host_bridge_mappings(struct domain *d); +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); + #else /*!CONFIG_HAS_PCI*/ struct arch_pci_dev { }; diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index 89ef30028e..0eb121666d 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -24,6 +24,16 @@ #include +/* + * struct to hold pci device bar. + */ +struct pdev_bar +{ + mfn_t start; + mfn_t end; + bool is_valid; +}; + /* * List for all the pci host bridges. */ @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0; } +static int is_bar_valid(const struct dt_device_node *dev, + uint64_t addr, uint64_t len, void *data) +{ + struct pdev_bar *bar_data = data; + unsigned long s = mfn_x(bar_data->start); + unsigned long e = mfn_x(bar_data->end); + + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) + bar_data->is_valid = true; + + return 0; +} + +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) +{ + int ret; + const struct dt_device_node *dt_node; + struct pdev_bar bar_data = { + .start = start, + .end = end, + .is_valid = false + }; + + dt_node = pci_find_host_bridge_node(pdev); + if ( !dt_node ) + return false; + + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); + if ( ret < 0 ) + return false; + + return bar_data.is_valid; +} /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h index c8e1a9ecdb..f4a58c8acf 100644 --- a/xen/arch/x86/include/asm/pci.h +++ b/xen/arch/x86/include/asm/pci.h @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) void arch_pci_init_pdev(struct pci_dev *pdev); +static inline bool pci_check_bar(const struct pci_dev *pdev, + mfn_t start, mfn_t end) +{ + /* + * Check if BAR is not overlapping with any memory region defined + * in the memory map. + */ + return is_memory_hole(start, end); +} + #endif /* __X86_PCI_H__ */ diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index cdaf5c247f..149f68bb6e 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) /* Unable to size, better leave memory decoding disabled. */ return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { /* * Return without enabling memory decoding if BAR position is not @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), PFN_DOWN(addr + size - 1)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 09:42:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 09:42:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396474.636623 (Exim 4.92) (envelope-from ) id 1oTgiV-000783-9G; Thu, 01 Sep 2022 09:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396474.636623; Thu, 01 Sep 2022 09:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgiV-00077w-6G; Thu, 01 Sep 2022 09:42:31 +0000 Received: by outflank-mailman (input) for mailman id 396474; Thu, 01 Sep 2022 09:42:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTgiT-00077q-7g for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 09:42:29 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2077.outbound.protection.outlook.com [40.107.249.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63452bca-29da-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 11:42:26 +0200 (CEST) Received: from AS8PR07CA0019.eurprd07.prod.outlook.com (2603:10a6:20b:451::22) by PAXPR08MB7600.eurprd08.prod.outlook.com (2603:10a6:102:23f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 09:42:25 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:451:cafe::f7) by AS8PR07CA0019.outlook.office365.com (2603:10a6:20b:451::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Thu, 1 Sep 2022 09:42:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 09:42:24 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 01 Sep 2022 09:42:24 +0000 Received: from 8b44bbbf7f09.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B14819AC-857A-4A1A-B049-736249AF02D6.1; Thu, 01 Sep 2022 09:42:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b44bbbf7f09.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 09:42:18 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com (2603:10a6:20b:41f::23) by AS8PR08MB7353.eurprd08.prod.outlook.com (2603:10a6:20b:444::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 09:42:16 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::d117:77a3:a165:3f55]) by AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::d117:77a3:a165:3f55%6]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 09:42:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63452bca-29da-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mLK1n+CkX5UHB8V5xtGetzNIGH/8uny58r8EwcP0UgI0GHoLP8OuFgJH0MbvYX93iPjpNb+NlfvlSOIJVVMKRMqCyyLu/UMUuzvfV4zGs3HetYypp/MOatxuhi+TCjuH+HNw91nY/86iI2/pymudQa+Ze1cBZ76jWH/++71cWKiXMyAPtjr1i2AjBo02Qkzab+i2XHcOPx5Tv6mKWeuQTKyVv4+OaluyzwjTh4KAdk4e4D2vt806EXWcqJz+2yX0CupRKhdvzwTFPEfLcJ+e7t29Vl2TNmdYDmnJZpW5qOWA6hbKikPfkntV0LJ4im08K6VTyBoeGE/HPBOpyyW2TQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LLaCUrt0QG9kCv8fRk4i1lSMJzVY0LYIkNk2W+pauY=; b=Zy4W0j9i6kt0g3OcABPXyQht1SeI4ivSGJLHl/okfjlk9PHc/dtK6Uf/z/C5Jd9SadFV/gMiMFNJNph7Fk36d4BzdnPPoc11eVP1vdqX/kKYcJc6kZEC1Tum+DXx0GcciQMsi/FiCQHkk8bhvAdMXWTyr4Hn2axCer7G5htlnU+CLfYYhzXKQSBXtTCe9oc0dNhOCEyz1RR/FWI53zXS8lPpDPDWhiaZGtP3tzzqvMJAtDVkJ5klncals1s1lNqp+3alhFmokqdZCj5YX+EJ5eHhWK3XyWv0t90b3lRatD1Iv2hh/MoYzi6Uq+zfGv422geip0wE4UqafNvf/V4Mdg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LLaCUrt0QG9kCv8fRk4i1lSMJzVY0LYIkNk2W+pauY=; b=GIqNfjPr920a0c9b+w8J43QDgnTmXTQB4psAVmiRDU/zQdObyx1nVfKBDSI6q2RNZNkUpqNH2b9MRHM6Fuv7HRczCoqtYqixCV22p5p02IZmQMvyg/jU6ry9ZuzyMAmOOXYA6JFKMnGEBQpHBRAzDkxmC8A+kb5HBoyDv8x6CC8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a5a85b6019b9e741 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=np1mCD87kkqY1fYeYRhK7OZm/H95Ae+UvK6eH+zwb2TCrNQ5NpJJZZALtKL3+upJ3Z+4TDWhaexYAeYgQ0+zS/wgHUWxWm0lU0BuuMdwpnYgwMBxp3H3lvKYjd6Oqr2Kqs9BUL5H2pGolcT5hG1REfULBGGG2hwakO5qgY8VHMIsaK2QcLVLrMTIiqSK/XKEMW6bN1ZLUd5UeUevvPstmmbGS7rWXadYavlcJYJSZXn5BJzgf6HCiBptj7MvyODEnRR+dN+XbVy7kobtVUE+geeAYnHvHHXsMTRNRfHW9OXna5Tt+giNtZlDjZ/QH25cTW+mdkGIcPFZbUm9okOdnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LLaCUrt0QG9kCv8fRk4i1lSMJzVY0LYIkNk2W+pauY=; b=RMBRPUF+Tt7yOfv+3mti/ysdqu/E0Pgdz9WSyKRMJ5gzwG+GTHXmjg5BFmdY+y8s3FkJ5aJVwSytqC4LJ+2gDLUC/I3KCxZgIZdd3PDSRQ31PBGqJBu62Seub+k2Xe8hTqqqc+vVbw+ml3sOwOnoM+8u2h5jtQDVudd1lDrMTgYbDCmdTYjnU9kjqtFQkOfkMP3difVSYHkMqy/bsbaP3IF2zLKQR4J0XCASJjQFRfhSsQvNyoOJvziR39MgDhZMDDYtEVFp2/pM1g0GLS1nZxpjg/wgp46fxHN6ZQ+jgRhNY75VlEwcElAj9RkK2MhFC5JDPAwOU9GsoCz4CHxsAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LLaCUrt0QG9kCv8fRk4i1lSMJzVY0LYIkNk2W+pauY=; b=GIqNfjPr920a0c9b+w8J43QDgnTmXTQB4psAVmiRDU/zQdObyx1nVfKBDSI6q2RNZNkUpqNH2b9MRHM6Fuv7HRczCoqtYqixCV22p5p02IZmQMvyg/jU6ry9ZuzyMAmOOXYA6JFKMnGEBQpHBRAzDkxmC8A+kb5HBoyDv8x6CC8= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Stanislav Kinsburskii , Julien Grall Subject: Re: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port Thread-Topic: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port Thread-Index: AQHYveM0KXGt+cb4qkiLnrRR6/y4Sq3KTlcAgAAEH4A= Date: Thu, 1 Sep 2022 09:42:16 +0000 Message-ID: <3FC2FD6E-3FC5-4311-B65E-9BA846F5B743@arm.com> References: <4f8f5abdb7d9dfb241794375d3705524b5b53490.1662023183.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a564eb11-c000-403e-fbb2-08da8bfe4697 x-ms-traffictypediagnostic: AS8PR08MB7353:EE_|VE1EUR03FT049:EE_|PAXPR08MB7600:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MKWNHyb9DBhNyIKqwHwVR7BCljP1RcVwYbvoQKTyq/3qJWOYSuHgNI33vm0MJHnEKkUr3hrKF8V88T9n/4ZQ22tSByoCF0KOHtOgdvjWNR4bhecu1adx30lJlSUDsOmx1SSuxvwNAgnh9/hZRfm776sSsv8ohXhvtqSbMp2YIw1HSc3F9r6z5FezMDdEBXEm4Ene15rJKfpz2MVx8R3TpfLwFimHQUsbZl9oBGMNSe6VR75aMl9ROgcuRCFgXylkFnI/kezhXiEKs0HW/VYcT9zqbXA9rpDJBuaXdNyIWkNR2U2i9a3Bn30UVQavERavAbu8JJ7YSq/KCUCr2s8z0bCDRk1pmFjcq05aig3C6sg9qMtpK5JWfYyvff/2SO38YXSiJkCf3xLM2WbfQFR3CWtJMH7Qn6jyRDAY2laVnIA6/jzUDZOXgPgKhDwUnqAOw7/wNdKWYwhJnuE0vLwFT7oFhdn8yOFakjKg7AySmIKsYnOjhuyXhldZEA7jvAJlCa8ykmpklHJ/Hfo6e79SVxMjQwKl+EH2vSMlmSQyqrWBK/iu9I+qD2aHJm4G/UpWF0/ni8NUbTBnsrPZL3zpkFh6DC2wvNLrtiyneKpUHQtCTqogPEQ4hn50q25k1Dgmxg/g5iZIokM58aM1CIcEBi1tmfmcdbigOvsabkfoz1gZG5Of+vQLAkBvzrGANYGPFfRh57w7LeyDoK6LZht+jahGN+xQGP9PxKj+Abqb/m7p5zPbSjqiQfNVYVb+oI2LFS5f3sZzsguxxvy2fZxGPvshL3UeE9A2Pcnw+3eiyhM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB7165.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(2616005)(86362001)(186003)(4744005)(8936002)(5660300002)(41300700001)(33656002)(6512007)(2906002)(53546011)(6506007)(26005)(38070700005)(38100700002)(83380400001)(122000001)(36756003)(91956017)(54906003)(478600001)(76116006)(6916009)(6486002)(66556008)(66946007)(316002)(66476007)(8676002)(4326008)(66446008)(64756008)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7353 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 841fb04e-0bf5-46ed-d071-08da8bfe418f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z6o/P83a5pNtlFKG44tG0K/mhPQEOC4GyNhaYpWKbl8eKAjgzszRq350WmbCIZfM631cpxeAlmG8oxbEzFZuFZx+8a+dCnYkIgRgdQ+6Da4QFIDa5lteBItheV8DdlGJoiA4CQ1lrZfQTtmKlICb4UQCHG1nmZjLt/WzEu4uiGcyuFAyKHLXNFFP9+BOrg5anuxYCfjfJGc/vg/kOHSoINXNwUrw6007sMqwTUWgdP3m8sQJXiHH4cHsAkEUEUC93MaFhrrLi9aZ9AVKmL9j5gE59nqgzNbt3Oo8Zi3/6ASUV0fpg888yEoPvDCEPUZIQEQbG3g1XbccDDJUA7/+3eFBJUoZSbYLg7EyZBe6rR1awBACTDjYkm4zr5AJVlgIm0yBzyGj5p1LT0k9sbGOQDmFZbyxlCY94mULeIshIPpZ221GXVJFgoH1j9TYax/VVzstFNsX4vO3R0Hw46pcqUwUsR21d/HAM5EyMoeJEJ6fNuxteJJzjSNTAWHqFEoMmQrWRlIK5On14DUVre8eluLKrtxFZie+jB6U3nPS83oBHpFOuU1/C++YSRsAmcKeZ9BQZLKr4MNLtOQ0LOZAZrMCaqdzc+KzXGZJP5L4rJ5kc9EcICYbHkeQJZbr1t0b4YybgUiADaordpL+nwC0jDZnNiR56HzqpcCjqOvZENtxGbLuNSAYtCGtCu4TLYEG6+ZE8JjChe5zpTHDE0g+dZY0mMhPRNtxWPjsmkV4piUhBx2ejwtlW5sBwPF/OVFLkUEYOpVtiyUzt07w4s4KcA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(40470700004)(46966006)(36840700001)(36756003)(6486002)(86362001)(82740400003)(6862004)(4744005)(8936002)(54906003)(478600001)(41300700001)(5660300002)(70586007)(70206006)(316002)(8676002)(4326008)(33656002)(107886003)(81166007)(2616005)(40460700003)(40480700001)(356005)(82310400005)(47076005)(26005)(83380400001)(36860700001)(6512007)(53546011)(6506007)(2906002)(336012)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 09:42:24.7728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a564eb11-c000-403e-fbb2-08da8bfe4697 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7600 SGkgSnVsaWVuLA0KDQo+IE9uIDEgU2VwIDIwMjIsIGF0IDEwOjI3IGFtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gT24gMDEvMDkv MjAyMiAxMDoxMywgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBJbiBhIGZvbGxvdy11cCBwYXRjaCB3 ZSB3aWxsIHdhbnQgdG8gZWl0aGVyIHJlc2VydmUgb3IgYWxsb2NhdGUgYSBwb3J0DQo+PiBmb3Ig dmFyaW91cyBldmVudCBjaGFubmVsIGhlbHBlcnMuDQo+PiBBIG5ldyB3cmFwcGVyIGlzIGludHJv ZHVjZWQgdG8gZWl0aGVyIHJlc2VydmUgYSBnaXZlbiBwb3J0IG9yIGFsbG9jYXRlDQo+PiBhIGZy ZXNoIG9uZSBpZiB6ZXJvLg0KPj4gVGFrZSB0aGUgb3Bwb3J0dW5pdHkgdG8gcmVwbGFjZSB0aGUg b3Blbi1jb2RlZCB2ZXJzaW9uIGluDQo+PiBldnRjaG5fYmluZF92aXJxKCkuDQo+PiBTaWduZWQt b2ZmLWJ5OiBTdGFuaXNsYXYgS2luc2J1cnNraWkgPHN0YXNraW5zQGFtYXpvbi5jb20+DQo+IA0K PiBVc3VhbGx5LCB0aGUgIkZyb206IiBtYXRjaCB0aGUgZmlyc3Qgc2lnbmVkLW9mZi1ieS4gVGhp cyBpcyBub3QgdGhlIGNhc2UgaGVyZS4gQ2FuIHlvdSBjbGFyaWZ5IHdoZXRoZXIgeW91IGVmZmVj dGl2ZWx5IHJld3JpdGUgdGhlIHBhdGNoIG9yIHNpbXBseSB0b29rIGl0Pw0KDQpJIGp1c3QgdG9v ayB0aGUgcGF0Y2ggd2l0aCBzbWFsbCBjaGFuZ2VzLg0KPiANCj4gSWYgdGhlIGZvcm1lciwgdGhl biBJIHdvdWxkIHN1Z2dlc3QgdG8gd3JpdGU6ICJCYXNlZCBvbiAuLi4iDQo+IElmIHRoZSBsYXR0 ZXIsIHRoZW4gcGxlYXNlIHVwZGF0ZSB0aGUgIkZyb206Ii4NCg0KT2suIEkgd2lsbCB1cGRhdGUg dGhlIOKAnEZyb2064oCdDQoNClJlZ2FyZHMsDQpSYWh1bA0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 01 10:27:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 10:27:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396492.636638 (Exim 4.92) (envelope-from ) id 1oThPv-00034g-KY; Thu, 01 Sep 2022 10:27:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396492.636638; Thu, 01 Sep 2022 10:27:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oThPv-00034Z-HR; Thu, 01 Sep 2022 10:27:23 +0000 Received: by outflank-mailman (input) for mailman id 396492; Thu, 01 Sep 2022 10:27:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oThPu-00034T-Fi for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 10:27:22 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20057.outbound.protection.outlook.com [40.107.2.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a900e964-29e0-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 12:27:20 +0200 (CEST) Received: from AM6PR10CA0099.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::40) by GV1PR08MB8570.eurprd08.prod.outlook.com (2603:10a6:150:82::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 10:27:17 +0000 Received: from AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::9f) by AM6PR10CA0099.outlook.office365.com (2603:10a6:209:8c::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 10:27:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT056.mail.protection.outlook.com (100.127.140.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 10:27:15 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Thu, 01 Sep 2022 10:27:14 +0000 Received: from 8dee5113608d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43EF156E-C611-4CC1-8133-B1B8996D306F.1; Thu, 01 Sep 2022 10:27:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8dee5113608d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 10:27:08 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com (2603:10a6:20b:41f::23) by PA4PR08MB6301.eurprd08.prod.outlook.com (2603:10a6:102:e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 10:27:06 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::d117:77a3:a165:3f55]) by AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::d117:77a3:a165:3f55%6]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 10:27:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a900e964-29e0-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wl5MqOKiWJ7n9Dd+hM4q36FGvJYeG8xEQJNcXIgCbB7Ez+wf51wuYb99njd51C/YMBrJTYD0rors8BIg+Am3uWoBois9RxjqhwgOozKPpxxPW78bU4V2th0qWMl9F8VfArVwpJID+D9osc3ga0/Bjp4gJtB5id57jqk3Q28yslO/HDfc0mXqhCgaBUtOiYD9ix02lC2kSwM2WE2JUjPD4g2RcH7teFnyldGMcd65ELeqNAbjY1ShrWJULiAxFyUleEq/LQPOJKFi6cEmTLyh4r476wZMLYG40v+9wln8TbSl77A3Z/CjBPhoPQ5w9qSewBxvC6PnjNUZzpYD1VuJbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpEOhq++szxWDXF4xQFsnoWVpbjQf7cyXJKT9fgBhVQ=; b=IxabaAGecWxmbzwsfdzVmVwWqFuqqle1zDZQ9XcF80V6r+hhpHsLY4XcevX0XGnwxQjwacVs9UsFb/elvzdzYry6odaBeqKaMSsBvd/FqmMVQ9p9tgIAu26zE+Yj3d0Oc+4J/nQO2PK8WRjJm1Z0iNGjP4PxreF+4QomX/vUXzWe+ZvFI3/D7Jn4Yal/91Q2Z5L0DSPJW7UNxwu3nGaLU5OG1nBsXYEWaEyC9vcnJFldgcR10bjLxnuEU6JkRdbzZM+382HiA4NQ9KIJwJE1C1oJ/81jzWwmDpVEHFTZRnK2Df5Fs1sp4FXf18T0y3JFE6nrmiH4o7pqjSCpt1Lfpg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpEOhq++szxWDXF4xQFsnoWVpbjQf7cyXJKT9fgBhVQ=; b=OpuYiAutrRtoS2K/M64/SsJ4ybPL2bNx191i5GrR3YI/6lvKGQi+JiVPDvtnE2lesRjePIRzkm7sQHJjBw9EB29jmB7D1/ua1ZS9qjXgdEwMrPjh6+nGvHnRCakn1o6+p0z7a12EyGIz1j6C0C+XoQmuoCTvoWKp6UOOfbC0Ung= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 36fe62fd522c0ee7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FANSJOYz9M0HixpINi+kgFR+xtYep1m70mnhdtUgDCSRRGKFYYN6fKb/T0jlfnX2M5Thz5q2bHLNK/+rO+SJN8VI6E/MWeeHYaTyWYqgAtI1PDs8z7n4vYEYF+VbzJAT2Pyn/o2sybyvriqGzOe/ujHF9uLe/aJK1dTaqUsS3fqeH0TjL+lGyifsBn9jAIgvjX+xIlJIV9Em/Wgq00Ly//8Zrj3PQUxVREfKSR64Pb2ptcxXrrC/xorcAbkLJFbEhX1iQ+2iTklfOq1hAUbdNYDP9HoF2AP119iE1ZlJHN1H2OckPkx2jgde49jGKi1UH/LNVZyixHIAZxh5Z7v3zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpEOhq++szxWDXF4xQFsnoWVpbjQf7cyXJKT9fgBhVQ=; b=fvNqEjtsG+BP2dpOiOH2IECRVqukjThcqo6KeowRL21TAcrgm0CbgqXeRRux5R7ZZ53FX2E1hhaNtY7ZmgbGNNNgYXvQvvZ8fH2y7tUGhlGIwJPyMyQX2YjFpT+Ldk+gL+SmAfpdcq0pBw+W98UaFucVON8e9VAO9fBSpB1SBJkXREDy5GGMVXK8F/cVUTt0+ibw1MmTFydzQEen8fMp3KW+JHf+VXzy38Y6r9rdorASGT+rSFzLFOKSIBMBZl2DCBkdYdN88zrHZHHmWn4z9sqSIYE1kH3ez4mz7f8PQyyjMcYc4457GCoG1ASEVhzGsvn74gQ+KhecsgxvCJqWlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpEOhq++szxWDXF4xQFsnoWVpbjQf7cyXJKT9fgBhVQ=; b=OpuYiAutrRtoS2K/M64/SsJ4ybPL2bNx191i5GrR3YI/6lvKGQi+JiVPDvtnE2lesRjePIRzkm7sQHJjBw9EB29jmB7D1/ua1ZS9qjXgdEwMrPjh6+nGvHnRCakn1o6+p0z7a12EyGIz1j6C0C+XoQmuoCTvoWKp6UOOfbC0Ung= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message Thread-Topic: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message Thread-Index: AQHYt8DukfAZB3LGK0y8Qp1jO3Tea62+JIcAgAxGuwA= Date: Thu, 1 Sep 2022 10:27:06 +0000 Message-ID: <454DC664-25A3-4DA2-99F5-BAB20FD8A590@arm.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 325efc1a-ff6e-4fd3-ee88-08da8c048a18 x-ms-traffictypediagnostic: PA4PR08MB6301:EE_|AM7EUR03FT056:EE_|GV1PR08MB8570:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: janergLdTUOQAgY3XaaInJc598ZY8KkGP2hzh2WCxz8Qpivs7TGcEtg1XC69yPGU79BjTaugbg+fV68NqqriXjg3GdO0wlgYpXeiD1WWuJxRFX/e79hT/bvA8cvwqvm/T4T8xih+xMB5NXXuEIQEK90uK7LIQgCZ8Ga3IRpX1yFqhJEX4hi2GVIxchvCbdFhzp9fiCDi55rOnyo0mfxjR6FAx4L0ZVVWnTOKpEmMzZuPZNGpmtXBcsnrt5Rl/oZO9B01LT6XxDIskqgXXs9slHPqCa67EMtQyW4Kjnb7PaHYQxt4CTaIjoUF73nRwv4yPgdq2cTRAe4KHgrwbIEglaaRxL0vApJmL+wHouHk8k3QGZz7HeplMv9uNhbEDguoAH7hxHge4tikd6Qs8wBvnjbiSzSNHNCgw6CcrkMOW5VL582dzC5fIBX/brBHtm9sKn0AHZ5b4N3l0Mpavh2P19Ggi6f2fT1Rjb38LIkR7y7k5cW1bNr37hWSsM2vvnMe5ZUpmExWF1ryo480XOLCUlV59CxMpTj/aTBNSdrkKgz4Er5Uh9jzGDo7qRExQHzFMXLBEozh7ihFOEDkgUW64JonFY3GC9R7iyHniyjGRJH97aGOzZFAF6FHgqPNIiniZahaC9fMK3yX0os8zJ8JD+pJKsA9RVGEgNKW405h5CCqnbwc6Bq3WxXbm8BBjcmmZOcdMkZWs4sh6eDRJ76brHcstz2KQxeERJwpjF6l54dHHR03Dvp5ENC7wT2TAlMiq/fEbYdVmNSDXXDlcEflBM2K/nrTfPoAllVOPLqFt3qOqzrDNfCy7Ief8vU8Td2w52kqoGI9Z+ciX2AzJc9Bpf0/8J5grUuRybSsL24nUrSVqMtgucVb3+YqtDYPNyHb X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB7165.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(4326008)(64756008)(8676002)(26005)(6512007)(53546011)(6506007)(86362001)(8936002)(38100700002)(6486002)(966005)(478600001)(71200400001)(66446008)(91956017)(66556008)(66946007)(54906003)(76116006)(41300700001)(122000001)(6916009)(316002)(38070700005)(15650500001)(83380400001)(66476007)(186003)(33656002)(36756003)(2616005)(2906002)(5660300002)(45980500001)(473944003)(414714003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6301 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e15f0a1e-d776-40a1-5c6a-08da8c048516 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c15M1Ucs17MV/xTG9wrr56UKwAn/A/6ISstBXCk3PdAL1yZogw5MbGMLHzV9DHuMWLnXbf+ANtwoMW9RvaPTVJ5l+ldRm2npasGxuu/RntCtrLil7hyUuW8S2P2rPKijY7J92X4KcQYW/8v/Xp0iZz6JE6xjwJesMO9qadW0OSo/CaeZYezKWIPmScOm61bFqPBO7jh4kIswE0o+FFsyoCKIrdVBwtS/5UnnQkskppsTIa2qMyFCWaoqTyrmGhjyMKhNnLgMnZ7YuJgGE01haBgG5roQd4Tk2MZjpZN8Pfw+hMwxxoh24VjI9TwhMQduMq8+l1Qk2rh9oW3nDbLol4kkI1CXT6SZnqE/SpWAaDbyAA5XUBeRenWd+fgwStBcDEWJPsC/Nm/skxJps6gFzLdKJBdHHe70H58DNGivklSLguBH42/Bt6yOTaAB1W8Tp0qb9B8H5yIVjxWMUnMiI/kAPIHO/LhQUVZDgmiVJM3GU+mth7N/kBP22xaGBM/RqSmnUIZ4txxyUwzZS7sCLY3h6Au17Rf1RxSf1WtHHz7Hqw8WhmqOL6oSloPPQDGIcVvZKxe9J9seXZer3c9qpBbgolq44E+c1HVEYq1LAhfaFjytsLlKI6t1npGBz/q1bqAcnXup5Yeo3MZDdKJJ6YeSfBeYRquTNcNiVgT0jxydMKE1V6x+QxS35Lp9uUEqa/wk6E98STYq8aXRkaglqp2Pp1Lf3iP2wPAxfN23nBFvSdLFQEOh98yrQCVH/03csrjdN67hl85FvrwXbyE1VK2UBi1JT8CW1ouPJhSqRF6Lvw8bcvDr+a5lXGC51iKIoVrHI9KI/LbFPR+O80aufkFRqUxJpIBCXP1oqbVrRxdMEeRoSHPkJBcdG8w+Z1A3uCSYzbsimcLzBl5xRDxB9Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(40470700004)(36840700001)(46966006)(356005)(82310400005)(81166007)(54906003)(82740400003)(36756003)(316002)(36860700001)(40480700001)(53546011)(26005)(2906002)(6512007)(4326008)(70586007)(70206006)(966005)(6486002)(478600001)(33656002)(5660300002)(40460700003)(107886003)(2616005)(186003)(336012)(6506007)(86362001)(41300700001)(83380400001)(6862004)(8936002)(47076005)(8676002)(15650500001)(36900700001)(414714003)(473944003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 10:27:15.0369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 325efc1a-ff6e-4fd3-ee88-08da8c048a18 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8570 SGkgSnVsaWVuLA0KDQo+IE9uIDI0IEF1ZyAyMDIyLCBhdCAzOjU4IHBtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gT24gMjQvMDgv MjAyMiAxNDo1MywgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBCYWNrcG9ydCBMaW51eCBjb21taXQg ZGM4OThlYjg0YjI1YzM5ZWE0NmYyOGM0OGExNjliZGJkMGUyYzdlMA0KPj4gaW9tbXUvYXJtLXNt bXUtdjM6IEZpeCBsMSBzdHJlYW0gdGFibGUgc2l6ZSBpbiB0aGUgZXJyb3IgbWVzc2FnZQ0KPiAN Cj4gV2UgaGF2ZSBhIHRhZyBmb3IgdGhpcyAoc2VlIE9yaWdpbikuIElmIHlvdSB1c2UgaXQsIHRo ZW7igKYNCk9rLg0KPiANCj4+IE9yaWdpbmFsIGNvbW1pdCBtZXNzYWdlOg0KPiANCj4gWW91IGRv bid0IG5lZWQgdG8gYWRkICJvcmlnaW5hbCBjb21taXQgbWVzc2FnZSIgaGVyZSBhbmQgdGhlIGNv bnRlbnQgaXMgZXhhY3RseSB0aGUgc2FtZS4NCk9rLg0KPiANCj4+ICAgICBpb21tdS9hcm0tc21t dS12MzogRml4IGwxIHN0cmVhbSB0YWJsZSBzaXplIGluIHRoZSBlcnJvciBtZXNzYWdlDQo+PiAg ICAgVGhlIGFjdHVhbCBzaXplIG9mIGxldmVsLTEgc3RyZWFtIHRhYmxlIGlzIGwxc2l6ZS4gVGhp cyBsb29rcyBsaWtlDQo+PiAgICAgYW4gb3ZlcnNpZ2h0IG9uIGNvbW1pdCBkMmU4OGU3YzA4MWVm ICgiaW9tbXUvYXJtLXNtbXU6IEZpeCBMT0cyU0laRQ0KPj4gICAgIHNldHRpbmcgZm9yIDItbGV2 ZWwgc3RyZWFtIHRhYmxlcyIpIHdoaWNoIGZvcmdvdCB0byB1cGRhdGUgdGhlIEBzaXplDQo+PiAg ICAgaW4gZXJyb3IgbWVzc2FnZSBhcyB3ZWxsLg0KPj4gICAgIEFzIG1lbW9yeSBhbGxvY2F0aW9u IGZhaWx1cmUgaXMgYWxyZWFkeSBiYWQgZW5vdWdoLCBub3RoaW5nIHdvcnNlDQo+PiAgICAgd291 bGQgaGFwcGVuLiBCdXQgbGV0J3MgYmUgY2FyZWZ1bC4NCj4+ICAgICBTaWduZWQtb2ZmLWJ5OiBa ZW5naHVpIFl1IDx5dXplbmdodWlAaHVhd2VpLmNvbT4NCj4gDQo+IEFGQUlDVCwgeW91IGRpZG4n dCBtYWtlIGFueSBjaGFuZ2UgdG8gdGhpcyBwYXRjaC4gU28gdGhlICJGcm9tOiIgc2hvdWxkIHN0 aWxsIGJlIGZyb20gWmVuZ2h1aSBZdS4gRm9yIGFuIGV4YW1wbGUgaG93IHRvIGRvIGJhY2twb3J0 LCBzZWUNCj4gOWM0MzJiODc2YmY1MTg4NjZkNDMxYmRhNzNmMmJlMTI1MGY2ODhlYiAieDg2L213 YWl0LWlkbGU6IGFkZCBTUFIgc3VwcG9ydCIuDQoNCk9rLg0KPiANCj4gQWxzbywgaXQgd291bGQg YmUgZ29vZCB0byBjbGFyaWZ5IHdoZXRoZXIgdGhleSBhcmUgY2xlYW4gYmFja3BvcnQgYW5kIHJl cXVpcmVkIHNvbWUgY2hhbmdlcyAob3RoZXIgdGhhbiBjb250ZXh0IGNoYW5nZXMpLiBJIGFzc3Vt ZSB0aGV5IGFyZSBjbGVhbiBiYWNrcG9ydHM/DQpZZXMgYWxsIHBhdGNoZXMgYXJlIGNsZWFuIGJh Y2sgcG9ydC4NCiANCkhlcmUgaXMgdGhlIGNvbW1pdCBtc2cgcGxlYXNlIGhhdmUgYSBsb29rIG9u Y2UuIE9uY2UgeW91IGNvbmZpcm1lZCBJIHdpbGwgbW9kaWZ5IG90aGVyIHBhdGNoZXMgYW5kIHNl bmQgaXQgZm9yIHJldmlldy4NCg0KQXV0aG9yOiBaZW5naHVpIFl1IDx5dXplbmdodWlAaHVhd2Vp LmNvbT4NCkRhdGU6ICAgTW9uIEF1ZyAyMiAxNjoxOTowMSAyMDIyICswMTAwDQoNCiAgICB4ZW4v YXJtOiBzbW11djM6IEZpeCBsMSBzdHJlYW0gdGFibGUgc2l6ZSBpbiB0aGUgZXJyb3IgbWVzc2Fn ZQ0KICAgIA0KICAgIEJhY2twb3J0IExpbnV4IGNvbW1pdCBkYzg5OGViODRiMjUuIFRoaXMgaXMg dGhlIGNsZWFuIGJhY2twb3J0IHdpdGhvdXQNCiAgICBhbnkgY2hhbmdlcy4NCiAgICANCiAgICBU aGUgYWN0dWFsIHNpemUgb2YgbGV2ZWwtMSBzdHJlYW0gdGFibGUgaXMgbDFzaXplLiBUaGlzIGxv b2tzIGxpa2UgYW4NCiAgICBvdmVyc2lnaHQgb24gY29tbWl0IGQyZTg4ZTdjMDgxZWYgKCJpb21t dS9hcm0tc21tdTogRml4IExPRzJTSVpFIHNldHRpbmcNCiAgICBmb3IgMi1sZXZlbCBzdHJlYW0g dGFibGVzIikgd2hpY2ggZm9yZ290IHRvIHVwZGF0ZSB0aGUgQHNpemUgaW4gZXJyb3INCiAgICBt ZXNzYWdlIGFzIHdlbGwuDQogICAgDQogICAgQXMgbWVtb3J5IGFsbG9jYXRpb24gZmFpbHVyZSBp cyBhbHJlYWR5IGJhZCBlbm91Z2gsIG5vdGhpbmcgd29yc2Ugd291bGQNCiAgICBoYXBwZW4uIEJ1 dCBsZXQncyBiZSBjYXJlZnVsLg0KICAgIA0KICAgIFNpZ25lZC1vZmYtYnk6IFplbmdodWkgWXUg PHl1emVuZ2h1aUBodWF3ZWkuY29tPg0KICAgIExpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L3IvMjAyMDA4MjYxNDE3NTguMzQxLTEteXV6ZW5naHVpQGh1YXdlaS5jb20NCiAgICBTaWduZWQt b2ZmLWJ5OiBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPg0KICAgIE9yaWdpbjogZ2l0Oi8v Z2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4Lmdp dCBkYzg5OGViODRiMjUNCiAgICBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2lu Z2hAYXJtLmNvbT4NCg0KZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FybS9z bW11LXYzLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hcm0vc21tdS12My5jDQppbmRleCBm MjU2MmFjYzM4Li4zNDA2MDkyNjRkIDEwMDY0NA0KLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYXJtL3NtbXUtdjMuYw0KKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXJtL3NtbXUt djMuYw0KQEAgLTIzNDgsNyArMjM0OCw3IEBAIHN0YXRpYyBpbnQgYXJtX3NtbXVfaW5pdF9zdHJ0 YWJfMmx2bChzdHJ1Y3QgYXJtX3NtbXVfZGV2aWNlICpzbW11KQ0KICAgICAgICBpZiAoIXN0cnRh Yikgew0KICAgICAgICAgICAgICAgIGRldl9lcnIoc21tdS0+ZGV2LA0KICAgICAgICAgICAgICAg ICAgICAgICAgImZhaWxlZCB0byBhbGxvY2F0ZSBsMSBzdHJlYW0gdGFibGUgKCV1IGJ5dGVzKVxu IiwNCi0gICAgICAgICAgICAgICAgICAgICAgIHNpemUpOw0KKyAgICAgICAgICAgICAgICAgICAg ICAgbDFzaXplKTsNCiAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsNCiAgICAgICAgfQ0K ICAgICAgICBjZmctPnN0cnRhYiA9IHN0cnRhYjsNCg0KDQpSZWdhcmRzLA0KUmFodWwNCg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 01 11:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 11:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396500.636649 (Exim 4.92) (envelope-from ) id 1oThvU-0006TQ-9p; Thu, 01 Sep 2022 11:00:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396500.636649; Thu, 01 Sep 2022 11:00:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oThvU-0006TJ-72; Thu, 01 Sep 2022 11:00:00 +0000 Received: by outflank-mailman (input) for mailman id 396500; Thu, 01 Sep 2022 10:59:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oThvT-0006T9-7e; Thu, 01 Sep 2022 10:59:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oThvT-0001dl-3Y; Thu, 01 Sep 2022 10:59:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oThvS-0005QL-Os; Thu, 01 Sep 2022 10:59:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oThvS-0004NH-OS; Thu, 01 Sep 2022 10:59:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AeP1sTRHxd/dVAZa9PQyFJ80X0MtsZoAnjLXB+hGK+A=; b=JTEKpSO+aU/yi1Ab1Od+ALr1qw daeJLvbprfWfTCaVfcDOEst22h6Lm+G/3Luv5sgAQQc1vpbhikgi4ccP0XwATsxNMScC9QbkGgsSZ HWDQHgMtuhCgdPRo8Z1SSiNxCd4bl4uTI6Cu15WeqZDCPPFrLxoGSqNKbF/klYuEtQMs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172902: regressions - FAIL X-Osstest-Failures: linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c5e4d5e99162ba8025d58a3af7ad103f155d2df7 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 01 Sep 2022 10:59:58 +0000 flight 172902 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux c5e4d5e99162ba8025d58a3af7ad103f155d2df7 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 28 days Failing since 172152 2022-08-05 04:01:26 Z 27 days 62 attempts Testing same since 172902 2022-08-31 23:12:06 Z 0 days 1 attempts ------------------------------------------------------------ 1599 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 165102 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 11:05:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 11:05:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396508.636660 (Exim 4.92) (envelope-from ) id 1oTi0Z-0007uf-Tw; Thu, 01 Sep 2022 11:05:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396508.636660; Thu, 01 Sep 2022 11:05:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTi0Z-0007uY-R7; Thu, 01 Sep 2022 11:05:15 +0000 Received: by outflank-mailman (input) for mailman id 396508; Thu, 01 Sep 2022 11:05:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTi0Y-0007uS-5x for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 11:05:14 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3312bd1-29e5-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 13:05:12 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 0601C22679; Thu, 1 Sep 2022 11:05:12 +0000 (UTC) Received: from suse.de (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 314B12C142; Thu, 1 Sep 2022 11:05:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3312bd1-29e5-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662030312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Mq+Xr0OI+bfUf9L9MD4E1lYUlcZgNZF3vEeJl7iivY=; b=qxrx6Job1q9NhDr8jWgNkmZI/DIOO/4e7B7RmUvgkYmx7g2HD/fgMwo5Yk3h0VlLoTt148 XYp7yip2SBIiuI+n/MfaQLawKmE1HR8l9pazuynzZByPC2unjCGeYASa4WYFvbNUExE7dA 7MiaajpJfHroyIAEi/eiNxfkWvr+0Tc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662030312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Mq+Xr0OI+bfUf9L9MD4E1lYUlcZgNZF3vEeJl7iivY=; b=aI8rpCPzOEsCk4iUnJ8AJ2D/wDZBIW/Yuzt0mzTQGVVpTTlaSfJwPqq4wfJerDAgBO140w J3d/FttUmGmZwoAQ== Date: Thu, 1 Sep 2022 12:05:01 +0100 From: Mel Gorman To: Kent Overstreet Cc: Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901110501.o5rq5yzltomirxiw@suse.de> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831155941.q5umplytbx6offku@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20220831155941.q5umplytbx6offku@moria.home.lan> On Wed, Aug 31, 2022 at 11:59:41AM -0400, Kent Overstreet wrote: > On Wed, Aug 31, 2022 at 11:19:48AM +0100, Mel Gorman wrote: > > On Wed, Aug 31, 2022 at 04:42:30AM -0400, Kent Overstreet wrote: > > > On Wed, Aug 31, 2022 at 09:38:27AM +0200, Peter Zijlstra wrote: > > > > On Tue, Aug 30, 2022 at 02:48:49PM -0700, Suren Baghdasaryan wrote: > > > > > =========================== > > > > > Code tagging framework > > > > > =========================== > > > > > Code tag is a structure identifying a specific location in the source code > > > > > which is generated at compile time and can be embedded in an application- > > > > > specific structure. Several applications of code tagging are included in > > > > > this RFC, such as memory allocation tracking, dynamic fault injection, > > > > > latency tracking and improved error code reporting. > > > > > Basically, it takes the old trick of "define a special elf section for > > > > > objects of a given type so that we can iterate over them at runtime" and > > > > > creates a proper library for it. > > > > > > > > I might be super dense this morning, but what!? I've skimmed through the > > > > set and I don't think I get it. > > > > > > > > What does this provide that ftrace/kprobes don't already allow? > > > > > > You're kidding, right? > > > > It's a valid question. From the description, it main addition that would > > be hard to do with ftrace or probes is catching where an error code is > > returned. A secondary addition would be catching all historical state and > > not just state since the tracing started. > > Catching all historical state is pretty important in the case of memory > allocation accounting, don't you think? > Not always. If the intent is to catch a memory leak that gets worse over time, early boot should be sufficient. Sure, there might be drivers that leak memory allocated at init but if it's not a growing leak, it doesn't matter. > Also, ftrace can drop events. Not really ideal if under system load your memory > accounting numbers start to drift. > As pointed out elsewhere, attaching to the tracepoint and recording relevant state is an option other than trying to parse a raw ftrace feed. For memory leaks, there are already tracepoints for page allocation and free that could be used to track allocations that are not freed at a given point in time. There is also the kernel memory leak detector although I never had reason to use it (https://www.kernel.org/doc/html/v6.0-rc3/dev-tools/kmemleak.html) and it sounds like it would be expensive. > > It's also unclear *who* would enable this. It looks like it would mostly > > have value during the development stage of an embedded platform to track > > kernel memory usage on a per-application basis in an environment where it > > may be difficult to setup tracing and tracking. Would it ever be enabled > > in production? Would a distribution ever enable this? If it's enabled, any > > overhead cannot be disabled/enabled at run or boot time so anyone enabling > > this would carry the cost without never necessarily consuming the data. > > The whole point of this is to be cheap enough to enable in production - > especially the latency tracing infrastructure. There's a lot of value to > always-on system visibility infrastructure, so that when a live machine starts > to do something wonky the data is already there. > Sure, there is value but nothing stops the tracepoints being attached as a boot-time service where interested. For latencies, there is already bpf examples for tracing individual function latency over time e.g. https://github.com/iovisor/bcc/blob/master/tools/funclatency.py although I haven't used it recently. Live parsing of ftrace is possible, albeit expensive. https://github.com/gormanm/mmtests/blob/master/monitors/watch-highorder.pl tracks counts of high-order allocations and dumps a report on interrupt as an example of live parsing ftrace and only recording interesting state. It's not tracking state you are interested in but it demonstrates it is possible to rely on ftrace alone and monitor from userspace. It's bit-rotted but can be fixed with diff --git a/monitors/watch-highorder.pl b/monitors/watch-highorder.pl index 8c80ae79e556..fd0d477427df 100755 --- a/monitors/watch-highorder.pl +++ b/monitors/watch-highorder.pl @@ -52,7 +52,7 @@ my $regex_pagealloc; # Static regex used. Specified like this for readability and for use with /o # (process_pid) (cpus ) ( time ) (tpoint ) (details) -my $regex_traceevent = '\s*([a-zA-Z0-9-]*)\s*(\[[0-9]*\])\s*([0-9.]*):\s*([a-zA-Z_]*):\s*(.*)'; +my $regex_traceevent = '\s*([a-zA-Z0-9-]*)\s*(\[[0-9]*\])\s*([0-9. ]*):\s*([a-zA-Z_]*):\s*(.*)'; my $regex_statname = '[-0-9]*\s\((.*)\).*'; my $regex_statppid = '[-0-9]*\s\(.*\)\s[A-Za-z]\s([0-9]*).*'; @@ -73,6 +73,7 @@ sub generate_traceevent_regex { $regex =~ s/%p/\([0-9a-f]*\)/g; $regex =~ s/%d/\([-0-9]*\)/g; $regex =~ s/%lu/\([0-9]*\)/g; + $regex =~ s/%lx/\([0-9a-zA-Z]*\)/g; $regex =~ s/%s/\([A-Z_|]*\)/g; $regex =~ s/\(REC->gfp_flags\).*/REC->gfp_flags/; $regex =~ s/\",.*//; Example output 3 instances order=2 normal gfp_flags=GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_ZERO => trace_event_raw_event_mm_page_alloc+0x7d/0xc0 => __alloc_pages+0x188/0x250 => kmalloc_large_node+0x3f/0x80 => __kmalloc_node+0x321/0x420 => kvmalloc_node+0x46/0xe0 => ttm_sg_tt_init+0x88/0xb0 [ttm] => amdgpu_ttm_tt_create+0x4f/0x80 [amdgpu] => ttm_tt_create+0x59/0x90 [ttm] => ttm_bo_handle_move_mem+0x7e/0x1c0 [ttm] => ttm_bo_validate+0xc5/0x140 [ttm] => ttm_bo_init_reserved+0x17b/0x200 [ttm] => amdgpu_bo_create+0x1a3/0x470 [amdgpu] => amdgpu_bo_create_user+0x34/0x60 [amdgpu] => amdgpu_gem_create_ioctl+0x131/0x3a0 [amdgpu] => drm_ioctl_kernel+0xb5/0x140 => drm_ioctl+0x224/0x3e0 => amdgpu_drm_ioctl+0x49/0x80 [amdgpu] => __x64_sys_ioctl+0x8a/0xc0 => do_syscall_64+0x5c/0x90 => entry_SYSCALL_64_after_hwframe+0x63/0xcd 3 instances order=1 normal gfp_flags=GFP_NOWAIT|__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_COMP|__GFP_ACCOUNT => trace_event_raw_event_mm_page_alloc+0x7d/0xc0 => __alloc_pages+0x188/0x250 => __folio_alloc+0x17/0x50 => vma_alloc_folio+0x8f/0x350 => __handle_mm_fault+0xa1e/0x1120 => handle_mm_fault+0xb2/0x280 => do_user_addr_fault+0x1b9/0x690 => exc_page_fault+0x67/0x150 => asm_exc_page_fault+0x22/0x30 It's not tracking leaks because that is not what I was intrested in at the time but could using the same method and recording PFNs that were allocated, their call site but not freed. These days, this approach may be a bit unexpected but it was originally written 13 years ago. It could have been done with systemtap back then but my recollection was that it was difficult to keep systemtap working with rc kernels. > What we've built here this is _far_ cheaper than anything that could be done > with ftrace. > > > It might be an ease-of-use thing. Gathering the information from traces > > is tricky and would need combining multiple different elements and that > > is development effort but not impossible. > > > > Whatever asking for an explanation as to why equivalent functionality > > cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > > I think perhaps some of the expectation should be on the "ftrace for > everything!" people to explain a: how their alternative could be even built and > b: how it would compare in terms of performance and ease of use. > The ease of use is a criticism as there is effort required to develop the state tracking of in-kernel event be it from live parsing ftrace, attaching to tracepoints with systemtap/bpf/whatever and the like. The main disadvantage with an in-kernel implementation is three-fold. First, it doesn't work with older kernels without backports. Second, if something slightly different it needed then it's a kernel rebuild. Third, if the option is not enabled in the deployed kernel config then you are relying on the end user being willing to deploy a custom kernel. The initial investment in doing memory leak tracking or latency tracking by attaching to tracepoints is significant but it works with older kernels up to a point and is less sensitive to the kernel config options selected as features like ftrace are often selected. -- Mel Gorman SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 11:17:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 11:17:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396516.636671 (Exim 4.92) (envelope-from ) id 1oTiCA-00018z-4e; Thu, 01 Sep 2022 11:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396516.636671; Thu, 01 Sep 2022 11:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiCA-00018s-1Y; Thu, 01 Sep 2022 11:17:14 +0000 Received: by outflank-mailman (input) for mailman id 396516; Thu, 01 Sep 2022 11:17:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiC7-00018m-PS for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 11:17:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cc091b6-29e7-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 13:17:08 +0200 (CEST) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Sep 2022 07:17:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6101.namprd03.prod.outlook.com (2603:10b6:208:308::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Thu, 1 Sep 2022 11:17:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.012; Thu, 1 Sep 2022 11:17:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cc091b6-29e7-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662031027; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1XeAqMZOQn8rtmQbiOmOwn6tHWrlcUZaXrWPVJfxQso=; b=H1CSfbkfZKsz7yyscqJihxlYDxZv6cKUAnWBDyIkFhLrntuyurTN+Wm9 Rzj/ifk2hr66xw5kuWPvDB6uQH/oCkO295I1anfaMXs1yKNdAZDhr5Zgl VGSMCRd5kJdOlb+F5WysH/m5pAJqlfLq/9VMou1vHqNWgAfAUW9Fv7St+ g=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 79547364 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ScAj/qt11Wc6c3I1Tb/LOJjEn+fnVHFfMUV32f8akzHdYApBsoF/q tZmKTuPPfiDY2DwLdlyaojg80JV7MDcyIJhSQNkrS9gHi5A+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4GpA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYwx+bxQMHhyz sw3GjExTAivjv+Uwb3uH4GAhux7RCXqFKU2nyg4iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QLT/PJqi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv Dnu9GXlGBAKcteYzFJp91rz17KTwnilBOr+EpXj691B0HKw21YcJxhKVAeVgeKBkEuhDoc3x 0s8v3BGQbIJ3E6kVN7mRDWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vlCzVgv7ySTXO17aqPoHW5Pi19EIMZTSoNTA9A79y9pog210rLVow6SPPzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:cqR5dqMhuEvU6sBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.93,280,1654574400"; d="scan'208";a="79547364" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrBhQ5o417KMBLU2me2mhEG1ne2tKKGfH/tMqj+eMnMOEvWEB2mriuvezjRoAKviCyYjDYKrVuosvtvwK5u8K/vPYVGeqTIroa48J+fJN/ymLMJnsDgn6Kqx6kW10fyGeOwTLHacl6vzfGdeZBKXIgWkZVeB/tkkgxZqny85u5ToTLWRFw9B81rSU+A91ClhF59Zlv8YK7gF1AOJfqsMmQh3y8GUBk53TVsuyKyMoSWUM/+oBH3Dxpyd1CK4Lv2TzFWp1aq1u6DssjtAscmiftZ4AS19xmXM006OAcB+KDU6BwJWncCegouMSlIbSYG9G9oGIh5A42mO/2lFCUIznA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XeAqMZOQn8rtmQbiOmOwn6tHWrlcUZaXrWPVJfxQso=; b=Ch+VGjZLf3npPrNJLepsxzoVf0sZKIIhI/aUZVdOBhphSXS+bFykY9jb143+ya7ikgIzwtOHtgDZRu+tx7dAgUnAQuo9cGkWmbm+ZZyZNDbKVJWy/uPwg2U8i2PdUH4pPIfFD4LXGuRz5gCtatQQs6G5ED4x8aUB2vQDYi0FNm2C60jZHUut7hPN1YgiR0LtaBUlCZcMAriiI1eAKVVeQtphHtbBI/EIkOUmDmehKSk1wUGFGyUJgUnrhTfwYdPonlkxYB2eJUrbMkvzPNyZ6QBgJu7kzYzbhAFUIb7vDvS4ktSK7MiGDjz5FWixn+ZHwIaUxl/O99dxeZzNCp4WQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XeAqMZOQn8rtmQbiOmOwn6tHWrlcUZaXrWPVJfxQso=; b=hN6hCRxEaK+bdCBw6pWnCfnAybYanzknL9V/bFEwX2tbDJViNoypbAmY0H5uOExN6n0HYeqePYJhpXDNgQ7+ePtoytUrXlOOoyOiT313i7QQQmjhDwCtl60XU77QpZG6ky7I0nmPQwnO/bziKTcesq0krsjXdbD2hG5Z6nqZNwk= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: George Dunlap , Dario Faggioli Subject: Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() Thread-Topic: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() Thread-Index: AQHYsVjU6cwqlcc3IUyYiKoWS8gK1a3KhgKA Date: Thu, 1 Sep 2022 11:17:02 +0000 Message-ID: References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-3-jgross@suse.com> In-Reply-To: <20220816101317.23014-3-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc6f92b7-3099-4ebd-6829-08da8c0b7f08 x-ms-traffictypediagnostic: BL1PR03MB6101:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bwKIwI6G69hy1IPdtcwA2x1q687+39ExLkun7/2pRw6kZ9ki3vpdSx6+AyfwwPi5RANOxpFOryu6PsAgwQlSe+aYiQd6Iqdt1ZGY+RUrl78YaVWuPpjjmQg2BqTP7T1+jl9rPr3OeJWb5WKQBc/fV60yEvvD5+fTiipQA6N9LwSWQxLHXAiNcKK7kcMAw1W6Ke+K8iIssXwZEOG4X61eFoPU1eRCbq+ZvRfn8Byvb/Ruwlx3/buBnrchEL8tr9Y5tKHs/2x076jSTjbnZ+ffzMsrO0gFP+xmVn/M9VUhqGjdBZP1jGVhVnQJkmUqoE9gvkXzTInW1ZKb1b8/qhMt+zhqCQfDn5KwiwM1UPIaWyJ52AXhmNblws/vre1cHF2iDKF0MJK0b7ZBPNgIRb4NgVsIiFOzbYLfhHwGqqJSBPFR40/5jW3TnHEIk1oLbVnvlTldHl7e0ZAludDlgxwo6HABIYuJlxo8bLcX5j4GgsuQk+hTf2K6WXZw4DJ2fYzClsmUO6pfvEOsRrp9jiGBgE2xMg2NLXPwQWqpZey6/VwKvxuy1VGhz0YNgbBbjm9uCW2ZFJkCxYrCKiMmADxc9hHIUUu5fOBO1lovbJ0o8nH4FQXOvTPUCfXyrQhpHAGnwTTcbonYvEOBcWr9E/DJ2UK4Z7BMWOvP1Sb8k5/3k0Cz2AALTatbJ47+ooCgS7iwVzVCBv6zo3Wn1BkfCKG8bQ9s/voHruSu4EDc/WP5mrL9R2KLFpjPZSUJH3tS5qBJHH8b4S4vLz/qXwx5Zyd/C/iw9fQ2d/BqxxWXdEY2TYX7VBqCoAy9aK77nPbahtwRGHSyighStwmeGMSstbDxjA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(478600001)(6486002)(53546011)(26005)(6506007)(6512007)(41300700001)(71200400001)(66556008)(66476007)(64756008)(66446008)(76116006)(66946007)(4326008)(8676002)(91956017)(5660300002)(4744005)(8936002)(54906003)(110136005)(2906002)(316002)(82960400001)(38070700005)(38100700002)(36756003)(31696002)(86362001)(31686004)(83380400001)(2616005)(186003)(122000001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WTFJOElyY3hyOFUrTHFyeEhuSnc0Q3JGbkxKOEFmREJ4RVVxaFRMUGZPVmVO?= =?utf-8?B?VFpHME5qd3podk5lano5SDdJVDlzcDlEQjdXbm53UHFFazJabXZMcXNSNm5a?= =?utf-8?B?ajRMWE1ZN25kQTJla295ZlkyY2Uvc0w5Wkt1UndueVRhRFo3TVlpa2Z2dzIz?= =?utf-8?B?bmlEYU4yZVlYR0ZGVWlSa3ZYbUMyZHYxZ3dHVld5UndKVFp4OFd2Y0U1aitC?= =?utf-8?B?N3RqekhlL2NnRy9ydG5XN1l2blQxbzZZaEhHT3B4bXZ2aU5DV1A5bjRXTjNo?= =?utf-8?B?Qi9BdkhxaFlGSGYyZ2s1REN0Y0t5NnhtQUd6Z2Z2dk92SzNLTXpZM3V1MTJI?= =?utf-8?B?UmhlUFIrTGdpNXZVaGxBMng4eVM3bWJqQU1MWjhlZUIwYW56b3VaN05rT2xB?= =?utf-8?B?SS8vTWhFdzNuUWVRR3dUWlFhU2xoTzVmWjJ1aU1lQmdqcjRsTFk2R1ZtVkE1?= =?utf-8?B?ZWFBbktiOEs1SnlsSzFISVlKQ0ZLSlh1SVVxNWY2SG83Z1ptYUgzOVowd2pi?= =?utf-8?B?YmVpWldnRkZxZGZQeGZGOG52d0NVSzBjcUZNUXp2SkE0NlVpb041ekJ3bVh0?= =?utf-8?B?OVlTdmU5TEV3TDdsWnNNTW1PQTU3NGptS0E1ck5vbStjd08ybk91SEhZSjRZ?= =?utf-8?B?bVpINU1UcTJyQkNZQmhmbkZYUTJWYUVGSFEyUnhYV2g3Y0hwL1g3SXhJeSto?= =?utf-8?B?WHBGdmcxc1VZTGlLRVcvM2lQMzExZ1dCSTZsdUo5REU4ZnJWVnhCTUZoZ29W?= =?utf-8?B?OHFlRWFsMkNxQkQ0T3JGMG0wYzhpL0VTMXRySDZZZUwwcU1QNTRUdStXV29s?= =?utf-8?B?NnR5cTJ6ektIT0JlNzc3UEUrWWYrVDVCYTdxQ0sycm5EaHRIUmFaMklyTUwr?= =?utf-8?B?N2l3UWtNdjNZcGpjYzNRL0srWDRsV0hsRnlIcDU4SW1TK0ozTWRSZ1BPYUcz?= =?utf-8?B?QzBWZit2SHdOR1BPTHVKRWdjbURmdHBDSVlKYVI1RnVSOU80Vlp4VHd2Y1By?= =?utf-8?B?cVk3M0h4YkRlT040eklGejVDZ3BVZzdpQmJwNWFwOHZwVU5wMGZSN3RwblFI?= =?utf-8?B?a2RTZ2hUMHFYNEpzWThtTis3eUZ5aWpwSVhnMG5jRUpaL3JDS216Vnd2UFkx?= =?utf-8?B?eFlBaGtBZ2ZmUzdMd1lkRzRGQlZuc1FvcVc5UkRKREVTa0pmVUhZeHJ5ZzJa?= =?utf-8?B?MXoxaWlISmtNRFlDTHZpYm9yRGJDWVdyWHova0xLVmUvWm9JQks4dW5zbWdy?= =?utf-8?B?Yy9qU09ZdlpZaHNyczNjdDdtN3ZmMkNEOUIrN3NGcVB1Ums5NmNJcFJvVjRL?= =?utf-8?B?L1dOby9oOHlxYUZOSkZVSTFXK1F3QWJFWXdVOGpidGIwNkQvZk83cndqOEts?= =?utf-8?B?TkROTzhocG5MOEE3WHVHS3ZVaGhQcERFeWN6QXZ6OWdLeFY1YnF5ZHk0cDBB?= =?utf-8?B?Tk5OMTh2S3NoSFlUWVc0azRxK1NXVkd1NWFlOUh4N2dVeENVbms4VkFwVlF1?= =?utf-8?B?eFoxbG1SSHA2WWlzSzhUbGVwbkNNK094ZEgzQU1aQThMbXl4bXZSWnBNNEhs?= =?utf-8?B?dkNad0hGU1dZd0J1ZFBnc2hFWFRzY3J4VU5naGdjcGhLUmM4ZGhzaU9IZGN1?= =?utf-8?B?Ym4rSmkxdDFLS29XeDdpL0M2YjRlTi9rNHlUTDlMbU0zbzc4WXAzVWtTM2lu?= =?utf-8?B?R1R4WHRZNUFqejExYi9mRTVMaVBGeGtZcTZaOGRoSjByT2JIQ1owaDExMzN6?= =?utf-8?B?SVlIRktIanQyd3V1Sk1nQ3pnczBWdzVIL0k2Uis0bml6dVQxelRLbytJSWI0?= =?utf-8?B?RU5aMmx0cE9lODJyMzZORkhaOElKWk9QemVrR2IwT3VGam51QXpCb3dsdjMz?= =?utf-8?B?dC8vMTA5aHRwZnBGenNhWVJlQzB1UjloRTEwM28xcDRydkQ5a2Z4eFJUb3Yz?= =?utf-8?B?TEYra2l6cHQrbDl3eFcxcGx1MzBxVnRDeEFZVldBOERoZ25qRktaZ2RHZkJU?= =?utf-8?B?QjlNb2N1WFJEeW9GUmoweFJDemh3U2E5Z0R4U2p3a3FzdzVwQ0RsWlc1Yitz?= =?utf-8?B?QTNDRXc3ZWdTU0ZQM0gwY2JFN3dkZmxCSUNlbWhkZkhCMU90TndsNm1DamFw?= =?utf-8?Q?eG0WQBk7trvN9gIo/07twn6M2?= Content-Type: text/plain; charset="utf-8" Content-ID: <990A17905BE2FD45BB98697101413B65@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc6f92b7-3099-4ebd-6829-08da8c0b7f08 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 11:17:02.9664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XMH8jlBrmUmCkxG1HEV+tJZwWkQkjK4nOh0s0yw8aNdiIKzS0mQfHZb4tcFyc6IcBa8Hbj3pP5k6eRcamb7mfhzEjDhprsm9vP7kl/I8oPY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6101 T24gMTYvMDgvMjAyMiAxMToxMywgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gZGlmZiAtLWdpdCBh L3hlbi9jb21tb24vc2NoZWQvY29yZS5jIGIveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMNCj4gaW5k ZXggZjZlZWQ4ODkzMC4uMjI4NDcwYWM0MSAxMDA2NDQNCj4gLS0tIGEveGVuL2NvbW1vbi9zY2hl ZC9jb3JlLmMNCj4gKysrIGIveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMNCj4gQEAgLTMyMzcsNiAr MzIzNyw3NSBAQCBvdXQ6DQo+ICAgICAgcmV0dXJuIHJldDsNCj4gIH0NCj4gIA0KPiArLyoNCj4g KyAqIEFsbG9jYXRlIGFsbCBtZW1vcnkgbmVlZGVkIGZvciBzY2hlZHVsZV9jcHVfcm1fZnJlZSgp LCB3aGljaCBjYW4ndCBkbyB0aGF0DQo+ICsgKiBkdWUgdG8gYmUgY2FsbGVkIGluIHN0b3BfbWFj aGluZSgpIGNvbnRleHQgd2l0aCBpbnRlcnJ1cHRzIGRpc2FibGVkLg0KDQpBcyBhIG1pbm9yIG9i c2VydmF0aW9uLCB0aGlzIGlzIGF3a3dhcmQgZ3JhbW1hci7CoCBJJ2Qgc3VnZ2VzdCAiLi4uDQpu ZWVkZWQgZm9yIGZyZWVfY3B1X3JtX2RhdGEoKSwgYXMgYWxsb2NhdGlvbnMgY2Fubm90IGJlIG1h ZGUgaW4NCnN0b3BfbWFjaGluZSgpIGNvbnRleHQiLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 01 11:21:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 11:21:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396523.636682 (Exim 4.92) (envelope-from ) id 1oTiGk-0002Ye-MY; Thu, 01 Sep 2022 11:21:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396523.636682; Thu, 01 Sep 2022 11:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiGk-0002YX-Ja; Thu, 01 Sep 2022 11:21:58 +0000 Received: by outflank-mailman (input) for mailman id 396523; Thu, 01 Sep 2022 11:21:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiGj-0002YN-Dr; Thu, 01 Sep 2022 11:21:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiGj-00021v-9n; Thu, 01 Sep 2022 11:21:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiGi-0006nb-Si; Thu, 01 Sep 2022 11:21:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTiGi-0002AR-SE; Thu, 01 Sep 2022 11:21:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sUJbj3w53ZS2FcZTuU4cEF3VzktUSMkVXlUFIkya6bQ=; b=fJ0SBiOsHAylW28kjc7F+P84GT BZuTP2odH6zDAKji2aTgl36k0HLDH9OVN7W9pg3MbXZq99fjiQYFxMxjtaJVtYGjGPsx5sFrwgCjr mc3VgrLiphpuP6NtsI0lF1tIe1Uu6VHnSLAfJ1bV82hi+xLaNKqmtuSSED7B2L+036fs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172909: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=9ca7ece8b3b1743b6ee76f5f20f2c5eeed001d72 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 01 Sep 2022 11:21:56 +0000 flight 172909 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172909/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 9ca7ece8b3b1743b6ee76f5f20f2c5eeed001d72 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 218 attempts Testing same since 172909 2022-09-01 08:40:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Ray Ni Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1248 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 11:24:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 11:24:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396531.636693 (Exim 4.92) (envelope-from ) id 1oTiJX-0003Aq-5C; Thu, 01 Sep 2022 11:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396531.636693; Thu, 01 Sep 2022 11:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiJX-0003Aj-1u; Thu, 01 Sep 2022 11:24:51 +0000 Received: by outflank-mailman (input) for mailman id 396531; Thu, 01 Sep 2022 11:24:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTiJV-0003AY-QZ for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 11:24:49 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b011c100-29e8-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 13:24:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DE23E2265F; Thu, 1 Sep 2022 11:24:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B4F5E13A79; Thu, 1 Sep 2022 11:24:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ePyfKn+WEGOGBQAAMHmgww (envelope-from ); Thu, 01 Sep 2022 11:24:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b011c100-29e8-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662031487; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uedeku0RXtcWiyeFDdKyLcP3uEp1CyzNSCtc/pYt7E4=; b=P5r1NDWMV9/HgyLe56TlCkHaKAeBYsr8dSSRMnowPmNh++mwtOCkD6XFp8Ibo++spv400G 1S7mSEkIfTL1pU6EUzLzwerA7ZH8Tmg9IhTEOkC9Z5h2NEeYJXg0KtmY3Sv0b/rX3t38Xs HHZ0z86s6wIcB9ScHrVJRT06HkmzwTk= Message-ID: <77346c6d-4a0c-b441-2253-4e968207c780@suse.com> Date: Thu, 1 Sep 2022 13:24:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Dario Faggioli References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-3-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ruzH4VwDHLoAVF3POWYEEM0e" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ruzH4VwDHLoAVF3POWYEEM0e Content-Type: multipart/mixed; boundary="------------fe45wrmu3t9Q9l9LH38KZmyB"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Dario Faggioli Message-ID: <77346c6d-4a0c-b441-2253-4e968207c780@suse.com> Subject: Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-3-jgross@suse.com> In-Reply-To: --------------fe45wrmu3t9Q9l9LH38KZmyB Content-Type: multipart/mixed; boundary="------------gp2lrGx52mDprKaBfe7qTnfh" --------------gp2lrGx52mDprKaBfe7qTnfh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDkuMjIgMTM6MTcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDE2LzA4LzIw MjIgMTE6MTMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2Nv bW1vbi9zY2hlZC9jb3JlLmMgYi94ZW4vY29tbW9uL3NjaGVkL2NvcmUuYw0KPj4gaW5kZXgg ZjZlZWQ4ODkzMC4uMjI4NDcwYWM0MSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9jb21tb24vc2No ZWQvY29yZS5jDQo+PiArKysgYi94ZW4vY29tbW9uL3NjaGVkL2NvcmUuYw0KPj4gQEAgLTMy MzcsNiArMzIzNyw3NSBAQCBvdXQ6DQo+PiAgICAgICByZXR1cm4gcmV0Ow0KPj4gICB9DQo+ PiAgIA0KPj4gKy8qDQo+PiArICogQWxsb2NhdGUgYWxsIG1lbW9yeSBuZWVkZWQgZm9yIHNj aGVkdWxlX2NwdV9ybV9mcmVlKCksIHdoaWNoIGNhbid0IGRvIHRoYXQNCj4+ICsgKiBkdWUg dG8gYmUgY2FsbGVkIGluIHN0b3BfbWFjaGluZSgpIGNvbnRleHQgd2l0aCBpbnRlcnJ1cHRz IGRpc2FibGVkLg0KPiANCj4gQXMgYSBtaW5vciBvYnNlcnZhdGlvbiwgdGhpcyBpcyBhd2t3 YXJkIGdyYW1tYXIuwqAgSSdkIHN1Z2dlc3QgIi4uLg0KPiBuZWVkZWQgZm9yIGZyZWVfY3B1 X3JtX2RhdGEoKSwgYXMgYWxsb2NhdGlvbnMgY2Fubm90IGJlIG1hZGUgaW4NCj4gc3RvcF9t YWNoaW5lKCkgY29udGV4dCIuDQoNCk9rYXksIHdpbGwgY2hhbmdlIGl0Lg0KDQoNCkp1ZXJn ZW4NCg== --------------gp2lrGx52mDprKaBfe7qTnfh Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------gp2lrGx52mDprKaBfe7qTnfh-- --------------fe45wrmu3t9Q9l9LH38KZmyB-- --------------ruzH4VwDHLoAVF3POWYEEM0e Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMQln8FAwAAAAAACgkQsN6d1ii/Ey9e Igf8DCsny9dM+Vxut0ae1VbWx8mNugXxHGrOFtFHd18N0xat0XGa2knJh1z5DQOQdAZDI8fHt5XJ r/KNChIOWcPXTNJ+jbVRHM2M0AeOmbIgszuf6Mur9dIK818B2x+RttX0J3pFRCYU8DjAUgiAbIYs ocmvoXGZISvIygjyyOewI2jBujv7hppV5f8TCB4udSeICQc7SMiClU4zkaikmtOn2IL4Iunex93R /mS8/W8F/Swdr7p7OSTg3Yrgi8dunSB5GaZq5hz4fEiVQo7he18eL+NO5meUlIovQqr5mnWx8o/k R1YCYgTT03Q5/Z8zTcDNpIy7LR8SINWs+9c4pO0WRA== =UJ8Q -----END PGP SIGNATURE----- --------------ruzH4VwDHLoAVF3POWYEEM0e-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 11:56:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 11:56:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396537.636704 (Exim 4.92) (envelope-from ) id 1oTinr-0006SU-Jq; Thu, 01 Sep 2022 11:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396537.636704; Thu, 01 Sep 2022 11:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTinr-0006SN-H3; Thu, 01 Sep 2022 11:56:11 +0000 Received: by outflank-mailman (input) for mailman id 396537; Thu, 01 Sep 2022 11:56:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTinq-0006SH-7Y for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 11:56:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTinp-0002b8-IH; Thu, 01 Sep 2022 11:56:09 +0000 Received: from [54.239.6.185] (helo=debian.cbg12.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTinp-000695-79; Thu, 01 Sep 2022 11:56:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" From: Paul Durrant To: netdev@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Paul Durrant , Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed Date: Thu, 1 Sep 2022 12:55:54 +0100 Message-Id: <20220901115554.16996-1-pdurrant@amazon.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removing 'hotplug-status' in backend_disconnected() means that it will be removed even in the case that the frontend unilaterally disconnects (which it is free to do at any time). The consequence of this is that, when the frontend attempts to re-connect, the backend gets stuck in 'InitWait' rather than moving straight to 'Connected' (which it can do because the hotplug script has already run). Instead, the 'hotplug-status' mode should be removed in netback_remove() i.e. when the vif really is going away. Fixes: 0f4558ae9187 ("Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"") Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: "Marek Marczykowski-Górecki" --- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 990360d75cb6..e85b3c5d4acc 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -256,7 +256,6 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); - xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ @@ -984,6 +983,7 @@ static int netback_remove(struct xenbus_device *dev) struct backend_info *be = dev_get_drvdata(&dev->dev); unregister_hotplug_status_watch(be); + xenbus_rm(XBT_NIL, dev->nodename, "hotplug-status"); if (be->vif) { kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE); backend_disconnect(be); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:01:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396546.636715 (Exim 4.92) (envelope-from ) id 1oTisj-0007yY-Cd; Thu, 01 Sep 2022 12:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396546.636715; Thu, 01 Sep 2022 12:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTisj-0007yR-8K; Thu, 01 Sep 2022 12:01:13 +0000 Received: by outflank-mailman (input) for mailman id 396546; Thu, 01 Sep 2022 12:01:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTish-0007y9-L7 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 12:01:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c37f19ef-29ed-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 14:01:09 +0200 (CEST) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Sep 2022 08:01:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB4921.namprd03.prod.outlook.com (2603:10b6:5:1ea::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 12:01:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.012; Thu, 1 Sep 2022 12:01:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c37f19ef-29ed-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662033669; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2qQyrUN58VB4D7oh6mQvBrz96Uv4XuRbLDDol7BAjOE=; b=EwkemrFRpA1fdg1J2A+v3IdaZXapWPIZlJNKrxToZTwCtQebg0GQhE/o Mm203UojEw9+lH3BT0xRNC2cA5tI1/W+EK/6ZWhgNmasgOBTKUMdNDsy+ nz3OIU22GYDSaD/n7EUVXDHdaDjY6EeYzbdaPOR9JmJXruGQBvxBcPP3x w=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 79549875 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qPAhfqrILtAaE4U+GW+m6jt7WO1eBmLRZBIvgKrLsJaIsI4StFCzt garIBnSb/zcZmLxfI0iPNi280MPvMKEn4BmGQRlrng0ES1GopuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WtB5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU++/1bWWhM1 sA1dgBQfyyqmu+d8O6kH7wEasQLdKEHPas5k1Q5l3TzK6ZjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NouQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE2b6SwXKrB996+LuQpttAiXLIn3UpMhBRUFfi/Kef2xbjcocKQ 6AT0m90xUQoz2SpQcP6RAaQu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBCTJmv7KUTnac3qyJtj70Mi8QRUcYeC4KQA0Kpdbqp6kyiA7CSpBoF6vdpt//FCz0w juKhDMjnLhVhskOv5hX5njCijOo45LPHgg841yNWnr/t1wjIom4e4av9F7Xq+5aK5qURUWAu 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF4n9hx0xZPpbxt3Qw= IronPort-HdrOrdr: A9a23:LuQQJKCCkL9vm1PlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.93,280,1654574400"; d="scan'208";a="79549875" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EiZ9aPvoQ6+2BR85nE1wfJgPjAUrXDjo14DrUG/zfV4liscqKFo+wG+pW/LsvKDqaO44Zfeb2lkQSOgoCehGmBLV3mEIJqgRDPrD+73ndbcUUnP+jpR3UfNe9WJuLMlkYQ0+2H1dReiXMj88PmEcklwhr+rNhQfESXtGnIRFAEcX2qSnb4Zb/up3hs0p0+sIJ30SeEZgdvUy712bHo+Bh/tL7ufUrZiHrd6mCuxMpPqd58vydxXG/rVy1wtLaMtJOL8P7tfO3tSQ5j12gc6AbB1WAjJYaWOJp9kSI08JV3VIFo1pNC1169AkWPnfOhT3jwxU90lA1cUA5t1RItDZUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2qQyrUN58VB4D7oh6mQvBrz96Uv4XuRbLDDol7BAjOE=; b=RwdWYcx8Dtdt3oHFfFcKRMe2D/HdfQd2CL662a3axKNmiw/oe5U7gNdKc7LH0IUntMQ4u/Fx+cKVIN93JNORSQHpHjfTLga0E+Q9m7hxNxEhgXY+y+epjMx2LblmUapoGZOmbmvngCd4RSPNm1Li5Dw660QlO/NIdP1d3eZa44UNpZRycx+uXuJltx1uhv3gbwz/TE6lzcEiRZp1Fys+8b7pBnbWO7gGoCyfKuz6oDDKVs6beQ4bDYM+aKtZ5uMBghYtAZtQgHka90uOh3bPzJf876wHGSwBtMmbUZBF8Hzf6Wl5nMHx5ydgd1FA7Ih51JSbfS8EY8bIyHx6HE/iWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qQyrUN58VB4D7oh6mQvBrz96Uv4XuRbLDDol7BAjOE=; b=uDQeJHBNuxyIo1bDqTBKIm+eV9I5LtsZcrl24lu7FwLe/b1D4wNVjTKW/byXeJ3+kleDHqrap/Nvn4gXxG0eQou5/19SnfD1T3fQ8uWE3JDc3U8EfKIDWGzMuwkLfk2IA2lRwflTacKWNfRCbsaUQ3fd0OhEgiDZF0487LoNtgA= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich Subject: Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug Thread-Topic: [PATCH v3 3/3] xen/sched: fix cpu hotplug Thread-Index: AQHYsVjUGULgew6mPUO+TQcIZn3wJK3JthgAgAB6fQCAAGG9gA== Date: Thu, 1 Sep 2022 12:01:04 +0000 Message-ID: References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-4-jgross@suse.com> <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> <94576d45-39c2-a786-2fe2-5effb16caf68@suse.com> In-Reply-To: <94576d45-39c2-a786-2fe2-5effb16caf68@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 52858ee0-d662-4169-3572-08da8c11a57f x-ms-traffictypediagnostic: DM6PR03MB4921:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xs9siveC6n2oQTco/RAbk3n/+D2x53ymd05kTWNkZyRkVRAF/OpcDRNeGb/P6uNEjQM62S1aYQmhH0fOU8pmnwJcf5eolcFLAs7OHVQWUawuV8mj8hxJHXxaF98o/8EfvzYZuaVUMpPn1mJ3KZftPEtzIkriDkuuBt8EjkcjlMqR5YfvXdA7iVkoH9dzGcBfR8w45zNy1tErYqTXI6lQSSi49TU1QovMHIIChJF0xbsRGNA/EzG21tEIGOIA+f+ugZqveDaPKyagI2n5mX8j7j9+3bjn0xgXcuHDqkj5/Zr5Z4S2EhL7MYYRKsy+UJ7ab5aU3agQwZu5mNMxiSuqo7OlQZgLdJ+TGnWU/EwGPSa7/CE8fI41S7sJgIt/796FlefL1tZllMDMt0hlELpCpXFMGkj24Aeev33QnhfHhMSBc8W4MX/Lfn1x+1Bld5BdA6x/sfftbXnHBvwUKcs5ZHpEUjEjMVQNlVxCdUCpL0PGyvQ9Rl7fwA3hSIoRw0lXX3lgs5YwEWaiXA3iPOvaaCj5dDEebMn2p0tIhKjJfRwnrq3gJrBHbJdtZjaJoUn1sLxHhknqHlKFaaBuzZCnGmLaed3qdOiBNV9aYAdJJElm56//Ku3oQmfUAQBdggs/i0qo34TqE8MANib3a8zHPK5nuoxbpBul/xuOKqNP1brsRwGw08iBDK/8ov+FYUo+6uckP7li8Y6n4kZRotWUMpbnTkYAbYp0gW7ors8g2mudztQ6OCAWni+rE6R4eGfELQH6DfxL2IQw9icOvfM05CsYShwx/n6zH6JWR9GYJh59Uccwd15zbeVzBukThT80CUTWzY3GFTXY6XHTGnsRIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(31696002)(2906002)(316002)(53546011)(86362001)(6506007)(83380400001)(71200400001)(110136005)(54906003)(8936002)(38070700005)(8676002)(82960400001)(76116006)(4326008)(6512007)(122000001)(66556008)(66476007)(91956017)(41300700001)(6486002)(186003)(26005)(38100700002)(31686004)(36756003)(5660300002)(66446008)(66946007)(64756008)(2616005)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OHdFN2RtN2VKdngvMUNsZmtZdDkxa3BYTXVUTjFZd0tsRUw0NEV6TUpkY0Zu?= =?utf-8?B?T3pMUnZRVjk3UHMzd2ttdTd6R283L2E4Tkd2UG5qazhtaXk5cXpDajQzVHZJ?= =?utf-8?B?ODExY3lzSmlhMEllbUljQXVXNnR0d1FGanNZSEtpczlmSTdaMDlQV3ZLNHY1?= =?utf-8?B?TTVuR3ltRUV1NUVRamlVQmNyazNEcWhrWWFoT3dqL240Ni85akEyc0ZsU1Nz?= =?utf-8?B?NHFRWG1GZTcySmxlZE50UjlSdGhYKzhObWowemxQZlZHOU5yd2tBU09GbTBU?= =?utf-8?B?ZytKOWlIVnRmN2ZTd1RNd1dxSGMvcE41NDEzZTEvbUVhbnBKUW54M2Fjd2ZK?= =?utf-8?B?NUFFeWtBeURnZHh6ZTBUU3lLTStPSEsxQlhKaFg0dmNDdHhEbzNMNjg3OFl6?= =?utf-8?B?ekw3YnN6a2pQRWY5THpvZGZtWjU0VzQ2R1ViTWFOd3NXSHN0RWNZWnFuNDl6?= =?utf-8?B?Y0YxeUVkdXhTakxKNmVrcm1OaXhzeVIra0h6bGRsZm84aXNqTm8rZ2owNm1C?= =?utf-8?B?eC9URkhQVFF1QjdnaDJXSU1EYWdTYnZkZGxJQkR6QzR3UnhaZTkwVUJWdEVs?= =?utf-8?B?d1JVWmJzNnUxU2dVaEtCMTB3MXhPMVZsdDRWeFdDVy9rRVhoMi9sZ3lTYzRs?= =?utf-8?B?RnZEdHFITERsTHdVOXN6SEhUMkdjWXBHK3o0N3NRN2R6K0FpS0grNTNHWW92?= =?utf-8?B?WmZMcFlRaW9wN21Nb2xodHFRRkRyQWwybUlUM1NNOSt4QnNKeGNUWFR2d0Zp?= =?utf-8?B?MVRiaEpUeXVvbDYrdTkvWDJZTzBQU3dENHFkMlRMaVViTU43Zk9vaGlxeDhO?= =?utf-8?B?d0RHQTJLeDJaNWZTMnV0Q0ZsY0tvSDBmSzVJNGhmUGQ4V0c0ZWJhTFcrczFy?= =?utf-8?B?VnNxTzRGNzk5NzR0TzhEUGxIVVl6aklFSzlnSnB0NFp2aTU4SGtyQ1RuNzIr?= =?utf-8?B?UkNkVXV0MUxiNnZiVEFiTndMSkM4RkVPZGVudmpNOVA2OStzejNONVRCMnRV?= =?utf-8?B?NEtmRlVvZjBvc1ZTck5BQjRJMEt5WHY1cndEdExpYzNJUnlydXhjWmdkM2I0?= =?utf-8?B?ZEdUSDF0ZWNBU1QwbHRpU2RJL3hOQWNIT204VGVKRUFLZzNKbjdYUjR6QWl3?= =?utf-8?B?NW44WnlOK2FxWGFOMGxXTmd1SFQvUnVnUGNSY2dJK2IxdUdYZWREVExGcElH?= =?utf-8?B?Z21OZUFzbUdEa2dXQjI2aGRTdU1tOVhnVm9oUCs1U1dMdTMyVGJGdityeTNw?= =?utf-8?B?MHhtblNCN2tXQytwVm53amVwenFzQ1BrSTRWZHlhSlFOdTh4S1YxWHZ6eUkr?= =?utf-8?B?ZDlWNnNvSlR6NHd0TjBmMVZjVjlPV2R5aWVZd1FaY2V3U0pQOG91M2ZDVi9j?= =?utf-8?B?bUNacmt2Q2Q5dG9ka0p6ZUN5a3JTZ1FEaDNXdE9GUWdUczZFdHNMYVNXakk1?= =?utf-8?B?Q1VDODYzNXNFRWYyZHJBMXJ2UnNiakU1WmQxakRrMkNlK1RxRzhWa2QxZy9k?= =?utf-8?B?Q0JsVmcveXU3NXVSNitrNTJzWVlCOGFZSHorM2tjditSanVEMm1YVms0anFD?= =?utf-8?B?NVlxZjRTVFYwcis3QTMvV21sQ3lhc1pFUzQ5MHJOa0tTY25JejN0WDViOEF4?= =?utf-8?B?WFdmcDlwbkY1SVg1MG92S3Ira0lBYWJXNktjc0N6QUdkb1hSaXNvK200cEx3?= =?utf-8?B?M0FNQnJiTHQvMjhMZTVKYUlSdjZJVlNkZjc3WEMzZ1BKQVpmdzRJaG1yUys2?= =?utf-8?B?R09WWVhzZGtYWXFHc0lNdkFkcXhhbUtGNEJHem1QM09VYll1bDI3SGJIdzFu?= =?utf-8?B?UUJVRUpCOGVsOUZ2VE5wcFRGRWcyVE9zdVBKYURUd0FzRnVhbFNVaGVjUkZ5?= =?utf-8?B?enE4aDJTTXBnTXc5TVgrTzVGQzhTYkZ4Nm9FNjE0UGdkclJHVXJBRGUwZnVI?= =?utf-8?B?Y0R2WUtqRCszQkt5NjlVSVhUU2RmbERtaGJhTlZjMTdYK2daSHVMa3Brc3pJ?= =?utf-8?B?aTJmZ0psRUgxalk4TlcwdjYyRGhULzI3cENBM0pkZ3VZQmRhTU4vZDBKRUdC?= =?utf-8?B?NHZmN0s4RXdTZzc4dUpMaEhnUy9yVU1kNm5kWjY1ZVEvcStTMUh3N1QySGNW?= =?utf-8?Q?zHZEodhpaWA6MO412lHr1YLL5?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52858ee0-d662-4169-3572-08da8c11a57f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 12:01:04.4631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3LVqRIMXNgzPMjsbw0a86NKNLdUBXZLcrGG9Tqe6W5OwzMISe3m1E+g7m0ZXA8ZW/71wEIuJFcFmtHWOWotIDT5b8wTJUvi6EXFxAgkcKJU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4921 T24gMDEvMDkvMjAyMiAwNzoxMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMDEuMDkuMjIg MDA6NTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNi8wOC8yMDIyIDExOjEzLCBKdWVy Z2VuIEdyb3NzIHdyb3RlOg0KPj4+IENwdSBjcHUgdW5wbHVnZ2luZyBpcyBjYWxsaW5nIHNjaGVk dWxlX2NwdV9ybSgpIHZpYSBzdG9wX21hY2hpbmVfcnVuKCkNCj4+DQo+PiBDcHUgY3B1Lg0KPj4N Cj4+PiB3aXRoIGludGVycnVwdHMgZGlzYWJsZWQsIHRodXMgYW55IG1lbW9yeSBhbGxvY2F0aW9u IG9yIGZyZWVpbmcgbXVzdA0KPj4+IGJlIGF2b2lkZWQuDQo+Pj4NCj4+PiBTaW5jZSBjb21taXQg NTA0N2NkMWQ1ZGVhICgieGVuL2NvbW1vbjogVXNlIGVuaGFuY2VkDQo+Pj4gQVNTRVJUX0FMTE9D X0NPTlRFWFQgaW4geG1hbGxvYygpIikgdGhpcyByZXN0cmljdGlvbiBpcyBiZWluZyBlbmZvcmNl ZA0KPj4+IHZpYSBhbiBhc3NlcnRpb24sIHdoaWNoIHdpbGwgbm93IGZhaWwuDQo+Pj4NCj4+PiBC ZWZvcmUgdGhhdCBjb21taXQgY3B1IHVucGx1Z2dpbmcgaW4gbm9ybWFsIGNvbmZpZ3VyYXRpb25z IHdhcyB3b3JraW5nDQo+Pj4ganVzdCBieSBjaGFuY2UgYXMgb25seSB0aGUgY3B1IHBlcmZvcm1p bmcgc2NoZWR1bGVfY3B1X3JtKCkgd2FzIGRvaW5nDQo+Pj4gYWN0aXZlIHdvcmsuIFdpdGggY29y ZSBzY2hlZHVsaW5nIGVuYWJsZWQsIGhvd2V2ZXIsIGZhaWx1cmVzIGNvdWxkDQo+Pj4gcmVzdWx0 IGZyb20gbWVtb3J5IGFsbG9jYXRpb25zIG5vdCBiZWluZyBwcm9wZXJseSBwcm9wYWdhdGVkIHRv IG90aGVyDQo+Pj4gY3B1cycgVExCcy4NCj4+DQo+PiBUaGlzIGlzbid0IGFjY3VyYXRlLCBpcyBp dD/CoCBUaGUgcHJvYmxlbSB3aXRoIGluaXRpYXRpbmcgYSBUTEIgZmx1c2gNCj4+IHdpdGggSVJR cyBkaXNhYmxlZCBpcyB0aGF0IHlvdSBjYW4gZGVhZGxvY2sgYWdhaW5zdCBhIHJlbW90ZSBDUFUg d2hpY2gNCj4+IGlzIHdhaXRpbmcgZm9yIHlvdSB0byBlbmFibGUgSVJRcyBmaXJzdCB0byB0YWtl IGEgVExCIGZsdXNoIElQSS4NCj4NCj4gQXMgbG9uZyBhcyBvbmx5IG9uZSBjcHUgaXMgdHJ5aW5n IHRvIGFsbG9jYXRlL2ZyZWUgbWVtb3J5IGR1cmluZyB0aGUNCj4gc3RvcF9tYWNoaW5lX3J1bigp IGFjdGlvbiB0aGUgZGVhZGxvY2sgd29uJ3QgaGFwcGVuLg0KPg0KPj4gSG93IGRvZXMgYSBtZW1v cnkgYWxsb2NhdGlvbiBvdXQgb2YgdGhlIHhlbmhlYXAgcmVzdWx0IGluIGEgVExCIGZsdXNoPw0K Pj4gRXZlbiB3aXRoIHNwbGl0IGhlYXBzLCB5b3UncmUgb25seSBwb3RlbnRpYWxseSBhbGxvY2F0 aW5nIGludG8gYSBuZXcNCj4+IHNsb3Qgd2hpY2ggd2FzIHVudXNlZC4uLg0KPg0KPiBZZWFoLCB5 b3UgYXJlIHJpZ2h0LiBUaGUgbWFpbiBwcm9ibGVtIHdvdWxkIG9jY3VyIG9ubHkgd2hlbiBhIHZp cnR1YWwNCj4gYWRkcmVzcyBpcyBjaGFuZ2VkIHRvIHBvaW50IGF0IGFub3RoZXIgcGh5c2ljYWwg YWRkcmVzcywgd2hpY2ggc2hvdWxkIGJlDQo+IHF1aXRlIHVubGlrZWx5Lg0KPg0KPiBJIGNhbiBk cm9wIHRoYXQgcGFyYWdyYXBoLCBhcyBpdCBkb2Vzbid0IHJlYWxseSBoZWxwLg0KDQpZZWFoLCBJ IHRoaW5rIHRoYXQgd291bGQgYmUgYmVzdC4NCg0KPj4NCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2Nv bW1vbi9zY2hlZC9jcHVwb29sLmMgYi94ZW4vY29tbW9uL3NjaGVkL2NwdXBvb2wuYw0KPj4+IGlu ZGV4IDU4ZTA4MmViNGMuLjI1MDY4NjFlNGYgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2NvbW1vbi9z Y2hlZC9jcHVwb29sLmMNCj4+PiArKysgYi94ZW4vY29tbW9uL3NjaGVkL2NwdXBvb2wuYw0KPj4+ IEBAIC00MTEsMjIgKzQxMSwyOCBAQCBpbnQgY3B1cG9vbF9tb3ZlX2RvbWFpbihzdHJ1Y3QgZG9t YWluICpkLA0KPj4+IHN0cnVjdCBjcHVwb29sICpjKQ0KPj4+IMKgIH0NCj4+PiDCoCDCoCAvKiBV cGRhdGUgYWZmaW5pdGllcyBvZiBhbGwgZG9tYWlucyBpbiBhIGNwdXBvb2wuICovDQo+Pj4gLXN0 YXRpYyB2b2lkIGNwdXBvb2xfdXBkYXRlX25vZGVfYWZmaW5pdHkoY29uc3Qgc3RydWN0IGNwdXBv b2wgKmMpDQo+Pj4gK3N0YXRpYyB2b2lkIGNwdXBvb2xfdXBkYXRlX25vZGVfYWZmaW5pdHkoY29u c3Qgc3RydWN0IGNwdXBvb2wgKmMsDQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVj dCBhZmZpbml0eV9tYXNrcyAqbWFza3MpDQo+Pj4gwqAgew0KPj4+IC3CoMKgwqAgc3RydWN0IGFm ZmluaXR5X21hc2tzIG1hc2tzOw0KPj4+ICvCoMKgwqAgc3RydWN0IGFmZmluaXR5X21hc2tzIGxv Y2FsX21hc2tzOw0KPj4+IMKgwqDCoMKgwqAgc3RydWN0IGRvbWFpbiAqZDsNCj4+PiDCoCAtwqDC oMKgIGlmICggIXVwZGF0ZV9ub2RlX2FmZl9hbGxvYygmbWFza3MpICkNCj4+PiAtwqDCoMKgwqDC oMKgwqAgcmV0dXJuOw0KPj4+ICvCoMKgwqAgaWYgKCAhbWFza3MgKQ0KPj4+ICvCoMKgwqAgew0K Pj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoICF1cGRhdGVfbm9kZV9hZmZfYWxsb2MoJmxvY2FsX21h c2tzKSApDQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuOw0KPj4+ICvCoMKgwqDC oMKgwqDCoCBtYXNrcyA9ICZsb2NhbF9tYXNrczsNCj4+PiArwqDCoMKgIH0NCj4+PiDCoCDCoMKg wqDCoMKgIHJjdV9yZWFkX2xvY2soJmRvbWxpc3RfcmVhZF9sb2NrKTsNCj4+PiDCoCDCoMKgwqDC oMKgIGZvcl9lYWNoX2RvbWFpbl9pbl9jcHVwb29sKGQsIGMpDQo+Pj4gLcKgwqDCoMKgwqDCoMKg IGRvbWFpbl91cGRhdGVfbm9kZV9hZmYoZCwgJm1hc2tzKTsNCj4+PiArwqDCoMKgwqDCoMKgwqAg ZG9tYWluX3VwZGF0ZV9ub2RlX2FmZihkLCBtYXNrcyk7DQo+Pj4gwqAgwqDCoMKgwqDCoCByY3Vf cmVhZF91bmxvY2soJmRvbWxpc3RfcmVhZF9sb2NrKTsNCj4+PiDCoCAtwqDCoMKgIHVwZGF0ZV9u b2RlX2FmZl9mcmVlKCZtYXNrcyk7DQo+Pj4gK8KgwqDCoCBpZiAoIG1hc2tzID09ICZsb2NhbF9t YXNrcyApDQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHVwZGF0ZV9ub2RlX2FmZl9mcmVlKG1hc2tzKTsN Cj4+PiDCoCB9DQo+Pj4gwqAgwqAgLyoNCj4+DQo+PiBXaHkgZG8gd2UgbmVlZCB0aGlzIGF0IGFs bD/CoCBkb21haW5fdXBkYXRlX25vZGVfYWZmKCkgYWxyZWFkeSBrbm93cyB3aGF0DQo+PiB0byBk byB3aGVuIHBhc3NlZCBOVUxMLCBzbyB0aGlzIHNlZW1zIGxpa2UgYW4gYXdmdWxseSBjb21wbGlj YXRlZCBuby1vcC4NCj4NCj4gWW91IGRvIHJlYWxpemUgdGhhdCB1cGRhdGVfbm9kZV9hZmZfZnJl ZSgpIHdpbGwgZG8gc29tZXRoaW5nIGluIGNhc2UNCj4gbWFza3MNCj4gd2FzIGluaXRpYWxseSBO VUxMPw0KDQpCeSAidGhpcyIsIEkgbWVhbnQgdGhlIGVudGlyZSBodW5rLCBub3QganVzdCB0aGUg ZmluYWwgaWYoKS4NCg0KV2hhdCBpcyB3cm9uZyB3aXRoIHBhc3NpbmcgdGhlIChwb3NzaWJseSBO VUxMKSBtYXNrcyBwb2ludGVyIHN0cmFpZ2h0DQpkb3duIGludG8gZG9tYWluX3VwZGF0ZV9ub2Rl X2FmZigpIGFuZCByZW1vdmluZyBhbGwgdGhlIG1lbW9yeQ0KYWxsb2NhdGlvbiBpbiB0aGlzIGZ1 bmN0aW9uPw0KDQpCdXQgSSd2ZSBhbHNvIGFuc3dlcmVkIHRoYXQgYnkgbG9va2luZyBtb3JlIGNs ZWFybHkuwqAgSXQncyBhYm91dCBub3QNCnJlcGVhdGluZyB0aGUgbWVtb3J5IGFsbG9jYXRpb25z L2ZyZWVpbmcgZm9yIGVhY2ggZG9tYWluIGluIHRoZSBwb29sLsKgDQpXaGljaCBkb2VzIG1ha2Ug c2Vuc2UgYXMgdGhpcyBpcyBhIHNsb3cgcGF0aCBhbHJlYWR5LCBidXQgdGhlIGNvbXBsZXhpdHkN CmhlcmUgb2YgaGF2aW5nIGNvbmRpdGlvbmFsbHkgYWxsb2NhdGVkIG1hc2tzIGlzIGZhciBmcm9t IHNpbXBsZS4NCg0KPg0KPj4NCj4+PiBAQCAtMTAwOCwxMCArMTAxNiwyMSBAQCBzdGF0aWMgaW50 IGNmX2NoZWNrIGNwdV9jYWxsYmFjaygNCj4+PiDCoCB7DQo+Pj4gwqDCoMKgwqDCoCB1bnNpZ25l ZCBpbnQgY3B1ID0gKHVuc2lnbmVkIGxvbmcpaGNwdTsNCj4+PiDCoMKgwqDCoMKgIGludCByYyA9 IDA7DQo+Pj4gK8KgwqDCoCBzdGF0aWMgc3RydWN0IGNwdV9ybV9kYXRhICptZW07DQo+Pj4gwqAg wqDCoMKgwqDCoCBzd2l0Y2ggKCBhY3Rpb24gKQ0KPj4+IMKgwqDCoMKgwqAgew0KPj4+IMKgwqDC oMKgwqAgY2FzZSBDUFVfRE9XTl9GQUlMRUQ6DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICggc3lz dGVtX3N0YXRlIDw9IFNZU19TVEFURV9hY3RpdmUgKQ0KPj4+ICvCoMKgwqDCoMKgwqDCoCB7DQo+ Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKCBtZW0gKQ0KPj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHsNCj4+DQo+PiBTbywgdGhpcyBkb2VzIGNvbXBpbGUgKGFuZCBpbmRlZWQgSSd2 ZSB0ZXN0ZWQgdGhlIHJlc3VsdCksIGJ1dCBJIGNhbid0DQo+PiBzZWUgaG93IGl0IHNob3VsZC4N Cj4+DQo+PiBtZW0gaXMgZ3VhcmFudGVlZCB0byBiZSB1bmluaXRpYWxpc2VkIGF0IHRoaXMgcG9p bnQsIGFuZCAuLi4NCj4NCj4gLi4uIGl0IGlzIGRlZmluZWQgYXMgInN0YXRpYyIsIHNvIGl0IGlz IGNsZWFybHkgTlVMTCBpbml0aWFsbHkuDQoNCk9oLCBzbyBpdCBpcy7CoCBUaGF0IGlzIGhpZGlu ZyBwYXJ0aWN1bGFybHkgd2VsbCBpbiBwbGFpbiBzaWdodC4NCg0KQ2FuIGl0IHBsZWFzZSBiZSB0 aGlzOg0KDQpAQCAtMTAxNCw5ICsxMDE0LDEwIEBAIHZvaWQgY2ZfY2hlY2sgZHVtcF9ydW5xKHVu c2lnbmVkIGNoYXIga2V5KQ0KwqBzdGF0aWMgaW50IGNmX2NoZWNrIGNwdV9jYWxsYmFjaygNCsKg wqDCoMKgIHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmZiLCB1bnNpZ25lZCBsb25nIGFjdGlvbiwg dm9pZCAqaGNwdSkNCsKgew0KK8KgwqDCoCBzdGF0aWMgc3RydWN0IGNwdV9ybV9kYXRhICptZW07 IC8qIFByb3RlY3RlZCBieSBjcHVfYWRkX3JlbW92ZV9sb2NrICovDQorDQrCoMKgwqDCoCB1bnNp Z25lZCBpbnQgY3B1ID0gKHVuc2lnbmVkIGxvbmcpaGNwdTsNCsKgwqDCoMKgIGludCByYyA9IDA7 DQotwqDCoMKgIHN0YXRpYyBzdHJ1Y3QgY3B1X3JtX2RhdGEgKm1lbTsNCsKgDQrCoMKgwqDCoCBz d2l0Y2ggKCBhY3Rpb24gKQ0KwqDCoMKgwqAgew0KDQpXZSBhbHJlYWR5IHNwbGl0IHN0YXRpYyBh bmQgbm9uLXN0YXRpYyB2YXJpYWJsZSBsaWtlIHRoaXMgZWxzZXdoZXJlIGZvcg0KY2xhcml0eSwg YW5kIGlkZW50aWZ5aW5nIHRoZSBsb2NrIHdoaWNoIHByb3RlY3RzIHRoZSBkYXRhIGlzIHVzZWZ1 bCBmb3INCmFueW9uZSBjb21pbmcgdG8gdGhpcyBpbiB0aGUgZnV0dXJlLg0KDQp+QW5kcmV3DQoN ClAuUy4gYXMgYW4gb2JzZXJ2YXRpb24sIHRoaXMgaXNuJ3Qgc2FmZSBmb3IgcGFyYWxsZWwgQVAg Ym9vdGluZywgYnV0IEkNCmd1YXJhbnRlZSB0aGF0IHRoaXMgaXNuJ3QgdGhlIG9ubHkgZXhhbXBs ZSB3aGljaCB3b3VsZCB3YW50IGZpeGluZyBpZiB3ZQ0Kd2FudGVkIHRvIGdldCBwYXJhbGxlbCBi b290aW5nIHdvcmtpbmcuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:08:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396553.636726 (Exim 4.92) (envelope-from ) id 1oTj0A-0000DU-1r; Thu, 01 Sep 2022 12:08:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396553.636726; Thu, 01 Sep 2022 12:08:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTj09-0000DN-VT; Thu, 01 Sep 2022 12:08:53 +0000 Received: by outflank-mailman (input) for mailman id 396553; Thu, 01 Sep 2022 12:08:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTj08-0000DG-RJ for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 12:08:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7543564-29ee-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 14:08:51 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A5EDB20004; Thu, 1 Sep 2022 12:08:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 74C4413A89; Thu, 1 Sep 2022 12:08:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eokKG9KgEGPNGQAAMHmgww (envelope-from ); Thu, 01 Sep 2022 12:08:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7543564-29ee-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662034130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=prycf6zC67ozZ9bWudK9unqfbehibITR9GfuLn6I+2A=; b=d0K3a6YtIPts7YhNhf6ybBIM7UwzOJwSUfn2kXnOrF/wQqvktfcuoBdZzrElYVyy1noCSq c5yMhuKsr1q3EZGb0qKnusm0K79vD+KwtoREB3jueDrx9YkJ5D9TC6eL0kKHm8NKE/0wm3 TcTKQMrkLOnoiPUoGoSRj/bgn1hBp14= Message-ID: <7ca10578-6c35-1abf-c418-8abd16cd47b5@suse.com> Date: Thu, 1 Sep 2022 14:08:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-4-jgross@suse.com> <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> <94576d45-39c2-a786-2fe2-5effb16caf68@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mFxDfl940PuNXjVwa6wL9dk9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mFxDfl940PuNXjVwa6wL9dk9 Content-Type: multipart/mixed; boundary="------------bYWa1wLlSWqaGLEKJEsjca8o"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich Message-ID: <7ca10578-6c35-1abf-c418-8abd16cd47b5@suse.com> Subject: Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug References: <20220816101317.23014-1-jgross@suse.com> <20220816101317.23014-4-jgross@suse.com> <096ed545-f268-ba45-6333-ed51d20fc99c@citrix.com> <94576d45-39c2-a786-2fe2-5effb16caf68@suse.com> In-Reply-To: --------------bYWa1wLlSWqaGLEKJEsjca8o Content-Type: multipart/mixed; boundary="------------BYtSIJBeJNOyztIl4skt6uh0" --------------BYtSIJBeJNOyztIl4skt6uh0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDkuMjIgMTQ6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDAxLzA5LzIw MjIgMDc6MTEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBPbiAwMS4wOS4yMiAwMDo1Miwg QW5kcmV3IENvb3BlciB3cm90ZToNCj4+PiBPbiAxNi8wOC8yMDIyIDExOjEzLCBKdWVyZ2Vu IEdyb3NzIHdyb3RlOg0KPj4+PiBDcHUgY3B1IHVucGx1Z2dpbmcgaXMgY2FsbGluZyBzY2hl ZHVsZV9jcHVfcm0oKSB2aWEgc3RvcF9tYWNoaW5lX3J1bigpDQo+Pj4NCj4+PiBDcHUgY3B1 Lg0KPj4+DQo+Pj4+IHdpdGggaW50ZXJydXB0cyBkaXNhYmxlZCwgdGh1cyBhbnkgbWVtb3J5 IGFsbG9jYXRpb24gb3IgZnJlZWluZyBtdXN0DQo+Pj4+IGJlIGF2b2lkZWQuDQo+Pj4+DQo+ Pj4+IFNpbmNlIGNvbW1pdCA1MDQ3Y2QxZDVkZWEgKCJ4ZW4vY29tbW9uOiBVc2UgZW5oYW5j ZWQNCj4+Pj4gQVNTRVJUX0FMTE9DX0NPTlRFWFQgaW4geG1hbGxvYygpIikgdGhpcyByZXN0 cmljdGlvbiBpcyBiZWluZyBlbmZvcmNlZA0KPj4+PiB2aWEgYW4gYXNzZXJ0aW9uLCB3aGlj aCB3aWxsIG5vdyBmYWlsLg0KPj4+Pg0KPj4+PiBCZWZvcmUgdGhhdCBjb21taXQgY3B1IHVu cGx1Z2dpbmcgaW4gbm9ybWFsIGNvbmZpZ3VyYXRpb25zIHdhcyB3b3JraW5nDQo+Pj4+IGp1 c3QgYnkgY2hhbmNlIGFzIG9ubHkgdGhlIGNwdSBwZXJmb3JtaW5nIHNjaGVkdWxlX2NwdV9y bSgpIHdhcyBkb2luZw0KPj4+PiBhY3RpdmUgd29yay4gV2l0aCBjb3JlIHNjaGVkdWxpbmcg ZW5hYmxlZCwgaG93ZXZlciwgZmFpbHVyZXMgY291bGQNCj4+Pj4gcmVzdWx0IGZyb20gbWVt b3J5IGFsbG9jYXRpb25zIG5vdCBiZWluZyBwcm9wZXJseSBwcm9wYWdhdGVkIHRvIG90aGVy DQo+Pj4+IGNwdXMnIFRMQnMuDQo+Pj4NCj4+PiBUaGlzIGlzbid0IGFjY3VyYXRlLCBpcyBp dD/CoCBUaGUgcHJvYmxlbSB3aXRoIGluaXRpYXRpbmcgYSBUTEIgZmx1c2gNCj4+PiB3aXRo IElSUXMgZGlzYWJsZWQgaXMgdGhhdCB5b3UgY2FuIGRlYWRsb2NrIGFnYWluc3QgYSByZW1v dGUgQ1BVIHdoaWNoDQo+Pj4gaXMgd2FpdGluZyBmb3IgeW91IHRvIGVuYWJsZSBJUlFzIGZp cnN0IHRvIHRha2UgYSBUTEIgZmx1c2ggSVBJLg0KPj4NCj4+IEFzIGxvbmcgYXMgb25seSBv bmUgY3B1IGlzIHRyeWluZyB0byBhbGxvY2F0ZS9mcmVlIG1lbW9yeSBkdXJpbmcgdGhlDQo+ PiBzdG9wX21hY2hpbmVfcnVuKCkgYWN0aW9uIHRoZSBkZWFkbG9jayB3b24ndCBoYXBwZW4u DQo+Pg0KPj4+IEhvdyBkb2VzIGEgbWVtb3J5IGFsbG9jYXRpb24gb3V0IG9mIHRoZSB4ZW5o ZWFwIHJlc3VsdCBpbiBhIFRMQiBmbHVzaD8NCj4+PiBFdmVuIHdpdGggc3BsaXQgaGVhcHMs IHlvdSdyZSBvbmx5IHBvdGVudGlhbGx5IGFsbG9jYXRpbmcgaW50byBhIG5ldw0KPj4+IHNs b3Qgd2hpY2ggd2FzIHVudXNlZC4uLg0KPj4NCj4+IFllYWgsIHlvdSBhcmUgcmlnaHQuIFRo ZSBtYWluIHByb2JsZW0gd291bGQgb2NjdXIgb25seSB3aGVuIGEgdmlydHVhbA0KPj4gYWRk cmVzcyBpcyBjaGFuZ2VkIHRvIHBvaW50IGF0IGFub3RoZXIgcGh5c2ljYWwgYWRkcmVzcywg d2hpY2ggc2hvdWxkIGJlDQo+PiBxdWl0ZSB1bmxpa2VseS4NCj4+DQo+PiBJIGNhbiBkcm9w IHRoYXQgcGFyYWdyYXBoLCBhcyBpdCBkb2Vzbid0IHJlYWxseSBoZWxwLg0KPiANCj4gWWVh aCwgSSB0aGluayB0aGF0IHdvdWxkIGJlIGJlc3QuDQo+IA0KPj4+DQo+Pj4+IGRpZmYgLS1n aXQgYS94ZW4vY29tbW9uL3NjaGVkL2NwdXBvb2wuYyBiL3hlbi9jb21tb24vc2NoZWQvY3B1 cG9vbC5jDQo+Pj4+IGluZGV4IDU4ZTA4MmViNGMuLjI1MDY4NjFlNGYgMTAwNjQ0DQo+Pj4+ IC0tLSBhL3hlbi9jb21tb24vc2NoZWQvY3B1cG9vbC5jDQo+Pj4+ICsrKyBiL3hlbi9jb21t b24vc2NoZWQvY3B1cG9vbC5jDQo+Pj4+IEBAIC00MTEsMjIgKzQxMSwyOCBAQCBpbnQgY3B1 cG9vbF9tb3ZlX2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkLA0KPj4+PiBzdHJ1Y3QgY3B1cG9v bCAqYykNCj4+Pj4gIMKgIH0NCj4+Pj4gIMKgIMKgIC8qIFVwZGF0ZSBhZmZpbml0aWVzIG9m IGFsbCBkb21haW5zIGluIGEgY3B1cG9vbC4gKi8NCj4+Pj4gLXN0YXRpYyB2b2lkIGNwdXBv b2xfdXBkYXRlX25vZGVfYWZmaW5pdHkoY29uc3Qgc3RydWN0IGNwdXBvb2wgKmMpDQo+Pj4+ ICtzdGF0aWMgdm9pZCBjcHVwb29sX3VwZGF0ZV9ub2RlX2FmZmluaXR5KGNvbnN0IHN0cnVj dCBjcHVwb29sICpjLA0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0 IGFmZmluaXR5X21hc2tzICptYXNrcykNCj4+Pj4gIMKgIHsNCj4+Pj4gLcKgwqDCoCBzdHJ1 Y3QgYWZmaW5pdHlfbWFza3MgbWFza3M7DQo+Pj4+ICvCoMKgwqAgc3RydWN0IGFmZmluaXR5 X21hc2tzIGxvY2FsX21hc2tzOw0KPj4+PiAgwqDCoMKgwqDCoCBzdHJ1Y3QgZG9tYWluICpk Ow0KPj4+PiAgwqAgLcKgwqDCoCBpZiAoICF1cGRhdGVfbm9kZV9hZmZfYWxsb2MoJm1hc2tz KSApDQo+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm47DQo+Pj4+ICvCoMKgwqAgaWYgKCAh bWFza3MgKQ0KPj4+PiArwqDCoMKgIHsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICggIXVw ZGF0ZV9ub2RlX2FmZl9hbGxvYygmbG9jYWxfbWFza3MpICkNCj4+Pj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqAgcmV0dXJuOw0KPj4+PiArwqDCoMKgwqDCoMKgwqAgbWFza3MgPSAmbG9j YWxfbWFza3M7DQo+Pj4+ICvCoMKgwqAgfQ0KPj4+PiAgwqAgwqDCoMKgwqDCoCByY3VfcmVh ZF9sb2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+Pj4+ICDCoCDCoMKgwqDCoMKgIGZvcl9l YWNoX2RvbWFpbl9pbl9jcHVwb29sKGQsIGMpDQo+Pj4+IC3CoMKgwqDCoMKgwqDCoCBkb21h aW5fdXBkYXRlX25vZGVfYWZmKGQsICZtYXNrcyk7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBk b21haW5fdXBkYXRlX25vZGVfYWZmKGQsIG1hc2tzKTsNCj4+Pj4gIMKgIMKgwqDCoMKgwqAg cmN1X3JlYWRfdW5sb2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+Pj4+ICDCoCAtwqDCoMKg IHVwZGF0ZV9ub2RlX2FmZl9mcmVlKCZtYXNrcyk7DQo+Pj4+ICvCoMKgwqAgaWYgKCBtYXNr cyA9PSAmbG9jYWxfbWFza3MgKQ0KPj4+PiArwqDCoMKgwqDCoMKgwqAgdXBkYXRlX25vZGVf YWZmX2ZyZWUobWFza3MpOw0KPj4+PiAgwqAgfQ0KPj4+PiAgwqAgwqAgLyoNCj4+Pg0KPj4+ IFdoeSBkbyB3ZSBuZWVkIHRoaXMgYXQgYWxsP8KgIGRvbWFpbl91cGRhdGVfbm9kZV9hZmYo KSBhbHJlYWR5IGtub3dzIHdoYXQNCj4+PiB0byBkbyB3aGVuIHBhc3NlZCBOVUxMLCBzbyB0 aGlzIHNlZW1zIGxpa2UgYW4gYXdmdWxseSBjb21wbGljYXRlZCBuby1vcC4NCj4+DQo+PiBZ b3UgZG8gcmVhbGl6ZSB0aGF0IHVwZGF0ZV9ub2RlX2FmZl9mcmVlKCkgd2lsbCBkbyBzb21l dGhpbmcgaW4gY2FzZQ0KPj4gbWFza3MNCj4+IHdhcyBpbml0aWFsbHkgTlVMTD8NCj4gDQo+ IEJ5ICJ0aGlzIiwgSSBtZWFudCB0aGUgZW50aXJlIGh1bmssIG5vdCBqdXN0IHRoZSBmaW5h bCBpZigpLg0KPiANCj4gV2hhdCBpcyB3cm9uZyB3aXRoIHBhc3NpbmcgdGhlIChwb3NzaWJs eSBOVUxMKSBtYXNrcyBwb2ludGVyIHN0cmFpZ2h0DQo+IGRvd24gaW50byBkb21haW5fdXBk YXRlX25vZGVfYWZmKCkgYW5kIHJlbW92aW5nIGFsbCB0aGUgbWVtb3J5DQo+IGFsbG9jYXRp b24gaW4gdGhpcyBmdW5jdGlvbj8NCj4gDQo+IEJ1dCBJJ3ZlIGFsc28gYW5zd2VyZWQgdGhh dCBieSBsb29raW5nIG1vcmUgY2xlYXJseS7CoCBJdCdzIGFib3V0IG5vdA0KPiByZXBlYXRp bmcgdGhlIG1lbW9yeSBhbGxvY2F0aW9ucy9mcmVlaW5nIGZvciBlYWNoIGRvbWFpbiBpbiB0 aGUgcG9vbC4NCg0KQ29ycmVjdC4NCg0KPiBXaGljaCBkb2VzIG1ha2Ugc2Vuc2UgYXMgdGhp cyBpcyBhIHNsb3cgcGF0aCBhbHJlYWR5LCBidXQgdGhlIGNvbXBsZXhpdHkNCj4gaGVyZSBv ZiBoYXZpbmcgY29uZGl0aW9uYWxseSBhbGxvY2F0ZWQgbWFza3MgaXMgZmFyIGZyb20gc2lt cGxlLg0KPiANCj4+DQo+Pj4NCj4+Pj4gQEAgLTEwMDgsMTAgKzEwMTYsMjEgQEAgc3RhdGlj IGludCBjZl9jaGVjayBjcHVfY2FsbGJhY2soDQo+Pj4+ICDCoCB7DQo+Pj4+ICDCoMKgwqDC oMKgIHVuc2lnbmVkIGludCBjcHUgPSAodW5zaWduZWQgbG9uZyloY3B1Ow0KPj4+PiAgwqDC oMKgwqDCoCBpbnQgcmMgPSAwOw0KPj4+PiArwqDCoMKgIHN0YXRpYyBzdHJ1Y3QgY3B1X3Jt X2RhdGEgKm1lbTsNCj4+Pj4gIMKgIMKgwqDCoMKgwqAgc3dpdGNoICggYWN0aW9uICkNCj4+ Pj4gIMKgwqDCoMKgwqAgew0KPj4+PiAgwqDCoMKgwqDCoCBjYXNlIENQVV9ET1dOX0ZBSUxF RDoNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICggc3lzdGVtX3N0YXRlIDw9IFNZU19TVEFU RV9hY3RpdmUgKQ0KPj4+PiArwqDCoMKgwqDCoMKgwqAgew0KPj4+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBpZiAoIG1lbSApDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsN Cj4+Pg0KPj4+IFNvLCB0aGlzIGRvZXMgY29tcGlsZSAoYW5kIGluZGVlZCBJJ3ZlIHRlc3Rl ZCB0aGUgcmVzdWx0KSwgYnV0IEkgY2FuJ3QNCj4+PiBzZWUgaG93IGl0IHNob3VsZC4NCj4+ Pg0KPj4+IG1lbSBpcyBndWFyYW50ZWVkIHRvIGJlIHVuaW5pdGlhbGlzZWQgYXQgdGhpcyBw b2ludCwgYW5kIC4uLg0KPj4NCj4+IC4uLiBpdCBpcyBkZWZpbmVkIGFzICJzdGF0aWMiLCBz byBpdCBpcyBjbGVhcmx5IE5VTEwgaW5pdGlhbGx5Lg0KPiANCj4gT2gsIHNvIGl0IGlzLsKg IFRoYXQgaXMgaGlkaW5nIHBhcnRpY3VsYXJseSB3ZWxsIGluIHBsYWluIHNpZ2h0Lg0KPiAN Cj4gQ2FuIGl0IHBsZWFzZSBiZSB0aGlzOg0KPiANCj4gQEAgLTEwMTQsOSArMTAxNCwxMCBA QCB2b2lkIGNmX2NoZWNrIGR1bXBfcnVucSh1bnNpZ25lZCBjaGFyIGtleSkNCj4gIMKgc3Rh dGljIGludCBjZl9jaGVjayBjcHVfY2FsbGJhY2soDQo+ICDCoMKgwqDCoCBzdHJ1Y3Qgbm90 aWZpZXJfYmxvY2sgKm5mYiwgdW5zaWduZWQgbG9uZyBhY3Rpb24sIHZvaWQgKmhjcHUpDQo+ ICDCoHsNCj4gK8KgwqDCoCBzdGF0aWMgc3RydWN0IGNwdV9ybV9kYXRhICptZW07IC8qIFBy b3RlY3RlZCBieSBjcHVfYWRkX3JlbW92ZV9sb2NrICovDQo+ICsNCj4gIMKgwqDCoMKgIHVu c2lnbmVkIGludCBjcHUgPSAodW5zaWduZWQgbG9uZyloY3B1Ow0KPiAgwqDCoMKgwqAgaW50 IHJjID0gMDsNCj4gLcKgwqDCoCBzdGF0aWMgc3RydWN0IGNwdV9ybV9kYXRhICptZW07DQo+ ICAgDQo+ICDCoMKgwqDCoCBzd2l0Y2ggKCBhY3Rpb24gKQ0KPiAgwqDCoMKgwqAgew0KPiAN Cj4gV2UgYWxyZWFkeSBzcGxpdCBzdGF0aWMgYW5kIG5vbi1zdGF0aWMgdmFyaWFibGUgbGlr ZSB0aGlzIGVsc2V3aGVyZSBmb3INCj4gY2xhcml0eSwgYW5kIGlkZW50aWZ5aW5nIHRoZSBs b2NrIHdoaWNoIHByb3RlY3RzIHRoZSBkYXRhIGlzIHVzZWZ1bCBmb3INCj4gYW55b25lIGNv bWluZyB0byB0aGlzIGluIHRoZSBmdXR1cmUuDQoNCkZpbmUgd2l0aCBtZS4NCg0KPiANCj4g fkFuZHJldw0KPiANCj4gUC5TLiBhcyBhbiBvYnNlcnZhdGlvbiwgdGhpcyBpc24ndCBzYWZl IGZvciBwYXJhbGxlbCBBUCBib290aW5nLCBidXQgSQ0KPiBndWFyYW50ZWUgdGhhdCB0aGlz IGlzbid0IHRoZSBvbmx5IGV4YW1wbGUgd2hpY2ggd291bGQgd2FudCBmaXhpbmcgaWYgd2UN Cj4gd2FudGVkIHRvIGdldCBwYXJhbGxlbCBib290aW5nIHdvcmtpbmcuDQoNCllvdSBhcmUg YXdhcmUgdGhhdCBtZW0gaXMgdXNlZCBvbmx5IHdoZW4gcmVtb3ZpbmcgY3B1cz8NCg0KDQpK dWVyZ2VuDQo= --------------BYtSIJBeJNOyztIl4skt6uh0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BYtSIJBeJNOyztIl4skt6uh0-- --------------bYWa1wLlSWqaGLEKJEsjca8o-- --------------mFxDfl940PuNXjVwa6wL9dk9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMQoNIFAwAAAAAACgkQsN6d1ii/Ey+I mQf+O9DE/Epfkz23JZn1cKFYQWbCw2xDv5WjUB1WXlDv1Uk8LAqQhjqezr0t5Xl5M1+DAliossXk kb2KnUQRyizOfwrwXgunKL4EcBkrgri1BYyLSDiT+5lkraWpqSXhIr7i+WVVt/PGXTSD38kbPN0s rE7R1XFbMW+zmu/0wTZz0dJIukPwPquo9J8pmmGDM5lfdXIoO8N1hBMchPN/09wlpDJujR71lY51 vEFN2TOae3F16RlvXLD8azMT9HPLEAY6jUqjJWDsvr9XZv61cw+LQkwv+R5Re/lyi/JRxyToG6+r ytMW7LmPiTD9ZtPgUM9Vap9Fp/q2bfAYbLwmFHByww== =mwel -----END PGP SIGNATURE----- --------------mFxDfl940PuNXjVwa6wL9dk9-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:13:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:13:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396561.636737 (Exim 4.92) (envelope-from ) id 1oTj4W-0001iu-MM; Thu, 01 Sep 2022 12:13:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396561.636737; Thu, 01 Sep 2022 12:13:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTj4W-0001in-JM; Thu, 01 Sep 2022 12:13:24 +0000 Received: by outflank-mailman (input) for mailman id 396561; Thu, 01 Sep 2022 12:13:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTj4V-0001id-KB; Thu, 01 Sep 2022 12:13:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTj4V-0002uT-Fy; Thu, 01 Sep 2022 12:13:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTj4U-0001JG-VE; Thu, 01 Sep 2022 12:13:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTj4U-0006mD-Sr; Thu, 01 Sep 2022 12:13:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P14V2Tm19OFexxrXfzsxT2gCGYE8O4Yxmh7Qqdt05Tg=; b=Mly5VRsdq8P6OcCEn14po8bsxL 6oTBE3vYbOZ5Cgu2TQchIcndzWtLnmSPe7rSjdhZMRGcYC3eBAatZl/OhX4SCooipk+pSXdFXNO8x Wt1NQslUOD+76GhSnH47ADwojRdXTosbzlHpfStRYITEH75bzPYQ0A7k5CBkvKx4bqt4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 172907: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-pvops:kernel-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3145180ef5db262f7ef45dcb286b67bb04b80b25 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 01 Sep 2022 12:13:22 +0000 flight 172907 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172907/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-pvops 6 kernel-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 3145180ef5db262f7ef45dcb286b67bb04b80b25 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 783 days Failing since 151818 2020-07-11 04:18:52 Z 782 days 764 attempts Testing same since 172885 2022-08-31 04:20:29 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121191 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:47:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:47:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396571.636751 (Exim 4.92) (envelope-from ) id 1oTjbr-00054k-EK; Thu, 01 Sep 2022 12:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396571.636751; Thu, 01 Sep 2022 12:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjbr-00054d-B3; Thu, 01 Sep 2022 12:47:51 +0000 Received: by outflank-mailman (input) for mailman id 396571; Thu, 01 Sep 2022 12:47:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjbq-00054X-5Z for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 12:47:50 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47daf487-29f4-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 14:47:48 +0200 (CEST) Received: from MW4PR04CA0346.namprd04.prod.outlook.com (2603:10b6:303:8a::21) by IA1PR12MB6650.namprd12.prod.outlook.com (2603:10b6:208:3a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 12:47:44 +0000 Received: from CO1NAM11FT098.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::3e) by MW4PR04CA0346.outlook.office365.com (2603:10b6:303:8a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 12:47:44 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT098.mail.protection.outlook.com (10.13.174.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 12:47:43 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 1 Sep 2022 07:47:42 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 1 Sep 2022 07:47:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47daf487-29f4-11ed-934f-f50d60e1c1bd ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gdOWKpooVjW4dtMwc/PJxJjyn86WijqVHYCDSK8YDCW06CLrUJIQKpB+Oppuf2G+S2gipVWdbwZRW3iKZE/wnhxkk6LPF+03j8KCa2ua58LtLsWCdOELmGYiphTzCzj2yo9Lcxz6FZsIZsdwEdL+iZGqJ7kyjDvJW6cJGDjpYMEeY63rthPO+w5hFw8rH9vzfPdGbA6QTIFEGtKGcJKFO2O/30FPS3+KRFCS3r5w3kcAnH2ImxONW7kGEywXQB4RVK9YPu6G3ZFuNrFylCYWVeVtc0VEOVC61LcbyQ+v1SW3LDy7srK4Hw7bC6Fz7GpxR1w7fhlHz2q2FMJDwjcMAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCqMWkbONnNBW7xCZnzA02s5mxJuxs8qoF+Sr83l4IM=; b=c+J3mb5U/NRWUpVZe+26wbJ/Yg1jdoHmGgayZEzH/AugbqCIc3EEgY0TEcrES1mOMDT+CLw7aDpqgTO2l4a9csEsj9pdYQYelXX6GgQ+s23B51FmqSpgfhjqWnRxOUX6U8qcvtXLQiLPSR4UL30czWVMZRHMLgh3mmEzofGhhMRburCBz2QWPiymeawfmc0xkKMxPi/TuCKMWPDI5AxrB4y4dpRxtyz78loC38BK+of+HpzV9TYEJtEiJ1+JUG+dJQP0xIwoiRDdkdp1V+Cla5Y41iPMsTpJOshLkFDEZE/Vcjv99DA+sa1dGRbQRO+zofwEokNTycZwit/zrQesKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCqMWkbONnNBW7xCZnzA02s5mxJuxs8qoF+Sr83l4IM=; b=0d2FrOUsa91RpxtEvb0AqVRpnV077E0NWM13F4VFjweyfrc31Fu57Y7x8zJeYL6g/N5JqE/gYV7kvYqixW2CVymFIW2kHJht1IROX1S39Dd1eRo28SrKlZdcBUYNf0UTPsbWd45CVzY4QBwW3pW6LjNi+ES/Yo2z7hHTaJ2c7WQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <717a1674-9217-9162-1f84-838ea4c79840@amd.com> Date: Thu, 1 Sep 2022 14:47:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Content-Language: en-US To: Rahul Singh , CC: , Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <2b7be7ea9f2f06939ebc185490196f20614b6a3b.1662023183.git.rahul.singh@arm.com> From: Michal Orzel In-Reply-To: <2b7be7ea9f2f06939ebc185490196f20614b6a3b.1662023183.git.rahul.singh@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d42719d-5d24-4ab9-4ffc-08da8c182a29 X-MS-TrafficTypeDiagnostic: IA1PR12MB6650:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8NIRppsz4kADx8AXFivAMp3yhCEBdgFrftb3OGFCXkklDDK6Xk78X89EEwrb25lgb3SbcwoynfY7YHpYt2OzRF9UTwChQXp5YPWkDg8Ez5k1VwySvKoC6cDS00eQ52Zz3U1S10yylnbkfvhK9ZB5l9J8JqB4NhoXbBd3Vu87ire8u4luL6VrRV+yhkEEAEZmZkQRl/MKbac+wNB/8vOtuxrCilvish0bSwfLnZbJxl07g3Sdw7uqNvrNPSjec1nl9TwVPlpQjqYS6D2owp+JSeshLiNhbgNYJAn9pUxkWgFEhoqcbeyfTIIGWwYDFfaB8utJk77G351Sm0vTZfRRuFTWHBqXgdL2Jyp9SnSFwhE6Fylg4+vJAN5T6c7YjAPPlO+nONmpn0bib/atvlUCk9xOdmXOfZgJNGIFCMylHmc0IiA7KAziYQHhvOL/6KiJK0ZcqUPPaMkURDCGOnH/Xhd6xD1nnPgFejg+dRCrqsqLrwNMHqW8Mtmt70yBqheY4YviTtdrTQPb/cSZxu80RGPz6F6n2QNn8xqerOogH1MCO3f0wNP535dDt1O9Pf3rXlrF+B+lktgjJm9Oe9VTVr20qhKm2y9CZfK0mA0u4cz36vszleuK09q064yfQN8n4vdHLRgHCC+q/lENAjGgCHPJGcOgl2Y1nd1gj+qwZM/JZKgQS0ayW5CRh+S7mquYwU9CTwDcA2PdvmMt04OWuSKEmRJESOXEzS7NjPHPeAOl/aONL713ZnwNOry7Tg0Z4pR4m9G/2NCTp77bJJRWd+hoM9UAOaSH69h4RoYymX91zfaiL8/hzJjUbhHA+jx6IFXIZ9/6bECx1Nn1eNXQ+g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(36860700001)(82740400003)(40460700003)(81166007)(54906003)(31696002)(86362001)(316002)(8936002)(16576012)(7416002)(110136005)(2906002)(44832011)(356005)(8676002)(70586007)(426003)(83380400001)(186003)(70206006)(82310400005)(5660300002)(47076005)(2616005)(336012)(31686004)(4326008)(53546011)(40480700001)(26005)(41300700001)(36756003)(478600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 12:47:43.8769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d42719d-5d24-4ab9-4ffc-08da8c182a29 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT098.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6650 Hi Rahul, On 01/09/2022 11:13, Rahul Singh wrote: > > From: Julien Grall > > Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event > channels code assumes that all the buckets below d->valid_evtchns are > always allocated. > > This assumption hold in most of the situation because a guest is not > allowed to chose the port. Instead, it will be the first free from port > 0. > > When static event channel support will be added for dom0less domains > user can request to allocate the evtchn port numbers that are scattered > in nature. > > The existing implementation of evtchn_allocate_port() is not able to > deal with such situation and will end up to override bucket or/and leave > some bucket unallocated. The latter will result to a droplet crash if > the event channel belongs to an unallocated bucket. > > This can be solved by making sure that all the buckets below > d->valid_evtchns are allocated. There should be no impact for most of > the situation but LM/LU as only one bucket would be allocated. For > LM/LU, we may end up to allocate multiple buckets if ports in use are > sparse. > > A potential alternative is to check that the bucket is valid in > is_port_valid(). This should still possible to do it without taking > per-domain lock but will result a couple more of memory access. > > Signed-off-by: Julien Grall > Signed-off-by: Rahul Singh > --- > Changes in v3: > - fix comments in commit msg. > - modify code related to d->valid_evtchns and {read,write}_atomic() > Changes in v2: > - new patch in this version to avoid the security issue > --- > xen/common/event_channel.c | 55 ++++++++++++++++++++++++-------------- > 1 file changed, 35 insertions(+), 20 deletions(-) > > diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c > index c2c6f8c151..80b06d9743 100644 > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -193,6 +193,15 @@ static struct evtchn *alloc_evtchn_bucket(struct domain *d, unsigned int port) > return NULL; > } > > +/* > + * Allocate a given port and ensure all the buckets up to that ports > + * have been allocated. > + * > + * The last part is important because the rest of the event channel code > + * relies on all the buckets up to d->valid_evtchns to be valid. However, > + * event channels may be sparsed when restoring a domain during Guest > + * Transparent Migration and Live Update. You got rid of mentioning these non-existing features from the commit msg, but you still mention them here. Apart from that, all the Jan comments were addressed, so: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:52:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:52:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396584.636767 (Exim 4.92) (envelope-from ) id 1oTjgL-0006iQ-28; Thu, 01 Sep 2022 12:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396584.636767; Thu, 01 Sep 2022 12:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjgK-0006iJ-Vg; Thu, 01 Sep 2022 12:52:28 +0000 Received: by outflank-mailman (input) for mailman id 396584; Thu, 01 Sep 2022 12:52:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjgJ-0006iC-QZ for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 12:52:28 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2082.outbound.protection.outlook.com [40.107.104.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed8dcb15-29f4-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 14:52:25 +0200 (CEST) Received: from AS8PR04CA0052.eurprd04.prod.outlook.com (2603:10a6:20b:312::27) by AM7PR08MB5478.eurprd08.prod.outlook.com (2603:10a6:20b:107::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 12:52:23 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::a0) by AS8PR04CA0052.outlook.office365.com (2603:10a6:20b:312::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Thu, 1 Sep 2022 12:52:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 12:52:22 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 01 Sep 2022 12:52:22 +0000 Received: from de8de7f5eef8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 588E85BB-49C4-42F3-8402-963D3013090D.1; Thu, 01 Sep 2022 12:52:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de8de7f5eef8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 12:52:21 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com (2603:10a6:20b:41f::23) by AM0PR08MB5332.eurprd08.prod.outlook.com (2603:10a6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 12:52:10 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::d117:77a3:a165:3f55]) by AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::d117:77a3:a165:3f55%6]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 12:52:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed8dcb15-29f4-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=R5TGgyoy2Snlg7lfUASIiL8nTgVM6J2Q/5rdCgl+3kZCsJl/Pb0MCQvcHxIh0XA3Zubpj2NDRZWQe2QNz4ABzo/39PXQM0fm+4ogP7Si+mGuJwuRxjbLOuQnIx3NpKspW3anpKu0jbFF5LiBKMjh3qxHSwvk6+o+Gvdo6nwypKDnDk9HVCOLP5EwhIaMCMAd0jq2AqPU/oKuUARCuWG74iwN5UQJ29wKHeOLiFcK/ub9JxIR84ZVgo8TCdULGgeZOohYASQlbm/ifNG6qXzq6CFsII+dOFBg1IPabCsQTfwxAQi6KoG7CLupycJitcZnszgHVmztHl/qAhjGMiwRcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TgIZLiaji23oAiTU/MzMChTmwY+es3GPxmRbrVWMRGA=; b=I1PZXbmcO34zjkdLvMqno2wnvhx5EqzP5p+quqTFGlHHtIO3Sn0fccm1C2ciQkPQquPAbwcJz/TIkgd380YuG56xMpwbJm3ZmMrQzrbIM7XmLcl7XrI8TpFnLzw3oZUWUNXAgm9+pJtkVbE5qoIiWpWqVgu26T4MkPg2UG3+l4ZeVpTzPtZ2ZloZePZtfIXaN7AgQbpN2xe0G8difJequD2vGnVQHtDDol6nZT6dCc1qDm2BuVUnnN5O75tbnduD5/JNA1RlgzaCCPuzHnxXDrGOxTq7qHOIvARUEhnUq3SIM/71RVxotLHUEKrbLtAYRjUIfQcRGhrODUgMaGva0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TgIZLiaji23oAiTU/MzMChTmwY+es3GPxmRbrVWMRGA=; b=NVoFEKMm2xGfU3LwhyvDy/EuzZhW3b2wbg1zw1SFSpv/6YBbB0Yf65iv05lp7AbnxU6EuiJ6Mij+h52Ylm1A/pOPOccT3rGI84yP4VGPzP2T4PwwbLIWPd8vJxfzNQpyBlPPqYRW+vAZ+g7GJ/b8423vZjDxF4AI6J1ldtiM2z8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ef329e0f027f9987 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OpC5eV9oUHpjj3HvibRgS3IEIOr+bi4tPVZtr5uSodnlyAh2QQXc66KO77Fmn188DLgG4helMut53vrEflb0CRy2YsnpgJHnIhkY3SDLD6QPztpQw1ec1bxEK5Q6qbLHuHYZL5yMeQZqW/F4JJ4+EP3sswfyr1XmgzTGLjiJwqnI+P0Dw/rE9rjq/MLA2YjHLQty/p6xbipmEtsrpdXgy0fFuHgCEtLhLO/9RsIthGx2GzhZrPNDlzn+XCSvSczwLEIw5xy90G5kV+2p/pc53D+wG6rkq1FN6jTZcbcnF6ClPI6zk9KeeL8mIDVzjD+YduJj1IVsV3SaYUlKwwGzaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TgIZLiaji23oAiTU/MzMChTmwY+es3GPxmRbrVWMRGA=; b=ATiC9u8DEiFB66dGOGTvtVnlnEea9u97lZOEbQmjetHF5cHgNiTNIPMOud2RE8pHXGotXVtXfcYr/nXUhTJQnUdXiJYkmbibBZBJP098nOcdqNIUrQCSCgzfzd74/Y2Vf6tG27QwfmiEYffcSZrJea/RneJ8zsXhJzqTVWMF1uZfCO2CGiwWkV7+PDIhoBVjIbWqFG68nypjxl3kMcnnl1rTv7nN627MV5aGXjgMfHQAh8RsBn8ztZ7/Nx531I7Xzk7kwchUKtZpxvXJ3nMbqaiswXZnp/sVMw7X9MDxUYWxv+ZFu1tVytEL3w4OFSKQ1l7wnXAWUUCFyBJ1HEz7rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TgIZLiaji23oAiTU/MzMChTmwY+es3GPxmRbrVWMRGA=; b=NVoFEKMm2xGfU3LwhyvDy/EuzZhW3b2wbg1zw1SFSpv/6YBbB0Yf65iv05lp7AbnxU6EuiJ6Mij+h52Ylm1A/pOPOccT3rGI84yP4VGPzP2T4PwwbLIWPd8vJxfzNQpyBlPPqYRW+vAZ+g7GJ/b8423vZjDxF4AI6J1ldtiM2z8= From: Rahul Singh To: Michal Orzel CC: xen-devel , Bertrand Marquis , Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Thread-Topic: [PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Thread-Index: AQHYveMkt35gh2PJUU+Mzacc/fzh2K3KhkQAgAABQIA= Date: Thu, 1 Sep 2022 12:52:10 +0000 Message-ID: <52331F06-0285-431F-B965-B30BA25F3051@arm.com> References: <2b7be7ea9f2f06939ebc185490196f20614b6a3b.1662023183.git.rahul.singh@arm.com> <717a1674-9217-9162-1f84-838ea4c79840@amd.com> In-Reply-To: <717a1674-9217-9162-1f84-838ea4c79840@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: bc147e46-eb49-4506-ae2c-08da8c18d014 x-ms-traffictypediagnostic: AM0PR08MB5332:EE_|VE1EUR03FT061:EE_|AM7PR08MB5478:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JE0yO0AlxQpX2W6soILTc4bBdS2VxeJysMD/u9asdr+vzAYCF37Ojn2CnPH15Zy1QGpJYiC32Bq3KXKmpK4SOf1B6DuLmSOcFsWWa0srpmtSLMTRl+GHNl/ukdGAWQdJqGaBXj3MacI9fHtfb0HfDRThecGS6qDi1TvavC4BQ+0fUUt7g0mCsZHJ9Nk/eWdCB5jSthK2jygm5TNjIXq0FMaixS+23fyUQrfSdYYt33CZaQWjss8I2EUvaQq2634lEN1Qv5vFlbSTs8MbwoIIEf7qnY/9mdZ+WIkmVhq3JbHNul6lXZLVMipBFKLNEx8+rU326JQoQbn7asX14PHqjTijwKufci4mbjltmRfzVT/gPRJCiEeSFZ3wKvsnYg/lq5d7TQoUkonNnOwqkeXLjlKTjmD1HzUprdzD+eSXMBmLnv25MXeMzQssTQH2MaOBX8BZut1BZgZNIp+aM20eWAGA+V8eQgzfIC5KMWTdAADEaSCFpuJbJzK2HLDL3Gn1Qx4eoWBn5ulTPAYkqvl8iacN5iZY1vgBQl04XYWYXg5flqxFojmHOQ2jq0rn3FQJRETQh17pv+iMvmPsaGHodSoxwTpGdHZ6jmwWFUtHYtwmn/17e9kX0cJ041jEO2PnWoikslBjZHtq1Ah7qsWlFGcU/4PtmCHOjLhykNEeRjrCfvhoMvltACicWKWyXwq3sXazWmnZ5EbWSS8gLugJwhUSIMth6/gx1USpaPJCFmVMgol02Yr3yI5IkNdqcyX9rjkrcYeTcxuRjk9QPdzcDcEUa5Wg+nPF0BtY6i57xRA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB7165.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(136003)(396003)(376002)(39860400002)(83380400001)(6916009)(54906003)(33656002)(6506007)(41300700001)(6486002)(53546011)(86362001)(6512007)(71200400001)(26005)(186003)(2616005)(478600001)(8936002)(2906002)(36756003)(38070700005)(5660300002)(66556008)(122000001)(64756008)(76116006)(66946007)(8676002)(4326008)(66446008)(66476007)(38100700002)(91956017)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3E4C52C0C126E54DA3AFCA95054CE9C0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5332 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cf24fc1e-9290-4dc0-8405-08da8c18c8ba X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2wnC4Rcr1z4BWuZcC5qegB1ps5xBp341QmSILWiJEXhWRZslF23Bs4QQlrMPnqcEUYQV81xvMrdT1XXjVC2n0AOXv+9n85MpA0JCVpQjJHR2T/qz6o7txMo2kWyOsbE/Ieg5xD6DFwbVTiJv1G0X4j06y7C8XMsJuvvs30G2YJuLJOYTTQNzUOIkQkIBRXOzJLDRjoWmlMZzQH5RLFA8frp2Zp6hiIlt2lY8IvN0OG4rej7mLFr3oa3YwrEHnX3++7mou5CLavBMwLEu7h6f2lcV9m2PFEYSrXr5jzm1qrVSaN0HZHQtosWGuVZ0njWItRAr1BIBr6YStK9BLHmjeBGVIieio15vQtriDXY6gJ4LPtUD/1ZPWeec5ITo2S9v6qJZj8ItTuyHtVrK68tTImFaq//myHl4wcKz3ciKt8mZzrZpB7KGDqj/uVLjKPSP528Cpsole8TCjnwOEzI614NOZ4r3eUSMlwp8MZ4jhEwp0U0n559QGqSNPmD5DryoZXuXw05Ww8yfIhlhn8urgNylCvIJu7GlzJfXh8tNN+G+YZXvaFrVxgjzY6VoFWPx3036WXKS465TGvHz8ZypKUV3drPnxa3u9+wWUpR9fcJdZN4dmTH8pJ18QtJQqs5hi61OaUDb1Qz5ohbvpVGvPpM9NxErviY++sqIK19Clxq5BKm5tPl/I4ob6ExPUe3Mh9GtU9049ENfHbiwmPRLXc22WUqSyzztnuwn4kCfz7RzWMQ1GyUlCjnFQNOHUaz8J6VDAZwpVCFPD3tTGhHPCA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966006)(36840700001)(40470700004)(5660300002)(8936002)(40480700001)(70206006)(70586007)(8676002)(6862004)(2906002)(4326008)(36756003)(33656002)(316002)(54906003)(478600001)(82310400005)(6486002)(41300700001)(53546011)(83380400001)(6506007)(356005)(6512007)(26005)(47076005)(86362001)(81166007)(186003)(336012)(2616005)(40460700003)(82740400003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 12:52:22.3372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc147e46-eb49-4506-ae2c-08da8c18d014 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5478 Hi Michal, > On 1 Sep 2022, at 1:47 pm, Michal Orzel wrote: >=20 > Hi Rahul, >=20 > On 01/09/2022 11:13, Rahul Singh wrote: >>=20 >> From: Julien Grall >>=20 >> Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event >> channels code assumes that all the buckets below d->valid_evtchns are >> always allocated. >>=20 >> This assumption hold in most of the situation because a guest is not >> allowed to chose the port. Instead, it will be the first free from port >> 0. >>=20 >> When static event channel support will be added for dom0less domains >> user can request to allocate the evtchn port numbers that are scattered >> in nature. >>=20 >> The existing implementation of evtchn_allocate_port() is not able to >> deal with such situation and will end up to override bucket or/and leave >> some bucket unallocated. The latter will result to a droplet crash if >> the event channel belongs to an unallocated bucket. >>=20 >> This can be solved by making sure that all the buckets below >> d->valid_evtchns are allocated. There should be no impact for most of >> the situation but LM/LU as only one bucket would be allocated. For >> LM/LU, we may end up to allocate multiple buckets if ports in use are >> sparse. >>=20 >> A potential alternative is to check that the bucket is valid in >> is_port_valid(). This should still possible to do it without taking >> per-domain lock but will result a couple more of memory access. >>=20 >> Signed-off-by: Julien Grall >> Signed-off-by: Rahul Singh >> --- >> Changes in v3: >> - fix comments in commit msg. >> - modify code related to d->valid_evtchns and {read,write}_atomic() >> Changes in v2: >> - new patch in this version to avoid the security issue >> --- >> xen/common/event_channel.c | 55 ++++++++++++++++++++++++-------------- >> 1 file changed, 35 insertions(+), 20 deletions(-) >>=20 >> diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c >> index c2c6f8c151..80b06d9743 100644 >> --- a/xen/common/event_channel.c >> +++ b/xen/common/event_channel.c >> @@ -193,6 +193,15 @@ static struct evtchn *alloc_evtchn_bucket(struct do= main *d, unsigned int port) >> return NULL; >> } >>=20 >> +/* >> + * Allocate a given port and ensure all the buckets up to that ports >> + * have been allocated. >> + * >> + * The last part is important because the rest of the event channel cod= e >> + * relies on all the buckets up to d->valid_evtchns to be valid. Howeve= r, >> + * event channels may be sparsed when restoring a domain during Guest >> + * Transparent Migration and Live Update. > You got rid of mentioning these non-existing features from the commit msg= , > but you still mention them here. I missed that I will fix that in next version. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:55:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:55:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396592.636777 (Exim 4.92) (envelope-from ) id 1oTjjA-0007Oq-J0; Thu, 01 Sep 2022 12:55:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396592.636777; Thu, 01 Sep 2022 12:55:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjjA-0007Oj-G7; Thu, 01 Sep 2022 12:55:24 +0000 Received: by outflank-mailman (input) for mailman id 396592; Thu, 01 Sep 2022 12:55:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjj9-0007Ob-1U for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 12:55:23 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56ea88a2-29f5-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 14:55:22 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id qh18so14204450ejb.7 for ; Thu, 01 Sep 2022 05:55:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56ea88a2-29f5-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=sCiNS6w6foNP+CKWvl8CEHUqFG0zx9VfwcMDKTwmM7k=; b=cA/7Dqww2zwOVK27MmDrhDPquXkIzEfGx3arKa75fFdUmRemrjIskpLVXFDAn4egN2 5LSThc0Dgh85zVnUjPX5Pj4x5lXxYctsYidH647bxBYuK+zXL2mODvpA0Odr6sIhZa3N vwDdb5SJybBCVyd1lTHt8mG7JNtfT6KFbT45tHbhAejHACUTaa+fyh7E3Tbco0bq/kcm dkTnOA9tUTK2bmqzy3slvm69odwfwNzbzp3ayDfV/8+2BvsPFU4KoTMbW5en6pr4xkP1 fnaE0kroOZQn/2g+Gn1Sht3Pg34oDa659TVVdEQpjX8b9OFx/OtyTzc0EObOZ/wmMHuR jM5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=sCiNS6w6foNP+CKWvl8CEHUqFG0zx9VfwcMDKTwmM7k=; b=VJ+xwrS4Zx9uB9m4ueWdzft/h211esFaF2D4al3fSYmkS+KiDXtITdTuG1G+tO/FAY QKUf8qsrrG9qZg0Ei+FV5cyrpEbc2C2JBjPYnAVIdggm9Zj1t19On8EmKmIJ7stPUe15 ZDWD1euRtMPwFb2cboAsYg2Irhf5zqV+OMji8wbPEBn39USincMrYiVlwW4wLi1qQkdA LyZTZ8toqSskhUePHYo4DcEJ2gmlzoRzlH2eFNyx7k0SH1jmcxDEsfIHH5grZH/O/qSF VH3gy4YD4oi0LGeThv1/jRL+Yz41iKEHy7pw4j2vjkXa4zs8a13tZS6oDZhQeJuL+xvj XVng== X-Gm-Message-State: ACgBeo0Jkb8YrUlWDZpgZVQ8yRT8zHdwrGMIaXPlE6xD1xOSLqTvlJaD uNh2MnYUy5DKvuKOgcGf7jB61nHdqjbhT7QHU0M= X-Google-Smtp-Source: AA6agR4RroBtQTt0co5okCkrxi5WGtHpVVl+N93eSqFHKu+g6OKclDLqrb4lUJWPUpW1TX0u/+CnuiSSh9wZEGcc/OM= X-Received: by 2002:a17:906:3c4a:b0:741:6b91:867e with SMTP id i10-20020a1709063c4a00b007416b91867emr15261985ejg.297.1662036921514; Thu, 01 Sep 2022 05:55:21 -0700 (PDT) MIME-Version: 1.0 References: <20220830202706.1618386-1-jennifer.herbert@citrix.com> In-Reply-To: <20220830202706.1618386-1-jennifer.herbert@citrix.com> From: Jason Andryuk Date: Thu, 1 Sep 2022 08:55:10 -0400 Message-ID: Subject: Re: [PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable. To: Jennifer Herbert Cc: Jan Beulich , Andrew Cooper , Wei Liu , Roger Pau Monne , Ian Jackson , xen-devel Content-Type: text/plain; charset="UTF-8" On Tue, Aug 30, 2022 at 4:30 PM Jennifer Herbert wrote: > > This patch introduces an optional TPM 2 interface definition to the ACPI table, > which is to be used as part of a vTPM 2 implementation. > To enable the new interface - I have made the TPM interface version > configurable in the acpi_config, with the default being the existing 1.2.(TCPA) > I have also added to hvmloader an option to utilise this new config, which can > be triggered by setting the platform/tpm_verion xenstore key. > > Signed-off-by: Jennifer Herbert Reviewed-by: Jason Andryuk Thanks. Is there a particular reason why CRB (Command Response Buffer) was chosen over TIS (TPM Interface Specification)? I think of CRB as more of an embedded device TPM interface, and TIS is what is usually used with physical TPMs. My experiences have only been with TIS devices, so that is influencing my outlook. Hmm, this patch seems to reference the Intel Platform Trust Technology (PTT) fTPM (firmware-TPM) as using the CRB interface: https://patchwork.kernel.org/project/tpmdd-devel/patch/1417672167-3489-8-git-send-email-jarkko.sakkinen@linux.intel.com/ If PTT fTPMs are using CRB, then it's more than just embedded devices.. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu Sep 01 12:55:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 12:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396596.636789 (Exim 4.92) (envelope-from ) id 1oTjje-0007vL-SV; Thu, 01 Sep 2022 12:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396596.636789; Thu, 01 Sep 2022 12:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjje-0007vE-P2; Thu, 01 Sep 2022 12:55:54 +0000 Received: by outflank-mailman (input) for mailman id 396596; Thu, 01 Sep 2022 12:55:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTjje-0007Ob-7J for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 12:55:54 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69a2eda1-29f5-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 14:55:53 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id y64so10633569ede.2 for ; Thu, 01 Sep 2022 05:55:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69a2eda1-29f5-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=jhfzIaUon51fYQp0F1k+dFqo+kZvbfWBW8TIyHPfH9o=; b=jMSC0YquDnvD/wKHI7Bl6kt3HP8PI5qhhb7sTMXUL+2sSZjhkC4vH4MxakkmvLKGjk QPxjuyey7HagF+AKEaAsGWlUWccERGb/0c3siHGQcJRHzMwkTFAm8yI38icYY1dnI/ZR aJcp7GhNNHp+/NeWvUyqk16WaRrTwzCxLwMXc/YmVsxcBaTyarMh4CYu0gU1Afya2nQt Y97YDdJE3S2oo7RCBbDVSvod461mGchoBGCr7dPjHgA/TAl8PQAqmeFnn+NUzkyI6D68 xImxBql/4xfUNMzoJes4HdZqS7VmJqHI1VM19eEqRUgI6esl0d1vJLnCn1eSCqjldWcB bbOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=jhfzIaUon51fYQp0F1k+dFqo+kZvbfWBW8TIyHPfH9o=; b=HqniuDbKLt7IkGj5iYuUOThYyMwbpNqdS/s6YwHWOmpZbNUlMkPWhSfTOh9ATGX236 QYbVAm6lY4CcFHHQAzPTw8IXJzXGQychXke6rs+A9ArxGz6nLSk+neUWNRp3BgWQlymI m4qK2MEd/04VUU5cbEDSJvbciwyE9bTTvOkCAoid1o6AeDCjpd3oNoEo+cKduiiqVfay UoYyk1F1gyZ4UipKbth4oOGHvORxucirzKTa4OsG9KfWYJH3jMxokpGWlF4bv3BvBXif rlqFVHxwYxIhuHaaFy7Hfdrb69ZW1S5K2SexdHKkfXc4Y3uP7toVUBH2YyAPBi3wd3CR uEKg== X-Gm-Message-State: ACgBeo2at5GkeJPL6/kQm5SBcMazszeviH3oaKLo29jnh0ebLA5zKQEs njvXF6CQbRbzkBhwPOI0S9NsyicvqCdzTkCO7eKJZLcd X-Google-Smtp-Source: AA6agR67InrKUxArKpIRlcyj7cVISplMIgyuL+xsXdnE6v/afHMiKYTX1RTDY2PSTc+Hfk6DW1c51JwwhoW8mNZLH7w= X-Received: by 2002:aa7:c956:0:b0:43b:206d:c283 with SMTP id h22-20020aa7c956000000b0043b206dc283mr28605542edt.381.1662036953082; Thu, 01 Sep 2022 05:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20220829151536.8578-1-jandryuk@gmail.com> <31F127F6-A096-4991-9D4C-1B2E032689A1@gmail.com> In-Reply-To: <31F127F6-A096-4991-9D4C-1B2E032689A1@gmail.com> From: Jason Andryuk Date: Thu, 1 Sep 2022 08:55:41 -0400 Message-ID: Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state To: Rich Persaud Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Bjorn Helgaas , xen-devel , linux-pci@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2022 at 10:35 PM Rich Persaud wrote: > > On Aug 29, 2022, at 11:16 AM, Jason Andryuk wrote: > > > > =EF=BB=BFAn HVM guest with linux stubdom and 2 PCI devices failed to st= art as > > libxl timed out waiting for the PCI devices to be added. It happens > > intermittently but with some regularity. libxl wrote the two xenstore > > entries for the devices, but then timed out waiting for backend state 4 > > (Connected) - the state stayed at 7 (Reconfiguring). (PCI passthrough > > to an HVM with stubdomain is PV passthrough to the stubdomain and then > > HVM passthrough with the QEMU inside the stubdomain.) > > > > The stubdom kernel never printed "pcifront pci-0: Installing PCI > > frontend", so it seems to have missed state 4 which would have > > called pcifront_try_connect -> pcifront_connect_and_init_dma > > Is there a state machine doc/flowchart for LibXL and Xen PCI device passt= hrough to Linux? This would be a valuable addition to Xen's developer docs,= even as a whiteboard photo in this thread. I am not aware of one. -Jason From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:19:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396604.636800 (Exim 4.92) (envelope-from ) id 1oTk64-00023R-NW; Thu, 01 Sep 2022 13:19:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396604.636800; Thu, 01 Sep 2022 13:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk64-00023K-Jv; Thu, 01 Sep 2022 13:19:04 +0000 Received: by outflank-mailman (input) for mailman id 396604; Thu, 01 Sep 2022 13:19:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk63-00023D-Eg for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:19:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk62-0004Fi-MN; Thu, 01 Sep 2022 13:19:02 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTk62-0001r1-D5; Thu, 01 Sep 2022 13:19:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PIgjDASsgFiY/ElhawtJlG7/nm73P8f/6MDomhxjrEU=; b=b+ZjzHIaOrO6TVvCQu5r8X7jtK CbLNGlyDxCoLve3pxsaNE0OwmzWDjtiHwNplpFjEr/gontxtlztUnuBVvn8sPB7MwURW5dcz/rTYn kWBsCdcxiDEsUswPlq2I/kckamiHcY6TuWTiAwVSgCGn3SnqAZyPKK6r0gVhwAgfe548=; Message-ID: <21e967e6-424e-d648-7bee-080e3d5185e9@xen.org> Date: Thu, 1 Sep 2022 14:18:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v11 5/6] xen: rename free_staticmem_pages to unprepare_staticmem_pages Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220831024041.468757-1-Penny.Zheng@arm.com> <20220831024041.468757-6-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220831024041.468757-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 31/08/2022 03:40, Penny Zheng wrote: > The name of free_staticmem_pages is inappropriate, considering it is > the opposite of function prepare_staticmem_pages. > > Rename free_staticmem_pages to unprepare_staticmem_pages. > > Signed-off-by: Penny Zheng > Acked-by: Jan Beulich Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:19:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396609.636811 (Exim 4.92) (envelope-from ) id 1oTk6w-0002aO-0W; Thu, 01 Sep 2022 13:19:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396609.636811; Thu, 01 Sep 2022 13:19:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk6v-0002aH-Ts; Thu, 01 Sep 2022 13:19:57 +0000 Received: by outflank-mailman (input) for mailman id 396609; Thu, 01 Sep 2022 13:19:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk6u-0002a7-UW; Thu, 01 Sep 2022 13:19:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk6u-0004G9-S2; Thu, 01 Sep 2022 13:19:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTk6u-00065L-BV; Thu, 01 Sep 2022 13:19:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTk6u-0006FS-B4; Thu, 01 Sep 2022 13:19:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QLq/AiXVDUI9XsY/MRiL7TYokeDKHWClohttHQGvi+w=; b=z1kc5djVl7JueIjsHA5qf0nfwr gUOZjsPX/l3ZGsoocuA6LxFlxM1soZRKPAcYdwH41YHOCKsviEN4/INc8wbxbIuw0+7TZYacnWvBk CwVGAPnJD2GW/crlYhnB0Y4+1cqgAe7CyE7rdGXC3H9WPCkrqGMLBFtEhTJS4+UgG5lw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172904: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore.2:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Thu, 01 Sep 2022 13:19:56 +0000 flight 172904 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172904/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail in 172894 pass in 172904 test-amd64-amd64-qemuu-freebsd12-amd64 18 guest-saverestore.2 fail pass in 172894 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 172894 like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail in 172894 like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 172894 like 172128 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 172894 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 172894 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 28 days Failing since 172384 2022-08-11 11:13:58 Z 21 days 44 attempts Testing same since 172776 2022-08-25 17:42:45 Z 6 days 15 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:31:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396620.636821 (Exim 4.92) (envelope-from ) id 1oTkHv-0004zF-5o; Thu, 01 Sep 2022 13:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396620.636821; Thu, 01 Sep 2022 13:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkHv-0004z8-36; Thu, 01 Sep 2022 13:31:19 +0000 Received: by outflank-mailman (input) for mailman id 396620; Thu, 01 Sep 2022 13:31:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkHt-0004z2-Dm for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:31:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5aa24c8d-29fa-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 15:31:16 +0200 (CEST) Received: from DB6P192CA0022.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::32) by DU0PR08MB7924.eurprd08.prod.outlook.com (2603:10a6:10:3cb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 13:31:14 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::be) by DB6P192CA0022.outlook.office365.com (2603:10a6:4:b8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:31:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:31:13 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 01 Sep 2022 13:31:13 +0000 Received: from 0f2a2c4a323b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 78AC8784-0C6E-4949-812D-98E3458839C3.1; Thu, 01 Sep 2022 13:31:02 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f2a2c4a323b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 13:31:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PA4PR08MB6078.eurprd08.prod.outlook.com (2603:10a6:102:e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 13:31:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 13:31:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5aa24c8d-29fa-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XxW+SG3yDMIqOsUNRLYT9wq2ni/Z/afG6ZDHoPhLXw52urixfCmM+y81iYR7EBtT8wxjUZXb6nuUL4gTZikqwaVaJLFRBvIAkRQNhomOStetdso7XewGO5Ves3MDWcjqea7aN7XYPSluoR4TFvR5jUHfB3xHoPcZMXYnsUPqFpyjL/XokYK6Rc6bzQJdfwrg5EG2c/sJYS1l0weBKR2RNXoymDPOt112tfmnZY2QNF/tP+m8K8UtEOQJbi71uNcJZVc+9xbPWd4tsCMnZt71EzBhtT4d98YVXmCqS8/LvW90QUiN9c0hZpNYnwmv3ynwGWdnuyZuac51xHbX3ukRrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+7aZtzP+3fVzOx9U/mTHQ45+BhoOndlAfsLGSne//qs=; b=XXnXOmNiRQzcJZ0CAQCtJLKelLWxNKt722Ch7rVNcHxEaUGVIVtamHnWEJ2TC2v8NKRxh3euB9SGOScVyqzRF3PXC3bdN/0euc7eGlw4j9WCnbKgJe+65LCgq5EUi7MsaIMMZioUoSStKofk7IyoCYzUQaHcqWJKIZIFcQ4GTcyEwgLJbxs4nehzMr7ZLT6DjZsIk/aYb+DwCpWpETX80MvPAmsWLPueJ58rLJMxADQqVR+X+BgMsKuwfTIlr8YbwiELtG9YEfiIW/eaDBWJ3nbAoqhUqzhMZzb8VeYAfghGv1yw8gIfYw/ybEfEVOkfeZcwoVctz59+vY9mjqkc4g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+7aZtzP+3fVzOx9U/mTHQ45+BhoOndlAfsLGSne//qs=; b=mS8EQP2r8lir1h0kGPnRD2agNn1uygb5w1Kwl0pbt2AHq2s0GzDuqgM/hX31y0U9idMcKVtnu029GZ15n1ooAXp13/M+zRfRonDSAF5lFJl0efyongRrNy58bmemaQ0KQ4jY2QWNpq9tnU9Ni1fyiRszipm0EJ3dsa4MQ9XQKsQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5f7059b396cb72ea X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QfVKmqd0DvpwgEdq6NmWsRveHgPknJ0bWrt5B7Zhh77nspr8oHZLg7Ane9GFwxIEq8DVxV08nRU1/iBK5UmCtrd8lcRLi4wz4EoDq+L4/4YDfncVrm6EYAwcH6nfewzAK70kHPy+xxvG2S9wfS1Bxa0byrXkWo1qEfuI7jkdjSixsX3k8wcKGCzOERuuRDpkkjTIyeA9QLGDuYZwO2RWl+cenwGQ1Pt+ePFarFoj6W/3EiI2LDL1gp1emNcFhls5uOpGG0wETfey8x8rfTBmLN/fSScwwd9BWTfTDkBRrdk8YyhnxwVtRHD8MZCU3FGYkKocG48leBxRXl4pFUFp8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+7aZtzP+3fVzOx9U/mTHQ45+BhoOndlAfsLGSne//qs=; b=QfANCKfkVwf/M5u3qcHTOt4sagFqdD050S2E2OX5joMKUu+6f1zqHGmET9U+k+lcnFtYsLVS4hc39zxEyWbivr8aJaO4U04mSqveBGMmB0Eh/NbIl/0dD/eto5GAYJcFdMwCagH4rpRWBa1Xq1Hu8vai9hzPKnEpf+2j6RAcgWVYoBOh/mj1HPlxXE9Hzfm1XX9wc4e5/Mra96l5u1Ark3AV9Qg8XW7ogfWsH4v4Dke/33NzGYADxhSB1wqq/7ygVEQ14J9wsoL69RveBQq56XKZcu8m2J/I34IfDX+q7zvSSegT2KVvr30rhi0837P2pxHj8ToYBAe0uIb6vVWQFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+7aZtzP+3fVzOx9U/mTHQ45+BhoOndlAfsLGSne//qs=; b=mS8EQP2r8lir1h0kGPnRD2agNn1uygb5w1Kwl0pbt2AHq2s0GzDuqgM/hX31y0U9idMcKVtnu029GZ15n1ooAXp13/M+zRfRonDSAF5lFJl0efyongRrNy58bmemaQ0KQ4jY2QWNpq9tnU9Ni1fyiRszipm0EJ3dsa4MQ9XQKsQ= From: Bertrand Marquis To: Henry Wang CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Wei Chen , Volodymyr Babchuk , Michal Orzel Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugdSSmJYfbb0KQ5sTlqjIZuK2/e0SAgAeENACAABMngIACu6WAgADQygA= Date: Thu, 1 Sep 2022 13:31:00 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <59f69736-a18c-9d08-94dd-791bd264d671@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 094ac9fc-1337-4e7e-7970-08da8c1e3db6 x-ms-traffictypediagnostic: PA4PR08MB6078:EE_|DBAEUR03FT038:EE_|DU0PR08MB7924:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mCLgH/Pk1cgLV+PrIuAabAbgtzRxD1nRMibWifPJlNh2bw/pbajX7uCXy577gVtkA9GqHcSFSglyT25Hb9H3olkfQY5lEjLv8modn6HJxzwbjfIZu0Rqr6gz8EkifMvI8fQC5bmWi6UvdTq5R8595tFpclMAdfEqwkMj047zOYM/+ZiA1PCxlxy7J4VPyc5EN6mEmizX9Nqz7lEpylc72QIOos9+8lSbQRBL1szciEgc8uR+tT8LaLENcMDnGc+Wl9Y40rc6IjcTXU2QhViyAsg2vxnQVquOikSpFJ6zQN7A6w9O2Vln0cZCrrDZ81ESquoazfr/JiYAnAlkbqeur5C1+LeNOXGKE8d4AnXfehmLBSTmcFDdEFLFdZhF/fQeukazOC02JOFM8nTBKjwSodJZ9uXsh18M+WbYlQMWAxSgvkYkWbtBf9p29dSXh4uKxtjjrmbM5EUdxZz5VkQUnJDy+kFlscIbSKAq7llPzYfQALJNGOEJKl3vPcwYmLOtJqIVxyOIGMWSKqXCuLi+WWn3HMcuojq54aiZj2mPtmHYfwngjOcUdrxh37CFDhcw8mfXC7pxCd8CmE0rw2J7NDTK7gG1xdml3bg7cX/uJhccsiTve8ZuOtV4nzHLo4fIIdw2EB+i4kiv7332wFy3skxzd+b5aLkSjP6aLgAxmDyD0+pkBVOhfdZQ+GL6VwpeUvUMyURoAVRmfNUnnWiL82nVWiq1GDg/dxnZ43aeBgr4Td/E60ZwCe/wNNYfcFLiken9N3y0nFm1CM4n+IQZ6GuV8CVkYimLx5gXCCvxtEU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(86362001)(2616005)(38070700005)(186003)(6506007)(83380400001)(41300700001)(53546011)(26005)(6512007)(38100700002)(122000001)(54906003)(316002)(33656002)(91956017)(6636002)(5660300002)(8936002)(6862004)(8676002)(2906002)(36756003)(4326008)(66476007)(37006003)(64756008)(66446008)(66556008)(76116006)(66946007)(6486002)(71200400001)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <14BC774AAB1A8146B2397CFDD699CB56@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6078 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e6831f79-3324-4bad-e887-08da8c1e35ea X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cwaHtnjTLjVFVOWdBFB+0aTXC/9VSnVReS9rQF/q6mdS0ZCEULhpNDYpheiAylJNoV0GAlfOb/Tfs9+EKzDjMPM61CDqjsxraWIR2DLnM736WjABDYktFR5hH/WtUkuCvBJSW3OzjBUwMnPt37S7FVVwLRwMAJPbYKwA45dKHsUpc6E2h8Gj+VwkkkRcixvHJmfnCPNT4jYGTFodKyXQb83l98GrK4G8QC85ReUU1oFHQ0DZBXRKvYQMGPSv3pekowKFziSjJY/r0ZXSKzkOhurdltDibiu1ceqysCCxFgnrmq9SqGyj1vS//EbTjnT+rHXmst19oCDYepz+HtiygdI1RBKWSlLlQb+G/Noo7538NVTaCHNVWSHHK3H/vqSAAIyA95fpQCcqyP+rGC3/F8cqGxRAtjLI13p5bMU1o/Zvy/JrG0GkK8EaTzeLrto2oAPdcQMlao4NYAYCT+fGxc6Iosu1WCsZvLZq9bOsqHaLBY9y9tSaPgqJk6GpoqEbMtQLrlavesYbecHF1DT/XkUwFLAwwEvrqZs3ddXldV+jh2A9VHieiyQBOVsP6TAFff/H7RmouTakHvVA/C6dlA8nANYMDQMll95WpMJ5r+dWKukPivlJGRlZA6Woa5BbKuZsJs6gOK/xtp5P5TqTpEjiBdGODwdVr2hYlj4Vk131lRFOkrJzNa3/dZPfgt+7Ie+rn1FhkFPIBeZiRedBfcsBocr6MeTnRdHx8pgn6Ez0Dsaym3ROFc9x1zKEEWOtwr06RMzltG4gMhTooMF1WA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966006)(40470700004)(36840700001)(82310400005)(6506007)(53546011)(47076005)(5660300002)(36756003)(41300700001)(83380400001)(6862004)(40480700001)(8936002)(36860700001)(6486002)(478600001)(8676002)(4326008)(70206006)(86362001)(82740400003)(2906002)(33656002)(37006003)(70586007)(54906003)(336012)(40460700003)(26005)(81166007)(186003)(6636002)(6512007)(2616005)(356005)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 13:31:13.8622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 094ac9fc-1337-4e7e-7970-08da8c1e3db6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7924 Hi, > On 1 Sep 2022, at 02:03, Henry Wang wrote: >=20 > Hi Arm maintainers, >=20 >> -----Original Message----- >> Hi Henry, >>=20 >> On 30/08/2022 08:11, Henry Wang wrote: >>>=20 >>> Hi Michal, >>>=20 >>> Sorry about the late reply - I had a couple of days off. Thank you very >>> much for the review! I will add my reply and answer some of your >>> questions below. >>>=20 >>>> -----Original Message----- >>>> From: Michal Orzel >>>> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot >> and >>>> heap allocator >>>>=20 >>>>> This commit firstly adds a global variable `reserved_heap`. >>>>> This newly introduced global variable is set at the device tree >>>>> parsing time if the reserved heap ranges are defined in the device >>>>> tree chosen node. >>>>>=20 >>>> Did you consider putting reserved_heap into bootinfo structure? >>>=20 >>> Actually I did, but I saw current bootinfo only contains some structs s= o >>> I was not sure if this is the preferred way, but since you are raising = this >>> question, I will follow this method in v2. >>=20 >> This is what I think would be better but maintainers will have a decisiv= e vote. >=20 > I think this is the only uncertain comment that I received during the lat= est > review of this series. I agree that Michal is making a good point (Thanks= !) but we > are curious about what maintainers think. Could you please kindly share y= our > opinion on the more preferred approach? I will do that in v2. Thanks very= much! I think it does make sense to put this in bootinfo.=20 Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:34:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:34:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396626.636832 (Exim 4.92) (envelope-from ) id 1oTkKu-0005cE-Mz; Thu, 01 Sep 2022 13:34:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396626.636832; Thu, 01 Sep 2022 13:34:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkKu-0005c7-Js; Thu, 01 Sep 2022 13:34:24 +0000 Received: by outflank-mailman (input) for mailman id 396626; Thu, 01 Sep 2022 13:34:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkKt-0005c1-Kd for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:34:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60067.outbound.protection.outlook.com [40.107.6.67]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9e037b0-29fa-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 15:34:22 +0200 (CEST) Received: from FR3P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::16) by PA4PR08MB5998.eurprd08.prod.outlook.com (2603:10a6:102:e9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 13:34:21 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4a:cafe::d0) by FR3P281CA0045.outlook.office365.com (2603:10a6:d10:4a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Thu, 1 Sep 2022 13:34:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:34:20 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 01 Sep 2022 13:34:20 +0000 Received: from 87e32432c947.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 11A2EF6A-1F75-461F-91F9-D93F00363BF7.1; Thu, 01 Sep 2022 13:34:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 87e32432c947.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 13:34:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8492.eurprd08.prod.outlook.com (2603:10a6:20b:565::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Thu, 1 Sep 2022 13:34:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 13:34:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9e037b0-29fa-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=g7VCfSoLX4aSrypoRWTLXNfUio1FNYEVQ5V/lgjQE8ZX+hVQfmIZH+hzkkZYJeZwI4xsB97gleTBI6s6ReFiMC/BqvkimQV046XSmp7IY+rjNs+iEwappcBfFmVqxGtPIHXQI0Y6mu0T+f4HcGQQt0NFgxVikuWuceuldHRYe69BKdTLfyuVSt2bWcK4x47NcNOpQ5RHfYDp+eQCtpvSp1Ely2g8S0J8zXXgFmApNyHzoid3KCCrJP5EIbS0vubOdVpMl4t7d7U9zwirbCuEqFBs6ALmEcA5hi28Fgjmv4XexxtGZqUlsh1CjKaI7aLBjY7hcSD7emt77g2MBH3jYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxRw09bemW009EVnRvkMOlocZZXMODx4PFwP1puPuW4=; b=ilfApVadfPbgmAwFG+HD7jng+q5IfZhU26zAM/NUdGoU6GCSF2xm1G55xo7dreGyWUpDWwIu4UO905bITYJIi2pqMjYRyvmxC6SCrkjJ07uTXtrGsiOkbHPZBTmQi3sMtP/cpK3KH0Q+UZeurrIXumDBozIJqxHtXupsCj5HLEmlnA0N4wsVx5+RxknrvpyH5x+GOBvtoNJ6HoFub2MnciwYDQ7QyUCpJfYA2lFdyT8fBlanPj012uSSUdF/85SDk43QGugRMBwQRqKKT/i4azb08+SdIVhnzOSq1bLUJAx9ZXaEhX+brHqh0dUnqLp3tGkX4IJR5hby58He52c97Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxRw09bemW009EVnRvkMOlocZZXMODx4PFwP1puPuW4=; b=wZ3ldVdb63kzec1dmSmKOKPNXI71YpQ+TkArpL5UrsDiQLtTXeUMo6jJGQ3MATFGcfVvnINu/Ej+V0Zst+H3d7+AuN9FYh5LUPeAsiDztUgQoUQa90x1f4T23XcirR2WAfYDxkJ+d/7KouJv0ONdwIj6OeRZRV8f7fEyRjL8aEw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6a534867fea7ffc4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hcd9S8YN3uJFe+UASidkv+AZpdLEtNqwdSH7koKvtMfDPBsOItBKzhfmZ8QWijEJzLz/LpyQTblPDfNUypdlJvrqkJDlC9YldQyZRrPuHqbkDHMgdSuZ72zK8BIfrK9qFJYhh3E/do8Mw+g9Mm8JdsxyOffNbmqAPJ7J1Rvfy0jRPenD75AY7bUfhAVw9dW1e52v5vIWm/UdRqNqQGM/+0EN5UApXzovcZIRMxPhbA4/vJ64a1o3QzE2AQUHYitK4kdXkD4SxKFBSkBnUidVVSZpFip55QegfPT/y0XghR0WbHEvSX+hQiM5lujNh3MB3f6f2bFqCSex2bVibJYz3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxRw09bemW009EVnRvkMOlocZZXMODx4PFwP1puPuW4=; b=VhD62jDQe+DopgorYDM6DfNyZ147LCTwcNLUDEUj1SYGzefFsFFF4FW8FKqYjWiHSk1RFxOCjt9slkRoCidh4i7CRA8m+SzlBaqOkO1RuPiZHkn0dbnYk6mfMrrp8X43qsXwrClofh9DeNOzqGsJch9QsIBs8/jpRG1gqs4QvSKrGQriqqFpQ+oMdBPqhyOGL6eP5iFYBiCaQlblKrQ0ZeNCldmTL9Z+dczOM+4AGqhLHwwoQIf/7G+1KPS0iph/ZDorvsF3TMpsdCju/WMyXX+4TNDc/OjSw8KJBvueRuHnjIrqZVnQtaYBHBpe80Y4AbE25Lz6x5vcAa2xALo/SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxRw09bemW009EVnRvkMOlocZZXMODx4PFwP1puPuW4=; b=wZ3ldVdb63kzec1dmSmKOKPNXI71YpQ+TkArpL5UrsDiQLtTXeUMo6jJGQ3MATFGcfVvnINu/Ej+V0Zst+H3d7+AuN9FYh5LUPeAsiDztUgQoUQa90x1f4T23XcirR2WAfYDxkJ+d/7KouJv0ONdwIj6OeRZRV8f7fEyRjL8aEw= From: Bertrand Marquis To: Xenia Ragiadakou CC: Stefano Stabellini , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Thread-Topic: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Thread-Index: AQHYtAQe6qSxrEQGbEumth30q9ivnq3Jq9wAgAC2VQCAAETOgA== Date: Thu, 1 Sep 2022 13:34:09 +0000 Message-ID: <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> In-Reply-To: <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 58d535a1-fe06-4f7c-1358-08da8c1ead28 x-ms-traffictypediagnostic: AS8PR08MB8492:EE_|VE1EUR03FT044:EE_|PA4PR08MB5998:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qOdoVoefY8lZVYQElcojZn9r26/27vPyVqq+8v/iClRdazSdKRUN43dSEIAblnOUke5/1wH001D0atE+KKOdqKkU135SBe83Z7zRO+X6IT3ss2OND0AytOJ5TlcjEHngZG9TaZqBBR1soULLL2Yhsif/tf8G5mqU22Pm340zodJaxhT99m91maxqxGh9v9RCiJFEH1XxZxpSM4WorRwFWJWLGOI3PU7mv8/lNsj0ssdVEXd7oBCirNWPPnWXmBt+zloOMOwYHOE27M9kSlU6BUZJb/H9HXZUINGWecUkzWcylmFn7yi6HaChCd6zfV+PoECHYZIUSGadL76MRSYUMWBgR5ZUabTtiF7Hskwn5IcC1sMKofiy4QTaVzeMI3psqz6QdCuPK3BXAVtjGtaNGtkaNRt7LMa9O55r52Mfk4bJommbapISz5IFEIpmOPpNJuPPN8XblfWHD+scNT6Wr1En8ReHIYK4THikaeCxI4dH1ydW6ftb2Tpa4bc+zHvP7oVnaDEvlksGn4LcQ4s8GG4XTdc7rCAqHbM84a6sBQSURFRR3uEKHzhrEAXJNF7UYploEp6U76DSwJT5TVnjV1MoTZDuOE06rUgmJKiLPTvnsXEx7VUKyyrxsycdQRm962LCzHSLxaFILpQkc5AGE3o01SdEXSZ3tQeE7UHZaLMr0po8QZW6c5UOYCB/OR/ugtdowlx1FfvTTHScM+yW7G8SxFG3v9XFRRAshvxqnSTTMl8rcwFFhSJm/0HvDBeCbwObDM+nEAr95zsWYVpZLqpdfML9fHQKhULIuASZxXE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(66476007)(6506007)(53546011)(66556008)(33656002)(38070700005)(6512007)(122000001)(76116006)(36756003)(26005)(91956017)(66446008)(38100700002)(66946007)(86362001)(8936002)(2616005)(5660300002)(186003)(316002)(6916009)(7416002)(8676002)(64756008)(41300700001)(6486002)(2906002)(54906003)(83380400001)(4326008)(478600001)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <18EC336AF5600647983E32F5A3A95FF5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8492 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 83467797-0b15-4ee2-75fc-08da8c1ea663 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MBUO010RounXtJdv59cobfAL0UBA+Qfsbd2TFdOnPR+MAl+swupS32FgbwIaj3eF2BT0E7TAgLRRxBlXzucJvE2mxJQA3HShj2Sefyvo+2XR1P3PKPyyFy/KmjuIt0Pu0JHFExkc7khqJpGSnviXiOQU9LKXxlOkTM66F+VQo2Qbz7AEPh0p6E5U1e1qNVMvKFNaqDj5RmBTmTU1Yb4cB4pUXN/kEyMY09NV2CfbyRZ/IOoy5ctRzs6vy/WcXBc3jlw1vDosYai91cZRksQ6n8PgXxe3ZNqKyUh5O53So6Wb5Eoxce3mtqBDdRZO1tu2Y+mN8PO7PGV4QZUkEL/bPjjEiz92lWh2AM3zdhRjYXH2IEctj5g0yPSlQY9+059SiqDZVPr/mIZKEKOzb2t5A2UCLE2sTLG3YS14npM4aniS6s3J+A3dMMgm4+IvT54Gfu/XdAiKMQep40vTPrB4e6O6fHNkpUL8lNbOiMOh0nbpQ5e3TNQ9bdLyDI1/2YzlWMruNiijNmczepC5eGrC53cj0c9eRf5QM8MnYMkY4wPdY9gLvcyO0CWTn0TSxftrmUvpglCjTtwXfUDwPMi4i12LC3ANWfHC46qIr/ijTbWHOkRFsIp7vH8/NZL0BQ//qUOQ/U2x6FJm8nyhcrRg0CfmE6tROLnSfdHtd1VvoOcmYQusPbolfuMffllGR/1af+f7aefgCl1AXor3dEg96R0WO5yCEfrSmPvpdWGXp/QAB/ZYL2l13Uar84z5zj3mzmor2H8Si3Dy47dPp74gfA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(376002)(346002)(40470700004)(46966006)(36840700001)(356005)(2616005)(86362001)(81166007)(40460700003)(186003)(47076005)(336012)(8936002)(5660300002)(6862004)(41300700001)(33656002)(26005)(6512007)(53546011)(2906002)(6506007)(36860700001)(82740400003)(40480700001)(83380400001)(82310400005)(54906003)(36756003)(70586007)(70206006)(478600001)(6486002)(316002)(8676002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 13:34:20.7088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58d535a1-fe06-4f7c-1358-08da8c1ead28 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5998 Hi Xenia, > On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: >=20 >=20 > On 9/1/22 01:35, Stefano Stabellini wrote: >> Patches 1, 4, and 6 are already committed. I plan to commit patches 2, 3 >> and 5 in the next couple of days. >> Patch 7 needs further discussions and it is best addressed during the >> next MISRA C sync-up. >=20 > I would like to share here, before the next MISRA C sync, my understandin= gs that will hopefully resolve a wrong impression of mine, that I may have = spread around, regarding this rule. > There was a misunderstanding regarding the rule 20.7 from my part and I t= hink that Jan is absolutely right that parenthesizing macro parameters used= as function arguments is not required by the rule. >=20 > The rule 20.7 states "Expressions resulting from the expansion of macro p= arameters shall be enclosed in parentheses" and in the rationale of the rul= e states "If a macro parameter is not being used as an expression then the = parentheses are not necessary because no operators are involved.". >=20 > Initially, based on the title, my understanding was that it requires for = the expression resulting from the expansion of the macro to be enclosed in = parentheses. Then, based on the rule explanation and the examples given, m= y understanding was that it requires the macro parameters that are used as = expressions to be enclosed in parentheses. > But, after re-thinking about it, the most probable and what makes more se= nse, is that it require parentheses around the macro parameters that are pa= rt of an expression and not around those that are used as expressions. >=20 > Therefore, macro parameters being used as function arguments are not requ= ired to be enclosed in parentheses, because the function arguments are part= of an expression list, not of an expression (comma is evaluated as separat= or, not as operator). > While, macro parameters used as rhs and lhs expressions of the assignment= operator are required to be enclosed in parentheses because they are part = of an assignment expression. >=20 > I verified that the violation reported by cppcheck is not due to missing = parentheses around the function argument (though still I have not understoo= d the origin of the warning). Also, Eclair does not report it. >=20 > Hence, it was a misunderstanding of mine and there is no inconsistency, w= ith respect to this rule, in adding parentheses around macro parameters use= d as rhs of assignments. The rule does not require adding parentheses aroun= d macro parameters used as function arguments and neither cppcheck nor Ecla= ir report violation for missing parentheses around macro parameters used as= function arguments. Thanks a lot for the detailed explanation :-) What you say does make sense and I agree with your analysis here, only prot= ect when part of an expression and not use as a subsequent parameter (for a= function or an other macro). Regards Bertrand >=20 >> On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: >>> Xenia Ragiadakou (7): >>> xen/arm: gic_v3_its: Fix MISRA C 2012 Rule 20.7 violations >>> xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations >>> xen/elf: Fix MISRA C 2012 Rule 20.7 violations >>> xen/vgic: Fix MISRA C 2012 Rule 20.7 violation >>> xen/rbtree: Fix MISRA C 2012 Rule 20.7 violation >>> xen/arm: processor: Fix MISRA C 2012 Rule 20.7 violations >>> xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations >>>=20 >>> xen/arch/arm/include/asm/gic_v3_its.h | 10 +++++----- >>> xen/arch/arm/include/asm/new_vgic.h | 2 +- >>> xen/arch/arm/include/asm/processor.h | 4 ++-- >>> xen/include/xen/device_tree.h | 6 +++--- >>> xen/include/xen/elfstructs.h | 4 ++-- >>> xen/lib/rbtree.c | 2 +- >>> xen/xsm/flask/ss/sidtab.c | 8 ++++---- >>> 7 files changed, 18 insertions(+), 18 deletions(-) >>>=20 >>> --=20 >>> 2.34.1 >>>=20 >=20 > --=20 > Xenia From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:52:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:52:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396635.636854 (Exim 4.92) (envelope-from ) id 1oTkcl-0008Ir-JR; Thu, 01 Sep 2022 13:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396635.636854; Thu, 01 Sep 2022 13:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkcl-0008Ik-Gp; Thu, 01 Sep 2022 13:52:51 +0000 Received: by outflank-mailman (input) for mailman id 396635; Thu, 01 Sep 2022 13:52:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkck-0008I8-79 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:52:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkcj-0004oT-Pj; Thu, 01 Sep 2022 13:52:49 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTkcj-0003v0-IE; Thu, 01 Sep 2022 13:52:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Ax6EyUP8IlhrPDpDqbHNfbG0obJxlV2kF881bCNVjtw=; b=Noekl/PvEnwq/PBFERKMnqDV8K jVyZDquDKVjL782qGQXovaeTWA/z/lFWF5rZ5u2Cm5yvWuwJ5KxUBZ135g92lqg+6jtcXcdoXQ/86 gV2TAB/0CyRyZStyrI5nGV5F+35SxFRqvldvFX6rgc3AZlsHmwobTJBsVGeyxXJShixo=; Message-ID: <9d328b4d-ef7a-e457-428d-83a2b2351465@xen.org> Date: Thu, 1 Sep 2022 14:52:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v11 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220831024041.468757-1-Penny.Zheng@arm.com> <20220831024041.468757-7-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220831024041.468757-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 31/08/2022 03:40, Penny Zheng wrote: > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; > + > + ASSERT_ALLOC_CONTEXT(); > + > + /* Acquire a page from reserved page list(resv_page_list). */ > + spin_lock(&d->page_alloc_lock); > + page = page_list_remove_head(&d->resv_page_list); > + spin_unlock(&d->page_alloc_lock); > + if ( unlikely(!page) ) > + return INVALID_MFN; > + > + if ( !prepare_staticmem_pages(page, 1, memflags) ) > + goto fail; > + > + if ( assign_domstatic_pages(d, page, 1, memflags) ) > + goto fail_assign; > + > + return page_to_mfn(page); > + > + fail_assign: > + unprepare_staticmem_pages(page, 1, false); Looking at assign_domstatic_pages(). It will already call unprepare_staticmem_pages() in one of the error path. It doesn't look like the latter can be called twice on a page. To be honest, I find a bit odd that assign_domstatic_pages() is calling unprepare_staticmem_pages() because the former doesn't call the "prepare" function. AFAICT, this is an issue introduced in this patch. So I would remove the call from assign_domstatic_pages() and then let the caller calls unprepare_staticmem_pages() (this would need to be added in acquire_domstatic_pages()). Also, I think it would be good to explain why we don't need to scrub. Something like: "The page was never accessible by the domain. So scrubbing can be skipped". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:52:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:52:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396634.636844 (Exim 4.92) (envelope-from ) id 1oTkcg-00082N-CC; Thu, 01 Sep 2022 13:52:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396634.636844; Thu, 01 Sep 2022 13:52:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkcg-00082G-9O; Thu, 01 Sep 2022 13:52:46 +0000 Received: by outflank-mailman (input) for mailman id 396634; Thu, 01 Sep 2022 13:52:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkce-00082A-Lr for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:52:44 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00071.outbound.protection.outlook.com [40.107.0.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 588db6cb-29fd-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 15:52:43 +0200 (CEST) Received: from DB6P18901CA0011.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::21) by GV2PR08MB8100.eurprd08.prod.outlook.com (2603:10a6:150:7a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.23; Thu, 1 Sep 2022 13:52:30 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::f6) by DB6P18901CA0011.outlook.office365.com (2603:10a6:4:16::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:52:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:52:30 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 01 Sep 2022 13:52:30 +0000 Received: from c9f64277024a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ED7C3890-DEBA-47FF-83C5-1AFB85A2B5AB.1; Thu, 01 Sep 2022 13:52:20 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c9f64277024a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 13:52:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB5536.eurprd08.prod.outlook.com (2603:10a6:803:13b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 13:52:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 13:52:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 588db6cb-29fd-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hZOhYPssheq99qoZf4F2PCQfcDzd5N8+xHbQKg/OOtIOW1G/4PBt9rgK7PKZlrJ2tIdx0IUrAGx8OGac6fIx2owUDZbCXhKWHZUTFyMqyC7gl7BJhqGajRE4dnhibnvpz6BvmsM9yoj8IV0T1gN9lV6O8QOxNkRR481QFI8VTlZw8WKn62d4i/P/cdkDlfgU4CsgJgEJewKv/Ok8L9hGu7UK0XNpOelEHB6jOw/i/hAnCxUIibhEXOapjMtlqP2C2u9/d1Mj7K/jp6hz/jPgH+GSw0nPy88wwiskY6Tn562KnOvUy1qhBquSw868mCrZkE5FjxsHCmS/nghYBUKwiw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/IrGcB7LR9nYX8o1o0wOpvZ9jGcCckMW0Z3W7YPZ/Wk=; b=Q2M5v5C26Jwz8+yrep4kC7Pidk7ixLw1DvFrZaJ9DjamWgR4bKtKImVFcUgJ65IFluJP9dU0Xfk2QwO4ljFL9FAi0kX/j6FCD4r5Qqe5ZW8CyntZb1HMXjeJ//ntsVppgocyCSvlb6/Zf/Ve6LiX4S0EU7DDf8Zf3oRNI+hMBNFyvZg9RZtSFAbWBeEiT78PiEM9vqu6/pz/it4zKIDSYLuGWf0RxUQx+nZNHcRJIMOcQQSCxKBhR1FHGVOSDVktdQ8xkX0MtEW+BIkmFOGP+gMNQLgcRM5TAhb1KUjr5edFDC2nPdxgQy4/rT8mdrbtyEKnsjcJ3wNXDu0ACiO6rw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IrGcB7LR9nYX8o1o0wOpvZ9jGcCckMW0Z3W7YPZ/Wk=; b=03TpI/OFpCnLHFZrZqRGyQVcGvRqlvZV5kP/N8MBkn5rK0lh7TvQtxHn86sdoanx/DafdchBMQSh11Nb1w0EwK21lq2fjdLpPAjf0CdteVO1GoyaCihhFyNseqn/1Xsu/6/M9v3TWYlYn668xuANaSnktyAcLkfZqevknT5LRc0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8F+OC8lpLQN9Gijfrvf4k1unIY5wxBgqfR8g8HFDMx/9rSPEEjB633Z7N4t1uA9C1OEiWoiTYZZzpi2ChITdUVbWegk//P51DaycUswSk/G4JGF7M3+moUYyraWJbBA2qeqqRNbFItBrGb/TIl+mZoC0n68odGJmJLHk8Gxd6xirfVPj7FMVkNhVYNml61xUKLnl30S4QZxfml4H6EphPTd9Ep4HP/kieCuprMZZyzkr0q2w7V7QyRQD+Q3mX8yaGX8N8IduDqsZmqyRZuFIc20qrlqpE6ppQd50c8dlLCZAsViRHMvWfcmwXSQKy4wwiPZCXwgCofLRyvMqrpVfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/IrGcB7LR9nYX8o1o0wOpvZ9jGcCckMW0Z3W7YPZ/Wk=; b=STtGODAGikB+49bpOscgZyt61tBtZxSV+PGW1Oxx8rba0JHFCB0tUfyeEH/kvdwXuEsDYpo+Iiv+dlCb40MtYUbHpVawwyN1T9wK3tkQY/+gs8qRzqFN0kzGn91A2iVHtaOcdioq282+czCKUY4EPOwaPEMplXKi2/WV2T/kHcQQ7UESuVOfhiGr3FX9uD8aOmKhvqVAuUQesGMs3RZxKYa7IY3+f5rOoW8BOhrvxVXDiO3pTUnSN45HlX0ZK1IsFr6EWqKblrK1+3kgqCqKkihxt9TsiSge2ud3EZVbWN3jUhgcBaNavI1uv2obcYX6EI5B7YynbvMJJi/jjmOfPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IrGcB7LR9nYX8o1o0wOpvZ9jGcCckMW0Z3W7YPZ/Wk=; b=03TpI/OFpCnLHFZrZqRGyQVcGvRqlvZV5kP/N8MBkn5rK0lh7TvQtxHn86sdoanx/DafdchBMQSh11Nb1w0EwK21lq2fjdLpPAjf0CdteVO1GoyaCihhFyNseqn/1Xsu/6/M9v3TWYlYn668xuANaSnktyAcLkfZqevknT5LRc0= From: Henry Wang To: Bertrand Marquis CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Wei Chen , Volodymyr Babchuk , Michal Orzel Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q2/e0SAgAeAsxCAABaogIACundAgADR+ACAAAOZ4A== Date: Thu, 1 Sep 2022 13:52:16 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <59f69736-a18c-9d08-94dd-791bd264d671@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 26C6BA4B7919314DB9967C9C707CE476.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2ad7b6da-eb8b-4b74-9461-08da8c213674 x-ms-traffictypediagnostic: VI1PR08MB5536:EE_|DBAEUR03FT035:EE_|GV2PR08MB8100:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Al0wzQ5i+3Na9TVn+IKR3cfYtT9aK4c6GFbRlTKgJAvPT0bTJYOHs6TmfyRx81l/9UjdFVquNemlGEvSycMIlKGSMSd/S6oQmw3IEwpq4kkLsySzQSoMU62jCKIma/0e+HDWVPGbcn0X5nvg+WrdEmZrucjVvQ73Afa6s39KiTTLuiBCl3xJAN42ucG47Zr1AxwYFqGoP19AVmpgmSEMQ2+YLcPDumc6N/10yadFtRCKzFNiO3iARMrtc0auKFaV6wPOJ1vly8IitP0jC31u8V5J+LSdCY+eG+4QWDLM6zWdh9BrezOIna4acfM0F1f4gzPQItwIw91goxJ0J6BDrGv8hJXlk+/aLhE183ljy75eR7HNmfn1qnNeQe6m3XmODsk6SOwSw1++UZI5ijtf/4vOkoV21Y0ycTiEESx3hiqc9F0AiaeD+npgcrDpM58Hs1ELoHGw6XyLBuWyDNIwomlrSyJ4BNo3FA1K+udxxrhwqQuF5e6uj5cDCuLtvN1z2Dz9YxHNO6adCNjnsHjz1dQcqK9VNwSI81Pe3/jqs38G3a304OM3T1MIcCh8G42BMnw2MpTefGvem2vIH9WHakq2zr7iIeEkNX1BlLzFfniiNccqL3rkVwzMNZov9Uh9I9GlmP1nq8q8wxPwwu9++7mrJgLycvekLMOyW2M9cYod2TzEN38RiXZ7HXF4IeznAieqnQ194Im3vbN/7XTD5ngLhQlsaz77z7QAnSfCzOaG4MK2qgItsqmJdAEZysIOwkEi6y8v2rMqomjHufdZgQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(76116006)(66946007)(8676002)(64756008)(66476007)(66446008)(55016003)(66556008)(4326008)(52536014)(33656002)(6862004)(5660300002)(8936002)(71200400001)(54906003)(6636002)(316002)(2906002)(478600001)(83380400001)(6506007)(7696005)(41300700001)(26005)(53546011)(9686003)(86362001)(186003)(38070700005)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5536 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 417a0c0d-0049-46fd-b987-08da8c212e74 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PuQcV/aAbDn3lUvyVWgkn59rZFKG8klPv3ecfp6IImOts2F2Yx4N4NGCt4ixJrRNx3gmmDp72rILG5ltF7QWzcAY2l7i5Vp/iWGSpLyHvLudpXR9lTtVrusD4ae/JY+r8yHVcOcbY1y6fqUR4yXF3CrCQibruF5Alu1jWRt4jUx/TPrdkfu0GBxz93UNGUFfocuRQu++sS5wDy7xV67pPyn3JJen4boP1osUZV1KzmDCuANNnOknRoKormFEu5FJGHpcEbPbvkQ3Djjom321CQcFXjWfp55P3sLOSAhR2djhoXo47ui6NbW8kI47GBcIf/QBD+q94szDmZhK7jE/AcRzYBvFOGKcQZONXhzyAMMLmvxLfvasS+vu9CZ8QihIpX2R5ShpGjgE0Z/UNyIJWF60yWpXKF9HmTePm+o8D6HbBuqzKmOIqpcuzqbqyJRxboCSLw40YDqBW3opnCnNBRupmQfJkb7MM/SQxT3zWDmZATjRQ/FS/kmVWdHwFc2P/XvdIYjUR0eYH+d6L1Ln5tIpx+slUSBovul4bKzcm0l57sRwkSKLJnvRub2m7sFa196dtv5hkxvzmMs8bi/paeUfPASTCn4kl5WsVsfuhiPVvLRA3oENW/cSu2FCFhLyYbGkgy69aufzEcrMRkBAmDs2LhThrcMroVQW9kN+QO2MSQ5Ca+v2TFT2BTgMJzGCSYsA0VpU+gmcTIQZsISi5KEZ+nAGsY0ezqYXcxQd+bLdgmY/hHIqKiZWjDDdO9oXh5TaBX9Rbuyjc/UduKh29w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(136003)(39860400002)(36840700001)(46966006)(40470700004)(36860700001)(82740400003)(8936002)(2906002)(52536014)(86362001)(40460700003)(7696005)(81166007)(41300700001)(40480700001)(55016003)(478600001)(53546011)(26005)(6862004)(54906003)(316002)(6506007)(6636002)(356005)(83380400001)(47076005)(82310400005)(70206006)(70586007)(4326008)(8676002)(186003)(336012)(33656002)(9686003)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 13:52:30.1609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad7b6da-eb8b-4b74-9461-08da8c213674 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8100 Hi Bertrand, > -----Original Message----- > From: Bertrand Marquis > > On 1 Sep 2022, at 02:03, Henry Wang wrote: > > > > Hi Arm maintainers, > > > >> -----Original Message----- > >> Hi Henry, > >> > >> On 30/08/2022 08:11, Henry Wang wrote: > >>> > >>> Hi Michal, > >>> > >>> Sorry about the late reply - I had a couple of days off. Thank you ve= ry > >>> much for the review! I will add my reply and answer some of your > >>> questions below. > >>> > >>>> -----Original Message----- > >>>> From: Michal Orzel > >>>> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot > >> and > >>>> heap allocator > >>>> > >>>>> This commit firstly adds a global variable `reserved_heap`. > >>>>> This newly introduced global variable is set at the device tree > >>>>> parsing time if the reserved heap ranges are defined in the device > >>>>> tree chosen node. > >>>>> > >>>> Did you consider putting reserved_heap into bootinfo structure? > >>> > >>> Actually I did, but I saw current bootinfo only contains some structs= so > >>> I was not sure if this is the preferred way, but since you are raisin= g this > >>> question, I will follow this method in v2. > >> > >> This is what I think would be better but maintainers will have a decis= ive > vote. > > > > I think this is the only uncertain comment that I received during the l= atest > > review of this series. I agree that Michal is making a good point (Than= ks!) > but we > > are curious about what maintainers think. Could you please kindly share > your > > opinion on the more preferred approach? I will do that in v2. Thanks ve= ry > much! >=20 > I think it does make sense to put this in bootinfo. I am good with that, then I think I will move this to bootinfo in v2 unless= other objections. Thank you for the input. Kind regards, Henry >=20 > Cheers > Bertrand >=20 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:53:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:53:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396645.636866 (Exim 4.92) (envelope-from ) id 1oTkdU-0000dn-SI; Thu, 01 Sep 2022 13:53:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396645.636866; Thu, 01 Sep 2022 13:53:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkdU-0000dg-Pf; Thu, 01 Sep 2022 13:53:36 +0000 Received: by outflank-mailman (input) for mailman id 396645; Thu, 01 Sep 2022 13:53:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkdT-0000dD-8e for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:53:35 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2070.outbound.protection.outlook.com [40.107.223.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75d90ecc-29fd-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 15:53:32 +0200 (CEST) Received: from MW4PR02CA0030.namprd02.prod.outlook.com (2603:10b6:303:16d::18) by DM4PR12MB6423.namprd12.prod.outlook.com (2603:10b6:8:bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 13:53:28 +0000 Received: from CO1NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::50) by MW4PR02CA0030.outlook.office365.com (2603:10b6:303:16d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:53:28 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT097.mail.protection.outlook.com (10.13.175.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 13:53:28 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 1 Sep 2022 08:53:26 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 1 Sep 2022 08:53:25 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75d90ecc-29fd-11ed-82f2-63bd783d45fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8MJ86/FeVl114m7dcXVLhLkwWvMY4LKxeVOHfMnanvumXXgwxxp8diOVWQEW5Mok/hz7dgSa1Hp2TXd/YHN31oStSeoMfAabghEuSFYQ1mOjtxnGZWUDbz5l7Ea53lCkuYAvC0zvFmcfqEyZQCVps//vnm616bSNTYBc/ZHyahR9VE6tApkSIRioBucqz7pUk1MNhMadtrUBWEtQhCFSeG3QxNScSw6rjGqRqIpAQCn+7hVLD0tbrqKanUP4uTTgJsPCtevBkORJe+56vrtOdcs2aXcJhi3FafJkgukS9JsFCk43LAnqyNZZQqrvgHb2xKDICLL4jHAZoQ8sniR0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lx3tJ9cpj9Ag3aU8VPbTK8ECXjkWWHeQ09wBQmrRHSI=; b=MsgNluJIU1dTuIWqAGZbpujmGGx9ZB3QU8DJUKt91PrLTZEY4RTFe/VKnLu8c/suGQI4oGJrIIi6tMjtoWz77sumSgpHw9kGd/WUswngi1fP5QEvWkfxAJ6Kr9NRfA5wWJ8sCdperJ+x1dmx4fFV9xLDhyqTsmVgOcIhxvmVyvy+DnQi6WF46cm+bFnhhovPZ1LLiTyW6SIS4Ce3CYuUCOJD58AvHaIATJKNsuwkifQkKv4IDpi17xmxhdgleXspsx9d8hgCQVxDmcmBMIOC89qgXIdWqtXkP5qUZ/T6+so78rSgfgJbrDMju5uKcm4INDCN7htfDVnh+fk3Q6/pBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lx3tJ9cpj9Ag3aU8VPbTK8ECXjkWWHeQ09wBQmrRHSI=; b=mRL1XhVedzFXSm01K/Iu2fG+2chdKT0yJjr//qW85CK3s9/TbNIdRKXKotyd6bxchefJpXmx1oqqM/okUk/cdqqRv2mQhojDj7MtsUwx+zOgG6HVueIp8rfjXzCuDAv8a6TlMnoBDb83lqpbYvB3DMaGXPxHV8Dl3LlemHOu3Wc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <99eff10e-6b7b-df74-5017-7628c0b0bd7a@amd.com> Date: Thu, 1 Sep 2022 15:53:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Content-Language: en-US To: Rahul Singh , CC: , Stefano Stabellini , Julien Grall , Volodymyr Babchuk References: <4ae16201df27aee274a3d740128812b118c252b3.1662023183.git.rahul.singh@arm.com> From: Michal Orzel In-Reply-To: <4ae16201df27aee274a3d740128812b118c252b3.1662023183.git.rahul.singh@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1d57e5a0-dccb-4e7d-cb0a-08da8c215907 X-MS-TrafficTypeDiagnostic: DM4PR12MB6423:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MDZNAxiP07mrRREXOJoOI2C5GSwVrMwsxq1TxQZjUiFebAvVQRN7NZpt/GuYy97RhxRz8NC38e39W9UMIb5s1DtOdwaI6KLWd4YLF6xmFKKMIpfGmBw1A1rJbzN8AXaIN18an7E0uOUSzVN2UJ6gZ+wNNrLNFTQR0sxKd8aKq7FOApNFW0czedMBKji/QL8nCKSRvjeJjKlFgATXnYZMWZDEUGy/ulgmEKdfbWDa6J7SrJWG/Y8bonuEL/LZwd4H5olfySNhJgwxOvYK+pTMTiQk2jeDVYPFAmbySUfXJGnmnS7sR2954qBggYtbtEvMjxzgAs7jLf23oxVU10Wqb4f6ubyER+/nOFRAS/uNIIaQeWS03RwQIdo2025ym3uoALQZjehHbaqpRz5g+xvngM2F0A/uSwgUlosV+nOKO41s/PiMK7ES7PIPz8Q46K/8jZQhH8DUImsssenaw9GJ3JcmDZO4f2DVnDNxijoqYLg1Ah9Sy8Hg+1Q8vQy1wJhrge7UE5h94M5T7M867o14Pra8j7zJZJ4Dal0+8TWqzDFvSn4AtN/OJcNz/yPiuGEzdHiRleLOSO/ABaYUnN3Y0zImDGIrqZKMzaKYpyeZiGRbQ3gOk+dHl7mT3rzO/bA1mnZMMbkMJ/n0bQBj58wZD6mI/QDfSXo/GpJPmjD9pOTHss50A3k7C4ADyRPgWeYczuNQ4HGEsx0h47yRO5WLaKXg0Q8NW2P2824QfazS9lrYkRj4nYThgCxapeY4yZPnaQG5oygxvX8h3KH2ayQVEBSAdySXdmzyp0a7wjYyZDouLrIz3ro+l7tvg1a3t4wzMOsVzZ+nE6aDYStAhE1epA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(36840700001)(40470700004)(46966006)(82310400005)(40480700001)(82740400003)(16576012)(110136005)(316002)(4326008)(8676002)(478600001)(70206006)(70586007)(36756003)(54906003)(31686004)(4744005)(8936002)(336012)(5660300002)(41300700001)(44832011)(31696002)(86362001)(2616005)(356005)(186003)(47076005)(426003)(40460700003)(81166007)(36860700001)(26005)(2906002)(53546011)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 13:53:28.0120 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d57e5a0-dccb-4e7d-cb0a-08da8c215907 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6423 Hi Rahul, On 01/09/2022 11:13, Rahul Singh wrote: > > Restrict the maximum number of evtchn supported for domUs to avoid > allocating a large amount of memory in Xen. > > Set the default value of max_evtchn_port to 1023. The value of 1023 > should be sufficient for domUs guests because on ARM we don't bind > physical interrupts to event channels. The only use of the evtchn port > is inter-domain communications. Following the previous discussion, I think the only missing piece is an explanation that 1023 was chose to follow the default behavior of libxl. Apart from that: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Sep 01 13:58:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 13:58:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396652.636877 (Exim 4.92) (envelope-from ) id 1oTkiF-0001Pq-EP; Thu, 01 Sep 2022 13:58:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396652.636877; Thu, 01 Sep 2022 13:58:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkiF-0001Pj-Bj; Thu, 01 Sep 2022 13:58:31 +0000 Received: by outflank-mailman (input) for mailman id 396652; Thu, 01 Sep 2022 13:58:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkiE-0001Pd-UK for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 13:58:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkiE-0004vJ-JT; Thu, 01 Sep 2022 13:58:30 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTkiE-0004NQ-DC; Thu, 01 Sep 2022 13:58:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Ykf3sbryLkFxHO/PnqXCNaoUDr3Li6kShYu7MCj51I0=; b=4cixfn14Qak0LdfC+M203swzqt loyt3kAGdvdg8ZyPWI/jkkZ1Hb0Jc2F35O2JDWDfKbbOtCiCKdSK1qGo+0My6B2j0t5r9MtVjCpDf gcu8MK7yoL1BDMlzvGCruRFpyBApXGkHLNTMKCA4UTPlo8Nh+2HgS+wvGgmGoueBf5Bg=; Message-ID: Date: Thu, 1 Sep 2022 14:58:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Stefano Stabellini , Henry Wang Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/08/2022 02:04, Stefano Stabellini wrote: >> size_t estimate_efi_size(unsigned int mem_nr_banks); >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index 500307edc0..fe76cf6325 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -73,6 +73,8 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes); >> >> domid_t __read_mostly max_init_domid; >> >> +bool __read_mostly reserved_heap; >> + >> static __used void init_done(void) >> { >> /* Must be done past setting system_state. */ >> @@ -699,8 +701,10 @@ static void __init populate_boot_allocator(void) >> #ifdef CONFIG_ARM_32 >> static void __init setup_mm(void) >> { >> - paddr_t ram_start, ram_end, ram_size, e; >> - unsigned long ram_pages; >> + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; >> + paddr_t reserved_heap_start = ~0, reserved_heap_end = 0, > > INVALID_PADDR or ~0ULL I would strongly prefer the former. It is more difficult to understand what's the value means in the latter. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:02:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396658.636888 (Exim 4.92) (envelope-from ) id 1oTklk-0002wh-1L; Thu, 01 Sep 2022 14:02:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396658.636888; Thu, 01 Sep 2022 14:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTklj-0002wa-UF; Thu, 01 Sep 2022 14:02:07 +0000 Received: by outflank-mailman (input) for mailman id 396658; Thu, 01 Sep 2022 14:02:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkli-0002wU-UR for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:02:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70089.outbound.protection.outlook.com [40.107.7.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a8d2392b-29fe-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 16:02:05 +0200 (CEST) Received: from DB3PR06CA0035.eurprd06.prod.outlook.com (2603:10a6:8:1::48) by PAWPR08MB9759.eurprd08.prod.outlook.com (2603:10a6:102:2ee::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Thu, 1 Sep 2022 14:02:02 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::83) by DB3PR06CA0035.outlook.office365.com (2603:10a6:8:1::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 14:02:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 14:02:02 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 01 Sep 2022 14:02:02 +0000 Received: from 19c5739e72f0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7AFD6882-BA24-4CDA-95BC-A9B3C6921203.1; Thu, 01 Sep 2022 14:01:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 19c5739e72f0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 14:01:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB9794.eurprd08.prod.outlook.com (2603:10a6:102:31e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Thu, 1 Sep 2022 14:01:49 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 14:01:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8d2392b-29fe-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=C6+YE+uy5+ov6Rst3LIGY2xvihyEqZ1WiuFroiv1BpID5esZwlhHO3gJd1kb9K9wXnFofNTL8pTAWtfWl5PrlwiZW4SYSZ+PeGNKcNQ/dCeHwjDdV0VOadYhlpMXPCkm6zj5dm66RB0wMOSyxRYtX9ojsn60CojvO2/wUkwxLVV5E2DJTjlH2G5yFS/Ftp2ZIBIRHiDsIZqNwReI0RioLgGSP90GvskRjRrD3ejqzZdqj6MO6SwRRg8wsaqH2zN1J5n9ZQ0ezaItMfkywwtJ6+PcoIj1mT9GybyWQ2Zw5qwh4/dHMSNK5RK7AFCiDZF9YiuVWWcGmndv5NPTjBTOxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wCPMpw+EYjLC56Bj4h/VlKmjqs41r2bMepqHO+rVH/4=; b=U//WPsOxQREzhcNWYkkFnDXzVEeLG1+aBz5WGwFFJXc5rqKT30JHlekwRNO3vlsJ0NdbbSbRCW1xEdciQF8Y2EvbT9DvHNqQVboNL6ax7FVT5yKh++l35h0w00/hFYJvCvU7fk2C43m5Wbp71tnA+dEWrAgP+nrN+C8qvwl2Zwo9l31Wz3VpAzXHfU/DT5E+62aA/FqF+x5L0fx1gWScL01uckLekAU2n5b5XCMJZbbSIL8Bp+f90v7QLTAq5Sbrq/zFdXPRwHSRp9JXeLFTlCOYyZk4uVu1HknWB0fJr7fI8C+TwLrOqDFuIEJRk890Xnu78vu2C3YqNspZb+d+yQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wCPMpw+EYjLC56Bj4h/VlKmjqs41r2bMepqHO+rVH/4=; b=0NIGSGyRcLIINRexXQsUzNhnogpo1iWohAdQiH51S7e3oITlmDf2XylXGtKlWeZgF8mAv+VkGqtLC8xEJY5dL4Txxq4pjEhCYDxxxVQ8gR0P3ZNlS8B0/BHyCzuZ8wfphw/Ykiqy3KT+t36azQeXuKH05Wc+5bigbbSLTnGUfEk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjvarLlXFDSiQqs2fXALkSm5fQH9zURrPa44YpFLbJyFk4Y9FnFzNTWTtOayJ8PMA4eJCNS3iMbzKzE0Tcu7fNAaisEk7ZFWRfhVwdieQR40IVKoP6To9jVUW84RZngaJYGZgAHDXol00qd9uhIlbcEb+mP2ncWpgvVDqFYTEEUaheG/shKUfx5iQHe+AJ+YtLPabQQEYBSJw4MQwanLeuST+oDX6NwtYRnxjgCxgH+4eOfFTg2RYu2KiGauCeU2TyeFSkZRAa4u82rB7G7rjDTlFkvMUN45wcXqLmUCZcgQhkDV+bjS+Q3LrOxGUkZxIkWOy4lSKVleDq2FnOtCkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wCPMpw+EYjLC56Bj4h/VlKmjqs41r2bMepqHO+rVH/4=; b=oOnmstP/dYXZm18F4KDrxrCUQ2f/qqp94Q9OeZRDUKau9wKj4NorXA4K0Kr7+5M9BY04aWzCjgMaiifadQ1/7Y7saPdE7+6v1TWswNTb5e8Lsnihe9Yu0/TzQGBMgv62DcJbFrg51G9wrXR8d/UIaN1eW1HCLki94LmY8w4KUDKc60HGjxl/Dby9Qgiz5zSUjnJhEG5xxBST0jUrls/64NV6Ll7SbZDTNKmJZgyWISqRPtdQHYjxB8Hse/eQIpoahM2omPsXHaWvIO4rEuQtADfGRlYfcWuQtZkPmToNapdgl68Dd0yvkJzzJMMfmowi3Dd1JdJIuikc38DN6xzVmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wCPMpw+EYjLC56Bj4h/VlKmjqs41r2bMepqHO+rVH/4=; b=0NIGSGyRcLIINRexXQsUzNhnogpo1iWohAdQiH51S7e3oITlmDf2XylXGtKlWeZgF8mAv+VkGqtLC8xEJY5dL4Txxq4pjEhCYDxxxVQ8gR0P3ZNlS8B0/BHyCzuZ8wfphw/Ykiqy3KT+t36azQeXuKH05Wc+5bigbbSLTnGUfEk= From: Henry Wang To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Stefano Stabellini Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q3GqcQAgAP89wCAAACAYA== Date: Thu, 1 Sep 2022 14:01:48 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C5EC30BCACE04843A9C3BED6115F7904.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7397353d-c5b1-4ab4-8b39-08da8c228b87 x-ms-traffictypediagnostic: PAVPR08MB9794:EE_|DBAEUR03FT057:EE_|PAWPR08MB9759:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mBpmUnnIQlGINjMod4BH7sigkdekJX8uQJPtIC/8bSJMSes22oVdN8PsOZX0v9k6OJX8t2K0/XmWpDTgU5DN9EKvrq5cBMCVJZHOL06r9BzU0tpLzTj+8/vU8/99e2wXJWqKfmg4HTFmBdRhsa6KWvSB2I0nEgrPfkSVPAMm51fvtYW5n+kU9ie+B/LVmbhjQGfVGAnNLiiCD0IWgtaeEyHA9f4Q8XV5/NyBWG06tnHkC+4mwcaCEOAZotAPPXy5I5ftIrvD1/mQo++AJomqhKJ/02C4aMGHMQG8tEo+Rr3Un40MyCwyneOzd4SANmB3C/yy7Q0NsMqFkbu66nO6RSAW01b9sf7zI80OsaqEwtQ4MO4I5QLMRyDxA+vXGm5AApTYVKLu1595/2I6nvG927GUf42DQw9MBNClv37x6eSoxZ9h1x2fvVcRbV9QDsMewvYHGR0+OYFu2zwPJ9kA7+ZYNJF8qN4pPEnrvmWjOZ49ffIy2XXZrevpF2PRa+uaB0IDmMuIJ+szZJRBtPLcRHueTlrC6YjCDQVBzkxdrOIbsvJaMY38QzxEbBKM/F54fDnidGywCXvLF3DcNfcO+hDdEuE9+11tgsRFT+GlHRIejPCHgwkSsIMVQcL8iha8dyVmu7Aqwb5ddetpGn3c1uIVGBZMWfZM9ain+86PkGuGRYn1ILT/8Q+KbzujtOlUcEoGbmPooAVaIIDySgO4TNN1qZWde4OFoNiN8E0iAavKayEl7d8my3fGTI5spe15 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(478600001)(9686003)(5660300002)(71200400001)(55016003)(83380400001)(316002)(186003)(54906003)(6916009)(38100700002)(76116006)(38070700005)(122000001)(4744005)(33656002)(66446008)(64756008)(4326008)(8676002)(66556008)(66476007)(26005)(7696005)(8936002)(52536014)(6506007)(66946007)(41300700001)(86362001)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9794 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a2b60729-d345-41d3-1d7e-08da8c228382 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pz8Rr54yAMYTWa/1R64jv1Rwfmefoe0s4xzxFW8wsIAC+FJ+EWq2TSEmDrsPZ/lXyqVB1DOsn3VrYJBHM4l2yUcMDkkoqJbTeFq9O+6eyH7v6y/lvfIsk0M72abiqt6AaOKga0k3CCHm1+i2bzvMDdcoWt68uUEaRdgBmObXs10ol6R8uplKMJctMwP08SASSGggTRbbYeX0aQ5lhn5yxdsRxYSI/xLdytIzitbPI1AQEUSRfJPfiQE+Os4IwLXvM3IVJvOrkBYLYTQLXDjGn3wWJzRR5V+UvjjUv/c7gCXkiOEP1oX4eDVP7V0t09xyapRKUsPNkIMWPzm8RfbuL2X1NY/gu1A7v7ewDhjJp3rJLrTp8b4xSElV9MskBBKqm/jr58uCcVB32mCiVgqQma4jwmbS5ZxiAGXrTIFuOEfyJuavS2jd3JnQEgZxBgvlxtuk908YgVnsGlFE85+1ZjGFT5facCJBoUaJPgj4gF6YLYyEb9F9bQDi0rn1A2ttnx668N11iYypO8aG5wpMYGOT2Rlov24d/ieq8zQ82MYt6mNqIa1XTf7reVR3W6j7YbnBnRKygLA9FVL0hjDBZpT6D9CXAuNU55jZqDCqa37/NIIB8SRPzTNgITP371D0hzhZVvwoIH/WLLiHAVb8fwJ0AUV33uas7ttWC8hkNxo1CXobjWRYU/QQ2r0+wEyhK2GFdJb+W80K0WKtv/WMgJY+E7pFMSNwr8SihcoWdeOC5qBPS3qDLpDOL/kl6/GPIBy8gVKg4/We2yPH+1I82A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(136003)(46966006)(40470700004)(36840700001)(41300700001)(70206006)(86362001)(336012)(70586007)(2906002)(4744005)(6506007)(52536014)(7696005)(8676002)(8936002)(40460700003)(6862004)(36860700001)(5660300002)(478600001)(40480700001)(55016003)(83380400001)(107886003)(4326008)(47076005)(186003)(33656002)(81166007)(356005)(82310400005)(9686003)(82740400003)(316002)(26005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 14:02:02.3882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7397353d-c5b1-4ab4-8b39-08da8c228b87 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9759 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+ICsgICAgcGFkZHJfdCByZXNlcnZlZF9oZWFw X3N0YXJ0ID0gfjAsIHJlc2VydmVkX2hlYXBfZW5kID0gMCwNCj4gPg0KPiA+IElOVkFMSURfUEFE RFIgb3IgfjBVTEwNCj4gDQo+IEkgd291bGQgc3Ryb25nbHkgcHJlZmVyIHRoZSBmb3JtZXIuIEl0 IGlzIG1vcmUgZGlmZmljdWx0IHRvIHVuZGVyc3RhbmQNCj4gd2hhdCdzIHRoZSB2YWx1ZSBtZWFu cyBpbiB0aGUgbGF0dGVyLg0KDQpUaGFua3MgZm9yIHRoZSBpbnB1dC4gWW91IG1lYW4gdGhlIElO VkFMSURfUEFERFIgY29ycmVjdD8gWWVhaA0KdGhpcyBpcyB0aGUgb25lIHRoYXQgSSB1c2VkIGlu IG15IGxvY2FsIHYyLCB3aWxsIHNlbmQgaXQgdG9tb3Jyb3cgYWZ0ZXINCmRvaW5nIHRoZSBib290 aW5mbyBjaGFuZ2UuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4g DQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:02:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:02:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396662.636898 (Exim 4.92) (envelope-from ) id 1oTkmO-0003Su-AO; Thu, 01 Sep 2022 14:02:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396662.636898; Thu, 01 Sep 2022 14:02:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkmO-0003Sn-7k; Thu, 01 Sep 2022 14:02:48 +0000 Received: by outflank-mailman (input) for mailman id 396662; Thu, 01 Sep 2022 14:02:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkmN-0003RV-Du for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:02:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkmN-00056M-5Y; Thu, 01 Sep 2022 14:02:47 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTkmM-0004kC-Tr; Thu, 01 Sep 2022 14:02:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FFAK7nHdNWDiWnTVw/4D2l4Kl3CXvrzokvIOjXAVFtA=; b=1ysSVGUQi8Q/zVsG9ot8OKbsaC pMLslnc/V8dMJ1H11R488qt11hcmeMWPkN/iW00s5ZvJC/wIMK1Gh+eYKGX+B2g6nI9qocF8mlyqg Lx2f4eG9YYQdRk1R/Wlazfje5YIP+RG5d5vwMxNynTpDNL4D1zxj1JgKV7uZPFQklhyY=; Message-ID: <65586e94-8b3e-0ac8-b738-b15c1aa3e682@xen.org> Date: Thu, 1 Sep 2022 15:02:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Stefano Stabellini References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/09/2022 15:01, Henry Wang wrote: > Hi Julien, > >> -----Original Message----- >> From: Julien Grall >>>> + paddr_t reserved_heap_start = ~0, reserved_heap_end = 0, >>> >>> INVALID_PADDR or ~0ULL >> >> I would strongly prefer the former. It is more difficult to understand >> what's the value means in the latter. > > Thanks for the input. You mean the INVALID_PADDR correct? That's correct. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:15:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:15:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396672.636909 (Exim 4.92) (envelope-from ) id 1oTkyK-000525-ER; Thu, 01 Sep 2022 14:15:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396672.636909; Thu, 01 Sep 2022 14:15:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkyK-00051y-Bl; Thu, 01 Sep 2022 14:15:08 +0000 Received: by outflank-mailman (input) for mailman id 396672; Thu, 01 Sep 2022 14:15:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkyI-00051s-N7 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:15:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTkyI-0005KW-7m; Thu, 01 Sep 2022 14:15:06 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTkyI-0005Kw-14; Thu, 01 Sep 2022 14:15:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6UG6kfG35vl7kMRaKycuahk569HwHQA5HASlfy1hjBM=; b=F/tmBArcdbpuiA+cX2Bm9SmgDF wTwbI5IV/O7aqZ+2G+AjfIf4g1N5W8plp+eTLX0G84X46L2JDackV9tQLZlntxjBCmMY5efwEO4pK HYzFTalThXdWEw12uGuNlP9MdrHfBDR9UDlRsNnhlfScieruL9BYEIo75zaIwhYqTbE4=; Message-ID: <2f99f0ee-6311-219a-2820-5e79d64b7d75@xen.org> Date: Thu, 1 Sep 2022 15:15:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message Content-Language: en-US To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <454DC664-25A3-4DA2-99F5-BAB20FD8A590@arm.com> From: Julien Grall In-Reply-To: <454DC664-25A3-4DA2-99F5-BAB20FD8A590@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/09/2022 11:27, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 24 Aug 2022, at 3:58 pm, Julien Grall wrote: >> >> Hi Rahul, >> >> On 24/08/2022 14:53, Rahul Singh wrote: >>> Backport Linux commit dc898eb84b25c39ea46f28c48a169bdbd0e2c7e0 >>> iommu/arm-smmu-v3: Fix l1 stream table size in the error message >> >> We have a tag for this (see Origin). If you use it, then… > Ok. >> >>> Original commit message: >> >> You don't need to add "original commit message" here and the content is exactly the same. > Ok. >> >>> iommu/arm-smmu-v3: Fix l1 stream table size in the error message >>> The actual size of level-1 stream table is l1size. This looks like >>> an oversight on commit d2e88e7c081ef ("iommu/arm-smmu: Fix LOG2SIZE >>> setting for 2-level stream tables") which forgot to update the @size >>> in error message as well. >>> As memory allocation failure is already bad enough, nothing worse >>> would happen. But let's be careful. >>> Signed-off-by: Zenghui Yu >> >> AFAICT, you didn't make any change to this patch. So the "From:" should still be from Zenghui Yu. For an example how to do backport, see >> 9c432b876bf518866d431bda73f2be1250f688eb "x86/mwait-idle: add SPR support". > > Ok. >> >> Also, it would be good to clarify whether they are clean backport and required some changes (other than context changes). I assume they are clean backports? > Yes all patches are clean back port. > > Here is the commit msg please have a look once. Once you confirmed I will modify other patches and send it for review. It looks fine to me. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:23:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396678.636921 (Exim 4.92) (envelope-from ) id 1oTl6F-0006Vh-8W; Thu, 01 Sep 2022 14:23:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396678.636921; Thu, 01 Sep 2022 14:23:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTl6F-0006Va-5r; Thu, 01 Sep 2022 14:23:19 +0000 Received: by outflank-mailman (input) for mailman id 396678; Thu, 01 Sep 2022 14:23:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTl6E-0006VQ-LA for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:23:18 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20046.outbound.protection.outlook.com [40.107.2.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f264bd9-2a01-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 16:23:17 +0200 (CEST) Received: from AS8PR04CA0142.eurprd04.prod.outlook.com (2603:10a6:20b:127::27) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 14:23:15 +0000 Received: from AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::27) by AS8PR04CA0142.outlook.office365.com (2603:10a6:20b:127::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Thu, 1 Sep 2022 14:23:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT008.mail.protection.outlook.com (100.127.141.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 14:23:14 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Thu, 01 Sep 2022 14:23:13 +0000 Received: from 760ab40789d8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 261AD0B5-5ED1-4697-8726-82BA02569921.1; Thu, 01 Sep 2022 14:23:06 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 760ab40789d8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 14:23:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAVPR08MB9403.eurprd08.prod.outlook.com (2603:10a6:102:300::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Thu, 1 Sep 2022 14:23:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 14:23:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f264bd9-2a01-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=k7N1gQVJGJsLQDlab716RFb8jDCqwAgdlYBDyXLaER2LFSqUluS4EY6Wv2pcF2GIDk99EtrAZPK9HwjsfbBd7NzZ4QkylLM3rihfCp+PiLm4V/inzxG9VanLX7BmP05u2l3apLK9PNUl4lUvSe7e9GU48N4GpiHP6zHt0C9fT2fEDqDlk1emkMrxldjyRBlPXNgMNZEJiZnS5d3Oc1eNySkU1tU9nAEshdVbG1GSUQzfQQ6/9uWOE3Au77IikIWQ52Zh71Y3zufQg8YxCTwYHV/pa5hoM9JfFGZJX1RjpYCpjhxA0FToYWl3Zv950sGPkWgZfovv2f3QsY4Tuakgrw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8STocPzQAsp/QtFbLD3tT4iT/1jCPMQUajeWWkRb4Ck=; b=dhfbSS5dW40eh61vMf3WuZhxueNX7aaZBZkbPJf+tAFVdVxLDFYfPX/sf/u9LzLVU/8l3p/ZpYJYKPdb5AIzBFniabilD9W02EGtOVWXIUL9aMkShfLsV9K7JajizrYoH/5b4DS24b6BwxfmHycxEgZ+/NR5AxkLQxWezt9BbXme8rDfn/7AvCY9m/rFhrRimx03WoBDUyb8VFx5HYmCYAvPYdWR/gGXVHjVB9pnCrwdjEpzYHzrsJ5autcwmUbOdAImc/pq3v8xsmx7d9tkqm8KnaPztCU7t7pCLtAcLXGsuiN8PmjvAHqjxvFridR+xBC4raryCcNENCJWjMj3jw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8STocPzQAsp/QtFbLD3tT4iT/1jCPMQUajeWWkRb4Ck=; b=9ZkgH+KidC3ftaYMcbCea33ZkkhKOfmZKEHdoGItOhf+NR1ziPsBvthClLnir1ydXxeHKkKmzegTJa7hS2VSIExF+RQ4knijqcU2flBNOIr+N7m+oe3y4wQJM75NcOEKWfq1NsdeheLdaM6hBx7DtAB9As0VlUjPDJDHXVlEyGs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3883857637e5dcb3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Usgk69EHp/rI4cQdWOH4+PjDT3D+MuPmux1jIaKTwmeJx3d4jvnIBMD5TNqjli+UgjqVNC+3u+Yni2YaxR3LTReaVSi5NGB3bhVlkuGQQuaQgKeo7KuXyZ26LTXe7CjEcKuxvIEMXECL+WajNlNGj1PG6vbl4NAM2Aipl+G7cEUBn2zsf+T32ksj/VkB3PTbTTjwoN9VvudpY0DxufDgJUT1maqhGF5Ru8OLKs5GQmy7VswpQKa7TBWFfuAMQhWztbONhjUZHtvfJV2GsQjD2F8NCxD8KWGggi/ATHTTEGeRxnd8/xxVcA528SsyUMWgisKYfjsjR0LUl+gs1TUfZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8STocPzQAsp/QtFbLD3tT4iT/1jCPMQUajeWWkRb4Ck=; b=Zt/2yoRVcGQP9hGTl6NI1VcLlSvD/NCFJSexTSq/FN2tyF+eDP7hCDgdMAZTmLyNV1E2+6ITNMmc2Mf0bg9+2NBOmW9Mm7YQRhfWjA572zdXdmQmgyQwqXUVVpHx1a7DrUMYOam0mkDoTALd+j0NOcvuesqzSxwU2a3y5xBABak8bcAKHNWlqyQAKVPLnaSckI6es4L+J5tuCzUXYoQsXOUwx4tT4zt6ullEhpzMUgatSnhqaqMT8eTumZk34Bd5YtwDNeUH2tKpfE3XYzOi0G4JaNc5+ypUa4BOBS06zX/I3DgyWFXqewIpeD0ORS95+JcQfTcoWXEtYYPHEgvhHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8STocPzQAsp/QtFbLD3tT4iT/1jCPMQUajeWWkRb4Ck=; b=9ZkgH+KidC3ftaYMcbCea33ZkkhKOfmZKEHdoGItOhf+NR1ziPsBvthClLnir1ydXxeHKkKmzegTJa7hS2VSIExF+RQ4knijqcU2flBNOIr+N7m+oe3y4wQJM75NcOEKWfq1NsdeheLdaM6hBx7DtAB9As0VlUjPDJDHXVlEyGs= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Wei Chen , Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] xen/arm: Add xen/arch/arm/efi/stub.c in .gitignore Thread-Topic: [PATCH] xen/arm: Add xen/arch/arm/efi/stub.c in .gitignore Thread-Index: AQHYroB9tR3Qy3uVT06PvIm0QNgWhK3Kv7KA Date: Thu, 1 Sep 2022 14:23:05 +0000 Message-ID: <42AC631E-BC9F-4581-8983-37D765BAF537@arm.com> References: <20220812191930.34494-1-julien@xen.org> In-Reply-To: <20220812191930.34494-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e85dea6e-168f-4910-700d-08da8c258182 x-ms-traffictypediagnostic: PAVPR08MB9403:EE_|AM7EUR03FT008:EE_|DU0PR08MB7788:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G+/fnvfgu0wkNi4OpXMkrSWPSj0PTlCXSGema6/W08KqZdkz2u3FLxF9r5mQIo48ffrqA61XN54YkoPZq2bnDQD+c9gFWvxJnASH4rsDJRiLDhpEQT9mpiZp85t4wPkKZtH+JYFJWUlIdwaOaa6x6byQGt3HdX6jg8sgiwf+xEl4KOOs/v8fs/FWKI5f+dvQXhjdt3GrO8955bWJVxb73VSpDVt8+yr6ygHMYAYRE0TBP3krdRFw8cvQUfR92YGY2v6Vmvour4mWPUZlPdGVGdj0TClN9nPAvQHth2IAVNcbw7FK5MKGUlOHqRx0nkaseLLS8mAPkGOzTi2HFi3pCNAzd1KuFAyg0QCpLU2949wnVV733vA65o7kG4PuLRFkPv9DdX96Eix3zXvSCL3RwqCr6i5gdyF3UABsctAM68W7NcHQ06pWjRzkw1gXOUq2++XrmwpALBE/9FnPuB5W0KLWtWxGs0zLbBbpZVMZ4VpgDEAXL5yW4Hcosa68D56sa/vb/wrO3slAOJNIbLzABRfB7Osivdpy15IvFIUdjUPsyq3nnd69Oj7HJUjJSlCsIFK49vF7zdP0nLW8vbGJEIY6VegUuSemcvSYek1ObZ57adCB5HNLu3hSoIe13iuSX0dSsauji1T7SQCEXJAIW7jRjoLFn3NDB0T4eVv28l34MMm5PcBMQz6X2L02zcw/KwhsKwYpqKaj36jtjszlgiC+8Hn2AU4A9Y0T4TUV5LpG0s26AryHMLKr6am+fY7/emWTn6eWVbikvGXc9tj5OTjJL55R8lyOgYbpblQ+ru/n84xdUOtn9VvFOS/AznqRU45onF1IL2yM0enrrixpgw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(136003)(366004)(396003)(41300700001)(53546011)(66446008)(64756008)(66476007)(2906002)(4744005)(91956017)(6506007)(8676002)(6486002)(8936002)(76116006)(5660300002)(2616005)(66946007)(86362001)(478600001)(66556008)(4326008)(186003)(33656002)(6512007)(26005)(122000001)(71200400001)(316002)(38100700002)(38070700005)(6916009)(36756003)(54906003)(142923001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3DFB4764090B0E47B5D4384F80DEF576@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9403 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 456ae11c-9241-4385-d985-08da8c257c6a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zr68zhLj9oiCcjBawrsA1zpfx0eFiXZre1Ao99PMmH9yBUJj4vahmxnHftVc9W2HSDEAP9gxLVzRJKCQ8Rh0Iomo17lPV98Rv1IaNlOYzn4SOwmeiFu815j6F+QXvNMudnmSXRAz5EYvNNgXYyfUAL2MNDRz2Fq6/wcgsRmlro/Cs6KoZqJ3f0OIBYEzAAkM1X9ReGB/qlLIl1+Nc2agSlHoZm/yiJK1dS1neoDE8olTKigjFx3dTkBIkV1ii9AtGGLu3/BWGhqi/5uBsSYqJpEbyEihDLYfqgLxOP4RCWKguoDU6sbBt+Vk0zNA0YO0wVMXWGHjagR1YGyD6hecRiJolClKtwVLxYoNG7GufZngnn/bQVifCj2xdMhVret3WkhjEW/kwa/5iIoHg55QliHluWFGXuZ7nmYdMU5bvr7MFG+MUS4onBjsyP7ls2aBlO7xGUg1kAfZoGMkkmKlaDcG6MPFnHBuO0t1f5w3v2bnEFwCyrSFY2jHBlvHbEOVQs8XnnQuuKo18KJ66yH1iOQERmyB/twpIg39qvxxpUroULLYzbvRdf81O/aY4Nv6VDllNYbtNi7o+vHm4yfmpb8SrWbh98N4uD000SBvqCEyBOK+s36sNOw5jtZySWL5C2ao/ANmxTR0/t9PYal6nddSMMA+rb52EyhjhrHWPW7eo4FX6PxL2LWBtjJ17xcBsb8aF9FYwy8XcKYw/gmGsgF7DOK/YvBVBUGu1emJThVqv+sjSo8TLFs9TMVdh5C7K0Wzkzz330rWroqyqJDKUxIzD7uv8TLnlQTuNtjSOYE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(36840700001)(40470700004)(46966006)(478600001)(6506007)(33656002)(4326008)(8676002)(41300700001)(316002)(36756003)(6486002)(54906003)(82310400005)(6512007)(26005)(53546011)(86362001)(2616005)(81166007)(36860700001)(336012)(47076005)(186003)(2906002)(8936002)(40480700001)(6862004)(5660300002)(70586007)(4744005)(70206006)(356005)(40460700003)(82740400003)(142923001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 14:23:14.0209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e85dea6e-168f-4910-700d-08da8c258182 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Hi Julien, This one passed through my filtering, sorry for that. > On 12 Aug 2022, at 20:19, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Xen build system the symbolic link xen/arch/arm/efi/stub.c. So we want > to ignore it. >=20 > Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm") > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/.gitignore b/.gitignore > index ed7bd8bdc76c..0d53eb304993 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -295,6 +295,7 @@ xen/.config > xen/.config.old > xen/.xen.elf32 > xen/System.map > +xen/arch/arm/efi/stub.c > xen/arch/x86/boot/mkelf32 > xen/arch/x86/boot/cmdline.S > xen/arch/x86/boot/reloc.S > --=20 > 2.37.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:23:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:23:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396684.636932 (Exim 4.92) (envelope-from ) id 1oTl6s-00073r-MJ; Thu, 01 Sep 2022 14:23:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396684.636932; Thu, 01 Sep 2022 14:23:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTl6s-00073k-Iu; Thu, 01 Sep 2022 14:23:58 +0000 Received: by outflank-mailman (input) for mailman id 396684; Thu, 01 Sep 2022 14:23:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTl6p-0006VQ-Ue for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:23:57 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b52fe8d0-2a01-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 16:23:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b52fe8d0-2a01-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 10:23:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662042233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JsB2G8WqLnYprEF0GcA9GFFIGkQht/MFH67dN0NC9t0=; b=P+qdlVJWY093c1JvjMpoBsAhuM3mvnI3jUKrYjXhcXjA7JDkTxBBu4A2hC17CCO8ZZ5R3D rLH5U4BLaxZ5HSxD5hP6U1jUXGFLfAJiihxtZ+Hfa0QaSzmc2WzHuvOvPKzjVyoQ9DuTBc CcLrAriFlVtUQ4Ne/7Ga0hI19yi31Mw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: David Hildenbrand Cc: Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: > On 31.08.22 21:01, Kent Overstreet wrote: > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > >> On Wed 31-08-22 11:19:48, Mel Gorman wrote: > >>> Whatever asking for an explanation as to why equivalent functionality > >>> cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > >> > >> Fully agreed and this is especially true for a change this size > >> 77 files changed, 3406 insertions(+), 703 deletions(-) > > > > In the case of memory allocation accounting, you flat cannot do this with ftrace > > - you could maybe do a janky version that isn't fully accurate, much slower, > > more complicated for the developer to understand and debug and more complicated > > for the end user. > > > > But please, I invite anyone who's actually been doing this with ftrace to > > demonstrate otherwise. > > > > Ftrace just isn't the right tool for the job here - we're talking about adding > > per callsite accounting to some of the fastest fast paths in the kernel. > > > > And the size of the changes for memory allocation accounting are much more > > reasonable: > > 33 files changed, 623 insertions(+), 99 deletions(-) > > > > The code tagging library should exist anyways, it's been open coded half a dozen > > times in the kernel already. > > Hi Kent, > > independent of the other discussions, if it's open coded already, does > it make sense to factor that already-open-coded part out independently > of the remainder of the full series here? It's discussed in the cover letter, that is exactly how the patch series is structured. > [I didn't immediately spot if this series also attempts already to > replace that open-coded part] Uh huh. Honestly, some days it feels like lkml is just as bad as slashdot, with people wanting to get in their two cents without actually reading... From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:29:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396692.636943 (Exim 4.92) (envelope-from ) id 1oTlCV-0007nz-A7; Thu, 01 Sep 2022 14:29:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396692.636943; Thu, 01 Sep 2022 14:29:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlCV-0007ns-6x; Thu, 01 Sep 2022 14:29:47 +0000 Received: by outflank-mailman (input) for mailman id 396692; Thu, 01 Sep 2022 14:29:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlCT-0007nm-Si for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:29:45 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 862abccf-2a02-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 16:29:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 862abccf-2a02-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 10:29:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662042584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M1aDaZlKYEwz8CxoGUE2hJszPL7mnQtqrJRQw3RcAgQ=; b=IK9QhIOZDhvhIHgjJAvozZeyNVUxpRDuv2a80UYwf9PmUNDsSXvx244cHMitGbjR3T3iGp 7sTtqClKi3PdI+46+oiLp/x5eTOLPULJGYd7PsGYsaj8KjDdrdJudl3cyWqngQc55MFiX/ TzPtdYtHcCsYBcEyFw2g+cdlpMBvH8I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Peter Zijlstra Cc: Mel Gorman , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901142937.vsnq62e6gqytyth2@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 09:00:17AM +0200, Peter Zijlstra wrote: > On Wed, Aug 31, 2022 at 11:19:48AM +0100, Mel Gorman wrote: > > > It's also unclear *who* would enable this. It looks like it would mostly > > have value during the development stage of an embedded platform to track > > kernel memory usage on a per-application basis in an environment where it > > may be difficult to setup tracing and tracking. Would it ever be enabled > > in production? > > Afaict this is developer only; it is all unconditional code. > > > Would a distribution ever enable this? > > I would sincerely hope not. Because: > > > If it's enabled, any overhead cannot be disabled/enabled at run or > > boot time so anyone enabling this would carry the cost without never > > necessarily consuming the data. > > this. We could make it a boot parameter, with the alternatives infrastructure - with a bit of refactoring there'd be a single function call to nop out, and then we could also drop the elf sections as well, so that when built in but disabled the overhead would be practically nil. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:32:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:32:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396698.636954 (Exim 4.92) (envelope-from ) id 1oTlF8-0000kD-OL; Thu, 01 Sep 2022 14:32:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396698.636954; Thu, 01 Sep 2022 14:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlF8-0000k6-Ja; Thu, 01 Sep 2022 14:32:30 +0000 Received: by outflank-mailman (input) for mailman id 396698; Thu, 01 Sep 2022 14:32:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlF7-0000jy-7w for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:32:29 +0000 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e77e4b9e-2a02-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 16:32:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e77e4b9e-2a02-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 10:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662042747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hzpqzF+cHXDydzBO/Ouha4xSMTzYETXF6uFA22HjvEI=; b=NZoXkZHKLzeUxAk3ak7Pb8vsW9ZNZzRTwKtA+BC4xdSYkJ+ynByJWkg/Sh230HugdVWRmg yoek0j7jmp5SFliaDUrwdj/qDw5fARM6MIEEXIMmkE2NnaJO1XhB2/CCfm1A1hYZKgVq4b dPipMi7tKAPAIcwcMtS9bvz5Flf6OaU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Peter Zijlstra Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/30] Lazy percpu counters Message-ID: <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > +static void lazy_percpu_counter_switch_to_pcpu(struct raw_lazy_percpu_counter *c) > > +{ > > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__GFP_NOWARN); > > Realize that this is incorrect when used under a raw_spinlock_t. Can you elaborate? From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:37:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:37:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396704.636964 (Exim 4.92) (envelope-from ) id 1oTlJV-0001Nw-8O; Thu, 01 Sep 2022 14:37:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396704.636964; Thu, 01 Sep 2022 14:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlJV-0001Np-52; Thu, 01 Sep 2022 14:37:01 +0000 Received: by outflank-mailman (input) for mailman id 396704; Thu, 01 Sep 2022 14:36:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlJT-0001Nj-EB for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:36:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlJT-0005gx-4A; Thu, 01 Sep 2022 14:36:59 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTlJS-0006H7-U2; Thu, 01 Sep 2022 14:36:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hOU+0GqXqBnQg3obRG/wlRki4qclTQwVxK80943F0So=; b=CtFBOnoXVK/YXGXh3kZSBmG/4B stZ9eug36WuGW9q6MuV/TCmS8QAxUTA5LJwU0lYbBgmquTD76LmQnAcO+nd9OpejqlbiHt/nR+aS0 l8WVyFNyVcoC0HxVFnEIEkny7ZFq0ieffii/TH9pexf36tKLTN3+oMaKDJwLJWPsc+ns=; Message-ID: <9b5afd5e-ec5c-bac6-9ad0-9dd9663aa705@xen.org> Date: Thu, 1 Sep 2022 15:36:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220824073127.16762-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 24/08/2022 08:31, Henry Wang wrote: > This commit introduces the reserved heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > A new boolean field `xen_heap` in `struct membank` is added to store the > configuration telling if the memory bank is reserved as heap through > `xen,static-mem` property in device tree `chosen` node. > > Also, this commit introduces the logic to parse the reserved heap > configuation in device tree by reusing the device tree entry definition typo: s/configuation/configuration/ > of the static memory allocation feature: > > - Add a boolean parameter `xen_heap` to `device_tree_get_meminfo` to > reflect whether the memory bank is reserved as heap. > > - Use `device_tree_get_meminfo` to parse the reserved heap configuation > in `chosen` node of the device tree. > > - In order to reuse the function `device_tree_get_meminfo`, the > return type of `process_chosen_node` is changed from void to int. > > A documentation section is added, describing the definition of reserved > heap memory and the method of enabling the reserved heap memory through > device tree at boot time. > > Signed-off-by: Henry Wang > Signed-off-by: Penny Zheng > --- > The name of the device tree property was chosen because we want to > reuse as much as the device tree parsing helpers from the static > memory allocation feature, but we would like to hear the upstream > reviewers' opinion about if using "xen,static-heap" is better. > --- > Changes from RFC to v1: > - Rename the terminology to reserved heap. > --- > docs/misc/arm/device-tree/booting.txt | 46 +++++++++++++++++++++++++ I have skipped the documentation and looked at the code instead. > xen/arch/arm/bootfdt.c | 49 +++++++++++++++++++++------ > xen/arch/arm/domain_build.c | 5 +-- > xen/arch/arm/include/asm/setup.h | 1 + > 4 files changed, 89 insertions(+), 12 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..e064f64d9a 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -378,3 +378,49 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > + > +Reserved Heap Memory > +==================== > + > +The reserved heap memory (also known as the statically-configured heap) refers > +to parts of RAM reserved in the beginning for heap. The memory is reserved by > +configuration in the device tree using physical address ranges. > + > +The reserved heap memory declared in the device tree defines the memory areas > +that will be reserved to be used exclusively as heap. > + > +- For Arm32, since there can be seperated heaps, the reserved heap will be used > +for both domheap and xenheap. > +- For Arm64, since domheap and xenheap are the same, the defined reserved heap > +areas shall always go to the heap allocator. > + > +The reserved heap memory is an optional feature and can be enabled by adding a > +device tree property in the `chosen` node. Currently, this feature reuses the > +static memory allocation device tree configuration. > + > +The dtb property should look like as follows: > + > +- property name > + > + "xen,static-mem" (Should be used in the `chosen` node) > + > +- cells > + > + Specify the start address and the length of the reserved heap memory. > + The number of cells for the address and the size should be defined > + using the properties `#xen,static-mem-address-cells` and > + `#xen,static-mem-size-cells` respectively. > + > +Below is an example on how to specify the reserved heap in device tree: > + > + / { > + chosen { > + #xen,static-mem-address-cells = <0x2>; > + #xen,static-mem-size-cells = <0x2>; > + xen,static-mem = <0x0 0x30000000 0x0 0x40000000>; > + }; > + }; > + > +RAM at 0x30000000 of 1G size will be reserved as heap. > + > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index ec81a45de9..33704ca487 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -64,7 +64,8 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > static int __init device_tree_get_meminfo(const void *fdt, int node, > const char *prop_name, > u32 address_cells, u32 size_cells, > - void *data, bool xen_domain) > + void *data, bool xen_domain, > + bool xen_heap) It sounds like to me, we want to have an enum rather than multiple boolean. This would also make easier... > { > const struct fdt_property *prop; > unsigned int i, banks; > @@ -96,6 +97,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, > mem->bank[mem->nr_banks].start = start; > mem->bank[mem->nr_banks].size = size; > mem->bank[mem->nr_banks].xen_domain = xen_domain; > + mem->bank[mem->nr_banks].xen_heap = xen_heap; > mem->nr_banks++; > } > > @@ -185,7 +187,7 @@ static int __init process_memory_node(const void *fdt, int node, > void *data) > { > return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, > - data, false); > + data, false, false); ... to understand the two "false" here. > } > > static int __init process_reserved_memory_node(const void *fdt, int node, > @@ -293,7 +295,7 @@ static void __init process_multiboot_node(const void *fdt, int node, > kind, start, domU); > } > > -static void __init process_chosen_node(const void *fdt, int node, > +static int __init process_chosen_node(const void *fdt, int node, > const char *name, > u32 address_cells, u32 size_cells) > { > @@ -301,16 +303,40 @@ static void __init process_chosen_node(const void *fdt, int node, > paddr_t start, end; > int len; > > + if ( fdt_get_property(fdt, node, "xen,static-mem", NULL) ) > + { > + u32 address_cells = device_tree_get_u32(fdt, node, > + "#xen,static-mem-address-cells", > + 0); > + u32 size_cells = device_tree_get_u32(fdt, node, > + "#xen,static-mem-size-cells", 0); > + int rc; > + > + printk("Checking for reserved heap in /chosen\n"); > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: node `%s': invalid #xen,static-mem-address-cells or #xen,static-mem-size-cells\n", > + name); > + return -EINVAL; > + } > + > + rc = device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > + size_cells, &bootinfo.reserved_mem, false, > + true); > + if ( rc ) > + return rc; > + } > + > printk("Checking for initrd in /chosen\n"); > > prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); > if ( !prop ) > /* No initrd present. */ > - return; > + return 0; > if ( len != sizeof(u32) && len != sizeof(u64) ) > { > printk("linux,initrd-start property has invalid length %d\n", len); > - return; > + return -EINVAL; This is technically a change in behavior for Xen (we would panic rather than continue). I am happy with the proposal. However, this doesn't seem to be explained in the commit message. That said, I think this should be split in a separate patch along with the ones below (including the prototype changes). > } > start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); > > @@ -318,12 +344,12 @@ static void __init process_chosen_node(const void *fdt, int node, > if ( !prop ) > { > printk("linux,initrd-end not present but -start was\n"); > - return; > + return -EINVAL; > } > if ( len != sizeof(u32) && len != sizeof(u64) ) > { > printk("linux,initrd-end property has invalid length %d\n", len); > - return; > + return -EINVAL; > } > end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); > > @@ -331,12 +357,14 @@ static void __init process_chosen_node(const void *fdt, int node, > { > printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n", > start, end); > - return; > + return -EINVAL; > } > > printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end); > > add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); > + > + return 0; > } > > static int __init process_domain_node(const void *fdt, int node, > @@ -358,7 +386,8 @@ static int __init process_domain_node(const void *fdt, int node, > "#xen,static-mem-size-cells", 0); > > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > - size_cells, &bootinfo.reserved_mem, true); > + size_cells, &bootinfo.reserved_mem, true, > + false); > } > > static int __init early_scan_node(const void *fdt, > @@ -383,7 +412,7 @@ static int __init early_scan_node(const void *fdt, > device_tree_node_compatible(fdt, node, "multiboot,module" ))) > process_multiboot_node(fdt, node, name, address_cells, size_cells); > else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) > - process_chosen_node(fdt, node, name, address_cells, size_cells); > + rc = process_chosen_node(fdt, node, name, address_cells, size_cells); > else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) > rc = process_domain_node(fdt, node, name, address_cells, size_cells); > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..6f97f5f06a 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1038,8 +1038,9 @@ static int __init make_memory_node(const struct domain *d, > if ( mem->nr_banks == 0 ) > return -ENOENT; > > - /* find first memory range not bound to a Xen domain */ > - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) > + /* find first memory range not bound to neither a Xen domain nor heap */ > + for ( i = 0; i < mem->nr_banks && > + (mem->bank[i].xen_domain || mem->bank[i].xen_heap); i++ ) > ; > if ( i == mem->nr_banks ) > return 0; > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 2bb01ecfa8..e80f3d6201 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -27,6 +27,7 @@ struct membank { > paddr_t start; > paddr_t size; > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > + bool xen_heap; /* whether the memory bank is reserved as heap. */ We have multiple heap: static, domain, xen. AFAIU, 'xen_heap' refers to both domain and xen whereas 'xen_domain' refers to 'static'. In line with what I wrote above, I think it would be better if we have a single field 'heap' which is an enum listing the type of heap. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:43:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:43:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396710.636975 (Exim 4.92) (envelope-from ) id 1oTlPd-0002qU-Tc; Thu, 01 Sep 2022 14:43:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396710.636975; Thu, 01 Sep 2022 14:43:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlPd-0002qN-Qn; Thu, 01 Sep 2022 14:43:21 +0000 Received: by outflank-mailman (input) for mailman id 396710; Thu, 01 Sep 2022 14:43:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlPc-0002qH-Lc for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:43:20 +0000 Received: from out2.migadu.com (out2.migadu.com [2001:41d0:2:aacc::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b1a5855-2a04-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 16:43:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b1a5855-2a04-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 10:43:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662043398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOHSW3FDpFxopIM9LbojW3h32sP5UuFpnfFE44cGJM8=; b=DYXiWVC0vy4teLKZQztFxvW1KXEKgsv/W8GLVht+MMEppphvXl1beWtjobZtBs7ufDfyf1 /Az+HrU+UnzwRWndfnxlx9U/cWoea5qHWVDTW/7rGq5kcj9ODLnVIRzkPJn+RdzRKpoYMZ 5Z1XsUa8iU3hq/D237KbAKpwZVrQllY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Peter Zijlstra Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901144311.ywhhdaigweyy7eo6@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 09:11:17AM +0200, Peter Zijlstra wrote: > On Tue, Aug 30, 2022 at 02:49:16PM -0700, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This adds the ability to easily instrument code for measuring latency. > > To use, add the following to calls to your code, at the start and end of > > the event you wish to measure: > > > > code_tag_time_stats_start(start_time); > > code_tag_time_stats_finish(start_time); > > > > Stastistics will then show up in debugfs under > > /sys/kernel/debug/time_stats, listed by file and line number. > > > > Stastics measured include weighted averages of frequency, duration, max > > duration, as well as quantiles. > > > > This patch also instruments all calls to init_wait and finish_wait, > > which includes all calls to wait_event. Example debugfs output: > > How can't you do this with a simple eBPF script on top of > trace_sched_stat_* and friends? I know about those tracepoints, and I've never found them to be usable. I've never succesfully used them for debugging latency issues, or known anyone who has. And an eBPF script to do everything this does wouldn't be simple at all. Honesly, the time stats stuff looks _far_ simpler to me than anything involving tracing - and with tracing you have to correlate the start and end events after the fact. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 14:48:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 14:48:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396718.636987 (Exim 4.92) (envelope-from ) id 1oTlUR-0003Zv-Jd; Thu, 01 Sep 2022 14:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396718.636987; Thu, 01 Sep 2022 14:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlUR-0003Zo-GF; Thu, 01 Sep 2022 14:48:19 +0000 Received: by outflank-mailman (input) for mailman id 396718; Thu, 01 Sep 2022 14:48:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlUP-0003Zc-TM for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 14:48:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1bcc8ff2-2a05-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 16:48:16 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC7C161DD3; Thu, 1 Sep 2022 14:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DDEAC433D6; Thu, 1 Sep 2022 14:48:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bcc8ff2-2a05-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 10:48:39 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/30] Lazy percpu counters Message-ID: <20220901104839.5691e1c9@gandalf.local.home> In-Reply-To: <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-4-surenb@google.com> <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Sep 2022 10:32:19 -0400 Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > > +static void lazy_percpu_counter_switch_to_pcpu(struct raw_lazy_percpu_counter *c) > > > +{ > > > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__GFP_NOWARN); > > > > Realize that this is incorrect when used under a raw_spinlock_t. > > Can you elaborate? All allocations (including GFP_ATOMIC) grab normal spin_locks. When PREEMPT_RT is configured, normal spin_locks turn into a mutex, where as raw_spinlock's do not. Thus, if this is done within a raw_spinlock with PREEMPT_RT configured, it can cause a schedule while holding a spinlock. -- Steve From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:07:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396725.636998 (Exim 4.92) (envelope-from ) id 1oTlmq-00069k-5c; Thu, 01 Sep 2022 15:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396725.636998; Thu, 01 Sep 2022 15:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlmq-00069d-2i; Thu, 01 Sep 2022 15:07:20 +0000 Received: by outflank-mailman (input) for mailman id 396725; Thu, 01 Sep 2022 15:07:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlmo-00069X-94 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:07:18 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c336c4d5-2a07-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:07:15 +0200 (CEST) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-202-xZVN_o7tM8GA-eH8zf09NA-1; Thu, 01 Sep 2022 11:07:13 -0400 Received: by mail-wm1-f72.google.com with SMTP id ay21-20020a05600c1e1500b003a6271a9718so9988652wmb.0 for ; Thu, 01 Sep 2022 08:07:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9e00:fec0:7e96:15cb:742? (p200300cbc7079e00fec07e9615cb0742.dip0.t-ipconnect.de. [2003:cb:c707:9e00:fec0:7e96:15cb:742]) by smtp.gmail.com with ESMTPSA id a6-20020a5d4d46000000b00226dedf1ab7sm9303786wru.76.2022.09.01.08.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 08:07:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c336c4d5-2a07-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662044834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n51zgqgBl470PB0vgcZT4BRIRHbxoQSrqhNCiStba2E=; b=ObDiSLMfQ9MXDmrGnlC1LZZNZWle7oseddosLR97XfdCMFtq6NiEU84hrrYb+YIX+PVJ95 lMwvk1ghQb+NVS3Q/a+XVJLVsH26CMN+7TkcbwgomSX2qCI1PUwBoHSpVpz7igyTQh4Sou 4X/G4lPfE32Y+MmVTqFcZL1HZ3QkZEY= X-MC-Unique: xZVN_o7tM8GA-eH8zf09NA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=n51zgqgBl470PB0vgcZT4BRIRHbxoQSrqhNCiStba2E=; b=dzzpvXOyPjeqLESS9FEyHH5VqIAr2JV0YT80SXaKkd6R47pory0tF0ST/BiySsTRrc V+Us2eAtGWDo7rJAjCv/dMQMKsVB2SkSw7LSQIIleK77HDytmy9IpuquMlwCk2TP5PwM c2IcTWAxdf1J0SDV875PSl2uV+2tblJO2nwa6PxKNkGCX5iM28CQhW0VWUEhx7cp7FPM LNIJEfQw8BrDlXjpRg0QOnX97xw2S/8Wna+v2mKvCNrk2a0kmAlW75u95q71heWRjoe8 +sqkmx8/GzvgaKzanwyb9jLtFnwnXzEZK+wthVIfZOCA8r/gvdEjfq+N+b7XNI02IUUB uMwg== X-Gm-Message-State: ACgBeo2bibmcFkHu4AGvZhLwsFcRR390XxRwu1mBjKiOtDgUR9BZyRQT 1TxZxEUKcdqKJCsmSQDkOecTKZshPv8MjSNdle/YDBt8kI345XGsT4yI1Yr+c7ig0INpHJZv2xl cfRCcdMCoCsk8NQ2t0IIlPjKhyuI= X-Received: by 2002:a7b:ce13:0:b0:3a6:34f8:e21d with SMTP id m19-20020a7bce13000000b003a634f8e21dmr5628133wmc.22.1662044831145; Thu, 01 Sep 2022 08:07:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR4MsTHzosmA7E7hGiZjHmjlTUlB0s2DWeDkp38EpmRPnqXeJG3hehRWe5SqC6TIKnfqy7LhVg== X-Received: by 2002:a7b:ce13:0:b0:3a6:34f8:e21d with SMTP id m19-20020a7bce13000000b003a634f8e21dmr5628080wmc.22.1662044830813; Thu, 01 Sep 2022 08:07:10 -0700 (PDT) Message-ID: <78e55029-0eaf-b4b3-7e86-1086b97c60c6@redhat.com> Date: Thu, 1 Sep 2022 17:07:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Kent Overstreet Cc: Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications In-Reply-To: <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01.09.22 16:23, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: >> On 31.08.22 21:01, Kent Overstreet wrote: >>> On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: >>>> On Wed 31-08-22 11:19:48, Mel Gorman wrote: >>>>> Whatever asking for an explanation as to why equivalent functionality >>>>> cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. >>>> >>>> Fully agreed and this is especially true for a change this size >>>> 77 files changed, 3406 insertions(+), 703 deletions(-) >>> >>> In the case of memory allocation accounting, you flat cannot do this with ftrace >>> - you could maybe do a janky version that isn't fully accurate, much slower, >>> more complicated for the developer to understand and debug and more complicated >>> for the end user. >>> >>> But please, I invite anyone who's actually been doing this with ftrace to >>> demonstrate otherwise. >>> >>> Ftrace just isn't the right tool for the job here - we're talking about adding >>> per callsite accounting to some of the fastest fast paths in the kernel. >>> >>> And the size of the changes for memory allocation accounting are much more >>> reasonable: >>> 33 files changed, 623 insertions(+), 99 deletions(-) >>> >>> The code tagging library should exist anyways, it's been open coded half a dozen >>> times in the kernel already. >> >> Hi Kent, >> >> independent of the other discussions, if it's open coded already, does >> it make sense to factor that already-open-coded part out independently >> of the remainder of the full series here? > > It's discussed in the cover letter, that is exactly how the patch series is > structured. Skimming over the patches (that I was CCed on) and skimming over the cover letter, I got the impression that everything after patch 7 is introducing something new instead of refactoring something out. > >> [I didn't immediately spot if this series also attempts already to >> replace that open-coded part] > > Uh huh. > > Honestly, some days it feels like lkml is just as bad as slashdot, with people > wanting to get in their two cents without actually reading... ... and of course you had to reply like that. I should just have learned from my last upstream experience with you and kept you on my spam list. Thanks, bye -- Thanks, David / dhildenb From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:17:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:17:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396731.637009 (Exim 4.92) (envelope-from ) id 1oTlww-0007dW-5o; Thu, 01 Sep 2022 15:17:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396731.637009; Thu, 01 Sep 2022 15:17:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlww-0007dP-26; Thu, 01 Sep 2022 15:17:46 +0000 Received: by outflank-mailman (input) for mailman id 396731; Thu, 01 Sep 2022 15:17:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlwu-0007dJ-9K for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:17:44 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a04c846-2a09-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:17:43 +0200 (CEST) Received: from FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) by AM7PR08MB5368.eurprd08.prod.outlook.com (2603:10a6:20b:103::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 15:17:39 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::ee) by FR3P281CA0061.outlook.office365.com (2603:10a6:d10:4b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Thu, 1 Sep 2022 15:17:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 15:17:38 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 01 Sep 2022 15:17:37 +0000 Received: from 8e2c5ef8123f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5D144BEE-D443-4E2A-839C-5D6C32FDB07B.1; Thu, 01 Sep 2022 15:17:26 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e2c5ef8123f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 15:17:26 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB9441.eurprd08.prod.outlook.com (2603:10a6:10:457::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 15:17:24 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 15:17:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a04c846-2a09-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KTLw1S0dz4U4iGieDeHWuk8I80w65RVGp1IhD5TtuJ0GACwarNKnbejqaGvJCmJUvKOFX4R2FcCcDdd7Ig21izoB1RZZh115vwMyIpgG2BEAb+aHYAgy4nF887enLUSlyQQRvOL2c54+ablVpeOIBierqg/m0/skhwb2Ht/s9ks7Tz7O20K2ccYdg5eBhMYcly6RMNXplBBAC7Vb/394EbbGe1W/CGt2NedfdJlrnsolRh5pAgwBKLH8VyZ4hciXdxzklottA4cX24rGicnIe+xqwKCtMaVP9sb1xCvuQO2eNLzaX5DI1ptPwdfzLpkjdIZHr0cigpec7T4qo2XVmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lket6qHQ/Tzb4J0rZ8JxetF93xrK0ohOk8rdFqOIaso=; b=jIaASWkQL5sWY5eastISmVAtYXboP8QOmQl3cM9PCcxZD1AARzsEvgCAVTSL4+8Qj19SGCP/lN9pahYls5RKH5KtLJW+MFxOPjnDs0ji60Q8XNDZFLydI+0Utvy3FGlT1o9PbQV4JH1dzm9KQPoOsae5cBqk417QN7K9v+xYuwh3mTaRmS4GDHrc7jjTsoROyJr7BztxeFEwls7vhs59Esm1xE0UpYH01uLKtrv2mykqB6C0YOx7G1zJ0U4bcKniXjADXFIXPzPttR7l5DXmG7UeQa5i1/gvxGrLc/eIyx+9xpyBuEhMpZAODJVXnmZi75HdWS8bwuJoB+Q020yZEA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lket6qHQ/Tzb4J0rZ8JxetF93xrK0ohOk8rdFqOIaso=; b=9tK1UHZT5VXBdyAvj2t2wzRsgWApr4utVzK0xV3gY6ixoUGJ8niP0DwwtxjLqAe4AvHbHJ8K8WAIy0UP4RPea4jKhPolzkfgdupWEC56Jx5M+MUJpZurKb/XtFcrUaduYTdomfBtpPJlHz0Llndggi/9IW5ECpGbSoFuLXSxBq8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f288f12510204072 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVWumy0UIZ4gflU/DN0TfTLJ/9hjo6lPUd19wx5vQpR/hVpQjS76SEq9fuM9LM15R+B0+T+EpzfVJPTYX/10Prox87TB5tFOKQirxk56Pv+rUJQGzhNSIQKIDjr3KTrU31SD6EQJWJ0p+L0ZvavUV5r2wQNaQRglotj63HcOJxUxC3emDflsRGJprJliPNH2T+1Ng0nbHfmiFC4vb7ZS2eN4XkCVyibBDcUhQgJZb/m6IOl3eFhTVmgH6v+QyQnlGwkz3eR+vhvRJImLVAqLOg/djXoCq8Ym353EGaa6dS+FYu0Gto2kTWEQjn1JmC6CMdJOHflvVIR/lF+o9UN1zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lket6qHQ/Tzb4J0rZ8JxetF93xrK0ohOk8rdFqOIaso=; b=E6bCSUrD4SXLkWAKMgSca5H+UajiYlo9gA+3rejsgv8sp8zPyA1AH2uZpjgMe8Dkt5gbHsHWxyIYYMSdcT4AmJ3e0axHV1FePGciIpIcyTvW8FQln+qDobXEW2tO33FAb9WnGayLSCe7p05vELKRYHo60eKvAxDTspK0WsRUTL5kqYj9Fa7A1XVHuY3X/xP3R7SlhkCFLgJEQCbS2w5hVos7NwdvL0pX6r/ih/KmwrIUWS0HMdfx8nzba+IYtWZ3pg05ZdFMvXY8JuMSzE3XDcsS9jOBB4fQmD49UdvuDW4DaKHRhqsZ1iJZcBBgZSrvikWCVS/m0U98Gpx6jAKEsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lket6qHQ/Tzb4J0rZ8JxetF93xrK0ohOk8rdFqOIaso=; b=9tK1UHZT5VXBdyAvj2t2wzRsgWApr4utVzK0xV3gY6ixoUGJ8niP0DwwtxjLqAe4AvHbHJ8K8WAIy0UP4RPea4jKhPolzkfgdupWEC56Jx5M+MUJpZurKb/XtFcrUaduYTdomfBtpPJlHz0Llndggi/9IW5ECpGbSoFuLXSxBq8= From: Bertrand Marquis To: xen-devel CC: Henry Wang , Jan Beulich , Julien Grall , Stefano Stabellini , Andrew Cooper , Juergen Gross , Anthony PERARD , George Dunlap Subject: Push 4.17 Feature freeze and Code freeze one week later Thread-Topic: Push 4.17 Feature freeze and Code freeze one week later Thread-Index: AQHYvhXwY5ksNZUEbUKzv0CjRBnFYA== Date: Thu, 1 Sep 2022 15:17:23 +0000 Message-ID: <2745BA23-B42E-49E2-89A2-59A0ED70388F@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0d839000-9443-4a60-dab1-08da8c2d1b22 x-ms-traffictypediagnostic: DB9PR08MB9441:EE_|VE1EUR03FT061:EE_|AM7PR08MB5368:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Qt7IBazubFZoTl7nK/HoREZrIWmYlyWwsHa5Mf8kFuvoZTdsjV08t1XdVV2KcP7FwETJ0xfPi0Q7TQZRpcNKTU+sUFtEpSyO3JzYtW1m3k2hSSMOTGNC5uctqrIfZ5DAiTxwPIjYmw5T0sCzFolA2aYbl8LCgEOE5lz8j78ho6b1vHf1py6qEn09zj5wL+OWiEncuD89/rbqVEDzN8LzJS89ngEXFNEDpgPX71VDRMhVfUKH17FZQHQoUGoC4l8oKN82vgwy7hlfyl0dr2H3m7pn/6QBxYa+9vCgMDOnnKUMGazqjshV0VAymoe2vW4vBvRabXn0ebXfISn+gZqn8wcqB/Sw9ReE9l3t7tYN/l5XE9B8Z1XhSIorGg0wB1l9ctd7KIBdYh+OHa1icKUu3Vvr7a6b2sSrU+gvyGOPxoJesSNdsrtI4rkdso3zL6Rr4Radb+0uW12GtgSIoXViigGPz+UzC1zykjGjjxxCoKDsskIW/KWbu2cA+YvaWWauYEpDCGREknsiUJVKzeSThI1lF3QChkYD3tyl3gDac6Y7o8nepAV0nS8whOavglBa4rtvkkRvWWiD5JL1JmJ4je+UXWPL0cwBIQCTgPc0hAu4n8T+4bv+zqgG32h5XpoSY8INJSlTr0og3dWtlhssd3q2XEdWsqBNowbjLnDeUhqoQ+yVjF/Lq3ASpA82UoLsNEO7LLmojE98w1HlL4CEBRS7aX64S/gM1O3JdJ3yYhgG/UcpdZ2Hlp/iDwCKNiUbqF1ciMNMRBG1CaTjzIPYDIf+X9M6AqNKCtHJcYAmzlw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(33656002)(186003)(558084003)(36756003)(41300700001)(26005)(478600001)(6512007)(2616005)(6506007)(6486002)(66556008)(76116006)(66446008)(64756008)(66946007)(71200400001)(66476007)(5660300002)(91956017)(316002)(38070700005)(86362001)(2906002)(8936002)(8676002)(54906003)(6916009)(4326008)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9441 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ee4bb652-77b3-4fce-8629-08da8c2d1296 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gwpqTNTk1SV1g5pjt9PgCccjp/W8efL2NTxJXgsej9ajOKf86knxOhLN4q34L/lzIIo8AZU8jkwQIzeAfWmLsAvu6H6FjSpneBSX+i0ZSJdfdSq01A7zDBnoswvb2f3YdSXysbDmIOLQSbvsLo7KOh832ChAMmR4i6JukV/gUKuW5UgddztMinLyWGvnOeld06LFLw2pbyf1JDc2BT7+Kt1Hx9X76MeR6yJKgTOWcdwZ5S2xkM27nA2MCh/voNgL/yWObAr9pfLadPEUyTVoN0T3lcPfpBRt+aTDfQQCRQXj+92/2GoVMHmjwucWYF1EQ2o2pzYEs0AZ2iE6iPHNMUzuR4ap4eZwvwjZ+04w8UaI7DskorJ13cpW/1aooEq8W9xPr4gU+fo+6Yz+bCObWX+o24j8G7+2ev21wNHx4zkx4/XLgg81wVKuJCDRAtKZFx1fQYS+IE5RnOd5OvOK/5sLdYmc0iS9IV4IYjGc6a49Tu+77iA6nXv0qL4YLjQv/01qrPO3U1C5cJ1jwgyYtEeO0IJ/IDRF8GN/2MWE+kxFIYlfAP5rnYBhdFv8uUhZ/YNcSJ1P9ntIouFkXv8qyf1u0DBVqZgHZjMAseTVWaXw7iHEHald9JRGA1fcdMqS0gAddcadAVwjFOpOCZjWn9NAbisiTw3Bs6YKmExBZ0WDlMULd52TnfC9TVTgzofMQm+27/hGsF1Ah2eO31wodO2Uow3sKj5VNfNTjW4Kc+sPBOoLJBjGJZ2YBJQakABONKyJmoYX/KOovHze2jUNZA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(39860400002)(376002)(346002)(40470700004)(46966006)(36840700001)(107886003)(26005)(6512007)(316002)(6916009)(86362001)(54906003)(558084003)(41300700001)(6506007)(6486002)(478600001)(82740400003)(36860700001)(40460700003)(2616005)(82310400005)(4326008)(336012)(186003)(47076005)(40480700001)(8676002)(356005)(81166007)(8936002)(70206006)(33656002)(5660300002)(2906002)(36756003)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:17:38.1782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d839000-9443-4a60-dab1-08da8c2d1b22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5368 Hi, Seeing that we have lots of series quite advanced in review but not already= merged, could we push both Feature freeze and Code freeze deadline one week later to have a chanc= e to finish those ? Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:19:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:19:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396736.637020 (Exim 4.92) (envelope-from ) id 1oTlyo-0008Eq-HR; Thu, 01 Sep 2022 15:19:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396736.637020; Thu, 01 Sep 2022 15:19:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlyo-0008Ej-Du; Thu, 01 Sep 2022 15:19:42 +0000 Received: by outflank-mailman (input) for mailman id 396736; Thu, 01 Sep 2022 15:19:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTlyn-0008EX-8I for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:19:41 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e241abc-2a09-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:19:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id DE0C832009A1; Thu, 1 Sep 2022 11:19:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Sep 2022 11:19:36 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 11:19:33 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e241abc-2a09-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1662045575; x= 1662131975; bh=TNsoNCzvViKt3VcPND+jjvKdD2DvxsX4hTj2K9cQ/vw=; b=T a5eyiigbp+x5c8Y/UHnpVCKhAHsnBey1ieZSDl8vsBY60K4unlLyPdzzEH9Y5/HX ie7DhoM4iIcU880x20HjF+53RMa4x9k87CdkqLEU4N0wCqPzIVHm2bcpEhsMJLO4 Uo/gKSR64mQ2TccWQwggjfeQG0JUwaHzSQcScuDkMb6Put31iaM2CgMIWIBaczRe GFSYSUbZ6My+qZchwsYTgUDVrHAc38nwp7hDUyM7588i5TcArOL9xLnMGT4zPTdR kIFkKAd/MSv0lI8VcY/Vv+ajH+7hkucPqqaP6DgGdDwHbUqUx1apLKkZkIbTMYL1 nWhzFt8ssz8urfTkcZcbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1662045575; x=1662131975; bh=TNsoNCzvViKt3VcPND+jjvKdD2Dv xsX4hTj2K9cQ/vw=; b=3WSp8Tnxqe8RaUri7PlYqJrhuFNAHm1TC2xq9OUQqSM0 0G47H4TCwzkRneRY6u6zpaHbArwTQSJSliJhvYoGu+l3RHXtMqATHnAGWTqh82Kv SZ/t9LmwQfD5F3A3M/e851P7NnryzZv0y2hzjaj1FfM+x/7shXYDYro6kxbzwYYJ 0EqI2TlQP+nu4yRZBVAuA7ogHX63nCFoFCxuPasifwibx+HbN4NqpQKq6USviTSn Gw6O8qn12ZKN9h+Y3+IrVh0Fh06aFH4D1AvMONNApxfkyNjdK5/vR+HgmXcQ0AUt XPSAapu4QdJr3tK9X+3MpYvYWd0kLXLWyzr2gENhAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekkedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehgtd orredttdejnecuhfhrohhmpeforghrvghkucforghrtgiihihkohifshhkihdqifpkrhgv tghkihcuoehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeeluedtveefffeulefgudeiveeuffdtkeehveejieei gfettddtfefgkeehudetfeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 1 Sep 2022 17:19:29 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: SeongJae Park Cc: jgross@suse.com, roger.pau@citrix.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, axboe@kernel.dk, ptyadav@amazon.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent Message-ID: References: <20220831165824.94815-1-sj@kernel.org> <20220831170817.94903-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pi/sglFMMbnoUUwn" Content-Disposition: inline In-Reply-To: <20220831170817.94903-1-sj@kernel.org> --Pi/sglFMMbnoUUwn Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 1 Sep 2022 17:19:29 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: SeongJae Park Cc: jgross@suse.com, roger.pau@citrix.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, axboe@kernel.dk, ptyadav@amazon.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent On Wed, Aug 31, 2022 at 05:08:17PM +0000, SeongJae Park wrote: > On Wed, 31 Aug 2022 16:58:21 +0000 SeongJae Park wrote: >=20 > > Changes from v1 > > (https://lore.kernel.org/xen-devel/20220825161511.94922-1-sj@kernel.org= /) > > - Fix the wrong feature_persistent caching position of blkfront > > - Set blkfront's feature_persistent field setting with simple '&&' > > instead of 'if' (Pratyush Yadav) > >=20 > > This patchset fixes misuse of the 'feature-persistent' advertisement > > semantic (patches 1 and 2), and the wrong timing of the > > 'feature_persistent' value caching, which made persistent grants feature > > always disabled. >=20 > Please note that I have some problem in my test setup and therefore was u= nable > to fully test this patchset. I am posting this though, as the impact of = the > bug is not trivial (always disabling persistent grants), and to make test= ing of > my proposed fix from others easier. Hope to get someone's test results o= r code > review of this patchset even before I fix my test setup problem. I can confirm it fixes the issue, thanks! Tested-by: Marek Marczykowski-G=C3=B3recki > Juergen, I didn't add your 'Reviewed-by:'s to the first two patches of th= is > series because I changed some of the description for making it clear whic= h bug > and commit it is really fixing. Specifically, I wordsmithed the working = and > changed 'Fixed:' tag. Code change is almost same, though. >=20 >=20 > Thanks, > SJ >=20 > >=20 > > SeongJae Park (3): > > xen-blkback: Advertise feature-persistent as user requested > > xen-blkfront: Advertise feature-persistent as user requested > > xen-blkfront: Cache feature_persistent value before advertisement > >=20 > > drivers/block/xen-blkback/common.h | 3 +++ > > drivers/block/xen-blkback/xenbus.c | 6 ++++-- > > drivers/block/xen-blkfront.c | 20 ++++++++++++-------- > > 3 files changed, 19 insertions(+), 10 deletions(-) > >=20 > > --=20 > > 2.25.1 > >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Pi/sglFMMbnoUUwn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMQzYEACgkQ24/THMrX 1yyDYwf/VfKN646vVgi2jJoF6YTtEC9WtaCKnkgp9Bhbx6MBspI0VMcMqlUW4iON qs/hnpOCkht7ZawoVqnlK6mb+u6M4W7MFSMNXWSXYvyiCs4fn0dYKm+V630g0eY2 jf7RIMbtjMs7D6GCEmg/FRYft2igtwVu/DQrrJeYXB13QgwXb2/5+PdwlDugMJE1 2ZUeCBQH680TnNsfw68eF4LY7+nZAqaC357Ns/5ANz0GR+M+CxG6B2zPsk7hd5ab pQt15XHMlzSeJNo2TpDWpZ3Rq4mKDzXL2V55S4eqq82rGymLYTaWzZzNGNmEhEtD abuZg0mXO7/n/yrWpUclPsSC5TwaXA== =NzXu -----END PGP SIGNATURE----- --Pi/sglFMMbnoUUwn-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:21:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:21:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396745.637031 (Exim 4.92) (envelope-from ) id 1oTm0H-0001Dv-0C; Thu, 01 Sep 2022 15:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396745.637031; Thu, 01 Sep 2022 15:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm0G-0001Do-T2; Thu, 01 Sep 2022 15:21:12 +0000 Received: by outflank-mailman (input) for mailman id 396745; Thu, 01 Sep 2022 15:21:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm0F-0001Dc-Ka for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:21:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b074f70e-2a09-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:21:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E90CD20195; Thu, 1 Sep 2022 15:21:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A5BBC13A89; Thu, 1 Sep 2022 15:21:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dSweJ93NEGOtdQAAMHmgww (envelope-from ); Thu, 01 Sep 2022 15:21:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b074f70e-2a09-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662045661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oQoq4bqQp7xDr4YMkqk9mdRdNYnybE6NtXuH/R709S8=; b=BlnfTdmzfEyX3DONFJzlyJLtdMETXUSg3qcaBBRvAAgCQPTeWqbyCnhqHgBiwaT9+yWxcN iRvbRhUSJ+vbfbryWrxexdRB9d19CRGCQPzR1um9gD0UR59dV3fJh+dTwL6fPBztMfluIJ zhKToXzB2xKMnXGopb10V2jmlBGDeyE= Message-ID: Date: Thu, 1 Sep 2022 17:21:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent Content-Language: en-US To: SeongJae Park , roger.pau@citrix.com Cc: marmarek@invisiblethingslab.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, axboe@kernel.dk, ptyadav@amazon.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220831165824.94815-1-sj@kernel.org> From: Juergen Gross In-Reply-To: <20220831165824.94815-1-sj@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CAINiOsjmi0msmQ0OUfeF4Kz" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CAINiOsjmi0msmQ0OUfeF4Kz Content-Type: multipart/mixed; boundary="------------zXbVxqxcXeKv8xitDfEShKed"; protected-headers="v1" From: Juergen Gross To: SeongJae Park , roger.pau@citrix.com Cc: marmarek@invisiblethingslab.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, axboe@kernel.dk, ptyadav@amazon.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent References: <20220831165824.94815-1-sj@kernel.org> In-Reply-To: <20220831165824.94815-1-sj@kernel.org> --------------zXbVxqxcXeKv8xitDfEShKed Content-Type: multipart/mixed; boundary="------------XOd2EQ3pU0OaWz2JuWcdTqkZ" --------------XOd2EQ3pU0OaWz2JuWcdTqkZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzEuMDguMjIgMTg6NTgsIFNlb25nSmFlIFBhcmsgd3JvdGU6DQo+IENoYW5nZXMgZnJv bSB2MQ0KPiAoaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIwODI1MTYx NTExLjk0OTIyLTEtc2pAa2VybmVsLm9yZy8pDQo+IC0gRml4IHRoZSB3cm9uZyBmZWF0dXJl X3BlcnNpc3RlbnQgY2FjaGluZyBwb3NpdGlvbiBvZiBibGtmcm9udA0KPiAtIFNldCBibGtm cm9udCdzIGZlYXR1cmVfcGVyc2lzdGVudCBmaWVsZCBzZXR0aW5nIHdpdGggc2ltcGxlICcm JicNCj4gICAgaW5zdGVhZCBvZiAnaWYnIChQcmF0eXVzaCBZYWRhdikNCj4gDQo+IFRoaXMg cGF0Y2hzZXQgZml4ZXMgbWlzdXNlIG9mIHRoZSAnZmVhdHVyZS1wZXJzaXN0ZW50JyBhZHZl cnRpc2VtZW50DQo+IHNlbWFudGljIChwYXRjaGVzIDEgYW5kIDIpLCBhbmQgdGhlIHdyb25n IHRpbWluZyBvZiB0aGUNCj4gJ2ZlYXR1cmVfcGVyc2lzdGVudCcgdmFsdWUgY2FjaGluZywg d2hpY2ggbWFkZSBwZXJzaXN0ZW50IGdyYW50cyBmZWF0dXJlDQo+IGFsd2F5cyBkaXNhYmxl ZC4NCj4gDQo+IFNlb25nSmFlIFBhcmsgKDMpOg0KPiAgICB4ZW4tYmxrYmFjazogQWR2ZXJ0 aXNlIGZlYXR1cmUtcGVyc2lzdGVudCBhcyB1c2VyIHJlcXVlc3RlZA0KPiAgICB4ZW4tYmxr ZnJvbnQ6IEFkdmVydGlzZSBmZWF0dXJlLXBlcnNpc3RlbnQgYXMgdXNlciByZXF1ZXN0ZWQN Cj4gICAgeGVuLWJsa2Zyb250OiBDYWNoZSBmZWF0dXJlX3BlcnNpc3RlbnQgdmFsdWUgYmVm b3JlIGFkdmVydGlzZW1lbnQNCj4gDQo+ICAgZHJpdmVycy9ibG9jay94ZW4tYmxrYmFjay9j b21tb24uaCB8ICAzICsrKw0KPiAgIGRyaXZlcnMvYmxvY2sveGVuLWJsa2JhY2sveGVuYnVz LmMgfCAgNiArKysrLS0NCj4gICBkcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jICAgICAg IHwgMjAgKysrKysrKysrKysrLS0tLS0tLS0NCj4gICAzIGZpbGVzIGNoYW5nZWQsIDE5IGlu c2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQ0KPiANCg0KRm9yIHRoZSB3aG9sZSBzZXJp ZXM6DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoN Cg0KSnVlcmdlbg0K --------------XOd2EQ3pU0OaWz2JuWcdTqkZ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------XOd2EQ3pU0OaWz2JuWcdTqkZ-- --------------zXbVxqxcXeKv8xitDfEShKed-- --------------CAINiOsjmi0msmQ0OUfeF4Kz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMQzd0FAwAAAAAACgkQsN6d1ii/Ey/f Hgf+NtistZlmf1qGYX/+wGy2DO972jLlom8DItCYrJ+2iaNffsH4Lyuz6uBRm45XwVYS8JCoBfY9 isDdLyxiq/mB82HCTI4rSznw/RXD93qZxpB9Ly48kitFArGhskGnm1zx28pRMtT9Uc9sd/bcfQQ9 koN0M3Ak9y0d3J8suqObS0grcqCdye3SRXnJ3iw/y1bDVxEb3ree/KrfcVy44Em5nvteM44igCsy BQQxRSDmJwbMiAVIc1e1Gf5LfZuNjnKI+pQBzo7GOBmHfbTbRx9Xi8ZXvbb1YQ5v3rxU2OmJYekA wGrmsH//uLsCMpPyZcKeeVdCLCyB4NSUZ+we+vPVgA== =+pQd -----END PGP SIGNATURE----- --------------CAINiOsjmi0msmQ0OUfeF4Kz-- From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:22:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396752.637042 (Exim 4.92) (envelope-from ) id 1oTm1e-0001nz-Cj; Thu, 01 Sep 2022 15:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396752.637042; Thu, 01 Sep 2022 15:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm1e-0001ns-95; Thu, 01 Sep 2022 15:22:38 +0000 Received: by outflank-mailman (input) for mailman id 396752; Thu, 01 Sep 2022 15:22:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm1c-0001ne-UE; Thu, 01 Sep 2022 15:22:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm1c-0006TF-Rb; Thu, 01 Sep 2022 15:22:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm1c-00073D-BY; Thu, 01 Sep 2022 15:22:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTm1c-0007Lm-B7; Thu, 01 Sep 2022 15:22:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sss5ZJ8b4z06lU8GW7QG8bmMOBLVebbnOdIzodIeO84=; b=ywjT65VF77iGo4HkyHsa+sN34B rpq1O9RtsjXXMDDud0663Z8DNaRhWYdzIz7TUEqZDwcYblBuR5nMZRGQB11deAVFuMvTxQG/Xm6zR OPGsfkO/cOFEF+PyMrk9DKpNwSRD0j2yB317D2PjSKEp8WhukDqundmzC2zUwgJunfb0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172905: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start.2:fail:regression qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e93ded1bf6c94ab95015b33e188bc8b0b0c32670 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Thu, 01 Sep 2022 15:22:36 +0000 flight 172905 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172905/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 test-amd64-i386-xl-vhd 22 guest-start.2 fail REGR. vs. 172123 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu e93ded1bf6c94ab95015b33e188bc8b0b0c32670 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 28 days Failing since 172148 2022-08-04 21:39:38 Z 27 days 63 attempts Testing same since 172905 2022-09-01 03:49:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Andrea Bolognani BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Paolo Bonzini Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3063 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:23:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:23:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396760.637052 (Exim 4.92) (envelope-from ) id 1oTm2T-0002SD-QL; Thu, 01 Sep 2022 15:23:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396760.637052; Thu, 01 Sep 2022 15:23:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm2T-0002S6-Mw; Thu, 01 Sep 2022 15:23:29 +0000 Received: by outflank-mailman (input) for mailman id 396760; Thu, 01 Sep 2022 15:23:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm2R-0002Rl-QC; Thu, 01 Sep 2022 15:23:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm2R-0006U0-PN; Thu, 01 Sep 2022 15:23:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm2R-00076v-BU; Thu, 01 Sep 2022 15:23:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTm2R-00088r-B4; Thu, 01 Sep 2022 15:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aoB7Gw6VbMOFdQnMUmK+S1hhrd2ML//ZUzUGLGADE1Y=; b=5Enx+Tr/0C+rhuQVJskqE573oT nwa9OLHP9Z/GLwJ2bduhuhwSq73jHjXUFRvc/I8G7EhRamoSGpgIVvA38YNR8vXqszOORZiwNujuz gQQjXp6k5PixhaYR4Sp1CamV8XK/1kGRtnjv+SGS/82gn09k5CN7Or2Wwc5T3wdar3wo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172912: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=033ba8bb2976629fdb664d7131f44f8b0b8f6777 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 01 Sep 2022 15:23:27 +0000 flight 172912 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172912/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 033ba8bb2976629fdb664d7131f44f8b0b8f6777 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 219 attempts Testing same since 172912 2022-09-01 11:42:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Ray Ni Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1360 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:29:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:29:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396770.637064 (Exim 4.92) (envelope-from ) id 1oTm8K-0003BQ-Fe; Thu, 01 Sep 2022 15:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396770.637064; Thu, 01 Sep 2022 15:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm8K-0003BJ-Cf; Thu, 01 Sep 2022 15:29:32 +0000 Received: by outflank-mailman (input) for mailman id 396770; Thu, 01 Sep 2022 15:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm8I-0003BD-Uh for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:29:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTm8I-0006aN-Ng; Thu, 01 Sep 2022 15:29:30 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTm8I-0000Bx-EY; Thu, 01 Sep 2022 15:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=W8XT3/qqFZN9iXTn5bGBgMVn7ZIAi2fICMBG0pphfkE=; b=Nh2cLHBhN4569eSJ1NeRGsJty1 O8hr3OOB6QDQW8v/lR4kiNp0qv13xwM7BeSuNX9LoLm6wyCE06ohjrqncZ3eKJ/a14WfSg6/E5QQ0 B8rMrat0dR/NXwNwcC2CVdEedNMy46ADTkde56LU9f3d3ncvfQsPyfwgmVa1XN3I9XDI=; Message-ID: <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> Date: Thu, 1 Sep 2022 16:29:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220824073127.16762-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 24/08/2022 08:31, Henry Wang wrote: > This commit firstly adds a global variable `reserved_heap`. > This newly introduced global variable is set at the device tree > parsing time if the reserved heap ranges are defined in the device > tree chosen node. > > For Arm32, In `setup_mm`, if the reserved heap is enabled, we use > the reserved heap region for both domheap and xenheap allocation. > > For Arm64, In `setup_mm`, if the reserved heap is enabled and used, > we make sure that only these reserved heap pages are added to the > boot allocator. These reserved heap pages in the boot allocator are > added to the heap allocator at `end_boot_allocator()`. > > If the reserved heap is disabled, we stick to current page allocation > strategy at boot time. > > Also, take the chance to correct a "double not" print in Arm32 > `setup_mm()`. > > Signed-off-by: Henry Wang > --- > With reserved heap enabled, for Arm64, naming of global variables such > as `xenheap_mfn_start` and `xenheap_mfn_end` seems to be ambiguous, > wondering if we should rename these variables. > --- > Changes from RFC to v1: > - Rebase on top of latest `setup_mm()` changes. > - Added Arm32 logic in `setup_mm()`. > --- > xen/arch/arm/bootfdt.c | 2 + > xen/arch/arm/include/asm/setup.h | 2 + > xen/arch/arm/setup.c | 79 +++++++++++++++++++++++++------- > 3 files changed, 67 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 33704ca487..ab73b6e212 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -325,6 +325,8 @@ static int __init process_chosen_node(const void *fdt, int node, > true); > if ( rc ) > return rc; > + > + reserved_heap = true; > } > > printk("Checking for initrd in /chosen\n"); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index e80f3d6201..00536a6d55 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -92,6 +92,8 @@ extern struct bootinfo bootinfo; > > extern domid_t max_init_domid; > > +extern bool reserved_heap; > + > void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); > > size_t estimate_efi_size(unsigned int mem_nr_banks); > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 500307edc0..fe76cf6325 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -73,6 +73,8 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes); > > domid_t __read_mostly max_init_domid; > > +bool __read_mostly reserved_heap; > + > static __used void init_done(void) > { > /* Must be done past setting system_state. */ > @@ -699,8 +701,10 @@ static void __init populate_boot_allocator(void) > #ifdef CONFIG_ARM_32 > static void __init setup_mm(void) > { > - paddr_t ram_start, ram_end, ram_size, e; > - unsigned long ram_pages; > + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; > + paddr_t reserved_heap_start = ~0, reserved_heap_end = 0, > + reserved_heap_size = 0; > + unsigned long ram_pages, reserved_heap_pages = 0; > unsigned long heap_pages, xenheap_pages, domheap_pages; > unsigned int i; > const uint32_t ctr = READ_CP32(CTR); > @@ -720,9 +724,9 @@ static void __init setup_mm(void) > > for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) > { > - paddr_t bank_start = bootinfo.mem.bank[i].start; > - paddr_t bank_size = bootinfo.mem.bank[i].size; > - paddr_t bank_end = bank_start + bank_size; > + bank_start = bootinfo.mem.bank[i].start; > + bank_size = bootinfo.mem.bank[i].size; > + bank_end = bank_start + bank_size; > > ram_size = ram_size + bank_size; > ram_start = min(ram_start,bank_start); > @@ -731,6 +735,25 @@ static void __init setup_mm(void) > > total_pages = ram_pages = ram_size >> PAGE_SHIFT; > > + if ( reserved_heap ) > + { > + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) > + { > + if ( bootinfo.reserved_mem.bank[i].xen_heap ) > + { > + bank_start = bootinfo.reserved_mem.bank[i].start; > + bank_size = bootinfo.reserved_mem.bank[i].size; > + bank_end = bank_start + bank_size; > + > + reserved_heap_size += bank_size; > + reserved_heap_start = min(reserved_heap_start, bank_start); > + reserved_heap_end = max(reserved_heap_end, bank_end); > + } > + } > + > + reserved_heap_pages = reserved_heap_size >> PAGE_SHIFT; > + } > + > /* > * If the user has not requested otherwise via the command line > * then locate the xenheap using these constraints: > @@ -743,7 +766,8 @@ static void __init setup_mm(void) > * We try to allocate the largest xenheap possible within these > * constraints. > */ > - heap_pages = ram_pages; > + heap_pages = !reserved_heap ? ram_pages : reserved_heap_pages; > + > if ( opt_xenheap_megabytes ) > xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); > else > @@ -755,17 +779,21 @@ static void __init setup_mm(void) > > do > { > - e = consider_modules(ram_start, ram_end, > + e = !reserved_heap ? > + consider_modules(ram_start, ram_end, > pfn_to_paddr(xenheap_pages), > - 32<<20, 0); > + 32<<20, 0) : > + reserved_heap_end; Not entirely related to this series. Now the assumption is the admin will make sure that none of the reserved regions will overlap. Do we have any tool to help the admin to verify it? If yes, can we have a pointer in the documentation? If not, should this be done in Xen? Also, what happen with UEFI? Is it easy to guarantee the region will not be used? > + > if ( e ) > break; > > xenheap_pages >>= 1; > } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); > > - if ( ! e ) > - panic("Not not enough space for xenheap\n"); > + if ( ! e || > + ( reserved_heap && reserved_heap_pages < 32<<(20-PAGE_SHIFT) ) ) > + panic("Not enough space for xenheap\n"); So on arm32, the xenheap *must* be contiguous. AFAICT, reserved_heap_pages is the total number of pages in the heap. They may not be contiguous. So I think this wants to be reworked so we look for one of the region that match the definition written above the loop. > > domheap_pages = heap_pages - xenheap_pages; > > @@ -810,9 +838,9 @@ static void __init setup_mm(void) > static void __init setup_mm(void) > { > const struct meminfo *banks = &bootinfo.mem; > - paddr_t ram_start = ~0; > - paddr_t ram_end = 0; > - paddr_t ram_size = 0; > + paddr_t ram_start = ~0, bank_start = ~0; > + paddr_t ram_end = 0, bank_end = 0; > + paddr_t ram_size = 0, bank_size = 0; > unsigned int i; > > init_pdx(); > @@ -821,17 +849,36 @@ static void __init setup_mm(void) > * We need some memory to allocate the page-tables used for the xenheap > * mappings. But some regions may contain memory already allocated > * for other uses (e.g. modules, reserved-memory...). > - * > + * If reserved heap regions are properly defined, (only) add these regions > + * in the boot allocator. > + */ > + if ( reserved_heap ) > + { > + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) > + { > + if ( bootinfo.reserved_mem.bank[i].xen_heap ) > + { > + bank_start = bootinfo.reserved_mem.bank[i].start; > + bank_size = bootinfo.reserved_mem.bank[i].size; > + bank_end = bank_start + bank_size; > + > + init_boot_pages(bank_start, bank_end); > + } > + } > + } > + /* > + * No reserved heap regions: > * For simplicity, add all the free regions in the boot allocator. > */ > - populate_boot_allocator(); > + else > + populate_boot_allocator(); > > total_pages = 0; > > for ( i = 0; i < banks->nr_banks; i++ ) > { This code is now becoming quite confusing to understanding. This loop is meant to map the xenheap. If I follow your documentation, it would mean that only the reserved region should be mapped. More confusingly, xenheap_* variables will cover the full RAM. Effectively, this is now more obvious that this is use for direct-mapping. So I think it would be better to rename the variable to directmap_* or similar. Ideally this should be in a separate patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:31:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396776.637074 (Exim 4.92) (envelope-from ) id 1oTmA5-0004Wi-Re; Thu, 01 Sep 2022 15:31:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396776.637074; Thu, 01 Sep 2022 15:31:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmA5-0004Wb-Ot; Thu, 01 Sep 2022 15:31:21 +0000 Received: by outflank-mailman (input) for mailman id 396776; Thu, 01 Sep 2022 15:31:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmA5-0004WT-32 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:31:21 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1fefb375-2a0b-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:31:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C39F61E88; Thu, 1 Sep 2022 15:31:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87365C4314C; Thu, 1 Sep 2022 15:31:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fefb375-2a0b-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662046277; bh=BpStsapj3/z8E8t4ssp7E5IEy9ihL4Ye7GsJheQPVSk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aTPBD0w6gH1K8/6Lqws5TOOzwS5Xtezxpl0NrRLxhYUbC43/QOjlLN7DhbVhxIHmk nvMkhX7K15MEBJFC6OS8T5kfqRmXUh8USpG62xBN1ltv3JSlp6pUFMrqVGSiOBGceH rxp5MUe1BnbGgir86cWvGSX1dLBW+eJOtlAryfoXQgPl9qmSiTn0gZIVAfwkVsZxXy fNZZKINhjwVI7BdxaXWS755ei0mk9LU70O5/ksVAcM2Zdta19CjTD1eMd9xMYoQng5 MwwkEfQu/VPuSmMnJwJ+z1XURjP9alHZQoDXe2YrHasRNos56+Sj8Uq2vBxg7bWfFk u191J9L9XGEoA== Date: Thu, 1 Sep 2022 08:31:16 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: xen-devel , Henry Wang , Jan Beulich , Julien Grall , Stefano Stabellini , Andrew Cooper , Juergen Gross , Anthony PERARD , George Dunlap Subject: Re: Push 4.17 Feature freeze and Code freeze one week later In-Reply-To: <2745BA23-B42E-49E2-89A2-59A0ED70388F@arm.com> Message-ID: References: <2745BA23-B42E-49E2-89A2-59A0ED70388F@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Bertrand Marquis wrote: > Hi, > > Seeing that we have lots of series quite advanced in review but not already merged, could we push > both Feature freeze and Code freeze deadline one week later to have a chance to finish those ? +1 On the ARM side we have a higher-than-usual number of patch series still to commit. This is different from past times when people rushed at the last week many patch series, completely new and unreviewed. These series went through the review process properly, they are in good condition, and are typically at v4 or above. They only miss one last round of review. I think we should give them a chance to finish, so it would be great to have 1 more week. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:33:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:33:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396782.637086 (Exim 4.92) (envelope-from ) id 1oTmCE-00059H-7N; Thu, 01 Sep 2022 15:33:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396782.637086; Thu, 01 Sep 2022 15:33:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmCE-00059A-4m; Thu, 01 Sep 2022 15:33:34 +0000 Received: by outflank-mailman (input) for mailman id 396782; Thu, 01 Sep 2022 15:33:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmCD-000594-Ck for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:33:33 +0000 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [2607:f8b0:4864:20::b2c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f2518da-2a0b-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 17:33:32 +0200 (CEST) Received: by mail-yb1-xb2c.google.com with SMTP id t184so9125033yba.4 for ; Thu, 01 Sep 2022 08:33:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f2518da-2a0b-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=cuZ+nGX7dbAKHVSMzM9WDnRxW6f4Hrbmbun1Vl7XZUY=; b=nPy2aaUnPlKN9168rAezb9LSPcW4fo9+X5T3qYP77vPFcpzl+GhEzMZUxcz6J/8TiE IizY0PKy2tILVlboBx4hOHtK6o3BgdgdGqsyzqTvhnIsClaTwjg++DGXEdjbBPa8JR6s MIO2ZCktfdOzY88zke9nN4gcVwpbigx1IRCHgdE2F2Mq1597r9VFdc/4HIbMkV/CeG8x zsKr4C+BAyJ34f5F1Hb/vV3IvHxRb8IEQg4iOBO9diUXfW6M3nrOExLvEuVNGqzKErqg hzqElImWPPWWViyded2pBo3h+cgyvOivEpW732ttVGvmx+I0KmbeGYZvy64qW3Me0ncH pw1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=cuZ+nGX7dbAKHVSMzM9WDnRxW6f4Hrbmbun1Vl7XZUY=; b=cCH507uoVpiOaVv1wxBkBLErqClVaIPdoJRT72yjptjG8uuKrl+Jx+7RSlWXjBNEwY ZvBh/Cbk+PSsUnY71UjziNZo0Q2Q83NcuD+7/JFoYlgsDiz3l9JEMGmi9SAXcgITI5kb kw5y+QPbmXyrr3mn5yFuGhISAyzTcNBv1QjYHEEOODBJ9DzeFlzvAAQMlJ92GGrREdjD FAqPSHwpGBJrhwP3H3Yz2qPFIpUMjeITpVswlE4HO5rR9vd30MhqvzB19IMM6JPe8eE3 X2hWp4XzGIvoiPFS8jw25BmCkgkx1w+oJhaGiYR31qgi9uvHqqoz9mCkceSn4nZ4BH8C 6zvQ== X-Gm-Message-State: ACgBeo1jxIzZMBjEZTTXNXo5yUi5DosB7xWQh39/EkzJleRluneg+DWL y51uKbC6Y2Qxo0+EymNuBKgjFLp4lYfBf+LAUEGHZQ== X-Google-Smtp-Source: AA6agR7nkVcaAE7evofOhQO8CQyYLS6FGoseisRuE7p9aju3ICNx4/ZUVa/hlS8HLwBhdw8j7iOCWiWLZKuRzYzC+BI= X-Received: by 2002:a05:6902:705:b0:695:b3b9:41bc with SMTP id k5-20020a056902070500b00695b3b941bcmr19699146ybt.426.1662046410779; Thu, 01 Sep 2022 08:33:30 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 08:33:19 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Michal Hocko Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: > > On Wed 31-08-22 15:01:54, Kent Overstreet wrote: > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > > Whatever asking for an explanation as to why equivalent functionality > > > > cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > > > > > > Fully agreed and this is especially true for a change this size > > > 77 files changed, 3406 insertions(+), 703 deletions(-) > > > > In the case of memory allocation accounting, you flat cannot do this with ftrace > > - you could maybe do a janky version that isn't fully accurate, much slower, > > more complicated for the developer to understand and debug and more complicated > > for the end user. > > > > But please, I invite anyone who's actually been doing this with ftrace to > > demonstrate otherwise. > > > > Ftrace just isn't the right tool for the job here - we're talking about adding > > per callsite accounting to some of the fastest fast paths in the kernel. > > > > And the size of the changes for memory allocation accounting are much more > > reasonable: > > 33 files changed, 623 insertions(+), 99 deletions(-) > > > > The code tagging library should exist anyways, it's been open coded half a dozen > > times in the kernel already. > > > > And once we've got that, the time stats code is _also_ far simpler than doing it > > with ftrace would be. If anyone here has successfully debugged latency issues > > with ftrace, I'd really like to hear it. Again, for debugging latency issues you > > want something that can always be on, and that's not cheap with ftrace - and > > never mind the hassle of correlating start and end wait trace events, builting > > up histograms, etc. - that's all handled here. > > > > Cheap, simple, easy to use. What more could you want? > > A big ad on a banner. But more seriously. > > This patchset is _huge_ and touching a lot of different areas. It will > be not only hard to review but even harder to maintain longterm. So > it is completely reasonable to ask for potential alternatives with a > smaller code footprint. I am pretty sure you are aware of that workflow. The patchset is huge because it introduces a reusable part (the first 6 patches introducing code tagging) and 6 different applications in very different areas of the kernel. We wanted to present all of them in the RFC to show the variety of cases this mechanism can be reused for. If the code tagging is accepted, each application can be posted separately to the appropriate group of people. Hopefully that makes it easier to review. Those first 6 patches are not that big and are quite isolated IMHO: include/linux/codetag.h | 83 ++++++++++ include/linux/lazy-percpu-counter.h | 67 ++++++++ include/linux/module.h | 1 + kernel/module/internal.h | 1 - kernel/module/main.c | 4 + lib/Kconfig | 3 + lib/Kconfig.debug | 4 + lib/Makefile | 3 + lib/codetag.c | 248 ++++++++++++++++++++++++++++ lib/lazy-percpu-counter.c | 141 ++++++++++++++++ lib/string_helpers.c | 3 +- scripts/kallsyms.c | 13 ++ > > So I find Peter's question completely appropriate while your response to > that not so much! Maybe ftrace is not the right tool for the intented > job. Maybe there are other ways and it would be really great to show > that those have been evaluated and they are not suitable for a), b) and > c) reasons. That's fair. For memory tracking I looked into using kmemleak and page_owner which can't match the required functionality at an overhead acceptable for production and pre-production testing environments. traces + BPF I haven't evaluated myself but heard from other members of my team who tried using that in production environment with poor results. I'll try to get more specific information on that. > > E.g. Oscar has been working on extending page_ext to track number of > allocations for specific calltrace[1]. Is this 1:1 replacement? No! But > it can help in environments where page_ext can be enabled and it is > completely non-intrusive to the MM code. Thanks for pointing out this work. I'll need to review and maybe profile it before making any claims. > > If the page_ext overhead is not desirable/acceptable then I am sure > there are other options. E.g. kprobes/LivePatching framework can hook > into functions and alter their behavior. So why not use that for data > collection? Has this been evaluated at all? I'm not sure how I can hook into say alloc_pages() to find out where it was called from without capturing the call stack (which would introduce an overhead at every allocation). Would love to discuss this or other alternatives if they can be done with low enough overhead. Thanks, Suren. > > And please note that I am not claiming the presented work is approaching > the problem from a wrong direction. It might very well solve multiple > problems in a single go _but_ the long term code maintenance burden > really has to to be carefully evaluated and if we can achieve a > reasonable subset of the functionality with an existing infrastructure > then I would be inclined to sacrifice some portions with a considerably > smaller code footprint. > > [1] http://lkml.kernel.org/r/20220901044249.4624-1-osalvador@suse.de > > -- > Michal Hocko > SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:35:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396791.637100 (Exim 4.92) (envelope-from ) id 1oTmEJ-0005on-NX; Thu, 01 Sep 2022 15:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396791.637100; Thu, 01 Sep 2022 15:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmEJ-0005og-Kw; Thu, 01 Sep 2022 15:35:43 +0000 Received: by outflank-mailman (input) for mailman id 396791; Thu, 01 Sep 2022 15:35:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmEH-0005oV-MX for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:35:42 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b974762a-2a0b-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 17:35:37 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 281FIgfF028411; Thu, 1 Sep 2022 15:35:31 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j79pc49nb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Sep 2022 15:35:31 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 281E1TW1036927; Thu, 1 Sep 2022 15:35:31 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2041.outbound.protection.outlook.com [104.47.74.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jarpb6jyn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Sep 2022 15:35:31 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DS0PR10MB6030.namprd10.prod.outlook.com (2603:10b6:8:ce::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 15:35:29 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026%3]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 15:35:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b974762a-2a0b-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2022-7-12; bh=k3jhOi/18aqXzObtn/UvjH1Vjp+lrALC3R1MFoWRLIk=; b=HSqO1mOCyzjuJX9MEYDOVD1AdEd2ddoCQCZJxoYyPgNraY34bcpCZxrCFKOMhIbzg/ex 9EnHztMUxgyewaO3PIJvSqLfDrMYu8mK2l8rFiVZzEbRsqWYR2NeyKABXVqMLZ9LItzl S9INAOmo3bEMAW3KSR2nJZh+ocGejzFsKlWeEJnsTg/+tNcNbEavMMXqBiCMFAqDPAaz pGpE42Ics+96OqzQvdmcREJGQr/RUJPLAHnh5RBQ4qEajLWtFg5e6yJaoI57O5dREJQP X10GVEHcMqfmQuXfWMtR9fRjTJl+Pkpx7DpVoMg+Tch67pCIU6pc+741+w4Zejh4swm1 FQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iecDb0ZbHR0gPXmS1viD1Nw0QW+2ArTkrHcjfMOuZbdVu0GEX7d5RlBkvcMEBB/dXc1n4zIWJy5odyRsKojgh0JKZtFXxxGEiZW0xW8u81p3lT+wqwASWXH31J/oaCyAMOWzpCBOY970AW/JXoEaE/znfYYI+udECLLmoKn9Pelp1nmZQJtziMOqNqaWddI6WoA+KxPb8HrVKaD5tPIzpXfaFxZJWuOa7OuRjsdQSXPQZtkCcak7wZ0zYt3DtqykKQR3SbnhEx/keBV8Z7Sx0ZFPmrIBROa+w3oQ8RSgLo+dvVDT2pEUKkXUWyq4oEKremXyfRRYhjPc911wwnEMTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3jhOi/18aqXzObtn/UvjH1Vjp+lrALC3R1MFoWRLIk=; b=BrYkeh+8x/FnBZPYgICsZelEnu3wAwbY2i6nZx9I1+iaF4kN/kcmfPL+MzRrZeTxlcDksHZMpvxgdTDJLk+KFTRoIyf4Si3ZUwt2ph8knp1BlnF5RqL4/ORsugA0C6tYk80pqbgUEHgrNtTJBbfa/DEFnCc/OVFIsFm8oO3MwuBeh9B9KEYLLKWRBWQwn72HsipYZ8qDzSUMcBZyOJeOF6vqA4oRjuOQxvC9UsyeiLY8fGsyI5IdZoLMUTYxySSKqrwmLBSpCFnkAACSOBrbp8N/cJbxKQox8Mhj6GJYWpVKjdyRlX6Agrvn6zXGZe4NbvjeTmbQqmaWGItlpCMAWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3jhOi/18aqXzObtn/UvjH1Vjp+lrALC3R1MFoWRLIk=; b=MfMFIaWq1dZHp6MhDWuOBdf0xGewH2sfuDlwKb6cwhNuFe9Kfd+VKnij9dUyq2p4NC4vu/1ugYUPM+97E3OENfSvP/k1nS/uXGE8Kehon4Iw3BDjwHU0SgD3/BTTkThCieoRdNGnNVwaOsa5rbLR5w3lviNu6itU+PpfWtk4pUw= Date: Thu, 1 Sep 2022 18:35:20 +0300 From: Dan Carpenter To: Juergen Gross Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Subject: [PATCH] xen/grants: prevent integer overflow in gnttab_dma_alloc_pages() Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-ClientProxiedBy: ZR0P278CA0057.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::8) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 77eaa148-93f1-48ad-e950-08da8c2f999a X-MS-TrafficTypeDiagnostic: DS0PR10MB6030:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pMEBtgElVZNcTC7vK2IGsTdnLdfXnTJles9buPnuiDfGSyW8R/eHx7lUva+HROlYB2/3uctLeMIhoS1y06/ztu3BCuZiQTmiCzwH7jZPVx+yTtLax5Gxe4pc3Uh4h7DmJlwFgAHCwlVcxAFmxvI5vOZfiwe9RfCCaq6Xb+mNKzpeXH8YHFYnY0MTy9hBMjwBMdmA/qR72rF+JJYxQsUbAGXG1DLh2HYSBmTL8rEF9LptGkHLJqAnbpqNNMm8cUDBA5SHUHWMpnWfnCZD2EGhu3KWGOuIrh2U2UphGNc3XLwk+vtJ+iyX+ItW8SfUgmdO+WAXjlX49jVPRitOoQUVDdMEWfsNuP7K4WUGA0sKhHqLJQBO00ESKz+aIBcZFFHhUUfTIVgeKfQe035W8ZaFmJX3/kd3xdMLWIZ6vp78RdFojEYp/1NMqRg50jpgEhRLlkrB2QMgdllCKU5RNnohoawtb474xPkfsPk+FIvVfOw4L6PfcYp1S92h1dPhmgRUOFIWL1cJb74nmTL3920tbBbovT52s6TaKqBh1eQebE7pfoS5SslHnQyP0rVQlgPR7IPDR3ayXZ1VsZHY2ofjat4+0O5ggjED1M/QIK70ErXHYZyXU6dF2s9/iYCnE945gMgXhU3BlaoOVpPFvkM4A/L52OJDHa92J9g6sXMDOLnVlXQCkjvxv0eVJZWUR2dcGHYOwsNI8p1xJ2icMjZNvJX0qO/eBdFP0ebhNHUrab3bdQmyfMom5sib7fIZci7YOS9cq5tzLbFw5i/1XZcEBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(136003)(366004)(39860400002)(396003)(346002)(376002)(6506007)(33716001)(66476007)(66556008)(4326008)(8676002)(6666004)(52116002)(316002)(8936002)(6512007)(26005)(86362001)(478600001)(6486002)(38350700002)(6916009)(38100700002)(54906003)(41300700001)(186003)(2906002)(66946007)(9686003)(4744005)(44832011)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wqq5pH6n1jT5FpG05kp42IfyeWga2HrVWYvd7L3Cq4cUzpa/Sf8jXcOSW47P?= =?us-ascii?Q?a1oFz1b3JylFHsJZ4/KSnhExzbG3iIX3mYmbvYECkK4Q3w1vEIlMQ+SDMtby?= =?us-ascii?Q?BS5upisidMAlUo+0LIiOTmclMcV/OHGxfUOmSHxh1FFJGFJn1ubMH/lS7XkA?= =?us-ascii?Q?B1Z78jS+76KXCKitSPSpp5yvCGfcMSNstkvFgWDmtsYlJG+8aRptBa4Pl2uq?= =?us-ascii?Q?InJe0f/3PASjyBOzJ08NS8z0KMtB95UHXkdrKCHwgj4iKsMpKvVcZRxzBHfM?= =?us-ascii?Q?JLQqu8L7Rsdx5KIPptCjZ7ZRm0YLC86XAY0+oCZaQFeAKXfQyfoTxlNwBqmC?= =?us-ascii?Q?+yEjy5p2CaA2xBvHl4WW0rEClaPOCHf+aY5kf7DhAy9oxCTExH4kVOB0diNQ?= =?us-ascii?Q?qglsLpXqcDga9bZwcpgFqlD6zcXQRT578XaTspnb+4I32165+rSW654wBhjE?= =?us-ascii?Q?ryq8FGAraizMVstBKkvow8a3WTFxEwpwMUfXK1c14WiWZufIZbOu+9ds50B8?= =?us-ascii?Q?2VMpH5UzBclTouIm5OLEfDMmS43WcXKOVsC3L7bQkv0Si3HfaujTGiFif+Ue?= =?us-ascii?Q?v+B/6SmDG0E/Yy0VHnIWyGJ9EiY7X8ABlK3osFLHzcqN+RujFvC1EAHrF/KJ?= =?us-ascii?Q?htZVh1nYVCcbKjvIIbRKmc7ekycdc1bJ600EX/a9yM+j2G6ziTU+B1FDbHUX?= =?us-ascii?Q?dTjtIp5VEYVVIosGYrTba2wiBOr5NmoHB+PIcu6iWEqC7GBqeeRITiGKT3k2?= =?us-ascii?Q?D848WrIWIm6FcwElghgErzWTOSTkdWSYM2obM3CI2+nzX2RUVN9kyj6TODsu?= =?us-ascii?Q?0/XQa2xNSvq8IqJM0IQQZaMAXNvX/1w6EQmq+skWv8fQkFn6q4fPeRBMDcNm?= =?us-ascii?Q?7B53eq0wfw0rJ/hQF3gH+q9JAzv2RwhS5YqEQMmZlMKH6QQNg7unEooU9+aQ?= =?us-ascii?Q?wGT5piQmicdXxe4EfM1UnZznx5ovn4LkumvpbOsgjkNy5UpU8DKEG3Dhwqpq?= =?us-ascii?Q?8vSMilLIL6NZwp65i0i1OjKQWOFYOA0ngVTZCXHdHttnc0dPwXs3hl5sC2SV?= =?us-ascii?Q?7JjkZA1nYqDR/Agw2xKpEgVKaaEaKKtRVO9PrtqUyHoNz00RTwWcBFUpM0Wy?= =?us-ascii?Q?HTo+vDLFdBx6whteautV8ac3UO9j5o5V4qoLzFF45b2ZOIw1SembGMRyi5UJ?= =?us-ascii?Q?V+y1DNJMFsCTSo8vcZHyvJ9B9/KFCqnpBkyFfVlp0WNLIROmu0rTw0hsusKp?= =?us-ascii?Q?cSSaefDyusjpDmK7SojNbBTi/4GkVSnOpZYf3bTzZOc6BscAgFKDX4W2VXph?= =?us-ascii?Q?lBdWWum1xJAAXYZNToYzaBidWECBgnt74s6jiBufgAF/IZ4uLtydl7qvZfcS?= =?us-ascii?Q?wXqtaYoRYph+Rl2PshrC/kU4YshxptaUR+LLUx+t4aEB41kOGYyte1sja7ZR?= =?us-ascii?Q?JNKMhPLQLcofHn6kDvLXkplj+km9o3ojM//VQxjy7J267LFiRGA0GdxgrtE/?= =?us-ascii?Q?f31o9PHcdDp8RLSK8d/rehnFlval3FlsNRX1NyIsXweSLZon5FbOyRYtQXHE?= =?us-ascii?Q?IdWGUi7bmcbQpqe9YbGb6zDk+MScoIYfaaw73DPJeBrIDjR1NyxNa75x68I/?= =?us-ascii?Q?kg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77eaa148-93f1-48ad-e950-08da8c2f999a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:35:29.6014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SRUbNFHeRBDsjfn3i3hC7aUv3/Xzwx6qQBYgAPHQjgs5I2tFEf5c8fEccMLAqVOcopX9bSCKJ5PQxanHMdtxpS3T4mNGBAKV9Pylbjc2bZ8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6030 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-01_10,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209010070 X-Proofpoint-ORIG-GUID: xivjyUq_5x4pYqFe-WbC4hN2Nwk1Q1ar X-Proofpoint-GUID: xivjyUq_5x4pYqFe-WbC4hN2Nwk1Q1ar The change from kcalloc() to kvmalloc() means that arg->nr_pages might now be large enough that the "args->nr_pages << PAGE_SHIFT" can result in an integer overflow. Fixes: b3f7931f5c61 ("xen/gntdev: switch from kcalloc() to kvcalloc()") Signed-off-by: Dan Carpenter --- drivers/xen/grant-table.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 738029de3c67..e1ec725c2819 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -1047,6 +1047,9 @@ int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_args *args) size_t size; int i, ret; + if (args->nr_pages < 0 || args->nr_pages > (INT_MAX >> PAGE_SHIFT)) + return -ENOMEM; + size = args->nr_pages << PAGE_SHIFT; if (args->coherent) args->vaddr = dma_alloc_coherent(args->dev, size, -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:40:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396798.637111 (Exim 4.92) (envelope-from ) id 1oTmIV-0006l2-BO; Thu, 01 Sep 2022 15:40:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396798.637111; Thu, 01 Sep 2022 15:40:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmIV-0006kS-66; Thu, 01 Sep 2022 15:40:03 +0000 Received: by outflank-mailman (input) for mailman id 396798; Thu, 01 Sep 2022 15:40:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmIU-0006Y1-2f for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:40:02 +0000 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [2607:f8b0:4864:20::b35]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56c71e21-2a0c-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:40:01 +0200 (CEST) Received: by mail-yb1-xb35.google.com with SMTP id 130so9146650ybw.8 for ; Thu, 01 Sep 2022 08:40:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56c71e21-2a0c-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=3cE853tliEpPWpHjkdjBsm55bguibJ1NOZ2l+ytqvIs=; b=CNR1NtmysqZN43aw5siPQxQB15yoyKxn0UtAt1eFrCVSTrqVXrck0MJQ5rF0EE8Iqy FECYDZNtaf4xFqIfRFeGfncBEzgsXCtgfPFQ9NnPdVRFkAf7PTRy+isa8Q/3u9s63jFF Bkv08GJGttRtk8ihR4u9G9sfgOvnbQBOURRSewgh7NzkPEQgVbW8k9NY5ToRU0fk16sO KDQeEwKDvn2AZgblfu2tmDll7zNnUGlKeUzAPAS8k31d+CGKhmmtzNe2LpeGY2e9A3T2 OyHR4dbvshaM9SSwkyP8U36LLaknoM2MMTtTCDpp5f48zXa2ecNcsCYbrEUZ3+gtqLOE C5XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=3cE853tliEpPWpHjkdjBsm55bguibJ1NOZ2l+ytqvIs=; b=vMFBFQ9gaUDuAiOK6XxdMiUg+fSEUI34GgK0Re70nYnkYJbAXte5DdiW3AbqGaHD1E RUPDTd1a6F7c/hvxCHJQlTead4MajdAmiqekUEBnTgJuvRh60Q3mQT0AQNxnPrJegHcv NBULDWW78/w9s27bakyQst/yrp2pGxPk2abHXPSk1HCFHi7XL1W9x/FgtYl9Ifr4KWPg nvLE1EhJ+jjJMgWHxU1Q6Ot/NFxWkJiVWFpOsr+acyN9ClGtD/+/2Cw6vX0fIa0ZTF9O MhwnmpVyFLTr0252Cf/WNrtUEgg7LgsAJiXcoJi6qQ97DAzkFhdYy99ygJon87iMGOK2 EnMg== X-Gm-Message-State: ACgBeo3Fzx9Vu7HsPy5gNv+3oF3S1ML6830fVqL4bY+fHAkgzWhKegch 9wYA/fIePfNneLMOai9dqCcYMhw9fpjtoIQ0/Oui+w== X-Google-Smtp-Source: AA6agR5aFHV5oWy3bOo2eVd0PIajtlCyUMrAF/y9Oh7oqrhvwnrJM9jnSE6k3ZmfRfh8uK89oJZlft1zkj3aGLobpWw= X-Received: by 2002:a25:b983:0:b0:695:d8b4:a5a3 with SMTP id r3-20020a25b983000000b00695d8b4a5a3mr20405655ybg.553.1662046799565; Thu, 01 Sep 2022 08:39:59 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> <78e55029-0eaf-b4b3-7e86-1086b97c60c6@redhat.com> In-Reply-To: <78e55029-0eaf-b4b3-7e86-1086b97c60c6@redhat.com> From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 08:39:48 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: David Hildenbrand Cc: Kent Overstreet , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 8:07 AM David Hildenbrand wrote: > > On 01.09.22 16:23, Kent Overstreet wrote: > > On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: > >> On 31.08.22 21:01, Kent Overstreet wrote: > >>> On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > >>>> On Wed 31-08-22 11:19:48, Mel Gorman wrote: > >>>>> Whatever asking for an explanation as to why equivalent functionality > >>>>> cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > >>>> > >>>> Fully agreed and this is especially true for a change this size > >>>> 77 files changed, 3406 insertions(+), 703 deletions(-) > >>> > >>> In the case of memory allocation accounting, you flat cannot do this with ftrace > >>> - you could maybe do a janky version that isn't fully accurate, much slower, > >>> more complicated for the developer to understand and debug and more complicated > >>> for the end user. > >>> > >>> But please, I invite anyone who's actually been doing this with ftrace to > >>> demonstrate otherwise. > >>> > >>> Ftrace just isn't the right tool for the job here - we're talking about adding > >>> per callsite accounting to some of the fastest fast paths in the kernel. > >>> > >>> And the size of the changes for memory allocation accounting are much more > >>> reasonable: > >>> 33 files changed, 623 insertions(+), 99 deletions(-) > >>> > >>> The code tagging library should exist anyways, it's been open coded half a dozen > >>> times in the kernel already. > >> > >> Hi Kent, > >> > >> independent of the other discussions, if it's open coded already, does > >> it make sense to factor that already-open-coded part out independently > >> of the remainder of the full series here? > > > > It's discussed in the cover letter, that is exactly how the patch series is > > structured. > > Skimming over the patches (that I was CCed on) and skimming over the > cover letter, I got the impression that everything after patch 7 is > introducing something new instead of refactoring something out. Hi David, Yes, you are right, the RFC does incorporate lots of parts which can be considered separately. They are sent together to present the overall scope of the proposal but I do intend to send them separately once we decide if it's worth working on. Thanks, Suren. > > > > >> [I didn't immediately spot if this series also attempts already to > >> replace that open-coded part] > > > > Uh huh. > > > > Honestly, some days it feels like lkml is just as bad as slashdot, with people > > wanting to get in their two cents without actually reading... > > ... and of course you had to reply like that. I should just have learned > from my last upstream experience with you and kept you on my spam list. > > Thanks, bye > > -- > Thanks, > > David / dhildenb > From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:40:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396799.637122 (Exim 4.92) (envelope-from ) id 1oTmIc-0007YQ-J6; Thu, 01 Sep 2022 15:40:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396799.637122; Thu, 01 Sep 2022 15:40:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmIc-0007YH-F2; Thu, 01 Sep 2022 15:40:10 +0000 Received: by outflank-mailman (input) for mailman id 396799; Thu, 01 Sep 2022 15:40:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmIb-0007Xn-Cj for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:40:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmIb-0006nR-2z; Thu, 01 Sep 2022 15:40:09 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTmIa-0000id-Sh; Thu, 01 Sep 2022 15:40:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KPRpPBebM4gjx9WMpJsAaLLlk7R/JZF85jsc/EGU+0k=; b=z6arhtJ4qNfD5LWuXvnlrPPWx3 XGNa7fw3AvFaH13zC8wqJnZaIa/K88/Z+qm07ueKqrgeKTyjxrDmLS3kueoh73AAn/70BIvAusf3U xhCTUvYjfBn52Z8l4IbPfU/jTTe5bHjYE5PXmoJBPT7qPXLKnMoF4qkECc0BR35P+hwk=; Message-ID: <3b58faef-d87d-3381-f54d-8ccdc0ea105f@xen.org> Date: Thu, 1 Sep 2022 16:40:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v6 1/9] xen/arm: introduce static shared memory Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220721132115.3015761-1-Penny.Zheng@arm.com> <20220721132115.3015761-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 29/08/2022 07:57, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Friday, August 26, 2022 9:17 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Stefano Stabellini ; Bertrand Marquis >> ; Volodymyr Babchuk >> >> Subject: Re: [PATCH v6 1/9] xen/arm: introduce static shared memory >> >> Hi Penny, >> > > Hi Julien > >> On 21/07/2022 14:21, Penny Zheng wrote: >>> From: Penny Zheng >>> >>> This patch series introduces a new feature: setting up static shared >>> memory on a dom0less system, through device tree configuration. >>> >>> This commit parses shared memory node at boot-time, and reserve it in >>> bootinfo.reserved_mem to avoid other use. >>> >>> This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap >>> static-shm-related codes, and this option depends on static memory( >>> CONFIG_STATIC_MEMORY). That's because that later we want to reuse a >>> few helpers, guarded with CONFIG_STATIC_MEMORY, like >>> acquire_staticmem_pages, etc, on static shared memory. >>> >>> Signed-off-by: Penny Zheng >>> --- >>> v6 change: >>> - when host physical address is ommited, output the error message >>> since xen doesn't support it at the moment >>> - add the following check: 1) The shm ID matches and the region >>> exactly match >>> 2) The shm ID doesn't match and the region doesn't overlap >>> - change it to "unsigned int" to be aligned with nr_banks >>> - check the len of the property to confirm is it big enough to contain >>> "paddr", "size", and "gaddr" >>> - shm_id defined before nr_shm_domain, so we could re-use the existing >>> hole and avoid increasing the size of the structure. >>> - change "nr_shm_domain" to "nr_shm_borrowers", to not increment if >>> the role is owner in parsing code >>> - make "xen,shm_id" property as arbitrary string, with a strict limit >>> on the number of characters, MAX_SHM_ID_LENGTH >>> --- >>> v5 change: >>> - no change >>> --- >>> v4 change: >>> - nit fix on doc >>> --- >>> v3 change: >>> - make nr_shm_domain unsigned int >>> --- >>> v2 change: >>> - document refinement >>> - remove bitmap and use the iteration to check >>> - add a new field nr_shm_domain to keep the number of shared domain >>> --- >>> docs/misc/arm/device-tree/booting.txt | 124 ++++++++++++++++++++ >>> xen/arch/arm/Kconfig | 6 + >>> xen/arch/arm/bootfdt.c | 157 ++++++++++++++++++++++++++ >>> xen/arch/arm/include/asm/setup.h | 9 ++ >>> 4 files changed, 296 insertions(+) >>> >>> diff --git a/docs/misc/arm/device-tree/booting.txt >>> b/docs/misc/arm/device-tree/booting.txt >>> index 98253414b8..8013fb98fe 100644 >>> --- a/docs/misc/arm/device-tree/booting.txt >>> +++ b/docs/misc/arm/device-tree/booting.txt >>> @@ -378,3 +378,127 @@ device-tree: >>> >>> This will reserve a 512MB region starting at the host physical address >>> 0x30000000 to be exclusively used by DomU1. >>> + >>> +Static Shared Memory >>> +==================== >>> + >>> +The static shared memory device tree nodes allow users to statically >>> +set up shared memory on dom0less system, enabling domains to do >>> +shm-based communication. >>> + >>> +- compatible >>> + >>> + "xen,domain-shared-memory-v1" >>> + >>> +- xen,shm-id >>> + >>> + An arbitrary string that represents the unique identifier of the shared >>> + memory region, with a strict limit on the number of characters(\0 >> included), >>> + `MAX_SHM_ID_LENGTH(16)`. e.g. "xen,shm-id = "my-shared-mem-1"". >>> + >>> +- xen,shared-mem >>> + >>> + An array takes a physical address, which is the base address of the >>> + shared memory region in host physical address space, a size, and a >> guest >>> + physical address, as the target address of the mapping. >>> + e.g. xen,shared-mem = < [host physical address] [size] [guest >>> + address] > >> >> Your implementation below is checking for overlap and also have some >> restriction. Can they be documented in the binding? >> >>> + >>> + The number of cells for the host address (and size) is the same as the >>> + guest pseudo-physical address and they are inherited from the parent >> node. >> >> In v5, we discussed to have the host address optional. However, the binding >> has not been updated to reflect that. Note that I am not asking to implement, >> but instead request that the binding can be used for such setup. >> > > How about: > " > Host physical address could be omitted by users, and let Xen decide where it locates. > " I am fine with that. > Do you think I shall further point out that right now, this part feature is not implemented > in codes? I have made a couple of suggestion for the code. But I think the binding would look a bit odd without the host physical address. We would now have: < [size] [guest address]> I think it would be more natural if we had <[guest address] [size]> And <[guest address] [size] [host physical address]> > >>> a/xen/arch/arm/include/asm/setup.h >> b/xen/arch/arm/include/asm/setup.h >>> index 2bb01ecfa8..39d4e93b8b 100644 >>> --- a/xen/arch/arm/include/asm/setup.h >>> +++ b/xen/arch/arm/include/asm/setup.h >>> @@ -23,10 +23,19 @@ typedef enum { >>> } bootmodule_kind; >>> >>> >>> +#ifdef CONFIG_STATIC_SHM >>> +/* Indicates the maximum number of characters(\0 included) for shm_id >>> +*/ #define MAX_SHM_ID_LENGTH 16 #endif >> >> Is the #ifdef really needed? >> >>> + >>> struct membank { >>> paddr_t start; >>> paddr_t size; >>> bool xen_domain; /* whether the memory bank is bound to a Xen >>> domain. */ >>> +#ifdef CONFIG_STATIC_SHM >>> + char shm_id[MAX_SHM_ID_LENGTH]; >>> + unsigned int nr_shm_borrowers; >>> +#endif >>> }; >> >> If I calculated right, the structure will grow from 24 to 40 bytes. At the >> moment, this is protected with CONFIG_STATIC_SHM which is unsupported. >> However, I think we will need to do something as we can't continue to grow >> 'membank' like that. >> >> I don't have a quick suggestion for 4.17 (the feature freeze is in a week). Long >> term, I think we will want to consider to move the shm ID in a separate array >> that could be referenced here. >> >> The other solution would be to have the shared memory regions in a >> separate array. They would have their own structure which would either >> embedded "membank" or contain a pointer/index to the bank. >> > > Ok, so other than this fixing, others will be addressed in the next serie. And this > part fixing will be introduced in a new follow-up patch serie after 4.17 release. > > I'm in favor of introducing a new structure to contain shm-related data and let > 'membank' contains a pointer to it, like > ``` > +struct shm_membank { > + char shm_id[MAX_SHM_ID_LENGTH]; > + unsigned int nr_shm_borrowers; > +} > + > struct membank { > paddr_t start; > paddr_t size; > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > + struct shm_membank *shm; > }; > ``` > Then every time we introduce a new feature here, following this strategy, 'membank' will > at most grow 8 bytes for the reference. Be aware that we are very early in Xen and therefore dynamically allocating memory is not possible. Therefore 'shm_membank' would most likely need to be static. At which point, this could be an index. > > I'm open to the discussion and will let it decide what it finally will be. ;) My original idea was to have 'shm_membank' pointing to the 'membank' rather than the other way around. But I don't have a strong argument either way. So I would need to see the resulting code. Anyway, that's for post-4.17. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:43:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:43:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396812.637133 (Exim 4.92) (envelope-from ) id 1oTmLu-0008WS-7L; Thu, 01 Sep 2022 15:43:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396812.637133; Thu, 01 Sep 2022 15:43:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmLu-0008WJ-40; Thu, 01 Sep 2022 15:43:34 +0000 Received: by outflank-mailman (input) for mailman id 396812; Thu, 01 Sep 2022 15:43:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmLs-0008W8-Kg for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:43:33 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d425fe7d-2a0c-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 17:43:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d425fe7d-2a0c-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 11:43:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662047009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OCuFL4N5GVZjONQAdChOE7OJr7ThTUJDCIIbzLkwFEk=; b=Zug2Ft4Qd/net99BOTd8W8Yfuju//gSHL3gkzYXZLEVciKsEhf1UkIyXgrPgVXlVt/CoSK WIJngXjsqZ/WvBYvq+hwDukTtw4VIC1L39QDy0ARuz5vTfzc62/XGVpvD13hkozhflqLO3 W0o6TaATn9DtFDXStAFl/opHuur0FVU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/30] Lazy percpu counters Message-ID: <20220901154321.apyq7246srkjthfr@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-4-surenb@google.com> <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> <20220901104839.5691e1c9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901104839.5691e1c9@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 10:48:39AM -0400, Steven Rostedt wrote: > On Thu, 1 Sep 2022 10:32:19 -0400 > Kent Overstreet wrote: > > > On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > > > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > > > +static void lazy_percpu_counter_switch_to_pcpu(struct raw_lazy_percpu_counter *c) > > > > +{ > > > > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__GFP_NOWARN); > > > > > > Realize that this is incorrect when used under a raw_spinlock_t. > > > > Can you elaborate? > > All allocations (including GFP_ATOMIC) grab normal spin_locks. When > PREEMPT_RT is configured, normal spin_locks turn into a mutex, where as > raw_spinlock's do not. > > Thus, if this is done within a raw_spinlock with PREEMPT_RT configured, it > can cause a schedule while holding a spinlock. Thanks, I think we should be good here but I'll document it anyways. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:44:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:44:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396818.637144 (Exim 4.92) (envelope-from ) id 1oTmNA-0000f0-Ht; Thu, 01 Sep 2022 15:44:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396818.637144; Thu, 01 Sep 2022 15:44:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmNA-0000et-Em; Thu, 01 Sep 2022 15:44:52 +0000 Received: by outflank-mailman (input) for mailman id 396818; Thu, 01 Sep 2022 15:44:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmN8-0000en-Uy for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:44:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03682c99-2a0d-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 17:44:50 +0200 (CEST) Received: from AM0PR04CA0039.eurprd04.prod.outlook.com (2603:10a6:208:1::16) by DU0PR08MB7762.eurprd08.prod.outlook.com (2603:10a6:10:3ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 15:44:47 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:1:cafe::b0) by AM0PR04CA0039.outlook.office365.com (2603:10a6:208:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Thu, 1 Sep 2022 15:44:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 15:44:46 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 01 Sep 2022 15:44:46 +0000 Received: from 9f7076c55a13.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 812F3DED-5ED3-4AB0-863D-A3F1ED39A217.1; Thu, 01 Sep 2022 15:44:35 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f7076c55a13.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 15:44:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB6649.eurprd08.prod.outlook.com (2603:10a6:10:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 15:44:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 15:44:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03682c99-2a0d-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QN8o/wMam1+5XXH76oSxCyDMkz9Prmtd0puBFCL5UpaMfjXWp20mgnEvRza2/530yWi7OLrurMa3P7KN1PwKcUVYdh3eJ0Z1CwzT8y6mWxKxYe9IQD4kAr1JU6rKs/uNuf2wmYAdyAzXI4yamrojOOikuiETQGRMDg5arD0nWypKt8XofzLAYHVOuNTC1LD/Mle7nZlBMZXn3Ki9UX/DkhHA6t9X+H8HkvDUPP5/N7DLc2EKSUfdhvPSUNuVZP5pFflN2hh3iQalQfWyiYaEqCXTiKDQz6b8piNPqGfs+5qjancQgWEg9mvHpGjK88H89jyDAY/hhO7bK+tw3jStlw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tr+GU2JynkP1mO1AW5MNNgmi2VPjckuL/jYHo82eAgY=; b=MSBkipyFvl6efopEdqoEghkIsykWQRaP2CFzjDlaQnALRZ/WBa6zRqdYxxu9UfL7LI9/+Chs4NuKOUz552wMLK46zaR590zL9pfDspFCLlI5FLc61c1M6hoPPbZLadpKQ4SM8ryuB/UHkhgUSg+B3yrtHjdQ4RYGEjSinzXkvWf8eSVQk8ga469WF8wunYJf/rx9N1yh07eUzmTibhy9yh24jzYQq6Y840HPp1dIodWOsVnM491pCtgzWQJoFKbH5BCwsowxWH6aQ3Co8X/2khggGRAlYuZyOx7CF5Aq/+WBos2y0p7p2k2mXtOgxIB7aBPJ3xUnv28cd8fiznCwfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tr+GU2JynkP1mO1AW5MNNgmi2VPjckuL/jYHo82eAgY=; b=alEFnauJLA7TcI3+CRQGsea2IXBX3QZGO1vmkHGZS9sRq9UPu4Q3QeLXpcn4RPoXDjRL53rMHiDRPPDhi2W5xUNI4sfnt91Z+Yhfyj/JlkkDW5Mr9MxrWMDDTDOyxfU7Vr2JyZwAqVlupVsSZnRa4y8tmFh4yuRjpzs1EGEjUtc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b4b49849e15151c9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MyUvF7zkgVMrMlIxJXUIBX0WhHes2URBx3m4nkR0fghBhqSEOGe36I1IC0x9o9lVfI52TlXaFh+tWszltGx+dz7KyQIXwb/8nuVLKpmxa3Oy7o3Gi/vCkI4Ddv+K2T09xljMlZ/ug7Do6sYcSzLDau70I3+cFVd6uaCEoLrmz0+uNn1c/ztvTXvtNFHIm8cL91ZDonF0PL+5/hoBuhLQZA2wRvSP0KjWRvUIGNreL/jf8braIo1Nr+WPlVfAbNHAj3bBk2/QIRfl7Rd3O+V45s5fdclDCFFq1VfUTK4zsbUmvibWFQ3LThKYOYOczjcVuWB6iCSVrgUPeaHZzDbhjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tr+GU2JynkP1mO1AW5MNNgmi2VPjckuL/jYHo82eAgY=; b=YhdmDWbBCRa3dDE2+/G52ig+6Q1nSpJl1Q7DFCcWMDqc2/snfKdkwKqzWOKN1bu99RuuKyMP7Oda5b8m7X5uf0wOCSSPa8UuUU9dzBZl5NcVkBX12W9Wuyg478W/95tjAYn2Ypmn9fOkb5Iwj9dEuk0JjpAdl3dUbhvZFW6CdPvoUCQ1lKLsFuNTx3VLLx1nENiialJN75TNw5S8dtpHIr5GkKzQsy6MRKKeqpWgqYOaN247ZllZ8MLY3D7I/2HzYPicR+iukJ/hEpLR9crYGIybyuATWClqIBIwHuMbRcSKKU3myM7E74uqPZ6eFGDyOlqlRQspfk3SbwP5bBEcQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tr+GU2JynkP1mO1AW5MNNgmi2VPjckuL/jYHo82eAgY=; b=alEFnauJLA7TcI3+CRQGsea2IXBX3QZGO1vmkHGZS9sRq9UPu4Q3QeLXpcn4RPoXDjRL53rMHiDRPPDhi2W5xUNI4sfnt91Z+Yhfyj/JlkkDW5Mr9MxrWMDDTDOyxfU7Vr2JyZwAqVlupVsSZnRa4y8tmFh4yuRjpzs1EGEjUtc= From: Bertrand Marquis To: Julien Grall CC: Penny Zheng , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v6 1/9] xen/arm: introduce static shared memory Thread-Topic: [PATCH v6 1/9] xen/arm: introduce static shared memory Thread-Index: AQHYnQTSz9lI9i8180Oxe885mt1wV63BYj8AgARM6wCABUkEAIAAAToA Date: Thu, 1 Sep 2022 15:44:30 +0000 Message-ID: <9B6588DA-6314-4048-9AF8-C46EA7C2AE6C@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> <20220721132115.3015761-2-Penny.Zheng@arm.com> <3b58faef-d87d-3381-f54d-8ccdc0ea105f@xen.org> In-Reply-To: <3b58faef-d87d-3381-f54d-8ccdc0ea105f@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b34fbfb0-bbbb-48c7-1af7-08da8c30e5f3 x-ms-traffictypediagnostic: DB9PR08MB6649:EE_|VE1EUR03FT064:EE_|DU0PR08MB7762:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: axMOJLKlpIRPNCX8RIP8FZVXPod2dJFJVXXgUv6xFkBEekeRwn4SXPOlAGPwN+ANRG9jfR/PclmUm748lDhgwsTP0bDQlSwKtWvfdLCOg4GG0kQCqrgWRsq1vrpq3Uxg+t5II4omTXMY2IUji9Xj8tpgxuOCiZrygBlvjhTRxNMVgNq7wzw2exR+dLHP0c9YNGV3YuNi77X4wjjk8mqMmRebyjX8Ou7Y80a5en/B4keboqAw8766+QbAL6u+Zc0eXoIaDnE/rc8MbemXWSxpr7mC4LJL68RsflVwX8Ifu5AzOFUpERF8+FWYOIdoQLCfbItLerWIPbmtb5X5JCOEJNxuiUd/IQJW6tNjj0cdVOxirD80wYTG4KSmujfdcLi4lCI95GR/LcUxozvSIs92HkVgyrnN55gDBDO8vVMYu8c4AtzLEyfuyGqIazNm2p738E76ySLe0+a01Emxt7WneR19KEHyZYls49offiB0R3PM60kQ3DtLci8vh7+63vC5JgSLxMmjDX6RaLfW17aSJ1CEsfNfY/0Ce4RYFGvXJ+SZU5+rTso3RUqebFYEO/7CbvADDf5k3G4A0+rWZFQgWslVN23lh86ACub4soqPxPq1BpcN6ISC7m/kXZV4ce7qCWA2Oc64xh3A+M2yk9Q/3MwpHhc7hucl6nw775QRExkuIxAO+4cK0nBBxVbMXEMeTK7MZ9cF0yP82ANdjWnNrFZ4er/gMfb7Qe4vxrXxZC1FwTs6bhnt+DmsareLXbNzxTqSXy1NkbVeMWqVfxBGuyAiVbrRqJQ2x0LChFoBKyE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(346002)(376002)(39860400002)(136003)(8936002)(5660300002)(91956017)(66556008)(64756008)(76116006)(66446008)(6916009)(66476007)(8676002)(2906002)(36756003)(4326008)(66946007)(33656002)(316002)(54906003)(478600001)(6486002)(71200400001)(53546011)(41300700001)(6506007)(6512007)(26005)(83380400001)(86362001)(186003)(2616005)(38070700005)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6649 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1d290648-55a2-44dc-d7fc-08da8c30dc65 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f+Z1dRTFCP74iKlsMcU+5B8JNrxLKnnFQ0bNM3ymM/n2UqsHoBv25T2z2pZ25cmx2Iv+kuHYcZ4QEccp0LnHcf5nISixuXOKxkoT/GZ7ASCnX5ARZkCMGMtvNU3NWleU7mTSAdyknHWPhqOc8lTbpjRttdzhoNEsV5LDbBWMIsaxfW6TSDakKZ8En8SidSWWPbpW2ZIfRgxGnQY5nbIhJDxqoJZWmV+n58ehm3/OLbmYUvVYxLVjLNso+RePSrxP4qVy4GoXxg6AWrVsqdbia9Op9Ipk4Tp+Co8ipIR39FvJ2pzA722X17ci8LvUXUkW9giHw248j3FS1Dd9gvvOLi50kkUJbU/VRyr5lDCbvFGPNaq+jTq2w+siXZxHQN9llDR/wsikr3vtTY1DQRMQSXCyISpbq8eW2FDIVvcjmdexo7YxcK1MEiCoJTvDQSOG5zNJfSkB7LNEREEnZptgEKn9WwryQmyeOel4bUyT9vtRLgTA1K8j7QT5up1WDcQ/f2vkxa9L8TZqU5u7b0XHDhV3skaMjsA1HOmzhdlGVPy2BsSsNAwIBnfZelLd6zgQNwD+0+MxVMaF19n6DejsikQYfKN+oOGVX99uUzqL7WRlZ96yX0m+vYtde3mJedTOjvjzj8V5OiLze1LXGyqVi1fBVGeZ+xzyewLZBExTKkoHIw6b/jbhLRFjG0B6Yo4zxzg/aJutm1kC87mNzJ5pZWRKHlbhI6B6XSNXasXMfuJrZbCTkaj+r/c/Lfov8GrR2SHtTRZWTSi+s+tBQkRVsQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966006)(40470700004)(36840700001)(5660300002)(82740400003)(53546011)(83380400001)(2616005)(36860700001)(36756003)(2906002)(6512007)(82310400005)(6506007)(26005)(6862004)(33656002)(54906003)(70206006)(70586007)(107886003)(4326008)(8936002)(316002)(6486002)(336012)(478600001)(86362001)(40460700003)(356005)(47076005)(8676002)(186003)(81166007)(41300700001)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:44:46.9173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b34fbfb0-bbbb-48c7-1af7-08da8c30e5f3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7762 Hi, > On 1 Sep 2022, at 16:40, Julien Grall wrote: >=20 > Hi Penny, >=20 > On 29/08/2022 07:57, Penny Zheng wrote: >>> -----Original Message----- >>> From: Julien Grall >>> Sent: Friday, August 26, 2022 9:17 PM >>> To: Penny Zheng ; xen-devel@lists.xenproject.org >>> Cc: Stefano Stabellini ; Bertrand Marquis >>> ; Volodymyr Babchuk >>> >>> Subject: Re: [PATCH v6 1/9] xen/arm: introduce static shared memory >>>=20 >>> Hi Penny, >>>=20 >> Hi Julien >> =20 >>> On 21/07/2022 14:21, Penny Zheng wrote: >>>> From: Penny Zheng >>>>=20 >>>> This patch series introduces a new feature: setting up static shared >>>> memory on a dom0less system, through device tree configuration. >>>>=20 >>>> This commit parses shared memory node at boot-time, and reserve it in >>>> bootinfo.reserved_mem to avoid other use. >>>>=20 >>>> This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap >>>> static-shm-related codes, and this option depends on static memory( >>>> CONFIG_STATIC_MEMORY). That's because that later we want to reuse a >>>> few helpers, guarded with CONFIG_STATIC_MEMORY, like >>>> acquire_staticmem_pages, etc, on static shared memory. >>>>=20 >>>> Signed-off-by: Penny Zheng >>>> --- >>>> v6 change: >>>> - when host physical address is ommited, output the error message >>>> since xen doesn't support it at the moment >>>> - add the following check: 1) The shm ID matches and the region >>>> exactly match >>>> 2) The shm ID doesn't match and the region doesn't overlap >>>> - change it to "unsigned int" to be aligned with nr_banks >>>> - check the len of the property to confirm is it big enough to contain >>>> "paddr", "size", and "gaddr" >>>> - shm_id defined before nr_shm_domain, so we could re-use the existing >>>> hole and avoid increasing the size of the structure. >>>> - change "nr_shm_domain" to "nr_shm_borrowers", to not increment if >>>> the role is owner in parsing code >>>> - make "xen,shm_id" property as arbitrary string, with a strict limit >>>> on the number of characters, MAX_SHM_ID_LENGTH >>>> --- >>>> v5 change: >>>> - no change >>>> --- >>>> v4 change: >>>> - nit fix on doc >>>> --- >>>> v3 change: >>>> - make nr_shm_domain unsigned int >>>> --- >>>> v2 change: >>>> - document refinement >>>> - remove bitmap and use the iteration to check >>>> - add a new field nr_shm_domain to keep the number of shared domain >>>> --- >>>> docs/misc/arm/device-tree/booting.txt | 124 ++++++++++++++++++++ >>>> xen/arch/arm/Kconfig | 6 + >>>> xen/arch/arm/bootfdt.c | 157 ++++++++++++++++++++++++= ++ >>>> xen/arch/arm/include/asm/setup.h | 9 ++ >>>> 4 files changed, 296 insertions(+) >>>>=20 >>>> diff --git a/docs/misc/arm/device-tree/booting.txt >>>> b/docs/misc/arm/device-tree/booting.txt >>>> index 98253414b8..8013fb98fe 100644 >>>> --- a/docs/misc/arm/device-tree/booting.txt >>>> +++ b/docs/misc/arm/device-tree/booting.txt >>>> @@ -378,3 +378,127 @@ device-tree: >>>>=20 >>>> This will reserve a 512MB region starting at the host physical addre= ss >>>> 0x30000000 to be exclusively used by DomU1. >>>> + >>>> +Static Shared Memory >>>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> + >>>> +The static shared memory device tree nodes allow users to statically >>>> +set up shared memory on dom0less system, enabling domains to do >>>> +shm-based communication. >>>> + >>>> +- compatible >>>> + >>>> + "xen,domain-shared-memory-v1" >>>> + >>>> +- xen,shm-id >>>> + >>>> + An arbitrary string that represents the unique identifier of the = shared >>>> + memory region, with a strict limit on the number of characters(\0 >>> included), >>>> + `MAX_SHM_ID_LENGTH(16)`. e.g. "xen,shm-id =3D "my-shared-mem-1"". >>>> + >>>> +- xen,shared-mem >>>> + >>>> + An array takes a physical address, which is the base address of t= he >>>> + shared memory region in host physical address space, a size, and = a >>> guest >>>> + physical address, as the target address of the mapping. >>>> + e.g. xen,shared-mem =3D < [host physical address] [size] [guest >>>> + address] > >>>=20 >>> Your implementation below is checking for overlap and also have some >>> restriction. Can they be documented in the binding? >>>=20 >>>> + >>>> + The number of cells for the host address (and size) is the same a= s the >>>> + guest pseudo-physical address and they are inherited from the par= ent >>> node. >>>=20 >>> In v5, we discussed to have the host address optional. However, the bin= ding >>> has not been updated to reflect that. Note that I am not asking to impl= ement, >>> but instead request that the binding can be used for such setup. >>>=20 >> How about: >> " >> Host physical address could be omitted by users, and let Xen decide wher= e it locates. >> " >=20 > I am fine with that. >=20 >> Do you think I shall further point out that right now, this part feature= is not implemented >> in codes? >=20 > I have made a couple of suggestion for the code. But I think the binding = would look a bit odd without the host physical address. We would now have: >=20 > < [size] [guest address]> >=20 > I think it would be more natural if we had >=20 > <[guest address] [size]> >=20 > And >=20 > <[guest address] [size] [host physical address]> >=20 >>>> a/xen/arch/arm/include/asm/setup.h >>> b/xen/arch/arm/include/asm/setup.h >>>> index 2bb01ecfa8..39d4e93b8b 100644 >>>> --- a/xen/arch/arm/include/asm/setup.h >>>> +++ b/xen/arch/arm/include/asm/setup.h >>>> @@ -23,10 +23,19 @@ typedef enum { >>>> } bootmodule_kind; >>>>=20 >>>>=20 >>>> +#ifdef CONFIG_STATIC_SHM >>>> +/* Indicates the maximum number of characters(\0 included) for shm_id >>>> +*/ #define MAX_SHM_ID_LENGTH 16 #endif >>>=20 >>> Is the #ifdef really needed? >>>=20 >>>> + >>>> struct membank { >>>> paddr_t start; >>>> paddr_t size; >>>> bool xen_domain; /* whether the memory bank is bound to a Xen >>>> domain. */ >>>> +#ifdef CONFIG_STATIC_SHM >>>> + char shm_id[MAX_SHM_ID_LENGTH]; >>>> + unsigned int nr_shm_borrowers; >>>> +#endif >>>> }; >>>=20 >>> If I calculated right, the structure will grow from 24 to 40 bytes. At = the >>> moment, this is protected with CONFIG_STATIC_SHM which is unsupported. >>> However, I think we will need to do something as we can't continue to g= row >>> 'membank' like that. >>>=20 >>> I don't have a quick suggestion for 4.17 (the feature freeze is in a we= ek). Long >>> term, I think we will want to consider to move the shm ID in a separate= array >>> that could be referenced here. >>>=20 >>> The other solution would be to have the shared memory regions in a >>> separate array. They would have their own structure which would either >>> embedded "membank" or contain a pointer/index to the bank. >>>=20 >> Ok, so other than this fixing, others will be addressed in the next seri= e. And this >> part fixing will be introduced in a new follow-up patch serie after 4.17= release. >> I'm in favor of introducing a new structure to contain shm-related data = and let >> 'membank' contains a pointer to it, like >> ``` >> +struct shm_membank { >> + char shm_id[MAX_SHM_ID_LENGTH]; >> + unsigned int nr_shm_borrowers; >> +} >> + >> struct membank { >> paddr_t start; >> paddr_t size; >> bool xen_domain; /* whether the memory bank is bound to a Xen domai= n. */ >> + struct shm_membank *shm; >> }; >> ``` >> Then every time we introduce a new feature here, following this strategy= , 'membank' will >> at most grow 8 bytes for the reference. >=20 > Be aware that we are very early in Xen and therefore dynamically allocati= ng memory is not possible. Therefore 'shm_membank' would most likely need t= o be static. >=20 > At which point, this could be an index. >=20 >> I'm open to the discussion and will let it decide what it finally will b= e. ;) >=20 > My original idea was to have 'shm_membank' pointing to the 'membank' rath= er than the other way around. But I don't have a strong argument either way= . >=20 > So I would need to see the resulting code. Anyway, that's for post-4.17. Following ongoing gitlab discussion, it might be a good example of a case w= here creating a new gitlab ticket would make sense :-) Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:45:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396820.637154 (Exim 4.92) (envelope-from ) id 1oTmNa-00014b-Qr; Thu, 01 Sep 2022 15:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396820.637154; Thu, 01 Sep 2022 15:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmNa-00014U-NW; Thu, 01 Sep 2022 15:45:18 +0000 Received: by outflank-mailman (input) for mailman id 396820; Thu, 01 Sep 2022 15:45:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmNZ-000144-4z for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:45:17 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150041.outbound.protection.outlook.com [40.107.15.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12370bdc-2a0d-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 17:45:15 +0200 (CEST) Received: from DB8P191CA0004.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::14) by DB9PR08MB8739.eurprd08.prod.outlook.com (2603:10a6:10:3d1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 15:45:13 +0000 Received: from DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::80) by DB8P191CA0004.outlook.office365.com (2603:10a6:10:130::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 15:45:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT027.mail.protection.outlook.com (100.127.142.237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 15:45:13 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 01 Sep 2022 15:45:12 +0000 Received: from cfc7f4c03195.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2C247EC8-4C63-461C-83EA-708298A56978.1; Thu, 01 Sep 2022 15:45:02 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cfc7f4c03195.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 15:45:02 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB8436.eurprd08.prod.outlook.com (2603:10a6:10:3d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 15:45:00 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 15:44:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12370bdc-2a0d-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fbQFrs1sXMlx9WrJFcKt4OhKOJ+is9A0+jjrw1jyhVoieu82rLZ8iUeC5ajpA+S+bCFyqOYLKJr94ZWWGCpOeaBlHkMDYNKMLO9gSp3dEPIifWNACbIJDvACN3x2Kwl/TNI+Bw3N2/KnqWuP1iX5t/XqlDBSPVxuzeQMidiz8AitEl4Nq8l/OO8elq5FXjqQxeUAB+pS2yCpm/HH3v8rbHif0PRmEqvlFsG8LwKn2tGFuURToCKNgLGV4r3fe4fvIOj7wZJtz24dbn7Iwro43lxdf8/XXgyQ/Tbb1FSm8ieq+3RJM/adsGJgCQGPgFOYv/xlXwGk8HokxTg3OpZdJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4SsNd35CtOlcvxyDaUqih9TSX4ZvggNCWsBQN7ZI98s=; b=bHcGw81GUTmj3uABvRE9AuJeUWRTyHub7sCScsEYLkE6VvmdFi2BRuIfOPo25WJUym0AAPCB4Sb9q1kkRbZMytuCk6QVilnX34niTUBojaq1mXz7AW1HcdDk6bn9E/9zT9I5MiGnJ/D7d8bFj7Mf85dzk2Uw9AR7GKsCaQsXS6pFUZxq4FevhifIMU7AqFnSozuzbpCsPLUGahOeBbPAQG8Vdz286S+qJhjpeoZYaHLOVA2ZubPFwmRl8tr7qPIvaW1YC2ju/liNaMJgzA8BN95o3zdGuBvHTG0AygAjmBj2wLcr5w82Cr2jL/PyS4I5woujmYN69jlEl9fVM2c/8w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4SsNd35CtOlcvxyDaUqih9TSX4ZvggNCWsBQN7ZI98s=; b=ZToEZmRRQcjDRW6OFfzh9M6f+gQ0+InsyOVPWKUHr9GlPLgZXIJ0Rf+CMVygLLkb8qjtFO8xEMEuc9Qh+deOiqxm2ANUdHn80yO0TN2Z7w7EEiHqAB/Y6Em5LEPIMveIN+6ZLSINlBPQ59lr6YAy60LnO0Y+e+wA9yZwGm0slX4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3TbteVgelgdQv7u6jM45yPzAlQt1Uo+m16akNAgBwQkYBC1nCmMMkKDG76tJdhyICSO8GxizaSWstJe9IXUFsfCJGL0IkrhZvWSaTpdMV+tnCP9cf2SwRaMy1dtkoQQphyQIKJ7hPyal0tjvLzY6Yk63DOgrxd955z2nQhIXfFDjFzLBNP1aSn4FoBF3QU8OuUyuyFhWfQw+oDwfE8U4dQbHF/BZ73nvZBTbWP0121AHa2QOSK4z4NOG6my6lGxRPUnrolRsijjwIbyhLx9ST5TgiqP+pe7NCCSUQSZGvpEvuuQRUm1BHHcCzNiSkz4g/A5rnq35eh5+QTGfoF/iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4SsNd35CtOlcvxyDaUqih9TSX4ZvggNCWsBQN7ZI98s=; b=HuGXWkJ/RbcF97Bed4U6Ba9XCK9AvgaIUhrbkCnb7aPTJiAtvvZRWey8csFumZy80PakviqGgH9zPLa0OemyFqPYTROq/CPYBJ0f6JpUBEYBL+CquZPWiAVLI0Mz51Fj4RJs2TcBxeyFxSetLHGZzZXLhgnstTyOO3Eo49NhAx7U9u4C825gOlXGT0/5fvUv1If7Uet1nJCHjQYfCUXG+MCalTGFKYlI0+Y72/xgKYgWJBmiFgBDxU7oIBJBzMSViBNZCzUY41ITp7cTlaz7ELUle61kqvcKWTFeOXIdLWdhdIPqUesLwntTdM1iOpcclWCjBVhqlOc1TLuwauNGcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4SsNd35CtOlcvxyDaUqih9TSX4ZvggNCWsBQN7ZI98s=; b=ZToEZmRRQcjDRW6OFfzh9M6f+gQ0+InsyOVPWKUHr9GlPLgZXIJ0Rf+CMVygLLkb8qjtFO8xEMEuc9Qh+deOiqxm2ANUdHn80yO0TN2Z7w7EEiHqAB/Y6Em5LEPIMveIN+6ZLSINlBPQ59lr6YAy60LnO0Y+e+wA9yZwGm0slX4= From: Henry Wang To: Bertrand Marquis , xen-devel CC: Jan Beulich , Julien Grall , Stefano Stabellini , Andrew Cooper , Juergen Gross , Anthony PERARD , George Dunlap Subject: RE: Push 4.17 Feature freeze and Code freeze one week later Thread-Topic: Push 4.17 Feature freeze and Code freeze one week later Thread-Index: AQHYvhXwY5ksNZUEbUKzv0CjRBnFYK3KsCCA Date: Thu, 1 Sep 2022 15:44:59 +0000 Message-ID: References: <2745BA23-B42E-49E2-89A2-59A0ED70388F@arm.com> In-Reply-To: <2745BA23-B42E-49E2-89A2-59A0ED70388F@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8D35FE9FF03492489B0764B48EF6AB9E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 59748237-588b-40a1-3d69-08da8c30f572 x-ms-traffictypediagnostic: DB9PR08MB8436:EE_|DBAEUR03FT027:EE_|DB9PR08MB8739:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gKeMFMvWwuKpkk2JD3NS/hjlUjIE0VM+ppmjCLfrKebWPvCBef15pUskEQy3CkrnvRF+8G4TMCZZOfhPS7Uv42DRPPnXsg8Kip8rVVbQ5TW5g1upmko+UX8HiTIfVZmeG8poEKwPyACnbainYntbsOXznExCdxyqpkKQwwzhoTLhHF4xdVLYP3gly/8teeeMFB/NzQG/JsgwrsaslF8Pyh79QiTiLBfqvsqLapo/U6VR01TCk83q4N9AT+UZh6FiywEhD1lp1fq8dZgCK/qsiYPRCQ3//J5xLbGSNdJhROgJDXgly6F6EASwDpkUJf5O/x9qa1mXHOMBx6hB8wmVrGmYHmbVMV5HYTzkSKMuuz+FW5gHfnJZHaI/gqHCkFc3987K/cEwm7F+4P8buW6QfraAcqBW9XZaDjzVf9vtjPgcPf5GuVmOCCIcXIuq7ngOA20+C2etfmH4XrxRCArIys66b1Z1JBUYxoizWxwKAXHzXKF1q9C9WD4hXJUAr30xcSbbttPdIcULJc/U6wwVa8NT5lKpAXD13IZPRSM619PNr5+UBbC1m/qCaQqfRr/i/XVnFegM1CO0iRvvareCkjZvK7AGRJUFHGgbsa2YM3eADsCeuHASR1yzNiiZK+Avxx2gozxKAEM+G/Now0DYswBvyT3TLxNfmDEH6pspO+NydTJP0VIhgZMi4IRlJakjz3qtlnwlXaFJJdDDLUfz3D1aGYa9b0RzpRayAshBZTyCMfymrz+b8joROxga32DoFBBQBE1dM6CN7x5SaCnN0Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(39860400002)(376002)(396003)(136003)(41300700001)(54906003)(110136005)(478600001)(38070700005)(71200400001)(7696005)(26005)(38100700002)(9686003)(186003)(6506007)(66556008)(5660300002)(55016003)(33656002)(86362001)(2906002)(4744005)(66946007)(316002)(8676002)(66476007)(64756008)(66446008)(52536014)(76116006)(83380400001)(4326008)(8936002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8436 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8464d1de-2bbc-4c0d-d5d1-08da8c30ed9b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5iO/Fqtk5XD5trSOHKwFd8qdU1cF9zZS59MG12LzhySBUZxTn+uJbHg7knEsO5P/ZmetFVsxpRpphE461Q43qbauzfvR/FriOyFk1mMT8Xh1G+GzS9hGuElVv5oFJ3bjEhnLXJDuusGz5LOrXcCcucNrJA1WT7nl7YilkkmZG/wKE/hr7qeaFTTAIBIPOmqu5S1HIh8WQPaJ3TtT/an1xgzBWMihfDPRNuKCbtTVJ3469ZMehrc0uUgLkY6FAxTddmfssNMcsQtwQC36B1SY7gSGlmSrRu+FUEEsw0t+ooo+eOlojNz4AjXlY/8GSqX8ESAmAMMLSc94BEvZDjP0/uzlXg4fdpVUd0+bC/S9Qeo82Xqp/o9QdWGyMwALZmwyVFSUqFV5/tq2z5kUPa42h/ux7uZ4PgkVvyXuPMx9Gs+CgoS5SgdbIFWU6r5J7P9ylje+sS9qX0U2eebTFDnu+ATn072KtbbH/OnBvQoHDI6uBtGH7FunQuoAX/wl6iVX6HzC1iYeUgQoursuqBTlPz9pSnRZA82jtUkfyUrXNVzgMkdARTJpe112cU4dLADBJhvp1CyRpBbNkSfcENiKb17iNCHJ31oyColYw8Uek6vKQAG/nUlwV11Zczyg7jiC8Z8eUC0qOnwjuYLJEoLjtas5Wm39hirXmgNiNVAyPFtdCVSWHPWmsQ8WKy1lEhU2UEUgeUrrtbxz01yQI9D5yZgj/MRaSjh6LYFQYmCfsn5HCv0eCw53dy/H0rIJT9l10NcwZcJYJsArMb+6t9LvWg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(36840700001)(40470700004)(46966006)(336012)(5660300002)(8676002)(4326008)(86362001)(70586007)(356005)(70206006)(110136005)(54906003)(316002)(81166007)(6506007)(41300700001)(40460700003)(7696005)(82310400005)(107886003)(83380400001)(26005)(47076005)(9686003)(186003)(82740400003)(55016003)(40480700001)(478600001)(36860700001)(33656002)(52536014)(8936002)(4744005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:45:13.0413 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59748237-588b-40a1-3d69-08da8c30f572 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8739 Hi Bertrand, > -----Original Message----- > From: Bertrand Marquis > Subject: Push 4.17 Feature freeze and Code freeze one week later >=20 > Hi, >=20 > Seeing that we have lots of series quite advanced in review but not alrea= dy > merged, could we push > both Feature freeze and Code freeze deadline one week later to have a > chance to finish those ? I am good with that. The updated schedule now would be: - Feature freeze Fri Sep 9, 2022=20 - Code freeze Fri Sep 30, 2022 (+3 weeks from Feature freeze= ) - Hard code freeze Fri Oct 14, 2022 (+2 weeks from Code freeze) - Final commits Fri Oct 28, 2022 (+2 weeks from Hard code free= ze) - Release Wed Nov 2, 2022 The planned RCs would then be (1 per week as soon as the code freeze): - RC1: Fri Oct 7, 2022. - RC2: Fri Oct 14, 2022. - RC3: Fri Oct 21, 2022. - RC4 (Final): Fri Oct 28, 2022. Please raise concerns and questions about above schedule and we can have a discussion. Kind regards, Henry >=20 > Cheers > Bertrand >=20 From xen-devel-bounces@lists.xenproject.org Thu Sep 01 15:48:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 15:48:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396832.637165 (Exim 4.92) (envelope-from ) id 1oTmQT-0001w4-Cx; Thu, 01 Sep 2022 15:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396832.637165; Thu, 01 Sep 2022 15:48:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmQT-0001vx-A4; Thu, 01 Sep 2022 15:48:17 +0000 Received: by outflank-mailman (input) for mailman id 396832; Thu, 01 Sep 2022 15:48:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmQR-0001vr-VX for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 15:48:15 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d9b35f6-2a0d-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 17:48:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d9b35f6-2a0d-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 11:48:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662047294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3q2ab5lCOZK9vdiUhbwubrfwUeXCUS3nuV3JJ1P3MrM=; b=Q1w1fehRUG1uXhIyMNshsTUMpTmPbUVPpFwGFROHZGyX22e7ziWcleTYofS9k+JUIfyvvY j3uaPxWQWIZ//KABwCBKh1zZLHjLywJUBjihm2NtvmoeKWP+dfcOWBJQ9BZSwjyUFtAdoj ea/IHZE7HCcVWAG5VEdR7YDF59Avgzo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: David Hildenbrand Cc: Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901154806.q4eegemrho6hgidu@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> <78e55029-0eaf-b4b3-7e86-1086b97c60c6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78e55029-0eaf-b4b3-7e86-1086b97c60c6@redhat.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 05:07:06PM +0200, David Hildenbrand wrote: > Skimming over the patches (that I was CCed on) and skimming over the > cover letter, I got the impression that everything after patch 7 is > introducing something new instead of refactoring something out. You skimmed over the dynamic debug patch then... From xen-devel-bounces@lists.xenproject.org Thu Sep 01 16:05:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 16:05:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396838.637176 (Exim 4.92) (envelope-from ) id 1oTmh0-0004pq-PF; Thu, 01 Sep 2022 16:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396838.637176; Thu, 01 Sep 2022 16:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmh0-0004pj-MJ; Thu, 01 Sep 2022 16:05:22 +0000 Received: by outflank-mailman (input) for mailman id 396838; Thu, 01 Sep 2022 16:05:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTmgz-0004pd-C3 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 16:05:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e033006d-2a0f-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 18:05:19 +0200 (CEST) Received: from AM5PR0601CA0079.eurprd06.prod.outlook.com (2603:10a6:206::44) by GV2PR08MB8392.eurprd08.prod.outlook.com (2603:10a6:150:b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 16:05:17 +0000 Received: from AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::51) by AM5PR0601CA0079.outlook.office365.com (2603:10a6:206::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 16:05:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT011.mail.protection.outlook.com (100.127.140.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 16:05:16 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Thu, 01 Sep 2022 16:05:16 +0000 Received: from b529239e29c5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 76C41A12-ED15-4200-839E-C7748A2C2E32.1; Thu, 01 Sep 2022 16:05:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b529239e29c5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 16:05:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6534.eurprd08.prod.outlook.com (2603:10a6:20b:31c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 16:05:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 16:05:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e033006d-2a0f-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b56F6uPXtgrtcCrs8sBDH/vwe4oLD+kkuJbkmTXaD83BQL+GGcpRUA55bMTfvLDEeFYrmyENZkGqwzf65vBl7rLZ3Uu406sOrTseGWkjo1gvRLrH4exvw0RCHHzc+4in8WnHV0LdJV/BHOM+F30LqmfNg0fCef630EIwx3jmbts00NnkqifPj2aLpvxJw6mzooQLi9+KVmMnJkSo0XadGz9IqDcvsmwGCB9I4oRfOfO4VGuCS/mJ6IC5PHUZAZC30AhD6iOHa5uzcLMSOkRA883sRhSJUS5ZFn47ZQtAA8o4G2xNOyq061kZtyvXyqh1Yb/K7ZyFcJR4qtJaa9WHIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=64cL9YJvOa6qwYva1RJAqxFv0BAwclUrYouxfWQWenA=; b=FQO/4OWcLJJi0qTZvh9POQE0Hq0WzQAbppeL4DQotnm3uRtADZnf3WueWcnbaPQsbFiFKCOFEjNiJfqXuwf4m7NtDOvFZEZAYO/DuQ9VrkuZgWnTijgMKVxxUD+Dl252S/j5eFT9t07yNe0HAiYPEHF2cZP5kyGpDuH9Zm6+9guaGOzf204sYAdiccRrZG5HkK1Cs24I+zOHqxtBdnpY7/1w/jdB0PoWsC4SXYap84ymictQI5RlhY5bh/DSDq3MR/8RmDNEJaJCt08Kw9QjMELZHl0jOuO5qd0Heuj0wYAZ0yTWKhOy7qbkTNUVpEfExhJZnpr7lpCAqKy0rMM4Iw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=64cL9YJvOa6qwYva1RJAqxFv0BAwclUrYouxfWQWenA=; b=TO/Nv6ytKWShO9jbKMC0LE3zc2WK2t5Fl/grpq3dQI7f4nEHnZ1pV9A4qP2rgkl8C+SwoUg2Bp6EAI5M6tzLttYHqml+tvllhw2FngB5O7kQI0/CWDDyCaRV8Kn8guQshpCYqei6kJ7L8X3j2zNJvsUwd292x7TX8GPX3BxfKC8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OkBcSHVjjd6hxJLusSwYBpzbzFXxOEBLlk32kLzG+WtC4kaazXswxKxoU1cofs0I0iKCMVE7vI0ZfjwgC1Dq34gXhSNo26LZRykUtUbpWqFEelNnF03POxd5XdMMrR47u7KNEhsbyYbYbxcMwMvhAaB6g/irsQtj9Z9uFjwuW3Xr4ZLXaRS4PI98C5KJfYGNGA8mi5bRKjWCZKUVLY98uKIaAlJZy2dF5DEwS28f8UI6I2EtMHgYeA1ahOrm/xUnWp0NfvoElfneWipDO+CFDiEMv4nSObhonvfhWPeYSS5fWQ0UNNu2U6pmhTCldU4+oanw2iIBwD03ljjWe+WYSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=64cL9YJvOa6qwYva1RJAqxFv0BAwclUrYouxfWQWenA=; b=jH8U95oTELTNNpYgI3yewcSZb/E+UPoOcy67VHr+cvzfOCj75rdLzr2KU67Jmwg/GZ9RSIUHFIemHqxxVu9cYnqIrHx+lYRFYLoulYP2AL+Oz+7vwuwUgwOEM6nAmVFQY2agRa7FwSKnTs5c0DCNEqhsHvaPwYVSXJt2sM7CQwnGd4PEBqaC/y4rMiHNYFvXEaAIAEISTD5bz1Gs8jIjVeBmFtYnJFEXCaZbrOiemempmkkNL6O8sYrQdD1clROPekis1p+uqe3DOJCXK8mFBBk4GbcNimuTcqArccpGZmtppSqauXDgaamJ6ZYz2693CABls/2yMSFtP4XjrQTruw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=64cL9YJvOa6qwYva1RJAqxFv0BAwclUrYouxfWQWenA=; b=TO/Nv6ytKWShO9jbKMC0LE3zc2WK2t5Fl/grpq3dQI7f4nEHnZ1pV9A4qP2rgkl8C+SwoUg2Bp6EAI5M6tzLttYHqml+tvllhw2FngB5O7kQI0/CWDDyCaRV8Kn8guQshpCYqei6kJ7L8X3j2zNJvsUwd292x7TX8GPX3BxfKC8= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini CC: Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q3KwCgAgAAG+VA= Date: Thu, 1 Sep 2022 16:05:03 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> In-Reply-To: <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 94A4F3A9D8FE0C44A9E9CCA18EC2F702.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 12e8ae07-0ecc-48ef-6eef-08da8c33c2ee x-ms-traffictypediagnostic: AS8PR08MB6534:EE_|AM7EUR03FT011:EE_|GV2PR08MB8392:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5WCMH6keqg0o1LqsDMCqt57s3IePgg6EIj1Jo2OVRC9EDj+T+coGhdaetHQQ/CCEBBtjU6RAmOJ7xCkH0+6M59uC8393QOJayky37F91ieV3jJluuNZBpd9HQyQcmINAmFesGYyfWOt8YiVB5U9zcqfoZ0756LtvA1+PtYja1JfbuWCWNvQ4RldCAfMd/GQxag/NaUUyBq+zYP5DaHXWEEMIVmg48Hp8I8/EA+RELLdJBIxfJ4J7aTrME/Nm92M4EP63be09zK68EbQ93feRlGmqAGoKm/0Khjo79J6xg1TS4TBdyW1sdrLZ/Lqq0cXvzdzm4cZ7cm4VRVrn9zLii0RCZi/zsAGqKb6VFdQZs37VL0CVDyq9I1R9ZLbi9nAguHbVDMTnhIu8oLz8h6zI55Y6yQiRdRrfEgvZKXQ2HFsD1d8JrwYj700sFevmONLsUpYg2ZH8hUangONvaLY+DqhH0LmSVdO1K2/95Bz3j6ZvK+2HIu35zPh8wFp83jEXqg6x7LcrzcrnpNdRCmtd/Nb2fvbo9M4k4wV6Jx5tKI9DSeRba3ek+IQ773VHfOWzKM2dQ9rotFfrPDp8vaw5OGzjqPxqOPNvqmojohBZZa90mOIOgU6+G8LTtgWUl+mPEKjUVOEkBIGl2rQQN7iFW1JYiio2tgrBPg4JyZO1osFSJPYLJfIxZUU4ppvYAXkXFBeC1QTawk6qmznwHU/po3PTZILVaeyLYi39IJiqCVUQSTh1l1y72lTDmm89j0xGGrUABvrUwqwG58oKeOQCQC9//h9xcFWNXA9CXUgHNlI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(186003)(83380400001)(86362001)(38070700005)(38100700002)(122000001)(52536014)(8936002)(76116006)(5660300002)(66946007)(64756008)(55016003)(4326008)(66476007)(66556008)(8676002)(7696005)(33656002)(6506007)(53546011)(2906002)(41300700001)(26005)(9686003)(110136005)(54906003)(478600001)(316002)(66446008)(71200400001)(966005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6534 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 47705f4c-506f-48ce-1f4a-08da8c33bb37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4eEIeBhrPUx6s+bJhpp2rA7RfUWL8qpCrZc8SGYH5y3LZvOYHDAVOEMj6BgNV7iAZ7t2oLQ0YBObfez07TvmMOwz0qheK8wrwLrLyyWGDePbfulX7CuCp4rzVyP89Qhis3S/dIiqHgATo0B8uhXfuoIxYEtVAENST2QDd5iIdIv15G39PFYgfb9sxHRs3M1iu+tugz19a/9lAl+c1PPnmHHHYgLb6Sq0L9wKdzkR/DtJBiUt2HE4JpFzn9sKvIlJHYjQWZCiFRFTs5RL8gtH+598Uid0PLftTn/Ke7bKFO+KjgtoZvyJBJL+29mQB+iDD1ZhairzEKYNxbYeY+uMAq8qILL5f/ud3nf4ypR1aj4P27a5CNTw5S/sxKp68nNCPFwJI+mAT9sOjP6+f30ZR36JEgBjnxUyBYM+3PWYf9wsBiMHfr4Ha15HdnAWcv7aTa/Ak/XnCeE3oJdDKy/hIOI5x6hv8BmFALW7Cn7usv8/hHe+hCaECTi3kNPIfGzOnFitMg1237vO242a/qscNJVjRfZ1wTnyj3dLsEKcEpeGNSNcxnEIDcMuSgfscDGLLUf5QSfDXewR7SIyoln+nlXvPlVkYnPgp4ToRrrJ2rynV//ps8Ndt3pW+fIggE9i+rk2rpbaHo/NcAimHxfP62oa2rBhIZpaQmybma++3GDD3lXq5WT2UeZ9KyyqjPYhS1NX/Mq18SpQs4pLVopPpgGZ/m/w8kBvncTDNNG40TJ5Gfrzv45fM293w8b/PRgahEfNCBRhbDDJOOaqd5XkSKWH1ys4pm+XLlMT0vQ0OdU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(39860400002)(396003)(46966006)(40470700004)(36840700001)(82310400005)(53546011)(82740400003)(6506007)(9686003)(47076005)(186003)(55016003)(2906002)(40460700003)(26005)(336012)(83380400001)(33656002)(36860700001)(40480700001)(4326008)(70586007)(110136005)(54906003)(70206006)(966005)(8676002)(86362001)(107886003)(8936002)(52536014)(5660300002)(41300700001)(316002)(81166007)(7696005)(356005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 16:05:16.7191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12e8ae07-0ecc-48ef-6eef-08da8c33c2ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8392 SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHlvdXIgcmV2aWV3Lg0KDQo+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1 YmplY3Q6IFJlOiBbUEFUQ0ggMi8yXSB4ZW4vYXJtOiBIYW5kbGUgcmVzZXJ2ZWQgaGVhcCBwYWdl cyBpbiBib290IGFuZA0KPiBoZWFwIGFsbG9jYXRvcg0KPiANCj4gSGkgSGVucnksDQo+IA0KPiBP biAyNC8wOC8yMDIyIDA4OjMxLCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IFRoaXMgY29tbWl0IGZp cnN0bHkgYWRkcyBhIGdsb2JhbCB2YXJpYWJsZSBgcmVzZXJ2ZWRfaGVhcGAuDQo+ID4gVGhpcyBu ZXdseSBpbnRyb2R1Y2VkIGdsb2JhbCB2YXJpYWJsZSBpcyBzZXQgYXQgdGhlIGRldmljZSB0cmVl DQo+ID4gcGFyc2luZyB0aW1lIGlmIHRoZSByZXNlcnZlZCBoZWFwIHJhbmdlcyBhcmUgZGVmaW5l ZCBpbiB0aGUgZGV2aWNlDQo+ID4gdHJlZSBjaG9zZW4gbm9kZS4NCj4gPg0KPiA+IEZvciBBcm0z MiwgSW4gYHNldHVwX21tYCwgaWYgdGhlIHJlc2VydmVkIGhlYXAgaXMgZW5hYmxlZCwgd2UgdXNl DQo+ID4gdGhlIHJlc2VydmVkIGhlYXAgcmVnaW9uIGZvciBib3RoIGRvbWhlYXAgYW5kIHhlbmhl YXAgYWxsb2NhdGlvbi4NCj4gPg0KPiA+IEZvciBBcm02NCwgSW4gYHNldHVwX21tYCwgaWYgdGhl IHJlc2VydmVkIGhlYXAgaXMgZW5hYmxlZCBhbmQgdXNlZCwNCj4gPiB3ZSBtYWtlIHN1cmUgdGhh dCBvbmx5IHRoZXNlIHJlc2VydmVkIGhlYXAgcGFnZXMgYXJlIGFkZGVkIHRvIHRoZQ0KPiA+IGJv b3QgYWxsb2NhdG9yLiBUaGVzZSByZXNlcnZlZCBoZWFwIHBhZ2VzIGluIHRoZSBib290IGFsbG9j YXRvciBhcmUNCj4gPiBhZGRlZCB0byB0aGUgaGVhcCBhbGxvY2F0b3IgYXQgYGVuZF9ib290X2Fs bG9jYXRvcigpYC4NCj4gPg0KPiA+IElmIHRoZSByZXNlcnZlZCBoZWFwIGlzIGRpc2FibGVkLCB3 ZSBzdGljayB0byBjdXJyZW50IHBhZ2UgYWxsb2NhdGlvbg0KPiA+IHN0cmF0ZWd5IGF0IGJvb3Qg dGltZS4NCj4gPg0KPiA+IEFsc28sIHRha2UgdGhlIGNoYW5jZSB0byBjb3JyZWN0IGEgImRvdWJs ZSBub3QiIHByaW50IGluIEFybTMyDQo+ID4gYHNldHVwX21tKClgLg0KPiA+DQo+ID4gU2lnbmVk LW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+IFdp dGggcmVzZXJ2ZWQgaGVhcCBlbmFibGVkLCBmb3IgQXJtNjQsIG5hbWluZyBvZiBnbG9iYWwgdmFy aWFibGVzIHN1Y2gNCj4gPiBhcyBgeGVuaGVhcF9tZm5fc3RhcnRgIGFuZCBgeGVuaGVhcF9tZm5f ZW5kYCBzZWVtcyB0byBiZSBhbWJpZ3VvdXMsDQo+ID4gd29uZGVyaW5nIGlmIHdlIHNob3VsZCBy ZW5hbWUgdGhlc2UgdmFyaWFibGVzLg0KPiA+IC0tLQ0KPiA+IENoYW5nZXMgZnJvbSBSRkMgdG8g djE6DQo+ID4gLSBSZWJhc2Ugb24gdG9wIG9mIGxhdGVzdCBgc2V0dXBfbW0oKWAgY2hhbmdlcy4N Cj4gPiAtIEFkZGVkIEFybTMyIGxvZ2ljIGluIGBzZXR1cF9tbSgpYC4NCj4gPiAtLS0NCj4gPiAg IHhlbi9hcmNoL2FybS9ib290ZmR0LmMgICAgICAgICAgIHwgIDIgKw0KPiA+ICAgeGVuL2FyY2gv YXJtL2luY2x1ZGUvYXNtL3NldHVwLmggfCAgMiArDQo+ID4gICB4ZW4vYXJjaC9hcm0vc2V0dXAu YyAgICAgICAgICAgICB8IDc5ICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tDQo+ID4g ICAzIGZpbGVzIGNoYW5nZWQsIDY3IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQ0KPiA+ DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9ib290ZmR0LmMgYi94ZW4vYXJjaC9hcm0v Ym9vdGZkdC5jDQo+ID4gaW5kZXggMzM3MDRjYTQ4Ny4uYWI3M2I2ZTIxMiAxMDA2NDQNCj4gPiAt LS0gYS94ZW4vYXJjaC9hcm0vYm9vdGZkdC5jDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2Jvb3Rm ZHQuYw0KPiA+IEBAIC0zMjUsNiArMzI1LDggQEAgc3RhdGljIGludCBfX2luaXQgcHJvY2Vzc19j aG9zZW5fbm9kZShjb25zdCB2b2lkDQo+ICpmZHQsIGludCBub2RlLA0KPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUpOw0KPiA+ICAgICAgICAgICBpZiAoIHJj ICkNCj4gPiAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4gPiArDQo+ID4gKyAgICAgICAgcmVz ZXJ2ZWRfaGVhcCA9IHRydWU7DQo+ID4gICAgICAgfQ0KPiA+DQo+ID4gICAgICAgcHJpbnRrKCJD aGVja2luZyBmb3IgaW5pdHJkIGluIC9jaG9zZW5cbiIpOw0KPiA+IGRpZmYgLS1naXQgYS94ZW4v YXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9zZXR1cC5oDQo+ID4gaW5kZXggZTgwZjNkNjIwMS4uMDA1MzZhNmQ1NSAxMDA2NDQNCj4gPiAt LS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPiA+ICsrKyBiL3hlbi9hcmNo L2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gQEAgLTkyLDYgKzkyLDggQEAgZXh0ZXJuIHN0 cnVjdCBib290aW5mbyBib290aW5mbzsNCj4gPg0KPiA+ICAgZXh0ZXJuIGRvbWlkX3QgbWF4X2lu aXRfZG9taWQ7DQo+ID4NCj4gPiArZXh0ZXJuIGJvb2wgcmVzZXJ2ZWRfaGVhcDsNCj4gPiArDQo+ ID4gICB2b2lkIGNvcHlfZnJvbV9wYWRkcih2b2lkICpkc3QsIHBhZGRyX3QgcGFkZHIsIHVuc2ln bmVkIGxvbmcgbGVuKTsNCj4gPg0KPiA+ICAgc2l6ZV90IGVzdGltYXRlX2VmaV9zaXplKHVuc2ln bmVkIGludCBtZW1fbnJfYmFua3MpOw0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2V0 dXAuYyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+ID4gaW5kZXggNTAwMzA3ZWRjMC4uZmU3NmNm NjMyNSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+ICsrKyBiL3hl bi9hcmNoL2FybS9zZXR1cC5jDQo+ID4gQEAgLTczLDYgKzczLDggQEAgaW50ZWdlcl9wYXJhbSgi eGVuaGVhcF9tZWdhYnl0ZXMiLA0KPiBvcHRfeGVuaGVhcF9tZWdhYnl0ZXMpOw0KPiA+DQo+ID4g ICBkb21pZF90IF9fcmVhZF9tb3N0bHkgbWF4X2luaXRfZG9taWQ7DQo+ID4NCj4gPiArYm9vbCBf X3JlYWRfbW9zdGx5IHJlc2VydmVkX2hlYXA7DQo+ID4gKw0KPiA+ICAgc3RhdGljIF9fdXNlZCB2 b2lkIGluaXRfZG9uZSh2b2lkKQ0KPiA+ICAgew0KPiA+ICAgICAgIC8qIE11c3QgYmUgZG9uZSBw YXN0IHNldHRpbmcgc3lzdGVtX3N0YXRlLiAqLw0KPiA+IEBAIC02OTksOCArNzAxLDEwIEBAIHN0 YXRpYyB2b2lkIF9faW5pdCBwb3B1bGF0ZV9ib290X2FsbG9jYXRvcih2b2lkKQ0KPiA+ICAgI2lm ZGVmIENPTkZJR19BUk1fMzINCj4gPiAgIHN0YXRpYyB2b2lkIF9faW5pdCBzZXR1cF9tbSh2b2lk KQ0KPiA+ICAgew0KPiA+IC0gICAgcGFkZHJfdCByYW1fc3RhcnQsIHJhbV9lbmQsIHJhbV9zaXpl LCBlOw0KPiA+IC0gICAgdW5zaWduZWQgbG9uZyByYW1fcGFnZXM7DQo+ID4gKyAgICBwYWRkcl90 IHJhbV9zdGFydCwgcmFtX2VuZCwgcmFtX3NpemUsIGUsIGJhbmtfc3RhcnQsIGJhbmtfZW5kLA0K PiBiYW5rX3NpemU7DQo+ID4gKyAgICBwYWRkcl90IHJlc2VydmVkX2hlYXBfc3RhcnQgPSB+MCwg cmVzZXJ2ZWRfaGVhcF9lbmQgPSAwLA0KPiA+ICsgICAgICAgICAgICByZXNlcnZlZF9oZWFwX3Np emUgPSAwOw0KPiA+ICsgICAgdW5zaWduZWQgbG9uZyByYW1fcGFnZXMsIHJlc2VydmVkX2hlYXBf cGFnZXMgPSAwOw0KPiA+ICAgICAgIHVuc2lnbmVkIGxvbmcgaGVhcF9wYWdlcywgeGVuaGVhcF9w YWdlcywgZG9taGVhcF9wYWdlczsNCj4gPiAgICAgICB1bnNpZ25lZCBpbnQgaTsNCj4gPiAgICAg ICBjb25zdCB1aW50MzJfdCBjdHIgPSBSRUFEX0NQMzIoQ1RSKTsNCj4gPiBAQCAtNzIwLDkgKzcy NCw5IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBzZXR1cF9tbSh2b2lkKQ0KPiA+DQo+ID4gICAgICAg Zm9yICggaSA9IDE7IGkgPCBib290aW5mby5tZW0ubnJfYmFua3M7IGkrKyApDQo+ID4gICAgICAg ew0KPiA+IC0gICAgICAgIHBhZGRyX3QgYmFua19zdGFydCA9IGJvb3RpbmZvLm1lbS5iYW5rW2ld LnN0YXJ0Ow0KPiA+IC0gICAgICAgIHBhZGRyX3QgYmFua19zaXplID0gYm9vdGluZm8ubWVtLmJh bmtbaV0uc2l6ZTsNCj4gPiAtICAgICAgICBwYWRkcl90IGJhbmtfZW5kID0gYmFua19zdGFydCAr IGJhbmtfc2l6ZTsNCj4gPiArICAgICAgICBiYW5rX3N0YXJ0ID0gYm9vdGluZm8ubWVtLmJhbmtb aV0uc3RhcnQ7DQo+ID4gKyAgICAgICAgYmFua19zaXplID0gYm9vdGluZm8ubWVtLmJhbmtbaV0u c2l6ZTsNCj4gPiArICAgICAgICBiYW5rX2VuZCA9IGJhbmtfc3RhcnQgKyBiYW5rX3NpemU7DQo+ ID4NCj4gPiAgICAgICAgICAgcmFtX3NpemUgID0gcmFtX3NpemUgKyBiYW5rX3NpemU7DQo+ID4g ICAgICAgICAgIHJhbV9zdGFydCA9IG1pbihyYW1fc3RhcnQsYmFua19zdGFydCk7DQo+ID4gQEAg LTczMSw2ICs3MzUsMjUgQEAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX21tKHZvaWQpDQo+ID4N Cj4gPiAgICAgICB0b3RhbF9wYWdlcyA9IHJhbV9wYWdlcyA9IHJhbV9zaXplID4+IFBBR0VfU0hJ RlQ7DQo+ID4NCj4gPiArICAgIGlmICggcmVzZXJ2ZWRfaGVhcCApDQo+ID4gKyAgICB7DQo+ID4g KyAgICAgICAgZm9yICggaSA9IDAgOyBpIDwgYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLm5yX2Jhbmtz OyBpKysgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgaWYgKCBib290aW5mby5y ZXNlcnZlZF9tZW0uYmFua1tpXS54ZW5faGVhcCApDQo+ID4gKyAgICAgICAgICAgIHsNCj4gPiAr ICAgICAgICAgICAgICAgIGJhbmtfc3RhcnQgPSBib290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tp XS5zdGFydDsNCj4gPiArICAgICAgICAgICAgICAgIGJhbmtfc2l6ZSA9IGJvb3RpbmZvLnJlc2Vy dmVkX21lbS5iYW5rW2ldLnNpemU7DQo+ID4gKyAgICAgICAgICAgICAgICBiYW5rX2VuZCA9IGJh bmtfc3RhcnQgKyBiYW5rX3NpemU7DQo+ID4gKw0KPiA+ICsgICAgICAgICAgICAgICAgcmVzZXJ2 ZWRfaGVhcF9zaXplICs9IGJhbmtfc2l6ZTsNCj4gPiArICAgICAgICAgICAgICAgIHJlc2VydmVk X2hlYXBfc3RhcnQgPSBtaW4ocmVzZXJ2ZWRfaGVhcF9zdGFydCwgYmFua19zdGFydCk7DQo+ID4g KyAgICAgICAgICAgICAgICByZXNlcnZlZF9oZWFwX2VuZCA9IG1heChyZXNlcnZlZF9oZWFwX2Vu ZCwgYmFua19lbmQpOw0KPiA+ICsgICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsN Cj4gPiArICAgICAgICByZXNlcnZlZF9oZWFwX3BhZ2VzID0gcmVzZXJ2ZWRfaGVhcF9zaXplID4+ IFBBR0VfU0hJRlQ7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICAgICAgIC8qDQo+ID4gICAgICAg ICogSWYgdGhlIHVzZXIgaGFzIG5vdCByZXF1ZXN0ZWQgb3RoZXJ3aXNlIHZpYSB0aGUgY29tbWFu ZCBsaW5lDQo+ID4gICAgICAgICogdGhlbiBsb2NhdGUgdGhlIHhlbmhlYXAgdXNpbmcgdGhlc2Ug Y29uc3RyYWludHM6DQo+ID4gQEAgLTc0Myw3ICs3NjYsOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQg c2V0dXBfbW0odm9pZCkNCj4gPiAgICAgICAgKiBXZSB0cnkgdG8gYWxsb2NhdGUgdGhlIGxhcmdl c3QgeGVuaGVhcCBwb3NzaWJsZSB3aXRoaW4gdGhlc2UNCj4gPiAgICAgICAgKiBjb25zdHJhaW50 cy4NCj4gPiAgICAgICAgKi8NCj4gPiAtICAgIGhlYXBfcGFnZXMgPSByYW1fcGFnZXM7DQo+ID4g KyAgICBoZWFwX3BhZ2VzID0gIXJlc2VydmVkX2hlYXAgPyByYW1fcGFnZXMgOiByZXNlcnZlZF9o ZWFwX3BhZ2VzOw0KPiA+ICsNCj4gPiAgICAgICBpZiAoIG9wdF94ZW5oZWFwX21lZ2FieXRlcyAp DQo+ID4gICAgICAgICAgIHhlbmhlYXBfcGFnZXMgPSBvcHRfeGVuaGVhcF9tZWdhYnl0ZXMgPDwg KDIwLVBBR0VfU0hJRlQpOw0KPiA+ICAgICAgIGVsc2UNCj4gPiBAQCAtNzU1LDE3ICs3NzksMjEg QEAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX21tKHZvaWQpDQo+ID4NCj4gPiAgICAgICBkbw0K PiA+ICAgICAgIHsNCj4gPiAtICAgICAgICBlID0gY29uc2lkZXJfbW9kdWxlcyhyYW1fc3RhcnQs IHJhbV9lbmQsDQo+ID4gKyAgICAgICAgZSA9ICFyZXNlcnZlZF9oZWFwID8NCj4gPiArICAgICAg ICAgICAgY29uc2lkZXJfbW9kdWxlcyhyYW1fc3RhcnQsIHJhbV9lbmQsDQo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHBmbl90b19wYWRkcih4ZW5oZWFwX3BhZ2VzKSwNCj4gPiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAzMjw8MjAsIDApOw0KPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDMyPDwyMCwgMCkgOg0KPiA+ICsgICAgICAgICAgICByZXNlcnZl ZF9oZWFwX2VuZDsNCj4gDQo+IE5vdCBlbnRpcmVseSByZWxhdGVkIHRvIHRoaXMgc2VyaWVzLiBO b3cgdGhlIGFzc3VtcHRpb24gaXMgdGhlIGFkbWluDQo+IHdpbGwgbWFrZSBzdXJlIHRoYXQgbm9u ZSBvZiB0aGUgcmVzZXJ2ZWQgcmVnaW9ucyB3aWxsIG92ZXJsYXAuDQo+IA0KPiBEbyB3ZSBoYXZl IGFueSB0b29sIHRvIGhlbHAgdGhlIGFkbWluIHRvIHZlcmlmeSBpdD8gSWYgeWVzLCBjYW4gd2Ug aGF2ZQ0KPiBhIHBvaW50ZXIgaW4gdGhlIGRvY3VtZW50YXRpb24/IElmIG5vdCwgc2hvdWxkIHRo aXMgYmUgZG9uZSBpbiBYZW4/DQoNCkluIHRoZSBSRkMgd2UgaGFkIHRoZSBzYW1lIGRpc2N1c3Np b24gb2YgdGhpcyBpc3N1ZSBbMV0gYW5kIEkgdGhpbmsgYQ0KZm9sbG93LXVwIHNlcmllcyBtaWdo dCBuZWVkZWQgdG8gZG8gdGhlIG92ZXJsYXAgY2hlY2sgaWYgd2Ugd2FudCB0bw0KZG8gdGhhdCBp biBYZW4uIEZvciB0aGUgZXhpc3RpbmcgdG9vbCwgSSBhbSB0aGlua2luZyBvZiBJbWFnZUJ1aWxk ZXIsIGJ1dA0KSSBhbSBjdXJpb3VzIGFib3V0IFN0ZWZhbm8ncyBvcGluaW9uLg0KDQo+IA0KPiBB bHNvLCB3aGF0IGhhcHBlbiB3aXRoIFVFRkk/IElzIGl0IGVhc3kgdG8gZ3VhcmFudGVlIHRoZSBy ZWdpb24gd2lsbCBub3QNCj4gYmUgdXNlZD8NCg0KRm9yIG5vdyBJIHRoaW5rIGl0IGlzIG5vdCBl YXN5IHRvIGd1YXJhbnRlZSB0aGF0LCBkbyB5b3UgaGF2ZSBzb21lIGlkZWFzDQppbiBtaW5kPyBJ IHRoaW5rIEkgY2FuIGZvbGxvdyB0aGlzIGluIGFib3ZlIGZvbGxvdy11cCBzZXJpZXMgdG8gaW1w cm92ZSB0aGluZ3MuIA0KDQo+IA0KPiA+ICsNCj4gPiAgICAgICAgICAgaWYgKCBlICkNCj4gPiAg ICAgICAgICAgICAgIGJyZWFrOw0KPiA+DQo+ID4gICAgICAgICAgIHhlbmhlYXBfcGFnZXMgPj49 IDE7DQo+ID4gICAgICAgfSB3aGlsZSAoICFvcHRfeGVuaGVhcF9tZWdhYnl0ZXMgJiYgeGVuaGVh cF9wYWdlcyA+IDMyPDwoMjAtDQo+IFBBR0VfU0hJRlQpICk7DQo+ID4NCj4gPiAtICAgIGlmICgg ISBlICkNCj4gPiAtICAgICAgICBwYW5pYygiTm90IG5vdCBlbm91Z2ggc3BhY2UgZm9yIHhlbmhl YXBcbiIpOw0KPiA+ICsgICAgaWYgKCAhIGUgfHwNCj4gPiArICAgICAgICAgKCByZXNlcnZlZF9o ZWFwICYmIHJlc2VydmVkX2hlYXBfcGFnZXMgPCAzMjw8KDIwLVBBR0VfU0hJRlQpICkgKQ0KPiA+ ICsgICAgICAgIHBhbmljKCJOb3QgZW5vdWdoIHNwYWNlIGZvciB4ZW5oZWFwXG4iKTsNCj4gDQo+ IFNvIG9uIGFybTMyLCB0aGUgeGVuaGVhcCAqbXVzdCogYmUgY29udGlndW91cy4gQUZBSUNULA0K PiByZXNlcnZlZF9oZWFwX3BhZ2VzIGlzIHRoZSB0b3RhbCBudW1iZXIgb2YgcGFnZXMgaW4gdGhl IGhlYXAuIFRoZXkgbWF5DQo+IG5vdCBiZSBjb250aWd1b3VzLiBTbyBJIHRoaW5rIHRoaXMgd2Fu dHMgdG8gYmUgcmV3b3JrZWQgc28gd2UgbG9vayBmb3INCj4gb25lIG9mIHRoZSByZWdpb24gdGhh dCBtYXRjaCB0aGUgZGVmaW5pdGlvbiB3cml0dGVuIGFib3ZlIHRoZSBsb29wLg0KDQpUaGFua3Mg Zm9yIHJhaXNpbmcgdGhpcyBjb25jZXJuLCBJIHdpbGwgZG8gdGhpcyBpbiBWMi4NCg0KPiANCj4g Pg0KPiA+ICAgICAgIGRvbWhlYXBfcGFnZXMgPSBoZWFwX3BhZ2VzIC0geGVuaGVhcF9wYWdlczsN Cj4gPg0KPiA+IEBAIC04MTAsOSArODM4LDkgQEAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX21t KHZvaWQpDQo+ID4gICBzdGF0aWMgdm9pZCBfX2luaXQgc2V0dXBfbW0odm9pZCkNCj4gPiAgIHsN Cj4gPiAgICAgICBjb25zdCBzdHJ1Y3QgbWVtaW5mbyAqYmFua3MgPSAmYm9vdGluZm8ubWVtOw0K PiA+IC0gICAgcGFkZHJfdCByYW1fc3RhcnQgPSB+MDsNCj4gPiAtICAgIHBhZGRyX3QgcmFtX2Vu ZCA9IDA7DQo+ID4gLSAgICBwYWRkcl90IHJhbV9zaXplID0gMDsNCj4gPiArICAgIHBhZGRyX3Qg cmFtX3N0YXJ0ID0gfjAsIGJhbmtfc3RhcnQgPSB+MDsNCj4gPiArICAgIHBhZGRyX3QgcmFtX2Vu ZCA9IDAsIGJhbmtfZW5kID0gMDsNCj4gPiArICAgIHBhZGRyX3QgcmFtX3NpemUgPSAwLCBiYW5r X3NpemUgPSAwOw0KPiA+ICAgICAgIHVuc2lnbmVkIGludCBpOw0KPiA+DQo+ID4gICAgICAgaW5p dF9wZHgoKTsNCj4gPiBAQCAtODIxLDE3ICs4NDksMzYgQEAgc3RhdGljIHZvaWQgX19pbml0IHNl dHVwX21tKHZvaWQpDQo+ID4gICAgICAgICogV2UgbmVlZCBzb21lIG1lbW9yeSB0byBhbGxvY2F0 ZSB0aGUgcGFnZS10YWJsZXMgdXNlZCBmb3IgdGhlDQo+IHhlbmhlYXANCj4gPiAgICAgICAgKiBt YXBwaW5ncy4gQnV0IHNvbWUgcmVnaW9ucyBtYXkgY29udGFpbiBtZW1vcnkgYWxyZWFkeSBhbGxv Y2F0ZWQNCj4gPiAgICAgICAgKiBmb3Igb3RoZXIgdXNlcyAoZS5nLiBtb2R1bGVzLCByZXNlcnZl ZC1tZW1vcnkuLi4pLg0KPiA+IC0gICAgICoNCj4gPiArICAgICAqIElmIHJlc2VydmVkIGhlYXAg cmVnaW9ucyBhcmUgcHJvcGVybHkgZGVmaW5lZCwgKG9ubHkpIGFkZCB0aGVzZQ0KPiByZWdpb25z DQo+ID4gKyAgICAgKiBpbiB0aGUgYm9vdCBhbGxvY2F0b3IuID4gKyAgICAgKi8NCj4gPiArICAg IGlmICggcmVzZXJ2ZWRfaGVhcCApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgZm9yICggaSA9 IDAgOyBpIDwgYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLm5yX2JhbmtzOyBpKysgKQ0KPiA+ICsgICAg ICAgIHsNCj4gPiArICAgICAgICAgICAgaWYgKCBib290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tp XS54ZW5faGVhcCApDQo+ID4gKyAgICAgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgICAgIGJh bmtfc3RhcnQgPSBib290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tpXS5zdGFydDsNCj4gPiArICAg ICAgICAgICAgICAgIGJhbmtfc2l6ZSA9IGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5rW2ldLnNp emU7DQo+ID4gKyAgICAgICAgICAgICAgICBiYW5rX2VuZCA9IGJhbmtfc3RhcnQgKyBiYW5rX3Np emU7DQo+ID4gKw0KPiA+ICsgICAgICAgICAgICAgICAgaW5pdF9ib290X3BhZ2VzKGJhbmtfc3Rh cnQsIGJhbmtfZW5kKTsNCj4gPiArICAgICAgICAgICAgfQ0KPiA+ICsgICAgICAgIH0NCj4gPiAr ICAgIH0NCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBObyByZXNlcnZlZCBoZWFwIHJlZ2lvbnM6 DQo+ID4gICAgICAgICogRm9yIHNpbXBsaWNpdHksIGFkZCBhbGwgdGhlIGZyZWUgcmVnaW9ucyBp biB0aGUgYm9vdCBhbGxvY2F0b3IuDQo+ID4gICAgICAgICovDQo+ID4gLSAgICBwb3B1bGF0ZV9i b290X2FsbG9jYXRvcigpOw0KPiA+ICsgICAgZWxzZQ0KPiA+ICsgICAgICAgIHBvcHVsYXRlX2Jv b3RfYWxsb2NhdG9yKCk7DQo+ID4NCj4gPiAgICAgICB0b3RhbF9wYWdlcyA9IDA7DQo+ID4NCj4g PiAgICAgICBmb3IgKCBpID0gMDsgaSA8IGJhbmtzLT5ucl9iYW5rczsgaSsrICkNCj4gPiAgICAg ICB7DQo+IA0KPiBUaGlzIGNvZGUgaXMgbm93IGJlY29taW5nIHF1aXRlIGNvbmZ1c2luZyB0byB1 bmRlcnN0YW5kaW5nLiBUaGlzIGxvb3AgaXMNCj4gbWVhbnQgdG8gbWFwIHRoZSB4ZW5oZWFwLiBJ ZiBJIGZvbGxvdyB5b3VyIGRvY3VtZW50YXRpb24sIGl0IHdvdWxkIG1lYW4NCj4gdGhhdCBvbmx5 IHRoZSByZXNlcnZlZCByZWdpb24gc2hvdWxkIGJlIG1hcHBlZC4NCg0KWWVzIEkgdGhpbmsgdGhp cyBpcyB0aGUgc2FtZSBxdWVzdGlvbiB0aGF0IEkgcmFpc2VkIGluIHRoZSBzY2lzc29ycyBsaW5l IG9mIHRoZQ0KY29tbWl0IG1lc3NhZ2Ugb2YgdGhpcyBwYXRjaC4gV2hhdCBJIGludGVuZCB0byBk byBpcyBzdGlsbCBtYXBwaW5nIHRoZSB3aG9sZQ0KUkFNIGJlY2F1c2Ugb2YgdGhlIHhlbmhlYXBf KiB2YXJpYWJsZXMgdGhhdCB5b3UgbWVudGlvbmVkIGluLi4uDQoNCj4gDQo+IE1vcmUgY29uZnVz aW5nbHksIHhlbmhlYXBfKiB2YXJpYWJsZXMgd2lsbCBjb3ZlciB0aGUgZnVsbCBSQU0uDQoNCi4u LmhlcmUuIEJ1dCBvbmx5IGFkZGluZyB0aGUgcmVzZXJ2ZWQgcmVnaW9uIHRvIHRoZSBib290IGFs bG9jYXRvciBzbyB0aGUNCnJlc2VydmVkIHJlZ2lvbiBjYW4gYmVjb21lIHRoZSBoZWFwIGxhdGVy IG9uLiBJIGFtIHdvbmRlcmluZyBpZiB3ZQ0KaGF2ZSBhIG1vcmUgY2xlYXIgd2F5IHRvIGRvIHRo YXQsIGFueSBzdWdnZXN0aW9ucz8NCg0KPiBFZmZlY3RpdmVseSwgdGhpcyBpcyBub3cgbW9yZSBv YnZpb3VzIHRoYXQgdGhpcyBpcyB1c2UgZm9yDQo+IGRpcmVjdC1tYXBwaW5nLiBTbyBJIHRoaW5r IGl0IHdvdWxkIGJlIGJldHRlciB0byByZW5hbWUgdGhlIHZhcmlhYmxlIHRvDQo+IGRpcmVjdG1h cF8qIG9yIHNpbWlsYXIuDQo+IA0KPiBJZGVhbGx5IHRoaXMgc2hvdWxkIGJlIGluIGEgc2VwYXJh dGUgcGF0Y2guDQoNClsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvNDhhMDcx MmMtZWZmOC1kZmMxLTIxMzYtNTkzMTdmMjIzMjFmQHhlbi5vcmcvDQoNCktpbmQgcmVnYXJkcywN CkhlbnJ5DQoNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 01 16:32:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 16:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396846.637188 (Exim 4.92) (envelope-from ) id 1oTn6u-00088e-Vh; Thu, 01 Sep 2022 16:32:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396846.637188; Thu, 01 Sep 2022 16:32:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTn6u-00088X-Sq; Thu, 01 Sep 2022 16:32:08 +0000 Received: by outflank-mailman (input) for mailman id 396846; Thu, 01 Sep 2022 16:32:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTn6s-00088R-FK for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 16:32:06 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c0d35bc-2a13-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 18:32:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c0d35bc-2a13-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 12:31:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662049922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lF0nzK0I3dkKY+VmvooE06KpjT5GF7za7apoY2ziCzA=; b=b+mGQz7e+S8nXflcP/Umq6k8mCFjCcajhS+oAKrOSAu3dWGCTZFUhafPBFCwtky43SVO1A 9liE+TRIsb/HqXx3Llx9NtT4cCnU5G225wc5/aVXkK7HBe0kN/DeWe/oPRR6yMuknOrEyX Th1UnEJvMcgJF/T8At8EC/TVB4d1otU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Mel Gorman Cc: Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901163155.sz4dqtubicdvzmsw@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831155941.q5umplytbx6offku@moria.home.lan> <20220901110501.o5rq5yzltomirxiw@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901110501.o5rq5yzltomirxiw@suse.de> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 12:05:01PM +0100, Mel Gorman wrote: > As pointed out elsewhere, attaching to the tracepoint and recording relevant > state is an option other than trying to parse a raw ftrace feed. For memory > leaks, there are already tracepoints for page allocation and free that could > be used to track allocations that are not freed at a given point in time. Page allocation tracepoints are not sufficient for what we're trying to do here, and a substantial amount of effort in this patchset has gone into just getting the hooking locations right - our memory allocation interfaces are not trivial. That's something people should keep in mind when commenting on the size of this patchset, since that's effort that would have to be spent for /any/ complete solution, be in tracepoint based or no. Additionally, we need to be able to write assertions that verify that our hook locations are correct, that allocations or frees aren't getting double counted or missed - highly necessary given the maze of nested memory allocation interfaces we have (i.e. slab.h), and it's something a tracepoint based implementation would have to account for - otherwise, a tool isn't very useful if you can't trust the numbers it's giving you. And then you have to correlate the allocate and free events, so that you know which allocate callsite to decrement the amount freed from. How would you plan on doing that with tracepoints? > There is also the kernel memory leak detector although I never had reason > to use it (https://www.kernel.org/doc/html/v6.0-rc3/dev-tools/kmemleak.html) > and it sounds like it would be expensive. Kmemleak is indeed expensive, and in the past I've had issues with it not catching everything (I've noticed the kmemleak annotations growing, so maybe this is less of an issue than it was). And this is a more complete solution (though not something that could strictly replace kmemleak): strict memory leaks aren't the only issue, it's also drivers unexpectedly consuming more memory than expected. I'll bet you a beer that when people have had this awhile, we're going to have a bunch of bugs discovered and fixed along the lines of "oh hey, this driver wasn't supposed to be using this 1 MB of memory, I never noticed that before". > > > It's also unclear *who* would enable this. It looks like it would mostly > > > have value during the development stage of an embedded platform to track > > > kernel memory usage on a per-application basis in an environment where it > > > may be difficult to setup tracing and tracking. Would it ever be enabled > > > in production? Would a distribution ever enable this? If it's enabled, any > > > overhead cannot be disabled/enabled at run or boot time so anyone enabling > > > this would carry the cost without never necessarily consuming the data. > > > > The whole point of this is to be cheap enough to enable in production - > > especially the latency tracing infrastructure. There's a lot of value to > > always-on system visibility infrastructure, so that when a live machine starts > > to do something wonky the data is already there. > > > > Sure, there is value but nothing stops the tracepoints being attached as > a boot-time service where interested. For latencies, there is already > bpf examples for tracing individual function latency over time e.g. > https://github.com/iovisor/bcc/blob/master/tools/funclatency.py although > I haven't used it recently. So this is cool, I'll check it out today. Tracing of /function/ latency is definitely something you'd want tracing/kprobes for - that's way more practical than any code tagging-based approach. And if the output is reliable and useful I could definitely see myself using this, thank you. But for data collection where it makes sense to annotate in the source code where the data collection points are, I see the code-tagging based approach as simpler - it cuts out a whole bunch of indirection. The diffstat on the code tagging time stats patch is 8 files changed, 233 insertions(+), 6 deletions(-) And that includes hooking wait.h - this is really simple, easy stuff. The memory allocation tracking patches are more complicated because we've got a ton of memory allocation interfaces and we're aiming for strict correctness there - because that tool needs strict correctness in order to be useful. > Live parsing of ftrace is possible, albeit expensive. > https://github.com/gormanm/mmtests/blob/master/monitors/watch-highorder.pl > tracks counts of high-order allocations and dumps a report on interrupt as > an example of live parsing ftrace and only recording interesting state. It's > not tracking state you are interested in but it demonstrates it is possible > to rely on ftrace alone and monitor from userspace. It's bit-rotted but > can be fixed with Yeah, if this is as far as people have gotten with ftrace on memory allocations than I don't think tracing is credible here, sorry. > The ease of use is a criticism as there is effort required to develop > the state tracking of in-kernel event be it from live parsing ftrace, > attaching to tracepoints with systemtap/bpf/whatever and the like. The > main disadvantage with an in-kernel implementation is three-fold. First, > it doesn't work with older kernels without backports. Second, if something > slightly different it needed then it's a kernel rebuild. Third, if the > option is not enabled in the deployed kernel config then you are relying > on the end user being willing to deploy a custom kernel. The initial > investment in doing memory leak tracking or latency tracking by attaching > to tracepoints is significant but it works with older kernels up to a point > and is less sensitive to the kernel config options selected as features > like ftrace are often selected. The next version of this patch set is going to use the alternatives mechanism to add a boot parameter. I'm not interested in backporting to older kernels - eesh. People on old enterprise kernels don't always get all the new shiny things :) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 17:08:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 17:08:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396852.637199 (Exim 4.92) (envelope-from ) id 1oTngO-00037V-SB; Thu, 01 Sep 2022 17:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396852.637199; Thu, 01 Sep 2022 17:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTngO-00037O-O9; Thu, 01 Sep 2022 17:08:48 +0000 Received: by outflank-mailman (input) for mailman id 396852; Thu, 01 Sep 2022 17:08:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTngN-00037F-Af for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 17:08:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc40969f-2a18-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 19:08:45 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E32CB61FD9; Thu, 1 Sep 2022 17:08:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2C0EC433D6; Thu, 1 Sep 2022 17:08:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc40969f-2a18-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662052123; bh=VpjvON3sVPsd8U1rNg088Qqso0kdxHxvxaDSoUjwo6Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JPOXyE/1a34n0qCijYduvy1yyOHswBgj6+ZbJvhWZi67Scw8XpCocJkIcOWFjsd5r YTnnQxsSwiGXNW6iLB88dwKibViXWklPk9pnDlV0TLEH4fJwyd48Gu3Sq74c/FaI1F 4uSwWkVX5pX762uj1qDQ4egLxrrHbHQRLU4OK9yOjUVzjBtWORO8tZxoskrlE5jXqP 6aUqWvqm+Rv2WzZx1zmRYkr2t8X2ESgV0STlyAeN+F7aPiJx9WBoYykvk5lQ+WiwQp +WiuuMwRPjNsxd6ZEwZrM1mbK+cuIG9HXwAowN8nLX0GwJ8xTTgYhtCHrcIteTba3d FD2C6COKiTGxQ== Date: Thu, 1 Sep 2022 10:08:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Henry Wang cc: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator In-Reply-To: Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Henry Wang wrote: > > -----Original Message----- > > From: Julien Grall > > Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and > > heap allocator > > > > Hi Henry, > > > > On 24/08/2022 08:31, Henry Wang wrote: > > > This commit firstly adds a global variable `reserved_heap`. > > > This newly introduced global variable is set at the device tree > > > parsing time if the reserved heap ranges are defined in the device > > > tree chosen node. > > > > > > For Arm32, In `setup_mm`, if the reserved heap is enabled, we use > > > the reserved heap region for both domheap and xenheap allocation. > > > > > > For Arm64, In `setup_mm`, if the reserved heap is enabled and used, > > > we make sure that only these reserved heap pages are added to the > > > boot allocator. These reserved heap pages in the boot allocator are > > > added to the heap allocator at `end_boot_allocator()`. > > > > > > If the reserved heap is disabled, we stick to current page allocation > > > strategy at boot time. > > > > > > Also, take the chance to correct a "double not" print in Arm32 > > > `setup_mm()`. > > > > > > Signed-off-by: Henry Wang > > > --- > > > With reserved heap enabled, for Arm64, naming of global variables such > > > as `xenheap_mfn_start` and `xenheap_mfn_end` seems to be ambiguous, > > > wondering if we should rename these variables. > > > --- > > > Changes from RFC to v1: > > > - Rebase on top of latest `setup_mm()` changes. > > > - Added Arm32 logic in `setup_mm()`. > > > --- > > > xen/arch/arm/bootfdt.c | 2 + > > > xen/arch/arm/include/asm/setup.h | 2 + > > > xen/arch/arm/setup.c | 79 +++++++++++++++++++++++++------- > > > 3 files changed, 67 insertions(+), 16 deletions(-) > > > > > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > > > index 33704ca487..ab73b6e212 100644 > > > --- a/xen/arch/arm/bootfdt.c > > > +++ b/xen/arch/arm/bootfdt.c > > > @@ -325,6 +325,8 @@ static int __init process_chosen_node(const void > > *fdt, int node, > > > true); > > > if ( rc ) > > > return rc; > > > + > > > + reserved_heap = true; > > > } > > > > > > printk("Checking for initrd in /chosen\n"); > > > diff --git a/xen/arch/arm/include/asm/setup.h > > b/xen/arch/arm/include/asm/setup.h > > > index e80f3d6201..00536a6d55 100644 > > > --- a/xen/arch/arm/include/asm/setup.h > > > +++ b/xen/arch/arm/include/asm/setup.h > > > @@ -92,6 +92,8 @@ extern struct bootinfo bootinfo; > > > > > > extern domid_t max_init_domid; > > > > > > +extern bool reserved_heap; > > > + > > > void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); > > > > > > size_t estimate_efi_size(unsigned int mem_nr_banks); > > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > > > index 500307edc0..fe76cf6325 100644 > > > --- a/xen/arch/arm/setup.c > > > +++ b/xen/arch/arm/setup.c > > > @@ -73,6 +73,8 @@ integer_param("xenheap_megabytes", > > opt_xenheap_megabytes); > > > > > > domid_t __read_mostly max_init_domid; > > > > > > +bool __read_mostly reserved_heap; > > > + > > > static __used void init_done(void) > > > { > > > /* Must be done past setting system_state. */ > > > @@ -699,8 +701,10 @@ static void __init populate_boot_allocator(void) > > > #ifdef CONFIG_ARM_32 > > > static void __init setup_mm(void) > > > { > > > - paddr_t ram_start, ram_end, ram_size, e; > > > - unsigned long ram_pages; > > > + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, > > bank_size; > > > + paddr_t reserved_heap_start = ~0, reserved_heap_end = 0, > > > + reserved_heap_size = 0; > > > + unsigned long ram_pages, reserved_heap_pages = 0; > > > unsigned long heap_pages, xenheap_pages, domheap_pages; > > > unsigned int i; > > > const uint32_t ctr = READ_CP32(CTR); > > > @@ -720,9 +724,9 @@ static void __init setup_mm(void) > > > > > > for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) > > > { > > > - paddr_t bank_start = bootinfo.mem.bank[i].start; > > > - paddr_t bank_size = bootinfo.mem.bank[i].size; > > > - paddr_t bank_end = bank_start + bank_size; > > > + bank_start = bootinfo.mem.bank[i].start; > > > + bank_size = bootinfo.mem.bank[i].size; > > > + bank_end = bank_start + bank_size; > > > > > > ram_size = ram_size + bank_size; > > > ram_start = min(ram_start,bank_start); > > > @@ -731,6 +735,25 @@ static void __init setup_mm(void) > > > > > > total_pages = ram_pages = ram_size >> PAGE_SHIFT; > > > > > > + if ( reserved_heap ) > > > + { > > > + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) > > > + { > > > + if ( bootinfo.reserved_mem.bank[i].xen_heap ) > > > + { > > > + bank_start = bootinfo.reserved_mem.bank[i].start; > > > + bank_size = bootinfo.reserved_mem.bank[i].size; > > > + bank_end = bank_start + bank_size; > > > + > > > + reserved_heap_size += bank_size; > > > + reserved_heap_start = min(reserved_heap_start, bank_start); > > > + reserved_heap_end = max(reserved_heap_end, bank_end); > > > + } > > > + } > > > + > > > + reserved_heap_pages = reserved_heap_size >> PAGE_SHIFT; > > > + } > > > + > > > /* > > > * If the user has not requested otherwise via the command line > > > * then locate the xenheap using these constraints: > > > @@ -743,7 +766,8 @@ static void __init setup_mm(void) > > > * We try to allocate the largest xenheap possible within these > > > * constraints. > > > */ > > > - heap_pages = ram_pages; > > > + heap_pages = !reserved_heap ? ram_pages : reserved_heap_pages; > > > + > > > if ( opt_xenheap_megabytes ) > > > xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); > > > else > > > @@ -755,17 +779,21 @@ static void __init setup_mm(void) > > > > > > do > > > { > > > - e = consider_modules(ram_start, ram_end, > > > + e = !reserved_heap ? > > > + consider_modules(ram_start, ram_end, > > > pfn_to_paddr(xenheap_pages), > > > - 32<<20, 0); > > > + 32<<20, 0) : > > > + reserved_heap_end; > > > > Not entirely related to this series. Now the assumption is the admin > > will make sure that none of the reserved regions will overlap. > > > > Do we have any tool to help the admin to verify it? If yes, can we have > > a pointer in the documentation? If not, should this be done in Xen? > > In the RFC we had the same discussion of this issue [1] and I think a > follow-up series might needed to do the overlap check if we want to > do that in Xen. For the existing tool, I am thinking of ImageBuilder, but > I am curious about Stefano's opinion. Yes, ImageBuilder is a good option and we moved ImageBuilder under Xen Project to make it easier for people to contribute to it: https://gitlab.com/xen-project/imagebuilder > > Also, what happen with UEFI? Is it easy to guarantee the region will not > > be used? > > For now I think it is not easy to guarantee that, do you have some ideas > in mind? I think I can follow this in above follow-up series to improve things. For clarity, are we worried that the region is used by the bootloader for other things? For instance U-Boot or Tianocore placing some firmware tables inside the range specified for xenheap? From xen-devel-bounces@lists.xenproject.org Thu Sep 01 17:08:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 17:08:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396853.637210 (Exim 4.92) (envelope-from ) id 1oTngV-0003OH-3N; Thu, 01 Sep 2022 17:08:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396853.637210; Thu, 01 Sep 2022 17:08:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTngU-0003OA-WD; Thu, 01 Sep 2022 17:08:55 +0000 Received: by outflank-mailman (input) for mailman id 396853; Thu, 01 Sep 2022 17:08:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTngU-0003Nk-AY for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 17:08:54 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1525dd0-2a18-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 19:08:53 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id p16so7356638lfd.6 for ; Thu, 01 Sep 2022 10:08:53 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b24-20020a196458000000b004946b7593fesm1530625lfj.198.2022.09.01.10.08.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 10:08:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1525dd0-2a18-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=XHRSQt/qwfKAxSmI7aXeTf1nP69MrNsfm23ssLVEMSw=; b=Ad5nZI8x9wXYvgsrpUul+9H+J2uTZUvQzH6jfQrBJuRdSfRqIL+2UB5Juja3Z8vrg0 AThC5Y2WomHCQoxYFfH+ONEHQMmownrTFqZ/jRHrJloRPFqun97cP9RFWdQwEs8BQiGk JW6Qs5XjF1Zgi2b7Kwv9MUvh+k4F71YwpLE2hdbRQS1hmsWM7FmpJUiDDPQ52qahZ8Cp Lh6fSh4j2bdBqSPqTJomXZoW2lIu8m7Gn3HuVqpsIn6pIltUbhspTWfnBRIQGEgQtHqX 2NTWBtMGm6HXTdIsZFI8BpSJYZlH0S05tEPquyNPpgDMh4FVBTebS/Fnn7QzwrxWucem Eakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=XHRSQt/qwfKAxSmI7aXeTf1nP69MrNsfm23ssLVEMSw=; b=jslhkIH5YiQs96OaMBXhKWnhLYsU+XonsW5+zP2oQlIYCUaHGE8TCH1cRVBSSlLBU6 u9Cb/omWRWUy7QfuCk/NvKANkGDz2Pji7ofSOb6edMb4q06Usj5kOM6OBbBZddwgqnKu lljRU53hif3/fckW6NR4JwG9Kd46FuT7V3SlpH/e98UySlZkF536QGz6q+n38U+SOQsb 3NqbJjb72f73GfKB0wnKhxd45kVoJUMNyRyS+YzHiiGDpPl76EFMF0r87sjenAR3gWu8 5+LmAHis7EEQ1c6op3cY5ZerDfM2L1pz7yjLg+KLBYFmPICh6PC99gETXNsXyV0DFF8n aE2w== X-Gm-Message-State: ACgBeo3WPrV7XrbHaDb5XGy1yDgHDydVkq2nGWy7Vso8xVJE3IztPG1S xzx/lqoU4P+aAvjMeYlYCiM= X-Google-Smtp-Source: AA6agR5qFFWYKYd9wrwVtRkdhp4cNqAAOSZACbtKbCCEnz2fGG6WEzP9ReFzM1m6oJg7Es2NFP2lhw== X-Received: by 2002:a05:6512:c03:b0:494:9f7b:7f84 with SMTP id z3-20020a0565120c0300b004949f7b7f84mr915591lfu.278.1662052132425; Thu, 01 Sep 2022 10:08:52 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 20:08:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant References: From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.09.22 12:29, Rahul Singh wrote: Hello Rahul > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh Reviewed-by: Oleksandr Tyshchenko Thanks! > --- > Changes in v3: > - fix minor comments > --- > xen/arch/arm/include/asm/pci.h | 2 ++ > xen/arch/arm/pci/pci-host-common.c | 43 ++++++++++++++++++++++++++++++ > xen/arch/x86/include/asm/pci.h | 10 +++++++ > xen/drivers/passthrough/pci.c | 8 +++--- > 4 files changed, 59 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h > index 80a2431804..8cb46f6b71 100644 > --- a/xen/arch/arm/include/asm/pci.h > +++ b/xen/arch/arm/include/asm/pci.h > @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, > > int pci_host_bridge_mappings(struct domain *d); > > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); > + > #else /*!CONFIG_HAS_PCI*/ > > struct arch_pci_dev { }; > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index 89ef30028e..0eb121666d 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -24,6 +24,16 @@ > > #include > > +/* > + * struct to hold pci device bar. > + */ > +struct pdev_bar > +{ > + mfn_t start; > + mfn_t end; > + bool is_valid; > +}; > + > /* > * List for all the pci host bridges. > */ > @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) > return 0; > } > > +static int is_bar_valid(const struct dt_device_node *dev, > + uint64_t addr, uint64_t len, void *data) > +{ > + struct pdev_bar *bar_data = data; > + unsigned long s = mfn_x(bar_data->start); > + unsigned long e = mfn_x(bar_data->end); > + > + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) > + bar_data->is_valid = true; > + > + return 0; > +} > + > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) > +{ > + int ret; > + const struct dt_device_node *dt_node; > + struct pdev_bar bar_data = { > + .start = start, > + .end = end, > + .is_valid = false > + }; > + > + dt_node = pci_find_host_bridge_node(pdev); > + if ( !dt_node ) > + return false; > + > + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); > + if ( ret < 0 ) > + return false; > + > + return bar_data.is_valid; > +} > /* > * Local variables: > * mode: C > diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h > index c8e1a9ecdb..f4a58c8acf 100644 > --- a/xen/arch/x86/include/asm/pci.h > +++ b/xen/arch/x86/include/asm/pci.h > @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) > > void arch_pci_init_pdev(struct pci_dev *pdev); > > +static inline bool pci_check_bar(const struct pci_dev *pdev, > + mfn_t start, mfn_t end) > +{ > + /* > + * Check if BAR is not overlapping with any memory region defined > + * in the memory map. > + */ > + return is_memory_hole(start, end); > +} > + > #endif /* __X86_PCI_H__ */ > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index cdaf5c247f..149f68bb6e 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) > if ( rc < 0 ) > /* Unable to size, better leave memory decoding disabled. */ > return; > - if ( size && !is_memory_hole(maddr_to_mfn(addr), > - maddr_to_mfn(addr + size - 1)) ) > + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), > + maddr_to_mfn(addr + size - 1)) ) > { > /* > * Return without enabling memory decoding if BAR position is not > @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) > > if ( rc < 0 ) > return; > - if ( size && !is_memory_hole(maddr_to_mfn(addr), > - maddr_to_mfn(addr + size - 1)) ) > + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), > + maddr_to_mfn(addr + size - 1)) ) > { > printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), > PFN_DOWN(addr + size - 1)); -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Sep 01 17:12:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 17:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396864.637221 (Exim 4.92) (envelope-from ) id 1oTnkK-00055K-Jw; Thu, 01 Sep 2022 17:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396864.637221; Thu, 01 Sep 2022 17:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTnkK-00055D-H9; Thu, 01 Sep 2022 17:12:52 +0000 Received: by outflank-mailman (input) for mailman id 396864; Thu, 01 Sep 2022 17:12:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTnkJ-000557-AD for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 17:12:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTnkJ-0000S3-0T; Thu, 01 Sep 2022 17:12:51 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTnkI-0001WB-Pd; Thu, 01 Sep 2022 17:12:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lsqUYYSRF6jOmbFLfp3LWn7c6Qiy5nQCpNZjqBdj4eU=; b=DfXlhcgUkMNFUKxfwqSVxa5NxV wBmv2z4UkItlAlq1CIltPCDuXzGy882G2tNahl+7hUSdpc0IDBRv84lkuNqzxg/6Ioc/Jc3FGJ6uc DmuYaFcAncYbUob0r3U5kfItc3r4hxBIiOervL6NhJXuKrxaLg8fbkBOwG7WbXhTr4YA=; Message-ID: <781b03df-5f0d-109c-6253-2b7c4a079ce1@xen.org> Date: Thu, 1 Sep 2022 18:12:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v6 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220721132115.3015761-1-Penny.Zheng@arm.com> <20220721132115.3015761-6-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220721132115.3015761-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 21/07/2022 14:21, Penny Zheng wrote: > Borrower domain will fail to get a page ref using the owner domain > during allocation, when the owner is created after borrower. > > So here, we decide to get and add the right amount of reference, which > is the number of borrowers, when the owner is allocated. > > Signed-off-by: Penny Zheng > Reviewed-by: Stefano Stabellini IMHO, this tag should not have been kept given... > --- > v6 change: > - adapt to the change of "nr_shm_borrowers" ... this change. 'reviewed-by' means that the person reviewed the code and therefore agree with the logic. So I would only keep the tag if the change is trivial (including typo, coding style) and would drop it (or confirm with the person) otherwise. Stefano, can you confirm you are happy that your reviewed-by tag is kept? > - add in-code comment to explain if the borrower is created first, we intend to > add pages in the P2M without reference. > --- > v5 change: > - no change > --- > v4 changes: > - no change > --- > v3 change: > - printk rather than dprintk since it is a serious error > --- > v2 change: > - new commit > --- > xen/arch/arm/domain_build.c | 60 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index a7e95c34a7..e891e800a7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -761,6 +761,30 @@ static void __init assign_static_memory_11(struct domain *d, > } > > #ifdef CONFIG_STATIC_SHM > +static int __init acquire_nr_borrower_domain(struct domain *d, > + paddr_t pbase, paddr_t psize, > + unsigned long *nr_borrowers) > +{ > + unsigned long bank; NIT: AFAICT nr_banks is an "unsigned int". Other than that: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 17:19:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 17:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396872.637231 (Exim 4.92) (envelope-from ) id 1oTnr1-0005pK-Ev; Thu, 01 Sep 2022 17:19:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396872.637231; Thu, 01 Sep 2022 17:19:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTnr1-0005pD-CH; Thu, 01 Sep 2022 17:19:47 +0000 Received: by outflank-mailman (input) for mailman id 396872; Thu, 01 Sep 2022 17:19:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTnr0-0005p7-CF for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 17:19:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTnr0-0000Yd-07; Thu, 01 Sep 2022 17:19:46 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTnqz-0001gB-QB; Thu, 01 Sep 2022 17:19:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MatNpidnBSSoOOMKery1Yow8frUNsc3/HSYXvmw1YrA=; b=23Fkjnhbu+zCUbXHwlE6WLdyV0 ubPPVfMpyE4yTsi/sbXZbD83bBW0rcj56ZbmH4iTppj2sirjtQSiXHKXzPYUsUKlWb0vEjREetoY9 JrURP9PLUqPbMMKbNV5DAKFT9lc3eMXqF3JyrJXWxkSwReL0fnNMVU9MOGITE+TmgbwY=; Message-ID: Date: Thu, 1 Sep 2022 18:19:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini Cc: Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 01/09/2022 17:05, Henry Wang wrote: >>> @@ -755,17 +779,21 @@ static void __init setup_mm(void) >>> >>> do >>> { >>> - e = consider_modules(ram_start, ram_end, >>> + e = !reserved_heap ? >>> + consider_modules(ram_start, ram_end, >>> pfn_to_paddr(xenheap_pages), >>> - 32<<20, 0); >>> + 32<<20, 0) : >>> + reserved_heap_end; >> >> Not entirely related to this series. Now the assumption is the admin >> will make sure that none of the reserved regions will overlap. >> >> Do we have any tool to help the admin to verify it? If yes, can we have >> a pointer in the documentation? If not, should this be done in Xen? > > In the RFC we had the same discussion of this issue [1] and I think a > follow-up series might needed to do the overlap check if we want to > do that in Xen. For the existing tool, I am thinking of ImageBuilder, but > I am curious about Stefano's opinion. > >> >> Also, what happen with UEFI? Is it easy to guarantee the region will not >> be used? > > For now I think it is not easy to guarantee that, do you have some ideas > in mind? I think I can follow this in above follow-up series to improve things. I don't have any ideas how we can guarantee it (even when using image builder). I think we may have to end up to check the overlaps in Xen. > >> >>> + >>> if ( e ) >>> break; >>> >>> xenheap_pages >>= 1; >>> } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20- >> PAGE_SHIFT) ); >>> >>> - if ( ! e ) >>> - panic("Not not enough space for xenheap\n"); >>> + if ( ! e || >>> + ( reserved_heap && reserved_heap_pages < 32<<(20-PAGE_SHIFT) ) ) >>> + panic("Not enough space for xenheap\n"); >> >> So on arm32, the xenheap *must* be contiguous. AFAICT, >> reserved_heap_pages is the total number of pages in the heap. They may >> not be contiguous. So I think this wants to be reworked so we look for >> one of the region that match the definition written above the loop. > > Thanks for raising this concern, I will do this in V2. > >> >>> >>> domheap_pages = heap_pages - xenheap_pages; >>> >>> @@ -810,9 +838,9 @@ static void __init setup_mm(void) >>> static void __init setup_mm(void) >>> { >>> const struct meminfo *banks = &bootinfo.mem; >>> - paddr_t ram_start = ~0; >>> - paddr_t ram_end = 0; >>> - paddr_t ram_size = 0; >>> + paddr_t ram_start = ~0, bank_start = ~0; >>> + paddr_t ram_end = 0, bank_end = 0; >>> + paddr_t ram_size = 0, bank_size = 0; >>> unsigned int i; >>> >>> init_pdx(); >>> @@ -821,17 +849,36 @@ static void __init setup_mm(void) >>> * We need some memory to allocate the page-tables used for the >> xenheap >>> * mappings. But some regions may contain memory already allocated >>> * for other uses (e.g. modules, reserved-memory...). >>> - * >>> + * If reserved heap regions are properly defined, (only) add these >> regions >>> + * in the boot allocator. > + */ >>> + if ( reserved_heap ) >>> + { >>> + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) >>> + { >>> + if ( bootinfo.reserved_mem.bank[i].xen_heap ) >>> + { >>> + bank_start = bootinfo.reserved_mem.bank[i].start; >>> + bank_size = bootinfo.reserved_mem.bank[i].size; >>> + bank_end = bank_start + bank_size; >>> + >>> + init_boot_pages(bank_start, bank_end); >>> + } >>> + } >>> + } >>> + /* >>> + * No reserved heap regions: >>> * For simplicity, add all the free regions in the boot allocator. >>> */ >>> - populate_boot_allocator(); >>> + else >>> + populate_boot_allocator(); >>> >>> total_pages = 0; >>> >>> for ( i = 0; i < banks->nr_banks; i++ ) >>> { >> >> This code is now becoming quite confusing to understanding. This loop is >> meant to map the xenheap. If I follow your documentation, it would mean >> that only the reserved region should be mapped. > > Yes I think this is the same question that I raised in the scissors line of the > commit message of this patch. Sorry I didn't notice the comment after the scissors line. This is the same question :) > What I intend to do is still mapping the whole > RAM because of the xenheap_* variables that you mentioned in... > >> >> More confusingly, xenheap_* variables will cover the full RAM. > > ...here. But only adding the reserved region to the boot allocator so the > reserved region can become the heap later on. I am wondering if we > have a more clear way to do that, any suggestions? I think your code is correct. It only needs some renaming of the existing variable (maybe to directmap_*?) to make clear the area is used to access the RAM easily. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 17:34:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 17:34:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396879.637245 (Exim 4.92) (envelope-from ) id 1oTo5E-00088s-Md; Thu, 01 Sep 2022 17:34:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396879.637245; Thu, 01 Sep 2022 17:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTo5E-00088l-K3; Thu, 01 Sep 2022 17:34:28 +0000 Received: by outflank-mailman (input) for mailman id 396879; Thu, 01 Sep 2022 17:34:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTo5C-00088f-PI for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 17:34:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTo5C-0000ny-F2; Thu, 01 Sep 2022 17:34:26 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTo5C-0002Ki-7A; Thu, 01 Sep 2022 17:34:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jJML3cTL7gnqvlEUKSuQiexy69p9vmBmLuGdbp6eSzU=; b=hCyoG0CKf8SRcvNQoM+9pBxuYW YvWkIvduDOX//CsjZfm4x9dtZI/xeKi9KPEYTeRN0HNMX8wm504V3GaY6yJWl/IWQcp+Weg4TbBnE V88+x0sqKPkQJtcES4QycRGBMM8QENF4z1OP9g5mQggeNVxZ5+Lok3ViILHOmM2f77PU=; Message-ID: Date: Thu, 1 Sep 2022 18:34:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Stefano Stabellini , Henry Wang Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 01/09/2022 18:08, Stefano Stabellini wrote: >>> Also, what happen with UEFI? Is it easy to guarantee the region will not >>> be used? >> >> For now I think it is not easy to guarantee that, do you have some ideas >> in mind? I think I can follow this in above follow-up series to improve things. > > For clarity, are we worried that the region is used by the bootloader > for other things? For instance U-Boot or Tianocore placing some > firmware tables inside the range specified for xenheap? Yes. I think it would be difficult for an admin to figure out which regions are used. Although they are likely (?) going to be static for a given UEFI/U-boot build. My major concern is such bug can be very difficult to root cause because we have no safety in Xen. The most likely symptom would be random corruption. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 17:41:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 17:41:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396886.637260 (Exim 4.92) (envelope-from ) id 1oToCF-00019k-GC; Thu, 01 Sep 2022 17:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396886.637260; Thu, 01 Sep 2022 17:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oToCF-00019d-D2; Thu, 01 Sep 2022 17:41:43 +0000 Received: by outflank-mailman (input) for mailman id 396886; Thu, 01 Sep 2022 17:41:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oToCE-00019X-HQ for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 17:41:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oToCE-0000wW-AX; Thu, 01 Sep 2022 17:41:42 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oToCE-0002ZN-4V; Thu, 01 Sep 2022 17:41:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Y0keqWveo3wRDP4YTCw6DOAAtgp5G+ZfabFLhzdiqTo=; b=5xzwdC4Jqz8soUVvVVrDXc8U1M YfdliA4KxUUBfnX1uPBoMLESfzha+sCv87ktNnoHyHr7NeC0m/GXBn1HhxRaUkMQFKOxVLbz66IG3 vNu8rUgoM5vS/UIa9s4CG1WbK8h+CcjSkN0nuq3LZ4XdlWPPlooSY7nWPs9Ikj9wMaoU=; Message-ID: <538c6b57-df40-8462-1dea-faa93d318774@xen.org> Date: Thu, 1 Sep 2022 18:41:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Content-Language: en-US To: Michal Orzel , Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <4ae16201df27aee274a3d740128812b118c252b3.1662023183.git.rahul.singh@arm.com> <99eff10e-6b7b-df74-5017-7628c0b0bd7a@amd.com> From: Julien Grall In-Reply-To: <99eff10e-6b7b-df74-5017-7628c0b0bd7a@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 01/09/2022 14:53, Michal Orzel wrote: > On 01/09/2022 11:13, Rahul Singh wrote: >> >> Restrict the maximum number of evtchn supported for domUs to avoid >> allocating a large amount of memory in Xen. >> >> Set the default value of max_evtchn_port to 1023. The value of 1023 >> should be sufficient for domUs guests because on ARM we don't bind >> physical interrupts to event channels. The only use of the evtchn port >> is inter-domain communications. > Following the previous discussion, I think the only missing piece is > an explanation that 1023 was chose to follow the default behavior of libxl. +1. The current explanation only justify why we haven't added a device-tree property to change the default value. > > Apart from that: > Reviewed-by: Michal Orzel Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 18:07:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 18:07:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396892.637271 (Exim 4.92) (envelope-from ) id 1oTob0-0003gb-ID; Thu, 01 Sep 2022 18:07:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396892.637271; Thu, 01 Sep 2022 18:07:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTob0-0003gU-FD; Thu, 01 Sep 2022 18:07:18 +0000 Received: by outflank-mailman (input) for mailman id 396892; Thu, 01 Sep 2022 18:07:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oToay-0003gO-Tt for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 18:07:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oToay-0001Tn-JP; Thu, 01 Sep 2022 18:07:16 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oToay-0003vu-7t; Thu, 01 Sep 2022 18:07:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=A+casrNcZi5q50Rj3Fynf84+uDd3HTNk8/llaeidYH0=; b=2CSceb+hnb/Oa8j5rbsRzplLi7 teOIiOgLfS0Csp8m660hHoNwiQdtDuGywU19nF+GMtXBXPkthOozTrP3WDa/5pJkQTRPzFAQwwzXT eVIfZnz1zuDHzANfjWLeePz+hH5GbY/1AFDWhN5+NIkdf+Jbinw8LtdiIH7bv171zDHQ=; Message-ID: <2142aa46-24a0-e0cb-16c0-95e8f6302ce6@xen.org> Date: Thu, 1 Sep 2022 19:07:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <3899ada4cc8217b45eab4f8d85492b0d5a6a9580.1662023183.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: <3899ada4cc8217b45eab4f8d85492b0d5a6a9580.1662023183.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 01/09/2022 10:13, Rahul Singh wrote: > Introduce a new sub-node under /chosen node to establish static event > channel communication between domains on dom0less systems. > > An event channel will be created beforehand to allow the domains to > send notifications to each other. > > Signed-off-by: Rahul Singh > --- > Changes in v3: > - use device-tree used_by to find the domain id of the evtchn node. > - add new static_evtchn_create variable in struct dt_device_node to > hold the information if evtchn is already created. > - fix minor comments > Changes in v2: > - no change > --- > docs/misc/arm/device-tree/booting.txt | 64 ++++++++++++- > xen/arch/arm/domain_build.c | 128 ++++++++++++++++++++++++++ > xen/arch/arm/include/asm/setup.h | 1 + > xen/arch/arm/setup.c | 2 + > xen/include/xen/device_tree.h | 13 +++ > 5 files changed, 207 insertions(+), 1 deletion(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..edef98e6d1 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -212,7 +212,7 @@ with the following properties: > enable only selected interfaces. > > Under the "xen,domain" compatible node, one or more sub-nodes are present > -for the DomU kernel and ramdisk. > +for the DomU kernel, ramdisk and static event channel. > > The kernel sub-node has the following properties: > > @@ -254,11 +254,44 @@ The ramdisk sub-node has the following properties: > property because it will be created by the UEFI stub on boot. > This option is needed only when UEFI boot is used. > > +The static event channel sub-node has the following properties: > + > +- compatible > + > + "xen,evtchn" > + > +- xen,evtchn > + > + The property is tuples of two numbers > + (local-evtchn link-to-foreign-evtchn) where: > + > + local-evtchn is an integer value that will be used to allocate local port > + for a domain to send and receive event notifications to/from the remote > + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. > + It is recommended to use low event channel IDs. > + > + link-to-foreign-evtchn is a single phandle to a remote evtchn to which > + local-evtchn will be connected. > > Example > ======= > > chosen { > + > + module@0 { > + compatible = "multiboot,kernel", "multiboot,module"; > + xen,uefi-binary = "..."; > + bootargs = "..."; > + > + }; NIT: Describing this node in the example seems unnecessary. > + > + /* one sub-node per local event channel */ > + ec1: evtchn@1 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec2>; > + }; > + Here you provide an example for dom0. But the position where you describe the binding suggests this binding only exists for domUs. Either we duplicate the binding or we re-order the documentation to have common binding in a single place. My preference would be the latter. > domU1 { > compatible = "xen,domain"; > #address-cells = <0x2>; > @@ -277,6 +310,23 @@ chosen { > compatible = "multiboot,ramdisk", "multiboot,module"; > reg = <0x0 0x4b000000 0xffffff>; > }; > + > + /* one sub-node per local event channel */ > + ec2: evtchn@2 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec1>; > + }; > + > + ec3: evtchn@3 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xb &ec5>; > + }; > + > + ec4: evtchn@4 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xc &ec6>; > + }; > }; > > domU2 { > @@ -296,6 +346,18 @@ chosen { > compatible = "multiboot,ramdisk", "multiboot,module"; > reg = <0x0 0x4d000000 0xffffff>; > }; > + > + /* one sub-node per local event channel */ > + ec5: evtchn@5 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xb &ec3>; > + }; > + > + ec6: evtchn@6 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xd &ec4>; > + }; > }; > }; > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 707e247f6a..4b24261825 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -33,6 +33,8 @@ > #include > #include > > +#define STATIC_EVTCHN_NODE_SIZE_CELLS 2 > + > static unsigned int __initdata opt_dom0_max_vcpus; > integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); > > @@ -3052,6 +3054,131 @@ void __init evtchn_allocate(struct domain *d) > d->arch.hvm.params[HVM_PARAM_CALLBACK_IRQ] = val; > } > > +static int __init get_evtchn_dt_property(const struct dt_device_node *np, > + uint32_t *port, uint32_t *phandle) > +{ > + const __be32 *prop = NULL; > + uint32_t len; > + > + prop = dt_get_property(np, "xen,evtchn", &len); > + if ( !prop ) > + { > + printk(XENLOG_ERR "xen,evtchn property should not be empty.\n"); > + return -EINVAL; > + } > + > + if ( !len || len < dt_cells_to_size(STATIC_EVTCHN_NODE_SIZE_CELLS) ) > + { > + printk(XENLOG_ERR "xen,evtchn property value is not valid.\n"); > + return -EINVAL; > + } > + > + *port = dt_next_cell(1, &prop); > + *phandle = dt_next_cell(1, &prop); > + > + return 0; > +} > + > +static int __init alloc_domain_evtchn(struct dt_device_node *node) > +{ > + int rc; > + uint32_t domU1_port, domU2_port, remote_phandle; > + struct dt_device_node *remote_node; > + struct evtchn_alloc_unbound alloc_unbound; > + struct evtchn_bind_interdomain bind_interdomain; > + struct domain *d1 = NULL, *d2 = NULL; > + > + if ( dt_device_static_evtchn_created(node) ) I think this deserve a comment explain why the node would be created. I.e it would happen if the other side was created first. I will comment about dt_device_static_evtchn_created() futher down. > + return 0; > + > + rc = get_evtchn_dt_property(node, &domU1_port, &remote_phandle); > + if ( rc ) > + return rc; > + > + remote_node = dt_find_node_by_phandle(remote_phandle); > + if ( !remote_node ) > + { > + printk(XENLOG_ERR > + "evtchn: could not find remote evtchn phandle\n"); > + return -EINVAL; > + } > + > + rc = get_evtchn_dt_property(remote_node, &domU2_port, &remote_phandle); > + if ( rc ) > + return rc; > + > + if ( node->phandle != remote_phandle ) > + { > + printk(XENLOG_ERR "xen,evtchn property is not setup correctly.\n"); > + return -EINVAL; > + } > + > + d1 = get_domain_by_id(dt_get_parent(node)->used_by); > + d2 = get_domain_by_id(dt_get_parent(remote_node)->used_by); I think dt_get_parent() could return NULL (i.e. for the root). So I think you want to check that at least remote_node() has a parent. For convenience, this check could be done in > + > + if ( !d1 || !d2 ) > + { > + printk(XENLOG_ERR "evtchn: could not find domains\n" ); > + return -EINVAL; > + } > + > + alloc_unbound.dom = d1->domain_id; > + alloc_unbound.remote_dom = d2->domain_id; > + > + rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); > + if ( rc < 0 ) > + { > + printk(XENLOG_ERR > + "evtchn_alloc_unbound() failure (Error %d) \n", rc); > + return rc; > + } > + > + bind_interdomain.remote_dom = d1->domain_id; > + bind_interdomain.remote_port = domU1_port; > + > + rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port); > + if ( rc < 0 ) > + { > + printk(XENLOG_ERR > + "evtchn_bind_interdomain() failure (Error %d) \n", rc); > + return rc; > + } > + > + dt_device_set_static_evtchn_created(node); > + dt_device_set_static_evtchn_created(remote_node); > + > + return 0; > +} > + > +void __init process_static_evtchn_node(struct dt_device_node *node) This is missing a prototype. So I guess this wants to be static? That said, I think it would make more sense to fold process_static_evtchn_node() in alloc_domain_evtchn() or alloc_static-evtchn(). > +{ > + if ( dt_device_is_compatible(node, "xen,evtchn-v1") ) > + { > + if ( alloc_domain_evtchn(node) != 0 ) > + panic("Could not set up domains evtchn\n"); > + } > +} > + > +void __init alloc_static_evtchn(void) > +{ > + struct dt_device_node *node, *evtchn_node; > + struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); > + > + BUG_ON(chosen == NULL); > + > + if ( hardware_domain ) > + dt_device_set_used_by(chosen, hardware_domain->domain_id); > + > + dt_for_each_child_node(chosen, node) > + { > + if ( hardware_domain ) > + process_static_evtchn_node(node); > + > + dt_for_each_child_node(node, evtchn_node) > + process_static_evtchn_node(evtchn_node); > + } > +} > + > static void __init find_gnttab_region(struct domain *d, > struct kernel_info *kinfo) > { > @@ -3364,6 +3491,7 @@ void __init create_domUs(void) > panic("Error creating domain %s\n", dt_node_name(node)); > > d->is_console = true; > + dt_device_set_used_by(node, d->domain_id); > > if ( construct_domU(d, node) != 0 ) > panic("Could not set up domain %s\n", dt_node_name(node)); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..5ee28b270f 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -106,6 +106,7 @@ int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); > > void create_domUs(void); > void create_dom0(void); > +void alloc_static_evtchn(void); > > void discard_initial_modules(void); > void fw_unreserved_regions(paddr_t s, paddr_t e, > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 6e0398f3f6..cf15d359d2 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1077,6 +1077,8 @@ void __init start_xen(unsigned long boot_phys_offset, > if ( acpi_disabled ) > create_domUs(); > > + alloc_static_evtchn(); > + > /* > * This needs to be called **before** heap_init_late() so modules > * will be scrubbed (unless suppressed). > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index 430a1ef445..5579c875d2 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -82,6 +82,7 @@ struct dt_device_node { > dt_phandle phandle; > char *full_name; > domid_t used_by; /* By default it's used by dom0 */ > + bool_t static_evtchn_created; I can see why you want to add the boolean in dt_device_node. However, I dislike this approach because this feels an abuse of dt_device_node and the field is only used at boot. So this seems to be a bit of a waste to include it in the structure (even if we are re-using padding today). I don't have a solution that is has trivial as this approach. However, at minimum we should document this is a HACK and should be remove if we need space in the structure. > > struct dt_property *properties; > struct dt_device_node *parent; > @@ -317,6 +318,18 @@ static inline bool_t dt_property_name_is_equal(const struct dt_property *pp, > return !dt_prop_cmp(pp->name, name); > } > > +static inline void > +dt_device_set_static_evtchn_created(struct dt_device_node *device) > +{ > + device->static_evtchn_created = true; > +} > + > +static inline bool_t > +dt_device_static_evtchn_created(const struct dt_device_node *device) > +{ > + return device->static_evtchn_created; > +} > + > /** > * dt_find_compatible_node - Find a node based on type and one of the > * tokens in its "compatible" property Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 18:15:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 18:15:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396897.637282 (Exim 4.92) (envelope-from ) id 1oTojE-00059P-EH; Thu, 01 Sep 2022 18:15:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396897.637282; Thu, 01 Sep 2022 18:15:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTojE-00059I-9w; Thu, 01 Sep 2022 18:15:48 +0000 Received: by outflank-mailman (input) for mailman id 396897; Thu, 01 Sep 2022 18:15:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTojC-00059C-Vl for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 18:15:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTojC-0001cU-Mv; Thu, 01 Sep 2022 18:15:46 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.12.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oTojC-0004OO-Fb; Thu, 01 Sep 2022 18:15:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+eJ8yffwd3+I1PKdtLVlUSP0MI8XZQkWC7Gi+VUC6GM=; b=JwP2v6fFiKfkkUgxu5nNikbguO ykaslXD4kjHqXWQPmLUi0M4cT5jp4M3p+GE8KYO5SYQ2NY1Jftm315pO6J1T4KGB7+5S9RyhEQWR5 E+qDAjc5lOhfhNcdnuulpcf6EbaP8agyfcQSFi17w3oWRJvekrEYn1aW2shFeTBdECfg=; Message-ID: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> Date: Thu, 1 Sep 2022 19:15:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 01/09/2022 10:13, Rahul Singh wrote: > Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to > disable xenstore interface for dom0less guests. > > Signed-off-by: Rahul Singh > --- > Changes in v3: > - new patch in this version > --- > docs/misc/arm/device-tree/booting.txt | 4 ++++ > xen/arch/arm/domain_build.c | 10 +++++++--- > xen/arch/arm/include/asm/kernel.h | 3 +++ > 3 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index edef98e6d1..87f57f8889 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -204,6 +204,10 @@ with the following properties: > - "disabled" > Xen PV interfaces are disabled. > > + - no-xenstore > + Xen PV interfaces, including grant-table will be enabled for the VM but > + xenstore will be disabled for the VM. NIT: I would drop one of the "for the VM" as it seems to be redundant. > + > If the xen,enhanced property is present with no value, it defaults > to "enabled". If the xen,enhanced property is not present, PV > interfaces are disabled. > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4b24261825..8dd9984225 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3336,10 +3336,14 @@ static int __init construct_domU(struct domain *d, > (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) > { > if ( hardware_domain ) > - kinfo.dom0less_enhanced = true; > + kinfo.dom0less_xenstore = true; > else > - panic("Tried to use xen,enhanced without dom0\n"); > + panic("Tried to use xen,enhanced without dom0 without no-xenstore\n"); This is a bit hard to parse. How about: "At the moment, Xenstore support requires dom0 to be present" > } > + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) > + kinfo.dom0less_xenstore = false; > + > + kinfo.dom0less_enhanced = true; Wouldn't this now set dom0less_enhanced unconditionally? > > if ( vcpu_create(d, 0) == NULL ) > return -ENOMEM; > @@ -3379,7 +3383,7 @@ static int __init construct_domU(struct domain *d, > if ( rc < 0 ) > return rc; > > - if ( kinfo.dom0less_enhanced ) > + if ( kinfo.dom0less_xenstore ) > { > ASSERT(hardware_domain); > rc = alloc_xenstore_evtchn(d); > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index c4dc039b54..3d7fa94910 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -39,6 +39,9 @@ struct kernel_info { > /* Enable PV drivers */ > bool dom0less_enhanced; > > + /* Enable Xenstore */ > + bool dom0less_xenstore; > + AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an enum with 3 values: - None - NOXENSTORE/BASIC - FULLY_ENHANCED If we want to be future proof, I would use a field 'flags' where non-zero means enhanced. Each bit would indicate which features of Xen is exposed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 01 19:00:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 19:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396907.637296 (Exim 4.92) (envelope-from ) id 1oTpQ4-0001U4-Py; Thu, 01 Sep 2022 19:00:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396907.637296; Thu, 01 Sep 2022 19:00:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTpQ4-0001TX-Li; Thu, 01 Sep 2022 19:00:04 +0000 Received: by outflank-mailman (input) for mailman id 396907; Thu, 01 Sep 2022 19:00:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTpQ3-0001A8-Ap for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 19:00:03 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47c71bfb-2a28-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 21:00:01 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTpPP-008Swy-VE; Thu, 01 Sep 2022 18:59:24 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8F5993002C7; Thu, 1 Sep 2022 20:59:20 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 729172B8B840F; Thu, 1 Sep 2022 20:59:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47c71bfb-2a28-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qo1Y7wjVRM1IPrvgDfwSP6kiSpx5CHm6THH/U/nXDvQ=; b=Cn40tdhd1E1TwjC2GqnrK/VMBS bok5IW5dPqC9b0Puyc5kB0GIPwBvnyb6nAzkLqRz8cvGe+hZxxiWfH5MRjXqCuiD8wRV3vAuxJP+J rBin1pHHm0PdKxLBfMtFhMb+NWLGsCy4r7eBzhOiR3RJwsipcHoCKo1LbfkIAxXUeO3hEsfIiXhrq k8QoRcUNeRFsus+I7Ba6wWsVhV63eeopBg9ahpU9S/Ox/FDoVHSGM37kZ29behPJVXZzWay4XLu5T q0+gdXxrW0zeerMoRET2yGibvMP6RcQg1rpJRDmnkL9WKUV+AjGLfBnI/ialwweB0bUk0PRwtZdkh fjN9qgsg==; Date: Thu, 1 Sep 2022 20:59:20 +0200 From: Peter Zijlstra To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/30] Lazy percpu counters Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-4-surenb@google.com> <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> On Thu, Sep 01, 2022 at 10:32:19AM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > > +static void lazy_percpu_counter_switch_to_pcpu(struct raw_lazy_percpu_counter *c) > > > +{ > > > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__GFP_NOWARN); > > > > Realize that this is incorrect when used under a raw_spinlock_t. > > Can you elaborate? required lock order: raw_spinlock_t < spinlock_t < mutex allocators lives at spinlock_t. Also see CONFIG_PROVE_RAW_LOCK_NESTING and there might be a document mentioning all this somewhere. Additionally, this (obviously) also isn't NMI safe. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 19:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 19:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396916.637307 (Exim 4.92) (envelope-from ) id 1oTpfB-0003OF-2G; Thu, 01 Sep 2022 19:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396916.637307; Thu, 01 Sep 2022 19:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTpfA-0003O8-Vq; Thu, 01 Sep 2022 19:15:40 +0000 Received: by outflank-mailman (input) for mailman id 396916; Thu, 01 Sep 2022 19:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTpfA-0003O2-7U for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 19:15:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76a338e9-2a2a-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 21:15:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 164EB33749; Thu, 1 Sep 2022 19:15:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E01CE13A79; Thu, 1 Sep 2022 19:15:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fSsfNtkEEWNbVwAAMHmgww (envelope-from ); Thu, 01 Sep 2022 19:15:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76a338e9-2a2a-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662059738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZXQSRqer3+FtfHBMGJ4s/SGRUTOoWiBwBxr7NnCmrIE=; b=HIwU2YpwnrE5NOlkMJL4ArkkguYGM6Uuv9mVzuDeMrV+CL1O1JAjH2PyiZhwzHs5d6Wd1L EizrfQTDfPcrC+OaDzCXbjkbXhZ3LjWuJBCYcYu92bDTSWDpbgxXjkuDAaz/tyPrX55oN0 b8fl7WeD5/bzHreO5sHpMhB/5J3nk9g= Date: Thu, 1 Sep 2022 21:15:34 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu 01-09-22 08:33:19, Suren Baghdasaryan wrote: > On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: [...] > > So I find Peter's question completely appropriate while your response to > > that not so much! Maybe ftrace is not the right tool for the intented > > job. Maybe there are other ways and it would be really great to show > > that those have been evaluated and they are not suitable for a), b) and > > c) reasons. > > That's fair. > For memory tracking I looked into using kmemleak and page_owner which > can't match the required functionality at an overhead acceptable for > production and pre-production testing environments. Being more specific would be really helpful. Especially when your cover letter suggests that you rely on page_owner/memcg metadata as well to match allocation and their freeing parts. > traces + BPF I > haven't evaluated myself but heard from other members of my team who > tried using that in production environment with poor results. I'll try > to get more specific information on that. That would be helpful as well. > > E.g. Oscar has been working on extending page_ext to track number of > > allocations for specific calltrace[1]. Is this 1:1 replacement? No! But > > it can help in environments where page_ext can be enabled and it is > > completely non-intrusive to the MM code. > > Thanks for pointing out this work. I'll need to review and maybe > profile it before making any claims. > > > > > If the page_ext overhead is not desirable/acceptable then I am sure > > there are other options. E.g. kprobes/LivePatching framework can hook > > into functions and alter their behavior. So why not use that for data > > collection? Has this been evaluated at all? > > I'm not sure how I can hook into say alloc_pages() to find out where > it was called from without capturing the call stack (which would > introduce an overhead at every allocation). Would love to discuss this > or other alternatives if they can be done with low enough overhead. Yes, tracking back the call trace would be really needed. The question is whether this is really prohibitively expensive. How much overhead are we talking about? There is no free lunch here, really. You either have the overhead during runtime when the feature is used or on the source code level for all the future development (with a maze of macros and wrappers). Thanks! -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 19:39:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 19:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396924.637321 (Exim 4.92) (envelope-from ) id 1oTq2A-0005pA-1b; Thu, 01 Sep 2022 19:39:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396924.637321; Thu, 01 Sep 2022 19:39:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTq29-0005p3-V5; Thu, 01 Sep 2022 19:39:25 +0000 Received: by outflank-mailman (input) for mailman id 396924; Thu, 01 Sep 2022 19:39:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTq29-0005ox-5O for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 19:39:25 +0000 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [2607:f8b0:4864:20::112a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c7b8bf51-2a2d-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 21:39:23 +0200 (CEST) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-333a4a5d495so346614687b3.10 for ; Thu, 01 Sep 2022 12:39:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7b8bf51-2a2d-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=rw5PRlxl7tO0yi2f42RcudRuneYpC4HLzAgnvXZWG5E=; b=lG3CtwEra2JQqN/veO23yk3cgaTJHFCiebuuRZY/xNehRm+m0fM4bIsWwBppGA+dxf mGwrLGImeNf4NmD+qiiJAgJrRcvEAfMmmsjPutkxq2y7CzoFE7qGuyTBDkwrYwo0ghp+ DIdTURnQpZf4mS51OcBm4/JauLAis6X1OUJhsFMZ1Eii1uGdRpU21Q08G5BpjTO5hJLN 9L5Fsbu9o5yfqdUojSVuS9kjs1tQfCEVguOYiQkyDJxdrNwv3a8BIeLV7PQsB1938bTI TTsL41uELqXnesIe6dBtowmfUnvD7Y1/Zc9uEXdIILlsmZXFDiVnDH9hCWWOHKwToPd1 MnoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=rw5PRlxl7tO0yi2f42RcudRuneYpC4HLzAgnvXZWG5E=; b=k1kq/6Ac6dggUEeFN31v1idm5YZX14jhEoXCTj+9vFwyPSxELTUoTxqcmj3qs+Tm6J IyMKN+VCUa5PD9MpDTjchoI/vIss2H9Po7SMoiZop0f2FfN2J9MOgQwaFhT1I82A5H4g /N4QzIx4qCzF4qOeCkZWSApZKWLwJonLYkZ26WKyitD5fiVFDjd0/HnEGoCpV36JOmCP wj6qkbhOzkPovPCCTfxmCm9efFHpcYN6LbN+1kl3L+w01JC6ESoxeckRh31hd/hlF39a L1HMQiuDQvcgD4oYPFYbfYXvq2BME+Io9UUYtxYL9FeaY0nljGP1m0TdhELtl40mg3w/ qEQw== X-Gm-Message-State: ACgBeo1SE7TbxLfwRNuZeXtzarobqGsM+8SLmSyrgab0NGVgaLQcPVuc MSaVw9xk5iigxZtuQqXXZUFnT+0l6X/XNrCv3pJCcg== X-Google-Smtp-Source: AA6agR43mbcplTcd3Q6E6SWUR/a0QzgezQxqYw6L8vriq8koQ7chGwVsb4h58VmaT16qZLx9mcJbzjGRj/xFE0GH57Q= X-Received: by 2002:a0d:d850:0:b0:340:d2c0:b022 with SMTP id a77-20020a0dd850000000b00340d2c0b022mr21758237ywe.469.1662061162404; Thu, 01 Sep 2022 12:39:22 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 12:39:11 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Michal Hocko Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > > On Thu 01-09-22 08:33:19, Suren Baghdasaryan wrote: > > On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: > [...] > > > So I find Peter's question completely appropriate while your response to > > > that not so much! Maybe ftrace is not the right tool for the intented > > > job. Maybe there are other ways and it would be really great to show > > > that those have been evaluated and they are not suitable for a), b) and > > > c) reasons. > > > > That's fair. > > For memory tracking I looked into using kmemleak and page_owner which > > can't match the required functionality at an overhead acceptable for > > production and pre-production testing environments. > > Being more specific would be really helpful. Especially when your cover > letter suggests that you rely on page_owner/memcg metadata as well to > match allocation and their freeing parts. kmemleak is known to be slow and it's even documented [1], so I hope I can skip that part. For page_owner to provide the comparable information we would have to capture the call stacks for all page allocations unlike our proposal which allows to do that selectively for specific call sites. I'll post the overhead numbers of call stack capturing once I'm finished with profiling the latest code, hopefully sometime tomorrow, in the worst case after the long weekend. > > > traces + BPF I > > haven't evaluated myself but heard from other members of my team who > > tried using that in production environment with poor results. I'll try > > to get more specific information on that. > > That would be helpful as well. Ack. > > > > E.g. Oscar has been working on extending page_ext to track number of > > > allocations for specific calltrace[1]. Is this 1:1 replacement? No! But > > > it can help in environments where page_ext can be enabled and it is > > > completely non-intrusive to the MM code. > > > > Thanks for pointing out this work. I'll need to review and maybe > > profile it before making any claims. > > > > > > > > If the page_ext overhead is not desirable/acceptable then I am sure > > > there are other options. E.g. kprobes/LivePatching framework can hook > > > into functions and alter their behavior. So why not use that for data > > > collection? Has this been evaluated at all? > > > > I'm not sure how I can hook into say alloc_pages() to find out where > > it was called from without capturing the call stack (which would > > introduce an overhead at every allocation). Would love to discuss this > > or other alternatives if they can be done with low enough overhead. > > Yes, tracking back the call trace would be really needed. The question > is whether this is really prohibitively expensive. How much overhead are > we talking about? There is no free lunch here, really. You either have > the overhead during runtime when the feature is used or on the source > code level for all the future development (with a maze of macros and > wrappers). Will post the overhead numbers soon. What I hear loud and clear is that we need a kernel command-line kill switch that mitigates the overhead for having this feature. That seems to be the main concern. Thanks, Suren. [1] https://docs.kernel.org/dev-tools/kmemleak.html#limitations-and-drawbacks > > Thanks! > -- > Michal Hocko > SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 01 20:10:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 20:10:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396931.637331 (Exim 4.92) (envelope-from ) id 1oTqWD-0001XM-D6; Thu, 01 Sep 2022 20:10:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396931.637331; Thu, 01 Sep 2022 20:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTqWD-0001XF-AX; Thu, 01 Sep 2022 20:10:29 +0000 Received: by outflank-mailman (input) for mailman id 396931; Thu, 01 Sep 2022 20:10:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTqWC-0001X5-4g; Thu, 01 Sep 2022 20:10:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTqWC-0003a6-2I; Thu, 01 Sep 2022 20:10:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTqWB-0000kt-HX; Thu, 01 Sep 2022 20:10:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTqWB-0000pi-H6; Thu, 01 Sep 2022 20:10:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=poZcJmgJ3iAPRaCKOxMky6LQWMBrENL416Hjp0B+jtM=; b=pBOBA14manasVuPg31J2rofNKX 8pt8UYjhK/Pi+gbp/ceEGabjZ79NHGEzlGw/LoXCvQcVD+1+uAMey9sGx+vGAiM+0o2eZ6xwTVb4V PZas2EUfxd8mpWPmW0NabXzKXI0Kszx1CQBlbLIBiZB1U9zWZeVIaTzmAm72oAFJpSag=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172917: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ac55fcb051e4f288d29432043a42c13866419598 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 01 Sep 2022 20:10:27 +0000 flight 172917 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172917/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ac55fcb051e4f288d29432043a42c13866419598 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 220 attempts Testing same since 172917 2022-09-01 15:42:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1425 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 20:15:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 20:15:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396940.637342 (Exim 4.92) (envelope-from ) id 1oTqap-0002Ai-Vm; Thu, 01 Sep 2022 20:15:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396940.637342; Thu, 01 Sep 2022 20:15:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTqap-0002Ab-T4; Thu, 01 Sep 2022 20:15:15 +0000 Received: by outflank-mailman (input) for mailman id 396940; Thu, 01 Sep 2022 20:15:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTqao-0002AV-4V for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 20:15:14 +0000 Received: from out0.migadu.com (out0.migadu.com [2001:41d0:2:267::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c864d6e2-2a32-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 22:15:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c864d6e2-2a32-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 16:15:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662063310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x2NMOlEzDduOKU3OG0hkVY/eZ9DnomVtYyGkujvYMfQ=; b=GZmX8EgKF+NWBO1K6a1hr+nxjuoF/PsDTSLqCo6JDft5Lp2ahwYTTK8b50dG3GDFiyI2oI 2rQSd84i51aF5SiQopFwaT3nCD3wYRAGWS4l2yVMm4bl7qQbXzOmzbG62OdE7XVziv2OfP OhmtcTJVp1MskxwDjbZcipuL7iWFfaI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Suren Baghdasaryan Cc: Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901201502.sn6223bayzwferxv@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 12:39:11PM -0700, Suren Baghdasaryan wrote: > kmemleak is known to be slow and it's even documented [1], so I hope I > can skip that part. For page_owner to provide the comparable > information we would have to capture the call stacks for all page > allocations unlike our proposal which allows to do that selectively > for specific call sites. I'll post the overhead numbers of call stack > capturing once I'm finished with profiling the latest code, hopefully > sometime tomorrow, in the worst case after the long weekend. To expand on this further: we're stashing a pointer to the alloc_tag, which is defined at the allocation callsite. That's how we're able to decrement the proper counter on free, and why this beats any tracing based approach - with tracing you'd instead have to correlate allocate/free events. Ouch. > > Yes, tracking back the call trace would be really needed. The question > > is whether this is really prohibitively expensive. How much overhead are > > we talking about? There is no free lunch here, really. You either have > > the overhead during runtime when the feature is used or on the source > > code level for all the future development (with a maze of macros and > > wrappers). The full call stack is really not what you want in most applications - that's what people think they want at first, and why page_owner works the way it does, but it turns out that then combining all the different but related stack traces _sucks_ (so why were you saving them in the first place?), and then you have to do a separate memory allocate for each stack track, which destroys performance. > > Will post the overhead numbers soon. > What I hear loud and clear is that we need a kernel command-line kill > switch that mitigates the overhead for having this feature. That seems > to be the main concern. > Thanks, After looking at this more I don't think we should commit just yet - there's some tradeoffs to be evaluated, and maybe the thing to do first will be to see if we can cut down on the (huge!) number of allocation interfaces before adding more complexity. The ideal approach, from a performance POV, would be to pass a pointer to the alloc tag to kmalloc() et. all, and then we'd have the actual accounting code in one place and use a jump label to skip over it when this feature is disabled. However, there are _many, many_ wrapper functions in our allocation code, and this approach is going to make the plumbing for the hooks quite a bit bigger than what we have now - and then, do we want to have this extra alloc_tag parameter that's not used when CONFIG_ALLOC_TAGGING=n? It's a tiny cost for an extra unused parameter, but it's a cost - or do we get rid of that with some extra macro hackery (eww, gross)? If we do the boot parameter before submission, I think we'll have something that's maybe not strictly ideal from a performance POV when CONFIG_ALLOC_TAGGING=y but boot parameter=n, but it'll introduce the minimum amount of macro insanity. What we should be able to do pretty easily is discard the alloc_tag structs when the boot parameter is disabled, because they're in special elf sections and we already do that (e.g. for .init). From xen-devel-bounces@lists.xenproject.org Thu Sep 01 21:38:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 21:38:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396949.637354 (Exim 4.92) (envelope-from ) id 1oTrtJ-0001eG-1o; Thu, 01 Sep 2022 21:38:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396949.637354; Thu, 01 Sep 2022 21:38:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTrtI-0001e9-Uy; Thu, 01 Sep 2022 21:38:24 +0000 Received: by outflank-mailman (input) for mailman id 396949; Thu, 01 Sep 2022 21:38:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTrtH-0001e3-9r for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 21:38:23 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65764776-2a3e-11ed-934f-f50d60e1c1bd; Thu, 01 Sep 2022 23:38:20 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBB5561F73; Thu, 1 Sep 2022 21:38:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13146C433D6; Thu, 1 Sep 2022 21:38:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65764776-2a3e-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 17:38:44 -0400 From: Steven Rostedt To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901173844.36e1683c@gandalf.local.home> In-Reply-To: <20220830214919.53220-28-surenb@google.com> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 30 Aug 2022 14:49:16 -0700 Suren Baghdasaryan wrote: > From: Kent Overstreet > > This adds the ability to easily instrument code for measuring latency. > To use, add the following to calls to your code, at the start and end of > the event you wish to measure: > > code_tag_time_stats_start(start_time); > code_tag_time_stats_finish(start_time); So you need to modify the code to see what you want? > > Stastistics will then show up in debugfs under > /sys/kernel/debug/time_stats, listed by file and line number. > > Stastics measured include weighted averages of frequency, duration, max > duration, as well as quantiles. > > This patch also instruments all calls to init_wait and finish_wait, > which includes all calls to wait_event. Example debugfs output: > > fs/xfs/xfs_trans_ail.c:746 module:xfs func:xfs_ail_push_all_sync > count: 17 > rate: 0/sec > frequency: 2 sec > avg duration: 10 us > max duration: 232 us > quantiles (ns): 128 128 128 128 128 128 128 128 128 128 128 128 128 128 128 > > lib/sbitmap.c:813 module:sbitmap func:sbitmap_finish_wait > count: 3 > rate: 0/sec > frequency: 4 sec > avg duration: 4 sec > max duration: 4 sec > quantiles (ns): 0 4288669120 4288669120 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 5360836048 > > net/core/datagram.c:122 module:datagram func:__skb_wait_for_more_packets > count: 10 > rate: 1/sec > frequency: 859 ms > avg duration: 472 ms > max duration: 30 sec > quantiles (ns): 0 12279 12279 15669 15669 15669 15669 17217 17217 17217 17217 17217 17217 17217 17217 For function length you could just do something like this: # cd /sys/kernel/tracing # echo __skb_wait_for_more_packets > set_ftrace_filter # echo 1 > function_profile_enabled # cat trace_stat/function* Function Hit Time Avg s^2 -------- --- ---- --- --- __skb_wait_for_more_packets 1 0.000 us 0.000 us 0.000 us Function Hit Time Avg s^2 -------- --- ---- --- --- __skb_wait_for_more_packets 1 74.813 us 74.813 us 0.000 us Function Hit Time Avg s^2 -------- --- ---- --- --- Function Hit Time Avg s^2 -------- --- ---- --- --- The above is for a 4 CPU machine. The s^2 is the square of the standard deviation (makes not having to do divisions while it runs). But if you are looking for latency between two events (which can be kprobes too, where you do not need to rebuild your kernel): From: https://man.archlinux.org/man/sqlhist.1.en which comes in: https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/ if not already installed on your distro. # sqlhist -e -n wakeup_lat 'select end.next_comm as comm,start.pid,start.prio,(end.TIMESTAMP_USECS - start.TIMESTAMP_USECS) as delta from sched_waking as start join sched_switch as end on start.pid = end.next_pid where start.prio < 100' The above creates a synthetic event called "wakeup_lat" that joins two events (sched_waking and sched_switch) when the pid field of sched_waking matches the next_pid field of sched_switch. When there is a match, it will trigger the wakeup_lat event only if the prio of the sched_waking event is less than 100 (which in the kernel means any real-time task). The wakeup_lat event will record the next_comm (as comm field), the pid of woken task and the time delta in microseconds between the two events. # echo 'hist:keys=comm,prio,delta.buckets=10:sort=delta' > /sys/kernel/tracing/events/synthetic/wakeup_lat/trigger The above starts a histogram tracing the name of the woken task, the priority and the delta (but placing the delta in buckets of size 10, as we do not need to see every latency number). # chrt -f 20 sleep 1 Force something to be woken up that is interesting. # cat /sys/kernel/tracing/events/synthetic/wakeup_lat/hist # event histogram # # trigger info: hist:keys=comm,prio,delta.buckets=10:vals=hitcount:sort=delta.buckets=10:size=2048 [active] # { comm: migration/5 , prio: 0, delta: ~ 10-19 } hitcount: 1 { comm: migration/2 , prio: 0, delta: ~ 10-19 } hitcount: 1 { comm: sleep , prio: 79, delta: ~ 10-19 } hitcount: 1 { comm: migration/7 , prio: 0, delta: ~ 10-19 } hitcount: 1 { comm: migration/4 , prio: 0, delta: ~ 10-19 } hitcount: 1 { comm: migration/6 , prio: 0, delta: ~ 10-19 } hitcount: 1 { comm: migration/1 , prio: 0, delta: ~ 10-19 } hitcount: 2 { comm: migration/0 , prio: 0, delta: ~ 10-19 } hitcount: 1 { comm: migration/2 , prio: 0, delta: ~ 20-29 } hitcount: 1 { comm: migration/0 , prio: 0, delta: ~ 20-29 } hitcount: 1 Totals: Hits: 11 Entries: 10 Dropped: 0 That is a histogram of the wakeup latency of all real time tasks that woke up. Oh, and it does not drop events unless the number of entries is bigger than the size of the count of buckets, which I haven't actually encountered, as there's 2048 buckets. But you can make it bigger with the "size" attribute in the creation of the histogram. -- Steve From xen-devel-bounces@lists.xenproject.org Thu Sep 01 21:46:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 21:46:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396956.637365 (Exim 4.92) (envelope-from ) id 1oTs0k-00035X-SC; Thu, 01 Sep 2022 21:46:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396956.637365; Thu, 01 Sep 2022 21:46:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTs0k-00035Q-Nm; Thu, 01 Sep 2022 21:46:06 +0000 Received: by outflank-mailman (input) for mailman id 396956; Thu, 01 Sep 2022 21:46:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTs0j-00035K-Ln for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 21:46:05 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79641aba-2a3f-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 23:46:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06F9161F70; Thu, 1 Sep 2022 21:46:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58693C433C1; Thu, 1 Sep 2022 21:45:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79641aba-2a3f-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 17:46:27 -0400 From: Steven Rostedt To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901174627.27c7e23d@gandalf.local.home> In-Reply-To: <20220901173844.36e1683c@gandalf.local.home> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Sep 2022 17:38:44 -0400 Steven Rostedt wrote: > # echo 'hist:keys=comm,prio,delta.buckets=10:sort=delta' > /sys/kernel/tracing/events/synthetic/wakeup_lat/trigger The above could almost be done with sqlhist (but I haven't implemented "buckets=10" yet because that's a new feature. But for now, let's do log2): # sqlhist -e 'select comm,prio,cast(delta as log2) from wakeup_lat' ("-e" is to execute the command, as it normally only displays what commands need to be run to create the synthetic events and histograms) # cat /sys/kernel/tracing/events/synthetic/wakeup_lat/hist # event histogram # # trigger info: hist:keys=comm,prio,delta.log2:vals=hitcount:sort=hitcount:size=2048 [active] # { comm: migration/4 , prio: 0, delta: ~ 2^5 } hitcount: 1 { comm: migration/0 , prio: 0, delta: ~ 2^4 } hitcount: 2 { comm: rtkit-daemon , prio: 0, delta: ~ 2^7 } hitcount: 2 { comm: rtkit-daemon , prio: 0, delta: ~ 2^6 } hitcount: 4 { comm: migration/0 , prio: 0, delta: ~ 2^5 } hitcount: 8 { comm: migration/4 , prio: 0, delta: ~ 2^4 } hitcount: 9 { comm: migration/2 , prio: 0, delta: ~ 2^4 } hitcount: 10 { comm: migration/5 , prio: 0, delta: ~ 2^4 } hitcount: 10 { comm: migration/7 , prio: 0, delta: ~ 2^4 } hitcount: 10 { comm: migration/1 , prio: 0, delta: ~ 2^4 } hitcount: 10 { comm: migration/6 , prio: 0, delta: ~ 2^4 } hitcount: 10 Totals: Hits: 76 Entries: 11 Dropped: 0 -- Steve From xen-devel-bounces@lists.xenproject.org Thu Sep 01 21:54:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 21:54:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396965.637376 (Exim 4.92) (envelope-from ) id 1oTs9D-0004YK-NB; Thu, 01 Sep 2022 21:54:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396965.637376; Thu, 01 Sep 2022 21:54:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTs9D-0004YD-KS; Thu, 01 Sep 2022 21:54:51 +0000 Received: by outflank-mailman (input) for mailman id 396965; Thu, 01 Sep 2022 21:54:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTs9B-0004Y7-Br for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 21:54:50 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b20260fb-2a40-11ed-82f2-63bd783d45fa; Thu, 01 Sep 2022 23:54:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b20260fb-2a40-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 17:54:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662069286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cwEaHM2MLzWFSTyYX5D3U7h9xVWN0G5HRpYdRjufwn0=; b=Twh7nBps+XmX0981JwFQK7PMJW17CAHEz4A60UGJ6tfnVJLg6TZy5G0xn6V03JWw5jzP+B 3RE93gZ+MZBUwxCNryz2EldJWBau/or+sfFVuw+2kP1flYXFxRkrg7pE3b74SSfBEB2oWB lummEMiyswsHuVB+uMrViWPiyxSgtyk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901173844.36e1683c@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 05:38:44PM -0400, Steven Rostedt wrote: > On Tue, 30 Aug 2022 14:49:16 -0700 > Suren Baghdasaryan wrote: > > > From: Kent Overstreet > > > > This adds the ability to easily instrument code for measuring latency. > > To use, add the following to calls to your code, at the start and end of > > the event you wish to measure: > > > > code_tag_time_stats_start(start_time); > > code_tag_time_stats_finish(start_time); > > So you need to modify the code to see what you want? Figuring out the _correct_ place to measure is often a significant amount of the total effort. Having done so once, why not annotate that in the source code? > For function length you could just do something like this: > > # cd /sys/kernel/tracing > # echo __skb_wait_for_more_packets > set_ftrace_filter > # echo 1 > function_profile_enabled > # cat trace_stat/function* > Function Hit Time Avg s^2 > -------- --- ---- --- --- > __skb_wait_for_more_packets 1 0.000 us 0.000 us 0.000 us > Function Hit Time Avg s^2 > -------- --- ---- --- --- > __skb_wait_for_more_packets 1 74.813 us 74.813 us 0.000 us > Function Hit Time Avg s^2 > -------- --- ---- --- --- > Function Hit Time Avg s^2 > -------- --- ---- --- --- > > The above is for a 4 CPU machine. The s^2 is the square of the standard > deviation (makes not having to do divisions while it runs). > > But if you are looking for latency between two events (which can be kprobes > too, where you do not need to rebuild your kernel): > > From: https://man.archlinux.org/man/sqlhist.1.en > which comes in: https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/ > if not already installed on your distro. > > # sqlhist -e -n wakeup_lat 'select end.next_comm as comm,start.pid,start.prio,(end.TIMESTAMP_USECS - start.TIMESTAMP_USECS) as delta from sched_waking as start join sched_switch as end on start.pid = end.next_pid where start.prio < 100' > > The above creates a synthetic event called "wakeup_lat" that joins two > events (sched_waking and sched_switch) when the pid field of sched_waking > matches the next_pid field of sched_switch. When there is a match, it will > trigger the wakeup_lat event only if the prio of the sched_waking event is > less than 100 (which in the kernel means any real-time task). The > wakeup_lat event will record the next_comm (as comm field), the pid of > woken task and the time delta in microseconds between the two events. So this looks like it's gotten better since I last looked, but it's still not there yet. Part of the problem is that the tracepoints themselves are in the wrong place: your end event is when a task is woken up, but that means spurious wakeups will cause one wait_event() call to be reported as multiple smaller waits, not one long wait - oops, now I can't actually find the thing that's causing my multi-second delay. Also, in your example you don't have it broken out by callsite. That would be the first thing I'd need for any real world debugging. So, it looks like tracing has made some progress over the past 10 years, but for debugging latency issues it's still not there yet in general. I will definitely remember function latency tracing the next time I'm doing performance work, but I expect that to be far too heavy to enable on a live server. This thing is only a couple hundred lines of code though, so perhaps tracing shouldn't be the only tool in our toolbox :) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 22:30:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 22:30:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396974.637386 (Exim 4.92) (envelope-from ) id 1oTshv-0000LH-H4; Thu, 01 Sep 2022 22:30:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396974.637386; Thu, 01 Sep 2022 22:30:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTshv-0000LA-EQ; Thu, 01 Sep 2022 22:30:43 +0000 Received: by outflank-mailman (input) for mailman id 396974; Thu, 01 Sep 2022 22:30:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTshu-0000L0-9q; Thu, 01 Sep 2022 22:30:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTshu-0005tT-56; Thu, 01 Sep 2022 22:30:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTsht-0000dk-Ov; Thu, 01 Sep 2022 22:30:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTsht-0000Ex-OV; Thu, 01 Sep 2022 22:30:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=r/n7mjhMolTf8AsiGp5nNX0OnPWVFHULOsUSDQ6AxBk=; b=NksrGA/vf5Jm9XsLmjOnvqGCNE 6aaEFrIc9cxwUoq8QB2Ezw5qhSk1mtCkxzr/cwp8w1gNj+4eBK7a7WszQzlbkh3wCq9J9WozUNVzq rVDzAXYRDjMvUIfdL+CQegCOwdjggF/9wKjrgR5iP/WO0R0UuOtqZZ9JRlGdsBQiJcoA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172911: regressions - FAIL X-Osstest-Failures: linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c5e4d5e99162ba8025d58a3af7ad103f155d2df7 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 01 Sep 2022 22:30:41 +0000 flight 172911 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux c5e4d5e99162ba8025d58a3af7ad103f155d2df7 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 28 days Failing since 172152 2022-08-05 04:01:26 Z 27 days 63 attempts Testing same since 172902 2022-08-31 23:12:06 Z 0 days 2 attempts ------------------------------------------------------------ 1599 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 165102 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 22:34:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 22:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396985.637398 (Exim 4.92) (envelope-from ) id 1oTslH-00011W-6J; Thu, 01 Sep 2022 22:34:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396985.637398; Thu, 01 Sep 2022 22:34:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTslH-00011P-3d; Thu, 01 Sep 2022 22:34:11 +0000 Received: by outflank-mailman (input) for mailman id 396985; Thu, 01 Sep 2022 22:34:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTslF-00011I-Nl for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 22:34:09 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2fd40133-2a46-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 00:34:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F34562017; Thu, 1 Sep 2022 22:34:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9A46C433C1; Thu, 1 Sep 2022 22:33:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fd40133-2a46-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 18:34:30 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901183430.120311ce@gandalf.local.home> In-Reply-To: <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Sep 2022 17:54:38 -0400 Kent Overstreet wrote: > > So this looks like it's gotten better since I last looked, but it's still not > there yet. > > Part of the problem is that the tracepoints themselves are in the wrong place: > your end event is when a task is woken up, but that means spurious wakeups will The end event is when a task is scheduled onto the CPU. The start event is the first time it is woken up. > cause one wait_event() call to be reported as multiple smaller waits, not one > long wait - oops, now I can't actually find the thing that's causing my > multi-second delay. > > Also, in your example you don't have it broken out by callsite. That would be > the first thing I'd need for any real world debugging. OK, how about this (currently we can only have 3 keys, but you can create multiple histograms on the same event). # echo 'hist:keys=comm,stacktrace,delta.buckets=10:sort=delta' > /sys/kernel/tracing/events/synthetic/wakeup_lat/trigger (notice the "stacktrace" in the keys) # cat /sys/kernel/tracing/events/synthetic/wakeup_lat/hist # event histogram # # trigger info: hist:keys=comm,stacktrace,delta.buckets=10:vals=hitcount:sort=delta.buckets=10:size=2048 [active] # { comm: migration/2 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: migration/5 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: migration/1 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: migration/7 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: migration/0 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 start_kernel+0x595/0x5be secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: migration/4 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: rtkit-daemon , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 preempt_schedule_common+0x2d/0x70 preempt_schedule_thunk+0x16/0x18 _raw_spin_unlock_irq+0x2e/0x40 eventfd_write+0xc8/0x290 vfs_write+0xc0/0x2a0 ksys_write+0x5f/0xe0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb , delta: ~ 10-19} hitcount: 1 { comm: migration/6 , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 10-19} hitcount: 7 { comm: rtkit-daemon , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 20-29} hitcount: 1 { comm: rtkit-daemon , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 preempt_schedule_common+0x2d/0x70 preempt_schedule_thunk+0x16/0x18 _raw_spin_unlock_irq+0x2e/0x40 eventfd_write+0xc8/0x290 vfs_write+0xc0/0x2a0 ksys_write+0x5f/0xe0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb , delta: ~ 30-39} hitcount: 1 { comm: rtkit-daemon , stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule_idle+0x26/0x40 do_idle+0xb4/0xd0 cpu_startup_entry+0x19/0x20 secondary_startup_64_no_verify+0xc2/0xcb , delta: ~ 40-49} hitcount: 1 Totals: Hits: 53 Entries: 11 Dropped: 0 Not the prettiest thing to read. But hey, we got the full stack of where these latencies happened! Yes, it adds some overhead when the events are triggered due to the stacktrace code, but it's extremely useful information. > > So, it looks like tracing has made some progress over the past 10 years, > but for debugging latency issues it's still not there yet in general. I I call BS on that statement. Just because you do not know what has been added to the kernel in the last 10 years (like you had no idea about seq_buf and that was added in 2014) means to me that you are totally clueless on what tracing can and can not do. It appears to me that you are too focused on inventing your own wheel that does exactly what you want before looking to see how things are today. Just because something didn't fit your needs 10 years ago doesn't mean that it can't fit your needs today. > will definitely remember function latency tracing the next time I'm doing > performance work, but I expect that to be far too heavy to enable on a > live server. I run it on production machines all the time. With the filtering in place it has very little overhead. Mostly in the noise. The best part is that it has practically zero overhead (but can add some cache pressure) when it's off, and can be turned on at run time. The tracing infrastructure is very modular, you can use parts of it that you need, without the overhead of other parts. Like you found out this week that tracepoints are not the same as trace events. Because tracepoints are just a hook in the code that anything can attach to (that's what Daniel's RV work does). Trace events provide the stored data to be recorded. I will note that the current histogram code overhead has increased due to retpolines, but I have code to convert them from indirect calls to direct calls via a switch statement which drops the overhead by 20%! https://lore.kernel.org/all/20220823214606.344269352@goodmis.org/ > > This thing is only a couple hundred lines of code though, so perhaps > tracing shouldn't be the only tool in our toolbox :) I'm already getting complaints from customers/users that are saying there's too many tools in the toolbox already. (Do we use ftrace/perf/bpf?). The idea is to have the tools using mostly the same infrastructure, and not be 100% off on its own, unless there's a clear reason to invent a new wheel that several people are asking for, not just one or two. -- Steve From xen-devel-bounces@lists.xenproject.org Thu Sep 01 22:37:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 22:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396993.637408 (Exim 4.92) (envelope-from ) id 1oTsoV-0001d6-Mb; Thu, 01 Sep 2022 22:37:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396993.637408; Thu, 01 Sep 2022 22:37:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTsoV-0001cz-Ja; Thu, 01 Sep 2022 22:37:31 +0000 Received: by outflank-mailman (input) for mailman id 396993; Thu, 01 Sep 2022 22:37:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTsoV-0001ct-99 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 22:37:31 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8d027da-2a46-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 00:37:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8d027da-2a46-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 18:37:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662071848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V/P7j4Y+xJUBAt6fEYfNoKfACstBZQ8E1OFd7bHElGY=; b=RyUvH2zz81kL6tcYdp2BW6QKmetndFvVS3i7VcCPOcaijLcz0TfOGgBaq909SL/Y1jdlP0 /Retvz17eFHQUiP5AcXQOlPHDOkvuT6UrIyhDdDGO5y36J1883WvsJluGTqXU9etuyqcdH dSwrFVK7mCUuYhH+U9EIxQUe3RmbsW8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Roman Gushchin Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220901223720.e4gudprscjtwltif@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 03:27:27PM -0700, Roman Gushchin wrote: > On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > > This is very interesting work! Do you have any data about the overhead > > this introduces, especially in a production environment? I am > > especially interested in memory allocations tracking and detecting > > leaks. > > +1 > > I think the question whether it indeed can be always turned on in the production > or not is the main one. If not, the advantage over ftrace/bpf/... is not that > obvious. Otherwise it will be indeed a VERY useful thing. Low enough overhead to run in production was my primary design goal. Stats are kept in a struct that's defined at the callsite. So this adds _no_ pointer chasing to the allocation path, unless we've switch to percpu counters at that callsite (see the lazy percpu counters patch), where we need to deref one percpu pointer to save an atomic. Then we need to stash a pointer to the alloc_tag, so that kfree() can find it. For slab allocations this uses the same storage area as memcg, so for allocations that are using that we won't be touching any additional cachelines. (I wanted the pointer to the alloc_tag to be stored inline with the allocation, but that would've caused alignment difficulties). Then there's a pointer deref introduced to the kfree() path, to get back to the original alloc_tag and subtract the allocation from that callsite. That one won't be free, and with percpu counters we've got another dependent load too - hmm, it might be worth benchmarking with just atomics, skipping the percpu counters. So the overhead won't be zero, I expect it'll show up in some synthetic benchmarks, but yes I do definitely expect this to be worth enabling in production in many scenarios. From xen-devel-bounces@lists.xenproject.org Thu Sep 01 22:55:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 22:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397002.637419 (Exim 4.92) (envelope-from ) id 1oTt5q-00041F-7g; Thu, 01 Sep 2022 22:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397002.637419; Thu, 01 Sep 2022 22:55:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTt5q-000418-59; Thu, 01 Sep 2022 22:55:26 +0000 Received: by outflank-mailman (input) for mailman id 397002; Thu, 01 Sep 2022 22:55:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTt5p-000412-2h for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 22:55:25 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29766209-2a49-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 00:55:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29766209-2a49-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 18:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662072922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bm+owKdXaA8Za4y2gNPpxqBECptJMMdY3T6zMUdS1uA=; b=Fj1UwT1LlnomuaYWyJX83g2eH1NGu9VGY3Z1XYuS7iWaeij+fOtjqjeNP5fRtDcipgANPk YblJyNeS8G+qSLk518WRLg7ZbAtUOZTxhs39TzCOzZh/6MJ4QyTPUYlr6G2HzUttGddpDz LgogK35WkmL6KTZCFbHByp017VQO0KE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901225515.ogg7pyljmfzezamr@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> <20220901183430.120311ce@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901183430.120311ce@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 06:34:30PM -0400, Steven Rostedt wrote: > On Thu, 1 Sep 2022 17:54:38 -0400 > Kent Overstreet wrote: > > > > So this looks like it's gotten better since I last looked, but it's still not > > there yet. > > > > Part of the problem is that the tracepoints themselves are in the wrong place: > > your end event is when a task is woken up, but that means spurious wakeups will > > The end event is when a task is scheduled onto the CPU. The start event is > the first time it is woken up. Yeah, that's not what I want. You're just tracing latency due to having more processes runnable than CPUs. I don't care about that for debugging, though! I specifically want latency at the wait_event() level, and related - every time a process blocked _on some condition_, until that condition became true. Not until some random, potentially spurious wakeup. > Not the prettiest thing to read. But hey, we got the full stack of where > these latencies happened! Most of the time I _don't_ want full stacktraces, though! That means I have a ton more output to sort through, and the data is far more expensive to collect. I don't know why it's what people go to first - see the page_owner stuff - but that doesn't get used much either because the output is _really hard to sort through_. Most of the time, just a single file and line number is all you want - and tracing has always made it hard to get at that. > Yes, it adds some overhead when the events are triggered due to the > stacktrace code, but it's extremely useful information. > > > > > So, it looks like tracing has made some progress over the past 10 years, > > but for debugging latency issues it's still not there yet in general. I > > I call BS on that statement. Just because you do not know what has been > added to the kernel in the last 10 years (like you had no idea about > seq_buf and that was added in 2014) means to me that you are totally > clueless on what tracing can and can not do. > > It appears to me that you are too focused on inventing your own wheel that > does exactly what you want before looking to see how things are today. Just > because something didn't fit your needs 10 years ago doesn't mean that it > can't fit your needs today. ...And the ad hominem attacks start. Steve, I'm not attacking you, and there's room enough in this world for the both of us to be doing our thing creating new and useful tools. > I'm already getting complaints from customers/users that are saying there's > too many tools in the toolbox already. (Do we use ftrace/perf/bpf?). The > idea is to have the tools using mostly the same infrastructure, and not be > 100% off on its own, unless there's a clear reason to invent a new wheel > that several people are asking for, not just one or two. I would like to see more focus on usability. That means, in a best case scenario, always-on data collection that I can just look at, and it'll already be in the format most likely to be useful. Surely you can appreciate the usefulness of that..? Tracing started out as a tool for efficiently getting lots of data out of the kernel, and it's great for that. But I think your focus on the cool thing you built may be blinding you a bit to alternative approaches... From xen-devel-bounces@lists.xenproject.org Thu Sep 01 23:00:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 23:00:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397015.637451 (Exim 4.92) (envelope-from ) id 1oTtB6-0005hT-55; Thu, 01 Sep 2022 23:00:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397015.637451; Thu, 01 Sep 2022 23:00:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtB6-0005hJ-1h; Thu, 01 Sep 2022 23:00:52 +0000 Received: by outflank-mailman (input) for mailman id 397015; Thu, 01 Sep 2022 23:00:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtB4-0005h1-Sl; Thu, 01 Sep 2022 23:00:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtB4-0006QH-QO; Thu, 01 Sep 2022 23:00:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtB4-0002vS-D1; Thu, 01 Sep 2022 23:00:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTtB4-0005Fy-Cb; Thu, 01 Sep 2022 23:00:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7Zm7gqMWF/qaUMYTr11oW6qasZrSP4Bd9sYelEnULK8=; b=bxNRJ5sncypgnlKE1eso1dwly8 Oo+vlKl3Nfb+iHUgkZob5XudTSgKVxDN1ni1oIvXAO7NbQPMtW2U9mSJOxmpIZaTLAbI2SDpuJJ+V n+wFO/tbkKeEHJDlTmMHcLz1HF3zc5w6xSv8PdZVwT8wV4AT9hPntT2in+PpKn7EWq3U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 172910: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-credit1:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-xl-cubietruck:xen-boot:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e997d055929665b12246e89eb092dc79c65de9a4 X-Osstest-Versions-That: xen=ace403022358b736755e3042e949540e775c65f1 From: osstest service owner Date: Thu, 01 Sep 2022 23:00:50 +0000 flight 172910 xen-unstable real [real] flight 172920 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172910/ http://logs.test-lab.xenproject.org/osstest/logs/172920/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit1 20 guest-localmigrate/x10 fail pass in 172920-retest test-armhf-armhf-xl-cubietruck 8 xen-boot fail pass in 172920-retest test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 172920-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 172920 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 172920 never pass build-amd64-libvirt 6 libvirt-build fail like 172901 build-i386-libvirt 6 libvirt-build fail like 172901 build-arm64-libvirt 6 libvirt-build fail like 172901 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172901 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172901 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172901 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172901 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172901 build-armhf-libvirt 6 libvirt-build fail like 172901 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172901 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172901 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172901 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172901 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e997d055929665b12246e89eb092dc79c65de9a4 baseline version: xen ace403022358b736755e3042e949540e775c65f1 Last test of basis 172901 2022-08-31 22:08:22 Z 1 days Testing same since 172910 2022-09-01 09:04:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ace4030223..e997d05592 e997d055929665b12246e89eb092dc79c65de9a4 -> master From xen-devel-bounces@lists.xenproject.org Thu Sep 01 23:20:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 23:20:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397032.637470 (Exim 4.92) (envelope-from ) id 1oTtTj-0008Bb-24; Thu, 01 Sep 2022 23:20:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397032.637470; Thu, 01 Sep 2022 23:20:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtTi-0008BU-TE; Thu, 01 Sep 2022 23:20:06 +0000 Received: by outflank-mailman (input) for mailman id 397032; Thu, 01 Sep 2022 23:20:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtTh-0007z6-Qh for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 23:20:05 +0000 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b06fa31-2a4c-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 01:20:03 +0200 (CEST) Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1E25A1C6992; Thu, 1 Sep 2022 23:19:58 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA id A9ECF8000E; Thu, 1 Sep 2022 23:19:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b06fa31-2a4c-11ed-82f2-63bd783d45fa Message-ID: Subject: Re: [RFC PATCH 28/30] Improved symbolic error names From: Joe Perches To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 01 Sep 2022 16:19:35 -0700 In-Reply-To: <20220830214919.53220-29-surenb@google.com> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-29-surenb@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: A9ECF8000E X-Spam-Status: No, score=0.64 X-Stat-Signature: iwqjhu65bfnp7s38he58qcgfcrx3mruu X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18FfjZ7BuRv/DHsUMYX6e6vN/rFvSwIdRQ= X-HE-Tag: 1662074376-819350 On Tue, 2022-08-30 at 14:49 -0700, Suren Baghdasaryan wrote: > From: Kent Overstreet >=20 > This patch adds per-error-site error codes, with error strings that > include their file and line number. >=20 > To use, change code that returns an error, e.g. > return -ENOMEM; > to > return -ERR(ENOMEM); >=20 > Then, errname() will return a string that includes the file and line > number of the ERR() call, for example > printk("Got error %s!\n", errname(err)); > will result in > Got error ENOMEM at foo.c:1234 Why? Something wrong with just using %pe ? printk("Got error %pe at %s:%d!\n", ERR_PTR(err), __FILE__, __LINE__); Likely __FILE__ and __LINE__ aren't particularly useful. And using ERR would add rather a lot of bloat as each codetag_error_code struct would be unique. +#define ERR(_err) \ +({ \ + static struct codetag_error_code \ + __used \ + __section("error_code_tags") \ + __aligned(8) e =3D { \ + .str =3D #_err " at " __FILE__ ":" __stringify(__LINE__),\ + .err =3D _err, \ + }; \ + \ + e.err; \ +}) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 23:22:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 23:22:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397040.637480 (Exim 4.92) (envelope-from ) id 1oTtVu-0000P7-CD; Thu, 01 Sep 2022 23:22:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397040.637480; Thu, 01 Sep 2022 23:22:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtVu-0000P0-9H; Thu, 01 Sep 2022 23:22:22 +0000 Received: by outflank-mailman (input) for mailman id 397040; Thu, 01 Sep 2022 23:22:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtVt-0000Oq-Bj; Thu, 01 Sep 2022 23:22:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtVt-0006le-9t; Thu, 01 Sep 2022 23:22:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtVs-0003ue-Pq; Thu, 01 Sep 2022 23:22:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTtVs-00062Q-PN; Thu, 01 Sep 2022 23:22:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3vc5URye/SXhihq5OSnfcsrB/8aOm81hhBQNPbbMUZc=; b=RW9Pn5C6q4zM9g4jZTljTe9TSr ygfzYBkjFpSRk4l0hCZQ/eSWNET0t3WS3rrCHOWYpfJw8Pj8fzMQOe5FC7/+QcA3vxMLtrY9Ox6IK 8WXOFCiTYEA9Fz00mYh1iEuINlIKiKhh38xk+dygbWpbbp1BNrQcaLbqo9LAsnS8r7TU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172921: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ac55fcb051e4f288d29432043a42c13866419598 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 01 Sep 2022 23:22:20 +0000 flight 172921 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172921/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ac55fcb051e4f288d29432043a42c13866419598 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 221 attempts Testing same since 172917 2022-09-01 15:42:06 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1425 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 23:26:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 23:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397049.637491 (Exim 4.92) (envelope-from ) id 1oTtaJ-00013b-UP; Thu, 01 Sep 2022 23:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397049.637491; Thu, 01 Sep 2022 23:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtaJ-00013U-Ro; Thu, 01 Sep 2022 23:26:55 +0000 Received: by outflank-mailman (input) for mailman id 397049; Thu, 01 Sep 2022 23:26:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtaI-00013O-E0 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 23:26:55 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f41ba37-2a4d-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 01:26:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f41ba37-2a4d-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 19:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662074812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ziQwyv6CBY5n7ARW4qu86GPnvQN6geI/tFyfrLXQmYY=; b=J6csj5dyhB9n57JXIj/oDTNnfDhtPgzehwGStIMJ1Zca26/ME4gYxeDh8PpO+R5AM1uQtx AuGPCBQOLiOURlLPfz0PHN++Qv8oJrHnFRvUJhS53h6Xh9/SgubQ1HLN0ij2EQ6piWu6qx RwYFCEhuRCegC1FPS7XpHSMhorTcjrw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Joe Perches Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 28/30] Improved symbolic error names Message-ID: <20220901232645.4dogffr26oisd7p5@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-29-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 04:19:35PM -0700, Joe Perches wrote: > On Tue, 2022-08-30 at 14:49 -0700, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This patch adds per-error-site error codes, with error strings that > > include their file and line number. > > > > To use, change code that returns an error, e.g. > > return -ENOMEM; > > to > > return -ERR(ENOMEM); > > > > Then, errname() will return a string that includes the file and line > > number of the ERR() call, for example > > printk("Got error %s!\n", errname(err)); > > will result in > > Got error ENOMEM at foo.c:1234 > > Why? Something wrong with just using %pe ? > > printk("Got error %pe at %s:%d!\n", ERR_PTR(err), __FILE__, __LINE__); > > Likely __FILE__ and __LINE__ aren't particularly useful. That doesn't do what this patchset does. If it only did that, it wouldn't make much sense, would it? :) With this patchset, printk("Got error %pe!\n", ptr); prints out a file and line number, but it's _not_ the file/line number of the printk statement - it's the file/line number where the error originated! :) From xen-devel-bounces@lists.xenproject.org Thu Sep 01 23:36:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 01 Sep 2022 23:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397058.637503 (Exim 4.92) (envelope-from ) id 1oTtjj-0002YA-V5; Thu, 01 Sep 2022 23:36:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397058.637503; Thu, 01 Sep 2022 23:36:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtjj-0002Y3-RA; Thu, 01 Sep 2022 23:36:39 +0000 Received: by outflank-mailman (input) for mailman id 397058; Thu, 01 Sep 2022 23:36:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtji-0002Xw-3b for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 23:36:38 +0000 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [2607:f8b0:4864:20::1132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb04535c-2a4e-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 01:36:36 +0200 (CEST) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-324ec5a9e97so2217047b3.7 for ; Thu, 01 Sep 2022 16:36:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb04535c-2a4e-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5pc1SgOf8Owl6sShRuirH1QWrWtPdJIgt3qepozMpkE=; b=QPtBN+jZZjR+fJQ+f+TgwZFy47TE1rR8gr1i8rB6mNu2nigO0JdCAAjMoUMaOVDYnd PiHulcKqQEwjGxjDADddZzXOUg5TYr/Y37FY0mLnlnZh9oqDpuWtb21NiE8K+MvKfMRy 5X2JycO4tSVca0qzV4Yx+TBoNNmpSKbKbCfgMYwA7K5CFp+VszB2v0xi3C2mZ4ZpAFpk VGoNBkpcZXTh7tuDysjYq/uSfLBayYSiQwhTFjGtzTF3WK2rRSdy71A7E9l9S18szgn+ hw0Qy3jClG1SDJCQ3AEQ+kyF5TgjSC7WKM1l7PFAPgZmXyevNIAyCBELnZOO/Zt3zo42 CuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5pc1SgOf8Owl6sShRuirH1QWrWtPdJIgt3qepozMpkE=; b=VzpD6SE0V1cKzN/ZS4PXXZLneBowbWeynVwYyVWmwBt3Oli2XBpUCr8Sx2xbC/4zA2 s/2fCVGtG452EjL5Rv5DdrrfHddF/nE3H99P1En/TzYKzCG4bMb1plF66Vq0Su6dT17U kogypXdftq1FSXK1IfaMGK1b6hari6uXtP+fX9PBRRdtxMfCKSqUCLF9Pxv+D5fiTSzg 82pY6gbFRfa2Tbu0AeKwKFmTW3rrIKz4klPfbmyjjHHKkfZ/c76z60JxEuZy48lVH9zd npmuT3lp7Qw/Ae5DJJRQotCuRPDSrgYwC9wiGveOljSWvOU6VrmRHK4uPnH/ZGOyqcP/ uHjA== X-Gm-Message-State: ACgBeo3Wg5xt7mzCN3w5gVTDwwKbzb4Z1vkNicZmryqJl5YKdoTm4+y/ Kp1D2SczYoLlYeeALNl97HYzrh/PbojThLfPMPVkog== X-Google-Smtp-Source: AA6agR6KXscPx8LI6183+UcafzSZSBU2Me59d4tUPUgAjsDK3Cl3Xie4I9qREIbKygjbUBWHlz0pZa86okKUwdzJLtw= X-Received: by 2002:a0d:c981:0:b0:330:dc03:7387 with SMTP id l123-20020a0dc981000000b00330dc037387mr25216063ywd.380.1662075395130; Thu, 01 Sep 2022 16:36:35 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 16:36:23 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Roman Gushchin Cc: Kent Overstreet , Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 3:54 PM Roman Gushchin wrote: > > On Thu, Sep 01, 2022 at 06:37:20PM -0400, Kent Overstreet wrote: > > On Thu, Sep 01, 2022 at 03:27:27PM -0700, Roman Gushchin wrote: > > > On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > > > > This is very interesting work! Do you have any data about the overhead > > > > this introduces, especially in a production environment? I am > > > > especially interested in memory allocations tracking and detecting > > > > leaks. > > > > > > +1 > > > > > > I think the question whether it indeed can be always turned on in the production > > > or not is the main one. If not, the advantage over ftrace/bpf/... is not that > > > obvious. Otherwise it will be indeed a VERY useful thing. > > > > Low enough overhead to run in production was my primary design goal. > > > > Stats are kept in a struct that's defined at the callsite. So this adds _no_ > > pointer chasing to the allocation path, unless we've switch to percpu counters > > at that callsite (see the lazy percpu counters patch), where we need to deref > > one percpu pointer to save an atomic. > > > > Then we need to stash a pointer to the alloc_tag, so that kfree() can find it. > > For slab allocations this uses the same storage area as memcg, so for > > allocations that are using that we won't be touching any additional cachelines. > > (I wanted the pointer to the alloc_tag to be stored inline with the allocation, > > but that would've caused alignment difficulties). > > > > Then there's a pointer deref introduced to the kfree() path, to get back to the > > original alloc_tag and subtract the allocation from that callsite. That one > > won't be free, and with percpu counters we've got another dependent load too - > > hmm, it might be worth benchmarking with just atomics, skipping the percpu > > counters. > > > > So the overhead won't be zero, I expect it'll show up in some synthetic > > benchmarks, but yes I do definitely expect this to be worth enabling in > > production in many scenarios. > > I'm somewhat sceptical, but I usually am. And in this case I'll be really happy > to be wrong. > > On a bright side, maybe most of the overhead will come from few allocations, > so an option to explicitly exclude them will do the trick. > > I'd suggest to run something like iperf on a fast hardware. And maybe some > io_uring stuff too. These are two places which were historically most sensitive > to the (kernel) memory accounting speed. Thanks for the suggestions, Roman. I'll see how I can get this done. I'll have to find someone with access to fast hardware (Android is not great for that) and backporting the patchset to the supported kernel version. Will do my best. Thanks, Suren. > > Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > From xen-devel-bounces@lists.xenproject.org Fri Sep 02 00:18:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 00:18:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397069.637513 (Exim 4.92) (envelope-from ) id 1oTuNk-0007Ml-4g; Fri, 02 Sep 2022 00:18:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397069.637513; Fri, 02 Sep 2022 00:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuNk-0007Me-1u; Fri, 02 Sep 2022 00:18:00 +0000 Received: by outflank-mailman (input) for mailman id 397069; Fri, 02 Sep 2022 00:17:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuNi-0007MY-8C for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 00:17:58 +0000 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1012f44-2a54-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 02:17:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1012f44-2a54-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 20:17:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662077875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sH0J8UqLRGNNuqRGsl3/vKnq+Ig43rrwpYa6HCIFafY=; b=vjeyKYOOpSC2AFAm4jt7/ryb4LupJNByTeBTeMD2t/Q2AW+B/pFP/7ZiDdyE5cJVTVuMdX ALGyATHTOJUJtqm8qyYMtPK0sO9+YjGsLH/Fx8WaF/0/oH1YBX2k+q7scEmrOk5wkgPIK+ fpiOJqNgjvaRqABW672Bej0dOIxJQbI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Roman Gushchin Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: > I'd suggest to run something like iperf on a fast hardware. And maybe some > io_uring stuff too. These are two places which were historically most sensitive > to the (kernel) memory accounting speed. I'm getting wildly inconsistent results with iperf. io_uring-echo-server and rust_echo_bench gets me: Benchmarking: 127.0.0.1:12345 50 clients, running 512 bytes, 60 sec. Without alloc tagging: 120547 request/sec With: 116748 request/sec https://github.com/frevib/io_uring-echo-server https://github.com/haraldh/rust_echo_bench How's that look to you? Close enough? :) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 00:22:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 00:22:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397076.637525 (Exim 4.92) (envelope-from ) id 1oTuSR-0000Lh-Mv; Fri, 02 Sep 2022 00:22:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397076.637525; Fri, 02 Sep 2022 00:22:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuSR-0000La-JZ; Fri, 02 Sep 2022 00:22:51 +0000 Received: by outflank-mailman (input) for mailman id 397076; Fri, 02 Sep 2022 00:22:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuSR-0000LU-11 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 00:22:51 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f7b3939-2a55-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 02:22:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 800D3B825DB; Fri, 2 Sep 2022 00:22:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C920C433D6; Fri, 2 Sep 2022 00:22:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f7b3939-2a55-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 20:23:11 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901202311.546a53b5@gandalf.local.home> In-Reply-To: <20220901225515.ogg7pyljmfzezamr@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> <20220901183430.120311ce@gandalf.local.home> <20220901225515.ogg7pyljmfzezamr@moria.home.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Sep 2022 18:55:15 -0400 Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 06:34:30PM -0400, Steven Rostedt wrote: > > On Thu, 1 Sep 2022 17:54:38 -0400 > > Kent Overstreet wrote: > > > > > > So this looks like it's gotten better since I last looked, but it's still not > > > there yet. > > > > > > Part of the problem is that the tracepoints themselves are in the wrong place: > > > your end event is when a task is woken up, but that means spurious wakeups will > > > > The end event is when a task is scheduled onto the CPU. The start event is > > the first time it is woken up. > > Yeah, that's not what I want. You're just tracing latency due to having more > processes runnable than CPUs. > > I don't care about that for debugging, though! I specifically want latency at > the wait_event() level, and related - every time a process blocked _on some > condition_, until that condition became true. Not until some random, potentially > spurious wakeup. Ideally this would be better if we could pass the stack trace from one event to the next, but that wouldn't be too hard to implement. It just needs to be done. But anyway: # echo 'p:wait prepare_to_wait_event' > /sys/kernel/tracing/kprobe_events // created an event on prepare_to_wait_event as that's usually called just // before wait event. # sqlhist -e -n wait_sched 'select start.common_pid as pid,(end.TIMESTAMP_USECS - start.TIMESTAMP_USECS) as delta from wait as start join sched_switch as end on start.common_pid = end.prev_pid where end.prev_state & 3' // Create a "wait_sched" event that traces the time between the // prepare_to_wait_event call and the scheduler. Only trigger it if the // schedule happens in the interruptible or uninterruptible states. # sqlhist -e -n wake_sched 'select start.pid,(end.TIMESTAMP_USECS - start.TIMESTAMP_USECS) as delta2 from wait_sched as start join sched_switch as end on start.pid = end.next_pid where start.delta < 50' // Now attach the wait_event to the sched_switch where the task gets // scheduled back in. But we are only going to care if the delta between // the prepare_to_wait_event and the schedule is less that 50us. This is a // hack to just care about where a prepare_to_wait_event was done just before // scheduling out. # echo 'hist:keys=pid,delta2.buckets=10:sort=delta2' > /sys/kernel/tracing/events/synthetic/wake_sched/trigger // Now we are going to look at the deltas that the task was sleeping for an // event. But this just gives pids and deltas. # echo 'hist:keys=pid,stacktrace if delta < 50' >> /sys/kernel/tracing/events/synthetic/wait_sched/trigger // And this is to get the backtraces of where the task was. This is because // the stack trace is not available at the schedule in, because the // sched_switch can only give the stack trace of when a task schedules out. // Again, this is somewhat a hack. # cat /sys/kernel/tracing/events/synthetic/wake_sched/hist # event histogram # # trigger info: hist:keys=pid,delta2.buckets=10:vals=hitcount:sort=delta2.buckets=10:size=2048 [active] # { pid: 2114, delta2: ~ 10-19 } hitcount: 1 { pid: 1389, delta2: ~ 160-169 } hitcount: 1 { pid: 1389, delta2: ~ 660-669 } hitcount: 1 { pid: 1389, delta2: ~ 1020-1029 } hitcount: 1 { pid: 1189, delta2: ~ 500020-500029 } hitcount: 1 { pid: 1189, delta2: ~ 500030-500039 } hitcount: 1 { pid: 1195, delta2: ~ 500030-500039 } hitcount: 2 { pid: 1189, delta2: ~ 500040-500049 } hitcount: 10 { pid: 1193, delta2: ~ 500040-500049 } hitcount: 3 { pid: 1197, delta2: ~ 500040-500049 } hitcount: 3 { pid: 1195, delta2: ~ 500040-500049 } hitcount: 9 { pid: 1190, delta2: ~ 500050-500059 } hitcount: 55 { pid: 1197, delta2: ~ 500050-500059 } hitcount: 51 { pid: 1191, delta2: ~ 500050-500059 } hitcount: 61 { pid: 1198, delta2: ~ 500050-500059 } hitcount: 56 { pid: 1195, delta2: ~ 500050-500059 } hitcount: 48 { pid: 1192, delta2: ~ 500050-500059 } hitcount: 54 { pid: 1194, delta2: ~ 500050-500059 } hitcount: 50 { pid: 1196, delta2: ~ 500050-500059 } hitcount: 57 { pid: 1189, delta2: ~ 500050-500059 } hitcount: 48 { pid: 1193, delta2: ~ 500050-500059 } hitcount: 52 { pid: 1194, delta2: ~ 500060-500069 } hitcount: 12 { pid: 1191, delta2: ~ 500060-500069 } hitcount: 2 { pid: 1190, delta2: ~ 500060-500069 } hitcount: 7 { pid: 1198, delta2: ~ 500060-500069 } hitcount: 9 { pid: 1193, delta2: ~ 500060-500069 } hitcount: 6 { pid: 1196, delta2: ~ 500060-500069 } hitcount: 5 { pid: 1192, delta2: ~ 500060-500069 } hitcount: 9 { pid: 1197, delta2: ~ 500060-500069 } hitcount: 9 { pid: 1195, delta2: ~ 500060-500069 } hitcount: 6 { pid: 1189, delta2: ~ 500060-500069 } hitcount: 6 { pid: 1198, delta2: ~ 500070-500079 } hitcount: 1 { pid: 1192, delta2: ~ 500070-500079 } hitcount: 2 { pid: 1193, delta2: ~ 500070-500079 } hitcount: 3 { pid: 1194, delta2: ~ 500070-500079 } hitcount: 2 { pid: 1191, delta2: ~ 500070-500079 } hitcount: 3 { pid: 1190, delta2: ~ 500070-500079 } hitcount: 1 { pid: 1196, delta2: ~ 500070-500079 } hitcount: 1 { pid: 1193, delta2: ~ 500080-500089 } hitcount: 1 { pid: 1192, delta2: ~ 500080-500089 } hitcount: 1 { pid: 1196, delta2: ~ 500080-500089 } hitcount: 2 { pid: 1194, delta2: ~ 500090-500099 } hitcount: 1 { pid: 1197, delta2: ~ 500090-500099 } hitcount: 1 { pid: 1193, delta2: ~ 500090-500099 } hitcount: 1 { pid: 61, delta2: ~ 503910-503919 } hitcount: 1 { pid: 61, delta2: ~ 503920-503929 } hitcount: 1 { pid: 61, delta2: ~ 503930-503939 } hitcount: 1 { pid: 61, delta2: ~ 503960-503969 } hitcount: 15 { pid: 61, delta2: ~ 503970-503979 } hitcount: 18 { pid: 61, delta2: ~ 503980-503989 } hitcount: 20 { pid: 61, delta2: ~ 504010-504019 } hitcount: 2 { pid: 61, delta2: ~ 504020-504029 } hitcount: 1 { pid: 61, delta2: ~ 504030-504039 } hitcount: 2 { pid: 58, delta2: ~ 43409960-43409969 } hitcount: 1 Totals: Hits: 718 Entries: 54 Dropped: 0 The above is useless without the following: # cat /sys/kernel/tracing/events/synthetic/wait_sched/hist # event histogram # # trigger info: hist:keys=pid:vals=hitcount:__arg_1618_2=pid,__arg_1618_3=common_timestamp.usecs:sort=hitcount:size=2048:clock=global if delta < 10 [active] # { pid: 612 } hitcount: 1 { pid: 889 } hitcount: 2 { pid: 1389 } hitcount: 3 { pid: 58 } hitcount: 3 { pid: 2096 } hitcount: 5 { pid: 61 } hitcount: 145 { pid: 1196 } hitcount: 151 { pid: 1190 } hitcount: 151 { pid: 1198 } hitcount: 153 { pid: 1197 } hitcount: 153 { pid: 1195 } hitcount: 153 { pid: 1194 } hitcount: 153 { pid: 1191 } hitcount: 153 { pid: 1192 } hitcount: 153 { pid: 1189 } hitcount: 153 { pid: 1193 } hitcount: 153 Totals: Hits: 1685 Entries: 16 Dropped: 0 # event histogram # # trigger info: hist:keys=pid,stacktrace:vals=hitcount:sort=hitcount:size=2048 if delta < 10 [active] # { pid: 1389, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 pipe_read+0x318/0x420 new_sync_read+0x18b/0x1a0 vfs_read+0xf5/0x190 ksys_read+0xab/0xe0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 3 { pid: 1189, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 61, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 schedule_timeout+0x88/0x160 kcompactd+0x364/0x3f0 kthread+0x141/0x170 ret_from_fork+0x22/0x30 } hitcount: 28 { pid: 1194, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1197, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1198, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1191, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1196, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1192, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1195, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1190, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 { pid: 1193, stacktrace: event_hist_trigger+0x290/0x2b0 event_triggers_call+0x52/0xe0 trace_event_buffer_commit+0x193/0x240 trace_event_raw_event_sched_switch+0x120/0x180 __traceiter_sched_switch+0x39/0x50 __schedule+0x310/0x700 schedule+0x72/0x110 read_events+0x119/0x190 do_io_getevents+0x72/0xe0 __x64_sys_io_getevents+0x59/0xc0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb } hitcount: 28 Totals: Hits: 311 Entries: 12 Dropped: 0 Now we just need a tool to map the pids of the delta histogram to the pids of the stack traces to figure out where the issues may happen. The above is just to show that there's a lot of infrastructure already there that does a lot of this work, but needs improvement. My theme to this email is to modify what's there to make it work for you before just doing everything from scratch, and then we have a bunch of stuff that only does what we want, but is not flexible to do what others may want. > > > > Not the prettiest thing to read. But hey, we got the full stack of where > > these latencies happened! > > Most of the time I _don't_ want full stacktraces, though! We could easily add a feature to limit how much you want to trace. Perhaps even a skip level. That is, add skip and depth options to the stacktrace field. > > That means I have a ton more output to sort through, and the data is far more > expensive to collect. That's what user space tools are for ;-) > > I don't know why it's what people go to first - see the page_owner stuff - but > that doesn't get used much either because the output is _really hard to sort > through_. > > Most of the time, just a single file and line number is all you want - and > tracing has always made it hard to get at that. Because we would need to store too much dwarf information in the kernel to do so. But user space could do this for you with the function/offset information. > > > > Yes, it adds some overhead when the events are triggered due to the > > stacktrace code, but it's extremely useful information. > > > > > > > > So, it looks like tracing has made some progress over the past 10 > > > years, but for debugging latency issues it's still not there yet in > > > general. I > > > > I call BS on that statement. Just because you do not know what has been > > added to the kernel in the last 10 years (like you had no idea about > > seq_buf and that was added in 2014) means to me that you are totally > > clueless on what tracing can and can not do. > > > > It appears to me that you are too focused on inventing your own wheel > > that does exactly what you want before looking to see how things are > > today. Just because something didn't fit your needs 10 years ago > > doesn't mean that it can't fit your needs today. > > ...And the ad hominem attacks start. Look, you keep making comments about the tracing infrastructure that you clearly do not understand. And that is pretty insulting. Sorry, I'm not sure you realize this, but those comments do turn people off and their responses will start to become stronger. > > Steve, I'm not attacking you, and there's room enough in this world for > the both of us to be doing our thing creating new and useful tools. You seem to push back hard when people suggest improving other utilities to suite your needs. > > > I'm already getting complaints from customers/users that are saying > > there's too many tools in the toolbox already. (Do we use > > ftrace/perf/bpf?). The idea is to have the tools using mostly the same > > infrastructure, and not be 100% off on its own, unless there's a clear > > reason to invent a new wheel that several people are asking for, not > > just one or two. > > I would like to see more focus on usability. Then lets make the current tools more usable. For example, the synthetic event kernel interface is horrible. It's an awesome feature that wasn't getting used due to the interface. This is why I created "sqlhist". It's now really easy to create synthetic events with that tool. I agree, focus on usability, but that doesn't always mean to create yet another tool. This reminds me of: https://xkcd.com/927/ > > That means, in a best case scenario, always-on data collection that I can > just look at, and it'll already be in the format most likely to be useful. > > Surely you can appreciate the usefulness of that..? I find "runtime turn on and off" better than "always on". We have static_branches today (aka jump labels). I would strongly suggest using them. You get them automatically from tracepoints . Even sched_stats are using these. > > Tracing started out as a tool for efficiently getting lots of data out of > the kernel, and it's great for that. But I think your focus on the cool > thing you built may be blinding you a bit to alternative approaches... I actually work hard to have the tracing infrastructure help out other approaches. perf and bpf use the ftrace infrastructure because it is designed to be modular. Nothing is "must be the ftrace way". I'm not against the new features you are adding, I just want you to make a little more effort in incorporating other infrastructures (and perhaps even improving that infrastructure) to suite your needs. If ftrace, perf, bpf can't do what you want, take a harder look to see if you can modify them to do so. -- Steve From xen-devel-bounces@lists.xenproject.org Fri Sep 02 00:23:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 00:23:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397085.637536 (Exim 4.92) (envelope-from ) id 1oTuTT-0000z9-57; Fri, 02 Sep 2022 00:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397085.637536; Fri, 02 Sep 2022 00:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuTT-0000z2-1X; Fri, 02 Sep 2022 00:23:55 +0000 Received: by outflank-mailman (input) for mailman id 397085; Fri, 02 Sep 2022 00:23:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuTR-0000yo-Cg for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 00:23:53 +0000 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [2607:f8b0:4864:20::b35]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84ecc83c-2a55-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 02:23:51 +0200 (CEST) Received: by mail-yb1-xb35.google.com with SMTP id e71so1040588ybh.9 for ; Thu, 01 Sep 2022 17:23:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84ecc83c-2a55-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=id/aU8twWVdV/Bsd/keLwAwE0+9+WzWIEZXVP3pbEN4=; b=G77qRohbCf8ac6L53jHN3bFU7PgUEL71xjRWrIRgmeioghpD0xzX3e0zi4p0Fjggdn KjTBdwkI1TuEZqbucWCkkW7b1W0zxO+VI5WfbrrTQxHWUgyA/tZnHLigSv/8NMdA/UI9 yIjZAiamvzjrepwHMz84VsWYmIN8e95FQxmPSo2qVVXspBAp75MmSrl9SPfSax4OI1C5 PKItbP+9xOmOhns90JGgekip/c4JyrWAYahbl7YRg91JgJ4DyXgvl2Iq86+UvWfYoNpM 0HV40naa8DroB19VETMd6C9gCjGoRmVPMuQwaMkdGp39fuTpS4NZhEPHnxCbapfqWUu+ Fo7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=id/aU8twWVdV/Bsd/keLwAwE0+9+WzWIEZXVP3pbEN4=; b=rywd9jIEM93NXPSUIJLK/QU1PjwyB8o6xhwJzL16M/z92ib+FLtfxECiRVIA/RpBzp uIr+GPYZI8rOLEXUJgqCo5oqGSgbuDQkO1oTuQaoJlAgTXgx0I4IRVlgTNvCq2KYHvZG +RYeOLp9C7QALnZvW1r5IC1HejGr31rPymagTc+UoZyz79i7w4cgdjvjmpizJ7wsE5/4 M+yfoX0q6BGC44txoc8hLX6Gh2a52tEK4grKH9hkHRbVYd38NSy3K+wXgUCagK1qPdvK CtAOpHOX5JgHjcuawzHaUIl234CDU8f9k4f2ovlQ5N6oUKxeI4M+B4x6MRMa3xXCtsXe l1aQ== X-Gm-Message-State: ACgBeo2zflCqkdHUxLROPP6JPm7w5kJnvsMQuA7rXh0P/K+iikFIvOpx UpQiKQeJ9+EXmS4R8x4WVBy1o9ZAF6aQUBqOw1R3XA== X-Google-Smtp-Source: AA6agR5khWcO1/mtBhCc+HnfsiiSZLMl2asMoj9dgrUfQVN7m8KeXcw0+VssAiP7SGLxfjEJG+/wwoOKBUTZXwGYJ8Y= X-Received: by 2002:a05:6902:1366:b0:691:4335:455b with SMTP id bt6-20020a056902136600b006914335455bmr20559494ybb.282.1662078230135; Thu, 01 Sep 2022 17:23:50 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-12-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 17:23:38 -0700 Message-ID: Subject: Re: [RFC PATCH 11/30] mm: introduce slabobj_ext to support slab object extensions To: Roman Gushchin Cc: Andrew Morton , Kent Overstreet , Michal Hocko , Vlastimil Babka , Johannes Weiner , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Peter Zijlstra , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 4:36 PM Roman Gushchin wrote: > > On Tue, Aug 30, 2022 at 02:49:00PM -0700, Suren Baghdasaryan wrote: > > Currently slab pages can store only vectors of obj_cgroup pointers in > > page->memcg_data. Introduce slabobj_ext structure to allow more data > > to be stored for each slab object. Wraps obj_cgroup into slabobj_ext > > to support current functionality while allowing to extend slabobj_ext > > in the future. > > > > Note: ideally the config dependency should be turned the other way around: > > MEMCG should depend on SLAB_OBJ_EXT and {page|slab|folio}.memcg_data would > > be renamed to something like {page|slab|folio}.objext_data. However doing > > this in RFC would introduce considerable churn unrelated to the overall > > idea, so avoiding this until v1. > > Hi Suren! Hi Roman, > > I'd say CONFIG_MEMCG_KMEM and CONFIG_YOUR_NEW_STUFF should both depend on > SLAB_OBJ_EXT. > CONFIG_MEMCG_KMEM depend on CONFIG_MEMCG anyway. Yes, I agree. I wanted to mention here that the current dependency is incorrect and should be reworked. Having both depending on SLAB_OBJ_EXT seems like the right approach. > > > > > Signed-off-by: Suren Baghdasaryan > > --- > > include/linux/memcontrol.h | 18 ++++-- > > init/Kconfig | 5 ++ > > mm/kfence/core.c | 2 +- > > mm/memcontrol.c | 60 ++++++++++--------- > > mm/page_owner.c | 2 +- > > mm/slab.h | 119 +++++++++++++++++++++++++------------ > > 6 files changed, 131 insertions(+), 75 deletions(-) > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > index 6257867fbf95..315399f77173 100644 > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -227,6 +227,14 @@ struct obj_cgroup { > > }; > > }; > > > > +/* > > + * Extended information for slab objects stored as an array in page->memcg_data > > + * if MEMCG_DATA_OBJEXTS is set. > > + */ > > +struct slabobj_ext { > > + struct obj_cgroup *objcg; > > +} __aligned(8); > > Why do we need this aligment requirement? To save space by avoiding padding, however, all members today will be pointers, so it's meaningless and we can safely drop it. > > > + > > /* > > * The memory controller data structure. The memory controller controls both > > * page cache and RSS per cgroup. We would eventually like to provide > > @@ -363,7 +371,7 @@ extern struct mem_cgroup *root_mem_cgroup; > > > > enum page_memcg_data_flags { > > /* page->memcg_data is a pointer to an objcgs vector */ > > - MEMCG_DATA_OBJCGS = (1UL << 0), > > + MEMCG_DATA_OBJEXTS = (1UL << 0), > > /* page has been accounted as a non-slab kernel page */ > > MEMCG_DATA_KMEM = (1UL << 1), > > /* the next bit after the last actual flag */ > > @@ -401,7 +409,7 @@ static inline struct mem_cgroup *__folio_memcg(struct folio *folio) > > unsigned long memcg_data = folio->memcg_data; > > > > VM_BUG_ON_FOLIO(folio_test_slab(folio), folio); > > - VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJCGS, folio); > > + VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJEXTS, folio); > > VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_KMEM, folio); > > > > return (struct mem_cgroup *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > > @@ -422,7 +430,7 @@ static inline struct obj_cgroup *__folio_objcg(struct folio *folio) > > unsigned long memcg_data = folio->memcg_data; > > > > VM_BUG_ON_FOLIO(folio_test_slab(folio), folio); > > - VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJCGS, folio); > > + VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJEXTS, folio); > > VM_BUG_ON_FOLIO(!(memcg_data & MEMCG_DATA_KMEM), folio); > > > > return (struct obj_cgroup *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > > @@ -517,7 +525,7 @@ static inline struct mem_cgroup *page_memcg_check(struct page *page) > > */ > > unsigned long memcg_data = READ_ONCE(page->memcg_data); > > > > - if (memcg_data & MEMCG_DATA_OBJCGS) > > + if (memcg_data & MEMCG_DATA_OBJEXTS) > > return NULL; > > > > if (memcg_data & MEMCG_DATA_KMEM) { > > @@ -556,7 +564,7 @@ static inline struct mem_cgroup *get_mem_cgroup_from_objcg(struct obj_cgroup *ob > > static inline bool folio_memcg_kmem(struct folio *folio) > > { > > VM_BUG_ON_PGFLAGS(PageTail(&folio->page), &folio->page); > > - VM_BUG_ON_FOLIO(folio->memcg_data & MEMCG_DATA_OBJCGS, folio); > > + VM_BUG_ON_FOLIO(folio->memcg_data & MEMCG_DATA_OBJEXTS, folio); > > return folio->memcg_data & MEMCG_DATA_KMEM; > > } > > > > diff --git a/init/Kconfig b/init/Kconfig > > index 532362fcfe31..82396d7a2717 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -958,6 +958,10 @@ config MEMCG > > help > > Provides control over the memory footprint of tasks in a cgroup. > > > > +config SLAB_OBJ_EXT > > + bool > > + depends on MEMCG > > + > > config MEMCG_SWAP > > bool > > depends on MEMCG && SWAP > > @@ -966,6 +970,7 @@ config MEMCG_SWAP > > config MEMCG_KMEM > > bool > > depends on MEMCG && !SLOB > > + select SLAB_OBJ_EXT > > default y > > > > config BLK_CGROUP > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > > index c252081b11df..c0958e4a32e2 100644 > > --- a/mm/kfence/core.c > > +++ b/mm/kfence/core.c > > @@ -569,7 +569,7 @@ static unsigned long kfence_init_pool(void) > > __folio_set_slab(slab_folio(slab)); > > #ifdef CONFIG_MEMCG > > slab->memcg_data = (unsigned long)&kfence_metadata[i / 2 - 1].objcg | > > - MEMCG_DATA_OBJCGS; > > + MEMCG_DATA_OBJEXTS; > > #endif > > } > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index b69979c9ced5..3f407ef2f3f1 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2793,7 +2793,7 @@ static void commit_charge(struct folio *folio, struct mem_cgroup *memcg) > > folio->memcg_data = (unsigned long)memcg; > > } > > > > -#ifdef CONFIG_MEMCG_KMEM > > +#ifdef CONFIG_SLAB_OBJ_EXT > > /* > > * The allocated objcg pointers array is not accounted directly. > > * Moreover, it should not come from DMA buffer and is not readily > > @@ -2801,38 +2801,20 @@ static void commit_charge(struct folio *folio, struct mem_cgroup *memcg) > > */ > > #define OBJCGS_CLEAR_MASK (__GFP_DMA | __GFP_RECLAIMABLE | __GFP_ACCOUNT) > > > > -/* > > - * mod_objcg_mlstate() may be called with irq enabled, so > > - * mod_memcg_lruvec_state() should be used. > > - */ > > -static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > > - struct pglist_data *pgdat, > > - enum node_stat_item idx, int nr) > > -{ > > - struct mem_cgroup *memcg; > > - struct lruvec *lruvec; > > - > > - rcu_read_lock(); > > - memcg = obj_cgroup_memcg(objcg); > > - lruvec = mem_cgroup_lruvec(memcg, pgdat); > > - mod_memcg_lruvec_state(lruvec, idx, nr); > > - rcu_read_unlock(); > > -} > > - > > -int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > > - gfp_t gfp, bool new_slab) > > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > > + gfp_t gfp, bool new_slab) > > { > > unsigned int objects = objs_per_slab(s, slab); > > unsigned long memcg_data; > > void *vec; > > > > gfp &= ~OBJCGS_CLEAR_MASK; > > - vec = kcalloc_node(objects, sizeof(struct obj_cgroup *), gfp, > > + vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > > slab_nid(slab)); > > if (!vec) > > return -ENOMEM; > > > > - memcg_data = (unsigned long) vec | MEMCG_DATA_OBJCGS; > > + memcg_data = (unsigned long) vec | MEMCG_DATA_OBJEXTS; > > if (new_slab) { > > /* > > * If the slab is brand new and nobody can yet access its > > @@ -2843,7 +2825,7 @@ int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > > } else if (cmpxchg(&slab->memcg_data, 0, memcg_data)) { > > /* > > * If the slab is already in use, somebody can allocate and > > - * assign obj_cgroups in parallel. In this case the existing > > + * assign slabobj_exts in parallel. In this case the existing > > * objcg vector should be reused. > > */ > > kfree(vec); > > @@ -2853,6 +2835,26 @@ int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > > kmemleak_not_leak(vec); > > return 0; > > } > > +#endif /* CONFIG_SLAB_OBJ_EXT */ > > + > > +#ifdef CONFIG_MEMCG_KMEM > > +/* > > + * mod_objcg_mlstate() may be called with irq enabled, so > > + * mod_memcg_lruvec_state() should be used. > > + */ > > +static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > > + struct pglist_data *pgdat, > > + enum node_stat_item idx, int nr) > > +{ > > + struct mem_cgroup *memcg; > > + struct lruvec *lruvec; > > + > > + rcu_read_lock(); > > + memcg = obj_cgroup_memcg(objcg); > > + lruvec = mem_cgroup_lruvec(memcg, pgdat); > > + mod_memcg_lruvec_state(lruvec, idx, nr); > > + rcu_read_unlock(); > > +} > > > > static __always_inline > > struct mem_cgroup *mem_cgroup_from_obj_folio(struct folio *folio, void *p) > > @@ -2863,18 +2865,18 @@ struct mem_cgroup *mem_cgroup_from_obj_folio(struct folio *folio, void *p) > > * slab->memcg_data. > > */ > > if (folio_test_slab(folio)) { > > - struct obj_cgroup **objcgs; > > + struct slabobj_ext *obj_exts; > > struct slab *slab; > > unsigned int off; > > > > slab = folio_slab(folio); > > - objcgs = slab_objcgs(slab); > > - if (!objcgs) > > + obj_exts = slab_obj_exts(slab); > > + if (!obj_exts) > > return NULL; > > > > off = obj_to_index(slab->slab_cache, slab, p); > > - if (objcgs[off]) > > - return obj_cgroup_memcg(objcgs[off]); > > + if (obj_exts[off].objcg) > > + return obj_cgroup_memcg(obj_exts[off].objcg); > > > > return NULL; > > } > > diff --git a/mm/page_owner.c b/mm/page_owner.c > > index e4c6f3f1695b..fd4af1ad34b8 100644 > > --- a/mm/page_owner.c > > +++ b/mm/page_owner.c > > @@ -353,7 +353,7 @@ static inline int print_page_owner_memcg(char *kbuf, size_t count, int ret, > > if (!memcg_data) > > goto out_unlock; > > > > - if (memcg_data & MEMCG_DATA_OBJCGS) > > + if (memcg_data & MEMCG_DATA_OBJEXTS) > > ret += scnprintf(kbuf + ret, count - ret, > > "Slab cache page\n"); > > > > diff --git a/mm/slab.h b/mm/slab.h > > index 4ec82bec15ec..c767ce3f0fe2 100644 > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -422,36 +422,94 @@ static inline bool kmem_cache_debug_flags(struct kmem_cache *s, slab_flags_t fla > > return false; > > } > > > > +#ifdef CONFIG_SLAB_OBJ_EXT > > + > > +static inline bool is_kmem_only_obj_ext(void) > > +{ > > #ifdef CONFIG_MEMCG_KMEM > > + return sizeof(struct slabobj_ext) == sizeof(struct obj_cgroup *); > > +#else > > + return false; > > +#endif > > +} > > + > > /* > > - * slab_objcgs - get the object cgroups vector associated with a slab > > + * slab_obj_exts - get the pointer to the slab object extension vector > > + * associated with a slab. > > * @slab: a pointer to the slab struct > > * > > - * Returns a pointer to the object cgroups vector associated with the slab, > > + * Returns a pointer to the object extension vector associated with the slab, > > * or NULL if no such vector has been associated yet. > > */ > > -static inline struct obj_cgroup **slab_objcgs(struct slab *slab) > > +static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > > { > > unsigned long memcg_data = READ_ONCE(slab->memcg_data); > > > > - VM_BUG_ON_PAGE(memcg_data && !(memcg_data & MEMCG_DATA_OBJCGS), > > + VM_BUG_ON_PAGE(memcg_data && !(memcg_data & MEMCG_DATA_OBJEXTS), > > slab_page(slab)); > > VM_BUG_ON_PAGE(memcg_data & MEMCG_DATA_KMEM, slab_page(slab)); > > > > - return (struct obj_cgroup **)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > > + return (struct slabobj_ext *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > > } > > > > -int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > > - gfp_t gfp, bool new_slab); > > -void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, > > - enum node_stat_item idx, int nr); > > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > > + gfp_t gfp, bool new_slab); > > > > -static inline void memcg_free_slab_cgroups(struct slab *slab) > > +static inline void free_slab_obj_exts(struct slab *slab) > > { > > - kfree(slab_objcgs(slab)); > > + struct slabobj_ext *obj_exts; > > + > > + if (!memcg_kmem_enabled() && is_kmem_only_obj_ext()) > > + return; > > Hm, not sure I understand this. I kmem is disabled and is_kmem_only_obj_ext() > is true, shouldn't slab->memcg_data == NULL (always)? So, the logic was to skip freeing when the only possible objects in slab->memcg_data are "struct obj_cgroup" and kmem is disabled. Otherwise there are other objects stored in slab->memcg_data which have to be freed. Did I make it more complicated than it should have been? > > > + > > + obj_exts = slab_obj_exts(slab); > > + kfree(obj_exts); > > slab->memcg_data = 0; > > } > > > > +static inline void prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > > +{ > > + struct slab *slab; > > + > > + /* If kmem is the only extension then the vector will be created conditionally */ > > + if (is_kmem_only_obj_ext()) > > + return; > > + > > + slab = virt_to_slab(p); > > + if (!slab_obj_exts(slab)) > > + WARN(alloc_slab_obj_exts(slab, s, flags, false), > > + "%s, %s: Failed to create slab extension vector!\n", > > + __func__, s->name); > > +} > > This looks a bit crypric: the action is wrapped into WARN() and the rest is a set > of (semi-)static checks. Can we, please, invert it? E.g. something like: > > if (slab_alloc_tracking_enabled()) { > slab = virt_to_slab(p); > if (!slab_obj_exts(slab)) > WARN(alloc_slab_obj_exts(slab, s, flags, false), > "%s, %s: Failed to create slab extension vector!\n", > __func__, s->name); > } Yeah, this is much more readable. Thanks for the suggestion and for reviewing the code! > > The rest looks good to me. > > Thank you! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > From xen-devel-bounces@lists.xenproject.org Fri Sep 02 00:24:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 00:24:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397092.637546 (Exim 4.92) (envelope-from ) id 1oTuUQ-0001YN-EM; Fri, 02 Sep 2022 00:24:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397092.637546; Fri, 02 Sep 2022 00:24:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuUQ-0001YG-BF; Fri, 02 Sep 2022 00:24:54 +0000 Received: by outflank-mailman (input) for mailman id 397092; Fri, 02 Sep 2022 00:24:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTuUP-0001IP-Bm for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 00:24:53 +0000 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [2607:f8b0:4864:20::b33]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a953c43d-2a55-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 02:24:52 +0200 (CEST) Received: by mail-yb1-xb33.google.com with SMTP id t184so1074471yba.4 for ; Thu, 01 Sep 2022 17:24:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a953c43d-2a55-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=/pPOPbPw8AnpH29BUzSqTrm5ZvDmaEgEyFxuBQlNiEg=; b=JFydOg9QoPX5QvCMFfTX+qzkxy7dX+yug3qLsycd8X5fIiKliNhG2sOdd7n2FZxg0x wlIQ0PSe2w+jF1eYJALDSn9VwIQg7e+fojjEXzmIOWtowrPcZ8vVaDgvGlc5viuLzbLq BuWwUYh3dJTjnuDVzKYwlUlnzQN1dlqhuf8e4UUJj0Gz3yVOw7ZhtZlACThcN+JogWbQ XLiaLX50zBOT8vT4sikyfQhvA5G9n7Ys1zkULvj3Bu6V7OPgO3m2SYNlgkEGLVgRXA6S YaT8WKnNiPs7HVTvCKPZfxYMJ9fk0eCfVfQjSQqADIJwkH1wr6+8aSYndPr9n1G1vqpS RvLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=/pPOPbPw8AnpH29BUzSqTrm5ZvDmaEgEyFxuBQlNiEg=; b=kp+FNkgJ9PFnS65CFTvjjoxAWYNclUBcMTSFeSp1p7SmNu6sczO+sIoxoDF7AyoQUu 91GSrXpYHSrincWtGYQVuAZ/AXZUbrJseenVD+NcGYZZGsZLaOl05XGFzr/UJXauhZxl Ys2jkeilJgRVXIEi7tNDR3ASWjP5fjyES9xfNs0DTbRLEfcXFgRlT/g7jocjuEUoqD+w odwgPNVfq5V+Hndp2GRMv3moakBebdZd8LHzQqVSfrVienJmwcwSUBCFmwopOGqxBnct M9oaO8m4iDiFihi15q45k1luf7rgFEmQSLU7yBC/M5O5Ql31yh9goN0Fb9um9zAfB4gX NkOw== X-Gm-Message-State: ACgBeo360X8wNoXvfICqS9YzcJP9A7WBiUTVTqFhqJxBbLWIvmSd3gcd Ihyatl5dI5WzGb4wgu0Hq1tQ1jmCkbCl1ukeernuCA== X-Google-Smtp-Source: AA6agR5/Ulv2F+QXTz0x1dcq0Ynnhj3rjvCeoD8VrxwV966KDu/pwW+2XwncQnNg3JY46QNFp+MHM1SP5XYuAvh7JKU= X-Received: by 2002:a05:6902:705:b0:695:b3b9:41bc with SMTP id k5-20020a056902070500b00695b3b941bcmr21283555ybt.426.1662078291363; Thu, 01 Sep 2022 17:24:51 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-15-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 17:24:40 -0700 Message-ID: Subject: Re: [RFC PATCH 14/30] mm: prevent slabobj_ext allocations for slabobj_ext and kmem_cache objects To: Roman Gushchin Cc: Andrew Morton , Kent Overstreet , Michal Hocko , Vlastimil Babka , Johannes Weiner , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Peter Zijlstra , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 4:41 PM Roman Gushchin wrote: > > On Tue, Aug 30, 2022 at 02:49:03PM -0700, Suren Baghdasaryan wrote: > > Use __GFP_NO_OBJ_EXT to prevent recursions when allocating slabobj_ext > > objects. Also prevent slabobj_ext allocations for kmem_cache objects. > > > > Signed-off-by: Suren Baghdasaryan > > Patches 12-14 look good to me. > It's probably to early to ack anything, but otherwise I'd ack them. Thank you for reviewing! > > Thanks! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397102.637558 (Exim 4.92) (envelope-from ) id 1oTv7Q-0006NV-Eh; Fri, 02 Sep 2022 01:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397102.637558; Fri, 02 Sep 2022 01:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTv7Q-0006NO-BG; Fri, 02 Sep 2022 01:05:12 +0000 Received: by outflank-mailman (input) for mailman id 397102; Fri, 02 Sep 2022 01:05:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTv7O-0006ND-A5; Fri, 02 Sep 2022 01:05:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTv7O-0001Eh-6T; Fri, 02 Sep 2022 01:05:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTv7N-0000wh-NP; Fri, 02 Sep 2022 01:05:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTv7N-0002zL-Mz; Fri, 02 Sep 2022 01:05:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0iHlogMV8UStoyslmtDrSGwpLHF9KiYNxhBnx0cMjI4=; b=i9TPey/48w1McIUE5VFUUWVOJ1 pUFd1eNtwvx5TiTxI/okNI8IFDeyfI6iHpCmxQk2xtMlmxKXpcA7VqEFEDU6UerhFwV0HpisrVhTE RlUkpMydfUxQsonFbIVh/3D9Nxq649haBujk2//TnASbex0l0vXLIVCl4vOcKDcok0fI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172914: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 02 Sep 2022 01:05:09 +0000 flight 172914 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172914/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 28 days Failing since 172384 2022-08-11 11:13:58 Z 21 days 45 attempts Testing same since 172776 2022-08-25 17:42:45 Z 7 days 16 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:16:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397113.637569 (Exim 4.92) (envelope-from ) id 1oTvIg-0007xG-K2; Fri, 02 Sep 2022 01:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397113.637569; Fri, 02 Sep 2022 01:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvIg-0007x9-H4; Fri, 02 Sep 2022 01:16:50 +0000 Received: by outflank-mailman (input) for mailman id 397113; Fri, 02 Sep 2022 01:16:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvIg-0007x3-0k for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:16:50 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea7a9721-2a5c-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 03:16:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea7a9721-2a5c-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 21:16:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662081407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+xwXm91t+47a+o+KD4FaRYzGqxlSaFanxZJX5xkrYrg=; b=xsMsILmjqxTsI8lWiS7DfvRsp699r7C6pWAO1kpANh9Dd5kioDtTINzKWhdVLjDokWmIue khYroBOFRpz/xNfthiK8dz+o9DocHo37OhMVSPh9dAetpd8HbpqXWoVnCTLgv27Mk+8wmE E6KlSHZFuPjRXjBTRPZPVQLJNKBMmZU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Roman Gushchin Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220902011634.6yfeujhzopepspm4@moria.home.lan> References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 06:04:46PM -0700, Roman Gushchin wrote: > On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: > > On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: > > > I'd suggest to run something like iperf on a fast hardware. And maybe some > > > io_uring stuff too. These are two places which were historically most sensitive > > > to the (kernel) memory accounting speed. > > > > I'm getting wildly inconsistent results with iperf. > > > > io_uring-echo-server and rust_echo_bench gets me: > > Benchmarking: 127.0.0.1:12345 > > 50 clients, running 512 bytes, 60 sec. > > > > Without alloc tagging: 120547 request/sec > > With: 116748 request/sec > > > > https://github.com/frevib/io_uring-echo-server > > https://github.com/haraldh/rust_echo_bench > > > > How's that look to you? Close enough? :) > > Yes, this looks good (a bit too good). Eh, I was hoping for better :) > I'm not that familiar with io_uring, Jens and Pavel should have a better idea > what and how to run (I know they've workarounded the kernel memory accounting > because of the performance in the past, this is why I suspect it might be an > issue here as well). > > This is a recent optimization on the networking side: > https://lore.kernel.org/linux-mm/20220825000506.239406-1-shakeelb@google.com/ > > Maybe you can try to repeat this experiment. I'd be more interested in a synthetic benchmark, if you know of any. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:29:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:29:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397120.637580 (Exim 4.92) (envelope-from ) id 1oTvUa-00012p-Ns; Fri, 02 Sep 2022 01:29:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397120.637580; Fri, 02 Sep 2022 01:29:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvUa-00012i-L9; Fri, 02 Sep 2022 01:29:08 +0000 Received: by outflank-mailman (input) for mailman id 397120; Fri, 02 Sep 2022 01:29:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvUZ-00012Z-4N for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:29:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0411541-2a5e-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 03:29:02 +0200 (CEST) Received: from FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::12) by PA4PR08MB6174.eurprd08.prod.outlook.com (2603:10a6:102:e6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 01:29:01 +0000 Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::86) by FR3P281CA0151.outlook.office365.com (2603:10a6:d10:a2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Fri, 2 Sep 2022 01:29:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 01:29:00 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 02 Sep 2022 01:29:00 +0000 Received: from ebbb3003282c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 936CAAC8-4E5F-41E8-B8A8-E03D2EB2D887.1; Fri, 02 Sep 2022 01:28:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ebbb3003282c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 01:28:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB6004.eurprd08.prod.outlook.com (2603:10a6:20b:285::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 01:28:53 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 01:28:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0411541-2a5e-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mGPdoGsoFxTnITwQh9sYhkP1A6/JOLhrB/qVbhBq16JNj471uh3qsp5JF4Qcg04+ps+duXETpFcDiogQRKzAW6yhpr75IAmSob61r+0fFvumpiV3cCkI0tHS2BCns6sCdMeE4uZJ/UquhDu2BoG58yA1d6TzaRpF06/vO1cfT7EIcio0vXVaJyHNrH0OBirr8YiZ27xJsMpzOuulS1yR28x5RcF6KSeBENtmZ6E40YhcmDBYb5KLgo17Xn22ukmt4NYnzPOsw69BlxldF5c7JqJ/8fxiKF7hlEj5+5JBs5yA6vCaVQhMxreh8ghFq0VxLHj+13spZKZCNoOeeZ8mDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNj9rnYkfPXmAu2FXvN5Nto8kMl+ok+LpejJNKyAcj0=; b=cDP6z8orRNabCdPbrYdrn8RFz1YbtUsllvtWmURBrErvawmX9v85Lo8irpE7qk4tf/tPJ6WikLq/rHGv2eaRcuqpTivq/1KJYW3aGCtHFOYEuJ71buUNTqKZxKTH8f0KVAj3l8e5EAVdi0eGcC/UHpAzcksEc44rMYi9nMpz9iToRgmXvnFQIOkr7fxAzTB+oJoU0kW+2LOrLYPT2Ie6Gbf31BjjVZfG+XeDReyEjbJ81o0j1hxyXJGy/UBE6LP75VrcPkEXSUqKoU86UcTVCuGSxg3hyeotG8dMpumMStOugTTO1jvPeAaGILUltdGw2w5jFUjZlqYEynDSfh2v6w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rNj9rnYkfPXmAu2FXvN5Nto8kMl+ok+LpejJNKyAcj0=; b=6pZanHJM2skTobhJBPh8TcCO47TAF+Mzdjm77kPL1FkS7YO8Rf9Lh/NX9I7JhawxlGpR7+/SmVX4m+HXJ0S6RbuVrvCVDUIK2UUjjg0gjpdHlSTgzS/rHxNNJcPy2oka9BwCPDxFFCHfIx6+DS+EK+pI/ODRbdDzm2B4MaPHavY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkB1+r4Gc5+Px4qegL6tYl8gXoKv73qXflLM47iI2yJMuJdD2Y7PTg4Q90ZNgX9ZLGxLCtfomr7yUOGux7eGhAxTviqxWoZ4qaf6JA3RW79ieQ8TBeU17hCtypMo29OId6Nui8YI98tjWzAgVcEJn6fK6KRn0SWw4qrAH0MFM24Hhz/AvTRb0tOxKdsEd9t4AQ5rrMbtJbadPWorKhnyYyX/ffTEd9Mp+wmJz6UI8v++vfKNG/vcwSKxcMC8FSjijAM5nM3elGpgchLqKlA2mrpCKPNXXsR9AbjbC2nEm0/cTjFW+sBoVl1U5R67vKJIq6cj//OmNTdF1ezxxyOo0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNj9rnYkfPXmAu2FXvN5Nto8kMl+ok+LpejJNKyAcj0=; b=FK+9+vcolptDdt+8+7ryJqEix37qpp/VOk0b5lJdFeCOl91JLmhA2IFnNRNs71SPU0zDwq4aCn+SdLU1JDNf+MTiLPz/YzlA1mvD0PGtYX7QwXH/CEPwlHdHm5i3T06rJsrp7mo/+eWFm/oTVYo02GEV4tvq/zoHJ+7iZkoODdQRiUv8Q64oPKBet9jDaDnSIf0BsR3Pc6YGJKi8aA9bvEMbk4IEznIL0lAUVceojvKQlK/HsbC9d319G5wlsKPb97YGbUYFRWLdH5Q1HfgcsHe4dTEGXpUBtfTOVqbt4kePjqRtVoN8qoJEVnqrw8gfS+nt2T7taCpYkQLZvawxhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rNj9rnYkfPXmAu2FXvN5Nto8kMl+ok+LpejJNKyAcj0=; b=6pZanHJM2skTobhJBPh8TcCO47TAF+Mzdjm77kPL1FkS7YO8Rf9Lh/NX9I7JhawxlGpR7+/SmVX4m+HXJ0S6RbuVrvCVDUIK2UUjjg0gjpdHlSTgzS/rHxNNJcPy2oka9BwCPDxFFCHfIx6+DS+EK+pI/ODRbdDzm2B4MaPHavY= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Bertrand Marquis CC: Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory Thread-Topic: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory Thread-Index: AQHYt4ueuuTQX+2f5E69518db+C55q3KsXoAgAC0jPA= Date: Fri, 2 Sep 2022 01:28:52 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-2-Henry.Wang@arm.com> <9b5afd5e-ec5c-bac6-9ad0-9dd9663aa705@xen.org> In-Reply-To: <9b5afd5e-ec5c-bac6-9ad0-9dd9663aa705@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3E8000BCAAFD7F41A6F2D972C45AEBC9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9b8558d8-4f1b-4f35-c84f-08da8c828399 x-ms-traffictypediagnostic: AM9PR08MB6004:EE_|VE1EUR03FT058:EE_|PA4PR08MB6174:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Rq4HeqoYX3MUnkmll+v76QBUD+KUO6qoBjxgfKPUn79xj928Gmw1curitPNUJp9xGpHwATFy9fpjLQHnz2r0AdaV88QC3uXnVw2dAYDdpsSjTumJuBY2Z/3FIHLijnmuRpRreCQuZHCTeu4SnjyF5tjXdH8I+atP4EbOpRQChEOE8wp5yitZtcS5QgQ5hlBGqi01/x9DKxJsOOk1EGNDSVwOF+qab0RON/iIJmsDMi1pW4eEVobPzKKxdSFlm8QiYEXfSn/N6vfF6YHMqxnfym+JmY/QC3dDokie3qr1tbE9N/RYwUC/+MawCeM9oa+HleunKuzTELEuWtaVd/nOTy1lQsPK9nZF+bLwlSZeC15eXjkY74/ul7dTG2EAaTXWgwgPWTPvC399PV42gQUB0X+ehUME55/wC7IhV+kwpoFQyFSIue9EnPS1jEPFkTpjAef9Qux80XHV3QqZtn3bU8hvbpJsirXVTSTAJlHuWYBJXdDNEpxvtbJby6WsIoeALicDjLuXWlAJ8RKFW3yczp0/GK1NV0kpBzEWzVmq6RTDwSMPXxDwW/7izD1DR7+dnFlM9fsL8e/OhmtQJizls9IuFpUKF5UL6a9+P/K/U1wBR07KFeDUzSsehenyf/Ncnf0FLEri3IQ5yOHptr0dJfl1pDh6AIVANn35DwJg6ONtE7Rvou8z9bvTMKRllpKuDT5dtW+zQaSQdcJkpbRxDv2KHrA3X8f1BUBaRQs9+Crh5HauW5xvGZpUzsA9hokau3n6v11YRD1D8IbLIFQmmg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(52536014)(71200400001)(38070700005)(41300700001)(26005)(6506007)(86362001)(7696005)(9686003)(38100700002)(83380400001)(122000001)(186003)(8936002)(5660300002)(4326008)(66556008)(55016003)(66946007)(8676002)(66446008)(33656002)(66476007)(76116006)(64756008)(2906002)(478600001)(54906003)(110136005)(316002)(6636002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6004 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dc7de5a3-6e34-4b02-f0a0-08da8c827ef3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3NbO9aWf3X4rpwtk8MKd9lcQsUOeXvRu7Kq6FtYyl7IVn53mivZBGWX5cO9uHl/pJvxLadplKHbQUQRBWz4ZtVajU9J7LTO/N8U5ePh9TcvRJxSIBY65hEHACk/IuPkI+9tusXomCOIJWjZmDgxDxQClkFwoQO4nTI/qx/6mpsoUQ4UGTffjadzDLhkfAmmufcCH4ber5n/xK+tr1SVWaeOdxqLX0L9qDPC180HfTAZ1cBeju4ln8BOBbjK71yNNVbNJPPDYUwcTpMG5PnBMl/uGQFkEfNNEU1vz61u/6SMz16/+9Xm4br6Cbuv6vwQJTstEv0UJQ7R8cdjxwAzw3gSuboenb0EdAGoxYhOCv1qPMXv9t1hvCHQCZaRf5fsi+g84MhxX0z7w2b/c978kzPwhGMngNB0GpsAGGS9aseLKfnseJ9yMfyrWbeiXcwN2OEgv0i543MZzII6HZLlwszuRPed1BX/H0oBNq5GdIxWend3qx38bw45O+YHFu07XzlG/Fvtz/+ZKbjCBnTdCcX/8y4sZLk2+uuINM61Zyn9napnITdrGvq3t8SkayKYfeA76/TaBP1+eS/WVnblH3mMBVl1itlfmJkMDG+ifFKpGHFWFE0TJX1NkjPmpdOvJn8FSDxx3OQt25nbxswtRLbo2xKVwhKPnaFGVPtzqxuQ8YgcMAjrXit4MSdGNIBNz7KjxDLFdkKrl3pq5rjYJmwSk6p2KG1eAO0l+7OfV4UC3bD3tnUGDisMwnmmnXQd0vukyqNpQVOdj4+ZIkmD4PA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(376002)(396003)(46966006)(36840700001)(40470700004)(6506007)(54906003)(41300700001)(316002)(478600001)(110136005)(82310400005)(7696005)(6636002)(86362001)(82740400003)(40460700003)(36860700001)(26005)(83380400001)(186003)(81166007)(5660300002)(336012)(47076005)(9686003)(8936002)(33656002)(40480700001)(52536014)(70586007)(70206006)(4326008)(8676002)(2906002)(356005)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 01:29:00.6471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b8558d8-4f1b-4f35-c84f-08da8c828399 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6174 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8yXSBkb2Nz LCB4ZW4vYXJtOiBJbnRyb2R1Y2UgcmVzZXJ2ZWQgaGVhcCBtZW1vcnkNCj4gDQo+IEhpIEhlbnJ5 LA0KPiANCj4gPiBBbHNvLCB0aGlzIGNvbW1pdCBpbnRyb2R1Y2VzIHRoZSBsb2dpYyB0byBwYXJz ZSB0aGUgcmVzZXJ2ZWQgaGVhcA0KPiA+IGNvbmZpZ3VhdGlvbiBpbiBkZXZpY2UgdHJlZSBieSBy ZXVzaW5nIHRoZSBkZXZpY2UgdHJlZSBlbnRyeSBkZWZpbml0aW9uDQo+IA0KPiB0eXBvOiBzL2Nv bmZpZ3VhdGlvbi9jb25maWd1cmF0aW9uLw0KDQpPb3BzLCBzb3JyeSBmb3IgdGhhdC4uLg0KDQo+ IA0KPiA+ICAgZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCB8IDQ2DQo+ICsr KysrKysrKysrKysrKysrKysrKysrKysNCj4gDQo+IEkgaGF2ZSBza2lwcGVkIHRoZSBkb2N1bWVu dGF0aW9uIGFuZCBsb29rZWQgYXQgdGhlIGNvZGUgaW5zdGVhZC4NCg0KTm8gcHJvYmxlbSwgU3Rl ZmFubyBhbmQgTWljaGFsIGhhdmUgYWxyZWFkeSBwcm92aWRlZCBzb21lIGNvbW1lbnRzDQppbiB0 aGUgZG9jLg0KDQo+IA0KPiBJdCBzb3VuZHMgbGlrZSB0byBtZSwgd2Ugd2FudCB0byBoYXZlIGFu IGVudW0gcmF0aGVyIHRoYW4gbXVsdGlwbGUNCj4gYm9vbGVhbi4gVGhpcyB3b3VsZCBhbHNvIG1h a2UgZWFzaWVyLi4uDQo+IA0KPiA+ICAgew0KPiA+ICAgICAgIGNvbnN0IHN0cnVjdCBmZHRfcHJv cGVydHkgKnByb3A7DQo+ID4gICAgICAgdW5zaWduZWQgaW50IGksIGJhbmtzOw0KPiA+IEBAIC05 Niw2ICs5Nyw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGRldmljZV90cmVlX2dldF9tZW1pbmZvKGNv bnN0IHZvaWQNCj4gKmZkdCwgaW50IG5vZGUsDQo+ID4gICAgICAgICAgIG1lbS0+YmFua1ttZW0t Pm5yX2JhbmtzXS5zdGFydCA9IHN0YXJ0Ow0KPiA+ICAgICAgICAgICBtZW0tPmJhbmtbbWVtLT5u cl9iYW5rc10uc2l6ZSA9IHNpemU7DQo+ID4gICAgICAgICAgIG1lbS0+YmFua1ttZW0tPm5yX2Jh bmtzXS54ZW5fZG9tYWluID0geGVuX2RvbWFpbjsNCj4gPiArICAgICAgICBtZW0tPmJhbmtbbWVt LT5ucl9iYW5rc10ueGVuX2hlYXAgPSB4ZW5faGVhcDsNCj4gPiAgICAgICAgICAgbWVtLT5ucl9i YW5rcysrOw0KPiA+ICAgICAgIH0NCj4gPg0KPiA+IEBAIC0xODUsNyArMTg3LDcgQEAgc3RhdGlj IGludCBfX2luaXQgcHJvY2Vzc19tZW1vcnlfbm9kZShjb25zdCB2b2lkDQo+ICpmZHQsIGludCBu b2RlLA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpk YXRhKQ0KPiA+ICAgew0KPiA+ICAgICAgIHJldHVybiBkZXZpY2VfdHJlZV9nZXRfbWVtaW5mbyhm ZHQsIG5vZGUsICJyZWciLCBhZGRyZXNzX2NlbGxzLA0KPiBzaXplX2NlbGxzLA0KPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEsIGZhbHNlKTsNCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLCBmYWxzZSwgZmFsc2UpOw0KPiANCj4g Li4uIHRvIHVuZGVyc3RhbmQgdGhlIHR3byAiZmFsc2UiIGhlcmUuDQoNCkkgYWdyZWUsIHdpbGwg Y2hhbmdlIGluIHYyLg0KDQo+IA0KPiA+ICAgfQ0KPiA+DQo+ID4gICBzdGF0aWMgaW50IF9faW5p dCBwcm9jZXNzX3Jlc2VydmVkX21lbW9yeV9ub2RlKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUs DQo+ID4gQEAgLTI5Myw3ICsyOTUsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgcHJvY2Vzc19tdWx0 aWJvb3Rfbm9kZShjb25zdA0KPiB2b2lkICpmZHQsIGludCBub2RlLA0KPiA+ICAgICAgICAgICAg ICAgICAgICAgICAga2luZCwgc3RhcnQsIGRvbVUpOw0KPiA+ICAgfQ0KPiA+DQo+ID4gLXN0YXRp YyB2b2lkIF9faW5pdCBwcm9jZXNzX2Nob3Nlbl9ub2RlKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5v ZGUsDQo+ID4gK3N0YXRpYyBpbnQgX19pbml0IHByb2Nlc3NfY2hvc2VuX25vZGUoY29uc3Qgdm9p ZCAqZmR0LCBpbnQgbm9kZSwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IGNoYXIgKm5hbWUsDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1MzIgYWRkcmVzc19jZWxscywgdTMyIHNpemVfY2VsbHMpID4gICB7DQo+ ID4gQEAgLTMwMSwxNiArMzAzLDQwIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcm9jZXNzX2Nob3Nl bl9ub2RlKGNvbnN0DQo+IHZvaWQgKmZkdCwgaW50IG5vZGUsDQo+ID4gICAgICAgcGFkZHJfdCBz dGFydCwgZW5kOw0KPiA+ICAgICAgIGludCBsZW47DQo+ID4NCj4gPiArICAgIGlmICggZmR0X2dl dF9wcm9wZXJ0eShmZHQsIG5vZGUsICJ4ZW4sc3RhdGljLW1lbSIsIE5VTEwpICkNCj4gPiArICAg IHsNCj4gPiArICAgICAgICB1MzIgYWRkcmVzc19jZWxscyA9IGRldmljZV90cmVlX2dldF91MzIo ZmR0LCBub2RlLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiI3hlbixzdGF0aWMtbWVtLWFkZHJlc3MtY2VsbHMiLA0KPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwKTsNCj4gPiArICAgICAgICB1 MzIgc2l6ZV9jZWxscyA9IGRldmljZV90cmVlX2dldF91MzIoZmR0LCBub2RlLA0KPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiI3hlbixzdGF0aWMtbWVt LXNpemUtY2VsbHMiLCAwKTsNCj4gPiArICAgICAgICBpbnQgcmM7DQo+ID4gKw0KPiA+ICsgICAg ICAgIHByaW50aygiQ2hlY2tpbmcgZm9yIHJlc2VydmVkIGhlYXAgaW4gL2Nob3NlblxuIik7DQo+ ID4gKyAgICAgICAgaWYgKCBhZGRyZXNzX2NlbGxzIDwgMSB8fCBzaXplX2NlbGxzIDwgMSApDQo+ ID4gKyAgICAgICAgew0KPiA+ICsgICAgICAgICAgICBwcmludGsoImZkdDogbm9kZSBgJXMnOiBp bnZhbGlkICN4ZW4sc3RhdGljLW1lbS1hZGRyZXNzLWNlbGxzIG9yDQo+ICN4ZW4sc3RhdGljLW1l bS1zaXplLWNlbGxzXG4iLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgbmFtZSk7DQo+ID4gKyAg ICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsgICAgICAgIH0NCj4gPiArDQo+ID4gKyAg ICAgICAgcmMgPSBkZXZpY2VfdHJlZV9nZXRfbWVtaW5mbyhmZHQsIG5vZGUsICJ4ZW4sc3RhdGlj LW1lbSIsDQo+IGFkZHJlc3NfY2VsbHMsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzaXplX2NlbGxzLCAmYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLCBmYWxzZSwNCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUpOw0KPiA+ICsgICAg ICAgIGlmICggcmMgKQ0KPiA+ICsgICAgICAgICAgICByZXR1cm4gcmM7DQo+ID4gKyAgICB9DQo+ ID4gKw0KPiA+ICAgICAgIHByaW50aygiQ2hlY2tpbmcgZm9yIGluaXRyZCBpbiAvY2hvc2VuXG4i KTsNCj4gPg0KPiA+ICAgICAgIHByb3AgPSBmZHRfZ2V0X3Byb3BlcnR5KGZkdCwgbm9kZSwgImxp bnV4LGluaXRyZC1zdGFydCIsICZsZW4pOw0KPiA+ICAgICAgIGlmICggIXByb3AgKQ0KPiA+ICAg ICAgICAgICAvKiBObyBpbml0cmQgcHJlc2VudC4gKi8NCj4gPiAtICAgICAgICByZXR1cm47DQo+ ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+ID4gICAgICAgaWYgKCBsZW4gIT0gc2l6ZW9mKHUzMikg JiYgbGVuICE9IHNpemVvZih1NjQpICkNCj4gPiAgICAgICB7DQo+ID4gICAgICAgICAgIHByaW50 aygibGludXgsaW5pdHJkLXN0YXJ0IHByb3BlcnR5IGhhcyBpbnZhbGlkIGxlbmd0aCAlZFxuIiwg bGVuKTsNCj4gPiAtICAgICAgICByZXR1cm47DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7 DQo+IA0KPiBUaGlzIGlzIHRlY2huaWNhbGx5IGEgY2hhbmdlIGluIGJlaGF2aW9yIGZvciBYZW4g KHdlIHdvdWxkIHBhbmljIHJhdGhlcg0KPiB0aGFuIGNvbnRpbnVlKS4gSSBhbSBoYXBweSB3aXRo IHRoZSBwcm9wb3NhbC4gSG93ZXZlciwgdGhpcyBkb2Vzbid0IHNlZW0NCj4gdG8gYmUgZXhwbGFp bmVkIGluIHRoZSBjb21taXQgbWVzc2FnZS4NCj4gDQo+IFRoYXQgc2FpZCwgSSB0aGluayB0aGlz IHNob3VsZCBiZSBzcGxpdCBpbiBhIHNlcGFyYXRlIHBhdGNoIGFsb25nIHdpdGgNCj4gdGhlIG9u ZXMgYmVsb3cgKGluY2x1ZGluZyB0aGUgcHJvdG90eXBlIGNoYW5nZXMpLg0KDQpBY2NvcmRpbmcg dG8gTWljaGFsJ3MgY29tbWVudCwgSSd2ZSByZW1vdmVkIHRoZSByZXR1cm4gdHlwZSBhbmQgZnVu Y3Rpb24NCnByb3RvdHlwZSBjaGFuZ2UgaW4gbXkgbG9jYWwgdjIuIFNvIHRoaXMgcGF0Y2ggaXRz ZWxmIGlzIGZpbmUuIE15IHF1ZXN0aW9uIG5vdw0Kd291bGQgYmUsIGRvIG1haW50YWluZXJzIHRo aW5rIHRoaXMgY2hhbmdlIG9mIGJlaGF2aW9yIHdpdGggcHJvY2Vzc2luZyB0aGUNCmNob3NlbiBu b2RlIGJlIGhlbHBmdWw/IERvIHdlIHByZWZlciBhbiBpbnN0YW50IHBhbmljIG9yIGN1cnJlbnQg YmVoYXZpb3I/DQoNCkkgYW0gbW9yZSB0aGFuIGhhcHB5IHRvIGFkZCBhIHBhdGNoIGZvciBjaGFu Z2luZyB0aGUgcmV0dXJuL3BhbmljIGJlaGF2aW9yDQppZiBldmVyeW9uZSBpcyBoYXBweSB3aXRo IGl0Lg0KDQo+IA0KPiA+ICAgICAgIH0NCj4gPiAgICAgICBzdGFydCA9IGR0X3JlYWRfbnVtYmVy KCh2b2lkICopJnByb3AtPmRhdGEsIGR0X3NpemVfdG9fY2VsbHMobGVuKSk7DQo+ID4NCj4gPiBA QCAtMzE4LDEyICszNDQsMTIgQEAgc3RhdGljIHZvaWQgX19pbml0IHByb2Nlc3NfY2hvc2VuX25v ZGUoY29uc3QNCj4gdm9pZCAqZmR0LCBpbnQgbm9kZSwNCj4gPiAgICAgICBpZiAoICFwcm9wICkN Cj4gPiAgICAgICB7DQo+ID4gICAgICAgICAgIHByaW50aygibGludXgsaW5pdHJkLWVuZCBub3Qg cHJlc2VudCBidXQgLXN0YXJ0IHdhc1xuIik7DQo+ID4gLSAgICAgICAgcmV0dXJuOw0KPiA+ICsg ICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICAgICAgIH0NCj4gPiAgICAgICBpZiAoIGxlbiAh PSBzaXplb2YodTMyKSAmJiBsZW4gIT0gc2l6ZW9mKHU2NCkgKQ0KPiA+ICAgICAgIHsNCj4gPiAg ICAgICAgICAgcHJpbnRrKCJsaW51eCxpbml0cmQtZW5kIHByb3BlcnR5IGhhcyBpbnZhbGlkIGxl bmd0aCAlZFxuIiwgbGVuKTsNCj4gPiAtICAgICAgICByZXR1cm47DQo+ID4gKyAgICAgICAgcmV0 dXJuIC1FSU5WQUw7DQo+ID4gICAgICAgfQ0KPiA+ICAgICAgIGVuZCA9IGR0X3JlYWRfbnVtYmVy KCh2b2lkICopJnByb3AtPmRhdGEsIGR0X3NpemVfdG9fY2VsbHMobGVuKSk7DQo+ID4NCj4gPiBA QCAtMzMxLDEyICszNTcsMTQgQEAgc3RhdGljIHZvaWQgX19pbml0IHByb2Nlc3NfY2hvc2VuX25v ZGUoY29uc3QNCj4gdm9pZCAqZmR0LCBpbnQgbm9kZSwNCj4gPiAgICAgICB7DQo+ID4gICAgICAg ICAgIHByaW50aygibGludXgsaW5pdHJkIGxpbWl0cyBpbnZhbGlkOiAlIlBSSXBhZGRyIiA+PSAl IlBSSXBhZGRyIlxuIiwNCj4gPiAgICAgICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQpOw0KPiA+ IC0gICAgICAgIHJldHVybjsNCj4gPiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPiAgICAg ICB9DQo+ID4NCj4gPiAgICAgICBwcmludGsoIkluaXRyZCAlIlBSSXBhZGRyIi0lIlBSSXBhZGRy IlxuIiwgc3RhcnQsIGVuZCk7DQo+ID4NCj4gPiAgICAgICBhZGRfYm9vdF9tb2R1bGUoQk9PVE1P RF9SQU1ESVNLLCBzdGFydCwgZW5kLXN0YXJ0LCBmYWxzZSk7DQo+ID4gKw0KPiA+ICsgICAgcmV0 dXJuIDA7DQo+ID4gICB9DQo+ID4NCj4gPiAgIHN0YXRpYyBpbnQgX19pbml0IHByb2Nlc3NfZG9t YWluX25vZGUoY29uc3Qgdm9pZCAqZmR0LCBpbnQgbm9kZSwNCj4gPiBAQCAtMzU4LDcgKzM4Niw4 IEBAIHN0YXRpYyBpbnQgX19pbml0IHByb2Nlc3NfZG9tYWluX25vZGUoY29uc3Qgdm9pZA0KPiAq ZmR0LCBpbnQgbm9kZSwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiI3hlbixzdGF0aWMtbWVtLXNpemUtY2VsbHMiLCAwKTsNCj4gPg0KPiA+ICAgICAgIHJldHVy biBkZXZpY2VfdHJlZV9nZXRfbWVtaW5mbyhmZHQsIG5vZGUsICJ4ZW4sc3RhdGljLW1lbSIsDQo+ IGFkZHJlc3NfY2VsbHMsDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c2l6ZV9jZWxscywgJmJvb3RpbmZvLnJlc2VydmVkX21lbSwgdHJ1ZSk7DQo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZV9jZWxscywgJmJvb3RpbmZvLnJlc2VydmVk X21lbSwgdHJ1ZSwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxz ZSk7DQo+ID4gICB9DQo+ID4NCj4gPiAgIHN0YXRpYyBpbnQgX19pbml0IGVhcmx5X3NjYW5fbm9k ZShjb25zdCB2b2lkICpmZHQsDQo+ID4gQEAgLTM4Myw3ICs0MTIsNyBAQCBzdGF0aWMgaW50IF9f aW5pdCBlYXJseV9zY2FuX25vZGUoY29uc3Qgdm9pZCAqZmR0LA0KPiA+ICAgICAgICAgICAgICAg ICBkZXZpY2VfdHJlZV9ub2RlX2NvbXBhdGlibGUoZmR0LCBub2RlLCAibXVsdGlib290LG1vZHVs ZSIgKSkpDQo+ID4gICAgICAgICAgIHByb2Nlc3NfbXVsdGlib290X25vZGUoZmR0LCBub2RlLCBu YW1lLCBhZGRyZXNzX2NlbGxzLCBzaXplX2NlbGxzKTsNCj4gPiAgICAgICBlbHNlIGlmICggZGVw dGggPT0gMSAmJiBkZXZpY2VfdHJlZV9ub2RlX21hdGNoZXMoZmR0LCBub2RlLCAiY2hvc2VuIikg KQ0KPiA+IC0gICAgICAgIHByb2Nlc3NfY2hvc2VuX25vZGUoZmR0LCBub2RlLCBuYW1lLCBhZGRy ZXNzX2NlbGxzLCBzaXplX2NlbGxzKTsNCj4gPiArICAgICAgICByYyA9IHByb2Nlc3NfY2hvc2Vu X25vZGUoZmR0LCBub2RlLCBuYW1lLCBhZGRyZXNzX2NlbGxzLCBzaXplX2NlbGxzKTsNCj4gPiAg ICAgICBlbHNlIGlmICggZGVwdGggPT0gMiAmJiBkZXZpY2VfdHJlZV9ub2RlX2NvbXBhdGlibGUo ZmR0LCBub2RlLA0KPiAieGVuLGRvbWFpbiIpICkNCj4gPiAgICAgICAgICAgcmMgPSBwcm9jZXNz X2RvbWFpbl9ub2RlKGZkdCwgbm9kZSwgbmFtZSwgYWRkcmVzc19jZWxscywgc2l6ZV9jZWxscyk7 DQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVu L2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gaW5kZXggM2ZkMTE4NmI1My4uNmY5N2Y1ZjA2 YSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiArKysg Yi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBAQCAtMTAzOCw4ICsxMDM4LDkgQEAg c3RhdGljIGludCBfX2luaXQgbWFrZV9tZW1vcnlfbm9kZShjb25zdCBzdHJ1Y3QNCj4gZG9tYWlu ICpkLA0KPiA+ICAgICAgIGlmICggbWVtLT5ucl9iYW5rcyA9PSAwICkNCj4gPiAgICAgICAgICAg cmV0dXJuIC1FTk9FTlQ7DQo+ID4NCj4gPiAtICAgIC8qIGZpbmQgZmlyc3QgbWVtb3J5IHJhbmdl IG5vdCBib3VuZCB0byBhIFhlbiBkb21haW4gKi8NCj4gPiAtICAgIGZvciAoIGkgPSAwOyBpIDwg bWVtLT5ucl9iYW5rcyAmJiBtZW0tPmJhbmtbaV0ueGVuX2RvbWFpbjsgaSsrICkNCj4gPiArICAg IC8qIGZpbmQgZmlyc3QgbWVtb3J5IHJhbmdlIG5vdCBib3VuZCB0byBuZWl0aGVyIGEgWGVuIGRv bWFpbiBub3IgaGVhcA0KPiAqLw0KPiA+ICsgICAgZm9yICggaSA9IDA7IGkgPCBtZW0tPm5yX2Jh bmtzICYmDQo+ID4gKyAgICAgICAgICAgICAgICAgKG1lbS0+YmFua1tpXS54ZW5fZG9tYWluIHx8 IG1lbS0+YmFua1tpXS54ZW5faGVhcCk7IGkrKyApDQo+ID4gICAgICAgICAgIDsNCj4gPiAgICAg ICBpZiAoIGkgPT0gbWVtLT5ucl9iYW5rcyApDQo+ID4gICAgICAgICAgIHJldHVybiAwOw0KPiA+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPiBiL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gaW5kZXggMmJiMDFlY2ZhOC4uZTgwZjNk NjIwMSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0K PiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gQEAgLTI3LDYg KzI3LDcgQEAgc3RydWN0IG1lbWJhbmsgew0KPiA+ICAgICAgIHBhZGRyX3Qgc3RhcnQ7DQo+ID4g ICAgICAgcGFkZHJfdCBzaXplOw0KPiA+ICAgICAgIGJvb2wgeGVuX2RvbWFpbjsgLyogd2hldGhl ciB0aGUgbWVtb3J5IGJhbmsgaXMgYm91bmQgdG8gYSBYZW4NCj4gZG9tYWluLiAqLw0KPiA+ICsg ICAgYm9vbCB4ZW5faGVhcDsgICAvKiB3aGV0aGVyIHRoZSBtZW1vcnkgYmFuayBpcyByZXNlcnZl ZCBhcyBoZWFwLiAqLw0KPiANCj4gV2UgaGF2ZSBtdWx0aXBsZSBoZWFwOiBzdGF0aWMsIGRvbWFp biwgeGVuLiBBRkFJVSwgJ3hlbl9oZWFwJyByZWZlcnMgdG8NCj4gYm90aCBkb21haW4gYW5kIHhl biB3aGVyZWFzICd4ZW5fZG9tYWluJyByZWZlcnMgdG8gJ3N0YXRpYycuDQo+IA0KPiBJbiBsaW5l IHdpdGggd2hhdCBJIHdyb3RlIGFib3ZlLCBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciBpZiB3 ZSBoYXZlIGENCj4gc2luZ2xlIGZpZWxkICdoZWFwJyB3aGljaCBpcyBhbiBlbnVtIGxpc3Rpbmcg dGhlIHR5cGUgb2YgaGVhcC4NCg0KU3VyZSwgd2lsbCBmb2xsb3cgdGhpcyB3YXkuDQoNCktpbmQg cmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFs bA0K From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397129.637591 (Exim 4.92) (envelope-from ) id 1oTvax-0002XD-JB; Fri, 02 Sep 2022 01:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397129.637591; Fri, 02 Sep 2022 01:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvax-0002X6-Ew; Fri, 02 Sep 2022 01:35:43 +0000 Received: by outflank-mailman (input) for mailman id 397129; Fri, 02 Sep 2022 01:35:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvav-0002Wh-HZ for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:35:42 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c89147d-2a5f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 03:35:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c89147d-2a5f-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 21:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662082539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DKbeuQ0KEVmGJmd1nxH6IkYl6hlcE8fBK782zCfa3dY=; b=djK/rzc16o2I5st6iLU+mmFycopk8nXeACxAiaLCYMzWJYltipsNT6kJ+bcD6p5dv0fhQK tsO6ER4nJ6etmNpcfsjSsEGbvTpJzvOlYT1SEGzRruYg/z2yOc4vkCLRQmY8hz09hO4/JQ EYL/angxfkhwhSI7Gv5opBj0F7OyMnA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220902013532.6n5cyf3oofntljho@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> <20220901183430.120311ce@gandalf.local.home> <20220901225515.ogg7pyljmfzezamr@moria.home.lan> <20220901202311.546a53b5@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901202311.546a53b5@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 08:23:11PM -0400, Steven Rostedt wrote: > If ftrace, perf, bpf can't do what you want, take a harder look to see if > you can modify them to do so. Maybe we can use this exchange to make both of our tools better. I like your histograms - the quantiles algorithm I've had for years is janky, I've been meaning to rip that out, I'd love to take a look at your code for that. And having an on/off switch is a good idea, I'll try to add that at some point. Maybe you got some ideas from my stuff too. I'd love to get better tracepoints for measuring latency - what I added to init_wait() and finish_wait() was really only a starting point. Figuring out the right places to measure is where I'd like to be investing my time in this area, and there's no reason we couldn't both be making use of that. e.g. with kernel waitqueues, I looked at hooking prepare_to_wait() first but not all code uses that, init_wait() got me better coverage. But I've already seen that that misses things, too, there's more work to be done. random thought: might try adding a warning in schedule() any time it's called and codetag_time_stats_start() hasn't been called, that'll be a starting point... From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:51:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:51:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397136.637601 (Exim 4.92) (envelope-from ) id 1oTvpm-0004qD-PW; Fri, 02 Sep 2022 01:51:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397136.637601; Fri, 02 Sep 2022 01:51:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvpm-0004q6-Mi; Fri, 02 Sep 2022 01:51:02 +0000 Received: by outflank-mailman (input) for mailman id 397136; Fri, 02 Sep 2022 01:51:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvpk-0004px-UT for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:51:00 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0f57694-2a61-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 03:50:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28493B828C3; Fri, 2 Sep 2022 01:50:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6228C433D6; Fri, 2 Sep 2022 01:50:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0f57694-2a61-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662083457; bh=kpvZcNv0Yk2sZhMzSSlCr20ObFRFOyBCoQqD7/vjsRY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PZV/uYVzmpiJmgsBAN/gWPfHeWXq2N8VbUeLQeulIls6D5IXnwlnLZRVATWRiT3Gj CB08Np+/uUl8NOFFZfebQGz3bm4FUniNY1CnRp7TkaamzfpBQMK43jcJroBIHtZUMz kWr4TroGrYJ/G9rWzuQmFXOeE3FZJnK8r9YXx1WtxPxDCTXga6svpScaZjqWXXG6/3 6DKowh122y1x8/ZIxFK6IUMiae2rlr/IimXzLqgdKGTSOqyYJhZ1HRxzCYUjmd/i5S Y1t3wn4Ums0aVV6QLSbXeHwNoIR14LmRxM0HjmOOcuXn/4v0wd34eJbvZwfzm9fIet jmnZQh3ZzkBqg== Date: Thu, 1 Sep 2022 18:50:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Henry Wang , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator In-Reply-To: Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Julien Grall wrote: > Hi Stefano, > > On 01/09/2022 18:08, Stefano Stabellini wrote: > > > > Also, what happen with UEFI? Is it easy to guarantee the region will not > > > > be used? > > > > > > For now I think it is not easy to guarantee that, do you have some ideas > > > in mind? I think I can follow this in above follow-up series to improve > > > things. > > > > For clarity, are we worried that the region is used by the bootloader > > for other things? For instance U-Boot or Tianocore placing some > > firmware tables inside the range specified for xenheap? > > Yes. I think it would be difficult for an admin to figure out which regions > are used. Although they are likely (?) going to be static for a given > UEFI/U-boot build. > > My major concern is such bug can be very difficult to root cause because we > have no safety in Xen. The most likely symptom would be random corruption. Thanks for the clarification. Yeah, I think we'll have to do some "creative thinking" to figure out a solution to this issue. I wonder if U-boot or Tianocore have some sort of API (or build-time data) to know the unavailable ranges. In any case, I think we can postpone to after the release. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:59:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:59:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397143.637613 (Exim 4.92) (envelope-from ) id 1oTvxa-0005WP-KC; Fri, 02 Sep 2022 01:59:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397143.637613; Fri, 02 Sep 2022 01:59:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvxa-0005WI-H5; Fri, 02 Sep 2022 01:59:06 +0000 Received: by outflank-mailman (input) for mailman id 397143; Fri, 02 Sep 2022 01:59:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvxY-0005WC-Md for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:59:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d07333ee-2a62-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 03:59:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE59C60DE9; Fri, 2 Sep 2022 01:59:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 171BAC433C1; Fri, 2 Sep 2022 01:58:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d07333ee-2a62-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 21:59:25 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 27/30] Code tagging based latency tracking Message-ID: <20220901215925.59ae5cb0@gandalf.local.home> In-Reply-To: <20220902013532.6n5cyf3oofntljho@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-28-surenb@google.com> <20220901173844.36e1683c@gandalf.local.home> <20220901215438.gy3bgqa4ghhm6ztm@moria.home.lan> <20220901183430.120311ce@gandalf.local.home> <20220901225515.ogg7pyljmfzezamr@moria.home.lan> <20220901202311.546a53b5@gandalf.local.home> <20220902013532.6n5cyf3oofntljho@moria.home.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Sep 2022 21:35:32 -0400 Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 08:23:11PM -0400, Steven Rostedt wrote: > > If ftrace, perf, bpf can't do what you want, take a harder look to see if > > you can modify them to do so. > > Maybe we can use this exchange to make both of our tools better. I like your > histograms - the quantiles algorithm I've had for years is janky, I've been > meaning to rip that out, I'd love to take a look at your code for that. And > having an on/off switch is a good idea, I'll try to add that at some point. > Maybe you got some ideas from my stuff too. > > I'd love to get better tracepoints for measuring latency - what I added to > init_wait() and finish_wait() was really only a starting point. Figuring out > the right places to measure is where I'd like to be investing my time in this > area, and there's no reason we couldn't both be making use of that. Yes, this is exactly what I'm talking about. I'm not against your work, I just want you to work more with everyone to come up with ideas that can help everyone as a whole. That's how "open source communities" is suppose to work ;-) The histogram and synthetic events can use some more clean ups. There's a lot of places that can be improved in that code. But I feel the ideas behind that code is sound. It's just getting the implementation to be a bit more efficient. > > e.g. with kernel waitqueues, I looked at hooking prepare_to_wait() first but not > all code uses that, init_wait() got me better coverage. But I've already seen > that that misses things, too, there's more work to be done. I picked prepare_to_wait() just because I was hacking up something quick and thought that was "close enough" ;-) -- Steve From xen-devel-bounces@lists.xenproject.org Fri Sep 02 01:59:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 01:59:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397144.637624 (Exim 4.92) (envelope-from ) id 1oTvxl-0005qW-R9; Fri, 02 Sep 2022 01:59:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397144.637624; Fri, 02 Sep 2022 01:59:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvxl-0005qO-OT; Fri, 02 Sep 2022 01:59:17 +0000 Received: by outflank-mailman (input) for mailman id 397144; Fri, 02 Sep 2022 01:59:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTvxk-0005WC-Dt for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:59:16 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8229f5b-2a62-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 03:59:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57FEA60B4A; Fri, 2 Sep 2022 01:59:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC28DC433D6; Fri, 2 Sep 2022 01:59:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8229f5b-2a62-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662083953; bh=LJWxUcaoKkGNDEB6WfgguSAcJ9dxDaxVrCgSQH66V48=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fY4qIv2vqofT8d3nHtKOjamsUmlA0vzTw4cKiNgPBrV2eSA/dQKtJG0P2Ltmff8Ao 0MBcts/qdgwxIOm/UaZRMaS9xaxyTPHynM8vuSaih0wtBvNAzI3KktPHBEh76rxb1P Q3HG6PB4R/ufcDmCpfGRJbn66Xwz1dQYc0sxZey/7ANCmuW13ecfIk4eAUHKuf5Aqp nVI9gjeMw/IdCFsCqOjq236P0LDpy1if5+YVbhYUPpk/gzLGpUidREAVRlwCU0Iy07 sKIgISuX7BrsbR6t+Cv0MZV25vAl5SMq/VZT2rLQqKs9+lrLKH1csw6ZloG8n85Hzh UvIlE8FtTUKYQ== Date: Thu, 1 Sep 2022 18:59:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Penny Zheng , xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v6 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated In-Reply-To: <781b03df-5f0d-109c-6253-2b7c4a079ce1@xen.org> Message-ID: References: <20220721132115.3015761-1-Penny.Zheng@arm.com> <20220721132115.3015761-6-Penny.Zheng@arm.com> <781b03df-5f0d-109c-6253-2b7c4a079ce1@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Julien Grall wrote: > Hi Penny, > > On 21/07/2022 14:21, Penny Zheng wrote: > > Borrower domain will fail to get a page ref using the owner domain > > during allocation, when the owner is created after borrower. > > > > So here, we decide to get and add the right amount of reference, which > > is the number of borrowers, when the owner is allocated. > > > > Signed-off-by: Penny Zheng > > Reviewed-by: Stefano Stabellini > > IMHO, this tag should not have been kept given... > > > --- > > v6 change: > > - adapt to the change of "nr_shm_borrowers" > > ... this change. 'reviewed-by' means that the person reviewed the code and > therefore agree with the logic. So I would only keep the tag if the change is > trivial (including typo, coding style) and would drop it (or confirm with the > person) otherwise. > > Stefano, can you confirm you are happy that your reviewed-by tag is kept? Yes I confirm Reviewed-by: Stefano Stabellini > > - add in-code comment to explain if the borrower is created first, we intend > > to > > add pages in the P2M without reference. > > --- > > v5 change: > > - no change > > --- > > v4 changes: > > - no change > > --- > > v3 change: > > - printk rather than dprintk since it is a serious error > > --- > > v2 change: > > - new commit > > --- > > xen/arch/arm/domain_build.c | 60 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index a7e95c34a7..e891e800a7 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -761,6 +761,30 @@ static void __init assign_static_memory_11(struct > > domain *d, > > } > > #ifdef CONFIG_STATIC_SHM > > +static int __init acquire_nr_borrower_domain(struct domain *d, > > + paddr_t pbase, paddr_t psize, > > + unsigned long *nr_borrowers) > > +{ > > + unsigned long bank; > > NIT: AFAICT nr_banks is an "unsigned int". > > Other than that: > > Acked-by: Julien Grall > > Cheers, > > -- > Julien Grall > From xen-devel-bounces@lists.xenproject.org Fri Sep 02 02:05:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 02:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397160.637635 (Exim 4.92) (envelope-from ) id 1oTw3f-0007tm-GN; Fri, 02 Sep 2022 02:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397160.637635; Fri, 02 Sep 2022 02:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTw3f-0007tf-D2; Fri, 02 Sep 2022 02:05:23 +0000 Received: by outflank-mailman (input) for mailman id 397160; Fri, 02 Sep 2022 02:05:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTw3d-0007tZ-Ex for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 02:05:21 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afbcdebd-2a63-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 04:05:18 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id CFE4D3200AB8; Thu, 1 Sep 2022 22:05:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 01 Sep 2022 22:05:15 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 22:05:13 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afbcdebd-2a63-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1662084314; x=1662170714; bh=ZzoR2jGGjy zO8FXeHrJVMpRQDnGO/0mF9EE1+PYHHYk=; b=e079IiuZSGmcy+hmyPMSObUjfh sflbIsjDLJgOcq2cCdu3lvJ0oYM7GgpyoaX/zZJGe6MXlxkPK8QDDvsupWIlaOjb PCKd9dPtpRt3lk7IYsYJU3iGHQpbzWytQZL7mNUXfcxFmSE7hNLfqxyjBQEsi1k4 WOk8jhik9dPpELMe3e0oxy/dVFOTn13v+jx3jEBYIL7bC0/jBlCUtZJp+TckIrGd yRNovrhkZvtRwyLFYg7jYcsL1eFiOZbuzZUUQjfDzK+EJrYYPYbiRsh+oiHygl6z W8ZmX+dBkv3/nuL03ZG4CualVvY33YoJ5LYlkTdCPzs2u0EDy2tcWkHv7R2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662084314; x= 1662170714; bh=ZzoR2jGGjyzO8FXeHrJVMpRQDnGO/0mF9EE1+PYHHYk=; b=s KrYKHxTiQk7xgCmMO1WxJUfzHSLvBaXhC1f+r1fLHNkeBgafwCDz+23Kl3zIUsev hvvp5JYf+j+lueig78SU8L70mjzffDz9kR6stmmQgL+N0s8PunEbnP0o7MnC4VqU 8eZIebWZ5tOt3kEkbqhEvNihwbLvn5R/ZsoA0JKcNDkAdguy7DeA9A8RDvv0FaSg +mC+nSsunToebGeVqhF2O4HsLK3leaHF/kvVQlAaZVxY9m4oH6K492cUcfW4LvBS 4pnCDZph5cKwi8eXPuEj0mVvK4GZ91QGo35o1SXs90txlS6OmIzv1cH5W14a/JMU A2385d5wgCcmAfj1dirIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekledgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugesghdtreertddtvdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepkeetudefjeejffeigeefudfgheduvdeg ffduueeiheefleeufffffedtheelvdevnecuffhomhgrihhnpehkvghrnhgvlhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 1 Sep 2022 22:05:09 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Andrew Cooper Subject: Setting constant-time mode CPU flag Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="60pSlVurV+P9wC0q" Content-Disposition: inline --60pSlVurV+P9wC0q Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 1 Sep 2022 22:05:09 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Andrew Cooper Subject: Setting constant-time mode CPU flag On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in a CPU register to enforce constant-time execution. Linux plans to set this bit by default; Xen should do the same. See https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. I recommend setting the bit unconditionally and ignoring guest attempts to change it. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --60pSlVurV+P9wC0q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMRZNgACgkQsoi1X/+c IsEaSA//ZiJ6lN02MUgB8ORxiPICdkFYDnPApv+uz6VQS5DIubKfcbyF9+dKmazV BLe/ycEvBOApmtF8VsjSoaXr71bLoZyP3VXcVmq/zFvLwezbGgXa3zFeWfqVv8HA cQDvnoh9Fymuq2fYxW4ZSRk27Ft0xwr0yuuV+rbQFdQZZEF4Qa7kMq+l6VlfMu7p QvLTsOcUdtOOTSDsgQQwHcuboJd1au3yJUXjGFxxLirRGhEcN+Eh0t5zzG32B+d3 iL7vYg+0nLq6Pz8hr/88TT7O/A81w5Yflv2SZ0UdU0UD9//5V/8+HoOuIru5DsF2 vcuy5ncSIm+7JxqXRAJ5BYdjehPQ8fRjhCFYolkDrR5aW3z9ATVs0d2K8EGYrQF8 uRefL7rBausbnx+JTnD+eixXX3h+dQpL3ojuMzUP6lu2WH3vslpzoRFuzUOUFHhk jhXiiG971liZy1R9GjTy4xnnx/vT1AN2EQdmgQkkRcIfzf++gdkNSl7Euew2TH86 3wRosYrwX7Qa1vXJIUVX7YjeEQpN5XaCUXfxik0bO+L3PRTj1wtKVzHOj7aFkaNG hxRgJa7F7vRXrQB4V3xWG5iie+DAdeLxvbbepEgisJy5njIlEZvvxmWcbJqAkUj0 qCzReFVpeV4XGxcUTnMu1boKmwg/SOO/eS/OYeQ09xFrHqH/Ai8= =5MAK -----END PGP SIGNATURE----- --60pSlVurV+P9wC0q-- From xen-devel-bounces@lists.xenproject.org Fri Sep 02 02:07:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 02:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397167.637646 (Exim 4.92) (envelope-from ) id 1oTw5b-0008TM-Ra; Fri, 02 Sep 2022 02:07:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397167.637646; Fri, 02 Sep 2022 02:07:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTw5b-0008TF-Ow; Fri, 02 Sep 2022 02:07:23 +0000 Received: by outflank-mailman (input) for mailman id 397167; Fri, 02 Sep 2022 02:07:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTw5a-0008T7-J6 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 02:07:22 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa687ac7-2a63-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 04:07:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38192B82939; Fri, 2 Sep 2022 02:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04842C433C1; Fri, 2 Sep 2022 02:07:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa687ac7-2a63-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662084438; bh=nkD7zrNHjQcljVJuYP4L4MyVaV7hhlag7R0EKkQvP7E=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VBpRU7AS0QhnvNwiofpB8SE4L7Xc+XCGXUjfKjUu1oM6nf6o/8KR7gw2yEhjLLtPY vJGY9H/Z1EkI/RrpCfVU06UkRcpgkym3Wf3+BvpkbqN/voPUi1cInQ7wtBL414ZBaB cFbixxyQ7BOg6DL9mIj1NmQlotdUMIpYasF4lBZWgPyaUuGL72lQbialBIdnDgLZgK 07GN/NBzQe957mehU9q3W8Zxlo+z0QQ7dGMbZCrvW5/ElLGhMHzhh8is8e+MADi0xM PfjffLpx6bGutoPBr/64Fokn1uhm1rZeyO1uEZLR1ZvxhDAy0haS6VFuMcvb2g8IuO CJFCpqrVZ+MkQ== Date: Thu, 1 Sep 2022 19:07:16 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Xenia Ragiadakou , Stefano Stabellini , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations In-Reply-To: <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> Message-ID: References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Bertrand Marquis wrote: > Hi Xenia, > > > On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: > > > > > > On 9/1/22 01:35, Stefano Stabellini wrote: > >> Patches 1, 4, and 6 are already committed. I plan to commit patches 2, 3 > >> and 5 in the next couple of days. > >> Patch 7 needs further discussions and it is best addressed during the > >> next MISRA C sync-up. > > > > I would like to share here, before the next MISRA C sync, my understandings that will hopefully resolve a wrong impression of mine, that I may have spread around, regarding this rule. > > There was a misunderstanding regarding the rule 20.7 from my part and I think that Jan is absolutely right that parenthesizing macro parameters used as function arguments is not required by the rule. > > > > The rule 20.7 states "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses" and in the rationale of the rule states "If a macro parameter is not being used as an expression then the parentheses are not necessary because no operators are involved.". > > > > Initially, based on the title, my understanding was that it requires for the expression resulting from the expansion of the macro to be enclosed in parentheses. Then, based on the rule explanation and the examples given, my understanding was that it requires the macro parameters that are used as expressions to be enclosed in parentheses. > > But, after re-thinking about it, the most probable and what makes more sense, is that it require parentheses around the macro parameters that are part of an expression and not around those that are used as expressions. > > > > Therefore, macro parameters being used as function arguments are not required to be enclosed in parentheses, because the function arguments are part of an expression list, not of an expression (comma is evaluated as separator, not as operator). > > While, macro parameters used as rhs and lhs expressions of the assignment operator are required to be enclosed in parentheses because they are part of an assignment expression. > > > > I verified that the violation reported by cppcheck is not due to missing parentheses around the function argument (though still I have not understood the origin of the warning). Also, Eclair does not report it. > > > > Hence, it was a misunderstanding of mine and there is no inconsistency, with respect to this rule, in adding parentheses around macro parameters used as rhs of assignments. The rule does not require adding parentheses around macro parameters used as function arguments and neither cppcheck nor Eclair report violation for missing parentheses around macro parameters used as function arguments. > > > Thanks a lot for the detailed explanation :-) > > What you say does make sense and I agree with your analysis here, only protect when part of an expression and not use as a subsequent parameter (for a function or an other macro). Yeah I also agree with your analysis, and many thanks for double-checking the cppcheck and Eclair's reports. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 02:20:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 02:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397177.637657 (Exim 4.92) (envelope-from ) id 1oTwI9-0002Pp-3n; Fri, 02 Sep 2022 02:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397177.637657; Fri, 02 Sep 2022 02:20:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwI9-0002Pi-0n; Fri, 02 Sep 2022 02:20:21 +0000 Received: by outflank-mailman (input) for mailman id 397177; Fri, 02 Sep 2022 02:20:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwI7-0002PW-1C for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 02:20:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8ac04f0-2a65-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 04:20:17 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B537661DFC; Fri, 2 Sep 2022 02:20:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BABEC433C1; Fri, 2 Sep 2022 02:20:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8ac04f0-2a65-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662085215; bh=z9yztbpr6qVxevKmHFjIE7RnInv3IcjaHlxoJUNi5Ps=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=laMYY4GNTAthAjVpTsf+3iYi6ORJV3gATD9EpqzwDess7yI7vmlkHSp5mWYdCOfcr nXo9Hhuv+hllUr841hXWuqFjDlJVZA9FOn2HncmaR+PGMGaAWkFBQDldqDnUfMRS/r 0nv/BfmOAif0aktZfC3RvH3+utDViUPFFMMLMJBmHVJ9mO6RC9CQ1I36cSfk0GLOQF 8BrETJ11Bl/T//EcVNDzAhya6cdC59VAbT///aPTA5PNNLfuM0MWtchH8eVdzqkhgk Oqs7tpLbldY3e9PFAqcMFwk8ivaNNvklwAzTEd4uHDU0JVWKM/Y3F7UBM9wimqbKRc shuZdr7FE9jhQ== Date: Thu, 1 Sep 2022 19:20:13 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Rahul Singh , xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property In-Reply-To: <2142aa46-24a0-e0cb-16c0-95e8f6302ce6@xen.org> Message-ID: References: <3899ada4cc8217b45eab4f8d85492b0d5a6a9580.1662023183.git.rahul.singh@arm.com> <2142aa46-24a0-e0cb-16c0-95e8f6302ce6@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Julien Grall wrote: > On 01/09/2022 10:13, Rahul Singh wrote: > > Introduce a new sub-node under /chosen node to establish static event > > channel communication between domains on dom0less systems. > > > > An event channel will be created beforehand to allow the domains to > > send notifications to each other. > > > > Signed-off-by: Rahul Singh > > --- > > Changes in v3: > > - use device-tree used_by to find the domain id of the evtchn node. > > - add new static_evtchn_create variable in struct dt_device_node to > > hold the information if evtchn is already created. > > - fix minor comments > > Changes in v2: > > - no change > > --- > > docs/misc/arm/device-tree/booting.txt | 64 ++++++++++++- > > xen/arch/arm/domain_build.c | 128 ++++++++++++++++++++++++++ > > xen/arch/arm/include/asm/setup.h | 1 + > > xen/arch/arm/setup.c | 2 + > > xen/include/xen/device_tree.h | 13 +++ > > 5 files changed, 207 insertions(+), 1 deletion(-) > > > > diff --git a/docs/misc/arm/device-tree/booting.txt > > b/docs/misc/arm/device-tree/booting.txt > > index 98253414b8..edef98e6d1 100644 > > --- a/docs/misc/arm/device-tree/booting.txt > > +++ b/docs/misc/arm/device-tree/booting.txt > > @@ -212,7 +212,7 @@ with the following properties: > > enable only selected interfaces. > > Under the "xen,domain" compatible node, one or more sub-nodes are > > present > > -for the DomU kernel and ramdisk. > > +for the DomU kernel, ramdisk and static event channel. > > The kernel sub-node has the following properties: > > @@ -254,11 +254,44 @@ The ramdisk sub-node has the following properties: > > property because it will be created by the UEFI stub on boot. > > This option is needed only when UEFI boot is used. > > +The static event channel sub-node has the following properties: > > + > > +- compatible > > + > > + "xen,evtchn" > > + > > +- xen,evtchn > > + > > + The property is tuples of two numbers > > + (local-evtchn link-to-foreign-evtchn) where: > > + > > + local-evtchn is an integer value that will be used to allocate local > > port > > + for a domain to send and receive event notifications to/from the remote > > + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L > > ABI. > > + It is recommended to use low event channel IDs. > > + > > + link-to-foreign-evtchn is a single phandle to a remote evtchn to which > > + local-evtchn will be connected. > > Example > > ======= > > chosen { > > + > > + module@0 { > > + compatible = "multiboot,kernel", "multiboot,module"; > > + xen,uefi-binary = "..."; > > + bootargs = "..."; > > + > > + }; > > NIT: Describing this node in the example seems unnecessary. > > > + > > + /* one sub-node per local event channel */ > > + ec1: evtchn@1 { > > + compatible = "xen,evtchn-v1"; > > + /* local-evtchn link-to-foreign-evtchn */ > > + xen,evtchn = <0xa &ec2>; > > + }; > > + > > Here you provide an example for dom0. But the position where you describe the > binding suggests this binding only exists for domUs. > > Either we duplicate the binding or we re-order the documentation to have > common binding in a single place. My preference would be the latter. > > > domU1 { > > compatible = "xen,domain"; > > #address-cells = <0x2>; > > @@ -277,6 +310,23 @@ chosen { > > compatible = "multiboot,ramdisk", "multiboot,module"; > > reg = <0x0 0x4b000000 0xffffff>; > > }; > > + > > + /* one sub-node per local event channel */ > > + ec2: evtchn@2 { > > + compatible = "xen,evtchn-v1"; > > + /* local-evtchn link-to-foreign-evtchn */ > > + xen,evtchn = <0xa &ec1>; > > + }; > > + > > + ec3: evtchn@3 { > > + compatible = "xen,evtchn-v1"; > > + xen,evtchn = <0xb &ec5>; > > + }; > > + > > + ec4: evtchn@4 { > > + compatible = "xen,evtchn-v1"; > > + xen,evtchn = <0xc &ec6>; > > + }; > > }; > > domU2 { > > @@ -296,6 +346,18 @@ chosen { > > compatible = "multiboot,ramdisk", "multiboot,module"; > > reg = <0x0 0x4d000000 0xffffff>; > > }; > > + > > + /* one sub-node per local event channel */ > > + ec5: evtchn@5 { > > + compatible = "xen,evtchn-v1"; > > + /* local-evtchn link-to-foreign-evtchn */ > > + xen,evtchn = <0xb &ec3>; > > + }; > > + > > + ec6: evtchn@6 { > > + compatible = "xen,evtchn-v1"; > > + xen,evtchn = <0xd &ec4>; > > + }; > > }; > > }; > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 707e247f6a..4b24261825 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -33,6 +33,8 @@ > > #include > > #include > > +#define STATIC_EVTCHN_NODE_SIZE_CELLS 2 > > + > > static unsigned int __initdata opt_dom0_max_vcpus; > > integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); > > @@ -3052,6 +3054,131 @@ void __init evtchn_allocate(struct domain *d) > > d->arch.hvm.params[HVM_PARAM_CALLBACK_IRQ] = val; > > } > > +static int __init get_evtchn_dt_property(const struct dt_device_node *np, > > + uint32_t *port, uint32_t *phandle) > > +{ > > + const __be32 *prop = NULL; > > + uint32_t len; > > + > > + prop = dt_get_property(np, "xen,evtchn", &len); > > + if ( !prop ) > > + { > > + printk(XENLOG_ERR "xen,evtchn property should not be empty.\n"); > > + return -EINVAL; > > + } > > + > > + if ( !len || len < dt_cells_to_size(STATIC_EVTCHN_NODE_SIZE_CELLS) ) > > + { > > + printk(XENLOG_ERR "xen,evtchn property value is not valid.\n"); > > + return -EINVAL; > > + } > > + > > + *port = dt_next_cell(1, &prop); > > + *phandle = dt_next_cell(1, &prop); > > + > > + return 0; > > +} > > + > > +static int __init alloc_domain_evtchn(struct dt_device_node *node) > > +{ > > + int rc; > > + uint32_t domU1_port, domU2_port, remote_phandle; > > + struct dt_device_node *remote_node; > > + struct evtchn_alloc_unbound alloc_unbound; > > + struct evtchn_bind_interdomain bind_interdomain; > > + struct domain *d1 = NULL, *d2 = NULL; > > + > > + if ( dt_device_static_evtchn_created(node) ) > > I think this deserve a comment explain why the node would be created. I.e it > would happen if the other side was created first. I will comment about > dt_device_static_evtchn_created() futher down. > > > + return 0; > > + > > + rc = get_evtchn_dt_property(node, &domU1_port, &remote_phandle); > > + if ( rc ) > > + return rc; > > + > > + remote_node = dt_find_node_by_phandle(remote_phandle); > > + if ( !remote_node ) > > + { > > + printk(XENLOG_ERR > > + "evtchn: could not find remote evtchn phandle\n"); > > + return -EINVAL; > > + } > > + > > + rc = get_evtchn_dt_property(remote_node, &domU2_port, &remote_phandle); > > + if ( rc ) > > + return rc; > > + > > + if ( node->phandle != remote_phandle ) > > + { > > + printk(XENLOG_ERR "xen,evtchn property is not setup correctly.\n"); > > + return -EINVAL; > > + } > > + > > + d1 = get_domain_by_id(dt_get_parent(node)->used_by); > > + d2 = get_domain_by_id(dt_get_parent(remote_node)->used_by); > > I think dt_get_parent() could return NULL (i.e. for the root). So I think you > want to check that at least remote_node() has a parent. For convenience, this > check could be done in > > > + > > + if ( !d1 || !d2 ) > > + { > > + printk(XENLOG_ERR "evtchn: could not find domains\n" ); > > + return -EINVAL; > > + } > > + > > + alloc_unbound.dom = d1->domain_id; > > + alloc_unbound.remote_dom = d2->domain_id; > > + > > + rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); > > + if ( rc < 0 ) > > + { > > + printk(XENLOG_ERR > > + "evtchn_alloc_unbound() failure (Error %d) \n", rc); > > + return rc; > > + } > > + > > + bind_interdomain.remote_dom = d1->domain_id; > > + bind_interdomain.remote_port = domU1_port; > > + > > + rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port); > > + if ( rc < 0 ) > > + { > > + printk(XENLOG_ERR > > + "evtchn_bind_interdomain() failure (Error %d) \n", rc); > > + return rc; > > + } > > + > > + dt_device_set_static_evtchn_created(node); > > + dt_device_set_static_evtchn_created(remote_node); > > + > > + return 0; > > +} > > + > > +void __init process_static_evtchn_node(struct dt_device_node *node) > > This is missing a prototype. So I guess this wants to be static? > > That said, I think it would make more sense to fold > process_static_evtchn_node() in alloc_domain_evtchn() or > alloc_static-evtchn(). > > > +{ > > + if ( dt_device_is_compatible(node, "xen,evtchn-v1") ) > > + { > > + if ( alloc_domain_evtchn(node) != 0 ) > > + panic("Could not set up domains evtchn\n"); > > + } > > +} > > + > > +void __init alloc_static_evtchn(void) > > +{ > > + struct dt_device_node *node, *evtchn_node; > > + struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); > > + > > + BUG_ON(chosen == NULL); > > + > > + if ( hardware_domain ) > > + dt_device_set_used_by(chosen, hardware_domain->domain_id); > > + > > + dt_for_each_child_node(chosen, node) > > + { > > + if ( hardware_domain ) > > + process_static_evtchn_node(node); > > + > > + dt_for_each_child_node(node, evtchn_node) > > + process_static_evtchn_node(evtchn_node); > > + } > > +} > > + > > static void __init find_gnttab_region(struct domain *d, > > struct kernel_info *kinfo) > > { > > @@ -3364,6 +3491,7 @@ void __init create_domUs(void) > > panic("Error creating domain %s\n", dt_node_name(node)); > > d->is_console = true; > > + dt_device_set_used_by(node, d->domain_id); > > if ( construct_domU(d, node) != 0 ) > > panic("Could not set up domain %s\n", dt_node_name(node)); > > diff --git a/xen/arch/arm/include/asm/setup.h > > b/xen/arch/arm/include/asm/setup.h > > index 5815ccf8c5..5ee28b270f 100644 > > --- a/xen/arch/arm/include/asm/setup.h > > +++ b/xen/arch/arm/include/asm/setup.h > > @@ -106,6 +106,7 @@ int acpi_make_efi_nodes(void *fdt, struct membank > > tbl_add[]); > > void create_domUs(void); > > void create_dom0(void); > > +void alloc_static_evtchn(void); > > void discard_initial_modules(void); > > void fw_unreserved_regions(paddr_t s, paddr_t e, > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > > index 6e0398f3f6..cf15d359d2 100644 > > --- a/xen/arch/arm/setup.c > > +++ b/xen/arch/arm/setup.c > > @@ -1077,6 +1077,8 @@ void __init start_xen(unsigned long boot_phys_offset, > > if ( acpi_disabled ) > > create_domUs(); > > + alloc_static_evtchn(); > > + > > /* > > * This needs to be called **before** heap_init_late() so modules > > * will be scrubbed (unless suppressed). > > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > > index 430a1ef445..5579c875d2 100644 > > --- a/xen/include/xen/device_tree.h > > +++ b/xen/include/xen/device_tree.h > > @@ -82,6 +82,7 @@ struct dt_device_node { > > dt_phandle phandle; > > char *full_name; > > domid_t used_by; /* By default it's used by dom0 */ > > + bool_t static_evtchn_created; > > I can see why you want to add the boolean in dt_device_node. However, I > dislike this approach because this feels an abuse of dt_device_node and the > field is only used at boot. > > So this seems to be a bit of a waste to include it in the structure (even if > we are re-using padding today). > > I don't have a solution that is has trivial as this approach. However, at > minimum we should document this is a HACK and should be remove if we need > space in the structure. I would move static_evtchn_created just above (or below) "bool is_protected". It would still re-use the padding and it would be closer to another more similar field of the struct. The only other option that I can think of would be to use port_is_valid, instead of static_evtchn_created, to check that the port has already been allocated, but we wouldn't be able to tell if it is a static evtchn or simply unavailable for other reasons and it would require more device tree parsing. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 02:28:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 02:28:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397185.637667 (Exim 4.92) (envelope-from ) id 1oTwQI-00036t-Tn; Fri, 02 Sep 2022 02:28:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397185.637667; Fri, 02 Sep 2022 02:28:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwQI-00036m-R0; Fri, 02 Sep 2022 02:28:46 +0000 Received: by outflank-mailman (input) for mailman id 397185; Fri, 02 Sep 2022 02:28:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwQI-00036c-1H; Fri, 02 Sep 2022 02:28:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwQH-000342-VN; Fri, 02 Sep 2022 02:28:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwQH-0004vp-FJ; Fri, 02 Sep 2022 02:28:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTwQH-0001WS-Et; Fri, 02 Sep 2022 02:28:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C5daYvdMM9VYzzbScH6XTWaXIMeWBkgTTK1F3AJPXfI=; b=UbRRzlMs1/Tv/3+OQJ04DeoMPQ WK96GveM3JvcGRySGW2JFPpzBda1wUZv5aCTUmnoclEcMKbPoEg3/nBc3p9lYotV+6khdlXmCEAZY XE7YrFMbboVoU7nTahxp2Ejd2JQlpg9R4+BmATKG5PF2XcueM+FSW+7CCiQe3LLtrMVs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172923: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=6edd257861fd8ef44d23a6c1afb329efd95a9ae7 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 02:28:45 +0000 flight 172923 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172923/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 6edd257861fd8ef44d23a6c1afb329efd95a9ae7 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 27 days 222 attempts Testing same since 172923 2022-09-01 23:42:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1440 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 02:40:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 02:40:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397196.637682 (Exim 4.92) (envelope-from ) id 1oTwbq-0005Ok-1g; Fri, 02 Sep 2022 02:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397196.637682; Fri, 02 Sep 2022 02:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwbp-0005Od-UL; Fri, 02 Sep 2022 02:40:41 +0000 Received: by outflank-mailman (input) for mailman id 397196; Fri, 02 Sep 2022 02:40:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwbp-0005OT-0U; Fri, 02 Sep 2022 02:40:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwbo-0003Gi-UD; Fri, 02 Sep 2022 02:40:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwbo-0005KD-As; Fri, 02 Sep 2022 02:40:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTwbo-0005Mo-AQ; Fri, 02 Sep 2022 02:40:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6+w4py4jzEZ8MqQmwirV5jWv2Rk46r4WgGa4UgUrVG0=; b=Gs3FNf2pAittKz3ZxR4Ul9xH9x tRBwtmEBx8F5p0MlvY3bHHpYic977pFwQalwGwik0vsgokXmQohl6vehjxDqlFKH0JSsQ+HIjnzHd UR1pW9+jvgCPSLxwT3DfSg9Hq3DdFTHYZNZk0+g191NdxwyoiZhvvP5u9Cu1ywEDEw8Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172916: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e93ded1bf6c94ab95015b33e188bc8b0b0c32670 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 02 Sep 2022 02:40:40 +0000 flight 172916 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172916/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-xsm 6 xen-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu e93ded1bf6c94ab95015b33e188bc8b0b0c32670 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 29 days Failing since 172148 2022-08-04 21:39:38 Z 28 days 64 attempts Testing same since 172905 2022-09-01 03:49:17 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Andrea Bolognani BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Paolo Bonzini Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm fail build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3063 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:03:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:03:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397207.637692 (Exim 4.92) (envelope-from ) id 1oTwxX-0007we-1Q; Fri, 02 Sep 2022 03:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397207.637692; Fri, 02 Sep 2022 03:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwxW-0007wX-Ux; Fri, 02 Sep 2022 03:03:06 +0000 Received: by outflank-mailman (input) for mailman id 397207; Fri, 02 Sep 2022 03:03:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTwxW-0007wR-19 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:03:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2e203e2-2a6b-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:03:03 +0200 (CEST) Received: from DB6PR0802CA0047.eurprd08.prod.outlook.com (2603:10a6:4:a3::33) by DB9PR08MB7536.eurprd08.prod.outlook.com (2603:10a6:10:304::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:03:01 +0000 Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::89) by DB6PR0802CA0047.outlook.office365.com (2603:10a6:4:a3::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:03:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:03:01 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 02 Sep 2022 03:03:01 +0000 Received: from 50fe2378898e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8B8B40D6-F81E-4EF7-A80C-170BCA451B82.1; Fri, 02 Sep 2022 03:02:50 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 50fe2378898e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:02:50 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DU2PR08MB7327.eurprd08.prod.outlook.com (2603:10a6:10:2e6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:02:47 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::5d27:806b:5d1f:f63]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::5d27:806b:5d1f:f63%2]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 03:02:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2e203e2-2a6b-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Qfh6K46Gp6JhQJDaR6jXyMB1CqOyf++EfiUUI/GLWYQaOmRId4FmBIphqwWzSa7+N2cpu9OgXFAYJPleszUAFRz64mkUw69Nn04Nil1v3vnEkc28PLoaa9zUja01Ry9q0OSvRKO/zHblp9zhwxRoafheYYVjkKeu7W0GRqRXtZzIDcIKAXFwo2HvggGE9Yb1w88+RuUHITNoxcaCl9o9EuEfGIYO2ekZ11f2WIq7LQaGVtJCfG4Jo10K9mQDsSJjd7GMtBtA9xdq5rDE1NdCZGpUXhOunH+2ufAi/lgCaCJxytU2SNeSlaljzTyVWq5yNNPpGfTpeGduY7JjGNPhDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2YK5W2c0+o6jMVXpn2NDPqx4MigGfzXG59s+OIzKNk=; b=WsTUgEuGixDe7tfEPhaymkpv68dvUR/X+HhNkKvp37hqu1oDP2BYz/DOkoHxHn0irP8avQwMsj5uGyq/VMlt5i4za5dz80lgil2jtUVrj4atSyGyKHDWoYAMY8wvEnwfkk8yZHpZoXk1ASCSilvT0XzJnEISbnJGAC5395PK7vM+O6ojWKURrjW2iSMBErSKmve21BiuP4xs1jyDvROVU9EXry9iiJtzedMdlBUCeOdiouJteowYN/u5OcciUD6+hpgzhH6HWjxA0SUtud8TFG4ntytxJ3m+w6WFylz0JE4CHX56BKSZCxtfOdT7yvkC3b9Yn9reJ1Xsb17weNjhtw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2YK5W2c0+o6jMVXpn2NDPqx4MigGfzXG59s+OIzKNk=; b=ALeXvsux7xnikyncx4MY/KcnKW6Mbk47qhc2BOpZ3lIQl8cnBNOAMkGz8THTeklItBU0QbPW3HTy70OI60fn5ELVAe0sWE9nostEE4PxHDxZEy8YlJsNuuvwAr2ItlxcGkyVRNMVdhtaVUSQy9VWKSP8aNsC33m/V9NFsoRicCI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mr1mvuaIECnte4B48EQDAAxrcz1EqDP4WVtsWhK6lemNQLNg3z7KeuVMginJE1Q+q1zHoRg5eW87iDo52JgCXcxfyt8pSShT+NCYFAxeOz9Q5EmBV4JYJ8J7qjZEWBg/gHs8pdbZbq3CVGg5d4hIVEUlA/ubgsrR+mYvH4WgEq0niktfIxItbeuetugZvRtDeubfvLk+TpwetSbSt75sHi9DNDRq3C+JoFG6qTdnYwA+tfcFHLsuZ9EcAcSRlk9TIP29abTDsLlD3q6Pc0ffKMcNWTQa4n8/9H9SYP0qzxxxE8at1n4GZgm20pc+FYR+vocdOLgy+udvJOvnyiZalg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2YK5W2c0+o6jMVXpn2NDPqx4MigGfzXG59s+OIzKNk=; b=XczaPO0uxioQJ+2JFXfnQN7A3y39JQzEtCwj8C0GuncyhthNb6DpruV66t2atIvPRMDzKOlDsFb3rTPhE8xUt2qbsCRGfKpg2Zmsw8N+H64j9xmtuxisSOYI5IF9w5JtO/oXvo8j+ZrjoAfsy7eqtXC84Cre2ootWZrccfyCKzzRIrhGMY6cBmyebfp99R5xpSiFSbdf1VWsx76fN99mxUKJHPE1JlXFzCbyXrRfcIoAMOCHbQ7Xk5NQGDbv1eAO+KJJWivybpa6Wa5uep+AEGmKCKI+6K1+lZ+MCB6NQAmI7K88xotvocNiNzHPLOqwoNRD+IOquMies2/BcS6jKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2YK5W2c0+o6jMVXpn2NDPqx4MigGfzXG59s+OIzKNk=; b=ALeXvsux7xnikyncx4MY/KcnKW6Mbk47qhc2BOpZ3lIQl8cnBNOAMkGz8THTeklItBU0QbPW3HTy70OI60fn5ELVAe0sWE9nostEE4PxHDxZEy8YlJsNuuvwAr2ItlxcGkyVRNMVdhtaVUSQy9VWKSP8aNsC33m/V9NFsoRicCI= From: Wei Chen To: Stefano Stabellini , Julien Grall CC: Henry Wang , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugxTCtO4LgrkGJKD3tY8acia3KwCgAgAAJ8YCAABHIAIAABy8AgACKuYCAAA6DsA== Date: Fri, 2 Sep 2022 03:02:46 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3825349A336EFC4A9ACDAA841306AAA6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d70ff47b-0206-45e3-7b6b-08da8c8fa5af x-ms-traffictypediagnostic: DU2PR08MB7327:EE_|DBAEUR03FT009:EE_|DB9PR08MB7536:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kbnC+2hf4As0b6O7Ah+rQz8YItj8PR+wy3r5EFD3iRCS0h9TtSCpVS5K4kkWhbHfnTwChLi1+kLEnzU2qYTtqp2QtLPG88HeeBqnJVATAx5cqLGgy4QiuSsKK2TC1MhnpCCvy5+Rki4l/8u8IARso/hDIX0wNyeE9bSIvvddx6nxI6PnGEApbNIoueogzi8cJRFiuAQiqrpFZhG648AGCnAGU9UIvMm5FghG7hveZLXy7HgWkeP07k3CxD4cOkUtWETiBEKNx4dEZFyh9Mp7tOe+bvsaZovrn1ou6PKy2qeLJecw/hhEjDlEGki32tfwHRsSF/ZANlaoxSH4yAx/QlPPLZ4ZYp/SWNZ2XoflJdhE0Ol6N5T7gi5z1cPLi0Y4HIuJZxzH1x79+RbKDsItjYdKQPAbD0R6IC4f+WTPGL4w4uRA1asKaxCCC0xNvG66XlSunXqaHbf8W4L47+pBJDZcHCTLQoWRwFOz3Wf7vYj2r2j0cQCBmBD2AEs9sjcWo1DD/bEDsKKSgAkGg2PQ14E97lrfBo3KnuaHbNz6iA/s9cGCgrJchd3G3FtNa7V+RBx2NIPp4gDfQRTtSCGZy4F2/FYbG/jOHBZZpoxACZO0izFrlIpHnHISnzF+vtBbL0ADv71Se8X6ES2y+rNaDAGOhfBoDCer2e+l6jDqgna8f81pypuMe8AB8oAMAwCZAw+L0IiEUjxd49YirCzp71GreO+pwk1ZR889w3uJQZXZ3NY0FE7+9ay/LV0ymDhZGjZaJaklsfwgDQQBNOK2Tg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(53546011)(55016003)(6506007)(7696005)(54906003)(316002)(86362001)(478600001)(9686003)(41300700001)(110136005)(38100700002)(122000001)(186003)(83380400001)(38070700005)(71200400001)(66476007)(66556008)(8676002)(4326008)(66446008)(64756008)(33656002)(8936002)(66946007)(2906002)(52536014)(5660300002)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7327 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5ed802d5-bd84-42c6-2d4a-08da8c8f9d0c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2BFqGsg+JBhhNn4G+oPVhQlT2eGc6OhkVUSZKWHcNTlDCM7Z2NdKxaXYogu3MM0NI1Z96xlD1gaufFJkfPTfr1Crx8+Ortx+xd2LHOgoaGpUxzL2k9ooXmf4ettvdYyBfUB7m2cQhzYPeQLRoHhVhkPxIZNYMriy79znv+nKMkaYycm9U76AkcQcVMi2TMSdojY/itXqNgVmVyhhtA/e+7+NLK6pmef1VYD51Y9rDeO8ZeAnijY2uvIOHCu0TRnT0q3iLGDgTg+IQcdE1LuHaFaEFpobz2PwSgsWZi5/xhZF5gcn7RaFOkrOtbSo2BVB8JlUCvuPL/TfQgCdhDl52e95HeJJmlGdhyLNZeL+oKY9zR2pWt7FqrnoSsGA1lPJOUHvi7OediLfNknXu4bc8+N02dCvzh38b0hZtwMTXhRLOHflIXTkMrAx4ckU1XE2vlXlEyzPwsfsi8wz/eaTqBs/GtvJmiQiPx5sXg+s8lFuYhV69hhSEWt6/88a+sPYLLclRC2XwCZhYi9+XYdSrA/npGmXWTuu/Yt9ef/HHPRzVSpdbJ15BKkNshAIX43lVQ/9Ad2Urva7WSXQEqefSk2Wh6YfJ2BQj8AT0dCxAkIm+HPG3lpgSEjNKwBAGhYsbu8HsYJd7F9+j6OUbNgariVSl7xXa1TCpCMhFD+NLlRnsVxYOVQuPiiB77vpjOKhAsRxEc1U4PocGOpyg81sR3VIJIhDZRiywrTJNnkqZajF4SlLHZ5jzyh79ehAEWk8PCV9N4wIxlQFXesp4GnewQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(396003)(36840700001)(40470700004)(46966006)(5660300002)(36860700001)(83380400001)(9686003)(40480700001)(55016003)(8676002)(40460700003)(478600001)(70586007)(26005)(4326008)(82740400003)(2906002)(33656002)(70206006)(53546011)(356005)(47076005)(86362001)(107886003)(52536014)(316002)(82310400005)(110136005)(81166007)(7696005)(54906003)(6506007)(186003)(336012)(8936002)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:03:01.4143 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d70ff47b-0206-45e3-7b6b-08da8c8fa5af X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7536 SGkgSnVsaWVuIGFuZCBTdGVmYW5vLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gU2Vu dDogMjAyMsTqOdTCMsjVIDk6NTENCj4gVG86IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+ DQo+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBIZW5y eSBXYW5nDQo+IDxIZW5yeS5XYW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdl aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15 cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDIvMl0geGVuL2FybTog SGFuZGxlIHJlc2VydmVkIGhlYXAgcGFnZXMgaW4gYm9vdCBhbmQNCj4gaGVhcCBhbGxvY2F0b3IN Cj4gDQo+IE9uIFRodSwgMSBTZXAgMjAyMiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiA+IEhpIFN0 ZWZhbm8sDQo+ID4NCj4gPiBPbiAwMS8wOS8yMDIyIDE4OjA4LCBTdGVmYW5vIFN0YWJlbGxpbmkg d3JvdGU6DQo+ID4gPiA+ID4gQWxzbywgd2hhdCBoYXBwZW4gd2l0aCBVRUZJPyBJcyBpdCBlYXN5 IHRvIGd1YXJhbnRlZSB0aGUgcmVnaW9uDQo+IHdpbGwgbm90DQo+ID4gPiA+ID4gYmUgdXNlZD8N Cj4gPiA+ID4NCj4gPiA+ID4gRm9yIG5vdyBJIHRoaW5rIGl0IGlzIG5vdCBlYXN5IHRvIGd1YXJh bnRlZSB0aGF0LCBkbyB5b3UgaGF2ZSBzb21lDQo+IGlkZWFzDQo+ID4gPiA+IGluIG1pbmQ/IEkg dGhpbmsgSSBjYW4gZm9sbG93IHRoaXMgaW4gYWJvdmUgZm9sbG93LXVwIHNlcmllcyB0bw0KPiBp bXByb3ZlDQo+ID4gPiA+IHRoaW5ncy4NCj4gPiA+DQo+ID4gPiBGb3IgY2xhcml0eSwgYXJlIHdl IHdvcnJpZWQgdGhhdCB0aGUgcmVnaW9uIGlzIHVzZWQgYnkgdGhlIGJvb3Rsb2FkZXINCj4gPiA+ IGZvciBvdGhlciB0aGluZ3M/IEZvciBpbnN0YW5jZSBVLUJvb3Qgb3IgVGlhbm9jb3JlIHBsYWNp bmcgc29tZQ0KPiA+ID4gZmlybXdhcmUgdGFibGVzIGluc2lkZSB0aGUgcmFuZ2Ugc3BlY2lmaWVk IGZvciB4ZW5oZWFwPw0KPiA+DQo+ID4gWWVzLiBJIHRoaW5rIGl0IHdvdWxkIGJlIGRpZmZpY3Vs dCBmb3IgYW4gYWRtaW4gdG8gZmlndXJlIG91dCB3aGljaA0KPiByZWdpb25zDQo+ID4gYXJlIHVz ZWQuIEFsdGhvdWdoIHRoZXkgYXJlIGxpa2VseSAoPykgZ29pbmcgdG8gYmUgc3RhdGljIGZvciBh IGdpdmVuDQo+ID4gVUVGSS9VLWJvb3QgYnVpbGQuDQo+ID4NCj4gPiBNeSBtYWpvciBjb25jZXJu IGlzIHN1Y2ggYnVnIGNhbiBiZSB2ZXJ5IGRpZmZpY3VsdCB0byByb290IGNhdXNlIGJlY2F1c2UN Cj4gd2UNCj4gPiBoYXZlIG5vIHNhZmV0eSBpbiBYZW4uIFRoZSBtb3N0IGxpa2VseSBzeW1wdG9t IHdvdWxkIGJlIHJhbmRvbQ0KPiBjb3JydXB0aW9uLg0KPiANCj4gVGhhbmtzIGZvciB0aGUgY2xh cmlmaWNhdGlvbi4gWWVhaCwgSSB0aGluayB3ZSdsbCBoYXZlIHRvIGRvIHNvbWUNCj4gImNyZWF0 aXZlIHRoaW5raW5nIiB0byBmaWd1cmUgb3V0IGEgc29sdXRpb24gdG8gdGhpcyBpc3N1ZS4gSSB3 b25kZXIgaWYNCj4gVS1ib290IG9yIFRpYW5vY29yZSBoYXZlIHNvbWUgc29ydCBvZiBBUEkgKG9y IGJ1aWxkLXRpbWUgZGF0YSkgdG8ga25vdw0KPiB0aGUgdW5hdmFpbGFibGUgcmFuZ2VzLg0KPiAN Cg0KV2hlbiBYZW4gaXMgYm9vdGVkIHRocm91Z2ggRUZJLCBhbGwgdGhlIG1lbW9yeSBzdGF0aWNh bGx5IGRlZmluZWQgaW4gdGhlDQpEZXZpY2UgdHJlZSBoYXMgYSBjZXJ0YWluIHByb2JhYmlsaXR5 IG9mIGNvbmZsaWN0aW5nIHdpdGggdGhlIG1lbW9yeSBvY2N1cGllZA0KYnkgRUZJLiBUaGlzIGlz IGRpZmZpY3VsdCB0byBhdm9pZCB3aXRob3V0IHRoZSBFRkkgYm9vdGxvYWRlciBpbnRlcnZlbmlu ZywNCmJ1dCBpdCBpcyBwb3NzaWJsZSB0byBkZXRlY3Qgc3VjaCBhIGNvbmZsaWN0Lg0KDQpGb3Ig RUZJIHJlc2VydmVkIG1lbW9yeSByZWdpb25zIChsaWtlIHJ1bnRpbWUgc2VydmljZSksIHRoZXkg d2lsbCBub3QgYmUNCnJlcG9ydGVkIGFzIHVzYWJsZSBtZW1vcnkgdG8gWGVuLiBUaGUgdXNhYmxl IG1lbW9yeSByZWdpb25zIHdpbGwgYmUgYWRkZWQNCnRvIGJvb3RpbmZvLm1lbWJsayBhcyBkZXZp Y2UgdHJlZSBib290LiBTbyBJIHRoaW5rIGFsbCBzdGF0aWMgZGVmaW5lZCBtZW1vcnkNCnJlZ2lv bnMgd291bGQgYmUgY2hlY2sgd2l0aCBib290aW5mby5tZW1ibGsgdG8gZmluZCB0aGUgY29uZmxp Y3QuDQpGb3IgRUZJIHJlbG9jYXRlIFhlbiBhbmQgRFRCLCBJIHRoaW5rIFhlbiBpdHNlbGYgY2Fu IGtub3cgdGhlc2UgYWRkcmVzc2VzDQplYXNpbHkgYW5kIGVhc3kgdG8gY2hlY2suDQoNCkJ1dCBp ZiB3ZSBkb24ndCBhZGQgY29kZSB0byB1Ym9vdCBvciBFREsyLCB3aGF0IGNhbiB3ZSBkbyBhcmUg anVzdCBjaGVjaywNCnByaW50IGVycm9yIGFuZCBwYW5pYy4gQnV0IHN0YXJ0aW5nIGZyb20gdGhl IGFjdHVhbCB1c2FnZSBzY2VuYXJpbywgYmVjYXVzZQ0KdGhlIHNjZW5hcmlvcyB1c2luZyBzdGF0 aWMgaGVhcCBhcmUgbm9ybWFsbHkgaGlnaGx5IGN1c3RvbWl6ZWQsIHRoZWlyIEVGSQ0KZmlybXdh cmUgd2lsbCBieXBhc3MgdGhlIHN0YXRpYyBtZW1vcnkgd2UgZGVmaW5lZCBpbiBkZXZpY2UgdHJl ZSB3aGVuDQpjdXN0b21pemluZy4gU28gbWF5YmUgY2hlY2sgY29uZmxpY3QgaXMgZW5vdWdoPw0K DQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IEluIGFueSBjYXNlLCBJIHRoaW5rIHdlIGNhbiBwb3N0 cG9uZSB0byBhZnRlciB0aGUgcmVsZWFzZS4NCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:07:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397214.637703 (Exim 4.92) (envelope-from ) id 1oTx1u-00006U-JT; Fri, 02 Sep 2022 03:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397214.637703; Fri, 02 Sep 2022 03:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTx1u-00006N-Go; Fri, 02 Sep 2022 03:07:38 +0000 Received: by outflank-mailman (input) for mailman id 397214; Fri, 02 Sep 2022 03:07:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTx1s-00006H-Ll for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:07:36 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2045.outbound.protection.outlook.com [40.107.22.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64875f15-2a6c-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 05:07:35 +0200 (CEST) Received: from DB8PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:10:110::37) by VE1PR08MB5821.eurprd08.prod.outlook.com (2603:10a6:800:1b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 03:07:31 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::73) by DB8PR04CA0027.outlook.office365.com (2603:10a6:10:110::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15 via Frontend Transport; Fri, 2 Sep 2022 03:07:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:07:31 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Fri, 02 Sep 2022 03:07:31 +0000 Received: from 6a6eac66f970.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 664555D0-A67E-4FFB-B46B-86BE1885F15A.1; Fri, 02 Sep 2022 03:07:20 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6a6eac66f970.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:07:20 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB8289.eurprd08.prod.outlook.com (2603:10a6:10:3df::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 2 Sep 2022 03:07:19 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::5d27:806b:5d1f:f63]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::5d27:806b:5d1f:f63%2]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 03:07:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64875f15-2a6c-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=n6CvM+eRpKSXCVZfG2KQQGm928BlW+PwNosYnhyYndjaoiljlZLWJDM39U/48hmvxjvF8BTZNeHi8Rcmq1h5jsnikK6mj+wbwZu0ueRQSu3kP7g57P7j5P6hIT6R9DwC+9wCl2rbCSqQmM03D9+oweahwQOtfMzuGNVMkZxEJm6ztjvkm4Flc3o261BGnihA7SUA8wtX4io/nybh5wTF96VXR39E/RWeCBDMdvjdGpQp4ebnGj2Uceg3q8+Y8iyXZfK2mFf6Ma93vuKf19xL5C3mrB7+34Yn53sWAgP2MoENRSgTPI3ziaf1lwyuJ8rdd207BYQo7IiPmyt6QgxJ6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G4Dymhsu7LGon53cRf6RwyPQomTyik1zHLqeRrrtoGk=; b=OhyF8zK5tmtS4klxDrXFdR4FQFztFlTAHTET1jeQZ9+jLYY4vONiLl/nU06H0N7jC1EmNGvkXpP7e89iOOnVxgZ7+MSO1UzkTR2jhsjoDPvpBZrQKwbmqpZJHrAeyMoGbmdSyx6zRczvnqC6ZwmcH6cX3yufIoBDN5xzlKfZTMR0i7T080krj786ftQ2L8jBGc8xSTJLYC11Z/AG3zNuyiQ8asSxsyn+m2lZjXuNb0zZnKIrwJpUv7INFfoJs1NyzTeZtYnCJ/Bzrijp0nl+pvUfSs/eUBWA6L149Nzd3AnojvS86jhhcCUCovNHONIAbGRGToV75X08RxIqjWtdeg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G4Dymhsu7LGon53cRf6RwyPQomTyik1zHLqeRrrtoGk=; b=dCz49n43cEUI4Rz1va5mjSfRzCKhddiqTvm0Ojo99cIHcafTJDUTunYLfWRLUo1/vmMUdavWPGHPnY1g75xZyXEdZmNobp/LisZRCewgBoojXlG7QXe+d39c2PzNPRO3dF6dgMHrVMv0cyRUTsMZsIT/DBjQGr0PJa/bwuAaGpQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7xve+M3MFuJpCAqWvZmtTM5cK7whB16EMb4IPkJyIPKFL8A+vNB79/SCx8qLotLsjxFWYc5WIu+jnqJQl7hApEbgRx/bdijIjRiAyA4dk6aVGy6/LpXcoS6nAdzX3CbRBKb0vyDa72+uGyhqo42ab4qktF7s5GCveEnncJUoa1plCkpTha3GMD82fiFqx2RLktzQIFSkbfOY2bGG48p4yrefmuR4tz81uQOgZ2Dh7gh4OvTltnBMktjWW/Dp6g1s1Z33y7g+vo/bfc+kQnejNQCscyDGPJb+xv6LdAXda0lIWuMAZ+GgugG2p76O2LYa/+qxYbk5bH9t2BMZyDo4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G4Dymhsu7LGon53cRf6RwyPQomTyik1zHLqeRrrtoGk=; b=KRWB+frtcBWRvVlAqjQnr81nmae884sZQugK6Gr9BTEMum9HQaEwos+w4Wy4UH+a29aowLM0boYt7lyzPdTtQu1vjeVXOrOGJEGEF3OXG+D1j41N+KkQrBErKvTPCuRExmUrSapzD1Db0bPHUkYxoP1/ISQUDmDCciuxwf90gIds+280XzDBAspEaDr76PFZO/0eJkXb2FyHkOk+7smVhE5DFMEeSG07VkomtBKJI8Le9+4giOhwpD+UTInyQfBh8oFxtDR6M78c7sehzez7QzotY2ssQrAFMddVPFMer/sTEWPFKzn5NwljxUdel4Gri3oUTNSkhwKf9O2M55Ad+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G4Dymhsu7LGon53cRf6RwyPQomTyik1zHLqeRrrtoGk=; b=dCz49n43cEUI4Rz1va5mjSfRzCKhddiqTvm0Ojo99cIHcafTJDUTunYLfWRLUo1/vmMUdavWPGHPnY1g75xZyXEdZmNobp/LisZRCewgBoojXlG7QXe+d39c2PzNPRO3dF6dgMHrVMv0cyRUTsMZsIT/DBjQGr0PJa/bwuAaGpQ= From: Wei Chen To: Wei Chen , Stefano Stabellini , Julien Grall CC: Henry Wang , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugxTCtO4LgrkGJKD3tY8acia3KwCgAgAAJ8YCAABHIAIAABy8AgACKuYCAAA6DsIAABhiw Date: Fri, 2 Sep 2022 03:07:19 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4F331DF260D8AF4483BC9C2AA766D366.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1a983f6b-eea1-4a83-e707-08da8c904678 x-ms-traffictypediagnostic: DB9PR08MB8289:EE_|DBAEUR03FT042:EE_|VE1PR08MB5821:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: p6QK5/0dPBTjpUHN4Viaagp8NllUZOljhdz/dsTKRc9lBTClKFexeijXc1bNBqhrrnwvhXBsmzVJKc8I0JcrBFZriVmIFgmU5bpjiSNsEfkKLNlBLcJGyIJXtoVKG9Hiqi0dEychr/ERx3fx+6M4d9ciHrqMVbu78Mr8MnLf1jyG+mU9yYG1dr5ZV/EI+5UeeY3t9tBTJ0aZtvdSV/fyzytUrs7939jdfBfBP0IQI5O4Vrpna4r4l37z/+gU0INv1Cz+q20cu3AxLuBv7/hG7WYOP8OfU0IzW4mFLEpJXcfONvzpA4y4wC1KIT+v/OAx5NZ5uLIpZMrYDlmXVMnezh4z/Us+jW92NpA/r9LUB6cuD6z415KE4jF53psl3U8tnWni18qSPl21f+5l6OVQXdqiNlqSGRIxcUMJnvgxOMrExJ06fxaIgvRMfJCerz94oGFu1QlfU22afmtzITUHWDY/HZV98vlqxjC3OVFXILx+DAGVFQAeVVB6jKX7Tv8HQq7kcV8B5Rmn+tNjlZdAwDdfuPlA30Lzbd/IjC2Mh73yH+D3Jx6eO3TMBM/1SMPiYQ0utC4U93MvHrIPaK670n4uZ30lOdhT5NqMLkv9AqjDNB8jLs6HVe7W+rcINlXQGDUQZlgSXPMY4E6bAC6UKwGCdXDeDV2cQ1ZHtk8P43Nhk5Pt9CgqtFQd6FejegRyGv0ZMtWyTougouR2lwBDLqZjdDEfJ8wS2mRtdL9T2SqVQ6CMSRntOnW5KUYM5qSp/+O8Z/C2DoV5NKoXUPB5Og== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(366004)(396003)(376002)(66476007)(2906002)(52536014)(38100700002)(83380400001)(4744005)(8936002)(316002)(186003)(478600001)(5660300002)(8676002)(4326008)(64756008)(71200400001)(53546011)(2940100002)(54906003)(41300700001)(110136005)(66556008)(122000001)(76116006)(6506007)(9686003)(7696005)(33656002)(66946007)(86362001)(38070700005)(66446008)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8289 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 35fc76c1-988f-4034-4e78-08da8c903f9a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d7GR5YzCa+/oPZaMAYLrK+1Kwe7r+jIqVj74TljRB/exGOHBZqrNrHZ8koQQERzkgF4bbeAF+yxKBsSVAc/iGjTZtQKvOMZjJS0guxwayWFFaX7hEAJJCqz9dH1SWsRio8F/RqouNou4V25g0typJhwQNau+CPWjEQrHw2A8u6JuOM3kaGU+UnXf2nJ/LNb9RtHzR//jDntpcsuJTYiVGzKG00S7DuoBx8gZH6D5WQFfQD9c+eMkonB10iuH5lOm4sjUK5/gtuqrVupaMmwi4vK/43B5x3ktXutsGL/ggYAJVAtc9PZXpX46M1NfepqPDqJOKYYQHIW4DDioL9POq57GDl+uOcOzGj8aql9WnK5ZCyozInoSjsRyaI3WMnuxJ7DfsdTAwh0aMS1Ma6Nzvfws5hZ36U7TbxZF/5k90jSfoKW4RqmMezErDh23yI3+z1ZpWVVJ5Pant6pvkFkw/2vHp8xggEJ0j7UFPQVPbO116TE0dscEs4ASw6vdjeGF/6jYPm8BWs4EpsQD1EpazwtF43xm8+JoA7k8CDP9x1V43mJ4JKr7zVTmGZtPpt0PYcd27RhhkeyfQ3l6Q2JgAhJXI7xUBLkjIaS8kZxV0CC9EmAH1en/NOpjgAwzc1MhzFDFjMUwUgCbq9d4wrR35y3s+JNfR7S6GILIexmdMltMgRhy0c/xznT9VX/NjPqzjY88Wj9jnYxyv9KehiJ0crpDTyNjkwc32iRg3HIsTVZ4rYhq4VnqRWTcFMG2TKmgjewBlrCsOkyAWkOnOGgXZA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(36840700001)(46966006)(40470700004)(5660300002)(8936002)(41300700001)(55016003)(70206006)(70586007)(4326008)(52536014)(82740400003)(33656002)(40480700001)(8676002)(83380400001)(7696005)(86362001)(81166007)(186003)(6506007)(107886003)(9686003)(336012)(356005)(53546011)(40460700003)(2906002)(26005)(2940100002)(54906003)(110136005)(36860700001)(478600001)(47076005)(316002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:07:31.1698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a983f6b-eea1-4a83-e707-08da8c904678 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5821 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRldmVsIDx4ZW4t ZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mIFdlaQ0KPiBD aGVuDQo+IFNlbnQ6IDIwMjLE6jnUwjLI1SAxMTowMw0KPiBUbzogU3RlZmFubyBTdGFiZWxsaW5p IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsDQo+IDxqdWxpZW5AeGVuLm9y Zz4NCj4gQ2M6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZzsNCj4gQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bh cm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29t Pg0KPiBTdWJqZWN0OiBSRTogW1BBVENIIDIvMl0geGVuL2FybTogSGFuZGxlIHJlc2VydmVkIGhl YXAgcGFnZXMgaW4gYm9vdCBhbmQNCj4gaGVhcCBhbGxvY2F0b3INCj4gDQo+IEhpIEp1bGllbiBh bmQgU3RlZmFubywNCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9t OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+ID4gU2VudDog MjAyMsTqOdTCMsjVIDk6NTENCj4gPiBUbzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4N Cj4gPiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgSGVu cnkgV2FuZw0KPiA+IDxIZW5yeS5XYW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBWb2xvZHlteXINCj4gQmFiY2h1aw0KPiA+ IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDIv Ml0geGVuL2FybTogSGFuZGxlIHJlc2VydmVkIGhlYXAgcGFnZXMgaW4gYm9vdCBhbmQNCj4gPiBo ZWFwIGFsbG9jYXRvcg0KPiA+DQo+ID4gT24gVGh1LCAxIFNlcCAyMDIyLCBKdWxpZW4gR3JhbGwg d3JvdGU6DQo+ID4gPiBIaSBTdGVmYW5vLA0KPiA+DQo+IA0KPiA+IEluIGFueSBjYXNlLCBJIHRo aW5rIHdlIGNhbiBwb3N0cG9uZSB0byBhZnRlciB0aGUgcmVsZWFzZS4NCg0KTWF5YmUgd2UgY2Fu IGFkZCBzb21lIG5vdGVzIHRvIHNheSB0aGF0IHRoaXMgZmVhdHVyZSBpcyBzdGlsbA0KZXhwZXJp bWVudGFsIGluIEVGSSArIERUUyBib290Pw0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:26:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397225.637721 (Exim 4.92) (envelope-from ) id 1oTxKW-0002aT-CE; Fri, 02 Sep 2022 03:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397225.637721; Fri, 02 Sep 2022 03:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxKW-0002aM-8j; Fri, 02 Sep 2022 03:26:52 +0000 Received: by outflank-mailman (input) for mailman id 397225; Fri, 02 Sep 2022 03:26:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxKV-0002aG-8U for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:26:51 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13d39978-2a6f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:26:49 +0200 (CEST) Received: from DB8PR09CA0032.eurprd09.prod.outlook.com (2603:10a6:10:a0::45) by PA4PR08MB6238.eurprd08.prod.outlook.com (2603:10a6:102:e8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:26:46 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::97) by DB8PR09CA0032.outlook.office365.com (2603:10a6:10:a0::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Fri, 2 Sep 2022 03:26:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:26:46 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Fri, 02 Sep 2022 03:26:46 +0000 Received: from 9bed2a2855fb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F014644F-02A0-496E-88C9-0B220B44554F.1; Fri, 02 Sep 2022 03:26:35 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9bed2a2855fb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:26:35 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by PAWPR08MB9098.eurprd08.prod.outlook.com (2603:10a6:102:342::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Fri, 2 Sep 2022 03:26:34 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20%7]) with mapi id 15.20.5588.012; Fri, 2 Sep 2022 03:26:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13d39978-2a6f-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iCzPFQzzb+wzYfjDbGf3wZNsWjJl2c/2ynBlPEoL6G1gDTDrnk3qlk2zgATyMvYInScQ7M1vu0ak3XtKo2//qOF/V3g1bb/y8zHgphRpACtGd0o0RbzvhLvq14DAZt1kqMeKZYgx0tjxyT1gAAMdf1VdQ+7Bs/76jXLju7vN/1MibD8exJO94ByKZNl6yLfZSYqLDGnCgYyW8dlPZVEz9ovpShtY9eWt6WxnzBdMyxeWJjLksrg+8mtYgZBAvRKcGSei3tP5zfwo1GVuB/D9GoXcd3JUZsHPRW/Un/tiQMXnftpDNtb1rD/FLy7JclC1RvCvu+8dhiwMiDSBQLCscQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aXVqFggeAI10CnlEnx3E1YjQaDN/L131D7NPhJhQZCk=; b=JEJOYCqgT9fhaF8NIfBmkRvJ4ue13V/7KlT0ZnSUzGFvgMP/f1WMMiVfE8OjpjuRlyke/s4x4lWw8sQPDYd9d6y8NfLknUsJ7Uevne1ofeWRc9o1IVpYvrsQ8c+9PuhHbgfJfPsxp+tdW1EshLHYEAW9G31S/iBOPqZ82bHmb+NnfWeErIGTZPBc86kMB2Uz7RQeAHST7eUIUo9nyHBrKegDDu7B5/R3M0ME8pi0RGF/tskfVMATP8ZEsgm1OadFXdHr9aWTLDonskI6cu4KzaUHvaJ5edABoIXegSZD+zszde+N7Dw8EVeGvCd0eU7kROL9Z1ZjbrSgIECWkGLDBg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXVqFggeAI10CnlEnx3E1YjQaDN/L131D7NPhJhQZCk=; b=yA1BAwF+s0ex8EGnflQEqKExNO/WqFGQ6kT44OQvJoo1dFb8sCHLxqh4Op2vVl1szTO0kq+EYVt3L/oHCV5YPgo9UzZKm3Obxx6tbjy/v+WSfi6t08xuolQ9zP+5gGB0rRA1/lsjq3Jt/EeYHlKo4I7elt7IHSyl5uCGIm/jR80= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nv2SAnm6H4SLYkGmStkB/qdfS+MBUnx0TNToQGgBN4rK3cWSCQyJXks9lxI1fvl8K8u24e2IZCjqJ3MIIFF8pi+yVt7HC3clYtYV+WWAa600BX6XN68eWVupCBYIqoqNPlmAU/NtsSHaRhS3hQ5Q7fLtalefUrMQ3yfyAkqSgxHwKFUq8DGOaNnMsKpkTibbRVKOhVmwZG9+9JC3vZZOVfzfIqXK8VOqD2H+mUHCysH4FtPNIgG5PbZeZ8f0MxDPOhthsIKYh0Ax/5ie3Fk8j7wskNHLt0sjdSqk/+/bYyl5+Mcd/khmOfSImQ4c1OetbFLKpFSozMvWV+CCCNbIWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aXVqFggeAI10CnlEnx3E1YjQaDN/L131D7NPhJhQZCk=; b=XKUdMiFANikdHBi0ySiprtZqLJuWApph+y8xM2rD9T/AkpeFA3FMBJ/QGCY7IzCqy0/4SxIEOrgM35TFVS9H1F7hvKvfuObiKQVvAin3B+K1gksqPhFQoRRg8RJa7C0hA0HExdEqfkMRF1RlF0r0PDCovUABh5i/BgNkJV4rmzmmGygukmJDXVhjz0M77Cd1MqDBMlQ64BlP3kj14Bn8fQUGMH3ALGmwiYED+ar0R+ZVLsdPkXG+3sYT1y1IbQnhH5ADHUfTR/gNTt9kg8lTk9fggdrt1I7efyqBLfQ0rfFRgc8wx5O6dJOB+XSQ/6FrbiEituOgezAm98Yb99sDnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXVqFggeAI10CnlEnx3E1YjQaDN/L131D7NPhJhQZCk=; b=yA1BAwF+s0ex8EGnflQEqKExNO/WqFGQ6kT44OQvJoo1dFb8sCHLxqh4Op2vVl1szTO0kq+EYVt3L/oHCV5YPgo9UzZKm3Obxx6tbjy/v+WSfi6t08xuolQ9zP+5gGB0rRA1/lsjq3Jt/EeYHlKo4I7elt7IHSyl5uCGIm/jR80= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 1/9] xen/arm: introduce static shared memory Thread-Topic: [PATCH v6 1/9] xen/arm: introduce static shared memory Thread-Index: AQHYnQTR3P1Hf4Rlc0O1VRJveInV4K3BYj8AgARCxICABVMrAIAAtVaA Date: Fri, 2 Sep 2022 03:26:33 +0000 Message-ID: References: <20220721132115.3015761-1-Penny.Zheng@arm.com> <20220721132115.3015761-2-Penny.Zheng@arm.com> <3b58faef-d87d-3381-f54d-8ccdc0ea105f@xen.org> In-Reply-To: <3b58faef-d87d-3381-f54d-8ccdc0ea105f@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 86737EBE24B9304BABD3CD5BCA0D2460.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 93ab6402-fc02-481b-b80b-08da8c92f6f8 x-ms-traffictypediagnostic: PAWPR08MB9098:EE_|DBAEUR03FT014:EE_|PA4PR08MB6238:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IxLm17OxFUp354HwzQ+7DQEbUGQNTt1KSwgvDKH5mgd5xJ5QcWKGGPHd+OpBkOZvQD5sg939slF69IrUJ8lk927GhXSNodj67yjDNt4cOozd4auIrbQDz+6mEvdsEJdohvuJWO3Yi98Efkj5/zuHI11snocSM6W+P0HlSBvBsdCQN/RI77XtTQUw8oI5GOO2Zni0rNjTeNVBVJFZtvDdqdlgQVXvTPMwqpcxXi49wadpQ3Q954lxrl7ETCZrENINIeirk27IC1P/6V7q16ROWUMgq//MMFYQ63cHL4XJ1X3l6PiT9iFJ7s1ktNN6igmGws9uoR4J6xZQnre2nqljjySJNIX/T0W7rsflU2qpSKbBeHxrdiI0pp7URd+NogiHcUygQluv2JHmT8Z4HOAmCtG1OqbfKLUjUVNtO9DgXx6iv/33H+OFgSpkICPrCmEJwl/YrAZOe7p2QlC/fEkHt3nVJqLuf+wq9LXlCWFZ4JVxqLjAyq4Vr4i1L7bwhoWXMEiIiDQdg4+pd+JuqBzoj9TmzscdM4WbkPAAP9N7HTOSIK+cbNbQLjgt70haAfDSrDoVfSwVnqYYDlL+GYHTinvwgLk/Ge5VuGnwZdFtM09Culen7GF2gYiOLuxeoQ/Wnx6tiUrd3VXimjc2SgvTfBlSF0EBmv5QnS05bsv7JvhOGXXYop+0BmZzJ7sGqmoI1Xg7vsT1GuKsvxBZBWE/oTj4KFYqk/IJKG7cXGFIIZkB5VXFHarais8Q2YzZSJFwqK77E7ooYsqiXKiJ0MUWaw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(66446008)(122000001)(55016003)(38070700005)(86362001)(66946007)(5660300002)(478600001)(76116006)(8676002)(64756008)(4326008)(66476007)(110136005)(8936002)(38100700002)(52536014)(41300700001)(33656002)(54906003)(71200400001)(316002)(186003)(9686003)(6506007)(53546011)(7696005)(66556008)(26005)(83380400001)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9098 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ae63817-3f02-488c-95ce-08da8c92efae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5IH5OQiHcbmn79bHaDUN2Pe/AsKqc4trL1NZRe8g7CHL5ze6zaL3vz5QxcaYGCz1xdS4TQAJmh5FECJIuOautyJYM2qFM471ZzI8jDsJhzS0Kyg1tsYDqdg7CCEbcR+jebiv11FylI/2cxz616Oc80qcLKgX2jpKfeMz4n27vHGnuP2cZ+rSOzLBipYW08qrjFWBTYfp7bwx04VxPFsNGORM0kAo+fuq8FQU7rxjHmsw34q+xHJXd9Di5ajF50n3rHqlGuBc6donwxhbafLF7lTWBqP2st+tIpmEBHFi4v5PEoMs9W/8Nh3q/zXIuCUP6Ldh5ykOSMrmpBklpCVraGiSkdYweX/5Dbora0cR9z+nrLGvgviRuZb3GxhtPZ8cjlWIgGxwxa620vK4IRwM3Ddrh8r3P+ToJSMuXredvPAdQP1H8F+LcXG70qdljc0B8M8lQQKwNHsdNOP8qEU4y9nzZS4bfnqCq/URaaBU7buEdG8RtMvqgCmIk391pAo/kvhmS4TtLcSfQ0geRok/irLaKFuZNvk/iBaUj2ULRbvVeGwh0IByYbWZUj1Vdbx0RSBXvhcbFZwxUonFwqUZq+2MqX7LiaMKfOPF9u07ECfJsL29j5MAG5x2arBLftGfvrfFFCCmcpUFGn5w2RWYbKTdvPhTosiHJeu+sA887/E+SR8ZAi48AzLI+vmLwFf4goN0zdJEJw2LtHd54Xn+0j9PNH56yjHRHagE8HOlnUOs3iJSWE3A9FrMisfx6Sfb5rXZffbEFw/qP+xT5aaT5g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(376002)(396003)(46966006)(40470700004)(36840700001)(9686003)(6506007)(47076005)(7696005)(26005)(336012)(186003)(40480700001)(52536014)(53546011)(8936002)(5660300002)(33656002)(107886003)(41300700001)(86362001)(478600001)(36860700001)(83380400001)(356005)(81166007)(54906003)(110136005)(82310400005)(2906002)(316002)(40460700003)(82740400003)(55016003)(4326008)(8676002)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:26:46.2799 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93ab6402-fc02-481b-b80b-08da8c92f6f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6238 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAxLCAy MDIyIDExOjQwIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxz c3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFy cXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVw YW0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY2IDEvOV0geGVuL2FybTogaW50cm9kdWNl IHN0YXRpYyBzaGFyZWQgbWVtb3J5DQo+IA0KPiBIaSBQZW5ueSwNCj4gDQo+IE9uIDI5LzA4LzIw MjIgMDc6NTcsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut LS0tLQ0KPiA+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA+PiBTZW50 OiBGcmlkYXksIEF1Z3VzdCAyNiwgMjAyMiA5OjE3IFBNDQo+ID4+IFRvOiBQZW5ueSBaaGVuZyA8 UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcN Cj4gPj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJl cnRyYW5kIE1hcnF1aXMNCj4gPj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15 ciBCYWJjaHVrDQo+ID4+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gPj4gU3ViamVj dDogUmU6IFtQQVRDSCB2NiAxLzldIHhlbi9hcm06IGludHJvZHVjZSBzdGF0aWMgc2hhcmVkIG1l bW9yeQ0KPiA+Pg0KPiA+PiBIaSBQZW5ueSwNCj4gPj4NCj4gPg0KPiA+IEhpIEp1bGllbg0KPiA+ DQo+ID4+IE9uIDIxLzA3LzIwMjIgMTQ6MjEsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+Pj4gRnJv bTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4+Pg0KPiA+Pj4gVGhpcyBw YXRjaCBzZXJpZXMgaW50cm9kdWNlcyBhIG5ldyBmZWF0dXJlOiBzZXR0aW5nIHVwIHN0YXRpYyBz aGFyZWQNCj4gPj4+IG1lbW9yeSBvbiBhIGRvbTBsZXNzIHN5c3RlbSwgdGhyb3VnaCBkZXZpY2Ug dHJlZSBjb25maWd1cmF0aW9uLg0KPiA+Pj4NCj4gPj4+IFRoaXMgY29tbWl0IHBhcnNlcyBzaGFy ZWQgbWVtb3J5IG5vZGUgYXQgYm9vdC10aW1lLCBhbmQgcmVzZXJ2ZSBpdA0KPiA+Pj4gaW4gYm9v dGluZm8ucmVzZXJ2ZWRfbWVtIHRvIGF2b2lkIG90aGVyIHVzZS4NCj4gPj4+DQo+ID4+PiBUaGlz IGNvbW1pdHMgcHJvcG9zZXMgYSBuZXcgS2NvbmZpZyBDT05GSUdfU1RBVElDX1NITSB0byB3cmFw DQo+ID4+PiBzdGF0aWMtc2htLXJlbGF0ZWQgY29kZXMsIGFuZCB0aGlzIG9wdGlvbiBkZXBlbmRz IG9uIHN0YXRpYyBtZW1vcnkoDQo+ID4+PiBDT05GSUdfU1RBVElDX01FTU9SWSkuIFRoYXQncyBi ZWNhdXNlIHRoYXQgbGF0ZXIgd2Ugd2FudCB0byByZXVzZSBhDQo+ID4+PiBmZXcgaGVscGVycywg Z3VhcmRlZCB3aXRoIENPTkZJR19TVEFUSUNfTUVNT1JZLCBsaWtlDQo+ID4+PiBhY3F1aXJlX3N0 YXRpY21lbV9wYWdlcywgZXRjLCBvbiBzdGF0aWMgc2hhcmVkIG1lbW9yeS4NCj4gPj4+DQo+ID4+ PiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gPj4+ IC0tLQ0KPiA+Pj4gdjYgY2hhbmdlOg0KPiA+Pj4gLSB3aGVuIGhvc3QgcGh5c2ljYWwgYWRkcmVz cyBpcyBvbW1pdGVkLCBvdXRwdXQgdGhlIGVycm9yIG1lc3NhZ2UNCj4gPj4+IHNpbmNlIHhlbiBk b2Vzbid0IHN1cHBvcnQgaXQgYXQgdGhlIG1vbWVudA0KPiA+Pj4gLSBhZGQgdGhlIGZvbGxvd2lu ZyBjaGVjazogMSkgVGhlIHNobSBJRCBtYXRjaGVzIGFuZCB0aGUgcmVnaW9uDQo+ID4+PiBleGFj dGx5IG1hdGNoDQo+ID4+PiAyKSBUaGUgc2htIElEIGRvZXNuJ3QgbWF0Y2ggYW5kIHRoZSByZWdp b24gZG9lc24ndCBvdmVybGFwDQo+ID4+PiAtIGNoYW5nZSBpdCB0byAidW5zaWduZWQgaW50IiB0 byBiZSBhbGlnbmVkIHdpdGggbnJfYmFua3MNCj4gPj4+IC0gY2hlY2sgdGhlIGxlbiBvZiB0aGUg cHJvcGVydHkgdG8gY29uZmlybSBpcyBpdCBiaWcgZW5vdWdoIHRvDQo+ID4+PiBjb250YWluICJw YWRkciIsICJzaXplIiwgYW5kICJnYWRkciINCj4gPj4+IC0gc2htX2lkIGRlZmluZWQgYmVmb3Jl IG5yX3NobV9kb21haW4sIHNvIHdlIGNvdWxkIHJlLXVzZSB0aGUNCj4gPj4+IGV4aXN0aW5nIGhv bGUgYW5kIGF2b2lkIGluY3JlYXNpbmcgdGhlIHNpemUgb2YgdGhlIHN0cnVjdHVyZS4NCj4gPj4+ IC0gY2hhbmdlICJucl9zaG1fZG9tYWluIiB0byAibnJfc2htX2JvcnJvd2VycyIsIHRvIG5vdCBp bmNyZW1lbnQgaWYNCj4gPj4+IHRoZSByb2xlIGlzIG93bmVyIGluIHBhcnNpbmcgY29kZQ0KPiA+ Pj4gLSBtYWtlICJ4ZW4sc2htX2lkIiBwcm9wZXJ0eSBhcyBhcmJpdHJhcnkgc3RyaW5nLCB3aXRo IGEgc3RyaWN0DQo+ID4+PiBsaW1pdCBvbiB0aGUgbnVtYmVyIG9mIGNoYXJhY3RlcnMsIE1BWF9T SE1fSURfTEVOR1RIDQo+ID4+PiAtLS0NCj4gPj4+IHY1IGNoYW5nZToNCj4gPj4+IC0gbm8gY2hh bmdlDQo+ID4+PiAtLS0NCj4gPj4+IHY0IGNoYW5nZToNCj4gPj4+IC0gbml0IGZpeCBvbiBkb2MN Cj4gPj4+IC0tLQ0KPiA+Pj4gdjMgY2hhbmdlOg0KPiA+Pj4gLSBtYWtlIG5yX3NobV9kb21haW4g dW5zaWduZWQgaW50DQo+ID4+PiAtLS0NCj4gPj4+IHYyIGNoYW5nZToNCj4gPj4+IC0gZG9jdW1l bnQgcmVmaW5lbWVudA0KPiA+Pj4gLSByZW1vdmUgYml0bWFwIGFuZCB1c2UgdGhlIGl0ZXJhdGlv biB0byBjaGVjaw0KPiA+Pj4gLSBhZGQgYSBuZXcgZmllbGQgbnJfc2htX2RvbWFpbiB0byBrZWVw IHRoZSBudW1iZXIgb2Ygc2hhcmVkIGRvbWFpbg0KPiA+Pj4gLS0tDQo+ID4+PiAgICBkb2NzL21p c2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0IHwgMTI0ICsrKysrKysrKysrKysrKysrKysr DQo+ID4+PiAgICB4ZW4vYXJjaC9hcm0vS2NvbmZpZyAgICAgICAgICAgICAgICAgIHwgICA2ICsN Cj4gPj4+ICAgIHhlbi9hcmNoL2FybS9ib290ZmR0LmMgICAgICAgICAgICAgICAgfCAxNTcgKysr KysrKysrKysrKysrKysrKysrKysrKysNCj4gPj4+ICAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9zZXR1cC5oICAgICAgfCAgIDkgKysNCj4gPj4+ICAgIDQgZmlsZXMgY2hhbmdlZCwgMjk2IGlu c2VydGlvbnMoKykNCj4gPj4+DQo+ID4+PiBkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9kZXZp Y2UtdHJlZS9ib290aW5nLnR4dA0KPiA+Pj4gYi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jv b3RpbmcudHh0DQo+ID4+PiBpbmRleCA5ODI1MzQxNGI4Li44MDEzZmI5OGZlIDEwMDY0NA0KPiA+ Pj4gLS0tIGEvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dA0KPiA+Pj4gKysr IGIvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dA0KPiA+Pj4gQEAgLTM3OCwz ICszNzgsMTI3IEBAIGRldmljZS10cmVlOg0KPiA+Pj4NCj4gPj4+ICAgIFRoaXMgd2lsbCByZXNl cnZlIGEgNTEyTUIgcmVnaW9uIHN0YXJ0aW5nIGF0IHRoZSBob3N0IHBoeXNpY2FsIGFkZHJlc3MN Cj4gPj4+ICAgIDB4MzAwMDAwMDAgdG8gYmUgZXhjbHVzaXZlbHkgdXNlZCBieSBEb21VMS4NCj4g Pj4+ICsNCj4gPj4+ICtTdGF0aWMgU2hhcmVkIE1lbW9yeQ0KPiA+Pj4gKz09PT09PT09PT09PT09 PT09PT09DQo+ID4+PiArDQo+ID4+PiArVGhlIHN0YXRpYyBzaGFyZWQgbWVtb3J5IGRldmljZSB0 cmVlIG5vZGVzIGFsbG93IHVzZXJzIHRvDQo+ID4+PiArc3RhdGljYWxseSBzZXQgdXAgc2hhcmVk IG1lbW9yeSBvbiBkb20wbGVzcyBzeXN0ZW0sIGVuYWJsaW5nDQo+ID4+PiArZG9tYWlucyB0byBk byBzaG0tYmFzZWQgY29tbXVuaWNhdGlvbi4NCj4gPj4+ICsNCj4gPj4+ICstIGNvbXBhdGlibGUN Cj4gPj4+ICsNCj4gPj4+ICsgICAgInhlbixkb21haW4tc2hhcmVkLW1lbW9yeS12MSINCj4gPj4+ ICsNCj4gPj4+ICstIHhlbixzaG0taWQNCj4gPj4+ICsNCj4gPj4+ICsgICAgQW4gYXJiaXRyYXJ5 IHN0cmluZyB0aGF0IHJlcHJlc2VudHMgdGhlIHVuaXF1ZSBpZGVudGlmaWVyIG9mIHRoZSBzaGFy ZWQNCj4gPj4+ICsgICAgbWVtb3J5IHJlZ2lvbiwgd2l0aCBhIHN0cmljdCBsaW1pdCBvbiB0aGUg bnVtYmVyIG9mDQo+ID4+PiArIGNoYXJhY3RlcnMoXDANCj4gPj4gaW5jbHVkZWQpLA0KPiA+Pj4g KyAgICBgTUFYX1NITV9JRF9MRU5HVEgoMTYpYC4gZS5nLiAieGVuLHNobS1pZCA9ICJteS1zaGFy ZWQtbWVtLQ0KPiAxIiIuDQo+ID4+PiArDQo+ID4+PiArLSB4ZW4sc2hhcmVkLW1lbQ0KPiA+Pj4g Kw0KPiA+Pj4gKyAgICBBbiBhcnJheSB0YWtlcyBhIHBoeXNpY2FsIGFkZHJlc3MsIHdoaWNoIGlz IHRoZSBiYXNlIGFkZHJlc3Mgb2YgdGhlDQo+ID4+PiArICAgIHNoYXJlZCBtZW1vcnkgcmVnaW9u IGluIGhvc3QgcGh5c2ljYWwgYWRkcmVzcyBzcGFjZSwgYSBzaXplLA0KPiA+Pj4gKyBhbmQgYQ0K PiA+PiBndWVzdA0KPiA+Pj4gKyAgICBwaHlzaWNhbCBhZGRyZXNzLCBhcyB0aGUgdGFyZ2V0IGFk ZHJlc3Mgb2YgdGhlIG1hcHBpbmcuDQo+ID4+PiArICAgIGUuZy4geGVuLHNoYXJlZC1tZW0gPSA8 IFtob3N0IHBoeXNpY2FsIGFkZHJlc3NdIFtzaXplXSBbZ3Vlc3QNCj4gPj4+ICsgYWRkcmVzc10g Pg0KPiA+Pg0KPiA+PiBZb3VyIGltcGxlbWVudGF0aW9uIGJlbG93IGlzIGNoZWNraW5nIGZvciBv dmVybGFwIGFuZCBhbHNvIGhhdmUgc29tZQ0KPiA+PiByZXN0cmljdGlvbi4gQ2FuIHRoZXkgYmUg ZG9jdW1lbnRlZCBpbiB0aGUgYmluZGluZz8NCj4gPj4NCj4gPj4+ICsNCj4gPj4+ICsgICAgVGhl IG51bWJlciBvZiBjZWxscyBmb3IgdGhlIGhvc3QgYWRkcmVzcyAoYW5kIHNpemUpIGlzIHRoZSBz YW1lIGFzIHRoZQ0KPiA+Pj4gKyAgICBndWVzdCBwc2V1ZG8tcGh5c2ljYWwgYWRkcmVzcyBhbmQg dGhleSBhcmUgaW5oZXJpdGVkIGZyb20gdGhlDQo+ID4+PiArIHBhcmVudA0KPiA+PiBub2RlLg0K PiA+Pg0KPiA+PiBJbiB2NSwgd2UgZGlzY3Vzc2VkIHRvIGhhdmUgdGhlIGhvc3QgYWRkcmVzcyBv cHRpb25hbC4gSG93ZXZlciwgdGhlDQo+ID4+IGJpbmRpbmcgaGFzIG5vdCBiZWVuIHVwZGF0ZWQg dG8gcmVmbGVjdCB0aGF0LiBOb3RlIHRoYXQgSSBhbSBub3QNCj4gPj4gYXNraW5nIHRvIGltcGxl bWVudCwgYnV0IGluc3RlYWQgcmVxdWVzdCB0aGF0IHRoZSBiaW5kaW5nIGNhbiBiZSB1c2VkIGZv cg0KPiBzdWNoIHNldHVwLg0KPiA+Pg0KPiA+DQo+ID4gSG93IGFib3V0Og0KPiA+ICINCj4gPiBI b3N0IHBoeXNpY2FsIGFkZHJlc3MgY291bGQgYmUgb21pdHRlZCBieSB1c2VycywgYW5kIGxldCBY ZW4gZGVjaWRlIHdoZXJlDQo+IGl0IGxvY2F0ZXMuDQo+ID4gIg0KPiANCj4gSSBhbSBmaW5lIHdp dGggdGhhdC4NCj4gDQo+ID4gRG8geW91IHRoaW5rIEkgc2hhbGwgZnVydGhlciBwb2ludCBvdXQg dGhhdCByaWdodCBub3csIHRoaXMgcGFydA0KPiA+IGZlYXR1cmUgaXMgbm90IGltcGxlbWVudGVk IGluIGNvZGVzPw0KPiANCj4gSSBoYXZlIG1hZGUgYSBjb3VwbGUgb2Ygc3VnZ2VzdGlvbiBmb3Ig dGhlIGNvZGUuIEJ1dCBJIHRoaW5rIHRoZSBiaW5kaW5nDQo+IHdvdWxkIGxvb2sgYSBiaXQgb2Rk IHdpdGhvdXQgdGhlIGhvc3QgcGh5c2ljYWwgYWRkcmVzcy4gV2Ugd291bGQgbm93IGhhdmU6DQo+ IA0KPiA8IFtzaXplXSBbZ3Vlc3QgYWRkcmVzc10+DQo+IA0KPiBJIHRoaW5rIGl0IHdvdWxkIGJl IG1vcmUgbmF0dXJhbCBpZiB3ZSBoYWQNCj4gDQo+IDxbZ3Vlc3QgYWRkcmVzc10gW3NpemVdPg0K PiANCj4gQW5kDQo+IA0KPiA8W2d1ZXN0IGFkZHJlc3NdIFtzaXplXSBbaG9zdCBwaHlzaWNhbCBh ZGRyZXNzXT4NCj4gDQoNCk9rLCBhYm91dCB0aGUgYmluZGluZyBvcmRlciBjaGFuZ2UsIGRvIHlv dSBwcmVmZXIgaXQgaW4gdjcgb3IgNC4xNy1wb3N0LA0Kc2luY2UgaXQgbWF5IGFsc28gbmVlZCBh IGZldyBjb2RlIHR3ZWFrLg0KDQo+ID4NCj4gPj4+IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L3NldHVwLmgNCj4gPj4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPiA+Pj4g aW5kZXggMmJiMDFlY2ZhOC4uMzlkNGU5M2I4YiAxMDA2NDQNCj4gPj4+IC0tLSBhL3hlbi9hcmNo L2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVk ZS9hc20vc2V0dXAuaA0KPiA+Pj4gQEAgLTIzLDEwICsyMywxOSBAQCB0eXBlZGVmIGVudW0gew0K PiA+Pj4gICAgfSAgYm9vdG1vZHVsZV9raW5kOw0KPiA+Pj4NCj4gPj4+DQo+ID4+PiArI2lmZGVm IENPTkZJR19TVEFUSUNfU0hNDQo+ID4+PiArLyogSW5kaWNhdGVzIHRoZSBtYXhpbXVtIG51bWJl ciBvZiBjaGFyYWN0ZXJzKFwwIGluY2x1ZGVkKSBmb3INCj4gPj4+ICtzaG1faWQgKi8gI2RlZmlu ZSBNQVhfU0hNX0lEX0xFTkdUSCAxNiAjZW5kaWYNCj4gPj4NCj4gPj4gSXMgdGhlICNpZmRlZiBy ZWFsbHkgbmVlZGVkPw0KPiA+Pg0KPiA+Pj4gKw0KPiA+Pj4gICAgc3RydWN0IG1lbWJhbmsgew0K PiA+Pj4gICAgICAgIHBhZGRyX3Qgc3RhcnQ7DQo+ID4+PiAgICAgICAgcGFkZHJfdCBzaXplOw0K PiA+Pj4gICAgICAgIGJvb2wgeGVuX2RvbWFpbjsgLyogd2hldGhlciB0aGUgbWVtb3J5IGJhbmsg aXMgYm91bmQgdG8gYSBYZW4NCj4gPj4+IGRvbWFpbi4gKi8NCj4gPj4+ICsjaWZkZWYgQ09ORklH X1NUQVRJQ19TSE0NCj4gPj4+ICsgICAgY2hhciBzaG1faWRbTUFYX1NITV9JRF9MRU5HVEhdOw0K PiA+Pj4gKyAgICB1bnNpZ25lZCBpbnQgbnJfc2htX2JvcnJvd2VyczsNCj4gPj4+ICsjZW5kaWYN Cj4gPj4+ICAgIH07DQo+ID4+DQo+ID4+IElmIEkgY2FsY3VsYXRlZCByaWdodCwgdGhlIHN0cnVj dHVyZSB3aWxsIGdyb3cgZnJvbSAyNCB0byA0MCBieXRlcy4NCj4gPj4gQXQgdGhlIG1vbWVudCwg dGhpcyBpcyBwcm90ZWN0ZWQgd2l0aCBDT05GSUdfU1RBVElDX1NITSB3aGljaCBpcw0KPiB1bnN1 cHBvcnRlZC4NCj4gPj4gSG93ZXZlciwgSSB0aGluayB3ZSB3aWxsIG5lZWQgdG8gZG8gc29tZXRo aW5nIGFzIHdlIGNhbid0IGNvbnRpbnVlIHRvDQo+ID4+IGdyb3cgJ21lbWJhbmsnIGxpa2UgdGhh dC4NCj4gPj4NCj4gPj4gSSBkb24ndCBoYXZlIGEgcXVpY2sgc3VnZ2VzdGlvbiBmb3IgNC4xNyAo dGhlIGZlYXR1cmUgZnJlZXplIGlzIGluIGENCj4gPj4gd2VlaykuIExvbmcgdGVybSwgSSB0aGlu ayB3ZSB3aWxsIHdhbnQgdG8gY29uc2lkZXIgdG8gbW92ZSB0aGUgc2htIElEDQo+ID4+IGluIGEg c2VwYXJhdGUgYXJyYXkgdGhhdCBjb3VsZCBiZSByZWZlcmVuY2VkIGhlcmUuDQo+ID4+DQo+ID4+ IFRoZSBvdGhlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBoYXZlIHRoZSBzaGFyZWQgbWVtb3J5IHJl Z2lvbnMgaW4gYQ0KPiA+PiBzZXBhcmF0ZSBhcnJheS4gVGhleSB3b3VsZCBoYXZlIHRoZWlyIG93 biBzdHJ1Y3R1cmUgd2hpY2ggd291bGQNCj4gPj4gZWl0aGVyIGVtYmVkZGVkICJtZW1iYW5rIiBv ciBjb250YWluIGEgcG9pbnRlci9pbmRleCB0byB0aGUgYmFuay4NCj4gPj4NCj4gPg0KPiA+IE9r LCBzbyBvdGhlciB0aGFuIHRoaXMgZml4aW5nLCBvdGhlcnMgd2lsbCBiZSBhZGRyZXNzZWQgaW4g dGhlIG5leHQNCj4gPiBzZXJpZS4gQW5kIHRoaXMgcGFydCBmaXhpbmcgd2lsbCBiZSBpbnRyb2R1 Y2VkIGluIGEgbmV3IGZvbGxvdy11cCBwYXRjaCBzZXJpZQ0KPiBhZnRlciA0LjE3IHJlbGVhc2Uu DQo+ID4NCj4gPiBJJ20gaW4gZmF2b3Igb2YgaW50cm9kdWNpbmcgYSBuZXcgc3RydWN0dXJlIHRv IGNvbnRhaW4gc2htLXJlbGF0ZWQNCj4gPiBkYXRhIGFuZCBsZXQgJ21lbWJhbmsnIGNvbnRhaW5z IGEgcG9pbnRlciB0byBpdCwgbGlrZSBgYGANCj4gPiAgICtzdHJ1Y3Qgc2htX21lbWJhbmsgew0K PiA+ICsgICAgY2hhciBzaG1faWRbTUFYX1NITV9JRF9MRU5HVEhdOw0KPiA+ICsgICAgdW5zaWdu ZWQgaW50IG5yX3NobV9ib3Jyb3dlcnM7DQo+ID4gK30NCj4gPiArDQo+ID4gICBzdHJ1Y3QgbWVt YmFuayB7DQo+ID4gICAgICAgcGFkZHJfdCBzdGFydDsNCj4gPiAgICAgICBwYWRkcl90IHNpemU7 DQo+ID4gICAgICAgYm9vbCB4ZW5fZG9tYWluOyAvKiB3aGV0aGVyIHRoZSBtZW1vcnkgYmFuayBp cyBib3VuZCB0byBhIFhlbg0KPiA+IGRvbWFpbi4gKi8NCj4gPiArICAgIHN0cnVjdCBzaG1fbWVt YmFuayAqc2htOw0KPiA+ICAgfTsNCj4gPiBgYGANCj4gPiBUaGVuIGV2ZXJ5IHRpbWUgd2UgaW50 cm9kdWNlIGEgbmV3IGZlYXR1cmUgaGVyZSwgZm9sbG93aW5nIHRoaXMNCj4gPiBzdHJhdGVneSwg J21lbWJhbmsnIHdpbGwgYXQgbW9zdCBncm93IDggYnl0ZXMgZm9yIHRoZSByZWZlcmVuY2UuDQo+ IA0KPiBCZSBhd2FyZSB0aGF0IHdlIGFyZSB2ZXJ5IGVhcmx5IGluIFhlbiBhbmQgdGhlcmVmb3Jl IGR5bmFtaWNhbGx5IGFsbG9jYXRpbmcNCj4gbWVtb3J5IGlzIG5vdCBwb3NzaWJsZS4gVGhlcmVm b3JlICdzaG1fbWVtYmFuaycgd291bGQgbW9zdCBsaWtlbHkgbmVlZA0KPiB0byBiZSBzdGF0aWMu DQo+IA0KDQpSaWdodCwgdGhlIGhlYXAgbWF5IG5vdCBiZSBmdWxseSBmdW5jdGlvbmFsLCB1bmRl cnN0b29kLg0KDQo+IEF0IHdoaWNoIHBvaW50LCB0aGlzIGNvdWxkIGJlIGFuIGluZGV4Lg0KPiAN Cj4gPg0KPiA+IEknbSBvcGVuIHRvIHRoZSBkaXNjdXNzaW9uIGFuZCB3aWxsIGxldCBpdCBkZWNp ZGUgd2hhdCBpdCBmaW5hbGx5IHdpbGwNCj4gPiBiZS4gOykNCj4gDQo+IE15IG9yaWdpbmFsIGlk ZWEgd2FzIHRvIGhhdmUgJ3NobV9tZW1iYW5rJyBwb2ludGluZyB0byB0aGUgJ21lbWJhbmsnDQo+ IHJhdGhlciB0aGFuIHRoZSBvdGhlciB3YXkgYXJvdW5kLiBCdXQgSSBkb24ndCBoYXZlIGEgc3Ry b25nIGFyZ3VtZW50IGVpdGhlcg0KPiB3YXkuDQo+IA0KPiBTbyBJIHdvdWxkIG5lZWQgdG8gc2Vl IHRoZSByZXN1bHRpbmcgY29kZS4gQW55d2F5LCB0aGF0J3MgZm9yIHBvc3QtNC4xNy4NCj4gDQo+ IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:31:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:31:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397232.637732 (Exim 4.92) (envelope-from ) id 1oTxOe-0003zM-T3; Fri, 02 Sep 2022 03:31:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397232.637732; Fri, 02 Sep 2022 03:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxOe-0003zF-QG; Fri, 02 Sep 2022 03:31:08 +0000 Received: by outflank-mailman (input) for mailman id 397232; Fri, 02 Sep 2022 03:31:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxOe-0003z9-0A for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:31:08 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140059.outbound.protection.outlook.com [40.107.14.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adc23160-2a6f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:31:06 +0200 (CEST) Received: from DB6PR0601CA0036.eurprd06.prod.outlook.com (2603:10a6:4:17::22) by DB9PR08MB6426.eurprd08.prod.outlook.com (2603:10a6:10:255::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 03:31:04 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:17:cafe::ac) by DB6PR0601CA0036.outlook.office365.com (2603:10a6:4:17::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:04 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 02 Sep 2022 03:31:04 +0000 Received: from eed0d6ed41d8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9FF07C0B-3C0E-426A-B073-208366B50B63.1; Fri, 02 Sep 2022 03:30:52 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eed0d6ed41d8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:30:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GVXPR08MB7774.eurprd08.prod.outlook.com (2603:10a6:150:7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 03:30:49 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 03:30:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adc23160-2a6f-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KRrPGdWwvsXkw4rR0sRHmum9S+12slB/aQGLAXoukxZRbBdcOtQSX2NcAwU0xS0J/KhymJvAt4r7ZsK9p4xBNqoT0vvYJ6DPJHAHGLuKcqQcoQ4sSsUezXGifu0QL52/Gg3sCdny8RQZkwXSjnNANtgMX9ZWQWqVoYEjlLRsVUGWO0ORe/h894ZLGew3sLEJhy89RUeU4OmZXhVO37eX+D/9whLotFe1gE3Vg4bnVKFbr/pJLzunEq6uXOdGmBIf29xp2Ll/gsS7iqBWqKzFFljnYOAEyBRZL/IYNfmZ7aMHWCleW0P+auxRX+WDafFjOMeDmuGL92LtJmQsgs4YDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4O4lBE22ExQUpguYwGqqakeE8idW8+2YaNU1ScgeKhc=; b=IlA4GWd+V/FfDXb5N4zUExA/gncv0RB/YxHVjwV8OwlnRFtb2/Cu9bA5qYK82YiE48JR3KoJ4xHYRtB+ieO/ooyH8iM308lBNlEoE3ubADS3Mx4msw59MGbxUmJnkPN6JYgkWB3Bmp5w6GPNEp+TX2kTXioPeHCk+CJ2Pd7zVsC9FvaZZlJz6VcHKTibGr/Wr+RLAaUUT3X+ykZUNiDXLdcXuHenkN1+LPCLkhF/kwXYlfPIvpjV3k3m9fopI/pDPaSkzQGQWGUHib+mMaKFlWdCPt9XT58fUXI3uET5Sv6A4h+a4QiSx7mL+NeEe6eVhzDE13qABNIlWie1Z8VJzg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4O4lBE22ExQUpguYwGqqakeE8idW8+2YaNU1ScgeKhc=; b=P6IUEYtrylDO+q9JeZpYVdH9Bc+Vf4Nlt9oOk7IkqagxTEqNIE3kGbquLsU7Lki+Vl7pDfvyJZtIdVCJfhuvZ9DUGAez8lSuQPSReM5cOqWY29B0wiJgc+e4Riw3JYzUsRybpfCqesNUg8YRDmZ1MZBgi0Xva85SJLT6fMjAr7A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l6HUVaNhfwe5KjVY/uV/sWdX8sA8UlfKBXUEI2Xs6rcmL7yJKzH1+pY/SnmrdxePt+w6VbiCmlkeUktz2UJGn9yEcKGE/3ewxxp9ZTSyXbzhhBsyiWf7QVUIN6SHUEmsQ7qQbVe6mm3Dlh4BPCJx7gQP04eKpUURAsc9dhhj2ljvfG8GwnisWM1ZPu89t9O6xVl7z3K5ZS6NvTaZP2HTJ3BXsLR6MujmqatnF/wmAZwkIzTwghEoGk+KXEit1SaU/2RYrBFVBpdqLuHdqYu4PVHDyQ5NgXeE6nniZZHG00Fq/Y7NMhDTN+t9yjIW6N6u4MyxjCZevSdsR9aNG4KOgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4O4lBE22ExQUpguYwGqqakeE8idW8+2YaNU1ScgeKhc=; b=EAdw2iNQbnCX898b9tFEaEDFcr68JBdUNfOZvW71+0pc+0NmnxJnXBr5Rpim8TohoAhkgpa9UwbcTZjYfNF2vE4GRazjln34wBorHfu+1ODDC0ydflSt/r6QmhWXi2rjvEw1I2v7cwxMUYszAGPTHM8Ur0I+WrRFdy/VXwhMOad08DT5VSB99+WqeiVB84VlQlHinJCh38NuR1LzUQOz4f2T75NWTkFJIlqP+FKKcBdkF4+G74bRUJww9xVtp+TFKFqVE+Un1aX/SiJy4gFv2oLXuNCvJSpi0QNMaoWJ4M+LWqW/cmMblgQB27ljxp9lqFfTap7NMlcUR+hXjvc+fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4O4lBE22ExQUpguYwGqqakeE8idW8+2YaNU1ScgeKhc=; b=P6IUEYtrylDO+q9JeZpYVdH9Bc+Vf4Nlt9oOk7IkqagxTEqNIE3kGbquLsU7Lki+Vl7pDfvyJZtIdVCJfhuvZ9DUGAez8lSuQPSReM5cOqWY29B0wiJgc+e4Riw3JYzUsRybpfCqesNUg8YRDmZ1MZBgi0Xva85SJLT6fMjAr7A= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Stefano Stabellini Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q3KwCgAgAAG+VCAABfUgIAApokQ Date: Fri, 2 Sep 2022 03:30:49 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3A96B08C86187648AB113540872498A8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 53d5e906-3219-471c-40ed-08da8c9390a6 x-ms-traffictypediagnostic: GVXPR08MB7774:EE_|DBAEUR03FT045:EE_|DB9PR08MB6426:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: krIR2vo2G2DMDQwK7SU1VuZjPVdJAOj4UKSSueByWjgt/mrJTg+yisGis12/M4hB6WgkWHfP3c18KLJmxafZD63zXSvYvZVmUWNvQdcTm+vYPacSY18y50HW/GyiQQveB/sjALAXMwb020/gujnHLEn9oXCEXAOjI+Q7sYXkRoKYg249TqKAS1H7XXQY997baPAP6lvbGJc3kFzweggNeNVeU+/o940BvhfIbAQ6AnZeO3AnffsVUngI6KW8sg0/Taqhbr6By+ntx8VuPt6EBCmI2st7rYtgxwOiKa6YbIV4GMyVlNf9oXMMurIWRb8E33GP2hacPaA36rCUW2d+TFauME7TbYeeBiNUs2x4GPSsb5TVp4Veer6Wgj67CfzZKUNnjZg9edRm+IC2X4R46/a9L7hV9tl3Aw0fvLHZ4gArdm4Kaox4ZMgdVN2/RBVPDdFTpcjScP0QQWLeqIoGrSlazUJ2M93r2ywpgafDtop2Cq1dGvjqyoSzieGDlHpROqcJMHnaJmyInFVSMY/AcdBREbMg9C4Kyti6ghdbSZ/y5UoEYnnqrQ6TG8Ck6Wsm7EwM8MTg/+86oQU01jlw0zVQHpHfk/mFRT1uQ3e7ymYGoTdN0GGavAVTiWMGwdM5oySwIPyNtloBoebBCk2UBiKqI8J7LrA1sgQd4gCJc26cEusMHH5oDQUK8QKSWuEQRjQiRjaZwNRr/FpVm9Y8E5+lHy2sXQGBfnKEH+Ax+JJARyRn3twU/QDWt16FS+u8 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(136003)(376002)(39860400002)(346002)(66946007)(41300700001)(66556008)(66476007)(66446008)(64756008)(4326008)(76116006)(83380400001)(186003)(54906003)(478600001)(110136005)(316002)(33656002)(26005)(9686003)(55016003)(8676002)(7696005)(6506007)(86362001)(38070700005)(71200400001)(5660300002)(8936002)(2906002)(52536014)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7774 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 853be9be-94ca-4902-a5b1-08da8c938811 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xi6eWx1/N9Z+Y5XcIbE/b2/wfcVbsp6a+biPMD1hgu6GwkGq+3bq0q9C54CXSdAJFNOfkuQF2gZNUXBcvEqkmxpBl5/qH2vRrNFcpiywZENash/fO9cJ/CND73D/ReP9kr9O4fP+Yva7cBIF52V3rz3ck3ArkBDq7wZm30uXJ+Kz3YH1AvZFpvp6SGvi+l+MFUD5Jefn08E5elfDwF2Ttu0Bjyvh/ykZLnJb4J1GXsoDfaXySkniXErwWH/4n1/AMSYtQ3QsXa8KYqyvyfzMwGVxLK1YF1nOrHgaqfk+2Jks94x/tKapwbFhj6eQ4Z698C1PULkygPh55MJQKzirqeXX3wTg2afhEi8cCodan2fhLDak41ENV224+aWtkSqqdPj/3p/EIgOyoT8OEymPO0A5P5VLB4d+SAe/2jh1aDyzQkLfu41TUy62avp727AHh+JXLLF5CY9PK44VchnT8hW1dCtaXUzdX28DsB9Zheb0ZB5K3od/WMpN1nvpIlQent2t2b9CDwDVhRbDDCQBnSKQogOBE1l4jyVUIS+hCf/TlZXxt+kFzqJIVsi5qJCUw89eWeMCqO5+8JL5AHpOLOwEGffSopuEJObyFZT+ghsC1bXfvnTHNGIDIaBetO4+ZLVq2rbL6dhtH8xQK1Pq6Z2ECXxrtzpYddHMS2hRCmTwRCun2eOkrEzfmJDsshDZU0rzlNfkaFUYwGPyXrxZL9NKWiMfeRNpYwrhnxup/DMy862OfjEGCQ/XwrisPqHl X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(136003)(40470700004)(46966006)(36840700001)(70586007)(52536014)(8936002)(5660300002)(55016003)(40480700001)(70206006)(8676002)(2906002)(4326008)(54906003)(33656002)(316002)(110136005)(82310400005)(478600001)(9686003)(41300700001)(7696005)(356005)(26005)(83380400001)(6506007)(107886003)(81166007)(47076005)(336012)(86362001)(186003)(82740400003)(40460700003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:31:04.1242 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53d5e906-3219-471c-40ed-08da8c9390a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6426 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IFRoaXMgY29kZSBpcyBub3cgYmVjb21pbmcg cXVpdGUgY29uZnVzaW5nIHRvIHVuZGVyc3RhbmRpbmcuIFRoaXMgbG9vcCBpcw0KPiA+PiBtZWFu dCB0byBtYXAgdGhlIHhlbmhlYXAuIElmIEkgZm9sbG93IHlvdXIgZG9jdW1lbnRhdGlvbiwgaXQg d291bGQNCj4gbWVhbg0KPiA+PiB0aGF0IG9ubHkgdGhlIHJlc2VydmVkIHJlZ2lvbiBzaG91bGQg YmUgbWFwcGVkLg0KPiA+DQo+ID4gWWVzIEkgdGhpbmsgdGhpcyBpcyB0aGUgc2FtZSBxdWVzdGlv biB0aGF0IEkgcmFpc2VkIGluIHRoZSBzY2lzc29ycyBsaW5lIG9mIHRoZQ0KPiA+IGNvbW1pdCBt ZXNzYWdlIG9mIHRoaXMgcGF0Y2guDQo+IA0KPiBTb3JyeSBJIGRpZG4ndCBub3RpY2UgdGhlIGNv bW1lbnQgYWZ0ZXIgdGhlIHNjaXNzb3JzIGxpbmUuIFRoaXMgaXMgdGhlDQo+IHNhbWUgcXVlc3Rp b24gOikNCj4gDQo+ID4gV2hhdCBJIGludGVuZCB0byBkbyBpcyBzdGlsbCBtYXBwaW5nIHRoZSB3 aG9sZQ0KPiA+IFJBTSBiZWNhdXNlIG9mIHRoZSB4ZW5oZWFwXyogdmFyaWFibGVzIHRoYXQgeW91 IG1lbnRpb25lZCBpbi4uLg0KPiA+DQo+ID4+DQo+ID4+IE1vcmUgY29uZnVzaW5nbHksIHhlbmhl YXBfKiB2YXJpYWJsZXMgd2lsbCBjb3ZlciB0aGUgZnVsbCBSQU0uDQo+ID4NCj4gPiAuLi5oZXJl LiBCdXQgb25seSBhZGRpbmcgdGhlIHJlc2VydmVkIHJlZ2lvbiB0byB0aGUgYm9vdCBhbGxvY2F0 b3Igc28gdGhlDQo+ID4gcmVzZXJ2ZWQgcmVnaW9uIGNhbiBiZWNvbWUgdGhlIGhlYXAgbGF0ZXIg b24uIEkgYW0gd29uZGVyaW5nIGlmIHdlDQo+ID4gaGF2ZSBhIG1vcmUgY2xlYXIgd2F5IHRvIGRv IHRoYXQsIGFueSBzdWdnZXN0aW9ucz8NCj4gDQo+IEkgdGhpbmsgeW91ciBjb2RlIGlzIGNvcnJl Y3QuIEl0IG9ubHkgbmVlZHMgc29tZSByZW5hbWluZyBvZiB0aGUNCj4gZXhpc3RpbmcgdmFyaWFi bGUgKG1heWJlIHRvIGRpcmVjdG1hcF8qPykgdG8gbWFrZSBjbGVhciB0aGUgYXJlYSBpcyB1c2Vk DQo+IHRvIGFjY2VzcyB0aGUgUkFNIGVhc2lseS4NCg0KVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNh dGlvbi4gSSBjaGVja2VkIHRoZSBjb2RlIGFuZCBmb3VuZCB0aGUgeGVuaGVhcF8qDQp2YXJpYWJs ZXMgYXJlOg0KeGVuaGVhcF92aXJ0X3N0YXJ0LCB4ZW5oZWFwX3ZpcnRfZW5kLCB4ZW5oZWFwX21m bl9zdGFydCwNCnhlbmhlYXBfbWZuX2VuZCwgeGVuaGVhcF9iYXNlX3BkeC4NCg0KRm9yIGNsYXJp ZmljYXRpb24sIGRvIHdlIG5lZWQgdG8gY2hhbmdlIGFsbCBvZiB0aGVtIHRvIGRpcmVjdG1hcF8q Pw0KDQpBIHB1cmUgcmVuYW1pbmcgc2hvdWxkIGJlIGVhc3kgKGFuZCBJIGd1ZXNzIGFsc28gc2Fm ZSksIGJ1dCBtYXliZSBJIGFtDQpvdmVydGhpbmtpbmcgYmVjYXVzZSBhcm0zMiBhbHNvIHVzZXMg eGVuaGVhcF92aXJ0X2VuZCwgeGVuaGVhcF9tZm5fc3RhcnQNCmFuZCB4ZW5oZWFwX21mbl9lbmQu IFRoZXNlIHZhcmlhYmxlcyByZWZlciB0byB0aGUgcmVhbCB4ZW5oZWFwLCBJIGFtIG5vdA0Kc3Vy ZSByZW5hbWluZyB0aGVzZSB3b3VsZCByZWR1Y2UgdGhlIHJlYWRhYmlsaXR5IGZvciBhcm0zMi4N Cg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVs aWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:32:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397240.637743 (Exim 4.92) (envelope-from ) id 1oTxPR-0004aZ-B2; Fri, 02 Sep 2022 03:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397240.637743; Fri, 02 Sep 2022 03:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPR-0004aS-7F; Fri, 02 Sep 2022 03:31:57 +0000 Received: by outflank-mailman (input) for mailman id 397240; Fri, 02 Sep 2022 03:31:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPP-0004PQ-T4 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:31:56 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2055.outbound.protection.outlook.com [40.107.104.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca575257-2a6f-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 05:31:54 +0200 (CEST) Received: from AS9PR06CA0590.eurprd06.prod.outlook.com (2603:10a6:20b:486::14) by DU0PR08MB7836.eurprd08.prod.outlook.com (2603:10a6:10:3b3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 03:31:52 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:486:cafe::3e) by AS9PR06CA0590.outlook.office365.com (2603:10a6:20b:486::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:51 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 02 Sep 2022 03:31:51 +0000 Received: from 82be5ef6c966.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5C52205-6D88-4297-B9DA-50E11D1A7228.1; Fri, 02 Sep 2022 03:31:44 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 82be5ef6c966.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:31:44 +0000 Received: from DB6PR0301CA0062.eurprd03.prod.outlook.com (2603:10a6:4:54::30) by GVXPR08MB7824.eurprd08.prod.outlook.com (2603:10a6:150:1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Fri, 2 Sep 2022 03:31:41 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::3a) by DB6PR0301CA0062.outlook.office365.com (2603:10a6:4:54::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 2 Sep 2022 03:31:41 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:41 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:40 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca575257-2a6f-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=agV1RI+rH3UnYlnMqnFXqyiD/9Dxl8dDNni85XJOm/OWtF1LndI4VhYxmScicb4yLG/j3n/8QZNK2hDjoPV+p/33QvhYGN/rfnOoRG0dfkCQ626zr1B60bCTwDN2pr2zhruYgu6zZKH1gQ6UT8Lpc7FfqcOdC/xw3OynFVMttTi/YAJ7c49LhVFveLT5l7U9fhRd+mAAB5oBJU/5/f5w5cas3R8PYKd6F/IeYWBqtHiWPuBrB2lkLNugc07Hw6vhKYEkQpcBF+Nk9I9vlP30i5GiUo/D5rfdGYh8oZiyhKIMrmeTauXWH9r2gUmiXgEpfsc8m5Av0xf0e+3ESIbSRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WNPp3mJZEp8qgDxT7NNCkedF3iq87kU7+nkKCUJRg9E=; b=d5NZzwk4A4OPfW4NaV+AWFrALwYBnYDbxNJstk7CgHSbcQXeg/nQ0wBpkrH4zr7JXOspQak0+N1ZmzbB1yXxg5elGs/qJ8sjYvNFJkLm5eGldldKx5mfh8lVECYRLHLY9vqaMITCFGOOs5YRezKfA6h8NP7HfK/iwNroqdMIr9g9nfarrKtQeF8Z1M/W7RbVmjpMbEZ1GcnRbZUw0DbA9frkSjLVaB3JRLJ+NUBbi2BXRoDTFD4PKBbI/VQjfbwFTkL5FS35FwneeAe/L11iuTJgpSu20RX3JBo6Jsg4a9/hFHIFc+WU+T+wN/48xIDiIHP9O1xoNPH6bXF2+TvGAw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WNPp3mJZEp8qgDxT7NNCkedF3iq87kU7+nkKCUJRg9E=; b=0MfFbPHdHJjrt/xT6qIRxyWCB8b47MycbH4BKMhmU4oI24yXvECilqzXvcplyWrr7gjP20bk4yw/LX98D7B+qBJg+7jXpSEHbAav5hduxuLBgNsUryv1gDrciOYhpPMTQODm1eZ63onqxNwX8UIimIXgElRiQgRkpzDZtejtbq4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0c5eb577714c7dcb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEuhdfV/wTOdEh0vI0nbjuCPzZgQ6qAYQXXh+JErdB1G2ggqmk7fvDi5eeGbCseJk45llG0RolrRoRR6K+tZFOgT+j2qurJgvH6lWR85QOCiGGTVWlNBOmnKAA7z9NoVmbzg8a/Gko+C92ddcmRRUKmODSgb07+hFuUEoCI/SuRJvo+PdmUTVENaqsJO941bBVb401Mx8DRe6tmy0i6ZegH1IrFqy1BZpbhW2R7/azWNOJ1PRwmHCcGMmHPHpxWki3sc/xOuKY0Mcs6nemW4SCQ27YLMl76oefDwDVuy3if9JfZgzShODhBGZtV8PhVNSgNAELwAuXa7fglXjbVRhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WNPp3mJZEp8qgDxT7NNCkedF3iq87kU7+nkKCUJRg9E=; b=Hd6NQa4aMB1TyrnTx6hq/0G89++DybxwM4DWF7qyc8Rxh8pgNTpVQ2WW85A9irueldnadGzYcxuwCw+BBdZK4wOjeDwwu0xVxhK1bc4IFQtWKr+teiGJQPEgZQVtSi66Ug/YyB6SBOWtwJfrmyYSYCGXsaYZa2pGkYSrMjVTTjP0LEHIc18wXrzJYndU99GvFY9OSydcamq33VXrcmGyOLQoIhGFCRMEX19GO1L7Yzy9ytW+GspkeK04f1VnhFJpuCmu0HetGHrtkVxiyHRm5A0oAjxU4fsUy6F5x9fxLD6B1YRbrZB+5Sl3A0j7IHiQ8Oc0t7ysgEF4MExBv9jTPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WNPp3mJZEp8qgDxT7NNCkedF3iq87kU7+nkKCUJRg9E=; b=0MfFbPHdHJjrt/xT6qIRxyWCB8b47MycbH4BKMhmU4oI24yXvECilqzXvcplyWrr7gjP20bk4yw/LX98D7B+qBJg+7jXpSEHbAav5hduxuLBgNsUryv1gDrciOYhpPMTQODm1eZ63onqxNwX8UIimIXgElRiQgRkpzDZtejtbq4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v4 1/6] xen/x86: Provide helpers for common code to access acpi_numa Date: Fri, 2 Sep 2022 11:31:16 +0800 Message-ID: <20220902033121.540328-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902033121.540328-1-wei.chen@arm.com> References: <20220902033121.540328-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 189b2cfa-822f-46c9-b182-08da8c93acf6 X-MS-TrafficTypeDiagnostic: GVXPR08MB7824:EE_|AM7EUR03FT004:EE_|DU0PR08MB7836:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: u1KYr7qybhylkmenMlr/aA9ZI4QLFrCAVgvmQ0EaKKDDNV3eBnG4jrH0t9cG74bZSRQ4SY1y/LEhWCAXl/LWoWuTEjt8h3VZx/6JeSkVk3r8ylNxor0fkWCNnYJ4gBFfFJzYuKVOZvwb/oUvHnQDZgAFG2Cq1awzF6DhEtmX+O3osk9QZX1uxuWe409LsUPJphBUmWHiAuRKJWdfuivRwe/TB3XPcrFD//ghzh4VqfYv5xe96ChNlk4VGmypsQuy2uUbLRbKJT+fP0K5V3eYhwNqfQkBHLtaB2BYtVHnoCOXqrSeLO4Ra7R1x+o0WrXiPWZN3gSUaclBfwwnHQ3zzGneIgrXi+uI5aINXKt6ryZ2S+lK3aeRj3Itp4m3GpJuEDy6rsbjwxnqE047dT8Z63miLVMqD5GUMmN6RjEKzn/u8POvPP8vdWhMnKFRHF002S7rpilQ15aYzajVKjE25b+bK4HWnPZm9Wg1IkPEHzi1yMmV+aatK9SrhRR5Ajpn5UEKeDqZaMcdP0BapR34rBHvt6LkgXD7lTfb5LmdSwd2FT95JCzkMMG1ZrZ1arQ66d6prNRhnDB+fqKBQLfbUXuwiai0njkGk5KrBhOeFiKwSd4b2xx/uhwnjRBQrUWikITVxfhEAfJYI5EkIDQdHoJAxUm8BDkzM9QBiq2QJ3Ztr4uyMUyH73oG0Hb0FJeBwAkHl6tBcP+gE60Rps5UCOlcb2b+nh1wj0GdmWOv8O6UR1Z5m6PrUxR3pVilATQHaT9ZVLKC+qgA/JTcYIHkjvfotZemzGBJMNMPhaZSUQ9LVR6xF6vgBQtEEaMLE7EG X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(40470700004)(46966006)(36840700001)(36860700001)(6666004)(82310400005)(36756003)(8676002)(5660300002)(44832011)(2906002)(4326008)(83380400001)(8936002)(70206006)(70586007)(40460700003)(356005)(54906003)(6916009)(316002)(478600001)(41300700001)(40480700001)(81166007)(2616005)(26005)(186003)(1076003)(7696005)(82740400003)(426003)(47076005)(336012)(86362001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7824 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cbdb8ee2-262e-4894-7b45-08da8c93a6bc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t3QbMjI06yOZjneEKCU9tzb5ER4JNv1EdB3zcE8PxLDgFNmfF00y0Mxbc/KHS5d8goHSx+7iOxiQVPugiVEWjy0LjOkZFmMPla2LndhKZVjIQiZ2kWOA3B8n8ejORTyr/ALG+2H9q9fxCbk4+Tjhl1fTHSsgmsfZTDtMyZwwOyLXcW0s+tdUfdZ8K3R7El6x9td3R64teFXkWqwzN9qdiXNaImnjFdAk8cm14+Ay21/tMmd0h4o21nWl51Bf5PZS6LtvVCCNNT7PllH81/Epzz7+axTaSt6KKyLZNJarEtqYljTzzzUlZEJpV3ayWzcM8Syc2l8gNLvvHcJDu9uRG3uTEUDwGdvceUZNRNQTr300zuRySIEV4CE3E+r6bgtBAED7lMB3weesOmk3RglS5vFIFE+TuGToYu6a0JgmFlg8fGC/ygO1RLHCv9GJqwKrQQlVqI4bN8kub82p+ajrs9ns0w+GMCj7upG2KhOWjjzmhzyfUXzRBfiIS/SAlL4FxhQ3lwrX+cgkCzHrxKIcuDOCwPXFkzC4/G97AmWZRDVXQaJcFwGRZ6mHHlZZ5uxz9ubo6ufgwqn+dSQBbLlkfjvvyZkeq/u9vjfjr+BwtPiWS059kCIQiZq17GubVUYsbW3izGJhvw7SchUQ1KzhtTqd/6SBLYcsYNZFAQSU10pupWoOCm7EHSt50Bk/WCr/EgetgbfeQhlxz51fFPeob0SntKH3DAUidWNMVWh4vTuvuJrzgU2/MMffZqz0avg/8FVg7c1DlR+gHSXPAfITfw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(36840700001)(46966006)(40470700004)(1076003)(426003)(47076005)(6666004)(2616005)(41300700001)(26005)(81166007)(86362001)(7696005)(40460700003)(36860700001)(83380400001)(336012)(186003)(82740400003)(40480700001)(36756003)(8936002)(5660300002)(4326008)(70206006)(70586007)(8676002)(2906002)(44832011)(478600001)(82310400005)(54906003)(6916009)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:31:51.5807 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 189b2cfa-822f-46c9-b182-08da8c93acf6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7836 acpi_numa is a specific NUMA switch for ACPI NUMA implementation. Other NUMA implementation may not need this switch. But this switch is not only used by ACPI code, it is also used directly in some general NUMA logic code. So far this hasn't caused any problem because Xen only has x86 implementing ACPI NUMA, but now Arm is implementing device tree based NUMA. Accesssing acpi_numa directly in some functions will be a block of reusing NUMA common code. It is also difficult for us to replace it with a new generic switch, because it is hard to prove that the new switch states can guarantee the original code will work correctly. So in this patch, we provide two helpers for common code to update and get states of acpi_numa. And other new NUMA implementations just need to provide the same helpers for common code. In this case, the generic NUMA logic code can be reused by all NUMA implementations. Signed-off-by: Wei Chen --- v3 -> v4: 1. Drop parameter from arch_numa_disabled, the parameter will be introduced in later patch where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. v1 -> v2: 1. Remove fw_numa. 2. Use enumeration to replace numa_off and acpi_numa. 3. Correct return value of srat_disabled. 4. Introduce numa_enabled_with_firmware. --- xen/arch/x86/include/asm/numa.h | 5 +++-- xen/arch/x86/numa.c | 38 ++++++++++++++++++++++----------- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index c32ccffde3..237f2c6dbf 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -32,8 +32,9 @@ extern void numa_add_cpu(int cpu); extern void numa_init_array(void); extern bool numa_off; - -extern int srat_disabled(void); +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_disabled(void); +extern bool srat_disabled(void); extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 627ae8aa95..a5bc7a78c9 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; bool numa_off; s8 acpi_numa = 0; -int srat_disabled(void) +int __init arch_numa_setup(const char *opt) { - return numa_off || acpi_numa < 0; +#ifdef CONFIG_ACPI_NUMA + if ( !strncmp(opt, "noacpi", 6) ) + { + numa_off = false; + acpi_numa = -1; + return 0; + } +#endif + + return -EINVAL; +} + +bool arch_numa_disabled(void) +{ + return acpi_numa < 0; +} + +bool srat_disabled(void) +{ + return numa_off || arch_numa_disabled(); } /* @@ -291,28 +310,21 @@ void numa_set_node(int cpu, nodeid_t node) /* [numa=off] */ static int __init cf_check numa_setup(const char *opt) { - if ( !strncmp(opt,"off",3) ) + if ( !strncmp(opt, "off", 3) ) numa_off = true; - else if ( !strncmp(opt,"on",2) ) + else if ( !strncmp(opt, "on", 2) ) numa_off = false; #ifdef CONFIG_NUMA_EMU else if ( !strncmp(opt, "fake=", 5) ) { numa_off = false; - numa_fake = simple_strtoul(opt+5,NULL,0); + numa_fake = simple_strtoul(opt + 5, NULL, 0); if ( numa_fake >= MAX_NUMNODES ) numa_fake = MAX_NUMNODES; } -#endif -#ifdef CONFIG_ACPI_NUMA - else if ( !strncmp(opt,"noacpi",6) ) - { - numa_off = false; - acpi_numa = -1; - } #endif else - return -EINVAL; + return arch_numa_setup(opt); return 0; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397241.637754 (Exim 4.92) (envelope-from ) id 1oTxPY-0004tD-IN; Fri, 02 Sep 2022 03:32:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397241.637754; Fri, 02 Sep 2022 03:32:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPY-0004t6-FO; Fri, 02 Sep 2022 03:32:04 +0000 Received: by outflank-mailman (input) for mailman id 397241; Fri, 02 Sep 2022 03:32:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPV-0004Wz-Vf for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:32:02 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80052.outbound.protection.outlook.com [40.107.8.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd047b2f-2a6f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:31:59 +0200 (CEST) Received: from AS9PR06CA0574.eurprd06.prod.outlook.com (2603:10a6:20b:486::12) by DB4PR08MB9310.eurprd08.prod.outlook.com (2603:10a6:10:3f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:31:55 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:486:cafe::c3) by AS9PR06CA0574.outlook.office365.com (2603:10a6:20b:486::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Fri, 2 Sep 2022 03:31:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:55 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 02 Sep 2022 03:31:55 +0000 Received: from 141fe9bc610f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B76D6802-23C4-43D7-917F-32D5CBFEFB05.1; Fri, 02 Sep 2022 03:31:49 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 141fe9bc610f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:31:49 +0000 Received: from DU2PR04CA0172.eurprd04.prod.outlook.com (2603:10a6:10:2b0::27) by GV1PR08MB8154.eurprd08.prod.outlook.com (2603:10a6:150:92::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Fri, 2 Sep 2022 03:31:46 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::d4) by DU2PR04CA0172.outlook.office365.com (2603:10a6:10:2b0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 2 Sep 2022 03:31:45 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:45 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:44 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd047b2f-2a6f-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ay7mTJE10ZArryG2jdemEo1OTQBY9AiGecZlPT6Xqy5FCzQLXiE/0fEsYgOeMESJ61zuempf8B+sAdrAVVolL2fyKiXr5nLS4jvSeOqXt9FBNj/HJYWZ51BEDB9jt7hJZeB8hoceOGXbNPZN74eMkyfKUcBw857iUI6jz5S135MM5PYBA9pWGSRqxUQXqVcDrYwpPifiT7QXXnW5R4ysPvQi/bsxqD01w685T/hVnLJF8DDZRsuITzDUrjTY6Qqga5neJPB3PtBm4T8w5dxMj+p11Aa8jx2uhtAGOxRSd3sV3SM+uiwnpymL7IBuc0k5YgZik7q4hSa5DRXWdlRaUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3JxDfGTgCwV+3K/QsVhEvgokhqhriH7vz3pd5PWXsY=; b=WODcaVs7iMD5MbekUnN198T5u+wSLjx+g+iNE5FXYJluM4/oA47oLo3dkkW5zAobGFpt2t5X4PTA2zDMchpiZzLL6J0pa6GAlR8M98LwFbtV9hB0gp5KwhSHAzWwfxvl8t1/bk+usRASkF7wvabRdVF5joIObcZKPRO1PM3KrXrJLKYx4uzSgM7iQdg2ohfH6bgKHjmv6oeaHOItjFxITFGg9UsEFBjav0kctlXLr7s2wLzdhWjdC6yaePGqc5at+0hUozChCToLem4f7vJQY8bYTR/Q/uoPEFXhHm7pgrEvWaZtYmfY378jxcH0KN/e901jUxnOjggCgnANlpqq/g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3JxDfGTgCwV+3K/QsVhEvgokhqhriH7vz3pd5PWXsY=; b=554UaewuSmuIxEp0HIv9AjKr40PioAVIbIFXBsnOgC4pN1wC5K61fRtoSExGNu3KheHwwuj9u5LNbu1GkPaSbOnv4t4M0zRuuQK/tb4aEbf4PYgP6Uil6czNXzdPyLX1gsYCQZWIz9DBEuMPF19GFZEIq6a+NaCYX4ZbWOmLYGY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ae6dbf44dc684e6f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JAqTYvORQPcMS+aug8+UfSzgOk7894pX0Z8816twi3u7ngi6/CsxVkT6TNBAqIctCnGf4NOpBUqiWDOe7vmKO0dJCqk7oke7Cakf6r3x6Wg0LAAJBkkQGsWkyJH9pezfy+uf1iVKKEOSu3SAVuySymSYX60Klgz/CSOCS1p+PPMayC8kOdX/NmZCLEgj0PRLj5qvyYzWXj5GshQNPFWtZCEbXNqXQHS5D1AcJZolw36Qycm7rUavu5HOL7R9S/tIayPHJW8AY+ycQM5jIWWBncj3VaSuTfehuq9MC4jGM0GaR7oy0G2qOXdTK3pYrhcFZ+gfsCWe48VLpaBeGuxwfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3JxDfGTgCwV+3K/QsVhEvgokhqhriH7vz3pd5PWXsY=; b=ZsY+s+9H1kyBGQ20WsTLy9LYJrakHh/MWi62FzKuoxltv2GejK4c80BvHmXnQ3bvtJ4d5OIuTD3e5aw/Qno0+p0cWivi1Sv6446YzDgzH2zeaGCpmMLFLm2OsFmE+UqCG1KgsBRBCk5bYZRiBO9xiaxnoAmXTS03xqiT/BIyrkt4vW5YjaquTqbsDAuHB9PFEVRvYAMS2RBosY9YorHAKY7pN2W7OCpX9DZJ9pqymRuaaSCIS82RykhUuue739G6gqGOwJmWADNF6wfDLXCXP5TcnvTKmKMo4jlB8UX55Tz9P0PQoqXquvwnQyZ/bLYZmdYAET6WnilNPmypGU2wYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3JxDfGTgCwV+3K/QsVhEvgokhqhriH7vz3pd5PWXsY=; b=554UaewuSmuIxEp0HIv9AjKr40PioAVIbIFXBsnOgC4pN1wC5K61fRtoSExGNu3KheHwwuj9u5LNbu1GkPaSbOnv4t4M0zRuuQK/tb4aEbf4PYgP6Uil6czNXzdPyLX1gsYCQZWIz9DBEuMPF19GFZEIq6a+NaCYX4ZbWOmLYGY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common Date: Fri, 2 Sep 2022 11:31:17 +0800 Message-ID: <20220902033121.540328-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902033121.540328-1-wei.chen@arm.com> References: <20220902033121.540328-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 7346aa42-52b8-4192-9fab-08da8c93af56 X-MS-TrafficTypeDiagnostic: GV1PR08MB8154:EE_|AM7EUR03FT004:EE_|DB4PR08MB9310:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1z27gsK03g+NldG0H/II4d3ALIarp7U4GThMCpbRm1XUkaiNZ50ua5w2aZARF6jq06OE81zuLSYkTEkUM1ny4Ar1hfsR6on4qTvawnU/wSziapbigHlDhbgdoNAehO+MGvOyuu0Gy4smyNdA0caIn/dCsDgj5EJjs42f1FgxL4Son8L9pzUC9PpwxGZiXk7izcYK2k4u1RJOLUw0tE1FTUa6YeLEQSv6CYI/Rfd9j8LjyKytY9JZD1XRyTxTb0IOYdAAun/IM+lxJILjBIh6W9JLshQw9+ZqNedUkQXBU9BC+8x7wfu5Yz/8o4TNRihBHdxiKWL15RRutRo/filGwHLDY5RBV/xCh3qUxvVzeqo213ZkeT3IHi91Fw4xdRot2n3q4kEnrsc4N2G8emTBvqBpf8EEgpi8vX1gplepV8WjnkFvonISwJr8T8vY61I7bMTEcVNz5WbFZNv3vxBgWPGYNTVN6Mi/0yKjmh0A5nCGSllygpyhGyMn1XlD3VH3600r8LsT3Z+Yhftu9CSZmy1q7baIC+x6z7nquBaWTUDs12OaT3+r2mAh1wVVemxgy7pu9xwOU8xNcfoWYg68CnUNw2/UeYgpMseBIplnq8Q97Qbq6CRpqv25iatDKLYJxmWakn0iZF92XGi1XMFPP7Hqz3aRPTHyMb4KCULW4Gr8nI8mljh/BcpDdhBxE9wTciawaV3qD2y0SLyY+pOlAqKVJeW0u4J4wLP+4tWWsfjyStECDfTasQMbseWo56h28e9NNTAG5ZrEtiWLD+czHXl4raHI26mi6OyaUctcAwTcf5vWenP6IE6BTOJf1r/DTnISY3x6fDGk8eRCGsafMg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(40470700004)(46966006)(36840700001)(36860700001)(6666004)(82310400005)(36756003)(8676002)(5660300002)(44832011)(30864003)(2906002)(4326008)(83380400001)(8936002)(70206006)(70586007)(40460700003)(356005)(54906003)(6916009)(316002)(478600001)(41300700001)(40480700001)(81166007)(2616005)(26005)(186003)(1076003)(7696005)(82740400003)(426003)(47076005)(336012)(86362001)(21314003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8154 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dd7ebdfe-e9ff-48ca-4ef8-08da8c93a988 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GTZWJUVJc68JJUS5hKDoVBbldyuSdEfDPCwg4i+QOlOnOSuwYBu6/j06e0J7dC0N9DLnxVHO0YA7FPIM9m2D2HjGA1je14WfVsPH6FP/jUOxv5Za0woUfOqE2rsD+WhDZiINByYPPVBWsOX8LghESqD/9CzUbcQKxFyQHs2HF6UCFt/cG0LibRnKJMsCrmZTgIrOoZ9yybBXlqptwflzTls9QOJLLDqwitM/Nb0P0B2vwuk+Q4FNQX6ySgXiGGab0h5csWIYgirKbJG5ht9tHx8ZJFiGffEsrPlTHSwcWhzLma9f9o+S63p+ZHi7vrHm0Oqh97PqPpsVWK6jlM5lwu2cBX+/QqVHLraZsl0d5yTrgkS9d9iYw2Hbx9dU3ucRnDuIlGjT+2NY8TWAj//mGKF5hHXYHkz2NfGHxxm3Ewe3pYxrv1j5koVXwcfskPWiCeWcfaCnHC9wtYzWlfoal2gRhDxp/6m869QnePoPiXKG1V1wiElvxlmiOJakj/HBdtdXnt7JaqVVfTb09G8/lV9BHBrdMFqmiDgjxJdyfU79QC9eVS1V6ntA41sAN6TmMWs8xtDepBnyrzjs0o02WRiEOCSSZTmMCn8lKwosODciyY9AVZ/QvDkwl0wcR9YRNRWgQX8P4eYEgl0Pq3rS2FAyK+3ie2lzWr0yeB0V66r8HBbEMDykhDrOCdMcG07s3U13UXTH6fKvsOFiVwmcQiey+Y7zDSRhHJIvRc27Sov/2EII5abLBjfo4UplFdfmvW81oq/fLIBnk3aPmpbXjgPZrk+qG65e1IpIc+6NRMc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(36840700001)(46966006)(40470700004)(26005)(186003)(7696005)(83380400001)(2616005)(81166007)(336012)(4326008)(70586007)(70206006)(8676002)(40460700003)(1076003)(478600001)(86362001)(6916009)(82310400005)(2906002)(5660300002)(47076005)(44832011)(6666004)(30864003)(426003)(107886003)(8936002)(36860700001)(36756003)(54906003)(316002)(82740400003)(41300700001)(40480700001)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:31:55.5336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7346aa42-52b8-4192-9fab-08da8c93af56 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9310 There are some codes in x86/numa.c can be shared by common architectures to implememnt NUMA support. Just like some variables and functions to check and store NUMA memory map. And some variables and functions to do NUMA initialization. In this patch, we move them to common/numa.c and xen/numa.h and use the CONFIG_NUMA to gate them for non-NUMA supported architectures. As the target header file is Xen-style, so we trim some spaces and replace tabs for the codes that has been moved to xen/numa.h at the same time. As acpi_scan_nodes has been used in a common function, it doesn't make sense to use acpi_xxx in common code, so we rename it to numa_scan_nodes in this patch too. After that if we still use CONFIG_ACPI_NUMA in to gate numa_scan_nodes in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA will be selected by CONFIG_ACPI_NUMA for x86. So, we replace CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_scan_nodes. As arch_numa_disabled has been implememnted for ACPI NUMA, we can rename srat_disabled to numa_disabled and move it to common code as well. Signed-off-by: Wei Chen --- v3 -> v4: 1. Restore compute_hash_shift's return value to int. 2. Remove unnecessary parentheses for macros. 3. Use unsigned int for proper variables. 4. Fix some code-style. v2 -> v3: 1. Remove acpi.h from common/numa.c. 2. Rename acpi_scan_nodes to numa_scan_nodes. 3. Replace u8 by uint8_t for memnodemap. 4. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 5. Use nodeid_t for nodeid and node numbers. 6. Use __read_mostly and __ro_after_init for appropriate variables. 7. Adjust the __read_mostly and __initdata location for some variables. 8. convert from plain int to unsigned for cpuid and other proper variables. 9. Use __attribute_pure__ instead of __attribute__((pure)). 10. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA in numa_initmem_init. 11. Add const for some functions' parameters. 12. Move srat_disabled to common code with new name numa_disabled. 13. Fix some spaces code-style for numa_emulation. 14. Change from int to unsigned int for numa_fake. v1 -> v2: 1. New patch in v2. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/numa.h | 57 +--- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/numa.c | 430 +----------------------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 8 +- xen/common/Makefile | 1 + xen/common/numa.c | 442 +++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 67 +++++ 9 files changed, 517 insertions(+), 492 deletions(-) create mode 100644 xen/common/numa.c diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 9a9cc4c240..5c2dd5da2d 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 237f2c6dbf..6c87942d43 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -9,72 +9,17 @@ typedef u8 nodeid_t; extern int srat_rev; -extern nodeid_t cpu_to_node[NR_CPUS]; -extern cpumask_t node_to_cpumask[]; - -#define cpu_to_node(cpu) (cpu_to_node[cpu]) -#define parent_node(node) (node) -#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) -#define node_to_cpumask(node) (node_to_cpumask[node]) - -struct node { - paddr_t start, end; -}; - -extern int compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids); extern nodeid_t pxm_to_node(unsigned int pxm); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) -#define VIRTUAL_BUG_ON(x) -extern void numa_add_cpu(int cpu); -extern void numa_init_array(void); -extern bool numa_off; - -extern int arch_numa_setup(const char *opt); -extern bool arch_numa_disabled(void); -extern bool srat_disabled(void); -extern void numa_set_node(int cpu, nodeid_t node); +extern bool numa_disabled(void); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); -static inline void clear_node_cpumask(int cpu) -{ - cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -/* Simple perfect hash to map pdx to node numbers */ -extern int memnode_shift; -extern unsigned long memnodemapsize; -extern u8 *memnodemap; - -struct node_data { - unsigned long node_start_pfn; - unsigned long node_spanned_pages; -}; - -extern struct node_data node_data[]; - -static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) -{ - nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); - nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); - return nid; -} - -#define NODE_DATA(nid) (&(node_data[nid])) - -#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) -#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) -#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ - NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..ae470ea12f 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -20,7 +20,6 @@ void early_time_init(void); void set_nr_cpu_ids(unsigned int max_cpus); -void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); void arch_init_memory(void); void subarch_init_memory(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index a5bc7a78c9..90b2a22591 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -4,20 +4,11 @@ * Adapted for Xen: Ryan Harper */ -#include -#include #include -#include +#include #include #include -#include -#include -#include -#include -#include #include -#include -#include #ifndef Dprintk #define Dprintk(x...) @@ -26,28 +17,13 @@ /* from proto.h */ #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1))) -struct node_data node_data[MAX_NUMNODES]; - -/* Mapping from pdx to node id */ -int memnode_shift; -static typeof(*memnodemap) _memnodemap[64]; -unsigned long memnodemapsize; -u8 *memnodemap; - -nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { - [0 ... NR_CPUS-1] = NUMA_NO_NODE -}; /* * Keep BIOS's CPU2node information, should not be used for memory allocaion */ nodeid_t apicid_to_node[MAX_LOCAL_APIC] = { [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE }; -cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; -nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; - -bool numa_off; s8 acpi_numa = 0; int __init arch_numa_setup(const char *opt) @@ -69,267 +45,6 @@ bool arch_numa_disabled(void) return acpi_numa < 0; } -bool srat_disabled(void) -{ - return numa_off || arch_numa_disabled(); -} - -/* - * Given a shift value, try to populate memnodemap[] - * Returns : - * 1 if OK - * 0 if memnodmap[] too small (of shift too small) - * -1 if node overlap or lost ram (shift too big) - */ -static int __init populate_memnodemap(const struct node *nodes, - int numnodes, int shift, nodeid_t *nodeids) -{ - unsigned long spdx, epdx; - int i, res = -1; - - memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - if ( (epdx >> shift) >= memnodemapsize ) - return 0; - do { - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) - return -1; - - if ( !nodeids ) - memnodemap[spdx >> shift] = i; - else - memnodemap[spdx >> shift] = nodeids[i]; - - spdx += (1UL << shift); - } while ( spdx < epdx ); - res = 1; - } - - return res; -} - -static int __init allocate_cachealigned_memnodemap(void) -{ - unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); - unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); - - memnodemap = mfn_to_virt(mfn); - mfn <<= PAGE_SHIFT; - size <<= PAGE_SHIFT; - printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", - mfn, mfn + size); - memnodemapsize = size / sizeof(*memnodemap); - - return 0; -} - -/* - * The LSB of all start and end addresses in the node map is the value of the - * maximum possible shift. - */ -static int __init extract_lsb_from_nodes(const struct node *nodes, - int numnodes) -{ - int i, nodes_used = 0; - unsigned long spdx, epdx; - unsigned long bitfield = 0, memtop = 0; - - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - bitfield |= spdx; - nodes_used++; - if ( epdx > memtop ) - memtop = epdx; - } - if ( nodes_used <= 1 ) - i = BITS_PER_LONG - 1; - else - i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = (memtop >> i) + 1; - return i; -} - -int __init compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids) -{ - int shift; - - shift = extract_lsb_from_nodes(nodes, numnodes); - if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) - memnodemap = _memnodemap; - else if ( allocate_cachealigned_memnodemap() ) - return -1; - printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); - - if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) - { - printk(KERN_INFO "Your memory is not aligned you need to " - "rebuild your hypervisor with a bigger NODEMAPSIZE " - "shift=%d\n", shift); - return -1; - } - - return shift; -} -/* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) -{ - unsigned long start_pfn = paddr_to_pfn(start); - unsigned long end_pfn = paddr_to_pfn(end); - - NODE_DATA(nodeid)->node_start_pfn = start_pfn; - NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; - - node_set_online(nodeid); -} - -void __init numa_init_array(void) -{ - int rr, i; - - /* There are unfortunately some poorly designed mainboards around - that only connect memory to a single CPU. This breaks the 1:1 cpu->node - mapping. To avoid this fill in the mapping for all possible - CPUs, as the number of CPUs is not known yet. - We round robin the existing nodes. */ - rr = first_node(node_online_map); - for ( i = 0; i < nr_cpu_ids; i++ ) - { - if ( cpu_to_node[i] != NUMA_NO_NODE ) - continue; - numa_set_node(i, rr); - rr = cycle_node(rr, node_online_map); - } -} - -#ifdef CONFIG_NUMA_EMU -static int numa_fake __initdata = 0; - -/* Numa emulation */ -static int __init numa_emulation(unsigned long start_pfn, - unsigned long end_pfn) -{ - int i; - struct node nodes[MAX_NUMNODES]; - uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; - - /* Kludge needed for the hash function */ - if ( hweight64(sz) > 1 ) - { - u64 x = 1; - while ( (x << 1) < sz ) - x <<= 1; - if ( x < sz/2 ) - printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); - sz = x; - } - - memset(&nodes,0,sizeof(nodes)); - for ( i = 0; i < numa_fake; i++ ) - { - nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; - if ( i == numa_fake - 1 ) - sz = pfn_to_paddr(end_pfn) - nodes[i].start; - nodes[i].end = nodes[i].start + sz; - printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", - i, - nodes[i].start, nodes[i].end, - (nodes[i].end - nodes[i].start) >> 20); - node_set_online(i); - } - memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); - if ( memnode_shift < 0 ) - { - memnode_shift = 0; - printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); - return -1; - } - for_each_online_node ( i ) - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - numa_init_array(); - - return 0; -} -#endif - -void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) -{ - int i; - paddr_t start = pfn_to_paddr(start_pfn); - paddr_t end = pfn_to_paddr(end_pfn); - -#ifdef CONFIG_NUMA_EMU - if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) - return; -#endif - -#ifdef CONFIG_ACPI_NUMA - if ( !numa_off && !acpi_scan_nodes(start, end) ) - return; -#endif - - printk(KERN_INFO "%s\n", - numa_off ? "NUMA turned off" : "No NUMA configuration found"); - - printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", - start, end); - /* setup dummy node covering all memory */ - memnode_shift = BITS_PER_LONG - 1; - memnodemap = _memnodemap; - /* Dummy node only uses 1 slot in reality */ - memnodemap[0] = 0; - memnodemapsize = 1; - - nodes_clear(node_online_map); - node_set_online(0); - for ( i = 0; i < nr_cpu_ids; i++ ) - numa_set_node(i, 0); - cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); - setup_node_bootmem(0, start, end); -} - -void numa_add_cpu(int cpu) -{ - cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -void numa_set_node(int cpu, nodeid_t node) -{ - cpu_to_node[cpu] = node; -} - -/* [numa=off] */ -static int __init cf_check numa_setup(const char *opt) -{ - if ( !strncmp(opt, "off", 3) ) - numa_off = true; - else if ( !strncmp(opt, "on", 2) ) - numa_off = false; -#ifdef CONFIG_NUMA_EMU - else if ( !strncmp(opt, "fake=", 5) ) - { - numa_off = false; - numa_fake = simple_strtoul(opt + 5, NULL, 0); - if ( numa_fake >= MAX_NUMNODES ) - numa_fake = MAX_NUMNODES; - } -#endif - else - return arch_numa_setup(opt); - - return 0; -} -custom_param("numa", numa_setup); - /* * Setup early cpu_to_node. * @@ -378,146 +93,3 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } - -static void cf_check dump_numa(unsigned char key) -{ - s_time_t now = NOW(); - unsigned int i, j, n; - struct domain *d; - struct page_info *page; - unsigned int page_num_node[MAX_NUMNODES]; - const struct vnuma_info *vnuma; - - printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, - now); - - for_each_online_node ( i ) - { - paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); - - printk("NODE%u start->%lu size->%lu free->%lu\n", - i, node_start_pfn(i), node_spanned_pages(i), - avail_node_heap_pages(i)); - /* sanity check phys_to_nid() */ - if ( phys_to_nid(pa) != i ) - printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", - pa, phys_to_nid(pa), i); - } - - j = cpumask_first(&cpu_online_map); - n = 0; - for_each_online_cpu ( i ) - { - if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) - { - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - j = i; - n = 1; - } - else - ++n; - } - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - - rcu_read_lock(&domlist_read_lock); - - printk("Memory location of each domain:\n"); - for_each_domain ( d ) - { - process_pending_softirqs(); - - printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); - - for_each_online_node ( i ) - page_num_node[i] = 0; - - spin_lock(&d->page_alloc_lock); - page_list_for_each(page, &d->page_list) - { - i = phys_to_nid(page_to_maddr(page)); - page_num_node[i]++; - } - spin_unlock(&d->page_alloc_lock); - - for_each_online_node ( i ) - printk(" Node %u: %u\n", i, page_num_node[i]); - - if ( !read_trylock(&d->vnuma_rwlock) ) - continue; - - if ( !d->vnuma ) - { - read_unlock(&d->vnuma_rwlock); - continue; - } - - vnuma = d->vnuma; - printk(" %u vnodes, %u vcpus, guest physical layout:\n", - vnuma->nr_vnodes, d->max_vcpus); - for ( i = 0; i < vnuma->nr_vnodes; i++ ) - { - unsigned int start_cpu = ~0U; - - if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) - printk(" %3u: pnode ???,", i); - else - printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); - - printk(" vcpus "); - - for ( j = 0; j < d->max_vcpus; j++ ) - { - if ( !(j & 0x3f) ) - process_pending_softirqs(); - - if ( vnuma->vcpu_to_vnode[j] == i ) - { - if ( start_cpu == ~0U ) - { - printk("%d", j); - start_cpu = j; - } - } - else if ( start_cpu != ~0U ) - { - if ( j - 1 != start_cpu ) - printk("-%d ", j - 1); - else - printk(" "); - start_cpu = ~0U; - } - } - - if ( start_cpu != ~0U && start_cpu != j - 1 ) - printk("-%d", j - 1); - - printk("\n"); - - for ( j = 0; j < vnuma->nr_vmemranges; j++ ) - { - if ( vnuma->vmemrange[j].nid == i ) - printk(" %016"PRIx64" - %016"PRIx64"\n", - vnuma->vmemrange[j].start, - vnuma->vmemrange[j].end); - } - } - - read_unlock(&d->vnuma_rwlock); - } - - rcu_read_unlock(&domlist_read_lock); -} - -static int __init cf_check register_numa_trigger(void) -{ - register_keyhandler('u', dump_numa, "dump NUMA info", 1); - return 0; -} -__initcall(register_numa_trigger); - diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b46fd9ab18..9df08e9366 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1350,7 +1350,7 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm) x86_acpiid_to_apicid[acpi_id] = apic_id; - if ( !srat_disabled() ) + if ( !numa_disabled() ) { nodeid_t node = setup_node(pxm); diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index b62a152911..4c7f0c547e 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -238,7 +238,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { bad_srat(); @@ -274,7 +274,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { bad_srat(); @@ -313,7 +313,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) nodeid_t node; unsigned int i; - if (srat_disabled()) + if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { bad_srat(); @@ -520,7 +520,7 @@ void __init srat_parse_regions(paddr_t addr) } /* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(paddr_t start, paddr_t end) +int __init numa_scan_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; diff --git a/xen/common/Makefile b/xen/common/Makefile index 3baf83d527..9a3a12b12d 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o obj-y += multicall.o obj-y += notifier.o +obj-$(CONFIG_NUMA) += numa.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o diff --git a/xen/common/numa.c b/xen/common/numa.c new file mode 100644 index 0000000000..03e7318d72 --- /dev/null +++ b/xen/common/numa.c @@ -0,0 +1,442 @@ +/* + * Generic VM initialization for NUMA setups. + * Copyright 2002,2003 Andi Kleen, SuSE Labs. + * Adapted for Xen: Ryan Harper + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +struct node_data __ro_after_init node_data[MAX_NUMNODES]; + +/* Mapping from pdx to node id */ +unsigned int __ro_after_init memnode_shift; +unsigned long __ro_after_init memnodemapsize; +uint8_t *__ro_after_init memnodemap; +static uint8_t __ro_after_init _memnodemap[64]; + +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { + [0 ... NR_CPUS-1] = NUMA_NO_NODE +}; + +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; + +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; + +bool __read_mostly numa_off; + +bool numa_disabled(void) +{ + return numa_off || arch_numa_disabled(); +} + +/* + * Given a shift value, try to populate memnodemap[] + * Returns : + * 1 if OK + * 0 if memnodmap[] too small (of shift too small) + * -1 if node overlap or lost ram (shift too big) + */ +static int __init populate_memnodemap(const struct node *nodes, + unsigned int numnodes, unsigned int shift, + nodeid_t *nodeids) +{ + unsigned long spdx, epdx; + unsigned int i; + int res = -1; + + memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); + for ( i = 0; i < numnodes; i++ ) + { + spdx = paddr_to_pdx(nodes[i].start); + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + if ( spdx >= epdx ) + continue; + if ( (epdx >> shift) >= memnodemapsize ) + return 0; + do { + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) + return -1; + + if ( !nodeids ) + memnodemap[spdx >> shift] = i; + else + memnodemap[spdx >> shift] = nodeids[i]; + + spdx += (1UL << shift); + } while ( spdx < epdx ); + res = 1; + } + + return res; +} + +static int __init allocate_cachealigned_memnodemap(void) +{ + unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); + unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); + + memnodemap = mfn_to_virt(mfn); + mfn <<= PAGE_SHIFT; + size <<= PAGE_SHIFT; + printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", + mfn, mfn + size); + memnodemapsize = size / sizeof(*memnodemap); + + return 0; +} + +/* + * The LSB of all start and end addresses in the node map is the value of the + * maximum possible shift. + */ +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, + nodeid_t numnodes) +{ + unsigned int i; + nodeid_t nodes_used = 0; + unsigned long spdx, epdx; + unsigned long bitfield = 0, memtop = 0; + + for ( i = 0; i < numnodes; i++ ) + { + spdx = paddr_to_pdx(nodes[i].start); + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + if ( spdx >= epdx ) + continue; + bitfield |= spdx; + nodes_used++; + if ( epdx > memtop ) + memtop = epdx; + } + if ( nodes_used <= 1 ) + i = BITS_PER_LONG - 1; + else + i = find_first_bit(&bitfield, sizeof(unsigned long)*8); + memnodemapsize = (memtop >> i) + 1; + return i; +} + +int __init compute_hash_shift(const struct node *nodes, + nodeid_t numnodes, nodeid_t *nodeids) +{ + unsigned int shift; + + shift = extract_lsb_from_nodes(nodes, numnodes); + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) + memnodemap = _memnodemap; + else if ( allocate_cachealigned_memnodemap() ) + return -1; + printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); + + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) + { + printk(KERN_INFO "Your memory is not aligned you need to " + "rebuild your hypervisor with a bigger NODEMAPSIZE " + "shift=%d\n", shift); + return -1; + } + + return shift; +} + +/* initialize NODE_DATA given nodeid and start/end */ +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); + + NODE_DATA(nodeid)->node_start_pfn = start_pfn; + NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; + + node_set_online(nodeid); +} + +void __init numa_init_array(void) +{ + unsigned int i; + nodeid_t rr; + + /* + * There are unfortunately some poorly designed mainboards around + * that only connect memory to a single CPU. This breaks the 1:1 cpu->node + * mapping. To avoid this fill in the mapping for all possible + * CPUs, as the number of CPUs is not known yet. + * We round robin the existing nodes. + */ + rr = first_node(node_online_map); + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] != NUMA_NO_NODE ) + continue; + numa_set_node(i, rr); + rr = cycle_node(rr, node_online_map); + } +} + +#ifdef CONFIG_NUMA_EMU +static unsigned int __initdata numa_fake; + +/* Numa emulation */ +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) +{ + unsigned int i; + struct node nodes[MAX_NUMNODES]; + uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; + + /* Kludge needed for the hash function */ + if ( hweight64(sz) > 1 ) + { + uint64_t x = 1; + + while ( (x << 1) < sz ) + x <<= 1; + if ( x < sz / 2 ) + printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); + sz = x; + } + + memset(&nodes, 0, sizeof(nodes)); + for ( i = 0; i < numa_fake; i++ ) + { + nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; + if ( i == numa_fake - 1 ) + sz = pfn_to_paddr(end_pfn) - nodes[i].start; + nodes[i].end = nodes[i].start + sz; + printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", + i, nodes[i].start, nodes[i].end, + (nodes[i].end - nodes[i].start) >> 20); + node_set_online(i); + } + memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); + if ( memnode_shift < 0 ) + { + memnode_shift = 0; + printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); + return -1; + } + for_each_online_node ( i ) + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + numa_init_array(); + + return 0; +} +#endif + +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) +{ + unsigned int i; + paddr_t start = pfn_to_paddr(start_pfn); + paddr_t end = pfn_to_paddr(end_pfn); + +#ifdef CONFIG_NUMA_EMU + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) + return; +#endif + +#ifdef CONFIG_NUMA + if ( !numa_off && !numa_scan_nodes(start, end) ) + return; +#endif + + printk(KERN_INFO "%s\n", + numa_off ? "NUMA turned off" : "No NUMA configuration found"); + + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", + start, end); + /* setup dummy node covering all memory */ + memnode_shift = BITS_PER_LONG - 1; + memnodemap = _memnodemap; + /* Dummy node only uses 1 slot in reality */ + memnodemap[0] = 0; + memnodemapsize = 1; + + nodes_clear(node_online_map); + node_set_online(0); + for ( i = 0; i < nr_cpu_ids; i++ ) + numa_set_node(i, 0); + cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); + setup_node_bootmem(0, start, end); +} + +void numa_add_cpu(unsigned int cpu) +{ + cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +void numa_set_node(unsigned int cpu, nodeid_t node) +{ + cpu_to_node[cpu] = node; +} + +/* [numa=off] */ +static int __init cf_check numa_setup(const char *opt) +{ + if ( !strncmp(opt, "off", 3) ) + numa_off = true; + else if ( !strncmp(opt, "on", 2) ) + numa_off = false; +#ifdef CONFIG_NUMA_EMU + else if ( !strncmp(opt, "fake=", 5) ) + { + numa_off = false; + numa_fake = simple_strtoul(opt + 5, NULL, 0); + if ( numa_fake >= MAX_NUMNODES ) + numa_fake = MAX_NUMNODES; + } +#endif + else + return arch_numa_setup(opt); + + return 0; +} +custom_param("numa", numa_setup); + +static void cf_check dump_numa(unsigned char key) +{ + s_time_t now = NOW(); + unsigned int i, j, n; + struct domain *d; + struct page_info *page; + unsigned int page_num_node[MAX_NUMNODES]; + const struct vnuma_info *vnuma; + + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, + now); + + for_each_online_node ( i ) + { + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); + + printk("NODE%u start->%lu size->%lu free->%lu\n", + i, node_start_pfn(i), node_spanned_pages(i), + avail_node_heap_pages(i)); + /* sanity check phys_to_nid() */ + if ( phys_to_nid(pa) != i ) + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", + pa, phys_to_nid(pa), i); + } + + j = cpumask_first(&cpu_online_map); + n = 0; + for_each_online_cpu ( i ) + { + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) + { + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + j = i; + n = 1; + } + else + ++n; + } + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + + rcu_read_lock(&domlist_read_lock); + + printk("Memory location of each domain:\n"); + for_each_domain ( d ) + { + process_pending_softirqs(); + + printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); + + for_each_online_node ( i ) + page_num_node[i] = 0; + + spin_lock(&d->page_alloc_lock); + page_list_for_each(page, &d->page_list) + { + i = phys_to_nid(page_to_maddr(page)); + page_num_node[i]++; + } + spin_unlock(&d->page_alloc_lock); + + for_each_online_node ( i ) + printk(" Node %u: %u\n", i, page_num_node[i]); + + if ( !read_trylock(&d->vnuma_rwlock) ) + continue; + + if ( !d->vnuma ) + { + read_unlock(&d->vnuma_rwlock); + continue; + } + + vnuma = d->vnuma; + printk(" %u vnodes, %u vcpus, guest physical layout:\n", + vnuma->nr_vnodes, d->max_vcpus); + for ( i = 0; i < vnuma->nr_vnodes; i++ ) + { + unsigned int start_cpu = ~0U; + + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) + printk(" %3u: pnode ???,", i); + else + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); + + printk(" vcpus "); + + for ( j = 0; j < d->max_vcpus; j++ ) + { + if ( !(j & 0x3f) ) + process_pending_softirqs(); + + if ( vnuma->vcpu_to_vnode[j] == i ) + { + if ( start_cpu == ~0U ) + { + printk("%d", j); + start_cpu = j; + } + } + else if ( start_cpu != ~0U ) + { + if ( j - 1 != start_cpu ) + printk("-%d ", j - 1); + else + printk(" "); + start_cpu = ~0U; + } + } + + if ( start_cpu != ~0U && start_cpu != j - 1 ) + printk("-%d", j - 1); + + printk("\n"); + + for ( j = 0; j < vnuma->nr_vmemranges; j++ ) + { + if ( vnuma->vmemrange[j].nid == i ) + printk(" %016"PRIx64" - %016"PRIx64"\n", + vnuma->vmemrange[j].start, + vnuma->vmemrange[j].end); + } + } + + read_unlock(&d->vnuma_rwlock); + } + + rcu_read_unlock(&domlist_read_lock); +} + +static int __init cf_check register_numa_trigger(void) +{ + register_keyhandler('u', dump_numa, "dump NUMA info", 1); + return 0; +} +__initcall(register_numa_trigger); diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 7aef1a88dc..baef4cd553 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -18,4 +18,71 @@ (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) +/* The following content can be used when NUMA feature is enabled */ +#ifdef CONFIG_NUMA + +extern nodeid_t cpu_to_node[NR_CPUS]; +extern cpumask_t node_to_cpumask[]; + +#define cpu_to_node(cpu) cpu_to_node[cpu] +#define parent_node(node) (node) +#define node_to_first_cpu(node) __ffs(node_to_cpumask[node]) +#define node_to_cpumask(node) node_to_cpumask[node] + +struct node { + paddr_t start, end; +}; + +extern int compute_hash_shift(const struct node *nodes, + nodeid_t numnodes, nodeid_t *nodeids); + +#define VIRTUAL_BUG_ON(x) + +extern bool numa_off; + +extern void numa_add_cpu(unsigned int cpu); +extern void numa_init_array(void); +extern void numa_set_node(unsigned int cpu, nodeid_t node); +extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); +extern int numa_scan_nodes(paddr_t start, paddr_t end); + +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_disabled(void); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); + +static inline void clear_node_cpumask(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +/* Simple perfect hash to map pdx to node numbers */ +extern unsigned int memnode_shift; +extern unsigned long memnodemapsize; +extern uint8_t *memnodemap; + +struct node_data { + unsigned long node_start_pfn; + unsigned long node_spanned_pages; +}; + +extern struct node_data node_data[]; + +static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) +{ + nodeid_t nid; + VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; + VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + return nid; +} + +#define NODE_DATA(nid) (&node_data[nid]) + +#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) +#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) +#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ + NODE_DATA(nid)->node_spanned_pages) + +#endif + #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:32:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397242.637760 (Exim 4.92) (envelope-from ) id 1oTxPZ-00050U-5E; Fri, 02 Sep 2022 03:32:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397242.637760; Fri, 02 Sep 2022 03:32:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPY-0004y0-WD; Fri, 02 Sep 2022 03:32:05 +0000 Received: by outflank-mailman (input) for mailman id 397242; Fri, 02 Sep 2022 03:32:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPX-0004Wz-BY for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:32:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70078.outbound.protection.outlook.com [40.107.7.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf29d2fd-2a6f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:32:02 +0200 (CEST) Received: from DB6PR0201CA0026.eurprd02.prod.outlook.com (2603:10a6:4:3f::36) by AM9PR08MB6642.eurprd08.prod.outlook.com (2603:10a6:20b:2ff::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:31:59 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::b0) by DB6PR0201CA0026.outlook.office365.com (2603:10a6:4:3f::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 2 Sep 2022 03:31:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:59 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 02 Sep 2022 03:31:59 +0000 Received: from 02871d7c7b46.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 205AAEA6-0047-483B-B2A4-59D5C8FBA078.1; Fri, 02 Sep 2022 03:31:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02871d7c7b46.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:31:53 +0000 Received: from DB6PR07CA0052.eurprd07.prod.outlook.com (2603:10a6:6:2a::14) by AS8PR08MB8490.eurprd08.prod.outlook.com (2603:10a6:20b:567::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:31:50 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::d2) by DB6PR07CA0052.outlook.office365.com (2603:10a6:6:2a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Fri, 2 Sep 2022 03:31:50 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:50 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:50 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:49 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf29d2fd-2a6f-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ShlnwG+b8zbpZNncZipqcLCfRgqI5XneJ5iEtA5TLwtZhXMMyJipbAPaMZy10JG+JKyFywBqq66cx1/rrHw0GhP5MJQ+1Q3R6AF0Fl3Yto/GtCMeiNrhT4mtCz/+z3r2Y9UR2N4JUsOzYLIjtUh3fgtNMxKTIAG0bL06bu+RX0RD0oMDiIHuuUU7q339YJ4g9aFfDEGGdJ79TLWYa1CK2ryIRzsmYC8vU4peq337XGBAKovOXIT64ErR4qRQRaVRuz5JrLgZWAoByxueOHhArL74Y1DbTAnf4qyzg8EYpKSkthvz6e/UVOvtJxMhNUPqOQgWevU4VgcVKwm7jcl3Tw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8Uwp6+nNlC0JAJBM8aB8Lyt4DmvZi8C88afoGTR6cA=; b=Nm8RkcidI6bOg5wy+UIdGvM5kyKStFNXPFVZBjYb4NJlmyVvEmN00YOIiKmxTmEwvPquJDsF8nIv+4iCqUbDFNuESNQivCQHt4H+oiOAsPBG1RJQe4QASIJ7Xviaew1LSXb2U5gsdk0oPa1jmMKmQzFyPFSXw2YfcPk5x4qBZSgdVXPMalkEz9DrhAsWCK/JIS0rbYwSE4mn9hrIq0jVph5+nr+0YaCvwqGgrSHi3hHzChNqqrHEYsiWoffqUwiee5Q3XN+3jRRQwj92wcQgblb1z3pk5hXvbj4vVUvEM0bUmYxXwXVsBm3SYvU/jHYBeELVYZwfOMA1oI1nTF2kVw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8Uwp6+nNlC0JAJBM8aB8Lyt4DmvZi8C88afoGTR6cA=; b=a5X29prkA/1jpbKfEoe/jDTxx4tq4pdxInUzmpjU/HdQVzvzEjKxb2xy5R1BDNXKxlUs++HJhyw67f4kOFMsAKR0QtmU8XNLCsvqW1lxIrrsQc8pypWAPKMvuUiRksNe3EPakcufZi7hEH523F0WH7b/wioaF0C59pLG6AicZtk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f1890f22cd6330db X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJEylBXXaGPmRlgU+fDnPbI5sGLGlqiY66gCfMAbxQxtZa/E/0pgpqm0vnOuT5G+JYnZeYDcREvrYB2wvIdEftbaUuZMbv3DcCilVqPQEqALS1bQXxHGqjnPj/XdWtEgLc9FamDEzj4bjdDuPyDQRv9AJ1Mpqvsh/uxEejkPqCp441I3Q0+9+PIAbpSwf/YGV7lkSnwlQRNYaIrnvXJMVsVC/cGJRBh8THeghEUcQqBNFYB0TCozlnK121XlXXisJiNkQb5MQcnAYxHDyOSXjW9uzXMzIyIeKodCfOD0tJK/VCsWLJdo7rAtMI3n7Of4aAqzzzgp7pOdfaZjW77+xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8Uwp6+nNlC0JAJBM8aB8Lyt4DmvZi8C88afoGTR6cA=; b=J86Tu2GnjgXH2HWIQj5B6Bq4D8n5hwFxYayq6DdqxeyHAyYijn3o4BqSkNEOriaPmiUu6+0G1HlcGRNR4cGvm0/+Y/8VQ5x/FHdsBa041vXaNju86DmzbmDU/oDRZKQNReQ092JLZYJJ+S6iZnzTfMPk01Bf6ak7evfezpJ3VWeggo6rmInNmVxu2470SDE+oZqNVgCgl2y7WZ6sqLODavC6guUxrosWXLn8QM9BNbXc+8n7+a8Rz9AXPWHomExEajq/W/zzWLGlJc+/olrh24sn2zJeV6V5b6Zj/RPtkJtYWwSPhwF0Jhw+3QlhvICdtdJhXj6HdlUv5G/U/ZpS2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8Uwp6+nNlC0JAJBM8aB8Lyt4DmvZi8C88afoGTR6cA=; b=a5X29prkA/1jpbKfEoe/jDTxx4tq4pdxInUzmpjU/HdQVzvzEjKxb2xy5R1BDNXKxlUs++HJhyw67f4kOFMsAKR0QtmU8XNLCsvqW1lxIrrsQc8pypWAPKMvuUiRksNe3EPakcufZi7hEH523F0WH7b/wioaF0C59pLG6AicZtk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Jiamei Xie Subject: [PATCH v4 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Date: Fri, 2 Sep 2022 11:31:18 +0800 Message-ID: <20220902033121.540328-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902033121.540328-1-wei.chen@arm.com> References: <20220902033121.540328-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 2ab30867-705c-4176-f435-08da8c93b1b6 X-MS-TrafficTypeDiagnostic: AS8PR08MB8490:EE_|DBAEUR03FT025:EE_|AM9PR08MB6642:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: T3PBpuTx8nk8FTkjrCL5aA8JMO5gHizsOhGLk0weIMimA8O1/hBKxAYDVtug+HfRa2+1p9JEIYXnKQcbdXjofLSVFivqVK3eJpxACgX+fz5STyfww9/QbIJyYE4eEIqH71/UlTQwcwsnMmE68BFzdLpsmK+9x1qzZFdcqGCDwUYo5iOuqo50fA1T+bdmTVf4hmi/JpnFhqZ2dgPjmnlCWWBbKAdeEmRtT/UOASHi4ERG95wf9vTQY3TyURR4A7GNllzgyM5caZB9XAYi4QO3CeydLMAc2mQIiEn+d/ugjUxZ+1IfU6FQK1zCcJwZGY129YUiCpvN4hNxYd8KmG9aG9WD8wh1L9W9GWSxR87xnGo7r0kM6qxK+4xMfz1MWbMB2EiNobv6OSoRGlnT1nLuqqRzsqTj+0qztTHdcbDBEYF+rgku+Yi0z7N7lGI/Ub52ymbPUA0B2G5r0CcD6voJwg8gtevHEcHRSePZNO3uiPR7LnI9wCBkk5R5UHEvkBPWcuZttSMPDWRgHHVJ+RFxDoKjzLDlrtjPQAV/5sdbRWvYOGerpYZMe8rFamNq9/uVxzzWlH17jF+oCPlApO7okxSRiCOpyLPKzE775svq2zx/LWVQJTZDTr0jAs6OvkzIn4zglVN4GcOBIKMenuTbJRx/6zHhO7tCxiuPOrbufJNOzM/o8Z5tUEfNinR+4/i/h+3FSj+1ZsgUd7FznbPHT5dHPmBheEuFIaiAYFxW7mMbu/ZEmCg4wjwp3OlKE9VJYm1g9lONsUYwgU4ZNourarGvsZtQRpiYWQ2JOU0bhp19ApydEt+HtmKXbkPp7RoI X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(40470700004)(36840700001)(46966006)(86362001)(26005)(426003)(8936002)(1076003)(40480700001)(7696005)(2906002)(44832011)(5660300002)(47076005)(186003)(36756003)(41300700001)(6666004)(2616005)(478600001)(336012)(356005)(8676002)(81166007)(83380400001)(82310400005)(36860700001)(54906003)(4326008)(70586007)(6916009)(40460700003)(70206006)(82740400003)(316002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8490 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2ef1b529-e9bd-4c8f-a242-08da8c93ac47 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +YlNvsYQ3cIlGUPp/braoFVDdcuWvSrGfQZp4EJLml8psDOPmXtBTm1tEUlyj6Gf8aV0WUF+D1J8hW82Hcj0eTEUjIh7tR2rL7joHkNnAlEPi73lmc+vK+6q6FmGkxmLpRXLGUF0nd6vR9rHZIE2LNwZd6bzMS0oI6AEOPjEwOLUwFv3fNmAOIYw15o5uFlAvV4ULcgXHc6UeXDoFRGzMZ7M2D7HuT1ZtpVtGgb6mKgPqeDkb8fhR4PTxupZ8nfNk5LcNHzAgzW6XMYwv561KqxsL+r4XeCJIxjYQybR3cjv8EFFByRsBn0tmCjF6r4nKVeuWuaFmNl7aRvH2HPflv14Nfvc81yxG19qXlCrNppY5bDA0m5JB5Em9lqRT7CA9q2JxvXPHK1VBX23rCMsedsmontHfrf44iR3dg9p4EPmrb81n2+CA4AS74vvUZ0JPBimP4OcVX5K/+MnmvqQr4/oHV9jrxADXfBJYb9UWbGvssGhil9ZsUe2NCEzjtXAIglwjd15BUK+ocioOc+tJVIgurgomkgiiRMgHYZd8qihc+km2ym7G/+QNBf+WoixturODuVRU9BvPGj1IVo9GsFWr5RkoY/PadCQXQD/gzmIdsjH6LLTOwVo7e8HfpKspQeEhBW1/kpFtu4H1G6MU/P3DSsDxPQJeSeEBfbwe1RsJEFRcjnsNsMdRQUxAM/3FpJtt3OVlQ0VP1XHt2IG+QDfX8epd10Y4/PFn7qktGwTKq+DD3fyZm7JSlPxZ38pPFFEW57iPtbb+1Z/CSJ2zA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(46966006)(36840700001)(40470700004)(54906003)(6916009)(26005)(2906002)(44832011)(40460700003)(36860700001)(82310400005)(36756003)(316002)(478600001)(70206006)(70586007)(5660300002)(82740400003)(81166007)(41300700001)(40480700001)(86362001)(1076003)(426003)(336012)(47076005)(7696005)(2616005)(83380400001)(4326008)(186003)(8936002)(6666004)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:31:59.5828 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ab30867-705c-4176-f435-08da8c93b1b6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6642 VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This results in two lines of error-checking code in phys_to_nid that is not actually working and causing two compilation errors: 1. error: "MAX_NUMNODES" undeclared (first use in this function). This is because in the common header file, "MAX_NUMNODES" is defined after the common header file includes the ARCH header file, where phys_to_nid has attempted to use "MAX_NUMNODES". This error was resolved after we moved the phys_to_nid from x86 ARCH header file to common header file. 2. error: wrong type argument to unary exclamation mark. This is because, the error-checking code contains !node_data[nid]. But node_data is a data structure variable, it's not a pointer. So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to enable the two lines of error-checking code. And fix the left compilation errors by replacing !node_data[nid] to !node_data[nid].node_spanned_pages. Although NUMA allows one node can only have CPUs but without any memory. And node with 0 bytes of memory might have an entry in memnodemap[] theoretically. But that doesn't mean phys_to_nid can find any valid address from a node with 0 bytes memory. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Jan Beulich --- v3 -> v4: no change. v2 -> v3: 1. Remove unnecessary change items in history. 2. Add Acked-by. v1 -> v2: 1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 2. Adjust the conditional express for ASSERT. 3. Refine the justification of using !node_data[nid].node_spanned_pages. --- xen/include/xen/numa.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index baef4cd553..af0abfc8cf 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -36,8 +36,6 @@ struct node { extern int compute_hash_shift(const struct node *nodes, nodeid_t numnodes, nodeid_t *nodeids); -#define VIRTUAL_BUG_ON(x) - extern bool numa_off; extern void numa_add_cpu(unsigned int cpu); @@ -70,9 +68,9 @@ extern struct node_data node_data[]; static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) { nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize); nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages); return nid; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:32:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:32:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397243.637776 (Exim 4.92) (envelope-from ) id 1oTxPf-0005Yr-Cu; Fri, 02 Sep 2022 03:32:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397243.637776; Fri, 02 Sep 2022 03:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPf-0005Ye-9R; Fri, 02 Sep 2022 03:32:11 +0000 Received: by outflank-mailman (input) for mailman id 397243; Fri, 02 Sep 2022 03:32:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPd-0004Wz-C7 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:32:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d266de92-2a6f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:32:08 +0200 (CEST) Received: from AM7PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:20b:110::28) by GV2PR08MB8654.eurprd08.prod.outlook.com (2603:10a6:150:b6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:32:04 +0000 Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::f2) by AM7PR04CA0018.outlook.office365.com (2603:10a6:20b:110::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 2 Sep 2022 03:32:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:32:03 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 02 Sep 2022 03:32:03 +0000 Received: from 8e115e350a08.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7C8400A7-3BB1-4017-8661-2C108810F8C9.1; Fri, 02 Sep 2022 03:31:56 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e115e350a08.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:31:56 +0000 Received: from DB6PR0601CA0042.eurprd06.prod.outlook.com (2603:10a6:4:17::28) by AS8PR08MB6408.eurprd08.prod.outlook.com (2603:10a6:20b:33a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 03:31:55 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:17:cafe::77) by DB6PR0601CA0042.outlook.office365.com (2603:10a6:4:17::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:55 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:54 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:53 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d266de92-2a6f-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CPEs1MKbh+DII0mmCVBppGkLwQBgm2/lNzzemOeMh9zte5bUZnBfAToU4pyVyHT5k8MoXFDwtpjTFCLElKx00Lqr3tmxvJxd7AlcrvTZMMKopc2yOutCbTe0L6QMgGoIUQtSeI/Fu0K8o4hqJNI7soBj+lU2Zd2SgHnMewbjsc++dfHwplTQHa1B3QblSkO/YC+f/rSKjVCXEtoWtjzY+ddJ8ZwCW5wQdGTfvF5SjTtQx20757MbjwIWbP4cHD+rmse+TAJrxLMSiCoNpRbv56Yp/Cuq1ywQ4Z0WazgbfnB6f1URkufo6gLzs7X8LelxCprtcMRRY9d/as2eIf3MRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3rJl4bvG5P28lwjcobHRthLqJO4TGcF+IiJpvc5pSCc=; b=KjS+Y4JBXjVMR+zj4B8apvGn2LM9O0df2zZ24bubCg7+BRdtqNTlS+WfsWkIPfIAbTPpGdLjTqWxM0nClU7yMOT8/H7o5JWC0IUOYxLQvL917/uaLQetqxFTVZQq3FgR3Po7aXfykw+SlBkCnVHRjCzi9ZtH5fJSpU1JV2mhyHYuvug3cddCITuhIEDHFXcqeribfEneAz0Pu7D95wW8R2Sq+t9PFh/64owa82mWAJ/IRpno3vzWNXXvvVkS1LDzv6F4cMvqS2XfHAetQQ/niXVGGW5SXoDYA1hIadFhvxRGJERGqz2CDzMz+0cCoSDGPXIHhaVuTzDxLhF/ALZGog== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3rJl4bvG5P28lwjcobHRthLqJO4TGcF+IiJpvc5pSCc=; b=pFsHmGgXz70xM0s3NjthVPY4iEMALG6drVaeHkyBCJxRn6ULtHl7DgSIy2tNP7/5/Jb2eMSCxTfL7WnWH4r/WlFTacSiw7ebJn6RkmV9jFzYeiasBCnXQUmJFquG8Kdtkxbi+IArLB8AIaqApNE5G5OInI02sUjfrd1JBxm7C5Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 64f1dc2d78702d66 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSb16J0qk+WGanEemGGPWMJwfm7bqVKfU2TWwMSGwQGeBgJr5Q9rrAtDJ/nGiJIPtWRoiWTWUBG4htrMlU6LXnhrGuq5V4jq/9NjBsWQDLZlnykYTFDgbfiOCgz1Dg2l4nCY8rO/tGl7T+XhwhKb9z2K8UGL9VEs8tPyY8uVckd7WOwpTYleWXUs2vI1wBOJUWYOXDCeEoUfsO/glaN93cRcT9EanLzQXf2MSvEgsknzQmMMUKWCZa2ZvmHNJFarewCNIrYZEisGGk3tcpdStTmEC+PnkRd2KsLG00F23H5gJLvApUUH0ixE3/i0Cb7u5vdBxu0djf0nfNUk0gZ4AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3rJl4bvG5P28lwjcobHRthLqJO4TGcF+IiJpvc5pSCc=; b=BErJhvOWOIxxJqIugDufA+2j01Opx7TVqeMRS+xrwVykWgHWRWW1Ht1Hwp9vUN9y50y12M/W6Oe04ffj7aeBdDE3wRfC2/sZZSlqiRCu5lB6h5wZoKJLw1dK/X6TBGMxohcqksn+QuooLbGtYtN0VFUtct4nDP9wfHC6WW3ulcPD21l9iA/L5AHlGajK28iW1qlcs8GEuvIZnXwUKbryhLYqJa2Odi4T3r+xWf1LMWMcRsQRxwxqO3fydPPyO/RdUs5+Tv2jXMn8+hfQG6qqcZ1xJHbKOZ5zNZHb45oYVWJxbmBXmr4Dvm55xMw0XCDLtPUu7m7nMoCmwIWKUxORSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3rJl4bvG5P28lwjcobHRthLqJO4TGcF+IiJpvc5pSCc=; b=pFsHmGgXz70xM0s3NjthVPY4iEMALG6drVaeHkyBCJxRn6ULtHl7DgSIy2tNP7/5/Jb2eMSCxTfL7WnWH4r/WlFTacSiw7ebJn6RkmV9jFzYeiasBCnXQUmJFquG8Kdtkxbi+IArLB8AIaqApNE5G5OInI02sUjfrd1JBxm7C5Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v4 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Date: Fri, 2 Sep 2022 11:31:19 +0800 Message-ID: <20220902033121.540328-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902033121.540328-1-wei.chen@arm.com> References: <20220902033121.540328-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 134fc4bf-528a-49ae-cf80-08da8c93b430 X-MS-TrafficTypeDiagnostic: AS8PR08MB6408:EE_|AM7EUR03FT042:EE_|GV2PR08MB8654:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dc2gxTi0hNBktT0/Xs1KZ1DqFMpyt5bEu2ey2GWmgx2bUlD5TUw50p1U5dSWXXIaxZVZoQ9hN2kwtqGqDmAaIXtSLthm/uNJA3YAFWBi4vHbePv0rZPfh4HFOsnwbgV/2h0DVbsUi730KousR/rJln2rvWaqSozRkp5XGdsq60Kyb/HdmLeu4Fqx4lpzmpafiT4vF/HEoGTCgggAH6p4eZT3PS7sEhpzJ1v5qgp8TCNPD6RWU3HJrlm8ftLs/YL2gUfqOvQuGvXIDAVJYa/gdqstveJnTLPIT54/f3d/Na5ghfaBCilbY94v9xBCdqi3ELyQ5u6gW0uhq2o1zwo9I58cg3+iMWtQpCIB/TC8LEeC6TLKTdLUGcNQJPGs9Atrc1+aAIjbsKY0gFh7RrEK7DkhPuUT3gu7a8eeAN9O6HBPo7wTxchzX9peeURa/MoU38fO0I0ZOH/2VYClF8RHrQt+Oez2eUEO5p5X5/YEQwf2C9Sk+NIwwFSe+6Rpnp2OJ0CyvlVmhf3EnCEdqCYB8O8Hjq2PKVk15i18rfkrFB5AG1W3k9gkM2TWeFU8EGshZ1CoHYrPERC9zleG9C1FW1Tfjzsa/tlTdG37gIU5iO1jM5aGoGT3LjrzKI1IBIsBX7sDa4TE1Ncp3FiL59pt4+M75HuNQDCt+gChN6nA8/PJ9jqb64yvaGFkh9PUETQOmLbcWvNBfrTPUMQLWA+1Q926KXvMgq3y09E92sQ7zTAwNvyyuZoXqV6zh7r57U6JBowZHFNvGOy79vWxqdHYEkiAADAQ2KwtaqiiIuY9zPzsDFDN9bYcpY6429opIkxE X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(40470700004)(46966006)(36840700001)(8936002)(81166007)(83380400001)(5660300002)(54906003)(86362001)(6916009)(36756003)(2616005)(316002)(186003)(1076003)(336012)(82310400005)(82740400003)(47076005)(36860700001)(70586007)(478600001)(40460700003)(26005)(426003)(41300700001)(8676002)(70206006)(40480700001)(7696005)(2906002)(44832011)(4326008)(356005)(6666004)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6408 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 98dfe6f1-1628-4130-e3b8-08da8c93aeee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1WxNT/DJCfJMK/orD/kszvu/Pkvd9JhI0xj0JLvHPW2Ahd52oRnSJNIANq+s0jeRYSTkYSPE/ackDbAn1PWzz3+3RJoRpbmHdzxZ81DVkWXAlWyn606q5smLc+Gw1cWvCUCK52eQ8ThXOf6AZTbw/8BjOiLZV4NxOFDuTcQKu5IO60YYYIevSD6PpegOwe0s0uJp2H2qqMVmFS6x/ermw4BRkI84McK7C9m65L74gnxljqrblyHvUAXZy0qYE0H/TdXkukOB8uFSdqOH9fdxtz5ZhNpF/NLLJEVx0X1zaOAadNydK9cv4WFM/GcTM4stRx39RT0ih1TepEj/uhGwIkPvAa1C+89xVTplXYDH0Lwmh5+kWz9iV19gDbpzUYEVvhH4rfzQ8tz89ZBgl1UNlyhM3dwuL1txcyVpimjiKGsXGInAhrCQYmnQ7cvRO/BMmwAhfiWzj93IXUa2yh6DSw1opeHK4gQgMQ+DP8VkpY/iHsrJiAaQ2DCmF+Z/BXvVAmEuspDm+/Eywz7w/jgkWPy01AF1R5x8dYnnRbPQggxDb9ua2oQ1ZQTcaWFDo4JkdXh4PTmgr00hmJqvHiNSo3xH9HNzzMFhG3rBe8WvcCRsOp2GQX4VIXl+7khQ4j60LxbdbLNK18z40kxUCIQfU3oxmKouP896xbQFPv8qb238PMe7v+GYRxXfGgeHOEjsbeSTq5ewE0IsGmzID5tvN8H/8+tAB30pDuJrnDe9cBKCvaJImLVDjOKJmT1dUdpoFdDxINCBINpjl/lTbu38Sg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(39860400002)(396003)(36840700001)(40470700004)(46966006)(186003)(2906002)(2616005)(36756003)(44832011)(83380400001)(82740400003)(336012)(47076005)(82310400005)(1076003)(5660300002)(426003)(8936002)(316002)(36860700001)(70206006)(70586007)(4326008)(8676002)(107886003)(7696005)(6666004)(6916009)(81166007)(41300700001)(86362001)(54906003)(40480700001)(26005)(40460700003)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:32:03.6900 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 134fc4bf-528a-49ae-cf80-08da8c93b430 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8654 The sanity check of nodes_cover_memory is also a requirement of other architectures that support NUMA. But now, the code of nodes_cover_memory is tied to the x86 E820. In this case, we introduce arch_get_ram_range to decouple architecture specific memory map from this function. This means, other architectures like Arm can also use it to check its node and memory coverage from bootmem info. Depends arch_get_ram_range, we make nodes_cover_memory become architecture independent. We also use neutral words to replace SRAT and E820 in the print message of this function. This will to make the massage seems more common. As arch_get_ram_range use unsigned int for index, we also adjust the index in nodes_cover_memory from int to unsigned int. Signed-off-by: Wei Chen --- v3 -> v4: 1. Move function comment to header file. 2. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 3. Use -ENODATA instead of -EINVAL for non-RAM type ranges. v2 -> v3: 1. Rename arch_get_memory_map to arch_get_ram_range. 2. Use -ENOENT instead of -ENODEV to indicate end of memory map. 3. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. v1 -> v2: 1. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 2. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. --- xen/arch/x86/numa.c | 15 +++++++++++++++ xen/arch/x86/srat.c | 30 ++++++++++++++++++------------ xen/include/xen/numa.h | 13 +++++++++++++ 3 files changed, 46 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 90b2a22591..fa8caaa084 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifndef Dprintk #define Dprintk(x...) @@ -93,3 +94,17 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } + +int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) +{ + if ( idx >= e820.nr_map ) + return -ENOENT; + + if ( e820.map[idx].type != E820_RAM ) + return -ENODATA; + + *start = e820.map[idx].addr; + *end = *start + e820.map[idx].size; + + return 0; +} diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 4c7f0c547e..bd9694db24 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -428,37 +428,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) Make sure the PXMs cover all memory. */ static int __init nodes_cover_memory(void) { - int i; + unsigned int i; - for (i = 0; i < e820.nr_map; i++) { - int j, found; + for (i = 0; ; i++) { + int err; + unsigned int j; + bool found; paddr_t start, end; - if (e820.map[i].type != E820_RAM) { - continue; - } + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); - start = e820.map[i].addr; - end = e820.map[i].addr + e820.map[i].size; + /* Reach the end of arch's memory map */ + if (err == -ENOENT) + break; + + /* Index relate entry is not RAM, skip it. */ + if (err) + continue; do { - found = 0; + found = false; for_each_node_mask(j, memory_nodes_parsed) if (start < nodes[j].end && end > nodes[j].start) { if (start >= nodes[j].start) { start = nodes[j].end; - found = 1; + found = true; } if (end <= nodes[j].end) { end = nodes[j].start; - found = 1; + found = true; } } } while (found && start < end); if (start < end) { - printk(KERN_ERR "SRAT: No PXM for e820 range: " + printk(KERN_ERR "NUMA: No NODE for RAM range: " "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); return 0; } diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index af0abfc8cf..38be7db960 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -81,6 +81,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +/* + * This function provides the ability for caller to get one RAM entry + * from architectural memory map by index. + * + * This function will return zero if it can return a proper RAM entry. + * otherwise it will return -ENOENT for out of scope index, or return + * -ENODATA for non-RAM type memory entry. + * + * Note: the range is exclusive at the end, e.g. [start, end). + */ +extern int arch_get_ram_range(unsigned int idx, + paddr_t *start, paddr_t *end); + #endif #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:32:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397249.637787 (Exim 4.92) (envelope-from ) id 1oTxPp-0006JP-Sf; Fri, 02 Sep 2022 03:32:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397249.637787; Fri, 02 Sep 2022 03:32:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPp-0006JB-OK; Fri, 02 Sep 2022 03:32:21 +0000 Received: by outflank-mailman (input) for mailman id 397249; Fri, 02 Sep 2022 03:32:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxPn-0004Wz-G3 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:32:19 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7ef4871-2a6f-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:32:17 +0200 (CEST) Received: from DB6PR07CA0172.eurprd07.prod.outlook.com (2603:10a6:6:43::26) by AS2PR08MB9500.eurprd08.prod.outlook.com (2603:10a6:20b:60c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 03:32:13 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::90) by DB6PR07CA0172.outlook.office365.com (2603:10a6:6:43::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Fri, 2 Sep 2022 03:32:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:32:13 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Fri, 02 Sep 2022 03:32:13 +0000 Received: from 84a4feb24c14.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F41608C2-F044-4E42-86CF-FFE7CC9B61D1.1; Fri, 02 Sep 2022 03:32:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 84a4feb24c14.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:32:07 +0000 Received: from DB8P191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::21) by AS8PR08MB9573.eurprd08.prod.outlook.com (2603:10a6:20b:61b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 03:32:02 +0000 Received: from DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::25) by DB8P191CA0011.outlook.office365.com (2603:10a6:10:130::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Fri, 2 Sep 2022 03:32:02 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT012.mail.protection.outlook.com (100.127.142.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:32:01 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:59 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:58 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7ef4871-2a6f-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SieV/NNbADK7PX3lbkaS5+U4k1E/eD8+Ikt23Qy9l+o5P8Rveh501H5QTJZ/NYkZ4igD2c+ddh/O96Z43SdzgEVZMQQW+EPIvGSDJSqTL2ox/CPaiwGiHzTs7LyOlrz0LymAkc8Q3mrf3ngD1rVKYztzDaDQet08aSkctVkiAytZKXAUw1sNZ3y7HahuPsDSqFFU4J/FP5MEAXkkLW/jQmQtLHygyl0V4p3gBwpcNv0EBIcIe+4dEJeY7CQZN//xrCI7Y3To3QXPHnMfEDsyTGRFBECRLCCoa8F/C18tFhL97vW3RYdev7JjLfNjWGB2x7SUHKRK5raO8KoUA+O2ig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lfSjviedwydQI2bCgX6A66sdP/EsoIsoIF3RlFpRa0g=; b=gsLV3743baK1rIkfAhW2LH0q8DTnNmwKA/CHYCg7VpyhZ2GO8d1VpAsRmabWTOqzeOOU53oezPNixme0XiKoKdSh1iT8bMvP6o+Gi0EmbCUeujIfrly9WZyFSLyaSeu4pWCjnkrhhE2Hzmlc8+OjQHjFgh8Tv6Sn2ectIwIVUCU5hnnO+YLJ02N7wznqKo8zFwgv+xO5T7u8WsIzIvnl3FHHP4Ss5l7eFMe4KjpK6HHEMBsZHVxPT0zHcRtOGi8UUDe6b6+8nOOmXYCxMnKJLlnOVwewT3C3tNACOdjK4RsxBkkJRSDDm1s3yasWx9XiSyVuDWM91pakxqNGrROlPg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lfSjviedwydQI2bCgX6A66sdP/EsoIsoIF3RlFpRa0g=; b=NinzuUHC9sxeXoGMociqzoWVX11fNnfxSxrIryTLrn4jbFyG35WdRuDuhiuVK01ZS9EIIsdn8V58NrbNhmdqnknQHLVl2NZ+JCLAJ0V6gTCKskz46fGd/cX/8DvMT+mvwu7BCwPMCwlQgiyvKi4GTRT8HgbWhd54t3StrB6RQiI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 53b8b6652d082267 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdGtVitsJpsZbgY8QkdW7GtaWh72m0aP1UhuphU9TF142OLcfH99sok5Mo1dFjRfiwXwCg6aek6ogULXChB/mPGrcICnFH3DVrkphOHCI8KKn3ZqpTvh5jiqwY29Wba+1Je0jj/qszUX+ISsAh7Y8Ip+qzblLm8rjwtrqm8SUSDFM/A8EShl6kadXhNvJCGI1T3dgN45Jg5Wos4T2Ddqmw/FNUy6F5xQisaOBRU7bAYlbZ4EirtdL1wkcmMTvJM1BiZo0xAK0Eq2XuUdrCWgdNzHaFjXOtofHp6UPcXLemn6CXpuNyBLv6ignpfuA1WMH/cPIbOGLiBWqhPQbmUSvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lfSjviedwydQI2bCgX6A66sdP/EsoIsoIF3RlFpRa0g=; b=V4I6STe/OFejiryIewBq9WmTg46+j7W2q81h895oGZ1x1vUs7NTVWsCDm6CjR8e/TIPVSiBNafsHb1JtjFbj/2HidhBaGXhft1tCaITC4y0WN0rsEXFv7NrX5/d9/wLd9q6V2clpGiaH1c86pMGNtzpP0ie19ifVA9m8QyLY4Qsemp9/PhoZldiMSDTkU7YoKeJ/Zyh/0XSKNgUG4VuUovpgoQs/ReBG4R65wJ959v15/xARzbhBb1kQMhz85mcOmRgFjAY/YTXt74UHU4ezhC/ZRz3msLb1wOPGGOsaGT96igIIB79XceTWYb6S/yHpmAB0i4cx6FF1wewW/OR0Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lfSjviedwydQI2bCgX6A66sdP/EsoIsoIF3RlFpRa0g=; b=NinzuUHC9sxeXoGMociqzoWVX11fNnfxSxrIryTLrn4jbFyG35WdRuDuhiuVK01ZS9EIIsdn8V58NrbNhmdqnknQHLVl2NZ+JCLAJ0V6gTCKskz46fGd/cX/8DvMT+mvwu7BCwPMCwlQgiyvKi4GTRT8HgbWhd54t3StrB6RQiI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Date: Fri, 2 Sep 2022 11:31:20 +0800 Message-ID: <20220902033121.540328-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902033121.540328-1-wei.chen@arm.com> References: <20220902033121.540328-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: b5e62c34-bdf8-4adb-f570-08da8c93ba20 X-MS-TrafficTypeDiagnostic: AS8PR08MB9573:EE_|DBAEUR03FT033:EE_|AS2PR08MB9500:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: p/tSO5tBxJdEeD6tsVuaTWavthIVwj2OC4InpAmhPcu+Az8qBgME+zt6hH0aO6JDNP0s7LfohUJynUry3ipBIW018/HSYO4g3iG0sb/Ja06QrQbJ0eSmvji424YNvyIKQDcYM+fzk8pWIS5C01Npkwubz7DIiBykyQcbVhxUnQmm6DWysb8/+b8zWZY1jyIaKfT+/9Vk+w/Lzy6WnI1Cs5Bf7hvPYer85vyOS2WZOWyk8j6an8SagbFOh5StfPZbF8Ejarq8j2SvsjHyunGQOfw+0ek58uJVVRoGIJdVAsuIPsYeTtyqTzhuMigeDneCq2cUHGArU7W344YaE/sDiX6wZ/Pzjs7CZNPK30glcA7cBkJ8eOlnaxxkKB+opXSeYbEX9Z4BlTRVQ4FiSfc7RjR8qXVAkINVoGPy5ObqAYaDmBYpAYzSiguLYPmLze67iYaU/yyaylztO6gxeNan6gUbE8gbXFk30p3vsxNpFSs2sDBYTmAbEgreUdjYHGP/0CORlnAizBpMt3xPnaHcEuzXfz42FOskxpoIqzQBB3NSGlGMeC43xLCp1LzFfXVN7TN1hQ4nbsU2LKY1cB9z7lUDRtwL+fo4VOBkl+gpCgjXhkO+zcW3CrYe495yahjQcJOqRTvpcDPwntc6qgP6671mwVXx1iS6FsA48+JBFzyQiQjGm0JCREHciJgLUdwZB0MR+vsm3rylrVtfjPpSkmA7GWQ296l3HSIvD6cLwjErq2hzu9Xu0WvIE/l8GIhqKB1Q4Xp01S5mKCjLa8K8DreSdZpkJ2RAxLlqTBi4BRJ8E7HmpW0G5k3Aa6+x99m+ X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(396003)(46966006)(40470700004)(36840700001)(356005)(86362001)(36756003)(36860700001)(83380400001)(47076005)(426003)(7696005)(2616005)(1076003)(186003)(26005)(6666004)(336012)(41300700001)(316002)(82310400005)(40480700001)(4326008)(70586007)(8676002)(478600001)(54906003)(2906002)(82740400003)(5660300002)(70206006)(6916009)(81166007)(44832011)(30864003)(40460700003)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9573 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8b80815d-6faa-4aef-e9ca-08da8c93b2f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xuNmryb7W3Pk04e3z49enxlOsftrDW+ppKPfIHiY2c/j9IlNK93XGxcG2TxDJOjbkEjlB0GYGZc1vVL2jNh4AwZj75mUjBCqs92Kam1+7l3tB2GhhThcJRekpynwsn/ndZYJn8Y694lMDvjyXgF0JIBQWyKqC37SmeYxLlxBunWdRC/T0s/hscasgmXIYErOaJq9851ytr81OFSkVOYgwuNZd74V2uDXYC6g+fVaYNJWfRKcaX0tz3ONLmxoU/Z8kmc84Mn/4j5xM6wSlC56xWDsOWG+T1e+rgJqimQCeuv+A53tB0AN5q+LHkab81Xavg1HV+9Vo8Yo4AEYAgRK8fB/wcy0XS0t5ibu/UMug8A8hOuvYUhX9zVKsKZCZo7mXoI8PMTccjLhHeqVVca89dKacvSvHO9ICsoEgG29AjTHnSBtP0pRmNQIDU9hfZs2pTQpsNaBiL2szMocA+5xLt5dJEefQ+BPBAo1E8SNdq9xitO/qGzMgk3qSZ3qekdkCwk/MSIWWg3BZK+ekbvHOIlWKF5MhiM48jnKEK+kvfHUrwTzG3GNdJcdjtrSLy3dope/jiYcGmCTD/ev+lhKZwVc24uerKqIEevotfxC+abR5EpNX32k+zsgVhSbMc9yniEL2DCX+o7v+/IhBrxxsI7DhmsONXeopIOy4qIYypcBVCAz0jg54DrLvIXTGlgSni1IPCGzY5qeYkQrHTGt6IulA+idk7IUn23oF5R3Aa9FudhoZE0gmDARm82EPLfxK28SGVYK9r4rQpMgo5bk4A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(39860400002)(376002)(36840700001)(40470700004)(46966006)(82740400003)(5660300002)(41300700001)(8936002)(40460700003)(26005)(2906002)(107886003)(7696005)(86362001)(6666004)(30864003)(36860700001)(44832011)(40480700001)(82310400005)(1076003)(336012)(47076005)(81166007)(83380400001)(70586007)(426003)(186003)(2616005)(54906003)(70206006)(6916009)(478600001)(4326008)(316002)(36756003)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:32:13.6993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5e62c34-bdf8-4adb-f570-08da8c93ba20 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9500 x86 has implemented a set of codes to scan NUMA nodes. These codes will parse NUMA memory and processor information from ACPI SRAT table. But except some ACPI specific codes, most of the scan codes like memory blocks validation, node memory range updates and some sanity check can be reused by other NUMA implementation. So in this patch, we move some variables and related functions for NUMA memory and processor to common as library. At the same time, numa_set_processor_nodes_parsed has been introduced for ACPI specific code to update processor parsing results. With this helper, we can reuse most of NUMA memory affinity init code from ACPI. As bad_srat and node_to_pxm functions have been used in common code to do architectural fallback and node to architectural node info translation. But it doesn't make sense to reuse the functions names in common code, we have rename them to neutral names as well. PXM is an ACPI specific item, we can't use it in common code directly. As an alternative, we extend the parameters of numa_update_node_memblks. The caller can pass the PXM as print messages' prefix or as architectural node id. And we introduced a CONFIG_HAS_NUMA_NODE_FWID to prevent print the mapping between node id and architectural node id for those architectures do not have architectural node id. In this case, we do not need to retain a lot of per-arch code but still can print architectural log messages for different NUMA implementations. mem_hotplug also has been accessing by common code, except x86, other architectures like Arm will also want to implement memory hotplug in future. We export mem_hotplug to common will not bring any harm for Arm and we also can reduce some per-arch helpers to access mem_hotplug. As asm/acpi.h has been removed from common/numa.c, we have to move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch as well. Signed-off-by: Wei Chen --- v3 -> v4: 1. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 2. Move mem_hotplug to a proper place in mm.h 3. Remove useless "size" in numa_scan_nodes. 4. Use unsigned int or const for proper variables. 5. Fix code-style. 6. Add init_as_disable as arch_numa_disabled parameter. 7. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Add __ro_after_init to proper variables. 2. Rename bad_srat to numa_fw_bad. 3. Rename node_to_pxm to numa_node_to_arch_nid. 4. Merge patch#7 and #8 into this patch. 5. Correct int to unsigned int in proper places. 6. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 7. Drop helpers to access mem_hotplug, we export mem_hotplug from x86/mm.c to common/page_alloc.c v1 -> v2: 1. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 2. Merge this single patch instead of serval patches to move x86 SRAT code to common. 3. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 4. Change the code style to target file's Xen code-style. 5. Adjust some __init and __initdata for some functions and variables. 6. Merge two patches into this patch: 1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA. 2. replace "SRAT" texts. 7. Turn numa_scan_nodes to static. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 3 +- xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 7 +- xen/arch/x86/srat.c | 311 +++---------------------------- xen/common/numa.c | 321 +++++++++++++++++++++++++++++++- xen/common/page_alloc.c | 2 + xen/drivers/acpi/Kconfig | 1 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 12 +- 11 files changed, 363 insertions(+), 301 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 5c2dd5da2d..c453450a74 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -#define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; #define acpi_video_flags bootsym(video_flags) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index 0fc826de46..95ff71a83a 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -474,8 +474,6 @@ static inline int get_page_and_type(struct page_info *page, ASSERT(((_p)->count_info & PGC_count_mask) != 0); \ ASSERT(page_get_owner(_p) == (_d)) -extern paddr_t mem_hotplug; - /****************************************************************************** * With shadow pagetables, the different kinds of address start * to get get confusing. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 6c87942d43..2ca3475271 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -10,6 +10,7 @@ typedef u8 nodeid_t; extern int srat_rev; extern nodeid_t pxm_to_node(unsigned int pxm); +extern unsigned int numa_node_to_arch_nid(nodeid_t n); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) @@ -22,8 +23,6 @@ extern void init_cpu_to_node(void); #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); - void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index db1817b691..68f9989e1f 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -157,8 +157,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap_x[L1_PAGETABLE_ENTRIES]; -paddr_t __read_mostly mem_hotplug; - /* Frame table size in pages. */ unsigned long max_page; unsigned long total_pages; diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index fa8caaa084..e565c3a34d 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -41,9 +41,12 @@ int __init arch_numa_setup(const char *opt) return -EINVAL; } -bool arch_numa_disabled(void) +bool arch_numa_disabled(bool init_as_disable) { - return acpi_numa < 0; + if ( !init_as_disable ) + return acpi_numa < 0; + + return acpi_numa <= 0; } /* diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index bd9694db24..7964e199c5 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -24,10 +24,6 @@ static struct acpi_table_slit *__read_mostly acpi_slit; -static nodemask_t memory_nodes_parsed __initdata; -static nodemask_t processor_nodes_parsed __initdata; -static struct node nodes[MAX_NUMNODES] __initdata; - struct pxm2node { unsigned pxm; nodeid_t node; @@ -35,19 +31,6 @@ struct pxm2node { static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] = { [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} }; -static unsigned node_to_pxm(nodeid_t n); - -static int num_node_memblks; -static struct node node_memblk_range[NR_NODE_MEMBLKS]; -static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; -static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); - -enum conflicts { - NO_CONFLICT, - OVERLAP, - INTERLEAVE, -}; - static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm) return node; } -int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) -{ - int i; - - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - if (nd->start <= start && nd->end >= end && - memblk_nodeid[i] == node) - return 1; - } - - return 0; -} - -static -enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, - paddr_t end, paddr_t nd_start, - paddr_t nd_end, unsigned int *mblkid) -{ - unsigned int i; - - /* - * Scan all recorded nodes' memory blocks to check conflicts: - * Overlap or interleave. - */ - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - *mblkid = i; - - /* Skip 0 bytes node memory block. */ - if (nd->start == nd->end) - continue; - /* - * Use memblk range to check memblk overlaps, include the - * self-overlap case. As nd's range is non-empty, the special - * case "nd->end == end && nd->start == start" also can be covered. - */ - if (nd->end > start && nd->start < end) - return OVERLAP; - - /* - * Use node memory range to check whether new range contains - * memory from other nodes - interleave check. We just need - * to check full contains situation. Because overlaps have - * been checked above. - */ - if (nid != memblk_nodeid[i] && - nd->start >= nd_start && nd->end <= nd_end) - return INTERLEAVE; - } - - return NO_CONFLICT; -} - -static __init void cutoff_node(int i, paddr_t start, paddr_t end) -{ - struct node *nd = &nodes[i]; - if (nd->start < start) { - nd->start = start; - if (nd->end < nd->start) - nd->start = nd->end; - } - if (nd->end > end) { - nd->end = end; - if (nd->start > nd->end) - nd->start = nd->end; - } -} - -static __init void bad_srat(void) +void __init numa_fw_bad(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); @@ -241,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -254,12 +166,12 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) pxm = pa->proximity_domain; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -277,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -290,11 +202,11 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) } node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -306,32 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - struct node *nd; - paddr_t nd_start, nd_end; - paddr_t start, end; unsigned pxm; nodeid_t node; - unsigned int i; if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) return; - start = ma->base_address; - end = start + ma->length; /* Supplement the heuristics in l1tf_calculations(). */ - l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE)); + l1tf_safe_maddr = max(l1tf_safe_maddr, + ROUNDUP(ma->base_address + ma->length, + PAGE_SIZE)); - if (num_node_memblks >= NR_NODE_MEMBLKS) - { + if (!numa_memblks_available()) { dprintk(XENLOG_WARNING, - "Too many numa entry, try bigger NR_NODE_MEMBLKS \n"); - bad_srat(); + "Too many numa entries, try bigger NR_NODE_MEMBLKS!\n"); + numa_fw_bad(); return; } @@ -340,136 +247,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) pxm &= 0xff; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } - /* - * For the node that already has some memory blocks, we will - * expand the node memory range temporarily to check memory - * interleaves with other nodes. We will not use this node - * temp memory range to check overlaps, because it will mask - * the overlaps in same node. - * - * Node with 0 bytes memory doesn't need this expandsion. - */ - nd_start = start; - nd_end = end; - nd = &nodes[node]; - if (nd->start != nd->end) { - if (nd_start > nd->start) - nd_start = nd->start; - - if (nd_end < nd->end) - nd_end = nd->end; - } - - /* It is fine to add this area to the nodes data it will be used later*/ - switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) { - case OVERLAP: - if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & - ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, - end - 1, node_memblk_range[i].start, - node_memblk_range[i].end - 1); - if (mismatch) { - bad_srat(); - return; - } - break; - } - - printk(KERN_ERR - "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, - node_memblk_range[i].end - 1); - bad_srat(); - return; - - case INTERLEAVE: - printk(KERN_ERR - "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, node_memblk_range[i].end - 1); - bad_srat(); - return; - - case NO_CONFLICT: - break; - } - - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - node_set(node, memory_nodes_parsed); - nd->start = nd_start; - nd->end = nd_end; - } - - printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", - node, pxm, start, end - 1, - ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); - - node_memblk_range[num_node_memblks].start = start; - node_memblk_range[num_node_memblks].end = end; - memblk_nodeid[num_node_memblks] = node; - if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { - __set_bit(num_node_memblks, memblk_hotplug); - if (end > mem_hotplug) - mem_hotplug = end; - } - num_node_memblks++; -} - -/* Sanity check to catch more bad SRATs (they are amazingly common). - Make sure the PXMs cover all memory. */ -static int __init nodes_cover_memory(void) -{ - unsigned int i; - - for (i = 0; ; i++) { - int err; - unsigned int j; - bool found; - paddr_t start, end; - - /* Try to loop memory map from index 0 to end to get RAM ranges. */ - err = arch_get_ram_range(i, &start, &end); - - /* Reach the end of arch's memory map */ - if (err == -ENOENT) - break; - - /* Index relate entry is not RAM, skip it. */ - if (err) - continue; - - do { - found = false; - for_each_node_mask(j, memory_nodes_parsed) - if (start < nodes[j].end - && end > nodes[j].start) { - if (start >= nodes[j].start) { - start = nodes[j].end; - found = true; - } - if (end <= nodes[j].end) { - end = nodes[j].start; - found = true; - } - } - } while (found && start < end); - - if (start < end) { - printk(KERN_ERR "NUMA: No NODE for RAM range: " - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); - return 0; - } - } - return 1; + if (!numa_update_node_memblks(node, pxm, ma->base_address, + ma->length, "PXM", + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) + numa_fw_bad(); } void __init acpi_numa_arch_fixup(void) {} @@ -525,59 +310,9 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use the information discovered above to actually set up the nodes. */ -int __init numa_scan_nodes(paddr_t start, paddr_t end) -{ - int i; - nodemask_t all_nodes_parsed; - - /* First clean up the node list */ - for (i = 0; i < MAX_NUMNODES; i++) - cutoff_node(i, start, end); - - if (acpi_numa <= 0) - return -1; - - if (!nodes_cover_memory()) { - bad_srat(); - return -1; - } - - memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, - memblk_nodeid); - - if (memnode_shift < 0) { - printk(KERN_ERR - "SRAT: No NUMA node hash function found. Contact maintainer\n"); - bad_srat(); - return -1; - } - - nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); - - /* Finally register nodes */ - for_each_node_mask(i, all_nodes_parsed) - { - uint64_t size = nodes[i].end - nodes[i].start; - - if ( size == 0 ) - printk(KERN_INFO "SRAT: node %u has no memory\n", i); - - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - } - for (i = 0; i < nr_cpu_ids; i++) { - if (cpu_to_node[i] == NUMA_NO_NODE) - continue; - if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed)) - numa_set_node(i, NUMA_NO_NODE); - } - numa_init_array(); - return 0; -} - -static unsigned node_to_pxm(nodeid_t n) +unsigned int numa_node_to_arch_nid(nodeid_t n) { - unsigned i; + unsigned int i; if ((n < ARRAY_SIZE(pxm2node)) && (pxm2node[n].node == n)) return pxm2node[n].pxm; @@ -594,8 +329,8 @@ u8 __node_distance(nodeid_t a, nodeid_t b) if (!acpi_slit) return a == b ? 10 : 20; - index = acpi_slit->locality_count * node_to_pxm(a); - slit_val = acpi_slit->entry[index + node_to_pxm(b)]; + index = acpi_slit->locality_count * numa_node_to_arch_nid(a); + slit_val = acpi_slit->entry[index + numa_node_to_arch_nid(b)]; /* ACPI defines 0xff as an unreachable node and 0-9 are undefined */ if ((slit_val == 0xff) || (slit_val <= 9)) diff --git a/xen/common/numa.c b/xen/common/numa.c index 03e7318d72..da0ff7ae34 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -13,6 +13,21 @@ #include #include +static nodemask_t __initdata processor_nodes_parsed; +static nodemask_t __initdata memory_nodes_parsed; +static struct node __initdata nodes[MAX_NUMNODES]; + +static unsigned int __ro_after_init num_node_memblks; +static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS]; +static nodeid_t __ro_after_init memblk_nodeid[NR_NODE_MEMBLKS]; +static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); + +enum conflicts { + NO_CONFLICT, + OVERLAP, + INTERLEAVE, +}; + struct node_data __ro_after_init node_data[MAX_NUMNODES]; /* Mapping from pdx to node id */ @@ -33,7 +48,309 @@ bool __read_mostly numa_off; bool numa_disabled(void) { - return numa_off || arch_numa_disabled(); + return numa_off || arch_numa_disabled(false); +} + +void __init numa_set_processor_nodes_parsed(nodeid_t node) +{ + node_set(node, processor_nodes_parsed); +} + +bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) +{ + unsigned int i; + + for ( i = 0; i < num_node_memblks; i++ ) + { + struct node *nd = &node_memblk_range[i]; + + if ( nd->start <= start && nd->end >= end && + memblk_nodeid[i] == node ) + return true; + } + + return false; +} + +static enum conflicts __init conflicting_memblks( + nodeid_t nid, paddr_t start, paddr_t end, paddr_t nd_start, + paddr_t nd_end, unsigned int *mblkid) +{ + unsigned int i; + + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + *mblkid = i; + + /* Skip 0 bytes node memory block. */ + if ( nd->start == nd->end ) + continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. As nd's range is non-empty, the special + * case "nd->end == end && nd->start == start" also can be covered. + */ + if ( nd->end > start && nd->start < end ) + return OVERLAP; + + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if ( nid != memblk_nodeid[i] && + nd->start >= nd_start && nd->end <= nd_end ) + return INTERLEAVE; + } + + return NO_CONFLICT; +} + +static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end) +{ + struct node *nd = &nodes[i]; + + if ( nd->start < start ) + { + nd->start = start; + if ( nd->end < nd->start ) + nd->start = nd->end; + } + + if ( nd->end > end ) + { + nd->end = end; + if ( nd->start > nd->end ) + nd->start = nd->end; + } +} + +bool __init numa_memblks_available(void) +{ + return num_node_memblks < NR_NODE_MEMBLKS; +} + +/* + * This function will be called by NUMA memory affinity initialization to + * update NUMA node's memory range. In this function, we assume all memory + * regions belonging to a single node are in one chunk. Holes (or MMIO + * ranges) between them will be included in the node. + * + * So in numa_update_node_memblks, if there are multiple banks for each + * node, start and end are stretched to cover the holes between them, and + * it works as long as memory banks of different NUMA nodes don't interleave. + */ +bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, + const char *prefix, + bool hotplug) +{ + unsigned int i; + paddr_t end = start + size; + paddr_t nd_start = start; + paddr_t nd_end = end; + struct node *nd = &nodes[node]; + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expandsion. + */ + if ( nd->start != nd->end ) + { + if ( nd_start > nd->start ) + nd_start = nd->start; + + if ( nd_end < nd->end ) + nd_end = nd->end; + } + + /* It is fine to add this area to the nodes data it will be used later */ + switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) ) + { + case OVERLAP: + if ( memblk_nodeid[i] == node ) + { + bool mismatch = !(hotplug) != !test_bit(i, memblk_hotplug); + + printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", + mismatch ? KERN_ERR : KERN_WARNING, prefix, + arch_nid, start, end - 1, + node_memblk_range[i].start, node_memblk_range[i].end - 1); + if ( mismatch ) + return false; + break; + } + + printk(KERN_ERR + "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n", + prefix, arch_nid, start, end - 1, prefix, + numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + + case INTERLEAVE: + printk(KERN_ERR + "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", + prefix, arch_nid, nd_start, nd_end - 1, + prefix, numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case NO_CONFLICT: + break; + } + + if ( !hotplug ) + { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; + } + + +#ifdef CONFIG_HAS_NUMA_NODE_FWID + printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, prefix, arch_nid, start, end - 1, + hotplug ? " (hotplug)" : ""); +#else + printk(KERN_INFO "NUMA: Node %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, start, end - 1, hotplug ? " (hotplug)" : ""); +#endif + + node_memblk_range[num_node_memblks].start = start; + node_memblk_range[num_node_memblks].end = end; + memblk_nodeid[num_node_memblks] = node; + if ( hotplug ) + { + __set_bit(num_node_memblks, memblk_hotplug); + if ( end > mem_hotplug ) + mem_hotplug = end; + } + num_node_memblks++; + + return true; +} + +/* + * Sanity check to catch more bad SRATs (they are amazingly common). + * Make sure the PXMs cover all memory. + */ +static int __init nodes_cover_memory(void) +{ + unsigned int i; + + for ( i = 0; ; i++ ) + { + int err; + bool found; + unsigned int j; + paddr_t start, end; + + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); + + /* Reach the end of arch's memory map */ + if ( err == -ENOENT ) + break; + + /* Index relate entry is not RAM, skip it. */ + if ( err ) + continue; + + do { + found = false; + for_each_node_mask( j, memory_nodes_parsed ) + if ( start < nodes[j].end + && end > nodes[j].start ) + { + if ( start >= nodes[j].start ) + { + start = nodes[j].end; + found = true; + } + + if ( end <= nodes[j].end ) + { + end = nodes[j].start; + found = true; + } + } + } while ( found && start < end ); + + if ( start < end ) + { + printk(KERN_ERR "NUMA: No node for RAM range: " + "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); + return 0; + } + } + return 1; +} + +/* Use the information discovered above to actually set up the nodes. */ +static bool __init numa_scan_nodes(paddr_t start, paddr_t end) +{ + unsigned int i; + nodemask_t all_nodes_parsed; + + /* First clean up the node list */ + for ( i = 0; i < MAX_NUMNODES; i++ ) + cutoff_node(i, start, end); + + /* When numa is on with good firmware, we can do numa scan nodes. */ + if ( arch_numa_disabled(true) ) + return false; + + if ( !nodes_cover_memory() ) + { + numa_fw_bad(); + return false; + } + + memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, + memblk_nodeid); + + if ( memnode_shift < 0 ) + { + printk(KERN_ERR + "NUMA: No NUMA node hash function found. Contact maintainer\n"); + numa_fw_bad(); + return false; + } + + nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); + + /* Finally register nodes */ + for_each_node_mask( i, all_nodes_parsed ) + { + if ( nodes[i].end - nodes[i].start == 0 ) + printk(KERN_INFO "NUMA: node %u has no memory\n", i); + + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + } + + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] == NUMA_NO_NODE ) + continue; + if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) ) + numa_set_node(i, NUMA_NO_NODE); + } + numa_init_array(); + return true; } /* @@ -242,7 +559,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) #endif #ifdef CONFIG_NUMA - if ( !numa_off && !numa_scan_nodes(start, end) ) + if ( !numa_off && numa_scan_nodes(start, end) ) return; #endif diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index bfd4150be7..39b9653286 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -159,6 +159,8 @@ #define PGT_TYPE_INFO_INITIALIZER 0 #endif +paddr_t __read_mostly mem_hotplug; + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig index e3f3d8f4b1..6f33d1ad57 100644 --- a/xen/drivers/acpi/Kconfig +++ b/xen/drivers/acpi/Kconfig @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP config ACPI_NUMA bool + select HAS_NUMA_NODE_FWID select NUMA diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 35b065146f..2bced13c0c 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -148,6 +148,8 @@ int assign_page( /* Dump info to serial console */ void arch_dump_shared_mem_info(void); +extern paddr_t mem_hotplug; + /* * Extra fault info types which are used to further describe * the source of an access violation. diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 38be7db960..e593115ba2 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -11,6 +11,7 @@ #define NUMA_NO_DISTANCE 0xFF #define MAX_NUMNODES (1 << NODES_SHIFT) +#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) @@ -42,10 +43,10 @@ extern void numa_add_cpu(unsigned int cpu); extern void numa_init_array(void); extern void numa_set_node(unsigned int cpu, nodeid_t node); extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); -extern int numa_scan_nodes(paddr_t start, paddr_t end); +extern void numa_fw_bad(void); extern int arch_numa_setup(const char *opt); -extern bool arch_numa_disabled(void); +extern bool arch_numa_disabled(bool init_as_disable); extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); static inline void clear_node_cpumask(unsigned int cpu) @@ -93,6 +94,13 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) */ extern int arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end); +extern bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); +extern bool numa_memblks_available(void); +extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, + const char *prefix, + bool hotplug); +extern void numa_set_processor_nodes_parsed(nodeid_t node); #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:33:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:33:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397274.637798 (Exim 4.92) (envelope-from ) id 1oTxRC-0007e2-Bd; Fri, 02 Sep 2022 03:33:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397274.637798; Fri, 02 Sep 2022 03:33:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxRC-0007dv-7V; Fri, 02 Sep 2022 03:33:46 +0000 Received: by outflank-mailman (input) for mailman id 397274; Fri, 02 Sep 2022 03:33:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxRA-0007di-PM for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:33:44 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2052.outbound.protection.outlook.com [40.107.105.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b0afe8b-2a70-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 05:33:43 +0200 (CEST) Received: from DB6PR1001CA0047.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::33) by PAVPR08MB9842.eurprd08.prod.outlook.com (2603:10a6:102:31e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 2 Sep 2022 03:33:33 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::f2) by DB6PR1001CA0047.outlook.office365.com (2603:10a6:4:55::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:33:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:33:32 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Fri, 02 Sep 2022 03:33:32 +0000 Received: from 0e3dc0218c6c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9538F91C-8A56-411F-9D50-1A773DCEACCE.1; Fri, 02 Sep 2022 03:31:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0e3dc0218c6c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:31:39 +0000 Received: from DU2PR04CA0152.eurprd04.prod.outlook.com (2603:10a6:10:2b0::7) by DU0PR08MB9485.eurprd08.prod.outlook.com (2603:10a6:10:42e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 03:31:37 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::f5) by DU2PR04CA0152.outlook.office365.com (2603:10a6:10:2b0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15 via Frontend Transport; Fri, 2 Sep 2022 03:31:37 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:31:37 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:31:36 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b0afe8b-2a70-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BHd3v98F/ipf2sT9NsZUumCVVyyXFr5C7EGbHuwqbHMz4kKWwd1Ifl72BKzUmGVV8KInScXqmR78Knha0caaXL+soHx0Je1SjX2Ob9HvcI+ys5TLeBqFk5YcM7+w+dY41SE7tYSPhFMKTOZI2v3CtwfydSKtKNLEKF44WeyKuVZjA7fPeUmmDj2dYfJcvqZBUn4lX7rR7jfQbshDcXglYBAnIepvJLmowT1wTaq66ut1Yn/Qjic+rDtGVxYU4jzJpCXMBSqz50EUccTTJYqBDLuhHBH6j+KTaaGCkiTRmFVYwGIGcKRPCcDas3x9vXhPVmQkjFZvIXYdgoLJqFOB3w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VAVx52p6Yh/LWjBjGGqSO3vbeOOd24PcskvC7LHRjs=; b=Q5aAhu0jbExBDIticqNp/Q4WB0jL2Z1hsoTUnSMDIIRBoOoyAc1bRyZncvE8l+12AMq7w8yqW9YWY2VYaQbsejObYImrmogP2rNNFtxFtkwmiwmNSbgC2Qcqd2NdUEpKM+K9Ep7n/MlQ1xKlreVgPkhi/RIrCPhmMM8s0Q3o417xnrHXQQZx6BudnXFJEdAMpipzrCnepfcflXHVKxBO276Rur9lqNc8hjur3EYrmi1jKzp/KnWSRgp84B2RwE0aQ94yDNZaaj79tH7sR7XreH1P9ynPXWPfvQEsDDcjKIoesER61ZaUluONnohInJNycwJSmEbMwNlJg7PFPBGkVQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VAVx52p6Yh/LWjBjGGqSO3vbeOOd24PcskvC7LHRjs=; b=b1V/Equoqm5DnJbJKTmmH9cbdtT5d+qupnpoyuTnYh//qAfWikZFeNZRA46BjZXxx0xMCPQxnFnysFHjTukGp+kbrONMNsKhoKaik5IN0saMg8R9ZepOTuBOVc6xxiBJ1ccqud0ATMkKqs0Pqu+JW/OOPs1+CsQePMWZPHrZUl4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a70ef03438a3fe76 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcx7COpjreTj92MH7V37Nk46FR040gFrHtjyg5gSGMh7ToB0uMUWqlsSfbGk2P8ovdsPypBcSQmeUnhHf1RIm41cvVOg/PLokpDkrczLkQHD0zgCLudLMkz8cJnM2US+LmwDxRxcGQAewmxuRd2DJyYjemvK1skbY7shX1z2lpYQtF+TqL2Cj9s9N9uulLivJgJyr6Ls5eFHDMz2UVKgE5j0nd737nNcRxlMVWpHVB4g+5wB/vL9WDwjIKUS02gtHqQGdrM8tk6arAGlfJuSGPBe86U3OlF2YCed9hv3HXT5bGcLSRKMSkFjBRCU0QlvZMtlu4H8d2cMvI1fJ+ViJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VAVx52p6Yh/LWjBjGGqSO3vbeOOd24PcskvC7LHRjs=; b=bzRNfXAlXndlY2BsGY5fu3/YtHa4TrLfvFSflpI77lRFUb2jh44BoenmQZW9DwEu14v8JLbUuxKelQxv65nShLz41F25r35GLGIibA1LzKU/X2+Y12oFbgWiqi3EXnfxi0bM2KSN03xT9Yv7H4FpzTpxXnhus/KB1VBftKo+gnZcHjrftkvNMEXYgw+HhPfBKqcKrokfwwMF3wv2Zs4poYeouiFmfwjRPahRw2udkiEXFsTWR/g5kq+M6awrjVIybPESob5ptTvbtjsnuyGnJGFdHZXuQVXY34ztE9LX3T0SQm2zNXJNa4H8HQ3IwVSxtxwzLD4TjH9Ug5McTjDacQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VAVx52p6Yh/LWjBjGGqSO3vbeOOd24PcskvC7LHRjs=; b=b1V/Equoqm5DnJbJKTmmH9cbdtT5d+qupnpoyuTnYh//qAfWikZFeNZRA46BjZXxx0xMCPQxnFnysFHjTukGp+kbrONMNsKhoKaik5IN0saMg8R9ZepOTuBOVc6xxiBJ1ccqud0ATMkKqs0Pqu+JW/OOPs1+CsQePMWZPHrZUl4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v4 0/6] Device tree based NUMA support for Arm - Part#2 Date: Fri, 2 Sep 2022 11:31:15 +0800 Message-ID: <20220902033121.540328-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 08a6fd14-1fe5-480c-8633-08da8c93e93d X-MS-TrafficTypeDiagnostic: DU0PR08MB9485:EE_|DBAEUR03FT013:EE_|PAVPR08MB9842:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kO7uM++LGD32DzGHPQTJ3umSHZem21fHIPBB+aL3nVbnNpo5Su6wcVC0FIy8j1E5gKi69psmIR+S3CdSpyx68R7tWy/ZqpngDcTqoWC8T/yqggGxv/pnDb9jmrbBF9Zk9OSjcV3ZVFNlun1zFFdXiEIxrwAoBzW765S97hbPqk8XsQTqQI8ygjeN44FJvfAGyJ31x4W7RBZmwvhhppecE7iZaqAlJoF6c/OyOwFCpektoAjvIExmEYF+OzcAX5I1X5bpKE0N+N8iTEomHAp9QjwNyLrTfcF+kCp6uJ2pJEhiq+cGxJiwZOHioi9pGGQHMlOdnn4mJQ9TItPtWEE6wqEuIeMtK3qG9m8q8CZcBg60hQKX0xWHEMoDStzl0O8R2Dy6M2GB46f6a3iumGlWHOgaFcDYEtNMPMA1kpcvVgFGE5Pecf3+9wbMVnAwZfDmglMHDOYtqjyrZWJp/0HNZs5JAlwR2/gExZKCT+JoYA0Z5rVai5sIO8KJb6FDj2sLzewCAmuQ6+bJCA3fAy1utYrCKHMYq2d8YQMADfqJTfVSG6SVnOnNGDWp3Vy7Ckj94AoTchPNA4DMRwYJfvyHaTYyPfj5hAlY40EKAhQ40fqkOWFIUtBipGygcL37aR+dM4O1ANU5+2W4HNjY39cnYYMke/5pOKplfzvafok7edSDYJSPADBNxV2Bf14MXXOo3A0LU9vpr9xZBIu0F+Vzk+Wr2/TlO9W1O7BeGrUxEMkUmo3SO0utUmYNnnnnS1ALJ5ur2/0O951fGZnMLdWxQCdnFsE4BG0a2YEOCtqbbHAzPDC7NU5H4nStlIhLEYYrWqJfFvSTT6XtQcdVkRCrGlDyd34rvJCN1mYYROq6zZvxQ4NsPzLWTG7Qe6lAgVz6 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(396003)(346002)(376002)(36840700001)(40470700004)(46966006)(82740400003)(478600001)(40460700003)(40480700001)(1076003)(36756003)(186003)(44832011)(36860700001)(966005)(2616005)(5660300002)(8936002)(2906002)(316002)(6916009)(54906003)(86362001)(70206006)(70586007)(81166007)(356005)(4326008)(8676002)(47076005)(6666004)(26005)(426003)(336012)(83380400001)(7696005)(82310400005)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9485 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f93732fb-5f5b-4407-ec6a-08da8c93a4be X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1g3JVWF5p27VWimiFUgqJI8Gzzp9CqZx7XLjNo7MjjTF5tEdTdhOedgraIK0AQpE02BNbHAOLkR94MUZRdtmLHT7Xa+uZ6lyvsHGhoHJgDfSq2VJxP1Ss7qsPIStVBOrFXgpruXB6Nv81zt0EDCMbOiOidG8Cmrpx6s61h3cnbfPenk/3bmycM15nag8eFp33hpzKJlgmNze7dTTBpcw5t9C2l+WTWS34JaityFcfWWQUCMP7A9ZWtOSKSTYb5womrkIbVmHd91695SUatOsHG3hYXBWAUghMxJPm0KTLNJdJh6YQkjgrsuKcuFNLnmlqgJPLXiSipQ6L6X3xp+J0f2dz3bDRNFw3MsuLNA7v6UJjswC2DJJmBNoxdYcozY+DAQ04jUzP0dYE0FecGeOLg/LTcL6/Y07fDzNLZRWYDYhvwOADZRHmhob06OrtnOxOUNQ9z+iHQb3aavFDtM/9vCVFGIxZhpLCCDcQGBEDRrug4tf1YAQ48S2H6epHxyaUfOZGVcjpivLRa/PCwmlKAqapYF61jGeQFeRQsra1Ru1uWC75CwiMmipdfS9NBVFBzlIFRI/wWrC/KV2Y4zUXMHUOZA8TToPa2rBurtZqWeY/MjBu+Y73vTQaowDQu3mHn067laU2U1EUyWW1TwhSMnOanBqI9/hMA7HV5Cc5ihgrOcDSv/dU21JP+XgQXIT+vpdbHJx740ZEtxUGUrxZ2678T0jFH5ffsamahzz16FOKPTV6HiUu3GwWXalfDJfy5SPHBcTrcToDPWfhJjpV7kaB9MS+b5zTrmse+DZhIGt3w336ZISBl+3u972kNkrqrbKyNXMjjggJm3Tn8WT8g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(8936002)(40480700001)(82310400005)(81166007)(54906003)(1076003)(26005)(316002)(36756003)(6916009)(82740400003)(41300700001)(2906002)(4326008)(7696005)(8676002)(70206006)(40460700003)(966005)(107886003)(426003)(478600001)(83380400001)(336012)(47076005)(86362001)(70586007)(6666004)(36860700001)(186003)(5660300002)(2616005)(44832011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:33:32.7394 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08a6fd14-1fe5-480c-8633-08da8c93e93d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9842 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - this series. 3. Add new code to support Arm. This series only contains the second part patches. As the whole NUMA series has been reviewed for 1 round in [2], so this series would be v3) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html --- v3 -> v4: 1. Add init_as_disable as arch_numa_disabled parameter in the patche where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. 3. Restore compute_hash_shift's return value to int. 4. Remove unnecessary parentheses for macros. 5. Use unsigned int for proper variables. 6. Fix some code-style. 7. Move arch_get_ram_range function comment to header file. 8. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges. 10. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 11. Move mem_hotplug to a proper place in mm.h 12. Remove useless "size" in numa_scan_nodes. 13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch. 5. Remove acpi.h from common/numa.c. 6. Rename acpi_scan_nodes to numa_scan_nodes. 7. Replace u8 by uint8_t for memnodemap. 8. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 9. Use nodeid_t for nodeid and node numbers. 10. Use __read_mostly and __ro_after_init for appropriate variables. 11. Adjust the __read_mostly and __initdata location for some variables. 12. Convert from plain int to unsigned for cpuid and other proper 13. Remove unnecessary change items in history. 14. Rename arch_get_memory_map to arch_get_ram_range. 15. Use -ENOENT instead of -ENODEV to indicate end of memory map. 16. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. 17. Rename bad_srat to numa_fw_bad. 18. Rename node_to_pxm to numa_node_to_arch_nid. 19. Merge patch#7 and #8 into patch#6. 20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 22. Use 2-64 for node range. v1 -> v2: 1. Refine the commit messages of several patches. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa. 5. Correct return value of srat_disabled. 6. Introduce numa_enabled_with_firmware. 7. Refine the justification of using !node_data[nid].node_spanned_pages. 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 9. Adjust the conditional express for ASSERT. 10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 11. Use conditional macro to gate MAX_NUMNODES for other architectures. 12. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 13. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. 14. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 15. Merge this single patch instead of serval patches to move x86 SRAT code to common. 16. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 17. Change the code style to target file's Xen code-style. 18. Adjust some __init and __initdata for some functions and variables. 19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts. 20. Turn numa_scan_nodes to static. 21. Change NR_NUMA_NODES upper bound from 4095 to 255. Wei Chen (6): xen/x86: Provide helpers for common code to access acpi_numa xen/x86: move generically usable NUMA code from x86 to common xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid xen/x86: use arch_get_ram_range to get information from E820 map xen/x86: move NUMA scan nodes codes from x86 to common xen: introduce a Kconfig option to configure NUMA nodes number xen/arch/Kconfig | 11 + xen/arch/x86/include/asm/acpi.h | 2 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 61 +-- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 438 +----------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 311 ++----------- xen/common/Makefile | 1 + xen/common/numa.c | 759 +++++++++++++++++++++++++++++++ xen/common/page_alloc.c | 2 + xen/drivers/acpi/Kconfig | 1 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 97 +++- 15 files changed, 917 insertions(+), 775 deletions(-) create mode 100644 xen/common/numa.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 03:39:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 03:39:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397285.637809 (Exim 4.92) (envelope-from ) id 1oTxWH-0008OX-Ux; Fri, 02 Sep 2022 03:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397285.637809; Fri, 02 Sep 2022 03:39:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxWH-0008OL-Q1; Fri, 02 Sep 2022 03:39:01 +0000 Received: by outflank-mailman (input) for mailman id 397285; Fri, 02 Sep 2022 03:39:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTxQ2-0004PQ-Ld for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 03:32:34 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60072.outbound.protection.outlook.com [40.107.6.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e19ca15d-2a6f-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 05:32:33 +0200 (CEST) Received: from DU2PR04CA0090.eurprd04.prod.outlook.com (2603:10a6:10:232::35) by VI1PR08MB5469.eurprd08.prod.outlook.com (2603:10a6:803:132::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 2 Sep 2022 03:32:18 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::56) by DU2PR04CA0090.outlook.office365.com (2603:10a6:10:232::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 2 Sep 2022 03:32:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:32:17 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 02 Sep 2022 03:32:17 +0000 Received: from f51a0cb4c96b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 89DAB0A1-28E9-41C0-813E-F00EDBFF854E.1; Fri, 02 Sep 2022 03:32:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f51a0cb4c96b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 03:32:12 +0000 Received: from FR0P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::11) by DB8PR08MB5387.eurprd08.prod.outlook.com (2603:10a6:10:115::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 03:32:07 +0000 Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a8:cafe::a1) by FR0P281CA0112.outlook.office365.com (2603:10a6:d10:a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Fri, 2 Sep 2022 03:32:07 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 03:32:07 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Fri, 2 Sep 2022 03:32:03 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Fri, 2 Sep 2022 03:32:02 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 2 Sep 2022 03:31:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e19ca15d-2a6f-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TH4O/OSl/GXDZtPZeNzan7mPCNxgqKtSG4HrD1ekN+qX4jDIiKsVrf/i12L3PmdwRx+ZRgWeI8lkICacIdktvxJcQxoU5c64aM6m5Uam5MxOEmGKx8bTIXDcVbxJ6nnGHD8pW6GbU271NnKzZuipaqBqcuoW+yI6RU/a0Sol/nTSbiGNh4qGjuPcpJ7eVJD3mMfyqaQspFZBjjILZM4tRjRYz2c/ibP4yV6AAIwoPj3GDqXY+HydkJpMFTe6Vd1smRmqSaC9No6lDPzBJ0cw+eA/7o0HdCkTJ7tZ4F8VAg9VH14ukE6KzxWSk3TmUd0IAvSfI1kW8+c+LEaidou/aA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c24JNM9CmKKyBmuocLYrIdMPXWfKN3aqMIKpf5afvV4=; b=gpPmPgdeccSTZIw3/DbbOgh6DxsDjxoViRjikyq1I3NqzPl7VuBCSRGKd0ld0+V0aOe+YsgWVbS+dDmUCUQpTD7FjYsaSUEm7/SlL4EgjAU4z4CxXeGs+1SDyLH+GpKiLJTclLEfItzcfiDdgqpvMAMOzYAnLa+/fikos0/ZR+JpgMq0c9rXOPS+Mm652VJD8IH2rt262BIsEYtUrKehtIvwGn1Mj3UdMrwO4S5IadaDcukLe10IJMgHfzCRQsxSY1SgB0bqRkUvDr+GUzTQVLYD6EkDrfYTHj7JAD13JT19xQ2LGOnwuVBi+pe3Z4RRmyD0GdzC6oWMeXG6WnK7+Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c24JNM9CmKKyBmuocLYrIdMPXWfKN3aqMIKpf5afvV4=; b=lbtlvdMlwCTPwrFVphMgQrn8X89rrEyvugz2kckcYvTISZMOZrw6BT38gAvCXJ4N9mux67BoGqi5QQAlDZLjVmiM25f9ny/RPJzx4v4R+TQP4Pb/WXicIysPoZCWGeUxSJ/HD/YXhZznFexmCGzyZb3Rrb4DZOPnz8gPRXjby9k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e9a734e8d165181b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LiToRe2dz/7nR9uUzYEoDSc1syPLMSUmWrQLbM7hkt6PBxfFaJTz0QbTY2gl2XWWZ3ey6yLyA/m5L5v7+jKecOdV4lZebvvXfL/PJt/G0XMNd5ORlWJzfnVlo5/+j24kD0Qb8nnjiGzatq/0Lss5JHIe0SqiTs6dxuXeXemDcN6GhSu0zZhnqwHdkSFcS2yl53cEKyPsHCt0S8rCO1RMm7JEmxt9gRzoEix1ilpuf5mf24sd21z22lg0Cj/BGvd/XKbsVrRPi94r2HbIILmYNGGODg6wQHiJ6+werwA6I0raKnbTvFYasQAG/KeiNyjnDmlOyw3UVwSe/Ud+YQHRiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c24JNM9CmKKyBmuocLYrIdMPXWfKN3aqMIKpf5afvV4=; b=O3Q8KxxGQ09UOX5wqaf9wU9ZDPSUPRU45xPadheJgEeLGt+L2CAj0Unn/Qno+GhwXjm5//8soPq55/cESQ3Cgkc3qP0zbu53P8/P3A96/kP92dic7dbtVM7l3Fqq8qMHImo5Ofj3Kudyr4jmMvtd8vw0sZokhN7LV46+f31fKdCv1DKJw48A3DTFuT3kQZjEtoF+/xpgTZ7uRnPEJ4PfJPBWcvMTCbeOjny8+WhID+KLxoWTH/92NUlq4QtkIo3QXWqVVfwznTxLO1Jr9UgJm7sVakBcx3Ff/t6G33wLkY2RpJTFh9B1jp/0hAQmTVw6Jq5+ivlNX+bUYeHECGjRoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c24JNM9CmKKyBmuocLYrIdMPXWfKN3aqMIKpf5afvV4=; b=lbtlvdMlwCTPwrFVphMgQrn8X89rrEyvugz2kckcYvTISZMOZrw6BT38gAvCXJ4N9mux67BoGqi5QQAlDZLjVmiM25f9ny/RPJzx4v4R+TQP4Pb/WXicIysPoZCWGeUxSJ/HD/YXhZznFexmCGzyZb3Rrb4DZOPnz8gPRXjby9k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 6/6] xen: introduce a Kconfig option to configure NUMA nodes number Date: Fri, 2 Sep 2022 11:31:21 +0800 Message-ID: <20220902033121.540328-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902033121.540328-1-wei.chen@arm.com> References: <20220902033121.540328-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: cf474a3e-91b0-4ad4-a9b1-08da8c93bc7c X-MS-TrafficTypeDiagnostic: DB8PR08MB5387:EE_|DBAEUR03FT057:EE_|VI1PR08MB5469:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JGRRDgUUgwq1I29DjGybxxrrOdX+/IkmLKt+W1B+NCp8RgzpPpmV7NVBnkU55qISCs1y9FegLsYHyhDsSF0VYGS8qZPPERgiw9bDpEoAAVrVkebS1UdBozzMaRcIgfyYkOHpKdM1Zs++mxVVFWxsjJVjJECtu1lauw0LVIdZMF9kj8LqFFFj0udJCRCEKE+hHgma7WmqMzm+dnJX0V6pweYYD4ce5YSrjzf5nFjFzAgkYMOGW4JTO52zi/fdMu6Tm0UtsqfCr8ZxP94wtvgm5Hin9kaMN2T+7TPRthzwQ3dcmm9ygojDhJAPp11jDjAoq++nUKd040qFI0HJ4GigWu0KaIu2oq52CrQTq3ZXsSY9KI6rrT0cipMDfUmojMxqo8Xxm+HJMR6tlJY3xyinEqda7eAJFerVJtMF6ZRtLsifHrDL7scTSwFaikwULuEpqididqoX3Z2CiWO157lkKUoY3P2VFda8/crBs58yw+QK4mP5zRP3HBvQrZlSnrscetf27lGxLu6CxAZ81BkdoFe5RVWbHOUzPFxMs0z6H77pxR3jy+Z24cv/ld3h6k4d36q0Sdpul2ME1hTnrQeF0xn4/ewraNP0Sm6CZaUM3SHtQ3uemhUesEhEXLs8Mas/0e3wFjUbFDMT3jVz8a3XRTcQMMTN37LOkKjG8awSGDn7Sl0BKZF31vPlrQQxOZRW4xzY49v0NdDSp/c+u+0xPrIK//kJwgs4PnUWB4JccTwcxBolJT46qSh1slCo8wBleXvhUjJl26bFdGRI3NrxxvIAIC8ugXkMJJBVAunCdE4= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(376002)(396003)(46966006)(40470700004)(36840700001)(426003)(47076005)(7696005)(26005)(336012)(2616005)(186003)(1076003)(40480700001)(44832011)(8936002)(5660300002)(36756003)(41300700001)(6666004)(86362001)(478600001)(36860700001)(83380400001)(356005)(81166007)(54906003)(6916009)(82310400005)(2906002)(316002)(40460700003)(82740400003)(4326008)(8676002)(70206006)(70586007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5387 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4e9e035f-a40d-49b6-b8c9-08da8c93b651 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fZtLOlQCO853KMU0YKSVrSaS5D94uJW/oE4rv8HJkbMRUMkQpJmNQebYwjUomlBgQM8aPepN2y2DeUQ1JvBLBhoiYl8G5MxphLyoT/KKbDESZDfZJqqeazRxR0FjmlfwMHgJ6Atyy8FYb7FGSM1i0WxbfycwJrvCBWNI4khrh4tplnNh0Ozs92XVB0FcfnySSdlTCI0JXB8iHzluDbsAPGt1fc2scH5qHTLYAwfZ056D+DSRWdTqkPLtrVv1AJJHDrDGYIl6y00pCliHzXLVDM1ScJ9ZgFE2uVhYFjYR8SeAH+nachM/j/aiV7ifwNS54vUjED22BFJmUzD2v/nYqWuMqOk8CEQD2E0nhzz+bxiWZVP+CxV9cYUfcnHR77YB4HfIfT7KvnwYRk7otvOFLi1xqEWa8kV0XiIn4J+/4TB8jS1rvKISWxzmnsTlT8iug9B/4fK5GOGkYDENktxqxdmxgEPl/+WQtFcXL4Ulm8KOOu8DFMhJwdvYjL+EoBEbx2HubPGESh66igjF9tjELi4smAhB9FPRvXLMGE9duQp8ZAzwVCGMlDYAlY++3tAcD0s/Y9KhxuQbLq9IeufTFLYR4I7i8vNyicH7fSOXDw9wD3uRXVyFE6+yrFhSq6xkSGImSpUiQqTbGGSGEMVbFeOdc4nNfXC2LHNkHJke9mlzSA4rbfWBT1pZGLZ71Yid7d4/UJq9gRbVAhOyp+F2BMf/l9y8RSBMd64nv2OTTrBGEA0APX5UB0a7QDloXTwkDl8MzgOTiNNk3cgMO+RHcA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966006)(36840700001)(40470700004)(82310400005)(40480700001)(36860700001)(86362001)(81166007)(70586007)(8676002)(4326008)(41300700001)(5660300002)(478600001)(54906003)(40460700003)(8936002)(70206006)(426003)(6916009)(1076003)(316002)(47076005)(186003)(82740400003)(2616005)(44832011)(336012)(26005)(36756003)(7696005)(6666004)(2906002)(83380400001)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:32:17.6714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf474a3e-91b0-4ad4-a9b1-08da8c93bc7c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5469 Currently the maximum number of NUMA nodes is a hardcoded value. This provides little flexibility unless changing the code. Introduce a new Kconfig option to change the maximum number of NUMA nodes conveniently. Also considering that not all architectures support NUMA, this Kconfig option is only visible on NUMA enabled architectures. Architectures not supporting NUMA still use 1 for MAX_NUMNODES. As NODES_SHIFT is currently unused, we're taking this opportunity to remove it. Signed-off-by: Wei Chen Acked-by: Jan Beulich --- v3 -> v4: 1. Update the commit log to follow Jan's suggestion. 2. Add Ack-by. v2 -> v3: 1. Fix indent. 2. Use 2-64 for node range. v1 -> v2: 1. Add NODES_SHIFT remove message in commit log 2. Change NR_NUMA_NODES upper bound from 4095 to 255. --- xen/arch/Kconfig | 11 +++++++++++ xen/arch/x86/include/asm/numa.h | 2 -- xen/include/xen/numa.h | 11 ++++++----- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..7028f7b74f 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,14 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_NUMA_NODES + int "Maximum number of NUMA nodes supported" + range 2 64 + default "64" + depends on NUMA + help + Controls the build-time size of various arrays and bitmaps + associated with multiple-nodes management. It is the upper bound of + the number of NUMA nodes that the scheduler, memory allocation and + other NUMA-aware components can handle. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 2ca3475271..7866afa408 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -3,8 +3,6 @@ #include -#define NODES_SHIFT 6 - typedef u8 nodeid_t; extern int srat_rev; diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index e593115ba2..e16a7c3764 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -3,14 +3,15 @@ #include -#ifndef NODES_SHIFT -#define NODES_SHIFT 0 -#endif - #define NUMA_NO_NODE 0xFF #define NUMA_NO_DISTANCE 0xFF -#define MAX_NUMNODES (1 << NODES_SHIFT) +#ifdef CONFIG_NR_NUMA_NODES +#define MAX_NUMNODES CONFIG_NR_NUMA_NODES +#else +#define MAX_NUMNODES 1 +#endif + #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 04:43:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 04:43:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397309.637823 (Exim 4.92) (envelope-from ) id 1oTyWR-00077D-Rv; Fri, 02 Sep 2022 04:43:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397309.637823; Fri, 02 Sep 2022 04:43:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTyWR-000776-Nt; Fri, 02 Sep 2022 04:43:15 +0000 Received: by outflank-mailman (input) for mailman id 397309; Fri, 02 Sep 2022 04:43:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTyWQ-00076w-Kg; Fri, 02 Sep 2022 04:43:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTyWQ-0005Xi-In; Fri, 02 Sep 2022 04:43:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTyWQ-00051o-5G; Fri, 02 Sep 2022 04:43:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTyWQ-0006uw-4Q; Fri, 02 Sep 2022 04:43:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vdCneTLCeFpbPrK56ik3R8qu3Am8zl2svSLsH6FaNxM=; b=KEfc8RYu/e1Z+cVAWx121yuqbz dYiH1PKoK3k1gQIe5mECfsV3Dlpj+q3ONPLjozcjz3zJuvoBmDauip1ZAarDu9n9gUhs663WTx4mf /APIbbHALgHZhgcQrQOyrmV027cf+FyCAyX6jFCH+zgwscgA65xMiqfuh7GiGfCzWlNk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172922: regressions - FAIL X-Osstest-Failures: linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=42e66b1cc3a070671001f8a1e933a80818a192bf X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Fri, 02 Sep 2022 04:43:14 +0000 flight 172922 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172922/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-pvops 6 kernel-build fail REGR. vs. 172133 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 172133 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 42e66b1cc3a070671001f8a1e933a80818a192bf baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 28 days Failing since 172152 2022-08-05 04:01:26 Z 28 days 64 attempts Testing same since 172922 2022-09-01 22:42:52 Z 0 days 1 attempts ------------------------------------------------------------ 1629 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 167086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397067.637861 (Exim 4.92) (envelope-from ) id 1oTzEE-0003aW-Kz; Fri, 02 Sep 2022 05:28:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397067.637861; Fri, 02 Sep 2022 05:28:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzEE-0003YQ-AI; Fri, 02 Sep 2022 05:28:30 +0000 Received: by outflank-mailman (input) for mailman id 397067; Thu, 01 Sep 2022 23:50:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtxG-0004sM-75 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 23:50:38 +0000 Received: from out0.migadu.com (out0.migadu.com [2001:41d0:2:267::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0393616-2a50-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 01:50:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0393616-2a50-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 16:50:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662076236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QeZ3ywOHO+ue61+bhlHhVrcPOQCnKvUeLhu9G4GOySc=; b=sadkhbMj3kQoxTU4Z0wL0RXHLY5y6xZiwOqubD8PoxvVg4LGYu+qUdek9jYhqs8dE5qisD cPrzl5F8o1AtoFcEb462CJ9ApSsv/yCMwGqAUCTFZ6Dxme6pBqRmTDZBKFxUtWhaf3KJSH DvKiilEWiSx7n4WVSBJXR8PEuxO/ReU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 16/30] mm: enable slab allocation tagging for kmalloc and friends Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-17-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830214919.53220-17-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Tue, Aug 30, 2022 at 02:49:05PM -0700, Suren Baghdasaryan wrote: > Redefine kmalloc, krealloc, kzalloc, kcalloc, etc. to record allocations > and deallocations done by these functions. One particular case when this functionality might be very useful: in the past we've seen examples (at Fb) where it was hard to understand the difference between slab memory sizes of two different kernel versions due to slab caches merging. Once a slab cache is merged with another large cache, this data is pretty much lost. So I definetely see value in stats which are independent from kmem caches. The performance overhead is a concern here, so more data would be useful. Thanks! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397065.637856 (Exim 4.92) (envelope-from ) id 1oTzEE-0003X2-A9; Fri, 02 Sep 2022 05:28:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397065.637856; Fri, 02 Sep 2022 05:28:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzEE-0003Uj-01; Fri, 02 Sep 2022 05:28:30 +0000 Received: by outflank-mailman (input) for mailman id 397065; Thu, 01 Sep 2022 23:41:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtnz-0003y2-6R for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 23:41:03 +0000 Received: from out2.migadu.com (out2.migadu.com [2001:41d0:2:aacc::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89926ecd-2a4f-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 01:41:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89926ecd-2a4f-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 16:40:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662075661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VCjuzNKAQwi4WscZTTheCwWMDo51dWnYKGYDxlIvOxM=; b=B9gaPrqoM9PK1lD+hEX/op7qHNl+aw6jdPSVrB1+SupdzgrKuElns2pV73ErXthR33K4/r Csn8Bq+pn89vebEyMD7KRNTie0fIVFpBfkYpm+nAJ89w7k+b02t9MZ2ViDAd0K6/czkU7+ 8O6NPwDmFvimrwGJf/eHTnN/ekV1fK4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 14/30] mm: prevent slabobj_ext allocations for slabobj_ext and kmem_cache objects Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-15-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830214919.53220-15-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Tue, Aug 30, 2022 at 02:49:03PM -0700, Suren Baghdasaryan wrote: > Use __GFP_NO_OBJ_EXT to prevent recursions when allocating slabobj_ext > objects. Also prevent slabobj_ext allocations for kmem_cache objects. > > Signed-off-by: Suren Baghdasaryan Patches 12-14 look good to me. It's probably to early to ack anything, but otherwise I'd ack them. Thanks! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397100.637867 (Exim 4.92) (envelope-from ) id 1oTzEE-0003jO-UA; Fri, 02 Sep 2022 05:28:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397100.637867; Fri, 02 Sep 2022 05:28:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzEE-0003gb-Iz; Fri, 02 Sep 2022 05:28:30 +0000 Received: by outflank-mailman (input) for mailman id 397100; Fri, 02 Sep 2022 01:05:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTv7E-0006MX-F5 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 01:05:01 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 439feea4-2a5b-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 03:04:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 439feea4-2a5b-11ed-934f-f50d60e1c1bd Date: Thu, 1 Sep 2022 18:04:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662080697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRI44dmgZNXvCbxbx0ytBb5MNkpf1qBSJsTY6pAYXVg=; b=tb82WN7ukOq58edHhF7JOoDon3b2L1v/3IY97PsYRx6OPp66Trpvsx1rbRyhlh12fOiUwG EZmYoO3fSDUB2lu8gxsuWxZiVkHfm4qLeJxKDdrjL94MRoA3GDg6F5I9+Uj2cx14iFfbdO He+0U/hKqYLU04r4PhzKId0lgLZpOKY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kent Overstreet Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: > > I'd suggest to run something like iperf on a fast hardware. And maybe some > > io_uring stuff too. These are two places which were historically most sensitive > > to the (kernel) memory accounting speed. > > I'm getting wildly inconsistent results with iperf. > > io_uring-echo-server and rust_echo_bench gets me: > Benchmarking: 127.0.0.1:12345 > 50 clients, running 512 bytes, 60 sec. > > Without alloc tagging: 120547 request/sec > With: 116748 request/sec > > https://github.com/frevib/io_uring-echo-server > https://github.com/haraldh/rust_echo_bench > > How's that look to you? Close enough? :) Yes, this looks good (a bit too good). I'm not that familiar with io_uring, Jens and Pavel should have a better idea what and how to run (I know they've workarounded the kernel memory accounting because of the performance in the past, this is why I suspect it might be an issue here as well). This is a recent optimization on the networking side: https://lore.kernel.org/linux-mm/20220825000506.239406-1-shakeelb@google.com/ Maybe you can try to repeat this experiment. Thanks! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.396972.637834 (Exim 4.92) (envelope-from ) id 1oTzED-0003Cz-6p; Fri, 02 Sep 2022 05:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 396972.637834; Fri, 02 Sep 2022 05:28:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzED-0003Cs-4K; Fri, 02 Sep 2022 05:28:29 +0000 Received: by outflank-mailman (input) for mailman id 396972; Thu, 01 Sep 2022 22:27:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTsfC-0007tv-Sa for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 22:27:55 +0000 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 518cf5af-2a45-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 00:27:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 518cf5af-2a45-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 15:27:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662071272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b1dqv/ByZCeKtjIN7qAh4WTPe6OgIYJaSbL14h63ejE=; b=bPfcK47fQmtHNFob8GO9qIi7EZXfoe+hOaMo2O4o8g+RsQj0PRQRLbLh445WIZSWHQmRJV LBroBJTCjF+9G5EQfhS7vnCo2+GliQ+zE+1OzI+y/mfqfGmc828gVfAcGLWPRyK/BsjEWu UCE5u2mL8EZXYlZBvRfTopuCwq247po= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Kent Overstreet , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > On Wed, Aug 31, 2022 at 12:02 PM Kent Overstreet > wrote: > > > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > > Whatever asking for an explanation as to why equivalent functionality > > > > cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. > > > > > > Fully agreed and this is especially true for a change this size > > > 77 files changed, 3406 insertions(+), 703 deletions(-) > > > > In the case of memory allocation accounting, you flat cannot do this with ftrace > > - you could maybe do a janky version that isn't fully accurate, much slower, > > more complicated for the developer to understand and debug and more complicated > > for the end user. > > > > But please, I invite anyone who's actually been doing this with ftrace to > > demonstrate otherwise. > > > > Ftrace just isn't the right tool for the job here - we're talking about adding > > per callsite accounting to some of the fastest fast paths in the kernel. > > > > And the size of the changes for memory allocation accounting are much more > > reasonable: > > 33 files changed, 623 insertions(+), 99 deletions(-) > > > > The code tagging library should exist anyways, it's been open coded half a dozen > > times in the kernel already. > > > > And once we've got that, the time stats code is _also_ far simpler than doing it > > with ftrace would be. If anyone here has successfully debugged latency issues > > with ftrace, I'd really like to hear it. Again, for debugging latency issues you > > want something that can always be on, and that's not cheap with ftrace - and > > never mind the hassle of correlating start and end wait trace events, builting > > up histograms, etc. - that's all handled here. > > > > Cheap, simple, easy to use. What more could you want? > > > > This is very interesting work! Do you have any data about the overhead > this introduces, especially in a production environment? I am > especially interested in memory allocations tracking and detecting > leaks. +1 I think the question whether it indeed can be always turned on in the production or not is the main one. If not, the advantage over ftrace/bpf/... is not that obvious. Otherwise it will be indeed a VERY useful thing. Also, there is a lot of interesting stuff within this patchset, which might be useful elsewhere. So thanks to Kent and Suren for this work! Thanks! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397000.637839 (Exim 4.92) (envelope-from ) id 1oTzED-0003Fk-Fo; Fri, 02 Sep 2022 05:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397000.637839; Fri, 02 Sep 2022 05:28:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzED-0003F9-Ap; Fri, 02 Sep 2022 05:28:29 +0000 Received: by outflank-mailman (input) for mailman id 397000; Thu, 01 Sep 2022 22:54:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTt4s-0003zw-D8 for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 22:54:26 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 059e4dde-2a49-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 00:54:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 059e4dde-2a49-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 15:53:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662072863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HsNTuFQ7XbCclBZlUbN3U5MkNcD4kydlxiKj9ag/mqM=; b=oPzrWlMu1zttBKXqMooMVKLQBDEeBWlyjX9vsDJkAXG+i91talZG3CnOLGZqJ/j7NVGRKB wZTWLVRasLoef5Won/PgGguSqmh0FC7JUNFBw6OgxkY16iM6YRuGaquB3T/TIBb4G8gtzw fhM8xA0vhhBp50IAflanG0eJ5LKzxK0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kent Overstreet Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901223720.e4gudprscjtwltif@moria.home.lan> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 01, 2022 at 06:37:20PM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 03:27:27PM -0700, Roman Gushchin wrote: > > On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > > > This is very interesting work! Do you have any data about the overhead > > > this introduces, especially in a production environment? I am > > > especially interested in memory allocations tracking and detecting > > > leaks. > > > > +1 > > > > I think the question whether it indeed can be always turned on in the production > > or not is the main one. If not, the advantage over ftrace/bpf/... is not that > > obvious. Otherwise it will be indeed a VERY useful thing. > > Low enough overhead to run in production was my primary design goal. > > Stats are kept in a struct that's defined at the callsite. So this adds _no_ > pointer chasing to the allocation path, unless we've switch to percpu counters > at that callsite (see the lazy percpu counters patch), where we need to deref > one percpu pointer to save an atomic. > > Then we need to stash a pointer to the alloc_tag, so that kfree() can find it. > For slab allocations this uses the same storage area as memcg, so for > allocations that are using that we won't be touching any additional cachelines. > (I wanted the pointer to the alloc_tag to be stored inline with the allocation, > but that would've caused alignment difficulties). > > Then there's a pointer deref introduced to the kfree() path, to get back to the > original alloc_tag and subtract the allocation from that callsite. That one > won't be free, and with percpu counters we've got another dependent load too - > hmm, it might be worth benchmarking with just atomics, skipping the percpu > counters. > > So the overhead won't be zero, I expect it'll show up in some synthetic > benchmarks, but yes I do definitely expect this to be worth enabling in > production in many scenarios. I'm somewhat sceptical, but I usually am. And in this case I'll be really happy to be wrong. On a bright side, maybe most of the overhead will come from few allocations, so an option to explicitly exclude them will do the trick. I'd suggest to run something like iperf on a fast hardware. And maybe some io_uring stuff too. These are two places which were historically most sensitive to the (kernel) memory accounting speed. Thanks! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397056.637845 (Exim 4.92) (envelope-from ) id 1oTzED-0003Lx-SR; Fri, 02 Sep 2022 05:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397056.637845; Fri, 02 Sep 2022 05:28:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzED-0003Kz-K9; Fri, 02 Sep 2022 05:28:29 +0000 Received: by outflank-mailman (input) for mailman id 397056; Thu, 01 Sep 2022 23:36:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTtjW-0002XC-Bd for xen-devel@lists.xenproject.org; Thu, 01 Sep 2022 23:36:26 +0000 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e40815e2-2a4e-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 01:36:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e40815e2-2a4e-11ed-82f2-63bd783d45fa Date: Thu, 1 Sep 2022 16:35:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662075383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=InNX4damzKIXIFkKIPo7hosE+32IjNQo/Q1jqKqY1l0=; b=TfzaA6eaHfVGKKMSS994EkCVPN+PoxcM39qKI9TyTQjexgAwYlNFw7qqlpGMruhf3xUG9j SmJFtNE9aVX2nlE9sSq2OBVJu46ZbVXvsOT32de+wdRTt5xKC0OXHu10Bh4rLZAWRSqEDY yg+k8hWS3aEnNns1Xuo4Jx7O/CPoymA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 11/30] mm: introduce slabobj_ext to support slab object extensions Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-12-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830214919.53220-12-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Tue, Aug 30, 2022 at 02:49:00PM -0700, Suren Baghdasaryan wrote: > Currently slab pages can store only vectors of obj_cgroup pointers in > page->memcg_data. Introduce slabobj_ext structure to allow more data > to be stored for each slab object. Wraps obj_cgroup into slabobj_ext > to support current functionality while allowing to extend slabobj_ext > in the future. > > Note: ideally the config dependency should be turned the other way around: > MEMCG should depend on SLAB_OBJ_EXT and {page|slab|folio}.memcg_data would > be renamed to something like {page|slab|folio}.objext_data. However doing > this in RFC would introduce considerable churn unrelated to the overall > idea, so avoiding this until v1. Hi Suren! I'd say CONFIG_MEMCG_KMEM and CONFIG_YOUR_NEW_STUFF should both depend on SLAB_OBJ_EXT. CONFIG_MEMCG_KMEM depend on CONFIG_MEMCG anyway. > > Signed-off-by: Suren Baghdasaryan > --- > include/linux/memcontrol.h | 18 ++++-- > init/Kconfig | 5 ++ > mm/kfence/core.c | 2 +- > mm/memcontrol.c | 60 ++++++++++--------- > mm/page_owner.c | 2 +- > mm/slab.h | 119 +++++++++++++++++++++++++------------ > 6 files changed, 131 insertions(+), 75 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 6257867fbf95..315399f77173 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -227,6 +227,14 @@ struct obj_cgroup { > }; > }; > > +/* > + * Extended information for slab objects stored as an array in page->memcg_data > + * if MEMCG_DATA_OBJEXTS is set. > + */ > +struct slabobj_ext { > + struct obj_cgroup *objcg; > +} __aligned(8); Why do we need this aligment requirement? > + > /* > * The memory controller data structure. The memory controller controls both > * page cache and RSS per cgroup. We would eventually like to provide > @@ -363,7 +371,7 @@ extern struct mem_cgroup *root_mem_cgroup; > > enum page_memcg_data_flags { > /* page->memcg_data is a pointer to an objcgs vector */ > - MEMCG_DATA_OBJCGS = (1UL << 0), > + MEMCG_DATA_OBJEXTS = (1UL << 0), > /* page has been accounted as a non-slab kernel page */ > MEMCG_DATA_KMEM = (1UL << 1), > /* the next bit after the last actual flag */ > @@ -401,7 +409,7 @@ static inline struct mem_cgroup *__folio_memcg(struct folio *folio) > unsigned long memcg_data = folio->memcg_data; > > VM_BUG_ON_FOLIO(folio_test_slab(folio), folio); > - VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJCGS, folio); > + VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJEXTS, folio); > VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_KMEM, folio); > > return (struct mem_cgroup *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > @@ -422,7 +430,7 @@ static inline struct obj_cgroup *__folio_objcg(struct folio *folio) > unsigned long memcg_data = folio->memcg_data; > > VM_BUG_ON_FOLIO(folio_test_slab(folio), folio); > - VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJCGS, folio); > + VM_BUG_ON_FOLIO(memcg_data & MEMCG_DATA_OBJEXTS, folio); > VM_BUG_ON_FOLIO(!(memcg_data & MEMCG_DATA_KMEM), folio); > > return (struct obj_cgroup *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > @@ -517,7 +525,7 @@ static inline struct mem_cgroup *page_memcg_check(struct page *page) > */ > unsigned long memcg_data = READ_ONCE(page->memcg_data); > > - if (memcg_data & MEMCG_DATA_OBJCGS) > + if (memcg_data & MEMCG_DATA_OBJEXTS) > return NULL; > > if (memcg_data & MEMCG_DATA_KMEM) { > @@ -556,7 +564,7 @@ static inline struct mem_cgroup *get_mem_cgroup_from_objcg(struct obj_cgroup *ob > static inline bool folio_memcg_kmem(struct folio *folio) > { > VM_BUG_ON_PGFLAGS(PageTail(&folio->page), &folio->page); > - VM_BUG_ON_FOLIO(folio->memcg_data & MEMCG_DATA_OBJCGS, folio); > + VM_BUG_ON_FOLIO(folio->memcg_data & MEMCG_DATA_OBJEXTS, folio); > return folio->memcg_data & MEMCG_DATA_KMEM; > } > > diff --git a/init/Kconfig b/init/Kconfig > index 532362fcfe31..82396d7a2717 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -958,6 +958,10 @@ config MEMCG > help > Provides control over the memory footprint of tasks in a cgroup. > > +config SLAB_OBJ_EXT > + bool > + depends on MEMCG > + > config MEMCG_SWAP > bool > depends on MEMCG && SWAP > @@ -966,6 +970,7 @@ config MEMCG_SWAP > config MEMCG_KMEM > bool > depends on MEMCG && !SLOB > + select SLAB_OBJ_EXT > default y > > config BLK_CGROUP > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index c252081b11df..c0958e4a32e2 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -569,7 +569,7 @@ static unsigned long kfence_init_pool(void) > __folio_set_slab(slab_folio(slab)); > #ifdef CONFIG_MEMCG > slab->memcg_data = (unsigned long)&kfence_metadata[i / 2 - 1].objcg | > - MEMCG_DATA_OBJCGS; > + MEMCG_DATA_OBJEXTS; > #endif > } > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b69979c9ced5..3f407ef2f3f1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2793,7 +2793,7 @@ static void commit_charge(struct folio *folio, struct mem_cgroup *memcg) > folio->memcg_data = (unsigned long)memcg; > } > > -#ifdef CONFIG_MEMCG_KMEM > +#ifdef CONFIG_SLAB_OBJ_EXT > /* > * The allocated objcg pointers array is not accounted directly. > * Moreover, it should not come from DMA buffer and is not readily > @@ -2801,38 +2801,20 @@ static void commit_charge(struct folio *folio, struct mem_cgroup *memcg) > */ > #define OBJCGS_CLEAR_MASK (__GFP_DMA | __GFP_RECLAIMABLE | __GFP_ACCOUNT) > > -/* > - * mod_objcg_mlstate() may be called with irq enabled, so > - * mod_memcg_lruvec_state() should be used. > - */ > -static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > - struct pglist_data *pgdat, > - enum node_stat_item idx, int nr) > -{ > - struct mem_cgroup *memcg; > - struct lruvec *lruvec; > - > - rcu_read_lock(); > - memcg = obj_cgroup_memcg(objcg); > - lruvec = mem_cgroup_lruvec(memcg, pgdat); > - mod_memcg_lruvec_state(lruvec, idx, nr); > - rcu_read_unlock(); > -} > - > -int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab) > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab) > { > unsigned int objects = objs_per_slab(s, slab); > unsigned long memcg_data; > void *vec; > > gfp &= ~OBJCGS_CLEAR_MASK; > - vec = kcalloc_node(objects, sizeof(struct obj_cgroup *), gfp, > + vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > slab_nid(slab)); > if (!vec) > return -ENOMEM; > > - memcg_data = (unsigned long) vec | MEMCG_DATA_OBJCGS; > + memcg_data = (unsigned long) vec | MEMCG_DATA_OBJEXTS; > if (new_slab) { > /* > * If the slab is brand new and nobody can yet access its > @@ -2843,7 +2825,7 @@ int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > } else if (cmpxchg(&slab->memcg_data, 0, memcg_data)) { > /* > * If the slab is already in use, somebody can allocate and > - * assign obj_cgroups in parallel. In this case the existing > + * assign slabobj_exts in parallel. In this case the existing > * objcg vector should be reused. > */ > kfree(vec); > @@ -2853,6 +2835,26 @@ int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > kmemleak_not_leak(vec); > return 0; > } > +#endif /* CONFIG_SLAB_OBJ_EXT */ > + > +#ifdef CONFIG_MEMCG_KMEM > +/* > + * mod_objcg_mlstate() may be called with irq enabled, so > + * mod_memcg_lruvec_state() should be used. > + */ > +static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > + struct pglist_data *pgdat, > + enum node_stat_item idx, int nr) > +{ > + struct mem_cgroup *memcg; > + struct lruvec *lruvec; > + > + rcu_read_lock(); > + memcg = obj_cgroup_memcg(objcg); > + lruvec = mem_cgroup_lruvec(memcg, pgdat); > + mod_memcg_lruvec_state(lruvec, idx, nr); > + rcu_read_unlock(); > +} > > static __always_inline > struct mem_cgroup *mem_cgroup_from_obj_folio(struct folio *folio, void *p) > @@ -2863,18 +2865,18 @@ struct mem_cgroup *mem_cgroup_from_obj_folio(struct folio *folio, void *p) > * slab->memcg_data. > */ > if (folio_test_slab(folio)) { > - struct obj_cgroup **objcgs; > + struct slabobj_ext *obj_exts; > struct slab *slab; > unsigned int off; > > slab = folio_slab(folio); > - objcgs = slab_objcgs(slab); > - if (!objcgs) > + obj_exts = slab_obj_exts(slab); > + if (!obj_exts) > return NULL; > > off = obj_to_index(slab->slab_cache, slab, p); > - if (objcgs[off]) > - return obj_cgroup_memcg(objcgs[off]); > + if (obj_exts[off].objcg) > + return obj_cgroup_memcg(obj_exts[off].objcg); > > return NULL; > } > diff --git a/mm/page_owner.c b/mm/page_owner.c > index e4c6f3f1695b..fd4af1ad34b8 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -353,7 +353,7 @@ static inline int print_page_owner_memcg(char *kbuf, size_t count, int ret, > if (!memcg_data) > goto out_unlock; > > - if (memcg_data & MEMCG_DATA_OBJCGS) > + if (memcg_data & MEMCG_DATA_OBJEXTS) > ret += scnprintf(kbuf + ret, count - ret, > "Slab cache page\n"); > > diff --git a/mm/slab.h b/mm/slab.h > index 4ec82bec15ec..c767ce3f0fe2 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -422,36 +422,94 @@ static inline bool kmem_cache_debug_flags(struct kmem_cache *s, slab_flags_t fla > return false; > } > > +#ifdef CONFIG_SLAB_OBJ_EXT > + > +static inline bool is_kmem_only_obj_ext(void) > +{ > #ifdef CONFIG_MEMCG_KMEM > + return sizeof(struct slabobj_ext) == sizeof(struct obj_cgroup *); > +#else > + return false; > +#endif > +} > + > /* > - * slab_objcgs - get the object cgroups vector associated with a slab > + * slab_obj_exts - get the pointer to the slab object extension vector > + * associated with a slab. > * @slab: a pointer to the slab struct > * > - * Returns a pointer to the object cgroups vector associated with the slab, > + * Returns a pointer to the object extension vector associated with the slab, > * or NULL if no such vector has been associated yet. > */ > -static inline struct obj_cgroup **slab_objcgs(struct slab *slab) > +static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) > { > unsigned long memcg_data = READ_ONCE(slab->memcg_data); > > - VM_BUG_ON_PAGE(memcg_data && !(memcg_data & MEMCG_DATA_OBJCGS), > + VM_BUG_ON_PAGE(memcg_data && !(memcg_data & MEMCG_DATA_OBJEXTS), > slab_page(slab)); > VM_BUG_ON_PAGE(memcg_data & MEMCG_DATA_KMEM, slab_page(slab)); > > - return (struct obj_cgroup **)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > + return (struct slabobj_ext *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK); > } > > -int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab); > -void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, > - enum node_stat_item idx, int nr); > +int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab); > > -static inline void memcg_free_slab_cgroups(struct slab *slab) > +static inline void free_slab_obj_exts(struct slab *slab) > { > - kfree(slab_objcgs(slab)); > + struct slabobj_ext *obj_exts; > + > + if (!memcg_kmem_enabled() && is_kmem_only_obj_ext()) > + return; Hm, not sure I understand this. I kmem is disabled and is_kmem_only_obj_ext() is true, shouldn't slab->memcg_data == NULL (always)? > + > + obj_exts = slab_obj_exts(slab); > + kfree(obj_exts); > slab->memcg_data = 0; > } > > +static inline void prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > +{ > + struct slab *slab; > + > + /* If kmem is the only extension then the vector will be created conditionally */ > + if (is_kmem_only_obj_ext()) > + return; > + > + slab = virt_to_slab(p); > + if (!slab_obj_exts(slab)) > + WARN(alloc_slab_obj_exts(slab, s, flags, false), > + "%s, %s: Failed to create slab extension vector!\n", > + __func__, s->name); > +} This looks a bit crypric: the action is wrapped into WARN() and the rest is a set of (semi-)static checks. Can we, please, invert it? E.g. something like: if (slab_alloc_tracking_enabled()) { slab = virt_to_slab(p); if (!slab_obj_exts(slab)) WARN(alloc_slab_obj_exts(slab, s, flags, false), "%s, %s: Failed to create slab extension vector!\n", __func__, s->name); } The rest looks good to me. Thank you! From xen-devel-bounces@lists.xenproject.org Fri Sep 02 05:52:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 05:52:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397356.637899 (Exim 4.92) (envelope-from ) id 1oTzb5-0000x3-1V; Fri, 02 Sep 2022 05:52:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397356.637899; Fri, 02 Sep 2022 05:52:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzb4-0000ww-V9; Fri, 02 Sep 2022 05:52:06 +0000 Received: by outflank-mailman (input) for mailman id 397356; Fri, 02 Sep 2022 05:52:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzb3-0000wm-EB; Fri, 02 Sep 2022 05:52:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzb3-00072t-BZ; Fri, 02 Sep 2022 05:52:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oTzb2-0001bs-Sk; Fri, 02 Sep 2022 05:52:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oTzb2-0002gQ-SD; Fri, 02 Sep 2022 05:52:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pyqo19tVUzkrz06yTlIP2Gk/obdvwhidmoM83oTdRNY=; b=W4MTOEoo1RbeqxuSSnS31wjRgi pzZL3NAyW1UOuQfzNWLK1qvl6KQN2PXziCexYSUOQuXrc0UfCMBrTt63R09lffCuFiF8OiiGpGovo zxx3neDfsMvO5gF0HxxN9vImsE3v+ZZUoQJ6b7D944xiC6JuI54TFbQsHbCnG0N/Inw0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172926: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 05:52:04 +0000 flight 172926 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172926/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 28 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 223 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 07:02:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 07:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397366.637913 (Exim 4.92) (envelope-from ) id 1oU0gb-0007zQ-4Z; Fri, 02 Sep 2022 07:01:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397366.637913; Fri, 02 Sep 2022 07:01:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0gb-0007zJ-24; Fri, 02 Sep 2022 07:01:53 +0000 Received: by outflank-mailman (input) for mailman id 397366; Fri, 02 Sep 2022 07:01:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0gZ-0007zD-DM for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 07:01:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1cf2257f-2a8d-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 09:01:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E1AF034017; Fri, 2 Sep 2022 07:01:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A646A13328; Fri, 2 Sep 2022 07:01:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Tq4fJ1uqEWMVUwAAMHmgww (envelope-from ); Fri, 02 Sep 2022 07:01:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cf2257f-2a8d-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662102107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sbV+FiqQ4NiOM+U9g9WVXNt3yfp7aQHt2tv8AaKog2o=; b=sXru7CJnp43OSHE+Q3gfs7Reml5Ral30qA5NcMVaeaDo9KZXV++Nmo0PZJlCThWGm5emu/ 985qf4Cg/8Mt/aNZhD8VxxD3yAYuUs59iovYZZ8XAEpFjUzJtWL65nnFHJQrCUXFKRBL03 PP1tYD9pDp/Mr+hBu9UpqHefhePfCTA= Message-ID: <5b0a0f39-7016-c447-fc45-9f66146f1cd2@suse.com> Date: Fri, 2 Sep 2022 09:01:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] xen/grants: prevent integer overflow in gnttab_dma_alloc_pages() Content-Language: en-US To: Dan Carpenter Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------cRQo4LafssU0J0xeIuAJyvJO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------cRQo4LafssU0J0xeIuAJyvJO Content-Type: multipart/mixed; boundary="------------fkTq3z0VP8wTMXnXLZNXAXX2"; protected-headers="v1" From: Juergen Gross To: Dan Carpenter Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Message-ID: <5b0a0f39-7016-c447-fc45-9f66146f1cd2@suse.com> Subject: Re: [PATCH] xen/grants: prevent integer overflow in gnttab_dma_alloc_pages() References: In-Reply-To: --------------fkTq3z0VP8wTMXnXLZNXAXX2 Content-Type: multipart/mixed; boundary="------------AajvFlGqY4hdbrcAuSypkoVX" --------------AajvFlGqY4hdbrcAuSypkoVX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDkuMjIgMTc6MzUsIERhbiBDYXJwZW50ZXIgd3JvdGU6DQo+IFRoZSBjaGFuZ2Ug ZnJvbSBrY2FsbG9jKCkgdG8ga3ZtYWxsb2MoKSBtZWFucyB0aGF0IGFyZy0+bnJfcGFnZXMN Cj4gbWlnaHQgbm93IGJlIGxhcmdlIGVub3VnaCB0aGF0IHRoZSAiYXJncy0+bnJfcGFnZXMg PDwgUEFHRV9TSElGVCIgY2FuDQo+IHJlc3VsdCBpbiBhbiBpbnRlZ2VyIG92ZXJmbG93Lg0K PiANCj4gRml4ZXM6IGIzZjc5MzFmNWM2MSAoInhlbi9nbnRkZXY6IHN3aXRjaCBmcm9tIGtj YWxsb2MoKSB0byBrdmNhbGxvYygpIikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRl ciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBH cm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg== --------------AajvFlGqY4hdbrcAuSypkoVX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AajvFlGqY4hdbrcAuSypkoVX-- --------------fkTq3z0VP8wTMXnXLZNXAXX2-- --------------cRQo4LafssU0J0xeIuAJyvJO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMRqlsFAwAAAAAACgkQsN6d1ii/Ey/Y LAf/WuPTgtFX7MUPzC8lcBQxS2xaDfDr2daJDF5ms0Ls/odgnyktNNsgplfNsK4x2ob598B7gvYO WFvC7BVywEDmQD2vM6SDcgF0igg2aNxUenSGht+RrJhZuMDa8dT4/noOX+n5WED4cXFQ9IXFeGss MsRRkAp2hgU7RZbp5qWpNOxLK7SUlvP4IcQ2F9CFdB12gnbjVr3OtNmdv43Dww38eYr70CIUNgC3 xOxUiYqe8BwBYd+eDHXiX4vBkygD7AM5BiyBev3+BJ3vXrHRXVLf45j2n8fY1X6E6o9nIbR6J7jJ PcmPu9D8m+lSgFlXIXUanZ0O5ZCcAzSjqzKKJxsICg== =7Ns1 -----END PGP SIGNATURE----- --------------cRQo4LafssU0J0xeIuAJyvJO-- From xen-devel-bounces@lists.xenproject.org Fri Sep 02 07:09:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 07:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397373.637925 (Exim 4.92) (envelope-from ) id 1oU0nw-0000F7-Uc; Fri, 02 Sep 2022 07:09:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397373.637925; Fri, 02 Sep 2022 07:09:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0nw-0000Ev-Qf; Fri, 02 Sep 2022 07:09:28 +0000 Received: by outflank-mailman (input) for mailman id 397373; Fri, 02 Sep 2022 07:09:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0nv-0000Eo-9e for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 07:09:27 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cb586e7-2a8e-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 09:09:25 +0200 (CEST) Received: from BN9PR03CA0501.namprd03.prod.outlook.com (2603:10b6:408:130::26) by SJ0PR12MB5406.namprd12.prod.outlook.com (2603:10b6:a03:3ae::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 07:09:21 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:130:cafe::2c) by BN9PR03CA0501.outlook.office365.com (2603:10b6:408:130::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:09:21 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:09:21 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep 2022 02:09:20 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 2 Sep 2022 02:09:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cb586e7-2a8e-11ed-82f2-63bd783d45fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G8Mqk9Cw70LhzI4O9hPQ5FD+jnmcsk2QqVOPv/A/b7Nqnrk9Yi33BZeKLZ3qGcaRsTL7FZDdJph5fQY2BXB5IjzfrAZyPgnhOTv1dwv3FREhuZNY/GiTU1AU86wuP97gyhIloqQMq5yqnnjB2HxYqvWQS+nQapeye/az02yLbpyLgfp8FxyOnye5arh34sbR5GloFBNzjEW7zP/SpgJLzVbrvYnN0zsyb3Y7deM5ft4X1mHHxztrc8NjKSL4IkM63A4c76lCu9KUoC/VSOglk68tOPG1KNg41xk4ctxCrkXuLykKkeR/Ooa/t4EUQDyHXKavuRAnqAHGFDrwe/NiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4zRZxMNvqrK8pNAflLJKCEsa1l9+8J4LDGYuY4EXPXI=; b=SXxKOdjBEsiLvqlfR+X7Z8F7UUdx6UR80pInifvKrXWMyWPu2yHSYPmr9RH7Dkcs5kftm19It+wr5iU1tKqqm4SEPCmwe4N1ELmYVkl5bp3CqE1zYczzI/v877PW/lZVa7EbVd+FyoeXcdlX1dZeqsKqSn11Ye8kcIaBjSVSLza2Ki8A187Tq9rJV1/ilET7J3ZT1tz5Q5kfxvoKl9+1b8FidVvlRpNgfnAyXI8/Lvsrx6nULfr3AUMPdDxbW1QmQFuVxLzWXafRuc9xquJAyUxsFx+p7xxwqjjfG7wgFhuXFzFkm6pEbbSAQZnGAZdJcdDVD6EALQJF7Tl8FdTLLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4zRZxMNvqrK8pNAflLJKCEsa1l9+8J4LDGYuY4EXPXI=; b=bERAnf871mD/sQaWH2uFkKkbfMRjI2TxaBO2Jj2xLq6UpGmdGmN7/IdAeOGdJau4Hi0GCBjyiXgrGvg3477CtvTmylmInKkcYvQPRhJA9JqqpmeVNSqsyVjc7D179hdfOpQt+1jPxfESzY5lHLlonavQH+e63+SSD9jT2q2yN+s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [for-4.17 0/3] GitLab CI cleanup and boot time cpupools test Date: Fri, 2 Sep 2022 09:09:02 +0200 Message-ID: <20220902070905.1262-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5647ed1e-b148-4ddf-7534-08da8cb20f3c X-MS-TrafficTypeDiagnostic: SJ0PR12MB5406:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rZK17z+F2C/dbh+O0laK3D9m9x+2IxInpuxKqX2hayMBM3tm1jF7g20f8Mxjj9gRHoSf23zD4LTMDcXgmMHBzpC+o+QHA+cQcZAVZI5NsTBN3eKnXcvz77q9MPleOwGF2Ajy7KgGDwi93n7r5B88fLX99ja+AracCTWWQee0zhIGdIvPl1VMFp00o+Ky4w5L1pYwdUbPzEZ9kQZz4cJxjN22Qqfo1BVwkL6hrgM+/KrFH0D07imRaXLyucFldtF2oPaX6JUX2FOptuE7zWCD+5ZZEJd8caAPrYWNsV2ctrCxJZJaWEva/HY+wqLwlyyfKl/m4FZLbeT0VpwOl9NitDThvJE2Y+enj0h37FrCW5W29gF99CLH/iFZZfPvjcRlVUmiMGQ/4xf+elHVrNFhbay1PZftMSTEe5MCKXHOaQGiEupB/ttozobjPO4MtVdQVVrN50e4pjnwPKO9KsZEJO2C4giuPA//CwzerU/dVtwF7Ecm/NKdPCeNWQTK3lIwmTVqIno3Y5wflsbRiKCMmGCh160xsRqdfFsieJOydnX7O7b9pxL00USrJE+cdY4cHOucP7lxyYJUJZ3YbPlb5gbuYeoXhlogKqJFl3zMxayVQmJitapDkDPkKDwtgun2nJHEmGNDpuOJ4q/pKWE5m3V3gmMCuhYMW/llTrEPF+znE8dKzWz8ZjOUzj7Xv+NCqf0Pyp2vGunlKvnVSFBZ0Xgi0U0NKIeu0Z5WeU1wRVUhOLafZhAQfVTyfyNP8zgvxEVi9IptVm8k1HcxUBDJbyyS8sTkPJ5xcZkPB9GTLngZt/1g5hrvzj8eRX8TXZBm X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(39860400002)(136003)(36840700001)(46966006)(40470700004)(54906003)(6916009)(41300700001)(336012)(36860700001)(6666004)(82740400003)(8676002)(4326008)(4744005)(5660300002)(44832011)(36756003)(8936002)(70586007)(70206006)(47076005)(356005)(1076003)(2616005)(86362001)(40460700003)(478600001)(2906002)(316002)(26005)(82310400005)(83380400001)(426003)(186003)(40480700001)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 07:09:21.3409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5647ed1e-b148-4ddf-7534-08da8cb20f3c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5406 This patch series performs a small cleanup before the release and adds a test for validating boot time cpupools feature introduced in 4.17. Notes for the release manager: Benefits: - improved dom0less test coverage - tested feature that is introduced in 4.17 Risks: - CI pipeline failure Michal Orzel (3): automation: qemu-alpine-arm64-gcc: Use kernel 5.19 automation: qemu-smoke-arm64: Silence ifconfig error messages automation: Add a new job for testing boot time cpupools on arm64 automation/gitlab-ci/build.yaml | 11 ------ automation/gitlab-ci/test.yaml | 21 ++++++++++- automation/scripts/build | 3 +- automation/scripts/qemu-smoke-arm64.sh | 35 +++++++++++++------ .../kernel/5.9.9-arm64v8.dockerfile | 34 ------------------ 5 files changed, 47 insertions(+), 57 deletions(-) delete mode 100644 automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 07:09:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 07:09:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397374.637936 (Exim 4.92) (envelope-from ) id 1oU0o1-0000Wv-9x; Fri, 02 Sep 2022 07:09:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397374.637936; Fri, 02 Sep 2022 07:09:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0o1-0000Wo-5b; Fri, 02 Sep 2022 07:09:33 +0000 Received: by outflank-mailman (input) for mailman id 397374; Fri, 02 Sep 2022 07:09:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0nz-0000VG-Ns for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 07:09:31 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2081.outbound.protection.outlook.com [40.107.212.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f1b57d4-2a8e-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 09:09:29 +0200 (CEST) Received: from BN9PR03CA0506.namprd03.prod.outlook.com (2603:10b6:408:130::31) by LV2PR12MB5895.namprd12.prod.outlook.com (2603:10b6:408:173::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 07:09:26 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:130:cafe::24) by BN9PR03CA0506.outlook.office365.com (2603:10b6:408:130::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Fri, 2 Sep 2022 07:09:26 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:09:26 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep 2022 02:09:26 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep 2022 02:09:25 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 2 Sep 2022 02:09:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f1b57d4-2a8e-11ed-934f-f50d60e1c1bd ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4NoOaLZdOzsjNzoOqWcANPuqoo9zoXqv0ElXRgZR2dnvLMTdJk5nzJT25ETpkPPyC3v8LDrF+AlM4iPPKuutSZdmTYCbuqQ64a4Jsg+QKwopDv3D47cVl2b66MLX2mMiIKlDCAA+bvx4V5mQzDyzW8rIfJg/2DkcLXeofxJvqSodU2lZsl9crpMiSouo/WcPxczi/A7BJzS/q3ZNcn2FBjrIIyxRtJc1gWEXOzfgS05OucvwgRF6WLkeMaEdvUTw61mOZ1c/B+mx1NPkFNCErF9qr4GyfL7fDWhYP7KDdYdfRianiSTc48epSJMQRC9UO0XSynmXd7gZQVMB8ayDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fxl2Y+brzqdoCYlG8sYLKyyIqMeJuYiU3UbH1MYdaBk=; b=a8yCLZR3W0ETY20cIh20NeFxzBW12WfHiVIuz670FpWptgCu5RnZoBGKcPspZ3iovMChDKZ1C85j1fLXh7FD+C5IqMWd84v7MkizYsypKKMKravzAz86Gpk2zhrjn0amO2jketjz/XjJ2JFQI0UMXlEtYeEURG2SOoQuXD/qB7m9c6SGcEBh6rNCTwdzTaOKVGZwg7aVHF/Jx3tMYmmwCe6y5hAAeItBNPMPn1qLyNC5/aWl7rP2/3P4y3bQm2qLR+0NfGYkMmJEcOiQ2R+tHhLXLvYx2Cr1RXIn+b159cgLNKcrbcJhyihKxOZXc2n8VMQfXG+DAn4YtenDJsYl/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fxl2Y+brzqdoCYlG8sYLKyyIqMeJuYiU3UbH1MYdaBk=; b=2/5pESK2VED6EXuMEUwK52Iz+b5APlbzcJfSnHFB/u041vuGv1lMHzXTmPbqxtNjhsoccRMo0eubQRvp2G4ZJGpY9/Fas8fqqHR3sAvqMzaSeH/dmUVzdCexOds3zRFs2M5wUtSXYfi59D5+Kxw/i9SRo5sbyZtshgq+V8vvRv0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [for-4.17 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages Date: Fri, 2 Sep 2022 09:09:04 +0200 Message-ID: <20220902070905.1262-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902070905.1262-1-michal.orzel@amd.com> References: <20220902070905.1262-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bf2b262-63b8-4f49-b6b5-08da8cb21258 X-MS-TrafficTypeDiagnostic: LV2PR12MB5895:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 12dTPMtE5a7+vzqnd5fPR/zsHHakEAZRG9+Wk/kPgnKU556XFSvY7m+6P27dE1AnyAwZNYNYaAAB8KwReP6cTrOeiwEFO9+ne/cPyoP06ppCsX7Jy2THPVQvHEdCOfuKztUEyLVgxe4jwebeEfVZIgXWK17ZtHsRMfP69hOrot7fR6C55TnUHagtxLRqLP9Uwd8JPniTBpQIrQZioUAGz8wnNhzjyRxktXnvZG0zPuoFPd1rKuMKa8MHQpD6niBI72sUyG//pdoHJ6PZNY4++a4YuGQ4uJAS7treu7uaONctdFxm7ezDeiByOIQ1tCg/GIstv77+653EG5fgf6p9koYIxp7wCs/EPMt9ICZ/7fi+/uSYb1XhRNnBwjW77OHXFbCCyYmF+tcDm2hzjp2yQEIeaYm7+iwvbw3+kcVQmjToiGs5BHSrTgNfjdgW00okJ0bhjhh9KagmnYVGnHJFdUzYzi6c5PoXp+q1NuwxXalY283LHMiokTqX8LqpotoXK2yluGyHEIC1r8/jFIrFZSiMfaGczwunSiWrR9VqL6dAo3zce7NLxepjzIn/Ujr9p6woPpnTmbonuuakBVv4Sz07GzvZT8i2BwmGatMg8HwUKYKN9sbpWdt9VKMtvYn2p5TYjkZ6MOXHW8iEXoZpHcitzlroj4jn4P/e9dJLfM9One3akARg8zKwsnj7GkbcRy2+bcGsBDg7CKwa2wixPdlqnhnuZr1/NGQrOWG9Q3qTBrb29EMceRlaILfuO5w0noR5nv4XWYFMGXcq8lyBnCZXg+opfu17ajzP1/ThWm8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966006)(36840700001)(40470700004)(86362001)(2616005)(5660300002)(81166007)(40460700003)(4744005)(426003)(47076005)(44832011)(186003)(6666004)(8936002)(1076003)(336012)(15650500001)(41300700001)(356005)(2906002)(26005)(36860700001)(40480700001)(82740400003)(82310400005)(83380400001)(70206006)(478600001)(36756003)(54906003)(6916009)(70586007)(8676002)(4326008)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 07:09:26.5436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bf2b262-63b8-4f49-b6b5-08da8cb21258 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5895 During the ping test, dom1 tries to assign an ip to eth0 in a loop. Before setting up the network interface by dom0, this results in printing the following error message several times: (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device Silence this by redirecting stderr/stdout to /dev/null as we do not care about the output and we should not pollute the log file. Signed-off-by: Michal Orzel --- automation/scripts/qemu-smoke-arm64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index c80d9b2aee00..7ac96027760d 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -6,7 +6,7 @@ test_variant=$1 passed="passed" check=" -until ifconfig eth0 192.168.0.2 && ping -c 10 192.168.0.1; do +until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do sleep 30 done echo \"${passed}\" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 07:09:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 07:09:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397375.637940 (Exim 4.92) (envelope-from ) id 1oU0o1-0000a4-Is; Fri, 02 Sep 2022 07:09:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397375.637940; Fri, 02 Sep 2022 07:09:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0o1-0000Ze-ET; Fri, 02 Sep 2022 07:09:33 +0000 Received: by outflank-mailman (input) for mailman id 397375; Fri, 02 Sep 2022 07:09:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0o0-0000VG-Ag for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 07:09:32 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2078.outbound.protection.outlook.com [40.107.102.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e10b1b6-2a8e-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 09:09:29 +0200 (CEST) Received: from BN1PR13CA0001.namprd13.prod.outlook.com (2603:10b6:408:e2::6) by CY5PR12MB6454.namprd12.prod.outlook.com (2603:10b6:930:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Fri, 2 Sep 2022 07:09:25 +0000 Received: from BN8NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::b1) by BN1PR13CA0001.outlook.office365.com (2603:10b6:408:e2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Fri, 2 Sep 2022 07:09:24 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT089.mail.protection.outlook.com (10.13.176.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:09:24 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep 2022 02:09:23 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 2 Sep 2022 02:09:22 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e10b1b6-2a8e-11ed-934f-f50d60e1c1bd ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QOM+Z1HgaJqUmynenQswR1Fq1Otb5hXsHaul9pkPdEW7Bt2QUs7uoCGP+IK1pSQ1nG+2zGt4Ce2r6hwhENxCenVZ8sglietLxEPsKUra8XtznAQnSDFmBNHvgZtvf5QFvJlN9+QET/vk0LksD8scAhoyKMVuCjFDvMISyNRZG+2av4XTaF4tBRGNFA5hwpUOjpvw9Ivfj2r58q27GRarYPQghzaP+yMBhQMSkehXMn7zOdlT21QxGm1zg5eJyehwOER/tm+jjAOr2o1P7PAjwVsqkGYST0jF2JCWUgj2revIvA/WBMECZMxyQqt3etIvhyCu4kH5UGLyg0ZC/yjxAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkQ0/4WqrVmydchd0BRt9qoBmBb8mcYYvjFU9/gX3yk=; b=P1Fk2XqZtvGE5CtmC2G98zEQN3lbaj0tzbT73CZNpFZ3EZQ6edXaiKC0W+yZURVdH13WUJXiceN6la4ZrQpGiQgGEr71bW3agg7tyPrG6XN6DiESb0NGjNOEX5O48FogZ2Rr2GTrFGiOfoxMvbrtbyB4zqb+UMZkItV4DnLS42I1uPrh5uRO5i9w3bpECddRK6Lbrg09kqGmNJhAMhUzUuskfw/EJMWBd2t1AlC3JU6j2Rnd2Zim2W0ytx6S0HIlbO7ZDzEGJVvowYqv/wGXTwVABXLafxLJL7gNQlRSAit9iBDqov2bmF8oJd995I7X4lUup+/h6WJYGVIgFrMiTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkQ0/4WqrVmydchd0BRt9qoBmBb8mcYYvjFU9/gX3yk=; b=crdWTldWU62yRnWArL8mw1EfhnjL9F6HIrD8cyYt8yqlmkWbRdxstZxTCDwg3h7QmRGH5l8qrlTExwbJeRS3NDHWWbA3CrNoO7u7xHP9vZ44l5KDpf00P3jJuciHGyWCwu877zIBhvs72hVnDQZLEz56zAEICOQHDaGf1S7R/yk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 Date: Fri, 2 Sep 2022 09:09:03 +0200 Message-ID: <20220902070905.1262-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902070905.1262-1-michal.orzel@amd.com> References: <20220902070905.1262-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1dd57485-c30b-491f-cca9-08da8cb210fe X-MS-TrafficTypeDiagnostic: CY5PR12MB6454:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iOLwsLn+zUboQcSgu3Rtt85VMqhQKYXQOU9lJ/fhONyE/nphvm/H79nqSUQ7X1XIjeTFZThHxNS21epR3SAeL0gLNKqd+ZxIvrBiPfF/rRyQx5hPMt5Ug1/TOtcMXe3/JTaXXsQAoFg8ge4qaqT0CnmLqqSf4D3ipvT0TO64BgO1udnABnyfy0d0Swi7ZQO6RFtg+6heAV6h0SdDxpy50QlAZAJpUju2IoY2V9IPCz2WOgQyY/p2kGU4RXrlYYKnoDIfeX2UUdYCkKZ7QV6Hyl6JENEeO0zZ/oJgmue2Hy2GlgCOedr5f63YNc4R7iEsUG7LkaIZ+GBlUubzeSfwH9aOMQJiF73cOIAxSgqNsC/uMGIdUid1pN3iaiUEV/rgyCcUlt89RJzNWtL5iAne7oDO341qyQdj0O6xqxptQtoFDANkDTy2NamPd44wwqr/6FOUe5Oex8BPJvZi+Pd5lknPI1xv8oYjJZrt9UFW+Z9UtON1kuyDEnpVwp56B1U+bnjJmZlSgS/5wP/cO2nHgNV5xuLh3JGpfC09G9XMkl9u9HwSw5KbW4Z3bALWJsCbGzlMsIIW4U+aE2HbXTp95EMh4pRrtutTL+taMqeS1yW7eW16hJPZBFjofyv8hbIZnrFHGGz8nNFe+rYGbYsZywLc3dh+zyDUm8jBzXP20Q7QlZZqiE1Ie8Vg3cjsqIloDv0PXAvMXLpp8SVvmaKmJD8aqmpxYHwoMBfmkEQIKS9Pq+3CR6ME9QNEKKbjthgGvGHvZQU6GrK4R2hQEEfk2A8bjlPMzBcJ9CJjFFsSMLNMxdrWD3A4fRDDg4vaOXTCsq7ABLSJ0FYimTDYonA6OA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(39860400002)(136003)(36840700001)(40470700004)(46966006)(2906002)(4326008)(26005)(54906003)(8676002)(36860700001)(86362001)(5660300002)(36756003)(44832011)(70586007)(6916009)(70206006)(8936002)(316002)(40480700001)(82740400003)(84970400001)(478600001)(2616005)(356005)(6666004)(336012)(41300700001)(186003)(81166007)(426003)(47076005)(966005)(82310400005)(1076003)(83380400001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 07:09:24.2922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd57485-c30b-491f-cca9-08da8cb210fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6454 After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having two kernel configurations. This is something not needed and maintaining a single kernel version is always easier. Modify qemu-alpine-arm64-gcc to use kernel 5.19 and remove kernel 5.9 from tests-artifacts. Signed-off-by: Michal Orzel --- automation/gitlab-ci/build.yaml | 11 ------ automation/gitlab-ci/test.yaml | 2 +- .../kernel/5.9.9-arm64v8.dockerfile | 34 ------------------- 3 files changed, 1 insertion(+), 46 deletions(-) delete mode 100644 automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index d2f75a090c0f..720ce6e07ba0 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -586,17 +586,6 @@ alpine-3.12-arm64-rootfs-export: tags: - arm64 -kernel-5.9.9-arm64-export: - extends: .test-jobs-artifact-common - image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.9.9-arm64v8 - script: - - mkdir binaries && cp /Image binaries/Image - artifacts: - paths: - - binaries/Image - tags: - - arm64 - kernel-5.19-arm64-export: extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.19-arm64v8 diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 2eb6c3866e2c..07209820b474 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -34,7 +34,7 @@ qemu-alpine-arm64-gcc: needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export - - kernel-5.9.9-arm64-export + - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export artifacts: paths: diff --git a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile b/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile deleted file mode 100644 index 053d65a3454e..000000000000 --- a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile +++ /dev/null @@ -1,34 +0,0 @@ -FROM arm64v8/debian:unstable -LABEL maintainer.name="The Xen Project" \ - maintainer.email="xen-devel@lists.xenproject.org" - -ENV DEBIAN_FRONTEND=noninteractive -ENV LINUX_VERSION=5.9.9 -ENV USER root - -RUN mkdir /build -WORKDIR /build - -# build depends -RUN apt-get update && \ - apt-get --quiet --yes install \ - build-essential \ - libssl-dev \ - bc \ - curl \ - flex \ - bison \ - && \ - \ - # Build the kernel - curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \ - tar xvJf linux-"$LINUX_VERSION".tar.xz && \ - cd linux-"$LINUX_VERSION" && \ - make defconfig && \ - make -j$(nproc) Image.gz && \ - cp arch/arm64/boot/Image / && \ - cd /build && \ - rm -rf linux-"$LINUX_VERSION"* && \ - apt-get autoremove -y && \ - apt-get clean && \ - rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 07:09:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 07:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397376.637958 (Exim 4.92) (envelope-from ) id 1oU0o7-00019a-Q8; Fri, 02 Sep 2022 07:09:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397376.637958; Fri, 02 Sep 2022 07:09:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0o7-00019Q-Mm; Fri, 02 Sep 2022 07:09:39 +0000 Received: by outflank-mailman (input) for mailman id 397376; Fri, 02 Sep 2022 07:09:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0o6-0000Eo-6y for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 07:09:38 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3381c2e2-2a8e-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 09:09:37 +0200 (CEST) Received: from DM6PR06CA0053.namprd06.prod.outlook.com (2603:10b6:5:54::30) by SJ1PR12MB6171.namprd12.prod.outlook.com (2603:10b6:a03:45a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Fri, 2 Sep 2022 07:09:33 +0000 Received: from DM6NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::5d) by DM6PR06CA0053.outlook.office365.com (2603:10b6:5:54::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:09:33 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT050.mail.protection.outlook.com (10.13.173.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:09:32 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep 2022 02:09:32 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep 2022 00:09:31 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 2 Sep 2022 02:09:30 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3381c2e2-2a8e-11ed-82f2-63bd783d45fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dEpajqYunuTuHH/ySIE2/PshNvOgkgl2CC5k/2kj7ozgpkCLI3en23NO3TsG7nSxkM9eISxyDVaiMV5z41sxLgEOY+RPdYTWshXonKz/sLX5K8A4STRvHAyqh9YhcPN7SXS0Hyv55mZqicwzZsPLVKDbspF6+w8R5XqEUQulA/PdkXZtS0JZmMM/mmCKB7wviY/hRsqNE6wEbflP08Jj2BKx68aRU9yfg2VwrYG6qKvF9t8HKxmGgM12GWaul38iT9GZHWz5svvKZKP1Lg/TgUdMg85nKlkyZVgDyYf3ax1WFYdnf1IVMobYFDZa56pA5cD5cEnAdYoXGFxr22Mkdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IybsSOGdqqAMIU/Bv0RNIgzKeODkE+cebiqQFF3IGf8=; b=BWCODGR7KRNE4ChXGSRyk96gyt6sOv3ma0aR/aq7S/m1Zw1qO6+GQSsVYVITDyXSIjldTxeKHh6fidxkz+HNNsPm4uOMGmDGoWGPJMCGc8hqLnofRsxEWAHIzW+pqgR+7hRddKp7VFa3152MPnL5gPEg+OS+HrO9lcQAe/Uxb9quHS6neS8VzH7IEfQjQswb6/G7KlwNBtpkCn2qJDmOoRLA0bALoFNuN8HsbdV/pAYNrQPNRRzGrMkQnyQceeAxp3ed142duoRFBYpoQ2yU9k34HMqWFYc7cznmoGNjcg1W7xkb9k0RYXbFZawZRE6BV8wpsLq/uVXxpP7z7g8cMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IybsSOGdqqAMIU/Bv0RNIgzKeODkE+cebiqQFF3IGf8=; b=hziqKBudyZVSMl2Oz06ne7JFP0PxqCIKq/C4t0btzjsNpNkiTgIQra5Do0WHMY3kjBJzJAKJwvqVyMM17y4Upo6WeLvHXoduDBmgEfqKuLUQ96BvoPXuu4Tn9AJCWPOia/FmFkhjn4se6Nt1e/84IhixlP1SR8eJSoIDaZdxDpY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 Date: Fri, 2 Sep 2022 09:09:05 +0200 Message-ID: <20220902070905.1262-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220902070905.1262-1-michal.orzel@amd.com> References: <20220902070905.1262-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef7c0f33-387c-4fb1-de35-08da8cb215fc X-MS-TrafficTypeDiagnostic: SJ1PR12MB6171:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZiZmBQOBAePezmI1Cdv7/SUoJNm/ZpQeUqiAnAGXz6Y6rP4tMZy8nsNfyOL+Rgh2QY0qnykmmV6qNX3TMSfSTlATvfD/N+nhVeBj6Euye4w8N37DHJEXGBit8H9jdBHfsjeyvKvlP2giT8N8xt7TXs/a2KrXC+hVlmqS4o2HW2AsPv5LqHopsRZkieQs46VOkMh1Jq7VXF2parN+pjzJlU3tPPiyrYG+7kwInoDULW3uyb26xni3FA9F5PFmg5ai3AJS27sAclbSA686aGSI0Bi/p7fnlrgTkAa5x74dHFQj6hfvsQ0JRThlzVwwHpGL6hafQfK5WZM7L4bKBclJN/ymrWEzvfo0SCd+FG/3P20qE3CPOL10UBE+HbwiVm1LO/YzY0dpHBOaKfH0y19ynqzEaxHTYE7wqMKQkTg81u68+XOc/PT4bbYrS1j0mYupJbjecFNiVwzZOVOJVB/0oN6nv+7ZW6wBOGzi/IcI4kArBWiZ0+vu96qbMYPUqaTSxr1aOq2zWVp+qFDCDhhrorzk6srGyNORFYI2BnWrg+8k4932KzZlt5Wh/fjIRbWM1vLmw5xWR97C/K4nWQTkRwEmyYFxy97ky8ya0h209zUlFuQDEafpCSNPwlr1Vua7VWWpVY17fVoJEw7mtq2iEC+1xabQuVPtif4wpZLZ6KOG/9/fPbHY29bTCwgknwsjMpPsDEc23xQZogZcfqS1xqUB0qsZcdQ0QgT0uTNXuud8coVPxs1n4ChJPEeMUvUv/PNovI5rzhxk+x+tDbs9hi/ZW9AILz0dsHRqg2JyfKVfiQ0NFmfD9jec4nEvn7ONZhypcSTivCLmAWi9Qn8SzZW/NPFC9FaaSUfAJLf+nn8y7dUyb/q1lRZqWuuLpXJu X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(136003)(346002)(40470700004)(46966006)(36840700001)(8936002)(54906003)(70586007)(8676002)(966005)(70206006)(316002)(4326008)(6916009)(86362001)(478600001)(81166007)(41300700001)(36756003)(356005)(5660300002)(82310400005)(2616005)(44832011)(26005)(82740400003)(2906002)(6666004)(1076003)(36860700001)(40460700003)(40480700001)(83380400001)(426003)(336012)(47076005)(186003)(157313001)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 07:09:32.6213 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef7c0f33-387c-4fb1-de35-08da8cb215fc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6171 Add a new test job qemu-smoke-arm64-gcc-boot-cpupools that will execute script qemu-smoke-arm64.sh to test boot time cpupools feature. Enable CONFIG_BOOT_TIME_CPUPOOLS for the arm64 build and add a new test case in qemu-smoke-arm64.sh that if selected will: - create a device tree cpupool node with cpu@1 - assign created cpupool to domU0 - add a check in dom0 xen.start to see if domU is assigned a Pool-1 Take the opportunity to refactor the qemu-smoke-arm64.sh script as follows: - use domU_check to store the test's commands to be run from domU - use dom0_check to store the test's commands to be run from dom0 - use fdtput instead of sed to perform dtb modifications - use more meaningful messages for "passed" variable. This way we can grep for messages reported either by domU or dom0 and get rid of assumption that tests can only be run from domU Signed-off-by: Michal Orzel --- automation/gitlab-ci/test.yaml | 19 +++++++++++++++ automation/scripts/build | 3 ++- automation/scripts/qemu-smoke-arm64.sh | 33 +++++++++++++++++++------- 3 files changed, 45 insertions(+), 10 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 07209820b474..d899b3bdbf7a 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -100,6 +100,25 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 +qemu-smoke-arm64-gcc-boot-cpupools: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: diff --git a/automation/scripts/build b/automation/scripts/build index 2b9f2d2b541a..2f15ab3198e6 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -19,7 +19,8 @@ else echo " CONFIG_EXPERT=y CONFIG_UNSUPPORTED=y -CONFIG_STATIC_MEMORY=y" > xen/.config +CONFIG_STATIC_MEMORY=y +CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config make -j$(nproc) -C xen olddefconfig else make -j$(nproc) -C xen defconfig diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 7ac96027760d..c2184850293c 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -4,20 +4,22 @@ set -ex test_variant=$1 -passed="passed" -check=" +if [ -z "${test_variant}" ]; then + passed="ping test passed" + domU_check=" until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do sleep 30 done echo \"${passed}\" " +fi if [[ "${test_variant}" == "static-mem" ]]; then # Memory range that is statically allocated to DOM1 domu_base="50000000" domu_size="10000000" passed="${test_variant} test passed" - check=" + domU_check=" current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) if [[ \"\${expected}\" == \"\${current}\" ]]; then @@ -42,11 +44,23 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -cpu cortex-a57 -machine type=virt \ -m 1024 -smp 2 -display none \ -machine dumpdtb=binaries/virt-gicv2.dtb -# XXX disable pl061 to avoid Linux crash -dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv2.dts > binaries/virt-gicv2-edited.dts -dtc -I dts -O dtb binaries/virt-gicv2-edited.dts > binaries/virt-gicv2.dtb +# XXX disable pl061 to avoid Linux crash +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled + +if [[ "${test_variant}" == "boot-cpupools" ]]; then + # Create cpupool node and assign it to domU0 + cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" + cpupool_phandle="0xffffff" + fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/domU0 domain-cpupool $cpupool_phandle + + # Check if domU0 (id=1) is assigned to Pool-1 + passed="${test_variant} test passed" + dom0_check="if xl list -c 1 | grep -q Pool-1; then echo ${passed}; fi" +fi # Busybox mkdir -p initrd @@ -66,7 +80,7 @@ echo "#!/bin/sh mount -t proc proc /proc mount -t sysfs sysfs /sys mount -t devtmpfs devtmpfs /dev -${check} +${domU_check} /bin/sh" > initrd/init chmod +x initrd/init cd initrd @@ -98,6 +112,7 @@ ifconfig xenbr0 up ifconfig xenbr0 192.168.0.1 xl network-attach 1 type=vif +${dom0_check} " > etc/local.d/xen.start chmod +x etc/local.d/xen.start echo "rc_verbose=yes" >> etc/rc.conf @@ -148,5 +163,5 @@ timeout -k 1 240 \ -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial set -e -(grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "DOM1: ${passed}" smoke.serial) || exit 1 +(grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "${passed}" smoke.serial) || exit 1 exit 0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 07:10:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 07:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397404.637969 (Exim 4.92) (envelope-from ) id 1oU0pF-0003Ml-C8; Fri, 02 Sep 2022 07:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397404.637969; Fri, 02 Sep 2022 07:10:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0pF-0003Me-8U; Fri, 02 Sep 2022 07:10:49 +0000 Received: by outflank-mailman (input) for mailman id 397404; Fri, 02 Sep 2022 07:10:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU0pE-0003Lp-43 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 07:10:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2063.outbound.protection.outlook.com [40.107.20.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d18ceae-2a8e-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 09:10:45 +0200 (CEST) Received: from DU2PR04CA0311.eurprd04.prod.outlook.com (2603:10a6:10:2b5::16) by DBBPR08MB5898.eurprd08.prod.outlook.com (2603:10a6:10:20c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 07:10:43 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::d2) by DU2PR04CA0311.outlook.office365.com (2603:10a6:10:2b5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 2 Sep 2022 07:10:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 07:10:43 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Fri, 02 Sep 2022 07:10:43 +0000 Received: from 265fb81e5b83.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 607692D6-857E-4E25-98CF-1C1393D8F2BF.1; Fri, 02 Sep 2022 07:10:37 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 265fb81e5b83.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 07:10:37 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by GV1PR08MB8083.eurprd08.prod.outlook.com (2603:10a6:150:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 07:10:34 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20%7]) with mapi id 15.20.5588.012; Fri, 2 Sep 2022 07:10:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d18ceae-2a8e-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iXzV0VeDxoIzcXlybg34vV4nKxDs2nxFdCzQE9GLD3VdaKZSNBJDeazha36CemI6YopfC6zZ0ktEKrOTMGv87Jsqaeta/LUVooOmxdB8xxx3Py3KbKFPkcKd0DagRsoHSspEuZaXINUe7aRiz/Yybu5EAmh4VyyXkKfRTp8fB1lS2BkaTOp7v5IwOjbFv2OUPdUvcb/MI2guz9FKhNdbs+SWC4l67ICQ0Kcgvem0xxw8I4HWt3k4dSR5PqAS+zLpAxoqCI1kbwx5ONuNgqaKMpX2vSgPmE37mz62Pble2bcTdO7FBHWRz/6YQfb4xTDWpvlebZPG3u5EI7tPVOCiUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M8/CfeCztkl9UZ0Gv642GE2S/5O7CvFEFtWFvLIHtO8=; b=b03KQdl8P/ugUzomRPQ7ydL/fuHwPY9S76Jy9oOUyEFFH7Og6ULvQ+N03z5POVpSXqeGzoP6XS+UtYw9bF+orvnS0yceSBSwAN0i/V5Ix3wQ+kjArZk1M6m217IJ3bYhNcQ75jKjTOOeLnaH4NtZRWa705cmT7gnWpuL4q9MnCA5TTRVWHYwfjB5gm9ysLt6bSi0lCC9b8aeQO7nc8LbJiFCgq+485c54vq9vmEQZTEYvEKNC5DGUDKU+iUlAMcCZ8OZFGkslsT7yzRUEZqJDhzjBtlT+yDKpOXy9BoNXGfYl/xVltaTKLWq6x5yUll3DVhY/Jfeh+z8HeF8t3Tkcg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M8/CfeCztkl9UZ0Gv642GE2S/5O7CvFEFtWFvLIHtO8=; b=x392sJlSU24HpqVMRIxgQrdY58i+eyK0ktG1f8YWM5+PQ+ZdBjzLVmvFRqpp/EGvShsZdP5rOaJ8GQHXROOc2odxzx43YWpX6IZbpBRtrtG+Ms3AqiQC3BG5foxt7v12ugWhWGuGjFtFbjFUB12qeV3yUgAXMEv8zr+kqcKOrp0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eSZ0mzcL3jMPweRz0qajR9RmV163IuWBdo9EJrczVmd9Muc2qA2NfErAb0gC7Xh53sQLLJGSxyftrvhl5r7slzUO/QK+DuugrkxxSNKzX6qGH5ofg+aC1GMwgVNtV/HHqgVUseaAHmrbe8T9/MGi759ysXe4kE/f2vIAua99icGSJqrvSZdC1jVU2MHk1dh+aU3RUSTcY2WgOy02pwrGv6vS2kIypcTRfqH0WwBVI4AHkeJ53APR8EeyHmjNEaUt2eQC8jPYS1EEs0NWsOK7mg/OCo6e/njyECgvwAYOHkx4vG4jsTBk4WSW74b80VV1eWDlKeHLGl4gRjNxQC2Acw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M8/CfeCztkl9UZ0Gv642GE2S/5O7CvFEFtWFvLIHtO8=; b=I0tXA0W3LAn68rOZE/3C3XBSMjmvN9E15arOv0IJCfb98/BtaSc5Kxf42fziikGe/tIU9aIEfAGzs6OhxuaeGfS7likRD0yny25cTsdcwWJ5CYExRoLTIp2svUH+GpEb8iCj79IpM4EvTsifKXQv4Z0ge4IM2axdFwkbBDGvht1Ly18fD4Ba7k9LPnse5ujAH6n2yWnjJlcTtuD3V6Zuckd+DQH5q8GfcyITt8i7qkPTbU3CoVw7Xc1PAWdLg7T+djpeE66aXGenbM37nb3+cVI88/5wPAeNGkuVMCNguTikxINj0HgR6/Q3JoAE0Dv8h5olDni+LtUDcbsTrEmgnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M8/CfeCztkl9UZ0Gv642GE2S/5O7CvFEFtWFvLIHtO8=; b=x392sJlSU24HpqVMRIxgQrdY58i+eyK0ktG1f8YWM5+PQ+ZdBjzLVmvFRqpp/EGvShsZdP5rOaJ8GQHXROOc2odxzx43YWpX6IZbpBRtrtG+Ms3AqiQC3BG5foxt7v12ugWhWGuGjFtFbjFUB12qeV3yUgAXMEv8zr+kqcKOrp0= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v11 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v11 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYvOMsvYdyv+g/RU6qDpjhWsAPd63KmnWAgAEgCQA= Date: Fri, 2 Sep 2022 07:10:34 +0000 Message-ID: References: <20220831024041.468757-1-Penny.Zheng@arm.com> <20220831024041.468757-7-Penny.Zheng@arm.com> <9d328b4d-ef7a-e457-428d-83a2b2351465@xen.org> In-Reply-To: <9d328b4d-ef7a-e457-428d-83a2b2351465@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A40F94C6AB77C648A56041E4CAB3CC69.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 99eff9c6-e8a5-4d36-ecc5-08da8cb24021 x-ms-traffictypediagnostic: GV1PR08MB8083:EE_|DBAEUR03FT062:EE_|DBBPR08MB5898:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dGvAX+PQ7H/HpjqZpt21bpUNiNt81G5OS5dxsLETwPnUl8GQGhyaC/dbnvdAJqkKXk4qUan7V6aCKuFcphBs1g0C1/xl1trdJ7xeYzYT+0XHKyE5eSf8+7q/uLIIzfDbi3/HTC/7MHr65V6hCXv70Qf5BsrKg/IbecWgd9urUe+Jc/jkH2wWkul6eiNH4IwgsKsmv8vEiQfw42qiKtsC6yAoOm7blEgL684igrAnUND/fARZ1o0GOfQjwA4Zl+fc5AjEjhFYcxEHgKvkPfxv3N8FU6kAK6OkBQ+GsJRvDR/AG1bbRLo/Q4TKsXGqt0UQoIQ4KYcmAu9PCrvcvXTq990AgVnFMZMjwBzXRJlzeLyKOhnFlMIKOcykjOQp8HnSXrzLzXFV4sL89IkyiTFymwzQbg+8y7MqM1LTptpTTpJZOxqaWnIcHvABOCyQyIIU8WMh2XprSOtEek3r11m/YurHqGfFJWSLdK7db7u4odu71YbVEwBD5w8Zdr4a/zpAgkcIKe2GTRh8dzX/CVh2t66nSafIyy3ShpFKasf2XK8Lf2/g1HLA5mhGCyEmHrNWGwLK02CddYhpS6eUo3yxP5gQg2YGEsdSck1Jx5RqvBuc9Y1YnpLFDN/aU5Rwj88vivHQO33O+oPliGMYd8xGsgaiF1kixPdwaaKa+giVu/3mRoj9Gk4MbfCe2aZ5rTg5SJebubacgNk4A6ykINpZldoQb264IMoQZ4PkJN7zxcgk8M33e1l40lwUUqHLlE2+pLYc7JFrIRLm7JR/e8ZBjg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(66946007)(66556008)(41300700001)(66476007)(4326008)(64756008)(76116006)(83380400001)(186003)(54906003)(478600001)(110136005)(316002)(33656002)(26005)(9686003)(66446008)(8676002)(53546011)(55016003)(7696005)(6506007)(86362001)(38070700005)(71200400001)(5660300002)(8936002)(2906002)(52536014)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8083 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4862b49d-0a39-4883-1f83-08da8cb23afa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oCwmhgkqDaQs/N4jcDTbeVL4Ub99EolNepyzfvjbi9gcWVh5Q8ByAnJx51AFwuhj0irBgVDfKQdzoQDR+UhraWn1OaLqqYuB+cLIQweSXMEuhQINzRtIBeNlykAmH4fksKQYp0j8A9aCc5UQBkn4ccnqn8OqG5r1di/TzEnox3gDzGCuGzKbOL8WaQkOQBoSmEZL3OMzksURwJ8LEVLkIoA0haFlUVgxAM+1Yn0HIg1P7hY2OJTD7fp2Soa1u0QgAmkJmFFL9WmObNUTMwkWotxkeDdYmMcVhit/hh3LKkLbFfCuWRLb2q5QKLPHqiFWlx/ponc/3kJQiFQuMgYDkZ9kcUaRFfbP0qa3MhiVSM/ON0Adtnr6WW/SE+FXXXcng/ex/I0O+KdLfOQbZ7Sk5RbKGL+V2ZU6gDaF9lV/Z0t1645RU2nHergClM0vFy5zIimVxDtIDln7Uc4l+CZsa6rJ7VZ8py/1ywooIOQaRPD5liQ9eooVX+XTah2JSQ6PNMSGDfZp3U4V56pgLawjgLdGlXj50v0U63xXouPAFqbh1gPaOwALr9uBRkcR2pWwQHmH/0JdIdnmCdPGydnXq7CwdGfqQhkxOhbYjt8hOwq8JtNnP3QOojk5RHhMJiLU/4dgA70c7tTf0wdzSTfRM+jb+pyVpDhFIG+cTAB4fBHe9BR09Ka8RcbmStSh0AyuIcNogZWwBjGhAxZatkqNBD/gOtOebK/6K1ggaFX1eGGfZFVFvydCEnwBUWRih85CcY7lsm8Mrn4Brm2/JvFt0w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(46966006)(40470700004)(36840700001)(53546011)(7696005)(83380400001)(41300700001)(26005)(9686003)(336012)(86362001)(47076005)(186003)(356005)(81166007)(36860700001)(40460700003)(6506007)(82740400003)(8936002)(5660300002)(2906002)(40480700001)(8676002)(4326008)(70206006)(55016003)(70586007)(54906003)(33656002)(52536014)(316002)(478600001)(82310400005)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 07:10:43.4378 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99eff9c6-e8a5-4d36-ecc5-08da8cb24021 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5898 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAxLCAy MDIyIDk6NTMgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJt LmNvbT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9y Z2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Ow0KPiBKYW4gQmV1bGljaCA8amJl dWxpY2hAc3VzZS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+Ow0KPiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxMSA2 LzZdIHhlbjogcmV0cmlldmUgcmVzZXJ2ZWQgcGFnZXMgb24NCj4gcG9wdWxhdGVfcGh5c21hcA0K PiANCj4gSGkgUGVubnksDQo+IA0KPiBPbiAzMS8wOC8yMDIyIDAzOjQwLCBQZW5ueSBaaGVuZyB3 cm90ZToNCj4gPiArLyoNCj4gPiArICogQWNxdWlyZSBhIHBhZ2UgZnJvbSByZXNlcnZlZCBwYWdl IGxpc3QocmVzdl9wYWdlX2xpc3QpLCB3aGVuDQo+ID4gK3BvcHVsYXRpbmcNCj4gPiArICogbWVt b3J5IGZvciBzdGF0aWMgZG9tYWluIG9uIHJ1bnRpbWUuDQo+ID4gKyAqLw0KPiA+ICttZm5fdCBh Y3F1aXJlX3Jlc2VydmVkX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IG1lbWZs YWdzKQ0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlOw0KPiA+ICsNCj4g PiArICAgIEFTU0VSVF9BTExPQ19DT05URVhUKCk7DQo+ID4gKw0KPiA+ICsgICAgLyogQWNxdWly ZSBhIHBhZ2UgZnJvbSByZXNlcnZlZCBwYWdlIGxpc3QocmVzdl9wYWdlX2xpc3QpLiAqLw0KPiA+ ICsgICAgc3Bpbl9sb2NrKCZkLT5wYWdlX2FsbG9jX2xvY2spOw0KPiA+ICsgICAgcGFnZSA9IHBh Z2VfbGlzdF9yZW1vdmVfaGVhZCgmZC0+cmVzdl9wYWdlX2xpc3QpOw0KPiA+ICsgICAgc3Bpbl91 bmxvY2soJmQtPnBhZ2VfYWxsb2NfbG9jayk7DQo+ID4gKyAgICBpZiAoIHVubGlrZWx5KCFwYWdl KSApDQo+ID4gKyAgICAgICAgcmV0dXJuIElOVkFMSURfTUZOOw0KPiA+ICsNCj4gPiArICAgIGlm ICggIXByZXBhcmVfc3RhdGljbWVtX3BhZ2VzKHBhZ2UsIDEsIG1lbWZsYWdzKSApDQo+ID4gKyAg ICAgICAgZ290byBmYWlsOw0KPiA+ICsNCj4gPiArICAgIGlmICggYXNzaWduX2RvbXN0YXRpY19w YWdlcyhkLCBwYWdlLCAxLCBtZW1mbGFncykgKQ0KPiA+ICsgICAgICAgIGdvdG8gZmFpbF9hc3Np Z247DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIHBhZ2VfdG9fbWZuKHBhZ2UpOw0KPiA+ICsNCj4g PiArIGZhaWxfYXNzaWduOg0KPiA+ICsgICAgdW5wcmVwYXJlX3N0YXRpY21lbV9wYWdlcyhwYWdl LCAxLCBmYWxzZSk7DQo+IA0KPiBMb29raW5nIGF0IGFzc2lnbl9kb21zdGF0aWNfcGFnZXMoKS4g SXQgd2lsbCBhbHJlYWR5IGNhbGwNCj4gdW5wcmVwYXJlX3N0YXRpY21lbV9wYWdlcygpIGluIG9u ZSBvZiB0aGUgZXJyb3IgcGF0aC4gSXQgZG9lc24ndCBsb29rIGxpa2UNCj4gdGhlIGxhdHRlciBj YW4gYmUgY2FsbGVkIHR3aWNlIG9uIGEgcGFnZS4NCj4gDQo+IFRvIGJlIGhvbmVzdCwgSSBmaW5k IGEgYml0IG9kZCB0aGF0IGFzc2lnbl9kb21zdGF0aWNfcGFnZXMoKSBpcyBjYWxsaW5nDQo+IHVu cHJlcGFyZV9zdGF0aWNtZW1fcGFnZXMoKSBiZWNhdXNlIHRoZSBmb3JtZXIgZG9lc24ndCBjYWxs IHRoZSAicHJlcGFyZSINCj4gZnVuY3Rpb24uDQo+IA0KPiBBRkFJQ1QsIHRoaXMgaXMgYW4gaXNz dWUgaW50cm9kdWNlZCBpbiB0aGlzIHBhdGNoLiBTbyBJIHdvdWxkIHJlbW92ZSB0aGUgY2FsbA0K PiBmcm9tIGFzc2lnbl9kb21zdGF0aWNfcGFnZXMoKSBhbmQgdGhlbiBsZXQgdGhlIGNhbGxlciBj YWxscw0KPiB1bnByZXBhcmVfc3RhdGljbWVtX3BhZ2VzKCkgKHRoaXMgd291bGQgbmVlZCB0byBi ZSBhZGRlZCBpbg0KPiBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcygpKS4NCj4gDQoNClRydWUsIHRy dWUsIHRoYW5rcyBmb3IgcG9pbnRpbmcgb3V0ISENCg0KPiBBbHNvLCBJIHRoaW5rIGl0IHdvdWxk IGJlIGdvb2QgdG8gZXhwbGFpbiB3aHkgd2UgZG9uJ3QgbmVlZCB0byBzY3J1Yi4NCj4gU29tZXRo aW5nIGxpa2U6DQo+IA0KPiAiVGhlIHBhZ2Ugd2FzIG5ldmVyIGFjY2Vzc2libGUgYnkgdGhlIGRv bWFpbi4gU28gc2NydWJiaW5nIGNhbiBiZSBza2lwcGVkIi4NCj4gDQoNCk9rLCAgSSdsbCBhZGQg aW4tY29kZSBjb21tZW50DQoNCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:01:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:01:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397417.637980 (Exim 4.92) (envelope-from ) id 1oU1cS-0000gU-OA; Fri, 02 Sep 2022 08:01:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397417.637980; Fri, 02 Sep 2022 08:01:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1cS-0000gN-L7; Fri, 02 Sep 2022 08:01:40 +0000 Received: by outflank-mailman (input) for mailman id 397417; Fri, 02 Sep 2022 08:01:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1cR-0000gH-TE for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:01:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1cR-0001RS-If; Fri, 02 Sep 2022 08:01:39 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU1cR-0002UG-Cf; Fri, 02 Sep 2022 08:01:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vm3NWXrvJFhnY8zHAUaiPmhnB+G0684b6qiXmr/lis8=; b=yy5z7cQNDmCUZTyvOlTcynoRI5 3y66B3cWSUyisJMGeVKchafK4LIgzvoieojx4wDVZK8KNvC1+IMXnNGuTgjUKgUbeKIlJFkUga72s HHjPVkRP2y5qAq36Y6izRSoVK9FPONhzNNq48AVvTzpheGxbIfnsGI8oF6z8rfWf1lig=; Message-ID: <56d7a2e6-8749-601b-b163-669401bdfd67@xen.org> Date: Fri, 2 Sep 2022 09:01:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory To: Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Bertrand Marquis Cc: Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-2-Henry.Wang@arm.com> <9b5afd5e-ec5c-bac6-9ad0-9dd9663aa705@xen.org> Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 02/09/2022 02:28, Henry Wang wrote: >> This is technically a change in behavior for Xen (we would panic rather >> than continue). I am happy with the proposal. However, this doesn't seem >> to be explained in the commit message. >> >> That said, I think this should be split in a separate patch along with >> the ones below (including the prototype changes). > > According to Michal's comment, I've removed the return type and function > prototype change in my local v2. So this patch itself is fine. My question now > would be, do maintainers think this change of behavior with processing the > chosen node be helpful? Yes. I think it is saner to stop booting early rather than seen random behavior afterwards. > Do we prefer an instant panic or current behavior? I think we should leave that up to the caller. Today, this is a panic() but we may decide differently in the future. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397424.637991 (Exim 4.92) (envelope-from ) id 1oU1fI-0001IE-4R; Fri, 02 Sep 2022 08:04:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397424.637991; Fri, 02 Sep 2022 08:04:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1fI-0001I7-1c; Fri, 02 Sep 2022 08:04:36 +0000 Received: by outflank-mailman (input) for mailman id 397424; Fri, 02 Sep 2022 08:04:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1fH-0001Hz-HA for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:04:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1fH-0001Ts-8k; Fri, 02 Sep 2022 08:04:35 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU1fH-0002aB-2r; Fri, 02 Sep 2022 08:04:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Iww+qkUmQIk4OGAhsIEZ1lk3lfswIjMNRrkLlcu0fXY=; b=XP36nketlO92QFgYOx/Y6pB7dC LSTzlKeY8PqjnREn2dNnkmfwHsjOOofOSMdAPCGT30Z5fMAVauFiE1qwWMKs8edklBA9txmk+vLZt t0rIJ+4iCpdkbl2HINsh6cppq6pSz2oYzndNLXgn47sSxj0B8Rki7NCNoV8o982YAHzs=; Message-ID: Date: Fri, 2 Sep 2022 09:04:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Wei Chen , Stefano Stabellini Cc: Henry Wang , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Volodymyr Babchuk References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Wei, On 02/09/2022 04:07, Wei Chen wrote: > > >> -----Original Message----- >> From: Xen-devel On Behalf Of Wei >> Chen >> Sent: 2022年9月2日 11:03 >> To: Stefano Stabellini ; Julien Grall >> >> Cc: Henry Wang ; xen-devel@lists.xenproject.org; >> Bertrand Marquis ; Volodymyr Babchuk >> >> Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and >> heap allocator >> >> Hi Julien and Stefano, >> >>> -----Original Message----- >>> From: Stefano Stabellini >>> Sent: 2022年9月2日 9:51 >>> To: Julien Grall >>> Cc: Stefano Stabellini ; Henry Wang >>> ; xen-devel@lists.xenproject.org; Bertrand Marquis >>> ; Wei Chen ; Volodymyr >> Babchuk >>> >>> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and >>> heap allocator >>> >>> On Thu, 1 Sep 2022, Julien Grall wrote: >>>> Hi Stefano, >>> >> >>> In any case, I think we can postpone to after the release. > > Maybe we can add some notes to say that this feature is still > experimental in EFI + DTS boot? Why EFI + DTS only? Regardless the discussion about how to properly checking the region, I think this wants to be a tech preview. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:11:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:11:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397431.638001 (Exim 4.92) (envelope-from ) id 1oU1mJ-0002jU-Uh; Fri, 02 Sep 2022 08:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397431.638001; Fri, 02 Sep 2022 08:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1mJ-0002jN-S5; Fri, 02 Sep 2022 08:11:51 +0000 Received: by outflank-mailman (input) for mailman id 397431; Fri, 02 Sep 2022 08:11:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1mI-0002jH-73 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:11:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1mH-0001by-Se; Fri, 02 Sep 2022 08:11:49 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU1mH-00032q-MF; Fri, 02 Sep 2022 08:11:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BWnCXcECXEynU70t6lUAg5HZUVGqJS9CbB/kj6BmBSA=; b=dNYQBtF6Gq5XFNZMWJmaDYKhkG td9IMg3YzxOrufuy/oC0csc6ppngfOwOdXhq0eTtRcy3D17Nhs6GMfoBsonlNrNDW0by5XhwSm2xX owAX3aRvGtvNbnRJIhsXU1H2A/tR8+884LCNREuBadrH4kPVY4Ytg+NgwHicYxWN3E6Y=; Message-ID: <3597a89f-98f6-d43a-4dd9-345b155e7216@xen.org> Date: Fri, 2 Sep 2022 09:11:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Stefano Stabellini References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/09/2022 04:30, Henry Wang wrote: > Hi Julien, Hi Henry, >> -----Original Message----- >> From: Julien Grall >>>> This code is now becoming quite confusing to understanding. This loop is >>>> meant to map the xenheap. If I follow your documentation, it would >> mean >>>> that only the reserved region should be mapped. >>> >>> Yes I think this is the same question that I raised in the scissors line of the >>> commit message of this patch. >> >> Sorry I didn't notice the comment after the scissors line. This is the >> same question :) >> >>> What I intend to do is still mapping the whole >>> RAM because of the xenheap_* variables that you mentioned in... >>> >>>> >>>> More confusingly, xenheap_* variables will cover the full RAM. >>> >>> ...here. But only adding the reserved region to the boot allocator so the >>> reserved region can become the heap later on. I am wondering if we >>> have a more clear way to do that, any suggestions? >> >> I think your code is correct. It only needs some renaming of the >> existing variable (maybe to directmap_*?) to make clear the area is used >> to access the RAM easily. > > Thanks for the clarification. I checked the code and found the xenheap_* > variables are: > xenheap_virt_start, xenheap_virt_end, xenheap_mfn_start, > xenheap_mfn_end, xenheap_base_pdx. > > For clarification, do we need to change all of them to directmap_*? Good question. > > A pure renaming should be easy (and I guess also safe), but maybe I am > overthinking because arm32 also uses xenheap_virt_end, xenheap_mfn_start > and xenheap_mfn_end. These variables refer to the real xenheap, I am not > sure renaming these would reduce the readability for arm32. So on arm32, only the xenheap is direct mapped today. So I think it would be fine to switch the name to "directmap_*". For extra clarify we could add an alias for arm32 between "xenheap_*" and "directmap_*". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:13:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:13:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397438.638013 (Exim 4.92) (envelope-from ) id 1oU1o1-0003KA-Aj; Fri, 02 Sep 2022 08:13:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397438.638013; Fri, 02 Sep 2022 08:13:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1o1-0003K3-6L; Fri, 02 Sep 2022 08:13:37 +0000 Received: by outflank-mailman (input) for mailman id 397438; Fri, 02 Sep 2022 08:13:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1nz-0003Jx-V1 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:13:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1nz-0001dh-K7; Fri, 02 Sep 2022 08:13:35 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU1nz-0003H6-EW; Fri, 02 Sep 2022 08:13:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nqKqBX88AtQ6oEKESEOaPu9A1+c8RgTpoOjHZ69JxyU=; b=58nwyYRE0T0anXYjhTVpgiTHh6 PvwSCm3zhmQuKgybBO2mzSs59a+EX6DOTYeGkeNq6dOIDrz81XV4CKMwZWCt3gAg/5J/79FYTYbFD nT09NHyAP6lbaIc8LcIxLReb0KAiYZdDcRERh5yaHj3J2V6vXaawf9UXhI78zH4VDaoU=; Message-ID: <70c3f092-8926-0114-1d8a-944aff12a1f7@xen.org> Date: Fri, 2 Sep 2022 09:13:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 1/9] xen/arm: introduce static shared memory Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220721132115.3015761-1-Penny.Zheng@arm.com> <20220721132115.3015761-2-Penny.Zheng@arm.com> <3b58faef-d87d-3381-f54d-8ccdc0ea105f@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 02/09/2022 04:26, Penny Zheng wrote: >>> Do you think I shall further point out that right now, this part >>> feature is not implemented in codes? >> >> I have made a couple of suggestion for the code. But I think the binding >> would look a bit odd without the host physical address. We would now have: >> >> < [size] [guest address]> >> >> I think it would be more natural if we had >> >> <[guest address] [size]> >> >> And >> >> <[guest address] [size] [host physical address]> >> > > Ok, about the binding order change, do you prefer it in v7 or 4.17-post, > since it may also need a few code tweak. The binding will become stable as soon as we release 4.17. So this would need to be fixed before releasing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:17:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:17:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397447.638023 (Exim 4.92) (envelope-from ) id 1oU1ru-00041B-Tj; Fri, 02 Sep 2022 08:17:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397447.638023; Fri, 02 Sep 2022 08:17:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1ru-000414-Qv; Fri, 02 Sep 2022 08:17:38 +0000 Received: by outflank-mailman (input) for mailman id 397447; Fri, 02 Sep 2022 08:17:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1rt-00040y-RO for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:17:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1rt-0001iP-Js; Fri, 02 Sep 2022 08:17:37 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU1rt-0003MO-E1; Fri, 02 Sep 2022 08:17:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mrUUPkAojxseD9SK97O8xr9gtyYPWw2Qjxu+eHjVMxg=; b=RVe6mRoB1Hu2zsviYzOOzh2R/y cU4E6dZiepoLLS1rdRP+PVx3y65i4zZgRLjmR04cvgnT8W3Kjl/j0SGqw4L1iPlZ7GHZeUrkwcCNd syckIwdMwxfZDcOWTlR4AU3gTW835amb3/6xAAo8/+1udjiqJdZN4ZwWaJCKkBzl9FXY=; Message-ID: Date: Fri, 2 Sep 2022 09:17:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property Content-Language: en-US To: Stefano Stabellini Cc: Rahul Singh , xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Volodymyr Babchuk References: <3899ada4cc8217b45eab4f8d85492b0d5a6a9580.1662023183.git.rahul.singh@arm.com> <2142aa46-24a0-e0cb-16c0-95e8f6302ce6@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 02/09/2022 03:20, Stefano Stabellini wrote: >>> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h >>> index 430a1ef445..5579c875d2 100644 >>> --- a/xen/include/xen/device_tree.h >>> +++ b/xen/include/xen/device_tree.h >>> @@ -82,6 +82,7 @@ struct dt_device_node { >>> dt_phandle phandle; >>> char *full_name; >>> domid_t used_by; /* By default it's used by dom0 */ >>> + bool_t static_evtchn_created; >> >> I can see why you want to add the boolean in dt_device_node. However, I >> dislike this approach because this feels an abuse of dt_device_node and the >> field is only used at boot. >> >> So this seems to be a bit of a waste to include it in the structure (even if >> we are re-using padding today). >> >> I don't have a solution that is has trivial as this approach. However, at >> minimum we should document this is a HACK and should be remove if we need >> space in the structure. > > I would move static_evtchn_created just above (or below) "bool > is_protected". It would still re-use the padding and it would be > closer to another more similar field of the struct. > > The only other option that I can think of would be to use port_is_valid, > instead of static_evtchn_created, to check that the port has already > been allocated, but we wouldn't be able to tell if it is a static evtchn > or simply unavailable for other reasons You don't need to know the event channel was statically allocated. If you have access to the event channel, then you can easily find out what is the remote port. > and it would require more device > tree parsing. The parsing is indeed the big cons. Hence, why I hadn't suggest it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397454.638034 (Exim 4.92) (envelope-from ) id 1oU1tA-0004c5-85; Fri, 02 Sep 2022 08:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397454.638034; Fri, 02 Sep 2022 08:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1tA-0004by-5S; Fri, 02 Sep 2022 08:18:56 +0000 Received: by outflank-mailman (input) for mailman id 397454; Fri, 02 Sep 2022 08:18:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1t9-0004bq-Fq for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:18:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2059.outbound.protection.outlook.com [40.107.20.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e17deb58-2a97-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 10:18:53 +0200 (CEST) Received: from AS9PR06CA0355.eurprd06.prod.outlook.com (2603:10a6:20b:466::22) by VI1PR08MB5309.eurprd08.prod.outlook.com (2603:10a6:803:133::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 08:18:50 +0000 Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::11) by AS9PR06CA0355.outlook.office365.com (2603:10a6:20b:466::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Fri, 2 Sep 2022 08:18:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 08:18:50 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Fri, 02 Sep 2022 08:18:49 +0000 Received: from c517a640682f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CC23C4BE-217D-445A-A4F8-7E201EC37CDC.1; Fri, 02 Sep 2022 08:18:43 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c517a640682f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 08:18:43 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB5907.eurprd08.prod.outlook.com (2603:10a6:20b:2da::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 08:18:42 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 08:18:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e17deb58-2a97-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FTcNEYJ/N70G5dmbMcUaftY0FEtNU+Np4YoHG1LR9J+kKrAN2WJ+fQGsarewCy32tuYn4+bNymFA0dIRBhElQg2XgCYxop8c9hF6IBIR6gpBUqhaQgMxxXPIrPsNeSkLqNqHGTZeSEH4j+7/RhudPrt7zbg9If8nV5eCHr50x9PT4XJ6/oiz2WKF+V7YfnMDTp47252dGBIhjPZx/GaDOBF8E1mXnCgxaPMW78ZmP3BaJqx7F4svbVTilnDiu3GXbJS7lxcSfTazYR6pP+UyieroTzfkrmDfKstRvtHyu0pZNApLm/heHZ7dasGXwdrc5ToXKzz40FaJUZHYU2XWiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUVHDdxEJym8NDyFqApVQbksD709+G831EmR+xDOp7Y=; b=a1yzChJ1nUHm28ux0tW1Wl2Ws65a64+kQkDs2xea22wtqYQfmmZUM2woXgugrHW+s+G81TVdTGU4dgdt+pb2ZC6XU+02jl1jvNRogLdBLfSiPONuz0feJKAi0HxQRMeRPaIC5osMGR7qrdw7q4+2aucxc++4VSEViZVVWt9j9bq0vIiXmexrj3b6RAw3qWBDakpjyLqJuLEqMvx+glMqfhacU/vgqYuMfERhy/U5KwQVe3QTLkZKImf+usrTwMu0esprUOX89jaajfHmsifBcK8qsXaA9sL9tsyFNGp7B6K4xafKtiUL6DGS8tzezIrbJtGN2z76PlcEWAv5C2w8/A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uUVHDdxEJym8NDyFqApVQbksD709+G831EmR+xDOp7Y=; b=upueO9yL5JmQ5nG3plI3E1BvWTBTsZprlhvNgvLL/WEEojfMpZ2PfBvB3+dcBOvN7UOfOFVaynBSUAyG3dQbjbjsxpO286o7c9U2SwS3UUhqyD2VsUim80Hutua28s5Q+CppzZeEMZ0XPNAU8sBWGEI9vZoQDAN217dyxdWNWqc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z4ZZw4J1eD0exYqF2YpEB/UmN6aBeyFMw+37aepBIQt5e3pApP53g63CE+a4jWR1aJHTDEYxvVhtujH9drL7IafbjnByMDnzVZWhtnCEgaecYKgG5RoJeAOetbVhi465zXAeTVpnVAHSyNefnGqn9sg8MHWqIukKHwOJdhllq9lQO4pGjogc6Jwtf1VE+fCVP4LyQBWuOOGCfSdXPpQFb15EsbKYkjFMQX7zxuQCA8QPef8bDl65lgK/0N4FwTth19J+dxuHhSbl35LCUhFy6e2mEOdn6QSL19nXpY7Zv/EG42oO4EUzZjUm9gxRg97M1dJq7brMQEnmLVtkoZ6+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUVHDdxEJym8NDyFqApVQbksD709+G831EmR+xDOp7Y=; b=eMOLAUdRxGt5clL/5Nt6G1qhCkq4QgrbJ5Pe+0nj9VTs4V4IGuWjwwT41QTffKFNMH+spMoJRsWPozkqNWXtucnsvWkxmkPOOrJO/WSbbX6wS4qGecoWtzZfdlXdmADm99pkC292JjpGqTxUsKNvWKKZ/APDwe7Q+TNNAyPVs8Xqg3rGziMIA75pzVs9VkGCA29LEKlRpblqftz3g2BfAjq30AJIGhHYr70o93gOfvwnMMe6Mk9XRATK0vn0VigaodHMB0uHw7tf3LpJH7x2h6yt0jbH0R9GItM5LCHmFOL/vDKdMxPx2SKUIvitX1iQHd6mSOE/1gPZ9gzVRHuGVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uUVHDdxEJym8NDyFqApVQbksD709+G831EmR+xDOp7Y=; b=upueO9yL5JmQ5nG3plI3E1BvWTBTsZprlhvNgvLL/WEEojfMpZ2PfBvB3+dcBOvN7UOfOFVaynBSUAyG3dQbjbjsxpO286o7c9U2SwS3UUhqyD2VsUim80Hutua28s5Q+CppzZeEMZ0XPNAU8sBWGEI9vZoQDAN217dyxdWNWqc= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Stefano Stabellini Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q3KwCgAgAAG+VCAABfUgIAApokQgABStYCAAADsEA== Date: Fri, 2 Sep 2022 08:18:42 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> <3597a89f-98f6-d43a-4dd9-345b155e7216@xen.org> In-Reply-To: <3597a89f-98f6-d43a-4dd9-345b155e7216@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7579A6AB8DDEB74B8F2E4D5905BE385E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0b701a83-6ff5-4663-37bb-08da8cbbc409 x-ms-traffictypediagnostic: AM9PR08MB5907:EE_|AM7EUR03FT012:EE_|VI1PR08MB5309:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WmtNxs+PHmvQwyQjPxQCss8u9+cK+IZ52BwN1Ut0hwUzz0EKQnnJxn4ymrULiIMGAG1XSXC5yS/4l0Exnsc/DyQZKPU/dXQllSwBZAiq96H6unob5YxZnXBHhKPJkK32SGijJ5dCk+tYbsbTv36CiRhdL4pQjhhmvYQ6JQhfgRmFTq9ILmjaqK/dv4TnZuSWuYT2OdL3oLXRrXzaur8FoCI5/BwiDboVK0Ai5AuaJyV9Gu7BQiy8rQ721AsvrRwI0IKFQOsOeVuPH5iJK7G76DoyB02f7hgy7oPgUYyEfey2O/2YeeKyjtp8y4eLq+e3lhObRXU2TaLeERA8Mu4TJ4SrYPj41/x08T11PuhuVIl9X68It1JoUbXnGPF42c3cTVaTG+v3zaX4p8o2qhNUehrtg5hx8mqoejbps3UXExfcXP1lrchekePE7EbTT0zWXGL1xvHVDg0Na0E+cWxo7HpLsB877bgBSjN2q3JZRWbz3zzfLae3FzknVFDpCZ9AF4hCU1VFM+X02MtF7U6l36bljDUoDzWqDOppjSuadJitfplGSiFq9RiGZbYaW12YR2E8+dNQFtS6Ch/tU/vcTV9Hk2VwXI14uWjS+LD0xFsKOYww6LKNF19zZjc62nYmAYqfGfq2wdNwBemci+01Xv7HEVnbhYjKmVGfKhz4Qh9HxVoUBurS9BG1Y2Bl4d2NLvwl6IhBZIk/5H6Uyck4za3FkoePAYofP9bDz5D3GQJqtd2i3Izxtg79kyZIyNcidAMPG94uigzODgLkJDSY5A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(6506007)(7696005)(26005)(9686003)(71200400001)(186003)(52536014)(8936002)(5660300002)(33656002)(86362001)(41300700001)(478600001)(122000001)(83380400001)(38070700005)(54906003)(4326008)(8676002)(64756008)(110136005)(66446008)(66476007)(2906002)(316002)(38100700002)(66556008)(55016003)(66946007)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5907 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2abc870d-7d8a-42ad-8179-08da8cbbbf6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GrsRCWEL7dildT5uxSaxqkYSFPZ/evDkVySw25uhUi4Pval4Jbj+p6bDzyJqoGLOs1TGiS+feHjoSPmphQQx4wr4g/nI2axCNc5w/nRCEeZNU1quYZly/Hck6UVBAM5Fuk6/P/9y+oGYWvOgWyIon8G9XiX9MgdtfMaSEwMDcCCRrok9nVevBUYvxcmP4BRH7SatcufHxLkjDfZ2ELMaQW5AOi5Ii0JYvSjH3S5SJxFsaJUFKJu5ZyFDXA45+E1rOezqQXIT/zvvUkESwRiZL7rzLvPm0L74mEin80a3tkhSoJv1UtAaZTHF9JEhpRhKeDn7JzNDyxm2jquARrff7B8g3p5iNdSglDC9g/SNdfvGeFz8r9xNHEg+hRzXv0QhXWZMQKPhKi01Q0C0RTpCzFz2MqynbtSlYT477PWp44VbQna+9G6kc5sqmOy37C1TGoMUGSZWmYUW5VJ5L1FvfcBsz80q+V/EoB0oDNp3k49H/wdwcj+zoTPgnKOpFG1aFKeCC/pBL7J6H5a8bQXVJ+1Nm3T/Z5ohArbKkn2F4u/GWeq7s5xlfNjEvl37XI7oD9pY+BJ7RfPEktWDz+IncrlH2uBYcPImKzVCSrKZaOT/nXsDjBvM3XVHlA2ZcMOLssn06qAcUIjgOtZI5Vv4ej6yDIU4xeeJQ21EF4jsKyOqDQEPdUvkZbY4m7Y0z3kM3OgozTRiR0hgvP5E897hOg782WsQPhNKXRWyjjX+IiiCv7sTDLkzPPw8ltMAFLXP+nCvL0H9tP/PYbmVC7CFtQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(39860400002)(396003)(36840700001)(46966006)(40470700004)(6506007)(7696005)(47076005)(9686003)(26005)(186003)(336012)(52536014)(8936002)(5660300002)(33656002)(86362001)(41300700001)(107886003)(478600001)(36860700001)(356005)(83380400001)(81166007)(54906003)(82310400005)(4326008)(110136005)(8676002)(2906002)(316002)(40480700001)(40460700003)(82740400003)(55016003)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 08:18:50.1589 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b701a83-6ff5-4663-37bb-08da8cbbc409 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5309 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4gVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlv bi4gSSBjaGVja2VkIHRoZSBjb2RlIGFuZCBmb3VuZCB0aGUgeGVuaGVhcF8qDQo+ID4gdmFyaWFi bGVzIGFyZToNCj4gPiB4ZW5oZWFwX3ZpcnRfc3RhcnQsIHhlbmhlYXBfdmlydF9lbmQsIHhlbmhl YXBfbWZuX3N0YXJ0LA0KPiA+IHhlbmhlYXBfbWZuX2VuZCwgeGVuaGVhcF9iYXNlX3BkeC4NCj4g Pg0KPiA+IEZvciBjbGFyaWZpY2F0aW9uLCBkbyB3ZSBuZWVkIHRvIGNoYW5nZSBhbGwgb2YgdGhl bSB0byBkaXJlY3RtYXBfKj8NCj4gDQo+IEdvb2QgcXVlc3Rpb24uDQoNCjopKSkgVGhhbmtzIGZv ciB5b3VyIHBhdGllbmNlIQ0KDQo+IA0KPiA+DQo+ID4gQSBwdXJlIHJlbmFtaW5nIHNob3VsZCBi ZSBlYXN5IChhbmQgSSBndWVzcyBhbHNvIHNhZmUpLCBidXQgbWF5YmUgSSBhbQ0KPiA+IG92ZXJ0 aGlua2luZyBiZWNhdXNlIGFybTMyIGFsc28gdXNlcyB4ZW5oZWFwX3ZpcnRfZW5kLA0KPiB4ZW5o ZWFwX21mbl9zdGFydA0KPiA+IGFuZCB4ZW5oZWFwX21mbl9lbmQuIFRoZXNlIHZhcmlhYmxlcyBy ZWZlciB0byB0aGUgcmVhbCB4ZW5oZWFwLCBJIGFtIG5vdA0KPiA+IHN1cmUgcmVuYW1pbmcgdGhl c2Ugd291bGQgcmVkdWNlIHRoZSByZWFkYWJpbGl0eSBmb3IgYXJtMzIuDQo+IA0KPiBTbyBvbiBh cm0zMiwgb25seSB0aGUgeGVuaGVhcCBpcyBkaXJlY3QgbWFwcGVkIHRvZGF5LiBTbyBJIHRoaW5r IGl0DQo+IHdvdWxkIGJlIGZpbmUgdG8gc3dpdGNoIHRoZSBuYW1lIHRvICJkaXJlY3RtYXBfKiIu IEZvciBleHRyYSBjbGFyaWZ5IHdlDQo+IGNvdWxkIGFkZCBhbiBhbGlhcyBmb3IgYXJtMzIgYmV0 d2VlbiAieGVuaGVhcF8qIiBhbmQgImRpcmVjdG1hcF8qIi4NCg0KU291bmRzIGdvb2QgdG8gbWUs IEkgdGhpbmsgSSB3aWxsIHRyeSB0byBhZGQgYSBzZXBhcmF0ZSBwYXRjaCBmb3IgcHVyZWx5DQpy ZW5hbWluZyBhbGwgYWJvdmUtbWVudGlvbmVkIHZhcmlhYmxlcywgdGhlbiBhbm90aGVyIHBhdGNo IGZvciBjcmVhdGluZyB0aGUNCmFsaWFzIGZvciBhcm0zMi4gSG9wZSB5b3Ugd291bGQgZmluZSB3 aXRoIHRoaXMgcGxhbi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0K PiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:19:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:19:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397459.638045 (Exim 4.92) (envelope-from ) id 1oU1tr-0005A9-Ge; Fri, 02 Sep 2022 08:19:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397459.638045; Fri, 02 Sep 2022 08:19:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1tr-0005A2-E3; Fri, 02 Sep 2022 08:19:39 +0000 Received: by outflank-mailman (input) for mailman id 397459; Fri, 02 Sep 2022 08:19:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1tq-00058k-IU; Fri, 02 Sep 2022 08:19:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1tq-0001k8-G5; Fri, 02 Sep 2022 08:19:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1tq-0002zu-1X; Fri, 02 Sep 2022 08:19:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU1tq-0003i3-0r; Fri, 02 Sep 2022 08:19:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=W+pdr5gqq6QtOC/Jexv4BUPYSDODb27F25rA15PizY4=; b=pD7uXLFzgnRJNr1FQDbF8h/7oV jxToSrJXkaajc4VFp+REqthvdT7h16CDzKp09TdCm+ofjv5q6uV5Nm0Qs7y5bHh0bTDkLt1AAgRu3 i02alhR5my+a/4aQxmUIuMUmBKoc1YvvE1oC0MUsR2JFHEl/q/wXDR/2fcE3dCXuXLeQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172924: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 02 Sep 2022 08:19:38 +0000 flight 172924 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172924/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 172914 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 172914 blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 172914 like 172108 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 172914 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 172914 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 172914 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 172914 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 172914 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 172914 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 29 days Failing since 172384 2022-08-11 11:13:58 Z 21 days 46 attempts Testing same since 172776 2022-08-25 17:42:45 Z 7 days 17 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:21:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397472.638057 (Exim 4.92) (envelope-from ) id 1oU1vl-0006eI-25; Fri, 02 Sep 2022 08:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397472.638057; Fri, 02 Sep 2022 08:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1vk-0006eB-Vc; Fri, 02 Sep 2022 08:21:36 +0000 Received: by outflank-mailman (input) for mailman id 397472; Fri, 02 Sep 2022 08:21:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1vj-0006e3-TA for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:21:35 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41daa1db-2a98-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 10:21:35 +0200 (CEST) Received: from AM8P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:21b::15) by DB9PR08MB8649.eurprd08.prod.outlook.com (2603:10a6:10:3d3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 08:21:32 +0000 Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:21b:cafe::2b) by AM8P251CA0010.outlook.office365.com (2603:10a6:20b:21b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15 via Frontend Transport; Fri, 2 Sep 2022 08:21:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 08:21:31 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 02 Sep 2022 08:21:31 +0000 Received: from 49af4c921f07.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9AF83ECA-7E84-48A7-B3B4-8D2BB97813FE.1; Fri, 02 Sep 2022 08:21:20 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 49af4c921f07.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 08:21:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAWPR08MB9448.eurprd08.prod.outlook.com (2603:10a6:102:2e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Fri, 2 Sep 2022 08:21:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 08:21:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41daa1db-2a98-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DZayc0qLHfxYA1ojBh2N+nbVpOlrmK9kAY+4FgX2mCgoT8ypIguxhc2HE4EE2nkgrYeb7iYay45lxBxT88PE2NJzd69lcizvKN1HTlQaV/tXpoenW7Ez5h9/dxIZTuChj0+ej0Tz0YziLaE1Wp3N6u/RYw4kPD5iYxWOJRrx82Ei86UuC0AoHCbHJ/wwa68gvhPtD9Ea7WUKX9j8ixE0ROh1zzKj6cOp0RywHD9C2lm6gxMrzvVHZs1beNmyQh+2aD4XDoWYr2Ca47Lv2NFDHUC4573U0AbSi8EUTs/6WFQiSWfsEnmeVWrlcxF+cpZx60FLdzE1P+Qph8H/+stbqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74eaIOaZRNx4sj0K2zxmuD1i6ICSV9sstwT5zWN8xVA=; b=jA6snh7Kw4bO89kV+sjwjRvNGox9tQKlCb7zLZrmX3MzKV4mWF3SwY6zA/XDdyY2i901QXAHNJ5Bn+kMMk6CMhxrYYLAMjpcIH2TueJAqW1kV3O3yEICXhbOKdePVK5Qmb5ZQaiM8abbCP04APPkFLNysTASruH86vgjn2U8EHf0m3SJXAaWiQ5V7P3sk7SfujGGSEgoMcj65ea40/H/VlJ6Mm0qGq7ApsdteWgXuMMycE34cE3G/jiWGoK+xjd+nGGODKxABRqENGUQjqajUMC+u+AuXvWvK4IjK7ZKltR6Ri9pwYfZL9lAVxrJVZXaZMI6HDfeWg7CZz62CboQiQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=74eaIOaZRNx4sj0K2zxmuD1i6ICSV9sstwT5zWN8xVA=; b=c9ipWPqhddSG8ciECBy6dO8q6A/TPDtkXNymrbzSIEqXnU8TQ2x3wke5ekpYnfoOUqJ+dB6Hb2PwUUVsGXw9JWkCPvYXZ0jHAwzpKITyHyBnM2P2u7XNBs6vL3jl2ay6nmYRzNvZM4Z4X8iql0FQ0IyL525Vk5alYcydPaRu4bE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5Wz8vubfEF62PxhH2Ye0vwT5Hmrt0One6pprNPhG9zrb8RMQ3PPIoUPH2vXnRM3uReiDnibYnEk83hJr/bG0tCXydCs2VN6meDpkY20TohEDwpVuTDZHUY6MJvG23hJrO1vKQZ0YPIZwnYoqM91JiCYZommhKDgEwPbI4rt7fQXg0JdG2mAvxPM83EbHDXfE+6jH4A84nfaruqIULY3iGSwDpxzccjKqD1Ultpu/vYuFiEazCSFqWSn/oS8Bpd0CKA76BXhFvl0h1cHvzN+zwXXSXOkDkuirG7zkg7F7IJ8TF5b3l5HsEXzWw18lRKTvQ3W7vc0GtOTbR+V3x0YMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74eaIOaZRNx4sj0K2zxmuD1i6ICSV9sstwT5zWN8xVA=; b=KokWjtneyp9JQm1FYJphVr3TX/3lhV8yZMRRJFFzmxt5m/Xnz0m/BZq/uITBTkPlUIop6Xo9Z7qkjRmIzvZJ7ajHtvnwHAYHh1UeAK+pf6M40dxP2qzh434OPPj4NmuTtN0h0j1g3ecMLPEBBWMOi4r3otbB+zlfLixstBd8gw4kor8NS98VZu/cGIwJRnDfxTo14uSAv6AIjVwZRh0qptgRUPNTvFGkHBbRqTxu8ZPv0ZKZjIDeVJUksAo62OEap5Wdspw8eDnSg6YTy6kh4jPhzurCwviqBFGalwMFe2jehCXcUW/Mu+Jqfxp2McUio9VIS5lYJKnx7GcWPFdDMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=74eaIOaZRNx4sj0K2zxmuD1i6ICSV9sstwT5zWN8xVA=; b=c9ipWPqhddSG8ciECBy6dO8q6A/TPDtkXNymrbzSIEqXnU8TQ2x3wke5ekpYnfoOUqJ+dB6Hb2PwUUVsGXw9JWkCPvYXZ0jHAwzpKITyHyBnM2P2u7XNBs6vL3jl2ay6nmYRzNvZM4Z4X8iql0FQ0IyL525Vk5alYcydPaRu4bE= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Bertrand Marquis CC: Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory Thread-Topic: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory Thread-Index: AQHYt4ueuuTQX+2f5E69518db+C55q3KsXoAgAC0jPCAAG9VAIAABQZQ Date: Fri, 2 Sep 2022 08:21:19 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-2-Henry.Wang@arm.com> <9b5afd5e-ec5c-bac6-9ad0-9dd9663aa705@xen.org> <56d7a2e6-8749-601b-b163-669401bdfd67@xen.org> In-Reply-To: <56d7a2e6-8749-601b-b163-669401bdfd67@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2F4579122164E14F8D1E2423D8098DEF.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6ec4247c-f545-4791-0dc1-08da8cbc2468 x-ms-traffictypediagnostic: PAWPR08MB9448:EE_|VE1EUR03FT045:EE_|DB9PR08MB8649:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PE87ZvXx87nDVQH/aztf+zYKk2zHJAf8ZaOTL4R1FXga/UBNgaA+YADdq1hYqRKaw8/ucRL2Dp4ntuxWQ7t5RnDDleIsse7BBX0nJmq9S8suLHxRN3niuqyQJsWJhpmIyWbVpEx7hkSeWYUN9NNOrIKuA1VwE5Ylr6+VE70GI39P+HRSPhxKM2zN8gVRkh3hMo1b0BhU+4fETFooAvCqgljjNAMhGlq0mzcMkJcImpL2dXTOYHHTCYojgafhwM1oDAvzA5h4cTBLnEG99AjjXUpENhv5Achv+9GmahBgHfqDnZtBXsMO67zuQGuXOafRNFxeq4jw1KjWWiQjT8IhoMoiDV+W7Ht+lO0N7+XDhh44D2ZpfdE8gw+86DTrkjm9nasqoc+5XRgAna9vOeha8qt2425/FwkLlpUdkQ5rCRlD6ZFuTAHzn48ITRv+ZBNcK74XeHQhZFALCnurX9TqLvS4swACBTQ20GXFLXfGhfJTSr+xbKbo926NpUIBiYmAfvnZqDtKDlS+ztbQNFFX0J4+1exgpz/a4JiB3+3DqTBV0h52X72Ad8FFjZJQt2qbYXK9lSjHENVAMgt3Qn9yn5vSkLz55DjUtju+LBxeSNOi+Sao/5f3ScJLE7dK+gq4Slv4O4M+721sJiFWyxF0vOpzZxLRCY6oTmXRC96idri+0qP9B3iS1fECWuPjHRtDSMAH6HagRTjiwNlMFkWUe2RPcXeWS8t91O7fmNXpis8ioRcjoHy8zLYyP4HiewyXhDWQTRUxsFo6JbSWOOBFLA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(8936002)(9686003)(110136005)(33656002)(122000001)(38100700002)(6636002)(54906003)(26005)(71200400001)(316002)(38070700005)(52536014)(7696005)(6506007)(76116006)(8676002)(41300700001)(53546011)(2906002)(66446008)(64756008)(66476007)(478600001)(4326008)(83380400001)(86362001)(186003)(66556008)(5660300002)(55016003)(66946007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9448 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b93d9e64-12a7-4260-684b-08da8cbc1cee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JcrkC3G86GWcBb0lt+A9725TV3j1tA5fwE7IaO6o5CwT2k4+zezbUjBZROvlf9uRaQADE3i2rLOjl2KlkCIHydcuFrqFSzwmEiRDltZPb1a74oVauJlmksmpPcB7VGp7w18z1ptHSPO5/F5ZI/Pz4rF4+7ePtbAHsWDAOXkF3DFubWrpq9MYf5Adk0xizQoc+98dBZPiHcyt3hhbDMBzRlW1X7ohjnlZs7fR2soC3y0UpkLoCB1AVXPe+n7DZYZgnsFo0tvOkzI3kq65w6UlX95qEnpML+0G6LaiGcbZP2ssUAOIVCCCHHxVBp9g23UZ3RtEqLu0YnktnZvrYsnQAHq7sQtkrobAmLRYux+z0hWCGF812pk1gbTOzcLEoiEiTi2E7gCEZE7WKaf0VzXNtNOz3CrOsHcxIk/Vb9LHAamsKbsRx6g0NJEp1rCDnXYI+t7yEqLq3g7V/fpCm9bFIqudgsidfRC2AOiqKm26i0mtIMQe3ftCbfzU3Ztvkee5KH5SICXFs+v8gbzNjj71lRPHJgiKV/l+5Es0eKBxjBDKkRZdLJFb1PX+C/m1eHcnJos0BUVbBscOS6JncKt+PC799SMlcJRgYpgRpgkuq6XBZwK7+sN0PyUddZiqYk8N8IugB/yryJ0fQ39c74n5aLOuYOFLWvwgs7I0frjBjC46IkGEwW97bPMpvNAx5JW2/NE2a11bImf50FDxC4WdNr13y6vBe7Nx/shsLY/JMmUEL8dRCRW+p2YAUCr2FO8Qw2S6cRIv3eFv9xGI8rUkkA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(396003)(376002)(40470700004)(36840700001)(46966006)(33656002)(82310400005)(86362001)(53546011)(82740400003)(6506007)(7696005)(9686003)(26005)(83380400001)(47076005)(55016003)(186003)(36860700001)(40480700001)(336012)(478600001)(5660300002)(52536014)(8936002)(54906003)(6636002)(110136005)(316002)(40460700003)(4326008)(8676002)(70206006)(70586007)(356005)(2906002)(81166007)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 08:21:31.7635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ec4247c-f545-4791-0dc1-08da8cbc2468 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8649 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggMS8yXSBkb2NzLCB4ZW4vYXJtOiBJbnRyb2R1Y2UgcmVzZXJ2ZWQgaGVhcCBtZW1v cnkNCj4gDQo+IEhpIEhlbnJ5LA0KPiANCj4gT24gMDIvMDkvMjAyMiAwMjoyOCwgSGVucnkgV2Fu ZyB3cm90ZToNCj4gPj4gVGhpcyBpcyB0ZWNobmljYWxseSBhIGNoYW5nZSBpbiBiZWhhdmlvciBm b3IgWGVuICh3ZSB3b3VsZCBwYW5pYyByYXRoZXINCj4gPj4gdGhhbiBjb250aW51ZSkuIEkgYW0g aGFwcHkgd2l0aCB0aGUgcHJvcG9zYWwuIEhvd2V2ZXIsIHRoaXMgZG9lc24ndCBzZWVtDQo+ID4+ IHRvIGJlIGV4cGxhaW5lZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+ID4+DQo+ID4+IFRoYXQg c2FpZCwgSSB0aGluayB0aGlzIHNob3VsZCBiZSBzcGxpdCBpbiBhIHNlcGFyYXRlIHBhdGNoIGFs b25nIHdpdGgNCj4gPj4gdGhlIG9uZXMgYmVsb3cgKGluY2x1ZGluZyB0aGUgcHJvdG90eXBlIGNo YW5nZXMpLg0KPiA+DQo+ID4gQWNjb3JkaW5nIHRvIE1pY2hhbCdzIGNvbW1lbnQsIEkndmUgcmVt b3ZlZCB0aGUgcmV0dXJuIHR5cGUgYW5kIGZ1bmN0aW9uDQo+ID4gcHJvdG90eXBlIGNoYW5nZSBp biBteSBsb2NhbCB2Mi4gU28gdGhpcyBwYXRjaCBpdHNlbGYgaXMgZmluZS4gTXkgcXVlc3Rpb24N Cj4gbm93DQo+ID4gd291bGQgYmUsIGRvIG1haW50YWluZXJzIHRoaW5rIHRoaXMgY2hhbmdlIG9m IGJlaGF2aW9yIHdpdGggcHJvY2Vzc2luZyB0aGUNCj4gPiBjaG9zZW4gbm9kZSBiZSBoZWxwZnVs Pw0KPiANCj4gWWVzLiBJIHRoaW5rIGl0IGlzIHNhbmVyIHRvIHN0b3AgYm9vdGluZyBlYXJseSBy YXRoZXIgdGhhbiBzZWVuIHJhbmRvbQ0KPiBiZWhhdmlvciBhZnRlcndhcmRzLg0KDQpDb29sLCBJ IHdpbGwgdGhlbiBhZGQgdGhlIHBhdGNoIHRvIHRoaXMgc2VyaWVzLg0KDQo+IA0KPiA+IERvIHdl IHByZWZlciBhbiBpbnN0YW50IHBhbmljIG9yIGN1cnJlbnQgYmVoYXZpb3I/DQo+IA0KPiBJIHRo aW5rIHdlIHNob3VsZCBsZWF2ZSB0aGF0IHVwIHRvIHRoZSBjYWxsZXIuIFRvZGF5LCB0aGlzIGlz IGEgcGFuaWMoKQ0KPiBidXQgd2UgbWF5IGRlY2lkZSBkaWZmZXJlbnRseSBpbiB0aGUgZnV0dXJl Lg0KDQpBZ3JlZWQuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4g DQo+IC0tDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 02 08:21:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 08:21:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397474.638068 (Exim 4.92) (envelope-from ) id 1oU1vx-0006zd-Ak; Fri, 02 Sep 2022 08:21:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397474.638068; Fri, 02 Sep 2022 08:21:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1vx-0006zW-7r; Fri, 02 Sep 2022 08:21:49 +0000 Received: by outflank-mailman (input) for mailman id 397474; Fri, 02 Sep 2022 08:21:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU1vv-0006e3-8z for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 08:21:47 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 476cd04a-2a98-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 10:21:46 +0200 (CEST) Received: by mail-pj1-x102d.google.com with SMTP id m10-20020a17090a730a00b001fa986fd8eeso4856201pjk.0; Fri, 02 Sep 2022 01:21:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 476cd04a-2a98-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=h9T3pk4GTDCw9FXAZGEOSHbembkbx8obAhaOxGlfp6I=; b=LITsmZNARCXxFT4TbsvrTZmZTdp4WSHLEKoV5Drd17BqN7uO/w+uHRHQTD7nJXcmEB aX0k7TkTeeJxmg86oOFmdUcOUPoSoHiraXoel/yfW9krFxUc4aQCD67SEqH7qIk3PSMY +4nNO4QNsmf7Tmv/iG+T/tof3Fw+qpuJ8gn5OkGgj2/MP5cIJZrTTvMUmAUtxy+wljxj ob8lpzmu1yBrJbSGHmlW/wH0Fj+cZTH61Bv8psBBsHzsiq6luu6MY9hI/m8oZtrHMfv0 Vwf8fHSWH3er0lPPrxLD9kU9SblD7EsqMzjvoTJ+jBpYAZgVnGkHHTnTYpMt1NgHMHO7 Q7Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=h9T3pk4GTDCw9FXAZGEOSHbembkbx8obAhaOxGlfp6I=; b=XC7oRbYunsbvSs/lEl7FIh3aTTq/WC4RuvwaFXCbonIIiN0SkNQSjwnzryeS83I8LE L8yZUal3tSi574ZD13PAH/1kkljzoFS4Etpwp19OQvXJcdUyWTqJ3WGJ9/9VGmVIx2cZ G4k0K+SqEbAx4Arv/NI4ZCXy4++EdFjA1gWIpj3Go6N3Vp+Cu4MeuLIRIBob6ywjiLZB eqO6Jz08xM4WJFBV4IwmRzlqPRAPrpMI82UAy5xjnoH94y/xvp0/qcRpJVK8MBN9VV6W wK1Px+gU3pSFjzHZwuZ317gOrq+yodKj9UIJfSM94baGPFZCscRXssTwHOaHt+dk6rvW ropg== X-Gm-Message-State: ACgBeo0fS/IocJU8k7zX4LJfs/vr1CNof/r4vV8CzMYzX/d3uSi5JLxS Hw5TByrDCiw3oUTO+3t1VMYUEoyLYfNv/I1N1Ps= X-Google-Smtp-Source: AA6agR5O36MIo0q4j/q9AJUj5ZyoVfCiBnac2fcRNhe7gTmFlsB/mU3nDzR4IAEHGxpzvwn8dKTbobrJCXZS7uM530k= X-Received: by 2002:a17:902:e80e:b0:16f:14ea:897b with SMTP id u14-20020a170902e80e00b0016f14ea897bmr33803088plg.6.1662106903328; Fri, 02 Sep 2022 01:21:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Oleksandr Tyshchenko Date: Fri, 2 Sep 2022 11:21:31 +0300 Message-ID: Subject: Re: Enable audio virtualization in Xen To: "SHARMA, JYOTIRMOY" Cc: "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "Stabellini, Stefano" , "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" Content-Type: multipart/alternative; boundary="0000000000008d3af905e7ad6b84" --0000000000008d3af905e7ad6b84 Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 11:58 AM SHARMA, JYOTIRMOY wrote: > [AMD Official Use Only - General] > > Hi all, > Hello Jyotirmoy. [sorry for the possible format issues] > > > Forgot to mention that I am able to play audio from HVM guest with Pulse > Audio as back end. > good. > Here is the corresponding HVM configuration: > > > > vsnd = [[ 'card, backend=Domain-0, buffer-size=65536, short-name=VCard, > long-name=Virtual sound card, sample-rates=44100, sample-formats=s16_le', > 'pcm, name=dev1', 'stream, unique-id=pulse, type=P' ]] > > > > I have used xen front end and snd_be (along with libxenbe) as back end as > suggested by Christopher earlier in this thread. > > > > Only when I change unique-id=alsa, audio is not working from HVM guest. > > > > If anyone has tried ALSA back end (instead of PA), please let me know what > I am missing. > We use snd_be over pulse and it works fine. I am not too familiar with all that sound's internals. But I would suggest looking at the following thread where Oleksandr Grytsov (the author of the snd_be) mentioned the need of HW parameters matching for alsa [1]. I made an experiment with alsa (however I am not 100% sure whether it is correct), nevertheless details are below. I changed guest config to use alsa: vsnd = [[ 'card, backend=DomD, buffer-size=65536, short-name=VCard, long-name=Virtual sound card, sample-rates=8000;11025;16000;22050;32000;44100;48000, sample-formats=s16_le', 'pcm, name=dev1', 'stream, unique-id=alsa, type=P' ]] And checked that snd_be started using alsa: 03.07.22 03:37:17.185 | SndFrontend | DBG - Parse stream id: alsa 03.07.22 03:37:17.186 | SndFrontend | DBG - Create pcm device, type: ALSA, device: , propName: , propValue: ... With that command running in DomU I heard the audio in headphones: root@salvator-x-h3-4x2g-xt-domu:~# cat /dev/urandom | aplay -f S16_LE -c 2 -D hw:0,0 Playing raw data 'stdin' : Signed 16 bit Little Endian, Rate 8000 Hz, Stereo This is the output of "aplay -l" in both domains just in case: root@salvator-x-h3-4x2g-xt-domd:~# aplay -l **** List of PLAYBACK Hardware Devices **** card 0: rcarsound [rcar-sound], device 0: rsnd-dai.0-ak4613-hifi ak4613-hifi-0 [] Subdevices: 0/1 Subdevice #0: subdevice #0 root@salvator-x-h3-4x2g-xt-domu:~# aplay -l **** List of PLAYBACK Hardware Devices **** card 0: vsnd [], device 0: dev1 [Virtual card PCM] Subdevices: 1/1 Subdevice #0: subdevice #0 Please check your HW params as suggested at [1]. [1] https://lore.kernel.org/xen-devel/CACvf2oW7gHCLdkqYi8w1s7-FBuX8zcAwAnfZa07XhVg-ioaXaQ@mail.gmail.com/ > > > Regards, > > Jyotirmoy > > > -- Regards, Oleksandr Tyshchenko --0000000000008d3af905e7ad6b84 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 1, 2022 at 11:58 AM SHARM= A, JYOTIRMOY <JYOTIRMOY.SHARMA@amd.com> wrote:

[AMD Official Use Only - General]

Hi all,


<= /div>
Hello=C2=A0Jyotirmoy.

[sorry for the pos= sible format issues]

=C2=A0

=C2=A0

Forgot to mention that I am able to play audio from = HVM guest with Pulse Audio as back end.

<= div>=C2=A0

good.

=C2=A0

Here is the corresponding HVM configuration= :

=C2=A0

vsnd =3D [[ 'card, backend=3DDomain-0, buffer-si= ze=3D65536, short-name=3DVCard, long-name=3DVirtual sound card, sample-rate= s=3D44100, sample-formats=3Ds16_le', 'pcm, name=3Ddev1', 's= tream, unique-id=3Dpulse, type=3DP' ]]

=C2=A0

I have used xen front end and snd_be (along with lib= xenbe) as back end as suggested by Christopher earlier in this thread.

=C2=A0

Only when I change unique-id=3Dalsa, audio is not wo= rking from HVM guest.

=C2=A0

If anyone has tried ALSA back end (instead of PA), p= lease let me know what I am missing.

=C2=A0

We use snd_be over pulse and it works fine= . I am not too familiar with all that sound's internals. But I would su= ggest looking at the following thread where Oleksandr Grytsov (the author o= f the snd_be) mentioned the need of HW parameters matching for alsa [1].

I made an experiment with alsa (however I am not 100% sure whet= her it is correct), nevertheless details are below.

I changed= guest config to use alsa:
vsnd =3D [[ 'card, backend=3DDomD, buffer= -size=3D65536, short-name=3DVCard, long-name=3DVirtual sound card, sample-r= ates=3D8000;11025;16000;22050;32000;44100;48000, sample-formats=3Ds16_le= 9;,
=C2=A0 =C2=A0 =C2=A0'pcm, name=3Ddev1', 'stream, unique-= id=3Dalsa, type=3DP'
=C2=A0 =C2=A0 ]]

And checked that= snd_be started using alsa:
03.07.22 03:37:17.185 | SndFrontend =C2=A0| = DBG - Parse stream id: alsa
03.07.22 03:37:17.186 | SndFrontend =C2=A0| = DBG - Create pcm device, type: ALSA, device: , propName: , propValue:
..= .

With that command running in DomU I heard the audio in head= phones:
root@salvator-x-h3-4x2g-xt-domu:~# cat /dev/urandom | aplay -f S= 16_LE -c 2 -D hw:0,0
Playing raw data 'stdin' : Signed 16 bit Li= ttle Endian, Rate 8000 Hz, Stereo

This is the output of "= ;aplay -l" in both domains just in case:
root@salvator-x-h3-4x2g-xt= -domd:~# aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0:= rcarsound [rcar-sound], device 0: rsnd-dai.0-ak4613-hifi ak4613-hifi-0 []<= br>=C2=A0Subdevices: 0/1
=C2=A0Subdevice #0: subdevice #0
root= @salvator-x-h3-4x2g-xt-domu:~# aplay -l
**** List of PLAYBACK Hardware D= evices ****
card 0: vsnd [], device 0: dev1 [Virtual card PCM]
=C2=A0= Subdevices: 1/1
=C2=A0 Subdevice #0: subdevice #0

= =C2=A0

=C2=A0

Regards,

Jyotirmoy

=C2=A0



--
Regards,

Oleksandr Tyshchenk= o
--0000000000008d3af905e7ad6b84-- From xen-devel-bounces@lists.xenproject.org Fri Sep 02 09:41:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 09:41:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397489.638079 (Exim 4.92) (envelope-from ) id 1oU3Ak-0006i0-6V; Fri, 02 Sep 2022 09:41:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397489.638079; Fri, 02 Sep 2022 09:41:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Ak-0006ht-3L; Fri, 02 Sep 2022 09:41:10 +0000 Received: by outflank-mailman (input) for mailman id 397489; Fri, 02 Sep 2022 09:41:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Ai-0006hj-P2; Fri, 02 Sep 2022 09:41:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Ai-00037X-JT; Fri, 02 Sep 2022 09:41:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Ai-00018h-1u; Fri, 02 Sep 2022 09:41:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU3Ai-0002Fa-1O; Fri, 02 Sep 2022 09:41:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qv5BQUlPC6ynKZbhC46iDwY4JTbUtzjCBqO+j76ogJU=; b=BD/2onUASjbKFneRTeyys0BN+k +xKuuAOWu7dupNP2yNtUbTWV9kSpEiXyPlXCqUp8Cqv01UIruifkqRZ8eCQJhb8PW+UX3dIUgQwt1 grKn+DKd/wdp0l7FUsR4yUGHW4xFMbdmNkRbv6DlPkFlVvjEiCm6y9I2fonDKWuGmpLE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 172930: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c8b796aba31b2c97a1a56867062b3bdd0d81923f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 02 Sep 2022 09:41:08 +0000 flight 172930 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172930/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c8b796aba31b2c97a1a56867062b3bdd0d81923f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 784 days Failing since 151818 2020-07-11 04:18:52 Z 783 days 765 attempts Testing same since 172930 2022-09-02 04:20:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121804 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 09:50:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 09:50:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397500.638089 (Exim 4.92) (envelope-from ) id 1oU3Jc-0008Fg-7n; Fri, 02 Sep 2022 09:50:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397500.638089; Fri, 02 Sep 2022 09:50:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Jc-0008FZ-56; Fri, 02 Sep 2022 09:50:20 +0000 Received: by outflank-mailman (input) for mailman id 397500; Fri, 02 Sep 2022 09:50:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Ja-0008FN-Lc for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 09:50:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a602b908-2aa4-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 11:50:17 +0200 (CEST) Received: from AM6P193CA0084.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::25) by GV2PR08MB8342.eurprd08.prod.outlook.com (2603:10a6:150:c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 09:50:10 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::82) by AM6P193CA0084.outlook.office365.com (2603:10a6:209:88::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 09:50:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 09:50:08 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Fri, 02 Sep 2022 09:50:08 +0000 Received: from f3f40e4b11d2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4D3E79C4-C943-49C2-B503-86D6CDBA9001.1; Fri, 02 Sep 2022 09:49:57 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f3f40e4b11d2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 09:49:57 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR08MB5374.eurprd08.prod.outlook.com (2603:10a6:803:12f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 09:49:55 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::5d27:806b:5d1f:f63]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::5d27:806b:5d1f:f63%2]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 09:49:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a602b908-2aa4-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=P47I17OPDL58YFHI/TIjObbz8KbIGr8gVbQrN4Nuw4rRAZbqLtiWIEo9g92DyojJRlC8fsEyw0btVPBhAaYW5qIExtKfp9MusWRCMqq7yv6utjyXz2teQ+a73fOjNLh2KwWGjjU/f9bvhsiBAlec2UVt3OYHEAw9mb0Y877hH/sBpfDHSCYJyKoLqqL5LbED369vIGYtBnGDavBVdhn6E0QdBfbzrrEbY7su8FCOgVnT6zpi0q3QNlKU19yp+qAccbeGNBSKb/2HAlThfaIS05oHjJRYnuIzneNVk9yOTdjskRqIp4CVwyLYPUw6JGKitFmNmOHyV17ec6S3wLWFEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kN00dsw7Q1aPXzVxr6unwTeTGB8aeACyZXIErFn7VtU=; b=BuaT8TKLpmuUOXr21k+ucVEwwfz3L83fogcifDi4+RX1wJ+9EXCdrhJcXAYwUfd7YzpCVxGGROFSFkOB0gLwOwh7I1GwxqNOhohUj56Oa4tOuWJq/gTcLeMDSNQNgfzZgBHQZ5yqSNwom69bJELPmEXv6EYX5cJ1pKYj882JcruCTJMJSHEu8jGLitKabecHq3NNjjIGACHpKH7yPbTPzXuIDmlIWbnyy7fg/lbPNLq4xHrRvl9pvMIzOvf9+ALTPaU/1FTfGnp2ebHdwkbhmhqDRRDAhhUt0WsT/iuqQYHH8CjyzDiOukQ+49+EK7K8TdNV8HoAVXy97ov/+IW5iQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kN00dsw7Q1aPXzVxr6unwTeTGB8aeACyZXIErFn7VtU=; b=OKlglImA/US8x7ku6dERxlzkf8swgg1gDVKPuYkP2wDOp7eLR9p2h1Pneazgp61oRA6cH1+BEBCYbrsG1HboYdCUFMUZWMP837t1S8UG+gSi6VzaocJSpZZeYINRPWof47maIBquBNXzwoCFacoSlaqOmdUqzuT5+WVsuIlH0rw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0WA821INjsCm6TSSk+ZPx1eQUgRDK0N82XTWUh7UKqZY3lPUzax4TR96AvIsJLaHo0H6DPnMbslkKtg3BxAb1j+KGtFfRm1DIg9zROfb+Bj39uajUSONQYWg5IktWLqGieMmfTetIQeJXdzLm1Ntih7lLTb2YFHalz2V48DGXoi58aBIS3Kk315jEwx9OoPI+p95IpatbGpGgBZIR+mXvPo0X7vi37J3s/LhDip4s1u358cFM9BroKupycrpcbRZvJ1Q+TrsjM6/DvUnRwQf07+In+y3RncJ4gFBtQwda8WCHLIej3iorYHz44wzJ4Vw7PCsvFq2wRKPPGN6fwd9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kN00dsw7Q1aPXzVxr6unwTeTGB8aeACyZXIErFn7VtU=; b=ilBp2Hb5dcRyj8uiaNp5ev8WnU6F6RFcow21uMF+8dNYeViTC9AMYvRIWVdIoea9zHCGhW7e5otwEyr6vwgjSBC7dWUkIZW7mOe9vOZX+MMoxsgLfnG9WsKJL4Lco6PclVODLKcKEqqYU5NlYLyDZJt7QYfkRXuvomakRpbFf9XkFzQvwonoj8xKvP1krTOmQjKgmDkY6AcM8strDyUGoAaGdAMv+zPnQx7IUDSOXGjFbBNZJmHX9RQ+012XitD3kMACHogRXVQpVlIYXnuQfRys7OaQAVbz87NWbzkG9pC2ULV7cvSsayiKLdeuBYCVPBqktguyZz725ShktV1LeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kN00dsw7Q1aPXzVxr6unwTeTGB8aeACyZXIErFn7VtU=; b=OKlglImA/US8x7ku6dERxlzkf8swgg1gDVKPuYkP2wDOp7eLR9p2h1Pneazgp61oRA6cH1+BEBCYbrsG1HboYdCUFMUZWMP837t1S8UG+gSi6VzaocJSpZZeYINRPWof47maIBquBNXzwoCFacoSlaqOmdUqzuT5+WVsuIlH0rw= From: Wei Chen To: Julien Grall , Stefano Stabellini CC: Henry Wang , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYt4ugxTCtO4LgrkGJKD3tY8acia3KwCgAgAAJ8YCAABHIAIAABy8AgACKuYCAAA6DsIAABhiwgABTyoCAABulwA== Date: Fri, 2 Sep 2022 09:49:55 +0000 Message-ID: References: <20220824073127.16762-1-Henry.Wang@arm.com> <20220824073127.16762-3-Henry.Wang@arm.com> <50bc7ce9-dc98-127b-d0db-40bf82929fc7@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8A1F362F7119C74FB5DDD455F7C4772F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7095f473-fb0c-4c7c-3bfa-08da8cc8859c x-ms-traffictypediagnostic: VI1PR08MB5374:EE_|AM7EUR03FT036:EE_|GV2PR08MB8342:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lW2zGU1iiSNTcY6B2myIksvB76n8LNsx3O59g+Pw/zj/Qz5tQkjgWwgSd9FIOSthmuIyvrLoWSfNX3TaUT5xUa5dirkqWYf1pWZBHjdnIXf/G2jiebPVWf8XV3uQ2Y/d4EkEt8sfr2i3NxYnQa0Syh59YXziX7fJ8IAdERarOAfVnQMLm0fBXiUEm+cnqY3+sTkqrd9wE+GOuqeWuqGgrven0JFCHez3wg9JyH1cF+BPz5LqhXch1zcx8EvDuboTWYEcjtLXsxbarECq9RyaIPku/qT/K1E6nCBcvA5+D7R+ijLtGgICPmqUBv7WaH9Tc62YU5FSirEXIavbsDf5YZRdJ4AuPbziX580vC3syoX1UvLggmhq68Z5orWxNfuwssTjpKBxw8I5rEiBpzKwvNOke00vFHV4WjYtMlmuyydt24psgeCAKtLh/skT88bSKrJP9L29SVPKQqXyoJWmRVVgquJVS5UAhxbjLLjw6Xm12nM2/HPLp7SdBEvtvN+0MLRvNRiD+m9xJ7faoIC+6Omwz5XJTzWCx0Za6l6TT4Llyvh4mRMPAwoo1v+n2uObhf8TrYlO++t9FY4rY91ncZZWUqXAz0SJ5ZCsirJg8ZnNUyJFdUnZ8O0Z4NyrwbCHzGIkXmzf4n96WJv31ua7lifrdguJ7+5kt79v/w+nHKW3yY9nWgYs4uXp0ICXrzh9aGdrdHpgyT3JVCXnEL/aY92RGEgsmMGm7QG4Gk5NoJCHPekSYzISlMCvmlnC2nESzW6FebFTnVWb+gsvueoszQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(122000001)(38070700005)(86362001)(316002)(38100700002)(2906002)(54906003)(8936002)(110136005)(52536014)(66556008)(66446008)(76116006)(8676002)(64756008)(4326008)(5660300002)(66476007)(66946007)(71200400001)(83380400001)(478600001)(186003)(53546011)(41300700001)(7696005)(6506007)(9686003)(55016003)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5374 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f82eb9ae-5279-4747-aa7b-08da8cc87d72 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UPL3wcRJAg/9bTsgMLRBXRszCIvu1xbtZ3v+FqY6qGx0fT65uFScR3S1nbf+RUD1vPqTF6VUYFUcnZs3P+qjEKDjqrvcnOUKhoiPIyh0m4hLRTVyDtv+bEpQ0R3tFPV5guBH3x3t4ojrmumsYugN6Vul9tmHqZd2KgJe3+xofXy3i0kKygzhwJK2DoIKkLOJ6dO8DF5bLMUqNBXQLn1BdoQTg5oh5pLIh2roJa53ZrTX8/gl3NSIUk39ljSzz6mckR7zxrm1KMSZo7qkJQKPu3T8aJ0RCz9n1WOuYFOa8QKqDfk1KznrbHORtEEvXqIbu8RMnbw9L/HQmdEB0/ob8MK/A4+M8J3z5tnCMVxXmAIcOvFBc/wBFKiBMAKmMsmkbadMwQ9Nfd4DzQwgfpziWLmfOodKXQEgIoSItBlCgz4SwDJTch5oH5/6F3/UauluNzg94LV3W7QifnjJ3TvAQmpMiLpOP7sdj11nUbwibzJF/47QaCh6JRyoW37iglVMtSKyHYFv9iTK0A3W1I2Mu6xDD4ioUe4/BvyYiRyQaXqZfndKe3OX8ep6Vqm3QkvnN/bIy5FSRo8uARbdTeaPsBUD/Van9NNG7YaRpvlotXf1f1XqXxT8Y6e4kiSbYVBF+/HYazUGVkQW+Bb3RTAoTLxoabiY40ilJk7xipzPMbdxXy9gMDKx5sVOcooBARUmhO1fzq/REoUb18BInjTtOVBCNLPNtjNBNyQTnas5KNy3qr3NWr+Y1Cxvhl4lWLr1WEqGi30rGfIzV8L4VewW8A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(36840700001)(46966006)(40470700004)(2906002)(82740400003)(107886003)(52536014)(8936002)(86362001)(54906003)(110136005)(40460700003)(81166007)(356005)(47076005)(336012)(316002)(186003)(26005)(70206006)(70586007)(8676002)(6506007)(7696005)(53546011)(9686003)(36860700001)(478600001)(82310400005)(4326008)(5660300002)(41300700001)(55016003)(83380400001)(40480700001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 09:50:08.8834 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7095f473-fb0c-4c7c-3bfa-08da8cc8859c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8342 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQ55pyIMuaXpSAxNjowNQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4g PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENjOiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFy bS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+IEJlcnRyYW5kIE1hcnF1 aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xv ZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAyLzJdIHhlbi9h cm06IEhhbmRsZSByZXNlcnZlZCBoZWFwIHBhZ2VzIGluIGJvb3QgYW5kDQo+IGhlYXAgYWxsb2Nh dG9yDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBPbiAwMi8wOS8yMDIyIDA0OjA3LCBXZWkgQ2hlbiB3 cm90ZToNCj4gPg0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZy b206IFhlbi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9u IEJlaGFsZiBPZg0KPiBXZWkNCj4gPj4gQ2hlbg0KPiA+PiBTZW50OiAyMDIy5bm0OeaciDLml6Ug MTE6MDMNCj4gPj4gVG86IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y Zz47IEp1bGllbiBHcmFsbA0KPiA+PiA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IENjOiBIZW5yeSBX YW5nIDxIZW5yeS5XYW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7 DQo+ID4+IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9k eW15ciBCYWJjaHVrDQo+ID4+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gPj4gU3Vi amVjdDogUkU6IFtQQVRDSCAyLzJdIHhlbi9hcm06IEhhbmRsZSByZXNlcnZlZCBoZWFwIHBhZ2Vz IGluIGJvb3QNCj4gYW5kDQo+ID4+IGhlYXAgYWxsb2NhdG9yDQo+ID4+DQo+ID4+IEhpIEp1bGll biBhbmQgU3RlZmFubywNCj4gPj4NCj4gPj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ ID4+PiBGcm9tOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+ ID4+PiBTZW50OiAyMDIy5bm0OeaciDLml6UgOTo1MQ0KPiA+Pj4gVG86IEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+DQo+ID4+PiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGlu aUBrZXJuZWwub3JnPjsgSGVucnkgV2FuZw0KPiA+Pj4gPEhlbnJ5LldhbmdAYXJtLmNvbT47IHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgQmVydHJhbmQgTWFycXVpcw0KPiA+Pj4gPEJl cnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgVm9s b2R5bXlyDQo+ID4+IEJhYmNodWsNCj4gPj4+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4N Cj4gPj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMi8yXSB4ZW4vYXJtOiBIYW5kbGUgcmVzZXJ2ZWQg aGVhcCBwYWdlcyBpbiBib290DQo+IGFuZA0KPiA+Pj4gaGVhcCBhbGxvY2F0b3INCj4gPj4+DQo+ ID4+PiBPbiBUaHUsIDEgU2VwIDIwMjIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gPj4+PiBIaSBT dGVmYW5vLA0KPiA+Pj4NCj4gPj4NCj4gPj4+IEluIGFueSBjYXNlLCBJIHRoaW5rIHdlIGNhbiBw b3N0cG9uZSB0byBhZnRlciB0aGUgcmVsZWFzZS4NCj4gPg0KPiA+IE1heWJlIHdlIGNhbiBhZGQg c29tZSBub3RlcyB0byBzYXkgdGhhdCB0aGlzIGZlYXR1cmUgaXMgc3RpbGwNCj4gPiBleHBlcmlt ZW50YWwgaW4gRUZJICsgRFRTIGJvb3Q/DQo+IA0KPiBXaHkgRUZJICsgRFRTIG9ubHk/IFJlZ2Fy ZGxlc3MgdGhlIGRpc2N1c3Npb24gYWJvdXQgaG93IHRvIHByb3Blcmx5DQo+IGNoZWNraW5nIHRo ZSByZWdpb24sIEkgdGhpbmsgdGhpcyB3YW50cyB0byBiZSBhIHRlY2ggcHJldmlldy4NCj4gDQoN CkkgaGFkIHRob3VnaHQgc29tZXRoaW5nIGxpa2UgdWJvb3QgKyBkdHMgd2lsbCBub3QgaGF2ZSBy ZXNlcnZlZCBtZW1vcnkNCnJlZ2lvbnMgbGlrZSBFRkkgcnVudGltZSBzZXJ2aWNlcy4gQnV0IEkg Zm9yZ290IHVib290IGFsc28gd2lsbCBoYXZlDQpzb21lIGFkZHJlc3MgdG8gbG9hZCBYZW4gYW5k IERUQi4gSW4gdGhpcyBjYXNlLCBYZW4gc3RpbGwgbmVlZCB0byBjaGVjaw0KcmVsb2NhdGlvbiBh ZGRyZXNzZXMgd2l0aCBzdGF0aWMgaGVhcC4gU28geW91J3JlIHJpZ2h0LCBJIGFncmVlIHdpdGgg eW91Lg0KDQpDaGVlcnMsDQpXZWkgQ2hlbi4NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxp ZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 02 09:53:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 09:53:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397507.638101 (Exim 4.92) (envelope-from ) id 1oU3Mx-0000RM-PV; Fri, 02 Sep 2022 09:53:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397507.638101; Fri, 02 Sep 2022 09:53:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Mx-0000RF-Kp; Fri, 02 Sep 2022 09:53:47 +0000 Received: by outflank-mailman (input) for mailman id 397507; Fri, 02 Sep 2022 09:53:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU3Mv-0000R2-9D for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 09:53:46 +0000 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 205e6acc-2aa5-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 11:53:43 +0200 (CEST) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-pdx-2b-1f9d5b26.us-west-2.amazon.com) ([10.25.36.210]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 09:53:26 +0000 Received: from EX13D08EUB002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2b-1f9d5b26.us-west-2.amazon.com (Postfix) with ESMTPS id E124945026; Fri, 2 Sep 2022 09:53:25 +0000 (UTC) Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D08EUB002.ant.amazon.com (10.43.166.232) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Fri, 2 Sep 2022 09:53:25 +0000 Received: from dev-dsk-ptyadav-1c-613f0921.eu-west-1.amazon.com (10.15.8.155) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.38 via Frontend Transport; Fri, 2 Sep 2022 09:53:23 +0000 Received: by dev-dsk-ptyadav-1c-613f0921.eu-west-1.amazon.com (Postfix, from userid 23027615) id 65C212599D; Fri, 2 Sep 2022 09:53:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 205e6acc-2aa5-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1662112424; x=1693648424; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RYkyDTlCTvMrlOLx7kj+NLb70k5rmvCjtCTCfEk9Kmg=; b=WpdcwnkBzstQNIThJ4/X50SwmghJPlvLG50/DpWGw6cf8VPG7q4Igofh Iyk9D67vV6bAxqpo20fcjFgx+iSdAH44BeG1A/N4DUk55zq6CvLPI7rXg Bkx/mb6/PWEfbgLN0X7gTxaEkIKfV3W9B73xJ2w0jakTN9qLuEwWYMEds 4=; X-IronPort-AV: E=Sophos;i="5.93,283,1654560000"; d="scan'208";a="255514482" Date: Fri, 2 Sep 2022 09:53:22 +0000 From: Pratyush Yadav To: SeongJae Park CC: , , , , , , , , Subject: Re: [PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested Message-ID: <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> References: <20220831165824.94815-1-sj@kernel.org> <20220831165824.94815-2-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220831165824.94815-2-sj@kernel.org> Precedence: Bulk On 31/08/22 04:58PM, SeongJae Park wrote: > The advertisement of the persistent grants feature (writing > 'feature-persistent' to xenbus) should mean not the decision for using > the feature but only the availability of the feature. However, commit > aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent > grants") made a field of blkback, which was a place for saving only the > negotiation result, to be used for yet another purpose: caching of the > 'feature_persistent' parameter value. As a result, the advertisement, > which should follow only the parameter value, becomes inconsistent. > > This commit fixes the misuse of the semantic by making blkback saves the > parameter value in a separate place and advertises the support based on > only the saved value. > > Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") > Cc: # 5.10.x > Suggested-by: Juergen Gross > Signed-off-by: SeongJae Park > --- > drivers/block/xen-blkback/common.h | 3 +++ > drivers/block/xen-blkback/xenbus.c | 6 ++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h > index bda5c815e441..a28473470e66 100644 > --- a/drivers/block/xen-blkback/common.h > +++ b/drivers/block/xen-blkback/common.h > @@ -226,6 +226,9 @@ struct xen_vbd { > sector_t size; > unsigned int flush_support:1; > unsigned int discard_secure:1; > + /* Connect-time cached feature_persistent parameter value */ > + unsigned int feature_gnt_persistent_parm:1; Continuing over from the previous version: > > If feature_gnt_persistent_parm is always going to be equal to > > feature_persistent, then why introduce it at all? Why not just use > > feature_persistent directly? This way you avoid adding an extra flag > > whose purpose is not immediately clear, and you also avoid all the > > mess with setting this flag at the right time. > > Mainly because the parameter should read twice (once for > advertisement, and once later just before the negotitation, for > checking if we advertised or not), and the user might change the > parameter value between the two reads. > > For the detailed available sequence of the race, you could refer to the > prior conversation[1]. > > [1] https://lore.kernel.org/linux-block/20200922111259.GJ19254@Air-de-Roger/ Okay, I see. Thanks for the pointer. But still, I think it would be better to not maintain two copies of the value. How about doing: blkif->vbd.feature_gnt_persistent = xenbus_read_unsigned(dev->nodename, "feature-persistent", 0) && xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); This makes it quite clear that we only enable persistent grants if _both_ ends support it. We can do the same for blkfront. > + /* Persistent grants feature negotiation result */ > unsigned int feature_gnt_persistent:1; > unsigned int overflow_max_grants:1; > }; > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index ee7ad2fb432d..c0227dfa4688 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -907,7 +907,7 @@ static void connect(struct backend_info *be) > xen_blkbk_barrier(xbt, be, be->blkif->vbd.flush_support); > > err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "%u", > - be->blkif->vbd.feature_gnt_persistent); > + be->blkif->vbd.feature_gnt_persistent_parm); > if (err) { > xenbus_dev_fatal(dev, err, "writing %s/feature-persistent", > dev->nodename); > @@ -1085,7 +1085,9 @@ static int connect_ring(struct backend_info *be) > return -ENOSYS; > } > > - blkif->vbd.feature_gnt_persistent = feature_persistent && > + blkif->vbd.feature_gnt_persistent_parm = feature_persistent; > + blkif->vbd.feature_gnt_persistent = > + blkif->vbd.feature_gnt_persistent_parm && > xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); > > blkif->vbd.overflow_max_grants = 0; > -- > 2.25.1 > -- Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 10:49:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 10:49:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397514.638111 (Exim 4.92) (envelope-from ) id 1oU4Ei-0005fZ-T7; Fri, 02 Sep 2022 10:49:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397514.638111; Fri, 02 Sep 2022 10:49:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4Ei-0005fS-QR; Fri, 02 Sep 2022 10:49:20 +0000 Received: by outflank-mailman (input) for mailman id 397514; Fri, 02 Sep 2022 10:49:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4Eh-0005fI-3E; Fri, 02 Sep 2022 10:49:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4Eg-0004Jd-V4; Fri, 02 Sep 2022 10:49:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4Eg-0005aU-KE; Fri, 02 Sep 2022 10:49:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU4Eg-0006Qp-Ji; Fri, 02 Sep 2022 10:49:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IX3RuXrb//rn/zH+wBLyGlhYA0FHd3eEqEt9ebpdjvM=; b=QjCPVRsBNuvXY54obSFGTkLxyk K2fDXUJAIkdd4m2rhKBf1511yAH5jDGLj7wEoBkeirCjNAMKOrXzSTVMzqErBwUm9MaQQst2ZRydv 2lhC9+HV++mfnjxopgp6MwBShylvFNHCGKx9ZzhD7EsOofpg5aRg74eBuaDmPB7Jcjfo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 172925: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e997d055929665b12246e89eb092dc79c65de9a4 X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Fri, 02 Sep 2022 10:49:18 +0000 flight 172925 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172925/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172910 build-i386-libvirt 6 libvirt-build fail like 172910 build-arm64-libvirt 6 libvirt-build fail like 172910 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172910 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172910 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172910 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172910 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172910 build-armhf-libvirt 6 libvirt-build fail like 172910 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172910 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172910 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172910 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172910 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e997d055929665b12246e89eb092dc79c65de9a4 baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172925 2022-09-02 01:52:02 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 11:00:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 11:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397525.638123 (Exim 4.92) (envelope-from ) id 1oU4Pc-00081B-4e; Fri, 02 Sep 2022 11:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397525.638123; Fri, 02 Sep 2022 11:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4Pc-000814-1w; Fri, 02 Sep 2022 11:00:36 +0000 Received: by outflank-mailman (input) for mailman id 397525; Fri, 02 Sep 2022 11:00:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4Pa-00080y-Nf for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 11:00:35 +0000 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75d12f11-2aae-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 13:00:33 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2b-22c2b493.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 11:00:13 +0000 Received: from EX13D05EUB003.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2b-22c2b493.us-west-2.amazon.com (Postfix) with ESMTPS id 30D8345037; Fri, 2 Sep 2022 11:00:12 +0000 (UTC) Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D05EUB003.ant.amazon.com (10.43.166.253) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Fri, 2 Sep 2022 11:00:10 +0000 Received: from dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com (10.15.57.183) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.38 via Frontend Transport; Fri, 2 Sep 2022 11:00:09 +0000 Received: by dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com (Postfix, from userid 5466572) id D42F2275A; Fri, 2 Sep 2022 11:00:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 75d12f11-2aae-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1662116433; x=1693652433; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+NMpbPFe8fp8R+B93WiLknkoUnpXkg4bwQ8Cau7P/jw=; b=dmHnsjSCMNb7N2BK/XvTgcpq2mH1kC5vG7s/f8RkP1Bw1AewLrTGCYwC uBltH/UhinHNVjvoGwdIFSXrjCbZ81xzzpUuL23HDnORLkUr28Cw0CPLf BSztLz4xVmsqOrACw5z93RxckqH9ScLmViGtmWLt/Moc5F/J8cOtcBwL7 M=; X-IronPort-AV: E=Sophos;i="5.93,283,1654560000"; d="scan'208";a="222899704" Date: Fri, 2 Sep 2022 11:00:07 +0000 From: Maximilian Heyne To: SeongJae Park CC: , , , , , , , Subject: Re: [PATCH v2 0/3] xen-blk{front, back}: Fix the broken semantic and flow of feature-persistent Message-ID: <20220902110007.GA100460@dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com> References: <20220831165824.94815-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220831165824.94815-1-sj@kernel.org> Precedence: Bulk On Wed, Aug 31, 2022 at 04:58:21PM +0000, SeongJae Park wrote: > Changes from v1 > (https://lore.kernel.org/xen-devel/20220825161511.94922-1-sj@kernel.org/) > - Fix the wrong feature_persistent caching position of blkfront > - Set blkfront's feature_persistent field setting with simple '&&' > instead of 'if' (Pratyush Yadav) > > This patchset fixes misuse of the 'feature-persistent' advertisement > semantic (patches 1 and 2), and the wrong timing of the > 'feature_persistent' value caching, which made persistent grants feature > always disabled. > > SeongJae Park (3): > xen-blkback: Advertise feature-persistent as user requested > xen-blkfront: Advertise feature-persistent as user requested > xen-blkfront: Cache feature_persistent value before advertisement > > drivers/block/xen-blkback/common.h | 3 +++ > drivers/block/xen-blkback/xenbus.c | 6 ++++-- > drivers/block/xen-blkfront.c | 20 ++++++++++++-------- > 3 files changed, 19 insertions(+), 10 deletions(-) > > -- > 2.25.1 > I've tested this patch series in the following ways: * Only applied the blkback patch but not the blkfront patches * Only applied the blkfront patches but not the blkback patch * Applied both All scenarios worked, so Tested-by: Maximilian Heyne Actually I also wanted to test changing feature_persistent and try reconnecting but I don't know how this is done. If anyone has a pointer here, I could test that as well. Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 11:08:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 11:08:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397532.638134 (Exim 4.92) (envelope-from ) id 1oU4XQ-0000Ga-Tf; Fri, 02 Sep 2022 11:08:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397532.638134; Fri, 02 Sep 2022 11:08:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4XQ-0000GT-Qw; Fri, 02 Sep 2022 11:08:40 +0000 Received: by outflank-mailman (input) for mailman id 397532; Fri, 02 Sep 2022 11:08:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4XP-0000GN-PZ for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 11:08:39 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98589e2e-2aaf-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 13:08:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE20A1FED8; Fri, 2 Sep 2022 11:08:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94B7E1330E; Fri, 2 Sep 2022 11:08:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WgnSIjXkEWPpQQAAMHmgww (envelope-from ); Fri, 02 Sep 2022 11:08:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98589e2e-2aaf-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662116917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OQKJWPbSeknFS2p5TaTKESaFO12O3cb0gTn/SCCCZgI=; b=fjZyqd9a55+CLVKcRTqepnjA5qUXp9YyHKS7d1A9dfUHlilYReQjKKVj5vyZzoUlhgphKo tcLJpb/eF1U9ovxuoz14yfslmcVSIDes9V4i3sAONSP3C/hRH5Eq52Q4xa9Oj3kQX/ruC8 moeqU1C4rnMRhcDi4+RUIkJR2+02lM0= Message-ID: <84def263-c061-605f-44da-580c745bf5b6@suse.com> Date: Fri, 2 Sep 2022 13:08:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested Content-Language: en-US To: Pratyush Yadav , SeongJae Park Cc: roger.pau@citrix.com, marmarek@invisiblethingslab.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220831165824.94815-1-sj@kernel.org> <20220831165824.94815-2-sj@kernel.org> <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> From: Juergen Gross In-Reply-To: <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------E4qBrFxb9XXKM8THkweeh7RA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------E4qBrFxb9XXKM8THkweeh7RA Content-Type: multipart/mixed; boundary="------------9bwtfbNIVhXfCZqDnn9IDv5I"; protected-headers="v1" From: Juergen Gross To: Pratyush Yadav , SeongJae Park Cc: roger.pau@citrix.com, marmarek@invisiblethingslab.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: <84def263-c061-605f-44da-580c745bf5b6@suse.com> Subject: Re: [PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested References: <20220831165824.94815-1-sj@kernel.org> <20220831165824.94815-2-sj@kernel.org> <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> In-Reply-To: <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> --------------9bwtfbNIVhXfCZqDnn9IDv5I Content-Type: multipart/mixed; boundary="------------LJRNnXWoagRkFyFEGiQdSuww" --------------LJRNnXWoagRkFyFEGiQdSuww Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDkuMjIgMTE6NTMsIFByYXR5dXNoIFlhZGF2IHdyb3RlOg0KPiBPbiAzMS8wOC8y MiAwNDo1OFBNLCBTZW9uZ0phZSBQYXJrIHdyb3RlOg0KPj4gVGhlIGFkdmVydGlzZW1lbnQg b2YgdGhlIHBlcnNpc3RlbnQgZ3JhbnRzIGZlYXR1cmUgKHdyaXRpbmcNCj4+ICdmZWF0dXJl LXBlcnNpc3RlbnQnIHRvIHhlbmJ1cykgc2hvdWxkIG1lYW4gbm90IHRoZSBkZWNpc2lvbiBm b3IgdXNpbmcNCj4+IHRoZSBmZWF0dXJlIGJ1dCBvbmx5IHRoZSBhdmFpbGFiaWxpdHkgb2Yg dGhlIGZlYXR1cmUuICBIb3dldmVyLCBjb21taXQNCj4+IGFhYzhhNzBkYjI0YiAoInhlbi1i bGtiYWNrOiBhZGQgYSBwYXJhbWV0ZXIgZm9yIGRpc2FibGluZyBvZiBwZXJzaXN0ZW50DQo+ PiBncmFudHMiKSBtYWRlIGEgZmllbGQgb2YgYmxrYmFjaywgd2hpY2ggd2FzIGEgcGxhY2Ug Zm9yIHNhdmluZyBvbmx5IHRoZQ0KPj4gbmVnb3RpYXRpb24gcmVzdWx0LCB0byBiZSB1c2Vk IGZvciB5ZXQgYW5vdGhlciBwdXJwb3NlOiBjYWNoaW5nIG9mIHRoZQ0KPj4gJ2ZlYXR1cmVf cGVyc2lzdGVudCcgcGFyYW1ldGVyIHZhbHVlLiAgQXMgYSByZXN1bHQsIHRoZSBhZHZlcnRp c2VtZW50LA0KPj4gd2hpY2ggc2hvdWxkIGZvbGxvdyBvbmx5IHRoZSBwYXJhbWV0ZXIgdmFs dWUsIGJlY29tZXMgaW5jb25zaXN0ZW50Lg0KPj4NCj4+IFRoaXMgY29tbWl0IGZpeGVzIHRo ZSBtaXN1c2Ugb2YgdGhlIHNlbWFudGljIGJ5IG1ha2luZyBibGtiYWNrIHNhdmVzIHRoZQ0K Pj4gcGFyYW1ldGVyIHZhbHVlIGluIGEgc2VwYXJhdGUgcGxhY2UgYW5kIGFkdmVydGlzZXMg dGhlIHN1cHBvcnQgYmFzZWQgb24NCj4+IG9ubHkgdGhlIHNhdmVkIHZhbHVlLg0KPj4NCj4+ IEZpeGVzOiBhYWM4YTcwZGIyNGIgKCJ4ZW4tYmxrYmFjazogYWRkIGEgcGFyYW1ldGVyIGZv ciBkaXNhYmxpbmcgb2YgcGVyc2lzdGVudCBncmFudHMiKQ0KPj4gQ2M6IDxzdGFibGVAdmdl ci5rZXJuZWwub3JnPiAjIDUuMTAueA0KPj4gU3VnZ2VzdGVkLWJ5OiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBTZW9uZ0phZSBQYXJrIDxz akBrZXJuZWwub3JnPg0KPj4gLS0tDQo+PiAgIGRyaXZlcnMvYmxvY2sveGVuLWJsa2JhY2sv Y29tbW9uLmggfCAzICsrKw0KPj4gICBkcml2ZXJzL2Jsb2NrL3hlbi1ibGtiYWNrL3hlbmJ1 cy5jIHwgNiArKysrLS0NCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYmxvY2sveGVu LWJsa2JhY2svY29tbW9uLmggYi9kcml2ZXJzL2Jsb2NrL3hlbi1ibGtiYWNrL2NvbW1vbi5o DQo+PiBpbmRleCBiZGE1YzgxNWU0NDEuLmEyODQ3MzQ3MGU2NiAxMDA2NDQNCj4+IC0tLSBh L2RyaXZlcnMvYmxvY2sveGVuLWJsa2JhY2svY29tbW9uLmgNCj4+ICsrKyBiL2RyaXZlcnMv YmxvY2sveGVuLWJsa2JhY2svY29tbW9uLmgNCj4+IEBAIC0yMjYsNiArMjI2LDkgQEAgc3Ry dWN0IHhlbl92YmQgew0KPj4gICAgICAgICAgc2VjdG9yX3QgICAgICAgICAgICAgICAgc2l6 ZTsNCj4+ICAgICAgICAgIHVuc2lnbmVkIGludCAgICAgICAgICAgIGZsdXNoX3N1cHBvcnQ6 MTsNCj4+ICAgICAgICAgIHVuc2lnbmVkIGludCAgICAgICAgICAgIGRpc2NhcmRfc2VjdXJl OjE7DQo+PiArICAgICAgIC8qIENvbm5lY3QtdGltZSBjYWNoZWQgZmVhdHVyZV9wZXJzaXN0 ZW50IHBhcmFtZXRlciB2YWx1ZSAqLw0KPj4gKyAgICAgICB1bnNpZ25lZCBpbnQgICAgICAg ICAgICBmZWF0dXJlX2dudF9wZXJzaXN0ZW50X3Bhcm06MTsNCj4gDQo+IENvbnRpbnVpbmcg b3ZlciBmcm9tIHRoZSBwcmV2aW91cyB2ZXJzaW9uOg0KPiANCj4+PiBJZiBmZWF0dXJlX2du dF9wZXJzaXN0ZW50X3Bhcm0gaXMgYWx3YXlzIGdvaW5nIHRvIGJlIGVxdWFsIHRvDQo+Pj4g ZmVhdHVyZV9wZXJzaXN0ZW50LCB0aGVuIHdoeSBpbnRyb2R1Y2UgaXQgYXQgYWxsPyBXaHkg bm90IGp1c3QgdXNlDQo+Pj4gZmVhdHVyZV9wZXJzaXN0ZW50IGRpcmVjdGx5PyBUaGlzIHdh eSB5b3UgYXZvaWQgYWRkaW5nIGFuIGV4dHJhIGZsYWcNCj4+PiB3aG9zZSBwdXJwb3NlIGlz IG5vdCBpbW1lZGlhdGVseSBjbGVhciwgYW5kIHlvdSBhbHNvIGF2b2lkIGFsbCB0aGUNCj4+ PiBtZXNzIHdpdGggc2V0dGluZyB0aGlzIGZsYWcgYXQgdGhlIHJpZ2h0IHRpbWUuDQo+Pg0K Pj4gTWFpbmx5IGJlY2F1c2UgdGhlIHBhcmFtZXRlciBzaG91bGQgcmVhZCB0d2ljZSAob25j ZSBmb3INCj4+IGFkdmVydGlzZW1lbnQsIGFuZCBvbmNlIGxhdGVyIGp1c3QgYmVmb3JlIHRo ZSBuZWdvdGl0YXRpb24sIGZvcg0KPj4gY2hlY2tpbmcgaWYgd2UgYWR2ZXJ0aXNlZCBvciBu b3QpLCBhbmQgdGhlIHVzZXIgbWlnaHQgY2hhbmdlIHRoZQ0KPj4gcGFyYW1ldGVyIHZhbHVl IGJldHdlZW4gdGhlIHR3byByZWFkcy4NCj4+DQo+PiBGb3IgdGhlIGRldGFpbGVkIGF2YWls YWJsZSBzZXF1ZW5jZSBvZiB0aGUgcmFjZSwgeW91IGNvdWxkIHJlZmVyIHRvIHRoZQ0KPj4g cHJpb3IgY29udmVyc2F0aW9uWzFdLg0KPj4NCj4+IFsxXSBodHRwczovL2xvcmUua2VybmVs Lm9yZy9saW51eC1ibG9jay8yMDIwMDkyMjExMTI1OS5HSjE5MjU0QEFpci1kZS1Sb2dlci8N Cj4gDQo+IE9rYXksIEkgc2VlLiBUaGFua3MgZm9yIHRoZSBwb2ludGVyLiBCdXQgc3RpbGws IEkgdGhpbmsgaXQgd291bGQgYmUNCj4gYmV0dGVyIHRvIG5vdCBtYWludGFpbiB0d28gY29w aWVzIG9mIHRoZSB2YWx1ZS4gSG93IGFib3V0IGRvaW5nOg0KPiANCj4gCWJsa2lmLT52YmQu ZmVhdHVyZV9nbnRfcGVyc2lzdGVudCA9DQo+IAkJeGVuYnVzX3JlYWRfdW5zaWduZWQoZGV2 LT5ub2RlbmFtZSwgImZlYXR1cmUtcGVyc2lzdGVudCIsIDApICYmDQo+IAkJeGVuYnVzX3Jl YWRfdW5zaWduZWQoZGV2LT5vdGhlcmVuZCwgImZlYXR1cmUtcGVyc2lzdGVudCIsIDApOw0K PiANCj4gVGhpcyBtYWtlcyBpdCBxdWl0ZSBjbGVhciB0aGF0IHdlIG9ubHkgZW5hYmxlIHBl cnNpc3RlbnQgZ3JhbnRzIGlmDQo+IF9ib3RoXyBlbmRzIHN1cHBvcnQgaXQuIFdlIGNhbiBk byB0aGUgc2FtZSBmb3IgYmxrZnJvbnQuDQoNCkkgcHJlZmVyIGl0IGFzIGlzLCBhcyBpdCB3 aWxsIG5vdCByZWx5IG9uIG5vYm9keSBoYXZpbmcgbW9kaWZpZWQgdGhlDQpYZW5zdG9yZSBu b2RlICh3aGljaCB3b3VsZCBpbiB0aGVvcnkgYmUgcG9zc2libGUpLg0KDQoNCkp1ZXJnZW4N Cg== --------------LJRNnXWoagRkFyFEGiQdSuww Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------LJRNnXWoagRkFyFEGiQdSuww-- --------------9bwtfbNIVhXfCZqDnn9IDv5I-- --------------E4qBrFxb9XXKM8THkweeh7RA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMR5DUFAwAAAAAACgkQsN6d1ii/Ey+4 ewf+IiYMMF37ivTMfTbYz675zUQOOHQOMZCqMgWRm0DZjx5gCLyj1k+D8gfdlWKA/kvm+IYHXccG 2LvpwNBuKbYdv87DHfeac54/2pkC1bl1RlqvgYFFlj8gCUsbFzmt2Ryq7W+OcmT5yDYFSyI/SnNx gmOBXG7i/9KIGyIkd0erGzCDEEnH18y+wia0KFNAKOCBVE1Rw4qXqbps3zs4cQYsyYdDXgCLVnad 7xcNfy+vuoZfdZAyZ2e2DSdqaYcg4jiq8MzJh7QZNpj3fup63mo+uLHz6exyDjrmllGKWLMHaRJz 8OqWFRyJ62texSA1IOU0Xx1bj3Xv+uLUg3g/zGPwdw== =QkJK -----END PGP SIGNATURE----- --------------E4qBrFxb9XXKM8THkweeh7RA-- From xen-devel-bounces@lists.xenproject.org Fri Sep 02 11:11:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 11:11:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397539.638145 (Exim 4.92) (envelope-from ) id 1oU4aB-0001da-Bb; Fri, 02 Sep 2022 11:11:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397539.638145; Fri, 02 Sep 2022 11:11:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4aB-0001dT-80; Fri, 02 Sep 2022 11:11:31 +0000 Received: by outflank-mailman (input) for mailman id 397539; Fri, 02 Sep 2022 11:11:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU4a9-0001dN-J8 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 11:11:29 +0000 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcc0380f-2aaf-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 13:11:27 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-92ba9394.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 11:11:15 +0000 Received: from EX13D05EUC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2a-92ba9394.us-west-2.amazon.com (Postfix) with ESMTPS id 9051B4558C; Fri, 2 Sep 2022 11:11:12 +0000 (UTC) Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D05EUC001.ant.amazon.com (10.43.164.118) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Fri, 2 Sep 2022 11:11:11 +0000 Received: from dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com (10.15.57.183) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.38 via Frontend Transport; Fri, 2 Sep 2022 11:11:09 +0000 Received: by dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com (Postfix, from userid 5466572) id 58D8226F6; Fri, 2 Sep 2022 11:11:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: fcc0380f-2aaf-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1662117088; x=1693653088; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6syYNqYADgJ/uyZ9pJBWRfO0mouP2N6IJMJoILo4HW0=; b=hgAOPDjQkvl0miYUFs79A0DufCUDrGq3eSiLhTouVp3qq3UuRFECyBZ+ sC5F1CgVqQPmyinIfJzdgLxi1HoRFXXnSA1RLKYyG4YFpzkyPbAsdZJmh mm/j4ARNIYG9Ov4WaCX+sWWQLKVY5g3hSSdM/qJXuAfD9vcC4rN6QLPUf E=; X-IronPort-AV: E=Sophos;i="5.93,283,1654560000"; d="scan'208";a="236927472" Date: Fri, 2 Sep 2022 11:11:08 +0000 From: Maximilian Heyne To: Pratyush Yadav CC: SeongJae Park , , , , , , , , Subject: Re: [PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested Message-ID: <20220902111108.GA27172@dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com> References: <20220831165824.94815-1-sj@kernel.org> <20220831165824.94815-2-sj@kernel.org> <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> Precedence: Bulk On Fri, Sep 02, 2022 at 09:53:22AM +0000, Pratyush Yadav wrote: > On 31/08/22 04:58PM, SeongJae Park wrote: > > The advertisement of the persistent grants feature (writing > > 'feature-persistent' to xenbus) should mean not the decision for using > > the feature but only the availability of the feature. However, commit > > aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent > > grants") made a field of blkback, which was a place for saving only the > > negotiation result, to be used for yet another purpose: caching of the > > 'feature_persistent' parameter value. As a result, the advertisement, > > which should follow only the parameter value, becomes inconsistent. > > > > This commit fixes the misuse of the semantic by making blkback saves the > > parameter value in a separate place and advertises the support based on > > only the saved value. > > > > Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") > > Cc: # 5.10.x > > Suggested-by: Juergen Gross > > Signed-off-by: SeongJae Park > > --- > > drivers/block/xen-blkback/common.h | 3 +++ > > drivers/block/xen-blkback/xenbus.c | 6 ++++-- > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h > > index bda5c815e441..a28473470e66 100644 > > --- a/drivers/block/xen-blkback/common.h > > +++ b/drivers/block/xen-blkback/common.h > > @@ -226,6 +226,9 @@ struct xen_vbd { > > sector_t size; > > unsigned int flush_support:1; > > unsigned int discard_secure:1; > > + /* Connect-time cached feature_persistent parameter value */ > > + unsigned int feature_gnt_persistent_parm:1; > > Continuing over from the previous version: > > > > If feature_gnt_persistent_parm is always going to be equal to > > > feature_persistent, then why introduce it at all? Why not just use > > > feature_persistent directly? This way you avoid adding an extra flag > > > whose purpose is not immediately clear, and you also avoid all the > > > mess with setting this flag at the right time. > > > > Mainly because the parameter should read twice (once for > > advertisement, and once later just before the negotitation, for > > checking if we advertised or not), and the user might change the > > parameter value between the two reads. > > > > For the detailed available sequence of the race, you could refer to the > > prior conversation[1]. > > > > [1] https://lore.kernel.org/linux-block/20200922111259.GJ19254@Air-de-Roger/ > > Okay, I see. Thanks for the pointer. But still, I think it would be > better to not maintain two copies of the value. How about doing: > > blkif->vbd.feature_gnt_persistent = > xenbus_read_unsigned(dev->nodename, "feature-persistent", 0) && > xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); > > This makes it quite clear that we only enable persistent grants if > _both_ ends support it. We can do the same for blkfront. Currently, the feature-persistent xenstore entry is written to from connect() which is called after connect_ring(). So it's not available like this. Perhaps it's possible to delay the decision whether to use persistent grants until connect(). > > > + /* Persistent grants feature negotiation result */ > > unsigned int feature_gnt_persistent:1; > > unsigned int overflow_max_grants:1; > > }; > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > > index ee7ad2fb432d..c0227dfa4688 100644 > > --- a/drivers/block/xen-blkback/xenbus.c > > +++ b/drivers/block/xen-blkback/xenbus.c > > @@ -907,7 +907,7 @@ static void connect(struct backend_info *be) > > xen_blkbk_barrier(xbt, be, be->blkif->vbd.flush_support); > > > > err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "%u", > > - be->blkif->vbd.feature_gnt_persistent); > > + be->blkif->vbd.feature_gnt_persistent_parm); > > if (err) { > > xenbus_dev_fatal(dev, err, "writing %s/feature-persistent", > > dev->nodename); > > @@ -1085,7 +1085,9 @@ static int connect_ring(struct backend_info *be) > > return -ENOSYS; > > } > > > > - blkif->vbd.feature_gnt_persistent = feature_persistent && > > + blkif->vbd.feature_gnt_persistent_parm = feature_persistent; > > + blkif->vbd.feature_gnt_persistent = > > + blkif->vbd.feature_gnt_persistent_parm && > > xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); > > > > blkif->vbd.overflow_max_grants = 0; > > -- > > 2.25.1 > > > > -- > Amazon Development Center Germany GmbH > Krausenstr. 38 > 10117 Berlin > Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss > Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B > Sitz: Berlin > Ust-ID: DE 289 237 879 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 11:47:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 11:47:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397546.638155 (Exim 4.92) (envelope-from ) id 1oU58S-0004xv-3N; Fri, 02 Sep 2022 11:46:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397546.638155; Fri, 02 Sep 2022 11:46:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU58R-0004xo-WC; Fri, 02 Sep 2022 11:46:56 +0000 Received: by outflank-mailman (input) for mailman id 397546; Fri, 02 Sep 2022 11:46:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU58Q-0004xe-EM; Fri, 02 Sep 2022 11:46:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU58Q-0005J0-Bf; Fri, 02 Sep 2022 11:46:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU58Q-0001O8-1p; Fri, 02 Sep 2022 11:46:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU58Q-0002Ad-0G; Fri, 02 Sep 2022 11:46:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1doNrZHvKzhpUFjz04ewQYhuzBoZ3Dyw5RcG0aXJPMc=; b=ddrmQqfAhRPr54jiPHmPq24+pE 5R3aEXY55RuZf+3YZy0iulJD/5L+RFyEvofEag1pE8fMfqvHRSeONIrPYf+Bk9QaXT3l2ybE8g4wQ 9RP6T/8I9NOcNtTdeXuRccmx73FdtX1Hb2O8xnLknbcuk3ZsWuGE1s1KBpKMFGe4NdlU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172933: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 11:46:54 +0000 flight 172933 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172933/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 224 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 11:58:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 11:58:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397557.638166 (Exim 4.92) (envelope-from ) id 1oU5Jg-0006Y6-6M; Fri, 02 Sep 2022 11:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397557.638166; Fri, 02 Sep 2022 11:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5Jg-0006Xz-3e; Fri, 02 Sep 2022 11:58:32 +0000 Received: by outflank-mailman (input) for mailman id 397557; Fri, 02 Sep 2022 11:58:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5Je-0006Xt-OI for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 11:58:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80075.outbound.protection.outlook.com [40.107.8.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e7b9f84-2ab6-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 13:58:28 +0200 (CEST) Received: from FR3P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::7) by AS2PR08MB8622.eurprd08.prod.outlook.com (2603:10a6:20b:55d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 11:58:26 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::3b) by FR3P281CA0148.outlook.office365.com (2603:10a6:d10:95::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.7 via Frontend Transport; Fri, 2 Sep 2022 11:58:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 11:58:26 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 02 Sep 2022 11:58:25 +0000 Received: from 652b8b2e35e4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D47D9A34-1816-4666-AFE6-E252A358879D.1; Fri, 02 Sep 2022 11:58:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 652b8b2e35e4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 11:58:19 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB8PR08MB5481.eurprd08.prod.outlook.com (2603:10a6:10:114::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 11:58:17 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::d889:1b83:c030:8d71]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::d889:1b83:c030:8d71%7]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 11:58:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e7b9f84-2ab6-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EIbxU4FiL21fPaWUlJy6SvKBqUkW39UP01wLLlZQIkc4RjZWjRisezg+77xV0Hdap4eGr+eecgMMCRtkkg+rS6mq06hxbq8wvvttfe85TsH/FrSu/iaYkCqENz2D21QbtJol6R4nZ4KLFiwXHMy0+CIHZL9p5OGiJXB1LqdnqbH9crhD7rWILa96u/4ufUNsy8mqvOfpY1fWUcByxoK01iFOJtrXFs2bqt84LIKEFr3ZOB4zUuPZ91uGRupYMfvJRK4wEEYmSzSvCCwKVPnfsRoKSSGFKMKPC3pR5JU6c3iK346YWCRby+51IEVuv8pGkhVkYMXj2poxSX/4MLUmzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v77W0OIem+V5+t0XY7TRXqjtWXEVHZBee2Uxeph3ERU=; b=ILfuG6/OlnEnbX+Vfp+w9cnS27K7YVWImKABWYwtLSeDECJZu/MS/MNCgzdGL0oSagGKz1oahTkKpumxDPeNF2KQ6RaUfFeiqJcexYsJjHFHr1/3Wf1wz6eUrHQ1yZL8TXOna4Jv7T6II9E9c7bHMM7zJAt6NqFxln//Ex6UnhqdDq6O44jsE3T5YigacyLWQFUWdPu3lp1h20bpjE/Av9klRlyjaq07QB6r+g6ij0f363BH+BurfKTwin+J4tk+fcgmtW0uwxQQbegHI+QlW+YK0nPiK9zzA0LznzWWtaAjvAQLFgq13oTMDCk9kw2sbIPObj3PLgY8kOZCsM6O9A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v77W0OIem+V5+t0XY7TRXqjtWXEVHZBee2Uxeph3ERU=; b=2pEkOPmKuedxJsbqSuqrU55ET2BA3IVRuGT35jlZOWd4ar/OPfohedG+IV+cFXq7sEiVFbFKdGze/VJx+5stlPt+0UUWxUzjqOD5UN1KRmG5ZMGpqMtAmkFLUaRfXVp3Q6k6W/qcoBB1iEltcJV41s+99np8WUekT9zn/kx1JUk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 23c65229d01dd821 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CotegCAyTbt5DO3l3o/Y0INnmISoJcH3wJmTKnV7IQGjN0aRYeif7AesfeVXf3SHQug25uvgYH9TmALUhHWB8G2Ioxo9RfcGt0gbqYoytBauL735a735m7W2OTBgmWt75ILQZKRC4BhqEU/pZSBCh4PYNLjvisdiW+jAUGrPQDEbAkOodoFevqqOEbCe2A7PlmhyIqSXcd/CZuZ4BaKqUdjfVA5ntx4/wsFhtWH5+mgCasD6iu/Rk85tRlrA+wlQ7KwIExer4oq7cYEKLex3PzDa/tzTMk3TkibRt0NTO1cwAZGddlErak44lfKOjdEuKbcJ8aFlQHkdVgBE9dGNEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v77W0OIem+V5+t0XY7TRXqjtWXEVHZBee2Uxeph3ERU=; b=W3q8QW3EsYTG9ZYZswZ+t9QDRap1PwJ2NEB3lB9MVQmWoxz656Jcb11anPH6GAfbelAb70RlUp4q3Oyn4+mXYuf2oaviNmI+uODzTacfS3TXhteW4pkHMYvYXmiiGLdvP9ge2ZL3ruuWtmo6AEaDTulusn01n/S7UajjB4X35KPeM7w0FQHseex657oWnF2DX5w+E/pR/GaKZOoMsscCSjpvfinmVANBRQrh0XHcHtAkjbO+b7pLZ3BbH83htuwIGpyD+Y85m3pkQwenzVS4tixy/UmYxWbFcLwajWi0m2N7LtoxU1irXhU4OOU023dhMxaMI35aRWJj1BPGk2O4tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v77W0OIem+V5+t0XY7TRXqjtWXEVHZBee2Uxeph3ERU=; b=2pEkOPmKuedxJsbqSuqrU55ET2BA3IVRuGT35jlZOWd4ar/OPfohedG+IV+cFXq7sEiVFbFKdGze/VJx+5stlPt+0UUWxUzjqOD5UN1KRmG5ZMGpqMtAmkFLUaRfXVp3Q6k6W/qcoBB1iEltcJV41s+99np8WUekT9zn/kx1JUk= From: Luca Fancellu To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 Thread-Topic: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 Thread-Index: AQHYvpsR/fswdO6djUeMGdO1y2PhXa3MCVqA Date: Fri, 2 Sep 2022 11:58:16 +0000 Message-ID: References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-2-michal.orzel@amd.com> In-Reply-To: <20220902070905.1262-2-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ea2a8ab0-b346-4537-ab07-08da8cda718d x-ms-traffictypediagnostic: DB8PR08MB5481:EE_|VE1EUR03FT055:EE_|AS2PR08MB8622:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wIZyFpBPdKMaXRXFWwu3/DqK0StDhg29Jf6IG2diUl+BGqgLK/y8g/v0THLn8eKOp5cw0nvoCH1vx2IjWps/O9DxhV15eOOSH/1aC/ZpMb2XwG+hnvP17vhsArxXKgx42LPmpg5uVRT8EcqymY1DZVp9req6rWKDz4a7rygEwK/PKH47TwUGiuovKmgomFJVmOWIeSFJZ+WyRPyGzfpQTJNWRSkKbuNZwtKkGG/2jOYsZn5yRztQJlPe9nrD08uPdWb2BpIikOZjGHQzsv4pJy8FuVlqPjib38hyHZ1iAfrY7+2py6qilf/P80hCcVtieTucljd9hHwhkX/SQZnXmrxz4sOlxadvIY52wGnFgVtMQB5uXJZS3olrDeKeprA2/Lr1oapFU3wD3z5aiD65x/+S6+mlx3EpL8MV73P4UyX5H1pKEKK7s3UGJ+MKK6GDw9OcHJKTNYV9QfJ9J8I4CbKeLkg+4aVj3u+ynnihBdCngxZ/1yDKUUKJ0wro+rv1Yr6Jnl7ggoFf5NYGhx8tfHtoaw4frwJLROdkKdp5Ba0IHXaS7i7YRUHvjikfVQ188P756ZGdJCCFMXXSjXvRqL111qhjWs71CLIb4eyjgTcyAEI3qjWiQ7qE0AVKxKOzHzo6zgHG75dPGX1wVDhLlt9El4muGmbtmCC5R7f+id9PC3xDQq0XaSGTcL+put2nEVa9E68WWAimvmjiSfL/foLgfD75aJ91pw0mqZJtSvaswPPj5e140P/FmsumgdW2YuipKJZRuGTSEo/fTXw1b7dCFnWWvGlcvqlE8t9Gp20= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(91956017)(76116006)(86362001)(66476007)(38100700002)(66946007)(66446008)(8676002)(66556008)(64756008)(4326008)(316002)(6506007)(6512007)(54906003)(38070700005)(6916009)(41300700001)(26005)(186003)(53546011)(2616005)(71200400001)(122000001)(478600001)(5660300002)(2906002)(6486002)(4744005)(8936002)(33656002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1CFBEDB203FE984FA4B9448E3574A3A9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5481 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4be583a-5d94-4ba5-1ade-08da8cda6bfe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7BRpdGE0bU45f4hAwkd9Z7X7KaOkApKMcKwKExNYV8K7lMzU19DAwdRiJGd1nrDiBxd0bf56UZ3T3ARuL87B4tnc0QQFj80klPSeDb2QX8N6iSEj1q69b4IpiZTPEHi1dncpOU+W9sdk7iIpjY3+0vKOU9gsw7DVtK6GHTmyLlLLqH2LWBBgS3CaILAFB4pUcjW++9k/1YbEeHPBqqamrXuAVsuz6NQppDKTr3AiV7ui/rgx4TqasFSLOy/zg/J6fpj6z+h20vJwxiRQZHU9tqJCksqtgVScq/j/GBATkVf+G6w07QA6eYFSHqzaEDyplXpPUXt40vMGLcn3p715jRKKun2rGuaxehD7CfVVsXXyC4N30YnBAyUD+2VtEkhmgvBTPzpLpE/JVMP7YYMaqLSG2HFS3Rq6IzKCj39EOhPbDKEizJ0cPFmHFCuHfy2NWPgucjqpPKGyOi13x4MlyevtD5s++v7J2t0TtAqG7AUWLGjOuIY8IZ5o22908lbbmxCXrxCoYF1wSFqzAWfHuzijvQob4snaVLXJGVQVP0to1zu16V3v+z15wL7jROIc1Rab3ANduDMtm+TPWRBvuhYZPs1fBYjDNNt0Blgd+lLrX2bAwpNvZefoYwirw4OV3tiI9Iht80hwqPnHnA6+jN009Rks/U93fIgKHslbszXk5/U0mZ9eheNRSroBpQuBX3zSDMxxgr9SbDEBBTlygyZGybIm+0wB9z7QQ2HVsUgK2Hz9/s2ZFMDYeTrDoRDKT1wCdmq7j3sZg3bFhD2XFQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(36840700001)(40470700004)(46966006)(478600001)(6506007)(33656002)(8676002)(107886003)(4326008)(54906003)(41300700001)(316002)(6486002)(82310400005)(6512007)(53546011)(26005)(356005)(86362001)(2616005)(336012)(36756003)(47076005)(36860700001)(81166007)(186003)(2906002)(5660300002)(40480700001)(6862004)(4744005)(70586007)(70206006)(8936002)(40460700003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 11:58:26.1121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea2a8ab0-b346-4537-ab07-08da8cda718d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8622 DQoNCj4gT24gMiBTZXAgMjAyMiwgYXQgMDg6MDksIE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs QGFtZC5jb20+IHdyb3RlOg0KPiANCj4gQWZ0ZXIgcWVtdS1zbW9rZS1hcm02NCB3YXMgY2hhbmdl ZCB0byB1c2Uga2VybmVsIDUuMTkgd2UgZW5kIHVwIGhhdmluZw0KPiB0d28ga2VybmVsIGNvbmZp Z3VyYXRpb25zLiBUaGlzIGlzIHNvbWV0aGluZyBub3QgbmVlZGVkIGFuZCBtYWludGFpbmluZw0K PiBhIHNpbmdsZSBrZXJuZWwgdmVyc2lvbiBpcyBhbHdheXMgZWFzaWVyLiBNb2RpZnkgcWVtdS1h bHBpbmUtYXJtNjQtZ2NjDQo+IHRvIHVzZSBrZXJuZWwgNS4xOSBhbmQgcmVtb3ZlIGtlcm5lbCA1 LjkgZnJvbSB0ZXN0cy1hcnRpZmFjdHMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwgT3J6 ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KDQpIaSBNaWNoYWwsDQoNCknigJltIG5vdCBhbiBl eHBlcnQgb2YgZ2l0bGFiLWNpLCBidXQgdGhlIGNoYW5nZXMgbG9va3Mgb2sgdG8gbWU6DQoNClJl dmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCg0K From xen-devel-bounces@lists.xenproject.org Fri Sep 02 11:59:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 11:59:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397562.638178 (Exim 4.92) (envelope-from ) id 1oU5KA-00072L-Hc; Fri, 02 Sep 2022 11:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397562.638178; Fri, 02 Sep 2022 11:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5KA-00072E-CR; Fri, 02 Sep 2022 11:59:02 +0000 Received: by outflank-mailman (input) for mailman id 397562; Fri, 02 Sep 2022 11:59:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5K9-00071u-B2 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 11:59:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2064.outbound.protection.outlook.com [40.107.21.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a043e920-2ab6-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 13:58:58 +0200 (CEST) Received: from AM0PR07CA0003.eurprd07.prod.outlook.com (2603:10a6:208:ac::16) by PAXPR08MB6512.eurprd08.prod.outlook.com (2603:10a6:102:15a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 11:58:51 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:ac:cafe::41) by AM0PR07CA0003.outlook.office365.com (2603:10a6:208:ac::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Fri, 2 Sep 2022 11:58:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 11:58:50 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 02 Sep 2022 11:58:50 +0000 Received: from bd71d2ee0a7f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A78A5507-D4AE-4D33-B544-FFC88ECA7CB0.1; Fri, 02 Sep 2022 11:58:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd71d2ee0a7f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 11:58:44 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB8PR08MB5481.eurprd08.prod.outlook.com (2603:10a6:10:114::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 11:58:42 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::d889:1b83:c030:8d71]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::d889:1b83:c030:8d71%7]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 11:58:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a043e920-2ab6-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XQ7OEeEoREn73oihf2L6Ix35CT8HZ4Rm4Jap4+heFz7REvw/LFS0o0223llqs47dtAKHJ591GMRK7/Tmx6/sOEWvTezpLZrm9RSvsLIjLdyiiYc5f8lkGQ/Kk9ZNOXygR5dq2yVz1YbRZSnUqgHoZtD7/gMjbAOEgEQ5yV4TpC4OYMbuWL+uRrF9meYt4oDnsKU1jyCCHPQCa6MEiK++e/X1WGbPLEngHAJXril2G4O081H/n/1NiJe0zFHPbaszlcYbLst9Om43VRhOLV9B6JTcLqWvUogDkSfC5F2dmJ8XxxS9Wryoms4yLFnlAaZf9qF6mFxp8PuzVDJyaSEuOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O1XIQ99yLPhFQhFR+ChrOwNK5D+LuNmADhPaJPc1LWQ=; b=hgzdVvCqa0twL5lm8M+dJzygeGKsJUUt8BH6swhFNaEPz6FG+E9FwDhfkZ8xA/iAO7kd3JjGcPr5wh+dGpeURg92xtWvQvRy49+TLXPYwx/vBk/VCudVG6ab64y4sAAsC5v0tII+DJT0UQlzbbrzS1dY3c/mvWD9O1h7kSQszt/fJ2xefIwkTLdMnYCG6Jz9C8oKPlAAhW37bfvVP504H6BfQWt5QDkWBucHbQS98XCYwf0xvzl+FY01S9duNzwbEGO2WX41tOzTePn4hlP0AwHx5ZlFBVCq3b+EbjdxHjpSQ9nut0iov8OkgPq292R7kkVQBO1RIGsJBKy2PoNKqA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O1XIQ99yLPhFQhFR+ChrOwNK5D+LuNmADhPaJPc1LWQ=; b=3xIlBxHkaGNn37qf54RCuh28Dw53LyQMvvUC9Y/nB1br/EhV2TNShC4AA8KWQece9gE8EBh0v0/ZWXazOIQ+iL54eeqqGHW5dEIlgsfkb63Y7EcYi2Sg+WM0bhwzAEcEAc0RNEw7h0k2ViqE+0vTqlBjS9m+D6zpVh1hsUScoKQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7e68ca5e3f4bd74b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DmTzEj7WPvktmi0ahVlmqKK19UTP8s8pjpDHz93Fk/MzmppFTlN04ZxcPnhU5izzUMaTUWUvP3U/sUY2/RhrygjGS6DS3sokh/NWLXEG8nMpCQdckLxgw9sVC98qAG5rpsZPs6D4Fd3kEZrLm8GFezBYsRXOWnn1fVnbjEyTJVHlSyQ4YKZ90XLVCgBJGJ0E1h2fLquGTKsOf/04BT/RyZw16L0DT+jBfB93/t+4qRzy6SW47lFDFeuH/wfTFzfhpgrihmIBU9accyO+fARd6iHRLsTRhGHR2ZdIbQmfvruDw/pBlWMgBMioQV1EYUdHW7pQYNNA+cP6Sm2J8eyPQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O1XIQ99yLPhFQhFR+ChrOwNK5D+LuNmADhPaJPc1LWQ=; b=BFuSyuAIpQqgL6fAzti21I+geN+dKGnco9NnqGlaD07F7pg56UeP5PenVigKzG1kiJxLqng35rhgzEakOys8KSmNpAqNH9cei03UiRCsgcjAv7ky6KyoF0Mwmeqtd6/O1pEjLaR4PDcqLDKVVTotfokUSW+0Ii6T2QUlUcMOL+KoZzegwfmIl2CKRuGslb0MtiXSjKMWQRJV4HvbAYeBmY5tgrR92evLJxK6ebnffAegQkyy14iFCLyR62dPyFet9tWygn1fviiYYsqJ+tlMyPfPcTHyPNcVETi57zXyU6haGmlU9A+2rXnwzBXzVXeNjXCc+S8o148SwQWYc3N20g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O1XIQ99yLPhFQhFR+ChrOwNK5D+LuNmADhPaJPc1LWQ=; b=3xIlBxHkaGNn37qf54RCuh28Dw53LyQMvvUC9Y/nB1br/EhV2TNShC4AA8KWQece9gE8EBh0v0/ZWXazOIQ+iL54eeqqGHW5dEIlgsfkb63Y7EcYi2Sg+WM0bhwzAEcEAc0RNEw7h0k2ViqE+0vTqlBjS9m+D6zpVh1hsUScoKQ= From: Luca Fancellu To: Michal Orzel CC: Xen development discussion , Doug Goldstein , Stefano Stabellini Subject: Re: [for-4.17 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages Thread-Topic: [for-4.17 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages Thread-Index: AQHYvpsHo7uRLr+x2k++nrEtWQ42s63MCXmA Date: Fri, 2 Sep 2022 11:58:42 +0000 Message-ID: <06411D8B-A659-4C5D-A942-3EF45FFE8ED8@arm.com> References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-3-michal.orzel@amd.com> In-Reply-To: <20220902070905.1262-3-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9078a609-73d6-4d3c-8877-08da8cda8056 x-ms-traffictypediagnostic: DB8PR08MB5481:EE_|VE1EUR03FT044:EE_|PAXPR08MB6512:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Sh77IBlov0SEaoqluzVTGVALJ/AGIDcFDHEoZ0VVFXNnxyLzC26JyD99JgA4I0QueIfpUcHmISc3jR6bMYOeIXZlBt/HpN5Za4/C8afJ3HBc6JVwn/2tXTiJZS9n8Mt1+hAoNhZMCy8FoxsbXtlI1bmS82tsLPMCP+N2ayQeoQhRXm4BiYLPnTsMj88/Kc3H5WXAwAMUBf0xW0P9USAEKDzDevb3Fmiy5b2ZJDVrboYprPCFTjyvy2vPBdwAmHy6im7G/g89Cnsn7SXhrB+U/PrwSqejx+ofIlThtb/m07ImdVLnXBn8tlmzvKPTwtWb2IJzPKVZeZtRxxx8/ao/pzonZrQscLUe5gSu2DwBxP3ZCgDBR0uQdq1nfyMeCz9qavza+x/aPAOg0zR2ErO0i16XRhmKBuQMr2XDBJi52+WPCjxXa3TAwJ5hGmQLUeHdGdiIT1gz3M313Okh+NP7v4JNUz0gZqXqap51Or9CtmQu+dj3Pw4ykCFcyEmIhdTe3Ex8HnYzFJgjZR4ZsIZ7pu3DRr7/SOdgWAW7s5cp1OLqcLR1stAEPSu8TqgH5ERJToNf++L8SeVI7yC++IAF44jKydn75m+i+zvnzSiwaP2Fr+i4MzBEBFylFLo6iGjSy7ii/ti+3uKdpMvxv4LAr/isMazzR1H7ry2v3XPJ9gzONZ6tC89G+FmTv24NCLBwTF4Oe1PSpKn8gdfrVqJqw2IeKEFh+KzH2VvzLK7p8y3bYEo5rttQeSK4ceUV5MP1TRbRd7TzpHWUfODUl0K5z0iHr0XeI65Psn5Z/h5lOnY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(91956017)(76116006)(86362001)(66476007)(38100700002)(66946007)(66446008)(8676002)(66556008)(64756008)(4326008)(316002)(6506007)(6512007)(54906003)(38070700005)(6916009)(41300700001)(83380400001)(26005)(186003)(53546011)(2616005)(71200400001)(122000001)(478600001)(5660300002)(2906002)(6486002)(4744005)(15650500001)(8936002)(33656002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7CB5B513F1B41047BD6E1CF840352FE4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5481 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 61adfa19-c8dc-4d97-7dd4-08da8cda7b0f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qveAB8VOpaPhJu+C2GbflhQh1C5G2bLB6jGA+CsYw5qYLEozvpA0NPP2YGhqM76n34BjPycNYKYjTuFKR12qIkMis7e8lqzYMDmLh9ESQES5bs+C2dtoeiCVOpDQfEs4y0+Fj3bwweSdwN6++dFo5TYPmqphYy0rwWJv0UUlC220xuzRXyefO6BbzqLVAXgzHev4WlW21ttrwjuvjECC3nWsCquTAo7kHS4ikXrrITJoxQ7bYYVuDsVSeWB4ENgMgxndo2n44OFMSWQcaRXruyVwiYjiOcsY1pRqqe4+N21FYyYssUq4W/5dLVJ6dQ3f2M+k4uPv+fjTpfDLgch1C5ult8z2TjXH+iOZZuDpDgIE1jiLB+FEuP0IIP+FCumYmU2O6XxMARvSAkQobRcosnSjrVGiAT91Nf7NEmcfYJjQ+QEXw90t8u+nNVZjyAQ6k9YXhbiJPU/8XkrcbZhF5QRUT9Z95NSrIY2FT2KjKGfwqb7CIekpLbAgA9+Cun7QJA98O/a5m251SJq/Mkzs2Sc0lJJjaGUk6NagvOFQD0IePNxmLULbIG4RNT7jB0ews4N/JcgfiuMzLl7ToEfVcwrKAj34F6iCC5KQFMKXwilJFIordpFy1QKka5Z0FNWLXpen9o30m3ozWRickzGKigbF6l0bJaMjgQQ4AwwoH3knAwtSarKEtf2FDmwUv8LHHqNWyraf6zkor1aFRF0BuEXOclIEOX3l09v/leTUO2P+WCAN8gMm9ZJbummGjLm7/2wz42p5IihE12mr9hOGdA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(396003)(39860400002)(40470700004)(36840700001)(46966006)(86362001)(36860700001)(82310400005)(356005)(82740400003)(40460700003)(40480700001)(81166007)(41300700001)(70586007)(4326008)(478600001)(8676002)(70206006)(6862004)(5660300002)(8936002)(54906003)(6486002)(316002)(47076005)(2616005)(186003)(336012)(33656002)(83380400001)(2906002)(53546011)(26005)(4744005)(107886003)(6512007)(15650500001)(6506007)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 11:58:50.9166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9078a609-73d6-4d3c-8877-08da8cda8056 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6512 > On 2 Sep 2022, at 08:09, Michal Orzel wrote: >=20 > During the ping test, dom1 tries to assign an ip to eth0 in a loop. > Before setting up the network interface by dom0, this results in > printing the following error message several times: > (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device >=20 > Silence this by redirecting stderr/stdout to /dev/null as we do not > care about the output and we should not pollute the log file. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Sep 02 12:00:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 12:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397573.638189 (Exim 4.92) (envelope-from ) id 1oU5LT-0008WN-3L; Fri, 02 Sep 2022 12:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397573.638189; Fri, 02 Sep 2022 12:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5LT-0008WG-0N; Fri, 02 Sep 2022 12:00:23 +0000 Received: by outflank-mailman (input) for mailman id 397573; Fri, 02 Sep 2022 12:00:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5LR-0008Vz-WF for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 12:00:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d15b41fb-2ab6-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 14:00:20 +0200 (CEST) Received: from DB8PR06CA0029.eurprd06.prod.outlook.com (2603:10a6:10:100::42) by GV1PR08MB8743.eurprd08.prod.outlook.com (2603:10a6:150:87::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 12:00:18 +0000 Received: from DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::a8) by DB8PR06CA0029.outlook.office365.com (2603:10a6:10:100::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 12:00:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT003.mail.protection.outlook.com (100.127.142.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 12:00:17 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 02 Sep 2022 12:00:17 +0000 Received: from b43e6b5262ed.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 48123793-C528-4E99-9395-1593896ECE82.1; Fri, 02 Sep 2022 12:00:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b43e6b5262ed.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 12:00:10 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB6083.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 12:00:09 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::d889:1b83:c030:8d71]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::d889:1b83:c030:8d71%7]) with mapi id 15.20.5588.011; Fri, 2 Sep 2022 12:00:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d15b41fb-2ab6-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RuL+4TzngMrpGmqN7Hjca+ylRzhzprrnizVrWxcXqyipoevpFo92vpYpcsf5nEd1zq+L1gISeSwfvc73W7/k9c3vv7ngOg2EPXG2zfEsfirJZh+CjEErtZSurpAs75BB9xvLZ3EbSO6RiLJ74Zza6NPaQGOPkml+QvoQI5EdcDpMdZjBuJGMyeBLWZ2LimEbhfCQD7y/EyLCCHqGgjdjru4J8a+Dwdhi07ZbUu1bCfsT8C2qOPl0LiDIQwovAo4QOxXMaQqn6bntCO1rAKarkfwwlZNf8fA2dHENiJEKRJ4t6RpDEmFjnVlUG5hJZ3kF1yKZzAgj5Xll/4PlVFiW6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b6XSZSDOsHH+WjS4nsg3J7OqWXunkYzF5U+k+pgINco=; b=lh7W721qTxzznaZhtR6fsa//RiWEHFklTMQIGfZ+SFmldOxMRquLPuDeUsDMbAZJUjOT3KIHLCQ8HuYknb7ORYY+9NYVgV9YDdG6WqAi/C3OWERmpI6pKNIDyVLDcFvu5UamcN1HfSf1YHAqsefVd104K5VRVPaFEoCgIHwvGvio+Oofp4WPMNh3JABGe5cQo9q5SAfr9Tiw1VsIwQUHO6GGGQGlqm0sZE9PuObV+yJmVIqGeB0zBjddSZtt8DLSEmD7r8wu5nd6Ser1kFvvBqHC2+eEL7+HR8iHBHrfwDbYVdExvomRGGy1zaME/5gKtmGU5i0ofKxbJ8vOkDwAWw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b6XSZSDOsHH+WjS4nsg3J7OqWXunkYzF5U+k+pgINco=; b=t2KLDK8J51PaUi7DTmVYJT7PRNVZPulPmZLS1zuH9jDdZYuIu2ml25Qbx5Dj4JHJzoo7gUGeabB5jPxi1aKMG/JOOQwlzyQ2OGFhTo2xSldcM7+Z/cHk5dizM3xEk5cKgRov6RD4kSrvcxYbn69zqPskealh68BzXxh1Ae2qXaM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a708caac89c1cd7d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bR0SRMC2PR2CmShgPAl78gDRQl1IqQci6udS0yCq74xRHNMkSmewvQNEiaFH7227/AFWxil9Os6E75mOsemRmD3OY4TLcU1ETN3MeAhY6wVgYgYeNP0bmHhRClgz5iyWsTd7fQ6TOFo+lVL0d+doMR6ydgzKJrl/5Am6F5U+3Q3rikyBJZMW1nelWRpQXKCNyIYbobPdd8MSEXcD4XQVSKeXE04MOj+uE1HDc5L/j6Nm74bWbNbuWQ+uaMTefpIT1+94gdzTmszCZgSHVHqiMFHDWdqg+JreH2WcbB+UvOleyrAlWIlEU+8B3Lf8YJglIXkwGXwkjKu5j9b06aYs9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b6XSZSDOsHH+WjS4nsg3J7OqWXunkYzF5U+k+pgINco=; b=cbGpCUUn+s/CBVvFPwpyxmVlgf6EKMlog6Wmw9m0P4Ic6DWZ2b7nyYtLUEGS6Cilat3EOHrffo4deYBmuSdBQ25o0G6+Uaps/fmwhQxeuq5gUZ8/SSdld5Z5uNipA7pyurOn2M5NLc7lGu5pP53Zjs000Jtc6Q5gWI424AuGKHpq6kF30tnwOueqRTCg4Edf060mRm9OrlNBjifP7rtmThcm4p0C3XXV1c5Kp9jftDl6sB2Io7hLkXjmMHL+JgiRnWFwSY3ijhgs77QFP65flQSLnbMTmlEav1TLh8bWB1R9PEuapEope5z/I0tYMfJTSIzRNKQU+4LwLJSsF2LSyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b6XSZSDOsHH+WjS4nsg3J7OqWXunkYzF5U+k+pgINco=; b=t2KLDK8J51PaUi7DTmVYJT7PRNVZPulPmZLS1zuH9jDdZYuIu2ml25Qbx5Dj4JHJzoo7gUGeabB5jPxi1aKMG/JOOQwlzyQ2OGFhTo2xSldcM7+Z/cHk5dizM3xEk5cKgRov6RD4kSrvcxYbn69zqPskealh68BzXxh1Ae2qXaM= From: Luca Fancellu To: Michal Orzel CC: Xen development discussion , Doug Goldstein , Stefano Stabellini Subject: Re: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 Thread-Topic: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 Thread-Index: AQHYvpsQ9QXsCVWjO0+hBzXJHV+QVa3MCeCA Date: Fri, 2 Sep 2022 12:00:09 +0000 Message-ID: <3E3B0825-5547-47B1-B417-98B8A54B6CBE@arm.com> References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-4-michal.orzel@amd.com> In-Reply-To: <20220902070905.1262-4-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3b857ceb-83d1-4e76-5c8b-08da8cdab3f6 x-ms-traffictypediagnostic: AM9PR08MB6083:EE_|DBAEUR03FT003:EE_|GV1PR08MB8743:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LTCbXJ80oBMjm8phfbjWF6Ncqa2YWLvXQeQKsek9/FHPOHVIIOmYsOknVKNx1pUOUxDpJzRDrE1wkvhAs4K8s3Qh7axJmnGUWMX68jc8eSJToXvGLJZGwDUw9j1djcUVbhGcL5RuzfWA0mNu9rB5fr6lq6WgjmeLIvLm13kmcuSLyS73vaGKl5OuzYrDuN7exKe+0WV2eUSRFqNKzhcaMYZdPbMDv4KuLeF7d7PJXHdMhghwDnKTsPwqGWvpXD+fLshS6LhWKWmjiXaWWyzttBFk7GWl4xUCAMDe+rkQyl3ORiaWKKTk4CFOoGWdNQKXT2VWW8mUNtud4t06V4CbXlCTN/yU9uN7/P8c3uNiFnDjHOqnNN20V+9lseCFDPERLZ/5ywWdJcmO7NKDQ21TSs7NDf5yvrQGV4PCqaQZbaShl43mqZ7kJSZvmFWuiUNiNs1hr8+TzHjskn6D04P4J7lcF3W6qvZQjuyku+XOcSHBhruxnZMkZC7Ffg1rsi9pg28rnE+wSOamA+9uGpQ4XnaKcIYx8F1YWu5QVZ2akx9aHU8Fwx9PeFSqfDkyHndLcArljnlj/1zFEI7w0X7bzXsUkE+ECMpRjgf0ExPXeRo1N+UaZOxYeK74Dbn8Ra5jvfrVrYioCpJ+4vnpGf0IcTGJW7BL0E5O2gSYMlStMXvo2NBOoSX1qtlr64DqqNDPpWkzUR2BXLTh7nDqCa4QcarF1tsx1uZlbvFweWH724/qDDI9ZkZUfVWPAbVovV9HpfavW7Cg11R3lepKCN5i7x3z6vW6Wua8eSQly0CKLdsofBGZvxfS1ZE4e7td+LlQLGAMDCe9i2j5O2YcZB12DQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(66556008)(122000001)(83380400001)(38070700005)(38100700002)(66476007)(64756008)(316002)(71200400001)(8676002)(66446008)(4326008)(478600001)(91956017)(54906003)(36756003)(76116006)(6916009)(66946007)(6486002)(41300700001)(8936002)(5660300002)(86362001)(186003)(4744005)(2616005)(6506007)(33656002)(2906002)(53546011)(6512007)(26005)(157313001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7B7644E311296044999DDF62974834BE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6083 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8e06e02f-4bb2-40a9-3b31-08da8cdaaf0b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /CKq8+HF7pulucn024K+ciF+sFuHr+z7aOm/UUrsJPXm2X7zkcyqpksL/cQG4Wku2EnrV2mlLimpDntZMn2a6c30t6kCAKb1L1Fai3I/1+fLakhkIAgVPvPoN4jJsXrc8T4Z/CWDcGxj4l/17rAIsRwO/xkDrxQnycG+I74BV1BWkKtmTYKCoqLapOG/FTPTyrkmPf++rnWXKXYO18MDXhnSw3H8hLOn2+sdN2j1TCPDQHe2oJLJt6k0qYeLr9fc/sRc6/XAV8RmYjB15qmcZTtUBiAlPZskVj4bx5l1tHy9j/K1hunmMsgIIm5cPhVTGC5Ta+hhs5/er+IuTQTafl0iwg3h2Al8Uf3LRcxLM283m0v2ZlAL0MX1Wf7WB1mi0Vi+4ll8Gvw1XNd3VCrijRzbDnc+hU7mQsjKjOURaloQlUiSctsWB4UqgIwXj5Ak2bDRV4Rx4kOtDdDYouDen/a7YIQ+X1fGu8pc0cj0x9ty/bPwqiAUcID57/DT2QbS/Ex8TiuAPDlh2Ye1YXNtzDBnqnhocDhsI9cnQDQXs+Cwir6X9OEEeSKGtMoJn7lf8ULQXznN9keNTNN3aGWGCzoV/SlPUB/gN3k3XwfxI4Aq8Q+EH6BsS4XuMQAu9LNr57Iif+Iq/R4RVc5CRZPvn7Gmv4coRQoPaMPwqI8nSRR+4mM6PHpBf/eKAx2AOc/k6D8Z6UbzlM6eOf+JSMhMsu8UShnqQcZb8bGM3tcVXROLkvjNL7QeBRp5tZQw8vSzWyApt5mCQwT1Bu6x7UR4VD6GHroKEALTvFRmEBcAq9k= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(346002)(376002)(40470700004)(36840700001)(46966006)(70586007)(70206006)(47076005)(4326008)(41300700001)(8676002)(2616005)(336012)(83380400001)(186003)(54906003)(478600001)(316002)(6512007)(36756003)(26005)(40480700001)(33656002)(107886003)(53546011)(6506007)(356005)(40460700003)(86362001)(36860700001)(2906002)(82310400005)(8936002)(6862004)(5660300002)(6486002)(82740400003)(81166007)(157313001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 12:00:17.6372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3b857ceb-83d1-4e76-5c8b-08da8cdab3f6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8743 > On 2 Sep 2022, at 08:09, Michal Orzel wrote: >=20 > Add a new test job qemu-smoke-arm64-gcc-boot-cpupools that will execute > script qemu-smoke-arm64.sh to test boot time cpupools feature. > Enable CONFIG_BOOT_TIME_CPUPOOLS for the arm64 build and add a new test > case in qemu-smoke-arm64.sh that if selected will: > - create a device tree cpupool node with cpu@1 > - assign created cpupool to domU0 > - add a check in dom0 xen.start to see if domU is assigned a Pool-1 >=20 > Take the opportunity to refactor the qemu-smoke-arm64.sh script as > follows: > - use domU_check to store the test's commands to be run from domU > - use dom0_check to store the test's commands to be run from dom0 > - use fdtput instead of sed to perform dtb modifications > - use more meaningful messages for "passed" variable. This way we can > grep for messages reported either by domU or dom0 and get rid of > assumption that tests can only be run from domU >=20 > Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Sep 02 12:02:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 12:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397583.638199 (Exim 4.92) (envelope-from ) id 1oU5NO-0000l2-FT; Fri, 02 Sep 2022 12:02:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397583.638199; Fri, 02 Sep 2022 12:02:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5NO-0000kv-CT; Fri, 02 Sep 2022 12:02:22 +0000 Received: by outflank-mailman (input) for mailman id 397583; Fri, 02 Sep 2022 12:02:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU5NN-0000kp-4T for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 12:02:21 +0000 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [2607:f8b0:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17f1dcb9-2ab7-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 14:02:19 +0200 (CEST) Received: by mail-pg1-x529.google.com with SMTP id c24so1754173pgg.11 for ; Fri, 02 Sep 2022 05:02:19 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id v65-20020a622f44000000b00539aa7f0b53sm1557339pfv.104.2022.09.02.05.02.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Sep 2022 05:02:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17f1dcb9-2ab7-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=W8RjYI+n37ofAo9LBQEiCCEo6ndS1LkvyfXGybqsT9Q=; b=KJAXAw3+eV100jVcXnx/LqY4g085qYcLfMEFb+CqK4NNPBI9F8q01WkRiTpC9xcqhF /4FkKnilu36QUVvPSMq5xoJPqh+oM/ajx5O1Ooz3frF0it9D7UMt8os//kh3KVKuZVb/ DPPYiXpugkbyENhGTY+/WPxqKyt1jcv2zujzHIJxdB0ew1X0zrJZfMTGT15i+87M0po6 0/QMZTGU+ePDJ2R+Ec9/I+/IE6Qsct4tdfUfCSODRxCfpDSAWo9ais93dWCx9G+uqlln 0sE9qiRD9Lz9bZ0YZbv1M1UDvvLW735W+u2JopGKR2Y65g0jVSPYyBMRqlC2d3FYstWU 49Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=W8RjYI+n37ofAo9LBQEiCCEo6ndS1LkvyfXGybqsT9Q=; b=N00vEs/xOe91ytLcNvpzgJ+/N7XxevQuxKDnx+buEYxzYvKDppqlstlVkvXaMZELQ2 UVjbitpU8JpehtEfDW515gCkTCpEtTyWcN35h4YrBfeYzb4TwxGzYgImaMXYX2AJ5PeH m7iJxlEePT9rlxSKYjtgXIkv3qSmui29p1gAn+2nb8lnL8r1PA8nb7Lcjdgy73YJ80xo NRMhOxgkd1ZLw6T6fWWY8Rgzc733fSsKtFn6ym10ZG39qnbR4uJsc7w/4dzRwsN/C1Ec FZh4Tx7QLU1rIXfANi7Qme3uqbTyfGdMo3sLuqOFSOruepciA4DIxRNl/7AoFWQEZ59E OwNw== X-Gm-Message-State: ACgBeo2FAuXQ6KPwpiuWQjdljPmomRVMJnJm64UNohUhND1Tx9hinLCU 8JjmIJp+ALQH3aFx+ai78fPxmA== X-Google-Smtp-Source: AA6agR6oz8BXj0U20tJpMgDuL2EJ/favK/h81yeCR3znK+DwDUa+f211F9QgLE7hKWaq2wOql0pxmg== X-Received: by 2002:aa7:92d8:0:b0:537:acbf:5e85 with SMTP id k24-20020aa792d8000000b00537acbf5e85mr35570681pfa.61.1662120138036; Fri, 02 Sep 2022 05:02:18 -0700 (PDT) Message-ID: <3a41b9fc-05f1-3f56-ecd0-70b9a2912a31@kernel.dk> Date: Fri, 2 Sep 2022 06:02:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Content-Language: en-US To: Roman Gushchin , Kent Overstreet Cc: Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/1/22 7:04 PM, Roman Gushchin wrote: > On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: >> On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: >>> I'd suggest to run something like iperf on a fast hardware. And maybe some >>> io_uring stuff too. These are two places which were historically most sensitive >>> to the (kernel) memory accounting speed. >> >> I'm getting wildly inconsistent results with iperf. >> >> io_uring-echo-server and rust_echo_bench gets me: >> Benchmarking: 127.0.0.1:12345 >> 50 clients, running 512 bytes, 60 sec. >> >> Without alloc tagging: 120547 request/sec >> With: 116748 request/sec >> >> https://github.com/frevib/io_uring-echo-server >> https://github.com/haraldh/rust_echo_bench >> >> How's that look to you? Close enough? :) > > Yes, this looks good (a bit too good). > > I'm not that familiar with io_uring, Jens and Pavel should have a better idea > what and how to run (I know they've workarounded the kernel memory accounting > because of the performance in the past, this is why I suspect it might be an > issue here as well). io_uring isn't alloc+free intensive on a per request basis anymore, it would not be a good benchmark if the goal is to check for regressions in that area. -- Jens Axboe From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:07:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:07:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397590.638211 (Exim 4.92) (envelope-from ) id 1oU6OR-0006tU-8k; Fri, 02 Sep 2022 13:07:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397590.638211; Fri, 02 Sep 2022 13:07:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6OR-0006tN-5q; Fri, 02 Sep 2022 13:07:31 +0000 Received: by outflank-mailman (input) for mailman id 397590; Fri, 02 Sep 2022 13:07:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6OQ-0006tD-6e; Fri, 02 Sep 2022 13:07:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6OQ-0006eJ-36; Fri, 02 Sep 2022 13:07:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6OP-000755-H9; Fri, 02 Sep 2022 13:07:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU6OP-0003NG-GS; Fri, 02 Sep 2022 13:07:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mIpHlBZ3kQ/IlNLR1FBDX5clGpsWMwHySVYBrwX5BfY=; b=ioT3XQE5X6xLRwiJC0pyXki5mi nSAzHS6uCgNqCE14DYmzniKYvVE6hVXnyBKNWbqCSBtwKet/BFE064vngYUzL+BwqqGjnNMK8U238 YDAA4gbsesMwg1ZN1YMOuztzvGsi/Hah//09dBckMVBod2r2ZZEMdly7p4fSqFmchSi0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172928: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-amd64-pygrub:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7dd9d7e0bd29abf590d1ac235c0a00606ef81153 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 02 Sep 2022 13:07:29 +0000 flight 172928 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 test-amd64-amd64-pygrub 21 guest-start/debian.repeat fail REGR. vs. 172123 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 7dd9d7e0bd29abf590d1ac235c0a00606ef81153 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 29 days Failing since 172148 2022-08-04 21:39:38 Z 28 days 65 attempts Testing same since 172928 2022-09-02 02:44:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub fail test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4167 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397602.638233 (Exim 4.92) (envelope-from ) id 1oU6YR-0000Fg-I3; Fri, 02 Sep 2022 13:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397602.638233; Fri, 02 Sep 2022 13:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YR-0000FY-FQ; Fri, 02 Sep 2022 13:17:51 +0000 Received: by outflank-mailman (input) for mailman id 397602; Fri, 02 Sep 2022 13:17:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YQ-0008Qk-1j for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:50 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3755e1d-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 895755C00DE; Fri, 2 Sep 2022 09:17:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 02 Sep 2022 09:17:47 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:46 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3755e1d-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124667; x=1662211067; bh=UjwBnOc1g+ 604LeBmJbINNFGx/iHztPfbL6nZ1PHHIs=; b=I8EV52P+O4bhSGTQlAuogNk4Dg g6UUYHvsoTtxoo6wsm198u6ko0a5vy+VNjqtoQDDvCMgfnFMeJSskhDFLcqDLkAH X929ir1Atv+1zkiOaq+lRrkNy2VKvxrWVYXioX9nn9hOGMa1n1FVi0lF3DGfVliO 3MALYjYLAUcz0CxsdhaI6mFS6IGBw9zF+cTCUYcbKWuAp9zziUm1X5+aPaxTa43/ DwhybuAHu4aaFjrASZOojHjXXlXhqWfY9KWxMWnvC02bza1mL0h+DMZZ8VXpyT6e 4edfzrBfTewpi7hTom2jkcITsocuQTbKsZ4jP9Uvrn1yMPrx/fCxdx2geRdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124667; x= 1662211067; bh=UjwBnOc1g+604LeBmJbINNFGx/iHztPfbL6nZ1PHHIs=; b=J ZMjXlt65yjEd5lDpBguwTaYT8aiTcBbP0aa2EzPDqWysgyiMvtDpcTKmPtrxuxTn tgtoXQugRO2+S/8mqPDIxCDqvIvcIDLRo2sP/CM1xM2n8kaAlADo+oLJdY4OoJCX DvE6vKh9iYBtzmaQCj690VrToSvrxCeRhHxBgAXQ96YnUeGSeR0en2XrFQvaKZVq 0Zp/dpcbmgOBYnQqiF5pxcdUa0DKIivFVxbTpiqTcR2eRb9g2dwo37Tcl7VH1qRV SA0sLVxyTvJWSFXzQlXOkXuhnQdjqQnmDR5FnclITudNeo6b9+RQ2Xe30WzLFpFf ukF1Us8nW7NjwaftpEoMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 02/10] console: support multiple serial console simultaneously Date: Fri, 2 Sep 2022 15:17:23 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously only one serial console was supported at the same time. Using console=com1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of MAX_SERCONS can be chosen in kconfig, the default (4) is arbitrary, inspired by the number of SERHND_IDX values. Make console_steal() aware of multiple consoles too. It can now either steal output from specific console (for gdbstub), or from all of them at once (for console suspend). Signed-off-by: Marek Marczykowski-Górecki --- Changes in v4: - use unsigned int for loop counters - other minor changes Changes in v3: - adjust console_steal() for multiple consoles too - add MAX_SERCONS to kconfig - add warning about sync_console impact - add warning if too many consoles are configured - log issue with PCI spec parsing --- docs/misc/xen-command-line.pandoc | 4 +- xen/drivers/char/Kconfig | 11 ++++- xen/drivers/char/console.c | 98 ++++++++++++++++++++++++-------- xen/include/xen/serial.h | 1 +- 4 files changed, 92 insertions(+), 22 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index c8b07042f58e..f6bdae9ca5f4 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -435,6 +435,9 @@ only available when used together with `pv-in-pvh`. `none` indicates that Xen should not use a console. This option only makes sense on its own. +Specifying more than one serial console will increase console latency, +especially when `sync_console` option is used. + ### console_timestamps > `= none | date | datems | boot | raw` @@ -2405,6 +2408,7 @@ vulnerabilities. Flag to force synchronous console output. Useful for debugging, but not suitable for production environments due to incurred overhead. +If multiple consoles are configured, the incurred overhead is even bigger. ### tboot (x86) > `= 0x` diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index 06350c387371..7b5ff0c414ec 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -85,6 +85,17 @@ config SERIAL_TX_BUFSIZE Default value is 16384 (16kiB). +config MAX_SERCONS + int "Maximum number of serial consoles active at once" + default 4 + help + Controls how many serial consoles can be active at once. Configuring more + using `console=` parameter will be ignored. + When multiple consoles are configured, overhead of `sync_console` option + is even bigger. + + Default value is 4. + config XHCI bool "XHCI DbC UART driver" depends on X86 diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index e8468c121ad0..60d42284f606 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -113,7 +113,9 @@ static char *__read_mostly conring = _conring; static uint32_t __read_mostly conring_size = _CONRING_SIZE; static uint32_t conringc, conringp; -static int __read_mostly sercon_handle = -1; +#define MAX_SERCONS CONFIG_MAX_SERCONS +static int __read_mostly sercon_handle[MAX_SERCONS]; +static unsigned int __read_mostly nr_sercon_handle = 0; #ifdef CONFIG_X86 /* Tristate: 0 disabled, 1 user enabled, -1 default enabled */ @@ -393,32 +395,61 @@ long read_console_ring(struct xen_sysctl_readconsole *op) static char serial_rx_ring[SERIAL_RX_SIZE]; static unsigned int serial_rx_cons, serial_rx_prod; -static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; +/* The last entry means "steal from all consoles" */ +static void (*serial_steal_fn[])(const char *, size_t nr) = { + [MAX_SERCONS] = early_puts, +}; +/* + * Redirect console *handle* output to *fn*. Use SERHND_STEAL_ALL as *handle* to + * redirect all the consoles. + */ int console_steal(int handle, void (*fn)(const char *, size_t nr)) { - if ( (handle == -1) || (handle != sercon_handle) ) - return 0; + unsigned int i; + + if ( handle == -1 ) + return -ENOENT; + if ( serial_steal_fn[MAX_SERCONS] != NULL ) + return -EBUSY; + if ( handle == SERHND_STEAL_ALL ) + { + serial_steal_fn[MAX_SERCONS] = fn; + return MAX_SERCONS; + } + for ( i = 0; i < nr_sercon_handle; i++ ) + if ( handle == sercon_handle[i] ) + break; + if ( i == nr_sercon_handle ) + return -ENOENT; - if ( serial_steal_fn != NULL ) + if ( serial_steal_fn[i] != NULL ) return -EBUSY; - serial_steal_fn = fn; - return 1; + serial_steal_fn[i] = fn; + return i; } void console_giveback(int id) { - if ( id == 1 ) - serial_steal_fn = NULL; + if ( id >= 0 && id <= MAX_SERCONS ) + serial_steal_fn[id] = NULL; } void console_serial_puts(const char *s, size_t nr) { - if ( serial_steal_fn != NULL ) - serial_steal_fn(s, nr); + unsigned int i; + + if ( serial_steal_fn[MAX_SERCONS] != NULL ) + serial_steal_fn[MAX_SERCONS](s, nr); else - serial_puts(sercon_handle, s, nr); + for ( i = 0; i < nr_sercon_handle; i++ ) + { + if ( serial_steal_fn[i] != NULL ) + serial_steal_fn[i](s, nr); + else + serial_puts(sercon_handle[i], s, nr); + } /* Copy all serial output into PV console */ pv_console_puts(s, nr); @@ -957,6 +988,7 @@ void __init console_init_preirq(void) { char *p; int sh; + unsigned int i; serial_init_preirq(); @@ -977,8 +1009,12 @@ void __init console_init_preirq(void) continue; else if ( (sh = serial_parse_handle(p)) >= 0 ) { - sercon_handle = sh; - serial_steal_fn = NULL; + if ( nr_sercon_handle < MAX_SERCONS ) + sercon_handle[nr_sercon_handle++] = sh; + else + printk("Too many consoles (max %d), ignoring '%s'\n", + MAX_SERCONS, p); + serial_steal_fn[MAX_SERCONS] = NULL; } else { @@ -996,7 +1032,8 @@ void __init console_init_preirq(void) opt_console_xen = 0; #endif - serial_set_rx_handler(sercon_handle, serial_rx); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_set_rx_handler(sercon_handle[i], serial_rx); pv_console_set_rx_handler(serial_rx); /* HELLO WORLD --- start-of-day banner text. */ @@ -1014,7 +1051,8 @@ void __init console_init_preirq(void) if ( opt_sync_console ) { - serial_start_sync(sercon_handle); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_sync(sercon_handle[i]); add_taint(TAINT_SYNC_CONSOLE); printk("Console output is synchronous.\n"); warning_add(warning_sync_console); @@ -1121,13 +1159,19 @@ int __init console_has(const char *device) void console_start_log_everything(void) { - serial_start_log_everything(sercon_handle); + unsigned int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_log_everything(sercon_handle[i]); atomic_inc(&print_everything); } void console_end_log_everything(void) { - serial_end_log_everything(sercon_handle); + unsigned int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_log_everything(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1149,23 +1193,32 @@ void console_unlock_recursive_irqrestore(unsigned long flags) void console_force_unlock(void) { + unsigned int i; + watchdog_disable(); spin_debug_disable(); spin_lock_init(&console_lock); - serial_force_unlock(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_force_unlock(sercon_handle[i]); console_locks_busted = 1; console_start_sync(); } void console_start_sync(void) { + unsigned int i; + atomic_inc(&print_everything); - serial_start_sync(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_start_sync(sercon_handle[i]); } void console_end_sync(void) { - serial_end_sync(sercon_handle); + unsigned int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_sync(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1291,7 +1344,8 @@ static int suspend_steal_id; int console_suspend(void) { - suspend_steal_id = console_steal(sercon_handle, suspend_steal_fn); + if ( nr_sercon_handle ) + suspend_steal_id = console_steal(SERHND_STEAL_ALL, suspend_steal_fn); serial_suspend(); return 0; } diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index f0aff7ea7661..226139841e71 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -100,6 +100,7 @@ struct uart_driver { #define SERHND_HI (1<<2) /* Mux/demux each transferred char by MSB. */ #define SERHND_LO (1<<3) /* Ditto, except that the MSB is cleared. */ #define SERHND_COOKED (1<<4) /* Newline/carriage-return translation? */ +#define SERHND_STEAL_ALL 0xff /* Synthetic handle used in console_steal() */ /* Three-stage initialisation (before/during/after IRQ-subsystem setup). */ void serial_init_preirq(void); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397601.638222 (Exim 4.92) (envelope-from ) id 1oU6YQ-0008RK-B0; Fri, 02 Sep 2022 13:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397601.638222; Fri, 02 Sep 2022 13:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YQ-0008RD-7s; Fri, 02 Sep 2022 13:17:50 +0000 Received: by outflank-mailman (input) for mailman id 397601; Fri, 02 Sep 2022 13:17:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YP-0008Qk-7i for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:49 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a182046f-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:45 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 12C0D5C00C6; Fri, 2 Sep 2022 09:17:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 02 Sep 2022 09:17:44 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:41 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a182046f-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1662124664; x=1662211064; bh=nIelx/7ZsvQKE+ntxO6p1c58nzAFexkrxQn uuZ1QjIc=; b=g4X5PHstvKwVrMkEe4+v+yiKVFmZv36JNuxSBuSwUhiD2oLl3eL JiX+UR9/XICDLfEka738bMFm0jRt2gmVwcxQ0e5Nvi6TE87CT2Iu7TQyUlHVS4Al VsHjD0kKH/Tx9r2jgx4kwIPGlXQDNdgyRYcNcTb95ntZ6vkfFqzJoJtXHjkAOWku RNV5B5SzgTSDINEeew+RnUXChVcoyw5Zy2lCgX9Zj5hfwTFj+sDQKHuIaPS6snRa uIBn/qXuZAhf7Q69lAINSdFUQmnZRw+ZT2lbQ74j6Km7oHIt8Cds4ifCZNlcQRDO /VpVnA84XQ++yhPF4NyRleMTa94FT5W8OcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1662124664; x=1662211064; bh=nIelx/7ZsvQKE +ntxO6p1c58nzAFexkrxQnuuZ1QjIc=; b=L3jf99cVPKras/8TTWmQboWWPC9Kk WJcUYOe2jdE0rD0nsaZjKEjPadqTl2OUoc4DW8mtttJFSkdLM9QxiBYWFJ5MRQ+s 361wY1zeGkNgYfN22dsps5bcj3SENGg8DjGB3owi7upMfJJmyma59b/OT8uBC435 7SNPxn1pr/fBC89O3dh4JlHSieHRemFdIeI+upW4pGz1JwA4sgYEUzAP9Wz4steW gLA7+In+0Hhj3ugDS280R4cvBRQ8VNKGyw6XEhA41+uzfrSfIeaZdqhc80jfrCpH X123fuxWJkXkJIevrSe/LoKGP8zFMObfmoZ5hZjz4zklDoUYeJZ4VkeNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefgffg geevhffggfetfefhffeuvefhvdevkeehkedttddtgeefkeduheevffduleenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Paul Durrant , Kevin Tian , Connor Davis Subject: [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability Date: Fri, 2 Sep 2022 15:17:21 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports console via USB3 debug capability. The capability is designed to operate mostly independently of normal XHCI driver, so this patch series allows dom0 to drive standard USB3 controller part, while Xen uses DbC for console output. Changes since RFC: - move the driver to xue.c, remove non-Xen parts, remove now unneeded abstraction - adjust for Xen code style - build for x86 only - drop patch hidding the device from dom0 Changes since v1: - drop ehci patch - already applied - adjust for review comments from Jan (see changelogs in individual patches) Changes since v2: - add runtime option to share (or not) the controller with dom0 or other domains - add RX support - several smaller changes according to review comments Changes since v3: - put controller sharing behind experimental kconfig option - several other changes according to review comments Changes since v4: - drop first 4 patches - already applied to staging - split dbgp=xhci into dbc=xhci Changes since v5: - roll dbc=xhci back into dbgp=xhci, but make it work together with dbgp=ehci Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Paul Durrant Cc: Kevin Tian Cc: Connor Davis Marek Marczykowski-Górecki (10): drivers/char: allow using both dbgp=xhci and dbgp=ehci console: support multiple serial console simultaneously IOMMU: add common API for device reserved memory IOMMU/VT-d: wire common device reserved memory API IOMMU/AMD: wire common device reserved memory API drivers/char: mark DMA buffers as reserved for the XHCI drivers/char: add RX support to the XHCI driver drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC drivers/char: fix handling cable re-plug in XHCI console driver drivers/char: use smp barriers in xhci driver docs/misc/xen-command-line.pandoc | 30 +- xen/drivers/char/Kconfig | 11 +- xen/drivers/char/console.c | 98 ++++-- xen/drivers/char/ehci-dbgp.c | 15 +- xen/drivers/char/serial.c | 6 +- xen/drivers/char/xhci-dbc.c | 364 +++++++++++++++++++++--- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +- xen/drivers/passthrough/iommu.c | 46 +++- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++------ xen/include/xen/iommu.h | 14 +- xen/include/xen/serial.h | 4 +- 11 files changed, 652 insertions(+), 158 deletions(-) base-commit: e997d055929665b12246e89eb092dc79c65de9a4 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397605.638257 (Exim 4.92) (envelope-from ) id 1oU6YT-0000jk-VI; Fri, 02 Sep 2022 13:17:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397605.638257; Fri, 02 Sep 2022 13:17:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YT-0000hc-Ki; Fri, 02 Sep 2022 13:17:53 +0000 Received: by outflank-mailman (input) for mailman id 397605; Fri, 02 Sep 2022 13:17:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YS-0008Qk-It for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:52 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a57bf8e8-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:51 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EB1385C00DE; Fri, 2 Sep 2022 09:17:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 02 Sep 2022 09:17:50 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:49 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a57bf8e8-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124670; x=1662211070; bh=/pD4K+B9L0 ba8VyhoGCQP8h4YWebGtRYWp1NDk3Q7sk=; b=tdaO6MNIL/4CTLnA2vlzLHSMZA wuiWWmcQ6wr8xBzp7snOTOvM4AP5LhWlD0PMqNK7MonOCdpCo3v4UqLspO1ysKCl JTnq5T34BdX/BAUATKtDGuNmLrd1T54o9+FUP+sBqKTxNOz4GpCwCegWNqsh3OpP 7/rYQUpAZk4T5jVgFUXwI8EG1NaEM3b5D2ktUYB4iMi9jJM3nDbRSlvla1sw2OV+ ULSoViZ/W+z59Ff2QTSFyl+F9yYR1JGm7zMHTX9tYb2QJ6Nkfzto1URcr4hZl5eF G531IPYi96d0vaD27+painYyqKZxIGWXoyCxdwERmGepErUX2GP7WHmEIhxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124670; x= 1662211070; bh=/pD4K+B9L0ba8VyhoGCQP8h4YWebGtRYWp1NDk3Q7sk=; b=C 2N30BQcvHdBuxA7Xou9GiHADYoZlniMDZtZjv/uaXGBhAEZuRBYVbQS1gYrn1YN3 jHV4PocAJJbIvxlNjIkbGPZ4ZO0+OU4NZ5AosuA0gPkbLHM+iyE6Ilrl2XY+46vw CqTWhONARdXpjr3UHC3HfdqneqmnvFFoHYJxovGkF+bN0CgREo8W0hLfKvTh1OjS xNlDe7+0zHbj0871qjib9H73sZ4GGBTjIqqJlr2vJfQz5Uvr8bPUWlpIrMkc00I7 d4GGBDwRS73Kr8ae89zfnfAYIMw2wpuru76cydhTEGvF/Ck2wteso4+jiHGwOz3b F39FJXRLNYD78uzD+Tlng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper Subject: [PATCH v6 05/10] IOMMU/AMD: wire common device reserved memory API Date: Fri, 2 Sep 2022 15:17:26 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Register common device reserved memory similar to how ivmd= parameter is handled. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v3: - use variable initializer - use pfn_to_paddr() --- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index ac6835225bae..3b577c9b390c 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -1078,6 +1078,25 @@ static inline bool_t is_ivmd_block(u8 type) type == ACPI_IVRS_TYPE_MEMORY_IOMMU); } +static int __init cf_check add_one_extra_ivmd(unsigned long start, + unsigned long nr, + uint32_t id, void *ctxt) +{ + struct acpi_ivrs_memory ivmd = { + .header = { + .length = sizeof(ivmd), + .flags = ACPI_IVMD_UNITY | ACPI_IVMD_READ | ACPI_IVMD_WRITE, + .device_id = id, + .type = ACPI_IVRS_TYPE_MEMORY_ONE, + }, + }; + + ivmd.start_address = pfn_to_paddr(start); + ivmd.memory_length = pfn_to_paddr(nr); + + return parse_ivmd_block(&ivmd); +} + static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) { const struct acpi_ivrs_header *ivrs_block; @@ -1121,6 +1140,8 @@ static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) AMD_IOMMU_DEBUG("IVMD: %u command line provided entries\n", nr_ivmd); for ( i = 0; !error && i < nr_ivmd; ++i ) error = parse_ivmd_block(user_ivmds + i); + if ( !error ) + error = iommu_get_extra_reserved_device_memory(add_one_extra_ivmd, NULL); /* Each IO-APIC must have been mentioned in the table. */ for ( apic = 0; !error && iommu_intremap && apic < nr_ioapics; ++apic ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397603.638244 (Exim 4.92) (envelope-from ) id 1oU6YS-0000W6-RI; Fri, 02 Sep 2022 13:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397603.638244; Fri, 02 Sep 2022 13:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YS-0000Vx-Nm; Fri, 02 Sep 2022 13:17:52 +0000 Received: by outflank-mailman (input) for mailman id 397603; Fri, 02 Sep 2022 13:17:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YR-0000AI-AB for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:51 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a3fed716-2ac1-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:17:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C63345C00F5; Fri, 2 Sep 2022 09:17:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 02 Sep 2022 09:17:48 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:47 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3fed716-2ac1-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124668; x=1662211068; bh=9gt4X0S6LT y3mZR525t0hd3leGbrVBuq9ANTQAYGNoU=; b=MiatnHshx5d6NgFfeYI+7o46Ue SPfZBFlm7w2UWQWZCQUW7WUEtty4PntBA8vUUlVY2bJQ4Y5CRvcKr5z8lEaSx3h8 qncssvHLqNdz1AIIaTOd9ao5mo1NKMJYg/ZXIkrJvxGhc/i/oC4v0rzvzeS7maBH tmMPgrO7+MWQF3pvdJvTzDAoImnhM5tNparXx3QltDF80bUtY74xSOIu5MzO9uIa RpzltLDzDtgm51RBU4kHKYGgWKqhLxWFGEXbmMoAxnTgWlJjxaw2NU1oSI0w5HU1 tomJdiHuKkJq0K29OfiR9+uX4O8Fa/Vk1nx3lRE2VDSjnJP90/4/b9L9HDag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124668; x= 1662211068; bh=9gt4X0S6LTy3mZR525t0hd3leGbrVBuq9ANTQAYGNoU=; b=b 4E8kppmTdE9TN6p3Kk9pvHk7Z68gAHJBaDhQJO+o6YAmIqqhcEa2z0HSK+1TUz0P GgVJ4QW4oS5SxfNGBG1i3lm5oHFk/BvrsCODxhzMaZ04yfB/QY8P087NmM8vToF5 X2a/OwPtGUK/miBURJFQ6aNi1dTt1NobDR5e4Llv5yn//hnUeyREP951GgOotjdR eLz8gCaxdVyG4kcvo2RLOuDNwvQL5K6saQnzJRF0fuxgjQnCRFXhNC8oR0QpIRF3 xYcv8J1JofGVUOVIJwjsWZqFuc/Tj4EY0JYBcnd+W/gVHgTKgJqLEChYv42dPMiZ g93R6e7T1uchZEtiee6vQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v6 03/10] IOMMU: add common API for device reserved memory Date: Fri, 2 Sep 2022 15:17:24 +0200 Message-Id: <3a1badcd90731d64950f4f80afbebbd042494f0b.1662124370.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add API similar to rmrr= and ivmd= arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for user-supplied reserved memory, and it may be useful for other drivers in the future too. This commit just introduces an API, subsequent patches will plug it in appropriate places. The reserved memory ranges needs to be saved locally, because at the point when they are collected, Xen doesn't know yet which IOMMU driver will be used. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v5: - fix indentation, keep full "reserved_device_memory" for consistency with iommu_get_reserved_device_memory Changes in v4: - mark functions as __init - use pci_sbdf_t type Changes in v3: - adjust code style --- xen/drivers/passthrough/iommu.c | 46 ++++++++++++++++++++++++++++++++++- xen/include/xen/iommu.h | 14 ++++++++++- 2 files changed, 60 insertions(+) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 134cdb47e0dc..5e2a720d29b9 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -669,6 +669,52 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } +#define MAX_EXTRA_RESERVED_RANGES 20 +struct extra_reserved_range { + unsigned long start; + unsigned long nr; + pci_sbdf_t sbdf; +}; +static unsigned int __initdata nr_extra_reserved_ranges; +static struct extra_reserved_range __initdata + extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; + +int __init iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + pci_sbdf_t sbdf) +{ + unsigned int idx; + + if ( nr_extra_reserved_ranges >= MAX_EXTRA_RESERVED_RANGES ) + return -ENOMEM; + + idx = nr_extra_reserved_ranges++; + extra_reserved_ranges[idx].start = start; + extra_reserved_ranges[idx].nr = nr; + extra_reserved_ranges[idx].sbdf = sbdf; + + return 0; +} + +int __init iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, + void *ctxt) +{ + unsigned int idx; + int ret; + + for ( idx = 0; idx < nr_extra_reserved_ranges; idx++ ) + { + ret = func(extra_reserved_ranges[idx].start, + extra_reserved_ranges[idx].nr, + extra_reserved_ranges[idx].sbdf.sbdf, + ctxt); + if ( ret < 0 ) + return ret; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 1240d7762d99..4f22fc1bed55 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -304,6 +304,20 @@ struct iommu_ops { #endif }; +/* + * To be called by Xen internally, to register extra RMRR/IVMD ranges. + * Needs to be called before IOMMU initialization. + */ +extern int iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + pci_sbdf_t sbdf); +/* + * To be called by specific IOMMU driver during initialization, + * to fetch ranges registered with iommu_add_extra_reserved_device_memory(). + */ +extern int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, + void *ctxt); + #include #ifndef iommu_call -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397604.638251 (Exim 4.92) (envelope-from ) id 1oU6YT-0000eA-H4; Fri, 02 Sep 2022 13:17:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397604.638251; Fri, 02 Sep 2022 13:17:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YT-0000d6-9X; Fri, 02 Sep 2022 13:17:53 +0000 Received: by outflank-mailman (input) for mailman id 397604; Fri, 02 Sep 2022 13:17:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YS-0000AI-23 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:52 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2493900-2ac1-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:17:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E6F3B5C0100; Fri, 2 Sep 2022 09:17:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 02 Sep 2022 09:17:45 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:44 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2493900-2ac1-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124665; x=1662211065; bh=P/446SguHG taplJg1g7ZVMbPb3ARpeZphSVBMP89Nyk=; b=juL0d31/WQdOxNE4NK5mXr2kC3 f2OAWkKQQtBPdsSL51gjVFZRywbDkIiK39AizGRo6W7iYeqgvsfAYoUioOAQN+LJ 1iTRdhLHdFq+//ThNDw7497c9PQqkIBo+y07/ca/W+uh9voAIxLBl5ZbNZbWTJhI k3/BgtvBBP12636kQcllczLaO3ULIuqjo/GDnOLtsYiA/UNbMyxEqWrm9N6a6isb jSBwe/SNQyYiJsmbTYAY0d5TDEhiaQToHaJqx05UR1YijvKEv6w17qi7tamFIay6 LFjAsraf1RS7y3ZrkiC2x2lqnDsx1GAqAHJoWLezj4GnvK2qDbLEeIgpHTbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124665; x= 1662211065; bh=P/446SguHGtaplJg1g7ZVMbPb3ARpeZphSVBMP89Nyk=; b=m t2z+hvunHDCLnxlwsQj7XmSOGuxtFQ1w9FmaK85z6Qh7abdSQcdBDfnpj52z2SUq iBM8V6DK7Dd6lb8g8Jy3pL51hv+lfzBY5KyzqPaMeK6mM50ZfHpO+OXmFUtqumnU oeKIgToHWhkqTIO196fnB+eufVgRTjDu/BqKhIjrFyTB+rMnpdLkzWfruD/j5qUg G5u1w3OOjp08xt/I1osi13xIwGkUBShmiTrnsCU1LEKEov5IBxuUKQ45NTIcq+Zf yvf1G0k2wQ2mfwmqwH75ks705BINWgCRDROsLfqjDCG2GgvPGZ1B7YJ9oqGI98OG pvZeJeghwDfvG0jsgnwzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci Date: Fri, 2 Sep 2022 15:17:22 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This allows configuring EHCI and XHCI consoles separately, simultaneously. This changes string_param() to custom_param() in both ehci and xhci drivers. Both drivers parse only values applicable to them. While at it, drop unnecessary memset() of a static variable. Suggested-by: Jan Beulich Signed-off-by: Marek Marczykowski-Górecki --- Changes in v6: - keep dbgp=xhci, but use custom_param() to parse multiple values separately - modify ehci-dbgp to use custom_param() too - change console=dbc to console=xhci, as 'dbc' doesn't appear in any other option anymore - update comment in serial.h new in v5 --- docs/misc/xen-command-line.pandoc | 6 ++++-- xen/drivers/char/ehci-dbgp.c | 15 +++++++++++++-- xen/drivers/char/serial.c | 6 ++++++ xen/drivers/char/xhci-dbc.c | 30 ++++++++++++++++++++---------- xen/include/xen/serial.h | 3 ++- 5 files changed, 45 insertions(+), 15 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 9a79385a3712..c8b07042f58e 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -409,7 +409,7 @@ The following are examples of correct specifications: Specify the size of the console ring buffer. ### console -> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | none ]` +> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | xhci | none ]` > Default: `console=com1,vga` @@ -428,7 +428,9 @@ cleared. This allows a single port to be shared by two subsystems `pv` indicates that Xen should use Xen's PV console. This option is only available when used together with `pv-in-pvh`. -`dbgp` indicates that Xen should use a USB debug port. +`dbgp` indicates that Xen should use a USB2 debug port. + +`xhci` indicates that Xen should use a USB3 debug port. `none` indicates that Xen should not use a console. This option only makes sense on its own. diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c index 92c588ec0aa3..b1794ed64c7b 100644 --- a/xen/drivers/char/ehci-dbgp.c +++ b/xen/drivers/char/ehci-dbgp.c @@ -1464,7 +1464,18 @@ static struct uart_driver __read_mostly ehci_dbgp_driver = { static struct ehci_dbgp ehci_dbgp = { .state = dbgp_unsafe, .phys_port = 1 }; static char __initdata opt_dbgp[30]; -string_param("dbgp", opt_dbgp); + +static int __init parse_ehci_dbgp(const char *opt) +{ + if ( strncmp(opt, "ehci", 4) ) + return 0; + + strlcpy(opt_dbgp, opt, sizeof(opt_dbgp)); + + return 0; +} + +custom_param("dbgp", parse_ehci_dbgp); void __init ehci_dbgp_init(void) { @@ -1472,7 +1483,7 @@ void __init ehci_dbgp_init(void) u32 debug_port, offset, bar_val; const char *e; - if ( strncmp(opt_dbgp, "ehci", 4) ) + if ( !opt_dbgp[0] ) return; if ( isdigit(opt_dbgp[4]) || !opt_dbgp[4] ) diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c index 47899222cef8..9d9445039232 100644 --- a/xen/drivers/char/serial.c +++ b/xen/drivers/char/serial.c @@ -311,6 +311,12 @@ int __init serial_parse_handle(const char *conf) goto common; } + if ( !strncmp(conf, "xhci", 4) && (!conf[4] || conf[4] == ',') ) + { + handle = SERHND_XHCI; + goto common; + } + if ( !strncmp(conf, "dtuart", 6) ) { handle = SERHND_DTUART; diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index ca7d4a62139e..8da76282259a 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -245,6 +245,7 @@ struct dbc { uint64_t xhc_dbc_offset; void __iomem *xhc_mmio; + bool enable; /* whether dbgp=xhci was set at all */ bool open; unsigned int xhc_num; /* look for n-th xhc */ }; @@ -1058,20 +1059,14 @@ static struct xhci_dbc_ctx ctx __aligned(16); static uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; -static char __initdata opt_dbgp[30]; - -string_param("dbgp", opt_dbgp); - -void __init xhci_dbc_uart_init(void) +static int __init xhci_parse_dbgp(const char *opt_dbgp) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; const char *e; if ( strncmp(opt_dbgp, "xhci", 4) ) - return; - - memset(dbc, 0, sizeof(*dbc)); + return 0; if ( isdigit(opt_dbgp[4]) ) { @@ -1087,12 +1082,27 @@ void __init xhci_dbc_uart_init(void) printk(XENLOG_ERR "Invalid dbgp= PCI device spec: '%s'\n", opt_dbgp + 8); - return; + return -EINVAL; } dbc->sbdf = PCI_SBDF(0, bus, slot, func); } + dbc->enable = true; + + return 0; +} + +custom_param("dbgp", xhci_parse_dbgp); + +void __init xhci_dbc_uart_init(void) +{ + struct dbc_uart *uart = &dbc_uart; + struct dbc *dbc = &uart->dbc; + + if ( !dbc->enable ) + return; + dbc->dbc_ctx = &ctx; dbc->dbc_erst = &erst; dbc->dbc_ering.trb = evt_trb; @@ -1102,7 +1112,7 @@ void __init xhci_dbc_uart_init(void) dbc->dbc_str = str_buf; if ( dbc_open(dbc) ) - serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); + serial_register_uart(SERHND_XHCI, &dbc_uart_driver, &dbc_uart); } #ifdef DBC_DEBUG diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 4cd4ae5e6f1c..f0aff7ea7661 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -91,10 +91,11 @@ struct uart_driver { }; /* 'Serial handles' are composed from the following fields. */ -#define SERHND_IDX (3<<0) /* COM1, COM2, DBGP, DTUART? */ +#define SERHND_IDX (3<<0) /* COM1, COM2, DBGP, XHCI, DTUART? */ # define SERHND_COM1 (0<<0) # define SERHND_COM2 (1<<0) # define SERHND_DBGP (2<<0) +# define SERHND_XHCI (3<<0) # define SERHND_DTUART (0<<0) /* Steal SERHND_COM1 value */ #define SERHND_HI (1<<2) /* Mux/demux each transferred char by MSB. */ #define SERHND_LO (1<<3) /* Ditto, except that the MSB is cleared. */ -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397606.638273 (Exim 4.92) (envelope-from ) id 1oU6YV-0001DI-48; Fri, 02 Sep 2022 13:17:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397606.638273; Fri, 02 Sep 2022 13:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YU-0001BX-VO; Fri, 02 Sep 2022 13:17:54 +0000 Received: by outflank-mailman (input) for mailman id 397606; Fri, 02 Sep 2022 13:17:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YT-0000AI-2E for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:53 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4951c85-2ac1-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:17:50 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BF1135C00F3; Fri, 2 Sep 2022 09:17:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 02 Sep 2022 09:17:49 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:48 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4951c85-2ac1-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124669; x=1662211069; bh=CFew235jgq 1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=XtOZzwiMiVGfW6+CoBAjZ4Uo6X tvxpY/LPPAsVsNMRZAAQVyF1bV47FsVpmHd52WN2N6zZB5lvN7I5qSDqHx5qUSIG 5bEyi02C+QjRHOvbCokzrf7syz/9XoL9dZJwjNcwv+NfIGUK6UvllAdOc0c8Nsss sXSvzuHliCX6+5JmucScY/DLtPIwmUAoBcxUiH9PVILegPza8jiPZmIW8a/G4EVU bkCYDKZIjbXoR/Uc5ILk9vfzWLgvd87+M6wwN26om6dunIyqpg5SXyiplKAp0jZJ SBPha4bTMCh3639cJ36SLA0k3AHZeESTRgGQh0UZ9l6ezEryB5lU0N2veT9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124669; x= 1662211069; bh=CFew235jgq1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=4 JAZKhhsAkNrCxSv//GVGt+/ktf+0G3DOthLxxNvX8+qjHV60ywWSjTP+Tvk1zcD4 reVd6UUeGzFzk5Xt3a0OV6G+l1rPKcGhAZRoGjwuoUp7rHesEOlp7S5YpqW2Ir/M Me8x4E6VlgUSeYeks1xHXsgH3EPIxsHGmL8FeGliTcYpOBrZsZ1kwVH4uW+icukI 4QEpWwFV4pRybLnP8M7V3K7vvlgYGx8kF57tlGA6IdEaang70g17S7PTsdLW2rqz Xw/4DGKtMDI1zoc+mP3wmp/OHBhz3dGXCopY//gp6eDyxhMbNhNFNrjj/y1eBiOw Ybgt74Y5aWhBkpOfTxTzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH v6 04/10] IOMMU/VT-d: wire common device reserved memory API Date: Fri, 2 Sep 2022 15:17:25 +0200 Message-Id: <5cf39b7b1990a8b1e8fe679cb46a4d5ec7ee3034.1662124370.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-use rmrr= parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- 1 file changed, 119 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 367304c8739c..3df5f6b69719 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -861,111 +861,139 @@ static struct user_rmrr __initdata user_rmrrs[MAX_USER_RMRR]; /* Macro for RMRR inclusive range formatting. */ #define ERMRRU_FMT "[%lx-%lx]" -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn +#define ERMRRU_ARG base_pfn, end_pfn + +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf); static int __init add_user_rmrr(void) { + unsigned int i; + int ret; + + for ( i = 0; i < nr_rmrr; i++ ) + { + ret = add_one_user_rmrr(user_rmrrs[i].base_pfn, + user_rmrrs[i].end_pfn, + user_rmrrs[i].dev_count, + user_rmrrs[i].sbdf); + if ( ret < 0 ) + return ret; + } + return 0; +} + +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf) +{ struct acpi_rmrr_unit *rmrr, *rmrru; - unsigned int idx, seg, i; - unsigned long base, end; + unsigned int idx, seg; + unsigned long base_iter; bool overlap; - for ( i = 0; i < nr_rmrr; i++ ) + if ( iommu_verbose ) + printk(XENLOG_DEBUG VTDPREFIX + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\n", + dev_count, sbdf[0], ERMRRU_ARG); + + if ( base_pfn > end_pfn ) { - base = user_rmrrs[i].base_pfn; - end = user_rmrrs[i].end_pfn; + printk(XENLOG_ERR VTDPREFIX + "Invalid RMRR Range "ERMRRU_FMT"\n", + ERMRRU_ARG); + return 0; + } - if ( base > end ) + overlap = false; + list_for_each_entry(rmrru, &acpi_rmrr_units, list) + { + if ( pfn_to_paddr(base_pfn) <= rmrru->end_address && + rmrru->base_address <= pfn_to_paddr(end_pfn) ) { printk(XENLOG_ERR VTDPREFIX - "Invalid RMRR Range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", + ERMRRU_ARG, + paddr_to_pfn(rmrru->base_address), + paddr_to_pfn(rmrru->end_address)); + overlap = true; + break; } + } + /* Don't add overlapping RMRR. */ + if ( overlap ) + return 0; - if ( (end - base) >= MAX_USER_RMRR_PAGES ) + base_iter = base_pfn; + do + { + if ( !mfn_valid(_mfn(base_iter)) ) { printk(XENLOG_ERR VTDPREFIX - "RMRR range "ERMRRU_FMT" exceeds "\ - __stringify(MAX_USER_RMRR_PAGES)" pages\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + break; } + } while ( base_iter++ < end_pfn ); - overlap = false; - list_for_each_entry(rmrru, &acpi_rmrr_units, list) - { - if ( pfn_to_paddr(base) <= rmrru->end_address && - rmrru->base_address <= pfn_to_paddr(end) ) - { - printk(XENLOG_ERR VTDPREFIX - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", - ERMRRU_ARG(user_rmrrs[i]), - paddr_to_pfn(rmrru->base_address), - paddr_to_pfn(rmrru->end_address)); - overlap = true; - break; - } - } - /* Don't add overlapping RMRR. */ - if ( overlap ) - continue; + /* Invalid pfn in range as the loop ended before end_pfn was reached. */ + if ( base_iter <= end_pfn ) + return 0; - do - { - if ( !mfn_valid(_mfn(base)) ) - { - printk(XENLOG_ERR VTDPREFIX - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - break; - } - } while ( base++ < end ); + rmrr = xzalloc(struct acpi_rmrr_unit); + if ( !rmrr ) + return -ENOMEM; - /* Invalid pfn in range as the loop ended before end_pfn was reached. */ - if ( base <= end ) - continue; + rmrr->scope.devices = xmalloc_array(u16, dev_count); + if ( !rmrr->scope.devices ) + { + xfree(rmrr); + return -ENOMEM; + } - rmrr = xzalloc(struct acpi_rmrr_unit); - if ( !rmrr ) - return -ENOMEM; + seg = 0; + for ( idx = 0; idx < dev_count; idx++ ) + { + rmrr->scope.devices[idx] = sbdf[idx]; + seg |= PCI_SEG(sbdf[idx]); + } + if ( seg != PCI_SEG(sbdf[0]) ) + { + printk(XENLOG_ERR VTDPREFIX + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + scope_devices_free(&rmrr->scope); + xfree(rmrr); + return 0; + } - rmrr->scope.devices = xmalloc_array(u16, user_rmrrs[i].dev_count); - if ( !rmrr->scope.devices ) - { - xfree(rmrr); - return -ENOMEM; - } + rmrr->segment = seg; + rmrr->base_address = pfn_to_paddr(base_pfn); + /* Align the end_address to the end of the page */ + rmrr->end_address = pfn_to_paddr(end_pfn) | ~PAGE_MASK; + rmrr->scope.devices_cnt = dev_count; - seg = 0; - for ( idx = 0; idx < user_rmrrs[i].dev_count; idx++ ) - { - rmrr->scope.devices[idx] = user_rmrrs[i].sbdf[idx]; - seg |= PCI_SEG(user_rmrrs[i].sbdf[idx]); - } - if ( seg != PCI_SEG(user_rmrrs[i].sbdf[0]) ) - { - printk(XENLOG_ERR VTDPREFIX - "Segments are not equal for RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - scope_devices_free(&rmrr->scope); - xfree(rmrr); - continue; - } + if ( register_one_rmrr(rmrr) ) + printk(XENLOG_ERR VTDPREFIX + "Could not register RMMR range "ERMRRU_FMT"\n", + ERMRRU_ARG); - rmrr->segment = seg; - rmrr->base_address = pfn_to_paddr(user_rmrrs[i].base_pfn); - /* Align the end_address to the end of the page */ - rmrr->end_address = pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAGE_MASK; - rmrr->scope.devices_cnt = user_rmrrs[i].dev_count; + return 1; +} - if ( register_one_rmrr(rmrr) ) - printk(XENLOG_ERR VTDPREFIX - "Could not register RMMR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - } +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) +{ + u32 sbdf_array[] = { id }; + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); +} - return 0; +static int __init add_extra_rmrr(void) +{ + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NULL); } #include @@ -1010,7 +1038,7 @@ int __init acpi_dmar_init(void) { iommu_init_ops = &intel_iommu_init_ops; - return add_user_rmrr(); + return add_user_rmrr() || add_extra_rmrr(); } return ret; @@ -1108,6 +1136,15 @@ static int __init cf_check parse_rmrr_param(const char *str) else end = start; + if ( (end - start) >= MAX_USER_RMRR_PAGES ) + { + printk(XENLOG_ERR VTDPREFIX + "RMRR range "ERMRRU_FMT" exceeds "\ + __stringify(MAX_USER_RMRR_PAGES)" pages\n", + start, end); + return -E2BIG; + } + user_rmrrs[nr_rmrr].base_pfn = start; user_rmrrs[nr_rmrr].end_pfn = end; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397607.638283 (Exim 4.92) (envelope-from ) id 1oU6YW-0001Pu-1b; Fri, 02 Sep 2022 13:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397607.638283; Fri, 02 Sep 2022 13:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YV-0001OZ-OA; Fri, 02 Sep 2022 13:17:55 +0000 Received: by outflank-mailman (input) for mailman id 397607; Fri, 02 Sep 2022 13:17:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YU-0008Qk-Hg for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:54 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a67b516d-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:53 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9A9EB5C00DF; Fri, 2 Sep 2022 09:17:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 02 Sep 2022 09:17:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a67b516d-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124672; x=1662211072; bh=VSr0av52FF /X96STc3yWhqiOBdkk8IpIl/76LTRVqS8=; b=bvJnfZONgbdEufAMPx0W/BddyU UTXbCqFPp0Lmy8qDJEPEDviSh7J+Bac5c1+tUpWlsRtABIwsyxzMcIyL2Mv8zlHk sC3D04ipDzNbTd0mdqTd5rs3tltqirW4coPOGC0B27TW7n3j5D4jIUSU7P6n215X TvXzpJ0OylCbwSCoKF3SXv3cBq3OrudeZ7guOyanqVrONhqYL9hlPdJcP13oaQrj uu82lSyrEmptxfTKBOnHR8cRDqCJ1kQK8jKRzB2RQ9y/Th++V6x6TcNYTBRs1dU0 e2ePcuKk1VqnZtnKhA34Wn4ZQWP/IHpK7ic3g9egRKn3LDvBTi6GQBHt++qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124672; x= 1662211072; bh=VSr0av52FF/X96STc3yWhqiOBdkk8IpIl/76LTRVqS8=; b=B XC/2KNbMOt//W1bN4mt0XvC2Lityps22BgHcoWptFd8r5UDbt/P0nNUCCsQPcV8j ZSQVFyfdFV3HaLKJP2UE5nENEkCtoZCEySo2Y6jDOSe1Dv4EJN4EDAEhzVY9INRj Hdi06pgxWr8KNuGpVHKIDkyQIVB2FQkFTCKJWYyyF5dFbojXOdx879jspziBd7Rz 5lyjh9yfG0vAeEtaM77qv974ZLz6crXljmbeU4Jf/S93XmtCKYLP5N4KHk5FcVUZ Fio+WXFSSKCetm6OHt3+NV0vjt89laz1sTcTE4xKwosKVLKAr2KWRNVi7CY4PsQn UXY/4C9/dt48w+DUOATRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 06/10] drivers/char: mark DMA buffers as reserved for the XHCI Date: Fri, 2 Sep 2022 15:17:27 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later patches), that domain will effectively have access to those buffers too. It does give such domain yet another way to DoS the system (as is the case when having PCI device assigned already), but also possibly steal the console ring content. Thus, such domain should be a trusted one. In any case, prevent anything else being placed on those pages by adding artificial padding. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v5: - add missing alignment Changes in v3: - adjust for xhci-dbc rename - do not raise MAX_USER_RMRR_PAGES - adjust alignment of DMA buffers --- xen/drivers/char/xhci-dbc.c | 43 +++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 14 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 8da76282259a..fc9745f7c2ac 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -1051,13 +1052,21 @@ static struct uart_driver dbc_uart_driver = { }; /* Those are accessed via DMA. */ -static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; -static struct xhci_erst_segment erst __aligned(16); -static struct xhci_dbc_ctx ctx __aligned(16); -static uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; -static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +struct dbc_dma_bufs { + struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; + struct xhci_trb out_trb[DBC_TRB_RING_CAP]; + struct xhci_trb in_trb[DBC_TRB_RING_CAP]; + uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; + struct xhci_erst_segment erst __aligned(16); + struct xhci_dbc_ctx ctx __aligned(16); + struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; + /* + * Don't place anything else on this page - it will be + * DMA-reachable by the USB controller. + */ +}; +static struct dbc_dma_bufs __section(".bss.page_aligned") __aligned(PAGE_SIZE) + dbc_dma_bufs; static int __init xhci_parse_dbgp(const char *opt_dbgp) { @@ -1103,16 +1112,22 @@ void __init xhci_dbc_uart_init(void) if ( !dbc->enable ) return; - dbc->dbc_ctx = &ctx; - dbc->dbc_erst = &erst; - dbc->dbc_ering.trb = evt_trb; - dbc->dbc_oring.trb = out_trb; - dbc->dbc_iring.trb = in_trb; - dbc->dbc_owork.buf = out_wrk_buf; - dbc->dbc_str = str_buf; + dbc->dbc_ctx = &dbc_dma_bufs.ctx; + dbc->dbc_erst = &dbc_dma_bufs.erst; + dbc->dbc_ering.trb = dbc_dma_bufs.evt_trb; + dbc->dbc_oring.trb = dbc_dma_bufs.out_trb; + dbc->dbc_iring.trb = dbc_dma_bufs.in_trb; + dbc->dbc_owork.buf = dbc_dma_bufs.out_wrk_buf; + dbc->dbc_str = dbc_dma_bufs.str_buf; if ( dbc_open(dbc) ) + { + iommu_add_extra_reserved_device_memory( + PFN_DOWN(virt_to_maddr(&dbc_dma_bufs)), + PFN_UP(sizeof(dbc_dma_bufs)), + uart->dbc.sbdf); serial_register_uart(SERHND_XHCI, &dbc_uart_driver, &dbc_uart); + } } #ifdef DBC_DEBUG -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397608.638299 (Exim 4.92) (envelope-from ) id 1oU6YY-0001xu-AQ; Fri, 02 Sep 2022 13:17:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397608.638299; Fri, 02 Sep 2022 13:17:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YY-0001xb-5v; Fri, 02 Sep 2022 13:17:58 +0000 Received: by outflank-mailman (input) for mailman id 397608; Fri, 02 Sep 2022 13:17:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YW-0000AI-5s for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:56 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a73937dd-2ac1-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:17:54 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 37AC95C00F5; Fri, 2 Sep 2022 09:17:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 02 Sep 2022 09:17:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:52 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a73937dd-2ac1-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124674; x=1662211074; bh=ZZ9BIZu9qK s+KPb2WpJ/gZIcmxFuDcvZaabjVF9MD4g=; b=RcS37mLq52/1OhfQ2WUvsq9tX5 Kq++tb+2EeBCWQ4qrpi3IGZxiXLU/cNYA3T2pO4Infs9SWwNcBmEWlhzya9h2/yL nG6qrGuaSeOWIohsLE8TaWx/bPv8aHuFd2DpOkkX1hg0Tk376G7Ix3E5celdeiS5 Zq7Zs+3u76cRjlUkEbrgqQ6UbD44yoSm/ixWLfp29cutHq8npkaLLZHFKsQ6SP2/ 6uY0SZ/cYFCejM1yEvR5K0NNzfuTZ8BTyep0ykEbfpOJNXXLpyBdONGu3dsUIzDy jZE6qZbprmKNGzIpY/5Vd4BoyRibTVJKlHepY1WvZm9Hq7tXAoVAduac7HUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124674; x= 1662211074; bh=ZZ9BIZu9qKs+KPb2WpJ/gZIcmxFuDcvZaabjVF9MD4g=; b=p hp/wGIb+mVHUdGnRxnDxDS9w6r0Mtw/pUPmve4zPFyv3ViXdG+WKT8yvdryQv2Vs 5x+x3F0GsfAjIb3i66bDTpjtQrqNIXFJYJe78ulHb4VWX7fsjAnZGFgUaUhPePjT 5vE419Z8LJiKttjkHY2TwTSTnDLO2mZ74EPFXwboVfnM+MnqEi++3tIzy3EpiHld +57WkB6+ymnQRrG7S2OQnkyyNf0oVDQL+7UwprLrKOz3h3bME6V63ox5hCyketXn ZZ6R/3GdkXgawl3sm+d8utHrI6BxxH/+N2RN3jZYQOg5gvjwEKllklZJeWyIpvg9 bVPWSNusRfPPrppEckuRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 07/10] drivers/char: add RX support to the XHCI driver Date: Fri, 2 Sep 2022 15:17:28 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add another work ring buffer for received data, and point IN TRB at it. Ensure there is always at least one pending IN TRB, so the controller has a way to send incoming data to the driver. Note that both "success" and "short packet" completion codes are okay - in fact it will be "short packet" most of the time, as the TRB length is about maximum size, not required size. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v4: - adjust return types - add some const New patch in v3 --- docs/misc/xen-command-line.pandoc | 6 +- xen/drivers/char/xhci-dbc.c | 129 +++++++++++++++++++++++++++++++- 2 files changed, 132 insertions(+), 3 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index f6bdae9ca5f4..fb4d80c590f3 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -731,9 +731,9 @@ Available alternatives, with their meaning, are: Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). -Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (output -only). XHCI driver will wait indefinitely for the debug host to connect - make -sure the cable is connected. +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability. +XHCI driver will wait indefinitely for the debug host to connect - make sure +the cable is connected. ### debug_stack_lines > `= ` diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index fc9745f7c2ac..557c5fc785ce 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -111,6 +111,7 @@ enum { enum { XHCI_TRB_CC_SUCCESS = 1, XHCI_TRB_CC_TRB_ERR = 5, + XHCI_TRB_CC_SHORT_PACKET = 13, }; /* DbC endpoint types */ @@ -239,6 +240,7 @@ struct dbc { struct xhci_trb_ring dbc_oring; struct xhci_trb_ring dbc_iring; struct dbc_work_ring dbc_owork; + struct dbc_work_ring dbc_iwork; struct xhci_string_descriptor *dbc_str; pci_sbdf_t sbdf; @@ -444,6 +446,16 @@ static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) trb->ctrl |= 0x20; } +static uint64_t xhci_trb_norm_buf(const struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_norm_len(const struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /** * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event * TRBs are read-only from software @@ -453,6 +465,17 @@ static uint64_t xhci_trb_tfre_ptr(const struct xhci_trb *trb) return trb->params; } +static uint32_t xhci_trb_tfre_cc(const struct xhci_trb *trb) +{ + return trb->status >> 24; +} + +/* Amount of data _not_ transferred */ +static uint32_t xhci_trb_tfre_len(const struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /* Fields for link TRBs (section 6.4.4.1) */ static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) { @@ -494,6 +517,14 @@ static bool xhci_trb_ring_full(const struct xhci_trb_ring *ring) return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) == ring->deq; } +static unsigned int xhci_trb_ring_size(const struct xhci_trb_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return ring->enq - ring->deq; + + return DBC_TRB_RING_CAP - ring->deq + ring->enq; +} + static bool dbc_work_ring_full(const struct dbc_work_ring *ring) { return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) == ring->deq; @@ -507,6 +538,14 @@ static unsigned int dbc_work_ring_size(const struct dbc_work_ring *ring) return DBC_WORK_RING_CAP - ring->deq + ring->enq; } +static unsigned int dbc_work_ring_space_to_end(const struct dbc_work_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return DBC_WORK_RING_CAP - ring->enq; + + return ring->deq - ring->enq; +} + static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, uint64_t dma, uint64_t len) { @@ -567,6 +606,31 @@ static unsigned int dbc_push_work(struct dbc *dbc, struct dbc_work_ring *ring, return i; } +static void dbc_rx_trb(struct dbc *dbc, struct xhci_trb *trb, + uint64_t not_transferred) +{ + struct dbc_work_ring *ring = &dbc->dbc_iwork; + unsigned int rx_len; + unsigned int end, start = ring->enq; + + if ( xhci_trb_type(trb) != XHCI_TRB_NORM ) + /* Can be Link TRB for example. */ + return; + + ASSERT(xhci_trb_norm_buf(trb) == ring->dma + ring->enq); + ASSERT(xhci_trb_norm_len(trb) >= not_transferred); + rx_len = xhci_trb_norm_len(trb) - not_transferred; + + /* It can hit the ring end, but should not wrap around. */ + ASSERT(ring->enq + rx_len <= DBC_WORK_RING_CAP); + ring->enq = (ring->enq + rx_len) & (DBC_WORK_RING_CAP - 1); + + end = ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); +} + /* * Note that if IN transfer support is added, then this * will need to be changed; it assumes an OUT transfer ring only @@ -576,6 +640,7 @@ static void dbc_pop_events(struct dbc *dbc) struct dbc_reg *reg = dbc->dbc_reg; struct xhci_trb_ring *er = &dbc->dbc_ering; struct xhci_trb_ring *tr = &dbc->dbc_oring; + struct xhci_trb_ring *ir = &dbc->dbc_iring; struct xhci_trb *event = &er->trb[er->deq]; uint64_t erdp = readq(®->erdp); uint32_t portsc; @@ -601,6 +666,14 @@ static void dbc_pop_events(struct dbc *dbc) trb_idx = (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; tr->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); } + else if ( event_ptr - ir->dma < DBC_TRB_RING_BYTES ) + { + trb_idx = (event_ptr - ir->dma) >> XHCI_TRB_SHIFT; + if ( xhci_trb_tfre_cc(event) == XHCI_TRB_CC_SUCCESS || + xhci_trb_tfre_cc(event) == XHCI_TRB_CC_SHORT_PACKET ) + dbc_rx_trb(dbc, &ir->trb[trb_idx], xhci_trb_tfre_len(event)); + ir->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } else dbc_alert("event: TRB 0x%lx not found in any ring\n", event_ptr); @@ -871,6 +944,7 @@ static bool __init dbc_open(struct dbc *dbc) return false; dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_init_work_ring(dbc, &dbc->dbc_iwork); dbc_enable_dbc(dbc); dbc->open = true; @@ -947,6 +1021,33 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, } /** + * Ensure DbC has a pending transfer TRB to receive data into. + * + * @param dbc the dbc to flush + * @param trb the ring for the TRBs to transfer + * @param wrk the work ring to receive data into + */ +static void dbc_enqueue_in(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t db = (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + /* Check if there is already queued TRB */ + if ( xhci_trb_ring_size(trb) >= 1 ) + return; + + if ( dbc_work_ring_full(wrk) ) + return; + + dbc_push_trb(dbc, trb, wrk->dma + wrk->enq, + dbc_work_ring_space_to_end(wrk)); + + wmb(); + writel(db, ®->db); +} + +/** * Queue a single character to the DbC. A transfer TRB will be created * if the character is a newline and the DbC will be notified that data is * available for writing to the debug host. @@ -969,6 +1070,19 @@ static int64_t dbc_putc(struct dbc *dbc, char c) return 1; } +static int dbc_getc(struct dbc *dbc, char *c) +{ + struct dbc_work_ring *wrk = &dbc->dbc_iwork; + + if ( dbc_work_ring_size(wrk) == 0 ) + return 0; + + *c = wrk->buf[wrk->deq]; + wrk->deq = (wrk->deq + 1) & (DBC_WORK_RING_CAP - 1); + + return 1; +} + struct dbc_uart { struct dbc dbc; struct timer timer; @@ -987,10 +1101,16 @@ static void cf_check dbc_uart_poll(void *data) if ( spin_trylock_irqsave(&port->tx_lock, flags) ) { if ( dbc_ensure_running(dbc) ) + { dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + dbc_enqueue_in(dbc, &dbc->dbc_iring, &dbc->dbc_iwork); + } spin_unlock_irqrestore(&port->tx_lock, flags); } + while ( dbc_work_ring_size(&dbc->dbc_iwork) ) + serial_rx_interrupt(port, guest_cpu_user_regs()); + serial_tx_interrupt(port, guest_cpu_user_regs()); set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); } @@ -1029,6 +1149,12 @@ static void cf_check dbc_uart_putc(struct serial_port *port, char c) dbc_putc(&uart->dbc, c); } +static int cf_check dbc_uart_getc(struct serial_port *port, char *c) +{ + struct dbc_uart *uart = port->uart; + return dbc_getc(&uart->dbc, c); +} + static void cf_check dbc_uart_flush(struct serial_port *port) { s_time_t goal; @@ -1048,6 +1174,7 @@ static struct uart_driver dbc_uart_driver = { .init_postirq = dbc_uart_init_postirq, .tx_ready = dbc_uart_tx_ready, .putc = dbc_uart_putc, + .getc = dbc_uart_getc, .flush = dbc_uart_flush, }; @@ -1057,6 +1184,7 @@ struct dbc_dma_bufs { struct xhci_trb out_trb[DBC_TRB_RING_CAP]; struct xhci_trb in_trb[DBC_TRB_RING_CAP]; uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; + uint8_t in_wrk_buf[DBC_WORK_RING_CAP]; struct xhci_erst_segment erst __aligned(16); struct xhci_dbc_ctx ctx __aligned(16); struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; @@ -1118,6 +1246,7 @@ void __init xhci_dbc_uart_init(void) dbc->dbc_oring.trb = dbc_dma_bufs.out_trb; dbc->dbc_iring.trb = dbc_dma_bufs.in_trb; dbc->dbc_owork.buf = dbc_dma_bufs.out_wrk_buf; + dbc->dbc_iwork.buf = dbc_dma_bufs.in_wrk_buf; dbc->dbc_str = dbc_dma_bufs.str_buf; if ( dbc_open(dbc) ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:17:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:17:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397609.638309 (Exim 4.92) (envelope-from ) id 1oU6YZ-0002G9-Qr; Fri, 02 Sep 2022 13:17:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397609.638309; Fri, 02 Sep 2022 13:17:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YZ-0002F9-KI; Fri, 02 Sep 2022 13:17:59 +0000 Received: by outflank-mailman (input) for mailman id 397609; Fri, 02 Sep 2022 13:17:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YX-0008Qk-QA for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:58 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a86032ab-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:56 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C60EE5C0140; Fri, 2 Sep 2022 09:17:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 02 Sep 2022 09:17:55 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:54 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a86032ab-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124675; x=1662211075; bh=jEhXVU2OZd QLanPulAJL30CKYwD6QKQqOYN+3xqQRKc=; b=IU8zwdteYyi12cGIOXh2CeiX0X g9lRddDnSOWr1Amm1hiCOSaSfWGtEkhnkX8hktbFo1VkK0PtBMv2Rm1T/2/VMUe/ ptuTuAotnaSz8+mkTp6vhlNGBGXnRH/TGlzGTi99p0mQv90Y1j6+dcaA7YMFrOzg CI3RCNqgrTRMh+AFQlJYhzbYr5J9lD2cwBrSD8v0FEIh8zz2o0QpW4cuoJpRMPF8 gd6o6P8HfEhLukWzY2Plx/SM+9aEflDyiR7Lwtk+wudb2czxfIMKPVBSyPMAfPa/ vXdFbEL7jidha3jN7dyu1HD5XQJId2HALs9S2VzaqAoh2hfcQwjSSOT28rRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124675; x= 1662211075; bh=jEhXVU2OZdQLanPulAJL30CKYwD6QKQqOYN+3xqQRKc=; b=n L0iHH4AVbglCweb9SqEJTZeh98XLFA2gd2RoOTxQIID8w3mlIK+V/cnrkEcTGF/G lO53p8AYDsadsVob6kH5Mpb3XMsca7ojOg1CZErwcVpSVtMSJz0ePFpLKqHHEysY 4pDqCm8sD5/TKS0/X+Z2lGntUgdDdzdNesq0dROkNgkH9icwp8Pf1KYV9tp0ABwI RcA7pgbCcVhelYp+HczHp8OX8Jbho/gcTDzW1r9Xa1usGSZ9/eOLkCFminF3NqEX YgvNMomPrDSiiByEhFHo52NE6TxijARoJHNnYKCEkT4hnNPmA7ePTGH+nZhWm38y GdkqjjSDXG+BUboKtUxrw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 08/10] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC Date: Fri, 2 Sep 2022 15:17:29 +0200 Message-Id: <5fc0395d7c67c534994f055b43cf9c2ad6ea6c67.1662124370.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack - re-enabling bus mastering behind dom0's backs. Linux driver does similar thing - see drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). When controller sharing is enabled in kconfig (option marked as experimental), dom0 is allowed to use the controller even if Xen uses it for debug console. Additionally, option `dbgp=xhci,share=` is available to either prevent even dom0 from using it (`no` value), or allow any domain using it (`any` value). In any case, to avoid Linux messing with the DbC, mark this MMIO area as read-only. This might cause issues for Linux's driver (if it tries to write something on the same page - like anoter xcap), but makes Xen's use safe. In practice, as of Linux 5.18, it seems to work without issues. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich --- Changes in v5: - drop CONFIG_XHCI_SHARE - make XHCI_SHARE_HWDOM = 0 - use parse_boolean - add comment about mmio_ro_ranges - fix doc Changes in v4: - minor fix for cmdline parsing - make sharing opt-in build time, with option marked as EXPERIMENTAL - change cmdline syntax to share=|hwdom - make share=hwdom default (if enabled build-time) Changes in v3: - adjust for xhci-dbc rename - adjust for dbc_ensure_running() split - wrap long lines - add runtime option for sharing USB controller --- docs/misc/xen-command-line.pandoc | 14 ++- xen/drivers/char/xhci-dbc.c | 129 +++++++++++++++++++++++++++++-- 2 files changed, 134 insertions(+), 9 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index fb4d80c590f3..1c755563c40d 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -726,7 +726,7 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` -> `= xhci[ | @pci:. ]` +> `= xhci[ | @pci:. ][,share=|hwdom]` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). @@ -734,6 +734,18 @@ over the PCI busses sequentially) or by PCI device (must be on segment 0). Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability. XHCI driver will wait indefinitely for the debug host to connect - make sure the cable is connected. +The `share` option for xhci controls who else can use the controller: +* `no`: use the controller exclusively for console, even hardware domain + (dom0) cannot use it +* `hwdom`: hardware domain may use the controller too, ports not used for debug + console will be available for normal devices; this is the default +* `yes`: the controller can be assigned to any domain; it is not safe to assign + the controller to untrusted domain + +Choosing `share=hwdom` (the default) or `share=yes` allows a domain to reset the +controller, which may cause small portion of the console output to be lost. + +The `share=yes` configuration is not security supported. ### debug_stack_lines > `= ` diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 557c5fc785ce..9f7e1dd60a78 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -232,6 +233,12 @@ struct dbc_work_ring { uint64_t dma; }; +enum xhci_share { + XHCI_SHARE_HWDOM = 0, + XHCI_SHARE_NONE, + XHCI_SHARE_ANY +}; + struct dbc { struct dbc_reg __iomem *dbc_reg; struct xhci_dbc_ctx *dbc_ctx; @@ -250,6 +257,7 @@ struct dbc { bool enable; /* whether dbgp=xhci was set at all */ bool open; + enum xhci_share share; unsigned int xhc_num; /* look for n-th xhc */ }; @@ -952,13 +960,56 @@ static bool __init dbc_open(struct dbc *dbc) } /* - * Ensure DbC is still running, handle events, and possibly re-enable if cable - * was re-plugged. Returns true if DbC is operational. + * Ensure DbC is still running, handle events, and possibly + * re-enable/re-configure if cable was re-plugged or controller was reset. + * Returns true if DbC is operational. */ static bool dbc_ensure_running(struct dbc *dbc) { struct dbc_reg *reg = dbc->dbc_reg; uint32_t ctrl; + uint16_t cmd; + + if ( dbc->share != XHCI_SHARE_NONE ) + { + /* + * Re-enable memory decoding and later bus mastering, if dom0 (or + * other) disabled it in the meantime. + */ + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MEMORY) ) + { + cmd |= PCI_COMMAND_MEMORY; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + + /* + * FIXME: Make Linux coordinate XHCI reset, so the DbC driver can + * prepare for it properly, instead of only detecting it after the + * fact. See EHCI driver for similar handling. + */ + if ( dbc->open && !(readl(®->ctrl) & (1U << DBC_CTRL_DCE)) ) + { + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + } + else + { + /* + * dbc_init_dbc() takes care about it, so check only if it wasn't + * called. + */ + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MASTER) ) + { + cmd |= PCI_COMMAND_MASTER; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + } + } dbc_pop_events(dbc); @@ -1129,10 +1180,38 @@ static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) init_timer(&uart->timer, dbc_uart_poll, port, 0); set_timer(&uart->timer, NOW() + MILLISECS(1)); - if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) - printk(XENLOG_WARNING - "Failed to mark read-only %pp used for XHCI console\n", - &uart->dbc.sbdf); + switch ( uart->dbc.share ) + { + case XHCI_SHARE_NONE: + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_HWDOM: + if ( pci_hide_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to hide %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_ANY: + /* Do not hide. */ + break; + } +#ifdef CONFIG_X86 + /* + * This marks the whole page as R/O, which may include other registers + * unrelated to DbC. Xen needs only DbC area protected, but it seems + * Linux's XHCI driver (as of 5.18) works without writting to the whole + * page, so keep it simple. + */ + if ( rangeset_add_range(mmio_ro_ranges, + PFN_DOWN(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset), + PFN_UP(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset + + sizeof(*uart->dbc.dbc_reg)) - 1) ) + printk(XENLOG_INFO + "Error while adding MMIO range of device to mmio_ro_ranges\n"); +#endif } static int cf_check dbc_uart_tx_ready(struct serial_port *port) @@ -1200,11 +1279,13 @@ static int __init xhci_parse_dbgp(const char *opt_dbgp) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; - const char *e; + const char *e, *opt; + int val; if ( strncmp(opt_dbgp, "xhci", 4) ) return 0; + e = &opt_dbgp[4]; if ( isdigit(opt_dbgp[4]) ) { dbc->xhc_num = simple_strtoul(opt_dbgp + 4, &e, 10); @@ -1214,7 +1295,7 @@ static int __init xhci_parse_dbgp(const char *opt_dbgp) unsigned int bus, slot, func; e = parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); - if ( !e || *e ) + if ( !e || (*e && *e != ',') ) { printk(XENLOG_ERR "Invalid dbgp= PCI device spec: '%s'\n", @@ -1224,6 +1305,38 @@ static int __init xhci_parse_dbgp(const char *opt_dbgp) dbc->sbdf = PCI_SBDF(0, bus, slot, func); } + opt = e; + + /* other options */ + while ( *opt == ',' ) + { + opt++; + e = strchr(opt, ','); + if ( !e ) + e = strchr(opt, '\0'); + + if ( (val = parse_boolean("share", opt, e)) != -1 ) + { + if ( val == -2 && !cmdline_strcmp(opt + 6, "hwdom") ) + dbc->share = XHCI_SHARE_HWDOM; + else if ( val == 0 ) + dbc->share = XHCI_SHARE_NONE; + else if ( val == 1 ) + dbc->share = XHCI_SHARE_ANY; + else + break; + } + else + break; + + opt = e; + } + + if ( *opt ) + { + printk(XENLOG_ERR "Invalid dbgp= parameters: '%s'\n", opt); + return -EINVAL; + } dbc->enable = true; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:18:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397610.638316 (Exim 4.92) (envelope-from ) id 1oU6Ya-0002RT-LF; Fri, 02 Sep 2022 13:18:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397610.638316; Fri, 02 Sep 2022 13:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6Ya-0002OP-F2; Fri, 02 Sep 2022 13:18:00 +0000 Received: by outflank-mailman (input) for mailman id 397610; Fri, 02 Sep 2022 13:17:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6YY-0008Qk-Sv for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:17:59 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a949c846-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:58 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 53DA45C00DF; Fri, 2 Sep 2022 09:17:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 02 Sep 2022 09:17:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:55 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a949c846-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124677; x=1662211077; bh=FT/9EaeivQ 6Yg0Q2MVnR1LdECut0xAgreZVi3/6Rzrs=; b=dYZzdvRf5MIoXjIPWqATS14Fx5 ISV/gzq+An9kBONWb/K8oAFpremfs0fAyDISlgQf7BcxhUA6zveYEQeWdf4gttok MDW6f9RnvDt9Wakm1BmTVlNRsLL5XoFQOCxpQG6CgZajwHAJaY9Yss00ias+RMu4 MV/p7E5REt9Erbvllo5Ojq9TJS2S32sxPrLVZUB+U+lT/bp6UzniZw1ggT96m+5f ctpYcZDasBsK23t/nlP/L2IZfUnr5pLtn79yj/PlMbo0krq5oY80/JuY8R0DEQ2Z 9L7QnoSDB1LgyYNzGXPO+uzoAC2hmH58l0PGmKYyI4sma7Hk3cXJ7msPNuug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124677; x= 1662211077; bh=FT/9EaeivQ6Yg0Q2MVnR1LdECut0xAgreZVi3/6Rzrs=; b=N vgc5yW0Tjb2kyfTYH2j7sftlaDHvjiaD311RHKMEXFW5cTWPW+YisU5La9ghcTpN KaNIIfM6egaUB8eTzcmo+a4xq7xb6yVm9vGWa/AgCyv38IxhecGsRrHIkjz9VAWe wHZ0QAfqFLywrPsqBOVygf3VoEKdmv0LNVqHtHqYvJTbEqJr4w8mQssp03i1jWy4 xyN76gc8L26hettC9WFuRik8Pvsgxuz5ebUD3mlBkq9pIsKj87qAaOZV1dOeSXE/ 6bEa4DdFEpRdJz97gp7TTPMRsyDea3cIBouYhild0cxPfWa1NDPt1fE+NjyvIHvM XfiQRJUlsN66Kpj4Jg3rQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 09/10] drivers/char: fix handling cable re-plug in XHCI console driver Date: Fri, 2 Sep 2022 15:17:30 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When cable is unplugged, dbc_ensure_running() correctly detects this situation (DBC_CTRL_DCR flag is clear), and prevent sending data immediately to the device. It gets only queued in work ring buffers. When cable is plugged in again, subsequent dbc_flush() will send the buffered data. But there is a corner case, where no subsequent data was buffered in the work buffer, but a TRB was still pending. Ring the doorbell to let the controller re-send them. For console output it is rare corner case (TRB is pending for a very short time), but for console input it is very normal case (there is always one pending TRB for input). Extract doorbell ringing into separate function to avoid duplication. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v6: - keep barriers consistent --- xen/drivers/char/xhci-dbc.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 9f7e1dd60a78..829f1d1d910f 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -554,6 +554,15 @@ static unsigned int dbc_work_ring_space_to_end(const struct dbc_work_ring *ring) return ring->deq - ring->enq; } +static void dbc_ring_doorbell(struct dbc *dbc, int doorbell) +{ + uint32_t __iomem *db_reg = &dbc->dbc_reg->db; + uint32_t db = (readl(db_reg) & ~DBC_DOORBELL_TARGET_MASK) | + (doorbell << DBC_DOORBELL_TARGET_SHIFT); + + writel(db, db_reg); +} + static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, uint64_t dma, uint64_t len) { @@ -1024,6 +1033,8 @@ static bool dbc_ensure_running(struct dbc *dbc) writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); wmb(); + dbc_ring_doorbell(dbc, dbc->dbc_iring.db); + dbc_ring_doorbell(dbc, dbc->dbc_oring.db); } return true; @@ -1041,10 +1052,6 @@ static bool dbc_ensure_running(struct dbc *dbc) static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, struct dbc_work_ring *wrk) { - struct dbc_reg *reg = dbc->dbc_reg; - uint32_t db = (readl(®->db) & ~DBC_DOORBELL_TARGET_MASK) | - (trb->db << DBC_DOORBELL_TARGET_SHIFT); - if ( xhci_trb_ring_full(trb) ) return; @@ -1068,7 +1075,7 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, } wmb(); - writel(db, ®->db); + dbc_ring_doorbell(dbc, trb->db); } /** -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:18:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:18:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397611.638329 (Exim 4.92) (envelope-from ) id 1oU6Yc-0002r8-KL; Fri, 02 Sep 2022 13:18:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397611.638329; Fri, 02 Sep 2022 13:18:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6Yc-0002oi-9P; Fri, 02 Sep 2022 13:18:02 +0000 Received: by outflank-mailman (input) for mailman id 397611; Fri, 02 Sep 2022 13:18:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6Ya-0008Qk-Io for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:18:00 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa413bd4-2ac1-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:17:59 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E76215C00DD; Fri, 2 Sep 2022 09:17:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 02 Sep 2022 09:17:58 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Sep 2022 09:17:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa413bd4-2ac1-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662124678; x=1662211078; bh=pEWUqxEj2m kIrRCvTAQi0Yzt/WUEwDzCu/7BJlYxh6A=; b=ElFWG///z1wqbpKkdQNnPsW8Er qFP9ZLwZKKqZPmKvmiZBEBDXQQneQXMwlwBT/rQPVDGX0W36MBxO02y5cQsA/TgQ pIFcpZD6Z4EPDIINj+9QoIZBNJIFd49Ui23JXIl6wlmAVOFEEc2hROgbL7qkWa+7 OHUsQVC6vVW/FMlFajEGoWSjJLKCbcuFxmmfhoylF98WdDufUXYSoDsVNIZBP9lt VgQ+z9ljZP2gYaW5uURthapsyHjPu7IaRpcRHTfF/yJRanpVJsPOAlA1C328+YfF VGmpFR8EFGq2O0L01lKpnr75+Ujn6kSkeIAnyczwzy5GTJHnZE4+VWzoteqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662124678; x= 1662211078; bh=pEWUqxEj2mkIrRCvTAQi0Yzt/WUEwDzCu/7BJlYxh6A=; b=j Hm1jHCb5X79ToZEa3aQ1IR17i2zIuTUxeP7rGJBwHd+4iGzQLRQOA96y/hIafJI8 DZ+ODjpvDUf2LSmEmliWsF+dzLekcJWNTdeOcZkqKSWrjv3ZI/TPYW4nVU14bPbW YItn9Q1ZHLaUAi4PHT+mW8QsIaJxfJk9mPrfxsMB7E8Lf9vf3TcTVJjxK/7WNFHG IqC1dDGq4OZqog3+A9zc17LIlq+RTxJpMISbCOp+mwEWr6XxvrRwQBIEoYHGuTbd Pqb92WyUfpw6XgJsEqQJZzd6qXJUXkULF9R07Mej3e0ol+jIMfZr2GZHKUcXbXxz WNT+fi0nIqUzKnnOWH3mg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeltddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 10/10] drivers/char: use smp barriers in xhci driver Date: Fri, 2 Sep 2022 15:17:31 +0200 Message-Id: <992c6512e54435a006c6de28515d1242518cb974.1662124370.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All (interesting) data is in plain WB cached memory, and the few BAR register that are configured have a UC mapping, which orders properly WRT other writes on x86. Suggested-by: Andrew Cooper Signed-off-by: Marek Marczykowski-Górecki --- New in v6 --- xen/drivers/char/xhci-dbc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 829f1d1d910f..03df4d82a623 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -666,7 +666,7 @@ static void dbc_pop_events(struct dbc *dbc) BUILD_BUG_ON((1 << XHCI_TRB_SHIFT) != sizeof(struct xhci_trb)); - rmb(); + smp_rmb(); while ( xhci_trb_cyc(event) == er->cyc ) { @@ -710,7 +710,7 @@ static void dbc_pop_events(struct dbc *dbc) } erdp = er->dma + (er->deq << XHCI_TRB_SHIFT); - wmb(); + smp_wmb(); writeq(erdp, ®->erdp); } @@ -847,9 +847,9 @@ static void dbc_enable_dbc(struct dbc *dbc) { struct dbc_reg *reg = dbc->dbc_reg; - wmb(); + smp_wmb(); writel(readl(®->ctrl) | (1U << DBC_CTRL_DCE), ®->ctrl); - wmb(); + smp_wmb(); while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCE)) == 0 ) cpu_relax(); @@ -858,9 +858,9 @@ static void dbc_enable_dbc(struct dbc *dbc) if ( !dbc->open ) dbc_reset_debug_port(dbc); - wmb(); + smp_wmb(); writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); - wmb(); + smp_wmb(); while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCR)) == 0 ) cpu_relax(); @@ -871,7 +871,7 @@ static void dbc_disable_dbc(struct dbc *dbc) struct dbc_reg *reg = dbc->dbc_reg; writel(readl(®->portsc) & ~(1U << DBC_PSC_PED), ®->portsc); - wmb(); + smp_wmb(); writel(readl(®->ctrl) & ~(1U << DBC_CTRL_DCE), ®->ctrl); while ( readl(®->ctrl) & (1U << DBC_CTRL_DCE) ) @@ -1032,7 +1032,7 @@ static bool dbc_ensure_running(struct dbc *dbc) { writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); - wmb(); + smp_wmb(); dbc_ring_doorbell(dbc, dbc->dbc_iring.db); dbc_ring_doorbell(dbc, dbc->dbc_oring.db); } @@ -1074,7 +1074,7 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, } } - wmb(); + smp_wmb(); dbc_ring_doorbell(dbc, trb->db); } @@ -1101,7 +1101,7 @@ static void dbc_enqueue_in(struct dbc *dbc, struct xhci_trb_ring *trb, dbc_push_trb(dbc, trb, wrk->dma + wrk->enq, dbc_work_ring_space_to_end(wrk)); - wmb(); + smp_wmb(); writel(db, ®->db); } -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:35:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:35:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397698.638345 (Exim 4.92) (envelope-from ) id 1oU6pH-0008PP-97; Fri, 02 Sep 2022 13:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397698.638345; Fri, 02 Sep 2022 13:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6pH-0008PI-6V; Fri, 02 Sep 2022 13:35:15 +0000 Received: by outflank-mailman (input) for mailman id 397698; Fri, 02 Sep 2022 13:35:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6pF-0008PC-TL for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:35:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 11cd76da-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:35:12 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E68A4ED1; Fri, 2 Sep 2022 06:35:17 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D35F63F766; Fri, 2 Sep 2022 06:35:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11cd76da-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Date: Fri, 2 Sep 2022 14:34:52 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series merge the applicable Linux fixes to Xen. Bixuan Cui (1): xen/arm: smmuv3: Change *array into *const array Christophe JAILLET (1): xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Gustavo A. R. Silva (1): xen/arm: smmuv3: Fix fall-through warning for Clang Jean-Philippe Brucker (2): xen/arm: smmuv3: Fix endianness annotations xen/arm: smmuv3: Move definitions to a header Robin Murphy (1): xen/arm: smmuv3: Remove the page 1 fixup Zenghui Yu (2): xen/arm: smmuv3: Fix l1 stream table size in the error message xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Zhen Lei (1): xen/arm: smmuv3: Remove unnecessary oom message Zhou Wang (1): xen/arm: smmuv3: Ensure queue is read after updating prod pointer xen/arch/arm/include/asm/system.h | 1 + xen/drivers/passthrough/arm/smmu-v3.c | 742 ++------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ 3 files changed, 708 insertions(+), 707 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:35:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397704.638357 (Exim 4.92) (envelope-from ) id 1oU6pn-0000UW-Ib; Fri, 02 Sep 2022 13:35:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397704.638357; Fri, 02 Sep 2022 13:35:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6pn-0000UP-Es; Fri, 02 Sep 2022 13:35:47 +0000 Received: by outflank-mailman (input) for mailman id 397704; Fri, 02 Sep 2022 13:35:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6pm-0000Sc-BR for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:35:46 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 24f3952b-2ac4-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:35:44 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9EBAED1; Fri, 2 Sep 2022 06:35:49 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 925ED3F766; Fri, 2 Sep 2022 06:35:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24f3952b-2ac4-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Zenghui Yu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v2 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message Date: Fri, 2 Sep 2022 14:34:53 +0100 Message-Id: <27ac197f803ea20d927c7d38de3ac8a7a676fe12.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zenghui Yu Backport Linux commit dc898eb84b25. This is the clean backport without any changes. The actual size of level-1 stream table is l1size. This looks like an oversight on commit d2e88e7c081ef ("iommu/arm-smmu: Fix LOG2SIZE setting for 2-level stream tables") which forgot to update the @size in error message as well. As memory allocation failure is already bad enough, nothing worse would happen. But let's be careful. Signed-off-by: Zenghui Yu Link: https://lore.kernel.org/r/20200826141758.341-1-yuzenghui@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc898eb84b25 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index f2562acc38..340609264d 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -2348,7 +2348,7 @@ static int arm_smmu_init_strtab_2lvl(struct arm_smmu_device *smmu) if (!strtab) { dev_err(smmu->dev, "failed to allocate l1 stream table (%u bytes)\n", - size); + l1size); return -ENOMEM; } cfg->strtab = strtab; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:36:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:36:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397708.638368 (Exim 4.92) (envelope-from ) id 1oU6q2-0000vR-RC; Fri, 02 Sep 2022 13:36:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397708.638368; Fri, 02 Sep 2022 13:36:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6q2-0000vK-Nb; Fri, 02 Sep 2022 13:36:02 +0000 Received: by outflank-mailman (input) for mailman id 397708; Fri, 02 Sep 2022 13:36:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6q1-0008PC-Du for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:36:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 2e5e0a77-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:36:00 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB5C0ED1; Fri, 2 Sep 2022 06:36:05 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 796933F766; Fri, 2 Sep 2022 06:35:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e5e0a77-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Jean-Philippe Brucker , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Robin Murphy , Will Deacon Subject: [PATCH v2 02/10] xen/arm: smmuv3: Fix endianness annotations Date: Fri, 2 Sep 2022 14:34:54 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jean-Philippe Brucker Backport Linux commit 376cdf66f624. This is the clean backport without any changes. When building with C=1, sparse reports some issues regarding endianness annotations: arm-smmu-v3.c:221:26: warning: cast to restricted __le64 arm-smmu-v3.c:221:24: warning: incorrect type in assignment (different base types) arm-smmu-v3.c:221:24: expected restricted __le64 [usertype] arm-smmu-v3.c:221:24: got unsigned long long [usertype] arm-smmu-v3.c:229:20: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:229:20: expected restricted __le64 [usertype] *[assigned] dst arm-smmu-v3.c:229:20: got unsigned long long [usertype] *ent arm-smmu-v3.c:229:25: warning: incorrect type in argument 2 (different base types) arm-smmu-v3.c:229:25: expected unsigned long long [usertype] *[assigned] src arm-smmu-v3.c:229:25: got restricted __le64 [usertype] * arm-smmu-v3.c:396:20: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:396:20: expected restricted __le64 [usertype] *[assigned] dst arm-smmu-v3.c:396:20: got unsigned long long * arm-smmu-v3.c:396:25: warning: incorrect type in argument 2 (different base types) arm-smmu-v3.c:396:25: expected unsigned long long [usertype] *[assigned] src arm-smmu-v3.c:396:25: got restricted __le64 [usertype] * arm-smmu-v3.c:1349:32: warning: invalid assignment: |= arm-smmu-v3.c:1349:32: left side has type restricted __le64 arm-smmu-v3.c:1349:32: right side has type unsigned long arm-smmu-v3.c:1396:53: warning: incorrect type in argument 3 (different base types) arm-smmu-v3.c:1396:53: expected restricted __le64 [usertype] *dst arm-smmu-v3.c:1396:53: got unsigned long long [usertype] *strtab arm-smmu-v3.c:1424:39: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:1424:39: expected unsigned long long [usertype] *[assigned] strtab arm-smmu-v3.c:1424:39: got restricted __le64 [usertype] *l2ptr While harmless, they are incorrect and could hide actual errors during development. Fix them. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Robin Murphy Link: https://lore.kernel.org/r/20200918141856.629722-1-jean-philippe@linaro.org Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 376cdf66f624 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 340609264d..64d39bb4d3 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1037,7 +1037,7 @@ static int queue_insert_raw(struct arm_smmu_queue *q, u64 *ent) return 0; } -static void queue_read(__le64 *dst, u64 *src, size_t n_dwords) +static void queue_read(u64 *dst, __le64 *src, size_t n_dwords) { int i; @@ -1436,7 +1436,7 @@ static void arm_smmu_write_strtab_ent(struct arm_smmu_master *master, u32 sid, arm_smmu_cmdq_issue_cmd(smmu, &prefetch_cmd); } -static void arm_smmu_init_bypass_stes(u64 *strtab, unsigned int nent) +static void arm_smmu_init_bypass_stes(__le64 *strtab, unsigned int nent) { unsigned int i; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:36:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:36:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397715.638380 (Exim 4.92) (envelope-from ) id 1oU6qL-0001Vk-6v; Fri, 02 Sep 2022 13:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397715.638380; Fri, 02 Sep 2022 13:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6qL-0001Vb-1B; Fri, 02 Sep 2022 13:36:21 +0000 Received: by outflank-mailman (input) for mailman id 397715; Fri, 02 Sep 2022 13:36:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6qJ-0008PC-5c for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:36:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 38e5c633-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:36:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9008EED1; Fri, 2 Sep 2022 06:36:23 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 474213F766; Fri, 2 Sep 2022 06:36:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38e5c633-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Zhou Wang , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Date: Fri, 2 Sep 2022 14:34:55 +0100 Message-Id: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhou Wang Backport Linux commit a76a37777f2c. This is the clean backport without any changes. Reading the 'prod' MMIO register in order to determine whether or not there is valid data beyond 'cons' for a given queue does not provide sufficient dependency ordering, as the resulting access is address dependent only on 'cons' and can therefore be speculated ahead of time, potentially allowing stale data to be read by the CPU. Use readl() instead of readl_relaxed() when updating the shadow copy of the 'prod' pointer, so that all speculated memory reads from the corresponding queue can occur only from valid slots. Signed-off-by: Zhou Wang Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg - add _iomb changes also from the origin patch --- xen/arch/arm/include/asm/system.h | 1 + xen/drivers/passthrough/arm/smmu-v3.c | 11 +++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/system.h b/xen/arch/arm/include/asm/system.h index 65d5c8e423..fe27cf8c5e 100644 --- a/xen/arch/arm/include/asm/system.h +++ b/xen/arch/arm/include/asm/system.h @@ -29,6 +29,7 @@ #endif #define smp_wmb() dmb(ishst) +#define __iomb() dmb(osh) #define smp_mb__before_atomic() smp_mb() #define smp_mb__after_atomic() smp_mb() diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 64d39bb4d3..cee13d1fc7 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -951,7 +951,7 @@ static void queue_sync_cons_out(struct arm_smmu_queue *q) * Ensure that all CPU accesses (reads and writes) to the queue * are complete before we update the cons pointer. */ - mb(); + __iomb(); writel_relaxed(q->llq.cons, q->cons_reg); } @@ -963,8 +963,15 @@ static void queue_inc_cons(struct arm_smmu_ll_queue *q) static int queue_sync_prod_in(struct arm_smmu_queue *q) { + u32 prod; int ret = 0; - u32 prod = readl_relaxed(q->prod_reg); + + /* + * We can't use the _relaxed() variant here, as we must prevent + * speculative reads of the queue before we have determined that + * prod has indeed moved. + */ + prod = readl(q->prod_reg); if (Q_OVF(prod) != Q_OVF(q->llq.prod)) ret = -EOVERFLOW; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:37:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:37:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397730.638390 (Exim 4.92) (envelope-from ) id 1oU6rI-0002HG-Kl; Fri, 02 Sep 2022 13:37:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397730.638390; Fri, 02 Sep 2022 13:37:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6rI-0002H9-Gc; Fri, 02 Sep 2022 13:37:20 +0000 Received: by outflank-mailman (input) for mailman id 397730; Fri, 02 Sep 2022 13:37:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6rH-0000Sc-I3 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:37:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5d0734a4-2ac4-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:37:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05A0E1516; Fri, 2 Sep 2022 06:37:24 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B230E3F766; Fri, 2 Sep 2022 06:37:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d0734a4-2ac4-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Robin Murphy , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v2 05/10] xen/arm: smmuv3: Remove the page 1 fixup Date: Fri, 2 Sep 2022 14:34:57 +0100 Message-Id: <5f6f8233ee5c27082aec27dfc06c6f600f0c5d55.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Robin Murphy Backport Linux commit 86d2d9214880. This is the clean backport without any changes. Since we now keep track of page 1 via a separate pointer that already encapsulates aliasing to page 0 as necessary, we can remove the clunky fixup routine and simply use the relevant bases directly. The current architecture spec (IHI0070D.a) defines SMMU_{EVENTQ,PRIQ}_{PROD,CONS} as offsets relative to page 1, so the cleanup represents a little bit of convergence as well as just lines of code saved. Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 86d2d9214880 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg. --- xen/drivers/passthrough/arm/smmu-v3.c | 42 ++++++++++----------------- xen/drivers/passthrough/arm/smmu-v3.h | 8 ++--- 2 files changed, 20 insertions(+), 30 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 85ad066266..f5485a8a1c 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -235,15 +235,6 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { { 0, NULL}, }; -static inline void __iomem *arm_smmu_page1_fixup(unsigned long offset, - struct arm_smmu_device *smmu) -{ - if (offset > SZ_64K) - return smmu->page1 + offset - SZ_64K; - - return smmu->base + offset; -} - static struct arm_smmu_domain *to_smmu_domain(struct iommu_domain *dom) { return container_of(dom, struct arm_smmu_domain, domain); @@ -1578,6 +1569,7 @@ static int arm_smmu_dt_xlate(struct device *dev, /* Probing and initialisation functions */ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, struct arm_smmu_queue *q, + void __iomem *page, unsigned long prod_off, unsigned long cons_off, size_t dwords, const char *name) @@ -1606,8 +1598,8 @@ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, 1 << q->llq.max_n_shift, name); } - q->prod_reg = arm_smmu_page1_fixup(prod_off, smmu); - q->cons_reg = arm_smmu_page1_fixup(cons_off, smmu); + q->prod_reg = page + prod_off; + q->cons_reg = page + prod_off; q->ent_dwords = dwords; q->q_base = Q_BASE_RWA; @@ -1624,16 +1616,16 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) /* cmdq */ spin_lock_init(&smmu->cmdq.lock); - ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, ARM_SMMU_CMDQ_PROD, - ARM_SMMU_CMDQ_CONS, CMDQ_ENT_DWORDS, - "cmdq"); + ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, smmu->base, + ARM_SMMU_CMDQ_PROD, ARM_SMMU_CMDQ_CONS, + CMDQ_ENT_DWORDS, "cmdq"); if (ret) return ret; /* evtq */ - ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, ARM_SMMU_EVTQ_PROD, - ARM_SMMU_EVTQ_CONS, EVTQ_ENT_DWORDS, - "evtq"); + ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, smmu->page1, + ARM_SMMU_EVTQ_PROD, ARM_SMMU_EVTQ_CONS, + EVTQ_ENT_DWORDS, "evtq"); if (ret) return ret; @@ -1641,9 +1633,9 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) if (!(smmu->features & ARM_SMMU_FEAT_PRI)) return 0; - return arm_smmu_init_one_queue(smmu, &smmu->priq.q, ARM_SMMU_PRIQ_PROD, - ARM_SMMU_PRIQ_CONS, PRIQ_ENT_DWORDS, - "priq"); + return arm_smmu_init_one_queue(smmu, &smmu->priq.q, smmu->page1, + ARM_SMMU_PRIQ_PROD, ARM_SMMU_PRIQ_CONS, + PRIQ_ENT_DWORDS, "priq"); } static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) @@ -2087,10 +2079,8 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) /* Event queue */ writeq_relaxed(smmu->evtq.q.q_base, smmu->base + ARM_SMMU_EVTQ_BASE); - writel_relaxed(smmu->evtq.q.llq.prod, - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_PROD, smmu)); - writel_relaxed(smmu->evtq.q.llq.cons, - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_CONS, smmu)); + writel_relaxed(smmu->evtq.q.llq.prod, smmu->page1 + ARM_SMMU_EVTQ_PROD); + writel_relaxed(smmu->evtq.q.llq.cons, smmu->page1 + ARM_SMMU_EVTQ_CONS); enables |= CR0_EVTQEN; ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, @@ -2105,9 +2095,9 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) writeq_relaxed(smmu->priq.q.q_base, smmu->base + ARM_SMMU_PRIQ_BASE); writel_relaxed(smmu->priq.q.llq.prod, - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_PROD, smmu)); + smmu->page1 + ARM_SMMU_PRIQ_PROD); writel_relaxed(smmu->priq.q.llq.cons, - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_CONS, smmu)); + smmu->page1 + ARM_SMMU_PRIQ_CONS); enables |= CR0_PRIQEN; ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h index c45d2f16c4..0742bc393f 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.h +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -130,15 +130,15 @@ #define ARM_SMMU_CMDQ_CONS 0x9c #define ARM_SMMU_EVTQ_BASE 0xa0 -#define ARM_SMMU_EVTQ_PROD 0x100a8 -#define ARM_SMMU_EVTQ_CONS 0x100ac +#define ARM_SMMU_EVTQ_PROD 0xa8 +#define ARM_SMMU_EVTQ_CONS 0xac #define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 #define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 #define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc #define ARM_SMMU_PRIQ_BASE 0xc0 -#define ARM_SMMU_PRIQ_PROD 0x100c8 -#define ARM_SMMU_PRIQ_CONS 0x100cc +#define ARM_SMMU_PRIQ_PROD 0xc8 +#define ARM_SMMU_PRIQ_CONS 0xcc #define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 #define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 #define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:37:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397731.638402 (Exim 4.92) (envelope-from ) id 1oU6rU-0002ei-UK; Fri, 02 Sep 2022 13:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397731.638402; Fri, 02 Sep 2022 13:37:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6rU-0002dl-PU; Fri, 02 Sep 2022 13:37:32 +0000 Received: by outflank-mailman (input) for mailman id 397731; Fri, 02 Sep 2022 13:37:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6rT-0002bO-H5 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:37:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6412f538-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:37:30 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A5B61516; Fri, 2 Sep 2022 06:37:36 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B6BAE3F766; Fri, 2 Sep 2022 06:37:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6412f538-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Zenghui Yu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v2 06/10] xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Date: Fri, 2 Sep 2022 14:34:58 +0100 Message-Id: <6e2951d4ec67a48d9e01c4b87289cfe56b00a345.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zenghui Yu Backport Linux commit e0bb4b735404. This is the clean backport without any changes. Per SMMUv3 spec, there is no Size and Addr field in the PREFETCH_CONFIG command and they're not used by the driver. Remove them. We can add them back if we're going to use PREFETCH_ADDR in the future. Signed-off-by: Zenghui Yu Link: https://lore.kernel.org/r/20210407084448.1838-1-yuzenghui@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e0bb4b735404 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 -- xen/drivers/passthrough/arm/smmu-v3.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index f5485a8a1c..2b04f73b87 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -402,8 +402,6 @@ static int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) break; case CMDQ_OP_PREFETCH_CFG: cmd[0] |= FIELD_PREP(CMDQ_PREFETCH_0_SID, ent->prefetch.sid); - cmd[1] |= FIELD_PREP(CMDQ_PREFETCH_1_SIZE, ent->prefetch.size); - cmd[1] |= ent->prefetch.addr & CMDQ_PREFETCH_1_ADDR_MASK; break; case CMDQ_OP_CFGI_STE: cmd[0] |= FIELD_PREP(CMDQ_CFGI_0_SID, ent->cfgi.sid); diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h index 0742bc393f..b381ad3738 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.h +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -456,8 +456,6 @@ struct arm_smmu_cmdq_ent { #define CMDQ_OP_PREFETCH_CFG 0x1 struct { u32 sid; - u8 size; - u64 addr; } prefetch; #define CMDQ_OP_CFGI_STE 0x3 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:38:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:38:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397742.638411 (Exim 4.92) (envelope-from ) id 1oU6sS-0003Pl-51; Fri, 02 Sep 2022 13:38:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397742.638411; Fri, 02 Sep 2022 13:38:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6sS-0003Pe-2U; Fri, 02 Sep 2022 13:38:32 +0000 Received: by outflank-mailman (input) for mailman id 397742; Fri, 02 Sep 2022 13:38:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6sQ-0003PW-Kx for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:38:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 87245b12-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:38:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAF301516; Fri, 2 Sep 2022 06:38:34 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82CE23F766; Fri, 2 Sep 2022 06:38:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87245b12-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Zhen Lei , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v2 08/10] xen/arm: smmuv3: Remove unnecessary oom message Date: Fri, 2 Sep 2022 14:35:00 +0100 Message-Id: <43ec5ca66040cea4783fe5608a68d667597ddb24.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhen Lei Backport Linux commit affa909571b0. This is the clean backport without any changes. Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210609125438.14369-1-thunder.leizhen@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git affa909571b0 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 9bd0c211c0..f8f0eeb528 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1644,10 +1644,8 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) void *strtab = smmu->strtab_cfg.strtab; cfg->l1_desc = _xzalloc(size, sizeof(void *)); - if (!cfg->l1_desc) { - dev_err(smmu->dev, "failed to allocate l1 stream table desc\n"); + if (!cfg->l1_desc) return -ENOMEM; - } for (i = 0; i < cfg->num_l1_ents; ++i) { arm_smmu_write_strtab_l1_desc(strtab, &cfg->l1_desc[i]); @@ -2432,10 +2430,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev) struct arm_smmu_device *smmu; smmu = xzalloc(struct arm_smmu_device); - if (!smmu) { - dev_err(pdev, "failed to allocate arm_smmu_device\n"); + if (!smmu) return -ENOMEM; - } smmu->dev = pdev; if (pdev->of_node) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:38:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:38:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397749.638422 (Exim 4.92) (envelope-from ) id 1oU6ss-0003xs-Cz; Fri, 02 Sep 2022 13:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397749.638422; Fri, 02 Sep 2022 13:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6ss-0003xl-A8; Fri, 02 Sep 2022 13:38:58 +0000 Received: by outflank-mailman (input) for mailman id 397749; Fri, 02 Sep 2022 13:38:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6sq-0003jF-Mu for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:38:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 97253a69-2ac4-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:38:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 803BA1515; Fri, 2 Sep 2022 06:39:01 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 373113F766; Fri, 2 Sep 2022 06:38:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97253a69-2ac4-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, "Gustavo A. R. Silva" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , kernel test robot Subject: [PATCH v2 09/10] xen/arm: smmuv3: Fix fall-through warning for Clang Date: Fri, 2 Sep 2022 14:35:01 +0100 Message-Id: <1a17c80becb0b2466efadef378d000f45debdc14.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Gustavo A. R. Silva" Backport Linux commit 5a1ab5c0299a. This is the clean backport without any changes. Fix the following fallthrough warning (arm64-randconfig with Clang): drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:382:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] Reported-by: kernel test robot Link: https://lore.kernel.org/lkml/60edca25.k00ut905IFBjPyt5%25lkp@intel.com/ Signed-off-by: Gustavo A. R. Silva Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5a1ab5c0299a Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg. --- xen/drivers/passthrough/arm/smmu-v3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index f8f0eeb528..6fb74d864e 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -489,6 +489,7 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) switch (idx) { case CMDQ_ERR_CERROR_ABT_IDX: dev_err(smmu->dev, "retrying command fetch\n"); + return; case CMDQ_ERR_CERROR_NONE_IDX: return; case CMDQ_ERR_CERROR_ATC_INV_IDX: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:39:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397752.638433 (Exim 4.92) (envelope-from ) id 1oU6sz-0004Ig-Kg; Fri, 02 Sep 2022 13:39:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397752.638433; Fri, 02 Sep 2022 13:39:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6sz-0004IX-Hf; Fri, 02 Sep 2022 13:39:05 +0000 Received: by outflank-mailman (input) for mailman id 397752; Fri, 02 Sep 2022 13:39:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6rs-0000Sc-E3 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:37:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 731c0d25-2ac4-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 15:37:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C00F1516; Fri, 2 Sep 2022 06:38:01 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C7F1F3F766; Fri, 2 Sep 2022 06:37:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 731c0d25-2ac4-11ed-82f2-63bd783d45fa From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Bixuan Cui , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v2 07/10] xen/arm: smmuv3: Change *array into *const array Date: Fri, 2 Sep 2022 14:34:59 +0100 Message-Id: <6ea753af191d7d187ba9675374f7571a855c381a.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bixuan Cui Backport Linux commit d56d5162e317. This is the clean backport without any changes. Fix checkpatch warning in arm-smmu-v3.c: static const char * array should probably be static const char * const Signed-off-by: Bixuan Cui Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d56d5162e317 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 2b04f73b87..9bd0c211c0 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -467,7 +467,7 @@ static int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) { - static const char *cerror_str[] = { + static const char * const cerror_str[] = { [CMDQ_ERR_CERROR_NONE_IDX] = "No error", [CMDQ_ERR_CERROR_ILL_IDX] = "Illegal command", [CMDQ_ERR_CERROR_ABT_IDX] = "Abort on command fetch", -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:39:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:39:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397754.638437 (Exim 4.92) (envelope-from ) id 1oU6sz-0004LW-U7; Fri, 02 Sep 2022 13:39:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397754.638437; Fri, 02 Sep 2022 13:39:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6sz-0004KS-QQ; Fri, 02 Sep 2022 13:39:05 +0000 Received: by outflank-mailman (input) for mailman id 397754; Fri, 02 Sep 2022 13:39:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6qr-0008PC-0X for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:36:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4c578e89-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:36:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 28138ED1; Fri, 2 Sep 2022 06:36:56 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EECC3F766; Fri, 2 Sep 2022 06:36:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c578e89-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Jean-Philippe Brucker , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Eric Auger , Jonathan Cameron , Will Deacon Subject: [PATCH v2 04/10] xen/arm: smmuv3: Move definitions to a header Date: Fri, 2 Sep 2022 14:34:56 +0100 Message-Id: <73362954b7395155c8287d2ea0737e132516cc90.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jean-Philippe Brucker Backport Linux commit e881e7839fba. This is the clean backport without any changes. Allow sharing structure definitions with the upcoming SVA support for Arm SMMUv3, by moving them to a separate header. We could surgically extract only what is needed but keeping all definitions in one place looks nicer. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Eric Auger Reviewed-by: Jonathan Cameron Link: https://lore.kernel.org/r/20200918101852.582559-8-jean-philippe@linaro.org Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e881e7839fba Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg - also move struct definition to header file to sync with Linux patch --- xen/drivers/passthrough/arm/smmu-v3.c | 666 +------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 674 ++++++++++++++++++++++++++ 2 files changed, 675 insertions(+), 665 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index cee13d1fc7..85ad066266 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -90,6 +90,7 @@ #include #include +#include "smmu-v3.h" #define ARM_SMMU_VTCR_SH_IS 3 #define ARM_SMMU_VTCR_RGN_WBWA 1 @@ -102,21 +103,10 @@ #define ARM_SMMU_VTCR_PS_48_BIT 0x5ULL #define ARM_SMMU_VTCR_PS_52_BIT 0x6ULL -/* Linux compatibility functions. */ -typedef paddr_t dma_addr_t; -typedef paddr_t phys_addr_t; -typedef unsigned int gfp_t; - #define platform_device device #define GFP_KERNEL 0 -/* Alias to Xen lock functions */ -#define mutex spinlock -#define mutex_init spin_lock_init -#define mutex_lock spin_lock -#define mutex_unlock spin_unlock - /* Device logger functions */ #define dev_name(dev) dt_node_full_name(dev->of_node) #define dev_dbg(dev, fmt, ...) \ @@ -157,12 +147,6 @@ typedef unsigned int gfp_t; #define readl_relaxed_poll_timeout(addr, val, cond, delay_us, timeout_us) \ readx_poll_timeout(readl_relaxed, addr, val, cond, delay_us, timeout_us) -#define FIELD_PREP(_mask, _val) \ - (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) - -#define FIELD_GET(_mask, _reg) \ - ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) - /* * Helpers for DMA allocation. Just the function name is reused for * porting code, these allocation are not managed allocations @@ -195,27 +179,6 @@ static void *dmam_alloc_coherent(struct device *dev, size_t size, return vaddr; } - -/* Xen specific code. */ -struct iommu_domain { - /* Runtime SMMU configuration for this iommu_domain */ - atomic_t ref; - /* - * Used to link iommu_domain contexts for a same domain. - * There is at least one per-SMMU to used by the domain. - */ - struct list_head list; -}; - -/* Describes information required for a Xen domain */ -struct arm_smmu_xen_domain { - spinlock_t lock; - - /* List of iommu domains associated to this domain */ - struct list_head contexts; -}; - - /* Keep a list of devices associated with this driver */ static DEFINE_SPINLOCK(arm_smmu_devices_lock); static LIST_HEAD(arm_smmu_devices); @@ -259,635 +222,8 @@ static int platform_get_irq_byname_optional(struct device *dev, } /* Start of Linux SMMUv3 code */ -/* MMIO registers */ -#define ARM_SMMU_IDR0 0x0 -#define IDR0_ST_LVL GENMASK(28, 27) -#define IDR0_ST_LVL_2LVL 1 -#define IDR0_STALL_MODEL GENMASK(25, 24) -#define IDR0_STALL_MODEL_STALL 0 -#define IDR0_STALL_MODEL_FORCE 2 -#define IDR0_TTENDIAN GENMASK(22, 21) -#define IDR0_TTENDIAN_MIXED 0 -#define IDR0_TTENDIAN_LE 2 -#define IDR0_TTENDIAN_BE 3 -#define IDR0_CD2L (1 << 19) -#define IDR0_VMID16 (1 << 18) -#define IDR0_PRI (1 << 16) -#define IDR0_SEV (1 << 14) -#define IDR0_MSI (1 << 13) -#define IDR0_ASID16 (1 << 12) -#define IDR0_ATS (1 << 10) -#define IDR0_HYP (1 << 9) -#define IDR0_COHACC (1 << 4) -#define IDR0_TTF GENMASK(3, 2) -#define IDR0_TTF_AARCH64 2 -#define IDR0_TTF_AARCH32_64 3 -#define IDR0_S1P (1 << 1) -#define IDR0_S2P (1 << 0) - -#define ARM_SMMU_IDR1 0x4 -#define IDR1_TABLES_PRESET (1 << 30) -#define IDR1_QUEUES_PRESET (1 << 29) -#define IDR1_REL (1 << 28) -#define IDR1_CMDQS GENMASK(25, 21) -#define IDR1_EVTQS GENMASK(20, 16) -#define IDR1_PRIQS GENMASK(15, 11) -#define IDR1_SSIDSIZE GENMASK(10, 6) -#define IDR1_SIDSIZE GENMASK(5, 0) - -#define ARM_SMMU_IDR5 0x14 -#define IDR5_STALL_MAX GENMASK(31, 16) -#define IDR5_GRAN64K (1 << 6) -#define IDR5_GRAN16K (1 << 5) -#define IDR5_GRAN4K (1 << 4) -#define IDR5_OAS GENMASK(2, 0) -#define IDR5_OAS_32_BIT 0 -#define IDR5_OAS_36_BIT 1 -#define IDR5_OAS_40_BIT 2 -#define IDR5_OAS_42_BIT 3 -#define IDR5_OAS_44_BIT 4 -#define IDR5_OAS_48_BIT 5 -#define IDR5_OAS_52_BIT 6 -#define IDR5_VAX GENMASK(11, 10) -#define IDR5_VAX_52_BIT 1 - -#define ARM_SMMU_CR0 0x20 -#define CR0_ATSCHK (1 << 4) -#define CR0_CMDQEN (1 << 3) -#define CR0_EVTQEN (1 << 2) -#define CR0_PRIQEN (1 << 1) -#define CR0_SMMUEN (1 << 0) - -#define ARM_SMMU_CR0ACK 0x24 - -#define ARM_SMMU_CR1 0x28 -#define CR1_TABLE_SH GENMASK(11, 10) -#define CR1_TABLE_OC GENMASK(9, 8) -#define CR1_TABLE_IC GENMASK(7, 6) -#define CR1_QUEUE_SH GENMASK(5, 4) -#define CR1_QUEUE_OC GENMASK(3, 2) -#define CR1_QUEUE_IC GENMASK(1, 0) -/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ -#define CR1_CACHE_NC 0 -#define CR1_CACHE_WB 1 -#define CR1_CACHE_WT 2 - -#define ARM_SMMU_CR2 0x2c -#define CR2_PTM (1 << 2) -#define CR2_RECINVSID (1 << 1) -#define CR2_E2H (1 << 0) - -#define ARM_SMMU_GBPA 0x44 -#define GBPA_UPDATE (1U << 31) -#define GBPA_ABORT (1 << 20) - -#define ARM_SMMU_IRQ_CTRL 0x50 -#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) -#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) -#define IRQ_CTRL_GERROR_IRQEN (1 << 0) - -#define ARM_SMMU_IRQ_CTRLACK 0x54 - -#define ARM_SMMU_GERROR 0x60 -#define GERROR_SFM_ERR (1 << 8) -#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) -#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) -#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) -#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) -#define GERROR_PRIQ_ABT_ERR (1 << 3) -#define GERROR_EVTQ_ABT_ERR (1 << 2) -#define GERROR_CMDQ_ERR (1 << 0) -#define GERROR_ERR_MASK 0xfd - -#define ARM_SMMU_GERRORN 0x64 - -#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 -#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 -#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 - -#define ARM_SMMU_STRTAB_BASE 0x80 -#define STRTAB_BASE_RA (1UL << 62) -#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) - -#define ARM_SMMU_STRTAB_BASE_CFG 0x88 -#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) -#define STRTAB_BASE_CFG_FMT_LINEAR 0 -#define STRTAB_BASE_CFG_FMT_2LVL 1 -#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) -#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) - -#define ARM_SMMU_CMDQ_BASE 0x90 -#define ARM_SMMU_CMDQ_PROD 0x98 -#define ARM_SMMU_CMDQ_CONS 0x9c - -#define ARM_SMMU_EVTQ_BASE 0xa0 -#define ARM_SMMU_EVTQ_PROD 0x100a8 -#define ARM_SMMU_EVTQ_CONS 0x100ac -#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 -#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 -#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc - -#define ARM_SMMU_PRIQ_BASE 0xc0 -#define ARM_SMMU_PRIQ_PROD 0x100c8 -#define ARM_SMMU_PRIQ_CONS 0x100cc -#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 -#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 -#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc - -#define ARM_SMMU_REG_SZ 0xe00 - -/* Common MSI config fields */ -#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) -#define MSI_CFG2_SH GENMASK(5, 4) -#define MSI_CFG2_MEMATTR GENMASK(3, 0) - -/* Common memory attribute values */ -#define ARM_SMMU_SH_NSH 0 -#define ARM_SMMU_SH_OSH 2 -#define ARM_SMMU_SH_ISH 3 -#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 -#define ARM_SMMU_MEMATTR_OIWB 0xf - -#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) -#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) -#define Q_OVERFLOW_FLAG (1U << 31) -#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) -#define Q_ENT(q, p) ((q)->base + \ - Q_IDX(&((q)->llq), p) * \ - (q)->ent_dwords) - -#define Q_BASE_RWA (1UL << 62) -#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) -#define Q_BASE_LOG2SIZE GENMASK(4, 0) - -/* Ensure DMA allocations are naturally aligned */ -#ifdef CONFIG_CMA_ALIGNMENT -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) -#else -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) -#endif - -/* - * Stream table. - * - * Linear: Enough to cover 1 << IDR1.SIDSIZE entries - * 2lvl: 128k L1 entries, - * 256 lazy entries per table (each table covers a PCI bus) - */ -#define STRTAB_L1_SZ_SHIFT 20 -#define STRTAB_SPLIT 8 - -#define STRTAB_L1_DESC_DWORDS 1 -#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) -#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) - -#define STRTAB_STE_DWORDS 8 -#define STRTAB_STE_0_V (1UL << 0) -#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) -#define STRTAB_STE_0_CFG_ABORT 0 -#define STRTAB_STE_0_CFG_BYPASS 4 -#define STRTAB_STE_0_CFG_S1_TRANS 5 -#define STRTAB_STE_0_CFG_S2_TRANS 6 - -#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) -#define STRTAB_STE_0_S1FMT_LINEAR 0 -#define STRTAB_STE_0_S1FMT_64K_L2 2 -#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) -#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) - -#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) -#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 -#define STRTAB_STE_1_S1DSS_BYPASS 0x1 -#define STRTAB_STE_1_S1DSS_SSID0 0x2 - -#define STRTAB_STE_1_S1C_CACHE_NC 0UL -#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL -#define STRTAB_STE_1_S1C_CACHE_WT 2UL -#define STRTAB_STE_1_S1C_CACHE_WB 3UL -#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) -#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) -#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) - -#define STRTAB_STE_1_S1STALLD (1UL << 27) - -#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) -#define STRTAB_STE_1_EATS_ABT 0UL -#define STRTAB_STE_1_EATS_TRANS 1UL -#define STRTAB_STE_1_EATS_S1CHK 2UL - -#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) -#define STRTAB_STE_1_STRW_NSEL1 0UL -#define STRTAB_STE_1_STRW_EL2 2UL - -#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) -#define STRTAB_STE_1_SHCFG_INCOMING 1UL - -#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) -#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) -#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) -#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) -#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) -#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) -#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) -#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) -#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) -#define STRTAB_STE_2_S2AA64 (1UL << 51) -#define STRTAB_STE_2_S2ENDI (1UL << 52) -#define STRTAB_STE_2_S2PTW (1UL << 54) -#define STRTAB_STE_2_S2R (1UL << 58) - -#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) - -/* - * Context descriptors. - * - * Linear: when less than 1024 SSIDs are supported - * 2lvl: at most 1024 L1 entries, - * 1024 lazy entries per table. - */ -#define CTXDESC_SPLIT 10 -#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) - -#define CTXDESC_L1_DESC_DWORDS 1 -#define CTXDESC_L1_DESC_V (1UL << 0) -#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) - -#define CTXDESC_CD_DWORDS 8 -#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) -#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) -#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) -#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) -#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) -#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) -#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) - -#define CTXDESC_CD_0_ENDI (1UL << 15) -#define CTXDESC_CD_0_V (1UL << 31) - -#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) -#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) - -#define CTXDESC_CD_0_AA64 (1UL << 41) -#define CTXDESC_CD_0_S (1UL << 44) -#define CTXDESC_CD_0_R (1UL << 45) -#define CTXDESC_CD_0_A (1UL << 46) -#define CTXDESC_CD_0_ASET (1UL << 47) -#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) - -#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) - -/* - * When the SMMU only supports linear context descriptor tables, pick a - * reasonable size limit (64kB). - */ -#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) - -/* Command queue */ -#define CMDQ_ENT_SZ_SHIFT 4 -#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) -#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) - -#define CMDQ_CONS_ERR GENMASK(30, 24) -#define CMDQ_ERR_CERROR_NONE_IDX 0 -#define CMDQ_ERR_CERROR_ILL_IDX 1 -#define CMDQ_ERR_CERROR_ABT_IDX 2 -#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 - -#define CMDQ_0_OP GENMASK_ULL(7, 0) -#define CMDQ_0_SSV (1UL << 11) - -#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) -#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) -#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) - -#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) -#define CMDQ_CFGI_1_LEAF (1UL << 0) -#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) - -#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) -#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) -#define CMDQ_TLBI_1_LEAF (1UL << 0) -#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) -#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) - -#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) -#define CMDQ_ATC_0_GLOBAL (1UL << 9) -#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) -#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) - -#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) -#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) -#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) - -#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) -#define CMDQ_SYNC_0_CS_NONE 0 -#define CMDQ_SYNC_0_CS_IRQ 1 -#define CMDQ_SYNC_0_CS_SEV 2 -#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) -#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) -#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) -#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) - -/* Event queue */ -#define EVTQ_ENT_SZ_SHIFT 5 -#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) -#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) - -#define EVTQ_0_ID GENMASK_ULL(7, 0) - -/* PRI queue */ -#define PRIQ_ENT_SZ_SHIFT 4 -#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) -#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) - -#define PRIQ_0_SID GENMASK_ULL(31, 0) -#define PRIQ_0_SSID GENMASK_ULL(51, 32) -#define PRIQ_0_PERM_PRIV (1UL << 58) -#define PRIQ_0_PERM_EXEC (1UL << 59) -#define PRIQ_0_PERM_READ (1UL << 60) -#define PRIQ_0_PERM_WRITE (1UL << 61) -#define PRIQ_0_PRG_LAST (1UL << 62) -#define PRIQ_0_SSID_V (1UL << 63) - -#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) -#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) - -/* High-level queue structures */ -#define ARM_SMMU_POLL_TIMEOUT_US 100 -#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ -#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 - static bool disable_bypass = 1; -enum pri_resp { - PRI_RESP_DENY = 0, - PRI_RESP_FAIL = 1, - PRI_RESP_SUCC = 2, -}; - -#ifdef CONFIG_MSI -enum arm_smmu_msi_index { - EVTQ_MSI_INDEX, - GERROR_MSI_INDEX, - PRIQ_MSI_INDEX, - ARM_SMMU_MAX_MSIS, -}; - -static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { - [EVTQ_MSI_INDEX] = { - ARM_SMMU_EVTQ_IRQ_CFG0, - ARM_SMMU_EVTQ_IRQ_CFG1, - ARM_SMMU_EVTQ_IRQ_CFG2, - }, - [GERROR_MSI_INDEX] = { - ARM_SMMU_GERROR_IRQ_CFG0, - ARM_SMMU_GERROR_IRQ_CFG1, - ARM_SMMU_GERROR_IRQ_CFG2, - }, - [PRIQ_MSI_INDEX] = { - ARM_SMMU_PRIQ_IRQ_CFG0, - ARM_SMMU_PRIQ_IRQ_CFG1, - ARM_SMMU_PRIQ_IRQ_CFG2, - }, -}; -#endif /* CONFIG_MSI */ - -struct arm_smmu_cmdq_ent { - /* Common fields */ - u8 opcode; - bool substream_valid; - - /* Command-specific fields */ - union { - #define CMDQ_OP_PREFETCH_CFG 0x1 - struct { - u32 sid; - u8 size; - u64 addr; - } prefetch; - - #define CMDQ_OP_CFGI_STE 0x3 - #define CMDQ_OP_CFGI_ALL 0x4 - struct { - u32 sid; - union { - bool leaf; - u8 span; - }; - } cfgi; - - #define CMDQ_OP_TLBI_EL2_ALL 0x20 - #define CMDQ_OP_TLBI_S12_VMALL 0x28 - #define CMDQ_OP_TLBI_S2_IPA 0x2a - #define CMDQ_OP_TLBI_NSNH_ALL 0x30 - struct { - u16 asid; - u16 vmid; - bool leaf; - u64 addr; - } tlbi; - - #define CMDQ_OP_ATC_INV 0x40 - #define ATC_INV_SIZE_ALL 52 - struct { - u32 sid; - u32 ssid; - u64 addr; - u8 size; - bool global; - } atc; - - #define CMDQ_OP_PRI_RESP 0x41 - struct { - u32 sid; - u32 ssid; - u16 grpid; - enum pri_resp resp; - } pri; - - #define CMDQ_OP_CMD_SYNC 0x46 - struct { - u32 msidata; - u64 msiaddr; - } sync; - }; -}; - -struct arm_smmu_ll_queue { - u32 prod; - u32 cons; - u32 max_n_shift; -}; - -struct arm_smmu_queue { - struct arm_smmu_ll_queue llq; - int irq; /* Wired interrupt */ - - __le64 *base; - dma_addr_t base_dma; - u64 q_base; - - size_t ent_dwords; - - u32 __iomem *prod_reg; - u32 __iomem *cons_reg; -}; - -struct arm_smmu_cmdq { - struct arm_smmu_queue q; - spinlock_t lock; -}; - -struct arm_smmu_evtq { - struct arm_smmu_queue q; - u32 max_stalls; -}; - -struct arm_smmu_priq { - struct arm_smmu_queue q; -}; - -/* High-level stream table and context descriptor structures */ -struct arm_smmu_strtab_l1_desc { - u8 span; - - __le64 *l2ptr; - dma_addr_t l2ptr_dma; -}; - -struct arm_smmu_s2_cfg { - u16 vmid; - u64 vttbr; - u64 vtcr; -}; - -struct arm_smmu_strtab_cfg { - __le64 *strtab; - dma_addr_t strtab_dma; - struct arm_smmu_strtab_l1_desc *l1_desc; - unsigned int num_l1_ents; - - u64 strtab_base; - u32 strtab_base_cfg; -}; - -struct arm_lpae_s2_cfg { - u64 vttbr; - struct { - u32 ps:3; - u32 tg:2; - u32 sh:2; - u32 orgn:2; - u32 irgn:2; - u32 sl:2; - u32 tsz:6; - } vtcr; -}; - -/* An SMMUv3 instance */ -struct arm_smmu_device { - struct device *dev; - void __iomem *base; - void __iomem *page1; - -#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) -#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) -#define ARM_SMMU_FEAT_TT_LE (1 << 2) -#define ARM_SMMU_FEAT_TT_BE (1 << 3) -#define ARM_SMMU_FEAT_PRI (1 << 4) -#define ARM_SMMU_FEAT_ATS (1 << 5) -#define ARM_SMMU_FEAT_SEV (1 << 6) -#define ARM_SMMU_FEAT_MSI (1 << 7) -#define ARM_SMMU_FEAT_COHERENCY (1 << 8) -#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) -#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) -#define ARM_SMMU_FEAT_STALLS (1 << 11) -#define ARM_SMMU_FEAT_HYP (1 << 12) -#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) -#define ARM_SMMU_FEAT_VAX (1 << 14) - u32 features; - -#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) -#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) - u32 options; - - struct arm_smmu_cmdq cmdq; - struct arm_smmu_evtq evtq; - struct arm_smmu_priq priq; - - int gerr_irq; - int combined_irq; - u32 sync_nr; - u8 prev_cmd_opcode; - - unsigned long ias; /* IPA */ - unsigned long oas; /* PA */ - unsigned long pgsize_bitmap; - -#define ARM_SMMU_MAX_VMIDS (1 << 16) - unsigned int vmid_bits; - DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); - - unsigned int sid_bits; - - struct arm_smmu_strtab_cfg strtab_cfg; - - /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ - union { - u32 sync_count; - u64 padding; - }; - - /* Need to keep a list of SMMU devices */ - struct list_head devices; - - /* Tasklets for handling evts/faults and pci page request IRQs*/ - struct tasklet evtq_irq_tasklet; - struct tasklet priq_irq_tasklet; - struct tasklet combined_irq_tasklet; -}; - -/* SMMU private data for each master */ -struct arm_smmu_master { - struct arm_smmu_device *smmu; - struct device *dev; - struct arm_smmu_domain *domain; - struct list_head domain_head; - u32 *sids; - unsigned int num_sids; - bool ats_enabled; -}; - -/* SMMU private data for an IOMMU domain */ -enum arm_smmu_domain_stage { - ARM_SMMU_DOMAIN_S1 = 0, - ARM_SMMU_DOMAIN_S2, - ARM_SMMU_DOMAIN_NESTED, - ARM_SMMU_DOMAIN_BYPASS, -}; - -struct arm_smmu_domain { - struct arm_smmu_device *smmu; - struct mutex init_mutex; /* Protects smmu pointer */ - - bool non_strict; - atomic_t nr_ats_masters; - - enum arm_smmu_domain_stage stage; - struct arm_smmu_s2_cfg s2_cfg; - - /* Xen domain associated with this SMMU domain */ - struct domain *d; - - struct iommu_domain domain; - - struct list_head devices; - spinlock_t devices_lock; -}; - struct arm_smmu_option_prop { u32 opt; const char *prop; diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h new file mode 100644 index 0000000000..c45d2f16c4 --- /dev/null +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -0,0 +1,674 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * IOMMU API for ARM architected SMMUv3 implementations. + * + * Copyright (C) 2022 ARM Limited + */ + +#ifndef _ARM_SMMU_V3_H +#define _ARM_SMMU_V3_H + +/* MMIO registers */ +#define ARM_SMMU_IDR0 0x0 +#define IDR0_ST_LVL GENMASK(28, 27) +#define IDR0_ST_LVL_2LVL 1 +#define IDR0_STALL_MODEL GENMASK(25, 24) +#define IDR0_STALL_MODEL_STALL 0 +#define IDR0_STALL_MODEL_FORCE 2 +#define IDR0_TTENDIAN GENMASK(22, 21) +#define IDR0_TTENDIAN_MIXED 0 +#define IDR0_TTENDIAN_LE 2 +#define IDR0_TTENDIAN_BE 3 +#define IDR0_CD2L (1 << 19) +#define IDR0_VMID16 (1 << 18) +#define IDR0_PRI (1 << 16) +#define IDR0_SEV (1 << 14) +#define IDR0_MSI (1 << 13) +#define IDR0_ASID16 (1 << 12) +#define IDR0_ATS (1 << 10) +#define IDR0_HYP (1 << 9) +#define IDR0_COHACC (1 << 4) +#define IDR0_TTF GENMASK(3, 2) +#define IDR0_TTF_AARCH64 2 +#define IDR0_TTF_AARCH32_64 3 +#define IDR0_S1P (1 << 1) +#define IDR0_S2P (1 << 0) + +#define ARM_SMMU_IDR1 0x4 +#define IDR1_TABLES_PRESET (1 << 30) +#define IDR1_QUEUES_PRESET (1 << 29) +#define IDR1_REL (1 << 28) +#define IDR1_CMDQS GENMASK(25, 21) +#define IDR1_EVTQS GENMASK(20, 16) +#define IDR1_PRIQS GENMASK(15, 11) +#define IDR1_SSIDSIZE GENMASK(10, 6) +#define IDR1_SIDSIZE GENMASK(5, 0) + +#define ARM_SMMU_IDR5 0x14 +#define IDR5_STALL_MAX GENMASK(31, 16) +#define IDR5_GRAN64K (1 << 6) +#define IDR5_GRAN16K (1 << 5) +#define IDR5_GRAN4K (1 << 4) +#define IDR5_OAS GENMASK(2, 0) +#define IDR5_OAS_32_BIT 0 +#define IDR5_OAS_36_BIT 1 +#define IDR5_OAS_40_BIT 2 +#define IDR5_OAS_42_BIT 3 +#define IDR5_OAS_44_BIT 4 +#define IDR5_OAS_48_BIT 5 +#define IDR5_OAS_52_BIT 6 +#define IDR5_VAX GENMASK(11, 10) +#define IDR5_VAX_52_BIT 1 + +#define ARM_SMMU_CR0 0x20 +#define CR0_ATSCHK (1 << 4) +#define CR0_CMDQEN (1 << 3) +#define CR0_EVTQEN (1 << 2) +#define CR0_PRIQEN (1 << 1) +#define CR0_SMMUEN (1 << 0) + +#define ARM_SMMU_CR0ACK 0x24 + +#define ARM_SMMU_CR1 0x28 +#define CR1_TABLE_SH GENMASK(11, 10) +#define CR1_TABLE_OC GENMASK(9, 8) +#define CR1_TABLE_IC GENMASK(7, 6) +#define CR1_QUEUE_SH GENMASK(5, 4) +#define CR1_QUEUE_OC GENMASK(3, 2) +#define CR1_QUEUE_IC GENMASK(1, 0) +/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ +#define CR1_CACHE_NC 0 +#define CR1_CACHE_WB 1 +#define CR1_CACHE_WT 2 + +#define ARM_SMMU_CR2 0x2c +#define CR2_PTM (1 << 2) +#define CR2_RECINVSID (1 << 1) +#define CR2_E2H (1 << 0) + +#define ARM_SMMU_GBPA 0x44 +#define GBPA_UPDATE (1 << 31) +#define GBPA_ABORT (1 << 20) + +#define ARM_SMMU_IRQ_CTRL 0x50 +#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) +#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) +#define IRQ_CTRL_GERROR_IRQEN (1 << 0) + +#define ARM_SMMU_IRQ_CTRLACK 0x54 + +#define ARM_SMMU_GERROR 0x60 +#define GERROR_SFM_ERR (1 << 8) +#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) +#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) +#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) +#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) +#define GERROR_PRIQ_ABT_ERR (1 << 3) +#define GERROR_EVTQ_ABT_ERR (1 << 2) +#define GERROR_CMDQ_ERR (1 << 0) +#define GERROR_ERR_MASK 0xfd + +#define ARM_SMMU_GERRORN 0x64 + +#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 +#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 +#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 + +#define ARM_SMMU_STRTAB_BASE 0x80 +#define STRTAB_BASE_RA (1UL << 62) +#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) + +#define ARM_SMMU_STRTAB_BASE_CFG 0x88 +#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) +#define STRTAB_BASE_CFG_FMT_LINEAR 0 +#define STRTAB_BASE_CFG_FMT_2LVL 1 +#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) +#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) + +#define ARM_SMMU_CMDQ_BASE 0x90 +#define ARM_SMMU_CMDQ_PROD 0x98 +#define ARM_SMMU_CMDQ_CONS 0x9c + +#define ARM_SMMU_EVTQ_BASE 0xa0 +#define ARM_SMMU_EVTQ_PROD 0x100a8 +#define ARM_SMMU_EVTQ_CONS 0x100ac +#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 +#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 +#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc + +#define ARM_SMMU_PRIQ_BASE 0xc0 +#define ARM_SMMU_PRIQ_PROD 0x100c8 +#define ARM_SMMU_PRIQ_CONS 0x100cc +#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 +#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 +#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc + +#define ARM_SMMU_REG_SZ 0xe00 + +/* Common MSI config fields */ +#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) +#define MSI_CFG2_SH GENMASK(5, 4) +#define MSI_CFG2_MEMATTR GENMASK(3, 0) + +/* Common memory attribute values */ +#define ARM_SMMU_SH_NSH 0 +#define ARM_SMMU_SH_OSH 2 +#define ARM_SMMU_SH_ISH 3 +#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 +#define ARM_SMMU_MEMATTR_OIWB 0xf + +#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) +#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) +#define Q_OVERFLOW_FLAG (1 << 31) +#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) +#define Q_ENT(q, p) ((q)->base + \ + Q_IDX(&((q)->llq), p) * \ + (q)->ent_dwords) + +#define Q_BASE_RWA (1UL << 62) +#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) +#define Q_BASE_LOG2SIZE GENMASK(4, 0) + +/* Ensure DMA allocations are naturally aligned */ +#ifdef CONFIG_CMA_ALIGNMENT +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) +#else +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) +#endif + +/* + * Stream table. + * + * Linear: Enough to cover 1 << IDR1.SIDSIZE entries + * 2lvl: 128k L1 entries, + * 256 lazy entries per table (each table covers a PCI bus) + */ +#define STRTAB_L1_SZ_SHIFT 20 +#define STRTAB_SPLIT 8 + +#define STRTAB_L1_DESC_DWORDS 1 +#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) +#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) + +#define STRTAB_STE_DWORDS 8 +#define STRTAB_STE_0_V (1UL << 0) +#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) +#define STRTAB_STE_0_CFG_ABORT 0 +#define STRTAB_STE_0_CFG_BYPASS 4 +#define STRTAB_STE_0_CFG_S1_TRANS 5 +#define STRTAB_STE_0_CFG_S2_TRANS 6 + +#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) +#define STRTAB_STE_0_S1FMT_LINEAR 0 +#define STRTAB_STE_0_S1FMT_64K_L2 2 +#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) +#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) + +#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) +#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 +#define STRTAB_STE_1_S1DSS_BYPASS 0x1 +#define STRTAB_STE_1_S1DSS_SSID0 0x2 + +#define STRTAB_STE_1_S1C_CACHE_NC 0UL +#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL +#define STRTAB_STE_1_S1C_CACHE_WT 2UL +#define STRTAB_STE_1_S1C_CACHE_WB 3UL +#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) +#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) +#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) + +#define STRTAB_STE_1_S1STALLD (1UL << 27) + +#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) +#define STRTAB_STE_1_EATS_ABT 0UL +#define STRTAB_STE_1_EATS_TRANS 1UL +#define STRTAB_STE_1_EATS_S1CHK 2UL + +#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) +#define STRTAB_STE_1_STRW_NSEL1 0UL +#define STRTAB_STE_1_STRW_EL2 2UL + +#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) +#define STRTAB_STE_1_SHCFG_INCOMING 1UL + +#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) +#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) +#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) +#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) +#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) +#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) +#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) +#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) +#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) +#define STRTAB_STE_2_S2AA64 (1UL << 51) +#define STRTAB_STE_2_S2ENDI (1UL << 52) +#define STRTAB_STE_2_S2PTW (1UL << 54) +#define STRTAB_STE_2_S2R (1UL << 58) + +#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) + +/* + * Context descriptors. + * + * Linear: when less than 1024 SSIDs are supported + * 2lvl: at most 1024 L1 entries, + * 1024 lazy entries per table. + */ +#define CTXDESC_SPLIT 10 +#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) + +#define CTXDESC_L1_DESC_DWORDS 1 +#define CTXDESC_L1_DESC_V (1UL << 0) +#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) + +#define CTXDESC_CD_DWORDS 8 +#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) +#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) +#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) +#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) +#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) +#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) +#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) + +#define CTXDESC_CD_0_ENDI (1UL << 15) +#define CTXDESC_CD_0_V (1UL << 31) + +#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) +#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) + +#define CTXDESC_CD_0_AA64 (1UL << 41) +#define CTXDESC_CD_0_S (1UL << 44) +#define CTXDESC_CD_0_R (1UL << 45) +#define CTXDESC_CD_0_A (1UL << 46) +#define CTXDESC_CD_0_ASET (1UL << 47) +#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) + +#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) + +/* + * When the SMMU only supports linear context descriptor tables, pick a + * reasonable size limit (64kB). + */ +#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) + +/* Command queue */ +#define CMDQ_ENT_SZ_SHIFT 4 +#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) +#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) + +#define CMDQ_CONS_ERR GENMASK(30, 24) +#define CMDQ_ERR_CERROR_NONE_IDX 0 +#define CMDQ_ERR_CERROR_ILL_IDX 1 +#define CMDQ_ERR_CERROR_ABT_IDX 2 +#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 + +#define CMDQ_0_OP GENMASK_ULL(7, 0) +#define CMDQ_0_SSV (1UL << 11) + +#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) +#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) +#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) + +#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) +#define CMDQ_CFGI_1_LEAF (1UL << 0) +#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) + +#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) +#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) +#define CMDQ_TLBI_1_LEAF (1UL << 0) +#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) +#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) + +#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) +#define CMDQ_ATC_0_GLOBAL (1UL << 9) +#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) +#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) + +#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) +#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) +#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) + +#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) +#define CMDQ_SYNC_0_CS_NONE 0 +#define CMDQ_SYNC_0_CS_IRQ 1 +#define CMDQ_SYNC_0_CS_SEV 2 +#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) +#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) +#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) +#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) + +/* Event queue */ +#define EVTQ_ENT_SZ_SHIFT 5 +#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) +#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) + +#define EVTQ_0_ID GENMASK_ULL(7, 0) + +/* PRI queue */ +#define PRIQ_ENT_SZ_SHIFT 4 +#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) +#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) + +#define PRIQ_0_SID GENMASK_ULL(31, 0) +#define PRIQ_0_SSID GENMASK_ULL(51, 32) +#define PRIQ_0_PERM_PRIV (1UL << 58) +#define PRIQ_0_PERM_EXEC (1UL << 59) +#define PRIQ_0_PERM_READ (1UL << 60) +#define PRIQ_0_PERM_WRITE (1UL << 61) +#define PRIQ_0_PRG_LAST (1UL << 62) +#define PRIQ_0_SSID_V (1UL << 63) + +#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) +#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) + +/* High-level queue structures */ +#define ARM_SMMU_POLL_TIMEOUT_US 100 +#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ +#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 + +#define FIELD_PREP(_mask, _val) \ + (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) + +#define FIELD_GET(_mask, _reg) \ + ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) + +/* Linux compatibility functions. */ +typedef paddr_t dma_addr_t; +typedef paddr_t phys_addr_t; +typedef unsigned int gfp_t; + +/* Alias to Xen lock functions */ +#define mutex spinlock +#define mutex_init spin_lock_init +#define mutex_lock spin_lock +#define mutex_unlock spin_unlock + +/* SMMU private data for an IOMMU domain */ +enum arm_smmu_domain_stage { + ARM_SMMU_DOMAIN_S1 = 0, + ARM_SMMU_DOMAIN_S2, + ARM_SMMU_DOMAIN_NESTED, + ARM_SMMU_DOMAIN_BYPASS, +}; + +/* Xen specific code. */ +struct iommu_domain { + /* Runtime SMMU configuration for this iommu_domain */ + atomic_t ref; + /* + * Used to link iommu_domain contexts for a same domain. + * There is at least one per-SMMU to used by the domain. + */ + struct list_head list; +}; + +/* Describes information required for a Xen domain */ +struct arm_smmu_xen_domain { + spinlock_t lock; + + /* List of iommu domains associated to this domain */ + struct list_head contexts; +}; + +enum pri_resp { + PRI_RESP_DENY = 0, + PRI_RESP_FAIL = 1, + PRI_RESP_SUCC = 2, +}; + +#ifdef CONFIG_MSI +enum arm_smmu_msi_index { + EVTQ_MSI_INDEX, + GERROR_MSI_INDEX, + PRIQ_MSI_INDEX, + ARM_SMMU_MAX_MSIS, +}; + +static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { + [EVTQ_MSI_INDEX] = { + ARM_SMMU_EVTQ_IRQ_CFG0, + ARM_SMMU_EVTQ_IRQ_CFG1, + ARM_SMMU_EVTQ_IRQ_CFG2, + }, + [GERROR_MSI_INDEX] = { + ARM_SMMU_GERROR_IRQ_CFG0, + ARM_SMMU_GERROR_IRQ_CFG1, + ARM_SMMU_GERROR_IRQ_CFG2, + }, + [PRIQ_MSI_INDEX] = { + ARM_SMMU_PRIQ_IRQ_CFG0, + ARM_SMMU_PRIQ_IRQ_CFG1, + ARM_SMMU_PRIQ_IRQ_CFG2, + }, +}; +#endif /* CONFIG_MSI */ + +struct arm_smmu_cmdq_ent { + /* Common fields */ + u8 opcode; + bool substream_valid; + + /* Command-specific fields */ + union { + #define CMDQ_OP_PREFETCH_CFG 0x1 + struct { + u32 sid; + u8 size; + u64 addr; + } prefetch; + + #define CMDQ_OP_CFGI_STE 0x3 + #define CMDQ_OP_CFGI_ALL 0x4 + struct { + u32 sid; + union { + bool leaf; + u8 span; + }; + } cfgi; + + #define CMDQ_OP_TLBI_EL2_ALL 0x20 + #define CMDQ_OP_TLBI_S12_VMALL 0x28 + #define CMDQ_OP_TLBI_S2_IPA 0x2a + #define CMDQ_OP_TLBI_NSNH_ALL 0x30 + struct { + u16 asid; + u16 vmid; + bool leaf; + u64 addr; + } tlbi; + + #define CMDQ_OP_ATC_INV 0x40 + #define ATC_INV_SIZE_ALL 52 + struct { + u32 sid; + u32 ssid; + u64 addr; + u8 size; + bool global; + } atc; + + #define CMDQ_OP_PRI_RESP 0x41 + struct { + u32 sid; + u32 ssid; + u16 grpid; + enum pri_resp resp; + } pri; + + #define CMDQ_OP_CMD_SYNC 0x46 + struct { + u32 msidata; + u64 msiaddr; + } sync; + }; +}; + +struct arm_smmu_ll_queue { + u32 prod; + u32 cons; + u32 max_n_shift; +}; + +struct arm_smmu_queue { + struct arm_smmu_ll_queue llq; + int irq; /* Wired interrupt */ + + __le64 *base; + dma_addr_t base_dma; + u64 q_base; + + size_t ent_dwords; + + u32 __iomem *prod_reg; + u32 __iomem *cons_reg; +}; + +struct arm_smmu_cmdq { + struct arm_smmu_queue q; + spinlock_t lock; +}; + +struct arm_smmu_evtq { + struct arm_smmu_queue q; + u32 max_stalls; +}; + +struct arm_smmu_priq { + struct arm_smmu_queue q; +}; + +/* High-level stream table and context descriptor structures */ +struct arm_smmu_strtab_l1_desc { + u8 span; + + __le64 *l2ptr; + dma_addr_t l2ptr_dma; +}; + +struct arm_smmu_s2_cfg { + u16 vmid; + u64 vttbr; + u64 vtcr; +}; + +struct arm_smmu_strtab_cfg { + __le64 *strtab; + dma_addr_t strtab_dma; + struct arm_smmu_strtab_l1_desc *l1_desc; + unsigned int num_l1_ents; + + u64 strtab_base; + u32 strtab_base_cfg; +}; + +struct arm_lpae_s2_cfg { + u64 vttbr; + struct { + u32 ps:3; + u32 tg:2; + u32 sh:2; + u32 orgn:2; + u32 irgn:2; + u32 sl:2; + u32 tsz:6; + } vtcr; +}; + +/* An SMMUv3 instance */ +struct arm_smmu_device { + struct device *dev; + void __iomem *base; + void __iomem *page1; + +#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) +#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) +#define ARM_SMMU_FEAT_TT_LE (1 << 2) +#define ARM_SMMU_FEAT_TT_BE (1 << 3) +#define ARM_SMMU_FEAT_PRI (1 << 4) +#define ARM_SMMU_FEAT_ATS (1 << 5) +#define ARM_SMMU_FEAT_SEV (1 << 6) +#define ARM_SMMU_FEAT_MSI (1 << 7) +#define ARM_SMMU_FEAT_COHERENCY (1 << 8) +#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) +#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) +#define ARM_SMMU_FEAT_STALLS (1 << 11) +#define ARM_SMMU_FEAT_HYP (1 << 12) +#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) +#define ARM_SMMU_FEAT_VAX (1 << 14) + u32 features; + +#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) +#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) + u32 options; + + struct arm_smmu_cmdq cmdq; + struct arm_smmu_evtq evtq; + struct arm_smmu_priq priq; + + int gerr_irq; + int combined_irq; + u32 sync_nr; + u8 prev_cmd_opcode; + + unsigned long ias; /* IPA */ + unsigned long oas; /* PA */ + unsigned long pgsize_bitmap; + +#define ARM_SMMU_MAX_VMIDS (1 << 16) + unsigned int vmid_bits; + DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); + + unsigned int sid_bits; + + struct arm_smmu_strtab_cfg strtab_cfg; + + /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ + union { + u32 sync_count; + u64 padding; + }; + + /* Need to keep a list of SMMU devices */ + struct list_head devices; + + /* Tasklets for handling evts/faults and pci page request IRQs*/ + struct tasklet evtq_irq_tasklet; + struct tasklet priq_irq_tasklet; + struct tasklet combined_irq_tasklet; +}; + +/* SMMU private data for each master */ +struct arm_smmu_master { + struct arm_smmu_device *smmu; + struct device *dev; + struct arm_smmu_domain *domain; + struct list_head domain_head; + u32 *sids; + unsigned int num_sids; + bool ats_enabled; +}; + +struct arm_smmu_domain { + struct arm_smmu_device *smmu; + struct mutex init_mutex; /* Protects smmu pointer */ + + bool non_strict; + atomic_t nr_ats_masters; + + enum arm_smmu_domain_stage stage; + struct arm_smmu_s2_cfg s2_cfg; + + /* Xen domain associated with this SMMU domain */ + struct domain *d; + + struct iommu_domain domain; + + struct list_head devices; + spinlock_t devices_lock; +}; + +#endif /* _ARM_SMMU_V3_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 13:39:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 13:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397757.638457 (Exim 4.92) (envelope-from ) id 1oU6t4-0004vc-JP; Fri, 02 Sep 2022 13:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397757.638457; Fri, 02 Sep 2022 13:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6t4-0004vN-CZ; Fri, 02 Sep 2022 13:39:10 +0000 Received: by outflank-mailman (input) for mailman id 397757; Fri, 02 Sep 2022 13:39:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU6t2-0004rV-Ki for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 13:39:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9dfbf6e1-2ac4-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 15:39:07 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 360E51515; Fri, 2 Sep 2022 06:39:13 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C89B23F766; Fri, 2 Sep 2022 06:39:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dfbf6e1-2ac4-11ed-934f-f50d60e1c1bd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Christophe JAILLET , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Robin Murphy , Will Deacon Subject: [PATCH v2 10/10] xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Date: Fri, 2 Sep 2022 14:35:02 +0100 Message-Id: <6a9a3d24477e583ea1a8b0954d43332144be03f0.1662123432.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Christophe JAILLET Backport Linux commit 98b64741d611. This is the clean backport without any changes kmalloc_array()/kcalloc() should be used to avoid potential overflow when a multiplication is needed to compute the size of the requested memory. So turn a devm_kzalloc()+explicit size computation into an equivalent devm_kcalloc(). Signed-off-by: Christophe JAILLET Acked-by: Robin Murphy Link: https://lore.kernel.org/r/3f7b9b202c6b6f5edc234ab7af5f208fbf8bc944.1644274051.git.christophe.jaillet@wanadoo.fr Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 98b64741d611 Signed-off-by: Rahul Singh --- Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 6fb74d864e..9e4815f455 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1641,10 +1641,10 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) { unsigned int i; struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg; - size_t size = sizeof(*cfg->l1_desc) * cfg->num_l1_ents; void *strtab = smmu->strtab_cfg.strtab; - cfg->l1_desc = _xzalloc(size, sizeof(void *)); + cfg->l1_desc = _xzalloc_array(sizeof(*cfg->l1_desc), sizeof(void *), + cfg->num_l1_ents); if (!cfg->l1_desc) return -ENOMEM; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 14:22:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 14:22:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397790.638467 (Exim 4.92) (envelope-from ) id 1oU7Yq-0002ed-QZ; Fri, 02 Sep 2022 14:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397790.638467; Fri, 02 Sep 2022 14:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU7Yq-0002eW-Nn; Fri, 02 Sep 2022 14:22:20 +0000 Received: by outflank-mailman (input) for mailman id 397790; Fri, 02 Sep 2022 14:22:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU7Yo-0002eQ-EK for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 14:22:19 +0000 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a2c9c170-2aca-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 16:22:15 +0200 (CEST) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 14:21:52 +0000 Received: from EX13D08EUB003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com (Postfix) with ESMTPS id 03919810AD; Fri, 2 Sep 2022 14:21:49 +0000 (UTC) Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D08EUB003.ant.amazon.com (10.43.166.117) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Fri, 2 Sep 2022 14:21:48 +0000 Received: from dev-dsk-ptyadav-1c-613f0921.eu-west-1.amazon.com (10.15.8.155) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1497.38 via Frontend Transport; Fri, 2 Sep 2022 14:21:46 +0000 Received: by dev-dsk-ptyadav-1c-613f0921.eu-west-1.amazon.com (Postfix, from userid 23027615) id 406C025972; Fri, 2 Sep 2022 14:21:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: a2c9c170-2aca-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1662128537; x=1693664537; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UKSdy9ljsTc9naNZmAjGvtO5F0jQVq8xZyMjs59heuU=; b=SuTzX5fVvLbsdkYAjpv7EsQJ0ws8W+DmP2Wf2VjSJmmrK4/KxVKTRFeX FIYaCkWRHpHDR8H8K7C+MfFmbc7YSE1wqBqCR7qODabEJqaUfCduVPTxU Pb1GDblpqqSjHBAaIvXRFJYrcL26UmjlG/86oDFI11BMRl+fw9O/anhaA o=; X-IronPort-AV: E=Sophos;i="5.93,283,1654560000"; d="scan'208";a="255595992" Date: Fri, 2 Sep 2022 14:21:45 +0000 From: Pratyush Yadav To: Juergen Gross CC: SeongJae Park , , , , , , , , Subject: Re: [PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested Message-ID: <20220902142145.txtszulz6edsf455@amazon.de> References: <20220831165824.94815-1-sj@kernel.org> <20220831165824.94815-2-sj@kernel.org> <20220902095207.y3whbc5mw4hyqphg@yadavpratyush.com> <84def263-c061-605f-44da-580c745bf5b6@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <84def263-c061-605f-44da-580c745bf5b6@suse.com> Precedence: Bulk On 02/09/22 01:08PM, Juergen Gross wrote: > On 02.09.22 11:53, Pratyush Yadav wrote: > > On 31/08/22 04:58PM, SeongJae Park wrote: > > > The advertisement of the persistent grants feature (writing > > > 'feature-persistent' to xenbus) should mean not the decision for using > > > the feature but only the availability of the feature. However, commit > > > aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent > > > grants") made a field of blkback, which was a place for saving only the > > > negotiation result, to be used for yet another purpose: caching of the > > > 'feature_persistent' parameter value. As a result, the advertisement, > > > which should follow only the parameter value, becomes inconsistent. > > > > > > This commit fixes the misuse of the semantic by making blkback saves the > > > parameter value in a separate place and advertises the support based on > > > only the saved value. > > > > > > Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") > > > Cc: # 5.10.x > > > Suggested-by: Juergen Gross > > > Signed-off-by: SeongJae Park > > > --- > > > drivers/block/xen-blkback/common.h | 3 +++ > > > drivers/block/xen-blkback/xenbus.c | 6 ++++-- > > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h > > > index bda5c815e441..a28473470e66 100644 > > > --- a/drivers/block/xen-blkback/common.h > > > +++ b/drivers/block/xen-blkback/common.h > > > @@ -226,6 +226,9 @@ struct xen_vbd { > > > sector_t size; > > > unsigned int flush_support:1; > > > unsigned int discard_secure:1; > > > + /* Connect-time cached feature_persistent parameter value */ > > > + unsigned int feature_gnt_persistent_parm:1; > > > > Continuing over from the previous version: > > > > > > If feature_gnt_persistent_parm is always going to be equal to > > > > feature_persistent, then why introduce it at all? Why not just use > > > > feature_persistent directly? This way you avoid adding an extra flag > > > > whose purpose is not immediately clear, and you also avoid all the > > > > mess with setting this flag at the right time. > > > > > > Mainly because the parameter should read twice (once for > > > advertisement, and once later just before the negotitation, for > > > checking if we advertised or not), and the user might change the > > > parameter value between the two reads. > > > > > > For the detailed available sequence of the race, you could refer to the > > > prior conversation[1]. > > > > > > [1] https://lore.kernel.org/linux-block/20200922111259.GJ19254@Air-de-Roger/ > > > > Okay, I see. Thanks for the pointer. But still, I think it would be > > better to not maintain two copies of the value. How about doing: > > > > blkif->vbd.feature_gnt_persistent = > > xenbus_read_unsigned(dev->nodename, "feature-persistent", 0) && > > xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); > > > > This makes it quite clear that we only enable persistent grants if > > _both_ ends support it. We can do the same for blkfront. > > I prefer it as is, as it will not rely on nobody having modified the > Xenstore node (which would in theory be possible). Okay. In that case, Reviewed-by: Pratyush Yadav -- Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Fri Sep 02 14:51:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 14:51:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397797.638478 (Exim 4.92) (envelope-from ) id 1oU80w-0005ug-5t; Fri, 02 Sep 2022 14:51:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397797.638478; Fri, 02 Sep 2022 14:51:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU80w-0005uZ-2S; Fri, 02 Sep 2022 14:51:22 +0000 Received: by outflank-mailman (input) for mailman id 397797; Fri, 02 Sep 2022 14:51:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU80u-0005uQ-9x for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 14:51:20 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3d749fe-2ace-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 16:51:18 +0200 (CEST) Received: from DB6PR07CA0199.eurprd07.prod.outlook.com (2603:10a6:6:42::29) by PR3PR08MB5836.eurprd08.prod.outlook.com (2603:10a6:102:8f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 14:51:16 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::1b) by DB6PR07CA0199.outlook.office365.com (2603:10a6:6:42::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Fri, 2 Sep 2022 14:51:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 14:51:15 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 02 Sep 2022 14:51:15 +0000 Received: from 77570224e9af.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ACB23BF6-C2A1-40F4-B9AA-072381D7A1D2.1; Fri, 02 Sep 2022 14:51:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 77570224e9af.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 14:51:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB7873.eurprd08.prod.outlook.com (2603:10a6:150:5c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 14:51:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.014; Fri, 2 Sep 2022 14:51:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3d749fe-2ace-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b7Bx4y2ftc/pvHz9eeulQOTF5qQIIEFfF5Q4xoBTO18SWyx4ZcWflypc3wsbmU9e07tR9PGmi2jOJjrniTM8Lwhr0qOnjqKldwOrnISXyOvjUCAK30AHfgSKixnSwFUbyZ4JArWhlf+NNfGX4DF2ELLAjqW5KS5NNI0tjW2W834Xw8179peKU8Yqsuoy0Ee312OsN2EDtsViFxvjIkk1Qt1df6vlta8F7t6bRRLbGos0VA5Oqa8txpBhnTo6upjbfPAMXvr4dOjHiZalcL7BG2Kkvf+nj0ZCCU+0ExFZIwikvLESpekSuJpQYWwgzOFZTEuK9fl1PLg0uXhA3WeMxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hfU4WtZdxG3QjEDzMjigkky0H4P3dG5bwh9cBQcwF7M=; b=PtbB0ovHEj7C54o1D2Np0I2xuCpe6g7VH/+GnhdpXgaKdGFNSc8l327z1Xu7T3KMAZ3Cp6P8u/8fGzWusaOKAr6zNI6R+bQDUTxWqz7NNfLVBL46YSsjK9vSuJ10O+EkkrUxsIifM9OW+8vW1IhuTspMjilbrO/vfHjjC5gYuHWWTXGjOhNJeCwSgXymdluzianXBLwBTokWBIKixKsUQES+4aQfy7TrWhq1RRV7zHIK3lK5Iyr29Mo/pKAltF/THR1FpbUGoz1PB9cBGsDQgEQkbvqnfi2WHETFNcJ+4Fx63zV3wGNoat+OcaAJzEAQOzZZ7ZwlTOx7hlnlA/jxGw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hfU4WtZdxG3QjEDzMjigkky0H4P3dG5bwh9cBQcwF7M=; b=qXZznj/W1wVqt/GIkC8qDncwy6JRWb0ErIoYU7txw8j/Omp4M7cE5Z1kP/s1ScWdCJR+CQc04O9iwzzUyj/iJuiV11z2IyVV4kEpNyQ84J19WQWpUXmdxxMYFShZyzK87ZbhbZmCs3DLmv5C27Vsaasj9O+HgIr8BKzGZcYfhp0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f759255cbe7da65e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGtNCX65okOSrB7fubbi0iqY80Nsk/HdoDKfCGRA/iSargl92NEd9iQcUD7e9R7d4HE5tMYBp5fvQc1R4coaniXxd0oQmFSGNZxQTq6IgED+ydk9y2zMI4bWyfVB6WJ1IkoKA+MY/H33PQWs9tReJ0+drIOo6wB3YkuAADL9Eaerogc44p7HJ6W8RYPsIOPxUEXkuCD+rdphPO2BIt6Z0X3GCFnA9l7CReg7dIX2SWck12xMAVGv1vRi2W6Un3chtCdOi8V1AXWj8xG8Lrkf3/v9nKUcXn6CwYW7MDkIjAHzlT+Fe6lcS5gAywZvZYUNhHyxwX7m4JCkt1/brGJ6NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hfU4WtZdxG3QjEDzMjigkky0H4P3dG5bwh9cBQcwF7M=; b=WxiVQpUR8+XZU59vIQs699dUqpNGKb9ilSyxdDxHFG1CzJwTs1LCLRFDOzq2GXnv7/snDhnHVUtNLjRqxseTekUHtOq/5JnvVSRp7CRt1D3jgQLhg3y+l5t+vWUzAuyZvgKW97EQRXygc7CDyey9VSX3H663ZLsnxre7Vqd1MGXfD3MlFITRnd8XHIPtBB3ATS3BK0IOahy5kkpGbkJILzaxx8TyDLgmcrbJHxH8tq4SBpkyAsMppSFPbhpFO7wxcBjBcNs/nL3nDQRLqQ4k4y6AwCSSUTKasKfpEH60n/gqYHxD6YJjemKrTKVwt7tvyhCIVyHbKxYjrCgryqx51A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hfU4WtZdxG3QjEDzMjigkky0H4P3dG5bwh9cBQcwF7M=; b=qXZznj/W1wVqt/GIkC8qDncwy6JRWb0ErIoYU7txw8j/Omp4M7cE5Z1kP/s1ScWdCJR+CQc04O9iwzzUyj/iJuiV11z2IyVV4kEpNyQ84J19WQWpUXmdxxMYFShZyzK87ZbhbZmCs3DLmv5C27Vsaasj9O+HgIr8BKzGZcYfhp0= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOAeMLlOwX5Mka7ZrpAabJW7K3K4ewAgAFZKAA= Date: Fri, 2 Sep 2022 14:51:07 +0000 Message-ID: <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> In-Reply-To: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c7d51533-3914-432e-1fc2-08da8cf29669 x-ms-traffictypediagnostic: GV1PR08MB7873:EE_|DBAEUR03FT037:EE_|PR3PR08MB5836:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dYKWFuuf1dIrp1cGAH35e4zJpKw9iPsahntrvrk2aTxiaPz30P1WNuWVExv7xvrdIxkmjhgj9N5xVOD0var2ccGIqRN1y/WPb46vo0WdxkD0rxb3eQTudEOBaV1og628LsI0BiC+SxQf/OAgj9nFpBEnVOsqQXAIhRgQyOPZUlbM9KtMydf/ftwn1W/TqR9/bomwtGkZxaCqnS8zWnmZdVnOscLeFCOThw8DUA2AvaPMLLyl7CtB6g6mC9lKidWN/9W/TlAghmDUTcq+1/VOERo4fHhO7N4hozCWvXMBuRmCD1e2A07IHrYRS0FTwebpQ14hDZpBMcem25s3fqqin0lEY44ru274WsV+UQcankV6WSWvaVM60bxgGNO8xZlieW9HaJ6cbIoI101HvkzeTUKupq1sYpuBrJ0BzU4K6U1DcY+v8zhs27VbpBIBjZ7XYGslJk/EjiWZEYtaPmwH3riebTZkqnai2G2d3FWx5SyJpNvbJqUb9ZNiNnPWztFh7GE6TmqP25PPAWy/8TvbcolD3OBWE+F6oHDePUoynhw7IOsiKLT9gMySsjO/EdFbMAM341dLyGM+3hPSRmPDP+kc/cNvfababV2B4ZDjfFteLdKgDdHrOGsLYgIPiPanATwzjp9PpUxn4bXpCNqwsJ2GXs9Mw/hycCJkNfnuHrf/08wfLVH+21r7x1d9rnxHYc/P5VRWRxLiQVA08UPlfPOYgmRrX4+oFG5aIo0mxm4ier8DAGQ5MctptrJPG2ftvC7Z239uAGtIM//i0b/rF0/gTR9rsFgbST1ZLgKwess= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(83380400001)(38070700005)(122000001)(38100700002)(4326008)(64756008)(66446008)(8676002)(66476007)(66556008)(91956017)(6916009)(76116006)(66946007)(316002)(2906002)(54906003)(8936002)(5660300002)(53546011)(186003)(2616005)(6512007)(71200400001)(6506007)(41300700001)(26005)(478600001)(36756003)(6486002)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7873 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8ce82a3c-f656-498e-0dee-08da8cf2911f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9FCVqapItS0ad++s7lPEy3Bsy1HYrRsN55utragXGKBopiKoL3VW77u/1CXVaVcD8CWIWRoShzdj0oIKfMNe/2sRHFhLu8QTsbJEtpf3ozMpaNUy/WeZw1DR7dYv61Twyb3LmG8AenKhht3mk894oDUMHnx95CEXAebMB7S+8spYNuO3igiVK8CdORsJm4HCvaeRKEZ9t4q7mQP9TLu4gjrTwxpgjGlJV0DDfsKcFZICHY5MtASajTKKtyALO5CmsSzd6iOr+TNYtZpVyfYZYdNr03tziG6acGUnANixUnIQJaHFP+dW28PWVAt1QuqED8agAPTNkP3R0tOYZf4AU7G4FOkaF3Ib/E7s2LsjgtUGy6P5hDbukln1pCtVdJLIBvoi+b3QHUAErRNmniEtVjIyIDHC8bPd/Iki7hLOUvKpgNEfpUXI34ea+7DuakuaLwhe0BfRJVYIW+fnfvRgyoCwRgvykXuEOA6LJKxDOw6hQnvW/uR5JlzcO6HRi9/9SgbtePhOp5uxex4nJtQSPjf0uwyVHluO53zNU62XaabmTFtniS1TXSeoM2fA/DG8icw5s2Mysdd7KKPSJAieJe8YeSFDlgXfFzuCGF3YvSlqlfQuS9Vg6qb6Ii25ooSJMfPzAgGOui0dG/y4a5hQarwYAsCFcXOvEwbCnzdJaTYaqODTs+mn/VCBEXMoH1E9AnERNa6ZMrEkxE+Ys9EpiS5qGCzt75BL+mmFlMis92uWZVlDrbK9VIEwXjI4sKNt2c4HhjksCLNwUPm8PKEr9A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(396003)(36840700001)(46966006)(40470700004)(53546011)(6506007)(107886003)(83380400001)(26005)(478600001)(41300700001)(6486002)(336012)(6512007)(2616005)(82310400005)(47076005)(2906002)(8936002)(6862004)(5660300002)(40480700001)(40460700003)(54906003)(316002)(4326008)(8676002)(70206006)(70586007)(186003)(82740400003)(81166007)(36756003)(33656002)(356005)(86362001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 14:51:15.9636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7d51533-3914-432e-1fc2-08da8cf29669 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5836 Hi Julien, > On 1 Sep 2022, at 19:15, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 01/09/2022 10:13, Rahul Singh wrote: >> Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to >> disable xenstore interface for dom0less guests. >> Signed-off-by: Rahul Singh >> --- >> Changes in v3: >> - new patch in this version >> --- >> docs/misc/arm/device-tree/booting.txt | 4 ++++ >> xen/arch/arm/domain_build.c | 10 +++++++--- >> xen/arch/arm/include/asm/kernel.h | 3 +++ >> 3 files changed, 14 insertions(+), 3 deletions(-) >> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic= e-tree/booting.txt >> index edef98e6d1..87f57f8889 100644 >> --- a/docs/misc/arm/device-tree/booting.txt >> +++ b/docs/misc/arm/device-tree/booting.txt >> @@ -204,6 +204,10 @@ with the following properties: >> - "disabled" >> Xen PV interfaces are disabled. >> + - no-xenstore >> + Xen PV interfaces, including grant-table will be enabled for the VM= but >> + xenstore will be disabled for the VM. >=20 > NIT: I would drop one of the "for the VM" as it seems to be redundant. >=20 >> + >> If the xen,enhanced property is present with no value, it defaults >> to "enabled". If the xen,enhanced property is not present, PV >> interfaces are disabled. >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 4b24261825..8dd9984225 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3336,10 +3336,14 @@ static int __init construct_domU(struct domain *= d, >> (rc =3D=3D 0 && !strcmp(dom0less_enhanced, "enabled")) ) >> { >> if ( hardware_domain ) >> - kinfo.dom0less_enhanced =3D true; >> + kinfo.dom0less_xenstore =3D true; >> else >> - panic("Tried to use xen,enhanced without dom0\n"); >> + panic("Tried to use xen,enhanced without dom0 without no-xe= nstore\n"); >=20 > This is a bit hard to parse. How about: >=20 > "At the moment, Xenstore support requires dom0 to be present" >=20 >> } >> + else if ( rc =3D=3D 0 && !strcmp(dom0less_enhanced, "no-xenstore") = ) >> + kinfo.dom0less_xenstore =3D false; >> + >> + kinfo.dom0less_enhanced =3D true; >=20 > Wouldn't this now set dom0less_enhanced unconditionally? >=20 >> if ( vcpu_create(d, 0) =3D=3D NULL ) >> return -ENOMEM; >> @@ -3379,7 +3383,7 @@ static int __init construct_domU(struct domain *d, >> if ( rc < 0 ) >> return rc; >> - if ( kinfo.dom0less_enhanced ) >> + if ( kinfo.dom0less_xenstore ) >> { >> ASSERT(hardware_domain); >> rc =3D alloc_xenstore_evtchn(d); >> diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/as= m/kernel.h >> index c4dc039b54..3d7fa94910 100644 >> --- a/xen/arch/arm/include/asm/kernel.h >> +++ b/xen/arch/arm/include/asm/kernel.h >> @@ -39,6 +39,9 @@ struct kernel_info { >> /* Enable PV drivers */ >> bool dom0less_enhanced; >> + /* Enable Xenstore */ >> + bool dom0less_xenstore; >> + >=20 > AFAIU, it is not possible to have *_xenstore =3D true and *_enhanced =3D = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an= enum with 3 values: > - None > - NOXENSTORE/BASIC > - FULLY_ENHANCED >=20 > If we want to be future proof, I would use a field 'flags' where non-zero= means enhanced. Each bit would indicate which features of Xen is exposed. I think that could be a good solution if we do it this way: - define a dom0less feature field and have defines like the following: #define DOM0LESS_GNTTAB #define DOM0LESS_EVENTCHN #define DOM0LESS_XENSTORE - define dom0less enhanced as the right combination: #define DOM0LESS_ENHANCED =3D (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0LESS= _XENSTORE) This way we have a proper feature bitset and ENHANCED is properly defined a= s a combination of the 3 features. What do you guys think ? Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 15:02:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 15:02:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397804.638489 (Exim 4.92) (envelope-from ) id 1oU8Br-0007Pj-7D; Fri, 02 Sep 2022 15:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397804.638489; Fri, 02 Sep 2022 15:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8Br-0007Pc-3N; Fri, 02 Sep 2022 15:02:39 +0000 Received: by outflank-mailman (input) for mailman id 397804; Fri, 02 Sep 2022 15:02:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8Bp-0007PW-MG for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 15:02:37 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4753a1ea-2ad0-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 17:02:36 +0200 (CEST) Received: from DB8PR06CA0027.eurprd06.prod.outlook.com (2603:10a6:10:100::40) by DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 15:02:34 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::2b) by DB8PR06CA0027.outlook.office365.com (2603:10a6:10:100::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 15:02:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 15:02:33 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Fri, 02 Sep 2022 15:02:33 +0000 Received: from 0265feb2c93c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4331EE66-7259-4240-A456-B1E8B35A2856.1; Fri, 02 Sep 2022 15:02:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0265feb2c93c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 15:02:23 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV2PR08MB8004.eurprd08.prod.outlook.com (2603:10a6:150:7e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 15:02:20 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.012; Fri, 2 Sep 2022 15:02:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4753a1ea-2ad0-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gOMCztR32DKUnLYx47/uVf1oViinWEKbZ2oeospcr3cD942GXHBLxj8XF0Spbon3yUlScTDmDjflnaXivz+ScVHBqR48tJKgpOL4X9fJ+UOmC3ROgxDo5DzOo0obAku/tNqIoEG5B9lo/Y4d7hAKdoGS6MfsEQqgGG6KoYz9IwXJYKmaPTzDb++Cdw7Tp1T0QeUdPrv5nAPNzTdVFtJYxNpUMtm3RhU0roAxAKI05GgN/Y8J1GsXqMbZQP+CuOhygGK5YpzDZ+u4Dej6ZIcXkoD+jJcox9j5iAi6EDrQsnrjjcgjiPiZ+GP75Jl0QZjF0/vkzY4Bs364DFMbFv2iag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hfmu6RFcwy0jtroWdMtyZfHH9lJ5HBEtyduPA+q04kg=; b=L/DjP9kbZrH6f4cd2GhqVT/6jsLpXWi3yOm0TDoZ/c7vUaaqUp5zTUqpwBHf6fKzvjJcg6JW7xyNexSWax7RJCAPM6igZevR6aLRTsgvlIekC0ytVMVOVHWfSFpc8UalMEk8uVUv6wMLarHK1FGCqz9Zm0S6PHI2vQ+ajR/JxB2nJkXw282ZxTMfX3RLMQOLQigxd83+CG2lNaXhc4LgwntA3mNGtRYBDvvcncs0tRI6M0LaReuqB3jgeXcHcJ8r2wncybfwcj/cx7Cns0xGkRfr9INgNIYXf9BwVR0wjs4UjiiUeGD9hCJA/4ZJu4Z8L0OnRVLrlZu5XMP1mdDAuw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hfmu6RFcwy0jtroWdMtyZfHH9lJ5HBEtyduPA+q04kg=; b=zeAoXwXxZ2Ihv4Pj9KyeOOJxiUsNix6LGhjEkZXWE5AtQLRYGp9MEW8lwFK+pR83S/wc+2zc1cWeN5N3CzMlDmnKczHz8y2wqR2cMFl/VvT6ljznYIF4l82wLW0pj1vHkAyI4p/0iMfg85sg4aMgGLsfsQiqwRxnabm4RLB3cM4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a3212560e182afd6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVCnZv8B3zMxmZl3IinJAC+zGd5WbMtoO1PRn7mBmrQ5jrfI/2L+U+qLqFETfFSbgtrw0i3TWkh5LGS/R9jemLJQwTMMLGHLR6ZAykJLgqbDkFoIhRhpEuJuUdWrclxr5qrMreBbhjuebQaQcrAo9RXqVt4xIucjTdDARQ4R4oG6TckGLgSJZjwRrKJyghpKfol60pPow/UVhg4UAArnZ2maUsf1ziwi/7BIQlzEt8JO3CC9Fb3QDSbyK5muYj5H6iAhkOAheY+36GiVoiTniWPrVMktp0sDR1v052yhfXGg4WwVwHcvJ+ySlizR+/CcXn6vYx7mzlusB1XpiMZyWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hfmu6RFcwy0jtroWdMtyZfHH9lJ5HBEtyduPA+q04kg=; b=FBZhdmYeLomx9M8UQL6HfxKz6xes3JdUFRr/T6g0usGVZKAXrO49jrt3sMaSE/Orn9ka6oXvafKG7fWaHwh7YKXA7x2ZJzMu5bKAOPZtrzbh7o8TMMs9INLoAasZde787GeBnToWx41sD+E1tdYIUf3Hf0HEP+F9i9yQiCuTxxTkrF/HMxOdWWD6O9oX5/FhC/teykvg5EQeKX+8wQPLJSnpJTvYl5+YWkCPCL3zpU1oHO1O/6KEpclmNweITwweUVs/p4uHbNUeUiK2sKjs5CKeUBswNKpavrjsWx/WE3sGAEK2wDmjshbEip19/IY6BQbK38YMz5r0B3V6/XCDAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hfmu6RFcwy0jtroWdMtyZfHH9lJ5HBEtyduPA+q04kg=; b=zeAoXwXxZ2Ihv4Pj9KyeOOJxiUsNix6LGhjEkZXWE5AtQLRYGp9MEW8lwFK+pR83S/wc+2zc1cWeN5N3CzMlDmnKczHz8y2wqR2cMFl/VvT6ljznYIF4l82wLW0pj1vHkAyI4p/0iMfg85sg4aMgGLsfsQiqwRxnabm4RLB3cM4= From: Rahul Singh To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFcTAA= Date: Fri, 2 Sep 2022 15:02:20 +0000 Message-ID: <99959982-8A12-44ED-9959-6BB5AA695447@arm.com> References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> In-Reply-To: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d2f4676d-cc67-41ea-a300-08da8cf42a63 x-ms-traffictypediagnostic: GV2PR08MB8004:EE_|DBAEUR03FT058:EE_|DBAPR08MB5814:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zuyqk0kGiEkbqjZU7CK/V25JI3xuUr/BVuXikvu8FH4BcTPfO9jZpACOqCFaUmvElSQDUN9ZYLCWn7QnNqD8pEOY2AZoAinssuswItva3IKgP89yODcXooqv0ru2Ho7ZCuZ+pmEFN0td/t2CWYJmo87CFJrRaYm3x6s6YUwHB7rrcRyjgPQqjddSGYzaZCaNYBkeAAnN9sxyNziGcd0bUmPX7umABfS/8FNVi7JsIAtyNzs44oQzYX3SBDqPcCV+jVyB0/FFHQ+sS6O8mrqtiZdXEkeqESPDz5SPIYZcFTfrAX7/nlgBYkbHe8X3yQleFVluqPZecSEIPZ9xwCli6CnFssxJVKgLapIchE6EyA1STLvoosp60r8zlT/I29mfKnzwA3P/nZriDz0aK5UlKeU3wn72Dc2hwKmBreOudQrb8EVsINQdjsugEKRmBpjO5sGiyPCfet+opbgippbVXx1pseP3TOe7OFIw6TkXew0l8UAsl2xMWORZSUQ6qGnkEPEC6EwmwxnIe0mtqImv9SUXYDVvuotLUlqdu65q8AckYEMr+KNf10ALyaCgeJgYxEy9X5vJIzJG5Xlv7OaR5dIikHurz+20+y05TVyzC8W2JqEHJbFKvBvN+0Sd4DdXP8zC++sGCa7SSSRXSc1Ua1+chtehK1Yo7hLuj27lZ96CEjvLH94SKpRw1rInpeI2fKvaGs+Jy0BKssEO9BSwOfTF8bhDXypvvhDRJ925uKYqGmQJ55zv1wvLXdlzGyf/tMX+enSGWtprwoT6K7m43jdKzCut+yRStPEMNPOejlI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(2616005)(186003)(6512007)(26005)(53546011)(36756003)(38100700002)(2906002)(122000001)(6506007)(38070700005)(4326008)(8676002)(5660300002)(71200400001)(33656002)(316002)(83380400001)(76116006)(66556008)(66476007)(66446008)(66946007)(64756008)(6486002)(86362001)(8936002)(6916009)(41300700001)(91956017)(478600001)(54906003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <48C1189192AB4B4D8440E82305EBE1FF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8004 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8b0e9bdc-9aa6-4e5d-7218-08da8cf42295 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CkBGARp3Gy/PU/CnxC+psw+Zabkc4H6S0NDdrGyB139STtRQZ9aDX4L8p5XufzopUuXHmJzb1zDFnqR/lDC7PqTjG1csDGlD2KxjPDrrXKak9oy12jdUd6KtvEz80g+zu/Lpq0/TqLu9J5Tm7RAEJvJ4FjgW2/RBx7QavtdAWzeDvMJvCgpji2tGUM/rFtOjZjW61EK857G0lXz2PZmhdBWk4JfEP2mWBc5TpC+lmY7oX7dsYUJUeqfsj5k57RIjOOR7h5B+GHla4tUgSGmAjA4FLZ134oOI7EAaFpfPAeNsPjWdg++LgOymJT39hmVx5Z2DamnHvZ//eGr25lbST2y/JWtv+9tqOSgyV4fG5Ap4U/G3ZSkA/K9cGRAsK4GqSrsMUXi3LovaqTfAz8iyjGc+C2GSabK1jYpj80A2GuZENFvj5xQszonunHBJiWJSYfN5Ih2V6MkhJt5B1vRiKsK7iqxGmjktzWx3TXKHjKBXTz4dUElJMc/L5NKCAs3xAWub40mNQuMDiEus1P+iYXyIBnN4Wn6kkzj/wK6Ep2O/ebTHVKkXlUuxqxDJtQDTsRu8hRMm5mBPRFmAoAdPzbEeHQHNMJutob5JFSvjNRaYr60vAwqWUHT4Cs7WDXZDwfCeCWd+SzqpXEFnyva526VwK/u9bxn5y457nJbLiw/2JO41sip0kOxjCuMZ6/r+JJBhjGSC6ZPm7yCMN15huQCOuBk14/E3fxtN30jhuE82aGyOfg6wPUJPQM6nEUUuh5FjeOXQlXgQ9jOMps7BkQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(376002)(396003)(40470700004)(36840700001)(46966006)(186003)(2616005)(2906002)(36756003)(83380400001)(47076005)(82310400005)(336012)(82740400003)(5660300002)(33656002)(8936002)(6512007)(316002)(6862004)(36860700001)(6506007)(70586007)(53546011)(70206006)(4326008)(8676002)(107886003)(81166007)(41300700001)(26005)(54906003)(356005)(86362001)(40480700001)(6486002)(40460700003)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 15:02:33.7428 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2f4676d-cc67-41ea-a300-08da8cf42a63 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5814 Hi Julien, > On 1 Sep 2022, at 7:15 pm, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 01/09/2022 10:13, Rahul Singh wrote: >> Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to >> disable xenstore interface for dom0less guests. >> Signed-off-by: Rahul Singh >> --- >> Changes in v3: >> - new patch in this version >> --- >> docs/misc/arm/device-tree/booting.txt | 4 ++++ >> xen/arch/arm/domain_build.c | 10 +++++++--- >> xen/arch/arm/include/asm/kernel.h | 3 +++ >> 3 files changed, 14 insertions(+), 3 deletions(-) >> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic= e-tree/booting.txt >> index edef98e6d1..87f57f8889 100644 >> --- a/docs/misc/arm/device-tree/booting.txt >> +++ b/docs/misc/arm/device-tree/booting.txt >> @@ -204,6 +204,10 @@ with the following properties: >> - "disabled" >> Xen PV interfaces are disabled. >> + - no-xenstore >> + Xen PV interfaces, including grant-table will be enabled for the VM= but >> + xenstore will be disabled for the VM. >=20 > NIT: I would drop one of the "for the VM" as it seems to be redundant. Ack.=20 >=20 >> + >> If the xen,enhanced property is present with no value, it defaults >> to "enabled". If the xen,enhanced property is not present, PV >> interfaces are disabled. >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 4b24261825..8dd9984225 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3336,10 +3336,14 @@ static int __init construct_domU(struct domain *= d, >> (rc =3D=3D 0 && !strcmp(dom0less_enhanced, "enabled")) ) >> { >> if ( hardware_domain ) >> - kinfo.dom0less_enhanced =3D true; >> + kinfo.dom0less_xenstore =3D true; >> else >> - panic("Tried to use xen,enhanced without dom0\n"); >> + panic("Tried to use xen,enhanced without dom0 without no-xe= nstore\n"); >=20 > This is a bit hard to parse. How about: >=20 > "At the moment, Xenstore support requires dom0 to be present" Ack.=20 >=20 >> } >> + else if ( rc =3D=3D 0 && !strcmp(dom0less_enhanced, "no-xenstore") = ) >> + kinfo.dom0less_xenstore =3D false; >> + >> + kinfo.dom0less_enhanced =3D true; >=20 > Wouldn't this now set dom0less_enhanced unconditionally? Yes , I will fix this in next version. =20 Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Fri Sep 02 15:06:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 15:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397813.638499 (Exim 4.92) (envelope-from ) id 1oU8F8-000860-Pa; Fri, 02 Sep 2022 15:06:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397813.638499; Fri, 02 Sep 2022 15:06:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8F8-00085t-Mj; Fri, 02 Sep 2022 15:06:02 +0000 Received: by outflank-mailman (input) for mailman id 397813; Fri, 02 Sep 2022 15:06:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8F7-00085k-NO for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 15:06:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8F7-0000OV-E3; Fri, 02 Sep 2022 15:06:01 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU8F7-0005M0-7l; Fri, 02 Sep 2022 15:06:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CMT3PrtV4pkKn9zo65fQvisjEOFSchSlF09kvmW09eQ=; b=3Uo7hhUp1h9Xpingc+riIpMvqE XX7et09tFcQQ1cWZ50JDHAXdB5xU/kQlQ5WfUfq7PMBQ1YeGp1XTOPpDo6c4Ti0Y/PNdAsgWjTAhq 3b8HLUJIt0hUjOmTJQKlYpHWhvdrQGBY1XM0jxP9+hQQlpnP9ZPPubGWsAZTBcCwvTCA=; Message-ID: <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> Date: Fri, 2 Sep 2022 16:05:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value To: Bertrand Marquis Cc: Rahul Singh , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> Content-Language: en-US From: Julien Grall In-Reply-To: <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 02/09/2022 15:51, Bertrand Marquis wrote: >> On 1 Sep 2022, at 19:15, Julien Grall wrote: >> AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an enum with 3 values: >> - None >> - NOXENSTORE/BASIC >> - FULLY_ENHANCED >> >> If we want to be future proof, I would use a field 'flags' where non-zero means enhanced. Each bit would indicate which features of Xen is exposed. > > I think that could be a good solution if we do it this way: > - define a dom0less feature field and have defines like the following: > #define DOM0LESS_GNTTAB > #define DOM0LESS_EVENTCHN > #define DOM0LESS_XENSTORE > > - define dom0less enhanced as the right combination: > #define DOM0LESS_ENHANCED = (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0LESS_XENSTORE) I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of defining a bit for gnttab and evtchn. This will avoid the question of why we are introducing bits for both features but not the hypercall... As this is an internal interface, it would be easier to modify afterwards. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 15:08:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 15:08:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397821.638511 (Exim 4.92) (envelope-from ) id 1oU8H9-0000Gv-8k; Fri, 02 Sep 2022 15:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397821.638511; Fri, 02 Sep 2022 15:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8H9-0000Gl-3n; Fri, 02 Sep 2022 15:08:07 +0000 Received: by outflank-mailman (input) for mailman id 397821; Fri, 02 Sep 2022 15:08:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8H7-0000Gf-Od for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 15:08:05 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061.outbound.protection.outlook.com [40.107.249.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ad4b078-2ad1-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 17:08:04 +0200 (CEST) Received: from AS9PR0301CA0033.eurprd03.prod.outlook.com (2603:10a6:20b:469::20) by AS8PR08MB9790.eurprd08.prod.outlook.com (2603:10a6:20b:615::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 2 Sep 2022 15:08:01 +0000 Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::6b) by AS9PR0301CA0033.outlook.office365.com (2603:10a6:20b:469::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15 via Frontend Transport; Fri, 2 Sep 2022 15:08:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 15:08:00 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 02 Sep 2022 15:08:00 +0000 Received: from 070369e45edc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F36E7BE4-F24C-41A7-82D2-C8AA30CB7797.1; Fri, 02 Sep 2022 15:07:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 070369e45edc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 15:07:53 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM9PR08MB5876.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 15:07:51 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.012; Fri, 2 Sep 2022 15:07:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad4b078-2ad1-11ed-934f-f50d60e1c1bd ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=g496igFT6X0p70NDgdUFejH/bOTTg44oArLKJ7SbLXmr+us3zcH+HSEbT028EtHg8DsR0Ewc6rxwh9lL3KVMuXxgX7L8Eg35nTaaqKW9OxgYWP5sr+4IxGFEygCaZ5zXEhr9SiXS4vyayV1VT712WpDt74FyNUKAeg8LgqmdqX79bPsiS1Q1uaqWL2REFZEbHFrYQalU+Ibp95zIZnZ0GkVdZNI14FgoxR4CdDVLqTaCOnqkWNDwzPmXjLRcrqKClKcnHajx6X3oRqBPhyncT4MQRGar9uyp09AwySUi1AQSB2JU+ipQVlg+aq2EHEUDR1RtSCpH2ExTiv7/+KPfcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y8kAxI9yYXnG9M/rGlqs/+IrCPTUSvtUMwzDZT9EbMM=; b=OO07l2JySI0vocipTzYQhn8s5MD6rroUp0gC5Tdkw3vTw4JA3K354aBTj6rO0em6Q8kdt2DDTIqUGv1sB1EVFQfjsNawf4NBqizN31qapA+In5BORZlg9mpWTGWqYXnu83W3Jmu85x19ThvUoO0ISdrmQrNDZP8fDRzZrpBzIR1j0mM8n52JWDew7ICFmUZPCikuf0pTgrcQL8JOak6GH67/aYidw19Fp8LvZAbZoNCP3HHHv8DVn3AbF87II7nX4Rwc7w/gqdm96eP8Km9kq+n0bk/3762VYOb3KGsv/zrrLnvuyyaa1Uf9Ku1ugkSV7SITjF9OXTqE6cTvHOrpSw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y8kAxI9yYXnG9M/rGlqs/+IrCPTUSvtUMwzDZT9EbMM=; b=cy/+8cBTb/RekcersjT/uGt3YtSe1pL+y2Ecqvzsrv0XFnFv/tjoHDiCI1kxuZ+TpFHI+kjn72fldHGF9PoO9mfo9mFRUbLquIclt6yP+pbcjf48xW6ufVp4DPFigh1daCjBTsv73pkFAT7FiEOhkoWpnsD/6W8r7ikW8aiN0Zo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0a0faa84760dce72 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/MFkneOz2I1K9UDPGNzALTnWMrfeZ6P8kZXILj3zmgTFOZKOBIJlr92rfrU4wotn88eSeY0yo8HfhCnaPwKK0WrQblGXX1907IRPw4IKe5vsqJ3XeWn90rbkx0VpC2phnclI3JpNwZYy1Fp7Pmso+gc35rIXqEqu52GBpDy7oCkn3DC3Mi3+tQvurKRZN4P0xhk+wIQiN7tONLLwcuuV4fcYfEbb73Xeq1o1SLKbhpv5cOlbofpoL5INem5WFpCA2M4IEszHFbll+KxNbSD/E+dFc3kpNymBnzHrd7DGQK8CY9gzhWMDfSCgFKJeLcnqo3CvffnNru2bfJij9XC+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y8kAxI9yYXnG9M/rGlqs/+IrCPTUSvtUMwzDZT9EbMM=; b=Xgpc9oJvqesHV1Y4G7S0UDu/A/EZ9k7stQyDWdPF8YMOgGW5z/mol7a5QNhioBlZWViSH3gb6tsEEX8QHkikKiTFHLgDSbaQLsOs+NI2omI0m5CBwC0qpm2EUI6/YpAe34DIPFDbIHnz/Zk9EQ6+LKxbcJe7WjlIe1Xm0AhrVTLq0hIYk43F3tvpbYfueu9m+ui5gXip03O16ZKbFgClgZYTbq7n03MbadDHPkIhVFxBAMDY8uej1fC60XEyQJ5jFHvuYjzzwMTavlkeGtPOo1RWI6xbU0qnmgtXAK+NUuJ3R8Nf9NtugRfwCdcSx9Mn+o4DRCx3//eBlcIaToF6tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y8kAxI9yYXnG9M/rGlqs/+IrCPTUSvtUMwzDZT9EbMM=; b=cy/+8cBTb/RekcersjT/uGt3YtSe1pL+y2Ecqvzsrv0XFnFv/tjoHDiCI1kxuZ+TpFHI+kjn72fldHGF9PoO9mfo9mFRUbLquIclt6yP+pbcjf48xW6ufVp4DPFigh1daCjBTsv73pkFAT7FiEOhkoWpnsD/6W8r7ikW8aiN0Zo= From: Rahul Singh To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property Thread-Topic: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property Thread-Index: AQHYveNwxlXXcvK6NkiecVIaY62Ipq3K34wAgAFgNQA= Date: Fri, 2 Sep 2022 15:07:50 +0000 Message-ID: <704547C9-47F9-43D4-99F9-77B9E9899A84@arm.com> References: <3899ada4cc8217b45eab4f8d85492b0d5a6a9580.1662023183.git.rahul.singh@arm.com> <2142aa46-24a0-e0cb-16c0-95e8f6302ce6@xen.org> In-Reply-To: <2142aa46-24a0-e0cb-16c0-95e8f6302ce6@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5e81dab6-1457-4637-42c9-08da8cf4ed3e x-ms-traffictypediagnostic: AM9PR08MB5876:EE_|VE1EUR03FT054:EE_|AS8PR08MB9790:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: A6rLM1U3cdJGOTxEcn2uie9AbvCET6ziLDtwiMKzNmxXeUm1O/3muFpxLVgghgABUeL9bz721R/Tscboa+QknzBdqwyGO4tz3E469Iu5f3oFCwz40S1RDTQb9O6pSh/TnWxZWgVlZR7+zXBYFZcLvsNeGoj9SdOA8x+7l48RNLLCMS+d04sTGaPciCCEM7f+hK75PmE7OnZ2SGkH9xdoQ/vsV28sQgG0RmBqF3TpAO350EIsUZZ1RgVevhBzpLzs+tUI0KOpDza9AHL8OCMVF7LbuH4jN9C3Hc/ZRO5lODqjWYly7hvjHG80ukzsbtvIeakZNRXegX42fwu9Gi7hjuAHKd6gH58e0PXKa7oq/u2J0c32VoboELNqPErVfWX1D71Go2RBYovLXOnkDqz03ksLC52arH1jeXRcpoggoZsR5Z2pIRW7m7XKLP4UBFwD/MF+yRpKcnTKOp/joKybBgArKEfeGkk1fRomnJqBgyUukrAL6q8hVfxNRdTBucWgpvyLGqhsud1flZqNnxk6iVLGXkhqq40A49hTpjZ3D5f8HpWL6nnQnTkWJpA10S1okXLxYBgDPgdKQw2gAgBoaSkq4JhpD/E8g+SkTWqR+kLHCh7EMoOPzF7KPXgqEz69i/NQe0OEF/XymZZoE809ov3Gjt1qIlIeZ16CTB8rfHQJVFXpg5jwnJbCuzkLji7hpisKhZsLJcYuOLR7fVwEI7O/Pqo+OdjEnN9yCaSvw1Paj+cbMOrsM9vSc6+aGhEUfQ4KgD9D7QZTFaR4w8Ou8lw/WXGaCdJ5tA0Qw+5N4YF4ogqtLqiVgn7vRh3Onll+FTSjMkr+tpPqAHqC5ky7rw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(66556008)(66946007)(122000001)(66476007)(66446008)(64756008)(86362001)(76116006)(38100700002)(53546011)(91956017)(6512007)(478600001)(26005)(6506007)(6486002)(71200400001)(316002)(54906003)(6916009)(41300700001)(2906002)(36756003)(83380400001)(38070700005)(186003)(33656002)(8676002)(5660300002)(30864003)(8936002)(2616005)(4326008)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5876 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 942f9ca6-586c-42f2-6d8a-08da8cf4e76e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rYFuysdWpYCYFWD8OlKbqk6/OOw9gOVs/oywTnGKFvzusQ8AeK6QNEZ1bxfqkNXP140Qb0U+jMFv1QMLQZPpvhOlOgGn77lBMQCcZXStswrl04jxQ/y+83goot6xbRA7OAhQPRZ4IuXR4ppdmuafX/GeVOY/sQP4//QSfuwwhW1R7Xl6MsdxueSlbwy7VTSliwBnmW2SKF0KEKEH9AGbE6Zh9fH9MNrk/K/ZQ26nfTo7no5vJtQ8TSTjkRdloviIyGcEOE7Pmw9PiNOxLVcfH4dR8ObduvX/TIFOQH59c5S1SaCB8b/EUg3oYpj0r4TmHBH/DVBXvRNGRojD1wx+ajNtOTMfo6Ymzf9wPRDIdS5YvicybAKELK4R/lVPv39TxI694T6/4QzekGkuS7P895cw8sPF94DkX+IAeH0PtFBVZbvLyz+rmo7ax+I5DUrX0XWZnKcznRObUfxAIzpu9pL3B1p0w+szwLvLVx1QKKEszul5vO8k9OFhFtoUaUi7ibAOGhg8pB4ZLh+nRmj0MkcsPG3xdOyxfZXeBjl1n3yTTTwP3vtMrSfMz+2FIuz7dh2H66sOIw9s8YOybdQ20a9LO82zrXX4IsHu5E+mDRESxMIL788IihxK9YoXvST8amzpo8/XaXqizz4wGEOzVXnvOR9cmwXjLO9qklotPGV8/5IXk2TNq8JW62qGF1PWRU/KCVgYPN4L7bfuypkUntKJ8eDkGz6cwOvZOFUuUtGjk85reMRU8wmCSi05vxUAA+d+WKCIYKzqQx5obhdjBtd3pZPzazE8sa9HmXMHIoo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(36840700001)(46966006)(40470700004)(6862004)(53546011)(107886003)(82310400005)(54906003)(26005)(6506007)(86362001)(6512007)(40480700001)(6486002)(41300700001)(47076005)(478600001)(82740400003)(36860700001)(8676002)(2616005)(336012)(186003)(40460700003)(81166007)(83380400001)(70586007)(316002)(5660300002)(356005)(30864003)(2906002)(33656002)(36756003)(4326008)(70206006)(8936002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 15:08:00.5129 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e81dab6-1457-4637-42c9-08da8cf4ed3e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9790 SGkgSnVsaWVuLA0KDQo+IE9uIDEgU2VwIDIwMjIsIGF0IDc6MDcgcG0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgUmFodWwsDQo+IA0KPiBPbiAwMS8wOS8y MDIyIDEwOjEzLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEludHJvZHVjZSBhIG5ldyBzdWItbm9k ZSB1bmRlciAvY2hvc2VuIG5vZGUgdG8gZXN0YWJsaXNoIHN0YXRpYyBldmVudA0KPj4gY2hhbm5l bCBjb21tdW5pY2F0aW9uIGJldHdlZW4gZG9tYWlucyBvbiBkb20wbGVzcyBzeXN0ZW1zLg0KPj4g QW4gZXZlbnQgY2hhbm5lbCB3aWxsIGJlIGNyZWF0ZWQgYmVmb3JlaGFuZCB0byBhbGxvdyB0aGUg ZG9tYWlucyB0bw0KPj4gc2VuZCBub3RpZmljYXRpb25zIHRvIGVhY2ggb3RoZXIuDQo+PiBTaWdu ZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+IC0tLQ0KPj4g Q2hhbmdlcyBpbiB2MzoNCj4+ICAtIHVzZSBkZXZpY2UtdHJlZSB1c2VkX2J5IHRvIGZpbmQgdGhl IGRvbWFpbiBpZCBvZiB0aGUgZXZ0Y2huIG5vZGUuDQo+PiAgLSBhZGQgbmV3IHN0YXRpY19ldnRj aG5fY3JlYXRlIHZhcmlhYmxlIGluIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSB0bw0KPj4gICAgaG9s ZCB0aGUgaW5mb3JtYXRpb24gaWYgZXZ0Y2huIGlzIGFscmVhZHkgY3JlYXRlZC4NCj4+ICAtIGZp eCBtaW5vciBjb21tZW50cw0KPj4gQ2hhbmdlcyBpbiB2MjoNCj4+ICAtIG5vIGNoYW5nZQ0KPj4g LS0tDQo+PiAgZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCB8ICA2NCArKysr KysrKysrKystDQo+PiAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAgICAgICAgICB8IDEy OCArKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gIHhlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9zZXR1cC5oICAgICAgfCAgIDEgKw0KPj4gIHhlbi9hcmNoL2FybS9zZXR1cC5jICAgICAgICAg ICAgICAgICAgfCAgIDIgKw0KPj4gIHhlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oICAgICAg ICAgfCAgMTMgKysrDQo+PiAgNSBmaWxlcyBjaGFuZ2VkLCAyMDcgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQ0KPj4gZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9v dGluZy50eHQgYi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0DQo+PiBpbmRl eCA5ODI1MzQxNGI4Li5lZGVmOThlNmQxIDEwMDY0NA0KPj4gLS0tIGEvZG9jcy9taXNjL2FybS9k ZXZpY2UtdHJlZS9ib290aW5nLnR4dA0KPj4gKysrIGIvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJl ZS9ib290aW5nLnR4dA0KPj4gQEAgLTIxMiw3ICsyMTIsNyBAQCB3aXRoIHRoZSBmb2xsb3dpbmcg cHJvcGVydGllczoNCj4+ICAgICAgZW5hYmxlIG9ubHkgc2VsZWN0ZWQgaW50ZXJmYWNlcy4NCj4+ ICAgIFVuZGVyIHRoZSAieGVuLGRvbWFpbiIgY29tcGF0aWJsZSBub2RlLCBvbmUgb3IgbW9yZSBz dWItbm9kZXMgYXJlIHByZXNlbnQNCj4+IC1mb3IgdGhlIERvbVUga2VybmVsIGFuZCByYW1kaXNr Lg0KPj4gK2ZvciB0aGUgRG9tVSBrZXJuZWwsIHJhbWRpc2sgYW5kIHN0YXRpYyBldmVudCBjaGFu bmVsLg0KPj4gICAgVGhlIGtlcm5lbCBzdWItbm9kZSBoYXMgdGhlIGZvbGxvd2luZyBwcm9wZXJ0 aWVzOg0KPj4gIEBAIC0yNTQsMTEgKzI1NCw0NCBAQCBUaGUgcmFtZGlzayBzdWItbm9kZSBoYXMg dGhlIGZvbGxvd2luZyBwcm9wZXJ0aWVzOg0KPj4gICAgICBwcm9wZXJ0eSBiZWNhdXNlIGl0IHdp bGwgYmUgY3JlYXRlZCBieSB0aGUgVUVGSSBzdHViIG9uIGJvb3QuDQo+PiAgICAgIFRoaXMgb3B0 aW9uIGlzIG5lZWRlZCBvbmx5IHdoZW4gVUVGSSBib290IGlzIHVzZWQuDQo+PiAgK1RoZSBzdGF0 aWMgZXZlbnQgY2hhbm5lbCBzdWItbm9kZSBoYXMgdGhlIGZvbGxvd2luZyBwcm9wZXJ0aWVzOg0K Pj4gKw0KPj4gKy0gY29tcGF0aWJsZQ0KPj4gKw0KPj4gKyAgICAieGVuLGV2dGNobiINCj4+ICsN Cj4+ICstIHhlbixldnRjaG4NCj4+ICsNCj4+ICsgICAgVGhlIHByb3BlcnR5IGlzIHR1cGxlcyBv ZiB0d28gbnVtYmVycw0KPj4gKyAgICAobG9jYWwtZXZ0Y2huIGxpbmstdG8tZm9yZWlnbi1ldnRj aG4pIHdoZXJlOg0KPj4gKw0KPj4gKyAgICBsb2NhbC1ldnRjaG4gaXMgYW4gaW50ZWdlciB2YWx1 ZSB0aGF0IHdpbGwgYmUgdXNlZCB0byBhbGxvY2F0ZSBsb2NhbCBwb3J0DQo+PiArICAgIGZvciBh IGRvbWFpbiB0byBzZW5kIGFuZCByZWNlaXZlIGV2ZW50IG5vdGlmaWNhdGlvbnMgdG8vZnJvbSB0 aGUgcmVtb3RlDQo+PiArICAgIGRvbWFpbi4gTWF4aW11bSBzdXBwb3J0ZWQgdmFsdWUgaXMgMl4x NyBmb3IgRklGTyBBQkkgYW5kIDQwOTYgZm9yIDJMIEFCSS4NCj4+ICsgICAgSXQgaXMgcmVjb21t ZW5kZWQgdG8gdXNlIGxvdyBldmVudCBjaGFubmVsIElEcy4NCj4+ICsNCj4+ICsgICAgbGluay10 by1mb3JlaWduLWV2dGNobiBpcyBhIHNpbmdsZSBwaGFuZGxlIHRvIGEgcmVtb3RlIGV2dGNobiB0 byB3aGljaA0KPj4gKyAgICBsb2NhbC1ldnRjaG4gd2lsbCBiZSBjb25uZWN0ZWQuDQo+PiAgICBF eGFtcGxlDQo+PiAgPT09PT09PQ0KPj4gICAgY2hvc2VuIHsNCj4+ICsNCj4+ICsgICAgbW9kdWxl QDAgew0KPj4gKyAgICAgICAgY29tcGF0aWJsZSA9ICJtdWx0aWJvb3Qsa2VybmVsIiwgIm11bHRp Ym9vdCxtb2R1bGUiOw0KPj4gKyAgICAgICAgeGVuLHVlZmktYmluYXJ5ID0gIi4uLiI7DQo+PiAr ICAgICAgICBib290YXJncyA9ICIuLi4iOw0KPj4gKw0KPj4gKyAgICB9Ow0KPiANCj4gTklUOiBE ZXNjcmliaW5nIHRoaXMgbm9kZSBpbiB0aGUgZXhhbXBsZSBzZWVtcyB1bm5lY2Vzc2FyeS4NCg0K QWNrLiBJIHdpbGwgcmVtb3ZlIHRoaXMuDQo+IA0KPj4gKw0KPj4gKyAgICAvKiBvbmUgc3ViLW5v ZGUgcGVyIGxvY2FsIGV2ZW50IGNoYW5uZWwgKi8NCj4+ICsgICAgZWMxOiBldnRjaG5AMSB7DQo+ PiArICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZXZ0Y2huLXYxIjsNCj4+ICsgICAgICAgICAv KiBsb2NhbC1ldnRjaG4gbGluay10by1mb3JlaWduLWV2dGNobiAqLw0KPj4gKyAgICAgICAgIHhl bixldnRjaG4gPSA8MHhhICZlYzI+Ow0KPj4gKyAgICB9Ow0KPj4gKw0KPiANCj4gSGVyZSB5b3Ug cHJvdmlkZSBhbiBleGFtcGxlIGZvciBkb20wLiBCdXQgdGhlIHBvc2l0aW9uIHdoZXJlIHlvdSBk ZXNjcmliZSB0aGUgYmluZGluZyBzdWdnZXN0cyB0aGlzIGJpbmRpbmcgb25seSBleGlzdHMgZm9y IGRvbVVzLg0KPiANCj4gRWl0aGVyIHdlIGR1cGxpY2F0ZSB0aGUgYmluZGluZyBvciB3ZSByZS1v cmRlciB0aGUgZG9jdW1lbnRhdGlvbiB0byBoYXZlIGNvbW1vbiBiaW5kaW5nIGluIGEgc2luZ2xl IHBsYWNlLiBNeSBwcmVmZXJlbmNlIHdvdWxkIGJlIHRoZSBsYXR0ZXIuDQo+IA0KDQpBY2suIA0K Pj4gICAgICBkb21VMSB7DQo+PiAgICAgICAgICBjb21wYXRpYmxlID0gInhlbixkb21haW4iOw0K Pj4gICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MHgyPjsNCj4+IEBAIC0yNzcsNiArMzEwLDIz IEBAIGNob3NlbiB7DQo+PiAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJtdWx0aWJvb3QscmFt ZGlzayIsICJtdWx0aWJvb3QsbW9kdWxlIjsNCj4+ICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4 NGIwMDAwMDAgMHhmZmZmZmY+Ow0KPj4gICAgICAgICAgfTsNCj4+ICsNCj4+ICsgICAgICAgIC8q IG9uZSBzdWItbm9kZSBwZXIgbG9jYWwgZXZlbnQgY2hhbm5lbCAqLw0KPj4gKyAgICAgICAgZWMy OiBldnRjaG5AMiB7DQo+PiArICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZXZ0Y2huLXYx IjsNCj4+ICsgICAgICAgICAgICAvKiBsb2NhbC1ldnRjaG4gbGluay10by1mb3JlaWduLWV2dGNo biAqLw0KPj4gKyAgICAgICAgICAgIHhlbixldnRjaG4gPSA8MHhhICZlYzE+Ow0KPj4gKyAgICAg ICAgfTsNCj4+ICsNCj4+ICsgICAgICAgIGVjMzogZXZ0Y2huQDMgew0KPj4gKyAgICAgICAgICAg IGNvbXBhdGlibGUgPSAieGVuLGV2dGNobi12MSI7DQo+PiArICAgICAgICAgICAgeGVuLGV2dGNo biA9IDwweGIgJmVjNT47DQo+PiArICAgICAgICB9Ow0KPj4gKw0KPj4gKyAgICAgICAgZWM0OiBl dnRjaG5ANCB7DQo+PiArICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZXZ0Y2huLXYxIjsN Cj4+ICsgICAgICAgICAgICB4ZW4sZXZ0Y2huID0gPDB4YyAmZWM2PjsNCj4+ICsgICAgICAgIH07 DQo+PiAgICAgIH07DQo+PiAgICAgICAgZG9tVTIgew0KPj4gQEAgLTI5Niw2ICszNDYsMTggQEAg Y2hvc2VuIHsNCj4+ICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm11bHRpYm9vdCxyYW1kaXNr IiwgIm11bHRpYm9vdCxtb2R1bGUiOw0KPj4gICAgICAgICAgICAgIHJlZyA9IDwweDAgMHg0ZDAw MDAwMCAweGZmZmZmZj47DQo+PiAgICAgICAgICB9Ow0KPj4gKw0KPj4gKyAgICAgICAgLyogb25l IHN1Yi1ub2RlIHBlciBsb2NhbCBldmVudCBjaGFubmVsICovDQo+PiArICAgICAgICBlYzU6IGV2 dGNobkA1IHsNCj4+ICsgICAgICAgICAgICBjb21wYXRpYmxlID0gInhlbixldnRjaG4tdjEiOw0K Pj4gKyAgICAgICAgICAgIC8qIGxvY2FsLWV2dGNobiBsaW5rLXRvLWZvcmVpZ24tZXZ0Y2huICov DQo+PiArICAgICAgICAgICAgeGVuLGV2dGNobiA9IDwweGIgJmVjMz47DQo+PiArICAgICAgICB9 Ow0KPj4gKw0KPj4gKyAgICAgICAgZWM2OiBldnRjaG5ANiB7DQo+PiArICAgICAgICAgICAgY29t cGF0aWJsZSA9ICJ4ZW4sZXZ0Y2huLXYxIjsNCj4+ICsgICAgICAgICAgICB4ZW4sZXZ0Y2huID0g PDB4ZCAmZWM0PjsNCj4+ICsgICAgICAgIH07DQo+PiAgICAgIH07DQo+PiAgfTsNCj4+ICBkaWZm IC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFp bl9idWlsZC5jDQo+PiBpbmRleCA3MDdlMjQ3ZjZhLi40YjI0MjYxODI1IDEwMDY0NA0KPj4gLS0t IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9t YWluX2J1aWxkLmMNCj4+IEBAIC0zMyw2ICszMyw4IEBADQo+PiAgI2luY2x1ZGUgPHhlbi9ncmFu dF90YWJsZS5oPg0KPj4gICNpbmNsdWRlIDx4ZW4vc2VyaWFsLmg+DQo+PiAgKyNkZWZpbmUgU1RB VElDX0VWVENITl9OT0RFX1NJWkVfQ0VMTFMgMg0KPj4gKw0KPj4gIHN0YXRpYyB1bnNpZ25lZCBp bnQgX19pbml0ZGF0YSBvcHRfZG9tMF9tYXhfdmNwdXM7DQo+PiAgaW50ZWdlcl9wYXJhbSgiZG9t MF9tYXhfdmNwdXMiLCBvcHRfZG9tMF9tYXhfdmNwdXMpOw0KPj4gIEBAIC0zMDUyLDYgKzMwNTQs MTMxIEBAIHZvaWQgX19pbml0IGV2dGNobl9hbGxvY2F0ZShzdHJ1Y3QgZG9tYWluICpkKQ0KPj4g ICAgICBkLT5hcmNoLmh2bS5wYXJhbXNbSFZNX1BBUkFNX0NBTExCQUNLX0lSUV0gPSB2YWw7DQo+ PiAgfQ0KPj4gICtzdGF0aWMgaW50IF9faW5pdCBnZXRfZXZ0Y2huX2R0X3Byb3BlcnR5KGNvbnN0 IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbnAsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1aW50MzJfdCAqcG9ydCwgdWludDMyX3QgKnBoYW5kbGUpDQo+PiAr ew0KPj4gKyAgICBjb25zdCBfX2JlMzIgKnByb3AgPSBOVUxMOw0KPj4gKyAgICB1aW50MzJfdCBs ZW47DQo+PiArDQo+PiArICAgIHByb3AgPSBkdF9nZXRfcHJvcGVydHkobnAsICJ4ZW4sZXZ0Y2hu IiwgJmxlbik7DQo+PiArICAgIGlmICggIXByb3AgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBw cmludGsoWEVOTE9HX0VSUiAieGVuLGV2dGNobiBwcm9wZXJ0eSBzaG91bGQgbm90IGJlIGVtcHR5 LlxuIik7DQo+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4g KyAgICBpZiAoICFsZW4gfHwgbGVuIDwgZHRfY2VsbHNfdG9fc2l6ZShTVEFUSUNfRVZUQ0hOX05P REVfU0laRV9DRUxMUykgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VS UiAieGVuLGV2dGNobiBwcm9wZXJ0eSB2YWx1ZSBpcyBub3QgdmFsaWQuXG4iKTsNCj4+ICsgICAg ICAgIHJldHVybiAtRUlOVkFMOw0KPj4gKyAgICB9DQo+PiArDQo+PiArICAgICpwb3J0ID0gZHRf bmV4dF9jZWxsKDEsICZwcm9wKTsNCj4+ICsgICAgKnBoYW5kbGUgPSBkdF9uZXh0X2NlbGwoMSwg JnByb3ApOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGlj IGludCBfX2luaXQgYWxsb2NfZG9tYWluX2V2dGNobihzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5v ZGUpDQo+PiArew0KPj4gKyAgICBpbnQgcmM7DQo+PiArICAgIHVpbnQzMl90IGRvbVUxX3BvcnQs IGRvbVUyX3BvcnQsIHJlbW90ZV9waGFuZGxlOw0KPj4gKyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25v ZGUgKnJlbW90ZV9ub2RlOw0KPj4gKyAgICBzdHJ1Y3QgZXZ0Y2huX2FsbG9jX3VuYm91bmQgYWxs b2NfdW5ib3VuZDsNCj4+ICsgICAgc3RydWN0IGV2dGNobl9iaW5kX2ludGVyZG9tYWluIGJpbmRf aW50ZXJkb21haW47DQo+PiArICAgIHN0cnVjdCBkb21haW4gKmQxID0gTlVMTCwgKmQyID0gTlVM TDsNCj4+ICsNCj4+ICsgICAgaWYgKCBkdF9kZXZpY2Vfc3RhdGljX2V2dGNobl9jcmVhdGVkKG5v ZGUpICkNCj4gDQo+IEkgdGhpbmsgdGhpcyBkZXNlcnZlIGEgY29tbWVudCBleHBsYWluIHdoeSB0 aGUgbm9kZSB3b3VsZCBiZSBjcmVhdGVkLiBJLmUgaXQgd291bGQgaGFwcGVuIGlmIHRoZSBvdGhl ciBzaWRlIHdhcyBjcmVhdGVkIGZpcnN0LiBJIHdpbGwgY29tbWVudCBhYm91dCBkdF9kZXZpY2Vf c3RhdGljX2V2dGNobl9jcmVhdGVkKCkgZnV0aGVyIGRvd24uDQoNCkkgd2lsbCBtb2RpZnkgYXMg YmVsb3c6DQoNCiAvKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQogICogRXZlbnQgY2hhbm5lbCBpcyBhbHJl YWR5IGNyZWF0ZWQgd2hpbGUgcGFyc2luZyB0aGUgb3RoZXIgc2lkZSBvZiAgICAgICAgIA0KICAq IGV2dGNobiBub2RlLiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICANCiAgKi8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQogICBpZiAoIGR0X2Rldmlj ZV9zdGF0aWNfZXZ0Y2huX2NyZWF0ZWQobm9kZSkgKSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgDQogICAgICAgcmV0dXJuIDA7DQo+IA0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiAr DQo+PiArICAgIHJjID0gZ2V0X2V2dGNobl9kdF9wcm9wZXJ0eShub2RlLCAmZG9tVTFfcG9ydCwg JnJlbW90ZV9waGFuZGxlKTsNCj4+ICsgICAgaWYgKCByYyApDQo+PiArICAgICAgICByZXR1cm4g cmM7DQo+PiArDQo+PiArICAgIHJlbW90ZV9ub2RlID0gZHRfZmluZF9ub2RlX2J5X3BoYW5kbGUo cmVtb3RlX3BoYW5kbGUpOw0KPj4gKyAgICBpZiAoICFyZW1vdGVfbm9kZSApDQo+PiArICAgIHsN Cj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+PiArICAgICAgICAgICAgICAgICJldnRj aG46IGNvdWxkIG5vdCBmaW5kIHJlbW90ZSBldnRjaG4gcGhhbmRsZVxuIik7DQo+PiArICAgICAg ICByZXR1cm4gLUVJTlZBTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICByYyA9IGdldF9ldnRj aG5fZHRfcHJvcGVydHkocmVtb3RlX25vZGUsICZkb21VMl9wb3J0LCAmcmVtb3RlX3BoYW5kbGUp Ow0KPj4gKyAgICBpZiAoIHJjICkNCj4+ICsgICAgICAgIHJldHVybiByYzsNCj4+ICsNCj4+ICsg ICAgaWYgKCBub2RlLT5waGFuZGxlICE9IHJlbW90ZV9waGFuZGxlICkNCj4+ICsgICAgew0KPj4g KyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgInhlbixldnRjaG4gcHJvcGVydHkgaXMgbm90IHNl dHVwIGNvcnJlY3RseS5cbiIpOw0KPj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+PiArICAg IH0NCj4+ICsNCj4+ICsgICAgZDEgPSBnZXRfZG9tYWluX2J5X2lkKGR0X2dldF9wYXJlbnQobm9k ZSktPnVzZWRfYnkpOw0KPj4gKyAgICBkMiA9IGdldF9kb21haW5fYnlfaWQoZHRfZ2V0X3BhcmVu dChyZW1vdGVfbm9kZSktPnVzZWRfYnkpOw0KPiANCj4gSSB0aGluayBkdF9nZXRfcGFyZW50KCkg Y291bGQgcmV0dXJuIE5VTEwgKGkuZS4gZm9yIHRoZSByb290KS4gU28gSSB0aGluayB5b3Ugd2Fu dCB0byBjaGVjayB0aGF0IGF0IGxlYXN0IHJlbW90ZV9ub2RlKCkgaGFzIGEgcGFyZW50LiBGb3Ig Y29udmVuaWVuY2UsIHRoaXMgY2hlY2sgY291bGQgYmUgZG9uZSBpbg0KDQpBY2suIA0KPiANCj4+ ICsNCj4+ICsgICAgaWYgKCAhZDEgfHwgIWQyICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgcHJp bnRrKFhFTkxPR19FUlIgImV2dGNobjogY291bGQgbm90IGZpbmQgZG9tYWluc1xuIiApOw0KPj4g KyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgYWxsb2Nf dW5ib3VuZC5kb20gPSBkMS0+ZG9tYWluX2lkOw0KPj4gKyAgICBhbGxvY191bmJvdW5kLnJlbW90 ZV9kb20gPSBkMi0+ZG9tYWluX2lkOw0KPj4gKw0KPj4gKyAgICByYyA9IGV2dGNobl9hbGxvY191 bmJvdW5kKCZhbGxvY191bmJvdW5kLCBkb21VMV9wb3J0KTsNCj4+ICsgICAgaWYgKCByYyA8IDAg KQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPj4gKyAgICAgICAg ICAgICAgICAiZXZ0Y2huX2FsbG9jX3VuYm91bmQoKSBmYWlsdXJlIChFcnJvciAlZCkgXG4iLCBy Yyk7DQo+PiArICAgICAgICByZXR1cm4gcmM7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgYmlu ZF9pbnRlcmRvbWFpbi5yZW1vdGVfZG9tICA9IGQxLT5kb21haW5faWQ7DQo+PiArICAgIGJpbmRf aW50ZXJkb21haW4ucmVtb3RlX3BvcnQgPSBkb21VMV9wb3J0Ow0KPj4gKw0KPj4gKyAgICByYyA9 IGV2dGNobl9iaW5kX2ludGVyZG9tYWluKCZiaW5kX2ludGVyZG9tYWluLCBkMiwgZG9tVTJfcG9y dCk7DQo+PiArICAgIGlmICggcmMgPCAwICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgcHJpbnRr KFhFTkxPR19FUlINCj4+ICsgICAgICAgICAgICAgICAgImV2dGNobl9iaW5kX2ludGVyZG9tYWlu KCkgZmFpbHVyZSAoRXJyb3IgJWQpIFxuIiwgcmMpOw0KPj4gKyAgICAgICAgcmV0dXJuIHJjOw0K Pj4gKyAgICB9DQo+PiArDQo+PiArICAgIGR0X2RldmljZV9zZXRfc3RhdGljX2V2dGNobl9jcmVh dGVkKG5vZGUpOw0KPj4gKyAgICBkdF9kZXZpY2Vfc2V0X3N0YXRpY19ldnRjaG5fY3JlYXRlZChy ZW1vdGVfbm9kZSk7DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4gK30NCj4+ICsNCj4+ICt2 b2lkIF9faW5pdCBwcm9jZXNzX3N0YXRpY19ldnRjaG5fbm9kZShzdHJ1Y3QgZHRfZGV2aWNlX25v ZGUgKm5vZGUpDQo+IA0KPiBUaGlzIGlzIG1pc3NpbmcgYSBwcm90b3R5cGUuIFNvIEkgZ3Vlc3Mg dGhpcyB3YW50cyB0byBiZSBzdGF0aWM/DQo+IA0KPiBUaGF0IHNhaWQsIEkgdGhpbmsgaXQgd291 bGQgbWFrZSBtb3JlIHNlbnNlIHRvIGZvbGQgcHJvY2Vzc19zdGF0aWNfZXZ0Y2huX25vZGUoKSBp biBhbGxvY19kb21haW5fZXZ0Y2huKCkgb3IgYWxsb2Nfc3RhdGljLWV2dGNobigpLg0KDQpBY2su IA0KPiANCj4+ICt7DQo+PiArICAgIGlmICggZHRfZGV2aWNlX2lzX2NvbXBhdGlibGUobm9kZSwg InhlbixldnRjaG4tdjEiKSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGlmICggYWxsb2NfZG9t YWluX2V2dGNobihub2RlKSAhPSAwICkNCj4+ICsgICAgICAgICAgICBwYW5pYygiQ291bGQgbm90 IHNldCB1cCBkb21haW5zIGV2dGNoblxuIik7DQo+PiArICAgIH0NCj4+ICt9DQo+PiArDQo+PiAr dm9pZCBfX2luaXQgYWxsb2Nfc3RhdGljX2V2dGNobih2b2lkKQ0KPj4gK3sNCj4+ICsgICAgc3Ry dWN0IGR0X2RldmljZV9ub2RlICpub2RlLCAqZXZ0Y2huX25vZGU7DQo+PiArICAgIHN0cnVjdCBk dF9kZXZpY2Vfbm9kZSAqY2hvc2VuID0gZHRfZmluZF9ub2RlX2J5X3BhdGgoIi9jaG9zZW4iKTsN Cj4+ICsNCj4+ICsgICAgQlVHX09OKGNob3NlbiA9PSBOVUxMKTsNCj4+ICsNCj4+ICsgICAgaWYg KCBoYXJkd2FyZV9kb21haW4gKQ0KPj4gKyAgICAgICAgZHRfZGV2aWNlX3NldF91c2VkX2J5KGNo b3NlbiwgaGFyZHdhcmVfZG9tYWluLT5kb21haW5faWQpOw0KPj4gKw0KPj4gKyAgICBkdF9mb3Jf ZWFjaF9jaGlsZF9ub2RlKGNob3Nlbiwgbm9kZSkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgaWYg KCBoYXJkd2FyZV9kb21haW4gKQ0KPj4gKyAgICAgICAgICAgIHByb2Nlc3Nfc3RhdGljX2V2dGNo bl9ub2RlKG5vZGUpOw0KPj4gKw0KPj4gKyAgICAgICAgZHRfZm9yX2VhY2hfY2hpbGRfbm9kZShu b2RlLCBldnRjaG5fbm9kZSkNCj4+ICsgICAgICAgICAgICBwcm9jZXNzX3N0YXRpY19ldnRjaG5f bm9kZShldnRjaG5fbm9kZSk7DQo+PiArICAgIH0NCj4+ICt9DQo+PiArDQo+PiAgc3RhdGljIHZv aWQgX19pbml0IGZpbmRfZ250dGFiX3JlZ2lvbihzdHJ1Y3QgZG9tYWluICpkLA0KPj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGtlcm5lbF9pbmZvICpraW5m bykNCj4+ICB7DQo+PiBAQCAtMzM2NCw2ICszNDkxLDcgQEAgdm9pZCBfX2luaXQgY3JlYXRlX2Rv bVVzKHZvaWQpDQo+PiAgICAgICAgICAgICAgcGFuaWMoIkVycm9yIGNyZWF0aW5nIGRvbWFpbiAl c1xuIiwgZHRfbm9kZV9uYW1lKG5vZGUpKTsNCj4+ICAgICAgICAgICAgZC0+aXNfY29uc29sZSA9 IHRydWU7DQo+PiArICAgICAgICBkdF9kZXZpY2Vfc2V0X3VzZWRfYnkobm9kZSwgZC0+ZG9tYWlu X2lkKTsNCj4+ICAgICAgICAgICAgaWYgKCBjb25zdHJ1Y3RfZG9tVShkLCBub2RlKSAhPSAwICkN Cj4+ICAgICAgICAgICAgICBwYW5pYygiQ291bGQgbm90IHNldCB1cCBkb21haW4gJXNcbiIsIGR0 X25vZGVfbmFtZShub2RlKSk7DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUv YXNtL3NldHVwLmggYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPj4gaW5kZXgg NTgxNWNjZjhjNS4uNWVlMjhiMjcwZiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNs dWRlL2FzbS9zZXR1cC5oDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAu aA0KPj4gQEAgLTEwNiw2ICsxMDYsNyBAQCBpbnQgYWNwaV9tYWtlX2VmaV9ub2Rlcyh2b2lkICpm ZHQsIHN0cnVjdCBtZW1iYW5rIHRibF9hZGRbXSk7DQo+PiAgICB2b2lkIGNyZWF0ZV9kb21Vcyh2 b2lkKTsNCj4+ICB2b2lkIGNyZWF0ZV9kb20wKHZvaWQpOw0KPj4gK3ZvaWQgYWxsb2Nfc3RhdGlj X2V2dGNobih2b2lkKTsNCj4+ICAgIHZvaWQgZGlzY2FyZF9pbml0aWFsX21vZHVsZXModm9pZCk7 DQo+PiAgdm9pZCBmd191bnJlc2VydmVkX3JlZ2lvbnMocGFkZHJfdCBzLCBwYWRkcl90IGUsDQo+ PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NldHVwLmMgYi94ZW4vYXJjaC9hcm0vc2V0dXAu Yw0KPj4gaW5kZXggNmUwMzk4ZjNmNi4uY2YxNWQzNTlkMiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9h cmNoL2FybS9zZXR1cC5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPj4gQEAgLTEw NzcsNiArMTA3Nyw4IEBAIHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25nIGJvb3Rf cGh5c19vZmZzZXQsDQo+PiAgICAgIGlmICggYWNwaV9kaXNhYmxlZCApDQo+PiAgICAgICAgICBj cmVhdGVfZG9tVXMoKTsNCj4+ICArICAgIGFsbG9jX3N0YXRpY19ldnRjaG4oKTsNCj4+ICsNCj4+ ICAgICAgLyoNCj4+ICAgICAgICogVGhpcyBuZWVkcyB0byBiZSBjYWxsZWQgKipiZWZvcmUqKiBo ZWFwX2luaXRfbGF0ZSgpIHNvIG1vZHVsZXMNCj4+ICAgICAgICogd2lsbCBiZSBzY3J1YmJlZCAo dW5sZXNzIHN1cHByZXNzZWQpLg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3hlbi9kZXZp Y2VfdHJlZS5oIGIveGVuL2luY2x1ZGUveGVuL2RldmljZV90cmVlLmgNCj4+IGluZGV4IDQzMGEx ZWY0NDUuLjU1NzljODc1ZDIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vZGV2aWNl X3RyZWUuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2RldmljZV90cmVlLmgNCj4+IEBAIC04 Miw2ICs4Miw3IEBAIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSB7DQo+PiAgICAgIGR0X3BoYW5kbGUg cGhhbmRsZTsNCj4+ICAgICAgY2hhciAqZnVsbF9uYW1lOw0KPj4gICAgICBkb21pZF90IHVzZWRf Ynk7IC8qIEJ5IGRlZmF1bHQgaXQncyB1c2VkIGJ5IGRvbTAgKi8NCj4+ICsgICAgYm9vbF90IHN0 YXRpY19ldnRjaG5fY3JlYXRlZDsNCj4gDQo+IEkgY2FuIHNlZSB3aHkgeW91IHdhbnQgdG8gYWRk IHRoZSBib29sZWFuIGluIGR0X2RldmljZV9ub2RlLiBIb3dldmVyLCBJIGRpc2xpa2UgdGhpcyBh cHByb2FjaCBiZWNhdXNlIHRoaXMgZmVlbHMgYW4gYWJ1c2Ugb2YgZHRfZGV2aWNlX25vZGUgYW5k IHRoZSBmaWVsZCBpcyBvbmx5IHVzZWQgYXQgYm9vdC4NCj4gDQo+IFNvIHRoaXMgc2VlbXMgdG8g YmUgYSBiaXQgb2YgYSB3YXN0ZSB0byBpbmNsdWRlIGl0IGluIHRoZSBzdHJ1Y3R1cmUgKGV2ZW4g aWYgd2UgYXJlIHJlLXVzaW5nIHBhZGRpbmcgdG9kYXkpLg0KPiANCj4gSSBkb24ndCBoYXZlIGEg c29sdXRpb24gdGhhdCBpcyBoYXMgdHJpdmlhbCBhcyB0aGlzIGFwcHJvYWNoLiBIb3dldmVyLCBh dCBtaW5pbXVtIHdlIHNob3VsZCBkb2N1bWVudCB0aGlzIGlzIGEgSEFDSyBhbmQgc2hvdWxkIGJl IHJlbW92ZSBpZiB3ZSBuZWVkIHNwYWNlIGluIHRoZSBzdHJ1Y3R1cmUuDQogDQpPay4gSSB3aWxs IGFkZCB0aGUgY29tbWVudCB0aGF0IHRoaXMgaXMgSEFDSy4NCg0K4oCmLg0KICAgICAvKiBJT01N VSBzcGVjaWZpYyBmaWVsZHMgKi8NCiAgICAgYm9vbCBpc19wcm90ZWN0ZWQ7DQorDQorICAgIC8q IEhBQ0s6IFJlbW92ZSB0aGlzIGlmIHRoZXJlIGlzIGEgbmVlZCBvZiBzcGFjZSAqLw0KKyAgICBi b29sX3Qgc3RhdGljX2V2dGNobl9jcmVhdGVkOw0KKw0KICAgICAvKg0KICAgICAgKiBUaGUgbWFp biBwdXJwb3NlIG9mIHRoaXMgbGlzdCBpcyB0byBsaW5rIHRoZSBzdHJ1Y3R1cmUgaW4gdGhlIGxp c3QNCiAgICAgICogb2YgZGV2aWNlcyBhc3NpZ25lZCB0byBkb21haW4uDQrigKYuDQoNClJlZ2Fy ZHMsDQpSYWh1bA== From xen-devel-bounces@lists.xenproject.org Fri Sep 02 15:12:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 15:12:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397831.638522 (Exim 4.92) (envelope-from ) id 1oU8LR-0001ja-Qo; Fri, 02 Sep 2022 15:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397831.638522; Fri, 02 Sep 2022 15:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8LR-0001jT-Nz; Fri, 02 Sep 2022 15:12:33 +0000 Received: by outflank-mailman (input) for mailman id 397831; Fri, 02 Sep 2022 15:12:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8LQ-0001jJ-0d; Fri, 02 Sep 2022 15:12:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8LP-0000V8-UN; Fri, 02 Sep 2022 15:12:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU8LP-0007HO-IV; Fri, 02 Sep 2022 15:12:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU8LP-0000eX-I1; Fri, 02 Sep 2022 15:12:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=stQl8CaB6PgRH0jlef4qIHxG04XhPP3AUtNddqVX0dA=; b=jtfsdebAX82cMLUFE+AP1vnDQX wWKWznCi45Ae6oYbnUJ/sA/byq/vq3bR2VBV2HcLs0NbsIXDvmLHgoz8pSU5yzFZUSkjxCuaMPYnV ZdUK7yxr3BPKsu86QciggMUHMlFzVdfYBmNOnapSfq1H6/1TnmTUO0DCyTATDaPayFlA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172935: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 15:12:31 +0000 flight 172935 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172935/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 225 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 15:55:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 15:55:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397842.638539 (Exim 4.92) (envelope-from ) id 1oU90J-0005xK-4c; Fri, 02 Sep 2022 15:54:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397842.638539; Fri, 02 Sep 2022 15:54:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU90J-0005xD-0b; Fri, 02 Sep 2022 15:54:47 +0000 Received: by outflank-mailman (input) for mailman id 397842; Fri, 02 Sep 2022 15:54:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU90G-0005x7-Rv for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 15:54:45 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e6b6b61-2ad7-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 17:54:41 +0200 (CEST) Received: from DU2P250CA0013.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::18) by PR3PR08MB5753.eurprd08.prod.outlook.com (2603:10a6:102:87::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 15:54:39 +0000 Received: from DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::d9) by DU2P250CA0013.outlook.office365.com (2603:10a6:10:231::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15 via Frontend Transport; Fri, 2 Sep 2022 15:54:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT064.mail.protection.outlook.com (100.127.143.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Fri, 2 Sep 2022 15:54:38 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 02 Sep 2022 15:54:38 +0000 Received: from 175e8593f4dd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2DCF786C-9DE0-49DE-8B35-8220CA2D3EC9.1; Fri, 02 Sep 2022 15:54:32 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 175e8593f4dd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Sep 2022 15:54:32 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DB9PR08MB9490.eurprd08.prod.outlook.com (2603:10a6:10:45b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 15:54:30 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.012; Fri, 2 Sep 2022 15:54:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e6b6b61-2ad7-11ed-82f2-63bd783d45fa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=S6NIC2IroUJP8de6BYtVsnbSuIaVHWfgWoQ8fnB4mx8enrpaXuIs61xpO0QT8wpd5JObiENOXfVU9OQ8ILOf8oVniWoD3uC7Qy4soNUPl4i6bQR0ktI9ta++Lii1RLKIxru8uRl9njb1R1ol/5cmR+Q82qziO0iZiR2CnCby9ZPCpghhsYFsNdJLOgOB8iZTHZQkGKhevsy5NcwQth9WgASA0aS/urk4glqjdQGvHYfLks0uyxGg0cgvpIsPnN006H/0NYnUkQt+b9NylgPODfq8uNDw3kw1rmU36icmvqmgmtG9TQv6TZQEboEyUJCYQsD/C7ime57MEPW9xZ+gFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yTsAaJE72t/O9Bq6IlWOFuulUXKMbzN0cp7XPNDqjYM=; b=R+JOCLkVAeT5+QM5veE9y+4nUYa3X29Zi0sXGa9S7/acktVMtRrAF6fQrIddiUifmxiOuzqJFUMcAJKvhjhayqWLliYMAHP9VY8ywQeX4kjNZsszAtrgr/GRmFSK+mIFPUS/yO5UlxXtgapO2FIy7YjSWqon8jPlpThoj6ip64BHPrbPsykzfCNGfjiZqBxgwC6go1hx/uCfIAb/E0UZRC5hWbxirFCKKxLqCb2ilV9QiLBBzV5ynD2NyI3mtLbf44cVLITUHplElSw+JlupXcjNljQhYhT8D5d+YJtcZv0CxUx54Sk51byYVxPq4fNMIJ7pouLXSW82sBXlwwa1kQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yTsAaJE72t/O9Bq6IlWOFuulUXKMbzN0cp7XPNDqjYM=; b=GfGWMhSTB3JG0iNsNfiEAHeYA9KgBvnJgvQXimzq3Wiz4ghSSxOxh091RnIjgh2sTvZS8efjAUabW6/V6/kIvFgOTY8C8wv/+n0xYKof0jU8QGY5moaHm25iglcqpMux/ZClmE5Njo412vbs/kX6Jv81fD0gKHKaYFMrWyIlyhE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: df1eb71335e77fb1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGipvzuzPO2Ma96Xxyf3e3EcbtbCpjTBw/yYFzLC9JsFDNEMo2iuEYIpa/6Fu0AnxLhsLgm+Ft1WZkahmga+EDWngUoyX1eW8bXItnDPQgiD3d67q53ETDvHCiC04ieI1N4jMZfkl+wGXXWTZUhLe8ec2ZU+4tBy0wGtyxUlMyCrrP6w+BQI0BuiIvW0e6KYLJ65d8y990oqBMa2ajnLFBoPDyDK8HhDwDI3N5DNHFn6XSeKWK2XLG7IQfoEJnLWqWEYuthDGjSyhf9pNubp8sIMSmuI+Tch+qVHBfLgSlMSuqyEmNpZx+J6E42IITOObHxHpaUPz+1ROZOG+xGXwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yTsAaJE72t/O9Bq6IlWOFuulUXKMbzN0cp7XPNDqjYM=; b=Mdeoi2ifzntYYY+909jtZuhYRHfuzJFZJA4lFyRBfvHsxVKzOTRHrZG2PofXN9/I+0zhp1Gw8h9EAyRIbWm/1pxbd3BhkBbES6fhPnAqOOGDDHucg7h2E0z8JCeL2KnXKpTk1nfzR1GrVpae6vTCN+d8NMXRXAt0QjyEvky1Urd+OeponIn0G+i7Hq+k19I5uBJJJTnCa+Z918imSShuJF2km6XCerV/0SKAz1Tpcxndshu9+hZCB2DD2jUpUAgQnVrEJSFcO5cdtsY0l1PmgexHGA1T8AEVvFGfsvRceMbC9uuEpIkYbM/zJg48Cm/zkDz8qmivqJtue/AwB/SMlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yTsAaJE72t/O9Bq6IlWOFuulUXKMbzN0cp7XPNDqjYM=; b=GfGWMhSTB3JG0iNsNfiEAHeYA9KgBvnJgvQXimzq3Wiz4ghSSxOxh091RnIjgh2sTvZS8efjAUabW6/V6/kIvFgOTY8C8wv/+n0xYKof0jU8QGY5moaHm25iglcqpMux/ZClmE5Njo412vbs/kX6Jv81fD0gKHKaYFMrWyIlyhE= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFZKoCAAAQmAIAADY6A Date: Fri, 2 Sep 2022 15:54:30 +0000 Message-ID: <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> In-Reply-To: <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fa2b4320-ab3c-46ec-f508-08da8cfb710d x-ms-traffictypediagnostic: DB9PR08MB9490:EE_|DBAEUR03FT064:EE_|PR3PR08MB5753:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4+qIn+qtCFEyGw85OTM+M7BnF+IpgSznFNeclF3OANT3vPh02kAlo1rNcxwOtuqp5U8yLsx789BnrsExBmnJ5/QuLQ2+grxH0qri1+DKbLkemwX0vCkq0BINJNXyPW1jbqy9L/5yzjG5+xuzCnksDFGgb4hlTudzglaSxblNL93Nq5Y8YhkBgprSyuHMXJ/hgrUVrxUAuVtd0bppFUW7V9D6veFMGrpjOec215am9tpnTpCG10p2LMUnZQWmLEZg+MHZxQD5o3/tpQuI+tTPC58b0J5IbPuTuPdevd9MvOlIRgmkEh4L+MC1UZAXMvXLYeFKyYNjghWDniF+aEMBwQUUt3LyYb/DiZfYt094BqC4iesYhNDfJBCkp583eTLN04ImSR5n7kpQ5BA/6T5fArAcPFxaVw+yT3hyKdZ6+tJHECeZsuBnLrW03G+1DDEV54QEjdOwFY4UCifmCzv1IpYysrkFMK6BUEpnxwwv9O2L0sPzWOfP7c2o+EScjOcqNQkk9RELk0jdYIO45ziV2bH+MqdjPgGnj4if88Sr+v4fcM0Ce1aoojJfsrYKxsBi+NMZM0GRMgO28XNpiIZauWN33dxfyCK2tR3UltsA6Ku/+QL9+OD8yf8w87nNPCiWsAJZP4vWKNz+mWenMiX5hWEFOvVmLsz174lHbljup9+MVJ1zc0+OzxrIdMXrBEqest6cJxGLLRnlYoEP5A/o7+3xgIH7MyBjtkdfRtKjuxk2B7vyq8jQetr33nq6vroIPOtZwT1b6IxRc/aNkHffJ9j5TL8C6KYsFXBR5XOKrts= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(2906002)(38070700005)(53546011)(6506007)(36756003)(5660300002)(41300700001)(8936002)(71200400001)(186003)(4326008)(8676002)(64756008)(478600001)(91956017)(2616005)(33656002)(6486002)(76116006)(66446008)(66476007)(66556008)(66946007)(38100700002)(54906003)(6916009)(26005)(6512007)(122000001)(316002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1FE9E06BB095EF4EA0F09B44F9AD8D49@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9490 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a9a0e399-b624-4a84-deed-08da8cfb6c2f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nmB7ujl332WbQuyyNbRwBsaN+y/uNdnIf3EKLbIMJJlt2SaCFMk0g8ssxepF25cpyC3lPzSrcTLBABp8FN2QNEqvhO0dwoVHg0A7qxJ3V3CpjMCeeVmh6qsEgPXNf0Dab8yB9cNHsYFd0oLW92WOVwGfRLNFPvA4gwlUqrD4df4x1jVu1ZC70oANn8qZZpztwJus93NgX2CJhFaYSAyNWOOVGqPXMy5Uc6G4K3BoipO8oGz+daM8jcZcNDWrafMNCXcjp8CBzPhLTuZ+nIr25xtWDQz8FSJn5ytxlrwoZwWAqTrg9oBxbqWyUWv8fHyM86YubwqMmMfFNGIulZTFsh+8YX3xouZMOCvV5uoEt6ybfWoDqXkcOEk0vrcVPexlZEWvGUuBvaL1qnhYWIsdSyZvEOy4TvjTHD8EmTecseDbijA9NRGFAQSeb26Uo+xhdUrSqUcM/p+cfX0vGg8VOVin9UNK8LffcqetOolyZUr/7OdXHkdJwR3NtQbgzzD5gcBzGKzZx2cgsxenKw5YvqMQqNnQHNKGW6BNDA/GF71+oBZA72WFl55BOzdKDPi36JXZCJhgXvE2q7C+lh/HsqfX4pkUnyPHFmEIfVhdMliE5592cjv/UaPZyv+1vwIcI/1IaPcdmcmem721P+DtHmXXcTncq0GqhVACKl5tKNgztAU+25aqenUopiXqfMPaYJzI3uzAgH87d9P25OCB/RYR4Vgfu3EkAblE/5prOHTtH3rJWhr9xOTsoYxnOQmGzw5lYgqG05lFSILfGj5Juw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(396003)(376002)(36840700001)(40470700004)(46966006)(5660300002)(86362001)(40460700003)(47076005)(6506007)(2616005)(81166007)(186003)(41300700001)(107886003)(6862004)(336012)(8936002)(33656002)(356005)(26005)(53546011)(6512007)(2906002)(36860700001)(40480700001)(82740400003)(82310400005)(70206006)(36756003)(54906003)(478600001)(70586007)(6486002)(8676002)(4326008)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 15:54:38.7610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa2b4320-ab3c-46ec-f508-08da8cfb710d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5753 Hi Julien, > On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 02/09/2022 15:51, Bertrand Marquis wrote: >>> On 1 Sep 2022, at 19:15, Julien Grall wrote: >>> AFAIU, it is not possible to have *_xenstore =3D true and *_enhanced = =3D false. I think it would be clearer if ``dom0less_enhanced`` is turned t= o an enum with 3 values: >>> - None >>> - NOXENSTORE/BASIC >>> - FULLY_ENHANCED >>>=20 >>> If we want to be future proof, I would use a field 'flags' where non-ze= ro means enhanced. Each bit would indicate which features of Xen is exposed= . >> I think that could be a good solution if we do it this way: >> - define a dom0less feature field and have defines like the following: >> #define DOM0LESS_GNTTAB >> #define DOM0LESS_EVENTCHN >> #define DOM0LESS_XENSTORE > >> - define dom0less enhanced as the right combination: >> #define DOM0LESS_ENHANCED =3D (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0L= ESS_XENSTORE) >=20 > I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of = defining a bit for gnttab and evtchn. This will avoid the question of why w= e are introducing bits for both features but not the hypercall... >=20 > As this is an internal interface, it would be easier to modify afterwards= . How about this? /* = =20 * List of possible features for dom0less domUs = =20 * = =20 * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and = =20 * evtchn, will be= enabled for the VM. =20 * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. = =20 * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-table= xenstore =20 * and evtchn, wil= l be enabled for the VM. =20 */ = =20 #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) = =20 #define DOM0LESS_XENSTORE BIT(1, UL) = =20 #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTOR= E) =20 Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Fri Sep 02 16:20:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 16:20:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397849.638550 (Exim 4.92) (envelope-from ) id 1oU9P6-0001Gn-5X; Fri, 02 Sep 2022 16:20:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397849.638550; Fri, 02 Sep 2022 16:20:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9P6-0001Gg-2r; Fri, 02 Sep 2022 16:20:24 +0000 Received: by outflank-mailman (input) for mailman id 397849; Fri, 02 Sep 2022 16:20:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9P4-0001Ga-7o for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 16:20:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9P3-000292-U4; Fri, 02 Sep 2022 16:20:21 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.18.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oU9P3-0000vl-Mq; Fri, 02 Sep 2022 16:20:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=koDpKsnmAyhrxN2S35+Y3Htdwr4K8FjBD8K9eq0iDZg=; b=ZrhcW5FeVsxs/aIHi1vIX2t9wg 4Xk/cHyJrzfq9lMQUqAHdJ7PYlbj0A5WgjWcKRtnBoZSRoFDH7RR+mhfUrWEValQwxeWNQb1GwW33 88argzrbtMUM8m4BZl+ZXnpRaJPLCje4hxrOxQ/EP0GdKqwdf2tzXe2I/3GjINmiZWNQ=; Message-ID: Date: Fri, 2 Sep 2022 17:20:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value To: Rahul Singh Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> Content-Language: en-US From: Julien Grall In-Reply-To: <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/09/2022 16:54, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 02/09/2022 15:51, Bertrand Marquis wrote: >>>> On 1 Sep 2022, at 19:15, Julien Grall wrote: >>>> AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an enum with 3 values: >>>> - None >>>> - NOXENSTORE/BASIC >>>> - FULLY_ENHANCED >>>> >>>> If we want to be future proof, I would use a field 'flags' where non-zero means enhanced. Each bit would indicate which features of Xen is exposed. >>> I think that could be a good solution if we do it this way: >>> - define a dom0less feature field and have defines like the following: >>> #define DOM0LESS_GNTTAB >>> #define DOM0LESS_EVENTCHN >>> #define DOM0LESS_XENSTORE > >>> - define dom0less enhanced as the right combination: >>> #define DOM0LESS_ENHANCED = (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0LESS_XENSTORE) >> >> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of defining a bit for gnttab and evtchn. This will avoid the question of why we are introducing bits for both features but not the hypercall... >> >> As this is an internal interface, it would be easier to modify afterwards. > > How about this? > > /* > * List of possible features for dom0less domUs > * > * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and > * evtchn, will be enabled for the VM. Technically, the guest can already use the grant-table and evtchn interfaces. This also reads quite odd to me because "including" doesn't tell what's not enabled. So one could assume Xenstored is also enabled. In fact the wording for ``DOM0LESS_ENHANCED`` is what makes it a lot more confusing. So I would suggest the following wording: "Notify the OS it is running on top of Xen. All the default features but Xenstore will be available. Note that an OS *must* not rely on the availability of Xen features if this is not set. " The wording can be updated once we properly disable event channel/grant table when the flag is not set. > * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. I would make clear this can't be used without the first one. > * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-table xenstore > * and evtchn, will be enabled for the VM. See above about "PV interfaces". So I would suggest to reword to: "Notify the OS it is running on top of Xen. All the default features (including Xenstore) will be available". > */ > #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) > #define DOM0LESS_XENSTORE BIT(1, UL) Based on the comment above, I would consider to define DOM0LESS_XENSTORE as bit 0 and 1 set. > #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 02 16:22:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 16:22:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397856.638561 (Exim 4.92) (envelope-from ) id 1oU9Qs-0001q2-Hy; Fri, 02 Sep 2022 16:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397856.638561; Fri, 02 Sep 2022 16:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9Qs-0001pv-F3; Fri, 02 Sep 2022 16:22:14 +0000 Received: by outflank-mailman (input) for mailman id 397856; Fri, 02 Sep 2022 16:22:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9Qr-0001pl-C0; Fri, 02 Sep 2022 16:22:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9Qr-0002AR-AN; Fri, 02 Sep 2022 16:22:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oU9Qq-0002hv-Qz; Fri, 02 Sep 2022 16:22:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oU9Qq-0004Fx-QV; Fri, 02 Sep 2022 16:22:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kLfdJ/OOyjEk7DwCwrP1NdRoKeOr5IKmMlJOjcbX+JQ=; b=A7QCBcsGt/ixLkCYDumK1vB0K0 qr/N47/QWmMz9HVGDRT67qgVZP/UayOOSWg5g8zsqSVDzdz9TUfxu1Y/i+6t1IZ13n41pjyfpP1vI t2PW2YjTWHCosgUbJtVbEzr6vyIMSMtEhyNUliWjAWB+5NV/OoT9nAju25m9s6yiLKys=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172931: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=42e66b1cc3a070671001f8a1e933a80818a192bf X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Fri, 02 Sep 2022 16:22:12 +0000 flight 172931 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172931/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 42e66b1cc3a070671001f8a1e933a80818a192bf baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 29 days Failing since 172152 2022-08-05 04:01:26 Z 28 days 65 attempts Testing same since 172922 2022-09-01 22:42:52 Z 0 days 2 attempts ------------------------------------------------------------ 1629 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 167086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 16:59:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 16:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397867.638571 (Exim 4.92) (envelope-from ) id 1oUA0w-0005JF-IQ; Fri, 02 Sep 2022 16:59:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397867.638571; Fri, 02 Sep 2022 16:59:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUA0w-0005J8-Er; Fri, 02 Sep 2022 16:59:30 +0000 Received: by outflank-mailman (input) for mailman id 397867; Fri, 02 Sep 2022 16:59:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUA0v-0005J1-OL for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 16:59:29 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 993af3dc-2ae0-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 18:59:26 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 76959621A6; Fri, 2 Sep 2022 16:59:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AF84C433C1; Fri, 2 Sep 2022 16:59:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 993af3dc-2ae0-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662137963; bh=DGrp9ol7B2fcIuUbZg7Ryi5vbk3GSCvjRzXLRLhagJc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VsoJYHVYCxuH9OeEdmFUSU6JUMq3+qm/agKa2mDB297wYG3ajJFAztMFqB4BJlRAL ZQBQym/PhDcFs2+7N4sMgIpisQN/RmxpsiWajH4fp4IX1l0SbYMdfXrGcpzoe8+sG5 FW0TJ/FBY9+sdzDB7IC1a+1N+qQsTQjr/XvPyFN8ZHK1HGh96nYy2WXJ2Xe2vKhFst Lbb1m+ssGgPalRPKK20TMZwPyVxWn/pkF7Ke1wnq2GeydIkygxI1SSntDBU1XtsrF6 UWEQmWGMkeQTaRFPpaYuPtgHDXKaPBj6MBzpUhPX87odsEaKNVRq8IQZgkmE9KrcIx 5V8+wdAFdEtMw== Date: Fri, 2 Sep 2022 11:59:21 -0500 From: Bjorn Helgaas To: Jason Andryuk Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Bjorn Helgaas , xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state Message-ID: <20220902165921.GA354189@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829151536.8578-1-jandryuk@gmail.com> The conventional style for subject (from "git log --oneline") is: xen/pcifront: Handle ... On Mon, Aug 29, 2022 at 11:15:36AM -0400, Jason Andryuk wrote: > An HVM guest with linux stubdom and 2 PCI devices failed to start as "stubdom" might be handy shorthand in the Xen world, but I think it would be nice to consistently spell out "stubdomain" since you use both forms randomly in this commit log and newbies like me have to wonder whether they're the same or different. > libxl timed out waiting for the PCI devices to be added. It happens > intermittently but with some regularity. libxl wrote the two xenstore > entries for the devices, but then timed out waiting for backend state 4 > (Connected) - the state stayed at 7 (Reconfiguring). (PCI passthrough > to an HVM with stubdomain is PV passthrough to the stubdomain and then > HVM passthrough with the QEMU inside the stubdomain.) > > The stubdom kernel never printed "pcifront pci-0: Installing PCI > frontend", so it seems to have missed state 4 which would have > called pcifront_try_connect -> pcifront_connect_and_init_dma Add "()" after function names for clarity. > Have pcifront_detach_devices special-case state Initialised and call > pcifront_connect_and_init_dma. Don't use pcifront_try_connect because > that sets the xenbus state which may throw off the backend. After > connecting, skip the remainder of detach_devices since none have been > initialized yet. When the backend switches to Reconfigured, > pcifront_attach_devices will pick them up again. Bjorn From xen-devel-bounces@lists.xenproject.org Fri Sep 02 17:43:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 17:43:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397875.638583 (Exim 4.92) (envelope-from ) id 1oUAhT-0001uI-Tv; Fri, 02 Sep 2022 17:43:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397875.638583; Fri, 02 Sep 2022 17:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUAhT-0001uA-R9; Fri, 02 Sep 2022 17:43:27 +0000 Received: by outflank-mailman (input) for mailman id 397875; Fri, 02 Sep 2022 17:43:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUAhS-0001tz-FN; Fri, 02 Sep 2022 17:43:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUAhS-0003U1-DU; Fri, 02 Sep 2022 17:43:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUAhS-00058f-2k; Fri, 02 Sep 2022 17:43:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUAhS-0001bq-2G; Fri, 02 Sep 2022 17:43:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nAA46z9+3xtcKTJT+Ol7nCyLK4ffrXkXdP+xKylwRU8=; b=sNfEnLLdT88v2GcX/9iuOx0Ppt U1q7RvsqV6MLAge1pApFjw0g5d+O6H9/t9BMNL9EmhJii0mWn5VBFJYJdCiJ1hld99i0c7k1DXvyc mfTsPx/BNfMeebhdoPwHOiDQxN1ziK3xOVXWSGG4Kv8RRE0ezYeAoGDXs3nhU1bq9U8k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172938: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 17:43:26 +0000 flight 172938 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172938/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 226 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 18:26:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 18:26:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397886.638600 (Exim 4.92) (envelope-from ) id 1oUBMx-0006Da-4K; Fri, 02 Sep 2022 18:26:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397886.638600; Fri, 02 Sep 2022 18:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUBMx-0006DT-1f; Fri, 02 Sep 2022 18:26:19 +0000 Received: by outflank-mailman (input) for mailman id 397886; Fri, 02 Sep 2022 18:26:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUBMu-0006DL-S9 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 18:26:17 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba0a2b88-2aec-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 20:26:14 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id gb36so5460750ejc.10 for ; Fri, 02 Sep 2022 11:26:14 -0700 (PDT) Received: from [192.168.1.10] (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.gmail.com with ESMTPSA id cb25-20020a170906a45900b00730a1c73288sm1529357ejb.49.2022.09.02.11.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Sep 2022 11:26:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba0a2b88-2aec-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=RGduPfmV/d+FI45R2V6B1LMc7TO2USYlbHZWxrYrI0A=; b=le+A5EFj1mWH+EY7sl7A9fBof9dsUD4sZYqeQPLQmVAOO8fsNwY+Zf3rB/ppJMGkZ6 dc53YtKJ1sUSvr01qC9R6OLKjcu+szK+qg8i5YbUg0ixljNJFeLdv4svMP0t9YsnITDy BYHbUNxu1BX/1hUc37GmLAxiFEq4jqqIOcTZkN4JdkjZ20jRCNVgP9hVZUe+f6RqajmT /a5DaDWA0AmxVPrkpFg9LNSH+sRmsanycetL3L9i3qdS7a3XCVnOgljIJvt2O0f3Yqpn unMDHvgToADnAcSU4+X6799h/GDOJHyBHsYFRTYjqZp33sHNvSh9vmPIf6k8mDLlhp36 xdfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=RGduPfmV/d+FI45R2V6B1LMc7TO2USYlbHZWxrYrI0A=; b=dXZsHvIzwPLZ4MsvwNpb+DALUqLo6Mk+828/oXMZiI5T57TOHnj3aAk0g9VL/pcdr+ 4SpSC5exnLBUTSyVvmNdDQ8COUIC2GMZuCHolBLSc1cPXFExmlfMgEBWilnwIvubtZNq FoD+JNQissJ/Tvn3PG8XbhBtGLYhoQ3Mpjm+C6wAcvHv+jd+LikLtrt3ZrTN5hfuR2HY 2Afx5VUZUFu0qoYGuOGv5kR2Jam1hbyqwkmnotXR+K2ylSXsjT9pFUOG3ELUpxZf+a/V +CKlCaTLhbbqGKpRis7GWfFKPBMqXEifc7mu97s0qzpAvsahxcQAoH9Skmdqydgh7yw5 xRzg== X-Gm-Message-State: ACgBeo2Fje2vzdJpjOV8ZcwQ9RuibgeJTbuyf1pgWFhQuunPHm+dLT2V PUT2l27CeyHqwnwyY1cbByw= X-Google-Smtp-Source: AA6agR4Z2AEWF1UqHkP/VYrLaqLVgKX60scJLKlweK44ANiBEdpFi4GMlx+o+5aQwKi4tK/82Q/+6w== X-Received: by 2002:a17:907:72d0:b0:734:b451:c8d9 with SMTP id du16-20020a17090772d000b00734b451c8d9mr27982558ejc.272.1662143173602; Fri, 02 Sep 2022 11:26:13 -0700 (PDT) Message-ID: <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> Date: Fri, 2 Sep 2022 21:26:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Stefano Stabellini , Bertrand Marquis Cc: xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/2/22 05:07, Stefano Stabellini wrote: > On Thu, 1 Sep 2022, Bertrand Marquis wrote: >> Hi Xenia, >> >>> On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: >>> >>> >>> On 9/1/22 01:35, Stefano Stabellini wrote: >>>> Patches 1, 4, and 6 are already committed. I plan to commit patches 2, 3 >>>> and 5 in the next couple of days. >>>> Patch 7 needs further discussions and it is best addressed during the >>>> next MISRA C sync-up. >>> >>> I would like to share here, before the next MISRA C sync, my understandings that will hopefully resolve a wrong impression of mine, that I may have spread around, regarding this rule. >>> There was a misunderstanding regarding the rule 20.7 from my part and I think that Jan is absolutely right that parenthesizing macro parameters used as function arguments is not required by the rule. >>> >>> The rule 20.7 states "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses" and in the rationale of the rule states "If a macro parameter is not being used as an expression then the parentheses are not necessary because no operators are involved.". >>> >>> Initially, based on the title, my understanding was that it requires for the expression resulting from the expansion of the macro to be enclosed in parentheses. Then, based on the rule explanation and the examples given, my understanding was that it requires the macro parameters that are used as expressions to be enclosed in parentheses. >>> But, after re-thinking about it, the most probable and what makes more sense, is that it require parentheses around the macro parameters that are part of an expression and not around those that are used as expressions. >>> >>> Therefore, macro parameters being used as function arguments are not required to be enclosed in parentheses, because the function arguments are part of an expression list, not of an expression (comma is evaluated as separator, not as operator). >>> While, macro parameters used as rhs and lhs expressions of the assignment operator are required to be enclosed in parentheses because they are part of an assignment expression. >>> >>> I verified that the violation reported by cppcheck is not due to missing parentheses around the function argument (though still I have not understood the origin of the warning). Also, Eclair does not report it. >>> >>> Hence, it was a misunderstanding of mine and there is no inconsistency, with respect to this rule, in adding parentheses around macro parameters used as rhs of assignments. The rule does not require adding parentheses around macro parameters used as function arguments and neither cppcheck nor Eclair report violation for missing parentheses around macro parameters used as function arguments. >> >> >> Thanks a lot for the detailed explanation :-) >> >> What you say does make sense and I agree with your analysis here, only protect when part of an expression and not use as a subsequent parameter (for a function or an other macro). > > Yeah I also agree with your analysis, and many thanks for > double-checking the cppcheck and Eclair's reports. Unfortunately in the specific case that I checked, it was not reported because it was actually an argument to a macro, not a function. Eclair does report as violations of Rule 20.7 the macro parameters that are used as function arguments and are not enclosed in parentheses. So, one tool reports it as violation and the other one not. The same goes, also, for the case where a macro parameter is used as index to an array. Eclair reports it as violation while cppcheck does not. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Sep 02 19:49:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 19:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397895.638610 (Exim 4.92) (envelope-from ) id 1oUCes-0005df-7r; Fri, 02 Sep 2022 19:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397895.638610; Fri, 02 Sep 2022 19:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCes-0005dY-5E; Fri, 02 Sep 2022 19:48:54 +0000 Received: by outflank-mailman (input) for mailman id 397895; Fri, 02 Sep 2022 19:48:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCep-0005dB-R0 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 19:48:52 +0000 Received: from out1.migadu.com (out1.migadu.com [2001:41d0:2:863f::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 433f34bf-2af8-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 21:48:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 433f34bf-2af8-11ed-934f-f50d60e1c1bd Date: Fri, 2 Sep 2022 15:48:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662148127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n3Vt2n+PBD0eNIsvGTR1l3JrOeVtWEjP88FVSBBEvEY=; b=mPyxzHSCWJDs7FY0KQSQlCnTELLgR0D5y3QUtw1jP0xws7G95PlcumsBf40lKyXM7CpTgQ EQ03B0NpMd3GmyUjL7/LRRu2b7P7CYcc/5drjtaORm2I0b47gBiN9Kk3SiUGyi3Al05Eo0 A5b6cgfMPf2NEURa1fE7EOtxMOAAjIs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Jens Axboe Cc: Roman Gushchin , Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220902194839.xqzgsoowous72jkz@moria.home.lan> References: <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> <3a41b9fc-05f1-3f56-ecd0-70b9a2912a31@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a41b9fc-05f1-3f56-ecd0-70b9a2912a31@kernel.dk> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Fri, Sep 02, 2022 at 06:02:12AM -0600, Jens Axboe wrote: > On 9/1/22 7:04 PM, Roman Gushchin wrote: > > On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: > >> On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: > >>> I'd suggest to run something like iperf on a fast hardware. And maybe some > >>> io_uring stuff too. These are two places which were historically most sensitive > >>> to the (kernel) memory accounting speed. > >> > >> I'm getting wildly inconsistent results with iperf. > >> > >> io_uring-echo-server and rust_echo_bench gets me: > >> Benchmarking: 127.0.0.1:12345 > >> 50 clients, running 512 bytes, 60 sec. > >> > >> Without alloc tagging: 120547 request/sec > >> With: 116748 request/sec > >> > >> https://github.com/frevib/io_uring-echo-server > >> https://github.com/haraldh/rust_echo_bench > >> > >> How's that look to you? Close enough? :) > > > > Yes, this looks good (a bit too good). > > > > I'm not that familiar with io_uring, Jens and Pavel should have a better idea > > what and how to run (I know they've workarounded the kernel memory accounting > > because of the performance in the past, this is why I suspect it might be an > > issue here as well). > > io_uring isn't alloc+free intensive on a per request basis anymore, it > would not be a good benchmark if the goal is to check for regressions in > that area. Good to know. The benchmark is still a TCP benchmark though, so still useful. Matthew suggested while true; do echo 1 >/tmp/foo; rm /tmp/foo; done I ran that on tmpfs, and the numbers with and without alloc tagging were statistically equal - there was a fair amount of variation, it wasn't a super controlled test, anywhere from 38-41 seconds with 100000 iterations (and alloc tagging was some of the faster runs). But with memcg off, it ran in 32-33 seconds. We're piggybacking on the same mechanism memcg uses for stashing per-object pointers, so it looks like that's the bigger cost. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 19:51:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 19:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397902.638622 (Exim 4.92) (envelope-from ) id 1oUChF-0006zi-Lc; Fri, 02 Sep 2022 19:51:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397902.638622; Fri, 02 Sep 2022 19:51:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUChF-0006zb-He; Fri, 02 Sep 2022 19:51:21 +0000 Received: by outflank-mailman (input) for mailman id 397902; Fri, 02 Sep 2022 19:51:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUChE-0006zN-CQ; Fri, 02 Sep 2022 19:51:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUChE-0005cg-B1; Fri, 02 Sep 2022 19:51:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUChD-0004Su-Pt; Fri, 02 Sep 2022 19:51:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUChD-00067o-PW; Fri, 02 Sep 2022 19:51:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LMoK41NEu9AW+9KtkcEIYovpao/qPuZ1Yn8fS3+Rn0w=; b=pxjORaqd4Ru/BQKCt56yYoLdaC 6MSyBkMkxnoBTdFDuBCajU/FYZ/t4HwqsrCwWBvAA9yOIqDJRta+SdB6KktVX/EBGZ+MnT6xOfuhE YTITmyZllUA0DIsh3YXgv0UJfBRc4pTvzpMfovy7jXu37zOeFdRnuCEV1YY6Z/HjfhGE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172942: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 19:51:19 +0000 flight 172942 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172942/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 227 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 19:54:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 19:54:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397912.638633 (Exim 4.92) (envelope-from ) id 1oUCjr-0007h8-5j; Fri, 02 Sep 2022 19:54:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397912.638633; Fri, 02 Sep 2022 19:54:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCjr-0007h1-2l; Fri, 02 Sep 2022 19:54:03 +0000 Received: by outflank-mailman (input) for mailman id 397912; Fri, 02 Sep 2022 19:54:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCjp-0007gs-7J for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 19:54:01 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc28bfd0-2af8-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 21:53:59 +0200 (CEST) Received: by mail-pj1-x102e.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso6451115pjh.5 for ; Fri, 02 Sep 2022 12:53:59 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id c6-20020a170902c1c600b00172ccb3f4ebsm2008369plc.160.2022.09.02.12.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Sep 2022 12:53:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc28bfd0-2af8-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=BgSQRPeP2vU+fzfPkC5136xUIsrQV+zIPc0zX8WqYvQ=; b=4q1ObG8WZYb+BFWPgZh7N7aITtmlNIGPzQtvKE2aYuRrU3oMZQ76tQz2zqxy31cTLt d8rIjpGYxzTxBhay1NPxlOw7vaD/UOVOLVL9kTH97EOmLP9jqiD95DNmZFsZ1Ptc8XmN SpoCT9nh9ECoUVn4HyZ7Qsn6ksQUfbOmmaLZNC8YNvNZJ0mYksYatinKwvYndzY1XvJm nky6nJQ50OCGfppKmlv+KompjFnK/xiaX17J7WZx+2ulxNlRcgnWzxkBWjasiiHjJ4Jl WgqrWN7XLOnHrvW9WLg3mCJ+/TAuDw9lCpZSCR3GLv/KhadF9BUUSKQnQ8/gjIX8jzxs EhUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=BgSQRPeP2vU+fzfPkC5136xUIsrQV+zIPc0zX8WqYvQ=; b=mIojooQogDCoZEgR6EODEX6Wtw+S6yp04ibQMLf1eubZN38bz3Yh8y3iERxyHeKaz9 pGrB43xQP4FyK0kzKmDP4tZWAoJ8ZL7I5Ul0bhOEIlyGxZJzeqwV3myKdNWqir0H7gz1 c5edMlWbmJOCNNbYy1aEAk1fsjI1QBsXGJ4mlGgx73RQFqTfn5G+90snsiUfjyOdYkNT VnXTHcU8Mpl240wipiLW6c80RokZ85V6j0QsF3ZZ5Vv7RK76YjWuySXqtLnxiEXZmatG KmJUWdtgKZhSMcLMCS7CZsPADuR+FcDUaTYDBWzCD4TvBcjQfFiRKxRzrxE6Fb1CUF7b vcsg== X-Gm-Message-State: ACgBeo3/wrgME5/mk/7NnUcFGJJLLcSXvVmhs/4Ga2MwGZk1iCYsU/Hk oRN345oB/sisqrzgBDKjarFxXg== X-Google-Smtp-Source: AA6agR5BylTPZ3Gegvy/NzTiavEg8hhtbTLj8aGfOurXCnjCbkfIWop802MX5aLKWWzJpm5rxypzOA== X-Received: by 2002:a17:90b:b16:b0:1fd:b47c:6ab with SMTP id bf22-20020a17090b0b1600b001fdb47c06abmr6698292pjb.203.1662148438176; Fri, 02 Sep 2022 12:53:58 -0700 (PDT) Message-ID: Date: Fri, 2 Sep 2022 13:53:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Content-Language: en-US To: Kent Overstreet Cc: Roman Gushchin , Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List References: <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> <3a41b9fc-05f1-3f56-ecd0-70b9a2912a31@kernel.dk> <20220902194839.xqzgsoowous72jkz@moria.home.lan> From: Jens Axboe In-Reply-To: <20220902194839.xqzgsoowous72jkz@moria.home.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/2/22 1:48 PM, Kent Overstreet wrote: > On Fri, Sep 02, 2022 at 06:02:12AM -0600, Jens Axboe wrote: >> On 9/1/22 7:04 PM, Roman Gushchin wrote: >>> On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: >>>> On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: >>>>> I'd suggest to run something like iperf on a fast hardware. And maybe some >>>>> io_uring stuff too. These are two places which were historically most sensitive >>>>> to the (kernel) memory accounting speed. >>>> >>>> I'm getting wildly inconsistent results with iperf. >>>> >>>> io_uring-echo-server and rust_echo_bench gets me: >>>> Benchmarking: 127.0.0.1:12345 >>>> 50 clients, running 512 bytes, 60 sec. >>>> >>>> Without alloc tagging: 120547 request/sec >>>> With: 116748 request/sec >>>> >>>> https://github.com/frevib/io_uring-echo-server >>>> https://github.com/haraldh/rust_echo_bench >>>> >>>> How's that look to you? Close enough? :) >>> >>> Yes, this looks good (a bit too good). >>> >>> I'm not that familiar with io_uring, Jens and Pavel should have a better idea >>> what and how to run (I know they've workarounded the kernel memory accounting >>> because of the performance in the past, this is why I suspect it might be an >>> issue here as well). >> >> io_uring isn't alloc+free intensive on a per request basis anymore, it >> would not be a good benchmark if the goal is to check for regressions in >> that area. > > Good to know. The benchmark is still a TCP benchmark though, so still useful. > > Matthew suggested > while true; do echo 1 >/tmp/foo; rm /tmp/foo; done > > I ran that on tmpfs, and the numbers with and without alloc tagging were > statistically equal - there was a fair amount of variation, it wasn't a super > controlled test, anywhere from 38-41 seconds with 100000 iterations (and alloc > tagging was some of the faster runs). > > But with memcg off, it ran in 32-33 seconds. We're piggybacking on the same > mechanism memcg uses for stashing per-object pointers, so it looks like that's > the bigger cost. I've complained about memcg accounting before, the slowness of it is why io_uring works around it by caching. Anything we account we try NOT do in the fast path because of it, the slowdown is considerable. You care about efficiency now? I thought that was relegated to irrelevant 10M IOPS cases. -- Jens Axboe From xen-devel-bounces@lists.xenproject.org Fri Sep 02 19:57:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 19:57:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397918.638644 (Exim 4.92) (envelope-from ) id 1oUCnT-0008IJ-Le; Fri, 02 Sep 2022 19:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397918.638644; Fri, 02 Sep 2022 19:57:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCnT-0008IC-IA; Fri, 02 Sep 2022 19:57:47 +0000 Received: by outflank-mailman (input) for mailman id 397918; Fri, 02 Sep 2022 19:57:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCnR-0008I2-Cl; Fri, 02 Sep 2022 19:57:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCnR-0005j8-7w; Fri, 02 Sep 2022 19:57:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCnQ-0004nu-Os; Fri, 02 Sep 2022 19:57:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUCnQ-0003Ay-OP; Fri, 02 Sep 2022 19:57:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4XkGM46xPHjWC026kpP5lGF1usjSt/NM60y2CwS4oIA=; b=oZ+I7VZanYx3K4uHZK7oO3Uke8 c6Se3YNl471554x5NIS9/ybq6mXTtog/+rh+RHBdBwg1WR1pfwGZIRKKs0RoQAeDpYHL5+HKwAKmx XI9fo9unP/2jGRT5Qt5qZGeFp0gKJ36f3iTNGYS3L+650IfS8LjTFsEREj0v/I7BNpZU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172934: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-examine:reboot:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 02 Sep 2022 19:57:44 +0000 flight 172934 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172934/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 172924 pass in 172934 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 172924 test-armhf-armhf-examine 8 reboot fail pass in 172924 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 172924 like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail in 172924 like 172108 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 172924 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 172924 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 29 days Failing since 172384 2022-08-11 11:13:58 Z 22 days 47 attempts Testing same since 172776 2022-08-25 17:42:45 Z 8 days 18 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 20:06:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 20:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397929.638654 (Exim 4.92) (envelope-from ) id 1oUCvd-0001QN-Bn; Fri, 02 Sep 2022 20:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397929.638654; Fri, 02 Sep 2022 20:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCvd-0001QG-95; Fri, 02 Sep 2022 20:06:13 +0000 Received: by outflank-mailman (input) for mailman id 397929; Fri, 02 Sep 2022 20:06:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUCvb-0001QA-A1 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 20:06:11 +0000 Received: from out0.migadu.com (out0.migadu.com [2001:41d0:2:267::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac671be4-2afa-11ed-82f2-63bd783d45fa; Fri, 02 Sep 2022 22:06:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac671be4-2afa-11ed-82f2-63bd783d45fa Date: Fri, 2 Sep 2022 16:05:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662149163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SemCjjx9bqrqhFAABAkUIroCfCc94PYvIF1DVQSZFl4=; b=DkqxrENv1HGZgJN2jzLkuenZfiCKRaXUD9WzQJ4Gyv/ayHL/Rtg7Xzr8AwspMWXlwZIUIL u2b26PHc1vj3E0HNj7dQceY3+rADhcYIqCEweC9ErZkbq6yycckimIVL96EkhBo8Hg7QMq Oask9xF1FPTxe7xFqrU4hLkV5BMu+ow= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Jens Axboe Cc: Roman Gushchin , Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220902200555.h5fyamst6lyamjnw@moria.home.lan> References: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> <3a41b9fc-05f1-3f56-ecd0-70b9a2912a31@kernel.dk> <20220902194839.xqzgsoowous72jkz@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Fri, Sep 02, 2022 at 01:53:53PM -0600, Jens Axboe wrote: > I've complained about memcg accounting before, the slowness of it is why > io_uring works around it by caching. Anything we account we try NOT do > in the fast path because of it, the slowdown is considerable. I'm with you on that, it definitely raises an eyebrow. > You care about efficiency now? I thought that was relegated to > irrelevant 10M IOPS cases. I always did, it's just not the only thing I care about. From xen-devel-bounces@lists.xenproject.org Fri Sep 02 20:23:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 20:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397940.638665 (Exim 4.92) (envelope-from ) id 1oUDCa-0003pq-U9; Fri, 02 Sep 2022 20:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397940.638665; Fri, 02 Sep 2022 20:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUDCa-0003pj-RG; Fri, 02 Sep 2022 20:23:44 +0000 Received: by outflank-mailman (input) for mailman id 397940; Fri, 02 Sep 2022 20:23:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUDCZ-0003pd-OF for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 20:23:43 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2283d140-2afd-11ed-934f-f50d60e1c1bd; Fri, 02 Sep 2022 22:23:42 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id f24so2944438plr.1 for ; Fri, 02 Sep 2022 13:23:42 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z10-20020a62d10a000000b00535d094d6ecsm2197822pfg.108.2022.09.02.13.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Sep 2022 13:23:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2283d140-2afd-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=k6pQn9EMMlV6BZtQiNF0XvMyejT4MeXWM0SLMVDUfUA=; b=atNBwFgIt7igHl+/QHLrFlJtFVTsSH/kJfYVSiBHiTvpkch9s3+zAthZGB6A5YDXlS v71QG7O0GohvTTqFSZ7hQ4jR7KHFNnmgxFUC6YUXp3eVqkrlZqyPHMxKdRrsK3hC7WJ+ ratf09sB7a22OqVWFFXLzBVLXIay3MBLrlzBsi890YvKl53SP/bZRFwgW9WLVQrECS+k e6/tO13lZyqAPIynEcJMUR9e2fBT2mJferk6/Xl8AJzVAjPmCX/MyAk+37HMrw2I7UDI 9l1WHpQ97YwZWMNi7XR5oEpipq812loh43BTSSYGw8QqCLvIufzr2WYkCLPG0vPEjTfE HLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=k6pQn9EMMlV6BZtQiNF0XvMyejT4MeXWM0SLMVDUfUA=; b=FIxxVQch8AefnIkaCPNvkBAuTfBHK6VSp7imCXopWxLyLrt2j4Epp3DkdIP+wcuOKO 0TSoOXJdqTXvwBRr/8IxXpu7rqssI04INoU8Yp7R4vtx3hJGOdMzj+qzG0MY8tBA9ecQ eE8LFCz+fgf5VbBi4CqBouCGlTKLXnM52NcvqdQdpDUoixFdSjeew0ET46DLMhKlgX+I ExNLFh57FLo7t7WIKpydN6hwqtOEfJBUnCCyn6M65QOh65qjOTxv3emaz3w4snhi7GiM 5k6FNTp8cnRPAHyliulQHCONvQuBnflKu6ETOyVVewuLGGshMiVGeYiluVQACFKcDix2 TzWw== X-Gm-Message-State: ACgBeo16LmA8WDG/900tYqRiqOBhrxKnpvnVretEanysmlMElunyNgWN XyiCXUdGCdfOs7y13fXDs77UVA== X-Google-Smtp-Source: AA6agR5AqhuPnCBKUHnmMMoOWG9kI43vIem/phxzSs6gDhTM24/CuEkLWk7/yQtSZJLhY720RHeSVw== X-Received: by 2002:a17:902:c94d:b0:16d:c10a:650e with SMTP id i13-20020a170902c94d00b0016dc10a650emr36139251pla.29.1662150220589; Fri, 02 Sep 2022 13:23:40 -0700 (PDT) Message-ID: <002ab1f2-078e-2bce-83a0-257a573b1f95@kernel.dk> Date: Fri, 2 Sep 2022 14:23:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Content-Language: en-US To: Kent Overstreet Cc: Roman Gushchin , Yosry Ahmed , Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , Johannes Weiner , dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux-MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, Linux Kernel Mailing List References: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901223720.e4gudprscjtwltif@moria.home.lan> <20220902001747.qqsv2lzkuycffuqe@moria.home.lan> <3a41b9fc-05f1-3f56-ecd0-70b9a2912a31@kernel.dk> <20220902194839.xqzgsoowous72jkz@moria.home.lan> <20220902200555.h5fyamst6lyamjnw@moria.home.lan> From: Jens Axboe In-Reply-To: <20220902200555.h5fyamst6lyamjnw@moria.home.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/2/22 2:05 PM, Kent Overstreet wrote: > On Fri, Sep 02, 2022 at 01:53:53PM -0600, Jens Axboe wrote: >> I've complained about memcg accounting before, the slowness of it is why >> io_uring works around it by caching. Anything we account we try NOT do >> in the fast path because of it, the slowdown is considerable. > > I'm with you on that, it definitely raises an eyebrow. > >> You care about efficiency now? I thought that was relegated to >> irrelevant 10M IOPS cases. > > I always did, it's just not the only thing I care about. It's not the only thing anyone cares about. -- Jens Axboe From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:01:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:01:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397947.638676 (Exim 4.92) (envelope-from ) id 1oUFfE-0001zT-6Z; Fri, 02 Sep 2022 23:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397947.638676; Fri, 02 Sep 2022 23:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFfE-0001zM-3h; Fri, 02 Sep 2022 23:01:28 +0000 Received: by outflank-mailman (input) for mailman id 397947; Fri, 02 Sep 2022 23:01:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFfC-0001zC-Fw; Fri, 02 Sep 2022 23:01:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFfC-0000R2-CF; Fri, 02 Sep 2022 23:01:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFfB-0007yV-Ug; Fri, 02 Sep 2022 23:01:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUFfB-0000c9-UB; Fri, 02 Sep 2022 23:01:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rB42XF+5y2JQ+miR/QpFuI+xjKRHAEGQOUDGs5aAzQQ=; b=oX0LS3cf36hdTIJF3qytezEUbg yMI6JzNGlVidCzJD6DDpJqF6MYHEJ5Sqg8uzmp3/OPM2whzLVo3howbUsQoUY62WAKUmfCKDMGPiC aKDlj4vKW8bLIsm5Y9TcV3/U3VPAbFyVGISyPang2ht/2kLpXpFPMRa0KNHefzQ765lM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172937: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7dd9d7e0bd29abf590d1ac235c0a00606ef81153 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 02 Sep 2022 23:01:25 +0000 flight 172937 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172937/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 7dd9d7e0bd29abf590d1ac235c0a00606ef81153 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 30 days Failing since 172148 2022-08-04 21:39:38 Z 29 days 66 attempts Testing same since 172928 2022-09-02 02:44:00 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4167 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:17:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397956.638688 (Exim 4.92) (envelope-from ) id 1oUFuS-0003XI-Jk; Fri, 02 Sep 2022 23:17:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397956.638688; Fri, 02 Sep 2022 23:17:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFuS-0003XB-H3; Fri, 02 Sep 2022 23:17:12 +0000 Received: by outflank-mailman (input) for mailman id 397956; Fri, 02 Sep 2022 23:17:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFuR-0003X5-A5 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 23:17:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5dbe5ce5-2b15-11ed-934f-f50d60e1c1bd; Sat, 03 Sep 2022 01:17:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55D0261F93; Fri, 2 Sep 2022 23:17:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E25AC433D6; Fri, 2 Sep 2022 23:17:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dbe5ce5-2b15-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662160627; bh=R/leICqXMaRFl4+rtbRuInm1Ze9Hvu1lK1dELb6O9ZQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Xi5WAFPt2G+jaBzAdQiaJD+BXIxBO3yvGVIEvlpEMk1/dyP/OQ63q4amSvVU1cZx3 QRqtJ9ns3F0sCO5fasrPPFZFcZoxiyj0/YcNMcsAUecDvCbITQdWM+7g6Zwbxwf7Ip F9P3AlEPP2UTlUhH9M6ORSywH+w0xUCkIuhZOusrum9sxvXLRwTFSU/H4xmu7qqTkl y8PZ+phvuzsof9EVkYKl/aibeMwNcV6nXebNtmckfAhSMw3yJ3eaQvvRz5nCrZL1pS M9lTMZBJcpbRqEE6u2ZYBu5GKiDpt3US8gd2v3fPoTIARRFESTyH5ZeuYflj6nWbXX e119bMBF6+hdA== Date: Fri, 2 Sep 2022 16:17:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Robin Murphy , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v2 05/10] xen/arm: smmuv3: Remove the page 1 fixup In-Reply-To: <5f6f8233ee5c27082aec27dfc06c6f600f0c5d55.1662123432.git.rahul.singh@arm.com> Message-ID: References: <5f6f8233ee5c27082aec27dfc06c6f600f0c5d55.1662123432.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 2 Sep 2022, Rahul Singh wrote: > From: Robin Murphy > > Backport Linux commit 86d2d9214880. This is the clean backport without > any changes. > > Since we now keep track of page 1 via a separate pointer that > already encapsulates aliasing to page 0 as necessary, we can remove > the clunky fixup routine and simply use the relevant bases directly. > The current architecture spec (IHI0070D.a) defines > SMMU_{EVENTQ,PRIQ}_{PROD,CONS} as offsets relative to page 1, so the > cleanup represents a little bit of convergence as well as just > lines of code saved. > > Signed-off-by: Robin Murphy > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 86d2d9214880 > Signed-off-by: Rahul Singh > --- > Changes in v2: > - fix commit msg. > --- > xen/drivers/passthrough/arm/smmu-v3.c | 42 ++++++++++----------------- > xen/drivers/passthrough/arm/smmu-v3.h | 8 ++--- > 2 files changed, 20 insertions(+), 30 deletions(-) > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index 85ad066266..f5485a8a1c 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -235,15 +235,6 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { > { 0, NULL}, > }; > > -static inline void __iomem *arm_smmu_page1_fixup(unsigned long offset, > - struct arm_smmu_device *smmu) > -{ > - if (offset > SZ_64K) > - return smmu->page1 + offset - SZ_64K; > - > - return smmu->base + offset; > -} > - > static struct arm_smmu_domain *to_smmu_domain(struct iommu_domain *dom) > { > return container_of(dom, struct arm_smmu_domain, domain); > @@ -1578,6 +1569,7 @@ static int arm_smmu_dt_xlate(struct device *dev, > /* Probing and initialisation functions */ > static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, > struct arm_smmu_queue *q, > + void __iomem *page, > unsigned long prod_off, > unsigned long cons_off, > size_t dwords, const char *name) > @@ -1606,8 +1598,8 @@ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, > 1 << q->llq.max_n_shift, name); > } > > - q->prod_reg = arm_smmu_page1_fixup(prod_off, smmu); > - q->cons_reg = arm_smmu_page1_fixup(cons_off, smmu); > + q->prod_reg = page + prod_off; > + q->cons_reg = page + prod_off; In the original patch it was: - q->prod_reg = arm_smmu_page1_fixup(prod_off, smmu); - q->cons_reg = arm_smmu_page1_fixup(cons_off, smmu); + q->prod_reg = page + prod_off; + q->cons_reg = page + cons_off; Specifically the second line seems to be wrong here? From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:21:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397965.638699 (Exim 4.92) (envelope-from ) id 1oUFyZ-000509-8y; Fri, 02 Sep 2022 23:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397965.638699; Fri, 02 Sep 2022 23:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFyZ-000502-5p; Fri, 02 Sep 2022 23:21:27 +0000 Received: by outflank-mailman (input) for mailman id 397965; Fri, 02 Sep 2022 23:21:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUFyX-0004zv-Ag for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 23:21:25 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f5efda3c-2b15-11ed-82f2-63bd783d45fa; Sat, 03 Sep 2022 01:21:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 53142B82E03; Fri, 2 Sep 2022 23:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9624BC433C1; Fri, 2 Sep 2022 23:21:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5efda3c-2b15-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662160882; bh=r5TBsV1adSVTAfB+81yvtAzFrzkzGu1Ragripsg63lk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Rd/DQpMKgpkc+EtpOfa8o6aax+TIXEJOF6IqHFj8FN4lvxW40selvbxW//lIWzBKI plEerGeaj3KtxCSOjBH4slAPpZsDZ9n6DE0x4T5RCgjp/jFNAjxnP2DE2OONNYUnC1 vF8SKphrRYDx6AM1mktzyQLqhwOGEOEP9U85RUZoTbn6LyHCsHEwutAHQJIONzxz0B 8tzFbpY/6kwF0DTg6xJ3HgahfnWSNWeJXaJlQR7T0dLOKDhJkrWJ90sWfgThuMZ1ez YojcCRumHJ7AhPT3GQiSxaAvhp1bZwzEVu/A7HkzJbkh8+y1nY6dxQEH6UwMFITYuO AMOPnMUrNvJgQ== Date: Fri, 2 Sep 2022 16:21:18 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Zhou Wang , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer In-Reply-To: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> Message-ID: References: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 2 Sep 2022, Rahul Singh wrote: > From: Zhou Wang > > Backport Linux commit a76a37777f2c. This is the clean backport without > any changes. > > Reading the 'prod' MMIO register in order to determine whether or > not there is valid data beyond 'cons' for a given queue does not > provide sufficient dependency ordering, as the resulting access is > address dependent only on 'cons' and can therefore be speculated > ahead of time, potentially allowing stale data to be read by the > CPU. > > Use readl() instead of readl_relaxed() when updating the shadow copy > of the 'prod' pointer, so that all speculated memory reads from the > corresponding queue can occur only from valid slots. > > Signed-off-by: Zhou Wang > Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com > [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c > Signed-off-by: Rahul Singh > --- > Changes in v2: > - fix commit msg > - add _iomb changes also from the origin patch > --- > xen/arch/arm/include/asm/system.h | 1 + > xen/drivers/passthrough/arm/smmu-v3.c | 11 +++++++++-- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/include/asm/system.h b/xen/arch/arm/include/asm/system.h > index 65d5c8e423..fe27cf8c5e 100644 > --- a/xen/arch/arm/include/asm/system.h > +++ b/xen/arch/arm/include/asm/system.h > @@ -29,6 +29,7 @@ > #endif > > #define smp_wmb() dmb(ishst) > +#define __iomb() dmb(osh) We don't have any other #define starting with __ in system.h. I wonder if we should call this macro differently or simply iomb(). > #define smp_mb__before_atomic() smp_mb() > #define smp_mb__after_atomic() smp_mb() > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index 64d39bb4d3..cee13d1fc7 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -951,7 +951,7 @@ static void queue_sync_cons_out(struct arm_smmu_queue *q) > * Ensure that all CPU accesses (reads and writes) to the queue > * are complete before we update the cons pointer. > */ > - mb(); > + __iomb(); > writel_relaxed(q->llq.cons, q->cons_reg); > } > > @@ -963,8 +963,15 @@ static void queue_inc_cons(struct arm_smmu_ll_queue *q) > > static int queue_sync_prod_in(struct arm_smmu_queue *q) > { > + u32 prod; > int ret = 0; > - u32 prod = readl_relaxed(q->prod_reg); > + > + /* > + * We can't use the _relaxed() variant here, as we must prevent > + * speculative reads of the queue before we have determined that > + * prod has indeed moved. > + */ > + prod = readl(q->prod_reg); > > if (Q_OVF(prod) != Q_OVF(q->llq.prod)) > ret = -EOVERFLOW; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:30:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:30:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397972.638710 (Exim 4.92) (envelope-from ) id 1oUG6v-0006Ky-4H; Fri, 02 Sep 2022 23:30:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397972.638710; Fri, 02 Sep 2022 23:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUG6v-0006KP-0Z; Fri, 02 Sep 2022 23:30:05 +0000 Received: by outflank-mailman (input) for mailman id 397972; Fri, 02 Sep 2022 23:30:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUG6u-00066n-6H for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 23:30:04 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a291740-2b17-11ed-934f-f50d60e1c1bd; Sat, 03 Sep 2022 01:30:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5F8E6B82E07; Fri, 2 Sep 2022 23:30:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EB94C433D7; Fri, 2 Sep 2022 23:29:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a291740-2b17-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662161399; bh=onlQpAt3BLki4noIhNxSX9Zv+ycBaMyoyH22BVDdPlE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rK6Vzqyp2CIu7uWXX93uPbfOADr4pD58iKjGmYlvdGMfsbymTPzPwEbohS9VKyGFY M/rONwvNYpsr/vX96LMsSMRvhlDkWAXjgj5n5CKhe6NWnkEzeRUbPm3JKXVg4xpDyf Vpk/O3nD9Pn14N6EXXDVAgvZtE90orYugces9rkp+biVI2njEcfD5XflG1UV0lgPq7 g9adrZjQumrX2OjN0KqB//h2SJ6n0zgOEwyzqhLHhLt4EJKV81FGYenp8WGbct4tG/ WnSQE/Z+R5+MfW/voH9rbBGYN0hiRav2PEYWeZFle1dsolvTUngiaekJq3NNzWcUvx fr4ZYqYg1gCLQ== Date: Fri, 2 Sep 2022 16:29:56 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Jean-Philippe Brucker , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Eric Auger , Jonathan Cameron , Will Deacon Subject: Re: [PATCH v2 04/10] xen/arm: smmuv3: Move definitions to a header In-Reply-To: <73362954b7395155c8287d2ea0737e132516cc90.1662123432.git.rahul.singh@arm.com> Message-ID: References: <73362954b7395155c8287d2ea0737e132516cc90.1662123432.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 2 Sep 2022, Rahul Singh wrote: > From: Jean-Philippe Brucker > > Backport Linux commit e881e7839fba. This is the clean backport without > any changes. I don't think we can say that this is a clean backport because there are differences between the two patches. That said, it is just code movement, it is similar to the original patch, and it still compiles. So I think we should change the commit message not to say that it is a clean backport, but other than that is fine. > Allow sharing structure definitions with the upcoming SVA support for > Arm SMMUv3, by moving them to a separate header. We could surgically > extract only what is needed but keeping all definitions in one place > looks nicer. > > Signed-off-by: Jean-Philippe Brucker > Reviewed-by: Eric Auger > Reviewed-by: Jonathan Cameron > Link: https://lore.kernel.org/r/20200918101852.582559-8-jean-philippe@linaro.org > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e881e7839fba > Signed-off-by: Rahul Singh > --- > Changes in v2: > - fix commit msg > - also move struct definition to header file to sync with Linux patch > --- > xen/drivers/passthrough/arm/smmu-v3.c | 666 +------------------------ > xen/drivers/passthrough/arm/smmu-v3.h | 674 ++++++++++++++++++++++++++ > 2 files changed, 675 insertions(+), 665 deletions(-) > create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index cee13d1fc7..85ad066266 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -90,6 +90,7 @@ > #include > #include > > +#include "smmu-v3.h" > > #define ARM_SMMU_VTCR_SH_IS 3 > #define ARM_SMMU_VTCR_RGN_WBWA 1 > @@ -102,21 +103,10 @@ > #define ARM_SMMU_VTCR_PS_48_BIT 0x5ULL > #define ARM_SMMU_VTCR_PS_52_BIT 0x6ULL > > -/* Linux compatibility functions. */ > -typedef paddr_t dma_addr_t; > -typedef paddr_t phys_addr_t; > -typedef unsigned int gfp_t; > - > #define platform_device device > > #define GFP_KERNEL 0 > > -/* Alias to Xen lock functions */ > -#define mutex spinlock > -#define mutex_init spin_lock_init > -#define mutex_lock spin_lock > -#define mutex_unlock spin_unlock > - > /* Device logger functions */ > #define dev_name(dev) dt_node_full_name(dev->of_node) > #define dev_dbg(dev, fmt, ...) \ > @@ -157,12 +147,6 @@ typedef unsigned int gfp_t; > #define readl_relaxed_poll_timeout(addr, val, cond, delay_us, timeout_us) \ > readx_poll_timeout(readl_relaxed, addr, val, cond, delay_us, timeout_us) > > -#define FIELD_PREP(_mask, _val) \ > - (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) > - > -#define FIELD_GET(_mask, _reg) \ > - ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) > - > /* > * Helpers for DMA allocation. Just the function name is reused for > * porting code, these allocation are not managed allocations > @@ -195,27 +179,6 @@ static void *dmam_alloc_coherent(struct device *dev, size_t size, > return vaddr; > } > > - > -/* Xen specific code. */ > -struct iommu_domain { > - /* Runtime SMMU configuration for this iommu_domain */ > - atomic_t ref; > - /* > - * Used to link iommu_domain contexts for a same domain. > - * There is at least one per-SMMU to used by the domain. > - */ > - struct list_head list; > -}; > - > -/* Describes information required for a Xen domain */ > -struct arm_smmu_xen_domain { > - spinlock_t lock; > - > - /* List of iommu domains associated to this domain */ > - struct list_head contexts; > -}; > - > - > /* Keep a list of devices associated with this driver */ > static DEFINE_SPINLOCK(arm_smmu_devices_lock); > static LIST_HEAD(arm_smmu_devices); > @@ -259,635 +222,8 @@ static int platform_get_irq_byname_optional(struct device *dev, > } > > /* Start of Linux SMMUv3 code */ > -/* MMIO registers */ > -#define ARM_SMMU_IDR0 0x0 > -#define IDR0_ST_LVL GENMASK(28, 27) > -#define IDR0_ST_LVL_2LVL 1 > -#define IDR0_STALL_MODEL GENMASK(25, 24) > -#define IDR0_STALL_MODEL_STALL 0 > -#define IDR0_STALL_MODEL_FORCE 2 > -#define IDR0_TTENDIAN GENMASK(22, 21) > -#define IDR0_TTENDIAN_MIXED 0 > -#define IDR0_TTENDIAN_LE 2 > -#define IDR0_TTENDIAN_BE 3 > -#define IDR0_CD2L (1 << 19) > -#define IDR0_VMID16 (1 << 18) > -#define IDR0_PRI (1 << 16) > -#define IDR0_SEV (1 << 14) > -#define IDR0_MSI (1 << 13) > -#define IDR0_ASID16 (1 << 12) > -#define IDR0_ATS (1 << 10) > -#define IDR0_HYP (1 << 9) > -#define IDR0_COHACC (1 << 4) > -#define IDR0_TTF GENMASK(3, 2) > -#define IDR0_TTF_AARCH64 2 > -#define IDR0_TTF_AARCH32_64 3 > -#define IDR0_S1P (1 << 1) > -#define IDR0_S2P (1 << 0) > - > -#define ARM_SMMU_IDR1 0x4 > -#define IDR1_TABLES_PRESET (1 << 30) > -#define IDR1_QUEUES_PRESET (1 << 29) > -#define IDR1_REL (1 << 28) > -#define IDR1_CMDQS GENMASK(25, 21) > -#define IDR1_EVTQS GENMASK(20, 16) > -#define IDR1_PRIQS GENMASK(15, 11) > -#define IDR1_SSIDSIZE GENMASK(10, 6) > -#define IDR1_SIDSIZE GENMASK(5, 0) > - > -#define ARM_SMMU_IDR5 0x14 > -#define IDR5_STALL_MAX GENMASK(31, 16) > -#define IDR5_GRAN64K (1 << 6) > -#define IDR5_GRAN16K (1 << 5) > -#define IDR5_GRAN4K (1 << 4) > -#define IDR5_OAS GENMASK(2, 0) > -#define IDR5_OAS_32_BIT 0 > -#define IDR5_OAS_36_BIT 1 > -#define IDR5_OAS_40_BIT 2 > -#define IDR5_OAS_42_BIT 3 > -#define IDR5_OAS_44_BIT 4 > -#define IDR5_OAS_48_BIT 5 > -#define IDR5_OAS_52_BIT 6 > -#define IDR5_VAX GENMASK(11, 10) > -#define IDR5_VAX_52_BIT 1 > - > -#define ARM_SMMU_CR0 0x20 > -#define CR0_ATSCHK (1 << 4) > -#define CR0_CMDQEN (1 << 3) > -#define CR0_EVTQEN (1 << 2) > -#define CR0_PRIQEN (1 << 1) > -#define CR0_SMMUEN (1 << 0) > - > -#define ARM_SMMU_CR0ACK 0x24 > - > -#define ARM_SMMU_CR1 0x28 > -#define CR1_TABLE_SH GENMASK(11, 10) > -#define CR1_TABLE_OC GENMASK(9, 8) > -#define CR1_TABLE_IC GENMASK(7, 6) > -#define CR1_QUEUE_SH GENMASK(5, 4) > -#define CR1_QUEUE_OC GENMASK(3, 2) > -#define CR1_QUEUE_IC GENMASK(1, 0) > -/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ > -#define CR1_CACHE_NC 0 > -#define CR1_CACHE_WB 1 > -#define CR1_CACHE_WT 2 > - > -#define ARM_SMMU_CR2 0x2c > -#define CR2_PTM (1 << 2) > -#define CR2_RECINVSID (1 << 1) > -#define CR2_E2H (1 << 0) > - > -#define ARM_SMMU_GBPA 0x44 > -#define GBPA_UPDATE (1U << 31) > -#define GBPA_ABORT (1 << 20) > - > -#define ARM_SMMU_IRQ_CTRL 0x50 > -#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) > -#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) > -#define IRQ_CTRL_GERROR_IRQEN (1 << 0) > - > -#define ARM_SMMU_IRQ_CTRLACK 0x54 > - > -#define ARM_SMMU_GERROR 0x60 > -#define GERROR_SFM_ERR (1 << 8) > -#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) > -#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) > -#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) > -#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) > -#define GERROR_PRIQ_ABT_ERR (1 << 3) > -#define GERROR_EVTQ_ABT_ERR (1 << 2) > -#define GERROR_CMDQ_ERR (1 << 0) > -#define GERROR_ERR_MASK 0xfd > - > -#define ARM_SMMU_GERRORN 0x64 > - > -#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 > -#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 > -#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 > - > -#define ARM_SMMU_STRTAB_BASE 0x80 > -#define STRTAB_BASE_RA (1UL << 62) > -#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) > - > -#define ARM_SMMU_STRTAB_BASE_CFG 0x88 > -#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) > -#define STRTAB_BASE_CFG_FMT_LINEAR 0 > -#define STRTAB_BASE_CFG_FMT_2LVL 1 > -#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) > -#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) > - > -#define ARM_SMMU_CMDQ_BASE 0x90 > -#define ARM_SMMU_CMDQ_PROD 0x98 > -#define ARM_SMMU_CMDQ_CONS 0x9c > - > -#define ARM_SMMU_EVTQ_BASE 0xa0 > -#define ARM_SMMU_EVTQ_PROD 0x100a8 > -#define ARM_SMMU_EVTQ_CONS 0x100ac > -#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 > -#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 > -#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc > - > -#define ARM_SMMU_PRIQ_BASE 0xc0 > -#define ARM_SMMU_PRIQ_PROD 0x100c8 > -#define ARM_SMMU_PRIQ_CONS 0x100cc > -#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 > -#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 > -#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc > - > -#define ARM_SMMU_REG_SZ 0xe00 > - > -/* Common MSI config fields */ > -#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) > -#define MSI_CFG2_SH GENMASK(5, 4) > -#define MSI_CFG2_MEMATTR GENMASK(3, 0) > - > -/* Common memory attribute values */ > -#define ARM_SMMU_SH_NSH 0 > -#define ARM_SMMU_SH_OSH 2 > -#define ARM_SMMU_SH_ISH 3 > -#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 > -#define ARM_SMMU_MEMATTR_OIWB 0xf > - > -#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) > -#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) > -#define Q_OVERFLOW_FLAG (1U << 31) > -#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) > -#define Q_ENT(q, p) ((q)->base + \ > - Q_IDX(&((q)->llq), p) * \ > - (q)->ent_dwords) > - > -#define Q_BASE_RWA (1UL << 62) > -#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) > -#define Q_BASE_LOG2SIZE GENMASK(4, 0) > - > -/* Ensure DMA allocations are naturally aligned */ > -#ifdef CONFIG_CMA_ALIGNMENT > -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) > -#else > -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) > -#endif > - > -/* > - * Stream table. > - * > - * Linear: Enough to cover 1 << IDR1.SIDSIZE entries > - * 2lvl: 128k L1 entries, > - * 256 lazy entries per table (each table covers a PCI bus) > - */ > -#define STRTAB_L1_SZ_SHIFT 20 > -#define STRTAB_SPLIT 8 > - > -#define STRTAB_L1_DESC_DWORDS 1 > -#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) > -#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) > - > -#define STRTAB_STE_DWORDS 8 > -#define STRTAB_STE_0_V (1UL << 0) > -#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) > -#define STRTAB_STE_0_CFG_ABORT 0 > -#define STRTAB_STE_0_CFG_BYPASS 4 > -#define STRTAB_STE_0_CFG_S1_TRANS 5 > -#define STRTAB_STE_0_CFG_S2_TRANS 6 > - > -#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) > -#define STRTAB_STE_0_S1FMT_LINEAR 0 > -#define STRTAB_STE_0_S1FMT_64K_L2 2 > -#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) > -#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) > - > -#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) > -#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 > -#define STRTAB_STE_1_S1DSS_BYPASS 0x1 > -#define STRTAB_STE_1_S1DSS_SSID0 0x2 > - > -#define STRTAB_STE_1_S1C_CACHE_NC 0UL > -#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL > -#define STRTAB_STE_1_S1C_CACHE_WT 2UL > -#define STRTAB_STE_1_S1C_CACHE_WB 3UL > -#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) > -#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) > -#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) > - > -#define STRTAB_STE_1_S1STALLD (1UL << 27) > - > -#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) > -#define STRTAB_STE_1_EATS_ABT 0UL > -#define STRTAB_STE_1_EATS_TRANS 1UL > -#define STRTAB_STE_1_EATS_S1CHK 2UL > - > -#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) > -#define STRTAB_STE_1_STRW_NSEL1 0UL > -#define STRTAB_STE_1_STRW_EL2 2UL > - > -#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) > -#define STRTAB_STE_1_SHCFG_INCOMING 1UL > - > -#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) > -#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) > -#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) > -#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) > -#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) > -#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) > -#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) > -#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) > -#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) > -#define STRTAB_STE_2_S2AA64 (1UL << 51) > -#define STRTAB_STE_2_S2ENDI (1UL << 52) > -#define STRTAB_STE_2_S2PTW (1UL << 54) > -#define STRTAB_STE_2_S2R (1UL << 58) > - > -#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) > - > -/* > - * Context descriptors. > - * > - * Linear: when less than 1024 SSIDs are supported > - * 2lvl: at most 1024 L1 entries, > - * 1024 lazy entries per table. > - */ > -#define CTXDESC_SPLIT 10 > -#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) > - > -#define CTXDESC_L1_DESC_DWORDS 1 > -#define CTXDESC_L1_DESC_V (1UL << 0) > -#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) > - > -#define CTXDESC_CD_DWORDS 8 > -#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) > -#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) > -#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) > -#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) > -#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) > -#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) > -#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) > - > -#define CTXDESC_CD_0_ENDI (1UL << 15) > -#define CTXDESC_CD_0_V (1UL << 31) > - > -#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) > -#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) > - > -#define CTXDESC_CD_0_AA64 (1UL << 41) > -#define CTXDESC_CD_0_S (1UL << 44) > -#define CTXDESC_CD_0_R (1UL << 45) > -#define CTXDESC_CD_0_A (1UL << 46) > -#define CTXDESC_CD_0_ASET (1UL << 47) > -#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) > - > -#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) > - > -/* > - * When the SMMU only supports linear context descriptor tables, pick a > - * reasonable size limit (64kB). > - */ > -#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) > - > -/* Command queue */ > -#define CMDQ_ENT_SZ_SHIFT 4 > -#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) > -#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) > - > -#define CMDQ_CONS_ERR GENMASK(30, 24) > -#define CMDQ_ERR_CERROR_NONE_IDX 0 > -#define CMDQ_ERR_CERROR_ILL_IDX 1 > -#define CMDQ_ERR_CERROR_ABT_IDX 2 > -#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 > - > -#define CMDQ_0_OP GENMASK_ULL(7, 0) > -#define CMDQ_0_SSV (1UL << 11) > - > -#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) > -#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) > - > -#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) > -#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_CFGI_1_LEAF (1UL << 0) > -#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) > - > -#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) > -#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) > -#define CMDQ_TLBI_1_LEAF (1UL << 0) > -#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) > -#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) > - > -#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) > -#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_ATC_0_GLOBAL (1UL << 9) > -#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) > -#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) > - > -#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) > -#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) > -#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) > - > -#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) > -#define CMDQ_SYNC_0_CS_NONE 0 > -#define CMDQ_SYNC_0_CS_IRQ 1 > -#define CMDQ_SYNC_0_CS_SEV 2 > -#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) > -#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) > -#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) > -#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) > - > -/* Event queue */ > -#define EVTQ_ENT_SZ_SHIFT 5 > -#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) > -#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) > - > -#define EVTQ_0_ID GENMASK_ULL(7, 0) > - > -/* PRI queue */ > -#define PRIQ_ENT_SZ_SHIFT 4 > -#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) > -#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) > - > -#define PRIQ_0_SID GENMASK_ULL(31, 0) > -#define PRIQ_0_SSID GENMASK_ULL(51, 32) > -#define PRIQ_0_PERM_PRIV (1UL << 58) > -#define PRIQ_0_PERM_EXEC (1UL << 59) > -#define PRIQ_0_PERM_READ (1UL << 60) > -#define PRIQ_0_PERM_WRITE (1UL << 61) > -#define PRIQ_0_PRG_LAST (1UL << 62) > -#define PRIQ_0_SSID_V (1UL << 63) > - > -#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) > -#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) > - > -/* High-level queue structures */ > -#define ARM_SMMU_POLL_TIMEOUT_US 100 > -#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ > -#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 > - > static bool disable_bypass = 1; > > -enum pri_resp { > - PRI_RESP_DENY = 0, > - PRI_RESP_FAIL = 1, > - PRI_RESP_SUCC = 2, > -}; > - > -#ifdef CONFIG_MSI > -enum arm_smmu_msi_index { > - EVTQ_MSI_INDEX, > - GERROR_MSI_INDEX, > - PRIQ_MSI_INDEX, > - ARM_SMMU_MAX_MSIS, > -}; > - > -static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { > - [EVTQ_MSI_INDEX] = { > - ARM_SMMU_EVTQ_IRQ_CFG0, > - ARM_SMMU_EVTQ_IRQ_CFG1, > - ARM_SMMU_EVTQ_IRQ_CFG2, > - }, > - [GERROR_MSI_INDEX] = { > - ARM_SMMU_GERROR_IRQ_CFG0, > - ARM_SMMU_GERROR_IRQ_CFG1, > - ARM_SMMU_GERROR_IRQ_CFG2, > - }, > - [PRIQ_MSI_INDEX] = { > - ARM_SMMU_PRIQ_IRQ_CFG0, > - ARM_SMMU_PRIQ_IRQ_CFG1, > - ARM_SMMU_PRIQ_IRQ_CFG2, > - }, > -}; > -#endif /* CONFIG_MSI */ > - > -struct arm_smmu_cmdq_ent { > - /* Common fields */ > - u8 opcode; > - bool substream_valid; > - > - /* Command-specific fields */ > - union { > - #define CMDQ_OP_PREFETCH_CFG 0x1 > - struct { > - u32 sid; > - u8 size; > - u64 addr; > - } prefetch; > - > - #define CMDQ_OP_CFGI_STE 0x3 > - #define CMDQ_OP_CFGI_ALL 0x4 > - struct { > - u32 sid; > - union { > - bool leaf; > - u8 span; > - }; > - } cfgi; > - > - #define CMDQ_OP_TLBI_EL2_ALL 0x20 > - #define CMDQ_OP_TLBI_S12_VMALL 0x28 > - #define CMDQ_OP_TLBI_S2_IPA 0x2a > - #define CMDQ_OP_TLBI_NSNH_ALL 0x30 > - struct { > - u16 asid; > - u16 vmid; > - bool leaf; > - u64 addr; > - } tlbi; > - > - #define CMDQ_OP_ATC_INV 0x40 > - #define ATC_INV_SIZE_ALL 52 > - struct { > - u32 sid; > - u32 ssid; > - u64 addr; > - u8 size; > - bool global; > - } atc; > - > - #define CMDQ_OP_PRI_RESP 0x41 > - struct { > - u32 sid; > - u32 ssid; > - u16 grpid; > - enum pri_resp resp; > - } pri; > - > - #define CMDQ_OP_CMD_SYNC 0x46 > - struct { > - u32 msidata; > - u64 msiaddr; > - } sync; > - }; > -}; > - > -struct arm_smmu_ll_queue { > - u32 prod; > - u32 cons; > - u32 max_n_shift; > -}; > - > -struct arm_smmu_queue { > - struct arm_smmu_ll_queue llq; > - int irq; /* Wired interrupt */ > - > - __le64 *base; > - dma_addr_t base_dma; > - u64 q_base; > - > - size_t ent_dwords; > - > - u32 __iomem *prod_reg; > - u32 __iomem *cons_reg; > -}; > - > -struct arm_smmu_cmdq { > - struct arm_smmu_queue q; > - spinlock_t lock; > -}; > - > -struct arm_smmu_evtq { > - struct arm_smmu_queue q; > - u32 max_stalls; > -}; > - > -struct arm_smmu_priq { > - struct arm_smmu_queue q; > -}; > - > -/* High-level stream table and context descriptor structures */ > -struct arm_smmu_strtab_l1_desc { > - u8 span; > - > - __le64 *l2ptr; > - dma_addr_t l2ptr_dma; > -}; > - > -struct arm_smmu_s2_cfg { > - u16 vmid; > - u64 vttbr; > - u64 vtcr; > -}; > - > -struct arm_smmu_strtab_cfg { > - __le64 *strtab; > - dma_addr_t strtab_dma; > - struct arm_smmu_strtab_l1_desc *l1_desc; > - unsigned int num_l1_ents; > - > - u64 strtab_base; > - u32 strtab_base_cfg; > -}; > - > -struct arm_lpae_s2_cfg { > - u64 vttbr; > - struct { > - u32 ps:3; > - u32 tg:2; > - u32 sh:2; > - u32 orgn:2; > - u32 irgn:2; > - u32 sl:2; > - u32 tsz:6; > - } vtcr; > -}; > - > -/* An SMMUv3 instance */ > -struct arm_smmu_device { > - struct device *dev; > - void __iomem *base; > - void __iomem *page1; > - > -#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) > -#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) > -#define ARM_SMMU_FEAT_TT_LE (1 << 2) > -#define ARM_SMMU_FEAT_TT_BE (1 << 3) > -#define ARM_SMMU_FEAT_PRI (1 << 4) > -#define ARM_SMMU_FEAT_ATS (1 << 5) > -#define ARM_SMMU_FEAT_SEV (1 << 6) > -#define ARM_SMMU_FEAT_MSI (1 << 7) > -#define ARM_SMMU_FEAT_COHERENCY (1 << 8) > -#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) > -#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) > -#define ARM_SMMU_FEAT_STALLS (1 << 11) > -#define ARM_SMMU_FEAT_HYP (1 << 12) > -#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) > -#define ARM_SMMU_FEAT_VAX (1 << 14) > - u32 features; > - > -#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) > -#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) > - u32 options; > - > - struct arm_smmu_cmdq cmdq; > - struct arm_smmu_evtq evtq; > - struct arm_smmu_priq priq; > - > - int gerr_irq; > - int combined_irq; > - u32 sync_nr; > - u8 prev_cmd_opcode; > - > - unsigned long ias; /* IPA */ > - unsigned long oas; /* PA */ > - unsigned long pgsize_bitmap; > - > -#define ARM_SMMU_MAX_VMIDS (1 << 16) > - unsigned int vmid_bits; > - DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); > - > - unsigned int sid_bits; > - > - struct arm_smmu_strtab_cfg strtab_cfg; > - > - /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ > - union { > - u32 sync_count; > - u64 padding; > - }; > - > - /* Need to keep a list of SMMU devices */ > - struct list_head devices; > - > - /* Tasklets for handling evts/faults and pci page request IRQs*/ > - struct tasklet evtq_irq_tasklet; > - struct tasklet priq_irq_tasklet; > - struct tasklet combined_irq_tasklet; > -}; > - > -/* SMMU private data for each master */ > -struct arm_smmu_master { > - struct arm_smmu_device *smmu; > - struct device *dev; > - struct arm_smmu_domain *domain; > - struct list_head domain_head; > - u32 *sids; > - unsigned int num_sids; > - bool ats_enabled; > -}; > - > -/* SMMU private data for an IOMMU domain */ > -enum arm_smmu_domain_stage { > - ARM_SMMU_DOMAIN_S1 = 0, > - ARM_SMMU_DOMAIN_S2, > - ARM_SMMU_DOMAIN_NESTED, > - ARM_SMMU_DOMAIN_BYPASS, > -}; > - > -struct arm_smmu_domain { > - struct arm_smmu_device *smmu; > - struct mutex init_mutex; /* Protects smmu pointer */ > - > - bool non_strict; > - atomic_t nr_ats_masters; > - > - enum arm_smmu_domain_stage stage; > - struct arm_smmu_s2_cfg s2_cfg; > - > - /* Xen domain associated with this SMMU domain */ > - struct domain *d; > - > - struct iommu_domain domain; > - > - struct list_head devices; > - spinlock_t devices_lock; > -}; > - > struct arm_smmu_option_prop { > u32 opt; > const char *prop; > diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h > new file mode 100644 > index 0000000000..c45d2f16c4 > --- /dev/null > +++ b/xen/drivers/passthrough/arm/smmu-v3.h > @@ -0,0 +1,674 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * IOMMU API for ARM architected SMMUv3 implementations. > + * > + * Copyright (C) 2022 ARM Limited > + */ > + > +#ifndef _ARM_SMMU_V3_H > +#define _ARM_SMMU_V3_H > + > +/* MMIO registers */ > +#define ARM_SMMU_IDR0 0x0 > +#define IDR0_ST_LVL GENMASK(28, 27) > +#define IDR0_ST_LVL_2LVL 1 > +#define IDR0_STALL_MODEL GENMASK(25, 24) > +#define IDR0_STALL_MODEL_STALL 0 > +#define IDR0_STALL_MODEL_FORCE 2 > +#define IDR0_TTENDIAN GENMASK(22, 21) > +#define IDR0_TTENDIAN_MIXED 0 > +#define IDR0_TTENDIAN_LE 2 > +#define IDR0_TTENDIAN_BE 3 > +#define IDR0_CD2L (1 << 19) > +#define IDR0_VMID16 (1 << 18) > +#define IDR0_PRI (1 << 16) > +#define IDR0_SEV (1 << 14) > +#define IDR0_MSI (1 << 13) > +#define IDR0_ASID16 (1 << 12) > +#define IDR0_ATS (1 << 10) > +#define IDR0_HYP (1 << 9) > +#define IDR0_COHACC (1 << 4) > +#define IDR0_TTF GENMASK(3, 2) > +#define IDR0_TTF_AARCH64 2 > +#define IDR0_TTF_AARCH32_64 3 > +#define IDR0_S1P (1 << 1) > +#define IDR0_S2P (1 << 0) > + > +#define ARM_SMMU_IDR1 0x4 > +#define IDR1_TABLES_PRESET (1 << 30) > +#define IDR1_QUEUES_PRESET (1 << 29) > +#define IDR1_REL (1 << 28) > +#define IDR1_CMDQS GENMASK(25, 21) > +#define IDR1_EVTQS GENMASK(20, 16) > +#define IDR1_PRIQS GENMASK(15, 11) > +#define IDR1_SSIDSIZE GENMASK(10, 6) > +#define IDR1_SIDSIZE GENMASK(5, 0) > + > +#define ARM_SMMU_IDR5 0x14 > +#define IDR5_STALL_MAX GENMASK(31, 16) > +#define IDR5_GRAN64K (1 << 6) > +#define IDR5_GRAN16K (1 << 5) > +#define IDR5_GRAN4K (1 << 4) > +#define IDR5_OAS GENMASK(2, 0) > +#define IDR5_OAS_32_BIT 0 > +#define IDR5_OAS_36_BIT 1 > +#define IDR5_OAS_40_BIT 2 > +#define IDR5_OAS_42_BIT 3 > +#define IDR5_OAS_44_BIT 4 > +#define IDR5_OAS_48_BIT 5 > +#define IDR5_OAS_52_BIT 6 > +#define IDR5_VAX GENMASK(11, 10) > +#define IDR5_VAX_52_BIT 1 > + > +#define ARM_SMMU_CR0 0x20 > +#define CR0_ATSCHK (1 << 4) > +#define CR0_CMDQEN (1 << 3) > +#define CR0_EVTQEN (1 << 2) > +#define CR0_PRIQEN (1 << 1) > +#define CR0_SMMUEN (1 << 0) > + > +#define ARM_SMMU_CR0ACK 0x24 > + > +#define ARM_SMMU_CR1 0x28 > +#define CR1_TABLE_SH GENMASK(11, 10) > +#define CR1_TABLE_OC GENMASK(9, 8) > +#define CR1_TABLE_IC GENMASK(7, 6) > +#define CR1_QUEUE_SH GENMASK(5, 4) > +#define CR1_QUEUE_OC GENMASK(3, 2) > +#define CR1_QUEUE_IC GENMASK(1, 0) > +/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ > +#define CR1_CACHE_NC 0 > +#define CR1_CACHE_WB 1 > +#define CR1_CACHE_WT 2 > + > +#define ARM_SMMU_CR2 0x2c > +#define CR2_PTM (1 << 2) > +#define CR2_RECINVSID (1 << 1) > +#define CR2_E2H (1 << 0) > + > +#define ARM_SMMU_GBPA 0x44 > +#define GBPA_UPDATE (1 << 31) > +#define GBPA_ABORT (1 << 20) > + > +#define ARM_SMMU_IRQ_CTRL 0x50 > +#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) > +#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) > +#define IRQ_CTRL_GERROR_IRQEN (1 << 0) > + > +#define ARM_SMMU_IRQ_CTRLACK 0x54 > + > +#define ARM_SMMU_GERROR 0x60 > +#define GERROR_SFM_ERR (1 << 8) > +#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) > +#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) > +#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) > +#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) > +#define GERROR_PRIQ_ABT_ERR (1 << 3) > +#define GERROR_EVTQ_ABT_ERR (1 << 2) > +#define GERROR_CMDQ_ERR (1 << 0) > +#define GERROR_ERR_MASK 0xfd > + > +#define ARM_SMMU_GERRORN 0x64 > + > +#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 > +#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 > +#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 > + > +#define ARM_SMMU_STRTAB_BASE 0x80 > +#define STRTAB_BASE_RA (1UL << 62) > +#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) > + > +#define ARM_SMMU_STRTAB_BASE_CFG 0x88 > +#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) > +#define STRTAB_BASE_CFG_FMT_LINEAR 0 > +#define STRTAB_BASE_CFG_FMT_2LVL 1 > +#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) > +#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) > + > +#define ARM_SMMU_CMDQ_BASE 0x90 > +#define ARM_SMMU_CMDQ_PROD 0x98 > +#define ARM_SMMU_CMDQ_CONS 0x9c > + > +#define ARM_SMMU_EVTQ_BASE 0xa0 > +#define ARM_SMMU_EVTQ_PROD 0x100a8 > +#define ARM_SMMU_EVTQ_CONS 0x100ac > +#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 > +#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 > +#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc > + > +#define ARM_SMMU_PRIQ_BASE 0xc0 > +#define ARM_SMMU_PRIQ_PROD 0x100c8 > +#define ARM_SMMU_PRIQ_CONS 0x100cc > +#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 > +#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 > +#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc > + > +#define ARM_SMMU_REG_SZ 0xe00 > + > +/* Common MSI config fields */ > +#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) > +#define MSI_CFG2_SH GENMASK(5, 4) > +#define MSI_CFG2_MEMATTR GENMASK(3, 0) > + > +/* Common memory attribute values */ > +#define ARM_SMMU_SH_NSH 0 > +#define ARM_SMMU_SH_OSH 2 > +#define ARM_SMMU_SH_ISH 3 > +#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 > +#define ARM_SMMU_MEMATTR_OIWB 0xf > + > +#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) > +#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) > +#define Q_OVERFLOW_FLAG (1 << 31) > +#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) > +#define Q_ENT(q, p) ((q)->base + \ > + Q_IDX(&((q)->llq), p) * \ > + (q)->ent_dwords) > + > +#define Q_BASE_RWA (1UL << 62) > +#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) > +#define Q_BASE_LOG2SIZE GENMASK(4, 0) > + > +/* Ensure DMA allocations are naturally aligned */ > +#ifdef CONFIG_CMA_ALIGNMENT > +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) > +#else > +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) > +#endif > + > +/* > + * Stream table. > + * > + * Linear: Enough to cover 1 << IDR1.SIDSIZE entries > + * 2lvl: 128k L1 entries, > + * 256 lazy entries per table (each table covers a PCI bus) > + */ > +#define STRTAB_L1_SZ_SHIFT 20 > +#define STRTAB_SPLIT 8 > + > +#define STRTAB_L1_DESC_DWORDS 1 > +#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) > +#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) > + > +#define STRTAB_STE_DWORDS 8 > +#define STRTAB_STE_0_V (1UL << 0) > +#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) > +#define STRTAB_STE_0_CFG_ABORT 0 > +#define STRTAB_STE_0_CFG_BYPASS 4 > +#define STRTAB_STE_0_CFG_S1_TRANS 5 > +#define STRTAB_STE_0_CFG_S2_TRANS 6 > + > +#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) > +#define STRTAB_STE_0_S1FMT_LINEAR 0 > +#define STRTAB_STE_0_S1FMT_64K_L2 2 > +#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) > +#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) > + > +#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) > +#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 > +#define STRTAB_STE_1_S1DSS_BYPASS 0x1 > +#define STRTAB_STE_1_S1DSS_SSID0 0x2 > + > +#define STRTAB_STE_1_S1C_CACHE_NC 0UL > +#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL > +#define STRTAB_STE_1_S1C_CACHE_WT 2UL > +#define STRTAB_STE_1_S1C_CACHE_WB 3UL > +#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) > +#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) > +#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) > + > +#define STRTAB_STE_1_S1STALLD (1UL << 27) > + > +#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) > +#define STRTAB_STE_1_EATS_ABT 0UL > +#define STRTAB_STE_1_EATS_TRANS 1UL > +#define STRTAB_STE_1_EATS_S1CHK 2UL > + > +#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) > +#define STRTAB_STE_1_STRW_NSEL1 0UL > +#define STRTAB_STE_1_STRW_EL2 2UL > + > +#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) > +#define STRTAB_STE_1_SHCFG_INCOMING 1UL > + > +#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) > +#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) > +#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) > +#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) > +#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) > +#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) > +#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) > +#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) > +#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) > +#define STRTAB_STE_2_S2AA64 (1UL << 51) > +#define STRTAB_STE_2_S2ENDI (1UL << 52) > +#define STRTAB_STE_2_S2PTW (1UL << 54) > +#define STRTAB_STE_2_S2R (1UL << 58) > + > +#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) > + > +/* > + * Context descriptors. > + * > + * Linear: when less than 1024 SSIDs are supported > + * 2lvl: at most 1024 L1 entries, > + * 1024 lazy entries per table. > + */ > +#define CTXDESC_SPLIT 10 > +#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) > + > +#define CTXDESC_L1_DESC_DWORDS 1 > +#define CTXDESC_L1_DESC_V (1UL << 0) > +#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) > + > +#define CTXDESC_CD_DWORDS 8 > +#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) > +#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) > +#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) > +#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) > +#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) > +#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) > +#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) > + > +#define CTXDESC_CD_0_ENDI (1UL << 15) > +#define CTXDESC_CD_0_V (1UL << 31) > + > +#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) > +#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) > + > +#define CTXDESC_CD_0_AA64 (1UL << 41) > +#define CTXDESC_CD_0_S (1UL << 44) > +#define CTXDESC_CD_0_R (1UL << 45) > +#define CTXDESC_CD_0_A (1UL << 46) > +#define CTXDESC_CD_0_ASET (1UL << 47) > +#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) > + > +#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) > + > +/* > + * When the SMMU only supports linear context descriptor tables, pick a > + * reasonable size limit (64kB). > + */ > +#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) > + > +/* Command queue */ > +#define CMDQ_ENT_SZ_SHIFT 4 > +#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) > +#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) > + > +#define CMDQ_CONS_ERR GENMASK(30, 24) > +#define CMDQ_ERR_CERROR_NONE_IDX 0 > +#define CMDQ_ERR_CERROR_ILL_IDX 1 > +#define CMDQ_ERR_CERROR_ABT_IDX 2 > +#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 > + > +#define CMDQ_0_OP GENMASK_ULL(7, 0) > +#define CMDQ_0_SSV (1UL << 11) > + > +#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) > +#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) > + > +#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) > +#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_CFGI_1_LEAF (1UL << 0) > +#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) > + > +#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) > +#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) > +#define CMDQ_TLBI_1_LEAF (1UL << 0) > +#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) > +#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) > + > +#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) > +#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_ATC_0_GLOBAL (1UL << 9) > +#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) > +#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) > + > +#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) > +#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) > +#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) > + > +#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) > +#define CMDQ_SYNC_0_CS_NONE 0 > +#define CMDQ_SYNC_0_CS_IRQ 1 > +#define CMDQ_SYNC_0_CS_SEV 2 > +#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) > +#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) > +#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) > +#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) > + > +/* Event queue */ > +#define EVTQ_ENT_SZ_SHIFT 5 > +#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) > +#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) > + > +#define EVTQ_0_ID GENMASK_ULL(7, 0) > + > +/* PRI queue */ > +#define PRIQ_ENT_SZ_SHIFT 4 > +#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) > +#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) > + > +#define PRIQ_0_SID GENMASK_ULL(31, 0) > +#define PRIQ_0_SSID GENMASK_ULL(51, 32) > +#define PRIQ_0_PERM_PRIV (1UL << 58) > +#define PRIQ_0_PERM_EXEC (1UL << 59) > +#define PRIQ_0_PERM_READ (1UL << 60) > +#define PRIQ_0_PERM_WRITE (1UL << 61) > +#define PRIQ_0_PRG_LAST (1UL << 62) > +#define PRIQ_0_SSID_V (1UL << 63) > + > +#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) > +#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) > + > +/* High-level queue structures */ > +#define ARM_SMMU_POLL_TIMEOUT_US 100 > +#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ > +#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 > + > +#define FIELD_PREP(_mask, _val) \ > + (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) > + > +#define FIELD_GET(_mask, _reg) \ > + ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) > + > +/* Linux compatibility functions. */ > +typedef paddr_t dma_addr_t; > +typedef paddr_t phys_addr_t; > +typedef unsigned int gfp_t; > + > +/* Alias to Xen lock functions */ > +#define mutex spinlock > +#define mutex_init spin_lock_init > +#define mutex_lock spin_lock > +#define mutex_unlock spin_unlock > + > +/* SMMU private data for an IOMMU domain */ > +enum arm_smmu_domain_stage { > + ARM_SMMU_DOMAIN_S1 = 0, > + ARM_SMMU_DOMAIN_S2, > + ARM_SMMU_DOMAIN_NESTED, > + ARM_SMMU_DOMAIN_BYPASS, > +}; > + > +/* Xen specific code. */ > +struct iommu_domain { > + /* Runtime SMMU configuration for this iommu_domain */ > + atomic_t ref; > + /* > + * Used to link iommu_domain contexts for a same domain. > + * There is at least one per-SMMU to used by the domain. > + */ > + struct list_head list; > +}; > + > +/* Describes information required for a Xen domain */ > +struct arm_smmu_xen_domain { > + spinlock_t lock; > + > + /* List of iommu domains associated to this domain */ > + struct list_head contexts; > +}; > + > +enum pri_resp { > + PRI_RESP_DENY = 0, > + PRI_RESP_FAIL = 1, > + PRI_RESP_SUCC = 2, > +}; > + > +#ifdef CONFIG_MSI > +enum arm_smmu_msi_index { > + EVTQ_MSI_INDEX, > + GERROR_MSI_INDEX, > + PRIQ_MSI_INDEX, > + ARM_SMMU_MAX_MSIS, > +}; > + > +static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { > + [EVTQ_MSI_INDEX] = { > + ARM_SMMU_EVTQ_IRQ_CFG0, > + ARM_SMMU_EVTQ_IRQ_CFG1, > + ARM_SMMU_EVTQ_IRQ_CFG2, > + }, > + [GERROR_MSI_INDEX] = { > + ARM_SMMU_GERROR_IRQ_CFG0, > + ARM_SMMU_GERROR_IRQ_CFG1, > + ARM_SMMU_GERROR_IRQ_CFG2, > + }, > + [PRIQ_MSI_INDEX] = { > + ARM_SMMU_PRIQ_IRQ_CFG0, > + ARM_SMMU_PRIQ_IRQ_CFG1, > + ARM_SMMU_PRIQ_IRQ_CFG2, > + }, > +}; > +#endif /* CONFIG_MSI */ > + > +struct arm_smmu_cmdq_ent { > + /* Common fields */ > + u8 opcode; > + bool substream_valid; > + > + /* Command-specific fields */ > + union { > + #define CMDQ_OP_PREFETCH_CFG 0x1 > + struct { > + u32 sid; > + u8 size; > + u64 addr; > + } prefetch; > + > + #define CMDQ_OP_CFGI_STE 0x3 > + #define CMDQ_OP_CFGI_ALL 0x4 > + struct { > + u32 sid; > + union { > + bool leaf; > + u8 span; > + }; > + } cfgi; > + > + #define CMDQ_OP_TLBI_EL2_ALL 0x20 > + #define CMDQ_OP_TLBI_S12_VMALL 0x28 > + #define CMDQ_OP_TLBI_S2_IPA 0x2a > + #define CMDQ_OP_TLBI_NSNH_ALL 0x30 > + struct { > + u16 asid; > + u16 vmid; > + bool leaf; > + u64 addr; > + } tlbi; > + > + #define CMDQ_OP_ATC_INV 0x40 > + #define ATC_INV_SIZE_ALL 52 > + struct { > + u32 sid; > + u32 ssid; > + u64 addr; > + u8 size; > + bool global; > + } atc; > + > + #define CMDQ_OP_PRI_RESP 0x41 > + struct { > + u32 sid; > + u32 ssid; > + u16 grpid; > + enum pri_resp resp; > + } pri; > + > + #define CMDQ_OP_CMD_SYNC 0x46 > + struct { > + u32 msidata; > + u64 msiaddr; > + } sync; > + }; > +}; > + > +struct arm_smmu_ll_queue { > + u32 prod; > + u32 cons; > + u32 max_n_shift; > +}; > + > +struct arm_smmu_queue { > + struct arm_smmu_ll_queue llq; > + int irq; /* Wired interrupt */ > + > + __le64 *base; > + dma_addr_t base_dma; > + u64 q_base; > + > + size_t ent_dwords; > + > + u32 __iomem *prod_reg; > + u32 __iomem *cons_reg; > +}; > + > +struct arm_smmu_cmdq { > + struct arm_smmu_queue q; > + spinlock_t lock; > +}; > + > +struct arm_smmu_evtq { > + struct arm_smmu_queue q; > + u32 max_stalls; > +}; > + > +struct arm_smmu_priq { > + struct arm_smmu_queue q; > +}; > + > +/* High-level stream table and context descriptor structures */ > +struct arm_smmu_strtab_l1_desc { > + u8 span; > + > + __le64 *l2ptr; > + dma_addr_t l2ptr_dma; > +}; > + > +struct arm_smmu_s2_cfg { > + u16 vmid; > + u64 vttbr; > + u64 vtcr; > +}; > + > +struct arm_smmu_strtab_cfg { > + __le64 *strtab; > + dma_addr_t strtab_dma; > + struct arm_smmu_strtab_l1_desc *l1_desc; > + unsigned int num_l1_ents; > + > + u64 strtab_base; > + u32 strtab_base_cfg; > +}; > + > +struct arm_lpae_s2_cfg { > + u64 vttbr; > + struct { > + u32 ps:3; > + u32 tg:2; > + u32 sh:2; > + u32 orgn:2; > + u32 irgn:2; > + u32 sl:2; > + u32 tsz:6; > + } vtcr; > +}; > + > +/* An SMMUv3 instance */ > +struct arm_smmu_device { > + struct device *dev; > + void __iomem *base; > + void __iomem *page1; > + > +#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) > +#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) > +#define ARM_SMMU_FEAT_TT_LE (1 << 2) > +#define ARM_SMMU_FEAT_TT_BE (1 << 3) > +#define ARM_SMMU_FEAT_PRI (1 << 4) > +#define ARM_SMMU_FEAT_ATS (1 << 5) > +#define ARM_SMMU_FEAT_SEV (1 << 6) > +#define ARM_SMMU_FEAT_MSI (1 << 7) > +#define ARM_SMMU_FEAT_COHERENCY (1 << 8) > +#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) > +#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) > +#define ARM_SMMU_FEAT_STALLS (1 << 11) > +#define ARM_SMMU_FEAT_HYP (1 << 12) > +#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) > +#define ARM_SMMU_FEAT_VAX (1 << 14) > + u32 features; > + > +#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) > +#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) > + u32 options; > + > + struct arm_smmu_cmdq cmdq; > + struct arm_smmu_evtq evtq; > + struct arm_smmu_priq priq; > + > + int gerr_irq; > + int combined_irq; > + u32 sync_nr; > + u8 prev_cmd_opcode; > + > + unsigned long ias; /* IPA */ > + unsigned long oas; /* PA */ > + unsigned long pgsize_bitmap; > + > +#define ARM_SMMU_MAX_VMIDS (1 << 16) > + unsigned int vmid_bits; > + DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); > + > + unsigned int sid_bits; > + > + struct arm_smmu_strtab_cfg strtab_cfg; > + > + /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ > + union { > + u32 sync_count; > + u64 padding; > + }; > + > + /* Need to keep a list of SMMU devices */ > + struct list_head devices; > + > + /* Tasklets for handling evts/faults and pci page request IRQs*/ > + struct tasklet evtq_irq_tasklet; > + struct tasklet priq_irq_tasklet; > + struct tasklet combined_irq_tasklet; > +}; > + > +/* SMMU private data for each master */ > +struct arm_smmu_master { > + struct arm_smmu_device *smmu; > + struct device *dev; > + struct arm_smmu_domain *domain; > + struct list_head domain_head; > + u32 *sids; > + unsigned int num_sids; > + bool ats_enabled; > +}; > + > +struct arm_smmu_domain { > + struct arm_smmu_device *smmu; > + struct mutex init_mutex; /* Protects smmu pointer */ > + > + bool non_strict; > + atomic_t nr_ats_masters; > + > + enum arm_smmu_domain_stage stage; > + struct arm_smmu_s2_cfg s2_cfg; > + > + /* Xen domain associated with this SMMU domain */ > + struct domain *d; > + > + struct iommu_domain domain; > + > + struct list_head devices; > + spinlock_t devices_lock; > +}; > + > +#endif /* _ARM_SMMU_V3_H */ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:31:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397981.638720 (Exim 4.92) (envelope-from ) id 1oUG89-000757-ID; Fri, 02 Sep 2022 23:31:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397981.638720; Fri, 02 Sep 2022 23:31:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUG89-000750-FV; Fri, 02 Sep 2022 23:31:21 +0000 Received: by outflank-mailman (input) for mailman id 397981; Fri, 02 Sep 2022 23:31:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUG88-00074s-Cy for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 23:31:20 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 582835ca-2b17-11ed-82f2-63bd783d45fa; Sat, 03 Sep 2022 01:31:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B45B161FCD; Fri, 2 Sep 2022 23:31:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2443CC433C1; Fri, 2 Sep 2022 23:31:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 582835ca-2b17-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662161476; bh=aGPtGfrss2v0h96EQ2/TiDm3KtRUOUN2TO3kyqHElxM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NwHOokM6VBGAOrzF0Ybkm71KCf7kSNoU+VfcK2OXMHvJfMqJHum/UdzW0GEBZowVb ipESM7LFM5MXNxyqJ+sxllAfqD8E/7rIU6eQTfn62Wi/02PbpI0Y6teChwLo+s6ggx UMOBYlBNiTSQWThExirxrIoc09aEMvEsVZhxYqNFbkbdnUIX3oBi4Xg/IihLb2l1Ph Hk06PIAKk1HYPUBq4y7yQMu7dCn6EPhlFGPLcihW3MOJIWp9vMFdpK6FpkqyET29RO 1doPY6jIHqnGW3jSmb76OGMsEiRn/4rnbvFAnFsd1rQXGqKhtSVcuktxA5BPLDOZ3w X06lkZ/QpxAmQ== Date: Fri, 2 Sep 2022 16:31:14 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v2 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII I checked all the patches against the originals. I had comments on patches 3,4,5. You can add: Acked-by: Stefano Stabellini to all the others (1,2,6,7,8,9,10). On Fri, 2 Sep 2022, Rahul Singh wrote: > This patch series merge the applicable Linux fixes to Xen. > > Bixuan Cui (1): > xen/arm: smmuv3: Change *array into *const array > > Christophe JAILLET (1): > xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation > > Gustavo A. R. Silva (1): > xen/arm: smmuv3: Fix fall-through warning for Clang > > Jean-Philippe Brucker (2): > xen/arm: smmuv3: Fix endianness annotations > xen/arm: smmuv3: Move definitions to a header > > Robin Murphy (1): > xen/arm: smmuv3: Remove the page 1 fixup > > Zenghui Yu (2): > xen/arm: smmuv3: Fix l1 stream table size in the error message > xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command > > Zhen Lei (1): > xen/arm: smmuv3: Remove unnecessary oom message > > Zhou Wang (1): > xen/arm: smmuv3: Ensure queue is read after updating prod pointer > > xen/arch/arm/include/asm/system.h | 1 + > xen/drivers/passthrough/arm/smmu-v3.c | 742 ++------------------------ > xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ > 3 files changed, 708 insertions(+), 707 deletions(-) > create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:47:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397989.638732 (Exim 4.92) (envelope-from ) id 1oUGNz-0000DY-UQ; Fri, 02 Sep 2022 23:47:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397989.638732; Fri, 02 Sep 2022 23:47:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGNz-0000DR-Rc; Fri, 02 Sep 2022 23:47:43 +0000 Received: by outflank-mailman (input) for mailman id 397989; Fri, 02 Sep 2022 23:47:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGNy-0000DG-Nf; Fri, 02 Sep 2022 23:47:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGNy-0001Aa-IK; Fri, 02 Sep 2022 23:47:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGNy-0002rA-5s; Fri, 02 Sep 2022 23:47:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUGNy-00007f-5R; Fri, 02 Sep 2022 23:47:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6DBi4e/L6bHyQuCiGV/lqJIpZVnwB2zY82c9id7Km2s=; b=25RKuBcZTjsNtsLLFQ4+2kVULo g/8mM9KZBuW0WIi6GbE3Mz/hN19lR22poetlX5tWycaa3MXpcczKEu++b0UkeIqtJKEXZVu/NyIr9 uNgDqNF1f1PjVO9e/eFh7UOzz33tGRGJfNRk5AXFikMCF4pCiMGPgAkxEnWYECn75RkE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172944: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 02 Sep 2022 23:47:42 +0000 flight 172944 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172944/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 228 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 02 23:49:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 02 Sep 2022 23:49:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.397998.638743 (Exim 4.92) (envelope-from ) id 1oUGPW-0000pB-Am; Fri, 02 Sep 2022 23:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 397998.638743; Fri, 02 Sep 2022 23:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGPW-0000p4-7c; Fri, 02 Sep 2022 23:49:18 +0000 Received: by outflank-mailman (input) for mailman id 397998; Fri, 02 Sep 2022 23:49:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGPU-0000ow-M8 for xen-devel@lists.xenproject.org; Fri, 02 Sep 2022 23:49:16 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9a55b32-2b19-11ed-82f2-63bd783d45fa; Sat, 03 Sep 2022 01:49:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB30061FFA; Fri, 2 Sep 2022 23:49:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0E7FC433C1; Fri, 2 Sep 2022 23:49:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9a55b32-2b19-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662162553; bh=ik3thNg7dTQ8AhGyWYMWMEz36RuPncLzi0M44FIfYkY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=gB+dlJEEuAFGKzH8+7znd9dDQbx34URZ6ZWqfMwK87BesCr4V6aFW5wzcwQGZeXsw XoDNEz3Z83YYR3M9aRFgXCatEIj42RPfSopSKY5ghgMWben4ZyRc2NJiOk4jpVKgEm 6u5+z4Sld1cF/u/vIR9YyRGb9JqdIVs0kep0nzS5Lz22+sTfOP3Ed6f+ZGGvR2MGfI 4X6oTntYVHpmhG+MVis/iCR9lqRmwHkJeUazBjS5V733DA22EznC5/GTqwErO+DyWq bDYqNjb38uri6KvwiTrRZHqw3Qw9aVtdXMGbTNgiIJx3oQYL3QKrqElUCnvgM1f3d1 /rb517pL7t8UA== Date: Fri, 2 Sep 2022 16:49:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 In-Reply-To: <20220902070905.1262-4-michal.orzel@amd.com> Message-ID: References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 2 Sep 2022, Michal Orzel wrote: > Add a new test job qemu-smoke-arm64-gcc-boot-cpupools that will execute > script qemu-smoke-arm64.sh to test boot time cpupools feature. > Enable CONFIG_BOOT_TIME_CPUPOOLS for the arm64 build and add a new test > case in qemu-smoke-arm64.sh that if selected will: > - create a device tree cpupool node with cpu@1 > - assign created cpupool to domU0 > - add a check in dom0 xen.start to see if domU is assigned a Pool-1 > > Take the opportunity to refactor the qemu-smoke-arm64.sh script as > follows: > - use domU_check to store the test's commands to be run from domU > - use dom0_check to store the test's commands to be run from dom0 > - use fdtput instead of sed to perform dtb modifications > - use more meaningful messages for "passed" variable. This way we can > grep for messages reported either by domU or dom0 and get rid of > assumption that tests can only be run from domU > > Signed-off-by: Michal Orzel > --- > automation/gitlab-ci/test.yaml | 19 +++++++++++++++ > automation/scripts/build | 3 ++- > automation/scripts/qemu-smoke-arm64.sh | 33 +++++++++++++++++++------- > 3 files changed, 45 insertions(+), 10 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 07209820b474..d899b3bdbf7a 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -100,6 +100,25 @@ qemu-smoke-arm64-gcc-staticmem: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-boot-cpupools: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-arm64 > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm32-gcc: > extends: .test-jobs-common > variables: > diff --git a/automation/scripts/build b/automation/scripts/build > index 2b9f2d2b541a..2f15ab3198e6 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -19,7 +19,8 @@ else > echo " > CONFIG_EXPERT=y > CONFIG_UNSUPPORTED=y > -CONFIG_STATIC_MEMORY=y" > xen/.config > +CONFIG_STATIC_MEMORY=y > +CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config > make -j$(nproc) -C xen olddefconfig > else > make -j$(nproc) -C xen defconfig > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index 7ac96027760d..c2184850293c 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -4,20 +4,22 @@ set -ex > > test_variant=$1 > > -passed="passed" > -check=" > +if [ -z "${test_variant}" ]; then > + passed="ping test passed" > + domU_check=" > until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do > sleep 30 > done > echo \"${passed}\" > " > +fi > > if [[ "${test_variant}" == "static-mem" ]]; then > # Memory range that is statically allocated to DOM1 > domu_base="50000000" > domu_size="10000000" > passed="${test_variant} test passed" > - check=" > + domU_check=" > current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) > expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) > if [[ \"\${expected}\" == \"\${current}\" ]]; then > @@ -42,11 +44,23 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > -cpu cortex-a57 -machine type=virt \ > -m 1024 -smp 2 -display none \ > -machine dumpdtb=binaries/virt-gicv2.dtb > -# XXX disable pl061 to avoid Linux crash > -dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv2.dts > binaries/virt-gicv2-edited.dts > -dtc -I dts -O dtb binaries/virt-gicv2-edited.dts > binaries/virt-gicv2.dtb > > +# XXX disable pl061 to avoid Linux crash > +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled Currently this test fails with: + fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled + [[ boot-cpupools == \b\o\o\t\-\c\p\u\p\o\o\l\s ]] ++ fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle Error at 'phandle': FDT_ERR_NOTFOUND Given my other comment below, I would leave this code as is. > +if [[ "${test_variant}" == "boot-cpupools" ]]; then > + # Create cpupool node and assign it to domU0 > + cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" > + cpupool_phandle="0xffffff" > + fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool > + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle > + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle > + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/domU0 domain-cpupool $cpupool_phandle > + > + # Check if domU0 (id=1) is assigned to Pool-1 > + passed="${test_variant} test passed" > + dom0_check="if xl list -c 1 | grep -q Pool-1; then echo ${passed}; fi" > +fi I would prefer to keep the device tree editing here to a minimum and instead add boot-cpupool support in ImageBuilder and add CPUPOOL* config options to the existing config file for ImageBuilder created in this file below. This way, we keep this test cleaner and we help more the user by proving a way to set boot-cpupools more easily in general, also useful outside gitlab-ci. From xen-devel-bounces@lists.xenproject.org Sat Sep 03 00:24:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 00:24:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398005.638754 (Exim 4.92) (envelope-from ) id 1oUGxL-0005Z3-6f; Sat, 03 Sep 2022 00:24:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398005.638754; Sat, 03 Sep 2022 00:24:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGxL-0005Yw-3e; Sat, 03 Sep 2022 00:24:15 +0000 Received: by outflank-mailman (input) for mailman id 398005; Sat, 03 Sep 2022 00:24:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUGxJ-0005Yq-AT for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 00:24:13 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb1a7e45-2b1e-11ed-82f2-63bd783d45fa; Sat, 03 Sep 2022 02:24:11 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1FA0FB82E29; Sat, 3 Sep 2022 00:24:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DB65C433C1; Sat, 3 Sep 2022 00:24:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb1a7e45-2b1e-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662164648; bh=17z6o1CQ36/VMrWC+vGRVK+1nGFALftB9WB0YaVAIvQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UTZ3qEJIKVD+2vJ9uNrYN9dAul/E9PymIbODiXbRhCQoPN0VhRe5PkazBXQEGlA2H fRxY0uU+KTcbKkTqfpWtM9tqNgvnAtfkUgnKjUTMty7RD14Y2t/6sEFniIl1eqz4BR K2LEs9jdZk9pxWhFHM5l/Q27OawI2654uqyurZTmVN7R4t/ycEZs4ga6IJeVeBl/Jn Vuvf+P1GslJIYVcx45zS6jIGAUkYJPKyJVNH5s9KX/W9Fu1o3aTdNXWPyxBKYPnITB EfQfYXi/lrOv7wSJT0Qn26KHoi9VgJGX+ZxQG0igMRoXiwx8qCEqkmdXZrpe1zlaSD v2yjCvdEwV49Q== Date: Fri, 2 Sep 2022 17:24:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 1 Sep 2022, Rahul Singh wrote: > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh > --- > Changes in v3: > - fix minor comments > --- > xen/arch/arm/include/asm/pci.h | 2 ++ > xen/arch/arm/pci/pci-host-common.c | 43 ++++++++++++++++++++++++++++++ > xen/arch/x86/include/asm/pci.h | 10 +++++++ > xen/drivers/passthrough/pci.c | 8 +++--- > 4 files changed, 59 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h > index 80a2431804..8cb46f6b71 100644 > --- a/xen/arch/arm/include/asm/pci.h > +++ b/xen/arch/arm/include/asm/pci.h > @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, > > int pci_host_bridge_mappings(struct domain *d); > > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); > + > #else /*!CONFIG_HAS_PCI*/ > > struct arch_pci_dev { }; > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index 89ef30028e..0eb121666d 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -24,6 +24,16 @@ > > #include > > +/* > + * struct to hold pci device bar. > + */ > +struct pdev_bar > +{ > + mfn_t start; > + mfn_t end; > + bool is_valid; > +}; > + > /* > * List for all the pci host bridges. > */ > @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) > return 0; > } > > +static int is_bar_valid(const struct dt_device_node *dev, > + uint64_t addr, uint64_t len, void *data) > +{ > + struct pdev_bar *bar_data = data; > + unsigned long s = mfn_x(bar_data->start); > + unsigned long e = mfn_x(bar_data->end); > + > + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) > + bar_data->is_valid = true; This patch looks good and you addressed all Jan's comment well. Before I ack it, one question. I know that you made this change to address Jan's comment but using PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= PFN_UP(addr + len - 1)) check means that we are relaxing the requirements, aren't we? I know that this discussion is a bit pointless because addr and len should always be page aligned, and if they weren't it would be a mistake. But assuming that they are not page aligned, wouldn't we want this check to be a strict as possible? Wouldn't we want to ensure that the [s,e] range is a strict subset of [addr,addr+len-1] ? If so we would need to do the following instead: if ( (s <= e) && (s >= PFN_UP(addr)) && (e <= PFN_DOWN(addr + len - 1)) ) bar_data->is_valid = true; From xen-devel-bounces@lists.xenproject.org Sat Sep 03 00:53:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 00:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398012.638764 (Exim 4.92) (envelope-from ) id 1oUHPC-0000M0-E8; Sat, 03 Sep 2022 00:53:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398012.638764; Sat, 03 Sep 2022 00:53:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUHPC-0000Lt-BQ; Sat, 03 Sep 2022 00:53:02 +0000 Received: by outflank-mailman (input) for mailman id 398012; Sat, 03 Sep 2022 00:53:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUHPB-0000Ln-L0 for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 00:53:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c118ba4e-2b22-11ed-82f2-63bd783d45fa; Sat, 03 Sep 2022 02:52:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8F056202C; Sat, 3 Sep 2022 00:52:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B35D2C433D6; Sat, 3 Sep 2022 00:52:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c118ba4e-2b22-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662166377; bh=oXfjIhgKoRIXrpxJE5IbVwJQItA4R8mh+W0/UVGnvfw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Vpt00UMGrmfL6hh4qiBVQv8c/m4jwC0mkn3KrVoTAGvk0M4c2XLXMLIbiA8s4p0Qf hcocKdHYxDCNfbQ9AtoMrdDtqAuyMzgn0APlwNavty7yVnWnaYCDnCPs5frqSQ3dNT l9XHGBtaQKvA6Eakmw/clPeQhdbW1sQMNRx8Bo0+Qx0xzUSkLLe3hUrvTyZUlinzDp ZjVQ2+/2tG0QCgar3KcvGldD4EL05IY32ekZRcLeXqEp9RNefn88eE+3jgb1TQFEuj riEnY4IvVXf/Tv10nknsVb1FRkeFTjWmF8he5HDAn7sSNBv+U7gShsZ9QsQfrUlhx6 zgDYvabzALabQ== Date: Fri, 2 Sep 2022 17:52:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: roberto.bagnara@bugseng.com cc: Stefano Stabellini , Bertrand Marquis , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , burzalodowa@gmail.com Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations In-Reply-To: <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> Message-ID: References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII +Roberto I think we need Roberto's advice on Rule 20.7. (Full thread below.) The question is on the interpretation of Rule 20.7. Are parenthesis required by Rule 20.7 in the following cases: - macro parameters used as function arguments - macro parameters used as macro arguments - macro parameter used as array index - macro parameter used as lhs in assignment Some of these cases are interesting because they should function correctly even without parenthesis, hence the discussion. In particular parenthesis don't seem necessary at least for the function argument case. Regardless of the MISRA C interpretation, Xenia noticed that Eclair reports violations on these cases (cppcheck does not, I don't know other checkers). On Fri, 2 Sep 2022, Xenia Ragiadakou wrote: > On 9/2/22 05:07, Stefano Stabellini wrote: > > On Thu, 1 Sep 2022, Bertrand Marquis wrote: > > > Hi Xenia, > > > > > > > On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: > > > > > > > > > > > > On 9/1/22 01:35, Stefano Stabellini wrote: > > > > > Patches 1, 4, and 6 are already committed. I plan to commit patches 2, > > > > > 3 > > > > > and 5 in the next couple of days. > > > > > Patch 7 needs further discussions and it is best addressed during the > > > > > next MISRA C sync-up. > > > > > > > > I would like to share here, before the next MISRA C sync, my > > > > understandings that will hopefully resolve a wrong impression of mine, > > > > that I may have spread around, regarding this rule. > > > > There was a misunderstanding regarding the rule 20.7 from my part and I > > > > think that Jan is absolutely right that parenthesizing macro parameters > > > > used as function arguments is not required by the rule. > > > > > > > > The rule 20.7 states "Expressions resulting from the expansion of macro > > > > parameters shall be enclosed in parentheses" and in the rationale of the > > > > rule states "If a macro parameter is not being used as an expression > > > > then the parentheses are not necessary because no operators are > > > > involved.". > > > > > > > > Initially, based on the title, my understanding was that it requires for > > > > the expression resulting from the expansion of the macro to be enclosed > > > > in parentheses. Then, based on the rule explanation and the examples > > > > given, my understanding was that it requires the macro parameters that > > > > are used as expressions to be enclosed in parentheses. > > > > But, after re-thinking about it, the most probable and what makes more > > > > sense, is that it require parentheses around the macro parameters that > > > > are part of an expression and not around those that are used as > > > > expressions. > > > > > > > > Therefore, macro parameters being used as function arguments are not > > > > required to be enclosed in parentheses, because the function arguments > > > > are part of an expression list, not of an expression (comma is evaluated > > > > as separator, not as operator). > > > > While, macro parameters used as rhs and lhs expressions of the > > > > assignment operator are required to be enclosed in parentheses because > > > > they are part of an assignment expression. > > > > > > > > I verified that the violation reported by cppcheck is not due to missing > > > > parentheses around the function argument (though still I have not > > > > understood the origin of the warning). Also, Eclair does not report it. > > > > > > > > Hence, it was a misunderstanding of mine and there is no inconsistency, > > > > with respect to this rule, in adding parentheses around macro parameters > > > > used as rhs of assignments. The rule does not require adding parentheses > > > > around macro parameters used as function arguments and neither cppcheck > > > > nor Eclair report violation for missing parentheses around macro > > > > parameters used as function arguments. > > > > > > > > > Thanks a lot for the detailed explanation :-) > > > > > > What you say does make sense and I agree with your analysis here, only > > > protect when part of an expression and not use as a subsequent parameter > > > (for a function or an other macro). > > > > Yeah I also agree with your analysis, and many thanks for > > double-checking the cppcheck and Eclair's reports. > > Unfortunately in the specific case that I checked, it was not reported because > it was actually an argument to a macro, not a function. > Eclair does report as violations of Rule 20.7 the macro parameters that are > used as function arguments and are not enclosed in parentheses. > > So, one tool reports it as violation and the other one not. > > The same goes, also, for the case where a macro parameter is used as index to > an array. Eclair reports it as violation while cppcheck does not. From xen-devel-bounces@lists.xenproject.org Sat Sep 03 00:56:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 00:56:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398022.638775 (Exim 4.92) (envelope-from ) id 1oUHSp-00012q-2s; Sat, 03 Sep 2022 00:56:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398022.638775; Sat, 03 Sep 2022 00:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUHSp-00012j-0D; Sat, 03 Sep 2022 00:56:47 +0000 Received: by outflank-mailman (input) for mailman id 398022; Sat, 03 Sep 2022 00:56:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUHSn-00012Z-68; Sat, 03 Sep 2022 00:56:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUHSn-0002wa-2b; Sat, 03 Sep 2022 00:56:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUHSm-0008GX-Fi; Sat, 03 Sep 2022 00:56:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUHSm-0007Ql-FC; Sat, 03 Sep 2022 00:56:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Antrhz8qs9svxjXJfyS2P4fYZI7R2Hxd4DyBEdNE/cI=; b=mKLzWPw8ac38ACj+DPOE6yRc0h bk2Q5fpYE4clwBOKSRnbWHKIguMzKxtxaugzOpLtcrPNGn4TzURMe0RLyOIwEHl44BDLi9p6/EHdq YU4GBpk1hNy0lxlX2hawncV1zRFqX4GbjcFlgWehE+8gPiDVb2xnTHcoBcAgMBouTmb4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172940: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=42e66b1cc3a070671001f8a1e933a80818a192bf X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 03 Sep 2022 00:56:44 +0000 flight 172940 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172940/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-amd 20 guest-localmigrate/x10 fail pass in 172931 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail pass in 172931 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 42e66b1cc3a070671001f8a1e933a80818a192bf baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 29 days Failing since 172152 2022-08-05 04:01:26 Z 28 days 66 attempts Testing same since 172922 2022-09-01 22:42:52 Z 1 days 3 attempts ------------------------------------------------------------ 1629 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 167086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 02:20:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 02:20:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398032.638787 (Exim 4.92) (envelope-from ) id 1oUIl8-0007a1-23; Sat, 03 Sep 2022 02:19:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398032.638787; Sat, 03 Sep 2022 02:19:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUIl7-0007Zu-V9; Sat, 03 Sep 2022 02:19:45 +0000 Received: by outflank-mailman (input) for mailman id 398032; Sat, 03 Sep 2022 02:19:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUIl6-0007Zk-KT; Sat, 03 Sep 2022 02:19:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUIl6-00038f-HK; Sat, 03 Sep 2022 02:19:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUIl6-00057O-0v; Sat, 03 Sep 2022 02:19:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUIl5-0003Kf-T0; Sat, 03 Sep 2022 02:19:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ftBkyB2VD6h1biBbyqjl8HwpbmY1RS8M0xtMfyVNa5A=; b=1+WE5rXGArx6RotiF4bVqB7lJR W0CvdNSGPDazLjZHR4E06N+DgJBClgXz8lzvkGs4GgAu0Gf78qpI7FyxYTLZDLRML2qaJ6bv3dnxk tiFfhol1lw18+bjrIcKUqp1s+/MDD7k+GUTarch/Da9+J4BOdjTk+dyJhs+3ESVv7FK0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172946: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 02:19:43 +0000 flight 172946 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172946/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 28 days 229 attempts Testing same since 172926 2022-09-02 02:30:44 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 05:01:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 05:01:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398042.638801 (Exim 4.92) (envelope-from ) id 1oULHZ-00072j-Kq; Sat, 03 Sep 2022 05:01:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398042.638801; Sat, 03 Sep 2022 05:01:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULHZ-00072c-I3; Sat, 03 Sep 2022 05:01:25 +0000 Received: by outflank-mailman (input) for mailman id 398042; Sat, 03 Sep 2022 05:01:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULHY-00072S-WC; Sat, 03 Sep 2022 05:01:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULHY-0006Hy-VC; Sat, 03 Sep 2022 05:01:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULHY-0006WL-Io; Sat, 03 Sep 2022 05:01:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oULHY-0007Ua-IF; Sat, 03 Sep 2022 05:01:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y1rLBOS6QSMGIdjSyuq0DK5DkI7oPKNQHstRf2Jh+CM=; b=Zgr8oMS/5Y6FLvVmdUI6TChk27 hasR/boI5U+2ImOsytoaIOurQylJlEU3QnTMWFLxYyiqyveJ0OjckYx5qp0PqFGyG67uKSpJ/DkoL JwOzYPz8RWrkeWLEpEvhwVnaYGyaensQ9AIGEqWiLT01F929iuxQVWzVcew3Vehj7cRg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172949: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 05:01:24 +0000 flight 172949 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172949/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 29 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 230 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 05:11:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 05:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398051.638812 (Exim 4.92) (envelope-from ) id 1oULRN-0008W0-Ls; Sat, 03 Sep 2022 05:11:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398051.638812; Sat, 03 Sep 2022 05:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULRN-0008Vt-He; Sat, 03 Sep 2022 05:11:33 +0000 Received: by outflank-mailman (input) for mailman id 398051; Sat, 03 Sep 2022 05:11:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULRM-0008Vj-Fm; Sat, 03 Sep 2022 05:11:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULRM-0006Rq-Bn; Sat, 03 Sep 2022 05:11:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oULRL-0006vq-QU; Sat, 03 Sep 2022 05:11:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oULRL-0005Va-Pq; Sat, 03 Sep 2022 05:11:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+1g9qHSeMFOnx9DIZWGqeESbeFOUH4sySgYj0PV/c/k=; b=g10D4jONP+0t2fhWVevxF8v7Sn iq4pxdJwLuOtyJpMKhtppyqvsuvYKJczp+VAC+8LSQjdLFgDk/tsStLnXMALVjn34V+Dyeb5U97pG uxcEWpyAD+3h7GnOOVv3es9AzeBrMX/jrmNQSrjgbr3iL6p80JVW+xwCvacIwJh2ArdA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172943: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-examine:reboot:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sat, 03 Sep 2022 05:11:31 +0000 flight 172943 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172943/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 172934 pass in 172943 test-armhf-armhf-examine 8 reboot fail in 172934 pass in 172943 test-arm64-arm64-xl-vhd 13 guest-start fail pass in 172934 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 172934 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 172934 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 30 days Failing since 172384 2022-08-11 11:13:58 Z 22 days 48 attempts Testing same since 172776 2022-08-25 17:42:45 Z 8 days 19 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 07:19:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 07:19:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398062.638823 (Exim 4.92) (envelope-from ) id 1oUNQj-0003Nj-U5; Sat, 03 Sep 2022 07:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398062.638823; Sat, 03 Sep 2022 07:19:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUNQj-0003Nc-QV; Sat, 03 Sep 2022 07:19:01 +0000 Received: by outflank-mailman (input) for mailman id 398062; Sat, 03 Sep 2022 07:19:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUNQi-0003ND-Et for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 07:19:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUNQh-00008J-MY; Sat, 03 Sep 2022 07:18:59 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oUNQh-0003x4-Ep; Sat, 03 Sep 2022 07:18:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=C8J9W6O0KlfOfOALc3DIYjJw189AZ5F+T/9iAqEN80E=; b=3oyZyt3XRQx4AQHhhFNvC7QTvi rMWGLWAplCUVYaoYvLGx4CYGjt665rK86YmSpzgvgRDn9iXXZ0oeQ//y3Yv5DJOYzJlL+821Fr08A dRozJ7Fdqlw5bp0ckhMZzLeyeqBVbkkoHFc7xN6ImkT1FuM8vbvyqXo3Yp/4VgKyozOw=; Message-ID: Date: Sat, 3 Sep 2022 08:18:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant References: From: Julien Grall Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 01/09/2022 10:29, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh > --- > Changes in v3: > - fix minor comments > --- > xen/arch/arm/include/asm/pci.h | 2 ++ > xen/arch/arm/pci/pci-host-common.c | 43 ++++++++++++++++++++++++++++++ > xen/arch/x86/include/asm/pci.h | 10 +++++++ > xen/drivers/passthrough/pci.c | 8 +++--- > 4 files changed, 59 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h > index 80a2431804..8cb46f6b71 100644 > --- a/xen/arch/arm/include/asm/pci.h > +++ b/xen/arch/arm/include/asm/pci.h > @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, > > int pci_host_bridge_mappings(struct domain *d); > > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); > + > #else /*!CONFIG_HAS_PCI*/ > > struct arch_pci_dev { }; > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index 89ef30028e..0eb121666d 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -24,6 +24,16 @@ > > #include > > +/* > + * struct to hold pci device bar. > + */ I find this comment a bit misleading. What you are storing is a candidate region. IOW, this may or may not be a PCI device bar. Given the current use below, I would rename the structure to something more specific like: pdev_bar_check. > +struct pdev_bar > +{ > + mfn_t start; > + mfn_t end; > + bool is_valid; > +}; > + > /* > * List for all the pci host bridges. > */ > @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) > return 0; > } > > +static int is_bar_valid(const struct dt_device_node *dev, > + uint64_t addr, uint64_t len, void *data) > +{ > + struct pdev_bar *bar_data = data; > + unsigned long s = mfn_x(bar_data->start); > + unsigned long e = mfn_x(bar_data->end); > + > + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) AFAICT 's' and 'e' are provided by pci_check_bar() and will never change. So can we move the check 's <= e' outside of the callback? > + bar_data->is_valid = true; > + > + return 0; > +} > + > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) > +{ Other than the current calls in check_pdev(), do you have plan to use it in more places? The reason I am asking it is this function is non-trivial on Arm (dt_for_each_range() is quite complex). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Sep 03 08:50:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 08:50:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398074.638833 (Exim 4.92) (envelope-from ) id 1oUOqc-0004Bd-Sj; Sat, 03 Sep 2022 08:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398074.638833; Sat, 03 Sep 2022 08:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUOqc-0004BW-Q2; Sat, 03 Sep 2022 08:49:50 +0000 Received: by outflank-mailman (input) for mailman id 398074; Sat, 03 Sep 2022 08:49:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUOqb-0004BM-Am; Sat, 03 Sep 2022 08:49:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUOqb-00029W-6X; Sat, 03 Sep 2022 08:49:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUOqa-00077J-VC; Sat, 03 Sep 2022 08:49:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUOqa-0001AN-Um; Sat, 03 Sep 2022 08:49:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7UpiJ8lvvYTEOFR/gcyjJ/lGkVi9njPX2M91xo17Pbc=; b=muvosdVv88fhap3j5MOQ8BvFyP dF8mL+zHR8HdxhlYirmVK+CPoXTvwNnIuzr9yNYWa/yPAktmLSTDCQtBzuvL4Ar4GOlFss2OWebSi BheARmjn/PmoMxAe6VpiV59jKW/5QXtkbEKplRfiyESETQaHnnNua9qAh9JiCyaMjcTc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172952: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore.2:fail:heisenbug X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 08:49:48 +0000 flight 172952 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-saverestore.2 fail pass in 172949 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 231 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 09:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 09:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398083.638845 (Exim 4.92) (envelope-from ) id 1oUPGf-0007QR-2f; Sat, 03 Sep 2022 09:16:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398083.638845; Sat, 03 Sep 2022 09:16:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUPGe-0007QK-W7; Sat, 03 Sep 2022 09:16:44 +0000 Received: by outflank-mailman (input) for mailman id 398083; Sat, 03 Sep 2022 09:16:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUPGd-0007QA-5N; Sat, 03 Sep 2022 09:16:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUPGd-0002cj-1g; Sat, 03 Sep 2022 09:16:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUPGc-0008Mo-Cw; Sat, 03 Sep 2022 09:16:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUPGc-0003d8-CV; Sat, 03 Sep 2022 09:16:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aPoD0eF3HhxmQCc04pN1mIAByMk5RlqORXIo++G33g8=; b=cVRLwK10GQ0I6VbqRRJ7d472OD dMEm+NnTthmfxgyB6MADISPrgtWOR3WGm2dBXenMHV9aRphsYcd1AGq9wf1rs/xDNL4CKdNUOi1DI vaeQP3cKrGS5Bpb1BKOr+LTNAPaNqbI+JM1Yh/cOeHiFfyULOIHZ28na7TXp+7w9ir5Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172945: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64::broken:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:host-install(5):broken:regression qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 03 Sep 2022 09:16:42 +0000 flight 172945 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172945/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 broken test-amd64-amd64-xl-qemuu-ovmf-amd64 5 host-install(5) broken REGR. vs. 172123 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 30 days Failing since 172148 2022-08-04 21:39:38 Z 29 days 67 attempts Testing same since 172945 2022-09-02 23:10:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 broken test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-ovmf-amd64 broken broken-step test-amd64-amd64-xl-qemuu-ovmf-amd64 host-install(5) Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 09:40:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 09:40:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398094.638856 (Exim 4.92) (envelope-from ) id 1oUPdW-0002FS-0R; Sat, 03 Sep 2022 09:40:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398094.638856; Sat, 03 Sep 2022 09:40:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUPdV-0002FL-TY; Sat, 03 Sep 2022 09:40:21 +0000 Received: by outflank-mailman (input) for mailman id 398094; Sat, 03 Sep 2022 09:40:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUPdT-0002FF-NA for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 09:40:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a65d195-2b6c-11ed-934f-f50d60e1c1bd; Sat, 03 Sep 2022 11:40:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A239061073; Sat, 3 Sep 2022 09:40:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 06579C433C1; Sat, 3 Sep 2022 09:40:14 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id CC84AE924D9; Sat, 3 Sep 2022 09:40:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a65d195-2b6c-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662198015; bh=M3MnJgLMLrOl+cvY1uH1vm+88wtXzYdqrv5Rrl5YSfc=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=EUXv1mxaPzUOTjD/OD0lBjM7j6oE9yhhIW76qK07bL6fddhbUHXpjnfQTQtAJBIB5 jpeD3o77z19BxV/eCpXWhyM26XeLhes3R//7w5jfiOzaZDScOJ4+w688Dfd9dLl2e9 Eai3djs7B4B/qY++eQqW3TC0yHzrMFGe6NhJj/WKa3p+CKW+nq3PNXFA4mVcJqtChL JomjYgPXzPGOUtmznZ28jlNLdzRZC0ID5f+0Ydvt5oUIF09mqTvUwIt8hHz5gwyMOX TbfaT8PNnwl8T0telxAHnx1yNV49TdBbxstI/atz3z3Salt+fWdabwo4KOokHHXLWe qvccCdEB/jfQg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166219801483.23737.17168227064618244830.git-patchwork-notify@kernel.org> Date: Sat, 03 Sep 2022 09:40:14 +0000 References: <20220901115554.16996-1-pdurrant@amazon.com> In-Reply-To: <20220901115554.16996-1-pdurrant@amazon.com> To: Paul Durrant Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org, wei.liu@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, marmarek@invisiblethingslab.com Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 1 Sep 2022 12:55:54 +0100 you wrote: > Removing 'hotplug-status' in backend_disconnected() means that it will be > removed even in the case that the frontend unilaterally disconnects (which > it is free to do at any time). The consequence of this is that, when the > frontend attempts to re-connect, the backend gets stuck in 'InitWait' > rather than moving straight to 'Connected' (which it can do because the > hotplug script has already run). > Instead, the 'hotplug-status' mode should be removed in netback_remove() > i.e. when the vif really is going away. > > [...] Here is the summary with links: - [net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed https://git.kernel.org/netdev/net/c/c55f34b6aec2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Sat Sep 03 10:14:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 10:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398101.638867 (Exim 4.92) (envelope-from ) id 1oUQAb-0005eU-Jp; Sat, 03 Sep 2022 10:14:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398101.638867; Sat, 03 Sep 2022 10:14:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUQAb-0005eN-Gx; Sat, 03 Sep 2022 10:14:33 +0000 Received: by outflank-mailman (input) for mailman id 398101; Sat, 03 Sep 2022 10:14:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUQAa-0005eD-EV; Sat, 03 Sep 2022 10:14:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUQAa-0003dm-A4; Sat, 03 Sep 2022 10:14:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUQAZ-0003YQ-Pv; Sat, 03 Sep 2022 10:14:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUQAZ-0008BG-PS; Sat, 03 Sep 2022 10:14:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZIOgygIRE9CIQne8VktEXQkHHUpmsKr87TwWXFGCKrA=; b=dy6QcIzgXnVTkorI6Sf1najgBB DZHCJneJjhVo/790/DLBNvG2i/cXegQDO+zT/QDS/DTpnYcbOwZFpeTH+uzYjwh10yVhiagKDwSm5 ixAlUXJ4pyzHbJ8NuvrwLENuCltuo8Z7AvUHaHYx/dsKL4tgU+weScm58rmFubXlLsqI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 172951: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c8b796aba31b2c97a1a56867062b3bdd0d81923f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 03 Sep 2022 10:14:31 +0000 flight 172951 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172951/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c8b796aba31b2c97a1a56867062b3bdd0d81923f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 785 days Failing since 151818 2020-07-11 04:18:52 Z 784 days 766 attempts Testing same since 172930 2022-09-02 04:20:43 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121804 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 11:20:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 11:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398110.638877 (Exim 4.92) (envelope-from ) id 1oURCA-00041g-I3; Sat, 03 Sep 2022 11:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398110.638877; Sat, 03 Sep 2022 11:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oURCA-00041Z-FS; Sat, 03 Sep 2022 11:20:14 +0000 Received: by outflank-mailman (input) for mailman id 398110; Sat, 03 Sep 2022 11:20:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oURC9-00041P-RY; Sat, 03 Sep 2022 11:20:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oURC9-0004ru-NC; Sat, 03 Sep 2022 11:20:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oURC9-0000Eb-2c; Sat, 03 Sep 2022 11:20:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oURC9-0001r6-28; Sat, 03 Sep 2022 11:20:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l7d/WOYBbDdxm2Yd35VHs82UZFosfcycCGsmqjQgCOo=; b=5qhA1xkhts9vplVvEe7M7cVcLW B2W5DBY1e1JOxTCxIaF/PO6G6VyQ0tf9ED+jd0yUdaUGqf3EeVx2IgrcTMtg55InlcSWQjZWcfz6T tpP7mG/naBv/FWzeVQnPcgcT9sj8Wy7/092HJayS60YOijxPMBWT8eIoSUTuzirUWCzE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172947: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d895ec7938c431fe61a731939da76a6461bc6133 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 03 Sep 2022 11:20:13 +0000 flight 172947 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172947/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d895ec7938c431fe61a731939da76a6461bc6133 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 30 days Failing since 172152 2022-08-05 04:01:26 Z 29 days 67 attempts Testing same since 172947 2022-09-03 01:11:57 Z 0 days 1 attempts ------------------------------------------------------------ 1673 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171730 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 12:52:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 12:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398121.638889 (Exim 4.92) (envelope-from ) id 1oUSdc-0004NM-EO; Sat, 03 Sep 2022 12:52:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398121.638889; Sat, 03 Sep 2022 12:52:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSdc-0004NF-Ax; Sat, 03 Sep 2022 12:52:40 +0000 Received: by outflank-mailman (input) for mailman id 398121; Sat, 03 Sep 2022 12:52:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSda-0004N5-Kx; Sat, 03 Sep 2022 12:52:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSda-0006QD-JA; Sat, 03 Sep 2022 12:52:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSda-0005In-81; Sat, 03 Sep 2022 12:52:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUSda-0002Tu-7e; Sat, 03 Sep 2022 12:52:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ntvSSFId1KnLW4PXnGGAaVHV2gjOLwZqOd0XQt8aR/g=; b=ABqEgAc6WtXuafpPFlyi4/EFII iSyvEbU57TvPv76bFWEFJoA3LaQ0kW4Uu7NHLO410LxThGTmAGNN0kCIokzBNwJwdKcFGNC0mjeF+ HXWBcJOBvCTkOQCYNBJR4wbaxKG3XHBwyt1HiiE6jk6i3sfWIlU1nsyHG6O0cvoT9IpQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172954: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 12:52:38 +0000 flight 172954 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172954/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 232 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 13:03:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 13:03:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398130.638900 (Exim 4.92) (envelope-from ) id 1oUSnm-0005uG-DJ; Sat, 03 Sep 2022 13:03:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398130.638900; Sat, 03 Sep 2022 13:03:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSnm-0005u9-AP; Sat, 03 Sep 2022 13:03:10 +0000 Received: by outflank-mailman (input) for mailman id 398130; Sat, 03 Sep 2022 13:03:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSnl-0005tz-8y; Sat, 03 Sep 2022 13:03:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSnl-0006e1-4X; Sat, 03 Sep 2022 13:03:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUSnk-0005fZ-Jx; Sat, 03 Sep 2022 13:03:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUSnk-0007Iz-JY; Sat, 03 Sep 2022 13:03:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JxlR6J4L9VebUlgeMgZSlmc/c2kEs28O58arDC4LIQc=; b=40yas1jt1mrdBDVjnEleiQNbFz XVDfvKqGK/5T1ozvnoON72TAMA9opoIfHHKRnNFFo0/ayN0hDCAsVmYxTV8pc1DB4vY88tDeLu904 LLX7D19IHFqyYL5f5ioez02JYMOvzS9jPAJ0OK0qbotg+WzwSDiI7epetigeXJSDTId0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 172948: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e997d055929665b12246e89eb092dc79c65de9a4 X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Sat, 03 Sep 2022 13:03:08 +0000 flight 172948 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172948/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172925 build-i386-libvirt 6 libvirt-build fail like 172925 build-arm64-libvirt 6 libvirt-build fail like 172925 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172925 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172925 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172925 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172925 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172925 build-armhf-libvirt 6 libvirt-build fail like 172925 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172925 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172925 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172925 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172925 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e997d055929665b12246e89eb092dc79c65de9a4 baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172948 2022-09-03 01:53:49 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Sep 03 13:54:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 13:54:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398139.638911 (Exim 4.92) (envelope-from ) id 1oUTbM-0002Wj-9i; Sat, 03 Sep 2022 13:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398139.638911; Sat, 03 Sep 2022 13:54:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUTbM-0002Wc-6x; Sat, 03 Sep 2022 13:54:24 +0000 Received: by outflank-mailman (input) for mailman id 398139; Sat, 03 Sep 2022 13:54:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUTbK-0002WS-HT; Sat, 03 Sep 2022 13:54:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUTbK-0007Ui-BY; Sat, 03 Sep 2022 13:54:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUTbJ-00085c-Qt; Sat, 03 Sep 2022 13:54:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUTbJ-0000HH-QR; Sat, 03 Sep 2022 13:54:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IOba4iZ85kVC7r9k7XjwrBqToS4R50twR3+FBnfVqLA=; b=cc88EmfDRcb9gDpTs3joqGWrnw 1LN+lqvq0gAGdJGF/u2V9CCvRBKpi2949ZmCC3qZuXY79Lxxn434PvXewqetoVRk9kaqIPiYw3Z2y zLUqSfR46IBf+2jdP3B9fDP7TAsBLSLSNcWuU0yBFWH9+apnooKjlVpw0Xob6lc+H4ug=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172957: regressions - FAIL X-Osstest-Failures: ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 13:54:21 +0000 flight 172957 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172957/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386 6 xen-build fail REGR. vs. 172136 build-amd64-xsm 6 xen-build fail REGR. vs. 172136 build-amd64 6 xen-build fail REGR. vs. 172136 build-i386-xsm 6 xen-build fail REGR. vs. 172136 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 233 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 14:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 14:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398153.638930 (Exim 4.92) (envelope-from ) id 1oUUXb-0000GX-0w; Sat, 03 Sep 2022 14:54:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398153.638930; Sat, 03 Sep 2022 14:54:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUUXa-0000GQ-Ud; Sat, 03 Sep 2022 14:54:34 +0000 Received: by outflank-mailman (input) for mailman id 398153; Sat, 03 Sep 2022 14:54:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUUXZ-0000GK-RW for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 14:54:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ff4c98d-2b98-11ed-82f2-63bd783d45fa; Sat, 03 Sep 2022 16:54:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A7B3D34C2C; Sat, 3 Sep 2022 14:54:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 84A8013517; Sat, 3 Sep 2022 14:54:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NmM2H6RqE2PWVQAAMHmgww (envelope-from ); Sat, 03 Sep 2022 14:54:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ff4c98d-2b98-11ed-82f2-63bd783d45fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662216868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CJfyMJFEqY/Rw/Ebm+V1xYgPDk5ZiuDtFBgSCD431IE=; b=KHwL4zNuFAmaKbIR2Y5apZfyfeGzXIFIjyttYMjgv7LGAAMidfWFffpPRNbXE4prRuyKR4 0fbhNVRfPd10vBHYeCCHkoF0iWRFE05iUzYB4Q/GE/LevHeQbZJjEX7d4gklgJLSBs4eDL XaFZLosKG96wZMvDzqHfJIoxfM/OEFg= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v6.0-rc4 Date: Sat, 3 Sep 2022 16:54:28 +0200 Message-Id: <20220903145428.29553-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc4-tag xen: branch for v6.0-rc4 It contains: - a minor fix for the Xen grant driver - a small series fixing a recently introduced problem in the Xen blkfront/blkback drivers with negotiation of feature usage Thanks. Juergen drivers/block/xen-blkback/common.h | 3 +++ drivers/block/xen-blkback/xenbus.c | 6 ++++-- drivers/block/xen-blkfront.c | 20 ++++++++++++-------- drivers/xen/grant-table.c | 3 +++ 4 files changed, 22 insertions(+), 10 deletions(-) Dan Carpenter (1): xen/grants: prevent integer overflow in gnttab_dma_alloc_pages() SeongJae Park (3): xen-blkback: Advertise feature-persistent as user requested xen-blkfront: Advertise feature-persistent as user requested xen-blkfront: Cache feature_persistent value before advertisement From xen-devel-bounces@lists.xenproject.org Sat Sep 03 15:57:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 15:57:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398161.638945 (Exim 4.92) (envelope-from ) id 1oUVWS-0006GS-Kx; Sat, 03 Sep 2022 15:57:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398161.638945; Sat, 03 Sep 2022 15:57:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUVWS-0006GL-IC; Sat, 03 Sep 2022 15:57:28 +0000 Received: by outflank-mailman (input) for mailman id 398161; Sat, 03 Sep 2022 15:57:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUVWR-0006GB-3u; Sat, 03 Sep 2022 15:57:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUVWQ-0001HH-TG; Sat, 03 Sep 2022 15:57:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUVWQ-0003Pv-J2; Sat, 03 Sep 2022 15:57:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUVWQ-0002oO-Ia; Sat, 03 Sep 2022 15:57:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Tb+XLq6VMSAxG3iUT/fMcDroJxL2rljsV5ELQNqCwX0=; b=DmZL/4qBUiIrXDdgea1hnQU8w2 4Mtg7R75lLMnvrrC3Y61sdtNpkHQW4+a+/u3QpvKTNdpYRZigPM3V+RvGUpnzMMB5Sh9vbrMt68c4 Ny6jNAbZvMj3cODXN3ZfHD70Uh9EaNrf/NjmGTzO7eemIeCUkpl8kEp+Yp4/gnCAKljA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172959: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 15:57:26 +0000 flight 172959 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172959/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 234 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 17:19:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 17:19:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398173.638956 (Exim 4.92) (envelope-from ) id 1oUWnw-0006CF-2T; Sat, 03 Sep 2022 17:19:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398173.638956; Sat, 03 Sep 2022 17:19:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUWnv-0006C8-V7; Sat, 03 Sep 2022 17:19:35 +0000 Received: by outflank-mailman (input) for mailman id 398173; Sat, 03 Sep 2022 17:19:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUWnv-0006By-2o; Sat, 03 Sep 2022 17:19:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUWnu-0003Dj-Tq; Sat, 03 Sep 2022 17:19:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUWnu-0007Hq-HB; Sat, 03 Sep 2022 17:19:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUWnu-0000ah-GS; Sat, 03 Sep 2022 17:19:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AAXUNAcUCsyUlujJdqyQ8Zt+weZNynWH0S7HDZgqgVg=; b=b7v/ukVjXaFceMUDRH4Uz3QgwN inYmPHcDlN3Zpt6vK017nKJs+bxeh0x2FPrY1+aCNX4ri2A3mLBjp2Bj+CWotaB37znzb4UxXYE6H FtqzDTDPIjcFfS3n3PbWIkxNvXYkDi8XYju4ch0OQzkEn8Wnech8WEZ4RtBxjFUa02F4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172953: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf:xen-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-examine:reboot:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sat, 03 Sep 2022 17:19:34 +0000 flight 172953 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172953/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf 6 xen-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail in 172934 REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-examine 8 reboot fail in 172934 pass in 172943 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 172934 pass in 172953 test-arm64-arm64-xl-vhd 13 guest-start fail in 172943 pass in 172953 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 172934 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 14 guest-start fail in 172934 like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail in 172934 like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 172934 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 172934 like 172128 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 172934 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 172934 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 172934 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 172934 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 172934 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 172934 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 172934 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 172934 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 172934 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 172934 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 30 days Failing since 172384 2022-08-11 11:13:58 Z 23 days 49 attempts Testing same since 172776 2022-08-25 17:42:45 Z 8 days 20 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf fail build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt blocked build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 18:09:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 18:09:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398185.638969 (Exim 4.92) (envelope-from ) id 1oUXa9-0002zB-T9; Sat, 03 Sep 2022 18:09:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398185.638969; Sat, 03 Sep 2022 18:09:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXa9-0002z4-QU; Sat, 03 Sep 2022 18:09:25 +0000 Received: by outflank-mailman (input) for mailman id 398185; Sat, 03 Sep 2022 18:09:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXa8-0002yu-DR; Sat, 03 Sep 2022 18:09:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXa8-0004AS-9m; Sat, 03 Sep 2022 18:09:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXa7-0001Mq-OP; Sat, 03 Sep 2022 18:09:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUXa7-00084z-Lk; Sat, 03 Sep 2022 18:09:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MoK/IqR7oE2dgu11dlQ5Ha5AgH4Tw++eDu+iQcCbWf0=; b=pi+c6rBS3aXn7SwJOy1SPANkLU gPZl3vavbGBi0GPFW014TrO9NslnvvA1tQgnV3IkxvqClC0rW/ZQ+nJidz2PwodiS6bq7ggqjj+75 2ncy4Krh5NkHH9MWd6m+mwlp73c4o7vpWXqHg/aJhC0otS72iOiYJVq2zasCULnZsAmk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172955: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64::broken:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:host-install(5):broken:heisenbug qemu-mainline:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 03 Sep 2022 18:09:23 +0000 flight 172955 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172955/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 broken in 172945 build-arm64-xsm 6 xen-build fail REGR. vs. 172123 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64 6 xen-build fail REGR. vs. 172123 build-armhf 6 xen-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail in 172945 REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail in 172945 REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-ovmf-amd64 5 host-install(5) broken in 172945 pass in 172955 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 172945 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 172945 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 172945 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 172945 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 172945 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 172945 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 172945 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 172945 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 172945 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 172945 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 172945 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 172945 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 30 days Failing since 172148 2022-08-04 21:39:38 Z 29 days 68 attempts Testing same since 172945 2022-09-02 23:10:19 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm fail build-i386-xsm pass build-amd64 pass build-arm64 fail build-armhf fail build-i386 pass build-amd64-libvirt fail build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-ovmf-amd64 broken Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 18:13:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 18:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398194.638981 (Exim 4.92) (envelope-from ) id 1oUXe9-0004OC-EU; Sat, 03 Sep 2022 18:13:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398194.638981; Sat, 03 Sep 2022 18:13:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXe9-0004O5-Bs; Sat, 03 Sep 2022 18:13:33 +0000 Received: by outflank-mailman (input) for mailman id 398194; Sat, 03 Sep 2022 18:13:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXe8-0004Nv-MW; Sat, 03 Sep 2022 18:13:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXe8-0004Eu-LW; Sat, 03 Sep 2022 18:13:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXe8-0001aZ-E2; Sat, 03 Sep 2022 18:13:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUXe8-0003LE-DZ; Sat, 03 Sep 2022 18:13:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=obIVTegluytln1JhVUSxiunMryeSHEIsldoxpsMW6/8=; b=ThmGJP90EBsFwcMTxdz/pLS9JB vHsdHaMfC262HTSXBeCYsn8vBRxCf49jtqjCLc4XdU6C9O9dPEL8fwxzl02w9hP8i5UXmH37sg4Pk CotiGAbbkWBtU4FJ7iwUZfyeU3+pf3L+XdP5IBs4M0cTDqANbwn/BkR8jNajTufHmT4k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172963: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 18:13:32 +0000 flight 172963 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172963/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 235 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 18:18:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 18:18:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398171.638992 (Exim 4.92) (envelope-from ) id 1oUXiU-00053c-9q; Sat, 03 Sep 2022 18:18:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398171.638992; Sat, 03 Sep 2022 18:18:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUXiU-00053V-59; Sat, 03 Sep 2022 18:18:02 +0000 Received: by outflank-mailman (input) for mailman id 398171; Sat, 03 Sep 2022 16:00:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUVYz-0007v6-WD for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 16:00:07 +0000 Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78df2fd1-2ba1-11ed-934f-f50d60e1c1bd; Sat, 03 Sep 2022 18:00:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78df2fd1-2ba1-11ed-934f-f50d60e1c1bd Date: Sat, 03 Sep 2022 15:59:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1662220803; x=1662480003; bh=JADhOmzo96Ooqdy7QBo3vR1+Orpah3E3wDWR72a1omU=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=M6pV+H2J5atdkuVhffW51nQ5t93mz4D4RoNjrYnFOtmYpJnnTbFvyCjsdxleXHne1 RXZGSdnSwbI39WAicySEgBlLMD5hTKBW/Ywv8V+EWRzy5wqScOm3rspFLBBG3K7Tur Favn+J2qpX68rVTur/QuS8QtEpl6IqqH+EPYcyfH8nNopnU4mgs+q5/n0S/smLZIRi IdoLueecPgfhhUAHg4DFro21rtXyaXnifbQSwEPm4NO5lZO/N//3AgfyXjoabKP74H +Y+A7n19DW/v4g8trOrFikOuwUbw0GwdIAKRNbRZN32THoAxK2wjC2J7jg/GOjXzs8 xV7Z0fRiefIOw== To: jbeulich@suse.com From: Dylanger Daly Cc: xen-devel@lists.xenproject.org, Andrew.Cooper3@citrix.com Reply-To: Dylanger Daly Subject: Re: Ryzen 6000 (Mobile) Message-ID: In-Reply-To: <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> References: <55eb8485-0c0d-51cd-c9b8-d517994ec6c6@suse.com> <7807b9cf-a09e-a393-ee7a-dc220a68e56e@suse.com> <3b2ad2ca-3c6c-4dcb-c603-bd5440350f20@suse.com> <2dHPPtixTlkUXYEzNPFRI4ezKHSe1A2VaThMjBpd1aM3NFkZQuyRdfmNWCigm1oXfdKhOwDJGoPBBIMLYtYhQlENV2eFVZ0G9EMOMj5e6UE=@protonmail.com> <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU" This is a multi-part message in MIME format. --b1_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU Content-Type: multipart/alternative; boundary="b2_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU" --b2_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkgSmFuLAoKQW5vdGhlciB1cGRhdGUsIGlmIEkgYXNzaWduIG9ubHkgMSBjb3JlIHRvIG15IFZN cywgdGhlIHN5c3RlbSBzZWVtcyBzdGFibGUgYW5kIGRvZXMgbm90IGJyZWFrIHRoZSBQQ0llIEJ1 cywgc28gSSBhc3N1bWUgdGhlIGlzc3VlIGlzIHJlbGF0ZWQgdG8gdGhlIFNjaGVkdWxlciBvciBB UElDLCBzZXR0aW5nIGxvZ2x2bD1hbGwgdGhlbiB0cmlnZ2VyaW5nIHRoZSBpc3N1ZSAoNCBjb3Jl cykgWGVuIGNvbXBsYWlucyBhYm91dCBBUElDLCBJJ3ZlIGF0dGFjaGVkIGEgcGljdHVyZSBvZiB0 aGUgWGVuIGxvZy4KCkNoZWVycw== --b2_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 SGkgSmFuLDxicj48YnI+QW5vdGhlciB1cGRhdGUsIGlmIEkgYXNzaWduIG9ubHkgMSBjb3JlIHRv IG15IFZNcywgdGhlIHN5c3RlbSBzZWVtcyBzdGFibGUgYW5kIGRvZXMgbm90IGJyZWFrIHRoZSBQ Q0llIEJ1cywgc28gSSBhc3N1bWUgdGhlIGlzc3VlIGlzIHJlbGF0ZWQgdG8gdGhlIFNjaGVkdWxl ciBvciBBUElDLCBzZXR0aW5nIGxvZ2x2bD1hbGwgdGhlbiB0cmlnZ2VyaW5nIHRoZSBpc3N1ZSAo NCBjb3JlcykgWGVuIGNvbXBsYWlucyBhYm91dCBBUElDLCBJJ3ZlIGF0dGFjaGVkIGEgcGljdHVy ZSBvZiB0aGUgWGVuIGxvZy48YnI+PGJyPkNoZWVycw== --b2_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU-- --b1_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU Content-Type: image/jpeg; name=PXL_20220903_153615927~2.jpg Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=PXL_20220903_153615927~2.jpg /9j/4QRkRXhpZgAASUkqAAgAAAANAAABBAABAAAA8A8AAAEBBAABAAAAxQEAACgBAwABAAAAAgAA AA8BAgAHAAAAqgAAABABAgAMAAAAsQAAADEBAgAVAAAAvQAAADIBAgAUAAAA0gAAABIBAwABAAAA AQAAABMCAwABAAAAAQAAAGmHBAABAAAA9gAAACWIBAABAAAA2AMAABoBBQABAAAA5gAAABsBBQAB AAAA7gAAAP4DAABHb29nbGUAUGl4ZWwgNiBQcm8ASERSKyAxLjAuNDUwNTk0MjA4emQAMjAyMjow OTowMyAxNjo1OTozMABIAAAAAQAAAEgAAAABAAAAKwA0pAIAJgAAAAADAAAzpAIABwAAACYDAAAn iAMAAQAAADgDAAAiiAMAAQAAAAIAAABgpAMAAQAAAAMAAACdggUAAQAAAC0DAACaggUAAQAAADUD AAAXogMAAQAAAAIAAACSkgIABAAAADkyNwASkAIABwAAAD0DAACRkgIABAAAADkyNwARkAIABwAA AEQDAACQkgIABAAAADkyNwAQkAIABwAAAEsDAAAMpAMAAQAAAAEAAAAKpAMAAQAAAAAAAAAKkgUA AQAAAFIDAAAJkgMAAQAAABAAAAAJpAMAAQAAAAAAAAAIpAMAAQAAAAAAAAAHkgMAAQAAAAIAAAAG pAMAAQAAAAAAAAAGkgUAAQAAAFoDAAAFoAQAAQAAALoDAAAFpAMAAQAAABgAAAAFkgUAAQAAAGID AAAEkAIAFAAAAGoDAAAEkgoAAQAAAH4DAAAEpAUAAQAAAIYDAAADoAMAAQAAAAAMAAADpAMAAQAA AAAAAAADkAIAFAAAAI4DAAADkgoAAQAAAKIDAAACoAMAAQAAAPAPAAACpAMAAQAAAAAAAAACkgUA AQAAAKoDAAABkQcABAAAAAECAwABoAMAAQAAAAEAAAABowcAAQAAAAEAAAABpAMAAQAAAAEAAAAB kgoAAQAAALIDAAAAkAcABAAAADAyMzIAoAcABAAAADAxMDAAAAAAUGl4ZWwgNiBQcm8gYmFjayBj YW1lcmEgNi44MW1tIGYvMS44NQBHb29nbGUAuQAAAGQAAADPFwAAQEIPACswMTowMAArMDE6MDAA KzAxOjAwAJoaAADoAwAA5gAAAOgDAACyAAAAZAAAADIwMjI6MDk6MDMgMTY6MzY6MTUAAAAAAAYA AAC0AAAAZAAAADIwMjI6MDk6MDMgMTY6MzY6MTUAbQAAAGQAAACyAAAAZAAAAOACAABkAAAAAgAB AAIABAAAAFI5OAACAAcABAAAADAxMDAAAAAAAgAQAAIAAgAAAE0AAAARAAUAAQAAAPYDAAAAAAAA WQAAAAEAAAAGAAABAwABAAAA/gEAAAEBAwABAAAAgAEAAAMBAwABAAAABgAAACgBAwABAAAAAgAA ABoBBQABAAAATAQAABsBBQABAAAAVAQAAAAAAABIAAAAAQAAAEgAAAABAAAA/+AAEEpGSUYAAQEA AAEAAQAA/+ICKElDQ19QUk9GSUxFAAEBAAACGAAAAAACEAAAbW50clJHQiBYWVogAAAAAAAAAAAA AAAAYWNzcAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAPbWAAEAAAAA0y0AAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAJZGVzYwAAAPAAAAB0clhZ WgAAAWQAAAAUZ1hZWgAAAXgAAAAUYlhZWgAAAYwAAAAUclRSQwAAAaAAAAAoZ1RSQwAAAaAAAAAo YlRSQwAAAaAAAAAod3RwdAAAAcgAAAAUY3BydAAAAdwAAAA8bWx1YwAAAAAAAAABAAAADGVuVVMA AABYAAAAHABzAFIARwBCAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABYWVogAAAAAAAAb6IAADj1AAAD kFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9wYXJhAAAAAAAEAAAAAmZm AADypwAADVkAABPQAAAKWwAAAAAAAAAAWFlaIAAAAAAAAPbWAAEAAAAA0y1tbHVjAAAAAAAAAAEA AAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAMCAgMC AgMDAwMEAwMEBQgFBQQEBQoHBwYIDAoMDAsKCwsNDhIQDQ4RDgsLEBYQERMUFRUVDA8XGBYUGBIU FRT/2wBDAQMEBAUEBQkFBQkUDQsNFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU FBQUFBQUFBQUFBQUFBT/wAARCAHFD/ADASIAAhEBAxEB/8QAHgAAAQMFAQEAAAAAAAAAAAAAAwIE BQABBgcICQr/xABNEAACAQMDAgUCBAUCBQMAAhMBAgMABBEFEiEGMQcIE0FRImEJFDJxFSNCgZFS oRYzYrHBJENy0RcYJeE0U4KS8WOiGSY1REXwg6Oy/8QAGgEBAQEBAQEBAAAAAAAAAAAAAAECAwQF Bv/EACsRAQEAAgICAgICAgICAwEAAAABAhEDIRIxIkEEEzJRI2FCcRQzJEOBUv/aAAwDAQACEQMR AD8A3GVG4ECrKfrOfiq9u2RVkbc/xX2Hz124AwtV3APvVBPqbPINKGOBx+9BY5WqMm4hR7+/tSpS CpzyR2q2zMSA4Vv+1FhaJtLDFW/Tgg80oNjCdz80ljg4I5FF0pg2KTGXcbGGVWlE7qsJDnA7UFjA wBA7+xqwjxgNkH3oiSfVgmlpKD6ikdvertkEcHikSOCR7GqDEn75pbICuPf5rQXDKHWrk4Hbv3oS SrC+3FEDbgP/ADU7FuapWNUQDnntVgMDPeqL5JYFj/elfq7Ultpzn2q4xj6f96CmGScikjIyPer4 JPfFURtU+5+aBuOTnsRRIzgNvOKsUyDkZpOEHJPNAQsNmSBzQVMZbnirluMZ7dqZyOBwTzQPXCsP pIzSiAsTHgkio1WYH3/vSvr9TG4kD4oG90djdsE02abLEA4BpxeblB3jJ+KZPjeARxQF3AcZyfml RSA54+rtnNN0IRgx/T/4qkbLMVOBngmmw4kk2kjHNCBLHJq2/LbquZOBjt7U2LoASd3seKJvCjkZ oDOH7EEDvigvPzgc0WDPKr4OCCaZTE72yMgUuWZj7Zx2xTYuW4xyalWGl8gSItjk9qfdKyMbzYDg 9+9RepzMMBjg+x+Ke9IEtqJPYDiuOfqtYxtrQp3WaNPdj81094WS+rorrjBRgP8AauXdLAbUImQ/ SoGa6j8LmU6K23GSwJ/xXzrOn08f/U89PMFpS3nj11OOUUyMc47nNQOj+Gk2uSekoyknG/GcVtDz E2Kjx31Vtm3cuePfnvWV+FXSr32oWttGx9P1F3AD2rnvTnhN5MLHkT1abpC810dTR2fpRmRYZIvb 4zWmNJ8JerdVnZNIsv4nIGMeI+Mke9d1eb/rj/gnw/07p/T7j07y8cRtGDjMQrTHgz1RP0jcW9xG 6gBhlW579zSdM5XfTQHVnhF4g9FxQSdRdPyafbScLOHyCfufahaf4b9U6osX5G0e6ZzhVTkmvTfr HQbDxn8ObuxkCyvIm+PYe0gHFa98uPQR0K5vFvbL0pNPJQSSj9X3FPKtYzpxS/l18QY7mKK50l7B 5cFN/wBW6pi58qPieY0dNH+j3YNjdXV3iH45wah4l2umadEtzZ6dJtknXlXb7GtjeLvjHL4Z9AWf UMFgl88+AIZGKgcfasedhZ1twJceXLxIsbaT1em5JWxlXR/01h134X9b6Lcrb3eh3Edyx3Ku0kkV 19oPnh1nXiAOmLKJWOMtMwz/AL1sDoDxAuuu+ubG/wBTtIIHI9KOOL6gn96k5O/bWEed+tdH9U9O TRSato9xYxTfpleM4o1n01rV3tjg02W7LnCCEZJH9q9WvFHpOy6w6I1awvbWO5DQsYgV5D44wa55 8rml2+hdRz6fPaJFdQREN6i5O7Pbmus5O3P9fn3HFMPTFx/EWsb6Gawuh2jljK1ni+VXxA1jpuXW NMsFuoO4jV+WWt8+b1fT8WdMVYY0X0VcsFwWOKz3y1dfxeu+nXMrJFKMqr/pz2q3Pa8eO9vOVd1t cz2F5GbSe1co8ZPKsO4o35qBDhgc471unzyeDKeGXiPa69a4Gm61MzFF7Bu5/wC9aOF3E8SGMbsj n7V0wy289nZ04WN0bhiwo1lb318hWOFnJ/pVc5qIDtHeIMFix4refhM0cdo0jopIbkEZJrVuoSNe wdFdQzxI0Onyl27BAc0CTpvqnTZmE+k3g2+5tmau1fBnqbSbjq63hktldB/qQY3Vu3xh8V7Lwptd Nkk02G7/ADpZVBUcY/8Az1j9jt4eMlrywutUmtnVLyG4tiTj+bEUH+9Ega7u5dtvAZC3Z/avS/Qr TojzF9OTx6toFms2DgBQHX/qGP8AzXOV/wCBsPRXifN0pDmfTpWV4HkH1KGqTOHh5OZJLXUYYSHt pXce0UZY/wC1NPzV1G3pS29wg7gvCQM16Y3HSnQvl46Sl1XVhHOoH/vqpZ2+wNYv0x4t+EnjDFea dcafY6WCv67lVRj/APHFPNfDrpwNFpev3kam30mZx7SRjIP9qG+n67HuM9ncwgf0i2bmu2ekuquj /DrrLUbOCUapo9u4EbKoZefg1vbozqfpDxGeUWOlxu0YBImgUVzue634bjyUuNQntBM15b3EeD9L PCQKRHe294iyQkrJj6sjFehXmJ8ZvCvw51C86Z1npf8AP6ksYcJb24IGRkV586vcWuoane6la2/5 S1uLgyQ22MbE+MV3xy3HmyvZa7FXLfVSY2Uk4AApzPZMLISjGz5Bpla2kk2QilmY8AV0+kh8m2NV ZWDH3A9qdxb/AEmcOAP3ptB0p1A+XWwZYz/pBJq8+iaxpkPqvo9+w/1PGdtY8tLq6P4bjbt3HJI+ e1S+n9W3WlQy28AJE6GMjPcGsPg1hJpvSlHpTgfoYEVLaLa3sl/DItuZEzkkciplWNW0WDQtRuIm aGEnJ9zjAoeo9Ma7DCJ5dIumVRkyIhZcfOa2/YmB7eKO4haNyBlSpH/iu1egjYX3gZNLHawkJZyg goCf0/euUz073jvj5PLyy1EXEW3B3A7c+9OU0e/mcGKxkm9yScUm30+5uOpdRkht39P82xVFXgDJ rdWmajbCOEXUIWTaB6bKRTz7254ceWTRdxDrWnRM01hcJATgyiAlf80H8yJoQEOd3Br1A0GLTNR8 B7krZQSxx2zL9UYyePmvLeeXbr2rsihI/wAy6hR2Az7VvHLyqZYeNPkcuqDIBFJaSSAHdjHsfirA hjnGPvTaUgg5cAZ7E12Z2eSzFINznJJxwMmnUCXfohrexZz2JPeh6TfqLiAC39WMOv1AfFdMaPfd JS9OKrWcb6y4H1beBXHLKR1wlrmO71I2ShruC4T/APxEL/mncEy3sKzqmxT+nJzkV6R/8F9Kav4D XFzc6PaThLJ2DtGA24L815iafNdGS5RIx6KyMVRedoyeKuOUyiZSy9JnLF/6f8UN3LA5bgdgOKZD U44ot05AcnAXnI/eirdQvGuPqbGcJzmus0xZRVYJ7ikSTesQH24HvigtqdqTtZGV/wDSQc0kyRKc 7WKt2p1tm76OWnW2Rmx/amP5phOfThEkh7ELnFLklWJ1Zh9Ldga294Pap0q0FyupxRJNj6C44/zX LPKY+3bDC1pO5vVAaS4jkhdOC/YZ/aiWU4u7ZZyoYqeSO+K9F/Cjovwi17pKWfVoNIupJC283rhG Vf8AIrzz6mSw0nxG1qPS3VtGju5kgCn6SueAPsKxhljTkwsFRoskgKMDIxTdYDuD5Uc5xTZZREhy Pp9ifekDUbeQ4LhcewzXfUeXxqR9Uop2lefjj+9ISUQjdhWYHkUyFxHIuYiDjvnihTMqFPUIw335 q9M6qQmuFdtwVVbGPtTd3bcCwjL+xVQMUwF3BI4RFfOcfUKKCzSMOAAP1Dt+1akxvpmyz2dkd2zz VKQrYY5FAinwTxnHzRJJF43cZrpHO+zuJoyApUYJ5FBuhFFcAx7APkMBQohLNcx21tEZriU7V287 a3N0B5VdQ6ykiNxDIzMAwCZ/zXLPPHHqu2Et9NPtMseM4k/vnFOInKwMmANwzkV1LrH4cWuy2ccm l63DHOwzidjhftXPPiV4N9WeE+tnReorBowGAivYQTDN91b3rnjy436TPDL3WORoucOoGe7A4NKk gjMi7ZyydgN3atj+HXlr6g8QTEkCtGJDgHnkVs/Vfw5OtPQH8O1uw3Y/TNIwFPLH+nSceenN+taP DoUtsyXUdy8yb2QHOw/GaiLr0pctIjBT/WhwftWR+I3hD1P4P9QDRupdPAlJxHdREtC/7E1P9D+X jqbxAlit7WN0WflcA8fvWbljWMZljdNZEWxP8uVs9jluRS1tUlcfUCTgfV3NdK334cniM1putL3S S2NwSaVg2fvXOnXPh91F4YdVS6D1NZNaX8XYx52EfIPuKTVdcpYyDSPC+TX9Jvb4XsdpHCMDfglm +BWBXtsuklobkkPGcCMjG771ubwy6F6l1+3MdnYvcxzONiODgmtm+JXko8Qtf0O1u7XT7P8APxL6 jCNvqI/04rNyxmWm8cMrN7cvaHpUep3Ntbw5jNwwHJz3+1H8WCIer7ayEheK1sxG4DdzWQ6F0hq/ Q3XSW/Vdm2htZozsLkbfVI7bfmtf9S6kmrdV6nfhQIpWOzPvXpsxywkryS3HK6RsNlCGIQLsb4H1 ftmnUYRCIycIB7UiCCVQZPpA9h70S5gjVEYsN/uPmpJjJXW3JVxDHdpsAT7seaHHp9rKAFRTtPci sl6Q8L9f6zu44dKsnkkk4HB5rPdV8nfizo9g80XTk12CMiONCW/xXOeDp877amW2hjHHB7cNS5dP t3TEjAE+xOc1a60LU9E1KbRNW0mfTNaXk29ypVh+2a2P0v5aeu+srAXukaLNexL/AFBTit/CVmY5 VraCwRZcqIowo4JUc/enSly4dgpZffHFbQn8o/iev1npa7Zl9gh/xWBdZdB9ZeHdxEnUvTt1pELj CS3CFVb+9WXHbHJhZO0O8cjyNIZcbuMHsKbDRFkYTzrHlezcc/2p0kRkXb3bGSDSEtWYMSMH7ntW tY724+eUHtVW2+hcBCMA/FDmRCgjLNvz+rPH7VUjRxiLe32/vTnT9D1DXrww2NrJPO3EcUak7j9q zl4/brx+d9GUulxuFR4lkJ7sMYokdiscWI2XA7BBistk8GfEe1tDPN0Vq35cDc0kUBOB81hsU5We a3eF4p4ztaKYYYEd+PmsS4Otxyg93bMY1AYg+59qjH0eMo3pzNIxOSrNx+2Km7SxvtXlENsjSh/p VEGTmpDUvCnrLS4xcT9K6wLdRu9ZICQR81neG2pc/ti8FuIgBKqqQMFUGBigz3JidY7bKZGMqcYo UWopJcSLNG8cmSu1wQVIq/oHadrZXuCPetTGUm9rpp66vKsGta9OtqATh2LBfgUO3hg0yV19YXUe NitjA2/FAmt0H0yLuye9G9FIEKAZ+3xV1qOnsNb+8gUyWl3NYvnG2NiCRSry41G+g23OoXtwpX6l eYkNSDIkh2bcze2felrY6lIB6UM9zFjn0ELMP7CsfHH26at7M7ezht0GSCe4yO370Rpt3bGPimMu plLhreZZYNp5WZSGNHVd6qwPDdsU+nGzVWkJJIzjFCI5bHNFfGM0LO0ZHv7VDagBjvj9qS4wCO4q gxLYokkeyPdnBo3iZTqrKSpwcU1dTsHJ4py7HPakmFScZx780dYi5ZXBOOfkU3kILjjOf+9OShMj E8AVf8iHdPrKBiAW+PvTSmyBiMY2il/l2QM74MfxT/XdH/g2pegLpbtNisJF7c1Ghssfq5rK7DnO BkcD2FIW2dyTkHAyaczQ7goHJqxT02K5wVGT96ISimMjIq24JI2RwTxS0lDqWIy3xSCvOW4FBYkH P+xoLBUGcZb5ogYHPt8Zofs2QP8ANTS7IwCh3e9UAvAFJDLIgGDn4pJbLcg5+1VFpk2nCZYd6ukz qn6Qf3q+d2cHjFDGEYcZT70WKVI5JE9T6VB5xTvW75Z7SOyt4lSCP6g4HLH70ycBc57EYpAQlRkn IopntTbhjtI7GnKbWjGVIA96u1uhJ3DNKIKxjZ9Ptz8UDVTuZgMClAJt+tsAnHNIlGDwMMPmlx4Z R6o3Httozo1lU8qOBRIT6WwsDknAFLS133IBIVT7mnGqQi0SJRIrMG9jRAZfrkB/qXvzQJJickID jsaXKQw57nvj3qojGqsrZwO1FXtLtoQZJE3g+9C1K6GolSzZIIKjPIoyW7XCBFJVPemc8KZZBjCH 6WHvV2FG1eViCccZpykdtgqB9Y96TI+Ej9Ibs8EGm8geJjuXA+DUDu8Yekv05x2IqPZnLcqUz+nN GhkkmuDAgDce5rNbboWLVOirrWEvgdYsiNmnezA96DCGJdT2PFFtSImGVGSOPvQYC5cG4jEJ3YK0 W4ji/O2x37YiwXIPse9BI27LLbSySPtEZ4B53U1s7WTVBN6K7tvIFbHuPBNtQ05ZumNctNRmki9R 7S6kw2fgCo7ozpLXun9RX+JaLdLCC3qmGPKjj/tSdjCF0a/uBiHTLiUe7BDxSHhntdQsLee3aBZ5 PSLTIV2/5rLbvxK1yOY2+l3xtk3sudgynNTd14mJrUdlaa7o9lq/ojbJcn6X/wDlx70GEdVdGT9I zW73N3BcR3eTGYmDcffHamybfSAxg4qQ68/4fuBEdFW4UbsskpJC/tUVpsZl3hjwFyc96Ggzncx7 tVTQA4AGc980e2hLOwK5AotyFI4GCPei6N7GJRMyuxxjt8UuVMlsHIXsKVJaM1mJQE+o4znvVo7W W9lVS3ohByR71mqSVZ42PvjsKSm0AKxCN/pNFeOe1kX09r54BpT2frTyXVwuNmNyj3qJ2QypIShk Axz3pvCBBMzAcDmnGoxWcyq9vGQr92oupy2n5PT7a0Aadc+pJ8/FVETcyo7M23kntSrQRBgW7qOB RW0+SQkONuexpNtbNPaPKpDKhxg9zV7FpJ1L5IBXPFWt3a2naVB9JHNWis2uHZM7So3EfajqhlQp kIMe9UIEgk3ux+o1dMOwJPOOBnvSNGvrdXVblD6ZJGD71e4EJ1N3jVo4R+ke1BW4q+5lEbe2KOZT LgvgEDGR70KW9WUsgjVgT+o9xVJk8AA0ClJPGOfmrowJYjv2pMgyu7OCO4FUrhsjOzb7n3oLsEEi RkZd/wBNGNssZ3Mckd6CYLp7cXMVu7oD9TY7U0uZ5I2G7I3DtQStskU8mC2PtTtNNS8cxers+GqA RGidSx27hwxp4RPazRyks9s3BI9qB9GLTThJHMTJIxxuPYCgS7F5ByM8c1lEnQNjfdLXGspq8Bli GTaM31n+1Yo8aRRlVOQoHf70Bco0XbDCreruMZx29s0FgfYZP2pWNu3I5oCtM2dwHLdx8U7R9oUg 5A70zIw4xyDRZhgbQ31Y7D3qBNxObhyowo75x2pvcXH5iIQxyHaDljggU5toTgl+B8/NLuBt2rHh UPfjvRdQy3hLcRMquh+RmiO2IkjXK4XAxRVVI22gcH59qNcQ4jU44x3qsg6Jr1109aXUln6rXPcF G2t/mti67rEHiT4Sw38Glqmp6e2bu4HLFffJ961fcRGOJ29TAP0kDuM963L4Wanpdv4Va/0+jRW9 5fgrE8p+lifcmtYzbGfWmi4w1zJbtEVBk5I+3tTu4UrOu/2GAAazbTPAbqWC1jlmkspYxkb4Zd21 fmovqzoqw6MtYXtNXt9VuZm2vHC+7Z81muk7YpLHuBLZ5PYUOPEZOWK/anrxeg31HODTMlfVXIPJ qQE/NsqggcfNPLWddQ/lWsLT3Sjc6gd8VGzL/MIA49gKc2WozaVOtxZTm3vO3qKMnH7VQzkEnrNJ KjRyM36WGMUporcSEzRK6kYJxTnUrme7cTXcvqSscliO9M58zbdqkD4rPprTPtD8Uo9P6CvelYdK /NLcKVSd2AEX3xWGW9tHBHHDnJVQCV45prFEHZskr8fenkSbGA24b5NW1nHHS725HAUn71aR2iYO N2V7Ee1EbU5LdWGzd7A0yTUklISSKTBPxUi04/Pm6Yq6EMe7+5pUaq2d3A+aTLdw2rbXtZbbPb1V IP8AahJ9QDJJvDcYFaSHNzdb7aZFAKoOCO9Zz034F9T9U9IDU9DC30kq7vRz9QFa5ki+lk5V37Gp rRuvupuiXH8H1q8tmUbTHEPpFGbP6bY6X8sXVukR22sa7py2umwMJpgOSdvNYF44+Ilv4hdXm8so nt7S1j/KqN2d/wBx8VkWj+OniFfaBqQudaTULQx7Cly2G5GDge9amt7cgn1hlmYvj7k5qbZmG/Z3 axGKOFRkkjAzUtcRwWUaCR/VkYgcDsaYM3CHOCO2PajLNuRlPfuM/NZdJ0JNE0Ev1EBiM4pDDaGw eT7UkN9QLfrPuauJMZz3HvRpZYSVyp4zjBNIhBtZjKNrEezDinB9WKFZZbSeK3Y4WdlwrH4BptJ9 Sgn9Oe3vRkjcis5cht3b7GrSI6LuH1P/AKav6UTuNvcdqVdwun85QQQMGthhJMxcIM7yc5Xgijw2 s85cPdzyfCyPkUFniWXcD9X9WfanFjMJZiM/cD5oI+7s5IwxJEhAxT3SNSvLK8jk02WTTZgmx3Vv pcfcU8uoRdxo9kuZD+sfFR7wT20habsOAwrPQyPo7U7XpHqS31a601NWSEsZYnGfVJ96x3qHqS31 rqW+vorUWlndT7lgUYEQ+AKcW9zLGrbD9gBT/VYoL2KEJpz27LFiSTbj1D/qq7EPNNaSshjPrFf0 5HApRkkQOofgjgH2o+gadpLm6l1S7uLUQf8AIWEcyH4NKvFgWVvTYlPvVEdb5Vf0ZbPJo00c0jZK EKe5HtRfTVQMN+1OhFLcrtjlGCOQeKAEVrBND3aQr7ZoTW4kOWG0DjAotysmmSLGq8MuWP3pKBsY IaMt/qFTQlukNdu+lru4e0uJYBKhV0DfSR+1QMsLTX88pbIkYuf3NPJZd+1QuCqbSR7/AHpFtBlg FyfmsjKdC6ysumelrm0i0ZptRkk9RL9ZMFD8EfH2rHbjULrqKQzXD/X7s3cmqlhJBB/yO1CkQsqh SMjsRQKVhEQpBOOM570W2dVw8hGd4OMe2abRFt+G5P3ozoADkZB7VsZF4kLo7TafeaJei5a4jX1l C42MKxa8AubYCUbCDgY96cRQxgAqASfc0K4VHP1H6vj4rMgFaYXUrOQg70YAA9iTU11BcajdajI1 9bx2sca7V2Jt3feoyzvVt9Qs5p1V1hbdsPuR2qf8R+vpOtprIQ2ENpHCoVnj/UxHtVSsYyBk5Jz7 1W6Itlm3Z7gmmmomRyBEQCvdQabyMkMEbDJb+o1WKXPKtu7OnBBpvGyxuH3ls9wfakTOJtjH6FJ9 6tIFikKMMYNaZOZEkkDOh2Ae9M2aQkep9TH3FHaYn4KqP0ihE+q/HHvQESZGVUVd1zuxgnHFElWe AOsyqDjsDnNNWhUksynd96uGUsAAT85oJHpzTLjWY5Eij+vP0qTgmo+6s5bO8NvcJ6citkg8Hiss 6OtGOq294Z/Rt7ZhIx/1faofrLW16j6tuLmKJdhOBs98e9SJvtOW+tp1Lp0fTen6SV1G5uF/9Y8u F2+4xWLatpcmla5PaXDATWzFGCnI496JZySJLGqZilD7llU4Kn5pc1pFFFNcySGV5HPqOTkk/NVS Lad3U9gM8AU5g1W+038xa2BQx3a7ZMrk4+3xUfbym2lcEHG36c1kvhlPZ6N1Jb6hqtpJf6fG++aK IZZQffFBC3Xp2NgWmWT1HxwDnFSlj0rqGu9PSXun2E4t4gWedhxityXvhZ0Z4mXlzrXTev7HJDfw RSMA/B+KzGTxn05vDKLoCHSLHp/qGW6/JF3wAq/6jSMXLTk3SJEIvBcsQY14DDuaawSFYUdG2nOA T3rZXi94UReFuvWtvFrKav68fqXDEjCMeePkZrXDo3qsXXnGR9qNSriC63SQQzYMvLAH9X70mHQr +QPhmIjP1/XwKoE2wEvp4nbjOe1PLfUikUkZ+recnNZU0jjvIHDxXBjYf1A80p2muo2SWTefmhSE zSswJUfAosNvK+cMNw5waBaz+jZC0CggnP7UkK8SZiZlfuGU4IND7sTj/wCmjRu0h2xKZHPYD3oE M9xcEPdTyzvnG6VyxA/ejSXU9vEyIimA/qk+KFJHPDLsmieIt33CmF1cMkZjAO3PY+9A7ikVnVo3 3n3FSUZbZ9QyD96irC2dn3RoU454rIIbM7BuGOPekgh7iZI8kqeeNlLuS0sYgkwgZQe/aj31uReR xRoXkb9I+TSl6Y1W5uMXNnLAp/qlGMimg1swjvtkP8texHvTzURNaaR6awhg7+orDuBTdNOlgmmj mG1I+F+9O9YnA/KJuG5Yew/7VrQhJ7iW5tFCHGzuBWS+FHXdn4f9RPrN3YLqMyRFIo3HCt/q/esZ eJcNhtm5hwfc/FFZBbth7Uhh3DjBqbGVdR9a33il1DNqOoOkDHiNRwFHsKxO5N1avKnoOVzw7IQP 81nvhVDoGpatPb30MWxIWdDKcfVjgise1TXNRvlmtZLtpYo3KqgUYxnjmqm+0TaXEv5ZlRyhcYdQ cZHwaR6Tc+5PBqwiwwPKgd8e9OYcejIwGeeKKSBBa4lMDvt993FLuNW/PSrsh9JCuChNNpvUYAE8 9zmrW8OcF2wamw5gj2qCF2AnnFFlkaRPTAAVe2aEkgjUKclc5zVmmEgbDciqEqux88UR5y67WA/c UzY+mN2fb9NLt8sODx3oLyghskAferlcBdtFaIMuTyfmgvIAcEHOKCpeODx+1ITaCq5yTzVbtuR3 J96WoyV+kEigWI1UoC3DHGDVTAWe5YydhfGadJbAOrlNwHPPtTaTbI8ik4yd2PvQIEjgE4wfvV7e JbiZVZSyyMFxmqEbTAKTz7U+tbaNFLAkSDkN8U0HOq6pNLHb2bwwJFan6GRArH9zTCOYsSG4/wDN KvUWWISeoZJSfqFN7cKHAfPyM1A6dTDCWRdzE4Ao93BAkMDIhEzDL89jV7h43t8+9AtrjMaqwLH5 q6EhaxKsIAP3INIu9jMVXge9JBKhS2U3cCm85O8ryrd+KkDiG3DDIcMBxikXUdwq4D5A9s9qqJW9 Nivt3q8SkJ6jEsQe3zV0p/FfvcQokkzS7BhQ/O0fAoUkW1wR2Hvig/TuEm0jd7UdWdVyXMi4/Saa QSORpVAPGe1LMWHAJ+odx81UaM+Me/8AtRRGoyTkt/qolq2wRsw/SP8Aal7hImxRlfY1aXPpFjyP 96vCQAPb7UQUoAi4OftVxIfpXGAKscMc4xik4yOe9GD2eZbiRMELsHYe9IWYK2GGKRbxliQowcdz VpI9jAsaoIZ9pwOfvVRTmO6d3zgjge1JUozAHnFOGjUBeAwPzUAUBOS+Tu7AVdsgsBwtJYMh4OPt VvqJ4zs+aCvTKEtzSvVVgCRjHt81QkUKVPGfmhyAk5x2poWClm2gYyO9EjXaOTkDtzVoSBJkjsO1 FQ4bcyZz7GgKd075B2fFEhtSGEhH8wcE1ZVXcGx39vincbL6g3DC0VYbk7LyT3p2iKG4G4kf4qyA 7eRgZ70RUKZI7E0Zo3pBQDzg/FLieT1FUSSLFnJUt9OfnHzSQxZgB7/NHK7lKkj96ISV2SyNndu+ aQpBzvXOe1WlJyE7igzSbNoQjcO+44og0bERMSQSDgDPtTG+iJgMkf1AcH7UWRo3bdGyuxHJU8UK O8KSPHtBXjJoJbp/oPVuoNHkvbO1E0KsV3s4Xn9qxudfRleEj05EJDL9xUqnUF9a2rW1tcvbw53F V4zUFem41G4GwO8o5YoOf3NGoDMS77FOG7E0CWEDaH5YdsVkup3lpe6Za21rYpbzRLtnuD+pzWPv tUk99vYmixWlaLe9Q6tb2NjEZ5pztIzjaPmpHqnpa66SvTp1wY2uV52jk/5pro+tXWg3SXFkds5P 6h8Vaa+fWLqe/uJS8qyctnPfuf7VQ2t7uTQ7u3vSEdo5VkaF+dwHtj71lMniN/ENVW/i0+3hbcWR RGFUZ+R71s3WfC7oLp3w7s9bi1m31nWLtNxi9TJQ1pO4kSV2JTG07Qq+9GUjdalJqd20siqCf6VG FH9qdxQoyLyM4zzUHGdwBBK/apK1yNpc5FQ0dpKsbkAbv2p1Dn08kkUzaIKpYUu3nWGL02O6VzwD 8UKciRkBGSBRfUjOdwJzzTeZGjb6eWPtSXuDGwzg8f4oi9wIWG9F2ke1AjLAsy8Mfaro3qDG3uc5 qmBWQNnJ9qAcoYg8Fn+KQQVXdJy/sT3FOhCZx6qttcd/vTOdTgkg/c1IKMrnDhckdhV7gwrGT6gZ zyRjsaGrOFyP0j3oRs/zQIB2ueR8CqKVZpFZ44zlRwQO9AsYb95JphHKMjBYIdtZV4N6fL1b1g/T 1xN+Xso4TcT3GOQB3H7VnPUnixZdGajNpGnaPb39jANobaCZKk9M3LVafSy9KX1AzBj+oDtUtZw+ lHLiYAkZGRU51R4iaH1hZwnS9IOlmLi4Ey7WL/8AT8isMnuWduDj3yO1V0iY06SO5vEguD6QBzuB 7ipK905dc1GK30+3Z3ztXaO5rGrZRLPEN31Huft71m3TniLZdCauJo4mnUx7PpGTmhEBeafJot/L Z3S7Z4sb1DZApJuFjdSGBAHAouv6zDqV80kUPEzGQuT9WTUI75X6gcjtQjILOISM0hPDd6JO6Lwa j7It+UGG2g03kknadtvIHfNFPXG4YAyKsFHc4B9qB6jNy2V+woTXDISR3PbNA+lt5NmV4ZqHCG9Q Dv8AJos7EmJQx3emDj2pvE5RzwuR7UDmQ7fsaYyzsq/T9Sk806nl3Rdl5/ppiQ6OwGArf4oCPHvI Xfkt9qDMqICo/Wvc0RTnhzgAYFNLgsD+nn3PzRqEMM87uR8U3lCvn1c7D7A80Qkuu4EBR3WhHjOe 33rFeiBQhYbdsBlOezHNIe92gYJAAzg0UjAUAcntQLqEyMGwST3IqtkPI+0NkbSe9GMmVJznPamc kTDaCKUHfZ9IBUcZomxjNuUA+1IabapYjcBVJGdrFh/aqZQVDDjPGD8URe2lLtydo9hTmKJQu51y fvVo7aLCyMSCOwqpZC7kY4PbFSkhMrFmBxgdv7VZFVSSpwp9qPsOwAEHjJzSksfzCEKQBVCLbE78 4BH/AGqds9EcWkdwn6G/qxUdHo4tk9Zm3Ox2bR8Vm3SV/E9l+RkUCLOC78YolY5+XMTfWfo/1UaO 3EgLckfNZpfeHkmovi01XT0hfuksuCBStV6Oj6XsYVFzDezt7wtnbTTMYnbqTIFI7dqeNhu4q7Is m3C4I7kU4W3wOMkferoBt3ezZXRmRzxuU803uZ29csfqPz805l3ZUAcfalx26qMt9VUMGX1hnbtz TOWBZH9wVqautsYBVeDTBo2UNLtBA54oBxwnH1YYftSWhQnkcd6crGUDHPDDOKDFEzXAXGBj3o1D N9MhmO993fP0nFEksEeLcBkj71ITxBF24GKZOSd20E596zprZtIVj5f60xwBTcR7jnkD2p+IiRkA Y7Zq0lswHP7gfFNIZRwGYuuMkD2pN0hjUDgA+1P0g9MiTsabXz+s5PAUfFNaEaxQrzzLmiLBiJmK 9xzStke/IByDwaMFwC2Qft80Ef6BKbc5Oe1J9Mq27bux7U7kBPAGM+1JeNggI/V8VOw0Ys4wwB+K pS4bJYfYUWWPdjeCP2oYgKNnuB7mq0XjaCR3pKSFeMZBPNXOEUdz+9Um08j37g0SryyDeqc/V71Z y6OdnHGDV5EDLlOGHbNIAdgRuy3zQqvWJHPYdhRo1GM47fNCEeP1nB9qXLI9ukYIDBuxXmilOAWL Y+r7UPce+eBRAfq+obWI7VZRnKgcUCkkyc57jmlyNiPAOQf9qts27Qfqz8UkKdrDHagEqsDujY/Y e1EkS6O5vUDFuNvxV0jwQw7ijLMcjjFQCSKSJSCFX5KjBNX2kpggDPvR94IJbkUIbI8EHI+KSaa2 UYyVUNmlLGxY8H4zVlZl7Hn7+1LEuQc96U2WlqGwGYkCn1jeQ2twgnjBA9xzmmgnQ5B703aRt5Kt tB/2qspS2ezN3LLNBuifP0g4oxslvl22irFg92NQ0xY26gDJHvQvzZjkX9RGPntWaJeDRL2WQ21u hurmU8IgzTmbp7U7eZYLiwltCR9ZKE/7020rqHUtIuBLY3TWk2OJAATWX9P+NOveo0Wr7Ly2U43s o3OKgxW801baQIjHtTZrXBXGQKyLqXqTS77UC9vB+VD98jAFQryk8EgA9jQAgVWDcYx2NKYMUKn9 RPDUtWBZUYBV96VhM4BwB2osCdMx4dsKOR+9BcFXGz6s9zRpZlQPwHYdlqX1HoHVdD06K4vWhVZQ HUxnP0ntmiIV7iRQFSMPnuaflovyUZdcvnlfihfws2ku5xxjg0K4G1uDn4o1Cwyl+P047fFDdQQC vcc0IA7O+CfYVeJj88jvn3on1smO9ntZpHikMaspBKnBFItJBbSBpbiSVn92OeacR2jXeZFVQo7g 0p4UjALIMLzhaLBZJ2ZMd/kZppc+qoVQW2D2ozqIrppRyHA49hQZrwpz6bGMdyB2qVVo0LR7W/7U qRIm27QVkXjPzVJcO4GMKp5yaUH/APUKWH8vHcd6oSI237mXB+9LGF5zwaKxBk+klh7ZFAwrOxH6 /igu7BVw3B71RAdVB5A96pUIOXIJPcfFVGMjLc49hQJgT6jlj9vtRjcg4AbLCqM8Sp9OFzwAe5oC wjJkKkA9zQFkj3rnPBFWW1EShnBZfY0WQyJACAPTBqvzAZAN3HxQWl2sBtGBj3oca/X9WB+1JkPq tw5IpIATAJJPzQGkdXKfAo6uCMqAv2HvTMDniiRORNgcCiQQyAEbh3qzfWv96SvKk47HFXIOCffH tRStmGXuFx2pDAK5IH00pPcls4+aQZsEhuxoCqwx9Qxj3oTSEx424GasJcDGMg0NZN3GCB96AyMD n2IpHqt+k9/mrFlCsMYPzVnwd2RnjOR7UBNwOSW2kDgfNItb8xud449s0Mg7EJGQ3Y0hofUUZ4x3 x7UGeaRqwutOZJxt28R//RTC5gYvh32c54o2hdXafY6M9o9gk87cLM/BH3phc6ikkZ4BPuAe1GfG i3LRCLdncRxUUyly3HBq0txvJGMZ9qsZAIwVzn3FZaDu1xFEvxz+1dteS+F/4aDt2r3z/iuJrmAy QwsG+p2AIrv/AMnWkCHpITFsfVtAP9q+T+Vf8kj18M6daaDA30ktway23ARe/wBPxWJ6PbNlQHOB WU28AON0mG9ue9e/hnTny+x5cEewqB6hH8uL43VNemyucncPiobXwzXEOD9Oc7fvXuxeDJB9VD09 DX2Vu9c6+ITn0pT3ODXQ/Xk3paSFPf4rmjr69HpyA8cV9TgfL/IrnnrqYsGz3rnrrBgJ5O+M/Nb5 67nVQ7Z79q566vuNs7n9RJ9qnN3t5eCfJDxEcUYMCOBQVjMUaHO7I7+wo64C9q+VX3Z6KLhgoxye wpYYhAqjjPYVSIGYAcnP+KIF2Spj6jnmiirEFIPfPcUh/wCY24nG3tSvWwW/xSRj4xmix6bg4X6g RS1XDZHI+9WbOBnmlA8YPIr6r5yxG0nnvSQpDYJGMUZeSQRwO2aTJgnAXkDIoBlchcnFX4Iyc5Bq 31EHIxmlEEjjg+9BQPIIOTVFt33+c1R+nBxz9qoDAJ9ia2LjAqwID7T3NUMHnNWOWB4/Y0WqICOC c4z3q5XLE54+KsGZRs3cY5qsHPappCvTVhgHke9C9Qgc8c45oncAkYxVpRwPY1QiSIsc9/2pRO4A e1LV2GTjmk/Uc5H7UBOAMexqyjCnJz8UhG5AIziitIF70CTHkAnuKsWEnbirscA8/wCKSuR3oFAA HvikM6KfqP01TPk81YEbskZHwaC3qKxznihyAHk96XJJiUptwQM4HakA7R80AGlUEjG6gs6uwxx9 6NcsAx4waayfQhPcn2qUXdwCecUu3ukXJJFR7SMWI/70OUFGwDx81RIdQzwlrb0ASCn1n71FIHJP ufvS0laQYY5x71diE/b5oBysHKr7djVl+B2FWIyxI5GO9KVTwfb3oFH6v0/4pSrhxk5HxSPVDLkD HxSVlxwOTQKdFGQPpzQ3VQoAPb3q5mLFccVT855rO2gsYyO5NN5JVgcBkxTiaUQfUH+n4xUbeah6 /GAfvQMdYnV5MgYFP+lpwLliOMnjNQV8xZSdv0ipLp6VVnQNkf8AiuWfpuVtfRXkaWFV5VzhiPau nfB2djYOje/Ncy9PjY0bhu+OK6W8InVYQoGSyE7q+bldPfhl/j05h80Omix8b5yB/wA+0WX/AHrP PAqD/wC2gdT9WVxWGecWc2fjPZy/OnJ/3qU8DdZePVbaT1BGNw3g1z1V47vJjvn4klbxR6XjTJX8 nnHtncaxDpC1lNqgIyxGa3B53uibjVbvRepYEaS0tYdjuo4AzWq/D6GW/v0giVs7VIH+rNS27efG XzdD+Busahb6ja2kQaRXAEqtyAnzWwvHXXNT6Z6CvZdHtd0koKSyRjlFx3qvD7R7bobpKbV9RxGY 4i8jkchBWPeE/ikniLqusWeoSerbXJZLaJgMFP8A81Hozm/Tnzwlt9PkvonmIfdcBpCx98811z1t 0r031V0ULXqAgaPGgZmD7Qv965X8TPCq98NPEP1bKGZdBuZN8LICQpJyQa3D4u2E995aNRaH1Rcw 24kTaTnPFYyjOOOsWPR+BXgcFLx6pMoHuL3GP/1ad9FaP07014g6da9O6m2paeGyXJztPxn3riTQ r3+W4u1m9ReDlyK6K8vmtJNr9lCkiHaf0g5NYx1I68U2636s19NE1jSGuH22krFXB7EntWttQ6Vk 6Z8XP4ooAs9TkDAr2yamPMG8tn0/YXqj6IZVyx9j7VkujwRdcdMaXcu5We3CkH5YV1k7MdTtzX5y 7aQ+Imgug5aEgH54rHPCm6W31uziGQqjDH4Oe9Zn52omttd6OmAwxDqX+cCtceFU7Pr9iF+rdgP+ 9bx+9pxTW20fP30bB1B4KWusHm400K0f/wCNgZrzv0+2l2TLtxs25z+1ejXn06qt+n/ASGxlXdJq G2NB91ANecFrqb30KO67dyjeo49q68by5a2d+oEvoEznJ/UPat4eHdkqQAW8gmYjPBrQDSuJNw+l R71uHwfuZBbiVS2GBzWcslkdG+DvT1yerLSSRfTQyhyPtW5/Mv4ca711YaAdDsjevZs/qIGA4IHz WivCfqi7t+rrKGT+YkjhUPwK3J5qvG7WfCPpPQ7/AEghGu3IdyM4wBXC5O+U1jKlfL/4Zav0o0t9 rEDWUix+mlsxz/fNJmax6m8xcLxFLiO0tgGZeQGA7VzFb+bbxA66tHshdRWMMibXeIAsQa2H5a+p IdM6qha6nMskxYM8jfUSamNjfHPKWoL8SHUZrfV+kbRZnS3lgkLRg8E7jzXJkSTJcQRoWxjAcHkf 3rs/8RDoXUeoND0LXrC1kuILFGSRo1ztBOcmuKLH+IXt5Zrb209wzDHpxIWJNdcLJvblvToXobpd R0wL8TkopAkHya6h8tkqI9yETvGv1fPNcv8AQ15cx9MXOlXET21yDuMMq7Xz+1dL+WqaSDesi43I FOfmuW3p4+8K5d87zzaX5g5phHuW4tY1X7/SK53cE+p6qHeO2e9dL+f+4/hHjVo94rAt+XBw3bO3 gVzLdam2pXb3LALPN+pB2r1Y3p4crNrXeouLVIVBWNecfNS3R+sfl7jeITKyHKjGcmsflkEQZ5Bx kLz2rcHhn0nbxxC7cq0hH6e4H3qZZdEjaXhR1daavf2sOs2H5e3yNzbcV0le+LXSmjxRadY9Iz65 axKB6y24K/7g5rA/APoTSup78C+gSWOP6iAP1VsrxP8AG7T/AAr1Sy0TTtFgvSFwy/pEZ9gK4V3s 60iOqPBvpLx06CuL+26Wi0TUY9zW2IhHJvHzgDNah8C/Ca36i6obRdRtwosWPqsgx2NdV+F/XkvX ukS3UmnLp4XgKhyD81rfwWgisvFvqm3yPU3My/tzWt7jj46ZJ1t1J0H4ZXVjpF1otpcXMigrH6Kl lX/USRWZx2OmXXRF4ujrHFZXFs7r6f6eVPFcneYW2vIPGdvzjN9cGYM9sZ9q6G8GbiW58M5A+dyx OoLfsa5+69Fx+G3PXhN4M2nU/WlzaXKbLUMZnZOCwz81vrrHUvD7oCW00i90izuLhlVNvpKZFX5J IrFfLe+/rHqHcdzICoz7DdWo/Gqe8i8aNRF8G9VkUR9/0+1J/S4T6dUS9P6PaeHGqLojZsLmBplw 2R29vivIu+QR9T6vGRhDey8fHJr1X8G5HufDC6ib6yqspBPtg15XdSqbfxE6kix9P5+XaPjk134/ bycnVWOBGzMT7gc1lnhx0SvUV9mSP1IkG7kZBFYTcS7IxC4znjPxW8fBudrbR3ERG9B+rHcV05On GXd6bv8ACHwd03rG8igFjAkUB+s7Pit29R9HeFfTMtvpWqx29teyKMCPh/347Ux8r1t/9p767Y/z HbO0VorxK1O81Hxd1eS83oUmPpRt7Ln/AGry5PXL3I64v+ldO0jwyv8ASdPBawFpIY9zbu6k5zXG Hgn4EWnWWtS2ojWFEZnllZchuT7V194eXIvvCSNi7SA28gy5z7Gofy8aLY2ei39zCFNwbhlZh3HJ 4qy601rxttYv1F4HeDPS1rDY9RRWtvdSgfUeHb/AOKwHxF8lfSUmgDqLoN5FlRfWMcr70kQd8ccV tXrjwa6X6r6ln1HUerBBeMSDC8qfQPgAtxWV9C2nTvh/pb2A6rtLy2Y5xc3EYx9v1VuWsWbaB8JP LF4deJ/SEkmr20rasjFJfy8nptGfnGK0fqvgLadBeIPUHT0sr3dnaMDA8ncqRkc/auhvCbqm30rx h1aOCZPyF5fSKrI30bc8EYrI/Mf0VHda9oup2ceyW6cRTyKOHyeM08mrO4wzw18mPQvUXR/8T1+K 5kuZdzK8cuxUUDIPasa8EPCnw56hvtV0/Udj29tK8aP6gVsKeMmt3+YDqKLwz8uWpQrdCC9kshbW +Dhmcj2rijwEaaV50unkE8ieoWDHPPes5dzs8vlp19/9iJ4UdWWssNo2oMrZDNb3uAOPfj/avOjV ehpdN691/pq0cNFaXjxQ7+TtB4/vXpz5aSp0G9IyG9U9zmuH4tNhfzC9VSzBdq3j8n2ya5zLS549 6S/hr5bY9VvLRbwSXN1LgRwqfpP9vaujY/I/4bRaRHL1OphnPJaKYRBT++OanPAFUfqS5bg7BtXI HArnLz/+KeunxKt+k4LyW0063iEw9JiuSe/bvXTdrjlrCCeNfk36K07Sfzvhvqk93qUbhpLZ5xIN vv7VG+DnlitusLwW9yDJeRqHlUnhagvLReak1xJ6d7LGZomVt7bt335rvTwV6Sh0TQzcnEl1KctK PesZZX0Yd9tPal5EPC42gk1e5uLS9kGNy3ARQfsK5m8xXku1jwb089RdM3r690/nMsQ+p4l+c11f 1r5euserer7zVLjWBNbSk7IzLt2j24ravRfSusaV0fcaH1G8WoWawMiOcEhcfpPzj5rrx5XaZ47l eO+nTy3kAlDiRTxtUYKmitJthw3Kg96VfGOw6v1y1hYLCL+5QIvbG7igXgKxRpu2/wDmvfvp8mS9 ts+XbpMav1NHcyKXjBJANejfgloaRQz323YV/kouMDFcE+V2/SK/Ct35Fei/hLdR3PTQVBtaOTD8 e+K+fyW3PT7HDP8AFtzpr/jr1Dqfibqtn6rW1rplyYUWIFVYKff5rdHiX0bp3jN4Rhr9UDRxfnI5 VX6lZATgH4OKx3oyDoCa96oXUzZfxhb2czfmXCsRnjbyM1l3QZf/AOrPU0OTbCKYQ591wax411uP TF/LPoyrosl+ybUT+XGPgjvWueoPMbrGreJ9xb2Tfk7DTpdi2zDmQA4Yk1uny77P/q+ZVxkXMmcV i3SPS3hxeprMupR2I1VJ39b15QjqcnG3kVzu5onST8dug7Dxj8JY7yWJPVt41vYmCgtkD9IPxTPy zaDHYaHLdiIKqqEDMMngc81lnR5/N+HuqwwZa2X1EgB5ymOMU38DSp6KuY1H1LLICPfNb92NSTxr TXUHmT1W58XdS0qGaK307SpwqLjHqj4PzWb+ZTwq0nxe8ObTXHgQ6jYotzFLEo3NkDKkjkgfFD6L 6I8OdUvdfudXt7D+LLeFXknn2SDjuBkf+a2H0JbRSeHd7bxn1bdWuEiLHOUH6auUrE7m2vvK50zb 22jyXn5dMr/LBA4U/tWPN5m7+88Rdb0ndFDZ6RdNAYgAHkwcZzWyvLmF/wCD7oLji5cZH7msH6H8 LOgtcl6q1fVfyz6xJqdwrSzTBGjIPcDP/fNc5LqN4amXYPnB8JLXxx8EbjUtO9CK/s4Dex3RQeoV VclQ1eaHhb4c3viddflbcFGRjukPODnFeuOkMr+BGrxq3qRppl4in5UI4FeZnlm8RNN8O+prya/I /LSMVP2+o810yzuMmnH9U87tsrVfw6evLbp6bVbLXbJ5EgacWzKDkAZ25rm3ozpq41zqaLS9QX0r iG49KaMfINeqV15qPDbT/Dua7uddhiJtnT8tG2+TJU8AV51+GWoWmseLd5qVuhNtc3heHcO6k963 M/iznj3Hof5bPDPTemNDF81pGPTT6JHXOMdzUIfN/b3fi5daBbCIaFZyenJOy/W5+RW3fC8KfDSL HvHKCf7GtNdEeWTpTXLHUdelvD/EZJmdpISD6RBJwRXmxt07ZWW6I85/g5YeIPRendY6bbwx6hpj C5e6RAJJYWxgE+9Zt5WtW9foyK2WL+XtDbx2BA7VPT2z634KatZzuXEUEsKu3dlQcH/auavLT5qu jvD7pnULDqO4NvJFO/pugDHAONtd8Zb2zbJ8T3xS87nWPQPWut6XH0281nY3DRI/5VjlR2Oa5f8A H7zVdReYrTrLSLzTrexsrSTe6hMOze2Piu+eg/M30F4v61JpkFlC0EpI9W6iXDZ+c1pXzl+UDR7X pu6686ItjYX9qQ89hAuYpUPd/tirjflpw5cb47cQdNdN6h1lrX8M05Wa7c7QuK2pqvkr8XentFn1 C10N76ARmZ1My7lUDJODz2oXlm6g0/prxAstRvgiI7Atu7dx716g6n4ldKTdKXlyeodLSFrKQ7Xv EH9PbBP+1bnLds48M1K8X+m7WTWb5Y5Yykwk9MxH2OcV6XeVbwG0jSumYNa1OyUzhQ6SMO2Bk1wX 4fR2ureJN9LCAbVrxmizxkZ716y+GCAeGVqqgcW7D/auXNlcrI7cU8JWuZPNv09N4mnpWyh/MWUT +jNeA/QT2yB8CtTed7yx6PrPTUXW/S+mrbXsUnq38tuQqPCezbfnJ71L9M+UG21C1vusH1qezvZz JNHb2yqUZcnhvjtW8OpZk1nwI1CNkJ2WIgYN7lcD/wAVx7jrJ00R5OPLvoq6JF1FqlqLucFTblhw PuR71tbUPM50ZD4lHoaay9WSKU201ywX0YmHGCuO1ZT4FBbTwl0xoIwXijdtg43EZ4rQkflJuesu p9d68XU5bDV7m/e4Swx/LJznGaxrKTyiyS3VYh59/Kdpt5oMniF0hpyW1/AA99BbKAkqcYYLjj3z Xn7p14l3ZAquCpyxHYf2r2y/MP1B4Lap+dVWl/hdzFIuOMpGw/8AFeI+j5totQiRQoaZ15/+R7V7 uPK2Tbz5Y6yP5F/MKrtwV+Pem8rhd5ZgWxxxRi5MI+oJgc5qy2p1B4kVss3x8V6MrqJj3RdB0WXX NTt7REYysw2be5zXq75VvL3pHRPQ0F9qWk20+oXigj8zEGKr8YIrnTyR+XePqPUl1zWIS9paFXXe vD88V19q3izZ33iXp/R2jssxt2U3Tr2Q+yrjvxXzvO8l29uU8J4xyX+KV0JoGgdK9G6xp+j2en3b 37xSyWsKpvXA4OAM964BiR1ih7hcZAr0p/FdTb4W9ITYyE1RsjHHIFebCLIkcKuwJA+fmvfhPjp8 /O9iPnbQT3xjt705kGFGR7U2bPqEe9XRCVBVsk0p2JXDc1fAH2qzZK49vmpXTE3CKcA9qHIrrggZ ozR5JUfHGaBKcIAPqce1HaACHDEuCMnkVdwY/wDqU0t5lUjd3I4qnYLGd65NQN5ozcW3A2svamVh bm5kCQhppd2CqqSafs6q8ed3JyAozxW0+gFTQdG6g1gwi3nNmRD6sYzn/UAaSJeo1XcWEkUhV1Kk fehfky65PJ9yaeSTNPNvL+o0h3sfuaW3bZj71Ks7iI/Jukp7ihSgjO7P7VNy7SECqCw7mmslt33D A+agjWjwNwwfigsmJCPbFPZLbDfK0DYWYBlxmjWiIoRMAqjDj70MwNExYHd805u7GW3VSCOecigK +1cHk+9DQTJsYke9AJx9I5yec05kAOeKbyACPKgljQJJyw5yKS7fApUK5cADNKnwvNAGVti8nmly em8tvBLOIRIwDSEfpXPJpvK+/ahOMnk/anGpwWszRBS0pCD6figmerbDovT2sJOlNXl1KZ0/9XFL k7X+RWNTvtlGBzniriBEnDKiRhfZRil3zrJIpAwce1TRtaVzJhdpY45IphMDC3IJIOfqp1DJOZ4o YgC8jBVYex+KyS88Mup5Ea5msmVAm4uy4FVPpjAbcA3fFBukDW7DkEHORVkt5EuCN20JkEfNOLWQ NuLqGX2GaIrUtfvdVtIoWhij2KEVolxkD5+aHqQBs7cJ9DIfqPzSp22g7fp+w9qG1qyhizlwRwPi gEzhGOCe2RVSvNKMkbh9zTZ5sKuOdpwaXvLRmRB9I55oFqWjKSJ9DjkmnP8AGLm2kZ45WCsMMVPJ /eg43xxuAdrDcAe4okUUeMsM570DQSyXM2cFznP71a+jMkezayfGOCKOtufzMm0hSq7l/f4pGsdQ XV1PBa29sPUUAOFHNA80C7n08D0byS3u14SYHtW0uj9X6muIPzmoa472iAg5fYDx8HvWFdM9NRST JProl0+1T6sbfqb9qmLzR9M8QdI1HUbnWf4XpOl5S0gTAaVh7kVZpKwrWJI/4tevZyAwyOSMfPvV oYikW5AVbOGIPJoOmQGWykkUF4ozy3wPk0/09hceoCQYlXcWqNrRqrylSOMc0q0j2XfAyjHBNXjl UyttXC471dJfqyOBii9LB8TyIDtZT/tVOh3ZP6fvVwn5nODtf59zSJVZCATk/NEXWAOoBY7AchR8 0p5GwVGB/wCaszBRikKuRnj7CsC/qEOCv/5qtNMRE8eTsfvk8/5qwO5h7YpEqEkewFA/1C6ibR7e KGExiLhmPvVWNtZSW59WRYpChMbZ4z7UP+JPa6Xd2YskvGuk2JITzE3yKgksZkgW3vIsogyDnnNB lOq9L2+mdKW+strcU9zI2x7Ud81CpdqI0CgLnnj2qMkRCMOCCvb6sj/FHnULYCU5wv8Ap962yNNs ki3x7kI7tnuKtsEkA+sgfFMxKz2L7UO9mCqPtUrbW38mPK/UFxigYZEzBHTYU5U/NEkvpJ503Jwv GBS9QgaEbhwc+9NEZmk3DJAHNA6jVGjLBcKOWNLit52iDqVSJjkA9zSYbxHjeALtBHeqkJlRFViq oMfvQOLUhJ23Yd8YK02uYyjbGzuq+RbzCcjJ9sHtSnL3EpdhlsZoHcGq3cFi9nFJtjbGc1FsUuLo QyMTJnvT25KLZh9/1jstRsbeofUYbZB/VQbL8PbLosS3cfUt2yuI8xLzjNY/qutW0t/qcFjGrWAb bC3wKx64uDLGiMA7jsw701LgjbHGYscsc0TR7DDJlgrcEe570Zn3OUxkgDNN7MDcrGQqRVpTI91I qH1UP+nvRTs3S9lH1fajW4LNgjOR3NRtrbk+oBwEOGDe1P4LhV2hMnPAPxQFm9K2ULHJvum7/arJ cGEY4LjkkigvGQSHwzZ+lvcVQO1cd2Pcms7B5bt52YEgZ9h7UkuXjCf1Chq2XPHalOyqpYA5ptdi RS4bO3Oe+aU0xC7ew+Kbx5DDmrMheXG7vzTaE3EBZGzjY3ehSX7x2gijyqK+CRTz8uCGUvx7g+1M hEWRoQ38sNuH2psGj126AeGLU72FCMYEv0/tVaVpTSzQQW7RSXUjYBPGTTSK0Hq4l+lO4Ios1tCJ FKbgykEODg0PR3eaVf2upTWl6ix3anAVSCDUW0RW52Pw/bHxTkl5JxM0xLjgEnOPvV1j9FJGP1ys f1n3p2EJF6YMmN2Pam7KCGO0bvYijvJwV27c9+aZ7gJtoBOfetBcrEtGzche9EnVQqSK+FNTfSGh af1Lqk1hf6gNOQJuWUe5+KgpkxqtzZNIGtIXKJIPfHvUq7FhKOWLsFHfJ+as8wZhiT9sU0k53xSE so4DDtU3090Lr+uyxRJZzW0cn6JnT6MfOfipWdo4MWXDDOD8VSzFEXZhZQ+8FhkHHtUh1b0xrnQ+ sWun6nFGwuVLRSIc7l+aZvaTibLoVQdjjiqssrZvXPir0n1x4QQ6bNpKWfV9qyj1VXAkUe9aetkj mRMBov8AoBx/ep3obpTT+o+sYLDWr9NI0qQEvdvgBD+5omv6Zpmm9R3ljp18uoWto5SK6U8OB2qb DV0WOFFALv3Bb2oc+5mBU4du5HFGZy0SjIYr8U3MjbiNpbI4CimwqxTYxVshHOOPen1zZrFPsYbJ MZwfik24Nu6uRtdcFQRR7+6W9n9Rx/PxgLUDOaeJINhA35qwvrCYqYw28j3pEkcc6kyfRg4IpbpG fTXb2HGBQESNZQWQ8D2NWOImxu5PFCCBJ8qx247U4LZVtowR7mi7SOjapc61Gui61qkNhpUL77d2 TID+wqLuBELya3guFuAp4kXgP+wpLWQvv5ckwVe/ah2Wlq+pRwQsqPvVPVc8DJxViFRtDFGyvFJ6 hO4v7CjWU6fxi2iv4pJ9OYfXHE21m+MGp7xB6aPR95DAdQg1SOWLf6kDA7T8HFYoL64F5ZyRwhvT kXgcjv71oE6mtbOzvSLGCWCHGVhlOWH70DQXk1O8a3tbCZpo1yQiliR/an3XF9LedYyzTRemrFF2 jgAYqd6K8Rb7wz6ni1fQ44ZnC7JoJ0DBhj5NYTtjrytZ3z2zl7SQqW2yKQc+1M7SSbbKk0onQnOB 7VIa1rV31h1xc6prDJNNdEyFUAVU+MYo0ZsdJsLi3RN887bhIedo+K10qN9ThSowBUlNLM1vDJJO 5XHALe1R8iI4K7hg/BofpzYCbw0Ptk9qaBJWiZY3Rw5J5THK/fNDkyxODkmlCFkXdt47cUsBew7f JqhtPBcLbeqfpB4X4NS6Cwl6eCrKY9QJBB+1W1Wa0v8ARrS1jUpPA5diP6gfamTRRLCiqMfH2rOx ae5kunQy91UD98UW6U3UahGf5z3PFB/L+ptxkfejQyXum3KvGygYwPetBMR9X9SmIr9PI704Rip3 LgDGDSJXknf1JW3M3wMYpbLsUlyVUVgKll2xhfY96JofT95q9zLb20fqyBd4G4Lgf3puy5HJzn5q 8Fw9hLkyOd2BlTgigVJDsYqwxsJGfmqkUMvA7U8uLC4ubqzt4mX1blwiZ7bj96Pr+kT9N338Pvtk d3GMsVOVP96uxHQghCwA49qaztGrkP8AqPIxTxpYZ/pjBi2fqdRnNDgvLOIufSaZ/d3HJqyhpbxQ XV4RLkoMZI4p1PDpdtqEbszy2IGXVTyfsPimUt+spYRgoP2ximkjO8O0Hue9VKPeT6a160tjBLHB /SsjZNMLshomUDaTVGJgOW3H5qypkfWP7mjFAjE0htyIvUEZy39qtqEsl7Ol2sJ2Dhox8UqVJLR/ Vil254IqY6c1+20a7W5nskvwVwYnOAasZSnQfh5e+IlrdXOnzRQSWuW/LuMmTjNYtexy2F+0dzF+ XuVYo8RP6cVN6frerWNzd3uiXL6UjOXPpjhAfasakSe7v5JrqYzyO25pD7mpuqLcDf3JJ+1Nwzeq GX9PvmpO5tvStQ6+xxmmAUMAD2artDlJZ5gRbMwQD6gDxim312/1xgKfmpq0ks9M0aaNlJu5htWQ f0VEvAYXWNnMwxkn71AuOR3k9QkZPsKtcZa2aIAgOcnPzV4osKHzgf6RRQ6yNhgV/cYrWwGGQTMR saXA4xWwulddsfDHp+71G5aO91m+i9KG1dcqi/NYDpcws7uRwDgqRg07jvdOuYJV1C4kScDESou4 H9/ioJTpbxG1Doq8OraGltb3MrFn9RN3J+Kx/XNQ1HqPVbrVb+cPe3MvqMynGG+3wKYR2ojXIIcZ +acPFCoRlypzyAc5oxJoi/nuby9i/MXU9w+BlpnLftikus7zg7+CKeX1uhdQjMSFzwKtZWMl6UVC UV22LMwwob4J9qrZs24AlzuoaAgq2eSecU6ubWS2d4pWSSRDhmQ5FOdI0mXVJ1jjkgQkZ/mvtrIb hVI5bA+wowKZAyVf2pF/E1hJJGzK7g4yvIoFkjyxjH8yVc0B5o1DKS22m0cz2jeopK8/SV4pxJH6 4w2QQf8AemxVYwgc4APvWtB82qXE1gbWd9+6X1fUblh9s/FM7hopwsJH1Kc+oPeluiiXaDkY4oVz Gxg/lruI7n3qdDZXhp4T6113K35KeKG0iX6p2wfq+MUz6r0LqDovXpdN1CzJhRcpOI+GH71ivT/V Wu9GxNc6Rqk1kznLxrzz81sLQ/MTq1+9tH1Dbxa7bocSeqoDYqrtrJtSmstYiv0+swSAgHsP3FSr dc6guoG4eZp/Wk3NHIchf2HtQus7uw1PqO8vdMtxZ2dy2VtxyBUCsLb1Zl5U8VKjYvW6x6r0bo1/ CI455txl2d+Kwa5huYLWO6khIhlbZHI3ufigXV3cehsadvSB+lD2X9qdXnUrXfTUGmSgM8FwZhJ7 sMYxTaQ46a1T+G6pHLLaxzBclfVXIBFPLy7bqXWAPyxe+u5cJEnZj8CsdR5pbcMVZkJ/UBTqK8ut JltruzYi6glDxSKM7TUUXUrC60LqeS3uYja3EYw8fxVXEu1GkGFBpOqahfa3qst/qc7Xd7KMtIww aZyXKGOQSKeeN33q7BBFIbczBtw+xpe6T8rCy5RzwQwxWbq/S6eGTPa2t1/GAdq3LIfTZvdfisJN 1c3np/mFChQNpAxTYVbw+szEnBHt807ED2qerIgGey9800gk9cPhShB79qTa3xuL1UWOe4CjiGJd zH+1IDTzAxey54xTOJljvJlk5QgY2jJpNzcF70FUMfOShHK1mnhN1V0/0L4o6NrnUFidX0WFiZrY jJJ/b3pVjFJolN0ssYMg9PB3LjH9jQ7MYIYDj3+1ZH4xdZWXWniHqer6NatYaVcS5gh2bcL+1Y3b OAu0/v8AvSlO1O4MBwPamzIWk4GaLuzkYoIlw5IOQKbQWO2Z224y1ONP0i5vvXMSfy4xkvntTZbh 1IwCfmrwazd2vqW8IxG/BJpsOYLiZbc/WCucHI5pocF2Y9844qTjvrCOGDu55Lqfmm93dwzDMcHp knuKbAVIQDHejJKY4+Gyc9jTfawPHJNGwZVwi5YfqpsFRIxuwOWHekiFee/70OVnX9K8UW1Ej8N7 9qgtLGRGBu4PeiWcKICS27B96LcJlFJGdvtVRL9JI7VoHkCvgBs/vR9G0qPV9S9GW4FpGVLes3Iy OwpizsuCRxiqDM8ZCMQe+aBy0RgkK7cZJyB70mYF4zGBj70oTs6qMlif6qNE4Q7AM47miU2a4b6E K9uKd2cW8bmBwD2oTxAgOTyD2FO0uCsIwMUNgghZCckHPankUheIrgY75pmqmUdsZPc0df5UwUHP sT7UZKabbGSo3ID3IpKSeo+4DkDmllw8Dxjgsckir2yKxwOCO/3oyXnAPFW78nINHkhKKSe1BB3g cUBLa8e0k3BQ6nvV5JWmcyEfq9vigbtqnPIHtSxjAPz7fFBcOR7An3xREdiyZP8AakBeeKokqeDQ KeKQzn6sRjnFWxKxzEwVR3BpDvu3ZJOKpHZXG3lCCD/egcLYzvAZgA8ffOOwoLMCO/t3olvfzJEk CHbHjA/+ihNE0bfqGPigVDiMqW5PbNSH5fJBPC01hG2McAkU4guAq/V9We2aBZyGAHt80uBG3/U2 7nsataf+oY7lKYp0qD1MA8CiUUMI1Uu309gKPGjh+f0+wq1psUZkUuP9JHaihRKCQCuDxniiFja6 ZYEP8Cl7hHb7eNxPc0NV2t3xj3qlgZyoAZyewFEJduEYMODzmpPo6x07X+v9Nsr1XfTpSN+xtvP3 Px9qibu32MA2c55HxSF/lOrwkoyHK4OD/moMo8TtK03p/ry+s7SNbW3ijBQdwawzp7Xv4RrDXESR 3DjIEcqbkOftTq49bX72Nr24MhB2tKx5Aqd6l1LRdN0aKw0nToo704Ml4Gy1UY3rV62oXks7RLE0 n9KDCj9hVunuqz0lqouhZC8eUbdrDIFBuAXgWRm3OT2+KdaX0/daxaT3EKrsgIyx9s0ah3rPWMWv yuY9Nj004ySR9JNYjdf8zjlPfipK+0qeycrIy4x2BqNumZBt9veiwEMFZlGQhHz2p/bNG8XoQqIw R9RPvUbAsk2dh5B7Ut1aE/U2AfYUBtNxp0s6MfpT/V2/tU50T05qHinrT6bpjJaLAvqSzMO6/FY9 NeoQqmP6TwzH3p50v1XqPSjXUmmSmCSUFCwHdfiglLvTTouoyW8zLJ6LlCy9jg4ohkWUFosKM9qi LaSa4X1nJbJLNn5NO4QYl3E/qNA+gDFiHfj7VZ7hbZgqpukY8uR+kUCOXYRnsaObxUUpsLHHJxRN HzNhgVO7gdqSY0Zyu3BPOaFFIViBX3+1ESSRmAP0496M6ICFSRnNU6kkHNFZC7FicUkIQPqzzQUr gkBeBj/NNJz/ADCmeT7U59H6geaRDbm5vNpO1Ae54oBLbyrHuA+ge1NEVnlmVSQ8gwoHtU5qk0cc YSGP+WF7g0z0qNYphcE5buPtUgz3w20616B0u81bUJhLqd1btDHF7hTWtb4TahrEs3qekM8AU+6i 1bUtQkjKkHZxx8VHrHLcOGckZ74q7/pNbIbbLI5fDbFwM980EtsVd3uO1OpY1hRm25f4prIdxVtu B/5o0kLGaJICdn80nhvgUKZAbj1EjAYcDA4pqXKAYzinMN8fT9MrhT8jtQVlkGWwCTxn2ocjmcNs 9qqeQbBgfT7g0OEYDc4BHH2oCx3ZFqYwT9PvVhcsXiDP+oZyPemqJ6aN3bPfirq4Ai+lwAOMijSV WX6lA7H3obZY8YO2mZmKy5DEL8EUm5mKTbV7CibStpOJQxD/AFjjJ9vtS1B4ORkdyRmouB2JGCAe 5HzT03zxAuq4PxiiitOpn2gHOOMjikTBlcKcKTSV1KS5RVkAGPtikzOWkBByR2oL4b3IPNJmw/BP f471RkLbcL/ikMMzAMcD/VRQzpslwsjW6M4i/Ww7CmnptGPqPf2NZbF1Ja6foNxp8dsiySOHedTl jj2rGL2f15N+0KtZ064U13lmIB7cftRfyzSgkOf2pAiZFDFf/u1b1ZUyQuftR12q5gZIEywbOePi moGxG9lUYx/5pzJKI0BKkuzcg1S24Quqgnc27J/7UDZX5ByT+9LBDAA8Y9qKsOGx7CkBGRWU8hzQ 2uJSDwRj70W3jMobbw3saVbWTOwPYD5qRhCxf0ZI7kVKmzRLOSKMox/WOW+KcwxLbgLGd6Hu1Hdl nYjBH2pMMRVSij6e9VPJcZkP05JFFMzSKV3FMjBxTm0jUHc/cewp2kMe7OwUkY2Z2cKwYY73btuJ yayCyuvVhKfUOMU3gtwB9QxnmnSlY/pA/vWki6Wqg5Dk/bNHAOD803jyjZPY08ziMH/ejYJiKOc+ wpIjJU0SUkfciibguSTziga+l9ZJ5JFIWAENjOD3pwSDSZD9Qx9K4oG0qDOAOwFBVVVg3JJp1sBz kbs1ZtivyBijUM5EYyFiCAvsaB6bMwIXCH+mpFnDgjvzSoVQ/Sf1e1FRgi2y/UCox+mjtcOxRUiD HHfFGuocnC9z3FIiWVX542nigbvCRywwp7io6ePIc7Mr3xU9NaLNlixGfambQRJuVxwe1TSRCAj0 FCrwecZ5FDC+oThhk08NnGs7CNdqseee9KFokQ3Ac/eppNmTwyBR3yKbESxygsefipYhdnBx9qaS wD9QHNGgBGXySN2TVOAHC+wpUqm3UHdnPtST9ZGTyPijRJUMchuBQJohGq7G355JohQqwxnBpUsS gcZNTsBjb3HerbeDtODS1TYwXO4mljIB9vepsCk3CMZILfcVYvgKe5x2HtRlw4AxzVKoywPBrSQO MEDcxwfalR3DM+BHmrOmzgE//RVLIy4J+omiio31gY70o8djjPzQ14JK8MfY1dQCfq96BRBJwOKs Qd5JxtA4pY24I9vmhqMcHtQXxhex/aqCDIJwPtSi24jjirKqyYH+9AogbiD9P3qzx/SQrZP2qRs9 PW5voImlRdxA5PYVket9JWOg7Uju47lnG4lWBx9hWaMJ+pCARkj3okbhkJI5JwBR54V9XbFlo/vQ jGyOFPBHvjtVgKihWww4+KROiFThefahLvjY7pC/3NFjLzFgygKDwRROlLBkDknA70ORTENuSyns wPApwdojO4k/+apERFwM49s9qaVVppCa8y2014toSf8A74kGQKmZ+m4dEURxakuoqBzIoxUNtWZx 9G0KP80Jr+WIFANqA8fesiSjkB38DtxkU1kZmXvtNJjknxllKg+5FEMaS5VmC/8AUTRUroeqm2Vr ZIoJPUH6pFyw/Y1e4u5yXhurmWQv+lXbKjHbFQroUIWBv5g5DA1eadhbpGzerODy3uKJo9a/kmjU SSA4HtQPXLnnHfANMRPiIqc8ndvpwoWQKZCQg54o19CyEqueM/OKDuzzu59xThW9cYQFT2HFMtkj XKxoSHB5GKIcLghdsjMPcD3oyXQV8AfYg/FbQ6Y8t/WfVPTkWtWkMFvaFSxVm5Kj+9YtrPRq6DPm 4/m7foZfvV0krG5JwWIIAB7YoXqZJXJII/T7Gpq8tIDbtPHF6SLxg1E2QQiQMN/wfipY2Q7KEHGA KKqKSqq3JGcYpxphs7SbdNGbhSc7WpU+qWk9yI40EBbgD4oGTZU5JIYGlHb7cH/VTae8VLhoyc7T jPzUhD09q81qtytnKloOTKV4I+1EqPmmSNGZcs49vmjEhmiZSfTYfUoq9ym1cgDg1aO2LtweQM4F CMm0q56UtbT0rqKRr9j9MjNkA0x1xYg2IdoU84FY9MR6YSZTu3fTgZIpMssskmSXKqMbh2FE2cS3 QRdjZKH2FJKlyNowKTGMk7vq+KOxGBhc54NXSBRox5GP7URmDKFH66KIVCExvjNIaIRA8nkVBQfE ecVdGEP8zuDxiqELH37+1JKAdz29qNk+si5wTiqeUKRk80iaMYDf4FWXttbByMg1rQXuJJwOKQ6M eScL8UpH+g7+/tS+CVIyQaaCf0gcfarx5OARx7VZiQRwcZqi3pfSDkHsaqQdINo/mc57VTqAr4OS 1B9RgfqbI9s0kznAzyfiptVBGVVDPwOw+Kujb3K7goPv81SuZAB3NKFqZI8H6cHINZAsibIUkbfe ixoxUZOD/wB6v/MdwGAUDjgd6PKhWMAd6BKp9PP+aVkqMAHHzV1IIxilTsBHjFF2AWaS4iAIGCMi vSbyp6UkPh/Zy78lm7fbjmvNyEo1/bLjGP1GvUTy3aWlr0Dp2M/XCrY+BxXx/wArDfLK9vDPi3xp mEiJDZYMP8VlKRxM3qAZHYfasa0iJVIYD9qySFsL2yPYV9Hh9PLy27KkCqOO9Y7rTE38OPYcisik wOQMGsa1Eb9YRd32xXtxeHO6Yv4gTFLdVPORxXNPiLMHSce32rojxHuMgYOAhI5rmnxBdtku05xy a+vwenxue7c9dczcPke3+K0J1Eyl29zmt3dcvvSQ57HOK0T1AC820cMT/evPy5aY/Hm6aREGMDkj 4zxR1lBZQD9PvQEXCcjPFFhISRVKncf6vavmvuwdRgMqnDZ4NE5jVdx+r/vSQCMg9896ojCBSNx7 g0VRBwOODTlwCBtG6hbeB8nj9qpQYkbkmg9OyT7VYHPHOKortz+9XUhcke9fVfPUzYBwxyfmqUMR kk8dquQME9qpT9Ix/igrv3Jq5Gc5q2eaoYzjFBXKEdyKsEOe/wDalAgDmg3TNHGhUZzwTWoFAnJ4 GfilhA6LyST3Ge1XiUswLD2qpLWKXdkneexBqbFK0ZJjUEyD3PvVZxwM5q0NsYiST24FUI2GWJ5r QosSnI70gYIB5NLcjcAcnjvVKSi0Fgp+nvj3NWLcfOKWGLZz2NWZC36BigSwOcjiqCk/errxnNKy eNox9zQJCkY96qTgdj3q+eD/AP2aGCXc45HxQXZgwXA79zSZFD/SGxz3pYXHfj7UMpgHnk0TRJ+g Y3ZNBdsDGc/tSiSG55HzSG+SuRmhAnJZueMe5oLMDwe/zTib6CeM4po+C31HH3qKHIgPPuKQykk8 ZJpeRj6TVyQi5yFNUMZQVBQA96szFmIUfSe9FYFnB70hW9Mso5oQmNdowvIq5TdJhSQtK4J+ngVR baOeaLtWA/AGAvaghSpPcZpbssijOQR8VYttPfNTtDd3KnhScdqps8cE05KypIoKja3agzTCI4K5 I7gVNNQG4id4jkZ/aoaTdbs2V3Z7VNNdCUEKpqNvJWj5GFJ+RUUwuZVVdyrlvfIq+hSo+qxqSSCO RTXUZZXgZSAM/wBQomhSJDqEbFee2axn6G59EZWWMD2OB+1dJeETrkRjuIzXMeisSqgHBYAiukPB 24U3CdyyxbTXy849eEunPPnbnhtfFnRGnkWFHtFX1G7dzWv+lPEKw0DU4I5LgKpb9YPBrJvxMYJI dW6Wul+kP/Lz89647fqe601I0jkxgZ3MM4rc1rSYckx5dPWQpY+M/g/daUl3ATNCY95OSmBnP71w 70N4523hD1veWeqWh1GLT5TCXjYZwDgVonS/GHrDRN0+gdSz2bsCjZzsIP2rHrGBJJbu7vZGvLy5 cySSSSEb2J5Nc/Ht6fVddeNnn5g8RdE/4f6b0u50u2Y4uJ5T+pfcD7VjHhX5mbfw/vreWWJp1GAQ pwQK52CFD9PphD/TxxSxbokLPsAXscHvV8TenoVr/nu8OOpNGjsrq0naY4YCTBCsPesn0rzn+F0v TqWd5c712bJLd1yGrzJjgtonZ1VQzc427qcWlpNdsyIok3f6owB/msWVZNzt6JXHmk8CkDZ0Szce +LdOf9qwPqvzZ+F0GuaTP010/JAYJt9xJaqI96fHFcYNpbw3Rt7sxK4GcACnNtp0UYZWCtE3+kVJ gxvV6dp+MPnc6S676PbQ9Ktbm3uJGRxPORtXb3HFSfgp5yem9B042GuTt6QGVmj7A1yD014X6Nr+ nXl1/GU09oELCJ8fUaweRRukiWVWCMU4XuPmrJ2s9artLzLePPTHi9c9PWvT0klw9hI7ySntyBxW XeWzo99T1mC9lg/kQkOTjg1wDZdU3OgsIYrcBfnHNbA0LzS+IvQGjSW2iX8cSOMfUuStLLPS4WS1 u38SfxQTWuodF6IsIvUmsG/MyMpyDuxxXIkDSrIiuoC4+rHsab6x1FqvV+tXGva1dvdahKfrnb3p KKVmLiTcCOMmunHb9vPnN3o4lu1WX+ZkxZ5Wtg9A+IVnpMixunpRhSuSe1a2uBlVAPc04s7KKcSe o2No7ZxWrNpjt0t4ceLOj6Lr9tcXl7GY0l3Bx/SKz3zo+P8A4f8AiD4WabpOhaxHe6sjqREneP5z XFllFAAwcEc4yDVfw7T4p3ERDseSSOa89wu3bK+WPinen+oL3p5o5rUhjj+rttreXh14taO99DNM HhuYwCGBwN1c8BiyBUJKqMHAobxSnd6RKt9jit+GoYW4vUzozzG9HdR6CNI6rvrO1ikj9I/mG+mQ YxzUfpN55f8Aw21V9at9d01blcuqtJvA/wDiMV5gywz3EaiWeRlHsXP0/tTe5sQd2JXkBGNrnOaz cb/Re3ovpXiB0T4q+IM2oqbayspHCo+QDIPmt/dN2vRPTO2ey1aBFU7stOMf4rx0iWWO2UxzzxyB gEEblQo/tTz+Laio9FtSvCMY/wCe3NdccenTGzWtvTLzA9BeC3i/sveq+ooba6tYztmtrkKRj5GO a83eutJ6f6Y61uLXpvUn1XR0J9K4Y5JH71j+oWFzsX83c3Fwrc5aU/4q6W9raWyGJc57g+1ak08e U+e0lczRzaeUb6mkOeKz3wx8RbTQZJLbVHZYj9AYmtaNIBGoVNq+xpusuJGEqn0yMbiO1TLHcdNv Q7wU8UND6U1GGdJTPbTAAlHHGRW8utug+iPFaay1O51OGGWFMq8EyqT/APLnmvIyHVtQhTbZXsqR JyqgmlLr+q3KkxXt9GoPKrcsAf8AeuNldrlL29itD696E6Zt10W117T4mtVAceoBn7k/Nc8aN4r6 J075gtdutP1CK+sHKrvibgg/qwa89pIr64UlrmfceWb1zuP96NYX13YEpbzyWxPdtxJP96sxrO5t 659Y+HvTHjPFp+sreItwiALKsgyF77SKyfRZ+nukunX0tdVtEhtom9RjKucHuTzXjovVPUCkxJrl 9AmOViuGANNJbjV7xszaxeyRn9eblsmszGr5TWtu/vCnxP0rpPxQ12aO8jutKnkKI6MOR81uzrvw v0Txaez1u0uYYLvADTls7k+OK8l7XVNQ04NHa3UnoN2yx3D+9SUXWfUa2wQa7fQxjgRpOwAq+DXl jPt7D6Ja6J0n01/C4Ly2RIYirsZFyxxznmvIXxBuIm8UeoUgUFFv5WEqnIYZqEn1rWL2FoptZv2d jy/5hvq/emWnwG0LoZGdic5c5JPzmu3Hjr28vJrI9kn/AJ3I3fvWf+G3W40G4MEqlo5Rgc4xWvYg pYsxAOMc0iUujKUJDL2wa7Z4+Ucceq9EfL91xb6DqAVr5Py9zjKseBmtm+JngLa+I3UNpr+nX0Nn IwHqkqSJV+Rj3ry70jrjqLSSBFfPF7gqMkVkTeOHX09ubc9UXSQlcKigrgfFeHLjyyr2TKb3a9Zb LRLPpno2TToGRYYbdlyzADdt+a5w8APEqHp7rPV9Pv7lIbKSVsuzZAb5rg6+616wv4ngk6gvriOX 9SG4YD/vVad1LrOgKRaXTtKefUZt2DXScWV+nO8mO/b0f8aPLNF4r38eudN66NJvJh/NclmicfYD sa03feUB+k7a5u+uOqPU09FLJcW8pjA/cE5Nc86Z5l/E3SLJYLXqd4lUY2lP0j7VifV3iX1r16F/ jevXN/asc+nkqP7it48eUvpLyY69umvBI6bNeTywX63UNjOVt5E43IO1du6S+n9a6FaTSxJcRoQy kjOGHY15AdOdY6/0hlNOnEFqw5AHas/0jzTeKGg6dJb6Prn5S3HOWiDc1r9dX92NntvPz89SXPVH XGh9E2b5WJBcOqHOCT7gU38EPLnrGp+pLDfpFLEg3ZB/xXJsXU+t6lrlxr2oahJdatcOZJJ5WPf4 HwK2X0Z5qvELpOGRNPuYoyvYyKDuxW7xXTjx8uO7bXoj4O+H+q9Ci5i1CWOZZOQ0YwK5b8SvKp15 Z+KWqa/ocI1G0upTMVjGAcnO3n3HzWuG89XizJBlLy0ST2H5dTmofWPOh4y30BiGt29uZAVYx2yg gH9q5Tgt9t582O9ul/APriHRespbLVFMFyjehMhb/lP9/mpvzY+VSPxvFv1DoEyx69CgV88rMnsB 968/tL6+1/T9Tlvprt5tQmk9SSRmI3t8mtoaT52fE3p7T1s7KaIopwDIgfA9hzV8LjluL54Z491n Hh55dOtfD+dp+oM6RZxAn8w5wCK6Y8uviNHfyX+hXF2sqxHMM+8YYV5/dfeZ7xU8U7R9N1vV1g0q Q5aGCMJu/uKx7pLxR1joMOtm7yL2GZDkffNcrx5W706YcmEmq708dfC/xet9el1TobqjUr7S7g5S wilIeL557GtQ3/ht48a107ezaz1xqHTBjDD8teznMigdwc9jWD2vn88R7bTktbQW6rCuA7opNav8 SfMx4meL0Isdc1YQ6ax/RbqE/wBxW8cLHLPOfTALe1ks7+aKR/XnE0izSnkswPLf3pzOwLp7gGg2 0K2rqA5c45Ynk0Rhh1BHFeuPFj/tn3g91GenuqIZJX2Rs3YnivR3wF6vS8umtIple3uE9UDPIb4r yoBaN98LkMPf4rY3Q/jlrvQc9tJDM87Q8oxbbj7V5eTC+W4+jxZ4zDxrsbxT8v2rad4j3usaZYSa rp2ov6jsBkwuTzity9Va9aeDXgg0mqyiP07Y2wJOPrcHH/euQ1/Ed6st7IoOnreeZV2iQsP84rQf iv489Z+OGsQ3Wv3hFpb/APJsYvpiQfcDgn7mpMcv6by5etPQXyrdZpe6fLp4cFJCZVJPcn4rA/FL wK1jSfFW71extpL7T9RbMYHKxn3JH2rlDoDzAav4dSxhGd4lAKog5P8Aet7J+JTq1tYbX6Khu5kX HqGfGT84rN4qXOe3VHVXUcHg74KfmbrbHcrbBMg4BlIrEvK71tFq9vc2qv6xuD6+4dgTzXn140eY jrbxy1CFtbm/J6ZG2+HT4ThcffHepLww8f8AVPDNo7qF3crx6AGMge1ZywzmtRnHkllldOeJ/hLr mneN+u6y+nT3Om6pcCS19HsD2rojqbqO28F/BWa+vXQNDbjCMcEu4Ax+4zXK3/7TUWtjEs3QxvJU GBIJeM/OMcVzh4++Zbq3x91uK4vQdJ0SDmLT4Xyqn5b5rOsrDymtPQjyk9YQar0/d2QcevI5uNnu ASf/AKa0X1r4a9R9P+NGtzXS3KaZqV288Kpkq4Y8dq528KPMdq3hpfwXcLkvGADkfqHwa6KH4nWk Pbp+Z6ON1doACxcDJ+2RxWZLrVdcc/HuOlusNXsvCfy56nJq8gtEj06W3+s8l5FYKP35ryy8EfDr /wCsbqBtPMoVZZC5Y/GayTzF+bbqjzGypp0sY0XpZHDGwRs7iOxJ96xrwi8UYPCrqFNQ2b0xs211 ywvjtxnJLl27Xtfw4OiNc6PNxPqF6NUMLskiSEIrjtx8Vxp0xBJ4beI15ot5Mkk2l3Rg9RP0vg96 6zt/xL+mtB6bFrLoUt1fKpGxGwGz79q4d1zrNet+v9e18wGyF7cm4iiznYp9qzMdzRnnqx64eAPU 8WtdJx2HLbo87h/1DmuZ+puneuPD3xn1XTI73U7TQb+YvZxwOdlwCfetPeCHms1Dw31GCOY77ZAN zsMgr78V1I/4h/hXcWkc91bzzXir9Kfl953fY+1cccMo7ZXHK7xbo6m1y18MPBW7utWYfRYtuT/U 7LjH7815P6T4W9V6/YXmr6Z0/c6rpqzSTPNCDiNS2RW0/Md51NT8ddmg6RYnR9Agky4Jy8v7/FbB 8tnmn6b8ONMTSuocR6aV2sEUNu/cV6cZcY8uVt5N1hHl00m/PUgU6dPDv2qsbRsCzV6Gdf3cOheC Ottq8iwqulyxuZT/AFFCAP8AJFajl88XgXp6pPbzYlj5UR2AUg/vXJ/ma84ms+OPr9PaMjab0i7A sCP5kuPcmueOF8tt8nJPHTUPhv0rP1trdrp0EnpM74U++CT/APcrqjWPw5dd1XQDcwdX2sbekZvR ljduQOxIrnTwa61tOhesNPu503QxsAZAOwrv5/PZ4T6XoWLrWZxdLCQYFtyxLY7cVcfLy7iyzx6e dnSkcvSPVMtlOgF7YzGGTYMA4bvXqr4C67Dr3hpaxRSLJIsRVgO4yK8luousE6o6+6h1uzBt7W9u mnjTHtXQXl280knhtqNvbaggewbhyWwQPnFZ5sbLLDiymrKyzWOrPEXpfxV1XpCLUL2y003O1YUY gMGOePkV151xLb9I+BN8922zbYguW7s5AzWttZ81ngPqt/Z6zqWpxvqFsuUf0CWT98d65h82/nWt fFy2XpbotJE0ONw899IdpuBj9OPYVmY2unlr27T8rmv22veGsKRzLKyMcoDyoNcw9TeLXiN0b4yd SdLW99c2umSX7/l9+eYycAr/AGrAvK95oW8MdQjtbyFX02UBZNz42feusNV8ffAvXtSs+p9S1C1k 1K0H0SOmXT7Ee9Txsmmp/wD1PTZDQr0d4Hah/EZNpj0udpJHPdnQ/wDckV4u9L6WeotSazQbnuLl hGAOcljXXXnN86tl4oaG/RnQxlfR5WU3N/8AoMmOwA9hWgfCHT7jp7WLDXBarJZ2kqySM3bvzXS7 wx6YllvbcNv+HJ17rHS663Z6zYozRGVLSVDvYYzjNc/dOaNcaR1d/D9ShEFzZz+jcwt7NmvWLT/N B4c2vRFve3vUltBm1/mRK2WQ47YFeTHXPUlp1F4hdTatpMskljcXpltZDwXHya7YZec7Y1q9PYvw Tm0STw00pNONtCjW4SQRMAxOOSaZ9CeXvpbozqu46isLi6ur+ViwaWfeoyckV482vVGuxDdFq+oR KP1JDOygf2BrqnyW+KQ0XraJ+oep5YbZlKo15ckoRnnvXn14+3azc27D82XgDYeP/h4mmX+orpi6 fI12k7nChgvGa8br7TR0/r15pTXKXy20jxesn9WDgGvQf8SHxn0LWfDjRdH6Z6nS41B7wtLDp0/d MDhiv9688bWwW0kMitvYLySck5713wryZY7oqoVUjfu49/am4j3M24/3pwVIDSY+gUPOVDKBtPvX oJOyXi28Hk1YxllBoqruB3/5pIXcnHI+aNwMxYH7+/xQJLdQ25Thv+9FLPkjsueTSXTA/wC1GwRG hH1IHI9/im9xHjLZPpY4FP0jBmXPAPt81V3AIpSO4xkKammonOj9R0jpSxkvdS0+TU7s8wbD9K/u Kaa111qnUgl9YQwxSDaIY1xsX4qJZ+CpPbspPahs4YBnI3e+B3FRfYcNt9ZOOB2py9oAo5yD2Aq8 ZUINp7/NLEv/AE8D3qE6NzYurAqc5oVwzY9MqP7d6cSOX3A5Cn3+KA6DkjOazYGJgwTkkCmskRXJ 3E4qRlAKKByfvTSaI7e/FGjN23hdzkD96osnpkY+oe/zQioDkE557GksSCOaztSJ87+PcU0O+Pn4 9qf+iCwbJBHtTO7k5Yf7irEI3CInBzmlxjKsfYj3oaJiPcoBz80NZ2P0se/FUFe1RI94OZDSojGq 7nBBAxmndzGlpaxL3dhktUfOcuCGytAmRVYfT3ptKsgP6uKO5wwyRg/FJdlHf6vtRk2R5YSrx8Mj bg3wfasgvuueptQhEM2syehtx6e7uPvUG65wVOB8UgKu79vmgLboXl9RxznJ+5pd3dpIPTFuIwP6 0oW/YhAB59zQfVdQQBuXvg0CH9PO0sc/OaWblfSIP0n2oLRmf6woApTRDZk/q9moGJjLvkcc9vmn q26mVS30RnuopIZXb+bwRwBQ95IG3sPmgkNWvll9OGKNQkY/Uvf9qYMjEe4T5FDUsrqfbOT9xUxr V3a3Gx7VfTyoDL9x70EVGoOWyef6vinFxC+mzLfwSxzOQApUe4psrjaMcYNVNEJlH1bCORigk36o 1HW2T87JJujGOTx/agfkrZw2S5Rjkx54B+apFKQbd2/Hf5q4IEQyCAD2NZWC6fbS2ayKh/8ASv8A qHzV7bEPqIF2RkYxSgw4AG0H2zV2PGO9RRFVExjsaUg3KwwAB2oPHA5xRN+5cNyK2AtLvXCZU57i lMSVQhs/vQ0gKzu2eD2Bq2VBAHPzQEZueFz+9JV8LyOak9G6buOobxILS4jilbn+a20f5qO1jTrr RLuS2mMbsp5aNtw/zWAF5Am4t+oj6QKXaXhayxKAZCcCsm6V6T0vqDSLm4vNXXTJ4E3rvGcj2xWI K8rCTKgpuKq47sPmidnYkESKM89wR80OcyTHMrE4q9nbGaMor4OfpzSJre8s1JuEwD2ohqyo26ML zjOTRyYru2tLKZ1ithIGlZP1ED2zUc0m8/SctnH01dV3A8HIPIrYyorp3UurvHZRmxtrK3MmJD/z CP8A6aaNfQuAwGDjOB81CF8AmPIf+rnvSo23SDcSqe5HtUofyLLqSEBMqO7UyigaEvzt+3zWY6hB oen9ANd2F60urGdU9IjGEPesVlcTEEjaRVDJg0+CfpPtiqdTFGpyeKeAr2BDEUWa0Mse/K7ScYzU gh/WEcoGSQfapGCcKn1ZGfemNzanIwMEH2o/BA75HzVDe4lLsqhvozyKNCwGSxAUfNCdPrAyOTTt bVApQ/V780FTRhLiLjG4bv7UWS3QAyZ4A5Ud6FMzylSxHqAYB+AKGLx0uFlRcsgwCe1DapJUW2cK jNKcYA9vmsi13RNL0iy0y56au2v5LhN13ubPpPjt/moO11Se3lka5t1DN2xzxTmKW1iiItIzF6hy +D70AVknVmLgDIzIp+aLG6BvoB7dvigtJlGPfn3p1EolRfp9s8VAoSDZtA3H5pBcpGZAN2Dj+9Ji QncyZb4p3pwV2CyyDYhDMv2+KgC0LK+c5zyQKH6rertI/YVKdU6ppV/dxfwS0bT7cLhmJzvb5qHU SRsvId+26lEnDLp6WzNdJMZD+kxnAFMJ5xGwTuHOBj2FDctIAAAWJ/TT3TILETl7ubftHEfvmkCI 7OMzBmZsnHBPFVdW/prKB9Q9se9Jnm3tIUG1AfpH2qvzQESoY8yH+vNQACyBUjKk/GaRfI4i+gEg e4p/BfOoZWAK9jxyaS0oEZULlTVgjoYt0aFRknkg1TZwVZiMn/FGU7pC6/SF4xS2kin5Qc+9WBsI g3cHbjvQ5IzGn042+1FMokDKp3AfFAeYBQGGF9s1Q0AlKTemQGH1Z9zSuluktT6vvDa2EU89ycHZ GD/fmjG+/LSBX2BXGMHHas26N8Xr7w1srm20zSoriSUHbdOcOmfcUE/ovg9p2mlv+LtYt9JkgX1P yzj62A+aXp3jbbWnV8djM8kvTUCGK3MJxv8AYZ+1a1tdd1LqrVNUudX1BpJJ4mdQ65DN7D7CoLQL pdLv7e5uArPbuHEbdj9sVnbnq1tfrjoyPqTT7nqDTNfM9zZqxNndNyqnnC/Fa7ttUvbizjjuMxoV yM9zTzr7rSHrLVItSs7M2E2zZLBE21HPyRTJI2lVCWGSoO0HIWm1xml5o/zdq0M4Dqfkn/xQrXT4 oYwIsRgnn5ozAoSAQSPmhf1YPY0rqVeOYVyp9wMik294be+RFR3dlxuUHANJZ2dSijeQQQK6L8mU Wk63qfU2g9S2lu9tPE1zHPMBuU47A+1I526jQMU2GdJWYyA8FjmjkxiMM5Jmz+qmnUz2+j9S65FY /XZx3ciRx5zwD7GqWQTxJKqFUbuppV+iiqyBjncM85q7ShMbmIP9OKtEkYJ/pz7fNSelanpWnQzL d6eLqV0OyYvj0z81FRU9z+UwcblzzinLMYMowG0gEOTUfMrOgBO4SH6XHvR7fQpb2e0s2mPrXUyw pk+5PBFa0FS3ioNyxsyg8uoyKyTrHoq10LpzSdVt9Vjv7i9BLR254H2x81lXiHp995etGm6T1Pp+ G5m1OITR6lIckA/HwftRX0zpTwp6L03Vb4NrWr34V4bR2+kHuf2rWuj6YVa6focvSv5p9WiGsGQB rRxyq/f71B2t1+UvW9JdyphuO3Bp715bR/xj+Ii0jsZNQi9cW6YIX9qk9U07pzRemdCu7G9kvNRu WYXcTLj0+O1ZoxvXNWuep9c/M3CpGzLsKx8DPzUtNcWUuktZ+govIwB63sahZZbdjvVDndn4o1pM omfjv2zWQCC2NxcqqHfP+lVX/tTu3tpbeWX84m3YdrxHvVRTC0ma5i+iUng/BFBuLi9uZZJWBn3D lsdvvQHmFkpUwxuq++45NNJlUI5GQB7ClQSbzh8DA9zTea7ljxL9AQHsT3FXYnzptrJ0tBqUd+n5 5WIexI+phUawzEXZMNjGBQbMS7lmaMNE574p7NtScbmIB9q0GkeAvwau3Kd8FfmlSAiTAXC/NWIa R8nArAvFNtYYG75FLtoittLIWPByfsaGAUbtn/zT5HSO2dRyr8spFbDaONo0Vy2d3ODRfUEkexxu BpuQkxDKNqgds9qJHtXJY8D3rAu5KgDBIB7ihS3QtgzkBgfb70e6W5tjEkkLpbyLuR2Xhh8g0CKF JblRJ9KKQxY9uKJGUdOaLfpaW/UGoQmPS7eQMJJOM/tQvErqvS+rtYgutOB9NVA+o8k1IeI3iD/x d07pGj2oS1trNgzRqcepj3NA1hOlT0tE1rbgaw5+tkOQK1pboz6StdIu7HUP4uZY2C4tzCcZP3rH 4lFuJELFgrYUseSKuLh1m9O2t2nOAdg7n70lI5JJMNEEZu6McYqM6JYiXBIwP+9BcKijJzS5ZTCs u84jU4BFNLi+hSzy7sxZu5HYVpLBkgacHYmR7nNNXcHPGVFSNxAJNKUR5SZvbOMigwIDFtBCkf5N BFSQ7mOT/arxW4JWRSGdey06lVXb6fbg02nc2yM6ABh96MHcmpb4zCuVDDDr801igyWLMEVeaGga cB8AFuSacSGL0trxEEf1571oINwGi2hi0bDgikFPUUEHBXtVlwF2qOB2+1UImQKQcg/NZFnLLxn6 fvQNx9ZSCTinDKc7n4I7ChhCzN7EVegre7MWIMaBc/uaXMSwjDOTuHcmg7mAbGSp9jVPF6rIR9JX 3qA4k2AKTz2GabypFHMWZAxx2NImzcXiGMY29/vVO4lmLbvq7EVQUJHIoAUgnuB7UR7U2o3LzuGe fam6FrfL53E9xVNO8rZOQvsKi0VLxljlU52MO471JRahGehzYYKyNd+pv/6fio2NWkG08KfcUqRd kPpg5Gc4q7Ra2CwepGADG/fPtQ5raFp1dGZUHwaugx87vmhyZwPcVAocllGD+9OtEcw6mjIoxnnd 2NMlZUfc+fTHehWt2sdy0kkbtbscfGKKnbuKzivbr147gtJzEYWwqt96Dp0Gjo0razLMXI/lei2M fGajYrnfI4TcyZyCxPakGEXbyh8jYhYMB8DOKu0LvLyAS5tlLhfc/FPdCubaGOWW43Nzwue9bL6b 8vtvqnhivWDdT2kGYy7acWAkb/p71qOeCOCcgROhVuA/H7U0tS108FzLvhjaIDjaTwaaQxRJK7oC JSP0+xq0Uo25XI57VMdIdM6h1trp03SIRPdsBhWO3FNohmkIUhhkg96LC4XJwTn3p51n0xe9GaxN pl6P/URNh/tTHT7R7vKZxjt96UOFtYrmaMMQqlwGLc4FN77T4bS4v/SYSqn6fsKTKgjVmyc85H7U 2gnEDMWUvFIu1hn2qDa+i+AV1q/gXceIFtrEKw2shSS0B+o1qqxJ9BpBIwAkwEBp7adW6vpuiTaP DqMqaZK+9rL+lzTCSdpSdyhXZsnHGKKc+szOzHPPxQJYBKrpvOc5wKtHHPdDZbxk7ckkUO1md1JP DA8H5ojPbDr3Wr7oWDoi2sNMht2kLif0sSsfnPz96w+4iljZrKZ8SW5wxonqNIhZiUkX9JXg03mZ mlLOfrxkk9zQFYzOG2sqhRwSO9ZX4UeIieHN1qM02hxas93GUSQqC0R+xPYVilqMQsV7MfehOzR8 btn7UBtQ1FNT1e6v5IxE0rEmJewzS1jRURmVWTupPfNDtYEkyWXI+Pmn7wxgrGeMjhB7VVRd4Jp5 Q0rYA5A+1IQGOQKOc+/xUvaWlkZW/it29rAR9DxLuOfjFR8sKC6f0pDLGOEYrjIqAy9wMjnuabXE fpSFE/TnJo4TDhvj2oFwrmT1TwG+miEBpAMjJUnFOokEsTISOf6gKDDIwXb3X/ej2tvIjM2MKfmi 7IEZVsMo2ns3zR4wIGHuCOxq+7apJ5YfpU0MTPcHMvB9gBRFzLIyFePVOcMPalWUkkDfzWw5/wB6 Qc5AI2tRYoPUhBdsEnCj3J+KtCiJTuJwB96vDIyzb88jstOdV0TV9GCvqtpNZhkDxBk+l1P3ptBJ slDqMYGagdFzMokI2/IpESnBGcA0bBkO7vu5OPmh42sTnDVoOIrd7yaKOMDk7f3pxqumrpd29qji T6QSR7Z70xtpnjl3biD3zTone25m5PcnmpEoaRkoOO3sKJDG6Pz3NFSXaoPBI7UoSSFmZEDce/tV RZYmUCQnC++auyhoywIOTwaCbuRkKtGFz96kL/TbWG3tGjk3yMMuQf00AFi/lli31A/poLnazYz2 4o0UWXb6t6j3pUlu2c44x3ozsOPghW5z8U6gtWkDzZ/lJxge5pqXEWF28n+rPanel6i1nHJE8fqI TnBovZN3fZtOBj5HvRYgDagg5P2olnaJqMcsix7YUyW3HGKZxsqqVQ/R2wKJ9lsQSBjj3qguGyDn 4ostmiafbyre7ppGIe3x+gDsf71bSFE1vLGx+uM9/tRAwx3ZzziiwQveSxRRcyMcYoNzNGkbSEjc DgBacz6PqWnaPYau8TQWd6cRy9iMfPxQWurKWzuXicYZe9CCDGM4pTRvIzMZWYqOSTyaCoJPagfW kcMYb1ThGXv8VVzZG3ZMESp3JFB3ADH25Bq8bNGoSMk7vmguihA2DkfFKhjDMpY8g5xRCVwqRgHH c0e2gBYuBggUQ6gkkKlDFkZxup3HDhiAuSKDEQVGTk05Ruc5xmiUoEgsAcEUVt0kYXJxSY5oxwU3 D3GaIuwfUi4X71OkIjzkqV+ke5p1BPJGMqwUjsaBu3vnGB8UlmCHtmqKuwbol3ba3v8AembW+M/W TinjOu3JHP3oakYJx3oGwjEY75+R80SwksYLhnvIpJgRwFPahTyAjj55oDoQcDJH2osE1Jlly1vE UTttJzTfSNUvNOt5raJysLncwPvSp47qG3GxVxnOc80KKOaWcMVwmOV+aNF3DNcyiUknI4BpncQB 3GR9PvV7tpRMyxxlkHHHtQUS7kYqLc4Pd6B5bS2Fg6mVSWHfHvVdTXejzvCmmpKpwGYyH396i7lF gm2k7mHJBNCnP5jkqBjvigDIpkn254+KdR2xji/ekWtoJWEgcDb3OeKdCa3VXMjF9vZF5JoCWV+8 FoYHVSxPt3q8cmIdpBOT7+1Hl0O+h0uLV5bM21vKcIJOH/uKZD6mKEkgHIJ+aB+riRFXJH3qhcOw bETShfZeM0GFCEAzg1eK6eSNkTgE44q7GTQdKasmmrf3tnLp0MozEJ+dw+c0zRgeFywX3+amx1jr es6PHY394Li1hTbHGRyo/eoFkkigVnHOeQKjOjpJODu4+KNu3g9h/amcUiSspDZx/SfeiXDuM8DO KIK7jZgjmmsuI2wNxz/SacQLlVZuWZeQasXSOZSy5XOCKBqbjAKp9XHOaXb7uSV2qPas48CfCvRP FTxAu7XWuo00mK1PrxW7kKJMe2fer+J/TNp031Re6dp0iSQwn+k5BqyEsYNKh2j3B96DBhA2WzTt grR7FODQWiClUXlh3ArAjpSxZSe2eKud/oMMDvxR5YWLZIwfj2FLC5IX9PxWgwkcRYBBP3NPIrVn iE5B2nvig+hJdSyxR8MV/Ufasr1G80a00Gwh01i8ioBdMw7ye+Ks/wBjE7mIphz+g9sU3QOCob+r tT2WVXO1cFD2z7UzwRIec/B+KjWjtCAPuO9Xju4ZVdQd+359jQWwsJUDDe5+aEFE2Qo2n3I96KtN Mpbt2/3qo0EzbsbQe9J/KsCADkUuEbfqzgA8iiaODAsShgPqHFCL/Xy5q7OzscDg9qsV+nsMfBop SkhstyCeKIrHnAPJoErAMhAOO2KMjqhMbHIPvQOlVsZUAgjNNJuDgMTk5pbz5TA7Dgc0LO7+1FgZ 24clAHzwapo1Jyy8fFFWMMu8Dg/7Un+YTtCAp/qzRqEugVNzq3pjsRxVhGzyfT3P6fvRZ1ysUZYl MZYfehSEKQVY4HxWdNzLQMsDM31U8ihBjBPA+aZx75C2OEPzTiNyI1jzkCml8iZY1Vx8nvSRGp+l RgfJpzsTBIXt2NLESu31cftTRtaOJhlVPtS44Jlj3d8HmqRjF3GEHb707EuU75GM1dMbN0VmfJ5p 0vGSox80oBdilR+9EjTKOR7d6uk2pASo4/vTuBfoGWORQVYKiso4PtTpFJQYYfVRnZ3ESe4zgcUq NCULH5pFupCYLcjnNL5DADPNHSC42kr344o0EqnCjjHsabMQoJDf/cq0I9R+OT80bPJF7496G3A7 ZoocbME5Ye1BIMb99wo2t9Xb2pIQE7WJbFEyvOTj96S/0AEcZ70CG4J5wo7YoUqAHGck9qXkMBtp LbFBzn96MkAkYI9qIm5zn3+aGc4Pvmr79uPvRdjOBIACcS+7UiNlJ2OCwHvVjIFBBGR802jumExI 4+1E2mLoxyBGjUKFTDVj9yzGWSPBbd/tT+W4+lSGwD3FMGTc5IbBPvQ2BGvpTxjuM8k1aVF9WQpL uBP+KMYZEXO7I+aC0CwHKEbj3FTaw3kiJc4JFWkAUANzTkEMMjj2zSktyyFTxn3NRUZLCSdwXv8A NWggZJGGAW+DUotsMnJ4B4pDLuz9P96laR8ys6hdgX70D8lskyJSxb+n2qRlQqCQ2abDb6g4++RV ShNAIyQeMe5oQVDGQDkg5pxLtB2sxdj2pqv0OExgE96FWkReNxI+6nFKfBC7Acj/AFHNWmXtxQ1U Ecnv75obK5YZpKP6TE4Bz/tSkYLnHIpJjLng7aGymOOQOasTvbgGr7SB9R+xqowXlCgjPtQ2ogx4 HtSw25OM5pUw3KuQBjuQaH6hiH0rk1NIXjPA5x7VZMiTeDxVllk5wg5HeiQM753Lk/FNNGNzaS/m d4lwrfHtTuEsCoeRyFHuaWx3cOCaE20sNoKfOaaTo9abagYE5+KC10wyB9ZPzSZZGYnPA+1IX6EZ xg47UXSnUvg/6u1LjYAldxznvUzYaNoUWi/mJNRkbUGyTCV+n/NMYwjMQqqy/IpUpEkBllSMnGe2 PeimBo9wY7dncGjEoskcik7l7cdqZS3rxzzSSttJHcjg1NrpRnBk+nv7iheot0xU+x/xRdM0XUtW V5Y7S4WBRlpGjIUj5Bp7FoyW4Ai5b+ommzajKHRUfJ2DAzSB+XGQ67h7mkSI0bHeMHtQduSe4zxi mwctEcLEAP8AqFM5rZ4MuMknuKvEnpEAHC5oyyn+j6iD702KtQWTZgMpFWuU2SoMkD49qUVEZJjf 6jyy/FVtEskbOdxQ5x81e1EeOCVRG0rxyMMfQcGml5bNpKerCZHZhty55/enFz6P5ov+lwQV+1Fe Y3aYYjGcnPvWUH0rrXqzT7SOG16o1GKzTn8sZT2+KkZ+v21KICRWL4yxc8k/NY5M4lUCJQhX3+av bW0VzISXCBBzn3NWXS7Hu9YnvLeUqwVSDhfmm9q8iW0ZyfUIw4FTEvTdlZqJmuPVaQZEYP6aYvCs GFU8Z+kUq7DUSscEtkdqFFCsNz6k+ck8Z7g1MwWVxEimSFstyMjmm12q5P0/zh2qGzVrR7uQ7Fwo OWb3rI7PrXqDS9Dm0yG5jmtWUqElGSB9qxpi6OHRypIwwHvRUui21g2F+Klm0GZ3ltoxKoDY+rHz TeOc2Vw7jLMRjb9qOJVCMARuJzih/mEJB2gsOCa1IG9s9wxlBjL7zlSPapB1mCqiKFQjDKR70Nb0 QuCmAwpT6kZs7lye+asQ0k3QysmPqTvVBy+CDkHuKM8+5sbQffNNIZj68qjgVVha3KxLuJ2j3NOo rndHtG0qeQx703CgDO0OB7H3rNtA1TpFrEwa3C8JxkyRDJNSIxUMcH3x2xQpB9RLDBNZbf6r0cgE WiySzRk/UZBjFQM8USyuysHU8jPtWVl2jiSuDtz8A1ZY/fP1Hn9qPNPEmCSM+wpiZpJJW+nbitdr oZdyzYfBNGWXcRgDGeQKTB9cbbhlz2NK9ExL9K8+9Ts0GCc8/pzxVghkP2BoiR/UGPPPY0phHEc8 nNNqGyK6lscDtVo4lU98miIqqCQc59qvgtkkYBqBxbaZLKC6c59hRZIGjGG4NNknli4VjkfBqz3M jkFyc/8Aagu4BnC9jjIqt2Qc5z96QDulDDA470ssEzkUCVVkxzSZS7Dv9XxS2YZxihyN9WcUrOxN OIk1i1Q84cBh816x+BtqqdG6UB9OLVcD/HFeU3R8QuOrLJiBtMqrj5Oa9bfCyGO16a01WGAIF4/x XyfyP/bH0+H+NbO02Mqy7TwKnIThe54qIsSinA7VMx429s819DinTx8t7Xkddg57VjJj/M66zZOF O4VkcgjzjdtrGkYTarKEO0ofavZi8GbBfEssJnHtyeK5r8RHIhl298V0N4g3LmecSH6QSAK5w8RJ 9sE2O+K+vw9x8Xn6c7daSqY3Ud+e9aV1k7rrdkKc+/NbX62uC5c+/Naf1Ny8xHdq8fN7PxrurZ+k NuBq6M2SM8H+r4oWDtAAwcd6cImRz714X3IrGCF3ZGO9FhkQDBJwO9XES9gKttLgL6eF/wBXzWtB 0NoG4Y78UkNzyBmh7VZSDwQOAKSCx/5g5qdD06A249/3q4UkZqhzk9iKUP0GvqPBtfnd7EH5quRg Hmkx/pOTzSmHOc0RYKSarudp7fNXLbl471YYU4PFArbg9wSKrKkfUAQD2q2AFJVs0GTKDnOAeeKB 0Zf7/tVhyNvb70KI+oPiiOM8/wC9WCiyKSNzE/BpBY5254qmOQxGNw96pF43E7ia0BAMcZPI5ohJ UAMpwfcVZyCc9iKIkrAZH+DQDbOTgfTV9p2fS5UH4qiSQT/tV1U9qCgNw4FXVw6sD3FIZmBJ9hRA MoMe9AhgQCVHP3ptE7u52e3enRBLEdhVFBHjB5omgmeVRu25xVmYke4/ejENjluBTWWTHYFhQgRZ gxI/xVK+WBOcfBq7Nxn2Pam7EEnn9qKKz7lO45PtimjkFcHBpXqAE7jQZ/qX6fqosWVkAKjHPufa kyYVdvcfNIkiBIHt80h92cRguP2ogYxvAB5pU36BgYI9/mlRsSNu0K9U6l855NAFfnkfaqH0nPcf elNwOOKt3A5o1pbIDAnilyxlWVSBhuaumCCDyKTPLuI7ggY4HtRkl3ZphhsbRgVZgJRnILe/3ock uM49qGZSQCDj4o0S8Xp5ORQ5oUnQDbn9+9U0jKc53Z9qDcXPp/p4NFRup6ddekzOEEQ7kU10hQLk Bvq/ajalfTPCVBP9+xpppUha7RuxVs4+a4Z+lxjb2hnZHGR3AGK6N8IiiPGyuCzAA1zboUwZUYng 4zXQfg+yrNEA2eRivBn6e7i9NQfiTaINQ0PpCfJH/rCn+3/3a5C0vwul1W8t4pEIjPBPzmu5vP7Y i86P6VYjAXUTk/2rRnh7pccj2wf6i7DGfasz048fHbzbO/D3yAaJ4gwPcajqt7Y2qx/8u2bGTWh+ sPLnLp/iLqvTHS97JqtpYEekZjl2PuDXpP1FqcHhT4I6rqMk4jne2ZoiO+8jgA1wx4fa5fRapda1 AS09xJudy2W5rjctPTfemNal5LPFe16am15bK3FvCnrG3x/MIFYJovhlrnUSLZ2QU3btteEgkg/F ep/g31wOrOn006/YP/K9PDd2B9qwrRfAiHpTxnL2NmTo9x/P9crnY3crWZnSxxSnks8TfyaajNZJ DYgbnIXkL7msi0nyKeIerQi8sdQj/JsNyBveuxPMV40R9OSW/S+lyB7+fBuGQ/8AKUf0n96y/oHq y7fwzubtIwbmzgLRoB3wPisXOx0n8d6cD6p5GPFHaZFgSd/sOTWI9ReVPxT6WtIZbzS5Vgd9oKLk 5rf0fnQ68m1y4tBPZJHHKyZaFQRg1nug+MvUXX99Zw399bTW0cgfZDGFyc++KYZWmE8q43vvLJ4s WWlNfy9LambNV9R2Ud1+axbSPDrXdUuEGlWxurrO1rcKd2a9obV459PiaQqYnjAbd2IxXHmo9KHw +8e7ho7dLbT7679W2IXgrn2PxXbekl7srjrqjwR640CGK+6h6fvdO06QACfbwP3rMvDvyU6p4n2b yW2uw20W3cqyt9R+9dtecfdd+BTSg4zImce9aC8EusLjp7XbWH1SLYoEY/A4rMz23x445bch+MHg /wBS+X7q7+Ca7NHexyruhlhH8th8Vi0c/wBCMowHHb4r0g8+PhjpHiD4I3HWluCt/pUatCQO/OK8 2tNlju9K/MFf5wIBjB5/xXXC7ebk1KdGVvc+/FIkuZQCSQpzgY96IFTKDcEU+59qdXdha3WrWUVn c/mdwzKNuAprd6crbofTOnNX1x1/LQuinsR2NT1l4O9bTAGx0t752OAkCksa3p4R2VnY6fHFdRKz t2JrsHwG6et4r5bqCJf0nLEZArhcu9R1wnlPKvLrqPoLrbolox1D07f6UJm2xvIn0t9u1S+jeE/V muRrLZ28rk8hSODXqr4/9L2HiH4ea1bqsc1zpsRuY3K7sOoJx/tXKnhF1lFY30C3sAYqypgD3q+W 2pN1zPL5cvEn0jOnT+pTJnOQvGPtWPa14cdWdOxvPqHT2q28ajmSSM7R/tXsJ1t4hW3QvQCa+LQX cWFURLxnNYP4b+O2h+KGpjSr/p+Cx9cFUE6rIsh+O1Z87tHlv070N1Br0aPZ2894x5WOIc1k1v4F eIcyma46Zvkg/pcJzXcfjD0po/gr4gaRruh6aEt7/LT268IGB9hWzOgfHjTustXtNJGkflppjt5I Kg/tiu+N6b608sOpuhOq9B3HUNHvVtgOCEOf+1QTGW70pTFayNcCTaU2EED7/evWvx+8XNK8ILfT Dc9NQ6218WVVKKApHzkVyfrGtr4l9XxX0HTtnokJI/8ATRRj6vvxWbk49XLTkWLo/qm6hDW+h3sp POQvGKZ6rFqei7U1HS76JB+oSRtwf8V64dB+HXS/ht0sepdYWOJ1iMkrTn6FHxisA0jzVeF3XWuX Gj3ei2FvbNlUu7qBCrffGKz5OvjPTzIttXjJ+mRRF3Vu3PxTlrohyMhAx5+1bU853Q/RfQ/iRYy9 Fzxz2Wot6s0MJ3JExOcjFahvWSS5lIIZTjt9q3jduGtdHZvGLemyhoz/AFDvRRKM4LYC+5qKivvy 65/UoPxUvZ6NqWujNlauzt2UrgGrcpE90oMTkx4ZscUtmDYEg2N7/NSS9C9UiDdBpFxdFP1pBGXI /uKi7q21TRMvqGjX9og957dlUf3NJnCzx9i5VVGTkDnir7o3BIPI70S2W+ngWW2tPzG/tGBSpdI1 mTDtod5Gg/UVgO3+5rpuMSW9wEDIyDuX5pMiuBlXA4ziryaVrCO0kOl3giAyfTgLgmgQLqOoHEVq 6sDh0kTay/2p5Qu4qKfOQ5BHsaOJt2MEcVQ03WVifGlXRiX/AN0252t/ehE3S25aa0uIMf6ICV/z WplGfG+zq3kkikLgnJ96LGd+WMmT9/ao/TZLq/VmtUM5HBTH1D+1PkS/tkMkunXC49vSNa84x4XI ZeM/XupSSmP9JCgnkmo0azHLPsA2yA/Ukn0kU6NyzSbYo2kTPLhc11mUvf045Y2dHhAmyR9IHOR7 1YTs8e31P80xOqmJvTcFYz2wlAn1YWxAKmUZ4GNtallrnqz2khIQCM5GPf3pBkk7iUqPimdpqS6i 7JlUIHG05zREm9QfGPmuupY43KSjsxwDkNg+9IlYzsCwGftSGmWNfqywHc1TXcKBXjLO5/pVc0ui Ty9HPoDghuRVBZJPqZ9uOyj3oZ1aGKIbk2Ef6uM0ldWt7n6UK59trZrN/wBNyWFXVvvG4ncV7Ypr JHKqI4JU+4pw9+kdu5JxxkZ45ph/GIpYSJGVvk7gMViukqpbyZsjcCPahIzbQgQN75NCGowzMQRG F/p2OCaMk6h1yO9c99tBS6fcXQMkKEpH+oDtSUk/lEDCr3AWsr0ae41PRptHtzHGZcsXIwf2zUZa 9IXa6gsDx7QT+r2NNdbWbqHF40REXpl2P27VQulaQKZV57itr9PeCF91f1AJQ35K1ICZAzuPwK6b 6M/Dz0XUNDE/UFwbB2XcjBhnHyfiuX7Jt3nDlpwqlzGgIMmf70dZVkUgupjHOGrr3rn8N4WWlXWo 9J9WC/mi+oWJRSHH7gmozwd8mcHXUkun67dHTbi3U+oijLA/tVvJDDju3KsFzAVYgGSMd2H9NO/X ga1jZCqLz9PuK7ev/wANjpuMbI+spLNzyAyKP9s1rvxI/Dj6i6d0r+I9N9QjqRE+prcoI2C++Md6 Tlx+28uOuX45WMhKSoykdjQ7iRgC+9CnYMtdK+GvkXvPE/S5Seo/4NdW52yqYcspz2xWruqvLnqn QnjJcdB3Oo/xUxKrx3arsDBhkcU/bjXHLjzjW/5qJ7cMrKZF4Gfam4vfWcKzoG+3Fdd9O/h0at1f o5u06tTSi2QsfoBua5+6Q8BeoeqOt9Q6dQrNd6fcPbtMABvAOCcUvLjYzOPOaa/n9TaVSZY0Hf70 ll2BQGGMZJXtXZdv+GFqOq6bHOvV/wDDZnXPpGLfg/vXKnjH4R9ReAPWD9Na3Ol00vMNwmD6i1nz xby8sPbGpJgQQQMd81GXGQQI3xk5JancxaWMwow3twu3kmt1eGHk86k8VUtfyc4s1lXO5xwOM81m 5Yyuk8s8emhmVdoMTKXPc0Pa7RtvAY9wRW8fMD5JOvPBTpmbqW8vINR0WBgkrQsAy5+wrRdtcNPb wgKFO36ee4rpjrKaebKZY01e3DbG3Sl855NSMd1M5bcqocYyvuKYm5DSbDIBjuBTndhwo5YjOK1M ZO0uVo+9mRkckg+696XHcCJV9BZInByGFBjY/wD56cIRgHmr4wnJljOj3TvoWY43SSctI36jVLFF POSX2sePgCgxgSZO/aD/AGrIuluitX6vlSLTbYvvYKrAZ5rOWpO2sblnekb/AA6zdMM2WXsR70eN cwZbHHYtW9oPIb4wXmnrc2+nWjCRQyh7hUJB+xrU/XXh51T4Ta4dM6u019NbjMgG+NvjDdqxjnNm eGf2x5/UNuxTKcYynBps9k88ZLMvqLzgnJasi0rpvUNfvRDp5ecSDESoma2naeSbxc1DTUvLDQYn VhuUyzhWP9jWf2Y2tTDPGNIQTelnagRj3Bq04jYM8jjeRw/xUh1d0f1B4W6/JYdV6bLpd4PpIkGU cfY+9Qj3MUrEE5B5UY4rr1lGJbKF/DEtITJdqjoxz6iE5FKiS3iiYRbGduRuPNbo8FPLTqvjdcpB FK1lbOcmcjIT+1R/mc8sGo+WjV9Fjk19NbtNTfagEYVoyP8AuK5Y5Y/T0XHO/wAmqH3CWNgrbwCD tPBoc0D/AFh4VXnOWJ/+mn9haXeq3EcNod0h5Marn/es9by4eJl/po1FemJ7m0YbkYE5YfYVzyuM ydsZn4tcQQRoquFCg96ez9Q6nBZNY2t00cLj6kHY031WzvtC1T+G6vpk+kzjIWG5UoT+2e9Ls9Mv dRkEVkAzt9KxgbiTTLLHXaY45ZXUREmk/miHYlX90LHB/wB6exWq6ZFhFwrDnms6s/AHxKvLf1rf pq6lQruBZCMisD1iw1LQLo2mt6fdaXc7sAXEZUH/ADUmWP03ZZ7PdJ1SXTnkaKJZXcbQH/SKjJbd 5I39bJBJOxWwBn9qyDonobUvELqC30W1cQyTEKrg96zzxo8ofiL4K6H/AB69txe6JwJJoX3MuRnk DtWrq62st00gunwQXaSlCMf1ZJJ/zRkGJ2fGFPtTqJ1ubBZyRwMYNDSMZBzx7CtSSM72G8OSeTtP ce1IEQXCJgKKdNwMUNQNxHtW0BK/SMc+3NXJ/wBONtE25UseFHxSRGGXGciiw2dO2e3wBQdynIPc dhUi035aA5UM5OFz71e00LV7pfUg0+e47ZaKIsP81i2RZtER30SPukIyO2RTlj+bb1+CpHBp3qmm 6pZKPWsJo4gMkyWxFM47sysq7k9MfqIGCD+1Z8pfTpIAYG54y2feiNagJnbn3zThpovTZ87sHnNA e6DgAKWB9qvX2u5AjkHHt/2qic9+PYYpRYk42kD7ihvIF4Paqn2T+lTzkj2NJAJUsCFqnuEwRzz7 4pPrI4Kj4qBq7Ek+5FNrkNJjH0k08Khuc7AKYS3KJKiHJOe+KjUpjJGTIQR/erhSjZ4CiiTnMzsA dv7UkMkkMqsxUMOMCsXruukm+jm2tJLqB3jAZR7Huagrpg07jO1wcbTWVaR0V1df6Yl7pGi3+pW0 Yy/5e3Z+Pc5FQM6y3jOZY/SfcVeJ02tGR3BHeszLvpMsddGjSD0guBkUmJVN1ESPtgUpkX/2xux8 1NdO6Ut9qlusowoO5j7DFb2wDq2F2pwWUcioJ8tu4wPYVKdQXC6j1JfzRECEMFQL2qNGDv7jbwOa 0BZPvwBVycDBGeO9VggHK7f3q6OGI5zxijIe0g/akkbclhjNHKlRndj7ULJd9h5H/agCQxAO88+1 WwxH1e3xRSueCOaEzBW2+1AMAlySCP2qxkLL7Bf+1OByCqkBvv70E4fcdpVx/T81KaCWFpM/V/ek mIoMnlf96kBEiQpLvwDxsxTecjaTxiqAbC6/f2q3puBTiLldwxtqt4Y496ACRHJ+O1K2fV24FOEA z3+9UTtJyAB+9ARPpC5GD/3onokjvkHtVRsNqAjIzxRmfkqy8n/apsNxGUk/VnHajLg96QIxGApJ Zvc0oYHBNZbKyP7Vdy2Dhe1J4x3o+0BVyc5FXaGYYnLHsKJaW35sD/28H3pdzahYw6Sqo90NWR/S jUuSoJ4GKbOzW7hubGZ41f8AV2dfam5jZWMTO0ivyS3NP5tSEz+nsA/6jSCEaJsgE+xByKimktot xIIXkcqo+nBxVQIscexTyvBzVyxXhTtCjg0PaVBPYfPzRC4rmVp44oyA7Nhc1fWmv2v/AMtdOY0B UuOx25peg201/wBT2drBAbiWYqI8ds57VsrzFdMaP01qnTSW38q/uLfN0hbPIHY1YzemBdaXmhXK WY0K3ntbmKMRuZP0v/1H71ClW2bgcNt5PyaGzer6ZPI2/wCaIlxHGcEHaRzmtBjCs11Ku4lcf1D3 qbtINrDKjGMHdTe3jijwqfUq+9P2kyAVXC471EhpHprRvn1Fk5yMntQrl2jY/Ge5p+rLFk+5preo s0Z4y3wKVQIXaUh1XANLuN3YnOPerWd1bWrBHYrtOQCKltS0mdLJNSmgZLS4/RIoyM1IIOa52pg9 x7j3pKuzxls80kW5D4LZBPvSmTYCeR+1Np2uGUKpI+sd2pf5nEhL5/ehAfSDjj70gxtIx9h8VpRJ bsTL2CkH/NKtSmwuW4BzzTNVP1HBY9u1HhRyq7k+knkCgcSXglGOCcYBFWF16aquAMihBALlk2jY OwpUFq95qkUKEYPdmPageWNnPrBWKAZ3Phj8Csi13RLzp+3t9qArONufcVsbofQOkOhre1uerNTj MFwQNkJ3MD8YFTHiXo3RmuahpD9JdQKkJOHjuOw/zXSY7crn20PJI9nDGGBQY5OKjpbkPvdHAY8Y +a214k+GPUmkLZNYQDVNOZMzzwx52/fitQXlgIL2RedqnhqxcXSXaWtpGu4BARs29mNV+S2kneWI +KEjekVGc8ZpP5wnKDKZ965qPYSQteosufTLhWb4HualesNG0bQ9Wil0a8/iNvJGGck5dG+Kgo1R VYsM/PNPLO0sjA5Z9jn9IoGf5nczHHBHapOwu7OSw23EeJl5FR72R9T+WjSsf0qgyT/aqaFxKu9T HKv6kbgj96AzgO+VUoD2zVKS5AYbSPelJOTkEcUmVwx98mtBLxZmJAAHfA9zVpMqrzBAoAwQvalG YBBxg0oTM1o9uAGSTk571AytwFt2dF27+QaZzp6qbQCRUkYhHDgn6V9qjUkEvCkhieMjANaEt1FL plx0lp1qtqy6nFKC1xjgp8Vj5l9aQEEsMYyafy3E2PSmjBUDtih7Ex9A2j4oRVtFLCuY2ypHvR9l pJp00M1mXum/S4HagJKFHLEgGnduYmleaZthRcqM96zWk70B4banrWpWNzb6bNe6ZC49doxxt+DU t4x9U9N3Ou2dn05pn8Pa3b0bpsYBI7/3oXRvjX1T0d0xcWWiXMcEcrHAaLO2sEmmnu793uUEk9xI ZppPlz3OParNMjM+6Z4zhkPZxVSNskWNUZsDO49qoRekmFPGfekklgMMS/xRdjrYzqDNChc++Kto vWesdN6jctYR+nNLGYSze4pza6o9pGd/LYwEz3pqXkvXka4G185AAxRmzatG1iWwN0JdOt5pbjlp JgTtJ9xTyVkEQII/+I9qavNK52uQR9hVekP9X1H2rIvIxwCFA+DQWgWdUDEYEgZ//j7inSBUBD81 SYj4wDxzmtaVJ9R39jqbwyadCttBBCFMajH1f6qm/C/TNM6y6ktBqNw9ssBzE6nH1+xrDY1Me7AA VjyDS0ne0IW1cw55yvBzVK2J402OsnxGsNK6p1iTV7Vo1e2klYEJHkYH70x8cp7XqHXtE0HSIDK1 nbqd0YP1jFYfqUyajb2slzPO88MgJklcuxHx+1bBl8fV0/RbaCDpu3l1CBPTTUiAGA+9XZrrtr7V RcXAhS+UvLBH6YGMFR8VFrdiUxRSK2EPJxxj7mpzVdZ1HqKdZp2RnYY/lx4xmpvp7r7T+ktA1TQL vS4r5r9NqXTKN8J+1YEHp+ivqVhNc2SepBGcFzzg1Hm2eNvqUkjjIo2hX95oVjcW1tc74Lh97x44 B9qHfjUb5xKEKIvBwMA02FvtG3jJPtRNJnOnSXDlw6OuDGfb9qbepJCM7cuBjBpvllOUG45yaug8 b05GkZkH1ofoA5Fbg8A+j+ivE3o/VNA1+e307WbdGmtrqQ4ZwPbNabCyrILpFMkaqd4UZxR9Qg6f urWGbRri4hu/TzcIGKEyfY/FSRDO8efSw9pDKJ44bp4d47FQeCKf+nJqSbYMGZBuqNiczwqpXaqe /wA0/wBPle03SZ2MVwDn/erVCMcqjMwIkpSRnvyKSszsCHO5ie5pbSj08isgcbBZ1SSTYjHk/FSd 5pPpLDi7jmif9LKeTUI8sco3FhkcHNOYsRRZ9QMn9PNXQI0UcTtGj5PsKN/CrqKxhmlgItbkkRSn s+O+KBbFWyzEK/zipDVpo0023tLfVmvVT6kQrtERPfApRa/1e81GC2t7mUPDaJ6cCL2A+9R/qMm7 CBhjsferx45Vv1f6qOskMUseXy5BypHFXSGGmadFNrNoLpttq0gWR8/pU96nOrNI0zQ9caLRrkXl mVDeopyMnuKiYB+YV0jDYBJyR3q6gRnauBjvjiqHmjyNZap+dVtrCJo9p+/vUbcxTNJ6m5pFL/Vn viiyXDjJxgg0S3d9SkFtAB+aPbc21T/egbalbxS52FhjH01fSvy19ew2xjjLPIFPqD6Ac85q+o6d f6TdLBfeksrdvTcMP8iraZqY6eS/TYs0l3GY9zDOz7j70GSeLs+nR+IcUWlPCdPhs4lcW/CB8c4r CTMJFBTO/dzV13SbWblgO/uaKyxxLuzy3wKMqbZOoAGPmmupwGWyVFX6ifbvThWCt9P1H4xR5HEn BH3oG89r+S0yEIhlYj6se1Alk9SwjKL9Z7qako5vpCHsaaS4KkEbVJ9q0wq2tEeJjJIEwuQB80kg K4AIYYqrixEZBR92RVoQo5P96aCJUVsFu3f70N4i6/Q3NGH8yRgDhvg0qJvyrbnG4/FZDQrhTz79 qm9K6J1TVuk9R6kVDDpVgQHkfs5zjA+9R1sRNOwfADdqNp3UWoWUcmgren+Eu5d7Y8qxoIsq11K8 iMsK8bc9yKsscUMZbH1Z5+9HupY7u7AtwCqnGMdqbzTbpip4IoKZhJ9an6T3FUGCKCecfNAaQhto xuPuKyDTdL0i7tJJL/UTbSovACbsmi1DRXAZcrwuSKI0hBB25+DQvVSG3eKD6kLfqI5I+aTDNkjd x9qIcb/9XFWOHUKeKuVC/tViyoMnnP2oG00TEOq8hh3rPNN8TtGt/CG86RvOm4JtXaXdBqhH1Ivv n3rCXkBHHYUS5gC6fb3zIGdzjbn/AMUXZKpD6UW1suFwSacS7TAsayL9X6sdxUW52ys23GecU5ss 3Eh2RsR/UwXjFEPNB16PQNesZJ0kvbO2lEj2pb6JPtj4qU676pTrTqFr6zsYtOiAwkAGMfvWNxQ7 5ZfRIDK2RnvRDkIXf9XY1dqAZyJVSPBJGCw+akdIvNX6Rki1bTbh7aYMVWVO5oKxJZIjOo2ucqD3 qUk6omn0eLTDp6C1hcusn9QJqIjtd1jU+pb4ahqMxmmfuze9OdK1eLT2YtB6pAzn70yWIbSclkHY GqmXCD2U/wBNA9Oq2Mmj6kjx7r+4kUxt/wDgwO4qIARlVVDDAxk+9Obe3iEn8xNqEZDH3okrKcMM AKuAo9zQMzBuYMzYb2NX9HMwWXIUcM1OILpBAfUt2kbnaUGaaXN3+biWOJSSTk//AEUXbY3R9uuo dFS6RYJAdXklJjmk4yD7VieudNXPTk8lldAJPBw5+SaLr02nWOn6QmkX0r3a/VOVGzaftimmu6o9 5fxN6rXUjKC7McnNEMY8sf8AqWru2CwfufmihACCDigEEuqhdzOeCaA0TgRBM5+9DMbO3P8Av7VU wW3fYzYcHGaULlFOe6nj+9ARp3gnijRd6tgbqyq5totMhKhFmuZo87z/AE1jdtGuFEv1DO5QPapu 4uWksAx4K8A1oRf8MJ0sSmTdIr7jk8imCzCSXglqd2lzFHK6ENgjB3HvV0gRXLqAq1kNw2G3Af2q 7sMKMEj4o5RFTkEEHO75pMjq7pzkD+ke1a0ABdr8U6eZyoDEYHxSJWG5SOfbikLJBEG/UXPtipQu RfUYFT9Y+aqKNASz5JzgfFXD7lyoz9zSVQ4wPqB/2qA6BZJPrG4jsRVzAxaCVQS0MgZVHbIq0UTI fqbB+1Gil2AncG+1O6M16u8brzrnQ7PQtas4y9l/yZolwf71gjIFkyFZk9sUezhj1bU4gsZ2f1ki nl/Emmai0Ebbl2+9NJNQ0jhKx795C/NGRSEDtjb8tQQ4dsNwtKldtzBs+l7Ve1GSMSE7RkCllMzK oIye+aBG5CgAlQaNGf56ljkcc00mxTbvGzKcAiiGYRwbiBzwcUSbM0v0qMMcE5oE9o0X8vfuHzVQ Bv5hyO1FTMm0dwp/zSbeFi5zyPYU+gtiWxjYB3NE2T6ojwACFPegvdybisZHp55osySYKsmEB4b5 oAtfqOOBQ0cuyuNq4xihlWUrzke5of6FHOTSmbao5waKefmN9s8MblFbuPmo8u0ZbBxg9qIz+pMs b/QO+RVnH80+4oiyqznnsff3NOdJlFlNN6o3B+Mj4puz7fn7Uq3gSd2Msm1QpOfvRIKmn/n2ZLZc fVkZqW6g1nU10m00m/nDQ2/Ma/Ofn9qDo2qWdpp82+BpZv6JAf0mmkDJrfUNpDczDNxIsZJ7ID70 Q3gvGbccZLUdUIwc96y7xE6Y0To+9isdMuBdNtBkkByCf3rD3cbioJyaArqzfpH70pHHqhUOD71W n202qSi0t1LzyfSoHc1nHgf0dH1h1dNaX9vJ+T0xs3e4YLfA+1WFuoxT0miG7aBu+3encMe8gg4G Pasr8XobCHqy7ttKCpaQPtUL2xWK27BTkE4NRg5WEK4ccfvS0I4A559qsImbJzuFWjkRSNoO6sqd RupIV12fB+acPiUfT9KAe1CaTdGjcNj3pJmIjds5A9qIJ6YxkHgUkx55OcUNLlhajC8dyaKHLoko IVHWtAEmCpznj3pCNhCff2oU8r5bYhdRy3PtWRaL0HrevdPya3bWWNKi/VcM2B/b5osQFnpdxq94 lraD1Z2P6Vo+s27WEnpyxlHXgj70wFobeY3FvdyJIp4MbYo11cPdiMu7M4B3bjnNSCPuZyQu04Pt VhI8iAB9pB71eaEk4xSPURfpA+od6rQqXDwklRuB5P3qzdSsUe22CM//AITFAL4XIfGfamcqGZHR cFiGPb3oG95CrStIZl3scg/NN3eNLb1C5P1DcPtmt1+HWg9B6d4Vyavr1xu1dmIVM7iD/wDGtR3b w37Tywx7YjKduRjIq66Tfae1rUem7/TLc6JDKq7R6gfsTisQi1UaPepfQxRyPHICqMMg4PvTpYJW hCRAKuP0gVN63a9PydOwxW8p/iRUep9PANRWTdedd3HifHY30VtDp9rDEI3t4xguwHc1g98GllgE REYj/Vu/qpy+tWsOjWVrBYtaPCNrzb93qn5x7U2MolYF+4+KoV6p4yAaNA4Ix+nikwohVj3Ydgas ZH3AsOAPioH0F4UHB4zzRpr0yNk5I9xUYEODIeQewp3DF6hDM20/FA5tplBOU79jT+Bd7BSwfb70 zGFK85x7UaznWEkkZJozT0xbWUngGlyorkDgAf701nut5yDg47VSynCsTuAFEAFssWoC4TMTg4Ei EhgPtS7tL+5u1ljud2eC0hy396dRvuXdgftRIv1A/wD9mpLYnjDZLWUkbhlu5p5DaxxtvIAb3qp3 xyDgnvQEEklwg34Qn6qik6qiwR78rgsBk0saJLqEAlt1JiUZL/eq1WOORBGG9RAc9ql9N6mlTpWX RVgUbZDIbgfq59qDGFKRuVfK443D3ptIowysCFY8ZqUvreO4gi9MgMO9MzbsHw3BHAzWg2lt4vRg MasHGc5pP0sduMHPapUKSQGABPuPamlxCv5g/T+5ouzc/pbgHHegLlFx3b2p00AKnuPvSra3jklO 6TYoXOcUaAik3sBjt8U1kuFd9qKTzg4FPokSGRnQ5U9s1kXSnUOn9N6RqdlLYpdz3jblkdcmP9jQ YoNyttJwR2q5jIycg4otzexTMzCLaU/3q/5WRYjM2EjYdyaAfp7tpz7VZoywI9x2q271GCLICwHa nEcXHJ5+aBs0ZC49++KdQpiIED/NLaFVyw5bHakeoFwMfUaECdiMqpwp9qsm88ZwPmlMgcdiP2pU I2A7u596NByAnbu5Oc4FCBDXG1geeyinfBTlsH5NVZP+WuhMNrkc8iglYOhdWXTf4lNaSR2B7SHt UU1usMhRv7GpW66t1a7057N79haswJhHbioyRzO/OMDiibJY5ljx2+KJJJtlKkfSRxQ9pLD5q7xN 6oYnI+KEFkjEkAyd2PaiejlItnOe+BnFNZJm2BVzubhfvW1umtEh6Z0PTLy5Rfzl8hKiZf0n7g0Y t012dPnjGEcHPOMU9tgI7dtyAH71vrq3QuldS6f0+C1uIk10ASSGMDGT3HFay1bw+1e4eRLSz3BR neTgYouN2w8TK+FIC/ejAAr9LAkUO50K4071BdHZIO4BzihWTBY8/rb70dLD2J9oGc/FEEh3qQTl e2aTFErLwcZPAoyxpz7n7miwmNNwGMke9O4kEIOPempLR/UOw+KWHaU5C847VI6QoXJVmA5PuaLG u1CScg80gSCEZIHI5pILMBnn7VV2t3Ge4+au7GVQPbGauQApBHFUF2rgnihslBt+1Dcktz2ooO0c 9vvSGwvIOKISB8f71Yb04PJ9quSNnB5pESyAAyPuI9wMUCn3ekV9qZBhETj6jTiab6SD79qbAbFJ B5oLybiMAUMBywIHNWJIPDc0OS49EHD/AFH4rOwd5GVQrdhQSwc52hT7mrSzAxqQMZ71b9ABPO72 oQX0tqggnijRB5DgnGaUmVj2NwPmloFWRRjdjtUrYcihWIHcUKRwuMGntwg2Arjn3qOY5Y71wSeK jQU8JT6hgg+wobIACVHcf4p0Yl2gk7TTGT1G3MCVCHJrSU0kJhdhyT7H4oLRkAHdkinbX2nlcSzF ZPgDNN/WhEgZfqB4GaFUWUpg0HK5wSNtEmiYjvnHPFM7gkZB4BPFTtBy6P8ASoxS2BijBYYppuKy qVP0gd6dTgzwA7twqihMeDjcTSAu36cZB7/aqil9MlduSo71dv8AmY+fegOsWFzu/saRJAxYNnAo ZkaME4zj2q4naRfp9/aguZHU+xX5FXjuBuXB5FXBwvbj4pA2hxlQR8Ci7EMhJxux71cSHeScZqgy SNlUx+9JYkuARRdLsRzgf2paou0qRx3NW344HP3xSxII3YfqJHNA/tIbaWGL1pkRCe3vQ7iS2gvJ YLbDR7chhUcpAZXVMn3zV2X0yZQ209sfash4bqKT+XuKv+9XWcQFCYvzQY8rJ2qPkngC5Knce7U4 iljlH6zt+TUGwLjxk1qfR4tIFtY2ulou3heTWOHV4cbptgDfpC+9Q0sEUqBSxkUHIFXYoTtMQwow v2oaHvNTSST6RkE96AzFDsV92fem5h+hj2weKWi7f1Yx9xWtBRDRtyQaLEwRcgjJPNBkfJ+BVLGu FO7v3qh2yKCfY45PzQ48RSbmOaCWYoxAJxSXJ+cZFBJi2hniZ5CBIGwB9qZTOquUUYH2pAZ8YI7+ /wAUhYmL7icj5qQEG3OSpHPtRktbHdiR2DN2A7VbH05yGps7fVkAnae/xWQ8WKWF3VZo3X/Sf1Cr SOc99rDt9jQbeb6mLjnHce9BWdmZtv6vvVEmNU1IITcXPqEjAPwBTea/V0KlwGb/ADQDqaiQwPFv 2gEv2p0L7SZGXZZNHKBy5OQf7U0G65A7ntV05IUNtYf4o00LekZeCjHjB5oeCIsgDDVoBnkAJdPq b3FAgjnuXWGLiSQ04IG0jGOeTVQ3LW8mYV/T2OOQaCRm0XUraNY7rTZ4T2WUjhv2oS2It8b3yc8g 1Kap17qer6ZbW17cLItuMRoowTUS9xJLDvmUIW5ANZgvIijJXuKZyOuB7MD7U59YSfp/2pDWm45z wfY1pVQuhgbHcdsUMu4bJGRjtSo4vTb6R/aiooVgze/tUS9m0MSwvK4AXcc4Wim5J/ST81chHJCk DPtV/wAsZOcAAVSTRqGinbDZVu4b70e3b8yg9QlHQ/5FXFr63BXt70VotnJwDjFGoUX9Mq2cZOMf FPxhNyHB+TUS8mbdiBlt3FPI7lTn2Yioo7sFGcbj8UH6X5b3/wBqH6wDZyaWJcMeeP2qhXpqgxg4 +aQJQDtJ4+9U8m7+1FeEBgQM475rApWQ985pSIxzuGaEw9L9Qx7g0pJS4IycUSryKCPpHI96SFJz nJz7mlbyqjnmlGTJIJycdq2mwyMj70lwWU4PI5pZkTONhLD+rNCdtjqT71m+kSvh0jXPWGlRY4Nw pOPsa9cvDyNRo9uXzxGMD4OBXlF4V24HX2lCJd6mZSf3zXrR0PtOlQALjKgf3wK+LzZb5Y+nxfwr PrEAhDjvUygyo5qJsRhVqWRgAK+rx78Xh5eqDcoChPb7VBWbJHf3MoXJ9qyC8y8TY4xnmoGwuYwJ nZOQcV6sXly9NT9ezfmbiZz23HIrnHxH/wCVN9+K6D63nV7i5Kngue1c7+JUw9KXBxge9fX4usXx OfW3NHWrBXbJ/tWqL7H5tiOx962b1tdKzvg5OeTWr7yPMxZmyD2FeLl1t0/Fk+i8HauOTVAlWAOM UqGNQucmiMgLCvF0+usrEMfb96NEGfnO0L7UIKVzzkilBTO53Hbge1aC1Tk88/NWO4n9WauI1Ujb ngcZq+w7NuMZ96aHpwpB+o5+5pSkFSM1SptBB7Cr4UHB7mvpvnr+h6xGGwAM0lWz71ffsJHfFWQj 3FAoja2R/fNXCCTnu33q4wRhu1JYLv3E454FAvaI1wOaSCEbjPbsaqQYBJyAe1WiPOT7jvQOBEuV I7Ee9DnBZTg4Ue4pLTfB9qSjGQgex9qsFnTYQD+kjOfvS1YEfelEbSR80Pb7jj96bFbQ4Jq6jBzj sKrtVucH702LFiD9qoMB796U6bMY+qqCZPatAbDNKWQqOO3xSghI/akyqc5GBUgvv3EfHvQbguu4 ryKSucn7UfAkXbnPzikDRXdlGaWWKYxg/alenuk2qO3ekTHHc5+9UN5gS2V5+3xQmh7ktRmGUGDg 0AEgsB+kj3oBmE9wcj5qgoK7Rk1ZGKAZGAPY0h3bBMQ3OD2o0sQHQhTkKefnNBeY2+BGSCe9UGKh mZdmeSB7mkEhnBIyftQ0v3Yt3b3JpJJPviiKdgx3+9IkcZ7YxQ0Co3HJ5P2pQGG+1J37jgcGlbvp x70IIijB+atIMj9WKT6gYlQc496GzfXtxiigywvkferGIqoJG4f6KMkgcBuRg45oqyRox380Ecpy 547expleN9XBz9xWQXTQtASoAf7e9Qt5FgewXv2oIq4UeiSWwfvUbYFlvFJO4Z7051G5KIQVyB2p np0mZsEe/Arhl3GsW2NE/wCTHj9JFb98Ihm8s+T9TA4+Oa5+6fkxb2/bBPat7eEc7Le2hU8+oB/v Xhzmns4QfPOgPQOhSHsmoE//AKtaR8KljuL2xQ9iwOa3r55oDJ4X2EmDtivNxPxxXOHhHqyx39sJ TgBlG7PtXOTp04r89Og/OTbyf/Y+RmJ/+VIrHHuPiuOPCq5ZrNmK4DYArv3rjo0+KHgpqGkWxE07 oTDk5ycZFcJ9B6TPDdJYsoEtnO0LovypxzXlvdXL26C8Mb3VoNdtYdODNIrjaq119N+c/gjlcfxA wnbj/Xj/AOmtR+APQ8lpbvrF5D6O7iBT3I+c1D3fj1Hf+Myada3IfRrEmGVV7mXsc0+lzu+nPkxk t/EHVk6mBTWFu/rE3fHsP8V2p4a/w6bpWFrURmFo8OB8Y961T5lPBsdXWVv1XoduralbjfMEGDIv +o/JrJfL4LmTo+YyxNGDGV+oYycc0xiy/wCOxjOrP5fhfXKXNtpAvFciQqTu3e/vUBq0/hjFc20X RkgS+ZwSkBzHXH+q9H61pPX2rvc6JdyBrqQrL+XZlALd62R4fO2matamWyntisgJc2zIP8nitydG M1end9zMYfDr1X3HZDubHfAFYH4jdNWvXXRmldTWMpMmmwghW7lQf+9bB3rN4a3DgblNm7fP9JrX /l/1uHW+lpdIuU3wvk4Y/q57VNW1jd3ahvMsi6l5a/X3Z2+gSf3PNct9OrFa61CkMnqbFUsfvgV1 t5sNOXTfLp1DbwYCxGMqB7DeK4q6QuHmvbdo8vuKkke44qa8W+O9u55tEs+rfL9qFlfxetbSWkhK MPcDIrxyxHpuqaukUZBjlkjjJ7n6jivX3VOo/wDhTy463fSLgW1mxBPvuryB2pPqM+pLJuE8ru8X 7tXbirhz9UL0JJII3dzvPBB7VlfQ+kTTajEwX6T71jOo6isssEVvHlQfqNbX8GdMku9Rkkl+qCMf TW8/TGPfTbXS8BgmtIjnfuHtXc/hBpT6H0RPfTN6Y9BypP7ZzXNPRWjaXe6hZxSKEnYDBx967Dvv 4NoHRBTVZ0tdLEIWR2O0YIryzG27e/LGYccav8COpIeqR1Dpd7MZDdM/6jyVyRx/mtDdQeHkvSni tf6KhCRLIs0be5DV0P4cz+E+ma16/TuprJeSHYAzlhn9sVivmm0aPSta6f6os1b8zPJ6MzL+nauN tbk04W97bD668P7zrLwjj0W0cG4OyRd/2B4rWPhB5fepOnupbW41YRw2cDbiYzhj9qz7Xuu9R07w IudesGC3tjDu3ewAHJrg7qrzv+JHVVq1rZ6pHZ2xBRniG1z+xHatzHfbNy06h83/AF1p8uu6Both dxXd5FuaeONgxi+N3xUL4GSxXXX2nyD6JQ2QfvXLHhZLJq+tTahq11Le3Uqs8ksmWYt7ZJro/wAD LuG36zspZGIHq/TzVnpnHv02F51YQ6dIvJ9RErr/AHOK1z4QaQlz15a252uBKC+744rYvnhuIrfQ +mbh2ClJtwJOABx71pvwp6qi07q+K/EqupcZYHPFccqcev2RuT8Qm/8A4R5ebiOFpImaWNFKnAAz jmvL9Q0Nsv1CXOAGc49vmvWLzh9IXfin5adYttJtzdXhWO4iVOTgHJx/avKPTNM1Qzrp4sXluc+m IiuSG7dqky1e2u/LSLv9PvmDTXM5lQ4wrEkAD4q65EYYZIHfFO+p9A13o7UI06jsJtPgm/5SPn6/ 2oC+mInSIH9OUye1euWa6YsZn0D0l/xBcxtMmYc8iupPDToR9Q1vTtGgs1CSMoaXb+kVpfwHv4Lb 1UnCO5jB5+a7M8BOpNJm6ut4yyQykBVD/NeO5W1vHDXbaXUeodKeXPpSK5a09SeYiOONE3F5Pk/A rGemPEHpXzIadd9O65pUNq8ykICvJ/Yms68Y+tOh+l7S1PWUKyW0j7UkaLcAf3rWNn5h/ATRbtbi 0vIoZ4/0vHDg1uM5f7aM6w8FLTwe69j0dVWS2f8An27gclM12F0HoGnap4ZJbtp1rMZIyrKUGeRj OcVy740eLui+LfXOmah06Xe3tovy/quu3eSc5rpTwg1Qx+Gd3c874Ym7/tXXbp4yYNYTeY3wx8IN Tj6QOnC8u0fbNIqKwDH5yKxXxI6T6K6k1qy6h0iK2jku2y8MPbHyRXFfXOqzar4sdS3khBke7LEf Az3rpDpS6xoWlqo4dQVY984+axdyOcx83ZvSXSeja34bLpzaXbuhhKH+WCeR3z81qG38RvCTobUR 0XeaRHqV2rFZJPSDIp+GPtW0PDHU5ovCm+vI3zPFC5U/BCnFec/SN2+u+JvUM92xeea7kLEk8nJ7 VJbVusenTfVPhZ0XqfiBp0vSljbWzX5G9bQZCD5rdvUmieHHhB0vAmv2EF+7ADEkYaWQ/tWpPLfa Qw9e25nYMyowjDc45oXnQFyniL04/wBQtfy5HP6d2TVtsa8ZuRlfUHl78LfMX0LPc9PaRFo16ATH dQJslD+wYZ7ZrmTpnwnPTOsXWharCttdWMvpT4HLDPeul/KZeXCanqVojEw8FsHg96wXxsVNL8ct RVjgXJ9VhVmVxqzjlz7bh0rwE6G1vw2jeDpixa8ePi5KfXn/AFZrXsd74AdMXMXS+r6Xp99qC/y5 biRcgt75OeK3Z0rqx03wTub2E7mitpSpP7V4/wCqarJqWv6xO8rNIbt8kkkg7j712x3ndR4+aTDb c/m88KumOiNe0vWujbiK1stRmKGyt2yiD/UK09E7siMx4K5NI1G61G+a3W+ne4jh/wCUJG3BP2+K te3kaC2S3HqFlO8j+k/FfRwxsnb5N99pjpjQp+p79LSHP1t711T4XeXzSLm8trB0D3kuN3GVFaT8 AraE68285kxld3zkcV3P4D28E/Whd0AYRMQCPcCvLyZ2V9P8bilx8kjqngh4ReH3T6HqrQ9MuJjw DKCXf9uRWufETyZ9E+KPT1trvhxb2+jToGb0ADskPxj5pXm7u3/+uDpm2kVpLZrIkIDxu3HnFbJ8 s+qzmTU7AZMCYYD2U/avJ+zLb23ilx2578FvAbQL/quLReptOjubiN9k8Eg9/it2dX+VXwf6c1F9 W1jTbTT9J9MKlmCQHb396h2uTYeZvVvTwoe6Utj9qhfOHqV0/iLo2nNIxs3iDCPPG7FW8mWvbHhj NdMc8WPJB4f9Z+Ht71P4evLaXlvA80cERyJce32NcCwLdWoktblDHPCxR0fupHsa9cPKq5uuiNRt pUwvq7SvtjGMV5geN1kum+OnWFnbriL825VfYc963xZXK9vJzYzGbYsl3KsQ9KQxso7jvWUeHR1f qbWLW2a8ciOTIHz9qxUsQWGwLjjNZ34IXaWPVkCy4U5GMmu/JuTpy4bPLt3h4F9CyXOvWe+NHhhU OVccZHvWJ/iCePeudEatovR2kSNbR3sBuppkP1EZxtrdHgVcxHWjGGAPpZA+eK5J/E3jaDxl6QmI JR9OYHHsNxrxSd9vpct1rTEfCHzM9ZdCak0FrK15FeYX07lshfuK6v8ABDWL3U/EEajPMTeXqb5w OFJrzy6OkcdR2M4k3Rept+rsPivSDwAk00ahpp3r+beIfuaZ++jim5tgnmq6i1a38dtM022uZ4rN rNHYRk4BreHl66p1LWbS/srtTNBasFE+exx2P3pPjRF4WR61b3PW97HZaisY9NyxVtvt2BrE7jzV +Fnh/wBPx6d0peJq94DtjtYFKsT7F2IGa5Zbl3WtzWmb+FI9LxJ6zjVvoMu/b8HdXMPjZLs84ly2 39NvDz8/SK6B8ueoza/1B1BrFyNtxfKJWQdly3YVoHx52webaaVuxt4j/wDqiumPccuT6de+EU7T 9MFmOSJiP9q839G8WtV8OvMjrc+mwR3Mv5+VfTl/Tjce9ejHglKs3SbMrZDTE/txXl311ay6b5ie oyxAIvy2B93reOtVjLfnHo/4TeInUHW/U6PqSxW1sbXd+XiP07vmuEfxFpTL46WqLG5SKMEbvcn4 rsjwEvNms2qYOTAAc1y557enJNW8wFlbuSfViQrtHODXn8tR7OXjnlI0P4UdA/8AEGpQzyQbViYH kfqOe1ep/g304nh74dRXN1GkMsiq/wBXB2nGBWlvLX4GRrLaXNzCotLXEjkgEM47A1lvjN4iXuud V2XTul2V2tjZzoZZUiYK5z+n9hXKW2+SeMxnjFfiAYm8sPUB5w0sJyK8tvDbwyuOvtQtNNjmaB35 Ur7jPavVfzu2d3e+WjWobO2e5nYRfyo0LNj34FeZvg91Y3Qms297JC6NC210lG0g5+DXf9mvTw3H efbpXpz8NKLqnQHvIdbe0vChCrL2L+1cZ9edEan4WeIGq9KantfUdNlMMssf6XHzXpt4ceebw20r QSNe1BtOuQRkMN24e5Arz08xviRpfif47dUdTaHzpVzKwglb/wB3716+HO5Mc0mMYNE3qZ7896KJ dqkE4PxQ7eRZASv0cDNVKO23kg8mvY8VTGlaW+q3lhbRENJJJg5r0+8pvgxpug6VBczWkcrIn1Fh /VjvXm/4WpG3VumFyMGUD6v3r1+8D2i/4ZQRgdlz/ivm82V/ZI+rwYT9W2pvGfzRXXS3iTa9I6JG IxCQZ5m4JOeVx8VmnjD0JpvmI8DLgPBH68lubiKVl+pWUHIB++Khm8Duh+uvETqDUNdf179JCVj9 XYUGe+f/ABWwvDmzi0vQNY0a2b1bCy3Rwktu+kg+9c5vbrZNOePJd4R2dnHPfXtlHLLan019VeVw fas58avNBL0B4l23RmnW0IlRY5bmebjCMAQF/wA1l3l5CImvwhQrLdMSB7c1jmreAfSPiZ4odR6t 1SpnvI/TSApMIyoA4OK5zGy7Yz/qJTx28K9G8x3g1PL+Qjl1U2xlsZgPrRwD9OfivKHpvpC5k6kb QZlxeQXJt5N3ZWU4Ney/hRp6aHp+paRDMZ7WwujDCxOfpxXl7pdiq+YrqhWx6bazMcY995r2ceXx rycskzxr0L8r3h/D0X0Yk0jBZ1QK23hVXGa83vNH4gav4sePOr/mLxrqw0q6e2tkz9AVTgEV6hX7 fw3wR1+WD+W6aVMwZTgg+m3P/avIXpstqGtQTSZZ3umaR25J5PeuWPWFr1+UvLMf7dz+Sfy96ZLp q65rOnxXisNyrIvCt7VtjxN81mneHvXdr0dpFjFcTxsIpg52rGM4IXFZZ5Y444fDq3WMADI7ftWu bnyw6J4ndd9SdTahqDRXSX0iRxx90I/qJrzy3LHb054yZ3FOeZrwS0TzB+EdxqdjY2j6+kIuLbUG GHQLyygj9sVqryKeBeh3Wg3ev6rYQ3lzbzmCNJhkqyn9VdKeHNuLDwwvNK3+sLOCeIS54YYNc2+V PqnqDRut9V0ixsnvNOluG9VBwE+r9WfmmVuoxMe7I2h4r+a+28O/ECDpHTNNS6li2i4klyqID7Lj 4qa8ePBnp3zE+Er3N5ZxR6kbX8xaXgX61bBIUn4qY6+8Augut+qBr2sxrb6wyqC4nVM47ZHufvUR 5leoNc8MPAe6XpDT2v3SL8tvT6jDERy3Het4Sz25ZWPLLw71K66C61CeqRd6fdtCso7ZU16xdHzW vj34JPYapMsq6ham3lkT6iCR+r968f8ATJp7l2uLgF5pJneU9mDHvmvTfyMX8k/Q8UTtlVQkY7Ve TLWcb48N8dv9PL/r3pFug/EDqPpYyF49LvHhjkbu6g8ZqMjjIZcH6viuifxCuiYejvMMk9kn8vU4 Rcyge7Mea59C/wA4bRlWHDV7Zenmk0Q8ZJzSAoGfml3LNE2FIc/ANAWQ7ssu0/Y5rXtooRnHbOPm rE98e3xSstIuUPFJClSdxzQg9vpyanJbWzOYyWDFvnmvWbyc9BdPR+B+mSHTra5kldhLLIgYtivJ yxGb2M55CZB/uK9d/JUQ3gHo3PPqOT+/FeHlt8tPVZJjtBdbeMvgxp3iLJ0NrmgxyaoriOUvbD0o ye2454rUHnJ8jXTmu9HXPW/h3ZRabqNlD68tjZ/8q5j/ANSD/VWJeN3gR1p1d5ndd1Sw0eU2t7PG VkDfSMDHftXbXVHUdl4U+DRm1uaKJ7LTRC0TsPrfZjA+eaktcfrp4Z2kVzLE0ZjYTK22VCOVI7in x6d125Rp7bS72WL/AFRxkr/2rtjyi+VDS/FfqXWepuoojNoaXTyraqdplZiSpz8D4rpHxM8w3hZ4 I6lb9K2/T9pq13bYglt4IIx6OPZiV5NW5VcbJO/bx+a/Pq+jc+rbzR8MHUqf96tNLubYA6sRkMw4 zXrR44+XHw/813hH/wARdO2lnomt28DzWt5awKmCoyyOFHJPsa4m8qXljfxl62fRtTDW1pppLXbv yWUNjA/eutz1i6YSW7c8WWmaldRbYbS4nbkl4kJA/wBqi5tSktJ/Qmgmt5gcMJkI/wDFe0HWmo+D 3lB6CtIb/TLCNHO23t5oUeedh3OSDgVzX4y+N/gL5h/DfWbKTSbXpzVYFL2VxHbokkkg7cqBx+9c 5lZWcs56eevrPeoVjjx7K/zSPy9ymWeynZwPpMUbFf78V1/5J/J3beMF9NqPUSTSdP2j5EqHAmbO cV2l4heJ/gp5fZ7XpeTQdJur9AqPam1jZ0HsWZlrX7JUyni8XF1H+c4YsJDxsII5/vT22sJJ1BeO RTuAwFJ716o+ZLygdFeZboBetfD21tNM6jhh9RI7KNUjuQBn0yowFb71yD5MepOjPDHxQuj4lRwS W0bPAfzUQlWGReOQe/Nc+S7x6deLkkz7dYeR/wAwfhz4f+GDaJr2rQaHfQEu814u0SLjsDjn9q83 /GPqjR+pvG7q/VOnzu0Sa9cozcb8tyR9q9tujtO8KfGTp+W40fQdC1jSyTE8g06MA8dgdufevGTx v6P0npDxy620nRbf8vpcM7enE3PpnPYfYVOPeptrKzLkt1prPVmhinMUSemvfeynvQ4tSks02o5k ZwRla9UvI54N+HHiT4F3NjrujWGrX8jlJy6L6yqR3B7iuEvNF4D2/gr5hNR6U05ZBpsiia03HPpo 36V+9dJn252ydNBzFrST1Ll1i3nICZP/AGo0CNJBJIjpt9jJ8168+XLyZeGtl5fYNS6w0iPUp76z e5ubiZBuhQZJ2nHB4rkDy8+Sqx8dPFfqu30u7ax6N0y9ZoJ5l3iSDdgKPk0/Z2s1d1x6wN3GJHkl jZeNoU7T/tVGa2ikRFDcjl145r2j6l8uXlu8FtO0+w6kt7WxluExGZ2y8hHBPY4zWqvMn+Gv0N11 4fN1V4UhrDU0i/MiJG3pdx4ztUY+k10lYuU+nly6Arlc/wD41KjgkRS6qG9iTTm60K70vUb3TWcz SWjbJzjlHHdaoE/lScdzjirpnGyoq7jM11GCxiQjkirppzzbS06xrngue9Fmt2Z0LfSFOe9b68qH gBp/jf4itper30NvZD+bIruFBUd8Z7GsZZ+Pt2xw8nPNx/6bepjYFP0uQdpqre9a4RHmQgMdpYD3 r161byn+VTpmVND1edHvQi7lF5uzn7gYFaQ82n4a+kaB0O3W3g961xYW8frz6ZK+8lACTIrfAx2r M5JWLqXt59XURtrqOKfIjbnI5oc0AExWKMyQD+s+1bM8DfA3X/HLq6z0HRrdpbt3xNLIMrGvyfiv S3on8NDwm6L6Rjk8QLh729x/MnW5EEYPwPmp+1rKeM28greIPcZWZGjB+oA9hT2aCOeI+jztPJWv Q/zFfh7+E9/0Bqer+EWr+nrmnkySWj3IkSVRn6c4AHbvXGPg74EdS+MvU6dLaNYSPqO8pIUbCJt/ USe3FdPOJjfL6a0MMMLjLO2eM+1JjjV5Nv8ANwM4JHBr1x8O/wALDw20bpeEddXMl7flfrZJhEiH 4ya1V5mPw5OielulpNa8MNVaXVbMNLJYPOJQ6gZPI7VfLc2lykunnak3qxhlikCrxj3Jqri7EjbU E/qYB7cVuLwK8t3WXjz1QbTQbL1WhyLmRsLHHg4PJ4zmu79P/Ci6Lj0K3TWeo2j1aUBpX3BACfYD /wA1z8+9abupJXlnDbhLNpC7EA4O75oM2UkVTvOfdewrr3zV/hw9ReAuht1P05qT9SdPK2J4kT67 fPbjuR96v5RvIanmQ6V1LVdR1xtHigPpxIqbj6nyftWtmOr25GKJAFZpGOSKeoYRg+ru5xj3r0VH 4PNlAHF34gxgOcRM1vtJP+a558zH4fvU/lla06ii1A9UdPysIpLqKPYYGPYMv/ms22Oe5vTnaLQv +ItUt4LBZJLlpEiRT2LMcV0N4sfhyeJ/hz4af8d/nrO7063txcXlhGT6sK4zn4rcvk28jVr4k9L6 X4g3PVENr6lyWSw2AspRvc+2a9IvErw3TxB8LNV6Pe9a1W9szaG6HJHGMn7fasY7y7azsnUfPPpV hDO9pLcyRi2cB9sh71NdaL03t09On5xK7RE3UcZ+mJviuxPF38KjWPD3pK+1/S+v7G9WxhaVra4g EeVHwTXCGmlSHkMSRuWZH9MYBIOM16bhrHyYmW7o5gtN9qWYe9IltAVwAQMYB+9O43xAcdsUp935 X/ll92ADnt9657dPHbJ/Bvpy6ueqdPkt8O6zY3/BxUR4kaLrcniNqx6nkf8AMRn+RJ/SF9hWR+EH h71Z1d1NBZ9Gw3N7es43GHJVWJ5Jx2/euxb78KvxA6402O91nq6C2v3UOYWj3sCfYn3xUnJL0zyY WPOtbf1VO1lVV/SAaDLxuyMsvcVurzFeULxF8tV0Jddsxd6PJ9EOo2y5Rv3x2NYx4G+DureOniHo vSGk3Udvc6kWH5t03KgHfIrpcpIz47jXEInYjlUx706smaaQKrFzngD3rsPrf8LHxM6N6l0uztbq HqDTb+RY5L+EBRAxOOVp94ifhU+JvRGiXGp6DfW+tTQRmSSCMBDgDJx81znJtn04znASQKGJOQMG qm2W8ylnxx/mtj+HPhTq/i7ra9HaVpUsfUyMySbxgjBwe9bO1ryA+MfR2t6bp7aAl298/pW05IZW c+x+K1cpGpNxzJNJbuyqdhdvb3p1Nrmr3GntpbXDixQ/TCR9NdK9bfhteNfRXTt7rEWk2t/DAhnu IkkXeqgZbb+1aQ8P/Czq3xT6jt9G6Z0ue9vHb02g28qffcfb965/sn9NzHy7YUttLIF3OAB7j2o0 MaSxMPzERYHGAec11re/hh+OH8OLw6VamVhzB66Z/wA1zD4leFnVfgrrtzonVWhTaTqERwxkX6XP yG7Gt43yZ12hJrSZpAikZ+fahQs8rFAy704IBrM/DPwp6t8XtfsemelrX89q90N8anjAAydx+K2R 1J5FfGDpzrDTOnLzpZpNYvozJb/l5QySAdzkcDFXLLxamG2jpdLQWTTrcGO7zxH7GgxTTAAcD5at 6eInkZ8cPDfpu81zXuk2fSoF3SSW0yyNGPuB3rn2yu4rhjDtdJIwfpJ5z96uOW2cpIcuzNJ9JX1D 2pvcNPZbQRumc8ulLWPfEzDj2H2okkjIinbucDvW2Uj/AMCX91FBKLy1ubiXAjt3k+sfYD5qupui dY6cS0fWY3tVcgop98UDS5m/jFjqZkMctowdF9yR96nuqOvNY8R7pE1qaN/y+fysaLjb+/zVlsZ8 YyXRPMp1F09pdxpuntBJBJD6QWXnHGM1graqbrT5oJLctcTyGV58f1HvTXULJdGtopZYhGrtt5Xv Ro2K4YksCMgZ4paSf0IkW2LB5btk0lIwG7c/enMcitkgYGOeaPplvHd3IV2AjxuZj7CubQFvZmWK fByEGfvTSNQY0ZgcjkLTi2vILUzzTSYRWK4HORVRSxXC7k7Zzn4qwPdF16/6c1WHUbKCCaWEEKkv vmm8mqy6xrF3cXdu8Fxcv6j5HGft9qd2UsNvMJWT1No4ApnqN7JPKzuRknAAHYVdBMjDP0nt2pKk lACB+9DRwRkYJXvR1XcACME/FUWkIxgjOPihI7FiduFHvSpMLktn4xV5rhZotqDGKzsBmKTRvGCd 7DkVmXTXUnTVn0O1hfaXJeaw6sqTEfQh9jWDA4kH1ZPbH2p/aKnH8z0x/jFa/wC0RjxTQFNzmaUZ 3E/vVpQ7HDJsb4p/qsMSzARTerlcsR7VHSSlWUkl+ME55osKS0Zk5/ST3FCkBBK5PHHNHW4Igxgh c9wavDAZT6uGkU8AqM1Be2heOwabciksAEHerWuXuCVGTjjNIuGXYEJ288/OKzrwou9A6e/P6rqe y+vACsNq3Ix80GG24ju1BVgzKSCvxRLmP07cyRKDMOBnsaddQXVjd61qGqWMItUuWB9Edk/ao2GY PHsJPJzmqBvNGhikMZkmByR7U5fUI7u4Jd44ZfZPfFJjjkOfTUMSDgE1ms1103p/h4to1kt1rMr+ q8mPrQ/v8fagwibaSMH+9KOHOexHxQord1jaZhw2MD4o23ZnK/UamhTDanH1E/NKbYEUkEMe+aSV DIPt96pvq+4qh1+UVrUS7+7Y20MxKjqjEgsMg1aF/o2kHApzAUS4V5wcR/04rAbhghdUjDgjH1e1 NGsBPEWcjaDjH/ajaleepKxgX+QeWwOwp5p3UFtoUtpfxWy3MEEqtKrsG4zzkVqTyS3U7Puj+nr2 7606d0i+S406G/uVTMi43xn3HyKyPzLeHFr4XeKB6fhObRYVmM5/UwPtUz44fxzqvUem+tNH9MaS sC/l2g4MRHyK1j1RqurdXa4+o67cy6hdemI/Uck/SOwppJdmMDrFbhoiCp7U8iur+8ghtrSXfI77 UjbtQIkVYlhWPCqOPvSuLZ1kD7XTlSvGDWWkrrXSWrdJuserRx+rIoZSh+lhjPFRMSH6zwoxnig3 epXt9KZLi6nnKjC+o+Qo+B8VZJJ4Yy2wPEy4Jz2rYkYblbDSY5o7gBbolFjTlmP2ppb6VfW+pR2i WEs7zjKrs+pqJ0Trmj6H1XpNzqtvJc2Vq5cIRkEn7V0J4hebWx1GxgHT3RdrZ3VtFsS6MYyeMZqy dJMu3Op/lzyRMhRlbayEcq3wacBgjbigkA9qBd6pfanfS3U0Cb7hjI2wY5JzRRHJFCh/Tkc1ir0H LJ67ZCiMf6aVGAoyRjHcUPKlie9KYNJIdnBPfNQZB0ZZdOagmoPrIkT04yyRp/7h+BWPLBCkLBU2 /U2F+BnijHTpSUSI/wAz7GlGJoGIuBsf35q7SBRRkDdjOfaivAp2uFyw5yKQZNoUKM/3okZec7M4 3dsVFILMoBZOSaJeP6RVNgcsMkj2oJuZIZthA3BsEGkNPI0rhkKpjhjWuxJ9NWNv1Dqf5e91JtHt UhZ0mHZmHZaZSwiK5lQTLKVOA496aoFYRq6bgO2e1V6YMxaP6T8HsaQEuZd8YypLZxhPehJEzfSU IX4Pei29/DZTbpIjKR2APvRk1BLt2Z0wx7Y9hVDNbJCS6swHuuaq7smiaMBRl13D9qs5YOQjcGiP I5kiLHO0bRz2FACOMBhngCrOwDER/Uc0VkMjN2oDDaCRxmjCyMY2z3qpJSVxnB+1LIBQMCCDx3oL JuBIPNBRLbAw/vV2UmLczHA5wKtEcnae1OtSV4IfSChARkn3qxg1WT1+ARkjsKSYmCgDk0jStLOp 3McERLS54IbHP3o+r6Y/TV3JZXjb7lRkbGyMH707FobS1Du97LJC23KGL3NVpukXmtLcG2PqJbjd Iz/0r96Zy7ZdrZYEDgE1JafrI07SL23hVllnG12B4YVBGLGQHlSUAA4Iz+o/amawSm5EqoQ1HsoV ChZOWHOTRZZiHOARj70CbeJVc4Yhx+qhXCIzFweSO9E9bD5Hc9zV5IXLIWXgnuKCPvoPQMRUkuwJ NbO0TwJ1XWuh4+ptNuIrwbd0ltEcuv2xWvbmzDyqwY8VlHQXV2t9I6m93puq/k4o1/mQyEtG4/8A j2z96RUJYaQZ7yeCUFJIz9UbDlD8GmOoRGHU/SjU7FbBJHFT/V3Wdx1D1HNqrGCCSbG8QptDYqAk kFxeGQyZLck5oHV8FjkjVOR9qCrbSfcVZ2ZnGTxV8HsO1EKkCugxgNVhjCCXBUchfikOQBuYc04s n9P8znazMuEVvb9qAbgOQ4T6M8nFTGmdUxadKsSWimA4Vyw+e9RUcytbLHyHxgim24qeBk/eglep dAgtSdRsbmKSN/q9JDytM43XYpZdzEZyfamySbTuIKj3FXYj1CwJwBxQSdpJpD2VyNTNz+c5/LrG PoH71HZKR4P6vn5pK/URySM980tSrMR3wKBBkKsWJJ/6aVJKZc/Tz2AqsfX9J/enBBKjKgEe9AOR GIRZGJx2HxQrjakWI+//AGo53LkH6j80yuSRwOx96DLvCnre36Mvbv8AP6UNVsp0KsFGZEJ7YrGd WkWbVpnsYDbW07mRIWHKD4qd8Pr7SNM6gt5deDDSz+v0jhj8c1H9UXVtf9V6i+lAmwkffbA9wlA1 lgFwI9xy474pleRG1uVkTcB2YjtR4ZGi3IVIb3JqoZyW/LoRh25L80airoRxPEVkBVx7fNBe5ENy E/TgZyfY1tno7w103r3w2uktbiJeqLWZmjgJCl1rW+u6JrejXEtrqOky27xDDloyf96aNK0jR7fV JkkurwqC/wBXp9zTzqwWNn1Kj6TbG5tAqjZKpw7VDWOnbrMzLK35pnCwQJ9Rds/ArqjxCmsPC/wt 6e1K80W2i6xuo1At3jBCgj9RHzVkZtkc+zade+iLuawa0Rxu2hThaHpRjmguhK4YEcKM8VkcnjX1 MtxJBfrYFADtiktNuR7d6edG+M1tp4ki1LRbKRVYtuWEZbPsD7U7PprS6Hrlnhb/AJTcg96Ja3KS oA5zzyBUt1p1NY9T6tNc29smmoVOyGNcZofQXTv/ABEs1vFHvuUyxUnHFXR9GFxcetMEz9IqwiXJ wp3HmldSaTLo9z6byjBbAK80i3JQDBLDH6qAoRlP1/TijJdrboQYvV3dvtQSS+AeRS0i4OGz8UCk dXUEgAe9FjEW7A4X/VQBD9LDOG9h7VeKEyx5Y+ns5C4/VTQe3EEIgeRc5Wsg8OuitL61vJNPub82 GpSjNoCceofb+1Y8pV7XBYF/9PzV7rUPXms7gA2t3af8uSPgipAbVLa96N1y6tJGQz2rlGI7Eimk xfUGN2dxY/FD1HUptUldmVpbiTkuxySfmplI9Ks+nIEIki1IqfzBZsh29sD2qsoeIFDlge+aeJMr Z3DcD7Uyt95IXkA+5qTk0G8s7aC8kiYWdxkxS+zY71F2LF+RiWRpiwZl2gDsPvTRFZn2jt7feiRk PlWAdT7/ABVpEw42nBHbFVC1WWED1It0ZPcUu5nRZRFGckjNEuJ572FEVwu3vgYzWW+EeiaJqMWs 2OsyIl7JGWildgOw4wfajO2IQYPJOCPiiCUO21mbae5FC9B7RGLMHO9lGOOM8UiN8jg455og0ocB VZ2dAcil7tuSRVZD4AbIq6AAFf1Y70XYSqe7DC/elGMufp+oDtRGkBTA7Cho5yvznkUXYUpBAByP 3oLvjsc5qV0+OyuLsrcE7ApIP3qNmW3nDKqkAHAxRQ4mZ5ABk/vRJMLAyHgtxzUvpc9tNLDDNEI0 BVQfc84pfWumpp3Us1vbqGiTbtX9xU7YM7Cf8lppQxqwJ4B701ujFcXsE8MJt2UfVj3pzczEbVCq D2xQbS6ht7lvzz7YgM5+9UCuLl5WOQxDN3z70Z96zootpbhyBtSIZY1LdK9Mah1/qwsdKgMdqDvl vG/So962LqvVujeGUqWWiWUeq36jbLO+CFYfFBjXSHhT1h1Cq61oqw6WLCUNtvjskZh8D3FdD9La hpmhwXdtbrFN1jqlvsnS3xtUgdzXLPUPiBrfUWoGa4vprdgf+VayFAP7Cl6bfTxTi5jubmG4xj1l kIf/ADVYylvSQ1u1u7XWLy3vuLyKRhLnvkmhRERqD/bFA3TTSvJM7zSOcmSRssf3NOoU3naVxWKS Cq2SOePtTi2IjcswDe1UkIGBkAferOgIJz2NA7nhVY927g9lFMZpMw4AwTRFfdkDn7VTRbu3J+K1 oWtIz6ZxkAjtS5BtAwOO2Ke2Nn6vHqKh+KBfQ+gSu7JHPFAD0ikTYHDggmpOw8Sde0PpH/hi3aKX R3Vhhz9aZ74qKkmzsUkn4prcQn1lIUBcd6aUOEKkIRCSB89zSzuTlBhR3JoMk4RSDwfmnsLwTWTL EjMzc7hzUQwkmEhP1Y5xig3C+mQuD9X9VLntcurMdmw1a4lW4JkDfp7Cq1DOUPGybgACeKqziYXT k5x7U5uVWVIweHx/im8RZZTzge9FnoxlUIzCEnd6n1D2NGiDksoOVJ7Gk6iWimY28RkYnOBQEv5C 4Dx7Se/FOxJEtbERKNxKnkVFXBkWXa2Vz2OODU3oWsRWEsv5iFZVZSBu7g0aXXtO1iy/hy2XpXIf IuSe2fbFBB29tID9XKfNFT/niMEYHc1OdR+H8nTulx3Q1eO6kdd5UcY+1QEDLe2ScenNG2cgfqoL xXDSuxB24OMe9OY52P62Le39qalWD52fUeaPAxZgGHegLuXeBk7T3FOosAAA9vc032KDsA5PajIp hPphfUagdRy5QgjB+aIoOV3cZ7GmyiQqS8Rjx2GaU0rNge3/AGonaTVEVdwbdx7VZdx/5YIA/qpo r5GDk/tT/T1ypO/K0SnNnEiRzFzg7fp/eixEmHfJ8cUwnm2nAOSOAKdwPvT6jtBHamkDD7+ccml5 9Nj8UN1CuoTOP3ohBUbT9RpoWlfLbguXHb4pSMVUsUCbhhiPekBlXGSABSmlL7ApBT3FAhUDZ3ce 4pFyPUVFU8+7GqBL9u5Pb4qioUsG7YyTQIBZMqBn70NiWbB/zSyrSEemcj3q4geTABJx3oAtjBXj mqERjUg8A0s2jR4L80lASwGCVHagashyAoyq0oRlkLBsVIPbCQZUbVHcfNMrh9hPp9qNQxkjAJ3A 4JqZ6Y6Yvuv9bTp6wkiiuHxzcHARfc0wBZiCyjYKXaSy2NzJcWs0lvOx+mSM4b/NEy9Nx9c+CnTf hpotpZNem/1woHkZDld3xWotQ2xSsEQqAcU70rqG/ttTllvZ5NQmdNm6RsgD7A0HUJReyEldhPtm iTZrI4bAHOP80DaC3wPYUTaEb6W5q4QnkjFGoQuSpA5H2oMsoj/UeRzgd6OqbW+32rLPC+50LSuo 5brqGES2gTMRYZCt9x70WsRgX8zA7KD6Q77u9D2xo42n/NZx1dd6ZqF/d3VhGkdtI38tUGBWFvGu 4MR/VQ9rFA+ff70uNAme/bNKQbVPwfvV3YAH9sUFpMBQ2eaoyAK2Bk9hmlQW0l0VK8qO9Zr0f4Qa 31TY6hqdoFhsYDne/O/9vimyMJ0VHk16weQHYkoJXHcZrbvinrNrq2pWphb+TDEAccAnFa//AIFd afcswkUFDgk+37Uwnmupp3Esvqc/2q1rU+17vULlr/FjN+WwOGBPB+afR9adQR20ltJq9xMCQFb2 AqNEAJDHg++eausYQFR896jMkh49y9zGpkmMkg5Yn3po0pMmVOwfFXIYA/Rhfc0pY0Lg9waN72e2 xZk3A84zii+o+0g9vmmyERfppypZkBAG00agsbBSGJ+kHkU4SdRKzqPpphJIY1wBnn3q0Fw+8g8D 5o6Q83FnJAzu9qUr4fH9VIidfUJPB+RQ9wUlkyd3BzRB5GJYKTkn4oahgrZBNEgUBGI+o/8AanBT dFk4A+aL9I8AyH/SB7GlMxB+oDA7YpQTg+9JLfRsXH70RYMDn7e1IJIVgeAe1WAIbGMsBzS2fI2h c/vQNWc4IIBx2zQnYgj6SRS5dxY4HHzQGZ42AGR96mwtiXTJGAOwpvKVHGzkdqMHLHJ4AoTDeSWy D8VBbIVectn2okeDICAQB81bJ3KoAGPc04UFl+oj+1FhYfc45zj2qpHypAGM9j8UOSPdk+wHtQ0V 1xySfg1GhxcFI/SP1fekt9bAnkCkgEHJH96FJM0UbMwAXOB81NLFXEirHnBNRF1qNzbHHotIrDO2 PliKdTzekoctkNxil6FrqaD1Bb6iYRdC3AJhbs/2rTVA07p+5ulkmfTby2iPZrlMAUG6078mfSYH dnO74ravW3mAn8QNBjso+nU0e3GF9UEZOK1vq2vLBCYiiu54LkdqkRFG52KM/Tzg02acOW5G0Hua UsS3jYRy2eSMdqb3MDQMwZcYPeqyIQSO4AY+1OLWIGZIi+MnigRZwAQMAZFFhlQuhdsBT8c0Enc6 JdWZZpY9sJ/S+O9NfyxG3ceBTy56llu7VLd33wIcqD3NMnn3AHJx9qC0/Az7gdvmghPUA/pI+KS0 hJx3HsaJHyhJ+lvYfNBbntz3pcq/WoX37k0jccnjue9LVi2exFAsgxkDO74Iqs5ye2KshUKPcUr6 T2OPajSg5U9u9WZBuwGy3vSnPsT/AIqkwGDKP3JoBuc8A4IpUspjUKFDE9qooN5570N/oUEZLA8U EjoPSGr9TwTSabptzfRocO0K5C/vTrUekLzQnhhvhHHKy59NeCB96zDoDx51PoLRJtI0qxjRZP1z +/Pz81FdQdURa5dC+uvqnwQce2azpjfbGGs763jJjhBTP0596FILgQmWTAb/AECnFxqrlx6ZbI7D NDe6acAuuzjmrps60a3XWJPy0k0dqHGDLNwq071PQYNEfb+fh1AdhJAcgVjrRGQnH1A9wO1WRmTb FGNqA8ge9UPWjVixzxVgmzHuDQt0iZwm45xtpAnIOGVk+xFEglxhm5kKjGML71XBTjJIHFXj9MDL jOau01srs4RlwO+6irif0kZiccdjVRXaMqAA8nmrpNBNhSm5W96IZbO1QBIGYD3zU9BDSCdnVSF2 0P1mO0Bdo98+9XM35hTlBG3suOaTIJgqkpkDtTSUp/5UvI5Pt8VSKwJPHP8AmqgnWTImOH9s0aSN Av0OO3eqpv6ZkJBwCaUqmMBgu4r7ChNJnbx2PenQ1SVvoKIVHwMZoBRys5kcjbleFz2NK3z7RsC7 B3zQm3M5IGAaIJAowV4+KC5Yuf1d+5FUqMiMQSfuaFJdJFkquR8VNWt3Z30UVtt2bRl2oIExqr7i x3dxWQ6J1RZ6bkXemJqEeOze37VEXhsUuTDDknHBPNBhBTJUkD4qCcvr2y1PfNZW35Lcc+keMU0f /lrhuabRT+nJknPGf706/PwsFUoATxxUka2Z7zvJ7E/FLVpFByucc0/it4XA3OqYOaVIkfqNsbeD xmtMo5IZZ1DrGoYnsKPJavCBlj98VdJTbMPfcaLNckBsYKHjFF0bqSuBuOfmrM2Tlu9WaUMwzgD4 FK2s6FlAJ9jQUxMhVccH4qo1fdtPGPekxbhJuPftinDncSFOKIQ0YbHp5Yf1GrohfLBuPg0kymMH kD5GKJApf7ihCYYC/qiRijLyv3o7uVXa7c8UR23EZ4YCgSKf6hyPepprtW5lXKrvb2BqwIB3A/Ue 4pJJUA55qolxySM1lRZEMgXBC+9FWMBtxIPzTde+c8gUuIsScjitsiMBkDbjPxSGQGN2PG2llzj7 0Dly657jtWcvVSe9M/8AASAN4gWWeVMgwD+/evVfo/dHp0Ma99oOfvxXl75arH8319pzY/SMkffN epfScYS3twCDlBXxspvOV9Pj6xZxZgkrntipBV4ptauuFwKf5BXgc/FfVw9PDyezW4BEDjOBg1jN nPm3lUjH1cnFZHfO6WzjGSfeoJLgppd4m1RgE5I5zXqw7ry5VpHrVtk1xznDmudPEycCGYtwO1b7 6yuAyXAJ+vca588TJF9BixBzzX18ZrF8Hm7rmrrCMfmJATiPFa7ugSdzdgeDWwOtrhGlYkjA74rA pptzYbAQc18/l9vR+LNKhf78CimTJBFN0XIGP00UDbjFebT6w0cikgH396OcBNynA/700JCscc8f FOIG+jDEc+1Bf1gccnileozsDjiremqcjkUhpQMe1TTO3p+qscbj/iqx9RHAPzSEdigpW4HJr6jw r+2SKs0bOAQKt6hUbRxmiRF88kEUFsBBkjNJYRv9X3pyE3x5Pam5UA98igRcOuEwSeexpTfTMVK4 UDgmlNFvOFI7dzSRvlRmkOSpxQDY/b3pfKHn2pW3b7Yq6kcng/arAlny2Rz+1XBIXn/erE/FWyRj jJqC4Yn7VcDI+Ku3BwO4qyhmOT2oL85/eqJMfB7VW6hs27vzWtgpZg5LY2YoUkuR29qpmLLgngew qlIZc8VIEg89qvuUEqqkA85q6gdwap/p5Xv8VYzsC7G8ghypHemzMTjnNOJfqznFAcARk/7iq1F1 BcYFWdMISP8AFXhnA49vmquJQBwRRrRhMxDYoKkKpZDyTyRRmBDEnnNDwi8KMZ9qtIUy++QaRlcb MY+9WOU7jNBkkOMDt7moorjaoCn+9CJLc4A+QaoZ2jjgdqsJQj8gYNBTEAA4A49qTknnGRS2myMB QTV0wwC9hRCChOcd/ikOjIQCMfv3o0i4z9WPg0Dc7nd+s/FFWfHt2ppcM/dRwPinkvGN+Ex2obAE 7sgE9loAQZdQSpfnkj2oephkTHpkDHf5q18ssH/JYpxkgHvTGDVpwoglBdWPdv6alERfKCw38CgR osN1C0bFgTz9qkdSjN4pZWVQDjGKZxaVdSyJNvHpoc8djXHL01I2NoPMEOQQQa3h4SXHo6jaj/rB /wB60XoTf+njBOT71ufwsl/+20ZJ4H/evBn093B70yvztQSTeBWo3KLlLdhIx+K4N6Z65TTrO3nj zKPo+leT2r0B84CtN5ZerGH6hZhv968jNM1q4s4YjDI20IAAD9hXPykjlOuR6o+XbxjsNTtxa3Uy 25MYWNZGxzXLfmVeDwF8X9+j3cF/Hqkv5pYQ4JRickEewrl2HqXVI2MsV/fQyntsm20zW41DVtVk v9Uvp790xumupfUcY7D3rjce3pzk9uvde/Eg1+DpdtE0vpmCK/aL0vzUT8Qj5FaX6X8bYendRbUr iS5k1OWT1HEa5DMeef71rqTVbecM9t6ffBCrSLKaKVwwChc/UQMYrf62bfTunp38Raw0LS47HUtG kuJETG/P+xqY6P8AxCuj7CymFzpksQeVnCooBGfbFcBXpguZCbcmQj3J70ZrILbrLJEqKPjvWphp dx6F3P4jPQ6MFTSrgu3s0eM1iHiD+IR01rfTd1p2ndOySXky7QzRjCD5FcNSw20gDks2OwySRS4m gA9RXdXU9iTg1ZibkrtOx/Ea03T+i00mXpxvzpgaAnOF5GKwvwo820PQmp/mTE1zE7l2tl7ICe1c sSIsgbepbnIqrdhbsQq7A3utWYEykruXxo86eieKnh5qXTOn6VcRT3oUGWXhVwcmsX8DukX6k1TT Et3Q4cCQL7L81ydZarNpu6RW3A8jecr/AIqS0nxX1vQbt7rTdVfTLg8N6ZIBFZuttY3Vd6effxLh 6D8Goej9NRXudY/9M2w/UgXHP968+rXwt1HSuj49dvJEii7Bc/ryKaa/1xrPVmqDUdT1ibWriNsg SsWVR8AU46z8VL3qrT7Wxa2eytIVCqiqSGP7Ct44+Lz813WNJfxxXSj08kf1H3rZPh74i2nTkb28 6GORzlTWrI4nM4WQESAbtrDBx/enso/MoFcHcBwRximWO2Z126u6A8wPTnSvVlnfanIbu3jA9SGL BxWT+ZLzt9KeKGg6boXTAvY0STNy8ibVUDsPvXFNuYosIVxKP6v9VEVVhyGQJE3cAGs446d7y7xk dI+HfivpHTerW9zNKRBG4kBU/Ua6Z8SPOn4WdQ9BnSnea4vZIwEjEYPpuPfPtXnFAsSYaFuSMZkP aqjtli/9pfUJ/Wc80sTzmUkd2at50vDyy8B9S6XP5sazdWb22wR5UuexzXFXSh0+F4hfQ74M7i4p nNYxkxm5hQt33d/7USOKRyEjj3IDnatbxkkcbXUPhX1R0Xpoi3TW0MeRuEpwTXV/T/iH4LaVaW16 bnT4rtVBaQt9QP8AnFeWGLYyAsCGAIwaynonqbQNB1BJtatzf2y/+2M4FTHB1xvWnpD1/wCPvgb1 pp4suo7611S1TO1JB+n9sEVx71p4reFth1oIOhhPDp4P1IR9BP2Nc+9W3WjdSdTXs+mwi106Q/yo DnKmoGK1g00mPYTnjK5HPzWMsO0k8bt6SeFHm90XSNOs9K1W5tDpxyjSSSfWg/apmbqry5aTrs3U UF5YwamD6vqIRgn4xXl7cwpOfq+lffvuP96ZTW9t+lVZWXsZCSD/AL1nwa3vtvnzpeYTQfHDqDTd L6cs91npsrMtwyANIxOPb2rRVuZFuIElGCo2tS4R+ShMiRIzkYMm3sKIN0rbmcbm5J+K6Y46c8k9 051Nc9M6u1xGomgXjaT7V0T4Z+IumXOoW1+1wYLqMhgoOP7Vy0VCj9WR2I+aMh/KkSW88kD47g8V jLjlawz8fb1i0/xO6C8XemRo/VjaclkiAIbqUAh8Y3fvWrNb8GvALo71NUl6rsr1ocyCz9VWD/A4 Nefltq08YG+ea5c85LfT/im0lqt3eGadwyt/SM8VZhtM84601/xI6U6p1u3/AOGbWLTrS3+kDAXI FdZ+EnXfSlj4a3Cajr9lbtPGytFJKAe3tXlJYLcW6u3rFF9ghxmn0M11dIBNdyMycorNxXScVlY/ dPHVZ54qaXpmj9W6veW84cXd5uhZTn+We9be6T6u0o9M2KGZSIVAO44K1y/cXcl4f/UytKR2+32F Fivp4UCJM0cWee/NavFqduOPNq+nq54WdbdL2PhdIb3XLG0SeNgVmmCkZBHIrzbsOroOmvGHqG5Q rPpiXkjI6nKuM9xWHajqLXoRZL+aSFRzCrEAmo6AenIzTIVgP6BVw49JyZ7srtDws8SLIavaapbT rDKj52lu4rq/qSy6R8dukUS6u4oJo+UuHIV42+3PavIaLVLm0uh+UvZLeP8A0g4pze9e9U26rFb6 /eJFn6ikp7fFYy4u3ow5ZnHqvol10R5bOkr+71DqS1mkdC/qNIDLJgcALmuNbjxei8UOsr7qWaZS k0xSFCcMI81yrq2pX/UBR9Rv7zUSv6fWlJC/2pdpqN1aOhgf0NvH0cUnF9p+zxyet/TuqaWvl8vo JdUt7YNbSEs8gGMivJOVrd9f1SKCZJVNw53Ke/1d6Tq/UmvamjW0mvahHZkYMHrHYftio6xt4IYN owJD3kXgmvRx8fjfJ5+fLy9J79KEHueMk96TGMYb9JB5poJw6qA2cDGaNDMoKhjx/wB69W3gs0yn w76sk0LW0nbsr5H7V3V4L9fWj9QWd/bXMZt3QeoWbBX5rzxknVlYR4UnsV4qb0Pq3WemyDp160cf ujnOa4Z8W3t/H5phNV6ueKPhTpnjVaWms6dc+jqdouyCY9iM5xV+j9I07wB6Rv8AUuo763ikf6nk 3cuR2ArzStfMF4gRL+Xtuo7qygVf0QSEGsW1/wASOqOriya51FqOpwoci3nmJArz/pr0Zc8k07k6 D6pt/EXxsudagQwi8f1I0J7YPFTfnOs0suq+jdQkZV9VmiIY/ArgjSfETW9ORpLO7ns5Y+I5Y3ww H70w1nxE6s6jv4bzVdcvNUeD/kpcyFglZ/TWf3y4vUvyuKI+nNQZJBJA8m4HNeanmo04aR5gOqFh k3NKTLn4ye1M4fGTrqz082mk63PpqsPqEDlc1hElrqeu6lJd6jqDXV/cHDS3DbmP966cXFca835G czw1AxKZrVnBBZe4zR9B1ldP120uwTG0OCRTjW+lJ+lmhSWdLhpl3Bk7CoZtjy5ZeAMH713s04cd 1dvQzwR8VLC//IXwugrptVtrVubzBeX/AKe8zHTVrPHNHFrlov8A6a6jbJx32H4GfevKPRuq9T0O X1rG4eAZGUDfSMfatvdLedfxF6QtRBp11aAKuAksZZj/AHr5ueF30+n+2ZumPDzyAzWuqet1Tdw2 tpCP5aWDbg/3cmtq+FHS+kdPeJFzpUV2t0toCIJg2d32rgjqzzmeK3Wumy2M2ux2EM361tgVc/3q H6H8yXVvQ9wt1p8pmvY/0zXOWH965+OTeOck06Y/Em02ex6l0DUizLbXaCAHsMiuUOltTi03Uopp yJERl+ogAiq8V/HLrTxv1uC76pu0nSAAQ28AKxp9wPmseM8QYochCO4rv4eWLh+zWT048t3XOnCW 1VZI1F3CseQeMj3NMvMH4Fa/rXiZb9Z6MgvIzGqPCud3Arz86Y8Wda6NCJZSvJGmAMMcYrdmlfiI eImlWEdnDaWMqxrxJcxlm4+9cvCx68splJXefhVaP4f9A3N71BKthErGeQytgRrivNi60PW/Fbxl 1nVNGtTd291fNsePnKhuCKh/F7zbeJHjRp/8P1W+gsdNHLwWIMYcfDfNC8HvMVqHhBPby2FskyRc l3Gc1rVxcrZllK9A/Bfo/qTQNfsTqmnfl4YkCFx78VqLzl+HXWl54pWHUug6FcawkCAp+VTfwPms QP4m3UMQDvoVuYycAhDzUPq34nvWrBjYaFZIp4UvGTg/JrMwtd887busv8PPPjb+HGnz6N1BoE0W pRsPVgYbXRh7EVufw/8AOZpXXYjki0NkV5ApKDcRmvLPqrrvU+u+s9a6n1Ro5b6/k9SVo0wqt8AV m/hl48T+HOI7S0Nwchzk9jUuFkZxsyvdevHiz4jW/hv4baj1RPZPexW8IkFttzuJGQCPivJU9SJ4 6eMBvoNOh0uPU5STawD6Mk96z/xd/ET6w666GuumoNBt7GC8hME08i5JUjB/vXO/h91NcdE3lpql su97X6j84rFwtnpztkr0p8N/JJ0B1L0/cDXLRbu6ZQmV/wDbPzXAXmP8KdO8DfGi/wCmNOle9sFy 0ZkGCp+K6Q6G/EoHRegiN+nZNQcsC7Z5PzXLHjX406h49eKupdWXOnJZRupjt7VVwY1+W+TXp4Jc fblz5SxjIxHMwXlTySKvIzMR+/tQIT6cGAcsTkmnlspkI/evfHzU309NNZXsF5EQDC4bk4xzXqV5 VvEq213QrCIzIjXEWdjHBJHFeWFsv0NGVJDd8Vsvwv8AF7UvDm5tZY5mZITlHJ7V4ebjvl5R9L8f knj4V1z5qegdetvGW01fTobv+C3MKiUwEhTLnkEiuiOgI4PD/wAHZb69LRBLZ5ZDJ+rOD8/vXOGn /iQdLjR4Ieo+l7u+uYgPrjwVY478g8/etKeYvz1an4w6Qem+ntPk6b0CTBneT/mvjsAR2H2rhMLt 3z5Jhjp1l5TvEOz6k1XXWWT/AO+pi0eOxOa1n5rOleqbHxxj1W1W7XQb+KJA1uzYLgAHOPvmuWfB 7x21DwvvYJ9OlV/TbcwIPIrriL8RnoWXSbePXdAuru8QbjhQV3fIBFTV3oy1ljK6R8KrGLobw3F7 qMn5aARm6lMxwUXH9RNeW+k9SW154365qkLh7a51WWSNxyCC+Qa2X5jvPvqHito7dNdKafcaBo90 hiuXuOZJQe4BHYfauatJnOivbND+mJssR3/eu2M8ca8+Xyyj2E6btpOsfCbWLC2O+S8sngj3cDcy ED/vXkpd2Fx0f1jf6Jcr6d3p906uD8gnivQTyZ+NEet6THpl7Pl2wqr77q558/fghN4ceIFh1lbX cUlj1BdNE0Kja0bgZJPz3rhjb4eLtnjrkxzn06z8m/XNtrnRq2IYCcDcFJ5wO9aZ8x1x114feNM6 6XfXFrour/zQ0WdjFjgqfvXNfgf5jdV8KdbtZ7ORGijysvqDKkZrsseffwn1zSbebXrVZr2EBjHJ EHAb5XI4rnjhZNPTeTeXm3j4fWn/AAt4Lo2oEwSfkpZZnm4OSpPNYT5P/wCH3vSms6hAiG4lvnBc fq2//RXJPmb8/wDF4maIeluirOXT9KkIF3eTDDtjGAmOw4rD/Lz5qr3wbufQWUXNpMR68cgJAHzX S42SOMvna2Z5t9S6k0vx6uUvp5/yhjje3MDsE2/0jiu2fBS5udb8K9GGqQhhJBsxJ9QkTHvWmZ/O J4HdUW9td62bSe72jcLm3Dsp9+SO1av8bvxFdG0vQG6f8MrP1bop6a3Uqn0kTHZQPemMrOXTj7ry 2js/GDra3syFgi1SZI4k7Y3e1ehPkUgnTpgtJGVj2EK2PvXnF0nbXnVfVQd2J1K+ufVlf/UzHmvX Lwj0SHwg8JJLvU1WBLS1N3Me30hc9/7VjklvJi68eWuOyvPr8RHq6DqTx9torXtp1uIZAT3INc4L Hu2RoxViTkD71kPin1oPFDxW6m6lhO61urlzCp52r7U26QtDqfUelxMoBmlUEY74NezO/rx25/jz yybv6F8gfXPiR0nFr2k3llaR3CZjju5GUn/Fc9dWdG6x4R9cX3SnUkCx3Vmf5np8hs9iM+1e2XhH ZR6D4aaQlxthiitw5L4wqgZzmvIbzP8AX1t4p+YDqfWrMhbdJPQXP9ZTjg1z48/KNcv8rGuYpt5J YbRnAH2qpH+jcRz7Yq0TNIxZ1xnuPiqYjD57V6Y5Q509x+aQ/wBGzlvYHNeuXkfukn8AtJ24+mZx /wBq8hrO5WCOISEIjOAc+/PavSjyY+OfRPQ/g7Hp3UXUVnpV1FM0mJ2IBX7Yrx8mPyj0+8GR+Jvn b/8Aq38brvoq70CCWxtXjEt96h9QKwzkLUx5qvCZfHzwsi6h6emuJbuC3Fzb28ZINwnfG0e/NeeX mf8AE/ROu/Mr1FrvTuoLqOkTbFiuYgQrFVwSM+1dreTPzJ6U3h8+k9Wa5aWH5FcRPO2GK9sVxyy+ Xikwsx8mxPI9PbL4SixRNl9ZzendLjBDfB/aofxQ638vuk9calD1Vo8Fxr0cxFzMYCxL++TuFaQX zMdG+X/zCaknTuqPrnSV8N89pZOTtlbOWJPfBNbz6w6F8CfMxBaa9qt5DFdSxAubW5EEmf8Ar45b 71vH1qsX3sCXzaeBnh30jc2+m3badaTQui29tCSckY7ZrX3kC1nTNa606tutNJNvOGkj3jDFC3uK hettD8uXlz6a1d7e5s+pLu9jeKOxum9aVGxgFT7HNc1+VjzFw+DfiRc6lFEV0K4cpJATyIyc4Fa5 OpKuEt3IzH8Um01K28cbK6uo5pdGeziCO36A2BkD7iuRbSK3fULeR5BJGxAAA4HPbtXs51JoPhb5 yOg7NtQmikhUlo8Sqk0RPznk1zz4leU7wV8uPSes9S3mqRz7YyltZTSK7s3sAPmnnLNRzx+OXbfv kOFqvl60sWgVU/NShtvz9NSHXvQPgVrXXF/ddWJo56hyDN+fuNjduDyRXGfku829h4Y3k+j6zI0H T19OWghbJMGexrqjxj8rHh/5lCnVVhqqwaldIG/NRzAxsMYGVHIrOPrTpyTxu2xdB678JPDHRJIt M6l0PTtPjBdkjvVbj7DJrxc6s1zT9a8T+p7zTHEmny38ro7dmBckEfv3rv8A6p8qPg14KdB3tx13 rEWouu5gYpOQMHA25z3rm3yh+VTRfMHrWvT/AMTGm6XaXDG2Qn6pE3fT/tU5JvHxThymPJLXdH4d jk+Cc4wB/wCuYgD9hXmn5sII9M8zPWkED5SWXczn2JPNewPgJ4M2Hgh0tLpNrfC7EkhcMWwAPbiu bPMH+G7pXi11jqvUundUR6PdXYLlZvqAbvz9s1eOWYyV15OSXluUc/8A4eXixB0X4rx6feySG31N PycYLYUMcEMa6l863gfp/WXVvQvUcFpv1J71ba6mAJ3QrggV5n9OJqHg54qX2mNfxahe9P3ojF1D yjgH9QxXtv4ZdS2PiN4eaBrTwRTLLAh/nAHa+Bkj47VzxluVjtzYzGTONPedbriHwm8uMtjpl7HY XVwIrOKBSA7xEEPgfFN/w7tMtrTy9WtxEiiee9m9SUfqbBGATXH/AOKR4sWnVPi7oHSmlOZZNBhZ b5UPBZucf+Kyz8PrzUaT0ZJc9I9R3y6dpUzbrZ5m+mKT3z+9byvjXnxlyxuvp0n41+Wfw38TvEa6 1/qHrNtP1F1RTaG5TbHtAHCluPntWzPDSXofwj6QXRrfrGxuLKItIJru8jG0Yzj9Xb7VqTx+8n1j 5gddt+sOlurRo010mLiXcZIZsDAKgfp+9aj1/wAhvSPQfQerah4l9bXF7BBGz/mLS49JVGOAUJBJ rpMu4466ed3iPq8Nt4x9ZvpcqXNjc3s7CSPlWy2c5rFrZGWFlbuDnH3oNuLa01TUoNPJksluXW3m fnfHn6c1IJEShCjLd+a9DXH6TvQWrdPWOq3CdRWbXttLGRGF/obHeuuPJF5PpvFq5vup5tTudK6Y SQxo0DFZpTnO0D/T964ntpEsbwu0e/2I7Zr1d/DN8Xenr7oK46QN0tvrEMpkit5DzInuR/8ARXlz +V1Xqvxx3GZdU2nlv8KddttB1jS7KfVkRQ0oZpnZvlzv71v3UjpWo+EWpHRgn8Jm0mcQBP07DGw4 rj3xU8gmu9Y+Pb9RW+oh9Fv7j15nftDzkjFdmxdIWvTvhzP05pY2W0OnyW8O9s8lGGSaY46efKTp w9+GN07aWHV/Xk6KomCiPGOQN/cfFay/FK8ZdYPihadGxSTWmn6fCkiNC5BlZ1BOfmnnko8aNI8H vHzrHQdfuVhjvblrL1s/Sjhs5NdG+dHycReZW307qTpm8t4dZt1G5wA35lf6fq+1ax1Jqtcs8spf p5RaD151Zo1jc2Ona1eWNndrsmhLH6wfY/Feh/4VnStvEnVOpuA10mwbmGTls55rStx+HD1Po/Te q651frcOhR2aFkmdhsJAJ5Hv2rMfw4fGXSejevdY6b1LUI44b1vSjuWO1HZOAf71jfb1eWN47J7R /wCJ14+9RXXiDD0Xps0+nabp30y/l5CplYnO4kfFcmdEeJ/XGiPdadp/UN7bafOpE2WL7wQeMmvU fzv+TFvMDbW3UPS7xQdRQp6bqANtwvyT81x9a/h79ddMaTe6p1DewaKLSFpIpJ2BjkwM7T/92vRl q4ajy8WUxy7dyfh89CWPS/gTbajAv8/WJTczNjnOT7/FYv4++VjxQ8XPEJ9atuqIrXTomAtbdJ2j 2qDkZANOfw7fEWPVfDCTp+5u43lspXFshbH0A4P+9RfmS8MvMDF1dPqXh9rtzqWlXTFxaRzemYPt k964TqaTK7ytdF6H07rWn+DN3onVc8epX8WmzQy3AO4SjYcZ/auc/wAO6NdPHV+lxHEEE7bVB7fV WsLnwo8yep9D6zf9UdeTdKR2tu8j2s02TOgHIDDisy/DFn9ew6keWf1rkDDsTy31D6q1vuNYz45N Q+f7zF9VaR5kU6W07UJbTTtEiguIUiO3+Yygkn55ru3ws1iz8fPL/ZnWkGpG/sDBeiZR9bleTXKP nk8mfV/iF4xQ9cdK2n8Wj1OOOC5gQBWtti4yT75rrPw60+x8vngHZvrAWwXSdP8AXvhI3/uAZIz/ APRSzty3NPJTw9696m6I8TdW0LRtauNP0vT9ZkgjtUYhQofA4r1c8YepOoNL8rus6/Y6g0GtW2kG 6a5VRkkLk14waX1Xaah4ratraSYtLvWZLoOD3QvkV7Q65YT+JnlQvrLSEEtzqvT7xwJn9RKYx+9W XWbplPhK8U+qfMB4k+KWimHXesb65t2Xd+W34UjPY4rHumuhNU1vTbqfSbSO49AbpllOMY/81kHV PgR4geHNk82s9IX0UUA9MzIpK8H3xWKdNdaaho9vcGynkjt5Th1U8/fNd8+XynjImEMSJU3JKgjY HBUexqQ0lFl0+VTlpUkA2/Y02Fz+buJGkGGc5zjvUhocrQCUJHvIBDNXnvp2x9vYf8O7wf0zoHwc h1lLNF1PVW3tckfUYuMKD8Vivjj1z5irrxKli6S0+fSunrdgqC3jEnrAHuSfms98gHirp3Xngjp+ lpKi6lpQ9GS3J+sKMYbFa68wHmd8ePB3q+a1j6UsrnQpXP5O7WBpPUX747VnGSRxztue3RWvdFye L/l/l0Pqq2R9Tv8ATWWdZ0GY58H6h8EV5kfh9dPjpXzcWujHBWwuLu3Un32git+6j5nvM91h0BqW rdP9D2C2EcTLNePGyNGuOSAfeufPw+tTutS80mkXl8v/ANsZ7i4a5A9nI5NdZeiTp6Yea3xgl8Cf BvVer7a1S7vIGEMIkPCM2fqH3GK85/C/8UHruz1W+TqlW1nT7tCI1ZQPT/bFdd/inOy+Ve+QEqr3 8Wcf/jV476UT6dvInaNMDn3rtjhPDyefXllp335Ouoo/ELzWXHVkVrFpp1IF/QhGAoGeOK758y3i 9ZeBnhZqfWM9pHfXtkh/JwyHAaXHFeY/4d+pNaePWkpv+iSNgM/OTXXP4rt49p5c7dFJAm1AIcfG DXDCS3VejknjI5t8O/xSerWk1GDqbSY9Xtr3lI5iFWJSP08e1dp+S/w40rTOm9R65j0WDTNQ6lmN zGIl/RAeQi/bNeJdg7+iVZRudFIOeBgV7p+S/rPTusfL50pJYzCU2NutpOM/pcDtXLx1m1ZrDpzH 1j+IVrsfmEPTFlBHZaHZXwtJQrZ9TDYJJP8AmuifOP4MdK+OvgVrN9qFtHLc2Fi99YX8YG8FVJAz 7g15p+J3gt1Ro3ml1bT7vS7qKS/1UywyLGSuyR+GyOO1erXX+mjoby067p13OsjafoUkbzPwrHYa 9FmrHF5pfhiwiy8eLAcCaSKSNxj4Br0i803i/b+X/wALL7r3+HQX99ZSC1i9Xgrvz2P9q82/w3bl JfMXpbxkFZRM2f8A8U107+LjrVzD4B22jRIRbXl4kskg+VzgV01uyNZe2vvDT8VXSurbbUNJ650x LNblGWLgMjg8YP2rzn8Tr/R7rxa6o1bRtO/JaJPc+pbwj9IB74+xqC/IxtaiVkDMi4BPzQ7p5bqN FwyqpHEhzWbj43TMnezKRfUnnlX6Y5GyB7ClreRRFYpFBJ7E0R0K7ht4Pam5CRASOvqv8EdqqnUq xyWu4chW+oL3Ao+kaXqepara3NramWONgAqjlhTJY0uIi4Zowe4XjNZn0N4nX3htG35S0t70f0rM mWH96JUx4o9Oi5fSYHha3hWDO1hg7vmsBv4BZsFUEIox+9T3VHiTrHWGo/xO+RIZQNqQr2UfFQE1 7Lebt64HfFZZxoNuhuZQFcoDxzUvDMv5K5iKD1U4D9s1Dqzq4BTCn3A7VMaWI7a1uWukL7h/LOf0 n7002x4QvbxYcfSW4zTh5RbwlQNrN+nFLkhkmXMhBUE9qvZgesROAY14GT2pA8TMMEZkb2703JeU 5GNvzVpZjIrKOYScClqQIlQcVoVtW1Xaqd+Se+aNBOqPyMlhjmrQsM4bkD5pM+Ij9P1E/wC1AV7h JGAxwOM0GQiPdyM/aqlYMFjyFB5J96FJKEi243EVNC6oFwwwD70mZgMg8g/FCz6owW2mkLEQQN+4 CpVObGaC0SdXQSFkwjHuDTFlZypUYJ96IeX3YGFPxVpJggyTx7CtIGpYNhs7sewrKuidfh6div4n t1nFwm0FhnafmoaGG1msHuFvIxJn/klef802kb01C7tue+KAGoR5dyDksxOf3pK20STRzoGjfaAw XsaKCLhyrEADnOKG0hGdrEAHH9qCY0fp6+6quJU063kuRApeQRjsB81FFW/OyRMCoT6So9jWZdD9 b3PSS6mNPdIJb2Ixu4HYEYrDYPUhklMrFiXJ3n+rPvROzi2dkILA8djRJ7r14ygGwLxVHCpuDEk+ 1K9T1wMhfjgd6mlDR2MDwg5B96WxwMM2fvSCihh3+9KVVOOcYqim+nBXgHvVg/GV5FKQhifj2FIG AMdj8UDqyjWSZPUcIpOM/wB8VmfXnRv/AA3pNpdxX0F7BOg4jbLDP2rAlVpFKgDvinISfAVpXcAY AY/SP2FZoY6lNLBbLHCQrhQ7H5GeRXoD0J5Duh/HbyyW/UXRd5GnUqQGSeNXOWkAyVb4rgNoYmYi 4J3LyMe9bD8F/Mz114BtdWnT10/8IuXDT2ynBIz7VvFz5JbOmGag3U3Q2sXvTt/cTWSWEhiayf8A TwccZpmL64luZcjIIBAA4FZj44+Klt44+Itjr1lpLaX/AOnCXaOeZH92JrDPy6Wkkpd3JJO1FPtS rh67WtpEmmeOZzEqqWBUf7Uqzu45pArRb0UnO7irw3djdKipbywSjhjLWYaJoPR+qeH95d32tjTN fErRwW5Bw4HY1nTpGLnSZQrSZGDlhj4plsEzKVPB/pHen2lX19o0NqwMd04JV0ccFft8UXVrzT57 o3Ftp09ox4kjZsjP2qbQylVyfpKqR2wKZTxOZkmaQlwNoX2NOhdIZMBCM+xqp3Li3SICSWaQRogH O6qmgo4JiGMhIfutGt0YERzNgH3p1qmm6lpN7Jpup27W13EqybSOQp7GmsyyRNtY+3BrKrGLLsU7 e1IKMsyozHGMlhV4pCN2eMdhSw2+H1sjYDgr7mgtHK1rKjoNyq+QSe9H1m+/P3Bf0hGuBgD3qNe4 M02z02WFvf4py7BDjPA7HvmtaQArMf1jGO37Ue0vXgkVw2NvaiKCUXdyM0GZUJHpDj4ppU/oul2f Ut8kc97HZmZsGWQ4AqH1CGSzu7qz/MLdJE5VZE5DgdjmmuNsJYw+ogbG4jgGnug2n8X1EQF0tlZW IY9uBVEf6zxAbeQe+faqklEJUE5PfmqfMLMzgjLEHNDklgkUpsJ+/vUFNMk8u1WVye+DTmFfSbA/ ahWepNpNvKlvbwFZiAzSJlgPsaTJfIvbuP8AeqmzmY7QxBApmZCxwMYokbi4UE9z7Va5gwoC47e1 E2WuNhIOcCgTMWjJHAx70tS0cTxjH1/5FIyFIzyPg85og35vTW0m2hhWQ6kHJmcjClfimwyzZH6f fFHhjS7I2hUK9gexpETrJMw4THcUgUZNqtsQGQ9s1SlZ7ZzPIBcHt/8ARQZWDkEHnOBV7a1AlO5g SDnBq7YNV9fTpf8Akvubuye9PBpo1OzM08vozp2DHJxUle37flCMLkDAwO1QrXHqyjtke/zTYC0P pjeTnHAqiCcEnH/mnKRbgVJ4Y5/aiXdvGsCLuwR71Azhilf9K7x7ge1CkV8HPCg8g96MWljYG3fb uHP3q8FrJdSOzNyB2HY0CI7F7ltqSrEMfqY9qyey6K1rROmpNfu7JLvSA20SE9/uKxC7KSAsX25B VVHAJrYHU0OudE9M6ZokmvR6lpd/Atz+VRs+iT7Hmgw1JFk3SBAI3OQB2FNxZvIz/UNp4x8UqSEw XHppKHixnA9qIbhViPpoTJigaano0+mXkUdxE0Tsu7Yw5wex/vSIIS0gVlAOO3vTqSa9vSZLyRpZ 8YVnOSAOwpEZ2Nlh9Y96Ltd02kjOB7U5hjh9IM5xzg/tQicuDgMPeiqyzbmAX0xwce1EBnNsCfSd 3X4figFg4JdM/GKfNbJEg3d2/Tn3qOkcRvtJ70B4WAcnAHHNFnEW5PSIkTGS33pmshJAI3DscCll wIiBgKecLQHMJlAIXJ78+9InDRKMAA59qcQMqWT7c+vng54xTQbs5l+oe9AhGXcCfmrXMyQsEAYu Tnt3pUSBpAw+e1ZRea/br0gulpaQi537jdOuXP2BoMagJznA208ZWWJX4IP+aBKhszGZlAL+4p5P AbaJZXIMbjigbNIobC9jTN7fcWLg/YUZXjaXYpKl/wBOatNI8dzGh5YcGi7UIQQFKhv/ABUlougS a/c3stvKIGsrczMPYge1MhLGwZsYPv8AarNdypG3pM8SEbH9M4LD4NENbvVH1BUJhUMOAI+7VV3p eoaasVzdWz28b8oWHenWgazp+ga/bXTWjXlsmfUhY8n9jT7qfXZeo7qS8EcyWbH+XbyNkIPtRpCW eoXel3qX1lPJbzKdyzxMQQaz++8eeo9c6YGh3sdtc+oDG15Io9Qg/NY70z0nq/Vl2llo9ruLf8x2 xtjHySam+uPBnXehdJj1S+EMyFtpaFgwBP2FRm2StleUDozTL/Vb3Xr20S9n0pi8KtzhgODisO8Y fE/VuuvFo3utwC3ihvEWO2/piQN3/wDNYzZ9XzdOaBDp2jXk+n3kr+tPcxOVDZ42/tTa9vLy/wBN Ml2oupznNyVO5v710jnrd22B5kdKs5uptJvrGZJoZ7VRuiA29u3HvWoGhkgVkOduc81n3hx1NFqV rc9NarsMbqWtZ5l+tG9hz2rHuoYH0tp4pF+qNsKT7is10QliSL+CWWP1QhyQfetq+CXUXTXQXWF/ c9WW0x0+7QflXReAx75+K1XDL+WuIpuXxyVxUzqXUz6pCiy2oVY+ymmxknjFN01L1lE/TUscmlXI 9QopzsPwfisPknHriPI9L4Wm88yybytvFErf6RzSbaPAUFc/cVEh8zKbhZAoUAYwO1WkkaGMvjue KVFblwfp5HaiCTcoiKjefcjtVim7zbSjNglvanfqPKqZICqOB8Uz9HdKIcZkPbjtTiJWgIWQYf5N OwQKmRuIB+RS2jBRiSMHtSFt2vGYLBK7Yz/LQ4oDxyQorM23J7Gqmz2yTbKHPYe1XvvTvLlpETYR /SaVG2xU5G7vVLKrytkjcfaiG+yUqUQhZPYntUzHrmryaTFpc8qyadFysOOx+xqPdcIpI9+apX5y jfTQElYBv5aBE9+aSG28fPvVSBIyec455qd6c6P/AOJ4DNDeR2wX9Qk96lSo1ASOMdu4NNXs4y++ YMzqcgoxFT3V/TY6OtraZ7xLsS8D0j2NY7DetLEAUwueQarJ2/q3SFk/5SnBY0JoSrE4GPmlLcej AEJxGTnHzSd74y7Aq3IwPagVNhAgBwTSElcNkHnOD96XIys+0rkex+KQybTw2P3qQPLmA28yowLA rn6aQkayLuPb4NSWkavbWqTPcRGeXGF+1Rs8m+4MoG0E7gvtVBbGJRLNuUKAuQD702W5LxsEhCoP elvOZH3n6eKqKLejsrAIfai7VasYmDsfqU7h+9Fm1J59RluLj6pmGCSaZsc8f9qcpKY0EbRB2kIV QBkk0Q2ndfVAcgA8ge+a2r0V4Q6enSMnUfWNwtrG5zb2EhwWH7feoXpDwyt7HUodU6wnOn2ygSQw OeXxzzQfFvruTrbWY3s43Gn2qiGOPP0sAMZrcx/tnLtO6v4t2tpoU+l9LaSmnjZsM68MR81gGl6Z NeI11cjIUhic8k0z01HtlKM5cMcnHsPiphTJ6SC1mWKNe6t71LTHFJTTWV7pclrDpCQ3Ab1GvQfr x/pxTW1RVX5GPaj2szemxU8kYOfeqSMCT6Rgn2rLS4IyMLj7U5VAApXhqT6MhbYoA9silNb3NshM o2qOckVlkuQn/FUpy2D2I5qjGRgnsRVkfBPfNEKwA2QcYpcMgZy3uO+KGApJXFXhlaIkbQQ3BrQr a7GSQMVxSA30Hk5+SacOC8eT/gUERkMMjGTgUAwSrryD+9WnYFeDyaqbiRj2I4oUZ3Mue1GtARCN rgb2XYCCVPvWTX2uad+Zf+H2iWiGMKUXkZx3qHTRY7uOSQOsZjGTn3plLGAfoBAxjIFNJQDI1xIQ 3z7+9LSJWG/aAU9vmqMLAAEZ+4qt4XPsTQNZpN2XAw+eBTe4nRGAaREdv6WPJo0/15Iycf0j4qd6 I0zT9bvZlmtRLcIBsLDO2ixjqTtbSpv7kZwR7U8TUYJl2yW6Ek/qo/W0UUesC3iYExDa2PY/FQ6K XXAAytFGuLa3VhtJPPGDVaVJCNQDpBvKE/V7g0CEOrfQdzDk++KdR3a2bf8ApSJJX/UQuTmiwC+l n1C8eSaZySSCueP8Ua0ZbaN04H701vI7qNt7RPCzezKRQI2kdsNzQhxNJJKx2Hge9GTBRT7j4oVz ELOUxqfpKhj+9WRs452ii6OdxbnI/Y96ItyoTaOSvvTeTvj2x3qhEQCx7UZP3vDKoy+TjFUrohUO cZ7ZqPjJBAGOafn00QethnHYUDlJgrYxhccVcXDRjaSQT7CmrsCQ2eG7D4qpJCjfWc/BoHiu2d39 Rp2kksJHP96j7XezhRye9Znb9LJLoQvzcruOcLmjNQlnaS6lciOKRY3A3FnOBUk9uiSgMwJxgkdj UE9xJ6v8kgDscjNOEeVxvkkB9hjiiH9pBayXLCblB3H3qp5bVJT6Kb0UdxTQRTZ4KlT7/NOFCxRE AY9/3osCN2jTL/JUAnB55q7xq9yfeD4pCk7wdoApwuGGRjFF0VIkShXgAj/1CrxBVB9t3em8rHPb j/vV4wxGRxQ0POwbPAIHambllP0jaBShG7pKmcE/prILLolZtNN7d3ywEDKx/NEiARzPlVbB91pK QLJIARjHejXohiYNDw44bFBjZpScDCt2NFOE0lZBlANgNNLiFY2IUj7Ud3k9MReoVB44pJjBSNcg kHk02bMWjIbJ/Wfir7Fdfn5NPbuJYpdo5JHcU2WPcCD9J/70UAqzEHAI+aUIsc4yR2FHlhESKc5z 7AUkMUbY3YdvmpWQAM/9OKTznCc/Y059My9jtpSJsYb8AfNKGe2TIYv9A42USJA4bdRJmDZ+kZ+K SPpVXAzk4wKoQ0IBG7IAoZXMmG/SachTMSre3cUle5DAcdqkaXgSUN9DlE7Y+af2PV/VOiwtZWWq TR6dM2XhXsaZllGCGwR7VRmI/SCT9qaEpf6k95DtU7Hxyc9zUbH6jqdxwwqk+s/VkE9jRFkSMHcv 6e9Pa7XEUnDHG33Oas5SUbx9IFWErPuH9B7UBgzZCcKR2xVRkWidP/xfS575buBY4jhombD01Fsj MdmSo4BqJitnh2mOQx55f/qp/FdGNRsbK/FFhT2kiDDjj5FKjUxOA5JU+wpJu5JCcHPyDVhIwyO5 +9HSHItS7Es4wTxSxD9RXINASY5A42iqa4CuW9jRuU59MZ4zz3+Kp/pUg4wO2KTDdBlxkECqMhlB GAT3H71I1oeFiqAt3HcCrySM3Y5Wmkfr7QZF2MeMVX5hY0yTnB7CqHDEBcnj7Cm5GQSvfPvV1uBK uFH8v4ojcDdwF9hQ0RlR2P8ANPehzgYGSQ2OQKs4bOVwSf6qaO77znn5NNppdgOV52j3q0hMg70S JSye1IVD8CsnSyIAD70IoVOT+n2BozqxzggVYEY55oiwiAQ85pQjMfA+oHGavhsYwMd81aF95aM8 D5osFZ1UsOwpIdQB8e5qzJ6iZ9h701lYhDhuD3o0MbnAIzmL5pt6m6TDHMfsTQY3+sKP+WD2+aM8 DbCQOPYfFFhMqRSKQMHA7VDyTE8gbCDgnFP3UW537shhTCZhjCncCealXYTXOxljZiysc4HYUtnV rnBw2R70OSJihwAPigoC0icfUncGp2lPbDUUj1KYxsoVV+o//RQzc/m5JfVO8g96ZvohSSWcErv5 wO9LEX5cbgSSw7VpFoJN7nAOO3NKMqqTGUJJ7PQoVcORgnNSEWnuY8lScdqAUabl4H+aXHJIuV42 e5qmikAwBg1YRSIdrkY+BQWAQ8j9XxV9/J98URVQLgjJ+aTtoKDg8e1XOSTjG2kN34oq4IXtQIkb 01GKoEkDOTnnil7VJ5HaiIRAu/hqAaKdhxkn70pQ6kEjmiPc5KjYAPkUlm+on9S/IoLY29quTkc9 /mk7Wf8ApIWqwOR3NGtLJbRSDJH8w92HvV8bScMeTyDSomEcgGeKEAwcs31DuKJDyI2y4MjNv+w4 q7/zUyvKe5q+ladfaykkWl2bahdZz6SnBqTfQ9bsLIRX+ktpzHgs4qKhdpxhSFPb+1WkZUU4GTjI NFkH1mIDcw4yBQ9piBDDIX571QGOZvRjePIkLe9P7dJ7yREcK8kpwEWo+6lZrMzQL9anGKy7w9WH TXbU7ra0gX6Fb2PzQD1Lpm506ONrmD0AR/UKx+ezLSsgHf3FZb1H1O2plmllLqOwbnFY5/Eog6tw K1YmzSKza3t9g4A9j3p3Jc21qihFeVwuTxkZpvea7LNL6eI/SPGQOf8ANNZLprfKKjOp7Ae5rmqR iZb2JZSFR/tTWR3VnUHJ9gabxvNEhRk9JvahyTEqFZsyd8/NaBYo/UJaY4f/AMU8kFrBGojYszD3 pvbEltsoyx5pzJcrENqRp+5GTQNzCFzjJx8VUSgYDHGexNIEhfft+hvcexocTmUkuc7faiU6kjwR jJ+4pIgLjgkfvSz600fqQkel/UaSL1wNrYx7GigtbjH3980AROvqorEFxyafGQTBuQcUlJFU7hg0 TsNNPVFh2qC4Xlj804V153D6vcVQckD2FKVEck/oJooc6A7mHb4FNlQJIp704eAEHMhGfYUlIztU Ej6aB3HIMgOm5f3onr/WVXCRgdhTdsFCAe4pqFLYUnAoH7OSRyMfHxQmKM+zJyRnApBJPIdTt9sd 6uG+kuBtf5oLiP6jyR85qwLFgqt9Iq5lMbDI3Z75o2xC4c/ox7d6Ai5RN+OR2x71S3CzBeMHPOaC bdid+XVQeBmrKu597cfIoFz4ySQMfIp3ZyCKJSw/agKigZPIHbNUsJGctvVucfFGoNIweT6s4+aS Jc54yPak4PAYn9qPEArHIGKztTVH3Pj5oiW3pg84J7Z96MdsjFEQD4arSn1Npzgp7VBYZTHNEh/n Bmxgihx4C98kfNKSYE8cEjFagJNH9OFGR80KPmRiOcDk1dpiPsvakxEtKxHYjGKxl/GmPdbu8qFo ZetoCOcKT/vXpl0fGDbJjIIArzr8n1mE6gMrLueM4r0d6TfbCo28kV8XG7zfRk1izC1OAvFPhMNx +nbge3vTS2IXaH/2p6w3Jla+xx+nzuT2Y6nOI7Z2/pPvWO3rsdNndVIBQ81N64wSwk3jAHtUHrM7 R9NccA+9ezjnbzZ60596wYH1CT7nJrnTxIc+kwQ7goPet+dWTART5OSXNc8+ItwVWYKMLjvX1fG+ L4HLfk5x6xUmVlX+o81iNyCSBnjtWVdVzZmbPBzWKscn55r53Le30Pxp0LGCMDgD7Uv3pI7felY5 715tvoFMAICw5YcY+1KiQEKTyR7Uk/UABxk0qI4JJbt2+9IDpBsYljkN7fFDucKcfqFV6pwVYfUK Q67jk9qiaen8Dh/sPg0sklju+ke1UCMcVcgse2fivqvAtjdjPBqjhcYNV9QOG4+9URhgcUWiiXCf Scj4NDBH1Z96uq7wWHP2q3t+9DZEil0ITO6l4TJCg7h3pSjGCOD7mrAA+5B9z80Qpn2f00Eyh3+k YHzTqLggnBFN5e2Md/iguCD9quB9Qx7VdcZqlX780Fj2I9896vtxnFWbirFnDKM8UF2GO/NWIwe9 EcAq3+AaEP1AZBP2oEsDg596r0OVIOeO1ORGpB3c/FNsMjn6uKAnole67fvTZ2IbIo7zu0eN2eKa qu5f+oVYmlsggtjND2Z+onj/AE0bjOO1Dx9hWlBaIZyg20jvww3USWQim7OzEgGtaWEuVAAx/mm5 UMRkZq8ryFzxke5FJDqmDzisqW6BlzTSQsuQPqBoslzEW2rID9qrcCCQN2aKsrhIMD5pDrvUFeKU SMY2nvVRxgSZ2sAfntUoGylFzjLGlbSsOdu4nulXklCnAxuU8VSSqGL87j3GaoA77lUCrCMhgRnj mnEm2XjYF+4pByoyDmgHPulj+pcYYbT80S4jUNG2cuD3FN5G3H+YTjuADVIpQNh+TyM0BjbrMSxI z96PqPRN4+lLeqtt6R7FZPqz8YqKa4ZmwRhR3IpvcXc1uNqyuI85AB4zWexB36lLKSDlSh5HvTOG +nTZFFkqv6hTm+meWSTd/UeWp9pPTunXNwTeaokSv3ROGFccr01jGWdNXYuLeICP02zW5PC8hNUU H2Ga1PJBpGnXNtb6RLLPEqgvJIc5P2rZXQN8VuA6DB7V87ku3v8Ax58o3D5mbYX/AJb+rUxnOnZ/ 3FeW/SvQn8SsLX8vGsk74BVuBXqz42Qm68AOo0I+p9N5/wD1a89/DuwW2sYwVBdXBFea79M3vKs1 8KPKZpviFqdvFq8KpGGCy+k3IFQvmk8uvRPQPWOhaL0YzWl5IpF9ht5H+nIrszy+aLbaP09davcc ShDIV+FA7iuIuueupOt/F7qDVQFYLMYkC98KeDSddN5XRx0n5CesOtNGN3p+t28EJHHqAAufvWrt Z8Ade6M6wuelNckMGoKM4gXcHU9iK7d8BvFF9GltLS/kK2rDa7E9j81svxm8HU6/1XReotEgjbUF dRNP/qi9qszumrj6riron8PnrbqXTTdjUILS2b6omZvqb+1TPS/kE17Xrq6tf40sL2p2yFuxP2rs Lxq8SYPBboK10+y2vrF1GIoEPcjsz8fFY35aOp9V1KaWPUcu0v1FmGSTWrdpr7c7Tfhr9TQszW2u wN/pDEYqE1P8Ojr+1WS7j1OxYxDdtMg5H7VnfmX8aeu+lPGTVNM0rVb6y0yIpsWENtxjnsKY6N4y 9R6/HBbXHUl7Isn/ADEYn6h8dqzKmra1dovkL8TOqdPa9s109IdxVfWn2liDitb9QeAnUPR/Uj9P 9RBtNvV7LAu9XHyDXq94O3EUnRkSK+70uSfcfetMeazopddurDq+wAmisx+VuGQduc5P7V2xyrNx 7cmX3kp6ytuml17SreLULFIjNJ6z7WIAySKgfC3wJ0vxK1Oyjvbw6OjPhxGm7Jzgg16P9C6idT8G rogbkTT5VVffGw159+H+qy6Zdq8TtGwnc5Q443Gue669a0R5mfKC/gfotv1RoWpSatpLPtuUaPCx j5yKxHwDfpu71+N9VltlgQBx65G0/wCa9GOn7HSvGTwfutH1K3NwkVu5KNyGbbxn+9ePOr2T9OdQ 6rpc6MjwXciRp/pXccCu+GW528vLNZRkfinqUer+J+sXtosQtkkMUXpfoKjtioVbuZpGQkYPtimW HUqmNozk4pwvBCrkFvc1fXaxLaf09qGryKljbtPJ844FZjpngb1Xrc4/JsGbgflyOSftWZ+DyLYG GSSPdGF+r9q628G9MtdT16ynitwXdshsfp+K4ZZbrthhtxh1X5UfFbpfQTrV102Dp8S75DGSXUfJ FYv014XdQ9T4NspjZe8br2r2a1m/sL24Xpy5lDzXcRWRD3KYrz01j1/DPxS1zS2hLRJcMY0x3XPF NsXH013pXk58TNdsDeWenpNGwyJCx/2pje+V/wAXelo3uo+nJJZFHeNSx/xXpL4SdaNc+F9xfQwB WtIGkVD2JAzitR9LebfqG+6kNvf2tp/D0k2uY1w+KlyunTwv9PPaLw86mvNVey1DT5NO1Bm/5Fwh Qn9q2Ba+UPxW1XSvUtdJjNuwyjgHNeg/mI0bReoPDR+p7Owt5dQiljkjuwg9QL7jNYJ4e+Z3VEgs dLbTY2RSEDAckVMc/wC2I4Z1TyveK/TGA/TFxcMeS8MRbJrXusdMdZaHqTRa709f2BZsK8tuQD+1 ezHi/wCJN34deFd71PbW6zXUKIViftlvmuIdd8Qeu/MTqFlJqFpaCKIbooLZccZ75NdfPZ3bpypY +HnUmomOS3svzCk/TG64dv7VkWqeEXWEXTswHh9qJue4uUgY8fGK9H/Azwv0PR9Bl6i122gaW1BJ Lr9MeBzWuOpvxBdPsOs303SrSF9Fhk9NppByV9yKnlqta10847u9vdPuItE1fT59GuGGCLqIoy4/ egCMLcSIWDInAdeQwrr7zz9Y+GniN0Db6ppE8Fx1PMQYmhA3/dTXHdsdunwRjCuijIHtW5u+3G90 6x9PGCB7Utcu2VTA96YyySccH+1TenaRqGsLHBYwu0j8FsE1dLJ/RcFuuOEbH2pzGsKNgD6visk0 bwT6/vXEGm6ZPqEjDKxqMk0413wO8U+moWvb/oe/t7SJS0sxUnA+a1Mpixljd+mMSiPaFAI+BSoo yQCEYAe+Kb6fBqOp/wDItJFfPAkBzWW6F4T9ea9E8mj6BfaiicymPsorrjlL25XDL+mO+ltIITd8 0WKaMyFRCdw+RWR6d4YeIGo3ElvYdM3l5PHxIkanKn4PFQd/091FoWo/ktY0e8027dsKJFIB/vit +WP9uGWOUvZpdWzTHehG/wD6RTKeV9oUo3Bx2rKE8OespRJPpmg314ka7pXUEhf8VFx9LdXXyyCD QLy6dRl/TQ/T/tTyx+mdVBoqzORjkcmrSpCi4BIJ/vRrLp7V7rUnsJrSewvV/WlwhU/9qdJ4d9WN NIbbQb6+UcK8QJU/7VzmeNvtrj4873EJsIJ4JWq2bCMjv8mh6qmsdOtjUdLubQkkASxNjjvzim/r 3+oxo1pZvcAnBK8108otlxoknpu+CDn4q2xgAApP9qtLY6rtBGm3WBwXEbHH+BTe7j1m3wY9OvZV IzlY2P8A4rUzhcctej5Z/Ygiix3JmZcjioS01+V9y3UYt2U4IkQrj/IqQS4ZSTwB7fBrUu3ms7SW Aozn/wC5Tq3nDDBGAfeohrzETsf0gZJ+KtDemaAPb5cg9wK15a9saZFbkxOxifaffIzSTGDPvOCT 3+9MEbU0AleymRDzxGxz/tVDXkjn2SwvDx+uWNgB/kUnJj/a+GcnpMKqOpGf7UBlVATwAKbQ3qvB 6qxSHf8ApKgnNBW5eTcrRSIB7tGef24q3PCfZ+vOzejtY4my24I2fY0CaBIyWTLMfvTb+Lwxlomh dCOMyIVyaJvnWITIA0XuRzVxzxyvVW4ZSdgObkNulcup4Ck5wKSu3+pfp7k04H1IS3b7U0muXIaO EYPdd3OT8VjOz7XCVeREkU4IWIdznkUOOW3Df8/bgcORWzvC/wADtQ62eO5vUMVs3ZR3Y12z4Y+Q /pGXQUuupoQ6Ou5VQ7SB9zXkzzm+npw4blO3mybmCVVEcjTyMcZjXJoovjaT7CRkd94xXovrvkQ8 GOqmubbprWLm11qNSUS2ugfq9gRitf8Ahp5JdJseq30XrSZp7v1P5fpsPqT5rnOWbd8eHtxg+rWs qbFiUTd/UBqjeQ3NtFsVgf6yB2r0213yG+C+nRb783lircBmuQv+PprAerfw6+hta0S6uug9bu5L 6E5EU03qIT8du9W8kS8ffTgtmhfCwyMzYyVxzVSxpHFHI/0o/wDSO9dY+Fvkgi6m6mutA6nnm0m5 t03sUOHcVg3mR8pkPgX1p0/Y6bqc2o6frAYoJyS6Fan7Y63ivTQEdvDJISiEcYyeeKGRbLlMZb35 wK7J8KfIlpHiZZepqWrXWnuqBtsLY4rT/XPlYvfD/wAYL7oq2nbU7aNY5IZv6m3jgGpOWWM58Nlk jSUJ2CTbGjx47Fu37UKOKOS1kmiCllOCCef8V3d0v+GrZ6voKXOuapLpV4+C0StgCtWeOX4dvU/h po83UHRd9/xLZxgvNax8yKo5JzjmrOXtnLisnTl9XkjXKovPOMU3mgimJeVQzD3BximkV+zwOWSR XjJVwe4YdxVLcSSIMBI3Izhz3rvMp9vPrLfRDwIuVKh93PJziqRzAcRnIxjHtTee4RnRY2WS5PJR T7UNbj9QwRzyPeus1Z0zdy9niRiUZ9Ibvc5p/FbMFIKAORjI9xUfZyEcntTy8vJIYQU+pjxkewqd Ttn30WEGMf2wKc2USux+twRz2qb6J8OdW6z1GAWVpPcFsACIcEmupumvw2epuptKi1A65Borypn8 vcqSR9uBXG82MvVbnDftyvaQmQcNkf707EShCoGffn3ra/jh5ReufAXTodSvJoNb0mRirT2CHMeP duK1n0voGp9SPGlhbvOjnbjGWz8Vvzlm2fGzLRi0KKRl0U47Gq/LRLIPSQeoR3P/ANFdMdL/AIfH XfVmkx6h+esdNWUblhvFJb+9a28X/LF174MTC41q1W50teBqVmpMY+x44rOOctdsuPL21ikYMmwY V/YimFzaNDdBzhmzwccVKQ6dMw3hgMDO7PGK2d4H+Al/4s6nFGxk9KR8Er7D5q55446ZwxztalST dICyICvI7UO4cqpYcFjkk10d5v8AyodO+XzpXRtX0jVbq51a7uVhmglkBUqe5ArnbR9C1DXrtYLe 2kuJHOFRASa5/sx+z5S+kh0z4jdRdDXgvNBujb3ajKupyFP7UXxG8Xut/GN7CPq/qOS/ism3QRFc CNvc1tTRfIt4ldU6RFqVjbLbRsNwSXgt/atZ+Kfgn174Jy28vVPT8lvbSsVgukX+XI3wT7Vykw97 enDLKTuMTeCFFMcRwD/V80I2wVCjsG+BtHFF0ix1DWZolgh3szYKKCT+wrclv5LPFnX7CHUNO0OT 8rOu+PeMEj9q6+WJjLWkIoIoNyKA47lsfpoogbcHU5HbcB/tWU+IPgj4h+D1qlx1V0zeWFm5wLnG Ub/AqK6V0peo9RtLEy+lHdFVUqeeTjNS5Y6d8cbb0imRQfrAfHZioo1tZJkttDg/pOMba6v6z/Dt 1Wy6Cj6m6Z1xLyWO3/MTWkmSSMZODjHauSNN1CeT1IXG2SKUxlD9jipjq+i9e01pPUlx0rqdtdWM eZ4X3rx7/vWxvEPzd+KHiD0+dAvdTGm6U0XpyQWwyXXGPqNarlaRI3cDke1Zp4TeDGq+LWt21hps bsLhgryj+n/qP2rln4zJufLFr20s1skQKctjP71O6PrJ0S8tr9IfUngOY0PABrZvmT8pms+W620X Ur3WrbU7S+m9LZCCJEP96wDSvDLrfrKCa46b6avdVtkALSxDIFayymc1WOPHw7jbfV3ns8Rtb8PJ ulbewtbS3nh/KvdRyZkCY7j4rmy2sXtJFllmNy36iRzuJ75p3d217p9xNZXVo9hqMTbZIJ1IYEd6 l9E6E6q6hgefp/RLrVLePmf0FPH+1YwuOHTeWNyu0VNjaGVGHGTx700cyPkKgT9zUvpHRHU/VeqS 6VYaNqM2rxttFogO5T9+Kn7ny/eKSARz9K3qleGwpz/2rrM8bfbPjpgvo5jIkO/3BTnBoE1u88TK Xkdf9LNisl1bwk8QdDiknl6Yv47eNdzMEPA/xUJpvS/Umvxyy6fpF5e+gMzqiEmP9xjisZXHfa4Z WbNLSySGJhHHt+RjFBmtZ5A2ZXjHttkK03v3u7XUJLS5gutNuIv1JMpXn+9O49L16awe8j0O9vbR ePXjRmBP9hXPLLHenXyutm1vatpwLLJuYn6pGOT/AJpcV5eKHMV7dAdyiylBTTp+G66nv7fTQDFc XMojjUggq2cAEGtteIvlE8XfCvpp+ornRzqeiekJprmHkQp8kVjyw3rZ5fFqSLTpr5pJ7slpEOUM kpY/71eIbpWkQb5EHI7A0y0zVTNZqNvqDn+ZRY52VGaPAJ4P3FdJJWZl9nMfVeu6TGVgv7m1QnhL edlA/wAUwv7zUNZKtqWpXupBjlYrmZmVT84NJdN2ScjPxQ3mIXjcxHuaY8cnab72lrctaqEjl9Nw PpI55pcXXXVVjG0Ta5qdih7LFO4X/ANY/Fqzx3CkIGweFqW1a91K9jNwbCdrfb9JjhZv+wplrbpf lDzVdTuOqNKC6jc3d1cpyTLcMwf9warpzr7qPo1RF0/qc+l7AeImK5/xWN2GtTwtmGFnYD6xIDkf 2NJlN7fH8xFaSiQHnYpP+wrNkvbnhhqdNhL5ievpIhHL1bqCyeyiRv8A6aitW8avEnVke2bq6/Fu ykZSZssPjvWJTQ38MZkm065bK5+iF8/9qi7fVWtyTLHJakHIV0Klv81ZI1qT2k9LF5pzyyy3TpdT nc7SncXP3JrO7LzAeJWl6F/B7Xqq8stNjyEjjyAP2rATqFxdorJambA5BUsQf7UV11D8uBNbSSL3 /lRMD/2qWY11noKKW5vpbi6u7uXULqZ9zzzuTIT9z3NPEuXgZJAMyp+kBsYPzUdvismzKZIg39Mi kEf5FOd6lVVQCrc5ataliY9b02PovmX8TumrIWOldU3VnZoOI2JIX9qwjrzxJ638RWZdd6jv9RQn LR+o3pt/bNRhvP5hjniMoX3UZDf4pmmtiO42MGhiPAj7E1zkx37c+Sb6o8Jt4447WMbZlHJIxmjl yExnDUbRo9Nvb2ZtS3oiqTGV7k0yu5Q7jaOAe4+K9TGMmuhA4LkSJ6i+4zWT9OdZ6l0TqcWq9M3E lleIAwkibDJ/asUEx3lVGRjv81eJ5EYmPKn5BrGU3G/LxrfY8/HjbJaG2i6wuPTxtJeLBqLk86Hj RbaJc2Ft1Xcx29yCszBdxYHvg+1aVaV3Y4O75zS45nDbBIw5/SKxMdM/yPbPXZ7G5lnvVlur26cz NOpOd59yfmt29CeeXxQ8LLBNI0jW5ZLJRkRzrv2/sTWjGd4U3DJ57USRygV22MWHYjNTwdNbmm2v FHzj+K/jNpb6Xr+uM2iyfqtYU2Bv3xWrNN1WXRnU2oaOQfpMbHIpnHdOQVCDkchR3q0L4YyKpR19 jTw2xjh45b26h8OvxEPEfw60FNGgkXULa3X6Fuz9aj4yeTWM+L3nZ8UvHnQH0G71G30/RpT/AD4I 2Cu4+MitAzs92wJjXcBnd71RjyBuhjDj3A5rpjjqGeMyu2UdNdda70hdwyaXqM1vHakE+jIVz/jv XUOi/ii+Iej6HFaPp8F56CCNbh2wxAGOa41ZmTDBdq/ApYdimEUb89scVnw1Wf8ATeHiv52/FXxx 099J1HUzp2jEktbwqFL/ALkd67P/AAq7INoOu3vqhpCgiK55xkHNeY6yyiNSyKWA9q6i8n/nR0jy 1JfW+qaTc6rb3SbdtnjcjZzXn5L45R6ePX68pHQvjb+IX1v5c/GTX+j9U6ftOoHiCS28Zl9NY425 U5HfIrj7zFedHxG8xdo9hqLHSum1m9U6ZZngn4ZhyR9jWLeY3xl/+yK8dNc63h02XTrS4iihhhlH 1KEXaM1gVurZECsERjkiunk8lx3ezTTY3jid0X8uWHb3rrHy/fiMdW+BuhRaHqWnDqbSIV2wQyvs aIfY1y1NGskxhd9mz+umE0aLIW3mTnGPtUvd2743WHi7c8WfxXL7rTpa90PS/D2zge+jaKSeaQSY BGMjIrhLTEntzOs+MyO0mB2BJzinUkYZsxqyke5q4zEGYLlvfHzXX3GJNXZ3c2xtY4G3Bt49varw loZ1ZeQB29jQWk9dF77/APSfalxSEnBG3HvTW25Wy/BrzBdTeAevfxXpy/a39QBZ4gAyuuckV2tY /i3aNc6bbrqvRiS3iKA31hwTjkjjivOJdpV4yoAP9XvQ47P6iIS3bu3asfr19rn83XvmH/Ew1/xT 6al6Y6Q0L/hi1nBWe6hkOZE91wO1aP8ALj4yw+BXinpHWV1H+djtGcyQg/VIWHJrV6rLG31rgdsi gzOpbMce1/kVvwYxx06985X4hlp5iOg16K0bpp7S1lmWaS6kf6gw7DFcgWcZtbOBHyJATkGg7Jp2 HrYBHZl7inQUpCz7i5Ue55Nd5dY6Y8O9tq+Wzxm03wQ8SdG1/VImeztH2uin6nBPet7ee/z/AHSv mA6ItukeltHuZbb1RO17cgqyNjGAPj71xdJi4CTSRbmTgEdxSZ98ro+3fHjgnk4+K5Y46rpZ5Re1 LrbBRH6swUYLnFdK+VPzj6v5ctSWFd+o9PzsPzNiTgA+5B9jXOKt6zCXcHPbAos2I4wEKhmOTtPc 1M8NrjdfGvXo/ib+X68jtr3Up7pNQjXOx7ASNGfgNXGXnJ8/+p+YmOTpfo8Po3R6P9czNtluv+pv gfauTHt1jDPIhct3Hx+1Np2CoQsYwTglu4qYxMsMZ6dAeT7xw0DwE8YNJ17X0f8AhMKNHNLCNzLk Y3AVuL8QrzvdBeYPw/teleh2ur2VZxM91cQ+ngfAFcPG2F1F6pWRFUDlD3oc0ikYWNgn+r7V2uXa eMCt4HNtCM42nJHzRbjD8EZpUcnqEKi8dgTS54JIFBID554qZXd2zYZrDuyDwPvUhovSuodQapcw afbfmWjUM28YVf70w/MOkoHo5yeKnbLqjVOl0nFoptnuFw4f3FSMWaQFzZ/lLmaGQqrxNtdRzg0F rB7yLbEx3Z4YCqtz6z3NxMxZ5G3OPk/NX/MyxR5tSVkHAWpssAMTW8htSB65GdxNOgZLSFRIiFie 4OatHEZnR3UM4GSaqZDJG5YDg+1Nnoh7togTwT8GkyX8kikEjB420OKMuu/HGcc0c2oUAlcHvTYl umNAHVN2unG5/JnYziXvkjsKnOitO6VMmpW/Uc0qT2rsoWIZ31iun3DRS7oZGWVO23g1aOVo55Zp YzvkOS3zTZqk6rHptvqtw2k+pLZZ+gSgqRSFU4JUgfajIwuQSw+pec/NCJ2neEO3702uisggcc0p YlTknGatGxZS3pkY+aVGC24OM57YrSA3KZBCjHHBpCQvL3yAT2xT5l37Nowy9waRcSu30CM8f1io aprJb5RgFxj3pEdqsbl+cmnMM3s8bY9i3vSfUBJVAcg9qGqE9vuGQB+xoTW6gbSvbsaenCAg57VY KJkJHYdzVTSPW0WMd8kNnAHervCxOe9OUWO3OSxbnuBxSy/PA+mps8Q7WEQFiy5B4zSpbRYTgHJP saWJAq55INJjErEOsTSY+TRSYrdtqhfpyeTRbq02SKrjKEcEe1WNxkkvG0Z+CKU7uyDAJxzzVNAM Nj44AA4qhgr7DB5+1UwbAZly2e1K9FH3O2VHbaPehpWI2HByRSmTjiihEiQYhZG9s+9WXc36hioa IRC4GABiix2zPMkWzc7fp281S/SCcd6vBJNFcI8bFZByrClWCvpkttN6UimI4zgil3Wh3mkG2u7m f1Le6BMKe/HeiagdQ1DacmSU8ZB70K6kuw8a3O9/TGAhOdg+1F0rSLqGxkvJpbNbqSVNiq5wEP8A qFMPRSVGzneew+KdSK0nKRls8c0qK2ZFPG0j2NQ/7NrDTpHkyH9PaM5AxS5YZ7W7S5R1LewbtR5L gojDbRdSuYbuCxggi5i+pm+c0tSaiJuZLq8vJJ5mEjSdyoxinkIt105oniVpSeGxyKcrEkcY3IVJ NN5DEhBbAXP1H7U2qPnheKGJllLktynwKq8vZjIAib1PLAe1GlZIw5Dd+M1M3ep6daaXa6JBCq3c q+vJdyd+f6ajKGWynNq12IpGgTh5VXIX96f9G6ctxqkupRTj19OH5yKNx9LEexrO/BvUtP1jROre k9QjYXc0BntyP69g9q1xpFw6QTRuvpeoGUuO7LntWvoTnUvXF/4ha3NrGoaZBYzemsTtE+d2O1Qm 1nbGNx7fsKvZRGCGZSPo9mFECvEMoM59zU2ujZoTESQO/cH2qoICrbmGEHt7U9XMy5YDj/elsAqk E/Se4qJo0cXFtBNcjbLC304I/TV9e0i60GOyjvITBLdJ6kYHYr8ikXk3o2LuTmFGUsvtya234q9L TQ9C9L6jKy3K2sQUzZBxvHAq7Gn4pjHGFJ3/AL0uRSRu2Y/agTjZOwwQcY47UZBIoG/sKu02Q1/L +Ta1AVUZ95Pvmh24jVi73TRSD9O0UO4zs3Ko2+/zQVQZBYEqe3FVSr2T826bm4U9h70o/WFG1VPy KHIhK7lj5HzQ0nYErtHA7UDa5vjbT+k31knjijqrOyKy4DHJIFOVks7nTpDNGEuo3AU/IoIlD8Bs KOxowe/lP4cy7pVYMP0k9qp7drWMSSlTvb2OcUyi02a5Ikk3Fj7kGitHLEMHg5xzRsWG1F3IwVwr ewJxmnFv01e3elSXEJFxOkwQWsfLkfIFQ9wkixmb1QjDsmOaDo2tX+j6nFc20slvcR8q4OD/AHow eywT2kxWeF4JF42OMGkS5JAAw3uR70S/1K81C6e5upDcNIdxb3Bps9w2O20/akoMYiqq23cPbNKd 4zN6oIzjGc0ETmQqDnaPYVZZIS2FU5B5NGdHMrqYDk89vtQIbdJQq/pz/VVbmkypH0DtViPqXHAH tRdHCWz2swTiZn4G05pWuaeba2iJcM3dlByf8VfRpYbbVPUuC3plcA/BpjdEXWqyvuYKD9LD3oaN UWJohJ6xU54VuOKm+nbcWukXl1Nn05SVgkI4Le9QjRLMZF259ufanpu5m0yKwEhNvEdyD4PvQ0aX PoTQqMB3OctWQabfaTb9Iy29zE8mtFjtuGbIEfsBWLCDa5VAdvzT2Od4Ywvph/37UTQUUH5a1SU/ U0pOec4pxE5jdXByexBFWjd7mUh4ggH+miW1nLckxx/VIe4+KLoAwF5Wbd78896VKAGUjnNXmtJr ZyHI44OKDypA7/vQ0TtIO7P057E07kEYttkAC7uWAOaEiq0MgYAse1Bs4zEpBJyfc+9GT0I86RxM V9NexJ5FIvdNWNnbcG29sc02W3XcWywz3FGkt5IkOCWUdioJoJzo/pey6luJLO71ddIAQv6j4w32 zUFMLcyTQ2aM6wuV399+D3pWm3MX8QhFzErovcOO4otzbwi5ufyMvoCQ/oPfH2o1DdZBgbPqO3mq jDNuUAE+1EFjJCinY27PNF0ua2s9Tj/PRt+WJ+vb3FEhlJFIjYwVK8kUZpPzUiMFyif0/epLXlib VVawbFmeA78kfvTa6hT1CYBlFAyR80NASFZ7kTSEyYI4P2p5f3C3REbTjJA+g8BRTaBXJzgYx71I 6FFpmj9UaPqWp20t/pizhr22i5dl+BQ0jlh/LlRlJ/dcHtSpR9ZcAHIrJ/FHXenOoOtIr7pLTLjT 9M9PDW0gwVrG7KL8xcZb6F91+KIYsrl1JACk8ip6zsNNtbTfe3bKWGUCjOTTnVumoINLs7r89bs0 5bMKd0xUNIApQFfUKfpX70ADBHcu77REmcKSME/erm2mUEZKxngMRxT2VFO2S5QxMR9KnvQTqDPb i1ZfUiJ4P3oA2us6ro9jNa2l40SzNscxHBYHsM16o+UXyt9Maf4R6LP1npUurazqaFnDMZFQNyAc 9v3ryrk02SaZEtuWX6inv+9dO+Df4gHWvhR0vHpPqDVYLZdkfqcyqPufiumMjzc2NymobefHy0W/ gN4kLJpuyTRb0b44Acemx/p/atD6N1VcWAsjLCl5Yxtk2bDAbH3rL/Ffxi6l8xXVFxrXUmoLDHDH mK3J+kD7D5rXP5eWNLeyiUzu7Yjx3JNZy9tcMsx1TrqrWB1N1Ut3a2i2qMFQxwcBf8Vm/ijptvZa FpMKwbLhYwzseS3HFB6N8LOrpdat7Q6QYbV2Ek80q5Kp3OD7UrxY1calrE0XqD0bNRCn/Vt4qR2r WAvgzRqmfUzggjipJ4tjKGZWz/SDkimFvGk93C9xGwtkkHqGP9RX7fesq6lu+no54jocM6OUAxc/ qzUNsenVRkAFiOxolmrO27kr7cU6tLcTyEMpY49vmqZWtVL5zGDj6famlImLxsEQFyx4NCM7HUIr K3QvKxAZscg08k9SK2E8X83cOPtWwfADp7TtU6outW1xo7e10+3M4DkDLD/vWmdsK1Tp+90ZUW8Y xStyVxz9qFc2xkhjljkDAjue9SPV3WL9X9W6hfrGyWrOY4x7AA8YqLt0bKn+nvj2okv9pTQ+tdd0 JnhtJIvRZdu14we/fmo2eGXVs4UJKTkj5JpbZ+sjGPtV4Z5LZop0x6kTh1X2J+DQNxp1zYtsuRJF Iw4WRcHFGjs33A7TmpXVdV1Lq6/OqagIYpUjEeIxhQo7UxF16WOSw+alTapEG0DGAaDEpGQOB7Ci GcSggAgexqipyuFaqbWaBmO79S+61UQNuxaNHQj4Y80pjskI2kA0oMzLxk0T2LIiyopkLMP1YY55 oJhUPkjj4pTSMFAbnnirgnvgsKAXomOXP6omHv7UYqFTlif9OBVs+xH0/FXkf003DPB4+KAUbuFG 7k0qRPUZMjG05496T6ZY7iSAaLCpVh7/AL0WFw8sTtwD7GlTgJGNo570SRd42qPqq7gKuPciho3H /LG8YB70r1Ikt2hXJLHO/wCKLdYuHBC4GAMClR24eNjjBUcURGlSxUdgTjNbI8Aemjr/AIiztKiz x2Fm8pRxkAjtxWu4rp7e9V3g3IuTg9q3J4K369N9AdZdXlQLg5tYyO4De1Vm3TXPXmu6n1Tq149w 5IinZI1zgBQe1Q1urrbKo7j9VN7zVZ5JEcxM4mbewHyTWaXvQmtaB01p+s39g1vYX+TEzHkVLksi At4QkhZTxj9NHjSQsCv6PcYpI/lSDapI96eqc9kIqbUuJymDwD/pFOQGY8nB9se1NRGRJnbg04DZ OD8d6bDqJNsAYyksOdxHNXvtSnu4lFxN6ijAB244psAMYQlmpIJZyCKjCXvdQsnt44oIirIAPV+a Yli544/YVaO1L4Ugsx/So96yvpjw01Dqa5ktjPHpskcfrD1z+oVRiquoJ5yffFUjnPHIodzA9vfX EOQVhYqSvvg4paqdmey/Iqggchdw4xTrSbvT8s2oSNG+P5e0Z5+KYtJHs2D3oJjB+rvTYNcuJXfb /q7033bR96reVIBGRViM4oHFuiPbu8k7RuP0oB+r96ExuLuSKCL/AJjsEUAdyaDtkjJ3N374pUcr LPHIjMjqwYOO4IqVSdQtrvTL6W1vYDbXMfDb+Nw+aaod8giIwrf1/FPNRubnVLqS5vp3uZOwkkOT imJTeo9wPcVdmhniTT70IJRKdv6qk9A19NAivhEgWeYYWX/TUK80cYRQgDe7GkervOMjNFNb5zNO JCDIzHJPvSS7RpmNSzf1AfFOJQN3zn4pIlEa57Ad8d6Kl9TudCbTrB9FuLhrpYyLr1o8b3P/ANFQ 1pcyWNwt1AwS7j5XK5GasucEqTk/5xVvTY9xyf6qB5q/Ueo69ta+lR3ThQq4xUbGgj+r3zTYbklY AnOeSaexZxj9Rxn+9Glpi7EZO4/FXbcjA5BGMYokcJkOV5X3NVNGFUE0TawYIc9/tVsNuLbyV+DV kO770sHjHzRFAhQDnOO2KNG4kKu4y4PagJgEfFFiQg7+9A+SJtTdpyywCMYCexpEijb8k/7UB3OA D2+BVi7kcE7hzzQGjic79rnHbv7U9sry6tSyCZ/QYYKE8VHx3BeREBA/1VKX0iJLH6fKkc0Qo5dh tPfk04hKgqDgrnGKbW0oRzv5Ur9P71SuGU+xHbFE0l4BayNJF65VgMolC/UcA4x7VHbgsinGG/1f anCTNLIVjTcftQOAv9RbPfijxq2wc5pgl2RIoYAAHnP+9O5LsPKdg47jHahsiQjdntjuaewCGRC8 cmfY/FNd5nYEIO3b5pVtALW3cBSrHuD80NquBvGFOCPejjVrqaKK2eUvEvsaBG4yA3Io8oiQqF5O O9A1kspNQjm9D6VB5FZZqOrdPzdO6fb21mYb+BCJZfk1i4JhVvTk2Bv1Y96czrYxaRn1/Uuyc7B7 UQxmyxDAcE8falRTBWjLpuUHJFUhDLGPfvSpQuMjsaaD7UprW8RGtI9j45+1RZVox9WC1EjkeAZW qwC2/ADN3oLwq0rABthPGT7UaWzt4HOCJJSOXzTXa3IJ7mrwRiHOMk+5apQoL6ZOP8UCTEcRBGST kZ9qMzFieKpY40+qRwAe2aoFBbFnDEbhU9070UusX1zdz6glmkMW6ONjgSH4qPD+m52AYAwBQZZT CAGzNn3PtWb7VaeBWlmkUYySKbNECB3Jx7U4jlD/AEngjtmqZCYmGCAR+r3qwNoommV4gu0qMlmH FN1kkVyuec4GKkkn/kGLBOP6j3NDCB8YUKR71VirdCxBlOR7H4pTBXOO1WOFBHJFJBwCTxRVvR29 uF+/tRPTYr9JwKCWPrJvGUB5A96ey3EZdiq7VPYfFAzaEk4Y5FUsOSBjaB8UfIcHH+TQo2LNzxig cxbSg4x9/mlBlI7Un6TGBnBNJDHBHsKLKun1yAH6Qe9XuIg0eI8jnvSMnB5p5CitGFP1EnjFHTGj 22mxvFEsc4aR+Du4ANSF1oj6TLFHNJFKW5LRsCBUZJCu1ETjBzROecZA9qOsuypiVlk3Dep/SPih SRoyjAC/alhfrPNVtPI7j5ooHomNsg4X4q0jFoztPI7GizZc7QecUz5j3AUFkld+M8D2FWRBMCef 7UuElT27980aJAuScg/AppnokxBVAYYNJZQy/Twas8pZ9x/Y5q8uUHwfasoDt3DPx3BpJOVyRgfa jLlkOePv81YJ2GMYoEGRVGSNo+Kl7PpbUotNbUzavJav+h9vFRcsaSJycfNPI+odQgsxZ/n51sx/ 7Ib6aIbSiSGJsr9THt8Co1ow7kNkLTq5vjJ75z800F0SrADLj2o6aUIlVioP6fekTy4bG4gUL83k 42kZ9zQJ5GY8qQKNLTMTDuyrKD+nPNR7kk7gv0iitFmVSc9qs8Rf9Ddu4qWJQg6ucHI+B8VZ/ozt bc3xSZTiTaODQpbi2tnHrMwLnCqASTVDqC4M7hN31e6U4aBQgycE+/xQYLL0ZPzJDR7wAFPxTkhF 3ZYFvYUSGRjInwDnFOkupIVB3dvahEcMwOGPepB5NFjsh6kd0183uD9OalDYXBmP1DHzirRPHLNt f6VwfqpK42kjkHvigPIqnb81QppN6ow4B7Zo685x8dqCCrqvsv3okeVY4PFAmOIEbj7Glhdhye1L iQEFc4GfekemXJxzz70a0Tgcf71Ye/fHxSgQRn3HcUoZx2+9E6J5Iq4PpEHuc1Zx3xSCOxTvRDn1 N3vt+1AMrylcfTg8k+9IDMeT2pTPlvqHbtRdlOSX+kZX3IpBIUMQSeOBS1JwSvY+3zVmGVx2x2oR Wja7rHTd+l9pdwbWccbgM1N6j4hdQ68ix6lqBvfuU24qCDHICjdUpoUWl3UkhvXc4BASI4OfvSdG jEXUjZ+vDk9wKKA8n1O2Tj/NWvLeGF/5AbaD3aglvVHcqRUXS4kVgy4wB3HzSWmk2nDEIeO/FXYK rZYcY5quGAUD6aoC88kwEe76fcH3qzQ/RnPAo4iBbhfq+9F/Ks0Zxg59qMxHCM+sp9gambGZbW3Y ysMlsozDtUfLEycZ+ojjFbp6F6Y8KF6fhXqDqgNqsih2gJ4Un2qSdmV1GnruWW5kJZvVwOCBTYW7 uOQeB8VuDq3ouy0m8lGntFLZyDdFICCdv3rDZreCFMHaTit2dGN2xOGQohU8t/qNXQlu55B4ol4Y 9+VXCZ5IoMAHrYjYlTyAay0vJMFJwfqPtQ0jnODghf271PdJ6NoutdQQW+tTyW1mc75Izgis/wCq uh+k9A0rd03q51U5y3qN+mjNapiUkAKT/wDEGrG1csSQQO9SBj2yltozmquropbDI3c84o0aEAAc Yz3oS8sB2pLXCq/LFFbjJqxkOWw2SPegO0mxgrDkjgiqaTJ2E/3oJl3AoyMeP1rRI4vS45I/1HvQ GZCYzzyOaCpZT+rNGL8H3GO9DQBuW4H/AHoFHj2HIqyR57nn3pRQcn+9XXKkEjkjn7UFBIoRuHBP sapn3LkcigRIYJ2y28uex7D9qNgjcoHHx8UC0UyuoZstUlBodzfI7QTRAIuWDtjj7VDxy5YgA5Hv RYHljyMNLnuAe1ApNydpDgHGDRIxubHekxW5ydoJHfDUbY0Y3HnPbFTQGS9u4IQSqTgjPajLIyja q4z7mgmTYGJ4A9/mlBS6j6jjvmmgb1GjXewyP9NEVt0Zcjn4pBYEYwcY/wA1Y5Ckdh8VI1osOSww MCqYmNhIPqB70MOEGTScmE7h9Sn2NRRzMoJ+kZNCOG57MO2KooDg7u65xVghTgfV960LmVvTO/g4 oySZtpABgsvBoPpmTI+1LhLQeirL9MhIzXPP+Nax9x1T5OIfTvJZ9mWYgc16F9M5aCPC7SO5Arhv yYWYn0iecp9SPgGu6On4XEUWfp4x+9fF4u8n0s/4spjyHyOT+1OjK6oRsyPtTaKNx2Ofv80cSygY xX28Hys0N1CDJaMDxkjise6oQwdPFQcjbnFT3UUjflioHO4Vj/W7GPREX3Zfb3r2cXt4+SudOrQ3 pyAjHJOa508R7rMdwE5xnmug+rpZSsuCOCRz8Vzl4kyBfUVeEBzke9fVt+L4nJ/Jzx1K5knYng1B RKBjjip7qMoZ3LcHORUDbglNxJ+rsK+TyPrfjzUGAO3NK2/2pIGFU55NKXcQcDcR7VwemrsN2NtK iVc5YHPsKpBnscUskbcAkEe9aZKmwxDDuabyS7G2nGDRUPpnI+ofem0oaZ8hRuNNLt6j7CAMnP2p JYscjjFFYLk8kn7UlxtB9q+m8fS+4F8j/elk8d8UFThjxRX+T398UTpbJIABwKVt47/eh7iDzwtL zxRFMxHB5/akepycmrkNt571RIH9OWPtQEDBcCkby0hHAH2pDbs+3alKFOCO/vQEYZAx3qpDk/NW 3CrIFlDknafagvgh+QCCOPtVmIPYc/8AaqZxheO1UMufg0TS2GZcY4oRUlsYwfmnH5vZlSucfFWW 6EmBtGB70NLKgG0gkEcZzSDw2Bz+9Kc/GKGzM/bANDRUuCPp7/FN+36acZUH6hgn4pueN2eK1FJZ sD6hk0nII/tSz9YAPPwRQXUjgHvVXoOQK+FB4plIxwwHJB70WSMxsSM/tQ/V+nlMH7VdnRADH+rj 70rK92AI+Pmhsm9s+oFz/TVTN+WAzhifmo0TL6OPpiCtnkihR/pPOPiiTYVwuASRnih5AGQckf7U FzKye1Wa8kkUDGAKGGJIyaWwwwHyKgHIu85A5+asqE7ccilqSD3x+9VIx7f9qooOdvfGP96G8p3b QO/xSsbVJ5JpCsE57n2oLSw7+Oxb3+KGXKfSfqK07BRFyzZplOySswVufkUFym+Nl9vimN3GoTYu Rge47U8ErRqi8cdzSJAJ0YmQDHx71KMeu7J41LjnPtUWrCOdjtzmpy83SxSEZGOKx361clhgZrz1 0xjYPShVUh3DIPNbX6FdTexiJsowJH+a1J0tKDDCSuWXOSPito9JSflDHtXkNtH2Brw8mPfT18GX yjpbxLg/M+CWsR5zu03v/YV589DKGRUPB3tz+1eiPVkBvPCLUI8gFtPI+3avODo7VUtbxlOMLM4/ 3rjJ2m9cjvvw0t0vfDq4gjYLLJYMpweR9JrzN6cgmg611reT9F7KpHz9VejXl41201TS5rRjtleH 9J7sD8VyP4oeG9p4feM2r6UCSZ2FyrAYzv5x/vTrfa8u2R9FWs01zYtGpdHIyPmu2PDm1udL6Whb UJtpJyFc8KvtWjPALw3lvjb3c0e2ygIfLDIJ+Kf+ZTxgXQdd0vo/TZPTusrNcFTjC44FYk72727x mLAfNJouqaf4kWevaizXmh3Cj8qw5WEfH2NbX8ueu6bNbLbxMrytyhA5rJ4NN0/xs8MG0q+QJMYw qludkgHDVqnwE6C1jo7xBn0u6VhFaSH+aRxIoPcVbOnPy1NM78TvHnw46B6sm0vqC0gm1EAGRmtl kPI45IrX2veYDwt1y2kt9O6cW5upOEKwCPB+c1gfmt8B+uOp/Fm41/QdGutUs51TBgGduBjmsH0r wj8RNKkSa56O1RAo+pvT4xUx6ML327M8A29bpG6CjbluF+MjgU26diTru06n6TvcxKs7bpQMkA/A oPlquXk6dvInjaNkcAhhyD8VhuhdTXXT3jTrNpv2+rdncD7rnvWvt192s38LbdtM8P8AX9IdWDWk dxEpcYLKFIBrg7RNAjs7aG5/Nj6pHJj9x9Zr061Owhj0vUJoolRpbSTdtHcla8stCR49avIJSx9O SQ89h9ZqXpxt7d2+WKVZNDu07hox2rze8zVrp/SvmF1vFms8Uyuyp2G7Jr0T8rwmi0WeYrttmiJZ 24xgV5j+ZvqKXqjx516ePY0VrO0W9ex5NTCsfk9ZRgTXEs0vMYBJzgnsKfWcDXF9CgTO401YGaTe VwRwAKy3oXSvz2qwOv1+4Fd8v4pG5+iNPNppPpqhaRlGD8V2f5YNDa6tVu5YzH6IyGIrnfo60tIr a2t2gRpcgk+/7V2v4XQWPT3Rz3sgW3twm6SQjAAA5rxyXfb1a1jtrTVPEO0i8wMTM/8A6aI/l2f2 H3rGfN34fWQ17p3qKxT05r6RkuJB2ZQAQf8Aesrk8cvCi61+YLov5m8DnNwsA+o575zWX+LFtZeJ HhBeXWmwmWWCP1LYY+pCMe37CuvqONvZHgV09BJ4cyW4mJF5EYyB/SCMVrvT/KDdWXUkl2urobJp d5XHOM55rKfLBfXN/wBLXdsXZHjUpuI/Q3zXC/il5gOvdL8ROodMh6tv7a1truSL+VJ+rB7Ck9NZ Z3Gu2vM51lofRXhHLoFjcw3GozOkcdrC+9vuTjtXNXh0jx6tpwZj+pdyn2rTHQi3/VetTajqOq3d zdMcqZiW3/vW7en1uodYtXmtZI2BCgBTyPmsWmGO8tus/Hm2XVPL/qiOdw9FG/xXIvhRfzaYNNNu /pu67Gx8Zrr7xAcXvl91BpFKE2nZhznFcN9BdRQ2/wCRUOBcQPhkYEY5rMt264yedr0B1e2jtvBf VliQMDp0rEfLbO9eKNik0ouGi+uVmdiX+dxr2i8Otch8QvDS7soAA720lvk9iWUgV5N+Ivgn1L4W 9ZX2iajZzRyeuzxuiHbKpOcr9q64dZduOX8q1nLYpJKLglhcJ3TuP7VeN8nP6c9zWe9T+BPX3SvS M3VN/pUlnogG5nuFw+D2IrX1g0H5NS2WYjBz7GvT1fTlcWXdH6SmvavDbqN6nvXV/Qfh+dJmsksr NXuJQN7lf01zP4PXq2PUMLsqsFI4PvXb/QfU1tDqtjCVUkgcj3rjkvHe3QmkaTp3hF0A2vPYfnNT EIchO7sf6R8VrnpPzLavrnU0dtrmiMmjXLbDE8WcZ7d+9bt6l6qs9C8PpNTntP4hawQK0sIG7Ax7 itCyecbwwh9P1Omrv1IyCAtuOD9q52t23faB8xfgLoHSmoW/VmjW6WsGpXCrLABhQ7e4HtW3fLcl rZ6RcWsEaqWAycd60r4teZPTvGLSbTS9K0u7tLaGdZ2nuUKnI7AVtDyx3Mkjyb8EMDjBrW7IRF+M 3j9pXl16neG30uLUNS1D+ZJEp28VjHVXin0v469ByyXemRLqHDIqpho2/wDl71z55w7yXUPHa5W5 kLGJSMjtj7VK+EUbN05crGpIPuf+9dvH47eG8nnyeLs3y421tB0rJaRQxqSAWLLuPbArCOv/ABr6 e8BurptCg0KHUdUvpPzEqhQuAfcVkPlruJWWdWQqpUnmuR/Mfq76h5lrk3rEy26LHGB8ZrOP268m sdN+de6x0Z4v6bZ30drFaayrqiwJAFYE/JHett6ZpPS3gr0Kmq3ttHHK0YDFxu3v/pFc5dLQQw9R 6bJjb9aHB7Gt2+bDTp9W8H7eW0yVhnSZtvP0gVz9V651jFdIdbdH+PZvdB1bpu0gWRSIw8SlpF98 NjiuXvEXy3WPg34iXVvp9qI9FvmMtmrNu2pnBH2rPvAwTP1jYmzP07Fxj/8AWrPPORC8M3T86vl1 XYwHcjd3pu7c7jKy3y6dNaHN0fcWY0u0mKj6nlhVixI+SKwTqvxd8NfLvq+paRf6fZ3uqTT73t/Q VvTH9wcVnflduS+jajnkKFOf815ueb/WG1nzGdTs8jD+dnAPHArvxyZXVceS+Ebe85Fx4Z+K3h+O rdAlsbDVbZQ3o26qjOT/AEkCuMNLmM9hF6hPqHsppxew28sDQv62w/UMMcZoUIDyI3II4FeyTTwZ dpHTNMbXtWt9ORioZvqC+/2rszwY8AtB0tLVry1W8kuQNsTD9Jrlfw2W2Xq2ydDvIkG8n5yK9BPD 2RI+qtHQLuXcoIH3rzcuV309X4/HLd1ubTuiehvB7pI6tq9pausijHrwK31H+kA1AHpLww8y2kX2 mTdO21s23+XNDEEcccNxjtTPzyevbeHGivbkiJdRTcie/HFYl5d7m7g65tEsyzQyxAyBTwePevM9 vjMow/pzy/aX4X+IVvo2piPUbDfugaaID1UzXTnU/ht4b6TpcGs6loVhFDbqGT6AN/HbHvWvfMu5 j8SukipId7dlOPjeaH5rruS38LemJUk2N62MZ5bgVzytsLqYTScHhV4Q+Pmj3Fv/AMPW4WI7D6S+ m6/cEV5p+OHhk/gv4p6p0zE8k1h6rPah+CIz2FehXlZlkl19yeQ1sSSf7Vy3+IxF6Xj3YNGAC1mm 44rf4vn5dvH+R/Hcc1GCSPMjKFjHyaXommrqXUVpH7MQQvzQzEZISzNn5BqY6SlS06o02Zx9KOCa +jyTp5uPqx334IdLBLrQbL0wqFNz8c/apr8QDxI1fw28JtPttHna0a/uBBLKhwdv+kVXg3r0cuua LcDCxlNuagfxNrD854S6DdKSyR6kobbzxjvXzcJ32+pnfGRxL0Z4w9UdF6zDqGn6nLFOWA3sdxrr /wAOurdT6q13SNZ1S8kudQnkXdJnAx8Vw3aWsKiNpHJjZgQa7h8BdU0yW30R5IwjLIiDPz80zkmW onFbkzfz13V/bdN9Jy2bOga5xIyHGRx/mi+WW/1X+MwJZs8mnyRhp9x3AnFbh8auruiej+mLG/6y tYbyy34t0kQN9WBnH9q0JP57/CXoyGa06a0a4N867YkgiCxs/sCc9qlx12zP5abe1tG03zCaT6Uh P5qH6we+K0p5/f5XW3hvKRkBpV/yRU74LdZal4k+I+mdQ6qiJcTMWWOP9Ma+wFQn4hOF17w7k9xP IP8AtWPKeNj05Txym20/LXds9zdwltyLbqRn+1RuvdKQa/5qJPUPpt+UhkyB/oXNH8skh/i17HwQ bRWB+eRU0zqPNLgEbvyAz/8AkVMPXa8mvLpr/wA6HWnUOl6109oOmNO1hdRGeaO1GJGYNgcisz8s HUN7rehalomrJMRDGMLcZDlW4IIP2px4x9c9P9AeLHT2o9QW/rwPYvHEduTG+/8AVUl0L1VpnWXi Xd3+hxsLb8uglk24DV1mtsT+HbzN8wXhTZdLeZ7XemdJj/L6bNcj04jzjcMk/wC9dX+Ff4fnh91D o6S9QQTT3LRKxZJNvetIec/UYdB80l5egq8iMkhA9iFFbM8MPxDdK6O05rfXNIvblY0C+pAhJwBW bbctE45cdz25r88fln0Ty0daaMnTt3LLp+tgywwSH6rYqcYz75rRMjNHMqy4eUjcXxjJrb/nE811 t5k+uNHvbbSZLXStJDR26yKRI273bNalvL6LVJ0kjQK+wAqP+9fS4vWnyeWaz7LtVGScd/apG2R3 eJIlDOxApnY7UPPepTSHA1MbcBUIYfvkVrL+Nc8L8o9GPJ34bpHpWnSTIv5n/mb9uKzvzheL+s9C XOg6Fpbtaw6ghlmuUHIAOMU48rUwmsNH2/p/LDJHucGsx8Up+joPFPQ/+LxZm2bTpBE18PoVt5r4 mONy3X2spNyLeDHVEXip0DcaRq0aahsh9N5JcMHDDA49iK0x5fvA+26F8Y9c0l4o52spjMhOCoUn Ix/tW/fDl9APXGrHpgWzaW1rHlrMfyt2ahOkyo8x3UgGMm3Gf8V1x3rxcssZMvKMI82PjvrPh9r+ mdPaUfysU8ayzTj3UnG37Vsbwq1mw8YPDS80vUlS+Qxfl7gyANncp559xUZ4g6f0RceMSTdZNahF sEFst4QIy27nOanPDFdHg6y1xOm/Q/g7BDi1x6QbB7Y4rc3K3bPHTy28Regf+BvFfqLpOJ3e1s7t o4ifdM16F+UHw+sun+mfzhH/AKpFH1EYwCDmuRfMHDHL5n+oQ2AxuMjHOTmu8/By2EPh1cSxgKXt DyPkIam/KzbjhdbefvnT6xPiB48XttBO8+n6YfSRQxKFueQPat0+STwsgnuDqc8CSSjDbnXOK5V6 hkS566155nLN+cZS+e/Jr0A8mPHTzqowAi5P9qxz+5pfx9ZTK0bzWeYjVfCHVND0LQ/Strm9T1Xu nUMEUHG3b96zbQzpfmO8GZ7HXLeK4/NwmKUYBIbHDr8HPxUV1z0B0n1f4vRydVSW8yR2x9GCdsc/ asl8KdJ0jpvqLWNK0CdZ9JjiSVdhyEcnBUH7UksvTc1cXO/lA8HNF6P8QepNJ1WziutSsJT+XEo3 bFycVnfmp8xOveE+u6PoOgW4tmuEEr3siBk25xsA7ZrFLuy6kuPNtr3/AA2SkYkhaVl/QFA+rNb/ APEaToKGG3PXw0g3PBiFz3//ABff5qZW+oYyT2bdGmw8dPCaKHqezi1CK8j2ToyjBJ9x8V5Q9e9O Wfhp45dT6FpJ36fpl4yWxz+kA8AGvWbVY5tW8LbqLwylsLZ3gYW74OwcdlA9zXj3rtnq2m9Z67Z9 QM516K6YXJk/Xu+9bx3Z23x5ayenfk86+TrLombSb6YzzRR7NrnO5WHIrgPzXeF1j4Z+YHU7CxQ2 +k3cnqQr2CEkn+/NdT+QGdmudu452NvJ9+Kxv8T7pexh1LprVosR3s42SEdyMnmunBlun5OGsppx vqmkR2N9HBa3f8QifG8gYxmvSXyNeFadOdOHW5Mb3X01Ue2ec15vdNW6z6lAiFiRIAxz3Ga9avBC D+B+CDXKfRJ+TeXj5Cms80n7Jt1xx8eKuCPPl4p3PiJ4wyaCt0G0jR/5aRL29QHk1uTyPeM9n0+4 6TkgjjS5I2zMcc9q4p6z1M614h9R305Mk0ty/wCo8d6meh9YvNJ1G0ubOSRHU4+k8jmnJNTyjPDP OeLt7z1eWyHrDUdH600a3aS8DLa3EFtCNuwnPqkj3rdvhD0Pofl78HBdX6wWzJb/AJm8nfA3HGVX NTfgB1DqHWHhXps+s2pWUAQ4kH/MUYwxzXLv4jniP1DpqaV0rDb3Fj0/cgMZ1OEuzgcZH+mnFh+z 05cmVw+N+mQ+VPraz8T/AB66t6ngs4bZLhGEUaoBsGazvzI+byw8AepE0m46aGru8Sybw4X9X9q0 p+HdHFB1Tfqjbx+XOWPzXQvmI8u3h14ualZX3WGpyaXdABI3jmCFwOw5FTGeOV2mV3rTnS6/E/06 T+XF4b/mHPsZlx/uK3H5KWseqNG6l6ibTbe1udWuTO8IUEIrEkL+wrWnUfkN8EdMsjP/AMd3elkj AllukKfse1Z/5E7S30qz6o0yyuhe2VlP6MFyp4lQMQGH71x5bvOO+OM/XaifxC/AnTOq/DO36p0/ TFXWtJmRAbWEAvEx+otgc4+ayryJdO6SPA+L/wBFBLK1y4kMkQbPAwOf71tufU4usrzrPpOa6iW5 aIwwQTc4VkP1Y+AT/tWv/Kfo1z0PYa90hdbTJp1yx3oCA3OMj7Vqz5SuUvwseY/mDs4+m/M11dLZ xxwmG7jMKxLtVD8gDtXpp5cusYfHjwOn0jWJVlnFubC5UclkxgMfmvNbzYWp0/zN9ZRNlj6itz8m usPwzNXmurvW7dnYwi2BCsexyK4XD/Jt6JjP0OCPMP4V3fgT4y670nKeFcz24HYo3I/2rA7aU7Qp GH+K7l/Fp8PbfQusumutbd2a81NPy0kZ7KEAAIrhOFZIJfWc7sDbX18eOTCV4JyS5eIvrEvjt7Ui VzsY/btQWlJUkDBz3q4lf1R2PHY9qxeo7zuxNdJ6QdV1mzsUjBmnKhSOdufevbby3eDuj9E+D+g2 dzpNlPevCJJ3mtlcknPHIryb8s3h5fdZeJ2i2VlH6stzMpI+ApBNev3jR1z/APVb0HplzDMsE4ur e3WIHll7MBXj8vO7ejlx/XJHnN+JT5etM8Luv9N6w6dsV0/S9YOy5hiGI/WzyQOw4rKPwzfD7RdW 6u1efVbKHUZYo90SzqGVf7GupfPT4ZWvjB5cLvU3laGbRoxqsCryHOB9P+9cz/hizyR9eSxNwZLZ yw+4U129enGZaxdleK/ij4P+Dmo2mm9XWum2V1dx+rEi6crblzjPArDevvLL4QebLw+TUNL0+2sZ Z8/lNUs4tjxN91Bx/mtVfiEeCHXHij170ze9K6Bfaxb29kY5XtVyqt6hODW6PJb4W9SeGPh/NH1G JLaa6ZSljL+qHHfPxmpKzZLjvfbhHwE6b6G8tHmK6h6f8RWW6s9OcwQzzRbw59iVr0a6E6V8JvFH QxrWgaJpt7Yu5X1Bb7ef2rzB85Wv2Ou+arqxI9hjtZcFoj+sjPJIrvf8PSb1vBBCE2/+oJ3HuRmp 4XG7av8AHcYJ5ndW8r3Q7an031dpdumtKuTbWkBDAleDurzx8H/A9fGnxHl0DpmB4rG8vWNvOzZ9 ODPH+BW2vO1JaHzndRG/tjd2yLGWiJyD9Irpz8NHovTzN1N1LFYpEJCI7cY4j55A+Kzy7mo3xZSY 21m/Tnkz8FvAHoX871stvqUqKPVvrw7Tn3Crnmou98pHl08yXRl/c9I29raXwUxw6jDKVeFx7lM8 iue/xUuvdbuvFHSel47qRdMhh9RYo2weQCf3rj/p3xU6r8PVmi6b1m/sVnTDFZCOD7d6mON36cMv LObY/wBbdFXHh519rHTM10t7/C5zGtwhyJBnANN7eMXExQjaCcAimkz3l/qhvbmV7ieRi8rSHLMx Pen0b+iWLoRnkV7NGE1O1jb+nIQn1AHGRQyhWV4mPB4BFWG6SSQIWUcfp710L5S/KzqPmH6u/LTx PaaHbMHurxR257Z+a48mVkeiYT3XPskv5YhDA+xRzIoyatp89vcl2uJB6QPEmfqX+1eznUHhx5fv Lh01bafrmjaXeXaqNq3UYkuph8/tWD+OHkc8OfML4YRdR+HGmWfTutNEZbc2q7Y5/wDpZR/VWMbf tx3N9PJ+SNI5VS133LseQRwB80lBbC4kb1D+Yj7xd62h4Z9B3UHita9K61CyPa3/AOVvYsc8MODX rP1r5KfC3rDpSyt7bpvT9GuoBFL+et49rlVALBj7g+9au/p0uUjxNi1kgCVEiDKfrDkDA+aubgz5 aI+pGeSdvH3r2JHhL5Zuq5rvpCDSNAm1SCHa8lvj1A2MZB+a8+OuvL7pvhx5jR0VY3xvdElvYWRW YEqjtyprn5WN43HJzvDNDK+bciXB+pS2CP7UU6hBFhZNkYY45YZr2C8W/wAPLw46q0Oxg6f0eLRd QikQSXEHG5ONxNRq+Vjy19SWMnSsM2mXGtww/l5TbzfzxKBgnt3zW/K6c88sb1Hkogt7hHeR/SiU HlOc02a7iS3J2qY17ZbBNdXdL+QvUNa8d9U6E0zUYv4fZEz/AJuU7gsef0kj3+1do3Pkn8BOgNF0 216mNpbXciqhnu5QrTP2O3PbmrM/KdJZJ7eRKzwSQJNC+9ezY5IooiWA+stsjs339v2rv/zQfhq6 RofRd51f4YXt080CGefT3YOjxAZLJj4FcWeGPRSdcdUaNpErNHFdXX5eaQDDrg81L37aw/0wmLUb eZndV2YOGQe9NJr2NZw4RYw3Iw2cV6o+If4XPQU+h2V/01NqEGpoYhLGXDI6H9bYxwcc0O8/Dj8B tcsrrSrLqC4/jMEZLelcL6gbHuP3rjMct6S5Y15YGVsluCPck80VQCpYKM1O+NfhPqPgX4oah0lq FwlyYm3W86nO+MngH71AW5xvU9h2rvJrpneyGLNg4C0pLpLeTO3fzyAM0MRPObgjAKLlQfeto+X7 y79ReYHqaLTNEhaLH1zSsPoVR3JNLZi6TG+2ube7tbu63ANAD33DtRbmLTlmRbS5kus8sWjIC16g x/hU+F1ho1m2v9TapFqMqhJJo5lSMyY5CjFcv+aP8PfqfwAsm6g6e1Bte6T3fXtUmW3Htv49/tSW tXLDWp7cuOsXqbFlww7ZFJDmI437sZzXU/k68klh5moNTv8AXdUutMsbPiP8scOX9v7V0D03+Edo T3d4nUvVtwIWbFmtg2HZf+vd7/tXTf2nlMXmkCGwzOwRjjJHakvHGxxETKw711v5rPw99e8v3S11 1RoN+Oo+nopAjwupM8S/6m4xjiuQNLuS5WSE5JOT9iK3O4xcopt0WVZSjDuG4xV7WD81cYaX00wS Wp/OZdc1Iq21Z52ChvYU3u9Il0u7uba8YeogG1o+xqZWTtvHG5XUX0XQ9T1+e3tdPtpr+6mbCRQJ uZhnHauoOhfw0vFzq/RItYS3g0yO4GViu5gkn90PIrpL8MTy92sel3HX+r2ayXQPpWIkXKkHOXH3 p754vPfq3hl1mvRPREyR3dvzeXyn+Ykn+j4xXCXLK9JnfH4xxN40eSTxa8CNLOta1osd9pOcNPp0 omIHyyjOKbeAvk48QfMRZXWq9L2cMFnaNsaa6nCKX+Oa6x6U/E40vUfCK96d6x0ibUuoZrWW3M8i ho5WYEAnPxn/AGrd34Ya+p4K6t/LCRNqbuAvbnnj/NLld6c5vW64uufwtvHXkxLpbk+xvUA/71o7 xm8sPid5f7yCPrDp8m2uBlbq2f1Yf23jjP2rufzIedvr/wANPMBcdP2kkUWnWjJm2hY7WTvz9yK7 D1b+F+PHl7bUNW0qCaDUdPNylvcIGWN8HDLn3HzVu5V7mrfTx58PfJH4weKnRf8AxL01oUU2jSqx Vbi42NJjvtBPNaRv9K1TTtXn0K906a11W0m/LmzYfWGzjFe9vlKsRpXgnp9qDlbeaZF4xwCK8jfG 8yX/AJ1OprwKAy6pGw2jgEEY4pbdbaxu8tAdReSjxh0rw4TrBultukxwC6lEcm6Yxn32d60t0x0r r/XWoppuhaReahqBfaIYULMD75/avf8A1nWZNG8BJNUIDyx6MGwyjBJjHtWjvw+vB7Remehb/q5L GE6prN5JIl0yKXjXJJVTjgGrN6YuXdebVx5BfG3+F/xUdJEBVEjATZYj7LWkurdE6i6T1pNL6t0i 80WZTtRLmMoX/bNetfVHn/1vp7zG33QK9OWs2jWF+bSW6Af1mGcZA7VsnzveBnS/jN4Ea5qd9a2l trNnZ/m7TVJVCyxADO3P37YqYZbvaZbk7eI01raxqrWkqMHGCGONpqGeF0V5EkDSZwIl5z+1OtB0 W66kuLKxtbNp7mWT8vCqfqkfdgV15qP4X3jBZ9EprsMmkySJbi6FlEf56jGSP3rp7q+PXbj+OZ+V lhZXA+pVHNTPTtvYXysl/dNYxEHJKZP2qPe8uNI1SaO4XGoo5iuFcchwSP8AxUjfWMystwCpDr9S r3rVmk0jGtxHNIkL+qikhCRgkfNIcu5YEAsB2Jp2pAmDAcqpHIpVtYLe3caKA7OQNw9s1zyvjNtY YXO6hOmaXrGu3ostOs5tRvG4SC2i3Mf2x3rJ7rwU8R7S2Elz0NrnoAbvps3JxXrH5AvK3oPhl4ZW fV+safFJ1FfoZvXukBNtGPjPas36f873R3VPju3h1YJJcxlzaR36KDHJN74Of0Y4zXLHO+6uU1fG R4fTyoFktSkkV2hClZU2sh9wR80Sx0q81DUI4bOCe9uXXattBHuY/wBq9LPxJfJloseiP4n9J2sW lz28n/22toBtWTcRh0A7Ek81sb8PTys6P0T4fWvW/UGnxXOtX6erazXCgiKHvnB9/vXXK3rSSzXb ytvfC7ryztzNN0brqWwXJY2L4A+SaxW1aEbywdJkO1gw5B+K92ekfOB0P4h+L134cWkEk0ql4Flm jX0pGX9S49xXF34l3k70roa3i8TOk7ePTdLknEeo2EKgKsrZ2tGoHAODXSMXe9VwLcruhC4Imbks o5xW3vCjyg+JXj107Jf9JaEq2lvw01xN6e9vjk1g/h3o8vUfVGmWVvG07zzpGuR9+RXt7M+meWHy 6T3tvFaWz6ZYeplhtWWbbkA/3rhfPy0656xxeDWt6Vq/SHVmsdN65bfktV0xjBJEOdsg780Gytpr 7bCqSSXB/SkMeWY/tWQdTdT3/ib4ga51PfwD+JavdvNsUfSCSeBXqx5FfJz0j0R4aWfWfVOnRan1 DqUZnkOoKGitEByCoI4GOcmr5d+JrWEzryOvdF1PRrZri70y/hX2ea2Kqv8Aeketb3NmGXgY+sAV 7idHeIngl449da70LYaHpuqXGmgrI8tuhguAODsPvXnv57/JfF4Idc2esdKB16Z1+bZBa92gmOMr 2GF5GK6TtiZTfbj1JVcpHbRPMmQNipkk/FObmyvNPiaaWyuNh7GSLaq/3NewHlO8lPQPhb4cab1b 1Tp0V7q1zY/mbz+KKpitfckAjjj3rK/DzrjwD8bOrtT6R03pfTbi4t9yq1xbL6VyB3MZ96z2XKfT xMhX1YDthU3B5Cq2d1ZZ4b+CniD4wQXh6W0CbV0tifXlXKhMd1rqf8Qvya6f5f8AVbfxA6Q/kdP3 1wI5rE9reQ9gv2p/+Gd44XXQniiOi51gbTNflLNM/BjfGe/3rOXlPTvjJcN/bi7qzRNZ6a15dE6l 0abSL6E7WSdCjDFMJYzG7BY98Ps2a9PPxa/AJdc6S0rxMsRDbtpLiDUGVcSTBuEP3xXmKnrNFzIr IzYQD4rphvx3Xm39A3MdvJZTqr7J8gqw9h75rL9F8CPELqvpWbqPRumL2/0S1/XdLEece4+RTnwu 8NtQ8UuuNH0DR7F7ia8lVJVRckrnlj9hXsz4pdXaT5Q/K0FuIYmNjZiwgS3iHpyTspwSPjvXOW26 dMp44yvCea8vL6DF0oV4HKEP9JGO4P3qRTUrUxhERGLDBJYZFbK8BR0zrXjxoOpddQRSaHqGoSz3 ltJ/ysucjP2r0580Pko8OvEfwOv7zoTp/SNF1O3hF7bX9lF/zolUkoCM965zkuVsn0tw8ZLft47e mVlEbxhYv/woaix3Udqp9KVJQTjJI4FdQ+Tjyi3Hjx4im115GtendFw9+o4kkGeFU/vXTfnb8tPg x0hp3R9pp2kR6Jrl7dxwxRWYx60GcOzf9X3rdyth4yZSV5izsQVkaZSpOCVbsPmpDQrvSobm4N6D LCEOCzZIb2Ne2ui+VnwK6H6Es7zUelNHXT4bdXk1DUU+rt3Y1hOs9IeUS/Xa9x0fbFQf+VMAanzd PPDbxynvE4ME6yQl9pHYinMsVg0amG7DXB4MZ7V3x1t5ePBLrvzIdF6B0NfW15ol+ANQTS5Q6L9X bPsa3N40/hj+Gmp9AanJ01Dc6brFlA89u3qZV9ozhuOe1J5fa5XjkeTsTrcMYTbJvXgszYH+aZXE TW5lWGKJ5B3xJxXTnke8s2i+YHxR1LReqnuYrLT7d5dkB2sxVtuD9qn/AD9+VPory1dQdJ3nTwvv 4bqkhW5gmbIAX/SfmrjctueWutOQIXe5s3uAlzNHG2JQkZKJ9t1NYUhnZwcxwMcxFj3+1eqn4eWs eF3il0/rHSUvSFlJcI3rot3bhzJGBgliffNcXeefy+zeCPjfqUUNmLTQdUla6sBCMRRqT+hf2rWN 8nDK2Vz/ADr6ixjC7AQePtWwegfDKx6+XXdQuBEHsbHdbl5dn8wfasKhiWS29RY8KOP2oTtdaa6t BdSRJN9LrG2Nw+K2HnRnWn/AWsz3sdn+amkjktd5/o3DHFX1Hp+ezitrx7mKeOZdxVWwy85xim1t bqoYlAdv1AGizRQyNDPsOTwSp5A+1S5ajcwuWWoUcemkaL6e7tnt/c0JTCJzFI4XB2Fx2rrbyN+S K28x38Z1Xq2fUrHpy0IFu9sdpnb4BIPb3onnj8jmn+WO10vqfpSa/v8Apmc+leNeuGMUhJ2qCPkC uc3e2ssfG6rkmSOKO59JF3o3CsG96vcaZE7ykXBWWP8AVGgyKzbwD8Gbnxu8VdI6Otbk2a6jISZn 7IgyTj+wr0mt/wAI3wwtYEJ6k1yOYgI7iRQC3uB9qsy8uo1cZjryeTQjh1G0eww0KTfSZGXAOPvT gXGpT6eun3WovNaxHCxuxIwPge9ejXil+Ens0S4l6K6oe5lgyUtb05L4/pyB3rjjovyw9RdR+PEH hb1Sn/DuqDJd7g7Sg9jn711kqWS+moQ8EUpKbriNuC+39NVeNb20S7mZ2fsQOM/vXqDYfhC6JaxR FOrLppCo9Un9LH7cVC9X/hCRrphXQ+q0hflpDd52D9uKmrtm+Mn+3mQbdolyNrHPuaQ99PHLsWLm PB3Bcg5+KyHrHoS66G8S9X6Ujcate6dc/lUaD6hMft811b4J/hg+JXihokWsa3cxdIWcn8yK0u1I ldT2IwOP708tXTlJbNuLdReX8+AWZJZBkRsm0E0u8ghaygkfMdxG53jtn7V6A9e/hC9cx6Y9/pXV Fjqd/bqWjgkBDyYGQFOMZrgLqfRNV6b611Dp7U7SSDUbNzb3UE3dGHc1ZNp5I9HFyC+QqY7Y71Sk hN7KMpz+9LS0mhZkCqIl47c0llk5U42nuaqpW6vtakghS/h9G3xmL6MEimhn3tk/UR81WoareanE qT3pdVAVWk4wB7CkaHo+o6tffktMtn1G827mRfYfNQUVLuZXRcD2pusKajOCF2nOKJNbXVpdlrwL EUYo0Z+R80pZ2hu1ng2sIzvCexpZpILJpdzG00McLSNGoZ9oyFHzTdbXamTwTUrBrt8kd/LG6x/n F2yKvZQO2KhopbgoSEaSNTjcKkposxqMJ+kj3ql9IKdqfV7n5q9sFuLWQzho2Ddz8UWXR4rST/7/ AIpkIzleau4aI2ByAOP2pBQBiCKRCJDcbI2AAH6j70S6UOFEkixOTx96u4z2GzkALjIpHJB4xzxi kzW4hUFpCM8kH2q8cMskSyQZkhJwWHYU2aVJCC30jnscVUcK4IGcD5pcsbx4G9Iix4LcZov5aNWX ZcKXAyQxyCam2tbWQwxrhozuz2NXubiF2URR7B2NCadprpY3ZS3YbfegywzJK2eVz7fNXaLu4s5i 6sTjsDRv4zHbQOVjYXEh4Cd6RJaPGIn4YyZ4PcUW0h/ITCWUB8j6T8VQJ1nDp6oP1jO0+9ARFdWL cY+adX1xJNdxOxIBBAyO9BFrsjkZnyx5HxUO1ivomIKNwf3+KPNcNdGIS4+gYXAxTe1b6Tht+D2W iukjDO2qnS6IHcjGKf6dq0+lWd5axbDDOdzK6AnI+DUfGoWM75AD/vRrawubyJ5YImkiU4MnsD96 IHJPFdBcQBJu28USGKBJDJNH6sq/pOcYq0dqY9ynG8HmlNbMr8DI+9FhX5ibeW4IzgKaDer64ZsH cByoFEW3d2AB+oDtTdLyWK6YxkOwBBiAzv8Ams26bmO+4PZIv5Fd0m9WPAxxRpV2rgfy1HfHasg0 Tww601uwF7pvS2pXFi65R0hOz9+1Qt7Z33Td3+W1vTri0l/9yKZCBj2708pYklt0bQxh2VYwWUnO TT9RJEGJVeBnd3px07071H1PZ3yaFotzqVrHIB+YhjJEZPYZqbm8POrtJRHl6evwm36v5Tf/AEVZ dxvx17Y7b7TOqhVZpjsTAxljRtT6dudEdlvYnhkzgDHH+aDqkt1YyQvFaGEqckSqQ4P/ANNZZqdt rz9CxvrGmao00jevFdyRfQYj25x2rX05WsKREuV9M52r7/FWjsYILgSs7nbzkj6f81Usr2ttBI9s 6KxwSF/XWbdadQ2+odK6Xa6boFzZCKLbNNPCy+o/24pEs1IwXUr7+J3gmcBVjGAR2o+mQ2Rsric7 vzKP/LUDgr80mKBkaOFYlRXGWjfuPmsp6M6klttL1bTbLQLfUpJ0KxSvGWaL9uO1Yt1XSY29sSth 6E/5hJPTk5O4+4PtRSkLqZLeERO3Lg/1H5pB0e+jjIlgZChzKGUg/suaJEfU+kAj27Vqd9samzRr UtJueTYOxVRRb8JYW8Fxa3BNzFIrxuR2IpdzG9qwJVtuMZNAlLXMY2J6m3k5on22Np3jx1RBH6kb mGZk2tMBkOMY7VrfWmu9ZuJbmaBgHkLtz+on3qT04S3Kb4lJCcMij9NWnjullKu2Y3H0jFaRDxwv G8LpHuiU52k4FSV00dyFd1VT8gdqqPbI3oDazr9RU/FWj1IB3hW3WZOxZRnFS3SSbKQxRQZik3M3 0ke4FLtdPQp6UYI+rcS3vRlUQKjwwQsPcFDuo8d3HOSpH5aYf0vxTG+XpvLHLG9g/lQ7w2kWQi/q AHNAmtWgvGgMsiL8BsZH3pzczJZXEZWRjc/64+VFJnnSab1mVpZcckKe/wA1Ptjx62VA6GF4o487 fYDtVo1LEERgAdwKtYtNa+uAwAmxke4oMs9xpvqgFMMuSW9hWtM62LK8b59JgSOCoq6QYVSybVz3 PenPT/R+u9RWd1daHoN9qcdsoa7uYIyViB7EmmsAuI2ktZmztblpB9QNSXaWaSACpHtJAQ+1Jitb eaRxLhkx2HFNoMeo6v8AWU/SPmhNcoyuyoc5wQB2qWz7WY7jKek+kB1Faz3d3djTNMhJC3BGST8U bUekliBGl341eMDJ9NeRWNHVrl9KW2SUvahtxiiPGfk1I9I6+/TOpG8h2qjIytF33EirLv0knSLM e52Vjtdf1LjkVdYgQdv1H2pbaiZLq8uhbsWkJZgR2FIiaX8s0saq0Z5DH2NJ6WQSW0EcUTO26WVt qxryc/tR7vS5dLkSK7iaCdxkI3HFMNJu75NXtrmzt21K9gf1BBChZgfvxUhq+vaz1Rq9xd6nbfl5 l42uMen9sGszLd0WdGoiB7GrOF9Fgf1j29qKsZjYBipb7UmcehKVC53jgn9NW3RJaEhWJQWYEN7U TckZ5pjCZZ2McUKzzZyBGhINGmunECGeL0LgNtKYpMpTWjpX9RQ2MKDyPmisEaTI4B5GaZZlRg5y Uxz8UaOYTBHBBUtjb71dro5IXOBg0oKEUj55prJJFBOYw3759qKoRZWSQvjuCPertmzRLRSbmDDH HAHNbT8FLW36g6Q6h6ZvJVhSYGbBOPrHatYFWchlEgQe9ZP4f2RuOqYFgllgQxM8sh4HHzSTbGTG nsWs7ua3K7jA5iz8496lr7XdS1C1t7e4vJbi2hGI4mYlU/YUPU9w129jj/mD1m+odqGoCKxDhiDy vxWbCWrxQHcWYjnsKMVUEKOfvmkLMqgGbCk/pyO9XubqC3BjAJnxkAc1K0eG0EKA7vqcdqE6kLgU Gxmnm2iRWUgYBfgU7iDHIfAOff3pLL2hCuR7f3q+Fj5PPvRJYDwWZUTuTQmQzj6cFPZqqVKWN3BB BJcb/wCepzHTc6reXV4ty88iyA8FXIwPigC3AEaAY9qXLDJCwAkjRc45p7BGUNOSQcucn70u7mRC kSLjjkg0JTK/DyRL8GguG38kFvdqb6BEH0kEDPzQ8MQBVtjyE7JFOO9JkHoKvqSbSRgVnYU0OeRz SNu3FJ9RwRtw4PxVPKXchZF+xrUoNtVjyMUExrvbB5+KCZGkXi4hUj2oqvviKqoLL+pqpoEMMlEy xPzQsMoZWGxvYGpHSpvy0zt+X/Msw2pGoySaBrVnqEFwzXdjJYyNyEmGDj9qm4qPeL1ACoLfNNih SZcdj3p/bXBtLOQthi57rRZtKljsra6J+m5JCqKu1R+15CdgG4d8e1XG11ORk++KoIYQSowc4JpD EozEcZ+KuxW8QFXYcnjFLlkEYKgAnvkHmkRBmDHAOf8AVRVsWgQSvhgeDQCkt0KJnkEc0MJ6YYqO B7UV0nAyNuPYUh0cjJwAaLNrLIwH0jap9qG+S2e6gdjSnViwA/vijLCfTGAM55zQ0bRnaC23+1Ly CgJGSe9HaIEEDgUL8owQ98ih0IoBIwu6lAlF3EEH4oLq8aB4pVZsfppUc87f8yqdHVlp099OyxIX YDOKvpz20eqlNUc29uEYF0G47vYcVVhrE+l3oliA3EbSDSZomuGdzgs7Zaogu6JQCgDLnj5xSJJd 7Z9hVNEFxsOABjBoQgfLYb6T80DmO4IUj5/2onqZhAHDZ702WJhj70ZNy84AA+aAiNJnJ5UDvRbd xHJu3Mrj3Boaqdg9hjgUMiSMEoMn70ZrJem7jTYddgOrQ+tp8hEbAcYY9j/ask6y6c0vQtRKafdr dwOu9XU5C/8ATWvLeR3t8SnLn49hUpZzNcJHbkYiJ9vakQRLgwSZ29u1OUnFwpYnB9xTG5hMDEBi wB96Ek7Krk/2oHUuVJKYYe9GCrGiNnO4VFxzzOVXAC/b3p0n5gEKAhHsDVBMZU8/2oqbFIDqpwMc igAuCM8GlhBccSDaD3IqAuAwyOQB7UMBRyybx8Zp/dWVrpdvGtvN+YZhlifb7VFCcliMf4oHIhIU uf04zirR4YnBwPbNDFxuQgHB+KvGSyDsDRdHELRQsfVXcmOBR7Se3a7QypugGcj5qO9ZmkVSjMu3 9Q7D96pZHjQ+oFC54IrLRzIkLlghyQcD9qMLHSTEjW9y01x/7iN2WmUoJAwMe+RVou5woBPuO9Xt miTEFnIP6fg0Bn9ODIIJalyQOQVGPTPfFNTGI5QgP0nsKhVlcyup+KdrKWTLdxSTbbP0jFESEYH1 gg1tAJsgg98/FFg3HAI4AzV2hwSXxsHY1eVCUYI2Pp7/AHqbUFZvqfOPtVEhsAjCg0pbKZoF243Y /qon5GZQuSvA5qdrsJ1Kqcc0ogtjNVLEwjYjBxSNzBBwB96psVIt4I3bgfirCPa4GCPvV42Yf37C lxMzcd6G1PIpAGOP9VOdJ0+fU7oQW7IpYcvIdooOz6CAAfnNJhYLEyN+mhD3UdLk0+3kgaRJGDZ3 Kc1HWwlTBDc/f2pbPuAWPOPerCOZcncCewpt0hz6wZQN2H+aNHOSmMbiO/3pihK/S4BIPenEahlI 985FSt40Y3B3cpVzMRkdh9qH6cqAbhyKpTtLZ9zV26bXZy2ABj70hAWLcdqcGPCngZPYUgoACf8A NNprsMoHIzV3H3xSt+MHYcex9qWQXJ4AyOakpA0dAuCMmrlVYcDj5pXocdu1W27QcjP2ogLbX7nk f4qlK/1t/ilqu5e2D96JDbxT7t7EY7AVA2cbu5GDTaRGZm5wtOZIihIODjtTKWQJ9JOf2osJdBgE GgZCz7v6fcihPKS+c4+1WM5HIIB+anbezw36TqE9ADHueKYTKTKc9vileoZDg9vYmriIk88mnamt qs1zMyRpv29/tRHT0GKsMMe9WikksJ2KMVLd8VVy/wCcG5P1A5qpQbi3Ujev/MbgCprojqmw6U1B 2vtFi1V3+kPIR9I+1RW1ig34LjsRSBCVZZHRRzwaH2lOpNRs73U5prG3/J2zncId2dp96gWcvdBh 3WnUsZbc2Bj2pv6AZ+DiiL7xgjvzSSBIOaUYtuSGBxVlDYzxUCWZkwiEknso7k/FWNjMeZFaM/DD mpHQtUfS9RiuorGO9miOUV+RmsyvrK81fSLjV9TtBYuDhV4AOfiqNf7WXYccdqLExDFSSR8ipUWP qP6a4YexFCubT8gPqIouugEtYwgw2S3elMmTtIKSJ+l/moue6uHmHpFdqnmnL3jTRBTkt7GhtTow OW5b3I96sp2H6u57UsPvAG05+avFFudvge5ohJyQVxxVgQOwxTowruGyQNjv9qsIQWxuA+5oAJtL duPiqdMjng06ayVBxIpP2oboQO2eO9GtG6nBAPPxVNy7Z7DtSth3A+9WKktjjFAjaWYbW2/JxT+y eyhdTENso7k/1UyDA/SD9VJukI2DH149qGz69uY5mJwA32pqQd4Gfq9xTcxSylPoPJxxRZfzUEo2 xKye7GibFERkYg53Y7fIpMn8kbv6vcUL8xPJdbgCF24zVSM05GRjPcj3obL9cFsnkfaii5fBCnHx QDEVYxgEqfeq2FTnjiiHZLIySIPUfbgg1GSBUmeRokRie5QE07e4kXlSoBPYUJ5cKCSG57Gp6S9h pf3qzhheS5PsWJAFOWuriUH1HJHyakbJtEeAfmjOLsf8rZ+n+9CvFRGCRkSO3P7U9tTGQBDj9XI+ fmpbSLu0dBEIFaQnaT7ioi4PpoFPBHegwzLHKrINsgOdw9qq7S96sCXZnUbSMgoKiXkntSzJMYw5 4A4FPvzKsCZOSc5+9R00iGXBBZifpWgOjyxrzIZDV2n3rjsxqkVYIzv3rOeymhoDI8n0jcvf7UE/ o/UOlaTY7NR6fXVZM/8AP9TGB8YptPrOn3MhktNNFlE36Yyd2Kj4tigFxlT3okgidTsAHxQO5NQS RFUov6cZxTVpE37CMYHekLhVIYZJHBqwy/egWX2ggc4qx2vztwR2FIIweKV3QkfqFDQQlLnhQRSz OVJHcntTd42TPB5+KUr/AFglOaBMvDo23t7+9EabDbs7c1d1BJDZH3pMkREKjIPPegNAMKzt2Pal WzmNWOTuJ4PzQYSzqRnAHanluhkChQGoE/mHAOWwxPtSjOd5Qn6MVdrYoSrr9bdiKutruIDcD5oK TbkZ4X4NFUgYx2+KRIoZMA4YdqSG479qBYJJPH00pm3KoPGPf5pMbAbse/tVY47Z/eou1YAPPIq7 MWPPP2pDHFJzzVQTIzV1+nj3pGce1V2/ei7HdyysqjBI70mV9j2sZO7bzzSAxwaukYnkDYJPzXHk /jW8P5R3p5ObE2nSYVRuLsGJrszQVkniXJxxXJ/lBsZI+hrNyuG9ya620RGSNQ+MgZr5H487fSz/ AIsihhl24B49qOTMFxt5+aCmWAwSMUt/VUHBJFfaxnT5ObH+oWdWgT3ZuTWN+IVzjTYz24wB8Vku rgzXlsp7AnmsT8SW/wDRAY4xxXt4vbw8vUc49YTukc+DkljXOPiK7BJv+1dFdVFXguMsBjNc3eIl xmKUsRkg4r359YvjW7yaF1xzNcds4PaoxgFPHYf7U81ViZyc4Oe1Mw+44YcDt96+Zn7fa4ZqCgFg AKKkWRn/ACabxsy4IIpX5ohioGBXF3GCKoIHue9Ug/UD9RpHqB1KH6f+qiwJsXvye5+a0aIOSD9q TEpEn08UaPjdk0GDJl+4NQ09QnbLHnv8UhSw9/8ANJhH0fVmljaQM5yfavqPEL6aqoO79/tSQ21c 5wPmrqxU/SOD81faAe+ftQ0tw2KsQQeTxVwuMj/FXxnjsPk0ZDaTsc8jtVy6u+RkGrhQny+Kuz4Q 4Xn7UFm7Fu5+KsWBG4Dn7UtWCgcHOOaoYwPYD4oBNuHP6qvGWXgDOaWSSvHcfNEjYKBu5P2oLMrO ORihorhw23eop5iJYixOT8UEZjTI7E9hQUSMFivPYUIjcSVj2Z9vvS2kbce3bIpMjsftSJolQEPz SG4OR3oioQgJFWZARVhoEMoYk5yKRJ9bZBwaLOmXBQcGhO5TAK5z7irFUuYhsOCfmhuwx25xVSyC MYzjP9VBDouBncT7VQmRy/BHekBN3OACOOaqeXa6gDP3FBaQ7ckYoETxI0iyDuO4oLkycoBwPcUX dzz8UCVS42hsY+KNfQKcHIQ+p/qzSm+4wf8AvVECPHJJq+8KOeT7UUM4RuRnPb7VcKzRF2OADSmd ccjJ7gUMJyGJLD/RQXVgMAjgjIzVcE81TOZBl049vtV+fmgQeFwKRsfGVGTSzyDVt+OOTQIkT1lA aURfcCkx2ES5YTCRhyearAIwwyDQmsI2BYOYz34PFEq0iq5wvAPc0xZBG2Q31Dt8U/LgARkfUeN1 NporcDAf6vYVL6OzK5lDI28gZ9hWMagQGXYxOW7VK3DFbhueB7VH3v6gzDB7V5naMz6NwtnExOcn nmtr9Gu0l7gruUkEVpvpF2yE3cH2rcPR9z+XurXOCdwU4/evNm6cW/KV1gtp/F/Dua1Y7RJaMmf/ AMWvJ2w6itrLV76zZyssN3Mox7/VivWbpaT1+kpB7bHAz/8AGvIPVtG01usdYja9e2kN9Nu2/djX nx/k6Z43z26T8GfHWz6O1izfUQDbggGQOBtFZN52OtOhtT6JtusdI1OCXqVSiwrFICzD4IFcN6nK 3Teo3Ky3v52DfiPafasX1OO2v7wSJJPKy8iMMSM/tUuPbpcpljJ/TpTpfzxeInRuipY2EtrKSn8p XjB2fvxzWuLvxr1TXOoZtX6muzc6lcNuMgHC/YfatYr6MWGyzSHjb7inkSW8sgMkckkfuQMgGtzG RnO+WtOp+i/O9rnhvZyLaiK9iYf8uRQcVlOi/iJahJqJ1G50SOSYjBVSBxXGBgttxbeVQcKM96Ud OiI3rcRoT/SDzWtYsd13XL+JddhmA6cUEfLiou7/ABMNaZHa36fjznaqnB5+e1cVbfSUI7Rv9s8m hlUluI1hVvX7hFGc/ep4zfTXp1NoHn/6o6Se8kt9GiuHunLsu0AKSc1h935qdU6g6ok1+9jCahId 4jjwuD8VouVrgvsfAK/0/FN7hZQ27aV+GFWY6LlXb9t+IN1HF09+SHT6PJ6RjErOCeR3rWPh1qMP UvUUlxdSRwm6kzKpOBuJzjNc1Pf364VJMe2c1dNT1OzkVo7t1T/Qpxz80yxlWPVTxK8UtA8D/L5q r22o2ram9rsijilG4swxxivJWOdtb1OfUblnd5nZ5ST/AFE8UXWbjUuo5gLu9kuwnZJ5Dgf2pdpA 1pbOjY2sct+9TDHXtM5MqeZPpcN7YzUt0b1PL07ebmAGP0moNJImAAmBP+kd6TO0KKJMll92X2rW U3NHett3aJ4+W+jajbyySGa5zn0gMBv71uXrH8Q2KfoiXpOx6XcXM8Xpm5WTKr8nFcY28IvIw0bA L8+9VLCsH8rB3OOGAya5eDXldabq6Y8XbCyjSS7uBDIvJULkk5ziunumvxBOmOjOkY9PuNIku5hH hVUY3/uMV59emiemDmIgcufenMttJLOpjmeY44ZgPpp4FunavRPn+0noaPWbxumXkS9kMkMaNsC/ 9PauReoesH6y631bXpLD8pDe3DXHpFs7cn5qGuFeCArdtvjAwARTHZ6gQQT7Ic8Kf+1dJhJGc/lZ XRXhj4qdK6JCq36rauox6pTOPviuq/D3zb+E+jaIkN3cR3dyo5la3DEn45FeZEryQ7k9YSDGSg5o lvNdiONLeVoj3JA7ivNeK2727TPGdV6qal59vCiGykgkdriPHMJjBUj9sVzt40ebvwv6wjW00HpU I5TabuJBGVPxwBXHJM0Z2vIcnuSKXFZxwQthnlkY5yVGBXWYf2zcpO47b8JPNnpXRVtEsN2tjbkA PHKN4Nbg1Lzo+B14iXetvDd6ii8+rBvOftntXmEmly3EkalpWycqq9hTrV7C2FpFC6EXyOCxI/p+ KzcN3bFzl7dSeafzuaV4w9O3XQXR+mMulXiqGv37IFPYD2rkMWsdtM0a/WigD9z805FkLNbj8rvS KQc8D/amyMSBuV89jgVvGePtne0romovpd2k8TfWpyF+a6B8MfHu10+WNr1QZo8AMR2rnIQFBuPs M/tT+DT7tykkXCn/AHrt4zJiZzCvSzw/82GhxQw2eoz28umy8OHAOP3HuKF1l1t5aZrx9R1KaNbo HdtgUjn9hxXnPa6bqEkxEJuHk7YjpzqWnTWt6LfUGc3SAEo/tmn6Vz58Mu464698xfSfWMMeh9L2 VvBpNs2VuxEFZ/71s7y9eNXSHSEFx/HNYisiq5Uk5FcARwbIY4EndcndhKc/wmKSEqzOR7kk8/vV vDfp5/3yNreZrxF6f8TPGKbWOnJ/V0wQshmC43NWQ+EvW+n6fo35KWRUuMZBZsA/3rSNnpiCAxxj YAMD3JpEml3NrIqM7tC45xwa7+Hx08szky8noh4DeMPS+kJM+s6tbae4BVd0g2muOfMh4g6R1R49 apq3T12L63T6BKowCwPNavk0+O7h9FXlZV9nYjNDg08bQIomSVOxHJ/+7XH9Vjtycsz1p0h4e+Km nazHbC9vFs7mMDv8iuvehfFzpfX+mf4LrE0H5dk2SNPMNrL+x7V5XXNvPbRmSJ5I37lgeRTWafU5 oQV1C5kT3Ac1xvFd9PVjyzx7eo+nSeEfhFc3evWXUFurR5b0BOG/sBXMviX5iI/Fnq+e7aREsLcl bWHII2/Oa5AuLK4uMbmkcHvvdqE0N1pzxiJtkWecHvVnFcY5zk7eovlo8RenNI0DVH1DVrOwRkDD 1ZgM4HOK86/Mrrek9UePmt3uh3y3lpcMxEqjg1gutiXU25mlig28IshAJ/zUXa2K2aLtVi27Jc8n HvV48bKmecymko1rAsDmVskLhRnvUVGvpncfmnE59R2yxI9hTUlVjOCWNeuPOeaTqkmj6lHPGwU7 gwI9jXaXg/4s2PUkdjsvUttRtwN5LY5HauIY4ckkjj7070+W5sJPUspZYWbn1IzzXDPj8vTtx8nh 7ezUl10l44dGx6Lq15C91CokOZAu2QDhh/8ARUN0p0z0b5f7TUNe1Tqa2uEiUiM+qu5R7qADzmvJ 62656lij2rrl3CAMH03IyKYT3eo6jIXu7+6u4/8A9NKx/wDNcZx5fbrly/0736g8brDxc8S7DVlk EWnQTCC1z22Z5ya2r5qr/RLnwh0sLqdtLPbSrJGiSgsc4zxXmBYa3qFtbfl7e/uIIgc7FHaqmv8A UNRuEe51e7naM5UM5OP7Zrr+m2J+6XHVemXlc1qwXXGle6ihRrfCb2AFc2/iQahZX/izodxYXENz I0SwuYXDYx7HFc7R9Xa7awmK21e5g4wHRsYqJjtZZ738zfXst/OTu3zMSc1rj4/C9uHJyTPHUOUU Rh1zliORQJWuInjmh5eLBIz3pwoClmYgM3vVnjWTu+B7ivRlN9OWNs7dD+EXjjD+V0+1nnNvNAwK MTjB+K7bS/6W8x3QEnTWqGMXRizhucH/AFrXkolzLZuPTQkZ4K96ntN8W+sungv8O1i4s4l4BjP1 CvHlx2Xp9HHlxynbtzSPw6tN0jqWC71LXlvtCVmeaPd6exfbml6v0/0h034m6Po3R+oevZRShZ19 TeA+ewNcRa34/eIurWs1vcdX6q0DjDKDgEVjGh9b9R6A4a1u54pA2/8AMA5fdnvXL9V3uk5cca9J vxFPSsvBXRbtyC9pPuCluTlVFeY2l6iyXyXXpCUOw4Xg4p91v4m9f+I0C2mv9T32oWUBykEx+msb s71tIeLYxZ19yK6zCa1XK5/Lb0K8uHipYaf/AAbc4imjcB1bggV0J5gfBuPzA6LpF/pGoL+b0pi8 SFfpcn5NeQidd6xpupreJeyxS5woQ4GK2Zo3nC8UenrMQaT1HJZQrxwea8t4rK9n7ZnI9PfBjom+ 8KtMvtU6rnhtBHDsMpcbFUc/+K0CfMJpXWvj/e6zodwBa2xS3WQt+oLwTmuH+uPMv4qeJFnPpuu9 ZX11pzjBhQ/Sw+/NYh031Je9NstxBcPH6f8ARn9f71bw5SdOf7pb29hPHTwah8fNE03WNJ1BFvbW L+UgORJznaTnipHwY6Mn8IOk9Q1PqSaCykMWZEZwFRUGf1fevMbpjzoeIfR1mbfSdRa0gbgknP8A tWM+Inmd8TfF+xk0rV+qriXTSfqtgdob96uPHaueXjjpkHit4j23jj5idQ1gR7bC6vBEgHIAH0jm vRry++B/SGnaW08mjWt5JJAmWnjDgHHPBryP0x5tDWK6gYLJbsJA3uSDW/8Aovz79b9B6eDZQ210 gQKyue/71jLDLHPZx82OXUZN+KR4W9MdAdTdIaroWmR6ZNqqSG6S3GxGI7ED2rj4sqmIIQpxjcPc Vl3jr4+dYeZDXtP1DqO5ge3sAyw2gOAinuKxeVo5Fj9OMRALgKvYV7+PqPBy/wArsSJy2cH6vmpG xlaC7WRfZMEff5qMtEYnk5qQVCAw4yRgH2rvreOnml1k9FPJ94tRDS7CF3QTjEbBj2Hatu+bHwN1 XxWg0jXNElW6m06Mo1pkYdCSSwPuR8V5e9E9bat0ncxvbTSDJ7Djmumej/xBeqOiNPTTxptrq0nG RK54+/Br5d4bjdPpz8jHKyu1/AHo+Xw/6Jlu9RRLSR49zo3042j3rTHhN45WXVXjnq+tJiCC5lNo qlu2Dt71zJ4xecvrzxjsRpTehoOmkkSrZOfrH3Oa1n091Fe9Ouj2s5jWI7jIhO4n5rU4rpLz4+Xb 0P8AN54H614hSab1Fob/AJk2qhJrdRyEzncPms98vPS8nQHQF1fapF+SWRfXdX7oiqck1yF0R+IJ 1B0jo0WmvpEWuNGP+ZcMQcf2NYd4w+ePrrxY0OXR7W1h6Y0+XKStaucyKe4JPtVnHftbnNMR8Uuu LPrPzAdQ67Zyb9OkvCYpB2K5r0U8tmsR670hcW+8NGI1RTn2IOa8l7BJLM7QybS2d6nOf3rr/wAo /jEul6hb2k140SKwR1J7g1jlx8NXTPFlMrWmfM70LeeEvjjqFtcDba3xNzb47MuTzXT/AJLPEiK2 hhsrpgGm+nYDyPikfiOeG+m9S9Cab1/Z30aalp2IkjdhiWMknj71xF0F1/qnRF1aaraX0kBb6wyn sfis54eerGuGfruU/t6Dednw06k1zUen+pdBWY21ohguxbHEhJORwOe1bW8u3Sb9C+HSXmpZhuJk Mshl4IUDOST/AOa5f6Y/Eqh0nQobbVtIm1LUEH1Skfq/3rWPjl5/uqvFLp6fQtFsoumrKfKyyo59 aZfjntXOd5Om4668v3Xmmde+LnV+qWgRTO5VQCM/SSOP3xWqfP14f9Uav1voeu6baXF3pItxARAh fD7ucgdq478LvGbWvDrUoJdOvWgmj5eYnlufeuw+mPxL+n9O0GGHqPTbqfUEG0zRR5V/ufvWssb9 NSam2+PKTouq6P4bRnUY5IopWUwxyqQwAHOR7V5z+a+WxHmh6yaEhv8A1LCQof663N4tfiWarr2i T6d0TpH8KkmBX+ItkPH+wziuRNGW8606rE9/dyXeqXsgkmun7s5POa3jjYzj3ene/kA066Sc3BQ+ mFbefgEcVrn8TjrR9R670Tp+MBRaw7s++cnmutfLZ0RbeFvhS2qzuoeS3M0rSHAG0Z7/AHNeXfjz 4mXPi74vaz1FdMTFJMYoIUOVjAJHFZ4Mbut8+flpCaBqJ065t5QMuzqDXrb5cdQi6t8HRaI6s5gM DjPYlT/9NeQNqjwuCxAIOefau3PI/wCNiaVq8WjXk4jhuf5Y9RvpBzwa1z4/OV1xy3x2Vy54s9FT 9GeK/U2i30ZtWjnaWLcMbgT7fatoeVXwQvvE/q60Jt2GlWzh5pCMDA9s1tn8SXwfkj1XS/Emxb1L cotpdKmMKoxhvvnNK8unnC8OfBnw/j07WI7sXjjez2sO7dxnHeuWVtvicfxx3PbqHxw8W7Hy/dDa ZHZLCJ5JFtbeJiMoo43FfemXib0BoPmq8FInVgbiS3M1pcqMtHKByv8Ac8V5oeYbx/vvHvxKudfV 5bbSICYrC3k4IjzwSO2a6C8sXnP6d8LtHk0zqa5uDZqAUEC78H/NdMLcfTjlPKbrI/Itot50h4ka voGoxGDULPckqt3GD2qH/Ey1LWNP6m0ZrGW6SDYv/LJVSffH3qcsfOH4YXnjrB1TodvcWenSwmPU bmSLYZJM/rxnnjitudZeZfwL61t7X/iONNVghYtAbqHIBPcj6qzL3umU6mnlLLrWoXodNQ1O9dMf Sk8hK/716Xfh0SQN0jqaQtvKpHkj7k1Hav4weVKKEm66f09415IFtn/bdWIeXfzXeEXhz1f1a1pc zaX07dkNZo6YK4P6QM8DHauOeMuUr0Y5y8dx+2zuovEe38O/OHi8GYNQhWAc/pyveuodO6fsbLV7 jVbVAsl3GFbb2YcHNeVXmc8zvSfin426Fr/Q0lyY9PX/ANXcTpsDMO2Oa7Y8PvOr4dv4fWN5r+vW 1hfQRKksAYFjgDkDPviu11t59ajz988lvHaea3rVhlVCwEfuVroz8Mi1mTVtanKkxNCBv9s1yf5l vEjQvGLzFdR9T9OySXWj3JhjiMq4LsoweM16ReRfw4n8P/CZtR1GGO2l1A/mA3bbHjPNZs7emX/E 5k/F66tsZLnpDQ45Q+o2u6V4hyVVsc159FxO0Xpn6HwSPg1vTzxeLun+MXmK1bVdLR30uwC2R9Qd 2j4Jx8VpJSjpvRNsgOeO1fSl/wAcj5eOFnJcwHhbJx7VUI9O4DOpeMrjj2NFfeE3Z596PptwtuPU l7EYH71wy7j2y6ehf4aPhXDd65cdUyuc2UQMQPuSADXYPj34Q6d4urpsF31DFpBsyW2M6gsT2yCa 0F5JfFbwz8M/CRF1PqWw07UpFMs4uZQrHA7Vw95g/MheeLnjTruraNql1BoYm9OD05GXcBxnAPav Dx4+Eu2+Xkuecr2Oi6E0nWfDZukbq4GpadLaflJ5Uk3Fxjvkdua4l8kXS/8AwD5jOoOn2G38uLgR Z77BnH+1X/D68ebHTzrOl9TdRx2lqIQ0DX82AXyMnJP71mln4m+HOg+cv+N2XUemiwvbF457iKVf RWXbjkjjJNdcc5Y55Y2XTOfNz5yk8suo6Tpy6E+qT30JnEokAUDJG3GO/wB64u8XfxMuvuvdHm0j QbGPpy3uVKyy8NKB/wBLY4p7+KN4l9K9b9b9LJ09rNrrE9pblbhrRw6x/UTyf71xjaHkrMFcMSQT 8V6PDeLOOrlqpfSrxr/VJpb+SW4urkmSa5mYlpDn5r1s/DuuUbwbaFXBKT5Efuq5rzw8qXhFovi1 1/Bp3UWqfwzTtm7cGAY/tmvVfwb6U8PvBPSZdN0bqO0eNyAxnuE3ft3rz+Vt093L4zCaeY/nx3W/ nB6hkU7d3pcj/wCHaus/wyurba50XqDRBIPXiYTAHjIJ9qnfMz5XfCbxc17UOr9W67XQdQeLe7xT oUOF4964R8DPGv8A+x/8XZprC7XUNJsbxkDhuLqPOMk1Oe78dOHDJccpW0vxVdC1DSfGrRNce3Md jPb7Emxw+ByM1xUVvriab8vbSXERG4emm9l/sK9qdQ17we86fh4be/u4MpgA3BVLi3c99mTWIdG+ CHgL5VNJ1XWdR1q01ZkiOf4nIjyY/wBKDPJrWOe+ozjlMMbK8e4r2OaMFSfVBwysMEH9qkLG0l1a 6S0tkMtyRuVc96kvFvqbp3q7xl6h1vpWz/h/T15Kfy8G3AJzyftmoqzvZtNu98LFJFPEi9xXqm9d ueOXl6Xt4WtNVMFwmx0JEgzwDXrb+GHa2sPgtq7w4aR9QHqN7nivI55JJ5Z5Hbe7kFmb3rtbyN+b LSvBe8l0PXFePSb2QbpR/S3+rGa8+fxvb1Wbw07s8YvBPwc8TvECKXrZkbqEQKESS99H6B244rLu jNP8OvBnQZbfStbsbHTYh6jrPqKuEAHtk1p/xv8ALX0z5tvyfV3TvUstvcmIQmS2lwhUdsgHg1qJ /Jd0R4LaBqGq+JvUy3lmARFHJdMCR84zyas1fTx6u+3MuodRabrPmz6h1rR7hbrT7vW2mhnXs4LD kV6t+M3Ux6U8DNf1VX9ORdKZUbtgtHgf968ZugLrQ7Xxak/hkh/hJ1bZZsx7Q7hg5r1z8z72Mvlm 1783exWsLacpSV2ADHZwBXXHuyOufqaeJWh9T61Z6tJqtpqs8N8WZ3lVsE/Ufetq+EGvan1F4u9P anq10by5mvYVaVjliAwxzWl9KmHppmPO7cf3Ga2p4KXMMXXPTQGI2TUIS32G+r+RhML0nB3O3sv5 kepT0j4G9a6ks7W866bKkDocMJCpAwa8MOkuodbXV/4mmpXEN3JICZ43w+4nnJr2r85ix3Xls6xc sNos2dWzweOK8QOnL3ZFFEDhXAbf9642bxTCbyevX4fGl3TdHdS3+rH8zq0l6qvdSHc5XbnGa4/8 9viFrXUPmOvbaeZ4LfS4Vitrfshw368fP3ra/wCHt5jdN0K+v+k9evorSO/YSQ3ErYUyDgLn9q2/ 5qvJNN459dad1h07fWtneGJYblJjiOSPOdwwOSa5Y+tOmc8cu21/KXrsvV3gD05JfB5nEDQytNz6 o5Hv7YOP7V5q6NotvYecvqCxgRLe0h6kkWONBhUHwB8V6Vyaz0/5UvAe3j1jUbe3XSbR/SEjgfmJ sEgD5ycV5UeG3Wr9bePSdT3G23uda1lrt0U8Jk+1dF4vvT1d80PW1/4c+XzqPW9MnFvew2YjSXuR uGOPvz3rxJ0Lxd6v6f1ldasNZuBeykuxeTvz7/NeyXnfspdQ8qPVEcCl3FrG+B8AZNeHdgqSWqP+ tXiJAHsc17MMJlha8vfkkfEPq/W/E/rY9Q9RzGS/dAmVPAAqPxnOeKqYelKu3GMdx3q+dqH5xXl9 +3p1J6XtY2kucqcEDsT3r17/AAxulLPSfB7Ub9YkF5d3IMkgH1AYP05+K8fbecCfLcRR8yH5zwMV 6ofhgeL2lv0/q3Rd1cpHqnqie3V2xvTGMD/Ncsuq7Z7/AF6jQnnD8curdY8yuqacdWmt7HRZPSt7 eB9iAK2cke7fevRfwt6hk8VvLXa6jqyRzy3+kzJIHUEHCsoOPniuVPNd5Edf6w8YU6x6Xk/OWOpy ZuoGJ9SGQnk9v011UE0by5+XU2WtajFa21hp0kXqu2A8jKcKPk5NWPPfGyac/wD4d9mNH1zrDTIj i3tyQoHb9daq8+Hjd1PpXmSg6dsNUnstO0q3gmiS2cplnUE7sd+a2T+HDqw1rWOrb9OYZxuB/wDx 6558/QEXm51peDusrM5/dRXXrxb5ZrOPRWKwbxO8sf5e/kVpNU0Q+pLIM4YqfqrwT1SwXRup9Q0u Njv0+8lhLLwHAbANe9fR0MknldsIkJWU6EQMcEHaa8HeoJGHV+tQsMsb2VS575De9Xj7xeLLrOSE yhkjBjfa6nO/HapHSb0SXH/qsSvt/UwzWS9PeDt3rOiPqJ1ONJHGYoZWxvrDts+nXcqzRGKeFihR xjP3H2rHJPLHUfU/HzmPJ29x/JIYf/sbOizCFAMLZA/dq8oPOSHPmp66+gHfduq/Hc13V+GX4z22 p9K3fRF/col9asJLSN25ZOd2K1p59fJR1VrHiQ3W/QunXeuJqLl7m3hG+RJTnIwB+mtcOUx/k83P /O1wJZRfzNksYZ94C5+PivXb8M6P8t4JakoGANSYAf2FckdG/hqdb694e3PU+u3g0S9ihe4TTJfp lwoJIYY+1dcfhr7YPCHVLXdkxX7Aqe+Rxn/asZ2XKWJMvLCwvxm8jfS3iT4sS9W6h1NFp7SlGlsp CoLAd+Sc81nPjN40eHfl/wDCx9AGsWtu5sGttMson9VmOCBnGcc/NedP4hPXfUuieY3VtMj1y8WP 00YKshXC+wAB9q5igvbue4gutQvJrlnYEG4kZj/uTit5dTa4YXO629xvKDqZ1XwE0u+YfXO8sjD7 8V5Zdd29vqHmi6w1C5xEq6moC5wd2eOK9KvIV1HZ9Q+XDSFtZUeWF5I5EB5Qntn7VwX40+XzrrT/ ADWanG2jXDw6neLJa3MCH0ZgT3Xiue947J8eTVel/V8jjy33bxoJG/gqYU+/0LXO34dC9bQ2msxX W5+kjM7B5uCJcnAj+3ziug/Et5OlPLTqaXjiCay0dElLH9LAKDTXyo3NvqHl76ZfTnjG+GTa6gEK 5Zjkj/BrX052+4i+qtH8FdU8btOk1b8j/wAeKdqIrbdzD/WBwT+9as/E2XxCl8FXt+lLUP0v/wD1 hoeZgo/SFA52/Ncg+I/hl4j2nmn1eG/sr9r671L1YLkBgLiPd+tCPbFepviC8en+C2u/xF1iVNBk SUzdg3okYOffNTGzdbzxs137eDvg/e2nTXV/T+p3chSwtrxZpWXugDDNe1+o+aLwvsfDo6nN1fZR 2x04j9eXBKcLgc5rw16N0WfXtVs9KtJdjX1y0asTwAZCOa9KZ/wouk7rw/FyOsNb/jLWAudhcfl9 +3cRj4zXSTVjvyYyY47eXPVUsXUPWetahbTAxTXrzxt/rXceaIlxKjDL854yOMUm+0qLRtc1LTZ0 McllK8LunJwGIyKdWVsJUAiD3CD9JI5r0cvuOGqQSJXOTnPfFTnQ9nHN1FaKowpmjVgexG4DFQTr 6O8hTu+Kmemp3tNStrskhIyr7R74Oa8HNL4vR+P/ADj6B9K02K28LYrKICOL+DhRnsMxd64603yH 6d0lp/8A9Ytl1NMmoRJ+eEcUeF/VnAOeOK6c8GOtofFfwC07U7Jg8t1pj2+wH6g4QriuDeh/Ebxl 1vxgi8Kr7W7y30781+Ua0uY8KIgc4Jx2q4yXGRy1l55du2PM/ANT8teoJN/MEtvblt3O7O2prpW0 ay8tdnb230suilE5xj6TWL+cTXLPozy3apHd3EcUqRwwxKWAMjKR+ke/apvwt1BOvfLFpg010up7 jRzEEjbJEm0/T+9dtOE9OZ9P8hx8OJLTxEterp5tQE0N41ssQXPqMpKh8+26t/eeGzg1Hyz9Srcx LMqwrIoYZwwBwa4r6C8aPGTrfxetvDe91W8msoLwQvZPHwY42H0k/YAV2D+IB1XB0h5YNflnCt65 S0VSfdgRxW9WWOmW5Zt5r+QnQYNa8w/RVrPAHiSVpW3chsDPau4fxUOv5+mvA6Hpy3iGNYlG6XP6 QnYf71xB5Dtfi6c8wvRUlychpGTI+CMD/vXbH4qnSd3q/gvZa5BD6tvpsv8AMPxu7f8Aar/9nacv bzD8MtHW86s0CGcbkN0gcffcOK94eqIZ7fwnntdNt1e4udMWyhi4ABePaD/bNeEPQ+sLZ6/pF59M fpSxyuB2/WOK92dUvf8AiDwZlvNKuEZzpAubeZDkB1j3DGPfIxXLLU5K65/+rFx74ReRnqLy6dXd O9cy9RnU/Su/Uv8ATo1CCKNiSfq/qxmtxfiH21tc+WbU9ZWMSXFhNDcW0hH6CWHP+wrm7y/+abxF 8ZvFjp3pPqCaRtNjvPSu1Zf+cAxH1f4rpzz16nZJ4U6X0xcBFg1vUre12E/qQOuVH9jUl7Yzx8db Sflx6yHmC8tyWN/b3Fm72R0y4nlXiYlMb0+3P+1Yd5e/IjYeA/iMOpIOqW1QRBvTtHi27Afvmt29 awx+FHgZra9MwLp66Lo0jWSQr/yyqEjH+K89/I35l/EXr/x/02y1/XbzUbXUw/5qGVfpwBx37YrU i8fHc8blPof8UvzBy9SPZ+HFlp80WlRzrcT3Ese38w4PBQkZwK4w8O9XfTerdKubaVra7iu48FOD jcOK9O/xWujNI1Dy5nqeWyibW9M1GCG3uwv1pG7EMv7HAry76Kthc9Q6U6HdLJcRHA/+Yq5ZTx1G +KWyvbvzBeHlr4u+W7W9EvHKq+ki7Bx/UkW8f9q8DrOJY7542yHhkaLaexwx5r6FOuNWtenfA7V7 u/mW2gj0B0LucDcYCAP8189NrP6+p3eOSbp5AftuNbx/hXkmvJ3X+GB0z+c8abXVAFY2ltcLIMfp LKfetrfi6+Iktj0z0z0LGii2v3/iEje+VZgB/wB61x+FPrcMfilf2GfrlgkYfPANZ3+Ka2naP4gd Ea1rlmbrSYrF4mOOAxdqvBjLnqunPdSPN603JOfUO5kA2ADH7V6wfhu+Ye5666Yn8Ptck9e/0qLd Zkr2gHdW+ea8phNNqus3s9tAY4pJC1vGBztJ44r1x/Dx8uI8M+hYuuNYK/xvWYN0ZzgQwZOd3x2r yZYScnxd9/4/l/8Ajf8AcaZ0Z5eelOpuqUtk060YvfXkijl2PYAfGfYV5Fa/43az48+ZnTOo9Wld rRtSjitbfd9EUYbACj2yK9ctdj6T8ynh11F09BefmLF5JLGV0I3xSqf1Ac8Zrx6ufCrVvBLzI2XS esqjy2OqRMssfKPGWypB9+K7zWnGXd7ev3jX0VqPiD4A6v05o1uk1/f6esMKOwABwOcmvLm4/DQ8 bI52ki0exkIHBa5TmvT/AMePEC+8O/LxrnUulMYr2104SQyL3Q4HNeXEf4j3jC1q3o6sLhZOAzH6 x/vWsePymzdnUZh5T/BvrTwO81/SuidaaTFpWoXDCaNImDLImcbgR3r1mvry0WaKxnYGS7DKsZH6 1x9X+1eSvlP8aesfGjzZdK6p1jqj6pewsIoWcD+TGTnYMfeu8fNn4kXfhfd9Data3H5UPqPoSue2 xioOf7Gs67MpbY1n5f8Awxi8MfOp19BY2DWWkXdoZLRNpChd2SQT3Gc1qX8X+S4e46BhlAaxWV2R cc7vfmvQN+nINV6t03qu0uElZLP8urJgq8bEtkGuBPxefUaXw+Vh/K9aTYfk4pjJ2k7sc5+Q7rzU OgfMDon5F1C6q62cyMMgoxGf712T+LR4eXPVHgno2t2Vr6jaJema4mAyUjIHc/Ga4G8qsMieYDoH aCCNRiyo4P6hXqf+ITqkOneVTrSORgrXMKRqD7ncK5cM3bp9D83DHHw1/TxIN96Nnb22NqkAuMc5 IptI8ENwm9GlUc4BxijwxzzmKO3tpb662KWS3XccY70BLS5nMn8oxuG5RuCD8V3zxuL5ssOriWGa WWVUMS7QcGl2mn3PqQuV3LdgLGB9zjOKXcXttFZ+ldRqjrjDDuTW2/Kh4d3niZ4+dHaXJam/04XK TXKIMrHGCP1favPyS2PVwZTHPdes3lh6eh8APLFoS9QSJZR20Bu5n78OMrn7nIqH83fR/wD9kN5U NSm0ohFMX8UiRuSyx7jj96z3zLdJ6n1B4CdQaB09btJfPbpBbQxDnAI4H7AULy+dN63/APURp3TP Vdj+QnhtDZFQTvaMg/UwPY8mumM1HDK+WXn/ALeV/wCHrE581XSSuvpmP1UKkdiFPFdj/ijdV6x0 v0v07JpWqXemuxcn8tKY8nPcmtE+Xbw5n8M/xBE0O4geERXVzJB6i4LxEHa1d++YzVPCnStHsW8U bKyv7V3K28d2ucc8nuOKxx4+Ntejms3j/wBOcvwwPEbrDrHQ9esNfnuL/SbdVnt7u4yxaUsMjf7/ ALVof8UvS7Hp7x30TV9J1GSy1i9gH5x7d9skYUDbz7cV1DqXnc8AfAXpCfS+kPQVY8y2+n6bH/Ke T7ndxXmF5hfHK68wnivf9Y6pCmni42QwWMbEpGoG0EZPvXXVk3XPHWWf9PQj8LTrHXupNN6kt9T1 m71a1gwYjeTGRlOR2J9q03+Jz4mdUaP47HQtP1++07TfyULejaTmNclRknFbQ/CTt1j0bqkqchH2 YH7itE/igmMeZucSRmUHT7f6R/8AEZrGOVym2s8J+3SP/Dg8CLfxM8dTr2sXRvo9GUXu+Vd/ryA4 AYnvXX34jfmf1Pwb6XsulumJxa6rqQP5iUD6o4sfTsPsa1h+Ec9m46pMSbJV/Sp7hcjisI/FnaST xX0aI/8ALW0Rh/itYY7y3Tkxkz8WsPLz+IX134BXd1FrQm6u0K6BleC7kzKsvsVc8gfauZ/FPrS5 8SPE7WutZbZrKXVbprkW/wDpBOaDc3UZMcUsJliCbvqHAoGoXjaisUss0PA9NET9WB7Vq9XUefKQ 1ub5bzI/LekW74NR0ssaFkIyyjOKeqodsggn357UgTiynmkNutwJF9Mqe4HyKxlemsJ3GVeFfhN1 J44dWWPTHRlkNR1Of6nZl2pEo7kn2r0K6A/CXbo2zg1XU/Ej8hqlxGPVUQBEjYj9IbdzU3+EF0XY WnRXVXUT2kRv57hESdly6Jg5APtn7VtPzN+Xjxt8YuqGXQ+r7Kw6ThmE1vp7uUbcDwSQM1y475Tb rzeMy1I4r8z34YfU/g/09L1p09rUvWlkrGS+thDtkhU/1KoJ3CuX/Afwig8ZPEOHpqfXI9CkubgR xSSJuBP+mvejwg6Y600bwsXQuvL221fWY4JIPzdueJEIwoP7DivGvQOh06S879joUa+j6PUCpsQ8 DLZrve44Y47y03n4jfg+6103Y29z0z1g2u3M7qj2jQbAoJ+pgc9hU7ffg2GHp27/ACfiO93rUMBl S1WAANJjOw88c8ZxXoP5hPEG78KPBPqrqawVWu9LtN0W/sCcDP8AvXjn0B55PFDw+60uOqv4u+rw XTH1Le7YlW3H9/bP+1YuPWye2mbHwT6lbxaTw+1WBrLVnuvypZxjbg4Lf4rr7xJ/Ch6n6Ig0GXp7 qL/iGG+kjiu3e2CG0ZscgAncOa1b0h4jan43+abp/qvVo0trm8ukRViGNoyK9b/Mz4p3Pgr4Daz1 RZxLLd29ukMe8kBWYYDD7jvWMZa9GcmOtfbz86q/B16ks+m9QvtL8QINX1i3jLR6elrsErj+jd7G uK+hfL9194meJA6C0fSHbqOJ3jlS4GwRhf1Ek9gPmugvCf8AEJ8R/C/qK6u9Uv5dc0nUGYyxXByU Jz9a816A+Qrp6x6u6UvPF28VLrXOqbh9szxgNDGpI2j4z9q1JZe2Lj4zdctaJ+DN1DfaFA2p+IsN neyR5ktltN4jP+ndXJ/mK8nXX/lclC65F+a6fnkZYNQt+UbHu3xXWnmp893iL4b+ZfW9F0PV5bfQ 9Cvlt5LBVBWYZ5yTXfXX/SmieYPy9vbazbR3NpqujreBu5jk9MPwfbB4rpPbnlLqPn96D6L1bxN6 80LpHSSn57VZ0gimccLn3rp3xI/Cu8WOjerNE0vTJ7fqCPVDsjvYjsSOQDLBgT9IA9zWE+UPp6TS PNT0Wk25VXVisf3VZMAD+1exXm68ah4G+Dmr6vBM8OsXKmLTnVchZeOT8cZq5476h/GS15hdU/hS eKvSnSd7rMV7bandWqGRrKLG5lAy23HeuL9Z0690q5NtPDJBJFOY5YnGCrD2Nd9+DP4qvWPRt9c2 XXiSdSafM+fzLj+ZEP8ASB2Irjrxk6xHiD4h9Q9Q2NqLfT9TvHmhiC4Kg/IrE3LqsW77Y3BbcKx5 IX+1Ce8gdvQdSrLyOKkMiKFv9O0c03uFEVsHXYHkAC575JrVWa+0n0D4Z9T+MfWVv050lpj6rfPw FRfpj/8Ak3Yf3rpGX8KXx1ntFEllYGTGTEt2gH7ZzXe34ZfhVoXht5ZdP6nGmxQ67qYln1C+K/zX RScDP2FaX1f8T7UdK8xksFvZtc9BCb8n+WmJWRV3YMuM/qz7VMdzstlecvib4NdVeC/UE3TnVekP pd9HnMhGUYD3Vux/tWY+DnlB8VPHfpTUeo+j9LSXR9OJWSaeYI0h+EB/V/avW3z4+FnTPjD5bdQ6 omsVk1CxskvtOuioEgVwpw39jT38OuBNN8sOhRyWwtIoN2ZRwJB/qP8Aiumv+TfXjt5hdN/huePf UWlJfWug23objgXM6xufttPNac8Q/Cvq3wZ1e90PqjTrjSbmSQFozkI5H+k+4r0y6h/EL1Wy8zTd N6ZClz07FdmyaJjgO2cbuDWw/wATfw40nqry+nq2W0RtW0p4zDIByVfuCa1ub05Zzrp4y24EkjKB kDk5+aczQqsTuBwB70ORF/MTTIux252D4ooLTwA+xIyKlhjOu0ZeR+jFHcBj6p7Rj3Fej/4bnke0 TrHQn8RuutJF9BcSA6VBKxXDKcsWX4/fvXnXcwSetbBQBFJOkZ+f1Cvoj6G0yDpzwU0e1s0FvDD0 +jgJx9XogkjHvmuVx3XWXwxc+eOPno8NPADq89Kx9MW+qC1wt1JZpGkcB+Mbea155/JPB7xU8u+n dT2smmHXpY1uNOFkyLISwyVkC4zj7ivNPxF1w6t1VqL3k0koM8sRLHJP1HBOaw31RawOtvNPJEG2 /U5IB/b/ADV5cf1xOCXPPp7neSvpXQOl/Kl0zqC6RZKXsGurpzApaUrk5Ykc8CsT6S88Xhn1V4oQ 9HXXTFrpzzTGFL2eOMpkHAyNvvWxfKfpsupeUPpWzhYCe50mSJGbtubcBmuMOkvIJ17rvjYLnWox p2jwXhkkukzhgGzlTjmsY947jtlMfO7by89PlS6N1vpO48QtM0yKz1+2ki3i2ULFOnbO0cD/AM1u JumtGfynxNc6XYts6eH1PbqxX6PnGaD5wep9M6N8C5tPuLuJbmcw29tA7j1JgMAlR3OKldaf0PKR cNn9PT3c/wDwFdfckeax43+Cmh2GoeYjQrTUbZbrTjqX/Idcofr44r1S8+vRvTum+XLVvy+jabZs hVInitUVl4PYgDHavM3wOCy+YDphiAAb9T+/116e/iI5Pl5uEU/rvIl/2NW6l6bznU08Yel/D/V+ vusdM6U0GIXWo6lIsSuf6FzhmJ+wr3K8uPlW6V8BfDfTtCXS7DVNXSEG+1O4tlZriU98bs7QO2K5 d/Du8pTaFCnin1VbPayKHbTrOVf5m0DmR8jt8V1n4EeLq+L+sdc3lncyTaRpuoCztFcbTjB3HH7i uGV3lC9TUecf4ofR+k9NeNlidG02GzElmk08NugRWJPJwK4vuv8A1FwtlYWzXElw4EKRpl5G+AK7 s/FDSa78eovTOEi0yEMD71z35T7KC58yvRsd7CjRR3cZj3DPO7ivTZrjcp/LtqnqLwo6y0WyjvtZ 0HUNLh7qZrZtn9z7VAz/AMPu7eNrAsJhxOMY2/t8177ebaxsb7y99brqECTQrZFlLqDtPHIz714Q pZ2mbgxkqsIwpI5Nc8cbZtdbu4t0lrmn6XBqMc0YWSeIxqxXOfvQYxZzMZJZ8rGp2pjk0wcqmAig E98Vf0S+2MHBY8k/Fa7YvvozeGDZugU/mHOBIfY/Fen3kc/D56KfwututfEOxkvtUvAZ0t5SYkgQ DO4885FcHeXjo+06u8wXQ+lXafmbC41WKKe0f9MqEjP9q9xfHjp29uvBPXOn+m4vRvZbZLSxhg42 jKgAfYDNcrvKvR+u46/21Po3l88vnjn0xrOn9OabZ3ItnMEs9vkSQSgYBHzivM3zX+V+98vniBJp LO2oWsqCa1u9hAdWOAv712x5avL14h+WXxjsta6gaLUtM1mI28htpCY4Xc92/wCqtpefro206q6e 6GilgWSb+MoPUK5YqMHBPuPtWvG4zprPGy91ofydfhx9Jah4fW/XXifFNqd3qEf5mDTiTEtpGM8t 85AzW9dF8pnlz8YND1CHp7TYLo28jW0kltORJC44zj4+9bQ8wr61pXgNPadMSPa6lPDDZQ+gvOHX aVA9siuQ/K54FeKHl08eNFuuoHMGldQt+Vm9Bi0cg7hHz2bPNSS+3nuU3px75rfK7qnlq8QH0z1T d6PckvaXZTG8E5C/uK030j0fe9b9V6V05pyfmdU1G5WDZtz3IyAK9WfxVtEhv+gOmrpkHrW9w+1s cgECuXPwy/D0dXeY+bVJLWOa30a3/MrJIOFYMBkfevTyTfFLHPhyn7LK9CoOmehvKL5apVXSrayt bfTwLiORAzzzsgDBieT9RPHxXiN1jdLe6xfzQQL6l9cNLGqDtluAP816ifim9fLD0/oXS1tMyTs7 TzoDwykDANeffl+6fturvMF4faffwh7KbU4VeE9mTIyDXL+GMrpMf23UdleUz8MfQNS6Ui6o8U3k v0vrdbi10+KUxGFSM7mI+1bo1f8ADj8DOt+kbn/g62/IXzArFfRXRmCP8Mua3h5j5tQ03we1LQum bSeTWNQg/J6db2a5YYxwP7Vyh5D+jPFHw08ab3TerLTUdM0XVbKW5/L3edksi/1DPb+1efGWe2un BPj54BdReB/XkvTeo2/83eBBIi8ToThW/ua7R8tf4V+k3nSlr1F4qXTnULtFn/hdvJtW3jIyMuD7 itmfiO9Labp9x0V1lcQ+rMt6lpKhGRsDA5rovry0vvFLwFkg6H1iGK5u7GMQXcD7lZQo3ICPf2rp PbWvjGltW/Da8C+pNHuLfp2J7O8KELdQXvr7D7ErmvOTzKeWXXPLv1LJpd6oms5HzaTr+mZc9/8A FeiHkM8Buu/DLqDqTWuqmktrC7j/AC0Fncuxk3hwS4B4AIzzWpPxQuven+ob/pzQrOdbzUdL9R7i SPDKpI4XPyDXbCby8Xn5L4zaJ/Cfu+h7t+r+ldU0uxuOrHn/ADkb3MCuxt8YIBNYh+In5cYfDnrl uodFs1tdF1ZMoEHCy92rRflT67fw18euktVHrRCe5RbnbxvTI+k16kee/o6Prvy+XOqRhWXT1F2u 4fVtYAcf5rhxzXJZXbPDWEy/t4qvZrPED2I+kkfNSugaXqPXL6V01ZWwllmuxCnpp9RycE59+KJJ brDc3YUfyi47+1dP/hmeHL9Y+Oo1aSL1rDRWaba65AYrgcf4q828bI6cOEyxt/p2lonlc8NPLp5b 9SXVNNtLrUG08m61SeP63mKnaFz+nn4ry18PvCQeN3jvpPREeox6da6rcsi3LLn08HPA/avR/wDE v8Sn0zpjTOl7W7AS53SXUCnHb9Oa8w7HWNQ6d6gtda0a5l0/VrCQXMN3H+pTmtSTHDdeWy5ZyR2v 5iPw19M8JvDy96j6Vv7nVBZqizWTRks3sWHJrlTy++WfqLzGeJA6X0tl06xh/m3t0w5gizgsB788 V62+UzzDWPmj8JJ2vo/Q1u3g/J6pCnK5ZSN65Jznv+9TXgx4DdLeWfSupNVDREPI88mpzKBKtv32 MfgGs45TLHp2yxuOXbz68xv4dmj+B3Tej3OldVNfX1/cLa+nPHgyMSACvJ+a2r0f+EfoUXT1nc63 1dMdSkiDzgR4VCRnGc1qXxp8xGqeNXj9osbT79FttUijsrdD/LChx9Q+5r0b8ytv1FN4O3cHS8N1 Pqv0KsdmCZCuOe39qzL3p1zw1jL/AG5Wj/Ch6Tcgr1m8kY/oVQR/3rTnin5GbHww8WOkOm9D6ja7 HUWY2kKjNqucE4zzWM3y+ZjRLiVLTTuqbaIk7VERING8veq9cap5i+mk6yN82ow3aBkvQd689sHt SZ6rn47bX6//AAqB0v0vqmraN1ZLq1/aRmX8o9vs9b5HBODXJXgp5dNZ8cvF1eg7K8j0mQI8k1y6 btip+r/Fe8U/pEGOUqBLlArH9WR2rg7wL8KR4X+fHV7GMmSFrC5nWTGAfUG7FdN79uNxczeaHyPR +W3pjTr0dQHXzeP6ZLRbNh+1Zf8Ah0eXrw48abXq0dYWX8Q1ixkjSKMzFCqEHJAHfsK3z+J1ctcd L6Jp27CM3qEDv71yH5I+vR4beZXSbuffLZXataFQcct9IJHatTC3HyZ68tJLzc+WKy8JOubqLTWk h0ljutw/AEfx9z960FY2ekCZY70NPDnG5TggV6t/iLdAJ1L4Rw6tFDvvLKcKzAcmM8kV5P3VhJNN I0aNFEncuOa9OHHLxeTz23Hk8WSwdHdNdQyLa6JrW28kH02kw7/sTWJa10/ddLahNp96phmj5aLG ePmss6B8P1a9h6nvJ1hsNPnD4ZsFiPj7Uz6/6wPXXWl/qBtFhi2iKPb7gdq81mm97rFoGCXSu+Vi A/VjjNZh4ReDnVPmA66g6e6djQtG3qvcOBtiX5NYnckvp8iHIZxuU+3FemH4V3hPa6R4Z33XEwc6 nqEz2YQjAWNSDuHvk5rhnvc09nDMdW5OZfGH8Pvq3wh6Ql16+vk1OCM/zPR/oNcySWbyXsFjaWzS XEsghEeeS2cV73eKWh2XXvhhr9iJEuYJbSVhIh3Asi5/7ivFLT9Fk0XxS0RzCC0WoAFW9/rFejDC 549PPf5yNv8ARP4ani3rekQ6hftaaf8AmUEqW4lUkIRkZ5p7q/4Z/irptpNLbLa3qqCzI0gyR9hm vSPxf6wvuh/Ai617TpDDe29jC0bj+kkCuYPKj51+oOrvEz/g/qwtqEN8+23uwPqRyeFPtiufhdbd stW+nnf1B4Q9VdLa1LpkmnyJdxPsaKddhznHGe9bq6L/AA4fFrrPSbTVpbWCxtbld8cckwD7fuDy K7Q/Ef6Aiv8AoLS+p7SKOLUrCc+rcLw7rgbR98GtXeQfzRdf9ceJ0fQmuX38Zs7e0LiSTgogx8fF auOsJkxjJvTU034XXiX6u6P8mpx39Zf/AKa0j4u+XXqPwF1P8r1NIiXDj+WifpI+c16/+Z/xc1Hw e8PV1XSoEmuJ5fS3yE/y/fIryz8ZfE/qTzOdc6Tp92oN/NItrCE/SS3Ga7cVkm8mc8bfTTnh10b1 b111dpth0TYvrGqibMaCIlFP/UewFdJa/wCQHx260uf4pf6TaW92VAdDdqQfsBnivQ7wY8I+lfLB 4SRXR063s9QtbISapeoo9SV8ZYZ+M/FcvT/iWXfTXX7xapYxz9O+qVZlJ3KmeD374rw445ZZbayy xxnbgzxK8FupvDK6utP1ywa2mgOGGOM/vWOaBb3HUOq6ZocUghncMULDO3Fdwedrx88O/GzpfTbz pacve53TFlCsw+DzXEfTNzDp/XFleuxigiDZb3FeqajyzK2ha5pZ07VZbWSQSelwXAxk/tUS0Ywf pziprXJ/zeq3k6hmjdiyH5qFvppLTDx4LYyc+1c8rI9OGFz9BzxmKFpw2xFHIx7/ALUa3024/hC3 +xmg3H6S3/itj+DXld8S/H68mTp3SZE08jc1/cKRCh/fHet3at+GF4waDpYuzfWt6ETLW1pJuc/P FXHOVu8evbkmI+pbpJt2xvwF9xTS8cRkgI3HJBHt81lHUHRGqdNas8V9buk0bFHjx+hgcdqy7wo8 r3iP492txqvTely3Gmw3BtpLgL9IYdxW78dVyxvl1Gqkhb8uJUdT/wBNWtS86NnC4PHNdC6T5BfF bqPqK40ay0go0AzLcXAIhX7E4qB8YPJ71r4MWFve67bG1VxjfFnaTXL9k21eml5G2sQG3E9x8URb losEgEdq2P4Q+WDxF8fbfU7vpPR2l06wwJbuUEeqfcJ8msmtfJP4u3WrT6fa9L3jm1fZLM0Z2q3w TimXJIkx20za28V1KzTKIivI29/8U0u3V7hdjYxxg8Vt3xD8pnXXg/am66jtTZNOMhzntWGdCeCX Xfilevb9KdM32t/lWCz3EURKoT2yaXmkm1mNt0xUxtuUsvb3FPbQ7kJBBI9vmt4P5DPF+z0ya9u9 CuoIlXexCH6B/itRa90Tc9MXMttcGdbmI7WYjjNbwzmfpnKePtDvPDNPskLRA8biMVN9PDpxvzMe p3cnqBf5DKD3px0Z4V9c+K0zx9M9M6lrEVu2yWeziLKp+5xWVf8A2K3ihc6uukWPSmpXF+uPXSKE lowexbis5ckxpJbGvHIlu3SM/Tn6OO4p5apaWkw/iCG4TB+hTtrZ/XflS6/8NdKgutb09rX6Nwd1 IYVqC4heKNoZZQ84bkHuK3jfObjGV8bJTm4ZGlLxghc/SKXG678MM8U1RyVBBBwOBSX5kIO/cRkb Bmrel9niuHl2ogweCSaf28Vxay5WF2GM71XIFN+kulOofEG7/h3TeiX+rzx5VmsYyxzW1IfLH402 Nl6jdPatp9kY9ssl1DgEf44rh+7GZaa/XfbWdzG4OWbcp702yN4XYSvyamte6Y1Lp1mS/ikSSPO4 sODinemeHHVvVNrDe2Gg6m1mwxG/on03HyDVz5ccJ2mOFyrHYp40cKUx8U5aSK5kXZJhgOcVnDeX zr7UrE/lemdSZxyT6JCj++KxvXPDLXOlQh1G2lsJE4dHHLGt4csz9MZ3wuqY+gQe5Pxn3pRhZVOT lfcUzX8zLOArs0S8EH2oxLxTEZLlv6TXTSSy9xRI2bI+c9xSZp4rSJSMSOM5PYYpvPJ6QYqQrdil dg+TryCz+M+mWnWXWV3LY9PM4e0tIuGnAOOc+1eXLmkvjHfHjtm3JcMz3aE28TMSMBY03ZNPdP0C +u7hLa4tXihcbmlcbdor1/8A+DfAHwy1yHQZ+nNI0284jMk8eAfuzE1rPzW+XrpOHpFuotCMIt3G TDARtwRwUx7VqW3s8fqPNOC5g0wT2tnItzsPEZGS/wC1Be1uNXBP5B4Ao3cCvVjyw+VbwwsPC6w1 fUen7LV766HrzXV8nMX/AEj7Vs5fDzwPmvP4fHpfTv5qT6fTjI3H7d6d303ZI8VZ7a7Szy0THaeH ZMZqPSVpG2KyrKfdea9OfMr5MNNhs5dU0aT0NLZwrWsY+pSe2OO1Zp0p5EvC/RugrS7m06Sa+a1W WSdsEliMn2+aTdy0xljqbeTTzPbQlZ0KEd2ZcCgWQtbu4Qs/qEHnZziunfFHwM0+bxi0TpcSMmmX 97HE4QcqhOK7K1/yL+GHRPSEz6fp7/noY9sc8nJdvvXT/wCz9f249+Pk8o9UuoLVH2RNtXgluMio u2uBIS0H845/Sveu8OnPIVD4idTz6xq2s2+n9Kw8zQ2rj1lA75FdP9MeSHwe0vpiG403Slux6W+O +YAu/wD1dqeXy8XTHHeO3jubiZsKluyOTg7x2olxPHaxmOU7mU/qzgGupvN34I2fQ9xG+ln0DdSh I1QfJ4rYHl7/AA2LXqXpaLqPxC1qW3hbE0UNsw27MZyxPaunLj+qS37Yw1ndRwsb+5cRpDEC3sB9 VHW6luZFg9JpLpjtCBcZNetXTvkl8G9SspYNDmju54l5lgdXI+M4rnLx18lup9KXLT6bKsTId9tL EOTj+1Tj/wAl1FzwyxjjybpLVNLtY31K2aBJf0qwwTULcbYGKEY2nsay7rbVeo7a5ltdbuZJ5bP6 QJBjGPesPFydUk3Qwi4f4Gea6cmPjdOGOfl2V9Myhl7ntiqJx9C8MO/3ppJFfqWUQNbqT3YYx+1O RG0UeD9Tn3PeuU3XSZS3QoJYYzirqqs208jvQkjbccElj7CqcSiNnjIVkyWDdwKW6jc/0UsiM7kv tCj470qxS0a/RL28MKOMrgVtHy7+UrrLzLai11YI2n6JC22a/mBCZ+FPzXaujfha9FQ26RT9VX13 qUSgvH9O1T/3xXmnNja7/rsjzhk/hivMEumYDhTs5NJikUphJcuf0nFdi+MHkx/4QilW2R7TGRHN IuDKPtWkfDfyo9b+K/Vr6NoVq0NrG22e/uFIjQfc12yznuMY+9VqBzJzmcyt/qAxRXZIIQ7zK2OT jkg16A6B+FiILcC+6sNxOBmWNO2f8VrfxK8kbdJLcpDbzWpQkLNIMLL9x8047+y6jrn8PblCSUsk ZUj6wMHNM7i8itXKTMrcZ5bbipnrLou86O1ForpCqLnv2NdaeSLyTaL4m6Vcdbddp+Y0rlLezJwp 99xpyWYXRjl5duMT1CyRi32mWA8gomf96dC7Ro1OfSc8gnuRXcnib4I9HaTrV/a9MWsFvo8O7c4G SpHfB+K5e6c8AOofGHxIuNF6KtDcWwfa11cAiGI/c+1TPfHjMqmPd01wL8v2OUB5PakC9ilJCvll 7/FdtaL+FX1V6K/xPqWzEhH1iFjj/tWGdeeSi46Ft57VROskfHqyDCv9xWZybas05VluFiQ7n+o+ w5NDIuI4vUWVET4JrY/Snlp6z6/6zi6f6dst80j+m1zKP5SH5J9hXQulfhQdbTqp1bX9NJ/qELtj /tS8mrrTeMntxa1/EqGSacFR3VRTG4uYbhFktpgEOc7+MV2H4geRCXolZLFPWe7RfplxlGPyPtWo OkfLZaax4raT0z1nqMujaRcvhrlOAD7DP3red8MPOs7m9NM2C2t3KiSXItgeN4+qjaha28M/p2t0 LrH6mUYr0M8SPw+enPDrpyLUumt2q2zgb3uB7exrn3xE8tVpa9Ovqek7oLqJSZYl/TV4/wDJ3DLL wnbm1sFN3v8A6aHNM0OGaUJxnbQZUm078x6oLOCVXPc84rpbya+Re98x9nda91Bqd3pehKxSJoB9 TuPbn2rnnn4XTpjPKbjmQz3FzMqxqmD7lhzRmllidklAixxke5rt3xQ8nvS3hRe/w3SUm6gmT/3Z RyD/AGrB7v8AD28SuuY4tZ06xjt7Jk3iGXjIrdy17Zs1XLLjaQTKoPtz3pUB3ybXmDfatxdT+Ve7 6dmkhvpnku4/paKPuD9qc9KeRnxZ6q0x9UsunZY9NB+h7pSrsv8AqHFYvLN6a19tJMHPqfUPpOAC cZpqZS0vp5KkdwOa31o3kk8SOpL2eDTdHub38udskm36EPwDWa6X+G94mzS/+otHgZuCwH6f9qz+ zvS6mnJ3qIm4mbCe5IpStYzLhLhnf/SRiuxpfwyOtbS1mkuHJSNS7lux/wBqwT/7ATxC1JPV0jSr 2+tmbas6Rko3OODiunltjpz20hsdp3mP/wCJzTldc1SaEo10ZrUc7HfNbi1ryddWdNu0WrJPb3aj C2+MnPxUYvlD8U76JZI+j7yGxHP5qaMhcfPbtVyuuk3GrjqMzRF0IT7ihXF695bfUxBX3IrbfTHl N6l626tj6bi1W1065bna78H7D71tnqj8PHX/AAysYrrWb+bUoXHAthuA/fis3LWUxanc6cigW7XE Si4Ac8so96WoEk7qrYXPFbvu/LhJqEcj2SLFIoyBKcGtNdRaDd6BqVxY3sfozR9h8128bO3LynoK KMLuUkk+3NLLExhf0P8APzVoWCIoPJA7mqlusKMrnHvWHTrSwf0xIx5A/Vj3q4JuSBGp/c8UCST0 5NsbFpGG5Ub3NZ1054IeJPU2lxXNj0fq629wPUjuTCfTK/IOO1c8uSY3TUx3usOt4XimwxAP3olx crBw3+1bAn8tXWNrCXvgsEoGSjZ3CsatOguobnUmtLbQ73VWiOw/l4y3P+K1cpGZd1jjzLMv0HDf firLHJJ2AY/vWy4PLL4la48bW/SN9bxt7yxEY/2qQ1Dyj9e2Nust3B+SC8kDNXG+RlfFqhLWVOWj BYfejwRRXMjBiEKjsT71Oal4SdV2VyYYLW9vtn6ngjLAf7U8s/Anr7VQvo9M3wycCR4yM/ftXK8s l0snl6QFhPaWxaK4tWeRuUmD4C/2pvJfxw3BRB6hB5962ND5VPEyZlkfSpIoF5O9SM/7VjPU3gf1 V0jMZLqFYGByc1vy625XLVY9c6vC64aAA/YUzaQu4IjO34UU4XSNQv5hDb2txOwOC0aE5/bip/T/ AAV8QLxlex0y5SEjI/MIQT/aszklvTpr4+THgCF+pWUH3IoT4TGOamb/AMOOttAeSfUYJJIACphZ ex+axyd5IiFKlTnDZGCK7Wac8cpkLgMQVyB8UJ1U7sH39xUlaaNeXpH5WJrjkcKKcXvTF1pzFrmF 4cDIDCp9tztDx4jYMV38+3vT0MN5YrjP+1OLfQNQmUSx2kkkR/rA4FNrmwmsGIk3YJ4zT00tL9TE 5yfvQET6z7n3o1xYzKm/BVWxg0503S5LgsGJG0Zz80ZCtkG5Sf0ipWHTLea39VYwGHIYntTaC1e7 m9ON0ixxvm4X/NFudHvdNdQ93HMGGQbdsitNbN9QRYv5rksF4zQk2ncwGCe5+avcs0ygOGBH+9JD FFO1GOffFQWkUMRjkZ7Ck7WQ7e5qzMVPuM9zSHuCJf5f1DGC1As52A9qshY7ifbtQlfAAUM2Tz9q IbchshiB8UBAeRn96WGG0nuTTcsEU5bJHIpQkIQMBnNDYcspJGAfsaUJWC9xn5qySjceDxxgighN m4H6iTuoDbTKMLlvuBTg2oWMMciT4NVaSPGNgk/lk52+9OmkQgEsBx70EeN6kIib896KWaJ8IxB9 8VYzfl84I2nktSLdlmkLBuG9xQSsNk5AaZ/bOM80G5twSuZDkHtRLaxSWQqbhwMZyfn4oTQGAsZM yAdiPis6CQ7IDgA88GkBv1DsashWTKpu+eRSGUA7iTkewrSiiTZjP9qW8+cZOab7jKM5wKpSpO0k miDM4OKQW2c5pqZfUlZEJIHPb2os5iVEViwlYfT96i/7H3/fFUkgzyaYxxhMCaYoSeM96cXEkMJR bdvXf3HvU3El7O2IIwD3+1FtHZ7m3WPkZwcUwguAJA8sciY7DHenmi25n1SH0HPqPJkKOwFefly1 jW8L8nph5WbKW28OdMUj9QyT7105oyOYlypJ+a518udrLD0LpzB8qVHFdG6VcSQwd8jHAFfN/G7f SzvWk2i8DHFXlVgnD/4oUTyOVYjCn/aizHCcGvt4vlZoC89SXVFRfasM8TC6xoD7DGKzJ5nGrNuG e3NYL4k3OTJHjJBzmvVxXt4eWdOb+uHEYnVe5JrmnxCLLDKDy2Dj7V0h1pcKUnAA3knB+K5n8Qbg Ok4J+sZr3cneMfH8d5NJ3jBbliwzk0FOOcZHtVruUpds+dwz2NKhBC5Jr5ub7XD67L2hhzx+1VtM mRjOfekjIbPt8UReFB5I+1cncpIwq4zkA96Iv1bdp+r3Whq4OVVgcc0uBR62Ryccn4q7TamcSJlB tYfPvQ7AA3Sn/NEuiNnHGPiiaHbPNcjHNWM7j093LsOBSQNzb/ftSp4FUZ3YcdwKTHyp5r6W3lKQ BUIHOfmrN+knHParv9AyAc/FKMZwN5CsfaqhIXKA4+r4pLZZdo5PeiAKpHJ3e9WUsNxGA3YftRkN AVwB2pZIc8cfNWLkg7u/tSsjI29vv70FBCQKttwOeKurc5zz8VZwHxkdvYUFv0YLcHHvSVbcMA80 p/5g57+1LS2IPPPx96AErsjIQMAnBoip/OIRuF5IJqasei9T1O3MqrEsYGeW5FMNU0N9LmjKy5c8 OKn2fRttye2M/NDEbg8gmjAblxKcEHg1cyFVIA5HvVDcll+o5/aqIDAsWwfgVbLE/V2ocp2rnHNW Bwv1LwODVoIzu2lS3NBV9y8Nt+1F/MmOPaDhxxkU7DS/gMB+sDYf00zO3ORycU9uN036gfsWqPcb e304rQvJtx35oHqMCc4JNUH3HGd1JnChcjOav2LTvuzt96FncB8+9I3b+BxV3wp9x+9PtqelyQTy aGzbew3UrIKH/wA0gOQQSML7VFVBI0O4lOSOM0lXZnZmHNEZiR88cUkJkjJxQUrsEKuM85FIDneV /q9hStxBx7/BqhyaBJyAftSCDkjPGKISpOKEx+k45P2oEkfSB7Ul+DjsKUG2gZ5zSXO89uKIsEA5 IyaHcR2zwkrH/MPZ6WwcrtQZb2okVkZYwJl2MOcCorH7jTmuFLcj2zUTquk/w2INvZmJ4DHms6it kjhYy4SNDn96xDqrVTquoo6xLDDCmxdp7/c1wuOm5T7pZgJowPnvW3ekHzqCZGVEi4rUPSADkSZO O1bg6My11GWxj9Rry5vX+P8Aym3XXQ8ZPS+08htw/wAivPXpTyuWvir4m6za3l22mo13KxlB5Ybj wK9C/Dx/V6WhPyT/ANq5v8LcWHjBq6ltpW5IAH3NeO5ar1STLPKNE+Y7yPaH4P6Np2r6Fez3n5q4 Fu8NwS39xTrwl8g+heIoF3qV/PYIFBaGNvqJ/eum/OsGHh5ozr+pdSUj/FC8sN+00pjZyf5edp/a s+XyY48dy1yD4u+S+x8NPEvTND0hp9UsNSg3hC31hs471sTpj8M/Tr/T45tR1u40t5Tn8sz5rOfO j1DedN+KvS1xZP6MwsWdZB3GHNPfCnxG6j6t1a3TVtWmvIkKFQRjGf2rftMJ5SuXPMR5J/8A6jJt PvrDXvz9lcthYHUgr9yahOnPL5J1BNCFtmvXlA4h4rs/z22pu9E0CMZIzk4/esd8tOjNLq1pbKo9 DAO73Jpv+mcZ/bA9L/DMXWNJiur7qNdKeQZEMiZZP71q3xo8g3WPhXpR1npbWo+pY4BumSFMNEgz 9R+e1diecbqbWNKh6e0rTpZ0t7tWaVIMhiR27Vkvl06qbXunptCv1lMqwci4GSwPHOaz5aa1ubeP 8eriZC119NxGSJD/ANQ7g1Ul2ssQdp9i4yBn2+a6Y8cvLtpvTXjzremWVmTpkzrKiDtufkmtieHf 4fnTHiFFOL7VLnTJFUMYoBnj+9df2dOGt3TiGFwzgE71YfSR2q0j4fJYbR7VtjzMeAkXln66TpvT 72TV7K+RXhkm4eP7VqO1AM8scpyynJatyn2DLiQsIuGPuRU5onRWqdQSLbWqO7t2bHCmouwRJb9k jyckYzXT/h3Z/wAF06Bo4FzKoYMR71jLLSydsI6a8sWranc26XsZW4YbVkjjOGNbisfww+pdUsI7 xurLOy9Qblgki4Ga6d8vupX3Ut1HC8cccVmgYbkzuPuc1iXme8W9bsvEaHpy0uHstPtdjOYmI3kj ua4+b06/4xxL4veU3rfwb1oQXa/xLT3XIvbVMID9/imXTPgDqnVNxbQ5lW4cgK6fUOe3Ar1P6btU 8XfB240y6kjmaeI25lYZI+/71rPypdMLpmvavCIRixkaEuwz2OBjNPK9M6m65mj/AAz+udQsvWj1 22j3LuWKROf81oTxZ8Fut/AfVIbLqHT3jtpTtjvo1zG/7kdq708e/HfqHSvFKXSLC7NlZafJsZAc CT7mts9R9N6d5ivAG5tL7ZI88Bb1CoLK6DI59ua1K5ZTby36a8OW1vTTe3EhnbP0pmt0+DPktsfF PUYG1GO5sbfd/MZH42/b4qJ6G0KCyBspJWilt5SvHuQ3Ga748H9Oteg/C+5128mEaCBpHY8bRipb XSa8a84fMt5ctG8I/E/T+m+gJJtSeeItdJNJvZX9hmobSvLV1bqV5bW3MV9cY2xIu7B+K2HY3Fzr fWGq9QXLNLcXN23oyk5O3dxXb3lj0r81p8mo3EIeZTtWV1ycfasTK6044Y/8nCt75AfF+0gWS3sY b3I3bTIqmtQdQ+H3V3SGvtoOr6HcabqEZwBIMqT8Z7V6Ode+ZfWrPxQ/h2nlbbSrGURyoe8wzgmt gePXRWmeJ3hR/GY7eJbi2jF7HLtG/tyM+9axzreXc281+kvBnrbW7mKGwhU3cmNiGPO41P6r5GvG y4nlu30FLl2O4ATKCT+1d9+V5bC76Y/OekkuoRLtEhH1KB3/AM1gPVvmQ6qh8TZdOtgLOytpQht2 H/MGfmrcv6ZmO488dS8K+pOjuqH0XqnTrjR9SAz6Uhyr/sa2F4eeW5vEnXbSxXVY9KMo27pBkE/F d9+abo7ResPByTqieziTVbOFJorgjDAt3BPvXI/h/dvZS6dqa3DQzRsNoQ8D71fPZjhtrjzHeU3q Ty3adZ6t/F4da0i6m9OTZHgofnPvWp7LVzJJEluS8ZAwfavW/q/pjSPH7wUu9L1LDXENs0qv32uF P1f7V5T9GdOPddQyabMNsNlcSQnA/UA3Brtx5ajy8+OqzTQdK1h9ILwRhGfBBC/V/mtheGXk86k8 bRc6hDrSacy4VprlN2/isv6Y6fWCO3tomUMEACnv/iuvbOey8HvAu+1JpTazflmkEmMMZCCVx/el 5K64ceMw8q8zda8K9f6K611npWdo7+50+c25uEGA5+QPala34V9edLaQ+p3fTF2umggtcctwffHx W4uhdXj6suG1u/b83qt1cG4nuGP1E5712/4O9aWfiL0jNpV7BGHiQwPEwBDqRjOK3OWyOXhM508r bS0u5o1eCNpkI+rHGKkZujer2to7n+BXhtJD9E+w4NdfWPl/ttJ8XpdAXTJZtJ/NCSPKYDR55Ofj Nbp8f+vtL6B6YtumbGGBry5QRJAFGYYwOGxWv3sX8fX287bTwa671K1a4tOnbiWNRkyjkVE3vhJ1 1Yhpf4FfEnttU16keEfUFrbeFb3qR7ls4HllGOSQCSP9q0Dc+fqEapLbQ9KwSorlVck5xnFcby7a vFOnDN70v1Jpbqt5pF5bl/65oztP2zUTqej67pqid9LvY4G7yCFtn+cYr0U1zxfPjL0/DpdzodtY 2zypK7DluPb7ZrpLSenNK1Po6z0+fT7aawltgjQPGCpXFTHksdv1zxeLFvp2q31m10lk/wCWHvnL Z/aon8rqjThLnS7u2ic4jkmjKq39zXbd94W23QvjMtlJYiOye73xR4+hl3dsfat0edTT9JtfBTT7 r+HW6Kt7DgxxqpHB+BW/2s44bjzt6T8vvWniU0kfTVmb+eMbmXcBisH6y6I6j8NOoW0nqrTJtPv2 U+nEzZDj7V3H4EdRDpbqXTmtj+XhuSB6gPse9ZN+I34OwdY9BWHiDpIR7/ReG2j9annmpjydtZ8W sNvNxHKxlihDf6DSUi25bHB+aLb3Z1CL1pMNJIN5wOxPtSlOUB7/AGNevG7jw3oPAxguFUe5pS3m EcrJj22r3NWkiWUMhOARWa+D3SNt1L1jaxXEXqWyHBX2zUyy06Y4eVkYzYQXIt3kNvLLnsqxk01a 9mt7oRTxz2hYZVZoygJ/vXp94N+DHTt7r2nbLWKeK2KySwGMFWH/AFVl/m08vfTfiN4YahBp+hWi a3aRmaC4t0CvCqjJ7fNcZzSu2fBcft5RrdTPHGbNPXmx/MCrmln84rK38Puc/wBTiI4FdK+AXQ/T dvo8EuoQr67Sem7sM4OcV3y3TXh3034dLrWoaHZtplpAryyJAGY9hn796v7tdJjwW4zJ44vqKW8g aZZYwP8A23QjNPlld4/VihMyt+lV5216h6Zb+AnirdLpydMW85lG1WntzGP2B3VpHxf8t/SXl56m 0zWoTJdaBqd1s/KyD6YPsPmp++J+jVcVSNcKFRoJgD7mI8f7U1nuobcEzCaNge7IRmvWnpSTwi6g t9LsU0izlnlVfT9WEDLfGaJ4zdF+C/h704dc6w6YsRZbvTXZCWZmxnAAIqTn23eDXt5Ii/jwrQt6 4YYG1u1Nri72IxjRsY5IGTW/uq+jehPFTxAhk8PdDbRdChJMkj5UyZ+1dV+CHk96RGmR6pqtmDZI NxFwMCX5bn2+9by5dMYcFst28w5dctoAFZmVz/S4x/3pMOqif9ByT/SGzXqnrHhr5beq9dPT0nT9 lPqJJUSwA4B/+QOP9q4X84nlu0ny+9VQX+h3pOjak302Wc+kx7Y+1MeWZseFnbSFzdthgDn+9RrS ZbH6uc5o4BCHP1EnmmErBJQD+onAIrW2ZDg7WfLtkjtn2peckNhSPkjPFNiiesySfrAyUzzQ31Bi xVIRFjgN7U6123Mb7P8Aasbbo2+gj29qWs0casrfWT2+1Q8esCCQxs0Rc8cninsVzHLaNI2NzcKp rNs12z43bM+jepNK0G+N3qOnpfoqFBCRx+9QOpaja3Wp3VzaWwtreZiyxDupNY813CsZDuqN8KTz Tmz1Gwt/5ki8j+k5rMs+msplrtNxrcwWvqywsI3GVZxwajXZjlkaNc9xtrMItfttV6TvGnlEhgiK wQRjPP71gUN/aw2sTTq6zMvKkHvXTeP28+PljejuGwj9YsfTDHk7Rg09W3RRxz7VHw3EKRiUxhFx nDnFOYrqNijRgFD7ZrpLiap/aRKDuPH7072xsQpIJpvFqdtFbSsFic9ipbk1a1ure4AdVww7xryR XWZSOdwyqYgOxchsYp3G0e4ssQMh/rHFRqPGOVxtPue1OIrm2LemrAyAc4PFLcb7Y1Z6ORdywSYM a+mfYLUlFd7o9yAf+MUvQ+pNP0wMZrWO7QcFHPamM91bT6hM9qhtkJyITwo+wNTePqJq72czXUsw A3JGB7oMGk+uXh9Jirp7ZqPdzuwf9jVK6rnAJFTU01unhZViKKoA+RSYdT1DTpFks7kwPj6pIzg/ bFNpJ0jUttJ+w702muIWfazhQRzzyP3rnZjfbpjMpejvWtc1nqGBLXWOoNRu7ROVt5ZiyZ9iBTKR g8UKLwkfZaELtEBJjdkHG4imz3aEjaCob/VxWPj9O2Nyh8WLJsUkZ9xTP02iYM7LMVPBbuKKl1Aj LuchiP0gc02nukYuEjzz3bis+GMd/K67L3KGDkAsTznmk3CsZd4bIP8AT7CkSXMUP04GfbHNDeTO c1fHbXldaOIwqnhyTnJUnIp1YanPpeoLNDIsMudyuO2aj4niRizce396Xawy6lMohiyEfkjuftWM vHF047u9M16g8Yuu9b0k6XP1ZdjT8bTbQylVx8EViOkQflo2UHe2c+ox/wB63p4Y+TjrjxftHuNN sl0iNRuM94SiuD2wayHqj8O/xa6Y0q51CJtO1SC2jLvBDOTK4HwPc1zmU9x1zx/tz3Kpe2UhQTnu D3p5onUupdOTLc2DCKWPlWJ9/Y1knhv4J634j9SnQLG3lt9VB2NBMCAh981vWX8NbxL2j07/AEpc dh+YNYyy2smppz/1p4ueIfiNpsFlr2ty3ulw422qOQuPgisZWzhmwSuB75+32rd3iL5KvFfws0ht Uks7fVLNf+Z/D3MjoPkj2FYR4ceCnVXjFqb2HTVor38alnE52qAO+azua7XVYSY7e0b1EXcp/wBR zimV0be5ZniRFY8EDtWWeJ3hD1l4Qa0ml9WaV+Sadd8N1HyjfYH5qd8PvK5114r6BPqnTlhHKkJw wZiKXKNaasWLb2kCL329waJd6jczwpE8ySRx/pQnAFTurdCdS9L6xP0zrmiyWmuI+1QV/UPt81nW meUHxJurOO+PSclzHMoMYO4f3rPlL9MtIyWsck4Z1ABGCTyDSLu0tI4woKyY5HHGay7r/wAMutPD GX1eoumrvSrUnYk8kZERPxurDblvV9IqY97/APtoc1uTFm9Tozjjii3FcKze8fA/xSlt4Lp2VpVV mXBLrn/FXnk9EDCD1P8ARVRrJLgMi5+3cVrxjG79nWmsui3cVwqrJOkiuoUYVse2K6B6k/EG8UH6 BHTOl29tY2jRfld+0GRY8Y4PeudLh952EFVUc4pv+Wtol9Z0Le3LGnjPLbp5/HSLtJZ5rmW4uH9a 4mdnckZ3MacoDDhWxuJpwZrSBAI1I9yfimU6NfwvswqIcFx+r+wq3LRJsQK8oZSmF93zQi5A5XIX jjmss0DwU8ROqNKS90PpbVNVsvaWC3LKRUP1D0X1J0TcRQdR9P6h0+8vEYvYSiv+xrEyiZYo2CCC EM80nrK/9EgzinNwDb3HrBY1WQAjYuMfahFDJblSqxyITn4IrJ9B8MeuOrtKFzpXS+p6vb+01tbl l/saeWKyMcLvOrss8g9iFNM47D0EbYzgZy31c1J9RaDrvQk8ceudP32jSt2W8hKbv8002JcyO2Rg AMyg1qTH6b39UxfTvRkWTbku/wBTk8gU/jmhllPKqyjapzxT3pPozVetdbt9K0pXunvXEMcTD9JP 3rZnjf5MfELy/dHQdU9Q2NhJo7lQzQTlpIye2RV/ZJfFLNXbV9hfX+jSD8jqclvL/wDhYyQf7fFT D9WdSSMNusXUnGciUjJ+axyGR1twxT02x9JxncKfJo+t3Z9az0y5uVCA/wAuMlRXPUtd5l12rVtZ 1fUoTFf397cxHho3mJB/tTBLGG3hjTJwDn7j7Ul76ezumgvYXt7jPKyqQV/aiPNKimUxhgWwAe5H zW/j9szHvoa01/U9KlLadqF1Zxjv6EpUmo/WtT1XqIONT1C7v2z9AnmLCprp2SbT9Uee40dtRtyu diKSM0y0yxPUXVq2LxjTPzL4VZOFT+5rUwxLJfaGhsGtAMxLvH6ce1OHR1Yc4J75rIetOlJ+j9aT S1lTUHJVf5bZyW7Yqa6t8u/ij0boUHUN30ndSaPPGJRcwRlljT/U3xW7ZOjHjkm4wV1whGcfJpX5 iRmWSOTIQf8AL92P70NEOIWU+pG3/MPxRwEIG0AAnt9655avSb16ZPpHiz1l07p4g0XqPVdGjPdY Llgqn9qh9d606m6zjVOouoNS1gBv0XEzMoHzimOnaZdaxqsdvaBzIzen6YGcmp/rPw6678Mba3uO pumr/SdPuMeje3EJVGz2BP3rh6rWetbqGtru60yZZbVQyp+nacMKm+p/EvrTrKxg03VOp9Ru9OQB RZSTMUx7DFYzJOFX+YGt3IzlsgYpem3yM3rxSfmI147dq6b9Vz/1T+OFLNUij/QBzn2+1F0vVb3T LoXNi224jYMG+CDxUdcapE9xmZViQjI9Q4xVJqFuYneJgEHDFTnitZZ+U7JPFm/Wnjd4idf6cdJ1 nqu+uNMKbWtEmIRh8EViVpbLFDCgARY+3yaBHqluZAh3KPZiDj/tVrjV7GX6SQpHHqEkAVznpu3/ AEkor66sbpHikMBT6omH9Jrcmkedrxd6c0qHTrfqX1Ft12oswLEDGAM1okXQlgX1ViK4yHJPFEW8 9aFmi2SrGoyRyQKzJq7S3c7ZJ4heLfWfjBN63Veu3epW4P0QvKTEme+FPaonRuoZOmrm0vLHPr20 m6Js/FQVzfW0W5ZJef8AT96RHcRtbM8YyB/ualyn0YzTcfip5yfFfxf6YHTOta7Hb6OFETQ2q7Gk UDA3H34rTENvbafBFAkxcqmD9jSr211HTVi/iFhc2RkG4NcRlQV9iDQPy8d0Y/SOONwB7mt4WyGo TNODKmfb4q/q7lbjn4pKsFY5UHB96U6ZBOMD7d62ytEiyOyPwjgZ/t2rIenutNZ6S1mDU9Cmmtr2 1IIuYH25xWOJtlOVUgfejJ66qWiwvp859sVzyx26Y5a6de6T+KP4y6XpEVr6Wl3LQIFE1xBukIHu x961h4n+avr/AMatatr3xBkM2joAU06zUxwMfY47ZrSO1Z5fXcAuyjKgnJ/tU8eo7zVNCXRmkT8h AwIBA3A/v3qemOrem3vBnzg9XeX/AFHUX6Vs7d7a/JItrpNwUfasB8S/GPqfxb6/verOp5YZNVut mTb/AEoqr+lQPsKwWJLe5uBG8z7d20uB/wBqVeWulWJeSOczsn6i5II/tV+rEy9y11DbfiSeK2m+ HsPSul2VhHbw235UXEkIZ9uMVyfNLNf6hNdyyh57mZp52Ax9THJxUjdmzgsormJ3jEgyBg4/am9g M+o20DA3YbgmrhPGaYsmWXkcnqDULOW3khupEMJBRWOV/atm6rFY+JPQs2sQ+nZ6tYqGmJ7vitUL eQzRyOykYGBxwKrT7+5tLeVLaV1jl4K/0tXTe2/vaf6P8RtY6P1mDV+n7ie0vrcjMkblScff4rtb oT8WfXum9AhtupNB/ik8ShBPFwWA/wBXya4DRGiLRzBU+Qp7im89mu1S8zG3Y/SkY3DP3NcvHtu9 zt2f46/iidaeJOiXOldOWidL6dcRlJmcZldSOQCKivKp+IHdeXbpi90m+6Zl1eK6kNz6qPglj71x 5cSQhwyQHfHwpcYGPt80SWCRgA0mAR+n2qXDd25Yax3tsXzAeNeteYjxQv8Aq/ULBbSSXasEaEDC DgD/ABWJW0xiG1zuJ4UvztqKtYfRYMXJ+fvT6VhKdwG3HtXT60uM8W4fAHzVdWeXnWVn0S6ZrLf/ ADrOYlopR78V2pH+Lv0VJFbyap4fX9zqMSjbIkqfS3vtyuRzXmQsbtkSE4P2q1tpdoZdzxFsHO4i sTDTWXz7dK+ZTz3dZeYO8axiaXp/pQscWMTYLj2EhH6qV5Y/Ot1R5ebj8umda6blIM9nId2P/h8V zc9p6bv6f0xZztHYUL0NpJRiM+wrrZ8XPHDt6hz/AIs/hrdXEN9N0FfzX8Q2pIzIZF+ysVyK5d81 H4gPVHmMkfQ9AWbpzpcjBtNxEr/O9hwa5eW2iP6ozu77gvvVQ2UcEhYAox/qxg1nHHV234si6I1l eh9Q0+6uCjm2nWVUHdsEH/6a9J778VvoGw6CEEWgajcaith+W9JHAG/Ztz27Zry+is4nfcdx2j9X fFIlRYWMUZJjPv6YrWON32752Z4yGupahLr/AFDfay0bBLmV5JF+Mkn/AM1bT7u5jR0hYqpPBB7C noihFuySyuu7kYHBP3oCwpHtWPv8g12zu3n1SwrHO45PzRYbj0izbyj7MLj5oHottxmlRxBXDFtw HNcMp5RccvG7dieTnz0XPgPZnp/WoP4n07I4JZDiSE/Irs698/fl9tYn1yO5tLjWNu8hbQfmC3xv x3ryU0Pw2bqbSbvXEv47VbdSfTLfqx8isV9IZjfBUnO5ggya5442VM8pldulvN/509Q8zfUdtbaf H/B+k9Nc/lYWB9V2IAYuffOO1bG8lHnnt/BBU6V6qVpemrmcMLwElrYn3/8Aj9q4kFrGq7YkAOc7 u2aqS2jaIiViRnLAjvVylqY2Tqvaafzh+WjQdVuep7fqTRzrDRkmaC3ImfjOAdvc/NecXnL85Ope ZzqNLaySXTejbIlba0LfVIf9b/J+K5qNnazsMD1QnIDqB/4o8axbkZECsvFdJf7Ys2y3oPqm76S6 j03V4WMbWDpIrqcEAGva+SXT/NL5WJGWJL1tY0xvSiU/++qkL+xyP968K5Wkjhf0/r/1AVvDwA89 HXnlu0e80XRrRNTsrv6lW5OVib2Iz2rlllfPbtljvBqK76d1LorqPVendXjMGo6ZcvDPGThlIJ4r 0J8kvn76c6S6Ys+guvbg2lnahlg1aXJRVP8ARJ8/vXnd1N1Nf+IHV+sdVazJu1XVbpri4CHgk009 JCq+ogMJ/VHj/FZsty8kxu8PGvZrSvGnyydBdR6t1ppvUWlR6pdqXkManBP/AELtwprz783Hm+1D x88UrbUOnzc2WgaTIpsoJnyPUXB9TH3IrmT8haSFtoJ5yFzkAfFOIoFi9R8YcjAUcYFbxulmL1p8 tX4hnRHiD0cnT3iRf2+ia7bw/l7iS6GYr0YwSMA9xU50drPlY8GupLvq/SOorHTb+UtI0zSllUnv tXbxXjh+XRwCE3MG4d+MCquYrZl+rfPjsjOdtWbTVnp2X58fOxZ+Yae36P6VEidKWkwknnc8Xbg8 MBjtWC+Rvwq/+tfx40iK4tZZtCtZd9wycBccjn25rnq1jtw6sEARBkKBjArfHlU84+qeV46sNN6d t+oLe+YnMrbXU5+RXO3t6cPjx2T27/8AxQvFTSugPLpN0sLww65rLRxWNupwWjT9RJ9q8f7CFIrd JjxIfof962F5i/HPqPzI9dTdV6zDHaA4jgsFkJSAduKwV4ozbpGJA5QYJHsfmvVjZMdPnzC+W28f Jr4vx+DPjlo+rhRJZzt+UfccDEnBP9q9IfxG/Cybxh8tVxcaNDHfzafKuoCZcFvQAJbB9xz2rxqj d0YtBKUERBWQf0mu1/DT8TTUekfCWbovqHp5eo50tzbW87v9JQjG18d/3rz4bxy29HLJljGqPIb4 fdN+IXjdpkXV97HBYWwLG2mk9MSuudoyfvivRfzv+aLR/ArwsOidP3tlJ1Jq0ZtrOzt3BEUJBBcY 4GBXjO91cajql9exRtaTXFy86x28hQRBjnapHsKtcWd1qV0skjT6o44PrzM7J+xNTHG422l707R8 hvmUuvCjxcGhdS6nCNG17AuLmdsiJ/Y5+c+9dc+ePoDpHVtO6Z8RXvLO31PSL+GP145E/nRO2ctj 9WPvXj4La2hgbDTJcKfpXJyh+xozXl9dxot1rGoXCL2t5rh2Uf2JrUlW47u497etelND8Z/BaTp5 9Ugjs9UsVWK4SUY7DnHuPtXGU34T/TRGYuuoImA52nt/vXnjb9VdRWMXo22v6hbwr+mNbl8f9+KK nXXWKZKa/egjsxun5/3rUysZ8Nd7d1+G3lxs/Kp5sehNOHUdvrMWpuJFlJCGM5xg/wD01tn8U2/V PCrRZ7e4hJhuXJ2yjcpwMHFeWE91rWoP+euNVvLu87+qZ2Zk+6nPFNr7UtX1m1jGqXl3qmw8G5nd gP7E0mWqzf7e1HkV8a9M8TvArR7ZblRqOiRixuFmlG5yOQ2DzXM34vOqiSbw+jieKT0Z3kAjcMx+ cj2rz/0HqXXelp3uNF1KfTZHGHEEpUEfsO9D1TqXUuqbufUNYvbrUrqNMLJdOW2/sDnFPKHj15Ou /wANvw4s/EjxsbXb2ymOm6ZCZ4DzhZlIxk/+K2t+Lt4oxrofTfQtpfLHeSTfm7qBG5KHAGf8Vh3k 2873hR5dvBubS9QtdRGuzSmaYR2/0yvjA+quOfFjrzUfH7xn1XXZGcQ390726zsf5UfcL9gKxxzW 05eS52bY50r1NqHRz3E+lmMSSKI97rk498H2os/VN3qMywxWqpdsf5kgTcXH7VHyWV5caxFp1qF9 R5RCgHY5OKyXq7pjWPBXq6wt55Yfz89uJ0kGGC59ua6eVvtiTpid3bT6hdbJIXZ9wIUoQf8AFejn 4R3h0F1LqvrN50DBP4eLZuXU5zuHwMV59W/U+vf8Q/xC7ukuJwGCsqAAA/ap7oTxi678Nr28uOk+ prnRPzLlpUh5DH5xWa6Y9x6Y+dzzydS+A/X9l0j0fFZS3ywrNcNcx+rkMOAB7Yp55HPOn1R5hetd T6c6pisUuYLU3CflI/TOAcf3ryj1nX9a6s1251fV9Rnv9XnOZbuY5b/epHo3xB6q8J+prfXOkdVm 0zV9u03kQz9Pwavl0uo9fPFHw3/hHnN8OOv2uI1g1SOTTBCRtYOkecn981qL8XWAR9A9N3pIXbK0 Wd2Dye2K4M6180Hi511q2majq/Vdxf32lv6to5AUQt7kAVjnit44eI/jR+R/431yXXUtBthjYYCf fA7/AL1qWGX1v6YWllGEXa6RuzkbWH+9ZH4U+GnUPjN1pH0z09aJc6vLlolPG5R3P9qxiSQ/SH4d eOalegPEDqXwq62s+oul9SOlatACEnXn6T3H96zlumN129iPIT5Z+p/L3omrf8SSokt6Ri3QZIPz kVp7z9+UDxE8XPFaXq7pDTl1KEWkcWz1AhXYvPeuYI/xN/GiGQQy6sWcDl1gUqaTqn4lHjbeabKs WtJb7wU9Ro1BGfiph8Zoyyty8qc+SrxzuvLP49y6X1JELHT7qT8hqSSHP5Yk53nHxXoV5zPLbZea fwxs9S6clhutaswJ7C4hYEXKEDC7v714sX9/qHUOq32uarK9zqd6/qyzH/3Gz3rcPhR5x/FvwZ0a 20Lp7qJv4EHLRW1xhyrHvgnt+1Ll2tvn39uufLn+FdBfC81Lxa/MQjlItNtpsH/5lx7fauE/Fnwi g6P8Q+rdM0Cdb2w03UZYIwp3OIweDmt8XvnK8fvGCC96bsNcEUM0RW5aNQo2EcqWHb+1a20Ww6Z8 LNaUa9rlzd9R3xCyWeN8YJ7lia6cd73XlzrRMDocmMgnOCD3o81u00LRrlXH1Mfc/YfFZz406P07 ZdaQLoJSNWjL3Kxn6Qx5FYY7uqN6Ywzcc0zkvTphlqyvSv8ACS8W7Czs9b6C1G4ih1SVxPZRngyK o+oE+9bX81Phd5gJ+uH1fw11ebU9Iu/r/JRziH8v/wBOT3ryJ07VdT6dvrbUdOnktLi3YOt3BIVk yP29q628P/xRfFPo3Q4bHUba06hRVCR3E7hHUAcZwea8uN/V8XpynnfKOgOlvB3zOax07r931D1o /RosrZ5EW5kMgnwCSAw4HauGvLzcanrnmt6Rm1O4e8vhrarLcO25pWDd8++azXxt/EE8UfGzpOXQ lmj0jS3JFwLZ8NKPgkc1z90J1rqPQfVGkdQ6RIP4nplytzG7/wCsHua9mOXlhp5ZnZyae4Xn5nMH lS69KnG63VW/bK14a6RKgso4mAkRV3KW5zXU/jr+If1n45+F110jqGk2unwXQAuZ7cg+tj/tXKsA /Lsm6IoNu0LVs+GmfWTb/lSEmqeYLo23cgObwMMDgDj2r1M/EmkMPlE6gAOCZrdM/wB68euhOuNR 8MettG6m0uJRqGmzCWJH7OPcV0f5pfP9rfmJ8O4ujz0/DoVjIUkuJVl3GR17H/vXm4pq9vXyZbkc nRRGaKS3ZldvSxkDnHwK9g/wtvEHR+oPLbpvTdvdKdX0GaRbu2P6lDMSp+9ePcCNbsGztZuCV5yK zvwl8X+qfL31ta9R9NXhglBzIndJkzyjDsc105Mu5pua5MNOk/OF5TOvOovNTq8umaPJc2vVGoLc WckfKlc87j2X+9emPUOqaf4NeX55dYkSyttH0NbabByBJ6QXAPv9Wa4Z0/8AGENxarJe9BQpeIvA 9UnLfY+1c7+ZXzydYeY6N9MuD/AOnGxnTIG3Kx+WPc1rTz229IfyqahH1B5n+hiQQ0GpMwI9wZMg 13t+LLcNB4G6KoJAa/IOP/iK8z/BzxQt/BrxM6a6meyFzDYXKPMB3aP3IroLzmee6x8zvR8HTWi6 C1rb285mFxKSXxgDt/au/Dq8ktcua7x1HGcgkuh6RCqmM7sd/wBqkOn+nrnqSeW3s2TEKZdpGxgU FYporK0kmUKqjB+f71a62qPUg3RpIMN6ZIJ+1Tl1c9xy47rHVM1hUNPGHyUJU/vSLi23i2lGCEA4 PzmnMUHox/QAyn3Y1d7YuUYYynPHvXCuu9vcPyN6mnVPlE6fNrjfJbT24Gf68Ecn+9eWXUfl660l 8w8vSh0O7/ismpbQAh2fU+c7+2Me9ZL5NfPJr3lo1A6Hq0Umr9CSsWNuP1WzHuVruu2/E68BbyRd XX+InVUiMe/8j9Sj/TuzTDJMp22j5mgOkfKFrtreMsc1po0NqwLDl1VFIB9+1Q/ksnl/+xI0kyQ+ mq2cxRieHGDyK84/N/539T8x2orYWIbR+lbR29C2D8yk/wBbfJP3rdnla/ES6H8M/AKbo3rBri11 LToHhsBBB6izqQcbjnjk1qZdadpj8duU43Z/NQ5XLK+s5GPneO1eqn4gTFPKPrPyRAMf2NeQ/Tvi tZ6V422PW91DJ/DU1VryQRruZYyc8Cu4fOD+IF4Z+MHgNd9K9IyX99qF6Yyz3FsY0jwOecnNZxl8 mc7NdPN+1AWZm25zkZPzk8UuKPEbxsNuTnNKs0jSJssSSfpz/wB6NFbxz3q2nrruYZMhPFdaxKY3 EciPbHbzDKk27PcBhx/tX0C+CfWdh4seA2iappDiSK50kWQBP/uLHsIz+9eBVzpZS4ZY5VlCLggH IIrqLyW+d7UPLTqK9P8AUET33RF0xZwhzJZn/Uq++a45XVdZj5YtK+Ofhzrvh74gatoeoaW6axBe sTbqNwYFiRyO/Bpn1f4Edc9I9JaT1RqejSWmjavNsizERhhyc/H716nXnmp8rXX2sQ9T36RXmqoQ yXN3a4kB+43Vzh54PPd054oaAnR3RtkLnQUYerfSRgMSP6VX2FZ5sv2Rv8bWGcjufyx3cnT/AJSe mbuFR61ro8kyBuRuXcRmuGOrfxPPFTRtdvLK1h0do4ZCoLWvbB963X4G+d/wq0vyz2mh3msvb6tY 6XLbPaMn1M5BAA55715f9UaiNd6g1O7jcR293cMwX3Ck1rimsOznmrll/ttPxI8w/V3jb4hadq/V WpLMGnjVYohthhX/AKF9vv8ANeuvVcKzeUe9itW9VD06NhX3Gwc14Ttp12bJCi7why02eQfavSPy g/iB9MydCW3QPig6WRtIBaQXBXcssY42v/b3qS9uO/LGRyx5Y9Dk1zzFdP2iIzNHch2CjO3a3Pav ULzuJp1x4WaZBq12ljps2rwJNcPyqLzyR71B9O695avC/W36m6fOh2mrNE0puLKTe/IyRyeCa4W8 5/nPvPH+5TQdIgFh0zZzblG/JnYHiQj2pju1rLLWnqTq+kaf1T4VJ0/puvQWMVzp8UEN7BMFIQKP qH74/wB6hvLr4Iaf4IdO6rp9hqSaoL+6/MyTKd31Y968MrPqHVNMRlOsaiyc7UF242/A79q9Hfwy fHnpyx8PepdI6m6qhstSTUA8UeqXODs2/wBJY9qxv5SLr4pb8SPwG0XUdFPXsWpiz1eMCKa3klBM yDsFFebHQ3T/AFL1D4iaVpHS3qHX7idGglhfY8Z9iDXQPnw8VtN688bL+XSNVk1DTY0EIMUpMRYH 2AOMfesB8o/WGl9M+YvpfUNXnS0smmWMTyMAiHP9RPYV6bL4uE/k3N48eGvmQ6O6DuZesdUvb/p5 Rm4l/N71PHZgO4rieNpJQd3EnuB7ivaTzveLPSx8v+v2lnrml6pc3oEMcNtdJI2cdwATXjNxNOBA oQov1fvVxvw0zq+W0ZNbMjBiCMe1CclmjLZwPepNmaRNzjvxQoolK/WASG3YqJttPyp366b5m/Di adkW3j1OJDI3G3kdzXtj499X3vQPhdrnVGmokl/pUYmgEgypyVBz/YmvAeB7jTdSi1OzkNrcRTLP D6Z5Vh717BeV7zWdD+ZDwmPS/WF3Z2et29ottf2V/IESdAAFdSxG48ZIrnb416pnvVv0j/AfzaXH mc6+03pYaU+jtZQnULuZ+VmdDj6R7VmnnU6gt9IsegGmdUL6yp2seccc4+Kv4adBeDvlettb6ki6 isbi4mZmN48qNNFH39NACciuBPOB5lpvGjrw6zpDPFoWmsq2SE4Mm1s78exNbyu+41nyY55TXT0z 8xvVcnR3g2uvQwm5/JzW05iBwXUckVpzw781Fv5lPE/pbS9L0G502PS7r85cGZg54GM8dhWR+X/x 06G8yvgJZaf1FrVg+pNbi2vrS7lWORZACqsqkjJ7HIqe8KvDXww8rOg6zqUGt2kty5aS51C5kT1z H3EagN2/asS9PNcfltpv8Ui+C9JdK2GRvuJ5T/gLWnfwnbwReK3WVjleLEOMDv8AWOftWr/Oj5l2 8fes7Q6fi00jTiyWZJ5ce5I+9QfkQ8YLfwl8xVnNd3H5fT9YUWVzK/6QCff49q9eeUnDMWOPH/Ja 3t+KLaM3X9tI5MaNaxCNyOCeOM1y15U5lh8yvh+JBtddUiTDdzyOa9CvxOOiH6q8KNH1zTrP8yln IXmuolyBEwG0k/FeXvSOoahpPUFh1BpdylrqGiTLcxl2wxKnutYz1nx46+nXhvhllv7e5Hj510nh ho2l9V3FlLfWOmTs9xHCcMFKgZrVPgz5qtD8xPjXp1ppGmXVilhp80kjTyA5bPA4xWVdA+JHRnm9 8EpNHt9bSe5vrFIdQjGBNHKFBYhM/INA8EPLZ0b5WdM1bqC4vRJeOC0uo3OF9CP/AEJ9jXknda0g POR0hD4tdSdAdCPci1/P3xd5cZ2qBzx+wrYPV+uaB5UvBAHTtPklsdMj9G2tlP1PIf6iTnjPJriL xl86mlzeZvpzqrTrdp9B0ST0fqbAmGcFvtXbevQdKebbwYnt9I1ZZbK+USCSJgZIHHO1h3Xmunrq t+pGv/J95uLrx/1fWdD1e0ji1SxT8yssK7UMecYx8iubfxHfBPTujtW0nqLS8xwazK/qxnnY4wSf 2ORXUXlh8peneWy/1nqO91f1b68i9GQyMFijjBznJPeuY/xEfHrp3rPV9D6f0W6j1OHSS7XE0bAq WYAdx8YFdOOyZ7+nDOeU04x8OLIy+K3SsMYLL+eQ8+wyK9lPMzJHa+V/qJpf0LpsY/8A+a80/IB4 XReLvj7G95IV07RUF+wxn1SGACftXa34jXiHD0r4V6doUdysL6jIUkt0P1CMAYyPjmuOPfJa9PLZ +vHF5Q6g6vcySKCqM3bHf716AfhGRQwjrYMALrCMcjnbkYNefV/eetPP6g9Pj+X+3zXYn4YHiMvT 3jDfaBeyD1dZtlihX52jNZ/Ky+eOk/Hn+PKJv8SOWUeKqjb/ACwi5YjjGOa4ivkWB5pFPrpI5Xg4 4+K9K/xOOjg9v0/rdvFtYpJHcSKO/wAZrlfyaeXqDx28Y7ePUInuOmNJxc3cY/S/PCn+9bzvlhpz xmspk6i/DI8Ctf6U0q4631GS407Tr5WWCyk+kXAwfrK+2PausPMJ0fe+IPhLrmnaTeSR3ZiZ1jtn /wCfj/2zj2NYf5p/HPTPAXw0ltLJoxrFzB+WsrRP6IwMZIzxgdjWhvw6/McOp9T1novVr0LcsTd2 v5mXLSEnlVJPJ+1cuLDwxjfJl53ycQdHaBd6V4z6Bb3cfpPHqUaMnsjBxkf5r2d8WPFGz8IOiZOo r+1lvbeIrH6UJwxyPvXIvme8v9j0t40dL9XaZax2mnahfxepBH7TbgWYj7k1035j/DLVPFvwun6e 0eSCO+kkSQG4bC4APvUxnztduSy4YOfrr8UTo6CYxnpLVGYH2mX/AOisD8LPGqw8wnm20bXrPQhp NvbwMhicDex+WI7msGvPw0fFg3EskF7ogLnuZ+3+1bC8q/lw6i8CPHy0tepRDPf3Fs0kRtW3Iyju 39qxnfGszx106+8a+s4ehrjpLUbpmW0Go7JApxkEYH+9LuegIpfGjQ+s7KzwGsJorq5z/qX6ARWn /wAQ3UZtO8LNGltyfVGoblI9iADW0/LD11deIfgd0zreoXKXN7LAUmkGBypIGf7Cu23n+nMv4k8c k930/EoOGQjj9zXF/hdpMekdedGhWzfz6mnqn3A38CuzPxLdTnsrrQPRKArEXGTznJrl3yZ+H+pe NPjzp3qCVrDS3/Mz3Ua5WNlOQGPsT7V7cbJx3t5cZfPb1F8ztnHeeCnUnqgMsVuZOfsK8aeouobW 2Mtr+UEgcZJBxXqH5/8AxJPR/hdHpFtMY7zUZAWUe8Q4NeX8Fj03rGsCO/vTbQHG7HufcV24uuLt y5cp56Y9c9QXWo6akCuY7SM8Qg/7n5qLsw7Tcn6GzU/1nHpem6i8WiAfkU4Vv9VQEMxUrITgjOK8 Wdaxno4s9Nl6l1TStDt8me4k9Jdnc5Pavbzo3QovCjy7WVnY2ZgksdJUtFCuHaXYMn98mvNf8OXw 4tPEXx5Gpajpv5rR9GheVJD+hbgcpk/P2r0t8avMH0v4H2NvL1BIxluORBGu47fkj+1eLiy87X0c sfDWKL8sHUMmv+HB0+7tZ4bm0ldZvzCECQOS3Gf3rgDzE9CJoHmcmWK1NtZvqoaFNuBtyO32rurw T84PQXjT1O3TuhGeDUzG0iRvEFDKAcnNay863Rz3HiF0Z1B+XP5RXWB51HG/fwP3r2YZXHpjq5bd H9XdE2niF4Vjp++m/LW11ZxK0hOAv0itX+Cflc6H8CdVv+pWvLe91QIQLqVxshj9+D7/AHqZ8z2p PpXlu1SWGV4JfykO10baRgA9xXkbrniF1DeSskms3pjbJKCdjx+2e1WY3xcss5jdO0/Pl5ktD6x0 6w6b6b1GPULOGVmup4z9LN22/wBq1V+GQTL5nL5sAKNHmwQPuK5RvdSlvJtkKTXEjnCxKMsxz/vX an4Zvhz1Po/jPe9Q6nod7p2lzaXJHDPcRFUbJHY/2rGWcuMxjGGNuVydL/iBXPoeEOnKO8l1gZ/Y VwT5VNETWfMX09FcKDHFKsqgdsg8V3958OndU6g8LtIj0zT57+SK8LukCFiox3Nec3hv1FdeFHjP 09ql+j2SxXSCdXGCibuc1OTfhNPZh4/b1J84VzJbeCuqlHZC3B2nuK8jeudJibTbKdogJrzdvB57 V7GeM3Tsfi/4PXJ0mRpkuLcXVts/90YyBXlrd+XDrfxO8QrbRtN0y7hhD+m106EJGB+rmuvFZqvk /kY5WzTnj8s1iCIiNnunc03mRQ6FkJdq3x5jfLBeeXm4ggn1Jr2eZBIHb3FaOViWG9tzY7027YTo iRgV2oTyucfFZp5Z/CeLxu8dNC6SupXhtbmQtcSEZ+hRnGPvWHyna2R2C4z81u/yF9Q2mg+anpe5 1S5itLeQPEs0rBVBK4AJ+54rjya129PH1l09atZsbfwM8J2tujtEDfkkWGC3iQZJ7b2+a1f4A+N3 ib1P1rNpfWuhJHp0+Vt7mCH09hHu3HNbg8X+vNR8Oujp9bsNJXWYoTmWHJyAffjuK5hs/P5reoXy 2th4erd3BOFSFyWP7Vjc106b/tFfiF+DWk29pa9TadaxWlxcBhdCNQBIR2I+DWYfhi2K2Pl/vUT+ rV5SSe54WtBeanzS6p4jaPDo2q9MSdOPBklZWO5yfse1dE/hqLu8A7lic79TlYH+wr1Zfxm3PGTu wfzeeaTU/A3VLSw6agtzqLL6t0biMMHXH0gff71zz4teePpbxm8FptJ1K1j/AOKZIzH+X2cK/wDq U+1Yr+ID1Z/F/EKeIhRPzGWU8Kq9q4pnuobeJ2X6jjCvjkHNTn4v1TblxZfsy09bPwwtNNv4FTXC llWW6ddhP0gg84rIfNn5k9U8BNQtF0CK3LXA33frpuLN7Y/tTT8M20Nt5XtImLFmnu5Sf81zV+I1 1G3/ANYlzau7ExsEjUc4+muHDh++Ov5FnFtmnU/mx6e81vS9l0R/wzKvUl66xJM7AhTn6mX7fauv uk+kunPLd4QLBYW8Vtb2FtvlkVArzyYz9RxzzxzXkt5MNdg0XzRdFXOpSJDAlw6tI2AOVwP969Y/ Myk0/gxrJto2mc7WAj5yO+axMJOS8dWZeWEyjX3l7821r4wdY6n0zq0cVpchd1qCOJgTgpj34rVH nr8vOl6bYL1To9rDbqUcTwqgxu+RWu/Ir0HqOu+PV3rIAitdLT15C/8AUCcYFdQeezWYNO8J2R3H rS52LnkiunB1ncdHJjNRgf4WWnpp/gVrICBXOsyAuByeBWzvMl4+2vgBaRSabaRT6ncnfcM6jcF9 sn3+1YJ+GYQ/gbqrAYU6xKR/tWkPxHepRddTy2uRFLEiKAD3Ax3rrx8X7LXPPOcemxOvPNz4beNH hcYrq5iTXvy7CW0kXlG/evMLrKOF+orqS3RVjDnaF9xQ50JvGmf6fcFOP80wjdVndyxYk/1HtXaY zjmnnyvndlPCzRrtAG7gn4FSfSXSV94idY6N05YEm5u51h/ljkr/APmpnsjUMSxwVzmtveSR44PN T0P+YwIPzGQzftxXz/ysrjx7j2/jSXPt60eCfg50l5aPCq2istNitp7e39S6uXAM0shGSC33NA8P fM70r4sdUXnSctrJp92VKLHcOGExzyowKzPxtikm8M9VEKGRgu7A+2a4A8rfTera15m4bu2ikZLO UzzMBkInbJrlrx45k6T5ZWVtzzleXHRbO1s9Z022Ecby5eHGQCP/ABXTnhTp2lWPhF05PPY2cNvF YK7AQqFX+2KxHzZXUMXRdrHKeZJCFB9zxU/YSLb+B2kEjIFkv0k9+DXfOeUnThvx2juhPHrp3rLr aXpe10g202XCy/TscL9gK1x5t/Bzp2+6eutSa0RJ2UvkDGDWpPLZq4vfM3FAkYGwzksP2NdHeayT b0lIrcxm3c7fbPNevg45jnMa+fzZefHa8cep4k0zUriG2P0byv781Hb3MO8YJX7VJdasJOoZGHcS EcD70xRG9BgozkivZ+VhOPLUcPw7csezro7RoerOv9A0xBk3M6LIuO/IzXuroWh2vQHhpY6do8It re0tUSNf9JIGT/mvEPwZ1W10Xxh6Vvr0rFFDfKGJ+MivcnVL6LVOhTc2bfmIZLdXVouQRgc1+b4+ /wAm7fos548ONjyy82nUV3qPWtzA1y8rIxZpN3JOa003it1g1nDZ3mu3NzYIdkcG87VHsMVszzTx tB1tNOo2pISfUxwRmtJWlrc3txCv5SQQs64kK4Br7HPqYTxfG4LleW2+ns14OW5by1aFsQvLcaT6 hUDlmINck9QeHPVPVXjLoy9P6fPAqyozykFF+k5Oc12Z4QX8HTvgd0tcXGfRg05MhB34+K1r1553 ej+iLr0jZzNPkja6bTXm4bdV78vbaviwwtPD+KO6cOyyRI7dst2OKnrlVHQoA4jFouOfbArz/wCr vN3d+KfiPoOlRzqumXV7GiWsZ/Tk+9d/61F6HQ80I4K2qqP9qzjl48slMu8Hnn1WguPMn0smCwW/ jOf/AMau+/FSIP02ckgb+R7Hj/euGbKw/M+aHQYZE3CGYMc/O6u6vE/b/wAO4c4Xf3/tXaXf5W44 a/wvKrzBdVa5034hTwaXq17YwyZEkMMpVWH3A716a+Dt1I/l46ZuHOZDpCsxPzivLHzJ3q3PilNt bG19rY5zXqR4VlIfLl05uO1BpCf9q43KX8jKO2Es444e87dzI8NmYyTNE6yR/Y960UfM14j3Fjb2 Nzrk0VkkYjMNsxRHX4IrcPnK1NPz9uiOPoTn9jXOvhR4ca940dYWPTehW8kplcLNKFysaZ5Y/A+9 fR/Pyn6sY8H4sv7bfp0v5Euo+q+rvG+0ntJJ/wCCQKxvfSJEZGDt3Cu/vFr8k2nxJdhdwVmUn2Az WL+EfhN0t5X/AA9FvAYReempubpsLJcuP6R8gVz35hvMfbKLhkO2eRSqRhv0Cvmfgy43eT6P5Ocs c0dY9G6b4o+YXS9AYsbO9vTFKkPBZc8133Z+S7ws6P0Nv4Z03/6hUGGlfcc/PNeVn/1o6l0x1zZ9 U6TIP4pZ3Hrx7vY5/wDNdk6B+IV1v1ZoK2+peHnoKVAe5iZjv++K9vPl588keThx1xVgnnL8JdG6 Q0eKW0gS3mc7lKYAz8Vxpvd442KHjjPzW9/MF42ap4myPHfWb2cEDfy42yDWjpW/5Sr+gDNd+THW Oniw/wDZpeCX05lf4+aC0N1qPUFpaRrhbyVId3xk4oyxmQqoOFJ5NS3TSIeuumVZyY1v4hkf/L3r 5fNlcMX1+CTK9vZHwE8N4vA3wPtrKAhrgWv5h+MZk25FaQs+vuodC68ttXQXkZmucy+sG9Iqx7V1 Z1LcQ2PSlrNIC9pEImkA90ArWnW3jJ0Z1RYQ6DZwG5vZJFWJZIgvpc9x/wDcrz8Nl271kHj5p1vr Xh0NRCLNLHtZP7/FH8L+mLXwv8LZLy1i9aaaM3jjGCSw4XPwKdeMKQ2vhqsBIRN0S7Qece9S+pND beFjNy0CWSnjvjivRP5duWvty9YeJPUGhddW2r+pdRrPcYuElRvSWMn4P2roPxl0636m6Jh1G2Pq xpiVX9ilYt1X4t9F9RaBaaNbr6147xIsTwBcH3OaznxHRNP8MpIYhgCEIgI+1dOKWck0mfePbzx8 eOhLbqTXNEt1hGy6uY4mZR2BbBrunWdK0rwM8FotF09QkSQiAZ/UxI5Ncq6tBb3nXnSsFw4UG6Ri R8hq6b80RH/DNsp5UjAH3rH8+awnxxca+MuuroPS7RQSn17wn355rqXyY+HMPhb4HvrjKst1qqHU JAVwy4B+nNca+YZvQvunYXBC+pFu/uea9HunhYWPg9pSxjGmixQNjvs2813/ADJrHGMcN8sq510/ xn13TfEN9TNxcS2s9xg2jkmNUJ7D9q3h4/aTb9UeGZ1KJj6yBWiKnAOfmozWrzw7vOiwmniza7+l LdOPVD5HJrK/EAR23hJIk0YA9FAFPGDjiuF6k09OXdQnl90nSdB8NDdaVaLc3gZ2nKqPUeT3Xd3r TGk+IXVw8V45obi6kEl16T2r5aNUJwRj7CtveA/S9/0V0hPq2qajLBZSFp/yhA9ML/rz3yav0r40 eH171UbW3tBY6lK5RJjHw5/esZzpJqXplfjQ2nwdGTT3oUFSPTb3zz2+f2rgTxtjszpEWqKqG5gm EiH9jkV175jOldQmiGrNcPdaeq7RCTgRNz2A7iuHPHjT76TRRLCSIQDla9nj5cLzXLxyd6eFvUg8 XvAOzvLxQ0wtvqEfALKOK5x1nRPzb6rpUiYidDn/AKa355OrF7Xy56I0i49aFm59xzWqdfMUfVmr soG1d3b3p+H/ADsObvHbzf6n6Ia68VbXp+2jLm5uhACB/qavYfoTpGx8B/Aa00iNTA0dsC5T6SHI 5NecvR+ix6x5ntBLbQDfo2D9m4r0i8wd4bfp94Bynp4xXhzvnyuuEuOPblPq69vLuC81dborCm4/ Uc8+1bI8kXmYbrma+6P12/je9tSfyZbhnXOMVpnr+X8n4Y35V9rNknJxXN/l+0fqbqrxh02PpGKZ tQSQO0seQI+eS3wK9n5uMxkyjjhnblqvSjq7wDfqLxegmitRHppdbiW4YZBIOcVsLxv8RovDzpOS 2sUH5uSIqqR4HpJjGcVsC0W9g0SJX2yXy2yhiexkC8n/ADXI3ivcXk812dQDLdnKMHNeb8bH9k3X bkz02l5WdSluej9TvZpDJucylmPc96131x5q+rNC167gs2sVtUkKxo8QZsfvWdeVDT4oPC2/ubyQ G0mlZXjPAAH3o1w/ghNqbpcafafmQxBMgPfP/wAqutcmkneLnDrrz1dZwg6abG2EU67JGji5I+3x XYfl71t9f8IunL58JLNEWZQMYOTxWh/HfS/CNenB/A4rGDV3dVURd8Z+5rePSCW/S3gvpkiOIkht w+9eOcGnJ121hjftinmJ6Vt7q/tL3ZsYYZnHcnNbHgkZ/DFTn18W2CfkYqD6oNv4heHUGpWk6yvA Azs3HPYg1MSWX8J8L/QjcyYt+GP3Fd8PllimXUcEdV6da2PWf8TtUMFxFNvR1OCOa7W03VdP8WPC aG+tmJWODY2ecuBg/wC9cZ9aRC31eZZBxuJ/3NdS+Uu2a78CirZxJPMBmun5eMx5ppOC+WHbmjXt Kj0nXpLdoso7nn4PzXI/mm6XOmdQrebMGT3x7V274naesHVjIP0tJ/vmuZPNvbK9rBPtwCuwA9+K 92OMuG3l5vjk5Viy4BAyABzTqFEMo3j+X75pNjp8gtwfUwGU4FHvJGksFMKBiF2sTxzXzeS629vF 3JtsTyweGB8U/GjStMSH1/Sf8wyMNylVPYivcrpq3tLfRrLTo4oohFbqhgRcBVAA7fFedn4XHgyY ri86+ujgopgi+MNnNdidOeIUMvjbf2k026GaIWtuV/TkHNfC4crny93p7+aS4yT6jVPjp0BY6d1B cyQxEI25gGOf7VmnlWstKbpPVLwaPahoJCDL6SlmPxnFOfMtpEscSTwxk7o2wfnjmleU2wmHhbqq JgzS3T43ds4r7OerZp8yTvYOsea7Sum9Z/h+o9OSRp6mz1FZeB89qzrqjo3pTxJ6W/j0aGWCW2Ms MkR2qRj4rRfWPld6x6w6mNxItnBavNlnEuSF9ziugbu20vw28NU0RL+Mi0tjEvqsA7+/atYb21da cv6N40weEesTadc9KWmpWDttEiwrvH98V1X07r2j6v0Pa9QnSIrO3mi9UQGNSV+3ArgDxIv/AM7r 4jVW2NKpzjj9Vd1acRZeC9gEAVVtVGMce9cM5P2OmM+PTXniB499LyWb6e9gbXJIY7Rk/tgVpfw+ 8BNP8c+prrVdQnl/glg+ZFY/8zPYVhXiQ4l1aRz9OJMBcfeuz/BjpmPpfwij2qEkuIDI7HuSR716 +fUwx0xMd3tg2vdUeFvgoIdOs+lLHUzGo3ywQJlf3JU1fqPV/DTxT6VS/sL2HTLhx9MaAIV+RwK0 N4s2iS6rMnqEPKTk/wB60r4nzS9NdMyvBM2VHJUlcmt48HhJlXHLlnqM68RrvRul7q4iRU1JNpUM zBs/euVvFKy0TU7B721SO21HfgwpwMfOKwa+611d7lriTUZSpOCpbPHxTC71X+IyCRkkcEcsM1vP PG+nDDG72lemupp9NuxbwR/ScZxwf81N9SdU/wARsxFj1DnDf1N+wrDrRgtzFDBlrydTsA757V6I eUnyWdN2vS0PW3XBMtwy+sttKPoQezV8nk55hn4vs4cW8Jk4Q0LR+pdQdItJ0rUpI2HYxsFqYXwY 6zvGe4urE2yLzulYc16p2nmD6Q6f1uLRo+mLBNLjb0hcxxKW2/PanXi94AdPdY6Edc0yWSGG4X8w qqMLg9uK7cdvJ282fVePOu9G6jo90RqKzcfoWH6s/wBhTO0sr6XhLC7kBONioQa9LvLh4R6BdeKN xputaPFfhVZo5Jfq24+1dGdZ+F/QnQk51w9M2LmNciEqAD/ar3vSSa9vFdPD3qOeAzWulXOGP/Kd Tk1V70J1LpcIll06S3UDiMnJr1yuetPDPq3TXt00q20W89iFAwa1t4U+HfTPWfjBd2lzBDrFt6ZY BjwD+1eiYXW6xuW6jzBGm6xJOfUtZQq+4jJp9H0Tq9++bS3uODllKEZH2+K9oupPCTw/6FQXU/TF kVUZ2kDBrCdW6g8KNd0e4Fto1rpNxjbwoBb9qxjjcnW6jyVuulNasgzyWptbdezS87qjre2u5lbf aSF84zFESG/xXq14b+UnQepJn6h6gK3ukbiY7R+FK/Oa2J0/p3ghZa6ugWnTNnBcxnashhyuf/lW LuVrx628arXonX5WeSz0+eUNxgoVpjqVheaXk3n/AKWQf0v816/+Mnl3tp55LnS3js7eX+YBEgAx WovBny9dG9YdY3ml9TaLHq6qfpdzgg10suM24W3bzIine9Yfql+Qi0/XQNUvJAYrafCjKhVPNeyG oeVrwj6DuWvZ+k7W1s4xkbeWakP0r4Salpjf8PWFrZzkY2zAA/70xxuSW+M7ePUHTWuXtu/qabNa onJMink0wkR7VxHNG6t2zXoH4t9CLZidofTktAcHYoGK5s6yh0T8q9u8YjuRwsir/vXb9NxYx5pl WlM7mCqefY1d2t7eMAzBnPL5Paq1NIrfUjaBJJbiQHaEHeuwfK/5DLPrLSLbqjrxyNOf60sdxG5c Z5rycnLOO6e3DjuXbjyHVzdB47SONkTvuwc/tTpILm4WNoYHV+/piI4/zXrR0v5Z/LndX38K07QU GoqMD1SQM/vWM+LPlct9GRI9KtLSyti2AIAG+n961hn5Jlj4vLy7aeEBbm1eLJ9nxQZbxkmKQkhl 4Ksc16qeH/kT8OOqNGN9rUf5y7HMjSEqF/bFZNpflG8ALW+XTxpZk1AcDdnBNYvJqudsjyLeS6aB XVjIf6lSI0C71OO0j3S2U24d2INesfW/lm0Hp1pU0rSLRYAPo4BI/wBq5o8R/CO000Ol5ZoI3JH0 qOK9XHh5x58+eYe3G63UDxK6kpvGQDVrmZLSEzMMYGB9zWwetvDK10XMlo5eFjwD/TWGaN0w+u69 YaSZDN+YnWNYx/Tk1z5r+qbrpwZzm9Jbwu8EurfGXWYrfp2zlFuWBnvGB2R//TXZHRn4WLX8EU+t dbWskjDmMYUqfgfFdG+DvQVn4UeGNpb6ZaRwypGDLJtwzNgVrzxA6gvxdSXv5uWKRTlFRyAP7V5O GZc+W493LJx4sF6s/D36d6Is3f8A9RqzDjercCl9Kfh0xeImmi8i1ODQYl42yrl/80jUfMx1Zbwr ptzqDzRN9KhlHb7muk+heq5b/wAK0vJXZdyY+lsZ4+a9HNP19V5sNZemlrH8KjSbZWaXq1L4gcKt YV1X5OLHw41JBDYzXezkzAHDVmr+Ieq6H1RDJpd9KrGTGz1CxPPxXRWsdZ6tqvS1kb2NZC6jcZEG a8+U6ax9sd8Hug3sOlNNhU+iyIdwPA/xW2LKyl05VUsJCah9As/VsoQ/0ccY4rJre32LtVhx81ji x1XXLI8SQzLgqBj2FCmPJ4paArjn+9IuWAVt3GB3r6OLz5IBImudcIBz8itdeJYMVzNzx2NbEsVS 71GbDlEx3rVniEzLLcKzFvqOCa9nDN183nuo5561cKk2Tzk81zP4gMpWZiRuIIzXRHXVxsinzycm uauuxvtZWPGTkV6s5qPmY5byaluABIc8HOBn4pSAlMEUOcsz5cZAPFKQnAr52b7XFOuyjwcEURzs 5X37ihk8HnJpJlZcZ75rk7DRxbQeNpJ4q4yjc8CryyJJt3HGBxSJf5gRl7fNA4VXkI2gY+9SHTkz WupDaA8pzgH3qPhDuhAbbxxUjpFuxu0kUjeg7/Fbx7YunpSrbOM5/f3q8q+kFxx+9C2sB8Ee9XVG Iy7bzX0njgizFmOTz96rfj9X1EdqG6Fm5FU6EEc9qIu8hZgDx9xSlckcY+1WjG4Dil7Qq8c0Ip1I +ojNWXkbv9viqOSeT/aqI2dvc0XS6gn7Z+aUfq+1WJ3EYqwIHPvRIuHwec5FFjuWjGSQWHzQ88ds k+9IIKnt3+KCXttevooisc21T8VHXdxPdbmkfJz3ofqY+nkiqIMhAyVHzS9k6WD7eO7D5qhcEHnF Uz73IUCrGPcOf1fFBTNvxtA470Ij1M8ZH2qniLY9M4+fvV7aTMhjHBrQRJER+ntVo4nZMqu9h7Ud 2A4HerrIIeQOcVRY2jN9TsxJ7A+1Rl0qrkYyKfXGqIsZU8saijJkt/VnkfagCHjXlhtNWlnyhCgf +aX6kQ7pn9qHOFLZAxWiAxJ7+xFW3E8sc470TZwMNtpLJsbB9v8AejQTTgkqsRx81RT1AAe1Lkck 5AwfikKxbPFFWMR+SMGrbMgd93wKKMyEJ8jvQnJD7VOCON1ZFHa8LNn6wOKswdQoBHI5paIsKlG+ r4NICfVk96BIbO7jBFIjJZtwHGfii5BbIGP/ADSBuB4fA/04oEsu5iAOBV0UcgjOe9Vnge9AeZ0O QOSaAjDZKNh4HvSZ71uRuw2aCblo1APIPv702llyxGcr96Bvqgkmt3VZjluwzWLSRyQhkYb2bgk+ 1ZRcNi1dSMt/TUBcABf1bnHf7VyrXpMdJ4ikWHP1Dkmtu9KsVuIcf6gP3rTvS8n/AKhXxg5xmtu9 Oy+hPCwHcg4+K8XJ3Xs4J8pt194YNnppUB5BPFc5dNqbHxw1lHGxhdrwa6D8K51l0nKHIIBP71zH 1t1BF015htba4kESrLG554xjNeOy7en+OdraPnUG7w105x2S/Qn/ABWPeVu9iOrohYCRozgH34ra PWeg6T49eHf5OwvI53XEiNkHa/3rHfBbwPu/Di6bUNbuYglup9MK42qMckms32xhlMZWmPPhEX8R ukyOQ1i64H/zNR/gndra63bp6oIJXufih+YzV7fxy8XLSz6duVmj0qEwesD9LPnPes48O/Lb1fo0 tleSTW/p5DsPUGce9Yy2cVmruprzk3MU/TmgzY+l8MDj2qJ8tl7bxazpiKygux4/tWxfMJ4P654k 9LadY6N6DXNtHtYTuFGf3rn/AKP6Y6p8FurrC06lSGyfcDDPFJuQ/wD43atY+kl+nR/jJ1j090V1 j0/f9RWq3NsYJVRnUEIc98Go3obrjSesPE57/QLcRWYtBG+1Qoc7u+BR/Ffwzh8dOhrCazu4n1K2 QmGRWBVj8Gmngn4ev4PaNfah1O0VrcqhLShh6aqOe/8AalyJ05e83/W8+ieYe9tosKi28LMw7/pq /h15208MreaO70aXUlZMKy53j7ZrHfEUxeMXivqfUUUqGCST0kkJ4KqccVv7wE8vvRmvCZtY0yHV niQMCx+kH44rpvoxkm7XBvmi8wN15kfEK21WHT/4RZ2ceyKOQfzCfufitTpMI4wuR6mPqPua65/E k8G+mvD3Xuk7npvTxpL3vqGYxnhsD4rkMWqpbQPv3tKu7cK7Y+nCa3Ujph/+21rKpA3ELiutOi2S 9061jkwgjUbT81yDYwOt2sm/agx9OfeumOh9Te46dhxIpmiwoGeTXn5Z301MtWO8PL61rFHEkGMl AGI7k0fX7/ojQ/FXU5urBZJLMqejJdoGXGPgg5rS/gB1le6brEKTSC3DsFzJwAPnms580PhNqnWO oab1HoqDUERQskUWG5/81ie3fe7ttLwkvbHUNS1iXRDGdHaYmP0hhD+wrGfAArF1T1SikfVcuSB/ 8jUj4dWzeE3hNeajq5WykjhMzJJxtOO2K055buvJtU64urzeIre7mdiXOFYE8VrKSJe7ZG0pk8P7 PxD6ik6oFit68xKrepuyPkVLeDl1a3Fj1DBppU6WpkMGwYXBz2rWvmW8Kta1jq6z6i0a2/PWzgJI kf1Et/8ARWwulzB4KeDN5qeuulq6xM7qSF2kjgVN6qWdOIrK0Sz641eNu63Tce36q7K60gZvK5r0 cZ+s6eOPfutcSaP1ILzqK51QASQXczSAjkd67m6IZPEnwl1TSI2UT3NoIghbsccVM7vTGG7K4l8N bZDp9v62Cfcn5rvvwMS3h6XSKFgf5YYgV5+RWl30d1Tq3Td//KvNMn2Ee5B7V175XurnuA1mx3B8 IFY8jFTGfbXH/CxIaZ4ddC6rqPUFxqs8Z1KF2YlnCtH/APTWUdIyfxHwl121LGS1iWSGF290A4rS Hj94Z9Qad4p/xGxtri40zUWURJbEkBsc78dhn5rdmrXNr4X+B8zai4hlkttpU/8A4QjtXTGdaLJM N7a58r2n6vDrV41lIq6YkjrOrjI+2K2J1nqHhZbdT+nrMlqusxOGdYx9W7/qqF8p15b3fTOoFCDO 8gdsfB7VofxY6I1nR/GDW7qSyurmG4uN8E6xlgwpJFx+TPvOpovWXUXhxY3HTs27piP+ZcQW+d+z jBf5H2rm7oO2S70GzG7/AJQyB84//NXfXTsUmj+Dd0+uskcYsZCyTAYUFOM5rz96DcrpCOnC/mZB n2I3/wD0UkcsZ45O2fLVF+b0DUYZeUkTYQfgjt/vXD3XPS1t035lOpNPtI1jtFuFfYowMkkmu6fL XFLB07eXDoVQg7T84rz717rU9UeYHXNVAykl4Y2IPbaxFdI5/k+43f0pZrJ1jbsygjAAPx2rcfnV MsPl0RoMhA8aMRxweK1BoMiwa/C6yBQQCpzXQ3j901eeI/ls1C0s09W59JJxt54TkkUneW2dW8Vj g/wtW6026hWIEx4AKmupvD/XZunLy3ktQY3JBGPfPtXPvhJo1w1kuoXKY9LKZ+TnFdeeX7op7121 bUoCYUyYhIOD8Uz7vS/j4XHHdbtkv8aEda/JepeJal1jC/WRjO3P7+1cINfXXXHWes6nq0si3bTs EWc5aMZ/QPsPiuk9b8wMMHilBotvsbTLeT05nU92/wBX9visR8yfhLHpyw9adN230u2+9RO20jhw KxJqumWN6bb8JenrSTw6ex3b4LqNo5drc4IIOP8AJrVV75L/AAkmv5ZP4ld28xbDgXqjn/FZN4Ha lNqHhdrJ3yZW2f0z7g7T2rz76g6k1K26mvYrzUL0OLhhgTMMDNc9GW5fTsPqnwo6Y8KxavoevPfy SSBfyssoc4/tXQ+o30mleGQvIJNjwWiurf4rgTpK/tY5be4jumkY4JEku8/2zXct3cHUvA6do+Xb Tu1at7df+LDPHHQv+JNB6Y6psJI3XT3R55Ixy2QP/NY15zJxqnlzsp0xte6hYY+OazXwYmg6v8Pp OnrpiAnZu5PzUD5uOnPyXl4vLQP6gs5VeMkY4Ga1K5Zfxcu9Fxsem9KmRT6kTfS1dbnp6PxB8v2p 6RdsX9aEqT3OccVyV0FeK3SmlFOA2B9ia7C6M1WLQvBjWtRuuIbSBp3/ALLn/wAVLNu1t/VHjZdW 3/DnUmr6YsZItbqS3GfYAnFDT/lH96e6tq8eudUa/qMUZ9O6vZZ48D2JJpoAEhGfqr34dSPlZezC /ciFHDbSzba6D8uNn6CvfFMYUhSR71oW305rrUraIncrPv2/Ga7k8Degra26VtxcpsRyMHFebnvb 1cGPbqHyqaVMNGvdUlyTM2wk/Ip/4QdTy9adSdd2V5cKx9Q2yKT/AE4I4+azXovpC00DoBrCGb8j FcRFmnDY2ZHfNYV0d4QaF0l1MNVseskkuC+8xerHh/nP1Vy3qPZnZbXKV10S3h/1rrfTSAzCC8Lq x7YJzxXVPUfTWpdR+WjUdJ0y3e6v7i2CxQofqble1Yh5nuj06f1K263tWWSOaRYZlX3J7H71sq18 S4ulvAmXqy3svzK2Ntv/AC+du4jA7/3rGi2eGnNvg94UdVxazpVje6Xc2c0MgZ5GPAQHkmsv/EKv 4tL8Oek7PcrzS6htXJ+rAXvitQa7+KBrkxuLfS+kLOK4XKJcPLnafY4rlnqrxQ6p8V+tV1bqnUnl f1d8cQb+Wv2A7Vdac7nvUdp+C8MT3XTUsgLb5Y8fYis+/EYg/MeEWjLjP/20Ttx7Gtb+EGsQG86a lVwUWaJCg7DJ71sv8RWUR+Demyg/p1FGyP8A41ccenflveLTPgt01aWulaV/KAaeREbPvmukvNnq F90H5ddSbSrp7WSGIRkxnaSuOR+1c1+CnUEV303pkocH0pIz+33rp3zS6Y/Wvln6ga0zdSiyMyhB ksQPir96rjnlvHp5adGdeXvT2sQ6k11ODJ9RlDnCE1jfi71Br3XWvG/1bV31Wzh+mBGJIQVE217P FpwRV2tEArh+4I7jFMrvrQacrw3Nu8gm5Rym0f2+1ejCYz7fPlsxMPWaWMh1wR2qNkuRbTbihlYn C49jT8vHJ/NUkB/6fYUzhfdqdtFKgYNMv0j4zXZiN0eCvl7uutgL66EpikcEFuSfsK9CPDnyn+Gn hX0YvUHWljbLGFBcXwBVM9gfnNYb5ZNJ08aXoi4VRuGf34rqXxj6H6c656WjseotSGm2QK4kaQKD +4Pevn23yr6kmsY0b/8AVX4AeYCK/wCm7Dpqx0+ZoyUvbRFjcnt9JriHqXyk33gx45w9Mau4vNGv CzWd2V+l07gfuB3r0O6U8IPDHoe8tLyy6osYhAwb/wC/Yxux7H6q1N5v+vOmuqevfD210PVrXU7+ zklMxtZA+xSAACR/euVt0z4zymmSeCnlM8NNd6HvF1Xpy2vJi+wz7AHAx7HHFRsPgd4AeFUc+n9W x2KSySN6X5nBdVPYdq3P5edSMuiXycBYjuC/PFeY/nW60l6j8xmtwpPItpCiqsIbjdnmunHN6dOW zHLVbp8XfKp4eJq2m690HqQttMuplWa1kkDrJn/SB2reHhh5KvDTqboi4Os6U93qDMVMkLBWUe23 jvXCXl51PULrrqytJrmSSxjcFI2kLKDmvWTwSkA0q5QfpB3f9qxluZ+LFwx8fJoOHyqeA3QWnpad WSxQTzsfSW7kAYD2GADWkPFfyO9Op1ZZ6r0DctL01ORviMgchj32ke32rVfnF66u9c8zvUyJczfk IWRIoyx2qQPYe2a6T8pEUlzZaRDPcyy28k24pI5YZ4q3K4OeMmbOujfIX4cdN9Kte9YxRyMUVzKj bBED8nBzUR1H+H74Q+JHT97cdC6lPZ6sqFYLmOffEG9ty4HFT/4hPUV/oPh9o8NnLLDBNLtlZCRw O2abeTfXJlt7TbI7JcqEZT7++a159xfDz3HBmj+DuraJ4ry9EdSxCCeKXYGZeHH+r9jXcHSPkJ8N OpulZLi+hvv4hEuC1rMEGcZ7Yph5x9GtdI8fOiNYhhSO6vMxySjjcFAxXTngvdK/TN1MW3bZMsR/ 8anJnlcpHPjxklrm+x8kPg9Z6Mp6pvJ7SaSQxx4uRGSM8ZGDzXMvmn8s1n4HXceq9L38mpdPSYX/ ANRIHZWPbmobzOeJGrav42dQRfxWeGG3lPowxudp54wK1/1H4ldU9W6OmiarqD3WnRsHCOecjtzX r48b9vHnlMvTHoBviDlsse9U9wkaE5J+wrJek7nR7e7jOqwepZnhsHG0/NY51F+RXqe+OkZk0/Km EN7D3r2W6jzydsm8POgdS651hLOzikJnOzcvOK7Z6C/Df6Zm6fF31heTwXLLuxDIF2/uah/In03Z W5srt4FkluJuS4zjgdq2J+If4i6r0R0j03Z6ddPbQ6hcOs3pnBIXGOa+Jnnc7ZH1scJjjGr/ABW/ DVspOnZtR8OOoZrq8tgXFlO+8TY/pU+xrnDwW8AbvxM61m6Y1qOTTryCQxTg8GMg4IrvTyUdaz6x pMunyzPKGh9YF23HORUT1rYWXSfm4tm063S2F5BHJMiDAZj3apjyXTOeHcYNcfhcaRDfRyjqn07E DDiQEP8A2b2rHPEL8LeZdInvOlOq1kuYVaRba4BYS49s/Nbx8/HiXq3RPhtpselym3W+nUPKhw37 Zp/5J9Z1HVOmbyO8upLmIRq6iVyzAk88mt/s707eG8dvIq4iu9H1m80zUYil3bzGKRCMHIOM/tTg BkJB5wa3T58dBsunvNLrK2NssMTIHKLwMkAk1pG3bepYnJPNfSwvxeWzQhG4MhBI3Bq6r8lfg7be IXVcVxdxq9pHIJPqXIrlOPc3qBT9QcHH2r0T/D8MCyMEAUtyB2zXg/K3cY9nD91vnzReOsXlr8N7 NtKso2v7vNvZKy4iQgDJIH7+1co+E/nv6m0LXp7/AKmhn1azkTH5dW4Qn4rPfxUS6dIdDMM+n+dk 3Y9/pFcKW8ghn/np9BUOmT2rfHjrHtiXeWq7p8BPE2z8UfMVcdUWWlJo8MyhfQUAZPyfua2x5zPG TqDwu0zSINDkS3F7l5Jf68g9h9q5l8kQLddW/bbuBAHc12z49+B+heMWmWa61qh0lbXhLj6QOfuS K88y8nfPUsYd5V/GS98SNFmsNdkW5uR2Zhnd8qc+1OekOl7Dp3zP6u2n20VlDcWZZoLdAibtvJwB jmpPwt6G6D8vui3k3/E1lcsF3SXNxPGHCj2Cg1hXg74maZ4qeZDWdW0SRp9JFo0ccjLtLEDBOK3j ue3LK7vTU34l8stxrPSlnnMS/wAwA9s5rdHkVnjfwwnhjjWMRSLkgcnv71p/8SyP09T6TnHB3bf9 62d5CZv/ANx9Yi5wssZ5/Y10vpjbX3XfiH0n0B5utU1HrZIZrFYCkDXKbhGR2IBpn4ifiRLPqcGm +H+kqscTlZbq+TMbr7bAO1af/EStGsvMHakgbLi134I4IrVHhJ4e6l1/1tZ6Zpdq1w0rr9KLwg9z x8Vyy6j0YYzPqvUjofVNJ8zHg80HUGnW9088ZgukmhDKkpH60B7Yrx+8cPDIeD/i1rHTDuMW07yQ SL/oJ+mvZSzOgeXLwjkudRuIbO3sLf1J5iQPVkA7D5PtXjD4m9dT+K3ilrfVEsxlS6uX9HeOVjzx n4rth/G15c/5TTYvhL5POuPHfRp7/QpLa2tLRtvrTLyxP3961j4veCvWPl86nXT+srU2huOYLgMC ky/IxXpV5C/E7pjRfCebStS1iy0y8jl3FJpgmRjvk1zB+Kf4i9M9c9d9P2PT+px61c2kCvP+WYPF GM/6hxmpx25R25PfTkBNTF1dMuNoHelyPuXaSCuajllWS4MiD6CByPejiUsv0/716K5SiXKwSAJE jRx8bt57muh/Jb4K2/ix4q2dve22/S7bEk6MMgr8Vzd6TXPqxsSPqGMV6UfhhaZFDqerThMyG0wz EdzkV5eabj2cfwlyb/8AHbx26W8ofRun6NpFirXty5FtZx42xDj63+xo0Wl9G+d/wSP8WsIpLoxl PVCgPbzYOCrd8fasf8fvLfpnmK8XxY6rqT6dBY2kbqYwC7ZHsPesm8tvQcfgp1JrvQ1pfHUrEMLh JpABIDjHIHauc31Hns288/AXyqvqXmRl6J1pHudJ0+9kS4YDkovbP716IeLvjB0Z5POitL0ux0xY 2uFZbO0gAG7Hdj81E+EfT9l/9k51zdRRhJIohISB3LHk008ynl/sfMn4naBo2oalLpVtpdrJIJrd Qzlj7YJHFTx62akqav8ApDofzueDMNzqunqWkDItxGFEsUoHs2M457V489beHeoeGPiJrXR99C0d xZzsFMg+v0wfp/2r2a8vfhifA/Vr/oe21ebVtMS1W+Rp4wrK5YA9q86/xB9OA84GrvEoUvZW5b2z 9Az/AOav7LhjuuvFxy8sm22/w1/BX+La1ddZ3kcb29qdsSOmfr45FRf4qnjJqesdU2HhZZ7I9OjR Lq4ZeTISAcf2rqP8PfQRo3gZHJgbrq5aT+2BXmJ5ieorvrLzBdV3mo3LS3NreyQRMf8AQDgCtcXy nnTnx3yXCMj8qvgavjX4j6bpV0jyaPHg3WwcqoIzj4r0e661vwj8onSFjpU+iQXqyOdtu6I85HyW K9q0h+GPoNvb6l1BfoMyNHszj7itleY/y0SeZPxrSxbU30qy02zillnjGWXP+ke9SbttiZ2yTFI9 d+A3hd5u/Bs61pfT8FlqT2zyWbWSpDLHMASqOQOea4M8sflUufEXxpuOkOqA8FrpE7LqManDjB/S DXpH5X+iV8IZepOhzey6ktncI8N1IuC6Ffce1cv2HXdx4X+dfW5La0kuLe+u2E8EK/U4J9vk1jxt sphlrboPxN1Hwa8qHTGj2F90tY3BuAUtoDAjzygdyWK8006g8BvC/wA3HhQb/SdDtdAvH3flb21i WOSKUDgPtH1D7VknmE8sOg+Zy00TVbzVLrQ57JCY5BGM4J5DAkYqd6U6Wt/LH4I6mlgbjqX+GxPd LGiZknbj6QB+1dcdzLTlfW3ih1j0dq/ht4nXugauzvd6XcENI/6mAP0n+9evXk78QY/HTwHm0zXI 4p1t0OnSQtgl4tuMsK8l+vfEDUPEfr/qXqHUIAtzdzljEww0YDcKf2rtP8MjqC5HXep2QnMlvPaF mjzgK3zit8m/Pcd+OefDtx95l/AzUfBHxx1/piSVDbyOb219PhRC5yo/xWt1AmKQQrmVyBuPOK70 /Fv8PF0rqTpzraOYiS/As3UZ4CAVwro8R9QbB9JZSSe4X5rtZrHbnxZbunbn4cPl9j6n6xfqrV7I Xlhp3EXrKGRn+cGifiqeNQ6k6q0jwvsUYQWLrNfIRwzd1x/auuPIVoEfTvl2sZ9g9aaaWUt7sBjG a8ovMZ1rc+Jvj11T1HdYWf8ANmHAIwoU7Rj+1cuLiue658+e8o6v/Dp0Pw96uvNX0fq/SdN1PWG+ myj1CIPvGf0rn3qK/ED8olr4edV6f1l0Vp6WWjah9F3ZQJtit2A9h2Ga5o8Mut9R6F6r0/UtNuGg ubeYSpIPnPIr2M8OOqenvMz4S27azYR3EbBfzti5yFkXsc/fvXlxlm8a9fJj4+Occ++TLyY9L2Ph 5Hr3W+hWmr3Wor6sCXyBwkZGc/atd+EPgn4WdT+cDVLPQ9Kgvul7US5tJAGjMqjkY+M1uDz8+YKx 8BvCiLofp4GHWdVt/QihiyPy9ryCwb5zgVoH8NAyDxclLytMZLaR2d+STtPJrpjj4z24W3Lt2f17 0j5fvDmS3t+q9G6Y0WSdS8KXNsFLrnGRgfatdave+UO6tpVmuelVRkZSI4iDz8fT3pPnm8qnVvmJ 1XQbrpmS1RbC2eKT8xKE+osTXI2pfhneMGmQPdwppN16alzELpSSAMnA96763DHV+27vKZ5VPCTx F1HrvVYdPfVtAttR/LaYJmBHpkEk9ucHtWr/AD/+S3pLwc6d0nqvoeG8s/zd2YLy1L7kC4yGGAMV 0r+G7pV1oPh/1dpN7F6V5aaqscqfBAOa374xdJab4weHPU/SrmN5pLdlUMuXjccggdx8ZrljNdVn K99OLvJR5N/DXxS8IY9a6o0o3+pXDbHIbG0f4NcN+KvR2keF/mH6x6bsIi+i6NqbJbRSncwRW7E1 6u+QnTJdA8PNY0idDHLY3vokE/GRXl/5prQSea7xLbOANUlJ/wA1cJuVrfenqPpXh/0F5nfLZC0P T9i8tzprRQyCJfWjmVML9WM968WequlNY6A671DpzWIGttV0qVoZbdu6gE4r1F/DB65u7nSNY6cn kMlvERJEM8J71y5+J54dzdCeY6PWowrL1Ehm3HjHcd6vFeuzln68tOTWXMn1DDE5xSydnIPb2q6K Wu2ErA7eN3tVPDLj1Bbyvb52mVVJUfua6RoIuC+d2PtT20sZrhtiSgBzt2YzmmUqLEdwO7Fbg8t/ QydZeIXTNk8Bnae9jEqYyNuRXHky8Z09f4+MuXbtbwD/AAxOgutfCzTNZ6vk1NdY1CISqbacIqIw +k4xz3+1cTeaLy1aj5ZPFOTp6aWa50e7+uxvmGPWX/T+4r266n6x0zwn0np6zmjVbeeRLGFQ2AuA AK44/FZ8L9R6p6N6T6xtYUey0NnW5YH6h6mNv++a7Y3UeDO7y6c3+SHyddP+ZGTVLjqO6uLXTrAb Vitm2yM3zn4rrK8/Cd8GpEOLjVFkbnMlwDmsD/CqupBqXUltn6PyiyEf9W4VgX4kXVuuaL5hBDY6 te2Vt+UgIjguGRclRk4FceK7ltdeb45SFeNf4UetdMaNea10BrI1s243x6LOpLuPsT71qXyY+UvR vMB1t1Bp3Vl7caY+mD05bRZNkgkBwyj9q9NPJd1N1B1T4K6ZcdQLKZIT6VtLMuDLFgYOT+r968n/ ABq1KXpXzE9Yf8P6lcWafxGaSRrWQoS+45HFbvc8mZbvxd1D8JPw2mBH8Y1ERNnhZODWrvHH8K/p vpDoq/1XQetBpTWkbSlL+T6ZABnaPvXbnlH1O41jwG6VvLqaS4uZoS0ksjFix5968hPNb1VreveY LrbT7nWtQNjbalMsdstwwTAJ4x2rWGW5tm45eXjGrPDfwy6k8SNeXp7QLCXV9TlkaIbRnIBxn/au 6eg/wkdT1Pp6G66j6ji0i8cfVZhclP3I4rav4XXg7b6F0bqXV13bKb64kEVnKy9oznP+9ar/ABHv N71FpviEvQXSWoyWNhYr/wCrZPocy5Ofq74rHjcq3nnZPHTCvHb8K3q3w56Uveo+ldeh6kjtI2kk sPTPqBB3IJHtXCFis00ssTyMskJIkV+CrA8iuzugfxM+tOiPCu66XvLBNXkMMlvDfTtlhuGMk++K 42ju7nUtW1C8uRzeSNM7BdoLk12xx088zs+jtXzEMHP/AJq63Jc5Q7ivcUB1ZLfHvn3oqIqbGT3P 1Yp1PbrN07NwvpiQyfsKb285nT1Y7lQucbScVvHy5+VDq3zHdQi30Yi10y2Ie4vJRhUUn2+a7Xn/ AAhOgora3j1Dru+gu5RtLemi7m/6QWGa45cmvTpfj1XmVYW17f3QtrXE8pGQo4z9qGHuvXmiaD0Z Yc+qpP6cV1B5ovIv1X5X7u31zQry46j6bUYGoeliS3PuHA7D71rXy2eAU3mL8VLPp1NRk0wXcTTT XYG44Hfj3rXn1sx7attdQt/yrTTsZEI+koe9H0dIL/1HlnWK0Q5LOOa726o/CV1DRupdIs9F6ol1 HQ72XbdXU0QWS2+SFB7UPxK/CXvOmejtQ1DpDreXWdUtFMh0+eJVEgAyRnPes/ss+jc/twZc30Ft PKti/wCZgXgSDjApks0ksgeR1VW+O9br8vHlV1bzBeI130RdXJ6dltEL3spX6hg4xj5rovXfwkup NM6ssNO0rqRb7QpuH1CUBZYsd8rXS56i3W+3Bt2losZ2yOWxnBPBpEkOyGOVZQit713V4v8A4T3U PRXRl7rfTPVj9QXtmhmexmi2F1AydvyftXN/gf5WOvfHbqKXSdK082kluxW4muQVSHH+r4NYnJtm 6t/01G06xsGe4DhuFwKK36lKupDd69Arj8I7qWDRmls+sIm1Mr/yHjX084+a478cfLj1z5edbfS+ sbF0hlOYNQgBaCX7Bu2ftTHO3rTNk+q1/wDnrm1iaKK4dIn/AFKh4b9xRPzqSIF9ZPUA/TitleXj y79Q+YfrNtA6Zu4tNKwtLJNOeMKOa27d/hleLkfWidPiXT5WeL8x+dEoCBM45Pz9q1cu2scJ/bln c4idyVDDkCgfmA68gEGulvGT8OXxY8IekbjqR3ttY02zG64itpN0ij52j2rl6PUfzO1SgUrwxIwQ aY3dTKTH1R3Y+wq8YBUsfbk1b1igyuMHgGkRFYZvTlc/UNwwPb4rVvTnJseGTKllcbfke1F9b1U2 uqiL3PHNZx4JeXzrrxz102nSGjtPETj81LlYR+7dhW9NR/C48cdPsZbloNHvFiUv6MV6Cxx7ADua 5+W69GpMe65YX0FTKIAo7kCrC7jdCygMB89qd9WdLdRdF9QSaFr+mzaPfW5wYJkKkjPcfI+9bc6U 8lPi31h0AvVul9PQTaHcfoAl/wDUP/1BO9b7Y1rtpQ3YRxhFU++KMJBFgtzmujLP8Nzxzk6cGpjQ 7B4Gj9VYXucTgfGzvn7Vzn1Loes9Aa5LpPUmmT6RqsDYe2uEILD5Gfb70m7fTfUnsOeWGQEqD9wa GjKDkAZ/6hmlWrG8lUwgNvOFHyavfwvZbhKhjkHdWHNXWmdkTSrt4IQ++Pf7U81XVrXXPyMel6dc Q3MOEdbZcmT7kDvTT+GPdiJQDI07BYwnJJPwK9ePJR5MulvCjoTS+seqtOtbjqSWP82k9ycpbRkA gnPGcH3rllbctSN7mOO3k3eeH3Vy2oul6Z1FbZhu3eg3P+1Qi3A9T8vcWslndRj6ldChz9wa9eNb /EY8NNN8WR0vDpNpcaKs4tn1cooCvnB+nHYfNae/EN0Xwj6rvekOo+lJtMuep7m/jhuW051xJBkH 6lXjP3rWV8Z2xhfPJ5+2/Tmu6narLBoOoS2ZP/Nigba337UO50HV9NikB0m/t4/cNbPgj/Fe+d/q HTvhV4PW2s3GlWqafYadC5ijt177B8CtReX7zfeH/j11PcdOPodjpuoYPpRyQoyze2M47/ak/us7 t6xjxZF8YGjCuNx/9lF+vP7UVpb+wZbiS3u9PRv65IGQN/civVLzC+Unojw/8bOiOttC0OKGDUdR K32m4/k78j+YMk4zk8dq2B+JF0von/2LOps+l2islzD6RigVSrYbGCBx2q/RL608a31CS4UIUaSd jhFjQszf4pclxLb3CJNBLbyY4S4iZGY/bNdn/hf9F6PqPjJczarp0OoyR2YMHroHEbfODxW1vxVf D6xv7/oFNL0uCG/kWVEFpCqF+e3A5rljluO2fxsx/t5pfn3eX0lzJMf6UQtj/FEvrie0wWtLqCLH Mstu4U/5FevPl38pfht5cvDm36/6xEd9qH5NbyaTUoh/6YkAlVUn6iPin7eaXy5+NMerdNz2unSQ pGVU3lslurD3Ib2rU8v6ccrPp5IdN6tp1xNDEsptlkGJZnOV/cfFNfSuLi4nhs2aeBHY+oB9JHzm nfiboWjaN4ldR2XTzrJoy3b/AJbY25EXJwAfcUDRtY6g1rTI+lNEs7jUGDFpI7S33yH+45rf/bj7 MGkUEguQw44q7uQpAcuDwQavrOjap0pdrHrejXuk7+VhuoSjN9wD7UCOX8wCygrGPbHNLPtLaeWt 0I7dYBB66Icpv7ihrqk8dyxCLAT/AKRgirRiQOrq+EzzkYq97Jau+Fl+sYzWZ0b3YFJLPHewXCz+ hIrB42HfIpx1Z1HddVapFca7qUdzcxRiNSoztUds1P8ARPh7qniJ1Zoug2qbJ9WnSGKUDIRScE16 w9M+RjwO8DPDJ73rfSrXV7i0j9W81W8YhmOBlUAIzWfLd6ddanbx3S5VWEds6yJjl84xRspDb+t6 v3AxzXrn1Z5E/A3x08K59U8P9Mj0e+niaWx1OxdmbeBkIylscnivM3SvAzqy+8VYfDwWgg6je+/J LHIuFznGW+OK7XuM4zd010NXtlYMmX3D6tx/TQ11ISlhFOqtjiPNevHT/kR8C/A/wxhvvEXT7fWd QjUPd6hcyMpZzjKooYZAJqH8WPw8vCDxe8KJdZ8K7GHRNZ9I3FrcWcrP65Az6bgsdpNZk37S3+nl FHdBk+psP2JpjcyiEtiSQTE4ULzn9ql9c6b1XpvqG90e+t/y17YSNDdW8gxtIODzXRPkQ8uK+Ofj RazapZM3T2jD17idk3JI4ORGf3rGduPqOmE3La5kuLDWLSC3mv8ATbmzt5jiKe4iZRIfsSKRJPHb qI5whf3OM4r04/Fk6t6V0joDpvw8061gg1oTC6SKGEKIYMYyDXnt4PeC+veNfiBpHSfTSJJf3IJe WY/SiL+s1fXtce2GRatBFm3DrtIyJCcc1ZrhL5dlsoucfrdiMCvXbo38NnwP8KukIrjxFZNbvpSB JfXsvoojkfoXB5rWvme/C/6bn6Xfq7wdcWs9tEZzpnq7opYwMkq2e9ax7c8r1083Fv2/LmKQ7RH2 A4/tTuTWrO5tEhntFhkX9Dkjv81mfgR5f+pvMH4jR9K6TCY3B33kjDAhQHBY16XdMfhieCvQvT9t H1dqC318/H52+uBAC3uq5bBrNt8tabknjK8wvD/xTl8NYNQSMRSwag49SUD6l+4rM/M/0hoei6R0 Tr1rK0mpaiqyTzE/0EZFdheYn8LLQj0hd9Q+Fl4ZriKMyfwx3DRSxgEko+Tk8dq4en6im6o0s6P1 XAfznTMsSxq4wVVHGUP9ga726x6cbh5VrZ7tPWaRt7hv/cmiIz8cmrrNHdANGCoB+pW9jXtHe+CH hV5rfLRb3egdPWttK+mn8jNBEI5Y51j4U475NeN2tdMXnSHUOraPqx9C+02RraaAjlSD3+9TCeXt rqTRpOgkVcHaftxmmzMUG36CP2zR4txiIcfcE/FXaA+m0ijIHJNNQ3QRLsQqI0VT/pGDVlmjChfT QA8EY70ocr9Xb2NJWEySgZGPmmmb7UYg2BuKqOwBp365jQOx9RewJ9qG9u0kkccYG5jt3ZwAKJr2 kNoN6bZp/wA2SBkx8gA1L1Fm8r0XNqEd1EjuoYoccf00K4ura4CxlyzueATmu3vKj+Gzb+OHhjb9 X6/1bd6KbiVo4bS0hEgKDHLEkfNbbuPwf+lGd4rXxG1FLnBwhtkyP7bs1zldbjJNV5nGRYYdpYMU 4yO9OdV0e5tIEM6Mq7QygnPBrdvmP8mPWXlyvfzOqodS6daX04NVhy24e28ex+1aUh1JZUMdzLLI mCFYDcSMcV0xm/bOv6qLN4sYCmLgcA1dwv6nXAbvmiGSNYZQlq7RBu5B3f2FJCxKY1beWPP18VNy 32xZYEyE4UDdgcfI/alwMLYs0aus2PY8H7U4ZTGWlQjaBzn2pECLGPWZmfd7bfem9Jq36CkmzGVk JcnnmqtLt7eF1VUKEf1DtTlAkiqSGUk4OVosljA8ZHqbg3GF71ry+2TCLE0IwPfP1fNK2nOOQKJB aWy6mkM5njtQwDOqHse5p5qlta2moy21jO9xaFsLM64OKb2evZhJ6gg9RVIgXO4r2NRm6Axkeo0E e7J2NjJ/aprU7O4/KpDb3ZCu6rsK4Xn3zXojo/4b/QzeW1utLnUZp9ebRnvw6j+WJApIxz9q6Y4z 7W3UecUdnbXFqQv8x0O4ZPer2ki2d7bymyFw0UgkKPypx7EfFBjtjbQyyI53JIUJ/wBWKfLISUfd 3HJFXPDwrOOflOi+oNXPUN684tYrIsf+XbrtQUzWBTGsZQxwAcqpxmnBKhysa5BOSSKdrEXYRkhS RwPmsbX6RrEIVCIVjAxg+1CubFItrI24HuBUgLP+aUeZUbODVSWkduwH5sSKey4pvayBi2CIDE23 PcihyCGTeDHJI7DBZTjP706KxMgZJQy9jj2oJbA+nIHyKyu9G0VqYYSg2b/vnNHSFFtwu0ZP6sdv 7Vd1EYAPOfejR/UcGi+RsNPtomDxxfX85NGS2WMZblyf1HnFOEb0ypxhc85okr5fI2hCeN3Bqyda Yytyi1qt1cP+VthJIXBJjQE5HzTOWBHDkxKZ0O0GQHI/ep7QOpLrpnVWvrHCOYzGUdMjmm010t3G 0ktuqXkspdps4DfbFakcZsvpCa0t9YijvY3SxZGMvpMQc+3vTeZLT+I3Eqb/AMtuzErHJ/vQpwyL uO0N74NGtzCIZDO43Y+lR806jff2GBE5LyMRu7c050B7LTr97+Z4GuFUqqSLkEf2qOWJpNxTnA7f FK2LImcgsO6gdqzNfbcysPb24Fzcyz7UX1OBsHA59qBc6ftjQH+W+Ozjj9xRbWNIlDsMMCGA9qe6 xqkuvX5uZ1SIbQuAMAAVLlvo2joTdJGQs7NgcNIxIU/bntVQWrXFyEt1YzvxtUZz96WuzlVGV9mF Gs9RvNGuRc6ayrOBwzLnFbx6S59La3p2paK8FvqFutu7ruQYwWWo1EJZuOftUlqWt6hr1z+Y1Vzc TomxXA7CmcUfJKHEf/VTbAiQK4XOSR229xSUjns5FdHaKVG3I8JKkUVt8cg2gxoBneRx/mpNenOp bnSob61024vraZisbxRFt2O+KxbPtcZlb0s+t395DtuL26ufYCSQkf8AejarpsKRwSW2ofmEKbni 9lao0wyxSPFeQzWkyDBSVCrKfgg0b8qbaxhuXkRllcoFB5H9qSaMpZe+jPTkuNNuvzljftZTA5zC xVh/vU7rHWPUOsRLHdateXiEfV6sxJJ/zUFPAjEEjGTz7UhYFXgFv81rG6YuVPJSY3VZAWOMgE5A qPiuLjTLma4h2lHA2nH6Wznj4pyX9M4bt96sw9NGAwyv3z2qZzzSXXbvy3/En6W608AJOjNV0WdO pPyC2LeqAbdygADf7CuArmd/XkJXcXdjv+M/+KS1mgT1CFb7gDP+auFCn6CfTA4U+1dOO+E1V1u7 PejOsuo/D3WDqHTWv3egXmeZbaQrurM+ovMR1/1jaSafrHXOp6pank2005Kufg81gDmMgArn4bFN sxhgdvc8ED/es6dZkfy3zSsGeTcG7xHsPtU70n4r9ceGkrv0z1Vf6FbXBy8NpKyq/wAZwaxsvHtP bHv/APTQtyZ45P8AmueWG3SZ9Noa15o/EzqbTm0/VeuNQubV/peFpjtYfete3WtG4srllJ9TBG4n u3tTU2zRKrEZUj/SKs6LNGY9uN2Mg8dqeGoxL271/D/8z3g94HeFl9ba5IdM6qlui1zJMoaSYfKN 3CfatBearx1m8ZfEO91ZJWm0+djFaKzZ2Rg/Sf8AFaBuLaMkARhpFHBwKJFHLFDyS+e+eSK6cd/X 2xnunCs7ySmZvUccLjsBU30h1nqPQHWdj1DpEktreaeUlWeNsMBnkD+1RdtbkxEjjHckc0kLJu2q u/PzXPPGZrhncI9T/EnzYeF3jL5YZpr3VrKTqCW1GdMOTPHMBj4rz06W8XOo/B3Wo9T6C6hlsDOm 66hRiEZs/pYe9a0tLP8AIXryqfSMhwSO3+KKI03yIxG1juP71nw0ee2wvETx76q8XNQW/wCp7v8A N36rgBc4I+Oaw/Rup9V6Y12x1/R7qTTNVtJBJBNGxBjI9+KZKTGAAMf2ojITGxHfGSK3J8fExy1d t09YecjxM8ROnYLHXNSiuGtZFeGdFIkDA53E1svpr8TXxa6c0m2sLpNJ1J4U2Ce5hYyOB2JPua5I hlMgwVIx9qcGVyi7wGI7YGDWPB6bz7mrHbOmfif+I00bzXtnoduijIiMLZf7DmtXddeeHrzrTrvT OsLG7g0nVdNUxwwW4KoyHurfINc77iY2coGC98mhiaB5AET6m7Y965Zcfl9pOTfqN7+LfnI638bt PW06nuLKEQj+TDaRlVJ+cU38C/OD1/5cIruz0Sa01rS7xw8lldqxETe2z4rRp9G1dyu0TgZJbk1U c8cm2WWT6if1YrU4/wDbnLZO43b4/eaHXvMDNFf63DDZXMMXpJDAMKorrX8OHq/wx8NPCK/1e/6m t7DqK7ctqNrM+0gL+nj3NedO4PvGAwPGRQzZNBN66yum8DhG2j7Z+amWF8tsTKa6dIebXzBTeLvX mp3SXDvo0EpjsYS3Kx/Nc6wxJf3MYZP5QbLfNUqNM+Xl3uO2TnmirF6ZG1sZ9q9k5LMPF57hu7pW oCEXksMDH8uuNm45JpdjpTarBP6dwsLQLk7+d2aAsAyCxwauZGg+tTtHYge9cb26TpuDy0+arqPy q3F/p+m6fa6rp2qzrNdo6kupAIG0/wB6k/Mj5pJPMN1TDqjafJpsVtbi3W0yfrOc1ooAsc+mGz2y aKEZ2yyBT2+9cMOL9beWdrKvC7xo1vwK6+susNBSOW+gVozazgsrK3cV0R4r/iDat4t9IaZavocG nXdjcpebyDiRl9se3/3a5Pbj9UYf9+9BA3f+125wTXXdSZadd+Lf4hM/i74Zv0jLoh0oPDGk0x7u VHcfFcjz3ryyPInbsCO+KYy3kCxvJIwVlOBjkf3NLtbyOVQAQw+U5FdZydeLlcd5bTXRfWE/QnXO kdSRWS6kmmP6jW0gysmfYivQ/on8Vbo1unrOHVekNQtLuNMOLQqsOf8ApHtXnEjlt6omFcYIpEUP o7c24bbwpz7ftXn8dXb0zOa09V9F/Ev8M9cuRbXGm39kkg5a5KlT/auG/Nh4maL4reJeoatosMVt ZsBsMIADYH2rSMsX5hVLrsx2I9qvHEYQwDF8/IrrjnrrTnlPL06c8sXn96k8GLC20XqFJeoenI2+ iHOZ4l9lQnsPtXT0H4lvh0mjz3OmdOXlveNkrGQgwx92wK8wJkZGDbQTjAOKfQ9NPbab/EDOsQU5 2E8/4qY4d7at3O22PMh4+6j426oLvUox9blYxFwEX4ArRbRgyHae3H9qO+2Sf1G3Mp5B/wDuUGdy 06sqsiHgHb3rr05ToqVcxEAe1MLgXFnewXVlJ6PolZBL7qwORUgzEDBGab5KPt7qR2I4rjycf7Md OmGXjdu+/Az8TddO6Tg0DxF6euNYnijEKXttjbKmMfWDnNbTtvPf4OWFpJc6X02ljfqv8tkhQEN/ YV5cNAJ4VG8r7qR7D4pXoyBd0UxVlGOVzXDDguP2uXJv03X5lPHqbxm6rN5dxQwwRArC8Y+pgf8A VW8vJb55ujfBfw5fpHqK0uvzq3LTJcR49NlIGM5964f/ACpnC/mHMh/1U2udKBmyB9I4zj/evd9a Zxum5/M34mWnid4g3upadte0uHLL6fx960bcIlvOY5AWROw+aeWjmwDBOX/1NQ7kmWRjkbvkVvmz vNNWJxT9d29EvJH50/Drwv8ABzTujuo7iTTb+0nkly/6WDHiuevOP4u6d4o+IV5qukzJNazSBo2U +wFc0TwG4nRnRWAHwKKA5YSNlivsTxWODH9UXly/ZTyZ9Q0S4tdWtpjHdxSCVGXuCDmvTDy3fiTd FdS9KaZ014i7tP1iCH0bq8uADbzAcA4Iz2rzL/PykYc7lI7EdqbXFvFdRAiFUmU8S4GcVxy4rlyf sjpjnJh4PaW981Hgj0To13e9LatorX0ifTHYxBC5/wCrAHFef3mP8zer+Mur3JEwaJFKrDESEQD4 FcvJAyITBMVfGO9OYWYFZXH88Dlw36q9nHZxuWXyeh34e3mr8OPDrwrv+nuqdeh0XWP4g8whnzmR SByP8VpDzv8AifpHXfWLXml3C3ELt9LoeWX965Uk0/8AN3LSyIol/pbHIpbJM0ii4naQKOMnNZ48 /Df+3Plnlpdy7ySkNwW4WkKGnbCouPfIpZQK4JPFLjnVZQoUxlfkd6zbvtuei5kMaksvt2NL0zU9 Q6V1XTdS0y5aK9tplmjkjOHHPYUiS/E5IPGKMlsPTSVW+sHKE/0n5rzcvH+3Dxd+Lk/Xlt6/eAfm 80Pr3oi30zr5RoGsC2EU8k6kw3IxwVwDg4/3rLenutfBjwgtdR1LRdWs3ubnJkKPulf325wMDPtX j/oXjX1xosP5T+Jx3EAXaEkgU4HtyRTO86u1S7Luk7JLIfr+riuWONxkxqcmc35R2r5l/NxY9b9Q abBBKI9KgnUSLnICE8muqIvHPw71vwetk0XqWyvhaW4Uwq/1AhexBrxykna5JWaQysR9TH3qrGCf Sl9Syu5LZSeWSQ4/xXozm5Hlwytt27X8sHit0p095l7+91zVINMt5PU9GWY4Qkj5rpXzO+LfSuu9 KO+l6vbahH+WcBonypNeUS27dQyi3SMzXjDKSA/USKu13rGhobS4upVAyuxnJGP2reGVmcyXKTw8 TfXrkXWsXMsZ3LvJNBikaFSy88ZFNZ5jPJhfpB7496Kh2gbicfFenn5P25bcOLj/AFzRF0jzXUNx CNs8f8xSP9VenPke85vTvVHSmmdA9SsdN16zjMQnuGAiuF/8V5kPJtcFVzQZLaSa7S6huJLaZfeJ tpH9xzXxuThuOX7I+ljy+WPhXtbq/lS8OequpV17UF/PIJPWWAyqYT9j9vtWi/NknhtZQ6ZZaRaW OmT2kwjf8siqpGccgV52aD4k9X6E5EHUOo4U4VXunIH+9I6i691fqJ86jfS3Ep/UzE8/3r047yny c7Zj6e0ugazolt4OaNHBrFnLHFZqExIDvOOwGa8y/Npr1tqPXVwlq67QOQp7GtC6R1Jr+hTetZa7 erHn6YjOxRf2FVfa5c67PJPe3DTT92kPc16Px8v1+W/tx5p5a0VYapd9I67pevWTo89lOs6g9wQc 817H+APmB6Y8x3hwiWV+kOrC3WK9s5H2yI+Blh9ia8XgkbMCzHPz9vik2D6jpV7+Y0XVbnTnY8tb zGPP24r53Pjl5eUd+Ozx1Xtr0d4BaN0h1zcdY313Fd3aRMqF/wBMa45PPuPmsM8w/mB6esNAuobH UY53hUhSrd3ry/0bzGdfaFam2i6jvLuBuGWaQnmoXqXxA1jqtwt3OzyOcyBTgV3/AB7Zl52OXL1j 4x2D4ceSzVvH20s+vr/qiys7a7lZlsdhZwoPyOOa9BtH6Ih07w+tOmUmzHbWotllB+PevC3prrvq 3o2Tfo3Ud/bR7s/lhK2xf7e1bX07zieK2n2yR/x6U7R/V714NZf+Rc9e3qx1eOTbsTzM+U06jZWt 0urK8k8ohUMv6c+/7Vv3y6+XnQfAfo63stNht5tamjzdX5ALO3wpxkL9q8xOpPOR4hdR2DWOp6t6 0ci4ZsYK/cfFYl0v5jPELpG8/MaV1NeSSA5CyyFx/vXp/Iyyz0xx4zG3t6w+JHgd1F4h3n5ibqSK AJn0ogjbY/2rlDxs8k+pdP276lc9RJqM0mSqqpX+xzWmE8/fjFHGPV1+EN2IKAVHa550PEDqS3EO pXX8RLDG4jAH7V04tzrScuMvexPLD0HY6j5qOnNF1mzgvLSGZvVgmUFXwOAR716sdT9G6BadNTpH pFhaxA4zFAq7Rn7CvDi96u1aTqQa3a6lNp+qI+6OWEnKH9623ofnc8U9DQaXqerPrcBXCiUbQP3O K6ya5ZXPH+DZvno6c0TQLqyksYoo3c8pGMZrkKSdWCBF+kVmXiZ4p6l4l3kc2pyMzqP0eyj4rDUt 2KrjAUf0nvXs5M/KvDjhZnsuH6hg8ftQluZNKuIr5HKyQyrIM/Y8UtMJKcHvR3jjnQpKoIbsTXjz x8pp78M/F7G+XDxV0jx78EtOgg1SGfWY7QRXcROWjccAkfGKZdF+Ad9ZdbxavrhgjstNlMiHaf53 x+wryW8PvETq/wAINbGqdL61JpUx4Pp8qf3HvXQekfiE+KYt3t9bv4L21kXaSsKoSP7CvPwzxunf LWtx2z5lfE63SGC2s7iF7OJSWkH+r4rN/B7xD0Xxn8MJNN0/UI2vYoDbXEZbLIR/UR8V5XdaeYfV esraRUl/LoT9SA53fNYZ0N4ydceEuvTat0prUum3EowRjcjj4INezPj8e44zk8unqh0H5dL6brVb /X1MWn2MheJUO0zNnKn9vtWSeP8A1zDa/l9KjkV4U+ucr/SR7GuEulvxJuvrCxki6iuI76R1Kgww qvfv2HFYb1Z5mNQ6utrj+Hs8TSgloz9RyfvWuHXl5VOS6nTP+qfEKysvGfp5fWWS2ju0ztPAy1d5 +Pmnx690Hb6lbyLLAhVwV5yp9wa8WNT1vUnuP4gzP+ahcOA3zmvVTy5+Y7ojxa8DbXS9b1i003Ub K3FrPDczhXZgvcA14fKz8i5fTvJvjjlnzJWkt1pdnqka5/LHOQO2K7Z8r/W0Hi35e9OtxKhvobU2 swBzhucHFcueJuqaLqOjaro8bJ+SXcEumP6vjFck9B+NXXHgT1HcXXR+svADJteBxvjZc9sHivT+ VlvHHTlwY+Nr0s8P/L9rY8Rlu9YsPy2mWkpb1Sf+ePbFZh5l+v7bQbXTtIB9SMuJLiNOSFHYVxVo 34mnWqR/ldZtoS7rtaSNQMf4rA+s/NbLr9tOlpI4aYneZBuYE/GanWeO67b7eqdnLZ9eeE/paZMh hurIIuDu2HHY49/tXNvTfgf1HrvV1rCbCTTrK2lDSXsgIGF7Efv7VwZ4a+afxI8KNamuOn9WLW0z fzLa5+tGXPsDwK6K0z8UXqF7ZLfVdGihcja1zAAQP7Vy8tzxrUlnp3P4y6tY6B0MLCa49SbaAqyH LsAO5rhTxd1O1uNFTSomD313IEiQdyT7VhvWHnJj1QSy2Re5mmOWWY5H9s9qd+UiCw8W/FCbqPq7 XrHT7fTWWSCyuJlHqnOcc/FerKzi4eu3OYXLPTvzoG1uvDby56DaXEX5W7trHZJG45UnJ/8AIrmj V9dydUvTwCjMzHtmtlePXjhpus3DaNo916qxDZIV/wCW33De9cn+OvidB050obC3uI3uphghG7V6 fxZO83LmvjjqNaeFvV+fMp07LJKoiOpRgMe36q9TPH/TpLrp03UY3xbdvHxivEAa1fWd8NYt2KTW 8yyROvdSD3r2T8C/EnTPG7wA0x21KF7+K1WKf1HG4yAc5zXxOTeHL/8Ar1T+G3J/iXaT6j0XJplr E0t7NKsaRAZLE9gK6U8mnl1i8A+jrzX+oEW21q9TMjv3ih77T960vrfU0Xhh1qbsWi6o9u+5IpRh c1EeI/4hl71EjaBqGipoMR5a4hl9Td9jXu/Jw/bni8/H1LHS/SPmAe+8XJbK+m2aVcsYoSDhFI4U /wB6d+bDpOW70O31S0t/pU7Z5Ixz+5rzZ6n8w9vZn1dOlEtwkglBVv1YP+1bp0H8U0av0wOm9Y6M WBGg/LtdesX3cYzg1zn+HLxxb15x2h4F2EVn4AKrqcOZWPHJrkrq/TL686quTFptyw3nASNu1O/D /wDEm0Lo7RItFfptZraFzicTAZB+RWw9M/Eg6D1DLPo8EWO+4jP/AGqTOee1mFk0486y6N6s/wCL IXFpeQWxnQH1FbGC3zXqDcdPyaR4C22n3hZ5YrNS+e+dua596y86vhn170/+UCxW8ocSfoBIKnI5 qI1T8Rjp7WNLuNFn0pbWP0vSFwJd2RjGQKnJh5dty+m5fK31L/GrLW+lbpFltoP/AFG8nk7mGR/t W6+uoRB0fdxQrtVUCgD2FeXHQ3m1Xwi67m6ht0XWNOmJV4PU2nbntW/D+JF011xod1YHT30aWZcJ Kz7wtduL45Rzzm96QXippfo+pMgy7Ljj5zXTXgGkvRnl9083K+nLiSQ7v+rnNcxeClxd+M/XSwrc pd6TbP6k7Z/WnxW/PHrxO0zpTSIdB025jigjTa0CnkCuv5WU5OeSOfDPHDTSHV+tx6v1UG3g7pt4 /wA1y35vupPRvo4gQUB+lfua3bcarawW95q07YWJS6/H7VxX4rdWzdddT3U7yFoYzlBXutnHx+Ly csueTFoVcEoZNm1M/ucZxTnRbCfWdXstLiDL+ZkVGHcnJ9qZTOJAr7fqHBFbD8B/Evpjwx8R7fVe ptNbULSEK8R252N84r8/+XllJvGbfV/Gsnt7D+AXh5pPgd4L6dpV7OttG8AeeduM7hn2pegL4TW/ U1vf2Wu28mpiTKKZTgt9wRXO/V/n48P/ABS0VdK6fuJbeT0fq/Mx7QDjgYrmvVfE2DTLpL2WfcY5 AxaBuSAc4rn+Lx6lyrXJd3f9vUrxn06DUeh7m5cgmFdyN371D+CVlFonhrObT6CWZ9xHG6ub7b8Q 3w16j6Aj0S9F3FqforCyGPK5AxnNZb0h51PDPSOkrfRjPMtwUK/o+kn7mvoYfKuGUuMRPiH5luu+ jNWmtopbZ4t5A3JyBmtJ+KvmfuLu2/M6lE8l0VJaQZABoXjD4qaT1VrD3VlOhQHggjGK0H4vdeaH eW9rao5l3EB9q8mvozHHjeO75OiovGq+6x6ssbOGQJDJKmVB57ivWSa5Fv4H6cZDy9vGK8/PLh/9 jbo+mWN91Ok38d9Xd6jZIH7jNd12Pj94Ra9o8Okxa1byWSKAkDHAA/zXxrblzW/T3fw45K448Q5m bV7hMFvTcMDj712r4V9QTdR+CMEyRM00UGwKO5wK1r4m2Xh9f6X6/T35Ul8+qA3JHyK074feaVfA rXXsddVZNBkbaZAf+WPsK9/5P/rxyjzYZ7ysR3ivcyQ60ZM+nLGxJVx961J4l9Pa91P05Ky6bO8T rkOqHB/tXZ0XiN5fPFS7j1qfWYJLjghZGCYPft+9E8RvFnp2ax/hnT2m2lzYqgEdzEATxXTH8jzk mmcuKb28i9R6D12IsLyzNuqnhmGM03v+or22tDps1nbxxsoXfHHg4HvXYPiBpugaxJc3l5fJZyAH +U3ANct9f65ptzOYbKNJAjFRKnIb+9c859rh/SN8Ori1m8QNFS42gC8jUsR2GRmvcKy6l6X0fw50 8XqCXTTbqjBFyO1eCkd41pcQXMWUnicMCO+RXpV5TfOz0h1V05B0X1ekGmzJGIvWumAWTjvk18Hl xs5vL6fXw1ePxrpReufBP8wpeGxjlHOTH/3qX6w8euiP+GXstJ1GC5YrsSGMYCDFYM/g74QdQXj3 tv1ZZXCOd5ghmQ5+3fNa88VbbojQ7JrDRtCcNGcrcxEkN9819Xhs9vncmWqzHywavHrPihrF1hSQ jAbfYHNZh4/dYRTxGHcCseQFxyRWnPKl1F090XqGt3ut69Z6fNcjbHFczBSo+2amvGfrbQZo3msb 2HUkUfTLA4df8iuvFfLPdMrPHbQXULJd3NzKhaLYCeDWZ+Rx7ifxO1q73sRBbsoyeM1qfqHqqJ4r p8hI3981s/yP9YdK6RJ1Jc6h1BZWFy0hhVLmYISD71r8rPdkjnwTyu7XQPjN1Xczhlmb1VCY21yd qEqXHUtskjYVpQNnt3roDxY6r0wQZtLqO/yCfWibcpH71yhrnVlvBeyXTZEqPuTPHI7V6Mcf/j/7 dM5/kegZnl0vw0s4YpdlsIu4+cdq5kma5k67tUt2YlpdzBc1sLwB8wvSfiX0cvTmpara6fqUB2yL dyhOPkE962r0/wCDnSmia03UL6/BqKqMrDEysAPsQa+bjl9V6pjqbZH1rqTRdF2AkI3/AJcDJ79q 1L4AWzS+IWp3QcK0f1LUp4oeLOjyJ+Sty6KPpX1BgYqP8vkFrNdapqNxqMFuJuEJcArXXPG6lcNz bK/GfqL85DcpIc7QfprlDqC7eK89eAmLk8g10T4taxplpa3JkuFmRQRujO7Ncsa91TZX928cJIRB wTwTX0fx5JO3z+fK+o0/4zeIeu2cEkUF9IIyf07u/wBq0vptxrPV8rx27LLPjjc2ATWw/GFre+nC b/q98f8AetSi1NkmyKR0UHdlGKn/ADWeW/0v4+NvdZx4ZdD3kHiP07a6sv8A6x7lSdzBgV3c162y +hpnQi2tsgSNVC5X24rxo6M6ok6Q6v0/V5ZpXaCVSGdiQFzz3r1q8I/Ebpzxz6At4dG1GKW/xiSN mAbdjFfnuSWc276fouPXg1dYXU9h4gRPFIS28EkHNdIdd6isfTunkD/1DxKXJqB6U8vM3T2vPrOu zxpZJlgI23GgeIXXGgyzxWcF2NkZCAvwa93H28HJdMh03UI4OgzsLpO2csDgGtY6ZJcHqyGRZizh wck5OPitszWuOj4FjjBiKbs49j71rbp+0SXrWNI3UgD6ue1dMeP+3mzy3pmPWeszmEHcA2OPmuYP FbVZZ/UjkO4/08V0111AyxSuwEaoOCe1cpeJeuWltdSJIdxJwCOa+h+NJJ283PJa0H1uVa2KnJIy QtYX4KWsf/1saYXIytwpBb25rOutCptzOqbgT3rS+m6uNC6vGpxyGOeCdZQvtgHtXj/N1cK6fiYX HKPY6/nS36HyTyxHP3wK0B13LFGkjTcgjgd62L4L+IGh+NPh7ZJbalGt4IgZLVGy4bHuKZah4AdT 9Qas0SQPFYM3Fww7Cuf4PJjx4yV9H8rHc6cmdQehe3ZRVIJ5Ujt3ruHwh03piLwn0+Lqe8ksrVUB 3BiAcj7VqnrHyzad0/NG7a2s9wzBWgGM5reOqdJW9p4c2lm0O+JYFzleO1Xmn7Mtx4+L4h6PYeB/ T95+esb+G+vF+pFmbfz/AHArFvETxpTW9Xi0zTLBFtBjbOMbSf2rRfWlq+mZktp0tgMkYAHFa96W 6ovNS6sgt2vnlCyDDdsVvkwmGBhlbk796SS6uNOt2uZwGwOBWYQKsKAB8/cmtZdJM7adar6hOVHN bC0+xcqCzd/vXg48t178pqJRGEh+k5pFw2QVbkEUuLTpEA2uCPvTe/3xp7cD2r3R5skFo5USXBY4 UbhWpPEGf/nAnO3IrbemxL6NyW7nJxWmev2/lzsDnvX0vx/b5n5Hcc59dTlo5+M5JrnHxAuCsTxk 4AroXru42QynGWycCub+vpfVMhPBr0cvp83jnya3LtK/J+kGlIQKRhfVIA4q6vn2r5Oft9vD0KxU 42D2qnhbYJB9TDuKsHCkHGSaJHP6SMVGSfapp1By/O5M5oqxSEDcMRgcURZVcISuPnFKcLvD+pgf 6KaDR5WSRSMisr6CRZNYSJ19RJBz9qxa4jU4K8EGsx8L8L1CsjL6iICWU+9axnbNvT0SjILbySft TtFSQHb3pG5D2wRVLMoHbFfQ7eMOQFC2SPtmkF0bBbkU4kFrJGWaQ5HApuIc5H+1VklijAhSQPeq OFPBJH71Z4jkY4pVvblxyp2g96LsvO5QexpCuScGiSIlucYJpBCFvpyaNL5yfikngY96IExyTjHa ht+1GS0DcYNLUZTJ71aNSRu9/irHvwaIuUy3fFXILZGfpFIMwjUk81UVx6kZITH7mgUB6ZJ4B9qH G+FJPLZqzjec57e1JKseR3Na0F+tlvpGF+aBKAJSw/UOTiq/5jkKMEd6TIWim3DuRgmqKWTaWLAm rSy5XaTtzzmkx5kUkigS++Tn/wAUAJQuTg5PvmgkHOeQvajGP1Nv9J+fmrSjYDtOeORWtBsWAfaA cfNVKwjHznvVKzpnb2Pc1QA7/qJ70AwWc/8AT7VTAhgp7j3NEaErhvf5q3JbLVKsCJyc4wR81Y4A 496JKVz3/wAUg4I7020SGx27Ukjdn70QJg4qzLjGBUCQuBn3qvb71fnBPvVsZoEqOPtSccfP3orY Ax7fNJIBB9vegAThsEYFXMBY47mrSysihlGRmrPFcFtsX1K3Jf4oF/kgQN4wKHPDarnewQntn3q5 uZItyTHdiojUbaa9ZCZNiqc9qAt9B6UX1ZHuDWMXKHLEcAn+9T9z67xgSSeoV4BxUHdSLG/pn9Z9 jXKmzvplijqpP9dbd0U5ETgdsc1qTRPTF9GucsT7VtzQpRHFGhHBYE15be+3o4rrKOnvBGVzDcRn /liJWGfmuFfOHr99o3ma1eCz2s8scRAf9P6RXd3g3JGFmUEBjEp/tXn15/onsvMfNOMr6tsmDnHO 0Vwklzd+W3usaj8fNe8PJHht9YurO8cZMNk+EH9s1inVvmi8SOph+Xk6n1E2jjbJEJDhh96wCNVl jaWVy8mcEseR/ekyRozLuI2/OMZrnlh25b3GbdH+Pmv9FOsllZW77TlmdSWb71tO08/XiI9v6FsU tgBxuOBj7Vz3b6hBpdwH9BbgA52k9qb6nNFe3ss6Rfl4XAIjB7GpeOVvDLxb6s/OX4wa1efl7XWH jlc/SHY4Fa81zzCdY6j1JLN1Rq8+sTwOQsLNmNT9q1+XdNrwXBiPznmmwsI4ZGmUPLM5yT+rJ/ar jxyL5bbs0Lzodf8ATsbRaNNFY2/9KrnH96xfxA8zXid4j2T22p9Q3H8Nc4lto3IDj4rWxDGcoYDH IOSGXBH9qXJNOhJYqB+1Lxy1bdsz6f8AF286bsVVLWaSKPG0HuTWyujPON1P0hayy2sn5SSUcICf /prQCuzgFm7/AB7UQrBMpMx3EDC1Zhpcc9Rkviv40dX+PHUMGodU3wkS0+m3hJ+lQfesPVX3qgAC RjaoX4p0lqrsDuBU8dqJLEqHj9q6SOSPkVlwwzknk1N6F1pfaTdbbeZgyHjJ4qOkACcD34pYhUg4 2g49hWbjtrW229H8wt7aR/8ArLeeS5AAVojxmtnaJ+IF130no6WulabayxIMBboZYVy2yKoT1X2x 47Z5NJlaNnDLuAHAJbvUnE7+WpptXxS84/iN4tOkWsMljZRtk28GQr/v9qf9HeZkaFYRpJZzCVMD bb8ZxWm541dlUkM/fB70v8pHKN2QjD74q/rjnjnquxdC/En1nRdOW0tdEjuEiXAe4zn++D3rSfjX 5uutfME0NjqbQ6ZpETH+Ta8CT/5fNahjt4VkyZtp91POaltI0XSLnUY49Rn/AC9rIw3Sr/TWLwyt XOVubRZdC0fpXSvT1eOa8Kj1IFPOa6P8tPjlpukdTQWl/O1vBL/LV3OF/vXn/rVnb6Z1LdW2jXBW 2jP8qVjuzRn13UWUCe9M0oGA0Q2bR/areNnjzk26/wDPnaaX0B1/pfWej6hHPe6xiS4tg4IbHYjH tite9NeaZdIt4p4fWsLrcCTbnBzXNl1BcaldG51LULq7CDESzys4QfAzTuKJREoZw6gYAAxxWsMN Rm8nh6d1Wv4mM9jZrCvT8l9JEoHrSd2NaS8VPOl1T40akkOoWi2WiwHctpF2J+T81oy3t7dFIiVk Y/ejQwMhbkc++Oa1+ti57dJ+HvmjToaeG6gnntWUAPBCcK4+4rcr/iU6WLdVHTE93JGP+Y4Brgm3 sljLFhuJ9z7U9hscA7pcr7ACpOKfbF5K6D8VfN91d453selRBtB6eJw8EZ2tKP8Aq5qS6Dt7ae5t NJiYKpxtJOMtmuc7d5rNv5UmFHb5FTEHVGrwzpJbXJgeHt8k13nFPp57zWXdemviB1/ZeAfl8vL2 3uITfx238qORgSztx2ry30jXZbfVmvn/AOdcTtM7D5Zs096h13XOuplOs6nc3NtEBtgZyVyPtQIo UjhfIG0EbQR2rpjw9OOfN+yuk+l+o7fV9LtWRlDxKNzE811l5e+u7Pq3pm60GW/UzPE8ccTHnBBB x/mvNDSuq7rRXJhztA5FS+neL/U2l3i3WnXn8ImjOY5o1ySa458N109PHzSY6refibIPL94hnp2+ lSSwlJu4wD3XPatk9V+fjp/Regf4d01pc8uuSQ+km8D0o8jBY1xJrWt6v1h1BPq/UOovrN9MdzSy HHHwo9hTG4gtppxMIzFIPg9xTDgvjqpeeSajdfTfidbl4r+aQreF/UkklOcnOa6j6d86PRS9Grpn UrPPdmP02jQZV1xgV54M0ZyArMDwV3Uj8tHO6FF2EcAsM1r9G+j/AMnb0r8K/MX4b6HoE1tJqUVt FK5KoR/SfY0bUfFrwElmea5s9ImkY5LtACTXmpDYX14j26QfmdoLEIMYHzTOKylkY7f0LxsPNY/8 d0/fjfbvzxN8aPA5+lbi10a0s49SYgwtawhWU/OakdJ86Ph9o/hxBpFyZ5tQFsYXhhAO5sd+9eed rDa2s7SSKqv2C4ziji0tJSZCqhvZvir+iM3nmtR3d4TeZPRul1iluGgtbBpGLFv1KrGp/wAzXmU8 POqvCy80TR9VXWtS1AiOG3teWQ/6m+1edsk8jZt/VLQn+4NH0i7tdDvYrqFB6yH3XFc7xWLOXGzt 1X4X9LXOpDRdJijDM4XCD2I71vjzeeI1p4L+XO6s0gVbvVIfyIi/rywwTXEnRfmK1bobWVv9LhVb qPJVpWyM/sawbxl8X+rvHvqGO66uvF/LWin8rbQjCD98dzWJx5b7ei8mNw1K1zpekG3tEdJ1LYy8 Z/VmqSFmwuO/vT23tfTI+rcByM96RcR+mM+5r1SaeKw56X/LR9QW0t0MrEw3D5HxXdHh34ldMzar pdu06W1k6ASEn6UrgG5tZGh3CQofZh3FDF3dWy7mvJZHONgQ4Arjnj5N4Z+FekPnI8zWgaN4Yafo PR/UKXeqPOiTQ25O4Re+a0f0F11ajTdOnjvy0u9WdpHPqA++ee1cuadHPLKzSSLiQcu4BP7Zp9Pp d5pFubhblp7YckRnBXP7VyvFa9k5cf7epviD4w+GXUXhE2m6l1NYi+jgDx26sdxmHbFY5aeN3h5D 5aNR03U+orK1na1dDbSN9TMewA/tXlzPfJNOWAMbf63bdTW+SOcrlGlVTks7ZX/FbnF1255cmPqU W1cSzXUyujq8z7VI7jPFbj8IPDrTepL2Ce9nACNkx7sVpxDbK/8AJdSv+Mmnqapd6aC9rcSwueCi ORW8sLZqRjHkku69avDbwY6Es9I0m9bUCl1FhzH64VcjtxWa+M3RfQvjB0vHofUWsRwWkMnqK0E4 VgcY/wAV42x+I3UEQRX1m9AHZFlbFMtQ611y8nZJ9VvZIZO2LhhtrE467cnLjZ7da+I+ndIeW7rq 20TpvqcaxYS4aSB5N72+fnHFdU+Bfj7our6E+lakIpI3OEIwVZT7NmvJOHTsyyXH5mS5kfGXmcsz /wBzzUrB1Fr+lskdjdSLCR3V8FazeOuOPLPVepPVHkv8K+rOpW6gtrqOwEjia5tY5FELe/b2zXIX 4iXUfhQmlab0t0LaWn8aspl9aewXhEA5U1zPrXWPUo/lzdQ6jB6nBRLhsGoC10NDc/mZbjdJKcPJ L9R59zmmHHZe2M8pro2haL8pGEfg/PzVpY9rpMMLJG4ZSKyXrHpzTNBurVNMu0vFeEPLg8AnvWNE biRnvXo04yOrvL745RWVna2V5eC0uY2HpOx4DCu+rLUOnfMt4ZHp7WbsRXzrzLbttYMOxU/9xXi1 aTy6dcxzox9Ray7R/GvrDRMR6fqMtqfZ0JHFeHLDLe5Hvx5ZlNV3tqH4cdzaXMtxcdWW/wDDFJJR 2cOV/ftmtIdR9BeHvhb4zdN6X0lqk95qbMw1JJn3CP4xzWgOtuvut9QsYTc9Y6hL6yByiXLDH2rB dO1O/wBHuzfxvI2oN3u3fe7fuanhlfpn9msntx5d4oJLXUpoZleHOxsHtxXll50Le103zQ65HbOr Q7QWKnPc/NYSPHDrs6LJZWnUFxY71wwiYqW/vWBoXvLqWa/uprq/f9c87l2b7ZNb48Msfpjmz8rt uzy93ENl4kWUSHETDdmvWTwH3TaXeThh6TAKMn7CvEPTdevdCuIrizkaO5U/TIvxWfzeYbxEXRTZ WOvzwK42uIyVJH71Lx25+TWPJP16rKfNmTa+Z3q1YyhjEgyFIIH7Gt0eVfxfsNLskt55MSW5BXPH NcdWc091PNeanPJPeynLySOWZj+5qSstZubCT1LRjG47BeN1deTi3jqOXFn4ZbeyniP0LpHma8Jj pQu4FuZArpcLyYmFN/AjwQn8HbCRtZvbWcWyFYpk+lQv+o57GvMXQPNF1/0fYwWel6gbeNscD3xQ OufMZ4ldf2P5XV+opxYZyUtyYyf8Vy/Vl9x2/ZjN6vt0N5lPGnTfFbzG6Npuj3CXWnaM4QXEfYv2 au1vBeDf0bqaR/XvcgfB+mvGnp/Vf4FqC39orRzqdwlbk5/+7W3bLzb+J0OkTaVp+sjS7OVNkkgi yzfcfBq5ceXlLpjHknhYxXx80q40bx76ngukzIHMmcg7QTxWEtkTMSd2ferT3F1ea3falfXst/cX KhWnlJLMf71bdjIr2Y2608OOOhDIQGX2P+KaxIRMZR3zgj7UZXAyD2oO4qwYHuaW7jUne3YHk08V rXQr2GG5zH+Xmztc4yvzXVHmx8DZPMb0Hpc2iXUT3NgxnhVefULY4GP2rym0fXb7Rrxp4JjG3sF9 63j0j53/ABD8OtJNnpUcTwcc3BD4/YGvm3CzL0+p5Y+M7dy+VLwY1Xwv0ye/19RYzLD6Aik4IUf1 E1qHqXxC0jxN82TTaHc+rb2UaWrS/wCp04bFcveI/nj8YPELQ5tHn1W3sbC5/lzC1gCSEH/qArWX QPiXq/hhqiX9gpmukO71WPJPyT71Jx6Ty8u69C/xL7f0/BLRLxlKzQ3sSfsTU75Cp5JtAvCxBRrd Dx85rz78ZvNL4k+Oej2mkdSXls2jW0glW3hjAZmHYkjvU/4VecXqzwb0yS20O0iupJFwDIRhT9wa Th+W3fzkwsSn4kEf5TzJXU5hIWaJVz/q+nuK5zU/l2VD22gipnxU8W+r/Hbq8a71TNHJdwgpGsSY CqfasbMjPJmQ5wAoFfQx6jxXupC2dPWJYn6iBkV095RPFeTw76njSeTdEsoK7zgEfeuWrYAMCDhe +ayfT9aNrJHIk3oSKAVYDua8/Pj5Y9PRxZSXVesfmo8FofMt4QWs2kziTU7RfzNl6TfQ7EDcv+1c J+H3k78ROr9dXSdR06XR44xj81dD6MD27U78GfOBrvhPj6G1SNFwLeWbAx9ga2H1P+Jh1hqNg9ro fTkFjeSr/Lnch9n9q4zetJZq7ic8FfC698CfMRa9KX17FezvEkiPAfpwf/NbW/EO1XU9F8MbG7sr qW3iEu1wpwpJ7H964k8P/H3Wul/EN+rtZZ9Z1V39Ro3JHJ7gH2FZH5lvOPr/AJg9Esunf4GmjaZH IJZMPvaVh2OfYVMcPH0ueXk0tLqt5qnpz3l9PdRvkN6rkgf712D5BeprLQ+tWsbqRVkkjMcbE/qz 2rjOFY4YvQlBLE8jPAFTnTXVmqdJalHc6bMY5kIZZAeVxXXLHpOPV9vQL8RDw01vq7pbRNX0i1e9 WxnxOkYyyL33VkPkR0jUNN6K1R762kgWR49rSD9XBrRvQ/4jT9MaAmm9RaO3UUija8wO3P2II5qC 8S/xLNV6h6eudI6L6YXp15lKNeswJVTwdoA4OPesTG3ouP8ARt5xNLufFzzQwaRpEf567tY/yYSL nDZ7Guu/Ajwa0Py2+H8mq636S6uYzJd3QXcUGMhFHz7V52+XDx9j8LuuJ+p9ZhbVr+RiCbhvqP3y feutZvxMeirtDb3HTjz/AOtHkV1/uMVJjftvLHxnTmXzoeYrqXxy15tPstOvbTo6zciGARMGl/63 A9/iuWI57eZ5YFY29wRtVGUqSP716U6j+JF4b2ytjomKcgcp6Kf99tcIePnjLZeNPilP1HpfT1v0 /auvppBCFwSP6jjirLdXTjMflK6X8pPkr0rxy6X1HVepb+9tLGNxHb/lH2swI5Naa85nlETyra/p 8+la0dQ0bWXMSwykmZP/AJV0L5TPO70H4RdA3Gj9S3EyTg7wIoiwyP7VoXz4+bTQ/Ml1Fo0PSulz x2umAO1/MT/MP+jbTjt127cl1lpzbBbNAFjVd5GeBSwSeANpHegWc1wskko+lmHII7UeOOSVDgbn POfmvU4aJYNGokYMVJG4gV37+G517Z6B1pJp1xclxqUXoQKTyHyK4Qi1ie1sntI/TVWP1blya2d4 Cp1Eeo4b7p2QQy2cgmLk4Kke4rzc0tnT28espp6Defw9adCXuh9adHX1xZykm3nmtsh4gB3/AL1m nkbs9f1npLU+r+q5Lm61bUZh6d5dE7pY8cnmsD6S8/8A0JN09/A/EopJqMJ9Oc+kGWTHvtxWG+Mn 4mnTOg9Lz9P+GWktLM0TQ29642RwA+4XFYxm3nylx6Z/4ZeLdlc+cDqGyt5kignZrR8NwxXtSvP9 1P1p4e33SnUvR0lzY7Elgur21BBAJ+kHFecXQ/ifq3S3V0fU0l0ZdYmuDO8wORvJya9HfDjzt9B9 edBzW/iRPbROqgSJ6YZe3wPemXU03cf+TNvJNL1D1Z0jddY9T6lcalql2fyitcZ3KikH/FcDeevq ix6h83GszWcqT21vbwwNIpyCyrgj/NdGeNH4kvQnQnREmheFFub3UGjMMNwYtkdtkY34Pc15tPrV 7q+rTajqEjTX99K08sjHO5icn/esXG5YaXiz1yyvYP8AD46nTV/CSWxLqZbW4OEHsuBXmj5mOmbz ovzBdV2V/bPby3l3JOgYc7WbIIrpP8O/xzPTHVw6Yu5I1sdScLvlYLsc496kPxWPBPV4r638VdNV HsIY47a7cEZjAAAOPfNb4MZjjqtc+fjyXKH/AOGf1Zbaf1dqOjT3Ow3FsWiVj+psjitoedXxN668 DetdP6l6XRo7PUoVtZJTyjMvscf+a86fAvxpufCbq/SNetpEuDbOpZGwNw4zmvUew80vg743eHxt erLu2tknUGeyuDkqflW9qzZ42s5zynme+SfVdc606V1nq3qVZJNS1G5Bjmk/qTb7fbNY34H6HpPV Xmw8RdUuYUmu9HYLbk/+25bBI/tWK+M/4gPhd4L+GjdP+HNyur6wsRtrS1gyq24II3lj3xn/AGrj Ty0+a3WPC7xGl6kvpGvjqUxfUNxOZgT2rU2xjPLenXn4j3jB1r0JrPSul6HeXWk6Tdo7ST27YEzc d8fGa3B5GuudY608IGk1l5rt4rgot1Mc7xwNv/8AfzUXrvi/4D+YnpPT5+rLy2YRAkWk8m14Ce/I qF6i843gf5bOgLjT+lbyLUJoAWtdJtz/AM1/u/8AYVyy35zTN/jquEvOx0dpnRHms6j07SoEtLKS KK5MKcDc4yxrpn8Otuno+qJYrKJ21X0dzyr+gL8VwZ4g+Jup+L3iNqvWmsZ/O6nIMR9/TjB+lf7C vTf8Obwfl6X6RuerL+2/L3GpLsts9zFwc49q6ZZ9+L1YY+PDtrL8XvqOzudF6N0KKVX1CO4a4aHP KqQMGvP3TnRbkOxADoMY/prdf4hvixp3in5mb/8AhFyZNO0mFbGQ/wD6ZOG/3rQNhKLe2V2P1QuN wJ/pr1ZT4PJxZeOb2q8kWsQ635dtOjiIaSL1I2A+cDFeQHijoE3T3iv1TpV9GbeZr6SUq3BALEiu /Pwz/Gm1xd9E3f0PcfzrNv8AV7kY9uK0x+Jd4Van0Z43/wDG5td2kawoCyIMqCBghj/Sf3qcHN4S pzY7yaT8HvDTUPEvrLSdD00M01xKBG3sozyT/avX/S7Xpryr+D0Buy35KyCJczqBvlkb3PzXM/4d ujdCdLdHXfUt3q1jBrMww35uZVMSAZ+nP/itC+e7zaw+MfX9t0t0pcGTp7RSwkuUk+m7k98j7e1e Obytyr08v1hi6y873gfZeYrwVtutNCEaapp1v+dikZSXnt+5jGPeucvw3rmWPxqW2kj9OQW0quh7 qQp4Nbs/D28yNt1X0ncdG6/eRR3lgnqQSXUgVWj7bOfin2h9J9B+EvnF0290DWbBLLXYJ3kto7hX SCYr9X1ZwNx7D2re9625WZYfE3/ED8xPVngv1B0tY9NXrWIvbZpnKnGSHI5/xXJ2red7xi12GS2H UK6arLtM0D/UR++a9APMn5dOjPMhd6ZPq3Ultp81jGYkMc6MSCc+5+9aRuvw0vDkwfyuuhbyAZEh mQgf23V6cbqMax+2Yfhr6pPq3QnVt1dztc3s+orLNK3dmweazuTxIbpjzfSdMyLGIdY05B/MOMY5 yv71hfkj03RfC/VPEboqHqG01KPTr9fSvDKqidcfqBzjjtxWgvO94oWegebTRdU0vUYZxa2MCSTW 0oYKQ+WGR74rju73W8cZllp6LdJ9Ex9K6/1DfQ+kkGqzRyrDEuAhVSD/AJ714teai2J80HiQFI+v VJcj3717U9DdbaV1r0rpet6beR3Fncwqwk3YwdvIPxXif5qtQWbzReIzW7pLC2oy7njO4d/Yiu2M 1K5z+U26w/C/RourdcXGFMXasL/GJuov/rG6CiBVpUtWZk98bjXQP4avh23T/h/qHUd7GySXbD0n kGAE9zmuCPxAvEMeI3md1xIbkXthpbGC3kRsqQM8CuHH6rt+RlMs5poPaJI2Ucb2PJqai6ivLfp+ TR4VRbaTlnI5NQ4gKFA+Qp5xR8sAT/T7V1gRZxhJGR0LJtwPeu9PwvPDttQ8RrnXLm09eytbVwkj DIWTIx/euGNInaFbkIQZnAC55xXsh+Hn0VF0d4FjUJGjQ6lJ+YdsgbABzk+wrjfldPRlfDi3Pad8 3fQ/VvXtn0ra9NadLeLY363crxd+COD9qyrx38OL7xW8v2p6BctHaX7WizuCDt3Rru2/3xXFHjh+ It17oXidr+m9Jz6eNE0+7e1RmiWQvtON2cdq6r8mnmFvfMT0JqtzrXoyXtnIsMoiQJuDA/0iutmo 8cvpz7+GRYnTOsOr7RkKSQWwRgfYhwK6X8butfA3prqOKPxFj0WXWTGpzfwh5AuBjkisO8BOgB4Y eaHxC0tREltf2ov7SONs7Yy4wD8H7VxN+KuqR+YSHeUkE9nANhwcYUVnix1GubPyyldLeKH4lnQv R+gSaF4Z6Y+raxDH6diqRgWkY9j39vivMoXl5r/VWq9RapOr6re3Es9zEh4V2JJxUFFJPZ3UbWRE Eu3ACLW5PLt5c+qfHTU7+LRLZJbq2w7SyvsXnvnNXks1qN8U1lMq9a/JpKsvl16M2gjZbkHI98mv I3zFRrH5meu29Mup1Kbd9uTXsl5dPDfUfCrwt0nQNUmEt3An1KnKx/YH3rzz81XkS8U7nxF6r636 egtL/SLmWS7k3XCq4Xk4C5z2rGE+GnScmM5rk7D/AA+9Rt77y+aVFCwL27ssij+kknArzK8+cKjz Q9XiXA3OxXeO/J7V0d+Gp5iLLpLVb/ojXryOzhvJCY5ZewlUkbc+1bZ87vkPuPHnV7Xq/omSAa04 2T27SBY5B/8AhNxPJrphlpw5O8rk8k7hrR4QqjEUY5U/1GgRGK5g/ltgJxtPz816XdF/hYaHYeGG pan4jakLfXVtZJBHDIBFAwH0kuDg15mzacmidS6lpqTi4SzuXt1lU5DqCcHNa3ax5RaeP1FXceV7 D5qX0qwa/ukRNqoFEhHy3xUdJGGO4khlPanulXGyVQRtyw2vnGGrOfcdcPcr3N8k3R2mdJ+AXT35 C3SKW6j9WaRVAZ2+CffFYJ4weWLxf8SvE2XqG18Q7HT9JjlD2WnFZD+Wx8YHenPkE8dNI698JrTp uS5it9d0qPZJCXGWU9ivyfsKw/xc6e8y/QPXuqXHQeoRat0/eSerG8+GZB7gr7YrnxzHx1U5N+d2 6k1DpC71vwlvunerZLfVJ5bBoLmaMHZNhf1Hd75ArzH/AA8rSLR/NJPb8GKE3UMYX+nDYFbY6+6a 8xXiF4QavqfUnWqaClurZ08R/lzNgHP1/FaN/DkvHbzA6crbprlUlSU98nOCc/8AmuuUmOPtjCzy 7d/+e/xW1Twj8CrjU9Iums7+4mFvHOhwyZB5FeZvhj53fE/oeS6lk1Qayl/y4u2LOCO2Oa7d/Fqk ZfATRVVsK2qDOD77a8p9Pb1tKjlTELkgMft9qZTeKcfyy07w/D56su+q/Mtret6hGBeapEZnHspP xXXXn18ZLvwb8D7q70u5ls9ZvpBDaXEJwyEYzj/NcT/hqzPL47FX/ptOD8jNbx/F3Zh4R9Ksp+j8 8+SP2XmufHPLp6PyZMcppy34Y+fDxS6XiubLVdQfXra4YESXp3NET/pr008sPRidG+FUOpzrBLqm s79UuJ4lAZw4BCk++K8M9Nme2e1zJuJ25JPftXuX5U+urHxG8BtBnsZlla3tfyMgB5VlUDmpqY56 Ysvh04Ps/PZ1xqXmS3T6tNB04dRFs+mRv/KWNX2n3rs/zpdFaF4q+WHqK/vYfWFlZ/xGwkPBjk+n B/3rhGy8nPWOmeZYadeafMtjJqJnN5GpaMRs+Sd3btXefnD6h0fw38q/U+m3t4sRn078hZBz9Uzj HH+1dMZ8unG6mO3EH4VmIvGCSL+v8lNv+5xwa66/EH8b9Q8CfBy01bRWEGs3t6LWKdeJIwckstcl fhaW4Hi+k6tuEljNlT/ScVm/4wd2/wDCekoN59IPv2A8ZyRXTHDyy01l9NK9EfiVdY6d0tqmj9Ww y9QwXMDxrLJ9TgkY5z7Vx4ZxrGoajqbxCF7mZnSFRhUB+KdR2wnYFAV3LyDVo4dgKr2zz96z4eN6 S+pQXi/kqucc/wCKdWuntdapa2iAM8jiJQOcgkUKdmWIgLkH/NSvTl+dL1vTbxgGWKZW598EVzz9 O/Hr7e5XgF0Nonl/8vOnPZ2oWKLT11C6MSjfI5QMR/4rlbwI/EP6h678en0rWrKOPQr+6NnBbwZ/ lHcVUjJ/zXYWhSJ4n+XW2h0idZJL/RliRgeBJ6Yyv+a8uvLR5f8ArJPMrp9jPo13bSabqRuppJoS kYRXJzu7dqzj1j05e8t12d+JH4J6T1f4c2vVsenxDWdKuFMt4i4doe+0n3Fbk8susx2flu6e1SUE QWtg87qncqgJIH+Kw38QDqNdE8C5IN6g6hcrbjJxmpzwJQx+US3Urtxot0Mf/iNXaOn/ANcaK8Df PbrPit5j7jp+G3UdMX10YLWKb/mRKDjP78Vh/wCL/wCE1geltD6/toAupRzflrub3aMABRXOXkKL v5ltE44F++SP/ka7O/Frjeby+2aqDs/Nndj+1cuPO3KxOfCYTHTyU0mZLZkkiDYRgFJ7Zp5rt6+p 6iZrmTd9O07ftUXYyh9OVITkhx+4496yTofouXrHXGt3mNvCo3PPtzsrtYzLJJtlfl06dTWfGLo2 Cc+pbS6pCpiPsNwr2k81Uv8ABPLN19+VzCLbS9sezjaAVA7V4s9E6zH4SeNmg3W83Vppt5HcPIf6 wp/2r2w8TNPk8dPLrrVroWySfqHSg1urP9OW2nGf7VnH+XZydyaeBVrEt45muXJ3v9bH9Rz3/vWU dMaOll1XpLwSH0JLmMKCTuA3Co/V+g9d6b6wvOnLjSrpdXhnaEW7RneWBxwvvWfweDvXvhhrnT0/ V2lzWVpezxy28kiEAjcOPsftT8qyzp6PxdeXb2f8U+kNR668vs2haUA1/c6ZCsan3OwcVxb5QvJL 1z0b4t2XUPUlo+kWumzfmEM4/wCbz+kY/wDNdseI/WGpdAeBEmvaUqNfWmmwunqAED6B815i6j+J p423r3Eem3umxojFTI1mhPf24qSeWLhjlljb4u+/Np1LaWmt+HultKrXlzqeRCDllH04JHtUR+JG gbyt6iG97uAf7NXnv5bvE3WetfM501qvVOrSalcz3LM4uG+hCSewPYZ9q9EvxFbC41Pyx6qltBJc Ml1C7CNckKA2SftTe5pbjcLNuQvwvBt8Wb35/KheP2rrLzVaHFrXjd4RpMgdIrlpNpGRwwrlr8LC 1km8StXnRGkjjtRvkA4U49/iuqfM9r0GkeOvhH6rACedkBJ9y1cuL1dunPd5T/pubxm8POmfEXpV rbqudrfR7N/zErrJsUAD+r7Vz5qPk28vfmB0AxdOPBJ/DlMLXOjzbcSEfSZOOayb8QjUdZsPAK9/ g/rj1Zdly0IOBHj+ojsK5l/C6vNVg6+1qztzI2jT25e5KrlN4U7cn2r1S/F55jvG1xn5jfL7rPlo 8R5+k9SQT2d2xexu0HEkeThhXXP4SfTmnDrDq66ltIZ7lI0EM0qjfGf6tuacfi/RRjqnomYKDMsJ Gcc7dxrmfyr9L+LvV/XdwnhJMovLNSZpZZfSiQN7MTxWbJ4+Rjjrt2t+Lp09p3/1WaBqf8Ot1v8A 86sIvVAEoX/T+1eWukw2DWt0zSyteoTsAP8ALNdH+cTpLxi6Ng0oeLUb3SznNtdQXfqwKfggcA1z po2ipcxPHHcKiAlnbP6s/err4uVvZ7Etnc6Pia49G8zuIPbFSWmXmlaToWoQTWcV5dXCD0JmH6TW POkNneMpjFwikDBPf707uL23ZlxD6QX+jPtXKzpcP5Tbsj8MHQ01zzAvc38CzRWthI0McgysbexA rsbz3+HnWHjZ07oPRPR9vM12t0L27uQcRpF2AauTvwtdZQ+Pmo2ZAQyafI6g/Ye1dgebjx+1ny0a 1ofV8Ok/xbRLxBYzQhsMzZzgfB+9Tj1p7+ea5Z4/0aeQ/wAMerfBvT+q+luqmb+RLC9qAcoVIbJX /ar9MeE9rP52df6iuLNcR2f5mJ2AJMmQNw/zU95RfHG68wNz1Z1TJpcuj2bvBHBayvvKgKc8/wBq Z+HHVIn843XGlyXSlY7LCRs3O7cOBXX/AKeXPfldsM/EN6C6u8VrforpvpG2lu7z1pZp44jj6doA ye3t71k3kH6W1/w66C1zpnqqFrTWre+3i3lbLmPb3/ao7zU+ZzVvK94maPqp0htZ0HV4hFJaqQjs VH9DkHH+KznyieKU/jZovU/WU+mSaXHe6hi3t5hl44wvbf70+mb6edH4lvTdl0/5p7w2sCW1ve6X FcTbBgGQ92P3Ndg/hYdHt094K6vfyLkarerMrEdwAw71xZ+Ifqy6n5ndeFvMZ1S1WJizbgpHt/av RfyM3drrPlR6dtrR1aeO1khlWI4ZXJPc/NbynUq/Tzc89XXsniJ5luq2udjro6nT7cL2AUnn963b +E54eWmp9XdUdXSD+dpK/loUx/rHJrkrxf0O8Tx06t0kJI96dQlG18sV59zXfH4Tl1HB074g2shj W8W8iPpZGSArAkfbNc+afLF6cNTjy0L+Ip0h4m+K3X2gdJdEaffaxp8Fh/ELiytm2or+oQHPye1b v8j2sand+CkHTHUsEkWuaM7W15FOM/SxOFNYj5iPNXaeV3xsWHUNIl1q31bTPXQpIEeIhyNuSDxk dq2L5TOoz4g9FX3iFLEtmmuzM6w7cGNEJ71nffTz6+PpzZ5f9d6X8I/Pl4j9MiBLGLUZ/wApYKi9 nJDbB9jWXefry+eJPitruj6j0vLPrGkQqIxpEBI/LSY5kPtzV/ATwR0TxK80PiP4pX8n56DS9X9P T4s4xMB/zM+/7U785Pnc1bwI6/telNA01Ddxwx3l1dSgMsiN2QDHH75rV9t4TLLOTGdt5+F9x/8A Uj5denX6zuPyUujWBF2ZT9W4FiFGe7YwK8TPEPXrLqrxb631yyVl03V9RnuIouzKjE4zXtPoE+g+ b7wAs31a1aG21aDMsSMd1tMMgEds/PxzivFHr7pdOhvEzq/p8ymSDS7+a0inI/5hUnkiu/Hrtz1Z dV6O/hNeIE2rdC9R9PTmWRbS5DwE/pjXn6ft3rj/APER8LpegPMrr946qw1xTfxFe21j2NdRfhF2 0kWl9bGRfqMyYI7e/vWrfxbpQ3jr05GgzL/CR2OMfXXPjt3WOWduG5H9SZUA7KM/FFctFE0acA8E Uq4lWJzLJ9G0ewqrHRNX12R7iy0XUru0A/8Avi2tWdM/ciprtrVs6hiGwxXHt2+KSMRksM59hTnU T/D71o70CCeIDMXvz81e2CSEvLHswfp5rVmmLe17djKhRl2SHsD/ALUv05LRoQxzL3I+2aLCVe9t nlbCq/1FeeKea5HAmtv+SlNxbKgEcpGC2e9cuSdO/Bflt7P/AIeUjt5ZdKZj/wDzE2P8LXFGu+YD rbpzzB6s1pr2qPqEepiO2t1kzE8e7lHA7g9q7d/D4VU8sui/HqyZ/wACg9L9G+X3qDxfnk0yO2uO sY5TKwklI+sH2B4Jz7VjFry1ll0yzzBW0fW3lX6muNbsYUuJ9HNw8TrlYZMA5XPINeQ3ll8qHVPm O63/AIdpEzafo1mf/Xao6n0oVx+ntyxHb716E/iQ+KXV/TnRadNadpklpomoHbcaih3LInP8vj9N bN8gegW+h+V3psWcMUdzOsrtKqAGRsnBY+/967b1NOHrtq6z/Cb8JrW3iiutd12S6YAlhdquWx3A xXIfm58gWq+XqVOotIv5da6Skch5ZATJbc8eocfeuyPEfyb+JvW/XF91UniJdWt1JL60dnE5SJef 0gDgCt5+YDpU6v5add0XVQl5KmlIkxkbAZ0VcnP7iuWOPbV7eJXhL4O9T+P3WMHSvStjLPO8geWd RiOCL3kc/Ar0U6L/AAh+kINJiHVHU2oXd/t+prB9qZ98ZrJ/ws+hrDp/wr6lv44o/wA7damw9fb9 aoM4UH4+1cz+eHzFdTdZeLWoWej3970/pOlObIpBclS7qcF+O2a6/quWV0eVxmqx3zieROfy4WH/ ABBo2pzan0u7iP8AnnMsTHtuNax8s3lW6o8zXVf5DS2Gl6NafXdajIDtUfbjvTTqnzH+JHWXhb/w LrOuHUOm45FaOKaPMxI7FnPJr2I8rPQGk+G/gB0xD0/pyRTXenR3ky5w00zoCSW+MmuWWOW9Hjlj 8q5mi/CP6Zj0sqerNQa/KHLlv5e72OMdq4n8y/lS6p8tmv28GrML7R5s+lqFuP5bfbkd67xuPLt4 +SeKS9U/8Qhrb88JjZi7wnpBs7Nucdq3b5zOkLDrfy09VvrNkpubCxa8gBOfRmA7g+9bk0mW8nm5 5Q/I7a+Z7orWteuOqo7K7tpRHb2CEkxd+ZAPnHFdT+Inlh8YPDfwD1nTdO8TmutF0uwc/wAOO8K1 uAS0a5GO2e9ec/hr1XrfRWtWjaJrN1pzTSIrrbylFmJ/1Ad69oeprq8k8oWqXF87SXrdOSNK7dyS h713wtwscssd47rwjurKXUJbSziQ20ss6Jz2Xe2M12Z1h+Fl1T0d4WzdX6f1XZatPbWf56W0iDDc m3cdpI9hXJjRy/mUlQhWt2WZJWOcMDkf717N+UbxUm8y3l3ntNW2xajFbNpN5dRAEOShUOF9iB7V vnz+acOGuPbxNttOvNb1C206yjdr24ZY1QDJLE4rpbxW/D8698GfCCPr3UtSsboDYZ7BM+rEGGQc 4x/vW3fKj5Zriz85+omKOO70/o+6kaaWbGHVuFIU9zmtxfiV+K7Xmlad4W6bLvl1aVTdKn6w2foA NcJ3lp6NS6kee/gP5Y+uvMHrQXprTJGsQ/pTalcAiGI+55rp6/8Awhuu7bT3nt+rtFnuYoy6wCKQ F2/05245/evQvwl6Xn8M/ATQrHQtEhk1a20uNhYgrCLifaM72+ST3Nc89G6d5q7bxVbWNUt9PGjX tyv5m3M6lYoM9lHyBxn3rn5TG91JjcvTyv6+8PeovCjqe50LqXTDpt1CxSSJlwWPzWPrKjxZjXAy Rz3r1p/FL8NdL1zwateporSJdasrxEF2owxjOcqfmvJuODbBEz4DZJIFderNxxyvYTZ2fJ+9IeTb EPqEbtnax7DFOZUDYC/qJwB80x1L+UixKm+5DZI+M8AY+9cs8rjNxmd1tTwP8snib4/Rrc9PaPId MZsfnZx/LPONwrbt/wDhoeMel2V5cwWsGoyRjKwAfU//AMeK6m8m+ueMWqeAtvoug9Jw9NzWhCx6 vfgRl1PuIm71094V9O+K+n6qZet+qLLU7IICIbW0SMlvjIrPDncsd2Ovi8Kde6f1rpDVLnSNcsZL TUoG2ywyDDA0XpXoTqTxK1iDROltJu9YvWYYSJc8/Gf/AKa9CfxU/DPT5tW6V12xtEh1K9EiXEkf BlIxtz966K8p/hP0p5dPL1ZdQyW6i5nsRqeoXjxgyAlclVPfFezKTwljGM71XnIv4c/jbLYC4Ogl ZcD+S/L5rRHW/h31J4TdUz6F1RpsmnapH+qOUcMPkV3B11+Jx13YdYXTaLBatocU5CQvCNzpn/Vj 3rn/AM2nmNg80Gt6HewaGNKvo41gmYNuLNkcZ965T/ZnMpZppvpTo/qTxV6mi0nozRrvUdTYbfSh U4P963VJ+Hp46TaaZG6Wmjl27vSUDdn4zivTfy0+E/Svld8vtjqM0cMUosxqF7fvGPUbeoYLnv7g Vyb1h+Kd1VY9a3TabosS6LFN9NnIAzlAcY347nvmsfKzcbup04N1/p7WOgdXu9G6ksrnT9VtRteK bjFTXh14PdeeMs0sPR/TF9rbxn+a8K/SB+9b68SOsNH8+fj50paaN08enNV1JhBduZNwdRyxNel0 2lad5S/ASK06Y0STVptPhEKR2sQMs0hyS7Y74NYxu1k1O3kh1H5NvG3pXTJb7UOhr9LCBN8ssYBC j3J9605cyXdtEunJbSSXhkC7QPrJ+K9jvLR5ousPEvq2bp3rHpW+tUuAfSupLIxxAf6WyORitCea vyy6H4beYvobqDRIkg0/W9Wid7ELlY3DZY8+xq3bWGHldOPP/sZfF+y0uw1WXoXVIbDUiq2bOAfV LcgY7jP3p51L5V/GfpTSBqOq+H2o22nxje8jgHAxnnFe2nij1/pfhV0VqPUGpRo8NlHugtyQvqOB wi8cGtG+WDzkab5jdZ1rp7U9PTTbxQfy9o53iePH1A/tWcstJMLZuR44Q2Gp9SX1vomn2c99qV64 hhsYRmRn7ba9QPw4vAfrLoLT9dtPEbpmeygVY20+HU0V9jZO7bx3rVHmf6Oh8mvmT0DrzpS2hu7X UM3jadLHxGoY7o1OeCSO9dkeU/zWR+Z6y1a5Tp+TQDY7dySTiTcT+wrly78sXbjmU48rJ04388Xl b686n8X9U1fo/oW6u9KnAYzWSqEc45OPY1w/1b0zrXROpfw/WdIutJvk49G7HJNeuPmE8/8AZ+BH XWodNv0lcas1pgGeO4CBiRntivNTzI+OUnj/ANdz9Qz6eullxiKBTuK17dZddPLyf7apE5d9r/UQ OcVcyEckcdqRhFlYo3/3TVmlyyqBkN3rLyq1NAiRurHPBYfb5q1nDqfU062mlabPesDw1vGSp/vW aeAXg9q3mF8W9N6KtAEMretduzY2wr+rB/avYjUdG8OfJn4QQLY6Fby2sBEaqYlaa4kx3JI+1eaZ ZeWnpnHNR4raj0d1H0zZepqOg6lAJDw8kZ2CoZ9RMAzMjA/1ADsK9uPBvxd6I82Oia/olz01BZxw oFltpVXcwPupAyMfavNnzl+XBfL/AOId3ptmok0fU42ubF2wWCZ5H25r04XftnLHVmnNUQuLwO9v YX9zEP8A3okPpj+/al6ZaaveXAW20y8lkQ7vTEZIx9zjmvYzyIeHHTnUHlL0zTNQ0a2uLa7llScN EN7dud3f9viq1bzB+Cvls6qtugLrTbS3s7IYl1AwJIUZjkAnBJ7/AO1Yty26WSPHtbG/v79xJbG1 nH64XUqFH7GmJjujJJHDbzXRQ49WGNiv+cV3h+JJbeGvU+h9O9adFXVt/E9Rl9KZ7PCK0XyVHY/e utfI94Z9N3flR6Yhl0exll1C2lFxPJbo0jFsjO4jNLn3p0mEmO3i+X1C4txFFZ3styh52RlgB+4F XImiSITwzrJzkOMEf2r2Hi8UfBDyt9Tr0DdQ2jPJKZbi8ltlkMUh7qcgnitFeaXwD6U8ePHHpMdB 3dpK+vhWuI7IqqRxryzbRjHFW5anbjr5PO2C9luVkggjb1M5DemW4/sKPElz6ZE0NxbuOzPGyg/5 Fe2Ok+GXg15NfD1ri9srOO3dwr3V3As0s0n2BBxTzVOg/CTzeeGsr6Tb2E0BBWK6tYFilt5McZAA qy9Q628SRcehDK8wdNnBA74put8s/prZCaZickqpwB+/atl+PPgzqXg71zqvTV4vqPZybVdeQynk HPvxXqN5YvLT0Dqfli0bSbvQ7eddTi/MT3LRj1d7DuG74FaylkSSV44xXc6T7ngdip/SyEjNFilm aSSWePCsc71GAPtXr5pFp5b/AAa6jg6HvI7NtahcIZrmHerM3YFua5c/EX8Gej+kr3Supulri1jh 1GX0pba0YNHjGcjHFXCW+2MtT04sWZlbkE57U4jDA5/UO+Kar/IuvTXOOAD3o7NLFMEbkH3FLNVm euxJZiWJ27R8Ckxuz4YjH71ZI45Sx5BBwDmlIcHA5rK7WlYKk24cKBwPet5+STy9aF5jvFa60nqG 5ubbTrG2adRZvtd2HbJOa0PMu64IJ+nHNdofhOFZPGHXZFGQbJ9p/uK8nNn42R6uCfG11Lf/AIeX gjolokuofm7dHO0ST3ABJ/xWDeL/AOGD0pddNTXPQU88eqqu9Yb2QOkvGcLwMGjfiOatqdjcaTHY PdpmIf8AKJCE5+3vW1PIL1B1Vrfg4IepjO4s5QlpJcA7yhyTlj+r2/aus+jKWx5H9U9Ear0J1Ld6 NqVq8F1ZSFJo27ow+agrq5jwSzqoUnPNdf8Amv6E1DxR8zmqdP8AStsbvUr68MLrGOA2Rks3tx71 0f0B+HZ4R+FnSC3fX0o1zUSoea6uZfRVG7lVAPODWsrZ6Yxwkjy1WVFt43Qo7t7p7fvS/WZgMKS/ x816i+Jf4fvh34j9LJq/hrLDplwsBMMUT74rh+4DHP0mvN7rDoLU+kuo/wCAT2Mh1tbprUxY/rzg Y+2aS9brFxvl0xthJIQqLtBXeWJ7UL1LcMwRpJCBkj2zXfvl+/C+tP4Pb674n6pJDJMgkbSo5MKg PP1Pnitw9SeQDwWvunrxOnFjh1KGItG8N2JTnHuAa53LL+nXxx08r44WjVWfiNhwTQJr4LjMZALY 3E1nPUPhB1FfeKMfROmxG61Q3HoRhP0jJ4J+K7g8Lvwu+nND0mO98Q9d9a9kx6lqjqsSH4D55pu3 05+Or2852vBG6BMuW9/ai3Nyixu+PqIwBXpb4ofhtdIXXS02oeH05TUI4y0cRcPHNgdg2e9cAReF N1d+Jem9Ja5dDQHmvxZ3M84wIhnG4/Fdv+NrGu5K2f5C/ALpLx58SNasur3k9DT1Sa2toXC+qfcH PetpfiB+CPR/hDdaCnSulQ6ZHeQFpoohySCRn/ArcPQn4cfSGlRR3Gh+IFybpVDPc6fMCSfuVbtW g/O94MX/AIT6toNrcdQXnUcV3CZo5rtjujwSNgGex5qcGN5M3XlkmPTkf1nROFMYzjcaVHftblSp WR84we1bx8pXletfNJ1br1nqWuto1rpKrIY4k3NJu+32p95pfKo3l06ggtbe7a/066iMkFy6hS4H cEV0zxs5Li886x3WiLi/EjFZAElYZIXtim0Fx6hb0iZ2Bwcdga335TvJvf8Amb1C/vbzVJdC0KyA zcLFvMz5/SKZ+Yny5Dwd8RIejtOum1WaTasMsa7GZm/SCB71x3prvXTStxcqgWOZSknsKZy3ZYFH c/8ARuOa7d8K/wALrWupenE1frzqk9NzzYMdnGqyEIezMxI2n7VIeJ34Y/8Awl0jNqvS+uydSNEN zW7IASP+kgnNXHK7amP24RjcrHvY7tvbFDmvJXChs4+PipTX+l7rpbUZYLm1lt2R9jo/fPxioyQB nO3gD5rtZWPZWW9JiRwexoZT058E7lIzn4NGkcMiKzDApoLDUNe1WPTNKtJLm9kKrGkQyTms5ZY4 zdMZasb8FmXfkqcAUtL3Ixu2v8fNds+G/wCFR1N1HodhqHUnVUejXdxEJGs0i3NH8CnPiZ+GRrXR HTk+p6Xq56ieEEmFI9rAfIHvXPHOZemrjZHE5kxErk/3FN5LuYLgJvL/AKQKktf0STpuWWK7gkju kcpscc5+MVtjwJ8mfiX4+yfnrS2bRtDzhrq7XZx8pnv/AGreWXjO0xnk0PNMrsqSj0pM87jxS43h fP8AM3ewIru7V/wn9Z03RJrteqRdyxKXMJT9X+9cXdf9HXHQ2tXmlXMZjkgf02BGM/erhlubWzuR j0kuwYbtVkuIyhCyAyDkr8VurwP8lnif49ac2q6Tpw03SAcevfH0y4/6QTzW4tQ/Cz660bR7m/fU 7eV4ULtGhBLAe3ep+2WtZYWduNIJY5wx39v1fajBgVyHA4zg086v6Zm6R1ebTpLdzco5jbjDFgcd q2/4V+RLxh8YNLi1rTtJj0zS34V79xE7A+4VjUvLN+yYXW2jBOHztXcPkUcM8e0NGyk9q6P8QPw6 /Evw26dk1i+WO4s4jmU2jiRx/wDig9q0Po/h91L1h1VbdOaBYyXWqXDCOONhjn96k5JTwtRDyMfp 3qCO5oW/6WLOrle+PauldN/Di8Z5Lo2Vxotql+0fq7zdD08fG7OM/amnV34ffix4f6FPrGt2FubK MfV+UmEhX9wDWpnNs+PTngzKYQ6/UM4BzS+lNA6p641WSz0HQ7zV5QcAW6nH+azbofwD6z8W+rG6 Y6S0gXWpwxGR/Ul2KqA4LHnAr1Z8ivgB1J4E+Hs+kdU6fYQXZf1I2i2yPk98uOa8/Jy3HOY/T044 43Df28ieoehOo+kpYhrunrYvsOYXXDf3qLjuBLFtTJC/FemXm98oXiD4udVXWqaFY2ckH9J9ZVLD /wCNcB+IPg7q/hTcG31lBFcxsVZF5wa9mOq8V3jd/TCt7c/Tx8VeMgoeCPk/NWDHd9a4BqlmC5Xb vz7A1LNdNTvs4jYImT+k0VZzj6YGZDyT7ZqLu9XhhdIiPTXGS5rL/D3wt8QPFqb/APdvQLi/tU4a cIRHj9/ms+cx6qzG1D22ry2twr2uUlT+tDgirXOoTXs3qXDNI592NbX1nyheJ3TdkdT1fQ5Le0QZ JQ5H961NremXukzvDcwmNl5BPtTymtpZ2G7E/UEP9qStzIjcRnH3qW6e8NuuOpdMGqad03fXWnMS q3iwtsJFTukeA3iHrE2yDpfULhyeG9JgoP70mcy9M6srDFuJXchoWX70SOVgGDI2ayvqnwo6r6Fj Z9d097MAYbcOUNQml9B9TdU2/radomo39mOBdRW7em3/AONVtWY21GO4TH8uQj3oq3WEGYztPzWR WvhB17cAWtn05qM7H6cpbsw/fNNOofCTqrpJUbVrCWzUjLmXjb/as76TViGefIwiE/AFIS4lGVSB tzd80nRum+o9fu5U0fS77VHj+jfa2zOo+xI4rJl8IuvIow8+gX9nxkzT25UL/ms45y3pq42RjsUp Y4KkEe1KT0y2OQ2c5FXv7W909miuiRKnyu0mg6VZ6nrQaWy029ugpKmSG3ZowfjNatkuq5y79HCP Hu3gEjtg/wDeib/QVmjH1Y96dQdHdT3LkW+gX754Jit2fFFfoXqLTg0l5pt1BEv6vVhKkmrj31Gr LO6jop3Cbn3KW9896P6zNHjcWA5ANAkkWVmAQoyf0n2qlOffHHata17TfWxQBIpBUZ/70pIFjQYf H2FD9UxrxgfBpKzCTBAw/wAGpo2O6xsfrRZGI/UaFcXbWse4n6R8UoPu3cZIFbc8nXhRoHjd41Wf T/Uyvc6UIWlkhibblgeBmvNy5+Dvx4+TUMOqLcRKYYGaQ9zilNfXs8QRrFwOzZU5Neya+UvwU6Ft kkk6bgtY87VaSQnP+9ONW8rvhj1poEv8D061hnIwk8J3bT9x7Vy4s8sr21njJj08YhePHP6X5aRS fnuKsPU5L5U5/wBq7M8efKQvS5uXsWJuYQWdQvDD965C1WzTT7uSCY7RFkFWPc/Fe/LG44+d9PFh bln4mMcuw9ix+adeuGj+pcD4oMEjX6IsNm4A77ec0dreW3DmS1aID/Ua4zKX09Fmg4pRbHe6BkPY U9jis5bT1wH9Qn9J7Co+S5t4gBMwjY9ix4pUV9Hc5jh3y44OwZ3Gs3PHG9rrLRbBGGFj2LnuKTNI wjKd8VaKa8ELQG3eJTzmRMYoXrwoBb5HrkcMzY211ueMm9ufe+lrdpC5ESKF+AMk1ey1O80q8d1h OPcYp9oXU9101qKS2JjupQDujaMOP3ompa+NTu2uJ7MpLKdzhV2isTPGly10NNq9ldWxNxKLd5eM S1EG0tILkTWKyzTjs0IYZrNfATTOjdc8WtBi66AGgyylZgGxtP8ATmvSbxZ8P/CfpHw/huOlLXSG myFVoZEkYrXLHWeeo9erMHl1cdT6+kSrd3V00JGFilJ4phLIZoy5I3E8sO9dBeYHSunoNAhu7b0l u2HIjI/8VzdbXUHphJNzN/016M8dTVefDOXIdZQoZfTDZ43GlwxJknYCfagLe2zEglolHuwxmlLe QDkSYPtn3rn09etnD4LHO0nHb4pqVdEIDFUzztqo7lHZi6Y45JNNry4aF9w2mPvgNkmm8Y6yTREw RVBXcAO3xTF4xvMsV01tIvO+JiGpw9zFPhjuh3cYI4qxihicLlSzdvvU6yZmWqndK8T+ptOsPy/5 6e7hxhWLcioO56puuoJX/Mb3I7+p3pAbblUO3PbFIeV2DoVGFGcqOa7Y56mnK4zK7q5u3W1mxuG5 cYHfNSmgdba10ZaQjQta1PTw3MkSSYXd7ng1DfmbUR7mVgW/q+KIJYkhMvqhUHya45YzK+TrPWmd T+N/Vl0gkvppbzsA8hyT9zWJaxqFxrF28sztI8vJ54qNbUYbkHbIxRf6vaiNcj0w8fA9iPmuly8p pzmGqXDbxwqVEQ47ZpMUrxtnG0Htj2pMlyhO53zJ/p7U3k1OEXPpum0t/UDkCuVkdvo89NV3NIMK efp7k/erIkbDcQd3tn2pvDdxzOVUn6f6j2oaakhIDIQo7sanjLUtPJoMEenMIm98ZpJjYsN8mcDB K0FNTtpmIRR9zSkv0YNxhR74rePXTEghhhRiQXI/0k0ZJNqkBn2kds9qbG8RBucfsPY0oXOyEOSi HP8AqqyxnWkp074gdVdFTNP03r19pEmNsoicjIrLj5iOob8IdZkbUZl/95jlz+9a9a+DHIIweC2M igvtP8tHVX75xXOT5bTxZr1P4z6/1PaC0V3s7VRjCnG6sIgaV5yWjYg5y5oc9xsBEgEhUcAHvWS+ HnhF1141aibTpbQ2v5LUbnUPtGD2rtlyf2xOLvbHlvPTSVUiDljjJ9qpUVtrTbycf0HkVtnXfKb1 z0bA46ltxpsmeI92cf3rEdS8L7rpyL14kZztyWJ3DNJjb2tymPtjVuY0lLr6keffPNOHuCAdl1Pk 9xmhWt47ySRGMI6/qb5oyRqWyDms68XS5bWsp72MmSJZJF9370dLy7uhhLmRGB/QTwanOnfEKLpm 0a3ewS6Vs5LDtUZqOq2F/M8sERgmk5AHGK1NT0ty2BcSaykJ/MTTRR/Iaou6kursx7mYlP6zUjNq JKrGzlj77jxTCScKwYNjPYVbltyk0tDeXls+30i0J5LE80+tdcvLBxNBNMCPYMeP96ZfxJQo9ZvT PYfegNcxsCd3Fc+pdul7mmVR+LPUiRCCPVLkw++G5H7Uw1bqfU9YYfnLuS5hPf1jnNRNrFK8ZcRj 0+2RVmI5G7Of9q3cvLp5/wBUl2HGXs7gtbswDHIWIkEf71NWPih1bph9HT9TvbULwVLcYqFlne2E bxqGIPendzqR1REAVY+PqI4NZxx13HeyWapet9Ua5roaS+vXnUnsScVFJO8JjVUCoOSB2FOI7aT1 BGoDL3PNIuFMYcgL9Pvmum9sY4yEpctE5dYwWPBJqrrT4bu3E0jAuDn6Tgmj2zC4QgIAx+KuLBgx CsCW/p71yywmbrMtHmj9RXvTpQ2d7c27D+qNzn/vWW2nmC64s7J7Y6u00fZA7ZOPvWFw6W9uheQb V/6+KavaSGXftGwcjBpx4TD05ZTySHUPV19r2JNQ3PcA5Eik5p7p/XuvaZZJDZX08MRHMLtlTUZH GjvG7nbj5HBpN00Elyf5uOOAOwrpLpnx60mLrxC13Uv5N1whGA0fArFLuCS7lbajiUHLSxkg4/zT twEA2yFvj4qo7jbu5I3Daf2pe+6YYzFPaR4pdU6JaLaW17dSwrgJGz8f96dar1l1NrkO69gaEdwU PesTIJXaGK8cYPahXetyWQCJdkNjlmbdg/FW8njj26686NOk894J1uJYLheQyMQc/FZVoXjL1t0t Cv5LWb9GT/22kyP+9Yppr3eqOqxWk9wG7skZJNSq+Huu3BMsGhX0oJ4LKwzXnxuGWXlHW5ZYzVbI i82HWd5aot5BbXpC95RlqxzUvGPq7VnkmhvLzTnbslm+1W/esXvugOqrH+Zc6XLaoBkAg4qHN1fW bbJY3RB3Br15Xyx1Xl3Nth6V4+9aaZD6VzqDXEa8Fbok5FZLYeZS2vrYwXujOt5jAuIRhDWoQqTL vDoCT2Y5NKFtKgBKBMdgBxVmXiXj8mTa9q51q6km/MAFzuw3OPtUPIrcmX6hjutMWIUAbvqJ7KM0 5soprqcwxq8r/wBIA5NMrtvHDx9KjEUiNFIoKewNL6e13Xujbt5+l9cvNIk7MYH2in46Q1FYXu5Y ykQ9jwf8VGiBgWRjtz74xXDLCZx3xzsmm0umvNl4laO6xah1LqF+R7SSEq3+9T+pebq/1KMJqGjb pgciZO5rRp3K+3dlMfqK0iYPHCn1ZHYE963jjMJ055TybeufNL1xJOktnrmoJaqMC2kf6QPjGaGP M91O04liu7qG5zn1LdsH+9amvbyPCQxRzTykDaIIy7E+/Apzp+mare4hj0a9gkbsXgYViZT0xeL7 be/+yu64AYXGoXN1GeNlw2RUNqXjpdavIwv7Z/VPOV/SKw2XoLX7OMCWxKqed5bmoiawuLZ8SgqQ fcV2xyyxmozccbe07rPWd7qYP86RYjwIh2qCnjW5H1gfOfelbAWGTzj2pYAc4z3rll3dV3xknpfQ Orup+gNXW86b1WXTZj3e3YgEfBreXT3n88XdAhWzudYW+jAwTISa0TseObaFzuOARQrqJDlCgBHc 9s1wnFrLbWWcs7dG33nSPUUOdStLiK+By1whwS3yOaYXPnP6rEfpWupXdxagYEUzZGPjFc/Rfl2j CMg9MHnNJjsYY5y8X0/HOa743xcLP6bl1fzHX2vRrJeW8mcZZV9vtWR+Aus/8UeIMPpKwhlOef6a 59ltfUkUFztCkk/Nb98m1g9z1dL9vq7dhXl/J58pNO3FhN7emHTGniDS7M5yNvsazuw9RkXBx7c1 g3TVnIkcCiTeqgd62JYxRxxje+GPauHBft6eT0MLRrgYEoXbTLUV9CFhu3H5pw0UR3MZsY7AUz1Q RpZO4fcQORX0o8GSHtZRFZzyHuAcf3rR/XM5CSrye9bonlMWiOwGD3rR3Xs2DL+1fT/Gnb5vPenO vXLn+YpPKscGucuvWAllBNdA9cs2+Y7vc1zz1unqNKHOMDIP3rtzPBxTeTXwfB+2e9LSmySMxCMM inyIQAe32r5OXdfcx9B5JNKCnK7SfvRNgYgHnNKkHpgjsTRr6ItwWL7hwO1LKgg+s20+2KFBI7Ms aj6mbBNHcJIDkbmU43Gh9ECVJHePGNoySeazDwUZNU1nUGYFFiQBfvWFxwg+qXOwYwWraPgx08Gu ZZUkDhVzxxurpx+2M7qO9kGxfpBxV2XPb3q8zhHAzj7VdXUjIHb5r3vJoj0Qvtx7A0oTBWVfnjNJ Z9zc0NwQwP3ogjtmVgMnFEimKn2x8UD1iMkkAfakGQqcryfagdSyCZt3bFXjZUHIBpos+JffJ9sU 44xjPPxRYXI2FLAgkVZxtwff7UgqwHParlsgktRdrF+x7Z+Kvnn4oQcsSAPp+aJH9KjcefvRlZk5 Dd/sPekFWz2GPijhhkZ4FWk2jtVgQELSN7cVYwNMQBLs5pIkOTnkYqi2FyeabBJVGTjH70AOFJQj JNK2sxABwPvSXTBx/UPemwKXgnmm8jbsHsPfNFlbcSCuBQrlg0aqVJPwDWgk/UhYdqbgr9QbO49q c5AXcq7cDtmm5+pi2KuwDay5/wC1BM2xsqODR5nG04OP3oW1c8Co1ov1jMmR9OO9CVvqx/3ogO0P xwaCw34AU/5qi7oxbgd/mrJ9IOfqI9qJINuATkjtQiwY/pwaiqAwMjvmrFjtznilKT2qgAAcf4oL A4Oe5+1WBxnjg1RGTt7Z+KrIQen3I96CiuTlmI+BSDuYDJA+KuCg3MxLEDAAq+cgZ4oBlShIA3Kf mgmGdztR3jX32+9OQwXj2p7ZanJbK6IitkYyRzQQDWhiJVixz7mhGJocgsXOO9TF9ufYExvb2q6d MarfKzwRLIqDLc7eKlTtBXLH0Q2AAvJrFL2E3dytwD9P6eKn9RaS3kKfBwRUVd25/WDgf6RWL62s X6fgJ1dVDY571t7SozhWJ5HsK0/opJ1NSvBJrbmhMyyJlsg9q8Wd7ejjnbprwYl/moG/UYgK4r/E h0eSPxh0e7VdxmgPb7Cuy/BtwL2JSfrx7VoXz2aJa3viZ0o82E3QuNx+a80y1lt25pdaeft3LIkT Yg9NQOQ6nn/7tRUmtRlApSRFXusiNk/7V6O+EVh4e9Paal11HBa38kSgJELTexas5g6g8M+urs6T J4arbQzfyxdmxAAB4zwKzlla6Y4TxjywF2hjSa2RZVI5WhzaoYype3O72TB5FdmePHlH0fwy6itt X0MF9Eu3wIWGNjn2ravgj5VrLXreLUtVeyawTDGIwAsR+9PNZx/bzWutRWKITzCFR/oCtuH+1PNM 6gntnS5sEjmQ9zjlTXqD1Z1D5d+jdYuOn7nRNPutQj/lsVt1P1fGa568RvAHoW/1uDWemFW2S8fJ sY5AQPvgVPMmMvUcf9UalNq162oNLFFdtgOoBwcVFSa4se0M8W4fIOP84r088GvKJpeoKLrXoLKf TkAJT0QCPtmjdZ9LeWGwvrnRb2wtzfrmMrCvZv3rN5O2cp4+3mJa6iL0NtRXYdvS7UazlN47wGEe qO2BXXOt+W7oiHqaGTpSb8vb3THFq7CQD4roHoTyXdE6D0zJrHWpie2RN+Y/5e1f3rX7Jok+68xI b2Pc6Ftjxn6lIxRortZ5QCVCY4J969KI/Kn5efFlLqy6Yic6lGP+YkxGCexwRzWkIvKDpvRHiLB0 91Ad9rNJtgmAx6qZrpM11HH38RZZpVQxSL9/aj2JkllVWZCWOMJXqnqnkJ8HrbQ1u7nT5IooUEks nqhdw981iVn5NPAnrmynXosztq0Wdr/mMhWHyCBU89Q1104NtOiJL6SCOWEzB/aLuBW+fBTyN6P4 y28z3WvXmnvGcCOA4IH3ra/QHg/01oPV83T3XaNZfl22xSq+wyKOxrqzwv6L6D6dmf8A4UkBkX9Q WYtn9/muc5Ks1Jt449fdKQ+HHiTrvTM90ZE0i8a3W4m4aRB8/ekaaNFlSXbM73Eudm88f2r0W8af Ary1dR9cazddWXwsuop5DJdKLkr9fucY/wDNec/iL050t0/4h3lv0bqDXuiW7/yWkJJUfv716MM/ KOd9oHVLZ9NvxFKpDONyA99tJ9SSSQIADxyDxUpr2qWuvXlrOxCTRRelwKc2/Rt5rl3brZvsU/qb Ga1vxYrHY42SYlmACnG0c4qctNLluyogAkVz/Rya3p0H5Zhri2yK66ldTYVIl+k5+5rprpb8Pro+ z0tLrqu6k0ydlGQlwFAP2Oaz5t3jscRDofSrLpi7nnvx/ENvEMrDIrBdMl+j0nEb7exJ71254s/h 36Ve6VPq3h51BLqM8ALSWjSby+PvWhuifAebV9YbS7+3e1uo29OYMMFDWpnNOX67a1N+eV5AojCg 8BvaipcZlESfqP8AUf0121qf4cfTsHRQ1aDW51vX2kR7dykn2o2m/hv9O32ixbur1stTIy8TEHaf gjOavlC8djipVMTbWliLfGacCRlG71YcY7Z5reE/lRudF6zl0SeY31uH2Q6kq7UYe/Fbe6h/Dpsb DpePU7XqT/1O0MYmiyG/Y1rzm2Lhl7cdxQSsgfKbSMg5oufVUGOaNSe/NdcQfhuJqOkR3CddR296 8fqLEU4B+K1pbeVHXINfPT11Cby4L7IpYxt3D5IrpjyYx5suLLJpmKZIjj1Q0nuPapvpy90Wx1GK bUgLq2b9UcftXVFn+Gs409ZL3q+PT5pB/wAswghT8bs1qPxs8mXV/gvaxalp14nUmlSAiWeGHaYv gf3rr+/H05XgynbUV+bWfV7yaxYJZFyYw/cD4qOluvTY4YMPt2rYHRXgrf8AWl5b2do/oTMB6rOM hTW3erfw9te6c0+0uouo4r0TuqPEkODGWq/tk6pOHKzbl1Z327vURSP6SaLuYwq74JJ7CuqNb/Db 6jt9Gkni6ztXuYk9T8uYcNnGcE1yZfwan0rq13omp2rfnLaRlYtxjH9WPvW8c5l6cssLj7EZmifA 4qma4ZCVIA+aSN0o3v71Z5Ci8N29q6OZxHrV7YbmtZjDIy7XZO7L7imq3UsMbSKdpY52fJptJKRH 6rNtweaTa5Ooq8kgMeAQPas29E7rIdB8P9f6wkH8PtHlZu5A4FbFs/KL4o31ms9ron5uE/6Frcvh PrNvo3SVjcxQKLgjAAXH9zXZvglrQ1zo4S4IZZCrZOa+fly3fT6fHw7x8q8utX8r/jDpMTmLoy9l DdzHETj9q1Zfpe6JqM2lavaT2F/C22SK5Uq6t8V6W2/ma6m/4wvoZvyy6VBdtbiIRjeQGwTnFE84 /gNo3il4SXfVOnW9vp+s2UX503EcY3zqO6kj3+9c8eXLfa5cMmO3mdNASEkcq6HgEn3oRtGckKwA PP7VmfSPhB1J1kLeHTraSZ5x9MKr2P71sW48i3jb+WDQaTbMh59Jp1DEfHeul5YxhhdbaEVWjbYS rN7D5oN3luQMkfFS3XXRPVPhd1J/B+pNEl0i+XkFzvV/2bsaeaP4c9SdUqgtbNyZCMMF9zU/ZG5j crphbM8oYowf/o+KRE8sJAkUD4BreUPkQ8ZLy1/N6boKPFKN4L3AUuP7mtceIHhB114TXNtp/V3T U+nT3X/In3b0P7/FJySGXHdsXZ5Ym/Tnd2AqU0fWntJvytyv8m4BVmPtU7034MdbdX3EUek2rS3D 4CwtHjd/es5vvI946R2pmXpZXGN+0Tjd/ir+2M5cV1tozqHTH066FqE2o43xk+6/NZT054IdRdYa bBNaAxWshA34xmj9e9K6013pdjqGj3Gk6xYgQyRSqf5n3HzXTHhH0l4qS9MRQaT0v+ZsIVDq4YAi uF5v6duLjmV7aa6k8h3iloHRN71cv5CTSrSIzugJ9UoBksBWiLC+m1GCFmQqDxuPGa9KPFzzGeIn TXgxqPTN94aXoknsJLaTUkbMaKQQWIx8E15/QdJ3Goadpq2UTXLsACUH9WTxW8OW77Yz4/lqIWJJ WmwrZ+PikbW9YRuMZPGayTqbwx696HtV1DVelruGyYZFwiFlA+TioO30jVNYQT2yG4yewXGPtXo/ bj9H6aBO88VxHEmFHfj3pTmdSX3Y5qQ1/pHrTp2zt7nVOn7iw0+UZW7eMlSP39qtpHRHUXUTw/wu 1mu1l7RheWNT9sZvFUZLay3ciFw0gHtTW4jk9YRqQoXjaay3qfwr8QOm7Xdd9Lajbr39WOFmwP7V hjanKnqQXcbesh2sJE2OP7d6vnjUuFx9kSpLFkBVwe/OabBtsn2p62GUKOF+T3NN5VG4kEYqbZ9C 8SKCew9qHLKzcx5Vvge9XhH0gscAnCj/AFUey6Y6jvyz2+k3V0qn6fShJqb17amPl2Zv6rnDljgd mNKj9QIAm0D/AHFPbzRte0u1c6loeoxZPLm1bA/vimFu6SW5cSBWH9OOTSWNXC+lrj1FyzHB9jTU NtYPg5Pvinjm6vbcolvJJKThDGmSaTc6Pr1vafXpN/tIwWFoxwKnlJ7P12e1WyyA+ojjbjFHVZRz 6yoT/qNR9jcJIogUPG6f8xJV2kn9jT+R5GKBLWSYtwFRc4rXljIkm6ewcEhZFdh3IPAqStQUKsxI HfioS3trrS8u+n3UCNyS8RNS1jqMd2mwH6/jHb961hnjaxlLKk4o2ck8AH3pwsJK59Q4A4BqOiub lIwvpNIgPIVeacJqscEq72Mang71xgVq8mO3OceVPFDORnj4orTFFGZCF+D2pEd1C8fqpnYc4YDN NH1KOT9ZwAcZ28/4rnlyTFqceQzsrZAP7U1xI7hVwTSH1KKNjsO8E4UtgZNHiZrhdkY2t/7jAZwK 5/snj5NTC2+JqLlVcr60RcnaAT70eGcyriUoVzgMtdheWLygdBeKloH6kWWaZkDokMm04P3FaJ82 3groXgR4w3GgdPTSrorRrJ6cr5MJIz3Peuc5Jk65YXDqtanG4g9/aky2frRHc5H/AHoUTRzBSLhJ McLhhljVjcn6lYYIq27axxtizq0ahA+VFCZQYyhOVobTljVnm2jk1Jf7dpNKit1imUlgEHtQrtIj IxgGD70JriCJXLgv8DOKRBLbywtI1wsLk8IWBOKbiXav5qxFUxGPcr3NNJmdWH05/epATQGPeJC2 ATjbTaS4iulDwlUGPqDsAR/atb6SblJtWck8YX2BqUtOHG4ZXOf3pjbEXcoigZR/+kJxUhZMis8b sHdO7DtU2naVktIL5opSoEqdjntT+CJ45FcDYw/qHtURaXLSEoMIw5G44yKkYbxlU79qAcH6quo6 667PXHqMWZQz/wCqkJARLvxzjGaQL+3iTJlOPnHFCe8XALnAY8HNQ3saVeSCOfmhCb0NzHuaGtwj BwLgOV7qBQJpGVtrkA9+OatWdG80hMhAXCk91pdvPFabg0IdTzlu+aBLOgJw+4AdwOKbz3CuoWJx 6h+aRrew7phNM7yFmTPAFRjTR20jmG2K7u7e5p9bMbpmRZc+mcMSKb3E2HZf9J96lJTJ5TKp3llU jJHHemCJ6EfpxgNFnPPenFzdBiwxkUyeXYcH6T8ViTRacz3Fu1qIiJIj/wBA4NR0aRq2S8o2nIyB R43YnJ5NOLi39NUD8+p8e1Ookm6A00auu6QKre/zVSzwEkrcDcB7HgVmnhB4B9T+NOufwfp0LNdn LBZF4wO/J7VvS5/DF8YRbssVvZFm7kTJ/wDTWPOLZqbcqOrQ/UwV3bsnzUlpfV+saFG7aZdSWE2M FoTgkfFbT8RvJB42+HukNqOs9Li60uDAM1lMGYD7gHNaYeK4tGaK9T0Z4+PT/qX7GtS+STLVLxNf 3Ml3cy+reyZLSynnJ71ayBXd6y+rz79sVUdxEEy8mwt2XbnmlJeb5CrEA9gAO4q44yNXeQt28YKL CHhQcgJ80zug8mdsrxof1KCcNRxL9XLe/vVpv0jJX6u2PenjMvbVt1o0toGgQ5dXhI7N3p3cQrbW qSrOJX9lH9NWt9NubqcwKm+YruCKMnFJdBj09uCpweMc1JJ6Zmkn0/1Td9P31tcwytG4cPuDYwwO a2p43edXxC8a/D2HofVTZW2ioER5Ij9coXtnmtIMgnLHcvpqcZNJa0t2IwcyewzxVmE9plPLqrQx wRxoPRAkC4+xNImN7cHaSPRXgBHI/wA81eWUAAZ3MOOK3N5aPKnqfmd1y70y01X+ERwIHe4K7sZ+ 1Zz8Z7dJvx1GjRGtndCaWIM4HGCT/enaG4i2ywMS2dwU9lz7VtnzXeVrW/KR1VounanrUWvWGpwN JBcJHs2kHGCP3rUsU0g2k9iP25rUkrOOU30Ws936rMXaVn7guRik/kQ0geSMSMeSZGOVP2o81tdJ H6qRgA++aQl4GIXP19jkZrP6sd7burD2zlNpdwsAQAdxJ7cV1cfxMOq9A8JY+i+ntEis7qG3/K/x I5DRLjuvPf71yTvSSQIXJPwTikzgQtsAJHc/Vwaz+vHy2XO+GgEE+qXl1qN2zS3l1I008sp+p2Jy T/mnYWSRBwGJOWB9xSJWXCsBtI/po/5qNIlAP1HjnvXX6082OPe2WeFni3rHhT1hp+u6ZI1vcWcm 4KvuvuK3b5sfxALjzJ+Htn0XZ6ClnGJY7ie7lH1ll+PjNcuWbxpet6+XjPcHvTe5ijSZmhiZMHOW Oa8845O3py70cm51C7hbF7PFE3DQrIw/vgGh2BaxLypGFmbgtnuP/ppVlKAGbkv7/NKaQOpA7nsa 6zGRNj2mo6hZkfk7ue2Zm5aJiv0/5qobzUtNu/Wt7+6M+c+p6rFv3zmkC3cRFj/saWqJtU7iG9yT WphiZZ+SUXxE6mSUiTW79scZ9Zsj/erXHX3Vd67R/wAevmiIxgzN/wDTUcVt4mJ/WPc5oIjG7IGA f0hWya346Z6y9nuka9rujxSxWutXVoJTmSRJW3E/5plbyXQvjdSTvcMDl2kcszf3NE/LRhiGLEj5 qg8Owop+o158pqtY2Rmmn+NnXei6LJp2ndSalYaewx+Xgkwn9uaxLSdUkTUTeXxkuXllDTyMcu4z zmmgKSkKGkXaffNFljCIzKTkjBP2rG7GrqvRjqP8SnoHo7wRi6Z6S0q7GsHTzaIrIBFEzIQxyPfJ zXmciXOpzSXVxNI80szTPIxyTk5waltPsoU5cCVBzt7YNU8QVyY1Kp2AxTD4uXjN7oLguQe/xmrk kpjP1Z7UYREsOeR7YoU84aJdq4YcE1vpew3SaKJ5IiBNxgVn2k+Onido3TkmhaZ1dqVhpU0fptbx NhSp9u9YRGBMMc5H9XzRJyjocbxtIHB4rOp7b3cp4qtt6sTI7ySkkuSc7m9yay7oTx58QPC4XSdH azNoInP8142w7496wZ9VtLFsMd8mBkbxTpIBqcu+2YSADJA71N76Tx0zjSPMX4paJ1RcdS6f1XfL r8ylZLyRvqcfB57VhHWXWHVnid1E/UHVeqz6xq7cNNOc8fAoMcG4nL4IpVhatdXqxLJjd+rJ4FdZ 05ZSb2Xp1z+Xuorh8HYchTWe+Gnj/wBY+D2qz33TOqnTXuTgqDgNWu722a2vXjDhgvHFIaESHJG4 j/audx3dt+Vk06yvfP8A+JtroCXS9YSvqJYBoA2V/fvWuuu/PJ40dcaRNpk3V0ltZyKRL6Lf8xT3 Hf4rRxgWPcAq8+5FKdC0QRAoHzityMXErSL270ho5o5ZFndjIZc4bJOSf810F4fefvxY8ONJXTLX UmvrKL/lJdnOP2Oa5/hKCaITgsmRnn2oNzEs9zM0RMcQOUDHNZuH9N/Wm3fGLzs+LvjNpUumahrc mn6XICslrbNgOPjvWitOshZtE6Bmz+sv7n3NSgjjljG79XsaHMmBEVPAbkV1x6Y8ZRLwRu6mMYBx nFKiRAAJFymcgfFCDFn2quMntTpkZM7sD7Zq2bax3j6ZB0b1nq3Qmpxalo+oTaffRMGjkhYgD/eu rtA/Fb8TuntLSwutE0zWriFcG9uC29v3wa4v+grtNKSZYkIQZJ7kmufjI62+V3W5fGvzn+KPj7C1 tqt4unaSxJa2tTtQj471hXgv40614E9cWXUegxq1/bgqUn/Q6+4NYkpJHA+n4FNXQHdvG7/xWbOt MzGS7bs8z/nU668zdlZ6Xq9lYadplq/qrb2jEgn5OTWkLNpEhjQyDaAcge9DVVbIxz8/P2oixFR7 fIpN2acpNZbjaHl/8wureXbr6PqeztUvdkXpvFN+l1+CRWX+aPzt9T+bG00/S73RbXR9Fs5DKiW5 JLscckk/atCi5zhJFDxg5II71djbsCwjZD7YbFdcZI1yXyuxdLia4eCGZv6goZe1bp8CvNN1d5cN clTR9QEmlF8y2Mxykv71pfSr+PT7j1XUSKOy/f5oN7dC9uDIEVsnPbms5YzK7bxzkx09HLj8XmeK xBHSNs14F5jLPtJ/zXI/mG803WPmb16K51qQWmmQc2+l2rH0oz89+a0+J3uNqG3AHYnPtTxltbMr /wC3kYyOTmt47x7rhdem5vKz5j08tXiFFrs2nNqMMkEkM0Cd/q9xUh5y/N9eeaa40q2Tp6LSdL09 94n59ZvscmtByTRhwfVIBOMhTmjXSq2xI8tnkkn3rMzky23q5GKuYHJXI44zQVnEm4djUlqcVqln mJmNwP1Y5BqPU7oxlAq+5q72zevazjAx7VeIgjJJLK4wvtj/AOmrPyvY4pBUMPcH96ljcy1XZflK 8/up+BdnD091Favq3SaSEh4+ZYf2zXU9z+Kt4OwLPcWel6xcX7Lnatqqlj7AtmvJRELQpEhaPBzu z3o0aRKCZYyGUYDocZrGM01nrLtvbzF+b3qHzIdVG7vrh9M6es5Q1jpQJ2qQf1sM/qrp3o38Sjw/ 6T8Aj0ncadqUvUC6fJZJHDGDGzOhXdn+9edGyKUqTCSByOe9Wlw7jNsE+SODXU38dNs+V3xjsPBH xd07qvXLWaWwjmaSSOLlxlif/NdKedTz0eH/AJh+hdP6S6dsdRMz3aO9xdxbIwMjI7/auEp4YzCV RHAb9QLc/wCaaQp6TKVQxKpDDJzyO1csMPHLa8l85NpfrSGDRerL9LS1MULOpRQPpPHtWzPB2+bS ej+ptXkthIEiVQx9jWOHrzp7q62Ww6htfTvI12LexcYPyakuhOjNUsdI6gT+M2x0Foi6ZkGX+2K7 YuOd3pAdYI81pba3bR/mLdgVmkXupPua6o8n/wCIjL4O6XbdKdXr/Fem423RXkZJmizjgc9v3rkj oXxLPSXr2l1aLqejzsweJh2HzWUHQfCjqJDd6X1OdAnl5kt54DIA32rnZ3sxy1NV6ZX3nD8tWr9Q p1bdadb3Ou4VxevbA3A29uc9xXKvm688Nt5htf0jQtA0qROm9JvUvBPIuJ5WUj/AxXPOveXi8g0S TWNM6msNUtUjMw2YUtgZxitXxXN4LYrNE0Ezc71bBx2xXO4XKdtYZTHLcetXjH55/CfU/Ltd6auq zzanLYR24soVHqLIEAx+2RXk5pd/M35hgpjeSQuN3YA0wWKMxiOWISOpyH9/7n3p7EwWHGPqzkHN d+Pc9pcpPSY0PqK96b1yx1WyZ1vbOVZkk/1EHOK9XPL/APiD+Hvi/wBGvpHiJPZ6PftF6FxHdD/0 8yYwc5PvXklEHl2ooLknAUfJolxo09m224KRg8gMvIFYyx1dxby+Xt7KWvmC8t3l60jU9Q6W1PSt 867ntdIYM8p9lH2rzw8w/m+6o8dfETTeoY4YtMt9DkLabbwk5AznJ57mudZEtZIzD6kYGeSseDj4 B9qJCiLHujLAHgAnkf3rWE1HK5/KPXjy9+evw98ZehR094gXFto2prbCC8j1MgW90MAHknufis10 fxb8v3l66b1i86f17Roobg+tNa6dMrySsOwABrxUURhVWMhXzy0v1f4pzOzxRNBGYiHAzlOR/es4 7+3S5Y/Tcvm48ydx5oOv014wJp2iaYpt7K2B+qRM/rb710N+F74l9H+H3UnWWn6zq9poz6jFE0D3 sgjEhHcAmuCoEjs1Znj9Ynj7Y+KGmmyy3C3cdtOlqh5lyRj+9byvWozMutV6Q/it+LXSXVXhloWk 6Lr2m6xefm1kMNrKsjAD3OPavNZbKWCwWWRfT3scoPcUa/t0uroPGjmMfqaZ95I+1KXZEhQMzRnk BznFP+LlfZ7pN9pNvp11FewySXRB9EoOxqV6U0XReoraXTLx57TVWXdFI/CsfgVjUQDfzGAXYc8V kVgbnXtJQvew2TwSblbbhyPYA1nVrNtl3GQ+EPidqvgB4raRq8z3Nlc2U6if0uDLBn6l/uK9brzx J8GfOL4VfltS1i2trWRwwhuZVjubeT/UAT/vivHrWupbrU4oYb8QXcsKFVnCYYj7mmnTF7PYSTTN dPbApt2RsVzXHHGzp6fO5Td9vYTUPGTwd8nPg89hpOu29/NbxsILe2dJbmeUg7S4GOM15vdD+aTV tC8xdr4na2ZJobi/FxewwH6pIs42j+1aOnafULqW5uLh5Zs4j9Vi2RUlpOjwX0E89xdi3eFNyhhw 7f6RXp+jHLveT2h61fwg84XhdDZ32t2c1pcqssMscqLdWbEAkDP6T7Go/rHxm8NfKB4IJpmlaxaX VxptqYbCyikV7ieXBwzqD2z3NeM+nXmr6Y0j2d/c6fG3dIJioP8Ag0m+urrVi0l69xqN5+lXllLE j+5qT/bllfqH3WnVt/171dqXUWoMTf6lPJPImchdxzgV6NfhSeJ1jL05rvRdzI/8VE35uJByojAO f2715q3Fhd2TrDewG1m9PcEbhtvsazXwL8btZ8BOvdL6n04ELFIBdwhsevDn6kHxms529NY3qzJ0 N+IX0RfeEfj7c69YWRTT+oofU/O7MKsx7jPzWvPJb4/2vgR422mp65NKentQD21y6f0O/AdvsO9Z l54vOv0x5nej+nNG0HRrqxurK6/NyTXBB2ZGNnYVyUqYaMMNkTLiRW5zTK3Jvj5JJY9sPHzy6dF+ b3QtG1e01OGaa2IMGpWThg8ec7M/FM/E7xR6J8mfgf8AwCC9judQt7ZorXT/AFB6zswOWIHtk5rx 40vxG6x6biS00Hq3VtMs14EEF06oo+wBqP1fV9U6qupLrWdau9UuAOLi7mMjH+5rOM73V31p3b5B PNxpnSXUur9L9WyJYWWvXhvINQlONszHhWOf04966L81fkksvMj1Rp3VmlauLTUHhSC4dm3RSQgf SUx7/wCa8fFid2jKyESL9Idj+n7is1svGLxL0K2jtbXrfVjbINqKLt8KuOAPjFat76axz8b5z29k 36m6P8nnglpthq9/DENMtSsUAYerdPyeB78nvXi34h9XjrbrnqbqdYBDDqmoTXaxsMFQxOAKH1F1 X1R1XJHNrmvXeuOv6fzkxfaPgZqKhuLe21rS5L1CbSC5jkuEX3TdyK15eM3PaY5bttes/wCGT4cS dB+A9xr94Vjj1yX84rNwUjXcDn7V55ecLxBuPFDzFdXX0t2byzsLh7axcnIEYPAH2rsvxz/EB6I0 XwOh6e8MmzqF1ZLaKFh9OO2Qph1Ax3+9eZMxluWaQyPLPcSEvuPJJrXHfuuHJ32tcWUd7bzKXC5U jPuTj2r3M8oXQmiaB5c+hraHS7WM3empLOTEC0rEck5HuK8YNV0HT+iX6WvdQO8XFwklzCOSsYPI xXpZ135/PDnpny/RwdCa0i69HZLbWtj6R3QnbjNSbzrrv4aecPmlt9Jbx66ubTrSG3tUu2j9OL9A INYALLFgLh54wPUC+j/X+/7U5v8A+IdW69c34/8AWaldyGecOcB2PJ/3q8/SWrxOs09p6a+7Bsiu +eOnDfkE7R2dwm1QTjmhXBaUepGwAU5cfA96cmzcuqMQxzjNIaxCTyQBvTP9QI71wylsdePKY5dv bPyG6dLp3lo0RJY2QSl5I939SkDBryu6660vuh/HjWdWtJ5VuNP1R5wI3OTh8/NG8J/OF4r+FPSc 3TvT2vKukJuEUN5EXZcjGFY9h2rU13Pfajq1ze3cvr3N7I000pPJcnNZwxW8k8tx7fRDTPNh5ao1 ins7ufV9PAEzAOLa5wO+OzCsC8jniNpK9BXXhbLerB1b03JNbvG7AGcZP1xZOTj3+K82/BTzk+KP l+0C56e6Su7GTS3mMzRXtt6hjc9yCe1YDdeKfVn/AB3/AMa2mryWPUBm9Z5rQmP6s5wMe32+Kauy au3pF4peHvmo0nrSWLpzre8v9Iu5C0LxcrAuezVgfmL8OPHbozwT1vWes/FiPULSGNTcaOZMM4JA x3579q1BZ/ie+OFjaxRStpU+xQplksQGOB3ORya0p42eZnrvzA6pEep9UjlixgW9nH6cf2DDsRW5 jYz5yV3b+FT4u6VP0dr/AEnf30UGtte+va28jYMseMcff7ViHnM8h/V+seIN71F0NbS6vYaoxmmt sbnSUnLdvauAtA17W+iNbg1rTbySxvYWAjlgfaR/iusOl/xT/FbR9NjsdRgsb2aBQomMAywHbccc mty5S9Jcpe6114r+UDrrwf8AC5es+qJ4LRfVWFbAnEqMe2RXqj5PfFXSPFjwC6fl0aYpdabZLp9x FLgNHKiAbu/6a8k/MJ5tet/Mc1pF1HPDDp1sw2WlumxSc9yOxrHvDLxz628A+pbTVOktTdcPve0Z iYW+dy9jXPLdu2v2+cmLvvrm/wDNfovVt/a6YNU1DTxMxhngTKbCfpwftWE+aePx66X8CV1PrXrG FdL1FxBNpIO2Zgf6W+f2FQMP4sXXX5NnfSLT1EGGxEP1e+OK5z8f/NB1j5jNStbnqSdYrSLiOytx tjA/1Eds11w47k5ZZ2ejjwu8vviR4iWum610/wBGahf6GtwjR3sMRKkqecGvYPrDRtXuvLJqGkNp 882sTaI1t+VRfr3lMYxXnL5bvxG9Q8EvDrTej7jpT+MWtgz+ndQyBCwJ9x9q3Vbfi4WJtsy9BXRl xk7bgc/2xWrMtzUXy3HDvXngv154X6Q8/VPSGoaVp1z9BvLiMhR8YNdR/hWeIdxpXibqvRp1Aw6V e2jXi2jsArSg4BGffBrHPND+ILB5gvC+56Stuk5NJ/MMGe6mlD7cdsDuK5c8LvEvUvCbxC6e6p0w FriwmR5bYNj1lHdc+2anLjcvlfaceX/CPdrpjwp0PonrTqDqvT1kivtYiH5uNiNmVwc/vXj35ifG m76z8e9T6ymRLcWN8qxxxsWRPSYAEZ+cV0L4nfilHrfw+1DRdG6VvdA1a8i9J7p59/pj32kCuA7/ AFFdWL/quEZjJMTxub3zXGbjp5eF7e9fTXVevdReBmia/wBNxWl/rV3pcVxDHdEiORig4JB4rkfW fPF446D1FJo934WafHfxyel6R9XLHOBjnsfauS/LF54+tvL3bTWLLLrvS6/V+QuGLvB/8D7CunZf xY+kdSjiux4ZTy3jAbZZ5Y2OR99uR/muUx8r23fjPLTXnno8bfGLVfDvTNM6/wClLPpbRr+ZXVYC xbd/pbJzXDCqjWySA4U8DHvitt+ajzTa/wCZHqdJ9WJtNEhOLbTwMqg+/GCfvWoVULHGANsY7Cuu O508GOVytG+ieSExAllb/FSXRUFldeJ3TwvCDBLfwq4bscOMVDs+05j+kg/5oDiaN7W5g+idJfUi l+GHvisclkxrtj7e93mN611/w48DdQ1bpO1WbVUgjghGD/JUqfrUD3HtXNHkX6p8cvE3q2XWep+o dQu+j7TKyHUFIWd88on3Fa48EPxTNK0boPTemuvOnLrVdQs4vRkv2cMswHbcpU+3FZxd/il9H6Tf 2UGg9Kva6Srl7mGJVQuD/pwoAP3xXDDOWO/jUz+JzdR2tn0VM5CpG8rk/tiuhtA0OTxQ8q+n6Tp0 8cU+r6AkcMr/AKAxUYzj715zecPzg6B5lrfR7bR7G40qHTlfcLn6i7NjgHApl5SfPzq/l+ifp/qS OXqDpcgejCHxJat8hjn6ce1evLkn68Z/Tjjd5WND9ZdGax011Re9P3OnXU9/FctbhI4mO9g2OOPc 1Ea90trnhn1NoydS6Dd6JIZEuI4LtNpdNw5r1AP4hXgZdw/n59EtWvWXd9dpG0m7HH1bO9efPms8 wM/mG8R01maE22nWkPoWcRO5kjznmvPN5O2WWtbeu3WGjN4veVp9O0G4jlkv9FhEMiHKllRSV49/ pIrxR6o6dv8AQOp59Ku9NvJb1ZTEYo4mJJBx8V0p5QPxB77wK06PpPqm3fWumFY/lZI+JIc9+cHI rri989/l1vtN/PXNrYy3zHLwmwT1B99+2uszuGNjVw724W8nMEvh75sehJOorWbQInkfAvxsADIQ pOcd69bPHLxcl8Huim12LS5tTRXyzRqSiKT3JFeNPmX8wzeNHio/UejRR6RYWDBNPCDJba30kn44 7V1v5cPxMdA1bpz/AIX8YERXVBEL5od0ZQDH1rjk/euOF1O2svlem5dL/Ew6I1OSGzh6c1261SQ7 RbW1uSWb4XitI+OPmTPjD449DaSdBu9Ch0rUYWjg1BNlwSzc7x7D9q3JqPmt8rmgQJquk3emXGp2 a77ZLW0KuX9gTgVxq/jDeeYXzRad1YLGO0sYdTt42Cd1G7C5+a1lyY4zcej8TH59vQfz5dO6n1L4 FXP8Lt5bg2ky3E/pDJSMKck/auNfw0eldTvfHO+1mC3kbTrGF1uZgCEQsDtzn5r0h8WfEvpvwt0G K/6qkSLR7yZbWV5U3IoI53DByPtWgLPzdeXnwW6a1IdI6pZzXDu8xs7OIq88h7ZYqOKZ4+WnHHk8 MbGovxT5kOu9IQKFMxs5HGfjecmn34Tlwkmj9YKv6laPP/5RrifzA+YPWfHHrW812/kbduKW0AbK xR+wUe1Zb5GvNFB5dPEp49bnMXTWsYS/kKFjHj9LD4q8+PjcK3w8sy48sIyb8Qu4ltfMX1DyVhOw 8g99tcnW1xE08kkudz52ye1ewHVniN5WvGC7fW9Y1zTdSmkA3zMGBIx2P05rzJ8ylh0FbeJt6OgG aTQA5MZBJWvXM9zUeHk7sa0VYN+CCfelLElxcmJDsRhjd8UBb+0nSBILZreRMiV2bO/9vikPJtZx u4PuK5aed1z+F0YYvNI0MpBulsJ9ueCRsPavTTx7608PejNKtJuvLOK/gkbbFE6b8ffFeFvhr4k6 x4OeIOk9U6VJJDdWcqtIImwzx55XI9iODXq/0x5s/A3zY9Ex6f1o8Gj3iOHOnXbkSZx+pWA4HJ4z Xm8pu4vdP4ypLpnzT+X7oy9a80fT49IuSNrSW9vgkf2NckefTx+6Y8cuq9HuOn/WNpplo9u8sq7T IzNnj7c11VF0h5XfCFn6mgmsJp7dDIkc035gMfjYeOa82vMP4m6V4neIusazoljFpOmMxEVrCmxM g8ECu/HjYxllj9PV3yGj0fLDpGOweY/7CvJ3zF341rrzWWmlIVryQDBORhiK9OvJL4t9GW3ld0xX 1+yhmgWZJoZZQsgcDkbe9eT3ixdQar1tfywTh0e7lYHPBG7ivZwYY2Zbebmyss0w+9vZ/wAiYGuJ 57aNh6cbtlU57ivcfyWTrp3lQ6RuCMiCykm/wSa8LtQlaNCxBEJcKf2r268rnWvStj5R9EZNbs0t otMlVw8yhlO05G3Oa+XZZyvdM98enlr5kuo26u8XeotUkJ9S6v3kyxPArcv4Yd0935iYhPO8rR21 wI/UYnA2Htk1zd4narbaj1lq00D+rF+acxv8rmso8sXjavl68ZtI6ultGvNLhDw30SnDBHGC+fsO a9HLNRxxly7d1/idTOt50zEXYQG2dmAJx+o/2pt+FSbnHXQcs1rmH0s5x710t1npHhv5s/DC1K6r Z3umXYFxa3ayqssZ+CDyB8iq0r/6sfKH4Zeja3NrYWUalyVkDzXMuOeRyef8Vid60a7rhT8SFbZ/ GKdlIikWIK5UcscDvXoN5eohpXl/6XY/pTS1l4+Nua8g/Mv4zv4v+IGsa/NF+WSeUCOIHICjgf7V 64eF/Uelt5ctBmj1G2SGPQ0VnWUfQ3p8j9813y31KknV08hPHHUp9T641QqXX1Lmb6txyfqOOa19 d67reoaZBZ6nqc99ZW5+iCRydgHxk1O+I90111pqM8c5eEXcgXn9QLd6xmeSMLM0a7tjE4J7ivRz ZTD083HLndH3SPSfUviQ1zB0j01f62YDtla0jLen8Z+KrqzofqnoO4jt+pdEu9HmUbvSu0IZxXo1 +Exoj2Ph51hfflTGt5dIUm2Y34DZAPvzisP/ABVNW0y56o6dslkja4jtj6+wAsv1Hgn9q48WuXLU ejkw/XNX24AEiSHcq7NwzxViSQMfSRSRKm8bAQmSBke1GIDfq9uacmPjdPPLuG8Z+qUMc8V2z+Ep bBvEfX5lH0JbOoP964jcmMuANxIwK76/CP0yNtc6uvd8e6D+UVLgPyfZe5H3r5X5eNuWOnt4brGu 1/GzxQ8Oukr6w0vri0ju5GAkj9WMMqA8Z71NdW3M1z4NXdz4bzWiKbUyWb2uPTCAEttx71xL+J9e el1jpUccwWX8kp257fVWXfhieO8ev6Dqfh5ql1/9srA+rY27HhohnfivVOtLq62Y/h+Jean44dc6 jrCvNqZshvknH17vUGTz2rrXxp8BtI8c9O0601jUdQsorMsy/kZdu8sOc1ojqrqLRfKn5mJ9b1Jx HoPWEYWe4CbFs23d8DuM1tPxx8IdV8ZLDTdU6P6wuNElMe4yWszencIR9JGDxWrpP9sh8E/Aex8C bG50/R9Wv77Tp29Robxw+1/kVzZ130b071T+ILolnNb208IsRPNCgG0yqu7JA9804t/KR4i6TA1z q/jBf2FsBlpXlYgH4NcpdJeLcXgX5t9P1TWtSk6jtrOR7ea8EmS6v9O/Jz271jKzWll7dx+fPxQu +i/D6DQ7DfDNqI3NNGSCEXjbx815f6V4odVdK6jdXWidQ6hpkkuVl9CUkuB7HJr1z8d/DPSvM34U RvoV7b3M8gE1neIcgr3KfauIbL8NbqqK6vL7qHVIdJ023RnDqwb1Pscdq9E8fFwvnMmafhl6DB4i 9YdT9farI93q9i35WN5QDu3d2Pwa6x8xHgr1F4wwW1ppmvfw/T41y1sxIUvk/VkVw75GfGHSfATx m1joXU76OLQ9Yn2peOOGnBwvPsDXZfmY8NOvusfyWq9C6xMk6J6TWUU2xCO+8N715sPt6c9yysi8 uPhJ1J4PdP3uj63rn8YsjIrWceSfQHuAT8nmuB/xAumNNt/F/USB6c12pmd0OCG+ePet6dF+X3xv 1L81L1V1zL0vawDKSm53h/3OeK5A6u6E678X/F7W+j+n2bq3WLGRhJdvLw8Y/r3H2rvJbjXHc8pt 0P8AhQ6heXOq9cWst1PPbWqxiNZXLDn9zUr+JvIs/UPTERO0RWjEkDn9RrYfkA8t3WPgSeqbnq+z htJ9UEYjSKVX/T37UDzveXDrrxj17T7zpmzi1CGGAph5VjKfbnvU/F/x8kuRzdy+Libyg9cv4T+Y bRLtroxabfyGGdWOBIG4ANd/+fzw5tOrvCePXQjPfae6pEB7q2Sa8uPEDo3XPCrXnt9YX8tqtlKr elnJjYHPevX3wLv9O8evLn002ty/xL8xaoLrD/UJFJAz98VOTkt57Z6b/X/imzTym+HyeCXl8so9 QliQSK+pSSKMbVcAgE/IrTHlp0u28ePH3qfrjW7eLUf4TMYYxMoZVcH+WwHyB2raXnH62Xwz8EY9 F05xC1+osY1zhljUD/6K5U/Dx8eNO6Q8TNc6U1W6jtoNaYSpPMcD1lGAufvWM54/JMcd9O2PMP4b 9b+JmlQaZ0vrFppNpjdK0xbc7f29qT5cPDnrrwz0O80rrLXbfW4Nw/J+jkmMe45pr5gNf8VtAu7G 48P7a1u7V49rxzIH+vPx8Y961d0f1f5n+qb6WK8g0bRLWMEtdT2qkA+wA961O/TU7jmT8RjpDT+n fE2SS0VIfzgN04QDAb4rjWNTtTP1K5PNbz80fVnUGs+JGoWfVt0l3qdvIVd4/wBB/YewrRLSS25K jBTPAx2r1e48WUuN6HWC3lmNu0mGI4rLPA3QOtOpPE+0j6DsLi71m1kXc8Cbti54J9sVi5TTp9ME v1Jexn+Z+1dufhD3en/8UdfxySRi/kij9HfgOy5ydteL8jHeD0cV1XWGkeBfiRqs9jqOv+I9zpmr CJUMWlthEGOVUH/et69H9PXXTOhx2V7rF3rk4bLXd6QXOfbiuTPOvY+Iup61YQ9PNeQW+MW0lgxB PPO4jtzW8/LD0n1N0b4S6dZdWX01/rEkhnZ7iTe6qcYUn+xrjw6k1HXLvtxT4/8Agxp175udP05Y EfT3vILh4mHDBiCVPyK7P8wniHH4I+GG7RoYbWUgW1rFGAiwDHBUD4rl/wAfOp7fQvOVppunEcbz 20YLHjnAFdE+cHwyvfEnwxkbSF9W7sj62FP60x2Hz/avZnqyeThPvTga3/EC8TemtWluJb/+OWJc qbe85TvWG+HNxH5nvNFoD6zaxizvL1JLm1QYUpnkVjg8ufiX1Vqk9jpPTtydrH+ZMhjUc/JrJPK1 Y3nhH5q+ltN16SO2vBdJbT7jgKxPua5WzWsTC99vU3xp6/svAnwxaXTbWKBoo/QsYEXEaYA7/tXn W34jXiL0jr8gmK65aPkG3uOVCnvjmu8vOL0NqHXXhNcLpcRuJbUmUogyzAgdvn+1eTDeAHiJ1Pql zZaX01ezzID9cymIY98E11wx4/G2+2c/O5TTpfypdIaL5v8Ax+1rrLWtOhtbDSIkuH0+NfolkJ4y P3rubzAav1v0/wBJ2tn4f6PNc3Drj1bRctAAMKAB81xh+FsB4feIXWnSmuuLPXLi3RYreQ8uynLA H3xXZXj9426z4Pw2tza6FLqFm6nMkY3bj8YxxXmmMuT0W2SRF+XHqzxG6lsL3SfEjpm4tVCH07q7 j/5uTjawPtitD9S+Flh4TebPR73QFWKG4lUiPA+jecsKyzo/zxdWdXX7WWm+GmoX06jcwbMQxjvy K1v0d4n6r4xeaHTzqtiLC8hkwbUD/lhfmu2MxxvaY3d6dc+Y7xZl8J+g7i+s9h1CUFY95xs4/UK1 75RPMKPH/pzV9H19IrjUbFtsnqc/mEb7HvihefDpm/1fw0iu7GJ5zG+x0RckA55Na8/Dh8IdV6c0 zV+qtStzb2165jtC5G6QgncSO4qXW41JNXbVvml0zWvLJ4sXPVfQN22jm7G1xHjBT3T9s11T5MvG zXvGXoCa+12JGmtzgXC53Ofg1zR+Jd1LaPqkVlE4aaJfrAPY1t/8NaRJvBOeRTwZCCPnvXPl4/8A JLVw1OOw08ffPJr3g/1FcaVHoFjOgJEcrM27Hz3xXCXjn4uy+LuryardWq2zSruYYwpPyK2l534b m+8QLxo7O4khUMhxGcj9q4/llv4AkFys3p5KoHBBUf3r6GMxxm3yuTPK5+P0q+cMoI4waZw3otbt GKK+7hs+1OYbG5u+NrJnsXGAf70wuomsp3Ei/UBjFcsr7erCakjeHk68AD5hfFy1s7qIto1i5nvG Iym0c7D+44r1j671vSfLl0bFZdG9NWtqHO9LaGIrD8ZJHvXDP4RmtWlp1T1TptxMqXtyA8UZblwM 9v7V394xeLOleGcUB1bRm1K3lQv6jKpReTxyO9fJ4s7yZXy+ntzkx0xTwT8e4PHO2u9D1/QDZ3uC JIzGWgdfsT71x158vL9pvR7S6hpkDR20sgOGHGM9q6JsvPN0VbXLDTekLl5l7/kYlLY++1a5x85H mfs/FTRIre0tJdPgQhTDcD6wcjvxXp38K4Za3HY/kx0xV8umgWtxbp6R3Axsgwy8d6gvGbzTW/gN 1DFpyaVbS6JGR6jxcMB77QDjI+9bK8uGlfwHwQ6WiJzvsUm5+6g151ed3qSe96ruraNslZCMduM1 v8TC5YduXNlMGd+bLxy6B8X+lob3QmT8zcLiSJwA4/cV1l5MNLtYfLV0nbrbx+jLC4dCow+Se/zX iyty9nKiKCBKwVgTnFe2Hk/VrTy2dKbs7ktWYf5NLyS8t43oxn+KZobxe8yWkeAWvW1g+kRLo4wJ 5IFw4/YD/wA1pPxb6o6R81/UfT2idHRevd3jh73KgMsY5J/fFar8+nVD6hrJh770LZHsagfwwZbS fxuuPXYi6jgkEIJ7/TzXo/Kw/Vx42fby8F/byZT+noHadOdG+WXon8voGkwQBBvc7R6kxA5Yt80T oDxK6X8xvT2p2S2weS3GydHUHZnsQagvNjObfpXeoK4iIL/b4rRf4eVlrP8Axb1deAFdKkCh944b njbXm/jZp6+rGsPOb5bbPpa3eeygHqBtxkjHtXUXkb6N0L/7HnTI20WzzJPIJC0QJc4Aycionzp3 sEXT9+k2ANuAT+1Z75Qrd9H8A9LaRChLPIA3HBxg1z5ct8uOLljjJNl9beJ/QvgBPa2c2kw+hcMS 9xBGpZCf9RxWnfMP1r4d9Y6EuqaTfWUolTDQxhRk/cD3rWnng6m/lPb7gGcMSc1wW+p3djCZILiX 6jwpclT98V9bjwnH3Xj5OXyy8Ik/Ee1tLHXXexJKMScL2NYxHLISAF+ph2rKOh/DfrXxn1OSx6V0 WXWrqMgSspwI8/JPas81ryZ+KPStq8mrad/DXiXcyEhiw/eudymeXxa1cZ20/wCoUkXdjPuDTlX3 txgn5oN/aNpN5LY3CsLmI/WGHNDt5MSqTwAeQKWWJLsYzNEJNq/URg11R+GPZRP5iYyq8rp0zt/8 vmuYLkRBJXU5Qrmuqvws0LeP1zKR302bv7V8v8i/KSvpcE+Fr0M8wdwi6FbRmBpnyWGwH/xWF+UT pvqDT36j1DUVmt9KuZR+WjlziX7jPxW1PEjxI0roVIF1Cx/PuwyRtB2r88ij6D1ppniJ0jeydJ3s SyxoU2omPSYg/SRxiunDJJpzv01F5k+o7bU7l9L04xXN86ejhOTuPsawjoPycdBeGmly9T+IsVtr 13cASpauD6aZGcAcZNSXhp0tcX/jfCNQTa9iTLKkv1bnro7rTpXpzrMQ2WtsrGHlI/V2Hmu15bnP 1/TEwku2pNC8KfBvxN0e6tendA0ywvYgQojj2yJ8Ej4rkTzC+W2Lp68lsoLZvze4emVHD57Yru/p vwl6D6H6hXVdLu0s7sDbtN6MH7EZ5FYB49a3oOq9Z6DFFfQXMyTxiVY3DY545q8WHjbWc7toTy6/ h36daWD9U+KCetGY/Uh01uCifL8d63pofQHl7nkGm2GhaTZ3a5RHK4fI+9Z35h9fvNJ6SggtXKJO QJCO5HxmvP7zMa++htarYlrSUxhjJEcMD+9cf1edt/p1ucxk39p3zI+GmlWvUKaJpS2kt/cPsijg xkZ7ZxWyPCv8OvovpbpmPqLxGv2ubllEjQRNiJFPscjJNac/D2Y9eeYJDrjvqawWUs8ZuW3nevYn NekviD0Nbdd2dvZ3uoLZ2ineYchdx/8AorjfldRcZrtqDTvKx4NdYaJIek9OsfzNuNvrJyVJ/wBd co+PXlotOm9Uktmj9NYz/Na1GMjP9PFdydD+Cmj9DdQC+tdcAt8Za1SYIrn2Lc81AeZBNF1BLWR7 i3aZVIdo2BOPuRXt4eKW6jhyanyc/wDg55ZfLn1TYWK2muSy6zIoEtndTBZg/uMY/wC1bP6/8oPS HR+gNPoUktvMTt2XMpIxj2zXNPhXptmfM1ZpYRRmLeGzGMZ++RXZ3mc1SW0s9NjSTarKWKg8nk1z 4fGfkXB0tt45XCc3gBovVvjdpXSvUmr3FlpOoEq0sDYwRyBk1tbxe8hfR/hVpNveaDNPcxtw4vCG Yf3ArVXmB1x9B6r0G+SUwy2ssczSKeSucnmu++pNY03xd8B4dbsm3xSWyyLJjJUgc1vntl7c+LHH bz16J8mcfjF4l22kNNPb6ImHvJLXhokPuDWZ+O/kh6T8GI7SPp67uNXvJeFgvTlx+2O9dj+WHpBe l+lL/XLlfTkucguwxlF5FYF0Pdp4oeY2RtVIvILdJJI0I+lSn6cCuUlyx3Hq3JdNE+GP4bFn1JpD 674harc6HYvGJ1gtWClV+HJ7Vs/SPw7fCW70i4uOldSl1e7gX6DNKHj3Y4BwK6e8Vehbrr7SY9Ni 1pdJtc5dAoy/tj9qxHwy8Bbnwz1tL2z6nDwsMPa7AqSD7jNc8Md+1t66cBeKHlZS2uZ7Ke3hsLuM kLCBjt2Ncn9d9I3fQV7JbX1u+VJ9JscV7MeZnp7Tr+Sxu8It2i5JXGSMnvXn/wCcXT7SHp2G59NB M3AI7ivq4cON4/J83k5csctOQLS6kuEDsNuef2qppbppoobIerPM+wD5zTe3nEcDRuOScr+1bL6L 8MdV641LRNF6ctDca1fSfygpxt98n4r5/PnOKdvp8E/ZG/vBf8PCy6n0SPVPEjrFemkuArwxRyqo IP7nvW9oPwxvD1OnJr/pvqC46jMS5Cbg+8/Axnmp7ovyXaf0l0zDd+LnWVzdr9Oy29YhYzjt75rp DwG6M6D6Ugu06K1Ca8jKj1FeYuFH7Y7/AHrjx53K9tZ/HuPM7xM8q9t0089s1qdNVFz6Uww1Yr4T eRHxF8Y9SVba1fRNAVsrqNwpCMv2OOTXpV5ielbPqTq3SYLlYwHljRifcE+9Z74ma3/9U/htFBo4 SBo0EEX0jA4716OSbsmLhLZO3GWk/hM9PW8R/N9Xm8utv1KHHf4rTfij5SNG6DjvbWGJ1NtketOO H/atuSdZaxpMt5rkOoXRvI2MgLSkoSf+mtLdQePnVfjT1rY9P6vLG0cs6xkxLjjIrpljOHDyzTHk 8rqMK8NfI719426kF0mBdN0TdxfzKRGR9jXSOkfhHzWtmW1bqtZWjXP8jIB/zXaOsavB4OeEGl2m j26RTC0RUBXIUlRliK5Du+vOpYtVutWg1279SFjIUaUmIf8A4tcuPG8nynpcs5GhPFfyqaP4dO9n ZQzNdA7RNMOJKaeG34ePiZ4tQNNFJaaDpwbO67BBkHyPmtueG/XmueZfxx0fQOoZIntI5iXaFNvC 813z4oaT1XH0vBo/RNvHFH6fpPIWCsqgYGDWM8plfHH3HbdkcCTfhQ6/pWlvPddQQ6gIly1vb53N +3FaK6k8rZt9Q/hWlW7w3RmWApegrhicA16ZeBPQPiT0V1Mz67NJPps42y/mJ/VKj5X4NM/MP0Na P1lo+poiQyzXMSsFGN2D3rUxutvPbblHD1j+FH4oXHpNNrOlLbygHYjH6cj3qfb8Jvq/TLSS5n6g srvYMmK23biPgZFekHiP1FN0V0LJLAwE4iEaueNvHetF+WfxmvdS66vuntTuXuxeZaF5GyUI/wDp q4YWzyrrcu3AFr5K9V6l6s/4Y0A7dSHd736Yx/2ruTyXeTvq7y7atcXeu6rYXMMyY9G0BJ/vUt5s 9JisNShvtIlOlagIzumtvoYn+1W8mXVvUuuXmr2+p6hNqFpbRgs87Fzn2wTXLkxtx8/prevTNPHP y9ax4uX7Ot5ZRWoOUWUHIH9q518SfLFY9BaRPZXc4knePd/LHHPxWzfGDxv6m6X6ku0srr0g0n0I RwAPatOeJHmM1O+6cM+q2f5iblRItfY/F47cJb6fM58pLr7cXde+Cmo9NXM1zYh3tslst8e9a1LT 2isGwefetj9eeNms6409vF/KiJIKd8g1rmV3ucNtwxGcfFcueSdx24LcvZtd37WMfqSxBxjOT7Vn 3hX5fPEvxsCTdMaBJLan6fzLocCsq8n/AIHHxj8YdK0/UEM+lwMZZR3BI5Ga9b+t5G8I+iILDo3S EgvtoXFtFhVGP1EDvXxM+XLLKTF9Pw1O3mPffhv+LWl6d+b1H8vFDjLlM5X9617rflf1HRE/k3xv J07qvODXq54IeJ3XXUmuSaV1Tpf5u0nXCymHYIwO+7I5zUF5kvCiwtnN7YW8VnG6Fm2KBzXvwxtn bx524vKLTPLP4p9So9zpfSN3eWKsR+YWMkGss0HyM+LHVZElpok0SYwysh4P+K9b/KbaPH4QQJNy xupVP7cVh3iz4v6p4d9Qzw6EUt4YG+sSLuV8/atY4XLLxieesdvMXqHyf9feH9k8eszpYx4ztOe9 Y9H5VfETXLGO70HQ77U7I5zcxISCa9CvFzzD6H1V0gi6tpy/nHBUzMvZvmt5+UJkuPBOzkTAhkZ9 rfasc2N4+l4svJ5HWHk48XL+NVh6YumyeW9M8UbqTyjdfdLWy3WsJb6XEg+v1MivU/xJ8Zb/AMOd Te30HYYEO+X1RnJz2rCNV69sPMK1loN7pOye6cGUZHIU54+K143HHypcu9R5i6R5fvEjVLlx09od xrtuOPWtULL/AH4qcXyeeLcitcX3S8+nRnlmnQha9f8AWbjQfAPo1LfpyzisrhwMKQDjj3+aT4Oe LUfjDa6lpGtQx/mIxj6QAJAfj4ry4ZZZdut6eOOueX/qLpmxVZWg9RjyEzkVj1l4ReIl9G9xpnS+ qXtsp2i7iiJTP+K9TvMX4R6D0xI1xp8eJDysT/V3rdXl2sI73wls0FrDCS7Kw9MfViuudutxj7eM tp5ePFvqAKI+mL+aI/qLxHineoeVvxFsYF9ex/huPaVSM/5r1w648XLjw21P8pp9rA9srfXlRWBe JniP0p4g6SHnxDdIu47DjDV34ePPLuuOecjye1fwj6i0jLTS+rGvJVPY1iqadPEswmBWRG9+4Fdi 9WaxpekzXH5S4imWRiCGIJrnrxAutOlmdo3SGRj9QUd675Yac8M7k17aF7mQQoCWOcUuWAxgl2I5 5ApMck9k6SRkIxJCkj2p23qko0u1lPJwMZrhXp6ABCxM4zgDOa3/AOSronpXr7xTtLbXNHi1CN4y xt5+2R71oS6m2W1yqL9LY4rqn8PjTpJvGiFkTeohKg14/wAm/DT1cGPe3oZedPeD3hbFEr9CWkbB c74bYN/vWTaZ010N4tdPu3TtpaWUi8MoiAdD7cVgPjraarf/APorWxnnCx4BjUnn+1SPlk8NtY6W tL/VtY3adC//AC1dsF/3zWfx/wCErPLJ5e2nPGLwLfpyO5kvrgXdvGxGAB/txXHniR0bot27wWEG +754RSf/ABXoL4t30nW2ufwyxl9YSzbGI5qd0zoroDwK08Nc6Za61qskYkdZUUsCe4BPavqcnjMJ Y+dMLcnjpN4aa/JeNHa6LdMwPDCNsf8AaiXXhv1faWks09jNGiDs6969l9D6i8PPGOxksLbS7bRN UJwqLCu4/wBwK0R4meXG8fVZ4LGdrnc+1IjwO9ebDK329FutPLu5kuLRB6sYtZ0Pwcn/AGoum3Gu XdxHdWEcy3KH6DHGx/v2r1t6G8rfRPhfbJq2v6NBqmoyJveC4QOoP2z2qRl8R/CCOeTT5OjbHQZP 0rMYFOf8CmMyzvXpLnI8pZtK67uo991Z3jr3BC4/fNQd802mXPpXyv659tpOP8CvRnq7w6Hij1Pa ab01qlvDYTNl5YkA2j4xW19F8APC7wU0r8zrul23Ud8RmRplBJ/zU5L4dLhbe3klbrqF7NsihaZf +hG/+inNz05rvoD1tLmRTyr7TxXsXpvTHhR4j2BGgaBY6ZeBchRCvFaV628GodD1+K71CzF7pMUu 4wwjYNtb45llHTLKTtxz5VfEPo7w863nn6u0t7lX2oj+kTsPv3Fdl9b+MPhp1LEkOhWUZlZeHjiA P/atkeFd94H9WXKaOnSFpDfnKt6sAJ/uaL4l+EPRunJN/wAOaZa6fJtLKQg5P2ryYTLz7dL3i4O8 TLzUFuZZLaL04AfpJGK1brcun6jbrcSsyTLw5A7n713f4beGWgdS9Rz6f1dD+YLf8kRNt59/3pz4 w+VroXQbZ5tLtBb/AOpZPqFe7LPWo8kxtu481r/bGxEZAJ7E9jTH804zuUZ9ivNehPhB5QumOujc 3XUWnvLZxE+l6TBMU46v8ofSL65FpnStt6Ukh2lpfrC1wud23jLt54SahPa/lpokDMGy24cGhHU2 aUi4iXe5JHpqfevTjS/JB4VdEWSXHXCyyTHlpYpAB/8Ak1kn/wBiz4NajpZvOkrNLmVf0+vgn/Br Ett6bvp5PpFdShjFATCP6gO9VHLMDtaLac4Fdy+IXgtPptxPHa6XBHbq2MxxgcVo3q7w6gtsqYhF J9hivZjw562815sZdVpWeZopEGcD3rqPyTW2/qK6mHYgZI+K5t6j0ZrC42EfSBk11Z5IrBI726cc xtGCDivkfmY6sj6P42s5t3/oNq5EPpyDJHI+9ZpFAxCibkge1Yhoe2NEKtzxzWZwSAAZzyK1wTUd eUdYohjIyKitd9NI3UcbhUoJkJYDgj2qD10rIn0jntX08Y+fkjNQuVTQmAHK/NaB6+c7ZDn2zW+t dKx6G3tkc1z518xaGTHJ5FfW/Hnb5X5F6c59dXKokpzzk1z91lP6jOewrefXRUW02W+oOf8AvWhO rPqmcj9PxV5Xn4fbD0RTJ3oyNv3D7UlP5bBsf2paqPrI+kkV8q+32sfS0DZTODiiviZsYpMWBEoX 2HNKV1LfSRtHzRfoKImKYkEDnvRCyuAqkBckk/NCaIySNj9J5zV1HpvsP6R70Um8jeW2kVG7c8+9 bO8E4H/qlZcjBA9q1hdkAEEn+1bi8I9kNq0jDCsgxj5rrxe3LP07iYlX3MS2e9KH0qRnP7Uje4PA 3D71dSSOcCvc8xSZZvqNU67iMHirMCWB4pYypx/ehpY23HHBPtVhaMTzu44yBxRN53HnmliX6Su4 8n5oaDUGJjjlsd6S2I8FSST3zS/VXjGcj71dNrE7+1GVBhsBJ4NDIPqge3xSpXXG0DikKS7DB5Hv QFJG3Yw7fFJKhwQOCe1WXJYsfjHNUwTcCW2kUCizYAPJFXfcgJYZz7CrKy5ycniipd+jyFD4+avQ a7lZvoUj96uFxjOcUe6unumLMix/IQYpvksBjNQXMoA+D96DLIcH3/aiEAnnmk7iwbIA29ua1oNy 5dwCeKGw/mnByTRHfnhRmkuoJ3ZAJ74qgDsQSP8AuKGSUByKKcBsk7qQ53Dj4oI+Y5JJ7UmHcMnB A9iaJMn1/YUkZUnklfvUjZZO7jBqynLDntVlfmqQg5BPNUU6/Vk8gciknJGSOaIDgfYVZsBRQDA5 5q7/AFduKtjH25q4I+cUFiNxHOCPir7QWJODVKeTVivJbHJ9qCzSKq8cmkfUeDwfiriMqzE457Vc ldvPJ+aATlgfpGGNUjyRsCrYIpW4Mu4c0j3Jon3peSYs285DgcN8UkXl0kJdL0iRe2TjI+KsykA8 5ppcxZiBCZ+49qmiIyceq29zvcnLCoW/ZxLkOQB7Cp2S2XH0Eq/3qI1NAsZGQT81itQLRdxv45HG 1Ac5rbelLsEW3kAjmtMWnqRzRgMSC3bNbj0IOlgm45cYrxZ47r0YZarovwXVhqFuzHLGsC85mgR6 n1j0kzICzRyDcfbHasx8Frgvrtqrtg44FY55zbwadrnSFwxAVd+c/vXl1vp6srvVrKfDHw+6Z8N+ hv8AifVC13sj9SQMm/HHZR7mmug+aa11zWFtbHRkW09QRo7AhuTxxU74V9cdMdZ9Hx6JdmJYtm1h MwAY/b4NMulvCbozw11a61m81uzlg9QukTSqdh9veudlxqyzXZn5vnaXw40yd19NhdKxX4NG8NL1 pvBjXJIN3qrZkqF7528Yph5qerOnepfCkPZaxaTsk4kjEcoJJH271ifl58dNF03S10jU8YkRUJA+ n+5p43K7bxvwrgvQbm51Dq/UhflhdC4YFZP1Yz35rcfh4LWDUD6YO6Nx9bscH7V0f4oeTTpTxE6o l6k0XqG10I3n1zRhxgn4HxWpevuhenvCKO103T9TTUtVLgSNHMGGAe9Yyxv0xxdZdupVuZ9P8D+q Li0d1uo7RnRk5IO3ivNzoPRrnq3U7u/1K4xK8p9UynkDP/evQPwh8YdBlsv4FqkiFrpFVomQlWGM HJrButfIzYdQ9R3Os9PdUwaLpt05lNq3Kgn4I7Vi4Vrknyt+kJ4JdC6ZcdQW6fmVk2kc7if8V1D4 p9D6J1X0bFpGs6s2j6eCD6iyBdxx75rj7qHSrbwa1aysdM1I313C2Z7iKXcCP7V0DpnU/Svjz4ev 07c6qst8V2A8o0b/ALmkmizckiH6P8EfDzorU4r/AE/r/E0RyM3EYH/eoPzL9ZdP33UvSf8ACdTt tRvLbCM1tIH2jPuRWF3PkH1yzuJLg9bWjWec+kwIO34yaxfUvCzprozqOwtNGuHv9QVwbl/Uyq81 2llc5Lt0H5gNYv28s9xdxzPuZVEhU9xke9aG8ruuXWl9T2bQyHdJHhv+rNdb6r0fpnVXgrLo18xN lPCBuBxzxitZ+DXluuPCvWRrGrX9rLYR5ZAXGEXuKTWu3WZSTVa589Vs1t1l01qEQZZLmFUYDjNZ N5SUMuoTTmVsLIiqGY1qbzV+L1p4r+I1lp2iOJrfSZdhcf1MO+PmtoeWPVbbSL1or+dLOQyI6qex pMdzpnH1pxf55Ilj8w/U9s00gkknaUKzEAj4FaN097fTz6bAlx3Zuw/avRrzU+Q/XPHjxFk6r6e1 a3sVuF5E4zz81w14l+BPVvg/q8ul9SNDOmSIpYRjdj/tXfj+Ptys7YbbbL7VAFXaiHIPzXTfhD0f +ctYXRV9SQHCmuVdOnkS5UAbcHIz+9dH+E/WTxWBR2aMopCuDipy70577dm+XHw6MOvfmZ2IETZU c/NbR8ffB7qDxW/JQafqaWljb/V6RcrlvnjvXOPgV406lo2p2Ecyb7KSUI0z8cZ710F469H9R+IP TkGodB9RTW+pw/zHgt5uJgfbjtXD/t6crvVi/gn4MdT+F14fX1OO4spD/MgDk5HzzWlvGi3g0Xx4 uVtmWNJEEjCP/UTzn71jWheD3j7fan6Wt9Q6noNkVJN491uRfscVjd30nqPTnXf5C+1z+PXS4d70 tnJz2+9WROPLee67k0rWYtO8JZb+cA/l7R35HZgDt/8AFeanT/i7rvUfiRfanJfSlhOyKFYgEZ7Y r0RbSbm88Db2DG+SS1JwPcYry26HAt+vNRtsCNob5iE+Oa9GM7cefLWd07PPXU2rRWdq6ATDaS4H PNdL9Qamul+D11fswLW+nmRWb/UBxXHuhW8r6rBK8qIjYyp7iupesbJ9U8BtZt1LOwtG2EDvgVcs f6atlwji/ozxK17WLuXXJtUnab1SsSBuF5+O1dR+Xu/ueqeqJtV1EiW6igKbiO/Pf964p8Lr6KPp +4siwNxDcsGA7rzXW/lm6pt7fWmsu8syYy3FTPGybY4tZbRfmp671qHxJtOn7W+kt9PhtUuGjjOP rJ7/AOK3F4KawevfD+XT9VC3kcSiIu/JcEdz9xWtvNF4T65rPV1r1TpUX5yEwLayQxjLLg/qrZng R01cdCdASXOrJ+UdwZnjk4MagfNc411pzjoMUHSvijrOmWqLDHZ6g0YCjjANdQeKvU3/AAt4W32u YU3dta+pCSezbcg/2rkWHV01jxW6i1O35hub95YsHuM966C8wNpdav5br+OLd6xtS2cc4ArrjvLK bcsspjx2uEtO82HXMepNq9zq0t2Jyf5Mh+nGTxitZ+JXXlx4jdaz6/eQQ2c0sYUJB2bHzUDpUCXt laRlsKqkEffca3L0d4CHW9NS9JDQtyR9q9kswr5+H+aajSUd/Bnb68jOPtRkmSd1G87c/WfcV3b4 Z+QzoDxD0Jr/AFOW8SYnYwtpdoU1xl41+HEHg74p6z0pZXL3trbndDIxywXPYn3rePLMrpM+C8c7 Q9tfafBdNF6Zmi9we1NdQuYrnVAtvb+lHIoQRL7EUH0VgeQgc8UO5Ro5be4342N3Fby9Vwx9uv8A wp0W5vukbBpSCpGFxXa3gFpsmm9GFZCMmUnj3rijwbvbiLpNQZMqi5UfFdneXrU7i/6ScXK7WDkg D4r4t3K+9xXfFWsf/sTtWn62ub+TUoY9MnuTO6Ix3YLZxip7zGeIVp0p0SeidPWT+IXcQgKsn0CL 3O75rSeu+J3U+j+KeqxSa1drBa3WREJT6eN3AxXSvXfS1l4r+G8WrGKOTV7eD8xE8Iyd4Gdp/wDo pN+2f5Y7Y/5XOgh030UuqSxr6jBhGijnisU648TPFnU+qN+i6DqWnaXCxWOKKHPrDPds1szwA62t tb6RbSlQw6tp+71rZuCDWpPEnzi9Q+GfUV3pup9KzqyMQgVN2B7HI4NYvtMemb+J/QWkeOfhBNP1 BoBi1ywhEkUsqYdJR3IPv2rDvKb0dYahFcPexJMYSUCMvGRWPWvm+6z6+0G+/hPSbR2/plZLiROE BHJxWdeUW7SSG9VZFMjMzyA98nk/707nt0w1d6a18zPniuugOsG6X6PiUGy+iaVxglx3XHwKxPRf F3VfGvoaay6usEvbqSQPbzuvOPcf2rU3nD8I9Z8O/HDU9buLSS+0zVZTcwyKhZUBP6f7VnngP1MJ elUMmmu6Wx3PMFwB8DNS5Ws4auXbrvwO6Lteluj21fUrdZnhXdCI0yyIPge5rXmreY7rG+6mkax0 yWHTIZtvpom7KA9z963x4W9S2fUHRUVxY7J3RMNbpwQcfpOf+9c/6/53ekuk9Xv9Nv8Aom4WeCZo nMaKgYjv3HP71xzls1HTOzyrI/Ml0ZpXip4QTdZR2LWGr6TAbuOd48OyLyyZ9wa1d4CeaS6g6DhW 30uGS42hWMh2jFRfi158YurugdW0DQOhNTgivrZrdrqUBoo0IwSMAfetJ+Bd5FYdINbSbi7N9P08 V58JlM+6vHJll09CuoeorvrTwB6pv7y3jiaXSrjAXnP0Nya88fLrLpN9oTSNbI1xZnO49+5rvnp2 4bVPLVrqqCZP4TcJtx7+m1eUngv1n/wt1C9pPN6LPKUeJj7ZNe+3px1rk7esvR2pWHiz4M6rpgtk mkWzktijoDlip2kVxn4QeGtpo2oDpnUNNSTUPzhi9Jx9K/Vndmt7+WbrO4supm06PH5C6w37mtjH wvuLfzAx60lgG0+VfVaQD6Q1Wb09OUkQPm5fSLTwjs+j5bVTcXwiEGxBtGzvzTvwL8MNA8NvDVep 9Z02Jmgh/NRsibmSMD2Hz9q1V4z+JsHWPjcNLuCps9FYoI85BzXVOldRaVH4XjUEhW+sbWz3SWyA MWAHK4xXOW2uEu8WidP86VtrfU62R0KE6BJJ6ZuHBMmM4BKnitMfiEeVvQbzow+KXSUUdveRYe5W LhJkOfr4rbVt5wPBmCW6Sfp2106aE8pJBGGJ/wDya1V5pvPZ0D1N4Rat0hoWj3l3dX0Zgh9NMRRZ zzkDFbwt37Zy/j6edqtJdwwy8ZZAxHsKDI0ZDAdicUvT45kgjMjho4kCkD5+KCUja6kO7bExHf2r 3S9PFIzPw2sLGe/STUo1nSFvpjNejHgD4m9G9K9PokOj3Gp62y/TaW9uHz8Vy/5aPA6y1aBdUv5B KgAZBngCvQnprSekfAnwzTqOWxikuRGWE0ceWc+wB9q+flnlllp9XHHHDGUjQevrzrvU4tI1vwze 20u8/lNPLbD6VPufiuL/ADm+TXRuhuu9N1rpmN7TTdVlzLbDPpxsDk4/eupeivNjq/XF7AbLSlFp PN6SAjLZz2qV84+yfoTRmmULK0meRypwM0xzuvbncdZTbX3lm8ofT1vo9vr2pFJJEIZFUZXj5zU/ 4j+cHwZ8OdauenJtLj1Wa1HpyvbWyMgbsRms36MivLjy361BpO/89/DpVg9M/UX2HGPvXi1rz3+n 9U6nBqk0sN4szCUSE7i2ec12x3Y58uWstOqvG3ovoPxt6i0fV+i0tbXVL2YGe2tD/Se5YD3rqry7 +TXpzRtPTVNVRZFj52AZVuOdxNcaeS2Kwh6uu5WRDKVyjHvjNelyS3b+X/Xn0ot+d9GUxFefq4zi uWXl5a21MZMNtWeKHjT5fuktWfQdT0C01WeL6SLeEMM/c5rlHxR8JOjetuvtP1vw8ht7eyvWCz6f bnITP9TfeuatXubl+qdTS7nkjvvzDCQSkg9+a7A8mOnaO7l5mUTFguCeW7VLMuObtOHivJk6P8HP Kd0L4fdIfx/qyOG9JjLyR3nEUQ+3PNKsNE8u3ivfy9P23S1qs8uY0uDCUUN8qd3et9+I2jdNax0D cWHU8n5XQZEQSurlMfHIrRugdJ+X7pW6juLHqP0ZIm3qTdscH/8AJre71V+P25p6x8oZ8I/FW0sW f810zqMubaZ88e5X+2a6/sPKz4Sp0pZ3N90xp8W2MSzXj5UnHfJJwKwDzB+LnRvWj9MWHTeu2+r3 tpM26OAktGMAZOf2rJfG7Ur7/wCxSvJrZpPXjhCsU77cHOaxnnTXW0dF4R+XvxVkuum9M6dso73D Il1ApDAj+pDu5rmC98vWjeXXxjg0rqs/nOlrqX1bW5m7vHnkGpHyf67cwappV0QzXEUpG45962d+ Jjpxk6V6W1gsFeN/RK9j9RzWd2xjCyd10j4T3nhnNMsfRkFpBIEGBDnOPjuaxHx3t/AaLqEN4i6d pd5q8yfW85JcKBxnDCtR+SWCJJrFuCwA7dxxWhfxHYFi8dwpAK3NsrMG7cDAqy69LlJk1R5soPCZ etLCTwnjFpboA86Qk+mfsPvWpLYTXUrSNkA4/tVWWjwxXvpfQXn/AE7ey/8A3ayWfp686b1K2tfW hvVlIO5P6Qa9MvS4zTGLj/09xsJ2k+xqV6O6P1Lq7WFs7aGSSWVtq7R2pj1ZCsPUcsEZB2DNdf8A kI6Ttrq9hvJ1WeVZMqJOcc15+Xl8K9XHjMptsrwb/Dx0JOn49Y8QJIREYfVwrldg/wCvPapPV/w/ /BDxOhurLpjXzFqkSEq9nJvUHHGee2a6o8bfDeXxQ6An6et9WbQxNIjNOh25UZyv7GtS+D/lSPhN rUOoWnVUUrRNkIDjd9j803dx5N9vMfxJ8BuqPBTr49M9RpkO+23uFGUlXP0kH34rs3wR/D46H8Qf DNL/AKgluI9TuhkS255jH25qQ/EfNjd690CyywyXke/dsYFgMj/FdJeV24WTw4tIwxLBQ2c+3Fef yynL47em4z9fk5k6a8gPhfoVlND1V1DJYu8hW0FxII2Kj35IrSHmd8oWm+DUthrPSOry6t09eOI5 PWOWRs/0kdxQ/PB4lXXUfmL1SzgvZxpdkqIkYY4RgMMRjtmtZW/XXUXUpstMvtXml0qORVjhlYn3 FejK5Yzbz4Y+d0628I/IH0l4keGVtqOraneW9+8fqK1pjjjIB+aedPfh5dB6dps7dV9R3GmO8hS3 DyBC6fPJrp3yxLHB4dWUMZOUjXP/ANNefXnA8RdV1vx/6g0+PUbg6baTBIY1cgLj4Fbxytm2spq6 OPMD5NT4Tanpr9Landa/o94QN1wARGT2Ax3rbfhf+G5p2sdMLqnWmsXGnTTRiUW9oeETGcsTWMeU nV9U616w0zT9Yv7nUNPR+YblyyqB2AzXTXnv601LofwJlfSbiWynuLuOAywttwnOV/Yj/tXPHktr d47NT+2juqvwzemtS6avLzoPrG6udViUmGKZg0LsP6SQTXDd90ZrnS/V9z05rttLZ6xbNsdJBg/Y /wB69CfIh1zqE95Lpk0zTwTrn6jna3esU/Ed6VstP8QuitZtoEhu7xXFxIvBk29s1rPk+PlGsMPn MKx3wm/Dq0vxP8PF1ybqi+069uFOy2iXKbsZ+rn5q/RP4aVhrmh3Nx1d1RcaCyzNDb7MDeAe/JFd leVplk8I9OIGMkk/vgV5v+b3xy6ovPHHW7S31u5tNPsnCx28bn01IPwKYZXKSs8k1nYxHzVeU3Xf Li8epaRqUnUfT3YXB5kQ/J55FaG/M/mreKfcSZAM/vW0/EbzJ9W9fdFQdKalcBrQH6rpBgkfFab2 LZ2qW8quojJPqA8EV3mX9uUl2ctHvB+rIzmmrxb5lDNlM96HBeafK5iNwc5+llbv/aqVySdpJTPB ra/Z5KkUUoERLJ/qNClldTGM5w3+KT6uUAU8UOE75wrZ5PFYz3q10w/k72/DTUWniqgV9wltJSyk djg11H57/GXqXwZ6D0O+6Zv3sLq5vfSd0G4lfjn2rlD8OAmTxetyDjFvJn/BrurzLeXvTvMB01Za feX402W0n9WOZj9J47YryYXbXNqZMa8nnjHqXjX4e30PUai/urQhJp5QD64bPBHb2rzq8/HgRp/h j5gXj6fVvy2tRG6S1QZETH+kV6a+FnhfpHlj8NtTngkk1SUL6s8kIz6pA4AFce9D28nmc81K6zr9 syWUEvqR2b/0Rg/prpcvFwk3emkPCP8ADs8SPFbRxqw2dO2bKCiagCjSfBUY7U78RPwwPFronRrz V9OvNO1qK2QyPbQSMZmA/wBI969LPMcviFa9D2un+GenpcXUp9GYhgrQxgDbsPt71hnlkh8Xum57 iw680uaawny5uJ5hI6Pj2/6ftUlq27eMEWmXa3zwTW7wXUJMc8EwIZSO/Fbs8EfJZ1747o0mkW/8 Psh9Qvr4Mkf9j71055rfA3QIPNdo66fZCC31RY57uJOzOzfUa648cfE3SvK74JC40ewiR0hEVpbI uBux+o470yt21jlqdvPvWfwwPGjpaKTVNL13R53gQsVMxBKj9xXIl307ra9QXmk6ilxb6xHK0c0A XlznuP39q6ht/Ot4mT622pT6pJOjOW/IDOxh8Y+K2P5YOlB5mfMAnUvUmnw2sdvm4aOJQu5k5AIr XlpjVuW2k/C38PjxS8XdDGoWVnb6XYq21RqbGNn++KX4n/h1+L3hLoF31HcQWGsafbrmWKwkMkij 5xXqf5iupvEHpTpe3s/DTpkalfzkK8wChIV7YA+fvWO+WTU/FC5ttQ0rxL0GX0Zvqinmw6jP6lYe 4NeuZ/Fi229PFXpLpefrLqSy0PT9y3t1IIVWYYBkzjFejvlo8onjn5fb8a3o0+g3Elwg9W0uLggS jHZj/etR+efw/wBP8B/Mrpet9N2a2a6lEb9Io1xGkgYg7R8cV0p5N/NX1r4xdVw6LrxtGtkjIPpx 4bABwc14ssvl290luO441/EXuvFDX/E/QB4nafY6akFs502HTpN8Lrk5wffmtVeEHlu6z8wcl1b9 IhGvLWMPLHOSqKPjiuwfxflLdZ+GyBdwFpOf/wBY1g/4fnitB4Z+JsdlLxaauRDM5/oHt/vWeXK4 a04cWPlvTlPxI8Iut/BvqWPp7raxm0ySTmCQD+XKB3wT3p/4b+AfWnjDqdxp/SVk19cwj1HaRTtA /evSr8TzwnvOuOj+mupbWAS22jMwll43LvI21ln4cXh3H0t4SXOrS2whvr64YeoVwdg5FT9tmUxb mphuvJDr/wAKOrfCfqyXprqnTWs9XiCuRggFT2IrMejvK54l+Jlomo6D0vd3Gn4/57Rna/8Aeu2Y emNN83XnNv8AUZYXi0TSWETpIA2Wh4IP2bHaunfMd45zeXnQrLTelelZL29uUzAtnB/IgAOPqCim Vy97Ymc8dPH7xC8ufil4YQHV9f6RvbXTYxhruGMlIx7ZrWr3zXTRyMpCnsAOc/cV7eeXPxg1HzC9 Oaxo3XeiRRuyBWgktyscqnvwR3FeWnnW8HNO8D/H/U9G0RmXRpwZoIGOWQEZK5rvxW/blvTRykmR 87gR3Ao6xswDO5C/FFhKtDFtGJCcsT3ow066vY8wwtJGOCQO1db07Sb0Ywxi4m9GCRt57BRnJ+K2 HoPlq8V+r7FL/SejdTurQj6ZBCcEVMeDy6J0r1ro8t7ZjVVRxLcQqm4sP9OK9SdA8XPEXXeltMk8 PfDuWy0pFwXvSoD/APxU8ivNeTfp2z4/CbryE668IvEPwxtYpupekdT0e0dtouLiEhWPxmoCOMXS CRJC2B9We1e9ml9JXnjJ4aXej+KGgQJJclo3tgFJVfZkOPpP3ryuvPKc2m+aa48N4XM9mbgSLt9o S3A/cDvXTHKybebHKb1XP3THhb1d4hMY+munb7VXQ97SIsDUlrngT4p9EW73uqdBazZWqjJungOF A7mvZfqPUOgfJR4Sm+h0+OKOPEaiMKJZ3x8/Fc2y/iddMdaLeaRrmjfw7R7iMpI9wu7ePgCpvK3a 5Zy9R5lWt+NWG+N2VVByccgj5qe6f6B6q61jZemtB1DVbhTy1tCWA/2rcHht4T6F49+Y24s9Bjax 6YvroOqoMAJnnFeq2pr4deTbwql1FLKK1tLWMKm3Hr3TgAYB+axlbnNR2648Zb9vFTqPw9636M00 XPUfSOs6bCnDXMtsQv8Ac4rHXdZrRJllaRXODsGcfavUa/8AxFvCzxdtrjp/XdEfS9JmQiS41RRK pGMfSAOK518r3ld6e8ePG3qJrZ2/4HtbgzqkR274ieAp9qxL49VcbMpa5QtdE1nUd0lhpt7dQoOT DESF/wBqZTtc6TK8Oox3dtcMMiKaLaF/vivaPxM8QfCXylaJpegHpu3vGkH0WkUKNNj2LMV5ppc9 BeF/nW8KL0WehWuj33KwTrCqzW8mOGYqBkfarrdee5dvGqygvLxj6ccksx7Kik8fam81nezStGLW 6edD/wAr0zn/ALV3/wCRnwktOjvMJqfTmt2VtqbWJmija4iDq23+oAjHNdieO/VnhN5f9Og1jXel tJn1C5b04bSC1jEsik8t+nGBW+7HbzmtR4crcyo3pXCmzn91mUjA/uKkLDTDq97HbCSaQSEEiJSQ P8V7GdeeAnhp5wvBT+I9PaRp+kX0yMbK+t7dUeOUd1faBurkbyueIfR/lb1vqvojxD6Vg1PXIb0B JpIkkeJewH1A8HvwKt9GGc3uxvnwn8lPhPr/AJbxeaz0rFcapLZvL+eAb11YLkEDPzXlRd3K9I6l fWoaWGSC5lhBkUjMYbAzx8V9B/QXW/TvVPQUOu6UsdvopiLMioFWMAcjAFcReLHnN8uTaPrun3nQ djf3YMkZWOzjDs443bgoP+9dcMduV5O68x01GG4mAjf1D3YqOMUO4BILq+0txxxRQtlqGu6pf6fA bLTrmdpreB//AG0OcL/2pnMZGDEjs3AplPGpvyOIofRQOJS79ipOSaA87xOzMJAB2AGaNEVCb1G6 YchR7Gun/KF5OZvMb1LLfXk81h0/Zqr3Lk8uT/StebLlmN07Tj3j5OWl1WB5iArgKuTuU4zVoNQj usKsyxluAPevbTXek/Lx5bND0zReotN0RLiRdsS3sCyzyjPc5Far8x/kP8PvH3oA9Y+F8VrpesLG Zo/yi7YbgAZ2Adlb710xycrenk9NdLbvhjK5B5JHApH8UgYH+YsgP+jNbc8Ceh4upPFjQemtYtxJ EmrR292GH6wGwVNepfil+H94U9TXFhe2ehxaMIZA13LA4RBEBk5Hb27103v0tnjJa8U/4hBuMfqh R33YOR/tRpH+lBHIDkbi7dq9g5vB/wAqfiFaz9J6e2mXF/Ghi2WjbJgw4zuI+ee9cMdB+XHRrPzb ab4f3covenp9S9OMZ3H0u+0mnlqmE8u45h/MsCv/ACJUH9SE0oXcVxOgEiIT3LZFey3iP+HL4Ran Hb3tjp7aJ+WYSXEvrARGNTzkYrGG8q/lZ8UbXUdG0G5t5NUiiYL6FyVaNgMZ5UZrW7fSecjyXckR li6rjtk96Cb+IIoJQMTy3PauyPAP8PWTxI8VeodI1LUzb9OaHP8AVIfrNxGTwA3zXYet+R3y09L3 mmaBqsLWuoXgEdtDJeYklOf/AI8f3rNz703M48dY7lWdBH6rhm7kcVV/J+V+tmkAzzxxXdXnY/Dn j8I9Hk638NXuptDtFzfaZO/qPbj3kz/UPtXO3lV8ItM8dfGDQOnNblkGlSgvOkeVZsHkE0t1EmUy ummY75Llcx7UQd2bj+9LS4jf9EyMScEHjFes3XP4Vnhc+vaNPoaXmmaN63/20Se73D08f0k9qg+q Pw6/L31l0prEHQN/MnUFgpCP+f8AUCv8EYGam9aY8pfTy5kCogDSByG25U5GaLqFncLbC4CEQ4/U KR1T0rf+H/WGp9Masoe50+5MZdDxxQdQLwsiG7cxH/28/T/ius9bZxuwGd3hBX3q8bNG4z+o9hVI VbYcjj2qi+JhgZP/AGqxEpAQ0RPJb4FGSBr25toYh9TssZB55JxTKKQiRFGQSeKyLpGNJtdttw5S VGB+TkVx5rrHp34MJctV3P4d/hSXfUHTdlq2odYNA91EsyRx8hQwzirdWfhG9Qtu/gfVkEpxkG7Z l+r44r0B6BuGt/A6xuEbbJHpLMrDjBEZP/iuBvLb5jOtp/MNZaZfazc6ppmoXrW0lvcSbwiZ9gex rhvUlWy5ZWRxP4xeA3W3l86jbROrbKW0hlY/l74KTDcY/wBLHvWCpNIYJDvQonLD3r2n/Eh6L0rq nyv9RXV9apLeaa8clnOR9UTFlBwfvmvMvyxeSbrXzImRrN10npyF/Sm1WUAgN8Adya9G/GRxxm2j 1iW7tVlFxtIGRH7mgBTIqlSw+cjmvSP/APY7aY1l6C9dD89jiQIeD87a438yvla6z8rHUkGnakx1 PS7o77XVI1/lyj/wfsanm1uZWSNX2YJJ3yBR8E1ZwvqMBO0jeyAcVsLwT8vvWPmG6vj0zpm0JiAH 5m8ZcRxD5ya7PtPweBHZJ+d6+hW7K5LJCVAP2+avk3lPD287YC8hk+v0yg3MPgVaaUyBl9QxEckv wD+1bx8z/kz6m8rF9bTS6ivUeiXXa6iXbg/6aP5dfJD1v5nZkvLc/wAD6c99UuBlePZR7/2qXOTp jHvtocQILfebo7x2T3NDcnZhmwxGea9Cpvwb76OJjaeIds18q8b7YnJ+/wAVxH4t+EnVfgL1ledO dWabJHdqx9O5I+iVPZgexyK1LtfKWxF+H3QX/wBYnV2haDG/pPqt0lsZfgMcZzXbnmJ/DF6d8G/A TWurdI6q1W61XSYFnmtrh8QydgVGD7ZrHfLf+HZ1V4ndK6T15adb2vTvrES2sIiLsnbBBHY1t7zt eHPjx075f5k1TrWy6l6WsEVL9bOEwyiMcBpM/rHasYzda5MZ1J7eY2mqBp0TMBmQZJPYUWSwV09R W9MsOwUc/eproHw71TxE6k0nprSZB+b1GVYod3YA9zW/vHr8PjxL8COi5+oZry313RLOMSXktsAG t147/wCa6XLV05SanbmKO2v4x6cN/PDH/wDgt5xSttypDztvjH05HNZB4ceHOu+LPVNh070vbyXe o37AI+chATyx/atv+Y3yRdfeWfpbTNb1zUrXVtMu5hAxtgAUkIzg1Zl9LJLGgmRrwhLfh/fPBoa2 7YfbK0m3uQOxrb3gR5SuvvHrUpV6asJrWzjGbjULldsaZ9hnvW2eq/wxfGnp20kOkpb60SuWSEqh P25rp5RjPHUcxdHXdrF1BZT3b4tYcl89iaB1Dq7ax1BqE6SloJJP5IIwFFMNX03Uem9YutC1ewks dStpDFPbSrtYMOD3p7f6EdNs7W4/NxTCZdxRBgx/vV+3ngQ3N/LG0HH6hRbdSoaNjk+xFSE/TGsW WifxKbTJY7FhkXO7IP8AaoJbprRRIi+qX7Y5rGVk7Wd9HcMDSTFSchTyfipb+FtcpuSSNQoyCxxm th+Gvk78X/F3RxrPTvTkzaVKMevK4Tcftmsh6o8hfjb0bos+pX3S89zptuu+b8vOpZQP+nua4Tk8 vUdphrpomSF2iGchj7VJQ6vq38H/AIVHIXtM5aPbz/moubbbeqjRzwyRMcxy91x3B/xWa+FPg14i +MmtSJ0Jok2pNCA0jt9Mf/5R4rflpqYbYVZxtcvKvpiKNeGYnsas1t+vbIH2j+nmuitV/D88fb27 N7c9MpZAAmRopUKAfJUd60DrGlXPT+ranpd2MalYuY58LsBI7jFYxz3UuJOkW1jJZ3LXjzxSD6YQ q8MfvTW60ya0WMyK2084BrMvDfwd648Zb02vR2g3OsXCqWIj4jGPcnsKz/qnydeOXR+hy6rrHRFy NPtl3TSJKshVf2HNWcnek8dNMJA30ybiVI96kLKKwlZvz6ywoB9JUZyaFa381xbz2CW43DLemw2v Hjv3rJekPCTrbxH9OTR+mtQ1K1Q8tGpUMPgE963lddrMLWN20KNcuyQSiEcAkcGhzO8crKyNs/pN Zd4leHOveHbQC+6X1jRoiPqNwSy/57Csa0X+KaxdR2mk2Eur3EoysUUZYgfJxSZbx2eF3ozzhf5m ePY06sWeG6inhjPqxNvQntmsifoHqu5v/wAk3SepC+A5X0Gx/nGKgtd6V17peU/xfStQ0/7yRMEq TLyulvFZN7Tej9b2s/Vc2qdUWzX+YfSjCDIQ+xP2rDrom8vbmZLRha7iy+mCVVe4rM9G6Rh65sEg 6d0rULvUQP50sQLIv3IFetHgJ4J9P6T5TbG2vuk9PbVpNInM/wCYtEaZpMNjJIznt2qeW7qL+vx7 rxfhdpjHJx6ZOFwAOKNLKJMguWUe/wAVl/VPht1Hoes6tMOnb86dFO7fRAwEYyft2rD57lbiNCke CxwFxgr+4rrrTnlh4KZo2jCn9XuPbFEjt0VsAf8A0U6zY2sSma2knkIxuVsAU1UhWYk7EP6RRy2K sIk4xu9uOKJFCkLBmyOf3prJci3jaRZFRh/UTkYp1b/xCeFXh0m/uw3/ALkVo5U/scVNzbU3o8ZY pbkuq/Q3YfFF03Rz1BfSWayei7rhSffFRzyzWV0sLRzW7sOUuYjGR/mpzpewa86jtg1wLOCM7ppW Ptj2rNWQ7hs4OotKOiXHp2l9p2VSYgDf9jQeh+g9R1HqSBtQg/LaPaOWmunHDAdjTPqe8jg16/Nv DPFazONss0ZUnHuM96BLqOpLZiF9QvvyL8OrQOqBf3xijNlK6vf+J9T3m66/MwIdkUg5G32xUOdN iEbKJDkjG7AqjPaWwlbeTGnAxyTntQpLyO1BLmSNW/T6iFT/AGzW50k2kum9KeXUUhiYlI0Z2kXu OKaWetai0UitfyPExI2040Tq6Xpy8a5hs5JkeMo5eMhSCMZye1Qs93DBBHI0ZFuScFTg810uVvaa 7PPSRto9Zg6nd/ejySG6m9Utlz3P7Uys5RP9bK4XuJRGcAe1O1nt50BjYNOP1MCAP8U2UeW5nnTa 0hEY4AxVljSNcK2P7+9Nby4TbCm4mSRsBRTrX7mLTLexjntWspUXEjsc78+/2rG59MjCcpFtTA+W 9zTF5mt7mGcAuY5Fk2/OPamo1e2LqFlD/vxmjfmow36tpPOPerDfileq+prjqq/N3JaR2iY2+jGM DFQsH0MTjHwRVp3Z2GMmkMrg4AP7VrdZ2LO4d+Tk4wRQXmUx+mIV/akOjoTuU4znP2ojldg2jDfJ 96kujZfpxvFgxgNjjFCSH0cY+r7E0ueZUUAj2yCKQXVlDD2Hsal7Z9FRsYZOIUZDxtPtR1d8grGs YXjA+KBCqSZcPz/pFKBKLuOSprcysmob2sAsLuyIU3ewq9vdSW0oaKP+YfdqS0g4PKn2BosJjdC0 xKoD/vU8q1sou8kwkKLCRydvZqsrLC7vhZSwxgn2oEc6XDSKCfSHYn3q6yotopC/WD7+9Llb7ZnV 3F47u8iDLuVoj2jI/TS/zLyAh8KPtQEI3bie9XBGTkgKBUdN79i/mJo33I2GYbScd1+Kb3NrDtXa 8gkByBjjNEjbehkQkpnGaWZt8QGAcVjWmrlbNAMzOQZVUY5wKWs+39X1Ie32qxO7P09qGwwOeBWm JNClxgf71cM2Po9ucGm+5lYAc5+acITwSAPmpZuaqzohlVpFmZGWVewUcU5iuZpn5JJPB3LirGT+ XnOB+9ASVHkIaQgH3BrMwxn015VJ3Lyx+iDL6i9ipAHFZ/5eOirPxf6ivOmrjTVE0LtP+bUnJjx2 rVM1y4jZFBcHs2e1bP8ALj4ka94T6nq3VekWkWoRQW5juInIDFftWvGenLLf0xHq7Q36S621bRZP 5b2cpWIAfSVzxmmdu8Nst00w9aeTsz/0j4FOes+p5PFXra96ivXSymviHFvF9O3HbNRN0g9Us0m4 9wBSYyellt9kqUKFXiGPbA5FDgZHnjDMXiH6lZQMilK3AHbPvVNgN9/3rPi6XPL0yDU7zRLW3ji0 aybDLmV5hgqftWMyonomOTk5yCAP8UUuzkDdxmruRgjgse1PGMTPKEJGVVPRCAjjafetqeWHrTQ+ kfFbT5Nfu2s7Sa8ikkI/5a7T3NaxjAt5PrA+oY/ao2HR01SSSGAkyEk7nPFc8+PynT1cHP4Zbr13 /ET8V+kupPAKyOj9Q2GpyyXscscVpOrsV2nkgHj+9eTb3bTyykL6ak5OQMNn4prm8s4PyM10zheA GYkD7URbpnRIpSrsnuBwa749RnPOWahUSYyCdrZyGpbD8yxTcF45J96UpO7JwRQGf1DmRNiZ4waZ fL282NuPoqKOO2kKxz+lx/S3ai3OyzBiguHuBMmZGbnmqZbcR4EYJPG6g/RbhkTkHncaSaW20GNF JO5eaKyAjAGAPc0NGGc9/iiRtuDAcD3oypZB+ocOOz0KC2Edw9xAc7jggNtYfcYq8Q9QEMCAPce9 WjmWKUORtIPf5rPhjvbflU0dZuRbJDHEiuPeWUktUeZZpImkuZiu4/UijgftSJZhcsZAAxA4oRJy A7ZyeQa3LrpnezmwYafJ6sV/LbjnCxyEA/cjPehuzXMjF33DOVc9zR0tbd0yAuPbijafbww3KtMu YfirMrPSXv2ZvaLesFLcj2oumXt/o/q29tqV3Grf/wAush9P9sZxTwwCK6kkQbYjmmUcYLNKpL8/ NY1N7amVk0cx+pPJ6lxy+KK6C4Uo+EJ/qPvSBOp4OB96KkquVDqBj3q35e187D3RtS1Dp26UWGsX lo3vHDKwQfsM1Kal1bq+roY9U1a4lmU5TfIWAHyQag3so3ZZMkN7MDihPCoZgw3sf6ifarJJ6XzO 7iBbsSA3BlLfPY1L6J1l1HoOk/koNeu0twT/AOkEh24rH0G9RztC+4osWJGy5G3sG+aXv2TLQ730 t/K13Kf/AFDHDIO37/vQZY3AEiMuEPKH3/eirFEJsCQJnkmhXIjVWRXEme9Yz3lNVnC+OW3oL5Rv Pv4b+Gfgta9HajDcaZrWnpLsKxgxyOc7ef71yJ4y+KN/4qda6pq1/IZ3uJi/qE5I/YVqyO0jYAeg W9yScn+1GW9ZWZVGxF4yTz/epxb446cnJ53aoHVuG4YMeT70YOVycY4ocM4clWUEexqzNuPetXK5 XdcfS0i71Yltv3HtUl0T1nrvhrrB1nprWrzRNQwYzNbn9anuCDUXuxkd81XpfUuScH2J4Fc8sZl7 amVx9Mu608VOpPEq+jv+o9Wn1a8VBH6sx/pHtxTHozq3qTw16mj6l6U1iTR9aUbFlg5OPiofYY1I wADSFUhiQdpPuOKzcdp55RsvxM8dOuvF+Cyh6r1ifVpoDlWmULtPyMVIeGnmk8VvDDTH0jQOrrmz sVbK20oDovPsTzWq7USod7TM/wAAnOKszkOxGDn57UmP9uszb36n86Xij1z07faJrHUc0tvINsu1 VG5ftitIXAS/mH1A7xy8jEk/3oG9tu47cjtgYxVllXK7lU1uYz7dJnN7bR8MPMr4l+CcH8P6c6om i0zO57VyGQn7Z7VsPqfz8+InWWgXOi6lqTLbzx7ZGhx9QPtXNcr5IKKhH/UMihi4O/lEQftxVk05 5Z2pPVEnu5fUedd5y4kLEOD+/wA/etzeGnnq8VvDPS7TSF1qa/0yH+XEkwB9NR7bjya0SrK7bidz f9XanJhcA7ihXuBiuVn9LOT+3R3X3nx668Q+nZ9J1C/a1sLggSCIhWOPuK1D4e+OvVvhF1Vc9TdM XoguZR6DtkFmTOfesHAYSEyKjJ/pxT3SddXRdRt7iG2gnETbjFMoZWrpLqacbbvbtnR/xVusLayt obvpe1uZQgDSh+XPyamZPxWNchhUSdJWu73ZXJI/tXBWpatLqOoTXQUQNKxYxxHCj7AU0a4uOVyB n396SO0z3GzvGvxWtvGPq69190KS3f60xwPtWdeWzzqdWeW6xudEi0q31vSLqT1ViuHK+mcexHNc +reZK5WNWHGVXFKkk3t6jLufHHPAq+M9mOd9fToLzB+am78eNRg1GRDbGJNgtEP0R/tXP8t3dwfl 5rNvR1KCTes8Zw2c5FBhmljzu2KvcECrb/QkDLXW6yx1XOXKZbdg+FP4n3W/h70/aaF1BoFt1EIA I472aUq+AMYOP/OayPxD/Eu1Xrfpq506DSoNCWVcepBKS4P964bkukJDGNsg5yTQbiS2ntnAjb1D zuBrlhj4+3TLLpkfUuunqmabUry6lvNQd9xlb3rHg7uhcqd3xQo7xobZVAABGAMVS3sgAVkZSe25 cV1t/pxxlnsTeUjk3fSzDHPepnw66713wY6w03qrpm9ZdRhbdszhT8gj3oXSHTLdXapLaLcBJFUv hvcUx1+xfRrqe0DJuTj6hmuOePnjqOuGcwy3XoB0n+LTLeWkcWtdHQw3agbzHISHPz3xSI/xXL/S 9SmM/S8F5p8kpMbNIVeIfHHeuDdKs3GgPqq3UP5iFwn5dxljn3qJ1C+a+kzJhXzzt4U/sK448Vx7 dMs5fTdnmQ8bo/Gnq+56qs/Us5ptrIrcFCPitx+Xn8SzqTw40K06b6y00dQWtuMR6gH/AJsUeOEI HfHya4vkCwIMSFgRk7j2poZlVcIHUnuwPeunJLl1GML4916i9XfiX9J650zeW2l6dPbXkkeI5ZVw FNec3WvWN91X1Xda/wDm5Uvnm9YXJOGLe1YoJSikPKzg/wBJPFPLWZJbbbuBkByAanHhZjZWMrfK ZO2vLv8Aidat0TpMeh+IMD6zBbqI478f8wKBgA/Nby6s/Em8ONf6Uuk0mKb8+YzseVAqq3715Qzs yyl5FGe2O2aAFVZ94YKp7oM4phhcb27ZZzL02Zrfi/1Lpnie3WuhawbHXI5TNFNGewJ+Peu2fBn8 UzpvVemLXSvEzSpri7hAEl3Egf12H9RXsK837hBPIrkKONuQPakyiHhVXB+auXHd7iY5/wBvVPxF /EQ8Pbvpm5i6Is3t9ZmUqk0luse0Y78Vp/yLdZXPiD5mZtZ1D+ZchX9SQDHPsa4OtJVjZ2MxD7cD BOBXTP4f3jZ0b4LeJN7edaXTW0N3xBeNnbF+4968/PbJjp34NXb1O8cvHbQvCIW0HUVk9xpl3GTK 4GRtzjFc79c/iHdB6X0jPpvQMUlvcBSqNNGI1Qn4GTWDeezx66S8Tui7ZuktTi1aJRh50Y4/sO4r zhuJy0gclgedozwP7V9HjmOpa8meerps3xf8XNQ8RtSmutTn9ZmYqfqzjNbS8knnbh8uuq3mh9Rw XF501eEfVFy9sR7qPf8AvXOcnTU8eiQ6xNdwtHI21YB+r96gLmNF3bTtcn9XtWOazO9Lx52TVeyc /m78vniAjXNwUnuHjIVry3Ctn4/VXnV5muptEvOuJbzp9In0veWVYwNprQMcot0b05i7txg5oxm9 MRs05IIG9XORVwupquec8ruM3uutLDVtHtdPaOWKWPPZeCf3rGdWVZDsOdr8FvfFKlj08wpJaO4k xli7cA/ao6S6eRcmTeB71L2s6TfQHiXrfgp11pvUGhTOLi1cMADgSr7qf3r1K8O/xBfCLxx6WttN 68tE07UnIM9jOu6AN8hsg15KQAyF1kIZCcgEciiSaepHqmRAv/Twa8mPF45Wx6v2SzVeyV54yeBP hlot/q3R9rpH8UdMBYVDb/3yTXm35jvEe0621q+v7eFYWmmEremAB37DFaTtb022TFdSEDnbuNPL nVBfxxrN/SOK9msfHWnl38tvZXwX82vhhqPhJ07aRdS20WoW+mRW8lozAOsioARj9xXnj5r+tLbq rr64/JSB0DMcqe9c3wRmKR5bUC2nHIljODUj/FpX5nlM0+OXfk1eKzDHSckmdXvJQmoW8zcpCQzf evYnyz+YPw7h8BunraPqS1F3HbmNrJpB6yt8Fa8cGljlhKTfpY8kcGkafcP0/fmSxnMTsPpkQkH+ 9eL9NnL+x2nLJx+Dqnzq9Y6dqnVqvp83r+oTtCnIzWjvCPxZ1XwJ8S7HqzTgzGFgZ4T2ZfcVi97q U1+yTS3T3U+OXY5x96ZSPNPIpl5UcEmvZz39uMx/p5/x/wDFnc/7e1vTPj54UeYnw/sZbzqDS7SS 6jBks7q4VJIW9xgkVMxdZeHfgV0VINHvbKVW3EflZFdmb5YgnFeGsNjFbXqS2k5gx9RKkgg1MSdd 6/zaxapO8GP0FzzXmxxsvbvnnPp1b5qvMpJ1zpc1rFcLPiTc0q4zj2Fd2eCvjR0BL4H9OW0PVGmS XCabGslrHcL6ofHIK5zmvFqW6e7G643DIwcngn9qaaO0+h3RutKuHt7knllYgf4rXJhMuSZyOfHl 44aydpedPqvTdduIo7N1Ygnewb/FcgT3YjsZGCDYpx+w+1KvdbvtUlVru5luWf8AV6jZprdMTbSx RKCQdzD/AMV6c8/LHUebHH/J5PSj8JvQ5bLovrPUHgMYup4vTkK43DB966f8dNT019Iu1lcNJFCy H7HnivO/yv8A4h1n4N+H0HSF/wBJTSS7mX87CdqnPY4+1H8YfNrF1Fod1b6RNI8s+W+pjlSa4fi4 2cvy9PR+Rl8OnOHi7dQX3XmrNb/THvwHH2NYhbshZiGJfsQe1E1bULi9uzLMRJM7biV9ueapoxDG hA/V3r18tlvTz8Usna8k5+tduQRxXXf4Xl9pmneLup6hqOqWunMlnJCsVzKEL5PcZrkSOaIAqVLZ 9/im6I0E4uLa5mtbhOFaFsNj96+Vz8VyyxyfQ4uSYTVe1HmD17Rb2zt5Y9Qgm2x/rhcMp7+4Nc2+ T7x1tekvHTWOkr3UILPRNRDzercuFX1VH0gE/NcNWHiv1VFZRWL6pNLZKMFJCS3+ax+8u5b+6/MP JMlxncJkfBWvRjqcep7cLn83s14sXum9AdS6f11aXCXMLv8A+qjgYNuH+oc091mDpbzHaDb6j03r aw6iARsWXbIR8OoORj2ryG0jxe6q0m0NuNfutQhI2mK6csuPtTGy8Q+otIvjfaVq17pNw5y7W0pX muOGNk7d7yYvUHUvJxDEs+oa/wBUXsVpGpbbbysST/muVPFmG38MOrLa80XUri+022nSUCdvrbac kHmtQW3mh8Q7Wz9C56hvNTiIwRNKSTWJ9Q+IWrdV2zTXLsAx4BPP35r34Txnbz5ZPXboLxW6M82P h0YLC7SLUVQGS1dh6kMgHcDPI+9a1618kzdZTev1Bq4jsLdMlojlyK8tun9e1zo+6/iOgate6Tck 8vazFDW2OnvN14kaTAYLjX73VICNrfmJSwP25ryYbmV29XWUbm6b0+28qnjRZdQaHI95oof8vPLJ +oRk/VXcnUujaX5gumrXXuk9cErBcR+nLhc/DYPBryX6y8W9b67t2N0DHBLkEKagej/E7rHw5kZO neo9R0u2B3PDFORG33xU5ePxy3PSYZz09NJvKf1LdXDTa11O9hp6jLPaTMWFaL6t8M+qrnq8dL9K 6q+rpM+xZryTjPySa01onne68trSSC+vrrUYSMH1HPNYT1T49671Fei5069udJvAdyvA+MH716OL LU3HLkm727t8vXkw638N/ES26i6hvtOmRCSwt5CzjPtXQfjV4Tar4h3dlNp9zFEsERjZJSQDk9+K 8sek/Ob4kdPFIrvqK71BUGCHc5P962jY/iNdV29ogeF/UA/VMc5rz46nJ5/bVvx0zHzPeW7WtNs0 ee4S7kRMj0yTx8VvPyF9WXHUXhhe9JahZj0tKP5cknllPcEVyX1p569V63sTDeaQTOUwZ1YYI/at Cab44da9Ia7Pq3TOvXOmNM++eGKQhXP3x3r0fkYfsxxuPtz4cpLXtd1zeaf0x0idNTFnHLH6MKJx x8VxRbeJSeBXixpurXDp6V3IbeR5D9CoxwWJ/aud7Tz1dX32nLFrytqUidpC3Y/Nap8S/Fq78UJ2 juZSkecqB7VvG448dldbLco9g/E/Q7vxK6ftNd6L1dLuQAYFtMDE47+3vWrX8KvGHXYvUn1qPS4Y R/zJpcECvNfwn80fiR4HyvBoGtO1ln0/y85LRr+w9jW84fxLOq9U05rbX/TnGMOLZdoNeTi96d88 azrxh1/rzw+vHsrjUm1/Pa4jO5RXIvjP1Fr2v3C/xG7DnGfTY8KKzzrLzZRa7psy2EZjdwfokOcV oDXurZ+oW9a7O+Qk5K8CvoXPxmngvHcsu1undBh1SeR5JisMSklh7t8V07+H113oek+PKx6tcx22 AI7d7ggDd24rk2yvWt4pVjkKljyB70q0mmtZPztoXhu4SGSdThlNfL/K48uWdPq8GU4+q9wPMr0h r3VkemjR457+2dDujj5VM9jkVOeXTwfvvDTTri61GVfzN7Eo9FTkIO/OfevM/wAMfxKvFXomwtNI upbDVra2AQfmIsyEfdq2xYfiXa1Ndm+lhSGfH1Jj6P8AFefimr2mW9adVeP6vZ9eWN3I7C3WWKR8 H+kcmtl9f6Na+LHh438Hukml9L1YgjAnt+k/Brzp8QfPbB4g2hmvLYrKBtDx8DP2Fa06U863XfhV rM+odO3CzQSja1teAvHj5weM19DL3Mo89v06uuPAbrDX0vNLGlS2SyZBuJ1IjP8Aeucda8GtV8D/ ABV0TUdZaOeCG5WSVoDuG3NbR6Z/FP1bUrNrXqXTba39VdpmgTFa88QvMr0t1DZXTwyPd3D5IWbk j/NdOSX8ji04dYZ7ej/Ven2ni94VWuoaDci4BtlMQQ5ycDK/vXK6eDvV+rNe6bHo11YtMCDPdIVj I/euTfCjzxdd+Cd5LHocsd7pEz5NldDcif8AxHtXSWj/AIpv8bsTaa1pcdl6i4eVR/2rjwb4vi9O WHlPKMd8Hulr7y3+YPTbnqL0Vjmk2epE2VAJx3Nd0eNN51rpOmx6v0ndz3cDgF7WBQzjIyCo+K81 vE/x96W6uuGuLC+e9uid6hzyh9sVKeFf4kHW/h5t0i6tU1vTYf0mUbpNv/yNZ5OP9d8/7bxvlI6z 0zxN8ZdWl/Kw2V3bz+z3UQVawHUvFDrK78SNF0rrAmW6jvIwq8D3qPf8TWw6s0maxuNObSJJV2+v 3Kn5rC/CfxK0/wAQvG3R1iuW1ORrhW9ST6jwa6TKeFZuFl27s8wmh6r1D0URpyNIqndJGo+ocfFa q8qHhE9j1DqHUWqQTxzQHbbeqMAkjn/FbS8bfFzUfC+S2ltrBby1kGZAw7/atTXvnJtNS0e5sxpr 6DJtP832z9sVng8s8bI45/Hs282mrwtqbx+qrFPp+k5xTryQOPy/UeMbii4AP3rlHqvx30a/ubuX UL8X7liR9XJrXvQfnK17wj62bUtLtDcaU7bZbZT+pfYCt83+Pi8WOPLzydSeOxu9R6nv2a1uJpkc gCNCcGtMeJPS+vP4eu8dgyFcswcc1u/pT8Tfw/6pmCah0c1jdvj1JZthGfntmsU8RfGLpnreO4m0 zW7dbSRjIYAcAZ/pr2fjcu+PwcPyMO/KPPXU9Km0ecC4j2Pk7i2fem17dra20kgXsP74rePi31X0 5e2ksGn2Ucs5H1TjB21oRrj1YizAY3befiuPNNyyOn4+TsD8MzrWw6f8WJ4L+VImmjxGHOMZ7V6S +LPizrXhraJfW+iW+pWLd5S5BX98V4PadruqdJa/a6vps7xX0LrIksPC/ScgH5rv7wi/FEs49Gj0 zxF6Zk1OUAKZoQPTOBj9JBr8/MMuLkktfY+OeO3SOk+cnWNYneGx6QjvZ1/9u2dia1r4z+YPUOrr d7fWLObQZIlOy0I4zWTab52PCvWLZ20HTLbRdUdPpdo0Vgf/AMUCuf8Axj68ter7h73Wb22uNgOD CwBYV9vD+Pk+flHc/l61P0PAezuojtZy5Un3JxXNfi3qV5fa7O07Fi5O7NMfDf8AEE8POmuirPpF tMuoHhTZ67n6QfmtfddeLkHUepS3elXkE9rMdxyR9Irr+Nlrl3XPknx6Yb4z3z2ukQqAPTZQoP8A 5ruryvyTaP5YtDCllkKPge/NeavjJ4k2d7ZQwxAySxlcgHvg5rrPwo/ED8NrTw70zpuZGsLqKFYj EwJ2tjB5rz/l7zzml/Gut7PvFq/uHvXV1MhYkYP71HeXbWY4PGTT0mcQuFZUUffisI8SvFax1q6N 7p95FNC2eFcZ/wAVp7qTxmuOidbsdf0VkN9CwYgnOce1er8jHfFPExvz29B/MVaXEVrEzFhGOC3t 71jPlB6d1C66uvNXEbJYRAgvztY+2Kxvw78//hH4qdNw2XX1wNJ1AAK0TqSGPyMdq2lF5m/D/Sem o7Tw6vLO7Cn6k/Tn/NfL/H/jcft6eW6Q3mbvv/XymR/p2kgGtseDsk1p4Maa9v8ARI4Jz8feuOPF HxWXqi4Emqutvbo31kPk4rcPSvnO8IdO6Gsunoeo0W/hjCeltIO7716bjccfGuUymTFvGDU5LzV5 4SxY/Vkn5rn/AMRL+TTOl7gQDZIBlpAecVnnil4lW2rXb3FlJE0U5+llbuK0Z4wdZ2kvTRto7lRd Y/5anlvtX0vKThmvb53LMss+mv8Aw28A/Efx+1PU06PWEw2rAyy3TlQSfis21P8AD68QenQf+JL6 3hZfqJicmuzPw8ekx0f4bS63egwm6+t1ce3zWyPFjrfT9Wu57lgn5ZEKDfj6h818rgzy5c7H0s+P xwmnlb1J5bLzS95t7+W8lTgRleDWq9a0LU+lL7/1yMqjjY49q9Fb3SdJnlnuRIQQd+c/Tj4ri3zI aqmp6rJDbx5ZZdqlBnP2r6mXFMY+dhzeN1WtZ5UeH1UA7Z2iuzvw2tMll8Q2uiQrLwc+1cfwdEdS LZQvBAssLDc4/qArrfyNeLPQ3hJqcr9UaxHplzIckTL7ivh8+Nyuo+9wZTT0K8S/HjVfD/Ungg0e 2voEXLPK5U1PdP8AVmneOXh/JKjPaTqD6sKHG0/bnkVzR4veOHR3WNvdzaBqcOpJIudyn3+Kxzyw eYPQ+i+pL+36h1VdLs5PpVJc4b716MeO4cUtcs5PPUb38JtA07Q/EPUBqb70ij/k+p/qrNutdf8A DG8v2i122WWdRzLtOP2zmtR9feLXRWka/Br+h6lDrCDloYpMVMQdZeFXjlaQyHXLbRb4DbJbScHc fvW5dzt57P6ZL051p4NdJXxudMjS3uQMCTZyP96aal4jab1r4gWdvorB4ZcbZOxyO5rB9f8AA/oD pKxa9/jC6yy5f0oJxn/Y1z9q/iLbdBdUx3uhxXFu1vJvVJWJwCe1dpjNbjhZbXYfjFduJ443ciCN OSffiuN/E+8invHES7/qOD2Jrqjo7xJ6Y8f+lrZJtSttH1NExKtzIAc/3qD1/wAs/SVlbXF/qOvQ 6qxyypazDI/wa68PLj43H7c+Tiy8ttc+Tu009td1Nr6Vo5YnUxoD7e+K6D6h0Hw46g1aZ9W6gmjm P/tTnaFH2rl/RPELpjwY62hlNncNaSts3MScD5roC56E6Q8b7AarpWuWdi8qjmWUZH9s183lmU5e 3t49eDMOj9G8MOiLtrux1eGWQgjBasJ8XOttMkgnSwAuYHJwT8VBXvly6d6RtHutX186pGo4/JTY 2/71rS26At/EPWZ9N6e6pXRvRfYRqL9x/evdw3xu68/Jl9Rkvl7trG966uZfy6o0QJDYwBWT+MWo pBeSlZtpUEDB7VkXgv5Yrzw/vJ7u66xsdVklHAh7Csg6o8th1q4nun1yIbwSyMOCa44Tee3fzkxc c6X1lc9M9a2V+JWkEMoPJ4OTXT3iVZ/8T9NabdJzLdBWAWtP+JPhDo3SVyZWuXuJLch3CHI+1dEe CsWl9XdL6dPe3UGIkwitKAf8Gn5OFwyicHJjlKFZ2R6J6Fit2b055AWDe5qB8ItGh1rV7q7uLv0t r/rb+mpjxe1uygT8sLmN/RztAORj960l4d+MGhaT1U1jqN6tpbztgM/6SfvW/wBe8PJcrrLToDq/ wp6X6pvWe/64MZxgJ6icf5NX6J8J+iejLqS4h6tW+LLjbJMuB/hqwjq7wgXr0redOahaxF+S3qqd wrA77y8aj0/FJd6v1Klng9kbiuXFO2crq7Zb4qaxpFis62rfmBuxuXBrknxKjs9UeQooikznK1mn Xev3GjW81nBfR3npcK+P1Vzh1p1nrlzLImxY4z3IXmvuTkxmGq+PyS3LcYp1/Db+ofTYF8EEe4rq XyRafFJo7St9IB2k1xVrU8ovog7s5dhkn3rvTyW6T6HSQduBJIeK/Mfnd5yx938Lcl27F0ewVXjY PlQvbPesrtIm9P8AVuINYzoMUCLlroL8A1lNkIWUhJg/7V04Z09PLR9oRQSOfc1j/UE6o6LGu45z ishIRAcksKx3W7hFuoQByWxmvdi+fkgeqZyNJ5BAPtXPfX8rBpSMgEZNdA9avi0dAc4GQK5469dl t33jPGTX2Px8a+R+TdRzL15Pva5j5AzkGtF9TTE3XJyD7Vu7rqZWabbgEE1ofqBszOSMNnsa583V eT8fdyRaYycjJq5O7HGKbWjNk7h3PenA4J/2r5lfoMfS2PcHFXYZIyP7CrEgH7far7skHPFF+lyC Af6fb+1DQmdyhBx3zRVi3sMAke+aM9s8UYfHB7fNSkNppIo13z49JeMmt4+F2u6Y2g59BiiDkxjk /tWn7LTYL0hJxuQnkHtW5ugLBbPTmEMKrEB9LKP1V6eLFx5b07JcHPI3VcoGH+n9qI8gAGMbqsCG 5969m3DRCDnmjeqMADv80FiWZlGOO1Wzjt3ptSwcnirbSTzxSim09ww+RSwm778e1QCVRupyqxqg 4yfakKAR25osJB78CjBvKftirRLhj75pxMixxb/1KTikoMDdxk0Ajt3FQwB/ek/pJ+nNHdo2XAQB h70koAQAfbmgGqgdv96vt24Gc0rbkZIz+1U7BFzxxQIblcnk/FIdhjGOPbNLyWOBjHzVmQAZznHz QAJcqV9z2oEtlI4DMwXHsDTs7QA57exoT3Ea/SUbJ53VsM1EiMcgmlqCGyfei+lPdIWQgKTwvvV7 fS7i7PoiJ/VPAI96FNJWLj6eMfamcgb1Cc7cVMdSdH3vTQtzcT7fW+oDt+9RbAOQM7gagEOTkHI+ 9IlTPIOPtRDksQFwB7CqcNjlSP7VI0EIzsJxk0kEg7f1H5oq9yM4yKD6xAKYwfmtKKeARmksgVTz n70j1CvA+rNKPbn27j5oLHL/ANQOPirAMOcZNKVUH0ooXj2pWdzAp2HzU0E5KnkVYkEj4q7vwTnP 2q6+2McVQIhsZH1VbeRgMvJ+KI7DJH+MUjeVGCMk9j8UQl42LdsD4pSJtU7u1UzshxnOPeklnYE7 cg0CH7g9xVl2CJ8/71dmyC3CkdhSFU3Ebhv5Zx2okQV8w9VlYlVHY1HXqevEYwBubsSak9Z+uTOA ABjFREig5OST8/FYydDG0iCXUS8Ag1tjQpx6GSeAPetUxxEXaY4+rvW09DjA9FO8bAZJrhl6ak7b x8E2deorN3PK9vvWB/iWT3OndOdM6jAxQxyMm4exJFZt4VSNFq0e04MeAp/xUJ+JTphn8Cor/gmC 5iAPxkivBLJk9fJ8eOV57SeIXUJRo49UnikTuqMV4qJn6h1rUZA76peyqOXjaZvqphp97p9vfvNf CSSDGwLH3J+atdTRC4lksWeO3bBRHPIrp1Uxy+J1FFqVzeiQzTmNPq9EzMVJqQHizr+ho9pFcmOI nG2IZI+2agTrF3bgMsqq4/3qMnnWR2cjaWOSV45qz01MtJ7VfEzqnUIli/it4qscZWVhgVA2mval pd+9yL26vZz2adySKAy7j9MjrKBxinMd5CFImJSVV5Le9TUS1l9l459XWsCRw3DxFOAVQEj+9A1P xl631GJof+I78MeQocjj44rEvXaNd0chX7g96SJi0u/cVYDvV1GpydaT3T3W+vaNcy3Ymmnuycn8 w5Ib571lFt459VIJPyV6bOXGWEY24rXIvd8YErM5B4pEtzsLFRj/AKu5rH62LlW8ek/FTrXq2VYr rqG7dW42tIQMVs/w+up7XWmElz67lu7NktXKWg9ZTaLdptbaBxkj5rKU8apuntViks4mkPuw9qxl x0wz7epXitq2o23lZ6glsg8V7DZq0bp37jt/ivLbU/ML1vrenzWU3VN7Hacp6Cse375qZ6485PiN 1h0rc9JRX0VrpF2gjfYMSBR7A1puyJtNsUyFgRjcO/3NMMfqtclnuM00zrfWdOeG9tpi7xD+vg59 zWb6D5pNY06Nkislnuc59fdgo1ahln3iNVfYFOADU5p/U1toKvGljBKHXl2XnNdMcfFzxz1W7R50 PE+402VLHX7i0dRhUC5UVgWm9a9ReIendR651RqEuqXUMbFPWGADj2rXM2vTPMXUoit/SgwKkLbW J5NEuLJHMQlB3bfet2bhlyfLbGNHna7ijunyGkBcL8c9qy6Lqa80+0X0JCjDuFqBjhW1EUHYquO1 EEwTa3Oc9vmkn9uNu2zel/Hy/wBPaG3vI5LmJPZVxn7Vtnpfzk9SdK6dLH0/DDYfWT6byli3+a5o srrbLuC7fYECnJMZkyY1Dd92Oc1zvFtZk3t1N50fFzqcz2j60La3lU5gjAxj3FYlo3jDqP51J7m3 aSVQDI7E5P3rXluN8m9Sc4xuFP7VmBP1EkjnPvXbDijheXxrfuredjr2HpeXRNMWKCyaMxCcPlgD 9q0907qE2mTNrUj77yaT1HDf1n5qH2h8LhVz9qd2+2eOXcdwjHAH/avVOPUcOTludbVsvHKWJoJb m0MkyHAVSfqrLurfOn1/qPR//DWmJFYRN9AuO7lP9JHxWgLZ2jlVlKoQM7vejtE9y7TMNxz+s1f1 xmcmXraU6Z6mvem5pJpGAupHMkuDw5Pets9N+Y3TtFKzXcJtpE4Bt+Wz88Vo2Uo7hW4+TVo1t7Zm ZIg/yx71m8e+m8Oa49uw7H8Qm80HTxZ2OjQ6koGRJcyFSDWqPE7zrdb+LMy6ftTQ9OQbZordzhx9 zWjpWjlYF0Cqfgc0NljVtqoAjd+OTWJwfbef5G/TavTPjTa9OzQTbHaaMgbcEg1sPxS/EA1/qvpC bpjT9BihS5hMDXeeduMHiuamnEYCKi4HYmgNIGkVuzjgfauv65vbj+74+InTED2l9bIW3Rlstv47 mux+iNfs9K6ZggDK3rABefeuL5ZXkcMj7Xz3qRtuuNetbZILectDkjk/UP2rGfHs4c/HJ6zeHGsw dD+GGp6pLJCscUDXYLvgcDsa8lfEjri68SfE7WdfdhJ+auGCHOVIB9jROoPEnrDVNIksDrGopaSL 6ckQn+l1/wBJHxWNWMcVlZLaxId2Ms3+n7CscfHcctunNyfsnR7+Ycs5fHbimmpl5VjiBJHDHFX3 7TwwOKVI+Rktg16Xmbw8PPGDTdH0FLO5mWCRFHBbk4rd/Rfn203w36WmhbSDqVyT/KfJGft+1cNN bQSsJJI8sPcU5W7SPEbKzL7DPFebLhle3Dn1NNxzePcfVXWus69eaeLNL1g4tlbIU1vTwm89GjeG tlNZ30M95DId4gUZ2n9//FcTzFMkKSOKCGjji3fX6nu2eaTimtLjy6ds9PebrQ7/AMSLnqDTVXp6 G44dWx9XzkVtm/8APH4Vakog1WwXUbsDZ6skKlGP7/FeYc6mSRWX6gf1F+9XmBdFCSDaP6B2rnPx 43efrWndHjp5wuk9C0BLHo6xtINTuxhktiCir96xbw580OidOaTbPAn5PVmbfK+cAN9vmuN57BXX e6qnsCncCm0iLGiJmRx8se37Vc+Ly6TDn8O9PUa987PhVrXTawdZxR39xGMsgjDZ/b4rRfih50vD +60SHprw40I2dnM+bi4aPaU/b5rjK4BADIiyAjndzmkRsIUdzgAf6eK5T8f/AG1eXvbuvwR8yWm9 ESyvb3yJJIP5olbhhn71tbrXzHeXTXmXUeqbOC91Axj1Hih3bj/YivMVdVtxGQyEsRgjNM4osRSN Hgpy21zmtfqkrrebfb0D1fzJeHXV+iX+i9JW/wDCdDeEw5a2AIz75Pas+8EOqPBbpzoOO11S506S YHDMzBmY15xyTtbdAmeGc2z3L8opwTWEwTvDEGRmUDj6Ce/zXmz4fntOPk1XtI/mX8GtG0KTTF1i 3j050MbwIuQVIwR3+9cneYDr/wArMHReqP09o8MnVUy4s5oEYFZM5yTuP/auCjqV1JMgV9y+4JPa hTxgzFwIsHvkEmun61ucl27v8vnjLoWldP6ZNPfwx38bj1PUfBUe2Pmupet/PD4XdJdHX1xJ1Mj6 jDbEqkQDOZMe3968Y5ZHikDi4aNx2VTSLyZbmICQRTMOSzA5zWf16bvL5Rtjp3xyaTrnV9XvTPJb ajcNIHYZypbIOf2ruLy8eZvSelo2t767hurW5xiSabGxfjHavMtL4JYJAWUofdO9NhPdQIypdNyc jnjHxWf079VjDk8ZqvWvqXS/Kz1FJe6nqP8ADUumzLNKku0lj8DOK5G8zvjZ4XaN0cekugrCHUJr oHbclADED77q5InkMkX6pHf3BY4zREtd7RSPGi7OQtbx4fH2zlnuaH05jb6XHbq5MgOWZu5+9DuZ lLEuu45GcUZzlixOCeeKHuAGSAfmu+nJ075ZfGO103Tm068nEKr9KmU7cCvQnwz8TOmOr+gZdD6n vbMWbqUR5nG0j5z7EV44aSlq9vcOt7HZTRjcnqj/AJh+KlbnxFuZOm001bm6F0p/UH/l4/avLlx9 7j2Y8s8dV689HaX4QeD7NqMfVWnXfpHfEpnQmNs9wAe9YJ5zPH7w/wBU8HXbTOoLG/1VZ4zDFFID IAT9XH7V5QNq97dMgkmk2+5Vjk0C7gimbcYyXX+okkipOImc3t6oeWPzO6Xa2MekzTrJbvjiQ428 d6yPxc8p/gr4p6pL1Fd63ZaJcTj1JWimjG4nuSCRXk7ba1ruiwLc2c8tvEvGcmgaz1pr+tRKk2p3 r7hgqZTj/vV/Xfpcs5n27J8Utc8LfL1q2iaH0a9trWrPKGl1C3m3fQO+7HY11l5fPMTod5p8WntO JLWY5IGDsY968Z7e0j0+4MpdpWbu7HJzWV6B1vrHTYQWeoXdqC2cxPgAVzx4Lj3ax+ya09WPGTyS eGHit1JJ1GnUKdO3Nx/MdLYx7XPycnitBdc3nQ/gJ1PpvTGg36ajfRkPPewNkMvyccA1yRN4z63d 27xya7qUtzg8tMdp/tmsZOs3+pM08sm+4P6nGdx/vXS8Vs7TDk8b09kfD/xP6U8XOhh0vrtwlw1z EUJY5U8cHOeCK1R1H5EOkoXnuYvEeW2QZb0Z5I1Uc/Oa86tN8Ste0RUisb25tH4BEb4xUvP1p1X1 JGwutZvZosZJMpwP965+Fkd9y9x1pd6J4e9O+IGj9P8AShS41eAj87dxNuR/uD967oh0TSdY8Kpr DU9o0ya0KzM3YDHJry98tE1jedWWNsqkXMRYzTMeG+K9Ees2uLPy09US+qVKaZK8T7sdh815pLvs t6Y54TeWjpvwu1GPXV6ghutKUmaKOVlWNQRnvXJX4g3mE0rxL6x0/pPp27W9sNJbddSxHKSPnP0n 7VzXP4wdRdQdO/w646g1MIQVEEU+IlHxisAKJbyhTI4de7A8t+9d8cXGZb7ehHky8SNJ00WMVzdq rNLh9xwyit0eaLyZWnmP1ez1yz1p9PuRHt3IAVI9iDXlhoHXeodK3cdxppJkX78is+j8wPixrGmX H8P6vvbO2iQt6cUxXao71jx+TrcfjsPzG+WnX/LfrtvHf6xHfWVx9Mcit/M/wO1Yjour6ZpGh3E8 ly8uruMQxk5CfesL6h6l6i68v47vXdcv9Xf+lrqQvt+4poYhaudpYs3dq9UnTlNnzXT/AJiWe5f1 ZnHLH3rozyr+KMnROtJDLMqrIVZfq7Y+a5h/MxxuGlyR9qNpmqNY3LywztHJ/SQcD+9ceXj83px5 NTT3D6g/hHmW8MZNM03XW069cLMTZyfXG4B4/auXJPJN4uDUGQ9R507fj1Fvjv2Z7gZ71xV0T5ne rvD9pI9L1M21wh/9tjl/71J9VedXxa1tTFJ1hdWCSjBEUh/8VnHC/bz5TbYnmA8MdF8I+udIsoOs LvqHUpxuuILpyxgI9vfFeiXlQhP/AAFbXCOHieFVGD2NeJlz1ZfXmunUtVubrU9QkkDSXkz5Zv3r cenecTxE6f0OTRdC1dtKsSu1XiJD4/epOL5+VezHKXi8WR+ciRdF8yvUdjHGI1dw7NjsawrRntBN aTPPmZZFYx+xGRWt7zqLVep9ZvtV1vUJtUv5cb7iZssf70/0++SJFmdzuhO/A9/tXpzw88dR5cb4 Zbe1Hlfg2eHsEiP6nqRKcZ7cdq8yPMx+asPMh1RbyoY2FwZHDcfNH6c87fiN0707HoWg3MNjY7Nn 5gAh0rUF31DrHU/UF1falfSavqlzLmS5c5aQ/ArHFhqWJn8rt0x5VfEW36W64sluSFieX9Z9hXff jz4eWfmN8HrnR9MvozLIyXUDKwP1LnCn4715BS3mudK3MKT2zac0nI9X9RH2Nbg8NvOX1b4T2Bg0 iVLx5Dyt39QFcLx3Hb02+Wr/AE7e8pvl11vwrknuuoisVwhPppGQQfk1zr+IF4taR1v4oaF09pNy l0+h5W5mjYMm5j2BHH2rWfX3nv8AFfrnS7mzXVrfRImTa7WH0Pg/BrnNL02V8Lm4nkeaRt8kjtks Sean6rljpxx5tckteznlODv4Oaed36s7T8cCvJrzQ2V1o3mI6ntLjK/zi8jNyQCeK2L0559+uvDn pFdC6cS2W3QYWacZ2/cVzh1L1LqnXfUWp67r1295qd64Z5s9/tXXiw8Zprkvlbkmdd0iO20CC+DC TewwmO9dMeR3wJ6V8UupEHU2nrqNlKjH8vJ2yBXJN1qMxto42lLRR4IT4r0Y/D6fQOntFXWdR1OC xIDYNw4UHP71eadTTfHfjdsG/Ef8r3hn4ReGdj1F0l0/BoOpm6EbCFjh1+eSa8/Ii0EKKX3JJ9Sm utfxNPMHD4m+I1v0ro+qQahoWmqQ35U5Rmznn5NckpbokEEcZZkXkbuT+1dMfUeab2PLlEGcBvmr JJtIbttNIeQfvQwVd1G48HkfNXLuO2N1XdP4cU7x+MdnCgzmByc+wxXV34h+oXlh4P6RLY3MlvMd VRd0MhUkYPxXmX5f/MZL4EdXpr0YW6uYkK+kOxB9qzjzE/iAdYePXT9row0G0sNNhuPzAkTO4nHv zXmww1Wua+XbuzyQ+KM2t9O3XS2uXy3Kqv8A6dJ2BbBH1Ak8nNF6k6W0vy7+Olh1GsTRdOaqcSSl cJbMTjaD/wCK8y/BzzCX/hp1bYa61zJc+k+54Ubhuc4rcnjz+JLrPjR0+em7PQLWys2cO80wy4Yd ivxS4W3VZ1qbekPmO17rzTegLXXvDoC6kh/nzwRrukmiYDbsHuec1yRpXmW8w+r3y6emg31ncyfS sl9aGOPP7+1ap8EfxIuofC7S007qEya9aogSNZGLPEo7BftWV9bfi5XuoadLB090zC0zAqDeJuUH 9qa24+mP9S9deIejeYvQ7jxVmtn1JTGEMGBGsW76RxXdPmn8IB4+eCk0Wk3KtexW35m1aM5WUBcl QfvXjR1P4ya54idW3nUPUN4bnUZz9EaH6YRngL8V1B5ePP7rXhJFDZa5cSavo8aYW0Lcp+1Z1Ze3 aTyjTNn4WdeLqkelydP6jZXhcxo0tsVib9z7V1h5I9Wk8K/GZunurvT02/kiMYw2VLMPpGfvUr1V +Kv07eabPHpvQ8t3elSY2nVWCt81wxq/jr1J1Z4jXHWmoSJaalLKHijj+lYsHj/Fby2cffxey3mU 8TOtfCvp221rpfQhrlqjbbmNAS6/fHx96510n8QrrrX7uPT9P8MxPfyHaqNI4yfnFa78HPxNrfp/ S2sOu0l6g3rt9SHk7cdjmpTrb8T7w30SzmfpXoeRNZ2H0rlo0BVj2PA7fNZmVvRlj4dVzR5q/Erx A688WoZevNNOmXcMRSztIFyI0JPA+RW9/wAPGx1K18TrSa5sriJJQ4LPGQMbT3rnHw68fk6l8c7f rnxIaPVLdpObVxlIgTnAHxXoBZfiB+CegSRvp2lNC+Mb7WJVI+1c8sfLT0Tk8cdSe2qPxatCv9Q6 l8P7u1tJ5oYbadZJIoywXLdj964l6N6rGidTWN1YtJFdWsisRKuDkHPavS3qL8RPwX12HZq+kS38 cYJUXMauB+2a89vNF4vdLeLvjAOpOhtB/wCHtEgtljeNUCCeQd2wMCunJNx5uPLxr1o0Df5kfLTY erIi3OpWwDH2DqSOabeLXVVv5a/K9cH1Y7S/s9P/ACtv6ZH1TkY4+feuQ/JP50emPC7o++0XrDUH giLh7ZT2Qc5xWrvPx53dO8foLLpTpOC4TQbOb1p7iXgyP8j/AKf3qcU8runJNXptT8M7r60fxE1e K9nWG+1UPOwlOMseff5NdheZvzByeAlnY3svTLa1Yzghrll+iNsn6Sa8YvDzxLvehtZs9atna3mh ZGSSM4yVPGa9EvDf8RzonrDpJ9P8TtOgnuUIIAiDRSADGSD7969GcmN9MzC2bh9pf4llrqk35fRe hG1HUCDstrPJdse3ArgXzbeNOq+OXjLJqus9NP0tPBAYzYz5D/8AyOa7e6x883l96Htf4p0r0vB/ H4gTbSafAkbK33wK84PGbxb1Txs8UL7q/UoViknYokaDsvyfvWuK7vblZd9oiBBC0bFskDOaymHr k6N0/cWtjCn56c4EjD9IrEY2Ixk5q0ciNKOcsv1YJrWXcr2cd8dO7/wx/DTSOq+vtQ1PWoor250+ 3W4hWQAguTjt711F52PM9rXgRddP6P07D+WlvgWa4Mf0AD2X5+9edfle8wV14CdU22swhZLeWTbc wf6k+BXo3qPmo8vnjFoVrL1bd6fHLCN0cOoxhpIye4U183j3268+7lLGyvKn4gdTeJXht/Gep4nW 4lnIhd02709iPtXNN3rFtpX4kc7XDrCpgRRv45IxW0OmPxAPBiwvW0KG9bStJsI/TgvHA9FlHYAd 688vMF5j7Lr3zQ6n1v0lcNDaRCJYJWONxj/q49jXefHF5NbydmfipdA67rvQOl9QaeHn02wPpXNu hPckkMR/5ry4t55bmWGNLKS9nYbUjij3OP7Yr1i8GPPh4f8Ai30k2ieIsltpc7R7JpLwZgl4x/Y1 B9Z9ReVbwvs7zqnSNS0m91mFC9ta2hyWf4xiu+GUsc7Lhk50/Dy1K203xht7C4SS3uB9ISZNrgk9 iPaugfxXelOoNT6C0XVbMyz6PazATRRAkI3fc3wPvXBWl+PGojxnuvETS4lspJLwTpCvACqexFen fhZ5yfDTx+6MuNG6ya20uaaEJcwX/wDypfuPiuOF8bdvTyy5YyvIGCe0cxGQmXGMqi7tv716afha Xlg+n9RW8GPzIjVzj2XcMVXV/S/lV8Jba96ks9U0y81KKN2isGf1FmPfbtxjnsK5G8A/NY3hb403 fVdhbGx6fvrg+tpsR25h9kArWXdlTC+WNxj0m8wPWfgVoXVgt/EawW51j01IZoWb6ccYIYVAdF+a zy8eHdpMOn7htJgbl0jtm54+M0bqLX/AfzZdJ2t5rt/b2Nxjs0ojuo/sWxyK1jqfQXlo8utpe67D q9rrlx6LRjTL+b8wZO/6RgYNXr6cdWdVH+WDxF0nxN83Gqa3ocbR6ZcJMIyRgtgH6j8ZrEfxYkvF 8SPD+QBzZfw+UHA+nd6hpPkO6jserPMnfalpliunWEyTNDbIMBFKnFdp+YXojwy8TrSw6W6/uoLS 4mP5i1cuI5sAnO18cDPtVvfpvG/ry7af/DZTUx4Y3zXCyLpbS/8ApywwpbPOK4O86LPaecTxBaB8 5niDL8EoD/tXon1V47+Evk/8IbjStF1q3vJbJGNppiSh5pJD79q8gta8Qb/xF8QNe6r1QPNe6pKZ SWPIGeB9+OK14/278WUy5N/T2v8ALbp8I8temQlRtksHL5HclK8OtWdIepNd3kPjUbgFNuTgOcV6 1+QrzA9NdQeElp0trGrRW2sWzNH6Ny+PUjIAAH+9Yn4t/hj+D1/Zaz1Ba9QXWiXspkufWa7X0Qx+ rtn5rfFk4cl8crt5Zm5gkty8S+mM8qe+aF+We5ilmX/lxY3t7DPah6xpcWhdWatottci/htLloEu B/7mP6s1UVy9paTW4fKufrX5IrGcsvbMH0UKLpPqCn1s7u+D9q9nvw67C0tfLzYTQKn5ia6l9Zxj c2DxmvFuwu47ByzIP1b9x9j9q7o8h3m2sPCPUJenupbvboN+Q0crHiJ/mvDn1ySvfJ5cFxdp+L3l 68Hevet7vV+rNXsY9ZbG6K6vkUxnHGFZuKzPorV/Dfwh6Dk0ex6u0ddNt0kk3PfxZGRzgBq1P41+ UbovzQ7OsunteFpql7tY3SyloZExg5UdjWn+qPJd4ReCHQl/qXiX1Ob24CP6XoSlVzt+nK5z3r2Y zfp4b61XLPg3fWOp+a63vNLbNhNr6tHjsQZDz/evUzzldR/8LeWvry6WRoppbBoomQ4IY45z/mvI Lyv6haxePPTz2koj07+Mp6Tue6b/AKa9WPxA57VfLD1V6lzHGwh3IhYZfj2pxzdrrz34Y6eKvSXU uq6dNDqVpeTW92BuM6HB/cmukfJhqE2qeZTo+9vZnvL241FZWuZDkn7VyzoFy8tlGrgwtKoVV+1d I+TG5isvH3omWV/SWLUUhGTwfvXPn+Nmnu/F8bx5benvnw6gm6Z8r3WN5C7xzbERGRiCMke/9jXi x0r1Nq+k6hFqNnfzwPM2WdGIyfjNexX4kN5Db+VHqhZJERpWjCAsBu59vmvFbQ9UFvZJCQ2FPY+x r6XH4/qy/t8zjx8s49u/ITCsvl30m+f67y6uJHmnPLScjGT715vebPr/AFo+cPq2V7i4g/K3Uawx FziMDAwPj5rqr8NXzJaNJ0n/AMAazqEFnc27+pYvM+31mY/UoP2rO/H38PSx8YPGhevLHW4dOF26 SajbzqWMm3/QQOP718r3j/t2ykw5b/ToTomT/jDwM0s6nBv/ADmigSxyjO/+XjJ/715W/h+lNP8A NRIpQNHHd3USJjt/MIFeiHmZ8dND8r3gjJax30A11LAWWmWsjZZyFC7iPjFeav4f93eXfmN0+69P fNdTvO6j23tlv967avjK5YWXJ6BfiXdaX3RnlyuHsLqS1lu7lYC0bFSQQfcV5CdH+K3V3RLpf6Lq lyZXwXG84J+/zXql+LQhk8uVrtYDZqKueecYPtXkXoTotkdjEqFU5+9d7JcY54X5Ea/q971Jr1/q mrMfzt83qSSH/VTW5vFa0VodPnmjTCvcFDt/zUxpNkdZ1uG0mQsXlUqfkbgK93ukfA7oHTvCnTLV +kdGdP4OskjSWiMWYxAkkkZzn3rEy307ZY+EeAct3E2EtERSV3HDdj8UNJriKaJtgGTzUz4kwWUH il1FFpiRR2H5iT0/SGFUhjwKjVuPykaQyR+tO3ICjJrrZpxZNDoUmoWUl+l3DEYhn0WYDP7U+6Vk R9atnXgl0yv3yKw64vyJEGwqwIG1xgisl6ZkMep2cpHLTqp/yK83NPi9X4385t7/AHhRBBP4SaHF MFa2ewVZQ3AKlec/2rD+g/Arwa0XrJtZ6X0/SJNchf1d1pdCVom/1bQxqa8Nd0vgBYg5VjpDj/8A 1mvJPwl8cdS8JPH2bUxdyR2lrqRjuY1Y4dN3Ib7VnGfGJcblndOu/wASrxJ6phXR+hBZGw6b1aUG W8U5/OduPttrqby+dG2vQvgRoFn0/axR3LWAkyw2+tMR+pv71EeYDw30/wAxXgmz6e1q9+LcX+m3 zpv9JtuSFI9yOKbeWXxCt/ErwWTRrK5ay1/SIDp1z6vDxyjIDgd8V0uvThqtKab5bPH6x8W/+Mh1 NaZF00qwm53IsbHJTaeCMcVtvzsdKQdW+XDVU1fTorm6g2S5JB9JwDllP/itI+JB82PT9/ddPaHY vrmlBy8WsWzYkIz255rT3mS6X8dunvBxNe6269aOwkkVJtCLkSBvhvmteHS43ecdZfh59Jaf0j5c 7S7ht41up55pJ5woDSAYwCfivPTzM+cPr/xC8VdbfStQl0nSrCdreGzhkOE2nBP3z3rvn8OLxH0f rHwFh0KO7ifVrKV/zNkWw6RtgBsfGM1yP5i/IL4h6D406rq3h501c9QdP3Mv5iPLjueWVvnmmOl5 f53bS6eOHXnjnD090v1JqY1DTUuURI+C3cA17O9HdGx+H/hRZaJ0fp8Fq9vYr+UgdtqCVlyWY/uc 15G9Z+A3VPgP/AOtup/yGlTTXaKdNtk2yQtkE5/xXrR0t1ivif4NW+s9G6hFJNd2AW2uGGQJQuCD j3zXGSzK7d+Sy8eMjnTw48J/Mj0z4uN1TrGqaVfWN1Kfzlt+ZBEkWewHZf7VJficdBab1J5YtW12 axibWNGaOW3uP6otzAMM+4rUuteIvm06e1VLX/hmaW2t5SEue6yDPG75rVPnh6y8ftX8NtITrp7T TNEvJNradpwKeoc8eqPeu0mu3PUtnbXvlX8eev8AR+qOmelrLqaW20ae5jCW/BUNxXpT55VkPk86 99V/UmOmp6jjgM25MmvLXy9+D/XZ696Wvh0zepaw3CNE5Qjf247V6r+cDQNS6k8pfWOmWtpJNqc+ moPy6csXypI/2rHFLcns/KxxxmGq8U/DDqC56G6m0bW7GbN5pk0c0ZJ4wMHFe4mt2Y8xnlnu7S3l jWbqLSFDPn6RIQCQf7ivD7VOkde6LtrRNa0O70z1lCpPKhCt/tXp7+GF4i6hr3RGsdJ38/qw6f8A zoPUOXwxAwPt9q9f5MmGc082eM8NxrX8NHwKv+nPFrqPWbqJRb6GZbDLDnc2QCP8ZrZPnb1e38Zf GPw/8EoLiNIbu7W7uriN9zRsD+hh+3tXTvR/h9Y+C2l9X6rasssdx6moyDGDlEZiDXlN0D5gbHWP OrZde6w4ttNbV2keT+lATt4rz3+3DDuvVXq4TeCXg3cr0T08NRutOt1htrG3XaZHxtLnHc+9aA8s Pi5446r189n4gaLdy6NdNtSaW39L8vk98++K6N8V+ruotK8MrvqDoOyi13UViW4gtjyJoyMkj9hz XD+i/iFeLuuaymk2XQ8NxqMj+lHCLdxub4zip79JO+mO/i++E+j6VcdLdd2UKxanqEzWl00YABVQ CGOO55rzvt1cQOrOWOOCa628+/i/4u9dWPTei+JXSsHTOnJO8tqsQO6V8DOc/GK5Ot4yykAgoMYN ej/jHGxlek+JGpWmivpN2i3tkybFSQ421AaFGRq9m1rCLqdpgFtRyW5/TiljT2uZERVwOCT7Yro3 yD9EdO9T+ZzRrfWYkks4YWuIFbGGlX9PfvzXHO7mlwx1du7fDbXfHLq7wm0K26S6Q0zom3tkEW+7 m2SSgADPpn2PfNb38F9L8Q7DStSTxFurS+uGYflzbkMuzB3Bsf2rXHns8UOq/CvwfguukYpI7u7u vy0k1upLwx4P1Ljt7VF+QnXfEXqnw91PWeubm6ura6cfw+S8Yl3UA7iAe1c8MfF3u8ptyf52PL9o mneaDp7RNFt/ysPVg/MXCwp+ht+CFH9j/mu8pB0V5QPApru20+PT9K0u1UtHCuJJ5SPc9ySe/wAV zR50+prbpDzi+Euq3aF4LW3EjAd/+aRW8fO74e33i15d9SGhxyz30cS3UMEfd1IBP+xrpJu9s5Wy RyNF+K3ql71FK2o6L+S0N3KlbfLlV/8AzVoDqu4sPNb5nrKfprTGtLDVXjjaMpsMgDZYkfJFaj07 QtZluv4HbaJe3epklFiSJlOf3IrcPlU1W78OfMp0ynUllLpdxBLseCb9S54Brjl8b09HBj5e3qhr S9FeTXwXu9S0rSYLOztUVTGnDXEpHGW+9cjad+LHNfao0Oq9GxQaO5KyyxuZCF/b3roH8RforUet vLteNphlkktZo5ngj53rg5PHxXkMkE81zHZ2dncyS7APRVCSWHc9q1ljNbcMe726h8D/AAf6Z82f mn1TULS1l0zo3/78kijTHqFeTGRxgNXevj7486D5VultI0rQum4by4VAkGlxKVSKEcZyPuK5U/C8 12C28Rtb0uRDBd3Vu0gicbThe+Qea6u8zPjt0J4Q6pp8XVvSMnUE88W6OZYFcKMnjLD+9TD5R05M dZanavBfxN0LzhdAa7Y9Q9MwQWyFYrmyk+rJYHDA/IxXNPlc8LbPwg87vV/T+nRJNp0KNFbmdASI yc5H3rYXTP4hPhhovrJovQuq2Jkw0iWUCjeR2ztFYd5aOvpvGTzia71Ra6fLp1nPEZVguBiRI/8A q+9dpOnL/k6U80/mD03y49NWOpto9nql7eSNHFbyAITj70LorW+i/Of4H3CXWmwxi5jNvdxekCbO cqeUJ74yOa5Z/FT0PV/4poOqPHK2isoSKRfqRXAG7OO3962/+GFo1/pvglqk15DJFDd3/q27ODh1 29x9qvj1tnbkXwp8dJfJH4o9a9KjQYeorUzm2SWZtjKqHhvvn4r1A8P/ABLi6v8AB6y62NmtpDPY yXZtVOQoXdkf7V5CeavT59X8w/V/5RVZFuZA7/BBr018A1kXyYaShyZBoNyMDnJxJU8dad851K5s 62/E+0e1h1Wwt+iLa6k+uFS3IbuMmvN/Ur6TWNf1PVxDHaJdXDTLAh4jyc4H2qX1z/02uamJmMUv ruDG3BxuPzUW0MHo7slsewNenUxjycl7ActLiUkBGPKZq2p3kUzW8SLlcfUB7Ck3MPqlfT//ACRV RwxkqoiZn2tu28cVwvUTjx88pi6t8hXk4tvMDr0nVGvkjovSphGbdTlrmYY+g/b713n40eZjw18s 93p3SVtpVi95BGm6yjiAWCL2OccmsO/CyitF8AL78mVOdSb1APY4Gc1tHxF8Q/AOz6xurXrEaAdZ jA9WW/tlZ/2yRmuW+tvXcJMrjO9Md8ZPAroHzkeD8OvaJBbQ6w9sZtP1G3RVkVgP+U/2J+ea8sPD To0WnjJpfTetIJZbPVTa3kStlWKt8/Fet8Hml8C+gtBuP4N1HpEFvGpkFjpsJBkIB4AC4H968xOi NXs+rPNKdbs4/SsdS1lriNTxtUtkUndb4cd2zT1V8V/BXwu1vpSz1Xq3Q7CC00WBZ1ugioQqjJT2 zmtWdJeYXy+eM2lah0Stnp+nW5jaGOC5tkiUp2BV+4NZB+IBf/w3yqazKvH1QKMfcGvHv0pkeC5j YoQNwdSQ2fmuknW3nmPldN0aH4P9MaN5wIuk7OZNe6bS+RkIOVkBb9P7CvTrxh8r/hHrun2ms69o Fjp9togEjyRqEEsK/wDtNzjH+9eWflcjntfHjpmd2Mkk10n1HknmvRr8SbXLjRfL1J6EzQ/mLxIW 2HGQQeKxjfLJvl4/1aQeka55X/GzR9e6d02x06A28BidZovRK8cGM5+rFaA8ovkP6a628SOqNW1+ Ya/0fot2bWzgf9Ny3cZx7AVxZDDLYqJ7G5kil9Mn1Y2wRx2717OeRiws7Py4dKXFqo9e8h9W6kHd 5O2TVyy8cvBymO8fJjOsWflr6R66tfD+40PSodVlACwxR7oUz2Vn3cH7Guf/AD4eQ/p/Qemj134f 2B0v8mf/AFmmWwJRlPeQdyMYrl7xTmum8furJ0mdJ4dfcou7HPqDFet/UU11q/lo1WbV0/8AVy9P ymbcMc+kcZrOOfem7jNTJ5LeSvw50br/AMxHTdlr9omoaX6rE2sv6ZMD35r0f8TPJp4JQ6zB1jr2 i2Ol6HpsMn523ZisVwf6c5PcewGM1wf+H/AIvMl02oYMqu5H+DXVf4qHVNzpXhzoekRzyR2t9Kzz RKcK+3GM158L5ZVvPU0cav5d/Lf4+eGGpDonT9M0y9RWWG7hcpPAwBOdpY8cV5Lavo50PXr7TGl9 drK4eAy//hApwDWUaP1PrnR8813ompXdk0oKgRyEKQfY1jshYF7q9O65ldmfHuSeTXv4/jO3z+S9 9Hd9Z2kVjBPbztJNu2tGwwFpq7Af/L5qwcyoFBwqngGk4JJ7H9qIcQ3TxRyqoB3ptOecCm08Qe2i G3eF4I96KnJJAwf+9KDBGLexGMVYbNDbeq+VH0CjLpUXpnLFSe3NFRsBsgCrTTEGLbg7jtI+KibN obb8nExU855qznfkkkEdhTq4X0XCEbc84pjcTEOSoye2KLpTBpJI2JyVo5LXc+18LFnLCmrSEKhb C5PtTjJYAbdp/wC9ASa3iiO22I2d8GgemNuf1Y9valenI7/SQD7bu1WhV2uRF3cjJPtQNxFI5Iij aVz2ReSaVLa3ylEntTbNnlW74qQjglt1aWKX0ZY/qUg85ptNrM+ogS3MjSTg8uTzRTiIxafKI55C LduXwORTBmjWZvRk3oSdpPequJ2m5Yglv96EVhhGB/zl5YD3ouzhxjls8DmrI6zEqRlV9xS0inn0 03QG6ANsZsdjU/0l0ZZ6n0/qeo6hfrbvAMwxqcf5+aJti7krJlhg4+nPvRN3YEYVu/NBYm4uPzBO 5EBGB7UW3tLnU/UFvA7hBufaCdo+aNUJrtWPpKcQ/NFjtogytIMqD2zSJrERgMnIPvRF3PCUABPz RNmtwGLlUXEftzTvSUkhjmaOaWIMMMEJAYfemcz+nL9Qz9hShcF3iEW9ctgqT3FAr0AkwmOWkTsR xSlZpWeZsg5xinN8n5WZYycMeSKEoDPnPHxROlKzMeRQ4pTLOQDnHeiNweDT8au38JFmttb/AEf+ 6F+s/uaIaTfSm7Gf2obZaH9OJCeKqOMSxh9xBHcZ4osLDcpJyAaAZUxHawEn3zV7Xah+o4HPAPNW nZPUbaO54oZ2jDHgigU8W5ywyVPt3qgqq64GR/qokMM7W011Gh/KxjLvjtTcXIKDaPpbkYFUOScO Y1znFAW1fY2ZMZPv7VdWaUhc7Qed+avcqAyoG3Ac5z3qCyMQ23OR/wB6uF9UHAww9hSl2yf0gFex paxOo3r2+RQNiNvY8/FCdmIb6tuBx96cyxeocjuPigSxLINj/qzkEUGZeG3Q1x1vY6w8UxWDTIjN KQO/HArDr5GKwy4+iQnAH74rZvRni3YdJdO6no2kaRNaXt5CUmvbkgxNxg9vmtaWj77CTePrDHHx 3zRnZVhEqSEkYz25o7qACFUZ+TQLVQynaxOPmnCxkndwaHY0UY/VjDAd6PDvC7jwc8VaIgJhuQO1 OLaMuXAbuPpz7UNrRyAv9fZTkr/qp/quo2OoWqG009LIrw4Vv1n5qNZCpXdlmFHMShPYk+1A1mkS aJMJhqHdMLTTZriTOxcDj5PanXHIxuYfFVNbJdQPbyEiNyCV/ajW2U6t4Va/0t0RpWuakIU03UwD EIX3OD8EVigCqgUE+opwwNSX/EusyWUNhNdyXNhAwMUchyqY+KbTF7lneRVDHk7RRr6IiXAYE9/a krFgcjsfmiIuEx+o/NUxKnBxmjOwJIP6s5J7jNJHEgZe/wAUcRBc85J7ZqjtYAHufcVE6P8ATdV/ LiTdCjkjGSaTpIspVvmvZJIm2loQi5DH4qOaBscfTS4J2gyNuQOxqKe3N1+YhSOK2FuiAcjuaaOM 4xmi+q0qn/tSOGyRn9qBKrhlz/alnBbYf81cYKnnv7e4pXpKYjzyff3ptCJWIjUZz8VZHLgLtwR3 OauE5A4wPelwqAu44BPsasURW2djirt+g/NJ3farE5YVQl8kDYM/NICbvb/ejIckkjvVRxgtncAD UqqQKV5OQaFJEpbGOBTgoOw/TTcn+ZjPNZqKEG3O4Zb5FOZXzGueWA9qSjgMRnP71Tn6MD571lQV +mRmLfq9s9qC1urylslQfiijPIGDj3qvt7UUkIqY2ZH70rhs+xqsfeqHfvW1JkAIC85+aWoBCqc/ vmpTRdC1HXre5l020N4bZd020gbB81FyuZApAxyQ32IrSbVLkqccoKWSr26tg5pEeJWaMN/alAGO HJwFFNmyAquBmjxKhRti0OJlMIdsEltu0Ve5tp7qEJZxsif1MTnvRDS7WSSRFihmlRTlpI0yoP3N SWudUXWuNEWs44BGgjG0YyB71lOg+I8PTfRV101caSsjzgj82o+rPyaxnQ3sbi5W1vj6ETnAnPZK vSyoq1urvSJ1uLSeSK4xjeB2ojyyXBlnuXa4uX5ZyKd69aW+manJbWtyLuFf0yqO9NFkEaEE9+1Y IbpHJaJvDEo5yyijZWTlkyD2+1GhmCdwCcY5pDsFJP8AtRQ5IQ6AEHnvmmhhK5xyAe1HnklYhEI2 +7UqUiMfSM1ZF2ZXW0OABxS7Gcx3C5XGeOaIFDNvxjHsacCzW4VnSQA/6RW4GtygmuizDdjjGeKb hB6h4wM05LhJeXB9jTKdgWH17QeCTVQdhlCCPp/ekqq8ccfNXijeNApIb3H3qnJ9PIGM9qCpIlZT jnmk3C2hliacFgOGGBirxlpMIvGTzR209wcNyMcZrllJfay2ehzbw2+JLe9cRP2gzkD+1InVWKkD DCmKWii5UhwjA0e6u/UYqRjHGRV31pPY1tsmkZHZgAMhSeBQXVQCv6hnuatbPl9vuR3qiQ77A2dt ZA2CqSQOB9qNDp0+qGO3t1VrhjkKTjNCALsVXuvcGipDcRSRyQyelIp/UK1FGuOn77TZWjvYjHIv dR2oTrEUCKmzbzx71e41fUJGKXlwZzj6W+KZm43DBOPvVQYJufBGfuKuYvr5JIoUcnpj0yc7uc04 Mo9IFcsw9vmgTFGGRgAFbPerqN2Qfb4qx+pAoG37UpeFz8UTZYjDMM+3tTr0I8H/ALUzjcNkgnFE a5Cgk1qIKwOMKv0/ekOpYADAdewPvQxcs5BRsgd6W0ihhuGX9vtTR/oWKVozlkAPxRHuGkO3stBj OU5PPzVK2c/NIHCQiTIx3HelpCLcnCDNJhl2kZIxSi+STmmoiw5Uhz/mqWMMoOMH7VQYMuPftzRF UIozkVNC6WzyOojVsn4o8NsQ8iOcMByaXbX0kOFjOCvuaTNcPIS74UsckiohvcWMaFZAd2DkDFJl V7hlyMKDyc96JuwQAcgUssFj3fBqzr0t7WOwIBtCY+9U8odcE5+AKGxWRckZzVbQpHHHzT2KSPbk bcg/1U4gjWKRX28L3JpKyA8fPYUReQc9jUDoTiYMV2hSfiguyJnjA+KqLA/UPpHGBSmhTcsiHd8g 1nRrvaoD6Yztwp7AiiPKxPLD9jVonRQTP2HIpYeNyZFUMParqARVyACBiniWcUNsMzZfvjPahSD1 9pDAAfFJChgB+kigRJG8pyG2jsfvSCjIhQ845wPejOQi44xQPVCbmfjHY001ukxTi4iZIzll7hSf ppayukYAGSe+fespudc0W+6btrS0so7a8U5lmQYL/vUBcogDYbOK1rZKb4eNQQcfIFVtC8jhj71Y SFAOxpTS7hnAzXPWmtqaOaUD+dgf/HmgT2wIAuZd6/6e2acJMwzxxQp2DFdwDD2prva72CLaPA2b gPjPelyWwKkLlAe9XT3HAP7VaSQnANVqTRlHaW1vuK5Z/kmhqmyUvnk+1O5iBGeBn7VHtd/WY2UL tH6qPTj2XLIUdmAGG4INRolNu7COJShPIJpzJI0ke0Ddn3NNykskUYSF2djgfeprTWzZ4VkkZmtw CO3Par/l/o4Jx7qRTsxyWz7ZVKSAcq3tSHceoB7mrtkKKJQeVGBRHJTLB9vwPahE7MbTuoc06QbV dshu1QOI7WO5uTKSVmbliPepmWe2ktVgNmY3HJm9zUPaXf5eRTs+r2zUk+oPcABux44qeMX2ALeL BPJx2+KvI0s8arI2+NTwO1JeUQgpncB3ND/NMxCqVXnsea1U0qS1iTBjO8g5+wqzWUt/LuMvqDuc DFOihTfmWJlYcKg7U3R2VVCuVx3xUl16NSlNaiQIq26tsyAwarTQWot44vyoRc5ODnmlpP6TlV4B 96W868dj96z7X60A1pBI4ILJIRjgYpUDtCzBfoftuB5pRmyPqGW9iPalRRrvO5xzzk+1W3fVZ9el hzERtzIe9bJ8t/jLp3gJ4p2vUWtWL3VmntGMmMfNa7W4ht2G9wwU/p+aYzIGvHlGWWTvn2rncN9N TN6W+I/nf6I8ctKSHRTJbOg4a8GwH7c1ofWPErRtM0m6hu5o7l3VtrIQRz965IlhVA31yrADnaDx TpYru7tALeVvQHcSHJr18OU4sdPNyYXP0vqTQXOqzXPpkoXLIQx/7UiVzKAyj9xmhwJ6LMAQxAwQ feiIc/pA+4rGeX7GuPDwgEsVsxEhZgf9A4oN5ayyyo9rI8SkcoHIzTp2VznGBVyMnJ4rE+Ppuzfs 0sA9qxWVmZW/USSc0VnRNymPcGOQaMq+oxTGffNImWP6eDgd/mrbtJJPR7bTQRWojdQ65yB3pnK+ fWjRR9RyBjsKlI/4NLZ5tY51uFGXaU5BP7VHq6ygMf1H3rFxmXtuWz0DvKKhhVoX7eqCciiyTS3D +ib2cnHILE/2pX8vHLZajW5t5rhYmISRud32qeK7AMJCIGn9Rl7KwxTm2uLlCAJGiX4RyRTttEWR X3SrICcIAafX/TMug2pN1GY5CudmO1ax6u2EHMj3OWdndc43d6j/AMnGDlFIIOVO0Zp+sjpCxRyu eQp+atFe+mVLgE+4q2bJNelWF7IsjiC5mif3LMSD/ajTL9Xq3EzzPg7Vz3p29raXlsrxuInJ5Q0C W1gtWVvW3t8Zzir7mjSKazhinjkjUOPTIYMOc/Ip1aavcxTBbaaW2cd3R8UuR1kThRTbarPlTtHu a5zGT0t76qU1Lq7WkYRPPNcJjGSSRUUF9QiZwEm7kqOaOt4Ym25LIeOaD6iAOQ3OexrozJpJQ9RX sEZQ3soibsCx4qI1PVHe6jlaaWedDlWY8ClDbNIiIhmY/wBIq95Y3CxcwsgXuxHOK39aXU3tvzwy 8+3XPh9of8Ak0m21K1jXak7vtwP2qb1jzdaZ1hbx+sv5K6xl03/SG+K5Z/LoVQByyt+rFHtLPTIb gLJCzw+7N81z4sZxZXJrPLz6bq6q8yU0Omz2mmEyNKuGCHNaWk63vbm6Wa4hwxbJ3c4prfQxRzu1 iCiE980KeHcI2JOcc59zXo/Z5PJ+ib22ZovWKQW3qiTEhXAJPb7YqB1k2d+jPLbrMxOQexFYokmy DYCcA5pzDeO+AG4rldV6cbqdJbTdVudKVRaM0C5/SG4p9qfVN9qQRLsK6Adlbk/3rHhIHY5JA+1K EqRodxO8n6axlLZp0lS2mX99pqMUnkZCcqPUP0j4p+/VOpTSKY1kjQf1hsGoe3mkKkpGzZ9xVb7m WYI+6MfNYmOjpltj4m9TdPzCayvbgMeNjSll/wB6mNT8bde1WFEuraKdyMNITg5rCdP09Li5SOW8 9OI/q55FE1K0s45G/KSu0Y+kknPPzWpuJ4g3WvXVxeyzC4uYJRyBFKVFT3Tfi71R0+6/kdSu2I/U JpWI/wB6xV1b0SxbkdsVTMWhRd2R/vWdLe5pszXfHzqTXY0TULCG7jAwGPBx71hk/VupC79azurz TlPO2KZgP8VFQgo6sZG+kcCr3FwzvvDnOOKtm3KYWRsXpjx66u6fjPpalJcwj9K3UpJP+adaz496 lrmH1GwFs55E9vIVYn+1arEkc7BpgGce5FOAdqgykbR2rWONnR+tnFl42dVabKHs9ZvNoOQDO3b/ ADWwdD84nWeliMSIbtB+pXuGGa0ZHdpCpjjRCG7lh2pMUSXEpRsAe5FWTS3DrTpS9871/rEEsc2g xOduHyxJNavv/GHUby6a5tpJ9HcncDFMQP8AFa5v54dOkEUeQMfq96tZTSXu5ZlJTHBcVvO+Xtxw 4/C722vZ+Y/rCACG5ujqVoBgvI3IH71FdQ+L512MBLPDNwrqeQawWSAlPTQBUPcj3ppIoglwhIX/ ALVzx3Jp1yx3dsr0XxT646ZZodM128gCSZI9UkAfas30/wA3PWdlB6Gsytq8Xb+a3JrTk0siwMRI wPt9qDZE3MLDHqSjtmseOqa6bi1LzD6d1EhEWmmG5HD5J4NYDqviReXbyLHChQnBwc1jfp7cNsCy YwSB7U6s7OKTcWKoCOa7zNy/XN7AudSfU5YHaMIFcEffmvR/yhWpXoG0eT6WZs/7V5z3EMKiD0Tk jkD+9emflXsRB4daSXH1MNx/xXyfyr8o+p+Pj1XR1haW4SE4+sD9VZJawpGpHAwOPaoLTfRWNBIC R8+9ZJClvMqsM/s1d+L0xyKJGD71jurAPfxjGSD2rIpo0IyDgCsfnAbVRxnHY/evdh08WXbFutn2 QqfcdxXP3iFLujlBPtW/euSvrOOy4/3rn7xGCrFL8gV9ngy1HxvyMfpy31wy7p+c8mtH9SODOTuw 2cVuvrw7BMR2ya0frq5Z2IBJPv7Vx5rtz/Hw1UfArLkMOD2xS4/qGWOGFVGSkC4OGFXY4+MnuRXz LX3MfSxIY4HBoI3CbOOPijqqoe9WKgOcmgItxtU4bA7GrtN6jje547L2poxJUgAYzTv1UlcIYt0q rw5qVTi21FbSXe3C55zW7OjNRmbp1Vji3IPqVh35rQVpFPPqUdo8e9Sea6M0CD+G9N2wRghYbSq+ 1evieXkdcEFiGHNXV2YfH7UNWwBgkUQOFzk16XFYZI3ZI+aUATilqQwPxVxj0wf7UXZAyg4xmiiX sO2BziglwaosRk96NClvg96TuIKk/wCKQOffn4ogUGPLH6h2omiweP8Apz+mrKeW9hQUbKjH980o qJCXBNEoisCCQeau2d/9qEpwBnmloeOaIoPtOKLvDRngYNAxuJIPHaq5Rcocn4osKZTGgwKEzHdj tSy7twaRtz25/eiLAYcZOR8e1KMiZ5Ucn3oYBYZPf7Ulkw4XuSOOavQdosahWHGKmNE1y00m6We4 T1Y/9xWOM0iRjd/tUbLcOCdrEf8AmtSpWw/EXrDSOrtPRrUHfAMRqRgr81rdmWRcrwR2A9qGuRuB ySeSTSSBG30k5PcVmKKuYzvDZ/enj37GEIQo++KiyxPucClCLeCQ5BHsTRrQjSh2zgd6GQGzkYPz SFhJP6jV2T6gA2PmtKSQEYbRn5qnZt2F5X3JpQHpKP6iferF2PYAJ7kUFog5Ymlxj6Ce+KC0rJwv Az71ZZtsik5AHcfNSArJk5/7VdY2Uc8Ur8wA2AueM59qSZZH/UMVWFSqN3yPmrKSSVPakhtyE9/t VLkMTjPHtRelbpu6Rgj4NV6knfZgY7fFXdie3b2pLSFz9J/cUNhMVkTeTyKBLMcnFGaJDEwAPPc0 hQrKVK7OO9EQ92Gck9xURdMYw4AztGTWQSqJplG30wON3sagtYZoj/KAJztbPvWMnTaJ/NB7qIxt wccVtbRbnEK88AVqgQxiRGX9QbtWzen/AK7FOeSOa83J1Om8fbc/hhdbNVjY9mxgf3FPvxFofV8s 98c4C3ELf71AeG0oS5hJOSjD/uKyr8QWH8x5YNVPxJCa+Vbd2vfnN4SPJzSxFcQO86Y5+gD3q95G uwmN/wCwpOnQ/mLeMhsER/pFTnTPRN31Fffl4/pIUsRjsK9GPpxnUYdFMzsVznB74p0QyDLLkD3r Km8NrqW5kFlNG2Mk+rzWJapdhZlgi+lkYox+SK6xncHinj3h2IyO4xRZ7mObO1QBj3FQk4nSRHVC 5zyBRsszAlzu9h7VQ7IVcbucdgKt6qqfqTdzQySsgRhtc9hVuw3HsD2ogtzIDMmBgY7AUNiWjK8E mrGRgmcZPyaOViUrg7iRziio+6WYRDssQ7sR2q9nFIeTh0/1Lzmti9MaXpup2Isr2AyepnkDkisd 6s6Iv+l7drqwic6YpyHAyFrWumfLSF1DTL+zMcksHoRS9mZcbv2pqzbJlKktx2pc/VerdXXFvHeu CkCBYlXhRipnSOmdU1W5hWGwd43OA4HvUk/ot2jRdwWgja5tTIrE/wAxuMUweWRmZWOQTwftWy/F iwsulOlNIsLmJE1GSXMkbfrC/wD0VrSI+pj6CvHGfinpnsuJNhBbtT60uxC43cJ8U3TZtIY5Pt8U MxuWPz8GtM1kMl3aywcIC/7c1HHDNnbjB4pCRPHtzznvintvAZMk4GKMzoe0JQYwD+/tTsZJBABp jFKiNwcnNSMeMcdzW4xacQR7eQMU5jUAnH+aTbxl+D9FOYl3AqF/vXeR5srsWOEArkHHwRRYV9JW yMBjn96VG5GB3PxV5CGTd32ntXSOQU4UDBH+KqC5OQjvhR7UKSYmQg457UFjmRScA++KRnZxNJvf gfT80MSEAcYFILZU84PxS0woAODxVJtdiHGO9WOGG2rMQe3FWRiY3+B7+9aF2ULhSM496tIgYheM fFA3so9z+9WM31hucn2q6IuYgJgVHHxQ3jDEnOPjBopckt8jmgo38tyR2rGl7CltRDERI5LfOaRI 52JwDxjPvVKxHJIYNx84pMo2NjvWWgRiQnAxVOmOMc1fBUbu4NUo4z3P3q7QkZU8djSwucHNWwVw BkilxRPLIFRCxPYD3qKUXG4EjOaVG0aBsrn4q11a3FnK0U8LQSKNxV+Dj5ppNOyxb9uVPGR7Us12 1KLKyORjjPsKH6alto+O9C3ngq37U1NxMJGC5BJxRfZ1c3GEKMAGHYexqPeXPf6SPan50u7mZZFX 1Qo5Q96zBvB+W36cGtX90bJZCFSKQ45NZo17L6giEqsVwcdqTFL6tpJu+on2NSuqWD6WywySJNGC fqTsahZZTJLtiGIvmueU06bWS0DEO2NvbGacG0AKmInHIPwKbJKIZP05PwaJBn629Rvq9vapj7N9 Mp8Qdmk9M9O2iBW9aLex+DmsKSZGtmjxgZ71kfWP5iXSdJmnglW2SPYJX7MftWPNYiVVaKeMt7w+ 61nOdrjaSkkUT4OBkd6B68mq3P5bTrYv6fMkjDFCnZo5AGTK/NGteo7rRp98EAIYYyw4xWNt7Bv7 V7CbEi7n7cjtTMorZJIJ9wBR7zV21FjIyFpGPIHtTYKwOQDn71l0lWSIZIxwO1GSFWIAHI96HAR+ og5+KFKzDjJXHYigm20tBYiUOBIvOwe9Mzp9xcI1xCAUT9Q3dhTKGaRlIDsP3qR0vUvybFgm5ezB uzVTZpFPGc5JbPApRKlyMVWr3CT3263jWOIgEKnsaVpWmavq/wCYaw02W8jgGZXUfp/eiRcR4GTj P+aPBGhlfdOIAe7Yzj+1RttdSMHEiFXU4wvtR45FMoWRcA9/vWdLs5S6WL1QGE0IPEuOapZDIhdH wB3zTaRtj5CD0x7CgNMwm342DtsHvTQfT6ndXNqIvUwin9GKd2WlQ6pZKwcJIMgnOKjEnHLHg9qs JeDGjlAeTg85q6DqSxhtz9L+oc9z7UZGL7VJGPjFNFnVwqjOR/vRUQkkj6fiqT2cTKCoCqoye4FO rGFreT6iCCOKbIHAwy5HzT+2JCgEdzxms1vGDxn6/v2zipEXz28DJFkhhgmotiVJwM0v196jOeP9 6zt1lTPR3WuqdAamt5pp9aRj+gntWZ9c+afxL6n6YuenJuoWt9HuIzG9tGv9J7jNaoupjBgr703i k9RyCOWrj4N+ybGJbO1Furl8gZPvRgwkPKjmpzQekrnWbhbazMazyqxX1O2AMmoS7VrOVo2/UrFS PuDitTpMZo3kTZLleSDyB70lZZTA6GRlU+ytgGlvIqocjLn3pu9wFB+jj71HQS1nkto3iVhsPfil SFZsN2x7UwkuSGyAe1Ae6YDHYmgcXUSBRj6s+1MXtQ4I5I+e1GMm5eQRigyS57PTSUWCUJCYlwFI 7kc/5q8BFtlgQ4Ps4zQJ2MURk42gdqZR3jOu7axHxV0yPcXbzSkD6MnGB2FKjdwBvbcAfimRd2be QQW55qRsrhDKisAwfgn4q2JLTu3ZpORj7n5p7DKUclT9QHxS5rOOzt1k9ZJN3dV7imqy42kYw3Y1 YVLW8zIM4GD3AHBqa0e6FtcJMmI5EbcrY7GoS2HqqAoOKlrOLbjAJXNbmkjKepuor/qd7dtVuBdt CMRMFxioKS2idWUx/T9u5pwP5acDcD7n2oLE8n+kUaNkiVYzEE+n4po2nwSsVILYOcE08LuycADP vTSeX0SWVTn3NTTFM5bOGItIkOP3ORUcd6uWyGB7LjtT+7lK425Ibkg1GyT7JCcVizSzdFD7Lhd4 B98U61LX9UigEP8AFZZrPHFvG5jC/wCKhZb0gFdpJ77qYTTls7kJ/f3rOU31XXG6N0t/SvzOga4l c5w/OP7+9ZNadDatLo0+tFI0tI+WUthv/wAmsdE8kSkxg7vYDvWRdLa7LNNHa3lzIY5AVKP27cZ/ vWtDGrycGAyAYBPBoEN27doweKe6lo11YRTW0gzGjEqT8GoMXUlsVXHfipf6Ep+VllVneNfT/wCo 4NCgjiklVPSZOcfrJFM3nu7ves/EKc7j71IaUt5f2Estnps12sILP6Y5A+ak1Ft2NeWf5eJWVF+2 00zk2XAVJI+V7MpxTCDXWvXkIXYinAGMYp2kxkHtQ3/YzRoFRlG8p23GgrcW0koWeJHJ+nahxj96 EJzskdRuAPasu6o1Do696GspNIATqUELcRAdx7k/NNL0x2WKOBh6W1Ae2Oas90I0/mQLKSDg7sYp gNyBW2Et3Aq90zmP07iFkJHcjFVNpP8ANXmhSW8s9qyJOuI2x9LfbNSfT3Sl11e+oXAdI47dS5Rn xn9vmqn61udYsbGy1SGIafYRhYVQfUSP6j96iRqUkFlcPZSSRckgA8gVDZdxG52oETYOCuADV8kq d1uruRjJ9qhrKWW7iaRnLPnJJp7bs05aYu8bxD9Gf1U1F2eqEt7aREjCyvzv77T80Jb8QKB/7mOX C96b/nd6ZOQ3x80BdR9fd9JUjgZFY1E3TmTUQ0TPuMp7FSlOLS6aG0L4Cq/AiI7UKLSNUu7P85aW ks1vHy7r2FMhcbzkg8nt8VZIbPpjPNtO1ZIgciPHI/vTu4lS5jG61S3lC4yvuPimFpdhuCSpFXvb vADj6iDitSSJs5S9/LW7W7oJYX7p2xQkM/1RPeqtoO0RjB/3pp+aJQMy4GffvS7q4S2VWZPUVxwR Wq3jdLOLP12kjXfJjBBXjFVCyK5KL3HP2oYkWduxQHsDRIU9Fn3DdmotylHL/SuO/tWT9NydLRaZ qi67A7aoU/8ARupICnHvWIByHRR9YJ7/ABSNQQswdXJdjjbmoydw3DWAWZW9Qjg5OBn9qnNHtdZ1 oIbTRXug2Ssxj4FV4d+H03Xs0s7y+loth/MuZ89z/pFZV1d42XVtpK6B0zCun2NudhvUA3ED4pcY vn4sN1TpzVNHWaa+0eSBM5JC7gf7VGWuq2otwZrWNT8hsZFZB0t4s6lYap+X1C4bV7Wc7SJxnFZz dy+F9/BOl/bS6RfGNnVH4DNj2pMYed/pqj8wLrZ6UQgQH6TnOTSbi1iRleaEOxPueDTOGVLXMcQ3 RbzsJ7/vUlJdwgYucIFHGfemtJvvYaRqXYxKUOOAG4FObe/udpjjf0pDwdpxmo97p9xWNcL80GQk fWuQ3yKlkq+SQ1OweZ1W7ffKBnLPuosEw9D0UtwuBgOT2PzUV+YeeYSSJlh8UaOdtxXacd6uvoxy 12mF1S+tf03EkXbLRyEZpvdG5vZYmuZHuEdgFaWQtz/eoqVjvI3Haf6SakGv4f8Ahwx4P5lZsoPc D5rn46XzmVd8/hsQC18YQksiI6WzYBON2V7Cl/jBdVT6N4geH8VlemCVtPmVxDJtYZkOM47VwT0r 4ndTdHXgvNJ1K6sb9DhJ4nwwoHVnWWueIGsjU+stSu9ZumT045J33FB9qmM1U5Lu7WvZH1Ietdzy XM6n6WmkLkffmixiRkE6YWRTnbnFRklzGgRAhUIMAnuf3oy6hkgbMg+9dbWMekhc9W6ppjpNb3T2 j9w0DbST/anWq9eazrdiLW46p1O5LgZja6faKx28lSZH+gAGmiQQxcqv1fINc8Z43bWWXkd6dZ3O nJJPMQXL/Tu5J++aFchhKX3fqOTj5qnu3farMWApq91vGMFcdqt3WT+3uiH2MoJHdT71mA6D1d+j H6nWJY9LgfmQtgj+1a+hlYOzn9XfNTcniZrUnR83TRK/wqVtzZ/VmsXCVZnZemS9PeMPWljLFbdN 6pqc6BM/lop3GPvgVj3V3WfUPXWoPFr2sX88qf8AMs7qRio/zR/DHrn/AIE1t9XhhWW5SIxqrj6T WP6/1DedTa9e6tfRRx3E5JAiGFArtjj44s53z7SFtrVx0zNaNpsrxzxuJIpY+WRx2x/epnxD8X+t fEhoYupepdUvtqhBb3KtGhHxjsR96w/Q9fj0XWrW6ki/Mek4kKHsce1TniR4qy+JfUMF01jFYW8E fpqIlwxx8/as61dr5daN7WT0wCzZdQDx9qm7DqvUdBurPWtMujaXEDh0lU8q498ViKXbbhhTgjvR 5b547P0khVlPOW5NMsfJvDkuM1GfeJHjj1/4yG00/XeoZ9Vtol+mORzHGMfI7GsZ0C2sprxF1G7M cCLhygzj7fesbheW4Yo6kA+w4yKkGkSFSEUoByauM0SppNbuOnNTE+lM/wBMhNvNG5VlweD9q3T0 P50vFSyjl0hesrm0idf1OnqHOMAZNc7RyeqplBII7UN5GjkYpIyZ7hfes6iZ3y9sk686v6i626hu LvX9buNWuRIWElw5YL91B7VIdC+Jmu+GGqw6h0xfm1vwd6XOMkEHtWDvM0hy+5yOPqosM5QY2jPt mulnWmMfg2b4u+YLxJ8wSQQdWdRy3xt+Vg2bItv/AGNRq9KaRZeHH5+PWQ2rBsG2xyw/asIbUpiC gJA+B2qnmlhiWdIt6HjOe1Yv9E97bL8EdW0mx8Q9Al6gxDpkVyvrux7Jkf8A0V6dearz29D9G+AN 9Z9EdRLcdS3dottYrCm7aMANk+3AxXj01008sLsVVVH1A+4o3UGvR65HBbQQw26wdnXPNc8J416M 8pnJs0sr2G7u5ZJYy88+6eWQn9L5zj/NT3R2vW/TPV9lql3ALqOM7niYZGKx31eIwipEq9yP6v3p 3NbX0pa7WxmkgRcNKg+lR816blt5pqMo626rs+sOrbrVLa1W3spP0IFwM/OKiZtSktJreSHJCMCq juWFQH5x5pAm7cO/FT3TGppY6xb309uLuCH9UZHvXPPHyjrx5+N26ksvxJfFfROhk6btXtRttjaI 0kCl9hGPjjiuaotbnf8AN3d2fUvbiQyTFuMkmorXdeXWtTnukt1t2kbgLxigrI+wb/5oxyT71nHH U01M9ZeUdT9CfiD+KnhN4f2vTWmm2nsIkZbeeSNZHQH2JI5rV3RXmF8TOmuurzr7R9WKalcTetdb eInP3j7VqSS6uAwRcCP/AE+1LjnuIFPpSsgPdR2rP6+9rjya27j0n8WPxFjhC3ljaSyjG59iqD98 VpfzKeazrXzBpby6v6VnpiEYtbdwQ7f6iK0C5aWUFo1ywxk1dQYDtKAAcZrbjdW7Zx4a+LnU3hR1 Da630tqc9hdQkE7WIVvsw9x9jXaXTn4uvVumaU0Wq9J22r3SgD10lEZ/wK4At7hWbDLlfg+9Xjjd Ztq23pI/9Z7ms6+28r+xv3x+8w/VPmes5Nf1aQW1nZykxaanaMfY+5oXl183fWfl0vEOmXLXumS8 y6ZO38sj/pB4B/atGDULnS1ltI5N0TjJQVHy3H5mMRSq3fgnutas2zOpp6TXn4w99NppS18P40vC uBLJc/SrfOK5A8cPNJ1x4/dZWOo9TXaLaadMs9pp0ZAjUg5wccGtZroKSWSvBciaMDJRjyKi24cq Ik2L2xWvrTOno10T+K5a6H09ptlqPh9A91bRrEskEoUZAxnt3/astt/xZrHVJfy48Pmff3DXQIP9 sV5gJM5XBhxtORjtUjY9TnSp1nWIq68DPsaki5V2P5ovOnbeYzoaPp+x6PtdIsrS7juLq4kdfV+j +lfgGsf8rHmQ6b8HvE5NRs7iWSwuY/TltW+hQx9s1yTc6tJqN9KZG9GQnLIoKjNZ3pnWmhaZ0Jd6 Nd6HFPfy/VHeoMPGf3q5drjyeM1Xf3nY84/UsfhDPpmmaANPtNaAU6vb3fqbEI/TgD3FeZ9hcuuQ 2E/9wNnknOc/5qWsPEfVJunptD1K9k1DT8/y4pmzs+MVjrybZBI6D7D7VmzeOqxM5hlt235a/wAT LXvC3p2PpvqvTf8AiOwhHp20qna8SD2JxyP3rb2ofit9FadGZ7LoSF70cqAFU7v3A4rzFj1B4El9 OJQW7Y9qYRM7XPr7WaQf0t+k1nHDU0zlnu7bg8ynmY6p8y3WcOoa1/6XS7Ry9nZL9Xo5+9a1JEEk WMlAOTQWcyO8qr6cjgBge3FImuW2BW/wK7y9acr2zrQtAutYtEvINwsg213A4OPYmndl1RfeH3W9 lqXT90Le7051lglRuxBzz/8ARWFad1Hqen2L2cd5PDZSnmJT9JNOFFuybmBkY88+9c88dtYZeD03 6C/FG6c1zp+2turOnDNqEEYW4lVRIkjY5fbjjPxUpZ/ip9DW+rCwbp2S00hOBcRsFx+yAV5g6bqc umXIlhQKD+pF9/tStW1CHWLhXW0/LkfHGa5SWV6PLG47dA+cXzO6b5iPFTTda0WymttO021/LQO3 6mO7cH7cVvby2fiVP0hp9p074mQvd6fBH6cerxDLKoGFUj34ri3SU03pnonUZbzNxq13lLZT/wC2 PmsJQTShYWclMZOPn3qXLtz/AGTxer3VPn38vEmk315Y2H5zVmRmiCacEZn9vq9q84+vfE7VvFjx cuerLdE0+6yPQjBxsVTlcmsEIEZXDyRYGPoxgj4oskJDCWKUIxGGPYn7VqTftcebXp6L+XP8SnS1 0mTp/wAWdzLCpiGoxwh1IAwEZcc8e9ZT1N5n/LT0VaX3VXT2ii/18qz2wfTyqPIfueK8vTcSXEf5 UoqKT+peM0m5vdSERtH1OeW1XtbuRsX9qmUssiXOVs608xfUGm+Nf/1kqotpp7kSta2Q9NdgOdmB 7H3r0K0vzteB3j90XBaeI9qmnXwfcbGVC4H/AFBx/wBq8obRWg2oG3L7GnLenIf52OPuc118Nekx y/t6n2Xjp5c/DLSNUfw9tLWTXJUyivamRSR92JxWKeSvxBuvFXzOa1rbWUOnldOb1I4AEVhnGcCv OO3ulsJnltp5Ity8gHiuwPwx+u9L0Lxd1mfXNSg09X08pG1w+0HmtzrDTU9u+/H7xV8MNNW56N8S gjaddxo4R03B84/xWqPFHzt+Gngt4Rrpvh5NHdajDD+X06zjjwkPBAck8HHx71zh+J/1RpOs+JOh DS9Tgv2NuplW0fLKMcEkVxaUtriKAiWYkKW2Stnaa1MNzbFuukxqnW2qdS6vrOr3t2X1DUZHnuJM fqdu/HtXoL5FfOd03pXh7D0T1zfmxmtJPQspJIsxtGckhm7e9ebZmxnKhBnnH9X70hbi59B4VuCI GOWBP/auOUv0648m5qvWLxW8IfKlrljq+t6rFpX566Dubi2uz6nqYzkKGx/tXknNBp8fUer2unzy Pp0Vy6228Y+jP01ZbuO1cMDNcexWRyR/3oE8kcYd0OZZDkfavTjdR5OWbvR5BFElwZGk2Swngexq 6mV/VmRSI1zkr/2qKnt30/057gsVc5B74rLuientV65nfTtFMKnbuZ5qxe2MbZdxvjyS+bqby8dU S2Wq273PTuogb4Ffb6TZH8yvRnV+mfL95nbOLqfVho+oTyxhDLcXKwSr9iCRXi82h3UWsXNpfILW Wzb0ZfYsfkUiO4eFnSOeYxoSBtkIOP8ANcPHt6P2bm/t6jeKmseXvyx9A6xYaHZ6Zq+sahC8cMKb J8E9vq5xXBngV1DZaZ4zdNalqDpZWcuol3B7RqW4/tWrJSbhYXjYM6n6vVJNDlMgfdFJmQnnceBj 4rpcGuHmuN7euH4j/XOhy+WC702DVLS4vb2e3MMEMyuxUA84FeUtlO6xrbM29x7n2+1Rmo6te6nL Et1fXFwEHeSQsB9uTS1vP5qNHzJ2GPmuuGXjNM3PV6bz8nmpQt5h+nI9Rlt4YfVyDcSBUUg/Jrub 8UTqbS7vwFsbK21G0nu5dTjKwxTKzYwecA9q8nA7i6DLugO7cZgSGUg9xUjfdRXurTBLy+ur5Au0 NO5bH7ZrlJ45NcnNeT2cKI4oEtXOEYfqQ57969Cfw6vNPoei6Y3hz1Dfi1cS50+7nIVMf6Oe3vzm vOqwmEabVQ4BOCfvSi+1PU9RknU8GMkNinJPK+TOPJ/wew3Vnk08NOsPF2DrptXt4LTeJ7nS4ZlM U8oOd5bd881Bed/zV9PdBdAah0boGoQ3nUmoxflzFbkOsUBGGywzzivMXSOvurRpYtodc1COzUf8 kSn/AOmscutakvkkmm9X1Tw0s7EyH/esYYbu2s89Tp03+HxDFN5jNH3SpG0G4je2N/HYfNb4/Fpu oG0boyITxiUSSZj3ZbHHOK88tH1q76buINT0jU5rDULf6o54mxIh+QaT1V1zrXiFP+Z6g1q81aaL /lyXzlmHzivLx45Y52aaucynaJupeGj2NhH7txn70CRPXQbhxS7iZrlI3JYqo2rn4q4GIgMcV9Cd R4r/AGqSMKiLs2gDv80CW1MDspOcjORRnlDrh+B7UCZyXwc54qIoRjAA7A1Ytnn2qxO8kBWUj5pY UEd8VRcntn6s0u0FntlkluTHcxjMUKrkOacaLol/1BqLWWnwma4Klgo+BTCKyn0zVLi3uoDFKnDI 3z81Ba1lbVr1FbHqSsEB+DV+otFuOnte0/SrtUSa5kVN6sCFBI5z/egwMtlcMy4yGyMe1I1W9Ota pHdXDndEAE/f5o02T42eE2keH03TtvY6ot1NeQCW5UHlSRWsVYiXOSccUbXH1HVr+Oe9uJJZAoVW Y5wo7AUp0HtjJH+arOK0kiJIpZ/qHYfNJsY5dQuT6KlXHBIq/pqwDSpkjtSbe7ns5BsyAO4HvUaT /hz4Za74q6lq9vplzHDLpyF5I3YAsoGaxPV4v4PcTW8j5mjcxsB8in2i3t3a6zPewanc6T6i7ZGt W2tKPg1kOn9P9OO811eTXUzNE5VnPG/2NRnbFun7G46i1WKwhb07ibCRHHY1lvid4G9Q+C+p6VFr k4uv4nEZo37FRjNYGwutNvVnsbl4LiNsxyA8qfmp3XOrOourrm2uuoNXudYnt19OFpWyEXHYVWjz ojqmztdL1bRJLcSC/BUXDf8Atk/AqJm0mTSWkjlumZFGFGeG/ehW5SOVljTYxPGPmqvGmcAXJwB+ l/mgd9J2UP8AE7iGdma3eAsvH9ftUr0t1bqXR/8AGkghjimvoxCJXUN6YHwD81D6RdTm4iit1L3L fQij+o0PUGmE0yTjbMjbXz7H3oqR1W7s5bSzW2TFwAfzB9mY+9R++OExoSWkkYKo+TTD83CojhEo aVuePY09hEPou0u4XCcx/Y/aiemR6l0W/S+j3U/UE35HUG2NaRAbhIpGc5q3WHh5ddF9H6H1RJqs OoJqMoVbeMjMWfnFYzqusXuuxwx6pdz34iGE9U52D4qU6a1zT9Hmi/iscuq6UhytoTna3tQMdRnS 6l9RDwyjn70JFJQdyc96VeGIySegvpwvIzov+lSeBRSzW6qSM55GKSgRTIIxgnvmrpbKScZGe5pb Bn7n9XxVI5icKTweMmgr8oRggkD3+KHg+qQB9A706kuTyg/5Y96uJQ0IUJ9R+KALQmQBmGE9mps4 G4jaSPvUxeMpgiVQqsF5FR7t6TK7ng9gBQ0f2Z6iTSmtLDSZbnTZz/MYJnmhab0V1J1DcS2Gn6WY fTGZZbz+Wij7E1K6R15rWl2kkNhcyRxA5VSPpppq3WHVOs2rQ6lqYEL8FLfgMvwavSRPN4TS9P8A TFxfX87XEwbapiG6L+zCsFkjKy7QMipVuq9Wi0UaNFqNwdKRt4t2OVBqH3sGD8kn2qEObe2afI9h 3anLR+iu39Q+KLZSC0tXLR+qZPb4qmlEWx12uqjB/eim4t2ChsbQe+aT+T3SABsE+9Suj2EnUcks UX0vGpkyftTC5tws8UaOfWc4FE6JGiXMqbom9U9yAaFHZSzyCO3ieVhw6oucfvUjKl9o87xq4MnB JXtVWOq3OkXpuLVjE7/rA7N+9Epnb2cjXUlsiM0w/TGq/Ux/anNxatbLtlQwyjujcEH4IrKk8QLy 1niubPSLCO8jHFwyfUP2qI1HWpdauZ7m8ijNzLy7Ee9GNolkzGGH68cii2zfQpzyO4p1b2TSIAuC W7ferTRPpko9RAXPsRwaNbWilLTZIAB96RPHHHds0TFkA4zTl7phIitAsY7jFBmB/MIFUEk96KRk g5A+o8nFFgha5bYP11kJ0cavd21poUDzXDxgyiQ5+v7faoOeGbT7kq4KTxMQw+CKIQ1rJC20ggDu DVJO6qVCggnkmnL3Ul2zyykbiMYFM52aOLco9+1Gyj9Z2qwz9qAj7ZHV+T2zWYWHQmlaroD6hYXc 51tWH/pyw2n9hUbfdFdQx2T3zadst48CSYjhTU2nSDkIY/TyferRqNxyfuKI+IJGWP2AyasVJbPY 4qoMFEi96SYhH9WSwHcYq9l/6ixkdB/MDdjSFu8kqy4f/SaybKEYUbhyT7fFLjT3UAk0qL6z2x81 RAiZiD9P2o1smS0IJcHvSPTDNuOdwoiFpGCjJU0pwYnKP9MnxTQFIm2Mt7UtlUgE8YFXkRp02AEh qSUlVvrUgD5rRskggZJwKuD9PB5oka+owyRntg1aWHYSRyTRnaysw4xSC3PNKTlv296WiDlif7Gh sky5BUgj4JGM03m7rGMeo3anlzidIkchYwRnHfFSfW+l6JpiWcnT93JeO8StKGOSje4rLW0FDC4Z g2VYfNOGT6Sc5o8rGaGFpP14+r2NBLAEgLtxQ2b/AKGH+9KAAPakhlLHOfvRdqqoxklvn2qaAwO3 sD81aT6WwOT8ClGGWPgjeO+fYUSK8bTkNwIVkX9JLDtVIHbXt1YvmKaS2Rv17WK7h8HHepC4ENzb J6QzIe7Ae9Wha21iAnlZB9Rzx/ihpBIIyudqewFX6NgLAUYDYA3+oUMwuzFVyxzjGKM7MgIClse9 PbUPBP8AQQwkXOD7VNBhNpt3ZbXljCBj9IHOalrjR9d6f0wz3dqbazlwUZxyaY6neTvbSPM5JjwV Kdwakdf8StX6r0G20zUtjQRKAjAfVgVplBOGusF2PHII96TcW/qhdxwic7R70WE/kokUruyMU70b p7VNfvns9PtnvJ3GcxjOwVNtGFyVYK6phTxtHehOmCAVbd7AjtR5dKutNuyk8m14WwyP7GnTXYlX c5Bp2bRITJ5JGO1EUjsOf3p/JJAynCDcKZMf1MBiq1FpWMKj6MlvampBUEgkHvUhBIRFgKrg/PtQ HABIxxmqmzUZZlB/zV4swBvTOSfY0d0VVPFWEILq36R96sWGotDcDYQQ3cmnvSPS1t1H1dbaVqWp DTNKcfXdsM7T8VadwZM9mHbFMrqze7UJ6hQN7ZxVNMp8RejdL6U1Q22hawNVtkH/AN81jBjxEFZw 2B8VUGlTmL01kJC+2e9Lj0W6eIziNzCp2u47A1NmwVOzIX6QR3+Klo9KvJIBJJMFCj37kVDKFV5V dsKpxTiWa4mYNNIRgAKPYCsp0TPCFfAGGB70qSweOD1RGxU+5HeqDrgPIeB7j3pIXUHtzO0knoOc J/pxTShJ/MIB4x3ApNkA17IhJDL9QGO9VHGo3hWYsy4Ofb71bpif8vrjRygzMVwCRnimge5f8zIT t2MO/tmkiVvT/VzStS1IT38myMAchdo7im8EbPxz3qQGdoX52Fj2BoEtqxZcIScZAA704lPoIWbv jgVlZ0rRNP0Ky1Ky1F7vVJhie3Y/TH/aqm2GpazuMsmw/cU4jBiULxvzkGiz3UjXW2Q742OWK9xV pSoDGMZQN9OaLAtzOfq7j3pStujbGKQblYzyAM8UUQhBuJyH9x7UZDtuVIXsKcR2d3euwtraS72/ qEa5xV4Y0jhcgfVjipPoHr266D1SQyQ+rBcH+apGT/atQRj2NxDMkMls1uzf0kVcW5LEE8itgda9 c6X1pcW72Nn+VliXksACawSUskjn3BrVZ2QluVYc5HvSk/lyP9Jx75pSyMNuOCe7UV5I/wAyWZ9q kYOai0EjfJu/T7Ype0cUkvgkMQQf0GlqznAbGaLspCFOSOaKCGRsDLCkjaQuKWD9J2ggH3omwUzg M3B+1HadJQAO9CaLI+k7m+KSyrCQ7grRBlT6cnk5pTAEMO1WjkDqu1s5q06GPkk/VQO47OCWEu0v 81eyihyIUHOAT2pdksK2zS7i0hOKJbR+rPKj4QIu7ce2aBuymI7Tglucj2okZJG34q6BZAeNpFWG ANwIxQLGEOSMj4qjP6TM4GQTjAqzyFoj8D3FAt7hLi6SCJgze/vWasPLiAL6RPJJ+pT2q5jK8gfT 8Uq4hlhlVWBGBkkjvQvWYghRke9RS0Zc57D4q3q7iBtx8ZpDKXOQOaX6j8AgMR70BGZdoJ/xQplV lCEcVfliQR2+KoYVtuc/vQCH8sY7CrhvpJxwP96Wy5IAG4n2prfTTWsXohCu88kj2oD43qMe3zRF UY+ocmm8joVXbntVllzIAPqAHNTTUp2jhF+ocDtQJcLjAopcsg+kH4ptLK6gAKCKjS++TOSMjtkU J3ZXJHBq8lw0KEle/tTe4n3AblwffFHSEPOQ455NN5JVuVdcAMP66VOocbge4oI+gAYyT3zR6fpW 8b49hyB+omna6i1jABDgEHKkjOKZM8YPBIOO3saC8rMhbsOOKIJeXrXdyZZW3yHlmoBnVSQwJA+B mgoxMhAGWFFjZ0XhcGp2KP1rwvPfjvVQuohaGWLEjn6XYdqSrs4JRvrFXM0hT05BuPcE96oIsQV9 mQWHvVJcej6gAJIGQMVaPa2VOFx2b3oQYqzHlse9A9UvcgbYtue+aG8JhkyV+nGMUeG/KKMgdvei pcpKGG0ZPufapRHpPHb7ySEA5INGW4jcZjKsG96yLo7TNG1CS4l1VXf0/wDlxDs5+9NNWtrWK7b8 pbpFE3ZB/TTXTPl2ituCNv1A+9LCrswf3q8tuYiVX/AoPestDx4Y88fvQZoy+Rux+1XUZAOcfalO P6QM/cVdgaRhCDwT8mlq5YnPak7B8VTYBGK0zRSoZNuMrnNVBctblkWTYre2Mikh+AO1CmYryF3U BT+tznO40DaykkE5PFLRgQARz70TcD70AkTJ44I96KuG7HPFXjChn+k8rxQbckKxJyRQHB9LO3O4 falmQEElRz34ps92A4Cktu7ke1WNyRESTle1ARblY43jCg7uzfFDiQ7Dt9vmnK2oaJGXv3waTLGI kkfBDY4UUAiARtBHP+aEykOG/qHb5qTt9MjkgR9wEp5Iqrm3WIEYDH/egjFklDhldgQcjFZAOtNQ 1NRFevv9MAKWXnH3qIuLSa3ZAoIVhnOO1DEYU7oSzP8A1BqgcXcoeTf3P+1NY5AzyjYGdhhftRFX 1+QcAVK9MaVHqOqzQeoioELbz2B9h+9URLsyxLGnLAYZqbqVjJVlO89mJqWvdPawlIZSpfnmo2YJ 3ft7famw4hDCP6ucVaePC7sYB7gUJJpYwDnKHtmiCYP9LHGKCyW2UyWKjPFNLm8ghlMZOT7nFTum XlnZu5uxJLC45WPvVQRaYt4JkgEkBPCS8/5oIS2uJbJ47m3/AOYP0t8U/vupb24jJupBOCMEKu3F PdSNu8jbIVhQ9kXsKhLmX0WLhdyj2PvV2Kla3Kvc2hLhQNyEYxSBcQ6tcWlp6ggWU7WlPAX75oMc hCOpO0P3Wg3mntfWywwpkDsB8VE02PqXhJpOi6SNQXqWLUtqg+jEwyCfsKwnUILYZSMsSPtTGw0y 60X02WFiH74Pan0iyMCfY+1U0ZRwHcQVwO9LaJ4iCI87qKZD+lwRiiA8F2O5e1QNgWXOaNGv0guO 1XYArnbx81Z2y23nt7UVLWOtCyj5j3A+wFLl12O/UrHiM55JHIqBMjxYALEY96QspYgkANnmppdp iR7dyVBy3c4Peo5bllv2iiGYSMliaS0UqyqjRsmRlXHuKOOn5b36beQiZeTn71Q49XByjZX/AGpY XLZ3bTjt7UI6dLYxRW78DcC0lXkb6iF5UHANGhPzGBgqNh9/erD6jkjaB2FBjbbJ+nLCi+rldzDk H2p6CiOxwOO5FUGJDbm49s0lH/Vnt7UgtkKp+fatGxxKWGdoNIjZywYZVgf81YHnav8AvRU55dwv xQSehS2NvqENxqMP5kBtxT/xWZ9U9TaT1HAiWunx2JQfqStc+pntx96SElDZDED4oxpKzMELKDla ayKpGCM/NIRjgDNLYZ+1ZCdwkQx7f70j0giqANn3FE9sjj9qphjHORQDdSxwf80IoGUqSePejs+F ++KRjam/57iiEafvmv7aH2LhQftkV6weAWlpYdE6QCODboMf2ryq6bj/ADOt2yD/APDrj/Ir118G 7aOPpLRyx4Fuv/avjfl3eU0+hw9StqWFtENpc7R7ZrIYraGEDM4OfitXdSdXSW+2C3AXHBNYk3W1 9ZXBZp35PZjxX0OHH49vPyZdt/yemoIDB8+/tUHKEXUwBzgViXS3XS6nbusm71l988VKabdtPfSu xzxxXol7ee+kD15Jvu5UA4HIrnbxHdmguMtyBxW++sbrddTn4Fc+eJMuYZsfBr63DOnxfyL25h64 nV4XGedxzWltXYS3DA/oz3rbXXD5kmccYJ4rTl+5WaRSCdx4xXHkva8PYQxyB/tS1BCZoEJYDbjb TreMAY/evHX1YAG2jJGcfFKLCQbcdveqWQpLvwDj2qt+8l9m37VF0G3A5FWF9DDlZIizN+k5ohR5 c4GP2pxLpaNCGDLv91PvRS9Jk3a5b/EpGfsfmt/y6dHp+mQMl4ZsoCVI4rQfTumt/HrdPU3Bl4Hx zW/bmxKdOrCWzKqghq9XD7eTldbhAG78fFW2Kg+rkGkRSFlBxyaVtbHJzXpcisemT8UTcrAcZH2o ZYEYXknvmlx4QAEfvQJMQB3f0mllFCZB+r5qi65b4+KTu38DtRrahkN7E/NJztJ5yT7VcoV/eqBG BkbjnkihtYbRg4wTRMHJxwMdqGSrdxilIcd6Mr4O4D2pfG057H4oSsfqx2NFP6CcUXoh2A+mM5Uf PvVbgeQMGrDAADfr9qtKdibj9I+TQ6KBcn2pJIOc8VZo3IUg44zzSZWDgEDIU0Oi0YRKN3HxTeWV kfkbvg1cyFxhgCP96DJksSACB2qxC2kkI+1M5Mbv9NG3P6e33zSTIgAVlzjsaQAEW8H5oUqYPPGK dPkRDHG49xS7vTEhgDLcCRsZOaojA3dcVTJxyeaSQAc5J/ar/wDLGWO79qabUVzgDORSmwVwf1H4 pKgAcVTOF7fq+aaFgdo/aku7iTCr9J71fORVoydmMiqhRXdjAxVcnJKggUh51IKx8n3NV6pAA9qk Cg3AA4FKzlSCcj2pAP8A3qm+rvx+1VOlLtQ45x7VRbaapj9OKSq+ocEGhCgTjj/erOGJBA5PBqiB 6mO371RynIOQaLpYKFiKiTk/amaiTeWb/lKcZpwvPLYOPikzspQ54zTZoyuE3oxRuO/NY/KRKSy9 s+9TWo7ngwp2ge4qAu5dvCYA96xk1DQqqziTdk55HxWxensG2XaeAvxWt5FKgN3LHmti9Hsn5dUk IBI9683LOm8fbZHh67C8GDxlR/uK2h537M6h5ZdbUcbVic1p/o93jvU9MkKZdp/bIrdfmrs5dZ8s muojBG/LqxLHuAK+Vca9/J1hHjrokxitDcZAYf0n4zWWaD4lato0huNPESvt27XQcisB0t3SMlz9 JUgD55NSLQkhdrEDHb4r1Y+nDe4zC267uIL830m31HbdJGBgf2+KFbXvhvJLJPf2NxDeSuX+mQkE n7Vhci/VgsTS3eCNQwjDH3OK2z4yJTqeTSriZW0a3e2iUclnzurHpIw57ELjsKMzux2k4z2HwKJH GFCnG4j2qw0vFZQ3MLSiXaygjDtjBoEEsFwggVszJ+rBzmsn6bsdFu9Yhn1Zh+VTBkgJxuxTPxDb pu+6vin6Zjaxs/SCGFuBv/1VnvYiZXTiEHmlwWzLMF25HfdmmWoX8FkUeZl3A8H5p5ba3GJRI8Y9 Nh9Lr71obH6GzHqdkg/5kisig/JrLuhdO6g0vqm80fXLXGluC2JV3xsP37CtM3PXX5F7RtPI/MRs GDfGKkeofGzqjqNWto7v8ojLtf0vcV025WUnWuipIde1U2csUVqszlTkDaPYCo3QeuNU6evhBHIY yje5yB96hlguJYmea8kZhztzwf3pZAlYfTkgd/esy6WRXUFzqXU3U8mp31wbyUDgucjFWEc5ky6b WPb9qLDE6khVyayGe21Cx0iG8uLKH8m4ISVv1N+1W9lumMGBs8nsaKrFAfdvvVM7MR2GTxilgZGG P1fIomzq0fPYZ/enpOXUqNvyKaQKqFWJ2msj6fWKBmnaNZh/oat4xxyqKS1DtwhyeQPmpWC1IQZG dvsKNcCW+vWljgjgQnhE9qfW1vtfBbk967SPPlkt+VMaR57mnEcLO6gcDPtSr1dt1hcmPH0k06th 6aqzYC5ro5eyjaEA7RyR3qPuTsbaRgCpF58Bh2x2xUVd/wAyTPb7UT7N5ZBt3f1U33hn4Peiy8bz j9hTVAUYfvWkOslXwfiqJAPz80KSYL9Z4NUG9RGcjA+BWWtaH3Z+KqR9kWFXnGTzTVn2EEcGjQz7 sllDY7VuM6Tdn0rd6hpMl+38mCJd7H7VA4b9WRszwazReuUj6WvNHggTbdQ+m7t3U/IrC7aLEaoT kKMYPvWtmyl5djn6SKTIhEWOwNEdQozjt7UKVskA9qybDSNUXgfekvtxk96WYyDnuD8VTxD091DZ sWwOMftSUTKk96LNBsXcFJpFvKqkgjvWY0RFKYkb3J+ae6PrEmkX8F3EiyNC+4ow4b7U0ljAXihx qc7OxPOaTUE31p1bF1dqJvRZm1kYANGD8VB28DXhSGIY3nbzRXhKA8g4q8c7W7bkGMc7h7H5q3uB rqFg+lTtbyK29QCGp3pPSl9q0pktMMY/1Ixxn70ONr69uzcXMjTn2Zh2FZf0VZ3Rury7CFra2T1Z M8Bse1JJTuMn8N+jrfVLK4v9XU2dhbHHqSfTvYewqO661HTvEC/uNJuNRaysLfBt5I2yFI+fmsU6 x8TeoPECGLTo4rax0+NtqwxHG4fJrF9Z0Sbp6xBacSPJwyqealSW/YNoHkmuoJ29dYHKRyjtIB/V TeWMJ+hc/wDSDQ9PluUTY8Aji/1j3pFvqWmXcrxRXJF0ucDnFc8o7S6CkfdwRhs9ieaduBAsYTDu eSo+KFpdit9qSCb9TnHFbH6b8KTeXrXtxdQwWSjCBm+o/NSY1Nmnijftc9E9O24iCKY/UT2x9q1V A7TBpR9MuSG298fvW0vHRLbT7jRbK3ufWgFthcHgN8VrrRNJNkJDcMFWTOMe9ZyjWNBDlxjO05+r PtTm+1yXVLO304QxLBE24SKOWP3pksJR5JCd0fwavCFV90aAD3I9q4OsCNkLN2aF8l/1UGdywJY4 /aiySn1Dt7Ghyj1I8Y5o6Q2Bxg9hSiBKoye3almFvTQnAHtT2wTS/WjbUZnhtAf5pi74obR6xmEh wAR7c0N5Cx9yufb5qQ1ibTJJmXSmdof6DJ3Io3THSZ1/V7aw/PQ2hmbDPOcf2H3oiILDPqHCFO33 qZ0LrDUdBM72U3oyyoY3UfpYH7fNE6p6KfpTWptPu5op2i5SWA5DD2/vWOyqkbHDFV9qNHsUkUiv h97sxZgRjk0G5kHqqewH9OaGsm07sDdiixOkzcRhmPc0Z0v+YyjIO9WQF+Sc/enIs5VG4REr+1A3 OrY27TntQXa1buFyDSksRI2Mcnuacxwzz/pGF96eQWhj5Y81K1O6Zw2mwgY5+amrSBCn1gM3tTYw Zk4Bp7BCxiBH/wB2sV1kHjtFlYYXb96dDSZpHjSEAljjn2oUIeMg5GB8nilT3TggRzbMNu3D5qba 0HdWM1pK8Mw2SL3FNTsDbW5I7YpV3NNM5Z2aQ/6j70zMxD5Peoq8kXqueavBp8MpX1ZCik+3tVjL hSwHIpjJdOHyRgGpa6YxIX8jacwFlfSMW/rUkFf2qHM0kxJkYls8n5+9OCxkwCe9ImVI8FWz+9Zj ppYsVTGdxPY/FNsNubJyD2pYkDA+9B3MJCMcVU6L9NtvOMg1S2kMv8yX+W4/TTdpSCck1Rf1lHqk +mBxikRaXahbJ2Z7femd1IsJ/tSblXki3El1U8Cml63r+mIxnb3zViUKW+aXKvnYO4pdvqbWyMIg CW7AjigNZYP6+W52/egsGtZGLEBR2Jqsnou57piZAMgdwKNBN6EYJHv3oEbSIE34CsODTn0Y1iRG cMWbAApWfrZ7De+s23G0H3qZs4I2ABbIFQcMHolSBn2xU5YqFUcAccistJ6ytoQocz7D8AVLwyww qHP1oDWMRTNKGUHZjtUpauzWQHeUNkg10x7SJY3kTMcRFeeDmhygA47j3ApQTdB9K/WAOaFKrREI RnPc1VKWL6t2Rt+KYXbIr7OD8ZoskhCkDkjsKipZd8hZgc+32ozQ5TksBjvUfdw7VO4d6kjCZpEi HDSHGavrnTlxoYiE13b3TyjdiBs7f3rF9GKBEYZ2wPpxzzQZoBwG4Ao7ZAbHJ+KEDIwHHA75rLqt Y3MmmXKXcIVnjbIVxkGmms67JrWqm4aNIZ9wJEQ2rwc9qXcFgCM4HzUaYVZSyjn3q7Sp/qvV16iW 3Ni4icACYE98UjqfQLTp3py01OPVoby4uD6aWigbkb71j4hit5Nzox3cDFIit4LSYzPEJJAcqJDm orJuh+hbTq+1vU1LWU0m5Cl4w54akeH/AFWPDrqaZ/8A+IwRkwyop+l1+axu6mW4uN8y5hIwoU8Z ptaqLNnMRI5zmoemW+IOoaX1r1Jc6nY26abbMoKwRrtAPuaxTfhMIQB2zSpXluCpx39qUbOSKPBt 2UE8E1Q2uIpPTb0iQMcj5rLr/qbQNa6d0PSbDSFs9SgXFzeAc/cE+9YuRMh2kYH+9CF01sCqIQD7 gUD24ZYJyoDEK52mr3uoTaoUMxUsnAwKtBaXFtakTukpk+pW+Aaa2qyXF26QIHdRz8UBCUSP6zsz wC3aqsysZZ1lWQdmAPan3T15pv8AxBZxazEJbON91xF8rU74l6N0NpmvWN10rqW+KdSZLQNkA/ei b7YckZ9aVlO1O4Ap16pRMjkmguQ0kmzA2ngUWIlxtbAP2oBXYEsaLGdhBBI+1SnUetWWqXOniGyF rLHGEcDgNj3pj/Ctii4a5ik5wIweRV9QnWRASqsVGMjvRWXQ3WhR9AXkc+uvZ6pu3Jax55+FP2NY Hb7njSU+45Aocmmxq0N0FJkkGSM8CjRRsnIG1TyagISFOVGQe9JcsDgAE5wB7URo1RGJZQB80hoy ViZPrG7Jx8UD+30JU2z38uImGVAP+1M9YaG6ljWJSixjAxSLt5LzCuSEXlV9uKsCsqbVzu96B8sU AsPUZsOvamEmqYVQSp3nGScGitzEYSQB7VkGhwdJHpO9TVPUfWWObZ1/pPtSNMftkaOfEf1IRknN VfRpdTRKZCijgsKNAyQwLtILAcge5oN0Y/T24IlPb7U0XTY+r+IOh9IeHy9KaBI0k9+N16wGGGff NarupCdqqdsYGAuf96S4a5wuB6i9yveiWjWAjZ57qMFeAp+a1tla3ke3kG0AD9qnZLHUOoIFkeJZ zGMDeOSKiCp3ZTGPapPTZLqDObtip42545rGzaNWL8tOiSDaN2Dg5AqV1yxtIYI5orn842B9JGAt N9U05IgoVwxPJwaET69r6HbNa9taJikwkbk4Bqo5g27Lggd6vBELeFx+sAdj3ovTPSWr9ZNcTaPp 806wAmXYvAA71IyQZtn1R4Yn2pSOThyNhx2pphZQPTJ+hij57gj2qSgRiuSA4HeqG0jqTuYZHyKc aettNPsl4TGSfgUKdkbO1cH2oMMUpLELjIwf2oi9xFbtM3puSgbg5obJsYtI5IPYZ7UnYqXLr/Rj t96ZNO885jVc5OMGsKXJMJJOeT7U5so3u5Ni8v249qe9PdH6h1HfrYWkSi5fLFpB9KgCm11pt7pT XLW7FjC2x2jH+a1Z0JfQei7/AKhg1F4p4bc2yliJpAu7/NQMcUc6nYf5iNtYA55pw11bv05fNKS9 zIoCLuP1H3zQdMtxY2okWRS7Abh8VL2hMiGAjPFNwNzZxz8Uu5maaVi3t8VdLecHcsLMvyKulNZ3 9Msozmpex6G1zqO2D6Lp8moLjLhV4H96ip0dfqYbSDyK2V4beYbVvC3Q0sLDS4LuNXL7pB9RzVZ7 atltZdGM0N0siXMbbJIpFwVPxSJhLJhkOVwPoqY6v65ueu+pb7WNQgjha6besMQxt+1QcU6hyMgH vg0TdScj2MDwStZNOoGZNrYxRNYv9L1CaE6VaGzjCD1AxyWb5zTJNVH5aSMxglz+sfFBR+30jb80 D9HKDjBGOaXb6fqGq+ubCIyC3T1ZFHcL80zWQYADZIPNSunavdaX60ltL+WZ02F17t+9FpzZvos/ T8jSu66zkCMdgo96jDM0m5O4+RTTl2YHksckj3NOYGW2gZeCfk96LsuzdRIsBBYyHC/vVtWtn03U ZbWfHqIM/Sc00LSTMEhk2Mexra9j07onUfg/NdteW1rrunSATSzPh5h8D70K1XFKpwCTzxmlyOzD C4BHzUfbJM1w6yMEt87hu4xWcav4bXF30faa7plysyqrG4RT9Qx2oyxa0kBkznHzkUSeSRbj0VfK fHtTGx1KGXEaKSVH1Z7g04mGZllHGBWaHIRdmeC2cYIzQHRVYgIF+3vVRb5J8qcP7H5pJ9S3cmZS M9iw71BaeOH8vh3wxOAnbisll8RtWvtEGkgxQ2QjEThFGWUduagNN02+6nuzDp9kbi4QcA9sfNG1 XSLvpm/OnarAIb30xJiHtg1YsMYEVJ1wcLg/VUxaJqMkEzW9q1xFCu5pEXgCmE1r6UaSyxPCAO8g I3ftWUdBeIFz01a6haxQJcQ3KFWSQcfvVixh1rI9yHnMUohVsNJtJUf3p9HdRqxEb71Pasx6M8Wr Dp7Q9V6c1PRobmyuyTFJt+oMfmsAv0WF5Ht1GA2Qg+Pips2kJnZSGJGP+9OrMrOZNxCgIW5+avFp OoXuircJbgheW+RUV6pUKEkVm7FfeqbOYJ1bIxuYt89qdXIVcbG3imEFu8dt6ryJGpJBEh7/ALUm G4/9PhAQB2J96mk2eIc8Z49jS/4lO42SPuQcKPim9rdLbxP6y4LdvtQzIJGGxgVPuKujZ1BctBdR zIR6qHILDIP2NEvLt72Qyy7RIx52DApmxweMbiP7Vb1CyY43D3qbNn2nWdtPIfVaRVXtsfFJndY5 5UVgFXkEmo6DUAhZiw74x96HdyfmjDCgBkuJVjJHwTWhKpdN6Jbd9P70ux1Fre+hm9D8zsYERns1 ZF4t9HQeGMGk2du8kz3cSszv2yRmsVs2FsgDtiXFGdtn/wDFuj9b6pBb6lo0el3TII45IRwx9his O670uy6c6gayt45YgsQZy5OGPvioe71Z7W7sZ4QpljcSbsfHtUr1v1xJ13q9pLdWqQPBGATGOX/e jJ90J0lYdQxarLfXgsZIojJbhuzkVjy3n5hAsn1yJ9OR70fS9B1LXre6u7d0WyszhwxxuJ7YpvZ2 zL67tti29lPvTTP2v6ZY4zg/vRLZ1RiWBJHzUr0qNEltr1taF564H8n8mO3/AMqh7mSLe/osZI88 Fu5FXQOoadsij2OlT6jqEFlBC1xdTOEjiUZyT8/FNrQmPBH+9SGn63daLq8F1pjFLlBkMOc/akZp OvaZe9KahNpusW4sbsf+2G38fNX0+2e8vbSCJvVa4YIir70717Q9abq2xv8Aq1Jja3Y9Vpl5Ow9g Kyq06h6O6R066utHSe+1KT+XE9xz6X3FKwxHV4W0TVp7Gd9ssJwcHIz+9OJ4ri3Ef5iF4QwypcYy KvovVMOnTahcX+n22rSXK4/nZ4b5phq/UN/rs8X5udpUT6Y1xjYPYD9qmtxNnc1wt0pWVjx25zTZ ZCCfTOCOOaXJaHTIQ85BD8LtPNR8rvKw9ME5rl4ss16d6Ytdd01xc62mn3Rb6IWXO/8AvWManu0+ /Nkx3OrFc/OPeq6c0S8vdSh1a+SWHRbWdRI47uft9qyHxQ1TSOousBqWkKYLVIFjWN+PqHc/3rck hNsdWbAAHDfPxRRJnIIG77nvTCEF2fOdpHHyKnk07TLfoBdRuLpxrrTmOC3jP0svy1dJNNSmKkYw cCloy5yRk/emazKyI+B6hH1Y+acJb3Dp6vot6Xbd7UWWiI2N2EDqeKNPYXekrb3i3bWsJP6YXw+3 4J96axyNDMjHkYOVpwZF2MZEEhI4ye1a03LZ6E1mTUZxBqr3bXIuP5cfqvucAfPxVkl3QoBHhlH1 EnJNNxa3IT1mt2/LpkmT2FSl/wBB6npvR0XV0t5afwyZ9sSRt9YPwauutM5XvZpBLbSaraW92pFq 7fzscHFTHUsGhQXc6aGWfTyB6Yf9Q455qL1norXultGsdc1P8qbW+GYSh+oA/NR8YllZee44PtzW cpYzs3ukjV22nao+9O00G2bp+81QakrtbMFNqVwWzQprJjxtGaaNY+oMM5UZ5Udj+9IzUh01fWkl 1GNUG62PAB5xUt4T9J6x4heIs+ldLXkmmS5Z0mB4IHtt96itftNO0bRIL2xkmlvA+HhxxjtkV0D5 V+kE8POpZetuo9UgsmNsfyNmGwXZx/UKsN6aS8QdH1Lo3rWXTdRvBealKpadwf6vgimCvbEY5Eg/ UAfej+IzQ3nilqmo3N2zXE87Es3b+1Q1zC1tI7eqroTwB3PxTa/Wz+QlN2wAbeaPJppi0e31F3AW eQxrGPb70S+0c6RaWTX7+k+oLmFDQUt7izmFlcowMf1pCfYfNRNgiBR2GP3qa6K07TNQ1t49Vv8A +Hqse6FsZG771EMGViHABPYU3ZPUmO88YwCKNJS5ghf1jG/rRq7Av7d+KZxqoIOMfHNS+na1pVl0 Tq+m7JH1W6lQhsfSAPioiYekVQr2WtJThplQY4/tSlbe/CAr2zTWS1mg3JJ9TYDcfFIiuHUiP9Of eiH7Ty2jZiYq/uM8UtpBIAzjcT7nmmEruTu4OOP3olmd7rGzqoPOTVjZ0pjkilBQKUGQfmmKqAQC o2nufirzXsEPqBZFk+orv9t3xTdrgFV2kMD3qUHncKuxOV9uaHG2/Gfb2pu7Ybd/sKNGQ2zJxz7V m/0hM0qwqd3P2+Kf22mrdWkDQl7nUJicW8SbioH7Uyu7IvM+DuFSHRPUl90R1LFqli6pcKrJh+Rz xUZRxP8AOMc26IocFXGGB+CPalzxQfT6RPHtn3pGt3Mtxqdzd3Uq3d1cyeo8o9zTWMsw9hQPLPqK 50W7aS2ka2m2FPUU4wD96ZSavcPeqZZluWb33ZJ/vTrRLnR4tfsl6gkkTS2kHrel3xU31pYdI2/V pHSMhlsJFyhlOcGmkYuUV5nk2nex5FE1TTZdJijuriMeg4yuGyf8U7m054S0rSxIVP6c8mg3Mgui iSL6qL7Ua2Yx3E00YkeMqH4XnOBTrTVt5Z7pbklVhgMwOf1H4oh1Y2FoyTW6x254VscmjaRp9hrK OzXfoljwZTjj4FFDDwanZNeWwKLAoMiN7ZphtknAnb6P+mst8Gunk6h68fRL9GOnzLIpkHbAHBqK 6x6Xvuk9QNk8MjKzssUkoxuG6htBvtmltyqkLu+rn2qa1DVklgSKOP01SoaWJ7FxDKMSgZIpwkRn wQMCiaMXiFxKMfqJwMCllvybPDBHNPsGZDFGXC/v8Uf1PyzE7C2OxHtWy/L34rdOeG9l1dY6zYtd vrEBS3ldQSrEfftUptqfT7WfX9Vt47eVYi30iQkAKPmso6g6DvNIiSUapDqcKjJKEfSf7U98Luo9 J8M+o3veqen/AOL6JKzMsajJ5z/t2o9/pUviNP1T1f01ZDSOmrQrttCTtXJ5xVNsP0Rbu0uxPaSK LpJA0e7nBp1aSWd91Mln1DP+WS4fdcypz+9R5gFg8MyyMwfkEfNHkMMr+rNCJHx+o96KzTqzQ+gJ L7R4dCu21A3M6QtCFKlMnBbdU3134W2XSGsz6ejtHax2izpcP2Yn4PvWpRp4umWS3lNs4OcrxtP2 qf1DW9Z6ihgg1bWbi9igURor+wFGULc2zWjcfUjHhvmlWsIAw0fG7Oak78QyxRwwjBjXue7Ghtby DRA6PsmJxhu9NLCAbfJHoHOODmqhuPQnt5JYxJHGctF/qHxSVj2CMthiBn+9Dn4LSYyPcD2ppdne v3Vveaul1aWv5G0kUKtvuyVPuf702ZFZsEZoy3ttd2sYMaxyp2f2ptaTo80wYkbVJyaA/oxvFhiQ D/vSIwpKhX3k8Aij6RLbXs4F+XFr3LRfqoevPa216semmQwsuY2k75odKZxFOokUyY74pEF9LaSg hFfJJCuKndbvtNn0izttPjkOoGIfmJXHAP2oHTkulWeoK+s+oy+myqkY98d6COvL25mEkjoibxg7 RgUESRSxKynJAxgHsam1Fol2j/Tcx+0bmmWsfl552mgto7UE4McfagYzW4jSP33e1O/yiKFbPt2p bJDcWGW3eup/l47CiQwzzqBMF+kf00DVHwCM/QPbNSfU/SH8Dl09oblLlrmETEI2QoPsfvUVLCdx KsFA4AolptjIklkECD9TueP/ALlGQ7V7myYiOUwE5DFfj4o9yXlms1toTPcyNtGByxosrRjDoyzI 3KkH9VEtnntZo7yJvSljbKlO6/eiX/R5d9N6pbX6RapF+VlYZVWPcUzmsJ4QfTieRFPMgXIH96e6 xrN51BeC6vbmWaTG0Fv6aTFf31rG9hFck2831GM9iaMmSxO6n2J/vRY4sFskH7UWOF4RtcDdSWAx xw3yaNaXnDCOPaShV1II/fmp/r2XS9RvdOl0eX1lMY/MsRjDVA/q+hzhQP1VeOCIkAyMT32ihou5 T6lY/Uo4H7U3Y7pMtwB2o80gEmxWAYdlNBUF5CHHail2+oahot/BqGnzGKZPcGhyzSXE0krks8jF 2Y+5NLaPjkjk0QKPTAyPvRNEYHdeP3pDlZYCPfNKkfcSAMn7VeIhDtlTHwfmptva9oJoE9WOaSJl /wBLYqbl8TdTvNGOlyMTbA/Uuf1fvUa+Htncja2Mbaj4YBlW2kGkZPL10mYFFCjAzQvpTAcZpAYM OQQP+9E2hgGKkCmw7v8AUrS401I7SzNk68M27O6m2kW8ZWaSUbx7E0hiPy7ouME9zV7ecxQFcd+4 qaXpYzFMoseYyf1Z7UJpQrAHGD7GnNrYXWrXMcFlCbieQ4WJe5o+oaQ+kam9hqEAW7T2PvWkNI23 AgfT8GlFcEF/qPye9FRdjfVHgj2oMvMpOR9hQPdJiin1qzW6O3T1fM+DyV/enPWZ0yXXGTQZGNgu AA/cVEepsXfjIB5A96dyenOuNhj24O7/AFUDcrFET6hbkdwKS6gsCmTH8U7e7WAnG1mYdvimkaXF 87CAoNnJ3HtVQWFVP7/FKkEZRFQYmyc1eNG3bCNzDvikAH1GAxmoptJEZXUKSG+KcDdAPpVd3vgV YEqSyD+5pS84bPJ9qaCZEV/qJLH4puWCqcttOe5p042D4JpCwxT5WX9anIFNA9x05f22nx3VxbSQ JPzErLjIpiqvH9JUkDsKyfVesL/UdMhtr259dIBtjBHIFQEKzajMFtYzJcOcLEO7H7Usn01spiRC o557in2iatZWN9EdR086jbA8wK23+9MN76demK8idWHDRsOQaqFUhuzI25mxhQOwrOmUpr2s2eq6 +ZdO03+HWgXiLPamBn3pvX68dhSJH2Au77t3fHtVkIRQo4X2AqigoYtIQUJGNtOIXYIOwI7UBmH7 VYv7A5P2p2CTFZRhcfcUzeOUJztKnvx/5p2keRuAwe9VtDDnt8U7a2YqPSfEakpjuxqV6a6m1bpD WE1HTn9LKlHHs4NMY7SS5kVFTKk4wKXcwGM+nyu3+k1NIcavfvqF29xKAWfJf7k+9Rv5R3jDKcDP AFHf6QGwT8g0W2vooYZInCZb9J+K0aR/puj5Bxgc5pLgs6H9QJ5ApzJbkqMsDmkRxg8dsUaKQoBl EKj4JprJIcnHPNO7hdgHOR9qrTdPbWNRtrJXW2aeX0xI/wClfuaIj2l77lwKcKBkA5IrJeruhV6J kKT38d7LgHMJyKxmGbehIwCavpQnj3fU3OKIrs6BWACjtSl7EHtQnYb/APV9quzo4ikSRW3v6Z9s Gs36a/hJ6E1azuddWK8eRXhg9PJ4/pz96wORPUH0jL47UjpHQtS6h1C4FnFl7dSxZ/0qB7Gsokkt rL6tyATdzk0w1RY3cMhxgYAFOnkFtP8A+uRdx4b06jpVimuA8RIQdhQBUFQFIyG7U4inNvH6DMfT c8BjwKU8WBt7/BHtRLWziuElhulyCP5Z+9XpegmtIY3dhIHkK4xTjprVX6f1eC8S3jmWLP8ALcZz mhjT0iQKP+aOAT7igxQtLtYKfpYgge9RDzVbqPUpzdWkKx+oxLADGCfam3p7WwBt+9CllW1uG3Sb Y8cxirif1owyqyq3YsMZov2G4WQKDyRSYh6V2BEMH+oj+qlRphCx754pM4ESGQPsx/3ogw+mQsq9 +4NUyFkKR8Hvisv1rw1ven+mbDVppfWe5G+QDlEB7Vh+/azM3BPAq1TmGSzOnpELctdZ+tye4/ag XACECNTsA45olsxj3Fl5fjJq74dueM+1IgSKZIs57e1Xih/VvG8e2e/+aOsYEoGNoNLd0VimORTe g2EgSUCPKtnBNPHiJXc55P8AvQJIxIDkYb5o0cjFFDckVre0pAikYn04y2OamNGt9MVTJrzBIm4Q A4Ofao/85Lar/JI3t3qX6T1DQ31i1i6mtklsd2XOeasQxu47P1jHAwdQu4EcjFMiizurxk4Hesq6 wtdG/i91Loi+lYscRRueAKxxZEjIGFX5+KUWWMRsfjHFGEpKBSoAH+aE0gEecgv96C0jSOCx/bFQ OChyDGPqFX/Lsyl5VyxpMcxiU7ThhThrlnUZGQauwCwEVpdqJRhCDn7U+1VopLZHgC4U4Jz7VHvN E8rIykuexp/+RjtLAepiQv8A057VAiG3LRq0e3b3PNCMgBIY7vqzRWsLmzhSURlIpPf2odxEFOEI J+1E0uzEMAyE7uwHc1QR9rZQxj2BFSHTOvfwLUUuDaW96yj6Vn7L+1F1vWLfUZXncLDK54iUUVDP LNHGwjT1FIwTWxPDTqzorpDSJZrmxafqaTIzIu5PtxWHWGmu0Uk7TCOXGViz3pErNbw7vSCqeDx3 NF/6T3UOqpq00k7ogMjFiEGBmscETSOyw4V+5GaPAIn/AFsfuKkrVdOglQzu6p7tH3qdJtDJMJVG QUK9/bNW3g87gKdalbQXNyXhdls88E+5q0mkegF3KzbhkEDtUjRuJcIWTueOaWEB+r+oe1V+SeJQ CpA981cKA+445GKgTFK1tIjggupyARWSafDoXVtqZdU1ldG1CN9vp+nuDL7GsauHAKkKM/NMp0ja RGEWBn6h80Gf6l4Satb6O2p2csWpadgkTRkVgv5RoFRZVKbuMngmpjQ+utR6PdEspvU05+JLGQ5j 596y3pjX+mL+5vH6giT0ZfqTb3Q1rS9NeSB4lG1S6jtihmGU912uOdtbN6m1rp6W2W30W2QWyDJm Pdq11dzgs7bsgnNYs01jQkhMqNFwWchVJPYmsm1jwO1TQrOKS4v4ZvUUOAJAe4zWEXBlzwcgHOM9 6Pda7fXaBDI5Uf8AUajrCrvQ5dNLKzg81Ey5EjBjnHuKfzXszJtlYuQM5NRczlmyBU29M/2FKVdc ls4PtVpiZ7hmJ2DHCjtVmAC4A5zVnGXUj2HtVKXHGka4T6pGbJJ9qIun3t5zE6bR3yQDQEfaSAuD 80G5nMaqVAyDzREiLb09y4AcDn4oP1scDBI96XYXdvqMgg3mKYj37GnF1Z/lgVAzjuaBr6KNglsY FKWFGPYkn3oMpDEIQBRo1cJx2oLLErkoCFA7EnFMb20eOQKGZHPIAPBqQliWVdpXIFAvkadF2nLJ woHeoNw+GsWjaN0u17dRJO9wrKzSNjBA9qwPULiGa5YcBTJ3Xmprwuuunr7TLjSup7gWmzJgdzja TVuptC0zp4R/kLhb61c5SSM52/vW+tMX2xTWG9O6QIfoPcimo+kHAz96c3dsZZxsYOx5NNJIzFmM ZLe7H2rm1/0LGrOAeMVd/oHBzQoV2EHJz8UQrtyc8GrpSfU+3tQ3uo1IBBA7Z9s0WC2FzIEV9o9y azDStF0q00qUXIS6V1JBY9jVZYYUdlLL+k+9OYk9ZRHkYUZzRpJoirKi4CNgL805kvI7mzdPyUFt InZ4+70ENITuwo/vS4Y3LcijbNh5AzRJVMJUAHJ7UA1iZyQv0kAnvQM5QrnAPGRRZEBBUcMeCaBI uzCjkD3NSBu4a3iwn8yr6erCZ5p05PAQ/wDfFOEi5ULgMed1ZDFcdPNabLh71dRVcDAHp5qiIjml 9IjZv+FoLNIyLvTYR/TmnsgQD6OR802l2lvq547ii1YNhf1EftSUmkSTcHD4/Tn2oayHJ34HsBWV dMdEW/VLiG2v47eUDLI7cmiIabqCe4hVbhUbjaGApvHbGZ2O7ZnnIqV1vpF9GvJF3tIqEqc9h96i G3CMhDQEaZnQxQoEiXu/uaQ7OsZht32K3JK8En96RHCzzB5W2oP6R70eV4t2BxmgAVnA2SSNKw9i c80Bo32gyDJz2oxjkKHbKFUHO49zVmUE8vn7VIEqglUhn4/7UKSIq+5Of71eFy7SryQDg0sOrIQf 2FOwGWQscZP7UgSNgAsc57inBiKKQw574pDMpAwoUkVRSykgbmLH71aWRXU+qdsXuaGB6mTkA/ak ybGjCH370E9c2+j3VjblZACBzzjNMxcJaO5gdeOM/aoNoVOIghwc4b4qRsbJfTWBiEzwXNStaODq bSjDyjGeKH+rOD3qz6ZAtxtEgdV9we9DAWRsK20J7n3qskygnCgfuTQmkCkoDlR3o9wy44IwfemD DL/Tgj/vRrQ5nYJ3GwHtmiRzCR84AT496am29zgfY1fYVIbG75AoJWaFZIl2ccUyt7Gaa5jgI4dt oAHOT2pVvdsdvGAPmnCXbxussZ2SDsfg+xokZY3hVrWkWzPd3EQQDcFZxkDGcCsfaQwysqvyOCQe 9Njrmq3Uga5uTdsnbce32oQuT6peRQHbnAq3TV19HFxKxTa2Sp9iasrD08YwR2NBeXg5G7Pz7VdS rrsk7HuBUZhfq+lIFdeT704eFZoXaPIYDgUGMMySLKcrn6CfarpciGPajYYe9Xar49Q7ThSAM80R bAy8q2ARkYo/Tz6PNqQGtSPFa4OXgPJrJ7+HpxIMaFNPPgZ/9RSDETD6bgMMH3oiqijBXNEllDuU kxk+9U0PAw24e2KbAmVHxxtFLjYAFW55xzS1CM2Mdh3qyFH3ANkj4psUyc5AyvzSSeOe3yKoFmjy v6apOVwff2qGlZ+rGfpq6r96sduMHmqZwkfA5oyVtwOaE8cRPLFM+3zSHnZRk42kYpVsPWlAOCBU +iJ3oSwR+r7CHdtDSDGf3FetfhlbR2/Semqs4lKxAcfOK8pfDKwS/wCvbAZzscD9ua9ZPD2Cx07p i0jZZN3pd1Hvivkcs883uw3MUTrjevMXI9+axjUzHKxLcqPcVkerTLI7BDwSc1iursFgYY+ontX1 8JrF8/k7rLeiYohGdgP1dzWe6BGzzzn4JFY50IlqulBiu3aBk1mXTyx+ldSpzljiuc3cls+LXHWE rC5uB9+a0N4juvoOM8lDzW9OspwL2YYzknJrQfiNIpWV/bHavvcU1hH538jflXLfXROZQO+TWp74 u0uMdj3raXXdxiWUKfc1qq7mzIcHODzXi5Lu9vT+NdqFsyx715zVjE64OP3pcF96CDcoK57VSao7 yPviTae22vNX1wHyCAaXFGXbHf8A7Uj0j6MkhOFHvVfmWa2IUduxqAqzflyxxkrTSbUjO7FOGUd6 ISSMv39wKtKpaNlWBV4yXHc0E50XdJJ1LYB8AN3J9/tXQ+s29tHHGYpg5ZRuXPaue/C7T49T6ntp HAeKMfSR8/Nb01qCKFgwTkjkmvdwyPFnu11dFD+XBAf1KVlsEfNWDbIyQCKUoDJuBya6sLGMs3B2 0rJHGeKQpJByMGrklGA7g+5oLlcnAOaXGxX4pCFm27uFzRDhRhRxQWYFyMkCk8jtxxSiTkZ7VfAo B7WUHfzS4yD+o1bf3Bq0QLkgvs29uKAm8FsBcLVskLx/arr9W7I5qyDk57UFtm4E9iFpGz0YGEzZ 3dgRRkJDE9z7CnKNFvTeu5T3z7UDMnZEHOSAOKBMwlRWQ7VNT13JYfw4xxIRMT3PtUJcRlIgF5Pu aAHbHzViCDtA/V/tRVyFKkDOO9BwwIVTn5NWBDRbDtyc0FoyQfbnvUm0YSPcSD9qYTA+oWziP4qw AYMyhGbGOaDcAkIFf96JwY93J596CUGTWqQhl3N8CqIC8sMiqZ8ED2FXkDY4BqNqhljxzQ2YewoT Kyj9zRIgRn7fNApQvak/TGpJFX3bW5FGQxsuG5+KJo2QIwOF70psD27UYtCvCkKR80OV1A+n9XvU hoNWAHxxVi5YgfNFjdVBJXd70P1g7ELHgfNXbKnO07e5pcX0AODz8Uh1JOVGfk1ZZNoUijUDlYmf OCBSycqAoyD3opffu3Y+1DVsZ4xmikOpUHbg0F42bG5Tj5zRZWBJ9qRIcpkZVfg1nYZ3cKzK0Y4H sax25tVgdmLbge/FT003pDJB596h74MXYqMA9yalWIqX62HORms46aOQpxkgVhLqQRnmsw6TYsjH PC15+T03j7bK6XgkjnhPYlwxFdCeNNkdX8uevRqu8/w9m/wK556SLvcxAuW+rNdKdUFrzy+a5n9T aZMP9jXgvp785vjjw7sFb0y/GxcqPt9RqWwfTUHjIqL0yAyzXiKxCwu2V+TuNSd0SPTAHO3NdMZ0 8/oBiFx9O40Y2EksBkijL/IFMVlJmCg5Px81I6ZrBhglVTgjK/5rUDFW3qSRtz7Gkxo5YFh37Y96 HDaPIXBlwud2PipO2CzYX2BxmiIyGINnfJ/NHsfelxaWTcRy/SffOazTRPDO21q5Nw1w5RyASPYV jXVnSP8AAdde0e4MESrujkc43LWvGpK2r4XW/hzZOt11hCshQEKxYFR/atR+I9/o131lfjp8elo7 ufSQj2+1RlvGs0gimRpNoOxlOc/2ppPIguNhhIfON7jHFc9Vr/pUQiLjbHtA98d6eLHHFllTBNKN vsGUKlT3I9qRG3Bxlge1bSrs5aroChDZz8UnnAP9XxRUJb9PIHtQO7e4HpnIJJ989qzbp2K01TSh ZX2qrbp2VJuQv7fFa8YmIknk/Aop2SAepGXI7nOMVqXtzyxukhqOkNb6pJbWn/qYY24mBwGHzS49 PlH1GMA/5qtGuAmQSdrfTz8VkKC2tbVgrbieQfvXSOXr2xx4WjJDDBHapKwEkJVif1dhQd0kk5Lk bf8ATT1IgqZH1Edh8Vqf6csrEhDKxjdiM4P9Ip9bK88qOwIUfamumCeNzIqgj+pTUxHNLy7hR/8A HtXePJkI0KqnquCwPx7Ue3hVlyBlT2BFChZmwN3H+mn54jx/2rek3Ufc2+1gw/T85qLnQmQnBzUl cgsQnvzzTMrtbHvnFTRvdR7hlBLDk0LPqMB7kcCn1x6e7k8jmmjASsXKHB7VGjWQh29Hbzn6j8Vc SCJgD/gVYS7IplCbQ39VNw30bgcge5oo7ukhJ9xVkWNl+osFHOQcUNF3ZYf2pL7lP+pfihDpT6qA wj+5NF9YbccEr7imkKbmPJC/Aoyf83Kn+X/UTWts2Ftcc8DJPz2FKlT0yQCGHcEHNSOn3VpBcq0t ut1D/VG3AP8Aera41rc3hktLVLKEDiFGyKbRFssmQR+kUmeXDrHjG+luS2APpHxSr23kdYCcbFP9 6m10JqFuEjhjjfJxktUeLUM4+TT4D4PcZGab49N/q5+9QhFxbtDgE8/tTf1MMMcmn6SKUIcZ+M1H TDZOSPejUm1jJhsZ4PeiKyuUGcJnB+4pvGuXI3Zz8+1FWKMSqrOQue4qb6XSVvdXtm05reCI+sns vennSniVN03pl5a3umSTWt2CrpnY2PtWN6XK1hqwuVAdo24DdiKc9SalL1LfxXM0SxCNcCNBgGrO hFJInrTGBTHGXLIuclV+Cfeir6d0qiaYtzyW5o9hp9vdXESSyCzUuAxz2Gae9fQaPpuvelpUolgZ V2FDkA45qbNaT+jaXo73OnR30mdPZx65HH01kPj9qPhc2k2dj0nbxJqmFw8aAEAd8n3rUUN9NITG 7ssanbj5PxQC1s6sPyxVyeZO5/elp39rI7W7iS3YZ/pPxTu61W8vE+q5k3KP6H2io8qqHAPHbNCk tyxyM4rO9N6Dkk/ON/6qR5cdt5yR+1GRVjbGSUX9O6rLaqp7dvmlgHafkexrN7X0HcSC8UoyqmOx A71HpbSkHarDB9hwakjHtzjk+1OJrXU47df5bxRsMhQv6q52NSsfuI3gzuHOfimrlpXCA4JPFZ5p Xh/e6zol7qbMkUNmu6QSHBP7VhAkTcpVMoeQaxZpqVk8nTUNr08t3dXak/0oo5FYjKAHZQAVz29q eXtzcTxrG0xeNey01WMk/f3zUa2Rtw25VCt9hSZJSp3EkODuyOCD8j4NGA2ds/vQLqEYV1yzHuKN RTancTK3rStOfYucmrwqbqRA6cD2pBsjDGrgk55p1YzlZFJGBRrZ1qdrDa2uVG18Z5FRnT6+tehW 4yaltd1A3VogEQBHG4e9R2lxtDIGxgnsaSG23ujdGtNR07WI5QryQWxeIHuWrU9xE4kYOCHDkH7V M2uqXcEgaKZopAcZHvV5LM3MhYn6mOTn5ppky0wtkjccGpAKSeeQPelW+nOkhIwQOOKkYrZWTDAA j/epW8QLe39UBuxNO2iMeBwoX/elpHt2gDCj3FDlb6iAuSa5Wu09EFcjg5B9qbYZQWK/anLOey4B FNXkDMR/+ahFSYw24nJHFMmBx328+9SJgkuCIwvI7Zpq2lagxlkFlO9rGfruAuY1/c0U0mkEYADd +9N5grN3++KSI2d2KMrgnjBzV2UYyvJ7GsOsCkcovfFAmmO8EsDRn+pcMKavsLHgkfPtVjanYq+c 7c0EX6gtjhlOKIdz/qUcdqQ1issbSAqxBHA70Y+tmtxdbmf6gNvam0mpLGhI5z7+wol0tmh+p33H uBUXcvFHwhJQ9ga0bO5NZWO2EcpChjw6jNM5LlGACybi3bFSXTk2nadewS6lC1zaMeUUZJFJ17Ub G41IzafZiCDcQsf2+9UMfUWJGRn/AJrHcCaSxDptKF2POTVtv5j6pAFcewo0ccQXdvbI7YFRkSA/ SocbsDgfFPLWNZoyWGHDZB+Kai3kJDBjsPOad20ZMZ2+/vSpo6j3AgZyT3p/AzEoOR7E0CNE+kj9 QH1CpC1QSRGTYUQnvWTSU08FyFKjAxzipYQhGZ81GWcu3HBB4xUuWMnsQPcYreKnUB3oMHaKcSWw dSrHge9NoUy2CPpp0ZgkXA/emxH3axxwk/pb2OKYTRCUKwGBjmnd3desGA9vmmpJ2k+2OAK0mjCR 5bN2KJ6jnsT7U1VHnZmlbbM3JIp9IWLfX2I7imWXQ7k5A+axfS4mNwEiwVOaau43MScD/ar343TM 6/SD3Ue9DgEcEm65jMkX+kVls1vZNyBufTzjPyaE1v6qjnaop/qckV08foYWJfq2HjmmEjPv/mHI +3vRF40Qfqzj5NWmjguFYlgrYwKa3N6z8f0jjtzTYPlssaKsbFYguxyyjnBoLMU3Nj9hTtGLcggE e1Fa1DrwR6jdvtQMtNSaO49VrhCT/QV7Vkeo9Q2N7oUVtEpXUo23M2ONvxTN9Ds0031DqEgvxz6Q H0VAiJ7mRszbGb3FASSRpHB3bqTHbvkNktnnFXW0/LxSiR923nPzVXVy1paLKCxkY4wBwKlFahef w9IgI5J3c42r2X9zTZZGUlwxikfuBWb9AaJrus6TqFjpNjbXc10v897nj0kHIK1ieuW01jeSwXMY t7yBtrxnvxVa0ZxyRW8u4gs/ZieTV4o4DNuitlDtyTjJomm28+oXaRxxl5X7ADJNO4gPzDIqksuQ QByuKlY0EQIwW7+xpCo6kFjwfiiNJFwEO7PfNJWb15TGAf5Y+KqrLYyNkq2CfnvVoyCxi2F5O2DV 0lIG9soDwPvTiS7WGeJo03kDk470FPp0luwZi6AoSFYHH9qsHCwsMh3x+nFHuNau9UljW7kxDF9K RhcYFBQWys7lmW5B+kexFGtJfqDVOnH6T0y1sLSaXXYz/wCokPCoD7Y96i4LxbdJY1A2SLgHH6aH +cllyOP7LSpYJZrUyqhcRjLMBRkgFWABP7GgtBKkhMbBMf70mHc6jH6G7Gj/AJeSUNHu2MV4eppr QX5eWNUdwZPUJGEGT/iiXSvFGy+htwezLtbP7Vn3gxqul9MdVm+17+fZW6qUUDJY+/FYp4u9UJ13 17ql/pNu1rYiYellduV+ahtCwOVyQPqHODS49rzqXOCe9OtJla+lFuLMtNj9bDg0nV9EvNKuSsyJ FuGcE8irpKSmn2k2rLPauybQMqezEdxWdeI3XvTvU/Rtjott03BY3sBX1ryNACSKwOzjKmNRyzHj FGvNKmsLkRzuHdxk/YUQzhARGVAcH9OaKm5ZAB8dqDJcLBKq43hjtH2p9LAqTou09u9NBDRswYgE n5Pagq7IcBf70Zrx45CmMx/NXX+c4wO9Vdms7sVLx8Y/VWw+i+sNZ6M6XuW0K+gsXuUKzb1yXU8H /asAkjALRkbc8H71dk9JI1DHAGAM1ECtysayomR6khfLc7mPJ/3p4JmjXA4HuBTbAwcjaRRLabEq gj6fcHtVCndZSNgwvvRFbeAMH7YNNrBWvLh1HLs21FX3PsKkm0vUdN1E6fqFsbC52eqizDaSvzQN tMv73p2S9lgMFzJcDayTJu2j/p+KjBHskmu5G2XDNuCj2qQdUikJ3ZYd6bzwmcBvf3qaGZeGfixB 0Bp+qyzWX5+9uY2jVj/7eRjisU6bvLi6tbh5SdjM7H27nNJtbJY0xj9Xc0v0/SjAU4DdwKmxC6jG sMhdTgE4A9jU9qPR+uaNoMGuSWBGlsP+fnjNRM9ul3dIrn6FbOPask1jq/UtUto9CmvJF0eMDMAH FIMZWUXFt+aTALH9NLW5ugF2OVQd1o88FlEDFaPISh49QYzTWUEglm24HH3rSdqu/qJ2fVu780yl t39TKMwJ+/anAUrGNnJbvSI3Xey/UpX3NE2bJp5Mm9z298U8PTt6F9WGH1i3CBeSftUhAv58+mi5 UIT9PcmrdMdWT9I6wl0gEv5Zt0cUnIBoiBaO9srhrS7s3t5xyUkUg4pxDB65bAI2ipXxC8QtR8Re p4tSvY4rcwptSO3UDj4471DJqLBN4heIk4AIxmgmdN6Y1LWbWWSwtTM0I3OfYKO9M4SrSFHGQO4+ TU70xB1XNbiHRNR/JyXzCH0gR9YP3qP626F17wq6lh0nXApvJ4xPtjbIAP3otM1jE0j7B+n+mgsS VJI2jtSkuI4ZiyAqxGDSIoGVsySZEhyooioYGdiqoWc/pxTC+S9/OflZUeJt4JTOFJ+ce5rKIYza qdjKtyBkA+9Rer3882XmaI3KDKsDyKDINV8OhYdDHWbzUY47h22pZ7gWepXwHu7+fq1dNupSukPA zSRP2OBWIwLb3elLPeh5L8f8sFjhf7dqDDqd3b3RlhuTBMEKF4+5U9xV2vQetm3TqzWvycWy3EzK m08YzSYkyQGBC1QjD8g4+f3+aIiFmwxxj4rCFiNrYoxBXJ4Ip2kMssu55lkAHCkU2e9Yx+n3VTkZ FIWZvY4b5q6C4Oo73Qpg1rIbd2+kshwcVkHTnTmp+JWryxw3O6WBVmlluG5ZRzjmsb1S3E0aMqgs rUZrbVLOWKeN7nS5COGxjev2oMo8U+upes9TsNNi0yHT008ejIseCZGHGc1iU1tJaTbMGHPfmmul xm01lZg7SAtlmc5yfk1K9TyLdahGdxZMZYr7UXYkHTF7f2BktrcSrEN7vu5IqFsrxJbsmMbmjP6W 4yayTpLVjpl4xnkJsWRlP9/eoi40iNL6W5tonkgYlgwppGWnqiGDQZrKCJoJbgD1XLZxj4+K16un me8kmZyig/Rg9zU3LmWz3jII/q96i4cyXK4GSTxu7ClGcdEeG+o+IkEqW2p21rJbDPozJkvn4rNv ELwN0zofw1tdTutRVeoWYL6StkFvYYrW0sdzpUMdzZagbW4xz+XbkVBTatq+sbZb2/nvmjP0rKeF /wDu1Uv+lraSX03a7+o47AY5+KMPTUbUxu91A7UzEs5kJkbIY8jFSFnMkTyb41lLf6qKPeWbwaYz MQHzlTTUxlrCJ2IDNxkVe6Z75lQZEXuo7Cn91bwLZWBUlnDZkHwBWdBlomh611NrttoWk6X+e1C5 IWGNByx+ayXxO8FusfCaytZup+lrrRjIwKTO/Bb7U48MfGD/AOq/xP03qS2gE35WUfS4yCBXQXnT 88+meZPoPS9Bt9KWzv42VpJSOBg+xro4XbQvVC6j1b0PpUzxSX2oQyKojzlsVFTeHHVsAV7rSVt1 I3APIM4NV0tZdTJaNqlrqy28MWFj2kNgfYU2n1fqDqvWUS51mWa43qoaQ4GM1nTW0L1FbappN9Bb zWDwyuMxqykbhTu3mkaVXnRfVVcYAxmtuePl/cWjdIabK0UtzDZH1pEA5/etPs7SXe5myrHNaWU+ sruazEsUUrKjnJjzwaIXDEliM59/er2loJASBuYdsUf+GSOP5g7diKJSNL1GaxknW2h2NIMMz8iq sun7qWzuL4Wchs1f6pwOFPxShcQ2i7WOT8+9S9l1zfWfTl5oNvj8pdvukJXnHxRm1ARuyRb3jIj9 m+ac6VKLnVLNLV1jLyhPUYZCk++KWypHZJbleVxg/wCofFS2r6xaXFtp0dppUVgbYDMkZyWNGNq8 RF1zTtfWHVtVGpBEHprH+gL7YHtUJN6cqbQoRTz98041IvesCztNI5znuRUbcW93CQJ4mjQdmIxm jFEW2AZWAznj+9E/KugB24zWT9FdB9RdbXCroWnJfi1xLLuHAWo3rK/B6ovLVtPls5oNqG2iXscY /wB6lTZkjia4USndheMngUbSNMl6gv2sLVxFM/6XP6RRNEsrK01a2utblaG0R8y2jcSMn7VkEnTM Wtyal1Ho5k0zpZRiGaThi3wKRfUYfeafd6Lcy6dJqMs7q2Siv9BPyBStOs72/mkKWcsqwjMjKpIU fOaVd9JX1raxax6+5W/SZD+oVMdN9f6jpGnX9hFIkCXa7GcKDt+f80sELZsLxphG+VAIJ+BV43SG 2Mav6wzkNWQat0EOkumrfVEvob03hKmOJs7c96i+mrNbVL/Ubi3ZrONNgYj6Qf3qhrFEfRDjGCcH PtT+wuriYNbhyUzwlWvLi0IjjWIqZOcjsKlE6VOnaZb6o93E8UsvpqqHLg/cVabQ86GFyD3HuaUC DDuJwCeKLPaM8rt6hkX3zQpLY7O/AHAq9rtIdP8AU8/T+vW1z6QurNAVa2l5R8/IrNJOg5fEnWWt jrMOj6P+Wa5khJHplh2AHtWr5B6IQS7zH3wKew3jSQYhM6bvpfkjI+P2qXf0hz1f1TqXVenQaBfX Sfw3S39K2MYwW29mPzTGwuhMFhH9C4OO7H2oQ0zMxCkgexPzWZeE1nZP1bcJf2qzXVpaPcRwt7sO xq+09GPVfTeqdMpYTXtq0MF1EJIiTy2ftUKpguIWZUZLhh9IzUj1h1brPVuvwTahcZb/AJaQ4+mM fGPam00PoFWHJ+3vTUiRHm3KQorknnJY+9XudUvbfULR1nubp7cqyqzll+wxR590y4cFM9gakOkr v/h/qzTNXkg/NWtsf5sDDKv96hYH1Xr69aTGWe3jinOMqsexgaiX06SyaymkGbdnGTjJ4rIeutXs +pOrrvUrNGtklb6VC7eKa6xeo7rBCcWwQZBHdveo1PSV6x1qy6hawuYx6ktsgVI/9OPeoUy3c2ox TZMlzKNg3HJx8ZoMMRBP0sq44bHBp105bpe30qyStG3aPHcmgsYZJLmQTOFdR2phJu3ZA5z2qT1j T59C1Ca2kbe/c5570BbeFinqPtU8sfihsCJVdlLLhh/tTmadpHWR8HaMDA70LTYJdX1oWGn2814x BYbFySBRdVsp7CT07m3ks5SNwimG1iPnFa2lva6y+o+4sSfk/wDahTODkAZ++KDCW2tkkA9qUss0 lxDHEm7LAEVlVAxk7DLtcD9NWnhkFsS7q2RkEDmtkeGfg3ZdcdF63rN9qg0ya2LkDI9uwNaw0gS3 sT/nDtgRmVX92wcCta1FjJdS6107qHpCx0P+GRW1xbtzeIm1m+5qOa3sre3Ntan8yxXLSdtppveT q3oxqAQn9QGM1aCVVny7DBFNptWgadNqU9xEqB1t4/UkLHGFocwEU+1BhRV0EkTTCNjtfjg44+DS JgXIIG0gYxUNnNndRG+hF0jSWe7+ciHDFfgGo+/WN7qZowUg3n01PJC+wNKDEKQrc9j96A24ksTg KMkn2qBBPrxgAbdvvTiZgtmpyDz7Dmn0OkOdNS9nR4YZh/LkIwsg+RTI6XfXVtMbKL1oov1sP6aB /wBT9Ltp/S9nrUckN5DP9PojG5SfkUfwm8OJev8AXbywSUWV7BCZocLkE47YqI03RL681jT7K3Ja 7u2CxozfSD8/at7dPT6V5ZrTUNS1i/XVurb+MwR21vhhHkVdVi/6aOne5ea+sbyJRfWMjRuw/qwc Zprp82A57UJbiS5uLrUJeZrqVpGXPPJzTzSLKa9uktbYKZZDgbjgVG4PP1Hp13ZQWWoWTTH1AWdT jC55p11H0vaz2smraEMaRvEaRu2W3Y7ioPVlSG/wycxNsk+M5xT+zvo9NgYyqVhdv0g8Z+cVOw20 vULzT43aOWSOVf0tE+1v80a56p1nWnj/AIjKZogfoduSD980FLRLl5pIpVXf2ye1Wn1AJpy2Uqs0 kRyHA71RWqKZ5DNK4dsY3D3FSPT9n+evYrD8wtqZo2ZZZFyMjsv96gJ7r/0px9LZBUt80/uJLpIo 1ljNvKFG1sYJFGiL2OXTrqW2lXMiNhiP6qbzWyXL4kQow7Ee1Gtw3plmbfJ7N70sZfOf1fNE0DZ2 k8OpxLLcu9qP1K7cYrN5+vY9M6NvOnNBUWlhdn/1DMMh/wBqw2QPLGwcZXsR24oBhcBVK7YD8UZs Etz6sLq+PTUYSgwQs7bXyoz70tNkSyOR/LUZJ+KzC36N1fqfRBqOk2ZntYkzI6DkCjbDZAIpCpBy x9qebWh24GVP6m+KB6K7wJZVQE8sT2x3rILDS7K56bvbu41iJLm2+qGCNuZB8GibRN0Y1IjSTe5/ ScUA3PolEkbLk4AxnJpLzmXHILkcY9quqbJIpDxcQuJEPyR80VKahYGxIQpJHMyhtsike3tmosIz oyE/UfYVmHiH4gzdd3GlzXMEdu1tF6QSJQM4GCfvWGRsBLuBOKjKe6W0HRZZYxrV/wDlbPP1fTkn 9vip3Uel+hYWaW01lpiR9EZUjNYRK7ybVOQoPuKu0XqbCy7ucg47VWhY7cW11cENhH4Ue9WMIYEn 6tvG6jSQY+puRjvSGlCqUThG/wA0AlQpIn1Yz/iiX+2bUCsaYCgZPsaqONJCFzkjnApwyJGD7k9z 80FkRWjDqNrrxTWT1GLBuFP+aco4wFHGTTmxsxqkkqiWO2ZVJVpjtBobR0cpU7d/b2+1S1tKI/f9 YxUZBaNvy21mPBxUzpVk11dQwRRtLI/6Y05JobN7Dp6+129khtYDMyKXdF9lHvU94Z3PTNj4iad/ xfA03TyMVmGcBTjuRVhe3vTV1NJaTPZXiqY2O3kA+xFY69st16j3GZmlOXHbJpHLLbKfEi16Wh6s u36YLnQ3JMPP/asagKRsHwcdtppaWvpIFRQEUYA74pSwOwycc0MfXZajJJAIB5oTv/JZ0H8xexoq OVPOdopVtEHZiTgD2+aKvDb3ZskubkFI27b1wTQSSe4PFTevdQtrZi9QYEKBFXGM4qFYMMuvDf6T RoNpC7pE8TIG7Ec05RcRl07D+oihK9xcsFMzQDsQq81JTemNJS1jJ27su57miRHJcW5uYJb7+TCr fVMoztH7VKdVTabNepJpMnq2RQYlxgsf2qJlAKmIYKA8Ur0vWYbjhRjgdqKFtXcHZyB2Jp9p1nPq ZeO0tHudoJ3L8D5oFsocSKy/STtANSPRXiFd9EHUI7OKOcXCFHWQe2McVKIIzepJIBGVKNjinCXD ZBKbio4Bpml5JOzuMIXJJ49zUrp2havrsVzHZW5me3TfN6YyVX5qC8ErXC/mGUomPccU3Myvuwfq zzWR9O9WWMnTiaLfWMTQOxAnPDq/3qCvLGPTryWGIiQKNwf5FX0kAWNjIMck9gKfxyqkO1gN3bn2 ptE5Uh1GG70C4dvUZmOSxzmnaizwl3+gZUfFAlRlxxjPtnmiQ3BSRWOduecVIaolsxja2AY45PxT 6EfYJepMktpO1tIjZ3q20/5o17d3lzczXNw5nu2/rbn2pMigRD4J9uKKJY94jwVB7GqBiaRo1acj 1G7tVtwkXBXAHYilTRpIr9/p96T6RUKB2HtU7CJAUC88E8UO+gudodm2xnsRTqLLPkYOPY+1Ggit zK35uRvRbjA5xSrpnHhh4R2mv51LqlJLbSFjLW7pJtMrYyP7fasM1x7Wy1W9TTx+XgEhVA/PA7Vk Vp1RaWgtNJutQuptO3ALkYEeaT4tdMaZ05Lpcul3ZvorxS0n/SfateUc9MXtL1C4O7c2eT81aVlM jHsCai45pbXtHz3pzbzC5bec4HJBGOajYzJljhsD4qmQggj/ABV9xjbthTV2Yk/cUFPG0nI7fakP 9Dbl5Yj9NSek9Kajr8wFpNBGvuJmwKBfaTNpt28MjI06fq2nI/tRdGDQLIFIOT759qeWzvaOk0DG KZDlXXgj+9ADKhIxlvelpON3sBU0aVeXD9QdSxC/nW2eXAaYDt96d6qsVjfz20Nwt4qHHqqu0MKj r0Ce8hkiG517n7VMXAtBaq+0SzHgiqaMIhCIwSNwPcmkyGNmAj4ApSAPI6FdqIMslJJ3yBYowqEd zUiEMCBnHekbhGxYnOPeji3Lr6hYAA/8ukSfO0AfFUHhmMsGwD34x3NBmMu4KyFRjggU+0eVba7j kWMSSf6T2qWm1uC5tp4zbBJeRuQUktGMxXZtjuUncO1VJM07vMx3yt3FNhGysV/UVosACMp9z3FF 0qU8HnkjtTeQ+nESyKxY/wCKkNXtXtIIpAV57jNN1gWR1ySF255orINW6DbTOmLTWhqsNwsy7vyq j6hWPbAY1b2IyRRNP0yaeCf/ANSqxwNj03f2+wqp4SONw49hQNigL96Xaz/wu/guVIkeJ920jg/v QnYoBnt8VSRSzliqYGOC3vQP9d1eTWp98gyW547CopI/SOAO1OhbsMA8H3qolCIYwAXZs7z7VQE4 4yO/fFIISM8jgHvRHUerg5xnk+1VfWF3BGkiwMbduA7djUAZLy3jjkIc5x8VsvwVlsYNC6is2lCa jd4kgLf1KByKhejegtI6o6JudVvdaGn6jaysBY8ZmX5rFfzFxot3HNZnDQvlUz3H/wBFP+1suug9 SmjGrT7/AKtjlWUexpAlgONoyPjFSup6pZ6orTx6dHaXMh3yspzuNRm4srcjj7YogyQgn1QP5eKJ b3s1hcpPb7GdewkXK/4pzo1m+pW0sS7cJy244OKY3dvMjMsKbo143UFahqxvHaWRVErDnYMCmUSv JG5R2ULyaPZQ+jdqb5MxnsBUjqd7bpGIreEIre9BFJop1l9xzvTu3bNGvtXttX0mDTLeAxS2kh3z njd9qe9PWbSXDl723hOfqSV8E/tTnqUWc88UVjAiuB9bR876Kg1BRA3BC/NNrhVuFYvwD2FPZrOa 0smNxG0TOcqG7mn3RnTkPVNvqDy3ggmthujhP9Z/+iiL2vU2srpyafeTtLaqPpVjkY/amN7Kkwzs 2gHnj3o019Lo+pRyvEtwifQYm7VGajeS394ZER1iPYKOBV2K/NBEbccj2zRraNLgBncqe4xS7Sw3 gbtrEjjNLFm+nM8kpVmIxsB/TQLbcVVGbfg8GkxW0gdmOCe+aDC/qjcBgKatJcFWOxjtqB+eEHGT 3zVmTYxb2+1NLaYhiXJZPmnqzKYzh+PmtQPcaL/CWmjSVdRBxkt9P+KjDEzx7/SVs+5pSogZWwWH +1GuNPaOfKuSpGdvtVTSySO8WD7cD7UhY2AJYDj/AHo0Nk0G5mkJ98VU5G0j3ogb3Ma539h74qjK joDErk/9a4xTjTL8aXqVvezWS38VrIH9FuzYrYnV/iBonXr2l3BpA0mVUCuirtBNBriMDGT/AMz4 +aL7bSME0q+haCcvsYK3ZsUlclRuOSfegSqjOTyfn4p07kwYYZ+9NBkE5/SaKpOzGDRKdPdyTQKj OxCdgTTaW6h08q8v1NL9Kr96H64AKkHNNb+JrtcxRlmROMj3pVTfTvQfUPVmpGTRdBvtSjOA0kcZ 2qftxWzNZ8qfW+g2dpd6hZmBbhN+HX6gK6B8tv4gXTPhd4a2HTmp9NCDVLfEZlWMBZfuWrMPFfzd aN4jabBdTpDaJEu2GGNsk5/vWMd5MW6jgLVOn7vpq/eG5Lh1P9R7UlZt6lWbfHnPepzxL6rg6j12 e4iDLFnavHasbtHRY9pBO6rTC2zs6hhdtwGBnnNPLdIokcTDdkf3pl+ZWNtq54FXLuVPHc1K2f6N p1rqepQ2F3diwtbhwhmfkKPmtj9U62mgTW2iWlzp+o2CIEW7SMF2A+TWp7q1jvnAnfbGq4x2zRbG G0sYXS1QLIckO7k/4qtbPtdtZRqDEkiMnKgHgioqVWDOQf2FZ4s+ndQdKWa7Uj1C0Qo755c/esUl gK8BRx8VDaLjhaUZP0/GaL+XBxn4waU7lGwT/t2qhIWRwOSaAc1jE8YyVHv80BkSZ1tyi7QO4FLt LZJoWfcVGT3oFvIDM5YHC9mNCQWeR7UemMAY7fak7Q0XIwBTO6uDNcb8kR9s0Zrj0oVVmwD7/NZ3 t0xxPtO0uzvBIbq4MJA+lcUwvrOK1JCPn702S4kkcgMRj3qnkLAAnd8VHeQhyduTyR/vTOXEbgr3 PtTiVfqOfaqWzMqjawJ9ueaOqNjZmdlY4I5yKpNwYcUVkWCbkhs/HzV9o2MTkn7VVpBlXkEe+c0C WzkuEJSM7h2Ge9IlUy4xlR7US1lkt3Vt+cdqIyLo3X9I6bs7231TSWupblf5dyP/AGvsKjrq+jl4 QkoT9P2FAke4mOUKFRwRTN8rkxEHJ5x7UD9bGGRi/rce4pYVIwArEj4NNIQI7YMTgdyTSobnaVm2 74ycACgVIWHAOAKb7GVWfleeDUg5DrkjB74NNJEH5hckhD7e1AmMRSRkXAEgP9TDJFOTrEsEQtos GD4NDjALsrgLFnGaey9PlY1ZZkZX+oc+1S36TRlbXUgWTH0t8/FLMreqCw3cd/mrw2ojLE9v+9HM YbAxipCAIZJC21lC/cUTaQSSw+4qyRooIk7ZqmhBG6PlB3NaXZLyqnYfuRRR6aAOkjlSR9JbgU6s NMkvEZxEQg4zjg00vNKNnO2w4THCH2omwTu/MNsyd3NSdrYTSw7fUAkb9Kkf4qKQPGxZGwcY/vRL S81Kab0AGd8giXHI+KLpI33T+q6cFkurGWCNjxJtJBpUaLImRksvzUpN1r1SbN9Ov79Z7Jf9SjdW P7pdpkUkx55YdqMqkwjsSODQmT2NXnkE8uVJVcUES7SQ2ftmpAUyemOFyDTd0F0x9SR8ZzhTijiQ OAOFBq8cYkkKr3qmh4WVI8kHAFWjs3kSSXd9OMgYpRspYhtcFAeQSKRsaNGzKQftUgG9qYWVj9QP NKikeG5WaEvDIBgMpo1pptzqNu0luwYp3U96GVliX6gQc4xiptrRzJq97d4FxKZV7d/+9BMTemzj A4oIVnJJG0jualYLKU2SXCQPcW/ZsDtV2yiGdlMa53FhyKBcSEMI8fzPY05dPVnaNV9Hnge4p9Pa 20ln6sbYuOzKe9II6LTLqRCWTEf+rPvTmbR7mwtluHi3RtwAOaZySOqiIzOqg9hRRq988K228vAv +rvQN3tt7ykkxsOQAf1Ul8LECYzG3tk5pUhH5jLn+Z7CiOWmAyeR7H2qi22Ry2XyfmjWGnm/uFR5 RBGD9UrDIFNiViYkt74GPeiS3M7WyxohQsSCftQSut9LW2lRpJBqsd8XGRHGnNQ8VrLKx/kucDnc pHFCtGuNFummVg5Rgfq5qfv+r5dSgPqldxXGdoGKCBMqROu2EzA5HftS/WUwsR9SbsEfB+KtaSbY GxjdnvTRp3ty47Ru24qBwDUXZMspU8fSDRUmJBGO4703BDsMsD9jRZJGi2OBlCuCB7Gqi7IJXGXw MY4qzR+iWcfUqcYFJjhdIJD2z2J9qvb7k04vncN4+o+9F2NHD+b/AFfSp/2owYRpt2Z28Z+aFIWa D1IzuUHBx7UiGYzj6BggdjQ7EwZwTjbt54qkyWXHYHmq3+mCT3bvV+cD+mP3oi6LtnkwcqxyAKWp YH+ZHlj/ALUgyhCGUfSD3NES4dlJOCuePmgHHuZjxxTn0RGAxOSRSY9isWLf2pypBTnC/GaAUl16 Ixjdmkelucswwc9qTLI0UIC4ZiePmjwKXUFv1Y96LCYoUJJkjBX2pZaVSXDhGPGF4ojIAGUH/FIQ ZYfNFDSSQgq3LfNESfaPcKO9O7fTzKpydpJqQ/4fPpbiy4bkAe9BBxXJWRjnbkcA0uIuqtxye5ot zp5jmy/OO1WClUUrx+9BePIjUDuD2ohG7n3pCEc881YMccZPPtQWYHNV379qpmDE4pB5IzzQ0RIm cAHjOcYp1AwjUOqbQvcmgICZB2xSZVYyRqP0Z5Hsazl1Kk9tmeX20h1TxFtvYeqG/fmvVzplYIen PUxzGmFx+1eX3lZ06GfxPRu0a4x/mvUPSittohAXKhRgfPFfJwu+R9HWsGI6gkcZYj6gTmsT1W5j jJyM4NZXqTiMuSNwB7CsS1OeOZyMDO4cY+9fb9Yvk5X5Nm9HPAugtDNAzs65Drxisi6ZuTBpVyME 7cnNRmhzxS6CrrHtUxgZH7VkOlzIOnWX01QLnJHv9654fydfrtqPqu49SS4ZjjJJrnrxOu3a2IDA YPP3rfHVwXNw5JALcfFc8eJ7D0iA31dzX3eOfCPz35M+Vcydc3DG6mIPuRz8Vr5F5kkbsaznrfme Q8nJOawZcZKgHb8V8/mmno/F0tbwK5JZtqn2rI9NudLhhjjkjDy4yR2zWNyQs5yHwPiiJlWGB+4r y7fVS2qXT3W5o4I4rYcBB7VDTF2w+3bH7gUtP5N9HIxLRjvGTxSJbhrif1ANkZyCooLxNtUHg59y KaXCTySsvqlU+RT2BlFtyP8A7lMXiKyEiTI74NBsLwU0tm6jSG3wNi7mJ+K3J1Vb7ZUww+5rUvg7 bPNrKzISHVvbjitoa5dP6smR3avfw4vFyV1chyMH3pbfQBgYGaQgUsCe4orxlmBHf5rowuORgjH3 q6qAD757ZoR3Z54pRdkwDzx7UC9pGeP7GqZSBxQRPyecZoitkc0FEAmqKbSMVQJPNKT6gfmgRtbJ OO1KTgAnk+9E4xjuDQXI2DAoF7/YVZpTGoynNBj3ernv+1O9o2nccigQzZXA+kn3pdrG05KHJZfi kw4D8nNSFpqEenyvIsQZsYzQR8k7IWRFMjN3B9qaox5D5B9wanW1G2Cu0SBS/fNQVzIruxzgjtig u4w3zxQywXtwfelMd4yRzj2psIn3ZPIFWAkrZI71YEPlcZAHagM2ef8AahTSNGhdTitSBWCsjcce woB4zk45q43bC/JoLyFgcitLFCNpJOOBThUJO3Oaa54+h/r+DVzJNE6F1HfnmstF3fpwMBnJPehY BH70qX0pJiy/pNIUEsfYZ4NBcqpOBkn96SeR8UWK33jcoPqZxilyqI5AjgBjQMowWJyP70tlLkY4 oxA5B7fNDkCA1AqLCE5PFL37ACOfkU3JC8LV0yMtnt/vVTQsgHJXgkdqb7WQggAg0t51znGKD6hP B5oQUq0QA4IFIY7pPtSGkJ47ilKvfjmiq2Zba3Y+9U6fQUP1KPelKSjYYZ+9V6mBlQD9qmhHXcJR c/4BqEmZ8tnt8Vkxi/MblYgHBPPtWMXuVJ7gE1mrEfKyhu/+9ZV0iALade5ds5FYTMCZBye9Zp0g 2UKj6QfevPyenSe2zujGCXi59lzXTM2L3wK1NAuN1hKuP7GuYumSEvwSeD9IrqbpxRd+FV3F3Bgd cV8/L+L6M7448PRbi31jVrfsyXT5Hv3NFjk9e6AGCFGKe9Y2bWPiP1XEi4kTUJEVP7moqGGJGErs fXU/pHYV0xl082UN7i2/9S4jJDA8H4oYDRMF2kF/1NTmJxNM7qc5+eKE8ixnLH37d61GCZkOIyCV iB+pvn7VJ2FpNfTqlpmQnsi96ibueVhtXiD3U/NSeg6zLo10s0DCC4UZSTGcVYMs0e+vOnbv0LlJ IPqG5S3YVsvqjw26a8YLW2uv4j+S1KCEIq7uGx7kVoHVdUvL2b81c37yzSZJcLjND07qnWNLmU6b eMkuP1t7Vu3bFjaGkeX25/iAg1jqOySzi7CEhJCP3rAZ/wAl0/1zPFbbdSsbF8fzDkOR8/NROu67 qnUkgbVbyWSYe8blcj+1RywJCfoY5Xjk8n9/mm/pcZWRdddUxdRXVuLewi09FPKwLtBqKAOQAMAU JIlkVTyxpTSbMgDA+ay2tOpVmPzSIj6bgHNLEm4gEcmku298gfV81IgrAvwn+TR4YGZu5wfbPekQ DJ55PzToSiNhsUFj7E9q1Izn0XHH6ZIwQD2p7buWOO4Aoca/myrNwR7in6QLbsGI3Z9hXWPNaf2N tFlWkXgVKvaWqKDGO45FR8SYVWX9Jp3Fu2kj3OOa74x5uSl2w2MOSTn/ADUtHb74wVXueRTS1td0 uMZIPBqfsUDQnsGBrr6eW3ZpFA0R+pMKPfHNOFGTgg4xnincgTJAXn3NWto2n3lDtArWmdoe8f0m Bwo45JqO3kkbuDUlq+ntN9Jk5znIpotudu1uWXjNStY3tGyklmC4x803klKDG7PsAKVcKVlddpBH cCgSArsJ7isXp3hvPc/QI8fT3NNoWRrjCg+l7jNVIGlnkKnK0GSPblkOM9xXO1vTIk02zn01z622 Uc8e1Q8aiNdhYsM9802WZlyC5ye4+aCk3ue4Pam0TAikPMI+gdyTSSygbQMA/FMTM2PpYg4/saJA Sx+o/tWpU12fsAiqATg96oD3yT8U2eYbwpG4URXXK57Grtmw4iQe/OD708kTeqjjHzUduZMgHKYp cdzJJGQRjb2x71SjbR+lvbsatLKjKVKqpHvQ2YMpz3NBk2qNp5+TUtSEAEtk80GdQVz704Urg89q HMRxzxWXSG0MQlfYAASQMinN9p0lgdj4Yr75700jJibtk5yKVJK875JLE/NBaMgSE4HxShawTkia doVHO4UNexLcUpmUgF/+1Nro1mtYkVgJDLHnAY+9Rz2C6ejTbjIAc/Tzt/YVIlkIZAfozmnel3dt p13BOqBhG4bY/Ib7GspUHJGWjExWWFf1L6ild3+aP9b43DaGHBFZ/wCKnifH4g6bp9iNIg06S1bI kgAG8fFYGVliVYyfpI5+1JWvZu8ABKgUghkGBkn9+1OmAV1w2c0llWGQHb6iZyRTagozMCQBVmBY FgBmncskTEyQwelEfb2pGzJD9s+1A2WP0XBP6j/SanLfUnNo0U7sxK4Xnlajpbc3H1KDn5FIisJZ ZdxY/cGiKvLc2PTZs7XXndJnL3Ns5yxPsAfisaaIyGNcAKoxxWSTaXbrId5JcdiKi79UhO2Mdvms ZNYmK2/pyHuR7GisiiPDpjHYj3oKTlnOTwKdOAY8DB47/FY06IqXlzg/2pVo3ozBiMgnnNOREAOR /egzEblwPq98VlsbVNNhRxIt8shP1emoxj7UwgQs5PP+adTW8dwuGAY/bg1UFsdyokR2+wHtSQ6S FjbfmAFcZUU4ltYImK4ww7EU6sLRrezMkq+n8c800kJeT5U9yRW5GZV5II5wrZ2FOcD3o9uC/INI EPqbivsKc2qEsMjA+1R0h1bqFVwcjIoyS7VUADfV3COBtOMH2oKtGZf0/wB6510g88hUqrHbnsPm lwWRGWBye/7UcQx3ESBuCPf3rNuqtC0/StF0xrbiS4QFiO+fmubca1nWO3mf1CRGeN33pqUCgt/T u71kkmnhAGdc/uO9RWqqkiekuF+wqpsizlw4dslRzmnlj1de6VBe6VcFzpd1J6hjB5J/+imoiWO0 XkD5IosFlFeJmRsBRxmo3EDeNZiT/wBLC0IHfJ4NMpI1CMVzj3qS1O0it3YJ9X2qObIUs3Kjv96x XSBmESqe+cfPNM7iWSGB1jQZDAc/FPR6gb6VJDjggdqZXVp6cLSzSfUO/PerF2YK08m7nt2FNr1x EAQWST+racCnYzGucFQ3OTTDVmBjVM8P3HvVqX0ZPMrkM5LL3wKdab+XksnkmUNLkhV+1NXgjUKE XaAOPvTWcGWVSAyY9hV2ycy3gU7VXaqj6Se9DdC5V1OW+TQHDSMp7YOADTlWCjAO7FNirdd/1Yy3 b4rNdE0vSpdMaXUT6ZAypVsZNYbEzPt47/FOPyReQNI7MB2TPAqWkSOs3ts3pQWgzFu5b/xTh9p2 BF+r3AqMijiK7T2BzUvARLFnIVs96jWl4GLAllxk9/mpjT5fp9JzlBz+1RrE+qgP1L7kU6gUujFB yD/mkT7SljuubYkHDqxHHxUol40W0Fc/+aZaa35axC7BzzTq3hkmkDkjA9q3Iu0paz+tGW2hcfar yAlSfY0UARxghQPkU2uZGwvp/q3DJHsKRk0vIwVBHHzigpIB9O3j707uw7kpgBBzupmYQoJYnb7Y qwNr1SDkDGPao9uV2/5xUjMMjLDjsKYTlASADwM8e9ZqwwubZGIZDg/FNVkCsQ/KjtijT3AjZTsL buMChMy3FykKLiRj3HasioJ9Oin/APVwyOhPeM4NROoywS3D/lg0ceSArHJxUpq+mzafemOdQPpy rDsahdg3tgY+5ohtcKIVUs2AeOTQREQ5x9QI9jmpiyWylv4Uu4xNbt/zFJxUr1Tp/T9ksR6fDiR/ +cjEkKPsaNsWSJowuSKt+bKkZUk5xSRLslLMeParOpQCQbiM84GffFBa4unA/Sce5xxTAXLepngA fatzaz5fNT0rw7j6mvOoILIzIZVs2x9S4z3rUtomnahbo0kzRSj6Rgd6aFoZo3UiXLBvaiyhHRk5 IXsKVHaO86xIhZScKcd6L6Uljd+lLHjb3zUArXqbVNHYw6fPLA7DLenwSKmeiemo/EXqmODX3mlE 8gRXRsSOT96cW72sdsspjX15DtDn2FNCt/pd/Hc2N0iTxMJI9p9xVaK6p0DVfCzruSwa3Nu8Dk2q ynczJjAJqFublUn9ZG+tizSbeM5Oad9T3+t9U63HrWszrPe42Fg+cLURJC4vADEzljxjsR96Wsjl ojGskUZaR+VUDNXErW0RaaznimY4KupFONE1FdK1mzu3jBjtpw5BGQQPY1nPjN40ad4nX+h21ho4 0+OyXDukQX1P3wOaLGCTMMYlAwOwFDVlRAUBJPzV5w35ksVyD/ilqpBzjH7jiiAu+9Se7e1N58hV VgRL/wB/71K+ipAHAyO9K0jT5tT1g6a7oiMu5ZW4Cf3qRpDm6SFNoY78cipLQdSmsY3RV3rKMMjU K56edNdl0l4zcTQ8mSAbgfirx2ctpfbJkeFwOCwxVZJu1/h8qLIN9u5zhP6avHeLLK3pj+UBkbu9 Fitbq4v2t44vVCfU578Ua/uLSdikNr6BQYY/6qLshAdXCwgCOX+ll4qMuIriyuTay/qPbnORTi3j YvuDFO+MHFZLpMdkthMLi2W9vJVIiZ2x6R+R81OmaxhLu+iURxSCCROVcjtT7EurW5e8uPzF0vd2 NNvy8ojZpZN5RtpOKLZWUE8rO7lXVcqOwqqUjR7E3sBLEcgrTa4leVmIdpXzxk80toggOPfk5pEf 0TBgNrgcCgPpmiatrkUtxZaTLcW1sczTKf0U3ub4NK7oS20bSP8ATWZeGfWmu6derpOnW4lTU5vR kwuSmf6sUrx46R07wv1bT9LsG9XUJv5t0PcFvn4onpgNvdEuxAJye3tTxJ5NxVYGcjnI7Ch2thG+ oQItz6YkI4PYVkPUcEumKlvbXUDs694jubFFY7LI0jliOadBtxtxtAiH6jSY7Z7eyM112Y4FWRCk fJypHFAK4H/qAinINO00i8Sw/Om3b8kX9ITEfSX+KA0GRuccD2FTL9Q6lNoH8LEw/hxOfR28/vmg hrSafRbuG4gVPWicSKG5GQeKlutOtdR671iLVdU2m5ii9FDEMYWogQMqgBsFRhQfarudkTmgCsUt wgdRt5OTV1kY5HbHencl5Fc2cdtDH6UijJbtmm8qAKNpPA5PzWdhfrnC4q+8Bfr5/agwEk47/P2o zKithjgd81AFkRmA29u1EvbcTQoAGTJ/VntV32sNw9qDNMThdxLeyj3rQdyJYLpRhVmkuy3L57Co u5gzEoA3Ffj3qgrhyWRlYHkfaiSMyLnIBPtVDSBtrENwQeKd3BhePI4J96bplZRwG+aJfuoaNWCx Kfk8E0YONM1uHQpGmKBnZCoB9jUFqcXrO0oP1SHc2PbNSL2NnHMqXUhClSeOcH5pm0gDGOJTOQeB 7kUFun7GKXWYIrthFbyHl/iti+KvhBp/QugafqOldQx6o94BIbcclAahodCtLjom61VHWO9SRY2t 24O09yKi9V1/daW1pHm4jVcMWOcD4oIGy1fV7WWOSCRreeNgyHsAR71nFhLqHW0pfU7o6jrcw9KN 5myV/wCkfArFpLUXEjSZwoxgGkx3JtJiyOyt3BU4I/Y0BNX0a90e9ltr+MQzxnGAwIP+KNaGNgpl GSv6abpeJLdxNOj3ERzu3MST/enckttHOjxxmFFO7b34oHSJGmXmG+dgcfaoC9tQ9hJPIuyXf9J7 4qUbfMzzKrMGOQcdqV9KIoYZJ5INBIXl/ouo9MWFvBE9lqER/nySHcJP2+Kxt4cShEO5f9VP5mjT 6Ih+r5pvMpjkHI+wFBQQKoUDgHgn3om+OJgZR7jOKu0coUeoAQOeKVb2i3rsN+E+DQOi+nXoYWiS LKoySxyP3pi8TKSMcD3qXslit4ZIIhjacliP1VC3RYzM2NufYUFS+qwCjjnNPtb6i1TqGWBtQYN6 MYhRYxgKo7UxjnHt2PY0R7jYDkF+OSBQVFblWGB96KgKSu0gGxhggmhNcCZQigqPnNObeCC6AgmG zJ5kzQKHpQ5DrvjI4UGr2lxiO4EbvHGVwELcA0mK3tRd3cMTs8UWACfej6ZLp1qbsX1obvdHttl3 bdr/ADQM7CWOR/y0jlWapOLRAbaY21tLe3cY3hIwSNv9qjZdMks0QzKFkPOVOcCsn8PPE7UuhLfV bazijlW5JAaRAWGfipRi35qC9tjMh9Bv0MpHIIpujyW2QmME5JPOan+kejDrgur+9ujb2rzNJIVX 6lJOeBUz1z0BZaT01Fr+l3b6hYxyiGYyLhkJ+1IMFkBuDkDkfFCgnkMrJ+XfP+racf5p0t1bQyBm cBSMinx6svzCLVpwdOH6f5QAB/8AlVDIRXJO2AhGxyMUR5JYowrnL+4FJacnJVuTzn5q0fP1N/k0 C4bm2tpg4tBIyjs/Kmh3c9vdY9W3RRngIMbaf6dZLcSlByftTS5ktxE5Z0RwxUJIcE4oxS/4rcQ6 c9tasY4scKtTfSnh/qnWNg81ixNzEu9mU4K4qBWEoFlQHYw4OOKl9I6l1HRFddOumsjN9MrLzuFV i/6AvI743IXU5ZpZY8oZJGyRj2qyWaMwIU8dqPLK1z9M0hcjkN7k1IWWnT6jcCK3IV2Xg4pEhtYx T+rtQBfg1KPBcNG4Y8r3waY3FlNp8hSSbdKDgkUqOMOcSSsqyHBbNVNmotbdxJIzF2B7U4guYI4H YRHAOCzD3rOOl7Ppp1FncXTQStwHK/Rz8t7VjGp2n8Nl1LSo5YbpEuPVSaMhgR9j8UZ2aW9nea1P Hb6bF69w5G2Id2p7edMalbG4hv7V7K5g4eKQ5NB0q+n0W6jvrGX0dRi+pD3xTvVuptT16aXUrycv eTH6xjvRja/h/Zv1N1Na6TE0dtNLJsWa4H0qalfHS0vdE6mGiXk1tObNQBLZLtV/3rD7i+uDLbTN iGSF9yyRnBBo9xPfdR64E2te3M7KnqNzk+1Ge2TeGfi9rPhneTSaE6W73ERjkE4ypHzWVeC2g6j4 reIx6y1SSBNOSQveybcI+0+1a81eEdL3jaLqemP/ABVhkBBzjHsPerJ1F1J0zpg0fT1vNL064B3R yRbQ3zzTW0sZB4263ovW3ixqOoaFaxx6dbL+T2rj+Yw43AVUzXul9LR6Pe6hF/C1/mflAvOT2zUV pr9O6R0o8TaZM3U8k25bgElVH+qmerXc2sXQkmYbtgU8fFRvH12j9QvZtTMVm8jfklbCqPYU7vdD msFSCe19EBd4YjllPY1I6D03NrBuWgjV1tojNITxhR8U91rVZNVhiklPKRhE+4HYVpPSO6T0aLVT NbT6gtpFDE0qvKMqMf0gVPnqbT4fDCbp9bFpJppi/wCaHAP3rHNOsQIGbdtZ+CD8UYwCC5iBP0gc Cou0SsKsY48FsJyD7Y7VkcVxay6HHbRxFWH1F8+9MunoBHqU7SwNODGyKh+T2NF0dUsnkW8X1GHG wnHNUhpMfTIU8Ajv81eIrIhJ5OOwol6kV/eoHjCRD9KA9qtAkUIaNBtUHByeaiC9PzxaVrljqohF w1o+TbTcxuPcEU96q6kGu9RXGo2tjHZW8vCWcYwEHvUKFMYYrnk0K5R2BUTCOVxsTJ55qslyag0s qwugiweCPmsm8O+o4/D7rOPqO7sTqiPC1uYc993vWReJ/TvTnSPSWg2lva41y5hV55d2e471ru1A uLWJWBdxwOcVfQq/ik1HqW9uY4tqTztMkQP6AfajOrxvlB9UZHB7VZ4ngnG9SQBwVPNDYSiVowxW N+ST3qLF7qQzetcumWVM4FZpZaCyaDp8N20X5jVFZrcxjHphf9VYa8Q9ORFztkGC1P8Aprqd9Fu0 j1GI38ECEW+449Mn4qFRF1ZXNndFbkAOhwWHGR80iQeqR7nPFFuLxrrVWMjb9wzz2pEyk5yuH9gK tWETXTQRAOSEPHFI0u+EGowybSCjcZ4NNrxbm708taHE4mCJkcE1tzxO8OrrpDQOnJ77T4bEXlss hmjbJlcjJFIrXOt3jX9+X3l2YYOe9AuQ0wjiQEjaM8ZocQYoZ4YyUkyFc+4+1PbPUp9EaSWAgPMm x9y54/8AFQZHp+q2/h4dA13pqGW+1GVJEu0LZCmsc6k1686g1carqKO1wy+mEJ7fam8ckk0oeNyG buvan8egXdzpx1QCOWzjl9ORXbDg/YUnSGsVm62sk5/5h/SpPaj9NXtvaahNNeNt+kkDHY1mvg14 T2vir091TeXvUUWk3WlRmS2ilYK0wAyAB71rm3sry20+V9QgaKd2IjDjG5QcZFa103Qb3XprrVLq WG7uraxmOxoIXxG/ySKn7+10tLCyispjlVzMWPG74FNdJ0l4+m59TQwGONsGJmHq/wBlpjLYyXNi 93FFKUjYLKyjIUn5+KztkiYqrnkYB9qqPbMwEak//TTeP05bd27Bc/3rKl6Bk0rw6s+uZNUMtpPI YmslXJQ5wDRKgVlDs6A7XT2FCuFlEQkVSqE8sTTrRNBudannu9MQ3AT6pYxyTUbd3aSyFZNtuqkj azYyR7YooyB7wf8Apot2O5FEt4xpmoQPqMJmtd6s8SH9QB7UorPpluk9tKI0n905BFA3SSswaRpm P+1EZ54r+K2m+I0ukWunaMdD0vToRGsH+s/IrCLbV7m1iuIbaX0UkHKju1NZFTY2VOV++c1UsRhs jPBbySBhzKFyq/3orKfDKy0TUOoZT1VfXFjbohaGW2fayn96gOp7aBtauTa3cuoweoTFcytufb8Z qVk6Agl6XtL6PU7c3EqFpITJhk/YVjUFq9snpJJ9K8n7UWHLR73VI1y2O1PPyv8AD4jP6hjuV5AX uKtodlBqslzHJP8Alp0UtGxPfFJW35V2l3t2OeamlRc5N0cNkgncfnNSdzp1zc26MVUxAZxQ3jVH UBB9RAye1G1GOXTrpImn9VGGUKngVWTa30SF7bcZcSE/pHtS7+BbRQoOTj9RPNXL7HIB5+1XW6s4 0cXFl+ayMBt2Np+aBrYvF6gkcK7IQQG5BIOanOrusLjqb8pJcWkEUluBGBCuNy4xzUG1hHFD6sSl E7igBzIcueRQ2emWDBCLg/FDhYuDv5OfaqSANtbt96Mts/pyvEhfb+qhs5sdMiujcyPeRw+nEW2v /Uf9I+/3qOikFxFy+1V9qXwLaT6SZHXbj4pcEdnDZQr6Ze7YkOc/pHtRab28STyujvsi7E1OaF1b rnRdpe6bo2p5sb1dkiZ5T/4/FRkwtXjWKZzCn+tBz+9N3t7FD6OmXkt9O5CoGTDEk4xihT6/0m3s La1Z3EryqXZSM7Dn3qNa1hj2GKFFZuQdtbo0LoQdA+H+u3HXcMBvLvD2caOCUXHtWoPzKXKDYmAG IUn/AE1nfekJSBIgWJAf2Aq8ssJeP6iHHBwM01Z3ef3ArZXhHa2sEupG+t7eaC7hMMTzsBsf5rS7 YOkQeIMu0qM4z3pKWSlywyxUZwB2FKRYra/v7Mtl4JTkjtjPGPmjiVrVZWgIy4wc/NCGSBphufgg 9qeRTLDdRS7QWjYEL7HHsRVoiVi+oZY96GR9fAz8ke1FE1XW5dTumaSKKGM9ljXaM02sYDeTMpPI BNGNujo28AgHNONJMNpdF2IwYyNpPehs3XZCd6jn5FElZXYbxkH4oscYlLMOF9hSPS+oqeAP8UIa ySfl/Ud1zjip/q7o260PT9GnnkjnS9X1CI+SgxkZqH/UCD9eTj7U9t5pmgKu7SovADHO39qM02tI wpACkL7VIQyy2kqzW8jwTqTtkQ4YftQI4yuCDn7UWZdsYbG4fvRnYk63Mv8AOnLOz8l3OS1BVQrY 9/c06N+txbosCYdf1ZpqmJtxHfPNEEDYY4GR7UksDKEAO7/TV1iOCBkk+/xRFgnjlV1hyM8MaNaC M7Ss6FACKbW14sbSNnO3kKBmpLT9HTUtUjtLm6TTklOTNK2No+1ZJ4Ya/wBMdCdY6rDrlu2r6Nyk dwV4c/IqbGGjWRNCcRjeDkEjvQl1aG7l+sGOTHIp71Ne2N5ql5caHCVsZHYxBh+mtgWsXSWleD6z /lYtR6iuG/nMzYMf3qptr7So2lnbb9Y9iT3ot1MT9JwMHkCg2Mypa5MfpoexFONMSxvtTht767a1 glUgTKM4b2oqOhlwH+nOT/iloxYAKO9GNoItVubRX3iJiqv/AKh80ZNK/MXUcaTejErgSSDuAe9F MLksNwXOcc89qlugNZ0/pTXrfUdUskv7cBg0TgEc9qmfETTtD0iSxGlXJuoTAPUkbjdJ8msRt5LU 3MM00OYInVmQHuM80DjVru217qS6uoo1sbWR90cKrgAfFZP0V4m3Hh9fX66bbxkXkQhmkmXOVAxW Ta7q/h31tojCyhfS7+ED0Tt5fA96wWLp5LzRL6+lljijtcenHn65Se/FZENrAiu79pIsL6jFyqds n4pcYJUAk5xyT3xQJd1tM6xYynAogl3AM5zKeP7VUHZgvGcg0hbUPIdzlQfk9qH6qlljzlyfb2pW 8xNIj8sf6jVUcegoCiUOy+2O9DmAQHZ3POBQY3RGKMNzexFObYetuBGAKBMUM13IscSFm7sB7VLy 6YYrISuyhs7dmO1R0F5PZOzW7CN+2QM0X8+ZoSJJN0hOcGgBISpweAPYe9KZ9684G33pAG6QsFyM f2o9jYrcpLlsMD2J4oABs4yMf+aTsySxBNFeB4JAsi8e2OaKouGhOwp6Q7fNDaHvJyZVjILkf0ry akGDyrHHcvIFTkBj2pelSHRdVN9sWZmTBUjIH3qtc1B9Y1AOm2Mf1YHApJpdMx6N6v6VaM2WvaU7 sjYW5jOOPv8ANRPUkOj2uoz/AMNRmtjzGCeeaxy70caZbR3RDbJG+hvZv2o1sr3Ns85cqw42H3rO qgUcUgx63H96NhQNrHKn3FNpNxbJBYn70aNd0bI6/URxW5F0k+m3kkvZIQxAPPAzx+1O4+l9Z1XT 7rWbKwe7sIZTFJMrgbMe5FMNG1K56f1Fbq3IEqoUKsM5Botr1Lfacl7HazPDb3hJmhz9Lf2qG0Ss ZeZ1I79zSJYMhinJ+KJAT6zyNwDS23DBx9PfNFMlkjjmVWlMbnjbjk1K6fov52N5Fn5j+oL81MdD 9QdO6RqN23UOmC9Ypi0mHZT75plc3dut3cT2oCxyvlFB7D4oIYKI7qVjvO4YJJ4p3pssMq+nuyoU jd8GnCbbljmNT9jQmJUKkcABPGF7k0ZAki/JMuGMgJ4NJuQWQMFYnPtRnGzIZSrjgq3saGUZkGH4 FAi1ka0uPqByP0kmn0GrGxSUtGCJPf4q2jwRXV8Irkb1IwufmgaxE1pdPEy7lj/SBzRdAQ2zl2uo 24c/Upq88eRwpA+RSxHI1oJorS4dQMM8aEqv71USO8ZBYMvvmou0nPoH5bSIL/8AOpKv9UDDlaiH VVkaRXLBwML8UqRZZEWMOSnxT630y0Gjy3Et6I79ThbU9mFVnaMjYIxHye5ojSgFlYbQPeg7WUg4 BJ5wDSZwxXe36vtRdjwSpHOGlAZfalyiQzHYeSMjFM4VKW0hnBHH8tT71bTrgyRys7ESqNgpFXmj eQr6jlf2NKSP0lJGWNDijYIzSKJHOcEntRI43WIFuD74NBUk26FVXAYn3oks+pXgFsbgSWo/TGKQ 1nLOAy7SvtzzVpFe0435Y9wPagZNYSW0gYsy5PJBpSEQu0rZkYDAzTqdXkSN8jb7ikrCryZC5z7V VD9MSKpY4JGaEzEORtxRrOB7m9az/wDcmYLGW4FTWvdD6n0tcwwaoYzLKu5AhzxURj8d3JCwKbh/ 8acDUZwjRldqH7UaaNYAuzBzR7eyN2gLOgJ/1HFBF4lkOGJPwSe1FliRgDOGyBgYNO5bRrfHqFcZ /pprsRjIwdmdeyEcVQxhtrcymQKGZe2/kj9qLG80E/qxSgZ/p+Ks4QH6kIJ9xV5IfTBKtlvirA8m uLi+lV53MzION3OKZD/7X3i3MDlS5w4T2H/0VZ5XsoQ7PuZu4HNUhEkW9QRnkhuKmha+na4uvRiA Mk30ZbnGfeuiNA8uXSuj+Gkd3Jqs9zrFwvqFDKCB9q52kthMFkXKyLjkHtUzo/WmsaTBLD682wna q53DH2qBPWGjJpGstaWjMY4gDnPOajVbbudyS7DndT7+Gap1Mz3tjFJP6ZzI+OB80O6ga2t2WSUS N8Y7VbP6DOKTMZGOSewpKxljkrg/FWQbE+rgjkU5ik5znFAWyS1hkQXkbyQE/WsZwQPtUheW2mpk aczCEjKo5y2aiCykkHhc9/mmzPm5GyQK4/SucZNaE5baLqDWJvEtHNnu9Mze274q6ynZ9R5HFSei 9Z3Wm6cNLuEWe2kbeVJ/S3zUTckXN03opgE8VNos8xKgZyc0KMGWY5yD9qI0JjP1jkd6cKFTY0B3 N71V0TAjmPEZ96TcJM6hHc7wcjFHDLEfpAx70kBXJZifs1GTm0v5fyiwyYlIOCT7UiaNGb6CGH2o fphR8BqLZWkVzdJHKSsfyDQISKMyKsikj32nFSmm9PXurCVLGD1yi7j9QBC/NM7+2W3uWVGyo9/m gQXtxY3PrQSvDIV2ttbuvxRCb3S7m1WVpmAKkAKP96CouFIaIEKozn5qbk1ezv4lhS39Fj+rJzuP zTSYBUYLRTedILx457pXdwOEQ4UffFN9RV1ijaORwAcqpPantvbSOS5H0Jyxp0YYWj3rgqexPtSd M2SnGl6fDdaM8shDXB9j/wB6d6D0pBf2srSalBaSpyI3HLVFWcLxzEBj9Qxj4o+oi2toY3M6JJ2d 3baBSk66NdQs/SvQu4be2fmgwPNFfGGQBsDIxxU/03qGg2sNy+tu7OyYtTD9QDfOaj7qNJZTNGMA 9v2rDRtBcBV9UoJGz+hhmgyy+spYxBSc9vapjQrqzsHuVuovVZlyrfFM7lraU5Q7cHOMYoiL9KeM 74JDHn9Qz3qRWVpLYruO445FIkRQAcAqaUgVCPUACj3FFSD6SbuAGKJ3mIwFB/UaqfpbWdI9D87p c1kX+pfU7EUiDUZ4SJLacRSxEOh+4rJ9d8YtW6q063tb+OPNsAC2OXNT7aYReK1jmOSNkY+5poiC ZT7KO+BUhrGvm+KxiBTj+rNNo78RABYgSeCPtVIafw95CNq7489qvMFgwroGI4A+Kcmb8uzygEbu Ao7CmgiEshXuSd22pXTE0kJbP08fIoe0tg8ADsKl59NmhCFoJIQ3YuuAajbiL0/qUHcaj040N2jH JG6pfonpHQOqXur3Wtf/AINPEwS1jJ4fPzUDLknd29sUwZAgUKCDnIPwfmjVT+vaNZ6Rez21o5lK PhpGP6vuKijb+nyGzxzzQfUYgmRmdiP1H3ocjvLFtXjHvnvQgtxDG8anfhxztFNY4yAcDNDBwfVY lscbaNHMrR71Hp47g96KqSMbfpYrnvTaJ2t5gyL9HuMU4ySwxnafbFOTqK2hWFYd7y8ZxwKBUETu jbEEiN/S1VLbyLtygRF5Cih3crQbYYmBQdyD/mlRTjAPJ+cmpRd5U3iVslh2HtQEvbe4ZoZ3Klvj 2pw21YzlQwb+ontRra40sR7Zoi03scd/71QyVI/qjUsYwP1GiL6oUBGzgYA+BTm6SIwAJwmeCKbA DODkbff5qBalv3q+4qxO49qQDzjHFV6hQDauf3oyppGYYkXA+RRrBkWURS59AncT80B3Zidwx8Un 0/WTbuIA96aa0ym61RPoW3bZGBnavvUVLJ+YYsTk/emMWVAQkKfkmnBbdkKd/wC1VIa3EcRfliM/ 6aLa6oluuyNzlcc55qprf1QN3+1WtrW3spleSJpc9gOcVmqLcmTUVe5y2GPJzU1NqFtb6LHaqiso GZGA5qInmjQZRSq9ytNWnKvuAJVxgrTbIojjuGK2wPpjuc0NoyzE44HHNJg2qhRRsBOTg0t5G27Q Pp+aRrS3pD6eKLEpVyQcEe9XiTgEk1fAUjb9RNNCbutYtbq1jWSM+rGP1fNQfqb7gORiNTyPmlz2 yxqGjmMjf6GGKFChUFmOc9waRlezeaLVJJ4iUt+MqD3qRv7xLgK0ancWA4/71FyIA2VyARzil21x +QkWX9S55DU100TII5t8byGORf6ge9T3SPiJc9JW01ktvHcW8pyxlXOP2q15pdrqNuk8ACsRng1E y6eYiUOWBqMnOr6tHqt+1xFGke45IUYANNGeORvqyp/1D3pq0BQMF4+KtIpMa8gKO5zWtC8qL6mA 2R80i3mW4uzCAfsaIgYAbQDH8ihHNpOZV5c9se1UGu4FjYEghx7mo8TFZSTkfIqTsZptQvUDqPSx gk1J6n0okMXqG6WXdyMdxU7EPBqiW649JG9xuGacyavFdRoX2+pjGBTFbD0WaOR9yg4DGkyWqqdy jke9UEdBIp35y3emrwlWwORnmlSDaq7nZGz7UpZDK2Qu5AOD81NAeGRdqgY96C8kiBiQPTHc4p6u GkJK4Pz70qW2EkDR8BG71REZ3ru2HIPFZH0rdWj3SW1/aNNDKcCVe6Uws4d0XpjGF4wfenAjNtMd p2REZOPY0GRavotpZSSwxH1oe6tmoGSzimb8sZFt0Y4yRkD74oTao0Q9NmZgexNBOoLGxfZvb3ND bJb3pPTdL02BoNTS6kbl0XiseuI1hmJQcDjig2226mMigpjnvVrqKd2PpJkAcZPei7LLsVxJsOeR gYpSI06h9v8ALXuM0iGKQn+aqhMbifg/FJcYb6WIBGSPmiCFEc4AzHVbP5YAXnPFXT1JF+gbBirB GTAbJOaBBicsc8DvxSy7HC8kYp4doOeD7VZtoUhVw3tQMoo8sSxIP/apKGNtilefmmLJPFJkqCpP Jp7a3AUEE454FGipIyG5G3NWWMjvkH5BpVzKdwx71RkCjuNxHYGgPLfMsCgj6V+O9O01oFEU9scC oyWNjGSTkkckUziJbCu3KnOaCVmuTM250K4OACaH3J3cEHiges0ibiMhe33oVx6ksgIBxjnFA7Zk GGHcd6vaDduf70CBHJ5QkDvn3p7E6CIhBhvcCgB6bFmAG4lsjFXltnQkEcUvdtI5x96p5Rkc9/mi bCAC8MO44pBV/QmLDsMg0pmARvc+xpErMLSNWbO4n+9Zy9VZ7dF+S3TUvetIpZV49Bif/lnivSMs segoMfpUc1wL5C9KSbV7ud+6ccjtXfN/JGuhpGP1Fu32r5HDN8lfSys8GHaj2JxnNYZeRRnUOFLM xxgfvWc6pKq27koCaw8uGvlJXDZH/evuXXi+Nl/JuDSCINAWMR/ytnepkPBD0zgjAKYJqFguAugr CDgKBUtqCovTiDPO3k1y47vLp1svi0v1e6COXnI965y8SQPRkb3rfvVsgDz5P088Vzt4kXBaOQA1 96XWEfB5sbcrtzX1jKyzyDuSTWGuM7sE5HxWSdcTPHdsw/Tk5NYrausjSMhO0/NfO5rt6vx8fEqJ UIzuPf5o5wnvmkMFQY2596SZA54GMV5tPorvHuJIySfmkNBInOCB70RGA5bt80RpFYkAkg+1E2bS RA5wcZFAWIOHcMC6dl+acyKQDzgYpusWCjLkHPJ+aK2x4FmOW4laQ+iQcZrP9eC/mGVGyucg1hvg 7ZtL6xnQQIf+Wfn71l2vL6U2AwYDjj5r6fBjdPHyOt44yrZYrn7UcurHHxTcrtPHPxmlAtkH3o5q ZwSf/NCK5BO6lH6mOaTIChUAcGguyAkEdqIq5zg5xSXQqVCjA9xSUJTPuCaBYcYq/qHcAPeqXt8U kROWVh2zQFJxu+9AkmGTxkDtS5Po4J5oTL7CgVE5c5AxRt5Ye2Kske1d2eaonJ4+kUCGfa/arm4c bhjiq2nnP71TEAA5oEctyRn7UMBZGLAZ9jRzJj9PekC6MIOUDfsKBZjCoAeDQwdqOAeKGbhpk3nj BwRQyzYHPBqi2wZPx80O4VWtyo5bNElfCtjvTV5yFULyfnFagrGxMbu/tSGtl2buA3fBpO8gkH6j V55GcYI/vWlNZSA+5x29xQ3Lu27uvcfelMrSADOB8VeKP9XOftWVgUYMYO4gE9hVCRiuSdyinD7R yRyBQmjUrkHAPtQGS5MiKUO1h8UGRjK+4tg/JpEeNuc4NE9MP37fNFXUYQEsCfilrNtx9CnHbNAe IA4Un7UsnCqD3FBdhvPbB+1IClScjilBgCKpxul5PB9qAcjAY7ftSJCpPGQCKqUshxjPvVonJk7Y HxiiKKIqjGcikT3JQNtxnFGgALktznsDUtpGgWuoTSLcSGJduVIHvUEEkrQopn4DdqLs4dsEE9hV 9Vtf4VJ6coL4b6M80IzMsY4PPGcVSGV0ziNl3FSfcVHXsaxopZicDmnt6CIzglc9jTbUpEfT4/5e XUYL571zsaiAb6yxUAqKynpTBB+4yBWFy+paq2Dkt7Vl3Qrb4jg7pV4OfauHJ6anU22V0woa6jYn lewrqvoRg3QtxFngkKf71yx02h/PxRgfSff711L4Yj1+lrtcd5FGP7187kvT6WN/xx40+MludP8A HXri1g5ZNRk2Z/c1iMkgz9QIJ/Uw+a2B4+x+h5iuu4cbSt9Iw/yawNtpjkBPv7CuuM+Mea3dAhcE nauMfNBkOW/Tzn2o3qoy4U4x3pDbSQc8ewrUTYEr5IHt7iiShmII+nAxVECMMWXINW5kGM4FaQFh tZItzPgcEmghGRyMYp5FGuSp7jkGlOyMvyTwMCimQXOMk7u/2qkcbSCOfmnGCrBiOcfpNJB3MqEY +cUQj1dkACkh/ekgGQAA4Y+xos8WGwO9JW2ldSE+k/PuKCsNAw9TIarFv9PJpxFakoA5LfcinEcC htuM8d6kDO2dieDhvtUrDEX+oLlj702sLb/1TAr9IqfitPThRmbAbtXXGdOedItYjEoJweewqTic yEHaMU2WASFdvNS8FgyuuV5+a7THbhctQuKH6AG7+xFPLaASJ9R249qutqMqCDipC2tAzgAYArtj NPDnltUMG1VAPIOMj4qRhU2qYjX1SxoltZhF+oZOOKeqyxgAKB9xXTTgBNC4ClfpJ70pQFUkcY+P enTplRt+r5zTO43xAMBujzzVTpHag+G471HhCVYA8+5qWkjWRi36vgUzmgcfpGOOfvUrWKB1FViK lHP/AFH5plIu8EDJ4zzUze2uTkAYPcU0NvjIx/cVyynT0yoJo3ik4BRfehsB6hAHFSMke2UMSWx3 BqNnLhnjHAri6GsxBkwBk/IoUkTLECMnJ5IoxtpHG1eCO5paw7wqjP09/vRKGsm1Qo/SO5NPI2jQ BgMgDgGmWoWN3G4aOFjG3fFUJHCICOfiqnSQDAkNkAH+mrLNgn7fPtTQFtrc8+1FhU8E8571UOBM MnJzx2ookCrwaZqNx44HscU4AIX6sHNEOAwP70GQ5Yhjn9qG9z6W1Qhdj8URIZMkMhU470IEHy4B pU54VVGeatMnpqDSQ7FS44Kc1ZWoVd2E9vDFLJC0CSZ9Msc7qbwY3DcSPvVXOoT6g4eVmYJwoJ4F D+oAknk+xptdHDBMtjkVaO1e6DFMEDjFNpp9iYBxSLe5kQblJUA5796ztdG7q6ztGBjBwc1fDuOF 70m6k9SZnzljyf3pdpdTpPFEEVVP9ZqRChBghz3Xtmk3MV1pwUzgN6nK5pWp3DQ3IhwNzdsdqZpH dK+GSW7B9kyxFWBe70dozuDjJP8Apq28bjlvpNBvnnt4yGhuLVSPpM8JUN9gTQVn9VVG3aAO/wA0 PtItIqxCIOAp9j7UqONi31MCvxUbsaVgdpB9qcRs4T3Y1lT83IiXI/xSBeGcEEbT81VpFHcH6iMY 9zTuOGwt43MsxDDtgZzQR1w5U5Pv2NRk8ZlkPB5qXkeOUAA5x2BptKGVgFHBosRC2QRxlc0d0ULt K4zT5oi2H3DcPbFM5ldzlj24FZ03sFYwUYAYoBtVIBJx9xTlf1/p3GnkFt6ozxn3FTRsyhtUUksu 4H3FEW3ZG3I20+1ScWmuw+kf5pP5FwWz3+MVrS+yfzdxdRpFKqFQP1DvS9KSEXJ9ZGYL2UdqkLTT 92MrxinX8NCgsFI+9VPRhLGlzIxji9JT2HzVC2KuEAw2KKYmVjjg/wDai/8AKQ7zuPsazY1KbmP0 SqE5YjtTdyFlaqub/wBNCwUNID3qPkvpZMHAU1mxuZJu0vljC7hxn3rJ5eobbU7WJJn3NHwh+K11 +Y3nOePjNSNgWyCornY6z0yjVtVS7RIYxgL3YdzWPyxhpCxGSKfDG05GT74ptcR7XBXkYoSAqfpY Be/vSH3YwG7UoE4xyQaHMdrYXjHzWHWGkts2TJnOeMGmrRoqkHkfFPpW+jdu3NUfJ6jNwQAa5326 yLLIkTptYrtOcVKw9R6FpAW5u7Fr2QHdsI4NY/MSuWYgkcfvTG8cuo44x2rUiUjqPU/47fS34RLa Nj/KgiGFVfbioaPSri4QXRkAz2jPelSu4bJ55/xTWa/ZS2wkFfg1aKvCVwWwpAptvDSY34+9JaT8 wvqk/Xu5qygBM4Az3NXSdCNsGS3JPaqghaMZY96EsiPuwN+OBj2NEj3l1DfUtSofxYjOc5OPanRm UYOPbvTaHJwNoXPFHeFhGRms1uReKMb2LEAU7tVlETqQGGcqftQAFEaEjJNOLchWOCcH2+Ky0fTZ LhkP8vAzinlmVmA2HC9jimQYkYQckU7siFQEAbvmukc7/aXiEcf/ADWYqeAKkLcGJsDkA5qNgbci g8n7CpOBtoUbc57mtRqn3MhXDZHxT23gRQxbjjt80wSQoR9IwPijp6lyuMYOeDRgq8jjZcAjGOcV ET3djGyrM7RLnCv7E1KSWsig7+fb96jbq09VEXaoGc4IzzSeg0laK4kaNtwQnKslMLhBvKJnb81J Ono9147UARtPMI4QAH4yewpfQiY1MEuGUOmeT8U71EWcKqII/rPOR7UvULX+DK0SzCXJ+ogZzUU7 b35krC7IupGu0Blcvgf1e1RE0Ycsp7+1TVyhjgZlwSB2qAdXwzlWGeRmiESIgAwvPvVv4i0EbBI1 YEYAYUlpN0WScNnHagAD1Dg5A7UbJ9L1bfc2N+c4ottrC2UTRtEHPxVlG85/Q3zmgH/mEhMknvQE vepNW12KO1vL24ntlOFikb6UHwKby2tuHVYQMD49hTnUJd9pGkagEEZZe5pDSggttAyOeMVBe21G dUG7gq2FI9qve3Mt1I0rncxHJ9qBFtVdvcE9qI22DHqRF/2NUCkuJpYUjBzzxV0tmZg27+b71aNT 6xcD6fYH2pRkOzG3DH3BoLQyhZXUk5X29jUiusGCH00RDxySOai5YtxGOw5I+aGSHjOByTUDi4mW RP5aAk8n96ZLcSmUbgML2PuKdQILpcY2bPv3pM0IimLH6SR3p2Em+UABm4x/vR/Vyg5OT7GraXND bSt6sImUjADex+avNKZ3b6Qq54HxU2BgXDsWiZREPn5oMlteS3UUBkx+YwnqR8YpwCBGVJAFN77U 5LOe2CoxiUhg4Gec5qxdt/Q6JbeB/hhaa3DbfxTqe+G5YpV3HZ/q/atHXPUV51Hfz6legRySvn0l GAv7Vn+u+Nms6903DYi3hZ0jEYnYAsq4wQPitbFJCvqOPvtUVq9s+xlv5oXdoJjEx+KSHur+RVVf UdjjC+9N/VkdVkEREXwRzTizuCXJjzG/sOxFRRdUtjaQOkoaOdB+mslvPD3UNI8PbLqiS8i/LXB2 pEp+tf3rEdUe4uJy9xJ9QXApzL1BqV7oMWlTXTS2ka4jh9hUqVVrbtbROHcu8g3ZPOauEBi5baRw MVb1ALaGONCrou3J7kfFW9PYoJP7g1VJc7VGCWptcKZCBuKvnINPVHZs5HxSrkx42bQwPY/BoMn8 N+qLHoHrDS9XvX9RInDSqPYfNbG678Lrrxa64vOq9K1G2j0bUEXM10clCPYfFaFNoTxMuS36TWQ6 X1HqWlaO9pb6hLb25yDGDx/ajPhu7ZF1N5eOsdP1O0gsrWPUrKXBa6tv0496L1t5fJfDXpt+oDqc E119JNnvBkyfbvTbSvMB1XoGkfwWLUmuLd1Kxsw5QfGawTWZ7zW738zqFxcvLnd9UxKk/tQ0PuaU A3IbDAEA9qIrKRtA4HalXMcjWUErqDu4XmhQRtscn570aXE4jypXNFkST0xIXHJ4UU12lwcdqMPT JVsndigS+6Q8gKfmhHIJBGRRZZfVUEnbt7YqyMDkngYzzU0BjLZbaFPwaV6ihce1KO14z+x7Ui7W VtNid0AKHGR3NNBPqRo/fGfiizosibpGHAxgVOdC9B6v15K8GiRxXF5H9RSRgvH96adSaDd9Na1c aXqfpi9hOHWJsgGmhEQwyMuCRtFSGjaImv6rplnuaJri4WJ5F4KoTy1M3kCZAP0/NBstUutM1EzW 0m1gMDimhmPj34c2Phf1xaaP07qr6taPbrLLK7hm3e4zWEzbBKjD6hj9PvmkyxX91dtcu7Hc29yz 7y32pXogz++8c00lGhsP4ikkgdYJV4Af+o1OdJwy6BZ6lc3tpb6gJ02QpcDd6R+RWP3EP5hlydpQ 54OM0yS7uFuGf1HPOACciqyBfYe8SNc+ozf3/apvQNEv7LV45tLtxdajJ9KWsmPrqJaU/mhc8LIv Y4p5bXV7FqMV/HOfWByHVsFfvQZj1/4P9UdI9KxdWa9PbW6zuEawgOCue2RWtbXTp5vUkiyqVkfV HVnU/UuntZ3motd2BYEo7HII7GpDpa90vStLukubP8/JPF6QUtjYf9VF0jdJvZtCs5oxbQ30zrge qM96ghKZ2ZpIzGd2CnxUq8a5JUkn4+KZzQuckjHPb5ohMUe0Aq3ApwZht2su8njP2pEERckAYGOK tDEXZsf09yaA0c87IERiqDslIaeRm2OMH3NObdRCQTwabvIru4PAPvQCaQLMByW9qPJbyNbs+0Ar 7mmtkjy3UcUb7d7hASMnJOK2T4yeBPVvhB0po+salq1tqGn6kFZI4iN6Z7UGurSRgmHYl/fFXl5K 7SY8d/vS/wAvKiL6igEL7e9ViRsjZ9P+r4oCLOywtuyT7EU4sbaIMkxbcM8o1NnmNrCrsA5HtSbP UWln5ixntigc3kVvJdNLHGYo2OQoHApuYSZAFBCHsfmn89wpIyoJ9qaRTKl6Gk+qLPKfNBY2npfS cA5yKsMxzMCNwxyoqa1+z05bLT7vS4ngLqfzKs276vmotl9MEEc45b5oFn8sqRy2/wBDP+tWqo1E kp4yMZH70xd42b3Bpe4x7Tk7fegkpwrREk5NQs05tLpGIwoOePepGNHmbAPB9qb3tgHIUAnHaotZ F0qsMOj6xqpnla4CgQ2qn6CT9qnND6ihPQur6VqSkNcyCVBngfate2xvbNiqybUc/Uo7Uu9uJ7mN Q7YQURFG3iErJt3ckAfArZmi9YaJ074aajoS2Nve6pfHma4XPpD/AKfvWuI4DLOM8A8ZqcTRdMFs ZJbxo5QRhAmRVSoyGMQwwxA70QdzT5SsafUoEYPc0ia2jiciPJX2+9S/TFjpsmowtq5Y6epzIi92 HxRLekZDO9hDJcWykszcPjgVsnwm1bo/p+W/n6v0yLVllQNESuSh96Y3v8KvtdMGnxC20R12IrDl W/eoCXTUgvXhTEsCn6XYZrU6cblaB1trVtrmvTz6Xaiz0kt/IhAxtFE6a0O21PcbuX8vEoJ3ff2o 02lZQyk8DjaKq1iYApjK8YFElMobFvVYHOQxwP27VKaek9ujyq/p7OcjvSxGd/1A59zRGI/Lsvs3 fNEuRk2ZZQ7HLNzk+9WilNxE0H0tEr54HINTnRPRmp9c9R2Oi6WNs11km4IysajvWXv4LHQ/FG36 O1HWkgF0uRqgUEKfjFIxtiOka1baLpF7bTWS3Mk6lR6gyBn3rGtKtxAyhVVdowD7Vk3iD0o/RHWW qdPjUBq62m0reKuBJn7Uz0KKzW+ga+QvZg5lUHkiiGh2vcBwgB7EinLW2YGnYYTdt2inDpbJeztC CkBYmJT7LSGJdBHnCZ7UNo14LeUFiMBeSDV7KW4skjurIsJA4ZSO4x808m0wSglRufsADwaf9JdR WfSN9dJq52mW3eOEBNw3HtVgyzR/GcgJJq2iWmoanD9KXkiZdR7YNYr1F1vq3WN2h1VlWKIsIViG AAfmogRSQwrMLdpUY5OD+mnEmnz2tpZXEgG26yVGe2Pn4q27Q2AMcoWS4KxqP80+E1mIAqIWYdi3 cmkyMtrbO8lpNMzYVD6Z9Msflu1ZHrGg3vQ1/oLXtrFHcunrGNSGGDyM1ldobTuoprC5e2KGBHXZ LkY4+DVanNHcyB7MD0UGD96d6peHqXVpTcqkMr85VQBUUY3tJPSTmIHkj3ohUZM8W4OFOezUuRDu BLBj371LdNrpNzq8UWo24ms5EIK79uD85q/WGn6Jp+uxLoIZLcqPUVn3c/NF0gTNNbMZIZW3fJqZ vtRs7jp2MLb/AP22LZknx9JX4/emo2Wk7NuDq3YYzTaIR7br8y5iB5XbRk2toDeSIrHbn+r4qSj0 S4Rn/KQtqEKt/NZVJI/vUZYRi8iniBbO36WH+5rP9K8YJ9B8MJOl7G3iW7MnN00YL7P371Yu9MIF obwXbW6Ni35m/wD0dS3h9oOn9ReK3TX59sadFIDOCeGFN+mr4HR9aCuIWmUCWRud1Q2hF9PuA8M7 LPE+Y5T7mk6ZvcZN4r6wdZ8X9SgZSlvE7Q28QGAsS/pIqEgV7efBTcA2ePisg1jWLfr3r7T31AJp 4MKwzTqMDIHLGo7W9MHTGtXVpa3y6nZlsxyr7VL2smkffRSS3UkkbkkjOF9qESWYM31Ee9P7WwTU LuONJ/yqSHDuedtX1PSBo85iWcXSD+scZq9LDKWTdCI1P07t3HejQaCdRE863CIkABdG/qpoXUEE fSDS9s0m4xPgEfUCcBqjQd2Eh9ELESc8ug9qeXOkxi1WdLtXZv6R3X96cabrFz07IlzBFFdOw2mF wCBUXfxXl21xqEdqsUAO6QK3Ck/aqh5qKJo/TVteWrI88dwrFW5B/tWVeJvjZe+L9h0zpU0CwR6S PqZRweKw+JohpzRzREliDg9hTaOBbVHVBtLDj5FEOZ9RZtPt7UKqrb7sADk5pnJKZgC/9x81TA7A WI3/AGq4VWXcScj2qNKth6cu5Vzijz3cjIys7KpO4xg/ST80AyemQB2H9QomSzh85yPjvQM445Le 5FxBO0ZbuqnHNPbnUbu9kja7mNxsTagY9h8CkTwlULn6M9mxShCEjVtw9T4HOaoCo9ImYLucY4Ht Ur051NqejWOtaegtnsNVYPIsg+tMfBpnCgBmYgDcOOabBiFasaFntY0RYU+lV9/mqe4ubazktBdy tbAZW1z/AC8/tSBkuDnOKvJwQCN+fatIR0nqeq6VJO1uXs/VG1yncisw8H7zSejuu213q7Q/4906 qsNjAN9Te9QEY/LRmTJ2heTTF57u4sisbtJHuyEJxn71NKe9YahY6v1Nq11pcP5PSZLgyWtse0Sf 6RUbBKV+pPpY8ZobevOvosgU+/2q0UJQ4zu2mk6QuTlHULnI5xWTv1ZJZeHD9NW1om6V98twR9WM 5wKxyFjk8ZI7ilbtx284PcVVRs17bOIU2qr8Bz71mtl0ZFqegXOpW9zGi26ZeJ/1GsZfRbeaQyel vI5ZRT2SdYWEUTMsO3BUNgftQRUe13DrlCOB+1O7EI5MWTlj3PtSGX1WJOAM+1Bmcr/LTgg/q96G 05YaLc6vFNDbW73Dw5aQr2UfNRM4VyipyV4FOLHqG+0gbbG9/LPIpSQ45YYxTrQtLsLr1DcaobZl BO0Lu3UEaY8ZLfTn3osDLDj6dynvke1G1MQK223cyAd8jFAku3/IrGihZVX6TQGtND1HV702thbP eFzuWNTg1GahZmyujDJBLBMrbXRvY1M6N1He6S1vPFIY5oiCJF4I+1Oeo+qB1JfPdPAIPUwHQDPP zT7EIjhFwQMD2o4u1AkSGTCvjOD8UH6F3ssDSovJB4zTiebTtQjibTbN7SXH8yIHczY7kChoIT+l IZWxj4q0N7arcMqxmSSTufakSSxkiJMmTttYc03hWC0v4prtXjsxIolZR/Tn6qBc8LyagC2EhVSF 5ySaLZ5sb1biFFSWMgq5HINbb8Uuj/DR9B07VPDy+uPzJUJOs2SGJHOM1qoafPNdG1Z1M/fLcDFB bqnUtV6qvknu9RmuCoGY2b6FH7fNBt0V4hxyoxmp7V/DbqHSNEttcFtDJpVxw0iyA7aidPRWLcce 1ACGJZZ2C9vcmpRkVbcxJKSrc4zQLeBFlk39sEj4pMSvNCfUJicduO9ACGyEUkjHLFu+aW2YhgkD J7UWx0651S9gtraVIpJP/ckOAoHc0q4tGsLi4iaQXao+EmHGRRYCuXG3J/cVSN6YK9yOSKd20iFQ CuN3vQTD/wCpY42g8ZHxRdhhtyZxxU2LCxitYXnUtIw9u4qNCkRlFTCn3p1cXYu4ljlUwsnCkf10 ZIuVjhGYThOwzTdU9Qksd2aU++VtjABVq0TbP0ihCBA6nPZPin9lNbQrIs3Yj2pubpEAMo3KO+Kl bzQbmy9M3dm9ssqB42deGU/FGb2YmRNwEYwhPAbmryTfUAMFBwRSEKQyAtyM4FLuFC/zAuE7/wB6 Ikn6N1j8ol8lsy2jjO9T3FR8VsLWNgM5J9zzT2LqS7mshE8kkar9KgOcf4qJNyzSlmOTnt80a0kN Kt3vo7gq2ZIyMIO5pa9QahZx/k2ghEAbfuYfUD8ZpPT1/d6FqrXogD5Qp6bdufemk0c10ZZJWLep JntwPtTam99crrGr2M19FvtEmRZFTghM4Y/4ra3XvXnS/wCQ/gfTmkwrp6RiNZ5V+snH6ga1RdQG KeCJTgHvg0UQtwAP0nORU6DSctGHiizgj3p7bdO3LaQt008Ygl42f1GmzuJ5fSXPqYPNSEV5K+lC 1LbTF9KmqBLIrJHC3Aj9qFcQxypkZ3Z4x7U5ngMOnJKSGkzyfmgGX6lwO4oFWbPDMZVX1HAwxPvT yW+tpVLW+UlfG5fn5plFPJFuU/QzjAHzUn0X01/xb1zpVja3i2SkM7yycrke1EoF30Xrt6sFxdaf NbaVvzJOx4K/IphrPoWupIlsrFCAo29gK311DbXMnSmvCw1iO8FghiurX/SB7qK0QsLvEvIKsARU 7SX+1LbpZXHqSsHkHKAUu4uFkcySMI/fcf3oF5cwxPGJHCAL+o0S1WK9hYyASxAglScbh3q6ahSG 3lUtHIJucFgKq2xDdEyIJAeBj2rJOqb7pu6g086FZmxSKHbcRn3f/wA1jIPqNuX6QexoHFhDp8mp tby+osUpz6i9xTrVbSyt2aK3ZiqnG9zkmotI29fKjgc5o53Ptyc5OaCQ0Ox0thcm/af1kXMHonGD /wBVMIblZbh40OwAZ3n3pUdtIjM2ThuMj2qorBY98jAg+1BTxKpOGDEjuKVHHG0ZyoDjsatIMkED C49qGrZON205oKcsFwhOT7VJCSH+Ho0cEscycTOx+kn7UxLY5yByBk/FSGp3f5H1tNixNDKVb1M9 jQR4uT6m5vqX2NGgjEgcsCAf04oUcI4Gc44yKdRkrHjPAoI+VXTdErfS/dvirKI40CldwI2lhRZB ulJbkfFG038ubUCU7WYnH3+KG0jc9QNqemWem3EUQtbP/llRyf3oEksLlVQYA74pF/07eaa9qbm3 eJbhfUjLDG5KTfxRWjxpECoIyxzTRsylGSxRwTnkU5is2kiE3qLxxSRsbAWPd9/mr3EnpQKowvP6 aGyhblcMeZPk+9CucKMEYPxR4JEliPqvtKdlHc1eSGL0TukLs3tjtQMZmFjblpRuwMgfNSc+k2sm g298l9HJPP8A/wAqnDIPvTNQTIUlIKgcEjNW2rgrjscZXjihsxkWUsyKMxcYBp7demxgW3H1BMy/ vV0ATgDFJWMLI742s/fFF2svqd1IJ+1WU3drKsiMMZyD7g0SPbEcNwtP4YFaAyMwYHsueaHRmT6z kyktK36nNKdUiUhWD57tVpUK5Gwp+/egspjXaDnPsakNC2sgSTcPY96XeN+Zk3EksfjvQfRdkKou 5j8UqKVoJQkg9NgOMc1V2caL1Rq/TNre2MBVrK9+l1kGSP2qO9RjwQFxxgfFTOlxw6tc+jNMsUn9 DN70bqLTobIRwxqrTjuynNZ2ygZGJGc4b2q7WaagEnLDMf8AipbVOnLfTNBhv5r6N7uZgFtAwyB8 n4qGMDJCuJMDOfTx3rQyHWE0VLGyOkb/AMy4HqLOc7TTa66euCiCSWPDjIKe1RW4nAxx7kUtriSP au9tp7jOaDI18OY7lI1HUVi87EKqHuCfapjXPAq/6L0aS/1K+t3TbvxCw5rW1na7LiVxIwB+/IqT /it/daebW4v5pLcN9CSOW/71Ily/oy9JpUZolyB2zV1R9mWGB/3osKi2URbiQfeqVAwO9iQORVbN 0Rt4dWyV9hRjCXI3AAdzTnTdOFzZ3rep6c8WDGoH66b3ENzbxkSqwkH6iR3oLG1xH2+nvSI5hA+7 A+9FE5e3XAwabzbkUlF3K3egyTSNRsNPk/NPFFdTgZQOM7TUJruvXupauLmd2m3DAGf0D4FNbdiC oH1ffFGXfGrbAPvmgDDKqowLK+T8ciiPbh/3+KUjeuuURVPvxVBZgd3qBVPuozQM9VIhtVkZiF3B ePatj6l0T0kej7C+0DVXudQdAbqJz7/Fa+i1IWHrrPbC8Rhhd/G3703tNRu7XDRMkDMTiMEGtQLm At5/RzkM2Mn5ptqe60ba3Le+PanM1pPKRI42tnOf/NINjcNI7S4kUjuagyXwxs9ObqGCfW7czaOg 2yn4J7H+1G8R9G0PS9Wnk0W5Z7Vmygc54qCt7hkjMKuVjbuF4oN3aqcFZSyE4Ksc/wCKuxG/lbko zB1CHsPejW5lVk3Odq+wrObG80qboyW0l0QR38R+m89Tk/2rFnWGWQHHpx+5rIRo+v6p03NP/D52 /L3GQ8GeKazXTXRYNEY85LcdqLIMSFFACj9LCpTp/UoNMvJXuYhOkg2ndV2IH0t6fIHvRUt2RMk7 lIp/cSxvLJ6KBELZAx7U3nz/AEDaR3+KbDBhlCGyB7GtgdIp0TqfSZS/uVttdhDbd4/5h9qwldhk BY8gcrR4ESFi3pRtk8DaMimxa/sFhlWZZBuJ+pfirLqMiMDHEA3bcKPJGNryOd8jngY/TSY0Kgg4 J+K0XseKb1VbeNxPzV1baSoUDjuKGIjG2X9+1EA2uSG4A70SkOwWFg5yxHtRoE9S3UF14HakLcIV O5c/fFU5BQEH0/vSJRSSfoBAx2pzbwtKQEGXzwKaPkou7296LDM1vJuR9r+x+KJSrt9krI7fzV7r 8UI2m47gScj3o85/O7VUD8wxxvPY08ngl0lkjvCmPco26imCWRT6i2MjgUvbiA7juegvczys/oWc 86qckQRlzj747U5jgeeL6VeFmHAkGCD96JQ4J3j7ZMbcMprM+lNN6Olu92uz3VtGYyV2H6c1hsum 3No4SWRXY8gqc0R0DRbJyAi9sjNDSV1KGyjkuhazExKx9Ag8lfbNG8MupOktK6tt26zsG1HTArAx 7Sy7vbPzTbpbQ36g1dbaIlkIPP8Ap4zUr0zd6VpTajYahpMWoxbmEcr4zGQcGs3tlmHUU3SOqSXU 2kWsVtp0gJhTH1IPgVqmQoLlgrkpnCk96VqcjeuzWbYiJ+mEHkCrGC7D7YUBVxkjHNbl+OmuwvVH PDZ7cVTMH7rz96UIJoQxYY2nbg/NFEWIw3cnvWNMgM4dArcYpTMkmNvYDnNKkhw+QMrQ2BCkcZ+a VsJwzAgDG34oMdtPdSlIkaWVuAijJNORGWBPbNTfSfVY6UuZpbW2SeaQbGeQZ2/cU1sRL6Ff2jhZ 4Aj9yCKbTRGK4O7AXNZJq2t3msXL3l7KoZ+yIMVC3OJjvBHfsaU2bC6BhwU5zxQC26Q7fpI7GnAX BAoe1RuLNjFZrtiRJ1Ff3Ia3u5Wl9MfTuNR9xO0iAqO3zSvXO6VnXaTwfuPakyMjhQo4Pes16MZo E4A4HOO5pk/LqM96kPSRQV3HdntTaOwuJ7jaiZT/AFU06LFF5UnHxn2ptcR7xhPbvTm5gkilZWQq 69vvSFyeCuCam0hhCjJKpIJ28ke1DnkaZ3zE0ZznAHGKmhb288RViY5P9XzQrjUri2hFmsqNCf6i gzj960qKgmeSTamS1Pg7xIFkHJ7H4pMkcM6iO0Yl/wCpwMYpbWdwgH8/ftHCstA2SNosqcc/FEty qNljuiHB+atPaSN/MZskD2NWh2xKA8Rkz9+1ZB5Lq2aZY0lUZ7K3vR3sgilsA7l447UrQdAtOoep YoLy4GnWaqWM23O0jsKm9ZsbGzJS0vTehTjft21YMcaUW8YibDE9hVBi2081JQGK3ljmniE0Y/Un zSLto7u/eWBRHCf6cYxVDJYz+r2qzSBAu6MnJxxWQQ2enrZF51LzHsM8VETgCf6BsjHYUTocaY5R WbGD7mm1zEYiUUDHzT2ylmmO139Rfb7UO5UJIFjAZc4JzWF2ZRSsmF2qcchnFFimmdsRLGgPc4od 0rSKY1O9M+w7UqBFXagPA9ya1UgqXUNvlZQzyseCO1FklMbHDAAjuKeNbSWunid4o2jZ9m/cCRUV OAJCAeO9ZNlyOzg5bIxzQyMICe3zVo13MAc896chUWNh3+1WobLtwSO+OaGhYuATke4qT0vR7jV7 hYrBBI3urHFSWo9L3GmnfJCYmHBB+aKgGuGQcRMRnuO1JDTyFtsTED3FFkee3fEeHb/TS21C8it9 5KxJ7jHertQWEqyAsTnFLEbScjhvmgm6MxBJ3DHelmQpGH3Db+9A99BkiyQO3amFw6yKUyNvary3 kkiDLYFMHRZHCsGIb3B96RNp3SxJAEWLMmTgKKl720uIuZYtpxzWQeFPTYDNqd60Rt4B9EbuMsf2 pPVF5b7p/RfdubkewHxWpjF0wW5T0ckEHd/tTa4tgUJ4IxytP7koCTjiotyFlJUHJ988Vj7Shxyb SFB2p8GrGSNwASwP2ok9vu2twMd+cUqRAygxoOfmtIbJK0iskZMZH9QpzDPIu1RKWA9yaZSmXJDK F/6h8UtCqL3oJGaRCMuRmmksyuwU8Z/2qvVB+nuTzQTFI+5s9qBV19TqobIxyasB6ChQCATxQULQ oowT+9EMoeWPA5XuDQLDDOQce1JbcxUFh9Lf5q0kJVC3+o9hVbfpU4oDNOA5AGMe4pSzPKDgZXOO fekqFkwCCPvSxGFIGDgfFGtAz4kYNt2onBNXFiHXK5wfcVM2NqJomdnUKBgrimyn8ttiQfy8E5ND RnZL+VnZcfSR705nmIGVIz96s+2Q424NU1spVu9ANGQZDchxSHVA2UBL/ekiIr2GCDSojgkt2PY/ FGSljw2SSOOwpcylUG39Q5yferRL/L5ySDRXAUjOce1AJ2bA2DO4c1RO3aQd3zRFYKp2jFDOA6Af 1N/igotIy9wFPcUi2hJkYuT9sUZ1xI4A4o0eLcZIDE/PtRpZYZGPCl29hSJ3iV4vVhlTPG5aexav JanKIr54wfanUWpW8WPzEYkaXlRjOKCFNs7SMu9ig5GDVoFAmCOdq+7Gpu7a3xiMBQ/fFRs8KsWh P1RnnPvQTmj6XpdwAs939RPJQ9hQtTg0q21N7fSblru3Q/8AOPYn3qCNmkKgRkqfnP8AtR8NDCio ACO4UYqaD+W6SM+ltyT2IoTRpHkqCG9/tTUOQpOdx+TS/wAy3IJzn3xVAy2CeO3uauv8w80SWRpI fTKgnOcigjIb4olVkqhz7Hih3OfyqZ/UG+mjbQwIP+1AuiGlts8IG5FZy9VcZ27i8g9gqW+pSOMn I3Guy9UeF7GFYwQwOP7Vyv5EdLWLpi/u/wD8I4BzXUusPGSoHsMV8rh/ndPfl1ixnVB/6Z884NYr ZILrUsHvkc1lOsEraMVHAbmoLQI1n1hCOcnsK+vfT5d/k2fNGjaZFETtf6efmn+vwmDQFIfIPBxT OdjG0MajlsD9qd9WP6WiiNe4XIHzxWeLHdaz6xaJ6wYL6pPYZzXOHibuMb7eMDk10P1i+xLgsc5H auafEi7I9TPx2r7evhp8Hky7c/dV2/5q4KscrmsdkjjgIiGEJqV1zUCLqf1DtwfpAqGeTk7vqJ7f avnZvd+PPurFvTco65IHtVpp1woVAB9u9XdykWe5p3a/lGjUysQSc9q4vcYkEkZ/Sfakj6ffFPbn a0jbSCg7LTV4wCH9x/igHJJ6gP04wcVVw5/LKq/rUjtVMd+Se/xQWAWXJyOKDdvhZDcpYepK6sgH c96m9amLSjIALHAAGKivDaJotDEgy/0ZORTnUZjMyNk5P27V9finxjx5+3ZTNtHfmqifJOc4/wDN XkAJBxzQii5HJ75xmubmMM7ScUqMAjBJoTTbDsUZBpKu+zJoDyt9RI549qSIwse5mOfirCCQjKH6 j3FWNpMnLAkUBlxjHvSlcAdsftQFZsZzzV8jfjOeO1Anf6jscHPtSk4IJHFLUDt3PtSigKlTkA+9 AiR+OO1IU5PHNLGAeeQParEhQcfq+1BRycYFJYDAA9qs7le/P7Ulv3yPmgoKSRznNWKsu0jORRUI B4+KpzweaNaCdiFYBAQTmhqd6nA7Gj7m9uKqNhFGwwMd6kUxnB5OeR3pMex4W9pO4oruHP0HJPcU 3cYk255FdIlBTcMsRyaRJIDwOR7mlu/0EYxTRWIOau2VSYVwd2BVLhxuVu/xSp4T9JK4z7CkLGYy dvFRovY24+4pTN2UjmrfzVwAcj3o1vaG4b6mC4+/NDRqyDd8UmQqij6myT7VU0geVhjgNirgBu57 UU42KVypB4/xQCfUPerXUbQWccv/AC1Z9u75oklhPaxoJInww3bmXHFSART0lxvB57e9VHJt47/e hmMFuQeBV1TJPBH96bFmmGMDJ+5pQkx9iO1XMSk9sUn01z9TYxU2BkuWl284INSdpqnoBdvLfBqO ZQjfSe/erxzJuI29xjNJdJoS4i1DWLiPc8RiBO7P6v7U8h6bZELyTSZzkKe1L04iOZMjkn9VZLCp vLhoH4YDK/emxgWsKIFKBBk/NQRy8RRhkfFZF1FAqaq0T5XYecmgJYWiMjyz/Se64rNm1YFeTJ+Y KjgA96yPo3+TdyEcF++KVf6ToDXLPJdtCCc4C55qY6TXSYJvQtpTOWOPUYYIrhyem2ddPuUuLXHf cK6s8JVB0a6j/wD0iVyvoyR2+p+ih9TChgfvXUXhGVm06aMtgkq334r5/L6fQw/9ceRXmZtZ4fM1 1lFbwtNNNeOFjUck81rXUbG50jUWsriF7edRuaN+4zW4vNJfv0t5nupr4Q+rMLx3j5xt781qPXNX bWdTe9kdmmbl3bk811wvUjxTLeWkOg/mnk8HkUXJAJHJ+KsqkEnHJNXltwSvpsQx71r07aB3+pn2 +1GILqpxjHerJFhmX3HvRguV57VU2Rbwm4Ukdz7mnVnpENwJ3a8jheEbtjHlz8CmjymOKVV4BHB+ Kb29sFC7m9Rz3Y+1DYzSlyf5bn4IFNPzUZlSLa6PngsCMmpy0vrexeJ2HqrGdxQ+/wBqlfETxS0z qjQrPTLPRItPmRgTOgG41rTNYbPPu3YbJBxmi2s5QrwZGJwAPagLaPKm9UKLju3z808tomgGezNx 96mlPJJSFAJ2j5FIQ/zM5oYU5G/kfFSNpGpCkJ2pNpbpUUfoRmUk96kI5lcqTnHx8UJ4jJGARtHw KcWNkSn18j7V2xefPLtJ2EYfawJG32qahlUyKNuBUVEgiVVU8nipjTrTfKrNzt9q7YdV4+TLUSPp K0YYjB+BTu0tyBk8UEDu3cA8VJW2GQcbs16NPHuioucAc8d6Js2Y2jiqI2u2FxV+Qfq4ouilK4O4 d+9CeYYKIv0e+aU52Lyu44piz/Sc5Xn5oyTKPSXKoSc0K5RiEYgc/FFdATkOcfarTIXxjgKOBStR DzsAzZpuQABjA5p7cWwcn2yaZPEFBBbcM/FYvcdMaYXMG6R8cA1DsFV87SecGp245jIJyD7/ABTM QyW+NmDu+k7viuVmnbG0yXaJDtUc96NAFVWbaM0zumaB8Af70lJv5YDZBapFSR1T0oWLDKjgjGag dQjWNhMCfq9visl6b1m10yS+S6gWSK4h9MF+dp+ax+6ht5Z5yW/l5G0bqiQKKQ4AOadCbDAAd6jj uyUjy2O5J7UONpW+pWyM4osSynnIGOe1XLA8Ak57YqPEjKSC2SRmlpE+cqx57fagkEZoQzg9jyTR Hv5CQA+4YwAKBHKY84AdXP1CqgtwrszH0wDxQVKJCm7PGaA1ytrHJk7m/wBPzWTaVqWj2ZP5qL8x 9PK7sc1AajBBPeySQKEjbkLUWA7cqG7ZGftSJrgKCMZ470aPKJtY5FN5Yy7cAEH3qtSGEzesRg8D nFDa4JOSpGfYCn8diZnY42DsDT226F1TUtOv9Qt4wdPsRunlJxtFYaQHqKzYOVFPvy8ckYw/1f6v eo23vLW+ZBE+WPI+9GS5aI4+/PFEZb0r4OXfiBp15qC6oLQ2QJ9N25cAZqB6e6rXRNQd7NXUqWjO 8ZOQcVWvR9QdP6dZ3YmNva3RxH6MvLfuBUJZxnPb+YxJb7n5omm0bvxsutY0dLLWdH06/S3OYcpz +5+9a4uJY7u+lnWNYklOfSXstJlQIpyNv7VYY28CrtDmN0XkkjHal27p6vbCk9zTCQFQCDk54oyk 8e5+KxtrTLekOkNL1+31mXUr/wDJGA/+kjU/VJWJXUJtmZAxba2M/NKiujGSckkDGavuM/04++6t JoWBQw3ZxnuaG8oP6ewPariT03Yf4NJXG4sakQh1BPH00JkBIAB570Xn9wx4z7U4t7ZpJQMfeka0 bLajhV+pm9/ipax0sp+oEmpfStELMpbBB9sVORaOyS8Y2fFbkth1vtj8dsypwpCj3NJNqAyuwOT8 Vk8mnMkZG3P3pEWm/mGA29xSY1uZSIWBlh/Su7HvUgb5b+3Nt6AhOP14p6en3SM/v8U2ubf8uMEZ GMECpZprcrHbqL0gCWzt9/mo+8nWO2eQHLewNS+qmK3gLhxv9wawXUdRyzryQ3tntUp7CjnkEkrO xbJzsokxAVWJwW9vioeWd3ZghwQM8VeO6coBIc1m10k0l7aEsT7qPepqzUhV547nNQNle+mvPbPa pu3mT0wwAz3INc66RMQtsTIG6rTRqU3FiGPtSLWZZyPb7CjXSlcgDn5rnu/bpoxLKmVz9QNAuZVQ 84ZiKHeMFMgJ5PYimpDeirP3xjNZrUEJ3AHgfYU2nVWG7O0Z7VTzBAQDz7Gmzyb1+QDWe3TZvdQl gAR9PfNMZwyfUQWx24p1e5l43Ee+P/FBvL4flCFwpPGfiuk9Mom7lV0MeMN3JqGRfqlBB57GpGZ9 gAb6j8/NMJM8AH/HtWadAC29NcAkCryNui2beV9/mlyBShy3Y0goA305ZaqBmZnKYiWLAwQnv+9S FrGGJOOMdqAUOEwQM9+Kd2g9JiDnGPepVi/5UyIcEqR2Ap9FbmO2T6izfBoYYoA49uKMjh13DO79 65tlQldwQfUfcfFGVRgj3ptalYnaQ53N7E06jPqjHuDwKKdWkc0sixwcyAEkH496k4rT1Y9yrgIO aZ2p9GQsGwQPaiT3BmCRqSi7uSp710jKa05t6tiMoy/PvTtgwj3p9JHYU0tZgUUqCCAKeKZGBLLw TW+g7s4vUhV3J3/FGMwj3YJXmgK7Myr7j4q/plxk88cCshf5oOVG47vvQJJSCwx27VSeq/6otuPe k3DiFIy8TMGP6vaiaM7xGWMv6uQf6KjhJKjgc4+BUmzKzHgfam1yAoHParfSfZheLuXKnB/0mo65 +g5Uc45qSduRwD8mml5EHyS2K5z2GUTljiQHHb96Xql/FOAERVwu36fb70F32DaW4+KZTjbEzoMg /NaqQ39EOoG44+KG9t6ADE/TRIyYB9S7mb3+KRPL6igMMKKjYBO89vp9jVHK4457VTFVLMOD7Clh vUJJOeKAYCxSDdk59qXfpC21gx/YUKPPpE/rcn3q4O1cMozQCiiJcBeCT3ohYxFkb6wPehRbtzZP 7USUvkHAORRYDIyllyW+wFKJzxirbjIvOARwDV9vY0VQcIDuNClGQEHDHkH5qnw+ff24o4uXUKF2 lD+pcc0SE2J9KZHk/wCWDyppc0avcPKX3Rv2B9qC7ks3sD7VRkb0wSuQOwqdroplxjAwe9UxxghT nPNKjcSNz3pRfdLsB+xNNMkMiOMHGSPagztcKscUYHp553f+KcrpHoszK4O72LdqSjBiU/r7Lmgq 1tRGcAjJ5I+KvM5QfSdrZ7inN1p/oxxlTumb9Tg8U1uUQEDfRAb6ed3VgWkXIX017sTU7rnhr1j0 roUfUOo6NcWmlzY9K5lX6ah7N9rh5QQyyBlYcdq2n4r+ZnqbxB8P9L6EvYkTTbXBE6LywHtVL/pq YXSX8KyFd8mOy+9EtcK2FiKEcjIq9pH+XjjRUCKowv3o1tKWuTuGOO55qHsn1BNKsbIROxwp9qLL byRMySY9Qd6HJyzEd/6WpQZ5zuf9Xu1VQ+xweKtsUnKk/wB6NIgC5NDcFV7fSfegplZnDtl9vt8V UcmGG4/Se6tR7eMygYOCB8d6aXMSyMd59ML70Bylq0odIsYXC7qpgZD9eDjsKRBFNPEJgmYwcB80 vawx9PPzmgSpfiNyTEOQPijCQRyHAyPiqwPTY9z8UBMue+TQU6YYHP0nvirFsA7RwPelSqSDhSR8 CkhSyhM4zUoQhKsMjKGjFBIAT9AU9vmhqGxtYDapxxRGDD6n+pffFUWP1PuGAB2FKedXh9J+Vzmk iQs2FXKn/ahbBKxGCMUDvTOptV0OTdp2+0kbj1YTggUxvr8y3L3dzLNdXUrYkfuSfk0SVnjiCq+3 JwaK1nF6q28J3CTGXPzQNLuWaD040hOx/wDUPq/tQREzOA6lHJ7Hiug9Bkh6w8E9fum02G3uNHi9 OO5MY3MR960JZN+ctGeRf52QGUnOKWWdpLKbve2zStEtw0E0YyVX3oZbYS6SuzMOWNZza6Rb6zoM GnLpsMl4svqfm9wUkfBNYxeaWbW8mt5AFEfcKcis7LDCFDPOgY8L7/NWngkHqSRwMEU8kdqvawbt 6sSefpxS5ZJWj/L7yqH7960lCsNG1HXZNlhayXjkZKRjmnGpdOa509+Xkv8ASriytGO0zOOD9qf6 RDNplvLeRXLwhDgCF9pNObvrvUte0pNI1OV3s4nMkXqNuYn96mk+2PPELm4IXMYHufek/kZI4zIj 5A/UB7U5LesduBs+1JWdoRsXhT3z71QiB/y7LIWL5OQD7UWfUBLMW2K3tgD/AHoFw8wbZsUL804h t4IFnmDbmWPO370EhpOiy3xcl0iVgcN8VC3UTWe+NpMtE20uP6vvRoZ2uI1EbOpB9jipDUYbdbZC 8eHA+pie9BCrIu9QHZwe9EaN5W+nG0e9HjmRUwI1APGfcCkqACXUYix2oIqSGdruN4J/QkQ5yal+ ptc1vqWztIdQ1ue+jtv+XHM5wn7c02fY8gdV4+9D9D1VYs3puDwCMg0XZybp2SPLBsLj96VBK7Nj n9vmhRqUUEjP9quFmRcrRBZUDk5OBim1upSQBeD8mnigspyAQaCyLCcnNAqQGP6z9WeP2pu424yC T3zTuMCQKvYZzk0O4AW4O3t8UDyG6YwmNm+nGQPg03n1ptQVbGO19N143/NJVI9pAYgnk0ksY8FT j/q96BveWslnOI3BD4zSIS7EAkj5FSHqrMisx3uO7E0KaJWkQqMNjGB70Foyyrnec+2KdLcbolGc ue5oAtmbCg8+9PI9PaSPeeAO1BHyJK7DJ9+AKNHAXjX6Tx3zUnb2YkwG+lh96O1oFwoOR74om9I+ 20+Pce54zTn8sEszGfc07ggIP08DOOam5m0t7AQR2bJdggmctlf8UkZuTGEtisQ3rnbR7eHaXMeQ fb7U6ulDkLEPpzzT+yslMeSNuB3rWnO5I2NpCNrkj3zR0ccAsc1KpYxlORniknTsgBcZNHPZosgL YAY4+e1OVjXcHwAfgUVNPkjIDjNGEQjx9IIz70Z3s0nyGJUHn2oZcQkbkDY+e1SBiEjd8H5oDQKG 4OftijB/ovWt90/GW0nfaXOeZI+9R+oa3qWuan+du7iQXIO718/UG+QaL6LbuMADufmkvEuCc/fF VNGUwe5u/XnnkmnbhnfuR96cRD0fp4596XsXep71e4VIpEMhKs/CioQCZ12lwM7PekwSMbf1ymVU ZwRx/eniWyOJFPGRWwulW0T/AOqnWbe/t0/ONJ/KYHDf/morXj6kbuGN0jjhwOBH/wB6YSQfnpRH InqyMcKzdxVoWMRVGAGPpDU+t4QLqMZO8Hgj2p7Dm3SWxR4jG0sUY+vaOAKbajILq3i2FgByvxis l1HV7rTtMmgtIo7hZ12uAOax1dJutKSws5h6kzt9RJ7buwp6XaSTxFubbpGTQnt4XtGfdvZfrB+1 Q/5rUdUgV725mupFAETSnJCjsKy610LSuiteik6hjS9AAlW0hcEAn3JFP+qL7pTqxPW0ONrHUYwS Is8YojX5ikwGuHIPse1ERlLAE9vb5qZ6R0WLrLqWCx1F/wAtbhDxnGXpp1Poz9P67d2DHLRHK54O 32NVrYVnHCZlWQDdjj2qtQhQXvpqVRgMmgW8SuuZSTIOc/FIvrdBIrxsWyMk5/2pEhZkQO2zlR80 mVUfiQHbj2oNsgV2LHIpxMVZQx/SKjSZ0PpvRL/QtamvdUn0y4tQrQBCB6h+KxzRdN1G80+61VNL uJNPhYpNcY4X75pdwLbV7hThkC4yN3BxW3vDTxG0LpzwY606bv2DapfktaDGQftVYrVOi6U2uaj+ VswxUoXwBjOBmnes6Lp+n6bY3tlqCzzHi5tc/XG2cU91Dr7Ubi6tpLCzh02SK1WAlUHP04J/esbs 1SC3IChsk7jjLEmosGntlZPzG0yBvYUhIiiYiXaB3WlMwXBTIHxml29yyyFfT78f2o0GrqAXI+xN JmmJQsG4z3akbDF6kZH0Ft3NJeSNWCu2Qey0Q8uNKks1jN19AnTfHn3FNzD6caZO5SeRTZ9QbVbl IyZWEI2rvyR/ajSZV8N/iirpH+XY/wDV2FSdlMun6TqUMmSbgLsHsMVHq2bfgZfOMn2FDu5y4A3Z wPmgeDVIruVEuUWNI17p7mmUQ9d5GGREW+ke9N0jLkcc+2al9Nltba2vkvELM0Y/LspxhvvQBhi/ IX9vujDQhg0gPv8AamurXccmqyyRr6cMkn0gf0j4pDTXEkYYtuyexpImktJ4pkCmaNg67xkZ+496 A+q6dLp90sFwjQMQGKsOcHtQ7kizlXKs0QFOuoupbrqXVzqN+VMrKq4RcAYGBQ7i9k1AxhkU7R2A 70Ahc+t+oER+wNOodOs7+Fz+aW3ukG4eoeHHx+9M/SB4bgVYoo9g2DkE+1AN8wK67v1D39qnOjul LvqPpnWNWhuLaKPTJQsyXJwXB77RWPy7ZWJ3ZNWZ5Vt3jWZ0t2OXjRsbz96Jf9DxvDKs0kZ28ZjB 96Jplre6gZbq3h9WO05mXHYVHSSITgRHAGAAamLDWG0jp7Uxatsubl12xk/qHvRTQXiX1z+Y3PDa sciI/wDmkyXMkMxW3kUrnKlvb7VkqW3Rtz4dfmUhnt+rPX+tGkJUj5xWHyfQQoIzjv8AegdvONhY /wDPPJIq+mxgl95ycZ496bxDJAbk/NU+IZV25FA70jTode1KSK4vRpcaxlleU4BYdhSbZCjSpIQz RnCuOzVFTRPPKN6kgn3FSIDLHgA4WgeNOkcBMTfzWP1ZpiP5k55I9zzVNkqDjFJt4fVlIf8ASfeg l9F02bUobq5EJFpCQu/5NR2o26QuwGRIGwRU/DrX8J0ltMtXBtXYOwPckfesf1C6/MXHqqh5PP3o VlNn4bQ6l4Xz9WQu015FIE9E8jGcVg+kr6OrS5D+n6fYe1ZZ0n19q3TOlXOkW7I+n3Gdsbpn0896 x8oxmlaP+WxbJP2NVOzmVBK6lDweOe9Ja3IkEefrH9NL/hd1c3NvDDj1G5+o4FIk0650++Zrhv5y HGxTuyairqjq3phMEHnPxQpVETEqd+7gin8rsFx6bJK3J3jBxQEaO2O6RCQfigcdPdM3/UOpyWll Lu9OP1JA3YL81nHQ0/TfhvrVxqur+lrN5GhSCKLlUP3FYf0nqrdN9QRXUhZbCc7LrB5KfAofWEWk HV5ZdF3Jp8nKbjls++azZtZdL3oh17qOS8hjSKW9nLrCnZfsKjr0y29/NbmLfGCVZX7Gk6Efyt6l 2xI9E70/epXWdRi1tBNBF6dwSSx7Z+a1OkMrfU3/ACUdpCfRWP8ASq9hTmTRNPuelDf3GosNd9Rl NsD/AEfNMXtIooAZAQx9gec1HCw9C+dmYsxHH7UGQaBr+qa1p8PT0V2EsojhVmbKj5NAu7Q6fetb s4Z4zgsv6aaOoaUGL+Uyj9S0RN08nqvycYP3oCs8bDBOfvVbhgmR+3CChsoLEEbaS0B9cOi75AMB T2oLS2+9Vdgdp/fvVo8KrDcckYFTMOqssH5B4UfAzvx2NRboolk3/QR+n96B4v5H+Hw7Wk/OgkSg /px7Y+9N2TDnL7fsamfDrSOndQGrnqSaSCSOPNo6E4L/ABUUbaMFiz72Ukf2zxRCo43VgVOR8GnJ QuueN/396bAlgApxinVkribLnKGjIBUFsMQH9zV44Wu5fRhG1u3qe2KqZAbpxn6Kd6ddvbSvAdpi de+O396AGo6QscfpJLvKkZK++Dmn/UPiHrGtWVlBeqsq2aCOIAc4HzTcFY41XPfvTG5hMjHaeaLE 1pnROuaroM2tRQJNaIu6T0+6fvUUkzT27A/p/wBPxWSaJ1vrPTOh3WlLKv8AD7sZkQDDf5rFppmt kO0boyc4xRAzliFjyVHtShEN+51IPt9qc2xEiq/ADd6p5D6hVcY+9GuykvHcAZ/SMZNCNxITtLEJ nO371cJvUsMADg4q7p6YBPOaaU2uTumD55HapS3sfW0GS8EuHWT0xEO5+/7VFzKeCwyPtTiO5EYQ RMQPcfemgKNSjKduG/qan1vFbtuG7Lj2pnIcsW3Y+1ONK1M6VaXRhiV7icbSzjIC/wD01Ogja17c R2qgoWPBPai6jpz6YwjuMowHBpppqXF9MIhmP/qPehKl5DdSRNL6xJx/NbdVBY2DkOx3Ff0mj6V+ XhLKkrQXBP0uDgg/vV2t/Q2iVQpPuDmk+ghctt7HiiFz6bf6HeKy6jcRR3bAXLhv+av3rIOtrPRo 7UXOiTuxREDq5+kn3xUNeb721USSFjGfpB9xQriRZbWJVQoFPK570VOdBXfT2i6pPcdS6WdXhliK RxAZVT81j2orFJfzLbRiGEyExoP6VPYUeU4wVBC4zgHtSUgUA+o2SeQwogMVhcTyDKsyjvjsKoW/ ps4GWCntTwXs0SGNSEU9z71RdXjwAN3z80UzMnpDbjg96dsBb7XkQncOKB6W91Q8H4pzqLy/llkb BWPgCgSl04yCOPilmX1YTn3HNBH/ACwxbBYc1YOA31HigosYlBHP2NDeVhMI/R9v1YpW30lSX9QY kYPtT97w2sSO0AYMOGJoG4gUr/OXI9hTYruOD/Y+9PPUZlO8ZDc5+KYBz6p2rkE+9AZJXgXCruo9 tHNPDLcpGfQiIWQ/BPahwiaTaqRl5SeEAyTRxeTFZbMI0ZB3SRsNpyPkUAJVwxCjDn2ocxUW+MbW B4PwaWcsTIwy1JwLhWY+x5+1DbIZ9bvdV0mFr+5Nz+XHpRu3cD71j1zLJMWJ5PzVeoCvpITt79+D VRoGYK52j/vTYFBcSowVQDj5osu+Xltu7Pt2qsqrE7MUoLv7fTxQITS5GmM8kmCfZaXLIVUoOQKU zOMAGkxplu1Dag+5c/FWVS/Zv7ilSKIhyePtV7cSMsoWPdke3tQWWEE5Zv8AFVko5UfWD3NH0ua3 guhHcIWQjn7U4b8qpYRgjJzyaCOlh9Xnft+1Xt7hob2GULvNu4kCt2bHt+1FeNQ2BzmrBAv6O/3o JPqHW21i6W8/KR25cYaC2GFFRBXEgLZUnsDTmF2yc8A+9Wfb6gY8ge5obKSSSMAKmT3zQpZkurmG I/yTK4j9RuwycZoouHRHUONrf7UymBBBP1jsM84+9Bk3VHh/adHtAsOqw6nPIN5EDZ2Vja3npyHc +XHfNEQBAuGYSA8uxzx8UVli2bti+sOcEd6mgiD8szGV7eOV+4Ln3pMpFxklcPnPFWuG3RHsspHG BVAyNCjHAbsaobAhWLbiF7c/NGUtn6hn96GwQDC9ge5q6q0nO7iiwlYQzFCTuophVO57H3pVurRE u5BHzRJgZO36aENWG9yB3pBOMgybiDjFLeIWySyrlmI7Vkt9ddOTdHWIsoGTXMYuQ3Iz85qdqx6C Zlx6bFZR2qa0PTNY6ms75Y4WnFqpMsnH0/aoNoHjUOv6vkU5stSvNO9X0LiWFZR9YRsBv3Fan+yG 72L2bBZCf2NXZ8R7QMfehszyEsWLsT70dB9Kg8n3pf8AR99GcZVJzGqsc8l/ik/WgIyW5p+Zzb52 gfdcd6BcTrO27gMe4HtUCLUM92oXgnjFZP0R0Lp/U2tzadqerjSkyDDNuwGY+xrGrZAWGD9We/xV 7qGOfAeR0KHcADzmgyfxG8NoejNT/JG+S/i27hLCQf8ANY90ff2PSnUsF3qWnfxbTHyrJjJj+CKO mpPcRlLqVpT7FuaYLDcrK7suyMdl+aoyHX7SXqRp7rRrN/Q35Eaf0CoN9KuTAV9N9y/qHxTnTNav 9Hkk/J3XoRyjEiEZyKImv3Fmk0IQSF+d5PzUEDGNr4JPFGkkiZlJ5YciiShGDBBtB5/vS4baP0Ru Xk+5oG7XLldoYhD7UtPy8oZLoMV/pC+1IaMICCCQDxRYXgJAeNmY9kBoEyQw4Hpk/sfagTFiTgD9 6dXbx7CANpB/TVQLHPCSSBn70DWIScdyaUzkr9Q5PelraysTtb6/YD3pUkEqlWkjO4fbvQNJ2WLb IqbieNlKh1KJjtkiZJCcAKKQ7ypK20BWHIBrMuguoNMj06+tNR0dbq9mG2K4Jxtz71qJWLys0YyA 3PY0Iq5YMScnvUnf2BtJGhG4hfdqbMhaRCvBHcVNqRb275x6jSE9txp8unyIMseF9qj5fpLAk5zw R7UuzuQjYZ2LHgEt2q9pT2S2gLfXvQEcbeBSlhjKAf0/eiGNZXCtIO2RzR47OOTf6km1kXKj2NVn tHFSZl3f8v2o/wCXLsRjg9qf6Zpc99FLcRqkiRd1LAGkM0Mj7fVCNj9AFa0myrfpKW6sHnW9i9FS CQD9VRzRtBK0bDeM8E07kiu3tSbaOZIgeX9M7T/emt0ZSUVwRx3xWSbZt4V+JUHQsmoRyWH5iS5T AcKGOccd6itT1sXiy3Mqq9zO5ZuOB+1QCIYXDqR8ZHtUlBNBb6fJuj3SseGPtREawJchcljzn4q8 YIkDuxKjjBozXBmIQqBGvOR71aZcBCp5Y7VX70XZ3ZavcaVOZLMmFsYJX4q7n880Yjb0Qclz8n5q esfCnrG/svzgsYobUpvDyOFyMZ96xqfSplgEkku3aSp2j3oh/bXtnprGI2yySgf82pLp+CHqTXrX T5LxdJt5j/MvJOFT7ZrGRGogRWdt4HfHerQgRuR9Tp75FF2z7q/oC06Q1hIbbVP4vBInqLKGBBFY bej0rhjtwrHgCkQzzhgGmd0+CaqZyQwB3E8c+1Gi9wBPG7jjFDMJfkLnPtQvSkJADbQPeriaWN/r bCg8EUZgkb2UUgimMy3B7Y7VaeCBLnKcDGd3yaEVWS59c/WR2zQ5rgSyBu2O4rPpYPcuIn+n689s +1N2fG4kjtzQjKwfv3PP2pS4MjBlwmeD80WQD1/rP+xq8x4x2NOGa2QcDa3yTTWeZWO5Wwfms16c DWaM5Pz2pPoOF4YZxwRRnkG05O75PxVWrqzosjDYTycc1l3Rt3cPbvCq4MuRn71ll5b2tvZwyQOy Fky3HvT3S9J0S21eG+upxexxfUsGMZNSPUOvWOrSNiGOIL+lUGBWjda+mlR25l3c+9NJrkQ8kZBH BqX1FbVydoUZOOBTWLSEusv6n0gcLWOliFfWZJQI/RQgfpAHJqU6T6Vm17VUt9QjmtYJMlmYYwPt SEtX0u9ivYdnqQsGTeuRn71nl/436t1Do38PutJt7S7AC/nIogAwHx8VYl39IC90Gz0V5bW0JaNT +pu5qFvSEBz3Ap9c6p+v1XzI/aoe/nKPwMgr80qzf2E7YRXJ4PJFEgnjYAlM/tTB8zLjaRn3FTlj 0zex6Z+dcILQdpC3JP7VlQRLsJVVBOOKXa2U81u0iuqndnEhpvKoOSDz800WxLS72Zxn238VoSMk foSfU6sT8dqo7mO8nvTaQKZfpb296LHPklW9uxpoG/MuBsYkg9hjtTeTIbLkgewp5a6nclZLeERA Pwd6ZP8AmgzOuzYf15qmhILgxrxgfI96bpcqjsoGBQwcEhjljSZFVefesMnQIYYjIGR9RpDhUB3Y q9gqSIwd/TA5yeatfLHsOxtx+1X2BmYyqkYYHnhTRGjlilAaFiD70wtZCs4+nt2HxUgzSzhsuQvs M1ArZtlyOPuKtMThgDn70v0YAjK5ZGA/Vmr74jGkaDO3kyfNGtG1ve3tpIHspjE47kVP6ff3/Umo 2dnqV40FpK2yW6bgRj5qFhEcczFjgVPfxa0XTHhjxJvG36h2q+hOdQ9LdP6Lb50W/wD4gx7yuc81 idxbq9qEOSxfOKYCNbclVDpk5xu4FWmv2349hxkVmbShyWohcLt4+RV0gjDAgbsc80qNy5IY5+5o z4VeME/FdDsFlV2Zdv1HsakNIW0gnT80B3zg1Guj5B3YBobuUbeTk1F0ynWru1WZTaTDa36ghxio aXUiQwkcnHv81HJdrHlVQvI/YAZzRJ7KeaJCIWBP6sjtV9GhnnaSIPg7SO1Nv6gTkH4p+j/l40ty M4HekSqEJDAcjg/FS6Q6sNZjsoXglsYbj1Bj1ZO6ftUfdXays3phV2nGB8U3nYSKUzgHnNR6KYWD IxbB5z700iVktleLeDlvimTRENz3HenUN6IiCy5BqnaBg3pgtn3+9UDibYWJHcd/iqju1iDBhlfY 0J3f6sLknsCaEzJuVHGHb+mgexBbyRcZ5+KVc2Po3CxLlpPtU90wIbba5ZBx/WMijatcWBWR0ws4 GN2eKlGLtCYnKnv7g+1K2qbchjhs8Um99FSZ3uYy2B9CuDmmU0p2o+GYd8jsKQPFf01VQc4+adID sY7s8c1FWryTPgj6P9RFO47kZIA47HNVYNDcSLFIVUsG4zRYi5lVJe2M1f1wLYqp4PtQ42AkDFsH 7+1FCklIlkZCVxxg06tnL7l3ZIpEKNJdSKiesCOSKuDsL7U2N2Zfiidkb/WaQHKyDgChywvHEGxk HuKPpMFvNcvJNKUbt+9TV3Z2rQ/RdA/P00EGj7YgxHf4pDy7WViSw+B7UcpcR/QxV0PYBcU40yJF nKlAfnNDRkrMoDA7loqOTjdHtNSVza28MbmH3981GMCJAM5oui3wz4BwB7/NJZcYG7+5pUYUZyau c+rwNyewoBquwNu5zShGcZAOfY04J+nGBirodpwO/wC/ahoKNiGwwORRJHxnB7+1KJUOce49zSCh AyaChDkDnI71QyHbHNUsgLHjHwaNbwNLuwpP7c0ACMdxwfmkHAyO4HuKVKDGxVzhu2PigsSDwQMd /iiCs5UAA80LJcsTwKIE3gPuz9qsUKSbQMg980Cw30gck02kdDb4JzKrZ/anKxkI2DyBQvy8auQh 3SsRuU+1c87qN4btelPkjsI4PC9pjxJKwIH2rfusooZCvxWpPJ5ZpH4T2CbcM8e4mtu6wymRAONo 7V8r8a7zr6PLjrFimtyGOycZ96jOlFVdR3DtnvT3X3/kOM+9D6NgEl6CBlFOTX2MvT4//JsOWTdf W67c5xzROtpd9pGqcEDB/wAVdJEk12BUGUGO9A68kUTuAcL3H+K6/j/yjXL/AB7aG62c4m9/3rmL xRmEZmJPPxXSfWsxzN8VzB4n/wAx5G+a+1Z8X57PvLTn3W9k147ycjPtTA4BBXOT8081lds8ozxm mUWSATXyOT2+tw/xE2nhs8Z7GlP/ADcbmIA7VXfgnAqlwMc5/euT0rBSmdwyKRI2fb+1Kcn9/tQ3 bJzQU8gRSDxnuaB6nquFK8ZHIq7xeqdrZyTT6y02RgEAJAOd33rU9pbpvjoq1aDpqFon2kpg5+KZ X7AyH0juweanulrEx9I2xl4uNmCM1CatA0Up24BPcA96+tx+o8eV3XbL2qemWxzUYYpHLCMZ+9Sq Xbom0AE1N2dtYPYs5IEpH1AVxrDEYgFUrIv8z2oiQlsK44J4xVXCmS7Zk4UHAFP7VCVBYglf9qQE tYHimwEUg4waLqEqwKQGDA+1AuXNw/8AKJwBzioYOzSMNxbHyaocu28nGAKGcmfsCDVlfsKobTnB 5/7UCyC74VgMUqVp0QFgAv8A3obKpUguFPcGkmaN3EUzElexqQKifeN3cVRj+CPvS5tp2hcD5FJC Z3N7nvVFsFO3vStiheBz81QIzzzSmdY175FAHciMc/7VWWwcgD96v9G7n/tVt2X55FSrFtxxj2FU q7jk+/tV4gDuB70N5MMVB7e+KdNATEB2CBUPyKbSZMfpjHf9fvTiQHOcChSMAnOAM/FbjNMriVgw QDA9zVRjt/V70WRQgz3JqkKnHtVRRkLruxgj2oTEb9tFncLnHamZcg5Bqdr0dxEQNvJyPcUykYC4 aRchgeCD2pauT+1IliPznNTa6CkLOxbOTRIF3ZUmrLGBkGibccrjJqxUvZa3pvpRRX9sZ4bdgwQD gml9Wdbv1AQFQQ26BVQYwQKgggY8nH7Ur8qrYP6sd81Bb1CZDxx7UUMAoDcZqwjwpJ9/v2ofqLn7 ioFFxuOT/ikSlWyRzVMBuNJYYzjtQWddkhC8ilxjHsKSHBxzx8mqIYtkdjQO0nHCjj71PaHeqNRj aST+nFYsl2EbbjLD5pUl6iT+s5KnbtAFXYD1dc+tr91IrB1OFz+1Y/dahIEVfYcYqXuWS4bd/wBx Udf2qgBge1Zog7u5d2J9qlulVYXquQcD29qjZLcZLE/2rIemoEAQh8DP6a48hts7QkzexPjDbQcm ulvB9gjLG36ihNcz6XOYNRgQDKlRzXRXhHJ/6iFs5/kSf7V4cp09uF+Onmd54un5rfzG6oG/Tdgy BvgE1pLU9Gm0y5/LtNC7BQ2VPBFdF/iORvB5gtFKEqs1irnbxk596526ptG0/VI43IYiMN9JyDmu kxskeHjv+So6V44yCDk/akhjgY9+5oCktjjvV2lCjjjHzSvcIAMsc5q0jlV+9ALEOCfpzVrm4MbR k4+rg07TQb+qThFLj4FFt0lQMHgkQ/LDFEs5ZE3MHVD3AIqWsp31a5W3ztAXJZqfaVHW2iz3qrJH BL6ROBJj6anoNBttHYJd2sUszDcrmorUurtTsUfSrVo1tEP1EDnNRA1K+uJt1xOZGA+kDsK6TTHb Lb/VLdUaJ7RZGI7r7VAwsjYkHGe2farwmWddoYgsOc1dbbaNp+raaAgkEkYG0d+9P7OIwJuY7s9q DbwhuVGR8VJxMgXBHHxW5OnLLIlVDNge1S8C/QAFJzTKKMbgEGB8VLabCzMeSwA9q6yb9PNctXsW 0si7qx7j2qfgRY124AemEER52n9zUjaWRbBZiSe5rrjjXLkyg8KkLszyfapSMKioeFOKbiHaFGOR 2NGcExMP6h2zXV4hDON3cYqxdQPg/emW5mCDbz7mjseRn6TRoZpAwAyMfahGNfZQ9KKgIvYfJxSB kE7e9E0S6jblRjPtTUuxzzjinkxaTGFwp96aPEUG4/Ue3ar0Q3ldQB84plOu7nBGTzinpt5JXO0H A+RSGgcd+9ZsbxqGuYhg7Rg+5NAyct6mNo/R96lLiPON3HNMriIEEHkDtWPHbtKhLy2y3qY3bjxQ JYBGV92qaggDE78Z9j8UC5RWVABl2/SaxrTUrH7gmPK++e9BFlHtD7cE9jT65QrKQy4JpAiZd285 TGV+1c6QxyLY7t3JHINDhJRSDxuORTv8sLhgFUl2O3FFNusIeNkIKDufeptvZi5wc8bquJGZcg8L 3pEgJJGMY7GrgBACTke/3ptS4ZCW3BsAnmnjzlwMnP70z2EOSgBQ+2KNkEcjFNhe2IEEKG+TVZVG Ax3/ANqssisMBcA9zSCcAZbJqEhUjtt4H01YxMU3EkfaqyPZv7UNppC+CcJ2zRo6XUmSP01jU8cE /NZLb+I9jaeHt9oao7ajeKY5cD6cGsMkBIYA4HzTSQAKMKN3+rHertLNh6ZbQ28qrsAEcYVWFODM sc+SM/FVCv1jHc9+apbg28xZFRivseaihNKZ533FnC84cnA/YVYMIyD7/NEncyyergBiOVWhMnBO dpPODWAmR/VIJPPuPal7cLjP+KbFWBoqMexHFajOlbcuoBoitt5GML71QIH1e+OKuNsi7R798Vlp dWU8n6s98UaNoVwAcN7CmygkH2weKKUDksB9QFApwHGfehScL79qWWIXv3qo4mkkVs4+Qa1EolpZ mWQAqxHcH2rJNNsNzglMc4yaBptplV25Ofb4rILdI7cAO31fFaxxtXciRsYFMYXb/epKKx3NwMVG 2l+inaCB+9TaXe/aVAIIr04zTlldlJpomjII4+1P9E0yJLk7wMduaRZ+psJI+kmncURjcnmuknbD IuoNL0y36JWWKIG/klK7zxxWmNQk9NGBJJ+a2FqOtSzWZgbsvbPtWrupbgxk44Nefkjrx3ti3VBM dq8oOG9xWBXF36QBc7Vb3NZZrGpLLC8L8/c1gerhL8egr8pXm29Ov6PoZEuPrQ449veiJICeeMe1 RumxlVVQcKvGaklbbKVwGzUrpDhXCkLnINS0LhUG07jioSJgeCe1PYZSh4ORUajKdJchwo+qQ9gP en92Nx9MzNAwGdnzWN2168TJIHAx7jgijXWoSSNuYljj371h0GuF5bDZb4prLMVQhf0/ekJMZtzE 4oFzdxo209sVmxYs02T9Sk4pvNexpu2A7fim1zqSMp2HB+abmZZh8VmRoWa4WU5znNMJNsm4ls49 qI6c7v6h2ApnLc7cqFw1WegzuU3HG4jPz7U2uI0WJ8MQccUeZm3Z7kexoEk4kO0kfFNBrF/ylU5J HvSyzJ9A7GixwKynLFfcfvVxgIdwx9zWtM7DthcrJxyg+am7aMiLMq5Yc4qOZRGisr8MeakYZt+A HzxyaxWot6bL9QGE7Yq7MICFJ+omithLdlLEnOf2pEQJj3SLuz71jTpspWy43Af2pxbH+aTjHPek WenTXX1xYVQc5JqQjWKE5YjaO9XSbokCspLEHn3FVGjMzFQTg0uC7zIVUAIRxmnNntBcZxmtQ2fa cxB+ocGpkTsFKtwo7VDQKUjyT3NO4pldgCSVFVnaUhPqTKAMcZz80+igVuQPpqJt5jJKB+le2TUm srIhxy3zVqxUo9IEtkjsM0Zup3TRG09rOOVe/q4+qgSlpE/VnA7U0UPDjkbc/HekTswfYAGjTYG7 qabyDY+JB3HY09uZAZWwoVe9NJUE7tuzwODUvpDGSFRkkdvamMkPqdwaeSQqWYy7mx+nacYNAmJQ AD9fsKzPa7RlwoAcHgj3phcyf+nAPHwae3g9XH1Y4oUiF4dpAwo+KtIYRxEty1GkgVTuzwecUJd0 O4k8ihTTSOVJ5Q/7Go0smoW4ZbWSzO/PMpFJ9FFvZUifMarkZz3qS6a1GDTdbs7y5QXUUEgdoW/r A9qzHxs8UtM8S7vTk0bp2HQLe0UGT0UCmQ/c1ddJ9tanBUshGTmkxRMEBZ9xoUCSO77eFJPPxRFt 5BjniopWOSBQpF4JByPc0rK+m2W5z3ocg9WMKeFHuPeixSkKmT2PzRtOhjlkf8zJsjI+g03VPpAb JA+1FaE+kHdgIh2FFFt7FWWT+aFCn6c+9CI3EoqBCvY/NULlZTgpjb2pxuCkFRuWp2ztHbmVzgYz xRIlMuF7n2xTveI1kaRBKh7AcYplFI6Slx9AP6ftTtpL2/TN5eQmaCCQ7B9QA5FMZo96mIcSD9R9 xT+z6v1PTlMEBZkbu2e9R9xqEt3cO7RiOSTuFFVOjUqS7AHLD3zRkibjBAJFJ9aGGdYpPpkYc1fZ vaRdxUnH9qINpL3VqZkYCSEnuecU/a2t3jXco9QHIPxQBKsKGNOFbBJ+4qrkqQuG4+alDKVW9dlY /QexocdvMWIlkJQHKg+1OCUPBOQexNKDD02Gd3PHFNi+3fFg547ZpUTHkex96EJc4z27D7URUHIZ +KyRZkZT3Bz7fFFhBJwf00J2DNxzS0yWUg4C+3zW1ipHViFB4q7OZEwf8UlsNITj34qgvH3qRC4Z fRy3+9JmUSfXKMRnsfZqu2DnP6filyyepbwxd1TJX+9VfpYMyKoU7UByF9jSSTKST9Jz2q0f1sM9 qyW66H2dKtrY1CJVJ2rbn9TGiMbLhkLICwBwaHIFjQZOD9qUsskcKRFl25yQBRZkVeCODyKla0DG c/Up3bfb5ozNA8e9GPr/AOn2pdvNZrFOZCfUHZV4xTMSL+teAT2qdsqCtA4D4BbuRV/VLPtJXHvV 5YvVHB+oU90Dpq76h1JbKyAe5kHCtTegy3fUGVwSD2HvV3cu7MAEk+DU9r3h11H0tcQi/wBPBU5w 0bAn/FQFzIzShnjMR7FTTYHcPmIZA3Hg0u1nleAwsVRwQY5B+oUJFZuTg885FJkjEl0V2lYgOWB7 GmzbpPonp2frXy9aj0/0/dwQaq8rSXK7sblHPNcxWO62u7hL1DFIsgiZR7beCa2V4A9Xp0h4gSTX 9yy6a8IXCnCsffIqA8TRZ6r4k6le6Gyvpt24cKo/SR3rtldxxwwsy3UPLfxyTgWzzSqpwd/H/aml 9qNz64xEgU/qJPIp0lrbwXTJGW9Vzgp3waY6nbvCjCRv5gPeuWnYMP6bmRWw496HMWeQbuQe5FJh kyDgbqIgwdzZx8VWel0aYwekWIU0IMUJULux3NPDkKr9z8U70rQbbUpHln1iKxB/pkTdmiGiD1V3 RLhfk1bd9exgCfn4qS1PRrXRsrZ6ol4jDJwuMGoJWlMpIwBnBBoHjQr6ZAJdvfNAtbV3ZyrqoJ5z R7V98rc5zQLyQC+jQEAH2oD3mkXUEKPbtGM8k5ojaPqKaa13cHdAW2b27Z+KXczLDCEkcouP8Vab WmudIXS/WLx7xKAR3PzQRhiPCnBH2p/p9hcXxljgj3GJTIR8gUxCvGQSduDin1reXNsZDExDMu1i Pce4oFoBcQiQRrGo7j5pqqAspHOfmiRKyAIGzznJpG7+Zhl7HsKBTRF3bGV47UIE44PHwaMZTliD j2++KGxB7Dn4oD2luLyb0RIE4yXbgCkTRFHZHdH2HuvvQHzKpV12D7HvVLAI4yin/Pc0FnkLThfY D2pTOHOSMY4OaTBbnO5sg4pwIVCjnKfFAONgXOFyDxzStyWzFni9T4U05WzjRNxkznkAUQQLIVbO PYDHegZiRVUERgZOAv39hR20rU7cpJcafPbIT9LyLgGkmASQ+oxZJY2yMqeT7Vll3rd9r2h2UN07 Yi5G48miWsYFudx3cH5FOrecbducg+1JmhLOFGe+KkdN0a9nsJ71dPklsYX9J7pQSFb4xRm5SG0a Mr4Iz96fRW7sEIXFHtLYMu5Ru4zzT2IK/G7B+PimnO5Ggs9rYz35/vV1gZwRjBPt70/9F1xjk/ei RwoQDn6vcitOdplDp7KewGTyKeGJwgAXK04IUI2Dk/Jp5p6Wk9zFFcyGNGBGfvRlGxqCR84/TVz6 SHfyT8U/1G3jsJ3SNxL8GotVd2PGSKMDFiyFgwaksm4KTgc0IyCF92QSO60f8yNiu9u8aNwsjLgE /agp5CiEex9xQY2+rGAB8mlHbPn6vpHYCrxQlscZNBThXRmzj7UhMsoA7/HzRmUKCD/cVa2lFvOk uMlTnaaBrJHs7KRj2NVuDKN2WwcgH2p7cX7XFw8ksQCt2A7U12LlucfGaLCBuBJBz70SOeQglcgE Y254pxDAHUHHHuaCkJZ/pPc44oQ2msi0ZJX6hzS7C5T1X3NtkxgA0vLrcEMc44IoJti8wm3rGw42 470Izfo7wm6p6s6O1bqbT/yw06yYhzcNhyR8CgeHTLr3U4stVjfUTJGylV/UvH6v7VGp1RrNtoh0 zTdRktrdzmSENhXP3FNuitevuidVvtR4/MzxmNGHdAe9HO7+ma+KHRHTvSnTUK6NqaalctL/ADRI +6aMf6SPitVWtw+lyQ3KrtCtyftTlJXuGnlkYsZ5CzE9+aTeMsNlIgHqLuCkfvV6Wb+2Ya7arJp9 j1FpP8pGAV/T/ob5rF5ddl6g1aT8y/5m6YBDO3cj4rcPQXg7rtla2T/mIr3QdTj/AJkJ49En3+9a l6o6Tuuh+qNVt5R6SQuWtmI5fmm2p7ZnrdhYaZ0AGmSNNREgCPn6iKwSNXlj3OB9itOdQ1d9c0yA 3andjt8Yq2kaZCdL1OX80I5IIw8cLnlz8Ciwy7OT7DvRIzvZY34UjkUBFcx7m498fegobj1TIrjY ndTUaPJbRsFrSzuJ7deJJY1yF/emeEsyojJ3MM81tfw51v8AJ+G/WM1sYFmlVUijmI7e+BWoGQR2 0Tu5WT3B9uaM7SCyNeZQyFOO9O73V4ksY7WOxhj9MYNwOXf7mpH/AOr7XLfQYdTlsGWymIEc+7g5 7VDapptxpF0bW5iCTDng5q6XQKuZkG3jFKIlTnP1D4ocKSXLZjQlP6iPakxlnbarcjuaijyFHTIb Lkcn4qZ6W1PQdLgv11SJLu4uIituR3iYjg1j8zr6TPEC7DggCs30rTeidR8M9QFzvTqFSGEitg5+ BQYVG7RWKQtKC4PLCqeH60JcsMd/mmMVo9oiNJNu9QZK/FPmm3hcYAxQUGIPA+n3pvIVOSRgUSWU kDsq+5oU7ogUKd4J70DnThGGlE43MVOzFNDJL6TGQjcDisi8NrLT9Z64ttP1SUQWrDPqE4Gfiofq LR303qbVrdJRLBHcNswc/R7CpA0t5Wdtucg0Z9u85bLDgimto4/MMdu1FOBTwABnJAP3+aoGyAso GMGgMXimyhPFPJWTemOMCgrGqhmDZ3c8+1AJbhmfDDIzmlTSZjGBgE4/tSRgNnH7UqRvrz7f9qBN ysEJiEGWz+qrKCeTxk9qWYfTj5GQ3uPaglvSxnJz/tQOVMcYLenuYfpJoGo6fNc3O5AFGMkHijwI ZZgoyc8kfFKuLhppS2cMPp20DYEIuwHcPdhSY4v0kj9qWgCgpwM+1K3MBtI7dsVJNBG0rKCw+mqM isd+MGryMQm48/INDWQSuGxkfFUG/Ns4Ck5HsCKUjs5CL9Ln2+aS0aqrFjlsfSBSoAIITJMpZl5w D2oFtG5QgjGKTGnpj/UTTP0ZJrkTeowjznbn2qRjR3laTbiM9jQNdrbW4LEn/FXJ5CHNOIwpnOTj B7fNCuF2XBfG5QOFog93pd9b6DHq8cMi6eX2NPt4BpJjAIwxYnu3zTy61TUdQ0OLS5boLp8Z3LbK MKT9/mmTNgD2H2pFGuZBO0f1ltoxnOMUFQ6Oro/1qcr8j/6aSTt47A0qNlZ8AYYUDm4vpr1j+YmM svbcwxxUZJcyBnx/MiT9Qp1ckRRgovqE9wKDeWMn5YOGCxE/pU4NBlsvR1pB07Y6lqOqrBZ3AzHF AQXB+CKw9o4kuZUilMkZOFLfFXuJTI8FoBLKmB6cYBYlvsBVxHAlwwLmG5hGXgmQoR/Y1Np9nEtu 9ntLqRG3IPsaM6r/AC2j7jlvimw1AyKRNllJ4BPApJnMKfR9cfuBVUd5C3DAMD/igC3e6AkjR9uc CUj6SR7ZpSOLmORCNikYz8VK6n1Pe6lo9rYsLdLayH0CBNpJ+W+aCKkjfAUnaw4/eiRROmdxwKyv pvw61PWNJsta1DV7OxsJZQkcLAb2HxUP1ZpFx0/rVxaShfSDExhGDZX2PFNiP5Z88Y+9K+sjA/V8 ikxjanHPz9qMM7AIxj5NAmKMuSEyzgZY041DSLywsre91C3a3tJV3RyvxuFCt1aJZV3Y3Ajjvg0/ 13XLrqDRbHRr6UyWNmm2HHfH3PvSM3ZjEfRsGlQ4En6f2oFtbyXCkKhMp7AUS02LbpAG3IhwP2pz bMY7kMr7MDuKLo29N4zhuHU8intsysFU84ptLJuZzn/7tKidlOewIoyJOPUlJUD9qHGNhGeKWm0g 5ODSXkweBnFGou53ZCGkoCeQeCeSKvGBt3kYB74ooUbNy9hRkV4iyYRw4HODQo4llB3ECqUHYrZ2 5oTAYJDYqRRLjbEq7D2OMikMv1Z70lE4+pv7VRf0wAOR7/aq0scZK/7Vcy7OHGcVdRv7L/enC/lD psiSRu10G+mQHjH7UDZTtJJwSfakooDE8ZzSY8uACfqH2oqoVbBxRIXcoUmQY4xk0M7gCVIA+KVq Nwbj0wRs2e496tFzxTR2vEuHUq5VhyD8Ur+HbyrnuOe9WmX01De9ERyYwApJNNELlUQ4DLkn/ahP N9G0expo4ZHO0tyf6zmiSfy5MY9uaKcxyhztY+2cmrrnewYjaewFN3j/ADirHEfTcf1GpSbS5bK1 jmmGMjjjGaBoM5DEf2NXWRSdpPftj2pCsVJDn+1LVQp3e9NBMkOyXBOT8mrFMrxn+1LkJUZPJqon JbJ4poJ3bJORkjsfeiSOJUyx5x2pFwAiBj9TNSYjv4NBQRwO+VH3pccJKt80pdPSWdGN16SD9QIy DR/TFszKkglX2bHegA+QqqTnHt96QweZRDnORgD4pb/T/Lbu3ahy7bOKZ5CQY03ZFAT1miiWByCE 4Le9BGSGOPqzxjtWbaV4V68/SEHVF1pjPo0oz6wcZA+TWLP6FtK5hBKMe5OcVdBxoN9Lo+q2epx4 M1q+9Y27H7Gl9Q67N1L1Fe6vOiQz3GN8cY+kYpi0YYjBPagSxei+6NSwH6sVNBy2DGWbCgCmgwLd lXA3fPvUjawiW0EoddhHKsM1DXc0sNwsca7gDQHt2X6QfpYH3p41sZLeSVCCE7/ent10VrttpEOr XemSWdhMcRSuP1GoiOZ4WaJzj5HzTQUi78KTjFXJKZ596ctZTJbpOInKHvhSRj5oCRNLcRxgdzw1 E32UwB5x2pSr7jj7Gkyr6crK3BB7VZWBO45FFLZCVyFB+c070q+/IXBkVQ4K7SD2pkFZieTV5I1C YAK5FAZF/O30oXCE5b7U3b9PK81ZV2ICHxnufejJGHUgkgfNENixY4buPiibWTnBpyLaGNlYPn5z SJjxxSVQ92U254ogbB55x7Uj0GRtoG4kZ/akZYSfWMA+9NgrRgI0nf3wKZBirDPv7VKRGCSMennf j6s00lQHOFO75oATozHANLaQS/WRtYDFXkQoCcc470XR7CfWZDHbqPUHYMcZoAlmYrtGWY4yfYVR I3uyncEAXbTu/tHsXEO4NOOXC87aeXk1m2kWtvDb+jcqxaab3f7U2IZ4cHGDhuwpaISjYHI9qWCJ XCFsY7GiLGWbaDhicUAPSI+vtV2J2Y3ZFHkUpgH27UMx+oDlduP96Acb7twPxSgmxQoAwR2FXWMD t3NWaTb79qAczybNgxtBpbZlVRGMnswHtTqTp7Wl00ao+myJpzHatx7E0wJMSgAlWbg4PNQlG9Mp kY5xQxIu7A4kHsfersssC7m5THY0+ligljUbCrD+vFNBmoMj7WA3Uwni2y5+P96m0S3tVZi3ryDs FqHhFxJKzPFIqk8EoRVXakYqcqdo70r1CxLPjI7UowEyY/TgdjSZgO23kdsUVUkm5VOf80oXDuPr YlaqGESrgsMkcUmRDbyoB9S+9Ak5bHu1JeMsxcd8YxRDKAQVG0GiLkqGAzmgEgKdyDn5opnBOwnk 9sUHb/MAA3uTytSK6SwQ3BKmPHYe1A0ZcrlWzzyTSUkWB9/AYe9UNzbz7D2+abT5wCe/wKCzPHJM S+fq74p5DbacoJhYtLjkfFNEtyWBU7jxTy3EFvO6yRkn+oKcc0SpHpfRbXqHqC20+61AaZGSWM5P +BUjrtktq8lsJhKykqsq+49jWO3t9HJC0VtB/MjIbce9N1vpCeSTxwDWtHYV3CUbZu3496HazTRS ZjJQr2NGILsTjGRnNKiiJjye9Qp0mrTzKRdyerxwMcilrfRAbgoZfimITe5JXH3rKOnPDu96msvz GnvG0eSDG7hSx/vSFQAkiuHCg+9Xm0eIQvIXHb6eeTTjqbpLVelbsW97ZPazSDMZ7gj96iPytzBK jTZyPY1pnbZXSXRnSWpdJzXc+rywaxEpP5aQ4BYdgPmsculQqEAy+MVF6eHvb1CMKVXcKIbh1umZ hzQqrWIx3DMSyn4B4NHKL6u8YD/NJhkDzL7j5qzktcvtA2ijLJrHrPU10s6WZ0Ong52FRk03XVIp 3J9ONgv9JqBUK75J2n/TVnDhtyYB9xRYntantdTSNIrKKyIH1ej/AFVBzRMhCF8jPFFS5cHGOPjF VuDyhFxvxnGKIHtIRg3Pxiks+bRjJlWTlCvfPsadAKhKy8Hvn4qyCOaMlDlAeD2oJDSfELXrq0Ww 1K6uLmzUYVX4xTK/v3z/AC23RDup96aSKwkGDgU5trOeZHKpvQd+Ku12d/xCKfTVRbcrOed2OP8A NOFvYnVFkj5xzTZJNqbByCOQPahS5UjH6vvURIpDpjR75rh45wfoX+nH3pneLHkFO3uR70HYXP1K D9iMgURoiFYnv7AVaAqAr5zjNXMXq9sYHzSfXMag4H9xTlprSLY0D7pW/Wh9qgE9uSoxjPuKYzxK hPBP3FSJu1VuwwR3oEjpIoEX1Z71K3EeVBBIGTV97bQoPP3p4V2DbgFP9QpsyMzfQhfngKOTWXTo 50nRYNVhnlubuO3kQfSjHG6oqS39Pcn+njNZXovQ2sdVJI2mae0/o49Tf9JH+aidY0HVNPu5LKaE xTx/qGOw/eljWN0gnCs6qDjb7fNLOxCHwQtJktnt5SGGW+aoTApjIJHtWK9MuwLvU5IV3A5BPf4p quqSSEZYlfmnE9i0ysy8qf8AFN00yVZPpI2D2xVahJmYsOO5pU7TWkwZWIHxR5NNAj3GUBl/So96 tEkkvq+opLnABrCGjTy3syvKSkaHOPmpN9TULHDGxERzuDCgz2jJwMDjvTUxF+/cd2NaWAySvOCC uFB4JpvOZVZRjdnjmj+qHZQxyAewor25eTOMoewpVPul9N027u5E1PUFsYU5DE8E0rWokg1BVt7o 3FkvYqeD98VGtoEd0oEo2qeckZBpAtzBtAfaEOFA7EVOheXc7ZGQBQ0RpMgn3p3ExdSWUj7GhSqF O1P1/NaSBqgLYHf705KMkRDkB/YU29XYDkbnBogn+rcy/wB6zs+iQkrzIocqxP6l9qeSgRSmNiWG P1mhpN/Lyo7+2KSQ0oywP09s1FhxEyCULsDn5NIkMU7+wweQKaxGWQyNGcMo+KcxN6Mz4IldiNwx 2rWmQYmUO6+27GDR4Yopk2RnaRkn5o0lmwJbepUtuIA7famiMIZixO0n6QP3oByokIDxksD3ajQz rg8VeO1lhEscwGwrlB96AU9PAH9/tWQ7fD424zim6wsGIB3Ec0uBc8E4OOKQSzAquVbPJNa0u13k ydrAMo70k7CU2HCg5NEEJA5HI/3pTRoQoAx80NhNLi6aCWQ7MZ3e9CEQDYBJQ9iaciJVueF3qw5Y +1XaHOcAgewFVA23AYXsPeq3FR8n5ogBBGP7ikEDd9qL2szkjI4+BQ23EckCibhnd3xSMjfxgg0N qtJ20+dZkwSpB596zHVevYupba2RdPhsJY0Ku0X9R+awyRROPpUgDvSYY9jnnA9hWelSs8yxK29g 33Peohrky5Y5we2akmNo0a/1S4wc0yjtJEQ72BweBVTYSwu5+k4LDHPtTZ7drTduf1M+9SzMqquc f2FN54Eccg4PNNIb28okTkDtRgj3t0scOIidqgD5JxQYbcq3baaRIpup47eCQwPIwBl7YPtVGwdY 8F+pdKt7a5vI7MRvH6i+i/OMe9YTc2SGfkYlj4NbCvOlOr9G0+CW+6kjvoJI8hEbJQfFYjdWmMyS N3/3p9NIO/SZ4AiOUwc5BpWkPHqOpQ2t8220cgOzHAFOrm2IU8HkVETWs3pH0RvIP6TWfadOs+nf CfwmXpRJU/KXd8Y+C0mWJIrVfVHT+k2TNZ20KxgZPFa1sLyaxMcsBlF0pztVsKP7VM3nWF1dSbru LbM3ds1MZ/bF39LaxobSWkXokIVPtWMPb3P5h0iKnaMturIBqxlG0ycH2qHunWZJijbGHv8AP2rb WO/s1gnZ4ztIY5/xT2OZWcK55A/zUjp2i6dcWMJkcoXHO045pU2n2VlOlrCTJI7AKTRo0tLu5iZy mI07DHvSohvaQk5dhjNPbzQZbJmSTKsOce1RzoYyS5KsOwoLxQGIAD9Q4zTqMNgHfnHcfNMDcmMD 3NFM28g5xRD42F9eyl1kURDgKDzVS6a1lGXSdt47j5z80xj1SW1kBU7ue1ZBZwHX9voFWkPePOM1 O1lQMBkVPSY4xS3gdcNg1KS6SbJ2Dphs4IzmhSNkMAcj3HxVDIRkRZwT96R2PBJYDgVJiGGSLiX9 x8UyktWBO1SRnvQJX5U4JpS4znnNUq7SMggVcxk8g+9BQVd+Pmrs27gdqQeCfkURcDsaBMYJbHsP epu1ZLG3aYFiCOQoqHDK+eduKLpWqxWspW8Vnts/VGpwWFAuRFuY2lwWLc81Ez5GTjHPasom1HR7 yGT+FWk1rEO8crbiT85oWhzKkoE9tGYiCQzYoMfjE6kYQ7SOMDvRlO8fTkSe4NZLeXVs43eh6CA4 4/qqGuE+ssMYbtgUDN5njZNyL8UgT51KIhfrkO1ftRJom4LNnHYVVgEbUrMyd/VABrzc38XXi9vV fymwmDwx0wH3i7Gtma2U/MlgRyMVhflstki8PbAY24iArLNbQGaT2wea8P4s1lXr58r4xiWt5MT5 xtzjNPuhUKXMi9yVxkVFdRRgWp2uRhqm+hQqRsSPqbjd8V9XP1t8rH+TMLPD61EE/p+KjOv5z6sm e4HFTGlAHXRIowuMGoLr4AyyZPY4r0fjdWLz/wAWg+srlmimIPzXMXiLd7jKN2cd66S63Eg9XYu4 AnP7VzD4jSq/qkAKCccV9nKzxfnbfk0jqz+rcSc5yaaRj3xx9qeXYBecgjg01t8pknsewr4/J7fZ 4f4iblKAYxj4pDOSBgVdiV7+/eqPHJHt2rk9CpCVGQM+1Cf6MZ4op2tFuz9WewpAXaVLMGHxQKsy GulU4GORn3FZtb39iTBBCiqTjJ+TWAzEpN6xP0j+kfFG0t5Z9WtyhKxM2AT2reE7cs/TqixSNdDt pCoO6PAI7GsK1hCJiWwDnupqeszdWmkW9tNMGVFGMVj+quskh57H2r62E6eSu2oVIwccU/tlKtnO c96iGuSrLg5HwKKt+6IcGvP7KkZ7EMS2MD2pvgxkAcA980yfUpycMc1Z5ZHI5yCOaocidLcP9XcV FbQJdw4zTh4jJxjn2pCx7GO6ptYuAYlypyc+9DCjLnvu5o8duXBBBVfmrbQmF9qbOwfQUE8mlmBS KJGmSc1fac8DNWL2RsKKM9/mlDg89qohmBydpPbNJ2c/FVkRcdvarLtIIbv7CrOD7VRO1d7dgcYo LFcNj396qN0d9pGRmqmZUbJ7/aggmM7h+k1Ko88sVnwx+o8k0D1FdTtU8/PelSCN1GQW/ehOw3ED jFZjQTsWOdpz80KZvpAdfpPHFHMhY4pLF8ZA3LXRDWT9JyOAOKa+oUwTyT8VJSD1F7Y47Uye325x xWmVGUbmAGRj3FCcK/GMZ+KtuxlScN96XjevbOKBssTCTB/xV+WGe+KJI4ZsYIIpKgkgdhWGoSFL Nn/FLCkLx2FUVO/jgY4q7oHQgHFFDbHBFFVwpHsP+9ClTbGoU8jv96TFFvdcsQB7UBJlyC3OPim4 IJJzxUiSoTBYbfmmMqIHOzsf8UF1OG2k54pBwiPuPLf7UtE759+x+KJNZXEkKtEFZhwRQNlX1k5I wKSxMecknHbFSWqdNT6RZWd1dnat1+hFPIprNGINm0ZwOMnuKUNAjNlgfqPaqeMsoJHI70QyAOd3 v2x7VZZUGQWHarQ3I2nJIxTO6kG0/VwaeXILNnPBFRd2DtYYz8YrNERdzbFYFsYqQ6YuZWkX6uxq IupDJ9IT7HNTPTP/AKcIhwWzya45rG0dFDz3cQBycCuj/CQhbhFH9Nu+P8VzdoEuyUupwygYrorw kmLXED9maBxXkzvT6HHjuajgb8TOJ4PGrp+5/Rt0pWwR35rlKPL43uWU/UNxyRmux/xSNNZvEvpi 4dSUewWLePnPauOp5FZwy4CgbcftWt/GPLMJjyVcxhM7R2oLpnk06jP0DAyexockAYElsZ9qldlQ WUdzIFkfapPJ+KyzqfojQNL6dh1KDWEu7lVDGFDnn4NYdKypkA4OMfvTCQBrQwr/ACwzfVt9/wB6 qHDsJ44pmTDHsopTz3IZpCpUY2kDikiQN6ar7DgUeWRpYwFOB/VRDIyGWU7hyfejxQ7V44Y+9C2K pBU5P3p3aIkjMsj7RjvntQHt5WiK8dqOoaTcRwTS1swyqIz6h9yKcQRenIQ3P7VuRjIWL1VEe6NE AH9PvUjHEHA+9M1i3H7VJWQ27R2NdY8uWxYbX6gSduO1TtiuNuBtB+KaxQK+AcH4qVs41VckYFdM NyvPJvurw27mT6M9+1TMAWMEj6ftTVChdSCQAPb3p87b0U4zn4r0x5uS9lxn8wy4bn4o7FM7SCGH ufemCRbm27toP9XuKM8uGVSSyD3NHKDNkZwOKFyOGOD96d2yRvKdhLJ2OTmk3NusRJ3bs96lWAPI yhU7Z96XDuBPNCkmGzuBihfnAoznt3qqdSOFUqSME9viqA2/pGQKYm5IcOFD/Iogu+xAwT7UZSVt KCjNLgY7DFQ13JGsxIBIB7CnEkomwxbBHt80KSHcpmRgdvt81r2S6RuohJXTZkJ9+DTb0dzlQOMY FPrpN5ztyce9Nju2YI5HxWXWI2aD0ywPINM5X3mMAY29jUhcRjcM5GfamN0ohxtzmudaiLvonyzE 8E8CiY2RoQO47mnTIGAdxkEcChujKeeU9h8Vix1hk29XDAYYHuKRc3ckuQU3fJFOpc/QAMgnkikS n0QUUAqff3rNVFlA4Bwc0hlCErtJFPnGBgdvY012bpDyaxtqBb9ig9sVcymQcnv71eRCy4PGD/mk GNkBAGB2zUNlJIqnBPf2qt7SHIAIHehfUwzgZpQLADbxxz96NwqQhyPb70NzuGw9vmlMCVwauVyO +KBMZxkY4oTgM+M4xRFO3OTSGjxg5rNWKjjUTBiOB96Vqd5aXU1mLWxSzNujLKysT6xPuaUCE+5+ KRF6Rd965+KbKZbyo3HOPk1Z5iACVJz70e4RQ2HP0n2oSuUJAGV/7VEUn1jcwwO/NWcHIA7Gibty ZIwfYVdZVAO7tVA9h5XOSO1VC5XluMfFIeUAnjK/NLhmBOGAx7VAvJfIzgYzmhrcHOM7vuKmNEvb awvIbia3FzHFIHaH/WPih9Qammsarc3kOnpY28h+iGMYVBVq1HpG8hUkn9qlLK13nlT+9A0yH1Ce 4PtWSWNgzLknB+K1jNsWnGj24P0lcEe9TiWAuW5XBx3pejaazYO7++KmksxC2VLYHfcpFevGOW9o ZdEYHgZP3qYsrYwqAy1KWsQ+ksAadSQRyk4UbhWtdlXsIdyjPP2pd4yw8gcCrRMsC8HtUPrN/sUj dxWp1WaY6nexqsoJwT2Nat6x1eOJGJkBIqT6q1wwRvJJv2DIBU4zWm9e1cajdfyC8iPkht3sK83N XXihOo6qZnZw2QaiVlMrE/pz/vTOadlkJOREOP71eBJ5FMpBMZ7H4ryPXj0mLeIsCwYqB7fNOo12 lTu7+9Q8VzLDH7bc+9Oop9+Qex7UbiUhCh2+vn3p1BOUcr3WoX1Sr5zgUVb4RbclgfuDUrUTiyht mecHOP2p9NflojI4Ct2IHxWNpqCgtsbJxRBPJIq/VncO1Zb9HU2pMV4O3NMJ72SVsZ57f2qLurxt zAnsaJDd4G4YOeORQFeUvkN2HwaQt2zHOeKZzXbMHEWCT3ppBdkx7WOD70VOG6JDKpJbHHzUZPKy y7iWAHGKq3vBbzLKpLHBGDTWaeSdxjJz3zWGxbi8KqGUf3qOEhBJDYJPvV7oTFB6jAAHtQo43umK jaQP7YrWk2ctqLR7Vxknin4LzQn1zhD+kioyWxw8LOeAcZ+am4fTKpFMP7VWQUWUxLGRuAPB+aew wumNwwP+9T/Tlho11JL/ABS7/KCL6429iajry6tZtQkFm3qW6Egv/q/audddAySbWOByaUjkKRTe RA5ADEE+/wAUbczOsZ2hVHcVF2Ul1JaxkAF93xTmFxdQKkh9NTyTQY88qAD+9FiVbqDYVzzk0NUa J9iMA2Pg+9PLa4b6d2SP96AEXtjkUZJWdwRgntj3qKnbVN8Ywck/PtTpYsTYzz81GWU00UWX2kZ5 IFOYJ2lLe6/6hW4xpOW6BcFyCKeLLEc7T9XxUPHOzoBjI+RT+BgJMnnjvWlhzN9EQcKfuKA7FVLc ZPsfanTCPAkEpyf6c01edDIe3P8AqqGzG7b1omIX6sY4pp6nosCfp4qRmUAc5wfemdxEMr/UoqVk wIlIYgcE9/imVzEFmBJLYHepO4kGNgO0n2phOm5mXOcDvUjW+kVMg3ltpKZ7Um42kYOVXFOtpzt9 ifc02v8ACck5PxVZRk4Oce3tihFBOnpmQxKPcCimVVkYc4x/ilkRyKofA9zj3qVtHOwt1AEDEDgT Uu1aS2yd4eWQZxj2o1zO1zmLPpw+xoEUPpzKM/YNTaFRZaC4kUDcvdTTP8weBg7TxtqUWAyF1OFH yPemd1brGAccjvUU0nkX1VT3Ye1O9FjGoh1UfXGcNmgWwV72AMAF3rk/bNZV1fYafo+rxyaRdpPF MgZkTunHagjLOS2N4YJDtAO3cRwajbwb9SdVOYV4HwalLxbF4EeJvqxlkPzUa0qu7ZIAA4obCaMD AC8+9LU7V2rwpp1/ChLpwu/zSDH/ALXuaalR9JY9ucUWFxxvcukCAeoxwD7GiappB0+4WNxuOAdw 7ZoPqG3YTJklTkAe1Ll1qV4DC5G1uSxHIouzd0UMMZINESHJzkFh2HvTcttACMH999EMjEhlXn5F SpGdab/wfa9Eah/GrFn1qeJvytzHkmM1r+2kjeygZXZlRdhduCT806tZXvLmOC7kK2w74+KJqccE dy8doB+W2gAH/vVICWI+pR/KxktVSygKpX6o2GRmqhYmFh+lPdTSJVEwRYmLqox9I4FZp0AxdpFD Dg/7U6twxBIAJAptcwtCqktkUa0ce2cfNXS6EY/VhgAT7e1KkQtKMD2oZVpHbA3KPf4ou4IQGJNN GiO4Jxjn270sZCjHANJckSsI+Bj396XExZCT7UiRbd/N2++Kon5OKtCfSOMdz3NElTbjGDSEJEZY HFUFKn6vpPtVvVaI5GM/ehSXEu5RJhj9hVUWVSYm2MAQM1ad55bNEM7AD+nPH+KEoiNwEn3bCeQv xUk0EAVig2oBgBuaMmEZ9AgH68jvTm3t1ZjJIxIUHimQzHz8GjteEWrhcH3zUXZ9HrtnHoX5AaRC bp2JN6WO8/2qJhtZZ9yxhQR/qOKCb5owq+mGJI5xyP70adZDCGjYE7sE/anaHfrFE9NwAV74pNnr F5pUwubWUwXKnKSr3WrosU1s7bwrAYwfekJeta2u0RxyE8AsM0vYf2XVOuLevcT6xNdzMCS0vIGf gVH3sxuJ/UY7mP6j8mmxd5gSuFcc4pSsZQMKRg8n2pJoEyGXd3PxTzStFvupFkttMj9STO5098VH o5aQ4HA9xTi0nudKmN1p93La3Pyh71NBrcQ3NncPbCP0ZEJUofn3pxo+ja/cNLfaPpOpXccf/MmW AmJPkk/FNLprmS/F5cz+rIWyxHua394PeamPww8K+pulxoEmqXGoQtFFcLj6dw7/ADV7S5aah0ex fpLVo9SuzDqbygyHa2REx9qxbVJTaXF1dZNx+YkLAH+nPsKFpsly5d2mKCViXjPYMT3xUjPp+GRD Ks64zuUYxTtJQ9MgiUCRxgkZx8US7EIC+m2R75ockLKp2AkfPxVFY/SDD/nD2POaqAicBdw4C+xo 9pJGbhTjLn271HSWL3kpKuVJPOKdW1smn6hZfmJt8W/69h7CgPqLxlwvAfPPtihi0yQADluQ1Sur ro73jmwJeFhlTJywNMzc+v6eBt2DAxQX07TIZNWsrWWcxpM2x3Hdc+9E6l6ds9E1qeG3uGuBE2BM f6h81FzJOt0ZVBBH6achpJ4g7sS5GCGOTQIy08Yy/qKT2NPZoliMb/S2e2Pio9wyYUjaD7ikIXUj 1SVQnahPuaB1chDCTgFiaTbPsGf6j3BpNzbyQzCIMGOM1YY3FMfX7UBJACM9j9qsYxkkna33pOGM mD3HtSWbLcqSaBIBJYjAIP6qvKpwGkXa/sakIIY1GZB9WM8USV3lTG1WC8ZxQRUY9VCrc89/iiRw GFsMS+73p0YvS2jaCD8CjJCSRkbyOwomzeBS0g3kAe1FeL6yo4U/NPo9M3KrbdtOEtBcsYmAUAZD fJoWomG1AkAQky9gKk7WzMbqCPrX/Y0eKNYlA2YlTgNR0L4JPDE5zWtMXICYzTyguwcjjG3FPPyU l1brIzhVU7QAef8AFWCkMdy5PzTqKIOuDwftRzuSOawfICjLE8fvWU9L9S6p09ot1pCvstbmX1JI 2XPNR8MfosMHB9ifanGfWyzEtKD+s85ppztAmjiMzemvp5JJotpZhlBxz7n5oThlc5GfmjpOYQoB x+/ajFKu2APC49qaqzQsR/qGcY9qJPIzuc4YfIrJuhuobfRL27E9lBfJNEUxKuShPuPtTS1jDDcA c7lIzxTrTrNdV1m001GCNI21pW4C/wB6PqlzBBJm02NIe4A+kftUNGzpOZN5Qnn6OCD9qSsy1kPW XSU/SGuJYvcm4V09QSN3qNuXPoIsX0sP6vmm89xealIJLq7aVkGFMpy2PjNKEn04x/mgFMq3JVnH 1HuR71nWpeI+l6t0RbaDe6WY7iA7Y5ok5T7/AHrBiFBymS+fYZ4ozbo0BV8n3rNSmiBVG2IHaPc8 GnSnCk5waE8pcZQfV71cv9AYLitKpxtPGcfNIH1bl5/elCXcue/PbNKnnSCI8ZU9yO4osJRQW2Y3 fYmrzxMqZIAA9qbwlo4hIMgE8E04aUPGVfk4ohAnYxlVJGaNYCNiivC+EOWYDihxlCV54NScOrxW uiXdvtPrSuMP8Cioy6WIajLKjlocd6QmJOduQec0BgoG4NgfFXSYhfpPHbFFLZSxbapGOeKsimZi HPI45qU6d0e21dr2G6umtnaLMD543/emEUnqyNHgEx/ST8496G4FNEYwQAePtTO5WX8vKFUqxx+o Vnei2/Sdzao+std/mlOAsD7QRWKaxocGkXBW2uZZ4XYsnqtkqPjNNsz2c2fXnVEEFjatrt0kMMii GJBgDkcfes48z1rPFr3Ss7szrPaRu77cbmI5rWdrdSW1yjsqv6TB1LfIqZ606vu+s7u2uZ5HdoYh HGjHITHxWuiTtChl/MtGjExDGOKLqHTd1ePHdJbyxovAkAwDV+ntMt73VEt9QvF06Egv+YcZGfjF J1DVr9dSa3S+lksrdjtVW4YexrLR/eWt5bbFa0aFSveQYyPkVGhI95+oKOwHzVzrt9eSgXU8syEY RXOdv2FOrPTYr+QmQbDGu4UUza3jij3DJZfdXwD+4oCxLeSgPkj+ogdqkLPSW1qd44JRCgP1FqlL VdK0bS72yS4W+vpD9LKeI6M9Mh8MuptY6u6Zuujr+6ZtJj3yRyY+pdoyP96wNpX3yrO7SybyAzHO QDSNA1260e6k9FzGSCpZTjNKmdHB5+o8g1rbWzjT7gWFhOAuZJCcE+1RMPqRPzxnJLU8iumhbtle 3NJlnUoDgAfFZC7W69BZiFzvH+9R80WJA6Ngnlk9qIly2W+KS7oJAWz96C4d5ydyYApSkKDjv8Ul Z2kL+nG3pgd6vESVOf1HvQWZDKjK/C1bG7bzjHxRcgLyc4HNWvLK7Omrew2ri23YM/tQNroK+FT6 HJ/UDj/elNIwaMhiTHwwJyTUx05q9jp1tqNte2Jup54SIZD2jY9jUHBbyQoBJndjkn3oDLKjDATj uTSxIcZVcnHC1dmxGMDcO3FDGYyzA/8A3KCx3HluKWoDjOMcUh5MAZOWPtVJJjO48UCQ5kGfYVb9 WSfb3FXlYIhJGMnsKQVIAOTtJoDK4ZcE8fFJkjO76TSShIyvNUhLnvigOJghA27W93FUw+rHHbNC GWwBzn5pWGEgUcOfagTHGHBLc89xRJRDaQtO7EIqk4HJqxY2LtkZ+RTnTtH/AIjp+oarPOkcNsQB Ae8mfigEuk3l109HrqOjac7bBGT/ADQ37U2EW0Byu3d7UWWd5YntoyUgJzsHAqm3Iqg87B70CDkg Mo2ge5pcUbRMz7vVY/0H3otsTc53lU2jIBHeqIVwGTIkH9QoJTT73TrjSprOS0WC7dgUnzyo+MVD flpNNlKPcExk9z7ilpbhTlyWfvmnDhZFBkUNj5oDataWGnTRxwzSTzhQ0jgZUZ+9R+5+XA3p81Zr d9uwudh7VkOmaG1zoFw8ciF4hu2+9BARuwA+otRAhYc/vS7i0kso4hL9Mb98dxVTSWZMa2STgAfW 8zZyft8UCCBlRnFU0e8DH0ke/wA0hiN4yaU7buAQQfigEjFJiQcKPmisqtGWJ4PJ+KbspdzuHA9q K0oRdp7Hjmgkei+s5OiOvtB1+103+Mtps/rPbbN42/cVkPjP1rZeMniodfuNGj0hbvahhhXYF++B WMaBqUugPdSWWxXu4/RlLjP0/amjyvJePJJJ6rjsW5xVjN/s817p2KxvpYYrsNBEdoYHuKd65qOj jpzT0srUWmphiLhv6XX2Oag5YWmcszE7uMVK6Dq1np2rWb6ppxvtNicCSNf1N+1RowtYwxLq6lD7 qcihTp+UjcJ9bSYCj2FT3WVzZ3PU9/dafYtp9lMwaO3PYcdhUFt2BXRGllmdY0TPYscUSJi5hjjs rJGuXlZly6K/CH7fFNL23ihki/Lzy3LHuZOSPtUl1n0DrXhtrNvYa0oR50WVXU8MpGaYlkDHY2Se xNNKVb2sB3maR43xwFGc0iDuIyMoGzmnlpLsMbzqNrA4IPem8pDztJGcL8UF7sCKRZFFItI5L52U LztzgUm4f1FUZPNKs3aGQsj7ZPZh8fFASa0eyYblMeR7ilW0bXgAj5cnAHuaLrl/LdJbNOo3njcK JY2F5p0lpqAheMBg6u4+lj8UDK5ttspSRiu0/V8ijMltGVMUjSr2yRVrqeW51KeabaGlcs20YFJj QS3KwRxt9bAID70YLACIdv1MT2+KAybchid3xTq4t2tpGV/oZG2t9jSMBhn9T0aDhlCH02XJIyaX v2kKeFPcCnFrqT21lNaGGNmkOfUdcsPsDTULu4Pt70NCuUfKIfoX3prKqZOQSPtThFCgRxrkf1N8 1ZhtJ7UUMBJFDEkEc4q5yX54HvS9oxubk5xgVYoF3gfUMd6J2uBuAPx7VYDJFKQfRyMUnftyc5oq z/SCoHPzVRAg9+fvSijHbg8+9ESAz5K9174oATDB5OauileAOMd6vODtUAZPtV4yXBUd8ZoEykvg E9qXEzKRuGBjiqiwuC4z81KWGlfxJzuJESDJNERhEclxFG5wCeSamtQ6aW3KTRTROjjkBuR/asff TriTUJHWUGJTwaerDIku8ue3Iz3ppQQRbuQQSM+wqV6j6pk6gvonEC20cUap6a9jgd6jZSSTt9ua GJGk5YLjt2oLgE/zGxuouPpJzjjmkqp9P5qwDMdh4BpKE7fVUPu5FPbO09UH6hz3po6bUKp+n3q1 nK0Uy4J2++exoDyQCN2Dcj2+1CVdvOaO77nP9QNDO1hgjGPtQXjlUKeA3zmryzsuOMe2AO1ICKB9 J796sWIOB9We9BcSFbhHUBip96PqYa5X8yi5UHBFBiQeoq5z71lvhzoEXVmo3VjOSkMMRnbHdgPY UDKx8S+oNN6Tm0L8/I2kyZIgbsM/FYfp7PFuMmZEbJx8Gp7Ure2WaeKEERpIQu7kgVGCL0/fHwKz sE9R0Ue5+1OI2G44wCw5BpuYtoyrcmixLgfPHc1rQQ8rxIVjGeaHayra6na3Fwh/lSLIUI4ODnH9 6OY+Qd2BQJ0a4bIOV7Emk6StoeKXjXeeIum2MH5ddPs7cAC3iXgsBjNasvCzXcc6j6c/WuKffWYQ CNwB4oUwKSADuQOTVZ1W2fAVG6nsurNNmCGSOBjbB1GV44xWpb+zurLU9zna8Mmxl+TRbLVLvSrs XdleTWk5Xa3pNjcPvSZZhc3nrTyO0p+rBP6jWezVEuZEkud6Dk9809jt4njYMu8kfqH9NR7LveQg U8jmZIVHAA71WzYxFCSGJFXkk44AbFEV1ViQMg9waAIgXODwaBErokTO6Zx2FZDrfQWq9P8ATema 1c3Nu9tervWGBwxUVBsUSLawDL2K1eLVbn8m1rLK726DESseEHwKM6NJJCMk5C/Jo8CpcAlMlVGS T2pdjrJ0i+trpII7hoiCY5lyjD3yKkOoOok1q5vbm3tI7USpmOCIYVTjtWWjVkdEUqv8thy1M43Q s6csp9z7Vk1h01ZTdE2+ovrMcF+7FZLZ+ePgfFY4IWg2qcEg/q+asFRp6Tkchf8Aelm4GAhXPwcU ln25+fvSV+oFSeD7/FULIjcZD7mAwVpmLYwszJI6H4U9qOEC4EYwR7/NGVQy7scnvQJjRiow3Pck 8mkLGzP9HLtwM0ooEBPOTVRM0ZJQ/WO2famhU0LwMIpBh++cdqJHMI8L6Yb33VTStcsC5ywHc+9W OEwMUCXcg5Pb5q2d+UyB+9XKhsZ5/aqMW7OBz80FIQgKtjnsRQpYx8Z+M+9XdGAxV4h6mN3sKCcj 8QNXt+nP4NLcb9PQ52beTntUHp9m1/dog+o53f2oksYAyQCT2pNu89rIrw4QkYyaIcaqHinVYl3Y PvQJL669L03UbBwOOQKNM8rIJHzg8bvvTKR5FTLEkNxRSJJVsMOCQz9vepzTurL253ie5imhjQ7Y CoBbHtS+i+jZfEjqO30mG6is0TDTSycYTPtWfeNtt01ps+n6X05ZRepp8fpz3aYzKfc5pO2cr4oP V+h9Huek7TX01RTc3C7pLFT/AMo/Fa8lZD9IGAOKLDfSLmJVzuPbNCuAISUdSGbtVre+ibdI1IYE k/JqY0HQ5epTeRwGGM243uZmxx9vmq6ctOn5NPun1e5kh1FWxbRqfpb96ZbVspWeFmEh4bB4P9qh si7sjBIyMRhTj7UiAq2Q5wB/VV5ZDL3JNIWNxnI49h80IW6rbvlP1n+o0lWdFwrHae4pBzI6c4we c09urSz/AC5Mcx9UDtmi7MyyhBgdvarJC9wGdVyAOftTdC4YNjI98GnCSybGlQMoHdR70NiKgilj ZB9A5NDkhF67TiQxsf8AenLFJEDRsORkrTWdhGmCfp+1EoUBKJKPftk+4pcYyAMLjHBpnJK27CKz ljjApzfQzWckURQ5dc8c0UdWVCMfUR7VTkIDtAHzTGKYhvdT/wB6dbXZVyvB96M7EcYYEZORkAUz nSYxSS2t3NbSqQdyMRj+1PH3oOO+Pf2pqw/lvuyAzqH/AG962NldG+L1p1TpS9M9XAzcYgv2XkH2 5rHOqNAbTrh0V/UQZMbH+pfY0fWPDIaXZRahaXKPZSgFUZsnd81mwudO6x6QCpCYdW09AkqN3Kjs aRmtS6QTLPIyofUUHA7UZbiEks5BZTggVWqo9pe/yTsLccfFZV0j4hQaBoN3pdx0/Z6gZCSt08eZ FJ+TWtIx70jGQTwMZFBd8tkNt+afahdxzIHVQMZOBTfS7KfW9Ws7C1tXubm4baBEM4/eshKqrgN/ V8miKNw+rHfk1J9SdNXuiSSW0sLJNH+uI8EVj8IdI8srK3+nND2eTN6SB0wxz2rJbPww1W/0STqC CRGtUGDg8j+1YjuEiZGUPYjNTeka3c2VpJai+uEt2HMIb6T/AGrWgK2LQxMsqbpDwGI7igNKAw+n +4FHa7EjjPJ7CgTJI3CkZPPFZCW2qpLd/YU+tNUaG3eOP6Vf9X3plEDgK36vvRf4fICWRcj25q6C 4wIo3CdyeTQc7jnJNEcFOGyppO3acH+rmroXZ2xweKuJ8xgZzirhPpODVo1Cpzz+1SgLYORjA9s1 TQk4Kj6sdxVTfW2D3FJZyqfTnPvmoshZT/0RDcNQ4GCx9sGgtI8jYLYC/wC9WDs31gfbFStxa4kP 6FJGfek2eo3dhMj277ZVOVcjOKW/1fqX+9DkBUHGAay1GT2niHrkM7zHUXilkAEhQBQ2O3FC1nrG 7u0Z5JRPJIcu5HJNYySXGNwLe9NLouCMZK/aq1MbRr65eblP0t3ApoVKSERDkDJz3xVEkrtyQ3fA NGMwLljwxXBrnXoxlNFuWlKRo5UNS4piAVY9jjPzSXRVZWAxjtj2oDEc+4pt0hy3phixXDAZBocW o3MlszDaI84LjuKZXMp2dzjsMmgJcG3LKFJVu61OlSaSkv8AUS+fc0b6drBB3qONwDEHAw2cAfaq W4c8ZxWlLkhCgMBg0lp9uSCWOO1WWZm3EnaB80DLliyYJHt7VhDqDXrhITC4+lu4AyaFNcCQqG4A 7GrxXrgqCkYB4JI5ojqJQ0ePpPO6rEi0UzufpOfahzS7Z8Hj7CnVu6W20DljQrkK6E8ZJ4NNkZX0 JoGha5Fdy6xei0aIfy4s/wDMNMJemmvNW/J6UsM0kr+lGrN9JJ981is0kccLxF/57D6ftWQ9F6lb 2MKLK7Ldo25cHBH3q6Ifa74adQdGzINSAt5H5Ij5X+xppGivaOD/AMw+5qW1vra+1FjHd3Ul3Cv6 RKc7agjdqWOCOaVDVQ8CSBVALcZqhI8P1ZGT34prNeATYz71LWkVvdWhczqr9vTI5qiO9UE5D9z3 HvTiytY7i4kWaUemo4HzTa8t3gmURR7k7ZHtQ53kjCIiKC3dwKCQSwk53SBVB+k5zxTe6t9siFWy q/qxTJpJ4pthfcnfnsKeQzgqicAe7e1TQkbbSzcwepBMAw9h3obMkwMMqhfYv2OaaIDbSfyHK85w PerSSvIzFhg/eqL3LTmMiFN6ocUJHldSWULn3HtTyz1IWylAqn5yKLLOblAfTRSPZRisNaRcUzru UEkA8/NOrWf1W2u20+1U8KOS6oY5vfPIpvchrRgWj3OeP2rVZO+N78nNCKjYT2+aq1kYMCQWYjt7 Uhj6LFS2Afc02uySrF1O8bSe1Cnu47Nn3qrDO36uMUqMgLvLA89qyHpa40NbiX+OwB7djlf3ppGO W8V5qKmKytZbhyc/ylzxT6WxlswiXELwykfolGDU9F1d/wAI6rNcaAUME42qHGcD7UjU9c/4gi/N 3R3XY/UW96aaY7CkIm2zHIHcipHV1gSwhaz+oHvTBvTdyVHI9hQXDxpsVyV+KaQq2myrB+2Pekv6 jEKBknsaGsbAfSw4NDkuGjVgZQ0vwO4ppNDMSqHI5xTO9Y3LoUXYgGCo9/vSjcJlSshbj6gR70bB MSPjKsfimmtDQalqNnA8ME7lMYwzZpaa1dtZxiaJZXzjJ70MvsUgAKe/NN8vIVCxtKc/0HGKmxJy 3U10q5RF/amot2Sfcx+juQKd20MKwoVky3dgfahs4lJx+1U0HGFZ2ONuaTdxrKIwMuexNLKFQxPt Vom9Fiw5LD3qhzp2kSXH1K6KnbOeRSp+nmtoZRJhi7ZBFITU1s0IZcn7VYaq1wuCxKg1FDW2eIog kICnhKOwKSq/6Z1/S1U8oPYE4HtVSksoGMgVUHl1e+kTfOFn29s+9M7m6/NAM6gN8DtRxIq4DLx8 U1laNuFG3n5oAMOAcBz8DvVKTj6eG9xRmVVUyLjcOQBVoH9Ueo6Y+aGgJFC/WrZH/ak2nqxTFo3O HHGGxtNPGEZC+jhlb2pLRrESqgAGhoaLVp4B6Tkk/wConvRRcKzBlHHc/emrRBxwMj/VVwE2kMeP gUBmuQrrsX6PkUX87KqFSe9Ml3QyADmL3pRGMEcigc72bHOf/NFSByu7GOfem8IIbCnGfY06e7CR jI9qBLHDZxzSmYKAduc/FNWkeQ+9FhQlDkn+5oL7Pb3o6aU10qyMyj7E80Jz6jBGyB7MDS1nZM9j t4zWdi5sXhLLGwRf9VNZUkh7yFx7Zp07idCkxPpnvtPakPYQMwaNpCwGMMcitACTyCIbpGZewUji lrOSME9quVHplMHg96AAaCjLv4xzTnp21kudbsY9uQZ1zn96agYcZ4qb6CJuutdNt/8A2/XUsR+9 eTny1i68Xt67+B+lC16Isl3KBsUlQee1SOtOpuZjHyhJB/ek+FVrDa9NKqsNwRef7ULVGEbyrnOW J4rh+Pj3t25bqMP6iQflCf8AqGKyLoG3/wDSPn6vesZ6gnDWxHb6hwazLomNFsMByGZcnHtX0c50 +dj7ZXo8atqt0c/UoG3FYf17ITfvz9OKyvpxg817KTyCADWE9czCSaZgfpXIrt+PN2Lz78Wh+v5n VblYzyQe1cveILhoWA4Pc4rpPr26CNPn4rmXr6RT6g7Yr6efWL89Z5ZNM3MpSaZcfqNVGp9PcBuZ ewpFz9V1KzH6R2pcTYyqg8+9fLy9vtcWOsYsWLDLdzVZBXg496WyKSqngmlLpsvB/p96xHcERqy7 hzx/aksxLEfppx6LRkqR9HxQxGCyn9I+9KAugZcMCfnFSvS0f5rW7S2A/lhxwRzQYrcbW3E8+4qV 6Ht/T6ltNwzlsZPxW+PvJzzvTfNzZvFBGuRwAAW7dqxHUi3rvgjAPt81sPWbFP4IqSHDDGftWvtS CsSIsbV7kdzX1cK8ldmEhgMg0tgz42DcPtQ5AV4yAKvG7QoNrfVXBVo0lLLvXHxTooQR7fYUmJ2Z Cz5JpbSDJI5+cUVRc9u4PtQd5LHAAqxJwSeKtGrPLuBH6cVELMj5BBwPcVQy+Se1WK44zVIcDGDn 4pF0uXx2q6yKc7jwO2KsVHP39qS8Y4waoKZVbAAx96sGz/erYRVGeTSGJHv9I7UBC4TG73qsgrtb 39qEPr98/Y0sYBG45x7igHMcn/VRF2yAk9virSbccDFCJ9MEg5HxVFMSGxnPxSNpAGTuPvVi2MZ7 0lyqnlgCa0LsyqBleaG8wY4T6VAyRVsk7vehurN/y/1djn2q7B/zETjHvQJXypKVadUChFGGHcig rlpOThfgVpgNwR9RGT81RnIX6RgUuW6D/Rsx+1Bwc47UWB8s5IHBpYkVQcnmroMEj2oUoUISwGaw qrh2PCcmm0pkI7k0URu6Zj5pKwzKuXI59qKtFG5A+rk+1EYGMHHf71fAUbv6x7VX6+9A3O5uBkLR FAUZ9/g0YoFQZxjt96GAGbZ7H3oKWV8Eoo2D3p3Fc+iituy3xTptOtrHRWna6SWUtj0V7/vUTBPE 8yMrBvYg0BdU1CS8/LxSMZIYuBk5xnvRp1t0gDcyyHhAPimIWUySfQpTPFWN5NCzEIBjitM7WZCJ hv8AjtVenCMfThjx9qXbfzlLu2TVrhljVRtD7TkCpVhvcSHaBtBGcftUfcOVkYqQdvan7TEjOwc+ 1Rmqp+XVSOd5wPualVB6sqtIHQlWPcCnfTbEThQc896b6r/6WECRlVm/pxzV+mX/APVx4J4+a4Zt ts6I5hugx5XaMiuhvCpy01sQcEqRxXOOlMTIef6RW/vCq7bdabQOXVefivByXT6P4+XbmL8U7TmX WOkr3H0AiLH3+a4TkiWGzCht0jOx/avQr8VGMHovp67Th4tT9PP2xXnvKAka4bf/AFMfjNamW5p5 sv50iBpBGAsYYH3JxVTMQABgVZU3AYJ298GkPGU5JzWmi1t1lBJJ3KKG9tuBJOCO2Pen9vdRxQke mCzdyabbwWAb5q6AobUtJj4HerSRlFIDAjOe9HluCwcKNhxgYphDCEYMXJ+RT7Zq7KzthR9XYgUe PTocLktuPcZpzbR5G3Cpjnd7mncUe/a2B96v2lulrG3Nm2UJweOTT+0t2mc5BJz7UIRrGeTuB7fF TGkSrbukgAO1s4PvXbGOFqyW7W80alSC3+oU79EDDZww4pxe6g19fQyzBMk4CqKS8BL/AEjIrpp5 M8u9JGyjG1TjJ+9S0CExbgP7GmOm2zOAG4NTUVmYgN31fFdpE3JCYYQZAR8djTon0k255NJAKqTj vSgx3YGP711ePK7qgDkjAFJfJPptyD7illdwG3vVhKscTE4BFE0XFI0Y2n6efaqkGMtvJz3Bpqlz hSFG7Hz3q5nxtJ9+9BUgLyBccmktaBxg/S3xRHYIQx/V7VY3GDuYdu5oEJbehnc2R71UG0sxPbPe iuXOcxmRMf08E01huoxd7ChjY9laqmjwiNMEjcPYUm5khCExIVqgwEpfO4H2+KqQ71ICjb9qqGrA Oc96BJGAx4wPtRpQYzkdvcUIMWyc5pWpTG4UBinfHvQIoVcgspIp47CRvoGQe5q2AqdwAKxp0lMZ YVwcJjBximrQqGXIyPipJyrcjk0n0QQWOMVnTUvaJuLTMhK8D4ptb2plD71O0VNlFLcgDHakOpjj kBxuPAHzXOxuXtASxcN7L8im/o47jIqSnXI2kY/amhY52Y7f71zs06QwnUhlHue1CY4X6vqI7inl 1EGCFf1LTOVMKG/qPeudbCYgsMDApSpkHn+1C2tn9Q4ozNlVXue+asXZJkGO3fvVZ3L2/uKRj6d3 wcGqActwRj4FNooA8HOc/NKRtv3weM0rZuUkggYzQRwO/FKq7fUcjg59qTsABI4yf8UoOo7VRY5O ex+KyLFPUHJ/vRIrIzh9rhAo+O9JL/Tkf4pJDEj6io98UNBFioG4cDgUIo0vbgfFOXXge9IW6ELj IoujjS+lNS1edo7PT57kAbnlVDtUfc1FzQrFfXNrG5MsH6zjsazjpzxT1LpSC7TT3fZPGYmiP6Dn 3/esNjjaYyzOP50rl3PyTRkmOR1cFT+n71JwE3P0uCdwzj70wtrRsAsM54rK9B6av71HMFq07IMk j2Fak2v/AGHp1iI5yhUgnt9qyzT7f0wvAzj3FNNJtWkz6oy6nB+1ZA8KwKMKO3Oa9OMcLUxo8yWr rIsaFlYOA3Y49qnOsOpn6uu4LmWyispYovS9OHG0/f8AesTtnLIvYgH2qf0+BcruAIrvP9Mzom3h IRQc8e9OFiKLuzg/NOrlo41AHao68vcRn2xUN7Mb/UPRLLkYHv8ANYrqmrI4Ks45NV1Fq4i34IIH xWruoOpikxK5781xyz01rbefRug9N6hrWlf8S+nJoTSj80jNglf3pv56PDbwf6U6Y0rqLwxuoIrq TENxbRzh9u77VzxYw9XdT6dqF5Ysxsocj1Jj9OP9I+9SCdI2+i9IQazroEwucslu2SAR8158r5O2 E8WL9LeF9/rVrHH+ZKF23CZxgAVJa90FcaFjZqkN7HEMOuQOab6x4tTC0jsLKxkt4WXBkH9NYkl3 PLcPK00kgfurHiuT0T5H4jR17DcO5pEmEUkDG34pQZeMjBx2FC3DOMZz80bPLWVYCHYKwBzg1J6j rtrepHuhUkDBwMVjsSH1CQT9ye1CuZQrbRn9x71K3EpPJHk4QDPYilWmrQWIYSIHYjAGe1Y8k7h2 bJZRSBli5bO4+9ZaSUsyzMzIg+o5plcTneAF2kewNBLNGV2kgGqgQTThd5BJ5JotWl3qhCkBjznN CtwzuDwMHn71JS6NAibmlLGmUoS3cKG+jNSFOdgL9jn4A7UGWMpIoV8Z/wBqPb6hGzFHUKzDCmkS qYzsY/Ue1VDJrZI5907mQH2qU0nT7NnlEse8SY3DOO1XtYrV0xKwD55zQpblLeU7KB/qFlZxLFHG PSVTuAJzmmTczbsnj3pUcn5nYzDcoPf4qxBa4OzhfigdQxxzRqZckA8k09QWlvERaDJ9x71HSO8Z APEPuKGsVyyvLbA4/wByK52NzaRTc36oyOfiiwwvNcPDCA5A3MSe1IBzbMwkfeVyM0WGRYLQOoCy OPrYVGxiqxHA7gc1UWAR6bcZposoDjI3ClG4SBWIUls9qCUaEj6i37U806OM3AZzjIqES8kZlXYe akorjAJ7Sg4FF7Sc0m3eB+mnGnOHOc/SRwPk1HBi8Yycn3p3ZP6ZYAduRSJUvb7VG1mI57U8UYXa pzUZa3CyA/8Ac1KxbFYA1rbEgHqSLnAowkUoFaMknsxFKZUXH1jmiRiRiNxBjHYUDV3OCCMfamjy emCoHBqVuCjE8DtUZdY2eoGH01aGUi5ALHgHtTK5mUNtX6eaJJN6mFSOTLnj6Tim86l5NmPqA5+a z6AmXcSoz+9DlXPDDBFFVnCkDk5q6u3BdR+1NtaRb2qKSZDtX703lW2RPTTnd7/FPNXQzneRhR/S KjoowHG7AUe9RV/yzKAsjAooyMUgoFHLZBHAp1GmEfgOGplcMQqoE2sDgCgW93hdi/UKbENcBlxv I/pz3paJ6jAZG8+1VFHG8p9SUQj3NANbKZf5t1pl7bxrj+akRZD/AHpUkqyvld4x/WwxW7LrxqsY /Di36ftbaN7pVCtPIuVI+a1Rc6RfX1lcahDayzWsRyzqPpA9z+1GN9o650+SGz/MFf5Z7sKYwqFl jMiho2PJNZjBe202gxIwAwMjd71jF1GEmbOAg7Ci2f0tLN6hZE+mIH6VFWMOcYGT8VeDbsPGMnIz R4pQucjtUrQcEhjDAgY7CgZVHZSofd3zS7iUZwPf4oSCdrqKCC3M00xCoAOWP2qgW1I32xwGND2B NJa3mjl9XdtUD9INZv1N4Uaj4f6Za3uvXSNLeqHhto/1IPvWEROJ2YKxIzjms2k2LFKU+ojA9gfe kzOzzDYMN9+1EEckuVcgAcim15I1vbSqpDlhw3uKU2fQ6Jcav6VpaOGuZWxsB5JrbnUmg6R4E+H8 FtqVul7r+qLuCSH6hn3+1RPl28N7jX9R/wCIJLlEtNJ/mSrIwBcd6wPxQ6vvvErxOvdVmzNp1tMb eEn9KqOBitz0zvtDRXfrxBnUjJJwfalRShpgmM5PYVeZRHNtxuWl2eEu2bG3jvUdEmwitHjhhYtJ KOQRwKbzv+WYwvgv7kc1PrBod3Y259WWPVAT6pz/AC8Vj+pwLBehFcOAeGHY0T7AkkkePEcQl5wc dxTq+Sa1tYYxBJB6pALSrjP7UbQJ47O7aWQAhXDYPvisx8YvFiLxGt9GtbXR4dOhsABJLEuC5HvU 9M70wNk9MbCPqXg/vTjC5wzYOKFcxiWb10kDRP8AUFH9Jo0Uce0h3DMe1GobzvGmCW98kGpK16Z1 vUtJOuWFrbjSI8hp5XwSR7YqKmWJdzOm/Hb70dLu9k08WXrulgefy2foBqm0lp/U2mWelusmki5v ZhgTscbP2FRs/rekXmRlbuARjim9xA9jJACPUAOR9qc3+q6hrMixx27BAAN+OMUQyYl0/V3+KRbj E6l1LRqfqA9xTo24CELw6cMvxQ7YmMkJwSD396DafTs+idRdGareDQ44rO0iKRT7vqaTHBNamgDL apG55Ybia3C3TsHSHl8u5TcBtS1F9yw54X9hWmC7C3tEOGkCfU49zRgeSIRx5U5IParY3tnG3jOK So2qWPIqyqxbfjija+WbDK2Pk0ZVyNrngew96EylRtxnPuKIo2EIMFvmgUpB4ZcY/wB6uX4HH1A1 dXLOFDKHX2NJlbaxwQT70CJVxKWGM/7U56ams9F1YXF7b/nd6MPRLYFNt4cZUYXsc1SIs3J4HsaJ ofXL/Tri8WawgFq3vF3B+9NoHJkw3OfYdhVprS2VGKvyPish8LuldD606ui0zWtTfS9LmHM4OCMf eidMfmb02IdsAH296bk+o4dRx7k1OeImh6R031Pd6Vot/wDxXT4H9OO49z+9RMdqDH9TYHwPan/R Tm1RRA0wAdM7Tx70FpLcs6fltn+smpHpDRY9W1VLdr+O1QtktP8AoWl3dpAnVdxpL3UM1pkKl3F+ lj7iiIiB7QWzRhdxxxJQ4wVj+o5Oe9TGuaRaaFeS2Nq/rxJgiX5zUZHGF4IyDQLRVCLn6j+/ajJb xqp92JyKb49By3BB7ChtK4XgfUec/FAR0E9xtHDr7Gk3UQZFMv1FTkKPY1b12eUKR9fuw7mnezMO cfWPY0DNYS31O2XPYUj60iJ/VITyfgU6SM+sD7+3xQ2fO7an15waA0Onx3EY3TGJmIXeO4+ac67p FlpesS21hqD6pboqkXLJtLEjJGPsaFFbSMoPbHNKaBscEbh3A70YJRd2R2IFGjiyoyCQaLYx7X3E A8cg1Ium/GFAU96FoVvZbIyzqCW/T9qs9qsLAg5NSdqoEDYwT7farGAN3UHNWMbRyGVyMdgO2aUs WMv2PsKkEtOM8LjvSXt+OMFh2BpGdiW1t6qBV+o4/vRPyh3BWXAXuKTbswb6SUb7Udy/6i2Tjv8A NVztCeMA49qKjjaMKOOPvQjnapI5FXYFPj9qM7FIUAbjzS7d/ScgEAt2oWTIFGAM+9FhUjMJ2s3+ rHajKmxJu3jaRRLoxxxRbf1H5pH6LjYSD8k9qS6CZSByV4BoMlvOiL2HpiTqONVNlGBv5+fgVi9t IttMzuSwZOB+9SV/c6wen/ysV+WgP67Yn6TUKEnWOMypiTHtQOVXCkZyD8dxSZjtYEDv3oSmRVLf pJ9qJcqyLGRyf6sU00sBlt5PA7iiM6ugI7GhIxbjAGe/3pMqnt2X7UU9tp205ZJYlVpG/l884HzT aZ2K5zyfehhdvAY4PzS4beaW2uJQvqRwcswHaiaDWQqcg8nvijRAzBt2dvYU3DoG4GTTxUjt0DmQ szd8+1DQT22DjJwD7VeaIxRI2zfGThs+1Le4DOcAbavJdRg5LnOMY9qAEpUKQP0jtmkInrISDtZf b5oztGwyPaiafbvd3IjiA9RuFHyaGjKX+XMu/wClPY/em8l/ctOoAV+eARjipa/kiETRtFukU7XH wajwA9/HKYSgAwA3ahpL3d9avpSWw04fm85NyW9vjFQ7IfU3g4b/AGo9yzpKZDymOFpqbgMMYIP2 op4Z0ktAEUiUnBwcU3DSr+kAbeD96G8u1wf7cU9064sneUXnqlfTOxYuCW9v7UTSNurmZlBC5A/0 +1OtcsZdFuY7O89Q3rRq+xhxtYZGKbWtwUDCYAOR2HanM19LfzrNdTtczqAqPIeQB2GaoPHpMUEC +pIY2YZweaWLH8v/AMzDjvke1MpbqaVifUX7lvej3xnsNOF0z7ouA22jRzqGo6faWH8gGW5xhyy8 Kfmoi59C0s7aUn1LmaQK49gCcA05v4oU0tD6hafgkHnNG0/QEvtCl1OQkwowCgcHcDkD/NREp1b0 RfdIi2SdJBc3Cq8ACZLAjPArHReXUN6sEm5Jw22QEYP96zLVPGjqDV73R7/ULWzlOnRiG2wufpHu fvWG6nqcuta1ealKojnuGLsF7ZNBK22pRRxyemphmPGfmpzo3QulZumdcfUp2j1hsm3dTjB/asPs HF5duGP0qp5b3NAt7iS3lR3VV2nkGiaIhtTGpMhZmBxux/vTiCMlQTz96eve/m4JMKg3HjHxTAXP p8Y47YoaLnX+WVH1NTSVgSAWC8U4STeQSeT3xR20RLmzkljzvB4+9DtGx4Jx8UeKGZVYyhS3cDNC WCSEem4247E1eQELw3I7g0U6tdRljtZkULuI4BHagRMG+okFvcfFN0yFdsYPzS4Dm2E23G4kfvQO ABM7RAYDjvUq3V15b6E2gx7PyWckHuTUN6Lk7t/+KssG6TeqhiRyx9qAkmHcNwp9mNFubJorbe7i Q44oE0TMgUkADmhxSMgCuSw9gaA1o7RWrSFQytwPtQxG3pZPcnvQnuzZMVZcxP3GOxqT1DSJNKmg eVHVp4RJGre4PvQMJfpjUjGfmkhd3sM/FEktbiHd68Ri91B96ukSG2aTOJAcD9qCxQBRuOQOy0At 6L4b61+PiiAkPycqw7/FOFjWWMxptcju3vQBX1oSVkjZQwyNwxxSNgiYgDK/NFlnuJ5CZXLlAFBb 4oPZgM5B70BfVS3nidhhPcfNXNwGvhLFlcf6hQp3K+hgBtj5Ib3+1Pdcvf4tqsl2I47bKqvpRj6e PegbyAPKWxu5yee9Cnga92pGxhCHOAeD+9Giid2JAz+/Aq7wvHkEY+QKBKRlbZlZt7Bs598U5hij lUZfGR2pCneoAXj3NKwoIXHI7GgTKVhGH9vjvV0ZXI2g896VHuySduf+qrLvwzLjjvmgSxYnJHGa UhHPsKuOUG79R7fFLVjGxGFYUCZJDFEDgMPbBpFlPPZMZIpCEP6kzwRSR/MbBVUx2xSwAGz/ALUB IpGuZJWuDmPBwD7U1kxGgCj6ffNOxhiE9z704j0drqOXDKDGu7HyaCLRHlBCr2FKtrcFjjIwMkHi qto7hylvH/Lu3dUTf+kZOBWWeIfhvq/hhqthbapJDO17CJUeI5UZGcUGKwAOrfTTSUuhAYZHwKeG Vg2yMAMKakSFuTgnvQEhljMRk2l2zt24rMNR8L30PoG26mvNQW3vbpiBYHGSPY1jPSt3DN1JYwXi CO1SQs7fNS/VmqPfXRjkuHuoomIiRzlVHtgVYlQ1qgmCED6h3JoN5IkCvsbcxYYApRuyEV1whHG3 5oxFtKoMIwffNRT3VJ5NStV3MHKDkjjNRasir+YQ7ZkIOD8g8EVTrjj1CFPcClOizAZBAXBAHvii Mkt7Z/ELU47vqzqVrGEIFUv9W7A45PaojX9Nj0e/Nra3Ed1Ep+mZGzuX5oWu3T9VzW8moWNvZpbr sSK3GFYfJ+TUl0xfabpOm6lDJZRyNLHtttwztb5onj3tjTsVRjufYhwW9hTy5E1jbwymJ1hkHEjD g/3qQktA+msHj2jufhqzbqjqjSOoOntI0e2tPT9G1CO+Ozf/AE0WsAjjZyN/BxkU9SD6Thdw+RQx HFbQBA+WU7dx/wBqMbg222POzeOc0TZq1r+aYnflRwRmpv8AjWqahokOjSyJ+Utm9SJcfVx7ZqK/ INbAyq6PF/Xt9qPBuV3CfVuQ/V8UWmyn1g8jDBDf70VWmgkSeJcunKk+xocMDiBhnec55o4kxAoJ wcUSAzy/mHeSYfXI25sn3qojjjHA7YpDE55G4UpXOCdv6aNCysrKc8N8ihhfpUZPPvVkbOecZpQG B3z9qBCEsCEfaR+rFWAMqH3NFUIjMRwT3PzVBNy7oztx3+9AmFVfGRg9jmrtEQ+AcfeqzmQsO3xT mJlk+k4Q/JoGjKecHIPeqWBiocjCk4GafTLFHljIrFf6R703N3+cbdjaByF+KBAjK44O33PxRo5N gbZ7j/NKYjb8g03LBm+k4CntQJZdx3HjP+1UkLylQhCY/q+aqQtnI5z2WrohnUgHaPfFBcAJMqOp LA/2NP1u5YWZYiURhzQAdiBccL7+9WVJJP0n6TQUZM8RYwvJNXMuVz3qiqwcbTkjnHvSDISwVFz9 6CpAHXcTzj296EUwQAP3FGiUuWGKJHBuYnOce1TsN5G2DBbaWq6fqHOSO1OktYZHV5UZkX+mmspR JT6YJRjgL8VAo/QctyT2FIWJxnI2j2zTpkxtc4P2qxQuruWy3sPYVYBrj+o8/aq5mhKKcAHkUoKY z9Qz9qVjJyo25p2BHGMsAqCrK4TIByD2pckRIIPIpCK24ZAwKor0+xA4+fenNnqF/pcjyWE5t5JF MbN/0/FIbkYAGapIyVzkfegFlm+nO8k5Zvk05S3zjjPFWSAKw2g4NOUhkYkJgkDOPtQNvRRCdwwR 2oqKqrkihP6jMTkYFLUMEG/HNAho8Aj+9IaMb8YwPijOAGGD2FJBAHH+TRFjvcKPj4pMyGSQBv8A IpbTKowoJJ7VcMuOe/vTQG8QZskUkRZOeMjsaKTltv8AvV2+ggEZ/airAtjng+9WLHGSeD71YtuJ PsKQH25z9Q+KAnq5IHse9VnA+ngimh1C0aYpvLN8BTTyG3uJ7czLaOsQP6z7ikAzt5I+pjVypMSF ucHGKr1QBuGB7Gr7vVcEHBAzj2qaFzAp5wMY96SMAn6cCr+oxOSOPihmTBbAzV2KZfVkyRxj54pT sSo4zSWUsdu7DY7UdY2T6iRge1AJVYDBBwfY+1W4Vfp70X1WOffFIZhkLjGe5FBSKFJx3q4b2FVs cDO3PtkVdIzt+oc+1BcMWlCt3Iqmjw2Bx9xVkXC7s5b5NLDfPJoBhMMAO4q8YxJ9RyPvSn4zjuPe rhTjJwSaBDDa5BGVq6sCf/opMxKrzQ1n2nOKCpWIiDE9zik2xyeOcfFEjhad1CDezHAShTxS6NJI s/8AIlz9KkZzQOnXahY/2+1N5P5cbOZBgc4JxVvzYuoVDEKx78VlfRWvaHoiXsGs6X/Eo5xlJsZ9 P7UGKRX8stpFbkZto3Mq5+T71SEE8jdznHxTm+ZHu5hboEt2YlUPsvxQZh6cRK8PQIgMtlcmeMsn HDoxBzRJ9QmmRhnLN/UWpCMXgG7O+hbDknGRRBbSOCyUGRfWkY7i+expvdrIznJ3+4Y+1FWP6RwS PmiC2Zj33LiqptbBFw0qgsOxIzii3FykzlFUqwGSau4ESYaIuBxxV0kGMeng/B71BeMBUU9ye9LR +MZx8fahBiDjgZpJQs5x3oKk5PAH3prlVuI0YZ3HGKdtH+k57d6S0Bud8qpsaIZGfc0GxfCbw60j xE0nqOaC0ZtdsFBhkLkLj3+msI1/QLzSZ43U7Yy22RTWTeD/AIu3vhxYa3GLWB7jUl2eqw/QMYNR PUuufxOCFQdxJLFu+40ZlQMS75GxyDVXSMFJCjOe1LUCGIkkqSf8U2ursbyM80aPOnOl9Y6mvDZ6 RbRXF3J+mOR9tZ5H5fOsrG1e4vmsbNlXJRp8tj3wDWuINZvNNKXGn3ElpdIcpNEcEVOzeJmvX1us d5KZZB3kf9Ro1Edqmi/w2ZhM4aROeKYw3UmMnDL7Cr3l7das7uMMD8UiKH0sDH1UZOvVE+CRgn2p lcgsxBBx3Io2/a2EOG/7VS99zHPzn3q7WFnUnRAytIQP0gsSB/asr8POqdM0fV9Qn1eWREnhCKY0 zk/esRdE2jn+1VCrZ3rgoO+KsrLMNd1DSNQhkEEO+bJw/biscigC7gvP2HGar1I8j0hhcYINI+pS dp7e4rdpou5iMkgVDtGOw96lujusNU8OddttTsWSKXs29N25fj7VFRs5YD9JJ71PwQ6Nq0Jjn/MC +jHfP8s1OmWSdV+IMfV9xc6reOBfXAAYIvHFYjDZaRNFJPJqE0N5/RAI8q/96pbDTVs5UPqtOOU2 nC/3qNBYLgEE/FaJ0ntG0az1Kw1CWeRYZrcAwqTjeT3qKv8ATZISCHDE/FIRyUzvWTPdBxinirkK z/THii7RwRoznuB7UaNwwJAO72NOJ7YvGXiw2TgCm8cckMvJAUVnQcXUJheMAH6lzzRSDtByT9s0 ue4WcIXYFh8U2a8Q5C/tWjaxBwT3Gexq2CuM8mrxSb93GRVg2CcrRCm/lnnsaVIFBUEdx/TSM5z7 n4pUAKyKWPGaiwAGJZyCW3YxyPerTKWcJHgjH1H4rI4ETXRLC8MUJgBKuo5f96j59PFqx2YwRk4q U2j2two3dxjGTQWwhAFKuWdcgDgUBXeQlQnqY7qPas1uKklXJC03mkG3GBmnElthNxG0+1N5Vt1I /MbiuQCF74rLQYRzH6iIVB7sKU8iugVRjH+9Z9c9C9MtYQtpuuSTF0DNFu7N7isZvOkjbqZBKSn2 NZamWmOyphiQP70mZQsLNjDfajTW3pgjcSM9zQoxx8/Oaj0z0Cm0wAuP8VUVqZ/pQ4JpbhBgDsfa kCUxElDg/NNNA3mlGGH8xO5aOM52j3plOm5xKpxuGcY7U8nu3lXa3K/BpqJMHtnPt7VlolIMgtg0 hpHjc4XOO1O45yFx3pvsaUtn6QO1a7NFLIbhdrL2+KJ6AIO0beKQiFcNu9s0QTl5Ao9+9ZDR0IOD Si5jXGcj3olwuzKrhiO5pvPGVQtk5I/tVgNFNuKx7Rvb+qhO7C9S2I3MecikLIbeJVAySP1fFVCW jf1FO5vtV0L3Nss0rHO114FVGkkClQC0o/qFJYlnZvn+mirI4jHJAbhj9qrIMy3QiDyqyoT+ocg0 uKVlIPLe1SF1c/mIlhU4jAwQPemZCxnC/p981k2TNberHvC5OaSk0tsV2puqStDG8BV/3qc0PpWT WrCW8TAiVsAU6GOR6pIV9MxkZ5qmkLMQP3xUhqlmunX8UBIkZ+5HsKyyTw16VTRoNVHUTy3bg+pZ o2MGm1ka+MBnRmySpPeq9CTYF24UdiPepOaaC2vPQiAkgPHarvfpbH6FBK9latFRsUm2bAGWHBH3 p9OgaJpCSJMZxQmuY2uorlI1Az9Ske9WutQE7SkJsU8ZNDYMdu86iSNCSOwz3oqXcqBt8Z+nuB7U 0s76e2VlRgR9/asg6It9K1q4uoda1RNNXblJScbz8Vg2hGmkuLjcoKxgd6tfTypLAkcRnZiFwOSa y/rLQNO0SWyTT71b63kUlpUOQDWPQvJYSrdQ43ocgN7VpWVL05+Q06F7lMSOM4PtWLX6pFcMx+oA 8A+9Pr7q291XmQgBRgiomeYy5LRMwznPsKaW6N5Y5ELHb9Lc/tQjPKuM4KDupp9FBO8RlmyE9hQZ YgvJU471WCNOZNwkf6wj7sf+KcX1yLiZZVj2KnG0GgRREMBEMA8kUp42J+kbVPfIou10kxIxAwO+ KO0mUDEAmm2DDJscbmIzS3jEjFFY5FFIAjdiD+/FZDZ3HTsGnxu9kPzgOJJS2Sw/aoBYxG36SWoI h3y4GPuTQZBq99ptw8ctpZpbRBfTMffP3oqeH2tX9omoQ2+zTl5LNxgVjwcRfrAbBzj2qet+tNQa EQyahMtsAAIc/TUv+hG6jo0tov8AMGDTGBZIpC4JA+Kmr3WReBRJhqjyQyMQKkiQMBDuy2GPJq1t hJyWBKkcY+aVZtD6ytIP5Sg7qkZms9qS2+4RtyCa0plMgK5ApMUO4jnB9s1eSTJPORSww24kI47E UC1kt4g8TxCSU/1Z4pugV2bam0A+9C9KQqItwABzuPeixr6iby2xV7/NARGOxuOc80Rm2nbjBx70 2Zx2DHn496MlxgAMu7HfHegrl+QQR96ELcO+Dx+9HLeoSVj9OIchvk0F8zMQPpHzQFXS+AQ/FJkt BC4BBKngjNXaRlwq8iqWbccMcmgd2ujxSH1Y5REo/oFJvLGLIbcM/wDSaAsec/zNn2FJ2CPDKec9 hQLVY4AAoPfGKr+W+foxSnDMDjH2+aGz8he9Apk+nCrwfarANsKgZUdjVo3I5zzSkbcGPbntQ0sM EEYxjsM0ZVVshhkY5oUNo13cbEIRz7mpv+Atp0AZ33FhzWdrELlVHHAHsaIsoJ28ZPb71UiI7YAI FCKAZVhz/SRWkGY5xGRyKG03O0niqUlu55HvQ3DMR2IB9qmgWM+oGV22cUMSvIoUSFVU/wCaXuGO cE+9DT9RAHeqCNPjI479qQshL4arMqk9vvn71RDZyME0Frt8BB2yay3wht1u/EbToymUMicj35rD 5FYgM3O3v9q2T5dLUXnibo6EblEm5v8AxXz/AMq6xjvxTt6zdC2sUeiTAHaUjX/tUJqYbc53ZJqZ 0SP09BmaN9p+kEfIxUBqZ2c7v2p+M1zdsT1lQpXPP1ZrYXRirHYOduPozz7isA1LE8ihvbtWxOnN sOkpJngJt+1ezOXbyYaTPTwX8vdyD3zitf8AWL7UmI+D3rPtEkEWk3LY+cGtbdXSlkl3cdzXs/Hx c+e/Fz94gykSze4xXNXXsv1Sc9/auiPEO52XLpkYIrm3rxg0znd/mvoZ3WL4Mm82sJdqNIWGSTwK pHwxz39qFeu0cvOGBPf4qoe+f1Yr5WXt9vCfGH4ZWQFsHnv8URroggKMg+9M9peP6jt+wptLcPEA pGATgftUdIfqrZO85yf8U2uOABnjNFViv0AfT/q+aTIBjnFAWC4V3XI+k+1ZD4bAv1xbGRd0OTkf GO1YujAt9HtWYeGCk6/CcnDZ3Gt8U3m5cnpvTqSZrvQ3RCAQc9+SK15K22PCnt/vWVarcFdOKZP0 jIJ9/tWHzXIdARhCe4NfVxx08ztxT9W4jcfmrSD6uKGWEZIzSS2/JBwRXnUYS4bjIApRkBUMBgZp urEgH5onDLgnGKBfqAZ44PzSe5BU7fmq3b/bFLUgDP3rLSl/UQeKUuDk4/c1ckEckZoTPgBQaFGb 6Dt7nGaSmcgnvVRy7uD37Zq7knFWBa4wcqB8UN4ZHjDlgy/BPNCckjueD2pDEs+SD/aqnYitsO08 fellgCQBxQjKuf0nP3q+4qDjmhSmVdpDdqpY1OOapQHHJxVhGFbOf8UQaKCPcC44+TUrYPo9pFMJ QDIw4zzUHJKrj6jkD2oRK7vpXA/7UCRJHM8hUFRuPBocsvpnCAqf2pcis6bl7DuRQWmYRFC2a2nY DNh+2Se9UWyDgc0h2y3Yiro24cc1qHQRkO7GACfelNMu3k80uSAZ47/BoTIcNxiqkBcscspyv2q6 r+ot7d81TFkRPTGXz/arSMVYnHHuDWdNE5ZEzuAH2NLkOYVKjI+aQ0wl7xBcDGat6jJ9KnKf7ilC ZCQDn9VDjlCucA7viizZZd+M/cUGA7DuJzn2NQHfc6g5xz2FNwkxk9OIZZu2aOHBQexzRY1CjcGO ft70CrHp7V9SB/L2pmjQ4Zl5xTuDpyeFyJ4ghHBzwRT3RepbnR4ZFiuHhVucL71DXfUU2peuWdsl sBuxNBLBLGCQRNMGbHJ9qZaskEJARlYkZyOagAGH6iSAc5owAkyFJCkfPajCyXRVWUd/aiNIXRSc K2ORQjGPpB5A96RJKFkbB4+aVYNDF6gzu/tUfq0oXYCMgds/NPEuQi4z/eo+4n9c7WjJCncCfmix D6jIrwMrYcjtkcih9NyBJ0yvvV9RcwkM0YO8nBPY0Lp2M20wcyb9x7H2rhe2209IkzIoAzkVvbwo mBktF91mUf71oXSpGWVCo42+1br8Jp/5tpwV/nruPzzXg5Y+h+N7am/FItTL4Z6Sx4Ua1yfjivOm 2jSGzkVW3bj7/Fem34m2k/nvBq2YEKy6pvH34rzKt4y1g8uNxAA2j/eufH7cL/JaOX6Qvv8A6qvJ KCpLY4qyxc7jyD7USKyJJBO7dzXdab/qwA3NJmUqCc9qfPaCJFZY2bI4xTWX61yO/Yg1tNhq2+Pk /wB6pY8yD6cH5NVDCxPsPsaKsYU+x+9A6SMohB96cW524XFCjdXXaTzREycYBzVxrnldnIBZiM5x 7U/sGZU5GATxTa2UbQc9/apSytixHYjNd8XlyujmO2YupH1KO3FS1iPr2Fef96BCoX6WBK+5HtUn YW8cc8Thiw2kEn5rvjj08ueW0pbRCJVHBJ+1PHuEVQp/VTNS0CBd29s8ZpaSMpywDAjgfFdY4W7O DzjHKntSVx32/wB6CGKgMDy3t8UdMqhweT3qsrZxkHjPY03uIS44OaPPJG7bSDwM0kzJgYPH3oBo u4AKMferFASy+4+aKJmH6QgJHY0OZ3dlyAP2oaKhga4kVUNZLofTC3PEr7AP1ORxWO2qenJnednu KfajrEsUQt7S4McZXJLcZNak6G++m/CnovStFi1fqfX4nEhGIIv1LWi+vLfTr3r6UdPJnS4Wwr/6 /wC9QUlzdygf+oDx+4LHmnMV6tqqLEm0g5ya567a3PHRc1pLaXAR02GQ8Cn0ug3P8Ilu45IlQfTg sN2f2qPvdWa6KuxLFexNQt5q5SYyM7EKMBQeK1HM/kLOqmQh2Ax270KKaO3Y5TINBgu2vVDjIB/p ojAKWyP71qqtNiVgYzs+2O9C9B2GQNwPfiiSuGHBxQ8yINysR9qy0Gq7BgrjmkSMsq7P0gd6IVeY k+/xQ5IZMEEYX3NZbl7NbklvpXlQO4703jQnAkYkfFOPS2uUAI5qjZ71B37WFYbnswnjVlIZtg7A n3qOkjZGOTg9hxUtJZrnLsXC8jPzShHBLH/MG6Qdsdqxcdty96Y85Y7gRkigTIpUMM81K3tp6Uhc HdG3cU0kwVC7QFzXKx1lR3oepnkCrlQykYxj3o9yAwJVSgPxTQOQwTcR8VluVJaToiaxPDYm6/Jp K3M23O3+1TfWnhyvRQia2ukvHYZaYPnP9qxQzTgFIJFgYH9fvQ55Lp+Jrlp2A9zUZINxLI5/MOCT 8DFXBVV+f3psySO/ALH4+aWyuh+pWDD2NGyy3fjt8UUFdmD+r2oCZyM55FLUEMTjt2xQKDDA4G6r gGcMqjaVpGwsc+9EXKlwW49hQNGfBIIJNKW33Htx70TYDIxHGfmlZ+rAPNAIpghVxx7Z/wB6Mgxh cd/cUB4I5G3FmWUHuKeQIsjISSu3/egPChibd2UVlOg6nLAqiOV0Vu+04yKh7Wza6J2AH9qyXTtI mjRGdRgHiuuEcM0xHHG8atH/AC8Hd+9TumaZFqzDeD+1QPp4bGf7e1S2mSy267lcg54xXqxcp021 qvg7oOk+HMXUel9SJfSswD6e6bXB9/8AFYDBg52jaRxims95NcYDTuD3PPH+Kd2ykjcfjvXT0b2F fI4TdnisW1rUPysTZkHPNTWu6mkMTKTitWdSaoTuKtkY55rlnemsZu9IfqXXdxchsKO/Naz1fqBU umDDIPvUvrd2shdvV/TztPvWCXFydUvZMLsXPC18/K9vVjgzXTPEu+tNMGnwzCGDfuwBwR9x8/eg df8AiLJ1RpdlpyxhEtB9JB71BnQZjFlIjgLndjio97Yw3OJU2n2BrPt2mC0MT3SjcfqzmnTRJbDe R9Puc040+zaSQemNxzjFTlrbR6XqUFzcwx3McRBe2k/S4+9NNIEKssfqxMDH+9WZ0V0ydxp11PJB Lr09xplqLewuHytvH2jPxUTPO0d1sKYP3rQfveJIrIEx96j3cbsMe1UZmk7LsNIjiM7cjac9j71G 4d2WnrduiIf1MBmj63o0+izek6eoSMhqq0ddP2l1IPcVF9RdQ3Uswd3YqowFNTpew1kKSAuuM+1D aBrS9G443jeB9qLHObuwE6oST3PxTaYm5njfefoXaWPtUdC5r55pdinahOAabXivFciB8mQc0f8A hGp3MC3IsLmS1DfS8a5zR7GG61O+jWS3KMjjDkcikjIcdhKqCR12t3A9zSl33ByQV9q250z5cbrr 6xOsRaylpHDu9dVYYAAzxWs9VSK2vbuGOQSrA5QMP6sHGalRHS2Kw/U0uSf6RV4IBkBjkfBpFtLl yMcn59qfpH/JEgIVvg1QuONgSdwC47USPaznHBpvExLHcOR/iqW4aORVCgbu5+KlDm4J3c/UoPOK e6VcCEhzH6qj+jNM5VZU/l8j3PzV7WXZnPGKjcPdSuFvJWeKEQFu4BzQs/Qq9296TCVlLVR/UCo2 gdxWGopGYKNoxzRhKFJ3/Vn3AoMWGODIsf71Jj0IYgCyzMRn6eaKRDJ9W7+n5p5C6s+AMn5qKEg9 QYB21IQEoN/dR7UWJa2yzAcLTuSJYhnHOaiIZfoEue57fFSquIioGZCe+aRaVGPTYu3Ye1P7O8R0 YHJb5+KZlRtwBuzS7QlCxPzVjPpMR2m4Z3YyMiqw6ZCvkD2FIjcOqYPakk+kzbScH5q6AruZn3c4 p7oeirrmoWNqg3SytgoTgf3plNB6i8HOfijadey6TIJFyGA4I9v2piw6N8aOkougPA6wne3skvjO EeWMKzFMfIrkm0u2upp5JF2leR9xU/1d1Xq/UOnx6bPqE01irb/TkORmoeC0CqSuWJAGTWrdkivy 4mlILbT9qbz/AMglMhiPenEquik/pPvmmRKsDgHOck1zbMXwplYEhz3U0G3jaVNxxtJ7jtWS9Nad peqa7arq1wbWyxl3Hz96J1LYaPpvUEtn09M99phG4zewb3AoMSldosL2GauRvk3t9QA4NLvAk0rL nYUPerJAAOZc85xQPbVNNhjM06l2wex7Vjt+YzIVhT+X/SDzipKRlD4A+kd8+9XMMDW5ZsZHagio 4BcxCMnaX4OPas5h8RbzR+kZOnbJo0gkiMUpZMlge/NYaVCv9H0r8ii7VJyePfmjOg4B/wDa+ItL t9Ntij5xVpPUmYFuBjHaiPGjRKqDaFO7n3pW71zgZVRx+9Gg/Rd0TYhkOcYA5oDhkLA7gR33cVO6 B1E+jX6zxWyO9vlgJRw2Rjmo7VLuS/klkkRFjdi5C8dznFQ2aoF2guRtJqa0bqSLRdR0/UPRWZ7F iyIfeoJCgjWOYYLcIR2BpAsy7PlhgcYJq7a0n+t/EXWfEnXE1DVV9OOCP07aFewWoXTdKvb+7jgg kjgaZvqdyML8mlOjRkL+kD4pvJKSjRkbg3v2oQ41iwGi65c2ovFvhENnrjhXJ+P2oUEULKN6eoOx 5pNvYW8TYnYuu04HwfmhmwdELF8KTxzWTSd03qKfSbOeytZpYrecFZFRyOKirwQpEsVs22BBjaPf 7n71YRMUQp3PBJ96cRJDbg8Bj2K/NaZ0bzIrwIVUr9jSFBGSRkinsLyXcQCWzEqeT7ChXNvv4jOD /VRpe0/mfVgfQM1UuboCUcL+3IqQ0DSI7m4k9eUxRxLnk/qoN9dIzGKNMKp4Ye4oI6SJgrbTkkUH ZvYRKCze4qRjkUsE24bGeaZH1IZyqY3nnIqJomTMcixK6p2+gnGTVTWjGRS7GRgOQjYx+9bt8t3l C1fzQ62Ra3KadYWvMl07YOfcCsZ8w3hHF5fvFafoy01JdTVFy87HLA/eremN6rBYWzCVODj3ocuW wqnn5q5yuwALnGdy+9WfZsO0Yk96kaIWVlGP1j5NSln1TqdnYyWcJi/KsPqDICx/vUVsYLkHC/FJ i3Pk4Kr9+KoXGzI8heXd6jZ7dqvdSGNVePDbaQwTkkn7/akSKJV+lsIvfHvQVc61qOrRwW9zO7W0 AKxxhuBmgrEIiBkDHFOraFHHfk0ee0j9MK7YOM5ohoGWNOefsaqN47nKLlPk0nYwALjcBwPvQZGk GQQEjz7UU7jbBEZ59s0mdJLSf0iNygbg/wD4pNmxYBj3zTm4DsSRyo45oArKrL+kbj70FmA/Y96I 0YjC4ptdqxQBSA27JFBkemdEa7r1h+d0mz9ayB2O7nbg+9RupadLpYEE8YimB5KtkVklr4h6lp/S c2hWrLFbTKAZo/1rWJ3l61xOhkZmUAAse/70SlfkUMG73IwaXZRwREMOy/09qVbzocqpJQ9jVTwo 5GMg0ZIuJIJVxDAPUdsFh7UxdG08uZckEHb96NGktqZBGDk80N5jI43jJ9wewqaX2eWM8M9kFhj9 OZ+ST7U1udKvpClyIgttAxLODw1H02zuJ3mMjKiN9K47CnVxJPBZtZb9yEc/BqojRfyahN6gO8Ef 9qcuf/TDAy57/anPTkVppDMlyrSQk5AXk0m8SOWeQxgpETlR8CgbQNwCRnHsaI0DXAJUAc0qGBVA J/xRVg5/WaC0OnbFXjB+aK9o24EHgck/NOkVRt7njtRIggQ8ZPbBozaZLa7eCf2pa2I428t708S3 SRRgYb706jiCuC2AB3qxm0y9CRVzt4HakLavK4JU8/FTUyxyqpjIP2q0C424q6c/JHwWPpSHGc/e pkWEfohyefikEr3GBkd6WWAyM71HbFGbQyAnCjBxSF+p92drCryv9YyPbuKbyTFv0oSwI4FGNnkZ 3DdkAVUsAWMSlgU7ZB5pxe6ZBb6fFd/mFIPBjz9WakOlfDq76m0q/wBbicmwtBlkHdjT0INnWBzh wc+9La5RgoAzx7UEJDcSEJtiRTgE+5pVz+WtVU723/btRkU/zkGW24pbBQoycferWtq9yBIgMijn jtSCf5hV14PfNEUxIcbBuHzTvQrW817U49OsYRPeyNhI843f3plPI2xEjAEYP1Ed6Np+tDpy/ivr OSWG9icNG9A46j0u/wCmtdm0vUbU215EAXTvgGmcM+E44NE1bqC96m1SbUL+Z7q9uBh5ZO5FNCu1 VGcU0HEl7IcqGI+1Ia4LRjdnHtTdP5spQEqf9Rou0A4B7dqNrsT6fB/zS0ijjhKoCD375oXOce1I a5ML7T7igOJY4VTcc5Gaux9Rgw7HsDT7qjpG66c0/SdQlJktLxA4c9gfimNtazXUkrQAPDGuXY9l oEMRKmCcc9xTm21Y2lpPaMQIZgA5Hvio4zJvIBIwe1XUJcRSxycMw+k+4oLpdwO7LBFj5BPejKwk iIA5rI4OkdFm8PZNXfVILbV4pQBak4YisZzhQ2cb+aJQWVo9q7+c0mQA5Z2pb5YncP70k7TgMDii rxSIFxI+xPmnNtqctpKk0UfCtwc9vvTYQwEYIzVpC4z6eAvYj7UD6fE2l6tcpd/lbtGR4gV3b8nk Uu51VdSs1eG3IWIAO4GQDjtmo1Wyy7uwH9qNbXsttbT2sLYs5W3sntu+aBzokqX2sWgvJPQ0/Lep kduKaakYYGcx5ALEAD4p3BBDviMzN6fO7HvUS6tK57/ST+r4okUkhYfT2xUpYaYboSMGCMBxx3pn dWNzpTQCaB42uFDRBv6gexrY/S/g7EdFudS6r6lXRpJoy9rbwMBuHw1Fa71DSxYWKztcK5JxtHNP +itDsesOo7DSrq8GnwTgl7gn6UI7VG6dLa6Y1/mVNQt4ixUP7D5qa6Dlis79NZven7+90abIBtly q/Jqxi9GfWXT8GgdRXGlxXaXSW5+mdDkP+9M5JvWsHhds9tvxQdcWyXXtQvLAubWd8xxk9h96kum 9J/jkk9vn+aI9yj2yKVpGvIY2KcOwwMmiG5uP4ebWOUrEDuZFoF2TFhZSBIWK4HfipSy6Y1O50m6 1eKNBptmN00zcVPZuHVj1Np9j0TfaS9is99dSBllYYKY+DUD+WcWm8uFHzRnMd0gmVQoH9LUi1tR ql56Mr+nCvLfehE7oEmhpZwJcWrfnInDS3e/6WXvjbTHrKHTpxf6pptyZY2O5YCuOftUU9yigpkK ofbg/FSc0tlayQhk3qVyVPb96JoWHQ0tug7PX2uwssrFJbZh+ke3NY+cmTcCRu5BrKtU6w0/VPD2 76bFiVleQPDcgYKc81jJG5UBOVUbRRe1J9JBJ5FOdOvZoIpIjJvUndz7U2kQtj6quYt6bQCuPf5o ok12t0SX4x70B8liM8ezGlWtuLm6ETZQGpjS+mJdcu1sbJla8kP0o1BDxSI0OwDLn3pSANiLPCjN VqFnPpN9c2UoAuLeT032/P2pMSNMm44DDj96AtwPQjRsEBux+avKDGyhc5IycVa8aRrVFf6TEcgU qaT1ZUdPqTaOVoAyszkKzhQTxU3ovR/Uev6Lf6zDY79Oshh5lGcVjWqXGYtiJlg27PxWU9F+KnUH SvT2o9O2rxto+oDMhf8A5gP2+1WJUBdQzWhgm3qzsdxBGcYqQ6i6nu+oWie7I9SGIRIVGPpFQ97K ty3BIweKNDAWUEkcD+9RVQPI0SrLIzv/ANRpw8J9HkHnigYDsm4bWHxTxpo/yhDH3wPmgXog09Z3 OpQtcWwQ/wAsHB3Y45pnYKrrhf5LgkbSc4GaTuYIoOBv7felfkLiJFkdSoPI+9ASaSKZWiUnfGMs SO9DliUWSTr9Tk7cUQEkAHAokSKqYzlTQNXj9NQWcOx+KshyM43U/WyinkWMuE+9ANuqkgHIBxQS HTNnY671Jpun6tObWwlkxI6nH+9OetodO0zqe+sdIcy6ZDgRSMc5qDktQSpB+rvn7UtlEn1E/Uvt nvQXhlGOKXjfgjGaGIZRGQABk8GrJC3qY30BpG3ISq/UO2aRGS6bC5D5/wA0vgsfkdgaujJkDsT7 mgtcA4jHcjtikqPUypOD8U+0XSpuoOooNHt5I4ZJe0s5+gf3p71ZZW3T9vDo+3frdvdEz3CfoaP/ AEighm2wpg8t80jKkjNXZt64C8jvVEAAHH9qClYg8jj5qrWSQPK6SFB7896rIIAPAFXjMaKwXgsc kUCtQ1p76wjspFCrE29JUXDBv3q2o6vq2vT20mqanJfvAvpwlz+lfj70IDJI4HNW9EscZHHuKCzO Gk2Fysme4HFG1G0bTLdJXYStJ2SkqNw2DIx7mlzMbjYT9RUYyfehDc3UcVsC0GJGGARQ3hkjKux3 DHH1c1L6PqY02S5D2kN2Jo9g9UZ9P7io6eAyMzDhj2x7UUlotibngmlz2EKFzj5wKkbPQryfRX1a BV/h8bbZC52uD/8AGpjws8RIOgOqFmvITc2zj0X3LnaPmleIes2Gr9S6hPo0hh0ycBhEp4J96naM YcruOFyvyKXBeZVtqd+CcVextmks55VHEa8A1a3d/wAsCVwrDkVQS4G6IkHJ9qFDCZfTJPK8j7Uq NvRwuPp9qk9P/L/m0e4ICe4oI7LvPJuZjgcDPFWj3Iykn3yPtR9UaIajK1vn0G4xTcQzRW4meN/S HG4jjNGaO6q6sTwM5J+aVJKkpywJZeKH/wCyCOScHApfqHaV2j9/mi7FtZdkUkWfok7g050i1Z1k RMhe5zUc4/SzMMH2FObe8eEYibb8/ejJxcxmIkFiik9hQQVYAE/571aWSacAY5HZjSFR2wpB596N DBF9+RirKn04xtqljwxUSjcDyueaXhgRnJooTQ5x781dvoIVP80ZxGbUMrgyM20Be4/er2ltLMWh VAze5oG6R8bidx+9GICLjOAaW8DQSGJxgrR9OtENpPdSuG2nCpmiGixBBjHHtViO/Gc0U7mBYjbk 8D4pSQbzycUDcwJLnjGRVlgS2UFeSaebSgJC5A+aBtzuOw4PAz7UC7qWG30+KRz9ZbbtA5yaktc6 P1Pp3R7bVb2wNvaXP/LYty39qb6HFbtrtlJcLvjjkVnB7ACs68auvB1ld2dtZgppdqoUIo/U496M 21q9LmM7GbKBjjJHanTJGyAxtuGean+ndC/4mjks7eNTfqytBE3/ALhHcVJ+Ilzp93st7PSf4TqF qoS9jUfSXA7iqSsSk2tECpHNIYPFENvJ+KeaQlkbVkmUmRuQDQJmLYRMb1NRrY62TfkmlkbDkZ2/ FNlDQ2u5E9T5AowuZXiET44qlneGD0lGFPtRNgNcyOAyKEIHxTuO6jmijwm1h+s4qNncyS/QGTHs Kdwlx+3tQ2fmFI9MlctuZj9NQcasXyRipKecCBVHBLfVn3oM6JHIUz7ZGaEWkcFFAqwBXJ759qt6 fA2+1EdCO/A+aKQMtj3+5o8aoJF3thff7UBTtfk1I2d1bxWTwzQ+q7MWEh7j7UUFkj3EK29famUk f1++KLnB2rkjPer4yOc5zRFRQ7gBnB+aTGGDEUZGw3AIwKRFwSw4zRNlBHAAP0kdqXBI0BwDhjwT n2pRmV1IYhfvTd9p/Uw257ihNimIQEq3O45qzsJGUAEYos1t6aK4mEmR7+1Ng7IQCMUXsp0/mbc8 1fARSMZFD9Qu5Izxx/aiI+5c4/tRQ02B1Z1+ke9KZULcdjViBuIJAOeauME49vagRjBUfFXJ2duS D71Ziu7vkD3pLZOSDnIoLtyrKP3oMqr9KrLhwQ2MfftRU3LnacMeOfinN9YWlvHA8EpeQ/rA9jQZ 9B4m6LHYW9re9KQSMigNNGACfvQNa6l6R1CxkbTUlsror/yWJIJrXzXEhOEYLxiq0vTbjVLmSOGM zSL9WE7mpBZgrzAKv09+e2aXsIJGCB3zShb3kZfMPpmM8rKOaSJ53JDAds4FUHIVEyVyT7UmZBc3 EfqfRgckcZpIO5R3zVty8788U0HkmmNNE1wNuIByQeaYu7J9bsGB9gKWsrRq4RiA4wR7GrJHwDjt 7UC44jJ9Q4B7iqeMAYPcdjRlJSMtxtzgGmkpZ/sT8UC4h6cbBjl8f2FU0Uq4b1BItIiUg7e/zUjo ui3eu3bw2sUtxIi7iiDOB81IGUmQ2M0lTg4Hej3to9qcd2zgg+1N1LIQqjeW9/in2KDj3zVMxJGB g0plVSSTzSZCCVA7HvVCXB2nncw/xSQolQBQFI7596VLvU4QEpSBkSgEc02JXQNVg0q7V7mMOnu2 Mlaz7T+u9BtpZWs7CO6uJVw5uE3f4zWtdoMecY+4oCu0JDjIxxilmzaR6mC3V5LLHEkG45CqOBUV DvK7Cfo96NLM0vEhOfYGksfT4/pPfFAoNnAB3KPersVwQ3P7VYlY1yvA70OOQuGI5xQXJLnn6V+R VRqFLA5xRVy2CUYD/VVSD6e/J+KAc+doRQAO9PbNysG9QMduaj5mJ2EDPzRTJ6T7BmQd+O1AaaR4 2zkc0E3MjFg6qP2o1tdWvrr60bMoPY9qXrckN66yQRLCRwBH70DNlDgZBDfaqB9JsY596c6NYS6t fizjmit5sbt054o2paW1pM8MzDev9S9jQMdnu3G6iFgqEfIoMUokBi3lvTHcVRcmMc8fNACS1hkU AggGrJbpbthSTGO2T3o6iJMszMc9hV9nPPb2FAiQseMjPxTS6tiSpBHbk4p+6DIOOPmqdQy4Pegj bcANsAyD/tT0Rq00cRAdm9/tV4dB1S5kd7G1M6KNzsOwFU1mvofzWKTKDgr7UGVXbaNHYRRw6YbO 5A+ucPuD/wBqxOfY1y+xefanugarFY3kAvI2uoQTvBHJFAupIZbiVoeFLE7R7D4o0ZbB+YC49s5o ghAyc5BNIYhZQ3JzxxR4raSdi0ZCr7g0SBhEB5BOOAKIm1EOF2E98+9IcNBgltxByacA+pH855oQ DJ/MKn6WIzUjHbE2/qHAXOPvTHdAb2Ml2VsbcntUmcQHl1kGfbtW4mjWQhTwpyBxmkG6khKkLh+x +9KuWLyZztNVDA8pA4PbvQULl2XknB9qVESB9A+r5qW1zpd9JuWR5dzBFfC8jkZqLgj/AJyAECrt geGNfTZuBJnsB3pTN9BVuDRXtzGwyMEf71G3M7JKB3Y96sDyF3AIUEL9uwpUil1Ynk1aG+WGPaYm YfIHvVGcSgNgL9qoA5kUYIx8E0GGHceTjmnCkzHdJyg7VfYsbhtuFqdg49PA2uECn6uP1Ud4YXUB Zclu3FChiilXLZyRQZWSOeKPd37/AGqghQRsR/vVKwVSTyR2pc2DyR3FN23bQM8is7FPI8MmY5CM 98GlLeyOfremU25gVx37k0SFVwFbJ/6qgJLM2B2APFONOnhtElVTuZxySKjrgbVG1i3PalgMMdxU rpC7tgzYLcUKJBKwUqCSO5q7hCx3H6vbFBJzgchv96yqvTWyJKyFXGeBRDqU7hVMxYY4zQJk3Ajv mk7e47kCjpMS5mEgKkfUex+aZsuz6cbR70RnwO/Pz8VZUZ5CC3NZdsegvy5cZAJJOBR7nR5o8E4Q YpxBbTNhlP1LyBTK9uruMkTsMk+1G4v/AAKWaNnRlRVHOajbi0EWQJRIR8Cltdy7y/qsUxgr80oJ HcQrNDzG3GDRtHBTv/VkftRQDnvhfmlzRBWz2oSDaWANAQ/UOO1AZ2iPBG4dqOrLtzjNN3XF2Cil 4iPqb/TQDkZi+Wzn7e9EEZmURkf3ockmZvpOUPYGpXTkS2jLOhbPbNSCOeA7iijG3t96IkEaLk/p I5qp5TLeSsUCKeyikxXP5YktEJAf6TVAghVA44RmwDRiuELY3Y/Tz3pxqk9rDp0TrhZPZBSZPTGk rMB/Nc8Y9qM6DBjYAYw3ciggnPI4pFtIwIyRvbgZpzLbThQzR85/p7UNl+sI1AEeeOadWVxeKoit pGh3/p+vABpkIpEPwppMigKwc4HxU0bS8mhahpTrc6ncR3NzIThozkAfFQN2qSXTNGDHID3U9/7U ZbtoYhEHLR98Zzim4XdMGJ2/emj0mbSeCeI/RhkXk/emc22U7ipye1JWP1FUKxj/ANWPeibtxVAB tHv8VQAxCZCEO0A5OaFKGlGP1ge2adPb+ov+nnnFHsNOluJ/Ttoy6YyzY7VNCOgs3kEh/TjmhGK0 YfzATIOQCPepZ7Fo5Gdn27TtCfIpM1skqg4GAaaCJNR3WcaR/SqH35pvNfcke/zRGtwzOoXCk0C5 ttpyB2HFVexYZGdg2AM96KNWubVtrBWj+NvemFu7HO7Az2FEmuCrqNucDk0PaXj1KO4jYsPbt8UF roSW7AgfYUxGZVJ5XI9qExwVUllGe5oqTgK+kG/qq1xKh/UP25pukhbhm+kHuKA5aRgM5xRT15gS v0ZLLt7dqWqICuT6YPdvegwTYBDZx81beqMVY7vgmiD4FqZTG3qhhwT7UlJkkVdyYb34oYkyMDsO +KVBMi7t7e/egBcAxShEAw3JqzwK+cjv7CjzRxvJuj5OOc0URqIsnBoGJgcHI4Qds0dZNiDdyKIZ EYYIpQh9UDaMKTQNVT1JCBhUPBA9xV5VaNzGrfyQcKPgU5k00pwGz+1WSwYsBu3c4NAIBE+kt3/2 obkqztu3KG28/FOJ7F1BZVLEVHXkbiAqSVJPahs8dgx4JOR7UpAXhVj+nODn3qc6Z8O7/XbYTpdR W8YH/unvU6ng7LN/6j+OW8iR94EbvUg18s+699MEKD2BpxDG0c7ljuB7VkWq9KRaVdK0qDJH0k+5 qFb/ANOCsmHUng+4qmlfljvDOSyjnbnikSeoO4yrfHtQY3IOdxIJ7U4aQkDacfY0A8Hbg5H7VTfS duCPk4owk2oSRknikq52Mhb6T80AVlVZP1Zo0s6SArs/uKQ1spG5O9WSNkIJ7fNBdQwQSBu3elhc Rlyfq9vmqVVVQwyR8fNFjKzSJGw2qx5PxQBYADIbvzSi30dsmnfoQKxCktzxmgyoqkkGgFvKsCHw T8U5/iE5QLJKWUcDn2pv6S9xgv7CkDJO1hyeDisKOJcsTu4oscO+ZT2J7D4oQhEH0ghgec0qO4xy B2PetdlJSJmlmUjDL2oca7lDkED5o7yhdxHGaTkhAiZxjJFVARKeQq5+TV3Ug4HJqhKCmFXGfelI cfrP1fFShAIB+o8Vb9PY0ojk9j+9IJHJ96m10S5LB93bHNbu8oGmpf8AiVBNIOFAwBWjXkK7lPci ukvItpqXXXUpl4+nj7V878vvGPTw916RWpjj0FyP1fpNYvqTffKgVkk2INFYj2OP3rFrxt4G7/av T+Nj0zzMdvJE/OKmTk9q2NpqqdGROyomT961zcqp1OJVOcOMk1s5FWOwwgwu3mvTldV5uObh9aH0 +npMVqzq+4Posx5JBrajKYtEIHAIrU3WPELn25r3/i3+3k/J9Vzl4jzgzzZ4I7Vzl1oDI7jOeM1v zxOlImlz7NWgevZNs26PH1DsK9HL2+Vx95aa6kt/5hDZIznmnsVpwcL7UlQGcnv+9HQ7uA+Pivl3 2+1j6N3g5A2MPelMhmADKNqg44oq3FxNJtYEIPilO6sFyCv2qbWGXqYT6xz7CqZgucDNVcH03wvN NW3bWAyQe5qqWn1SrgbQfitneEentLqhfgoPbHatWW8W+4RQ+0GtxeEaJC2Ax3ZP966cV1k55/xZ j1hA8RgXjDrnC1iM1uN5D/5FZnrLCSFixJcfNYfNGglO5iPtX1fp49OzJZcvwM1eJhjg/vQpGBJG CAfilYAwI89sEmvM6nULRoRGX+pjwMUOZ8TMp7KfaqEyKFYplx2NCklzKXPc9zRnRxHNvOfcUovg EewporgAkZq35jDDJ4NTpezts7vkVZXUg9/3oBkK5JP9qWHGR7inTQynlSB+9L9T+YdvbuRTdpD/ AJ7Uliw4b6WHcVQ5EquxIX/NKMhEZOOR2pAXgEHIxQ2mYY7UZ7LVjJyw4NXb4zgUAzupH04FKeQs OeCKKWmSDk0QhEXO76j7U1D5U7jjFJZfqBA4+aMiN+oZGAKW0Y27iCSabljuHOfjNPllGAD8UAmU qMLgL8E03kAX6hilzTBmLcDHtQQwPbHNbFjyu3Z396ECsIYA5H/mjByBgYI96az7EyEzg0YV631Z Y/3FJlZigZRvYn9IoUf0YPf7Usu0MokQjGP01dtAyB152nP/AGpOQ4JOc+9GbUJXU5jXfnk0AsxY lsHI9qbUlSNmDzz3qj9I4oUkm0Yxx81YvuUgdqULcrH9ZBI/eh8FSw+e1ImQm3KrySMZNEhyqAAZ bGOagUDgjac/vRNpY7icBeQKCFwm44B96szlkYAd6AjetI27bmMjjntQRBggngZ9qpFMQGG4H9NW ZyW57HsKAsqKi/SQRikIN0OFI3faqdl9EgLknvQYkAC84b96JodoSMe5x2FN3jUv9Qxj2qQiUMwD cfemt5IFmSILlz74oK/ILJj6qJBZmLG7aUHuTTOSWYFh3xwStMp1kDABzsPfJrOlhr1BqQubcxLE oRGPIHJqG0Zf/Upt5BPvT7UCMfL020hc3I3cYPtXPTdbL0xwAhHH01uPwvu2VbMhQC86kZ+xrS+m MCqce1be8OJNslpntFICK+by3t7eC9on8Tu0lbwJs5Ishhe+oSPYYrzD02KOPTUKP9Trlga9X/xE rYX/AJd55sf8v6/9hXkvpUwOFVcJsByfnFZ4vdcbfnToJ9CD396Wjejhj2oUkn1DAyMcmrCVSRk4 +1enSpy161l0azktre2hnVxy0iZIFQ8r2c1u59NvVkO4jPY02KljwP7CljdjJTao4qppUEARfozt +G5pLQn1WypA9hTy1CS7Que3vT1USIKSu4jjmrCg2VoNqttwT81Jpp6BMng0BmCH2GKXBOzH3b4r pi82V/oT8sM5B24qW0y3ZeCePuKZwxlyoIxmpqFRjgfUBx969GMePO09W5ZLR4vpCn9XHNOrQqEP 0/tzTSzhMu5nXAp9apGkjRkFHHO5hxXeajzW05VBkBj+xohbYhwPqFM7VbiZn9GBrlVPMqDKrRQ5 IwTipKkhwp3EELniiST4XG3PzVrS3ZhkfVJ/SnzWRXXhnrmm6M2r6hPZx27jKw+p/M5+1NmmNIFc EgkZpT265R2Hb2oUQZGKnH7Zokkp2Lzk/eqmgjjfuA+n4pbHLMAcigNhCNxxmqSZQ2ZeB7GqFmRo /q9j7UuVUlRHB3H3B9qGCV2lxlPYmiPh19UDYB/SKCjDwSuBjsaEN7cMOaus/qOG/SvxSlIY7ieK poloiwOO/wC9BbTkcgkDPuKexvEmffFPdI1OHTWeaezivsjCpIeBU3pIio09HK7QFHbFKZdyggc/ FEvtQjvGOIBCxJIx2FNwdpznGPmqVdrdg36eKoL2yB9qu0rFQAPp9zQwTnGcVFUF3MR2+9XuYnCb XYEe+PenllfQ6VIs8lul2oOfSbs371bWNTi1O5M0dnHZqw4iiPC0VEmEtJnOPbmkGJs8LjPfmiPE CT33Y4pMYIP1Z5+axpvZrOihBxyfamvoEoyjKk9j8VJXJXC8YI96aSuCoCcnNSrje0ZLaSwwkStu +9MZlDAbT27VMzSEJhuQfmoefBbI4x2rjlHXD/ZsAzjEnA9qYzRESgFhnP8Ainjz/JH96ZTOpPb+ Znj71yvT0RQT0p8Nhhj3p9ovTupdRagLfTYVll91PHFRrmTcCy81IaP1BeaHKHsm9OfORJ7g1lR9 e6V1Tp3VTb3sfoXUQDkY4xUPfSO8skjHJzjvT3VOotc6i1NpdS1B5kxycD/FRsluVJBcsDVT7EX/ AJSnB5HeqQNjg+9FVQkYUew7UEfSOeKsUQEgZxV5GwBgYNJz6g2+/wA0kkjAbIIqJFwuWLH6se1X UnfuHNXQbSSOfkUGckYx/tTRoZUZmwANx96dR2jqFJU4oemnZgzcMTxn3qaVwSAMAHuKsTSQ0IGB 1yoxjJrKBqgdAmwDA4rEUmMYXaCAx705WYqd2TxXfHpysZFE+9gfapu0ZQmO5rFbbUVCge9Stvf4 wSQTXfGsWMjiVWbJxilT3n5eEgNwKhhqgRPb/NRWra+qQMeB8c96tymmdIfqvXM78sQR961V1Fr+ 1Ww/+/epfq3XlKuGbYx7CtYajfSTvnOV7V4+TPfUeniw17MNR1e4u5iAMc96PpKbpxvQP9+1JX0p Bnuae2iFjwnYckV53t0f3eoalFujVBHAFxvJz/tUHJI87s7/AFsKc6jLhV9NjgfqGaDbsT2xxVRe OKcjNtOYWxyaVKJdn1Ss7j9T570aQGKLIIXNMJb/AIEa/q92HvVQWwuprK7Eu4Mv9QPah3uowSTM 8qHcxypFWDjBOck+9AkVJAcckUa0tLdBtzqPoHNFF6kdsjyOq7/0nPOf2oum9Mtq9wsSzmIPwR7V tfVvBnTunvDaa71e3jk1FgDaXCtz+2Kkxvtd6afluJRIyF94xwabmy/PEBm+rtiryxSLcEMduPan UCuGURgMx+KlWHP/AAbrI0l9Rt0Q2MIyAZACf7VB2c4naMlcIf1pUpfwSsD6szp8qGOD/aokMsL5 yOf96jW25Og/Fuw6YSeGWxF7ayRGMxN/ScdxWq7nqQy6revCjQ+rKXRP9A+M1ET3Th0igP8ANY/p +1PdoiISRcyHuau0TcXVmpx2MyQXlzBbuNsyRSlQag0U+pJsGFdtxyakUslnTDfSmPY0zwIZiqx5 QdjWFiywMjgj/mA/5p9ErPHvkkHfhRSNP0qS7v0cyZT/AE1mmt+GEXSXSEPUF7q0bGeQBLNGBbn7 VYumJsQuB70P0yx3BtzfFDMgNwxU5BbgVJwW6iEyF1AH9OeaVkNm9OMcZBHNWxlPo5FWkYE4U+1V GdvbBammoWsqxDeT/alM2ArnlWPK1SvC3G3OfmgthnAA+ke1ZaPBAk7b0QBB/q5pcYxwgH9uKa+s Y1xtKj4pYfaeVPPPFSrD5F9KIgMDg5zSFlkBxg4NJDMUYAcferW5lBwDuB7faoSn4kA2Y/SPajJe TAgoMIBihQ25df5nGPanSQRpkKSRjsaLtk3Stv8Axa9t4GYCSQ4yay7qvpqx6Rs4Y7i+jlvp2BSF B2Fa7sbh7B1dSY29iPapC4l/NyRyz75XDBg7HJrS07VmEjDH0jirgkn5zQfX3SNnjJ7CkFy2SpIq 1Dt2KDbnBHJoE8hdQc5FVGXP/NP/AN2iflJLkDEEpTPBQd6km6z0jmkUMQAG+1FSSFCrNwVYNtx3 +1SEnSGpJplzqjWM1vYw8NJOuM/tUBDM80TOn1HuCfilmiZS051e6i1HUZpoovSif9Ef+mmjadIb UyDIx/vVS4BXD5Pufipmy1OG30+dWUSZXADf96y0xMaVq3UUgsbK1e5dv6IYyx/uRRrnSdT6MP8A C722ayndQwR+Dj5rJOhvEXV+g9RuJdLkFu05yzuoJB+ee1MOvtdvepdRTVNUv/4neP3wACB8ACgh J7WzSFFun9SWT2Q9qimj/KuVBLjsD8U6uFjSPldrHvjvTSOTedqf8sd80ShSKd+ckE1aRi0bKO1O ceoPpO75+1N3GSQgyff7UVeB1/K7mxuHtVDB7jOR/ikhRj7UpR+9BeQAqOc4pVuzRDccEjsDSWf0 uCA2e9UGUjnGP3oByo8r+ozYLHkAe1UwAY5OAR+mk+qV5HY0RPqXPBNACWP1olV/6DlTVJICSpT6 v9VGdfUUbvb2oSxFjyeKL2VJkKQSWb70Hbs5LDae/wBqNgsrDGQO33oUSBThxke/3odrMBF+psj3 NONP0S519ZJYSTDDztBosskUyKohWMgdx70jTtWuNK9b8q231OCB2NFNWCxSrEGO1e2DSbqwlkha W33O2ew9qvDa+rdAZ2jOT881MXV7Fo8CvakyMRhtwoGravJFpCwRg72/WR3pqL5yoxHgngmkxbpU dv63Oc0hIpEPHIzg0DmWbcMgtjGODQ4FLvlD9fcA0CWQopHIB7VaKVlXd7n3FBL3e+YRSGLaygAs O3+KinG3VfVOdjds1IWrz3KP9eyGNdzE0ylP5i5ZpD/LJ+g0GZ9H+PXWnhdY3mkdK6o2lQXed5UH OfkH2rCdVl1bX9Qn1PWbuTUtUuMmS6kk3N/vTiKwadWIlCgDBB70lrNbBeZMg8Uvbn4ErN6UMKDk KNpNXQAkSHlj8VQtInABZlz8CltsjtjJHkKnBz3qNELcSxzRuECmNtyl+RWR63qMXUVsNQKxQ3AU RmKJdqnHvioW3ngEayXIEiDnaeM1aR4X+qJNisc7Ae1VTa5jPqEfb/NJW3ZYwO2e4pwQGG9u47Vd 5P5QJwQPis6Q2EqJkY9M1eS4DMVX6n28j7UmRd9x9JBOKR6ZWZ5Aedu0j7VoN5ZmXOT9I7Uua0uI 0jMkbbXTcuR3pX5VmhkdFLxqfqPxW0ep+npr/pHQ9YtE3WEcAhkZRyD8mpsavicBFzkEfFOjNvXa wxQPy+yWQhuM8ZpeGBBznAwaqdKmTIUgFj/2oLxl5FkyCO1GaTcp28UOPaP1dvihU70xoUOratBb mQQ+qSN7dhxmmupaA63d2kbh/Sbbn5ptHNNbwiUMVXP0sOMVeHWyylWOZGOD8mjJjE4iV42yNp/3 px+aV0VRjf8Ac80bWBDB9Uakuy/UPv8ANSk11pkvSdtappcK3rHLahk7/wBqEQbMznGcferOqZGR lffmlIpdzjnaPanxFm8YVlO/3ovRlDNDbxyRIxKsc5J7UQSCZiDyccGkS2CgEx8UOC3ZW4ByaIL9 Sv8ARnNX9TfIUAOT3NTeiaRDe3sMN5MbWBj/ADZfdR74pGpaVZ2Gqyw2dy13aBiY5z3YUS1HRqxB 4+odh81M6XpzXe0MoV24xTRLcN9S447UdJbpBjO3HY0YyqXtdJS4na0QgXABOM/FQJR1Z/oYYPFP tPvTbXkMjn6i2Cffnua2N1N4QXKabp+pafqMU1te4zgj1A3wB8VZNuNy1WuIEJUEpn+/IpRXZ808 1nRo+ktRbT7gvLdqAzbxyAftQQ+0dsZGKejew4yVByvA7EU5BO0bBwR70FSMgd1+actLEY8gcg+3 aqwCsbYO845pagRkqCSO9JkkVTwCwJ7mkxuN2Tw3sDRndWuCWG4HbipDpzRL7X9Qgs7CFppXYB3C 8RqfemEheUMpxjFbF8FZdVtdWb8lHIlvIR+amjTPpqPfJ7UIf6z4FaR0xdxfxTq2GKSYjNuVycVL dcdXw9A9CvoGiQCa0mXBvEXAlJ7ita+K0i3vX+qTG8F9EJA0Ewc4AHxUNPq+o6tZwWBvmFnEdyxk cZrPtaYwB5rRi8YRt2QDV1h9WULJzGeCSewoiwtFG0byB2H9VCYHaSg3YGCtaZbd1jpbQNB8NItU 0O5Ml1jFwpbcG/8AorUVvMZy0j5Vif05p5p95qFhpE+nJIwtJyGkhJyCfao9BIhztwM9/tTQyXw7 6FvfEXqObT4LpbNYRumdxkjPakeIvR950R1GmlyH8xBs3C42YBqL03qC96W1D+IaRcTWt242uYxn ePvUhrnV2qdUKn8YvXvABxvAyKCGtXbB4yvYNRpMLMp7nvmgKJBGdhxGO33oXrPJIQSFYUbOkC/m C2cA1b1NoOBznFDhG4ZY1d+AOP2xQGlLR7Qy8GmxdQ+4jcft7U8QesoM7EKBwKYyx7SWThfaiMl1 HqIaj09aWczNILY/y0Zsgf2qP0rUPQiuWl/lRyDt2BqOESpbqx4anLLC6Ik/1qBniiymkjmSeSSA hYycBTzmsg0bpXUdX6em1wtELWFjGY8gNx71jzKhJCgjHaiR3shtpNON1LFDJjeqnAagLdSRtZTp tQhm4yPq/fNNYXMsiITtjUY3Uq5Ta5BTbtHagxs6IyrhgfmmhMy6LqFnbQXVzaSJaXHMMzAgPigI jsJ2i2lFGSSO1SV917rXUmm2Wk3zqLSyGyEKP1Z7VAzzSWkskSNyeJFoX/SkIdN7na2aUwABGcA/ FASUxyKHXcG9qXdKUJB4I9qJBobf8wVVSArMqf5NPOr9Ik6O12LS5D6rMoYuo+k/3qO09pMsI1yM hv2xWV6n1lp2pdNvY3Nsk98CDFO3cY+9Dtj3rL9IZtoX2ppdTsFLxYBYY554qx3enGZFwSeQfily zRKPpXKH/aidkX+uTX7wNLIzNBGETJzgDtT1b2bULNYNXF9PEWBGYWyEHfFQk7vbtFLEqsRIGGex wexra/Vfj9fdT3elRpZ2unR2lqbcmGMfWCMEmjURfU2teGqeGUmi9KWsr6vdS5leb9SD3OT3H2pl 0H1/rvTHTF3ZF0m0lI/Tit2HOSME5NYXf6fCzsTNgHkMo9zU30zNZaNeGPWLa4mgaNgLdl5yR9LU 3pmzbH0mDSFtpCkk5J+Tms66U0+STTbrULBlXULRfpDtgENwe/2qA0/o7UNZBEVuttAmf5khwvf5 q+q2kugb9OuZYpCyj67V/oOewzVWTRhe21xa6mY7mMGYnIwcgE1m+nddJo3hHq3Ss1sZLy8k3CbP AHxUJrXQN/05pNjqd4wCXGON2SpPaoe7umYjdhwBjDUnTNmzeKcyQ4K/UAo/xVIGYl1yfbijmEwx +rsJVv6V708tLNl0+W4x9BGBn2qNK6W1az0bVZLu5svzyNG0fpN2BI78/FRtzD+ZlMgJwDwM+3xS 8zohzhh/vSJZPUbCc8YwKEJVF2jbkA8EfNVj02bI2pjuaU+YoAxGMGrFjInpyEbCeTRV4wZZEC8r 7nFWEhjlCkHAq0Ur20u2Ij0yMYNEuE3gkcnFAieZBkBuSfnkUiG9ks5PUhlkjlH6ZEbDCkzacyxq 4O5mGTVk+hBuAYj2oCSs963qPueRv1Mx5P71aAtFuDZUex+9EWVdvAx+3tSjMWh2kArntQKDRtCf UG9z3ahTv+X9JYuNx+KV6i/lWj2fWXzmjQ3CRyQBow6ocnNA1mlKybpow0h+B3pzEbXYySxFZCuU FScOjf8AEWqS7XigKRF1MpwCR7fvUdedKatL0/P1IY1Wyt39IuT9TEewoGIVQw3cn3FFAaUbY/5b E4yfarWuJoklI4ZeTVRo287Tn96BUqRRYXfu292oluBNlMBl7hvijC0jW1RhGP5hw1Le1WyYRHGw rnAoHcWmwXGk3EssgSSHkL7mgNdXV1YAGNmROzAcf5pk8+QVBO1uKf22r3cGkfwxWCwGT1GYDk/a gjY3aUlsYPuDR2VSkQjOG/qFLaJBnvj5pKIEwR/vQKvrV4jFMnMRO3P3pCliDkbR80VpcRCMnKg5 x96AXG9doOw+1AflkyF+nGM0BUUuMGjtuVNqn6T7fFD4VQVH96CUsbSCdSZWLZ4UD2ptd26RSyxq MOnuaBb3JicEHaw5BpM0ryOznLM3c0ApCNyj/ek3Kyx23rIMpuwTRFQsP08USzYJcgSkPBkMY/Y4 oEQ3O2T8xHIUlA4xwVNWEs1zIJJpGkkHJdjkk/epfqnUIdRlN5BpqWiMArel2JFRCuqlckIW7A96 BTHLcHBzyfmrFxI5+R7VW8sdoAJq3pyRgFh9J96CpUBQHP1far7cLz3x3q68EEYpEk20gnk0CFG5 sHgDsaINzF1RCQPehTOcoW5X4FSGnXERLJdNtiYYG0djQR5ZlyCaoOyjnJp3Jb2iMwRlOOxJ5NCX A+O/tQITPc/TzUhFCogMjOBj5NMtobJByG/2qUtLiwsrXbc2gu95Cgk8qT70Ec0NvIxyAwYe1Jit RHx7+wp3qVrDYXnoxyK574U5xV514VivbjNNhFtd3Frn0kDR4wykUTR9Gu+rtfg03TVzcTZ2xdua kuiLWXVurbKH8nJdWQmCz7V+lR96d9R2Fz4e+JU15pt4im3dpIXtyGXDf01Z6ZrHNW0a80PUZrG+ haG7hJV0zkA/vQIZCx+oYx81M6x1RLrVw888YM7frcf1fvULG4lJ4Peos/2PcRvcwsLdQJCOOayG HrO6HTi6NdWMJTbtLBfqz85qDs7XBZtxHwKLFht3PIPvQNVjKYx9IJxzTi0s5727jghQyzOcKo7G qZlUsWPHzUjadQvplllYFjkJwJTxiiUXW9Fg0O7Nl6wubjYGcgcKT3FRQtd0oONo9+aJJeG+WSQy D13/AK+9ZLeXFo/S8Wm3NlHFfowZL2M5MifeiMbyc4U52/FPRbH8nHMzjkE/tSzpdpaTQo0xWFxl vmka9H+WZbVJUlQjh1PGKLte86bnggi1IlFhlH04Yc0zVWaMyFv5Y7n4obt68MduZDhO3NS9jFZQ 6XcQ3Mkv5k/8hVGVYe+T7VYbMSoW3f0gCDyrY96Lp2o3OkqZo9okIAIcZpsh2RmMNkZz+1KS0dIy Mlx35qGxrq5WefeThmH1fvQvVBQqv6fcVZbZGkyQcmrvGsKEqO/tRFtxIGckDmrS3EasADzRXjMq qUbZ7nPvQ7iFXwyoEI+KBccu/J3YQfqpybO8awfUBZyixDbRKVO0n5/amUKqisp538HNZlP4m6uv h5cdLtbwS2jjYk+0B0X4oMPT1IZQQwIYAinolZwGfnHYD/vTWGL07eFCQzKuCaW+SRg7aJoaE3+l 6na6lp8xiurc7lZTTnVtZvdYu7m7vyDdznMjDsT9qZxli7AvwRVjAZyAxxt7k1dmjnQLa2u9Zitb q7SyEowJyMgVWr6cunXc6R3C3Kg4WVRgOP2oMWnwwetLnlRn96byzKZAOcH3NRVohgcnP3xRRIAo J5xSGYhcA4x80q0h59aXGwdlPvQVIWwjAYRzt3Ee9WAIYAfSfajz3v5lFUxiNB2QULYHZtvBHagq FFnymQXU85pEkRkYs5II4pSqkY+vgn4oucY7UWBKpQdqt9ZTDH6aI2CN5zgVT4ySex9qkXRAXntn 7mr4BABzj5FXOCOeF+asr7pAgG2PGTVUlhsA+rI+auwK4ye5pe1N5CZKdxn5qhG8xCphnz2qfSaU zhFIDZY1QUlAAfr+KXJZPG6rIuxm9vilKRGpUkb/AGaqaNYmAlIYZI/po9ym8DgAfAFIlhw2/jPy KuJN3DnLUTskMWGOwq0gP05OV9qsXYq2Pakbix7cY7UaUCyn6TmjRk7s7xuA7YpsgB3EsB8ClMCr B/cUD7Q4tNv72ZNZuGs7f0j6cqg/8yh3FlHbSBLdmuYycLL9qTHsuCPXfAHv8UW6uDHcxrasHgxh sU2GzSwLIySn0ef1mnmtWUWiXEMEd2l6ksYlEqdhn+mmE2mtrmqWdrEjSPJIFCJ3b7VL+ImiTaRq 0VibAWM0cS5hU9/vRDBYwGDf0gVUdjbjdItzhz2jxVroNDp6u64J4NNIwwQc4B4yPailzWoSJn9U F2/9sCp7oi/i0m4WR32Mx2sc4xWO7MkHnvS5IQSSrEB+TRGUdW9Qw3d76NsilW7v81BCKeCYfl7f 80rptZgcbfvUZDbk3EfJIU9yakjeS2dw207VIxx700pUtu0fBOCBSNofPOKUs/qkMcHPekHgsBU2 LthI+O4NIEsgBdBkDhhQzuUYb+1W2MsmA2T8g1Q5BL/SOVJzj4pLxkHnj71dD6a/6jjJxQnnJ9s/ v70FNksoj5Puaf6Hrl3ol5HqOnyNb3KBkyT9LAjBBHvTOPKPtJG4jIAoLQlUMZJC7s0Do3kfLTBp Gck9/cnNWdwpOz6SaXpsC3d1HGVO35+Kvf6e9oX5X6W7k+1L2Bbh6YXGXJ4+9C3+kxBHINSU2mtZ 2VrdvNFILgbljVslMezVKR+HVrP09Lrs+tlJ1OTp8OCSPmkGMmZWIUkfYZoTSKrk7hgdwDmjWUen 2ut6fJeerLpSkvcbBk8HtU71+ulT3EWpdL6ZcRaZIBv+n6VP3rOioGN8kFn+kngUu6j/ADAYo3v2 oEGxpQQcDHb4pyuNjADt2NXsP7O0sZ9OaRpD66jGCaiUiMrFNrSN7Ki5J/tSXV0II/v96cabqtxo 2opdWr+lIq4LYzxVFfkBNdvFJ6kQiQO/0nABpO4RuwQgheMVLHraaRLhZVVpbj6Xfbyw+KZ6XoOp a5JfXFlZSXMUBAkEYziiG7XrtgEDZR74xS3BaBdkZUfTTO6QxuyOpjdeGQ9xSrW4EuVBHHBzRV1t zIoHYGhRxFJ13Z2ZwSOKNK7WkodhuHfaKch0uRlFwzckUEdd+lHJIIzlf6c+9Z70tonQk/RZuri6 mfq1n2iAv9AH7VgE0DXd6sCIS7Haqj3PwKkYdMbSA4ki2OP1E980Dzqzp6fp/VLWVmTbKAysjAgi o67vJL6Ueo25UPBA7U4uZ1udJDEYJfgk5plbCQxu68r2O3mpAl41LqI8KccleM0p7SIsrRuRIP1q ewoUjbXXHfFFlb1yjKMFRg/eqCixjdDl9pXsKBFE7MEVcn2BNOGn3whVXEgPNIldXY7Ttx3x70CG R0yrDHPYGrm2jZcux3fFCMmWHJI9zVrqK4it1uXtpRAzbVnYYQn4zQOIri5tN6288q8foR8ZFNrq 5imDCQtEwOcKMk039J4z6qsd6jvUz0VqA0TWrfWXt4754mwbeX9LD34osRLWz3MTSW26N1H9YINA R/y8gXGSe5rNetOoj1Pqdxfiyi05GGFih7YrCZLZWywYs1AoOsoKpk4POacRMEIAOSaHbwZXd74x +1OIYwkbZUE+zn2oBzOrY4596qNzGpOc7hV2GDuBBx/vRbayk1F1jjjJZ+AaA2kaRe9TzG00yCOa YfUQzAHFFm0C4t53jnPoPDwyDkZoF1oOvdLahDdw2M8cSY/mKCNw+9TP8eS6s5vUQeu/6i3BB+K3 IbQKtKyq5GGGRuqSsd0R9ckNKFxnHFNJzHhcMP2zRLO6EayJkHjjNESF7qclzuLyb5GABP2HtUSp YPuz2NK3Kck8t9qcw221d3BBowsb59wPcDvmm9jZR3mqjdIYi3YtyM0ueAlDzyfihjEcSxgEkdie 9WCbu+m5ROR+YQKRgbeM1HXmm3Fi5ilbcTyOO4qm1Pa0eTIQmMk/NZFLcx63ZpIVzNH9OffFNrGK xMQp+M9jThfrjIP+Kq7hSKYq2QAaJH6QAw2TitIpQYYs5zgU8T0xEu+MF2HDe9MjjlSPpIoqTKEV G5x2oKu19MIo5J70KMgSYxwe5pc0uAcDg+5oCSjByPqIxiglI7HTZY/qkJkx2BphPDFHLiM/T8Zp rbIbBSvLZ5zmrNN9ef01hdltFjcQMqaFsZcDk/3p1b6lFGNkmD+9Of8A088PqxsNueV980WI1kC5 BHJ7EU3kUo4ZcsT706upBCxjUhmPY/FLtluJpBENNvJ2IwGhj3D/ADWfpvZlnIyRge9V6fqEpGRu NZhbeEuq6vam5kuItOiP9M7Yf+4rH7/o+50ad/5qSSR9nByGqaWZaRi2KpIY3Y7wMkfahN/LmLf0 /FPHV1kLP9UjD6jTWaInLe57mmnXGnEd2YwD2PxTC9YXLucZ496HLuHAJJ9qtIfT2rnLN3FZdYYv H6aAdiacW8yxRbAAAO2Ks43SFSuSBV1jVWGeD71O3TYEuWfDHIoeP5h2YJxx96XMPVkWMHDMcCrI m5DHxuU8tTtQVIlkEh+jb/SOxqQW8gEJREChxzUa4y7KpyfcCrJCsjlHOwH+qnYvKkckowNqqeMU 7W5CxGMgn4x7UhJLW3YQk7mP9RpNzLEgAjIMnbFQ2PbadJd3kMKKXkc4wPYVLSaXFYSujqGdDtNQ lrq1xZyD0ZNkg7nFGl1lnDNI27PJY+5rTO6czx2xhfeq8e5HakzadFNp6SJcKVTgLUa1x+Y+tGV0 HdQe9IKlC0igDB4QHisxoT8mBtJGSOQfilwz3ERIKM8Y96Q988MgaQAZHAFOre/XYVeVVRx2atMi xeg8TeocHGRULNskdiXzinxljLkKn09qYzQSvd5jUKn/AHoMq6H8Nm6m006lLrEVhAsvpiGSPcT9 81XVvTlvpl6Le3uBdIpGZlGA39qxs3GrWUy/kroxWmPrhzwTUnba4Zm/ngFh7k1IvRtqFhJCq/V/ LHfHtTSFnjk9ONDLn3qWn1eO/Qx+msagc45zQI79bCMbEB55B7mppFl37mXbhjwM0ESXEF0Bb3Bt 3Hf707kvFnSSVRhQcY96bGJYxvwZJG/2rQp5pnmGXDD+o/NX9YquQOKR6EiDO0sPfHtV2Uj2HfvR Yvbzq7Ef1e9KmUSNgj2psBFDJuZiue33ovqEE7hk9h+1FIS12EsFz8fam10xLrFGu+RhnA+KkC2F A4B+1JhZLC8iu48NKp5Q9qAFmrNASylCOPqGKVPah4lbByaldU1Q6u6H0UhOc/R7mgiJtuw+36aC LRDsCdgPejoiOCQduO9VdQSxhiysuf6sUr1IpF9NlwP9Q96AMi4/SdyZ70MkvNgYBA7UZnUEJ3T2 x71UPpq4YqTjuRQWAYt9P0/IpeEhXc6hx80vYHkZ8HGO1BlXa7c5H+k0FevHJ+mNk/c5q8kihvpf 6ap4i+3HGO+KCYvTBJHAPaidLM6ljg/t96PbXzIMvjHYUNtkkZLcY/T9qRtDRoo5weTRdHi6keyg YzyaW4WYespYSL/SDwaYtHHE2xQTvo0bPbt6Y5Ye9DRx68pQbyY2PcUWw0a8vp0kazNzaocsynGB 801ednzuAJ+acWOv32kkTWkpZT9LxnsRRIzO7v4oNNW3gkMA7Y+KgIuoprW5dVbaAcBx70wn1cag 2+T6S3tTWW5jjIP6j96jV7ZDfa3+etjI5LkDC5PY/NY3dfXJhQ2PerRzBGLhvoP9OaLDFJuGJN4b 9IPtVTZCQFY2ZB9QPAocO73xzUzHqMNvEImswzj+s/PzUWVCzucfR32//RQ0qQfyDng/ago+3BB/ cGjs26PB5B9qSEXO7aSB8+9EOY5Q0Y3EcdgKRPKBjC7gPbNN2idHBU4B7/aiGPaODz80XReGEe5T kfHxSUYAt3OKpTtjJHLfJq0c4LZZQpqaDhizKoTjA70jduQj+uqZyy8Dirr9IwAcU0L4UyI3uPii s2M7QBkYyaDEoXJ7k/HtRWXenPfvWWtBRhhk8k/BpQJIOVyfir7gB9JoYZSQRkv7Vspbn1CF9qTG 5DEd1xgke1GkIVc8bsc03T6QQPpz/vRlSx5/T2HalD6l5HI9zVmc5G3ApGcAkj/FZrWlixDEfJ4q 7NnIZeaS5BxnuKszmVPrbt7VFNpzhgx4HvXYHkHsEvNU1C+ZNu0BQfiuOryTdasmPrLV3Z5AtNUa Lfse7BcN8n3r535d1I9X4/drs3USF0tkB5HOKxac/wAogjOayPWtsNmNn6m4asZuWITFez8e/Fx5 /aFhCvq0Q9vUGa2dMoWzYJyD2rWljGj6sgPI3ZJrZUm1LaNQffjPvW8/bhh0e38gi0OME+3etQ9Z TAwOO3BrbeuADR4UPHGa0t1w2IX5+RxX0Px508P5N9ub/EsrI9wS2W+K5x6xnknnPOOMcVvzxDmC XM4J5+a536xvFkklRTgj3FejOvlcWXzY3E0m9gOT781cMxPp9mz/AIoFtJkhSc/enPpBmPxnk182 +328fUGjuXQhAcqPc1U0rvJjPb4NBnhYxkKMDNN485xjGO9XTYmD+YyfiktkM5/poiISWLDjHFIJ 3AoDwO9AmI7Du4yv/atz+F0csUdvdekDwcfFakstJGpKY4HCyqOze9b66B0Q6V01hpN7gZbP9Ndu LHtyz9C65KZGLEYJ7rWITqS5OexrKdYJcbs/3rG5owHJz9HzX0/UeSe3YyThj3pEkx3/AKv8UCMK 4yWI/aqY/wAzYvt714tup9FKWUEkH96SNpOCfemqzBckDtV2kZcEcg1dh9vUJ3oSuMnODTX1XZSB /mqWQD9Y7VQ6jdJATnBonqFB27CmrSb+U4Ud6t65kAw30nvQFkmcSrtPGc0R7gySPIT9Xx801U/V tzz7GlSbw4X/AHqyh3Dcnacj+woqszHsKaQYOd/cUZArMwJ+njBzV2HqxEYBHGPems04JYAf4p1e 3g/JekvBx+qoiOTByTn5FT6NnLAKeSSO9LSVdvI+mgM527geKQ3MeBwxPc1WTreu3PfFDebDgA8k UnfvQKcD70kKGJ55FBUoyu48k9xSFJViCcR/9qXvCAAnvVPIoXgjPxWoBqrBjg/TmrEfzVVhkZx3 9qUS0i8HAochK7SeT2qpoqOJXcgZHPuaFcWzQ5GQW7jFVkMv1ZI+aQoAIOScDGc0XQBVlIB9+5oi dxkZ+KW+eCPqxV1kjAyW2D2oG8v1E8f2qykFvsaRcyZbC/5q245yBQFlAQH3FBkcMoxx9xVmdmJ/ akxrlh8fFAssBnnNDE2Oc8iryWx9P3zmgtvZzuGQO2KzsGyJRjOPvQpGDMoVu1Xt7C5uGAjQ8+57 U8u9Na0G1/14zWg2Vgj7CeTRw0QbBXccd6ZFTye5PY1YMygqxO75oH0ZRh/zREPbNPrDWLbS5y9z ALqLGCMcmoZAWIOMge1FiX6mZn/V7HtQJup47q5mkgX04TyE+KYXkoWNvp7U+/JrhyrbCD2+aZ36 ARhe+fihGPXqtgsf0farWhMbqc/V8fNEuUOGQ5BXscd6bWrETR59jiueXptsnR3zBCT3ra3QUuya NeQS4Nal0kn0lAOGA962x0JOkrwSEEY/VXyuS9vTw3VZj54bNdQ8sutuwyYrP1BjtnivH3T42h06 3aQ/WUHH9q9lvN3Gt55WOpSB/wD03cD/AIrxssdk9uG3ZCRqB++KvF7crL52iBN65Pf4q08RYgBe 3vVHKpnBFU956agFd1ehtdHZQO2T71YmR2G19ynuKvMfXCFSEyOwNBCOp4yVHcr7VOzcSFo+cjgM O2KevKF2MCCw7g+9R9mB6688Y70VSS77+eeCK1GakY4vUJLEEGnNvGsPvxjH7UzsomfDbuPipWC2 5JIyT7e1dZ7cKcRSI5UDt8/FSdkDkgHd96io4tjhRx81M6bAIyfdsZxXqxePkjIdBth6ihyGB5YE VnehWnT+q3dtBdwsfRYMSpwCPg1gWmt6TDuD71lvSNu7aiRFGTv7n4rV7ednHiVcWl2NLh6Z0+OC 1iP/AKloU2hhjsa0ncTrFqctsykPu+lcc1s656zt+n7mezMvq7uMY7VE6Hf6Lf8AUMskqj8w6EAE c5qNXTGLu+XTTHEmEux9RJ7gU0u+ory9TZPcvKD7Ocisemup5eotUWdiWjmKop7lfkfanSys3IXt WmKfxSG4YOx2sn+9PHzMykjb9qZJIqxqx+k/erJqDpIcYNXZo49IEkSLvq/oE8Ocj2HxSfzRbaRg MRmnDEmMPt5HxTaaD7EI3I9h8VaQgBgO/wAUh5U9QDJZu5OKLAySAnHFNro1ZN2MDmix23rKxMm3 HvRsIq4P0k9sU2DJGzE5bNVkkgKpwc54yBQjdxW77HcBj7U6KLhiTtXGcD2rINMfpNdCme7Mv8VC Ex7l4ZviiemOSsMD4x2oP6sc8/eiSSfmMMFC49hQmciTPY47UPZ3EF9PvzQXYCXaO9CLllIByT8U tgZI1H6SKlXcVI3IBwftSdwBA4H3qvTKfc/NUVwDyCajWjj6XXjv8mhmIKfqParBiQVJzx7Uhpfo AH+9GTaaMtuABb45pItcRgkYfHb3p5Eqlhle1P7G0t55m35DKDUa2xq8tyYWbsfisckVixHuDWQ3 VnKrybpt4DH6aiZkG/kAftXLJ3wqHmUvIZAANvtihFTIN6jke9SFzHgBycgewpnLkAEAgN34rjk9 EoOWlOWzxSXXBI7Z9xV3fjBPFDlk/SPcVlolcjIBHfsferbCJAFblvb4qtwY47/BpLHYxbcC3bvy KJT/AND6QHP1HvTd7ZIwxRskfNNre+bcVbgngE0cqzfcGqQq3OxlJ4HvRLna+WTt80LZsDHgfYmq EgdNvz8VdIvuVEGDlj3pcSiTAPamcm7J5yO1EiuRHwo7e/tWV2fBPqAxuIORn2qSt5NrocZP3qLt nZpAwPNSKv8ATxzitRNns0rSKNpwAaJBccMG7mgJKi4MmQPiretHuJTj7mukukOy4SQFfepGOURo GY4I9qg3J3Ke9CvNQ9OHO7k1ryZuO03JrCxgjO4VjWt6wDCzBuPbPtURcayEfDEnNYh1Hrj3CPGj 7Tn2rllltccPtG9S6m93dAbs7e5zUVFCHfc2cf7UkMW7ncffNHLhotpORn2rhHrkC4jcgYIPvRjI wCBWIHY4OMigqAATjIoiSbTyM/tVjoVcIHb+WCE7GrxoI8EL39qKX/lAjjPAFUkPqgD3BqpoO5b6 W3kMB2AqOAQoVc7cnggZqUn0mV2OyWP1McDdUz0vqej6VfRXOqQhrdCFcHsTSJWLOsdsE3ElT80i e9thkKcH4xWXeMEdvdahZPoVkxspo/VV4lyB+9YVJvhLBov0qN2RyKWLOz20F/dyqtiAx7/q21Uk 2qXkpt9S1i6aCMnZE0uQD9qijvk/qZSfg4NIihaZhFHuLk/qJzU8rrS6FEXqSsVkMu092p5ZzvFM MDB+QM07HTOow6e900O21ThpccE0ysWuL+7/ACtlaLLc4ygc4yay0Lqr8j1D9R70mxs7cy+pNgR4 xyO1MZ7e/trqWHUU9C4jOWVqM92bmMBfoCjJOO5otO77RLC2jFz+YDXDn6cfFRgnjf6iS5HFVHCJ Dn1CWHsaVshTMarhyc7qIOb2MwbfqwR7HFW9dWK5G1exNDS05AJzz7USaBEGSOBUinJvwkGyxjdD /VITnNNporm5SH155Zxz9MrZVf7Ve2f0mBXhT81KzdQwjRW0/wDIKbh2BF6D9Sj3GPvRdo+1hKxH J+oc5o7NhQSBg9zQI5g6AfoQcYqSsZYdqD0fUOcANSkNEHqNvORg8AUdOOAB+9T1np0X5hTcMsUT Hk/AqDmdBfzLtIiVyFY+4+1TZF1jCjBGc9qoKqAr/vVycuWz/aqI+r/6aiwlzjmTsac2t0ISpADl fY0Acrt/z96s5ABHH7ipWj2W69U7mwmewFHgKsNuNpI4Ipg43WyluSP9qLBMAqlWPxmqQ89SQELu zzyaewljnPPNMUZDICR9Xz804ifah5JyeSKyqTs0d2cTMCO6/ap6Z4bm2jEbAFRzisWS4KOAOx4O fipBGCQnYec81rYPJIGmxu2sBxT0RkKMtioeOUyEseMf5p0Lg5AGSPagfpIxc7zwO1TGkdbDRLyI 7BJGnOxuc1jayOO31Chyw+oRu/sRSXSWbZZ194oav1tZxWbuttp8bZEEYwD+/wA1iMayYATAHbH2 o6RblAIxj5pBcI2cYpbtJjIbXGH+lQARz+9BYsrLxgHsKeyQq6A45+RQAuM7v6O2ay0Z3Fq9wmM4 z800TTGtnaRWzkbck5xTmUEuRyf/ABQ5k2JgL34zmgaSIrA88jjJ96ZA7XIU8e9STptjPvxTAQli MAktRCTIEBEZ4/70NmA5Q/U3ejvCThShBoSQMXZMZYfFFW+k4GcEd6onBO1s0mURofct70iOQM2O NoGcCgtIChz3Bp3pektqTMqH6iOFpsHSaKXYQpVeA3GamOlOmdZ1c7rULE5HueB/emkqNmsJbS8i sZreSOSRwquwwP8ANSHVfS930TqUdtdOrrMgeKVezccjFbH1bS9Ru9HtIdRgE9xacRzRLnJA+R71 q7Xhd3OqSz6pcST3R+lInGNoHwKuklR/q/Vu2liaMwVlAP0kjPFACekSz/Sv3pXYZByPY1HTatiy EElgR7g0l2xuwMn70uMliVGKp4zux/mgQshZsHv7VZJC+7coXB4xRETkDAz81dkLZJ9vigNpVrDe avaQySFYpHCyPnG0e9L6gjgtNVvbW2bfbxS7IyTnj5pntD5XO35PahbMknJJ7c+9Z2LIvPJKfcdq MGZAQ3INUzBEywznuBSG25BwQh5ptNrGPf8ASOePelabYrHJI8zlo2X9HxS423A87T84pckwTZtA XPetKkOp4LDQ9PghstQW8kmQNJGgwY8+xPvUUbG4t9PimdCVPOPmk3afmZFbAHbIxyadT6xM8Kop KxrwFxxRKE0ygAsvpn4NDcqbq1WV/wCUxxn/AEj5q7WM9xbescsd3cDgUKzjZbkmYBnCnag5zRGV 6vomm6U0Kw3o1OJ4/UaaEEBR8YrFtQdGZhDu9A/0k8miaZqFxbpOmNokyCGHYUhz9BAIINA8sFth bD1k357DPakTW7JyuAMnimyoFhGxjkHsaum8bm35BHtzQK4HGcVSJxgfpPvQI5ADy/zxSs7WDYIU nse1BcLum25A2+4HerFt4f6CMHGfmhXFw8E4jRd2e7D2qQkBtdPE8xXB7D3NDcF0vT3mhlTfhGB3 HPetodedWW3RngrpeiafLHPqt4w3xA7iq/PFaUs7u4uo1j+r3PHGRS7csuZArO3YFznH7VglkIWS XAEv/NKjP2p0V2puHPz96CW9N8uNzN3NOfTO45bAx7VtgJX+vlcJj3qxxIhYfpzgn2okcAvJI4ix Rc5bHuKmusW0r8npyaZD6A2YnQH+qi1BCVpLUQxRvMVO7gZqZ8Oen9A6o6xtrLqS5ew0vBMkiSbS D7c1M9G9Y6d0rFcLdadHdmaIoHbv2oHgx050xrPV4surwxsrkuykMVVcnjmjO1/EHp7ROmutXsun 786joAh9QTOdzep/pz8VjEqvKv0qdueBUh1hZWmn69q9npcn/wBrrW5MNuc53IPeoi1lATcSxNWp D60ZYiN67SRzU1FeaUmlXFusJa7b3J5/tWNyM0hVQefmjW8LMG+ohj71GiFuGQAZyaeRIcFt2CTS I7JC6HPPuKmJtHMFik218seMitaZuWjcytKMHHbHNCjhw4x2z2FFQbAuRtz80VY8EEjGaac7RIoy M5wAfilM2FZicgccVM9M6TYa9rFrp9/enTreVgHuB/TQOrdIsen9cv8AStP1N9WtoG+mdwB/bipY 5Woy2sri+u7SCytWvbqYkJApwSTWTwS9R+HfVWlw9Zade6XasBLFDI+Qw+x9v2qC6Y1m46e1i21G 3QSTW8iuqNx271vPxx8a9J8Z+mbf8/YNZ39rCFt3VOxA+a6Y6jjl3WvdR8SNN1zxE1TWXsI1hltx AkUy7s496w+7lMk0kgACMxYY9vtUbp0DR4LnexXk/JosshLlApP3rOTeJ3HC7nIOFq6N6eVcgjGe KEkxaNQgKsO5+1CkYBiyHPPNZ2tZrD0Nrd90jc6vbWg/JwJvMpIIYfFYdo6z6tZyGO3eYj9W0E7a fQ9Va5a9PXej2d7LHYXX/MgHZv8A6Kc9Ca5qPSdnqMVtIqfmU2sGUHIxitdCIjYQS7TnOdpzWVaF 1vfdI2VwdNmEUs6mORD2YEY5rD5nbedoAYntRAhIBPB+KiGzwmS63vngHGO3JyacRssYC5yPnFKE R3/qwSPf2qyoSyqzChC441ubyISOYoM4ZsU/6mtYNFuFjsJvz0BjDiReMH4oOkWN3qurLptsQ7Sf pD8Af3q1/Z3PTupy2epRem8Z7Hs37faibhml9hk3OzA9wRgf5pw7K0uFO6I81n/UetdJaj4UadYR RlNeD59RF5A+K1qG2OE5AA4zxRdJVb60sgFCEzN7k8Co24EXqNLDJ6hc/p+KvEtvjdNhiPYmjaFp 03U2rJZaZGj3Eh2RJKcBm/8ApoaWhjQROSxMhH0ihRxgDdIoLD4PNPdZ6V1zpuYDVtMlsFEhQsyn azD4NWu9Qt5LYQQ2Cwy/1ThslqBo5ByR2PaqADEE8Ee9UV2ouOasrLGmWI/cmijmQZUFs49jUt05 09N1W17JAyotrgMWOAM1j+0scg9/eiRXU1nFJ6UrR+p3CtjP70Z0ca3bSWFz+TEq3Eo/pSo+3kmh /lPEykn+oc1LdFdKX3V/UEVpDcBbiQ4Vyew+1D6vubi3168jvp2L2v8AJCqoG4r3P70X0DZrDHc/ +qb6WGApOKbuIG1PZgqByGBzU70LqXTSTzT9RWD6jDnaijIxTjrLVemm12WfpzTRbWPoqNjNklve ibQl8SJAHQggYGec0zeLcmOxNEgujPl2yWzgZ+KU6DO4nkUXsbRdWn0HUobq3gjnkQ5CzruX7cUi cPrWq3c0wCXF05ldYxhQfsPYVUTbpt/cjsaUGKzvNvw/+r7UTtM9JdISaot5KXV4rRSzyMe2O1Yw 0zXE8jHnJJH7UcXl3psdz+Xu3Vbj/mIDw1P9J6ev7u0P5ZY2mkGAueW+w+9F3o0s57eCcPNLtUKe B2NR8MqTM7lRt3ZGOQakY9DkstZtdN1SF7FzKvrK4+raTUx4m6VoOh9bNZdOXUl1YKqtKjjHptjs KG0CSS2Gy2e1Wa2aZliU7Fc4J+KcNcR7O3B9h7U2m3xRgRktnmibZf0f4dHq99RsU1C3sHtYfVE1 yRhz8CsJu7UadcSRkrNKrFGYc5xRYc37KszMrDgMrlf/AM9ZAltoFn0bNbqry9RmQFZl5AX3FDpB 2FlEEYnBB+rDnt+1OLrWWmvIpppBJIgC5POVHYVF6jGDbSzsrJsXMm09hRNJC3dkJE02+niIyJUi JBA7mmtqnrzre6ltPQX+VbYwwSkw6RpmudL6rqL3fp3NiFe3t1OMt75+ax/R7RL20utUjZjaxy+k VcYOalZ9L/8Atc11C6hcf8oHGfjIpSI2bWNS1u3iN1dySMi4SBm+kY+1AkkmVY2mgaNM4LMMA0TR 1NzcRRmL+c7bQh+alOsOob3UtOs9IltY4VsJSfVXu32NFXF1FcRRJayK79smhakt3FIloHCkjcVz We6j4OR3ngjpXUGm24t9Xu7pE/MyPtAOeB/eovrDpSHoLp+O31Z1k6sMm9pIW3IYvjNWzTHkwe0a VLhlnmVlHdAOaP09b2F51HHb6peHT9MkbDXCjOKe3uoaeOkrL8vZK2qylhNd7vqA9hiom1geCyUh 1mf3UDOKjTO+tdR0PQrWLTdAuIdUtD3uGT66wZkIYZwdw7U3A3tuKbefiikbJdqg/cUUXg5Vsbva hsGwAp5pca45PB+aSz/zc7T/AGoFeo6qFLcClKfSCshBY+xFVIm5c+9ESP0RgtliPegXpkUM8ly0 8giO3IGKEqqDgNkZ70gd/p4z34q6ph84244zQKUh2OBwPiqGeeQCasqCAk5yG96LFEgUZOTQJ9SW KYNGw4GSD/4p9qOv3N7o8NgJXW0Vi5hz9JY9yaZuiMSpfBPbHerri352CVF/UD70CrTSLm8tW/Ko HVOWJOMCgMhiyNpU4qd6eisNV1aKKa8/h9kImkZwfce33qHmeOa7mZGZ4Q5VHIwWHtkUA4JJV2QS sAndWpyZA6EHkgdzTa1T17Jy4Jfd9OfYU4SF3hJXLBRyQKBuV9sZHero4XgZFEihd3Axk+xpdxA0 DAMMGgsG+gZOQfaryNgADGKQhCj6u/tS9vsePmgAz5c88UTYTk5xj2pzNJGY402AY7sO5pCoJFPO B8mgArH1eDkn2okluw7HYDzg0+axsrfSobv80Gv3n9M2w9l/1U2uASx4yB75oELGAn6d3Hekjbyp 4xS4JHjY7RkE9qc3lqYUEoAdCM5HzQNyAoxyM0OMA5JA4pAPq55K/GapWCMAeB70Dr+IzLp7Wapv hzk/NSug6ppdl05qlreWJm1GePENyx4Qf9I9j96iI5YkkJjYlgMEEcUlV3Dk7SPb5oA2zBArbcNj BzT9I0k3LI+xcZ5oUSjeI2PB5JoTTGZyo7JwPvQLjtDLMyxyquBlcjNIitlnVhIwVl7CkqrCQMvD D4FXIYgnfgmgH+V25wePvSXTvtB+xojAgcndikxTxiTExIRuOPagSpS3y8qAjuOKJbG4ngN0bSQ2 h/S+04/zT7pqzm6h6n0zSrVBO9xNt2t2C57n44rZfjF13Y9OSHpXTbdI7azVUnMag7mI55ol6akR 1Ybh+ktgYHvTqKMFipzgkH4oKiNnRoE2RHnDDtTuVl3f6QKysWnt4hIZNy7j/mkq+WwWyo7Vf0lm G72+KSFVTgjgdqaQo3l1bRPFa3M1qJOXNu20t+9VG0rwlWYuO2X5P+aQy7iCc9+1GH0L+nKr/vWw 19HLkcg49qW0Yhh3BSSPinE7eoVZU28Y4qgrBDnGDxU0qp41i9JopfU3rlx/poca54HY1dmZTtQD 9/tV7cliwk+kf0mibUY/TcGUfR8U7t4re+lNtcZWHGQfamrOFIGNyjsCadRsgGcYeiUrSelJLpLy 5U/+ituWbP8Aikeq4jEbEkg4GTTg3LiPYj4T3UHA/vQTAXG79Rz3ohOGnX+YeRxmrxWG6RY1YPxu HxS0iKKWJ9+xqllxMGBwF54oBXVryjQnDZwy+9O5Itij4AoCqPzLShiMnOKcSuG5I+qqGcqN9LAY 3HkVO6hp8FlDC0c3qh1BPPY1ElCDk+/+1X3uYwgHFQEiG92wc4q0eFct3+QavaqI1fOTu4ogspoY hPjMLZw3tQCVDI4bGAfakSuLeWTcN6ge1SdhNpz6fMb+4ljmQExxIuQ370a66au4enYdVZIxbTth ADk1aIgvG8KuOQe1CVjk45/esktbzSn0NLVbTfqBBJnHc/2qFj0q4ngmkjTcsIy2PYVBZggjRWGJ D2PzVGAMGBbkDNMJpwt2FViwVQcmnkblk3AgVVikXDDaMGrMBK4xkftVNJ6bZAL/ALCrN9ILZAyO Kh0cPDE0ahWO48Yzwaynwv0PQerIdcs9UuRZ3dsR+Wkc8YxWPhLBNFhuYZ3lvyxV4CPpVfnNQayO 8jCNdvPJBxxREzqtta2F/NbwXa3kcX0+sgwCaba1oeo6bFZvMnpx3ILREMDkVVpbgA4xj4xS7qLY FLStIo7Atnb+3xQKs9Iacp/NALYBYnsatrukz9M6gtteZDS42MDkHPam81q+wFpRHGx7q3alajeT ahEguZfzXp4CyMecDtTYLfaXdaa4S8iEbHlRnNAVw3fvS5b17tE3sWCLtGTzig7t2doz96NFk9hn 6filNiRhzgAUFWfGX4HucUpyJV9PPf3FFOoSnCPyT7YpLIUZl4FFs5GvojBGAZYzxnuaDeRGEj1J NvODzQIbB4DYb4+KXa3Qs5lfAd15z7U1wDNvDZwOCPejRsuFLDg0Z2Xdai93eeu/9hRNKgbVr1LO PHrTOFXPGKHcLFIm6P6WHdPamfqFcMgMbqcrIpwQaL2mtY0C80C6FvdbW5wGU9zUW5UNkcH2oaTS yTF5Z3m3DguavuLMQR27GhBImBDg80loTIRsbDD2pEYO8tjC+5paSrG75OR7UUgxgELjBHelABAO c1aaUOGI7j/NIWULxnAoKYB2K8/elCMRjuVHxVywAGW5PvV2YbDjn/qpoBa4ltzHNbtJHcwuJEkj OGBHapS61/UNavFudTuPzMuAGdv1Y+M1GrJJ+aRGAAyMn7VeS6SS5aMJgr/vRNJzqAaaLGJLaVpZ WGSM8CoiwISAhuc/NNOJCcA/sKdWqDAUnAoowUp7A/vSWX6SeDmm7MQxJkIOeRUhokcV+L5WfaYY fUX/AKj8UTRgqHGUYKQf80WQi5kXcATtwQPmkFSluSThuKf3KWltHC1u2+Rxl8+xopsqiMbaQz+3 bHxS1b1Hbdwg5zQC4eJifoYn6SaaF/U4OeT96GYwx3Anjk4pQlEbbWXP3+aotsUlWwV7oaApQJbh t2efarRqJTtP0gdjVhbfyfULEKx3AH3pEimUgrIqhe4+aBMmYzkcMT398fFIzJklmyBTkXEboA6Z PyfalkQoucE8dqC9jfvauHXGQatqN0b8nccbu+KCAMAAY+9OBbr6XJy1EodvbxNvR5iCwyM1IdD9 RLofV+lvqaoNPimxOWGQy/eoeWF0kJXt7Gmwjmn37vqbH0k9s1Vbw6w8Jen+rb++1aXV49O0pU3w 2Vs4V+RnuKxHo7rBukdKutDhtf4lpLMdpkG5lP8AqJNY50nZvqMTyXcxCqCMFzSItVfSLqaK3O+F sjkVGaYX9j+UnkkBO2Vy4+32pdtMGApYuTdzZc8MeF+KTKy2t0UVew3DijQk4QjJBNNGAZCe1OTL 6yNxjNAZBkg8/tQJgRA4wuSOxqZsdY1HRFdrG8a1LjDqp4b96h4UKMBzxRmf6drH6s8CiaWkf8yx llcvMeXPzTW2Y+oXKhBn9I96dM8ccgDKckd6dwaWl5/KjdfWH1YopzfWyG1h4zI4B44xTAwNaIZY Wb1ex3DAqrmS7kYRzExbR9IFTnUfWDdVafZ2jabDZTWqhRNH3f7mgjdLhjtbyC5a4AuIZBInHuPm nWrai+oXkjuVf1CSw9smocTqrY/W2O9ImmAXI9zzSBy6MtpJEihgTkCiflJbbTokxsMnfbQYXCgZ PGKMLsemUOfsT7UDJrdvU2n/ADSmUWy5fII71dl2BgxP1e/xS2P5hE34JQYGaANs812ZJFTai92x 7Ugcndu+n5rIbfXbaPRY9MltFjZM/wDqF/U+fmsfKbE2g8L2H2oE59N8jt709/id1qFothdsfyUZ zGg/Tn5xTBZFkJU4yO496dTRhYg+04+BzQAa22ho4ySrfNCtHeIlI22SIedwp9C6TRBUJDfJocrL GDjBI7n3NBaeSfAaZw+f9IxTYFVfcowKV6ss+MjC+xpCr9WO1AqS4ycJxmiB1CAZ3UKeLgnOMfFJ ij+lTnFBaRMn6O3vSra5nVxFFIYnzlWHeqfK5I5qrdDDKJFJDDtxQbT6P67L6bdafrE4lxAxR39m 9hWu9TtXu7uM267UlbDE/wDemRnlEn1EkkZ3fNHXUJLhAjZVB8e1blKeXXTj2Dt6sqypjgrTJYgH wB/ejCdgpDMQn/UaErNuDLyPasAinA+kbaJHIYhtAJ3HHPtQ/VZ1+pcftVombcMZ+9aiaPpV9IhW P1MOB7mmxRnLezDuCKO26e8tnViCDln+w9qedQXMBuVljwN4wQtajKIDNLhcgkd8e9PtHVo3D+qQ uckE0xWRY3LKuDToRpc+jEj7biRwg5wMn5qxe4em9iM8zgJOq8lSKAJ2mJJjVSTxgVsi78uup6B0 vDq91qMLtcci3R88fasAvtLudJlCyjevuwHArUnTmYTK+ck457VZCEbKkE0V5/UXYBmP5puoPGF7 VGoJMeD9X3xV44zIR8/NJVPU3gZPHOacxDYqkNtwO1SKLFagxsjfUx5z96Z3di8JycZp7aiC7Zw0 5jYcHPH96XcaPEihYdQNwpG7ce4NZEEQBJgRgt/1DNFVGKF9oRT3AopgaFju+sj3NIn4G4ZAPJWj UBmgRwCWIHfvzWXaX4ua7plnHp1tHZxW8a7FkMX1kfJPzWHq5VmH/em8sx2Nng/PxUnpWTXfUF1q E/r3V68j55Xd9P8Aim0+qNOuWfcgGMVj7G5KoyxAxfJPJpwgII2nlu6mqk9jA5lJU5jahSYyR/SK uoJc7FOR9quysGBHGfast4hPExAZU5FN3t2EgYrg/NP0cnAII9qqZdqZ2liTjBrOnaZIZlAk3/1Z qsF5WPBDfbmj3VrsmHPLdsUMRmMgY5/1VHWUwkQq6MD9aNwabvAskjAMyuxyWB71KyQlweO/zTGa D035G3PvRuVVppscbl2nBz2HzVT26lthOVPuKvAkcsjDHK9/vRreAC0kyh3A5HucVna7R0lsIbuF ypKg8mj3CKwV4MIzPnLDNOXykawxkGRjnD02aOfcUkTBB4xWkIlhCEH+o96XFamUAOhVSPcU4t54 4yodN32NGvtTV0AyCV7ADsKzsM7iBYUVY1VQO+0d6D6oL/pz+1TehJbaqWhYruxnk4qMJR7mUIcK DgH7U6XaPnlZGZgodjwAfYU703SreeaU3cgRQMopNTFp0/BqVqzRMDL8A85ppJ0rcW7751LqBnOa u0MLmIQvtR9yjsQapZNv6id3+qlzWiKcowI98c4q0mcMAATjjNUAml9QkA9ux+aagnn5+1OtuF4U F+xA9qLHHGVQqNpB5zQM4t0bf6R96OvqSsRwxxxRJrcKcqN370CKcRyvkdhwTQDF00chRuDnmpGC QnJGQuOKhnYPJk87vtzUv061l6j/AJqd1Ttjb70WJKPqB7mBLaRIokTsVGGP7n3pnPIO685pNzY2 YvQI5H3sfpPsf3ptIWR2jIwQe9FXO2U8jt2NU+SyqTjnvSoVH5aSRf6SARVslow3YigXkZwMfuaE v8tic5BHY0aEFzk8A+9AK752Ue/tQKSYRsNwx8fai/nN+Bzn5HtQ2s2AH/ehIjbu+KB7FPLOjI4Z 0HO8mm7QjaTvwKIMxIcEkGrLAr4UEgHuKAKqoB+rv2FO7NvSAJxz801aKMb9rZYcYNBuJZIogyDc fYUE6ZN8ZG0DHIqNly0pIANAgup1aPeo2lecGnZKtGWHFAKNtykKcn3NIk/mrjPIqiS2fb9qvjGA cZoaXVCyklcUh0wwb9K55pYYggsfoobOxOQuVB70DpZC7YWMEAY3UKWMkc8D2xRISwTORgDJFEjA kUPwMjsfahDJInLZ9jS/TCb17H4o8wESEs3B7UCZ0wrF+SOSKC52hchMn5pMlwSrIYwCff4FEgkj ICqwLfHxSjCruze/YUSG0K4+rbnHvToSFFOAN4PAHeiJGIkx7GhGP6w4PNF0M1zmAFjlvcUFnVgu O470J2IcyYywNXRfVcnGKGy0IMgJ7YpSuIYvfOferMpGAO3YVSrK/BXIHzQFHYEjg1TZ20La0bHn ke1KQt7/AKvigXCB2LcGiFQxwAGx2NCZSO44pSlsduB71NC6gk4ztFEClQMZ/wDpoeRtAX6s0RBK ysij6gMipsUqmMlhj6u60dHUqMDH2pqY2WRdwIJ70UyBiT2/aouypl3c7OftQJEeOVFCbg3ORT61 VpiAxzTm5t4ZNpI24q7EY4K8t+r703DMrY7mpJogVAbLg9j8UzwseQMBs+/em0DkdQfqHbtgVZ2+ jOOPeiu43EnGccUOWVzDgjj9qjZszZfjtVyRG2Cv1H5q0bZc57fNWZ/pYE5YdjQNL2YoiKMKfU7H vivQryF2Yh6Lkk5LO/BrzsulJvIHIyAcH7ivTLyPWkUPhxbPGOWkOP8AzXyvzPUevgnddFa/hVwD 96xa8ZRAxzzjtWU9QuqPKu3kdqw+8kBDHHGK+h+PPhHn572bdPp6+qIDzznitjysGeBDwFatedJ4 k1lT962LME/O24PJ3c1cu8nHD0X1a5jsY+MBRWjeuLsLHKGPcnFbq64uysCxHHIrQHW8u5ZAecZN fY/Gw6fM/Ky9ubPEe7IupzjcOcVz7rkq3NxKB3HJreHiNdH87NGThQe9aI13+TdPt7N3NObp4+HH d2ho4yM8YPtTqBn/AEkYOaAx38jkj2okc5C5b6ftXz6+vOok5VX0x7Zpm6AMQW7f71YXLyKoPHtS hCsgYkmqu1k/mZxlsewpJ065LqyoRk/VTiyX03H9Iz7+9TrXCGE4POOPvREJp8kmn3qs2Nu7AYVv /obUjJ0/IJVDAjgY5rQly+9owo2sGBrfvStso6at5B3Zea9nC5Z0x1VsHaPb2qClXJwxDfapbVHI uGLH6PgVE71Z8Ed+xr153UeeTt1uyiNc55+Pig+oQQQeaAbgvgH34pAcAkDmvJp20ctkZ/0n4oYk MTn6i2T2qwlUgAjtSSoc4bg+xqGjsS4jz2x2oaymaUcY5zQBktkMCRVSFgwwf8UNH/qEEoo496RF KEyMcfFCgfegXsfmhyEKSAP70Ndnz3A+jGMihvdliGAzu9vio92OcU6QKQAf9q0aO7e5xnIIb7+9 KMu4Fj9BHtTKdm4cHt2xVLclhggfvViDvM5PJyKXC4zluKaGZRwBgY7n5ooYKODWk0fDEhDZIHuM 1TxlQdp3VHGR89sCnFvNlSrtjPaml0WSx4FXVmGBxn5pIUBeOTVLKUXjGfvVZKY7jhlpDjOPmk7y ZMA96SxGDzV9A9vKShyuMfNWlORnPJoSOzHH2q+MgL3NOxQyR74pO0ftS2jIzim0u72PeqbXZ1QH aSM0KZBJGoPIByKuBtHbNWdjjONp+KAaRlxg5POaXGAB3pKM2csNtWZ/0gDk+1AYKGYEj96SWG7k AUF5irEdifY0kyv+5+9A5SQnO/t7UkqeBigwyttUEZOeacpKFYZGc1nQcrNe2dp6iR74B/UD2qOl 1GSdiZEYkj9RPanzSMqlcnaf6c8VH3BYnA4UnmtBEOWAPPHtRMEON3Oe5oXqbQQntS0+plJJoCMg VSc4/ags7J2G7HNLbcykMv0expvG2JHJGfYUFpC2wnJyaE0e+dSwbgcDNOUQykD9JpveRlFJ3EH5 +KNaAu7mKz024WeEzTHmLb3qAi+qSNgNuTmpGeXcCWOWXs2e9R4lxIo4/tWL3Gv+2c6DJ6kRGecd 6250PKobYedwB49q03op/wDTqBxu4zW3Oh0FtOGY59QY59q+dnj27cPeTb/mPjF/5VupUxk/wzH/ AGrxg0aBVgRc5UZ/zXtX4qW41Ty39QwE4/8AQsteJ0BdbmSBQQqzSAkduDis8ft15JpI3OzYnpsW 4pFmzicepGGjNEjUPHu7iqkkMaA5wBXZxjNOiOl9L1qS9ubxH/KW8TSsiHDce1MJdN0PUroDS/Wh t25KyH6s1jdr1Bc2InFuzKsqFHAPcGk6Pp1zvWSK49JyexPFbYux542trmWKPBjQ4VvmkRbi65xt qQl0ySxl2zusjkZypyKbMqK23GT3qJs4hCod7E5X+kVJWtwzpwDgHtUVEm4AHIOe9S1taSuwVMjP NdcJ245ZSH9uilgzg5Ptmpa0t90m9SeO1SXS3SEupzKgVjxknHasqm6fsLFiI5FklQ4bntXpkeTP Jj9kjgA7SactPrEKM9sskERGDIDgYqei06IwsYiGm/pUUz1e5vIdJlt3bY2f0kYrTzxiZkczhpGL yA/rb3rINAvLGw1KG9uIwWhP1HPce4qGs9NkuSqqC7t2AqZGm6LpdhdDWmliuih9FcEZNXbfi2T1 T1D4XeIFjCqWM+m6lapkyQDDS8e5+K0ZcFYZJFT/AJW8hT74zxT3TNfl0eyL2Zil9VfTlVkBOKib +UsfUCY3HkZqb7T0UspldV35AoiPI00kTRFUA4emtj9LZB7nJp+11u+kkFj7VLVkKi4fjgD3NSOn 6olvIAWEg+KiTK0xORt2+3zVo0WPD4GT2pKeKevb5LsMDGseSCGFNvXG7Z2H2qN9Yv8ARjKZ7mjx Ort35FWM05a4GSue/ufakoELEMx2gVfYuWDY/cVUEquWBUYFa2mho0WTI5IpGo7FjjXZkD/alG69 N9yKAPYULU75rpo1EQiCrg45yfmm00RG/prjHOKRu9TPHb3prtklXeJTEy+2O9HiLGDOMn5NNmhd wX7f96U+CPf96bAbxkcH70VGAXlqjRbOY8YJOfmkncRwKSZRu5+oHt9qSHZ5VKHCDuvzRNiAhNpG S1UyqBySKTkMxx9JpM0uGbB4PzQ0TLM0T9yBSVmYsW3upH+k4zS1YMoOM0Q+mANxFTao2VGYtkn9 /moi6QJuJyTWSssbFsGorVrQOHZWAwK55O2CCeTewwM/IoF1MSxHHftT22hGcDJamd7GckhctXGu 0Mwu8ktjFPnt4G05pAV9fdgL/wBPzTCR9qnIrJ+gfDqXrzUZIIbo2XpoZGlPOQKzJ21uMQt7X6x6 yvtLfTt5JrP+kvCi16hjeW61i2tJpm/lQMMMB8GsN0nrEdO6zeTehHeT207wRo36WKnGajtT6l6h 1zVZJreMQNM24xJwF/arpLU1110Jc9BXpiu7qKYSMRH6J9vmomOQLCo9QO/xS9asr+0eBdWL/mWX eFdt2QaZQKHYkYzUrUOJn3IBnGe5q0Ur4AAzj3q8iFTnaCPjNXtCAQufp9zTZomOZR6pcYAHv2pO Q8anIKHnIrMek+iLDqvVYLO61BbCCU4ediMAVBeI/Tdr0X1TJpej366zbxAZkjIK/wCaJsGAjZuG QR8Ve3umkdl7AUnRLW4u1l42lRyPYVaERi4Oxt3OG+M0XR9cMzemCSoIyv3pULBsqxyPmpO10/Tb 2FPzd4YCoyABwKvdaNapZGS1ujcnP6iuKsNGU8kcYLq+cDgVBandFkYq/PxSruYRyMHyPsTUJqd6 pQ4GCPYUrUiE1a8ljBbJx81jzSGeQ5yQT3qR1G+Mj7WwVxwDTVOAM4PGa47d5ibvCFwqnI+RVliZ i3OMf70ViCBkbSPikuwdCVOTVa0sqqFIB5+KRllPBzQ5ZGjA3rwB3+aPaW2pTp6zaLN/D/a4QE4+ 5qmyi5jHq5ywGAvsKaG+bDLv2nvmi3kluEVbebfIx5SoNpjLPtEEr4PIRCTmglATK6yCRlI4BB71 OaPpZ1m6gsfSDmdwDu/ehaB0dqusMrW9uyAjO2UbSB81sHRNM0/w3t59Y1e5hnmjQmKGNwWVvbit RjK6PPE/rSx6K0+z0XRIYJ5oYNlwxHCH7/etHXV1qM6fnEXcsx+rI4ol5qE3U+s3OozfQLyX1ZAD x+1Sz34WIQqAtvH2XFZt21jNINbp1ZCYsNjnPtT6zufyxMm3IP8AtQYo5NSvCsYwhPP2pzqUun6X bNbDfeXY5HojcF/fFYdDi46tulsDZNI/5RzkxE8E+1MbbUXguY5osxz44kHcUzCCTmRsIRnae4NS WiQwyXMayIe/+aCPfUp9UuJJrpZnlJ5kk53URkRYPULnOe1bc0PqfojQOk9Wi1HTvzutSDZCV5Az 7/asO0TSNN1zT7/8xIlvJFEXSMnG4f6R96uk2xqCG39DduBf35ptcxcYySvyDTi26fWaeOGNtzu2 AGOMCn+u6CuiLGGu1mHYqpyAfis6VC28giXIYsfg07ilDEswJ+Qaa7QzcDC/NHhUwv6jnMSryvzV B5uYfoH6j3puWKuMN9sVd7x5JdixenEVypFJhUNHvcbWzQOVRVIBILe/2o6XLl9m3aF/Sw96bKoB 3HgHuKPFcbUb013H2c+1FOxdFlKsxOfYmkXNyZCi4yE7femTzyE/Uo3fanNurMpDcke1TQpZdxJB waNGeADye9K9FguNhx7HHekPC8Un+kVKsWc5O7kftVo/bdkA+5rLeiZNIs9Ujn1pRNaIQxT3JqP6 p1Kw1rWrm40yzFnZGU7Iwc5+9RUY7kwmMnv70i2BjUANgj5or7SRx++PalqAxBbHJosFRWXa3JHu akYZsqdo5x2PvTASIEbB3n3WnMMqMBgEGsrseeTfGjgbW7EU6gbaM5JLD5pmCrkg/wB6cRSRxbcA 78cCinIjUHnIb5p3bsNg9h8mmaOZf1d/gUcQsOV4Aq9JD23KNnB574q+1VP1U3zuAx9LA44pbS9u cj5qKIGVVyORTeQ+o2f8ClEscHGARxmhE4bkZoHD3OICvp5zzkexpqGD/UQV496OmSWLDGOwHvTd 5frG4Aq1A32kuxPNIZUdCCCKK6od5BKg0zYbPqUk+2KAd0DnAHt7U3WIpHujOXz/AIo9wrYAGce5 oG7PHIH2+aBu+ovAwSRRkck0nSUvNU1KOKyAaWdxGI/cmngazDB2jYyr/VjOaa24ntdT/P6exiZG 3L7YPzRPpLda9IXHRki22pMovnAcKpH/AGqF0nTDqsM9xArAQqWkBGcAdzWxNG1Hoy/sZtX6zE97 qEefpDE5+MU96X8W+mo5ok0rpNVtmmCZZiSV+4rTPk1xp/Tw1aSKbawtl+pnY4GKkdb62mtoF03R SqRRjDSj9Waz7zP6VpGiz6DdaVm0N2okuLOM7cKe3Fam6Uk0wa1a3OrKfyBbLxg9xUlXe2T6X4ua 5a6FHpaLC6oxfewyxNY1eNdX8v5udjLO5zz7ftUr1br/AEtd9RtJ0zp0ttZBdr784LfNQ000kjtI D2P0gVNrIdJb2txF/NDiQc/UeP8AFM7qEAgKPp+1JEpyWc4bt39quMMg5yDRdUK2Ahn28sKJCx/M PuB/vSEUiThsAe1KgczbmPBzxRpaaFQSVPPtQg7LFlgR980eRiW+rgfApmu6Fma44ibtRNljdIzA d8Zq284z2PvVGaNsFSQtWjMEsihpfTHtj3qaNlpuMwdTlP6gaM7xrEwIPByP2prvZGYAfyx70WN/ zCFQBwe9NIJGBIMgnFJmiLDJ+aVbJsl3bsge3tV03SXBQY2YyTmkWBLj1ATlsUVhn6f0jNIOBu+1 JExLcDOKqJewcW2nzQZJ3cjPzUAWksw7gj1BkBh7ZqWDvHGGdNueVz7ikegjFVbl29qCI0+abe24 F88EtzinD8kL7fanzQekSuNh9h8UfUltolh/LxhWI+vnvQDsen73VkeazZI0QfU7n6R/amTbrS7F o0iTsT9Txjg0+Qoy+mzsqnuEbGf3pg0ca3jCBfS9vVzmgzvR/DvS+pLH1Z9Vt9KjjPeT9T1Edb9M 23S9tElrqlvqyMcBrfuv71jVpJdxCSElpk7L7VZdPaGUscg98M2RRKLZtsKkjOBzn3od4n5p9zc4 OVX2peVZ9rNgDtj3NO3ht7S2W5E24Hgqw4BoGIln/LKkduyPnlgO/wBqusyu+FheMr33dqc6drl/ p9xI9tcRiOQYAdN1N76U5B/qY5JopDcjJXAH+aWjrt55zSUYiJlPJPYmkTJKjD6cj3IowcIBD/Nw cD3q0kg1BFcLtwcc02kdyoQElW4IpauLUqj5wfgUWqurZAGG/EqjK0nQ7iRYfVlJ3nIAzjFO9Utj HEkrEAYBH3zSUsWtV3SAAkZAzxRC4NMjluGkluR9XO0+9K/LIkcnPKnjFCW5KtyueMZNKjkK5wME /NA3cI7g8gjvT6zxEQSdw96GtuXyR9Sn3p1bKkGEPJb2ozaSRHHdpcDLEP8Ao9sVn174iNLpMdod OgyF2iTb7VhscEdw4QKVzxmpO5063i0lXeYh0b6fmtOGXZnMy3EzSEcHkKOwpbAlOeM9j8UGMxll 2ybm91o5G48jOOwoxOoTbxm7kFuo28bi7faiLAhkBGCe5PyaVbvskJIzkYIFWSVWdhtGDxx7VO0D CehOJF+pvhu1Em1SeYrFISUPx2obY3PnmkqNrKfYe9NoKFCj6ccUtOWYYGD70AsRKwxkU4VigIKi o36LIAYZAAxjimsccTJI44weaU+7PbP70uGLMTggf/TRlP6R0voOpdE6lrF9qU8Gq2xP5e2jbCuB 8isesblr1QI+WI9varSsYEUqOwxiq0bUI7FZf5G7dwMnBFa0DG3iALNgODVpUCID3NNb2ZnIbb3p TXJbavFAsguhxwx96tHhSQRnHvSBMqgDdnPuKO2mzvCWQMxHJ2jNEO7AzW94ksUvounIf4q/WPUN 31newNeemHgQR74xgnHuaZBCQAdwJ+eKQ6B5XCA/SMsQOKJo3KiM7VbIHvRkiMn1ltxx70NcAExn j5NFhbIJA3ce1GiDCWQhI97nsPmtg+BOj9J3PViv1Xfy6ZHbIZ4HjbB3CsBSTbKHBxjtg0D0wZ5c lm3e/vV6Z0ynrXre9631e6S61Oa50+1uZVtQW4K+xNY5E0aWaqJQzqdp+aaWulNZuxV/UikP6TTo pFFHtVMbf8moSFocoQOwp1a/l7RUeQJM8g5jI7U1treSSOSRI9yoMtjkL+9XMivwgBcD9XxRoKRl iuHEmEBOQP8AxTaZo5jtVmyPbGKfWbRxuHuU9ZVbkfapfq3qKz6gi0+3sNJisYrRT/NRslye+aJv sfw16hj0Hqa2uoiFlhOcyHisw68Go9dta30+iQW8Fu0jrc28e0S8e5rUn8IklcTq+z5UHk1nUniz 1HrWg23TJvE02xT6GkEYLFe3/ajOUrBtMiMYml3FUJJTPvzirNcyOW/lDcffHNSPUFlb2txBa29w 09vEv0ysMEn7imUUpRgcgmjUEt1dUU4wfvS2ilkkPZU+aX+YEzAhQF+1JuJDjAOc/FFKt7GRi7Ft iDkkml3WlQrbpJ/EYpGfvEvBSmsXqzwvAsmGJGM8VIa/0s2g/kZGuEuVnjDkoRlG/wBNE7RjqUjC j6iD3PvUno+r3WkapY3dsd8ttKJfSbscewpm8ROMDaB70OV8KNuQw9xRNMi8UeuLXxL6xg1GxtZ7 S8WMJcM5+liPj9qY6zpr6FpcN5NF69xckAP7t9zWOr6qT+ohw47Y/wC9PLnVb6+aGOcs6xjag7/4 oulgBAA5O525KfFDluG298E8cVJ6tYyWE8aTDMrRhsY9qjhCAwGffuaGgw5jVBJn6jgY7mnLST6d OIY0AL4+phzzU10l1HovSz6ldajpg1XUHi2WsbnagPzUUde/jOs/nLtViZzzGo4UUZN3tLjE6zZA YZIzXVvgt49dA9MeEUuj6lp0S6r6EiHev1Lxjj965f1FlSaUsfUUn6cHsKgkUS3EziPEmOGNanTV SDyzy/mriGP8rptxcGSOFvbJ70aaRYl3xvv+ngCmkDTi0RJSXbOG+BVGC5uFWWKB0tQ20zkfTn96 lTsnRLu3t78z3O4NuyoHcH5ot1NFd6lOztuic5Lfen93pVpYW8R3etNJ+pgO1Rd3psVi2FlJDfVz UNnur9VaxPo9ppEupzrpNpIHigVuCw7Gm9zf3GozG4vp3upWXALnOB8VfTdIk1dhziNe2felalYv YyhGUg/YcVd7XROmx287+nfJI9tnlbc4P+ad3LWEerD+CwzJEI8SR3ByxaooO8SEqSDn24p/MfTs oZkJNwThdoyT9qmlN7qSeN2WWPAzkYpCNlmOO9GuFmFuklxFNAz8AXCFD/bNMcNC5y24j2oHUBMq F1G4DjFXeZ4zudOKtZQy3U6w2URmnmOFjTkn+1S2tdLalokcaXgWOVhn0yef7igiSRcsszSemo/p +aNdxOuCVxnt80kSIFAEIMg4wTRFuZLlT6p3NjAx7UAEjcuRnBxT+/jih0qxmH/MkLBx8UxP0wFu d3bP2okcsmoxRwLHJII+SVXOKBJBIXjP7VdHVG+r2pdptjumDqcKvahTDfKcDAPxQO7KKCa9iNyM QlwGZeMCm96BHc3CxMWh9QqnyVocCjftJJHwTxT+BkgkLCEcDA5zigYwQqveLAT9O75+aWyEMSDn I7U7uHWZyw/Ue/xTd1J+occ+1AIuw7Uc3jRW5SNigJ+rHzVki+oKe/xTy3tkdXeQcJzj5olMLUuF dwcEcjNPr69/MqglQbl4BT/zU/ZSadLpJ3Qhvn5FYr6QjmlaLIiLcAnNT7IUyYXJ5A96GXIPA3Uc ZbPGQBQWAABHFVVbWOCRmlb/AKQD2+KuJoYm2O4VyMgZ5NHurRre3jlOGV/vyKAaGFgQsI9Qf1D2 qm3glOMHGavLLELUbEMb4wxzyavd3UcbRnIY4oFBPS5JwKG5YH9ZAPOB2pKysoYthtw/xSC4/qOK C5kVeTyakbxrY6PG1uiteBgT9x8VH+ipX6hjPY/NUIdrHLbR80Er1TFptqumyac+8yRZnX4aodJd x3YJYUp4s8Ad6JEnp9j/AJoEsdqsHB/ehDYqKw3jd2J9xRpGSf8AlzfSh4JHxU9IsOq2NvY2EY3x Jwx4IolQCt9eRnP71cEEduaHtZGkQ87SRilRx5OR3opcGDIOKKlmmq6pY2pxb+pKI2f2APvSAmxe 31d8UWGNJRlsrIOQfg0G2+o06Z8IbGKHppl1HXLiPE93Jz6RIwStaeuGkuLqWe4kaWSQks7HJJ+9 LS3uvzJadywIx9RzxVkzFGys2XzwpFGdKhlOMMuQOM0b0PVIC/2q0UY74GMcnNFM2BhACfn4odFx 2zWwKkck9jQmUM+CBxVobgNIY3cFwOefaltGJGYoGbH6to7UOgiMcfHvSo87c5JyfftV1AJYNxS1 ZYduTlaLsaX6UVhwGoCNuPIBGe1FtonuskLI4HtGucCg3sItWUKrM7nAT3JoyKYU/MK0jiGI/SzH sKLqVtb6dIWSb8zbYyJB2pU0X/pwk8RjJxmNxyKyHQtEHU/h/rk4SNGtcqsbHDEA5yBViVi11pur WlpBqN5pFxbaVcHEV8w+g/tSkU+oFzuzWY6x4n6r1N4V2fSF2I5Le1IImC4YY9qxGyYFWkZSvxUU UIsTEMn0+9CllRJPozgc4HzV7m4DqQGzn4pxoJtLa/tpb0GW0DD1QBztoGcspf2OWqa6Y6T1LqCW 4/I25uPR4cZAwab60thPrU1xpRY6f3RXGCKJZ3txaO8tvdvbbuCI2xn96BrqFpJpkjxTrsdW2Mvu rfFN4DjgnP3NF1G4acxlmy7Py5OSaQMAjBFAeJM54/zSjGXQ7e/firK+4HDDb81ZbxYHJHYA8mgB LdARGNQSx7mpC2muG0draEFxnOD7VKaTq+i3OjNBNAEvFB+s/wBVRmmX82lzuixCSGUY59qLUdAf SLCVcg8UdZJYIWjF1MbfuIpGyFP2FCvBIZWOzABqe6J6JfxBF/NNqMelWtjFvMkpC78e3NVELpd8 dIm9aMCXdkFW9qu3UYtrtwC3836fy6f159qYsoUsEbKI5UMvOcHGaedHaS+o9Tx7ykc2d0TyHAGK s19l7ZBrHh5qOjaZHf6nZSacZxvh3jhgRkViplWMFXIDj+kVtrxR8brnrTp1enry2jiuLQqnqLz+ n4P3rSnpS3Wsj1Mqp5yK1lNQkZFY39vZ2OoW8sRkluVX0pB2jx3pquJIiVU7T/q5oIjZZXU87e1L F86D6QNw4xXMFt4DuIXKgj/NGh0t7tXaNfpQZJFO9Ps7ifT7i9mXCwDcQeC39qjf4jPGzGFW9M8E fNZWKtLvaH9UfUDgBaqWdWkyuQD7GgsPp3Hgn2q/pFlBB5q/S6LjJOVIBXvg0sRjZlQMmkKuwHI5 pBcKQDkVdKuBt4ANDEjJMo7LnnFGkzyQfp75ps5BIb/apsFvZUjjLDcIz3zQ7a4yNwGRjvUv02ul 3VxcLq0jC2ELEAf6vaoeaW0W5P5NmeAdsjFNh5Z+otwrQD+b2p3JpzXTssy4kX62XNRsd0ijIyG/ 7Uv8z60i5LDdgbi1UEAjkDrGm1gcBaAwwxj7MtO9a6euOntUiju2j5CvhGzkEZqtTubeRv5Me0kd 896MxHtL6ClsnHzmruTwG4Q9jQ2ZJotmwoc8tRZGMwQHsvajS5BZPT7AcgjvVD9J+PmrYBHI2mhk MxGDwPY0a0OHAIVjlfigRW8l1cMkQJkPCqPc/FLkQxr9QIPwRTu0aSzRLqIgzIwZPsRRNG1zY3en sIr23ktrnuUcYJHzmlRRrKCrMFZRkD5qZ6m6h1frRYX1SeNpI/0lU2H+5qAlsmtc7XAJGQwOanZT yOOJ7f1HHHuKYyXCRzhCSISw3D7VJ2d7G+lejJDmb/VmseumjSaBrhikJmRGKjJwTzVRtDpXo7pn xA6ij0axvJbWb8sZmknf3HwawbWNK/gmr3tiJPVFs5USZ/UKy7xO0Lpzpi605unSYMwB3khlO7dj kZrBZbhrpjI4JLdyTWdAkQ9Riudp+1GEpViFBKj3qrcBUIUhVPyeaPFKZQISVCA8GtC4so3tZ5xc qJEYBLc/qk+4pxZW5t1eSdhGCMAA4yKjvy/5UjJDMCSHpzaxx399GL6Ui092HtQVd437/wClv8Uh Q2BgAn2qtSWGK+dLeTfD/Tn2FAScgcHLE8fagVdTmMlGQqW4ojAehmQAr7E03mjachncu1SNtBb3 duqSuQUGeeDQNhE4jVtv0HsxoZUMSxGJkOV+G/elG8AgFqpLRb8jjtSVZdx3MqY4yxoJXWuoT1Ha 26G2htZrdNh9JcBsVjfIY7QN6+9PzjJCDJHG75ociEH6VGD3NBN6bLbyaIiXMas5k3lgOcfFNp7e 3B3RB/qPYmgb/wD04TbgAcc029doznJOPmgVJvj3EdgaILgCIYB3H/FAbVWRZA0QZRGWB9v71lmh +HfW02ii+fp8LpsiCVZ3bA2kZzmiMWd5pWUKMD5pbv8AyyWGD7YqpI5o5HWUekyHGFOQasCWbnkD vmikxXXpwsqEqG9hS0B9PI5x81aK2DuHzhP9NFY7mIXCgU0hNpLDZ30NzKC6xMG2ezfassv7K013 dqdltjLjc0J/p+1Yd6PqHOcY9qVBLLbnMbMo9xng0OxnbLFxwAcEUEvvJPYd6ptrq2c5Y5IpVvbi 5uljZsIF7iiiWE0JunWcmFEXO9uxzTq/0KWzX12YNEeV+4oGpz2tzAbVo/08Fx74pUGpyW8kKTH8 zAi4AzQM33AHnJPajabLJHcpHDHuuWOFx3NHvB+YBkjURr7qKa2chtbyK8Q/XFyBn3oJXqbTdR0u 9SPUY/y7yRb1QnJxTHStPuNSv1t7cbpCOMnGaNqWvfxgubhmecDgMc0ytJisqIrEStwArYP+amhJ dTdJ3XTssCMQ7SLltp7Gog6fLucbvqUA5+akJbXUN8kU6yOqDdlmJ4/egHfFGWLKi47lqQKEOBtb ggcZocsTxhWk5Q/5oS3DyorDLJngmn+A1oS/1P7GqkN0G7Pqc47UuPDIwAwB80OfduUIM8c1WAAN h3H3+KKE7FTwPpzx9qWh3Pt9sd6q4UrCzsNpGOKX/Dry6iVobeV4yOZlX6f80GT9Fdead01Y3dlq GiQXxkyI5GX6x/eonV57W6Z5bSJ4YWP0pIeRULcWpjuPSyWlUZLD2qrm0mdEAkJCigcDc8TFI244 yBQJ0KwKSpZz2x70dNVu47JYHZXRDx9PNIe4kJjaT6scDHtQAlicCN3Y5A/QpxilRgfHP3o0qrIm QpAHOT71bT4PzbFQQFxggnFAiRCAAccjvQmfbtG0YqUvrGytbWEWrsWz9SmoqRSvA+aA+3AXIx+9 WeQNx70lpeCx5xVkA2s5YFfmguyNIpLfUAOMd6tAhYhxuUDgg8Zo1nqJsry3uFUN6bhip5DAVJ9R axHrN3+Yt4ViJ/UqDANVrSKki3AbzlT7UreFUBePtSfUkl+ll2haTIIypzltxA47ioyOh+tdw/bH anJi90+nishvvC250bSIdQgvBdW8qhnUEFl/tWMEPA5UsTIp4T3NajOwi05hkQNsI7URMfkUcnLA c0p3LRsZBskIxigRuEiCMfpJqroUbniDBWx/qAzUdfl4N4bcN/G9RyP2rIIdfnsYDFbBDHL9LBlB pzp1/FZ3Md00Su0bCQB1yMitRmnFv1PeXem2ULahezrAgVUckDj96a6jrd7dKFMLCA8EmsyuvFeP X7V7ebSra1IHEkSAFqw+91BbncQgQdtoNb2wZnDOijKqOeKK8JYApkN70AsAQVHahtctG4Kk5+Ky 2M52DjgnvSFkYnABbFEljMyKNpOByRR1tmitwewPBrIjkkAZt2QGGMHtV45SpIU7B2NLmj2MTgEL xxV4rZp5Y1OAG7E+1RatvH9TZIoLOW+4NObrToYnJ9XdIB2Hamudhxz++KlagEp9PcQOfvTrQx+Y u0hEAmaU7Ap+abz73x9NMp1kigaSIssqngqcGjWm15/D+30zp5J75hFcg5Cbh2rCNSt47VyUXg9j TM6o88EYnmmkbbwHkJoc1wZioJPHYVXOb2cRy7RtxgmkPKhJDcfc0Le0mCO3xVjCzMT6ZI+aOkGJ VhkE4+RSXnSIYDFh81ZYmyQOBQmSINlmDH4U5rLUpI9Fi205Y/PtQJYHZwVOFpblVclV71QkZUZW GT3qV1lBK/Q24NtUZNR0rjfkjcvcZpxK0ygGMnZ2bNG9OK7lAkb8vGwwp+9ZdYjoWEVzwMgij2+o TQzF1iyiHsw7ipRNAtIXQpPuI5Lfakan6YcBZBLGPcDtU0sH1Xq1NbhVJNLt7YxjAdFwx/vUG8rS fW52sOB96RK4L+nGN6Egb80GYSS4hLfXC3BHvSqXKAfq2kN701CpMSZMhs8fepC2UyWze7e+abSW kxk+iJ5eM4Rc4poZLY6TYJYiWCdVnYfVuPasbuE9WeVUGADgOPegZZTghlbOCc9v7U8t1jbIbjnA poMLa8m02cbGcEHPB71Py9Vz39usLKFXGGaoa6iX1CAMAe4qo7dmOCMofcU0FSMUj9JAPSLZJHvS mt2nBMYLDHBoJlFu5iK4jHuaV6npbmDkrjOBTQZTzGJDDDlZ+7E1kEnQ2qDSYNRaNo7V/wCsnINR cUcasJok9QN3z3p9F1LfC0h00SOLSMkpGTkLnvU20PJ08qwRsszF2OAuaS3TVxO3pmP0zj9be9Lj 1KSORCvBjGRmjTdRy3f1TnYB+nFXaaCl6DuILdJZJUIPsnf/ADUNNbmFmj2AMDgZH+9ZNa9Wi3tJ I3h9SIcgls4rGbq+N9cNOv0x+y1NodJtO1MHcwzyaFOCWAIpIljk2kfqAxVSXMaKFPL1pouJGjjZ M/q5xQZZFVlycfNLS5Ek8YDHGMYIoV8QWHPb/egKsrAAf0e1AZzFIWHLilxszpzjFNlObkIV4I5N A/a/JtVGPrNDcltpwfvVmUKo2DO09zRN5G7HKDsaArBdq4qysI1LDORSBLyCByfc0QHaoLHgUAXA Zw6L/wDLPNOreON4VdcMCff2ppIDMfVhbag7j5o1rCpcmM7A3+BQKnhCjIGBQVOFUf7/ADT+RRFB 9YDtnO6m0d/a+ptKMx9+OBQ0ANuP71cRKXODgkcc0WaRZVyqgCgrGBGVKnLng/FBd4iVxngc8URN qp8n3o15YXdqilY85GQT2NDEU0mxI1AyPq+1BcJCHzyPtQ7ovakEDd7Y+1KniKBf6j70qVPUCsee MVnaaILwtCHkO8j+ijk206KY0Xdj9IplsWIlyAce3xSVPoOZYjnd8dq0py8EaMp2BW9yKc2Nmbsu AdpRc1HrcNJjBy3vmiJd3VpLiPndwxA9qEGkDRKRnOO1IZfUT6cY96JIWk70HcFbkcfAoFBVGGXB 4wc0lpARwcH4FLfGe2AaSjRbGyM/BoaJU59yfgijbjsABPP3pKxIuDnGewpXGMYoEluTxnjuKXt5 UkcmkxxnPzS9xGOKBLM36eQB7/NLQqQG9scirnk9uPalRwK4IxjPtQCyqlTjaftS1uGhfIPNFaEe mBnd96Wtnv8A/lWaA/nfUBDd+cmkqhK8CnD2ajGBu/8ANIEO1WJyCO2KjWhbeX0B96qS7dlHvmrx ReqfqJXikvbFIyc9j+mhoq3mee6NuWCEDORTVoHLFwwYDiiLbt+aWWIYIH1n5oSPGHYqSAPaholo +dzHHtxQ5WYw71OVHBBo854QjnPtTa7UliFO1R3FDZvuGOD/AGqmOScc8Zq0KeozZ7E8GktIIGx7 nIxRNmQcysgTBy2P2r1F8lth+T8MbCMj6wwbP715eWaob0wMdu8ZB9wc16x+UnT0tfDLTV3ZcIp3 H9q+X+TrLUezh3K2n1Sw/NS474rC7+YeltHesz6lIN5PtPHtWD6lgBvY19Hh/i8nL7P+h4lfWBu4 AUkfvWwU2yX8TtnbxmsE6ECz32e2FNZ9ZFRqKx43KVBxT/kmP8UT4huu9Co528Vz711L/KkI+9b2 8R7lmuUCrhAp5rnjr+9VFmUd8HBr7n4/WO3xvyZ8nNPiPKTeTEnIrR2uSl52bOR71uDr64bdOp5L Hv8AFac1b9T7jgVy57tjg6qOgZuQBj7052liCRnmgI6hTj2FEWRo2Qgbg3H7V4H09HpRUPbj2osE eDgf2oTfSBuO498UeJsdwCx/2oHEtsDFnscU0feNoyxycHHtTlrlolAGP70NpRIMnlicECroJsoi dUSPl0LZJY54roLTJDZaFCh/TtBFaD022ZdYhC5Xc4INb+9EnTYQBgbBXt4Y4Z+kDqEhZGYHjP8A eolZd2Sn1FfmpC+DEPGPpOfb3qHeAx28zq53NwBXTkrM9Orhn1Bz7VUZJVyTnmqqqxXQ69FWTcc5 /egLl2HOKqqqBS/SWqpHO4KOAaqqoHEZKEc5q27IINVVUPtZgFAOKpJDx96qqrAcXX8rbt7Edqbe pv7KFz8VVVViVU3JQewNF3fVtxxiqqq6MrGQtyfb2pDymNOO/wA1VVQPN5t4IcclhyTQpeHK/PvV VVbZUGOc1d22jnmqqqlF9xjbiqDEsrdjVVVUEdz6ZOe1DlIyPpFVVUCJv0nHFIViyqTzVVVAsYlV tw/TQJIwFyuQR75qqqsBsMuck5Oe9E/o7c/NVVVsWYbZQue470rJ2k/FVVVz2L+qSf7UD1i0oU9j VVVdBdhmqJwT9hVVVZ2EMWPdiSKSn6x9qqqrQkYwpDHH6RxUbd4kTJ9/aqqqVpjN0SjNg4x7U2jG 65UfaqqqzPS1nfTkImjKscgLuH2NbS6NcyXEatyFxiqqq+bn/J6fx/5OgtVjW98F9WhkGUeF1I+2 2vEuQbdc1W3HCreTAH9jVVVTj9unIIsp2AAY9qavMcHIyD7VVVXVwgttGswBYcmjhyrFB2HtVVVb ZosczAkDjHFHgG9hnv8ANVVUEjZQDLc9jWS6Io9Vs/VtqqqvRx+3l5Wy9J12TTOgOp7mCNFuYhGE l9xmsHsNSmn3u7bmI3k57mqqq9NfPqRtNVnimXYxVvml6jdTXbASSFifc81VVUWJ3pSZNPvLZzF6 vPbO2sS61159d1qWSeMFUJCoWyBiqqqwiAs4Fkkcj6Ax7CnMq7Vx3/eqqqk9i0BGxsDGaDMf5qsB gjiqqqV0hSsxj5JJ+aW0hjjDcEn/AGqqqkZpaD1IVPbJp3HGGg29gD7VVVW4lLhP0gD+rvScEOdp 21VVVXSoclsMS2KmLWBJ4wWHOO4qqqjIGs2iWU8SJkgjnNEhsUk0h584IPC1VVQRcRCrkgE1QIZA 2ORVVVBVrL6yklQCKS/Eu0cCqqqNKY4dQKHN71VVQ0WRsiOKaiYsq55z/tVVVYb0G7sihgeTTW9J MZ5PNVVVnJIYGf0DGVUZbgmmGoqXbG4ru7kVVVXKvTALW2W4YIxOB7/Nbq8EtJW+ttfT1Gi/9M0Q Ze4GDzmqqqRyrX3WHh9o/Tx9a1SX1MlmLyZDN7nGKgum7wabqCT+ik4jO/ZJ2P2qqqq6QPrrrKXr PXjcTWsVr6CBFSLtgVjgxExZR3qqquddMTmabZCDtB/egwXDGQYAA9xVVVRo+vTLe2LqkphCrk8Z z/2pXQujW+oybH3oGDH6G9xVVVbZP3Z9PhkMMjr6oKsM1FwxiA7Bzk5J+9VVVgOWuC2yPH0N3FZL oKGW4gh3ARk4Ixn/ABVVVWCJ8RtKi03qSW0jJKBQ2496wy4tVZWB/wA1VVVrriwrXrYRy8Me9XgG QmfZaqqrg7xU4wpYcU3hh3HJY1VVW0ZR09ptsVUTxC4AbH11ujq7qN+lOm+n9Ms7WBba/gaWf6cF sf05+KqqrTCF0fw66c6700Xs2nfkJw+3daPt4/xV/wD6t9J6R1E3UXq3JiGFWRsf3qqqjDVnXPiH qQ1qaG2ItVUFQU74rXmpl72N55ZHeQsCzMxJNVVVzldMTu2kSAQLHGFXA4zS3HqzspJCn2FVVVp0 Zb0ZpkE90iuuQ52mt/8Ai7J0/wCE3Q9nDpHS9iby7tVeS8f9ZJ98Y71VVRwt7cpW0y6nNJK8aqzt n6ewpv8AnZv4nFAjlFzgEd6qqrDvicWsHpNcSBjuLAf5p5r+jLbxWNzHKVyR9IHv85qqqpQzmV4I zKkrK4yM0NARE6sxfnOT81VVVFiSPpGMH7dqdWx9QLmqqqBcsSq7EDBxmmiyH1B8AVVVQLMpYgH3 owiELqinEZ5K1VVQFSJWDNjkUa2bscc/PzVVVBa6vZ7oBPUKBDxtFLyzD6mLH5NVVVmtQJrkj27H j7U6hH8sj/q5PvVVVRS2G2TANEjYewxxVVVFi5kIlUYHJ/xT08duKqqrLRSuSuTT60AH1nlvn4qq qgd2IEcu4DJJ96mpYhgn/aqqqJDJgIi+BnbQLqUooKgD7VVVRSrZ2lUFzux2FHMQ35/2qqqgcMwj 050CjLPnd7j7VFbBI4J+aqqoE7A0Tk+xocqCJ1A5BFVVUDcjMnJOPigh/qcYHNVVUCdhLA7iD9qF KxZCcnPbNVVUT6Rsh9W9ijblG4xWwvL90zBrXihZafM5/LpKGIK53faqqqJQ/M5qzat42Xlu0Sxw wRC3VFOfpU8VrPSoRLLOjncsakqKqqqxz4jtZT+VjPABPYVeJsD9qqqqO8WlHBPvmkq2Ru7faqqq IPBOAQpjByO9LMYDbl+n3x3qqqjQKncWbtV5o1uVWKQZHzVVVGatHYxCRGYFgx2lfapKXS7QXiIs IUEfPaqqqCO1GJbe49BQDEfYjJ/zQGUR8KNv7VVVQW9Yqinvmrov/qVI4NVVVIsKuDgH700SVg+0 YG7g1VVVQ/uy72BVnJ2cg1eSQoyOOGVe9VVUFnnZ2DNy2M/vVlX8wGdu47VVVQJKgKGHBoMh3Jjt z7VVVQGSZkCgHnHeqlYupJJNVVUShfw8zWpkWQLjk5XJP980BCbmMJISy5xtzxVVVGVW0KhsAEAd hmndriQzbxv29s1VVRsLG0Bzzk9vilxTNNLKGOAFxgcVVVRglFwU/ahTymO4Rv1bzjB9qqqotSmr W6t+WhOSCN2c0lfrGxyXAHBzjFVVUQ02/SxyfpOKcLHg5zk4qqqgNaL75474o8jYKuAA3/aqqqRz o9tK3qsRxilS3TzTrEwGF5zjvVVVacC4FSbEmwI32ogJfLZxVVVE+i0PJ+9N9x9QgcAmqqqIKvLb T7+9Iycjnn5qqqgupywB5zRf09vmqqqNCPIdhPx/vQVlIXd9+1VVVllW71gCeKS0Kgg/FVVVoEW2 DqcsaZSoI7yNB2PB+9VVUBLuyFrMoiIRQORjOac2d/c2yL6czL8Y9s1VVQVNO8ocs2WI7n2pzdx/ lNOhSNiDNHlm96qqoGtlCjQFSMgUqdBbJHs43nmqqqALIElKjgVa1BkZiWIwcVVVRalL7SUtolYS MzEdz7VH7AsbHJJI7n2qqqhGWdHwRW/QvURaMSSSRgeoeCOaxCKERQAqcE9zVVVEJSQoSo7Hg/er YEDMEG3I5+9VVUX7LbTnFsl0twy4/ox/5ptFIxlMhOWU9z3qqqhDy5b8w5kfkgZP3pk2c4Bxz3xV VVGYtA7MGG7ApZkYpuBwV7VVVRVnj3MrZ9s08QnKBju+M+1VVUBpubYt8GmXZ8Z4qqqgvJGIUWUf rLYzTvR8DqPSUKhla5UEGqqqCY8R5ynVd3sAVcbcfb4rEvVYYOc1VVQTvT9xF/E7eGa1juI522OJ P/FZJ1B4caZpt5+YieX6lLiPP0iqqqMMUhRL2YwlQgDdxUfdWyx+oV4K5xiqqqkbq43R9Ns+7Mhf duxzj4osXV15edLLoTBVtYnMmV7sT81VVWqLtOTaRRewXue9XFol8rO5I2LwBVVVRgu2je0haaOR l28hR2plf3k924LynLN/iqqqNpbTOlItRguXe4kURLuwP6jUfMGsLrTp425gmDAfOPmqqqZESPWP XN7151Ar36Iot0CokYwOPeoVz6oZiME1VVQO+nL6XStYt7q1b0riI/TIO4zR9f1W71LVZZ7mdppm 5Lt3qqqgZxxh4llPLGi2UYMhPypNVVUAYmJjcN9S57VM6L1RP09BKlvFG5nG0s45FVVUEabky3eS oBYc/wB6axrneSf0txVVVA6CrImMY47irkemmzv96qqoKQZdQeVPtVTfQzY7Z7VVVQKsgJFZ2zuX safRPnjsNuaqqolMxO6XLxBiEcYIqpYRbRCNSSF+aqqqfZAzKy2xxxvO00m8+mAECqqqqst1vpPT rTw4stUWNmvpJiDKW5x8ViLFjOpJyAo4NVVUCnG+QjsKoQo31EdhxVVVBaNMqWyePaiJGrR7iMkV VVQVETKxUnhe1XR/UOG5xVVVBc/Shb3FAVi45qqqguV2nuT+9SOnTNHE8sZKOfpyD7VVVRKZTnYA w/Ux5PzTqEBUBA71VVRSWUMw+1LSTKcjJz3qqqkFXkbKgYOfio+1nc3kqsQw7cjtVVVBa4uXtLhY uHBbBOMVNaXpDanaXt56/o/lx9KBM5/vmqqqMJmbW7a76BgRdKtobwzembxB9ZFROhai+jfmgqrM JEx9Y/T96qqpBI9T6PFp9ro11GTuvofUkGOAftURdIIXUL2+DVVVBk/Susv03fStDEkourdiQ/8A T+1Q0WqNZ61b6m0SzTW771V/0kmqqqAmt6xJr2oyX0yKksn6gnAp/wBHXZsJ75wgk3w4Kt2qqqrE qNg0MT2Gp3gmKei4Ij25BzT/AE2wiurRgwPAqqqoqBKCOeVMZANKhBHvjIzxVVVBOaFp8VxfrbSZ KSKzEjuOKhYyVd1zkKxA/wA1VVQKjUTNtYcAZpMjlELDuCKqqoJCCFQyhgGDDmpG90a2l1GJQpRC BkA1VVQRfUWlw6TdpDCWKgg5Y80XU5DHaRCPKMP6gaqqotR0GrTCEhwsn3Iq0U7zh4WYiJ/1IpwD zVVVEP306OFESP8Aloqk4FA0jJ1e3lJyIznZ7HjtVVVCG+pvt1KZ+4Z/0/GTT3SYkm1JUdQS/G74 qqqr9NHWuWa6bu2MWIPc1DRy4uFOByc1VVUZSF7q87EKrbIyo+nvSIZWbKg4XG7AqqqstQKU7sq3 Ofeko/LA84qqqr9Kp23DmgKThzntVVVUHXJtC2aZNKXXd2I+KqqoEtMVWQDjPHFVafQBjt8GqqqB 8wAXIUZxTWWQjIqqqgJcXElyDJM5lkwAWbvik5KsM84FVVUSLn6yfalMgXtVVVFWU4cCl2kImuwr EkY3VVVRol7qQ3DJJtdVOBgYI/vTq1uvSkP0KwIxg+1VVUFihK8sWBHY+1M5PpcgDAHYfFVVUSrq xH054NFmtYj6ZKZ98ftVVVEgJj/NTbZCWB780aXT47cEKSQvsTVVVA+0fVksUuYGs4bgy/8AuSD6 k/am+pQoqqYxsJPPvmqqqBs7kSqDyD7VJnS4m0szAsGDYHPaqqqCPezSOIS5JbtQGQKSRwVGRVVV AfS4vVnk3EnC5p7JqpSFLX8vEwcbjIR9VVVUDWNFyVxgHn9qyzwl6I03qzq1rXUlkmtkQt6atjJq qqlENr2nxafq2p28A2RQTskY+FHtUPD9eQf3qqqgkZYFS3Ru5ao+6UFT+1VVUaM5og1vJCDgSKQT 7jmtk9N+ZTqy66Ck6PnaGXT7dfSWQr9e1ewqqqjnk1/NqUtxcS7goCn2FKRvUz7ftVVVGhZpCIxj jHxSclgGPc1VVQLL4zxSlX7+1VVUFbRwMf3pyIRbNleSfmqqqAenXo0q9hvjClysbZMEoyjfvTvq HW01eYMllBZAc7YBgVVVQR+47VGTg0lkXdgDA/71VVQBlgUTF1+khaLHEqbJMZk9m+KqqoHEWt3c XrRmQusi4O72Fbe8IfBLRfEXoe61jUpJluE3AKn6Rj4FVVVqDWmsaLFptxJawsRHFJsXIzxmmSRb bn0ixK4/aqqqiQm5CxglVxmmiNs3YGMiqqqiktMWLK31Agjmst8NfES+sundS6faCKe2eXaJHH1q PsaqqoIzUI0E8iquMe/uaiJVMIYBjyaqqrIEkY5Ap/pOoLplz6pgjueM7ZeRVVVaCr+6/PuZdixB jnYo4FNHhWPBXiqqqBDTuy5zzjPNA37k3Y5qqqgXCikhmXP29jTe6uDHK0SKqR/6QKqqoEWzlwST znFPYXKDK8VVVRoRpGBJzn7Ve2RWkAxgk96qqoyldE6qvrG4lthIZI1GBuP2pnLMZ9RaRsbid2aq qrUYIkO6Y7hk/NNWAMgUjIqqqqJHTtj4DRqavdxBkOCVB9hVVVWFMYIh6gQEgd6MV2MxyTVVVaYg KXLG5VDyDTuVwrBAo+od/iqqqNs8u+kbXQtC0m7SR5pLyP1H3+x+1Y9Ji9upbdhtRRwRVVVaZ2YX MKWW2JRuB9zTR4sq8m4gNwVFVVVybocUQiYDJYfelXL5GMe+KqqqVqAuv8vdQVbcwXtniqqqy0m7 G4gj06SB7OKV35Erd1/aosIs0zKVA2DjFVVUS+yWO1W+1ULiVSAHOC20j5qqqtspOGyiZgGBO7Ge acajodnp916UUZ2bQfqOaqqoRFyKpTO0DFM3hX1h9+KqqrFdsAmtQ0ytuIB4K+1Fh0yOf+W5JVjx 9qqqo7xHOx0yS6hUmRB9I3fFAtl3uY+wZeaqqrJCZLZYIzAnCjnPvTObKAYPfiqqqldCreYshOMY PtUh+fuLFd9vKYX7ErVVVURsmZZSzEljyT780pfolUd8CqqqBMshlLAgDn4oloSJCmfpqqqgNfhD GAUB+9Rsa7mCE5A4qqqgJuMaYX6ee4ocYLXYyaqqrDR5IuJwB700vV3yJzgH2qqqtsmYmkd5Ig+0 ds4ojoQ8eTnAxVVVYDkWa+mJAxBNNXHpOOcn71VVW2hrc+q5kPBXtirXDb3BPvVVVBdYsHGTSGj9 KUkHJqqqgu8zoAM5z3ohO6Nk7Y96qqoCIv8ALU0Wb+XtAPtVVVAO+Ait1ZQAWGTik20hmjVf0j7V VVQO4I/rwzFhjsaVMixAogwO5qqqgZCYtPswAuKkmYLbAkZK9qqqoHkHUkuoWQt5YlO07Q+ecUxt 3KXLgcVVVWYFTKI9zYzn5pt+YLHAUCqqqgo7ZJQhUYPeqLRgMqxKqiqqq2G0jKWxtA/anKSbYl4y RxmqqqEWEu07cf3pKt+okZxVVVAoYxkjOfarSSgZUIMAVVVQXic7Mnk/9qX/AEE1VVQKMfwSKtHy dvtVVVArby3/AE9qUrEfVk5qqqgWZiyAdhmll2BP1H4qqqs0WDMw/URRrZAfpJyDVVVRs9EaqwwM YFNpfqdlHH3qqqgRkorMCfpHb5ptqKq4tZFUIWXJA96qqoATyEQswGCOKFFKbiJ1cZP+r3qqqgE4 9BNo5ANNZMNOuRnaeKqqowJp0SydSQbhkMu3HxyK9bPK/aJB4c2IHO2NTk/tVVVfJ5f5R9Dj/izr qbC384UYA9qwvUzu3ce1VVV9Ph/i8PL7TnQUIE4I/qUk1nukRrNqTsRgiPiqqqT+SY/xYT4kyt+Y kGcAVzt4g/olPPY1VVX3eH+D4n5H8nLXiHOySy4Pc1p/U5i0u4859qqqrz8zfB7DUbVH7UpCZgg/ Tj4qqqvE943q7SwxnBxk05tZDg47D2qqqgVOxbbk0FFywUEiqqqmxPdLD83rEQkO4RgYFb8tU26M N318YGfaqqq9nC4Z+mG6sxDEqdpHvTWMbOO4xnmqqq6cjWPp/9k= --b1_6RPlTHB8Ufj4gEChmXk7FTkC3cSCWeVeYULNoiyOuU-- From xen-devel-bounces@lists.xenproject.org Sat Sep 03 18:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 18:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398215.639003 (Exim 4.92) (envelope-from ) id 1oUY79-0008Ng-GD; Sat, 03 Sep 2022 18:43:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398215.639003; Sat, 03 Sep 2022 18:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUY79-0008NZ-DQ; Sat, 03 Sep 2022 18:43:31 +0000 Received: by outflank-mailman (input) for mailman id 398215; Sat, 03 Sep 2022 18:43:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUY78-0008NP-DD; Sat, 03 Sep 2022 18:43:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUY78-0004kR-Az; Sat, 03 Sep 2022 18:43:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUY77-0003Gp-L9; Sat, 03 Sep 2022 18:43:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUY77-0004R9-Kg; Sat, 03 Sep 2022 18:43:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aLqbVy14K0A9aNjsXUtNXrhF+lXEG/m9LDw8JVcl08w=; b=galWY49ponmBpBIZTxs6ybUrqF DpT6w/S4XGox/oUFf2CaO4BBtlYYuMqbqP280apcv218FV/RVDYnStUMtyUM1rv4kj8UN6ZQcDp7U raEZZJs3oV28EYW6L29s2f+nrrRXPZtEz5ZXykI/C6rSw1uxHJk2cCM/k8tgGMOjivvk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172956: regressions - FAIL X-Osstest-Failures: linux-linus:build-amd64:xen-build:fail:regression linux-linus:build-amd64-xsm:xen-build:fail:regression linux-linus:build-arm64-xsm:xen-build:fail:regression linux-linus:build-i386:xen-build:fail:regression linux-linus:build-i386-xsm:xen-build:fail:regression linux-linus:build-arm64:xen-build:fail:regression linux-linus:build-armhf:xen-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking linux-linus:build-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:build-i386-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-examine-bios:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-examine-uefi:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-freebsd11-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-freebsd12-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking X-Osstest-Versions-This: linux=d895ec7938c431fe61a731939da76a6461bc6133 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 03 Sep 2022 18:43:29 +0000 flight 172956 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172956/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 172133 build-amd64-xsm 6 xen-build fail REGR. vs. 172133 build-arm64-xsm 6 xen-build fail REGR. vs. 172133 build-i386 6 xen-build fail REGR. vs. 172133 build-i386-xsm 6 xen-build fail REGR. vs. 172133 build-arm64 6 xen-build fail REGR. vs. 172133 build-armhf 6 xen-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-examine 1 build-check(1) blocked n/a test-amd64-amd64-examine-bios 1 build-check(1) blocked n/a test-amd64-amd64-examine-uefi 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a version targeted for testing: linux d895ec7938c431fe61a731939da76a6461bc6133 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 30 days Failing since 172152 2022-08-05 04:01:26 Z 29 days 68 attempts Testing same since 172947 2022-09-03 01:11:57 Z 0 days 2 attempts ------------------------------------------------------------ 1673 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-debianhvm-i386-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemut-debianhvm-amd64 blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-freebsd11-amd64 blocked test-amd64-amd64-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemut-win7-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemut-ws16-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-amd64-examine blocked test-arm64-arm64-examine blocked test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi blocked test-amd64-amd64-xl-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171730 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 03 20:29:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 20:29:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398224.639013 (Exim 4.92) (envelope-from ) id 1oUZlT-0001Ha-4E; Sat, 03 Sep 2022 20:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398224.639013; Sat, 03 Sep 2022 20:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUZlT-0001HT-1c; Sat, 03 Sep 2022 20:29:15 +0000 Received: by outflank-mailman (input) for mailman id 398224; Sat, 03 Sep 2022 20:29:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUZlR-0001HN-Oa for xen-devel@lists.xenproject.org; Sat, 03 Sep 2022 20:29:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11a457aa-2bc7-11ed-934f-f50d60e1c1bd; Sat, 03 Sep 2022 22:29:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BAD5B60DE6; Sat, 3 Sep 2022 20:29:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 2DEF9C433D7; Sat, 3 Sep 2022 20:29:10 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 1441DC4166E; Sat, 3 Sep 2022 20:29:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11a457aa-2bc7-11ed-934f-f50d60e1c1bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662236950; bh=Mf+tK2Y3ypAtX/kvPF7uzRvJIYaqF6rhBP6iGfMIOfY=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=F3tJ4TprMNuh4pGYCdaXhzguaGi2fsdfeCI0Yiar0ifXpbQ1K3usxFAIVP01qVgiB I/C4UwpOuWRlWkevVLTtTVcShJiXi/cEMJmcey4aHOjs/rai0Jr9cIVnXOs3EIXSE7 5O0ykDE+rTZvzVbj1+B+olnHdBob2XYC4V4cLV+shOWhEze+MCxk2irWISK0/Cpm9S nfBNjcUkNcQTR7XWQ/JDK9txvtIunTzz0jk6actxKeMCyRS4q56zKXiZjtgkArbhqY inkOG24UYo/G3YUv1yIgSgbsXHq8f0FTyCCck6wWLxPTutKBSJBAbYET42Syndwc2x EOKFexc/5igVQ== Subject: Re: [GIT PULL] xen: branch for v6.0-rc4 From: pr-tracker-bot@kernel.org In-Reply-To: <20220903145428.29553-1-jgross@suse.com> References: <20220903145428.29553-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20220903145428.29553-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc4-tag X-PR-Tracked-Commit-Id: e9ea0b30ada008f4e65933f449db6894832cb242 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 65eea2c060aee3bf6d27ea365360059fbd4eeff4 Message-Id: <166223695007.8828.12790840864237325625.pr-tracker-bot@kernel.org> Date: Sat, 03 Sep 2022 20:29:10 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Sat, 3 Sep 2022 16:54:28 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/65eea2c060aee3bf6d27ea365360059fbd4eeff4 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Sat Sep 03 23:15:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 03 Sep 2022 23:15:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398231.639025 (Exim 4.92) (envelope-from ) id 1oUcLi-0000Ee-Tt; Sat, 03 Sep 2022 23:14:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398231.639025; Sat, 03 Sep 2022 23:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUcLi-0000EX-RG; Sat, 03 Sep 2022 23:14:50 +0000 Received: by outflank-mailman (input) for mailman id 398231; Sat, 03 Sep 2022 23:14:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUcLh-0000EN-AW; Sat, 03 Sep 2022 23:14:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUcLh-0001WC-81; Sat, 03 Sep 2022 23:14:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUcLg-00050X-SW; Sat, 03 Sep 2022 23:14:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUcLg-0000RH-Qx; Sat, 03 Sep 2022 23:14:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WW41vuX53QJGGIg7i1MEp1/cJXTvBqyc5Mh2wKUugg8=; b=llNyRC8qzIh9/1FgsnqluIwf7M tZ5kdlCHcQOSb6kyuX4yH14cF1keZFc6ntIZNFGRtiX/Roo7blecdvs0dLqqqiKMOM/XOxNLTY213 14AeylddX+hJje9BizbcgwasytLXXz5U3d2+cytfyyZSvIxP8AOrqYm+R5wQDCnp/W8s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172967: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 03 Sep 2022 23:14:48 +0000 flight 172967 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172967/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 236 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 00:42:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 00:42:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398242.639036 (Exim 4.92) (envelope-from ) id 1oUdi9-00014C-LO; Sun, 04 Sep 2022 00:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398242.639036; Sun, 04 Sep 2022 00:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUdi9-000145-Hl; Sun, 04 Sep 2022 00:42:05 +0000 Received: by outflank-mailman (input) for mailman id 398242; Sun, 04 Sep 2022 00:42:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUdi8-00013v-Ud; Sun, 04 Sep 2022 00:42:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUdi8-0003eQ-Q6; Sun, 04 Sep 2022 00:42:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUdi8-0001Oi-CW; Sun, 04 Sep 2022 00:42:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUdi8-0002a5-C3; Sun, 04 Sep 2022 00:42:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vIEdg61qhJYA1hhTuQvyFLqCGZq/okKcK7SHiyhDpOo=; b=UdDHXRiVLeokY3Ylxbj+0hHXdZ z5GU0FpX1yHBsHjUo7kFnqkWkND/114x10dpIGBDhWVbIhAXVNLngSIIC/6oS3/TFl45bQGILUJ5n q4VTT9G0xJvh0w85YfhukP1O20EIDH2sUAR4tFQE/mzaVg3aWnFNaJ/qjPfBdgDzvax4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172965: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-vhd::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf:xen-build:fail:regression linux-5.4:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sun, 04 Sep 2022 00:42:04 +0000 flight 172965 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172965/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd broken build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf 6 xen-build fail in 172953 REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken pass in 172943 test-arm64-arm64-xl-vhd 13 guest-start fail in 172943 pass in 172965 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 172953 pass in 172965 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 172943 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 172953 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 172953 n/a build-armhf-libvirt 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-examine 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 172953 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 172953 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit1 14 guest-start fail in 172943 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 172943 like 172128 test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 172943 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 172943 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 172943 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 172943 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 30 days Failing since 172384 2022-08-11 11:13:58 Z 23 days 50 attempts Testing same since 172776 2022-08-25 17:42:45 Z 9 days 21 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd broken test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-vhd broken broken-step test-armhf-armhf-xl-vhd host-install(5) Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 02:00:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 02:00:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398252.639050 (Exim 4.92) (envelope-from ) id 1oUevl-0007Qs-EW; Sun, 04 Sep 2022 02:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398252.639050; Sun, 04 Sep 2022 02:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUevl-0007Qk-8E; Sun, 04 Sep 2022 02:00:13 +0000 Received: by outflank-mailman (input) for mailman id 398252; Sun, 04 Sep 2022 02:00:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUevk-0007Qa-J5; Sun, 04 Sep 2022 02:00:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUevk-0003nI-Gv; Sun, 04 Sep 2022 02:00:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUevj-0004Nz-Hq; Sun, 04 Sep 2022 02:00:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUevj-0000vO-HO; Sun, 04 Sep 2022 02:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z876Lc/CrVQFMGg1WDsnT5ij8nE0d/mUjFWOoaJqoQE=; b=HsTBb8sr0YvLyeMOE0mjsFVufF oCG1QJLupddR/FEXShiPnA6c7T7wdHEPwnFKz18BQpqllGa64boBSsWLm0Ha2y9LqQ52YlkWx6UMp pOaNPAZYZ/qqtsD6f/fQPoglpaFD1iaKFjNU4OcAolsR7bINcsTFGkOXUezEj65ytFqo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172969: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 02:00:11 +0000 flight 172969 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172969/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 30 days Failing since 172151 2022-08-05 02:40:28 Z 29 days 237 attempts Testing same since 172926 2022-09-02 02:30:44 Z 1 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 03:19:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 03:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398261.639061 (Exim 4.92) (envelope-from ) id 1oUgAO-0005yn-0h; Sun, 04 Sep 2022 03:19:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398261.639061; Sun, 04 Sep 2022 03:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUgAN-0005yg-TO; Sun, 04 Sep 2022 03:19:23 +0000 Received: by outflank-mailman (input) for mailman id 398261; Sun, 04 Sep 2022 03:19:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUgAM-0005yW-U3; Sun, 04 Sep 2022 03:19:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUgAM-00057q-PX; Sun, 04 Sep 2022 03:19:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUgAL-0007tz-IE; Sun, 04 Sep 2022 03:19:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUgAL-0003q5-Hn; Sun, 04 Sep 2022 03:19:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZcgQ877fAfEy5RCJpB+ROERnXRRWu9SF3sNyZ88ohoM=; b=YxAVldU7CjHr0/phvzlMQpMVx1 qMlbjBHAWGjKMmoPl1ZnNiJQwcHaFdVucBIg2J3D1EFey2HWxqpASRUJAj1/5wXoKrnykcJBmgqkd a2uEyHddi+JFM3TELNe2HC6E65eRwTIHhUT7lkQmrc8H9B63GxO1wb3cWJE8hMEiJAt0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172966: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sun, 04 Sep 2022 03:19:21 +0000 flight 172966 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172966/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-xsm 6 xen-build fail in 172955 REGR. vs. 172123 build-arm64 6 xen-build fail in 172955 REGR. vs. 172123 build-armhf 6 xen-build fail in 172955 REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail in 172955 pass in 172966 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 172955 pass in 172966 test-amd64-i386-pair 10 xen-install/src_host fail pass in 172955 test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail pass in 172955 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 172955 n/a build-armhf-libvirt 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 172955 n/a build-arm64-libvirt 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 172955 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 172955 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 31 days Failing since 172148 2022-08-04 21:39:38 Z 30 days 69 attempts Testing same since 172945 2022-09-02 23:10:19 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 05:27:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 05:27:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398275.639081 (Exim 4.92) (envelope-from ) id 1oUiA9-0001xW-6b; Sun, 04 Sep 2022 05:27:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398275.639081; Sun, 04 Sep 2022 05:27:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUiA9-0001xP-3L; Sun, 04 Sep 2022 05:27:17 +0000 Received: by outflank-mailman (input) for mailman id 398275; Sun, 04 Sep 2022 05:27:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUiA7-0001wz-W7; Sun, 04 Sep 2022 05:27:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUiA7-000845-TX; Sun, 04 Sep 2022 05:27:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUiA7-0007gn-2C; Sun, 04 Sep 2022 05:27:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUiA7-0003tK-0A; Sun, 04 Sep 2022 05:27:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1GrWHAPWZspj2tNjZS+w3s7Yoaowky1go/kRjZSkBAo=; b=6csNfWybWdaMWUm6UVM22XHyD8 ft0wQ6QMZ7gb9MCHgSRpn6X4L5OO6Hx30GKs/ghUY+dD+G8QI/gc7CPqCb3BvG5w2aXoIXf3bqNaY HoNgsYjXLdMmE3N27APpDyysgvBBXupO6VlfzATRc8KXpZB9aJfEhLBda2CjjPLsOQCw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172968: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=42cf58c272ee1dae902e8cc1166c246589abd1d8 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sun, 04 Sep 2022 05:27:15 +0000 flight 172968 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172968/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 42cf58c272ee1dae902e8cc1166c246589abd1d8 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 31 days Failing since 172152 2022-08-05 04:01:26 Z 30 days 69 attempts Testing same since 172968 2022-09-03 19:10:14 Z 0 days 1 attempts ------------------------------------------------------------ 1680 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 172477 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 07:47:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 07:47:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398284.639092 (Exim 4.92) (envelope-from ) id 1oUkM0-0007Ey-3f; Sun, 04 Sep 2022 07:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398284.639092; Sun, 04 Sep 2022 07:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUkLz-0007Er-Vc; Sun, 04 Sep 2022 07:47:39 +0000 Received: by outflank-mailman (input) for mailman id 398284; Sun, 04 Sep 2022 07:47:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUkLz-0007Ef-8H; Sun, 04 Sep 2022 07:47:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUkLz-00027u-60; Sun, 04 Sep 2022 07:47:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUkLy-00019O-Qd; Sun, 04 Sep 2022 07:47:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUkLy-0005bD-Oa; Sun, 04 Sep 2022 07:47:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4Jc+USMt2+RJstl0abKZRseaBtsQSLWO0oFXYI16gQ0=; b=mB/VXNfGIQzvzBM+YhwPWBwEsR gk8nbIJIaUaZYBHVhWNtw7mzd6UromPkIgceEyWFdJz0KVQxHJVMKxBnQDTXif6Muyu444eQvbPyH mOaYYyLSiroRB0iA8lyEWcb73EHNNYa1eA/CZDLWW9OaVDYWfy38bUfeXM3hz2wuMYdE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172973: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 07:47:38 +0000 flight 172973 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172973/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 30 days 238 attempts Testing same since 172926 2022-09-02 02:30:44 Z 2 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 10:41:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 10:41:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398298.639103 (Exim 4.92) (envelope-from ) id 1oUn3v-0007ln-L2; Sun, 04 Sep 2022 10:41:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398298.639103; Sun, 04 Sep 2022 10:41:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUn3v-0007lg-II; Sun, 04 Sep 2022 10:41:11 +0000 Received: by outflank-mailman (input) for mailman id 398298; Sun, 04 Sep 2022 10:41:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUn3t-0007lW-U8; Sun, 04 Sep 2022 10:41:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUn3t-0005m3-Ou; Sun, 04 Sep 2022 10:41:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUn3t-0006cp-Au; Sun, 04 Sep 2022 10:41:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUn3t-00087G-A6; Sun, 04 Sep 2022 10:41:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WR77PGUHMRd1WxTvk284EAh0X2Jskv9BRAwId9y/g7E=; b=o0cXcarbEwVFkUMiodk9+KqiBo xRcgJfzRtyyDoEUF4zz/liBKQUmG2N1a2XUrhu3vrY05bqRFPxiHaokd4NiDb//PR9CYufkmArP0V t7Il496YA5kpesrrdvJ8+RS6Dv5CuGuNzXl0XxV+ENN5RItr3GiF9iDRJF6HDhRPWhKg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172970: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sun, 04 Sep 2022 10:41:09 +0000 flight 172970 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172970/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 31 days Failing since 172384 2022-08-11 11:13:58 Z 23 days 51 attempts Testing same since 172776 2022-08-25 17:42:45 Z 9 days 22 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 11:54:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 11:54:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398309.639114 (Exim 4.92) (envelope-from ) id 1oUoCZ-0006LW-40; Sun, 04 Sep 2022 11:54:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398309.639114; Sun, 04 Sep 2022 11:54:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUoCZ-0006LP-0n; Sun, 04 Sep 2022 11:54:11 +0000 Received: by outflank-mailman (input) for mailman id 398309; Sun, 04 Sep 2022 11:54:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUoCY-0006LF-CL; Sun, 04 Sep 2022 11:54:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUoCY-0006zo-92; Sun, 04 Sep 2022 11:54:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUoCX-0003g5-Q8; Sun, 04 Sep 2022 11:54:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUoCX-0008PH-Pc; Sun, 04 Sep 2022 11:54:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5Rh+vQpRrOF/6fImvgOSKgVwWY7MduamJi9ooi/7s4k=; b=dTHIWabezVEPYcUBmVQ0/6o6RO PNrBGYIL5rhwEVGdBVpNVxqUryY03yCpJ8WrtdUeFW24KcNFuZnMoCUhsjaHXxPWmq150ZJLXfz+N Xc0pf4jXJ9OqHE5dtka5U6ejS9846I1lt82CK7ONA9Sf4cAIsx1nS59GQdcEwqeR4SlM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172980: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 11:54:09 +0000 flight 172980 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172980/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 30 days 239 attempts Testing same since 172926 2022-09-02 02:30:44 Z 2 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 12:20:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 12:20:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398320.639125 (Exim 4.92) (envelope-from ) id 1oUobe-0001Cw-9i; Sun, 04 Sep 2022 12:20:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398320.639125; Sun, 04 Sep 2022 12:20:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUobe-0001Cp-6K; Sun, 04 Sep 2022 12:20:06 +0000 Received: by outflank-mailman (input) for mailman id 398320; Sun, 04 Sep 2022 12:20:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUobc-00015X-Qc; Sun, 04 Sep 2022 12:20:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUobc-0007VQ-LX; Sun, 04 Sep 2022 12:20:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUobc-00059O-9V; Sun, 04 Sep 2022 12:20:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUobc-0006K5-8t; Sun, 04 Sep 2022 12:20:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E1hTQC/nYX6NcFnFJAddQofKtBWmzYVeLQrPUfo6jlM=; b=5rSSIkODdpuIxDDsJ1MDWdDRzp POAfmacqByvFJNcInQMJC7rXmice754x1oGbGYT30xhdiwL4V3HTNkgGnwlbkAM53TmjE0QfLTC2Z k498vtM3b4pHgB1T6TukDM/EDXhf4Aiq7G69RKyMnsvNhHkH9AxDGaP7+QSZKBc3S614=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 172972: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:guest-localmigrate:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e997d055929665b12246e89eb092dc79c65de9a4 X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Sun, 04 Sep 2022 12:20:04 +0000 flight 172972 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172972/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 17 guest-localmigrate fail pass in 172948 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172948 build-i386-libvirt 6 libvirt-build fail like 172948 build-arm64-libvirt 6 libvirt-build fail like 172948 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172948 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172948 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172948 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172948 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172948 build-armhf-libvirt 6 libvirt-build fail like 172948 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172948 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172948 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172948 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172948 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e997d055929665b12246e89eb092dc79c65de9a4 baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172972 2022-09-04 01:52:27 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Sep 04 12:57:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 12:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398330.639139 (Exim 4.92) (envelope-from ) id 1oUpBn-0004Xo-5J; Sun, 04 Sep 2022 12:57:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398330.639139; Sun, 04 Sep 2022 12:57:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUpBn-0004Xh-2f; Sun, 04 Sep 2022 12:57:27 +0000 Received: by outflank-mailman (input) for mailman id 398330; Sun, 04 Sep 2022 12:57:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUpBl-0004XW-WE; Sun, 04 Sep 2022 12:57:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUpBl-00088l-Pw; Sun, 04 Sep 2022 12:57:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUpBl-00080d-A4; Sun, 04 Sep 2022 12:57:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUpBl-0005N0-9b; Sun, 04 Sep 2022 12:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YLjR+d5t+BVzmqYGj7ydlJSVjTngEI3uYCytO84+OM4=; b=HoqIxWc0gAta0sqkV2Noo3g0mb buzTUvjwnrGBMX0ny2Opp/QzoZdK5Zbow7eyz71tXNsIIKKlbz+gNZzxjlnxK6fb1CZN1t5rhAJWv jYPjjUc9E0w7ACYpmoIdeax6Z7yEZbrCSDyDtOHqubIa4W7wcW6rgC8/OTKiGtY3z0Gk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 172978: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c8b796aba31b2c97a1a56867062b3bdd0d81923f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 04 Sep 2022 12:57:25 +0000 flight 172978 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172978/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c8b796aba31b2c97a1a56867062b3bdd0d81923f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 786 days Failing since 151818 2020-07-11 04:18:52 Z 785 days 767 attempts Testing same since 172930 2022-09-02 04:20:43 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121804 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 14:00:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 14:00:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398341.639149 (Exim 4.92) (envelope-from ) id 1oUqAz-00033b-Sg; Sun, 04 Sep 2022 14:00:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398341.639149; Sun, 04 Sep 2022 14:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqAz-00033U-P4; Sun, 04 Sep 2022 14:00:41 +0000 Received: by outflank-mailman (input) for mailman id 398341; Sun, 04 Sep 2022 14:00:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqAy-00033K-Jt; Sun, 04 Sep 2022 14:00:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqAy-0000uc-GB; Sun, 04 Sep 2022 14:00:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqAy-0003J9-1f; Sun, 04 Sep 2022 14:00:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUqAy-0005dA-0w; Sun, 04 Sep 2022 14:00:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RsiROyGml0B8kkm8B5HaMt0KV0swrtYKGzcQhC/hccA=; b=ZXzkkyjXKH/jK9GDTXQqwfgV8b sfahuvP/Tg7rr9zbyEESP0AVCaHoQc4h5q00geer84WPmPxOjHqyQPKCbjZ4GiQRv3tX1pPGcfsRz yUgJoYif2asrXRSt9tLNtKvWlbNbALVepaqNo7Nrphxn8BCbO/JMWVvj/x/SEkpV5xho=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172974: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sun, 04 Sep 2022 14:00:40 +0000 flight 172974 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172974/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 31 days Failing since 172148 2022-08-04 21:39:38 Z 30 days 70 attempts Testing same since 172945 2022-09-02 23:10:19 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 14:25:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 14:25:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398350.639161 (Exim 4.92) (envelope-from ) id 1oUqYn-0005UP-TX; Sun, 04 Sep 2022 14:25:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398350.639161; Sun, 04 Sep 2022 14:25:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqYn-0005UI-QP; Sun, 04 Sep 2022 14:25:17 +0000 Received: by outflank-mailman (input) for mailman id 398350; Sun, 04 Sep 2022 14:25:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqYm-0005U8-7A; Sun, 04 Sep 2022 14:25:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqYm-0001Ia-68; Sun, 04 Sep 2022 14:25:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUqYl-00054X-ME; Sun, 04 Sep 2022 14:25:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUqYl-0005Cf-Ll; Sun, 04 Sep 2022 14:25:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mu84s+pe/99LbPIH1XPzSPBtvhqAbZHFiX6IjEaMQog=; b=rpr9MWmJuKpwqHze6J5ZmWpu+O tYtLThtSSu2Sboqjhztsy9fPQFbmyomTFUjhNNhxtGlmPfFwdxQLJqL4xVXdU4SZBSYL8zL3VEz9n PETwWkrOUeU3Cn/GLLoYk/NTaI8YZtfEKI4udOIodsasF9aWch9CD1sBMW2bhSq7ldn4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172982: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 14:25:15 +0000 flight 172982 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172982/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 30 days 240 attempts Testing same since 172926 2022-09-02 02:30:44 Z 2 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 17:26:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 17:26:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398359.639171 (Exim 4.92) (envelope-from ) id 1oUtNx-0005vA-Cg; Sun, 04 Sep 2022 17:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398359.639171; Sun, 04 Sep 2022 17:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUtNx-0005v3-9u; Sun, 04 Sep 2022 17:26:17 +0000 Received: by outflank-mailman (input) for mailman id 398359; Sun, 04 Sep 2022 17:26:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUtNv-0005ut-FY; Sun, 04 Sep 2022 17:26:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUtNv-0004yQ-3q; Sun, 04 Sep 2022 17:26:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUtNu-0003NG-I2; Sun, 04 Sep 2022 17:26:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUtNu-0007pA-HT; Sun, 04 Sep 2022 17:26:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BkcewOjdE8V+D/y6FhFEvAP2gz40bgedrJz/9ADpfJU=; b=1BJlkmETITDTX3xvyAauTKKq4s 2GpINl4X0eFaKwjWNuOM5DRL42QyInbhPMlvYl1slp5T2TTsz667N9k4zWddAbVUVRjc9NlKFc6x0 Cxow8LWjCVv/R4aVlAD/ANEI1+1FKedAhkqbdgl8jFQvzRKu69V69zLPjhQQUuxxEBpU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172979: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7726d4c3e60bfe206738894267414a5f10510f1a X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sun, 04 Sep 2022 17:26:14 +0000 flight 172979 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172979/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7726d4c3e60bfe206738894267414a5f10510f1a baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 31 days Failing since 172152 2022-08-05 04:01:26 Z 30 days 70 attempts Testing same since 172979 2022-09-04 05:32:32 Z 0 days 1 attempts ------------------------------------------------------------ 1690 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 173177 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 18:09:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 18:09:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398370.639183 (Exim 4.92) (envelope-from ) id 1oUu46-0001rn-RH; Sun, 04 Sep 2022 18:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398370.639183; Sun, 04 Sep 2022 18:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUu46-0001rg-N6; Sun, 04 Sep 2022 18:09:50 +0000 Received: by outflank-mailman (input) for mailman id 398370; Sun, 04 Sep 2022 18:09:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUu45-0001rW-KQ; Sun, 04 Sep 2022 18:09:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUu45-0005pX-Hk; Sun, 04 Sep 2022 18:09:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUu40-0005cM-4j; Sun, 04 Sep 2022 18:09:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUu40-00030J-4E; Sun, 04 Sep 2022 18:09:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R/WII0MmZjVSxkpMfzvwb5ygGyLTVSgyTVsNnfyzH+I=; b=5SZAv46zVlpj9ko9bE7FOV7gvs 5PVx8Gf/n5w/AC+EjE0nMowv5zv/PuJD9cYbjEdib1baz5DWp/sVQWMFCqQ5OFAztcEdyUFfGiYai d1LGw70BctScsW5v+h6uw+26VhLFJkqjVSnZsLwKTUPWNFw8WSE/3c/A9ub121LfQkog=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172985: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 18:09:44 +0000 flight 172985 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172985/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 30 days 241 attempts Testing same since 172926 2022-09-02 02:30:44 Z 2 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 18:52:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 18:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398379.639194 (Exim 4.92) (envelope-from ) id 1oUujX-0006rS-4r; Sun, 04 Sep 2022 18:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398379.639194; Sun, 04 Sep 2022 18:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUujX-0006rL-02; Sun, 04 Sep 2022 18:52:39 +0000 Received: by outflank-mailman (input) for mailman id 398379; Sun, 04 Sep 2022 18:52:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUujV-0006rB-PG; Sun, 04 Sep 2022 18:52:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUujV-0006Xg-MU; Sun, 04 Sep 2022 18:52:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUujV-00080r-5f; Sun, 04 Sep 2022 18:52:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUujV-0000pT-51; Sun, 04 Sep 2022 18:52:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CvZLSztV+eYwJUoemq/EDIkTubgerWxDrj1pbw/qqLs=; b=yQn7JH5/CwTLSOk50XXA5iNChY 185LEwbU9r3Ggl0daoDGKIQwCv4Paow7SAwyYsiqwQQgm9hoY1CUJE6Vno/ovu0yO4B/dydQEivi0 AYN/ivDvGX3Vq8i1hH1kRbLHQHRhm+ocJ5JMe2nqImcPMag8/8Ww7RmdyKm6rXLi3qaE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172981: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sun, 04 Sep 2022 18:52:37 +0000 flight 172981 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172981/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 31 days Failing since 172384 2022-08-11 11:13:58 Z 24 days 52 attempts Testing same since 172776 2022-08-25 17:42:45 Z 10 days 23 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 20:31:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 20:31:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398388.639205 (Exim 4.92) (envelope-from ) id 1oUwHA-00085F-5i; Sun, 04 Sep 2022 20:31:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398388.639205; Sun, 04 Sep 2022 20:31:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUwHA-000858-1R; Sun, 04 Sep 2022 20:31:28 +0000 Received: by outflank-mailman (input) for mailman id 398388; Sun, 04 Sep 2022 20:31:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUwH9-00084y-29; Sun, 04 Sep 2022 20:31:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUwH8-0008OK-Vz; Sun, 04 Sep 2022 20:31:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUwH8-0006yc-DP; Sun, 04 Sep 2022 20:31:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUwH8-0008Qz-Ct; Sun, 04 Sep 2022 20:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TV5sEKgSy4s3ceyKgD0QMinXEnGt8Wp0sK/vJiKAZBc=; b=GTxMr+XbN+bK3LcyUI9O+BovuT QjA1E5Cr51CIIrtYSsqtDgB0cW2WA6NGU9zXsNkvbqSs8gLZO2ugEADinpix7MKFguCao2qr2VSXw PCLHhqhpVMkOGk/1AdFssX9uG2EybgV7yZX6o7ajy1MlIfrRoly4bum455CJVHgc9AEE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172987: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 20:31:26 +0000 flight 172987 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172987/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 30 days 242 attempts Testing same since 172926 2022-09-02 02:30:44 Z 2 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 22:54:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 22:54:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398400.639220 (Exim 4.92) (envelope-from ) id 1oUyVe-0004r1-L4; Sun, 04 Sep 2022 22:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398400.639220; Sun, 04 Sep 2022 22:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUyVe-0004qu-GS; Sun, 04 Sep 2022 22:54:34 +0000 Received: by outflank-mailman (input) for mailman id 398400; Sun, 04 Sep 2022 22:54:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUyVc-0004qk-LH; Sun, 04 Sep 2022 22:54:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUyVc-0002NU-GL; Sun, 04 Sep 2022 22:54:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUyVc-0006SS-2z; Sun, 04 Sep 2022 22:54:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUyVc-0001P8-2T; Sun, 04 Sep 2022 22:54:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OItFbQgBvuWJfk6NiQH6Eado3/VNVd1yKMLa2/Uppoc=; b=oou+7Box6Y/gf0CHhg0iBn3cPU MsszM4rdRnuY/J8Mp9wQAPTlqAMru3SIja2IP3xW1ij5zx4/eZBcDuQFVzrfaJEl0zhjDfUUjq49j q0AkqHDI2R9WLNF5HEzW4hW1ncv77MP3JnHyiF5e8JVt3Yp1V7c4G2ph918iHAf0MTxM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172984: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sun, 04 Sep 2022 22:54:32 +0000 flight 172984 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172984/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 32 days Failing since 172148 2022-08-04 21:39:38 Z 31 days 71 attempts Testing same since 172945 2022-09-02 23:10:19 Z 1 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 04 23:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 04 Sep 2022 23:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398409.639230 (Exim 4.92) (envelope-from ) id 1oUzRl-0002ZD-0k; Sun, 04 Sep 2022 23:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398409.639230; Sun, 04 Sep 2022 23:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUzRk-0002Z6-TY; Sun, 04 Sep 2022 23:54:36 +0000 Received: by outflank-mailman (input) for mailman id 398409; Sun, 04 Sep 2022 23:54:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUzRj-0002Ym-6y; Sun, 04 Sep 2022 23:54:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUzRi-0003Qo-VW; Sun, 04 Sep 2022 23:54:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oUzRi-00022b-DY; Sun, 04 Sep 2022 23:54:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oUzRi-00046E-D9; Sun, 04 Sep 2022 23:54:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4YELHvZ13suLAD0MJt1trgpGTO8JxBq4vRnIwmycosg=; b=M8/JvD1uLViB5Tz0Iy+yteYfmP LDqoyiZbR0Gx13UHR4iLYP0jGzuf72sD8YhCkFccSw0NaFlqP8Yc6/e/lNM7Uh8mBXVpeQNBndSLB A+hwQg7oOzyVj/EOaU0Y7kt7zz+9YxyAmTg+IAl6GvEFq7ENLSR6WRpeyNv73IgfzhUM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172989: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 04 Sep 2022 23:54:34 +0000 flight 172989 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172989/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 30 days 243 attempts Testing same since 172926 2022-09-02 02:30:44 Z 2 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 01:33:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 01:33:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398418.639241 (Exim 4.92) (envelope-from ) id 1oV0zD-0002Xz-Ur; Mon, 05 Sep 2022 01:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398418.639241; Mon, 05 Sep 2022 01:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV0zD-0002Xs-RV; Mon, 05 Sep 2022 01:33:15 +0000 Received: by outflank-mailman (input) for mailman id 398418; Mon, 05 Sep 2022 01:33:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV0zB-0002Xm-Hs for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 01:33:13 +0000 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [2607:f8b0:4864:20::d32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b398b92a-2cba-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 03:33:11 +0200 (CEST) Received: by mail-io1-xd32.google.com with SMTP id i77so5875852ioa.7 for ; Sun, 04 Sep 2022 18:33:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b398b92a-2cba-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=2RluQjqzTIUHmUhPkFaAucreOiCVZIKJVjpKNDHkTVI=; b=Q2SFjmrk55zpV9cBG3THFMLDJmuoc/8nrQ9p1qSD4f3cKratTElhXWpwlJpzLyLGdB dUdJn77SvWYU1bP95CNfftS8y/vUZXmtUUk048r8ICfLieWVmDGDmUW5u9pFn0Wimb2+ fjqU5NekUrHLRJIhO6WL/TlQwCGPS6j156hXfsaJx7lHdSgwEnbb8DWRFk8q7xjioT1t iG+0L8yNs39bpjd/CsZ4HREZ9tLgN3o/zOan5zEv/n3CDSIzOP4LnKLk4WpSk4BU0yEP 4AYwp1478Pf1dFxHmYXmnh+61qZlMLJPPjkGYHj5zdiNAcoW1tZU++xE8S7Db8in70AK L7BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2RluQjqzTIUHmUhPkFaAucreOiCVZIKJVjpKNDHkTVI=; b=4dqbQPaFRl47pqjtUFeR4HPnqRQtcLkqwra8ZaxXpEvaNFQ5ioLAVzVYiHLTb9D13D bws+e5DneTabKIAVvY0ylG9UepwGce0Eso9ORFm4upN5RtmTnKTMUQmN7lAy1cz4rbTs HFDQ5yU206tYmZFw+jjaAuQN5XlpEOkU1A1wtsyfnEoPBnTHc63WwWqYKLBx1LSixsjE zdJnleWlMxQMKa7alNe7jZ3zUNsiSzbLcffdmhpPqT0oUnxOLujM5N3xaLbV3GrYQDpW vdmPcfWDFCi8rQ5bxHxVHcQ1q0SV+hBU4c8ePlSIJxr0EFn51q1omeCqniwbusbXaVAj fJbg== X-Gm-Message-State: ACgBeo1P/xhJQ9TfCA/Hy9k3t5tUYRwH30AvnaI3VHYXQdvPTVdo/TlW Xr7FOfRjeWnlW44CzNfasPtgrrAf5YscvDTXCEN8uw== X-Google-Smtp-Source: AA6agR5tFRVsPv1w5HQVwvNXMwt9PQzl6OY2wrpjmNL5au6axj2vXUaHdVOAmgfDNm2JaHEXPkzVG4QoN+UeQErwqKQ= X-Received: by 2002:a02:7b19:0:b0:34a:74d:118 with SMTP id q25-20020a027b19000000b0034a074d0118mr23960434jac.62.1662341590010; Sun, 04 Sep 2022 18:33:10 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 4 Sep 2022 18:32:58 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Michal Hocko Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > > On Thu 01-09-22 08:33:19, Suren Baghdasaryan wrote: > > On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: > [...] > > > So I find Peter's question completely appropriate while your response to > > > that not so much! Maybe ftrace is not the right tool for the intented > > > job. Maybe there are other ways and it would be really great to show > > > that those have been evaluated and they are not suitable for a), b) and > > > c) reasons. > > > > That's fair. > > For memory tracking I looked into using kmemleak and page_owner which > > can't match the required functionality at an overhead acceptable for > > production and pre-production testing environments. > > Being more specific would be really helpful. Especially when your cover > letter suggests that you rely on page_owner/memcg metadata as well to > match allocation and their freeing parts. > > > traces + BPF I > > haven't evaluated myself but heard from other members of my team who > > tried using that in production environment with poor results. I'll try > > to get more specific information on that. > > That would be helpful as well. > > > > E.g. Oscar has been working on extending page_ext to track number of > > > allocations for specific calltrace[1]. Is this 1:1 replacement? No! But > > > it can help in environments where page_ext can be enabled and it is > > > completely non-intrusive to the MM code. > > > > Thanks for pointing out this work. I'll need to review and maybe > > profile it before making any claims. > > > > > > > > If the page_ext overhead is not desirable/acceptable then I am sure > > > there are other options. E.g. kprobes/LivePatching framework can hook > > > into functions and alter their behavior. So why not use that for data > > > collection? Has this been evaluated at all? > > > > I'm not sure how I can hook into say alloc_pages() to find out where > > it was called from without capturing the call stack (which would > > introduce an overhead at every allocation). Would love to discuss this > > or other alternatives if they can be done with low enough overhead. > > Yes, tracking back the call trace would be really needed. The question > is whether this is really prohibitively expensive. How much overhead are > we talking about? There is no free lunch here, really. You either have > the overhead during runtime when the feature is used or on the source > code level for all the future development (with a maze of macros and > wrappers). As promised, I profiled a simple code that repeatedly makes 10 allocations/frees in a loop and measured overheads of code tagging, call stack capturing and tracing+BPF for page and slab allocations. Summary: Page allocations (overheads are compared to get_free_pages() duration): 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) 8.8% lookup_page_ext 1237% call stack capture 139% tracepoint with attached empty BPF program Slab allocations (overheads are compared to __kmalloc() duration): With CONFIG_MEMCG_KMEM=y 39% Codetag counter manipulations(__lazy_percpu_counter_add + __alloc_tag_add) 55% get_slab_tag_ref 3.9% __ksize 3027% call stack capture 397% tracepoint with attached empty BPF program With CONFIG_MEMCG_KMEM=n 26% Codetag counter manipulation(__lazy_percpu_counter_add + __alloc_tag_add) 72% get_slab_tag_ref 7.4% __ksize 2789% call stack capture 345% tracepoint with attached empty BPF program Details: _get_free_pages is used as page allocation duration baseline __kmalloc is used as slab allocation duration baseline 1. Profile with instrumented page allocator |--50.13%--my__get_free_page | | | |--38.99%--_get_free_pages | | | | | |--34.75%--__alloc_pages | | | | | | | |--27.59%--get_page_from_freelist | | | | | --3.98%--_alloc_pages | | | | | --0.53%--policy_node | | | |--3.45%--lookup_page_ext | | | |--1.59%--__lazy_percpu_counter_add | | | | | --0.80%--pcpu_alloc | | memset_orig | | | --1.06%--__alloc_tag_add | | | --0.80%--__lazy_percpu_counter_add | |--35.28%--free_unref_page | | | |--23.08%--_raw_spin_unlock_irqrestore | | | |--2.39%--preempt_count_add | | | | | --0.80%--in_lock_functions | | | |--1.59%--free_pcp_prepare | | | |--1.33%--preempt_count_sub | | | --0.80%--check_preemption_disabled | |--4.24%--__free_pages | --1.59%--free_pages 2. Profile with non-instrumented page allocator and call stack capturing |--84.18%--my__get_free_page | | | --83.91%--stack_depot_capture_stack | | | |--77.99%--stack_trace_save | | | | | --77.53%--arch_stack_walk | | | | | |--37.17%--unwind_next_frame | | | | | | | |--8.44%--__orc_find | | | | | | |--10.57%-stack_trace_consume_entry | | | | | --9.64%--unwind_get_return_address | | | --5.78%--__stack_depot_save | |--6.78%--__get_free_pages | | | |--5.85%--__alloc_pages | | | | | --3.86%--get_page_from_freelist | | | | | --1.33%--_raw_spin_unlock_irqrestore | | | --0.80%--alloc_pages | |--5.19%--free_unref_page | | | |--2.73%--_raw_spin_unlock_irqrestore | | | --0.60%--free_pcp_prepare | --0.73%--__free_pages 3. Profile with non-instrumented page allocator and BPF attached to tracepoint |--42.42%--my__get_free_page | | | --38.53%--perf_trace_kmem_alloc | | | |--25.76%--perf_trace_run_bpf_submit | | | | | |--21.86%--trace_call_bpf | | | | | | | |--4.76%--migrate_enable | | | | | | | |--4.55%--migrate_disable | | | | | | | |--3.03%--check_preemption_disabled | | | | | | | |--0.65%--__this_cpu_preempt_check | | | | | | | --0.65%--__rcu_read_unlock | | | | | --0.87%--check_preemption_disabled | | | |--8.01%--perf_trace_buf_alloc | | | | | |--3.68%--perf_swevent_get_recursion_context | | | | | | | --0.87%--check_preemption_disabled | | | | | --1.30%--check_preemption_disabled | | | --0.87%--check_preemption_disabled | |--27.71%--__get_free_pages | | | |--23.38%--__alloc_pages | | | | | --17.75%--get_page_from_freelist | | | | | |--8.66%--_raw_spin_unlock_irqrestore | | | | | | | --1.95%--preempt_count_sub | | | | | --1.08%--preempt_count_add | | | --4.33%--alloc_pages | | | |--0.87%--policy_node | | | --0.65%--policy_nodemask | |--15.37%--free_unref_page | | | |--6.71%--_raw_spin_unlock_irqrestore | | | |--1.52%--check_preemption_disabled | | | |--0.65%--free_pcp_prepare | | | --0.65%--preempt_count_add |--4.98%--__free_pages 4. Profile with instrumented slab allocator CONFIG_MEMCG_KMEM=y |--51.28%--my__get_free_page | | | |--21.79%--__kmalloc | | | | | |--3.42%--memcg_slab_post_alloc_hook | | | | | |--1.71%--kmalloc_slab | | | | | --0.85%--should_failslab | | | |--11.97%--get_slab_tag_ref | | | |--5.56%--__alloc_tag_add | | | | | --2.56%--__lazy_percpu_counter_add | | | |--2.99%--__lazy_percpu_counter_add | | | --0.85%--__ksize | --35.90%--kfree | |--13.68%--get_slab_tag_ref | |--6.41%--__alloc_tag_sub | | | --4.70%--__lazy_percpu_counter_add | --2.14%--__ksize 5. Profile with non-instrumented slab allocator and call stack capturing CONFIG_MEMCG_KMEM=y |--91.50%--my__get_free_page | | | --91.13%--stack_depot_capture_stack | | | |--85.48%--stack_trace_save | | | | | --85.12%--arch_stack_walk | | | | | |--40.54%--unwind_next_frame | | | | | |--14.30%--__unwind_start | | | | | |--11.95%-unwind_get_return_address | | | | | --10.48%-stack_trace_consume_entry | | | --4.99%--__stack_depot_save | | | --0.66%--filter_irq_stacks | |--3.01%--__kmalloc | |--2.05%--kfree 6. Profile with non-instrumented slab allocator and BPF attached to a tracepoint CONFIG_MEMCG_KMEM=y |--72.39%--__kmalloc | | | |--57.84%--perf_trace_kmem_alloc | | | | | |--38.06%--perf_trace_run_bpf_submit | | | | | | | --33.96%--trace_call_bpf | | | | | | | |--10.07%--migrate_disable | | | | | | | |--4.85%--migrate_enable | | | | | | | |--4.10%--check_preemption_disabled | | | | | | | |--1.87%--__rcu_read_unlock | | | | | | | --0.75%--__rcu_read_lock | | | | | --9.70%--perf_trace_buf_alloc | | | | | |--2.99%--perf_swevent_get_recursion_context | | | | | |--1.12%--check_preemption_disabled | | | | | --0.75%--debug_smp_processor_id | | | |--2.24%--kmalloc_slab | | | |--1.49%--memcg_slab_post_alloc_hook | | | --1.12%--__cond_resched | |--7.84%--kfree 7. Profile with instrumented slab allocator CONFIG_MEMCG_KMEM=n |--49.39%--my__get_free_page | | | |--22.04%--__kmalloc | | | | | |--3.27%--kmalloc_slab | | | | | --0.82%--asm_sysvec_apic_timer_interrupt | | sysvec_apic_timer_interrupt | | __irq_exit_rcu | | __softirqentry_text_start | | | |--15.92%--get_slab_tag_ref | | | |--3.27%--__alloc_tag_add | | | | | --2.04%--__lazy_percpu_counter_add | | | --2.45%--__lazy_percpu_counter_add | |--35.51%--kfree | | | |--13.88%--get_slab_tag_ref | | | |--11.84%--__alloc_tag_sub | | | | | --5.31%--__lazy_percpu_counter_add | | | --1.63%--__ksize 8. Profile with non-instrumented slab allocator and call stack capturing CONFIG_MEMCG_KMEM=n |--91.70%--my__get_free_page | | | --91.48%--stack_depot_capture_stack | | | |--85.29%--stack_trace_save | | | | | --85.07%--arch_stack_walk | | | | | |--45.23%--unwind_next_frame | | | | | |--12.89%--__unwind_start | | | | | |--10.20%-unwind_get_return_address | | | | | --10.12%-stack_trace_consume_entry | | | --5.75%--__stack_depot_save | | | --0.87%--filter_irq_stacks | |--3.28%--__kmalloc | --1.89%--kfree 9. Profile with non-instrumented slab allocator and BPF attached to a tracepoint CONFIG_MEMCG_KMEM=n |--71.65%--__kmalloc | | | |--55.56%--perf_trace_kmem_alloc | | | | | |--38.31%--perf_trace_run_bpf_submit | | | | | | | |--31.80%--trace_call_bpf | | | | | | | | | |--9.96%--migrate_enable | | | | | | | | | |--4.98%--migrate_disable | | | | | | | | | |--1.92%--check_preemption_disabled | | | | | | | | | |--1.92%--__rcu_read_unlock | | | | | | | | | --1.15%--__rcu_read_lock | | | | | | | --0.77%--check_preemption_disabled | | | | | --11.11%--perf_trace_buf_alloc | | | | | --4.98%--perf_swevent_get_recursion_context | | | | | --1.53%--check_preemption_disabled | | | |--2.68%--kmalloc_slab | | | --1.15%--__cond_resched | --9.58%--kfree > > Thanks! > -- > Michal Hocko > SUSE Labs From xen-devel-bounces@lists.xenproject.org Mon Sep 05 03:12:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 03:12:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398427.639252 (Exim 4.92) (envelope-from ) id 1oV2Wb-0004eR-CL; Mon, 05 Sep 2022 03:11:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398427.639252; Mon, 05 Sep 2022 03:11:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2Wb-0004eK-8i; Mon, 05 Sep 2022 03:11:49 +0000 Received: by outflank-mailman (input) for mailman id 398427; Mon, 05 Sep 2022 03:11:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2Wa-0004eA-Qf; Mon, 05 Sep 2022 03:11:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2Wa-0006sD-KP; Mon, 05 Sep 2022 03:11:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2Wa-0000Nr-4O; Mon, 05 Sep 2022 03:11:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV2Wa-0001p4-25; Mon, 05 Sep 2022 03:11:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WXr55Nqf3DYlGsSUr+zL2i2uGkxh8vBLoVP+30QlR7I=; b=Wktcn+roD6fy30Vsm81vosm2ln DV3puWJu6ijPlKBeGoZdpjEZ/fsX7Qj2JEPEkHSdUY4Fz6+WvNy7+k80uBTYlPBbSOKafUokqUNcz Me8bddLUADHRSoLY9mxbrzgryPYF1v48SVs4z1GfPxLS19GocETz0PDpxGgBV2UCNA0g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172986: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7726d4c3e60bfe206738894267414a5f10510f1a X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Mon, 05 Sep 2022 03:11:48 +0000 flight 172986 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172986/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 172979 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7726d4c3e60bfe206738894267414a5f10510f1a baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 31 days Failing since 172152 2022-08-05 04:01:26 Z 30 days 71 attempts Testing same since 172979 2022-09-04 05:32:32 Z 0 days 2 attempts ------------------------------------------------------------ 1690 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 173177 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 03:31:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 03:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398436.639263 (Exim 4.92) (envelope-from ) id 1oV2pI-00071s-UP; Mon, 05 Sep 2022 03:31:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398436.639263; Mon, 05 Sep 2022 03:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2pI-00071l-Qq; Mon, 05 Sep 2022 03:31:08 +0000 Received: by outflank-mailman (input) for mailman id 398436; Mon, 05 Sep 2022 03:31:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2pH-00071b-TC; Mon, 05 Sep 2022 03:31:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2pH-0007EL-Qj; Mon, 05 Sep 2022 03:31:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV2pH-0001Cb-FJ; Mon, 05 Sep 2022 03:31:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV2pH-0007Qa-Es; Mon, 05 Sep 2022 03:31:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R6fSZ/99SK53lswLvpHhDBrEmv1BBKyhcnIceDZMtgA=; b=DRSHsb054JyiHKEOs2/cEICF8z KFgdLbmoaUB14laagNL32Z+RDMUlVSNvnSpwN67T2dnhtl+g4fwB/pEefp4JNetDj8X5j7lnxiEj8 7aU316xQqqkz2CIozsG4L1ewnFHst5ydcocrCccDaBw47Nl9kXQ/c1FFbFmTdCO151VE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172992: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=ec87181192f013f4f7ff916b2a39ff2c87b079f3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 05 Sep 2022 03:31:07 +0000 flight 172992 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172992/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf ec87181192f013f4f7ff916b2a39ff2c87b079f3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 244 attempts Testing same since 172926 2022-09-02 02:30:44 Z 3 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1457 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 03:45:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 03:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398445.639274 (Exim 4.92) (envelope-from ) id 1oV32v-00007d-6B; Mon, 05 Sep 2022 03:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398445.639274; Mon, 05 Sep 2022 03:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV32v-00007W-2p; Mon, 05 Sep 2022 03:45:13 +0000 Received: by outflank-mailman (input) for mailman id 398445; Mon, 05 Sep 2022 03:45:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV32u-00007Q-1J for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 03:45:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2075.outbound.protection.outlook.com [40.107.21.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23e8d05f-2ccd-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 05:45:10 +0200 (CEST) Received: from DB7PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:10:52::31) by AM8PR08MB6628.eurprd08.prod.outlook.com (2603:10a6:20b:362::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 03:44:47 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::bc) by DB7PR02CA0018.outlook.office365.com (2603:10a6:10:52::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 03:44:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 03:44:46 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Mon, 05 Sep 2022 03:44:46 +0000 Received: from a8a37d5a5168.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17387697-A65C-4047-83F5-BDCF97051DCB.1; Mon, 05 Sep 2022 03:44:36 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8a37d5a5168.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 03:44:36 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB7804.eurprd08.prod.outlook.com (2603:10a6:150:5b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Mon, 5 Sep 2022 03:44:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Mon, 5 Sep 2022 03:44:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23e8d05f-2ccd-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YtAsGO3l/u6f2na0w7n4UciwNdBSeeo8kFF4br5DBZMk9fxVaQxYK2XuEx2XilG+IpCYj2qja+CnkQHc+eGla+9wO6Yk4DUfis2xnIg+QRFjQvj7yxdsBWwe8ctrUh9Wp8fQHvWi37QuE9Q+fyiPsCdM3tA4xT2Ur7SFE8rY+woZqZmLRIBiXHTUJau5npa2EKifO+w/prnoFWGuqtYrZN5uvOO7q50mgzXriZqzrP5SYqAJlotXE/wPp+cf7Kn1oN86M+dEtKIo4lobl8iQuqpq86ctFgfd2fHADHujNsNfgkWtf2zuXWI4UQ99Ioh3AU07zbtIV8XcBWKMRrS5IQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWoQ9ZSYFjnjyRnksdC3j5tqGGnmAdf0hNC572h/55M=; b=DMo+O8v5A9qmdrarwT8B3M3tsKG5uG+sBQUizcIgSTut2lCh2yJKh0BEpO0pbP2RQnubp4SplZ+/ry4HNHD7EAvZwArRya9XXSPT175BdBq3/YU/IcfN6Km8i2Hod9JQGXOhkX1em4BQy/D61DMPa2LdRkusLj7G2fgrh87S5i+Mt7ZWYvDmXM2AKFLNJz2PfJ2nzTJPhE9c5vwTv4Pwz5nyrHXJle2oV1kZUYfeNEWTKtEEXeoA4dbkyZR3bw8Dj4cYtslE7DdH7KIyePp/NLM8T18QSn9L1JiBnXjYsybomjN5hPDzeqIpsx9J7cjmFBr+bTpbh/4lb3+xJPB9XA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWoQ9ZSYFjnjyRnksdC3j5tqGGnmAdf0hNC572h/55M=; b=JIdFCN9TTPcy3B43QSSEWvz2trZIgJFjAanOmPOB17FAagCOtwJMREiZcczwjlHUhooJZCgKkEwjyG/6f+z9RCu7b7KJYHiHSAH5w3Vw/KLNdL2c6hIz8FHA2AUY1fdU1BOkjvqrlo+pfYW79sQT6UNNJa1966rxuepXjKSNI0I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMA7lBTnWr6WW47EYu214ws/uifdFJHojNE981QHzOnHoc1DnFH8j6RQ5IzRTnaGJolirwR2P48Da+qKdx9WOUCX4TjJrm8arTVklrLZLWV9Vu+cuKf6unkqbMnOsit3L7V/jyw3YEMD+O3ztk5EVN4ji3at6Drtv+0VLh5tcU9lWDSSMicDEYNH8DOJeWxKwBlNqebask9Q8TlYwZ3BCBdPhd2Yezck9WIIzZjAaqICq2ZqDFpA4xpr7S1Iw24l5yvjLHNaMZutiQwKfqahpm29SDUx3/vFY/34ZGZvRgavUTyLFXm4UPiedsX/1Sh2wLLoozpnA+pjwjfx3Zr03w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWoQ9ZSYFjnjyRnksdC3j5tqGGnmAdf0hNC572h/55M=; b=XabJUdUw8XAST1Jzv3l7Xp8GJolFwoE0je2NJFJMVJP7Lxz9vYohJvoJbARG/Qz1NXYgFsVR5W1l7gVHSFeK2yXlysk+3lolBId49zABLPoLpQ6YniFWFJEx4feh1vOig/4FG01uyZLTL+eRFbfX3Luv2Ur9DlbexyuYWtDXRonUUqklJ7cmx8VnOjCJq5/DWc5IQIMylBtNhvudW9B/QFtwDEo7QYwDYFgJDx0NK1N6uJTRnXHm/1XgSqTIMUSM1i34L7Kc443sJxv8IeEO/e/9jp+nEJpfqmkNU1ywIBwHfKaPYc3mEx7pCxkRUHDdPMUekceHL+lFZlXtv6KZeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWoQ9ZSYFjnjyRnksdC3j5tqGGnmAdf0hNC572h/55M=; b=JIdFCN9TTPcy3B43QSSEWvz2trZIgJFjAanOmPOB17FAagCOtwJMREiZcczwjlHUhooJZCgKkEwjyG/6f+z9RCu7b7KJYHiHSAH5w3Vw/KLNdL2c6hIz8FHA2AUY1fdU1BOkjvqrlo+pfYW79sQT6UNNJa1966rxuepXjKSNI0I= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: Xen 4.17 release: Current status before the feature freeze Thread-Topic: Xen 4.17 release: Current status before the feature freeze Thread-Index: AdjA2VmJ6EcVoZ5cTOOgVSRHep4cQA== Date: Mon, 5 Sep 2022 03:44:33 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0CB61D2A885E34408716F6B41BD27DDF.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 30386608-2497-4e7e-dc40-08da8ef0fa60 x-ms-traffictypediagnostic: GV1PR08MB7804:EE_|DBAEUR03FT034:EE_|AM8PR08MB6628:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lRUGf6YP0mGhDmx8LOhYz3axOHBqMLRB0gVkdoHI9Jgo26Rt1QX0uRX1YFKd111lds7eIMWgQ54GXXIDdKoucyIvlaLgHZeJXXHhJVSC8mDwhFVQmvNU3AxAzxMobTgrNZw852Cts96dhzDsmEAhpYnn5sbpSULXyZfIWBPG91YKOYTgRxT/P9xexM9k5bIFCEaEzr67+e5ur5KVCO4kBMK+Hn2moJ0kmKP+Z5ChJBbf/g+5hrm4Y2xwyGFaxweh5XUUk6ObrDREueMbrUfjbup6Y1f3uk/AK9Xz7O52uOyq9mHyPf+zVZkbUBD2Td9jDDe9n9jLLzqSNVyV+d7SJSVbmDfYjCYin4GveNtl5M7s83BkB0DS8W9hrrebAdpmwgdGO7Qt8FDheFt5UqrK4cz6qoIaDWXv7GDe1X4jsjF86bflHZTdCCfr+ahfVUcZpRgU6m1q58k0XFWQgpLSE4lHPF7zU0e6XxdVtAAiiwvRHX+Pji8SX+tYh9bODLNdbPGH9n8bWLm06CNuP83ipol5T+1jZoKSzjV8l0mXGTOqYnijf/sBToYEj18EY3caXTIhOIKQus2Hv9TlifNBpzVOG2DJs8vs1nEPwMEsr+xscXRmLKO/4wR2PF9hOS8GZYsBEJ9cJkxDthL8z3/gxkJATtR0caA37QT3HzvjeDPANiziipdEf1V3LgKqzCuWpVTAzl4ogAtz+nRYkqeDi1w7HJlT66JzBwwV58hoo5oxGzsFL1AK/MLeZW1xgAhaBNjn5H2WkmKWPzcLTqRSik1w8fUVrGejhzSUi34HEoutuaFg50bFo5+yVm2LvQmnsesLUQdD9oEc1x6h6MWo3g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(6916009)(316002)(83380400001)(9686003)(6506007)(26005)(7696005)(54906003)(52536014)(478600001)(8936002)(55016003)(38070700005)(7416002)(86362001)(2906002)(5660300002)(33656002)(122000001)(4326008)(76116006)(66556008)(66476007)(66446008)(64756008)(8676002)(66946007)(186003)(71200400001)(966005)(41300700001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7804 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 60a85741-798d-4a0b-502f-08da8ef0f26e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r9RevS05z7PcCz1BCiKXQdrR2Nahmge8CLB4/c8rgOJPaRIp3xnLpIzKWDcBLA7ZQE17P27d3Ictgi2AMpRYTotE/TiYmvbVzJuu8KEDCimECMaoo9vpkqmyqsaemx3MnFvwjk8Dyr4qEFHfbl8gMbwbFg2fLtXr4r/a79HvCPnlzCxLFt8jkr7v+kpuicEeWt7i+pcfNMJ7eZWcLMvYfcgdseGvrHFxmZDaQ7auUTvJwu+MBgRbNA+4/1XGMzZ4fDoz6mxMdlIhqXBm9K+bnOLQ1Mlx0r4zW2Rx8AHEAoWc9yQq1h3ZMRKHA4avKw4pC62V3/sZeeiITHXv2YsMMeunTailcu+oPhprBRPNWOffmaYohpV741pUe4A/awW1NK/Tu878+73wCx4g+lLQqN82Qam90/g2v/V6dw6AhyEHtnDP0HR1yHBRvnPoMqilcKluTlDjfVcCLUBGCIZhKp8z6Ri60QRudhyyiQIcGoTng+JQOcefsNZ6BYVqTV9x4yFl+NbHy06eCJb7jkGV5ot1VRS9jwgorKWcTzSSLrQSA7XRPoy3sBqE6ftlfkMF6RIrZdbJNtuwiG2CySlKqCSnsJkMIYplEVR8xkm7k795GBAPHvPaJGZH7PTgMsr15bWVrvlPiiGSx6iA8gcDvyYqMHYW0z3vhB6trhqSQ7YlUaDMGDeKAJsbqX0yNMt0y5UxS6b+PAkjwFNgjWKHIvpTILa6p/e/xStsr2sxcnF0zJkFS3MSvzg4HYTFH1l6lSA2//TS8leNkc1uOoPweQFewx0H8sPVfEnkzB9k75vITRgtW0z/zCcbzUBdckEP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(376002)(396003)(46966006)(36840700001)(83380400001)(36860700001)(54906003)(6916009)(82740400003)(356005)(81166007)(4326008)(55016003)(70586007)(70206006)(82310400005)(8676002)(316002)(2906002)(40480700001)(52536014)(8936002)(5660300002)(9686003)(7696005)(47076005)(6506007)(26005)(186003)(336012)(966005)(107886003)(41300700001)(478600001)(86362001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 03:44:46.9199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30386608-2497-4e7e-dc40-08da8ef0fa60 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6628 Hi all, As the feature freeze date is around the corner (Sep. 9, 2022) and we are currently summarizing the series for the release, here are the list of seri= es pending in the mailing list. Please add the ones that I probably missed. Thank you very much! Note that the blocker, automation, Arm lists should be accurate for trackin= g the 4.17 release IMHO. More inputs and clarifications might needed to clari= fy if all series in x86, tools and common lists are going to the Xen 4.17 rele= ase. Also, as agreed from the September community call, the tracking of Xen 4.17 release will happen both in the mailing list and the Gitlab. I will send th= e Gitlab link once the work is done. Thanks! ** Blocker List **: 1. Patch: x86: enable interrupts around dump_execstate() https://patchwork.kernel.org/project/xen-devel/patch/e717897f-980d-ad44-31d= 9-39f5e7e1c45e@suse.com/ Status: Waiting for review. 2. The fix of libvirt after the virtio support in toolstack Status: The OSSTEST seems to work properly, apart from what Jan asked in IRC - the qemu and omvf OSSTEST might need a force push. (I am not sure if this has been fixed so I just carried this) 3. [v2] x86/PV: issue branch prediction barrier when switching 64-bit guest= to kernel mode https://patchwork.kernel.org/project/xen-devel/list/?series=3D661061 Status: Need review. 4. Licensing issues and details https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-6137005add77@citr= ix.com/T/#u According to Andrew, relicensing device_tree_defs.h is a release blocker ** Arm **: 1. static shared memory on dom0less system https://patchwork.kernel.org/project/xen-devel/list/?series=3D661838 Status: Need v7 from author. 2. populate/unpopulate memory when domain on static allocation https://patchwork.kernel.org/project/xen-devel/list/?series=3D672665 Status: Patch #6 needs review. 3. xen/pci: implement is_memory_hole for ARM https://patchwork.kernel.org/project/xen-devel/list/?series=3D673155 Status: Patch #2 has comments and probably need a v3. 4. Introduce reserved heap Status: Need a v2. 5. xen/arm: smmuv3: Merge Linux fixes to Xen https://patchwork.kernel.org/project/xen-devel/list/?series=3D673634 Status: Need a v3. ** Automation ** 1. GitLab CI cleanup and boot time cpupools test https://patchwork.kernel.org/project/xen-devel/list/?series=3D673488 Status: Need CI maintainer's review on Patch #1 #2, need author's action for Patch #3. 2. automation: Test a pv network interface under dom0less enhanced https://patchwork.kernel.org/project/xen-devel/list/?series=3D666128 Status: Need reviews. ** x86 **: 1. [v2] x86: show_hvm_stack() requires enabled interrupts https://patchwork.kernel.org/project/xen-devel/list/?series=3D667114 Status: Need reviews. 2. [v2] x86: help inlining of functions involving alternative_call() https://patchwork.kernel.org/project/xen-devel/list/?series=3D667117 Status: Need reviews. 3. x86/spec-ctrl: Reduce HVM RAS overhead https://patchwork.kernel.org/project/xen-devel/list/?series=3D666983 Status: Patch #1 reviewed. Patch #2 discussion going on. 4. Intel Hardware P-States (HWP) support https://patchwork.kernel.org/project/xen-devel/list/?series=3D666690 Status: Need reviews. 5. x86/hvm: Improve hvm_set_guest_pat() code generation again https://patchwork.kernel.org/project/xen-devel/list/?series=3D666603 Status: Waiting actions from author. 6. x86/AMD: check microcode size against CPUID-supplied limit https://patchwork.kernel.org/project/xen-devel/list/?series=3D666515 Status: Need review. 7. xen/x86: import linkage.h and clean up x86/kexec.S and x86/entry.S https://patchwork.kernel.org/project/xen-devel/list/?series=3D665401 Status: Patch #1 #3 merged. Patch #2 #4 need actions from author. 8. x86: limit issuing of IBPB during context switch https://patchwork.kernel.org/project/xen-devel/list/?series=3D662741 Status: Need replies from maintainer 9. XSA-407 followon fixes https://patchwork.kernel.org/project/xen-devel/list/?series=3D660818 Status: Patch #3 reviewed with further actions from author. Patch #1 #2 merged. 10. x86/irq: switch x2APIC default destination mode https://patchwork.kernel.org/project/xen-devel/list/?series=3D655330 Status: Patch #1 merged. Others need review. 11. [PATCH v2 00/12] x86: memcpy() / memset() (non-)ERMS flavors plus fallo= ut Status: Some parts committed, some parts entirely uncommented on. 12. [PATCH 0/2] x86/vMCE: address handling related adjustments Status: No comments at all so far. 13. [PATCH v3 0/5] x86/mwait-idle: (remaining) SPR + (new) ADL support https://patchwork.kernel.org/project/xen-devel/list/?series=3D668735 Status: Patch #1 #3 #5 need reviews. 14. [PATCH v2 0/8] x86emul: a few small steps towards disintegration Status: Entirely ignored for about a year (since v1 submission). 15. [PATCH 00/11] x86: support AVX512-FP16 Status: v1 was reviewed, but some of the review comments need further clarifying before Jan can sensibly make/submit v2. Note that this depends on item 22 (albeit if absolutely necessary it could be re-based ahead). 16. Device tree based NUMA support for Arm - Part#2 https://patchwork.kernel.org/project/xen-devel/list/?series=3D673455 Status: Need reviews for Patch #1 #2 #4 #5. 17. [v2] x86/public: move XEN_ACPI_ in a new header https://patchwork.kernel.org/project/xen-devel/list/?series=3D670995 Status: Ready to be merged. 18. x86/PVH: restore VMX APIC assist for Dom0 https://patchwork.kernel.org/project/xen-devel/list/?series=3D670123 Status: Need review ** toolstack **: 1. Toolstack build system improvement, toward non-recursive makefiles https://patchwork.kernel.org/project/xen-devel/list/?series=3D666960 Status: Partially committed. Patch #1, #8 #17 needs an ack from related maintainers. More reviews needed for Patch from #20 2. libxl smbios support https://patchwork.kernel.org/project/xen-devel/list/?series=3D666694 Status: Need reviews. 3. Virtio toolstack support for I2C and GPIO on Arm https://patchwork.kernel.org/project/xen-devel/list/?series=3D669685 Status: Need reviews. 4. tools/ocaml code and build cleanups https://patchwork.kernel.org/project/xen-devel/list/?series=3D664150 Status: Patch #2 #5 #6 merged. Others need actions from author. 5. [v2,1/4] tools: remove xenstore entries on vchan server closure https://patchwork.kernel.org/project/xen-devel/list/?series=3D659375 Status: Need reviews for patch #3 #4. 6. [PATCH v7 00/11] libs/guest: new CPUID/MSR interface Status: Largely reviewed, but there was something Andrew's input was needed on, or he wasn't happy with. 7. tools/xenstore: add some new features to the documentation https://patchwork.kernel.org/project/xen-devel/list/?series=3D665064 Status: Patch #2 merged. Only patch #5 is not properly reviewed/acked. Discussion seems going on and (probably?) needs a respin. 8. acpi: Add TPM2 interface definition and make the TPM version configurabl= e. https://patchwork.kernel.org/project/xen-devel/list/?series=3D672588 Status: Need action from author. 9. Use direct I/O for loop devices https://patchwork.kernel.org/project/xen-devel/list/?series=3D668537 Status: Need inputs from reviewer/maintainer. 10. x86/hvmloader: Fixes/improvements https://patchwork.kernel.org/project/xen-devel/list/?series=3D670606 Status: Need actions from author. ** XSM **: 1. [v12] xsm: refactor flask sid alloc and domain check https://patchwork.kernel.org/project/xen-devel/list/?series=3D666302 Status: Need review. ** drivers **: 1. Add Xue - console over USB 3 Debug Capability https://patchwork.kernel.org/project/xen-devel/list/?series=3D673630 Status: Need reviews for #1 #2 #4 #9 #10 2. PCI: avoid bogus calls to get_pseg() https://patchwork.kernel.org/project/xen-devel/list/?series=3D666322 Status: I am not sure if this is superseded by PCI: re-work pci_get_pdev() and friends, if so please ignore this. ** Common **: 1. xen: add late init call in start_xen https://patchwork.kernel.org/project/xen-devel/list/?series=3D664963 Status: Need actions from author. 2. xen/wait: Improvements https://patchwork.kernel.org/project/xen-devel/list/?series=3D660565 Status: Need reviews for patch #4 #5. 3. xen/sched: fix cpu hotplug https://patchwork.kernel.org/project/xen-devel/list/?series=3D667963 Status: Need actions from author for Patch #2, need confirmation from maintainer for Patch #3. 4. Hyperlaunch https://patchwork.kernel.org/project/xen-devel/list/?series=3D657187 Status: Need actions from author. 5. [PATCH 0/9] gnttab: further work from XSA-380 / -382 context Status: Some parts are controversial, but this shouldn't prevent the reviewing / progressing of non-controversial ones there (7-9). 6. [XEN PATCH v2 0/4] xen: rework compat headers generation Status: The 3rd patch needs reviewing by someone speaking enough Perl. 7. MISRA fixes. https://patchwork.kernel.org/project/xen-devel/list/?series=3D672591 Status: Need review. 8. Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS https://patchwork.kernel.org/project/xen-devel/list/?series=3D670926 Status: Need review. 9. Make XEN_FW_EFI_MEM_INFO easier to use https://patchwork.kernel.org/project/xen-devel/list/?series=3D670812 Status: Need confirmation from maintainer 10. [XEN,v2] build: Fix x86 out-of-tree build without EFI https://patchwork.kernel.org/project/xen-devel/list/?series=3D668331 Status: Reviewed but not merged. 11. [XEN] MAINTAINERS: CC Anthony on Xen's build system changes https://patchwork.kernel.org/project/xen-devel/list/?series=3D667992 Status: I guess this need a v2? Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Mon Sep 05 05:55:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 05:55:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398454.639284 (Exim 4.92) (envelope-from ) id 1oV55D-0004cA-IM; Mon, 05 Sep 2022 05:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398454.639284; Mon, 05 Sep 2022 05:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV55D-0004c3-Fm; Mon, 05 Sep 2022 05:55:43 +0000 Received: by outflank-mailman (input) for mailman id 398454; Mon, 05 Sep 2022 05:55:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV55C-0004bt-5k; Mon, 05 Sep 2022 05:55:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV55C-0001lC-1P; Mon, 05 Sep 2022 05:55:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV55B-0003JS-Iu; Mon, 05 Sep 2022 05:55:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV55B-0007Kf-ID; Mon, 05 Sep 2022 05:55:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KDhLkEHjWZWLmcWuwxHp/ljK+vwl+Z67pwqoKjNzNEA=; b=N2CEuLJumG7dDpPpN+urD4WOL5 +UZbh5YGtHfPltEgDpVOjw5s6rC5iuVk7AiG+H4w/+YIf2ATgVWPOX1f9loqMs803i7yXZJ4Kv98E jEpn5K+Rd+wHHUWen0yZqCBWTEUKhlqWbhkcIWiI/4uD8BUWmJFOodVNSwfnpKZeJ/2E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172988: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Mon, 05 Sep 2022 05:55:41 +0000 flight 172988 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172988/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail pass in 172981 test-amd64-i386-xl 7 xen-install fail pass in 172981 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 172981 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 172981 like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail in 172981 like 172128 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 172981 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 172981 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 32 days Failing since 172384 2022-08-11 11:13:58 Z 24 days 53 attempts Testing same since 172776 2022-08-25 17:42:45 Z 10 days 24 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 06:24:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 06:24:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398463.639296 (Exim 4.92) (envelope-from ) id 1oV5X9-0007zH-T9; Mon, 05 Sep 2022 06:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398463.639296; Mon, 05 Sep 2022 06:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5X9-0007zA-OL; Mon, 05 Sep 2022 06:24:35 +0000 Received: by outflank-mailman (input) for mailman id 398463; Mon, 05 Sep 2022 06:24:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5X9-0007z0-DQ; Mon, 05 Sep 2022 06:24:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5X9-0002LE-7X; Mon, 05 Sep 2022 06:24:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5X8-0004RF-OS; Mon, 05 Sep 2022 06:24:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV5X8-000600-O3; Mon, 05 Sep 2022 06:24:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jy4gMmz4ygl7BmU23roriRmkdYyf+oiiUQGtObviTcQ=; b=AbP0N9fxjVwGJhvxh7vmcv1szj GEYK144gWKzyQ69QWmMYtJQqNShPhnqIDqv5e0Oid4YJ3o1PK6aR+8DOsBmHwa+NPeRqNkWcYr2ci kiBlK+jL7MkKKM+i7bbZl6S4mDYuP+/GavOiIA9erXLwZ39YV1z9B+vHnurmAtXa/MJU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172995: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=08522341c4935f27cd7d3dbfd38ffa8329cdc2cb X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 05 Sep 2022 06:24:34 +0000 flight 172995 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172995/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 08522341c4935f27cd7d3dbfd38ffa8329cdc2cb baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 31 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 245 attempts Testing same since 172995 2022-09-05 03:33:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1474 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 06:27:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 06:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398472.639307 (Exim 4.92) (envelope-from ) id 1oV5aO-00008T-C3; Mon, 05 Sep 2022 06:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398472.639307; Mon, 05 Sep 2022 06:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5aO-00008M-8B; Mon, 05 Sep 2022 06:27:56 +0000 Received: by outflank-mailman (input) for mailman id 398472; Mon, 05 Sep 2022 06:27:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5aM-00008F-Up for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 06:27:55 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2052.outbound.protection.outlook.com [40.107.96.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ddad6605-2ce3-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 08:27:51 +0200 (CEST) Received: from BN9P223CA0028.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::33) by BL1PR12MB5319.namprd12.prod.outlook.com (2603:10b6:208:317::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 06:27:44 +0000 Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10b:cafe::9c) by BN9P223CA0028.outlook.office365.com (2603:10b6:408:10b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 06:27:44 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 06:27:44 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 01:27:43 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 4 Sep 2022 23:27:43 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 5 Sep 2022 01:27:40 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddad6605-2ce3-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfotplqbU/vz7M1OXGvINP9k8VIxTe6trI7/gU6uWdpBqouCXkkqyuA5SD7cxFJGGfND+sboz+XDT843wBt0wg8Np1IrXcScp+DhOTYLvUx2YdURK3wAz22lbHkdxbD8RbMDS87o5RUy/DgJrAqx33vFfJX2LpuNTa/ogj2mn5/CxNek6cfDwuYmLyIy0imsRq376m/Es+k6Wgtxq8b3ODaX+grQltMwqmPk1L+ZnJBxS0c0n8sbJ92iLCaSDvvT0DgsC3MFi5TMGjiHn1TSiJpC0fY2+rKxkKesQ025TjptTT+eIJjx/EQeu7w6Ft4ELYUSNajdfrqrsE0MVcSXgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LEXN8yK+NOi0eG2LmzvXUlKfjKJlPX22L+PLn+EGk40=; b=E2PUrfgx3wJ1sXYBTgeX1mIrL9cMsCSCSMIOE+JO2uXVHPFiGUkZOpA6uItioP3oPgbrpq0NDzKTcMXnp5jZdoL1sBugIXVy7sGsFXujnCb8vJbFfEzIEHhfBQSekeH8kAhDAy0zgg7Qa6pFA5cCwJetVa8kWRF10ZELcuVnh5wi0FMIf0pUIzi9wmSqafnpA2DR68QZqXRtmX6dqEO9rvN6GHTtPv0zpjPppV3i8qIfFaaxxzvuejln7jnzKLOa7OVSXObApvSSoo38LeDHG+Wl4g0sc3nFB3C3lR0jOPwS25nbwSJKd/Sb+zkZrkmG7OtCTxrlZYLWgp3z/U+qKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEXN8yK+NOi0eG2LmzvXUlKfjKJlPX22L+PLn+EGk40=; b=cefO86k9EKZHzMK/uRPzDpbCSoQkn+JcnT8AEdxtm5eKOykLhf69w7Mbs0C4PAcmmgx25t9tfWdJTbOjVLksBR/qU82yBgn9UHJExIaVKB0zvr70wmbEhVhkhMVvhTKNB0xbxjfUT0HSjAxM0YRFX195GM+ZFSFlOS7egzETk/E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Mon, 5 Sep 2022 08:27:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Xen 4.17 release: Current status before the feature freeze To: Henry Wang , "xen-devel@lists.xenproject.org" CC: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , "Bertrand Marquis" , Julien Grall , "Julien Grall" , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , "Volodymyr Babchuk" , Wei Liu , "Wei Liu (LSG)" References: Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 599efcef-e026-4c25-22fb-08da8f07bdf9 X-MS-TrafficTypeDiagnostic: BL1PR12MB5319:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fwXaEqUdLn8odlCDJA/TAzR1UwDBQLIPqVDIwShjQsHqBea2PCLfm1hBLaBrBt0RDzQZ3vs9r6wJhcJzmn/jZ/rZUs93n+UnzUoarnQdgu4AXvGhJPgxv+XsTvSiDV7uTrR/m1EeeTVoL00TwvmmW+f/le5LQGZT1Z3QNcjlBBJIL/iRJudpI9E7dFIL1BSKlJ/hcFCemrMXCFfWr0jwYl7TaUR4OR57kVXUchA0hXytd4qgN4in5aoP82ImFnn4nguDsB2T+4o3aI3aZARogJOPOdsABOen3AzpZeXwPRXEp/HSrAfVS6rx4tzKx6gHKjZ/eW4MGtWfrT0rGLbT17xBn+3r0WU+CVoMInS/a88FBtsvOLiHxBzRcpHfGmnAURxWbWAMXrv1T20Z1y0iikS/Aa5VNqZTWAsSe1WpHobIhcGGy+1XbCuc/+3lg3ZAeNwIco9RW16+mpwAn2GAeqI7efPESwy4Gg6L7gpCcy3M9vyKDWm0u4bo1JqgNRFDLNLjXR5ZpODBGljXCYNa7VPHf28HzdmORun5Z3W665RQ7BE60pX0LkZIkDBksJZf/FAPYnmOYIxJRv8y21VHT855D8o+MhILe2tJmGpNh3dVo9UC+PqjctkBeizNpDV6QH6LjoCBBPsx+KBQNnmTOUxs94k/XKvlLXgvgXZ3EhgypgCFUkM9lw85dhISm0wAa4wzvGKnOyJmuZPp/924g1NVZOD+VGBW+TAXo5/UQzwIRVClbUeXUmW2tckpCoNpvaV2sycIuR7Q1pM4AtFq3WPxVLnDqpH6CWP4T0f6YEQ7hZm+6tgRwlXF6M42HkySZQgJOTOnEauTaoE/i/7J+b0q9rsNfQ7jtNetzQ+lqxiuwbQzKoN4FsFR/6m+Yp3CBnfxkkSAKS4X6lVocYH5uw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(39860400002)(46966006)(36840700001)(40470700004)(30864003)(41300700001)(36860700001)(45080400002)(5660300002)(7416002)(53546011)(86362001)(26005)(54906003)(110136005)(31696002)(2906002)(16576012)(316002)(47076005)(426003)(40480700001)(44832011)(70586007)(336012)(81166007)(186003)(2616005)(82310400005)(8676002)(4326008)(356005)(40460700003)(82740400003)(966005)(478600001)(83380400001)(31686004)(36756003)(8936002)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 06:27:44.0485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 599efcef-e026-4c25-22fb-08da8f07bdf9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5319 Hi Henry, On 05/09/2022 05:44, Henry Wang wrote: > > Hi all, > > As the feature freeze date is around the corner (Sep. 9, 2022) and we are > currently summarizing the series for the release, here are the list of series > pending in the mailing list. Please add the ones that I probably missed. > Thank you very much! > > Note that the blocker, automation, Arm lists should be accurate for tracking > the 4.17 release IMHO. More inputs and clarifications might needed to clarify > if all series in x86, tools and common lists are going to the Xen 4.17 release. > > Also, as agreed from the September community call, the tracking of Xen 4.17 > release will happen both in the mailing list and the Gitlab. I will send the Gitlab > link once the work is done. Thanks! > > ** Blocker List **: > 1. Patch: x86: enable interrupts around dump_execstate() > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Fpatch%2Fe717897f-980d-ad44-31d9-39f5e7e1c45e%40suse.com%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197623536%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vnthB7ax%2FUotcyFVzDr4KY0upw%2FMaVcohohNhkX8FSA%3D&reserved=0 > Status: Waiting for review. > > 2. The fix of libvirt after the virtio support in toolstack > Status: The OSSTEST seems to work properly, apart from what Jan > asked in IRC - the qemu and omvf OSSTEST might need a force push. > (I am not sure if this has been fixed so I just carried this) > > 3. [v2] x86/PV: issue branch prediction barrier when switching 64-bit guest to kernel mode > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D661061&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Uht4bWolBsJ9mBOBlS%2BGAu54aF31KM%2B1KoYX1L2qIWA%3D&reserved=0 > Status: Need review. > > 4. Licensing issues and details > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fxen-devel%2Fb58f5340-d4fa-df9d-89de-6137005add77%40citrix.com%2FT%2F%23u&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fwpKnLKCXDNxAtBYVRmqZVsLWB%2BEB45V0GNU2vN2RVw%3D&reserved=0 > According to Andrew, relicensing device_tree_defs.h is a release blocker > > ** Arm **: > 1. static shared memory on dom0less system > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D661838&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=28lcf7Dz5%2FeHSmBV3zzvCaxtUVqq8IC30S75r3%2B66Cw%3D&reserved=0 > Status: Need v7 from author. > > 2. populate/unpopulate memory when domain on static allocation > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D672665&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jZGE6%2BOGqJSqX%2FZOCLTg45zPOvD0PFzqD6%2FPNBTGWIE%3D&reserved=0 > Status: Patch #6 needs review. > > 3. xen/pci: implement is_memory_hole for ARM > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D673155&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NtnIPQdAFfymoMgIhbMMQkmF1M7Cxa4CTYxdYTJZZKA%3D&reserved=0 > Status: Patch #2 has comments and probably need a v3. > > 4. Introduce reserved heap > Status: Need a v2. > > 5. xen/arm: smmuv3: Merge Linux fixes to Xen > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D673634&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XP1tf8AFAtTpz6p3xlKC4Owk1KBcFQPKuOgEoVxGF%2BE%3D&reserved=0 > Status: Need a v3. > > ** Automation ** > 1. GitLab CI cleanup and boot time cpupools test > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D673488&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JjOXozG5%2BjcqJLBgeK7Q2j8DdLF164hgVIC0ji2fI90%3D&reserved=0 > Status: Need CI maintainer's review on Patch #1 #2, need author's > action for Patch #3. > > 2. automation: Test a pv network interface under dom0less enhanced > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666128&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2B4hsXs170gzyFfIHushsp5RtSRR0OHiQ02oJYRxeh8%3D&reserved=0 > Status: Need reviews. This one is already committed so no further actions are necessary. > > ** x86 **: > 1. [v2] x86: show_hvm_stack() requires enabled interrupts > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D667114&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2GMogdfRBaU9m3iCbG1inTo9kFdhQr8GnhNP%2FtVU5LI%3D&reserved=0 > Status: Need reviews. > > 2. [v2] x86: help inlining of functions involving alternative_call() > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D667117&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9KdAzRjVbKphM25fivLDYFEhsncF9CDsbOLUEuaO8AM%3D&reserved=0 > Status: Need reviews. > > 3. x86/spec-ctrl: Reduce HVM RAS overhead > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666983&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dsiSOtY%2FzguMjrenaDfXIQwBtRlYk4nFROr%2FwBZgb1A%3D&reserved=0 > Status: Patch #1 reviewed. Patch #2 discussion going on. > > 4. Intel Hardware P-States (HWP) support > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666690&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wOTtNaEBTGKEzD%2FVFh2QuYhjhnHts288fgKY4zcIVEs%3D&reserved=0 > Status: Need reviews. > > 5. x86/hvm: Improve hvm_set_guest_pat() code generation again > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666603&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=N0WQ223ZJe9%2BpkrNc6tiwbbM68Q%2FVf5yqXVtzK0FOU0%3D&reserved=0 > Status: Waiting actions from author. > > 6. x86/AMD: check microcode size against CPUID-supplied limit > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666515&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BvmkDXDbRNmKJ7jnO2PreisO%2FKzIrjVyZHUKmzczmAM%3D&reserved=0 > Status: Need review. > > 7. xen/x86: import linkage.h and clean up x86/kexec.S and x86/entry.S > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D665401&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sL8CWy4YKZvvCNqFXf4FtlbWB6zc5LZocXCqeC1P664%3D&reserved=0 > Status: Patch #1 #3 merged. Patch #2 #4 need actions from author. > > 8. x86: limit issuing of IBPB during context switch > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D662741&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wXpCCywBSgU1tVagEhBkI9pIOl6tAFqwCorSffcOhTI%3D&reserved=0 > Status: Need replies from maintainer > > 9. XSA-407 followon fixes > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D660818&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ri34I7PPXm%2BR3GJtrADNK5eiwenNFqqFjCo9SsYIWzo%3D&reserved=0 > Status: Patch #3 reviewed with further actions from author. Patch > #1 #2 merged. > > 10. x86/irq: switch x2APIC default destination mode > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D655330&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vFEDwnmV%2FshbnDHkIA4nwyXh%2B%2FnvgmpSow5oRXYfqVM%3D&reserved=0 > Status: Patch #1 merged. Others need review. > > 11. [PATCH v2 00/12] x86: memcpy() / memset() (non-)ERMS flavors plus fallout > Status: Some parts committed, some parts entirely uncommented on. > > 12. [PATCH 0/2] x86/vMCE: address handling related adjustments > Status: No comments at all so far. > > 13. [PATCH v3 0/5] x86/mwait-idle: (remaining) SPR + (new) ADL support > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D668735&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wahuXQHzNyi5Yt2CI4kKmhfzmzN%2BS%2FJEO0OSYx%2FTwSo%3D&reserved=0 > Status: Patch #1 #3 #5 need reviews. > > 14. [PATCH v2 0/8] x86emul: a few small steps towards disintegration > Status: Entirely ignored for about a year (since v1 submission). > > 15. [PATCH 00/11] x86: support AVX512-FP16 > Status: v1 was reviewed, but some of the review comments need further > clarifying before Jan can sensibly make/submit v2. Note that this depends > on item 22 (albeit if absolutely necessary it could be re-based ahead). > > 16. Device tree based NUMA support for Arm - Part#2 > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D673455&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TusNBDBsW7AnSGpR6yEImKNxkEGLgZIgjEEcev4ryEw%3D&reserved=0 > Status: Need reviews for Patch #1 #2 #4 #5. > > 17. [v2] x86/public: move XEN_ACPI_ in a new header > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D670995&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197779758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=majajhLfE62Up3M9KAa6ksgslTGKvsGBoGxhGHhNuL4%3D&reserved=0 > Status: Ready to be merged. > > 18. x86/PVH: restore VMX APIC assist for Dom0 > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D670123&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Ip4xHGg0TxIuKVlRaWCrbNAsdHGH6%2FgCXfzEHOoHWk%3D&reserved=0 > Status: Need review > > ** toolstack **: > 1. Toolstack build system improvement, toward non-recursive makefiles > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666960&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Xl6A9Maf1F%2FEMvPFqW3NZJ7JGx5T07NFcoME5xLGGqc%3D&reserved=0 > Status: Partially committed. Patch #1, #8 #17 needs an ack from related > maintainers. More reviews needed for Patch from #20 > > 2. libxl smbios support > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666694&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=D4FOu0dHNWQ7nO89P2k6rH2nT70Jn%2BaIIYnGKilksIk%3D&reserved=0 > Status: Need reviews. > > 3. Virtio toolstack support for I2C and GPIO on Arm > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D669685&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4z16JuysU54mjtqnuDfUvS8LdtOJ0nFWBKO6BtLTlWY%3D&reserved=0 > Status: Need reviews. > > 4. tools/ocaml code and build cleanups > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D664150&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kTkbw7CwcqAxFqyq2aSiVAReJkcCpvOHEcYJln2DAQE%3D&reserved=0 > Status: Patch #2 #5 #6 merged. Others need actions from author. > > 5. [v2,1/4] tools: remove xenstore entries on vchan server closure > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D659375&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iw0ZOpdDn1Q1KadIX4rFSabGrv%2FKwCegv%2BrRNFkVm2o%3D&reserved=0 > Status: Need reviews for patch #3 #4. > > 6. [PATCH v7 00/11] libs/guest: new CPUID/MSR interface > Status: Largely reviewed, but there was something Andrew's input > was needed on, or he wasn't happy with. > > 7. tools/xenstore: add some new features to the documentation > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D665064&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Ffi7oTkO%2Bog2bzwrRhJ52mDkVs3RJcvUf8bkYSN8lQY%3D&reserved=0 > Status: Patch #2 merged. Only patch #5 is not properly reviewed/acked. > Discussion seems going on and (probably?) needs a respin. > > 8. acpi: Add TPM2 interface definition and make the TPM version configurable. > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D672588&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eFtefrytIF%2F%2BLYsKCDyyjObhjfJwnLpn%2BgPdaWf8Wu0%3D&reserved=0 > Status: Need action from author. > > 9. Use direct I/O for loop devices > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D668537&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BtxexTF2VJBhEX%2BKLE%2FlB2dtUkNY6EsG3Ef0Q2g%2FBno%3D&reserved=0 > Status: Need inputs from reviewer/maintainer. > > 10. x86/hvmloader: Fixes/improvements > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D670606&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LJHMEa2HKYgCTbBxcVLA2eSTyJrCXeOUtuAKXzAivU0%3D&reserved=0 > Status: Need actions from author. > > ** XSM **: > 1. [v12] xsm: refactor flask sid alloc and domain check > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666302&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ugxiYYLWSSOYxtPkEWDeOIQL8z%2BTi5gEb7EEZPxQAeo%3D&reserved=0 > Status: Need review. > > ** drivers **: > 1. Add Xue - console over USB 3 Debug Capability > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D673630&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9zvdfqJJIWpX6MT%2B%2FYHQ6uutsMRMJF9Auw%2FiQmqjeHw%3D&reserved=0 > Status: Need reviews for #1 #2 #4 #9 #10 > > 2. PCI: avoid bogus calls to get_pseg() > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D666322&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BU10KM16NKzBltZNKV9YbSTjVJ%2BuwWiXZBgEE8CAzK0%3D&reserved=0 > Status: I am not sure if this is superseded by > PCI: re-work pci_get_pdev() and friends, if so please ignore this. > > ** Common **: > 1. xen: add late init call in start_xen > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D664963&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uE2i0zvCY5GXYX6d1xOnogzVIiFZqZTVHqb%2FSNIM4Go%3D&reserved=0 > Status: Need actions from author. > > 2. xen/wait: Improvements > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D660565&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=41hE63L7h18TQSjfbLoz63lIWKAMaeOBtQdHDUWSx28%3D&reserved=0 > Status: Need reviews for patch #4 #5. > > 3. xen/sched: fix cpu hotplug > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D667963&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FH63FIDiaE0dw4HFjk6y6l1AmAW%2Bagx0jVND6vlC9ZM%3D&reserved=0 > Status: Need actions from author for Patch #2, need confirmation > from maintainer for Patch #3. > > 4. Hyperlaunch > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D657187&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=L%2BbTDhvf4VEFLCFm9j14s8%2B4nBb39QO3ykeshD9hCNE%3D&reserved=0 > Status: Need actions from author. > > 5. [PATCH 0/9] gnttab: further work from XSA-380 / -382 context > Status: Some parts are controversial, but this shouldn't prevent the > reviewing / progressing of non-controversial ones there (7-9). > > 6. [XEN PATCH v2 0/4] xen: rework compat headers generation > Status: The 3rd patch needs reviewing by someone speaking enough Perl. > > 7. MISRA fixes. > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D672591&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VNurmeZaHbnKVm3qySTUeJ%2Fsnz8hVYH%2B6yj%2F%2Bi9m1O8%3D&reserved=0 > Status: Need review. > > 8. Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D670926&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WtYYtGWNUPdIk0qbgndnq9dJiAoEztZj%2F6DGTx9J2Do%3D&reserved=0 > Status: Need review. > > 9. Make XEN_FW_EFI_MEM_INFO easier to use > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D670812&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=z4pu6ezw2gg8aBKQW4RK8VJZqkYiqB16G2x%2FQI7NOMw%3D&reserved=0 > Status: Need confirmation from maintainer > > 10. [XEN,v2] build: Fix x86 out-of-tree build without EFI > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D668331&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DpWn9TxA%2B9lVbgAB8ruV3lxPNFdRmJuA5QaoTnW%2FRIc%3D&reserved=0 > Status: Reviewed but not merged. > > 11. [XEN] MAINTAINERS: CC Anthony on Xen's build system changes > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fxen-devel%2Flist%2F%3Fseries%3D667992&data=05%7C01%7Cmichal.orzel%40amd.com%7C3f83f8ea3b134211740a08da8ef10c82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637979463197936037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ivWh1KaJPkJKL6CNnte9KPJm5g%2FcKd2hhQjJ%2F99z9eE%3D&reserved=0 > Status: I guess this need a v2? > > Kind regards, > Henry > From xen-devel-bounces@lists.xenproject.org Mon Sep 05 06:32:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 06:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398481.639318 (Exim 4.92) (envelope-from ) id 1oV5ep-0001d9-4M; Mon, 05 Sep 2022 06:32:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398481.639318; Mon, 05 Sep 2022 06:32:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5ep-0001d2-0Q; Mon, 05 Sep 2022 06:32:31 +0000 Received: by outflank-mailman (input) for mailman id 398481; Mon, 05 Sep 2022 06:32:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV5en-0001cw-Bi for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 06:32:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82bf1966-2ce4-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 08:32:27 +0200 (CEST) Received: from DB8P191CA0001.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::11) by VE1PR08MB5678.eurprd08.prod.outlook.com (2603:10a6:800:1a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 06:32:24 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::11) by DB8P191CA0001.outlook.office365.com (2603:10a6:10:130::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 06:32:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 06:32:23 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 05 Sep 2022 06:32:23 +0000 Received: from 69e9e9a9c2c1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 16300792-A05B-4B43-B43D-0E6C22A8CC15.1; Mon, 05 Sep 2022 06:32:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 69e9e9a9c2c1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 06:32:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV2PR08MB9349.eurprd08.prod.outlook.com (2603:10a6:150:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Mon, 5 Sep 2022 06:32:10 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Mon, 5 Sep 2022 06:32:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82bf1966-2ce4-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hnV0HzZ+V2GmnwTG/62f1ZI60zhGh0vSE9Ibc+EaQ/jI3C3/ateem7tvEM0LD3UZQZR0U27rKSpxVwvb2wugHvU7V84BMlA7Om6DyuAklFTvLDvPkjab05mFD3kqBSPsEaNMKd+AXuSrikslDh1DQwXIb8ehlXJZpL/ENdMD3+vH1/WRVrG2JKUhHEDyWYku+aQJ06dxIWBJkwguSgJz+aXc/nCwyA4sS3QP650N+mimgdzZ3Gy8kBybHPGbhk/5ir0fnrDfMdRNBdL4nhlInrqegfev2fITkaV97Sr9wTqI5xi2s4r+eaw8N+a9oXTodAZUz8iI3Nq6bFhcs9KJPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MqpPF/edmWMSORvpVcHoHFZe05iZXukyC3jbWDN62A=; b=GYZCHCDlt4sxadQuV/+3QQOEkAzCJWJHrpJOE/iWYoeMud/6wxTU/OErt83YxqMsPGI9Kf6Qpc7TjvsE3n6f/iWIngBIu1rN/v1TY7ztI6AEV5T2DUkcv6EAjl0k5Pf2DGIed+NwLj5rUfAp0ElhU2Oaz2ZcZPl2B1kCNL9FV/2P5HUHtSLPkQ1DI6HdILmurh5lL8yB71ZvXEPaxTi+eaXPKiltDaxCeJxSP0R07yLJ3QyTNICMs2HYCgpKaBBAlCK108Z+vjAWwScyS+aoluM+5LJZJFh1BiKAJ19cBCq5fV7Uos7zwPwAkm3YfVXfc+2gSTKCwr2H52QHNoobIg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MqpPF/edmWMSORvpVcHoHFZe05iZXukyC3jbWDN62A=; b=zX2k5Qtqlb0fMEGeqq+DbR5KhvLioWZy6OHiGNNektQ+tEuJo0lKNFYqTq16f4bsxNcu4E2xaC0CwYaHbO1a9i+vG9R3qd8g/DLTy715OhXlgMOhs6CJNq2ua1QEXa8b2Y8Ayrjio2CoohvS6e7MC7CgUOMI7K8b0st4Z5KEnJ0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijk84FKmZu+Ihs71C3Ge0oTmH1thUnRSVAoASmkFOdAo7KWtN/kiDxp/YjOVKn1/S3dHDiLk30V0SbFLPbCTqsElzYZk8beLhDvYgZLie//6jsvhQVz4erBzxs9kT1MM5FaxHVhNH6LDk/DhWN5X4eVWZxKpHgDW10CMJu91kJ3AYEGb90awoF15ldhEbJw5LSDhOszcq8Pwn2gM35zcldKrgBD+uu5nWKLknXP5XoeshXL+tcxhmJpz9hrzkmSA7efjfq3TM0ukP0bBODR9yBgDE+nVIxj1eb2dUCS2G13lGWtsIqYUeJ3Ugfwb5KKMybPaHj/B7mIoRIRHwGRRbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MqpPF/edmWMSORvpVcHoHFZe05iZXukyC3jbWDN62A=; b=b6MS1EGCcxVgP/FncijZS6MY6PrubVLTyxiy6MVBolrOPdSG7Nh2J6dQmIhPAX7b2z3l9uIGFDOQVe1eQ2lvPQ0p5QzgdAojYVdve78amnVR4jmvwmMng31dEqoOlZl/5mZpFvj6oczj+GOjdbaL+8IgrXzyiXlEVJZDEBCAO+9efGXTPrzWlHulwBN3Osnw2QdkfAVTz8Xmf8WgGHLmhfYAVVcGu4ot/zNlPWPCZ/mgq/s3+ny8g9q4+688VJtlWoLY8TWQDJxhxtyqzP6PdF5qVWROMU34xaVaYnDQzluUCWOmyTE0rznFiZFgT/GoDEk+2UUizVCzqs/FG9BDEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MqpPF/edmWMSORvpVcHoHFZe05iZXukyC3jbWDN62A=; b=zX2k5Qtqlb0fMEGeqq+DbR5KhvLioWZy6OHiGNNektQ+tEuJo0lKNFYqTq16f4bsxNcu4E2xaC0CwYaHbO1a9i+vG9R3qd8g/DLTy715OhXlgMOhs6CJNq2ua1QEXa8b2Y8Ayrjio2CoohvS6e7MC7CgUOMI7K8b0st4Z5KEnJ0= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: RE: Xen 4.17 release: Current status before the feature freeze Thread-Topic: Xen 4.17 release: Current status before the feature freeze Thread-Index: AdjA2VmJ6EcVoZ5cTOOgVSRHep4cQAAFz7uAAAARPBA= Date: Mon, 5 Sep 2022 06:32:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3BA66BA891313547A71F151FD0D52755.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 31b730f1-54ee-41cf-a5fe-08da8f0864b6 x-ms-traffictypediagnostic: GV2PR08MB9349:EE_|DBAEUR03FT030:EE_|VE1PR08MB5678:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OPs385BS6uXWmnNq7WWwCw1eAydLmGw8HA0vqbgzc97yi+MxyzK7S7CHbilb4djdeKPDr7d5XlmFGKCUmNUgSHVpEgRX7sRvkaM/HQtPXKdoXguCAB/AeqwG1GXu/oiYNHuczi3OfNvyNuiZMOojbmCFAzWfMjZ9NmcuEOID+iKT5PAIC+mtF2czZCDNYCj8ajSS+IjQDPfbVt65HKo+IKsB5pQDLzVOMmjpaMQw9CT9gS2lffi/F/lnznm3PNTZKNYgpGfnyei87dgOZZE4W88EJT8xEpyBdpZqBkJZcVPQKKhYWscwkE7LQRofSxuYejEAEjotjqsKlxKT6wwVrwZx3vDa46YNNSgg0S2ipFWiafIm/dmaEB3N7TYRbQqwN44vTiGZh5LZqppWENQOyFQs501wymi+h2GEF7dy2qGpcdnjqWkej/JcInImQdZFmdmr0hcAroTjoNaHI37Qo5uHEuhE03T6Y588dRUDzeabrALuLLw1kOEsfsNUbzHxxsDwrFPuD99KhkgQHW8tOMvQVZ3Ms+eJV/Y5Tcyr46sKhI9FYDNRRUB0K1CxGNbkab5FdGHceIhdhbeDMP5tsNrh0O5jVnTzf6eQsm0Xf8XVRWUgi8lC3zXQVAqVm7aRB26kRij86lfGDrmxQKwB1UNyRFJHdSZdWrwnF9ban/cvLqxAttDEt1Q+tb0Bzxi0scz0ZR995W9/Z1Z/jTuZG9y+gzYTjNPcvJus3HqXRCsbxoY1m2xjo6ih/mYez1REVDkS1IxCagqwAydm+yoDK8UM0gkmFvadQ8C2nYpkBLQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(376002)(366004)(122000001)(66556008)(8676002)(66446008)(66476007)(76116006)(4326008)(66946007)(64756008)(38100700002)(966005)(41300700001)(71200400001)(186003)(26005)(7696005)(9686003)(478600001)(54906003)(6506007)(316002)(83380400001)(2906002)(45080400002)(110136005)(8936002)(52536014)(55016003)(5660300002)(7416002)(33656002)(38070700005)(4744005)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9349 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be9a39b6-19e0-4122-d6ae-08da8f085cd3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 22lHgBDpKPWX4vax3V7aTg7SYhE5PuuVEAZM/F9yb/lRoLg3Az/MpuOqepbrzKaLx2FvIZoEcHcHjW7dvG8jwIV+xxoRBSD4ZUcawKjbeJoqDxMderfwCZwe2GO++eeE0QQRTR15jUfpTIgJ9ob9rNMUtSGSQCWxWRbqVBwBKV4F3k79z4yW4+vi0VR9TAR2B9cuN1hw6Bt4AaOYkq9O2kKsSt+it8km6mU42zhBPnnEuXdCx28BfgPw2om43lQ6ChXV1j9mQK/XSKaOiBubK6LxR58/iASK9T2NDuZe38XIokdMrANspZTbXRIFeVQPDPyueBE6eWQ7XMOMYn7F4Lhe3cPsQS0xtg8ceJ18VlEdqdsn6vs4eO7fiLCI7B/4JqfNj11wKQFotonzOea7vrMkKrY0vUeN7AwzoNeRKplVm3c2YJgtrvJphiiIyZXZ2dApxGWcJB1FpiVdTOGdYAU8qs8ppXKnhus/sUfJi8Ye93g6sOI7Rhtn7RpGB9KoCLcToa4q9aXuN1bi1cbLs9YdLSVh7zSY/G8sKb2UQyPq/3nDqzzdltIWUCIc5GGH/sgCVo1uXltS9gCOKLuxHR4HfIBCLw/ipJX4SjHMAIfnrhRGsizGVheuq8IfxXpyKjXIuSnvYapJmNLKE5z+j5ZcfnUh0ba4vzGBTCZmymjdQM3d5Ag4b1NXUdGKOqHYssVeNwQqRVtfTuLUopwRRy3unfYZveELMJc1FPRYhk60CNA/WtJcizqv/xGLP+MA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39850400004)(36840700001)(46966006)(8676002)(47076005)(70586007)(4326008)(70206006)(478600001)(36860700001)(81166007)(966005)(52536014)(7696005)(6506007)(83380400001)(107886003)(8936002)(4744005)(41300700001)(26005)(9686003)(2906002)(356005)(33656002)(5660300002)(86362001)(45080400002)(82310400005)(82740400003)(40480700001)(316002)(336012)(55016003)(186003)(110136005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 06:32:23.8548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31b730f1-54ee-41cf-a5fe-08da8f0864b6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5678 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4gMi4gYXV0b21hdGlvbjogVGVzdCBh IHB2IG5ldHdvcmsgaW50ZXJmYWNlIHVuZGVyIGRvbTBsZXNzIGVuaGFuY2VkDQo+ID4NCj4gaHR0 cHM6Ly9uYW0xMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/dXJsPWh0dHBzJTNB JTJGJTJGcGF0Yw0KPiBod29yay5rZXJuZWwub3JnJTJGcHJvamVjdCUyRnhlbi0NCj4gZGV2ZWwl MkZsaXN0JTJGJTNGc2VyaWVzJTNENjY2MTI4JmFtcDtkYXRhPTA1JTdDMDElN0NtaWNoYWwub3J6 ZWwNCj4gJTQwYW1kLmNvbSU3QzNmODNmOGVhM2IxMzQyMTE3NDBhMDhkYThlZjEwYzgyJTdDM2Rk ODk2MWZlNDg4NGU2DQo+IDA4ZTExYTgyZDk5NGUxODNkJTdDMCU3QzAlN0M2Mzc5Nzk0NjMxOTc3 Nzk3NTglN0NVbmtub3duJTdDVA0KPiBXRnBiR1pzYjNkOGV5SldJam9pTUM0d0xqQXdNREFpTENK UUlqb2lWMmx1TXpJaUxDSkJUaUk2SWsxaGFXd2lMQ0oNCj4gWFZDSTZNbjAlM0QlN0MzMDAwJTdD JTdDJTdDJmFtcDtzZGF0YT0yQjRoc1hzMTcwZ3p5RmZJSHVzaHNwNQ0KPiBSdFNSUjBPSGlRMDJv SllSeGVoOCUzRCZhbXA7cmVzZXJ2ZWQ9MA0KPiA+IFN0YXR1czogTmVlZCByZXZpZXdzLg0KPiBU aGlzIG9uZSBpcyBhbHJlYWR5IGNvbW1pdHRlZCBzbyBubyBmdXJ0aGVyIGFjdGlvbnMgYXJlIG5l Y2Vzc2FyeS4NCg0KT29wcywgc2hvdWxkIGhhdmUgZHVnIGEgbGl0dGxlIGJpdCBkZWVwZXIgaW4g dGhlIGxvZyA6UCBzb3JyeSBmb3IgdGhhdC4uLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:00:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398489.639331 (Exim 4.92) (envelope-from ) id 1oV65c-0004yT-9b; Mon, 05 Sep 2022 07:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398489.639331; Mon, 05 Sep 2022 07:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65c-0004yL-6x; Mon, 05 Sep 2022 07:00:12 +0000 Received: by outflank-mailman (input) for mailman id 398489; Mon, 05 Sep 2022 07:00:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65a-0004y1-9o for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:00:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 607261dc-2ce8-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:00:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BCF79381F6; Mon, 5 Sep 2022 07:00:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 789E9139C7; Mon, 5 Sep 2022 07:00:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +S0vHHeeFWNlZAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 07:00:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 607261dc-2ce8-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662361207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=VwnnnHFVyMh4doC8T6gN9JLyib/ggCwOKhTiZDOdBa4=; b=PzDdNUlOKecQLi51LKGUBb5sNIfG+oOQZ0KyKXwa4LAJ7XwDVt7N3w6As09oNioYhwvB6b Oulc0MzAHxGAk1FyYPBU6q0cIzrZ3AxOCevF2g64Ou1ZavDIVQdSlk4TGR2ctZSGr62glv 3FhZMUV/6UB6fhxlyXiBPv+cMz40MAc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , George Dunlap , Dario Faggioli , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 0/3] xen/sched: fix cpu hotplug Date: Mon, 5 Sep 2022 09:00:02 +0200 Message-Id: <20220905070005.16788-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A recent change in the hypervisor memory allocation framework led to crashes when unplugging host cpus. This was due to the (correct) assertion that allocating and freeing memory is allowed with enabled interrupts only. As the main cpu unplug operation is done in stop-machine context, this assertion triggers in debug builds. Correct that by pre-allocating all needed memory while interrupts are still on, and free memory after interrupts are enabled again. Changes in V4: - addressed comments Changes in V3: - addressed all comments Changes in V2: - addressed all comments Juergen Gross (3): xen/sched: introduce cpupool_update_node_affinity() xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() xen/sched: fix cpu hotplug xen/common/sched/core.c | 214 ++++++++++++++++++++++++------------- xen/common/sched/cpupool.c | 92 +++++++++++----- xen/common/sched/private.h | 21 +++- xen/include/xen/sched.h | 9 +- 4 files changed, 236 insertions(+), 100 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:00:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398492.639354 (Exim 4.92) (envelope-from ) id 1oV65d-0005M5-Lc; Mon, 05 Sep 2022 07:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398492.639354; Mon, 05 Sep 2022 07:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65d-0005JK-CR; Mon, 05 Sep 2022 07:00:13 +0000 Received: by outflank-mailman (input) for mailman id 398492; Mon, 05 Sep 2022 07:00:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65b-0004y1-RI for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:00:12 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60ce29a3-2ce8-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:00:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8D5465FA47; Mon, 5 Sep 2022 07:00:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EC7E139C7; Mon, 5 Sep 2022 07:00:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aJHvEXieFWNlZAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 07:00:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60ce29a3-2ce8-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662361208; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2H8ajQ0HI/UBXsBcjmQNLbg3xZkwAorHJLO/n1m1pk=; b=lCDIElhW05K9jsPGmmMOfov6AdxOQgnzDYOLOVIApJydT/7QsGJ+E397rcWhgYJjY+Qify Zo1HNE/ZyqVTs1qPiRQDFeRsGyWCJwlJV0SYRLin/azSVcqiAP8GwLdnmqePcj37f1Hf3v pEEl8ezUNborW2Hy2zKW49g2wSRRgXI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich Subject: [PATCH v4 3/3] xen/sched: fix cpu hotplug Date: Mon, 5 Sep 2022 09:00:05 +0200 Message-Id: <20220905070005.16788-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905070005.16788-1-jgross@suse.com> References: <20220905070005.16788-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() with interrupts disabled, thus any memory allocation or freeing must be avoided. Since commit 5047cd1d5dea ("xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()") this restriction is being enforced via an assertion, which will now fail. Fix this by allocating needed memory before entering stop_machine_run() and freeing any memory only after having finished stop_machine_run(). Fixes: 1ec410112cdd ("xen/sched: support differing granularity in schedule_cpu_[add/rm]()") Reported-by: Gao Ruifeng Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - move affinity mask allocation into schedule_cpu_rm_alloc() (Jan Beulich) --- xen/common/sched/core.c | 25 +++++++++++--- xen/common/sched/cpupool.c | 69 +++++++++++++++++++++++++++++--------- xen/common/sched/private.h | 5 +-- 3 files changed, 77 insertions(+), 22 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 588826cdbd..acdf073c3f 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3247,7 +3247,7 @@ out: * by alloc_cpu_rm_data() is modified only in case the cpu in question is * being moved from or to a cpupool. */ -struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu) +struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu, bool aff_alloc) { struct cpu_rm_data *data; const struct sched_resource *sr; @@ -3260,6 +3260,17 @@ struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu) if ( !data ) goto out; + if ( aff_alloc ) + { + if ( !alloc_affinity_masks(&data->affinity) ) + { + XFREE(data); + goto out; + } + } + else + memset(&data->affinity, 0, sizeof(data->affinity)); + data->old_ops = sr->scheduler; data->vpriv_old = idle_vcpu[cpu]->sched_unit->priv; data->ppriv_old = sr->sched_priv; @@ -3280,6 +3291,7 @@ struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu) { while ( idx > 0 ) sched_res_free(&data->sr[--idx]->rcu); + free_affinity_masks(&data->affinity); XFREE(data); goto out; } @@ -3302,6 +3314,7 @@ void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu) { sched_free_udata(mem->old_ops, mem->vpriv_old); sched_free_pdata(mem->old_ops, mem->ppriv_old, cpu); + free_affinity_masks(&mem->affinity); xfree(mem); } @@ -3312,17 +3325,18 @@ void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu) * The cpu is already marked as "free" and not valid any longer for its * cpupool. */ -int schedule_cpu_rm(unsigned int cpu) +int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *data) { struct sched_resource *sr; - struct cpu_rm_data *data; struct sched_unit *unit; spinlock_t *old_lock; unsigned long flags; int idx = 0; unsigned int cpu_iter; + bool freemem = !data; - data = alloc_cpu_rm_data(cpu); + if ( !data ) + data = alloc_cpu_rm_data(cpu, false); if ( !data ) return -ENOMEM; @@ -3390,7 +3404,8 @@ int schedule_cpu_rm(unsigned int cpu) sched_deinit_pdata(data->old_ops, data->ppriv_old, cpu); rcu_read_unlock(&sched_res_rculock); - free_cpu_rm_data(data, cpu); + if ( freemem ) + free_cpu_rm_data(data, cpu); return 0; } diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index aac3a269b7..b2c6f520c3 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -411,22 +411,28 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c) } /* Update affinities of all domains in a cpupool. */ -static void cpupool_update_node_affinity(const struct cpupool *c) +static void cpupool_update_node_affinity(const struct cpupool *c, + struct affinity_masks *masks) { - struct affinity_masks masks; + struct affinity_masks local_masks; struct domain *d; - if ( !alloc_affinity_masks(&masks) ) - return; + if ( !masks ) + { + if ( !alloc_affinity_masks(&local_masks) ) + return; + masks = &local_masks; + } rcu_read_lock(&domlist_read_lock); for_each_domain_in_cpupool(d, c) - domain_update_node_aff(d, &masks); + domain_update_node_aff(d, masks); rcu_read_unlock(&domlist_read_lock); - free_affinity_masks(&masks); + if ( masks == &local_masks ) + free_affinity_masks(masks); } /* @@ -460,15 +466,17 @@ static int cpupool_assign_cpu_locked(struct cpupool *c, unsigned int cpu) rcu_read_unlock(&sched_res_rculock); - cpupool_update_node_affinity(c); + cpupool_update_node_affinity(c, NULL); return 0; } -static int cpupool_unassign_cpu_finish(struct cpupool *c) +static int cpupool_unassign_cpu_finish(struct cpupool *c, + struct cpu_rm_data *mem) { int cpu = cpupool_moving_cpu; const cpumask_t *cpus; + struct affinity_masks *masks = mem ? &mem->affinity : NULL; int ret; if ( c != cpupool_cpu_moving ) @@ -491,7 +499,7 @@ static int cpupool_unassign_cpu_finish(struct cpupool *c) */ if ( !ret ) { - ret = schedule_cpu_rm(cpu); + ret = schedule_cpu_rm(cpu, mem); if ( ret ) cpumask_andnot(&cpupool_free_cpus, &cpupool_free_cpus, cpus); else @@ -503,7 +511,7 @@ static int cpupool_unassign_cpu_finish(struct cpupool *c) } rcu_read_unlock(&sched_res_rculock); - cpupool_update_node_affinity(c); + cpupool_update_node_affinity(c, masks); return ret; } @@ -567,7 +575,7 @@ static long cf_check cpupool_unassign_cpu_helper(void *info) cpupool_cpu_moving->cpupool_id, cpupool_moving_cpu); spin_lock(&cpupool_lock); - ret = cpupool_unassign_cpu_finish(c); + ret = cpupool_unassign_cpu_finish(c, NULL); spin_unlock(&cpupool_lock); debugtrace_printk("cpupool_unassign_cpu ret=%ld\n", ret); @@ -714,7 +722,7 @@ static int cpupool_cpu_add(unsigned int cpu) * This function is called in stop_machine context, so we can be sure no * non-idle vcpu is active on the system. */ -static void cpupool_cpu_remove(unsigned int cpu) +static void cpupool_cpu_remove(unsigned int cpu, struct cpu_rm_data *mem) { int ret; @@ -722,7 +730,7 @@ static void cpupool_cpu_remove(unsigned int cpu) if ( !cpumask_test_cpu(cpu, &cpupool_free_cpus) ) { - ret = cpupool_unassign_cpu_finish(cpupool0); + ret = cpupool_unassign_cpu_finish(cpupool0, mem); BUG_ON(ret); } cpumask_clear_cpu(cpu, &cpupool_free_cpus); @@ -788,7 +796,7 @@ static void cpupool_cpu_remove_forced(unsigned int cpu) { ret = cpupool_unassign_cpu_start(c, master_cpu); BUG_ON(ret); - ret = cpupool_unassign_cpu_finish(c); + ret = cpupool_unassign_cpu_finish(c, NULL); BUG_ON(ret); } } @@ -1006,12 +1014,24 @@ void cf_check dump_runq(unsigned char key) static int cf_check cpu_callback( struct notifier_block *nfb, unsigned long action, void *hcpu) { + static struct cpu_rm_data *mem; + unsigned int cpu = (unsigned long)hcpu; int rc = 0; switch ( action ) { case CPU_DOWN_FAILED: + if ( system_state <= SYS_STATE_active ) + { + if ( mem ) + { + free_cpu_rm_data(mem, cpu); + mem = NULL; + } + rc = cpupool_cpu_add(cpu); + } + break; case CPU_ONLINE: if ( system_state <= SYS_STATE_active ) rc = cpupool_cpu_add(cpu); @@ -1019,12 +1039,31 @@ static int cf_check cpu_callback( case CPU_DOWN_PREPARE: /* Suspend/Resume don't change assignments of cpus to cpupools. */ if ( system_state <= SYS_STATE_active ) + { rc = cpupool_cpu_remove_prologue(cpu); + if ( !rc ) + { + ASSERT(!mem); + mem = alloc_cpu_rm_data(cpu, true); + rc = mem ? 0 : -ENOMEM; + } + } break; case CPU_DYING: /* Suspend/Resume don't change assignments of cpus to cpupools. */ if ( system_state <= SYS_STATE_active ) - cpupool_cpu_remove(cpu); + { + ASSERT(mem); + cpupool_cpu_remove(cpu, mem); + } + break; + case CPU_DEAD: + if ( system_state <= SYS_STATE_active ) + { + ASSERT(mem); + free_cpu_rm_data(mem, cpu); + mem = NULL; + } break; case CPU_RESUME_FAILED: cpupool_cpu_remove_forced(cpu); diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index e286849a13..0126a4bb9e 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -603,6 +603,7 @@ void free_affinity_masks(struct affinity_masks *affinity); /* Memory allocation related data for schedule_cpu_rm(). */ struct cpu_rm_data { + struct affinity_masks affinity; const struct scheduler *old_ops; void *ppriv_old; void *vpriv_old; @@ -617,9 +618,9 @@ struct scheduler *scheduler_alloc(unsigned int sched_id); void scheduler_free(struct scheduler *sched); int cpu_disable_scheduler(unsigned int cpu); int schedule_cpu_add(unsigned int cpu, struct cpupool *c); -struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu); +struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu, bool aff_alloc); void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu); -int schedule_cpu_rm(unsigned int cpu); +int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *mem); int sched_move_domain(struct domain *d, struct cpupool *c); struct cpupool *cpupool_get_by_id(unsigned int poolid); void cpupool_put(struct cpupool *pool); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:00:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398491.639347 (Exim 4.92) (envelope-from ) id 1oV65d-00059v-4O; Mon, 05 Sep 2022 07:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398491.639347; Mon, 05 Sep 2022 07:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65c-00058x-RI; Mon, 05 Sep 2022 07:00:12 +0000 Received: by outflank-mailman (input) for mailman id 398491; Mon, 05 Sep 2022 07:00:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65a-0004y1-R9 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:00:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6081d192-2ce8-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:00:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 148BC385D1; Mon, 5 Sep 2022 07:00:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C4225139C7; Mon, 5 Sep 2022 07:00:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WKefLneeFWNlZAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 07:00:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6081d192-2ce8-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662361208; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PcIcHlXy1U4J1S/sT61vK8cPPB3NmDByuTHbbmO7RMI=; b=Ef8liysk5Otlq0hfvLRZL7AjQ/kygkaLeqxNhX1yHMU0RUgDLikfndEVHkCCllQhLxvO++ rjuqsHqsQ55gXYu+sgr9zSUNXMSNWxoFr0Rhkc7EBfYx4gROigSpECsP6h8K84WQ5vj/Lr NSBfFLvIshtbYB5FFxE/Tcpmfzr754I= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , George Dunlap , Dario Faggioli , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 1/3] xen/sched: introduce cpupool_update_node_affinity() Date: Mon, 5 Sep 2022 09:00:03 +0200 Message-Id: <20220905070005.16788-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905070005.16788-1-jgross@suse.com> References: <20220905070005.16788-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For updating the node affinities of all domains in a cpupool add a new function cpupool_update_node_affinity(). In order to avoid multiple allocations of cpumasks carve out memory allocation and freeing from domain_update_node_affinity() into new helpers, which can be used by cpupool_update_node_affinity(). Modify domain_update_node_affinity() to take an additional parameter for passing the allocated memory in and to allocate and free the memory via the new helpers in case NULL was passed. This will help later to pre-allocate the cpumasks in order to avoid allocations in stop-machine context. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - move helpers to core.c (Jan Beulich) - allocate/free memory in domain_update_node_aff() if NULL was passed in (Jan Beulich) V3: - remove pointless initializer (Jan Beulich) V4: - rename alloc/free helpers (Andrew Cooper) --- xen/common/sched/core.c | 54 ++++++++++++++++++++++++++------------ xen/common/sched/cpupool.c | 39 +++++++++++++++------------ xen/common/sched/private.h | 7 +++++ xen/include/xen/sched.h | 9 ++++++- 4 files changed, 74 insertions(+), 35 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index ff1ddc7624..5f1a265889 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1824,9 +1824,28 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, return ret; } -void domain_update_node_affinity(struct domain *d) +bool alloc_affinity_masks(struct affinity_masks *affinity) { - cpumask_var_t dom_cpumask, dom_cpumask_soft; + if ( !alloc_cpumask_var(&affinity->hard) ) + return false; + if ( !alloc_cpumask_var(&affinity->soft) ) + { + free_cpumask_var(affinity->hard); + return false; + } + + return true; +} + +void free_affinity_masks(struct affinity_masks *affinity) +{ + free_cpumask_var(affinity->soft); + free_cpumask_var(affinity->hard); +} + +void domain_update_node_aff(struct domain *d, struct affinity_masks *affinity) +{ + struct affinity_masks masks; cpumask_t *dom_affinity; const cpumask_t *online; struct sched_unit *unit; @@ -1836,14 +1855,16 @@ void domain_update_node_affinity(struct domain *d) if ( !d->vcpu || !d->vcpu[0] ) return; - if ( !zalloc_cpumask_var(&dom_cpumask) ) - return; - if ( !zalloc_cpumask_var(&dom_cpumask_soft) ) + if ( !affinity ) { - free_cpumask_var(dom_cpumask); - return; + affinity = &masks; + if ( !alloc_affinity_masks(affinity) ) + return; } + cpumask_clear(affinity->hard); + cpumask_clear(affinity->soft); + online = cpupool_domain_master_cpumask(d); spin_lock(&d->node_affinity_lock); @@ -1864,22 +1885,21 @@ void domain_update_node_affinity(struct domain *d) */ for_each_sched_unit ( d, unit ) { - cpumask_or(dom_cpumask, dom_cpumask, unit->cpu_hard_affinity); - cpumask_or(dom_cpumask_soft, dom_cpumask_soft, - unit->cpu_soft_affinity); + cpumask_or(affinity->hard, affinity->hard, unit->cpu_hard_affinity); + cpumask_or(affinity->soft, affinity->soft, unit->cpu_soft_affinity); } /* Filter out non-online cpus */ - cpumask_and(dom_cpumask, dom_cpumask, online); - ASSERT(!cpumask_empty(dom_cpumask)); + cpumask_and(affinity->hard, affinity->hard, online); + ASSERT(!cpumask_empty(affinity->hard)); /* And compute the intersection between hard, online and soft */ - cpumask_and(dom_cpumask_soft, dom_cpumask_soft, dom_cpumask); + cpumask_and(affinity->soft, affinity->soft, affinity->hard); /* * If not empty, the intersection of hard, soft and online is the * narrowest set we want. If empty, we fall back to hard&online. */ - dom_affinity = cpumask_empty(dom_cpumask_soft) ? - dom_cpumask : dom_cpumask_soft; + dom_affinity = cpumask_empty(affinity->soft) ? affinity->hard + : affinity->soft; nodes_clear(d->node_affinity); for_each_cpu ( cpu, dom_affinity ) @@ -1888,8 +1908,8 @@ void domain_update_node_affinity(struct domain *d) spin_unlock(&d->node_affinity_lock); - free_cpumask_var(dom_cpumask_soft); - free_cpumask_var(dom_cpumask); + if ( affinity == &masks ) + free_affinity_masks(affinity); } typedef long ret_t; diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 2afe54f54d..aac3a269b7 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -410,6 +410,25 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c) return ret; } +/* Update affinities of all domains in a cpupool. */ +static void cpupool_update_node_affinity(const struct cpupool *c) +{ + struct affinity_masks masks; + struct domain *d; + + if ( !alloc_affinity_masks(&masks) ) + return; + + rcu_read_lock(&domlist_read_lock); + + for_each_domain_in_cpupool(d, c) + domain_update_node_aff(d, &masks); + + rcu_read_unlock(&domlist_read_lock); + + free_affinity_masks(&masks); +} + /* * assign a specific cpu to a cpupool * cpupool_lock must be held @@ -417,7 +436,6 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c) static int cpupool_assign_cpu_locked(struct cpupool *c, unsigned int cpu) { int ret; - struct domain *d; const cpumask_t *cpus; cpus = sched_get_opt_cpumask(c->gran, cpu); @@ -442,12 +460,7 @@ static int cpupool_assign_cpu_locked(struct cpupool *c, unsigned int cpu) rcu_read_unlock(&sched_res_rculock); - rcu_read_lock(&domlist_read_lock); - for_each_domain_in_cpupool(d, c) - { - domain_update_node_affinity(d); - } - rcu_read_unlock(&domlist_read_lock); + cpupool_update_node_affinity(c); return 0; } @@ -456,18 +469,14 @@ static int cpupool_unassign_cpu_finish(struct cpupool *c) { int cpu = cpupool_moving_cpu; const cpumask_t *cpus; - struct domain *d; int ret; if ( c != cpupool_cpu_moving ) return -EADDRNOTAVAIL; - /* - * We need this for scanning the domain list, both in - * cpu_disable_scheduler(), and at the bottom of this function. - */ rcu_read_lock(&domlist_read_lock); ret = cpu_disable_scheduler(cpu); + rcu_read_unlock(&domlist_read_lock); rcu_read_lock(&sched_res_rculock); cpus = get_sched_res(cpu)->cpus; @@ -494,11 +503,7 @@ static int cpupool_unassign_cpu_finish(struct cpupool *c) } rcu_read_unlock(&sched_res_rculock); - for_each_domain_in_cpupool(d, c) - { - domain_update_node_affinity(d); - } - rcu_read_unlock(&domlist_read_lock); + cpupool_update_node_affinity(c); return ret; } diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index a870320146..2b04b01a0c 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -593,6 +593,13 @@ affinity_balance_cpumask(const struct sched_unit *unit, int step, cpumask_copy(mask, unit->cpu_hard_affinity); } +struct affinity_masks { + cpumask_var_t hard; + cpumask_var_t soft; +}; + +bool alloc_affinity_masks(struct affinity_masks *affinity); +void free_affinity_masks(struct affinity_masks *affinity); void sched_rm_cpu(unsigned int cpu); const cpumask_t *sched_get_opt_cpumask(enum sched_gran opt, unsigned int cpu); void schedule_dump(struct cpupool *c); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 1cf629e7ec..81f1fcba2a 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -666,8 +666,15 @@ static inline void get_knownalive_domain(struct domain *d) ASSERT(!(atomic_read(&d->refcnt) & DOMAIN_DESTROYED)); } +struct affinity_masks; + int domain_set_node_affinity(struct domain *d, const nodemask_t *affinity); -void domain_update_node_affinity(struct domain *d); +void domain_update_node_aff(struct domain *d, struct affinity_masks *affinity); + +static inline void domain_update_node_affinity(struct domain *d) +{ + domain_update_node_aff(d, NULL); +} /* * To be implemented by each architecture, sanity checking the configuration -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:00:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:00:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398490.639336 (Exim 4.92) (envelope-from ) id 1oV65c-00052S-LV; Mon, 05 Sep 2022 07:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398490.639336; Mon, 05 Sep 2022 07:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65c-00050x-G0; Mon, 05 Sep 2022 07:00:12 +0000 Received: by outflank-mailman (input) for mailman id 398490; Mon, 05 Sep 2022 07:00:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV65a-0004y0-LR for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:00:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60a6a986-2ce8-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 09:00:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 479FA385AF; Mon, 5 Sep 2022 07:00:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C48A139C7; Mon, 5 Sep 2022 07:00:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UGeYBXieFWNlZAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 07:00:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60a6a986-2ce8-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662361208; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KRjMVm9WMpGjwgu7kxWkc6BMWjYWXuyMzdLcjTHzkko=; b=PqGscHGVAJCBn5s/ioJGti4iNxBfglC9aE9lEb98YD20oqfVSWIdPscBS659MfXGjrV2CV ToH9QcEm6CdpWzKzBQxWlsfw6YPlwJKfGScXRam6HedU1KJTgjwc7kDxaMyHN686d38MJG oWlKv0bYA0VIxRmgp/0xzNfWUfiM7Eg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , George Dunlap , Dario Faggioli Subject: [PATCH v4 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() Date: Mon, 5 Sep 2022 09:00:04 +0200 Message-Id: <20220905070005.16788-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905070005.16788-1-jgross@suse.com> References: <20220905070005.16788-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare not allocating or freeing memory from schedule_cpu_rm(), move this functionality to dedicated functions. For now call those functions from schedule_cpu_rm(). No change of behavior expected. Signed-off-by: Juergen Gross --- V2: - add const (Jan Beulich) - use "unsigned int" for loop index (Jan Beulich) - use xmalloc_flex_struct() (Jan Beulich) - use XFREE() (Jan Beulich) - hold rcu lock longer (Jan Beulich) - add ASSERT() (Jan Beulich) V3: - added comment for schedule_cpu_rm_alloc() (Jan Beulich) V4: - rename alloc/free helpers and make them public (Andrew Cooper) - rephrase comment (Andrew Cooper) --- xen/common/sched/core.c | 143 ++++++++++++++++++++++--------------- xen/common/sched/private.h | 11 +++ 2 files changed, 98 insertions(+), 56 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 5f1a265889..588826cdbd 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3237,6 +3237,75 @@ out: return ret; } +/* + * Allocate all memory needed for free_cpu_rm_data(), as allocations cannot + * be made in stop_machine() context. + * + * Between alloc_cpu_rm_data() and the real cpu removal action the relevant + * contents of struct sched_resource can't change, as the cpu in question is + * locked against any other movement to or from cpupools, and the data copied + * by alloc_cpu_rm_data() is modified only in case the cpu in question is + * being moved from or to a cpupool. + */ +struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu) +{ + struct cpu_rm_data *data; + const struct sched_resource *sr; + unsigned int idx; + + rcu_read_lock(&sched_res_rculock); + + sr = get_sched_res(cpu); + data = xmalloc_flex_struct(struct cpu_rm_data, sr, sr->granularity - 1); + if ( !data ) + goto out; + + data->old_ops = sr->scheduler; + data->vpriv_old = idle_vcpu[cpu]->sched_unit->priv; + data->ppriv_old = sr->sched_priv; + + for ( idx = 0; idx < sr->granularity - 1; idx++ ) + { + data->sr[idx] = sched_alloc_res(); + if ( data->sr[idx] ) + { + data->sr[idx]->sched_unit_idle = sched_alloc_unit_mem(); + if ( !data->sr[idx]->sched_unit_idle ) + { + sched_res_free(&data->sr[idx]->rcu); + data->sr[idx] = NULL; + } + } + if ( !data->sr[idx] ) + { + while ( idx > 0 ) + sched_res_free(&data->sr[--idx]->rcu); + XFREE(data); + goto out; + } + + data->sr[idx]->curr = data->sr[idx]->sched_unit_idle; + data->sr[idx]->scheduler = &sched_idle_ops; + data->sr[idx]->granularity = 1; + + /* We want the lock not to change when replacing the resource. */ + data->sr[idx]->schedule_lock = sr->schedule_lock; + } + + out: + rcu_read_unlock(&sched_res_rculock); + + return data; +} + +void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu) +{ + sched_free_udata(mem->old_ops, mem->vpriv_old); + sched_free_pdata(mem->old_ops, mem->ppriv_old, cpu); + + xfree(mem); +} + /* * Remove a pCPU from its cpupool. Its scheduler becomes &sched_idle_ops * (the idle scheduler). @@ -3245,53 +3314,23 @@ out: */ int schedule_cpu_rm(unsigned int cpu) { - void *ppriv_old, *vpriv_old; - struct sched_resource *sr, **sr_new = NULL; + struct sched_resource *sr; + struct cpu_rm_data *data; struct sched_unit *unit; - struct scheduler *old_ops; spinlock_t *old_lock; unsigned long flags; - int idx, ret = -ENOMEM; + int idx = 0; unsigned int cpu_iter; + data = alloc_cpu_rm_data(cpu); + if ( !data ) + return -ENOMEM; + rcu_read_lock(&sched_res_rculock); sr = get_sched_res(cpu); - old_ops = sr->scheduler; - - if ( sr->granularity > 1 ) - { - sr_new = xmalloc_array(struct sched_resource *, sr->granularity - 1); - if ( !sr_new ) - goto out; - for ( idx = 0; idx < sr->granularity - 1; idx++ ) - { - sr_new[idx] = sched_alloc_res(); - if ( sr_new[idx] ) - { - sr_new[idx]->sched_unit_idle = sched_alloc_unit_mem(); - if ( !sr_new[idx]->sched_unit_idle ) - { - sched_res_free(&sr_new[idx]->rcu); - sr_new[idx] = NULL; - } - } - if ( !sr_new[idx] ) - { - for ( idx--; idx >= 0; idx-- ) - sched_res_free(&sr_new[idx]->rcu); - goto out; - } - sr_new[idx]->curr = sr_new[idx]->sched_unit_idle; - sr_new[idx]->scheduler = &sched_idle_ops; - sr_new[idx]->granularity = 1; - /* We want the lock not to change when replacing the resource. */ - sr_new[idx]->schedule_lock = sr->schedule_lock; - } - } - - ret = 0; + ASSERT(sr->granularity); ASSERT(sr->cpupool != NULL); ASSERT(cpumask_test_cpu(cpu, &cpupool_free_cpus)); ASSERT(!cpumask_test_cpu(cpu, sr->cpupool->cpu_valid)); @@ -3299,10 +3338,6 @@ int schedule_cpu_rm(unsigned int cpu) /* See comment in schedule_cpu_add() regarding lock switching. */ old_lock = pcpu_schedule_lock_irqsave(cpu, &flags); - vpriv_old = idle_vcpu[cpu]->sched_unit->priv; - ppriv_old = sr->sched_priv; - - idx = 0; for_each_cpu ( cpu_iter, sr->cpus ) { per_cpu(sched_res_idx, cpu_iter) = 0; @@ -3316,27 +3351,27 @@ int schedule_cpu_rm(unsigned int cpu) else { /* Initialize unit. */ - unit = sr_new[idx]->sched_unit_idle; - unit->res = sr_new[idx]; + unit = data->sr[idx]->sched_unit_idle; + unit->res = data->sr[idx]; unit->is_running = true; sched_unit_add_vcpu(unit, idle_vcpu[cpu_iter]); sched_domain_insert_unit(unit, idle_vcpu[cpu_iter]->domain); /* Adjust cpu masks of resources (old and new). */ cpumask_clear_cpu(cpu_iter, sr->cpus); - cpumask_set_cpu(cpu_iter, sr_new[idx]->cpus); + cpumask_set_cpu(cpu_iter, data->sr[idx]->cpus); cpumask_set_cpu(cpu_iter, &sched_res_mask); /* Init timer. */ - init_timer(&sr_new[idx]->s_timer, s_timer_fn, NULL, cpu_iter); + init_timer(&data->sr[idx]->s_timer, s_timer_fn, NULL, cpu_iter); /* Last resource initializations and insert resource pointer. */ - sr_new[idx]->master_cpu = cpu_iter; - set_sched_res(cpu_iter, sr_new[idx]); + data->sr[idx]->master_cpu = cpu_iter; + set_sched_res(cpu_iter, data->sr[idx]); /* Last action: set the new lock pointer. */ smp_mb(); - sr_new[idx]->schedule_lock = &sched_free_cpu_lock; + data->sr[idx]->schedule_lock = &sched_free_cpu_lock; idx++; } @@ -3352,16 +3387,12 @@ int schedule_cpu_rm(unsigned int cpu) /* _Not_ pcpu_schedule_unlock(): schedule_lock may have changed! */ spin_unlock_irqrestore(old_lock, flags); - sched_deinit_pdata(old_ops, ppriv_old, cpu); - - sched_free_udata(old_ops, vpriv_old); - sched_free_pdata(old_ops, ppriv_old, cpu); + sched_deinit_pdata(data->old_ops, data->ppriv_old, cpu); -out: rcu_read_unlock(&sched_res_rculock); - xfree(sr_new); + free_cpu_rm_data(data, cpu); - return ret; + return 0; } struct scheduler *scheduler_get_default(void) diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index 2b04b01a0c..e286849a13 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -600,6 +600,15 @@ struct affinity_masks { bool alloc_affinity_masks(struct affinity_masks *affinity); void free_affinity_masks(struct affinity_masks *affinity); + +/* Memory allocation related data for schedule_cpu_rm(). */ +struct cpu_rm_data { + const struct scheduler *old_ops; + void *ppriv_old; + void *vpriv_old; + struct sched_resource *sr[]; +}; + void sched_rm_cpu(unsigned int cpu); const cpumask_t *sched_get_opt_cpumask(enum sched_gran opt, unsigned int cpu); void schedule_dump(struct cpupool *c); @@ -608,6 +617,8 @@ struct scheduler *scheduler_alloc(unsigned int sched_id); void scheduler_free(struct scheduler *sched); int cpu_disable_scheduler(unsigned int cpu); int schedule_cpu_add(unsigned int cpu, struct cpupool *c); +struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu); +void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu); int schedule_cpu_rm(unsigned int cpu); int sched_move_domain(struct domain *d, struct cpupool *c); struct cpupool *cpupool_get_by_id(unsigned int poolid); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:09:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:09:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398518.639375 (Exim 4.92) (envelope-from ) id 1oV6EC-0007WL-DR; Mon, 05 Sep 2022 07:09:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398518.639375; Mon, 05 Sep 2022 07:09:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6EC-0007WE-AG; Mon, 05 Sep 2022 07:09:04 +0000 Received: by outflank-mailman (input) for mailman id 398518; Mon, 05 Sep 2022 07:09:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6EA-0007Vn-TR for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:09:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d7b03ac-2ce9-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:09:00 +0200 (CEST) Received: from AS8PR04CA0207.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::32) by AM7PR08MB5301.eurprd08.prod.outlook.com (2603:10a6:20b:dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 07:08:58 +0000 Received: from AM7EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::9a) by AS8PR04CA0207.outlook.office365.com (2603:10a6:20b:2f3::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 07:08:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT010.mail.protection.outlook.com (100.127.141.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 07:08:58 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Mon, 05 Sep 2022 07:08:57 +0000 Received: from 76ef96ecfdb3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2B063553-31F6-4B55-BDC4-553C92EEE242.1; Mon, 05 Sep 2022 07:08:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 76ef96ecfdb3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 07:08:47 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by DB3PR08MB8985.eurprd08.prod.outlook.com (2603:10a6:10:43f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Mon, 5 Sep 2022 07:08:45 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20%7]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 07:08:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d7b03ac-2ce9-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=afvDgb6RuGwykpHzY0NTwO2rLsZU4YPbbMb4ze3imRXYc6imd0KJtFp0cENMXneEZJy1O+TWWkdqzyO1yYZ7+65F7i9DWXVW92T7p/gLDSbz0es22lsr/Iijt76wS+eMghsp+sX5xV8mcqhrMXgPsJsa6Wu9ZKLkWNno3UXWKkk6WPV/tDDnxLrVvAUEafDnqy4wOyEDmXG+6pkyQU//BDPuYJCAbz1OVWl7ocmsByWwE0LyIqcqnPWwAhBG6dp38OLFYVGEIUvjfObY7oktYXaRtCFKQ3dj9BP6X7E/7btZrw+cYpVZqjxsS/vcdB31xxJLoiqXuKgsDl3SAyuwPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=81EhxXJ+tLHvtuckNf5+P5UUedJHfF0Tr48WNZ+OcjM=; b=hw7QXHp0TVNuxawpetCkN4Mh63nEbkN7ZfkN+7yKwMm+h00SYf6YFt1dc2clRZpDHMzIoABtQEDBmzTL86GUVpLaQ0AoA7ZrcDKxPprHIr2WJVNEBRqu8BhyehJGgJ4dWALgcxRL8Cu/4lcGiOZI/7gQXaWG2c6QYSKrLlp6Cnsv6Y+2UyibCRsjYx+fn80dG4K4rTYntnE7DkbKmwzX3ZgigH5WcWxZB88MA3Vb5dQrK3jfQpnBPT/fuJwLtSpetIE/NZtFGqhyNDL1Hp+TCxxPl4x184Ur/sBfWxUUTRnHX4w0m2uJBgDgCQ34KZfcqK8/Rf9AXwFveXNGX4qaWQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81EhxXJ+tLHvtuckNf5+P5UUedJHfF0Tr48WNZ+OcjM=; b=n/8tacabaqZsylb6u11SYmRSstcJHmUc+PxCYthzDCFQYQE3rGTfBJkIj/pGLiuzP4keo7LNTR0xc1K7fu2cZlwJjeu7PihaYF2meLIQye+BptygVnH3pkqsErTT79z24qnUEXrq+xOCYxQfk9ioQkahZiIw/etyY+OvJeZ+VDk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=du/jDcKlJjOcXFu1hZHFw9c9qGpvEEPrQcgjQItliHsIgjIljGvP0rvGBP/TQislTVkl7r8J4uluYXlbegz9ruW55spTwqcNBRCfxPPS2SbLE8Lc3uc0OEujfY4mywKO2+aw9dO4C5XTkXh8eN6jjcENxgYYgVrHSjTBBL7RfgKuReI8M0/j1Z60jvFavCvEMhT/qCi3MHw32QEBPrQUio/j2CndxMzzuRu5VA6XWvjBRVUTlT4XQCsPhk0WF7JTydkOHiSP2stFfX2IuSl2bfYzUsf776P1syNLphz9jOt5TauX+VgPMmXkpxQUpINZ9ohfcwBd0JV5HMMGFUSCYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=81EhxXJ+tLHvtuckNf5+P5UUedJHfF0Tr48WNZ+OcjM=; b=MylNE34wSFtbNnG4cIZaldN9EcKiGEn2gSm5Ca7OZ3NN6YnUDunzgeW6c2Ef8SmsYJ53h2e7iMUM16l0BacFldYjSdOoFoLzcbgA/1Ak7Clsq99co0ulgWX7hktOtRX1hq1oQJ6XvMU2Vyc/xi8q278PI4HxCFlku3HyDk/UBi2GgsbT8R7R/m45TlFJun+1U1VjlJWT8dBl8k7weFl9qjh+Ug0cF9KPvhqRtMY+1sw9rL4Q6C1TRVzjJexW2nfaWjKTTliPM+JqCSInJ145wjkPydU8jhwNoXneyUhjxFRHuaKM+NYiC/neRwJ9AKX96bb1ghlLgw710Fnr+bjGJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81EhxXJ+tLHvtuckNf5+P5UUedJHfF0Tr48WNZ+OcjM=; b=n/8tacabaqZsylb6u11SYmRSstcJHmUc+PxCYthzDCFQYQE3rGTfBJkIj/pGLiuzP4keo7LNTR0xc1K7fu2cZlwJjeu7PihaYF2meLIQye+BptygVnH3pkqsErTT79z24qnUEXrq+xOCYxQfk9ioQkahZiIw/etyY+OvJeZ+VDk= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYsRk4bhBJQxIp9UysK0xEJzOLuK2y32KAgB2pAvA= Date: Mon, 5 Sep 2022 07:08:45 +0000 Message-ID: References: <20220816023658.3551936-1-Penny.Zheng@arm.com> <20220816023658.3551936-9-Penny.Zheng@arm.com> <691b68f0-db68-b400-5473-558583f8dbc1@suse.com> In-Reply-To: <691b68f0-db68-b400-5473-558583f8dbc1@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F44CA4A3385D094EBFCE5DEC597B9CB2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9081c912-4578-4d0b-08bf-08da8f0d80a4 x-ms-traffictypediagnostic: DB3PR08MB8985:EE_|AM7EUR03FT010:EE_|AM7PR08MB5301:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NodsnuQBnjCbOyY2yPZL4KCaOo5quDWVlIWKzx68mkbMmcHgryLvNPQ6hf0PaMpdNMLy5l0oyciPTcTX0sH21sVoa9OvR0WOR0iPrlQ2ylS3jYCWXS/3s8weZErRdhiY0lubveTog0sLTE9eqLsg46jM/A+pyv2DqVDAhk/QDQ8oOePdV6zqvK4yTGr2oC3OmnLUJfubBWYvzj6LEPOvoY+ONG8IfO0MKtlFJ7TejYyZ8WX1zlb/2jbBNzBs9LRx/+AV3mhyWuJjZEZvW9G17xejJg8b0rj6/mZg/MvcgX2vWkStBIMpmF5E+Pz6uLYV22N9Q4T6NMpG74nvQldwDb+SKYLkRn/8Tq09bgjsOFg6HBNfMVCEs6ox/SaEhIppS5VAq9uar06kl4tKTWXXZ/1ubwKio/RizaixDTuZXe3Na9b5M5NsAFvqQ4qQs/UAiAPYAiOemqwiViKQAkSsMqPUwCWwxKimuPNEYbPnaL6xJgkMSao5aKqCkPW5BTOkWoM7Y9sdKbPvoQ2447KZ0k4wg2CzuCNtzwf5uMEbjh+UJj10i/3BLy4KSeFzclfthC9RCmz4i7eU5d650twqa5H8zIdrZBFS0hX7uasNt0mEy4lb4aWYgCX4t3W5R5LCtXLvtetMd9RUL+0+htwh0RJxgFq1Uti4zdNNrIYN2LL3jflHP5piWkDAvnZnqOS4q0Ea8h9cukIhNPYapoUhMykGXHrDs6nOp259y6AqSp7qJ7NWU6Q7trpWdKDbfeDgGQL0Ejj9S1kJJx+xbe3NGQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(366004)(39850400004)(376002)(136003)(6916009)(54906003)(9686003)(83380400001)(71200400001)(41300700001)(55016003)(186003)(478600001)(6506007)(26005)(7696005)(53546011)(86362001)(38070700005)(66946007)(66556008)(66476007)(66446008)(64756008)(33656002)(38100700002)(4326008)(8676002)(76116006)(5660300002)(2906002)(52536014)(316002)(122000001)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8985 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4e5b792-d673-4dbf-a5f6-08da8f0d792d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ryc14i1TfFTsX32xopMBKBcPPKXgxUovkLPYZsaLa/4EcxUVORTjQRrO+lKbJ5UKO0f1iGh5mntdrS468ff2+E/am58+o3TK+u2TBdpH/obSxhBNYNhYDrcn+r47JQyMtUjkciBadL8BNMuykwpsquPI/ygWzQjOUtG1WA2RuTfHH4SziGnXVq+pF1xVj5wKQvPy+mF21DiA0L7n0UZsfxH1BgxLyXjZfhfF6hPu6Tbrf+qHx6WIF3hjMCKMnL5iVcT95ttialQle2JrZQxXHC/li5PhXOVFa/l52lgdGjW8cZcl06bJ0if1GcG6vdG6/cq0T9gOoNsWqf8qjMKV0KUIpcEXrVpmCGhYaiGvZkcMXq053dZUP9pdYxzvyuFkWOZu/SZzV1eKPQqGZpYLtzgdVQ9KxlIAE73lwxBUp81DQWf4XmgdiOhbJ8AEfkBNr7hZgclpnRCiWFkn1Bccudnybzr1nTSBomnEhCgMI8Dt2OwRAO/xWB1TRlnaIuS6uGPvqU2cJY5i7C9+gz26jqF2JCtZLaCQw3nWfp5XCpKlwPIdp0PEkk7Zn2bPxlmNJjByyzlUuWquWDC+OMj76bvu53AA/bd11duBLICNKtz5FACUH6RfSVa+X2OI3UUI5nl8OrPcaWgO0IOx3tOlWp3G0ekAUJ1k0pXsnMgwO5A8eeWeD5JKE1jZGP4DPLqargSBfEVuUhwvBnkP3jp5cpF2t/Mz3aM7dTSEoECeZC23NsgfOxfuPgw6ykKIYUX6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39850400004)(46966006)(36840700001)(81166007)(356005)(36860700001)(82740400003)(83380400001)(4326008)(8676002)(70586007)(82310400005)(316002)(54906003)(70206006)(55016003)(2906002)(9686003)(8936002)(40480700001)(6862004)(53546011)(6506007)(47076005)(5660300002)(336012)(186003)(52536014)(41300700001)(7696005)(478600001)(86362001)(26005)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 07:08:58.1302 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9081c912-4578-4d0b-08bf-08da8f0d80a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5301 SGkgamFuIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogV2VkbmVzZGF5LCBBdWd1c3QgMTcsIDIw MjIgNjowNSBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+IENj OiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5j b20+Ow0KPiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5p IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsNCj4gV2VpIExpdSA8d2xAeGVuLm9yZz47IHhlbi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxMCA4Lzld IHhlbjogcmV0cmlldmUgcmVzZXJ2ZWQgcGFnZXMgb24NCj4gcG9wdWxhdGVfcGh5c21hcA0KPiAN Cj4gT24gMTYuMDguMjAyMiAwNDozNiwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gQEAgLTI4Njcs NiArMjg1NCw2MSBAQCBpbnQgX19pbml0IGFjcXVpcmVfZG9tc3RhdGljX3BhZ2VzKHN0cnVjdA0K PiA+IGRvbWFpbiAqZCwgbWZuX3Qgc21mbiwNCj4gPg0KPiA+ICAgICAgcmV0dXJuIDA7DQo+ID4g IH0NCj4gPiArDQo+ID4gKy8qDQo+ID4gKyAqIEFjcXVpcmUgbnJfbWZucyBjb250aWd1b3VzIHBh Z2VzLCBzdGFydGluZyBhdCAjc21mbiwgb2Ygc3RhdGljDQo+ID4gK21lbW9yeSwNCj4gPiArICog dGhlbiBhc3NpZ24gdGhlbSB0byBvbmUgc3BlY2lmaWMgZG9tYWluICNkLg0KPiA+ICsgKi8NCj4g PiAraW50IF9faW5pdCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBt Zm5fdCBzbWZuLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGludCBucl9tZm5zLCB1bnNpZ25lZCBpbnQNCj4gPiArbWVtZmxhZ3MpIHsNCj4gPiArICAg IHN0cnVjdCBwYWdlX2luZm8gKnBnOw0KPiA+ICsNCj4gPiArICAgIEFTU0VSVF9BTExPQ19DT05U RVhUKCk7DQo+ID4gKw0KPiA+ICsgICAgcGcgPSBhY3F1aXJlX3N0YXRpY21lbV9wYWdlcyhzbWZu LCBucl9tZm5zLCBtZW1mbGFncyk7DQo+ID4gKyAgICBpZiAoICFwZyApDQo+ID4gKyAgICAgICAg cmV0dXJuIC1FTk9FTlQ7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCBhc3NpZ25fZG9tc3RhdGljX3Bh Z2VzKGQsIHBnLCBucl9tZm5zLCBtZW1mbGFncykgKQ0KPiA+ICsgICAgICAgIHJldHVybiAtRUlO VkFMOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICsvKg0K PiA+ICsgKiBBY3F1aXJlIGEgcGFnZSBmcm9tIHJlc2VydmVkIHBhZ2UgbGlzdChyZXN2X3BhZ2Vf bGlzdCksIHdoZW4NCj4gPiArcG9wdWxhdGluZw0KPiA+ICsgKiBtZW1vcnkgZm9yIHN0YXRpYyBk b21haW4gb24gcnVudGltZS4NCj4gPiArICovDQo+ID4gK21mbl90IGFjcXVpcmVfcmVzZXJ2ZWRf cGFnZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbWVtZmxhZ3MpDQo+ID4gK3sNCj4g PiArICAgIHN0cnVjdCBwYWdlX2luZm8gKnBhZ2U7DQo+ID4gKw0KPiA+ICsgICAgQVNTRVJUX0FM TE9DX0NPTlRFWFQoKTsNCj4gPiArDQo+ID4gKyAgICAvKiBBY3F1aXJlIGEgcGFnZSBmcm9tIHJl c2VydmVkIHBhZ2UgbGlzdChyZXN2X3BhZ2VfbGlzdCkuICovDQo+ID4gKyAgICBzcGluX2xvY2so JmQtPnBhZ2VfYWxsb2NfbG9jayk7DQo+ID4gKyAgICBwYWdlID0gcGFnZV9saXN0X3JlbW92ZV9o ZWFkKCZkLT5yZXN2X3BhZ2VfbGlzdCk7DQo+ID4gKyAgICBzcGluX3VubG9jaygmZC0+cGFnZV9h bGxvY19sb2NrKTsNCj4gPiArICAgIGlmICggdW5saWtlbHkoIXBhZ2UpICkNCj4gPiArICAgICAg ICByZXR1cm4gSU5WQUxJRF9NRk47DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhcHJlcGFyZV9zdGF0 aWNtZW1fcGFnZXMocGFnZSwgMSwgbWVtZmxhZ3MpICkNCj4gPiArICAgICAgICBnb3RvIGZhaWw7 DQo+ID4gKw0KPiA+ICsgICAgaWYgKCBhc3NpZ25fZG9tc3RhdGljX3BhZ2VzKGQsIHBhZ2UsIDEs IG1lbWZsYWdzKSApDQo+ID4gKyAgICAgICAgZ290byBmYWlsX2Fzc2lnbjsNCj4gPiArDQo+ID4g KyAgICByZXR1cm4gcGFnZV90b19tZm4ocGFnZSk7DQo+ID4gKw0KPiA+ICsgZmFpbF9hc3NpZ246 DQo+ID4gKyAgICBmcmVlX3N0YXRpY21lbV9wYWdlcyhwYWdlLCAxLCBtZW1mbGFncyAmIE1FTUZf bm9fc2NydWIpOw0KPiANCj4gRG9lc24ndCB0aGlzIG5lZWQgdG8gYmUgIShtZW1mbGFncyAmIE1F TUZfbm9fc2NydWIpPyBBbmQgdGhlbiAtIHdpdGgNCg0KSSBnb3QgYSBiaXQgY29uZnVzZWQgYWJv dXQgdGhpcyBmbGFnIE1FTUZfbm9fc2NydWIsIGRvZXMgaXQgbWVhbiBubyBuZWVkDQp0byBzY3J1 Yj8gDQpTaW5jZSBJIHNhdyB0aGF0IGluIGFsbG9jX2RvbWhlYXBfcGFnZXMoLi4uKQ0KICAgIGlm ICggYXNzaWduX3BhZ2UocGcsIG9yZGVyLCBkLCBtZW1mbGFncykgKQ0KICAgIHsNCiAgICAgICAg ZnJlZV9oZWFwX3BhZ2VzKHBnLCBvcmRlciwgbWVtZmxhZ3MgJiBNRU1GX25vX3NjcnViKTsNCiAg ICAgICAgcmV0dXJuIE5VTEw7DQogICAgfQ0KSXQgZG9lc24ndCBjb250YWluIGV4Y2xhbWF0aW9u IG1hcmsgdG9vLi4uDQoNCj4gYXNzaWdubWVudCBoYXZpbmcgZmFpbGVkIGFuZCB3aXRoIGl0IGJl aW5nIGp1c3QgYSBzaW5nbGUgcGFnZSB3ZSdyZSB0YWxraW5nDQo+IGFib3V0LCB0aGUgcGFnZSB3 YXMgbm90IGV4cG9zZWQgdG8gdGhlIGd1ZXN0IGF0IGFueSBwb2ludCBhZmFpY3QuIFNvIEkgZG9u J3QNCj4gc2VlIHRoZSBuZWVkIGZvciBzY3J1YmJpbmcgaW4gdGhlIGZpcnN0IHBsYWNlLg0KPiAN Cj4gQWxzbyBJIHRoaW5rIHRoZSByZW5hbWUgb2YgdGhlIGZ1bmN0aW9uIHdvdWxkIGJldHRlciBi ZSBkb25lIGZpcnN0LCBzaW5jZSB0aGVuDQo+IHlvdSB3b3VsZG4ndCBuZWVkIHRvIHRvdWNoIHRo aXMgbGluZSBhZ2FpbiByaWdodCBpbiB0aGUgbmV4dCBwYXRjaCwgYW5kIHRoZQ0KPiBwcmVwYXJl L3VucHJlcGFyZSBwYWlyaW5nIHdvdWxkIGFsc28gYmUgdmlzaWJsZSByaWdodCBoZXJlLiBUaGlz IHdvdWxkIHRoZW4NCj4gYWxzbyBiZXR0ZXIgZml0IHdpdGggdGhlIGludHJvZHVjdGlvbiBvZiBw cmVwYXJlXyooKSBpbiB0aGUgcHJldmlvdXMgcGF0Y2gNCj4gKHdoaWNoLCBhZmFpYywgdGhlIG5h bWUgY2hhbmdlIGNvdWxkIGFsc28gYmUgbWVyZ2VkIGludG87IEZUQU9EIEkgZG9uJ3QNCj4gbWlu ZCBpdCB0byBiZSBzZXBhcmF0ZSkuDQo+IA0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:27:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:27:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398528.639386 (Exim 4.92) (envelope-from ) id 1oV6VV-0001X3-00; Mon, 05 Sep 2022 07:26:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398528.639386; Mon, 05 Sep 2022 07:26:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6VU-0001Ww-Ta; Mon, 05 Sep 2022 07:26:56 +0000 Received: by outflank-mailman (input) for mailman id 398528; Mon, 05 Sep 2022 07:26:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6VU-0001Wq-6x for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:26:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1ddf97d2-2cec-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 09:26:54 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EAFBED1; Mon, 5 Sep 2022 00:27:00 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DCB473F73D; Mon, 5 Sep 2022 00:27:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ddf97d2-2cec-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v2 0/4] Introduce reserved heap Date: Mon, 5 Sep 2022 07:26:31 +0000 Message-Id: <20220905072635.16294-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 The reserved heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such reserved heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU systems, where only a finite number of memory protection regions are available. The limited number of protection regions places requirement on planning the use of MPU protection regions and one or more MPU protection regions needs to be reserved only for heap. The first patch introduces the reserved heap and the device tree parsing code. The second patch enhances the error handling in processing the dts chosen node. The third patch adds the implementation of the reserved heap pages handling in boot and heap allocator for Arm. The fourth patch renames xenheap_* to directmap_* for better readablity. Changes from v1 to v2: - Rename the device tree property to xen,static-heap to avoid confusion. - Change of commit msg and doc wording, correct typo in commit msg. - Add an empty line in make_memory_node() memory type check to improve readability. - Use enum membank_type to make the memory type cleaner. - New commits for make process_chosen_node() return int and rename xenheap_* to directmap_*. - Move the global bool `reserved_heap` to bootinfo. - Replace the open open-coding address ~0 by INVALID_PADDR. - Do not use reverted logic in heap_pages calculation. - Remove unused Arm32 reserved_heap_start variable. - Decouple the arm32 reserved heap too small size check with region end check. - Reuse the arm32 original xenheap finding logic with the new helper to make sure xenheap on arm32 is contiguous. Henry Wang (4): docs, xen/arm: Introduce reserved heap memory xen/arm: bootfdt: Make process_chosen_node() return int xen/arm: Handle reserved heap pages in boot and heap allocator xen/arm: mm: Rename xenheap_* variable to directmap_* docs/misc/arm/device-tree/booting.txt | 45 ++++++++ xen/arch/arm/bootfdt.c | 54 +++++++--- xen/arch/arm/domain_build.c | 8 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 22 ++-- xen/arch/arm/include/asm/setup.h | 8 +- xen/arch/arm/mm.c | 24 ++--- xen/arch/arm/setup.c | 145 ++++++++++++++++++++------ 8 files changed, 238 insertions(+), 70 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:27:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:27:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398529.639398 (Exim 4.92) (envelope-from ) id 1oV6Ve-0001pA-7Z; Mon, 05 Sep 2022 07:27:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398529.639398; Mon, 05 Sep 2022 07:27:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Ve-0001ow-4M; Mon, 05 Sep 2022 07:27:06 +0000 Received: by outflank-mailman (input) for mailman id 398529; Mon, 05 Sep 2022 07:27:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vd-0001oQ-6q for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:27:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 2348637a-2cec-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:27:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43DA0ED1; Mon, 5 Sep 2022 00:27:09 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C40923F73D; Mon, 5 Sep 2022 00:27:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2348637a-2cec-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Date: Mon, 5 Sep 2022 07:26:32 +0000 Message-Id: <20220905072635.16294-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220905072635.16294-1-Henry.Wang@arm.com> References: <20220905072635.16294-1-Henry.Wang@arm.com> This commit introduces the reserved heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_tree_get_meminfo(). Changes of code are done accordingly following the introduction of this enum. Also, this commit introduces the logic to parse the reserved heap configuration in device tree by reusing the device tree entry definition of the static memory allocation feature. If the memory bank is reserved as heap through `xen,static-heap` property in device tree `chosen` node, the memory will be marked as heap type. A documentation section is added, describing the definition of reserved heap memory and the method of enabling the reserved heap memory through device tree at boot time. Signed-off-by: Henry Wang Signed-off-by: Penny Zheng --- Changes from v1 to v2: - Rename the device tree property to xen,static-heap to avoid confusion. - Change of commit msg and doc wording, correct typo in commit msg. - Do not change the process_chosen_node() return type. - Add an empty line in make_memory_node() memory type check to improve readability. - Use enum membank_type to make the memory type cleaner. Changes from RFC to v1: - Rename the terminology to reserved heap. --- docs/misc/arm/device-tree/booting.txt | 45 +++++++++++++++++++++++++++ xen/arch/arm/bootfdt.c | 31 +++++++++++++++--- xen/arch/arm/domain_build.c | 8 +++-- xen/arch/arm/include/asm/setup.h | 7 ++++- xen/arch/arm/setup.c | 2 +- 5 files changed, 84 insertions(+), 9 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..ff7ca36715 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,48 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + + +Reserved Heap Memory +==================== + +The reserved heap memory (also known as the statically-configured heap) refers +to parts of RAM reserved in the beginning of boot time for heap. The memory is +reserved by configuration in the device tree using physical address ranges. + +The reserved heap memory declared in the device tree defines the memory areas +that will be reserved to be used exclusively as heap. + +- For Arm32, since there are seperated heaps, the reserved heap will be used +for both domheap and xenheap. +- For Arm64, since there is a single heap, the defined reserved heap areas +shall always go to the heap allocator. + +The reserved heap memory is an optional feature and can be enabled by adding +below device tree properties in the `chosen` node. + +The dtb should have the following properties: + +- xen,static-heap + + Property under the top-level "chosen" node. It specifies the address + and size of Xen reserved heap memory. + +- #xen,static-heap-address-cells and #xen,static-heap-size-cells + + Specify the number of cells used for the address and size of the + "xen,static-heap" property under "chosen". + +Below is an example on how to specify the reserved heap in device tree: + + / { + chosen { + #xen,static-heap-address-cells = <0x2>; + #xen,static-heap-size-cells = <0x2>; + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; + ... + }; + }; + +RAM starting from the host physical address 0x30000000 of 1GB size will +be reserved as heap. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..5af71dc8ba 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, - void *data, bool xen_domain) + void *data, membank_type type) { const struct fdt_property *prop; unsigned int i, banks; @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, continue; mem->bank[mem->nr_banks].start = start; mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].xen_domain = xen_domain; + mem->bank[mem->nr_banks].type = type; mem->nr_banks++; } @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, void *data) { return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, - data, false); + data, MEMBANK_MEMORY); } static int __init process_reserved_memory_node(const void *fdt, int node, @@ -301,6 +301,28 @@ static void __init process_chosen_node(const void *fdt, int node, paddr_t start, end; int len; + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) + { + u32 address_cells = device_tree_get_u32(fdt, node, + "#xen,static-heap-address-cells", 0); + u32 size_cells = device_tree_get_u32(fdt, node, + "#xen,static-heap-size-cells", 0); + + printk("Checking for reserved heap in /chosen\n"); + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: node `%s': invalid #xen,static-heap-address-cells or #xen,static-heap-size-cells\n", + name); + return; + } + + if ( device_tree_get_meminfo(fdt, node, "xen,static-heap", + address_cells, size_cells, + &bootinfo.reserved_mem, + MEMBANK_RSVD_HEAP) ) + return; + } + printk("Checking for initrd in /chosen\n"); prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); @@ -358,7 +380,8 @@ static int __init process_domain_node(const void *fdt, int node, "#xen,static-mem-size-cells", 0); return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, - size_cells, &bootinfo.reserved_mem, true); + size_cells, &bootinfo.reserved_mem, + MEMBANK_XEN_DOMAIN); } static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..1e46b95f0b 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, if ( mem->nr_banks == 0 ) return -ENOENT; - /* find first memory range not bound to a Xen domain */ - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) + /* find first memory range not bound to a Xen domain nor heap */ + for ( i = 0; i < mem->nr_banks && + (mem->bank[i].type != MEMBANK_MEMORY); i++ ) ; + if ( i == mem->nr_banks ) return 0; @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, u64 start = mem->bank[i].start; u64 size = mem->bank[i].size; - if ( mem->bank[i].xen_domain ) + if ( mem->bank[i].type == MEMBANK_XEN_DOMAIN ) continue; dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..d0cc556833 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -22,11 +22,16 @@ typedef enum { BOOTMOD_UNKNOWN } bootmodule_kind; +typedef enum { + MEMBANK_MEMORY, + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain. */ + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */ +} membank_type; struct membank { paddr_t start; paddr_t size; - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ + membank_type type; }; struct meminfo { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 6e0398f3f6..8d3f859982 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) { - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_XEN_DOMAIN ) { mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:27:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:27:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398530.639409 (Exim 4.92) (envelope-from ) id 1oV6Vk-0002CJ-Fm; Mon, 05 Sep 2022 07:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398530.639409; Mon, 05 Sep 2022 07:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vk-0002CC-CQ; Mon, 05 Sep 2022 07:27:12 +0000 Received: by outflank-mailman (input) for mailman id 398530; Mon, 05 Sep 2022 07:27:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vi-0001Wq-Es for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:27:10 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 26ae17ad-2cec-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 09:27:09 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12251139F; Mon, 5 Sep 2022 00:27:15 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D1E7E3F73D; Mon, 5 Sep 2022 00:27:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26ae17ad-2cec-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int Date: Mon, 5 Sep 2022 07:26:33 +0000 Message-Id: <20220905072635.16294-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220905072635.16294-1-Henry.Wang@arm.com> References: <20220905072635.16294-1-Henry.Wang@arm.com> At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error type. Signed-off-by: Henry Wang --- Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 5af71dc8ba..3796a4bd75 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -293,9 +293,9 @@ static void __init process_multiboot_node(const void *fdt, int node, kind, start, domU); } -static void __init process_chosen_node(const void *fdt, int node, - const char *name, - u32 address_cells, u32 size_cells) +static int __init process_chosen_node(const void *fdt, int node, + const char *name, + u32 address_cells, u32 size_cells) { const struct fdt_property *prop; paddr_t start, end; @@ -303,6 +303,7 @@ static void __init process_chosen_node(const void *fdt, int node, if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) { + int rc; u32 address_cells = device_tree_get_u32(fdt, node, "#xen,static-heap-address-cells", 0); u32 size_cells = device_tree_get_u32(fdt, node, @@ -313,14 +314,14 @@ static void __init process_chosen_node(const void *fdt, int node, { printk("fdt: node `%s': invalid #xen,static-heap-address-cells or #xen,static-heap-size-cells\n", name); - return; + return -EINVAL; } - if ( device_tree_get_meminfo(fdt, node, "xen,static-heap", + rc = device_tree_get_meminfo(fdt, node, "xen,static-heap", address_cells, size_cells, - &bootinfo.reserved_mem, - MEMBANK_RSVD_HEAP) ) - return; + &bootinfo.reserved_mem, MEMBANK_RSVD_HEAP); + if ( rc ) + return rc; } printk("Checking for initrd in /chosen\n"); @@ -328,11 +329,11 @@ static void __init process_chosen_node(const void *fdt, int node, prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); if ( !prop ) /* No initrd present. */ - return; + return 0; if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-start property has invalid length %d\n", len); - return; + return -EINVAL; } start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -340,12 +341,12 @@ static void __init process_chosen_node(const void *fdt, int node, if ( !prop ) { printk("linux,initrd-end not present but -start was\n"); - return; + return -EINVAL; } if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-end property has invalid length %d\n", len); - return; + return -EINVAL; } end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -353,12 +354,14 @@ static void __init process_chosen_node(const void *fdt, int node, { printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n", start, end); - return; + return -EINVAL; } printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end); add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); + + return 0; } static int __init process_domain_node(const void *fdt, int node, @@ -406,7 +409,7 @@ static int __init early_scan_node(const void *fdt, device_tree_node_compatible(fdt, node, "multiboot,module" ))) process_multiboot_node(fdt, node, name, address_cells, size_cells); else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) - process_chosen_node(fdt, node, name, address_cells, size_cells); + rc = process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:27:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398534.639419 (Exim 4.92) (envelope-from ) id 1oV6Vp-0002bj-OR; Mon, 05 Sep 2022 07:27:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398534.639419; Mon, 05 Sep 2022 07:27:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vp-0002bZ-LE; Mon, 05 Sep 2022 07:27:17 +0000 Received: by outflank-mailman (input) for mailman id 398534; Mon, 05 Sep 2022 07:27:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vn-0001oQ-M0 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:27:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 29a410c7-2cec-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:27:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA22BED1; Mon, 5 Sep 2022 00:27:19 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B4F9A3F73D; Mon, 5 Sep 2022 00:27:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29a410c7-2cec-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Date: Mon, 5 Sep 2022 07:26:34 +0000 Message-Id: <20220905072635.16294-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220905072635.16294-1-Henry.Wang@arm.com> References: <20220905072635.16294-1-Henry.Wang@arm.com> This commit firstly adds a bool field `reserved_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the reserved heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the reserved heap is enabled, we use the reserved heap region for both domheap and xenheap allocation. Note that the xenheap on Arm32 should be always contiguous, so also add a helper fit_xenheap_in_reserved_heap() for Arm32 to find the required xenheap in the reserved heap regions. For Arm64, In `setup_mm`, if the reserved heap is enabled and used, we make sure that only these reserved heap pages are added to the boot allocator. These reserved heap pages in the boot allocator are added to the heap allocator at `end_boot_allocator()`. If the reserved heap is disabled, we stick to current page allocation strategy at boot time. Also, take the chance to correct a "double not" print in Arm32 `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. Signed-off-by: Henry Wang --- Changes from v1 to v2: - Move the global bool `reserved_heap` to bootinfo. - Replace the open open-coding address ~0 by INVALID_PADDR. - Do not use reverted logic in heap_pages calculation. - Remove unused Arm32 reserved_heap_start variable. - Decouple the arm32 reserved heap too small size check with region end check. - Reuse the arm32 original xenheap finding logic with the new helper to make sure xenheap on arm32 is contiguous. Changes from RFC to v1: - Rebase on top of latest `setup_mm()` changes. - Added Arm32 logic in `setup_mm()`. --- xen/arch/arm/bootfdt.c | 2 + xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 116 +++++++++++++++++++++++++++---- 3 files changed, 104 insertions(+), 15 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 3796a4bd75..616bf5ce47 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -322,6 +322,8 @@ static int __init process_chosen_node(const void *fdt, int node, &bootinfo.reserved_mem, MEMBANK_RSVD_HEAP); if ( rc ) return rc; + + bootinfo.reserved_heap = true; } printk("Checking for initrd in /chosen\n"); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index d0cc556833..22fb950bc8 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -82,6 +82,7 @@ struct bootinfo { #ifdef CONFIG_ACPI struct meminfo acpi; #endif + bool reserved_heap; }; struct map_range_data diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 8d3f859982..0b4f7cb909 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -556,6 +556,43 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, } return e; } + +/* + * Find the contiguous xenheap region that fits in the reserved heap region with + * required size and alignment, and return the end address of xenheap. + */ +static paddr_t __init fit_xenheap_in_reserved_heap(uint32_t size, paddr_t align) +{ + int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) + { + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Arm32 allocates xenheap from higher address to lower, so if + * there are multiple memory banks that satisfy the requirement, + * use the highest bank. + */ + end = max(end, aligned_end); + } + } + + return end; +} #endif /* @@ -713,8 +750,9 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 static void __init setup_mm(void) { - paddr_t ram_start, ram_end, ram_size, e; - unsigned long ram_pages; + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t reserved_heap_end = 0, reserved_heap_size = 0; + unsigned long ram_pages, reserved_heap_pages = 0; unsigned long heap_pages, xenheap_pages, domheap_pages; unsigned int i; const uint32_t ctr = READ_CP32(CTR); @@ -734,9 +772,9 @@ static void __init setup_mm(void) for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) { - paddr_t bank_start = bootinfo.mem.bank[i].start; - paddr_t bank_size = bootinfo.mem.bank[i].size; - paddr_t bank_end = bank_start + bank_size; + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; ram_size = ram_size + bank_size; ram_start = min(ram_start,bank_start); @@ -745,19 +783,42 @@ static void __init setup_mm(void) total_pages = ram_pages = ram_size >> PAGE_SHIFT; + if ( bootinfo.reserved_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) + { + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + reserved_heap_size += bank_size; + reserved_heap_end = max(reserved_heap_end, bank_end); + } + } + + reserved_heap_pages = reserved_heap_size >> PAGE_SHIFT; + if ( reserved_heap_pages < 32<<(20-PAGE_SHIFT) ) + panic("Too small reserved heap region, should be at least 32M\n"); + } + /* * If the user has not requested otherwise via the command line * then locate the xenheap using these constraints: * * - must be 32 MiB aligned * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system if less + * - must be at most 1GB or 1/32 the total RAM in the system + * (there is no reserved heap) or 1/32 the total reserved + * heap region (there is reserved heap) if less * - must be at least 32M * * We try to allocate the largest xenheap possible within these * constraints. */ - heap_pages = ram_pages; + heap_pages = bootinfo.reserved_heap ? reserved_heap_pages : ram_pages; + if ( opt_xenheap_megabytes ) xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); else @@ -767,9 +828,15 @@ static void __init setup_mm(void) xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); } + /* + * On Arm32, xenheap must be contiguous, look for one of the region + * that matches the above-mentioned xenheap constraints. + */ do { - e = consider_modules(ram_start, ram_end, + e = bootinfo.reserved_heap ? + fit_xenheap_in_reserved_heap(pfn_to_paddr(xenheap_pages), 32<<20) : + consider_modules(ram_start, ram_end, pfn_to_paddr(xenheap_pages), 32<<20, 0); if ( e ) @@ -779,7 +846,7 @@ static void __init setup_mm(void) } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); if ( ! e ) - panic("Not not enough space for xenheap\n"); + panic("Not enough space for xenheap\n"); domheap_pages = heap_pages - xenheap_pages; @@ -824,9 +891,9 @@ static void __init setup_mm(void) static void __init setup_mm(void) { const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = ~0; - paddr_t ram_end = 0; - paddr_t ram_size = 0; + paddr_t ram_start = INVALID_PADDR, bank_start = INVALID_PADDR; + paddr_t ram_end = 0, bank_end = 0; + paddr_t ram_size = 0, bank_size = 0; unsigned int i; init_pdx(); @@ -835,17 +902,36 @@ static void __init setup_mm(void) * We need some memory to allocate the page-tables used for the xenheap * mappings. But some regions may contain memory already allocated * for other uses (e.g. modules, reserved-memory...). - * + * If there are non-empty reserved heap regions, (only) add these regions + * in the boot allocator. + */ + if ( bootinfo.reserved_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) + { + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + init_boot_pages(bank_start, bank_end); + } + } + } + /* + * No reserved heap regions: * For simplicity, add all the free regions in the boot allocator. */ - populate_boot_allocator(); + else + populate_boot_allocator(); total_pages = 0; for ( i = 0; i < banks->nr_banks; i++ ) { const struct membank *bank = &banks->bank[i]; - paddr_t bank_end = bank->start + bank->size; + bank_end = bank->start + bank->size; ram_size = ram_size + bank->size; ram_start = min(ram_start, bank->start); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 07:27:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 07:27:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398536.639431 (Exim 4.92) (envelope-from ) id 1oV6Vt-00030G-7k; Mon, 05 Sep 2022 07:27:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398536.639431; Mon, 05 Sep 2022 07:27:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vt-000305-40; Mon, 05 Sep 2022 07:27:21 +0000 Received: by outflank-mailman (input) for mailman id 398536; Mon, 05 Sep 2022 07:27:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV6Vr-0001oQ-PV for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 07:27:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 2c22bfe2-2cec-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 09:27:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23FEDED1; Mon, 5 Sep 2022 00:27:24 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E3FBF3F73D; Mon, 5 Sep 2022 00:27:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c22bfe2-2cec-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v2 4/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Date: Mon, 5 Sep 2022 07:26:35 +0000 Message-Id: <20220905072635.16294-5-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220905072635.16294-1-Henry.Wang@arm.com> References: <20220905072635.16294-1-Henry.Wang@arm.com> With the reserved heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily. On Arm32, only the xenheap is direct mapped today. So the renaming to "directmap_*" would be still valid for Arm32. No functional change is intended. Signed-off-by: Henry Wang --- Changes from v1 to v2: - New commit. --- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 22 +++++++++++----------- xen/arch/arm/mm.c | 24 ++++++++++++------------ xen/arch/arm/setup.c | 27 ++++++++++++++------------- 4 files changed, 38 insertions(+), 37 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 2fafb9f228..0fefed1b8a 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -160,7 +160,7 @@ #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) #define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) -#define XENHEAP_VIRT_START xenheap_virt_start +#define XENHEAP_VIRT_START directmap_virt_start #define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index da25251cda..1dcb0a093a 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -150,19 +150,19 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t xenheap_mfn_start, xenheap_mfn_end; -extern vaddr_t xenheap_virt_end; +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -extern vaddr_t xenheap_virt_start; -extern unsigned long xenheap_base_pdx; +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; #endif #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ unsigned long mfn_ = mfn_x(mfn); \ - (mfn_ >= mfn_x(xenheap_mfn_start) && \ - mfn_ < mfn_x(xenheap_mfn_end)); \ + (mfn_ >= mfn_x(directmap_mfn_start) && \ + mfn_ < mfn_x(directmap_mfn_end)); \ }) #else #define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) @@ -263,16 +263,16 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) static inline void *maddr_to_virt(paddr_t ma) { ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); - ma -= mfn_to_maddr(xenheap_mfn_start); + ma -= mfn_to_maddr(directmap_mfn_start); return (void *)(unsigned long) ma + XENHEAP_VIRT_START; } #else static inline void *maddr_to_virt(paddr_t ma) { - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - xenheap_base_pdx) < + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < (DIRECTMAP_SIZE >> PAGE_SHIFT)); return (void *)(XENHEAP_VIRT_START - - (xenheap_base_pdx << PAGE_SHIFT) + + (directmap_base_pdx << PAGE_SHIFT) + ((ma & ma_va_bottom_mask) | ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); } @@ -315,10 +315,10 @@ static inline struct page_info *virt_to_page(const void *v) unsigned long pdx; ASSERT(va >= XENHEAP_VIRT_START); - ASSERT(va < xenheap_virt_end); + ASSERT(va < directmap_virt_end); pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; - pdx += mfn_to_pdx(xenheap_mfn_start); + pdx += mfn_to_pdx(directmap_mfn_start); return frame_table + pdx - frametable_base_pdx; } diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index c81c706c8b..7d6814caf2 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t xenheap_mfn_end __read_mostly; -vaddr_t xenheap_virt_end __read_mostly; +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; #ifdef CONFIG_ARM_64 -vaddr_t xenheap_virt_start __read_mostly; -unsigned long xenheap_base_pdx __read_mostly; +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; #endif unsigned long frametable_base_pdx __read_mostly; @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, panic("Unable to setup the xenheap mappings.\n"); /* Record where the xenheap is, for translation routines. */ - xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; } #else /* CONFIG_ARM_64 */ void __init setup_xenheap_mappings(unsigned long base_mfn, @@ -618,12 +618,12 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, int rc; /* First call sets the xenheap physical and virtual offset. */ - if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) ) + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) { unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - xenheap_mfn_start = _mfn(base_mfn); - xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); /* * The base address may not be aligned to the first level * size (e.g. 1GB when using 4KB pages). This would prevent @@ -633,13 +633,13 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, * Prevent that by offsetting the start of the xenheap virtual * address. */ - xenheap_virt_start = DIRECTMAP_VIRT_START + + directmap_virt_start = DIRECTMAP_VIRT_START + (base_mfn - mfn_gb) * PAGE_SIZE; } - if ( base_mfn < mfn_x(xenheap_mfn_start) ) + if ( base_mfn < mfn_x(directmap_mfn_start) ) panic("cannot add xenheap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(xenheap_mfn_start)); + base_mfn, mfn_x(directmap_mfn_start)); rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), _mfn(base_mfn), nr_mfns, diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 0b4f7cb909..399a695ff6 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -733,11 +733,11 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 /* Avoid the xenheap */ - if ( s < mfn_to_maddr(xenheap_mfn_end) && - mfn_to_maddr(xenheap_mfn_start) < e ) + if ( s < mfn_to_maddr(directmap_mfn_end) && + mfn_to_maddr(directmap_mfn_start) < e ) { - e = mfn_to_maddr(xenheap_mfn_start); - n = mfn_to_maddr(xenheap_mfn_end); + e = mfn_to_maddr(directmap_mfn_start); + n = mfn_to_maddr(directmap_mfn_end); } #endif @@ -859,15 +859,16 @@ static void __init setup_mm(void) * We need some memory to allocate the page-tables used for the * xenheap mappings. So populate the boot allocator first. * - * This requires us to set xenheap_mfn_{start, end} first so the Xenheap + * Note that currently xenheap is direct mapped on Arm32. + * This requires us to set directmap_mfn_{start, end} first so the Xenheap * region can be avoided. */ - xenheap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - xenheap_mfn_end = mfn_add(xenheap_mfn_start, xenheap_pages); + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); populate_boot_allocator(); - setup_xenheap_mappings(mfn_x(xenheap_mfn_start), xenheap_pages); + setup_xenheap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); @@ -882,8 +883,8 @@ static void __init setup_mm(void) smp_processor_id()); /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), - mfn_to_maddr(xenheap_mfn_end)); + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); init_staticmem_pages(); } @@ -943,9 +944,9 @@ static void __init setup_mm(void) total_pages += ram_size >> PAGE_SHIFT; - xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - xenheap_mfn_start = maddr_to_mfn(ram_start); - xenheap_mfn_end = maddr_to_mfn(ram_end); + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 08:12:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 08:12:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398575.639442 (Exim 4.92) (envelope-from ) id 1oV7Dd-0001IG-5j; Mon, 05 Sep 2022 08:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398575.639442; Mon, 05 Sep 2022 08:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7Dd-0001I9-2u; Mon, 05 Sep 2022 08:12:33 +0000 Received: by outflank-mailman (input) for mailman id 398575; Mon, 05 Sep 2022 08:12:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7Dc-0001I3-2f for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 08:12:32 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c6a17c2-2cf2-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 10:12:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6CC095FCCC; Mon, 5 Sep 2022 08:12:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4046313A66; Mon, 5 Sep 2022 08:12:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vpI8D22vFWNpBAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 08:12:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c6a17c2-2cf2-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662365549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vLBCtbeiMkaT10it/2QfW3oy9NGXJ0931FNcJJeTs+E=; b=hvJuONTlqXa3IZLVuzAZ3mvfimjG/HG5K1UYXiiMd6Jxc7MnBmd8EvFQgw5oSEYQnG/f0V +51wd/30Jfiv7ka9ky5kghqEmUu9AoehBsL4FA/S3udtvnMmZ/ybc1m3/Htxqdr3KL53Wv TIehxfs6fvCI+DApLUGQDHmpY/iq5bI= Date: Mon, 5 Sep 2022 10:12:28 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun 04-09-22 18:32:58, Suren Baghdasaryan wrote: > On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: [...] > > Yes, tracking back the call trace would be really needed. The question > > is whether this is really prohibitively expensive. How much overhead are > > we talking about? There is no free lunch here, really. You either have > > the overhead during runtime when the feature is used or on the source > > code level for all the future development (with a maze of macros and > > wrappers). > > As promised, I profiled a simple code that repeatedly makes 10 > allocations/frees in a loop and measured overheads of code tagging, > call stack capturing and tracing+BPF for page and slab allocations. > Summary: > > Page allocations (overheads are compared to get_free_pages() duration): > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > 8.8% lookup_page_ext > 1237% call stack capture > 139% tracepoint with attached empty BPF program Yes, I am not surprised that the call stack capturing is really expensive comparing to the allocator fast path (which is really highly optimized and I suspect that with 10 allocation/free loop you mostly get your memory from the pcp lists). Is this overhead still _that_ visible for somehow less microoptimized workloads which have to take slow paths as well? Also what kind of stack unwinder is configured (I guess ORC)? This is not my area but from what I remember the unwinder overhead varies between ORC and FP. And just to make it clear. I do realize that an overhead from the stack unwinding is unavoidable. And code tagging would logically have lower overhead as it performs much less work. But the main point is whether our existing stack unwiding approach is really prohibitively expensive to be used for debugging purposes on production systems. I might misremember but I recall people having bigger concerns with page_owner memory footprint than the actual stack unwinder overhead. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Mon Sep 05 08:44:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 08:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398583.639453 (Exim 4.92) (envelope-from ) id 1oV7iv-0004kg-Ju; Mon, 05 Sep 2022 08:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398583.639453; Mon, 05 Sep 2022 08:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7iv-0004kZ-H3; Mon, 05 Sep 2022 08:44:53 +0000 Received: by outflank-mailman (input) for mailman id 398583; Mon, 05 Sep 2022 08:44:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7iu-0004kT-3z for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 08:44:52 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2064.outbound.protection.outlook.com [40.107.93.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 002f866a-2cf7-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 10:44:50 +0200 (CEST) Received: from DS7PR06CA0010.namprd06.prod.outlook.com (2603:10b6:8:2a::17) by IA1PR12MB6353.namprd12.prod.outlook.com (2603:10b6:208:3e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Mon, 5 Sep 2022 08:44:46 +0000 Received: from DM6NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2a:cafe::c4) by DS7PR06CA0010.outlook.office365.com (2603:10b6:8:2a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 08:44:46 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT017.mail.protection.outlook.com (10.13.172.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 08:44:46 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 03:44:45 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 03:44:45 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 5 Sep 2022 03:44:44 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 002f866a-2cf7-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WlamoT03TVZfAQy1b1O06AxxseBENk/QEv+4k15SzhxOZ4AcGNudTnSvmlWi7qZ80O3oxXvbv/pQpAj59mhHmprWW6arUlzkSI02R1VOL+obt4j6nNclutLD2Yh/Kv8ryJcrK4Uqc2rj9c4plzn7gfVCVEmzA9+TzY2/4XlhZwhKBteVlBxLelPkbfvOsdQ9o75XiIkRdgORd49oVXWsdyB0UpsniJyvviN8oZw0de/nhYob6Ukc7rz4qXDMYMGNjfI1eGsKtQ6UUaUBS/ITCKx6trJoUDWghdO+geilP/qBBaRnp2WOiNmov4A09nheAWZ24AFOmU0w/aDfPNkXQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AwDs2ed147tl2UT5ygQg74PPniA3YTFZLRnX5MVHE6o=; b=C/IY7D+/zaetrOW5aKAKO389REACpgw0mWSIU6OxSJ77fommDWaPVnisMC1m3iEKh7UGUPRHY9DeSerR7aU7ZYwdkDRdpA3CCx7g/aVnfop2y/JcOvnhgs01UUorUWjrTqef5Nwi1fT2nJ6w9JSjyhTJnYIdx04IBjtVPoavIqeAZkXZqhPRudiI4s0YNySsc6xvd6plEa/JGTgBcGdNLZ4RdACTdYO9WoNW6eU119OAa5aBS7cw3djhphvKMyq3g6C5ylCBbuCKTOJe8kLYdMuypvKWAwISMDPxrFZd4r8MInq0zmVl7zRAXyQBa/N2nEGhZ7qnf3mOgyqZAwwMFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AwDs2ed147tl2UT5ygQg74PPniA3YTFZLRnX5MVHE6o=; b=wfLLHFaJaBXA88T3/PLrOlvRaCOXcHjAi6iYhdjQ0sNgxjiAPCPai4uaWvvNz90TixHKd9C4l3mFWugDD+MiV8oIb/NvWQrvxZo25no27LM6cTxUgG4fkY5wTv6xvQKjP0VcslJhYa6uFMRQnpOe0SfxBLy6m+vCTxEB6Fc3t5c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <98b712c1-2a02-9baa-b816-3c28cccaf74e@amd.com> Date: Mon, 5 Sep 2022 10:44:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 Content-Language: en-US To: Stefano Stabellini CC: , Doug Goldstein References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-4-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 703fa30f-85cd-42f0-13b1-08da8f1ae2b4 X-MS-TrafficTypeDiagnostic: IA1PR12MB6353:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cxzsgH9RhCwuxGqj6X2f7zX3sSSDYOgbDUvk14GW7AVSUQgs4c2j0/hUsOX/Pi10z3jpemHSwZKGK1j3Bg28dxO/bzCB1CBgett7xW5eyOEJxmGKLj0m5SQtH00ukov5FYbbMug3AmAx0j90KrDPOS796D23VZfT+H/TSQl+mr2s63NNRPnkiEwjuDwHmKwmnf1DwfKF/tnV1+uFmTnRuTfW6ENuy9uFmdiwY3Gi1Oer6hA7PCdfXa8QhVbXWMi/OBAN0ZeLNP9aPEctam8UsFptIi0pFQcDFqKzHDRTS7v13BytCPua7G1hkTqNitqob0nhisDB2+RZtJ8CF6lZMDoB1L/OvCp+PGV61NfrMisGSvhuZXm3g58iVfq7ByjpH3+bxXxLVySBc+sNlNk7GrY+tvQZiNmKYItZanAl/n2+ZfTelTtYLF2LUgk/z8Wp57VMDVyLmvO4Iq5smkb7S2N1XOIj7rKCPiT4abG9og0e4B+qXOXiQYEmUD48UnVCnR9QgLeGsyE7ud2K0t4K739RJzuUOfE9a9PmoY94cMhsyUAAZea9pX4fyC/Focf67/z53DfSRVT94RRzu5lVQQBLYVeLG+0mFla8Hc4Kp/Qdg4zNGxzNatGI3QLctMbstRvIOFM+SXRHVQdhnYV4btaSVM1ETFCCd3oUWFrOdb3mARhzZpb6FF8Ql+M75DOa4rrgHNFcmHogykETlpxjS5ioET109z8S5shphjzMkmHf8IWI8v/8BHEsLp0asTgHFuqbg3nkxrkZevmMZX9oSPZ/SKYrUtUmW8ys8hYgTjWEmicbk8vuSjSLOs6qL882FqlJDQOHcRvmz6cEl7+AhWpTSH3G5P2uDH/pL3Drr0Q= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(40470700004)(36840700001)(46966006)(336012)(186003)(2616005)(47076005)(426003)(82740400003)(8936002)(83380400001)(36860700001)(44832011)(5660300002)(70586007)(70206006)(4326008)(40480700001)(82310400005)(2906002)(8676002)(41300700001)(478600001)(40460700003)(26005)(316002)(16576012)(6916009)(54906003)(53546011)(31686004)(81166007)(36756003)(86362001)(31696002)(356005)(157313001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 08:44:46.0783 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 703fa30f-85cd-42f0-13b1-08da8f1ae2b4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6353 Hi Stefano, On 03/09/2022 01:49, Stefano Stabellini wrote: > > > Currently this test fails with: > > + fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled > + [[ boot-cpupools == \b\o\o\t\-\c\p\u\p\o\o\l\s ]] > ++ fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle > Error at 'phandle': FDT_ERR_NOTFOUND My bad. The qemu version used by CI does not generate phandles for cpus. So the fix is very straightforward and requires putting custom phandle for cpu@1. diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index c2184850293c..158d5665d71d 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -50,8 +50,9 @@ fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled if [[ "${test_variant}" == "boot-cpupools" ]]; then # Create cpupool node and assign it to domU0 - cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" + cpu_phandle="0xfffffe" cpupool_phandle="0xffffff" + fdtput binaries/virt-gicv2.dtb -p -t x /cpus/cpu@1 phandle $cpu_phandle fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle > > Given my other comment below, I would leave this code as is. > > >> +if [[ "${test_variant}" == "boot-cpupools" ]]; then >> + # Create cpupool node and assign it to domU0 >> + cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" >> + cpupool_phandle="0xffffff" >> + fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool >> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle >> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle >> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/domU0 domain-cpupool $cpupool_phandle >> + >> + # Check if domU0 (id=1) is assigned to Pool-1 >> + passed="${test_variant} test passed" >> + dom0_check="if xl list -c 1 | grep -q Pool-1; then echo ${passed}; fi" >> +fi > > I would prefer to keep the device tree editing here to a minimum and > instead add boot-cpupool support in ImageBuilder and add CPUPOOL* config > options to the existing config file for ImageBuilder created in this > file below. This way, we keep this test cleaner and we help more the > user by proving a way to set boot-cpupools more easily in general, also > useful outside gitlab-ci. I agree that ImageBuilder is a great tool. However, I would opt for keeping what I did because of the following: - current release schedule (we could benefit from having a test for 4.17 feature instead of waiting for the corresponding change to be done in ImageBuilder first and tested), - test is already prepared and requires just a trivial fix, - we should not enforce users willing to add tests to gitlab-ci to always prepare the ImageBuilder changes first. ImageBuilder is not meant to support all the features strictly because some of them require too much end-user knowledge and digging into device tree (it should stay as simple as possible), - all in all we need to have a way to modify the dtb and fdtput is certainly better than sed as it does not require additional steps for decompilation/compilation and its commands look more clean than using sed transformation. Let me know what you think. On a side note, I can add boot-time cpupools support in ImageBuilder to my TODO list so that we can check if this is something ImageBuilder should support. If yes, we can modify this test after the release. I can already think of the following IB config options that would need to be introduced to properly support boot-time cpupools: CPUPOOL[number] = " " - to create cpupools NUM_CPUPOOLS = "" - to keep the number of created cpupools DOMU_CPUPOOL[number] = "CPUPOOL[number]" - to assing domU to one of the created cpupools So we already have 3 new options and the number of required sanity checks I can think of is significant. Even then, we could easily trigger a failure e.g. if user assigns cpus of different type and does not pass hmp-unsafe=1. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 05 08:49:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 08:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398592.639464 (Exim 4.92) (envelope-from ) id 1oV7na-0005TV-AR; Mon, 05 Sep 2022 08:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398592.639464; Mon, 05 Sep 2022 08:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7na-0005TN-7j; Mon, 05 Sep 2022 08:49:42 +0000 Received: by outflank-mailman (input) for mailman id 398592; Mon, 05 Sep 2022 08:49:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7nZ-0005TH-2l for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 08:49:41 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad6e8d50-2cf7-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 10:49:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5BCEA38129; Mon, 5 Sep 2022 08:49:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A198139C7; Mon, 5 Sep 2022 08:49:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UM+9CSO4FWMqFwAAMHmgww (envelope-from ); Mon, 05 Sep 2022 08:49:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad6e8d50-2cf7-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662367779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xc3ngfTbFfRO12fCwmaAUkvuolnuXfU1jb4qhmTTa9o=; b=naI5Af2DTLvKC4tKL0EBn4HU/6OQwcnrc/MJPo/U5PoHZEMiHEK3C1cS+Jz7y89mgJJnMC z4jnqVmLLkQjrc+tpmfFOBAXeR1gseGMvPLn7HvDrPqqcrAwnvNF+LnPu4gXLWFn7NidMW POtBx+boR1rnp6IBK7NcOwLS94FYp8I= Date: Mon, 5 Sep 2022 10:49:38 +0200 From: Michal Hocko To: Kent Overstreet Cc: Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901201502.sn6223bayzwferxv@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901201502.sn6223bayzwferxv@moria.home.lan> On Thu 01-09-22 16:15:02, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 12:39:11PM -0700, Suren Baghdasaryan wrote: > > kmemleak is known to be slow and it's even documented [1], so I hope I > > can skip that part. For page_owner to provide the comparable > > information we would have to capture the call stacks for all page > > allocations unlike our proposal which allows to do that selectively > > for specific call sites. I'll post the overhead numbers of call stack > > capturing once I'm finished with profiling the latest code, hopefully > > sometime tomorrow, in the worst case after the long weekend. > > To expand on this further: we're stashing a pointer to the alloc_tag, which is > defined at the allocation callsite. That's how we're able to decrement the > proper counter on free, and why this beats any tracing based approach - with > tracing you'd instead have to correlate allocate/free events. Ouch. > > > > Yes, tracking back the call trace would be really needed. The question > > > is whether this is really prohibitively expensive. How much overhead are > > > we talking about? There is no free lunch here, really. You either have > > > the overhead during runtime when the feature is used or on the source > > > code level for all the future development (with a maze of macros and > > > wrappers). > > The full call stack is really not what you want in most applications - that's > what people think they want at first, and why page_owner works the way it does, > but it turns out that then combining all the different but related stack traces > _sucks_ (so why were you saving them in the first place?), and then you have to > do a separate memory allocate for each stack track, which destroys performance. I do agree that the full stack trace is likely not what you need. But the portion of the stack that you need is not really clear because the relevant part might be on a different level of the calltrace depending on the allocation site. Take this as an example: {traverse, seq_read_iter, single_open_size}->seq_buf_alloc -> kvmalloc -> kmalloc This whole part of the stack is not really all that interesting and you would have to allocate pretty high at the API layer to catch something useful. And please remember that seq_file interface is heavily used in throughout the kernel. I wouldn't suspect seq_file itself to be buggy, that is well exercised code but its users can botch things and that is where the leak would happen. There are many other examples like that where the allocation is done at a lib/infrastructure layer (sysfs framework, mempools network pool allocators and whatnot). We do care about those users, really. Ad-hoc pool allocators built on top of the core MM allocators are not really uncommon. And I am really skeptical we really want to add all the tagging source code level changes to each and every one of them. This is really my main concern about this whole work. Not only it adds a considerable maintenance burden to the core MM because it adds on top of our existing allocator layers complexity but it would need to spread beyond MM to be useful because it is usually outside of MM where leaks happen. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Mon Sep 05 08:54:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 08:54:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398599.639475 (Exim 4.92) (envelope-from ) id 1oV7s4-0006tN-SD; Mon, 05 Sep 2022 08:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398599.639475; Mon, 05 Sep 2022 08:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7s4-0006tG-PP; Mon, 05 Sep 2022 08:54:20 +0000 Received: by outflank-mailman (input) for mailman id 398599; Mon, 05 Sep 2022 08:54:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7s3-0006t6-CL; Mon, 05 Sep 2022 08:54:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7s3-0005bQ-7R; Mon, 05 Sep 2022 08:54:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7s3-0005xY-0M; Mon, 05 Sep 2022 08:54:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV7s2-0005n8-U0; Mon, 05 Sep 2022 08:54:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y/Kd8Ffkj8gVl0B1nkpAWdBzLkP7tWoV4u/unXs7scs=; b=qld/N4F2uqb1bG1nH0ouutSLCC 5Ff67FIJ0g2mX2QFQsaxJdR5EAkrKnkrdmsy2NxCrkyXYVCUwLv+Q6r/4upe2U65Nh1oeWE3CP2Jq 9ilGBK6iJ7xZweVnY7phom2lEHLQqH3Xy0TMVVfD0nRTxrECQCwETArAqIYRBBBW05G0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 172991: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Mon, 05 Sep 2022 08:54:18 +0000 flight 172991 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172991/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 172984 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 172984 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 32 days Failing since 172148 2022-08-04 21:39:38 Z 31 days 72 attempts Testing same since 172945 2022-09-02 23:10:19 Z 2 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:06:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:06:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398608.639486 (Exim 4.92) (envelope-from ) id 1oV83X-0008TA-0i; Mon, 05 Sep 2022 09:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398608.639486; Mon, 05 Sep 2022 09:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV83W-0008T3-TN; Mon, 05 Sep 2022 09:06:10 +0000 Received: by outflank-mailman (input) for mailman id 398608; Mon, 05 Sep 2022 08:58:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV7wG-0007Xm-0V for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 08:58:40 +0000 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [2607:f8b0:4864:20::112b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee84a329-2cf8-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 10:58:39 +0200 (CEST) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-3454e58fe53so7705057b3.2 for ; Mon, 05 Sep 2022 01:58:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee84a329-2cf8-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Mcscb+4yg14w1rBiRtYpdW9I8YuY8tTeWXrlK9wFWrU=; b=Z8sZwX0UrQNHUyE15uUzUljN1G5+XUXWn7ozlWkNQaPS0v+13+PWoolzvMZEH/2/s6 LYS6ZELiyvlMT62CZWUyH+h/p1jXfwfZLcOF83nbGfa1U5bzWw0uJywA1Nq6g4RggQN9 M+azNg9wtAjIuHGBIaj/LBqqtGG4wC1BksRWLrapbeVhca09DWdw9aO+S7lkiOmT419k B7LBrz0EVZ5dFwwSikfSkFiCRf8G7DmN1ptEdy0ZLUUkT5MXom1MAu8JaMJrJbPX6xsQ z/gVg/ZkLNO66Ao9RVZbmyzaUupGI6+7kFaD3U0bHdpOYObc1T0hLgrkbVZFP/rVpApA /zsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Mcscb+4yg14w1rBiRtYpdW9I8YuY8tTeWXrlK9wFWrU=; b=Iq+/5DXEZJcLcLXzKp1pt5J3gLvOfIjcoAPWU55djvQPgcZOoq6sTAQGcq464RAlVK pmvfkqFFLljZVqWISoayGBFE/fY7bVygUWwUdiCDn2eYjm/Uk3DFJ0uBLJKHBMelO3hU Tg80rVmTH71yeXtC9wmsX8fOf7EUAmaxZhH/Yh798rBXXMJLhxhygvhG1w+PS+ON8Dlr irL9uNUOJe54Cmt7B8Zdmovtz/tds46OEHeCHPU2kC8xSKflDpg3B8Aajt14Kq9A5B2v g/S5wjgcS9IRn6uTBY+r2yGTciE/EJOuaKu6wW7cuoLCf9nV/I8X6TwVNZvXG4ENC9py 5lRg== X-Gm-Message-State: ACgBeo3vsFq1pBNw0iiYIt40KSRSwkS9OJAIxonzvq0Np38dsB7MjcB/ 7rlRTI+K9gU6G/aXLR+ToHuggyAT1W5AkRTWWk4onw== X-Google-Smtp-Source: AA6agR4vColk4VOoxJ3aA1AZBZ3YZkQTsja6zG5W+nyEUjeTUXHJb0eacFw2AD+E2b0jt8egp4/3QX6cb8SK35bLOpk= X-Received: by 2002:a81:bb41:0:b0:328:fd1b:5713 with SMTP id a1-20020a81bb41000000b00328fd1b5713mr38838381ywl.238.1662368317652; Mon, 05 Sep 2022 01:58:37 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Marco Elver Date: Mon, 5 Sep 2022 10:58:01 +0200 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Michal Hocko Cc: Suren Baghdasaryan , Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Mon, 5 Sept 2022 at 10:12, Michal Hocko wrote: > On Sun 04-09-22 18:32:58, Suren Baghdasaryan wrote: > > On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > [...] > > > Yes, tracking back the call trace would be really needed. The question > > > is whether this is really prohibitively expensive. How much overhead are > > > we talking about? There is no free lunch here, really. You either have > > > the overhead during runtime when the feature is used or on the source > > > code level for all the future development (with a maze of macros and > > > wrappers). > > > > As promised, I profiled a simple code that repeatedly makes 10 > > allocations/frees in a loop and measured overheads of code tagging, > > call stack capturing and tracing+BPF for page and slab allocations. > > Summary: > > > > Page allocations (overheads are compared to get_free_pages() duration): > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > 8.8% lookup_page_ext > > 1237% call stack capture > > 139% tracepoint with attached empty BPF program > > Yes, I am not surprised that the call stack capturing is really > expensive comparing to the allocator fast path (which is really highly > optimized and I suspect that with 10 allocation/free loop you mostly get > your memory from the pcp lists). Is this overhead still _that_ visible > for somehow less microoptimized workloads which have to take slow paths > as well? > > Also what kind of stack unwinder is configured (I guess ORC)? This is > not my area but from what I remember the unwinder overhead varies > between ORC and FP. > > And just to make it clear. I do realize that an overhead from the stack > unwinding is unavoidable. And code tagging would logically have lower > overhead as it performs much less work. But the main point is whether > our existing stack unwiding approach is really prohibitively expensive > to be used for debugging purposes on production systems. I might > misremember but I recall people having bigger concerns with page_owner > memory footprint than the actual stack unwinder overhead. This is just to point out that we've also been looking at cheaper collection of the stack trace (for KASAN and other sanitizers). The cheapest way to unwind the stack would be a system with "shadow call stack" enabled. With compiler support it's available on arm64, see CONFIG_SHADOW_CALL_STACK. For x86 the hope is that at one point the kernel will support CET, which newer Intel and AMD CPUs support. Collecting the call stack would then be a simple memcpy. From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:12:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:12:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398618.639497 (Exim 4.92) (envelope-from ) id 1oV898-0001YJ-QY; Mon, 05 Sep 2022 09:11:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398618.639497; Mon, 05 Sep 2022 09:11:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV898-0001YC-Lz; Mon, 05 Sep 2022 09:11:58 +0000 Received: by outflank-mailman (input) for mailman id 398618; Mon, 05 Sep 2022 09:11:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV897-0001Y6-VM for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:11:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c9b1718e-2cfa-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 11:11:55 +0200 (CEST) Received: from DU2P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::8) by PR3PR08MB5643.eurprd08.prod.outlook.com (2603:10a6:102:84::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 09:11:54 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::15) by DU2P251CA0012.outlook.office365.com (2603:10a6:10:230::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 09:11:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:11:53 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 05 Sep 2022 09:11:53 +0000 Received: from 40efb51d4ed9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2F9FCBE0-2F0D-4423-A14C-2370BA9A5A9D.1; Mon, 05 Sep 2022 09:11:46 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 40efb51d4ed9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 09:11:46 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AS2PR08MB8362.eurprd08.prod.outlook.com (2603:10a6:20b:545::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 09:11:45 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 09:11:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9b1718e-2cfa-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NSdzgxCdDRVDM2HcEFfCNgKGNTNc0FjFF3QpsTCGjP0ePezOHADrinySP+E2qYZPPsJaReK2gQu5b8wgwGjLWlx0UzdwDXGUv88/KlyKbWmqnw7iUedm+mIBsnl8XYCUSHPr5FKlejlcvss3e7jOG8LUG27uBnBVAmLJ1wFRz77mTqpBV7FUB3kqlkHjIQ0p8jPJO9PPFrac1ewVDXHUVdEDpRJIisNMmqA45e8YtjAn19olWDFk/PR+SYNy+3Cv2KVeBccYqGHUMw8jqL3l4m5f4CNMVCbhn1r5FFDnvjapwESTlPtVv6EZrEy6K9frMC8zfB/E6FLgf8RylpUQEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXHzqPrFfTspFIw1SxP0IY02oNfxltXmy++thZqLMWM=; b=ZEmMQUhrCoIh1z9Ogn44GRcQA8t01mGUxvHHY8vd3u/Nf4yzEKw/0BzaUrE1F8QLp5akkCd5HIunCauDqLw3n0/6AOhcNyYuaOtXduNeFOQo2mAcdkS3WnhFFu0lauc7gjlEiD/hgmaIo3aBFtotdwPVL3/QtvV9fiJEqnSgRdnd2ceex9ivm6SpfWeDj8u8ho4hk5nc3WFHwsfAJUymlqLzRa2WWuy3rXUf/RBnaQsv8y9Z+03EDUwQxYhpaHdQDdpDP9rT5vbeCGEfpcNUJX7bXJmhyhHQfTxYJn7xwXi/1g9/lzZ/+7+C3/Z4a+1wi0WP+Ai5ndpQuUoL1lZhLw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXHzqPrFfTspFIw1SxP0IY02oNfxltXmy++thZqLMWM=; b=jnunlRNlKiS2fikNKPbEbvWQ4uKtkoa+lCVZK9GdYimAqy6/6LWZXVw8Spnew5dygTsw25yE61U+06P6Tg790E8KmcO9lf/RZH9lLCfuSjFzwvVvOTU89cmIrJ2Ap1QbadXPODjyXxLmLYn19bkCKuulJh4fBjhVtCkQbuNCL2U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 29ace08cdaeac71e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lFTgvocMc7g1HiLvxMUTZFIP/0yeD5TmO/J3wGPd1Z3nNELmpp8gozOctea+Kf9IaWi4i1QqLbV+9im1uUM57aaiWPvZ1kjeE3QOaJanyUv25SjnHk1uV7Tkz7rNocPgbXBvEBU4GILqBUm2eMw1mWedXCq0FzEHeQtuaakrIbGt6XRFdwRtvvuR1unQ2Q+9jpO3LlKtmwIhZRtAOfFHtSswYvzzqESCa+U56VmA/2Zg0Adx2NrIXcyQ2dZfU4xhWFlij4j1fyqjfl+pfpkOLPRyX0AHoLMEbrFtBsxBcQsjX8k43s3t+DpW9sRGaB+0j5IichRajOc/vjhrC+YgUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXHzqPrFfTspFIw1SxP0IY02oNfxltXmy++thZqLMWM=; b=Sn+sziLwLzvwOjw7KYz5ifZSvyWlu+fW4ElvIZJjCsmYNghKjiK/iLy1tx/XlfyvKeQcMXjcUyL5BwBT6Qj56we0JD6qDFHLfgW1+jZHJ1VYx/qmA5KTTR73bHFO/Ty1+XsrTfnt0z/RN0Zf3+Qpm/7bZTfuKmtr4xw85kFk7HUpABVZkm6JBrxcZJk/4PdyLE9eppmA6KJ0Sn4t8gXfcPloDy8Mufqby/z/dSjs706+4HxqGeZwhaFjcZTwTUXRaxx7/h0OUfSNRGmqmpVwQ+ePEODPkTA4MwD33tAbQPJULw3u3CTdhtpdfgTBCy0zLNZqhOgcUK6kBkuHT3bxkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXHzqPrFfTspFIw1SxP0IY02oNfxltXmy++thZqLMWM=; b=jnunlRNlKiS2fikNKPbEbvWQ4uKtkoa+lCVZK9GdYimAqy6/6LWZXVw8Spnew5dygTsw25yE61U+06P6Tg790E8KmcO9lf/RZH9lLCfuSjFzwvVvOTU89cmIrJ2Ap1QbadXPODjyXxLmLYn19bkCKuulJh4fBjhVtCkQbuNCL2U= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Bertrand Marquis , Jean-Philippe Brucker , Julien Grall , Volodymyr Babchuk , Eric Auger , Jonathan Cameron , Will Deacon Subject: Re: [PATCH v2 04/10] xen/arm: smmuv3: Move definitions to a header Thread-Topic: [PATCH v2 04/10] xen/arm: smmuv3: Move definitions to a header Thread-Index: AQHYvtETH3/THBwEyUiOSo1yfqj9qq3Myi8AgAPHNoA= Date: Mon, 5 Sep 2022 09:11:44 +0000 Message-ID: <8932E06A-F426-4185-8EF0-46B4DCFABB84@arm.com> References: <73362954b7395155c8287d2ea0737e132516cc90.1662123432.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 97f7346c-27ff-4287-c86f-08da8f1eacaa x-ms-traffictypediagnostic: AS2PR08MB8362:EE_|DBAEUR03FT059:EE_|PR3PR08MB5643:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jwoQPJfmogOUwQEeSi3lgcmHk0CqTogKXljPsO96YmftSRuybvVIjKsYOawNuIc0N5OUoUotr3rnISgQ3MT3WwBbQTYY0094MZVgXUDgUqLFWouAUY5VUVUl1oy1yZnN7EfMMcr01e3XI6hr82ZAXaLmAHDSlh2Ah3BjI4J82Wi7USnDE7UX59pYLxNogiigoH1C7bk/96xVnSRncemdT2SU89GpsuprEg29VCf+XHXDuJ5dlXzWolakQPFot5XXc9AeipEl3WUn+3arWQhNhFqBkxODuMtU2EB7nd4IldlBEQyCvaRHZ3MbcCkQbrIP3YeohlJM3SiajmCVEnkMrpBZEspQwPpN0rAFrAXlvhLwLZ+w/mOmMj0FTSS5K+nqjGBJiNLdpo1OfHyy/7jt/vVcBcwOuLWq7y9MAlqEX5ZzyNh6Qz6GT6Cd5TvuZSV7BSTGNeqCzc8Eemw4B7K9Znsc8u+im7jM3pn6beAIB47rBmw7Uw9Xy4lCQLr/y/YtU95V9mMPYo7/Kto0FgDgGwLn2Kb7f3IUGRdh3uetP19koMSJavpsGJZTz0P8+LKyASw3q51cBDZEHUSQHr8PlQ5Uelp7Po1PiPlbtfsAd+erkSY9nSriSY6+Yli7YDlcJFmZF7aWHSWK6MjL74/pIN9tFBkx/0bhjlOu9+pyMDNoZ2gupVQHD4a8mIPdgkOoGgxBUdAvpxnSxT0UD3zEKSe5F2znaXzi4SeaUWJYaqdXcEiqQvtcYpMu8IgU+DYbvjoEOQUBM+2ZEb3MoAUTU6+k7UNIZw0uB+xvQgMP8n4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(71200400001)(2616005)(53546011)(76116006)(66946007)(66556008)(6506007)(66476007)(91956017)(4744005)(26005)(2906002)(316002)(6486002)(38100700002)(86362001)(41300700001)(6916009)(64756008)(186003)(8676002)(54906003)(4326008)(6512007)(478600001)(122000001)(66446008)(5660300002)(36756003)(38070700005)(8936002)(33656002)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8362 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 06b83682-2fbd-4293-3d80-08da8f1ea74b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cjhpX0D7+VqkjOXDHx7Xoupz+PwbysH9JSMxBGGZFGSNCrFw8SjYU7xrBDOn67CxEGiC5S2KFAn/eImwu/bfR6+mg8r3m22j+rmBTVWFnqmtJj7BuOTpWqEIVsK7ZlvZUfwHQGY7oUPZz5bQJm4++CKjhohKZPHbhqJ/Z5XCUqW1TnqQWnyHcKu+uBUxz6pVTUjDMiyuwluqMS/3OjZ2BRlhwUlzOZUX72AB6UCd3DxJektzrKhFHesvFi7/EP37mbfxzGBGd4DimnhwzT21sEqzihBvddOOS86ZrDC6hc3/limojSL3XDBgjqY1YpTwjJKTM4jwBXWaYR7ajUzYxzCU2pjBqdslRuagUTEAR+yFUfgAvXqPn9DOHTxnMo11X11a14dlM/i5o5ywGm1Yx46G4rdYPc0qevhPpx+b+6v5SY9w0wP3CBcOawKnKbZQWKcyMjQDihexy1FKEIBMksLZZ7XkUA7b56fgv822aYlo1mbr8byGcfl43xGJhSnv1leANpVmIvr1CivnpCbcRSmnbo6VufQy17pY0iLFEfI7R6CbfgKB/lrHzzrH/Fz8mZkjoovpCrL2AW3z6vRXphOI/u5+bR/Ia6aTFdt/GoR9DhbNIuwUmucJCGD6eGXE8KY/8pJjXNpee7pkwRury56q4Fo4frK7g7BcuN0QH8Bpi4uYnjZRyeYZaYHBYU5fQKaAsg83QqJ5gyoraqPKCK2DMBdNt9o2zC+M8Y4yZJ8F1vb/IT+XECkHcYAHYkK3HGb3H9RNIXqVyX8sBCbeiQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39860400002)(36840700001)(46966006)(40470700004)(186003)(2616005)(53546011)(47076005)(40480700001)(6862004)(83380400001)(8936002)(5660300002)(4744005)(336012)(41300700001)(86362001)(36756003)(6506007)(6486002)(478600001)(107886003)(26005)(6512007)(81166007)(40460700003)(2906002)(356005)(316002)(70206006)(70586007)(82310400005)(4326008)(8676002)(33656002)(82740400003)(36860700001)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:11:53.5010 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97f7346c-27ff-4287-c86f-08da8f1eacaa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5643 Hi Stefano, > On 3 Sep 2022, at 12:29 am, Stefano Stabellini w= rote: >=20 > On Fri, 2 Sep 2022, Rahul Singh wrote: >> From: Jean-Philippe Brucker >>=20 >> Backport Linux commit e881e7839fba. This is the clean backport without >> any changes. >=20 > I don't think we can say that this is a clean backport because there are > differences between the two patches. >=20 > That said, it is just code movement, it is similar to the original > patch, and it still compiles. So I think we should change the commit > message not to say that it is a clean backport, but other than that is > fine. >=20 Ok. I will remove the clean backport msg from commit msg in next version. Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:13:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:13:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398625.639508 (Exim 4.92) (envelope-from ) id 1oV8AH-000282-4F; Mon, 05 Sep 2022 09:13:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398625.639508; Mon, 05 Sep 2022 09:13:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8AH-00027v-0F; Mon, 05 Sep 2022 09:13:09 +0000 Received: by outflank-mailman (input) for mailman id 398625; Mon, 05 Sep 2022 09:13:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8AG-00027Y-1s for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:13:08 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00077.outbound.protection.outlook.com [40.107.0.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f39fca22-2cfa-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 11:13:06 +0200 (CEST) Received: from DB9PR01CA0012.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::17) by PAVPR08MB9649.eurprd08.prod.outlook.com (2603:10a6:102:310::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Mon, 5 Sep 2022 09:13:02 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::8e) by DB9PR01CA0012.outlook.office365.com (2603:10a6:10:1d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:13:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:13:02 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 05 Sep 2022 09:13:02 +0000 Received: from e87e207be86a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5FAACAD-44E1-4164-8A6A-304132413235.1; Mon, 05 Sep 2022 09:12:50 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e87e207be86a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 09:12:50 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DB9PR08MB9491.eurprd08.prod.outlook.com (2603:10a6:10:45a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Mon, 5 Sep 2022 09:12:48 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 09:12:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f39fca22-2cfa-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Oxd+ayau7y7RbCtlebMnEc8+xn/GwOablzBvK2Nkpgj94O/98yiUpoRTClno4ROBRR96Qdl4vLcm+CfAO4RVZJ9151Y/iU95fGHcxyxNBQS0YkTFr87xE62U173S1d6lZ83zUTKZF8A37rZHQfIdKnA72jNHpuaFZ6GRG3FStEwb+CL27Ntne57oc8BEtNAWGgOdzA86mOKh5AqfejMDnH81KK/bMy/0eJ30zn8MXJAEn8W7yTwgESya/xknCroIxPUOPQ6HHbxVXTSWb4lC4iCNjRIOgbZhFHEy11Ipgsx3cIQrTXZn+Sy/12ZtGe5q1vTQWOg7dmlCAInQHSJfDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6cOu7CDU0x/Nbb0bW36KQosXPxNepXH5OMrfxlb/Vs8=; b=WfuFVYTGSqoLF+Z1mwVWcA3g9jJ9hV7dAv/t5agrhvpSvMZ/038HJam8mvm3FRWwzGJktk84JpTbb2hmeVwbJtht4zUqV+BSeYvK4mlb1NmM0eORbdhQQSI3pstGjlN4HJJLEuoAhoR5fIs2ZQDu1zN3vo2burkBhgxv5K9rhhDZCh+Gq0gTLFw6tS2aqkSqPsP2wl6a69h+WW+xu2PQ1fumFkMWHRuvd7kbWdLAk9T/dcxST35Ng38D1yysSFbNupicg0uRp9XDcgoSPUzlgqQ3LQRQ3l4B5z+SachsMMaNRnLusiORsBqVg6GRnbB1UM6z9HlMnyog8yzpn0mSdA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cOu7CDU0x/Nbb0bW36KQosXPxNepXH5OMrfxlb/Vs8=; b=a29AX90vyy4SrnQydCxphBVoy3zYT2a1PzypSgeni00V9G9Gi1m7gmOliG2qEnTsaiIF8LxSmSQ3biApewaDkaFW+TA5X4H0CxpTqMKtCdm8AUeZajofCXY85hFcNHWr+yc/LgEWUY/v4tzBevLwfAuID1DOvy/IjpXPWqgMbgo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9d3a0b82d9b4a542 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=czuYf6lSrSHRgOwzcTAQfBIsxF4TkFhriv/mcRkrh/qkNUuIl+Yl5MYX6u+HebX6ssMqEMMMnKHjlFpHX5nrNE3QzZBGCaE+eTTdpHf8VYlW0pL0GEw26bjSKl1hj9Ef43HRw1zTul1ofbvWaIkPNK1YA7pAmEFf9CtX3zKzKn/DJIt1SbYGzY5bg9W2fpaRZXyuIPxqrAb/4LPsF3FOsfoXLLror1uOnrv51bpg2vcohe3s1VfKoMuWVsKK+SA3/0lwKwPVSfL0nNcmEQdLYaHOWejRMRENvcYMCzxQCMdnusHKvakC2uhbpv5d0HUVvz3rm5hCMclHsgoaGX7pwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6cOu7CDU0x/Nbb0bW36KQosXPxNepXH5OMrfxlb/Vs8=; b=i+8L4aJftcxx1xkYpeGypMRmRidOJVUYQP2Jwl1/HGaYVH91RbRxXF/uj87XxpwtIyMD5fX09MsGxCRVtkco6FRHCMJJmU3fs/+QgGjRoGNOV9TN7IobK58PJDOgJ8HmG2GrMYpKF/aCYcQtL9tizdgGXysLPFrwrUxoXnI41BTM5vcE3FCvZb8XdhZPXbO1oMUwf2T3QLYRrLTSbpCC6E4UYqlnuR3ljv/9ktsKjnccrhQo3iUQDfQWK0fcG6fgVQtO5Aj4xEVUK4DlLAKhz+vNmq0wNGNrV9bBAXJmlc2n3sNjJG2URHhFSg0hFY06R3qzz9CJJosZz04L55u/wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cOu7CDU0x/Nbb0bW36KQosXPxNepXH5OMrfxlb/Vs8=; b=a29AX90vyy4SrnQydCxphBVoy3zYT2a1PzypSgeni00V9G9Gi1m7gmOliG2qEnTsaiIF8LxSmSQ3biApewaDkaFW+TA5X4H0CxpTqMKtCdm8AUeZajofCXY85hFcNHWr+yc/LgEWUY/v4tzBevLwfAuID1DOvy/IjpXPWqgMbgo= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Bertrand Marquis , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v2 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Thread-Topic: [PATCH v2 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Thread-Index: AQHYvtDYzitHBxQbZkqmuucOXZ3Boq3Myo0AgAPHJYA= Date: Mon, 5 Sep 2022 09:12:47 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e90627ff-72dc-45b7-3332-08da8f1ed5b1 x-ms-traffictypediagnostic: DB9PR08MB9491:EE_|DBAEUR03FT023:EE_|PAVPR08MB9649:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7MRHOwoxU8KCA93BtT4QdQ5yaHYLACrm7v3axmPfrjT2kqGbr5HVf2m0sNjiVV4cDkbN01v8Y4vmAFFTqwfh6c1wdlDHZ0CnjGe/bR1f/RMxKwBNKCQP5KYWAJmZSTdYoXGJ5NVxSYQsjCxADHtBjtZxKLjMZ+SYbJefcJlHaC9DVouZvyS1Wpnd9TQKQ7mgUsfUVwS+KtSYvwPvuIq6bn/Kj6O0Ws93lLs6BF/ufkVVzPD2WmV7ysq9pB6MdNYDOrlz2UGPlOZoCU818fMy/60nuPFE8232hlOvyDvIcOraTR45dzvyRNYEvkwM16ATRYtfG9Mti8t7PrPKUfdQ/o1lzZvqDwB4e3Oe2P7tdNJZFuc5c75kTlSOxEU4lSQ6HilX90bkGg3UnTYXaoJPAk2y9woLh9AybBq5llBGTgq9DiJfmq+2iya/bTfkEil8XK0LmfG+3tVOfDUkkfPYRhdmr/v9qAScLg6hGmoxC1/wJxv4OPLM2455LK/IBIHkpkRGasLJF5FYQleUFepiYAvKDx1DR2m9vdc/PYbl6zfk3AwwXiWF5M+/1PftB3er0GcmE+t7NfSYp6n015rIiJtfdmO6103+cp4qsaPaDIMCND9CrbuKBCBsZyZXI5rfuBnYgnOIntu93bl0S53IY4cSS3REGK0CMvBKCjADY1diuRSDOWRAQU+ejEYjyq/QxIb8PUerPYoxvaHUgbNZ0NMXwiv9svLOcfmgEM+Qbe0TUaIQx2YBtgWeAYkDmpYuGr3pPhaooLqR0CPsFXNRAPfU0HPQ0Da6WfxMQsBQ8Wo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(366004)(39860400002)(346002)(26005)(53546011)(6512007)(86362001)(6506007)(8936002)(4744005)(2616005)(186003)(5660300002)(33656002)(6486002)(478600001)(71200400001)(41300700001)(36756003)(2906002)(76116006)(66946007)(64756008)(66556008)(6916009)(4326008)(316002)(66446008)(38100700002)(8676002)(66476007)(38070700005)(91956017)(54906003)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <72E11E3EEE68B4448A977B280B060B16@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9491 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f3a19238-d1b8-4c27-90d1-08da8f1ecce9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BRkpCZlV28uT1IAS3RRMDWZ3BrZST3J8VMQYoP+TP6diREBD/gPyZW+EhoCqxxB0NLUzgLNg4tpsUTaxoJdGThBIsnLVJv7cjMsRtWNJLiZaHXCtmbiBtLN4M8fBZxT0u0RXhW1Cg0stvk0TMDqbgveT3GCPNv+VHdphoJk4gqpCB52DuiybF9AsF85q0l/Fn3kmIdy0iBTRX1y6yvUHfGqCj0lahr196rLTPN/jaHS6PgNdWGpgTYHZhRqA1/EvBQSy9S1xrXBU0DotM9s4phNAsV7EVxB4bM8t2pHDFk6OFb2VgFuFqtBNcf+KBpI5ozD7HYN0TjOpu0friGCik77P8bNk3SIK5Vkx50oA+2vU15cmemIMAMgf/Xptsb2cu6IUA0DBHhBZJRG5X9yDF5bCJjlm46Lc/oZLbHryCHYIqRbIJ6LuSURbWzYNPapN4EgJwopamVHlF3lb5zRYGY0vXP0zTp2XcwDiOQJKIg/GccG3rD4I3f8gQca6hjpL/fgMx/hGMUubCNNKRVQ5XM/wNOD1uA6a6fka8qSJzLqyIesTvEWpFDTuvbhsoBBDgajMiaX2CjIuu70EweIyiOH8auri2xgPq0x26MEaq88N8HJadH2DKgsfSKWh+Ug4XihR90Nef9nYDj55xrjE4MLUi6Tf09zUwcPVembx2MV3vSqTjdUf2KoQtyPsfN3ZbAhFAtXy/c55x3X5qMaRFYyP6Lc9QH4/VxE9KkZkwar1PQ6pNoqIYdTA8Obnl6A73THXuUykHV+kdW3hpiYbOg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(46966006)(36840700001)(40470700004)(8936002)(36860700001)(6862004)(5660300002)(40480700001)(4744005)(81166007)(2906002)(356005)(40460700003)(82740400003)(6506007)(6486002)(41300700001)(53546011)(478600001)(82310400005)(107886003)(316002)(54906003)(33656002)(8676002)(4326008)(70206006)(70586007)(6512007)(26005)(336012)(186003)(47076005)(2616005)(86362001)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:13:02.3297 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e90627ff-72dc-45b7-3332-08da8f1ed5b1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9649 Hi Stefano, > On 3 Sep 2022, at 12:31 am, Stefano Stabellini w= rote: >=20 > I checked all the patches against the originals. >=20 > I had comments on patches 3,4,5. >=20 > You can add: >=20 > Acked-by: Stefano Stabellini >=20 > to all the others (1,2,6,7,8,9,10). >=20 =20 Thanks for reviewing the patches. I will add the Acked-By in next version. Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:13:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398632.639519 (Exim 4.92) (envelope-from ) id 1oV8Az-0002fr-D2; Mon, 05 Sep 2022 09:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398632.639519; Mon, 05 Sep 2022 09:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Az-0002fk-9d; Mon, 05 Sep 2022 09:13:53 +0000 Received: by outflank-mailman (input) for mailman id 398632; Mon, 05 Sep 2022 09:13:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Ay-00027Y-6O for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:13:52 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10050.outbound.protection.outlook.com [40.107.1.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e84796f-2cfb-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 11:13:51 +0200 (CEST) Received: from FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) by DBBPR08MB5995.eurprd08.prod.outlook.com (2603:10a6:10:20b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 09:13:47 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::c4) by FR3P281CA0078.outlook.office365.com (2603:10a6:d10:1f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.11 via Frontend Transport; Mon, 5 Sep 2022 09:13:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:13:46 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Mon, 05 Sep 2022 09:13:46 +0000 Received: from c1accd49a49c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6A1F87D9-480B-4A04-85A1-AF86C5352FB4.1; Mon, 05 Sep 2022 09:13:35 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1accd49a49c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 09:13:35 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV1PR08MB7380.eurprd08.prod.outlook.com (2603:10a6:150:24::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Mon, 5 Sep 2022 09:13:33 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 09:13:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e84796f-2cfb-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RPZP91eSjyPJw8MGQV0ZkDhW//nL4DEsUnvyUnGc5mgVrYUix0r5ECz2i/wscsR6frbqm9TO9rO83ALOvfsBxBDZdTPRB0H/TULLNu2cS4Y8bR/vRbj2byjKfIz5Rvkep3CUdVX92Wx+MCiexv37YBgF6jqAAiGGkRX1+1F59NtNI7QdAQYAPw9/v3LSJb1LDzTM5hnb3hc2+ag13yBDUm0sJpenCHMw770VGKsVPQnGioifX7JnRyh8Q94prULqXYFooprBPDrnxUYSmDkrOO3twuCROwVuLvhRJLdA14NTk1CJDHX/E6C0TjH3wH7wPB4/ob75Ujfogxr+hNb+Zg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHCWcaXMERe3FXd6gIa8H2PVDggSzZSrakc57PwMIME=; b=kdLxXMbTmAY4EGI/Rj7UKEqvbELjTBAWOjuxscBIHKbiqBXbLNmyVhJrWGozwM+kVZdNdeS6xUv3RvahkSl7CZF5JtfR+g2hW5bCuXyDdYSmZjvwlg/22JwHGik+o8zyaCXEU9TLsI4HXpCiNLkV3hkxcwADjgwZjumxJTeDNxhaw8z4uN+9JuGS0cknCaIVmmChOV2U6BrM7YLprgaUKIlNu9DpzM6rrf6f26GJEnM1/FC0DqxOI3EtEZlGq4vMKsjYb6n7C97ZDMg3qYGzykW+7+/Lw4hoqJNjjQhzj6AP3A92rzVBoLnSFs5wNhinpUrY0TQgw8j2R3ahjpXK3Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHCWcaXMERe3FXd6gIa8H2PVDggSzZSrakc57PwMIME=; b=Du55bZaqTpSXB1UNDmEdqFu33vUm0YQgT4A5kw6E6i9OgsnZrGeXPo9SmBzyjBk2P/SsE9UuladfhIGIWr0JZB/harKABzZjDOozGboVy6KFhrI+xXEACf555WNU/dNS2WWEwkK3AL69EjXghe2e4xYpAp6XoVCLPkDktkywwtY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: df63ac3dd498b0be X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKhFAFLjVm3llQURixmhBELy8C9mGTXWoEQ6AnUZ6H2U76o7Ag3iJaNlIlJe0ktXXI0XzEFRDPrrnb8eZGLffGmlVaFSPXaRufDyCj1fG8VK8yIhKzkCKWi2/Apesjv8UqtQNtJI91IITTbP7khgBMHPJ5csh9WCOjBqu0Iqgq03Y1KLMF6Z2XZig4n+e+0feO86ZpP36pOhOYXb2MN5vFybs3QkHeYKIvEWx4WlLPGF9a16o6y6/m0gZCAAhkLRpTJcJJ7cscrCR89kjd1bYHwDphFDwh/0hw0FOeHxRK0fkQchsADs0ozkfy9GQhs0UOy9XU6vnoB9ibImWxw+nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHCWcaXMERe3FXd6gIa8H2PVDggSzZSrakc57PwMIME=; b=aBEFzQwtctzEtKC44HZB99CXYMrwVjniE1w1rdPSfTUrKqbLuez07lwmV+OxlAJYtjBSE7B7RfvEMxP9eE+yReY+prx8GoFjS5WKy5ozmp8RS+VHdPg3gWc0L8+FzhI7SepHKdQMQmR4YVtDxH2mJKfKA5NnAZ3nYyXVeJ8EnFu5EISggON2OYD/hhIcomF/Z9C059b1ahbqFezACdMB3/kY2j5NSOSmyIZEuWIouMgz1JrcFic8KlknpaqSEJHceHFOj8FWa1WM+b/QLgZls3iJRcDCMOSlcqX1x+3F9vlWxgkepLIaWbVdR1Bqi56GmSHXb4fr2Api7spTfxVOXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHCWcaXMERe3FXd6gIa8H2PVDggSzZSrakc57PwMIME=; b=Du55bZaqTpSXB1UNDmEdqFu33vUm0YQgT4A5kw6E6i9OgsnZrGeXPo9SmBzyjBk2P/SsE9UuladfhIGIWr0JZB/harKABzZjDOozGboVy6KFhrI+xXEACf555WNU/dNS2WWEwkK3AL69EjXghe2e4xYpAp6XoVCLPkDktkywwtY= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Bertrand Marquis , Robin Murphy , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v2 05/10] xen/arm: smmuv3: Remove the page 1 fixup Thread-Topic: [PATCH v2 05/10] xen/arm: smmuv3: Remove the page 1 fixup Thread-Index: AQHYvtEkIpWQpxSsvEmAc2g+NtYY8q3MxpiAgAPLTwA= Date: Mon, 5 Sep 2022 09:13:32 +0000 Message-ID: <6FAAE725-9372-4A7F-BE3B-A61907EF3088@arm.com> References: <5f6f8233ee5c27082aec27dfc06c6f600f0c5d55.1662123432.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3a769242-ea3d-4c95-0712-08da8f1ef033 x-ms-traffictypediagnostic: GV1PR08MB7380:EE_|VE1EUR03FT029:EE_|DBBPR08MB5995:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Z84+DbJ1OHFna2Qaf8AzDYp9KD9wCE71UcqJ/lcc27URDBIIWI7bMDpFfdGHUJ04Pq9ouxM45TXemGBN70UXLn9FlO30onh+Op47u08PFNYm3YebYHhTkrkhBwHog6JuWrTrF8WTa84cQ+G/g7nesi85AQzag9ECCR4IfAIAy2adV3QNGmhG1WNZvJoEGw8p3GfN0Q6PYFzJeQNnw6ufHOJyadTsZU0czIwge5n3rzSNgvYeiLQGTGllAnrFhhJGJWpfbXw1KNBTPuLxEKUqMnj3fzUWMpH3MoXgZSmEIY3SfOXlJCGo8vu/7gtE41DncghxZR4KvUGFR1iU57sHRl2VseQFDd//avtDhzEDlq+pHgOz+W1m1IY81OIBOqJvnMF5nEHTpPqYSx/yrQqeb2dpSV/XQDGOZwAg0TW+cLs+UWr/fgjfkRGG9Js0o38UmTVWBtAtTmXR/9gS6EBq2J1I14GbcOaNqLQenNHhWsoEn1eEP2QeNdqTba4eXpsKFo0ZK3DApZeGHh43CyPqJiV/WSg+nxWsfT9mxp3eK3zF2t9p6GWJUQ7oHEW36Yd17gAkxqr8OfrBFUbSax/8YzCs/tZb3S5bxPMY7lxm+6tRUifF87uhN2wawi7zxCx6ZqA5psvB4itJ1XFiMJiuZdbQazEPnrTRgzxbXQxiA6uynI+fwziehyP68ngvEmMHxfparXM8zOwARdVUE/06EZs805tV7Tce9ssoL28uKoVYzdG2DiXqTechvx83RNNO5QBxQZeGxwZ5urzp4ZMH00WXssRSs0tp7N7qlWcnu08= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(122000001)(66556008)(8676002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(91956017)(2616005)(38100700002)(6486002)(41300700001)(71200400001)(186003)(26005)(6506007)(53546011)(54906003)(6512007)(6916009)(316002)(83380400001)(36756003)(2906002)(86362001)(33656002)(5660300002)(8936002)(478600001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <115CA7EE4AA58F42B478A21708AD0164@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7380 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7901fba8-fe78-43c8-96e6-08da8f1ee7ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4si/JyIVShrU470buEJM50ewP1YWXE+2KJzmMq9ZtQzdGpFre5Yd99+EKBLV4ZTABBXuSNk3c8Dc4WT7ojwAYjFN7A4jm/mJ4vmjU744HT2Qujn5ITCOWD8I52xwOiRgT3jTnWiMgLS/YNgLihkSjDZ4MqvTxn+3OJXzHmblPDcyQ1zgx1HffiJQ347nN6h/IMrj4YlVA1ETKdkU4MX4jjyY1+rDUGHXNv1JXOgPvKclgpQgKUD4811GGRBrI7keTHeI0Guq8nUT8QPvoUq4g0pkwZS16ep9IyXlvumnzkgHr9KkpAVVougjOZolLKYAxDXExw5GzdRDNAYhUFLvZhi4R8Be18G1+ZmuE5G6297V3VOuJEPo0NlxAOnd80BV7G6wdDUz5rBW+lGHwzKD9NnYs83ePzjvxJjqkoO7OODPWqTZKzuAThTh8awQOPWXWlric4C4nvTBgLcnvJrYF+HzGMk3AW6mjyDkZXdVOuIIQlX8f2dh27rRmrTg5ODqtwzUgmdFMUt1UG9KAt52X9N5qekV2eclYRD6gOrQQKOEsW4oEN3zv4r5+97+vvyCez28t+OlRX74hUM8ISL2kMitQ5LndRKPwjmeFPHUUzJltpPYPsi5m5yPgaw2Y3q6vZt9CB/FBU7ueDnFh9l9mX67iGh7up9DtrJbJNIKvVsJ7OevM8DzwiIfYcrakyj+Cr8qVvQyRk4qXAR0RDgrRWhQ/FX1WuEhe2AgQjkm0oaUra1+JYByU0wwflAN35nlHH2j6VX6LxsNK5/dqF+rPw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(396003)(346002)(376002)(36840700001)(40470700004)(46966006)(83380400001)(4326008)(8676002)(336012)(47076005)(70586007)(70206006)(36860700001)(8936002)(6862004)(33656002)(5660300002)(107886003)(6506007)(53546011)(478600001)(26005)(6486002)(41300700001)(186003)(2616005)(86362001)(316002)(54906003)(82310400005)(40480700001)(40460700003)(6512007)(36756003)(81166007)(82740400003)(2906002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:13:46.6919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a769242-ea3d-4c95-0712-08da8f1ef033 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5995 Hi Stefano, > On 3 Sep 2022, at 12:17 am, Stefano Stabellini w= rote: >=20 > On Fri, 2 Sep 2022, Rahul Singh wrote: >> From: Robin Murphy >>=20 >> Backport Linux commit 86d2d9214880. This is the clean backport without >> any changes. >>=20 >> Since we now keep track of page 1 via a separate pointer that >> already encapsulates aliasing to page 0 as necessary, we can remove >> the clunky fixup routine and simply use the relevant bases directly. >> The current architecture spec (IHI0070D.a) defines >> SMMU_{EVENTQ,PRIQ}_{PROD,CONS} as offsets relative to page 1, so the >> cleanup represents a little bit of convergence as well as just >> lines of code saved. >>=20 >> Signed-off-by: Robin Murphy >> Signed-off-by: Will Deacon >> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git= 86d2d9214880 >> Signed-off-by: Rahul Singh >> --- >> Changes in v2: >> - fix commit msg. >> --- >> xen/drivers/passthrough/arm/smmu-v3.c | 42 ++++++++++----------------- >> xen/drivers/passthrough/arm/smmu-v3.h | 8 ++--- >> 2 files changed, 20 insertions(+), 30 deletions(-) >>=20 >> diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthr= ough/arm/smmu-v3.c >> index 85ad066266..f5485a8a1c 100644 >> --- a/xen/drivers/passthrough/arm/smmu-v3.c >> +++ b/xen/drivers/passthrough/arm/smmu-v3.c >> @@ -235,15 +235,6 @@ static struct arm_smmu_option_prop arm_smmu_options= [] =3D { >> { 0, NULL}, >> }; >>=20 >> -static inline void __iomem *arm_smmu_page1_fixup(unsigned long offset, >> - struct arm_smmu_device *smmu) >> -{ >> - if (offset > SZ_64K) >> - return smmu->page1 + offset - SZ_64K; >> - >> - return smmu->base + offset; >> -} >> - >> static struct arm_smmu_domain *to_smmu_domain(struct iommu_domain *dom) >> { >> return container_of(dom, struct arm_smmu_domain, domain); >> @@ -1578,6 +1569,7 @@ static int arm_smmu_dt_xlate(struct device *dev, >> /* Probing and initialisation functions */ >> static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, >> struct arm_smmu_queue *q, >> + void __iomem *page, >> unsigned long prod_off, >> unsigned long cons_off, >> size_t dwords, const char *name) >> @@ -1606,8 +1598,8 @@ static int arm_smmu_init_one_queue(struct arm_smmu= _device *smmu, >> 1 << q->llq.max_n_shift, name); >> } >>=20 >> - q->prod_reg =3D arm_smmu_page1_fixup(prod_off, smmu); >> - q->cons_reg =3D arm_smmu_page1_fixup(cons_off, smmu); >> + q->prod_reg =3D page + prod_off; >> + q->cons_reg =3D page + prod_off; >=20 > In the original patch it was: >=20 > - q->prod_reg =3D arm_smmu_page1_fixup(prod_off, smmu); > - q->cons_reg =3D arm_smmu_page1_fixup(cons_off, smmu); > + q->prod_reg =3D page + prod_off; > + q->cons_reg =3D page + cons_off; >=20 > Specifically the second line seems to be wrong here? Yes you are right I somehow miss that . I will fix that. Regards. Rahul From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:16:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:16:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398641.639529 (Exim 4.92) (envelope-from ) id 1oV8Di-0003Pg-VK; Mon, 05 Sep 2022 09:16:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398641.639529; Mon, 05 Sep 2022 09:16:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Di-0003PZ-So; Mon, 05 Sep 2022 09:16:42 +0000 Received: by outflank-mailman (input) for mailman id 398641; Mon, 05 Sep 2022 09:16:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Dh-0003PQ-8Y for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:16:41 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2075.outbound.protection.outlook.com [40.107.94.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7242b572-2cfb-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 11:16:39 +0200 (CEST) Received: from MN2PR15CA0022.namprd15.prod.outlook.com (2603:10b6:208:1b4::35) by IA1PR12MB6042.namprd12.prod.outlook.com (2603:10b6:208:3d6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Mon, 5 Sep 2022 09:16:36 +0000 Received: from BL02EPF0000C405.namprd05.prod.outlook.com (2603:10b6:208:1b4:cafe::a2) by MN2PR15CA0022.outlook.office365.com (2603:10b6:208:1b4::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 09:16:36 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000C405.mail.protection.outlook.com (10.167.241.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.10 via Frontend Transport; Mon, 5 Sep 2022 09:16:35 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 04:16:35 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 04:16:34 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 5 Sep 2022 04:16:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7242b572-2cfb-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLgeAxttNn54vlxZWAB5m37D8eq/zgvWYN6WKgxC8aPxQlGoIgCd5LMs/dWKJBlv20939reHy0Ot6pihvgFnLTvLtWtkv94frQ6JVVIiPmfB5zHMvM/+8SPo5BGBPWTvL6gaqBj0DOIUHWDolXNvC+MmB6LvByu7nePLbaGUbfp2+vYMGV0fCoQvHqbWiHISIAOLO42SeB1YUfe/OzrtD1zVWd6bpxLjERzZlF8Ip0lG1oHBhuVYTDeVzm2MMR9wM+/Rz51QFl0+qqePN3ZUyoqvamSnYHgmqb7O+5lGPZW56VONJOAI2T7Tz3aGOo1v2WErYfkWiCO1fj9dGOmv9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jtmLFL+3KZ8xG33Tl3+dVb7YfA4SCCuaU6TuGlBgmlw=; b=SiIXkCVxq8yq4rVXoH+ZTqzBGC2stwpbMdbPjtMzuYCbDAw8pj0tJ14MBDfup5jg8unxjrEZQ1r8Y1SjyYMuAmuiGR7mzezguqn17fLdJYCUud7qp98hsV5BixX4bIZHb2/uRSCCamUKkKTIFkNfHpMiemfSBzW1egxN/VYmwjpz3o/IvkF/cdKKkHnIPL5uojdXEI296euBX5EvnkpGNDcxee9oosaHqjH6f2IHEFkdhhKQtSKPlXWWFW/UE2cMG8GidPP3J9T+CZQ0h3OWrjNkO3Zr2UNq47pUrKuFxyV0aO6shU3xkzD5EFPrZU/Hmjikgw9JytpNUCuDPF15wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jtmLFL+3KZ8xG33Tl3+dVb7YfA4SCCuaU6TuGlBgmlw=; b=balsLUaFUrL7fCXZar+iysLoozPMbSDiUzyh+o0GV/+JstxmmJegzjCM3zIGL6SwP5GFkzaHI3hv8/qW38yHTYXOrCoI3qwjIJvqLMXU2JtyzCcVPQs3UAle0n7d2qqL8Mt0XQ5EL3mNoIJKTH+50zcT11xBDF3iXlKQNeNpb1Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <865125f7-9a15-6495-051a-64b08d6555d6@amd.com> Date: Mon, 5 Sep 2022 11:16:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int Content-Language: en-US To: Henry Wang , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-3-Henry.Wang@arm.com> From: Michal Orzel In-Reply-To: <20220905072635.16294-3-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000C405:EE_|IA1PR12MB6042:EE_ X-MS-Office365-Filtering-Correlation-Id: 71c59d6d-8a8b-4e81-218e-08da8f1f54e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aeQCWT5AWUqlTskiAbNafSh9eDiMMZEtegJWzecGKElTkz9odmP4m0RYG2nitcH+/4TTTFdeNOGH2UPQpG3wkAWxpIsdtpmlpWVT9s/jiGd0s7PNNToZpg9yFGfCH4RmuLnUIq0gK+LHbvFgh7qEBSp/5sgPKI+HSRmxMru3qiBe8OdJi4Nh+a89kUUhI/KTuXW9t2q/g2xWP+bW1bJSkgBr+pz/v1CcWGZWE0GHIbZ8pCkAQ82rUw2cvOy46rfuU/EFTzrPPoa3fjb6ri+cL5fuyebLwDV8l8DivHmll4J5cXAB7xW4+0kkmIYu3lxcUOTK5ldjM+6o0Gg5BsXggPaAFSEsOmzAUQ6Gkk9AoHb3aeiuYUjbvPbxBNBVJgytnUtfwe2iDxjqJK+RImM6LDz/gXl2jqkQ23xW3y6b/NvoV+z6Us9BfqnRGWD4tMZB2FbKD5wmEGzut3PoTrkm8OJmKX/k5Q/xrl0NJMVSUVuoR/hn455Vx1XrSkIA+sX0+MpAkIPvVkCSFzeBb0v50M2zdVblA7uyjNPc+rm4uVrKR1OZspH5bUZQI+M70YTSRsck2Fsb/T95cROkqcCFKRVhXH/K+M8J0zBI3TnkhlbxczayWdm/Vp1kj9LnyD4dWKil4r839vr5mpheWsMPVc496jPSKQ91uU3vE8jJGw5nVfR7vsa9YFXcIP+rvssdQzV+zC6UKjNhllK8yASmicaRqKK6iaPXkAsARpilS4jTUg05lhBm7/p0cwWo/bKxxLkzAmCv+d4mZZnF696PSJpAVPePfCQAMxamtz/tivwAupsPOFTETUycklDBWgcismAf+50XH/rkjjYAP85cBQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(40470700004)(36840700001)(47076005)(26005)(53546011)(426003)(2616005)(336012)(186003)(36860700001)(356005)(82740400003)(81166007)(8936002)(5660300002)(8676002)(82310400005)(40480700001)(70206006)(36756003)(4326008)(2906002)(44832011)(4744005)(70586007)(54906003)(40460700003)(31686004)(478600001)(31696002)(41300700001)(86362001)(110136005)(16576012)(316002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:16:35.6297 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71c59d6d-8a8b-4e81-218e-08da8f1f54e0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000C405.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6042 Hi Henry, On 05/09/2022 09:26, Henry Wang wrote: > > At the boot time, it is saner to stop booting early if an error occurs > when parsing the device tree chosen node, rather than seeing random > behavior afterwards. Therefore, this commit changes the return type of > the process_chosen_node() from void to int, and return correct errno > based on the error type. > > Signed-off-by: Henry Wang > --- > Changes from v1 to v2: > - New commit. > --- The patch looks good but I think it should be put as the first one in the series as this is a natural prerequisite for the introduction of the reserved heap. This will also help not to modify the same reserved heap code you introduced in the first patch. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:18:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:18:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398648.639541 (Exim 4.92) (envelope-from ) id 1oV8Ez-0003yd-B9; Mon, 05 Sep 2022 09:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398648.639541; Mon, 05 Sep 2022 09:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Ez-0003yU-8D; Mon, 05 Sep 2022 09:18:01 +0000 Received: by outflank-mailman (input) for mailman id 398648; Mon, 05 Sep 2022 09:18:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Ey-0003yM-3s for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:18:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Ex-00065c-PH; Mon, 05 Sep 2022 09:17:59 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oV8Ex-0004t5-If; Mon, 05 Sep 2022 09:17:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lzc6LczOLY1m3dTsd82GgGKmhnO3m4aF7TR0EcG0clI=; b=QXiSQZWyHl4Xk7brJ/O/HWBdfK PnP3sW/BQAJfp3jDfncbzXogXC7Xtg1OM2cuhUtHntOEea2wyMLGB5sFxvDe45Jzkq2vh9/d0xiQr 0bUWoomnty9R1KykyYpKZ2IbnCqadYzxygS+wI1fsHa0FtkZ4Qljarw/JK+1ihTsqBOw=; Message-ID: <80bfb53c-8aae-bd33-18db-d06c04b18f51@xen.org> Date: Mon, 5 Sep 2022 10:17:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int Content-Language: en-US To: Michal Orzel , Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-3-Henry.Wang@arm.com> <865125f7-9a15-6495-051a-64b08d6555d6@amd.com> From: Julien Grall In-Reply-To: <865125f7-9a15-6495-051a-64b08d6555d6@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/09/2022 10:16, Michal Orzel wrote: > Hi Henry, > > On 05/09/2022 09:26, Henry Wang wrote: >> >> At the boot time, it is saner to stop booting early if an error occurs >> when parsing the device tree chosen node, rather than seeing random >> behavior afterwards. Therefore, this commit changes the return type of >> the process_chosen_node() from void to int, and return correct errno >> based on the error type. >> >> Signed-off-by: Henry Wang >> --- >> Changes from v1 to v2: >> - New commit. >> --- > > The patch looks good but I think it should be put as the first one in the series > as this is a natural prerequisite for the introduction of the reserved heap. This > will also help not to modify the same reserved heap code you introduced in the first patch. +1. The same could be said with patch #4. The renaming should be before patch #3. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398655.639552 (Exim 4.92) (envelope-from ) id 1oV8Fs-0004a3-Kh; Mon, 05 Sep 2022 09:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398655.639552; Mon, 05 Sep 2022 09:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Fs-0004Zu-Hv; Mon, 05 Sep 2022 09:18:56 +0000 Received: by outflank-mailman (input) for mailman id 398655; Mon, 05 Sep 2022 09:18:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Fr-0004Za-1V for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:18:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2048.outbound.protection.outlook.com [40.107.22.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c2f3aa30-2cfb-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 11:18:54 +0200 (CEST) Received: from DB7PR03CA0089.eurprd03.prod.outlook.com (2603:10a6:10:72::30) by DBBPR08MB6138.eurprd08.prod.outlook.com (2603:10a6:10:205::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 09:18:52 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::73) by DB7PR03CA0089.outlook.office365.com (2603:10a6:10:72::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 09:18:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:18:52 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 05 Sep 2022 09:18:51 +0000 Received: from 75bc5b9e03e1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8586AD73-D807-4FF1-B977-CE33A47864FB.1; Mon, 05 Sep 2022 09:18:44 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75bc5b9e03e1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 09:18:44 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AS2PR08MB8362.eurprd08.prod.outlook.com (2603:10a6:20b:545::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 09:18:43 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 09:18:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2f3aa30-2cfb-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Kop3AoSVgR10dFWQaqbw2NqFzeR9dryr6dN9X4dgdx6j6OgnxypM7ZXV/ROj8Oa/hRIeSwdXb852sNIxnRlXgOieBbgJv2oKzStEbyQ1ce+TQZzJkwVa39tgT6Rfof4u1IqNOjM4ltBGBgd27rRa4XbI4Egx/QI2q50N9vE8/tv958HO/ou7Jzsub6+o5Ng5OKJvKUJscNyuY3eV4IRsvnOZB8EaMcgCqjpYAMYDSehB1cuvCCKUrmWoOHvbyki813V95UAfOtWUcKzWu3+ZNV+hz3OVC/vUpC72cZ6q5dnO1m5oNCswaBCkAUYMH+uqgvhpMBdde6bnW8vM6emDvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWAw9AizrppWbMqtmNqglZxSrRobWCsQT9g/gRle4DY=; b=EwK6M4hv/UHsvTf6BpRA/8HdXKEmlJ6r6yPuQ2lEwbln/AFdiBgd5yofAVO2IzWFgE1TnbmX/qeye/A1jI+L/OlpfT/iRyr9gtwyVoOvSpRpevzg25RsppI0RIvd8oahRZ5hfRGnaaKZ6o/7rMfjQi84d1ysbnIwIOgQv5eyCV3ukz921rPs5J64ivqunI9c11jLvX4WGPz/cw5iP8ss9xVh/uOTkv1dbmmDhINEujzI1zFqTdCOsclkpFA3aKzAhPpIWo04pKKUAnJY5elBhm2uwTilHFDKT4qbbVct7L1WejcDpAT6WrLy2ElOuZ3YtqNcIuMZpWt7JrbECAj0JQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWAw9AizrppWbMqtmNqglZxSrRobWCsQT9g/gRle4DY=; b=H1R5NxOSo/vw4HFAxe5ncgIRN6d/r4K0JQw0plVTfqnXDib87XSF6ktCKXaIGrQHqOQ8BkwnwCzH99ur4LVdSU7OMPpZkh3Ywakj9lh0qtPCRJkeo6hhE/I19VsTVnoFqpmkGK0GFsbGQW12sXMAJNsFZwcwEM0zebquhU2sDcs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a9209b7d0169f453 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LwoLB8XQ2OtWeSXu3z6yZISZoBXdcUITQ5BL8t+XVzzvxaiUqsHGwa2uaAeP4QpzEygCFIvkVYjZRnGJJk+whfnYXiWs/bp4eFSzI6m5q3p7laeEfus0hR20UEfRij7/74/RqhZuA3Eox3MjYaqVj3wPLibbg8k2/8son6a30CRwIKHatyqeGK25hbMVF5BxC8dQSmeQrgO3//UvXSzvbsgS2HPyJNoqBWB9jqac7OWi2rhPtNDi85gz6LCUo25ftKzMPB+7y6rjMl6nRsb2PkCx4gw5KvVYuNwdHlqy2L+ytXWiEFNEYJu9y21/8sYuY+M6WjEAhUjCr20QAhYevQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWAw9AizrppWbMqtmNqglZxSrRobWCsQT9g/gRle4DY=; b=Hg67Eo6/eCsUBnJLa4N2R1FcWSY/5Ll+6594HDfcTit/Qb+osMgy1zft1WwFM8dWoWgPrzVtaEG3gofghYhpJ2mdOHCt0OyN5KY4AkE4dR0Rg02BenUOLalvdN3wCQ7H3unDdJ/8vhku9LszRBqnqQ2hYJpcpxiseOw9T2LIg4YpI/DkYM6jlx5zYdBR+rUiqhv54kGnYrDCBcXxVG1e0UyUXqRW5OaPCdKbKNpSWdSoXlSg3h2/ecYWHJpol5BjJKTM33Ujw6Zun0GXu3mmdwKBFp39iSqsfrXpH3vA3eP+eWhexgl2NNzv4a3XQbc4ljGxA2LMVMbkmhXN+5MiJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWAw9AizrppWbMqtmNqglZxSrRobWCsQT9g/gRle4DY=; b=H1R5NxOSo/vw4HFAxe5ncgIRN6d/r4K0JQw0plVTfqnXDib87XSF6ktCKXaIGrQHqOQ8BkwnwCzH99ur4LVdSU7OMPpZkh3Ywakj9lh0qtPCRJkeo6hhE/I19VsTVnoFqpmkGK0GFsbGQW12sXMAJNsFZwcwEM0zebquhU2sDcs= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Bertrand Marquis , Zhou Wang , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Topic: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Index: AQHYvtEAJSRg4g4gWEG/XWmXvqw9I63Mx8YAgAPLkwA= Date: Mon, 5 Sep 2022 09:18:43 +0000 Message-ID: References: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 56e40c8c-ac96-49e4-af76-08da8f1fa624 x-ms-traffictypediagnostic: AS2PR08MB8362:EE_|DBAEUR03FT007:EE_|DBBPR08MB6138:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4aAZ0YnWTRzupsOJUim7FD49cJ/ur0UpQtDHdxp8/mTLG7Zjg8zC1YCW5moxxDr7L3CqQ/wi636UGJk1Qsy39ldDCTN8aJyjtywyH02rQWPXnOKNnM4XeE/4wnGvrdpC1KrAmVxsacpkhf81xXo2s7bGHVdh0JVpctEObOsOPP7bgMnPr4gPQwZO0Pw3u/iaVnNboyK0A2MnjkWerrA7pIkavwnvCiJawx4KnUSGcqv+KUbZ43g1qXIvAKHpS+wbtjAtU9GCHG0G4lb6qNUU7pJ5mMVc4hQAqQwVSiHjDNepuE2P4ug8lBWErdDA+qQmkDOoUlJ2DJ0WCt1NUBmh21GpD6HFqW4HHIXkDYGPvjGMrkZ+nnqttB5Oy9nqtau3FbbcHdRcxxFVwNFEECm66lyp1XdpP8H/fug+iLJMOWR1QgQqrFZyJVWAgX2Z7yKT0KWv8eWKN18UOD6TCFsVtNHDDbPlAIEirn1m0Ngfvljq3Q7UAWmWzGjbOs47Fuuh800m3qj0omu0v1mQv+dR1PAlVWwYVag2Zepf+4d/Vtk3JHOTbQ4fW4StGPUlN0tTfR+gSTfQyuqeDLzgLv8+la4PuBVA93SmZFXSgVYwsZs686VoXUqSf5fo6kOnbuVb3rMQlIjSY/1KvH8Zx9upju8r3nUBmOcyw5jANyfpv4wpho3DJ9kE2JCxfOQU9KloLE4cUZfakQDnPqGm2Vs5WlWaVt7FxE4uyg2RfTLSlHxB2w19XaXRpHg43Lb0SEEwRsvUYcrQGwTCJCRFuBpcmIx5tkLIg0w1UaCkF12HKqSRxTZFSqoYTVVOdAlpzrvAxkr79YZZRIrICFwVJlH+lw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(5660300002)(478600001)(66446008)(122000001)(83380400001)(36756003)(38070700005)(33656002)(8936002)(316002)(2906002)(26005)(966005)(53546011)(71200400001)(2616005)(66476007)(6506007)(91956017)(66556008)(66946007)(76116006)(186003)(6512007)(4326008)(8676002)(54906003)(6916009)(41300700001)(86362001)(38100700002)(64756008)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8362 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e1452d54-4967-4e11-98cc-08da8f1fa0f8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +WkcP7cwMlY1Yrgk/czK7chH/3H2Kq1iiUXDxF4RY1f0o/FKGfzyFl4fk+SA0UmMUupvajAt+1FZfC/4BiWyIhSFveSTLOwxlwEf8J3wU/f5F5VUS8ceSEjPv7ifO2q2z0dHir1urcZl7WyxG/8I+OJIb1kSdFerOkXFnt2iqF9uCxKv4oCIUgYTwOnnLtbt2Z0dFzioyp530pD7lU8y10uch+LmXRsqsN1wEpVpyYbUHsnytYSNO/4OAjc0dfC6LNv9nFaZ0mR0PZJZGsP5+nh8jsW0U6ViP+pvWHzijGbjQrJaOmn2pw9EjdPchMc4sUBVl1/qaK0T6WXr7qky87LqSGweqnASknSAZpg3jh3+AETHCgxYpoSzTogEHwHA4a8gwpL3gfRXH4NfiMQdsxlu7IaHhyCXEfkW+NHqu5XiS7AujZQES46cH5bQPqdRExlIW71Aa2GE2VtK6Ued3rvHoZajgTqDiADIMb38Vmw9ZJfThFhK96RChk/PmZuCK278Ik/SMXwYwzGX+JvnnireGYgPSz4+rFn2DN/w9Z7EZ6VQBfs3TPz4rPgUQ4NUuqakodi3tDSOq1FlDdvPX6zhjdmfccbgEXVtCeh/bTqQSXB1LE/GjNWy6FKJZt8zlGa3Q5V8QGzi1r7LLaiA8VgHpVfz0ZxQLCZK0hUBSuTrP8NeaGAPtrE+/mIUl1VjPEdBG73dWK2pXtTLCq1TgYEwUSgc5OYfOrN7O11pA9YpgGcouSFuQoQuk0NNzi5BWXr/Z8QqLCDOqhcQ/Ehwv00LvsHnqxiMSc5sW5lPFL8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(136003)(39860400002)(36840700001)(40470700004)(46966006)(36756003)(40460700003)(54906003)(316002)(82310400005)(40480700001)(6512007)(356005)(81166007)(82740400003)(2906002)(86362001)(36860700001)(6862004)(8936002)(5660300002)(83380400001)(33656002)(4326008)(8676002)(47076005)(70206006)(70586007)(336012)(966005)(6486002)(41300700001)(2616005)(186003)(6506007)(107886003)(478600001)(26005)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:18:52.0370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56e40c8c-ac96-49e4-af76-08da8f1fa624 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6138 Hi Stefano, > On 3 Sep 2022, at 12:21 am, Stefano Stabellini w= rote: >=20 > On Fri, 2 Sep 2022, Rahul Singh wrote: >> From: Zhou Wang >>=20 >> Backport Linux commit a76a37777f2c. This is the clean backport without >> any changes. >>=20 >> Reading the 'prod' MMIO register in order to determine whether or >> not there is valid data beyond 'cons' for a given queue does not >> provide sufficient dependency ordering, as the resulting access is >> address dependent only on 'cons' and can therefore be speculated >> ahead of time, potentially allowing stale data to be read by the >> CPU. >>=20 >> Use readl() instead of readl_relaxed() when updating the shadow copy >> of the 'prod' pointer, so that all speculated memory reads from the >> corresponding queue can occur only from valid slots. >>=20 >> Signed-off-by: Zhou Wang >> Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangz= hou1@hisilicon.com >> [will: Use readl() instead of explicit barrier. Update 'cons' side to ma= tch.] >> Signed-off-by: Will Deacon >> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git= a76a37777f2c >> Signed-off-by: Rahul Singh >> --- >> Changes in v2: >> - fix commit msg >> - add _iomb changes also from the origin patch >> --- >> xen/arch/arm/include/asm/system.h | 1 + >> xen/drivers/passthrough/arm/smmu-v3.c | 11 +++++++++-- >> 2 files changed, 10 insertions(+), 2 deletions(-) >>=20 >> diff --git a/xen/arch/arm/include/asm/system.h b/xen/arch/arm/include/as= m/system.h >> index 65d5c8e423..fe27cf8c5e 100644 >> --- a/xen/arch/arm/include/asm/system.h >> +++ b/xen/arch/arm/include/asm/system.h >> @@ -29,6 +29,7 @@ >> #endif >>=20 >> #define smp_wmb() dmb(ishst) >> +#define __iomb() dmb(osh) >=20 > We don't have any other #define starting with __ in system.h. > I wonder if we should call this macro differently or simply iomb(). =20 I think either iomb() or dma_mb() will be the right name. Please let me know your view on this. Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:21:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:21:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398662.639563 (Exim 4.92) (envelope-from ) id 1oV8I9-000610-0x; Mon, 05 Sep 2022 09:21:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398662.639563; Mon, 05 Sep 2022 09:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8I8-00060r-UB; Mon, 05 Sep 2022 09:21:16 +0000 Received: by outflank-mailman (input) for mailman id 398662; Mon, 05 Sep 2022 09:21:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8I7-00060f-77 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:21:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16758c8e-2cfc-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 11:21:14 +0200 (CEST) Received: from AS8P189CA0051.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::34) by AS2PR08MB8287.eurprd08.prod.outlook.com (2603:10a6:20b:556::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 09:21:12 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:458:cafe::9b) by AS8P189CA0051.outlook.office365.com (2603:10a6:20b:458::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:21:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 09:21:11 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 05 Sep 2022 09:21:11 +0000 Received: from 3fc51c039d09.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F71BDE32-4D75-4404-95BC-0EB5DAEC7B7D.1; Mon, 05 Sep 2022 09:21:05 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3fc51c039d09.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 09:21:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB9139.eurprd08.prod.outlook.com (2603:10a6:102:30c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Mon, 5 Sep 2022 09:21:02 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Mon, 5 Sep 2022 09:21:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16758c8e-2cfc-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oWiJbPR1WxA3OyPn66YfBvikfD8QdM0dv+Qr+koe/vFYJlny/R/UTP+SktixVgln74Seg1n2m98Hqu2O4okaRsyWIlfRzyOzSvSkElfiqnqhaDhCF4DPQE9gGWUzvm52BBced6GBvajBlcBIzPdIyGREN+urvsrJxN0CJv3biywGJBWG2UnG4B9MRV+u5VWOdItG5VCeiARg+oesA77MiTcqg/euawU12gjnshO875B6aCHTqtEWrZlag1BGXbgljEFuiPio7ytOj5+AVLbDO87vxzpw/Y4D0idN74oxqdJctO+GBH9dsO4EKs0/5SIyscHr7KIE9qJI5NTEKymx1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alDDSy3Dus7nIEmIncxGZP4cuawpPGwz/Hp4/9DrTt4=; b=RnAr8AK3VH5w6+XUTlyr2aP/s44FzmCk4YVJGl3MBDg079HJDc4ifkOHGBX7ZfHSjXv3DpP3jqEx0sVVo418jb22rIHtewNToYwbOFY7lulpxu/QQebERNVBranLVNQ9swXmBV3EnBjZlKTf85GLPsfG4GuwgIhalWD6pj5CSoby0Fuwf3F89KREMvKNX89CrFRI6qJ+Klja4ZOXJofRx0gu8sjbNJxCN1yzfkzPPIgIuiHmtjgHJ8q8ZOH7SNkSjxA1CoVvaYBFwstrcEgRo840PUrw9ozOkc/Dm69+3PxilaEIPTJ7qSK3Ia0jLenzCWroAgzJau7CCJG5Sy6Juw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alDDSy3Dus7nIEmIncxGZP4cuawpPGwz/Hp4/9DrTt4=; b=gXTisBypvJlbV7A2ydV5yuDlkCUHtoOoOXxHfD2j9UpnhfWTZAYiWUykClkGgByLxm2JlpISSD5OEJWXgKmaBCJfUlQbVBqwNXGI4L8vW1daRUNUkOwpvxoNd8twJGH+ScG00gXFAsDDqXHq3CnnLsCXzafPSusyNrNmDkPW3M4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lovgu3ozbg26JKNfSu7ebG8/1J/rmIrm1d4eGptyBQPVg5hGrZ3oIQjLf8a3WB/WooVPJl+9Y0tfXaLPV8gfXTm+nuXQ4plVi2sj4FOiHHN88MmvSQakyiJY3e+ttUsyAEsjvcI67fNdo3P/mmZfPJ7kJFZk3YtOj1sc/Gi8QPkBj9+xqXGoYPytP6lEj3W/+EUTsJ52iImj9t4NaGlJtdCkaTYEXLiivxUWRQSHOaywDVBDy18Sob+pffwWlEmG9KP9+mlFluqb1S58YtMLe17rCTfBWjzbJOKI/okJiAryO1sNiiwP4y502zyQwRVok1A1jL7tlL2Js4cJTaZpTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alDDSy3Dus7nIEmIncxGZP4cuawpPGwz/Hp4/9DrTt4=; b=IyLAWCfvyuGV7J6qwwWk5+Qrd8nSQwI6UYMvPrNaZdiHKfHN5mdqF1Rp9PFAiQoEyeiSMxEMepGMwkBo9j1nLTVi6JM/BYB5s4nJ8/fZ/IsiYmZRc+61xtg/L0TeuCcPm04s7xACDzuCMnSW0PPJm5DbxEht/GVI+M5ZzohhzAJ+KrhjBJ7HTzGeFdoznJGIigroKxIAengGnPe7prWoQPJPl2/lClbPTxAgBZlB8ls2Ie3qhtI/MJNMCemd7G6iL9bVnCnd5BTtkGK72TMxuYUgleZWiyw+8WRuByhrLqoMcRUgMmhNKRxnTt0xO38NhyT8nVbt1/Zeh+uuY7lAKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alDDSy3Dus7nIEmIncxGZP4cuawpPGwz/Hp4/9DrTt4=; b=gXTisBypvJlbV7A2ydV5yuDlkCUHtoOoOXxHfD2j9UpnhfWTZAYiWUykClkGgByLxm2JlpISSD5OEJWXgKmaBCJfUlQbVBqwNXGI4L8vW1daRUNUkOwpvxoNd8twJGH+ScG00gXFAsDDqXHq3CnnLsCXzafPSusyNrNmDkPW3M4= From: Henry Wang To: Julien Grall , Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int Thread-Topic: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int Thread-Index: AQHYwPjyVgMKyZ6Cs020VCbItAD6Y63Qjm4AgAAAZYCAAABZkA== Date: Mon, 5 Sep 2022 09:21:01 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-3-Henry.Wang@arm.com> <865125f7-9a15-6495-051a-64b08d6555d6@amd.com> <80bfb53c-8aae-bd33-18db-d06c04b18f51@xen.org> In-Reply-To: <80bfb53c-8aae-bd33-18db-d06c04b18f51@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4277765BED140648963FC827C75AECAE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e7d7ae88-8b20-4134-5de6-08da8f1ff91e x-ms-traffictypediagnostic: PAVPR08MB9139:EE_|AM7EUR03FT023:EE_|AS2PR08MB8287:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: e5576NaR8Oqde1kVT0UZ4JClRgwHZBSDE37G5RFMcc/3TALBNisXY7JJ392WMtJeg+uJBeG0/yp+ubiyhFi8aLgxxI8v9UCAiv2AQiVUO06bWgjv1iyiF3rhZnSezhfzlX0KVB3Md2KfvVtZnO7GPkCGMQChGkD2A0z2WJkwYjZ3l+tJHGnDuQ7/v312Cctq8b762rpBLF26rnhZxWQ4mg2hplvQeZcVFteHjs0C+BoUmIB9lWCsAqjtJm60hAkngNDxL4kLKNXjwGRhd2Q2KwmHZyDOcToJiRR/69EgZG8Ayx0AmbzV58OHaLcfgz6TT7GzzGAbah56txNLqz7Nn8BCTU/w1IBHN62lePk8s+V2rzhvzbnZLZgT4W4y5A0vKmg82bZIfZYzC0/+CcIus7EnF+iSpxE6u2mamY23P79pe0aqgQGvjhy2MGeZF9EnhbRdiIs+6o4v1oLjA+10PPGCgVMeSz1wB8LwZvJUOBAOgXCn4u8v79HoCOxQ8/0NY6kH/Kfu8hXTGP7GsOOFaD/zFmggv9yluxNynDcQfJPTdAYl4UjOcTK0Ggy0utk7sjCRaoubYzGtM6ExqL1bPmsKkXNCn+7vTht66dO56vqLZOS+89N4g2iXQ6UwpWA1jQZ39plrNkpf2+16A8siGuIl7WrNiWw/1VZ5KCs7SZwkezzwfNNjj0aALFWsP7u3FpvgPvLM4VrRutHgyo5HPtJXmmI/RHzSy/xUWDkp75cZJMaX5MLIggwS9Jd9dEemNmspvpto8r8p8IyP7PivLw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(83380400001)(316002)(26005)(7696005)(6506007)(110136005)(9686003)(54906003)(55016003)(4744005)(38070700005)(8936002)(33656002)(5660300002)(52536014)(2906002)(478600001)(86362001)(4326008)(64756008)(66476007)(66446008)(8676002)(76116006)(66556008)(66946007)(122000001)(71200400001)(186003)(41300700001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9139 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d6478533-eed0-48f7-a885-08da8f1ff35b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: okQHUMy+aasjnGIKzUNFFInaqObaaRrVewpUwtXbJP9vUrKKoIneGBcMoO6es1+MtGh5sVKkgf/2zVusrBcs0qId0EoamIvQLkXq6wDqC2an6W0AuhWOAsYC4U9I8n0JdvfeF7h2K6zHv6nCtwrKRPjegTazUByZLljPRqw7oULrPxZO5k24HMMcOJSipe5Ky23230NZYYSl1pZtrMe/RpLNQcii99Q/BLN6hjkcEfCkJVO+Xkcs8wfoFzzzZhWy10uYvlbu48HA6jqIygzFa6DnHJdopT05sK30A0nv5vY/yvQJYfIMOV6V/OjH28bfz5/YsDY9oCc4RvBOlX9hLHqwn8WcRSAqRZaMMqOM+yw6loOnV77VyIoepGvvJ+HXgpfjSVq06BktAGq8SrdX5qWktM9zcDcttnS36l74j1vSFXoY0ab9uig6h37jePmcBs08cPfHGfmO/Kc2veZJyeEJsN3S71mzcNUhBcXRsynYFDrWkDkC49nV7QFgc4+LxCtrhePIIBpS+SSjl34LHSjTze9+2XYm8NQfM66l5FvV4pEeImtaeKwW/5KXxSfK/48uS9bdlPArih5clur3QWl4ruWjPGBuXzi15YZb4ykaBRVPak2+oX13Qa2ihyENP+CQgk9C1Xy7TVwrFG//g670LLAF5HOk5P1tG1j6ZXDH6DFgUX92hSz9SJHkLeuH7sIIFqC7gHWzqbtWy7jVni41nDcFT/6Q9FT41xyzt3DrcgJOoanD2VZ5BN4+4/7WpSY5/tdskgaemK53yt8zIA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(396003)(39860400002)(36840700001)(46966006)(40470700004)(54906003)(4744005)(81166007)(107886003)(186003)(336012)(47076005)(356005)(82310400005)(110136005)(7696005)(36860700001)(82740400003)(41300700001)(33656002)(8936002)(316002)(86362001)(70586007)(478600001)(8676002)(5660300002)(52536014)(4326008)(40460700003)(6506007)(40480700001)(2906002)(55016003)(9686003)(83380400001)(70206006)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:21:11.1996 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7d7ae88-8b20-4134-5de6-08da8f1ff91e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8287 SGkgSnVsaWVuIGFuZCBNaWNoYWwsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g RnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gPj4gQ2hhbmdlcyBmcm9tIHYx IHRvIHYyOg0KPiA+PiAtIE5ldyBjb21taXQuDQo+ID4+IC0tLQ0KPiA+DQo+ID4gVGhlIHBhdGNo IGxvb2tzIGdvb2QgYnV0IEkgdGhpbmsgaXQgc2hvdWxkIGJlIHB1dCBhcyB0aGUgZmlyc3Qgb25l IGluIHRoZQ0KPiBzZXJpZXMNCj4gPiBhcyB0aGlzIGlzIGEgbmF0dXJhbCBwcmVyZXF1aXNpdGUg Zm9yIHRoZSBpbnRyb2R1Y3Rpb24gb2YgdGhlIHJlc2VydmVkIGhlYXAuDQo+IFRoaXMNCj4gPiB3 aWxsIGFsc28gaGVscCBub3QgdG8gbW9kaWZ5IHRoZSBzYW1lIHJlc2VydmVkIGhlYXAgY29kZSB5 b3UgaW50cm9kdWNlZCBpbg0KPiB0aGUgZmlyc3QgcGF0Y2guDQo+IA0KPiArMS4gVGhlIHNhbWUg Y291bGQgYmUgc2FpZCB3aXRoIHBhdGNoICM0LiBUaGUgcmVuYW1pbmcgc2hvdWxkIGJlIGJlZm9y ZQ0KPiBwYXRjaCAjMy4NCg0KQ29vbCwgSSB3aWxsIHNlbmQgYSB2MyB3aXRoIHRoZXNlIGFkanVz dGVkLiBXaWxsIHNlbmQgYWZ0ZXIgZml4aW5nIG1vcmUgcG9zc2libGUNCmNvbW1lbnRzIGZvciB2 Mi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4g SnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:31:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:31:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398671.639573 (Exim 4.92) (envelope-from ) id 1oV8S3-0007eZ-33; Mon, 05 Sep 2022 09:31:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398671.639573; Mon, 05 Sep 2022 09:31:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8S2-0007eS-W7; Mon, 05 Sep 2022 09:31:30 +0000 Received: by outflank-mailman (input) for mailman id 398671; Mon, 05 Sep 2022 09:31:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8S1-0007eK-BO for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 09:31:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8Ry-0006NG-TT; Mon, 05 Sep 2022 09:31:26 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oV8Ry-0005LJ-Jv; Mon, 05 Sep 2022 09:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5FgliYH0x1QTvE9lSa2XHpn9O4R/3vC2uFHrycBrS2c=; b=qcStOTPFMSdZij4xK8jtIGfEJh z8+eqNXcHNJVfGjvzJCLHXMneXcIae2kdPafYAobTLXd/03YNMpTmTzSrpVlruN/kwRTQw+wxddjN xp2qZulP4+xYo/mAY0X/p0NtG7v8etN91nwvGE1Av/ghsQZvxmeTDvWMdeg3cLCVzsBw=; Message-ID: <5f0bf815-3236-2262-62b4-cd3d99bb60ff@xen.org> Date: Mon, 5 Sep 2022 10:31:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Content-Language: en-US To: Rahul Singh , Stefano Stabellini Cc: xen-devel , Bertrand Marquis , Zhou Wang , Volodymyr Babchuk , Will Deacon References: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/09/2022 10:18, Rahul Singh wrote: >> On 3 Sep 2022, at 12:21 am, Stefano Stabellini wrote: >> >> On Fri, 2 Sep 2022, Rahul Singh wrote: >>> From: Zhou Wang >>> >>> Backport Linux commit a76a37777f2c. This is the clean backport without >>> any changes. >>> >>> Reading the 'prod' MMIO register in order to determine whether or >>> not there is valid data beyond 'cons' for a given queue does not >>> provide sufficient dependency ordering, as the resulting access is >>> address dependent only on 'cons' and can therefore be speculated >>> ahead of time, potentially allowing stale data to be read by the >>> CPU. >>> >>> Use readl() instead of readl_relaxed() when updating the shadow copy >>> of the 'prod' pointer, so that all speculated memory reads from the >>> corresponding queue can occur only from valid slots. >>> >>> Signed-off-by: Zhou Wang >>> Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com >>> [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] >>> Signed-off-by: Will Deacon >>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c >>> Signed-off-by: Rahul Singh >>> --- >>> Changes in v2: >>> - fix commit msg >>> - add _iomb changes also from the origin patch >>> --- >>> xen/arch/arm/include/asm/system.h | 1 + >>> xen/drivers/passthrough/arm/smmu-v3.c | 11 +++++++++-- >>> 2 files changed, 10 insertions(+), 2 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/system.h b/xen/arch/arm/include/asm/system.h >>> index 65d5c8e423..fe27cf8c5e 100644 >>> --- a/xen/arch/arm/include/asm/system.h >>> +++ b/xen/arch/arm/include/asm/system.h >>> @@ -29,6 +29,7 @@ >>> #endif >>> >>> #define smp_wmb() dmb(ishst) >>> +#define __iomb() dmb(osh) >> >> We don't have any other #define starting with __ in system.h. >> I wonder if we should call this macro differently or simply iomb(). > > I think either iomb() or dma_mb() will be the right name. > Please let me know your view on this. It is not 100% clear why Linux went with __iomb() rather than iomb(). But I would prefer to keep the __* version to match Linux. If the others really want to drop the __. Then I think it should be name iomb(). The rationale is while __iomb() is an alias to dma_mb(), the __iormb() behaves differently compare to dma_mb() (I haven't into details why). So if it was a read barrier, we would likely want to use the iormb() semantic. This will keep the terminology consistent with Linux (even if we remove the __). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 09:59:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 09:59:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398678.639585 (Exim 4.92) (envelope-from ) id 1oV8sn-0001mG-7U; Mon, 05 Sep 2022 09:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398678.639585; Mon, 05 Sep 2022 09:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8sn-0001m9-4D; Mon, 05 Sep 2022 09:59:09 +0000 Received: by outflank-mailman (input) for mailman id 398678; Mon, 05 Sep 2022 09:59:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8sm-0001lz-3L; Mon, 05 Sep 2022 09:59:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8sm-0006oa-0G; Mon, 05 Sep 2022 09:59:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV8sl-0000qh-Jt; Mon, 05 Sep 2022 09:59:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV8sl-0005z1-JN; Mon, 05 Sep 2022 09:59:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XxKxXtJN2GvygE51PsX5KBfon+BzKDxmB1rA+xalkWo=; b=07uPV390CJyoqZtvvTyBNCtatI g1vg4WK2VYkXW2b0lvtAgF7ueLDX3J/RfDJF4VD3qnnNjSyUw9gKm6omZbaLfR502S7TIh2xy29Fa 9+StcgNZnxX0mEpSGLzK5lPpQ9uRmGRNy71xRs8lUcTjtWu0xBrzNndloU30/OuuUt9c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172998: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=08522341c4935f27cd7d3dbfd38ffa8329cdc2cb X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 05 Sep 2022 09:59:07 +0000 flight 172998 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172998/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 08522341c4935f27cd7d3dbfd38ffa8329cdc2cb baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 32 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 246 attempts Testing same since 172995 2022-09-05 03:33:08 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1474 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 10:23:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 10:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398688.639596 (Exim 4.92) (envelope-from ) id 1oV9GT-0005Ai-5k; Mon, 05 Sep 2022 10:23:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398688.639596; Mon, 05 Sep 2022 10:23:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9GT-0005Ab-38; Mon, 05 Sep 2022 10:23:37 +0000 Received: by outflank-mailman (input) for mailman id 398688; Mon, 05 Sep 2022 10:23:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9GR-0005AF-SJ for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 10:23:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80079.outbound.protection.outlook.com [40.107.8.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id caed54dc-2d04-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 12:23:32 +0200 (CEST) Received: from DB6P195CA0007.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::17) by AS8PR08MB7815.eurprd08.prod.outlook.com (2603:10a6:20b:529::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 10:23:30 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::15) by DB6P195CA0007.outlook.office365.com (2603:10a6:4:cb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 10:23:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 10:23:28 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 05 Sep 2022 10:23:28 +0000 Received: from 9d38d3bb0c37.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C02FB8FB-3FD9-4108-86F1-E87DA5E6419C.1; Mon, 05 Sep 2022 10:23:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9d38d3bb0c37.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 10:23:17 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB7899.eurprd08.prod.outlook.com (2603:10a6:150:5e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Mon, 5 Sep 2022 10:23:15 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 10:23:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: caed54dc-2d04-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eQ7BizAAR6M48iJ4HXGhISHwMjg0DPp8zslSeuse62jNHchDzP64B1nDNsnYvROc9XdGoOZUeilzbuXMkTo2kMvC72bewEGlRJC3vzm6VD8uOyOcdoWScW8qU7IfdT6YaIwPpbx9yCGbX9+3gAgHZIP1/b9bsh+Xw/rGBLKPvvWxAS3OaA3y7JPZmKFqGxjKqoqNMzSXXXufFGBmBMqfPG8uwxdPKoaz7zuR5dpJ95rFSdKdt8DXMYp+kG0bIq16EC99hZAoMsHy3Il4+IlAPMtKOqQ/p+K1ViwHHC4iSftT3k1T7XlWV972xDjkS876OiA3auyGdEk+lEyGK5eBYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMk4SVauaH5SMHMK2VVZThaO7HX4T+edUbNHKUIHbnY=; b=SMCcj+5tVpDZ38IpG08vUshpQy/UO7RnCt4W/wva+/YOjPfzdyQCTz+/+2boNxu9TZIok/6V/urxwJ1Si0sQwQp4fFHlc01eXd8EhTd/9E66Wq8+fq17stvP7bBVRP3AAfyNzufbqLvWHjgXV0m23qUTm1V6WvooT4fNJlhHvM4wGe3lBmJ4EyPcYJcqb53JqGXUT0AG4CCNzSrIawYRtdUlH3vouTMDQxySzPjQDr7HJVF4JgIOuTajwnt7Av1iACLVmZNbC0BIxBY6ZdwKiTuYem59jsVASEYdHNPPGi+GslVVYROSmY7yt3aa+NzOk7h9qTjdlqyHIpxnl9RdBg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMk4SVauaH5SMHMK2VVZThaO7HX4T+edUbNHKUIHbnY=; b=gI6oDDACbjN+SnVkvPU6ceZ42O8QeLRH02omfKeKTJQb4Oo4G0kvbbaTGCi5x/yEalOo+0DmBdK+Ti2SyXVgmdsD0VQRPlrA0cvnWwzgDpAT2e3cP390nvUvPlNHEzNQv16u7YNzQKQ+wVW6Dq3YecAWm2ZpZKw0jv9ksOni4Ps= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 786d5d970e109e3d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lq828TaKAiJajCe1r0KFQa1p+VqS5wJ3oqUH5olclae1QZHMsL38zTcap6gTXIio+MDD2w9FcM6qH5usqkuDD+25nTawRSLFQlouIOynj1tVmUIgG2l8R2vATqkGaS338GTdfMQXfDwVADCx28QkjEdAy1dhkL1xtm8umvA31LuAF99gnRi+333IqNavE7idLLz914MZMWtiK7B6fQ9ZAUXi5IajqQJisVhxf3Cg/jUdvxfLgviDo4YygI3iHxd6iSXAWnR6nqIVRh90TrvyTlbQ5jFw6UUOq77i9GubDcDw6Qavb/jP4RTRxMThEekF3/DK9V4OXCVKa3HlT7A3bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMk4SVauaH5SMHMK2VVZThaO7HX4T+edUbNHKUIHbnY=; b=epgVZuRH4H0AP4QbYiMp3D6wKS6Z7VPTFybShTWs8TkxHzqLWkBw3k9GKgX3jrpAErAg45sf6h+PWAY0x24A16bn9u7Bdj8CG4MDKhVqd5eNsoW/n3w+lYh1flq3Dj5ubGgDGD7SsPRVrOYfOlyQCBGYJHGPapGUDonQv+pEDjgIzlt3xhM+tYlBlxSq3E+l/hJeWBcACLaGMYk0dewJHgBwM5BLNfBEq6g4fQMn72YEVFWJza4KIAxlw2UJllQppNDXl7+4mSzp8q7NbVv179gU3lvO372U4XI1bZL8scKUwP6zn2+nT9elTSmJGNWMIyr4Dn9TzNLxqizcHCHz2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMk4SVauaH5SMHMK2VVZThaO7HX4T+edUbNHKUIHbnY=; b=gI6oDDACbjN+SnVkvPU6ceZ42O8QeLRH02omfKeKTJQb4Oo4G0kvbbaTGCi5x/yEalOo+0DmBdK+Ti2SyXVgmdsD0VQRPlrA0cvnWwzgDpAT2e3cP390nvUvPlNHEzNQv16u7YNzQKQ+wVW6Dq3YecAWm2ZpZKw0jv9ksOni4Ps= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , Stefano Stabellini , xen-devel , Zhou Wang , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Topic: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Index: AQHYvtEAS2RWaHYM0E2SfKglZEy6Bq3Mx8YAgAPLlICAAAOLAIAADnwA Date: Mon, 5 Sep 2022 10:23:15 +0000 Message-ID: <71FC45C0-2F78-4CB7-AAB7-5B2C357F2C74@arm.com> References: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> <5f0bf815-3236-2262-62b4-cd3d99bb60ff@xen.org> In-Reply-To: <5f0bf815-3236-2262-62b4-cd3d99bb60ff@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 91271be0-81d9-4304-e0fc-08da8f28acc3 x-ms-traffictypediagnostic: GV1PR08MB7899:EE_|DBAEUR03FT054:EE_|AS8PR08MB7815:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: khkh8fo6lKUrBxXsbq+FSUqP2bSsXc2UmTJKuD1ledXSkLyr6wIoa3OcGYETqsviHHlKTFtvmO8CEht5mtpwV+OJjACB/XwsklEUAxYOZ+1k30n6IdTQcFrEsPw7AhjOlRbpSDP7nEvgmrj1O+tQCh/hxRIWSg6Dn07JQEQI/+BXNML9T2oQmJzHlRSdZkY+eILs7x2alDlLC433oVQhTqsFxjAA5a7Bsw/uffrdNAmzyH3n5S29QKXiYS84ayaGy3+TPd0ZR+bV533CJLtXb0CmhLyGdS/7KiEMJWEzAD7+IgKrtaXQXIkaROQreODbJvx9dQODkluPe+1DoZzFJVROMvhijHqJZnagYjzBOHjLanRTkoVYa5V/ULqXA8GW51X3WnNOf3Y4HyI52v/QqhV4wZfZ4AcfnlGJlwYU5+V/Kqts2bsySeecyySlFHn1qb8+sTLkD/kSfhJB56eC7EXPvJW/U3GxfdauetqM3NAzK1iRf2zcMWzGaOM4zKz64VOo3GSaiexN+PXiuLa7btKJag3kmXxr5H2ExFGYfxoKNvt8Nh33a6qCNi7cAVXnNGudig1hUAe0hAxU0vB3tPf5nXwh+p6RG73IW/rUw7Zt0MT+JKm0gzB3TwG+dhrmmI3OS3Ke3vlsmXOQfMj1lGcN0uFTQGqhvtdZmcaFgPRKWp47CKX055QIJtYyM1ejAgFi3+gUDCFaISzEOtPvqse58N6D1qjH3jW4ryLw2sIsabmB96FfGlhFEahgIrk18Ik7/bzlgbPjCShsSUqrm8FiweeU01jhjRZN1wVaVV5T1146wPHV1Dhrn5K6RC4TB71uZDANIOcQuknFcDQygg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(53546011)(26005)(6506007)(8936002)(2616005)(6512007)(186003)(71200400001)(5660300002)(33656002)(41300700001)(478600001)(86362001)(6486002)(966005)(36756003)(38070700005)(83380400001)(2906002)(6916009)(8676002)(4326008)(66446008)(54906003)(64756008)(38100700002)(66476007)(316002)(122000001)(66946007)(76116006)(91956017)(66556008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <4F7EBBC32551A141B68075FCF77C4621@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7899 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a5d56338-7da0-40f1-193c-08da8f28a4d1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t8JuapwEz+5mnPVvaBekSOmuGQw25P/in9WULN+2hw91LeBao/KJXdlVIAo6f+N0q1Cq8IJH/cHAtTafadGq4EhNJHOZq4E8ciEIdJv7d6+yvLz29b+BgO28/lhHus6CyGpdDHTlcnIam0bkBAKZf/74iWebPmByVSyZZ3JVwECYeQoIFyd7euvC1muodPM2qO/K/Sb+Y1egE3IHjt3KQkYTUTB/9l7s0izekZCXkI29tPoIt8rcx33xEy/saH0IQWf/2cD9c/mCDIBFvzjg5M1h3/BMQr2nM9iR6kk5b3on8HuRJdXvfcZK1NhRYAeZrL5cLxjSztQm1qr4TaCdW/WgjyviY2HSBJ3K4v2XW21fE7XE67ASH1d9Ajb5lOvXYgVWM9yeZ6wPlZHRfch6eKAYECmMT4c69BlK+cKoqyqvqIZFFQPQdqhK90WBbCg81dYd5aLGc8RTKfggsfI4FlzJV+LDDX2aJpL6fzBQL8oFr98ZOqnQeQmn7F+hqKs4ZpAbDgn0wKWjuSLS6yaVWy5WBhaUdNTZo5NiedohJO+T8WYiVyF8KdAIr23GSqdPW4oJs1aDVDg7ItgenCRH7wdg3oQUth0tFwOsaPBBGH3GPalvx7JrRkxh3lyQiwQQLmxezen/oTg26OPCX/uTHGiurXXUfIcFv/2HjAGSsnNBPnNmv3cr236qeDCzJ3XW9QdflqlJux8666421llsYnkuoeOmpKoZ/M/FnV1maUD6WP1aRfGiHdP2awaVgGCQ96sUQXu8e4Uo8GWeg9WyNvKJFiUQZL9jdCtTUQqf2dA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(346002)(396003)(36840700001)(40470700004)(46966006)(316002)(478600001)(82310400005)(54906003)(8676002)(966005)(40480700001)(4326008)(5660300002)(8936002)(6862004)(2906002)(356005)(70586007)(81166007)(70206006)(6486002)(33656002)(86362001)(82740400003)(36756003)(40460700003)(336012)(107886003)(47076005)(53546011)(26005)(41300700001)(186003)(2616005)(83380400001)(36860700001)(6512007)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 10:23:28.6172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91271be0-81d9-4304-e0fc-08da8f28acc3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7815 SGksDQoNCj4gT24gNSBTZXAgMjAyMiwgYXQgMTA6MzEsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNS8wOS8yMDIyIDEwOjE4LCBSYWh1bCBT aW5naCB3cm90ZToNCj4+PiBPbiAzIFNlcCAyMDIyLCBhdCAxMjoyMSBhbSwgU3RlZmFubyBTdGFi ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4+PiANCj4+PiBPbiBGcmks IDIgU2VwIDIwMjIsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+PiBGcm9tOiBaaG91IFdhbmcgPHdh bmd6aG91MUBoaXNpbGljb24uY29tPg0KPj4+PiANCj4+Pj4gQmFja3BvcnQgTGludXggY29tbWl0 IGE3NmEzNzc3N2YyYy4gVGhpcyBpcyB0aGUgY2xlYW4gYmFja3BvcnQgd2l0aG91dA0KPj4+PiBh bnkgY2hhbmdlcy4NCj4+Pj4gDQo+Pj4+IFJlYWRpbmcgdGhlICdwcm9kJyBNTUlPIHJlZ2lzdGVy IGluIG9yZGVyIHRvIGRldGVybWluZSB3aGV0aGVyIG9yDQo+Pj4+IG5vdCB0aGVyZSBpcyB2YWxp ZCBkYXRhIGJleW9uZCAnY29ucycgZm9yIGEgZ2l2ZW4gcXVldWUgZG9lcyBub3QNCj4+Pj4gcHJv dmlkZSBzdWZmaWNpZW50IGRlcGVuZGVuY3kgb3JkZXJpbmcsIGFzIHRoZSByZXN1bHRpbmcgYWNj ZXNzIGlzDQo+Pj4+IGFkZHJlc3MgZGVwZW5kZW50IG9ubHkgb24gJ2NvbnMnIGFuZCBjYW4gdGhl cmVmb3JlIGJlIHNwZWN1bGF0ZWQNCj4+Pj4gYWhlYWQgb2YgdGltZSwgcG90ZW50aWFsbHkgYWxs b3dpbmcgc3RhbGUgZGF0YSB0byBiZSByZWFkIGJ5IHRoZQ0KPj4+PiBDUFUuDQo+Pj4+IA0KPj4+ PiBVc2UgcmVhZGwoKSBpbnN0ZWFkIG9mIHJlYWRsX3JlbGF4ZWQoKSB3aGVuIHVwZGF0aW5nIHRo ZSBzaGFkb3cgY29weQ0KPj4+PiBvZiB0aGUgJ3Byb2QnIHBvaW50ZXIsIHNvIHRoYXQgYWxsIHNw ZWN1bGF0ZWQgbWVtb3J5IHJlYWRzIGZyb20gdGhlDQo+Pj4+IGNvcnJlc3BvbmRpbmcgcXVldWUg Y2FuIG9jY3VyIG9ubHkgZnJvbSB2YWxpZCBzbG90cy4NCj4+Pj4gDQo+Pj4+IFNpZ25lZC1vZmYt Ynk6IFpob3UgV2FuZyA8d2FuZ3pob3UxQGhpc2lsaWNvbi5jb20+DQo+Pj4+IExpbms6IGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMTYwMTI4MTkyMi0xMTcyOTYtMS1naXQtc2VuZC1lbWFpbC13 YW5nemhvdTFAaGlzaWxpY29uLmNvbQ0KPj4+PiBbd2lsbDogVXNlIHJlYWRsKCkgaW5zdGVhZCBv ZiBleHBsaWNpdCBiYXJyaWVyLiBVcGRhdGUgJ2NvbnMnIHNpZGUgdG8gbWF0Y2guXQ0KPj4+PiBT aWduZWQtb2ZmLWJ5OiBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPg0KPj4+PiBPcmlnaW46 IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9s aW51eC5naXQgYTc2YTM3Nzc3ZjJjDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxy YWh1bC5zaW5naEBhcm0uY29tPg0KPj4+PiAtLS0NCj4+Pj4gQ2hhbmdlcyBpbiB2MjoNCj4+Pj4g LSBmaXggY29tbWl0IG1zZw0KPj4+PiAtIGFkZCBfaW9tYiBjaGFuZ2VzIGFsc28gZnJvbSB0aGUg b3JpZ2luIHBhdGNoDQo+Pj4+IC0tLQ0KPj4+PiB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc3lz dGVtLmggICAgIHwgIDEgKw0KPj4+PiB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hcm0vc21tdS12 My5jIHwgMTEgKysrKysrKysrLS0NCj4+Pj4gMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQ0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2Fy bS9pbmNsdWRlL2FzbS9zeXN0ZW0uaCBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zeXN0ZW0u aA0KPj4+PiBpbmRleCA2NWQ1YzhlNDIzLi5mZTI3Y2Y4YzVlIDEwMDY0NA0KPj4+PiAtLS0gYS94 ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc3lzdGVtLmgNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL3N5c3RlbS5oDQo+Pj4+IEBAIC0yOSw2ICsyOSw3IEBADQo+Pj4+ICNlbmRp Zg0KPj4+PiANCj4+Pj4gI2RlZmluZSBzbXBfd21iKCkgICAgICAgZG1iKGlzaHN0KQ0KPj4+PiAr I2RlZmluZSBfX2lvbWIoKSAgICAgICAgZG1iKG9zaCkNCj4+PiANCj4+PiBXZSBkb24ndCBoYXZl IGFueSBvdGhlciAjZGVmaW5lIHN0YXJ0aW5nIHdpdGggX18gaW4gc3lzdGVtLmguDQo+Pj4gSSB3 b25kZXIgaWYgd2Ugc2hvdWxkIGNhbGwgdGhpcyBtYWNybyBkaWZmZXJlbnRseSBvciBzaW1wbHkg aW9tYigpLg0KPj4gIEkgdGhpbmsgZWl0aGVyIGlvbWIoKSBvciBkbWFfbWIoKSB3aWxsIGJlIHRo ZSByaWdodCBuYW1lLg0KPj4gUGxlYXNlIGxldCBtZSBrbm93IHlvdXIgdmlldyBvbiB0aGlzLg0K PiANCj4gSXQgaXMgbm90IDEwMCUgY2xlYXIgd2h5IExpbnV4IHdlbnQgd2l0aCBfX2lvbWIoKSBy YXRoZXIgdGhhbiBpb21iKCkuIEJ1dCBJIHdvdWxkIHByZWZlciB0byBrZWVwIHRoZSBfXyogdmVy c2lvbiB0byBtYXRjaCBMaW51eC4NCj4gDQo+IElmIHRoZSBvdGhlcnMgcmVhbGx5IHdhbnQgdG8g ZHJvcCB0aGUgX18uIFRoZW4gSSB0aGluayBpdCBzaG91bGQgYmUgbmFtZSBpb21iKCkuIFRoZSBy YXRpb25hbGUgaXMgd2hpbGUgX19pb21iKCkgaXMgYW4gYWxpYXMgdG8gZG1hX21iKCksIHRoZSBf X2lvcm1iKCkgYmVoYXZlcyBkaWZmZXJlbnRseSBjb21wYXJlIHRvIGRtYV9tYigpIChJIGhhdmVu J3QgaW50byBkZXRhaWxzIHdoeSkuDQo+IA0KPiBTbyBpZiBpdCB3YXMgYSByZWFkIGJhcnJpZXIs IHdlIHdvdWxkIGxpa2VseSB3YW50IHRvIHVzZSB0aGUgaW9ybWIoKSBzZW1hbnRpYy4gVGhpcyB3 aWxsIGtlZXAgdGhlIHRlcm1pbm9sb2d5IGNvbnNpc3RlbnQgd2l0aCBMaW51eCAoZXZlbiBpZiB3 ZSByZW1vdmUgdGhlIF9fKS4NCg0KV2UgbmVlZCB0aGUgX19pb21iIGFzIOKAnGxpbnV4IGNvbXBh dGliaWxpdHnigJ0gaW4gZmFjdCBzbyBJIHdvdWxkIHN1Z2dlc3QgZm9yIG5vdyB0byBvbmx5IGlu dHJvZHVjZSBpdCBhdCB0aGUgYmVnaW5uaW5nIG9mIHNtbXUtdjMuYyB3aXRoIG90aGVyIGxpbnV4 IGNvbXBhdGliaWxpdHkgc3R1ZmYgdG8gcHJldmVudCBhZGRpbmcgdGhpcyB0byBYZW4gb3ZlcmFs bC4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBK dWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Mon Sep 05 10:24:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 10:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398695.639607 (Exim 4.92) (envelope-from ) id 1oV9He-0005hR-Gy; Mon, 05 Sep 2022 10:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398695.639607; Mon, 05 Sep 2022 10:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9He-0005hK-D5; Mon, 05 Sep 2022 10:24:50 +0000 Received: by outflank-mailman (input) for mailman id 398695; Mon, 05 Sep 2022 10:24:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9Hd-0005hA-9H for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 10:24:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9Ha-0007Lb-7X; Mon, 05 Sep 2022 10:24:46 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oV9Ha-0007yx-0d; Mon, 05 Sep 2022 10:24:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+buCVX/R7HsKg5J8hDkENMtQaIpdVJfRXnEceHXrBxo=; b=W9j8P/wty6t62v4FBj1YkJ6gCu XeBUE/GqhylfmQ/3M0gmUFzBWwRMq1aRhu+Uuv70s1QDu6R8qJo5fmT3E79XzOZ6lZSCKF30sAAbS UDDqC05XXOoQeTMwQjcj/cBHf90lCQt3Opsd5FQodvrSfwNzEJ4REjM4Roo39ZvMMu0g=; Message-ID: <8ae636bb-9508-9477-af0e-d30440782dbf@xen.org> Date: Mon, 5 Sep 2022 11:24:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Content-Language: en-US To: Bertrand Marquis Cc: Rahul Singh , Stefano Stabellini , xen-devel , Zhou Wang , Volodymyr Babchuk , Will Deacon References: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> <5f0bf815-3236-2262-62b4-cd3d99bb60ff@xen.org> <71FC45C0-2F78-4CB7-AAB7-5B2C357F2C74@arm.com> From: Julien Grall In-Reply-To: <71FC45C0-2F78-4CB7-AAB7-5B2C357F2C74@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Bertrand, On 05/09/2022 11:23, Bertrand Marquis wrote: > Hi, > >> On 5 Sep 2022, at 10:31, Julien Grall wrote: >> >> >> >> On 05/09/2022 10:18, Rahul Singh wrote: >>>> On 3 Sep 2022, at 12:21 am, Stefano Stabellini wrote: >>>> >>>> On Fri, 2 Sep 2022, Rahul Singh wrote: >>>>> From: Zhou Wang >>>>> >>>>> Backport Linux commit a76a37777f2c. This is the clean backport without >>>>> any changes. >>>>> >>>>> Reading the 'prod' MMIO register in order to determine whether or >>>>> not there is valid data beyond 'cons' for a given queue does not >>>>> provide sufficient dependency ordering, as the resulting access is >>>>> address dependent only on 'cons' and can therefore be speculated >>>>> ahead of time, potentially allowing stale data to be read by the >>>>> CPU. >>>>> >>>>> Use readl() instead of readl_relaxed() when updating the shadow copy >>>>> of the 'prod' pointer, so that all speculated memory reads from the >>>>> corresponding queue can occur only from valid slots. >>>>> >>>>> Signed-off-by: Zhou Wang >>>>> Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com >>>>> [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] >>>>> Signed-off-by: Will Deacon >>>>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c >>>>> Signed-off-by: Rahul Singh >>>>> --- >>>>> Changes in v2: >>>>> - fix commit msg >>>>> - add _iomb changes also from the origin patch >>>>> --- >>>>> xen/arch/arm/include/asm/system.h | 1 + >>>>> xen/drivers/passthrough/arm/smmu-v3.c | 11 +++++++++-- >>>>> 2 files changed, 10 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/xen/arch/arm/include/asm/system.h b/xen/arch/arm/include/asm/system.h >>>>> index 65d5c8e423..fe27cf8c5e 100644 >>>>> --- a/xen/arch/arm/include/asm/system.h >>>>> +++ b/xen/arch/arm/include/asm/system.h >>>>> @@ -29,6 +29,7 @@ >>>>> #endif >>>>> >>>>> #define smp_wmb() dmb(ishst) >>>>> +#define __iomb() dmb(osh) >>>> >>>> We don't have any other #define starting with __ in system.h. >>>> I wonder if we should call this macro differently or simply iomb(). >>> I think either iomb() or dma_mb() will be the right name. >>> Please let me know your view on this. >> >> It is not 100% clear why Linux went with __iomb() rather than iomb(). But I would prefer to keep the __* version to match Linux. >> >> If the others really want to drop the __. Then I think it should be name iomb(). The rationale is while __iomb() is an alias to dma_mb(), the __iormb() behaves differently compare to dma_mb() (I haven't into details why). >> >> So if it was a read barrier, we would likely want to use the iormb() semantic. This will keep the terminology consistent with Linux (even if we remove the __). > > We need the __iomb as “linux compatibility” in fact so I would suggest for now to only introduce it at the beginning of smmu-v3.c with other linux compatibility stuff to prevent adding this to Xen overall. I would be fine with that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 10:36:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 10:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398704.639617 (Exim 4.92) (envelope-from ) id 1oV9T6-0007JN-MT; Mon, 05 Sep 2022 10:36:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398704.639617; Mon, 05 Sep 2022 10:36:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9T6-0007JG-Jq; Mon, 05 Sep 2022 10:36:40 +0000 Received: by outflank-mailman (input) for mailman id 398704; Mon, 05 Sep 2022 10:36:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9T5-0007J9-C8 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 10:36:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d395122-2d06-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 12:36:37 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Sep 2022 06:36:32 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5804.namprd03.prod.outlook.com (2603:10b6:806:fb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 10:36:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 10:36:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d395122-2d06-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662374197; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uv2wUdVfPvpiScb5nREle6bDlPbjffGNPQ4dXabpOvM=; b=eWmkoqF8ooMnINKc7MQVh/xTQRTEMpk6AB7VGugsUuqDHvamFDk5qV4n SJHaXsTZd2/l5i8MvoBxtCx8eiyCMaYAzUBh7MCy9XCHpiawXzja5saXi vvkbOdHZf56n4xraaU3SSV7wDEneyc1EaTi7jN8uiOr195MnF02peIypF 4=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 79459289 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vv31ha144Yx2+yfa9vbD5TZwkn2cJEfYwER7XKvMYLTBsI5bp2MOz TcWWDqFaPyJM2T3LdsiOYW2/UJUsZeEytYxG1Q+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8E435ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6612Dl0WepEAxsRUIT5/8 vw9ECAjaSnW0opawJrjIgVtruIKCZCyeak56jRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ym5KmMIwL6WjfNfD2z75Qp9yrXydvHSfcSHX559lUeEv GPWuW/+B3n2MfTAmGbYoyj814cjmwvRc7k+L6Cd3MIwhR6B6mk5AUcVeguC9KzRZkmWHog3x 1Yv0ight68p72SwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQK2 1mTjpXWDDpgmLSPTDSW8bL8hT+8MCcaLGgGZAcfUBAIpdLkpekblA/OQNtlH+i6h9rdGDfsz jTMpy87750Rh8MW06Sw/Xjcnimh4JPOS2YICh7/W2uk6kZzYt6jbonxsFzDt68efMCeU0WLu 2UCl46G9ucSAJqRlSuLBuIQALWu4PXDOzrZ6bJyI6QcG/2W0ybLVehtDPtWfy+F7u5slefVX XLu IronPort-HdrOrdr: A9a23:2UXgzKgSk0lYXCRw86TnVnuiTXBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II= X-IronPort-AV: E=Sophos;i="5.93,291,1654574400"; d="scan'208";a="79459289" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nv3JyM3aOAIV21PpRFuwt+IY4qcsH/p6n+dATNwL060tVT6X2N8iV1dZPikSqPP0NAlubVrIc5i2ev/to+/jGRRAsgdkGLHVxS+jDzbOH4ri3XZu6EesZUrDf/1QWupHRfl7tuXW6sfnXCXo2A5EDby5N/N/2noGHq45SST/tkR4ge+bBvxzmceGKIog2rSyjvMEK+PYTEFKw2+ZxWqR8vF2nH9h0bKKmbVejmSpxH2NrbJ4YlXQ34TG5Bpw45aJ98+/S8Nk+QfbYCmDe3qMsLO3XrpiafmZ2GHMepUcISsNcO6HJh9fjiHbuM0u+6MUQoz/5626OvYIIpspd4WK3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uv2wUdVfPvpiScb5nREle6bDlPbjffGNPQ4dXabpOvM=; b=l6SX0L7IckAozV+8FBIfZWP+9Uwt+o3J8W4dPxBiB8Dm3KXIO5pb3mLaWUNdqlBkxT2WmZ8I/988m5IkfYcpKCteDwo489Pq39vYQVR8LUmNy2qsdGykD/h6SEixdPBZDtih/yQGG+7nm5jf0xGYiuoHKRczGdCLA5cfFOKkqHj9uVe8XsPok3Wo4AC6MbzYag59MrWOL7Yp6xW8U7IgBnFE49+KexgabnKI3pq8Cj5dm1fifehLqxTL25YwiSZ3jPGYZxT3KPr31L9iiVkJf/zVc4VGv+9zXAaHQl9DWcvP8o+A3Az0N1tVgbXBKECldooTitN67mDAUdwtE2u9pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uv2wUdVfPvpiScb5nREle6bDlPbjffGNPQ4dXabpOvM=; b=pWuolGU0ESKR6d66DlkPE9sJ7AW/yUR/NeNqKpfR0J7ZBqsVJYXwL73hiPoT6STHYUSf70WJv7drbZ2IuibnFBeGKug2hb/CLDAcNBjEqgU2mB8NQRcU8F6YBIa7dBttjK27dBfJlRMls021xgZcs+WZ60GSwquM3rQ7sOrrGOo= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich Subject: Re: [PATCH v4 3/3] xen/sched: fix cpu hotplug Thread-Topic: [PATCH v4 3/3] xen/sched: fix cpu hotplug Thread-Index: AQHYwPUrmwAE8kE4eUqry59vQa94Aq3QpM0A Date: Mon, 5 Sep 2022 10:36:30 +0000 Message-ID: <8272d775-d8d8-b526-4e39-0d75ff2b5f92@citrix.com> References: <20220905070005.16788-1-jgross@suse.com> <20220905070005.16788-4-jgross@suse.com> In-Reply-To: <20220905070005.16788-4-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3b0807b9-682b-4409-ac51-08da8f2a7f08 x-ms-traffictypediagnostic: SA2PR03MB5804:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6k3r+x5ifLVUoN/bVE4CsmX2OKh2GM09GS9HNBIrpqzImI3ERgYSJmJeNkdXKuYkqO6zH8r9HoPgF+WRjJyPi1NSLDEMbILkO/W/p9vciqX6ZSLX6KqQlrG88hFaD3Htx6dUw/GRTTrU7kzx5bHfGRwUvOM3eFKxalkTP5T9WNMsNn8Vit75bumbifHvPU+hayuJNzP5wAhX+9EoRffphoTAz1C/DpRCYXQctMgB1EZRuJdxkOuCw2lPJfyQbWM16rgElnNtIddGZf8qCKa+oImajfn9GnMaTEazBQq+nns4pG7ccbs2EArf9sKJ5sGirhjw0tHqtNEXTEvWtuX0am/DYkAFBVsaZi3RYye8uJxB24qyLnsQ6R53857q2onVjqRzHo9Iu9m67Tr7qAusuPc/vLQzyorxWV6w7uh1TnohR4tnokbIyMerpe+uEBorXIxuI37zRt2y9LAY4uN1Ed6WNCdc4G9Jhm4v7KuIw8tP42+hB74XiOsojLOBErVqwcLSCwGawc/5OLA6wBj925IaArphfCmxi4i0DVSzkDWjiJASK449iB8maBp9zf8+LWtpcTHrPf5gOViRmf9Xe9UBbAxxFUxcENzmXNE+ufKlmK9B0REpLQGF+boivX3u0TR3V+wVNQIoMIYNHH2J14dwWhy5EwJ82qo6VWaRMdkmlZyskVLxPvoEdDS+PF+yljifydBINgq04SUDgzXgyKFTNxbOlYoATtHsy/gO+Js+lJcady9haUs2lv2Y2ll6QRAYBcFSqMT0c0iR6+DCaaJCCAggHVFzIS63BQ5bPm0uZg3KRl62mWe0vEUmuim4CHBv52HJfnAoZalOSIkJKA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(366004)(396003)(376002)(36756003)(31686004)(31696002)(86362001)(66476007)(76116006)(8676002)(4326008)(66556008)(66446008)(66946007)(91956017)(64756008)(122000001)(38100700002)(38070700005)(82960400001)(71200400001)(83380400001)(2616005)(26005)(478600001)(6506007)(41300700001)(6486002)(316002)(54906003)(110136005)(2906002)(6512007)(186003)(53546011)(8936002)(5660300002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T3gwOTJnT3lGOEdCYkg3YzFDSVZaVVhHL0RnMlEwTnpKelJSVTkrK3hzWmFi?= =?utf-8?B?MXJJK1dBdU1yWnhrc2t6OUVXNWYzaEV2b3NwZmQ0TmpMYnBmamtGY0dsaWJ2?= =?utf-8?B?akxSajc3SzhVdGc1K29NWFhYaWYreUFWZU1iWk5HSXVwZjdSS2ZLN2JoeklC?= =?utf-8?B?ZFVXMSttdFpGSEI4K3ZzL3FqMDUra1RtaGgwUjNhbk14YVRBMytjQml3SWs4?= =?utf-8?B?dU1GdFJQdWpleHdzUStYdDlDeXg3cDMzWjNlQTIvcFVmaHRlcFJwREppZTIy?= =?utf-8?B?eWVkK3dCZjdWdm1kY25WamF0bzBRaEhycVhZeDNoaFY1MHREdngwUTVJWkFF?= =?utf-8?B?MnR0eGFFdERZbnpreEFJTFR1U2lNdXlab3RCRDRqbEZOZkdzT3JFOGZVSXh3?= =?utf-8?B?UFNCbmhaS0xmMk9Lcjh3TGFFSFZrMHc1a29YcFVMTzZDNHpMYkpNZjEzeXdV?= =?utf-8?B?a1VPYXkxN3pwNS9HK3BHNTZDL2x1MFoydVg1aTRWNUpHQ2ZWTlpxbS8xa3Fs?= =?utf-8?B?L0t4cjBMS1NCUGJhWXUzb1lTdWlhbTZCWlBYWHpUSTR4RkZreEsxVi9JU0hw?= =?utf-8?B?YVM3RnNYR3pyQ3Zpbldzdm1nTXJ3Z1k0bGVSbVp2OTVKYWhESFVHWFRsVnFK?= =?utf-8?B?azZPSjJvUllvNitMZ1NqdEhpbFN1S3NPZnJtdVZEamRSZ1dBZmtXaWxjM2pY?= =?utf-8?B?VTgxOWI0a0YwaTB0RElBQmdPZVcwMzc0QWNwa2UxODdkd05BUzB1RU13ZjFN?= =?utf-8?B?RCszd05mV2RmT2ZvSTk5cGlPMVNqa0R4SVNxd04xaitua0t3QllybmlYanBL?= =?utf-8?B?WGhoSXRySDhEY252VEl0ZTJoaHM4cDFzOGV6cDc2VWRVUGh1WGhOQzRMalcx?= =?utf-8?B?TFJOdzRIajk2eElxY0U5VWVSVlBlOHRpK2F4U0FvS3RYUUUzV3o1S2ZLd04r?= =?utf-8?B?bkxjTytRVlZ5WFpMUjZCOXJodkNsK2cwSlZGSVc3NDJ2NjV2SXBtRTBuUit4?= =?utf-8?B?MVlLN0pidDAvT0xtU082QTNMYm9iTE9FUTZ1NktkcTZNbXkra1BFWEVVcDV4?= =?utf-8?B?Sko4azY5djFBNkl4Y0IrOGVpYWRNZU5uLzc5QnJLN3pHV09NYUR4VVFHZEVw?= =?utf-8?B?MkpUSm8vRzhUcnRGVzJEYWk4eU5WY2FYcUUzcklNNEZWdVk5eTNPdGt6a0p1?= =?utf-8?B?VURXSUFQTENOZ1JDM2FrSlFQVkhqY1EzdFdFNW03Wm55TFFSWTlrWkJJOXBD?= =?utf-8?B?MlZsZC9HY3pCT2E5amVDNWMwT0drcmNSMkx4WVJvamUzRm9OZk5WTzhFTCtM?= =?utf-8?B?M1AwQ0RpWklOSHRuZmpnTVViNmtDMnZnSGlrdUdId3RzOXlxRjFHZnluWlN1?= =?utf-8?B?TFhJOVRjanZXWjhVQXIzdWxOYlZkT0FPakdLcTloQVRMMHpzTDVpSG1JdVZ6?= =?utf-8?B?MzZpVnlzeGJvMFdIRzFPZFFHUnVaTGNKeU1JdEVVT3RoZzhrc1Y3U1V5N0Fk?= =?utf-8?B?MUp5M1BvSlZWVHRRVWVGODNMK1ZXY0tMcTlETStyRGxaazYzSnUwelM3enlN?= =?utf-8?B?b2ljR2xXaE9meGVxNXZmVnpXWXprMkw2V1hkdkk3WnNTY3hJWU5TUkRvbmZZ?= =?utf-8?B?QU9UaEU3dlJONTE5MlRuVnJSS0w4OFVLZDNkdzRISUlBdnE4NVRUb3A0VHl4?= =?utf-8?B?NjJZUHBTd1lnNUdvbkpnbTNXZzVLdUxENWEwekpHTUpqdGVqYVJTZ0RZV1Zj?= =?utf-8?B?SitEVUpiRVpxS1FPc1VhSTk0MlVLWW1LOHVrcjlMZmRydSt3Vkg5dFJjR0RX?= =?utf-8?B?elRlMXlKcUFHZGFDS0RKMDFORFJMVlZmYXRlSlJyZTlRTE8rZythZjNCd0F5?= =?utf-8?B?NktjRmM1c1Y1UERBOW5pTVlsTEJxaXBFMnh4MUdLRXFFckpiS0FzY092dk9X?= =?utf-8?B?dzM5M2piOFVPQW9RSUVJZ2NzQzBOelZnVDR5SU9oUGNySkI0d1VNTk04dlR6?= =?utf-8?B?V1p1aVFEV2l4YVlKK0Q0cklLQ2tQUTJjZ01rNlBQcm96QnVGc2xPLy92R2lp?= =?utf-8?B?MHlndnNneW51UEwxb3FReUw2L2thOUl3ZmRWM2h5Y2xWQy8zQkYvWHRyR1ps?= =?utf-8?Q?/0LEQuL665AS4bqytVKy+pjmQ?= Content-Type: text/plain; charset="utf-8" Content-ID: <30C964D35E26F247BD08B3BA37BA5706@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0807b9-682b-4409-ac51-08da8f2a7f08 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2022 10:36:30.8394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6AQrlfNrQy3emqL1+JqORPMwWowjXK6IONutOCsdM5mi8LwNQSe66ttQBB3BzS83b/UPdzeV8wQiBVVCw1P6Rhh7bQRvOAiHAmEFloM8bLo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5804 T24gMDUvMDkvMjAyMiAwODowMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gQEAgLTMzMTIsMTcg KzMzMjUsMTggQEAgdm9pZCBmcmVlX2NwdV9ybV9kYXRhKHN0cnVjdCBjcHVfcm1fZGF0YSAqbWVt LCB1bnNpZ25lZCBpbnQgY3B1KQ0KPiAgICogVGhlIGNwdSBpcyBhbHJlYWR5IG1hcmtlZCBhcyAi ZnJlZSIgYW5kIG5vdCB2YWxpZCBhbnkgbG9uZ2VyIGZvciBpdHMNCj4gICAqIGNwdXBvb2wuDQo+ ICAgKi8NCj4gLWludCBzY2hlZHVsZV9jcHVfcm0odW5zaWduZWQgaW50IGNwdSkNCj4gK2ludCBz Y2hlZHVsZV9jcHVfcm0odW5zaWduZWQgaW50IGNwdSwgc3RydWN0IGNwdV9ybV9kYXRhICpkYXRh KQ0KPiAgew0KPiAgICAgIHN0cnVjdCBzY2hlZF9yZXNvdXJjZSAqc3I7DQo+IC0gICAgc3RydWN0 IGNwdV9ybV9kYXRhICpkYXRhOw0KPiAgICAgIHN0cnVjdCBzY2hlZF91bml0ICp1bml0Ow0KPiAg ICAgIHNwaW5sb2NrX3QgKm9sZF9sb2NrOw0KPiAgICAgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7DQo+ ICAgICAgaW50IGlkeCA9IDA7DQo+ICAgICAgdW5zaWduZWQgaW50IGNwdV9pdGVyOw0KPiArICAg IGJvb2wgZnJlZW1lbSA9ICFkYXRhOw0KDQp2NCBpcyBtdWNoIGNsZWFyZXIgdG8gZm9sbG93IHRo YW4gdjMuwqAgT25lIGZpbmFsIHN1Z2dlc3Rpb24sIGhhdmluZyByZWFkDQp0aHJvdWdoIHRoZSBz ZXJpZXMgYWdhaW47IHJlbmFtZSB0aGlzIHRvIGZyZWVfZGF0YSBzbyBhcyB0byByZWxhdGUgbW9y ZQ0KY2xvc2VseSB0byB3aGF0IGl0IGRvZXMuDQoNCkkgY2FuIGZpeCBvbiBjb21taXQgaWYgeW91 J3JlIGhhcHB5Lg0KDQpFdmVyeXRoaW5nIEEvVC1ieSBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 10:39:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 10:39:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398711.639628 (Exim 4.92) (envelope-from ) id 1oV9VL-0007uS-2C; Mon, 05 Sep 2022 10:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398711.639628; Mon, 05 Sep 2022 10:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9VK-0007uL-Vl; Mon, 05 Sep 2022 10:38:58 +0000 Received: by outflank-mailman (input) for mailman id 398711; Mon, 05 Sep 2022 10:38:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9VJ-0007uD-Oh for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 10:38:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1644748-2d06-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 12:38:56 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE65D5FAC0; Mon, 5 Sep 2022 10:38:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 984E813A66; Mon, 5 Sep 2022 10:38:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uuu4I7/RFWOSSwAAMHmgww (envelope-from ); Mon, 05 Sep 2022 10:38:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1644748-2d06-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662374335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2UQUyshiHmhRVmAkIS2I9YEYcgvDF1j8Yi0DuFVp8FE=; b=dIXOXWKTTLJv6i28nU1F88iiTyEFqtBJEiHK2X8T2BPfD3SMHyISLWvMF5p1CHtlWA8kFC j6J7fDwn6Guc/5ecdzl2EHNq0N3fe3yZvF31vHiRWfjxaMZYl1JXhbnIIOlaIb0IyG5vue o4B54ff+99ak0pPnxjJbHW8E5Pvv3lA= Message-ID: <334a0d3c-a7da-b03e-962a-1c6e31853c7c@suse.com> Date: Mon, 5 Sep 2022 12:38:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 3/3] xen/sched: fix cpu hotplug Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: "Henry.Wang@arm.com" , George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich References: <20220905070005.16788-1-jgross@suse.com> <20220905070005.16788-4-jgross@suse.com> <8272d775-d8d8-b526-4e39-0d75ff2b5f92@citrix.com> From: Juergen Gross In-Reply-To: <8272d775-d8d8-b526-4e39-0d75ff2b5f92@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------DRGhtZLJeSQlMkX1n57bNvoV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------DRGhtZLJeSQlMkX1n57bNvoV Content-Type: multipart/mixed; boundary="------------UeVSaT0mYYMlD5wnp4604KGW"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: "Henry.Wang@arm.com" , George Dunlap , Dario Faggioli , Gao Ruifeng , Jan Beulich Message-ID: <334a0d3c-a7da-b03e-962a-1c6e31853c7c@suse.com> Subject: Re: [PATCH v4 3/3] xen/sched: fix cpu hotplug References: <20220905070005.16788-1-jgross@suse.com> <20220905070005.16788-4-jgross@suse.com> <8272d775-d8d8-b526-4e39-0d75ff2b5f92@citrix.com> In-Reply-To: <8272d775-d8d8-b526-4e39-0d75ff2b5f92@citrix.com> --------------UeVSaT0mYYMlD5wnp4604KGW Content-Type: multipart/mixed; boundary="------------5i06FQAmsvPfmlVvOnkoYxkw" --------------5i06FQAmsvPfmlVvOnkoYxkw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDkuMjIgMTI6MzYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA1LzA5LzIw MjIgMDg6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBAQCAtMzMxMiwxNyArMzMyNSwx OCBAQCB2b2lkIGZyZWVfY3B1X3JtX2RhdGEoc3RydWN0IGNwdV9ybV9kYXRhICptZW0sIHVu c2lnbmVkIGludCBjcHUpDQo+PiAgICAqIFRoZSBjcHUgaXMgYWxyZWFkeSBtYXJrZWQgYXMg ImZyZWUiIGFuZCBub3QgdmFsaWQgYW55IGxvbmdlciBmb3IgaXRzDQo+PiAgICAqIGNwdXBv b2wuDQo+PiAgICAqLw0KPj4gLWludCBzY2hlZHVsZV9jcHVfcm0odW5zaWduZWQgaW50IGNw dSkNCj4+ICtpbnQgc2NoZWR1bGVfY3B1X3JtKHVuc2lnbmVkIGludCBjcHUsIHN0cnVjdCBj cHVfcm1fZGF0YSAqZGF0YSkNCj4+ICAgew0KPj4gICAgICAgc3RydWN0IHNjaGVkX3Jlc291 cmNlICpzcjsNCj4+IC0gICAgc3RydWN0IGNwdV9ybV9kYXRhICpkYXRhOw0KPj4gICAgICAg c3RydWN0IHNjaGVkX3VuaXQgKnVuaXQ7DQo+PiAgICAgICBzcGlubG9ja190ICpvbGRfbG9j azsNCj4+ICAgICAgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7DQo+PiAgICAgICBpbnQgaWR4ID0g MDsNCj4+ICAgICAgIHVuc2lnbmVkIGludCBjcHVfaXRlcjsNCj4+ICsgICAgYm9vbCBmcmVl bWVtID0gIWRhdGE7DQo+IA0KPiB2NCBpcyBtdWNoIGNsZWFyZXIgdG8gZm9sbG93IHRoYW4g djMuwqAgT25lIGZpbmFsIHN1Z2dlc3Rpb24sIGhhdmluZyByZWFkDQo+IHRocm91Z2ggdGhl IHNlcmllcyBhZ2FpbjsgcmVuYW1lIHRoaXMgdG8gZnJlZV9kYXRhIHNvIGFzIHRvIHJlbGF0 ZSBtb3JlDQo+IGNsb3NlbHkgdG8gd2hhdCBpdCBkb2VzLg0KPiANCj4gSSBjYW4gZml4IG9u IGNvbW1pdCBpZiB5b3UncmUgaGFwcHkuDQoNCk9oLCBwbGVhc2UsIGdvIGFoZWFkISBJJ20g ZmluZSB3aXRoIHRoZSByZW5hbWUuDQoNCj4gDQo+IEV2ZXJ5dGhpbmcgQS9ULWJ5IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQoNClRoYW5rcywNCg0KDQpK dWVyZ2VuDQoNCg== --------------5i06FQAmsvPfmlVvOnkoYxkw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5i06FQAmsvPfmlVvOnkoYxkw-- --------------UeVSaT0mYYMlD5wnp4604KGW-- --------------DRGhtZLJeSQlMkX1n57bNvoV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMV0b8FAwAAAAAACgkQsN6d1ii/Ey+/ dAf9EdW4VPMxHNW8Ldm2eQHHOiZMKCMXY1YyS7UIQ8T2ypg/77jXNluLhV+jvFn50+hp9FawEobA VNhRctwMMabvyGvym/Z821hVfkwGOHnc+QxMJOPdnkxHld07I+zPQa9qbmfYARJhE8gfB7VYEAps Lyub6g0ORydpRFbt0gJGUYvYPWVnWd0MD7/EYR/k0KhBF+Dk3/EF6WOtkK0EVUHYvNJ/RMIEOAyK wDlYQf262SDFezE7Mi1uIXq1HJGH8gfccKNwNSmtAD7ME1kSIl3zKjUUXMJwsbk4Zu9VRSxIxaON uySW7+nPIR8SqWxWFnyskCkYwSnWWVeUoFHm28l3nw== =6erF -----END PGP SIGNATURE----- --------------DRGhtZLJeSQlMkX1n57bNvoV-- From xen-devel-bounces@lists.xenproject.org Mon Sep 05 10:45:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 10:45:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398722.639652 (Exim 4.92) (envelope-from ) id 1oV9b7-00014E-UP; Mon, 05 Sep 2022 10:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398722.639652; Mon, 05 Sep 2022 10:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9b7-000147-Pu; Mon, 05 Sep 2022 10:44:57 +0000 Received: by outflank-mailman (input) for mailman id 398722; Mon, 05 Sep 2022 10:44:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9b7-00013x-Ar; Mon, 05 Sep 2022 10:44:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9b7-0007jU-8F; Mon, 05 Sep 2022 10:44:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oV9b6-000540-PT; Mon, 05 Sep 2022 10:44:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oV9b6-00051l-OX; Mon, 05 Sep 2022 10:44:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l7qNM+YFMt3FwTqzyVyjZYEhX7U6iwlJP4M9GrpKJLI=; b=DTYEgEhibaM3In5jz/yjD25XRw nMhzh1qFkTJe8ATK5h/r32dDa8KFjLl1TqITw6WW8+ZlrSYzR6vvQ+norsXZCF7Eh2uBR+cHAJHmV 1uql70PV9y9gI2apUm19D6aS/BDhYVnX+3z/WTmO3zrU5Gw5uCtF4NXy2KomNq/FPFTc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 172996: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c8b796aba31b2c97a1a56867062b3bdd0d81923f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 05 Sep 2022 10:44:56 +0000 flight 172996 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172996/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c8b796aba31b2c97a1a56867062b3bdd0d81923f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 787 days Failing since 151818 2020-07-11 04:18:52 Z 786 days 768 attempts Testing same since 172930 2022-09-02 04:20:43 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121804 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 11:13:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 11:13:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398735.639663 (Exim 4.92) (envelope-from ) id 1oVA2N-0004TJ-Aw; Mon, 05 Sep 2022 11:13:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398735.639663; Mon, 05 Sep 2022 11:13:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVA2N-0004TC-7r; Mon, 05 Sep 2022 11:13:07 +0000 Received: by outflank-mailman (input) for mailman id 398735; Mon, 05 Sep 2022 11:13:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVA2L-0004T6-Qt for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 11:13:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b52c80c5-2d0b-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 13:13:03 +0200 (CEST) Received: from DU2PR04CA0278.eurprd04.prod.outlook.com (2603:10a6:10:28c::13) by DB9PR08MB7795.eurprd08.prod.outlook.com (2603:10a6:10:39a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Mon, 5 Sep 2022 11:13:01 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::a7) by DU2PR04CA0278.outlook.office365.com (2603:10a6:10:28c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 11:13:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 11:13:00 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 05 Sep 2022 11:13:00 +0000 Received: from bf622aec953d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FE03FF8C-D3E2-45A3-8E6F-A6CAC38B6864.1; Mon, 05 Sep 2022 11:12:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf622aec953d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 11:12:50 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by VE1PR08MB5871.eurprd08.prod.outlook.com (2603:10a6:800:1ae::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 11:12:47 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 11:12:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b52c80c5-2d0b-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bI8y0hFSwpiPQ18l4W3mITeQFmZF3ZaL9rZyXL4AsQ7XY6a5+zUyzP2HR+SKKJ01ZKBGFjBJlz2ewtT3HuG36+Ym/kQgU0RxvMDJBYIgPr7WiVwjqBiLRWFGZXD8qdwXGA4JIeEY96ptLpNbKYk8UPS2RV8fDVZCqPok6AvHIJqyph4/hOWc34yhh063KSF4Mnri8/Gw12WDX2VbsKWVMSEcUpb4n4Hm6sdO3aYZkKosK/EyGQu4G62Fbdxb9ttFqkXvtFboalKror/SbU33f74OU430hNGEXAV3di83MtRfhSGic+66pmb6QKg1FeZNe7sPQp7tfHNwo2SzmNwAHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FfCop8JFo+U16ITqf9+5QrgRFfTvtTJT7PypKA86ri0=; b=khYszJVT5b0scdgr1K5xBaoKr6+dpuPcmD9xhe7PURSFPoC6fP+Kzt3ogIaf2xZyHKVRrGP/ewN1pRfpbKT0WE7bZP2OZrdC3eglziHA5cteVdlbdisbLRXFuvxGY6niu8EyDtl5OizHyJvKHLVrT1sel8U97P6MFdqFtjiZ+34YRxILj9z3l9fInSsBzIwlxjMZcSfQj9BYqYA7l7LHNdikmCKzwm1dfK7wvgVcpBfNdWBcxtBJFoavYXHfx+SXTR9p8XBWRm3KSR9iroKB7ESW+2qX0lGpIeeyYvZUPT5gINeFkxVnLj6pIPUdQAI0HJTtVelBESqaHZiBlAMzig== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FfCop8JFo+U16ITqf9+5QrgRFfTvtTJT7PypKA86ri0=; b=PWktcbuSX7QV1V9EdgoUsRRUjOjlF+P85UXdkPOx3U6nNveMCN3gXWTKkhPJG3z1SfmW2RYnQVBBnOVJOctahL0B9n0/Wf5M5d1H/6vpoYkvL2tyZTm1HaAw/MV1IS6rnWWL4y45qzMf85AmTiRBxVs3+L/1WSa09hjCoVQeRKA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9d2471f83f4dd4ca X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=asYmtwP6rYlRe1EmdUwYYfO6gC/RI1CtRURpH7+Z3WsE5gMd6oV9xr4YAjgUIRlNxK3TxeS35sI7rdY4lH0RhzJrh59MiI5aHMcWujSQcwxh+5E1gYzIMwRkta7fNhzhBgJpZpBfUt2vtuprG8m5jKKp8w9bB2yClEu1EiuPbYkYEhghFYH0w5T0Bu/PPUeiGd6cB1Rb2YqHec3AbMBXrMVjg35UZ/bDSCS6OjtwpnFUY4SEnrtXcmgL9KO7jvcrVECZgcMrdRCU9Q85hwXAunb8cX81XRHWupGynrlh1/8CvzqASFKwetiL4CMdWZ7Yuunma2rXIixdPu7WjPYV8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FfCop8JFo+U16ITqf9+5QrgRFfTvtTJT7PypKA86ri0=; b=T0xauWHPDk53m2d27RnDpmYDkRhXOLVevhOTC2pmKmxR93TQywsGK2MSM166EqIYhtoHVIIFM52MDKc/Kx6sZTdXUipild4mr3DSQBS0h9A6KVZV8RkyHFwB4R7FpGd0z5Z4EXRUpJtPoCPNcPKvivPHMc4OJTS3Dt4hRrqsYgk8p53tuUqE67/itkM7wibx/LdFsYixUxepke9QyvH3q7ZOWwMkgFS4Q18lt0s+XhaOLSUAYlo9Qq5YyYUfRPFPqK6FkviR/29rL6hrqqGzPAXzlD3JKCakSDPNVqobUmF2kvuTyDjH+Pa10pvXKdiKiivZnSdjU071WdaoG5YDXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FfCop8JFo+U16ITqf9+5QrgRFfTvtTJT7PypKA86ri0=; b=PWktcbuSX7QV1V9EdgoUsRRUjOjlF+P85UXdkPOx3U6nNveMCN3gXWTKkhPJG3z1SfmW2RYnQVBBnOVJOctahL0B9n0/Wf5M5d1H/6vpoYkvL2tyZTm1HaAw/MV1IS6rnWWL4y45qzMf85AmTiRBxVs3+L/1WSa09hjCoVQeRKA= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFZKoCAAAQmAIAADY6AgAAHOICABGESgA== Date: Mon, 5 Sep 2022 11:12:47 +0000 Message-ID: References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8783ff28-5d94-467d-97ca-08da8f2f9831 x-ms-traffictypediagnostic: VE1PR08MB5871:EE_|DBAEUR03FT039:EE_|DB9PR08MB7795:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2ZRRaily/0cFq+iD6flwmLTtGfQZehJvMKF8NW6GPuLCTb6YdS1ihkf8YsGSjrTJV3mPOQ9sP2Eyx61Sq/u64wVJVEe4ILJDficQXkzK07CTyuotyy80NiHu7nBdoie4axwUy/ChfI1sfg6/0ZM5qw7xG/Seyy8YdQK0mFs/rIXp5cPTHRg1WAZpZhBxiFcj1ju1ZiO768yaaIfz9dgt0UpDM2NAMKNeUYoyAJe9gfMsd4GTrUa76an1KjQqSaHq9+CODHZGEMz+W22+/2zAs+1v8B9aCrFLYcsmnNhHamiIZCSgoW2tlGQuyvgBmYXIyYpff/yEsNaBwZ69FblttUH5UhN9B5sIonex4NaX4NKsW5Rf2HK7NYEc0YPNjCMggPfft4x+Le0FBqn3x0CIeZvb59LVJWDEqPr5Nj9EezCCNwnbBEw62R+M8H2U1CVQ6QbspMypiJgZiYSA1F29fr19OMC6l+cwmz3L1ke2Bi3SswQi6zqxuciBjQbaBCxhj/L23s00MEm3BVB+Eekyej2JrnFp7ToZ7h4a9czqxBD/+73lgqj5zoElarzA/dCH10VqJ81t7m7aIw73KkucAD9dm1hkAPsZQvYCmOvcwzuzmimty4QdKlgVk1J0QeoeWlr9FVyFejCfY2TtSY+P/NvHzoVw8GZc2iVrjTJuICt4SKQ/9fBerye64D5de+woZp2JOWUQAeb9Lf3fcZyaU5a7AVrRqtPuI/4D0M2u8Gy1dL2smMeUIcecMccArz+16LlHWY2Tn0lOsmCVScAwDAGdcOetTTdwkPS3RUdI7Dc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39850400004)(396003)(366004)(346002)(376002)(33656002)(5660300002)(316002)(83380400001)(4326008)(8676002)(66556008)(91956017)(66476007)(8936002)(6916009)(54906003)(36756003)(66946007)(76116006)(64756008)(66446008)(2906002)(41300700001)(71200400001)(6486002)(478600001)(26005)(6512007)(86362001)(186003)(2616005)(53546011)(6506007)(38070700005)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <8DB64CB2AA8B724D8E5BCD153137C281@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5871 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 61c4ca99-1d68-4612-542a-08da8f2f906e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cmwRaoHM8dgRlKdtgSZWNZZwrMYXMimWscs8SNCEQXzsQxAPhsSiF+JpiO3uLlHZEGREXjqPWTYGhAlmz4WUrTHpuXcM81UH365NHozFqLzUciWEBoppyooqrib3n3IaTuy6eQ2uQiFqD4RRxYrPS5Fs5h1lLFHU9oH0JpX03OGMxVuAecOcMNFxOlJ84rpqYvainoA8d2Fyj9UKWlZtVQALfFQ1DPId7lg7k0lDeyyHd6lndsgUVaDVAM8/Y2mUyfUkq1datq2bgTa3xciTAsPmHob6ahcbJunHURR3obz1VwVKMt39HBzXB85UTRvata5zkRH+xJ4w+L8fKQ+6LohQ0o33tMSfdTn5Kb5wxL3A6hLiYeEeNYxZfcbudBjTRbbCUX51TKH/uJtbpmCuXd1m2jJHvQwCOorWdXhPmvoXzyKQGIAU3HLyziZiJ5QSk9WIi5AH/MrExcQ3ZoXoQu+3ZpTQACxBRC4IfNLgctvdqvtDEKHtWSdVgvpfQim6FJfc+Yowz1RI1SxEfJgp+9tRCZ5mE28ZUVAvAI4kTAyhejNbqm4xFVdiNu667sLChX8pPe8maroT0Si+TJBgi1SHlWAJHOjdJPFemJyHMoo2/emMbdkFo9opkF39BNd5C6r1Q0AqsK2q4y09mG1m5RR+QFcire8ecBF8r8N7buAeHEI3RMGSnXJVXlo9LdShpwr7k8AXZJHyf1tIim0DZNdi1VPogKYEhmFajRAIYyEaKdcwomzxon3Fvo3XPNWh1nXrJhcRCrAbqK3ctZ4GLA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(346002)(136003)(40470700004)(36840700001)(46966006)(356005)(2616005)(336012)(47076005)(41300700001)(26005)(6506007)(107886003)(6512007)(53546011)(36860700001)(83380400001)(8936002)(40460700003)(5660300002)(82310400005)(8676002)(40480700001)(6862004)(186003)(4326008)(2906002)(6486002)(478600001)(316002)(54906003)(82740400003)(86362001)(70206006)(70586007)(81166007)(33656002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 11:13:00.5968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8783ff28-5d94-467d-97ca-08da8f2f9831 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7795 Hi Julien, > On 2 Sep 2022, at 5:20 pm, Julien Grall wrote: >=20 >=20 >=20 > On 02/09/2022 16:54, Rahul Singh wrote: >> Hi Julien, >=20 > Hi Rahul, >=20 >>> On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: >>>=20 >>> Hi Bertrand, >>>=20 >>> On 02/09/2022 15:51, Bertrand Marquis wrote: >>>>> On 1 Sep 2022, at 19:15, Julien Grall wrote: >>>>> AFAIU, it is not possible to have *_xenstore =3D true and *_enhanced = =3D false. I think it would be clearer if ``dom0less_enhanced`` is turned t= o an enum with 3 values: >>>>> - None >>>>> - NOXENSTORE/BASIC >>>>> - FULLY_ENHANCED >>>>>=20 >>>>> If we want to be future proof, I would use a field 'flags' where non-= zero means enhanced. Each bit would indicate which features of Xen is expos= ed. >>>> I think that could be a good solution if we do it this way: >>>> - define a dom0less feature field and have defines like the following: >>>> #define DOM0LESS_GNTTAB >>>> #define DOM0LESS_EVENTCHN >>>> #define DOM0LESS_XENSTORE > >>>> - define dom0less enhanced as the right combination: >>>> #define DOM0LESS_ENHANCED =3D (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM= 0LESS_XENSTORE) >>>=20 >>> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead o= f defining a bit for gnttab and evtchn. This will avoid the question of why= we are introducing bits for both features but not the hypercall... >>>=20 >>> As this is an internal interface, it would be easier to modify afterwar= ds. >> How about this? >> /* >> * List of possible features for dom0less domUs >> * >> * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and >> * evtchn, will= be enabled for the VM. >=20 > Technically, the guest can already use the grant-table and evtchn interfa= ces. This also reads quite odd to me because "including" doesn't tell what'= s not enabled. So one could assume Xenstored is also enabled. In fact the w= ording for ``DOM0LESS_ENHANCED`` is what makes it a lot more confusing. >=20 > So I would suggest the following wording: >=20 > "Notify the OS it is running on top of Xen. All the default features but = Xenstore will be available. Note that an OS *must* not rely on the availabi= lity of Xen features if this is not set. > " >=20 > The wording can be updated once we properly disable event channel/grant t= able when the flag is not set. >=20 >> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. >=20 > I would make clear this can't be used without the first one. >=20 >> * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-ta= ble xenstore > * = and=20 > evtchn, will be enabled for the VM. >=20 > See above about "PV interfaces". So I would suggest to reword to: >=20 > "Notify the OS it is running on top of Xen. All the default features (inc= luding Xenstore) will be available". >=20 >> */ >> #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) >> #define DOM0LESS_XENSTORE BIT(1, UL) >=20 > Based on the comment above, I would consider to define DOM0LESS_XENSTORE = as bit 0 and 1 set. >=20 >> #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENS= TORE) =20 Bertrand and I discussed this again we came to the conclusion that DOM0LESS= _ENHANCED_BASIC is not the suitable name as this makes the code unclear and does not correspond to= DT settings. We propose this please let me know your thoughts. =20 =20 /* = =20 * List of possible features for dom0less domUs = =20 * = =20 * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature = =20 * can't be enabled without t= he DOM0LESS_ENHANCED. =20 * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All= the =20 * default features (including Xenstore) will = be =20 * available. Note that an OS *must* not rely = on the =20 * availability of Xen features if this is not= set. =20 */ = =20 #define DOM0LESS_XENSTORE BIT(0, UL) = =20 #define DOM0LESS_ENHANCED BIT(1,UL) = =20 #define DOM0LESS_ENHANCED_FULL (DOM0LESS_XENSTORE | DOM0LESS_ENHANCED) Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 11:41:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 11:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398742.639673 (Exim 4.92) (envelope-from ) id 1oVATa-0007jw-G9; Mon, 05 Sep 2022 11:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398742.639673; Mon, 05 Sep 2022 11:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVATa-0007jp-DT; Mon, 05 Sep 2022 11:41:14 +0000 Received: by outflank-mailman (input) for mailman id 398742; Mon, 05 Sep 2022 11:41:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVATZ-0007jf-ES; Mon, 05 Sep 2022 11:41:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVATZ-0000L4-A3; Mon, 05 Sep 2022 11:41:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVATY-0001RV-Mf; Mon, 05 Sep 2022 11:41:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVATY-0007lv-Lx; Mon, 05 Sep 2022 11:41:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZzZCpkGbibmfh30UAnO7/ILqzQI1d7/ZVInNiXZJR2Y=; b=GG9iJXRRzVj6skanVMLtsclTQw Yfp6+w9zQzoZcCvy/p8ZC/TqqLFmEeAKUSzcxF3hUw3FSfV470ZbvBH0VrQ72+l9S3aSyiEChIZAd 5HL5iYKfV5Q2keesCDIsF0ct6Fa2X7/4kOWDXQCl8e6KbDBvtak6+toFJD6MeW+oxFf8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 172993: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:guest-localmigrate:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e997d055929665b12246e89eb092dc79c65de9a4 X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Mon, 05 Sep 2022 11:41:12 +0000 flight 172993 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172993/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 17 guest-localmigrate fail in 172972 pass in 172993 test-amd64-i386-pair 10 xen-install/src_host fail pass in 172972 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172972 build-i386-libvirt 6 libvirt-build fail like 172972 build-arm64-libvirt 6 libvirt-build fail like 172972 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172972 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172972 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172972 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172972 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172972 build-armhf-libvirt 6 libvirt-build fail like 172972 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172972 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172972 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172972 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172972 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e997d055929665b12246e89eb092dc79c65de9a4 baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172993 2022-09-05 01:52:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Sep 05 11:43:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 11:43:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398752.639684 (Exim 4.92) (envelope-from ) id 1oVAVs-0008PI-1p; Mon, 05 Sep 2022 11:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398752.639684; Mon, 05 Sep 2022 11:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAVr-0008PB-VE; Mon, 05 Sep 2022 11:43:35 +0000 Received: by outflank-mailman (input) for mailman id 398752; Mon, 05 Sep 2022 11:43:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAVq-0008Op-Q6 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 11:43:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAVq-0000Mq-GX; Mon, 05 Sep 2022 11:43:34 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVAVq-000310-8o; Mon, 05 Sep 2022 11:43:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4j3kzyEP7VlimZbrNJEO5D4sGqyfvcKwWz5KKi8AhVM=; b=gxhvUq8PxwsoNs4m7I1h4JCDc9 nt8jTRUrYs7dGxkRb1PkBijkjGLjY5B13jMcwWETytHWXHbXRSbcZLjXHmfneCht0QmWBRXhD/lHO /B2+OG4MiTEHSUHltmkNZ0HU8qR+YkNNVekcRfjHNo5Cwa6gywhtduwxK2cTN42K3R/o=; Message-ID: Date: Mon, 5 Sep 2022 12:43:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Content-Language: en-US To: Rahul Singh Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/09/2022 12:12, Rahul Singh wrote: > Hi Julien, Hi Rahul, > >> On 2 Sep 2022, at 5:20 pm, Julien Grall wrote: >> >> >> >> On 02/09/2022 16:54, Rahul Singh wrote: >>> Hi Julien, >> >> Hi Rahul, >> >>>> On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: >>>> >>>> Hi Bertrand, >>>> >>>> On 02/09/2022 15:51, Bertrand Marquis wrote: >>>>>> On 1 Sep 2022, at 19:15, Julien Grall wrote: >>>>>> AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an enum with 3 values: >>>>>> - None >>>>>> - NOXENSTORE/BASIC >>>>>> - FULLY_ENHANCED >>>>>> >>>>>> If we want to be future proof, I would use a field 'flags' where non-zero means enhanced. Each bit would indicate which features of Xen is exposed. >>>>> I think that could be a good solution if we do it this way: >>>>> - define a dom0less feature field and have defines like the following: >>>>> #define DOM0LESS_GNTTAB >>>>> #define DOM0LESS_EVENTCHN >>>>> #define DOM0LESS_XENSTORE > >>>>> - define dom0less enhanced as the right combination: >>>>> #define DOM0LESS_ENHANCED = (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0LESS_XENSTORE) >>>> >>>> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of defining a bit for gnttab and evtchn. This will avoid the question of why we are introducing bits for both features but not the hypercall... >>>> >>>> As this is an internal interface, it would be easier to modify afterwards. >>> How about this? >>> /* >>> * List of possible features for dom0less domUs >>> * >>> * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and >>> * evtchn, will be enabled for the VM. >> >> Technically, the guest can already use the grant-table and evtchn interfaces. This also reads quite odd to me because "including" doesn't tell what's not enabled. So one could assume Xenstored is also enabled. In fact the wording for ``DOM0LESS_ENHANCED`` is what makes it a lot more confusing. >> >> So I would suggest the following wording: >> >> "Notify the OS it is running on top of Xen. All the default features but Xenstore will be available. Note that an OS *must* not rely on the availability of Xen features if this is not set. >> " >> >> The wording can be updated once we properly disable event channel/grant table when the flag is not set. >> >>> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. >> >> I would make clear this can't be used without the first one. >> >>> * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-table xenstore > * and >> evtchn, will be enabled for the VM. >> >> See above about "PV interfaces". So I would suggest to reword to: >> >> "Notify the OS it is running on top of Xen. All the default features (including Xenstore) will be available". >> >>> */ >>> #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) >>> #define DOM0LESS_XENSTORE BIT(1, UL) >> >> Based on the comment above, I would consider to define DOM0LESS_XENSTORE as bit 0 and 1 set. >> >>> #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE) > > Bertrand and I discussed this again we came to the conclusion that DOM0LESS_ENHANCED_BASIC is not > the suitable name as this makes the code unclear and does not correspond to DT settings. We propose this > please let me know your thoughts. To me the default of "enhanced" should be all Xen features. Anything else should be consider as reduced/basic/minimum. Hence why I still think we need to add it in the name even if this is not what we expose in the DT. In fact... > > /* > * List of possible features for dom0less domUs > * > * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > * can't be enabled without the DOM0LESS_ENHANCED. > * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > * default features (including Xenstore) will be > * available. Note that an OS *must* not rely on the > * availability of Xen features if this is not set. ... what you wrote here match what I wrote above. So it is not clear to me what's the point of having a flag DOM0LESS_XENSTORE. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 11:47:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 11:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398759.639696 (Exim 4.92) (envelope-from ) id 1oVAZM-0000an-Hk; Mon, 05 Sep 2022 11:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398759.639696; Mon, 05 Sep 2022 11:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAZM-0000ag-E6; Mon, 05 Sep 2022 11:47:12 +0000 Received: by outflank-mailman (input) for mailman id 398759; Mon, 05 Sep 2022 11:47:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAZL-0000aa-7Q for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 11:47:11 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79463df1-2d10-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 13:47:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 295E9B8110F for ; Mon, 5 Sep 2022 11:47:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D57D9C433D7 for ; Mon, 5 Sep 2022 11:47:07 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id b19so8963964ljf.8 for ; Mon, 05 Sep 2022 04:47:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79463df1-2d10-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662378427; bh=NHuH20RrQjxRSqiH0mBVZk8zTQuLxuDS7k7p+r4UxA0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VmsO4/rrmylf8/u2/pk96SzSMvTQRigqOOVMVv/F+2rcKfVibHN50t5Ci/AkViS2D /1qKssYq733OPSahQv7niTSffy4hTNp4Hh68Y0MUtCwbHm9Bohc3JX/Ve4W3cOBUQq lcrrbCkRo74vijamxAJIG88UIKkbxNsLfXGztX/9fgOaHStHuOKCXU5uy502mSPhFX jsaY/YTxs+e35PkZX26ypa0aixYJ5pivEkDO5he42wLqBcPlp/85obB6sHiBo94qF7 I1XEzbL4Z7EdhBhua8TCf+zRDc4LvGNK4Frar9/jdc1pNW0iOcAK/Z6uoIn3vzq23G Ki1PWLlwSdnIQ== X-Gm-Message-State: ACgBeo2+BbDpZ2NTm3m+jtsehEPieNvoB3zHb7SNw2UQC04i8lvjdp3K 22I12NHNltAjyv9GlcL7+CBYTvQ3nFjwZvaVyWk= X-Google-Smtp-Source: AA6agR7BAfNwXqTdiA+9ukiurbQmio6yAhB7Swj2kfchvdOlIHXq4ha1E1EZD4MjF6Zgfu08ZnI0Zywhrl+jacxNRI0= X-Received: by 2002:a2e:710c:0:b0:264:ed38:e57f with SMTP id m12-20020a2e710c000000b00264ed38e57fmr9678972ljc.189.1662378425797; Mon, 05 Sep 2022 04:47:05 -0700 (PDT) MIME-Version: 1.0 References: <20220828025158.1455-1-demi@invisiblethingslab.com> In-Reply-To: <20220828025158.1455-1-demi@invisiblethingslab.com> From: Ard Biesheuvel Date: Mon, 5 Sep 2022 13:46:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] Add support for ESRT loading under Xen To: Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Sun, 28 Aug 2022 at 04:52, Demi Marie Obenour wrote: > > This is needed for fwupd to work in Qubes OS. > Please elaborate on: - the current situation - why this is a problem - why your approach is a reasonable solution. > Signed-off-by: Demi Marie Obenour > --- > Changes since v1: > > - Use a different type (struct xen_efi_mem_info) for memory information > provided by Xen, as Xen reports it in a different way than the > standard Linux functions do. > > drivers/firmware/efi/esrt.c | 49 +++++++++++++++++++++++++++---------- > drivers/xen/efi.c | 32 ++++++++++++++++++++++++++ > include/linux/efi.h | 18 ++++++++++++++ > 3 files changed, 86 insertions(+), 13 deletions(-) > > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > index 2a2f52b017e736dd995c69e8aeb5fbd7761732e5..c0fc149a838044cc16bb08a374a0c8ea6b7dcbff 100644 > --- a/drivers/firmware/efi/esrt.c > +++ b/drivers/firmware/efi/esrt.c > @@ -243,27 +243,50 @@ void __init efi_esrt_init(void) > void *va; > struct efi_system_resource_table tmpesrt; > size_t size, max, entry_size, entries_size; > - efi_memory_desc_t md; > - int rc; > phys_addr_t end; > - > - if (!efi_enabled(EFI_MEMMAP)) > - return; > + uint32_t type; > > pr_debug("esrt-init: loading.\n"); > if (!esrt_table_exists()) > return; > > - rc = efi_mem_desc_lookup(efi.esrt, &md); > - if (rc < 0 || > - (!(md.attribute & EFI_MEMORY_RUNTIME) && > - md.type != EFI_BOOT_SERVICES_DATA && > - md.type != EFI_RUNTIME_SERVICES_DATA)) { > - pr_warn("ESRT header is not in the memory map.\n"); > + if (efi_enabled(EFI_MEMMAP)) { > + efi_memory_desc_t md; > + > + if (efi_mem_desc_lookup(efi.esrt, &md) < 0 || > + (!(md.attribute & EFI_MEMORY_RUNTIME) && > + md.type != EFI_BOOT_SERVICES_DATA && > + md.type != EFI_RUNTIME_SERVICES_DATA)) { > + pr_warn("ESRT header is not in the memory map.\n"); > + return; > + } > + > + type = md.type; > + max = efi_mem_desc_end(&md); > + } else if (IS_ENABLED(CONFIG_XEN_EFI) && efi_enabled(EFI_PARAVIRT)) { > + struct xen_efi_mem_info info; > + > + if (!xen_efi_mem_info_query(efi.esrt, &info)) { > + pr_warn("Failed to lookup ESRT header in Xen memory map\n"); > + return; > + } > + > + type = info.type; > + max = info.addr + info.size; > + > + /* Recent Xen versions relocate the ESRT to memory of type > + * EfiRuntimeServicesData, which Xen will not reuse. If the ESRT This violates the EFI spec, which spells out very clearly that the ESRT must be in EfiBootServicesData memory. Why are you deviating from this? > + * is not in EfiRuntimeServicesData memory, it has not been reserved > + * by Xen and might be allocated to other guests, so it cannot > + * safely be used. */ > + if (type != EFI_RUNTIME_SERVICES_DATA) { > + pr_warn("Xen did not reserve ESRT, ignoring it\n"); > + return; > + } > + } else { > return; > } > > - max = efi_mem_desc_end(&md); > if (max < efi.esrt) { > pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n", > (void *)efi.esrt, (void *)max); > @@ -333,7 +356,7 @@ void __init efi_esrt_init(void) > > end = esrt_data + size; > pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end); > - if (md.type == EFI_BOOT_SERVICES_DATA) > + if (type == EFI_BOOT_SERVICES_DATA) > efi_mem_reserve(esrt_data, esrt_data_size); > > pr_debug("esrt-init: loaded.\n"); > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c > index d1ff2186ebb48a7c0981ecb6d4afcbbb25ffcea0..b313f213822f0fd5ba6448f6f6f453cfda4c7e23 100644 > --- a/drivers/xen/efi.c > +++ b/drivers/xen/efi.c > @@ -26,6 +26,7 @@ > > #include > #include > +#include > #include > #include > > @@ -40,6 +41,37 @@ > > #define efi_data(op) (op.u.efi_runtime_call) > > +static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, > + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); > + > +bool xen_efi_mem_info_query(u64 phys_addr, struct xen_efi_mem_info *md) > +{ > + struct xen_platform_op op = { > + .cmd = XENPF_firmware_info, > + .u.firmware_info = { > + .type = XEN_FW_EFI_INFO, > + .index = XEN_FW_EFI_MEM_INFO, > + .u.efi_info.mem.addr = phys_addr, > + .u.efi_info.mem.size = ((u64)-1ULL) - phys_addr, > + } > + }; > + union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info; > + int rc; > + > + memset(md, 0, sizeof(*md)); /* initialize md even on failure */ > + rc = HYPERVISOR_platform_op(&op); > + if (rc) { > + pr_warn("Could not obtain information on address %llu from Xen: " > + "error %d\n", phys_addr, rc); > + return false; > + } > + md->addr = info->mem.addr; > + md->size = info->mem.size; > + md->attr = info->mem.attr; > + md->type = info->mem.type; > + return true; > +} > + > static efi_status_t xen_efi_get_time(efi_time_t *tm, efi_time_cap_t *tc) > { > struct xen_platform_op op = INIT_EFI_OP(get_time); > diff --git a/include/linux/efi.h b/include/linux/efi.h > index d2b84c2fec39f0268324d1a38a73ed67786973c9..0598869cdc924aef0e2b9cacc4450b728e1a98c7 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -1327,1 +1327,19 @@ struct linux_efi_coco_secret_area { > +/* Result of a XEN_FW_EFI_MEM_INFO query */ > +struct xen_efi_mem_info { > + uint64_t addr; /* address queried */ > + uint64_t size; /* remaining bytes in memory region */ > + uint64_t attr; /* attributes */ > + uint32_t type; /* type */ > +}; > + > +#if IS_ENABLED(CONFIG_XEN_EFI) > +extern bool xen_efi_mem_info_query(u64 phys_addr, struct xen_efi_mem_info *out_md); > +#else > +static inline bool xen_efi_mem_info_query(u64 phys_addr, struct xen_efi_mem_info *out_md) > +{ > + BUILD_BUG(); > + return false; > +} > +#endif > + > #endif /* _LINUX_EFI_H */ > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Sep 05 11:54:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 11:54:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398767.639707 (Exim 4.92) (envelope-from ) id 1oVAgk-00023i-AV; Mon, 05 Sep 2022 11:54:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398767.639707; Mon, 05 Sep 2022 11:54:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAgk-00023b-7b; Mon, 05 Sep 2022 11:54:50 +0000 Received: by outflank-mailman (input) for mailman id 398767; Mon, 05 Sep 2022 11:54:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAgi-00023T-TY for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 11:54:49 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2085.outbound.protection.outlook.com [40.107.105.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89e7a6a0-2d11-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 13:54:47 +0200 (CEST) Received: from DB9PR05CA0005.eurprd05.prod.outlook.com (2603:10a6:10:1da::10) by DBAPR08MB5701.eurprd08.prod.outlook.com (2603:10a6:10:1a6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 11:54:41 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::88) by DB9PR05CA0005.outlook.office365.com (2603:10a6:10:1da::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 11:54:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 11:54:41 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Mon, 05 Sep 2022 11:54:41 +0000 Received: from d1b8e7878359.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B7E1B622-B00A-4C94-A5E6-A6604F9FE171.1; Mon, 05 Sep 2022 11:54:34 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1b8e7878359.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 11:54:34 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB7622.eurprd08.prod.outlook.com (2603:10a6:102:240::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 11:54:33 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 11:54:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89e7a6a0-2d11-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b1klfK46kUbtDP246cEsnGm4dU6EHHmpy94pRy1AKZFq+WRKBne3pG1GM4aOsPjHtq0PSNpGI5gqx5KFhQQ/iE6SUQdG74BMH8UNdVK0I0XpHwrCNYg4Zq61xTEgrlroaHh7iw9Uvh6+v5mYvfNd+v8yKe2ZH9PVi/d8Lv9E96pd/DOv1fT/b99Tj6oFcmzfXa2AxXdKM117rLi2Oe0+/GVk8wMDaiGoQHo997CI2CHpbbgCB2LAZdrgyu3Ral0Exy/+sfV6P3abCK9SPjKc2p5MnuRa4o3AM9NShQg5vRcPyNPdXMcDXP++YGES25q6meAV3awYdbjbX8omUKOdWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWAtu2dRfS5JQG8mucNPIuH9nckkItnfdNbwzyKRpZA=; b=Mldw94TdYe4fEeI6L2fplEJkmveYSNs9LkiHESl3fMGIKn8ACRWKZgxyo4traE4T64np1U7dchyDftPyM0bFJEKail6b35hXL0Z8oaZs2Qydw9Dq4C39XE5/wSCUHtEc1UHguX8GB+zwx4boox5lSdX1OpQ8VFSLKycTtnS2yDiOv6P/cPfg+ipRhi3mXhrhOugQLM0NxqvsUPLOqa27wUIHVNEZa+8zE3PwNolBHK6KLzlVk8f5NL+jFlPbMn6+bsANwAneWQjryeH4dulzE+syO/Q9bQhjQfXAWgufpELv8t+XbhaLC+Y2GWHCCchjNMk//SQF5QEmcOHzbAngvQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWAtu2dRfS5JQG8mucNPIuH9nckkItnfdNbwzyKRpZA=; b=4/DGfCpkE7V8qnWuWa8VufCJPZwJeYG4Ydbs8UQiBuyydbx0qHmbQwVyDC8F2HAfzHkw3uFikNe1iD5Zej914h6wp/vmzi+5pDCFs+XLJsgvg8PlFKfbdUmfEmhXhNXpAFJhQEEw3OQV8sItRczN02V1mSdD8vhmQKuGrVeI3tg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5778ae41984c9e32 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOwdmx5bFLwlPFE7D11NQJztYowm+6xurfXI8znbuK2zmyVyfBOE64oUl4jIjKOaWQZUqmXUqbLhtvye6ApvJSTiBZdoEyRrdKC25CDG8NNZXq87AKGCphKK0+j1f7KJKDV+8T5tfvGovgDDisCOdQHkUEP3W5e/65d0/aGPS92igOTEjF+JXuN8+7E8Ytr1NZvndRziP6GiRAUgzJVkbl3MBXu1yFz5ABNvm4XIlgZYXnuySargWA8md/pf2uxGG3Mt0bGasRlAmdVNEkcPD+jwHjd+c5Ud8OBf19Mb67Rulv3ehxXww+MI0BfZO79X1Pzq9xo/hyr99DLCdo4YFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWAtu2dRfS5JQG8mucNPIuH9nckkItnfdNbwzyKRpZA=; b=C157JP1Ctv8CSs5HUdVWO2H0smWypnIQ30kV1slJ0F5Ml7yoOXGodsaB1i8YCeE58vGM8V+ZKhCyCeHQ1dHwxvBSJJvqHS4uaBhOTKlAlvNYXwXrN0cbj84NM6CihxaLCV3xBeIJzWzqXt4sLsjoruZmSA8yawAAjpCqIGeRGbKCnnyueMSOuajDtGt4eONQIWNH3kBaylnqkw9Wsx3J9j3AXjtDxnB5UvuXqBzuxXlL9yL4rjvrHgHb2XxCS/a1EPFBiFO6fyN6/Moctw/pDQRV0aj4ezWPhdd3VUt2WnuYnFbneatbu/cdR6A546MLnp87G/jtMN0iJpaKc3SYnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWAtu2dRfS5JQG8mucNPIuH9nckkItnfdNbwzyKRpZA=; b=4/DGfCpkE7V8qnWuWa8VufCJPZwJeYG4Ydbs8UQiBuyydbx0qHmbQwVyDC8F2HAfzHkw3uFikNe1iD5Zej914h6wp/vmzi+5pDCFs+XLJsgvg8PlFKfbdUmfEmhXhNXpAFJhQEEw3OQV8sItRczN02V1mSdD8vhmQKuGrVeI3tg= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOAeMLlOwX5Mka7ZrpAabJW7K3K4ewAgAFZKACAAAQoAIAADY8AgAAHN4CABGESgIAACJcAgAADEoA= Date: Mon, 5 Sep 2022 11:54:32 +0000 Message-ID: <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d7ae3801-ea31-45e8-8dfc-08da8f356ab2 x-ms-traffictypediagnostic: PAXPR08MB7622:EE_|DBAEUR03FT039:EE_|DBAPR08MB5701:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IWXIcc+XADgeXaLp+3rpIa/vnCGQxun8On4OKCcVcjoRKmjbBvDzB6cGyrH243yHscfMFNS3k4pe+dO2YcmMaKha0ZDCoanxLYibF69ltUYGWgN90bQHNYKOzLJA5+sShsmy2aB0pLwV++1hP3NvAJKmgrsi0VS6c1udQH3g75ae3WfHzYIsSbigYXXs/X0ehbDCbjDKWXI/nTrwshZ6lxg0xCwlZM+XCe/rkKls3pKvrPqxqSI7TQLitDXl0D1eqcPH8Gze7B8NiZUoc0jZikFGKcYDoSXf2q2LiBEx/gP5hQdHnz9J17x4mTfrV7oMpQ7FDQECoY+Ptz1ZeW+ESHg63CzvATVbgXlus8DETbLMyFbvpaVhoAuj/ZfaWtgCdskI/hvPav5elxKnw/GBR+NWXQh/h/Eas5ms2rGeoiCYt9bInG4vdesr/0qV9fRPn9e5VQppgnpYm8aCqb2M0zObQQyhLjTaEGE4h5J+btIMVFv9ukPd8HsoCDDjM15HKjS6spvRVVVZoRfyJZS2ax9a8w+DktHgLqoSmi6+UKoe8+gqlGjNyQpi0LFxfxit650vAahtfPvSijZg46xW5kPFOB+8abJwcGD4fV4DP4adRdB0EKJ9FPyVyRB858I3uuMo5qaokeKWvBv3234nQJ/Z0ZQMs/VPZQjAU+DHZs3VkaznIcvLdzYLFaHXvivgHR2r02jYQ2kUkLVJ3yd8wBcjtvMTpveBKHibiJKYbTIv4qJviJGlAkdDhDYGZBduBy+qkTbu/rlybw7JwnEDyeEjUjqNERVY8AAEOuRV81c= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(376002)(39850400004)(346002)(316002)(91956017)(4326008)(8676002)(76116006)(66556008)(66476007)(66446008)(5660300002)(64756008)(66946007)(122000001)(38070700005)(6512007)(478600001)(26005)(6506007)(38100700002)(71200400001)(41300700001)(6486002)(53546011)(36756003)(54906003)(6916009)(186003)(86362001)(33656002)(2616005)(83380400001)(2906002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <9337BC55D06EA2489DD253D92D4051B9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7622 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1a88275a-98a9-4e5a-1286-08da8f35653b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LSVGYPYAloLZsXhH5PKcAFpR5dFUpPKzc4HHth/5N1gG7H8HGBclLr89jkZ2uz/Zsef34zAyC15wtHoAymAANX71vQJV3tkopk2c1VwGHZLpPlcLANiRf2pvrWOfLexydfBZ1UHl1agDHSwq5RFWLf2eqqKG209p5FwqP+Ygx9EKl8AXVerBsR0Knc5Sa+rG8n52rOelhOjxCRgPGSxBYJcUrhXLOUzXtKse9wMhM9AY4U2HyYZfy5/n4lIYSXqs7qhn5PBlpgx8aYuBwLO3mzII/klJkATG5CCribk/blYjpdJ7COaZTvGP2GFfbbqAtoQfMpoucR7WDHJVYSp6u1FWBJz0oLKZ3OT/WgCR4r2uHvzZ08ZYtvLKnibjP8do4RfrnlNMWQXELiuqIrYF1D15Dq3fe7TEVXcWgyi7XViwxQA4vKqiFC+oUXewAcmr52ACB9t1kYiKltdXXSkuXtn8sluxQxXouZbhwsQ0vo3UHLjEyKEAB/xFDQKmHfhPgfdok0voFtqsWfdZlpil7i+MsvITJ4O86349wdnFWMKcO7+O5Wj0wls6SZbBe5k66KglMlFa/ap25lkm04HUJUopxzbbnwashHAjUisrAjQw+caJ1scFTFxWhflpAyD6kIBOkQ/WCSMANdn4/pBQdPsHMFtDOhnRqvwlq2PbxsC+Vcmevy55vAaNwyso5G6eI1jP6pkVCGRJlbB+G9MW3ZJTy04/D26UIRe0sE1nLFoxT90xLnWXcrXpV4IL7zq0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(36840700001)(46966006)(86362001)(82310400005)(40480700001)(53546011)(36860700001)(82740400003)(36756003)(54906003)(316002)(2906002)(70586007)(70206006)(4326008)(478600001)(8676002)(81166007)(356005)(33656002)(5660300002)(83380400001)(336012)(6862004)(186003)(41300700001)(107886003)(6512007)(6486002)(6506007)(8936002)(26005)(2616005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 11:54:41.2315 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7ae3801-ea31-45e8-8dfc-08da8f356ab2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5701 Hi Julien, > On 5 Sep 2022, at 12:43, Julien Grall wrote: >=20 >=20 >=20 > On 05/09/2022 12:12, Rahul Singh wrote: >> Hi Julien, >=20 > Hi Rahul, >=20 >>> On 2 Sep 2022, at 5:20 pm, Julien Grall wrote: >>>=20 >>>=20 >>>=20 >>> On 02/09/2022 16:54, Rahul Singh wrote: >>>> Hi Julien, >>>=20 >>> Hi Rahul, >>>=20 >>>>> On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: >>>>>=20 >>>>> Hi Bertrand, >>>>>=20 >>>>> On 02/09/2022 15:51, Bertrand Marquis wrote: >>>>>>> On 1 Sep 2022, at 19:15, Julien Grall wrote: >>>>>>> AFAIU, it is not possible to have *_xenstore =3D true and *_enhance= d =3D false. I think it would be clearer if ``dom0less_enhanced`` is turned= to an enum with 3 values: >>>>>>> - None >>>>>>> - NOXENSTORE/BASIC >>>>>>> - FULLY_ENHANCED >>>>>>>=20 >>>>>>> If we want to be future proof, I would use a field 'flags' where no= n-zero means enhanced. Each bit would indicate which features of Xen is exp= osed. >>>>>> I think that could be a good solution if we do it this way: >>>>>> - define a dom0less feature field and have defines like the followin= g: >>>>>> #define DOM0LESS_GNTTAB >>>>>> #define DOM0LESS_EVENTCHN >>>>>> #define DOM0LESS_XENSTORE > >>>>>> - define dom0less enhanced as the right combination: >>>>>> #define DOM0LESS_ENHANCED =3D (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| D= OM0LESS_XENSTORE) >>>>>=20 >>>>> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead= of defining a bit for gnttab and evtchn. This will avoid the question of w= hy we are introducing bits for both features but not the hypercall... >>>>>=20 >>>>> As this is an internal interface, it would be easier to modify afterw= ards. >>>> How about this? >>>> /* >>>> * List of possible features for dom0less domUs >>>> * >>>> * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table a= nd >>>> * evtchn, wi= ll be enabled for the VM. >>>=20 >>> Technically, the guest can already use the grant-table and evtchn inter= faces. This also reads quite odd to me because "including" doesn't tell wha= t's not enabled. So one could assume Xenstored is also enabled. In fact the= wording for ``DOM0LESS_ENHANCED`` is what makes it a lot more confusing. >>>=20 >>> So I would suggest the following wording: >>>=20 >>> "Notify the OS it is running on top of Xen. All the default features bu= t Xenstore will be available. Note that an OS *must* not rely on the availa= bility of Xen features if this is not set. >>> " >>>=20 >>> The wording can be updated once we properly disable event channel/grant= table when the flag is not set. >>>=20 >>>> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM= . >>>=20 >>> I would make clear this can't be used without the first one. >>>=20 >>>> * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-= table xenstore > * = and >>> evtchn, will be enabled for the VM. >>>=20 >>> See above about "PV interfaces". So I would suggest to reword to: >>>=20 >>> "Notify the OS it is running on top of Xen. All the default features (i= ncluding Xenstore) will be available". >>>=20 >>>> */ >>>> #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) >>>> #define DOM0LESS_XENSTORE BIT(1, UL) >>>=20 >>> Based on the comment above, I would consider to define DOM0LESS_XENSTOR= E as bit 0 and 1 set. >>>=20 >>>> #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XE= NSTORE) >> Bertrand and I discussed this again we came to the conclusion that DOM0= LESS_ENHANCED_BASIC is not >> the suitable name as this makes the code unclear and does not correspond= to DT settings. We propose this >> please let me know your thoughts. >=20 > To me the default of "enhanced" should be all Xen features. Anything else= should be consider as reduced/basic/minimum. Hence why I still think we ne= ed to add it in the name even if this is not what we expose in the DT. In f= act... >> /* >> * List of possible features for dom0less domUs >> * >> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature >> * can't be enabled withou= t the DOM0LESS_ENHANCED. >> * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. = All the >> * default features (including Xenstore) wi= ll be >> * available. Note that an OS *must* not re= ly on the >> * availability of Xen features if this is = not set. >=20 > ... what you wrote here match what I wrote above. So it is not clear to m= e what's the point of having a flag DOM0LESS_XENSTORE. When we looked at the code with the solution using BASIC, it was really not= easy to understand. By the way the comment is wrong and correspond to what should be ENHANCED_F= ULL here ENHANCED would be the base without Xenstore. Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:04:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:04:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398776.639718 (Exim 4.92) (envelope-from ) id 1oVAqC-0003ee-DQ; Mon, 05 Sep 2022 12:04:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398776.639718; Mon, 05 Sep 2022 12:04:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAqC-0003eX-Aa; Mon, 05 Sep 2022 12:04:36 +0000 Received: by outflank-mailman (input) for mailman id 398776; Mon, 05 Sep 2022 12:04:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAqA-0003e8-Uy for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:04:35 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2057.outbound.protection.outlook.com [40.107.100.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6993845-2d12-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 14:04:33 +0200 (CEST) Received: from BN9PR03CA0140.namprd03.prod.outlook.com (2603:10b6:408:fe::25) by MW4PR12MB7119.namprd12.prod.outlook.com (2603:10b6:303:220::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 12:04:29 +0000 Received: from BN8NAM11FT057.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::cb) by BN9PR03CA0140.outlook.office365.com (2603:10b6:408:fe::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 12:04:28 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT057.mail.protection.outlook.com (10.13.177.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 12:04:28 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 07:04:26 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 5 Sep 2022 07:04:26 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 5 Sep 2022 07:04:25 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6993845-2d12-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rp+s7wyMNPsptLieyDaBq3W20FfRw0AD6c0ouJpxI6+GQhnID4u9vK/8MYTrg50ZcJUdLJVZahirVzUElLoVuZ2eZY3WShMkLuZsbNpgoIKRw0nGjzvCfzUxyg3ziWj7sVllMqU2F4AXkJ5jP+6nORaL+5gZqIfoPU+lz5bEcuXSiF+ZUEyw7u95BonIhCYpQRbnGJJ1bf7gewDCoiVjFJbu+uCFRvyF+0IRHyxaDHtaFHrL/u3RrS+9ct3EdzEd1D4IcLdfolNhtScC5sAh8VcmmGWIiw+4f9a8Ce62PMbZT33iypKb1605Fqa6Ch3UFhb0LJKz5TmG9F6d5wKrmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yj8RwooBFay5ImDaoLqnb0VynjqAuZ3CV+5rX8NPc20=; b=IEWpMgUE087DRTqZg+7sF/0G5K/sP2hQFn+bQlnHLqmUCThI/GeFAeU3jryiVRqz4nCkwWTLQzvupRo4M8ZFq9D/kcdB0pe1LyhLWvf0JTZG/VJHZDuneCZn0M4U40CofLYQSySixcXqbeLTMUbxEau9C04eDz9yU4u888VRiATA7YQYyd0j2/4/ZQ6txbsWXkgagrzy/HALgbFUlarh+qf0WLFG2L/EYgxV0A8dD39jUUsYuj0B6rOfo5D2nqeW+oJkgDbVZ1pynF8KtJkEZ2emI2Qw7ewtAmxPmfy+WnPMpNmTzyBjVkGcwGP+nTlPH5A5SNL5h/j40aLpfVVbAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yj8RwooBFay5ImDaoLqnb0VynjqAuZ3CV+5rX8NPc20=; b=PbMYYtyrgQPYJMWsOs2uQcF3SqfxNoFWK7pPPMC3VSrUl5jCqvgjtS1x1DNxADFOVAJlsqUuzZMUza3unZeVFgLjwQP6MxNkCC5pQuwVZuslSBa6RAigUzDvfn4XoIUVTkJt1zHrG9p8kjDZGov77AjqY1MbYXPqwxkGafUB9j0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Mon, 5 Sep 2022 14:04:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Content-Language: en-US To: Henry Wang , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , "Penny Zheng" References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> From: Michal Orzel In-Reply-To: <20220905072635.16294-2-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5313e51-8fb7-4a37-d629-08da8f36c8a5 X-MS-TrafficTypeDiagnostic: MW4PR12MB7119:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rrzxzhZ6A8Z0SShBlaqbjcODFLcWXuejVNBg+UJJgfQE/Q9N340fhOAoRW3BEGeAKzrl60iJZgOHo/81wNt2QTA+xTvBzlFk8oRWcbA6YtbU8SB1CrJtocdQQzsERFxXo0Y5PBn4cjcSDjggLDHN99pSXWcyzphpgwgwgebL15UYcZcTE1ynO3duD3qIrZY5iVTDGyDaZyTQ9y+CQ2s4msB5NOW3VmGJyahEpxX64du/azVYio2mJpE2EqYQvf1X836rrmtYqmrTVr06ABvQPfG4X4o1q8LANPgsYRojy4bltSl+depHonJXcVIQKlOW7Trtk6jiqj1ON+OTi0OiHbsQWqHTjJ+VOM1EKjdyMo+epyoj8lSz1To/N1qRP1SjP1AxM5vRaiDr41iD2J/83eDe313NCSP/feHRpd0EMntKcUGYo6RWnjfAhWSwPZNO6Y2OQTn+LG/uWwFevO6zVuG1RgGYXR5S+hW5+dkTL/YnZ8Bbh/sQcfAkFXISFigQknTypoKGwFjeZOHOy3tTShE58eV/9ozatAw+nqc1X7pvBZfitUEXfMoZ4HgCHmGu0MeI3O4NHeb7Aa9vB/iN+NllnRB809x7WW/323YQtjL9T54iWI20cisTVGKpz5mfAzeNxDGTV/v6O363s/150WxmS13yggOKzT05pGPFYRr4aYdVA6w1Y4hQFwqpAEmLiAtCTNOXsXIeyjdtDSOjeaYwgyfSsdrziyLHvfX8VsUFybfatLdg4f1u5oJwCxzetjUZqM8hTRA+f8pUoHzPD2YC3LIUMpNmuuASCyQWXYZJ3wgT9dJQ0+qR8pBJCzD9ADtKI821S5eqlZdJq6J8WQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(396003)(376002)(46966006)(36840700001)(40470700004)(82740400003)(44832011)(4326008)(8676002)(5660300002)(478600001)(8936002)(4744005)(53546011)(86362001)(31696002)(40460700003)(41300700001)(36860700001)(356005)(81166007)(82310400005)(26005)(2906002)(40480700001)(47076005)(426003)(2616005)(16576012)(83380400001)(70586007)(70206006)(336012)(316002)(36756003)(31686004)(186003)(54906003)(110136005)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 12:04:28.2882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5313e51-8fb7-4a37-d629-08da8f36c8a5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT057.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7119 Hi Henry, On 05/09/2022 09:26, Henry Wang wrote: > > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..d0cc556833 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -22,11 +22,16 @@ typedef enum { > BOOTMOD_UNKNOWN > } bootmodule_kind; > > +typedef enum { > + MEMBANK_MEMORY, > + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain. */ > + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */ > +} membank_type; Whereas the patch itself looks ok (it must be modified anyway given the comments for patch #2), MEMBANK_XEN_DOMAIN name is quite ambiguous to me, now when it is part of membank_type enum. Something like MEMBANK_STATIC or MEMBANK_STATICMEM would be much cleaner in my opinion as it would directly indicate what type of memory we are talking about. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:08:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:08:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398783.639729 (Exim 4.92) (envelope-from ) id 1oVAtY-0004HL-V1; Mon, 05 Sep 2022 12:08:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398783.639729; Mon, 05 Sep 2022 12:08:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAtY-0004HE-Px; Mon, 05 Sep 2022 12:08:04 +0000 Received: by outflank-mailman (input) for mailman id 398783; Mon, 05 Sep 2022 12:08:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAtX-0004Fn-Cp for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:08:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAtX-0000rt-6p; Mon, 05 Sep 2022 12:08:03 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVAtW-0004GK-VO; Mon, 05 Sep 2022 12:08:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Yr0g0HMMQwKj7yCbNSoqlwrmPqHy7PHwiQ3A349aXFs=; b=YZOrMTyiAWO/rtPB55V4GEPciU 0uKVkdny1H4lrdyfJhQ91MaNeZAXNcfktH78PKfu7oCQaKQfcXPmEbaCJ2rm5ofcVmW+nM6u1NhEG oDFwxy3xB/7VOjHhzppkUEYxnu4zr21UH6qKCCNRrYs1HiE96HH+QgrBTgAfuKDYF6yc=; Message-ID: Date: Mon, 5 Sep 2022 13:08:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Content-Language: en-US To: Bertrand Marquis Cc: Rahul Singh , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> From: Julien Grall In-Reply-To: <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/09/2022 12:54, Bertrand Marquis wrote: > Hi Julien, > >> On 5 Sep 2022, at 12:43, Julien Grall wrote: >> >> >> >> On 05/09/2022 12:12, Rahul Singh wrote: >>> Hi Julien, >> >> Hi Rahul, >> >>>> On 2 Sep 2022, at 5:20 pm, Julien Grall wrote: >>>> >>>> >>>> >>>> On 02/09/2022 16:54, Rahul Singh wrote: >>>>> Hi Julien, >>>> >>>> Hi Rahul, >>>> >>>>>> On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: >>>>>> >>>>>> Hi Bertrand, >>>>>> >>>>>> On 02/09/2022 15:51, Bertrand Marquis wrote: >>>>>>>> On 1 Sep 2022, at 19:15, Julien Grall wrote: >>>>>>>> AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an enum with 3 values: >>>>>>>> - None >>>>>>>> - NOXENSTORE/BASIC >>>>>>>> - FULLY_ENHANCED >>>>>>>> >>>>>>>> If we want to be future proof, I would use a field 'flags' where non-zero means enhanced. Each bit would indicate which features of Xen is exposed. >>>>>>> I think that could be a good solution if we do it this way: >>>>>>> - define a dom0less feature field and have defines like the following: >>>>>>> #define DOM0LESS_GNTTAB >>>>>>> #define DOM0LESS_EVENTCHN >>>>>>> #define DOM0LESS_XENSTORE > >>>>>>> - define dom0less enhanced as the right combination: >>>>>>> #define DOM0LESS_ENHANCED = (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0LESS_XENSTORE) >>>>>> >>>>>> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of defining a bit for gnttab and evtchn. This will avoid the question of why we are introducing bits for both features but not the hypercall... >>>>>> >>>>>> As this is an internal interface, it would be easier to modify afterwards. >>>>> How about this? >>>>> /* >>>>> * List of possible features for dom0less domUs >>>>> * >>>>> * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and >>>>> * evtchn, will be enabled for the VM. >>>> >>>> Technically, the guest can already use the grant-table and evtchn interfaces. This also reads quite odd to me because "including" doesn't tell what's not enabled. So one could assume Xenstored is also enabled. In fact the wording for ``DOM0LESS_ENHANCED`` is what makes it a lot more confusing. >>>> >>>> So I would suggest the following wording: >>>> >>>> "Notify the OS it is running on top of Xen. All the default features but Xenstore will be available. Note that an OS *must* not rely on the availability of Xen features if this is not set. >>>> " >>>> >>>> The wording can be updated once we properly disable event channel/grant table when the flag is not set. >>>> >>>>> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. >>>> >>>> I would make clear this can't be used without the first one. >>>> >>>>> * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-table xenstore > * and >>>> evtchn, will be enabled for the VM. >>>> >>>> See above about "PV interfaces". So I would suggest to reword to: >>>> >>>> "Notify the OS it is running on top of Xen. All the default features (including Xenstore) will be available". >>>> >>>>> */ >>>>> #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) >>>>> #define DOM0LESS_XENSTORE BIT(1, UL) >>>> >>>> Based on the comment above, I would consider to define DOM0LESS_XENSTORE as bit 0 and 1 set. >>>> >>>>> #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE) >>> Bertrand and I discussed this again we came to the conclusion that DOM0LESS_ENHANCED_BASIC is not >>> the suitable name as this makes the code unclear and does not correspond to DT settings. We propose this >>> please let me know your thoughts. >> >> To me the default of "enhanced" should be all Xen features. Anything else should be consider as reduced/basic/minimum. Hence why I still think we need to add it in the name even if this is not what we expose in the DT. In fact... >>> /* >>> * List of possible features for dom0less domUs >>> * >>> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature >>> * can't be enabled without the DOM0LESS_ENHANCED. >>> * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the >>> * default features (including Xenstore) will be >>> * available. Note that an OS *must* not rely on the >>> * availability of Xen features if this is not set. >> >> ... what you wrote here match what I wrote above. So it is not clear to me what's the point of having a flag DOM0LESS_XENSTORE. > > When we looked at the code with the solution using BASIC, it was really not easy to understand. I don't quite understand how this is different from ENHANCED, ENHANCED_FULL. In fact, without looking at the documentation, they mean exactly the same... The difference between "BASIC" and "ENHANCED" is clear. You know that in one case, you would get less than the other. > By the way the comment is wrong and correspond to what should be ENHANCED_FULL here > ENHANCED would be the base without Xenstore. Thanks for the confirmation. I am afraid, I am strongly against the terminology you proposed (see above why). I think BASIC (or similar name) is better. But I am open to suggestion so long it is not "DOM0LESS_ENHANCED" vs "DOM0LESS_ENHANCED_FULL". As an aside, I think it is more logical if you define DOM0LESS_XENSTORE as bit 1. But that's NIT at this point. What matters is the naming. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:10:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398790.639740 (Exim 4.92) (envelope-from ) id 1oVAwC-0005fR-AT; Mon, 05 Sep 2022 12:10:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398790.639740; Mon, 05 Sep 2022 12:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAwC-0005fK-7W; Mon, 05 Sep 2022 12:10:48 +0000 Received: by outflank-mailman (input) for mailman id 398790; Mon, 05 Sep 2022 12:10:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVAwB-0005fE-5a for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:10:47 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c5067bdf-2d13-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 14:10:45 +0200 (CEST) Received: from AS9P250CA0004.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::12) by AS8PR08MB8087.eurprd08.prod.outlook.com (2603:10a6:20b:54c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Mon, 5 Sep 2022 12:10:43 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:532:cafe::33) by AS9P250CA0004.outlook.office365.com (2603:10a6:20b:532::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Mon, 5 Sep 2022 12:10:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 12:10:43 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Mon, 05 Sep 2022 12:10:42 +0000 Received: from 07b090eba8b4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9346E921-36E5-4101-BF24-21292C43DC23.1; Mon, 05 Sep 2022 12:10:32 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07b090eba8b4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 12:10:32 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB8626.eurprd08.prod.outlook.com (2603:10a6:10:3d2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 12:10:30 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Mon, 5 Sep 2022 12:10:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5067bdf-2d13-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ixac/NeVPJw7xpDm82UcpVbBkzK0k4JM8eRMloRPsz1pB0kjHt84r/MrGYPMIpJXQw0aPU5Y6VFzEW79M2SE9sJ/Knr6StpXd8W9rnZDpj/EDQXjeNOTEdD4x/6pdicb2twQ/oHfF1oJbUSzmJCn3SQluQsoYJ7A/7dx2+iTXtH7C/CUXYodiWm84yR0oXTHRoOSeyZ9jmtuMOVq0qgmzPdVqdCdyCiSQa3g2k8KUHWLP23wVZz9/to/7HtDvNRBiE2kX7/8yTXM/n34xVX8r/U8HDgG0tW/j6tYlPQdEI2GyOm9G5n4PL4wGkJA/Zokz/+qHcKENYwJSBmL4Ten9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQNrynW96T7bdfkC1QPh5+rO/TbSBYGFxulXEpZ+MPo=; b=UATG8DC4/DlXMsFyFRMYwBMrn5sHr6RfbqLblgvDnUvzzzi8nYVOh29381Zw7H7tE3pyXRjbAx9jwlvGjLQudbVouZ4NqaEkMOwsJM7c4qmskgOINy6+42IB8893eN3lyI+7wxo0G9OQw5qNR326dXLZ90YeGyA692b0DMFfMYiigURGmmUcWgGY7tDqFJIZAh2l5+W/0/q8WC2wh4nfMzol3zUHZVhhUcdqPcdJvTGtlq9nEyc5PIeGOwoBogS2iunYva9HO+bB+sMaDoU089NtwimK8emuIEyLK0cER4WSxAt4t4cvuIu4pmondRs0BaAAPHjtR4b4DtdcVmctHA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQNrynW96T7bdfkC1QPh5+rO/TbSBYGFxulXEpZ+MPo=; b=DylgcMwd7gUYjL3+lc86TanoK5SbhCss1zCpf0jN77/droZIy9urqEh7ECgY5phVRCpVle8rYoxW9c5R6zjhiiRQ0NZs38om8gpfN5+8TTbnjFiV1/lnpN0LU/KXxZzi/PqV88tHALlx24h7PTglcoF2/BUeQORrxD5Z+XaDYa0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWv2BQXCEnWJMaMNf74xC6FADZByo5R3YnvJ/cSGTujSVkJcEP6SKLNx3InVfQ6i+DS9LpGHlx+oCjpq3g0quaqKoOq3LQKdaeezZIYAgBJ4AnCWlJdWLq6EV0MKap8NzLvAircoAY0SmsarcFkXd0M2xZwa/e4NNVq1IVudd0BKpAwbtSXiogM1RjDXZ/JL+7LHASgCOCYWeFkKeMVYCDQTwwGqSdr4glCMPtZ/+mDZFZRm8ZWjIT+AOCX1aI/8F597IQbF4y5LD9LQtTNshIwCwgq7YnyCXlFAdATuGEAGWrdI/mlLxiwXeTcER1YevZzdmgTXTlqoLLrYa5TDMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQNrynW96T7bdfkC1QPh5+rO/TbSBYGFxulXEpZ+MPo=; b=DddbSiBxsqxtYrvgz0Uz3X2ZJgpu6B03uBQzEKehM58tXHsgi8Jqp0CEgxshsCBppdYiUzJU9h8vNw5LyaLrRs2rTaYDPbqm8/PqR/3NthD89Sz22pApHpQUUbaOkv8iGGO5DBPt5Yj7OvCJk5oFXvOhd7dr6iaFHiFs6hyPpN6JlOsx8Meaqe7jIwE4t/57OUqX6OC8rOw+3nt8LXjxTiUWrkxWrR4tuyyfZK7lJ7jNlRNgwYUPa4icCjKYtZ5fieFZgFlEMgYnCbl9yqNj8uABbqP1eP4A5wZpkFYCaT0WVyqmp/lmxx4+FImDELz2rXiVbf2Ok0aRGIZZTU94pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQNrynW96T7bdfkC1QPh5+rO/TbSBYGFxulXEpZ+MPo=; b=DylgcMwd7gUYjL3+lc86TanoK5SbhCss1zCpf0jN77/droZIy9urqEh7ECgY5phVRCpVle8rYoxW9c5R6zjhiiRQ0NZs38om8gpfN5+8TTbnjFiV1/lnpN0LU/KXxZzi/PqV88tHALlx24h7PTglcoF2/BUeQORrxD5Z+XaDYa0= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Topic: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Index: AQHYwPjzoXW29+zrjEaaAKDaLd6E0a3QvVUAgAAAVfA= Date: Mon, 5 Sep 2022 12:10:28 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F074D8DE7FED064686B8C9809A1DA453.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 39e73607-52b4-4312-a38e-08da8f37a82a x-ms-traffictypediagnostic: DB9PR08MB8626:EE_|VE1EUR03FT024:EE_|AS8PR08MB8087:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cXDy46Mx2avbhHBrzLsOXWCX7UhoHs3/Vx5p7xbVnWZOfJY4VJWuPGcXPJ57YHYGRt4QrpzX3ujy3Tpm85kLCwx0lt2ytKWMjGACNsa6pWy3P5uhczkoI32rTBXJ7JH7kmwIkc+RD8Uo5/KXfmWEIVtk0PpNkKg5W8DKYz/2zcAxz5c0sYsOoNNKGrKEJ641ALMr42vnkCxD3q2IQ1CbcVms9Be76dHthzH9NfsTf9BUQAF3P4P7ayBRv2+YMuqTS5lvA5Xt12y/BL9e/r4/gbg+uiqw1QkB9UI2TofVGNXChzWFfCZ9AvxwFkU2c01vKYB09BOKl/DdfVEQx8WwvcDJfx6aUft1Vl9roPsST6EXfmZBLLdpAl/nVO+HVVXd6YsMmq77GXl43VmtbVDM968OsmbTq2OGIGBjb1IpbR0Z92iuqlgvZVdWvPlCcbmiLbocJ1CulI3S53BD5gLP4FRdSIoMIP9rAhaVe5jdT96v0X2D6DnrPFWSAxHJaQWETGHG7Kz6aHijzZyMCQEdseY2XsA3Ra2uostfhT5Eb6XidIwUnOoD1Ba5fTBHAEX0rznFmVL+8fvZo77Eq16EPGU7iOO67fCj+U5uK1FBkupH/fjsajkDU/VjjKkxFk+5lU5Yj8ps0YD2FbnkJc/+R3WGqEHUqnnMPZ3jTu9abUGApbSvdd964C2UyNwF/Oy2NPg15QCQkNXfdpS6ApD/A9fz4VMTVgVwUt0RDFn+u1eQtDRVgeZ0fjerzauVgik5kQwjWMOAHx/6TIk6KxmCQw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(4326008)(86362001)(7696005)(38070700005)(55016003)(8936002)(76116006)(110136005)(64756008)(71200400001)(54906003)(4744005)(66476007)(66556008)(66446008)(33656002)(66946007)(316002)(8676002)(478600001)(41300700001)(83380400001)(38100700002)(5660300002)(52536014)(2906002)(26005)(6506007)(9686003)(186003)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8626 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7fbba20b-9bcf-495f-50f3-08da8f379f8c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L0sXJ5ACvD+xCTld/W4Y3CgQLlpPxaTT0DLcGT6VUYn3vMBsNKfCkrWgahFXphFH4ETvyC4WWR+pqWJBojd2EBoqL6+OZtP45fpqHEoUGuuzKkQ9mh5HjbhNcisyU616oEXf0WfricvSgMGeN1eIGOD0z6saXsp3jaj5WLd1pIjD0Zg4lA9Fv5BLnTbPqIJh+a0UhzZOXliZmPV47ZDwmIn/amCLRVBmsiKTmNvcO2xSKA70Voviyx3uCGlTk90V5yZIVFbm33p9m7Dw2kjWUY1AuQwhgR0UVPQy51ZFyR/RSD+4Y/ZQVEC1/OxhcyhU/y5cRh52NSBVVxwevkksfEqtCp8Ze4FoKPdc8baUTD3sAG5eTNW0KFFCW1avaLJS2mP+oddvSRUjGmwHvguaJb8MsyVCQkllVf0tk5AQUu7zkXseC1NhuxbTamT4tm/FfBdUt9mfQ38bz05pxufETc4zRFAJKcak2xvcMuWDAro+VcjIZte2rdxm2jaGMiDHM0z+HLeE8wkHaQBF0Y1e8EXr9ozeP7HxIXez6+HRSbb6ZSWXDDUmGF/GBbhiMPGfi/E/I01X+GOGGJIBO9klo2NnU9nR4lR9gAx7uFfmjqNe85XuTwuKGbs+R8sjrtmzs5zGz5zStxFVi8WagmS7v/q3YBcLjFxxW7KIOtnDv+Yemc/7tx68mSoJerQ0dNefCGeBRiJRaW+c3+4EoH0BFU6I5cVMOtVFo8ORM8xEaZSj/9dqlGfJhzlGH0VRbS98Usax7cLkyQF4nDqCA+8REw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39850400004)(346002)(136003)(376002)(36840700001)(46966006)(40470700004)(4326008)(356005)(82740400003)(81166007)(40460700003)(36860700001)(8676002)(83380400001)(54906003)(316002)(82310400005)(70206006)(55016003)(110136005)(70586007)(8936002)(5660300002)(2906002)(9686003)(52536014)(47076005)(4744005)(40480700001)(26005)(336012)(186003)(7696005)(6506007)(478600001)(41300700001)(33656002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 12:10:43.2748 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39e73607-52b4-4312-a38e-08da8f37a82a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8087 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4gK3R5cGVkZWYgZW51bSB7DQo+ID4g KyAgICBNRU1CQU5LX01FTU9SWSwNCj4gPiArICAgIE1FTUJBTktfWEVOX0RPTUFJTiwgLyogd2hl dGhlciB0aGUgbWVtb3J5IGJhbmsgaXMgYm91bmQgdG8gYQ0KPiBYZW4gZG9tYWluLiAqLw0KPiA+ ICsgICAgTUVNQkFOS19SU1ZEX0hFQVAsIC8qIHdoZXRoZXIgdGhlIG1lbW9yeSBiYW5rIGlzIHJl c2VydmVkIGFzDQo+IGhlYXAuICovDQo+ID4gK30gbWVtYmFua190eXBlOw0KPiBXaGVyZWFzIHRo ZSBwYXRjaCBpdHNlbGYgbG9va3Mgb2sgKGl0IG11c3QgYmUgbW9kaWZpZWQgYW55d2F5IGdpdmVu IHRoZQ0KPiBjb21tZW50cyBmb3IgcGF0Y2ggIzIpLA0KPiBNRU1CQU5LX1hFTl9ET01BSU4gbmFt ZSBpcyBxdWl0ZSBhbWJpZ3VvdXMgdG8gbWUsIG5vdyB3aGVuIGl0IGlzDQo+IHBhcnQgb2YgbWVt YmFua190eXBlIGVudW0uDQo+IFNvbWV0aGluZyBsaWtlIE1FTUJBTktfU1RBVElDIG9yIE1FTUJB TktfU1RBVElDTUVNIHdvdWxkIGJlDQo+IG11Y2ggY2xlYW5lciBpbiBteSBvcGluaW9uDQo+IGFz IGl0IHdvdWxkIGRpcmVjdGx5IGluZGljYXRlIHdoYXQgdHlwZSBvZiBtZW1vcnkgd2UgYXJlIHRh bGtpbmcgYWJvdXQuDQoNClRoYW5rcyBmb3IgdGhlIHN1Z2dlc3Rpb24uIEkgYW0gcHJldHR5IGJh ZCBpbiBuYW1pbmcgdGhpbmdzIHNvIGluIHRoaXMgcGF0Y2gNCkkgc2ltcGx5IHJldXNlZCB0aGUg b3JpZ2luYWwgbmFtZSBmb3Igc3RhdGljIG1lbW9yeSBiYW5rcy4NCg0KSSBwcmVmZXIgTUVNQkFO S19TVEFUSUNNRU0gYW5kIHdpbGwgY2hhbmdlIGluIHYzLiBJIHdpbGwgY2hlY2sgdGhlDQo4MCBj aGFyIGxpbWl0IGluIGN1cnJlbnQgY29kZSwgaWYgU1RBVElDTUVNIGRvZXMgbm90IGZpdCwgSSB3 aWxsIGdvIFNUQVRJQy4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gfk1pY2hhbA0K From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:48:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398803.639778 (Exim 4.92) (envelope-from ) id 1oVBW6-0001BQ-Fa; Mon, 05 Sep 2022 12:47:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398803.639778; Mon, 05 Sep 2022 12:47:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW6-00018e-81; Mon, 05 Sep 2022 12:47:54 +0000 Received: by outflank-mailman (input) for mailman id 398803; Mon, 05 Sep 2022 12:47:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW4-0000jq-Uc for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:47:53 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3785bfc-2d18-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 14:47:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 76AE8388A4; Mon, 5 Sep 2022 12:47:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C18513A66; Mon, 5 Sep 2022 12:47:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4DyADfbvFWO1DAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 12:47:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3785bfc-2d18-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662382070; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VlJ/HKfnDfMr+Qyu9LFLpf4AfrG79Ga4xwdEyjPTosw=; b=j7Ae712dtB3caWIdV+8Zumb/9QfV01+4kmqe968UZlkyj4mD5k3mOyZyNbouu0PldNByAe HVmJ411vtQlzmvAwV6XXPTZG9zD2QisJ2IXoPCx90NFGHzS8wyu/a+bOW735PcndUcUaCf zbxJB/LdYI0E0y9QTZ4F/jpLhQt/W9k= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features Date: Mon, 5 Sep 2022 14:47:46 +0200 Message-Id: <20220905124746.1975-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905124746.1975-1-jgross@suse.com> References: <20220905124746.1975-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain quota Signed-off-by: Juergen Gross --- V3: - new patch V4: - add new record types instead of modifying the existing ones (Julien Grall) --- docs/designs/xenstore-migration.md | 160 ++++++++++++++++++++++++++++- 1 file changed, 155 insertions(+), 5 deletions(-) diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md index efa526f420..c70505c43a 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@ -43,7 +43,14 @@ the setting of the endianness bit. |-----------|---------------------------------------------------| | `ident` | 0x78656e73746f7265 ('xenstore' in ASCII) | | | | -| `version` | 0x00000001 (the version of the specification) | +| `version` | The version of the specification, defined values: | +| | 0x00000001: all fields and records without any | +| | explicitly mentioned version | +| | dependency are valid. | +| | 0x00000002: all fields and records valid for | +| | version 1 plus fields and records | +| | explicitly stated to be supported in | +| | version 2 are valid. | | | | | `flags` | 0 (LSB): Endianness: 0 = little, 1 = big | | | | @@ -77,7 +84,10 @@ NOTE: padding octets here and in all subsequent format specifications must be | | 0x00000003: WATCH_DATA | | | 0x00000004: TRANSACTION_DATA | | | 0x00000005: NODE_DATA | -| | 0x00000006 - 0xFFFFFFFF: reserved for future use | +| | 0x00000006: GLOBAL_QUOTA_DATA | +| | 0x00000007: DOMAIN_DATA | +| | 0x00000008: WATCH_DATA_EXTENDED (version 2 and up) | +| | 0x00000009 - 0xFFFFFFFF: reserved for future use | | | | | `len` | The length (in octets) of `body` | | | | @@ -129,6 +139,7 @@ xenstored state that needs to be restored. | `evtchn-fd` | The file descriptor used to communicate with | | | the event channel driver | + xenstored will resume in the original process context. Hence `rw-socket-fd` simply specifies the file descriptor of the socket. Sockets are not always used, however, and so -1 will be used to denote an unused socket. @@ -241,9 +252,9 @@ the file descriptor of the socket connection. ### WATCH_DATA -The image format will contain a `WATCH_DATA` record for each watch registered -by a connection for which there is `CONNECTION_DATA` record previously present. - +The image format will contain either a `WATCH_DATA` or a `WATCH_DATA_EXTENDED` +record for each watch registered by a connection for which there is +`CONNECTION_DATA` record previously present. ``` 0 1 2 3 octet @@ -406,6 +417,145 @@ A node permission specifier has the following format: Note that perm1 defines the domain owning the node. See [4] for more explanation of node permissions. +\pagebreak + +### GLOBAL_QUOTA_DATA + +This record is only relevant for live update. It contains the global settings +of xenstored quota. + +``` + 0 1 2 3 octet ++-------+-------+-------+-------+ +| n-dom-quota | n-glob-quota | ++---------------+---------------+ +| quota-val 1 | ++-------------------------------+ +... ++-------------------------------+ +| quota-val N | ++-------------------------------+ +| quota-names +... +``` + + +| Field | Description | +|----------------|----------------------------------------------| +| `n-dom-quota` | Number of quota values which apply per | +| | domain. | +| | | +| `n-glob-quota` | Number of quota values which apply globally | +| | only. | +| | | +| `quota-val` | Quota values, first the ones applying per | +| | domain, then the ones applying globally. A | +| | value of 0 has the semantics of "unlimited". | +| | | +| `quota-names` | 0 delimited strings of the quota names in | +| | the same sequence as the `quota-val` values. | + + +Allowed quota names are those explicitly named in [2] for the `GET_QUOTA` +and `SET_QUOTA` commands, plus implementation specific ones. Quota names not +recognized by the receiving side must be ignored. + +\pagebreak + +### DOMAIN_DATA + +This record is optional and can be present once for each domain. + + +``` + 0 1 2 3 octet ++-------+-------+-------+-------+ +| domain-id | n-quota | ++---------------+---------------+ +| features | ++-------------------------------+ +| quota-val 1 | ++-------------------------------+ +... ++-------------------------------+ +| quota-val N | ++-------------------------------+ +| quota-names +... +``` + + +| Field | Description | +|----------------|----------------------------------------------| +| `domain-id` | The domain-id of the domain this record | +| | belongs to. | +| | | +| `n-quota` | Number of quota values. | +| | | +| `features` | Value of the feature field visible by the | +| | guest at offset 2064 of the ring page. | +| | Aligned to the next 4 octet boundary. | +| | Only valid for version 2 and later. | +| | | +| `quota-val` | Quota values, a value of 0 has the semantics | +| | "unlimited". | +| | | +| `quota-names` | 0 delimited strings of the quota names in | +| | the same sequence as the `quota-val` values. | + +Allowed quota names are those explicitly named in [2] for the `GET_QUOTA` +and `SET_QUOTA` commands, plus implementation specific ones. Quota names not +recognized by the receiving side must be ignored. + +\pagebreak + +### WATCH_DATA_EXTENDED + +The image format will contain either a `WATCH_DATA` or a `WATCH_DATA_EXTENDED` +record for each watch registered by a connection for which there is +`CONNECTION_DATA` record previously present. The `WATCH_DATA_EXTENDED` record +type is valid only in version 2 and later. + +``` + 0 1 2 3 octet ++-------+-------+-------+-------+ +| conn-id | ++---------------+---------------+ +| wpath-len | token-len | ++---------------+---------------+ +| depth | | ++---------------+---------------+ +| wpath +... +| token +... +``` + + +| Field | Description | +|-------------|-------------------------------------------------| +| `conn-id` | The connection that issued the `WATCH` | +| | operation [2] | +| | | +| `wpath-len` | The length (in octets) of `wpath` including the | +| | NUL terminator | +| | | +| `token-len` | The length (in octets) of `token` including the | +| | NUL terminator | +| | | +| `depth` | The number of directory levels below the | +| | watched path to consider for a match. | +| | A value of 0xffff is used for unlimited depth. | +| | | +| `wpath` | The watch path, as specified in the `WATCH` | +| | operation | +| | | +| `token` | The watch identifier token, as specified in the | +| | `WATCH` operation | + +\pagebreak + + * * * [1] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/designs/non-cooperative-migration.md -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:48:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398799.639751 (Exim 4.92) (envelope-from ) id 1oVBW5-0000kN-7W; Mon, 05 Sep 2022 12:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398799.639751; Mon, 05 Sep 2022 12:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW5-0000kD-39; Mon, 05 Sep 2022 12:47:53 +0000 Received: by outflank-mailman (input) for mailman id 398799; Mon, 05 Sep 2022 12:47:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW3-0000jr-TR for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:47:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3303210-2d18-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 14:47:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 34494388A3; Mon, 5 Sep 2022 12:47:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E6C6613A66; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AN4IN/XvFWO1DAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 12:47:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3303210-2d18-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662382070; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rGlCKEwcU/SZ0y9iAyqoydp7gF1Ss4+EyFvuwscMXI8=; b=D+XbUfY5DqhzDLv3fkIGTYgyJfygElHDI+FpD++HdkoM9dZxckoFGEPSLgkmnyt/imRwHn sj7Lkv74+vdmwoNnbEa71JHpO6xBmt8iTRlzY7Jtxgq/NjynElc0oPzZjhbagbIbqxpLii UaYwhim36MYw5I0k0D/QfcaSbbPale8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v4 3/4] tools/xenstore: add documentation for extended watch command Date: Mon, 5 Sep 2022 14:47:45 +0200 Message-Id: <20220905124746.1975-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905124746.1975-1-jgross@suse.com> References: <20220905124746.1975-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add documentation for an extension of the WATCH command used to limit the scope of watched paths. Additionally it enables to receive more information in the events related to special watches (@introduceDomain or @releaseDomain). Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- docs/misc/xenstore-ring.txt | 1 + docs/misc/xenstore.txt | 16 +++++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt index 2792d13530..dbc7335e24 100644 --- a/docs/misc/xenstore-ring.txt +++ b/docs/misc/xenstore-ring.txt @@ -69,6 +69,7 @@ Bit Description ----------------------------------------------------------------- 0 Ring reconnection (see the ring reconnection feature below) 1 Connection error indicator (see connection error feature below) +2 WATCH can take a third parameter limiting its scope The "Connection state" field is used to request a ring close and reconnect. The "Connection state" field only contains valid data if the server has diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 73670d7907..da47d7bb16 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -187,7 +187,7 @@ SET_PERMS ||+? ---------- Watches ---------- -WATCH ||? +WATCH ||[|]? Adds a watch. When a is modified (including path creation, removal, @@ -198,7 +198,11 @@ WATCH ||? matching watch results in a WATCH_EVENT message (see below). The event's path matches the watch's if it is an child - of . + of . This match can be limited by specifying (a + decimal value of 0 or larger): it denotes the directory levels + below to consider for a match ("0" would not match for + a child of , "1" would match only for a direct child, + etc.). can be a to watch or @. In the latter case may have any syntax but it matches @@ -209,7 +213,13 @@ WATCH ||? shutdown, and also on RELEASE and domain destruction events are sent to privileged callers or explicitly - via SET_PERMS enabled domains only. + via SET_PERMS enabled domains only. The semantics for a + specification of differ for generating + events: specifying "1" will report the related domid by using + @/ for the reported path. Other + values are not supported. + For @releaseDomain it is possible to watch only for a specific + domain by specifying @releaseDomain/ for the path. When a watch is first set up it is triggered once straight away, with equal to . Watches may be triggered -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:48:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398801.639761 (Exim 4.92) (envelope-from ) id 1oVBW5-0000rw-N7; Mon, 05 Sep 2022 12:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398801.639761; Mon, 05 Sep 2022 12:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW5-0000qR-IW; Mon, 05 Sep 2022 12:47:53 +0000 Received: by outflank-mailman (input) for mailman id 398801; Mon, 05 Sep 2022 12:47:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW4-0000jr-G4 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:47:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2ca3ad0-2d18-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 14:47:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 492633889F; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A09113A66; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yoOOAPXvFWO1DAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 12:47:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2ca3ad0-2d18-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662382069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DxA2WpFHQvjVo1ZU09I5qKpdf/5ONEa27/jr6GvF1iM=; b=a/NA0MpDxNwn8+q9vE1P+8jmWVat3MrAPhMTbJavdKPMTHJHp4DA6mDB4oznlvNtXTwQDL /WIZ3kKeREmA9UJzX95Vl2c4NqL1d8OZJewQpvuP9wiugPTpfvgmlVZVXK/xLGgLkED6hX cBd6fzF5VUuUXV02YUwVx1sM3RxGGOs= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 0/4] tools/xenstore: add some new features to the documentation Date: Mon, 5 Sep 2022 14:47:42 +0200 Message-Id: <20220905124746.1975-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the past there have been spotted some shortcomings in the Xenstore interface, which should be repaired. Those are in detail: - Using driver domains for large number of domains needs per domain Xenstore quota [1]. The feedback sent was rather slim (one reply), but it was preferring a new set of wire commands. - XSA-349 [2] has shown that the current definition of watches is not optimal, as it will trigger lots of events when a single one would suffice: for detecting new backend devices the backends in the Linux kernel are registering a watch for e.g. "/local/domain/0/backend" which will fire for ANY sub-node written below this node (on a test machine this added up to 91 watch events for only 3 devices). This can be limited dramatically by extending the XS_WATCH command to take another optional parameter specifying the depth of subdirectories to be considered for sending watch events ("0" would trigger a watch event only if the watched node itself being written). - New features like above being added might make migration of guests between hosts with different Xenstore variants harder, so it should be possible to set the available feature set per domain. For socket connections it should be possible to read the available features. - The special watches @introduceDomain and @releaseDomain are rather cumbersome to use, as they only tell you that SOME domain has been introduced/released. Any consumer of those watches needs to scan all domains on the host in order to find out the domid, causing significant pressure on the dominfo hypercall (imagine a system with 1000 domains running and one domain dying - there will be more than 1000 watch events triggered and 1000 xl daemons will try to find out whether "their" domain has died). Those watches should be enhanced to optionally be specific to a single domain and to let the event carry the related domid. As some of those extensions will need to be considered in the Xenstore migration stream, they should be defined in one go (in fact the 4th one wouldn't need that, but it can easily be connected to the 2nd one). As such extensions need to be flagged in the "features" in the ring page anyway, it is fine to implement them independently. Add the documentation of the new commands/features. [1]: https://lists.xen.org/archives/html/xen-devel/2020-06/msg00291.html [2]: http://xenbits.xen.org/xsa/advisory-349.html Changes in V4: - patch 2 removed, as already committed - major rework of last patch Changes in V3: - patch 1 removed, as already committed - new patch 1 - minor clarifications in patch 2 - new patch 5 Changes in V2: - added new patch 1 - remove feature bits for dom0-only features - get-features without domid returns Xenstore supported features - get/set-quota without domid for global quota access Juergen Gross (4): tools/xenstore: minor fix of the migration stream doc tools/xenstore: add documentation for new set/get-quota commands tools/xenstore: add documentation for extended watch command tools/xenstore: add migration stream extensions for new features docs/designs/xenstore-migration.md | 166 +++++++++++++++++++++++++++-- docs/misc/xenstore-ring.txt | 1 + docs/misc/xenstore.txt | 33 +++++- 3 files changed, 188 insertions(+), 12 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:48:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398800.639756 (Exim 4.92) (envelope-from ) id 1oVBW5-0000no-Ex; Mon, 05 Sep 2022 12:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398800.639756; Mon, 05 Sep 2022 12:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW5-0000nK-B0; Mon, 05 Sep 2022 12:47:53 +0000 Received: by outflank-mailman (input) for mailman id 398800; Mon, 05 Sep 2022 12:47:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW4-0000jq-1Y for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:47:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2f9e200-2d18-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 14:47:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8FD86388A0; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 506FB13A66; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4K1kEvXvFWO1DAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 12:47:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2f9e200-2d18-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662382069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GSBCJ5cXL+X0Jz3TL0Sa1Pme0dCpqP3btKnhVhmZDqU=; b=madmR9X2HnvDzzLMcsPf8usDofgrWHz4CA0yOvMIVF+BL+1ZptCB2QD0XHzC5fyvI2k2WZ FAgoFBBK3xjKvoBwTctzNw06fcQk2twT56PIPf38SD/pdyoMTa5YAiPe48rlxg3P9Dd9qY +D7AAYSkYy5TAiMRO+wvupSWkz8w13Y= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 1/4] tools/xenstore: minor fix of the migration stream doc Date: Mon, 5 Sep 2022 14:47:43 +0200 Message-Id: <20220905124746.1975-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905124746.1975-1-jgross@suse.com> References: <20220905124746.1975-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop mentioning the non-existent read-only socket in the migration stream description document. The related record field was removed in commit 8868a0e3f674 ("docs: update the xenstore migration stream documentation). Signed-off-by: Juergen Gross --- V3: - new patch --- docs/designs/xenstore-migration.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md index b94af7fd7c..efa526f420 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@ -129,11 +129,9 @@ xenstored state that needs to be restored. | `evtchn-fd` | The file descriptor used to communicate with | | | the event channel driver | -xenstored will resume in the original process context. Hence `rw-socket-fd` and -`ro-socket-fd` simply specify the file descriptors of the sockets. Sockets -are not always used, however, and so -1 will be used to denote an unused -socket. - +xenstored will resume in the original process context. Hence `rw-socket-fd` +simply specifies the file descriptor of the socket. Sockets are not always +used, however, and so -1 will be used to denote an unused socket. \pagebreak -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 12:48:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 12:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398802.639768 (Exim 4.92) (envelope-from ) id 1oVBW6-00011I-1u; Mon, 05 Sep 2022 12:47:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398802.639768; Mon, 05 Sep 2022 12:47:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW5-0000zz-S3; Mon, 05 Sep 2022 12:47:53 +0000 Received: by outflank-mailman (input) for mailman id 398802; Mon, 05 Sep 2022 12:47:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBW4-0000jq-G3 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 12:47:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f321b54b-2d18-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 14:47:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DEDC61FFD9; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 98C2413A66; Mon, 5 Sep 2022 12:47:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QAn8I/XvFWO1DAAAMHmgww (envelope-from ); Mon, 05 Sep 2022 12:47:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f321b54b-2d18-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662382069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NpHiptJcwGoAMGrSBmcUyjE7qCo40p2IN4dYlppaCrM=; b=KcMQH7MMzfweSsHBfbp36uANpyg5uB6Wd0mtHzPylQMnAhey4flWR/yTY+1dpQEnVu/cCc RwpwevS06zGfKz7JBu9nEWNT4BpcxH8K9XJUfPZ4fSl8Qe6wJPf6pO1eMYJeKW17RlAX+M fFfsrBg525Pe3cqHcw2O/9mjUWX/pH0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v4 2/4] tools/xenstore: add documentation for new set/get-quota commands Date: Mon, 5 Sep 2022 14:47:44 +0200 Message-Id: <20220905124746.1975-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905124746.1975-1-jgross@suse.com> References: <20220905124746.1975-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add documentation for two new Xenstore wire commands SET_QUOTA and GET_QUOTA used to set or query the global Xenstore quota or those of a given domain. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - remove feature bit (Julien Grall) - add possibility to access global quota and to query supported quotas --- docs/misc/xenstore.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 33d8fc87f7..73670d7907 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -348,6 +348,23 @@ SET_FEATURE || xenstored prevents the use of GET_FEATURE and SET_FEATURE other than by dom0. +GET_QUOTA [[|]|] | +SET_QUOTA [|]|| + Returns or sets a quota value for the domain being specified by + . Omitting will return or set the global quota + values, which are the default values for new domains. is + one of "nodes", "watches", "transactions", "node-size", + "permissions", or any other implementation defined value. For + GET_QUOTA it is possible to omit the parameter together + with the parameter, which will return a single string of + all supported values separated by blanks. is a + decimal number specifying the quota value, with "0" having the + special meaning of quota checks being disabled. The initial quota + settings for a domain are the global ones of Xenstore. + + xenstored prevents the use of GET_QUOTA and SET_QUOTA other + than by dom0. + ---------- Miscellaneous ---------- CONTROL |[|] -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 13:00:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 13:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398836.639806 (Exim 4.92) (envelope-from ) id 1oVBhz-0005Sq-R5; Mon, 05 Sep 2022 13:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398836.639806; Mon, 05 Sep 2022 13:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBhz-0005Sj-Nx; Mon, 05 Sep 2022 13:00:11 +0000 Received: by outflank-mailman (input) for mailman id 398836; Mon, 05 Sep 2022 13:00:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBhy-0005Sd-8Y for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 13:00:10 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20082.outbound.protection.outlook.com [40.107.2.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab4a3b16-2d1a-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 15:00:08 +0200 (CEST) Received: from AM5PR0602CA0020.eurprd06.prod.outlook.com (2603:10a6:203:a3::30) by PA4PR08MB7458.eurprd08.prod.outlook.com (2603:10a6:102:2a5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 13:00:06 +0000 Received: from AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::4b) by AM5PR0602CA0020.outlook.office365.com (2603:10a6:203:a3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 13:00:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT049.mail.protection.outlook.com (100.127.140.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 13:00:06 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 05 Sep 2022 13:00:05 +0000 Received: from 553bdbf2f81b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7FEB29B6-329A-4E06-991F-45B03727AD9B.1; Mon, 05 Sep 2022 12:59:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 553bdbf2f81b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 12:59:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS4PR08MB7904.eurprd08.prod.outlook.com (2603:10a6:20b:51f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 12:59:45 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 12:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab4a3b16-2d1a-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OhS6LGv/2fLVgLuZs32bslVJrD7JL5j1yVEIB2LQL4qxQRPWQDlftSj+yGDkoXUpnwRYqi11wDiVWeKfvEMC5NWBTayyBRn1c55X7D9Ncg5HpgG8Sjl7ib8Kjt+JnZjZ2XLihaqUBTPn/ROtRB/JAOzpTIvfvVzQ/D9UjGPHtpg5/nBX2kJq6fm+VGQIHzJC4M++hu7Bak3cTarkIBuO297lRH/BNuNekLzVYLxJXiEAWkmAy6pgdiEk+c/IjfnucsS1DTs+g6JDR4rLk4HnODr6bEgWwrSvYL/8f8GN2MOtEIJUtssZSdCFeBJiSIDgm3cBupsusBC7wGiZxgT+Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vm1dtfNoyw0A4MV7brOwwM2q9yROOYu2odnhkmnnMt4=; b=dhi6gIWRcsv15/rB+nFN+MkTh/AEwzRLGUtvZrIX0A5AYOhI8D4fItmJFCJ9Tq5qFiZTpof5l8f+uy015o+EVZoH58+o2QmPfRJBmQnfv+hhnLJkzRtbkYYJNXR9j3hnD+5AmZgrKMucZ/8oddOsebjo2foep5H3ihwcvrp50KzO2FI3b7eP9FbDokzrJjgno2geaMBi74EYkTD+fBXuRvbaYk9lKTokzztd9T3+/o089idV0Vimr1vml91hWYzwFFmGEZ8bhHKk9kAHEy7f85g4WdAtIR7BXm9ELtmNtZPTmMvoIL9ndX2PjSiJ1v7M9K5ReQkh9ht/u+MKepk3YA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vm1dtfNoyw0A4MV7brOwwM2q9yROOYu2odnhkmnnMt4=; b=5M8Dxz0PdlIgiglL5jV/8M0AD/ypLNIxeGdFQRijjTjVgfXoyyat/uNjF8FEPR51LnHTLF2dSo+mD80+subDXkIxF80PJpMy3hQZfrZnz0/Wj+WergPf4vc9SVlSy9K4pYryR3Vt7r14TJeQSkVd9QaL7NWkJExoswrNzQ0XmQQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 04e362773495884d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odeT/iEhoCECm++HuOUbITO0TNfR+MFMcFshb7sbbiMuYLk6lAbaCayn0dVyBHuqWLwk1QnziIxoQaNtcAk9/zoCMI2NHW3/Fp0KYUHkNxKHJmxsiEVD1ZU3scRYPQ1ZsHL2eKxeke9FYI96e9Bf85o7hlBOTaXC9iPd5xHajhBfHzLyaoODV2BuptzzxSx9eT69H2EJb8yCILNbRqXSWN9m8KTVOXrqD6C6RlUsFVSh3okvb2agRh1UZUO3ex0ADx7J8/ia8OxY1xgC8FTt/euHOZuL/V22rrLZhTZOOWvBMo4rPVphEd7vh9pV3KDFQVs4IEbOV/kCVLOBOj0A4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vm1dtfNoyw0A4MV7brOwwM2q9yROOYu2odnhkmnnMt4=; b=Xjxjvf94x7hlSTRoraLYYZ66kMtGXvbysCRIHiTrFmrwM8ZpHUBe1yiunDTL3mf4RxEgax8k4VS53WiCG78IufuoRV11/QW8dwLmZLjR5XDiLgFbALWZFtvhLhYOGDRtJd372i/nVdLyBl3R3x4aFQPMpVBL4pku0+QguFfEqMKO2HJxREbmQtU9QO9kH9sNZRxmloXgtgrWLpebTXjkHSmwlTJ327T0TE7Lj/hA53hhvi8aIPBjymdjnwbw9BprTiDQGxZGT84z5koi+205hV1JgfEPpTctpCrHYjD8ET5bJ8Hv9yo5a3zzXo0ikZTMvX9JEbwXgH4rnsXt5aONBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vm1dtfNoyw0A4MV7brOwwM2q9yROOYu2odnhkmnnMt4=; b=5M8Dxz0PdlIgiglL5jV/8M0AD/ypLNIxeGdFQRijjTjVgfXoyyat/uNjF8FEPR51LnHTLF2dSo+mD80+subDXkIxF80PJpMy3hQZfrZnz0/Wj+WergPf4vc9SVlSy9K4pYryR3Vt7r14TJeQSkVd9QaL7NWkJExoswrNzQ0XmQQ= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOAeMLlOwX5Mka7ZrpAabJW7K3K4ewAgAFZKACAAAQoAIAADY8AgAAHN4CABGESgIAACJcAgAADEoCAAAPFgIAADnWA Date: Mon, 5 Sep 2022 12:59:45 +0000 Message-ID: <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b481b1d3-c9bd-4d09-97fc-08da8f3e8e18 x-ms-traffictypediagnostic: AS4PR08MB7904:EE_|AM7EUR03FT049:EE_|PA4PR08MB7458:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pij07dsmFSPJvJgE2lOe0ZCKFrXuSfmANvZaZaq2aEPNMufoa2q5EYbE2FzLv+HdQl5uoYzzz1N/6QGeEAcOTrIOid51oYW1xZJGjTq2ntP2eF2uStfFN7Cjg6rT9O21DnLzytBwFtKvvRXnaCP00Y71t1RulfzZpg+bJimdCLPCNhGYsL9wyDsjZfM7skZdhyulehCEY02iyonvuMjoCDoPOI44EVJcpXFuHPkgg3TmG2J0XEI8NrpJB4jLk2k1vXUIz3OmZhdNlHCAUUymc4BXk4LnF823Zp5udIthFhYdiCeRXaKRargW1nUx08Ndn2UUV/zmZuD6sFv7kLS7KsCy+PAha2IcqUDp8XLVPJAIXttBNOJ1IaEVunXWAZVNKn/B3AZrO6L725PD6PiF52nKENiiGmbc6JEeAn6uDaE/k70RVxODCQqp6beYI3W9r55p0JI9njDLcMriZJgCO3dOkozJLhD81CNap/aPSAAb46Km1tGcG/OroVuIHcju/B1xS3mpTwMoxrEGchmpDcxksEJl84EbYwG54TcwqUf+9Ko/mxX5QdNkMxDSQ5CYgtIYOkzWiX59edVs8Jm4BY12DgDog5X8jo4yvOHAabpymSX/pUE7XrQX0hJJ3Cu5z2ZVmxedRkApam6tAEUMT/nvSkgUzEbJhFXGIz3kpMJMgmZPk9cILshV+M/LI4HL1fRoj6p01DBm5deuDOBzKfVLvUkJPMwmABaF33pkYH/v5mYKPTc4G3PLAQab7ZtJ2QiqE77P9BVDfwnPL7/NLI4MVDcEf/SBg80LR3VNf7E= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(8676002)(66556008)(186003)(5660300002)(4326008)(2616005)(83380400001)(8936002)(122000001)(66946007)(38100700002)(91956017)(76116006)(2906002)(64756008)(6486002)(6512007)(316002)(71200400001)(26005)(6506007)(53546011)(41300700001)(478600001)(6916009)(54906003)(36756003)(66446008)(38070700005)(86362001)(66476007)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7904 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 159c8db4-bbf2-4a18-318d-08da8f3e8200 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kA8X/6FyJzd75WdU9mDQ/yeIwJWratEdf0Fw4QMOFRPxeUBq8RWsjrWgWwXB3ruBcgz7/IbS4Akm9zS+T9JcWhZYAeaij4celzzDKjsfCQ5eOorTne9MjjDNJxAjcq6Dys3HpRIIDIHBPeVIffMUsB2mVyLzwSKXLyYSPnVcQBHXbiSgeEFdgeaku9n3T8NfeWZfHdKq/YqZTE22MM/vIBBThn+AD0obUgs/pL1Azfksj/3tzpHHhSid8P2rpaDflAAD2tJKL70KuvHhgf+a7bDjzL+bTc4jrT/nHjNMZJGnNnK/9x0A7K5KuaOQrqyNL9PCmz6floUY3U+oO2e7vzbKSu+VkYTWm+XbmGKpfgVzhpSKCVHekvpsQbGT5Y1UNWSMMhUmRn1PV/vLrQed4EYInsx9TLw4DCA2jK+9VnPl+3lbrvvU8B4k1OS2Aan07A9L6Z+IYRI8jsydMw2DH+2Xt5zmFUPeVA3ZdN3jyK5dfG0bvAgDnD36E3WJOhxxKN0FaTxHaj+ndI9D2I4WRxs7Egpe9hup7SjrBP+xVEFYGhnoWXrNxmDB5/ERRI66H//NhDzOOEHT475WPlI5tUFNyE+xDSJ0D2Xuxo2qKC9BAHCucCKNPsdoIv9G5WpxTWkq2sVOGZBtVVaHaMfP4sul5G1YtEn8yzgd7HXKgL9hqY8K/BUK++23eTyBlyl4sFn6NYUE1sXL1fLTNMU8/KBS6UjiKrdJ8S/HmIefpMtq8F9iOXk7vnqKT+om0F/zVOwJ6yu2quJZo6+Uk9asSA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(46966006)(40470700004)(36840700001)(8936002)(107886003)(2616005)(186003)(6512007)(336012)(53546011)(36756003)(6486002)(5660300002)(6506007)(47076005)(6862004)(26005)(33656002)(86362001)(478600001)(40480700001)(70206006)(40460700003)(2906002)(356005)(36860700001)(41300700001)(82740400003)(81166007)(83380400001)(316002)(54906003)(82310400005)(70586007)(4326008)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 13:00:06.0442 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b481b1d3-c9bd-4d09-97fc-08da8f3e8e18 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7458 SGkgSnVsaWVuLA0KDQo+IE9uIDUgU2VwIDIwMjIsIGF0IDEzOjA4LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMDUvMDkvMjAyMiAxMjo1NCwg QmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4+PiBPbiA1IFNlcCAyMDIy LCBhdCAxMjo0MywgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+ Pj4gDQo+Pj4gDQo+Pj4gT24gMDUvMDkvMjAyMiAxMjoxMiwgUmFodWwgU2luZ2ggd3JvdGU6DQo+ Pj4+IEhpIEp1bGllbiwNCj4+PiANCj4+PiBIaSBSYWh1bCwNCj4+PiANCj4+Pj4+IE9uIDIgU2Vw IDIwMjIsIGF0IDU6MjAgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0K Pj4+Pj4gDQo+Pj4+PiANCj4+Pj4+IA0KPj4+Pj4gT24gMDIvMDkvMjAyMiAxNjo1NCwgUmFodWwg U2luZ2ggd3JvdGU6DQo+Pj4+Pj4gSGkgSnVsaWVuLA0KPj4+Pj4gDQo+Pj4+PiBIaSBSYWh1bCwN Cj4+Pj4+IA0KPj4+Pj4+PiBPbiAyIFNlcCAyMDIyLCBhdCA0OjA1IHBtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+Pj4gDQo+Pj4+Pj4+IEhpIEJlcnRyYW5kLA0K Pj4+Pj4+PiANCj4+Pj4+Pj4gT24gMDIvMDkvMjAyMiAxNTo1MSwgQmVydHJhbmQgTWFycXVpcyB3 cm90ZToNCj4+Pj4+Pj4+PiBPbiAxIFNlcCAyMDIyLCBhdCAxOToxNSwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+Pj4+Pj4gQUZBSVUsIGl0IGlzIG5vdCBwb3NzaWJs ZSB0byBoYXZlICpfeGVuc3RvcmUgPSB0cnVlIGFuZCAqX2VuaGFuY2VkID0gZmFsc2UuIEkgdGhp bmsgaXQgd291bGQgYmUgY2xlYXJlciBpZiBgYGRvbTBsZXNzX2VuaGFuY2VkYGAgaXMgdHVybmVk IHRvIGFuIGVudW0gd2l0aCAzIHZhbHVlczoNCj4+Pj4+Pj4+PiAtIE5vbmUNCj4+Pj4+Pj4+PiAt IE5PWEVOU1RPUkUvQkFTSUMNCj4+Pj4+Pj4+PiAtIEZVTExZX0VOSEFOQ0VEDQo+Pj4+Pj4+Pj4g DQo+Pj4+Pj4+Pj4gSWYgd2Ugd2FudCB0byBiZSBmdXR1cmUgcHJvb2YsIEkgd291bGQgdXNlIGEg ZmllbGQgJ2ZsYWdzJyB3aGVyZSBub24temVybyBtZWFucyBlbmhhbmNlZC4gRWFjaCBiaXQgd291 bGQgaW5kaWNhdGUgd2hpY2ggZmVhdHVyZXMgb2YgWGVuIGlzIGV4cG9zZWQuDQo+Pj4+Pj4+PiBJ IHRoaW5rIHRoYXQgY291bGQgYmUgYSBnb29kIHNvbHV0aW9uIGlmIHdlIGRvIGl0IHRoaXMgd2F5 Og0KPj4+Pj4+Pj4gLSBkZWZpbmUgYSBkb20wbGVzcyBmZWF0dXJlIGZpZWxkIGFuZCBoYXZlIGRl ZmluZXMgbGlrZSB0aGUgZm9sbG93aW5nOg0KPj4+Pj4+Pj4gI2RlZmluZSBET00wTEVTU19HTlRU QUINCj4+Pj4+Pj4+ICNkZWZpbmUgRE9NMExFU1NfRVZFTlRDSE4NCj4+Pj4+Pj4+ICNkZWZpbmUg RE9NMExFU1NfWEVOU1RPUkUgPg0KPj4+Pj4+Pj4gLSBkZWZpbmUgZG9tMGxlc3MgZW5oYW5jZWQg YXMgdGhlIHJpZ2h0IGNvbWJpbmF0aW9uOg0KPj4+Pj4+Pj4gI2RlZmluZSBET00wTEVTU19FTkhB TkNFRCA9IChET00wTEVTU19HTlRUQUJ8IERPTTBMRVNTX0VWRU5UQ0hOfCBET00wTEVTU19YRU5T VE9SRSkNCj4+Pj4+Pj4gDQo+Pj4+Pj4+IEkgd291bGQgcmF0aGVyIGludHJvZHVjZSBET00wTEVT U19FTkhBTkNFRF9CQVNJQyAob3Igc2ltaWxhcikgaW5zdGVhZCBvZiBkZWZpbmluZyBhIGJpdCBm b3IgZ250dGFiIGFuZCBldnRjaG4uIFRoaXMgd2lsbCBhdm9pZCB0aGUgcXVlc3Rpb24gb2Ygd2h5 IHdlIGFyZSBpbnRyb2R1Y2luZyBiaXRzIGZvciBib3RoIGZlYXR1cmVzIGJ1dCBub3QgdGhlIGh5 cGVyY2FsbC4uLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gQXMgdGhpcyBpcyBhbiBpbnRlcm5hbCBpbnRl cmZhY2UsIGl0IHdvdWxkIGJlIGVhc2llciB0byBtb2RpZnkgYWZ0ZXJ3YXJkcy4NCj4+Pj4+PiBI b3cgYWJvdXQgdGhpcz8NCj4+Pj4+PiAvKg0KPj4+Pj4+ICAqIExpc3Qgb2YgcG9zc2libGUgZmVh dHVyZXMgZm9yIGRvbTBsZXNzIGRvbVVzDQo+Pj4+Pj4gICoNCj4+Pj4+PiAgKiBET00wTEVTU19F TkhBTkNFRF9CQVNJQzogWGVuIFBWIGludGVyZmFjZXMsIGluY2x1ZGluZyBncmFudC10YWJsZSBh bmQNCj4+Pj4+PiAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBldnRjaG4sIHdpbGwgYmUgZW5hYmxlZCBmb3IgdGhlIFZNLg0KPj4+Pj4g DQo+Pj4+PiBUZWNobmljYWxseSwgdGhlIGd1ZXN0IGNhbiBhbHJlYWR5IHVzZSB0aGUgZ3JhbnQt dGFibGUgYW5kIGV2dGNobiBpbnRlcmZhY2VzLiBUaGlzIGFsc28gcmVhZHMgcXVpdGUgb2RkIHRv IG1lIGJlY2F1c2UgImluY2x1ZGluZyIgZG9lc24ndCB0ZWxsIHdoYXQncyBub3QgZW5hYmxlZC4g U28gb25lIGNvdWxkIGFzc3VtZSBYZW5zdG9yZWQgaXMgYWxzbyBlbmFibGVkLiBJbiBmYWN0IHRo ZSB3b3JkaW5nIGZvciBgYERPTTBMRVNTX0VOSEFOQ0VEYGAgaXMgd2hhdCBtYWtlcyBpdCBhIGxv dCBtb3JlIGNvbmZ1c2luZy4NCj4+Pj4+IA0KPj4+Pj4gU28gSSB3b3VsZCBzdWdnZXN0IHRoZSBm b2xsb3dpbmcgd29yZGluZzoNCj4+Pj4+IA0KPj4+Pj4gIk5vdGlmeSB0aGUgT1MgaXQgaXMgcnVu bmluZyBvbiB0b3Agb2YgWGVuLiBBbGwgdGhlIGRlZmF1bHQgZmVhdHVyZXMgYnV0IFhlbnN0b3Jl IHdpbGwgYmUgYXZhaWxhYmxlLiBOb3RlIHRoYXQgYW4gT1MgKm11c3QqIG5vdCByZWx5IG9uIHRo ZSBhdmFpbGFiaWxpdHkgb2YgWGVuIGZlYXR1cmVzIGlmIHRoaXMgaXMgbm90IHNldC4NCj4+Pj4+ ICINCj4+Pj4+IA0KPj4+Pj4gVGhlIHdvcmRpbmcgY2FuIGJlIHVwZGF0ZWQgb25jZSB3ZSBwcm9w ZXJseSBkaXNhYmxlIGV2ZW50IGNoYW5uZWwvZ3JhbnQgdGFibGUgd2hlbiB0aGUgZmxhZyBpcyBu b3Qgc2V0Lg0KPj4+Pj4gDQo+Pj4+Pj4gICogRE9NMExFU1NfWEVOU1RPUkU6ICAgICAgICAgICAg ICBYZW5zdG9yZSB3aWxsIGJlIGVuYWJsZWQgZm9yIHRoZSBWTS4NCj4+Pj4+IA0KPj4+Pj4gSSB3 b3VsZCBtYWtlIGNsZWFyIHRoaXMgY2FuJ3QgYmUgdXNlZCB3aXRob3V0IHRoZSBmaXJzdCBvbmUu DQo+Pj4+PiANCj4+Pj4+PiAgKiBET00wTEVTU19FTkhBTkNFRDogICAgICAgICAgICAgIFhlbiBQ ViBpbnRlcmZhY2VzLCBpbmNsdWRpbmcgZ3JhbnQtdGFibGUgeGVuc3RvcmUgPiAgICogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5kDQo+ Pj4+PiBldnRjaG4sIHdpbGwgYmUgZW5hYmxlZCBmb3IgdGhlIFZNLg0KPj4+Pj4gDQo+Pj4+PiBT ZWUgYWJvdmUgYWJvdXQgIlBWIGludGVyZmFjZXMiLiBTbyBJIHdvdWxkIHN1Z2dlc3QgdG8gcmV3 b3JkIHRvOg0KPj4+Pj4gDQo+Pj4+PiAiTm90aWZ5IHRoZSBPUyBpdCBpcyBydW5uaW5nIG9uIHRv cCBvZiBYZW4uIEFsbCB0aGUgZGVmYXVsdCBmZWF0dXJlcyAoaW5jbHVkaW5nIFhlbnN0b3JlKSB3 aWxsIGJlIGF2YWlsYWJsZSIuDQo+Pj4+PiANCj4+Pj4+PiAgKi8NCj4+Pj4+PiAjZGVmaW5lIERP TTBMRVNTX0VOSEFOQ0VEX0JBU0lDIEJJVCgwLCBVTCkNCj4+Pj4+PiAjZGVmaW5lIERPTTBMRVNT X1hFTlNUT1JFICAgICAgIEJJVCgxLCBVTCkNCj4+Pj4+IA0KPj4+Pj4gQmFzZWQgb24gdGhlIGNv bW1lbnQgYWJvdmUsIEkgd291bGQgY29uc2lkZXIgdG8gZGVmaW5lIERPTTBMRVNTX1hFTlNUT1JF IGFzIGJpdCAwIGFuZCAxIHNldC4NCj4+Pj4+IA0KPj4+Pj4+ICNkZWZpbmUgRE9NMExFU1NfRU5I QU5DRUQgICAgICAgKERPTTBMRVNTX0VOSEFOQ0VEX0JBU0lDIHwgRE9NMExFU1NfWEVOU1RPUkUp DQo+Pj4+ICBCZXJ0cmFuZCBhbmQgSSBkaXNjdXNzZWQgdGhpcyBhZ2FpbiB3ZSBjYW1lIHRvIHRo ZSBjb25jbHVzaW9uIHRoYXQgRE9NMExFU1NfRU5IQU5DRURfQkFTSUMgaXMgbm90DQo+Pj4+IHRo ZSBzdWl0YWJsZSBuYW1lIGFzIHRoaXMgbWFrZXMgdGhlIGNvZGUgdW5jbGVhciBhbmQgZG9lcyBu b3QgY29ycmVzcG9uZCB0byBEVCBzZXR0aW5ncy4gV2UgcHJvcG9zZSB0aGlzDQo+Pj4+IHBsZWFz ZSBsZXQgbWUga25vdyB5b3VyIHRob3VnaHRzLg0KPj4+IA0KPj4+IFRvIG1lIHRoZSBkZWZhdWx0 IG9mICJlbmhhbmNlZCIgc2hvdWxkIGJlIGFsbCBYZW4gZmVhdHVyZXMuIEFueXRoaW5nIGVsc2Ug c2hvdWxkIGJlIGNvbnNpZGVyIGFzIHJlZHVjZWQvYmFzaWMvbWluaW11bS4gSGVuY2Ugd2h5IEkg c3RpbGwgdGhpbmsgd2UgbmVlZCB0byBhZGQgaXQgaW4gdGhlIG5hbWUgZXZlbiBpZiB0aGlzIGlz IG5vdCB3aGF0IHdlIGV4cG9zZSBpbiB0aGUgRFQuIEluIGZhY3QuLi4NCj4+Pj4gIC8qDQo+Pj4+ ICAqIExpc3Qgb2YgcG9zc2libGUgZmVhdHVyZXMgZm9yIGRvbTBsZXNzIGRvbVVzDQo+Pj4+ICAq DQo+Pj4+ICAqIERPTTBMRVNTX1hFTlNUT1JFOgkJWGVuc3RvcmUgd2lsbCBiZSBlbmFibGVkIGZv ciB0aGUgVk0uIFRoaXMgZmVhdHVyZQ0KPj4+PiAgKiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAJY2FuJ3QgYmUgZW5hYmxlZCB3aXRob3V0IHRoZSBET00wTEVT U19FTkhBTkNFRC4NCj4+Pj4gICogRE9NMExFU1NfRU5IQU5DRUQ6ICAgICAgIAlOb3RpZnkgdGhl IE9TIGl0IGlzIHJ1bm5pbmcgb24gdG9wIG9mIFhlbi4gQWxsIHRoZQ0KPj4+PiAgKiAgICAgICAg ICAgICAgICAgICAgICAgICAgCQkJCWRlZmF1bHQgZmVhdHVyZXMgKGluY2x1ZGluZyBYZW5zdG9y ZSkgd2lsbCBiZQ0KPj4+PiAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgCQkJCWF2YWlsYWJs ZS4gTm90ZSB0aGF0IGFuIE9TICptdXN0KiBub3QgcmVseSBvbiB0aGUNCj4+Pj4gICogICAgICAg ICAgICAgICAgICAgICAgICAgIAkJCQlhdmFpbGFiaWxpdHkgb2YgWGVuIGZlYXR1cmVzIGlmIHRo aXMgaXMgbm90IHNldC4NCj4+PiANCj4+PiAuLi4gd2hhdCB5b3Ugd3JvdGUgaGVyZSBtYXRjaCB3 aGF0IEkgd3JvdGUgYWJvdmUuIFNvIGl0IGlzIG5vdCBjbGVhciB0byBtZSB3aGF0J3MgdGhlIHBv aW50IG9mIGhhdmluZyBhIGZsYWcgRE9NMExFU1NfWEVOU1RPUkUuDQo+PiBXaGVuIHdlIGxvb2tl ZCBhdCB0aGUgY29kZSB3aXRoIHRoZSBzb2x1dGlvbiB1c2luZyBCQVNJQywgaXQgd2FzIHJlYWxs eSBub3QgZWFzeSB0byB1bmRlcnN0YW5kLg0KPiANCj4gSSBkb24ndCBxdWl0ZSB1bmRlcnN0YW5k IGhvdyB0aGlzIGlzIGRpZmZlcmVudCBmcm9tIEVOSEFOQ0VELCBFTkhBTkNFRF9GVUxMLiBJbiBm YWN0LCB3aXRob3V0IGxvb2tpbmcgYXQgdGhlIGRvY3VtZW50YXRpb24sIHRoZXkgbWVhbiBleGFj dGx5IHRoZSBzYW1lLi4uDQo+IA0KPiBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVuICJCQVNJQyIgYW5k ICJFTkhBTkNFRCIgaXMgY2xlYXIuIFlvdSBrbm93IHRoYXQgaW4gb25lIGNhc2UsIHlvdSB3b3Vs ZCBnZXQgbGVzcyB0aGFuIHRoZSBvdGhlci4NCj4gDQo+PiBCeSB0aGUgd2F5IHRoZSBjb21tZW50 IGlzIHdyb25nIGFuZCBjb3JyZXNwb25kIHRvIHdoYXQgc2hvdWxkIGJlIEVOSEFOQ0VEX0ZVTEwg aGVyZQ0KPj4gRU5IQU5DRUQgd291bGQgYmUgdGhlIGJhc2Ugd2l0aG91dCBYZW5zdG9yZS4NCj4g DQo+IFRoYW5rcyBmb3IgdGhlIGNvbmZpcm1hdGlvbi4gSSBhbSBhZnJhaWQsIEkgYW0gc3Ryb25n bHkgYWdhaW5zdCB0aGUgdGVybWlub2xvZ3kgeW91IHByb3Bvc2VkIChzZWUgYWJvdmUgd2h5KS4N Cj4gDQo+IEkgdGhpbmsgQkFTSUMgKG9yIHNpbWlsYXIgbmFtZSkgaXMgYmV0dGVyLiBCdXQgSSBh bSBvcGVuIHRvIHN1Z2dlc3Rpb24gc28gbG9uZyBpdCBpcyBub3QgIkRPTTBMRVNTX0VOSEFOQ0VE IiB2cyAiRE9NMExFU1NfRU5IQU5DRURfRlVMTCIuDQoNCkkgZG8gbm90IGFncmVlIGJ1dCBJIHRo aW5rIHRoaXMgaXMgb25seSBpbnRlcm5hbCBhbmQgY291bGQgZWFzaWx5IGJlIG1vZGlmaWVkIG9u ZSBkYXkgaWYgd2UgaGF2ZSBtb3JlIHVzZS1jYXNlcy4NClNvIGxldOKAmXMgZ28gZm9yIEJBU0lD IGFuZCB1bmJsb2NrIHRoaXMgYmVmb3JlIHRoZSBmZWF0dXJlIGZyZWV6ZS4NCg0KQmVydHJhbmQN Cg0KPiANCj4gQXMgYW4gYXNpZGUsIEkgdGhpbmsgaXQgaXMgbW9yZSBsb2dpY2FsIGlmIHlvdSBk ZWZpbmUgRE9NMExFU1NfWEVOU1RPUkUgYXMgYml0IDEuIEJ1dCB0aGF0J3MgTklUIGF0IHRoaXMg cG9pbnQuIFdoYXQgbWF0dGVycyBpcyB0aGUgbmFtaW5nLg0KPiANCj4gQ2hlZXJzLA0KPiANCj4g LS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 05 13:08:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 13:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398853.639822 (Exim 4.92) (envelope-from ) id 1oVBqD-0006M1-Ny; Mon, 05 Sep 2022 13:08:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398853.639822; Mon, 05 Sep 2022 13:08:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBqD-0006Lu-LG; Mon, 05 Sep 2022 13:08:41 +0000 Received: by outflank-mailman (input) for mailman id 398853; Mon, 05 Sep 2022 13:08:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBqD-0006Lk-1p; Mon, 05 Sep 2022 13:08:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBqC-0001xo-Vc; Mon, 05 Sep 2022 13:08:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBqC-0007uk-Ck; Mon, 05 Sep 2022 13:08:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVBqC-0001em-CN; Mon, 05 Sep 2022 13:08:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JuPydSuBMMJ2DP78Cq30s4SUJh/UETpMMPQmO7wGUDQ=; b=Jiu+QwNHaLqZ7Jl1FDA4xOvruk lUH5s1V+qC+jTq1qg1b1Tl6EzytxHIJKd2r3bTP5B4pJs8tjgKcuXAC5G5D8O6qnuGa0BAPTr4Bos PF+ViXNrdpfTMaWAgmd2ykpUKwAwWec+sL2HLTQUT7O6qg2ss9e3/CzsbUYnt+44UNsc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173001: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=08522341c4935f27cd7d3dbfd38ffa8329cdc2cb X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 05 Sep 2022 13:08:40 +0000 flight 173001 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173001/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 08522341c4935f27cd7d3dbfd38ffa8329cdc2cb baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 32 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 247 attempts Testing same since 172995 2022-09-05 03:33:08 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1474 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 13:11:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 13:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398862.639833 (Exim 4.92) (envelope-from ) id 1oVBtA-0007kE-7t; Mon, 05 Sep 2022 13:11:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398862.639833; Mon, 05 Sep 2022 13:11:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBtA-0007k7-4f; Mon, 05 Sep 2022 13:11:44 +0000 Received: by outflank-mailman (input) for mailman id 398862; Mon, 05 Sep 2022 13:11:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVBt8-0007k1-R6 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 13:11:42 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4860c0e0-2d1c-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 15:11:41 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id d5so5229061wms.5 for ; Mon, 05 Sep 2022 06:11:41 -0700 (PDT) Received: from horizon ([2a01:e0a:19f:35f0:dde5:d55a:20f5:7ef5]) by smtp.gmail.com with ESMTPSA id y22-20020a7bcd96000000b003a54f1d007csm10514094wmj.10.2022.09.05.06.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 06:11:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4860c0e0-2d1c-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=9wIR0YoTNedOMl2ijqWHncarAIsVvB/0F5GTrmKNCmg=; b=efMSKwjHaMW293Xz8oK8ILEWfIx/Bd9uOMVmu0pxXAE2yxHFYCxuZw30FVkBl4pBvD yPYDXFmB85JSp6yWeZ511rtxWeDscaKkIT1Wmq1k2LPlr1HBfUQuinMK7ybfHDr6keye Mhye+skdlmPJ5Red9ZO4f7R0O8XT65wRIFmimHeZidvoDX3Ib/LKvQ4l4t/tEbEHl2fx 7NYmTqxE2T39TVx1kGi0H3QnEWQEBP+JiXFDzODydKa52yN004yrUZOSSrmpYhQKSnL8 gsEouLIZFUTpiXdpX04mln/4n7RLBbc1BiWWU1PKWtEScoyl2k2EqWa+5qaw4r/IN96J mEAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=9wIR0YoTNedOMl2ijqWHncarAIsVvB/0F5GTrmKNCmg=; b=Bkbd/u/fHT4shmmN1MUtUo4oREGNhJ775ZR0a/0zsjNu/E1L4Znf932luz9LyeFip+ DQoBFxPxK6GAE+zDvRGLniPqk3eU1wKfJE2ZRL4gqmcKKQOuKFFuG6ihhxJEsfgxMBAY z3CiqMayXAI2t02GEozxb+rA+/Re2VBWW3MjoHu96fG1UgVDX6yOwtWYg22xO5yTaUZI hhkIfB0UlWBwiXsdNEBdH/c+f5Zbt028XRKai5UtZ4cCQ0ifHihgcUiYy5t8wUi2rh81 XRt++WAwNj42/goo6B39x9wpIzdp+3FHVvVfcQLBOpikt25AN3fhyENLnTKhB4JNzGwE cZww== X-Gm-Message-State: ACgBeo1RlQkemjJZrc7oxF08jEicITdiFUIJgDPiZ88rSzsTg/dnOg9f f6TloOGK5AwKt6H4A/gAeZ18+lAvfPQ= X-Google-Smtp-Source: AA6agR4NRI201GxBKAPm2w9HkK3lkGfpNHncVBPr1MD+D4nGXC4SIuv2+HeHZ7oHf2vFUhEjtmjTVw== X-Received: by 2002:a05:600c:19d1:b0:3a6:14e5:4725 with SMTP id u17-20020a05600c19d100b003a614e54725mr10370937wmq.141.1662383500886; Mon, 05 Sep 2022 06:11:40 -0700 (PDT) Date: Mon, 5 Sep 2022 15:11:38 +0200 From: Matias Vara To: Paul Durrant Cc: xen-devel Subject: Re: [RFC PATCH v1] xen/docs: Document acquire resource interface Message-ID: References: <89a56dfe-7bc7-472c-3c0c-644ed36a0c44@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <89a56dfe-7bc7-472c-3c0c-644ed36a0c44@xen.org> On Tue, Aug 30, 2022 at 01:06:11PM +0100, Paul Durrant wrote: > On 29/08/2022 10:03, Matias Ezequiel Vara Larsen wrote: > > This commit creates a new doc to document the acquire resource interface. This > > is a reference document. > > > > Signed-off-by: Matias Ezequiel Vara Larsen > > --- > > Changes in v1: > > - correct documentation about how mfns are allocated > > - correct documentation about how mfns are released > > - use the wording tool instead of pv tool > > - fix typos > > --- > > .../acquire_resource_reference.rst | 338 ++++++++++++++++++ > > docs/hypervisor-guide/index.rst | 2 + > > 2 files changed, 340 insertions(+) > > create mode 100644 docs/hypervisor-guide/acquire_resource_reference.rst > > > > diff --git a/docs/hypervisor-guide/acquire_resource_reference.rst b/docs/hypervisor-guide/acquire_resource_reference.rst > > new file mode 100644 > > index 0000000000..d1989d2fd4 > > --- /dev/null > > +++ b/docs/hypervisor-guide/acquire_resource_reference.rst > > @@ -0,0 +1,338 @@ > > +.. SPDX-License-Identifier: CC-BY-4.0 > > + > > +Acquire resource reference > > +========================== > > + > > +Acquire resource allows you to share a resource between Xen and dom0. > > That doesn't sound right. The resources 'belong' to Xen, and are specific to > a particular domain (A). Another domain (B) with enough privilege over > domain A can then map and hence access those resources. > > Paul Thanks Paul, It would sound better something like: "The acquire resource interface enables sharing resources that are specific to a particular domain and belongs to Xen with a domain with enough privileges, e.g., dom0. This domain can map and hence access those resources.” Matias > > From xen-devel-bounces@lists.xenproject.org Mon Sep 05 13:37:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 13:37:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398871.639844 (Exim 4.92) (envelope-from ) id 1oVCHY-0001sA-9x; Mon, 05 Sep 2022 13:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398871.639844; Mon, 05 Sep 2022 13:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVCHY-0001s3-7C; Mon, 05 Sep 2022 13:36:56 +0000 Received: by outflank-mailman (input) for mailman id 398871; Mon, 05 Sep 2022 13:36:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVCHW-0001rx-Nu for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 13:36:54 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccf470c8-2d1f-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 15:36:52 +0200 (CEST) Received: from AM6P192CA0037.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::14) by DB9PR08MB7626.eurprd08.prod.outlook.com (2603:10a6:10:30a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 13:36:50 +0000 Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::f9) by AM6P192CA0037.outlook.office365.com (2603:10a6:209:82::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 13:36:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 13:36:49 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Mon, 05 Sep 2022 13:36:49 +0000 Received: from 42073404c82c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9B3454FE-DBE1-46C6-BA62-DE890218C334.1; Mon, 05 Sep 2022 13:36:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 42073404c82c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 13:36:42 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB7663.eurprd08.prod.outlook.com (2603:10a6:10:319::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Mon, 5 Sep 2022 13:36:40 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 13:36:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccf470c8-2d1f-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=g8wfSqbmh8db5TRsEZ5zEyhSrA+zE4tB0mKDOHDkglpajmplNVqC4it3MIMyw2aigQGK/BfB6M40u8AQL0ttddLr6ZTO8ZDn/xhfAsCDXuzZbV/Dw/VilkX+QKxjp3sc4km2H35d0bIJEzMo6mKFKCb1t8VSB/kk+zE5HjCA6W5j4PPM1bvRLgQ7fUQiIHE0GW2npr6SRe3wCUXL08K0kcfU9doEV93nT37DFdIQhAvc40UrxvAPp0Bf9zb8j9/geCjWQK3HCD3ZIgzgaH/jPojQhhr+kEUuJ1Y0WwgqjZFH4STIQZXs9MPDljfCSDSIi+tPi1Vy2v4xl8soo9VaAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7opXkaEtIDMzH+1cK3aghCv2BYe5N81Hh6jyHO7ehw=; b=V33Ia7RxYD7oTrYjH1rF0ckoqZOvKHe1TqGVN5zgj8dZQmgFPzpvnBmYdM/I0CKdpL8ZljoS1OFGOFb/JGI+TyqUgGFtvFCYgSLZbtoSEbIZOXueqZssxoFBrs/u1gDbyYpudqb2Oqk7gXCeBra7FJW/v8O3HdghOp8pqkUEGpieYy/E1LClRYHLibYNSToF7V4Bmi42Rj1VagZvqQdg1bu2UGua5J+nRIs4rr+Qw6EztdgKSlpr5cXSt4dyTUyZa9DISqxzxf/jT31grFiqVbr+KMi0OrUeaHdJ9FncofP1g15hgCqYbuzqasUtDZ9GC8cp1/KebNb2hw6OMVaQFQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7opXkaEtIDMzH+1cK3aghCv2BYe5N81Hh6jyHO7ehw=; b=Kc4MCs9yDTLxZ/LSGouUpqvWerRIqIV3ju7rzq4Hse90nB4NIwdwFHUqsA6DzAZVNM46XAEvoTTRN/dfa+u9deMOTnG9dAZCvqPpJ2Y49QZlolp2cc/C0e4XpJG0nuBajW+vYJlSNK/qZK3dJklG/1ZK9I6iQiU7w/1VXd1hSrM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a8c10f67b7f7ad4c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUtibyPfDLAoDLi2TTsyy76OTtGkvxsEaJCHh7x6WvsIFnMLTA5m0pGwvNo5eVawxqDG6erGQ009m8fD35VdvxqSW0+ak5oN3XvTdqLf8SH13wKuEqD+isPUBMg962tQGerRFaSlzAQ+b8DB0bNl9ZMzIzl2MArYNh3uI2QQbqvebKAOXrSKA6/au+mf9hY5dZilSyHM8a4gip38jWLQEhssZouMy/F2KU9+llPF8USNftdfjE8LFbag7nwKQtsSN2Mndp6tlMNYVD+a7UOIwS1vEd9B48icTuPqBVHKMF0JDr/WuSq+tevu3jsNWkyv1ozw9AfuD2X8/9lLJ+R/MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7opXkaEtIDMzH+1cK3aghCv2BYe5N81Hh6jyHO7ehw=; b=SZKZbMhmakmd/DnCZH7ihnsR+UgMVOgZWh5H7hZTpbwYfePe1/Ee/6r+N7Rb3EaE6eIUc82a2V+zUXnnp8V9uCGtPkSd7K4WjhIlq2q8hhq519UxY6HUPQdda/nUyyc+/CzS5ZTlR+FZzgXNnlMOCBUHz0KXXhPhieQLAVrOAJ0zxSZSDk6SeOlJT+VubtEDgLmcK3718nFS00eS+L7cDELKZeXVQLMqNbWl51b+IB4HWciJr0moVsgSRFnfX+rkmDMfGAKS67xgeIPRph5xHjSoBbUVJW1DHytYXr0ldCZcSQCheqoRGANay9qofsNjTp4ieQtdjGKiPGvLMleGZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7opXkaEtIDMzH+1cK3aghCv2BYe5N81Hh6jyHO7ehw=; b=Kc4MCs9yDTLxZ/LSGouUpqvWerRIqIV3ju7rzq4Hse90nB4NIwdwFHUqsA6DzAZVNM46XAEvoTTRN/dfa+u9deMOTnG9dAZCvqPpJ2Y49QZlolp2cc/C0e4XpJG0nuBajW+vYJlSNK/qZK3dJklG/1ZK9I6iQiU7w/1VXd1hSrM= From: Rahul Singh To: Bertrand Marquis CC: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFZKoCAAAQmAIAADY6AgAAHOICABGESgIAACJcAgAADEwCAAAPEgIAADnWAgAAKUAA= Date: Mon, 5 Sep 2022 13:36:40 +0000 Message-ID: References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> In-Reply-To: <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f7800f39-3748-47c7-667a-08da8f43afaa x-ms-traffictypediagnostic: DU0PR08MB7663:EE_|VE1EUR03FT057:EE_|DB9PR08MB7626:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YZ+AF2QwqR0Q9YrLXiOjcLpB61l1np3zItb2hlVyQG8DmO7GdWSrNJe9h9on+hF8BELJQ0qdZmwjd/fo5zbgdXHA11yJudrJlMMFfhiZJKnWV2vZ3Q/fnXQlAaU7egFyfZ1cb46+VbsJnh9zSrVRc5T7IQqCMRdQKFHzL2TcNn5SeR6CfB0Q8O/y9b1Fu6yO9NlXuFo5TL+J1lKx0IDQvVzvhOtiSpo0gLnl+uG3XAD8KyMmRhhG6PELRD2DX1l6Wqt6wZJdBH7koMo+tNFx6WH0v6MWbOYVCy0jWBMgVm7GCHsTpc2WrW0zOYR1zl4UeDxpWJK5bdBFHmMmjWAPTv5ZdAZLDE9xDmE3J0R62xLVPz8BxpQtXkVjd7yaBOL27DQBL4F500hpmicJuWB6+uAFLROGTd/XEgdnYWsc8ZCydohXHzqiB4vKUstYQy/+GZ8j+4AsUGRSSA4H9MujwCfzD2dspt1FFJJfXUPxyEnlpjbiA5+LRpAC3iY00QhV1MMlKOA5m1EiGdXe9Yld8e8vhDsJXgu/1Kt6G/qwKFT3C9AnuUq2tkmLIHhmRj+rqVrQOhYErl3ypJi+MbtX2/f+30pyc5nH3yN7wNhqqiWK/9xXC7jVI+c3wqg0JvYvXclv+FLD+TEbzVTLiaegKBblVSAMgygUQBdvWYxdWPK4mfNENbd3gUq9hm93DokLqeckcR486GR3FaAzJhMjbqXuDMXdCo1hYUtSG1oeru41bZ1br/JekXzYnYS77Nc58kxojY+btCk1Uymhcbf4brMT5OYQaTM2eSMFRgn7XAc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(83380400001)(38070700005)(6636002)(38100700002)(122000001)(66946007)(66476007)(76116006)(64756008)(54906003)(4326008)(2906002)(316002)(66446008)(8676002)(37006003)(66556008)(91956017)(71200400001)(5660300002)(6862004)(186003)(53546011)(6512007)(26005)(6506007)(2616005)(8936002)(6486002)(478600001)(33656002)(41300700001)(36756003)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7663 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 96fc6951-920e-42ef-c10e-08da8f43aa3b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GZ3qRf4q5ORloepO0wKULicCUbBVO8fn6sGd5SxdEER6x/JZ1ndySd7omZJiLayHJKgkJQGHyDkK1/9N51GVSQeCUDBDQJ9zoa2QJ93k6ey/lSmzCCcLxtU0bJzwK4w9gHjedMC5Rj5SQk8BPmbdyYmPS40f/BGCeBskoxfA9eh8+K1CjEKH69gJSTog0cqqNavNznWzQ/W9ZpVaQBaNQOkl24JBf3On+D9xkknQOoH8Zs0Scshp9scHeYBBTRi6QBUehv0GpHkL4pBhVjNx9fTW/1K73H5g6ubv8UN5HINK2pVfISI1pNkckclbTqDHnQcsvPgW0hfoftxGvbxWF9HOnX6gePIVpBBi9dWtEpp2weeCPeP71pxzIsxPsdOrYQJ/rszcoo/ppH5WwIpW9Ahf+WNFmAqf1OE5rCDs2Y24f8n9FYtOHpaLYcCMnmlE5o3ed8Y0bm4BnmRmQipULuNOPxvsayaQJYXfPuhWjPPth9TkYLPFg9eqNoWiZ0vx0F4WJ1/RNsItHXeS8z5KovzRu4k9K7fEhKxBZ1sBOQHodumj54IHPnBOZF41s9nzYrzIp2kvOpVqZ+0ieJvpyYvzWj0mca7RnjKURNY7h9DMZHSL8+u6ZFWeTbbxI2Uk+12BfW2UKlD3+SzEZ467hncEdnrNGJJN+fnJwl4zeEx77nJylLM9BWGDxswz5Ek9YeHGkFtT+18VdKvz7jxg9gu9LKxgmSTVFcP98QUkrzfTqh/R9cfJVAa3dKyulKdPL3BI2umLEpbmCyXa1BeOVQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(46966006)(40470700004)(36840700001)(47076005)(40460700003)(2616005)(86362001)(81166007)(356005)(6512007)(6506007)(41300700001)(107886003)(83380400001)(26005)(336012)(82740400003)(36860700001)(53546011)(186003)(54906003)(37006003)(40480700001)(33656002)(316002)(6862004)(70586007)(8676002)(4326008)(8936002)(6636002)(5660300002)(2906002)(36756003)(478600001)(6486002)(70206006)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 13:36:49.7545 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7800f39-3748-47c7-667a-08da8f43afaa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7626 SGkgSnVsaWVuLA0KDQo+IE9uIDUgU2VwIDIwMjIsIGF0IDE6NTkgcG0sIEJlcnRyYW5kIE1hcnF1 aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBKdWxpZW4sDQo+ IA0KPj4gT24gNSBTZXAgMjAyMiwgYXQgMTM6MDgsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPj4gDQo+PiANCj4+IA0KPj4gT24gMDUvMDkvMjAyMiAxMjo1NCwgQmVydHJh bmQgTWFycXVpcyB3cm90ZToNCj4+PiBIaSBKdWxpZW4sDQo+Pj4+IE9uIDUgU2VwIDIwMjIsIGF0 IDEyOjQzLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4gDQo+Pj4+ IA0KPj4+PiANCj4+Pj4gT24gMDUvMDkvMjAyMiAxMjoxMiwgUmFodWwgU2luZ2ggd3JvdGU6DQo+ Pj4+PiBIaSBKdWxpZW4sDQo+Pj4+IA0KPj4+PiBIaSBSYWh1bCwNCj4+Pj4gDQo+Pj4+Pj4gT24g MiBTZXAgMjAyMiwgYXQgNToyMCBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3Jv dGU6DQo+Pj4+Pj4gDQo+Pj4+Pj4gDQo+Pj4+Pj4gDQo+Pj4+Pj4gT24gMDIvMDkvMjAyMiAxNjo1 NCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+Pj4+IEhpIEp1bGllbiwNCj4+Pj4+PiANCj4+Pj4+ PiBIaSBSYWh1bCwNCj4+Pj4+PiANCj4+Pj4+Pj4+IE9uIDIgU2VwIDIwMjIsIGF0IDQ6MDUgcG0s IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+ PiBIaSBCZXJ0cmFuZCwNCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gT24gMDIvMDkvMjAyMiAxNTo1MSwg QmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+Pj4+Pj4gT24gMSBTZXAgMjAyMiwgYXQgMTk6 MTUsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4+Pj4+PiBBRkFJ VSwgaXQgaXMgbm90IHBvc3NpYmxlIHRvIGhhdmUgKl94ZW5zdG9yZSA9IHRydWUgYW5kICpfZW5o YW5jZWQgPSBmYWxzZS4gSSB0aGluayBpdCB3b3VsZCBiZSBjbGVhcmVyIGlmIGBgZG9tMGxlc3Nf ZW5oYW5jZWRgYCBpcyB0dXJuZWQgdG8gYW4gZW51bSB3aXRoIDMgdmFsdWVzOg0KPj4+Pj4+Pj4+ PiAtIE5vbmUNCj4+Pj4+Pj4+Pj4gLSBOT1hFTlNUT1JFL0JBU0lDDQo+Pj4+Pj4+Pj4+IC0gRlVM TFlfRU5IQU5DRUQNCj4+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4+IElmIHdlIHdhbnQgdG8gYmUgZnV0 dXJlIHByb29mLCBJIHdvdWxkIHVzZSBhIGZpZWxkICdmbGFncycgd2hlcmUgbm9uLXplcm8gbWVh bnMgZW5oYW5jZWQuIEVhY2ggYml0IHdvdWxkIGluZGljYXRlIHdoaWNoIGZlYXR1cmVzIG9mIFhl biBpcyBleHBvc2VkLg0KPj4+Pj4+Pj4+IEkgdGhpbmsgdGhhdCBjb3VsZCBiZSBhIGdvb2Qgc29s dXRpb24gaWYgd2UgZG8gaXQgdGhpcyB3YXk6DQo+Pj4+Pj4+Pj4gLSBkZWZpbmUgYSBkb20wbGVz cyBmZWF0dXJlIGZpZWxkIGFuZCBoYXZlIGRlZmluZXMgbGlrZSB0aGUgZm9sbG93aW5nOg0KPj4+ Pj4+Pj4+ICNkZWZpbmUgRE9NMExFU1NfR05UVEFCDQo+Pj4+Pj4+Pj4gI2RlZmluZSBET00wTEVT U19FVkVOVENITg0KPj4+Pj4+Pj4+ICNkZWZpbmUgRE9NMExFU1NfWEVOU1RPUkUgPg0KPj4+Pj4+ Pj4+IC0gZGVmaW5lIGRvbTBsZXNzIGVuaGFuY2VkIGFzIHRoZSByaWdodCBjb21iaW5hdGlvbjoN Cj4+Pj4+Pj4+PiAjZGVmaW5lIERPTTBMRVNTX0VOSEFOQ0VEID0gKERPTTBMRVNTX0dOVFRBQnwg RE9NMExFU1NfRVZFTlRDSE58IERPTTBMRVNTX1hFTlNUT1JFKQ0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+ PiBJIHdvdWxkIHJhdGhlciBpbnRyb2R1Y2UgRE9NMExFU1NfRU5IQU5DRURfQkFTSUMgKG9yIHNp bWlsYXIpIGluc3RlYWQgb2YgZGVmaW5pbmcgYSBiaXQgZm9yIGdudHRhYiBhbmQgZXZ0Y2huLiBU aGlzIHdpbGwgYXZvaWQgdGhlIHF1ZXN0aW9uIG9mIHdoeSB3ZSBhcmUgaW50cm9kdWNpbmcgYml0 cyBmb3IgYm90aCBmZWF0dXJlcyBidXQgbm90IHRoZSBoeXBlcmNhbGwuLi4NCj4+Pj4+Pj4+IA0K Pj4+Pj4+Pj4gQXMgdGhpcyBpcyBhbiBpbnRlcm5hbCBpbnRlcmZhY2UsIGl0IHdvdWxkIGJlIGVh c2llciB0byBtb2RpZnkgYWZ0ZXJ3YXJkcy4NCj4+Pj4+Pj4gSG93IGFib3V0IHRoaXM/DQo+Pj4+ Pj4+IC8qDQo+Pj4+Pj4+ICogTGlzdCBvZiBwb3NzaWJsZSBmZWF0dXJlcyBmb3IgZG9tMGxlc3Mg ZG9tVXMNCj4+Pj4+Pj4gKg0KPj4+Pj4+PiAqIERPTTBMRVNTX0VOSEFOQ0VEX0JBU0lDOiBYZW4g UFYgaW50ZXJmYWNlcywgaW5jbHVkaW5nIGdyYW50LXRhYmxlIGFuZA0KPj4+Pj4+PiAqICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGV2dGNo biwgd2lsbCBiZSBlbmFibGVkIGZvciB0aGUgVk0uDQo+Pj4+Pj4gDQo+Pj4+Pj4gVGVjaG5pY2Fs bHksIHRoZSBndWVzdCBjYW4gYWxyZWFkeSB1c2UgdGhlIGdyYW50LXRhYmxlIGFuZCBldnRjaG4g aW50ZXJmYWNlcy4gVGhpcyBhbHNvIHJlYWRzIHF1aXRlIG9kZCB0byBtZSBiZWNhdXNlICJpbmNs dWRpbmciIGRvZXNuJ3QgdGVsbCB3aGF0J3Mgbm90IGVuYWJsZWQuIFNvIG9uZSBjb3VsZCBhc3N1 bWUgWGVuc3RvcmVkIGlzIGFsc28gZW5hYmxlZC4gSW4gZmFjdCB0aGUgd29yZGluZyBmb3IgYGBE T00wTEVTU19FTkhBTkNFRGBgIGlzIHdoYXQgbWFrZXMgaXQgYSBsb3QgbW9yZSBjb25mdXNpbmcu DQo+Pj4+Pj4gDQo+Pj4+Pj4gU28gSSB3b3VsZCBzdWdnZXN0IHRoZSBmb2xsb3dpbmcgd29yZGlu ZzoNCj4+Pj4+PiANCj4+Pj4+PiAiTm90aWZ5IHRoZSBPUyBpdCBpcyBydW5uaW5nIG9uIHRvcCBv ZiBYZW4uIEFsbCB0aGUgZGVmYXVsdCBmZWF0dXJlcyBidXQgWGVuc3RvcmUgd2lsbCBiZSBhdmFp bGFibGUuIE5vdGUgdGhhdCBhbiBPUyAqbXVzdCogbm90IHJlbHkgb24gdGhlIGF2YWlsYWJpbGl0 eSBvZiBYZW4gZmVhdHVyZXMgaWYgdGhpcyBpcyBub3Qgc2V0Lg0KPj4+Pj4+ICINCj4+Pj4+PiAN Cj4+Pj4+PiBUaGUgd29yZGluZyBjYW4gYmUgdXBkYXRlZCBvbmNlIHdlIHByb3Blcmx5IGRpc2Fi bGUgZXZlbnQgY2hhbm5lbC9ncmFudCB0YWJsZSB3aGVuIHRoZSBmbGFnIGlzIG5vdCBzZXQuDQo+ Pj4+Pj4gDQo+Pj4+Pj4+ICogRE9NMExFU1NfWEVOU1RPUkU6ICAgICAgICAgICAgICBYZW5zdG9y ZSB3aWxsIGJlIGVuYWJsZWQgZm9yIHRoZSBWTS4NCj4+Pj4+PiANCj4+Pj4+PiBJIHdvdWxkIG1h a2UgY2xlYXIgdGhpcyBjYW4ndCBiZSB1c2VkIHdpdGhvdXQgdGhlIGZpcnN0IG9uZS4NCj4+Pj4+ PiANCj4+Pj4+Pj4gKiBET00wTEVTU19FTkhBTkNFRDogICAgICAgICAgICAgIFhlbiBQViBpbnRl cmZhY2VzLCBpbmNsdWRpbmcgZ3JhbnQtdGFibGUgeGVuc3RvcmUgPiAgICogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5kDQo+Pj4+Pj4g ZXZ0Y2huLCB3aWxsIGJlIGVuYWJsZWQgZm9yIHRoZSBWTS4NCj4+Pj4+PiANCj4+Pj4+PiBTZWUg YWJvdmUgYWJvdXQgIlBWIGludGVyZmFjZXMiLiBTbyBJIHdvdWxkIHN1Z2dlc3QgdG8gcmV3b3Jk IHRvOg0KPj4+Pj4+IA0KPj4+Pj4+ICJOb3RpZnkgdGhlIE9TIGl0IGlzIHJ1bm5pbmcgb24gdG9w IG9mIFhlbi4gQWxsIHRoZSBkZWZhdWx0IGZlYXR1cmVzIChpbmNsdWRpbmcgWGVuc3RvcmUpIHdp bGwgYmUgYXZhaWxhYmxlIi4NCj4+Pj4+PiANCj4+Pj4+Pj4gKi8NCj4+Pj4+Pj4gI2RlZmluZSBE T00wTEVTU19FTkhBTkNFRF9CQVNJQyBCSVQoMCwgVUwpDQo+Pj4+Pj4+ICNkZWZpbmUgRE9NMExF U1NfWEVOU1RPUkUgICAgICAgQklUKDEsIFVMKQ0KPj4+Pj4+IA0KPj4+Pj4+IEJhc2VkIG9uIHRo ZSBjb21tZW50IGFib3ZlLCBJIHdvdWxkIGNvbnNpZGVyIHRvIGRlZmluZSBET00wTEVTU19YRU5T VE9SRSBhcyBiaXQgMCBhbmQgMSBzZXQuDQo+Pj4+Pj4gDQo+Pj4+Pj4+ICNkZWZpbmUgRE9NMExF U1NfRU5IQU5DRUQgICAgICAgKERPTTBMRVNTX0VOSEFOQ0VEX0JBU0lDIHwgRE9NMExFU1NfWEVO U1RPUkUpDQo+Pj4+PiBCZXJ0cmFuZCBhbmQgSSBkaXNjdXNzZWQgdGhpcyBhZ2FpbiB3ZSBjYW1l IHRvIHRoZSBjb25jbHVzaW9uIHRoYXQgRE9NMExFU1NfRU5IQU5DRURfQkFTSUMgaXMgbm90DQo+ Pj4+PiB0aGUgc3VpdGFibGUgbmFtZSBhcyB0aGlzIG1ha2VzIHRoZSBjb2RlIHVuY2xlYXIgYW5k IGRvZXMgbm90IGNvcnJlc3BvbmQgdG8gRFQgc2V0dGluZ3MuIFdlIHByb3Bvc2UgdGhpcw0KPj4+ Pj4gcGxlYXNlIGxldCBtZSBrbm93IHlvdXIgdGhvdWdodHMuDQo+Pj4+IA0KPj4+PiBUbyBtZSB0 aGUgZGVmYXVsdCBvZiAiZW5oYW5jZWQiIHNob3VsZCBiZSBhbGwgWGVuIGZlYXR1cmVzLiBBbnl0 aGluZyBlbHNlIHNob3VsZCBiZSBjb25zaWRlciBhcyByZWR1Y2VkL2Jhc2ljL21pbmltdW0uIEhl bmNlIHdoeSBJIHN0aWxsIHRoaW5rIHdlIG5lZWQgdG8gYWRkIGl0IGluIHRoZSBuYW1lIGV2ZW4g aWYgdGhpcyBpcyBub3Qgd2hhdCB3ZSBleHBvc2UgaW4gdGhlIERULiBJbiBmYWN0Li4uDQo+Pj4+ PiAvKg0KPj4+Pj4gKiBMaXN0IG9mIHBvc3NpYmxlIGZlYXR1cmVzIGZvciBkb20wbGVzcyBkb21V cw0KPj4+Pj4gKg0KPj4+Pj4gKiBET00wTEVTU19YRU5TVE9SRTogICAgICAgICAgICAgIFhlbnN0 b3JlIHdpbGwgYmUgZW5hYmxlZCBmb3IgdGhlIFZNLiBUaGlzIGZlYXR1cmUNCj4+Pj4+ICogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2FuJ3QgYmUgZW5h YmxlZCB3aXRob3V0IHRoZSBET00wTEVTU19FTkhBTkNFRC4NCj4+Pj4+ICogRE9NMExFU1NfRU5I QU5DRUQ6ICAgICAgICAgICAgICBOb3RpZnkgdGhlIE9TIGl0IGlzIHJ1bm5pbmcgb24gdG9wIG9m IFhlbi4gQWxsIHRoZQ0KPj4+Pj4gKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHQgZmVhdHVyZXMgKGluY2x1ZGluZyBYZW5zdG9y ZSkgd2lsbCBiZQ0KPj4+Pj4gKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGF2YWlsYWJsZS4gTm90ZSB0aGF0IGFuIE9TICptdXN0KiBub3Qg cmVseSBvbiB0aGUNCj4+Pj4+ICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBhdmFpbGFiaWxpdHkgb2YgWGVuIGZlYXR1cmVzIGlmIHRoaXMg aXMgbm90IHNldC4NCj4+Pj4gDQo+Pj4+IC4uLiB3aGF0IHlvdSB3cm90ZSBoZXJlIG1hdGNoIHdo YXQgSSB3cm90ZSBhYm92ZS4gU28gaXQgaXMgbm90IGNsZWFyIHRvIG1lIHdoYXQncyB0aGUgcG9p bnQgb2YgaGF2aW5nIGEgZmxhZyBET00wTEVTU19YRU5TVE9SRS4NCj4+PiBXaGVuIHdlIGxvb2tl ZCBhdCB0aGUgY29kZSB3aXRoIHRoZSBzb2x1dGlvbiB1c2luZyBCQVNJQywgaXQgd2FzIHJlYWxs eSBub3QgZWFzeSB0byB1bmRlcnN0YW5kLg0KPj4gDQo+PiBJIGRvbid0IHF1aXRlIHVuZGVyc3Rh bmQgaG93IHRoaXMgaXMgZGlmZmVyZW50IGZyb20gRU5IQU5DRUQsIEVOSEFOQ0VEX0ZVTEwuIElu IGZhY3QsIHdpdGhvdXQgbG9va2luZyBhdCB0aGUgZG9jdW1lbnRhdGlvbiwgdGhleSBtZWFuIGV4 YWN0bHkgdGhlIHNhbWUuLi4NCj4+IA0KPj4gVGhlIGRpZmZlcmVuY2UgYmV0d2VlbiAiQkFTSUMi IGFuZCAiRU5IQU5DRUQiIGlzIGNsZWFyLiBZb3Uga25vdyB0aGF0IGluIG9uZSBjYXNlLCB5b3Ug d291bGQgZ2V0IGxlc3MgdGhhbiB0aGUgb3RoZXIuDQo+PiANCj4+PiBCeSB0aGUgd2F5IHRoZSBj b21tZW50IGlzIHdyb25nIGFuZCBjb3JyZXNwb25kIHRvIHdoYXQgc2hvdWxkIGJlIEVOSEFOQ0VE X0ZVTEwgaGVyZQ0KPj4+IEVOSEFOQ0VEIHdvdWxkIGJlIHRoZSBiYXNlIHdpdGhvdXQgWGVuc3Rv cmUuDQo+PiANCj4+IFRoYW5rcyBmb3IgdGhlIGNvbmZpcm1hdGlvbi4gSSBhbSBhZnJhaWQsIEkg YW0gc3Ryb25nbHkgYWdhaW5zdCB0aGUgdGVybWlub2xvZ3kgeW91IHByb3Bvc2VkIChzZWUgYWJv dmUgd2h5KS4NCj4+IA0KPj4gSSB0aGluayBCQVNJQyAob3Igc2ltaWxhciBuYW1lKSBpcyBiZXR0 ZXIuIEJ1dCBJIGFtIG9wZW4gdG8gc3VnZ2VzdGlvbiBzbyBsb25nIGl0IGlzIG5vdCAiRE9NMExF U1NfRU5IQU5DRUQiIHZzICJET00wTEVTU19FTkhBTkNFRF9GVUxMIi4NCj4gDQo+IEkgZG8gbm90 IGFncmVlIGJ1dCBJIHRoaW5rIHRoaXMgaXMgb25seSBpbnRlcm5hbCBhbmQgY291bGQgZWFzaWx5 IGJlIG1vZGlmaWVkIG9uZSBkYXkgaWYgd2UgaGF2ZSBtb3JlIHVzZS1jYXNlcy4NCj4gU28gbGV0 4oCZcyBnbyBmb3IgQkFTSUMgYW5kIHVuYmxvY2sgdGhpcyBiZWZvcmUgdGhlIGZlYXR1cmUgZnJl ZXplLg0KPiANCj4gQmVydHJhbmQNCg0KUGxlYXNlIGhhdmUgYSBsb29rIG9uY2UgaWYgdGhpcyBs b29rcyBva2F5Lg0KDQovKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICogTGlzdCBvZiBwb3NzaWJs ZSBmZWF0dXJlcyBmb3IgZG9tMGxlc3MgZG9tVXMgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICANCiAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQogKiBET00wTEVTU19FTkhBTkNFRF9CQVNJ QzoJTm90aWZ5IHRoZSBPUyBpdCBpcyBydW5uaW5nIG9uIHRvcCBvZiBYZW4uIEFsbCB0aGUgIA0K ICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCWRlZmF1bHQgZmVhdHVyZXMgKGV4Y2x1ZGluZyBYZW5zdG9yZSkgd2lsbCBiZSAgICAgICAN CiAqICAgICAgICAgICAgICAgICAgICAgICAgICAJCQkJCWF2YWlsYWJsZS4gTm90ZSB0aGF0IGFu IE9TICptdXN0KiBub3QgcmVseSBvbiB0aGUgICANCiAqICAgICAgICAgICAgICAgICAgICAgICAg ICAJCQkJCWF2YWlsYWJpbGl0eSBvZiBYZW4gZmVhdHVyZXMgaWYgdGhpcyBpcyBub3Qgc2V0LiAg ICANCiAqIERPTTBMRVNTX1hFTlNUT1JFOiAgICAgICAJCVhlbnN0b3JlIHdpbGwgYmUgZW5hYmxl ZCBmb3IgdGhlIFZNLiBUaGlzIGZlYXR1cmUgICANCiAqICAgICAgICAgICAgICAgICAgICAgICAg ICAJCQkJCWNhbid0IGJlIGVuYWJsZWQgd2l0aG91dCB0aGUgRE9NMExFU1NfRU5IQU5DRURfQkFT SUMuICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICogRE9NMExFU1NfRU5IQU5DRUQ6CQkJ Tm90aWZ5IHRoZSBPUyBpdCBpcyBydW5uaW5nIG9uIHRvcCBvZiBYZW4uIEFsbCB0aGUgIA0KICog ICAgICAgICAgICAgICAgICAgICAgICAgIAkJCQkJZGVmYXVsdCBmZWF0dXJlcyAoaW5jbHVkaW5n IFhlbnN0b3JlKSB3aWxsIGJlICAgICAgIA0KICogICAgICAgICAgICAgICAgICAgICAgICAgIAkJ CQkJYXZhaWxhYmxlLiBOb3RlIHRoYXQgYW4gT1MgKm11c3QqIG5vdCByZWx5IG9uIHRoZSAgIA0K ICogICAgICAgICAgICAgICAgICAgICAgICAgIAkJCQkJYXZhaWxhYmlsaXR5IG9mIFhlbiBmZWF0 dXJlcyBpZiB0aGlzIGlzIG5vdCBzZXQuICAgIA0KICovICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiNk ZWZpbmUgRE9NMExFU1NfRU5IQU5DRURfQkFTSUMgICAgIEJJVCgwLCBVTCkgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgDQojZGVmaW5lIERPTTBMRVNTX1hFTlNUT1JFICAgICAgICAg ICAgICAgICAgQklUKDEsIFVMKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiNk ZWZpbmUgRE9NMExFU1NfRU5IQU5DRUQgICAgICAgICAgICAgICAgIChET00wTEVTU19FTkhBTkNF RF9CQVNJQyAgfCAgRE9NMExFU1NfWEVOU1RPUkUpDQoNClJlZ2FyZHMsDQpSYWh1bA0KIA== From xen-devel-bounces@lists.xenproject.org Mon Sep 05 13:51:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 13:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398878.639862 (Exim 4.92) (envelope-from ) id 1oVCV2-0004Gv-SA; Mon, 05 Sep 2022 13:50:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398878.639862; Mon, 05 Sep 2022 13:50:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVCV2-0004GR-L3; Mon, 05 Sep 2022 13:50:52 +0000 Received: by outflank-mailman (input) for mailman id 398878; Mon, 05 Sep 2022 13:50:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVCV0-0004D3-63 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 13:50:50 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be184c92-2d21-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 15:50:47 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4FB025C0124; Mon, 5 Sep 2022 09:50:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Sep 2022 09:50:46 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Sep 2022 09:50:44 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be184c92-2d21-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662385846; x=1662472246; bh=D1HUAi8Rml jpADjhvAS8+P6wQ88QJtRK17ws45qCrsA=; b=YDDMe5LhiZI/ojtjb/Xqcy6/0Y JVkZA97sgNsU4b7ye3aIGHJDaEKM+NsWhDWJrlxMo5/eCOdStv3nEqOSi2acazj1 gOXyiETySfAaMNkUt1S0V5tQNI+2FIJKl5oeItR5AL37KXE8vCJRPCKIrHJualkX mwp/lThcxnVT06luvYkRarJONCyWxglLzMk7t7QU+TvTLQ0oIfsRr00HI/BZeqpd QeWNIOZmEQ2PgPD9oLaEGMRQJS2DgUafp/7TTvwRVxuz9LFdSuOMAYMbe0yiCchm IZ6ncbTtNBCW1QE/ZCzrY4FEJyirX7nhnWBoh8jWkIXx20D2790yK1e+hZpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662385846; x= 1662472246; bh=D1HUAi8RmljpADjhvAS8+P6wQ88QJtRK17ws45qCrsA=; b=Y TJvtB0UTdCrRm+X+4EdufBqOxvJNy6Iz9B9E+1TA2J8WjFzH6djcJhHBhx81Y5nH OqWBxRvH+pZ59zICA+6vj341jTPSaHc33izBlHo0rq6sMF+eDSmhef3dk7bBIFW0 v/IFua9h0oKn/orxur+eRKE28Fmg6doi4GiVorhibL7TefiPcBmofCWlMHftrUec DQk/VYSi7opEa66b6F1wZ2PIsBVV31sPyMdyA21hj/B5bO491sGVw31MJ0jzxShu vM7IuMO4XYR0lSfLJXvktj6WFnwuXOxlyq2HFqRbADUTm2Wx9LOZmldwGW4G+xmR 8hQFzmHDE7kV0cv7Q0C2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeliedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 2/2] tools/libxl: enable in-band reconnect marker for stubdom QMP proxy Date: Mon, 5 Sep 2022 15:50:19 +0200 Message-Id: <20220905135019.3749982-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> References: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This enables stubdom reliably detect when it needs to reconnect QMP socket. It is critical, as otherwise QEMU will not send its handshake, and so libxl will timeout while waiting on one. When it happens during domain startup, it can result in error like this: libxl: libxl_pci.c:1772:device_pci_add_done: Domain 3:libxl__device_pci_add failed for PCI device 0:0:14.0 (rc -9) libxl: libxl_create.c:1904:domcreate_attach_devices: Domain 3:unable to add pci devices See vchan-socket-proxy commit message for details about this reconnect corner case. Stubdomain side needs to use --reconnect-marker=1 option too. Signed-off-by: Marek Marczykowski-Górecki --- tools/libs/light/libxl_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index fc264a3a13a6..cc9c5bea1e7f 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -2625,10 +2625,11 @@ static void spawn_qmp_proxy(libxl__egc *egc, sdss->qmp_proxy_spawn.failure_cb = qmp_proxy_startup_failed; sdss->qmp_proxy_spawn.detached_cb = qmp_proxy_detached; - const int arraysize = 6; + const int arraysize = 7; GCNEW_ARRAY(args, arraysize); args[nr++] = STUBDOM_QMP_PROXY_PATH; args[nr++] = GCSPRINTF("--state-path=%s", sdss->qmp_proxy_spawn.xspath); + args[nr++] = "--reconnect-marker=1"; args[nr++] = GCSPRINTF("%u", dm_domid); args[nr++] = GCSPRINTF("%s/device-model/%u/qmp-vchan", dom_path, guest_domid); args[nr++] = (char*)libxl__qemu_qmp_path(gc, guest_domid); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 13:51:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 13:51:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398879.639855 (Exim 4.92) (envelope-from ) id 1oVCV2-0004DP-GO; Mon, 05 Sep 2022 13:50:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398879.639855; Mon, 05 Sep 2022 13:50:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVCV2-0004DI-DT; Mon, 05 Sep 2022 13:50:52 +0000 Received: by outflank-mailman (input) for mailman id 398879; Mon, 05 Sep 2022 13:50:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVCV0-0004D4-0f for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 13:50:50 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bd56896e-2d21-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 15:50:47 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CD90A5C0129; Mon, 5 Sep 2022 09:50:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Sep 2022 09:50:44 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Sep 2022 09:50:43 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd56896e-2d21-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1662385844; x=1662472244; bh=z2EJpj9Jlrlm/5HYp/8onWWgFEWiwsTS8KY smptHOcA=; b=Iu5dwexg3XkHA1F8o8smQD5NDSIQ3HIlVa9ATvpkvHbiaZUrRVo 3u5TANlGzNn/jb/B8dgLS7IhH7Fl/+oeJiVrVT5TMNzYrTBvXqxmfSlGh2AjtgFU 536oy6mxuQ4+BZqoXRxGeLvceOQkiomOVeY7lFNELOkSbJqkcJ7ANdZ268ED3PN1 WRg3/raf/eiCnjsguxLOw0Jrz913sWNRGpb6M0H4a5/3gd2RdZkIrTLPHAhESxB2 27x88VeOJLdEwfSgF/369rL1zP2HWu9/nmLp/CV5mfZ9Fe3MZyOa6fOc5JpUSQHV tIvboXZztc1JxVJlZI6miQNWNAxA3xjkF8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1662385844; x=1662472244; bh=z2EJpj9Jlrlm/ 5HYp/8onWWgFEWiwsTS8KYsmptHOcA=; b=AwrILnfmwVzNb9VVUaT/XdJKct4H/ shMdphDsGcCaP6m0/mC+IU6npgRPC3vETlsovZjN09w9Qs8eYDRkAST6HmCo+Q8N T2VO1pIKzsliERYE/huCq4lD1EtkOdk//mMYVkojif/yIJ06Ft6TIHbdM8Qhpol6 qBDCv6hechCXMGEkoxpV0GbOgGYq0hYQQ49GzGdGeT97YB+8+6BaT0uuAjC6e79l cgyEI29AcAj5JOqM1d/pRFXr1T9Ni6xdCZzzlTaA5B91K1zoEPyzAQwSfJRP0hyx Dw318VaYvQD5yNxy5fT+rLXF4dfnXU/inZVC6XcK9tlmjgSgrjR6hCm9A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeliedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Wei Liu , Anthony PERARD Subject: [PATCH 1/2] vchan-socket-proxy: add reconnect marker support Date: Mon, 5 Sep 2022 15:50:18 +0200 Message-Id: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When vchan client reconnect quickly, the server may not notice it. This means, it won't reconnect the UNIX socket either. For QMP, it will prevent the client to see the QMP protocol handshake, and the communication will timeout. Solve the issue by sending in-band connect marker. Whenever server sees one (elsewhere than the first byte in the connection), handle it as a client had reconnected. The marker is a one byte, and the user need to choose something that doesn't appear in the data stream elsewhere. Signed-off-by: Marek Marczykowski-Górecki --- tools/vchan/vchan-socket-proxy.c | 51 +++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/tools/vchan/vchan-socket-proxy.c b/tools/vchan/vchan-socket-proxy.c index e1d959c6d15c..1e7defe9bae7 100644 --- a/tools/vchan/vchan-socket-proxy.c +++ b/tools/vchan/vchan-socket-proxy.c @@ -31,6 +31,7 @@ * One client is served at a time, clients needs to coordinate this themselves. */ +#define _GNU_SOURCE #include #include #include @@ -54,6 +55,9 @@ static void usage(char** argv) "\t-m, --mode=client|server - vchan connection mode (client by default)\n" "\t-s, --state-path=path - xenstore path where write \"running\" to \n" "\t at startup\n" + "\t-r, --reconnect-marker=value - send(client)/expect(server) a\n" + "\t single-byte marker to detect quick reconnects and\n" + "\t force reconnecting UNIX socket\n" "\t-v, --verbose - verbose logging\n" "\n" "client: client of a vchan connection, fourth parameter can be:\n" @@ -61,7 +65,7 @@ static void usage(char** argv) "\t whenever new connection is accepted;\n" "\t handle multiple _subsequent_ connections, until terminated\n" "\n" - "\tfile-no: except open FD of a socket in listen mode;\n" + "\tfile-no: expect open FD of a socket in listen mode;\n" "\t otherwise similar to socket-path\n" "\n" "\t-: open vchan connection immediately and pass the data\n" @@ -88,6 +92,7 @@ char outbuf[BUFSIZE]; int insiz = 0; int outsiz = 0; int verbose = 0; +int reconnect_marker_value = -1; struct vchan_proxy_state { struct libxenvchan *ctrl; @@ -291,6 +296,7 @@ int data_loop(struct vchan_proxy_state *state) int ret; int libxenvchan_fd; int max_fd; + bool just_connected = true; libxenvchan_fd = libxenvchan_fd_for_select(state->ctrl); for (;;) { @@ -368,8 +374,33 @@ int data_loop(struct vchan_proxy_state *state) exit(1); if (verbose) fprintf(stderr, "from-vchan: %.*s\n", ret, outbuf + outsiz); + if (reconnect_marker_value != -1) { + char *reconnect_found = + memrchr(outbuf + outsiz, reconnect_marker_value, ret); + if (just_connected && reconnect_found == outbuf + outsiz) { + /* skip reconnect marker at the very first byte of the data + * stream */ + memmove(outbuf + outsiz, outbuf + outsiz + 1, ret - 1); + ret -= 1; + } else if (reconnect_found) { + size_t newsiz = outbuf + outsiz + ret - reconnect_found - 1; + if (verbose) + fprintf(stderr, "reconnect marker found\n"); + /* discard everything before and including the reconnect + * marker */ + memmove(outbuf, reconnect_found + 1, newsiz); + outsiz = newsiz; + /* then handle it as the client had just disconnected */ + close(state->output_fd); + state->output_fd = -1; + close(state->input_fd); + state->input_fd = -1; + return 0; + } + } outsiz += ret; socket_wr(state->output_fd); + just_connected = false; } } return 0; @@ -385,6 +416,7 @@ static struct option options[] = { { "mode", required_argument, NULL, 'm' }, { "verbose", no_argument, NULL, 'v' }, { "state-path", required_argument, NULL, 's' }, + { "reconnect-marker", required_argument, NULL, 'r' }, { } }; @@ -421,6 +453,14 @@ int main(int argc, char **argv) case 's': state_path = optarg; break; + case 'r': + reconnect_marker_value = atoi(optarg); + if (reconnect_marker_value < 0 || reconnect_marker_value > 255) { + fprintf(stderr, "invalid argument for --reconnect-marker, " + "must be a number between 0 and 255\n"); + usage(argv); + } + break; case '?': usage(argv); } @@ -509,6 +549,15 @@ int main(int argc, char **argv) ret = 1; break; } + if (reconnect_marker_value != -1) { + const char marker_buf[] = { reconnect_marker_value }; + + if (libxenvchan_write(state.ctrl, marker_buf, sizeof(marker_buf)) + != sizeof(marker_buf)) { + fprintf(stderr, "failed to send reconnect marker\n"); + break; + } + } if (data_loop(&state) != 0) break; /* don't reconnect if output was stdout */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 14:27:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 14:27:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398896.639877 (Exim 4.92) (envelope-from ) id 1oVD4l-0008JF-Md; Mon, 05 Sep 2022 14:27:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398896.639877; Mon, 05 Sep 2022 14:27:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVD4l-0008J8-Jj; Mon, 05 Sep 2022 14:27:47 +0000 Received: by outflank-mailman (input) for mailman id 398896; Mon, 05 Sep 2022 14:27:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVD4k-0008Iy-7K; Mon, 05 Sep 2022 14:27:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVD4k-0003RC-54; Mon, 05 Sep 2022 14:27:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVD4j-00031U-Ph; Mon, 05 Sep 2022 14:27:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVD4j-0004x9-PE; Mon, 05 Sep 2022 14:27:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1xwRpIf4Y/vUQCdUX8psobmod14f1O02xOSyrW2DdG0=; b=jWJDyonHmIm8+VqeePh52RUF8V DrO1QRpSXTQZCJrBaUkONWL0YQJ6h6YMKs25i6Ssiuf9pq4lNsN9z5AoFT4rQYFycwSvCjDHGBgM9 +FhH/GgbYbtJKl0sY7fvgnmyAtOwVk/uxUF7EgBoM+jOR6F8OJt+sZU5ErAXpmHSThFY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173002: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d84473689611eed32fd90b27e614f28af767fa3f X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Mon, 05 Sep 2022 14:27:45 +0000 flight 173002 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173002/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172899 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen d84473689611eed32fd90b27e614f28af767fa3f baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172899 2022-08-31 22:01:49 Z 4 days Testing same since 173002 2022-09-05 11:00:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e997d05592..d844736896 d84473689611eed32fd90b27e614f28af767fa3f -> smoke From xen-devel-bounces@lists.xenproject.org Mon Sep 05 14:59:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 14:59:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398905.639888 (Exim 4.92) (envelope-from ) id 1oVDZG-0003GZ-4n; Mon, 05 Sep 2022 14:59:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398905.639888; Mon, 05 Sep 2022 14:59:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDZG-0003GS-21; Mon, 05 Sep 2022 14:59:18 +0000 Received: by outflank-mailman (input) for mailman id 398905; Mon, 05 Sep 2022 14:59:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDZE-0003GM-9p for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 14:59:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c0bb098-2d2b-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 16:59:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c0bb098-2d2b-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662389951; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SUYhBjSo65ns5zJUnqPMv2slbVg/QCx9SuyguzqTMdk=; b=RYW1kIpi9CFsOCyZaZK6txvjntTwGagma3YfQpIQ/7lq7tnMRI6XsH0K 8qbA5R1egJdIUDo5MzlyDxUUS7WfDblLO790VQsLsWsmWFmGLlwpeuKqi 8acy9CbQffKiwDG8viBAZNq1EFMLjVdcl2NGJRmP5jS9XwbrnSJGL5ixX U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80220326 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:rd93w6lb6LLuyGzOfyJm+Hro5gyIIURdPkR7XQ2eYbSJt1+Wr1Gzt xJLCz2Fb/ncZTOhetlwOdyxoxlUuZ6DmtVrSFFspXs2RCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37ayv4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kqNI0nyNtyIFh35 NckOB89VkG/3MSflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oi1aoCNIYbULSlTth28i VDG/HniPgATG//FwBe9yy3y1vCayEsXX6pNTeblp5aGmma7xGYeFRkXXluTuuSihwi1XNc3A 0cU4Cs1sa8q9EGxCMa7VBmxun2ssRsVWt4WGOo/gCmGyrDV+BqeHmgJVHhKbNU8t+ctWTUw0 laD2dLubRRjqKaQSG6d3r6MoCmuJDMOKmsfeS4DSxBD6N7myKk3jw/QQ/5mEaWvicbyFy22y DePxAAhg50DgMhN0L+0lXjXjjTpqpXXQwod4gTMQnnj/g5/fJSiZYGj9R7c9/koBKyUVEWbt X4I3e2X9vkTDIqlnTaIBu4KGdmB5fmfNybHqUVyBJRn/DOok1adeoRX7CB7NV1eGM8Ocj/0Y 2feoQpUopRUOROCTaJxeZP3NM0swoDpD9GjXffRBvJVeYR4fgKD+CBoZGaT0nrrnUxqlrswU b+ZbMKtAHAyGalhij2sSI8107AxzyQ67WrWTIL8yVKs1r/2TGWJRLkMNlzIdfww5q6ApATT8 v5PNs+LzQUZW+r7ChQ76qZKcwpMdyJiQ8mr9YoHLYZvPzaKBkk9Av/u844kWrVcjo9phsj4x iCBAWlxnQ+XaWL8FemaVpxyQOqxA8wn/SlqY3JE0UWAgCZ6P9v2hEsLX95uJOR8qrQ+pRJhZ 6NdE/hsFMijXdguF941SZDm5LJvex2w7e5lF3r0OWNvF3KMquGgxzMFQucM3HNUZsZPnZFiy 4BMLyuCKXb5eyxsDdzNdNWkxE6rsH4WlYpaBhWWeIIKJhiwqdE1cUQda8PbxOlVcH3+Ksayj V7KUX/0W8GWy2PKzDU5rf/d9Nr4ewePNkFbA3Pa/d6LCMUuxUL6mNcobQp9VWqCPI8C0Pn9O L49IjCVGKFvoWumRKIlSeY1kP9luoOyz1KYpyw9dEj2g52QIusIChG7MQNn78WhGpcxVdOKZ 3+y IronPort-HdrOrdr: A9a23:mt0LdKygZ/VlHQAOtJoHKrPwLr1zdoMgy1knxilNoRw8SK2lfu SV7ZMmPH7P+VIssR4b9exoVJPufZqYz+8S3WBzB8bGYOCFghrKEGgK1+KLqFeMJ8S9zJ8+6U 4JSdkGNDSaNzhHZKjBjjWFLw== X-IronPort-AV: E=Sophos;i="5.93,291,1654574400"; d="scan'208";a="80220326" Date: Mon, 5 Sep 2022 15:59:03 +0100 From: Anthony PERARD To: Henry Wang CC: "xen-devel@lists.xenproject.org" , "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , "Bertrand Marquis" , Julien Grall , "Julien Grall" , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Volodymyr Babchuk , "Wei Liu" , "Wei Liu (LSG)" Subject: Re: Xen 4.17 release: Current status before the feature freeze Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Sep 05, 2022 at 03:44:33AM +0000, Henry Wang wrote: > ** Blocker List **: > 2. The fix of libvirt after the virtio support in toolstack > Status: The OSSTEST seems to work properly, apart from what Jan > asked in IRC - the qemu and omvf OSSTEST might need a force push. > (I am not sure if this has been fixed so I just carried this) The build fix for libvirt have been applied to the project libvirt. osstest needs to be updated to be able to build recent version of libvirt. But we'll have to wait until Roger is back to update osstest (patch for osstest are available). Once osstest is updated, it should be able to test the recent version of libvirt and then start to use it with other branch (qemu and ovmf). I don't think a force push for qemu and ovmf is necessary, and fairly soon not needed. > ** Common **: > 10. [XEN,v2] build: Fix x86 out-of-tree build without EFI > https://patchwork.kernel.org/project/xen-devel/list/?series=668331 > Status: Reviewed but not merged. I believe this should be a blocker. And the status might be that I need to update the patch. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 05 15:06:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 15:06:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398913.639900 (Exim 4.92) (envelope-from ) id 1oVDgV-0004jZ-VL; Mon, 05 Sep 2022 15:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398913.639900; Mon, 05 Sep 2022 15:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDgV-0004jS-QQ; Mon, 05 Sep 2022 15:06:47 +0000 Received: by outflank-mailman (input) for mailman id 398913; Mon, 05 Sep 2022 15:06:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDgU-0004jM-Ce for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 15:06:46 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a7f3d8a-2d2c-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 17:06:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00378B8119C; Mon, 5 Sep 2022 15:06:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99AC4C433D6; Mon, 5 Sep 2022 15:06:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a7f3d8a-2d2c-11ed-af93-0125da4c0113 Date: Mon, 5 Sep 2022 11:07:13 -0400 From: Steven Rostedt To: Suren Baghdasaryan Cc: Michal Hocko , Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220905110713.27304149@gandalf.local.home> In-Reply-To: References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 4 Sep 2022 18:32:58 -0700 Suren Baghdasaryan wrote: > Page allocations (overheads are compared to get_free_pages() duration): > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > 8.8% lookup_page_ext > 1237% call stack capture > 139% tracepoint with attached empty BPF program Have you tried tracepoint with custom callback? static void my_callback(void *data, unsigned long call_site, const void *ptr, struct kmem_cache *s, size_t bytes_req, size_t bytes_alloc, gfp_t gfp_flags) { struct my_data_struct *my_data = data; { do whatever } } [..] register_trace_kmem_alloc(my_callback, my_data); Now the my_callback function will be called directly every time the kmem_alloc tracepoint is hit. This avoids that perf and BPF overhead. -- Steve From xen-devel-bounces@lists.xenproject.org Mon Sep 05 15:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 15:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398921.639910 (Exim 4.92) (envelope-from ) id 1oVDp7-0006DE-OJ; Mon, 05 Sep 2022 15:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398921.639910; Mon, 05 Sep 2022 15:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDp7-0006D7-LJ; Mon, 05 Sep 2022 15:15:41 +0000 Received: by outflank-mailman (input) for mailman id 398921; Mon, 05 Sep 2022 15:15:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDp5-0006Cx-Ql; Mon, 05 Sep 2022 15:15:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDp5-0004Ic-O9; Mon, 05 Sep 2022 15:15:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDp5-0004dR-7N; Mon, 05 Sep 2022 15:15:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVDp5-0006WY-6t; Mon, 05 Sep 2022 15:15:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KbHzSFrWBB0hzXm0jtVrEHAtr5sheLsE72VnhUW/YT0=; b=XXW78nk9Aipa1/s/VBFxLvacyr H+f/xIzf2Qd2dUaM2weEP1ddR5N3Ix6bz7iyYBo+aQJJInrCoZEUPvSaavB8pO2Di634ha0Rct9fX utYaaT66pOn/uxEQctZFLCGMtrWYQyVJb6bkJMyVCp6V8tZNbIMX20Nb3MpG/yXHM/EI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173003: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=08522341c4935f27cd7d3dbfd38ffa8329cdc2cb X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 05 Sep 2022 15:15:39 +0000 flight 173003 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173003/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 08522341c4935f27cd7d3dbfd38ffa8329cdc2cb baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 32 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 248 attempts Testing same since 172995 2022-09-05 03:33:08 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Pierre Gondois Ray Ni Rebecca Cran Rebecca Cran Sainadh Nagolu Sami Mujawar Shengfengx Xue Wu, Jiaxin Xiao X Chen Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1474 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 15:19:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 15:19:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398930.639920 (Exim 4.92) (envelope-from ) id 1oVDt3-0006rp-8c; Mon, 05 Sep 2022 15:19:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398930.639920; Mon, 05 Sep 2022 15:19:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDt3-0006ri-66; Mon, 05 Sep 2022 15:19:45 +0000 Received: by outflank-mailman (input) for mailman id 398930; Mon, 05 Sep 2022 15:19:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDt1-0006rY-OU; Mon, 05 Sep 2022 15:19:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDt1-0004LW-Ku; Mon, 05 Sep 2022 15:19:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDt1-0004mF-4C; Mon, 05 Sep 2022 15:19:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVDt1-0008DH-3k; Mon, 05 Sep 2022 15:19:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p/TeYwaPLvRnx9dOFH1UdFj+J95b5a8gQk7i3T2EYcI=; b=uMhzT7Jr80rdMsvXCSJCWQpNvo mii2mzwUBYVQCodkUrvGlV+cwjeYhMsUWjh3R7isukckPRhFMIVqvdo7+3lPXzr4I9U/+7+GKQRg+ zGRJ+bkui1/lHkVktLgvb65YtqIqNrZrx0F8pVsOjk1b07tHOvi9imG3x4vSBPhj1gFo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 172997: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=684cc17be897de3b0fd2e5a021a702f68046d9fe X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Mon, 05 Sep 2022 15:19:43 +0000 flight 172997 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172997/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-pvops 6 kernel-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 684cc17be897de3b0fd2e5a021a702f68046d9fe baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 32 days Failing since 172384 2022-08-11 11:13:58 Z 25 days 54 attempts Testing same since 172776 2022-08-25 17:42:45 Z 10 days 25 attempts ------------------------------------------------------------ 401 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 11210 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 15:22:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 15:22:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398940.639932 (Exim 4.92) (envelope-from ) id 1oVDvy-0008Ip-Sp; Mon, 05 Sep 2022 15:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398940.639932; Mon, 05 Sep 2022 15:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDvy-0008Ii-Pn; Mon, 05 Sep 2022 15:22:46 +0000 Received: by outflank-mailman (input) for mailman id 398940; Mon, 05 Sep 2022 15:22:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDvy-0008IY-1e; Mon, 05 Sep 2022 15:22:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDvx-0004PL-V8; Mon, 05 Sep 2022 15:22:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVDvx-0004sb-Hn; Mon, 05 Sep 2022 15:22:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVDvx-0001hz-HI; Mon, 05 Sep 2022 15:22:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qDPTSHz4xQ4Df2tZ8NCNnGoas3KVL0g3jhlU9Tc+cpU=; b=rrsACZtBG2a5z61HEDB9K/9qkh FGcJhX56k23XGqqwXZHzULf1d5FescLM6HbFBvkcfqwA9csVYuawtxAkMNYwvEhLIroDDCz59Fhji X0HCbOUDhc2CqS2+gePfJxDg6CJxkKIQHbveTWyvSMNUgmxKfCM4rPPxhtd2w0ynjpLg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172994: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:host-ping-check-xen:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e18e42e4b280c85b76967a9106a13ca61c16179 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Mon, 05 Sep 2022 15:22:45 +0000 flight 172994 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172994/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 10 host-ping-check-xen fail like 172133 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7e18e42e4b280c85b76967a9106a13ca61c16179 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 32 days Failing since 172152 2022-08-05 04:01:26 Z 31 days 72 attempts Testing same since 172994 2022-09-05 03:16:17 Z 0 days 1 attempts ------------------------------------------------------------ 1691 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 173946 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:31:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:31:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398952.639946 (Exim 4.92) (envelope-from ) id 1oVF00-0007PZ-0w; Mon, 05 Sep 2022 16:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398952.639946; Mon, 05 Sep 2022 16:30:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVEzz-0007PS-UG; Mon, 05 Sep 2022 16:30:59 +0000 Received: by outflank-mailman (input) for mailman id 398952; Mon, 05 Sep 2022 16:30:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVEzy-0007PM-QW for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:30:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1db73b5a-2d38-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:30:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97C9F139F; Mon, 5 Sep 2022 09:31:01 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90A8C3F534; Mon, 5 Sep 2022 09:30:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1db73b5a-2d38-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Date: Mon, 5 Sep 2022 17:30:35 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series merge the applicable Linux fixes to Xen. Bixuan Cui (1): xen/arm: smmuv3: Change *array into *const array Christophe JAILLET (1): xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Gustavo A. R. Silva (1): xen/arm: smmuv3: Fix fall-through warning for Clang Jean-Philippe Brucker (2): xen/arm: smmuv3: Fix endianness annotations xen/arm: smmuv3: Move definitions to a header Robin Murphy (1): xen/arm: smmuv3: Remove the page 1 fixup Zenghui Yu (2): xen/arm: smmuv3: Fix l1 stream table size in the error message xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Zhen Lei (1): xen/arm: smmuv3: Remove unnecessary oom message Zhou Wang (1): xen/arm: smmuv3: Ensure queue is read after updating prod pointer xen/drivers/passthrough/arm/smmu-v3.c | 741 ++------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ 2 files changed, 708 insertions(+), 705 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398954.639956 (Exim 4.92) (envelope-from ) id 1oVF0K-0007jq-7o; Mon, 05 Sep 2022 16:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398954.639956; Mon, 05 Sep 2022 16:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF0K-0007je-5D; Mon, 05 Sep 2022 16:31:20 +0000 Received: by outflank-mailman (input) for mailman id 398954; Mon, 05 Sep 2022 16:31:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF0I-0007PM-HE for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:31:18 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 2a56833c-2d38-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:31:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D8A1F1756; Mon, 5 Sep 2022 09:31:22 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9BB933F534; Mon, 5 Sep 2022 09:31:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a56833c-2d38-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zenghui Yu , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v3 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message Date: Mon, 5 Sep 2022 17:30:36 +0100 Message-Id: <0356dc541c86e7b7003df6ac941a673cec6f129d.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zenghui Yu Backport Linux commit dc898eb84b25. This is the clean backport without any changes. The actual size of level-1 stream table is l1size. This looks like an oversight on commit d2e88e7c081ef ("iommu/arm-smmu: Fix LOG2SIZE setting for 2-level stream tables") which forgot to update the @size in error message as well. As memory allocation failure is already bad enough, nothing worse would happen. But let's be careful. Signed-off-by: Zenghui Yu Link: https://lore.kernel.org/r/20200826141758.341-1-yuzenghui@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc898eb84b25 Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- --- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index f2562acc38..340609264d 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -2348,7 +2348,7 @@ static int arm_smmu_init_strtab_2lvl(struct arm_smmu_device *smmu) if (!strtab) { dev_err(smmu->dev, "failed to allocate l1 stream table (%u bytes)\n", - size); + l1size); return -ENOMEM; } cfg->strtab = strtab; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:31:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398966.639968 (Exim 4.92) (envelope-from ) id 1oVF0p-0008QK-HH; Mon, 05 Sep 2022 16:31:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398966.639968; Mon, 05 Sep 2022 16:31:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF0p-0008QD-E8; Mon, 05 Sep 2022 16:31:51 +0000 Received: by outflank-mailman (input) for mailman id 398966; Mon, 05 Sep 2022 16:31:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF0n-0007PM-RC for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:31:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 3d26dfa2-2d38-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:31:48 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C449139F; Mon, 5 Sep 2022 09:31:54 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB2763F534; Mon, 5 Sep 2022 09:31:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d26dfa2-2d38-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Jean-Philippe Brucker , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Robin Murphy , Will Deacon Subject: [PATCH v3 02/10] xen/arm: smmuv3: Fix endianness annotations Date: Mon, 5 Sep 2022 17:30:37 +0100 Message-Id: <19cce911d1c62683f49779f52d22d73e7812b557.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jean-Philippe Brucker Backport Linux commit 376cdf66f624. This is the clean backport without any changes. When building with C=1, sparse reports some issues regarding endianness annotations: arm-smmu-v3.c:221:26: warning: cast to restricted __le64 arm-smmu-v3.c:221:24: warning: incorrect type in assignment (different base types) arm-smmu-v3.c:221:24: expected restricted __le64 [usertype] arm-smmu-v3.c:221:24: got unsigned long long [usertype] arm-smmu-v3.c:229:20: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:229:20: expected restricted __le64 [usertype] *[assigned] dst arm-smmu-v3.c:229:20: got unsigned long long [usertype] *ent arm-smmu-v3.c:229:25: warning: incorrect type in argument 2 (different base types) arm-smmu-v3.c:229:25: expected unsigned long long [usertype] *[assigned] src arm-smmu-v3.c:229:25: got restricted __le64 [usertype] * arm-smmu-v3.c:396:20: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:396:20: expected restricted __le64 [usertype] *[assigned] dst arm-smmu-v3.c:396:20: got unsigned long long * arm-smmu-v3.c:396:25: warning: incorrect type in argument 2 (different base types) arm-smmu-v3.c:396:25: expected unsigned long long [usertype] *[assigned] src arm-smmu-v3.c:396:25: got restricted __le64 [usertype] * arm-smmu-v3.c:1349:32: warning: invalid assignment: |= arm-smmu-v3.c:1349:32: left side has type restricted __le64 arm-smmu-v3.c:1349:32: right side has type unsigned long arm-smmu-v3.c:1396:53: warning: incorrect type in argument 3 (different base types) arm-smmu-v3.c:1396:53: expected restricted __le64 [usertype] *dst arm-smmu-v3.c:1396:53: got unsigned long long [usertype] *strtab arm-smmu-v3.c:1424:39: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:1424:39: expected unsigned long long [usertype] *[assigned] strtab arm-smmu-v3.c:1424:39: got restricted __le64 [usertype] *l2ptr While harmless, they are incorrect and could hide actual errors during development. Fix them. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Robin Murphy Link: https://lore.kernel.org/r/20200918141856.629722-1-jean-philippe@linaro.org Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 376cdf66f624 Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- --- xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 340609264d..64d39bb4d3 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1037,7 +1037,7 @@ static int queue_insert_raw(struct arm_smmu_queue *q, u64 *ent) return 0; } -static void queue_read(__le64 *dst, u64 *src, size_t n_dwords) +static void queue_read(u64 *dst, __le64 *src, size_t n_dwords) { int i; @@ -1436,7 +1436,7 @@ static void arm_smmu_write_strtab_ent(struct arm_smmu_master *master, u32 sid, arm_smmu_cmdq_issue_cmd(smmu, &prefetch_cmd); } -static void arm_smmu_init_bypass_stes(u64 *strtab, unsigned int nent) +static void arm_smmu_init_bypass_stes(__le64 *strtab, unsigned int nent) { unsigned int i; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:32:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398969.639979 (Exim 4.92) (envelope-from ) id 1oVF1E-0000Wf-Ps; Mon, 05 Sep 2022 16:32:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398969.639979; Mon, 05 Sep 2022 16:32:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF1E-0000WW-Mu; Mon, 05 Sep 2022 16:32:16 +0000 Received: by outflank-mailman (input) for mailman id 398969; Mon, 05 Sep 2022 16:32:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF1C-0000Uj-HU for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:32:14 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4bd3d7e7-2d38-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 18:32:13 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F2897139F; Mon, 5 Sep 2022 09:32:18 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B74923F534; Mon, 5 Sep 2022 09:32:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bd3d7e7-2d38-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zhou Wang , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Date: Mon, 5 Sep 2022 17:30:38 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhou Wang Backport Linux commit a76a37777f2c. Rename __iomb to iomb() while merging to get in sync with other Xen definitions. Reading the 'prod' MMIO register in order to determine whether or not there is valid data beyond 'cons' for a given queue does not provide sufficient dependency ordering, as the resulting access is address dependent only on 'cons' and can therefore be speculated ahead of time, potentially allowing stale data to be read by the CPU. Use readl() instead of readl_relaxed() when updating the shadow copy of the 'prod' pointer, so that all speculated memory reads from the corresponding queue can occur only from valid slots. Signed-off-by: Zhou Wang Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c Signed-off-by: Rahul Singh --- Changes in v3: - rename __iomb() to iomb() and also move it from common file to smmu-v3.c file Changes in v2: - fix commit msg - add _iomb changes also from the origin patch --- xen/drivers/passthrough/arm/smmu-v3.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 64d39bb4d3..e632c75b21 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -107,6 +107,8 @@ typedef paddr_t dma_addr_t; typedef paddr_t phys_addr_t; typedef unsigned int gfp_t; +#define iomb() dmb(osh) + #define platform_device device #define GFP_KERNEL 0 @@ -951,7 +953,7 @@ static void queue_sync_cons_out(struct arm_smmu_queue *q) * Ensure that all CPU accesses (reads and writes) to the queue * are complete before we update the cons pointer. */ - mb(); + iomb(); writel_relaxed(q->llq.cons, q->cons_reg); } @@ -963,8 +965,15 @@ static void queue_inc_cons(struct arm_smmu_ll_queue *q) static int queue_sync_prod_in(struct arm_smmu_queue *q) { + u32 prod; int ret = 0; - u32 prod = readl_relaxed(q->prod_reg); + + /* + * We can't use the _relaxed() variant here, as we must prevent + * speculative reads of the queue before we have determined that + * prod has indeed moved. + */ + prod = readl(q->prod_reg); if (Q_OVF(prod) != Q_OVF(q->llq.prod)) ret = -EOVERFLOW; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:33:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:33:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398978.639990 (Exim 4.92) (envelope-from ) id 1oVF2d-0001K5-8f; Mon, 05 Sep 2022 16:33:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398978.639990; Mon, 05 Sep 2022 16:33:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2d-0001Jw-5h; Mon, 05 Sep 2022 16:33:43 +0000 Received: by outflank-mailman (input) for mailman id 398978; Mon, 05 Sep 2022 16:33:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2c-0001Jo-9y for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:33:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8038e1f3-2d38-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 18:33:41 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F1AEB139F; Mon, 5 Sep 2022 09:33:46 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B68D03F534; Mon, 5 Sep 2022 09:33:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8038e1f3-2d38-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Bixuan Cui , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v3 07/10] xen/arm: smmuv3: Change *array into *const array Date: Mon, 5 Sep 2022 17:30:42 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bixuan Cui Backport Linux commit d56d5162e317. This is the clean backport without any changes. Fix checkpatch warning in arm-smmu-v3.c: static const char * array should probably be static const char * const Signed-off-by: Bixuan Cui Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d56d5162e317 Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 512a3617a2..ef1604d863 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -470,7 +470,7 @@ static int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) { - static const char *cerror_str[] = { + static const char * const cerror_str[] = { [CMDQ_ERR_CERROR_NONE_IDX] = "No error", [CMDQ_ERR_CERROR_ILL_IDX] = "Illegal command", [CMDQ_ERR_CERROR_ABT_IDX] = "Abort on command fetch", -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:33:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398979.640001 (Exim 4.92) (envelope-from ) id 1oVF2f-0001aO-Fn; Mon, 05 Sep 2022 16:33:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398979.640001; Mon, 05 Sep 2022 16:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2f-0001aB-Cu; Mon, 05 Sep 2022 16:33:45 +0000 Received: by outflank-mailman (input) for mailman id 398979; Mon, 05 Sep 2022 16:33:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2e-0001Jo-JF for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:33:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 81b5caa4-2d38-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 18:33:43 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 652911756; Mon, 5 Sep 2022 09:33:49 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A3133F534; Mon, 5 Sep 2022 09:33:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81b5caa4-2d38-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zhen Lei , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v3 08/10] xen/arm: smmuv3: Remove unnecessary oom message Date: Mon, 5 Sep 2022 17:30:43 +0100 Message-Id: <02838ee702b7455831bf5f8022cf361f44e9e4f2.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhen Lei Backport Linux commit affa909571b0. This is the clean backport without any changes. Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210609125438.14369-1-thunder.leizhen@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git affa909571b0 Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- --- xen/drivers/passthrough/arm/smmu-v3.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index ef1604d863..6f551cfede 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1647,10 +1647,8 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) void *strtab = smmu->strtab_cfg.strtab; cfg->l1_desc = _xzalloc(size, sizeof(void *)); - if (!cfg->l1_desc) { - dev_err(smmu->dev, "failed to allocate l1 stream table desc\n"); + if (!cfg->l1_desc) return -ENOMEM; - } for (i = 0; i < cfg->num_l1_ents; ++i) { arm_smmu_write_strtab_l1_desc(strtab, &cfg->l1_desc[i]); @@ -2435,10 +2433,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev) struct arm_smmu_device *smmu; smmu = xzalloc(struct arm_smmu_device); - if (!smmu) { - dev_err(pdev, "failed to allocate arm_smmu_device\n"); + if (!smmu) return -ENOMEM; - } smmu->dev = pdev; if (pdev->of_node) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:33:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:33:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398980.640012 (Exim 4.92) (envelope-from ) id 1oVF2h-0001sD-N9; Mon, 05 Sep 2022 16:33:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398980.640012; Mon, 05 Sep 2022 16:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2h-0001s4-KY; Mon, 05 Sep 2022 16:33:47 +0000 Received: by outflank-mailman (input) for mailman id 398980; Mon, 05 Sep 2022 16:33:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2f-0001Jo-VG for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:33:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 826fe998-2d38-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 18:33:45 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98F131758; Mon, 5 Sep 2022 09:33:50 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DF303F534; Mon, 5 Sep 2022 09:33:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 826fe998-2d38-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: "Gustavo A. R. Silva" , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , kernel test robot Subject: [PATCH v3 09/10] xen/arm: smmuv3: Fix fall-through warning for Clang Date: Mon, 5 Sep 2022 17:30:44 +0100 Message-Id: <47eb45f019e402bbf7be485b3187ecfbfb4f99fb.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Gustavo A. R. Silva" Backport Linux commit 5a1ab5c0299a. This is the clean backport without any changes. Fix the following fallthrough warning (arm64-randconfig with Clang): drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:382:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] Reported-by: kernel test robot Link: https://lore.kernel.org/lkml/60edca25.k00ut905IFBjPyt5%25lkp@intel.com/ Signed-off-by: Gustavo A. R. Silva Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5a1ab5c0299a Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by. Changes in v2: - fix commit msg. --- xen/drivers/passthrough/arm/smmu-v3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 6f551cfede..e8f2f2dbe1 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -492,6 +492,7 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) switch (idx) { case CMDQ_ERR_CERROR_ABT_IDX: dev_err(smmu->dev, "retrying command fetch\n"); + return; case CMDQ_ERR_CERROR_NONE_IDX: return; case CMDQ_ERR_CERROR_ATC_INV_IDX: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:33:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:33:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.398981.640023 (Exim 4.92) (envelope-from ) id 1oVF2j-00029r-1y; Mon, 05 Sep 2022 16:33:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 398981.640023; Mon, 05 Sep 2022 16:33:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2i-00029h-Tn; Mon, 05 Sep 2022 16:33:48 +0000 Received: by outflank-mailman (input) for mailman id 398981; Mon, 05 Sep 2022 16:33:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2h-0001Jo-5n for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:33:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 83425ef9-2d38-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 18:33:46 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 232AA175A; Mon, 5 Sep 2022 09:33:52 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C1DEE3F534; Mon, 5 Sep 2022 09:33:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83425ef9-2d38-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Christophe JAILLET , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Robin Murphy , Will Deacon Subject: [PATCH v3 10/10] xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Date: Mon, 5 Sep 2022 17:30:45 +0100 Message-Id: <9cfdd7090aa113000eb903f3cf521caef23df8e1.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Christophe JAILLET Backport Linux commit 98b64741d611. This is the clean backport without any changes kmalloc_array()/kcalloc() should be used to avoid potential overflow when a multiplication is needed to compute the size of the requested memory. So turn a devm_kzalloc()+explicit size computation into an equivalent devm_kcalloc(). Signed-off-by: Christophe JAILLET Acked-by: Robin Murphy Link: https://lore.kernel.org/r/3f7b9b202c6b6f5edc234ab7af5f208fbf8bc944.1644274051.git.christophe.jaillet@wanadoo.fr Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 98b64741d611 Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- --- xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index e8f2f2dbe1..a3d5f53137 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1644,10 +1644,10 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) { unsigned int i; struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg; - size_t size = sizeof(*cfg->l1_desc) * cfg->num_l1_ents; void *strtab = smmu->strtab_cfg.strtab; - cfg->l1_desc = _xzalloc(size, sizeof(void *)); + cfg->l1_desc = _xzalloc_array(sizeof(*cfg->l1_desc), sizeof(void *), + cfg->num_l1_ents); if (!cfg->l1_desc) return -ENOMEM; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:37:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:37:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399000.640033 (Exim 4.92) (envelope-from ) id 1oVF6L-0003gr-IY; Mon, 05 Sep 2022 16:37:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399000.640033; Mon, 05 Sep 2022 16:37:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF6L-0003gk-Fw; Mon, 05 Sep 2022 16:37:33 +0000 Received: by outflank-mailman (input) for mailman id 399000; Mon, 05 Sep 2022 16:37:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF6K-0003ge-2z for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:37:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF6H-0006FA-1X; Mon, 05 Sep 2022 16:37:29 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVF6G-0008ER-Rm; Mon, 05 Sep 2022 16:37:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=OYcax9VqV1dppgMWP2EfWZrpSd5WoXtc4cBeacEit74=; b=yFGh1HE2fM+tZE5966zPfZR0Ii /C94/yN9OxIZgKNKOQxM90eHVbvxmmyGLdXN16l21HnBgBpR/343eL3tERJuigrLfUFU+leKDyFlj f7mcWEvkkHmL63PLKvckIJYAOrEO/kV2xUGaM13epfVCscycg3MU/bXe8UkIAl/uxqUI=; Message-ID: <885a4f6b-8350-229d-55da-4171eeafb800@xen.org> Date: Mon, 5 Sep 2022 17:37:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Zhou Wang , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Will Deacon References: Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/09/2022 17:30, Rahul Singh wrote: > From: Zhou Wang > > Backport Linux commit a76a37777f2c. Rename __iomb to iomb() while > merging to get in sync with other Xen definitions. > > Reading the 'prod' MMIO register in order to determine whether or > not there is valid data beyond 'cons' for a given queue does not > provide sufficient dependency ordering, as the resulting access is > address dependent only on 'cons' and can therefore be speculated > ahead of time, potentially allowing stale data to be read by the > CPU. > > Use readl() instead of readl_relaxed() when updating the shadow copy > of the 'prod' pointer, so that all speculated memory reads from the > corresponding queue can occur only from valid slots. > > Signed-off-by: Zhou Wang > Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com > [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c > Signed-off-by: Rahul Singh > --- > Changes in v3: > - rename __iomb() to iomb() and also move it from common file to > smmu-v3.c file Hmmm... Quoting Bertrand: "We need the __iomb as “linux compatibility” in fact so I would suggest for now to only introduce it at the beginning of smmu-v3.c with other linux compatibility stuff to prevent adding this to Xen overall." Which I also agreed. I couldn't a more recent conversation explaining your approach. Can you outline why you didn't follow the approached discussed? Cheers, > Changes in v2: > - fix commit msg > - add _iomb changes also from the origin patch > --- > xen/drivers/passthrough/arm/smmu-v3.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index 64d39bb4d3..e632c75b21 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -107,6 +107,8 @@ typedef paddr_t dma_addr_t; > typedef paddr_t phys_addr_t; > typedef unsigned int gfp_t; > > +#define iomb() dmb(osh) > + > #define platform_device device > > #define GFP_KERNEL 0 > @@ -951,7 +953,7 @@ static void queue_sync_cons_out(struct arm_smmu_queue *q) > * Ensure that all CPU accesses (reads and writes) to the queue > * are complete before we update the cons pointer. > */ > - mb(); > + iomb(); > writel_relaxed(q->llq.cons, q->cons_reg); > } > > @@ -963,8 +965,15 @@ static void queue_inc_cons(struct arm_smmu_ll_queue *q) > > static int queue_sync_prod_in(struct arm_smmu_queue *q) > { > + u32 prod; > int ret = 0; > - u32 prod = readl_relaxed(q->prod_reg); > + > + /* > + * We can't use the _relaxed() variant here, as we must prevent > + * speculative reads of the queue before we have determined that > + * prod has indeed moved. > + */ > + prod = readl(q->prod_reg); > > if (Q_OVF(prod) != Q_OVF(q->llq.prod)) > ret = -EOVERFLOW; -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:39:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:39:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399008.640050 (Exim 4.92) (envelope-from ) id 1oVF7m-0004Nu-8I; Mon, 05 Sep 2022 16:39:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399008.640050; Mon, 05 Sep 2022 16:39:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF7m-0004Mc-2P; Mon, 05 Sep 2022 16:39:02 +0000 Received: by outflank-mailman (input) for mailman id 399008; Mon, 05 Sep 2022 16:39:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF1U-0007PM-3v for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:32:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 55637154-2d38-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:32:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24737139F; Mon, 5 Sep 2022 09:32:35 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7246F3F534; Mon, 5 Sep 2022 09:32:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55637154-2d38-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Jean-Philippe Brucker , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Eric Auger , Jonathan Cameron , Will Deacon Subject: [PATCH v3 04/10] xen/arm: smmuv3: Move definitions to a header Date: Mon, 5 Sep 2022 17:30:39 +0100 Message-Id: <9d2a455ecb4e5bc8c846127e9df3080553c84888.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jean-Philippe Brucker Backport Linux commit e881e7839fba. Also, move Xen related struct definition to header to get it compiled. Allow sharing structure definitions with the upcoming SVA support for Arm SMMUv3, by moving them to a separate header. We could surgically extract only what is needed but keeping all definitions in one place looks nicer. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Eric Auger Reviewed-by: Jonathan Cameron Link: https://lore.kernel.org/r/20200918101852.582559-8-jean-philippe@linaro.org Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e881e7839fba Signed-off-by: Rahul Singh --- Changes in v3: - remove clean backport msg in commit msg Changes in v2: - fix commit msg - also move struct definition to header file to sync with Linux patch --- xen/drivers/passthrough/arm/smmu-v3.c | 665 +------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 674 ++++++++++++++++++++++++++ 2 files changed, 675 insertions(+), 664 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index e632c75b21..e65b226b85 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -90,6 +90,7 @@ #include #include +#include "smmu-v3.h" #define ARM_SMMU_VTCR_SH_IS 3 #define ARM_SMMU_VTCR_RGN_WBWA 1 @@ -103,22 +104,12 @@ #define ARM_SMMU_VTCR_PS_52_BIT 0x6ULL /* Linux compatibility functions. */ -typedef paddr_t dma_addr_t; -typedef paddr_t phys_addr_t; -typedef unsigned int gfp_t; - #define iomb() dmb(osh) #define platform_device device #define GFP_KERNEL 0 -/* Alias to Xen lock functions */ -#define mutex spinlock -#define mutex_init spin_lock_init -#define mutex_lock spin_lock -#define mutex_unlock spin_unlock - /* Device logger functions */ #define dev_name(dev) dt_node_full_name(dev->of_node) #define dev_dbg(dev, fmt, ...) \ @@ -159,12 +150,6 @@ typedef unsigned int gfp_t; #define readl_relaxed_poll_timeout(addr, val, cond, delay_us, timeout_us) \ readx_poll_timeout(readl_relaxed, addr, val, cond, delay_us, timeout_us) -#define FIELD_PREP(_mask, _val) \ - (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) - -#define FIELD_GET(_mask, _reg) \ - ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) - /* * Helpers for DMA allocation. Just the function name is reused for * porting code, these allocation are not managed allocations @@ -197,27 +182,6 @@ static void *dmam_alloc_coherent(struct device *dev, size_t size, return vaddr; } - -/* Xen specific code. */ -struct iommu_domain { - /* Runtime SMMU configuration for this iommu_domain */ - atomic_t ref; - /* - * Used to link iommu_domain contexts for a same domain. - * There is at least one per-SMMU to used by the domain. - */ - struct list_head list; -}; - -/* Describes information required for a Xen domain */ -struct arm_smmu_xen_domain { - spinlock_t lock; - - /* List of iommu domains associated to this domain */ - struct list_head contexts; -}; - - /* Keep a list of devices associated with this driver */ static DEFINE_SPINLOCK(arm_smmu_devices_lock); static LIST_HEAD(arm_smmu_devices); @@ -261,635 +225,8 @@ static int platform_get_irq_byname_optional(struct device *dev, } /* Start of Linux SMMUv3 code */ -/* MMIO registers */ -#define ARM_SMMU_IDR0 0x0 -#define IDR0_ST_LVL GENMASK(28, 27) -#define IDR0_ST_LVL_2LVL 1 -#define IDR0_STALL_MODEL GENMASK(25, 24) -#define IDR0_STALL_MODEL_STALL 0 -#define IDR0_STALL_MODEL_FORCE 2 -#define IDR0_TTENDIAN GENMASK(22, 21) -#define IDR0_TTENDIAN_MIXED 0 -#define IDR0_TTENDIAN_LE 2 -#define IDR0_TTENDIAN_BE 3 -#define IDR0_CD2L (1 << 19) -#define IDR0_VMID16 (1 << 18) -#define IDR0_PRI (1 << 16) -#define IDR0_SEV (1 << 14) -#define IDR0_MSI (1 << 13) -#define IDR0_ASID16 (1 << 12) -#define IDR0_ATS (1 << 10) -#define IDR0_HYP (1 << 9) -#define IDR0_COHACC (1 << 4) -#define IDR0_TTF GENMASK(3, 2) -#define IDR0_TTF_AARCH64 2 -#define IDR0_TTF_AARCH32_64 3 -#define IDR0_S1P (1 << 1) -#define IDR0_S2P (1 << 0) - -#define ARM_SMMU_IDR1 0x4 -#define IDR1_TABLES_PRESET (1 << 30) -#define IDR1_QUEUES_PRESET (1 << 29) -#define IDR1_REL (1 << 28) -#define IDR1_CMDQS GENMASK(25, 21) -#define IDR1_EVTQS GENMASK(20, 16) -#define IDR1_PRIQS GENMASK(15, 11) -#define IDR1_SSIDSIZE GENMASK(10, 6) -#define IDR1_SIDSIZE GENMASK(5, 0) - -#define ARM_SMMU_IDR5 0x14 -#define IDR5_STALL_MAX GENMASK(31, 16) -#define IDR5_GRAN64K (1 << 6) -#define IDR5_GRAN16K (1 << 5) -#define IDR5_GRAN4K (1 << 4) -#define IDR5_OAS GENMASK(2, 0) -#define IDR5_OAS_32_BIT 0 -#define IDR5_OAS_36_BIT 1 -#define IDR5_OAS_40_BIT 2 -#define IDR5_OAS_42_BIT 3 -#define IDR5_OAS_44_BIT 4 -#define IDR5_OAS_48_BIT 5 -#define IDR5_OAS_52_BIT 6 -#define IDR5_VAX GENMASK(11, 10) -#define IDR5_VAX_52_BIT 1 - -#define ARM_SMMU_CR0 0x20 -#define CR0_ATSCHK (1 << 4) -#define CR0_CMDQEN (1 << 3) -#define CR0_EVTQEN (1 << 2) -#define CR0_PRIQEN (1 << 1) -#define CR0_SMMUEN (1 << 0) - -#define ARM_SMMU_CR0ACK 0x24 - -#define ARM_SMMU_CR1 0x28 -#define CR1_TABLE_SH GENMASK(11, 10) -#define CR1_TABLE_OC GENMASK(9, 8) -#define CR1_TABLE_IC GENMASK(7, 6) -#define CR1_QUEUE_SH GENMASK(5, 4) -#define CR1_QUEUE_OC GENMASK(3, 2) -#define CR1_QUEUE_IC GENMASK(1, 0) -/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ -#define CR1_CACHE_NC 0 -#define CR1_CACHE_WB 1 -#define CR1_CACHE_WT 2 - -#define ARM_SMMU_CR2 0x2c -#define CR2_PTM (1 << 2) -#define CR2_RECINVSID (1 << 1) -#define CR2_E2H (1 << 0) - -#define ARM_SMMU_GBPA 0x44 -#define GBPA_UPDATE (1U << 31) -#define GBPA_ABORT (1 << 20) - -#define ARM_SMMU_IRQ_CTRL 0x50 -#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) -#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) -#define IRQ_CTRL_GERROR_IRQEN (1 << 0) - -#define ARM_SMMU_IRQ_CTRLACK 0x54 - -#define ARM_SMMU_GERROR 0x60 -#define GERROR_SFM_ERR (1 << 8) -#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) -#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) -#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) -#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) -#define GERROR_PRIQ_ABT_ERR (1 << 3) -#define GERROR_EVTQ_ABT_ERR (1 << 2) -#define GERROR_CMDQ_ERR (1 << 0) -#define GERROR_ERR_MASK 0xfd - -#define ARM_SMMU_GERRORN 0x64 - -#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 -#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 -#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 - -#define ARM_SMMU_STRTAB_BASE 0x80 -#define STRTAB_BASE_RA (1UL << 62) -#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) - -#define ARM_SMMU_STRTAB_BASE_CFG 0x88 -#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) -#define STRTAB_BASE_CFG_FMT_LINEAR 0 -#define STRTAB_BASE_CFG_FMT_2LVL 1 -#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) -#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) - -#define ARM_SMMU_CMDQ_BASE 0x90 -#define ARM_SMMU_CMDQ_PROD 0x98 -#define ARM_SMMU_CMDQ_CONS 0x9c - -#define ARM_SMMU_EVTQ_BASE 0xa0 -#define ARM_SMMU_EVTQ_PROD 0x100a8 -#define ARM_SMMU_EVTQ_CONS 0x100ac -#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 -#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 -#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc - -#define ARM_SMMU_PRIQ_BASE 0xc0 -#define ARM_SMMU_PRIQ_PROD 0x100c8 -#define ARM_SMMU_PRIQ_CONS 0x100cc -#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 -#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 -#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc - -#define ARM_SMMU_REG_SZ 0xe00 - -/* Common MSI config fields */ -#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) -#define MSI_CFG2_SH GENMASK(5, 4) -#define MSI_CFG2_MEMATTR GENMASK(3, 0) - -/* Common memory attribute values */ -#define ARM_SMMU_SH_NSH 0 -#define ARM_SMMU_SH_OSH 2 -#define ARM_SMMU_SH_ISH 3 -#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 -#define ARM_SMMU_MEMATTR_OIWB 0xf - -#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) -#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) -#define Q_OVERFLOW_FLAG (1U << 31) -#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) -#define Q_ENT(q, p) ((q)->base + \ - Q_IDX(&((q)->llq), p) * \ - (q)->ent_dwords) - -#define Q_BASE_RWA (1UL << 62) -#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) -#define Q_BASE_LOG2SIZE GENMASK(4, 0) - -/* Ensure DMA allocations are naturally aligned */ -#ifdef CONFIG_CMA_ALIGNMENT -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) -#else -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) -#endif - -/* - * Stream table. - * - * Linear: Enough to cover 1 << IDR1.SIDSIZE entries - * 2lvl: 128k L1 entries, - * 256 lazy entries per table (each table covers a PCI bus) - */ -#define STRTAB_L1_SZ_SHIFT 20 -#define STRTAB_SPLIT 8 - -#define STRTAB_L1_DESC_DWORDS 1 -#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) -#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) - -#define STRTAB_STE_DWORDS 8 -#define STRTAB_STE_0_V (1UL << 0) -#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) -#define STRTAB_STE_0_CFG_ABORT 0 -#define STRTAB_STE_0_CFG_BYPASS 4 -#define STRTAB_STE_0_CFG_S1_TRANS 5 -#define STRTAB_STE_0_CFG_S2_TRANS 6 - -#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) -#define STRTAB_STE_0_S1FMT_LINEAR 0 -#define STRTAB_STE_0_S1FMT_64K_L2 2 -#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) -#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) - -#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) -#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 -#define STRTAB_STE_1_S1DSS_BYPASS 0x1 -#define STRTAB_STE_1_S1DSS_SSID0 0x2 - -#define STRTAB_STE_1_S1C_CACHE_NC 0UL -#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL -#define STRTAB_STE_1_S1C_CACHE_WT 2UL -#define STRTAB_STE_1_S1C_CACHE_WB 3UL -#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) -#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) -#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) - -#define STRTAB_STE_1_S1STALLD (1UL << 27) - -#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) -#define STRTAB_STE_1_EATS_ABT 0UL -#define STRTAB_STE_1_EATS_TRANS 1UL -#define STRTAB_STE_1_EATS_S1CHK 2UL - -#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) -#define STRTAB_STE_1_STRW_NSEL1 0UL -#define STRTAB_STE_1_STRW_EL2 2UL - -#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) -#define STRTAB_STE_1_SHCFG_INCOMING 1UL - -#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) -#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) -#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) -#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) -#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) -#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) -#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) -#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) -#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) -#define STRTAB_STE_2_S2AA64 (1UL << 51) -#define STRTAB_STE_2_S2ENDI (1UL << 52) -#define STRTAB_STE_2_S2PTW (1UL << 54) -#define STRTAB_STE_2_S2R (1UL << 58) - -#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) - -/* - * Context descriptors. - * - * Linear: when less than 1024 SSIDs are supported - * 2lvl: at most 1024 L1 entries, - * 1024 lazy entries per table. - */ -#define CTXDESC_SPLIT 10 -#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) - -#define CTXDESC_L1_DESC_DWORDS 1 -#define CTXDESC_L1_DESC_V (1UL << 0) -#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) - -#define CTXDESC_CD_DWORDS 8 -#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) -#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) -#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) -#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) -#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) -#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) -#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) - -#define CTXDESC_CD_0_ENDI (1UL << 15) -#define CTXDESC_CD_0_V (1UL << 31) - -#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) -#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) - -#define CTXDESC_CD_0_AA64 (1UL << 41) -#define CTXDESC_CD_0_S (1UL << 44) -#define CTXDESC_CD_0_R (1UL << 45) -#define CTXDESC_CD_0_A (1UL << 46) -#define CTXDESC_CD_0_ASET (1UL << 47) -#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) - -#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) - -/* - * When the SMMU only supports linear context descriptor tables, pick a - * reasonable size limit (64kB). - */ -#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) - -/* Command queue */ -#define CMDQ_ENT_SZ_SHIFT 4 -#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) -#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) - -#define CMDQ_CONS_ERR GENMASK(30, 24) -#define CMDQ_ERR_CERROR_NONE_IDX 0 -#define CMDQ_ERR_CERROR_ILL_IDX 1 -#define CMDQ_ERR_CERROR_ABT_IDX 2 -#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 - -#define CMDQ_0_OP GENMASK_ULL(7, 0) -#define CMDQ_0_SSV (1UL << 11) - -#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) -#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) -#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) - -#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) -#define CMDQ_CFGI_1_LEAF (1UL << 0) -#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) - -#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) -#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) -#define CMDQ_TLBI_1_LEAF (1UL << 0) -#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) -#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) - -#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) -#define CMDQ_ATC_0_GLOBAL (1UL << 9) -#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) -#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) - -#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) -#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) -#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) - -#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) -#define CMDQ_SYNC_0_CS_NONE 0 -#define CMDQ_SYNC_0_CS_IRQ 1 -#define CMDQ_SYNC_0_CS_SEV 2 -#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) -#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) -#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) -#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) - -/* Event queue */ -#define EVTQ_ENT_SZ_SHIFT 5 -#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) -#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) - -#define EVTQ_0_ID GENMASK_ULL(7, 0) - -/* PRI queue */ -#define PRIQ_ENT_SZ_SHIFT 4 -#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) -#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) - -#define PRIQ_0_SID GENMASK_ULL(31, 0) -#define PRIQ_0_SSID GENMASK_ULL(51, 32) -#define PRIQ_0_PERM_PRIV (1UL << 58) -#define PRIQ_0_PERM_EXEC (1UL << 59) -#define PRIQ_0_PERM_READ (1UL << 60) -#define PRIQ_0_PERM_WRITE (1UL << 61) -#define PRIQ_0_PRG_LAST (1UL << 62) -#define PRIQ_0_SSID_V (1UL << 63) - -#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) -#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) - -/* High-level queue structures */ -#define ARM_SMMU_POLL_TIMEOUT_US 100 -#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ -#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 - static bool disable_bypass = 1; -enum pri_resp { - PRI_RESP_DENY = 0, - PRI_RESP_FAIL = 1, - PRI_RESP_SUCC = 2, -}; - -#ifdef CONFIG_MSI -enum arm_smmu_msi_index { - EVTQ_MSI_INDEX, - GERROR_MSI_INDEX, - PRIQ_MSI_INDEX, - ARM_SMMU_MAX_MSIS, -}; - -static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { - [EVTQ_MSI_INDEX] = { - ARM_SMMU_EVTQ_IRQ_CFG0, - ARM_SMMU_EVTQ_IRQ_CFG1, - ARM_SMMU_EVTQ_IRQ_CFG2, - }, - [GERROR_MSI_INDEX] = { - ARM_SMMU_GERROR_IRQ_CFG0, - ARM_SMMU_GERROR_IRQ_CFG1, - ARM_SMMU_GERROR_IRQ_CFG2, - }, - [PRIQ_MSI_INDEX] = { - ARM_SMMU_PRIQ_IRQ_CFG0, - ARM_SMMU_PRIQ_IRQ_CFG1, - ARM_SMMU_PRIQ_IRQ_CFG2, - }, -}; -#endif /* CONFIG_MSI */ - -struct arm_smmu_cmdq_ent { - /* Common fields */ - u8 opcode; - bool substream_valid; - - /* Command-specific fields */ - union { - #define CMDQ_OP_PREFETCH_CFG 0x1 - struct { - u32 sid; - u8 size; - u64 addr; - } prefetch; - - #define CMDQ_OP_CFGI_STE 0x3 - #define CMDQ_OP_CFGI_ALL 0x4 - struct { - u32 sid; - union { - bool leaf; - u8 span; - }; - } cfgi; - - #define CMDQ_OP_TLBI_EL2_ALL 0x20 - #define CMDQ_OP_TLBI_S12_VMALL 0x28 - #define CMDQ_OP_TLBI_S2_IPA 0x2a - #define CMDQ_OP_TLBI_NSNH_ALL 0x30 - struct { - u16 asid; - u16 vmid; - bool leaf; - u64 addr; - } tlbi; - - #define CMDQ_OP_ATC_INV 0x40 - #define ATC_INV_SIZE_ALL 52 - struct { - u32 sid; - u32 ssid; - u64 addr; - u8 size; - bool global; - } atc; - - #define CMDQ_OP_PRI_RESP 0x41 - struct { - u32 sid; - u32 ssid; - u16 grpid; - enum pri_resp resp; - } pri; - - #define CMDQ_OP_CMD_SYNC 0x46 - struct { - u32 msidata; - u64 msiaddr; - } sync; - }; -}; - -struct arm_smmu_ll_queue { - u32 prod; - u32 cons; - u32 max_n_shift; -}; - -struct arm_smmu_queue { - struct arm_smmu_ll_queue llq; - int irq; /* Wired interrupt */ - - __le64 *base; - dma_addr_t base_dma; - u64 q_base; - - size_t ent_dwords; - - u32 __iomem *prod_reg; - u32 __iomem *cons_reg; -}; - -struct arm_smmu_cmdq { - struct arm_smmu_queue q; - spinlock_t lock; -}; - -struct arm_smmu_evtq { - struct arm_smmu_queue q; - u32 max_stalls; -}; - -struct arm_smmu_priq { - struct arm_smmu_queue q; -}; - -/* High-level stream table and context descriptor structures */ -struct arm_smmu_strtab_l1_desc { - u8 span; - - __le64 *l2ptr; - dma_addr_t l2ptr_dma; -}; - -struct arm_smmu_s2_cfg { - u16 vmid; - u64 vttbr; - u64 vtcr; -}; - -struct arm_smmu_strtab_cfg { - __le64 *strtab; - dma_addr_t strtab_dma; - struct arm_smmu_strtab_l1_desc *l1_desc; - unsigned int num_l1_ents; - - u64 strtab_base; - u32 strtab_base_cfg; -}; - -struct arm_lpae_s2_cfg { - u64 vttbr; - struct { - u32 ps:3; - u32 tg:2; - u32 sh:2; - u32 orgn:2; - u32 irgn:2; - u32 sl:2; - u32 tsz:6; - } vtcr; -}; - -/* An SMMUv3 instance */ -struct arm_smmu_device { - struct device *dev; - void __iomem *base; - void __iomem *page1; - -#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) -#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) -#define ARM_SMMU_FEAT_TT_LE (1 << 2) -#define ARM_SMMU_FEAT_TT_BE (1 << 3) -#define ARM_SMMU_FEAT_PRI (1 << 4) -#define ARM_SMMU_FEAT_ATS (1 << 5) -#define ARM_SMMU_FEAT_SEV (1 << 6) -#define ARM_SMMU_FEAT_MSI (1 << 7) -#define ARM_SMMU_FEAT_COHERENCY (1 << 8) -#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) -#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) -#define ARM_SMMU_FEAT_STALLS (1 << 11) -#define ARM_SMMU_FEAT_HYP (1 << 12) -#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) -#define ARM_SMMU_FEAT_VAX (1 << 14) - u32 features; - -#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) -#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) - u32 options; - - struct arm_smmu_cmdq cmdq; - struct arm_smmu_evtq evtq; - struct arm_smmu_priq priq; - - int gerr_irq; - int combined_irq; - u32 sync_nr; - u8 prev_cmd_opcode; - - unsigned long ias; /* IPA */ - unsigned long oas; /* PA */ - unsigned long pgsize_bitmap; - -#define ARM_SMMU_MAX_VMIDS (1 << 16) - unsigned int vmid_bits; - DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); - - unsigned int sid_bits; - - struct arm_smmu_strtab_cfg strtab_cfg; - - /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ - union { - u32 sync_count; - u64 padding; - }; - - /* Need to keep a list of SMMU devices */ - struct list_head devices; - - /* Tasklets for handling evts/faults and pci page request IRQs*/ - struct tasklet evtq_irq_tasklet; - struct tasklet priq_irq_tasklet; - struct tasklet combined_irq_tasklet; -}; - -/* SMMU private data for each master */ -struct arm_smmu_master { - struct arm_smmu_device *smmu; - struct device *dev; - struct arm_smmu_domain *domain; - struct list_head domain_head; - u32 *sids; - unsigned int num_sids; - bool ats_enabled; -}; - -/* SMMU private data for an IOMMU domain */ -enum arm_smmu_domain_stage { - ARM_SMMU_DOMAIN_S1 = 0, - ARM_SMMU_DOMAIN_S2, - ARM_SMMU_DOMAIN_NESTED, - ARM_SMMU_DOMAIN_BYPASS, -}; - -struct arm_smmu_domain { - struct arm_smmu_device *smmu; - struct mutex init_mutex; /* Protects smmu pointer */ - - bool non_strict; - atomic_t nr_ats_masters; - - enum arm_smmu_domain_stage stage; - struct arm_smmu_s2_cfg s2_cfg; - - /* Xen domain associated with this SMMU domain */ - struct domain *d; - - struct iommu_domain domain; - - struct list_head devices; - spinlock_t devices_lock; -}; - struct arm_smmu_option_prop { u32 opt; const char *prop; diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h new file mode 100644 index 0000000000..c45d2f16c4 --- /dev/null +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -0,0 +1,674 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * IOMMU API for ARM architected SMMUv3 implementations. + * + * Copyright (C) 2022 ARM Limited + */ + +#ifndef _ARM_SMMU_V3_H +#define _ARM_SMMU_V3_H + +/* MMIO registers */ +#define ARM_SMMU_IDR0 0x0 +#define IDR0_ST_LVL GENMASK(28, 27) +#define IDR0_ST_LVL_2LVL 1 +#define IDR0_STALL_MODEL GENMASK(25, 24) +#define IDR0_STALL_MODEL_STALL 0 +#define IDR0_STALL_MODEL_FORCE 2 +#define IDR0_TTENDIAN GENMASK(22, 21) +#define IDR0_TTENDIAN_MIXED 0 +#define IDR0_TTENDIAN_LE 2 +#define IDR0_TTENDIAN_BE 3 +#define IDR0_CD2L (1 << 19) +#define IDR0_VMID16 (1 << 18) +#define IDR0_PRI (1 << 16) +#define IDR0_SEV (1 << 14) +#define IDR0_MSI (1 << 13) +#define IDR0_ASID16 (1 << 12) +#define IDR0_ATS (1 << 10) +#define IDR0_HYP (1 << 9) +#define IDR0_COHACC (1 << 4) +#define IDR0_TTF GENMASK(3, 2) +#define IDR0_TTF_AARCH64 2 +#define IDR0_TTF_AARCH32_64 3 +#define IDR0_S1P (1 << 1) +#define IDR0_S2P (1 << 0) + +#define ARM_SMMU_IDR1 0x4 +#define IDR1_TABLES_PRESET (1 << 30) +#define IDR1_QUEUES_PRESET (1 << 29) +#define IDR1_REL (1 << 28) +#define IDR1_CMDQS GENMASK(25, 21) +#define IDR1_EVTQS GENMASK(20, 16) +#define IDR1_PRIQS GENMASK(15, 11) +#define IDR1_SSIDSIZE GENMASK(10, 6) +#define IDR1_SIDSIZE GENMASK(5, 0) + +#define ARM_SMMU_IDR5 0x14 +#define IDR5_STALL_MAX GENMASK(31, 16) +#define IDR5_GRAN64K (1 << 6) +#define IDR5_GRAN16K (1 << 5) +#define IDR5_GRAN4K (1 << 4) +#define IDR5_OAS GENMASK(2, 0) +#define IDR5_OAS_32_BIT 0 +#define IDR5_OAS_36_BIT 1 +#define IDR5_OAS_40_BIT 2 +#define IDR5_OAS_42_BIT 3 +#define IDR5_OAS_44_BIT 4 +#define IDR5_OAS_48_BIT 5 +#define IDR5_OAS_52_BIT 6 +#define IDR5_VAX GENMASK(11, 10) +#define IDR5_VAX_52_BIT 1 + +#define ARM_SMMU_CR0 0x20 +#define CR0_ATSCHK (1 << 4) +#define CR0_CMDQEN (1 << 3) +#define CR0_EVTQEN (1 << 2) +#define CR0_PRIQEN (1 << 1) +#define CR0_SMMUEN (1 << 0) + +#define ARM_SMMU_CR0ACK 0x24 + +#define ARM_SMMU_CR1 0x28 +#define CR1_TABLE_SH GENMASK(11, 10) +#define CR1_TABLE_OC GENMASK(9, 8) +#define CR1_TABLE_IC GENMASK(7, 6) +#define CR1_QUEUE_SH GENMASK(5, 4) +#define CR1_QUEUE_OC GENMASK(3, 2) +#define CR1_QUEUE_IC GENMASK(1, 0) +/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ +#define CR1_CACHE_NC 0 +#define CR1_CACHE_WB 1 +#define CR1_CACHE_WT 2 + +#define ARM_SMMU_CR2 0x2c +#define CR2_PTM (1 << 2) +#define CR2_RECINVSID (1 << 1) +#define CR2_E2H (1 << 0) + +#define ARM_SMMU_GBPA 0x44 +#define GBPA_UPDATE (1 << 31) +#define GBPA_ABORT (1 << 20) + +#define ARM_SMMU_IRQ_CTRL 0x50 +#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) +#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) +#define IRQ_CTRL_GERROR_IRQEN (1 << 0) + +#define ARM_SMMU_IRQ_CTRLACK 0x54 + +#define ARM_SMMU_GERROR 0x60 +#define GERROR_SFM_ERR (1 << 8) +#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) +#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) +#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) +#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) +#define GERROR_PRIQ_ABT_ERR (1 << 3) +#define GERROR_EVTQ_ABT_ERR (1 << 2) +#define GERROR_CMDQ_ERR (1 << 0) +#define GERROR_ERR_MASK 0xfd + +#define ARM_SMMU_GERRORN 0x64 + +#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 +#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 +#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 + +#define ARM_SMMU_STRTAB_BASE 0x80 +#define STRTAB_BASE_RA (1UL << 62) +#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) + +#define ARM_SMMU_STRTAB_BASE_CFG 0x88 +#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) +#define STRTAB_BASE_CFG_FMT_LINEAR 0 +#define STRTAB_BASE_CFG_FMT_2LVL 1 +#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) +#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) + +#define ARM_SMMU_CMDQ_BASE 0x90 +#define ARM_SMMU_CMDQ_PROD 0x98 +#define ARM_SMMU_CMDQ_CONS 0x9c + +#define ARM_SMMU_EVTQ_BASE 0xa0 +#define ARM_SMMU_EVTQ_PROD 0x100a8 +#define ARM_SMMU_EVTQ_CONS 0x100ac +#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 +#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 +#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc + +#define ARM_SMMU_PRIQ_BASE 0xc0 +#define ARM_SMMU_PRIQ_PROD 0x100c8 +#define ARM_SMMU_PRIQ_CONS 0x100cc +#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 +#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 +#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc + +#define ARM_SMMU_REG_SZ 0xe00 + +/* Common MSI config fields */ +#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) +#define MSI_CFG2_SH GENMASK(5, 4) +#define MSI_CFG2_MEMATTR GENMASK(3, 0) + +/* Common memory attribute values */ +#define ARM_SMMU_SH_NSH 0 +#define ARM_SMMU_SH_OSH 2 +#define ARM_SMMU_SH_ISH 3 +#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 +#define ARM_SMMU_MEMATTR_OIWB 0xf + +#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) +#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) +#define Q_OVERFLOW_FLAG (1 << 31) +#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) +#define Q_ENT(q, p) ((q)->base + \ + Q_IDX(&((q)->llq), p) * \ + (q)->ent_dwords) + +#define Q_BASE_RWA (1UL << 62) +#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) +#define Q_BASE_LOG2SIZE GENMASK(4, 0) + +/* Ensure DMA allocations are naturally aligned */ +#ifdef CONFIG_CMA_ALIGNMENT +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) +#else +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) +#endif + +/* + * Stream table. + * + * Linear: Enough to cover 1 << IDR1.SIDSIZE entries + * 2lvl: 128k L1 entries, + * 256 lazy entries per table (each table covers a PCI bus) + */ +#define STRTAB_L1_SZ_SHIFT 20 +#define STRTAB_SPLIT 8 + +#define STRTAB_L1_DESC_DWORDS 1 +#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) +#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) + +#define STRTAB_STE_DWORDS 8 +#define STRTAB_STE_0_V (1UL << 0) +#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) +#define STRTAB_STE_0_CFG_ABORT 0 +#define STRTAB_STE_0_CFG_BYPASS 4 +#define STRTAB_STE_0_CFG_S1_TRANS 5 +#define STRTAB_STE_0_CFG_S2_TRANS 6 + +#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) +#define STRTAB_STE_0_S1FMT_LINEAR 0 +#define STRTAB_STE_0_S1FMT_64K_L2 2 +#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) +#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) + +#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) +#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 +#define STRTAB_STE_1_S1DSS_BYPASS 0x1 +#define STRTAB_STE_1_S1DSS_SSID0 0x2 + +#define STRTAB_STE_1_S1C_CACHE_NC 0UL +#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL +#define STRTAB_STE_1_S1C_CACHE_WT 2UL +#define STRTAB_STE_1_S1C_CACHE_WB 3UL +#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) +#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) +#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) + +#define STRTAB_STE_1_S1STALLD (1UL << 27) + +#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) +#define STRTAB_STE_1_EATS_ABT 0UL +#define STRTAB_STE_1_EATS_TRANS 1UL +#define STRTAB_STE_1_EATS_S1CHK 2UL + +#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) +#define STRTAB_STE_1_STRW_NSEL1 0UL +#define STRTAB_STE_1_STRW_EL2 2UL + +#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) +#define STRTAB_STE_1_SHCFG_INCOMING 1UL + +#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) +#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) +#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) +#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) +#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) +#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) +#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) +#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) +#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) +#define STRTAB_STE_2_S2AA64 (1UL << 51) +#define STRTAB_STE_2_S2ENDI (1UL << 52) +#define STRTAB_STE_2_S2PTW (1UL << 54) +#define STRTAB_STE_2_S2R (1UL << 58) + +#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) + +/* + * Context descriptors. + * + * Linear: when less than 1024 SSIDs are supported + * 2lvl: at most 1024 L1 entries, + * 1024 lazy entries per table. + */ +#define CTXDESC_SPLIT 10 +#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) + +#define CTXDESC_L1_DESC_DWORDS 1 +#define CTXDESC_L1_DESC_V (1UL << 0) +#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) + +#define CTXDESC_CD_DWORDS 8 +#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) +#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) +#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) +#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) +#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) +#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) +#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) + +#define CTXDESC_CD_0_ENDI (1UL << 15) +#define CTXDESC_CD_0_V (1UL << 31) + +#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) +#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) + +#define CTXDESC_CD_0_AA64 (1UL << 41) +#define CTXDESC_CD_0_S (1UL << 44) +#define CTXDESC_CD_0_R (1UL << 45) +#define CTXDESC_CD_0_A (1UL << 46) +#define CTXDESC_CD_0_ASET (1UL << 47) +#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) + +#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) + +/* + * When the SMMU only supports linear context descriptor tables, pick a + * reasonable size limit (64kB). + */ +#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) + +/* Command queue */ +#define CMDQ_ENT_SZ_SHIFT 4 +#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) +#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) + +#define CMDQ_CONS_ERR GENMASK(30, 24) +#define CMDQ_ERR_CERROR_NONE_IDX 0 +#define CMDQ_ERR_CERROR_ILL_IDX 1 +#define CMDQ_ERR_CERROR_ABT_IDX 2 +#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 + +#define CMDQ_0_OP GENMASK_ULL(7, 0) +#define CMDQ_0_SSV (1UL << 11) + +#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) +#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) +#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) + +#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) +#define CMDQ_CFGI_1_LEAF (1UL << 0) +#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) + +#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) +#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) +#define CMDQ_TLBI_1_LEAF (1UL << 0) +#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) +#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) + +#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) +#define CMDQ_ATC_0_GLOBAL (1UL << 9) +#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) +#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) + +#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) +#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) +#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) + +#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) +#define CMDQ_SYNC_0_CS_NONE 0 +#define CMDQ_SYNC_0_CS_IRQ 1 +#define CMDQ_SYNC_0_CS_SEV 2 +#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) +#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) +#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) +#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) + +/* Event queue */ +#define EVTQ_ENT_SZ_SHIFT 5 +#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) +#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) + +#define EVTQ_0_ID GENMASK_ULL(7, 0) + +/* PRI queue */ +#define PRIQ_ENT_SZ_SHIFT 4 +#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) +#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) + +#define PRIQ_0_SID GENMASK_ULL(31, 0) +#define PRIQ_0_SSID GENMASK_ULL(51, 32) +#define PRIQ_0_PERM_PRIV (1UL << 58) +#define PRIQ_0_PERM_EXEC (1UL << 59) +#define PRIQ_0_PERM_READ (1UL << 60) +#define PRIQ_0_PERM_WRITE (1UL << 61) +#define PRIQ_0_PRG_LAST (1UL << 62) +#define PRIQ_0_SSID_V (1UL << 63) + +#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) +#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) + +/* High-level queue structures */ +#define ARM_SMMU_POLL_TIMEOUT_US 100 +#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ +#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 + +#define FIELD_PREP(_mask, _val) \ + (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) + +#define FIELD_GET(_mask, _reg) \ + ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) + +/* Linux compatibility functions. */ +typedef paddr_t dma_addr_t; +typedef paddr_t phys_addr_t; +typedef unsigned int gfp_t; + +/* Alias to Xen lock functions */ +#define mutex spinlock +#define mutex_init spin_lock_init +#define mutex_lock spin_lock +#define mutex_unlock spin_unlock + +/* SMMU private data for an IOMMU domain */ +enum arm_smmu_domain_stage { + ARM_SMMU_DOMAIN_S1 = 0, + ARM_SMMU_DOMAIN_S2, + ARM_SMMU_DOMAIN_NESTED, + ARM_SMMU_DOMAIN_BYPASS, +}; + +/* Xen specific code. */ +struct iommu_domain { + /* Runtime SMMU configuration for this iommu_domain */ + atomic_t ref; + /* + * Used to link iommu_domain contexts for a same domain. + * There is at least one per-SMMU to used by the domain. + */ + struct list_head list; +}; + +/* Describes information required for a Xen domain */ +struct arm_smmu_xen_domain { + spinlock_t lock; + + /* List of iommu domains associated to this domain */ + struct list_head contexts; +}; + +enum pri_resp { + PRI_RESP_DENY = 0, + PRI_RESP_FAIL = 1, + PRI_RESP_SUCC = 2, +}; + +#ifdef CONFIG_MSI +enum arm_smmu_msi_index { + EVTQ_MSI_INDEX, + GERROR_MSI_INDEX, + PRIQ_MSI_INDEX, + ARM_SMMU_MAX_MSIS, +}; + +static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { + [EVTQ_MSI_INDEX] = { + ARM_SMMU_EVTQ_IRQ_CFG0, + ARM_SMMU_EVTQ_IRQ_CFG1, + ARM_SMMU_EVTQ_IRQ_CFG2, + }, + [GERROR_MSI_INDEX] = { + ARM_SMMU_GERROR_IRQ_CFG0, + ARM_SMMU_GERROR_IRQ_CFG1, + ARM_SMMU_GERROR_IRQ_CFG2, + }, + [PRIQ_MSI_INDEX] = { + ARM_SMMU_PRIQ_IRQ_CFG0, + ARM_SMMU_PRIQ_IRQ_CFG1, + ARM_SMMU_PRIQ_IRQ_CFG2, + }, +}; +#endif /* CONFIG_MSI */ + +struct arm_smmu_cmdq_ent { + /* Common fields */ + u8 opcode; + bool substream_valid; + + /* Command-specific fields */ + union { + #define CMDQ_OP_PREFETCH_CFG 0x1 + struct { + u32 sid; + u8 size; + u64 addr; + } prefetch; + + #define CMDQ_OP_CFGI_STE 0x3 + #define CMDQ_OP_CFGI_ALL 0x4 + struct { + u32 sid; + union { + bool leaf; + u8 span; + }; + } cfgi; + + #define CMDQ_OP_TLBI_EL2_ALL 0x20 + #define CMDQ_OP_TLBI_S12_VMALL 0x28 + #define CMDQ_OP_TLBI_S2_IPA 0x2a + #define CMDQ_OP_TLBI_NSNH_ALL 0x30 + struct { + u16 asid; + u16 vmid; + bool leaf; + u64 addr; + } tlbi; + + #define CMDQ_OP_ATC_INV 0x40 + #define ATC_INV_SIZE_ALL 52 + struct { + u32 sid; + u32 ssid; + u64 addr; + u8 size; + bool global; + } atc; + + #define CMDQ_OP_PRI_RESP 0x41 + struct { + u32 sid; + u32 ssid; + u16 grpid; + enum pri_resp resp; + } pri; + + #define CMDQ_OP_CMD_SYNC 0x46 + struct { + u32 msidata; + u64 msiaddr; + } sync; + }; +}; + +struct arm_smmu_ll_queue { + u32 prod; + u32 cons; + u32 max_n_shift; +}; + +struct arm_smmu_queue { + struct arm_smmu_ll_queue llq; + int irq; /* Wired interrupt */ + + __le64 *base; + dma_addr_t base_dma; + u64 q_base; + + size_t ent_dwords; + + u32 __iomem *prod_reg; + u32 __iomem *cons_reg; +}; + +struct arm_smmu_cmdq { + struct arm_smmu_queue q; + spinlock_t lock; +}; + +struct arm_smmu_evtq { + struct arm_smmu_queue q; + u32 max_stalls; +}; + +struct arm_smmu_priq { + struct arm_smmu_queue q; +}; + +/* High-level stream table and context descriptor structures */ +struct arm_smmu_strtab_l1_desc { + u8 span; + + __le64 *l2ptr; + dma_addr_t l2ptr_dma; +}; + +struct arm_smmu_s2_cfg { + u16 vmid; + u64 vttbr; + u64 vtcr; +}; + +struct arm_smmu_strtab_cfg { + __le64 *strtab; + dma_addr_t strtab_dma; + struct arm_smmu_strtab_l1_desc *l1_desc; + unsigned int num_l1_ents; + + u64 strtab_base; + u32 strtab_base_cfg; +}; + +struct arm_lpae_s2_cfg { + u64 vttbr; + struct { + u32 ps:3; + u32 tg:2; + u32 sh:2; + u32 orgn:2; + u32 irgn:2; + u32 sl:2; + u32 tsz:6; + } vtcr; +}; + +/* An SMMUv3 instance */ +struct arm_smmu_device { + struct device *dev; + void __iomem *base; + void __iomem *page1; + +#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) +#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) +#define ARM_SMMU_FEAT_TT_LE (1 << 2) +#define ARM_SMMU_FEAT_TT_BE (1 << 3) +#define ARM_SMMU_FEAT_PRI (1 << 4) +#define ARM_SMMU_FEAT_ATS (1 << 5) +#define ARM_SMMU_FEAT_SEV (1 << 6) +#define ARM_SMMU_FEAT_MSI (1 << 7) +#define ARM_SMMU_FEAT_COHERENCY (1 << 8) +#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) +#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) +#define ARM_SMMU_FEAT_STALLS (1 << 11) +#define ARM_SMMU_FEAT_HYP (1 << 12) +#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) +#define ARM_SMMU_FEAT_VAX (1 << 14) + u32 features; + +#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) +#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) + u32 options; + + struct arm_smmu_cmdq cmdq; + struct arm_smmu_evtq evtq; + struct arm_smmu_priq priq; + + int gerr_irq; + int combined_irq; + u32 sync_nr; + u8 prev_cmd_opcode; + + unsigned long ias; /* IPA */ + unsigned long oas; /* PA */ + unsigned long pgsize_bitmap; + +#define ARM_SMMU_MAX_VMIDS (1 << 16) + unsigned int vmid_bits; + DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); + + unsigned int sid_bits; + + struct arm_smmu_strtab_cfg strtab_cfg; + + /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ + union { + u32 sync_count; + u64 padding; + }; + + /* Need to keep a list of SMMU devices */ + struct list_head devices; + + /* Tasklets for handling evts/faults and pci page request IRQs*/ + struct tasklet evtq_irq_tasklet; + struct tasklet priq_irq_tasklet; + struct tasklet combined_irq_tasklet; +}; + +/* SMMU private data for each master */ +struct arm_smmu_master { + struct arm_smmu_device *smmu; + struct device *dev; + struct arm_smmu_domain *domain; + struct list_head domain_head; + u32 *sids; + unsigned int num_sids; + bool ats_enabled; +}; + +struct arm_smmu_domain { + struct arm_smmu_device *smmu; + struct mutex init_mutex; /* Protects smmu pointer */ + + bool non_strict; + atomic_t nr_ats_masters; + + enum arm_smmu_domain_stage stage; + struct arm_smmu_s2_cfg s2_cfg; + + /* Xen domain associated with this SMMU domain */ + struct domain *d; + + struct iommu_domain domain; + + struct list_head devices; + spinlock_t devices_lock; +}; + +#endif /* _ARM_SMMU_V3_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:39:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:39:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399007.640045 (Exim 4.92) (envelope-from ) id 1oVF7l-0004KN-U7; Mon, 05 Sep 2022 16:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399007.640045; Mon, 05 Sep 2022 16:39:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF7l-0004KG-QU; Mon, 05 Sep 2022 16:39:01 +0000 Received: by outflank-mailman (input) for mailman id 399007; Mon, 05 Sep 2022 16:39:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF1w-0007PM-KH for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:33:00 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6745c000-2d38-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:32:59 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F067139F; Mon, 5 Sep 2022 09:33:05 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C7F753F534; Mon, 5 Sep 2022 09:32:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6745c000-2d38-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Robin Murphy , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v3 05/10] xen/arm: smmuv3: Remove the page 1 fixup Date: Mon, 5 Sep 2022 17:30:40 +0100 Message-Id: <6a8cb40d46ab3e688df1f037e4fdacdcd98e3c6a.1662394710.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Robin Murphy Backport Linux commit 86d2d9214880. This is the clean backport without any changes. Since we now keep track of page 1 via a separate pointer that already encapsulates aliasing to page 0 as necessary, we can remove the clunky fixup routine and simply use the relevant bases directly. The current architecture spec (IHI0070D.a) defines SMMU_{EVENTQ,PRIQ}_{PROD,CONS} as offsets relative to page 1, so the cleanup represents a little bit of convergence as well as just lines of code saved. Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 86d2d9214880 Signed-off-by: Rahul Singh --- Changes in v3: - fix "q->cons_reg = page + cons_off" Changes in v2: - fix commit msg. --- xen/drivers/passthrough/arm/smmu-v3.c | 42 ++++++++++----------------- xen/drivers/passthrough/arm/smmu-v3.h | 8 ++--- 2 files changed, 20 insertions(+), 30 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index e65b226b85..272adebb0b 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -238,15 +238,6 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { { 0, NULL}, }; -static inline void __iomem *arm_smmu_page1_fixup(unsigned long offset, - struct arm_smmu_device *smmu) -{ - if (offset > SZ_64K) - return smmu->page1 + offset - SZ_64K; - - return smmu->base + offset; -} - static struct arm_smmu_domain *to_smmu_domain(struct iommu_domain *dom) { return container_of(dom, struct arm_smmu_domain, domain); @@ -1581,6 +1572,7 @@ static int arm_smmu_dt_xlate(struct device *dev, /* Probing and initialisation functions */ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, struct arm_smmu_queue *q, + void __iomem *page, unsigned long prod_off, unsigned long cons_off, size_t dwords, const char *name) @@ -1609,8 +1601,8 @@ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, 1 << q->llq.max_n_shift, name); } - q->prod_reg = arm_smmu_page1_fixup(prod_off, smmu); - q->cons_reg = arm_smmu_page1_fixup(cons_off, smmu); + q->prod_reg = page + prod_off; + q->cons_reg = page + cons_off; q->ent_dwords = dwords; q->q_base = Q_BASE_RWA; @@ -1627,16 +1619,16 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) /* cmdq */ spin_lock_init(&smmu->cmdq.lock); - ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, ARM_SMMU_CMDQ_PROD, - ARM_SMMU_CMDQ_CONS, CMDQ_ENT_DWORDS, - "cmdq"); + ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, smmu->base, + ARM_SMMU_CMDQ_PROD, ARM_SMMU_CMDQ_CONS, + CMDQ_ENT_DWORDS, "cmdq"); if (ret) return ret; /* evtq */ - ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, ARM_SMMU_EVTQ_PROD, - ARM_SMMU_EVTQ_CONS, EVTQ_ENT_DWORDS, - "evtq"); + ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, smmu->page1, + ARM_SMMU_EVTQ_PROD, ARM_SMMU_EVTQ_CONS, + EVTQ_ENT_DWORDS, "evtq"); if (ret) return ret; @@ -1644,9 +1636,9 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) if (!(smmu->features & ARM_SMMU_FEAT_PRI)) return 0; - return arm_smmu_init_one_queue(smmu, &smmu->priq.q, ARM_SMMU_PRIQ_PROD, - ARM_SMMU_PRIQ_CONS, PRIQ_ENT_DWORDS, - "priq"); + return arm_smmu_init_one_queue(smmu, &smmu->priq.q, smmu->page1, + ARM_SMMU_PRIQ_PROD, ARM_SMMU_PRIQ_CONS, + PRIQ_ENT_DWORDS, "priq"); } static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) @@ -2090,10 +2082,8 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) /* Event queue */ writeq_relaxed(smmu->evtq.q.q_base, smmu->base + ARM_SMMU_EVTQ_BASE); - writel_relaxed(smmu->evtq.q.llq.prod, - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_PROD, smmu)); - writel_relaxed(smmu->evtq.q.llq.cons, - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_CONS, smmu)); + writel_relaxed(smmu->evtq.q.llq.prod, smmu->page1 + ARM_SMMU_EVTQ_PROD); + writel_relaxed(smmu->evtq.q.llq.cons, smmu->page1 + ARM_SMMU_EVTQ_CONS); enables |= CR0_EVTQEN; ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, @@ -2108,9 +2098,9 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) writeq_relaxed(smmu->priq.q.q_base, smmu->base + ARM_SMMU_PRIQ_BASE); writel_relaxed(smmu->priq.q.llq.prod, - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_PROD, smmu)); + smmu->page1 + ARM_SMMU_PRIQ_PROD); writel_relaxed(smmu->priq.q.llq.cons, - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_CONS, smmu)); + smmu->page1 + ARM_SMMU_PRIQ_CONS); enables |= CR0_PRIQEN; ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h index c45d2f16c4..0742bc393f 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.h +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -130,15 +130,15 @@ #define ARM_SMMU_CMDQ_CONS 0x9c #define ARM_SMMU_EVTQ_BASE 0xa0 -#define ARM_SMMU_EVTQ_PROD 0x100a8 -#define ARM_SMMU_EVTQ_CONS 0x100ac +#define ARM_SMMU_EVTQ_PROD 0xa8 +#define ARM_SMMU_EVTQ_CONS 0xac #define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 #define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 #define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc #define ARM_SMMU_PRIQ_BASE 0xc0 -#define ARM_SMMU_PRIQ_PROD 0x100c8 -#define ARM_SMMU_PRIQ_CONS 0x100cc +#define ARM_SMMU_PRIQ_PROD 0xc8 +#define ARM_SMMU_PRIQ_CONS 0xcc #define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 #define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 #define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:39:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:39:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399016.640067 (Exim 4.92) (envelope-from ) id 1oVF7o-0004v4-T5; Mon, 05 Sep 2022 16:39:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399016.640067; Mon, 05 Sep 2022 16:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF7o-0004ur-PU; Mon, 05 Sep 2022 16:39:04 +0000 Received: by outflank-mailman (input) for mailman id 399016; Mon, 05 Sep 2022 16:39:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF2J-0007PM-Gj for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:33:23 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7520eda7-2d38-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:33:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DB75139F; Mon, 5 Sep 2022 09:33:28 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 317663F534; Mon, 5 Sep 2022 09:33:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7520eda7-2d38-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zenghui Yu , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v3 06/10] xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Date: Mon, 5 Sep 2022 17:30:41 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zenghui Yu Backport Linux commit e0bb4b735404. This is the clean backport without any changes. Per SMMUv3 spec, there is no Size and Addr field in the PREFETCH_CONFIG command and they're not used by the driver. Remove them. We can add them back if we're going to use PREFETCH_ADDR in the future. Signed-off-by: Zenghui Yu Link: https://lore.kernel.org/r/20210407084448.1838-1-yuzenghui@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e0bb4b735404 Acked-by: Stefano Stabellini Signed-off-by: Rahul Singh --- Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- --- xen/drivers/passthrough/arm/smmu-v3.c | 2 -- xen/drivers/passthrough/arm/smmu-v3.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 272adebb0b..512a3617a2 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -405,8 +405,6 @@ static int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) break; case CMDQ_OP_PREFETCH_CFG: cmd[0] |= FIELD_PREP(CMDQ_PREFETCH_0_SID, ent->prefetch.sid); - cmd[1] |= FIELD_PREP(CMDQ_PREFETCH_1_SIZE, ent->prefetch.size); - cmd[1] |= ent->prefetch.addr & CMDQ_PREFETCH_1_ADDR_MASK; break; case CMDQ_OP_CFGI_STE: cmd[0] |= FIELD_PREP(CMDQ_CFGI_0_SID, ent->cfgi.sid); diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h index 0742bc393f..b381ad3738 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.h +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -456,8 +456,6 @@ struct arm_smmu_cmdq_ent { #define CMDQ_OP_PREFETCH_CFG 0x1 struct { u32 sid; - u8 size; - u64 addr; } prefetch; #define CMDQ_OP_CFGI_STE 0x3 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:40:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:40:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399042.640077 (Exim 4.92) (envelope-from ) id 1oVF9C-0006ud-89; Mon, 05 Sep 2022 16:40:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399042.640077; Mon, 05 Sep 2022 16:40:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF9C-0006uW-5U; Mon, 05 Sep 2022 16:40:30 +0000 Received: by outflank-mailman (input) for mailman id 399042; Mon, 05 Sep 2022 16:40:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF9B-0006uP-4E for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:40:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVF9A-0006Jt-Rm; Mon, 05 Sep 2022 16:40:28 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVF9A-0008Nf-Ly; Mon, 05 Sep 2022 16:40:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TE7m6aGewoSAgxWuzTVhscDrS+uZQg9ihL2LZLx33V4=; b=tP0muAvZNWqIS1R6PbuwRmuazJ BI84Oolnb9prqXmTGktZcU/rFdMgyMKXObsCOcMVKtL7HGyJTKBTfkQKvfQpgbOmauERlyy0q0oa8 dSlAgQzdeGelCM86r7WBgA9GMlTthXD1xPunN+0Hv+ssUz2/fxs1ide5HegUAXXL5v3M=; Message-ID: <771e2800-4457-b9f4-63bf-a71f3805e4ea@xen.org> Date: Mon, 5 Sep 2022 17:40:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Content-Language: en-US To: Rahul Singh , Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 05/09/2022 14:36, Rahul Singh wrote: > Please have a look once if this looks okay. > > /* > * List of possible features for dom0less domUs > * > * DOM0LESS_ENHANCED_BASIC: Notify the OS it is running on top of Xen. All the > * default features (excluding Xenstore) will be > * available. Note that an OS *must* not rely on the > * availability of Xen features if this is not set. > * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > * can't be enabled without the DOM0LESS_ENHANCED_BASIC. > * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > * default features (including Xenstore) will be > * available. Note that an OS *must* not rely on the > * availability of Xen features if this is not set. > */ > #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) > #define DOM0LESS_XENSTORE BIT(1, UL) > #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE) The explanation looks good to me but the indentation looks odd. Also, I think it would be preferable to use U or ULL (if you want 64 bits) so the size of the bitfield is not arch depending. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:50:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:50:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399058.640088 (Exim 4.92) (envelope-from ) id 1oVFIX-0008WC-42; Mon, 05 Sep 2022 16:50:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399058.640088; Mon, 05 Sep 2022 16:50:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFIX-0008W5-1M; Mon, 05 Sep 2022 16:50:09 +0000 Received: by outflank-mailman (input) for mailman id 399058; Mon, 05 Sep 2022 16:50:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFIV-0008Vz-1N for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:50:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60042.outbound.protection.outlook.com [40.107.6.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca7f0992-2d3a-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:50:05 +0200 (CEST) Received: from AM0PR06CA0089.eurprd06.prod.outlook.com (2603:10a6:208:fa::30) by DB9PR08MB8268.eurprd08.prod.outlook.com (2603:10a6:10:3c4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Mon, 5 Sep 2022 16:50:00 +0000 Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:fa:cafe::c5) by AM0PR06CA0089.outlook.office365.com (2603:10a6:208:fa::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 16:50:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 16:49:59 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Mon, 05 Sep 2022 16:49:58 +0000 Received: from 13030c8d0800.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 336275C0-539B-4292-AC8F-EC1EA1770CC2.1; Mon, 05 Sep 2022 16:49:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 13030c8d0800.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 16:49:52 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AS8PR08MB6614.eurprd08.prod.outlook.com (2603:10a6:20b:338::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 16:49:51 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 16:49:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca7f0992-2d3a-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ns16w31PCAYT3J3bG8/NiIcq/INHb3WF9w9IiXHq4DcUeqkFOlM05QnfZsnsWEOo+zgW+U3Tn06zQxfvXAhihe0a91HUd8pDIpSl+4jD2hiXMeeGrQOpg3WVCLSO3V8xpv5epT/heNNQ4VPV3Nl6DmfayCqw1tm9dcRb9C/ptu8OCuNV6jBgIdJwaIp327zRabIclAWeNRPA7SyRIvi5LzCpQEXGCS2Gu4EqNM9YYQTDdw5tRRk6kOyXhD/+fq9CEOKpr1UQsc6opomz8VoARzsId4QPqKzIGJHUmGhX+p//mzI6PFZ4WHu7uJt1cIDSaMhHDe6i861ac3j+mdojsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=astuJcRJ4TaYXeCiH+Cc4vRFAdkcIwqCPz+W13vNrrI=; b=msdKuoGKKlmHak9ZD3AOC4G7tcyVD7f8s/y5aAv5O36ttdwWzyCUzE+g8+fC6lBmTvfUgez+NUdTx3P2TPzaNUzZ/6st8AHvTMMJM2gDIBqj+PaNpo/NRGncWegotRR19sFXg05rnyxHzfr18JOyqAfJwNHGR1WMxGBrDfMbnWmynjv9csPCi9skz9QvsHvqmG57XHKIjf8TEP/I3QG864I9M+BLcsgIcSQIRKLE92aN1IR1/usxm0jmo/XimsSwnjvaQdIFTQsGpB9d3zdw39VbJzCw8XYEUK15mj7W2hnvNSRgLOSibI6gO4Wb/vFAimlbSUVoFAiwuEb3fcwvxw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=astuJcRJ4TaYXeCiH+Cc4vRFAdkcIwqCPz+W13vNrrI=; b=5e1U84I6iKp8aegkf7++VbC+b7Bub1gtIn4rT3O1eHcd/jzgJN/wll910AahqJ7w9HoFD1Co7/DwgmiX2awMYbkKyaolq860OlJmZ6NVvcz+KyqmXiF3klC0109QYxoCJ5gopYx9FB7+yRS71iwXhNCGJQId5m4JrEiRkdjU+EE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e39834c7f27cb9d1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzrCKBZY/9MBrce+2vLzeXClEjmqas4TAk+MroyGjEgfnfTz5fCQ8/ysqa2RgR7jmvP+iOmI+TY6zZue6sBcZC5Ty7ZhwrM6k51DLJpGvJJZJ67qmZU7QxsJFo7xlkMjz5HWMt3GNm36Gl7X6Tk2Vswy1IvNHdGGn+gciUJ08eZgQLf2YvSM0BqZGxxfsQi9Z3Fn5PxNmGzSPAJC/d0Ln3YKPXBiuzD6723Yv2jVE6S1dpjBo3sWLFyAH+3hX5AbKMOFnTawyYPd6CZYO9dp37HcRNhnBsSJeriy0RGiq+6H+L/imll+aoTSdQ5nUsUmyyz6iRpRbG6ibd1rgArHZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=astuJcRJ4TaYXeCiH+Cc4vRFAdkcIwqCPz+W13vNrrI=; b=DNf0pI3JkAzUAC2xanO2n4LCCruLIiX78qeAmkZONjj5n1/ftlVz+9LNgpIvt9jdp62AtHOOAo26sJugPFewXfmdE1iXtzQjBZfL+u9rC+99RNv7uSIV0aL1ZjTydhQ5fMf1k8itRq+nD0IYLBiJYRaGwtGtx4xgok3UoRCOLzWBvgGuyMHpGN/jMAXB8P+PCQxDzl/sWNv1FeTsR4O8HRpd0gxEg2J+G+BtwVUmaFvngxU/AmvVGpu4Hdx+SGRz4uGU2pDeJBZRWjd8OZkgYW1nHmGSmv9wrUzuN1MzY99B2JfSuJ1q9SazTK8CSqMYU+p459Z1l4FPj1EOlcBq3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=astuJcRJ4TaYXeCiH+Cc4vRFAdkcIwqCPz+W13vNrrI=; b=5e1U84I6iKp8aegkf7++VbC+b7Bub1gtIn4rT3O1eHcd/jzgJN/wll910AahqJ7w9HoFD1Co7/DwgmiX2awMYbkKyaolq860OlJmZ6NVvcz+KyqmXiF3klC0109QYxoCJ5gopYx9FB7+yRS71iwXhNCGJQId5m4JrEiRkdjU+EE= From: Rahul Singh To: Julien Grall CC: xen-devel , Zhou Wang , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Topic: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Index: AQHYwUUf4E2j4BiT+ESEZERmzSI0nK3RCQUAgAADdQA= Date: Mon, 5 Sep 2022 16:49:50 +0000 Message-ID: <41229BFA-D9F9-442D-92D2-67354897B5EA@arm.com> References: <885a4f6b-8350-229d-55da-4171eeafb800@xen.org> In-Reply-To: <885a4f6b-8350-229d-55da-4171eeafb800@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 723b1b4f-f43b-4970-5d1d-08da8f5eab84 x-ms-traffictypediagnostic: AS8PR08MB6614:EE_|VE1EUR03FT014:EE_|DB9PR08MB8268:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5i7S+4pDMZNmPE07QpL1lhvJ3PaxIw7qamW8uj0OOK8QbvnbSojFTKWsPGQ6kcyCX2yTwGVnNKapKTBqE0xTUaiti7res/WHcAXlVISTwdVVBJIqsiZGK1fn/plmovC+aQnbhtFHbjO23hJ9NS0YcyQ4vIpdp+M0tu41HlbVjsechLjj5jiXYBx/3jgXfbcaE3nRPP08qbXXNtsiVjyuIeUR3pGib70XGfDOgp6RUVfiQT5DVoks2btCIKaIW4tBWNGcPU8ZNrq1t7dijzZstM84fk4lM2QhD42HfBUo2FKNKrGKg+Qkqz3sIg17VMZKP9FD4wM2o4HlYYJK+dolaeolWU+ECdMelNlvo1U47DRk4UTrnLLnWErstXQGim6y8eM322JYgPdxMBr0gC4iHFVFfRY5RUW0o+TsfQAV0fytWc6kgXecDxlEKzV9FyNSbDnyGOQ4MRHa3ix5aIxCn1yte79vzvNpp/kOyJESgi+xqgkuwXSzSihQlH4MvH8EGpiockd/PHdGwdU2/3A2RZ0uZ/nIF8eVx2pTQZmGu9HjO0J2ThsMK2LenEOZVah9e1qMS4HFTF60+8VOjU56N5grJGB/qsTyLt7MnGf/+cQIcII4YsUlRXFDZeg3gcY1OQCkY7r3jy7/ndzttkbXRGRqzkgPnRaFD2O06HTIO+jQzmsoeVp/HYfMts1GHUIKvvIVV8v+CENaI2I7BXP/zoSyvJpmgl5LdPSECvdelDd7i0pUmriCzQl62N2uhdGUVvKoxnSQfboX/MfJG9t73o7uqFeve9y5haHL5S4xFyZGyhSCHtGXiWKiWLvFD72QI2JC3elxPBjECDLBYC3XvQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(64756008)(66556008)(8676002)(4326008)(33656002)(66446008)(76116006)(91956017)(66946007)(8936002)(5660300002)(6506007)(83380400001)(26005)(53546011)(478600001)(6486002)(966005)(71200400001)(41300700001)(186003)(2616005)(86362001)(316002)(6916009)(54906003)(36756003)(66476007)(2906002)(38100700002)(6512007)(38070700005)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <91DAE0AFFC2E254588F8EBA884F06B3B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6614 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 445acbed-ffaa-4ef5-0be0-08da8f5ea681 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vxTUsy7dDLgFv1zWpPU+djoGllrjv7glDgdi7bYSkPtRzjcAZ5gw7pxHfNJad5IRkKc7/S8iMeTU/BzP7SXO6IO0oZA9dG80VnHbzlESJyH2TwBmx9ko0Cj2RuvJ1UFiIPSGWna2t8nf9VZK69TpKHwCRr0cSGUmn9fASj9JDpjFwMSb5f7vsY3Kh/OnhiYnoaVixCTP3TJ+HAth+MZ0dAV57+gFvE+fqWrjCgvSkqDOi9/nTvQJjjGphDHUrKeqWbxNVsRiW+hDv03r+hrWwdghZ6FTar4758JssVntqP8P2UrJrAzDwx8qK95aDwPjiyyeaGD/e645g4Sy9bmGXxnuD8l69mukpN7hnBkvwh4NvZ+qsGHxaybJrBQCnU1UXOWyD4M4gBDxpGl+EYFY0zib0rRHXwyOcPMFDwfMLJFFloCOHU8lAsifLCu+lBOAN/0fuVyG/1VpL8jk2DzunzkZY/do8vqUW17bGFh8bfjxA2KUNsAdjWD0Y4rBBbR4612hMWMDKnDXYOo7ln348iVyz7EDTuNOZ9PKnWh8vx2J7Emj5LX+mr5vsemlH2rqAHGsW9g4hraPAVGqNTjpnAdm2bEQ26iWeq2njtB+20pQR8q/jwF6c724Ee/aUXrtR6tMCv6eXnBwBPTnSqNqJQ3VhnbtAlXl9JC8wfAbNeA1pwugZF73Cm8GLdsCq0uaaR7OINiml6ExcrEBCC9UVeaRF9ixH6Zy69tckJus0YzmTnlORHqcePlN8wJkcs2QzCGTRsBMSb4jSzIMbGxtaOGsM+kTdbYm09VqGLXw1i0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(39860400002)(36840700001)(40470700004)(46966006)(6512007)(6486002)(82310400005)(53546011)(4326008)(2906002)(5660300002)(36860700001)(26005)(6506007)(316002)(47076005)(40460700003)(356005)(966005)(8936002)(33656002)(6862004)(478600001)(86362001)(81166007)(41300700001)(186003)(107886003)(336012)(2616005)(40480700001)(83380400001)(70586007)(82740400003)(54906003)(36756003)(70206006)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 16:49:59.2372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 723b1b4f-f43b-4970-5d1d-08da8f5eab84 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8268 SGkgSnVsaWVuLA0KDQo+IE9uIDUgU2VwIDIwMjIsIGF0IDU6MzcgcG0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNS8wOS8yMDIyIDE3OjMw LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEZyb206IFpob3UgV2FuZyA8d2FuZ3pob3UxQGhpc2ls aWNvbi5jb20+DQo+PiBCYWNrcG9ydCBMaW51eCBjb21taXQgYTc2YTM3Nzc3ZjJjLiBSZW5hbWUg X19pb21iIHRvIGlvbWIoKSB3aGlsZQ0KPj4gbWVyZ2luZyB0byBnZXQgaW4gc3luYyB3aXRoIG90 aGVyIFhlbiBkZWZpbml0aW9ucy4NCj4+IFJlYWRpbmcgdGhlICdwcm9kJyBNTUlPIHJlZ2lzdGVy IGluIG9yZGVyIHRvIGRldGVybWluZSB3aGV0aGVyIG9yDQo+PiBub3QgdGhlcmUgaXMgdmFsaWQg ZGF0YSBiZXlvbmQgJ2NvbnMnIGZvciBhIGdpdmVuIHF1ZXVlIGRvZXMgbm90DQo+PiBwcm92aWRl IHN1ZmZpY2llbnQgZGVwZW5kZW5jeSBvcmRlcmluZywgYXMgdGhlIHJlc3VsdGluZyBhY2Nlc3Mg aXMNCj4+IGFkZHJlc3MgZGVwZW5kZW50IG9ubHkgb24gJ2NvbnMnIGFuZCBjYW4gdGhlcmVmb3Jl IGJlIHNwZWN1bGF0ZWQNCj4+IGFoZWFkIG9mIHRpbWUsIHBvdGVudGlhbGx5IGFsbG93aW5nIHN0 YWxlIGRhdGEgdG8gYmUgcmVhZCBieSB0aGUNCj4+IENQVS4NCj4+IFVzZSByZWFkbCgpIGluc3Rl YWQgb2YgcmVhZGxfcmVsYXhlZCgpIHdoZW4gdXBkYXRpbmcgdGhlIHNoYWRvdyBjb3B5DQo+PiBv ZiB0aGUgJ3Byb2QnIHBvaW50ZXIsIHNvIHRoYXQgYWxsIHNwZWN1bGF0ZWQgbWVtb3J5IHJlYWRz IGZyb20gdGhlDQo+PiBjb3JyZXNwb25kaW5nIHF1ZXVlIGNhbiBvY2N1ciBvbmx5IGZyb20gdmFs aWQgc2xvdHMuDQo+PiBTaWduZWQtb2ZmLWJ5OiBaaG91IFdhbmcgPHdhbmd6aG91MUBoaXNpbGlj b24uY29tPg0KPj4gTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8xNjAxMjgxOTIyLTEx NzI5Ni0xLWdpdC1zZW5kLWVtYWlsLXdhbmd6aG91MUBoaXNpbGljb24uY29tDQo+PiBbd2lsbDog VXNlIHJlYWRsKCkgaW5zdGVhZCBvZiBleHBsaWNpdCBiYXJyaWVyLiBVcGRhdGUgJ2NvbnMnIHNp ZGUgdG8gbWF0Y2guXQ0KPj4gU2lnbmVkLW9mZi1ieTogV2lsbCBEZWFjb24gPHdpbGxAa2VybmVs Lm9yZz4NCj4+IE9yaWdpbjogZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJu ZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdCBhNzZhMzc3NzdmMmMNCj4+IFNpZ25lZC1vZmYtYnk6 IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4gLS0tDQo+PiBDaGFuZ2VzIGlu IHYzOg0KPj4gIC0gcmVuYW1lIF9faW9tYigpIHRvIGlvbWIoKSBhbmQgYWxzbyBtb3ZlIGl0IGZy b20gY29tbW9uIGZpbGUgdG8NCj4+ICAgIHNtbXUtdjMuYyBmaWxlDQo+IA0KPiBIbW1tLi4uIFF1 b3RpbmcgQmVydHJhbmQ6DQo+IA0KPiAiV2UgbmVlZCB0aGUgX19pb21iIGFzIOKAnGxpbnV4IGNv bXBhdGliaWxpdHnigJ0gaW4gZmFjdCBzbyBJIHdvdWxkIHN1Z2dlc3QgZm9yIG5vdyB0byBvbmx5 IGludHJvZHVjZSBpdCBhdCB0aGUgYmVnaW5uaW5nIG9mIHNtbXUtdjMuYyB3aXRoIG90aGVyIGxp bnV4IGNvbXBhdGliaWxpdHkgc3R1ZmYgdG8gcHJldmVudCBhZGRpbmcgdGhpcyB0byBYZW4gb3Zl cmFsbC4iDQo+IA0KPiBXaGljaCBJIGFsc28gYWdyZWVkLiBJIGNvdWxkbid0IGEgbW9yZSByZWNl bnQgY29udmVyc2F0aW9uIGV4cGxhaW5pbmcgeW91ciBhcHByb2FjaC4gQ2FuIHlvdSBvdXRsaW5l IHdoeSB5b3UgZGlkbid0IGZvbGxvdyB0aGUgYXBwcm9hY2hlZCBkaXNjdXNzZWQ/DQo+ICAgDQoN CkkgYW0gcmVhbGx5IHNvcnJ5IHRoYXQgSSBtaXNzZWQgdGhlIG5hbWluZyBhbmQgd2hlbiBJIG1h ZGUgdGhlIHBhdGNoIGluIG15IG1pbmQgdGhlcmUgd2FzIGEgY29tbWVudCBmcm9tIFN0ZWZhbm8g dG8NCnJlbmFtZSB0aGUgX19pb21iKCkgdG8gaW9tYigpLiBJIHdpbGwgc2VuZCBvbmx5IHRoaXMg cGF0Y2ggYWZ0ZXIgZml4aW5nIG9yIGRvIHlvdSB3YW50IG1lIHRvIHNlbmQgdGhlIHdob2xlIHNl cmllcz8NCg0KUmVnYXJkcywNClJhaHVs From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:51:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399065.640099 (Exim 4.92) (envelope-from ) id 1oVFKF-0000f2-GD; Mon, 05 Sep 2022 16:51:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399065.640099; Mon, 05 Sep 2022 16:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFKF-0000ev-DQ; Mon, 05 Sep 2022 16:51:55 +0000 Received: by outflank-mailman (input) for mailman id 399065; Mon, 05 Sep 2022 16:51:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFKE-0000en-49 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:51:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ad22bb1-2d3b-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 18:51:53 +0200 (CEST) Received: from AS9PR06CA0648.eurprd06.prod.outlook.com (2603:10a6:20b:46f::16) by DBBPR08MB6300.eurprd08.prod.outlook.com (2603:10a6:10:209::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 16:51:39 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46f:cafe::fd) by AS9PR06CA0648.outlook.office365.com (2603:10a6:20b:46f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 16:51:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 16:51:38 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 05 Sep 2022 16:51:38 +0000 Received: from 01e22cc94631.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F80B1DA0-BF8A-42B8-8D47-9EE41A85F81E.1; Mon, 05 Sep 2022 16:51:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 01e22cc94631.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Sep 2022 16:51:27 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by PAXPR08MB6416.eurprd08.prod.outlook.com (2603:10a6:102:152::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 16:51:25 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 16:51:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad22bb1-2d3b-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dIjjKstNPTJEcQ8sY61Gr5hzPeEkAXaADi1ZpajI25yBuMPJIX3iUIN2du/GyyvmkwBBISMiKLaKCRPQnnpAovR1BudQGZutwPtVAHsYWR6Jot2vej7WK0/j9SJYzs8PnsrHJWEL5xldJ3ZPewbAy/U0Rbx6Ms9M4mGnTJKzJbotmidHsbh1fjs7aqMPG+qixH5251gihF+qFyIyz/mYRMK56j8w7oZHYBtE05FYCYPFCZP67KOhiZyTSrjQ70dD0U/z76FYsMK/1LC+DB1oYzX+MDAZNrMucUCmJjP1vWEttdfvg9DBM6corz7Se9QLjZBubUfABpzR7Rni9lwllQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsgTKyBbntCDVmvDXzWwWDFlH7xshsqNUPBaVZnVGbE=; b=GbPxE2Fp41hXuwQhstMgO9e6NQhZpRHM4GN/UeaUNN8ERvZt4lFNce5a7022NtYC3gxcuyrNwsSxhKqGYYszK82RCSGRqmvDOf6kT/I0kzkSWUNRrP1DqbVpmkC/YQMHUUc3OxscpEC8v2GVwE73Z8r5/F1R/6NagBXEESBFMjh+J/p3HwEe1mhpPjDzD7a2Twm9eVKG6R8TL6d99tikENdBd8f0In1+raBDUUpL2Lnsa8Sns67Royx92/wLjCpEsvEt4QjgB9vi19byp/yGVloIzIjXN7JJ2Wc04UBfRPEfXzRHhTKQWoWDfA+T4EkItDOXamSWzKl+XMeYPOyzHA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsgTKyBbntCDVmvDXzWwWDFlH7xshsqNUPBaVZnVGbE=; b=PI6TAQuKp1HMUSnDQbLYk84a0qRaZD95I83HHkbvUuKNZeeMQhjEe0raFKEq4sOWuGPAxSlIyUUjtcmNW3uM+o6euUI2w/k32JGC7kiwlwVK1doPBW2JkL6WkyXMefa+tFhqM/4Lzez8R6RNTRto8mVLqUKg1wcn5FwG3Mzgz7Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e46ea9cb08125ffe X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iEhTFL6T1pr6UYCA15zeJv9d++22iF/5VbSbNttjW8KVsDqkyORwgc24Bymu+WtKBvuQHn9wEVgbi2Z8DGx2yg7Vzv2NWJaB0vTRQ+v1EbrqKgu9xv32qhMhykuCvtVsrF5RbPJ59xROLanP976zBAxAOO+GIZ1OVW4B8kY9qG340S9MX7D9U9M3e4Sqa1Lv9mfXVwtoP2nU1/cCrnQaEL9SWXhMUnzDHySsAeGnjFDVgSWGe2YtRplRDVE7eUO18nYQRoaSrsSEHkiWbliOe7vu7CerGVSUOIfyLUEcDGHCyuon5aIrbmyik8MIXcNHhi4a7ASLze9fBUuCdiJKjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsgTKyBbntCDVmvDXzWwWDFlH7xshsqNUPBaVZnVGbE=; b=ban6PjwAXR+NVfWlTlmBd/PI4DxuoqLEfOw8JRjbb3bF6bmTfQq6j5qTQbN+iapclq+/Ncc/qy19MYap1pE8OkfzLQWeToRHpfquqwfgaVcKRwtqzc0RWUNI+xJ1PIVDwM8XiO8ZOridlzgqyt+BLeJE/F87SZQAW5elyq9MyX/km2pBf+NJvF1663otzRWVAfr8K7yBKU8bgKoSPhbP3huLBa236YP965C55gWmw1D87H5UlRbWMLc0phO+R1xu/w21WAH2yVdpVQLdmi/dO+OSGhaGW7KnV/DLEeHWBPcG9oKnyu+c9r+vLrdR4lp+YePk5Ssd1nlzoXCTWxnd2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsgTKyBbntCDVmvDXzWwWDFlH7xshsqNUPBaVZnVGbE=; b=PI6TAQuKp1HMUSnDQbLYk84a0qRaZD95I83HHkbvUuKNZeeMQhjEe0raFKEq4sOWuGPAxSlIyUUjtcmNW3uM+o6euUI2w/k32JGC7kiwlwVK1doPBW2JkL6WkyXMefa+tFhqM/4Lzez8R6RNTRto8mVLqUKg1wcn5FwG3Mzgz7Q= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFZKoCAAAQmAIAADY6AgAAHOICABGESgIAACJcAgAADEwCAAAPEgIAADnWAgAAKUACAADNYAIAAAxEA Date: Mon, 5 Sep 2022 16:51:25 +0000 Message-ID: <07A77C93-A304-47ED-B3E7-58F87A959CDB@arm.com> References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> <771e2800-4457-b9f4-63bf-a71f3805e4ea@xen.org> In-Reply-To: <771e2800-4457-b9f4-63bf-a71f3805e4ea@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 18650fb3-07db-445b-9a3e-08da8f5ee6db x-ms-traffictypediagnostic: PAXPR08MB6416:EE_|VE1EUR03FT003:EE_|DBBPR08MB6300:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: p+9BBzoLbqFTPrIZyJnP2du4sR3jYGO7J+6jrAwJAbwj5j5EuKSoUDBY6jPfVr8yR8hSwX62MS3/QG4MCekgLNglhCvzAAxpzp51RRLVQ07tMfTCAABNg51k0lBTM5/ghBLsEShYXZ0in46vSfQjYx90t8soWT2xSEay08tGUVG2T3FrYSPanHxISQjYU5I9ZW6DdKoZxTPIEbOfvNhYZm6KlSFcREIOEgJHf/RbH48496Wkm6iGUzM4XiW3iVomp0mIA2XE88JNC+VaDULugj2eSiwOAWyE8Ybi8jUCy/OWvZwu4ffNzYg53bqcKbkdC/GUbCxi4f/sJGApeC1DyCtlVlIw9y1eA72WmpiZuMqmarmv6MKwqEz0xKQerfKfwV0ZZHQGeo7fR0NP3zeF2sIzALx/jTxXB+I92bOEsgZnwQaCGYspQ3dEJLCbBcmyRuu/PM4/TPe9w2dsYlNMPwYHykJQIZghKQco0DhkxtvReEaVAFPxVs/e4NwUTrwFtvxwVoBGawhugPmnHZ2gWXpzq6YnaQHV4XFZqh7K7E9WFQGFaAxLEovRL+PSR8XsitVWznH3Y2grwtDrdG0BUo5eDmYILikeDZsofmleJfLs8equcHuqz3DXlh1kYibGi52RkKw9FUhm1K+4kuSP3H+uEzeOy6Tm7EDzu+r3STbn/n6sNq0PtZi0p8EzuUELGh2NUQXM55+Y/6QV6c9MirTvyOTN9i0Dp9xQelfjKQccqbH+m+pcU9mlRhOPy+sLFYHTuLKORSmL7WNmqJtcBJZXfssNbO/NsAHlsNujvxc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(366004)(136003)(376002)(91956017)(64756008)(4326008)(8676002)(76116006)(66446008)(66946007)(66556008)(66476007)(5660300002)(316002)(122000001)(38100700002)(38070700005)(6512007)(186003)(26005)(6506007)(478600001)(71200400001)(53546011)(41300700001)(6486002)(6916009)(36756003)(54906003)(33656002)(86362001)(2616005)(8936002)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <75BBABA930518444AA23F484C902594A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6416 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 66ac6cb7-61bc-4d16-48bd-08da8f5edf05 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZV12qNGW86/iwctchLpf7Y/4LgDG2R6KGhtvLGM/sqJ3ZVgbLZHt4r/9h/2wRcMnZujbRTG9Kx8ucJ7ff5A2UURiXF6O7tAxyuPH+LpjA5iACcEoH9b6LHv81GrTguQuMmNt+U4whVj1NwLqGA3NK72h1Sgv1mu7WsM/3oT6f16EUYHhhjRP6KltRLNCgPjdPtR2+FUCLQWkHqehMehxMhMFyVyKSUQ4q8iyklPBMMEEV+DQriWRofn2Nit5onzkt1KLOcQifaeKCKiciuH6TszmO1+/brjhxul7xVralfSICa8csntLEdTx2SraNdhFSjpnnE4IHuVBOJV0t7Byvc/XrTMbVmABCVS+rLKgZzEtrL9J7BNV6nER9anBeD8U2qAsT8V+02hMvnj4d4JgdEriJC2ehgWe0Zgu2f6DEPLRinGQZl+jH2vHr1yoPKmCEuimG6RxfJ5suM8ZcPFnw4YaKst9sTQhf4hUcYBJWgXAEH1jCtSyGiCYNGjqTB+RVbbhfELpsUlead56cjqIg9St0tdb6MO5vDaudbuS6ZI++W78XFuatBtF1JMIdESNouEYVTwbK/4qRkUsgdqPwO0GcXLkE1+GIB5IGyFYhHChgI3dMUiOYf8cD6R7tSam2q1fIzkI77KkmHc090T/ojAB/nHDqQzaD95ClYl22yRBW+GWC2Ij7//meOrlZr4yLGfat+w1eqMlgOAOE1ZnDXuHFhZ0p9EYQv36jE/IOZwIy4lNTg5sSVkETjEolwWB2gqFR6APQmOHp+kOg8UVyQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(46966006)(36840700001)(40470700004)(81166007)(6862004)(8936002)(356005)(54906003)(316002)(33656002)(6486002)(478600001)(40460700003)(70206006)(4326008)(53546011)(70586007)(8676002)(6506007)(47076005)(86362001)(6512007)(2906002)(26005)(186003)(336012)(82310400005)(41300700001)(2616005)(82740400003)(5660300002)(36860700001)(40480700001)(107886003)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 16:51:38.7945 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18650fb3-07db-445b-9a3e-08da8f5ee6db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6300 Hi Julien,=20 > On 5 Sep 2022, at 5:40 pm, Julien Grall wrote: >=20 > Hi, >=20 > On 05/09/2022 14:36, Rahul Singh wrote: >> Please have a look once if this looks okay. >> /* >> * List of possible features for dom0less domUs >> * >> * DOM0LESS_ENHANCED_BASIC: Notify the OS it is running on top of Xen. A= ll the >> * default fea= tures (excluding Xenstore) will be >> * available. Note that an OS *must* not r= ely on the >> * availability of Xen features if this is= not set. >> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This = feature >> * can't be enabled without the DOM0LESS_E= NHANCED_BASIC. >> * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All t= he >> * default features (including Xenstore) w= ill be >> * available. Note that an OS *must* not r= ely on the >> * availability of Xen features if this is= not set. >> */ >> #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) >> #define DOM0LESS_XENSTORE BIT(1, UL) >> #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | D= OM0LESS_XENSTORE) >=20 > The explanation looks good to me but the indentation looks odd. Also, I t= hink it would be preferable to use U or ULL (if you want 64 bits) so the si= ze of the bitfield is not arch depending. >=20 I will fix the indentation when sending the official patch. I will use U as= I am planning to use uint32_t. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Mon Sep 05 16:55:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 16:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399074.640110 (Exim 4.92) (envelope-from ) id 1oVFNo-0001NY-2f; Mon, 05 Sep 2022 16:55:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399074.640110; Mon, 05 Sep 2022 16:55:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFNo-0001NR-05; Mon, 05 Sep 2022 16:55:36 +0000 Received: by outflank-mailman (input) for mailman id 399074; Mon, 05 Sep 2022 16:55:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFNm-0001NL-KA for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 16:55:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFNk-0006ZH-Be; Mon, 05 Sep 2022 16:55:32 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVFNk-0005Vd-4k; Mon, 05 Sep 2022 16:55:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IZIz7nSvvjZV4rHsQN7sIUnHqESWRU4aVKJmtcn/JyI=; b=NICKcLVuwg5ttEjUNb9Jn4ZKI9 bPV3RWb/mLRik239mQ9mpLujDaT6ukHgXPaHA7Zja7BCFWJo3wNNWWGrAdezKXa2b9j1Y/xdB9EdE 87rsSz1F7YraNau5KccWGhoNyoMi88qw4shh8hMUfqTG2oxKjqiEdNSID6TQRTkuvPr4=; Message-ID: <5c0e3697-96cd-c4e5-4de0-a01d4d699c69@xen.org> Date: Mon, 5 Sep 2022 17:55:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Content-Language: en-US To: Rahul Singh Cc: xen-devel , Zhou Wang , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Will Deacon References: <885a4f6b-8350-229d-55da-4171eeafb800@xen.org> <41229BFA-D9F9-442D-92D2-67354897B5EA@arm.com> From: Julien Grall In-Reply-To: <41229BFA-D9F9-442D-92D2-67354897B5EA@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/09/2022 17:49, Rahul Singh wrote: > Hi Julien, Hi Rahul, > >> On 5 Sep 2022, at 5:37 pm, Julien Grall wrote: >> >> >> >> On 05/09/2022 17:30, Rahul Singh wrote: >>> From: Zhou Wang >>> Backport Linux commit a76a37777f2c. Rename __iomb to iomb() while >>> merging to get in sync with other Xen definitions. >>> Reading the 'prod' MMIO register in order to determine whether or >>> not there is valid data beyond 'cons' for a given queue does not >>> provide sufficient dependency ordering, as the resulting access is >>> address dependent only on 'cons' and can therefore be speculated >>> ahead of time, potentially allowing stale data to be read by the >>> CPU. >>> Use readl() instead of readl_relaxed() when updating the shadow copy >>> of the 'prod' pointer, so that all speculated memory reads from the >>> corresponding queue can occur only from valid slots. >>> Signed-off-by: Zhou Wang >>> Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com >>> [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] >>> Signed-off-by: Will Deacon >>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c >>> Signed-off-by: Rahul Singh >>> --- >>> Changes in v3: >>> - rename __iomb() to iomb() and also move it from common file to >>> smmu-v3.c file >> >> Hmmm... Quoting Bertrand: >> >> "We need the __iomb as “linux compatibility” in fact so I would suggest for now to only introduce it at the beginning of smmu-v3.c with other linux compatibility stuff to prevent adding this to Xen overall." >> >> Which I also agreed. I couldn't a more recent conversation explaining your approach. Can you outline why you didn't follow the approached discussed? >> > > I am really sorry that I missed the naming and when I made the patch in my mind there was a comment from Stefano to > rename the __iomb() to iomb(). I will send only this patch after fixing or do you want me to send the whole series? I would be fine if you only resend this patch. Also, looking at the other patches, you added the Acked-by before your Signed-off-by. In general, the tags are ordered chronologically, so this should be inverted. I can deal with that on commit once Bertrand confirmed he is happy with the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 17:21:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 17:21:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399083.640122 (Exim 4.92) (envelope-from ) id 1oVFmO-0004o7-1i; Mon, 05 Sep 2022 17:21:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399083.640122; Mon, 05 Sep 2022 17:21:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFmN-0004o0-Uc; Mon, 05 Sep 2022 17:20:59 +0000 Received: by outflank-mailman (input) for mailman id 399083; Mon, 05 Sep 2022 17:20:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFmM-0004nu-KQ for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 17:20:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFmM-00071o-An; Mon, 05 Sep 2022 17:20:58 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVFmM-0006d9-4k; Mon, 05 Sep 2022 17:20:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CzuIvFi+oO1hqJgHSHob4r417DNR2QtJwnFmftjGd3s=; b=rohPzjhVr34OUwrx5XH/9aeBLH MHmCktI7x03EwgptxpwygIVVJ2deKKiHJ4XKNAr7G618elPgy16WqtxckN+QlHhZpzpO2swbiiV4w jYgBgPWx+hNZpNCzjUq1qMdWWi/fpglk7Ozprlw/uEY2KhrWWD62HIm4UKEUVbPeGqps=; Message-ID: <4d5a9acb-32ae-dc52-61b0-4e35052c7270@xen.org> Date: Mon, 5 Sep 2022 18:20:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220905072635.16294-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 05/09/2022 08:26, Henry Wang wrote: > This commit introduces the reserved heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > Firstly, since a new type of memory bank is needed for marking the > memory bank solely as the heap, this commit defines `enum membank_type` The wording is a bit confusing. I read this as the code will use "enum membank_type" but this is not possible as your enum is anonymous. My suggestion would be to avoid creating a typedef (see below). > and use this enum in function device_tree_get_meminfo(). Changes of > code are done accordingly following the introduction of this enum. > > Also, this commit introduces the logic to parse the reserved heap > configuration in device tree by reusing the device tree entry definition > of the static memory allocation feature. If the memory bank is reserved > as heap through `xen,static-heap` property in device tree `chosen` node, > the memory will be marked as heap type. > > A documentation section is added, describing the definition of reserved > heap memory and the method of enabling the reserved heap memory through > device tree at boot time. > > Signed-off-by: Henry Wang > Signed-off-by: Penny Zheng > --- > Changes from v1 to v2: > - Rename the device tree property to xen,static-heap to avoid confusion. > - Change of commit msg and doc wording, correct typo in commit msg. > - Do not change the process_chosen_node() return type. > - Add an empty line in make_memory_node() memory type check to improve > readability. > - Use enum membank_type to make the memory type cleaner. > Changes from RFC to v1: > - Rename the terminology to reserved heap. > --- > docs/misc/arm/device-tree/booting.txt | 45 +++++++++++++++++++++++++++ > xen/arch/arm/bootfdt.c | 31 +++++++++++++++--- > xen/arch/arm/domain_build.c | 8 +++-- > xen/arch/arm/include/asm/setup.h | 7 ++++- > xen/arch/arm/setup.c | 2 +- > 5 files changed, 84 insertions(+), 9 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..ff7ca36715 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -378,3 +378,48 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > + > +Reserved Heap Memory > +==================== > + > +The reserved heap memory (also known as the statically-configured heap) refers > +to parts of RAM reserved in the beginning of boot time for heap. The memory is > +reserved by configuration in the device tree using physical address ranges. > + > +The reserved heap memory declared in the device tree defines the memory areas > +that will be reserved to be used exclusively as heap. > + > +- For Arm32, since there are seperated heaps, the reserved heap will be used type: s/seperated/separated/ > +for both domheap and xenheap. > +- For Arm64, since there is a single heap, the defined reserved heap areas > +shall always go to the heap allocator. > + > +The reserved heap memory is an optional feature and can be enabled by adding > +below device tree properties in the `chosen` node. > + > +The dtb should have the following properties: > + > +- xen,static-heap > + > + Property under the top-level "chosen" node. It specifies the address > + and size of Xen reserved heap memory. > + > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells > + > + Specify the number of cells used for the address and size of the > + "xen,static-heap" property under "chosen". > + > +Below is an example on how to specify the reserved heap in device tree: > + > + / { > + chosen { > + #xen,static-heap-address-cells = <0x2>; > + #xen,static-heap-size-cells = <0x2>; > + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; > + ... > + }; > + }; > + > +RAM starting from the host physical address 0x30000000 of 1GB size will > +be reserved as heap. > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index ec81a45de9..5af71dc8ba 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > static int __init device_tree_get_meminfo(const void *fdt, int node, > const char *prop_name, > u32 address_cells, u32 size_cells, > - void *data, bool xen_domain) > + void *data, membank_type type) > { > const struct fdt_property *prop; > unsigned int i, banks; > @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, > continue; > mem->bank[mem->nr_banks].start = start; > mem->bank[mem->nr_banks].size = size; > - mem->bank[mem->nr_banks].xen_domain = xen_domain; > + mem->bank[mem->nr_banks].type = type; > mem->nr_banks++; > } > > @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, > void *data) > { > return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, > - data, false); > + data, MEMBANK_MEMORY); > } > > static int __init process_reserved_memory_node(const void *fdt, int node, > @@ -301,6 +301,28 @@ static void __init process_chosen_node(const void *fdt, int node, > paddr_t start, end; > int len; > > + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) > + { > + u32 address_cells = device_tree_get_u32(fdt, node, > + "#xen,static-heap-address-cells", 0); > + u32 size_cells = device_tree_get_u32(fdt, node, > + "#xen,static-heap-size-cells", 0); > + > + printk("Checking for reserved heap in /chosen\n"); > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: node `%s': invalid #xen,static-heap-address-cells or #xen,static-heap-size-cells\n", > + name); > + return; > + } > + > + if ( device_tree_get_meminfo(fdt, node, "xen,static-heap", > + address_cells, size_cells, > + &bootinfo.reserved_mem, > + MEMBANK_RSVD_HEAP) ) > + return; > + } > + > printk("Checking for initrd in /chosen\n"); > > prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); > @@ -358,7 +380,8 @@ static int __init process_domain_node(const void *fdt, int node, > "#xen,static-mem-size-cells", 0); > > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > - size_cells, &bootinfo.reserved_mem, true); > + size_cells, &bootinfo.reserved_mem, > + MEMBANK_XEN_DOMAIN); > } > > static int __init early_scan_node(const void *fdt, > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..1e46b95f0b 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, > if ( mem->nr_banks == 0 ) > return -ENOENT; > > - /* find first memory range not bound to a Xen domain */ > - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) > + /* find first memory range not bound to a Xen domain nor heap */ > + for ( i = 0; i < mem->nr_banks && > + (mem->bank[i].type != MEMBANK_MEMORY); i++ ) > ; > + > if ( i == mem->nr_banks ) > return 0; > > @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, > u64 start = mem->bank[i].start; > u64 size = mem->bank[i].size; > > - if ( mem->bank[i].xen_domain ) > + if ( mem->bank[i].type == MEMBANK_XEN_DOMAIN ) > continue; > > dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..d0cc556833 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -22,11 +22,16 @@ typedef enum { > BOOTMOD_UNKNOWN > } bootmodule_kind; > > +typedef enum { > + MEMBANK_MEMORY, Technically everything is memory :). I think here you are referring to either: - Reserved memory for the device (or firmware) - Any memory that will be used by the allocator. I would consider to name the field MEMBANK_UNKNOWN or MEMBANK_DEFAULT with a comment explaining the meaning depends where it used (we have several arrays using struct membank). > + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain. */ > + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */ I would clarify the two values are only valid when the bank in in reserved_mem. > +} membank_type; I would prefer if if we don't define any typedef for this enum. But if you want to keep it, then please suffix with _t. > > struct membank { > paddr_t start; > paddr_t size; > - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > + membank_type type; > }; > > struct meminfo { > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 6e0398f3f6..8d3f859982 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) > > for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) > { > - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) > + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_XEN_DOMAIN ) > { > mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); > unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 17:25:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 17:25:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399090.640133 (Exim 4.92) (envelope-from ) id 1oVFqG-0005Qv-IE; Mon, 05 Sep 2022 17:25:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399090.640133; Mon, 05 Sep 2022 17:25:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFqG-0005Qo-F4; Mon, 05 Sep 2022 17:25:00 +0000 Received: by outflank-mailman (input) for mailman id 399090; Mon, 05 Sep 2022 17:24:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFqF-0005Qi-9M for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 17:24:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVFqE-00074q-Vo; Mon, 05 Sep 2022 17:24:58 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVFqE-0006uV-Oq; Mon, 05 Sep 2022 17:24:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6g5RVZj9wl4AEMwIuyUZvblZsrSdcPEkv3pz/GHAHD8=; b=dFtOGVhmHoDGiIhU6UpTVbrQMk 5La8nY6/4jOMl73c6n4w57lGU1KtwFqcOsy932BhE+SQ78s9lgvkRuezdsN4w0xo5XkX9GSH1Qa54 ODmwzW6tAe6eqt6VX2ZCBEL9iW92op8eWgO7A2NIwgyTfGOTJQPXRLHqM6cenZ6QyelU=; Message-ID: <8325d0ce-1fd3-d754-9eaf-d73b19f8d53e@xen.org> Date: Mon, 5 Sep 2022 18:24:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Content-Language: en-US To: Michal Orzel , Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 05/09/2022 13:04, Michal Orzel wrote: > On 05/09/2022 09:26, Henry Wang wrote: >> >> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h >> index 5815ccf8c5..d0cc556833 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -22,11 +22,16 @@ typedef enum { >> BOOTMOD_UNKNOWN >> } bootmodule_kind; >> >> +typedef enum { >> + MEMBANK_MEMORY, >> + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain. */ >> + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */ >> +} membank_type; > Whereas the patch itself looks ok (it must be modified anyway given the comments for patch #2), > MEMBANK_XEN_DOMAIN name is quite ambiguous to me, now when it is part of membank_type enum. > Something like MEMBANK_STATIC or MEMBANK_STATICMEM would be much cleaner in my opinion > as it would directly indicate what type of memory we are talking about. I am not sure. Technically the reserved heap is static memory that has been allocated for the heap. In fact, I think thn name "staticmem" is now becoming quite confusing because we are referring to a very specific use case (i.e. memory that has been reserved for domain use). So I would prefer if we keep "domain" in the name. Maybe MEMBANK_STATIC_DOMAIN or MEMBANK_RESERVED_DOMAIN. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 18:04:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 18:04:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399097.640144 (Exim 4.92) (envelope-from ) id 1oVGRs-0001Ku-HU; Mon, 05 Sep 2022 18:03:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399097.640144; Mon, 05 Sep 2022 18:03:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGRs-0001Kn-ET; Mon, 05 Sep 2022 18:03:52 +0000 Received: by outflank-mailman (input) for mailman id 399097; Mon, 05 Sep 2022 18:03:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGRq-0001Kg-Fw for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 18:03:50 +0000 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [2607:f8b0:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1671a71f-2d45-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 20:03:47 +0200 (CEST) Received: by mail-il1-x12f.google.com with SMTP id l6so4926801ilk.13 for ; Mon, 05 Sep 2022 11:03:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1671a71f-2d45-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=T67TRgbvL4Ai6kaNg3fck6vcoHVKT+0s4pwJ/NSZTGA=; b=cPF8g7Tq5Xr7vWwWPXlAIGbvK841YSQ7JL9eISWcCc1GmuozWN4LmUfAHYFGsC3plp xbkMUOOnQhpFxa0XIBosBwjnD4RAr2Kl5FqcTcUiqI63BnVfEWkAAfAMPK2+2D9jC4rI SBcZs3gwdK8qGIp1MV9X/fGPGkKuR5qRQqaUNUEfXT08Tya/qRlmc89AlTJ5Ml7Xorrw xo1/RpLc8BQEQ206qriFaMJIssLZDxhxOljYpigcvkdlTlPx06einaUW7/uPd1dNz5in HXBRJcn7nXiV8BlMPqUAxSW6U9l+lE6gj/Oi85wJcyYJwIvqaZZYLOTvZP+kHnJ13k+5 7W5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=T67TRgbvL4Ai6kaNg3fck6vcoHVKT+0s4pwJ/NSZTGA=; b=1AkJhyCAA7+7d+ru3m1VdSl7Zv4Ak40M1O5DbhNiqQdGa28PNv+T3NlEBHAnnU3gJv cU/IoKrCWeiMBtHqJHE4YBKG9DW9r3Dllr5LbJtqRMohwBZY9tR5Axrf+4RmFCJOUNPa URiRomlEhUH4LgsV03Y3DzRXq0O+SxPFZYiT3G24ABiMpNI+Sp3PH51bBgoVPL77vKzQ QBenRHes7qS0OWsB4YkNiAEG0QwFwuKGm55JWqq8fR6jyztOu1P8oSySOCqbHc9eutgv FHfWloPw+cqG6R62orul+HXgK7v0OkRmnbx9n65sjU0cbNA3JelDGGxmhEI3CTF7/uDD OMyg== X-Gm-Message-State: ACgBeo1u3AMTJd+Y2xNSOjni/Ku44/jEwBiDnoQyGSnrDlx6LQgsbpuM U0VHJcwzQFgvipwqN1NOJeeGt/QOHnO7VqGOZEAkog== X-Google-Smtp-Source: AA6agR4B7x+HXZFIStbcPiXGjinnhf/x5VSF8+h0pcx1isIR3eJmYhiMXqo5jfQScJCtZZmLuVhzCMYw0KB/RJ8mvlI= X-Received: by 2002:a05:6e02:1ba8:b0:2eb:7d50:5fb8 with SMTP id n8-20020a056e021ba800b002eb7d505fb8mr14014798ili.296.1662401026346; Mon, 05 Sep 2022 11:03:46 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 5 Sep 2022 11:03:35 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Michal Hocko Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Mon, Sep 5, 2022 at 1:12 AM Michal Hocko wrote: > > On Sun 04-09-22 18:32:58, Suren Baghdasaryan wrote: > > On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > [...] > > > Yes, tracking back the call trace would be really needed. The question > > > is whether this is really prohibitively expensive. How much overhead are > > > we talking about? There is no free lunch here, really. You either have > > > the overhead during runtime when the feature is used or on the source > > > code level for all the future development (with a maze of macros and > > > wrappers). > > > > As promised, I profiled a simple code that repeatedly makes 10 > > allocations/frees in a loop and measured overheads of code tagging, > > call stack capturing and tracing+BPF for page and slab allocations. > > Summary: > > > > Page allocations (overheads are compared to get_free_pages() duration): > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > 8.8% lookup_page_ext > > 1237% call stack capture > > 139% tracepoint with attached empty BPF program > > Yes, I am not surprised that the call stack capturing is really > expensive comparing to the allocator fast path (which is really highly > optimized and I suspect that with 10 allocation/free loop you mostly get > your memory from the pcp lists). Is this overhead still _that_ visible > for somehow less microoptimized workloads which have to take slow paths > as well? Correct, it's a comparison with the allocation fast path, so in a sense represents the worst case scenario. However at the same time the measurements are fair because they measure the overheads against the same meaningful baseline, therefore can be used for comparison. > > Also what kind of stack unwinder is configured (I guess ORC)? This is > not my area but from what I remember the unwinder overhead varies > between ORC and FP. I used whatever is default and didn't try other mechanisms. Don't think the difference would be orders of magnitude better though. > > And just to make it clear. I do realize that an overhead from the stack > unwinding is unavoidable. And code tagging would logically have lower > overhead as it performs much less work. But the main point is whether > our existing stack unwiding approach is really prohibitively expensive > to be used for debugging purposes on production systems. I might > misremember but I recall people having bigger concerns with page_owner > memory footprint than the actual stack unwinder overhead. That's one of those questions which are very difficult to answer (if even possible) because that would depend on the use scenario. If the workload allocates frequently then adding the overhead will likely affect it, otherwise might not be even noticeable. In general, in pre-production testing we try to minimize the difference in performance and memory profiles between the software we are testing and the production one. From that point of view, the smaller the overhead, the better. I know it's kinda obvious but unfortunately I have no better answer to that question. For the memory overhead, in my early internal proposal with assumption of 10000 instrumented allocation call sites, I've made some calculations for an 8GB 8-core system (quite typical for Android) and ended up with the following: per-cpu counters atomic counters page_ext references 16MB 16MB slab object references 10.5MB 10.5MB alloc_tags 900KB 312KB Total memory overhead 27.4MB 26.8MB so, about 0.34% of the total memory. Our implementation has changed since then and the number might not be completely correct but it should be in the ballpark. I just checked the number of instrumented calls that we currently have in the 6.0-rc3 built with defconfig and it's 165 page allocation and 2684 slab allocation sites. I readily accept that we are probably missing some allocations and additional modules can also contribute to these numbers but my guess it's still less than 10000 that I used in my calculations. I don't claim that 0.34% overhead is low enough to be always acceptable, just posting the numbers to provide some reference points. > -- > Michal Hocko > SUSE Labs From xen-devel-bounces@lists.xenproject.org Mon Sep 05 18:07:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 18:07:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399106.640154 (Exim 4.92) (envelope-from ) id 1oVGVY-0001zX-4c; Mon, 05 Sep 2022 18:07:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399106.640154; Mon, 05 Sep 2022 18:07:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGVY-0001zQ-20; Mon, 05 Sep 2022 18:07:40 +0000 Received: by outflank-mailman (input) for mailman id 399106; Mon, 05 Sep 2022 18:07:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGVX-0001z4-7f for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 18:07:39 +0000 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [2607:f8b0:4864:20::d32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9faea228-2d45-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 20:07:38 +0200 (CEST) Received: by mail-io1-xd32.google.com with SMTP id d68so7246698iof.11 for ; Mon, 05 Sep 2022 11:07:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9faea228-2d45-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Bum5cdqCm4gIf+I6AQy+wa1rXRQMNTd23PbVP2YAzEs=; b=P1Rb3fVwlXmtVf21S4DMQt260sMuniAXM5U5+atV+MhvCaumM2tXM3K6KXNyMSjZe0 3nRcAmBfF+7W6/WOVR2XOADKxyQte4OnojdLmDBhMFh9NdRikO81nZDemeys0l200+Ya BtEOzumSQwgu7ZWm3QeSZrXIo15d7vuotOaip8lu87RHKwjf3TUmogDdVvisjKKDmHLO PI+YQ7orIzFlOARyvXxCAIGW+yY5UcwZ3NgJ+U4tIgdfF/EioIbKjubkaR07oZSndJ0y pThgMzg7BhFJemuG5SPivo5QOLrPUeLBb55vYf5zQYtWTw5SjAAGq1FqYgp+ZLnBdvd/ Qr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Bum5cdqCm4gIf+I6AQy+wa1rXRQMNTd23PbVP2YAzEs=; b=3wyp9ZpnL+vgMFI47uuUlJNsUtlwPltnV0aqxhJ4SqFK2dluTU1cwLkMbumqE5kShj sMkGPvfqVPkTZMwb4DiwGF0IThUY/afGD2VYuXih5hwpGaN/ytw59k4Z4GeREK1ne89s fuTRWw2tO0ABREEqdOlDhGl7rVBVEYhU92luT+4nR2VQ4mEIRdZHMn4Gx23pIK2T+YJJ fQQg/MLYnw+5ASYMSvUg8JZb44Hb74yam0luwdxCz8fwqeRnf73pYDoHif/vbIsfICrR Hb4NeKihf354PcSgaI57vPu9Vz0ESdaLg5N5sWH+Qi35ViDkvwqIsEF85GNxXsdWH4Ru PMzQ== X-Gm-Message-State: ACgBeo2kPe2BWo79yJN3dN4HGuxmeIscXndye4FGMoZL42Wa1fZqv4WC Bykcw38wrdZNzQX7E7Ibfv5p0V5E3d30wadUV9LBEQ== X-Google-Smtp-Source: AA6agR6r5XgehoMYjBLme4+OWXroqyk9NqBwquoUHJYNtZV3MpkU67zLpVv3eXPms5QzjDOiUeZjqJqeUZuYSAeGarw= X-Received: by 2002:a05:6638:1492:b0:34c:d42:ac2f with SMTP id j18-20020a056638149200b0034c0d42ac2fmr13910620jak.305.1662401256621; Mon, 05 Sep 2022 11:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 5 Sep 2022 11:07:25 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Marco Elver Cc: Michal Hocko , Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Mon, Sep 5, 2022 at 1:58 AM Marco Elver wrote: > > On Mon, 5 Sept 2022 at 10:12, Michal Hocko wrote: > > On Sun 04-09-22 18:32:58, Suren Baghdasaryan wrote: > > > On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > > [...] > > > > Yes, tracking back the call trace would be really needed. The question > > > > is whether this is really prohibitively expensive. How much overhead are > > > > we talking about? There is no free lunch here, really. You either have > > > > the overhead during runtime when the feature is used or on the source > > > > code level for all the future development (with a maze of macros and > > > > wrappers). > > > > > > As promised, I profiled a simple code that repeatedly makes 10 > > > allocations/frees in a loop and measured overheads of code tagging, > > > call stack capturing and tracing+BPF for page and slab allocations. > > > Summary: > > > > > > Page allocations (overheads are compared to get_free_pages() duration): > > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > > 8.8% lookup_page_ext > > > 1237% call stack capture > > > 139% tracepoint with attached empty BPF program > > > > Yes, I am not surprised that the call stack capturing is really > > expensive comparing to the allocator fast path (which is really highly > > optimized and I suspect that with 10 allocation/free loop you mostly get > > your memory from the pcp lists). Is this overhead still _that_ visible > > for somehow less microoptimized workloads which have to take slow paths > > as well? > > > > Also what kind of stack unwinder is configured (I guess ORC)? This is > > not my area but from what I remember the unwinder overhead varies > > between ORC and FP. > > > > And just to make it clear. I do realize that an overhead from the stack > > unwinding is unavoidable. And code tagging would logically have lower > > overhead as it performs much less work. But the main point is whether > > our existing stack unwiding approach is really prohibitively expensive > > to be used for debugging purposes on production systems. I might > > misremember but I recall people having bigger concerns with page_owner > > memory footprint than the actual stack unwinder overhead. > > This is just to point out that we've also been looking at cheaper > collection of the stack trace (for KASAN and other sanitizers). The > cheapest way to unwind the stack would be a system with "shadow call > stack" enabled. With compiler support it's available on arm64, see > CONFIG_SHADOW_CALL_STACK. For x86 the hope is that at one point the > kernel will support CET, which newer Intel and AMD CPUs support. > Collecting the call stack would then be a simple memcpy. Thanks for the note Marco! I'll check out the CONFIG_SHADOW_CALL_STACK on Android. From xen-devel-bounces@lists.xenproject.org Mon Sep 05 18:08:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 18:08:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399113.640166 (Exim 4.92) (envelope-from ) id 1oVGWR-0002Yp-FA; Mon, 05 Sep 2022 18:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399113.640166; Mon, 05 Sep 2022 18:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGWR-0002Yi-BG; Mon, 05 Sep 2022 18:08:35 +0000 Received: by outflank-mailman (input) for mailman id 399113; Mon, 05 Sep 2022 18:08:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGWQ-0002V4-Mc for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 18:08:34 +0000 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [2607:f8b0:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1045709-2d45-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 20:08:34 +0200 (CEST) Received: by mail-il1-x134.google.com with SMTP id s11so4935141ilt.7 for ; Mon, 05 Sep 2022 11:08:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1045709-2d45-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=hbTvjCqXtfZwCNAPDugxhLvbO4tPW4uXsytclFMPf88=; b=BWl6tEU0Jv/5Ok7izOy2X+2XFHIjW2yJwE8yMIwADusWnEOeQC8si1U6iks3IFTXtR 5tbbeyYCmyTiKFNMcU3D2cV+gb/s5ohOcUII9kU6FU7ji/Zh8BrlwKsCQaRcerXV6BGZ 8PlGGmZZYHPvdH+WgSsyR10w9r/j2bW/3D0lAGkx1tIn87fB5RB3pcjDyqMnvPGCsyas uH/yoycyrf5kaO5p9L7J37V/vDYJvxKCrEBpA8AorAMThecIv/vXA5VLdyTk9mhWPhlm xhk4J8Awk+fBDhqAh5Kc3xuDELqvWV7xGoRQ08TJNeQzRqgNOVW6ruxsZF0Lyj7+Dw3B m0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hbTvjCqXtfZwCNAPDugxhLvbO4tPW4uXsytclFMPf88=; b=KmxPidMrdXHyzghvYEE28ZN0F2ypzTETgVkhIshJ8oF+f2sVoT23RD+39D/Ccga4xI wFgzHU2tI6DA73lFXrGkstiCKUjVvXVGlnUDOOK19jxX5IoI9rMDZLS8CHbZWUKEpGl7 zYLDmS84qP0YjuhcyLcen5gik3vE9ZGtnNHwhgwzZROMF7Dl/MHwkfLURSA6n2j1OOtZ HyaB/m3z0xLQOvbGvknMAMzk4U6gSKL6zOxIiUKeBdS5T16sBemGoCKFTBBRDYEuvh2f 0peQHrOcBxlvX0mcLz+6WmG915JoJ0sO2SEwHr+uU0eKeDdrFOPgbp0u3swVA1Cpn0oe bEcQ== X-Gm-Message-State: ACgBeo1ux6ZfSENqrsaVXoNasbFyz9vs8rIoTeDVkb8C3RJCYbUAGnQG ST3CgHThiVFjfNbtV4nwNGETsOkSDWAf1bAc+fhllQ== X-Google-Smtp-Source: AA6agR4Rv/lC85vS43o4ySf3NvmJunla0lbszDaoWXhv+p4vulk9P6WBBoE0T5B+Wry+ZoXPm1CE94n4VZxipIKzyxQ= X-Received: by 2002:a92:ca06:0:b0:2eb:391a:a2a4 with SMTP id j6-20020a92ca06000000b002eb391aa2a4mr16719486ils.199.1662401312639; Mon, 05 Sep 2022 11:08:32 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220905110713.27304149@gandalf.local.home> In-Reply-To: <20220905110713.27304149@gandalf.local.home> From: Suren Baghdasaryan Date: Mon, 5 Sep 2022 11:08:21 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Steven Rostedt Cc: Michal Hocko , Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Mon, Sep 5, 2022 at 8:06 AM Steven Rostedt wrote: > > On Sun, 4 Sep 2022 18:32:58 -0700 > Suren Baghdasaryan wrote: > > > Page allocations (overheads are compared to get_free_pages() duration): > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > 8.8% lookup_page_ext > > 1237% call stack capture > > 139% tracepoint with attached empty BPF program > > Have you tried tracepoint with custom callback? > > static void my_callback(void *data, unsigned long call_site, > const void *ptr, struct kmem_cache *s, > size_t bytes_req, size_t bytes_alloc, > gfp_t gfp_flags) > { > struct my_data_struct *my_data = data; > > { do whatever } > } > > [..] > register_trace_kmem_alloc(my_callback, my_data); > > Now the my_callback function will be called directly every time the > kmem_alloc tracepoint is hit. > > This avoids that perf and BPF overhead. Haven't tried that yet but will do. Thanks for the reference code! > > -- Steve From xen-devel-bounces@lists.xenproject.org Mon Sep 05 18:16:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 18:16:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399120.640177 (Exim 4.92) (envelope-from ) id 1oVGe0-00043H-6f; Mon, 05 Sep 2022 18:16:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399120.640177; Mon, 05 Sep 2022 18:16:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGe0-000438-3q; Mon, 05 Sep 2022 18:16:24 +0000 Received: by outflank-mailman (input) for mailman id 399120; Mon, 05 Sep 2022 18:16:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGdy-000432-F1 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 18:16:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGdy-00083Y-55; Mon, 05 Sep 2022 18:16:22 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.1.223]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVGdx-0000tu-UJ; Mon, 05 Sep 2022 18:16:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5+clwZw1Mth9Fr8Yi0FaL99UUSFFJfcKM1iBW4AIjEA=; b=K2ZcLb+6tUhhlV0ROmINFb/Mxh 03WcRsqCwBu+ri2uDOexfamvhA24gX7uYERBV0veC5QaJWjmkeSi3NVQKq1oZ62CF1kZr6n7gFRlb sjDA/u6N7iUV8xCp09lHW5isvX5177sAg/cKhHJIU8YPpartdv3eb6AezyweqXF8KBTI=; Message-ID: <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> Date: Mon, 5 Sep 2022 19:16:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220905072635.16294-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 05/09/2022 08:26, Henry Wang wrote: > This commit firstly adds a bool field `reserved_heap` to bootinfo. > This newly introduced field is set at the device tree parsing time > if the reserved heap ranges are defined in the device tree chosen > node. > > For Arm32, In `setup_mm`, if the reserved heap is enabled, we use > the reserved heap region for both domheap and xenheap allocation. > Note that the xenheap on Arm32 should be always contiguous, so also > add a helper fit_xenheap_in_reserved_heap() for Arm32 to find the > required xenheap in the reserved heap regions. > > For Arm64, In `setup_mm`, if the reserved heap is enabled and used, > we make sure that only these reserved heap pages are added to the > boot allocator. These reserved heap pages in the boot allocator are > added to the heap allocator at `end_boot_allocator()`. > > If the reserved heap is disabled, we stick to current page allocation > strategy at boot time. > > Also, take the chance to correct a "double not" print in Arm32 > `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. > > Signed-off-by: Henry Wang > --- > Changes from v1 to v2: > - Move the global bool `reserved_heap` to bootinfo. > - Replace the open open-coding address ~0 by INVALID_PADDR. > - Do not use reverted logic in heap_pages calculation. > - Remove unused Arm32 reserved_heap_start variable. > - Decouple the arm32 reserved heap too small size check with region > end check. > - Reuse the arm32 original xenheap finding logic with the new helper > to make sure xenheap on arm32 is contiguous. > Changes from RFC to v1: > - Rebase on top of latest `setup_mm()` changes. > - Added Arm32 logic in `setup_mm()`. > --- > xen/arch/arm/bootfdt.c | 2 + > xen/arch/arm/include/asm/setup.h | 1 + > xen/arch/arm/setup.c | 116 +++++++++++++++++++++++++++---- > 3 files changed, 104 insertions(+), 15 deletions(-) > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 3796a4bd75..616bf5ce47 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -322,6 +322,8 @@ static int __init process_chosen_node(const void *fdt, int node, > &bootinfo.reserved_mem, MEMBANK_RSVD_HEAP); > if ( rc ) > return rc; > + > + bootinfo.reserved_heap = true; > } > > printk("Checking for initrd in /chosen\n"); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index d0cc556833..22fb950bc8 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -82,6 +82,7 @@ struct bootinfo { > #ifdef CONFIG_ACPI > struct meminfo acpi; > #endif > + bool reserved_heap; > }; > > struct map_range_data > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 8d3f859982..0b4f7cb909 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -556,6 +556,43 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, > } > return e; > } > + > +/* > + * Find the contiguous xenheap region that fits in the reserved heap region with There might be multiple. So "Find a contiguous...". I would also drop "xenheap". > + * required size and alignment, and return the end address of xenheap. I would write "and return the end address of the region if found otherwise 0". > + */ > +static paddr_t __init fit_xenheap_in_reserved_heap(uint32_t size, paddr_t align) > +{ > + int i; Please use unsigned int. > + paddr_t end = 0, aligned_start, aligned_end; > + paddr_t bank_start, bank_size, bank_end; > + > + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) > + { > + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) NIT: You could avoid the extra indentation by reverting the condition. > + { > + bank_start = bootinfo.reserved_mem.bank[i].start; > + bank_size = bootinfo.reserved_mem.bank[i].size; > + bank_end = bank_start + bank_size; > + > + if ( bank_size < size ) > + continue; > + > + aligned_end = bank_end & ~(align - 1); > + aligned_start = (aligned_end - size) & ~(align - 1); I find the logic a bit confusing. AFAIU, aligned_start could be below the start of the RAM which is not what I would usually expect. The code works. So no change requested. > + > + if ( aligned_start > bank_start ) > + /* > + * Arm32 allocates xenheap from higher address to lower, so if This code is also called on arm32. So what are you referring to? Is it consider_modules()? > + * there are multiple memory banks that satisfy the requirement, > + * use the highest bank. > + */ > + end = max(end, aligned_end); > + } > + } > + > + return end; > +} > #endif > > /* > @@ -713,8 +750,9 @@ static void __init populate_boot_allocator(void) > #ifdef CONFIG_ARM_32 > static void __init setup_mm(void) > { > - paddr_t ram_start, ram_end, ram_size, e; > - unsigned long ram_pages; > + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; > + paddr_t reserved_heap_end = 0, reserved_heap_size = 0; > + unsigned long ram_pages, reserved_heap_pages = 0; > unsigned long heap_pages, xenheap_pages, domheap_pages; > unsigned int i; > const uint32_t ctr = READ_CP32(CTR); > @@ -734,9 +772,9 @@ static void __init setup_mm(void) > > for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) > { > - paddr_t bank_start = bootinfo.mem.bank[i].start; > - paddr_t bank_size = bootinfo.mem.bank[i].size; > - paddr_t bank_end = bank_start + bank_size; > + bank_start = bootinfo.mem.bank[i].start; > + bank_size = bootinfo.mem.bank[i].size; > + bank_end = bank_start + bank_size; > > ram_size = ram_size + bank_size; > ram_start = min(ram_start,bank_start); > @@ -745,19 +783,42 @@ static void __init setup_mm(void) > > total_pages = ram_pages = ram_size >> PAGE_SHIFT; > > + if ( bootinfo.reserved_heap ) > + { > + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) > + { > + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) > + { > + bank_start = bootinfo.reserved_mem.bank[i].start; > + bank_size = bootinfo.reserved_mem.bank[i].size; > + bank_end = bank_start + bank_size; > + > + reserved_heap_size += bank_size; > + reserved_heap_end = max(reserved_heap_end, bank_end); > + } > + } > + > + reserved_heap_pages = reserved_heap_size >> PAGE_SHIFT; > + if ( reserved_heap_pages < 32<<(20-PAGE_SHIFT) ) > + panic("Too small reserved heap region, should be at least 32M\n"); This is a bit misleading. 32MB is not sufficient, it also has to be contiguous. So I would drop this panic() completely. > + } > + > /* > * If the user has not requested otherwise via the command line > * then locate the xenheap using these constraints: > * > * - must be 32 MiB aligned > * - must not include Xen itself or the boot modules > - * - must be at most 1GB or 1/32 the total RAM in the system if less > + * - must be at most 1GB or 1/32 the total RAM in the system > + * (there is no reserved heap) or 1/32 the total reserved Did you forgot to add "if" before "there"? > + * heap region (there is reserved heap) if less The new wording suggests that the 1GB limit only applies when the admin doesn't specify the reserved heap. However, we don't support larger heap than 1GB. So the limit should also apply for the reserved heap. So how about: - must be at most 1GB or 1/32 the total RAM in the system (or reserved heap if enabled) > * - must be at least 32M > * > * We try to allocate the largest xenheap possible within these > * constraints. > */ > - heap_pages = ram_pages; > + heap_pages = bootinfo.reserved_heap ? reserved_heap_pages : ram_pages; You can avoid the ternary operation here by setting heap_pages in the 'if' above and add a else for the 'ram_pages' part. In fact, 'ram_pages' could be completely dropped in favor of 'total_pages'. > + > if ( opt_xenheap_megabytes ) > xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); > else > @@ -767,9 +828,15 @@ static void __init setup_mm(void) > xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); > } > > + /* > + * On Arm32, xenheap must be contiguous, look for one of the region > + * that matches the above-mentioned xenheap constraints. > + */ IMHO this is already implied by the large comment above. But if you want to be more obvious, then I think this should belong to the comment above. > do > { > - e = consider_modules(ram_start, ram_end, > + e = bootinfo.reserved_heap ? > + fit_xenheap_in_reserved_heap(pfn_to_paddr(xenheap_pages), 32<<20) : Please use MB(32) in new code. > + consider_modules(ram_start, ram_end, > pfn_to_paddr(xenheap_pages), > 32<<20, 0); > if ( e ) > @@ -779,7 +846,7 @@ static void __init setup_mm(void) > } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); > > if ( ! e ) > - panic("Not not enough space for xenheap\n"); > + panic("Not enough space for xenheap\n"); > > domheap_pages = heap_pages - xenheap_pages; > > @@ -824,9 +891,9 @@ static void __init setup_mm(void) > static void __init setup_mm(void) > { > const struct meminfo *banks = &bootinfo.mem; > - paddr_t ram_start = ~0; > - paddr_t ram_end = 0; > - paddr_t ram_size = 0; > + paddr_t ram_start = INVALID_PADDR, bank_start = INVALID_PADDR; > + paddr_t ram_end = 0, bank_end = 0; > + paddr_t ram_size = 0, bank_size = 0; > unsigned int i; > > init_pdx(); > @@ -835,17 +902,36 @@ static void __init setup_mm(void) > * We need some memory to allocate the page-tables used for the xenheap > * mappings. But some regions may contain memory already allocated > * for other uses (e.g. modules, reserved-memory...). > - * > + * If there are non-empty reserved heap regions, (only) add these regions I am not sure what you mean by "non-empty" here. How about something like: "If a reserved heap was provided by the admin, populate the boot allocator with the corresponding regions only". > + * in the boot allocator. > + */ > + if ( bootinfo.reserved_heap ) > + { > + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) > + { > + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) > + { > + bank_start = bootinfo.reserved_mem.bank[i].start; > + bank_size = bootinfo.reserved_mem.bank[i].size; > + bank_end = bank_start + bank_size; > + > + init_boot_pages(bank_start, bank_end); > + } > + } > + } > + /* > + * No reserved heap regions: > * For simplicity, add all the free regions in the boot allocator. > */ > - populate_boot_allocator(); > + else > + populate_boot_allocator(); For arm32, shouldn't we also only add the reserved heap (minus the xenheap) to the boot allocator? At which point, I would move the change in populate_boot_allocator(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 18:28:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 18:28:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399128.640188 (Exim 4.92) (envelope-from ) id 1oVGpJ-0005ak-9I; Mon, 05 Sep 2022 18:28:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399128.640188; Mon, 05 Sep 2022 18:28:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGpJ-0005ad-6G; Mon, 05 Sep 2022 18:28:05 +0000 Received: by outflank-mailman (input) for mailman id 399128; Mon, 05 Sep 2022 18:28:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVGpH-0005Yv-Ob for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 18:28:03 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2040.outbound.protection.outlook.com [40.107.94.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77e825a8-2d48-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 20:28:01 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by PH7PR12MB5656.namprd12.prod.outlook.com (2603:10b6:510:13b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Mon, 5 Sep 2022 18:27:56 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d%4]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 18:27:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77e825a8-2d48-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O84cBVXyGm31T7xq0tjp91LAZnzvT+41a7o9nvuKCsPrKYmoeJrEn7S9scMqLMjYHBupAA+CiPBLHErfX/CqWGKu4NIbl9KsuaTHgZfebTQUqq9HQVh5I1Z3PjtxbOK5DL5st4U5GKZMdS/+fUqL0ox7fC0LgAWLy8Hklf+1HPuhDD4O5NkIv3ZDykCi45LnbFAPQm5k+u2eEnFDFL5wsRCcrgxAWiaVD07C/W0yg4InrBBK9y5CmG1thtAO2AdNx4XQCzLJzZ2QXI24FJfsUza4W+GzYe7GGQ2Jw6XxgE7GkWvS1ds+fDyvp3SBIQPFzvqPdIK/dtpzGoXHxaw91A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r2YZjqSWAqsFEieyZigc4KKlHdLCzOveAHOrDx1ISKk=; b=O2TuBa/bc3T5vqMQoWmDzz8hh2hICiDsnW2cS2E0h1aDVy8Lv6CAvDL0zRg6Mbg14Jt0SZfagj0PkbWo+P8mwUBWdmcbhm2V/6Aw2h5unNeg2/D9fM0pTa9Z5Jojvd9qAQ8KI+ossFW0Ky/TgfWBWA+NNW/DZFdxss6TxYYq47KAzxm9yCyZ4yEIQjvYKRHk3nnceKyT62kTX6Tpx52Pq/aUWNdqTGn52tzkEk+SiNx7qjtub6J57C7kietzd/mZs9DKVa2EWES4/PAtMexf9oh5ynPrrN8bI5JGHIU3pm4Pxp2R2+zNfzOLZXh7wkmLtb0elrZE9n3k2tht94Cu9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r2YZjqSWAqsFEieyZigc4KKlHdLCzOveAHOrDx1ISKk=; b=fnreGcstLAQBThqKryQgT9zzHrMAh9ssTDvSpom18Fh2fgHQNE2DofpVNh5oFzeKiBeIUfDUi3D516nEC7fd0oNGPkOMWyIeeB4qNOyiw14FK1gAyZLfXJf1cZnGnRAFdhRwjlLwIyRenqw8wzqFAopJhFceznGIPTMxQ1MjYiI= From: "SHARMA, JYOTIRMOY" To: "olekstysh@gmail.com" CC: "SHARMA, JYOTIRMOY" , "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "Stabellini, Stefano" , "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" , "al1img@gmail.com" Subject: Re: Enable audio virtualization in Xen Thread-Topic: Re: Enable audio virtualization in Xen Thread-Index: AdjBJCbHGOCKcGneSouxTwfUhwYYsg== Date: Mon, 5 Sep 2022 18:27:56 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-05T18:27:54Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=37bedcd6-5a97-46e7-ba26-6fe49401d5ef; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 003e09bf-fa68-423a-b30e-08da8f6c5ab7 x-ms-traffictypediagnostic: PH7PR12MB5656:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8xeeAPwfU3lKHf6N5jaGVoZlLWhs57lb5vztXrgFKnByLYhPcu10eXpwBDhx9AHWGMBEXqrxW8UjAOEClFL98HapniaLcnPwAeHj3jLRX4EsnhCG+F+q37hSMd/vOGXM3U1CY/yw4/7SzxdNar3VOvcFNdrlf1LwQ3H2EpWjd8vEcCx2xpn8AL6PjAqxe8ISUoXzEb4TPeQs5Pu028ML0j7/LWkT8leS/aACzFirQotYrRzmeFOlXdeykOUI5jxVyD7lBX3belvkS5ENc25b/zd8qooO/ikUDHMPD/6BjqDP8bKO788al6UQfqPZYpmA0HiHvvbMTBbxCbFX9fwD8vAE8b8c15tqLxj2ijFYuspjv5jd1XOIFkykb3CnITj37VDjgwcAuFC3/18tbFH+6HJWjwUHwvhfecxQczMpE64kRxOpatnwig8yG4nXwpW95GvnS5rPitAxZByxmwb7s/mUPr/9H5N5bbwndd98TvC6gSPkRCLn8eaOiVLMHpRuTdCHxZW1f6YHRhBoLSww2/p7Ozw7ZwA6Lq1+PZlzH/xzNd0+B2p6SrIvHM/JoLmZRnhH/YMf9la4Hai2thbpQAs1wqMbWzH8FGz+2q20guAHkOF9gLuNv8t+60SB9qfihjkobIFKUGfA1JkoKGizNkocP16Qq/6GvMoZ+sXzOEWDS5MrffoBJbWs2r/3mT77Wbya6Fev/lXtusuHqkQ3Z3QEY5RILHGjD69Zq15/oJCprmrjvGWsvstHWfp5AawzrdYtTeI06uOXOH13yWlRRQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(39860400002)(396003)(136003)(376002)(122000001)(8676002)(76116006)(4326008)(66446008)(66476007)(64756008)(66946007)(66556008)(38100700002)(186003)(41300700001)(71200400001)(6506007)(55236004)(54906003)(7696005)(9686003)(6916009)(316002)(55016003)(83380400001)(26005)(8936002)(5660300002)(33656002)(478600001)(86362001)(2906002)(52536014)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6lDJXo7zq46cuZJcAEgpLiOmBvmQo8wJtw+uXuINvywrDUsyYtpMsojFfWHL?= =?us-ascii?Q?LHTcs0RfHWsuMBGjU9i0G46jzVuZDcJF7LocrbpgzRw0kuKFX9MDuKzKx4EU?= =?us-ascii?Q?0apqdOtd6GrQtsVBuc1jWbATZZiIRZ1T2L3gDRpM8cECqT0MYcosqWg4Zhyh?= =?us-ascii?Q?1NI7Ts1X5gbotOIEEvoCLVZ0d3vB52WnXetErkX5OGXJtjJnoeEwlAvlx6A3?= =?us-ascii?Q?7dWAEKUvYqdh2p6+Yubz1V78dgiaDKPJJvoU5p50Z3Jyz6vDQFur3r7/i69W?= =?us-ascii?Q?Bwg87O6rNYcofIyMuXZUYWu3C+aRvjNXejE4X4F3uJk8TM/7opS0ZA4afTHZ?= =?us-ascii?Q?NJNChQhDi7AhpH6+oLKElcDN4+8He/GPUcAzbXrEQ9kvdeRnXKB4bBEUjMm9?= =?us-ascii?Q?re2u5OAMg22RUYSHqWbnXdU+FDFsddntsuvL6ZlP9ftd7FTf/a6GxOPr77vo?= =?us-ascii?Q?KLWHsW2vAlny8q4we/Iq4mQvMtxqRq7G7Bs3xziL98jxOJ82l79sJd6PF+D/?= =?us-ascii?Q?oy481DpKse58b/xGgq321F3Kw5F8sYbXLWOMcL1AwUmXvSbhToE2dSX7xMYU?= =?us-ascii?Q?JVqoCy0vjsBkXQUJUtBIMb+LU8m7m+DyZgO6jCC7HTklMtf56gBHfBAjIVF3?= =?us-ascii?Q?9r2Fc/bkr+a8JPzFD28Qeua36nPRa7rsev5PXAXLCPlQ+MKEfHiG7KPVOfNd?= =?us-ascii?Q?eZSmFzAwyeEoSkImrQuBimLhDZu/yd7RbfTmv1DrHgOM9Se15j3gc/SV89dV?= =?us-ascii?Q?ytnKo7UU7zKATC9FaQrC8HjhdNczBl1uAszcBG/T/cmmvY0oS8cD7WVJVqpu?= =?us-ascii?Q?0S52Gf2spEFHABV7QSd0YGt0gF2cRn0uHlWwYR8Nn+8yozQ+Bd50Z6LVKXeP?= =?us-ascii?Q?68kbLMwYzZZ0GoNXBfhswUT09hoyFXXuXtftPpkx+Z5zf8T1g9Xp5h8qBKVp?= =?us-ascii?Q?Cvixr6/JJHakjOYyeQceSXAisFTIGMLTlYDUG1lWWb4DCu02K1xY1vckq5RI?= =?us-ascii?Q?ogcNvq9xkPjNDhD6xEF3Ml9dpP915+XZA0Q1+XUP68dSCjnvjsxXUlvxV1Pr?= =?us-ascii?Q?jo2VyKuYxluLS1kPIBqoBd5pV3Vo1KuqXLTRXA3hf/H0QPMVJjJnXTg9sPSl?= =?us-ascii?Q?PhjZLtS5AfalBXLt+Xz3s8sHZ5Kmc154wIMjqpOUTr86f3ONzdEJ1AFGb1lZ?= =?us-ascii?Q?QnVvaCfJs1aoRWcjK342LVLRi+v230ok47eyhtbOCvmecKPN6vpDIz/nM0po?= =?us-ascii?Q?LC2YAQX7Ahka8Su+Y8+HSr5lYeoY3bPvj+2aLDwwkA8fOomqGfY+jecNlRAW?= =?us-ascii?Q?Ef6lY7f3n+eUvSIb0yx4Mh0eZ0eoPoRpIVppof8tpeZH0QtC+5RbNYNWKZk5?= =?us-ascii?Q?Qvn9QouPajbvH1Pmqlpds00ly19PI+WHvUE7oOvBbpyuuBfrwJmT5lpqkHRL?= =?us-ascii?Q?v5w4CM2HqNzvO5xJWI2CZhyxfKJZZJwkWDxN+ZjktjW3u6643xHgQ+R18bmO?= =?us-ascii?Q?rOKqFkVYybWjlXNDWGz4UBQNrNWL7+pXui1F6CUWAPyEeq5/LxJ698aV4jGn?= =?us-ascii?Q?DcwCilmDyIVMEEazHVk=3D?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB429727E2F53D906BCF38E3809F7F9DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 003e09bf-fa68-423a-b30e-08da8f6c5ab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2022 18:27:56.7418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M1spT21pcqc0iGcaX5KHSIc79XUXrErmokrpLxJfpcy+yZLSnn7hjIM2ewNBEXZP+7+tiqX1B0+mHUe1d2854Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5656 --_000_DM6PR12MB429727E2F53D906BCF38E3809F7F9DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Oleksandr, Thank you for your input. I tried matching the hardware parameter (i.e. buf= fer size) in the HVM config file, but still no luck with audio from HVM gue= st. Here is the complete vsnd config: vsnd =3D [[ 'card, backend=3DDomain-0, buffer-size=3D22050, short-name=3DVC= ard, long-name=3DVirtual sound card, sample-rates=3D8000;11025;16000;22050;= 32000;44100;48000, sample-formats=3Ds16_le', 'pcm, name=3Ddev1', 'stream, u= nique-id=3Dalsa, type=3DP' ]] This is what I see when I play audio in Dom 0: amd@amd-Bilby-RV2:~$ aplay -v ~/SampleAudio/music.wav Playing WAVE '/home/amd/SampleAudio/music.wav' : Signed 16 bit Little Endia= n, Rate 44100 Hz, Stereo ALSA <-> PulseAudio PCM I/O Plugin Its setup is: stream : PLAYBACK access : RW_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 44100 exact rate : 44100 (44100/1) msbits : 16 buffer_size : 22050 period_size : 5512 period_time : 125000 tstamp_mode : NONE tstamp_type : GETTIMEOFDAY period_step : 1 avail_min : 5512 period_event : 0 start_threshold : 22050 stop_threshold : 22050 silence_threshold: 0 silence_size : 0 boundary : 6206523236469964800 I have also tried giving buffer-size as 88200 (22050 * 2 channels * 2 bytes= per sample), but still there is no audio from HVM guest. What will be the right parameters based on the above aplay information? Below is the information obtained using -dump-hw-params flag. Do I need to = change vsnd parameters based on this information? amd@amd-Bilby-RV2:~$ aplay ~/SampleAudio/music.wav --dump-hw-params Playing WAVE '/home/amd/SampleAudio/music.wav' : Signed 16 bit Little Endia= n, Rate 44100 Hz, Stereo HW Params of device "default": -------------------- ACCESS: RW_INTERLEAVED FORMAT: U8 S16_LE S16_BE S24_LE S24_BE S32_LE S32_BE FLOAT_LE FLOAT_BE MU_= LAW A_LAW S24_3LE S24_3BE SUBFORMAT: STD SAMPLE_BITS: [8 32] FRAME_BITS: [8 1024] CHANNELS: [1 32] RATE: [1 384000] PERIOD_TIME: (2 4294967295) PERIOD_SIZE: [1 1398102) PERIOD_BYTES: [128 1398102) PERIODS: [3 1024] BUFFER_TIME: (7 4294967295] BUFFER_SIZE: [3 4194304] BUFFER_BYTES: [384 4194304] TICK_TIME: ALL -------------------- Added Oleksandr Grytsov for help. Regards, Jyotirmoy --_000_DM6PR12MB429727E2F53D906BCF38E3809F7F9DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


Hi Oleksandr,

 

Thank you for your input. I tried matching the hardw= are parameter (i.e. buffer size) in the HVM config file, but still no luck = with audio from HVM guest.

Here is the complete vsnd config:

 

vsnd =3D [[ 'card, backend=3DDomain-0, buffer-size= =3D22050, short-name=3DVCard, long-name=3DVirtual sound card, sample-rates= =3D8000;11025;16000;22050;32000;44100;48000, sample-formats=3Ds16_le', 'pcm= , name=3Ddev1', 'stream, unique-id=3Dalsa, type=3DP' ]]

 

This is what I see when I play audio in Dom 0:<= /o:p>

 

amd@amd-Bilby-RV2:~$ aplay -v ~/SampleAudio/music.wa= v

Playing WAVE '/home/amd/SampleAudio/music.wav' : Sig= ned 16 bit Little Endian, Rate 44100 Hz, Stereo

ALSA <-> PulseAudio PCM I/O Plugin<= /p>

Its setup is:

  stream       : = PLAYBACK

  access       : = RW_INTERLEAVED

  format       : = S16_LE

  subformat    : STD<= /p>

  channels     : 2

  rate       = ;  : 44100

  exact rate   : 44100 (44100/1)=

  msbits       : = 16

  buffer_size  : 22050

  period_size  : 5512

  period_time  : 125000

  tstamp_mode  : NONE

  tstamp_type  : GETTIMEOFDAY

  period_step  : 1

  avail_min    : 5512=

  period_event : 0

  start_threshold  : 22050

  stop_threshold   : 22050=

  silence_threshold: 0

  silence_size : 0

  boundary     : 6206523236= 469964800

 

I have also tried giving buffer-size as 88200 (22050= * 2 channels * 2 bytes per sample), but still there is no audio from HVM g= uest.

 

What will be the right parameters based on the above= aplay information?

 

Below is the information obtained using –dump-= hw-params flag. Do I need to change vsnd parameters based on this informati= on?

 

amd@amd-Bilby-RV2:~$ aplay  ~/SampleAudio/music= .wav --dump-hw-params

Playing WAVE '/home/amd/SampleAudio/music.wav' : Sig= ned 16 bit Little Endian, Rate 44100 Hz, Stereo

HW Params of device "default":<= /p>

--------------------

ACCESS:  RW_INTERLEAVED

FORMAT:  U8 S16_LE S16_BE S24_LE S24_BE S32_LE = S32_BE FLOAT_LE FLOAT_BE MU_LAW A_LAW S24_3LE S24_3BE

SUBFORMAT:  STD

SAMPLE_BITS: [8 32]

FRAME_BITS: [8 1024]

CHANNELS: [1 32]

RATE: [1 384000]

PERIOD_TIME: (2 4294967295)

PERIOD_SIZE: [1 1398102)

PERIOD_BYTES: [128 1398102)

PERIODS: [3 1024]

BUFFER_TIME: (7 4294967295]

BUFFER_SIZE: [3 4194304]

BUFFER_BYTES: [384 4194304]

TICK_TIME: ALL

--------------------

 

Added Oleksandr Grytsov for help.

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB429727E2F53D906BCF38E3809F7F9DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Mon Sep 05 18:45:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 18:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399139.640202 (Exim 4.92) (envelope-from ) id 1oVH5k-00081z-0j; Mon, 05 Sep 2022 18:45:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399139.640202; Mon, 05 Sep 2022 18:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVH5j-00081s-Tr; Mon, 05 Sep 2022 18:45:03 +0000 Received: by outflank-mailman (input) for mailman id 399139; Mon, 05 Sep 2022 18:45:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVH5j-00081m-D0 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 18:45:03 +0000 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [2607:f8b0:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d924e6d8-2d4a-11ed-af93-0125da4c0113; Mon, 05 Sep 2022 20:45:02 +0200 (CEST) Received: by mail-pf1-x42b.google.com with SMTP id y29so9308161pfq.0 for ; Mon, 05 Sep 2022 11:45:02 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id u15-20020a170903124f00b00176ba091cd3sm1910534plh.196.2022.09.05.11.44.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Sep 2022 11:44:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d924e6d8-2d4a-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=bp7uubPhvNdLHMSt0aPBCCek7261kdyNq09tUdxS+hw=; b=piwDQu/IQn+iTyDmrFAKLLGug2/KVIY0wExpws2cTzWbVzQSAeP21bPvOiuaRqDs2W JQoerfe3i4QQz7Cj1GsYnZVIR1xKCKWMECDAl3eXr+TOFn09Ud17TXz2OPRBNMzXaQ00 bRAB2djvvnCoTXv68Ow/gDY8gNR87B3UphTOmg/nkljGpBLK2Kru1ca9zKlDPQvntNjO mMIzgSHR8yf5hPReChlBzaYVsZgAt1UFpnPZ3NTnb1GPzkwb3HG7zv/BZtSipedU5QQ3 aVcP2YbTWfY0XZEJvLhnxRCKUAZXjcy0d3SAOSR8rLFHgESMgNsb387q+JmPGxUvicyP hisw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=bp7uubPhvNdLHMSt0aPBCCek7261kdyNq09tUdxS+hw=; b=CpmZTDSiyUofPi0g9+3K8K1bWab53ZdKlCc+vZaEB/ekQ0kRxRKMBAFvB/tV7+tzxl lQZz2ATLPKlvdwrPRSav1ir9g3D8+28yw3ijMMI5s4kVtlEtiHg9bbEDBMEG2JyOKkko YA4Wt4uAGHMG6EktIBBmWvv3Ksa8uwh1SJvGs5m3Yo0E7NMucPupZ4QzsUg9LkzSv+37 VXsxf8TcMksSQEbU7oHYaHgMITOARAwrQrQGppya2ox4P3WzkBFBYteH2gGoclH4i3mA HmUnsTuHxzJjHQKYvmOU99LJTKb+Vtk2GeIQct2JW3aVbTyNbsVOPePmm7m3pwZho4qE bBMg== X-Gm-Message-State: ACgBeo1NKo0uToUR0TazW7Vtgr/2QfegJL3MFJ8n9ztri5iMNu+YAO0d 0AKufrfXf5uzjEbN2/M1vIM= X-Google-Smtp-Source: AA6agR5Z0n78WBJ+tl3rvbtMAHs4LRm2iBpVTL/7lQ4Vdk+FtE7G2db+zR5YWnYqEMH87O6DNCB35w== X-Received: by 2002:a65:6cc8:0:b0:3fe:2b89:cc00 with SMTP id g8-20020a656cc8000000b003fe2b89cc00mr43555470pgw.599.1662403500241; Mon, 05 Sep 2022 11:45:00 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications From: Nadav Amit In-Reply-To: <20220831101948.f3etturccmp5ovkl@suse.de> Date: Mon, 5 Sep 2022 11:44:55 -0700 Cc: Kent Overstreet , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Michal Hocko , Vlastimil Babka , Johannes Weiner , roman.gushchin@linux.dev, dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , Arnd Bergmann , jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Transfer-Encoding: quoted-printable Message-Id: <8EB7F2CE-2C8E-47EA-817F-6DE2D95F0A8B@gmail.com> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> To: Mel Gorman X-Mailer: Apple Mail (2.3696.120.41.1.1) On Aug 31, 2022, at 3:19 AM, Mel Gorman wrote: > On Wed, Aug 31, 2022 at 04:42:30AM -0400, Kent Overstreet wrote: >> On Wed, Aug 31, 2022 at 09:38:27AM +0200, Peter Zijlstra wrote: >>> On Tue, Aug 30, 2022 at 02:48:49PM -0700, Suren Baghdasaryan wrote: >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >>>> Code tagging framework >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >>>> Code tag is a structure identifying a specific location in the = source code >>>> which is generated at compile time and can be embedded in an = application- >>>> specific structure. Several applications of code tagging are = included in >>>> this RFC, such as memory allocation tracking, dynamic fault = injection, >>>> latency tracking and improved error code reporting. >>>> Basically, it takes the old trick of "define a special elf section = for >>>> objects of a given type so that we can iterate over them at = runtime" and >>>> creates a proper library for it. >>>=20 >>> I might be super dense this morning, but what!? I've skimmed through = the >>> set and I don't think I get it. >>>=20 >>> What does this provide that ftrace/kprobes don't already allow? >>=20 >> You're kidding, right? >=20 > It's a valid question. =46rom the description, it main addition that = would > be hard to do with ftrace or probes is catching where an error code is > returned. A secondary addition would be catching all historical state = and > not just state since the tracing started. >=20 > It's also unclear *who* would enable this. It looks like it would = mostly > have value during the development stage of an embedded platform to = track > kernel memory usage on a per-application basis in an environment where = it > may be difficult to setup tracing and tracking. Would it ever be = enabled > in production? Would a distribution ever enable this? If it's enabled, = any > overhead cannot be disabled/enabled at run or boot time so anyone = enabling > this would carry the cost without never necessarily consuming the = data. >=20 > It might be an ease-of-use thing. Gathering the information from = traces > is tricky and would need combining multiple different elements and = that > is development effort but not impossible. >=20 > Whatever asking for an explanation as to why equivalent functionality > cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. I would note that I have a solution in the making (which pretty much = works) for this matter, and does not require any kernel changes. It produces a call stack that leads to the code that lead to syscall failure. The way it works is by using seccomp to trap syscall failures, and then setting ftrace function filters and kprobes on conditional branches, indirect branch targets and function returns. Using symbolic execution, backtracking is performed and the condition = that lead to the failure is then pin-pointed. I hope to share the code soon. From xen-devel-bounces@lists.xenproject.org Mon Sep 05 19:16:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 19:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399146.640212 (Exim 4.92) (envelope-from ) id 1oVHZr-00030h-Fg; Mon, 05 Sep 2022 19:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399146.640212; Mon, 05 Sep 2022 19:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVHZr-00030a-Cm; Mon, 05 Sep 2022 19:16:11 +0000 Received: by outflank-mailman (input) for mailman id 399146; Mon, 05 Sep 2022 19:16:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVHZq-00030U-15 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 19:16:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ecc8dad-2d4f-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 21:16:04 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 455796146B; Mon, 5 Sep 2022 19:16:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7168DC433C1; Mon, 5 Sep 2022 19:15:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ecc8dad-2d4f-11ed-a016-b9edf5238543 Date: Mon, 5 Sep 2022 15:16:33 -0400 From: Steven Rostedt To: Nadav Amit Cc: Mel Gorman , Kent Overstreet , Peter Zijlstra , Suren Baghdasaryan , Andrew Morton , Michal Hocko , Vlastimil Babka , Johannes Weiner , roman.gushchin@linux.dev, dave@stgolabs.net, Matthew Wilcox , liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , Arnd Bergmann , jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux MM , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220905151633.04081816@gandalf.local.home> In-Reply-To: <8EB7F2CE-2C8E-47EA-817F-6DE2D95F0A8B@gmail.com> References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <8EB7F2CE-2C8E-47EA-817F-6DE2D95F0A8B@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 5 Sep 2022 11:44:55 -0700 Nadav Amit wrote: > I would note that I have a solution in the making (which pretty much works) > for this matter, and does not require any kernel changes. It produces a > call stack that leads to the code that lead to syscall failure. > > The way it works is by using seccomp to trap syscall failures, and then > setting ftrace function filters and kprobes on conditional branches, > indirect branch targets and function returns. Ooh nifty! > > Using symbolic execution, backtracking is performed and the condition that > lead to the failure is then pin-pointed. > > I hope to share the code soon. Looking forward to it. -- Steve From xen-devel-bounces@lists.xenproject.org Mon Sep 05 20:21:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 20:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399154.640224 (Exim 4.92) (envelope-from ) id 1oVIag-0001cT-88; Mon, 05 Sep 2022 20:21:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399154.640224; Mon, 05 Sep 2022 20:21:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIag-0001cM-4t; Mon, 05 Sep 2022 20:21:06 +0000 Received: by outflank-mailman (input) for mailman id 399154; Mon, 05 Sep 2022 20:21:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIae-0001cC-Bu; Mon, 05 Sep 2022 20:21:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIae-0001qL-8A; Mon, 05 Sep 2022 20:21:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIad-0006cI-Qd; Mon, 05 Sep 2022 20:21:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVIad-0001BQ-QB; Mon, 05 Sep 2022 20:21:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=867wq1VdFp9iPlgg6MXMn+KOIUHX05pSvBFddRcn+Aw=; b=R/2zPEpkEQM3wri+FkkKzdtg+W rPTQ+tnm6NU7Ir8CU+bE45bc5ZLIrdM0/DKBryIS+312la7+aAv18kOR+ZIQoCknkvMGr4XiAMumn 8DcPCtPGl+yiviZMej2svTGXIewdwDXme/grvciq2V80igOZVpsVEzJHPAcK5Rc+v1aA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173000: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Mon, 05 Sep 2022 20:21:03 +0000 flight 173000 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173000/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 33 days Failing since 172148 2022-08-04 21:39:38 Z 31 days 73 attempts Testing same since 172945 2022-09-02 23:10:19 Z 2 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 20:42:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 20:42:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399165.640235 (Exim 4.92) (envelope-from ) id 1oVIva-000480-5C; Mon, 05 Sep 2022 20:42:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399165.640235; Mon, 05 Sep 2022 20:42:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIva-00047t-29; Mon, 05 Sep 2022 20:42:42 +0000 Received: by outflank-mailman (input) for mailman id 399165; Mon, 05 Sep 2022 20:42:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIvX-00047U-Py for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 20:42:40 +0000 Received: from out2.migadu.com (out2.migadu.com [2001:41d0:2:aacc::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46f7c003-2d5b-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 22:42:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46f7c003-2d5b-11ed-a016-b9edf5238543 Date: Mon, 5 Sep 2022 16:42:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662410556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WiGoaCLsrAtGX5WjZ54R9ZEwhVpr8CfiS3GHCMjFnnI=; b=hnmt3aHZjiqk4ERDUnjQhKqTOVd36AXDvGfghBFkI6MlG+YAV38zdha6mLi0wPB8rg9d9p f+XQ8HrbJOiH4ZgK5Kz3JWnaEEtobK791M/A4ImHaFUKx2pGDzECdjOHQ8Ioeny6lWxRc5 3ffslWYfmfssKDR8OUSYZcd0xfFRct0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Suren Baghdasaryan Cc: Steven Rostedt , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220905204229.xqrqxmaax37n3ody@moria.home.lan> References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220905110713.27304149@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Mon, Sep 05, 2022 at 11:08:21AM -0700, Suren Baghdasaryan wrote: > On Mon, Sep 5, 2022 at 8:06 AM Steven Rostedt wrote: > > > > On Sun, 4 Sep 2022 18:32:58 -0700 > > Suren Baghdasaryan wrote: > > > > > Page allocations (overheads are compared to get_free_pages() duration): > > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > > 8.8% lookup_page_ext > > > 1237% call stack capture > > > 139% tracepoint with attached empty BPF program > > > > Have you tried tracepoint with custom callback? > > > > static void my_callback(void *data, unsigned long call_site, > > const void *ptr, struct kmem_cache *s, > > size_t bytes_req, size_t bytes_alloc, > > gfp_t gfp_flags) > > { > > struct my_data_struct *my_data = data; > > > > { do whatever } > > } > > > > [..] > > register_trace_kmem_alloc(my_callback, my_data); > > > > Now the my_callback function will be called directly every time the > > kmem_alloc tracepoint is hit. > > > > This avoids that perf and BPF overhead. > > Haven't tried that yet but will do. Thanks for the reference code! Is it really worth the effort of benchmarking tracing API overhead here? The main cost of a tracing based approach is going to to be the data structure for remembering outstanding allocations so that free events can be matched to the appropriate callsite. Regardless of whether it's done with BFP or by attaching to the tracepoints directly, that's going to be the main overhead. From xen-devel-bounces@lists.xenproject.org Mon Sep 05 20:45:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 20:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399172.640246 (Exim 4.92) (envelope-from ) id 1oVIxz-0004j9-I0; Mon, 05 Sep 2022 20:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399172.640246; Mon, 05 Sep 2022 20:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIxz-0004j2-EQ; Mon, 05 Sep 2022 20:45:11 +0000 Received: by outflank-mailman (input) for mailman id 399172; Mon, 05 Sep 2022 20:45:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVIxy-0004iw-18 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 20:45:10 +0000 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0e2e59b-2d5b-11ed-a016-b9edf5238543; Mon, 05 Sep 2022 22:45:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0e2e59b-2d5b-11ed-a016-b9edf5238543 Date: Mon, 05 Sep 2022 20:44:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1662410707; x=1662669907; bh=dQoZ+1WqtrwsZUeYC0cUYMAtoO/JqTs5qGSoqcwbBYY=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=iAfzAoJZrSiTxNNjGNmTi3wHMT8Quw5iiHJMv8T8vN2y2BnXRHAi7yAxUgXZ6tOCx W4MVkaXzRPHMSb7mwJ24nVnkQmDIO0zp5/x9cN90eKoqEMHXU2bvF4bIMMxaTq6oon EvQRu2dOiwllArI1pdnz58tuvFmeY8buT7SAZKqw3tyMDrqH6PhHxNHWWdnZUT2z+P YXGrN3cUc/f/mCeb6j6uuxuNLUGV401J/2aiAXAjpOXunKIaiI9sdDdijqtcm6YWEr nK/G9olb0N7tJA7/jQ5MIX8tnMqHttVnZdf6mqF/eZYgAMQr7fblFeeRm35FCK4QhE Wy2xXjDohVfFw== To: jbeulich@suse.com From: Dylanger Daly Cc: xen-devel@lists.xenproject.org, Andrew.Cooper3@citrix.com Reply-To: Dylanger Daly Subject: Re: Ryzen 6000 (Mobile) Message-ID: In-Reply-To: <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> References: <55eb8485-0c0d-51cd-c9b8-d517994ec6c6@suse.com> <7807b9cf-a09e-a393-ee7a-dc220a68e56e@suse.com> <3b2ad2ca-3c6c-4dcb-c603-bd5440350f20@suse.com> <2dHPPtixTlkUXYEzNPFRI4ezKHSe1A2VaThMjBpd1aM3NFkZQuyRdfmNWCigm1oXfdKhOwDJGoPBBIMLYtYhQlENV2eFVZ0G9EMOMj5e6UE=@protonmail.com> <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_FDcUmKLDuvCfnQE1xiOCBvZ7ASZpXmWsh7j4rwEXXcA" This is a multi-part message in MIME format. --b1_FDcUmKLDuvCfnQE1xiOCBvZ7ASZpXmWsh7j4rwEXXcA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkgSmFuLAoKSSd2ZSBtYW5hZ2VkIHRvIGZpbmFuZ2xlIGEgdmVyeSB1bnN0YWJsZSBlbnZpcm9u bWVudCB0b2dldGhlcgoKV2hhdCBJJ20gc2VlaW5nIGlzIHRoZSBmb2xsb3dpbmc6CgoxLiBBbGwg YXBwVk1zIGluY2x1ZGluZyBkb20wIG11c3QgaGF2ZSAxIGNvcmUgYXNzaWduZWQKMi4gVGhpcyBt ZWFucyBJJ20gYWJsZSB0byBsYXVuY2ggNCBhcHBWTXMsIGFzIHNvb24gYXMgSSBsYXVuY2ggYSA1 dGgsIGl0IHB1dHMgYWxsIFBDSWUgZGV2aWNlcyBpbnRvIGEgYmFkIHN0YXRlCjMuIElmIEkgc2h1 dCB0aGUgNXRoIFZNIGRvd24sIEknbSBhYmxlIHRvIHJlc3RhcnQgc3lzLXVzYiBmb3IgZXhhbXBs ZSBhbmQgInJlY292ZXIiIHRoZSBVU0IgQ29udHJvbGxlci4KCkknbSBub3Qg8J+SryBidXQgSSB0 aGluayB0aGlzIG1lYW5zIGl0J3MgYSBzY2hlZHVsaW5nL2NvcmUgaXNzdWU/CgpJdCBhbG1vc3Qg d29ya3Mg8J+kpuKAjeKZgu+4jwoKQ2hlZXJz --b1_FDcUmKLDuvCfnQE1xiOCBvZ7ASZpXmWsh7j4rwEXXcA Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 SGkgSmFuLDxicj48YnI+SSd2ZSBtYW5hZ2VkIHRvIGZpbmFuZ2xlIGEgdmVyeSB1bnN0YWJsZSBl bnZpcm9ubWVudCB0b2dldGhlcjxicj48YnI+V2hhdCBJJ20gc2VlaW5nIGlzIHRoZSBmb2xsb3dp bmc6PGJyPjxicj4xLiBBbGwgYXBwVk1zIGluY2x1ZGluZyBkb20wIG11c3QgaGF2ZSAxIGNvcmUg YXNzaWduZWQ8YnI+Mi4gVGhpcyBtZWFucyBJJ20gYWJsZSB0byBsYXVuY2ggNCBhcHBWTXMsIGFz IHNvb24gYXMgSSBsYXVuY2ggYSA1dGgsIGl0IHB1dHMgYWxsIFBDSWUgZGV2aWNlcyBpbnRvIGEg YmFkIHN0YXRlPGJyPjMuIElmIEkgc2h1dCB0aGUgNXRoIFZNIGRvd24sIEknbSBhYmxlIHRvIHJl c3RhcnQgc3lzLXVzYiBmb3IgZXhhbXBsZSBhbmQgInJlY292ZXIiIHRoZSBVU0IgQ29udHJvbGxl ci48YnI+PGJyPkknbSBub3Qg8J+SryBidXQgSSB0aGluayB0aGlzIG1lYW5zIGl0J3MgYSBzY2hl ZHVsaW5nL2NvcmUgaXNzdWU/PGJyPjxicj5JdCBhbG1vc3Qgd29ya3Mg8J+kpuKAjeKZgu+4jzxi cj48YnI+Q2hlZXJz --b1_FDcUmKLDuvCfnQE1xiOCBvZ7ASZpXmWsh7j4rwEXXcA-- From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:08:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399180.640256 (Exim 4.92) (envelope-from ) id 1oVKGc-0004Kc-Ip; Mon, 05 Sep 2022 22:08:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399180.640256; Mon, 05 Sep 2022 22:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKGc-0004KV-Fd; Mon, 05 Sep 2022 22:08:30 +0000 Received: by outflank-mailman (input) for mailman id 399180; Mon, 05 Sep 2022 22:08:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKGb-0004KL-21; Mon, 05 Sep 2022 22:08:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKGa-0003fa-Sv; Mon, 05 Sep 2022 22:08:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKGa-0005vW-Go; Mon, 05 Sep 2022 22:08:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVKGa-0000BI-GJ; Mon, 05 Sep 2022 22:08:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dIY/SrN+o62wEUzLT08oZW625/8Jr2MAvld5UXRiNtM=; b=rLdZtWxNomOBHa7tQTRyTIIl+0 hMU2Ct3D32u37V8/gc9CEOyMNRa/EKnEA9AV4rsCulxpwTJ8oLmaIRTzdHxGsReEfOoL1XbegrplM k8/jQ83A6W3Tp00sVImzkWjAyYGea5Zg6W/k/2pRMY74rT9JJ5cZ+Z8PBkr33SYQaQmI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173009: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=c05a218a9758225ddf94eedb365633f2154551da X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 05 Sep 2022 22:08:28 +0000 flight 173009 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173009/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf c05a218a9758225ddf94eedb365633f2154551da baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 32 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 249 attempts Testing same since 173009 2022-09-05 15:47:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1685 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:16:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:16:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399188.640268 (Exim 4.92) (envelope-from ) id 1oVKOH-0005n0-DJ; Mon, 05 Sep 2022 22:16:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399188.640268; Mon, 05 Sep 2022 22:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKOH-0005mt-AS; Mon, 05 Sep 2022 22:16:25 +0000 Received: by outflank-mailman (input) for mailman id 399188; Mon, 05 Sep 2022 22:16:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKOF-0005ml-Ll for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:16:23 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e5434f1-2d68-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 00:16:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5612C60AFF; Mon, 5 Sep 2022 22:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D5E2C433C1; Mon, 5 Sep 2022 22:16:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e5434f1-2d68-11ed-af93-0125da4c0113 Date: Mon, 5 Sep 2022 18:16:50 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Suren Baghdasaryan , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220905181650.71e9d02c@gandalf.local.home> In-Reply-To: <20220905204229.xqrqxmaax37n3ody@moria.home.lan> References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220905110713.27304149@gandalf.local.home> <20220905204229.xqrqxmaax37n3ody@moria.home.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 5 Sep 2022 16:42:29 -0400 Kent Overstreet wrote: > > Haven't tried that yet but will do. Thanks for the reference code! > > Is it really worth the effort of benchmarking tracing API overhead here? > > The main cost of a tracing based approach is going to to be the data structure > for remembering outstanding allocations so that free events can be matched to > the appropriate callsite. Regardless of whether it's done with BFP or by > attaching to the tracepoints directly, that's going to be the main overhead. The point I was making here is that you do not need your own hooking mechanism. You can get the information directly by attaching to the tracepoint. > > static void my_callback(void *data, unsigned long call_site, > > const void *ptr, struct kmem_cache *s, > > size_t bytes_req, size_t bytes_alloc, > > gfp_t gfp_flags) > > { > > struct my_data_struct *my_data = data; > > > > { do whatever } > > } The "do whatever" is anything you want to do. Or is the data structure you create with this approach going to be too much overhead? How hard is it for a hash or binary search lookup? -- Steve From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:17:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399195.640279 (Exim 4.92) (envelope-from ) id 1oVKOw-0006Jz-MW; Mon, 05 Sep 2022 22:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399195.640279; Mon, 05 Sep 2022 22:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKOw-0006Jq-JO; Mon, 05 Sep 2022 22:17:06 +0000 Received: by outflank-mailman (input) for mailman id 399195; Mon, 05 Sep 2022 22:17:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKOv-0006Jg-7G for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:17:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKOt-0003p0-VZ; Mon, 05 Sep 2022 22:17:03 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVKOt-0003RB-MM; Mon, 05 Sep 2022 22:17:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=EBOdudOT+xgYsvdRtEirddTv/VOttgYvsDpfbVGGTC4=; b=3VTa6TugWE6I3NO8NnRyKE6iCZ Bs/OHhJCxZ7jx5Al3CX74BzAfQ7shR+OLa8rHatyfvCWaXaHQV1M69RSasxvJpInT/JuL7wKpK6Yk bqCqhABK3cAiiW6fy80yf65WPwtunk2+MI0Hay8Hl3uxwekLz7H1aojWzglofgumSMUs=; Message-ID: <4627ccd9-8a0a-d63d-6672-7a14c8605179@xen.org> Date: Mon, 5 Sep 2022 23:17:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Andrew Cooper References: <20220818105601.1896082-1-jens.wiklander@linaro.org> <20220818105601.1896082-4-jens.wiklander@linaro.org> From: Julien Grall Subject: Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator In-Reply-To: <20220818105601.1896082-4-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, On 18/08/2022 11:55, Jens Wiklander wrote: > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > Partition in secure world. > > This commit brings in only the parts needed to negotiate FF-A version > number with guest and SPMC. > > A guest configuration variable "ffa_enabled" is used to indicate if a guest > is trusted to use FF-A. > > This is loosely based on the TEE mediator framework and the OP-TEE > mediator. > > [1] https://developer.arm.com/documentation/den0077/latest > Signed-off-by: Jens Wiklander > --- > SUPPORT.md | 7 + > docs/man/xl.cfg.5.pod.in | 15 ++ > tools/include/libxl.h | 6 + > tools/libs/light/libxl_arm.c | 3 + > tools/libs/light/libxl_types.idl | 1 + > tools/xl/xl_parse.c | 3 + > xen/arch/arm/Kconfig | 11 + > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain.c | 10 + > xen/arch/arm/domain_build.c | 1 + > xen/arch/arm/ffa.c | 354 ++++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/domain.h | 4 + > xen/arch/arm/include/asm/ffa.h | 71 ++++++ > xen/arch/arm/vsmc.c | 17 +- > xen/include/public/arch-arm.h | 2 + > 15 files changed, 503 insertions(+), 3 deletions(-) > create mode 100644 xen/arch/arm/ffa.c > create mode 100644 xen/arch/arm/include/asm/ffa.h > > diff --git a/SUPPORT.md b/SUPPORT.md > index 70e98964cbc0..215bb3c9043b 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > > No support for QEMU backends in a 16K or 64K domain. > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > + > + Status, Arm64: Tech Preview > + > +There are still some code paths where a vCPU may hog a pCPU longer than > +necessary. The FF-A mediator is not yet implemented for Arm32. > + > ### ARM: Guest Device Tree support > > Status: Supported > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index b98d1613987e..234c036aecb1 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1616,6 +1616,21 @@ This feature is a B. > > =back > > +=item B > + > +B Allow a guest to communicate via FF-A with Secure Partitions > +(SP), default false. > + > +Currently is only a small subset of the FF-A specification supported. Just > +enough to communicate with OP-TEE. In general all the basic things and > +sharing memory with one SP. More advanced use cases where memory might be > +shared or donated to multple SPs is not supported. > + > +See L for more > +informantion about FF-A. > + > +This feature is a B. > + > =head2 Paravirtualised (PV) Guest Specific Options > > The following options apply only to Paravirtual (PV) guests. > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index 7ce978e83c9a..4ab5a7b044d6 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -278,6 +278,12 @@ > */ > #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 > > +/* > + * LIBXL_HAVE_BUILDINFO_ARM_FFA_ENABLED indicates that > + * libxl_domain_build_info has the arm.ffa_enabled field. > + */ > +#define LIBXL_HAVE_BUILDINFO_ARM_FFA_ENABLED 1 > + > /* > * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing > * 'soft reset' for domains and there is 'soft_reset' shutdown reason > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de093914..a985609861c7 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + config->arch.ffa_enabled = > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > + > return 0; > } > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index 2a42da2f7d78..bf4544bef399 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > ("vuart", libxl_vuart_type), > + ("ffa_enabled", libxl_defbool), > ])), > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > ])), > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index b98c0de378b6..e0e99ed8d2b1 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2746,6 +2746,9 @@ skip_usbdev: > exit(-ERROR_FAIL); > } > } > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > + xlu_cfg_get_defbool(config, "ffa_enabled", > + &b_info->arch_arm.ffa_enabled, 0); > > parse_vkb_list(config, d_config); > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index be9eff014120..e57e1d3757e2 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -139,6 +139,17 @@ config TEE > > source "arch/arm/tee/Kconfig" > > +config FFA > + bool "Enable FF-A mediator support" if EXPERT > + default n > + depends on ARM_64 > + help > + This option enables a minimal FF-A mediator. The mediator is > + generic as it follows the FF-A specification [1], but it only > + implements a small subset of the specification. > + > + [1] https://developer.arm.com/documentation/den0077/latest > + > endmenu > > menu "ARM errata workaround via the alternative framework" > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index bb7a6151c13c..af0c69f793d4 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -20,6 +20,7 @@ obj-y += domain_build.init.o > obj-y += domctl.o > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > obj-y += efi/ > +obj-$(CONFIG_FFA) += ffa.o > obj-y += gic.o > obj-y += gic-v2.o > obj-$(CONFIG_GICV3) += gic-v3.o > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 8110c1df8638..a3f00e7e234d 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) > goto fail; > > + if ( (rc = ffa_domain_init(d, config->arch.ffa_enabled)) != 0 ) > + goto fail; > + > update_domain_wallclock_time(d); > > /* > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) > enum { > PROG_pci = 1, > PROG_tee, > + PROG_ffa, > PROG_xen, > PROG_page, > PROG_mapping, > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) > > PROGRESS(tee): > ret = tee_relinquish_resources(d); > + if ( ret ) > + return ret; > + > + PROGRESS(ffa): > + ret = ffa_relinquish_resources(d); > if (ret ) > return ret; > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7ddd16c26da5..d708f76356f7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > if ( gic_number_lines() > 992 ) > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > dom0_cfg.arch.tee_type = tee_get_type(); > + dom0_cfg.arch.ffa_enabled = true; > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > if ( iommu_enabled ) > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > new file mode 100644 > index 000000000000..b85c492928d2 > --- /dev/null > +++ b/xen/arch/arm/ffa.c > @@ -0,0 +1,354 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > + * > + * Copyright (C) 2022 Linaro Limited > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms and conditions of the GNU General Public > + * License, version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public > + * License along with this program; If not, see . > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +/* Error codes */ > +#define FFA_RET_OK 0 > +#define FFA_RET_NOT_SUPPORTED -1 > +#define FFA_RET_INVALID_PARAMETERS -2 > +#define FFA_RET_NO_MEMORY -3 > +#define FFA_RET_BUSY -4 > +#define FFA_RET_INTERRUPTED -5 > +#define FFA_RET_DENIED -6 > +#define FFA_RET_RETRY -7 > +#define FFA_RET_ABORTED -8 > + > +/* FFA_VERSION helpers */ > +#define FFA_VERSION_MAJOR_SHIFT 16U > +#define FFA_VERSION_MAJOR_MASK 0x7FFFU > +#define FFA_VERSION_MINOR_SHIFT 0U > +#define FFA_VERSION_MINOR_MASK 0xFFFFU > +#define MAKE_FFA_VERSION(major, minor) \ > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > + ((minor) & FFA_VERSION_MINOR_MASK)) > + > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > + > +/* > + * This is the version we want to use in communication with guests and SPs. > + * During negotiation with a guest or a SP we may need to lower it for > + * that particular guest or SP. > + */ > +#define FFA_MY_VERSION_MAJOR 1U > +#define FFA_MY_VERSION_MINOR 1U > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > + FFA_MY_VERSION_MINOR) > + > +#define FFA_PAGE_SIZE SZ_4K > + > +/* > + * Limit for shared buffer size. Please note that this define limits > + * number of pages. But user buffer can be not aligned to a page > + * boundary. So it is possible that user would not be able to share > + * exactly MAX_SHM_BUFFER_PG * PAGE_SIZE bytes. > + * > + * FF-A doesn't have any direct requirments on GlobalPlatform or vice > + * versa, but an implementation can very well use FF-A in order to provide > + * a GlobalPlatform interface on top. > + * > + * Global Platform specification for TEE requires that any TEE > + * implementation should allow to share buffers with size of at least > + * 512KB, which equals to 128 4kB pages. Due to align issue mentioned > + * above, we need to increase this value to 129. > + */ > +#define FFA_MAX_SHM_PAGE_COUNT 129 > + > +/* > + * Limits the number of shared buffers that guest can have at once. This > + * is to prevent case, when guests tricks XEN into exhausting its own > + * memory by allocating many small buffers. This value has been chosen > + * arbitrary. > + */ > +#define FFA_MAX_SHM_COUNT 32 > + > +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) > + > +/* Memory attributes: Normal memory, Write-Back cacheable, Inner shareable */ > +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU > + > +/* Memory access permissions: Read-write */ > +#define FFA_MEM_ACC_RW 0x2U > + > +/* Clear memory before mapping in receiver */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > +/* Relayer may time slice this operation */ > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > +/* Clear memory after receiver relinquishes it */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > + > +/* Share memory transaction */ > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) > + > +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL > + > +/* Framework direct request/response */ > +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > +#define FFA_MSG_TYPE_MASK 0xFFU; > +#define FFA_MSG_PSCI 0x0U > +#define FFA_MSG_SEND_VM_CREATED 0x4U > +#define FFA_MSG_RESP_VM_CREATED 0x5U > +#define FFA_MSG_SEND_VM_DESTROYED 0x6U > +#define FFA_MSG_RESP_VM_DESTROYED 0x7U > + > +/* > + * Flags used for the FFA_PARTITION_INFO_GET return message: > + * BIT(0): Supports receipt of direct requests > + * BIT(1): Can send direct requests > + * BIT(2): Can send and receive indirect messages > + * BIT(3): Supports receipt of notifications > + * BIT(4-5): Partition ID is a PE endpoint ID > + */ > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) > +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) > + > +/* > + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition > + * count only. > + */ > +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) > + > +/* Function IDs */ > +#define FFA_ERROR 0x84000060U > +#define FFA_SUCCESS_32 0x84000061U > +#define FFA_SUCCESS_64 0xC4000061U > +#define FFA_INTERRUPT 0x84000062U > +#define FFA_VERSION 0x84000063U > +#define FFA_FEATURES 0x84000064U > +#define FFA_RX_ACQUIRE 0x84000084U > +#define FFA_RX_RELEASE 0x84000065U > +#define FFA_RXTX_MAP_32 0x84000066U > +#define FFA_RXTX_MAP_64 0xC4000066U > +#define FFA_RXTX_UNMAP 0x84000067U > +#define FFA_PARTITION_INFO_GET 0x84000068U > +#define FFA_ID_GET 0x84000069U > +#define FFA_SPM_ID_GET 0x84000085U > +#define FFA_MSG_WAIT 0x8400006BU > +#define FFA_MSG_YIELD 0x8400006CU > +#define FFA_MSG_RUN 0x8400006DU > +#define FFA_MSG_SEND2 0x84000086U > +#define FFA_MSG_SEND_DIRECT_REQ_32 0x8400006FU > +#define FFA_MSG_SEND_DIRECT_REQ_64 0xC400006FU > +#define FFA_MSG_SEND_DIRECT_RESP_32 0x84000070U > +#define FFA_MSG_SEND_DIRECT_RESP_64 0xC4000070U > +#define FFA_MEM_DONATE_32 0x84000071U > +#define FFA_MEM_DONATE_64 0xC4000071U > +#define FFA_MEM_LEND_32 0x84000072U > +#define FFA_MEM_LEND_64 0xC4000072U > +#define FFA_MEM_SHARE_32 0x84000073U > +#define FFA_MEM_SHARE_64 0xC4000073U > +#define FFA_MEM_RETRIEVE_REQ_32 0x84000074U > +#define FFA_MEM_RETRIEVE_REQ_64 0xC4000074U > +#define FFA_MEM_RETRIEVE_RESP 0x84000075U > +#define FFA_MEM_RELINQUISH 0x84000076U > +#define FFA_MEM_RECLAIM 0x84000077U > +#define FFA_MEM_FRAG_RX 0x8400007AU > +#define FFA_MEM_FRAG_TX 0x8400007BU > +#define FFA_MSG_SEND 0x8400006EU > +#define FFA_MSG_POLL 0x8400006AU > + > +struct ffa_ctx { > + uint32_t guest_vers; > +}; > + > +/* Negotiated FF-A version to use with the SPMC */ > +static uint32_t ffa_version __read_mostly; > + > +static bool ffa_get_version(uint32_t *vers) > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_VERSION, > + .a1 = FFA_MY_VERSION, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > + { > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > + return false; > + } > + > + *vers = resp.a0; > + > + return true; > +} > + > +static u16 get_vm_id(const struct domain *d) > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; > +} > + > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > + register_t v2, register_t v3, register_t v4, register_t v5, > + register_t v6, register_t v7) > +{ > + set_user_reg(regs, 0, v0); > + set_user_reg(regs, 1, v1); > + set_user_reg(regs, 2, v2); > + set_user_reg(regs, 3, v3); > + set_user_reg(regs, 4, v4); > + set_user_reg(regs, 5, v5); > + set_user_reg(regs, 6, v6); > + set_user_reg(regs, 7, v7); > +} > + > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > + uint32_t w3) > +{ > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > +} > + > +static void handle_version(struct cpu_user_regs *regs) > +{ > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + uint32_t vers = get_user_reg(regs, 1); > + > + if ( vers < FFA_VERSION_1_1 ) > + vers = FFA_VERSION_1_0; > + else > + vers = FFA_VERSION_1_1; > + > + ctx->guest_vers = vers; > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > +} > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > +{ > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + > + if ( !ctx ) > + return false; > + > + switch ( fid ) > + { > + case FFA_VERSION: > + handle_version(regs); > + return true; > + case FFA_ID_GET: > + set_regs_success(regs, get_vm_id(d), 0); > + return true; > + > + default: > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); > + return false; > + } > +} > + > +int ffa_domain_init(struct domain *d, bool ffa_enabled) > +{ > + struct ffa_ctx *ctx; > + > + if ( !ffa_version || !ffa_enabled ) AFAIU, this check means that even if the admin requested to enable FFA for the domain, it may not be honored. If that's the case, then I am afraid this is not a desired approach because this issue will only get noticed after the OS has booted. We should return an error if the domain has requested an unavaible feature. > + return 0; > + > + ctx = xzalloc(struct ffa_ctx); > + if ( !ctx ) > + return -ENOMEM; > + > + d->arch.ffa = ctx; > + > + return 0; > +} > + > +int ffa_relinquish_resources(struct domain *d) This is called from domain_relinquish_resources(). However... > +{ > + struct ffa_ctx *ctx = d->arch.ffa; > + > + if ( !ctx ) > + return 0; > + > + XFREE(d->arch.ffa); ... the allocation of FFA is happening in arch_domain_create(). In case of early failure, the relinquish helper will not be called. You want to split this function in two parts: 1) ffa_domain_destroy() -> This will be freeing anything that was allocated by ffa_domain_init() and will be called from arch_domain_destroy(). 2) ffa_relinquish_resources() -> This will be freeing any resources allocated afterwards. The former will not preemptible while the latter will. Which should be fine because arch_domain_init() and therefore arch_domain_free() should never contain long running operations. > + > + return 0; > +} > + > +static int __init ffa_init(void) > +{ > + uint32_t vers; > + unsigned int major_vers; > + unsigned int minor_vers; > + > + /* > + * FFA_PAGE_SIZE is defined to 4k and we're currently depending on > + * using that page size. > + */ > + BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE); > + > + /* > + * psci_init_smccc() updates this value with what's reported by EL-3 > + * or secure world. > + */ > + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) > + { > + printk(XENLOG_ERR > + "ffa: unsupported SMCCC version %#x (need at least %#x)\n", > + smccc_ver, ARM_SMCCC_VERSION_1_2); > + return 0; > + } > + > + if ( !ffa_get_version(&vers) ) > + return 0; > + > + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) > + { > + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers); > + return 0; > + } > + > + major_vers = (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR_MASK; > + minor_vers = vers & FFA_VERSION_MINOR_MASK; > + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", > + FFA_MY_VERSION_MAJOR, FFA_MY_VERSION_MINOR); > + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > + major_vers, minor_vers); > + > + ffa_version = vers; > + > + return 0; > +} > + > +__initcall(ffa_init); > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > index ed63c2b6f91f..b3dee269bced 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -103,6 +103,10 @@ struct arch_domain > void *tee; > #endif > > +#ifdef CONFIG_FFA > + void *ffa; > +#endif > + > bool directmap; > } __cacheline_aligned; > > diff --git a/xen/arch/arm/include/asm/ffa.h b/xen/arch/arm/include/asm/ffa.h > new file mode 100644 > index 000000000000..4f4a739345bd > --- /dev/null > +++ b/xen/arch/arm/include/asm/ffa.h > @@ -0,0 +1,71 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A(FFA) mediator > + * > + * Copyright (C) 2021 Linaro Limited > + * > + * Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without restriction, > + * including without limitation the rights to use, copy, modify, merge, > + * publish, distribute, sublicense, and/or sell copies of the Software, > + * and to permit persons to whom the Software is furnished to do so, > + * subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef __ASM_ARM_FFA_H__ > +#define __ASM_ARM_FFA_H__ > + > +#include > + > +#include > +#include > + > +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) > +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) > + > +static inline bool is_ffa_fid(uint32_t fid) > +{ > + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; > + > + return fn >= FFA_FNUM_MIN_VALUE && fn <= FFA_FNUM_MAX_VALUE; > +} > + > +#ifdef CONFIG_FFA > +#define FFA_NR_FUNCS 11 You wrote 11 here, but you seem only expose 2 in this patch. However, AFAICT the call count is deprected in SMCCC v1.2. So do we need to update it? But if it is not deprecated then... > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid); > +int ffa_domain_init(struct domain *d, bool ffa_enabled); > +int ffa_relinquish_resources(struct domain *d); > +#else > +#define FFA_NR_FUNCS 0 > + > +static inline bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > +{ > + return false; > +} > + > +static inline int ffa_domain_init(struct domain *d, bool ffa_enabled) > +{ > + return 0; For the same reason as above, this should return -ENODEV if ffa_enabled is true. > +} > + > +static inline int ffa_relinquish_resources(struct domain *d) > +{ > + return 0; > +} > +#endif > + > +#endif /*__ASM_ARM_FFA_H__*/ > diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c > index 6f90c08a6304..34586025eff8 100644 > --- a/xen/arch/arm/vsmc.c > +++ b/xen/arch/arm/vsmc.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -32,7 +33,7 @@ > #define XEN_SMCCC_FUNCTION_COUNT 3 > > /* Number of functions currently supported by Standard Service Service Calls. */ > -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) > +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) ... it seems incorrect to me add FFA_NR_FUNCS unconditionally because while the hypervisor may support FFA, the guest may not have access to it. > > static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) > { > @@ -196,13 +197,23 @@ static bool handle_existing_apis(struct cpu_user_regs *regs) > return do_vpsci_0_1_call(regs, fid); > } > > +static bool is_psci_fid(uint32_t fid) > +{ > + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; > + > + return fn >= 0 && fn <= 0x1fU; > +} > + > /* PSCI 0.2 interface and other Standard Secure Calls */ > static bool handle_sssc(struct cpu_user_regs *regs) > { > uint32_t fid = (uint32_t)get_user_reg(regs, 0); > > - if ( do_vpsci_0_2_call(regs, fid) ) > - return true; > + if ( is_psci_fid(fid) ) > + return do_vpsci_0_2_call(regs, fid); > + > + if ( is_ffa_fid(fid) ) > + return ffa_handle_call(regs, fid); > > switch ( fid ) > { > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index ab05fe12b0de..53f8d44a6a8e 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -318,6 +318,8 @@ struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > /* IN */ > + uint8_t ffa_enabled; AFAIU, this will be 0/1. We have a 'flags' in common but not in arch. I don't think we should use the common one (I don't think FFA will be ever used on x86?). So I would introduce a new field flag in xen-arch_domainconfig. Also AFAICT, XEN_DOMCTL_INTERFACE_VERSION has already been bumped for 4.17. So we should not need to do it in this patch. However, if this is not going to merged in 4.17, then you will need to bump the domctl version (assuming this is the first patch touch the domctl after the release). > + /* IN */ > uint16_t tee_type; > /* IN */ > uint32_t nr_spis; -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:17:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399198.640290 (Exim 4.92) (envelope-from ) id 1oVKPI-0006ox-3u; Mon, 05 Sep 2022 22:17:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399198.640290; Mon, 05 Sep 2022 22:17:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKPI-0006oq-0k; Mon, 05 Sep 2022 22:17:28 +0000 Received: by outflank-mailman (input) for mailman id 399198; Mon, 05 Sep 2022 22:17:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKPH-0006nC-1v for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:17:27 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85316080-2d68-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 00:17:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7BFFB81118; Mon, 5 Sep 2022 22:17:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25FF2C433D6; Mon, 5 Sep 2022 22:17:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85316080-2d68-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662416243; bh=BDxNCKqD202DtOlDDp0107b8qH36zNff1JZExZDyU4Y=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EOLXwLX87BKRwz85nHVPuPx2FI3ka/aSyKU7U1uWJhBYnuNOVu61LaXOKRDJYZRTE 51Sxg3pM0V0x4ERvBUWGuttJbfIGbq7x1kYewet1RxrrFLKiBMf/aWWu5X4ARx19YF 6eji5Ceh6aykBKY+fSbbyPo9HgNxh/j6GTczNtZndwrZ2/kcbpNkuz/g/fWEB1gfj9 +y636yLfAHbP0VLz0+HxPfGM6GCGq6QT+UfEBa5XOjAlmhjlx5M6ntFCuK8dxFMJ1W bTpn9hTAR+XYDCPWgT4WPzooQauRI3egfYQx7GxCz+kbOfo5BQCL6d0SuNMqzzZQvP CTZX6pzcxE7Qw== Date: Mon, 5 Sep 2022 15:17:22 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Bertrand Marquis , Rahul Singh , Stefano Stabellini , xen-devel , Zhou Wang , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v2 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer In-Reply-To: <8ae636bb-9508-9477-af0e-d30440782dbf@xen.org> Message-ID: References: <59c24309e2d8494edf414904fe9725b4e7387098.1662123432.git.rahul.singh@arm.com> <5f0bf815-3236-2262-62b4-cd3d99bb60ff@xen.org> <71FC45C0-2F78-4CB7-AAB7-5B2C357F2C74@arm.com> <8ae636bb-9508-9477-af0e-d30440782dbf@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1967879923-1662416243=:3931" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1967879923-1662416243=:3931 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 5 Sep 2022, Julien Grall wrote: > On 05/09/2022 11:23, Bertrand Marquis wrote: > > > On 5 Sep 2022, at 10:31, Julien Grall wrote: > > > On 05/09/2022 10:18, Rahul Singh wrote: > > > > > On 3 Sep 2022, at 12:21 am, Stefano Stabellini > > > > > wrote: > > > > > > > > > > On Fri, 2 Sep 2022, Rahul Singh wrote: > > > > > > From: Zhou Wang > > > > > > > > > > > > Backport Linux commit a76a37777f2c. This is the clean backport > > > > > > without > > > > > > any changes. > > > > > > > > > > > > Reading the 'prod' MMIO register in order to determine whether or > > > > > > not there is valid data beyond 'cons' for a given queue does not > > > > > > provide sufficient dependency ordering, as the resulting access is > > > > > > address dependent only on 'cons' and can therefore be speculated > > > > > > ahead of time, potentially allowing stale data to be read by the > > > > > > CPU. > > > > > > > > > > > > Use readl() instead of readl_relaxed() when updating the shadow copy > > > > > > of the 'prod' pointer, so that all speculated memory reads from the > > > > > > corresponding queue can occur only from valid slots. > > > > > > > > > > > > Signed-off-by: Zhou Wang > > > > > > Link: > > > > > > https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com > > > > > > [will: Use readl() instead of explicit barrier. Update 'cons' side > > > > > > to match.] > > > > > > Signed-off-by: Will Deacon > > > > > > Origin: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > > > > a76a37777f2c > > > > > > Signed-off-by: Rahul Singh > > > > > > --- > > > > > > Changes in v2: > > > > > > - fix commit msg > > > > > > - add _iomb changes also from the origin patch > > > > > > --- > > > > > > xen/arch/arm/include/asm/system.h | 1 + > > > > > > xen/drivers/passthrough/arm/smmu-v3.c | 11 +++++++++-- > > > > > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/xen/arch/arm/include/asm/system.h > > > > > > b/xen/arch/arm/include/asm/system.h > > > > > > index 65d5c8e423..fe27cf8c5e 100644 > > > > > > --- a/xen/arch/arm/include/asm/system.h > > > > > > +++ b/xen/arch/arm/include/asm/system.h > > > > > > @@ -29,6 +29,7 @@ > > > > > > #endif > > > > > > > > > > > > #define smp_wmb() dmb(ishst) > > > > > > +#define __iomb() dmb(osh) > > > > > > > > > > We don't have any other #define starting with __ in system.h. > > > > > I wonder if we should call this macro differently or simply iomb(). > > > > I think either iomb() or dma_mb() will be the right name. > > > > Please let me know your view on this. > > > > > > It is not 100% clear why Linux went with __iomb() rather than iomb(). But > > > I would prefer to keep the __* version to match Linux. > > > > > > If the others really want to drop the __. Then I think it should be name > > > iomb(). The rationale is while __iomb() is an alias to dma_mb(), the > > > __iormb() behaves differently compare to dma_mb() (I haven't into details > > > why). > > > > > > So if it was a read barrier, we would likely want to use the iormb() > > > semantic. This will keep the terminology consistent with Linux (even if we > > > remove the __). > > > > We need the __iomb as “linux compatibility” in fact so I would suggest for > > now to only introduce it at the beginning of smmu-v3.c with other linux > > compatibility stuff to prevent adding this to Xen overall. > > I would be fine with that. +1 --8323329-1967879923-1662416243=:3931-- From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:19:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399210.640301 (Exim 4.92) (envelope-from ) id 1oVKRV-0007dp-Gh; Mon, 05 Sep 2022 22:19:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399210.640301; Mon, 05 Sep 2022 22:19:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKRV-0007di-DS; Mon, 05 Sep 2022 22:19:45 +0000 Received: by outflank-mailman (input) for mailman id 399210; Mon, 05 Sep 2022 22:19:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKRU-0007dc-Bd for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:19:44 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d74b82b8-2d68-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 00:19:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7101B81598; Mon, 5 Sep 2022 22:19:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14A02C433D7; Mon, 5 Sep 2022 22:19:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d74b82b8-2d68-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662416381; bh=2zCGslPKOq0qjEIEfD18prRPd7UwxPKZojQ4MBgjtHM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tKP46uVhbhNgBVwHssDzVyIeWjXXbkxsoG8qrcx5Cdcuyf4NkO1heJqnZ9YIqU8Qa Md1IffVcq5ynecUTNKljW98fW2Y2+Xbdu1/fm2TwzKDLOv5FZEdRe00OCa8yKxKV5G MZHpSVkDhcZyRHJsJJFvu++A9VknQEK4UwoGtD6WMNea12EDKdU18+PyeAT7821259 Y7WSNe/mXu2/8CtUePlWylvAKjKlPFuF16IYqVb6PwPdZr65ZTp4N4/QsM8psXXeK6 AARKuP6gF6JZ2RB6Q9k8ONiz8mPx4/vuQDOz3py/mdDbZwkV07TKZzdnL1ZUY543Sl 2jhyoYqSE+awQ== Date: Mon, 5 Sep 2022 15:19:40 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Robin Murphy , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v3 05/10] xen/arm: smmuv3: Remove the page 1 fixup In-Reply-To: <6a8cb40d46ab3e688df1f037e4fdacdcd98e3c6a.1662394710.git.rahul.singh@arm.com> Message-ID: References: <6a8cb40d46ab3e688df1f037e4fdacdcd98e3c6a.1662394710.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 5 Sep 2022, Rahul Singh wrote: > From: Robin Murphy > > Backport Linux commit 86d2d9214880. This is the clean backport without > any changes. > > Since we now keep track of page 1 via a separate pointer that > already encapsulates aliasing to page 0 as necessary, we can remove > the clunky fixup routine and simply use the relevant bases directly. > The current architecture spec (IHI0070D.a) defines > SMMU_{EVENTQ,PRIQ}_{PROD,CONS} as offsets relative to page 1, so the > cleanup represents a little bit of convergence as well as just > lines of code saved. > > Signed-off-by: Robin Murphy > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 86d2d9214880 > Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini > --- > Changes in v3: > - fix "q->cons_reg = page + cons_off" > Changes in v2: > - fix commit msg. > --- > xen/drivers/passthrough/arm/smmu-v3.c | 42 ++++++++++----------------- > xen/drivers/passthrough/arm/smmu-v3.h | 8 ++--- > 2 files changed, 20 insertions(+), 30 deletions(-) > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index e65b226b85..272adebb0b 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -238,15 +238,6 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { > { 0, NULL}, > }; > > -static inline void __iomem *arm_smmu_page1_fixup(unsigned long offset, > - struct arm_smmu_device *smmu) > -{ > - if (offset > SZ_64K) > - return smmu->page1 + offset - SZ_64K; > - > - return smmu->base + offset; > -} > - > static struct arm_smmu_domain *to_smmu_domain(struct iommu_domain *dom) > { > return container_of(dom, struct arm_smmu_domain, domain); > @@ -1581,6 +1572,7 @@ static int arm_smmu_dt_xlate(struct device *dev, > /* Probing and initialisation functions */ > static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, > struct arm_smmu_queue *q, > + void __iomem *page, > unsigned long prod_off, > unsigned long cons_off, > size_t dwords, const char *name) > @@ -1609,8 +1601,8 @@ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, > 1 << q->llq.max_n_shift, name); > } > > - q->prod_reg = arm_smmu_page1_fixup(prod_off, smmu); > - q->cons_reg = arm_smmu_page1_fixup(cons_off, smmu); > + q->prod_reg = page + prod_off; > + q->cons_reg = page + cons_off; > q->ent_dwords = dwords; > > q->q_base = Q_BASE_RWA; > @@ -1627,16 +1619,16 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) > > /* cmdq */ > spin_lock_init(&smmu->cmdq.lock); > - ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, ARM_SMMU_CMDQ_PROD, > - ARM_SMMU_CMDQ_CONS, CMDQ_ENT_DWORDS, > - "cmdq"); > + ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, smmu->base, > + ARM_SMMU_CMDQ_PROD, ARM_SMMU_CMDQ_CONS, > + CMDQ_ENT_DWORDS, "cmdq"); > if (ret) > return ret; > > /* evtq */ > - ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, ARM_SMMU_EVTQ_PROD, > - ARM_SMMU_EVTQ_CONS, EVTQ_ENT_DWORDS, > - "evtq"); > + ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, smmu->page1, > + ARM_SMMU_EVTQ_PROD, ARM_SMMU_EVTQ_CONS, > + EVTQ_ENT_DWORDS, "evtq"); > if (ret) > return ret; > > @@ -1644,9 +1636,9 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) > if (!(smmu->features & ARM_SMMU_FEAT_PRI)) > return 0; > > - return arm_smmu_init_one_queue(smmu, &smmu->priq.q, ARM_SMMU_PRIQ_PROD, > - ARM_SMMU_PRIQ_CONS, PRIQ_ENT_DWORDS, > - "priq"); > + return arm_smmu_init_one_queue(smmu, &smmu->priq.q, smmu->page1, > + ARM_SMMU_PRIQ_PROD, ARM_SMMU_PRIQ_CONS, > + PRIQ_ENT_DWORDS, "priq"); > } > > static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) > @@ -2090,10 +2082,8 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) > > /* Event queue */ > writeq_relaxed(smmu->evtq.q.q_base, smmu->base + ARM_SMMU_EVTQ_BASE); > - writel_relaxed(smmu->evtq.q.llq.prod, > - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_PROD, smmu)); > - writel_relaxed(smmu->evtq.q.llq.cons, > - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_CONS, smmu)); > + writel_relaxed(smmu->evtq.q.llq.prod, smmu->page1 + ARM_SMMU_EVTQ_PROD); > + writel_relaxed(smmu->evtq.q.llq.cons, smmu->page1 + ARM_SMMU_EVTQ_CONS); > > enables |= CR0_EVTQEN; > ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, > @@ -2108,9 +2098,9 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) > writeq_relaxed(smmu->priq.q.q_base, > smmu->base + ARM_SMMU_PRIQ_BASE); > writel_relaxed(smmu->priq.q.llq.prod, > - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_PROD, smmu)); > + smmu->page1 + ARM_SMMU_PRIQ_PROD); > writel_relaxed(smmu->priq.q.llq.cons, > - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_CONS, smmu)); > + smmu->page1 + ARM_SMMU_PRIQ_CONS); > > enables |= CR0_PRIQEN; > ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, > diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h > index c45d2f16c4..0742bc393f 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.h > +++ b/xen/drivers/passthrough/arm/smmu-v3.h > @@ -130,15 +130,15 @@ > #define ARM_SMMU_CMDQ_CONS 0x9c > > #define ARM_SMMU_EVTQ_BASE 0xa0 > -#define ARM_SMMU_EVTQ_PROD 0x100a8 > -#define ARM_SMMU_EVTQ_CONS 0x100ac > +#define ARM_SMMU_EVTQ_PROD 0xa8 > +#define ARM_SMMU_EVTQ_CONS 0xac > #define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 > #define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 > #define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc > > #define ARM_SMMU_PRIQ_BASE 0xc0 > -#define ARM_SMMU_PRIQ_PROD 0x100c8 > -#define ARM_SMMU_PRIQ_CONS 0x100cc > +#define ARM_SMMU_PRIQ_PROD 0xc8 > +#define ARM_SMMU_PRIQ_CONS 0xcc > #define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 > #define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 > #define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:20:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:20:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399217.640312 (Exim 4.92) (envelope-from ) id 1oVKSP-0000Xs-P8; Mon, 05 Sep 2022 22:20:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399217.640312; Mon, 05 Sep 2022 22:20:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKSP-0000Xl-MO; Mon, 05 Sep 2022 22:20:41 +0000 Received: by outflank-mailman (input) for mailman id 399217; Mon, 05 Sep 2022 22:20:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKSO-0000MS-Ab for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:20:40 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7905c31-2d68-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 00:20:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E7B1B81113; Mon, 5 Sep 2022 22:20:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3B93C433D7; Mon, 5 Sep 2022 22:20:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7905c31-2d68-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662416435; bh=0uQIVkwIBZXhGWZ96FuaXOVEFL507x5ie/HJSeTbYaA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Kz4Z3+s9oyvYrQDPz3RrVGr6r6OsSIW+azFWGqBgjkn2EsfQPeC9/Zun4VibfGPYn 0jUCozvlqDI0gWjYF1Oygpduh9a8Nh+A0Xzro8vdxnZF1A/WfUBt6rUCEdsRV62P7S kMeB/mrIaF7dXHh+eGqXV9bZ8fyXzOJEKshZAY//S5+PY5wZw3ML7XbqmKZVc6iggm wEhZYb3mhhVjRWFlFITUwSASoazCMhY2yJ5Wk0HPczQ3K+4UGQgvyFiEnDk4f55TTF nHAdWWJc/MssE9vG+Sm08p9nKOPyxagrpUeENbx/18AlZQFkNmHnqWxfFcqUoAuYQG MA8LSGlzWm4sw== Date: Mon, 5 Sep 2022 15:20:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Jean-Philippe Brucker , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Eric Auger , Jonathan Cameron , Will Deacon Subject: Re: [PATCH v3 04/10] xen/arm: smmuv3: Move definitions to a header In-Reply-To: <9d2a455ecb4e5bc8c846127e9df3080553c84888.1662394710.git.rahul.singh@arm.com> Message-ID: References: <9d2a455ecb4e5bc8c846127e9df3080553c84888.1662394710.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 5 Sep 2022, Rahul Singh wrote: > From: Jean-Philippe Brucker > > Backport Linux commit e881e7839fba. Also, move Xen related struct > definition to header to get it compiled. > > Allow sharing structure definitions with the upcoming SVA support for > Arm SMMUv3, by moving them to a separate header. We could surgically > extract only what is needed but keeping all definitions in one place > looks nicer. > > Signed-off-by: Jean-Philippe Brucker > Reviewed-by: Eric Auger > Reviewed-by: Jonathan Cameron > Link: https://lore.kernel.org/r/20200918101852.582559-8-jean-philippe@linaro.org > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e881e7839fba > Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini > --- > Changes in v3: > - remove clean backport msg in commit msg > Changes in v2: > - fix commit msg > - also move struct definition to header file to sync with Linux patch > --- > xen/drivers/passthrough/arm/smmu-v3.c | 665 +------------------------ > xen/drivers/passthrough/arm/smmu-v3.h | 674 ++++++++++++++++++++++++++ > 2 files changed, 675 insertions(+), 664 deletions(-) > create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index e632c75b21..e65b226b85 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -90,6 +90,7 @@ > #include > #include > > +#include "smmu-v3.h" > > #define ARM_SMMU_VTCR_SH_IS 3 > #define ARM_SMMU_VTCR_RGN_WBWA 1 > @@ -103,22 +104,12 @@ > #define ARM_SMMU_VTCR_PS_52_BIT 0x6ULL > > /* Linux compatibility functions. */ > -typedef paddr_t dma_addr_t; > -typedef paddr_t phys_addr_t; > -typedef unsigned int gfp_t; > - > #define iomb() dmb(osh) > > #define platform_device device > > #define GFP_KERNEL 0 > > -/* Alias to Xen lock functions */ > -#define mutex spinlock > -#define mutex_init spin_lock_init > -#define mutex_lock spin_lock > -#define mutex_unlock spin_unlock > - > /* Device logger functions */ > #define dev_name(dev) dt_node_full_name(dev->of_node) > #define dev_dbg(dev, fmt, ...) \ > @@ -159,12 +150,6 @@ typedef unsigned int gfp_t; > #define readl_relaxed_poll_timeout(addr, val, cond, delay_us, timeout_us) \ > readx_poll_timeout(readl_relaxed, addr, val, cond, delay_us, timeout_us) > > -#define FIELD_PREP(_mask, _val) \ > - (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) > - > -#define FIELD_GET(_mask, _reg) \ > - ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) > - > /* > * Helpers for DMA allocation. Just the function name is reused for > * porting code, these allocation are not managed allocations > @@ -197,27 +182,6 @@ static void *dmam_alloc_coherent(struct device *dev, size_t size, > return vaddr; > } > > - > -/* Xen specific code. */ > -struct iommu_domain { > - /* Runtime SMMU configuration for this iommu_domain */ > - atomic_t ref; > - /* > - * Used to link iommu_domain contexts for a same domain. > - * There is at least one per-SMMU to used by the domain. > - */ > - struct list_head list; > -}; > - > -/* Describes information required for a Xen domain */ > -struct arm_smmu_xen_domain { > - spinlock_t lock; > - > - /* List of iommu domains associated to this domain */ > - struct list_head contexts; > -}; > - > - > /* Keep a list of devices associated with this driver */ > static DEFINE_SPINLOCK(arm_smmu_devices_lock); > static LIST_HEAD(arm_smmu_devices); > @@ -261,635 +225,8 @@ static int platform_get_irq_byname_optional(struct device *dev, > } > > /* Start of Linux SMMUv3 code */ > -/* MMIO registers */ > -#define ARM_SMMU_IDR0 0x0 > -#define IDR0_ST_LVL GENMASK(28, 27) > -#define IDR0_ST_LVL_2LVL 1 > -#define IDR0_STALL_MODEL GENMASK(25, 24) > -#define IDR0_STALL_MODEL_STALL 0 > -#define IDR0_STALL_MODEL_FORCE 2 > -#define IDR0_TTENDIAN GENMASK(22, 21) > -#define IDR0_TTENDIAN_MIXED 0 > -#define IDR0_TTENDIAN_LE 2 > -#define IDR0_TTENDIAN_BE 3 > -#define IDR0_CD2L (1 << 19) > -#define IDR0_VMID16 (1 << 18) > -#define IDR0_PRI (1 << 16) > -#define IDR0_SEV (1 << 14) > -#define IDR0_MSI (1 << 13) > -#define IDR0_ASID16 (1 << 12) > -#define IDR0_ATS (1 << 10) > -#define IDR0_HYP (1 << 9) > -#define IDR0_COHACC (1 << 4) > -#define IDR0_TTF GENMASK(3, 2) > -#define IDR0_TTF_AARCH64 2 > -#define IDR0_TTF_AARCH32_64 3 > -#define IDR0_S1P (1 << 1) > -#define IDR0_S2P (1 << 0) > - > -#define ARM_SMMU_IDR1 0x4 > -#define IDR1_TABLES_PRESET (1 << 30) > -#define IDR1_QUEUES_PRESET (1 << 29) > -#define IDR1_REL (1 << 28) > -#define IDR1_CMDQS GENMASK(25, 21) > -#define IDR1_EVTQS GENMASK(20, 16) > -#define IDR1_PRIQS GENMASK(15, 11) > -#define IDR1_SSIDSIZE GENMASK(10, 6) > -#define IDR1_SIDSIZE GENMASK(5, 0) > - > -#define ARM_SMMU_IDR5 0x14 > -#define IDR5_STALL_MAX GENMASK(31, 16) > -#define IDR5_GRAN64K (1 << 6) > -#define IDR5_GRAN16K (1 << 5) > -#define IDR5_GRAN4K (1 << 4) > -#define IDR5_OAS GENMASK(2, 0) > -#define IDR5_OAS_32_BIT 0 > -#define IDR5_OAS_36_BIT 1 > -#define IDR5_OAS_40_BIT 2 > -#define IDR5_OAS_42_BIT 3 > -#define IDR5_OAS_44_BIT 4 > -#define IDR5_OAS_48_BIT 5 > -#define IDR5_OAS_52_BIT 6 > -#define IDR5_VAX GENMASK(11, 10) > -#define IDR5_VAX_52_BIT 1 > - > -#define ARM_SMMU_CR0 0x20 > -#define CR0_ATSCHK (1 << 4) > -#define CR0_CMDQEN (1 << 3) > -#define CR0_EVTQEN (1 << 2) > -#define CR0_PRIQEN (1 << 1) > -#define CR0_SMMUEN (1 << 0) > - > -#define ARM_SMMU_CR0ACK 0x24 > - > -#define ARM_SMMU_CR1 0x28 > -#define CR1_TABLE_SH GENMASK(11, 10) > -#define CR1_TABLE_OC GENMASK(9, 8) > -#define CR1_TABLE_IC GENMASK(7, 6) > -#define CR1_QUEUE_SH GENMASK(5, 4) > -#define CR1_QUEUE_OC GENMASK(3, 2) > -#define CR1_QUEUE_IC GENMASK(1, 0) > -/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ > -#define CR1_CACHE_NC 0 > -#define CR1_CACHE_WB 1 > -#define CR1_CACHE_WT 2 > - > -#define ARM_SMMU_CR2 0x2c > -#define CR2_PTM (1 << 2) > -#define CR2_RECINVSID (1 << 1) > -#define CR2_E2H (1 << 0) > - > -#define ARM_SMMU_GBPA 0x44 > -#define GBPA_UPDATE (1U << 31) > -#define GBPA_ABORT (1 << 20) > - > -#define ARM_SMMU_IRQ_CTRL 0x50 > -#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) > -#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) > -#define IRQ_CTRL_GERROR_IRQEN (1 << 0) > - > -#define ARM_SMMU_IRQ_CTRLACK 0x54 > - > -#define ARM_SMMU_GERROR 0x60 > -#define GERROR_SFM_ERR (1 << 8) > -#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) > -#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) > -#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) > -#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) > -#define GERROR_PRIQ_ABT_ERR (1 << 3) > -#define GERROR_EVTQ_ABT_ERR (1 << 2) > -#define GERROR_CMDQ_ERR (1 << 0) > -#define GERROR_ERR_MASK 0xfd > - > -#define ARM_SMMU_GERRORN 0x64 > - > -#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 > -#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 > -#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 > - > -#define ARM_SMMU_STRTAB_BASE 0x80 > -#define STRTAB_BASE_RA (1UL << 62) > -#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) > - > -#define ARM_SMMU_STRTAB_BASE_CFG 0x88 > -#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) > -#define STRTAB_BASE_CFG_FMT_LINEAR 0 > -#define STRTAB_BASE_CFG_FMT_2LVL 1 > -#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) > -#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) > - > -#define ARM_SMMU_CMDQ_BASE 0x90 > -#define ARM_SMMU_CMDQ_PROD 0x98 > -#define ARM_SMMU_CMDQ_CONS 0x9c > - > -#define ARM_SMMU_EVTQ_BASE 0xa0 > -#define ARM_SMMU_EVTQ_PROD 0x100a8 > -#define ARM_SMMU_EVTQ_CONS 0x100ac > -#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 > -#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 > -#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc > - > -#define ARM_SMMU_PRIQ_BASE 0xc0 > -#define ARM_SMMU_PRIQ_PROD 0x100c8 > -#define ARM_SMMU_PRIQ_CONS 0x100cc > -#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 > -#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 > -#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc > - > -#define ARM_SMMU_REG_SZ 0xe00 > - > -/* Common MSI config fields */ > -#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) > -#define MSI_CFG2_SH GENMASK(5, 4) > -#define MSI_CFG2_MEMATTR GENMASK(3, 0) > - > -/* Common memory attribute values */ > -#define ARM_SMMU_SH_NSH 0 > -#define ARM_SMMU_SH_OSH 2 > -#define ARM_SMMU_SH_ISH 3 > -#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 > -#define ARM_SMMU_MEMATTR_OIWB 0xf > - > -#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) > -#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) > -#define Q_OVERFLOW_FLAG (1U << 31) > -#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) > -#define Q_ENT(q, p) ((q)->base + \ > - Q_IDX(&((q)->llq), p) * \ > - (q)->ent_dwords) > - > -#define Q_BASE_RWA (1UL << 62) > -#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) > -#define Q_BASE_LOG2SIZE GENMASK(4, 0) > - > -/* Ensure DMA allocations are naturally aligned */ > -#ifdef CONFIG_CMA_ALIGNMENT > -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) > -#else > -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) > -#endif > - > -/* > - * Stream table. > - * > - * Linear: Enough to cover 1 << IDR1.SIDSIZE entries > - * 2lvl: 128k L1 entries, > - * 256 lazy entries per table (each table covers a PCI bus) > - */ > -#define STRTAB_L1_SZ_SHIFT 20 > -#define STRTAB_SPLIT 8 > - > -#define STRTAB_L1_DESC_DWORDS 1 > -#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) > -#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) > - > -#define STRTAB_STE_DWORDS 8 > -#define STRTAB_STE_0_V (1UL << 0) > -#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) > -#define STRTAB_STE_0_CFG_ABORT 0 > -#define STRTAB_STE_0_CFG_BYPASS 4 > -#define STRTAB_STE_0_CFG_S1_TRANS 5 > -#define STRTAB_STE_0_CFG_S2_TRANS 6 > - > -#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) > -#define STRTAB_STE_0_S1FMT_LINEAR 0 > -#define STRTAB_STE_0_S1FMT_64K_L2 2 > -#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) > -#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) > - > -#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) > -#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 > -#define STRTAB_STE_1_S1DSS_BYPASS 0x1 > -#define STRTAB_STE_1_S1DSS_SSID0 0x2 > - > -#define STRTAB_STE_1_S1C_CACHE_NC 0UL > -#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL > -#define STRTAB_STE_1_S1C_CACHE_WT 2UL > -#define STRTAB_STE_1_S1C_CACHE_WB 3UL > -#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) > -#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) > -#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) > - > -#define STRTAB_STE_1_S1STALLD (1UL << 27) > - > -#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) > -#define STRTAB_STE_1_EATS_ABT 0UL > -#define STRTAB_STE_1_EATS_TRANS 1UL > -#define STRTAB_STE_1_EATS_S1CHK 2UL > - > -#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) > -#define STRTAB_STE_1_STRW_NSEL1 0UL > -#define STRTAB_STE_1_STRW_EL2 2UL > - > -#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) > -#define STRTAB_STE_1_SHCFG_INCOMING 1UL > - > -#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) > -#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) > -#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) > -#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) > -#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) > -#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) > -#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) > -#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) > -#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) > -#define STRTAB_STE_2_S2AA64 (1UL << 51) > -#define STRTAB_STE_2_S2ENDI (1UL << 52) > -#define STRTAB_STE_2_S2PTW (1UL << 54) > -#define STRTAB_STE_2_S2R (1UL << 58) > - > -#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) > - > -/* > - * Context descriptors. > - * > - * Linear: when less than 1024 SSIDs are supported > - * 2lvl: at most 1024 L1 entries, > - * 1024 lazy entries per table. > - */ > -#define CTXDESC_SPLIT 10 > -#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) > - > -#define CTXDESC_L1_DESC_DWORDS 1 > -#define CTXDESC_L1_DESC_V (1UL << 0) > -#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) > - > -#define CTXDESC_CD_DWORDS 8 > -#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) > -#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) > -#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) > -#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) > -#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) > -#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) > -#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) > - > -#define CTXDESC_CD_0_ENDI (1UL << 15) > -#define CTXDESC_CD_0_V (1UL << 31) > - > -#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) > -#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) > - > -#define CTXDESC_CD_0_AA64 (1UL << 41) > -#define CTXDESC_CD_0_S (1UL << 44) > -#define CTXDESC_CD_0_R (1UL << 45) > -#define CTXDESC_CD_0_A (1UL << 46) > -#define CTXDESC_CD_0_ASET (1UL << 47) > -#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) > - > -#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) > - > -/* > - * When the SMMU only supports linear context descriptor tables, pick a > - * reasonable size limit (64kB). > - */ > -#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) > - > -/* Command queue */ > -#define CMDQ_ENT_SZ_SHIFT 4 > -#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) > -#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) > - > -#define CMDQ_CONS_ERR GENMASK(30, 24) > -#define CMDQ_ERR_CERROR_NONE_IDX 0 > -#define CMDQ_ERR_CERROR_ILL_IDX 1 > -#define CMDQ_ERR_CERROR_ABT_IDX 2 > -#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 > - > -#define CMDQ_0_OP GENMASK_ULL(7, 0) > -#define CMDQ_0_SSV (1UL << 11) > - > -#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) > -#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) > - > -#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) > -#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_CFGI_1_LEAF (1UL << 0) > -#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) > - > -#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) > -#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) > -#define CMDQ_TLBI_1_LEAF (1UL << 0) > -#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) > -#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) > - > -#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) > -#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_ATC_0_GLOBAL (1UL << 9) > -#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) > -#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) > - > -#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) > -#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) > -#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) > -#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) > - > -#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) > -#define CMDQ_SYNC_0_CS_NONE 0 > -#define CMDQ_SYNC_0_CS_IRQ 1 > -#define CMDQ_SYNC_0_CS_SEV 2 > -#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) > -#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) > -#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) > -#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) > - > -/* Event queue */ > -#define EVTQ_ENT_SZ_SHIFT 5 > -#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) > -#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) > - > -#define EVTQ_0_ID GENMASK_ULL(7, 0) > - > -/* PRI queue */ > -#define PRIQ_ENT_SZ_SHIFT 4 > -#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) > -#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) > - > -#define PRIQ_0_SID GENMASK_ULL(31, 0) > -#define PRIQ_0_SSID GENMASK_ULL(51, 32) > -#define PRIQ_0_PERM_PRIV (1UL << 58) > -#define PRIQ_0_PERM_EXEC (1UL << 59) > -#define PRIQ_0_PERM_READ (1UL << 60) > -#define PRIQ_0_PERM_WRITE (1UL << 61) > -#define PRIQ_0_PRG_LAST (1UL << 62) > -#define PRIQ_0_SSID_V (1UL << 63) > - > -#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) > -#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) > - > -/* High-level queue structures */ > -#define ARM_SMMU_POLL_TIMEOUT_US 100 > -#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ > -#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 > - > static bool disable_bypass = 1; > > -enum pri_resp { > - PRI_RESP_DENY = 0, > - PRI_RESP_FAIL = 1, > - PRI_RESP_SUCC = 2, > -}; > - > -#ifdef CONFIG_MSI > -enum arm_smmu_msi_index { > - EVTQ_MSI_INDEX, > - GERROR_MSI_INDEX, > - PRIQ_MSI_INDEX, > - ARM_SMMU_MAX_MSIS, > -}; > - > -static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { > - [EVTQ_MSI_INDEX] = { > - ARM_SMMU_EVTQ_IRQ_CFG0, > - ARM_SMMU_EVTQ_IRQ_CFG1, > - ARM_SMMU_EVTQ_IRQ_CFG2, > - }, > - [GERROR_MSI_INDEX] = { > - ARM_SMMU_GERROR_IRQ_CFG0, > - ARM_SMMU_GERROR_IRQ_CFG1, > - ARM_SMMU_GERROR_IRQ_CFG2, > - }, > - [PRIQ_MSI_INDEX] = { > - ARM_SMMU_PRIQ_IRQ_CFG0, > - ARM_SMMU_PRIQ_IRQ_CFG1, > - ARM_SMMU_PRIQ_IRQ_CFG2, > - }, > -}; > -#endif /* CONFIG_MSI */ > - > -struct arm_smmu_cmdq_ent { > - /* Common fields */ > - u8 opcode; > - bool substream_valid; > - > - /* Command-specific fields */ > - union { > - #define CMDQ_OP_PREFETCH_CFG 0x1 > - struct { > - u32 sid; > - u8 size; > - u64 addr; > - } prefetch; > - > - #define CMDQ_OP_CFGI_STE 0x3 > - #define CMDQ_OP_CFGI_ALL 0x4 > - struct { > - u32 sid; > - union { > - bool leaf; > - u8 span; > - }; > - } cfgi; > - > - #define CMDQ_OP_TLBI_EL2_ALL 0x20 > - #define CMDQ_OP_TLBI_S12_VMALL 0x28 > - #define CMDQ_OP_TLBI_S2_IPA 0x2a > - #define CMDQ_OP_TLBI_NSNH_ALL 0x30 > - struct { > - u16 asid; > - u16 vmid; > - bool leaf; > - u64 addr; > - } tlbi; > - > - #define CMDQ_OP_ATC_INV 0x40 > - #define ATC_INV_SIZE_ALL 52 > - struct { > - u32 sid; > - u32 ssid; > - u64 addr; > - u8 size; > - bool global; > - } atc; > - > - #define CMDQ_OP_PRI_RESP 0x41 > - struct { > - u32 sid; > - u32 ssid; > - u16 grpid; > - enum pri_resp resp; > - } pri; > - > - #define CMDQ_OP_CMD_SYNC 0x46 > - struct { > - u32 msidata; > - u64 msiaddr; > - } sync; > - }; > -}; > - > -struct arm_smmu_ll_queue { > - u32 prod; > - u32 cons; > - u32 max_n_shift; > -}; > - > -struct arm_smmu_queue { > - struct arm_smmu_ll_queue llq; > - int irq; /* Wired interrupt */ > - > - __le64 *base; > - dma_addr_t base_dma; > - u64 q_base; > - > - size_t ent_dwords; > - > - u32 __iomem *prod_reg; > - u32 __iomem *cons_reg; > -}; > - > -struct arm_smmu_cmdq { > - struct arm_smmu_queue q; > - spinlock_t lock; > -}; > - > -struct arm_smmu_evtq { > - struct arm_smmu_queue q; > - u32 max_stalls; > -}; > - > -struct arm_smmu_priq { > - struct arm_smmu_queue q; > -}; > - > -/* High-level stream table and context descriptor structures */ > -struct arm_smmu_strtab_l1_desc { > - u8 span; > - > - __le64 *l2ptr; > - dma_addr_t l2ptr_dma; > -}; > - > -struct arm_smmu_s2_cfg { > - u16 vmid; > - u64 vttbr; > - u64 vtcr; > -}; > - > -struct arm_smmu_strtab_cfg { > - __le64 *strtab; > - dma_addr_t strtab_dma; > - struct arm_smmu_strtab_l1_desc *l1_desc; > - unsigned int num_l1_ents; > - > - u64 strtab_base; > - u32 strtab_base_cfg; > -}; > - > -struct arm_lpae_s2_cfg { > - u64 vttbr; > - struct { > - u32 ps:3; > - u32 tg:2; > - u32 sh:2; > - u32 orgn:2; > - u32 irgn:2; > - u32 sl:2; > - u32 tsz:6; > - } vtcr; > -}; > - > -/* An SMMUv3 instance */ > -struct arm_smmu_device { > - struct device *dev; > - void __iomem *base; > - void __iomem *page1; > - > -#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) > -#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) > -#define ARM_SMMU_FEAT_TT_LE (1 << 2) > -#define ARM_SMMU_FEAT_TT_BE (1 << 3) > -#define ARM_SMMU_FEAT_PRI (1 << 4) > -#define ARM_SMMU_FEAT_ATS (1 << 5) > -#define ARM_SMMU_FEAT_SEV (1 << 6) > -#define ARM_SMMU_FEAT_MSI (1 << 7) > -#define ARM_SMMU_FEAT_COHERENCY (1 << 8) > -#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) > -#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) > -#define ARM_SMMU_FEAT_STALLS (1 << 11) > -#define ARM_SMMU_FEAT_HYP (1 << 12) > -#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) > -#define ARM_SMMU_FEAT_VAX (1 << 14) > - u32 features; > - > -#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) > -#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) > - u32 options; > - > - struct arm_smmu_cmdq cmdq; > - struct arm_smmu_evtq evtq; > - struct arm_smmu_priq priq; > - > - int gerr_irq; > - int combined_irq; > - u32 sync_nr; > - u8 prev_cmd_opcode; > - > - unsigned long ias; /* IPA */ > - unsigned long oas; /* PA */ > - unsigned long pgsize_bitmap; > - > -#define ARM_SMMU_MAX_VMIDS (1 << 16) > - unsigned int vmid_bits; > - DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); > - > - unsigned int sid_bits; > - > - struct arm_smmu_strtab_cfg strtab_cfg; > - > - /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ > - union { > - u32 sync_count; > - u64 padding; > - }; > - > - /* Need to keep a list of SMMU devices */ > - struct list_head devices; > - > - /* Tasklets for handling evts/faults and pci page request IRQs*/ > - struct tasklet evtq_irq_tasklet; > - struct tasklet priq_irq_tasklet; > - struct tasklet combined_irq_tasklet; > -}; > - > -/* SMMU private data for each master */ > -struct arm_smmu_master { > - struct arm_smmu_device *smmu; > - struct device *dev; > - struct arm_smmu_domain *domain; > - struct list_head domain_head; > - u32 *sids; > - unsigned int num_sids; > - bool ats_enabled; > -}; > - > -/* SMMU private data for an IOMMU domain */ > -enum arm_smmu_domain_stage { > - ARM_SMMU_DOMAIN_S1 = 0, > - ARM_SMMU_DOMAIN_S2, > - ARM_SMMU_DOMAIN_NESTED, > - ARM_SMMU_DOMAIN_BYPASS, > -}; > - > -struct arm_smmu_domain { > - struct arm_smmu_device *smmu; > - struct mutex init_mutex; /* Protects smmu pointer */ > - > - bool non_strict; > - atomic_t nr_ats_masters; > - > - enum arm_smmu_domain_stage stage; > - struct arm_smmu_s2_cfg s2_cfg; > - > - /* Xen domain associated with this SMMU domain */ > - struct domain *d; > - > - struct iommu_domain domain; > - > - struct list_head devices; > - spinlock_t devices_lock; > -}; > - > struct arm_smmu_option_prop { > u32 opt; > const char *prop; > diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h > new file mode 100644 > index 0000000000..c45d2f16c4 > --- /dev/null > +++ b/xen/drivers/passthrough/arm/smmu-v3.h > @@ -0,0 +1,674 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * IOMMU API for ARM architected SMMUv3 implementations. > + * > + * Copyright (C) 2022 ARM Limited > + */ > + > +#ifndef _ARM_SMMU_V3_H > +#define _ARM_SMMU_V3_H > + > +/* MMIO registers */ > +#define ARM_SMMU_IDR0 0x0 > +#define IDR0_ST_LVL GENMASK(28, 27) > +#define IDR0_ST_LVL_2LVL 1 > +#define IDR0_STALL_MODEL GENMASK(25, 24) > +#define IDR0_STALL_MODEL_STALL 0 > +#define IDR0_STALL_MODEL_FORCE 2 > +#define IDR0_TTENDIAN GENMASK(22, 21) > +#define IDR0_TTENDIAN_MIXED 0 > +#define IDR0_TTENDIAN_LE 2 > +#define IDR0_TTENDIAN_BE 3 > +#define IDR0_CD2L (1 << 19) > +#define IDR0_VMID16 (1 << 18) > +#define IDR0_PRI (1 << 16) > +#define IDR0_SEV (1 << 14) > +#define IDR0_MSI (1 << 13) > +#define IDR0_ASID16 (1 << 12) > +#define IDR0_ATS (1 << 10) > +#define IDR0_HYP (1 << 9) > +#define IDR0_COHACC (1 << 4) > +#define IDR0_TTF GENMASK(3, 2) > +#define IDR0_TTF_AARCH64 2 > +#define IDR0_TTF_AARCH32_64 3 > +#define IDR0_S1P (1 << 1) > +#define IDR0_S2P (1 << 0) > + > +#define ARM_SMMU_IDR1 0x4 > +#define IDR1_TABLES_PRESET (1 << 30) > +#define IDR1_QUEUES_PRESET (1 << 29) > +#define IDR1_REL (1 << 28) > +#define IDR1_CMDQS GENMASK(25, 21) > +#define IDR1_EVTQS GENMASK(20, 16) > +#define IDR1_PRIQS GENMASK(15, 11) > +#define IDR1_SSIDSIZE GENMASK(10, 6) > +#define IDR1_SIDSIZE GENMASK(5, 0) > + > +#define ARM_SMMU_IDR5 0x14 > +#define IDR5_STALL_MAX GENMASK(31, 16) > +#define IDR5_GRAN64K (1 << 6) > +#define IDR5_GRAN16K (1 << 5) > +#define IDR5_GRAN4K (1 << 4) > +#define IDR5_OAS GENMASK(2, 0) > +#define IDR5_OAS_32_BIT 0 > +#define IDR5_OAS_36_BIT 1 > +#define IDR5_OAS_40_BIT 2 > +#define IDR5_OAS_42_BIT 3 > +#define IDR5_OAS_44_BIT 4 > +#define IDR5_OAS_48_BIT 5 > +#define IDR5_OAS_52_BIT 6 > +#define IDR5_VAX GENMASK(11, 10) > +#define IDR5_VAX_52_BIT 1 > + > +#define ARM_SMMU_CR0 0x20 > +#define CR0_ATSCHK (1 << 4) > +#define CR0_CMDQEN (1 << 3) > +#define CR0_EVTQEN (1 << 2) > +#define CR0_PRIQEN (1 << 1) > +#define CR0_SMMUEN (1 << 0) > + > +#define ARM_SMMU_CR0ACK 0x24 > + > +#define ARM_SMMU_CR1 0x28 > +#define CR1_TABLE_SH GENMASK(11, 10) > +#define CR1_TABLE_OC GENMASK(9, 8) > +#define CR1_TABLE_IC GENMASK(7, 6) > +#define CR1_QUEUE_SH GENMASK(5, 4) > +#define CR1_QUEUE_OC GENMASK(3, 2) > +#define CR1_QUEUE_IC GENMASK(1, 0) > +/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ > +#define CR1_CACHE_NC 0 > +#define CR1_CACHE_WB 1 > +#define CR1_CACHE_WT 2 > + > +#define ARM_SMMU_CR2 0x2c > +#define CR2_PTM (1 << 2) > +#define CR2_RECINVSID (1 << 1) > +#define CR2_E2H (1 << 0) > + > +#define ARM_SMMU_GBPA 0x44 > +#define GBPA_UPDATE (1 << 31) > +#define GBPA_ABORT (1 << 20) > + > +#define ARM_SMMU_IRQ_CTRL 0x50 > +#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) > +#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) > +#define IRQ_CTRL_GERROR_IRQEN (1 << 0) > + > +#define ARM_SMMU_IRQ_CTRLACK 0x54 > + > +#define ARM_SMMU_GERROR 0x60 > +#define GERROR_SFM_ERR (1 << 8) > +#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) > +#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) > +#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) > +#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) > +#define GERROR_PRIQ_ABT_ERR (1 << 3) > +#define GERROR_EVTQ_ABT_ERR (1 << 2) > +#define GERROR_CMDQ_ERR (1 << 0) > +#define GERROR_ERR_MASK 0xfd > + > +#define ARM_SMMU_GERRORN 0x64 > + > +#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 > +#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 > +#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 > + > +#define ARM_SMMU_STRTAB_BASE 0x80 > +#define STRTAB_BASE_RA (1UL << 62) > +#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) > + > +#define ARM_SMMU_STRTAB_BASE_CFG 0x88 > +#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) > +#define STRTAB_BASE_CFG_FMT_LINEAR 0 > +#define STRTAB_BASE_CFG_FMT_2LVL 1 > +#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) > +#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) > + > +#define ARM_SMMU_CMDQ_BASE 0x90 > +#define ARM_SMMU_CMDQ_PROD 0x98 > +#define ARM_SMMU_CMDQ_CONS 0x9c > + > +#define ARM_SMMU_EVTQ_BASE 0xa0 > +#define ARM_SMMU_EVTQ_PROD 0x100a8 > +#define ARM_SMMU_EVTQ_CONS 0x100ac > +#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 > +#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 > +#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc > + > +#define ARM_SMMU_PRIQ_BASE 0xc0 > +#define ARM_SMMU_PRIQ_PROD 0x100c8 > +#define ARM_SMMU_PRIQ_CONS 0x100cc > +#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 > +#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 > +#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc > + > +#define ARM_SMMU_REG_SZ 0xe00 > + > +/* Common MSI config fields */ > +#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) > +#define MSI_CFG2_SH GENMASK(5, 4) > +#define MSI_CFG2_MEMATTR GENMASK(3, 0) > + > +/* Common memory attribute values */ > +#define ARM_SMMU_SH_NSH 0 > +#define ARM_SMMU_SH_OSH 2 > +#define ARM_SMMU_SH_ISH 3 > +#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 > +#define ARM_SMMU_MEMATTR_OIWB 0xf > + > +#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) > +#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) > +#define Q_OVERFLOW_FLAG (1 << 31) > +#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) > +#define Q_ENT(q, p) ((q)->base + \ > + Q_IDX(&((q)->llq), p) * \ > + (q)->ent_dwords) > + > +#define Q_BASE_RWA (1UL << 62) > +#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) > +#define Q_BASE_LOG2SIZE GENMASK(4, 0) > + > +/* Ensure DMA allocations are naturally aligned */ > +#ifdef CONFIG_CMA_ALIGNMENT > +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) > +#else > +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) > +#endif > + > +/* > + * Stream table. > + * > + * Linear: Enough to cover 1 << IDR1.SIDSIZE entries > + * 2lvl: 128k L1 entries, > + * 256 lazy entries per table (each table covers a PCI bus) > + */ > +#define STRTAB_L1_SZ_SHIFT 20 > +#define STRTAB_SPLIT 8 > + > +#define STRTAB_L1_DESC_DWORDS 1 > +#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) > +#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) > + > +#define STRTAB_STE_DWORDS 8 > +#define STRTAB_STE_0_V (1UL << 0) > +#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) > +#define STRTAB_STE_0_CFG_ABORT 0 > +#define STRTAB_STE_0_CFG_BYPASS 4 > +#define STRTAB_STE_0_CFG_S1_TRANS 5 > +#define STRTAB_STE_0_CFG_S2_TRANS 6 > + > +#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) > +#define STRTAB_STE_0_S1FMT_LINEAR 0 > +#define STRTAB_STE_0_S1FMT_64K_L2 2 > +#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) > +#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) > + > +#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) > +#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 > +#define STRTAB_STE_1_S1DSS_BYPASS 0x1 > +#define STRTAB_STE_1_S1DSS_SSID0 0x2 > + > +#define STRTAB_STE_1_S1C_CACHE_NC 0UL > +#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL > +#define STRTAB_STE_1_S1C_CACHE_WT 2UL > +#define STRTAB_STE_1_S1C_CACHE_WB 3UL > +#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) > +#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) > +#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) > + > +#define STRTAB_STE_1_S1STALLD (1UL << 27) > + > +#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) > +#define STRTAB_STE_1_EATS_ABT 0UL > +#define STRTAB_STE_1_EATS_TRANS 1UL > +#define STRTAB_STE_1_EATS_S1CHK 2UL > + > +#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) > +#define STRTAB_STE_1_STRW_NSEL1 0UL > +#define STRTAB_STE_1_STRW_EL2 2UL > + > +#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) > +#define STRTAB_STE_1_SHCFG_INCOMING 1UL > + > +#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) > +#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) > +#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) > +#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) > +#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) > +#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) > +#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) > +#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) > +#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) > +#define STRTAB_STE_2_S2AA64 (1UL << 51) > +#define STRTAB_STE_2_S2ENDI (1UL << 52) > +#define STRTAB_STE_2_S2PTW (1UL << 54) > +#define STRTAB_STE_2_S2R (1UL << 58) > + > +#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) > + > +/* > + * Context descriptors. > + * > + * Linear: when less than 1024 SSIDs are supported > + * 2lvl: at most 1024 L1 entries, > + * 1024 lazy entries per table. > + */ > +#define CTXDESC_SPLIT 10 > +#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) > + > +#define CTXDESC_L1_DESC_DWORDS 1 > +#define CTXDESC_L1_DESC_V (1UL << 0) > +#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) > + > +#define CTXDESC_CD_DWORDS 8 > +#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) > +#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) > +#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) > +#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) > +#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) > +#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) > +#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) > + > +#define CTXDESC_CD_0_ENDI (1UL << 15) > +#define CTXDESC_CD_0_V (1UL << 31) > + > +#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) > +#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) > + > +#define CTXDESC_CD_0_AA64 (1UL << 41) > +#define CTXDESC_CD_0_S (1UL << 44) > +#define CTXDESC_CD_0_R (1UL << 45) > +#define CTXDESC_CD_0_A (1UL << 46) > +#define CTXDESC_CD_0_ASET (1UL << 47) > +#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) > + > +#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) > + > +/* > + * When the SMMU only supports linear context descriptor tables, pick a > + * reasonable size limit (64kB). > + */ > +#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) > + > +/* Command queue */ > +#define CMDQ_ENT_SZ_SHIFT 4 > +#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) > +#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) > + > +#define CMDQ_CONS_ERR GENMASK(30, 24) > +#define CMDQ_ERR_CERROR_NONE_IDX 0 > +#define CMDQ_ERR_CERROR_ILL_IDX 1 > +#define CMDQ_ERR_CERROR_ABT_IDX 2 > +#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 > + > +#define CMDQ_0_OP GENMASK_ULL(7, 0) > +#define CMDQ_0_SSV (1UL << 11) > + > +#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) > +#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) > + > +#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) > +#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_CFGI_1_LEAF (1UL << 0) > +#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) > + > +#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) > +#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) > +#define CMDQ_TLBI_1_LEAF (1UL << 0) > +#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) > +#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) > + > +#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) > +#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_ATC_0_GLOBAL (1UL << 9) > +#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) > +#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) > + > +#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) > +#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) > +#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) > +#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) > + > +#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) > +#define CMDQ_SYNC_0_CS_NONE 0 > +#define CMDQ_SYNC_0_CS_IRQ 1 > +#define CMDQ_SYNC_0_CS_SEV 2 > +#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) > +#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) > +#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) > +#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) > + > +/* Event queue */ > +#define EVTQ_ENT_SZ_SHIFT 5 > +#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) > +#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) > + > +#define EVTQ_0_ID GENMASK_ULL(7, 0) > + > +/* PRI queue */ > +#define PRIQ_ENT_SZ_SHIFT 4 > +#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) > +#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) > + > +#define PRIQ_0_SID GENMASK_ULL(31, 0) > +#define PRIQ_0_SSID GENMASK_ULL(51, 32) > +#define PRIQ_0_PERM_PRIV (1UL << 58) > +#define PRIQ_0_PERM_EXEC (1UL << 59) > +#define PRIQ_0_PERM_READ (1UL << 60) > +#define PRIQ_0_PERM_WRITE (1UL << 61) > +#define PRIQ_0_PRG_LAST (1UL << 62) > +#define PRIQ_0_SSID_V (1UL << 63) > + > +#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) > +#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) > + > +/* High-level queue structures */ > +#define ARM_SMMU_POLL_TIMEOUT_US 100 > +#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ > +#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 > + > +#define FIELD_PREP(_mask, _val) \ > + (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) > + > +#define FIELD_GET(_mask, _reg) \ > + ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) > + > +/* Linux compatibility functions. */ > +typedef paddr_t dma_addr_t; > +typedef paddr_t phys_addr_t; > +typedef unsigned int gfp_t; > + > +/* Alias to Xen lock functions */ > +#define mutex spinlock > +#define mutex_init spin_lock_init > +#define mutex_lock spin_lock > +#define mutex_unlock spin_unlock > + > +/* SMMU private data for an IOMMU domain */ > +enum arm_smmu_domain_stage { > + ARM_SMMU_DOMAIN_S1 = 0, > + ARM_SMMU_DOMAIN_S2, > + ARM_SMMU_DOMAIN_NESTED, > + ARM_SMMU_DOMAIN_BYPASS, > +}; > + > +/* Xen specific code. */ > +struct iommu_domain { > + /* Runtime SMMU configuration for this iommu_domain */ > + atomic_t ref; > + /* > + * Used to link iommu_domain contexts for a same domain. > + * There is at least one per-SMMU to used by the domain. > + */ > + struct list_head list; > +}; > + > +/* Describes information required for a Xen domain */ > +struct arm_smmu_xen_domain { > + spinlock_t lock; > + > + /* List of iommu domains associated to this domain */ > + struct list_head contexts; > +}; > + > +enum pri_resp { > + PRI_RESP_DENY = 0, > + PRI_RESP_FAIL = 1, > + PRI_RESP_SUCC = 2, > +}; > + > +#ifdef CONFIG_MSI > +enum arm_smmu_msi_index { > + EVTQ_MSI_INDEX, > + GERROR_MSI_INDEX, > + PRIQ_MSI_INDEX, > + ARM_SMMU_MAX_MSIS, > +}; > + > +static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { > + [EVTQ_MSI_INDEX] = { > + ARM_SMMU_EVTQ_IRQ_CFG0, > + ARM_SMMU_EVTQ_IRQ_CFG1, > + ARM_SMMU_EVTQ_IRQ_CFG2, > + }, > + [GERROR_MSI_INDEX] = { > + ARM_SMMU_GERROR_IRQ_CFG0, > + ARM_SMMU_GERROR_IRQ_CFG1, > + ARM_SMMU_GERROR_IRQ_CFG2, > + }, > + [PRIQ_MSI_INDEX] = { > + ARM_SMMU_PRIQ_IRQ_CFG0, > + ARM_SMMU_PRIQ_IRQ_CFG1, > + ARM_SMMU_PRIQ_IRQ_CFG2, > + }, > +}; > +#endif /* CONFIG_MSI */ > + > +struct arm_smmu_cmdq_ent { > + /* Common fields */ > + u8 opcode; > + bool substream_valid; > + > + /* Command-specific fields */ > + union { > + #define CMDQ_OP_PREFETCH_CFG 0x1 > + struct { > + u32 sid; > + u8 size; > + u64 addr; > + } prefetch; > + > + #define CMDQ_OP_CFGI_STE 0x3 > + #define CMDQ_OP_CFGI_ALL 0x4 > + struct { > + u32 sid; > + union { > + bool leaf; > + u8 span; > + }; > + } cfgi; > + > + #define CMDQ_OP_TLBI_EL2_ALL 0x20 > + #define CMDQ_OP_TLBI_S12_VMALL 0x28 > + #define CMDQ_OP_TLBI_S2_IPA 0x2a > + #define CMDQ_OP_TLBI_NSNH_ALL 0x30 > + struct { > + u16 asid; > + u16 vmid; > + bool leaf; > + u64 addr; > + } tlbi; > + > + #define CMDQ_OP_ATC_INV 0x40 > + #define ATC_INV_SIZE_ALL 52 > + struct { > + u32 sid; > + u32 ssid; > + u64 addr; > + u8 size; > + bool global; > + } atc; > + > + #define CMDQ_OP_PRI_RESP 0x41 > + struct { > + u32 sid; > + u32 ssid; > + u16 grpid; > + enum pri_resp resp; > + } pri; > + > + #define CMDQ_OP_CMD_SYNC 0x46 > + struct { > + u32 msidata; > + u64 msiaddr; > + } sync; > + }; > +}; > + > +struct arm_smmu_ll_queue { > + u32 prod; > + u32 cons; > + u32 max_n_shift; > +}; > + > +struct arm_smmu_queue { > + struct arm_smmu_ll_queue llq; > + int irq; /* Wired interrupt */ > + > + __le64 *base; > + dma_addr_t base_dma; > + u64 q_base; > + > + size_t ent_dwords; > + > + u32 __iomem *prod_reg; > + u32 __iomem *cons_reg; > +}; > + > +struct arm_smmu_cmdq { > + struct arm_smmu_queue q; > + spinlock_t lock; > +}; > + > +struct arm_smmu_evtq { > + struct arm_smmu_queue q; > + u32 max_stalls; > +}; > + > +struct arm_smmu_priq { > + struct arm_smmu_queue q; > +}; > + > +/* High-level stream table and context descriptor structures */ > +struct arm_smmu_strtab_l1_desc { > + u8 span; > + > + __le64 *l2ptr; > + dma_addr_t l2ptr_dma; > +}; > + > +struct arm_smmu_s2_cfg { > + u16 vmid; > + u64 vttbr; > + u64 vtcr; > +}; > + > +struct arm_smmu_strtab_cfg { > + __le64 *strtab; > + dma_addr_t strtab_dma; > + struct arm_smmu_strtab_l1_desc *l1_desc; > + unsigned int num_l1_ents; > + > + u64 strtab_base; > + u32 strtab_base_cfg; > +}; > + > +struct arm_lpae_s2_cfg { > + u64 vttbr; > + struct { > + u32 ps:3; > + u32 tg:2; > + u32 sh:2; > + u32 orgn:2; > + u32 irgn:2; > + u32 sl:2; > + u32 tsz:6; > + } vtcr; > +}; > + > +/* An SMMUv3 instance */ > +struct arm_smmu_device { > + struct device *dev; > + void __iomem *base; > + void __iomem *page1; > + > +#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) > +#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) > +#define ARM_SMMU_FEAT_TT_LE (1 << 2) > +#define ARM_SMMU_FEAT_TT_BE (1 << 3) > +#define ARM_SMMU_FEAT_PRI (1 << 4) > +#define ARM_SMMU_FEAT_ATS (1 << 5) > +#define ARM_SMMU_FEAT_SEV (1 << 6) > +#define ARM_SMMU_FEAT_MSI (1 << 7) > +#define ARM_SMMU_FEAT_COHERENCY (1 << 8) > +#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) > +#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) > +#define ARM_SMMU_FEAT_STALLS (1 << 11) > +#define ARM_SMMU_FEAT_HYP (1 << 12) > +#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) > +#define ARM_SMMU_FEAT_VAX (1 << 14) > + u32 features; > + > +#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) > +#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) > + u32 options; > + > + struct arm_smmu_cmdq cmdq; > + struct arm_smmu_evtq evtq; > + struct arm_smmu_priq priq; > + > + int gerr_irq; > + int combined_irq; > + u32 sync_nr; > + u8 prev_cmd_opcode; > + > + unsigned long ias; /* IPA */ > + unsigned long oas; /* PA */ > + unsigned long pgsize_bitmap; > + > +#define ARM_SMMU_MAX_VMIDS (1 << 16) > + unsigned int vmid_bits; > + DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); > + > + unsigned int sid_bits; > + > + struct arm_smmu_strtab_cfg strtab_cfg; > + > + /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ > + union { > + u32 sync_count; > + u64 padding; > + }; > + > + /* Need to keep a list of SMMU devices */ > + struct list_head devices; > + > + /* Tasklets for handling evts/faults and pci page request IRQs*/ > + struct tasklet evtq_irq_tasklet; > + struct tasklet priq_irq_tasklet; > + struct tasklet combined_irq_tasklet; > +}; > + > +/* SMMU private data for each master */ > +struct arm_smmu_master { > + struct arm_smmu_device *smmu; > + struct device *dev; > + struct arm_smmu_domain *domain; > + struct list_head domain_head; > + u32 *sids; > + unsigned int num_sids; > + bool ats_enabled; > +}; > + > +struct arm_smmu_domain { > + struct arm_smmu_device *smmu; > + struct mutex init_mutex; /* Protects smmu pointer */ > + > + bool non_strict; > + atomic_t nr_ats_masters; > + > + enum arm_smmu_domain_stage stage; > + struct arm_smmu_s2_cfg s2_cfg; > + > + /* Xen domain associated with this SMMU domain */ > + struct domain *d; > + > + struct iommu_domain domain; > + > + struct list_head devices; > + spinlock_t devices_lock; > +}; > + > +#endif /* _ARM_SMMU_V3_H */ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:25:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:25:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399225.640323 (Exim 4.92) (envelope-from ) id 1oVKX5-0001Gq-FB; Mon, 05 Sep 2022 22:25:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399225.640323; Mon, 05 Sep 2022 22:25:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKX5-0001Gj-BZ; Mon, 05 Sep 2022 22:25:31 +0000 Received: by outflank-mailman (input) for mailman id 399225; Mon, 05 Sep 2022 22:25:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKX3-0001Gc-TA for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:25:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKX2-0003zM-I3; Mon, 05 Sep 2022 22:25:28 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVKX2-0003oB-BY; Mon, 05 Sep 2022 22:25:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=aZ+QETFKjDryICpffzfkU/TwRnDas8qPNjdsl2OrVl4=; b=D5rnJiwTSCpk/rxHW7BTPLf+fD 3WDtdjUzADm4jx3uegFApnyr5md62f9ud3waWMWGc7TBHvp16mVDICnx8XeaXRWR7gy+3qF3PHW/R z73I0wwpT8uob5FuD20amlA/69UEJQzpBKNBx3OsgOMf+i7MSOIB7COBVbY2r89pPBcI=; Message-ID: <057e2a04-545f-0de8-1d42-8b19ae19f009@xen.org> Date: Mon, 5 Sep 2022 23:25:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu References: <20220818105601.1896082-1-jens.wiklander@linaro.org> <20220818105601.1896082-4-jens.wiklander@linaro.org> From: Julien Grall Subject: Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator In-Reply-To: <20220818105601.1896082-4-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, More remarks. On 18/08/2022 11:55, Jens Wiklander wrote: > +/* Negotiated FF-A version to use with the SPMC */ > +static uint32_t ffa_version __read_mostly; NIT: if this is not meant to be modified after boot, then I would suggest to use __ro_after_init. This was introduced recently and will prevent the variable to be modified after boot. > + > +static bool ffa_get_version(uint32_t *vers) This is not __init. Is this going to be called at runtime by a domain? If yes... > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_VERSION, > + .a1 = FFA_MY_VERSION, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > + { > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); ... this wants to be a XENLOG_G_ERR to rate limited it. XENLOG_ERR is not by default and will allow a domain to spam Xen console. A rule of thumb is any code reachable for a domain (other than dom0) should use XENLOG_G_* when printing or gprintk(XENLOG_*, ) if you want to print the domain ID and ratelimit. Note that the latter doesn't require the G_* becauce it will add it automatically. > + return false; > + } > + > + *vers = resp.a0; > + > + return true; > +} > + > +static u16 get_vm_id(const struct domain *d) > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; > +} > + > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > + register_t v2, register_t v3, register_t v4, register_t v5, > + register_t v6, register_t v7) > +{ > + set_user_reg(regs, 0, v0); > + set_user_reg(regs, 1, v1); > + set_user_reg(regs, 2, v2); > + set_user_reg(regs, 3, v3); > + set_user_reg(regs, 4, v4); > + set_user_reg(regs, 5, v5); > + set_user_reg(regs, 6, v6); > + set_user_reg(regs, 7, v7); > +} > + > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > + uint32_t w3) > +{ > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > +} > + > +static void handle_version(struct cpu_user_regs *regs) > +{ > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + uint32_t vers = get_user_reg(regs, 1); > + > + if ( vers < FFA_VERSION_1_1 ) > + vers = FFA_VERSION_1_0; > + else > + vers = FFA_VERSION_1_1; > + > + ctx->guest_vers = vers; > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > +} > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > +{ > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + > + if ( !ctx ) > + return false; > + > + switch ( fid ) > + { > + case FFA_VERSION: > + handle_version(regs); > + return true; > + case FFA_ID_GET: > + set_regs_success(regs, get_vm_id(d), 0); > + return true; > + > + default: > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); This one definitely want to be a XENLOG_G_ERR. But I would use gprintk(XENLOG_ERR, ). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:41:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:41:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399236.640333 (Exim 4.92) (envelope-from ) id 1oVKmV-0003dr-QN; Mon, 05 Sep 2022 22:41:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399236.640333; Mon, 05 Sep 2022 22:41:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKmV-0003dk-Nd; Mon, 05 Sep 2022 22:41:27 +0000 Received: by outflank-mailman (input) for mailman id 399236; Mon, 05 Sep 2022 22:41:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKmT-0003dd-T4 for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:41:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de1b6056-2d6b-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 00:41:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 59B0160ED5; Mon, 5 Sep 2022 22:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F492C433D6; Mon, 5 Sep 2022 22:41:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de1b6056-2d6b-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662417681; bh=3HlGoPvoNOu2zy39eHiPtPohjAPnGT+sVn4pFvGIjj0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=c/NNt9LxvljVK1Fp73hlUH4VLO13CKhkRo2g33s3wxkbpNDkmoJM+KaARvioZVn6Q h601EuNx2KGRS8egy0b1O6c1qu/udAbXt9XxAEy0FklLMs6XQZc7UYyrHvPwToZeyC FpsiF8SQid58SPErprlVIXX/gWlbqc/aA7jsxWFd0nsyZbi9I1nxctTgNkPFYo3ThK Q/P6/3Fk8OBYHLTYTE+ZbWXTJxWKrTIGg/ZzIbA2RBWz9ar25v1dhbSBT2CjWlWEMJ T6m8KdDquDzbHeKcxaiAk7VkD/G0Svzo21aiHqffqy/gdp84M0BCZDW7AvT59w4Jvb RyrJfUV16+I7g== Date: Mon, 5 Sep 2022 15:41:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: Bertrand Marquis , Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value In-Reply-To: Message-ID: References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1917976994-1662417118=:3931" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1917976994-1662417118=:3931 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 5 Sep 2022, Rahul Singh wrote: > > On 5 Sep 2022, at 1:59 pm, Bertrand Marquis wrote: > > > > Hi Julien, > > > >> On 5 Sep 2022, at 13:08, Julien Grall wrote: > >> > >> > >> > >> On 05/09/2022 12:54, Bertrand Marquis wrote: > >>> Hi Julien, > >>>> On 5 Sep 2022, at 12:43, Julien Grall wrote: > >>>> > >>>> > >>>> > >>>> On 05/09/2022 12:12, Rahul Singh wrote: > >>>>> Hi Julien, > >>>> > >>>> Hi Rahul, > >>>> > >>>>>> On 2 Sep 2022, at 5:20 pm, Julien Grall wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>> On 02/09/2022 16:54, Rahul Singh wrote: > >>>>>>> Hi Julien, > >>>>>> > >>>>>> Hi Rahul, > >>>>>> > >>>>>>>> On 2 Sep 2022, at 4:05 pm, Julien Grall wrote: > >>>>>>>> > >>>>>>>> Hi Bertrand, > >>>>>>>> > >>>>>>>> On 02/09/2022 15:51, Bertrand Marquis wrote: > >>>>>>>>>> On 1 Sep 2022, at 19:15, Julien Grall wrote: > >>>>>>>>>> AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false. I think it would be clearer if ``dom0less_enhanced`` is turned to an enum with 3 values: > >>>>>>>>>> - None > >>>>>>>>>> - NOXENSTORE/BASIC > >>>>>>>>>> - FULLY_ENHANCED > >>>>>>>>>> > >>>>>>>>>> If we want to be future proof, I would use a field 'flags' where non-zero means enhanced. Each bit would indicate which features of Xen is exposed. > >>>>>>>>> I think that could be a good solution if we do it this way: > >>>>>>>>> - define a dom0less feature field and have defines like the following: > >>>>>>>>> #define DOM0LESS_GNTTAB > >>>>>>>>> #define DOM0LESS_EVENTCHN > >>>>>>>>> #define DOM0LESS_XENSTORE > > >>>>>>>>> - define dom0less enhanced as the right combination: > >>>>>>>>> #define DOM0LESS_ENHANCED = (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN| DOM0LESS_XENSTORE) > >>>>>>>> > >>>>>>>> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of defining a bit for gnttab and evtchn. This will avoid the question of why we are introducing bits for both features but not the hypercall... > >>>>>>>> > >>>>>>>> As this is an internal interface, it would be easier to modify afterwards. > >>>>>>> How about this? > >>>>>>> /* > >>>>>>> * List of possible features for dom0less domUs > >>>>>>> * > >>>>>>> * DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and > >>>>>>> * evtchn, will be enabled for the VM. > >>>>>> > >>>>>> Technically, the guest can already use the grant-table and evtchn interfaces. This also reads quite odd to me because "including" doesn't tell what's not enabled. So one could assume Xenstored is also enabled. In fact the wording for ``DOM0LESS_ENHANCED`` is what makes it a lot more confusing. > >>>>>> > >>>>>> So I would suggest the following wording: > >>>>>> > >>>>>> "Notify the OS it is running on top of Xen. All the default features but Xenstore will be available. Note that an OS *must* not rely on the availability of Xen features if this is not set. > >>>>>> " > >>>>>> > >>>>>> The wording can be updated once we properly disable event channel/grant table when the flag is not set. > >>>>>> > >>>>>>> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. > >>>>>> > >>>>>> I would make clear this can't be used without the first one. > >>>>>> > >>>>>>> * DOM0LESS_ENHANCED: Xen PV interfaces, including grant-table xenstore > * and > >>>>>> evtchn, will be enabled for the VM. > >>>>>> > >>>>>> See above about "PV interfaces". So I would suggest to reword to: > >>>>>> > >>>>>> "Notify the OS it is running on top of Xen. All the default features (including Xenstore) will be available". > >>>>>> > >>>>>>> */ > >>>>>>> #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) > >>>>>>> #define DOM0LESS_XENSTORE BIT(1, UL) > >>>>>> > >>>>>> Based on the comment above, I would consider to define DOM0LESS_XENSTORE as bit 0 and 1 set. > >>>>>> > >>>>>>> #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE) > >>>>> Bertrand and I discussed this again we came to the conclusion that DOM0LESS_ENHANCED_BASIC is not > >>>>> the suitable name as this makes the code unclear and does not correspond to DT settings. We propose this > >>>>> please let me know your thoughts. > >>>> > >>>> To me the default of "enhanced" should be all Xen features. Anything else should be consider as reduced/basic/minimum. Hence why I still think we need to add it in the name even if this is not what we expose in the DT. In fact... > >>>>> /* > >>>>> * List of possible features for dom0less domUs > >>>>> * > >>>>> * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > >>>>> * can't be enabled without the DOM0LESS_ENHANCED. > >>>>> * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > >>>>> * default features (including Xenstore) will be > >>>>> * available. Note that an OS *must* not rely on the > >>>>> * availability of Xen features if this is not set. > >>>> > >>>> ... what you wrote here match what I wrote above. So it is not clear to me what's the point of having a flag DOM0LESS_XENSTORE. > >>> When we looked at the code with the solution using BASIC, it was really not easy to understand. > >> > >> I don't quite understand how this is different from ENHANCED, ENHANCED_FULL. In fact, without looking at the documentation, they mean exactly the same... > >> > >> The difference between "BASIC" and "ENHANCED" is clear. You know that in one case, you would get less than the other. > >> > >>> By the way the comment is wrong and correspond to what should be ENHANCED_FULL here > >>> ENHANCED would be the base without Xenstore. > >> > >> Thanks for the confirmation. I am afraid, I am strongly against the terminology you proposed (see above why). > >> > >> I think BASIC (or similar name) is better. But I am open to suggestion so long it is not "DOM0LESS_ENHANCED" vs "DOM0LESS_ENHANCED_FULL". > > > > I do not agree but I think this is only internal and could easily be modified one day if we have more use-cases. > > So let’s go for BASIC and unblock this before the feature freeze. > > > > Bertrand > > Please have a look once if this looks okay. > > /* > * List of possible features for dom0less domUs > * > * DOM0LESS_ENHANCED_BASIC: Notify the OS it is running on top of Xen. All the > * default features (excluding Xenstore) will be > * available. Note that an OS *must* not rely on the > * availability of Xen features if this is not set. > * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > * can't be enabled without the DOM0LESS_ENHANCED_BASIC. > * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > * default features (including Xenstore) will be > * available. Note that an OS *must* not rely on the > * availability of Xen features if this is not set. > */ > #define DOM0LESS_ENHANCED_BASIC BIT(0, UL) > #define DOM0LESS_XENSTORE BIT(1, UL) > #define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE) Let me have a chance to propose a naming scheme as well :-) I agree with Julien: I prefer this proposal compared to the earlier one by Bertrand and Rahul because I think it is a lot clearer and "ENHANCED" should mean everything. Also, it makes it easier from a compatibility perspective because it matches the current definition. But I also agree with Bertrand that "BASIC" doesn't sound nice. I think we should keep "DOM0LESS_ENHANCED" and "DOM0LESS_XENSTORE" as suggested here, but replace "DOM0LESS_ENHANCED_BASIC" with something better. Some ideas: - DOM0LESS_ENHANCED_LIMITED - DOM0LESS_ENHANCED_MINI - DOM0LESS_ENHANCED_NO_XS - DOM0LESS_ENHANCED_GNT_EVTCHN Any of these are better than BASIC from my point of view. Now I am off to get the green paint for my shed. --8323329-1917976994-1662417118=:3931-- From xen-devel-bounces@lists.xenproject.org Mon Sep 05 22:47:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 22:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399243.640345 (Exim 4.92) (envelope-from ) id 1oVKs5-0004II-DZ; Mon, 05 Sep 2022 22:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399243.640345; Mon, 05 Sep 2022 22:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKs5-0004IB-Aw; Mon, 05 Sep 2022 22:47:13 +0000 Received: by outflank-mailman (input) for mailman id 399243; Mon, 05 Sep 2022 22:47:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVKs4-0004I5-NA for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 22:47:12 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad2d9dac-2d6c-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 00:47:11 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F23A460DC5; Mon, 5 Sep 2022 22:47:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E41CCC433D6; Mon, 5 Sep 2022 22:47:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad2d9dac-2d6c-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662418029; bh=D4O0LGnOWLsAdZyvPnicnuMbyeSrlbLmU9Ck6mn2lbs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fW3FHCtgA+E8xkmjL7B+qHAAPwHKMCRT1TU6Lfykjd5DWNDr3Ty7aFVtd9Vz+P+qq 6sddB4f7snmj3Gthd3vQvGmNmMe0tuSQzYsGMzKpmCfI0IqusmD+cg5riul+Ir/zJW biJaEXlbFXnJFrYmmI1R6XBKnaaYdsFky7LyBAZKiLUWdXuqVSmdYfom+rX62wBe6+ N5JTj581F7xXvxNHXJ0ps33jAnGtsSJXTfSOjl13yGGnVygZR0JXjo2CRSo1oW4Lrt 2KTc8j5TbbTLubxxMJ8peEyUWRuatiXj8m4g6IvyV4SCvSJWyN9a/Eh+lH2s5Uko7T IX0JyUGiQs7UA== Date: Mon, 5 Sep 2022 15:47:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Henry Wang cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory In-Reply-To: <20220905072635.16294-2-Henry.Wang@arm.com> Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 5 Sep 2022, Henry Wang wrote: > This commit introduces the reserved heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > Firstly, since a new type of memory bank is needed for marking the > memory bank solely as the heap, this commit defines `enum membank_type` > and use this enum in function device_tree_get_meminfo(). Changes of > code are done accordingly following the introduction of this enum. > > Also, this commit introduces the logic to parse the reserved heap > configuration in device tree by reusing the device tree entry definition > of the static memory allocation feature. If the memory bank is reserved > as heap through `xen,static-heap` property in device tree `chosen` node, > the memory will be marked as heap type. > > A documentation section is added, describing the definition of reserved > heap memory and the method of enabling the reserved heap memory through > device tree at boot time. > > Signed-off-by: Henry Wang > Signed-off-by: Penny Zheng I think the device tree interface is good and you can consider it acked by me. I'll let you follow up on the other comments by others on the code changes. > --- > Changes from v1 to v2: > - Rename the device tree property to xen,static-heap to avoid confusion. > - Change of commit msg and doc wording, correct typo in commit msg. > - Do not change the process_chosen_node() return type. > - Add an empty line in make_memory_node() memory type check to improve > readability. > - Use enum membank_type to make the memory type cleaner. > Changes from RFC to v1: > - Rename the terminology to reserved heap. > --- > docs/misc/arm/device-tree/booting.txt | 45 +++++++++++++++++++++++++++ > xen/arch/arm/bootfdt.c | 31 +++++++++++++++--- > xen/arch/arm/domain_build.c | 8 +++-- > xen/arch/arm/include/asm/setup.h | 7 ++++- > xen/arch/arm/setup.c | 2 +- > 5 files changed, 84 insertions(+), 9 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..ff7ca36715 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -378,3 +378,48 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > + > +Reserved Heap Memory > +==================== > + > +The reserved heap memory (also known as the statically-configured heap) refers > +to parts of RAM reserved in the beginning of boot time for heap. The memory is > +reserved by configuration in the device tree using physical address ranges. > + > +The reserved heap memory declared in the device tree defines the memory areas > +that will be reserved to be used exclusively as heap. > + > +- For Arm32, since there are seperated heaps, the reserved heap will be used > +for both domheap and xenheap. > +- For Arm64, since there is a single heap, the defined reserved heap areas > +shall always go to the heap allocator. > + > +The reserved heap memory is an optional feature and can be enabled by adding > +below device tree properties in the `chosen` node. > + > +The dtb should have the following properties: > + > +- xen,static-heap > + > + Property under the top-level "chosen" node. It specifies the address > + and size of Xen reserved heap memory. > + > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells > + > + Specify the number of cells used for the address and size of the > + "xen,static-heap" property under "chosen". > + > +Below is an example on how to specify the reserved heap in device tree: > + > + / { > + chosen { > + #xen,static-heap-address-cells = <0x2>; > + #xen,static-heap-size-cells = <0x2>; > + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; > + ... > + }; > + }; > + > +RAM starting from the host physical address 0x30000000 of 1GB size will > +be reserved as heap. > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index ec81a45de9..5af71dc8ba 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > static int __init device_tree_get_meminfo(const void *fdt, int node, > const char *prop_name, > u32 address_cells, u32 size_cells, > - void *data, bool xen_domain) > + void *data, membank_type type) > { > const struct fdt_property *prop; > unsigned int i, banks; > @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, > continue; > mem->bank[mem->nr_banks].start = start; > mem->bank[mem->nr_banks].size = size; > - mem->bank[mem->nr_banks].xen_domain = xen_domain; > + mem->bank[mem->nr_banks].type = type; > mem->nr_banks++; > } > > @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, > void *data) > { > return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, > - data, false); > + data, MEMBANK_MEMORY); > } > > static int __init process_reserved_memory_node(const void *fdt, int node, > @@ -301,6 +301,28 @@ static void __init process_chosen_node(const void *fdt, int node, > paddr_t start, end; > int len; > > + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) > + { > + u32 address_cells = device_tree_get_u32(fdt, node, > + "#xen,static-heap-address-cells", 0); > + u32 size_cells = device_tree_get_u32(fdt, node, > + "#xen,static-heap-size-cells", 0); > + > + printk("Checking for reserved heap in /chosen\n"); > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: node `%s': invalid #xen,static-heap-address-cells or #xen,static-heap-size-cells\n", > + name); > + return; > + } > + > + if ( device_tree_get_meminfo(fdt, node, "xen,static-heap", > + address_cells, size_cells, > + &bootinfo.reserved_mem, > + MEMBANK_RSVD_HEAP) ) > + return; > + } > + > printk("Checking for initrd in /chosen\n"); > > prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); > @@ -358,7 +380,8 @@ static int __init process_domain_node(const void *fdt, int node, > "#xen,static-mem-size-cells", 0); > > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > - size_cells, &bootinfo.reserved_mem, true); > + size_cells, &bootinfo.reserved_mem, > + MEMBANK_XEN_DOMAIN); > } > > static int __init early_scan_node(const void *fdt, > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..1e46b95f0b 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, > if ( mem->nr_banks == 0 ) > return -ENOENT; > > - /* find first memory range not bound to a Xen domain */ > - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) > + /* find first memory range not bound to a Xen domain nor heap */ > + for ( i = 0; i < mem->nr_banks && > + (mem->bank[i].type != MEMBANK_MEMORY); i++ ) > ; > + > if ( i == mem->nr_banks ) > return 0; > > @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, > u64 start = mem->bank[i].start; > u64 size = mem->bank[i].size; > > - if ( mem->bank[i].xen_domain ) > + if ( mem->bank[i].type == MEMBANK_XEN_DOMAIN ) > continue; > > dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..d0cc556833 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -22,11 +22,16 @@ typedef enum { > BOOTMOD_UNKNOWN > } bootmodule_kind; > > +typedef enum { > + MEMBANK_MEMORY, > + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain. */ > + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */ > +} membank_type; > > struct membank { > paddr_t start; > paddr_t size; > - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > + membank_type type; > }; > > struct meminfo { > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 6e0398f3f6..8d3f859982 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) > > for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) > { > - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) > + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_XEN_DOMAIN ) > { > mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); > unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 05 23:22:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 23:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399252.640356 (Exim 4.92) (envelope-from ) id 1oVLPc-00008y-8Q; Mon, 05 Sep 2022 23:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399252.640356; Mon, 05 Sep 2022 23:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVLPc-00008r-4z; Mon, 05 Sep 2022 23:21:52 +0000 Received: by outflank-mailman (input) for mailman id 399252; Mon, 05 Sep 2022 23:21:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVLPb-00008l-7R for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 23:21:51 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 844e5d96-2d71-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 01:21:49 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8155AB815F0; Mon, 5 Sep 2022 23:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B74DC433D6; Mon, 5 Sep 2022 23:21:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 844e5d96-2d71-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662420107; bh=63tJtpZoPgyfLZgi2FZnF3BpCtPOFfJWkevsfGMuQbE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TaUu0eHFxeC9D3A+emIlo1tGWqTOdorIXaEPHMpLDWUl3prJm/3j+iWcdECv6vUZ/ FSfLtIYVzhWJj7TvFyXUTf9EKpNO7niWQKLDjpn7VX6eMLFERiPO0vdtT14iE557h+ Hn/EZTsAsvzywO/QP0QN+fq5S/4SYN4l91R3duNJtySa//6Q2L4ViEFcT87PPopRAD bfHQmz9u7c58LXAAaCI9u0sTuDwssxY6Rmjkv/uNVgvI7092HT76YpTICcPsVBvwIG ZzLarHeYaC9bqH8W8GfeTVDjMBPYCMYhEartAbIPqhN3ZjFd01HNupivd7+EE88cx7 4W3Hz4FoSSXKw== Date: Mon, 5 Sep 2022 16:21:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Doug Goldstein Subject: Re: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 In-Reply-To: <98b712c1-2a02-9baa-b816-3c28cccaf74e@amd.com> Message-ID: References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-4-michal.orzel@amd.com> <98b712c1-2a02-9baa-b816-3c28cccaf74e@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 5 Sep 2022, Michal Orzel wrote: > Hi Stefano, > > On 03/09/2022 01:49, Stefano Stabellini wrote: > > > > > > Currently this test fails with: > > > > + fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled > > + [[ boot-cpupools == \b\o\o\t\-\c\p\u\p\o\o\l\s ]] > > ++ fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle > > Error at 'phandle': FDT_ERR_NOTFOUND > My bad. The qemu version used by CI does not generate phandles for cpus. > So the fix is very straightforward and requires putting custom phandle for cpu@1. > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index c2184850293c..158d5665d71d 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -50,8 +50,9 @@ fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled > > if [[ "${test_variant}" == "boot-cpupools" ]]; then > # Create cpupool node and assign it to domU0 > - cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" > + cpu_phandle="0xfffffe" > cpupool_phandle="0xffffff" > + fdtput binaries/virt-gicv2.dtb -p -t x /cpus/cpu@1 phandle $cpu_phandle > fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool > fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle > fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle > > Given my other comment below, I would leave this code as is. > > > > > >> +if [[ "${test_variant}" == "boot-cpupools" ]]; then > >> + # Create cpupool node and assign it to domU0 > >> + cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" > >> + cpupool_phandle="0xffffff" > >> + fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool > >> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle > >> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle > >> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/domU0 domain-cpupool $cpupool_phandle > >> + > >> + # Check if domU0 (id=1) is assigned to Pool-1 > >> + passed="${test_variant} test passed" > >> + dom0_check="if xl list -c 1 | grep -q Pool-1; then echo ${passed}; fi" > >> +fi > > > > I would prefer to keep the device tree editing here to a minimum and > > instead add boot-cpupool support in ImageBuilder and add CPUPOOL* config > > options to the existing config file for ImageBuilder created in this > > file below. This way, we keep this test cleaner and we help more the > > user by proving a way to set boot-cpupools more easily in general, also > > useful outside gitlab-ci. > > I agree that ImageBuilder is a great tool. However, I would opt for keeping what I did because of the following: > - current release schedule (we could benefit from having a test for 4.17 feature instead of waiting for the corresponding > change to be done in ImageBuilder first and tested), > - test is already prepared and requires just a trivial fix, > - we should not enforce users willing to add tests to gitlab-ci to always prepare the ImageBuilder changes first. > ImageBuilder is not meant to support all the features strictly because some of them require too much > end-user knowledge and digging into device tree (it should stay as simple as possible), > - all in all we need to have a way to modify the dtb and fdtput is certainly better than sed as it does not > require additional steps for decompilation/compilation and its commands look more clean than using sed transformation. > > Let me know what you think. > > On a side note, I can add boot-time cpupools support in ImageBuilder to my TODO list so that we can check if this is something > ImageBuilder should support. If yes, we can modify this test after the release. Yeah, ImageBuilder doesn't necessarely need to support every feature. However, a tool (if not ImageBuilder, Lopper, or a new ImageBuilder script) should support CPUPOOLs to enable the user. You are right that ImageBuilder is not necessarely tied with gitlab-ci. This is especially true once we start doing more interface-level testing, such as hypercalls fuzzing with XTF. We are not going to be able to use ImageBuilder to trigger every possible device tree boot time combination, especially the ones that are invalid. We want to be able to test Xen with invalid device tree input as well. In addition to interface-level testing, we need user-level testing to test features the way we expect a user to use them. This is what ImageBuilder is for and that is why it has been used today in gitlab-ci. On ARM today we only have user-level testing in gitlab-ci, but I'd love to have more interface-level testing, which will surely require more device tree manipulations outside of ImageBuilder. - user-level tests -> ImageBuilder, common valid configurations - interface-level tests -> not ImageBuilder, various valid and invalid configurations, maybe automatically generated? Device tree manipulations expected in gitlab-ci. In my view, this test belongs to the "user-level test" category, this is why I would prefer if it was done using the same tool that we expect the user to use. Ideally, it would be ImageBuilder because that is the tool that we have used so far (but it could be a new script under ImageBuilder or Lopper). But I understand deadlines, release schedule, etc., so if you think it cannot be done properly using ImageBuilder in 2-3 days, then I would take this patch as is, and we can revisit it in the future as you suggested. I am OK with that too. > I can already think of the following IB config options that would need to be introduced to properly support boot-time cpupools: > CPUPOOL[number] = " " - to create cpupools > NUM_CPUPOOLS = "" - to keep the number of created cpupools > DOMU_CPUPOOL[number] = "CPUPOOL[number]" - to assing domU to one of the created cpupools > So we already have 3 new options and the number of required sanity checks I can think of is significant. > Even then, we could easily trigger a failure e.g. if user assigns cpus of different type and does not pass hmp-unsafe=1. As we both wrote above, ImageBuilder doesn't need to support every feature and every possible way a feature can be used. Only the most common ones. I don't think we want to support the case where a user assigns cpus of different type. I think you are right that these are the interesting options at the ImageBuilder level: NUM_CPUPOOLS="" CPUPOOL[number] = " " DOMU_CPUPOOL[number] = "CPUPOOL[number]" The last one could also be: DOMU_CPUPOOL[number] = "CPUPOOL" # e.g. DOMU_CPUPOOL[1] = "CPUPOOL2" From xen-devel-bounces@lists.xenproject.org Mon Sep 05 23:48:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 23:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399259.640366 (Exim 4.92) (envelope-from ) id 1oVLop-0002eO-A5; Mon, 05 Sep 2022 23:47:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399259.640366; Mon, 05 Sep 2022 23:47:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVLop-0002eH-7W; Mon, 05 Sep 2022 23:47:55 +0000 Received: by outflank-mailman (input) for mailman id 399259; Mon, 05 Sep 2022 23:47:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVLom-0002eB-Kp for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 23:47:53 +0000 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 271acfe5-2d75-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 01:47:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 271acfe5-2d75-11ed-a016-b9edf5238543 Date: Mon, 5 Sep 2022 19:46:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662421670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aV58+8xM7vZiC+ARHrNwrMa2NOiuYoscS5I3pyUTgBc=; b=g/enLV1JWMwpy1AyXIuK4kHtWcmra4fxFsTUcPxQ3hUWakh3HZFxjFpnVO9NhK3wjScc9f irWUYVuNDjD8ENf7YkMd2RUCrJ2/ViqqPY2BhztGYYDjlWUSm+DOVdUpVQh8M2jqIup2FQ tYI+IaNim7kGQArVz8zbq85hmG2o2lA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220905234649.525vorzx27ybypsn@kmo-framework> References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901201502.sn6223bayzwferxv@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Mon, Sep 05, 2022 at 10:49:38AM +0200, Michal Hocko wrote: > This is really my main concern about this whole work. Not only it adds a > considerable maintenance burden to the core MM because [citation needed] > it adds on top of > our existing allocator layers complexity but it would need to spread beyond > MM to be useful because it is usually outside of MM where leaks happen. If you want the tracking to happen at a different level of the call stack, just call _kmalloc() directly and call alloc_tag_add()/sub() yourself. From xen-devel-bounces@lists.xenproject.org Mon Sep 05 23:51:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 05 Sep 2022 23:51:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399266.640377 (Exim 4.92) (envelope-from ) id 1oVLs2-00044A-OJ; Mon, 05 Sep 2022 23:51:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399266.640377; Mon, 05 Sep 2022 23:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVLs2-000443-LZ; Mon, 05 Sep 2022 23:51:14 +0000 Received: by outflank-mailman (input) for mailman id 399266; Mon, 05 Sep 2022 23:51:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVLs1-00043x-DZ for xen-devel@lists.xenproject.org; Mon, 05 Sep 2022 23:51:13 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ec23c99-2d75-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 01:51:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ec23c99-2d75-11ed-af93-0125da4c0113 Date: Mon, 5 Sep 2022 19:50:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662421870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L/QtR7clKwa18sm3kCbVwFkkFjR319r9zDLdSKgBl/k=; b=K0AUlJQwh12ArX3Ivo5AajZFTOnj8fptPh9b/mWIPD8nscGPgO8kw0SNz+Kn/2nIaB9e9i 7R3FAk1ULpUqZb/f26WREIzq78CmF0IzVffZPJjJ7RbMsrYAMZ8f5FwzvnmygEisggBmw5 5Icx4XHaZKC0M/ASUBy2hcvuJroZdmk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Suren Baghdasaryan , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220905235007.sc4uk6illlog62fl@kmo-framework> References: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220905110713.27304149@gandalf.local.home> <20220905204229.xqrqxmaax37n3ody@moria.home.lan> <20220905181650.71e9d02c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905181650.71e9d02c@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Mon, Sep 05, 2022 at 06:16:50PM -0400, Steven Rostedt wrote: > On Mon, 5 Sep 2022 16:42:29 -0400 > Kent Overstreet wrote: > > > > Haven't tried that yet but will do. Thanks for the reference code! > > > > Is it really worth the effort of benchmarking tracing API overhead here? > > > > The main cost of a tracing based approach is going to to be the data structure > > for remembering outstanding allocations so that free events can be matched to > > the appropriate callsite. Regardless of whether it's done with BFP or by > > attaching to the tracepoints directly, that's going to be the main overhead. > > The point I was making here is that you do not need your own hooking > mechanism. You can get the information directly by attaching to the > tracepoint. > > > > static void my_callback(void *data, unsigned long call_site, > > > const void *ptr, struct kmem_cache *s, > > > size_t bytes_req, size_t bytes_alloc, > > > gfp_t gfp_flags) > > > { > > > struct my_data_struct *my_data = data; > > > > > > { do whatever } > > > } > > The "do whatever" is anything you want to do. > > Or is the data structure you create with this approach going to be too much > overhead? How hard is it for a hash or binary search lookup? If you don't think it's hard, go ahead and show us. From xen-devel-bounces@lists.xenproject.org Tue Sep 06 00:38:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 00:38:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399273.640388 (Exim 4.92) (envelope-from ) id 1oVMbT-0000cj-Q5; Tue, 06 Sep 2022 00:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399273.640388; Tue, 06 Sep 2022 00:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVMbT-0000cc-NQ; Tue, 06 Sep 2022 00:38:11 +0000 Received: by outflank-mailman (input) for mailman id 399273; Tue, 06 Sep 2022 00:38:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVMbS-0000cS-8B; Tue, 06 Sep 2022 00:38:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVMbS-0006tD-1Z; Tue, 06 Sep 2022 00:38:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVMbR-0008GH-JE; Tue, 06 Sep 2022 00:38:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVMbR-0003MN-Ii; Tue, 06 Sep 2022 00:38:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Qlk1/wgep7CWvBzJPv0h37RV23Q/s2CjPKtePA3APKA=; b=0WhNYaSnQS/iSzD4HtEbb4Fd88 NX3KTUhQGORndGxFn1T6gTuv/Agk3QVwDvNbxZfUW8gdItqwHxf33pa3p+VxEi+uwAnYgHI74oQN5 ns79Gm3/bnWQKCZeJmBBMG0oc8BZ296jxnR5iPpU9BpA2gy6nrTPh/gzVFqW1IXYBKqE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173004: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-migrupgrade::broken:regression xen-unstable:test-amd64-amd64-migrupgrade:host-install/src_host(6):broken:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d84473689611eed32fd90b27e614f28af767fa3f X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Tue, 06 Sep 2022 00:38:09 +0000 flight 173004 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173004/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade broken test-amd64-amd64-migrupgrade 6 host-install/src_host(6) broken REGR. vs. 172993 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 172993 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 172993 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172993 build-i386-libvirt 6 libvirt-build fail like 172993 build-arm64-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172993 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172993 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172993 build-armhf-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen d84473689611eed32fd90b27e614f28af767fa3f baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172993 2022-09-05 01:52:22 Z 0 days Testing same since 173004 2022-09-05 14:38:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade broken test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-migrupgrade broken broken-step test-amd64-amd64-migrupgrade host-install/src_host(6) Not pushing. ------------------------------------------------------------ commit d84473689611eed32fd90b27e614f28af767fa3f Author: Juergen Gross Date: Mon Sep 5 09:00:05 2022 +0200 xen/sched: fix cpu hotplug Cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() with interrupts disabled, thus any memory allocation or freeing must be avoided. Since commit 5047cd1d5dea ("xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()") this restriction is being enforced via an assertion, which will now fail. Fix this by allocating needed memory before entering stop_machine_run() and freeing any memory only after having finished stop_machine_run(). Fixes: 1ec410112cdd ("xen/sched: support differing granularity in schedule_cpu_[add/rm]()") Reported-by: Gao Ruifeng Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper commit d42be6f83480b3ada286dc18444331a816be88a3 Author: Juergen Gross Date: Mon Sep 5 09:00:04 2022 +0200 xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() In order to prepare not allocating or freeing memory from schedule_cpu_rm(), move this functionality to dedicated functions. For now call those functions from schedule_cpu_rm(). No change of behavior expected. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper Reviewed-by: Andrew Cooper commit a83fa1e2b96ace65b45dde6954d67012633a082b Author: Juergen Gross Date: Mon Sep 5 09:00:03 2022 +0200 xen/sched: introduce cpupool_update_node_affinity() For updating the node affinities of all domains in a cpupool add a new function cpupool_update_node_affinity(). In order to avoid multiple allocations of cpumasks carve out memory allocation and freeing from domain_update_node_affinity() into new helpers, which can be used by cpupool_update_node_affinity(). Modify domain_update_node_affinity() to take an additional parameter for passing the allocated memory in and to allocate and free the memory via the new helpers in case NULL was passed. This will help later to pre-allocate the cpumasks in order to avoid allocations in stop-machine context. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 00:58:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 00:58:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399284.640400 (Exim 4.92) (envelope-from ) id 1oVMuv-00037U-Li; Tue, 06 Sep 2022 00:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399284.640400; Tue, 06 Sep 2022 00:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVMuv-00037N-Ik; Tue, 06 Sep 2022 00:58:17 +0000 Received: by outflank-mailman (input) for mailman id 399284; Tue, 06 Sep 2022 00:58:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVMuu-00037H-EC for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 00:58:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fba44f57-2d7e-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 02:58:14 +0200 (CEST) Received: from AS9PR06CA0140.eurprd06.prod.outlook.com (2603:10a6:20b:467::26) by PAVPR08MB9306.eurprd08.prod.outlook.com (2603:10a6:102:305::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Tue, 6 Sep 2022 00:58:10 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::3c) by AS9PR06CA0140.outlook.office365.com (2603:10a6:20b:467::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Tue, 6 Sep 2022 00:58:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 00:58:10 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Tue, 06 Sep 2022 00:58:09 +0000 Received: from 3748e944446f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A18E72DB-0F2E-45EF-823C-54BBCF1D7B5E.1; Tue, 06 Sep 2022 00:58:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3748e944446f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 00:58:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 00:58:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 00:58:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fba44f57-2d7e-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=k8UyiCeZHifYZLUWfOYCKL9HkE6rQxquIVtckdWfQ52feCTdZYf6ISr/VNUnRYVI/HemvmNYfMZ0nuvRQRZZQEX7qzHDkzfKQq6yYeGV7iNvra1k917iS3xSF4K/eKMULwrcjQ/n5N7aD4hEtvvG7Ss1/cZztu7p4k4+65Ify22oRs10ydOoXsG5gTD5HqxLoU003qlGKs0rZvvWffZq/uXqXHXs0t+VB9sNKshYlcaG1yr2Ztbg1gc8j2qVSYW4gOSOfkkyTDomNVYLUgy/LmPpZOpX7iDYed97hOwe6IVAvxXlpi0+h+s3FZKhFv3s155UykoWfUs8nQnGF+XEzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L7J9WA2MFUmhguNx9IeUrNKEVRRslrxh9aiMqFwCYn4=; b=E9Uf8jslrwf6XMtAbVVTtT252CcYw8XzqitYPnxs2Xsn7rL2DLTZyy1DkrIoowKUsXZLyyL2kSMJ2ncTQ/gJvCg/UQioiGwDIa5w0do78yKimJaJOXse+5xjnC4sJeiFW18r4dvwp/tR0P68ElOAU1+ok/62tcD2xFCjt2vh7yG8DXr1acaA8q8P0Zlg0slL9Z1mDtlJjULaoyjv8h4tLCUpN2RojfWHg/5jKkx432HK1typNUYCGrAo5l5Trwj7H+oABCwq8thjtwKSMM51rnHz/xDGEJ6RBPj1KL8stQtQr9O4tD1UZ2wEIIXYu74b+wCU4PfoR/pZOXXGBgbvNQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L7J9WA2MFUmhguNx9IeUrNKEVRRslrxh9aiMqFwCYn4=; b=LCQXIj9xjDK7/4wD6Jy+0j3v0UiqH9XcdttG4HQJ+bQC7G1Af2e4jeWyYbr8aA6rAwCgpL/9orlcOugKKkoPmKRKEtk4iCDYAsE60onZAfSR2XdzxWirTTPEX5ZljxeDXwijqpSgxgx1nU0nXPbNuu8mbM/M5yzH/TlqrLfvuyo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=INtsuPp9l5pGtsUz+HKc15hbK8Xj8C+7ckzcGb6RM13pmQN6wh2KqoDcQFOXlNNEg8+jxNbUcLhDNjknwgoYaB3fgWHxpmPRLyQxlkF+a61njOhycRqZZ3uel3DNEbr2BjNAmDLEwlr5x4YNbHA9ZU1H+pZAta5Sa2kDwmjMuJgLXYmJLPeGYl/KJcTyx+JPMg5iqIjZinNy+wRzSmJJDrgZvXx2LGPBo3hHrjOMxO/k20bbEWjQR7jJGzvbNGSF9344ey3DuVoK1674tyuInuIaeVB4uj8u7CNOjIbtPN9EuLaOy6wkEvPHC/sCR37SqU/dlmmZLIKS45agfnC/Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L7J9WA2MFUmhguNx9IeUrNKEVRRslrxh9aiMqFwCYn4=; b=L/wjNlD+aXh0SYhNp1jbOBtJzhLXk/Gi34rg3tMxvWpASteDR3vOU312l5XIK89KJphsFhqqxqzvwM20OKMfsUq3ft9AzhGI/RXKIk0f4WXiEOSzS+/tbdaU3HKqZwjbGWzS/ZEn6fROE3yO1ZFalrg6M3xQ96cED4ln+h4rfoEdtqqyUuFdciJ9p+RILJmvJ3Ick5vwTKoWxCD3kUAMq28iEszdsq+fHqO+WYyV+R1r1JV8pLPYOQM2FZzd5LL7YMPXLXsUYBd4SmmbnzQwWkE1MAFo9b8EfR1LLT3QZrVadw2FyabpzHiuD1TA6eVZ0vFz0HqZdjtpKu+jfdLEZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L7J9WA2MFUmhguNx9IeUrNKEVRRslrxh9aiMqFwCYn4=; b=LCQXIj9xjDK7/4wD6Jy+0j3v0UiqH9XcdttG4HQJ+bQC7G1Af2e4jeWyYbr8aA6rAwCgpL/9orlcOugKKkoPmKRKEtk4iCDYAsE60onZAfSR2XdzxWirTTPEX5ZljxeDXwijqpSgxgx1nU0nXPbNuu8mbM/M5yzH/TlqrLfvuyo= From: Henry Wang To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: RE: Xen 4.17 release: Current status before the feature freeze Thread-Topic: Xen 4.17 release: Current status before the feature freeze Thread-Index: AdjA2VmJ6EcVoZ5cTOOgVSRHep4cQAAXrAGAABTkYBA= Date: Tue, 6 Sep 2022 00:58:01 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B0DD53D62E228243AD048BF80D9AC04B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2b39a105-464b-4803-adb7-08da8fa2de43 x-ms-traffictypediagnostic: PA4PR08MB6080:EE_|AM7EUR03FT052:EE_|PAVPR08MB9306:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vOtXtVUX5R+Gkqv8uoA5jqfE/fzQmNFaIjMr02I7OtHIEXRhMRFyAlVr1xPwp6VgQ9ODUUFeCwXbpK+D4uRjxJabL61upeXXtPS0cI0HlJeKBtXl1IyLXHao8zW3Tyjn2J1qpAKqMm2g8prw5S85COR6/bPWNtlEVXyYPoVJnS7HXzGoyQqu2y4Ob4mwGcRtklHVJPFrwuiC+d5eyZuI+qGy22IgRkMBs0Qnyb8MBiOKB1dzh9wHUUXaR9hBxzpjy521tBfvayrrBufCwTepZR+tsdJPW+r9R/2n3giU0IujvraxL1VUi/926MGw1xqTPFU/cEDI4vM6PoayaTZpBt7JgnGi21Rm45g+orkjsFgMEWk+83yM9QK0KouPyV0ZmTdNfPRsk+9YldTEFxCsr7GO0O8/okuzTY8T/WN08jgR+WytStDQnaO9VnXLrRP9U34hh2+oAqeeLrX2QCzLnz5Ng6Pvfn98GbiO6DDL16ecGiWj2X1rFY++D27Nq1tzED4wvbi2wSx4PYDASTbCJhkRzVBYeXMfbIL1Y0AiAPfSppZ3edz0O0KBv/EsK2zfJr4fyI1gxyoz6ZojD2fUkOkFMWio56n15S6ko6lCsxmqCG+ZauKjeobCWHNGclNJQlYyKMw8GTdBQIq93W8RuvBtmf2Vw34GzPDN2HnFJfU4+o5SQToav2p04fEc6r5z3NKzoEKLMoRZAOdqwZaseGmzk1Zz3qBor+o0kLH5HsslY5LWjvcsFi2Yj67gJsKZ6cwJFQUeBV6vNEHU5EZYSFgQc9LCBkl/ibfnf8zrq2U= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(39860400002)(366004)(136003)(54906003)(6916009)(9686003)(55016003)(316002)(38100700002)(122000001)(38070700005)(2906002)(86362001)(8936002)(5660300002)(64756008)(83380400001)(76116006)(66446008)(4326008)(8676002)(52536014)(66556008)(33656002)(66946007)(966005)(71200400001)(41300700001)(186003)(66476007)(6506007)(7416002)(478600001)(26005)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d1e8a26a-980f-487f-0918-08da8fa2d8e0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 08vUvFlsWFSz9kehAIt798GSwho8yscrvh2bEp3xMcY7QbitF+5bvYslfQGXvbAUoRfBtYT/YIG5Tuhhho3BwVAo4/BFJn+gT1JZ1bCQG+ERw5rHo9hCI26bN2H9vIv2W9oDQkKstKpRbKuef8+PDVypbtxcMCg18FW2Hr5YuCoC4WDoNHED7YXCS/XyuJa3QIRruiu0h7Pj+m1Es7msncH9gDXgqsV7FR7Dt6M9y9X8qtklsfORbW2zyby3nUBJqdbvLaU3Q26BaYHNHWqOTrKaE2XGj/Lm1aHvTt2DEonKHmEVZfO+8Va2gs40o5mR8K5vm7+K2yNBTchZFPN57Fb9tir65SvHOIUskPl9d3XgDpN/TW2twls3YkBtWGi8P1WHUcLdRRpMjU+wGUvvcgAD/4J4x6/gwfhdYej16D5zt2YkYwKbVfd+I6w7Krura6Ozg6Dj7JjOh6gXfPqYYKxL9GjsZQOhru2Wq4MyLAteGKvJafDHwlPEraNIUVQ7uFiCt+/ZqAKMRUD9/HXWZTfpDQCvbaNoZcFXT94bbmd2Dsx/7ZWY0h/nFFragX0eizG3XdM73wkTX4rd5NFR53+c85An8ljVZ2FfsVJfPc3q9ocx7kbmYBP7Ya4GrMbGTjJ183hVwb6BuHpweoHALxe9rLZFg2qYk7sTKJgtcFDron8zfJR8HjAVW4Df5c5tj6XXWDw+syR23+G9qZU3d3sw6QMCB5AeETYCviT2sB+tdV3YA/Q+AL0LzR3e9tT4ogCF0PF2rRqkDOZrc6xm0YbCHvfgJt9Wc5fqyI0uXRU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(376002)(396003)(40470700004)(36840700001)(46966006)(82740400003)(8676002)(356005)(4326008)(70586007)(36860700001)(81166007)(70206006)(336012)(186003)(966005)(41300700001)(40460700003)(47076005)(107886003)(7696005)(6506007)(9686003)(54906003)(478600001)(26005)(83380400001)(8936002)(40480700001)(82310400005)(52536014)(55016003)(5660300002)(316002)(2906002)(33656002)(86362001)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 00:58:10.2172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b39a105-464b-4803-adb7-08da8fa2de43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9306 Hi Anthony, > -----Original Message----- > From: Anthony PERARD > Subject: Re: Xen 4.17 release: Current status before the feature freeze >=20 > On Mon, Sep 05, 2022 at 03:44:33AM +0000, Henry Wang wrote: > > ** Blocker List **: > > 2. The fix of libvirt after the virtio support in toolstack > > Status: The OSSTEST seems to work properly, apart from what Jan > > asked in IRC - the qemu and omvf OSSTEST might need a force push. > > (I am not sure if this has been fixed so I just carried this) >=20 > The build fix for libvirt have been applied to the project libvirt. >=20 > osstest needs to be updated to be able to build recent version of > libvirt. But we'll have to wait until Roger is back to update osstest > (patch for osstest are available). >=20 > Once osstest is updated, it should be able to test the recent version of > libvirt and then start to use it with other branch (qemu and ovmf). > I don't think a force push for qemu and ovmf is necessary, and fairly > soon not needed. Thanks for the information. I am personally good with it. >=20 >=20 > > ** Common **: > > 10. [XEN,v2] build: Fix x86 out-of-tree build without EFI > > https://patchwork.kernel.org/project/xen-devel/list/?series=3D668331 > > Status: Reviewed but not merged. >=20 > I believe this should be a blocker. And the status might be that I need > to update the patch. Sure, added to my list. Kind regards, Henry >=20 > Cheers, >=20 > -- > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 01:04:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 01:04:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399291.640411 (Exim 4.92) (envelope-from ) id 1oVN0s-0002pR-A0; Tue, 06 Sep 2022 01:04:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399291.640411; Tue, 06 Sep 2022 01:04:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVN0s-0002pK-7I; Tue, 06 Sep 2022 01:04:26 +0000 Received: by outflank-mailman (input) for mailman id 399291; Tue, 06 Sep 2022 01:04:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVN0q-0002pE-LN for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 01:04:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8214f72-2d7f-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 03:04:23 +0200 (CEST) Received: from AM5PR0701CA0060.eurprd07.prod.outlook.com (2603:10a6:203:2::22) by AS8PR08MB7919.eurprd08.prod.outlook.com (2603:10a6:20b:53a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 01:04:21 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::c9) by AM5PR0701CA0060.outlook.office365.com (2603:10a6:203:2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 01:04:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 01:04:19 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Tue, 06 Sep 2022 01:04:19 +0000 Received: from e9246f6743a6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD97E2B7-20B2-427A-9F7D-D4B2A5452C59.1; Tue, 06 Sep 2022 01:04:09 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9246f6743a6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 01:04:09 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB7699.eurprd08.prod.outlook.com (2603:10a6:10:392::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 01:04:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 01:04:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8214f72-2d7f-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cRbayMubTXxgkDD4uRU6D82LCVGKDxhiiTUEkVA+G+VhWrij3rWH9jAiy1jRucZevJ2m6pMarPfernKH/9NXhMuc5yQlnxRg+uFPzHKXu5IhNMrZH71GfrVxDxAd8x+c1K8zyNHfHQADvo+MJX8r8vRwdxZht1wEPiaYNg+pFWpOSdADTuEoai2YtFjYJp7P2yELvN/9ZlvWJOCi7AZvrfF0c2nZ0cGu+K/tYMBmZ7MCdUoekhT2i1QH3cIzv/smTYJXONqtroCbvd+eqlJW1WpKrSD9iASFmG6i/C6/rt6+G5FktNF5IsKWDpEqBHAsLrojIViNyzloHLFsxt3J9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vww4n9Oj/OmLWXmWO6p4e6ZT2aAz3ONu39QJ6TLyNnc=; b=M+x/hphgT3V88UrKH4llwUU+o7VbkV2e69liF4VeH7/L3yg0LvFSa2Fb8fNvKxwIoPjet76qX5tIvv+xJUv9RnqJvYoEkozLYquWBiC2RM9Zo9i9s9Kg4UoL9bjN1AdYsDArciSKEX24581uQn58aeRrJjPiPXKycw2JFXRXNSISD5vQiXjnfYcl3Nw7WaMXrI98FbXx6E3hBAbQRaOkyb6F0MRBGwwv8VkqNeNnbj/2T+9CoWn4ejTat4pZkfPS4ryudpD8gBAm81V2CAzbFcBZjM6hNqgULudid9kftVsg9nACQMlfzAGeMmYLfVhZKSjeDxKCjDmGBCAK/8FEZw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vww4n9Oj/OmLWXmWO6p4e6ZT2aAz3ONu39QJ6TLyNnc=; b=FxSDvHc9PzB03/NaDGsdtR+PCUgppinSzmpB4nwDKl4UfUQn467bRZFq9Q2lZJoDvb72r+PDmU6uV9Jh7CDg+ozze/x2jfY5G4tFoEtGXgC3m2mcIUQ1EMzRdesy6QhlBJcs2ENXCuAdnOHJh2zGCnecgVwbojw9PZW6wLLTHeI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kt950srEvHf3oBdQzApxxnWMNtCrAf6vepKjN6G7Mw50/OrvvtnHY4fUt5stEzrq8Rm+AwxxrBkr8KzuyrynYUP3FVEOknmXTszofdZHMrEzzQTjROsfxKLcde1rKDyRAkAfcELNyzE+oqhJkqBz7M9w3t7qem7UYNUBsdbSWE9FMbNb520tGXGfZFnXdIm6LPW55rFtyj3RhcvGvDZ4TGQuX9yfzTln4bAQYGg5kl4YivAIG0Jvs9DWusETfFquAmUpols6at4M8b2mGxZfDBKwe+QMTTXTRVurBb7FA7UTMd6lIq5q+Bc1MjYinAVEfDbfjxu6FTnFsurW9aTJcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vww4n9Oj/OmLWXmWO6p4e6ZT2aAz3ONu39QJ6TLyNnc=; b=Ij6zJryiShGuzzizS7WyBJ0ksknOT5Clzv8Xeu9jL/K0I0F+ug8P5yxam3PUob29SW6NoYc+lXY8n0EgXbWKoQxPsL/xUn7QD28mxiKpvbDMJoHCjjo3T/ayenCzMuDX3BpJl+mY1uLjo+paVTeEiyg0fEkhjuCljVDXlgkzTRnm+yNnelcZlvfs61O9n4p/qQ0yvSfnQPRw8smVUCX4MDLRaeOLZUnQQ7tQzfDzvXnE0Exago4ohPP2mnUdpX4aJMcrswheLlo3lYnv8OsEMCjUM3Xj+yPO8Z/72Qn1/Q5CjkkwGnlrh/v0VqOPvxeuzuqACbCLhZbAjZcN51NV8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vww4n9Oj/OmLWXmWO6p4e6ZT2aAz3ONu39QJ6TLyNnc=; b=FxSDvHc9PzB03/NaDGsdtR+PCUgppinSzmpB4nwDKl4UfUQn467bRZFq9Q2lZJoDvb72r+PDmU6uV9Jh7CDg+ozze/x2jfY5G4tFoEtGXgC3m2mcIUQ1EMzRdesy6QhlBJcs2ENXCuAdnOHJh2zGCnecgVwbojw9PZW6wLLTHeI= From: Henry Wang To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Topic: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Index: AQHYwPjzoXW29+zrjEaaAKDaLd6E0a3RcOeAgAAmEqA= Date: Tue, 6 Sep 2022 01:04:06 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 02942F566B41A540803C3672B89EC504.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4aa1c60f-b528-4068-a9ce-08da8fa3baa7 x-ms-traffictypediagnostic: DB9PR08MB7699:EE_|AM7EUR03FT040:EE_|AS8PR08MB7919:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mFl0pDraqCSI1c+vBxd5xT7iSNHiX0s8Nn/55Jn3nbs0JblyD+a2jYHLnUVfDHJwUHgg0OVLYtkuvlptDyOFgK5PRrdiXEeccz1dTXhiv1e4MXr6/03T+udlmaVHMUFc+1sqQMjSFHkKiifhX+8Fw6vs6kVUAZJK10dFLQkm2FGrmZ5ZnZ1nCJsEbtPQFvYobSxsigpp5e1m22GUHHpEdteekV5DTzy4YsVee6eYcYTdoSDtsLnUUu3hQaX6bjStBG7ZTu1NfqkYBTnkzgGJAL2TSN0qRvoX3eQnXywA3P0jFjMLIaiDDy+dOpDBWa7//o8t3COqldcqEgEjnY7lrY93ZSzxwf0VySVeUVs++l/daTlh8WblZztETJ7P2WgG3IUn+H8LzHn2ZoL6czIa82BAouedkmnXQWspd21j14ZMviSsmSjOiX5KQZL0P9Dy2R+cYCgeSCow7LR9D5ZtCz8wTWwqx9gVGeHPKj0sBxGYueIwEsIBO3I/89jKKiLiFtA5XnP23y7exiVgUvVVJiOFk2vrrlIr2/e0RDunUAhSfvxZJh/FpepP9GHxLDt6VbVE5GlkCfQXF8J7CQ6MNSaLOvZck6rTtrlGYS1xw+j0O33mTD5BHy2ZYTZRWb8mio+W+FNoqmyN7MlF4OtDavsigVq86eBWDbxylY08YNF2R83APlR9VYBk+DxQJ9q9xdxyQm44/vNCo3lkOjvqJme7p/B2Chh5HtO6NUapB4D9DXKJlwJS4DpsTEHSMw2w5v5QB6RAb0CNk1VUuceI5Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(186003)(6506007)(52536014)(5660300002)(8936002)(9686003)(26005)(86362001)(33656002)(71200400001)(478600001)(7696005)(41300700001)(38070700005)(8676002)(4326008)(76116006)(64756008)(66446008)(66476007)(66556008)(2906002)(6916009)(54906003)(66946007)(55016003)(316002)(83380400001)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7699 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c06fdd42-0f82-4059-7d5d-08da8fa3b25f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dsFWtnZ2Io0LNRmMNre72ebmfrGhr/Gso5nSJQJCsPstwehOijlIaFuZwjTJurvVxM4j5bnsG8N7dL4AwlsaU2eNCeKku/43cfcoDV2lwrNv6P6M5R9PgTbYEeqDW3ESa8AMPJJrk/XZvv9enu7sPcQt9A9WRt82dUpoZ6fn73hJ7bdormhXGTfxWdjHG7MBM+BUAI1nbsti6Sux9tl3LTcRl4rTKwqp8aloJUNIxM7p1zeZ99gOjznV+QWxf9xz6I6UCxExCf6fn8f+nMyZu1GkE5IItTFINJ3tteKIkTgN7nifh9C5301bGUkZaZXN0bR5oiq9m598byjowIbTssrY2UD/qFq0zXui4HMFGb2ZagFlOgx2sQkPrJ+G54PIiNh7Lavn+yY2kjCrq9WoL9nrWqLtal5a8SYxXV1+rmxeuZZWALhvl4v2o99BrdQfDfRfhzM3Zsp+hDK4q8jXzRizSNGehV9iVPARKdznB+iFlT087sxIHzXMWqraNgegrhQumefaENtcnsYa/xafG1aXki03QcDFwu++X4IqOU7RUtWgnGwa1nZUHnwMaVS2TFqccsN9B2MNPnZ053PNa11GgWKZRQV8eAVWcVx+OcWyGCzM4ILv4Jo2T6/xIqbfCc+B1C+1BgiB3MWvVO2P2OILHYdDLuKtup2e1vjc3/oGzXsPn7n64DTskkSQMF8cU7FOKWysFSGM7zO7DiSJtdswrIqwmTdjemG1cmWTRNEK70MQll/jI9Zk63zJu1SZE9IY6CpNS9N13nqTueDOQA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(136003)(346002)(36840700001)(40470700004)(46966006)(6862004)(83380400001)(52536014)(186003)(9686003)(2906002)(40480700001)(5660300002)(55016003)(54906003)(41300700001)(6506007)(7696005)(86362001)(33656002)(47076005)(8936002)(26005)(478600001)(336012)(40460700003)(81166007)(70206006)(4326008)(8676002)(316002)(70586007)(36860700001)(82310400005)(356005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 01:04:19.9712 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa1c60f-b528-4068-a9ce-08da8fa3baa7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7919 Hi Stefano, > -----Original Message----- > From: Stefano Stabellini > Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory >=20 > On Mon, 5 Sep 2022, Henry Wang wrote: > > This commit introduces the reserved heap memory, which is parts of RAM > > reserved in the beginning of the boot time for heap. > > > > Firstly, since a new type of memory bank is needed for marking the > > memory bank solely as the heap, this commit defines `enum > membank_type` > > and use this enum in function device_tree_get_meminfo(). Changes of > > code are done accordingly following the introduction of this enum. > > > > Also, this commit introduces the logic to parse the reserved heap > > configuration in device tree by reusing the device tree entry definitio= n > > of the static memory allocation feature. If the memory bank is reserved > > as heap through `xen,static-heap` property in device tree `chosen` node= , > > the memory will be marked as heap type. > > > > A documentation section is added, describing the definition of reserved > > heap memory and the method of enabling the reserved heap memory > through > > device tree at boot time. > > > > Signed-off-by: Henry Wang > > Signed-off-by: Penny Zheng >=20 > I think the device tree interface is good and you can consider it acked > by me. I'll let you follow up on the other comments by others on the > code changes. Thanks, I will fix the comments from Michal and Julien. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Tue Sep 06 01:09:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 01:09:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399298.640422 (Exim 4.92) (envelope-from ) id 1oVN5f-0003Uq-T3; Tue, 06 Sep 2022 01:09:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399298.640422; Tue, 06 Sep 2022 01:09:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVN5f-0003Uj-PY; Tue, 06 Sep 2022 01:09:23 +0000 Received: by outflank-mailman (input) for mailman id 399298; Tue, 06 Sep 2022 01:09:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVN5e-0003Ud-6v for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 01:09:22 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150047.outbound.protection.outlook.com [40.107.15.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 893d462e-2d80-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 03:09:20 +0200 (CEST) Received: from AS9PR06CA0470.eurprd06.prod.outlook.com (2603:10a6:20b:49a::29) by DBBPR08MB6057.eurprd08.prod.outlook.com (2603:10a6:10:1f5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 01:09:18 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::ea) by AS9PR06CA0470.outlook.office365.com (2603:10a6:20b:49a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 01:09:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 01:09:17 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 06 Sep 2022 01:09:17 +0000 Received: from b5728015e667.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 94EA476B-2186-4AAC-BB5D-9EB7F7FBAB07.1; Tue, 06 Sep 2022 01:09:06 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b5728015e667.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 01:09:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB7699.eurprd08.prod.outlook.com (2603:10a6:10:392::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 01:09:04 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 01:09:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 893d462e-2d80-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jroc47vanB76l+PahsXxkZx3Ai2HXJvBHLYTu2ZFI3jfgT2M8p/O/wr/6zvBmMnHZdIkjVQJ5qZ9dRJfpVQYlI6lEhZT0wgHOEY+crd8rc3+1u5Qw5GlpaKkXdWpnYL++RBDAe90tvR3Z2/6+29z/PcP52ARP2hPsTkn95NN0f3IAuSkgSoPl7YNT+TSF14vT4NCpHW6R7Gc5jJRrqn1kDfDsSzuCCHpWXyhwULYc+zhC6J6YAcqiE/Ze2JdfX0XDjmhB/2UXmG8zhsGNM+67ZQZ6TnuOxCHDY81cnW+pvZFePrALizrEpAvR3zKbdfoqMGfNdNsKdBNIwy/36WGMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oc/FOGss4EeFcefUfgnZZs9tCthkRP6fMl0fwkk5FRA=; b=KcT7tVchId+A1ggtOrV+cHxTaphSJAICqCJ7V/0NnXXH2IrqKc2l9DkWajj5QVtYnmv2AulnWSi4Kwz44gUh/h3kFxea9WRH0P4lDy6maEIxP1rRgdQ6tp+DECYljglYJVLrSHQ/AZ2l7rCeMR60Lkgl2olZczL0C9ksnvJ28pbQ/NFzI9nNdjvFwEzaa6l38qConIftVYJDcmsXv6E7HVmZGbU/YOuukpeftRGXYzYem3qqeSdiQfIF4ubAWNM+r0Uw2BpuyLR7W3TFS31doROqJTuLDGgE8KEhMnFqks5rGKIYJBnTxa5mi5YZZkDx31F0ieLeJvXx/u/kOKvnZA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oc/FOGss4EeFcefUfgnZZs9tCthkRP6fMl0fwkk5FRA=; b=mTf51U+kycw4IRlhcEdfeSHlT/EXtJmphlxf6XIZtKkDpN7iDnjYQY5nnLSc4R1ErvV4aXhFwhGBAqS4DPcU+AX/HIwoAOCMKYho5717c4et3j/5vDkommrJ5MMOtCHGqM0uGh+UvY0p5a7v7tm8QOM8PdxHk7/4WGyJ/UOwYjs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgURaX3z0vbnaLxazQgLnUcYxICzwLdV52YO8rx/MOknFquY5d+u9+hFiEAoKX8qY5+yOs94/hQX22pZn8Z2pwx8FwVHiOBkxyaiARPG+K83EQSJz2PiWJ84p2s6XeJa3bmctEbLXhXtSofbOgVbZBFsYs51aQv29s1GBk3tJaLQp0cETatrpJO2vKdoBRFQBxBxZOtZ8/3CBCBBEmM8KlDvMQpjdbzbBFkQLBZbz31vr6h8Azsx2Ulkq/rwWE/wTBuO1dUVkdXfmOKcEf1J3GEJUkv5UQCvwiufQ1hfH8R9W4iioURn8i4HfLwwxChe3Y39nUtpnx++EyW2VjzW3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oc/FOGss4EeFcefUfgnZZs9tCthkRP6fMl0fwkk5FRA=; b=XKzWsrE+9TvZvt3l4AM6/9byTe2cdUuw6RFL583xtmV3f7So0QAo4FSOIrTQO9bcmkRI/Dq3PaHnGIaTYvTFQe/RNK8TneChGaV2iezi4yIo0A9awrDR8ydqbzH8xCxYz6beRuX/vVCCz6zpuj1nFsxfLh7RuBG1KR46LmmujS7WblkjNA/hN9i+s2OwjsrsmX5pM92wrEhgKQkjOO6Sm43sT/v/2wWItlJsYmpezTFsCTuFQd+rlW1l+mRsW3BnnurJhBX/qFOGMo95nTZzrTekUlfUGqUXBzcrCWCkk/C+Hi9/dak64AQRMnZK3XDgthRZVdicC45xFdSjSM8ctg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oc/FOGss4EeFcefUfgnZZs9tCthkRP6fMl0fwkk5FRA=; b=mTf51U+kycw4IRlhcEdfeSHlT/EXtJmphlxf6XIZtKkDpN7iDnjYQY5nnLSc4R1ErvV4aXhFwhGBAqS4DPcU+AX/HIwoAOCMKYho5717c4et3j/5vDkommrJ5MMOtCHGqM0uGh+UvY0p5a7v7tm8QOM8PdxHk7/4WGyJ/UOwYjs= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Topic: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Index: AQHYwPjzoXW29+zrjEaaAKDaLd6E0a3RFcUAgACB/kA= Date: Tue, 6 Sep 2022 01:09:04 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> <4d5a9acb-32ae-dc52-61b0-4e35052c7270@xen.org> In-Reply-To: <4d5a9acb-32ae-dc52-61b0-4e35052c7270@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D74880AE8FF07F44B48A41C8F1C3FDF1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1b471601-fbbf-47cc-d122-08da8fa46c01 x-ms-traffictypediagnostic: DB9PR08MB7699:EE_|VE1EUR03FT048:EE_|DBBPR08MB6057:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: k2UXXKx096VHpJsx+Mtb6bhzeZC4b5CFnvKHQ5KR2X+/DsNxJv0zCTKbrj/+W6oM7H/xRsDGO2ld/tgIw+tzE+f+sSC4VY6DbCGbA8ut0gdKlYyg/ECNJwMDq1zbvX4p/p2IGEXh5CaFttpkuu7BhPq4tGZ0/WL6L9094fbpyDv0wqi4u9RTIxQxZxQJXGCBU7uyIFe/eb+blNGAqwGg66LnTOyzUNlMwxvIvbZ1SYLvHwUGJO/R1inNH4osZzcF1xOtr9isGAV0JXZ0uheAYIXMpMP7hnxZ5TimvJ5XN7C1hmFphyaOoD+Z6Kmdfs/CldRi8AKbMOCIJdCjrjZrSFw6Iq+cUSqkbWMFFcZVSQwUGRld7SSX4xuKNTIyoQdU4IsQFJaVJKoFR41ICq/p5W4nZe3+skkOnl2IooeS8qgVa+9l6EpRR0XXJr4JbIJladlrfJi4A4eZ4sdIX4nA2O1CbUjJD3nE+adA6jjM6LAnXdVVxMqvUFYJ0yrDH65aXYm8JdyQoe4XQ0ReCa7B5GkrY8yY3Wt/yahwbI5G018sw6l4AA5hf+O3QKo/00A5gp2Ox5f9PrrpiD5OgT1Ntu71YfMnuDnfmLUlfTeOL3/9eR0v7V+JjIUeCCFn7ZkeW8uoqAVdsw72TDSI3Vu1JrA9T6N8yDBCxgpXow1SzPRIH2KNQGULSEkhPzrNa4PCMWKgN92DuBE5uBBV+hsuJ8SsoNze+cJ7u5jChZhuhKAD1iNZlw4m6m1BZTXgKyefQcSuICVnWFvDQLFyjticEA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(186003)(6506007)(53546011)(52536014)(5660300002)(8936002)(9686003)(26005)(86362001)(33656002)(71200400001)(478600001)(7696005)(41300700001)(38070700005)(8676002)(4326008)(76116006)(64756008)(66446008)(66476007)(66556008)(2906002)(54906003)(66946007)(55016003)(316002)(110136005)(83380400001)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7699 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f25bf760-7196-410d-7af9-08da8fa46440 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tgssA239uOy+uXhGuN7VNKZdUjc249ep27J+g7j+URRUVq7k5RhvfF2/a1bf+8kasE6YTDNLCQp100ohTc1JwYwmhs/dJxINNqOg7xfriHehWxpnNOO3Rn8evt/VCDvNH8uOZfeuBC907EtPEL63Cyh37SRHEgOl2ccQHLoPvswSKc/qGRVpRrmNjYIrGo8rYqu5rOaK/2fTmNAEN7NAeDLrkva7taX7LCLNWwOi3ssjsPP/Ing8RJgeV5CvJqXSB7hKRjE+s82a+Wo6BGEtbZr+VoVZdD4rc4XcNgUNuJVRat/2JiGgMqEzgcaMXc5cIrT+SppBkvsXUPYcb6C9Ksq2XjhSKEcon3oiJhy0h6wd8Hgbi6As4fY0FhfGCr/ta3/aP9ns62MTmIG/hKIjQ9sFIbwSvPEV/r1CjcHLMUZzHkAi1rkMk1uwMUQ2EgC8ZkpPKU+kf0KlL6Z/v/7KDW6H0eD1+hoU7MvjUoVhVFMTzplXpccgNQeJh7JOGl+6raaAEifKe3wB8tXdfGMZSI30v6UCNmQ7vBhl9MxvjK5RsIC+GEyf76d2bas91tCk0Y47llHlDFfnM+6BQBlawV/Z9XxGTEC1nQV5xO3y/JUl6+jKvayxlK1YOPHECGseGqwBsfPsP8apqyFnpaUmwS3wtGA+DOp7AUthgL/4CbWJMbAcm11vIvbT4EyF/d6XgUQFfZ3a8/xxwkMzB1CeE9qeNNQDm1wu4v2onetNlIXzVlnvHqb7TldPywui2HMfXUjyR8p3ZVfSvk+yax4hJg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(40470700004)(36840700001)(46966006)(40480700001)(6506007)(55016003)(7696005)(83380400001)(4326008)(8676002)(70206006)(70586007)(86362001)(33656002)(53546011)(356005)(36860700001)(81166007)(478600001)(5660300002)(8936002)(41300700001)(52536014)(26005)(2906002)(9686003)(316002)(40460700003)(47076005)(336012)(82310400005)(110136005)(54906003)(186003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 01:09:17.4740 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b471601-fbbf-47cc-d122-08da8fa46c01 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6057 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS80XSBk b2NzLCB4ZW4vYXJtOiBJbnRyb2R1Y2UgcmVzZXJ2ZWQgaGVhcCBtZW1vcnkNCj4gDQo+IEhpIEhl bnJ5LA0KPiANCj4gT24gMDUvMDkvMjAyMiAwODoyNiwgSGVucnkgV2FuZyB3cm90ZToNCj4gPiBU aGlzIGNvbW1pdCBpbnRyb2R1Y2VzIHRoZSByZXNlcnZlZCBoZWFwIG1lbW9yeSwgd2hpY2ggaXMg cGFydHMgb2YgUkFNDQo+ID4gcmVzZXJ2ZWQgaW4gdGhlIGJlZ2lubmluZyBvZiB0aGUgYm9vdCB0 aW1lIGZvciBoZWFwLg0KPiA+DQo+ID4gRmlyc3RseSwgc2luY2UgYSBuZXcgdHlwZSBvZiBtZW1v cnkgYmFuayBpcyBuZWVkZWQgZm9yIG1hcmtpbmcgdGhlDQo+ID4gbWVtb3J5IGJhbmsgc29sZWx5 IGFzIHRoZSBoZWFwLCB0aGlzIGNvbW1pdCBkZWZpbmVzIGBlbnVtDQo+IG1lbWJhbmtfdHlwZWAN Cj4gDQo+IFRoZSB3b3JkaW5nIGlzIGEgYml0IGNvbmZ1c2luZy4gSSByZWFkIHRoaXMgYXMgdGhl IGNvZGUgd2lsbCB1c2UgImVudW0NCj4gbWVtYmFua190eXBlIiBidXQgdGhpcyBpcyBub3QgcG9z c2libGUgYXMgeW91ciBlbnVtIGlzIGFub255bW91cy4NCj4gDQo+IE15IHN1Z2dlc3Rpb24gd291 bGQgYmUgdG8gYXZvaWQgY3JlYXRpbmcgYSB0eXBlZGVmIChzZWUgYmVsb3cpLg0KDQpZZWFoIEkg dGhpbmsgeW91IGFyZSBjb3JyZWN0LiBUaGUgdHlwZWRlZiBpcyBub3QgcmVhbGx5IG5lY2Vzc2Fy eS4NCg0KPiANCj4gPiArLSBGb3IgQXJtMzIsIHNpbmNlIHRoZXJlIGFyZSBzZXBlcmF0ZWQgaGVh cHMsIHRoZSByZXNlcnZlZCBoZWFwIHdpbGwgYmUNCj4gdXNlZA0KPiANCj4gdHlwZTogcy9zZXBl cmF0ZWQvc2VwYXJhdGVkLw0KDQpPb3BzLCBzb3JyeSBhZ2Fpbi4uDQoNCj4gDQo+ID4gK3R5cGVk ZWYgZW51bSB7DQo+ID4gKyAgICBNRU1CQU5LX01FTU9SWSwNCj4gDQo+IFRlY2huaWNhbGx5IGV2 ZXJ5dGhpbmcgaXMgbWVtb3J5IDopLiBJIHRoaW5rIGhlcmUgeW91IGFyZSByZWZlcnJpbmcgdG8N Cj4gZWl0aGVyOg0KPiAgICAgLSBSZXNlcnZlZCBtZW1vcnkgZm9yIHRoZSBkZXZpY2UgKG9yIGZp cm13YXJlKQ0KPiAgICAgLSBBbnkgbWVtb3J5IHRoYXQgd2lsbCBiZSB1c2VkIGJ5IHRoZSBhbGxv Y2F0b3IuDQo+IA0KPiBJIHdvdWxkIGNvbnNpZGVyIHRvIG5hbWUgdGhlIGZpZWxkIE1FTUJBTktf VU5LTk9XTiBvcg0KPiBNRU1CQU5LX0RFRkFVTFQNCj4gd2l0aCBhIGNvbW1lbnQgZXhwbGFpbmlu ZyB0aGUgbWVhbmluZyBkZXBlbmRzIHdoZXJlIGl0IHVzZWQgKHdlIGhhdmUNCj4gc2V2ZXJhbCBh cnJheXMgdXNpbmcgc3RydWN0IG1lbWJhbmspLg0KDQpNRU1CQU5LX0RFRkFVTFQgc291bmRzIGdv b2QsIGFuZCBJIHdpbGwgYWRkIHRoZSBjb21tZW50Lg0KDQo+IA0KPiA+ICsgICAgTUVNQkFOS19Y RU5fRE9NQUlOLCAvKiB3aGV0aGVyIHRoZSBtZW1vcnkgYmFuayBpcyBib3VuZCB0byBhDQo+IFhl biBkb21haW4uICovDQo+ID4gKyAgICBNRU1CQU5LX1JTVkRfSEVBUCwgLyogd2hldGhlciB0aGUg bWVtb3J5IGJhbmsgaXMgcmVzZXJ2ZWQgYXMNCj4gaGVhcC4gKi8NCj4gSSB3b3VsZCBjbGFyaWZ5 IHRoZSB0d28gdmFsdWVzIGFyZSBvbmx5IHZhbGlkIHdoZW4gdGhlIGJhbmsgaW4gaW4NCj4gcmVz ZXJ2ZWRfbWVtLg0KDQpHb29kIHBvaW50LCB3aWxsIGRvLg0KDQo+IA0KPiA+ICt9IG1lbWJhbmtf dHlwZTsNCj4gDQo+IEkgd291bGQgcHJlZmVyIGlmIGlmIHdlIGRvbid0IGRlZmluZSBhbnkgdHlw ZWRlZiBmb3IgdGhpcyBlbnVtLiBCdXQgaWYNCj4geW91IHdhbnQgdG8ga2VlcCBpdCwgdGhlbiBw bGVhc2Ugc3VmZml4IHdpdGggX3QuDQoNCk5vIEkgdGhpbmsgeW91IGFyZSBjb3JyZWN0LCBhIGVu dW0gbWVtYmFua190eXBlIGluc3RlYWQgb2YgYSB0eXBlZGVmDQp3b3VsZCBiZSBlbm91Z2ggaGVy ZS4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gPg0KPiA+ICAgc3RydWN0IG1lbWJh bmsgew0KPiA+ICAgICAgIHBhZGRyX3Qgc3RhcnQ7DQo+ID4gICAgICAgcGFkZHJfdCBzaXplOw0K PiA+IC0gICAgYm9vbCB4ZW5fZG9tYWluOyAvKiB3aGV0aGVyIHRoZSBtZW1vcnkgYmFuayBpcyBi b3VuZCB0byBhIFhlbg0KPiBkb21haW4uICovDQo+ID4gKyAgICBtZW1iYW5rX3R5cGUgdHlwZTsN Cj4gPiAgIH07DQo+ID4NCj4gPiAgIHN0cnVjdCBtZW1pbmZvIHsNCj4gPiBkaWZmIC0tZ2l0IGEv eGVuL2FyY2gvYXJtL3NldHVwLmMgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+IGluZGV4IDZl MDM5OGYzZjYuLjhkM2Y4NTk5ODIgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL3NldHVw LmMNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+IEBAIC02NDQsNyArNjQ0LDcg QEAgc3RhdGljIHZvaWQgX19pbml0IGluaXRfc3RhdGljbWVtX3BhZ2VzKHZvaWQpDQo+ID4NCj4g PiAgICAgICBmb3IgKCBiYW5rID0gMCA7IGJhbmsgPCBib290aW5mby5yZXNlcnZlZF9tZW0ubnJf YmFua3M7IGJhbmsrKyApDQo+ID4gICAgICAgew0KPiA+IC0gICAgICAgIGlmICggYm9vdGluZm8u cmVzZXJ2ZWRfbWVtLmJhbmtbYmFua10ueGVuX2RvbWFpbiApDQo+ID4gKyAgICAgICAgaWYgKCBi b290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tiYW5rXS50eXBlID09DQo+IE1FTUJBTktfWEVOX0RP TUFJTiApDQo+ID4gICAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICAgIG1mbl90IGJhbmtfc3Rh cnQgPQ0KPiBfbWZuKFBGTl9VUChib290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tiYW5rXS5zdGFy dCkpOw0KPiA+ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBiYW5rX3BhZ2VzID0NCj4gUEZO X0RPV04oYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLmJhbmtbYmFua10uc2l6ZSk7DQo+IA0KPiBDaGVl cnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 06 01:42:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 01:42:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399307.640433 (Exim 4.92) (envelope-from ) id 1oVNbq-0007hk-In; Tue, 06 Sep 2022 01:42:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399307.640433; Tue, 06 Sep 2022 01:42:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNbq-0007hd-FS; Tue, 06 Sep 2022 01:42:38 +0000 Received: by outflank-mailman (input) for mailman id 399307; Tue, 06 Sep 2022 01:42:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNbo-0007hT-JS; Tue, 06 Sep 2022 01:42:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNbo-0006Ix-Hc; Tue, 06 Sep 2022 01:42:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNbo-0004md-6E; Tue, 06 Sep 2022 01:42:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVNbo-0007rU-5i; Tue, 06 Sep 2022 01:42:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JkMHAZiekIcaEZwavpCfuSRaYANJZJ9SDKLmXwxGqPQ=; b=EJJjp3c9TYRz795OT5Hcf2QLKk Z8cUDY6FeXoiW6TQdHDTrNbvFd7zp023xBCVCI8izJ3ij6Z4ju5zozcuiCln8JXqTofVXFHn0ytQI a02LvCS4JUxHp8763aXwhzS818/JEc5Ch6qihxJN5nOCJqPhnGAGsY5Y3LFPVlbZ5+3Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173012: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=c05a218a9758225ddf94eedb365633f2154551da X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 06 Sep 2022 01:42:36 +0000 flight 173012 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173012/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf c05a218a9758225ddf94eedb365633f2154551da baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 32 days Failing since 172151 2022-08-05 02:40:28 Z 31 days 250 attempts Testing same since 173009 2022-09-05 15:47:58 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1685 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 01:54:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 01:54:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399316.640444 (Exim 4.92) (envelope-from ) id 1oVNmo-0000px-JL; Tue, 06 Sep 2022 01:53:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399316.640444; Tue, 06 Sep 2022 01:53:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNmo-0000pq-GK; Tue, 06 Sep 2022 01:53:58 +0000 Received: by outflank-mailman (input) for mailman id 399316; Tue, 06 Sep 2022 01:53:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNmm-0000pk-Vf for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 01:53:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2058.outbound.protection.outlook.com [40.107.22.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3d88f43-2d86-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 03:53:55 +0200 (CEST) Received: from AS8P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::33) by AS8PR08MB9093.eurprd08.prod.outlook.com (2603:10a6:20b:5b1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 01:53:53 +0000 Received: from AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::92) by AS8P251CA0012.outlook.office365.com (2603:10a6:20b:2f2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 01:53:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT053.mail.protection.outlook.com (100.127.140.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 01:53:52 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 06 Sep 2022 01:53:51 +0000 Received: from e8b9b2509a0a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9F8718CE-AC48-4967-A7A9-702EDAB4480E.1; Tue, 06 Sep 2022 01:53:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e8b9b2509a0a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 01:53:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6341.eurprd08.prod.outlook.com (2603:10a6:20b:33f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 01:53:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 01:53:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3d88f43-2d86-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LvhHxtkofE8bT7lHt2yB4NVdCHYXmlRex7nFkXAKnIYZYn2AQ1KvphJMoFSigMDBvEhZmgpIzb2HFqSMDgY75X/cKsgOsgVz2QJo3cdT3WPR/o/Hjk/bCevGyYIPVndpF/QDwwWuvihr1oz7utjk56HppdkW6VCWOSV3u43zcjEBtbSKioxKsPL9v8wR+XP77BVTdH5IJGkOxUw0/EfpU82WdIoSUCtXKQrhc4l4PBbO0e20/aEEBowz6WBX0fzMi2UGkAbQpFGLdcfiDn1+hiKU2W/T2CUxIomTgF0cUZ8e4a4lJ2CdEYWeqQheXwMOtS5AMzIpgl0QMjsU7OiQJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nwcCRLRAkduViQ5sJxpO7rJlQDEbcJBdrm88eo5GSHo=; b=kVjmlYkAFekeQTw2RHAfocKiQprkIJ5Y+9BUCTlNBTtYe4xneJytQoyqzbCo0924pHrWt/U3V3e69fxDRPiSDZzPB9zvQyI3BWN6cQ05yn24Vr2M8Pba5qNTY2I2ZxPl+g+eQR9xZq24+dHSsseAMw0IN+RCmAOhoIr4qC5UDXTC8Zh5QJZuSfjSvyjn34UDtK1OlLiPK7fY+0763EIJVltks195EF7XNAmgIc2pBJ37xvIvLUmVUIBHEUig3PAyhCd/tBmFdeD9CgMHgZ4S6Y3yMclVRzOm3GdzY5z/vPGNF2sNTD4yapBX56InQ79wVcza1Gt/ioJD5F17KBzIsw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=fail (no key for signature) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nwcCRLRAkduViQ5sJxpO7rJlQDEbcJBdrm88eo5GSHo=; b=J3p1ttDGoUz6J1c/QtN3LgIbUjc8fVnQVYK0VAOratYoF5sUTJcqOXabDhrsIEnpEhygQtnYrR199R80Rk1/iiNza0elcIexFq+mc6SC8q5Ls9TgD71QCCnN3kZYCIQODtUoYVJ3wnYyp785/9Rcu0+MU4D8WjzRFW1dNNkudOQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=fail (no key for signature) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UHSSHMUNyOmBOW/bqCHydoVnFlc/5v0K/ZpGi6pV68M+PfsHvXIJ6qszIhkpHRNYwEf0B4tW4J/yyvHhlQLS0oAAgNIGgrFoEVHsFFQ9k+zKC0PRovSRQmKbc2uOJtZWOE/L6UwMhtD34ZTrQN7I9rKC6lK/Qxp4znP11jJ23oG9YV34Pk/5oTw84uknklIc9/UgO7cyAXtNL/OqK5dtibFCye7VOaTImjV5xlJ3eT6nozpXGntUVIPs1MDkiLlmVRofeiUNu9bfzPsgo2cI3qjKOgXPHXrKS+qeMxeQ2T2oO7+6B3JsciVcwETpFZgFQkQSbrqnHf8/9r12otzN+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nwcCRLRAkduViQ5sJxpO7rJlQDEbcJBdrm88eo5GSHo=; b=IilqeovzYcgmLTbAoNC0r6k+220Ih4ZULbRp/jRQxL1rdJGYgB0gCv+FCwtBQ7N0yfMFpM89ShE/15hWc1Tb47ITmQjEBLVqrxHCfxoAJKymCW4ebAcSAHQbkEs98z7StJCwzbjSaAueTvTouMJkHwA81ZXJd9R4NfW6qKVBcEPqDIBAW0cM967t5Ysm8xKsahH/ZmXQbotUqavi6hyeGkUMYYCbIyuNTOnRwLghvAtL+F3hGlAKoTqWu9qHHMPjW46Q/twNyNYDXiNeu6E9Wqnoa8vPMwI/wYEEt8U6p0b+kQ/CWAOkLn1MGDirJUr5KqTr2cOPOyaY93p3Ij3vtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nwcCRLRAkduViQ5sJxpO7rJlQDEbcJBdrm88eo5GSHo=; b=J3p1ttDGoUz6J1c/QtN3LgIbUjc8fVnQVYK0VAOratYoF5sUTJcqOXabDhrsIEnpEhygQtnYrR199R80Rk1/iiNza0elcIexFq+mc6SC8q5Ls9TgD71QCCnN3kZYCIQODtUoYVJ3wnYyp785/9Rcu0+MU4D8WjzRFW1dNNkudOQ= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYwPj6dlOKXE+k5kuuj2vKrDnG5K3RJT6AgAB0+PA= Date: Tue, 6 Sep 2022 01:53:44 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-4-Henry.Wang@arm.com> <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> In-Reply-To: <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E68FD510EB23AB43B860D399602DF8FE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9f7ddc0d-9855-4410-8ffb-08da8faaa632 x-ms-traffictypediagnostic: AS8PR08MB6341:EE_|AM7EUR03FT053:EE_|AS8PR08MB9093:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d2uYwMP46UD6/NaMIL8S87tcEl3G1suU2mnbnAwF5YdYZ5HeasMh+ybmT2E2j3+UXO/NsPtqJ/0zZpfdq18ZP9qOSDPYarTWAoGBwJoEE9qvUt6NzN53rdi7JFq22R6zVWMn9Wcm9dQ87oXbJncHbe1EZEvqCw+GUq4548ox8OPu1zK2IyCI4lzoH98XyuCQgtC0glR3dQnMbkF1sfVukeh1vjMNeaayGHEk+WgYEuXbsIuWOKAwYxz6xmeTou2+Hy9G/vtoNixAZJ4ktx60lFDbNmq2HOAlsJTDQogJOONQz18gyGREFr/j1VhCD/yfbMwwCk/+MjpaqQhS8lzMEAh7Ah6LQdjAnexbQyDJB1ugqpS75AP5TGLp139L+6jlRd4JdDefIR+B0HskFNeOzSShp2zG7dwo9Fxt13fLpBD86na1RubicMTy0oyKfAdTZvAgy0iEn4Z8S5TMgsoquKgZeHIzG+N+s1A+6iRPXx5Eexr3pTfuSh6/Ur/UOg8CZpH2ij7yzY/rriFEfb+eZLY3aZpnsdCVhIPAqorCkOMrO4eypC+mIfZI2soyTtINOCKn+P4vmkVDxkRLxHR7QucyDI3eABK2N46kCt3k6sUdAwMwjfya4RywzmcK0H9bZRw4RF+5BrowT7KaK5xSd/4KwSGf1lftXpfVFfNV8f5wYAs7HODKph5lleViDGFmj8dBVWpjHDWapLfgP/H7J6TqobjfdfLSRpJxewkhfRiytLNzUC7os/H8s+iZxok6P3G1SGWm19RTv90G97JoVQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(366004)(39860400002)(346002)(396003)(26005)(9686003)(83380400001)(2906002)(52536014)(5660300002)(30864003)(8936002)(71200400001)(6506007)(7696005)(86362001)(33656002)(41300700001)(186003)(478600001)(38070700005)(54906003)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(8676002)(55016003)(110136005)(38100700002)(316002)(4326008)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6341 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 751d3111-f88e-438c-3a82-08da8faaa19c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xsP/8bI5owU+53kb8ycPYvRaN3NvG8WG4apO78+SjOVk35DX/6vME+DrHst4CBkuRcIL2Dz7KQlYjvAss8aPvmitbw/v2xw7Z5xWBBnf8qewm06KEBGzOS8goCNHAZaQ1Xb4xXTj6RB9mu8UtYGZdqxyW0vxn4TJLTyA1p2RipzXYCqgUWifF2QyMyKbB0GsxzK1b84b7A54oW7zfTi2f/3OE+dTw/ZUCYPQskizKif38JC708AT6Cz8wvjPvFhj+IVcabIU6BYpgRMO7OudDwIUPFbMY5qC4tWBakJtFFCVuW58Fj6x/pjDo5fy+ih1FZ3GNBOrTWSVvdpZzseMcO3SfkHzWyRiCBEFbBGr+9dOLfrBhA93htyrNUGC62w8DGqCkcAJJF1dQL/ifUqqaEG4fQLXlJV4jyueNvmIjUS2z1c5kC3Q2c/i9FmYLH4EoDI93miAZDYc5LQlLWwBPRsgpy6CwCnWD1fH2I9muOVZap4yVQhG6qCpXzrMazLOIdxgUduyXiTPPYlws/aGyV6POkuVB3UWphzx3r6Jl9cOVQXgxZV9IYOEebKpck7GY8kl+mEsnBgpASnJKzR8wtG4sNpbxgTOxB20Ut9PYX6nCzEofbxk7UMd+vuiCd+vsD/JS1BSMr4zDDeuuAvFtIoLLN6agV2Vh/HEzDNzRplvfu+06nfpQ688iF3TBdZ8kNeFqtXAzZ2zwNRR7H93+DA+FYGDyeopUrlJLYRWoGZIQbIP1LeW3NvAEWMxQdBDe9w4CTG4wBoHvYe1Qarf+g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(36840700001)(40470700004)(46966006)(26005)(478600001)(6506007)(54906003)(9686003)(41300700001)(7696005)(110136005)(47076005)(70586007)(336012)(4326008)(186003)(316002)(107886003)(70206006)(8676002)(83380400001)(5660300002)(81166007)(82740400003)(33656002)(30864003)(36860700001)(2906002)(52536014)(8936002)(82310400005)(40480700001)(356005)(86362001)(40460700003)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 01:53:52.1109 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f7ddc0d-9855-4410-8ffb-08da8faaa632 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9093 SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHlvdXIgY29tbWVudHMsIEkgYWRkZWQgbXkgcmVwbHkg YW5kIHNvbWUgb2YgdGhlIHF1ZXN0aW9ucw0KdGhhdCBJIGFtIG5vdCAxMDAlIHN1cmUgaW5saW5l IGJlbG93Lg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGllbiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IEhpIEhlbnJ5LA0KPiA+ICsNCj4gPiArLyoNCj4gPiAr ICogRmluZCB0aGUgY29udGlndW91cyB4ZW5oZWFwIHJlZ2lvbiB0aGF0IGZpdHMgaW4gdGhlIHJl c2VydmVkIGhlYXAgcmVnaW9uDQo+IHdpdGgNCj4gDQo+IFRoZXJlIG1pZ2h0IGJlIG11bHRpcGxl LiBTbyAiRmluZCBhIGNvbnRpZ3VvdXMuLi4iLiBJIHdvdWxkIGFsc28gZHJvcA0KPiAieGVuaGVh cCIuDQoNCkkgd2lsbCBmb2xsb3cgdGhlIHdvcmRpbmcgdGhhdCB5b3Ugc3VnZ2VzdGVkIGhlcmUg YW5kIC4uLg0KDQo+IA0KPiA+ICsgKiByZXF1aXJlZCBzaXplIGFuZCBhbGlnbm1lbnQsIGFuZCBy ZXR1cm4gdGhlIGVuZCBhZGRyZXNzIG9mIHhlbmhlYXAuDQo+IA0KPiBJIHdvdWxkIHdyaXRlICJh bmQgcmV0dXJuIHRoZSBlbmQgYWRkcmVzcyBvZiB0aGUgcmVnaW9uIGlmIGZvdW5kDQo+IG90aGVy d2lzZSAwIi4NCg0KLi4uaGVyZS4NCg0KPiANCj4gPiArICovDQo+ID4gK3N0YXRpYyBwYWRkcl90 IF9faW5pdCBmaXRfeGVuaGVhcF9pbl9yZXNlcnZlZF9oZWFwKHVpbnQzMl90IHNpemUsIHBhZGRy X3QNCj4gYWxpZ24pDQo+ID4gK3sNCj4gPiArICAgIGludCBpOw0KPiANCj4gUGxlYXNlIHVzZSB1 bnNpZ25lZCBpbnQuDQoNCkFoIHN1cmUuDQoNCj4gDQo+ID4gKyAgICBwYWRkcl90IGVuZCA9IDAs IGFsaWduZWRfc3RhcnQsIGFsaWduZWRfZW5kOw0KPiA+ICsgICAgcGFkZHJfdCBiYW5rX3N0YXJ0 LCBiYW5rX3NpemUsIGJhbmtfZW5kOw0KPiA+ICsNCj4gPiArICAgIGZvciAoIGkgPSAwIDsgaSA8 IGJvb3RpbmZvLnJlc2VydmVkX21lbS5ucl9iYW5rczsgaSsrICkNCj4gPiArICAgIHsNCj4gPiAr ICAgICAgICBpZiAoIGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5rW2ldLnR5cGUgPT0gTUVNQkFO S19SU1ZEX0hFQVAgKQ0KPiBOSVQ6IFlvdSBjb3VsZCBhdm9pZCB0aGUgZXh0cmEgaW5kZW50YXRp b24gYnkgcmV2ZXJ0aW5nIHRoZSBjb25kaXRpb24uDQoNClNvcnJ5IEkgYW0gbm90IDEwMCUgc3Vy ZSB0aGUgZXh0cmEgaW5kZW50YXRpb24geW91IHdlcmUgcmVmZXJyaW5nIHRvLg0KQXJlIHlvdSBz dWdnZXN0aW5nIHRoYXQgd2UgbmVlZCB0byBkbyBhIA0KYGBgDQppZiAoIGJvb3RpbmZvLnJlc2Vy dmVkX21lbS5iYW5rW2ldLnR5cGUgIT0gTUVNQkFOS19SU1ZEX0hFQVAgKQ0KICAgIGNvbnRpbnVl Ow0KDQpiYW5rX3N0YXJ0ID0gYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLmJhbmtbaV0uc3RhcnQ7DQou Li4NCmBgYA0KDQo/DQoNCklmIHNvIEkgd2lsbCBjaGFuZ2UgaW4gdjMuDQoNCj4gDQo+ID4gKyAg ICAgICAgew0KPiA+ICsgICAgICAgICAgICBiYW5rX3N0YXJ0ID0gYm9vdGluZm8ucmVzZXJ2ZWRf bWVtLmJhbmtbaV0uc3RhcnQ7DQo+ID4gKyAgICAgICAgICAgIGJhbmtfc2l6ZSA9IGJvb3RpbmZv LnJlc2VydmVkX21lbS5iYW5rW2ldLnNpemU7DQo+ID4gKyAgICAgICAgICAgIGJhbmtfZW5kID0g YmFua19zdGFydCArIGJhbmtfc2l6ZTsNCj4gPiArDQo+ID4gKyAgICAgICAgICAgIGlmICggYmFu a19zaXplIDwgc2l6ZSApDQo+ID4gKyAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gPiArDQo+ ID4gKyAgICAgICAgICAgIGFsaWduZWRfZW5kID0gYmFua19lbmQgJiB+KGFsaWduIC0gMSk7DQo+ ID4gKyAgICAgICAgICAgIGFsaWduZWRfc3RhcnQgPSAoYWxpZ25lZF9lbmQgLSBzaXplKSAmIH4o YWxpZ24gLSAxKTsNCj4gDQo+IEkgZmluZCB0aGUgbG9naWMgYSBiaXQgY29uZnVzaW5nLiBBRkFJ VSwgYWxpZ25lZF9zdGFydCBjb3VsZCBiZSBiZWxvdw0KPiB0aGUgc3RhcnQgb2YgdGhlIFJBTSB3 aGljaCBpcyBub3Qgd2hhdCBJIHdvdWxkIHVzdWFsbHkgZXhwZWN0Lg0KDQpZZWFoIEkgdW5kZXJz dGFuZCB5b3VyIGNvbmNlcm4uIEhlcmUgSSB3YW50IHRvIG1ha2Ugc3VyZSBldmVuIGlmDQp0aGUg Z2l2ZW4gc2l6ZSBpcyBub3QgYWxpZ25lZCAoYWx0aG91Z2ggbGVzcyBsaWtlbHkgaGFwcGVuIGlu IHJlYWwgbGlmZQ0KZ2l2ZW4gdGhlIHNpemUgY2FsY3VsYXRpb24gbG9naWMgaW4gc2V0dXBfbW0p IHRoZSBjb2RlIHN0aWxsIHdvcmsuIFNvDQp0aGUgYWxpZ25lZF9zdGFydCA9IChhbGlnbmVkX2Vu ZCAtIHNpemUpICYgfihhbGlnbiAtIDEpIGFuZCBiZWxvdw0KaWYgKGFsaWduZWRfc3RhcnQgPiBi YW5rX3N0YXJ0KSBjaGVjay4NCg0KPiANCj4gVGhlIGNvZGUgd29ya3MuIFNvIG5vIGNoYW5nZSBy ZXF1ZXN0ZWQuDQoNClRoYW5rcyENCg0KPiANCj4gDQo+ID4gKw0KPiA+ICsgICAgICAgICAgICBp ZiAoIGFsaWduZWRfc3RhcnQgPiBiYW5rX3N0YXJ0ICkNCj4gPiArICAgICAgICAgICAgICAgIC8q DQo+ID4gKyAgICAgICAgICAgICAgICAgKiBBcm0zMiBhbGxvY2F0ZXMgeGVuaGVhcCBmcm9tIGhp Z2hlciBhZGRyZXNzIHRvIGxvd2VyLCBzbyBpZg0KPiANCj4gVGhpcyBjb2RlIGlzIGFsc28gY2Fs bGVkIG9uIGFybTMyLiBTbyB3aGF0IGFyZSB5b3UgcmVmZXJyaW5nIHRvPyBJcyBpdA0KPiBjb25z aWRlcl9tb2R1bGVzKCk/DQoNClllcywgSSB0aGluayB0aGUgY3VycmVudCBhcm0zMiBiZWhhdmlv ciBpbiBjb25zaWRlcl9tb2R1bGVzKCkgaXMgd2hhdA0KSSBhbSByZWZlcnJpbmcgdG8uIEluIGZh Y3QsIEkganVzdCB3YW50IHRvIGFkZCBzb21lIGNvbW1lbnRzIHRoYXQgZXhwbGFpbiB3aHkNCndl IG5lZWQgdGhlIGVuZCA9IG1heChlbmQsIGFsaWduZWRfZW5kKSBzaW5jZSB0ZWNobmljYWxseSBp ZiB0aGVyZSBhcmUNCm11bHRpcGxlIHJlc2VydmVkIGhlYXAgYmFua3MgYW5kIGFsbCBvZiB0aGVt IGNhbiBmaXQgdGhlIHhlbmhlYXAgcmVnaW9uLA0Kd2UgY2FuIHVzZSBlaXRoZXIgb2YgdGhlbS4g QnV0IGZvbGxvd2luZyB0aGUgY3VycmVudCBiZWhhdmlvciB3ZSBjYW4gb25seSB1c2UNCnRoZSBo aWdoZXN0IGJhbmsgdG8ga2VlcCB0aGUgY29uc2lzdGVuY3kuDQoNCj4gDQo+ID4gKyAgICAgICAg ICAgICAgICAgKiB0aGVyZSBhcmUgbXVsdGlwbGUgbWVtb3J5IGJhbmtzIHRoYXQgc2F0aXNmeSB0 aGUgcmVxdWlyZW1lbnQsDQo+ID4gKyAgICAgICAgICAgICAgICAgKiB1c2UgdGhlIGhpZ2hlc3Qg YmFuay4NCj4gPiArICAgICAgICAgICAgICAgICAqLw0KPiA+ICsgICAgICAgICAgICAgICAgZW5k ID0gbWF4KGVuZCwgYWxpZ25lZF9lbmQpOw0KPiA+ICsgICAgICAgIH0NCj4gPiArICAgIH0NCj4g PiArDQo+ID4gKyAgICByZXR1cm4gZW5kOw0KPiA+ICt9DQo+ID4gICAjZW5kaWYNCj4gPg0KPiA+ ICAgLyoNCj4gPiBAQCAtNzEzLDggKzc1MCw5IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwb3B1bGF0 ZV9ib290X2FsbG9jYXRvcih2b2lkKQ0KPiA+ICAgI2lmZGVmIENPTkZJR19BUk1fMzINCj4gPiAg IHN0YXRpYyB2b2lkIF9faW5pdCBzZXR1cF9tbSh2b2lkKQ0KPiA+ICAgew0KPiA+IC0gICAgcGFk ZHJfdCByYW1fc3RhcnQsIHJhbV9lbmQsIHJhbV9zaXplLCBlOw0KPiA+IC0gICAgdW5zaWduZWQg bG9uZyByYW1fcGFnZXM7DQo+ID4gKyAgICBwYWRkcl90IHJhbV9zdGFydCwgcmFtX2VuZCwgcmFt X3NpemUsIGUsIGJhbmtfc3RhcnQsIGJhbmtfZW5kLA0KPiBiYW5rX3NpemU7DQo+ID4gKyAgICBw YWRkcl90IHJlc2VydmVkX2hlYXBfZW5kID0gMCwgcmVzZXJ2ZWRfaGVhcF9zaXplID0gMDsNCj4g PiArICAgIHVuc2lnbmVkIGxvbmcgcmFtX3BhZ2VzLCByZXNlcnZlZF9oZWFwX3BhZ2VzID0gMDsN Cj4gPiAgICAgICB1bnNpZ25lZCBsb25nIGhlYXBfcGFnZXMsIHhlbmhlYXBfcGFnZXMsIGRvbWhl YXBfcGFnZXM7DQo+ID4gICAgICAgdW5zaWduZWQgaW50IGk7DQo+ID4gICAgICAgY29uc3QgdWlu dDMyX3QgY3RyID0gUkVBRF9DUDMyKENUUik7DQo+ID4gQEAgLTczNCw5ICs3NzIsOSBAQCBzdGF0 aWMgdm9pZCBfX2luaXQgc2V0dXBfbW0odm9pZCkNCj4gPg0KPiA+ICAgICAgIGZvciAoIGkgPSAx OyBpIDwgYm9vdGluZm8ubWVtLm5yX2JhbmtzOyBpKysgKQ0KPiA+ICAgICAgIHsNCj4gPiAtICAg ICAgICBwYWRkcl90IGJhbmtfc3RhcnQgPSBib290aW5mby5tZW0uYmFua1tpXS5zdGFydDsNCj4g PiAtICAgICAgICBwYWRkcl90IGJhbmtfc2l6ZSA9IGJvb3RpbmZvLm1lbS5iYW5rW2ldLnNpemU7 DQo+ID4gLSAgICAgICAgcGFkZHJfdCBiYW5rX2VuZCA9IGJhbmtfc3RhcnQgKyBiYW5rX3NpemU7 DQo+ID4gKyAgICAgICAgYmFua19zdGFydCA9IGJvb3RpbmZvLm1lbS5iYW5rW2ldLnN0YXJ0Ow0K PiA+ICsgICAgICAgIGJhbmtfc2l6ZSA9IGJvb3RpbmZvLm1lbS5iYW5rW2ldLnNpemU7DQo+ID4g KyAgICAgICAgYmFua19lbmQgPSBiYW5rX3N0YXJ0ICsgYmFua19zaXplOw0KPiA+DQo+ID4gICAg ICAgICAgIHJhbV9zaXplICA9IHJhbV9zaXplICsgYmFua19zaXplOw0KPiA+ICAgICAgICAgICBy YW1fc3RhcnQgPSBtaW4ocmFtX3N0YXJ0LGJhbmtfc3RhcnQpOw0KPiA+IEBAIC03NDUsMTkgKzc4 Myw0MiBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc2V0dXBfbW0odm9pZCkNCj4gPg0KPiA+ICAgICAg IHRvdGFsX3BhZ2VzID0gcmFtX3BhZ2VzID0gcmFtX3NpemUgPj4gUEFHRV9TSElGVDsNCj4gPg0K PiA+ICsgICAgaWYgKCBib290aW5mby5yZXNlcnZlZF9oZWFwICkNCj4gPiArICAgIHsNCj4gPiAr ICAgICAgICBmb3IgKCBpID0gMCA7IGkgPCBib290aW5mby5yZXNlcnZlZF9tZW0ubnJfYmFua3M7 IGkrKyApDQo+ID4gKyAgICAgICAgew0KPiA+ICsgICAgICAgICAgICBpZiAoIGJvb3RpbmZvLnJl c2VydmVkX21lbS5iYW5rW2ldLnR5cGUgPT0NCj4gTUVNQkFOS19SU1ZEX0hFQVAgKQ0KPiA+ICsg ICAgICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgICAgICBiYW5rX3N0YXJ0ID0gYm9vdGluZm8u cmVzZXJ2ZWRfbWVtLmJhbmtbaV0uc3RhcnQ7DQo+ID4gKyAgICAgICAgICAgICAgICBiYW5rX3Np emUgPSBib290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tpXS5zaXplOw0KPiA+ICsgICAgICAgICAg ICAgICAgYmFua19lbmQgPSBiYW5rX3N0YXJ0ICsgYmFua19zaXplOw0KPiA+ICsNCj4gPiArICAg ICAgICAgICAgICAgIHJlc2VydmVkX2hlYXBfc2l6ZSArPSBiYW5rX3NpemU7DQo+ID4gKyAgICAg ICAgICAgICAgICByZXNlcnZlZF9oZWFwX2VuZCA9IG1heChyZXNlcnZlZF9oZWFwX2VuZCwgYmFu a19lbmQpOw0KPiA+ICsgICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsNCj4gPiAr ICAgICAgICByZXNlcnZlZF9oZWFwX3BhZ2VzID0gcmVzZXJ2ZWRfaGVhcF9zaXplID4+IFBBR0Vf U0hJRlQ7DQo+ID4gKyAgICAgICAgaWYgKCByZXNlcnZlZF9oZWFwX3BhZ2VzIDwgMzI8PCgyMC1Q QUdFX1NISUZUKSApDQo+ID4gKyAgICAgICAgICAgIHBhbmljKCJUb28gc21hbGwgcmVzZXJ2ZWQg aGVhcCByZWdpb24sIHNob3VsZCBiZSBhdCBsZWFzdCAzMk1cbiIpOw0KPiANCj4gVGhpcyBpcyBh IGJpdCBtaXNsZWFkaW5nLiAzMk1CIGlzIG5vdCBzdWZmaWNpZW50LCBpdCBhbHNvIGhhcyB0byBi ZQ0KPiBjb250aWd1b3VzLiBTbyBJIHdvdWxkIGRyb3AgdGhpcyBwYW5pYygpIGNvbXBsZXRlbHku DQoNClN1cmUuDQoNCj4gDQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICAgICAgIC8qDQo+ID4gICAg ICAgICogSWYgdGhlIHVzZXIgaGFzIG5vdCByZXF1ZXN0ZWQgb3RoZXJ3aXNlIHZpYSB0aGUgY29t bWFuZCBsaW5lDQo+ID4gICAgICAgICogdGhlbiBsb2NhdGUgdGhlIHhlbmhlYXAgdXNpbmcgdGhl c2UgY29uc3RyYWludHM6DQo+ID4gICAgICAgICoNCj4gPiAgICAgICAgKiAgLSBtdXN0IGJlIDMy IE1pQiBhbGlnbmVkDQo+ID4gICAgICAgICogIC0gbXVzdCBub3QgaW5jbHVkZSBYZW4gaXRzZWxm IG9yIHRoZSBib290IG1vZHVsZXMNCj4gPiAtICAgICAqICAtIG11c3QgYmUgYXQgbW9zdCAxR0Ig b3IgMS8zMiB0aGUgdG90YWwgUkFNIGluIHRoZSBzeXN0ZW0gaWYgbGVzcw0KPiA+ICsgICAgICog IC0gbXVzdCBiZSBhdCBtb3N0IDFHQiBvciAxLzMyIHRoZSB0b3RhbCBSQU0gaW4gdGhlIHN5c3Rl bQ0KPiA+ICsgICAgICogICAgKHRoZXJlIGlzIG5vIHJlc2VydmVkIGhlYXApIG9yIDEvMzIgdGhl IHRvdGFsIHJlc2VydmVkDQo+IA0KPiBEaWQgeW91IGZvcmdvdCB0byBhZGQgImlmIiBiZWZvcmUg InRoZXJlIj8NCg0KSSB3aWxsIHVzZSB0aGUgd29yZGluZyB0aGF0IHlvdSBzdWdnZXN0ZWQgaW4g Li4uDQoNCj4gDQo+ID4gKyAgICAgKiAgICBoZWFwIHJlZ2lvbiAodGhlcmUgaXMgcmVzZXJ2ZWQg aGVhcCkgaWYgbGVzcw0KPiANCj4gVGhlIG5ldyB3b3JkaW5nIHN1Z2dlc3RzIHRoYXQgdGhlIDFH QiBsaW1pdCBvbmx5IGFwcGxpZXMgd2hlbiB0aGUgYWRtaW4NCj4gZG9lc24ndCBzcGVjaWZ5IHRo ZSByZXNlcnZlZCBoZWFwLiBIb3dldmVyLCB3ZSBkb24ndCBzdXBwb3J0IGxhcmdlciBoZWFwDQo+ IHRoYW4gMUdCLiBTbyB0aGUgbGltaXQgc2hvdWxkIGFsc28gYXBwbHkgZm9yIHRoZSByZXNlcnZl ZCBoZWFwLiBTbyBob3cNCj4gYWJvdXQ6DQo+IA0KPiAtIG11c3QgYmUgYXQgbW9zdCAxR0Igb3Ig MS8zMiB0aGUgdG90YWwgUkFNIGluIHRoZSBzeXN0ZW0gKG9yIHJlc2VydmVkDQo+IGhlYXAgaWYg ZW5hYmxlZCkNCg0KLi4uaGVyZS4NCg0KPiANCj4gPiAgICAgICAgKiAgLSBtdXN0IGJlIGF0IGxl YXN0IDMyTQ0KPiA+ICAgICAgICAqDQo+ID4gICAgICAgICogV2UgdHJ5IHRvIGFsbG9jYXRlIHRo ZSBsYXJnZXN0IHhlbmhlYXAgcG9zc2libGUgd2l0aGluIHRoZXNlDQo+ID4gICAgICAgICogY29u c3RyYWludHMuDQo+ID4gICAgICAgICovDQo+ID4gLSAgICBoZWFwX3BhZ2VzID0gcmFtX3BhZ2Vz Ow0KPiA+ICsgICAgaGVhcF9wYWdlcyA9IGJvb3RpbmZvLnJlc2VydmVkX2hlYXAgPyByZXNlcnZl ZF9oZWFwX3BhZ2VzIDoNCj4gcmFtX3BhZ2VzOw0KPiANCj4gWW91IGNhbiBhdm9pZCB0aGUgdGVy bmFyeSBvcGVyYXRpb24gaGVyZSBieSBzZXR0aW5nIGhlYXBfcGFnZXMgaW4gdGhlDQo+ICdpZicg YWJvdmUgYW5kIGFkZCBhIGVsc2UgZm9yIHRoZSAncmFtX3BhZ2VzJyBwYXJ0Lg0KDQpTb3JyeSBJ IG1pZ2h0IHVuZGVyc3RhbmQgeW91ciBjb21tZW50IGluIHRoZSB3cm9uZyB3YXksIGJ1dCBkbyB5 b3UNCnN1Z2dlc3Qgd2UgbmVlZCB0bzoNCmBgYA0KaWYgKCBib290aW5mby5yZXNlcnZlZF9oZWFw ICkNCnsNCi4uLg0KICAgIGhlYXBfcGFnZXMgPSByZXNlcnZlZF9oZWFwX3BhZ2VzOw0KfQ0KZWxz ZQ0KICAgIGhlYXBfcGFnZXMgPSB0b3RhbF9wYWdlczsNCmBgYA0KPw0KDQpJZiBzbyBJIHdpbGwg ZG8gdGhhdCBpbiB2My4NCg0KPiANCj4gSW4gZmFjdCwgJ3JhbV9wYWdlcycgY291bGQgYmUgY29t cGxldGVseSBkcm9wcGVkIGluIGZhdm9yIG9mICd0b3RhbF9wYWdlcycuDQoNCkdvb2QgcG9pbnQs IEkgd2lsbCBkbyB0aGF0IGluIHYzLg0KDQo+IA0KPiA+ICsNCj4gPiAgICAgICBpZiAoIG9wdF94 ZW5oZWFwX21lZ2FieXRlcyApDQo+ID4gICAgICAgICAgIHhlbmhlYXBfcGFnZXMgPSBvcHRfeGVu aGVhcF9tZWdhYnl0ZXMgPDwgKDIwLVBBR0VfU0hJRlQpOw0KPiA+ICAgICAgIGVsc2UNCj4gPiBA QCAtNzY3LDkgKzgyOCwxNSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc2V0dXBfbW0odm9pZCkNCj4g PiAgICAgICAgICAgeGVuaGVhcF9wYWdlcyA9IG1pbih4ZW5oZWFwX3BhZ2VzLCAxVUw8PCgzMC1Q QUdFX1NISUZUKSk7DQo+ID4gICAgICAgfQ0KPiA+DQo+ID4gKyAgICAvKg0KPiA+ICsgICAgICog T24gQXJtMzIsIHhlbmhlYXAgbXVzdCBiZSBjb250aWd1b3VzLCBsb29rIGZvciBvbmUgb2YgdGhl IHJlZ2lvbg0KPiA+ICsgICAgICogdGhhdCBtYXRjaGVzIHRoZSBhYm92ZS1tZW50aW9uZWQgeGVu aGVhcCBjb25zdHJhaW50cy4NCj4gPiArICAgICAqLw0KPiANCj4gSU1ITyB0aGlzIGlzIGFscmVh ZHkgaW1wbGllZCBieSB0aGUgbGFyZ2UgY29tbWVudCBhYm92ZS4gQnV0IGlmIHlvdSB3YW50DQo+ IHRvIGJlIG1vcmUgb2J2aW91cywgdGhlbiBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlbG9uZyB0byB0 aGUgY29tbWVudCBhYm92ZS4NCg0KSSB0aGluayBJIHdpbGwgYWRkICJ0aGUgeGVuaGVhcCBzaG91 bGQgYmUgY29udGlndW91cyIgYXMgSSBtaXNzZWQgdGhpcyBvbmUNCkJlZm9yZSB5b3UgbWVudGlv bmVkIHRoaXMgaW4gdGhlIGNvZGUgcmV2aWV3LiBJIHRoaW5rIGFkZGluZyB0aGlzIHdpbGwgYXZv aWQNCnBlb3BsZSB3aG8gY2hhbmdlIHRoaXMgcGFydCBpbiB0aGUgZnV0dXJlIG1ha2luZyBtaXN0 YWtlcyBsaWtlIEkgZGlkIDopKQ0KDQo+IA0KPiA+ICAgICAgIGRvDQo+ID4gICAgICAgew0KPiA+ IC0gICAgICAgIGUgPSBjb25zaWRlcl9tb2R1bGVzKHJhbV9zdGFydCwgcmFtX2VuZCwNCj4gPiAr ICAgICAgICBlID0gYm9vdGluZm8ucmVzZXJ2ZWRfaGVhcCA/DQo+ID4gKyAgICAgICAgICAgIGZp dF94ZW5oZWFwX2luX3Jlc2VydmVkX2hlYXAocGZuX3RvX3BhZGRyKHhlbmhlYXBfcGFnZXMpLA0K PiAzMjw8MjApIDoNCj4gDQo+IFBsZWFzZSB1c2UgTUIoMzIpIGluIG5ldyBjb2RlLg0KDQpPaCBz dXJlLiBUaGFua3MgZm9yIHBvaW50aW5nIHRoaXMgb3V0Lg0KDQo+IA0KPiA+ICsgICAgICAgICAg ICBjb25zaWRlcl9tb2R1bGVzKHJhbV9zdGFydCwgcmFtX2VuZCwNCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcGZuX3RvX3BhZGRyKHhlbmhlYXBfcGFnZXMpLA0KPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAzMjw8MjAsIDApOw0KPiA+ICAgICAgICAgICBpZiAo IGUgKQ0KPiA+IEBAIC03NzksNyArODQ2LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX21t KHZvaWQpDQo+ID4gICAgICAgfSB3aGlsZSAoICFvcHRfeGVuaGVhcF9tZWdhYnl0ZXMgJiYgeGVu aGVhcF9wYWdlcyA+IDMyPDwoMjAtDQo+IFBBR0VfU0hJRlQpICk7DQo+ID4NCj4gPiAgICAgICBp ZiAoICEgZSApDQo+ID4gLSAgICAgICAgcGFuaWMoIk5vdCBub3QgZW5vdWdoIHNwYWNlIGZvciB4 ZW5oZWFwXG4iKTsNCj4gPiArICAgICAgICBwYW5pYygiTm90IGVub3VnaCBzcGFjZSBmb3IgeGVu aGVhcFxuIik7DQo+ID4NCj4gPiAgICAgICBkb21oZWFwX3BhZ2VzID0gaGVhcF9wYWdlcyAtIHhl bmhlYXBfcGFnZXM7DQo+ID4NCj4gPiBAQCAtODI0LDkgKzg5MSw5IEBAIHN0YXRpYyB2b2lkIF9f aW5pdCBzZXR1cF9tbSh2b2lkKQ0KPiA+ICAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX21tKHZv aWQpDQo+ID4gICB7DQo+ID4gICAgICAgY29uc3Qgc3RydWN0IG1lbWluZm8gKmJhbmtzID0gJmJv b3RpbmZvLm1lbTsNCj4gPiAtICAgIHBhZGRyX3QgcmFtX3N0YXJ0ID0gfjA7DQo+ID4gLSAgICBw YWRkcl90IHJhbV9lbmQgPSAwOw0KPiA+IC0gICAgcGFkZHJfdCByYW1fc2l6ZSA9IDA7DQo+ID4g KyAgICBwYWRkcl90IHJhbV9zdGFydCA9IElOVkFMSURfUEFERFIsIGJhbmtfc3RhcnQgPSBJTlZB TElEX1BBRERSOw0KPiA+ICsgICAgcGFkZHJfdCByYW1fZW5kID0gMCwgYmFua19lbmQgPSAwOw0K PiA+ICsgICAgcGFkZHJfdCByYW1fc2l6ZSA9IDAsIGJhbmtfc2l6ZSA9IDA7DQo+ID4gICAgICAg dW5zaWduZWQgaW50IGk7DQo+ID4NCj4gPiAgICAgICBpbml0X3BkeCgpOw0KPiA+IEBAIC04MzUs MTcgKzkwMiwzNiBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc2V0dXBfbW0odm9pZCkNCj4gPiAgICAg ICAgKiBXZSBuZWVkIHNvbWUgbWVtb3J5IHRvIGFsbG9jYXRlIHRoZSBwYWdlLXRhYmxlcyB1c2Vk IGZvciB0aGUNCj4geGVuaGVhcA0KPiA+ICAgICAgICAqIG1hcHBpbmdzLiBCdXQgc29tZSByZWdp b25zIG1heSBjb250YWluIG1lbW9yeSBhbHJlYWR5IGFsbG9jYXRlZA0KPiA+ICAgICAgICAqIGZv ciBvdGhlciB1c2VzIChlLmcuIG1vZHVsZXMsIHJlc2VydmVkLW1lbW9yeS4uLikuDQo+ID4gLSAg ICAgKg0KPiA+ICsgICAgICogSWYgdGhlcmUgYXJlIG5vbi1lbXB0eSByZXNlcnZlZCBoZWFwIHJl Z2lvbnMsIChvbmx5KSBhZGQgdGhlc2UNCj4gcmVnaW9ucw0KPiANCj4gSSBhbSBub3Qgc3VyZSB3 aGF0IHlvdSBtZWFuIGJ5ICJub24tZW1wdHkiIGhlcmUuIEhvdyBhYm91dCBzb21ldGhpbmcNCj4g bGlrZToNCj4gDQo+ICJJZiBhIHJlc2VydmVkIGhlYXAgd2FzIHByb3ZpZGVkIGJ5IHRoZSBhZG1p biwgcG9wdWxhdGUgdGhlIGJvb3QNCj4gYWxsb2NhdG9yIHdpdGggdGhlIGNvcnJlc3BvbmRpbmcg cmVnaW9ucyBvbmx5Ii4NCg0KU3VyZS4NCg0KPiANCj4gPiArICAgICAqIGluIHRoZSBib290IGFs bG9jYXRvci4NCj4gPiArICAgICAqLw0KPiA+ICsgICAgaWYgKCBib290aW5mby5yZXNlcnZlZF9o ZWFwICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBmb3IgKCBpID0gMCA7IGkgPCBib290aW5m by5yZXNlcnZlZF9tZW0ubnJfYmFua3M7IGkrKyApDQo+ID4gKyAgICAgICAgew0KPiA+ICsgICAg ICAgICAgICBpZiAoIGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5rW2ldLnR5cGUgPT0NCj4gTUVN QkFOS19SU1ZEX0hFQVAgKQ0KPiA+ICsgICAgICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgICAg ICBiYW5rX3N0YXJ0ID0gYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLmJhbmtbaV0uc3RhcnQ7DQo+ID4g KyAgICAgICAgICAgICAgICBiYW5rX3NpemUgPSBib290aW5mby5yZXNlcnZlZF9tZW0uYmFua1tp XS5zaXplOw0KPiA+ICsgICAgICAgICAgICAgICAgYmFua19lbmQgPSBiYW5rX3N0YXJ0ICsgYmFu a19zaXplOw0KPiA+ICsNCj4gPiArICAgICAgICAgICAgICAgIGluaXRfYm9vdF9wYWdlcyhiYW5r X3N0YXJ0LCBiYW5rX2VuZCk7DQo+ID4gKyAgICAgICAgICAgIH0NCj4gPiArICAgICAgICB9DQo+ ID4gKyAgICB9DQo+ID4gKyAgICAvKg0KPiA+ICsgICAgICogTm8gcmVzZXJ2ZWQgaGVhcCByZWdp b25zOg0KPiA+ICAgICAgICAqIEZvciBzaW1wbGljaXR5LCBhZGQgYWxsIHRoZSBmcmVlIHJlZ2lv bnMgaW4gdGhlIGJvb3QgYWxsb2NhdG9yLg0KPiA+ICAgICAgICAqLw0KPiA+IC0gICAgcG9wdWxh dGVfYm9vdF9hbGxvY2F0b3IoKTsNCj4gPiArICAgIGVsc2UNCj4gPiArICAgICAgICBwb3B1bGF0 ZV9ib290X2FsbG9jYXRvcigpOw0KPiANCj4gRm9yIGFybTMyLCBzaG91bGRuJ3Qgd2UgYWxzbyBv bmx5IGFkZCB0aGUgcmVzZXJ2ZWQgaGVhcCAobWludXMgdGhlDQo+IHhlbmhlYXApIHRvIHRoZSBi b290IGFsbG9jYXRvcj8gQXQgd2hpY2ggcG9pbnQsIEkgd291bGQgbW92ZSB0aGUgY2hhbmdlDQo+ IGluIHBvcHVsYXRlX2Jvb3RfYWxsb2NhdG9yKCkuDQoNClNvcnJ5IEkgYW0gbm90IHN1cmUgd2hh dCB0aGlzIGNvbW1lbnQgYWJvdXQuLi5hcyBoZXJlIHRoZSBjb2RlIGlzIGZvciBhcm02NC4NCkZv ciB0aGUgcXVlc3Rpb24sIHllcy4NCkZvciB0aGUgbGF0dGVyIG9uZSwgZG8geW91IHJlcXVlc3Qg c29tZSBjaGFuZ2VzPyBJZiBzbywgY291bGQgeW91IHBsZWFzZSBraW5kbHkNCmVsYWJvcmF0ZSBh IGxpdHRsZSBiaXQgbW9yZT8gVGhhbmtzLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0K PiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 06 02:34:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 02:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399327.640455 (Exim 4.92) (envelope-from ) id 1oVOPu-0005YM-T5; Tue, 06 Sep 2022 02:34:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399327.640455; Tue, 06 Sep 2022 02:34:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVOPu-0005YF-Pw; Tue, 06 Sep 2022 02:34:22 +0000 Received: by outflank-mailman (input) for mailman id 399327; Tue, 06 Sep 2022 02:34:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVOPt-0005Y5-GN; Tue, 06 Sep 2022 02:34:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVOPt-0007dD-EP; Tue, 06 Sep 2022 02:34:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVOPt-0007o4-0e; Tue, 06 Sep 2022 02:34:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVOPt-0000X7-0B; Tue, 06 Sep 2022 02:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K+PFHS2uY0SXTbVVuKQb9jGlVGtKDNYn2iXLykePVA8=; b=4FX1c0kQ/Yc88l3/2n07H1rY2d vSvTB63FNLP1v1ZR/AE9Ky0D/DnXrqKVe9cNx9448Jd9eyoWdpe6hoGgxx5RIRL4HJPod6SDdlSqJ HGkqe87tV0WBeDLmXp+QMZjirEXo/LXwckxsuy4yFT9haQHRl1P5XC3O9bjYVwPJ9mnU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173007: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e18e42e4b280c85b76967a9106a13ca61c16179 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Tue, 06 Sep 2022 02:34:21 +0000 flight 173007 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173007/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7e18e42e4b280c85b76967a9106a13ca61c16179 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 32 days Failing since 172152 2022-08-05 04:01:26 Z 31 days 73 attempts Testing same since 172994 2022-09-05 03:16:17 Z 0 days 2 attempts ------------------------------------------------------------ 1691 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 173946 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 02:53:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 02:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399336.640466 (Exim 4.92) (envelope-from ) id 1oVOhp-0007yn-DK; Tue, 06 Sep 2022 02:52:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399336.640466; Tue, 06 Sep 2022 02:52:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVOhp-0007yg-AS; Tue, 06 Sep 2022 02:52:53 +0000 Received: by outflank-mailman (input) for mailman id 399336; Tue, 06 Sep 2022 02:52:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVOho-0007ya-9s for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 02:52:52 +0000 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [2607:f8b0:4864:20::b33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe29c31b-2d8e-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 04:52:49 +0200 (CEST) Received: by mail-yb1-xb33.google.com with SMTP id e126so8168606ybh.1 for ; Mon, 05 Sep 2022 19:52:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe29c31b-2d8e-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=bfTltfO7WnxXTmI5aAqzYfltIOrisJOrfI2bushTDFg=; b=oQZCm5c+XeuESChEw7vC26nyp80dMgNSeJoZ2MyUMTnxbOdhwxSvMf0xZAvn2kULOk yRSHlBLomENOgAzikZCVJ+Z+Y68nQ9TCRMSmIImqkN5OxBDdKBqDQMcWK0KsD87gqHmk c72G3wN4sgUxMztCQOk4iLk2b5yFFRWHjSdvTWfMY6bTXYoukfYZzSxliskCxVNwKGFu 6K64FM/Pdk73u1bZkOR2MFeANBCDF9VTVPwoD6neyj4HzDqx4Ll69ta2oI7ZpcymAbdt uIIdsjEz2x0HBow2e/rK2v5AbtWdtGpn5fv6sFYChWtI8qKPA1dxSRqHQgZ3qHSHmZF+ flFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=bfTltfO7WnxXTmI5aAqzYfltIOrisJOrfI2bushTDFg=; b=2q6KbQjzUHJv3y4zv1Wb3B4iuh3NFhYFgq98yWXlP/ckvx4NlPvJehpeVQRSJ+12lo 272ET1n2SyzrRWheIQyFGr+PioJxeVn3pcLtL1IIBL+B3QIHDOeXKDDatsOIPqMHiC7d AR/dnYVocf4ur0A6s7zITEGbStvwnzfwRlnfnJzRSLeDVArJ07dFOnQRwFoX1ik9jKrc C06S/Hm47q5hjR+CWYZjflmrHOl/8/ckb3GQv8C0LFTw+Gyrv8YuoXR5tk8SiON/WrCX rM1kKqdqCvY46tWnw1GIXi6k/DupS4YHQbUSiwpv2EAD+L5nfIOb9H0Mjyn0Ywkgaheh PLgQ== X-Gm-Message-State: ACgBeo38/3chgOp54NZCYW76+TLN/rb+UdSoB3j5kI7Aga932j+7SEqV fj2XcLmesAKJaMNECk7aR+YSlQRFIhmeRPR6CNv8ZA== X-Google-Smtp-Source: AA6agR539z3VV8b3kg6wBw2gnF6iTaaStugyNMDKRNSDRFkZ1ZlhhROmJ5Ul4fyfO9KSfcgQ1RwGtdYeWpgi9aGJ900= X-Received: by 2002:a05:6902:572:b0:67c:2af2:3a75 with SMTP id a18-20020a056902057200b0067c2af23a75mr33501615ybt.346.1662432768468; Mon, 05 Sep 2022 19:52:48 -0700 (PDT) MIME-Version: 1.0 References: <99e460f1-ca5f-b520-69e0-b250915fd591@xen.org> <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> In-Reply-To: From: Leo Yan Date: Tue, 6 Sep 2022 10:52:37 +0800 Message-ID: Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table To: Julien Grall Cc: Marc Zyngier , Ard Biesheuvel , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Content-Type: text/plain; charset="UTF-8" On Thu, Aug 25, 2022 at 10:40:41PM +0800, Leo Yan wrote: [...] > > > But here I still cannot create the concept that how GIC RD tables play > > > roles to support the para virtualization or passthrough mode. > > > > I am not sure what you are actually asking. The pending tables are just > > memory you give to the GICv3 to record the state of the interrupts. > > For more specific, Xen has its own RD pending table, and we can use > this pending table to set state for SGI/PPI/LPI for a specific CPU > interface. Xen works as hypervisor, it saves and restores the pending > table according to switched in VM context, right? > > On the other hand, what's the purpose for Linux kernel's GIC RD > pending table? Is it only used for nested virtulisation? I mean if > Linux kernel's GIC RD pending table is not used for the drivers in > Dom0 or DomU, then it's useless to pass it from the primary kernel to > secondary kernel; as result, we don't need to reserve the persistent > memory for the pending table in this case. I don't receive further confirmation from Marc, anyway, I tried to cook a kernel patch to mute the kernel oops [1]. Hope this is not too arbitrary and we can move forward a bit. Thanks, Leo [1] https://lore.kernel.org/lkml/20220906024040.503764-1-leo.yan@linaro.org/T/#u From xen-devel-bounces@lists.xenproject.org Tue Sep 06 04:01:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 04:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399325.640477 (Exim 4.92) (envelope-from ) id 1oVPlu-0006gk-E1; Tue, 06 Sep 2022 04:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399325.640477; Tue, 06 Sep 2022 04:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVPlu-0006gd-As; Tue, 06 Sep 2022 04:01:10 +0000 Received: by outflank-mailman (input) for mailman id 399325; Tue, 06 Sep 2022 02:05:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVNyN-0002mt-W3 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 02:05:56 +0000 Received: from mail-m972.mail.163.com (mail-m972.mail.163.com [123.126.97.2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6eea892e-2d88-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 04:05:53 +0200 (CEST) Received: from localhost.localdomain (unknown [116.128.244.169]) by smtp2 (Coremail) with SMTP id GtxpCgA3NAfcqhZjHAaSbA--.23398S2; Tue, 06 Sep 2022 10:05:17 +0800 (CST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eea892e-2d88-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=xmN1F CoHwFFxWoZVNoofoQFdyf4htAgoTRMoCaG/1Y8=; b=Gt9504JVSfg9QvkZhZylc Vs8Rqa6YklAvZg6PXYtEq7Mbn166EYDn1rP6JKYkqdwmYM8WD5jfy5QyVS9X8R8u 8J1nziqGh+SuuZnl2/hyoG03Zyi/GnB24+RatxYf3q8NXzlOJ4hpFZhHDPZyF7cb z0gRQ3ILZQ9rcPSENNqFPs= From: Jiangshan Yi <13667453960@163.com> To: axboe@kernel.dk, roger.pau@citrix.com Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jiangshan Yi , k2ci Subject: [PATCH] xen-blkback/common.h: fix spelling typo in comment Date: Tue, 6 Sep 2022 10:05:14 +0800 Message-Id: <20220906020514.4169975-1-13667453960@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:GtxpCgA3NAfcqhZjHAaSbA--.23398S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrury7Jr47ZFy5Jw4rXFyUtrb_yoWDtFXEkr 1UZanrXrWFyF4Sv3WjkF4Sqry2934UuFWkCFnaqa9agayUGa17X34qyr1fGFnxGrW8tw13 C3ZxJrWUtF48JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU88sqJUUUUU== X-Originating-IP: [116.128.244.169] X-CM-SenderInfo: bprtllyxuvjmiwq6il2tof0z/1tbiyB10+1p7HnJeYwAAsq From: Jiangshan Yi Fix spelling typo in comment. Reported-by: k2ci Signed-off-by: Jiangshan Yi --- drivers/block/xen-blkback/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h index a28473470e66..4223995642f4 100644 --- a/drivers/block/xen-blkback/common.h +++ b/drivers/block/xen-blkback/common.h @@ -132,7 +132,7 @@ struct blkif_x86_32_request { struct blkif_x86_64_request_rw { uint8_t nr_segments; /* number of segments */ blkif_vdev_t handle; /* only for read/write requests */ - uint32_t _pad1; /* offsetof(blkif_reqest..,u.rw.id)==8 */ + uint32_t _pad1; /* offsetof(blkif_request..,u.rw.id)==8 */ uint64_t id; blkif_sector_t sector_number;/* start sector idx on disk (r/w only) */ struct blkif_request_segment seg[BLKIF_MAX_SEGMENTS_PER_REQUEST]; -- 2.25.1 No virus found Checked by Hillstone Network AntiVirus From xen-devel-bounces@lists.xenproject.org Tue Sep 06 04:18:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 04:18:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399349.640488 (Exim 4.92) (envelope-from ) id 1oVQ27-0008G8-OR; Tue, 06 Sep 2022 04:17:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399349.640488; Tue, 06 Sep 2022 04:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQ27-0008G1-Lk; Tue, 06 Sep 2022 04:17:55 +0000 Received: by outflank-mailman (input) for mailman id 399349; Tue, 06 Sep 2022 04:17:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQ25-0008Fr-F6; Tue, 06 Sep 2022 04:17:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQ25-0001IY-D4; Tue, 06 Sep 2022 04:17:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQ24-0004nI-QL; Tue, 06 Sep 2022 04:17:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVQ24-00013q-Py; Tue, 06 Sep 2022 04:17:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yj6PjW74Fllj2yR7u1jBhNfBih6fVK24pElc6Ewa3ZU=; b=c7oGxuKY1TLjpFt9TizwmTUgvK N6hQ9yl4kbMeP8DBfUkR9+7U4f2k9DjW9xQmjUwrtPDnYAVGhENWqOT2ZX9i4FQ6qXwOfn/71F6OL aZFOCBkRbBlIafswUNYYZ6Csh32RczShVhQCxOFXMHFJrNppzWhet6nAnLUj9CwcFWR0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173008: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Tue, 06 Sep 2022 04:17:52 +0000 flight 173008 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173008/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 33 days Failing since 172384 2022-08-11 11:13:58 Z 25 days 55 attempts Testing same since 173008 2022-09-05 15:47:43 Z 0 days 1 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 04:41:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 04:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399360.640499 (Exim 4.92) (envelope-from ) id 1oVQOT-0003AK-O7; Tue, 06 Sep 2022 04:41:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399360.640499; Tue, 06 Sep 2022 04:41:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQOT-0003AD-Jf; Tue, 06 Sep 2022 04:41:01 +0000 Received: by outflank-mailman (input) for mailman id 399360; Tue, 06 Sep 2022 04:41:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQOS-0003A3-T9; Tue, 06 Sep 2022 04:41:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQOS-0001pc-Qt; Tue, 06 Sep 2022 04:41:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVQOS-0005pO-Dw; Tue, 06 Sep 2022 04:41:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVQOS-0001VS-BS; Tue, 06 Sep 2022 04:41:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YxHm1IC0khzmlt6mRxMt4GyZRI7zZYC3RpnOaskgoHY=; b=fyBKbLdP+HBaGttvU4VswLHXqt jwnz1kp3u8lSxFoArrmFmKdpn29VC2jyE6LghRv9kBF7Ro5EXmSnVEYoLCqO8sc5ygnxhaH9X8k4V i7drXlpLmodMYnJHXXQg01o1U40viUnY+bpOFmmdQFEFk0qSDU0O85ug15HOEyM/HTvw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173014: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=c05a218a9758225ddf94eedb365633f2154551da X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 06 Sep 2022 04:41:00 +0000 flight 173014 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173014/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf c05a218a9758225ddf94eedb365633f2154551da baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 32 days Failing since 172151 2022-08-05 02:40:28 Z 32 days 251 attempts Testing same since 173009 2022-09-05 15:47:58 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1685 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:27:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:27:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399370.640512 (Exim 4.92) (envelope-from ) id 1oVS3R-0005DO-Ct; Tue, 06 Sep 2022 06:27:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399370.640512; Tue, 06 Sep 2022 06:27:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVS3R-0005DH-AA; Tue, 06 Sep 2022 06:27:25 +0000 Received: by outflank-mailman (input) for mailman id 399370; Tue, 06 Sep 2022 06:27:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVS3P-0005DB-RV for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:27:24 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6b32866-2dac-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 08:27:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 706B4B81619; Tue, 6 Sep 2022 06:27:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EEBEC433D6; Tue, 6 Sep 2022 06:27:20 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oVS3J-008ET7-P2; Tue, 06 Sep 2022 07:27:17 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6b32866-2dac-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662445640; bh=igFNa4rbBoErHv0XWpIkATD1jfwiBEbsi335mfFwe7w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PqjCFCDYkb6Dw/p5YNwrg9LJVAoM2erCwaEplExiJbiagUZnruBpROt79ONc/S5ZT UTsZR0ggiR+8kpYWP182LJE8tEjGUlVQyl1Ln53bU1e62Sl5roUdU0snv5TkIsBggI cHgBlqXCdHBjjA/7tFTsJJdZmIUPiKAzpXTKw2a0uGhXSQmYRvxgRdY0lby0+dpRkh Hy6xvm/E6Cjwzcbek8ljv+ThC52mBNyZLPPtgx/RH8BXS/gqkOgt9kaGGPxvy91GYP eToDuKt30DfcZtX20s5zvCfGjo1oOIv621+N5+E7dlKs0OfheV6Mk+qneNxTE2v5Uw FYP2qPsAjavEw== Date: Tue, 06 Sep 2022 07:27:17 +0100 Message-ID: <87r10puiey.wl-maz@kernel.org> From: Marc Zyngier To: Leo Yan Cc: Julien Grall , Ard Biesheuvel , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table In-Reply-To: References: <99e460f1-ca5f-b520-69e0-b250915fd591@xen.org> <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: leo.yan@linaro.org, julien@xen.org, ardb@kernel.org, jbeulich@suse.com, Bertrand.Marquis@arm.com, Rahul.Singh@arm.com, peter.griffin@linaro.org, xen-devel@lists.xenproject.org, jgrall@amazon.com, mathieu.poirier@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 06 Sep 2022 03:52:37 +0100, Leo Yan wrote: > > On Thu, Aug 25, 2022 at 10:40:41PM +0800, Leo Yan wrote: > > [...] > > > > > But here I still cannot create the concept that how GIC RD tables play > > > > roles to support the para virtualization or passthrough mode. > > > > > > I am not sure what you are actually asking. The pending tables are just > > > memory you give to the GICv3 to record the state of the interrupts. > > > > For more specific, Xen has its own RD pending table, and we can use > > this pending table to set state for SGI/PPI/LPI for a specific CPU > > interface. Xen works as hypervisor, it saves and restores the pending > > table according to switched in VM context, right? > > > > On the other hand, what's the purpose for Linux kernel's GIC RD > > pending table? Is it only used for nested virtulisation? I mean if > > Linux kernel's GIC RD pending table is not used for the drivers in > > Dom0 or DomU, then it's useless to pass it from the primary kernel to > > secondary kernel; as result, we don't need to reserve the persistent > > memory for the pending table in this case. > > I don't receive further confirmation from Marc, anyway, I tried to cook > a kernel patch to mute the kernel oops [1]. What sort of confirmation do you expect from me? None of what you write above make much sense in the face of the architecture. > Hope this is not too arbitrary and we can move forward a bit. > > Thanks, > Leo > > [1] https://lore.kernel.org/lkml/20220906024040.503764-1-leo.yan@linaro.org/T/#u I'm totally baffled by the fact you're trying to add some extra hacks to Linux just to paper over some of the Xen's own issues. M. -- Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:33:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:33:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399377.640523 (Exim 4.92) (envelope-from ) id 1oVS9e-0006hi-2o; Tue, 06 Sep 2022 06:33:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399377.640523; Tue, 06 Sep 2022 06:33:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVS9e-0006hb-00; Tue, 06 Sep 2022 06:33:50 +0000 Received: by outflank-mailman (input) for mailman id 399377; Tue, 06 Sep 2022 06:33:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVS9d-0006hV-0h for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:33:49 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc86f690-2dad-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 08:33:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8368.eurprd04.prod.outlook.com (2603:10a6:102:1bf::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 06:33:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 06:33:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc86f690-2dad-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mtd5u3q8zVQxs3Q4q/2DFcYsEIiwqBAyQyjEFZ15Bco8qxdZqdJZ4zgz8IwliubYxsEQwOR6N1KDdw+EEC/juHWYiWaeTvxjhhLquKfoBSTIE6orm8fsQtUeDgIioYJCKCN1wFkTRZLNPeNOdamBKeN9oJBLupUaja2ni1KMJM1JOAf0OFqAp/0iQK0k424uN9tuu+JBQarO2mktEsz0Z07/CONaeRtBthM/xg4O/+rzTuzdzbJ+DpkYeqmYmbrKV7dl/MBaaA3Tv0+PsXIrUgv8ibICru/EwUhQNmUnj4u77HEuNcq9Jeq7tLl7g2pC6LbuVTRNtNcttPpDMUfpCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPmF2/PqohE6KhCfmaPh7Kot0HjxeHWQOTXeX2dsNPg=; b=ThBTDuAr+7m+AN9p6itHXnA3MQZLcXs2afpVPdt5YEtN3GHXDmui+Fi992X9LxTMgbLlHIJM0mOx3pDA9SZPIqtNEuSrLWt2N+eWy6oqoLsVIa3vUTrdwObiSxSfKaU/dbbPi6ILVncO96ElSqTdcu1lxL+ezVvayHGfAhlNKqOII/KiHjyQe0Gno1Hk6zJ33JJdRJaC3ox0Y33aSY0tS9hoCSMCBBXd+R1Yy9ZFpqswj2Ey7yqdZkGnt5dtqjIzZjXHoxMBL7pEc6pG9kbWmh21JIAygJusak/m32D9un7h87ZKo78ZnwzIpMT1t7oSyH+6HqXiBYR4l+a1IUFn3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TPmF2/PqohE6KhCfmaPh7Kot0HjxeHWQOTXeX2dsNPg=; b=flZSZoFsWlzOWnVW5gfJva5cwD8CsTNfqlNyOMUhAxdXYOZepTWpVbsafQi9uIxqi7uI3tM41lqnPxMmLwwhXzdJAcQJaWBoAKRyy0vocSLF/QQAOWBP0jejHjg4se/sPxAjaS+XHo24m+a+3O++LzvIQPivdnEVaCVzjr5suvXe1Id3cHQVUal7A+29npFMyephqlOQS96VPg6+TtkVjz6FQe2Gn99vN2NFLddVrsUtVjvw0JwpHScPthltvGJmBcX2DZLHvk8BMAP5A5a3oHlPzgRwKCX/lWaj+GnxI8m3zZ1mkGHl01RSEfrDYoWTwdPhqPmcL+4L6Ke26PllPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <384fbd22-909a-b56c-9cc2-0765f2498b9e@suse.com> Date: Tue, 6 Sep 2022 08:33:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap To: Penny Zheng Cc: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220816023658.3551936-1-Penny.Zheng@arm.com> <20220816023658.3551936-9-Penny.Zheng@arm.com> <691b68f0-db68-b400-5473-558583f8dbc1@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0111.eurprd04.prod.outlook.com (2603:10a6:20b:31e::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41534e9f-ad38-45c5-3b5a-08da8fd1c004 X-MS-TrafficTypeDiagnostic: PAXPR04MB8368:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wrStnvZPcurLSJpA3NlNAlnsZ+dM3e2/Ccm5zQP/GsWC8zqvKPLlyMYZFS1EZiR8tnTlndiOUhEJvn8kuU948PdB6oh12BeF5vTQs0kkU9KAKPvgp1gIgProO/f1SDmvxWKGqV9iwLY7HDu3vLRLhzEWVlsShhpTAlKEYDkagL6WNm+XtL5S6XKVGSBBKXFttrmSRH14h0CxGLK0E7ohuxuE1Z2vM48+MIMSMvSavO23WIMofL6eVqGJUwyy6IfaZkBnYzlydhe3pZKvJxYAklqLJsd+0/ixG55t83fYVO+yJ8dLku8qwspBNpHOv+l15j20zM49/Snk+37RiESukFZirMJE0SSMI1xKrZd/ckApNkoydI0toGMXsKk5zLKD2C3yDNMfrRyP2gsDx8elc7bFPCgetJ9bUqKnuntnSbTRRKjj7exTMLq4mgFrqWCgrRQDF42HJq3c7XhdRV7+cF+vI8zSrdz1pZ7njOk6Ep8bY1rt4sM9XUjx4iplQ+HJy0sInyBF9VDtj8yoFn507Cm8KyeW0Jj8OXVLoKvzmcXEQc8FD/LKyKI1BdpMd8o8GTy+qOv8wVODIYtz64yU78AthAWnpnVzjy+3OmrQx4cr0nr0nAkC4ssSYMKb7PLzpxqiWu/fpIy5ZK+tVriZlczrk7rKdk/nhj8lJHMvfJjf40dnbzYex/2LJ3bawJidyiJaj7VFvTziHgK3FhUI3ZmO2+wfu2iAx7C26edlxY33n3ASOeYhhWTlN3MEkfCDHs8+RhF2AKa2Z1MNxhBE6Wlia1hDsMCBZzHgJt3Tcuk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(396003)(39860400002)(346002)(136003)(38100700002)(31686004)(36756003)(186003)(2616005)(54906003)(6916009)(316002)(8936002)(6506007)(6486002)(66476007)(4326008)(478600001)(5660300002)(8676002)(66946007)(86362001)(31696002)(53546011)(83380400001)(66556008)(6666004)(26005)(2906002)(41300700001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkxpWWROUkZPZzJscnFiZ0hxTkkwSVB1RUZBZG0vcGNQc1FiOFBhaEx1M1BZ?= =?utf-8?B?TVdjQ0pRYXJiWGRidUN5RXgySG80aStGSUVubVpteENZbzh5TURPOTZSeHR2?= =?utf-8?B?RnFQcmNWbkFyYVgzREd5WE1KUXR0Z2ZPVTZIYnROZ25DSm5xMi9RaW5ubGdF?= =?utf-8?B?TEV2aldoT1B3dW1jRWF3dkVtWStpTTRGTzMwZ1NDZlVGOVdqaEhiVWZJZ1dP?= =?utf-8?B?Qk9jVGdTMjdEWXVkNWdlakduNlBibkYzOTA3ZE83YVZDdTVaS0YwQjJseXow?= =?utf-8?B?UjN5QmpJVW9OQVo4N3BDeGQ0TndMZ3JyVG5jNm1CajRMNmcweGFSOG56L3RW?= =?utf-8?B?WU1pN1FKMVNHUFRsQnVGQkZ2bFhtdXlGb3NOZUV1ZUJ1N1ZnU3J1cXJlRlpP?= =?utf-8?B?dktjeFpjTUdacFFaL2hZZCtLWFRzY0V1Zks0cHlBVGYxSmpDVVorZjhJV0tJ?= =?utf-8?B?a29nejhEcGx2ZUhtZlh4VklvNjVOQWVBUkhCcWxPRG1KSmRTRUF3b3QrQU9X?= =?utf-8?B?R3c0L2YzQVFxWEZiRHVKL3lxWmhPSktyM3dMTzIxWXdhZU4xYnpCWXlBQjZo?= =?utf-8?B?eEcvRE51L0NZSDlwalpMMmNHSENTeEpadmE5UWJ3dWM3V3ByS0Z5RUFjSnc5?= =?utf-8?B?ejlMVGZHVUR1WXNzNHJXMG9UbHZ5bTZ6eGpQQWtNYjE3VXVhZlJyem9RbWRz?= =?utf-8?B?V0M0THV6MWFZTkFYZ0dISXBJQ2QydS92d21zdzVBMmZ6SmJMZnFHUWt4emRW?= =?utf-8?B?b09sY0kzWW9pQU5xWHJ2aFJWVUR3VGVDVHpLUk5sVy9aUmZ1cnlQWHJrTmdo?= =?utf-8?B?OEMyakcxd3MrbkdDQ2liS2lCYTNiTGVYNXc1OUZoeTFYczgwSmpNVVNSYTht?= =?utf-8?B?dzgyQmV2SldjenEvSWNsb0t1emlab0pSaXFpeHBZU0F3K3NYY3FGc1dwak1F?= =?utf-8?B?bUlCdmdwdThpU3NsWjRINUZ6N09lVTh3QmttTll3SExsaC9yaE0wQlFtYXZx?= =?utf-8?B?WDVMUE5wc3RrZ2JSNnBrL1pwK3FHZldxTzZGZkR0a1pIMWIxdSt1elVyNmpR?= =?utf-8?B?UFpoRjVXdW9rZkFOWDZLeG0vTmlGVENjYTRmSDlBMjF0NzliQXI5emZxM2Zw?= =?utf-8?B?R0s3anJSanhvTjgvajQ1Mm56UGxyRDNYMTVwVlJJd0FTbWRrbUxKTXhLVFhv?= =?utf-8?B?ZzlHTGluTE5hWVFtMTlOcnpBWnlWMWZ1ZERkeFJBR2hlZWFFZXRmVG5pdjFh?= =?utf-8?B?RTIyVjF1cFZGYXNEUmtNb2kycWRPZXhiQWp1cm5YYTR0d3dZVmtkcXVyVDFv?= =?utf-8?B?aHJEWGN4akYyNmloaWtDWXJ1NGhFWHJwSTd6TWtuU0ZvMzRLeHJKc242cExM?= =?utf-8?B?SVdLZFRIanlkb3ZDbTRCTElMMXB1R29Lemc4ZDlXV2xVUUhpMXZPa3ZiKzVX?= =?utf-8?B?S2k1VFZBWm9ZYVdtM3BxaWNpV1M0Vy9ibFFPaTF3Y0VyZ3JLdGIvMThxUEd6?= =?utf-8?B?RmcveXZHT0c3VzFWUkZQVVlGOHBXcEpYN1NRNzNwZzN6U1VMbVNHc1ZFZk9a?= =?utf-8?B?NFZDdVFLNjk2TzJvY1JEc25uUlN6UEw0MkdTUUJFZCtsbTFpd0dKT3JId2pP?= =?utf-8?B?bEdtbWg2U01RcGl5aVEvMXJ2aUtoMjF1dW5MVWlNcDJmd0hsWXByLzF3VnVK?= =?utf-8?B?Wll2dzVPS3lBNDU2UWdiV09zR21ZZHo4TEQ1aFVueW91R1o4RWU2UC91di90?= =?utf-8?B?VG9WcldJcTdmb0xyQ1NRMGVBQi9rRnMxQ2dVSlJnZDRmODRnYStrOTA1VlJX?= =?utf-8?B?RHZtKys1WUpZRTlFR0lNdktSSTl4dUhQMmQwUGhGWVRpakdwc09HYVZYR2ZP?= =?utf-8?B?TW9xdFB1QW5MNUlWNUlpMWpFdUZQcUlpQ0VqV1MxY0ROQS9wYy9uMmwxVUR3?= =?utf-8?B?QVJUaThoTFNodzI4Q2V2Uk94NHhwVHl6SHBWQTlMTGoyZWtNN0ZuZHA2dzNK?= =?utf-8?B?MFlSQ1JGVlFLNlFPaHgrOVgvUjg3YjkvRktKWU9GL25uZnhqYUpjV2F6UDJh?= =?utf-8?B?RlA2VnhybjVyYUp1ekVsaFFoaFBjNUNBZ2twUWFFeFBCMXJmeml5cFVxNUp2?= =?utf-8?Q?CktAoKdKWn9tKIDhGTe6p76dN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41534e9f-ad38-45c5-3b5a-08da8fd1c004 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:33:46.0192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6GHEf5ODZbLXKkt3BXzkIECMppEVWfSttsFT+vW7zvlzvTHx/YQeeq6BcATQLmSEij5ileRouDHKArvgmpDshw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8368 On 05.09.2022 09:08, Penny Zheng wrote: > Hi jan > >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, August 17, 2022 6:05 PM >> To: Penny Zheng >> Cc: Wei Chen ; Andrew Cooper >> ; George Dunlap ; >> Julien Grall ; Stefano Stabellini ; >> Wei Liu ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v10 8/9] xen: retrieve reserved pages on >> populate_physmap >> >> On 16.08.2022 04:36, Penny Zheng wrote: >>> @@ -2867,6 +2854,61 @@ int __init acquire_domstatic_pages(struct >>> domain *d, mfn_t smfn, >>> >>> return 0; >>> } >>> + >>> +/* >>> + * Acquire nr_mfns contiguous pages, starting at #smfn, of static >>> +memory, >>> + * then assign them to one specific domain #d. >>> + */ >>> +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, >>> + unsigned int nr_mfns, unsigned int >>> +memflags) { >>> + struct page_info *pg; >>> + >>> + ASSERT_ALLOC_CONTEXT(); >>> + >>> + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); >>> + if ( !pg ) >>> + return -ENOENT; >>> + >>> + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) >>> + return -EINVAL; >>> + >>> + return 0; >>> +} >>> + >>> +/* >>> + * Acquire a page from reserved page list(resv_page_list), when >>> +populating >>> + * memory for static domain on runtime. >>> + */ >>> +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) >>> +{ >>> + struct page_info *page; >>> + >>> + ASSERT_ALLOC_CONTEXT(); >>> + >>> + /* Acquire a page from reserved page list(resv_page_list). */ >>> + spin_lock(&d->page_alloc_lock); >>> + page = page_list_remove_head(&d->resv_page_list); >>> + spin_unlock(&d->page_alloc_lock); >>> + if ( unlikely(!page) ) >>> + return INVALID_MFN; >>> + >>> + if ( !prepare_staticmem_pages(page, 1, memflags) ) >>> + goto fail; >>> + >>> + if ( assign_domstatic_pages(d, page, 1, memflags) ) >>> + goto fail_assign; >>> + >>> + return page_to_mfn(page); >>> + >>> + fail_assign: >>> + free_staticmem_pages(page, 1, memflags & MEMF_no_scrub); >> >> Doesn't this need to be !(memflags & MEMF_no_scrub)? And then - with > > I got a bit confused about this flag MEMF_no_scrub, does it mean no need > to scrub? Yes, as its name says. > Since I saw that in alloc_domheap_pages(...) > if ( assign_page(pg, order, d, memflags) ) > { > free_heap_pages(pg, order, memflags & MEMF_no_scrub); > return NULL; > } > It doesn't contain exclamation mark too... Hmm, you're right - on these error paths the scrubbing is needed if the page wasn't previously scrubbed, as part of the set of pages may have been transiently exposed to the guest (and by guessing it may have been able to actually access the pages; I'm inclined to say it's its own fault though if that way information is being leaked). But ... >> assignment having failed and with it being just a single page we're talking >> about, the page was not exposed to the guest at any point afaict. So I don't >> see the need for scrubbing in the first place. while my comment wasn't really correct, as said - you don't need any scrubbing here at all, I think. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:34:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:34:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399383.640535 (Exim 4.92) (envelope-from ) id 1oVSAR-0007Eq-DB; Tue, 06 Sep 2022 06:34:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399383.640535; Tue, 06 Sep 2022 06:34:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSAR-0007Ei-9v; Tue, 06 Sep 2022 06:34:39 +0000 Received: by outflank-mailman (input) for mailman id 399383; Tue, 06 Sep 2022 06:34:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSAP-0007EQ-O9 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:34:37 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2081.outbound.protection.outlook.com [40.107.94.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7bc928b-2dad-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 08:34:34 +0200 (CEST) Received: from DM6PR03CA0085.namprd03.prod.outlook.com (2603:10b6:5:333::18) by CH0PR12MB5090.namprd12.prod.outlook.com (2603:10b6:610:bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 06:34:32 +0000 Received: from DM6NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:5:333:cafe::74) by DM6PR03CA0085.outlook.office365.com (2603:10b6:5:333::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 06:34:32 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT068.mail.protection.outlook.com (10.13.173.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 06:34:32 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 01:34:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 01:34:18 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 6 Sep 2022 01:34:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7bc928b-2dad-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JNsOOFWAMO/U4JTKxIUlr314C8rdCmA24BwwQr1tqbqvolXqD4U+NHBl+5Oh0tJJiR1xyU4ro4kVQTHKEyYAfhIDnLF0HtkILTdesaROR34hwdSXusuCHj7hGDRO1pvHoWhBbNSZIKjWLyxkxH+wiZvHkBkzsx6vGNUL6mp42pBDXO1Brz8raOj9jaj+HXQCW1xdq216ZriDaNygWClWusVCaKzhOdGb9ixt0n6izUX9ZCE3AiYDPihBoSwkWb9qdOJKyXuaJZTZa0IUmLNNVlsN9TwOX3TDa6ISopaisr0BWlUAOnItHhLh/1stn6bD7Pz3s7DpP07ahoitnnbmVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6cV2/+PYa5+t3tkC0QaGXJzpjfNp0WjGvwv4ZDJmXiM=; b=IBcfEomIdiTYV9Elt9nJZwWB/P+7CtguwZ1AMFSj6U8FJElDLvSoJY2AwFqZs/RDcm9FcLwZ205nh9IApLjKgFCCbA9kdEp5yQ0TuyAgQiVnKEmjBhYQPYpIWQFj9GOSff74HAsFrO9yodpZHrmRed2WEnzmxZdAvjfK23KfQAcc9E/n5OoeDWMa6YC70VGeqaVeA5kUXkiLD5H8yhqR1EoS6jBYZNlO6NMVp8gu5MUbkl6f/jfx1DUwT7nkGbhoTskUFVNctp3a17jSf+DS7aieRhTwaIvD9fV2mlDzIqgXj5Plg+8OLeF3fRtgpMEtXK/ybV2qTdcijShz+gmMDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cV2/+PYa5+t3tkC0QaGXJzpjfNp0WjGvwv4ZDJmXiM=; b=Am9bSCNfMkGy0sUec+I1cZp2OXjS7OuBNnANnt7nURVZfgFM2aPOJREhwn2wfMNOev2afFSjt1saXt8b5eG+CrQWrKNbcmn/L5QkoIcl/7W1tby8tsDm7E4+E+4EBWn+RoOPG6ioJz6p7yvEBGgkZBwcTe9a4s7R2UzovrHZtrg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <4030d661-7b25-4957-e2dc-069fb4030ea0@amd.com> Date: Tue, 6 Sep 2022 08:34:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory To: Julien Grall , Henry Wang , CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> <8325d0ce-1fd3-d754-9eaf-d73b19f8d53e@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <8325d0ce-1fd3-d754-9eaf-d73b19f8d53e@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df552572-8b63-42a2-5f47-08da8fd1dbb8 X-MS-TrafficTypeDiagnostic: CH0PR12MB5090:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TzMj8/bGQvmVz8hGTdDBXDLiTSZxSranQ1Ueg9eogIPExptyCcSD1KdEjvxNqw1MnAQ9eSXYqAq43+8mLR2bAz5iG7t2L2rRucYsEJuRPAzBm4jy3ltqizAXltXDnUQd/WSvs6naI1Dx6AD7HNwrHsBZh4p/UZuHSJTxjfKDU+OH7Q2jiNCiTI/CCrStGCAxanVh1cwdVCh8XfZth7UfJyyrcwQdCXOaeH3Sc5MWt/apjh6UVJ3JtJfSEdzG7/XAXwBgWMura4Bo+HDqfRtkvlBRXJ1A0aRx6AmCE1xQnYgH917eVvZKGq2SjRunRKI61YF5JyRtAdxwRvGRzpOE4QKVukPmBQDYd+qAFNF6dIvqKWmI54ezbTexVvvLwVFEmHraXzh0dr60J/YxWYhMy/3RTL7Sis5mcie7LkYXVUduKD8boTRqU19gxtrdYaUPcqaL0R7gCkhT/SH0C8Lf62IbroYcSm0hMXA0PfpuiEk+VDjyZX0PKU/+dP4tn4M7gDKla7WN4ug9FQO5tJ322xgEBvQjBJ8Uq5+qsB41cOaTNFnSANfDnd2NK93w+9VzB6iQhRzLftZh6ANi6sdPKdU8L/KzmJTOkKskIY1LJe5to4+NbxbmGt8iMmhdDIkzcKRtEuQ2LpSOFTv4mc6eLxOUv5HKLizkKcqNWyiCpasPeuafR3isz371UFgOFv89wnh8Z904tF1vZ+FxbpUa2cMp4N7RlG8xHcdxDFvEeHjXhFosqvmcQSy71a7lrs4i26G4QqZg52udd+fQecfK98Y8mJfNSSjM+8d1Z+ByXO4cseIy4to6qgZokjMCCUnpWVIHkXZv27n8ZAh2omoVaQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(36840700001)(40470700004)(82740400003)(54906003)(47076005)(186003)(336012)(110136005)(426003)(356005)(36860700001)(82310400005)(40480700001)(2616005)(83380400001)(16576012)(31686004)(316002)(8936002)(40460700003)(26005)(2906002)(36756003)(41300700001)(53546011)(4326008)(8676002)(5660300002)(31696002)(81166007)(44832011)(478600001)(70586007)(86362001)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:34:32.2482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df552572-8b63-42a2-5f47-08da8fd1dbb8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5090 Hi Julien, On 05/09/2022 19:24, Julien Grall wrote: > > Hi Michal, > > On 05/09/2022 13:04, Michal Orzel wrote: >> On 05/09/2022 09:26, Henry Wang wrote: >>> >>> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h >>> index 5815ccf8c5..d0cc556833 100644 >>> --- a/xen/arch/arm/include/asm/setup.h >>> +++ b/xen/arch/arm/include/asm/setup.h >>> @@ -22,11 +22,16 @@ typedef enum { >>> BOOTMOD_UNKNOWN >>> } bootmodule_kind; >>> >>> +typedef enum { >>> + MEMBANK_MEMORY, >>> + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain. */ >>> + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */ >>> +} membank_type; >> Whereas the patch itself looks ok (it must be modified anyway given the comments for patch #2), >> MEMBANK_XEN_DOMAIN name is quite ambiguous to me, now when it is part of membank_type enum. >> Something like MEMBANK_STATIC or MEMBANK_STATICMEM would be much cleaner in my opinion >> as it would directly indicate what type of memory we are talking about. > > I am not sure. Technically the reserved heap is static memory that has > been allocated for the heap. In fact, I think thn name "staticmem" is > now becoming quite confusing because we are referring to a very specific > use case (i.e. memory that has been reserved for domain use). > > So I would prefer if we keep "domain" in the name. Maybe > MEMBANK_STATIC_DOMAIN or MEMBANK_RESERVED_DOMAIN. > Personally I would drop completely using the "reserved heap" naming in favor of "static heap" because "staticmem" is also something we reserve at boot time for a domain use. This would also directly correlate to the device tree property "static-heap" and "static-mem". Then such enum would be created as follows and for me this is the cleanest solution: MEMBANK_DEFAULT MEMBANK_STATIC_DOMAIN MEMBANK_STATIC_HEAP But I think we are already too late in this series to request such changes, so with the current naming we can go for: MEMBANK_DEFAULT MEMBANK_RSVD_DOMAIN /* memory reserved for a domain use */ MEMBANK_RSVD_HEAP /* memory reserved for a heap use */ > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:41:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:41:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399394.640546 (Exim 4.92) (envelope-from ) id 1oVSH7-0000NN-7s; Tue, 06 Sep 2022 06:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399394.640546; Tue, 06 Sep 2022 06:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSH7-0000NG-57; Tue, 06 Sep 2022 06:41:33 +0000 Received: by outflank-mailman (input) for mailman id 399394; Tue, 06 Sep 2022 06:41:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSH5-0000NA-VY for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:41:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eeebcf1a-2dae-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 08:41:28 +0200 (CEST) Received: from AM7PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:20b:110::40) by PAVPR08MB9063.eurprd08.prod.outlook.com (2603:10a6:102:325::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Tue, 6 Sep 2022 06:41:24 +0000 Received: from AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::69) by AM7PR04CA0030.outlook.office365.com (2603:10a6:20b:110::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 06:41:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT060.mail.protection.outlook.com (100.127.140.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 06:41:23 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Tue, 06 Sep 2022 06:41:23 +0000 Received: from b6d8896b728f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 19F261C3-A53F-4191-983A-5741AB42F44D.1; Tue, 06 Sep 2022 06:41:18 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b6d8896b728f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 06:41:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8711.eurprd08.prod.outlook.com (2603:10a6:10:401::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 06:41:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 06:41:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eeebcf1a-2dae-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Qh7rPBcHUgZkHATuuGDJuPZpK6FnUukcocu3OgjrXvCRGhfNHUox0BDa6r9YY7KtS2Dy9QIlrK2T1xFvX2yhlkjLvximHceiy++CDPZtOwDnWYALx/govt+RW0oOZ9ohzD1/ntUMob/j44wmZn9lsPgGDDlgypY7O9raEVvaXWAnBN83VHHIb46LNWTCFvclGZREFz2e19OaWp6s6HaVDKVWoXez818IajPxnzdf2aAB/1LzRaGSfYJ75PjuONXmJmA/LH4ZOoTh0xNC4f4XY/IcqxGJJM9D7FOMlfoTkmOGHyptQj4ZLrb+hOGUvaDT5vLTYAgrn8YYHPfcOlilfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ug7/sB5v5qriGhe8kvJtO8YG7xZW2naa63COGHavWYw=; b=VHbVxSUh9VRLlTT+evhlCf9vQCr3oPclpkWkcWoARPgub4RIg9JHpPBQQmCoXPkCMBN8lF98pNhrsUuMj043BNaSoRXMEcAd9+hSF+JjlAkePMKXHgIfESQAYogbys6y5ysszsO9jDyihfNn3hdCjas2GkIs+bC15sxvNcFa5y/iBexcrA0Vm3mM9PK6xIbDr+w9rrPTV+AOGDrZjtC2UuBnGufcusHOcVngK3BeNR7cinsTNrSv013dNH6bn86vQScHjoPjgpp8uDZFC3DEAwvpSOxC8SkqysybSxtxi2biYTpcSHHK195DOVA5lDpadNdKovRZCZ9jsLNe+tY25g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ug7/sB5v5qriGhe8kvJtO8YG7xZW2naa63COGHavWYw=; b=YAPiaEggho5uHfJySTYkTMgNQ23ud8zPfOmYB9Lu1be6NbtAz/AG1MA6vo3Br3VYTqmqoFgqL/pp6M/HT1PzRoQ1v61gCOnrwFp06/QjwXAEPfbeyMDhak3WYQrfQJStxNkpEIVEzRJ+q//ytucE0ZMKt19rM/eAVFXJ8QTKGic= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qa7r6cZSQ4yPiwN49DvMm+qiWHu2watumMXBIQRhVXxC72cFpPY20hGN9JZlhpezdRNS5Q+fXcyRniBc1+suMmpLg/BzItDvnOi/DWTkTKfqu+WXs0rtQorqbMTbbtfGMAwp1UutXcV2zt6vOg6e9kYtqCq/iaM63hl6qHPCW/i1ZtkqcrDQvoAS6URzV6IM6XYKcCs0xuvEA/lqWt6xg7yK0USiAn0FDgWJ6jsVG9rdpHrb41XsaSsWgG8U1zjUBiz3quyTf4b9CHU4wkanG0pttZJ44yzaUiGLmnvf3uNSjKdGiXntLeDnVkix+ho5f5l3oAH4Uch2V4BiYWM2MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ug7/sB5v5qriGhe8kvJtO8YG7xZW2naa63COGHavWYw=; b=oPObpYS9rpmIDPh58hLl7g9reBCd+yk0mdZDeXRhAtt7oWn+37PBunR/PoLKpg5fWU6qXCuwdv0r/KB0CoyUp4siWnCCBW02EDbT+5KaNYkMtNbrM0T4uZ9L8+ORW5DHhFjX0MuDh5zdcS5Um1xLEIolVC3CxpuJYQCixRGpRkmnEhnYTxMnyPWnmnkogv/9hqDag3xTFEoF9Sk49ywi4y3cO44UNN4Z8OuofZdj2lWOAYcrQ4LOubMjUpjd6bZnQ0X4CzGTvjOxJtA9sK/7lVNzWgCYjZVwdWXe/ylyngfD3aRDGKwgiSuF34/DQdclncEMFSo8P9OAm1cURjOILA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ug7/sB5v5qriGhe8kvJtO8YG7xZW2naa63COGHavWYw=; b=YAPiaEggho5uHfJySTYkTMgNQ23ud8zPfOmYB9Lu1be6NbtAz/AG1MA6vo3Br3VYTqmqoFgqL/pp6M/HT1PzRoQ1v61gCOnrwFp06/QjwXAEPfbeyMDhak3WYQrfQJStxNkpEIVEzRJ+q//ytucE0ZMKt19rM/eAVFXJ8QTKGic= From: Henry Wang To: Michal Orzel , Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Topic: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Thread-Index: AQHYwPjzoXW29+zrjEaaAKDaLd6E0a3QvVUAgABZjgCAANyIgIAAAOmw Date: Tue, 6 Sep 2022 06:41:13 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> <8325d0ce-1fd3-d754-9eaf-d73b19f8d53e@xen.org> <4030d661-7b25-4957-e2dc-069fb4030ea0@amd.com> In-Reply-To: <4030d661-7b25-4957-e2dc-069fb4030ea0@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9D827F34F8C8AA449DB299573B7F83F7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 67af3148-f014-4db9-ef4f-08da8fd2d0f6 x-ms-traffictypediagnostic: DU0PR08MB8711:EE_|AM7EUR03FT060:EE_|PAVPR08MB9063:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IenW86inAV69wWCI32ZcmmROICVO5WqAewYaf0hyn9XRUB5/z2InIA3+ZZ28n1wHldIa5nB3/X1UFWJb9gMc2KDM+hlANiutTUKS/k+P0FO3xx1eqv8sCWGPBcd7PICZ/EOtsYgb5xFnWb8Koag376PFCXeQUviQR0lBwupXaVrxvC/RRwCkakMDvTw7qt2Ja4fpw5WgkBM+zkDzsegs5p/GpaKmpgVDGe+L9DOHOkNMaqH1V6XPOpLQRToAI+hOPDqvDDXuKcJmND141Z/hC4E5gBsAKePz4rJ3u8eY/NXzjG7EFiC3uzveOV1m6FxA3ZiAsr6pcrkNgg3Z+wc/AVxKD06r10j8diBlu3Ipyw6DYJXFQ3rd2xKoL6NAUH2h+b70Z8XRZRF/S2FigrzHdeIR8faruYuhnPP6HO69Pfw4migGMQcZAy/8mDUwMxJAHqJ1HPqzpvAK8y/gyJOi50EZ0cnFtP8ifQLbK1BcBqecg6mX2yELxE4nqrApEmmtkAYB7xywUdchKo3VjIjPGYW1eohOQW4JPTXgX0/DmF248hRkIBg/B9gu/eiTGoIKG9erWqBjUWMj4UqvCDs+zf10c44bCL6/gbo4+bpkgzflwAIWDPaJ1LrVS2fuHkL+EWSAREMJtc2OoX5SHLaijrXKzJskrr+xfbvJeVOaCGMRmCNcIneH3o3HPObzmvqhNcqzQ9taJBWUcfDzRPLHmm30VhqYrywaB54g4Vstvs3oXUmEWPbpgP4Y86gtOolou4RpWF4ufyNXWNwfCzMJww== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(110136005)(2906002)(33656002)(316002)(186003)(76116006)(5660300002)(8936002)(52536014)(66556008)(66446008)(66946007)(8676002)(4326008)(66476007)(54906003)(64756008)(86362001)(41300700001)(71200400001)(53546011)(478600001)(9686003)(7696005)(6506007)(26005)(38100700002)(38070700005)(83380400001)(55016003)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8711 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 82bc4962-d1e5-496c-213a-08da8fd2ca9f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pB3pQSjJH1z5f4cr7HsWo+bIqCpapt64e6LZqGKnl2HakuQ+/+6SxcXA2eV5+DN5cAPW2PbTocO/qCOF1sEQdOobRpVbUk+10Ke0KI1mvYCaPlFSqIZ48G/sUpcYpMvani23d0+pvTWMKyBZqe2bGldfDS5OOiJ5VcEdjBfkbn9qog8YNzkD/81KspNzUMyGlbHAwkKVQoN5Anqw0tlQAL893TICNHaXNsLNBgGPwgM9HAzF/2p1AX5cUN1LFsJ9U6D7xaB6o/m2uRQBhk2leFKny3AGoj/Yaeyckai9AyW6VLGIjrnXPM+Jn03LCWP+ajyxNj8ellYYOIb/e1wvyXyB8/QqAuG2h3akDagZQNLPdEHGfbcp9EUm3ZFm4cDfOOsxhfwxV7aju0U6PZRcrYVGuPXh0K3GzAc8LVqZYIanwCd9+gfBWQQazriRNvtSAx0FTh+6YB1WyK6lXVT60GZNzOUOrcDNOHFWM1/AZajtT9kkYbrbUqkvtguuirt49/oWnzIRYTLYy+lpTwWj3tl/4GmELXJecveqkFY/FyzizGRgiRzUsabRBeKbGT/+rV+1n1dhMyDcv0iPeuJgru+Psh44ynZfA098GGeh+c1P8t9d99tWCBnuct5q1KD+xSvXPN2NPI/G7YUOY/1uWmRSPv31gKGFbUm14i5bJ4KQqPKi1yePD55rA0MJdSib0HLR0ISM4e5Xjjr90kObW8/f7PR0BQL0W3vss4Oed61pqaSfnlR8iuF8HP75uKLyZTnT6/UNYZvBpzLsI2ip8A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(36840700001)(40470700004)(46966006)(70206006)(70586007)(356005)(47076005)(36860700001)(5660300002)(52536014)(55016003)(33656002)(54906003)(316002)(40480700001)(4326008)(86362001)(8676002)(82310400005)(2906002)(8936002)(110136005)(41300700001)(53546011)(7696005)(336012)(478600001)(40460700003)(83380400001)(26005)(82740400003)(6506007)(186003)(9686003)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:41:23.7625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67af3148-f014-4db9-ef4f-08da8fd2d0f6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9063 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg MS80XSBkb2NzLCB4ZW4vYXJtOiBJbnRyb2R1Y2UgcmVzZXJ2ZWQgaGVhcCBtZW1vcnkNCj4gDQo+ IEhpIEp1bGllbiwNCj4gDQo+IE9uIDA1LzA5LzIwMjIgMTk6MjQsIEp1bGllbiBHcmFsbCB3cm90 ZToNCj4gPg0KPiA+IEhpIE1pY2hhbCwNCj4gPg0KPiA+IE9uIDA1LzA5LzIwMjIgMTM6MDQsIE1p Y2hhbCBPcnplbCB3cm90ZToNCj4gPj4gT24gMDUvMDkvMjAyMiAwOToyNiwgSGVucnkgV2FuZyB3 cm90ZToNCj4gPj4+DQo+ID4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L3NldHVwLmgNCj4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPiA+Pj4gaW5k ZXggNTgxNWNjZjhjNS4uZDBjYzU1NjgzMyAxMDA2NDQNCj4gPj4+IC0tLSBhL3hlbi9hcmNoL2Fy bS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9h c20vc2V0dXAuaA0KPiA+Pj4gQEAgLTIyLDExICsyMiwxNiBAQCB0eXBlZGVmIGVudW0gew0KPiA+ Pj4gICAgICAgQk9PVE1PRF9VTktOT1dODQo+ID4+PiAgIH0gIGJvb3Rtb2R1bGVfa2luZDsNCj4g Pj4+DQo+ID4+PiArdHlwZWRlZiBlbnVtIHsNCj4gPj4+ICsgICAgTUVNQkFOS19NRU1PUlksDQo+ ID4+PiArICAgIE1FTUJBTktfWEVOX0RPTUFJTiwgLyogd2hldGhlciB0aGUgbWVtb3J5IGJhbmsg aXMgYm91bmQgdG8NCj4gYSBYZW4gZG9tYWluLiAqLw0KPiA+Pj4gKyAgICBNRU1CQU5LX1JTVkRf SEVBUCwgLyogd2hldGhlciB0aGUgbWVtb3J5IGJhbmsgaXMgcmVzZXJ2ZWQgYXMNCj4gaGVhcC4g Ki8NCj4gPj4+ICt9IG1lbWJhbmtfdHlwZTsNCj4gPj4gV2hlcmVhcyB0aGUgcGF0Y2ggaXRzZWxm IGxvb2tzIG9rIChpdCBtdXN0IGJlIG1vZGlmaWVkIGFueXdheSBnaXZlbiB0aGUNCj4gY29tbWVu dHMgZm9yIHBhdGNoICMyKSwNCj4gPj4gTUVNQkFOS19YRU5fRE9NQUlOIG5hbWUgaXMgcXVpdGUg YW1iaWd1b3VzIHRvIG1lLCBub3cgd2hlbiBpdCBpcw0KPiBwYXJ0IG9mIG1lbWJhbmtfdHlwZSBl bnVtLg0KPiA+PiBTb21ldGhpbmcgbGlrZSBNRU1CQU5LX1NUQVRJQyBvciBNRU1CQU5LX1NUQVRJ Q01FTSB3b3VsZCBiZQ0KPiBtdWNoIGNsZWFuZXIgaW4gbXkgb3Bpbmlvbg0KPiA+PiBhcyBpdCB3 b3VsZCBkaXJlY3RseSBpbmRpY2F0ZSB3aGF0IHR5cGUgb2YgbWVtb3J5IHdlIGFyZSB0YWxraW5n IGFib3V0Lg0KPiA+DQo+ID4gSSBhbSBub3Qgc3VyZS4gVGVjaG5pY2FsbHkgdGhlIHJlc2VydmVk IGhlYXAgaXMgc3RhdGljIG1lbW9yeSB0aGF0IGhhcw0KPiA+IGJlZW4gYWxsb2NhdGVkIGZvciB0 aGUgaGVhcC4gSW4gZmFjdCwgSSB0aGluayB0aG4gbmFtZSAic3RhdGljbWVtIiBpcw0KPiA+IG5v dyBiZWNvbWluZyBxdWl0ZSBjb25mdXNpbmcgYmVjYXVzZSB3ZSBhcmUgcmVmZXJyaW5nIHRvIGEg dmVyeSBzcGVjaWZpYw0KPiA+IHVzZSBjYXNlIChpLmUuIG1lbW9yeSB0aGF0IGhhcyBiZWVuIHJl c2VydmVkIGZvciBkb21haW4gdXNlKS4NCj4gPg0KPiA+IFNvIEkgd291bGQgcHJlZmVyIGlmIHdl IGtlZXAgImRvbWFpbiIgaW4gdGhlIG5hbWUuIE1heWJlDQo+ID4gTUVNQkFOS19TVEFUSUNfRE9N QUlOIG9yIE1FTUJBTktfUkVTRVJWRURfRE9NQUlOLg0KPiA+DQo+IFBlcnNvbmFsbHkgSSB3b3Vs ZCBkcm9wIGNvbXBsZXRlbHkgdXNpbmcgdGhlICJyZXNlcnZlZCBoZWFwIiBuYW1pbmcgaW4NCj4g ZmF2b3INCj4gb2YgInN0YXRpYyBoZWFwIiBiZWNhdXNlICJzdGF0aWNtZW0iIGlzIGFsc28gc29t ZXRoaW5nIHdlIHJlc2VydmUgYXQgYm9vdA0KPiB0aW1lIGZvciBhIGRvbWFpbiB1c2UuDQo+IFRo aXMgd291bGQgYWxzbyBkaXJlY3RseSBjb3JyZWxhdGUgdG8gdGhlIGRldmljZSB0cmVlIHByb3Bl cnR5ICJzdGF0aWMtaGVhcCINCj4gYW5kICJzdGF0aWMtbWVtIi4NCj4gVGhlbiBzdWNoIGVudW0g d291bGQgYmUgY3JlYXRlZCBhcyBmb2xsb3dzIGFuZCBmb3IgbWUgdGhpcyBpcyB0aGUgY2xlYW5l c3QNCj4gc29sdXRpb246DQo+IE1FTUJBTktfREVGQVVMVA0KPiBNRU1CQU5LX1NUQVRJQ19ET01B SU4NCj4gTUVNQkFOS19TVEFUSUNfSEVBUA0KPiANCj4gQnV0IEkgdGhpbmsgd2UgYXJlIGFscmVh ZHkgdG9vIGxhdGUgaW4gdGhpcyBzZXJpZXMgdG8gcmVxdWVzdCBzdWNoIGNoYW5nZXMsDQoNCkkg YW0gb2sgd2l0aCBhIHB1cmUgcmVuYW1pbmcgdG8gc3RhdGljIGhlYXAgaWYgSnVsaWVuIGlzIG9r IHdpdGggdGhhdC4gSSB0aGluaw0KSnVsaWVuIGhhcyBkb25lIG1vc3Qgb2YgdGhlIGNvZGUgcmV2 aWV3IGFuZCB3ZSBzdGlsbCBoYXZlIDJ+MyBkYXlzIGZvciBpdC4NCg0KS2luZCByZWdhcmRzLA0K SGVucnkNCg0KPiBTbyB3aXRoIHRoZSBjdXJyZW50IG5hbWluZyB3ZSBjYW4gZ28gZm9yOg0KPiBN RU1CQU5LX0RFRkFVTFQNCj4gTUVNQkFOS19SU1ZEX0RPTUFJTiAvKiBtZW1vcnkgcmVzZXJ2ZWQg Zm9yIGEgZG9tYWluIHVzZSAqLw0KPiBNRU1CQU5LX1JTVkRfSEVBUCAgIC8qIG1lbW9yeSByZXNl cnZlZCBmb3IgYSBoZWFwIHVzZSAqLw0KPiANCj4gPiBDaGVlcnMsDQo+ID4NCj4gPiAtLQ0KPiA+ IEp1bGllbiBHcmFsbA0KPiANCj4gfk1pY2hhbA0K From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:49:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399402.640557 (Exim 4.92) (envelope-from ) id 1oVSPD-00015s-34; Tue, 06 Sep 2022 06:49:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399402.640557; Tue, 06 Sep 2022 06:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSPC-00015l-Vm; Tue, 06 Sep 2022 06:49:54 +0000 Received: by outflank-mailman (input) for mailman id 399402; Tue, 06 Sep 2022 06:49:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSPB-00015f-IQ for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:49:53 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b5161f8-2db0-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 08:49:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5957.eurprd04.prod.outlook.com (2603:10a6:20b:9e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 06:49:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 06:49:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b5161f8-2db0-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxdsSNymekpT7hnaqzpdixTjHKlV2z4d5v+0xT0cYKo0xvHGVQGqY6u2QmUIZOGkk8lQwP15VQjgh6OH8qOmwm/IJqDWP2pLUDhBc5nqHps9zY6uhuEvPw8el26RI3cuE56BijjCDT2tE2x6NECSetZ6ArGSxKGPOUttIlsyZakdJCJZj5UbU1VRIfCokjXpZaau8jo3w3R2GIMsiHCxBFDSLw7pkRVDYL93ZrrPeiUoSPDOA1IPhqMNpr337mvFCBCp6DOONjLr8snjJlrv+TsGZRdiNSODedCheZb0OTihgzRrQ5sRB+XUHoDzha5KFkzlNl91r6mT0nGISKc62A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=daJ/X+yeFCczqqO3r5A3SgYuveEeP1d45cY5MyHiEUk=; b=WmSs5B+2MLu0+CdyxT3RngV+FIor31W/JIjfotcLWAhlI1cwdDFUNqdBj1E6aSKCJnFNpLy/Zqe9HRsn/kyzVbDWOq3E1ETSEyJxCsTXkiLuZkp6FZwdMZDw1wp7s0LJR9IRm4koFbffUgHzlErx22a8+4ezMemHHnsAMTlcPxLIy/xn4jsSpevlV1qd1QtQljnCiHeENrUm08cxvRyyWH/V/QtuMPNnjPoNLsSM9Ya7D+8ZjglqaY12tSitVAMBorMs+k0FNVjOTTEpw73Ld0TJUIbPKjJsJN7KGI1OLbpaw1AIX1ZZcqiOBrRNRZ/NtHUzwbGgxyfeRS6bUfBOhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daJ/X+yeFCczqqO3r5A3SgYuveEeP1d45cY5MyHiEUk=; b=KYEVX/Z3IHXIkthgDDPvZoal2FFKm87kGofPS5tHRVqbE29sPmx/tPQWyNPus/KVZXpCGKjDDpvNNvM7rXWjfvZu1TlXSuuJx4ygk2RwEqL30KQXdrncxpdpLMojBsatz7A3Qc7uwudfWnNYiOEyB6H/ggPEdpEStuevC6/kiwBV8ULsRM5OZBBuOxr7UXn/eKlksk+JlazHi0N2Fsgip7tOh5UhSqQu1pg20y2eCrC/V0TNMbfJ0t+eh7A6/9CYRzW22NKQo4IuBPLx9UpX/y9SxYEIYxBWlpH/QuCkQPh4+3EKQFP/amnJlWjE05B9Kpf0VS+YjHbTGKXbXOTYaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2a1a9e8c-0635-e207-e858-0e0bd1df0f11@suse.com> Date: Tue, 6 Sep 2022 08:49:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Add support for ESRT loading under Xen Content-Language: en-US References: <20220825215218.1606-1-demi@invisiblethingslab.com> Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Ard Biesheuvel , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko From: Jan Beulich To: Demi Marie Obenour In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 873354b4-52c2-4fec-83eb-08da8fd3fdd0 X-MS-TrafficTypeDiagnostic: AM6PR04MB5957:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: af4XOKthSQacd31g1ISu8sMiz16UWmsIxi2H3DPVJZdS0Loo9xECuyUTLITeow2MeOp468FWWcZ9MrjuliayNlGLOYOK5zLvdHXvE61ZmS4zXhbchBI/RMmLCMf9J0CiLyZ8h4GNJLGuAG3tRuc894DwQ9RZgurMpxjWKwkzwdPcs69E96nyum12NjCQxEyeCAhNDGLonv4JJVkJARZUCiHSsyPgeIADZP190uWRAmH6QivDQeJ2VeCS1vGQZ+2aglCEtC59vKbP7PRbGfXhMu9qF9V4UBHViolNvLL21r+zaPwHDqGn/q7+1Ll4JfzA70eCZRsRLkgbe+E3Lklwq6TRsaONZJqZPEggelFlplBPPytODkOOam600Kk9uoysThyBurCIOd8DM979qDtBUNI6+rn/knjbTcAa4L8rtMSGsF4pWvLeDyF0N9YR5bmxHkN8rlgG0IaPRma4YfjVF0X8oFhzV72jKJyT1soMjEIPFWg9TWPoH2Aib8moGfPKacL6JWuJvaAVeIrVqXFI6HgIhJ3hYUC4n+P3MrrsVBUJia4WL6oePQo+bIml47oeFmnDSpahhxXXqtkA3kSSQPh0YVGztvO/ebIUKgYtJxIrfWZT0twiRUKfaUnXoc0k8aHQ7hq8el3EplY40ko6eguPn2zYd4aU014TTmOFkpTMubf7hSzUIzH4Cnid2SG5IWqpYTvaoag6jronXQcVBBjIjnrNVusucl/paTRlBA8x7jqXQtoD9Hi2oobkpgvt+H3/1CUSDY+94GXHThP6LBguZmvf9yVxowipoGhmHG4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(396003)(39860400002)(136003)(346002)(36756003)(38100700002)(186003)(2616005)(4326008)(8676002)(66476007)(66556008)(478600001)(66946007)(6506007)(83380400001)(31686004)(41300700001)(6666004)(6486002)(53546011)(6512007)(26005)(31696002)(86362001)(5660300002)(8936002)(54906003)(6916009)(2906002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yzhpc2d2K04zMDYyZDUrZ0JZTXFFWFlzL1c4Um5sNHpvQjdvSmhHVk5KRmEz?= =?utf-8?B?cHN3MmxSQTVSbnI0elp4R0U4cEhBT2NnanA5eEpQSzhSOFd5OGNoRFVEUGZP?= =?utf-8?B?eXlpMFV4WlBXcnhnU2ZCRndxMkl5RWtoOGR5YUVuUjZpYzlnUkhTL1VhZVhU?= =?utf-8?B?dTJFTmhabnJNL1lxNFF4eUFqVURNSzFkY3lia1hnQ0JWdUFEbXJFTnRuQi8r?= =?utf-8?B?M082bUNxWmtwdUdaOExSR1loZ29rVWlmL2tmTVY2ck9NTXJpK3FmR3k1UmNI?= =?utf-8?B?VW13Wm5rY3FkNjM0T3VudFhvUkJQcDNUcHpnbDFsTXQwM2I3dk1hcGRYT2Vj?= =?utf-8?B?dFVmdVZwZWFVSHdKbzJ3ajg3UWtUVHF6Z0x6K3BSdVF1Y040bXE1LzVnQ0dV?= =?utf-8?B?QjNVSG1HRmhBMk8vQm1vNTI5bXpnTGVJMTl4eWdKenppTGV5N1h2cjZkUFFO?= =?utf-8?B?R3BITzNlemdOcXp6OEQ3ZzYyQy9wQjdFTHFmdGx4MVM0WFhoNUhydGtPcVRV?= =?utf-8?B?RnhQYUJnTnA3QVNZMi9HbjdhNTJWNktYOGJURzFlRE1YTVlpRnVKc05ISGJB?= =?utf-8?B?VDl1MCt5c09qYlpuREZyZXVieVNrNlVjOGpzS1hTU1g4eE11S3Jmb3ZMMGRN?= =?utf-8?B?ZG5peitESEdzdU5rY084Z1NzOVR4d2JBQVRzbzJqdlRPSDJYYWJvTDdXRnJ1?= =?utf-8?B?cWZCa0ZPeVFINXk3S0srK3BnUVRVS2Q4YldEODJpMGlPa3VpS0Q4VTNPcjVL?= =?utf-8?B?VG9NRko5RDRBTVJCaHVESWFRczlzUGhua0wzYm9yazdsMXlYd1ZRS2Z0Uy9s?= =?utf-8?B?blJsOWVEd3hNaEp4L1pNOVMyaWYwcExRbE45ZHhlczB0L2VPclV3NElQVjJL?= =?utf-8?B?NjQ2SncrYUtOL3BTejVudndETytyS09oc090Rkk3SHkxd1c5QWptZFJLK3JI?= =?utf-8?B?QlcxN1lmZnN5dU1ERk16SDV1Y1hqa2FnQXFFVmc2SHgzWGRIL3JRZmcrNTBT?= =?utf-8?B?aFJPV2g4ZTF3bzNiUitFZkI5Y3lkZVVNZDZ0WWdmdFhrSk9UZnRza0ZPbEJz?= =?utf-8?B?akExWUVNUm1jK2U0VXFIaUJhWDBaYzRGTFh4cnFiMjN0YWI3ZmMzYVhjRlov?= =?utf-8?B?RzUzTEFNRFM5R3QvRVNWYUtHREFidmMvQW43OEdNR1NoUW1kcmN2Yldsck8y?= =?utf-8?B?eFNzUVozbGxMZHhmWVJoSlNybGhkZWVFbndBdjU5bEFmcnVJZDRtNGxXVmhy?= =?utf-8?B?MUY3L0ZUTmMzY0xTVlZ4dHJLVlFpUEQ0SjdONWh1NzZIOHZMN0lRWC9PTDJG?= =?utf-8?B?aGx2RHVLQ2Q3VnNEMk5kR1ZlNVFBREJjN3lrVmdwazM5WTRmd1plQjI1NG5s?= =?utf-8?B?Q1MyTFFaQnNsUWJXdjFub3RlTlBEaUZkSlV3Y3BhSm1zejBFcXJYd2hlWU5S?= =?utf-8?B?Sm8vS0VreWxxT2xyQmpPQkFyOG5QcUtHSDJRKzg1WVl0dXZPU2xadjVzYnoy?= =?utf-8?B?K2d6MFoxRURDanRzSmR5YXZTWFk5b2RRUTRYU3JKZXVKOXEzbThmRXdxMXBY?= =?utf-8?B?d1JWREJjaFBkekw2R0xaU0JFb2JBN0F3Y1JjZURRVWdrNFVzbnp0L05zaFFl?= =?utf-8?B?SjNUNUpzS3RCd1hyYVhpYzYvQWtYT2crcFBGc1kvaWJmTDJrMjZrTXAweHFn?= =?utf-8?B?Y3lGNjIydHl2ME1pcTEwaUFEd3U2NlY3VGhhZjZ6TVhCOHRiY1NyZGx1R1FP?= =?utf-8?B?bThsUzNkRktOQUpKd1pleTRzbEdENFJRMXV2Y2szd2ZBUHBFMWE3UDZrNGw5?= =?utf-8?B?ZWhSd2xLWnJvNHZlRldURi9zeDI5bE9NL2pheDBwYWYyTU9EbGRHUk41NXda?= =?utf-8?B?ZWVWNUhzZytzYzR3ZkpYbHdWNzlqNzUrS3VFNEVuY0pIKzhNZ3VLVGh1T25x?= =?utf-8?B?YTY3Y1BXaENHbzZUbGNHUnMzRS9QYWxTQzNRbURQLzFsS0ZMZDkvLzY1Y1ln?= =?utf-8?B?eGUyN2g3cmhCYTJHR1FiTnVUYkZZUlh4Ym5ldVNTRHVMSmFjNHZzRk05WHA1?= =?utf-8?B?R2x3SjhXMFh5OEtKcHc3MENrSjljSWFRaWNxdlNMcWozQUlKekxkR2VtWVZS?= =?utf-8?Q?XhyRsPqwArEtAWnsw509J8B58?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 873354b4-52c2-4fec-83eb-08da8fd3fdd0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:49:48.6925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gET1Fn7mGvp0kv5bOWWgOI7f/Eg22s1VejON6ag5JlNgleCb01PDAcjGZZ/pR8gvfRl/lQHzqY/kbKdClIiZcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5957 On 26.08.2022 20:01, Demi Marie Obenour wrote: > On Fri, Aug 26, 2022 at 09:53:29AM +0200, Jan Beulich wrote: >> On 25.08.2022 23:52, Demi Marie Obenour wrote: >>> @@ -40,6 +41,38 @@ >>> >>> #define efi_data(op) (op.u.efi_runtime_call) >>> >>> +static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, >>> + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); >>> + >>> +bool xen_efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *md) >>> +{ >>> + struct xen_platform_op op = { >>> + .cmd = XENPF_firmware_info, >>> + .u.firmware_info = { >>> + .type = XEN_FW_EFI_INFO, >>> + .index = XEN_FW_EFI_MEM_INFO, >>> + .u.efi_info.mem.addr = phys_addr, >>> + .u.efi_info.mem.size = ((u64)-1ULL) - phys_addr, >>> + } >>> + }; >>> + union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info; >>> + int rc; >>> + >>> + memset(md, 0, sizeof(*md)); /* initialize md even on failure */ >>> + rc = HYPERVISOR_platform_op(&op); >>> + if (rc) { >>> + pr_warn("Could not obtain information on address %llu from Xen: " >>> + "error %d\n", phys_addr, rc); >>> + return false; >>> + } >>> + >>> + md->attribute = info->mem.attr; >>> + md->type = info->mem.type; >>> + md->num_pages = info->mem.size >> XEN_PAGE_SHIFT; >>> + md->phys_addr = info->mem.addr; >> >> As indicated in reply to your patch changing XEN_FW_EFI_MEM_INFO in >> the hypervisor: While this may fit the ESRT purpose, the address you >> return here is not necessarily the start of the region, and hence >> this function is not a general Xen replacement for the non-Xen >> function. Therefore I think it also shouldn't give the impression of >> doing so. > > Is this just a matter of renaming the function? Besides renaming the function perhaps it also shouldn't give the impression of being generally usable. I would expect it to be a static helper somewhere, or even be expanded inline. > Is it possible to > implement the original function with the current hypervisor? Yes, but doing so would be ugly: You'd need to "bisect" your way to the start of the region. As an aside (I think I did point this out before): Can you please adjust the way your mail program sends mails? When I respond to your mail (using Thunderbird), I find all the people previously on Cc on the To: list, while your address is lost. As indicated I believe this is a result of the Mail-Followup-To: tag your reply came with (and I further think that TB's treatment of that tag is a reasonable one, albeit perhaps there are other reasonable treatments as well; I am not aware of this tag having any formally specified treatment). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399409.640568 (Exim 4.92) (envelope-from ) id 1oVSRb-0002Rh-Ea; Tue, 06 Sep 2022 06:52:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399409.640568; Tue, 06 Sep 2022 06:52:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSRb-0002Ra-Bs; Tue, 06 Sep 2022 06:52:23 +0000 Received: by outflank-mailman (input) for mailman id 399409; Tue, 06 Sep 2022 06:52:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSRZ-0002RS-ON for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:52:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 74171a60-2db0-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 08:52:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5957.eurprd04.prod.outlook.com (2603:10a6:20b:9e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 06:52:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 06:52:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74171a60-2db0-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdmDYn0PyVMUeuEMq6Rvkw5GKAIXQ93uWZK9sc9/oN2bjmoCHi5/rC0qdc61b2nC8pBcywrqDE1NxBMH0nW/1fxs1xAUDN/2Fv5/IKiKdv6BksEX4eSPx1V8HJVipQSvNkHJO31VyRD9c2FVfADd2MmJZFxaRCkwE0d1WUahWLi58dhKWeVsZTYULlCPVjaP7NlxQTk+8ESsm+hWpcACvgZY2P8SihAJWMCDgjfx6leweayua1uFT9LUdSiMs+HxT6JddJDo/wUYKF3euws7FxMRXCbNyHAnOqhziDwtdO/OnPBdl7N4sft4Lbs+8NfaPQmI+V6BssQ3D1mrLLScEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytRg+7SBo4U3Tgcagqli6pR6ip8yI/MJujbsIYjbjEA=; b=m2g4oBWcx0izBJ9UoRQe4Vdgl29Zwkqs4qTN3D8qQEkKBYWNmmghnJomEcAtZ8YX3TlhRwAtpx1TvC6TRhoUuLUmBvgkfweac9Iurjnyf79PKHSmU9p8m6Ig9hG18WmmkOPZdPV17M8vfvHJI2OgEn/xjABSe621jQKAcd0VVK7/8HHFVrgM34fdoyvEFnjx7bweC0HbAutGV5RfkliYs2DYooZ0THZoHkFju++luLrDJG8m7n/n8Akb6gR63Y6DVyZCVoDmSkhRmh5aqsH82UpMgydQu+fP7S2HUSGOOmOIOwn7aC2rNLJur+h70C9/b6SaQFZFVk5RA+oZKHDBEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ytRg+7SBo4U3Tgcagqli6pR6ip8yI/MJujbsIYjbjEA=; b=qDwJGjBE0uPmLUlQV1bdop8kksaXEonAhEB8AehY7Fp0VXJe1azwqp1aOx3Ul5fRYkH+Rz9ZR70XRzTqaJ43BWzN3eDz5dYRiYXN7KRdVBGfQKDUDglpAQEsl6364+QNBb8AqB/omVgCoPd2Iukg/UEyTGMFWiKno8okCS2NogChaur4Gpfpn+4YqYPEObSliAqPoOneqd2DBKJlPlpOn17OJBAlbH9Jm3SOHb4ScV8r6gRBlAm8c9bv2Gh3tQ4jvC17XKu2wgPsHMOya8PuV/ov0z/Ydh5taOvPhHG15Si3k37suULmXVU1hLLfB4s7sDuGTcAeapEg4B7yBZkbQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9cefce23-a903-9ff0-2690-ca973432cb82@suse.com> Date: Tue, 6 Sep 2022 08:52:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 9/9] drivers/char: fix handling cable re-plug in XHCI console driver Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <6ab5ac63-becb-3635-20f5-dd0f03188003@citrix.com> From: Jan Beulich In-Reply-To: <6ab5ac63-becb-3635-20f5-dd0f03188003@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P191CA0075.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c501e395-4676-471c-fc4b-08da8fd457b7 X-MS-TrafficTypeDiagnostic: AM6PR04MB5957:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i/rfHAtGQm1XxTiITPu9BfbfqJfoJN9YKVVFwjbNUlOZOYHIREx3NaZzMlgirbPlBQryz1BkzuWLIPYu1xbRrK3G8CQIZWY1ksIxkh5lH3IR5VegEQzEGooQlxm2OiadTvFt2reSrjpbtnKoF/SbLjRpR90QmRxN29FzIoFBkGu1f7xOeKVsgPKqBbOOOopl/LBRNfPogv6mqe2anJfPRRt5YC9orj6fb63bIkItiY+eA43O4WbRIP8rYRjNYGEEWfi79ODPncLCn2NpBlaHV28f3CgBF540k5xQsEwhmrkgFaPxpm5CzwCpu1qrIsyqd0ttV8dDWP2+rz7oDhPhLE19/GkXN7AAscYrYVINdi6bvHEZQaHE18LTPm2Fv7acb/rDP3xel3F+FVkcUBnkPjL9kCCebjEjwUmwSGKna4rOD9+Zlolr0a6lVY+QXXrGzdFOWjG1vw5HHYaRsqJ4q9e4UUlUS5+UUhhaPv1MDXmlPkVA5lp2jYHkujUvak8lMuXRqvJloIIKQrKIFDMSveRyeb5GeesOkcYcbQkVuDGbvqLYot5KCRqkfZ+VniYrOASk1nPJv01S0B7cqavFrhxmr+CtJnyw8F5iTaOQIyKNWEg4uiPKXLGAtDRtIRpPYgG9fCrjM2GrWbdNdVE1YWmzclTllv6R9ORlq+pKq5zuwrrdUFyYNnJu+aX0f7crX4XgYYor52QHqZO7ia8dj4sCdn+/vDMe5uBKA/W4UJP7V2YS9r2LSlkwMkuAH0fdEqg/JE9+O5OdC7amgVh3m/o5mwDeLsH7oiddbx6SBTY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(396003)(39860400002)(136003)(346002)(36756003)(38100700002)(186003)(2616005)(4326008)(8676002)(66476007)(66556008)(478600001)(66946007)(6506007)(83380400001)(31686004)(41300700001)(6666004)(6486002)(53546011)(6512007)(26005)(31696002)(86362001)(5660300002)(8936002)(54906003)(6916009)(2906002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDRGUXZzOCtmWnQzMmpYNjU4RTJxS1F2aUJtcjFGSjlweUc5TDZtVm1JY1U2?= =?utf-8?B?OGI0ZzhXVkxsWXZCSGZrTEZLNEZ3R3Bua0wyWW1RcFJ3dVpZblAra1dCSkpj?= =?utf-8?B?cUozdnJtZzJHZXNhS1dzRUVHelB1SENwZi9lcE1JMkgwY00raUYwblpJRGph?= =?utf-8?B?ZWJPSWhwWjZBdUhwaE5GTCt3WFRFT0RRSkZYZmJ2WGg3WjdORkVtSDAwL3Fu?= =?utf-8?B?d1doeFdiWXZHTnZMTUpjT2k2YklXMzdrSkIzRmo3TnBHTmI1MDUxYjJjZ1Yy?= =?utf-8?B?R3h0U3orNGU4SVU1ZERmODVIRXkwTmMvVmM0dXZnNEI2eVFwbEVqNHRxVjV5?= =?utf-8?B?U3hBT3Y2OXdrUVRiNmpuSzdsRE5YWVp5UHI1Z0VUYk9vMnVzU1JWQzlzME84?= =?utf-8?B?ZmxuTmQ5aW9LM1Nja2l3TWtwa0RhdXluWGNCRU9rOWFiNnJySnVBcnBRNmNW?= =?utf-8?B?VXE5SnhJSWZVU1ErV1BodjhoNzhBYnZVV2ZJcUhuYVdEd1l2WkplYndtTGVJ?= =?utf-8?B?YnByS3d2RDk1NlZhZHZMVzlnbjRoWkJkZzhMYk9TS0ZUZFI1YytrYTBrU0NZ?= =?utf-8?B?dUI1ODJsV1YvNjJRaEVEaG5FMmVFM04zRThqdG51b3A4YSt2OFlqbFpCS2Zt?= =?utf-8?B?bk5aQTRLOVdBa1N6L2hlcnUzUktleUVueVdrZnhYaFlEcmZwdWZRdkhPdjNC?= =?utf-8?B?VUY5bXVQaXNKbG9scFlUdWNvZm45RXZ4blpMTTR4LzZiMUNSNnNlWXNodzAv?= =?utf-8?B?c3U1em92N2llZkhadlh0Q3RrVnY4RzB6UXNXOHRwOG5YdTZqRnRqU0Viaytk?= =?utf-8?B?MDE4VWYreWFKY3JWTWpXTEVRaUY5ajFRTlU2YTB0ZGhodmNpcldrd0JtdEhR?= =?utf-8?B?d3lwcUNRTDFlTWhuNEtyb1R5dGhNd04zVTFVRUJGNHlGeDFqRHdreDJmUDBh?= =?utf-8?B?ZUNOYXliMy9hUlVEOXYwY3RHK3VFdmFxNXJucGRkT3lZL3JhNXhHMmN3amY1?= =?utf-8?B?RExDK3BUZENKdGwrNk9yZG16MU1mejJYcDdtWmExaFBGMm1KbE1ocFBrZHVa?= =?utf-8?B?aTRMNm5sVWJRZ0l1RTFtYjNaOUJ0ZDhqcUI0REVTOWQyNG81OFg5b3Z0VXQr?= =?utf-8?B?b2dtZEdRN1M0V25XOHFhUjBaV1NBMDdEaC93bmNwWENPS1d2MDNxU0pZOTl5?= =?utf-8?B?OS9PS1ZXS2o5Mms1Y2FjV3psZWIreDJ0eW5TSGVJOTA5MG9MQ1VzWHl5TEtM?= =?utf-8?B?U0ZtVjFhSFJRckVEWWE2ZHJ3MmphUmcxSjYwSkd4STZyZ3B6TVdQR0dyTjdo?= =?utf-8?B?NlhkRkJVSWMyRXVIdVcvTFl4ak96eEdJMy9uVy9XMHNFc0pjSXVjdkJTVm5Z?= =?utf-8?B?VUVLL2dndE43RHNEYXA5bjdUNlJYRnRPcmxDb3RsZHNTWWR2U1VERHVkZ1Nn?= =?utf-8?B?MkwyMGYraFpnR2lHWTltUUNsVzdRYklIV0dFdWs3N0owakFidHQ4c0FpVHZm?= =?utf-8?B?ZFFVSGJKYktEOVhEZU1Ha3pwb3JZSGJQdFREdjMvKy9haTBORm01Tlc3K05j?= =?utf-8?B?SXJIVHA3RmJWbHNnOHp0OEdjUkNlejFpaUgvSGJXbXZGMmEva29yOEtYUFdU?= =?utf-8?B?VGdNUlpBLzVrUXdVQk5OK0N2TFNVc0p5czVxN0RIbmMyOXhXS1NVQXJjeVBt?= =?utf-8?B?KzlGTTJWYlVUS1dCSkJueFZZQ3VXMUthMjZEbUdzOFM2MHNVZisxNk9RdjNB?= =?utf-8?B?ZEpOMXpRaGp0Yk80YjZTSjhkT003NHFGT2VQbkpzOXNrQnFlcE1CZnVZWEt2?= =?utf-8?B?UFNMUnJMOENpdVlRL0ZyQkVsOGVpWWc2SmVybHQ3UW91b2VDLzZkZG1QZUlW?= =?utf-8?B?UzdVQUplK01XT0ZySjI5Nk9DU3A1RUNJNmRvVjk5Z2s3eDNYbm1MTjYzUHFG?= =?utf-8?B?ZVY5RFgxQVpJN1llYW9xblptaDY3VDl1RGpHRDVocHRlZzRYMVdqcnpxWldF?= =?utf-8?B?Q0U0T2ZUb3MybGd0OWxWWnFQVHNTRjgzV2hFSTduZlFSM0lCTmx3MkZiSUU1?= =?utf-8?B?L210U3laTExzYkJYNXNxNWpPR1kwS2p3VUYvSlFibTExZG1TYmVsQ1FjRkpy?= =?utf-8?Q?tWhVX4TMPx7qb64/mLc1w2Jcd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c501e395-4676-471c-fc4b-08da8fd457b7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:52:19.5110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wo0RikG85/4m/TxHckS0AIGgkYCmXJnkrns7qYch4AttzgvBltmlgnPZg88NyerGkDGOBOgV3CGtfLbjRIt9ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5957 On 26.08.2022 17:44, Andrew Cooper wrote: > On 26/08/2022 15:50, Jan Beulich wrote: >> On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote: >>> @@ -1023,6 +1032,8 @@ static bool dbc_ensure_running(struct dbc *dbc) >>> writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); >>> writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); >>> wmb(); >>> + dbc_ring_doorbell(dbc, dbc->dbc_iring.db); >>> + dbc_ring_doorbell(dbc, dbc->dbc_oring.db); >>> } >> You retain the wmb() here, but ... >> >>> @@ -1066,8 +1073,7 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, >>> } >>> } >>> >>> - wmb(); >>> - writel(db, ®->db); >>> + dbc_ring_doorbell(dbc, trb->db); >>> } >> ... you drop it here. Why the difference? > > As a tangent, every single barrier in this file is buggy.  Should be > smp_*() variants, not mandatory variants. > > All (interesting) data is in plain WB cached memory, and the few BAR > registers which are configured have a UC mapping which orders properly > WRT other writes on x86. But such drivers shouldn't be x86-specific when it comes to their use of barriers. For this reason I specifically did not complain about any of the barrier uses throughout the series (with the further thinking of "better one too many than one too few"). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:54:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:54:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399419.640578 (Exim 4.92) (envelope-from ) id 1oVSTi-00037b-Uc; Tue, 06 Sep 2022 06:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399419.640578; Tue, 06 Sep 2022 06:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSTi-00037U-RC; Tue, 06 Sep 2022 06:54:34 +0000 Received: by outflank-mailman (input) for mailman id 399419; Tue, 06 Sep 2022 06:54:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSTh-00037M-EE for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:54:33 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140087.outbound.protection.outlook.com [40.107.14.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2cb046a-2db0-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 08:54:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4312.eurprd04.prod.outlook.com (2603:10a6:209:49::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 06:54:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 06:54:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2cb046a-2db0-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WUC8Ew8uUcI10Uy3H+sCKmlIb/1oQx8uFR5MIQVEv0SB2PpjnQ77/6mnktDo5OPZrs4qrQ9G7vVwYjFzV+l5OfI59/f03sS9upV2gjzWtbjfR6sl4YZN3ESyeFF6JT8eRvn/+EgoUfsOBUGA+ZcGPdAmXmegVzq93q66BbE/yO1UYWQX60dLWbtanC2/43bjny3PWuIYN3FTqmHTrgXzEmLan6Wivgz0oyKSdUxP2wlfyYZHH781oA4ichPNZe4p+kgf34SvL+MQ9fQlZQml8N2ENC/nCEa/X/6So2LN63zB/HTPhoU+yQVqUOq/2f+qoywR8eSUUQKSVxbW2+kbYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkg1l0K+uoKu8O7X9t9Eq0ec3cB6nljQKzS8X0a/luY=; b=US7+HX0MKUgedyWLWqgynmub4QQOGZfnMTFK+EFMES4+MrsrQgoPEg3QN3ODiMmrm/lbc9nSWpfwbP1kA/lJedpkvBxqby7ra1yCeQje8K6UsNQmrzfRz1WP8ZD8btXPVOAEeWaBr2rEP42S/eLCKEWey9eUHaJtL/SPE+1C0UZngN9pZpJ7jUj5VBRpp0SzoB78w2Q3okqaegIA8vlHoE0LjaBfkm/otu1E76FkQml6DmxIANxBWuj/HyGjq/yLc1d52qyNO4IBJZr9EkVKMxC7WmY/Yo4MOMH8gNa0jLSSu1GVpkwHwW2SPHJWUppOx/AL9rULByR/iWfRGobisg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkg1l0K+uoKu8O7X9t9Eq0ec3cB6nljQKzS8X0a/luY=; b=bNOVC98iwMxPDi/ACU+x9TZYIH26LBVkWTpB0WfEho7UeQTC3qu81aqhfXPNsYnNZAzn9+Yy3Ju3cVTsm8O3pe3kS2RdVK2Y/lr/aPJYBv87xa26iQAbvEr8E1S7mYeGWs2hsrW/Mpb0AvKb1xGc6v3D3keA6lrrdB944woXQHhZTdS9m2aa4Qi19o0a17cKL22Pk5Eqej2T7GCsv+pPBpnAVLIo6+LcZphOalyx94jDWSCtWNotNu5l8cGzA5NLy0dbxvDyY/OXiX1rfG1SytPQ/Vs5olsGOFXJb+y2bo064kDcXrRp2P6U6ZpoAXcFPs2s9xhqljFjNgJVsohe3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 08:54:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Make XEN_FW_EFI_MEM_INFO easier to use Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Xen developer discussion References: <20220824210452.3089-1-demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 520d9d21-d482-4312-e617-08da8fd4a594 X-MS-TrafficTypeDiagnostic: AM6PR04MB4312:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lasPD4orHryHnJebJuc5tzZW2hg1+goPFhFaB1o1FwoagDYsVTc7mwfvlGc0jvKTJZjwjRzwBF01c+lxkJsuP7qZtEQMYtZZhXeZHt/KQFzasVwVl4YLH8fWIFGBtrojpyYGByy3IYpr8cnl9CDZ9hbLEKQusV+XA3yPZ/raZTfH4wBnxHLjBwY5oOkYpKR2nzKGRSYpX2DvcyZBFbGy6R5PKs8kYH4IW+ey0LwB/7xmEa+UREp3RC7F4UsyhtnFK/7/fyoQn8M5d8whyboQQzCSVMuJwV/kUN0DhR58dQfvG6bp9UL8EUSsPqp+OyZEWBCgMpdghlXWnguz2t8sTAmD/kovRaAlpS9zKhhQj4CBwJM21fbQqnVYWdnRn9PNURBRiD5jFPWlF0o9C6D7SfMwtjBH4piITcf32Le16aV2cynYzPmpaqBBh5tj3F2/MHIDlf3G3haS73ZrAHFnCn2TbdpxAj2z+U24wi+eYnBN3l1hE8xnjSrHqEGqUX2aXsZFJ2KsVzXDk5eKqXegq0X6Yp4atERkcZ2bKAk2tweWXDfQPcpfKgb4tyGkiwToD4p60k2tTKhrUKiRv/6TW23Hxo6bfpXGU0SQ5bvyo1CDO9HyVCTiH+CLwBDfOiTFA7/s/HyhVq3dBXQmIYQBbYekFLWBD/cD3UTkCrfMMpTvOWtVZr/E30pzQC5E4EIzuQEv8tgBzy8OpD7/ubLe5j3D5yukHw8G+FY7aG37jC2FD1XMJbR5bFtc3l319u1Bg0BYAMjCTr6wlxIAkRiSVW4WgajtkU0fUBZ7JuIZAws= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(366004)(346002)(396003)(376002)(6506007)(5660300002)(36756003)(31686004)(6486002)(2906002)(8936002)(41300700001)(2616005)(186003)(6512007)(53546011)(26005)(31696002)(4326008)(86362001)(66476007)(66556008)(38100700002)(66946007)(478600001)(54906003)(8676002)(6916009)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVp4WGVMckxwYUkvUEtYTitaR3FhYUlKMnZ0OGo4UWJ2OXczdjd4WFRNeFBN?= =?utf-8?B?WlRDVk1zVTIxVmhKMU04emM4anRicXowRU5qU2xROVVIWmVyY1pvRGkwa2Jj?= =?utf-8?B?TGViU0dQQjUrQUdOSXlaMVovRHpZOUhPTG1kRGJPUmxSeWt2YzJYS0dHK21n?= =?utf-8?B?Q05yb0VLVGpBYVpqNTFCQWkzVDNLZmExOWVLZlF4MjJkcVlKdzl2cnNJZ2Nm?= =?utf-8?B?NWUwQkFaZlpHL2d6OXVza2lxMnk4QnlLMHZqZFNGUHh2MFdlay9xaHRXMm5i?= =?utf-8?B?SDJKUE44K1Q1ZEVMNXhiS3phSlZoWXg2SFpvdkQ0aWV3QTArRVJuTndpazNS?= =?utf-8?B?eGJobkZJeVgrVEdjOXBOaTJ1a3JGNmpCV0FvRGt4Q1pUZ0RPTkV5OVlnQ1Mw?= =?utf-8?B?ZXUvczUvWjk3cWQwR2xLVHZoWWhVVlBjWk9YZjNYSUhRRmh2a00zUG5hN2ZE?= =?utf-8?B?QlZqQ3BmajFaTFZXQUZQTFhEMXhBN2VPcTREaVNaVEtrbjdUSGxMeEsrL1lY?= =?utf-8?B?cHV2eFFPMnhPV25NK1FBYks3dnVqNWl3L1d0RmRSN2RWN0dkR240U0dHdVBK?= =?utf-8?B?cHpwaGlHWGtLRXQ0d1V1dDVScVBFZVZYVnJOdFV2Qm9Eb09MMEpNZXF0RmNy?= =?utf-8?B?RmEyYzhzeUxSTVVhamwzdGpWdkFIbnlrWXR5MEU3amx4WnE3bHNtVm8yUUI0?= =?utf-8?B?bnZ0RGdhMWl5RzUzb2lUN1BFcGIwR3N0SlJhQVpRUnNXd01WWHV0VWJMcnlj?= =?utf-8?B?MGRPdnRhUXgrYmVjbFh1c2RnVkR1dHVlS3lOOUh6cnREOGJmaWl4VVhUVGN3?= =?utf-8?B?V0M5MjRWNCsyaUpGVkpFckszbXJHWDdURW1rdWZrQm1VYkxpOUlxR1cydUVG?= =?utf-8?B?VVJJUWhZai9DZHQ2M3RwaXYrRmpXVk53M1JyYjM2dkg0ZjFWbDdEZG9LUHNH?= =?utf-8?B?akJLMjJ0S1V5bU1yckcrdkFONFcwOWFmNlhIbTJMM3JCMk1XSFlZOFYva3li?= =?utf-8?B?RUc3VGlNM1pBeDF3YUhjR0UwMmF6YTVhSVBFQ09CZ3ZxbCtwODFqOFg5WEs2?= =?utf-8?B?Q1g1dDlFckJReXNBbVR4WC9XRnhpelMrWG95MHZEdzA5S3pGWlk1cjcvUExx?= =?utf-8?B?VVB1TEdvVlBFOTZxN3hNOEtPTzRUYk15aExObGg5cnE3L2dZdTlLQUhpTWZ1?= =?utf-8?B?VmxVMUMvbkRkVmxxSkh1QUFDYmdqUGFReFpaTFBWOE9Zd0pGNGNzc0VvVUxW?= =?utf-8?B?WFU3SUkxNUl2alpQQVNmVUhib0RlYUtiV2FqZnRLMmw2MjVqajIyWndYdHpn?= =?utf-8?B?RWRzMFhlUkVzTERHTWoyNERiZHEzb1QyNXpVY3RqM0lScTFpb3ZVZGtEcndR?= =?utf-8?B?YXQySGFiT2ZkSXFiNVVzSzBVcklnVEI0Q1pmbE9xRkZnY21TRGZNcVloQVM1?= =?utf-8?B?OUFUQ0tiVXdUcE01aWg2T21QS0xkVzBWSVZUVnVXb0pNck1melp3MUs3YU9q?= =?utf-8?B?RE1UWmNmeFpTcnB5MnBHVlhjUG1tTXlwZFgxdjlUeXNKTjlrdUtGb1F1S1Vn?= =?utf-8?B?NTVyL2RZNWFvSXNoa2I1UU9SQktUUTdUcFl2OFc1MXM4VnExV1ZFOEhUdnFm?= =?utf-8?B?dXdIcUFodnIvYXhFelpNL21XT2dGL25BbEJGcy9zZjkydmc0blVpTWU2dnA0?= =?utf-8?B?WDV5cGJ6U2I0cUs0K0ZENnhGUzN6RjdOOFlWREk1WlRNNkZiNS9YeStmODBI?= =?utf-8?B?b3hEcmdBdzBqQXA4SElZZ1dTMGJKSjZnUnR2T1N6Z0NmVWlVZGIzQUxYZVhl?= =?utf-8?B?OEh4em1EYXlNeEJXcjNZOUxzWTBRMzdvUm4xRjNHbWdOTFUxRnRHZ05aRzYv?= =?utf-8?B?TENqSmZvcUNzNE5nMkQrTzZIVG43SGgxVXBPbFd2YWs5LzcxUVBmYUF3cmsy?= =?utf-8?B?V0VsY1VhdGg4YzRvTGYveTI3T1I4U0l0dmxYSGlqMW5sZ1pQWno1Y01YeGc4?= =?utf-8?B?VXVTc3lYN1Exd0FJeGhSelNCOCtTb3RLK0pwK3R2Tzd3NGRLdDN0VlMvTHRS?= =?utf-8?B?VWlIZ09pZ290SjlLV3NZQ29iRkdhNXFuT1NWR3pTcHFpaTBhbEFBc1F2K1ZT?= =?utf-8?Q?TvGJKT7llJoR5+1KmQsoGWqWk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 520d9d21-d482-4312-e617-08da8fd4a594 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:54:30.0965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zH4xzuFONIPuxJO5Zmek0/1X/BL7RvEWHKUd+rK3PAX8yj8HlSnwH/MxSDchpmumpbsFnto+aUw45AkX78rjmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4312 On 26.08.2022 20:15, Demi Marie Obenour wrote: > On Fri, Aug 26, 2022 at 09:18:50AM +0200, Jan Beulich wrote: >> On 25.08.2022 22:36, Demi Marie Obenour wrote: >>> On Thu, Aug 25, 2022 at 09:59:56AM +0200, Jan Beulich wrote: >>>> On 24.08.2022 23:04, Demi Marie Obenour wrote: >>>>> Fix both of these problems by unconditionally setting the memory region >>>>> size >>>> >>>> If you were to report a larger ending address, why would you not also >>>> report a smaller starting address? >>>> >>>> But before you go that route - I don't think we can change the API >>>> now that it has been in use this way for many years. If a "give me >>>> the full enclosing range" variant is wanted, it will need to be >>>> fully separate. >>> >>> Does anyone use this API? >> >> The XenoLinux forward port of ours did, and upstream Linux still wrongly >> doesn't. The two functions efi_mem_type() and efi_mem_attributes() still >> wrongly fail there when running on Xen. >> >> But how does this matter? Even if we were unaware of any users of the API, >> we can't know there are none. >> >> As an aside: Something's odd with your reply. When I opened the window to >> write this reply, Marek and the list were put into To: (instead of Cc:) >> and you were dropped altogether. I can only guess that this is what >> Thunderbird made of the Mail-Followup-To: tag which your mail has. > > Probably? Mutt generated the header because I had (incorrectly) > told it that I am subscribed to xen-devel. Is it best to leave this > header unset? Probably, seeing that it results in misguidance of at least on commonly used (I believe) frontend. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 06:58:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 06:58:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399425.640590 (Exim 4.92) (envelope-from ) id 1oVSX3-0003jL-Dv; Tue, 06 Sep 2022 06:58:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399425.640590; Tue, 06 Sep 2022 06:58:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSX3-0003jE-BG; Tue, 06 Sep 2022 06:58:01 +0000 Received: by outflank-mailman (input) for mailman id 399425; Tue, 06 Sep 2022 06:58:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSX1-0003j8-WD for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 06:58:00 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c410e49-2db1-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 08:57:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4312.eurprd04.prod.outlook.com (2603:10a6:209:49::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 06:57:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 06:57:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c410e49-2db1-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KwnZB3AOwDTA6J5lXpyf7UN7ScSBAdoSZVCC9ajB9LQm30jHCPH5crkKBgGW4tUnHtq7AVAZqI8v6lzlJYaWfz6lgfuCwLF301xEAuwp/VzG+hL3VSX5U26Z2jrKBM9Hvsq5hp1FnOPEjCxb8xWQzq/BAc2dsf6GjpPYBY2JiLA0qg5jqDCl29meEMneG8EwMk6x09qwRz8AGo2/R/+peaAVSBjrvXxVXL1nSvCmMQHqaD0XcPhl8yIHyjiQaJTAqv8Tf9FLFQT5ue5YkaIYEdhnQgcWpbpYorM8yUI/9TkoxATjfL4THd+h6VcbvLFeu5w0k3+vKJQ9iagYQCP+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jG0zk3SlbjRhX+881sK3vMg9u6tDIRC6tb39swUTrwk=; b=m6RJ7MLAskp+BK/lKwVewGOZysiuUI4mHNusmax7UYLu0ezsRssNOADdJc4/YSakDBgLv1HJL5cKEGVALBaRoD8SYWgextLf4+pWcCFdMtp3uQMdjE8jIqfx9mudVEi8MTIhEw+5DS1H+iLhC9f/OQsx3F0I87eb8wVRHExVwexk+8zFUEu5PY3aEu0GFeKvFwVYAjEjDyZQ7G/96FVpycYuiRA4Etytqj6u1EX8UiU74Ou0vRYcLSteLnQQxcfMJousJkJRh+Nh9CeHODvUP5cktGpV0x3mDnkoSqktoIAtvyl7aYyI/LRRWtSRii9nqTwLhEQuTUHdzo94yj+DsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jG0zk3SlbjRhX+881sK3vMg9u6tDIRC6tb39swUTrwk=; b=JTitQH6k/iHNI98cFboW3MOoiYtCtdWUEywaUE3e6oEelpFSGTD5vwfVLHzG3i9TblzZsJ3zjt6BR4c0NTMTjxO8Vlj4zJ5Q3hE2u/+ssuO5BOB0kuibx58Fu0jFbUSbHJknVBQB121xnbTfGiqo02qxJ3/26v+kT1FCXYNHTx/cwDaIIqGMMtgR0MiTnZ+oRbo0JT09NycU4hym6JZwSWuIMUBuuv/akNfuPm0afJUxXtS1jNR155CN2jY9ik+Fle08uv2vtGnlW7E6Gyl0KIFqTjRe/SN8pQORw6xbfaSlPiOJ8YeoylM7GUk6SPL5dk7Gyv4+de1Tjh1c5ItYzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <94930ab0-5507-b6cf-c2e4-dcb4e5bf276d@suse.com> Date: Tue, 6 Sep 2022 08:58:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 1/9] drivers/char: separate dbgp=xhci to dbc=xhci option Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <2fc50656-24bb-414f-4f39-3b23c4c3aa0f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P193CA0057.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdafc8c9-2098-4821-8c12-08da8fd52065 X-MS-TrafficTypeDiagnostic: AM6PR04MB4312:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SnWzT8pBx94p46crcYhh8Pgto/tkwS6gUWzA82h/U0KVzs1Bw21/7kM+UTVID5NYu/QcDy6rd9TB/noChfMHXyfRlJQ4c7hLMzkq+G2mhZlhbFskZS/i7Od9q3iNcVJ3a1vYwweaXEFw5LgIr0x4SngdhRfFMiRZ0XQafzyC7GR0TV6vR73szJH/469GY8Z5obvoaZ+1C25pqFNGRirTZWi4mS/qTVQACW4p2+2aK9geyaJFcio3AKe0LKq89uLMbcmrQbnmD4vmNN/k+sl0VxyNTTDC5SbTyuxjKbY9G5Nk1fWK1DyshHWGB/vICn5Qe0V88Rneg9FHLP6BcinIDv2ijHcztroUG/GF7SfYu+J9Wj9eLeQCFZ4jbLO4biytVXK4Ri5prQdAPxkH20E5VCZO20TbC+XS563TLpozMyX1kxM/C7ZUcRuPLfKuZfc+2fNqt/oI7qAetP837iVz1+EW/jXSGhrYa/8A8mI0LosDx86X2QsL7pu8j5hcDP+WwbSbVYEGNRD1gP/Wuf7E1tkuylG5ZiIMIsFsy9zNlQeVIKYkh1UhOF1olPUtZ3Nrq2t/FPcyY0UHrRwpo0Obp7ICir4a9lRYK1V5Igdhl6OFvwhpYYW5CqstyO5e62NOJv4BXZzlZU4A2SmuM0tPBxVb4xxd21Ar+i07yuG+dbUsU6dOpkhdCy5LjJQaKkc2fPrnKSWdnL+h/SFYuB2XqB4lGDXlyWz6WLqsRwJZGGDDRYIurie5BfEgX6PC6j7+s8g0nc9GX62xNycsHXG10YOlkROFQB+DVqu4DNHL5Rk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(366004)(346002)(396003)(376002)(6666004)(6506007)(5660300002)(36756003)(31686004)(6486002)(2906002)(8936002)(41300700001)(2616005)(186003)(6512007)(53546011)(26005)(31696002)(4326008)(86362001)(66476007)(66556008)(38100700002)(66946007)(478600001)(54906003)(8676002)(6916009)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXRjVVdGdy9OSU52OUNXY1NvdktFakFmQlFISEJhaENJUzc3QzdiNmI4T0xW?= =?utf-8?B?Umczd01VSStuNTY3dTlTWDJldlUwZGRiVGhtWTY4dnNTcXJzUElvaFh5OFRj?= =?utf-8?B?VDQyOUVLN2ptRVdOcFNaT1dKM3dhbjNiREE2VXdSK2ZyYlk4Mis3ZVFlcmJD?= =?utf-8?B?elpYUHlOaFZYd3lFdWpYQ3Z4eWEzYVFFN3JmdDdEVkNoV0dmcENNOEViRGln?= =?utf-8?B?Rkxwazc0cmN4M0FnUDJPendBMGdmSVJhMERsMmRLYzY5MGhRRC9UcUQrMHpF?= =?utf-8?B?ZkpabmM0dWc2VVQ5K1hjN2xHRUVLY3hRNTU0NmlMNUd4eE4yK3k5WlF3dXJv?= =?utf-8?B?dG14RHVIZHd4aTE2SExnN2N1c3NrTk15S1RlS2RmZmNLcFF0RWF1U3VNbHVJ?= =?utf-8?B?N3U4VEZGY0hJNTNTMnM1TGRqb2F6NWZlb2pjd05ISjdNWmw5Q2tESEcvbURz?= =?utf-8?B?Q3Evdk9oMGpocy9LWGZ5NFNDalA3anY1YkNOdWhxYVJpOXV1VHpseHBIR0Vv?= =?utf-8?B?T1o0Z3d4akdvVzVUZVBVRzRsWkMzYXpKMmJsVDl4L05JejQ5MW1vcml6cFE1?= =?utf-8?B?MERraStXM0xRejNoZmtxU2xqdlJJMkZadXFiMVpWSDlDaWt2aXBnUkREQzJ6?= =?utf-8?B?Q2piVVFhSHBJNytNYU5qTFBNWEFMd2NSdEpnaDJocHQxUURHSTNOQXpmeSt4?= =?utf-8?B?UFMrNzBLeFhCWE1jS1Y4alRGbTY4ZHE2WEZ2NDhka1c2ZnlCYStsMytQSEJF?= =?utf-8?B?MEl5ZUFXbTIwL21kbmIwYkJqa3I0YTQ3OUsvbWRiZVBZZjNCT29IM0xjQ2Yv?= =?utf-8?B?RTB0SUkxSUFraHFocm1taFRKdVNqbzB1QW5rL3QxYVg4cnc4QUhTcStNYnBX?= =?utf-8?B?bGZJNjBpdXF2bUNCNlkxR0tUNkh5cU9KVVI3bkhlV1pKdnRiRDl1MkdYd3I5?= =?utf-8?B?akQ3bkl5cUlmNVpIODZSZmZQZEF2eXFMUklUVWFvT2RieDN3Tm8ybEM5bTdv?= =?utf-8?B?ZEZlSHlsZ21hYXU2TzAybGFwQ3JaTStYK0tmblFqakFJdHlrRCtZNEgxNWxM?= =?utf-8?B?L0YzRVZXR3E2SDY3U3ByYWJJcjZVNWlyTGtEUlpOdm1uYVdtWS9rd3JqSFI3?= =?utf-8?B?VWFySVJlMC9pQzVOM2F4c1Y3ek1kbVBwWWhPVnI4bTFkOC84NUd0a2ZkR0Ey?= =?utf-8?B?MjREZ0xGNmYzcjhzL2pGMEducjlucGtnWG8wak92RTNmYVlQZy9IYVhlQXJ4?= =?utf-8?B?OThZWm8wZmI2d25rVGhjdVNvdFI4ZXVXUEQ5Vlpqdy9kN2RWMzVUckhSRFVJ?= =?utf-8?B?RXZ0K2xxS0VSVFBSTStTVHdRYzZ5eW5BRTZXRkRLZU9Rb3VFNzQxU095cFlq?= =?utf-8?B?Qm8zbVd5OG5rUlRVNVJCM0J4K0cyOHNiZVVxeGc3Z3MzZHdid1FiRWtDTEIy?= =?utf-8?B?bkZYdWJpcGdYTWxPakNYOUxEMVRTQTJHQnczT3hRM3czVVBvQ1MyRy90bTV0?= =?utf-8?B?V0hYWXJCRTdoRnlpUGhyNEZoUFBSNmdRcTZ0UGhZNit1NVR3aGdzTkJuTG11?= =?utf-8?B?UjI3WE9tVlJzQlB6ZVNpSXBvbkkvR3I0QTdZQnRoU2hqZWZnL0hJUkpzRzBN?= =?utf-8?B?ZHlqRThLN00rdEZtMDI2WDAycGN0anZRQktaMGZSZDNYWVkvbWdEVnBLc08r?= =?utf-8?B?b3N2YkJwVSt3eXhSTUN3UW9XSlBHT2ZGc1QzbmN3TWVOOVI2N2pySWhMMk9E?= =?utf-8?B?cWNOU1NWRWhseTdReWRpRmk3ODAyVlhBS3hlRndXbGdvZG04OUFGM0YxbUNa?= =?utf-8?B?Q3JNdE9Hd25rcFlRQXJGUk1TeHlqd1ZsZ1BtNUh6bFQvOXpEZ0lGbFRkMHRk?= =?utf-8?B?WUgxRkpDR2dHVENoYkJmSGtidkNPdUEwaEFBTXJCdHh4VTJBQkwwT3ZPQlhl?= =?utf-8?B?aGg0QlBla01KZUpqaDkva3Bha29XbjJ0UTVCcDE2cEQvVE95cExUU2FVbWgz?= =?utf-8?B?UnFMOUNkSGRweHVqeXJpVy84ellnMldybTB5OHk4TlZOSzY1YUk0NUpJeGVu?= =?utf-8?B?WUg1WEVERERUcXhLM1ZsRXFDd3cxWkFSckV6VGxVcFJkci9yNlFsaFJGRnZD?= =?utf-8?Q?qUG8YVVYC6gPP/ATBKgZhfctq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdafc8c9-2098-4821-8c12-08da8fd52065 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:57:56.1772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /WeNcgvj58NauQhxyfvehaspnD7vrUN6ZIXxfnBdS3sQOEFHtVuIdgHbH8BFCTDFpUTg0reUFATtlLAXScbWqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4312 On 29.08.2022 13:57, Marek Marczykowski-Górecki wrote: > On Mon, Aug 29, 2022 at 01:49:30PM +0200, Marek Marczykowski-Górecki wrote: >> On Fri, Aug 26, 2022 at 04:20:52PM +0200, Jan Beulich wrote: >>> On 26.08.2022 13:46, Marek Marczykowski-Górecki wrote: >>>> On Thu, Aug 25, 2022 at 05:44:54PM +0200, Jan Beulich wrote: >>>>> On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote: >>>>>> This allows configuring EHCI and XHCI consoles separately, >>>>>> simultaneously. >>>>>> >>>>>> Suggested-by: Jan Beulich >>>>> >>>>> But was I maybe confused, and much less of a change would suffice? After >>>>> all ... >>>>> >>>>>> --- a/xen/drivers/char/xhci-dbc.c >>>>>> +++ b/xen/drivers/char/xhci-dbc.c >>>>>> @@ -1058,9 +1058,9 @@ static struct xhci_dbc_ctx ctx __aligned(16); >>>>>> static uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; >>>>>> static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; >>>>>> >>>>>> -static char __initdata opt_dbgp[30]; >>>>>> +static char __initdata opt_dbc[30]; >>>>>> >>>>>> -string_param("dbgp", opt_dbgp); >>>>>> +string_param("dbc", opt_dbc); >>>>>> >>>>>> void __init xhci_dbc_uart_init(void) >>>>>> { >>>>>> @@ -1068,25 +1068,25 @@ void __init xhci_dbc_uart_init(void) >>>>>> struct dbc *dbc = &uart->dbc; >>>>>> const char *e; >>>>>> >>>>>> - if ( strncmp(opt_dbgp, "xhci", 4) ) >>>>>> + if ( strncmp(opt_dbc, "xhci", 4) ) >>>>>> return; >>>>> >>>>> ... this already avoids mixing up who's going to parse what. So right >>>>> now I think that ... >>>>> >>>>>> @@ -1102,7 +1102,7 @@ void __init xhci_dbc_uart_init(void) >>>>>> dbc->dbc_str = str_buf; >>>>>> >>>>>> if ( dbc_open(dbc) ) >>>>>> - serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); >>>>>> + serial_register_uart(SERHND_DBC, &dbc_uart_driver, &dbc_uart); >>>>>> } >>>>> >>>>> ... this and other SERHND_* related changes are enough, and there's no >>>>> need for a separate "dbc=" option. >>>> >>>> But then you wouldn't be able to configure "dbgp=ehci dbgp=xhci" as >>>> one would override the other, no? >>> >>> Not as long as both use string_param(), true. They'd need to both become >>> custom_param(), doing at least some basic parsing right away. >>> >>> But using two such options at the same time isn't of interest anyway >>> without your multiple-serial-consoles change, so possibly not of >>> immediate need (unless someone comes forward expressing interest and >>> actually approving that change of yours). >> >> Then why change at all? Since you can configure only one (dbgp=ehci _or_ >> dbgp=xhci), then there is not ambiguity what "console=dbgp" means. >> Separating SERHND_DBC from SERHND_DBGP would IMO make sense only if you >> can actually use them both (even if not both for console, but for >> example one for debugger). > > Or do you mean to use custom_param() to actually make "dbgp=xhci > dbgp=ehci" working? Yes. > But then IMO having "console=dbgp console=dbc" would > be confusing, as "dbc" has no obvious relation to neither side of > "dbgp=xhci". Well, there was never any idea of using multiple serial consoles, so the present "console=dbgp" doesn't provide room for telling apart the two. Just like there's no way to tell apart two EHCI controllers' debug ports both (intended to be) used at the same time. JanMaybe use "console=xhci" then? > From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:07:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:07:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399432.640601 (Exim 4.92) (envelope-from ) id 1oVSfl-0005HM-A5; Tue, 06 Sep 2022 07:07:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399432.640601; Tue, 06 Sep 2022 07:07:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSfl-0005HF-6Y; Tue, 06 Sep 2022 07:07:01 +0000 Received: by outflank-mailman (input) for mailman id 399432; Tue, 06 Sep 2022 07:07:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSfk-0005H9-5N for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:07:00 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20047.outbound.protection.outlook.com [40.107.2.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f869f1b-2db2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:06:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7813.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 07:06:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 07:06:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f869f1b-2db2-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eo28dIGOGO5GV/E4gSKb+miXFIAfpbtJVUV+DxzoYj07EudT+JdXoBKCh0M7mR5ECdIPrG5QZqlEHLQL/QVAFNvXkTRzfNepdClyu1xfVllzL3pqFAToxZ2gKyx/93YlqUiWSpSfWWzEqZbNF6JW7p/UunhX7ABaWDJczqq+8VcM1PhVAFAljbgC5b+k23zNUTnm5Y5mtJC3tamAfSsmsHSY58TLnNCrcItaCWO3AVQWblQh227wgoPxaL+qEA/GpQrCpAbJ5Uhm+lguo2gqEmy0rlsz9RS9mLFyEN+uuZyKoZoqiDS4Om03fl9AeBwZGfyTNO80vBzZyHILlnysIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6I/63x5qAG9k0n9qEXH2a0xgxLGEscX/MDRhYH8wntA=; b=FhiKETB9F67rU6VECki6fUTuOuRrqmyFZo3UQM4xmoY5/2nlrU6k/328wh2+4ueZaWSIkvJF34lbel1fRrx3pFoWVqZGe5UBDMAvQgcoId1NyjKq95Bot8xYn3pvjGArAdmdNyCgcBkGwZqgkDX6NIltQSTGeI1+NLvN6KvynHpvRrArGHgbO8bAhzQbMqmeJfFuKp7DGRqmtEApF0U+62itort/7r5sAKcXd952nIIRPsHb6+BjsDXg/KAh9dhP+ptsB442EgTchHi7x4+28Y9+3nYhh5kRZukGGoLy2NsZrbffs0fRn+dE9kpr+JstnX5eWMrV6ba6CW20xamMhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6I/63x5qAG9k0n9qEXH2a0xgxLGEscX/MDRhYH8wntA=; b=sAUkN14+WHv62c782QgvXpJk7ONIJgX9j4kkGKFGu2KR1OWeQhoY1VeYBUXNWAT9kRwh5T1+gXXqGzk/M7OjK0NxZOzI+mvU7TBYrzFbWIavjOqHBFR9IzCJg4P1ak6LY7carkZqjdOz8R1x/65i611t8e6wnr+czTJaHHRSEhCormglGTGL7OBKlRHOYf4IGA77eyoVVkZ8VYEJXEG0VRCLopCD+4moVbYvvZJxtJaFKtE5KUW/ZeLDAua2Cdq1Xcj2KoJ7GaAFWOF71QskFrPy2ilO+qVEv2SMN1EaIfmiMLYYR1T6nr77VTnmpWYXq9pmtJb7nYvVBPq/3jIQpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 09:07:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20220822025810.2240707-1-wei.chen@arm.com> <20220822025810.2240707-3-wei.chen@arm.com> <15c1de02-efa3-5d2d-db3f-1b04de8a1ba4@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b57241d-2fdf-4422-d844-08da8fd6626f X-MS-TrafficTypeDiagnostic: AS8PR04MB7813:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P/7FuLAkt3lRiCQe741iObennzBu6M/T6HTsSVzT6k35YPo/67fSFjplBToI0Q3v98LG10xrXUpdVHAJkLOBxVw0S68fTpun1HV1n0SrWOzK8/r3D9zXdj+x6X5bsL9KK/KPtOpccduHS9JPJESAbTfhK0QWx+Az5uEapg59NCLJzzIFBvkgw7GKOTYHejKWMs4BtR8gOEYZkIVbKFwQ9fL6oGSKfatydzJm2mjmdMAfzG4Jt9wBgjG4K48da6vBUjfvkdIvxB7d+HXlwdftXiiIK/GTl6x8tvpU9yI1sEJ7HGH0UorGQtXlVNFtJIe7P5HBycGPLM8yVCGBHvLH5VowczpVSQAfqf2lJDwI0Qj1fp1KFUnIV7xGYgsCatatwDkmz473EnCEt/KsUNcyEpw0VSIA+9OwHbuY4gtZP0pJtamMWuXyAdTJNvP0yCfVIoQUo6DD4f0F2quGV9+1o+oDv1zeL17997n7HllBtRO3hs25KRQpUC2NV/BV/0IxKm0onR64VEHsR34xhGFPJLrP0uknpUoZl7ypJsw0Mf3sdHND7SefWtsxFQuEU+A9T73PDLd9aq5VzXEuHY9tr7dqIre6TxzWtJnt28PSGGa6flP5QDogejZ+SXsCdZIgARANvtLcMXfsvtSQsUKgiXFKg02tmXZb5Iavx9VYfiGA0PAEGEAHOJKawWFiXq8A3sAvyEoUT9sllPE1QVpfPynMynJvavKJPwo9xdxDXCWCxf80fjMNygwtVBlfzsrO+Oz/TTBhKTb/M8GezkxsTvopMiVjTzUH6K1VnGezKt4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(396003)(366004)(376002)(66946007)(8676002)(478600001)(4326008)(66476007)(5660300002)(8936002)(6486002)(6506007)(83380400001)(66556008)(41300700001)(6512007)(26005)(6666004)(2906002)(86362001)(31696002)(53546011)(31686004)(38100700002)(316002)(36756003)(54906003)(2616005)(6916009)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2F3cENuSTQ4cTlybS90OGNFYTlFcjlGSVRsZXAyL1BVN3pUdVRZYWp5djNw?= =?utf-8?B?OXNHZU0wdDBNK25yYXYwSTFqcXM0N0ZMbUVHcWdVdDhoU1FBM21mOGN3eG4x?= =?utf-8?B?amdRdnBlNXdYSitvMEE5VUNZWnVpUzBuWlI4eU54eDVNU1lyY3RhNS82Rkx4?= =?utf-8?B?blVvYjdIc1djU2h0WW5JclVrNEloYXBERjNXT3lvaXh3VG0rTzlwZDVaSVly?= =?utf-8?B?UXNqVGpTdDlDZ3JYL1FtcmtLSmZuMm9DSTBnRlBzV1hldjdiRTRZVmUveFl2?= =?utf-8?B?Y3dPdWNNNmRucE1PQjdicjlVUkFaZ2ZLWnp3aC9JMnZHckR4cElBVzNTMnlZ?= =?utf-8?B?K1Y2S3g3VnFLWHNVUTMxMlBIY0NmVVFZdyt4S2pCR0Y0NXFDNExzY092TWJs?= =?utf-8?B?NVRXNTYvN2dyZTVudVVxazR6U0dKWWp0TjFCU1paU2JzR21BOWlDYVNlQnBW?= =?utf-8?B?K2owWS9SUVpuZW40R2tISmpER25LL2NDOHdBbUtYNTl0YXQ3NHY0OFZLK0VI?= =?utf-8?B?Z1BucVdBMy9jR2E5Zk90Z2xtUTRQTjVkQm1tT21IWUVCU2gxOVNRNWIxM3VH?= =?utf-8?B?KzdiOXhWTUQwdm5jZFpmamp6LzRIdkh6Smt0aWZ3QjVnQ21lMDNvcmFBTGJp?= =?utf-8?B?WnBvU0xqSXQrWTM5dU9yejQrTWtYQzJ2U2hQQW9peWtURHVuU2JpRU12TXRB?= =?utf-8?B?aENQTHFNaG12bkJ4MDFkdElLY2Vpc0ZtcUdMNnU4ZGFZeXVmTkhZQnc2dGV0?= =?utf-8?B?VFRYRWphS1FMVzZGZXBsMjlIRVVNY2ovU2FhVDJHVDlxTFJEa3pZYmNyMHR5?= =?utf-8?B?cDNuUGtmQVRIUkxtaXhGcWdMNEprV2lJV3EvQy9oS2ZuQWVxYTV3UEVoeEZD?= =?utf-8?B?Mlh3eUpITmtsRnFRa1pXN09Hd3MyVGJSeDZ6ZkEveFVEcWRGRSsxSitiZm93?= =?utf-8?B?UXU3REd0U1RtQ3NOb3dxYnBsNWhHbDIyWC91WGJBSFFnOGpoYjI5OWNldWcw?= =?utf-8?B?WDVmank2VDF4eVkyYnlBQ0FxUzBLNnRwcno3bm9URjlQL2UzVll0Y1NvR2ZW?= =?utf-8?B?OCsxNElPTkVZWDNrYUp1Y29RYUpxRWEvVHYwQ2dBcDZZb2F0YnVjdGUzUXYr?= =?utf-8?B?UGNMWUtQNXVUNTZkU2xwMGhNYlE2NDRrV3pxaFB1alBpVHQ5NDZiazRUUVdl?= =?utf-8?B?YUl5Y29WQW9LSXV4NGErQUROR2xybGNIVk9Gc3hqd25rMUYxTXNSMy9kYmp3?= =?utf-8?B?SWxyK0h1T0VsOUxoQVJ3N09ZZFdmT2J4K0xtNW91K0p2blNWRWxWM2pibXpn?= =?utf-8?B?OEZkc3V5T2wrSkRPcTZLcFR4K3B4Q1BNalo0UFczTVJKUkJvZXZSVmI2Zklk?= =?utf-8?B?Q2JVRzRHTzB1NkIvNVpabWRlK1pBdEVuODBzU0MrMFNiVFdLamV3Z3F2MmV2?= =?utf-8?B?Yit1bmhGaGJ0ajMrSHZJYlBaaGxIV0h4TEowTGxyYkZJWDdrYzlFakZBdVo3?= =?utf-8?B?ejRETXZWYUVRWk1IaDAvbzdRbWNKSDBubklTWDVhNDJybEIxbVlDNXA2ekNQ?= =?utf-8?B?bVdqTEovTTNmZU1mSmwyeU1SajZBV2NSQUphdnF2ZVlxa04rNk1FYVFyUUdR?= =?utf-8?B?WG1sTWFYZ25qZDh4bVJtNFlzd0dxeXdXWnJ1dDVLR0owREV5YUIwd2tqS3A5?= =?utf-8?B?R2htZ3djSVZuMC9Zck9YNzVZd1N5SDg0enZ0Ly9WWitWUDVOSCtmdnA3bDFV?= =?utf-8?B?VDdPd2E3ck0zRHBVV0Q4aGNOWnNQbDhBZUVVS2ozUiszM0dIQ3lINkVJWnY2?= =?utf-8?B?VkM2OHlOZWJFa3RrQ3c0VFYzVXQ3UnZoSkdKTFkrY1N4Tm9ldXlleHBLU29J?= =?utf-8?B?YjJuS3ZxZ0FJbFJaY0h0dHBqNVJiZkNjYlFnaFBucGhadmVsS1JuSE5WclJW?= =?utf-8?B?blNHdEswdmx4MHU4SVRTY3RxWG1KK0lGUVNNWHQxbXJTQy9Xb3NzS0V2bVpC?= =?utf-8?B?Z0wrcEhQbGRnL0o0L2xVSDg3Z2s5MzRLZ0dJclY1RXVQRFo0TG8vT2hnZ2xy?= =?utf-8?B?WFFyZ1NFZGZSSFNOSEsxS3lGRVNYU0hiSFlYZEN4dTRYSWJ5N1BkK3pHUkgw?= =?utf-8?Q?Bp1oRGkFFZFXmaN+pjw9UzlRR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b57241d-2fdf-4422-d844-08da8fd6626f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:06:56.4710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sw+5/upvWodD0kfflxvI4vt6I9RJRIeMShLSwZk4t680QtGnEoSxa2v9ks0R7Dmxr8P5YrzoYTW6cYgFSS0FzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7813 On 29.08.2022 11:49, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年8月25日 18:58 >> >> On 22.08.2022 04:58, Wei Chen wrote: >>> +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; >>> + >>> +bool __read_mostly numa_off; >> >> This, otoh, can be, or have I missed a place where it's written by a >> non-__init function? >> > > I think yes, it will be used in numa_disabled and numa_disabled will > be called in cpu_add. In the original code I cannot spot such a path - can you please point out how exactly you see numa_disabled() reachable from cpu_add()? I'm clearly overlooking something ... >>> +bool numa_disabled(void) >>> +{ >>> + return numa_off || arch_numa_disabled(false); >>> +} >>> + >>> +/* >>> + * Given a shift value, try to populate memnodemap[] >>> + * Returns : >>> + * 1 if OK >>> + * 0 if memnodmap[] too small (of shift too small) >>> + * -1 if node overlap or lost ram (shift too big) >>> + */ >>> +static int __init populate_memnodemap(const struct node *nodes, >>> + nodeid_t numnodes, unsigned int >> shift, >> >> I don't think you can use nodeid_t for a variable holding a node count. >> Think of what would happen if there were 256 nodes, the IDs of which >> all fit in nodeid_t. (Same again further down.) >> > > If we use u8 as nodeid_t, why there will be 256 nodes to here? > And the MAX_NUMNODES has been limited to 64 (using NODES_SHIFT or > CONFIG_NR_NUMA_NODES). If we allow 256 nodes, we have to update MAX_NUMNODES > and nodeid_t first I think? Well, when writing the reply I did forget about MAX_NUMNODES, so yes, with that the value can't be larger than 255. Nevertheless I don't think a count-of-nodes value should be expressed with nodeid_t. It should be simply "unsigned int". >>> + nodeid_t *nodeids) >>> +{ >>> + unsigned long spdx, epdx; >>> + nodeid_t i; >> >> This is likely inefficient for a loop counter variable. Note how you >> use "unsigned int" in e.g. extract_lsb_from_nodes(). >> > > Did you mean u8 for "i" will cause something like unalignment, and will > cause loop inefficient. If yes, I will use unsigned int for "i" in next > version. There's no issue with mis-alignment afaics, but there still is the inefficiency issue requiring the loop variable to be zero-extended before being usable as an array. Both x86-64 and aarch64 have the zero-extension as a side effect when moving 32-bit quantities (from memory or between registers), and arm wouldn't require any zero- extension at all then. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:10:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399444.640612 (Exim 4.92) (envelope-from ) id 1oVSil-0006mm-Vb; Tue, 06 Sep 2022 07:10:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399444.640612; Tue, 06 Sep 2022 07:10:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSil-0006mf-SC; Tue, 06 Sep 2022 07:10:07 +0000 Received: by outflank-mailman (input) for mailman id 399444; Tue, 06 Sep 2022 07:10:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSik-0006iQ-61 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:10:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eea39d88-2db2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:10:05 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0402MB2775.eurprd04.prod.outlook.com (2603:10a6:4:99::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 07:10:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 07:10:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eea39d88-2db2-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+uPVakEg9iCuSZGgaL1kxnntWXlc4Nt1Rooa1M1A2b40qWabWmnLNLYo9Keikef173XNCScxXf3w3xX2vykLF+ZuJ9NQJlnIVB1nwo0Mfq5aWkBboD9yeP6PCRhY2mQpNQ6pcCobuvI/z20ciqbRq+vR4+RBcLqdyOsLZRrk210KJHbwo7fLWav8PelUrm5BstlSz9VURu+dUaXkROnUqErzeWfAo6WZqjmfrTladPtc+G4hgZysw/fhDjlwKpHxtTkShMj26V3/LuelyZC0MvgdUarE/dwfqgKqTLcVsYLTOAQxmBRkogH0RggjBjpK7j6mZnCKKs0Qg/CW1WG2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DsDDV/FN9vy0G1r/S2w2wFWcUVlkivmZdtxVuZRHZZM=; b=mbM+ZcrACjqM8rIHTfCuGf2cCk/GJc2fE+Wqf1KE2K/vuJp09LLeUCfCz5u+AaPDobKIzcG1puJ8+U1uIeTT9Pj7kLscNHKUayK/x6iAQilHe+3Z5lDq9xhAV8cds5wt4d+5VmkffXAF1iMzjgp+MHWkJJ9wo8xQzgqXy/EfSLgouHUNlxNp53VRFxW6CboQbSzFrPuonTabbJTginq9jZ/Z+Unfee66XlHjvtl5iuO/WH9O/ADjMF7e39wDJPa6wyJqeBHLrvo19THkCrXJNoJgfKPGc9C4bsHQcH7jjDYSr3qo1Wl3BkH0urQQUMksqTonk6uO4Mm6e6TAqLvRWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DsDDV/FN9vy0G1r/S2w2wFWcUVlkivmZdtxVuZRHZZM=; b=bg9GiSVeJxFjwWrtM11mqeC9KQna+yqAMqd9lSkUK50NJkI6dBluSp+apcBIcaHldx9klo+qO+FUxVpguTLPkNmTd4zZ0iJhcVvlxb9ptu8NTDQboC20cZ/UKy6agaG8fthKESsMrVHlPUMT7xOgrW2KM53JOjPABaIyJ1Fi3HJql0XhSEYNuKSYMDcPwWf7y3dPImOcMWpS/zqEkFd9pUoVLTt6/JeBQqTawhKFf4Ihe9Fbv3MQAUJpVWEimN+iqDTPOWQHUhxo8+JSF5pIRa/yycmKu80kdquHkE8pj8pO8/qjwGDd9HM7wER7sEHh/qfbNCgb5/XBWAcASOJthA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <68f9ca92-1971-f881-02d7-97560bb24617@suse.com> Date: Tue, 6 Sep 2022 09:10:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20220822025810.2240707-1-wei.chen@arm.com> <20220822025810.2240707-6-wei.chen@arm.com> <67d9e7bf-8e0c-9290-5ac5-30d8cd8b9177@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR04CA0038.eurprd04.prod.outlook.com (2603:10a6:20b:312::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2093ac4-9122-433d-d38c-08da8fd6d1bd X-MS-TrafficTypeDiagnostic: DB6PR0402MB2775:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8me1e0cm8NNJYk7GwIde5/0ueNfihAYCtexjHi9pHQYggCVymP29iD+5GNq+SJcL36xdTcNlekxSjU+NxiFB1siU+zO/zPylUaLre/N4KWlpbL3ri0cYQxDterV5PyMRq7r24jrCZuDKCwnfP75ibUszhVtU6nB/pDQaWGb9L1RhxzaFi5hLZ396PvoJgetHc8q+89lCqKJaPWPj4QrDz6clzOqTBYtO6SIRxvllda0jEPm/Rx/k9PETwNTlI1vJAoD2MfjLD2gY2IfuqoEfJU5YhR9goKtpeN1e1Kit+80sfANGz3R0cUEjN4N5MckQ28zREJLNPKkiKgG2gmfaUP5O7s3lweG8TEJRCjc/MRpVrj743Inrde9t9By9fJooh+0cpPGVxzgFWzOV/IcILhELy76bUXD1FkCh0yXH52VJhTkMuH6XsA5J12L60Zag8L8I1uQ2E5bAYql2NTSzUaVa9Tvo6WRl2IgmMgbOJNJoOKuwYNR9B9o8NkHAHxP1Rd4drJs/nESBNpTRVDjIbUynOgKfsRXKax66e/3q6HiMbv8YtViiBM13vb/X1E67HdUQEQiXmf7q0fWUEURMjxOHHOE9jH8s62Pu8W+hs9PQIj2K4H3VYhAgFaX5sbORPfhxeWSUDaQeJ0FxILme1cJENB7UrGZ2x/myTpWQ4ba36pcc3JSotrQhijlJHg5eVDG6Oy3jcEo8hqOoW1YX/L+eIpHSjh+ARF5tvIVuYnArBYZylaGPOfm4LhelTFmmFhO1yysAOjC3KJCKMu1MgfkcYiBezZ+UUU+frvRV4Yw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(136003)(376002)(346002)(2616005)(186003)(41300700001)(5660300002)(8936002)(6916009)(316002)(83380400001)(54906003)(26005)(478600001)(66946007)(53546011)(8676002)(6512007)(31686004)(66556008)(86362001)(2906002)(6506007)(6486002)(4744005)(38100700002)(66476007)(31696002)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akdRWnZSeExvbmVtTFhKUlZXMkR6eENGak5XVGt1d2RJKytXMDdTZjB6UHls?= =?utf-8?B?VERlRCtpYU5HSnpEdFlOV2x1NXpTMjlidDRQTkRyRDVJbGc0Y1F2VUNyTzNr?= =?utf-8?B?Mm9kZ203QWVkWkg1R1JER0N1aVEvWkIySVBwRjlueVlNODdzVTgwdXM4dG5x?= =?utf-8?B?N2hndkR1VnZERVVka0t6UE84SlNYS2V2eGhXSG92YTFtRVJtYkZWaDZwdWdx?= =?utf-8?B?bU9yL082TDJNdzhWd0hoMk4wc0hNVzlieFFyUXBWcUVWYVVxMXVVRSs2L1RB?= =?utf-8?B?T3N3dXRVN2J0dmtqdmszYjd6VW8yRmJGU3Z5Q2V5R1ZleHVhUURjaWFjSmFG?= =?utf-8?B?b3IxUFhydEMwNDIxdGFPUnoyVWNSTkt0YzdCK2ZtMmR3dktHUEZkaXMvU0N1?= =?utf-8?B?N3pnTmN0Q2hwS0NJdWw5ajluK2U3Zkk4RGJlWmUwdUdQemk4SHFZc1RRK3Bq?= =?utf-8?B?amZxMSs0MW55S3BuR1JwTXFnV0NCc2lTM2FoUlpDeDF3THU1a3J3NU9YYXlW?= =?utf-8?B?ejdybndxV1ZPckplSHM0S1pVSGhaaldCSVd6UEtGRWNrajZIbnlSZ1ZzSUpz?= =?utf-8?B?VFhnNkFnNllncHg0bEFYKy9JcXM1eHRTQ0RPMENVa0ZmMTZSZFBiYUIybWRR?= =?utf-8?B?QVV4Uk1HZ1hVTDBXOEl3TysycUErbzBOQUxqeTJMc0J2UjIzd2tDa2ZzWWtv?= =?utf-8?B?OEZURS9ObHprQzRrdGsxREdDN2N5ZnFGYmU1a1FiT1E4S2FoVXR1L0p2ZnN3?= =?utf-8?B?SnhYRHNKenpoK09vREJIRXVYSXNTSXZ1dlBrSFJLa2VsRjVyMnpwcDZzYXJi?= =?utf-8?B?WVBBVGJSRCtpZlNQbXVVNmtYMTZtbnlSSjB6ME1ieFp5bVJtaFd5YUxSUE51?= =?utf-8?B?VUlRVmU1ekFjc0RnL0l0WEVYS1U5RC9mK3ByMWFlOTBNM3VQN2lGa0JCcDR1?= =?utf-8?B?MUhRTlhab3Zxb1ljK1JlL2tqbDd6VXN6ZFl0L2ZhYkZhZzVpb2F3YkJ3WDMr?= =?utf-8?B?MHZCNldvclI3S1ZkT0kxdHZEZ1hza2N4NXpGZER6UitRbU5vdFJTY3pDRHpu?= =?utf-8?B?V0hqTmVvZzFQVXMrWTlWZUVaOVM4NWZOOHVKQXM2VTVRNGlCMkNGTENvVnZr?= =?utf-8?B?SjVQNFJySndNejdzcVZhaWxLL0E0ZStySDd5eTlITlJaUUJUcDY5SXo3czUy?= =?utf-8?B?UnlwYWtTNGl4NjladXZqZWgvU0ZzY1BaODBPdDdjRTBUUlM4NlNpNGVyeTla?= =?utf-8?B?dE5UejRYUi9OeVFJVWNwWVMvRTRsbUFWVzF0cm02Wm9kbTd4TTJjbEVZY0tG?= =?utf-8?B?ZXc2QkxET3NZUnRrSm5MalNDQzZwSXRDZTJVMzhVUmZQRXNKcDU1KzVpMWlL?= =?utf-8?B?Y3ZSNmJ2WlNTU0tLYXVUc3dXUytscTdVSXo3aDFVaHFJYXRoeTB4a3h2bVZk?= =?utf-8?B?Z3QrazI4ZXBYeU4rMkVUUFFCcnR1RWJxbmd0ZWRqalJVZmJ5UkRqK0ZZVUda?= =?utf-8?B?V0dtQzNieFZ0VUtQbEpDNjljN2lnRVhaaUNnRTI2cnl3akdpTU5uZXJ6WjJy?= =?utf-8?B?Yjh6Z1o1eTNhSzdOZmZJMkwvSGUraHpQQXJVQXkreE95OURZSzZVWm5aUW1V?= =?utf-8?B?alNyYURmYUhYZlFYNGJtYzZqWG9heXIrY3doSW83cHVkTmJva0ptMVdqRCtE?= =?utf-8?B?dEJpWDUwNXNLbWoxdXNiUWIweUQ1Qng4bmZrWWFYWmxaYkdsTGY2bmY3Vm5x?= =?utf-8?B?REZWbXFxNnJuRG83NzNlNDBiVS9LdERZc3BiWnJucUV3a20wWTFVdWJpZE4w?= =?utf-8?B?bENXdHFmNmtXZ0hEZXNubE15ZGFlOW16VWhnczRHLy9WT09Dd2JMemkvUmYz?= =?utf-8?B?Q1RRenRBT1NrOFMyMm5GMG9zVzhhZ1YyRmd6M2p3K0FIK28rMmFHMXM5ajg0?= =?utf-8?B?ZXVncWk2eXJZemQ4VUVHdnlXZ3M5OVlsNUh6WFlIWTdDR2I5Ri9ZK1ZOUmVG?= =?utf-8?B?QTl0bWRnNEp6REx2dW5DRllMeE9XM0FXcDhTbzFPcHpwVng2WGpRVEpscVBp?= =?utf-8?B?S05lVmlZTGN2ZC9PM09JV2hINlJyS2FlRldqbDNqNmFpUzJDZVpZOFFFTjBG?= =?utf-8?Q?4Sw4k0/J5kSiwNNf6sK9qNXYq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2093ac4-9122-433d-d38c-08da8fd6d1bd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:10:03.2092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y6AcpPib0n3zQXLHy3ZtTgxT72Fm28vK03l7bJ6DZwnJQWSs0tcudc7z2JLSEynzcRZFKAhb2JxJBLw6L/iTtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2775 On 29.08.2022 12:47, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年8月25日 20:50 >> >> On 22.08.2022 04:58, Wei Chen wrote: >>> +bool __init numa_memblks_available(void) >>> +{ >>> + return num_node_memblks < NR_NODE_MEMBLKS; >>> +} >> >> This is kind of clumsy, but I have no better suggestion. >> > > Did you mean the whole function or just the name? The need for it (as even a non-inline function) primarily. Its name at least reflects its purpose, so would be okay-ish. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:12:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:12:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399451.640623 (Exim 4.92) (envelope-from ) id 1oVSkr-0007Ns-B3; Tue, 06 Sep 2022 07:12:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399451.640623; Tue, 06 Sep 2022 07:12:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSkr-0007Nl-7M; Tue, 06 Sep 2022 07:12:17 +0000 Received: by outflank-mailman (input) for mailman id 399451; Tue, 06 Sep 2022 07:12:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSkp-0007Nb-EF for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:12:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70089.outbound.protection.outlook.com [40.107.7.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a741b8a-2db3-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:12:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0402MB2775.eurprd04.prod.outlook.com (2603:10a6:4:99::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 07:12:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 07:12:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a741b8a-2db3-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRomu4KIra23FRvt8ImYMMDtzoTUsT4O2cXbWR9BaKjIBzqnRcLLxSpSOy8+vGxoelFnuH+bKgr8VBUgLhMuYeZPp8ZhULqa51PmL12g5Q+JWk5sEeGH9BIkgs2sh9G2ysXc/k3A6WAJiugD98Gv+zDhyYUPZH1HAYqND78C+Wd6ulynlMliGEKQWEQP96qWsS+/P7M9p8K7npq1/WkCiFK20btud/HYJoSaXwY4otN3nfReIj1dL+6b4MK/ZeYrQNLASeLaKPHutLLscVZLSxq34cdCjM8obgweDvB/uwfW0B36Y90L6i0OhcuYHpFaR7b2fbihnT+pM0RDepeusw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Qv1yRbwFt54gt5dYwQMtYOC2jFf4S9KVBq4/ZC3nuI=; b=QXHsq3myEofUV4I/2I+72yqCfE32c8Q4t6cSDHWWo88wFFScOubFs0KSwHBIq8DBINvMc9dZSWr7XN4Lu4Q+2n83/RywCJ/KwMKkPO74b0rJypmcipZGguF13jne1etqpfCLIQZl+QMYcp0ZuklLWBl+BcEFAJltQxfmseNLWmuDtow1U2MgJ9C5SE8+rKZ4sqRCWFzUZKsLHGdamHCbQ5h6pTzjPR3+3hVDCiJCoz74lu219PQwJcNRi+jTYoSM/ThBV3jLlrpj12zzyyo47Ctk9i2pw0Fq+VpyoHd0HZPmDkM8ABLXD2AHDvqaNWYMZTDZZu5yl7jNkZP9k53zog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Qv1yRbwFt54gt5dYwQMtYOC2jFf4S9KVBq4/ZC3nuI=; b=zR/diPyuxh2hjGAkLI8x8j8hvd89rHbk2RWSHKN7X5C7iFasAhOnYrHlvCHvHamjW3wBxuNtCZ5lZKFcsSU56cccDOpoeJoF6TVMc72aN7nRimW087eZ7qzHV+gatjkvx0bwPGjc96VyLa2XoPGItLNdm6qClIfDLy7/OpudLCTi74K+/1RYlYbp2teL7ku+LnRoAMlcurWQBp/BmsGrjmZJ24bYr3q6cyyJxClM7EqSGMK3ErXp3Mr2mwul6KHZsqMffbf7bWH+YN23NqlCfLMFDKhkYMdBe7X2keP5rbW0IcAKFH/uqiMuOSdWZ8I57a78fSHq0yd0LCxLO8MtyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <23cad912-f716-af99-3fea-e7e8bc364e8e@suse.com> Date: Tue, 6 Sep 2022 09:12:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 6/6] xen: introduce a Kconfig option to configure NUMA nodes number Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220822025810.2240707-1-wei.chen@arm.com> <20220822025810.2240707-7-wei.chen@arm.com> <33d061fb-5bb9-f9a6-458e-23909d306580@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR1001CA0068.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::45) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b701be6-9b1d-4f53-16cb-08da8fd71eef X-MS-TrafficTypeDiagnostic: DB6PR0402MB2775:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kf1seglfY6yAd2Y98W7Ly6IDjqdaimiz+6/sKvcWy9pRDAoaZMYo9TV974pmefzQa0BX7rrpjBUpv4Mbh2mgXA/ThX6dwtIxAmnJbkbAkF92ZJl5qVOrDO5NMmwv5uEaCG3fbtvA4M+hVvIik88H2bYTCxKBwBQmNVWXNbluNvWGXXyf/a29MPBE7r1NtYd3+iEHZtjtwECbAkIjt8/+LeNcqMZ05PapZRY8udPqdRiMHDHTdQrgG5SuddePhSjDxYNxh1RUdhy2obll7Vff7vn+h4VmnVJr9368au5PPCDUGjJ/fICJ1ZRitNza8IBPEYq7Mvbfm7k8FjB3WVUXwJc0QXhpTrRjLiULUQFW1ByWPFDzvukdsuq1PdlxXjPqbCC+YmmVPJIvX27rxser5jda7xi6tlAJ6n4Gq42QxrlCATzmvBLhvbcvrE926Zaiuwdq2xl85ps+nJDcsek6Y52SpUHotoBxmAOxGU47HV2OQvl64qli4lT/0EogkenxNwLNvMkgKR+CE1JjhsFBu+xLlvGZoipzPOJ7aH/UWGUOfM1VMEzlUmZcd15+BBbWbLiUooqb9cQA4tx8lFSyY3DhzjqBFHpOiK+cEjBL3i2yAM0sS7jsifh2DK/oGnp1NcjUJqc8NgttdPtjFhksKFW0nUz4GlHB8QZYm3nuPNf6XuK/9LS7LAIO96ntS6cCu9VdwOPp192zr4Yek18ax0hRR8DqsvV9JgKO7h3UmVRKGzK44mvHWiKFTSRa9b8SHgXjMeyf3ytkX5/WwXRsQj+6g9BsYgA9YNm2BoK+SPE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(136003)(376002)(346002)(2616005)(186003)(41300700001)(5660300002)(8936002)(6916009)(316002)(83380400001)(54906003)(26005)(478600001)(66946007)(53546011)(8676002)(6512007)(31686004)(66556008)(86362001)(2906002)(6506007)(6486002)(4744005)(38100700002)(66476007)(31696002)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z05VOUpYeW40UlRnTEt2YzVFZXp5QkNCU2N4Kzd4a1lSelRDeDhZblRRU3hz?= =?utf-8?B?VUpDR1YzbklLYmw5Q1RwTVNNZmhpeWk3ckdoOC9mcGtpODNvMHI5Um52Ui9K?= =?utf-8?B?NTFnNUl3aWRKTG9MU2drU0pOUTZhSy9yVTVtdlhFT1FNdGpHT0lVQVZTSy8r?= =?utf-8?B?ZkhKaDRoQXM0NERjcjdLbFpZVUc3MmdUZFo0TG82eTdOQVJCVkV3R3RaVzdh?= =?utf-8?B?aDNYN2FMWmcxRkUrZmcyb29iQ01yeFIvb1NqSlZsc3Z3dXIyMjFYWGxpSFBP?= =?utf-8?B?T0dNMytxSGd3a1N1aUNUK2VqcERkTDI1Nkk0QVhUVUZvL2g1SnQyQlBieE1M?= =?utf-8?B?aUt0VGhvcHRseU5FUXM2aEpBN2JWSGZ4N0xLNXRNektMRVI1c1N4WWU1cEI4?= =?utf-8?B?RjYxcU5BY0piMERGOUM0Z3NQNUhWNkpNcnRnbW1HelpvMmlKK09rQnlGZjJz?= =?utf-8?B?RFpEc05HZS92Q1JFUjVtV2hUbk9HM1grSkNoc3h0RmFCRytOeFM5OXR3cXJa?= =?utf-8?B?alVadEkyZnBZZlZtRUhmOXl1WWZ6WE5TZnlvT21ZK3ozSmJrK29zck5pMnA5?= =?utf-8?B?Z2tUeGNjVStraDdMdlczSll4NjhtWHY3cWN4RFY3QkM4MnMxWG51T2tCN0tV?= =?utf-8?B?cmhXKzRiWkNtdFhKN0tQbHl6RzNsT00wM3lxbHZ0SmVRYWdra0pOV0I4UXNZ?= =?utf-8?B?LzdmbzF6R3JJRGdIdDlCMkttNVFXUVUyTEt1QmlnSElTRWxxRHNXUXNkOHdn?= =?utf-8?B?Rmh4NUc2dE9WZVdDWmlJdHhvR2NONjBMa3IrWXhOTm9BSUZZTUZZRkpXcGhG?= =?utf-8?B?cjBzU0pqbjFsc3ZiVXFNeUJVRmcwdUpyS3V3MGZRYVpHQTlEYnFCSk42TmFN?= =?utf-8?B?cDJldWo3bmdIWE9TY1lvWnpoVWZxZE1uSmJqQWpma1o3L0UvRnRPNGJrb2N4?= =?utf-8?B?bVU0c2lMUVpYaXBpMG9hd21nMnRvM3FtcmM2UDRjUWZJL1VBQkJQQnIzam9H?= =?utf-8?B?VWFrR1NiZmVod2UvRGx1T0JWK1VhMDJ0bTE3YnQzTk9hV2hsWGc0dmtGbzBz?= =?utf-8?B?SU5XelF5dUh4UC94NzhObXJTZTNPQmhkOFRZc0d4WnZsaXVGUVBEZDhCNnIx?= =?utf-8?B?ZVRyOUdJRm02R1M2OThiOFE1eXpmbUU4Q1NaaUNJVGZ1ZkJvK2c5TnZ6UE1E?= =?utf-8?B?WHk4SzdySWpCL0lHeFV4TzYxUis4QjBYTmFTdUt0c2s4TXE1ZUhIayswSFBC?= =?utf-8?B?c3RaRUVHQ1o2Z2pNcUdPbFhjOHB5cFNqSWQxNXM3TVVnS3IxKzgzSURzME5M?= =?utf-8?B?a3NBMVU3RXJGODE3YTdhRjhOSm1jNFlqQ2xDV0lzdndvT0ozdU1hQjFRaGpp?= =?utf-8?B?elRIMFVwNHFtdFBCNFZhTHZwNm5HT05HMi9wNE5WVE4rcGNDcEwxNE4zb1FG?= =?utf-8?B?NVNkbngzek1jdnh5UzI3QWFwU1h1d2xLY1Jhc2NiYmRpcGZpcjhwNHlKQktR?= =?utf-8?B?ZUJveHlHWWlIWkF6VWNISlhKbEp3dmZ6cVp0WjZ2aWVQV0s1Z2U2SXFLbmt3?= =?utf-8?B?S2lSRzhDVjhuVWQ1ejJpOXpoeVI2S1ZEb04wNks4MDByeElCelVyaHlad2Ey?= =?utf-8?B?bU5XWFlCNzVQOUtIYzBNVko0TUF5a21qRmNNUW04aXFKUWV5SkJLcFQxTDl2?= =?utf-8?B?aUpWaXlhWno1ZVVWZVJtY2JXeXltUHBYanBYVGtFeDMxUWNoRDJheFRUU05y?= =?utf-8?B?THhaUVlCblF1RXZ3M2xNcWUzS1ZHNFpjeWc5bmUvVHg0bTdwem8xelVPZ3p2?= =?utf-8?B?Z2tsbkwrekFOanJ2NHcyY0Z6NUNleXRUZ2RTQzNES0tXdFhSUUN5YjZXVUdq?= =?utf-8?B?TVlYR0VxaUREUXN3UERrYlZMSmQ4LzhrZ01KTXIxd1F0UW55RFNVZlVwbTJE?= =?utf-8?B?NGF5Z3pIaUZqejRiU0xQdWFPTWRCUSs0YTJmcFp0N3JWSTVMOTM4V0UwVjVm?= =?utf-8?B?OTdNdHh1ZDhGL0gzT0ZvMDBjanFBdGs5VGxqTUE1Wm1lTDNyUGRSbC93UXZa?= =?utf-8?B?MDlvdGl2MFRybHNLU25PdWJhclozcjVDeW9FcHpGS2dpTjZ5K09xL1R6Rll0?= =?utf-8?Q?qeIZLxZkiACH75W8m0I+m+L+Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b701be6-9b1d-4f53-16cb-08da8fd71eef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:12:12.7009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zd7YUGXSS7Dk1ujLKBQSZdnXmjW2O88nl4fUjWB0M4EQk5+uhqEZdf0U2gFO20VfMworXjnGKZ3yiKeYIULbiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2775 On 29.08.2022 13:00, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年8月25日 21:06 >> >> Note that there's an alternative with less #ifdef-ary: >> >> config NR_NUMA_NODES >> int "Maximum number of NUMA nodes supported" if NUMA >> range 2 64 if NUMA >> default "1" if !NUMA >> default "64" >> >> But I can see reasons why one might deem it better for there to >> not be any CONFIG_NR_NUMA_NODES in the resulting .config when >> !NUMA. >> > > Is it because there are many places where alternative patches need to > be added for #ifndef CONFIG_NR_NUMA_NODES? Well, yes - that's why I said "with less #ifdef-ary". As you may have noticed, excessive use of #ifdef easily makes code hard to read. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:14:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:14:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399459.640634 (Exim 4.92) (envelope-from ) id 1oVSnI-00081b-N0; Tue, 06 Sep 2022 07:14:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399459.640634; Tue, 06 Sep 2022 07:14:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSnI-00081U-KD; Tue, 06 Sep 2022 07:14:48 +0000 Received: by outflank-mailman (input) for mailman id 399459; Tue, 06 Sep 2022 07:14:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSnG-000810-Fx for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:14:46 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140057.outbound.protection.outlook.com [40.107.14.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 944cb497-2db3-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:14:43 +0200 (CEST) Received: from FR3P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::14) by PAVPR08MB9746.eurprd08.prod.outlook.com (2603:10a6:102:31d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Tue, 6 Sep 2022 07:14:37 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a0:cafe::81) by FR3P281CA0177.outlook.office365.com (2603:10a6:d10:a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.5 via Frontend Transport; Tue, 6 Sep 2022 07:14:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 07:14:37 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Tue, 06 Sep 2022 07:14:36 +0000 Received: from cabb236e4cb8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2FD77009-0C8E-435E-9742-5B1AB8A7988E.1; Tue, 06 Sep 2022 07:14:27 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cabb236e4cb8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 07:14:27 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS2PR08MB9000.eurprd08.prod.outlook.com (2603:10a6:20b:5fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 07:14:24 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::9c00:1efb:1e42:3b20%7]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 07:14:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 944cb497-2db3-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ekk0TnT6eZ8s6M+NTeLW6Hzon8Lid4zDQfAJfOceKFPypOxJrSUUCC4SdukxWuTj3dXzUugPR+WyfSCs7T6G8p1pBZQdeErxxNa4IF7Lon2X/193BnBbigU0zXx1uddgx2Cz9XI9VOugP1hYs/qRGg4c4KzXEd7fKbM3vyKw7JuVXGkhsmEQHX4UyVuCICeMB0ocnPDavhAug9SEzXkD78kFNRQDnwDyaupLVV5fB61+ZnKfA7vhwSNhr89puSEYShUPqi7MtEeM0kv0/Ns+TtCiZhQa2n/0tnIsbFPqGVqIv/3QNpnmpoZVgb2Ihm8qkzWHzbVdF4flsAWKIRH/nA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j7SYwP74Mbd5KJGLOVL+JMRE8GAuoLm9NruCqdPOXZw=; b=YiSU2NHF4bbNXulJOhRA9hxOhntR1xAo3OJ0MdHA9EasaKqQZTRoL+YEYKz++fdrNyPNOx/bZye8lMRsGnZDjZOegBseLYdqFvxoddq4NqiFrgW9xFjpkYnIr7guFC2RjGIOkZ+Gc/U7UWMd5fvYhJqKv994k5oHCnzPRs0ISirrfMpkBjdllnCLu3Lp9nDBbyeYgCZAHdYfaq737eZd2e91Gl03PM4zpOv+1m1Y3N9maduDSWxgtvDVrClujLNx/kah5kp41F75gKLKLv+X0K2Q08YV6p+YlFAGIV+5qsg8b8d14C9oetIKcUSC9Y3KLkJqD43KcUv7As/cxO2+QQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j7SYwP74Mbd5KJGLOVL+JMRE8GAuoLm9NruCqdPOXZw=; b=KAUZyAEBEMiPHEWsrJkGntemrmTeAuWmEPw0kdGabotSF2RZwUllMXPbgfmmzDoAEGAUw4qdk88d1gP+cvsr6DG+7iR2ek1fAofs4k/BxQx+0futmcIh37lkXrEWwnyts0vty7yS4oO7J4RQ6YSGxXI/n0Yq+wvw9ORuU5t0fo8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvbI79a/q82Yee9yA7ED0p4LmdQaNZiUOxUwQ+2bNnayIrx9nd1jPBEk9BNjFUISbvtmrPB58WVd9zP6PtB+4qh6tuHMW8RZYtyqJcPlxHGjbodTfehn3LeMLGfvNU6UbkhKZDvGrOqd+ZKTiSiXfWhTb9hYEY7FxmRyj6e5HIs5z2k810cSa40QFwePX9mBcgIIp0MMiS8tsBhcw2oRc5KKGf84VvKfkc9xP64IrZwnOqB08eNI0WrXHjfaBVM6Hot0zajyO8YLgll09dxy7cgftkaQU/JDQqa8L/PuBXwHYArf5AOe8BJM7hkGXMS/fE2HsmVDsXhzMNBzjcPwdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j7SYwP74Mbd5KJGLOVL+JMRE8GAuoLm9NruCqdPOXZw=; b=jJlXP2hnP5t0FBxTAcwNtnn5gv6P7KJiplEgAMWH0ZnSNg2w7DAm2W1LmFpMZuVi4gqHG8QgdVSkPcjB2hfBOT8tE5cQnYd58pbrajNMek1JLwe7fwAEJuQTq2/HJjC0TCoLIasezDipMgVXz8dooyhbVPDKkqw78IKp8ICpUhYYm2SsSJRbWH+r5ThxL0t794BJ8pO4sP/o9swM9RQpO4hNV1nhoqJfH1duBY/CxNFHtyua1b5wGMI3Q74f7wTXYgAcOSBa7Z5Pyqs6VpQNiyXS8xOVhcpU1YemQFRfPJUvYXCXtb1HLZuwZSWyhrI1K6IJGRm+AYceodnOweLBKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j7SYwP74Mbd5KJGLOVL+JMRE8GAuoLm9NruCqdPOXZw=; b=KAUZyAEBEMiPHEWsrJkGntemrmTeAuWmEPw0kdGabotSF2RZwUllMXPbgfmmzDoAEGAUw4qdk88d1gP+cvsr6DG+7iR2ek1fAofs4k/BxQx+0futmcIh37lkXrEWwnyts0vty7yS4oO7J4RQ6YSGxXI/n0Yq+wvw9ORuU5t0fo8= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYsRk4bhBJQxIp9UysK0xEJzOLuK2y32KAgB2pAvCAAYqqgIAABv8g Date: Tue, 6 Sep 2022 07:14:23 +0000 Message-ID: References: <20220816023658.3551936-1-Penny.Zheng@arm.com> <20220816023658.3551936-9-Penny.Zheng@arm.com> <691b68f0-db68-b400-5473-558583f8dbc1@suse.com> <384fbd22-909a-b56c-9cc2-0765f2498b9e@suse.com> In-Reply-To: <384fbd22-909a-b56c-9cc2-0765f2498b9e@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A2537845717224439E1EB31548070ECE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 298ba4a4-c61f-4363-ccb2-08da8fd77533 x-ms-traffictypediagnostic: AS2PR08MB9000:EE_|VE1EUR03FT009:EE_|PAVPR08MB9746:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uDH0D63JtieH3Y+z1/ea0vrFrTJWuSsQMxhRf/r/2+hASqc+yva/YUOAI9ywVOiqHhA4yXmueWncgqT/kcp3teq/gMxd0vmfMRj1bOgdC2nfpzw6KWAvKkLJndW8/3eEDNPl5NjUE/aUyan2sf7k2wsWMl1w5kYe5BSIcdcNH5JT+VSa2bqewWe3S3wxiq/B/wi8tP+xf2XA0neGYDrE4yMzBsoHbm+mecqqARS+FfoRUKJhVAH6tQ/LjZpYh1rPwBzY6F6n9OT0tZgClg8pRbcfHE3uMYsN/xUHmyHRdyHAAqgYIJC7oC7p5+AiSsCLDWzgOKOj+YGe3gYqcSOm8alAAf83OBNAb2W8wXP4DmwIXIGqOuz0d6bdmTXbii5Ob6U4Lhz9TzrMxgQjADbxeSheIHLG7cnOOYLHHGRvsNqmpudPKYKjY30HT9/U/LSnzWiQJvofCoE/oZxcUhKiLySrj64b1EZLNO8MdJad1g02t//xOvCb1JelsGzqCfQetUltCp3AGC5UGIogFSMxV0xXARQi6mhnTd065TsYlTg6JxPX3Xy5lS6t3v0Xxrj1nY59KqQ4xb/GPZJfAmbnU6H2al4uo/beRHfAYTBLZIzRiW8pfRWBl7VWr2sHE81KqUGWC6fQspuzgnDAgsBgDsvfwkLiX1BtWizcky67YEh0/BnXqp1W5+yQEXmNmrbLThrPGcub3Ac11SL4NgMCggwWH7+KI613hDAFbBbWqyvvNs/piDjAM1tS+mOqVJEDoqwvV+Ec5fTw/V3Az/kqIQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(396003)(136003)(376002)(39860400002)(53546011)(55016003)(7696005)(54906003)(316002)(86362001)(478600001)(26005)(38100700002)(6916009)(122000001)(41300700001)(6506007)(4326008)(38070700005)(186003)(71200400001)(66556008)(9686003)(66446008)(83380400001)(8676002)(66476007)(64756008)(52536014)(66946007)(2906002)(5660300002)(33656002)(8936002)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9000 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a3e5a74d-8921-4366-1e0d-08da8fd76d38 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Di8sfGpSvd20uFBtRnWam5rJoArIrKfsowg6jVJhug3WT6Mcz/RG5l6hF6++dOyshhxh9WJNO/lFtfFzqzAQT/MCvi1CG0LH1IVnyQA5eqlYvr7Erp0DZ4uHtzJSBFVYQajrrpy9pgF+oL9Bmh9xFzxb8l0HROve5HHVnLGYO8z4Lq2WstHkXOrD+hKUfigbbvCXDAvijQbnwzg+T7bGL5ZgORgd8UdhHrbSHEBUZL04eCGWs7ZB24o3fmdVzH9XuBOpjRgo+YYLYl19k6y/B0DUDCn8iwF0ZyEdRsKb6gOSFzfCyqXzTc5eERqbKkSQWoKhww/OFgy4jfEnh64UphjN4V/w7NTxt+isT6I+07Z1mX3tzew7vPUCP6EadpwweSOFkoYpJ/hFg/vHPyv/7t1xyXnMSlmBcW62k6WnjBydAVGmeRw2Jl3Y/ONDWCc+LLwp4lTn/p5KvTHAetJl9hVt4gSK1wIf2lXqhKYgEp/ybx2Krj1836CZGxkFulobvXU9IoIwfnAe2R1M7l9hedpST6uY9SYXGaZHoT525lL0VAZmUKUanC0JB8s6eUzI9lHKtdDlCrZMbUFk0BxIu0TfJkccT+EaIXZgM7jT19zQdAhTVm5m0sYSm+9fw3vgr17PwtOxdRhXCgtxNp8YwHcgo+yEDup8VupjtLrrqunFb8xqbG4NlWHawhRG3xIL6IIdqnLk2RzifyN8GL1vGY5EUFAceRFIjD76ldB3b91WKMmm0lLZwzJPU2Bsd+JAz+7ONGJbwdpjGxArhQOtqQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(46966006)(36840700001)(40470700004)(47076005)(83380400001)(4326008)(54906003)(8676002)(70206006)(82310400005)(316002)(9686003)(33656002)(86362001)(70586007)(186003)(336012)(26005)(40480700001)(81166007)(2906002)(52536014)(356005)(55016003)(6862004)(8936002)(5660300002)(53546011)(478600001)(41300700001)(82740400003)(6506007)(7696005)(40460700003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:14:37.2009 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 298ba4a4-c61f-4363-ccb2-08da8fd77533 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9746 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgNiwgMjAy MiAyOjM0IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6 IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5kcmV3LmNv b3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNv bT47DQo+IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkg PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ow0KPiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjEwIDgvOV0g eGVuOiByZXRyaWV2ZSByZXNlcnZlZCBwYWdlcyBvbg0KPiBwb3B1bGF0ZV9waHlzbWFwDQo+IA0K PiBPbiAwNS4wOS4yMDIyIDA5OjA4LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBIaSBqYW4NCj4g Pg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4+IFNlbnQ6IFdlZG5lc2RheSwgQXVndXN0IDE3LCAy MDIyIDY6MDUgUE0NCj4gPj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0K PiA+PiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+ID4+ IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcA0KPiA+PiA8Z2Vvcmdl LmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IFN0ZWZh bm8NCj4gPj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IFdlaSBMaXUgPHds QHhlbi5vcmc+Ow0KPiA+PiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gPj4gU3Vi amVjdDogUmU6IFtQQVRDSCB2MTAgOC85XSB4ZW46IHJldHJpZXZlIHJlc2VydmVkIHBhZ2VzIG9u DQo+ID4+IHBvcHVsYXRlX3BoeXNtYXANCj4gPj4NCj4gPj4gT24gMTYuMDguMjAyMiAwNDozNiwg UGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+PiBAQCAtMjg2Nyw2ICsyODU0LDYxIEBAIGludCBfX2lu aXQgYWNxdWlyZV9kb21zdGF0aWNfcGFnZXMoc3RydWN0DQo+ID4+PiBkb21haW4gKmQsIG1mbl90 IHNtZm4sDQo+ID4+Pg0KPiA+Pj4gICAgICByZXR1cm4gMDsNCj4gPj4+ICB9DQo+ID4+PiArDQo+ ID4+PiArLyoNCj4gPj4+ICsgKiBBY3F1aXJlIG5yX21mbnMgY29udGlndW91cyBwYWdlcywgc3Rh cnRpbmcgYXQgI3NtZm4sIG9mIHN0YXRpYw0KPiA+Pj4gK21lbW9yeSwNCj4gPj4+ICsgKiB0aGVu IGFzc2lnbiB0aGVtIHRvIG9uZSBzcGVjaWZpYyBkb21haW4gI2QuDQo+ID4+PiArICovDQo+ID4+ PiAraW50IF9faW5pdCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBt Zm5fdCBzbWZuLA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IG5yX21mbnMsIHVuc2lnbmVkDQo+ID4+PiAraW50DQo+ID4+PiArbWVtZmxhZ3Mp IHsNCj4gPj4+ICsgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7DQo+ID4+PiArDQo+ID4+PiArICAg IEFTU0VSVF9BTExPQ19DT05URVhUKCk7DQo+ID4+PiArDQo+ID4+PiArICAgIHBnID0gYWNxdWly ZV9zdGF0aWNtZW1fcGFnZXMoc21mbiwgbnJfbWZucywgbWVtZmxhZ3MpOw0KPiA+Pj4gKyAgICBp ZiAoICFwZyApDQo+ID4+PiArICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4gPj4+ICsNCj4gPj4+ ICsgICAgaWYgKCBhc3NpZ25fZG9tc3RhdGljX3BhZ2VzKGQsIHBnLCBucl9tZm5zLCBtZW1mbGFn cykgKQ0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+PiArDQo+ID4+PiArICAg IHJldHVybiAwOw0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICsvKg0KPiA+Pj4gKyAqIEFjcXVp cmUgYSBwYWdlIGZyb20gcmVzZXJ2ZWQgcGFnZSBsaXN0KHJlc3ZfcGFnZV9saXN0KSwgd2hlbg0K PiA+Pj4gK3BvcHVsYXRpbmcNCj4gPj4+ICsgKiBtZW1vcnkgZm9yIHN0YXRpYyBkb21haW4gb24g cnVudGltZS4NCj4gPj4+ICsgKi8NCj4gPj4+ICttZm5fdCBhY3F1aXJlX3Jlc2VydmVkX3BhZ2Uo c3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50DQo+ID4+PiArbWVtZmxhZ3MpIHsNCj4gPj4+ ICsgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGFnZTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgQVNTRVJU X0FMTE9DX0NPTlRFWFQoKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgLyogQWNxdWlyZSBhIHBhZ2Ug ZnJvbSByZXNlcnZlZCBwYWdlIGxpc3QocmVzdl9wYWdlX2xpc3QpLiAqLw0KPiA+Pj4gKyAgICBz cGluX2xvY2soJmQtPnBhZ2VfYWxsb2NfbG9jayk7DQo+ID4+PiArICAgIHBhZ2UgPSBwYWdlX2xp c3RfcmVtb3ZlX2hlYWQoJmQtPnJlc3ZfcGFnZV9saXN0KTsNCj4gPj4+ICsgICAgc3Bpbl91bmxv Y2soJmQtPnBhZ2VfYWxsb2NfbG9jayk7DQo+ID4+PiArICAgIGlmICggdW5saWtlbHkoIXBhZ2Up ICkNCj4gPj4+ICsgICAgICAgIHJldHVybiBJTlZBTElEX01GTjsNCj4gPj4+ICsNCj4gPj4+ICsg ICAgaWYgKCAhcHJlcGFyZV9zdGF0aWNtZW1fcGFnZXMocGFnZSwgMSwgbWVtZmxhZ3MpICkNCj4g Pj4+ICsgICAgICAgIGdvdG8gZmFpbDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgaWYgKCBhc3NpZ25f ZG9tc3RhdGljX3BhZ2VzKGQsIHBhZ2UsIDEsIG1lbWZsYWdzKSApDQo+ID4+PiArICAgICAgICBn b3RvIGZhaWxfYXNzaWduOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXR1cm4gcGFnZV90b19tZm4o cGFnZSk7DQo+ID4+PiArDQo+ID4+PiArIGZhaWxfYXNzaWduOg0KPiA+Pj4gKyAgICBmcmVlX3N0 YXRpY21lbV9wYWdlcyhwYWdlLCAxLCBtZW1mbGFncyAmIE1FTUZfbm9fc2NydWIpOw0KPiA+Pg0K PiA+PiBEb2Vzbid0IHRoaXMgbmVlZCB0byBiZSAhKG1lbWZsYWdzICYgTUVNRl9ub19zY3J1Yik/ IEFuZCB0aGVuIC0gd2l0aA0KPiA+DQo+ID4gSSBnb3QgYSBiaXQgY29uZnVzZWQgYWJvdXQgdGhp cyBmbGFnIE1FTUZfbm9fc2NydWIsIGRvZXMgaXQgbWVhbiBubw0KPiA+IG5lZWQgdG8gc2NydWI/ DQo+IA0KPiBZZXMsIGFzIGl0cyBuYW1lIHNheXMuDQo+IA0KPiA+IFNpbmNlIEkgc2F3IHRoYXQg aW4gYWxsb2NfZG9taGVhcF9wYWdlcyguLi4pDQo+ID4gICAgIGlmICggYXNzaWduX3BhZ2UocGcs IG9yZGVyLCBkLCBtZW1mbGFncykgKQ0KPiA+ICAgICB7DQo+ID4gICAgICAgICBmcmVlX2hlYXBf cGFnZXMocGcsIG9yZGVyLCBtZW1mbGFncyAmIE1FTUZfbm9fc2NydWIpOw0KPiA+ICAgICAgICAg cmV0dXJuIE5VTEw7DQo+ID4gICAgIH0NCj4gPiBJdCBkb2Vzbid0IGNvbnRhaW4gZXhjbGFtYXRp b24gbWFyayB0b28uLi4NCj4gDQo+IEhtbSwgeW91J3JlIHJpZ2h0IC0gb24gdGhlc2UgZXJyb3Ig cGF0aHMgdGhlIHNjcnViYmluZyBpcyBuZWVkZWQgaWYgdGhlIHBhZ2UNCj4gd2Fzbid0IHByZXZp b3VzbHkgc2NydWJiZWQsIGFzIHBhcnQgb2YgdGhlIHNldCBvZiBwYWdlcyBtYXkgaGF2ZSBiZWVu DQo+IHRyYW5zaWVudGx5IGV4cG9zZWQgdG8gdGhlIGd1ZXN0IChhbmQgYnkgZ3Vlc3NpbmcgaXQg bWF5IGhhdmUgYmVlbiBhYmxlIHRvDQo+IGFjdHVhbGx5IGFjY2VzcyB0aGUgcGFnZXM7IEknbSBp bmNsaW5lZCB0byBzYXkgaXQncyBpdHMgb3duIGZhdWx0IHRob3VnaCBpZiB0aGF0DQo+IHdheSBp bmZvcm1hdGlvbiBpcyBiZWluZyBsZWFrZWQpLg0KPiANCg0KVGhlbiwgdGhlIHNhbWUgZm9yIHRo ZSBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyguLi4pDQoNCiAgICBpZiAoIGFzc2lnbl9wYWdlcyhw ZywgbnJfbWZucywgZCwgbWVtZmxhZ3MpICkNCiAgICB7DQogICAgICAgIGZyZWVfc3RhdGljbWVt X3BhZ2VzKHBnLCBucl9tZm5zLCBtZW1mbGFncyAmIE1FTUZfbm9fc2NydWIpOw0KICAgICAgICBy ZXR1cm4gLUVJTlZBTDsNCiAgICB9DQpPbiB0aGlzIGVycm9yIHBhdGgsIGl0IGhhcyBtaXN1c2Vk IHRoZSBNRU1GX25vX3NjcnViIHRvby4NCkJ1dCBJTU8sIGFzIHdlIGFyZSB0YWxraW5nIGFib3V0 IHRoZXNlIHBhZ2VzIHdpbGwgYWx3YXlzIGJlIHJlc2VydmVkIHRvIHRoZSBndWVzdCwNCm1heWJl IGhlcmUgaXQgYWxzbyBkb2Vzbid0IG5lZWQgc2NydWJiaW5nIGF0IGFsbD8NCiANCj4gQnV0IC4u Lg0KPiANCj4gPj4gYXNzaWdubWVudCBoYXZpbmcgZmFpbGVkIGFuZCB3aXRoIGl0IGJlaW5nIGp1 c3QgYSBzaW5nbGUgcGFnZSB3ZSdyZQ0KPiA+PiB0YWxraW5nIGFib3V0LCB0aGUgcGFnZSB3YXMg bm90IGV4cG9zZWQgdG8gdGhlIGd1ZXN0IGF0IGFueSBwb2ludA0KPiA+PiBhZmFpY3QuIFNvIEkg ZG9uJ3Qgc2VlIHRoZSBuZWVkIGZvciBzY3J1YmJpbmcgaW4gdGhlIGZpcnN0IHBsYWNlLg0KPiAN Cj4gd2hpbGUgbXkgY29tbWVudCB3YXNuJ3QgcmVhbGx5IGNvcnJlY3QsIGFzIHNhaWQgLSB5b3Ug ZG9uJ3QgbmVlZCBhbnkNCj4gc2NydWJiaW5nIGhlcmUgYXQgYWxsLCBJIHRoaW5rLg0KPiANCj4g SmFuDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:17:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:17:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399469.640645 (Exim 4.92) (envelope-from ) id 1oVSpn-0000EY-8s; Tue, 06 Sep 2022 07:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399469.640645; Tue, 06 Sep 2022 07:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSpn-0000ER-6A; Tue, 06 Sep 2022 07:17:23 +0000 Received: by outflank-mailman (input) for mailman id 399469; Tue, 06 Sep 2022 07:17:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSpm-0000EJ-Gu for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:17:22 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f14fcb6a-2db3-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:17:19 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id bj12so21055930ejb.13 for ; Tue, 06 Sep 2022 00:17:21 -0700 (PDT) Received: from leoy-huanghe.lan ([104.245.99.30]) by smtp.gmail.com with ESMTPSA id jr23-20020a170906515700b0073ddd36ba8csm6155158ejc.145.2022.09.06.00.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 00:17:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f14fcb6a-2db3-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=rl0u1aqEkK/yqRyJx+719gi2bJ4faMggjt+D/zEIqp8=; b=DWqrlnEhQoDijF4/BrL+LO8ixFulKUP8Qbft8FVqsV81OnQcaqRwyNlsl8Y55rredp PkuCeFROEuiOODehGXpxlMViU3yhkfFwpW3gVcpY7y+t1yips2cGFd3M9qHTaw8Xd9XV ymioNPOhN4FkEQjkkmQHHXQZl/NL4nsAv+eybQT94+OkS0WKkRv/ev0f4AlGv+NmYXfX Uux7WLsqWTT7RmqT6EU1j/vYRgbbC3h3NavMclFQGOSzt4N6T6pxO4MoLx8qsmIEX75o ghAJlC2vmNv3XjTGMP1z0tm3U/AU/skK0BbHxQdKvVcj9nPDdtsxgb6rRt0S4n08TRks FbXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=rl0u1aqEkK/yqRyJx+719gi2bJ4faMggjt+D/zEIqp8=; b=1DuSfkZJSjD1qoiEtDpRmhulOf1+PQq42CW8W+HWujz8DczzP4xyiiO/W97g2RYPhY sZFRr9k17MET/Vx0jtSaWqcg8CtfkZlLcrE1x4B4AUL4kqzZwHDoY7nupFzGDGU/CVdk 4/Tzxw7hE9XecIRaQelPRPY3b7Tl4AEy6SCbzjD98Rh0oMbYm1oMu3TtijvduiSfO+ca 5BBnFHvc0RiGQVo1FfzkY2NYrvtk+sUDkiSR7dQkp5CtlvrTdYQD3Ztemwq8s2kyh35E aYo+5zBOW4WTF4pzaB/PSV0NAX7UL5Dipl0NixosWJ7lUBBvhp84Iv1sRpqDXvZWTZV9 A3xw== X-Gm-Message-State: ACgBeo0bzC6l77Olwf9Ugz57IdklyTpF4kpULe/ushGbeAx+hP3k6/Ni NFCp7GknEBj14JaI2zkvXThqhg== X-Google-Smtp-Source: AA6agR5lf4dhGbtsv0f1ahlTaIg/tinOOaDKFBbeYz8+s4qYEj3F3TAjEaCrIlmnXrbK12lkELQljA== X-Received: by 2002:a17:907:9603:b0:742:9ed3:3af2 with SMTP id gb3-20020a170907960300b007429ed33af2mr21431653ejc.510.1662448640559; Tue, 06 Sep 2022 00:17:20 -0700 (PDT) Date: Tue, 6 Sep 2022 15:17:14 +0800 From: Leo Yan To: Marc Zyngier Cc: Julien Grall , Ard Biesheuvel , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table Message-ID: References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r10puiey.wl-maz@kernel.org> Hi Marc, On Tue, Sep 06, 2022 at 07:27:17AM +0100, Marc Zyngier wrote: > On Tue, 06 Sep 2022 03:52:37 +0100, > Leo Yan wrote: > > > > On Thu, Aug 25, 2022 at 10:40:41PM +0800, Leo Yan wrote: > > > > [...] > > > > > > > But here I still cannot create the concept that how GIC RD tables play > > > > > roles to support the para virtualization or passthrough mode. > > > > > > > > I am not sure what you are actually asking. The pending tables are just > > > > memory you give to the GICv3 to record the state of the interrupts. > > > > > > For more specific, Xen has its own RD pending table, and we can use > > > this pending table to set state for SGI/PPI/LPI for a specific CPU > > > interface. Xen works as hypervisor, it saves and restores the pending > > > table according to switched in VM context, right? > > > > > > On the other hand, what's the purpose for Linux kernel's GIC RD > > > pending table? Is it only used for nested virtulisation? I mean if > > > Linux kernel's GIC RD pending table is not used for the drivers in > > > Dom0 or DomU, then it's useless to pass it from the primary kernel to > > > secondary kernel; as result, we don't need to reserve the persistent > > > memory for the pending table in this case. > > > > I don't receive further confirmation from Marc, anyway, I tried to cook > > a kernel patch to mute the kernel oops [1]. > > What sort of confirmation do you expect from me? None of what you > write above make much sense in the face of the architecture. Okay, I think have two questions for you: - The first question is if we really need to reserve persistent memory for RD pending table and configuration table when Linux kernel runs in Xen domain? - If the first question's answer is no, so it's not necessary to reserve RD pending table and configuration table for Xen, then what's the good way to dismiss the kernel oops? IIUC, you consider the general flow from architecture view, so you prefer to ask Xen to implement EFI stub to comply the general flow for EFI booting sequence, right? If the conclusion is to change Xen for support EFI stub, then this would be fine for me and I will hold on and leave Xen developers to work on it. > > [1] https://lore.kernel.org/lkml/20220906024040.503764-1-leo.yan@linaro.org/T/#u > > I'm totally baffled by the fact you're trying to add some extra hacks > to Linux just to paper over some of the Xen's own issues. I have a last question for why kernel reserves RD pending table and configuration table for kexec. As we know, the primary kernel and the secondary kernel use separate memory regions, this means there have no race condition that secondary kernel modifies the tables whilist the GIC accesses the table if the secondary kernel allocates new pages for RD tables. So only one potential issue I can image is the secondary kernel sets new RD pending table and configuration table, which might introduce inconsistent issue with rest RDs in the system. Could you confirm if my understanding is correct or not? Sorry for noise and many questions. I understand this is a complex and difficult topic for me, and it's very likely that I am absent sufficient knowledge for this part, this is just what I want to learn from the discussion and from you :-) Thanks, Leo From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:19:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:19:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399477.640656 (Exim 4.92) (envelope-from ) id 1oVSrt-0000tP-Lb; Tue, 06 Sep 2022 07:19:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399477.640656; Tue, 06 Sep 2022 07:19:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSrt-0000tI-Ix; Tue, 06 Sep 2022 07:19:33 +0000 Received: by outflank-mailman (input) for mailman id 399477; Tue, 06 Sep 2022 07:19:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSrs-0000tC-Q9 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:19:32 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f0894e9-2db4-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:19:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7434.eurprd04.prod.outlook.com (2603:10a6:102:8e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 07:19:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 07:19:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f0894e9-2db4-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wj6PIqnpB6jCCis7Ah8ThaddjwlZiHPzA2IZOaRmm+Wu2SgRKavA9LObUbpb1i7GUaLEgpA+scCyvsn3Yj9ldS6wbCdDFKqbXbtRBjESUnmwnsSZ8Z0JA8VPJNq4A25zIwTEN201clzH2pNFnrbCmzykLu0Oig+4Nga+T5aF8U1RIFkGi1SSOuZfvSZxQA/2zDRLLbp8I59BqTfay0hf8xnpOd3F0okykJmTLeXPsDB4bqKDMmwyTbrneQvoffk1SVPavX7OxNgXBQN/syMozR3HaMNXcagIyCft0Lyvf06lG7g3UOX3m2R/jN21Q+a6fPfFZq/dHwjPnjOYQz0Bog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ZNDNsgCfZyTP2r/RW5aBlQ9VqxDpM/1WfEZ/69haIA=; b=GNUodehlB7OVnBaWWvu/EB4/N7cOkD+bF20UH+Evm5dDF3QccCwMtxoK8EaO12eZ+Me2fz/bI8iAXiGJ3fFWcBq5/0uMMiUhiWMYI9P0kyFG+iJXN4rcNOGxJ5ycCC6iqqlS6v348YamBufXpddtw10++CouOr7D+GxjcxGGv0fMA8AqVKnycy5dL8YIkHuY06GvRe2eIVsOz4zduc8rq6ewyB9E9xgkcr+78BbHLVwE5asr2/uLjZPWZLBLE3mch+YFwdZ2UCtZ+GYOswYwfxhVRpNsD3ducjk1Gw4YHwenKx+ojlDiXVEl57MyNr4Ft5DAPxzjcWgyKwTIp0290Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ZNDNsgCfZyTP2r/RW5aBlQ9VqxDpM/1WfEZ/69haIA=; b=mOHXS4HC1qBp8RwttPC09375yVgqPRr80ZtDV15Y0n9WDwWO7SVk7y0OuZnZM1tOfdMU6VWctDpOapNcPJp5g96sE7YTVx4d+v2a3eDUiZkxPbEHTbfcPJ1yTYssGj9FMrvnm8KFwp38IG99S7cfGkCrGp2KoY/yIfCH+YSnlJuIQPPslMU9tB1poI6TnqzzOsncCRfxuqP6J/lLwK5tm1WFhxbQirkeNBvAAOy1iBMV+RR6bRe1Wid4pz915Eodl8P7Xg+9Bpy1haCHO+8kNohcSiM2My6KGdqapYpKK//cGs9wmaxukUzLTwlFwtgO85L8IAQU8piwWwea6EaGWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f02915c-ee93-83e5-73b9-a4cc9d2ee70c@suse.com> Date: Tue, 6 Sep 2022 09:19:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220816023658.3551936-1-Penny.Zheng@arm.com> <20220816023658.3551936-9-Penny.Zheng@arm.com> <691b68f0-db68-b400-5473-558583f8dbc1@suse.com> <384fbd22-909a-b56c-9cc2-0765f2498b9e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a50789a-e9b3-44fc-e0e2-08da8fd823a8 X-MS-TrafficTypeDiagnostic: PR3PR04MB7434:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6n3dfDuB12p9EI1ZyqF4Q1GUXQse1ZR17zrngTmNT6IAfF1tLRVXRWzWWrxJZN5ehajvzORyXKnmXQQoY4xdLt0pwKNvog23buDcfN+Pcj46aL+0ehlqd4tYoBbr0Mm9hnymn8CaTKVbtxslhF/RXtXiROtNhFlxf3OvZKJldu7oIG5mbBIYGzUVryZDRcIUTGF0xIMwVsGubXDOQtHtWJ4EC67z6tb1GA3B4C0fgto4ulrxaeLzBosJeguqL6QbL44w6BYMakTi8hIpD+KdzkNTDxHPmkH9eViZvHX44fpFeUyGWNszxMJSPTo1cHsJvRlOy67z/Q5sudRALyrg/F7tDGFUl5SsSfRvUugNrdPLCfreQ2islmhhHGGb5dHy5CW/u3mG/7DH7lqUZcKXQTaleWtLTShKclbTLdBXPgx9VbK3L1UuKqeQ+mtg29R9xHcej2mXttGVZ1yrqY2ZGAcC4wAbhZqKvVHdqw3kI8THUBp6EZ43yF+Dyq7a2Zn6algGMai8yhYRy0C/A5vEbcQZndnoS1t+0HFVX5KkcPAy9Ott7TDdvXONA8KsGecuONC8va0hsCZzr6tKNY4hMDXKaFLOkqxiOaZGTN9BmKPH3xU2sSs0ujFH/PHyoOpdlLHQOCKujPN8B0RcV/ui8/IdRnaYs7Tfn+3ObPJmzowm1g7DypZoVVNwfZUgkW9fao2v7YUCHFcYyZz2jvaSstBGoXMs55yv7z7OZ/yYqN+dLT2Q0MY//xt+PJsJ6n73Vsttv7+Fy2HvSomwuuQAkk0vQuYnHBWAAdAVu+6dQ4U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(366004)(136003)(396003)(346002)(66476007)(83380400001)(4326008)(8676002)(66946007)(8936002)(5660300002)(66556008)(53546011)(478600001)(6506007)(26005)(6486002)(6512007)(41300700001)(186003)(2616005)(316002)(6916009)(54906003)(31696002)(86362001)(31686004)(38100700002)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzFZR29reDV2SFV3ekNMSnBhRVkwMkRiTVF6TkIvYmlqZGhnZlJZWTZZNUdy?= =?utf-8?B?NWtRSlY4N0o1QnFoVU5ON3p0c0JYNFV0dlRyR2ptQWY5L1RuZ0VCNEZZNExh?= =?utf-8?B?T1lNek5KWEEyeG1CRTJHRUdlcFp0UmZ4NUtkK1BnSFBZOE9Ra25DbndQTy90?= =?utf-8?B?dnpXVS9HM1h0OFMrYm9HK3QvSnJOSmYyUlBnb2M0cTVSRzZ3TDR0Y0xXSXNE?= =?utf-8?B?dU1wNkFIMnhrcUtHSFZvdUd5R1Vpek5uRmtQVG5IcGZCZlBHcStMa0RjT2tF?= =?utf-8?B?WEN5VUhvRnltTEErZXNMd2JJN2VsMmJ5dVBFQ0V2eWs3ekpOOHZkWlg3a3kx?= =?utf-8?B?RE96TlFMbm1GdkdjemhjaWgzVmtudUNMdk9QYTAvYVYyUENGMDhWdFl2UXFP?= =?utf-8?B?aUVFTWg3cmR2T3h1V0JSR3RGN3o2N2lWbDVFSHRtY25yWGo2a09aR2pVdlha?= =?utf-8?B?ZTNZSnFhVUVwSzN5TzZtQmZMTE9uZk1MWk1vVTJ4cFlXT1N2MSsxZWdDT2FC?= =?utf-8?B?bFU1RUhGeDBTc1J5ZkFidHM5cmxWTGMvY3BQRDVFRStKZ1ROcGFrYVRnUEtj?= =?utf-8?B?T1ZtcDJGYWFkVnNXYUtRVDFnN3JzUTFvVFJBbzJwdlMvaVdqZzlXaWJSa1Zn?= =?utf-8?B?VzRFelJYR0hTWW5iVlBoc0xsNjBDbTh6ZldXYjNsdXppOUZMQlZiV0FjZ0I3?= =?utf-8?B?bllsYXNmcmhkY2Y2aUxuVEVOenI1MW1CTTJCZElYMm1qR2tCRHRjRm1IWGRV?= =?utf-8?B?S3dabnF5akNXS2VKdlhiRU9VUFJ1TVZRZEc3VnVwcUdHS0NERHhnR0tWV1NN?= =?utf-8?B?cG9Sam1pTzJEV2tRUHNPS2x5aEo2UEsrLyt3bGo3cDZzT3NWZG9yd05PT0Nk?= =?utf-8?B?MENDWU5yQlpuTHFGOCtBU29wbVlZejdNc3g0R2lsZHRSY3pya2NpWCttUlpI?= =?utf-8?B?Y1MyWnBKazdmWEtYTTZxd3RiVnYxcUErV25JaFVyVVNBalFXSFc4MTAyTW1L?= =?utf-8?B?QjY1QnZGS3pGVzR6TnJwSGZPMnc0WHNDYUpiQ0pOMG1MRyt3YTBTY1MyNlRs?= =?utf-8?B?bWIrZjlBK2JpQnBNbk5CTFNsSlRFUTVZOEpwVXZEWWhhU29uUldISEZQaHlv?= =?utf-8?B?dVNBRGNlRWpUek1sRWdoWGNGL2JRRU1vS3lvS1BSVVppUGZsM2VqaXU3a2M3?= =?utf-8?B?bmlpQXRzU3ZNbitoYXF5djFtMFFQODBSblo3Q2k1UkJxbTREVExidTBRZTlG?= =?utf-8?B?bWVUVFdQNitFU2VIWkVvNWZzMFE4aTFPRHFzMVNlSW1TVGdaL0tLMzVDQkpx?= =?utf-8?B?VGQ5cjJ4M0JWN053bE9ULzVBZjJYejAxM3ZsUnErUDBlQlB4RzVQVzIwVXRy?= =?utf-8?B?K3ZuQTA3enlkWjA4dWlhM2diT1d1bXJrMjduTjhQVzJaWHJXaTdncGI0Wnpy?= =?utf-8?B?emIxOG9kR3Zka0xteDVYV0FYZDcydmRSdG9UT2FSMGtVUG9HMUdxZ1c0a0Zx?= =?utf-8?B?bDQydnQvK2R5Y0FMRWVwcEtVMGdnUXlGc1ZyZ2xMN1BFdksxR1ZtanQwdXlm?= =?utf-8?B?cUxKN3kwVXFUeTVRQ2RYa2QveHVhL1VVejE2WHg5RTNobHd3NlJuZ2RwaVBv?= =?utf-8?B?U0JIRVFWVE9PN0tVRDJVek45aURLV2o1OE92QnZMYW9vZHY2NzhiamtpR0ZR?= =?utf-8?B?RXZ6OG10VGt0ajlIMEFlcysvQkRnQTZ0SjhGNCtwU0dxVVhDMXVobG95ZGtH?= =?utf-8?B?MzlvbCtsczhvc1l3Q0dlZ3hKbFA2a0tMNVVzUXNueWpLSXRWTThUZXhMUmk1?= =?utf-8?B?TU8ranB2R0pIVnhLelgyREpPek1zdi9WcU1xTzZ4QkNpOG1oQmxGVFZiZisw?= =?utf-8?B?UjF4WEwvM2xMMXZDMFhkbHNnbGExYVRyQ2NYeHY2UEJzWXJmdWYveTlPUmYr?= =?utf-8?B?OXdnT2JnUk4xRUdERjIzT0dLQVlPWWhSSlV1OVBsUGdrLzY5eDU3UkU4UzEx?= =?utf-8?B?ZVJlaUcrY0RQUHY3MmdtdUlTMzE2N0I0VjlZQnByaTBWSXFPbk9DQ2UrdElv?= =?utf-8?B?SkZ4MXRXY1hWOHVZUE1OVjFWRVZ0cmp5VFY4ZEIrcUM4K1ROS1g4eXA1MUVG?= =?utf-8?Q?+6WVJAqcE5STC0tkPRZgj8t5J?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a50789a-e9b3-44fc-e0e2-08da8fd823a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:19:30.1262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GXvB+4bEIiZ8QQujuJQVzRztB1d2mA51dc+gFvuZbX3Hmdsl4MofiywgscRbfSMjndHxKTRvsCEYKFo5E97uhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7434 On 06.09.2022 09:14, Penny Zheng wrote: > Hi Jan > >> -----Original Message----- >> From: Jan Beulich >> Sent: Tuesday, September 6, 2022 2:34 PM >> To: Penny Zheng >> Cc: Wei Chen ; Andrew Cooper >> ; George Dunlap ; >> Julien Grall ; Stefano Stabellini ; >> Wei Liu ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v10 8/9] xen: retrieve reserved pages on >> populate_physmap >> >> On 05.09.2022 09:08, Penny Zheng wrote: >>> Hi jan >>> >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Wednesday, August 17, 2022 6:05 PM >>>> To: Penny Zheng >>>> Cc: Wei Chen ; Andrew Cooper >>>> ; George Dunlap >>>> ; Julien Grall ; Stefano >>>> Stabellini ; Wei Liu ; >>>> xen-devel@lists.xenproject.org >>>> Subject: Re: [PATCH v10 8/9] xen: retrieve reserved pages on >>>> populate_physmap >>>> >>>> On 16.08.2022 04:36, Penny Zheng wrote: >>>>> @@ -2867,6 +2854,61 @@ int __init acquire_domstatic_pages(struct >>>>> domain *d, mfn_t smfn, >>>>> >>>>> return 0; >>>>> } >>>>> + >>>>> +/* >>>>> + * Acquire nr_mfns contiguous pages, starting at #smfn, of static >>>>> +memory, >>>>> + * then assign them to one specific domain #d. >>>>> + */ >>>>> +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, >>>>> + unsigned int nr_mfns, unsigned >>>>> +int >>>>> +memflags) { >>>>> + struct page_info *pg; >>>>> + >>>>> + ASSERT_ALLOC_CONTEXT(); >>>>> + >>>>> + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); >>>>> + if ( !pg ) >>>>> + return -ENOENT; >>>>> + >>>>> + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) >>>>> + return -EINVAL; >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> +/* >>>>> + * Acquire a page from reserved page list(resv_page_list), when >>>>> +populating >>>>> + * memory for static domain on runtime. >>>>> + */ >>>>> +mfn_t acquire_reserved_page(struct domain *d, unsigned int >>>>> +memflags) { >>>>> + struct page_info *page; >>>>> + >>>>> + ASSERT_ALLOC_CONTEXT(); >>>>> + >>>>> + /* Acquire a page from reserved page list(resv_page_list). */ >>>>> + spin_lock(&d->page_alloc_lock); >>>>> + page = page_list_remove_head(&d->resv_page_list); >>>>> + spin_unlock(&d->page_alloc_lock); >>>>> + if ( unlikely(!page) ) >>>>> + return INVALID_MFN; >>>>> + >>>>> + if ( !prepare_staticmem_pages(page, 1, memflags) ) >>>>> + goto fail; >>>>> + >>>>> + if ( assign_domstatic_pages(d, page, 1, memflags) ) >>>>> + goto fail_assign; >>>>> + >>>>> + return page_to_mfn(page); >>>>> + >>>>> + fail_assign: >>>>> + free_staticmem_pages(page, 1, memflags & MEMF_no_scrub); >>>> >>>> Doesn't this need to be !(memflags & MEMF_no_scrub)? And then - with >>> >>> I got a bit confused about this flag MEMF_no_scrub, does it mean no >>> need to scrub? >> >> Yes, as its name says. >> >>> Since I saw that in alloc_domheap_pages(...) >>> if ( assign_page(pg, order, d, memflags) ) >>> { >>> free_heap_pages(pg, order, memflags & MEMF_no_scrub); >>> return NULL; >>> } >>> It doesn't contain exclamation mark too... >> >> Hmm, you're right - on these error paths the scrubbing is needed if the page >> wasn't previously scrubbed, as part of the set of pages may have been >> transiently exposed to the guest (and by guessing it may have been able to >> actually access the pages; I'm inclined to say it's its own fault though if that >> way information is being leaked). >> > > Then, the same for the acquire_domstatic_pages(...) > > if ( assign_pages(pg, nr_mfns, d, memflags) ) > { > free_staticmem_pages(pg, nr_mfns, memflags & MEMF_no_scrub); > return -EINVAL; > } > On this error path, it has misused the MEMF_no_scrub too. Why do you say "misused"? > But IMO, as we are talking about these pages will always be reserved to the guest, > maybe here it also doesn't need scrubbing at all? Perhaps. It feels as if we had been there before, quite some time ago. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:20:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:20:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399484.640667 (Exim 4.92) (envelope-from ) id 1oVSsN-0001jK-02; Tue, 06 Sep 2022 07:20:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399484.640667; Tue, 06 Sep 2022 07:20:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSsM-0001iP-SY; Tue, 06 Sep 2022 07:20:02 +0000 Received: by outflank-mailman (input) for mailman id 399484; Tue, 06 Sep 2022 07:20:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSsL-0001Pj-Eu for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:20:01 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00089.outbound.protection.outlook.com [40.107.0.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51bf437d-2db4-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:20:00 +0200 (CEST) Received: from FR0P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::13) by GV1PR08MB8692.eurprd08.prod.outlook.com (2603:10a6:150:86::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 07:19:58 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::2b) by FR0P281CA0050.outlook.office365.com (2603:10a6:d10:48::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 07:19:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 07:19:57 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Tue, 06 Sep 2022 07:19:57 +0000 Received: from 6366550728e4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 48282156-987C-461D-8ABA-539C02AA1DB1.1; Tue, 06 Sep 2022 07:19:50 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6366550728e4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 07:19:50 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PR3PR08MB5740.eurprd08.prod.outlook.com (2603:10a6:102:87::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 07:19:45 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 07:19:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51bf437d-2db4-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=G4UT95SlIDX3jTJfGPL7AgWXUlgXb9MCBowMm1eoHPAt+9vra6ftnieWu6srh7eU8QHqJKQIkHrjy/kDyvbNNpeJYnXvLZeT78aImh4i5Y7+0q2CkgEARCFYgxnAnr0azYjBhfxJRCX18MGc33KJ6ri4/xI9m6bMEtbNAozELo7ciL4SEUdEe+4FPhsW8DCGaMB+HnIR8bb4yQQM5Y6fOLm0UunfBmEW303nCd8K/2Xb1PfJKVQRTMPbI8RVpld/CldftCTrkuHCSZ4wvtj5EBCWTno7GRtWeRtJh9cRxiRuFR9SZQJyeqZ9H3l45NpDv+JweFUkOnujXSMiRe3K3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7QqqIbKntsO1D9Nj1iz8XQZOoYYfriM9zZHKegE4N9A=; b=OA5sa4RT7EgU5Uf6bDqZ6NvTppMALh8ShtFJQe/Rwio2iBpvM/aLS3Ag9HgBiVGBEDQngBzkd2vBrz0t6b5IKsh4B6Nz9pJ3VqdlAg3ZNUVokPPgsOcuRwBIrQRCyexps6Mc/1IYECh89RmwSStq2pLsOWHgGvFBt1s5OVjUML0c3kchdrB7BHIy9rAdjMF42LiR89q6n0+M5CKw3ffzClX8K8cLoG1VGGMHWd0mocBu+8aktM2F1CpJjyApLgl4dwOmyC6p1e9FqYdcegbVzvKfRmWfY06V1siMJZpZ4Sv0AfJqyIRxC/XOERkdBhbVgxyRMAEOhngfg389t9DIIA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7QqqIbKntsO1D9Nj1iz8XQZOoYYfriM9zZHKegE4N9A=; b=t7Fg3ZjlKFz01ylz/R8fmO7QJmlDGK+HqBT4HVVbeFD9NLAzKks7u3oZyFNA0yRsCzzTgdyWiuuAaASeAGve+6ryqPDay01uBMl/jtA04jfA4M97M/oJPOENokb2IkDR9Myqrrv5ECfOr+FkhF+YvEHQsuZCgozxy9Ds6/1VLEA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4dd57dc163130151 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DEoKhcxVXa8gOjHLEwuWCZkszg8ao4DtSdKzzWdZ7N1Dbh2MSAB+pEVRvKSxsuqyrh32dsS86W/cYL4AELlaacUJy7uaDCmp7gv4r6vW9mjkj9bF7otEfmKBiESsJnE/VYXraKLKAGo5q9L3+23EViw9RKUcFYzDgRRPKqX5rg15ooUzeBLyDnN4K4poeAYTXQhDlXMaUjT+3ZUUzCKVr6gd6c5ZKDfrsjSfQeCdRXeOUoVOqY7mrttUSuQnunHs2LeXOH6lCGbVopwi3DmD26GxCF0CRIcNO9w+ZIOoydtwzQh+huxYRLfz1xto9mJVfxpPEnXc33E5frlkkrBmXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7QqqIbKntsO1D9Nj1iz8XQZOoYYfriM9zZHKegE4N9A=; b=O4GnhACa68xTvMDd5UgiFRAJXUQw6tbHEU3SEvGPphzhTE+fgOH7jHIz4HtXin6izv9ZQ24fLEov3Gddj8zOwW8JYEsI0y3W20zDBbWAwFJ6WR7ZuCG/NQ8IUfc53gk3zKbJSqzCjLgsvFl3z3Nkh12y3tjTrslE6UwHhWXqMpQQgU1DRca40dXzK6Evk1w1q0NAdZYcutyBOcp3L47PENL8bvMG0pckB36/1t3pK/bdOeYlQWk2sa1lRrE9gzwu8GIzG9MYJbd6aoois9Tbg3undWTc5Q14o4e1CnreXAppeWiqiK3nUJTxq5WnQeGzG/FtU7XVJHPElV8DIa65Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7QqqIbKntsO1D9Nj1iz8XQZOoYYfriM9zZHKegE4N9A=; b=t7Fg3ZjlKFz01ylz/R8fmO7QJmlDGK+HqBT4HVVbeFD9NLAzKks7u3oZyFNA0yRsCzzTgdyWiuuAaASeAGve+6ryqPDay01uBMl/jtA04jfA4M97M/oJPOENokb2IkDR9Myqrrv5ECfOr+FkhF+YvEHQsuZCgozxy9Ds6/1VLEA= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , xen-devel , Zhou Wang , Stefano Stabellini , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Topic: [PATCH v3 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Index: AQHYwUUWFmEvVlJX+EKYMZGC5n14Aq3RCQUAgAADdwCAAAGWAIAA8XYA Date: Tue, 6 Sep 2022 07:19:45 +0000 Message-ID: References: <885a4f6b-8350-229d-55da-4171eeafb800@xen.org> <41229BFA-D9F9-442D-92D2-67354897B5EA@arm.com> <5c0e3697-96cd-c4e5-4de0-a01d4d699c69@xen.org> In-Reply-To: <5c0e3697-96cd-c4e5-4de0-a01d4d699c69@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 88510204-c9a7-4409-3bda-08da8fd83420 x-ms-traffictypediagnostic: PR3PR08MB5740:EE_|VE1EUR03FT043:EE_|GV1PR08MB8692:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wDn/O9QQ7iyya61lFWKz0vVgSZgQ3QRcqRBl28/Eld1vmMSeLFc7neXswh8wDfkUGs2kS9JFLkfzrHUIrgZ7lPhNrWmM+Ha34WMv3IGo6ZPw3eldjBptFHNqd5cpvqqGSwihKq/5PsUyBFMGRwexbVP8qJ7vTt5KHwsbpdAHbkYBzbzJuNsgLwljmZXcy8v0tnJUU2RcAHsVIX3GL9XyoR1SlP4MwegROr+iYIdCKIE6U3qjjsaC34ZJXx3iWzC6pf4p0vntcWjmFx233QT1K9R4VBtE7vsBVZWCXqeE8e+8uMLoiP4K3W35ke6h1RRRP7MVAheRcRQp13/UAgOUOtm5K5TGhFRU3YcxRQoiBTl8jbhF2kZ3GCMBjsu43RQaRWVws98xshhI2esMiaO7Hof5KQnRqJZpaBw9eDH2u8qS/SGEDJxPrl4kWg45QcZpkstrGBOGuP57BB0WZDrVg5m7CeDkJSIGODzqontksP2PS3fVYwOUNcHZSMETHDCDethTt+O2rsDULxt+h9t6uNJqQWu3fmEIsF9Q9XR6A+4nRdhSr4K5vl4ntG6ixZciWpxzG/teG2T62SXTptb57md1O62ZxwTQpUIxa65UxTUiYzKaAb2rCMZwv6ObUVQrkNeo5I4xli4x5oSc+4Ao6ZnaG3e+9nNuuSEnI+DoaugW5K28LERTnF6UOE7Z+JGrgjWOOTlPwA/OFTgKpAG3azWMVLCoNqQagFHF5z9fny9b/ouwl5IImJgREltahbqYvk847cqbArB6+QewzWIz4ZBGlUrtKEBQJeLVZzQXHpsN6H2XxTsXiYnFTwab0DEE84ODRpRCQABBMjTxBq7c3Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(66476007)(66446008)(91956017)(66556008)(64756008)(76116006)(4326008)(8676002)(478600001)(8936002)(966005)(6486002)(6506007)(66946007)(83380400001)(6512007)(41300700001)(26005)(2906002)(38070700005)(5660300002)(33656002)(86362001)(53546011)(122000001)(38100700002)(316002)(36756003)(71200400001)(54906003)(2616005)(6916009)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5740 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a0af1738-d967-4cb1-e120-08da8fd82ccc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F3ZSxpfC7lj9mR/BFsvn59rZZXwYdIoVS+DEYYvBGq6+UoZHkM+pC+CZ7qDZKRUQ6g5V76FMFlYRTIeWz91le8QNnuyFBBrHldwBn3F0C3p7/y/O9tUcs/zZ9X2gABPBvfosxwCUFwnysSN/HxXRfQBlRs9qjhzI3Fv1I5dKeAL3v/qGLfCy/mg3B9urku6kx/l3rBA1dyN1PieyNfe5iavbEzUnxgZXwM5dxF2klLQ/Et2dkqH8oW4c7VGFvOw80zl1ZwydKC1PEPVy4CPYiJ1ViDOASuT8B7bvuZDExEq6Srnoenj+sq4P9K2y/B9vm9ziQEBUdleb1BGleAfwhjSnz3F9wHt8zwuaVZg2nGsvsKDPZGtu9g71FP7ZUOrFSwC6HAQx1wolHlNeb8pL982NztAdow0e0D1VJ1eanRZPWtJibV/doWZ2Pyz/hPELuWVP/dXL3LT0W9kVti1nuRW0doW4U6yqaWM6FKgCk5Lg3Fk5/TJbziP9huex2ke577alzKJd+FlcJGsCWxLrPozAglsbxVN2jzbEVMEkGf7B63v5fghN5J/yE60O6DJnJCtfY8b2TO1zOhU95Oso/lAQLantzKJXehJPIKwP9yQwFkT61+Z/8KMZvO14ZA6npmOVadTn8XHy41+4465w9k9NKrNYHZmLuVhlJHutudbjbO6yLKmhx3Xgt2wOsUMrn6Z4tD1DLEv3Ir3Wpo5LI/UyBZbFl8qQGes3GvBUbl+kby0CkQuTBS0YYnvzKUpRTxIxFw7FQUDoJXGvoCvzomBwzfRc9oUCUXrYuOKjFdM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(40470700004)(46966006)(36840700001)(36860700001)(356005)(8676002)(4326008)(70206006)(70586007)(82740400003)(2616005)(6486002)(336012)(47076005)(41300700001)(81166007)(186003)(966005)(40460700003)(6506007)(6512007)(26005)(53546011)(54906003)(316002)(107886003)(478600001)(83380400001)(6862004)(36756003)(2906002)(86362001)(5660300002)(33656002)(82310400005)(8936002)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:19:57.5488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88510204-c9a7-4409-3bda-08da8fd83420 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8692 SGkgSnVsaWVuLA0KDQo+IE9uIDUgU2VwIDIwMjIsIGF0IDE3OjU1LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMDUvMDkvMjAyMiAxNzo0OSwg UmFodWwgU2luZ2ggd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+ Pj4gT24gNSBTZXAgMjAyMiwgYXQgNTozNyBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9y Zz4gd3JvdGU6DQo+Pj4gDQo+Pj4gDQo+Pj4gDQo+Pj4gT24gMDUvMDkvMjAyMiAxNzozMCwgUmFo dWwgU2luZ2ggd3JvdGU6DQo+Pj4+IEZyb206IFpob3UgV2FuZyA8d2FuZ3pob3UxQGhpc2lsaWNv bi5jb20+DQo+Pj4+IEJhY2twb3J0IExpbnV4IGNvbW1pdCBhNzZhMzc3NzdmMmMuIFJlbmFtZSBf X2lvbWIgdG8gaW9tYigpIHdoaWxlDQo+Pj4+IG1lcmdpbmcgdG8gZ2V0IGluIHN5bmMgd2l0aCBv dGhlciBYZW4gZGVmaW5pdGlvbnMuDQo+Pj4+IFJlYWRpbmcgdGhlICdwcm9kJyBNTUlPIHJlZ2lz dGVyIGluIG9yZGVyIHRvIGRldGVybWluZSB3aGV0aGVyIG9yDQo+Pj4+IG5vdCB0aGVyZSBpcyB2 YWxpZCBkYXRhIGJleW9uZCAnY29ucycgZm9yIGEgZ2l2ZW4gcXVldWUgZG9lcyBub3QNCj4+Pj4g cHJvdmlkZSBzdWZmaWNpZW50IGRlcGVuZGVuY3kgb3JkZXJpbmcsIGFzIHRoZSByZXN1bHRpbmcg YWNjZXNzIGlzDQo+Pj4+IGFkZHJlc3MgZGVwZW5kZW50IG9ubHkgb24gJ2NvbnMnIGFuZCBjYW4g dGhlcmVmb3JlIGJlIHNwZWN1bGF0ZWQNCj4+Pj4gYWhlYWQgb2YgdGltZSwgcG90ZW50aWFsbHkg YWxsb3dpbmcgc3RhbGUgZGF0YSB0byBiZSByZWFkIGJ5IHRoZQ0KPj4+PiBDUFUuDQo+Pj4+IFVz ZSByZWFkbCgpIGluc3RlYWQgb2YgcmVhZGxfcmVsYXhlZCgpIHdoZW4gdXBkYXRpbmcgdGhlIHNo YWRvdyBjb3B5DQo+Pj4+IG9mIHRoZSAncHJvZCcgcG9pbnRlciwgc28gdGhhdCBhbGwgc3BlY3Vs YXRlZCBtZW1vcnkgcmVhZHMgZnJvbSB0aGUNCj4+Pj4gY29ycmVzcG9uZGluZyBxdWV1ZSBjYW4g b2NjdXIgb25seSBmcm9tIHZhbGlkIHNsb3RzLg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBaaG91IFdh bmcgPHdhbmd6aG91MUBoaXNpbGljb24uY29tPg0KPj4+PiBMaW5rOiBodHRwczovL2xvcmUua2Vy bmVsLm9yZy9yLzE2MDEyODE5MjItMTE3Mjk2LTEtZ2l0LXNlbmQtZW1haWwtd2FuZ3pob3UxQGhp c2lsaWNvbi5jb20NCj4+Pj4gW3dpbGw6IFVzZSByZWFkbCgpIGluc3RlYWQgb2YgZXhwbGljaXQg YmFycmllci4gVXBkYXRlICdjb25zJyBzaWRlIHRvIG1hdGNoLl0NCj4+Pj4gU2lnbmVkLW9mZi1i eTogV2lsbCBEZWFjb24gPHdpbGxAa2VybmVsLm9yZz4NCj4+Pj4gT3JpZ2luOiBnaXQ6Ly9naXQu a2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0IGE3 NmEzNzc3N2YyYw0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hA YXJtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IENoYW5nZXMgaW4gdjM6DQo+Pj4+ICAtIHJlbmFtZSBf X2lvbWIoKSB0byBpb21iKCkgYW5kIGFsc28gbW92ZSBpdCBmcm9tIGNvbW1vbiBmaWxlIHRvDQo+ Pj4+ICAgIHNtbXUtdjMuYyBmaWxlDQo+Pj4gDQo+Pj4gSG1tbS4uLiBRdW90aW5nIEJlcnRyYW5k Og0KPj4+IA0KPj4+ICJXZSBuZWVkIHRoZSBfX2lvbWIgYXMg4oCcbGludXggY29tcGF0aWJpbGl0 eeKAnSBpbiBmYWN0IHNvIEkgd291bGQgc3VnZ2VzdCBmb3Igbm93IHRvIG9ubHkgaW50cm9kdWNl IGl0IGF0IHRoZSBiZWdpbm5pbmcgb2Ygc21tdS12My5jIHdpdGggb3RoZXIgbGludXggY29tcGF0 aWJpbGl0eSBzdHVmZiB0byBwcmV2ZW50IGFkZGluZyB0aGlzIHRvIFhlbiBvdmVyYWxsLiINCj4+ PiANCj4+PiBXaGljaCBJIGFsc28gYWdyZWVkLiBJIGNvdWxkbid0IGEgbW9yZSByZWNlbnQgY29u dmVyc2F0aW9uIGV4cGxhaW5pbmcgeW91ciBhcHByb2FjaC4gQ2FuIHlvdSBvdXRsaW5lIHdoeSB5 b3UgZGlkbid0IGZvbGxvdyB0aGUgYXBwcm9hY2hlZCBkaXNjdXNzZWQ/DQo+Pj4gICANCj4+IEkg YW0gcmVhbGx5IHNvcnJ5IHRoYXQgSSBtaXNzZWQgdGhlIG5hbWluZyBhbmQgd2hlbiBJIG1hZGUg dGhlIHBhdGNoIGluIG15IG1pbmQgdGhlcmUgd2FzIGEgY29tbWVudCBmcm9tIFN0ZWZhbm8gdG8N Cj4+IHJlbmFtZSB0aGUgX19pb21iKCkgdG8gaW9tYigpLiBJIHdpbGwgc2VuZCBvbmx5IHRoaXMg cGF0Y2ggYWZ0ZXIgZml4aW5nIG9yIGRvIHlvdSB3YW50IG1lIHRvIHNlbmQgdGhlIHdob2xlIHNl cmllcz8NCj4gDQo+IEkgd291bGQgYmUgZmluZSBpZiB5b3Ugb25seSByZXNlbmQgdGhpcyBwYXRj aC4NCj4gDQo+IEFsc28sIGxvb2tpbmcgYXQgdGhlIG90aGVyIHBhdGNoZXMsIHlvdSBhZGRlZCB0 aGUgQWNrZWQtYnkgYmVmb3JlIHlvdXIgU2lnbmVkLW9mZi1ieS4gSW4gZ2VuZXJhbCwgdGhlIHRh Z3MgYXJlIG9yZGVyZWQgY2hyb25vbG9naWNhbGx5LCBzbyB0aGlzIHNob3VsZCBiZSBpbnZlcnRl ZC4gSSBjYW4gZGVhbCB3aXRoIHRoYXQgb24gY29tbWl0IG9uY2UgQmVydHJhbmQgY29uZmlybWVk IGhlIGlzIGhhcHB5IHdpdGggdGhlIHNlcmllcy4NCg0KV2l0aCB0aGUgYWNrZWQtYnkgbmVlZGlu ZyB0byBiZSBtb3ZlZCBhbmQgdGhlIGlvbWIgcGFydCwgaXQgd2lsbCBtYWtlIHlvdXIgbGlmZSBl YXNpZXIgaWYgUmFodWwganVzdCByZXNlbmQgdGhlIHNlcmllIHNvIFJhaHVsIHBsZWFzZSBzZW5k IGEgdjQuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+ IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:22:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:22:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399494.640677 (Exim 4.92) (envelope-from ) id 1oVSuX-0002rZ-I1; Tue, 06 Sep 2022 07:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399494.640677; Tue, 06 Sep 2022 07:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSuX-0002rS-FS; Tue, 06 Sep 2022 07:22:17 +0000 Received: by outflank-mailman (input) for mailman id 399494; Tue, 06 Sep 2022 07:22:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSuX-0002rM-5R for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:22:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0f48a7d-2db4-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:22:13 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 31AD0B815CB for ; Tue, 6 Sep 2022 07:22:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03544C433B5 for ; Tue, 6 Sep 2022 07:22:13 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id k10so1405483lfm.4 for ; Tue, 06 Sep 2022 00:22:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0f48a7d-2db4-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662448934; bh=ygOQGBtlFCqHqPt/P+/9h0MUZOQeKdGeco5BlIVAnpA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SmgQzSwjdq2BLIb+qtbFPNvFWpxxYp8Ea7hyxaHK/jAtegjgTVPi/2U/YQ7VStDet 7QjxEYBuIQ4J2baYe27ZKAZhqQ0OBbOZk4aRhWC4q/FoLoegQlD4HdkSBF6bURnb1U s7DO8TmmhyrlsdNeTSuK/E+qhTlrC+bj3I+lBB0oi8Bh1bDIFhix3raJvl8/rf9O7m gSicIOR1oSD9XFKGK+S0rBE2aVFbc/OQeOw3oINlKBBN1K0avlxM2cp7j0jcQB5p5s USR7hjc2qZ28DIdJfueavTi/PfxtDQdZyzJt7M4s65cXGUaFYAM6u+S36D/WAMMJwe DISpPFqi4N+2g== X-Gm-Message-State: ACgBeo1VDQpEILJRaPXKvjCNX1Pdw1QYfdRytlLnbBt/QG1BpIvsaov1 CpPlpYfQSDadKwtqDGIwx0lzs9ZF4pDkCBYkAjw= X-Google-Smtp-Source: AA6agR7cDgv/uHpVBjdw468KjkaT3EcxbQ+S7TkYr+OVzhmCESoGFKZdbR03xDPw0e4K7chcQG4tXJ+Gat6BxIr/yhg= X-Received: by 2002:a05:6512:13a1:b0:48d:f14:9059 with SMTP id p33-20020a05651213a100b0048d0f149059mr19693452lfa.110.1662448931991; Tue, 06 Sep 2022 00:22:11 -0700 (PDT) MIME-Version: 1.0 References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 6 Sep 2022 09:22:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table To: Leo Yan Cc: Marc Zyngier , Julien Grall , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Content-Type: text/plain; charset="UTF-8" On Tue, 6 Sept 2022 at 09:17, Leo Yan wrote: > > Hi Marc, > > On Tue, Sep 06, 2022 at 07:27:17AM +0100, Marc Zyngier wrote: > > On Tue, 06 Sep 2022 03:52:37 +0100, > > Leo Yan wrote: > > > > > > On Thu, Aug 25, 2022 at 10:40:41PM +0800, Leo Yan wrote: > > > > > > [...] > > > > > > > > > But here I still cannot create the concept that how GIC RD tables play > > > > > > roles to support the para virtualization or passthrough mode. > > > > > > > > > > I am not sure what you are actually asking. The pending tables are just > > > > > memory you give to the GICv3 to record the state of the interrupts. > > > > > > > > For more specific, Xen has its own RD pending table, and we can use > > > > this pending table to set state for SGI/PPI/LPI for a specific CPU > > > > interface. Xen works as hypervisor, it saves and restores the pending > > > > table according to switched in VM context, right? > > > > > > > > On the other hand, what's the purpose for Linux kernel's GIC RD > > > > pending table? Is it only used for nested virtulisation? I mean if > > > > Linux kernel's GIC RD pending table is not used for the drivers in > > > > Dom0 or DomU, then it's useless to pass it from the primary kernel to > > > > secondary kernel; as result, we don't need to reserve the persistent > > > > memory for the pending table in this case. > > > > > > I don't receive further confirmation from Marc, anyway, I tried to cook > > > a kernel patch to mute the kernel oops [1]. > > > > What sort of confirmation do you expect from me? None of what you > > write above make much sense in the face of the architecture. > > Okay, I think have two questions for you: > > - The first question is if we really need to reserve persistent memory > for RD pending table and configuration table when Linux kernel runs > in Xen domain? > > - If the first question's answer is no, so it's not necessary to reserve > RD pending table and configuration table for Xen, then what's the good > way to dismiss the kernel oops? > > IIUC, you consider the general flow from architecture view, so you prefer > to ask Xen to implement EFI stub to comply the general flow for EFI > booting sequence, right? > > If the conclusion is to change Xen for support EFI stub, then this > would be fine for me and I will hold on and leave Xen developers to work > on it. > As I mentioned before, proper EFI boot support in Xen would be nice. *However*, I don't think it makes sense to go through all the trouble of implementing that just to shut up a warning that doesn't affect Xen to begin with. > > > [1] https://lore.kernel.org/lkml/20220906024040.503764-1-leo.yan@linaro.org/T/#u > > > > I'm totally baffled by the fact you're trying to add some extra hacks > > to Linux just to paper over some of the Xen's own issues. > > I have a last question for why kernel reserves RD pending table and > configuration table for kexec. As we know, the primary kernel and > the secondary kernel use separate memory regions, This is only true for kdump, not for kexec in general. > this means there have > no race condition that secondary kernel modifies the tables whilist the > GIC accesses the table if the secondary kernel allocates new pages for > RD tables. So only one potential issue I can image is the secondary > kernel sets new RD pending table and configuration table, which might > introduce inconsistent issue with rest RDs in the system. > > Could you confirm if my understanding is correct or not? > > Sorry for noise and many questions. I understand this is a complex > and difficult topic for me, and it's very likely that I am absent > sufficient knowledge for this part, this is just what I want to > learn from the discussion and from you :-) > > Thanks, > Leo From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:23:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:23:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399501.640689 (Exim 4.92) (envelope-from ) id 1oVSvm-0003Ta-SM; Tue, 06 Sep 2022 07:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399501.640689; Tue, 06 Sep 2022 07:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSvm-0003TT-P8; Tue, 06 Sep 2022 07:23:34 +0000 Received: by outflank-mailman (input) for mailman id 399501; Tue, 06 Sep 2022 07:23:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSvm-0003TN-19 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:23:34 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cffcf433-2db4-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:23:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F2371F964; Tue, 6 Sep 2022 07:23:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2160313A7A; Tue, 6 Sep 2022 07:23:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id f8r7BnT1FmOCNAAAMHmgww (envelope-from ); Tue, 06 Sep 2022 07:23:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cffcf433-2db4-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662449012; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yWige9mo0MBBtPav5dIlbqrSvO7RJRBpbBUTOf+sq9M=; b=WccstuGcN1E1smf3eeXr4m/9pomQg8ST93ACF2vvMP9mGzR6axKEmCztIjBdCY0kE1ePhF qp1K5CsZswV66J5NVNekoHzxPlFalOoi6cZRPYDHsBj6ywB2YlS1u9Xkk+KAWE0r4Pl9uD W0z/Db1D98aMVW/f++pbHZ2Vb4C25hg= Date: Tue, 6 Sep 2022 09:23:31 +0200 From: Michal Hocko To: Kent Overstreet Cc: Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905234649.525vorzx27ybypsn@kmo-framework> On Mon 05-09-22 19:46:49, Kent Overstreet wrote: > On Mon, Sep 05, 2022 at 10:49:38AM +0200, Michal Hocko wrote: > > This is really my main concern about this whole work. Not only it adds a > > considerable maintenance burden to the core MM because > > [citation needed] I thought this was clear from the email content (the part you haven't quoted here). But let me be explicit one more time for you. I hope we can agree that in order for this kind of tracking to be useful you need to cover _callers_ of the allocator or in the ideal world the users/owner of the tracked memory (the later is sometimes much harder/impossible to track when the memory is handed over from one peer to another). It is not particularly useful IMO to see that a large portion of the memory has been allocated by say vmalloc or kvmalloc, right? How much does it really tell you that a lot of memory has been allocated by kvmalloc or vmalloc? Yet, neither of the two is handled by the proposed tracking and it would require additional code to be added and _maintained_ to cover them. But that would be still far from complete, we have bulk allocator, mempools etc. If that was not enough some of those allocators are used by library code like seq_file, networking pools, module loader and whatnot. So this grows and effectively doubles the API space for many allocators as they need both normal API and the one which can pass the tracking context down the path to prevent double tracking. Right? This in my book is a considerable maintenance burden. And especially for the MM subsystem this means additional burden because we have a very rich allocators APIs. You are absolutely right that processing stack traces is PITA but that allows to see the actual callers irrespectively how many layers of indirection or library code it goes. > > it adds on top of > > our existing allocator layers complexity but it would need to spread beyond > > MM to be useful because it is usually outside of MM where leaks happen. > > If you want the tracking to happen at a different level of the call stack, just > call _kmalloc() directly and call alloc_tag_add()/sub() yourself. As pointed above this just scales poorly and adds to the API space. Not to mention that direct use of alloc_tag_add can just confuse layers below which rely on the same thing. Hope this makes it clearer. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:24:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:24:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399509.640700 (Exim 4.92) (envelope-from ) id 1oVSwV-000427-4V; Tue, 06 Sep 2022 07:24:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399509.640700; Tue, 06 Sep 2022 07:24:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSwV-000420-1g; Tue, 06 Sep 2022 07:24:19 +0000 Received: by outflank-mailman (input) for mailman id 399509; Tue, 06 Sep 2022 07:24:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSwT-0003TN-T0 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:24:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea954b80-2db4-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:24:17 +0200 (CEST) Received: from AS9PR07CA0028.eurprd07.prod.outlook.com (2603:10a6:20b:46c::30) by DB9PR08MB6570.eurprd08.prod.outlook.com (2603:10a6:10:251::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 6 Sep 2022 07:24:14 +0000 Received: from AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46c:cafe::2b) by AS9PR07CA0028.outlook.office365.com (2603:10a6:20b:46c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 07:24:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT028.mail.protection.outlook.com (100.127.140.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 07:24:14 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Tue, 06 Sep 2022 07:24:14 +0000 Received: from 50cf23498f71.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BB7E1E5D-4FC7-487C-BCDA-0544C9A813CD.1; Tue, 06 Sep 2022 07:24:06 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 50cf23498f71.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 07:24:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB6106.eurprd08.prod.outlook.com (2603:10a6:10:202::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 07:24:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 07:24:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea954b80-2db4-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MZE2GuoOVkczEc07poGmo+WlLuCYajxVV3OWexsSfPljzZiVQ6UyfeSB2QjuXxfUx3ku2a9/nRz3L14F1sm9IUGCjEWk0aHa7/fBdsiRWzV4jJzhiebY3DD+3N+ZCr+4Lke877ed9ltcKijqV/y1rOIVNs1mB6dLYOz7TgTMuF3xgm5ltfqIj46/qyU2YCkyqs0bIHfj660JERMtA2RSuaXHivKFDOm1TyjiZtvslVkfLUXXxPhkxwwzuY5l/ae+h0EjSVanwHUBZqml0kUjvyfMo8QIjAMBiMfA8a46yLl8mMOZ/aRLRqaYUEYbY4187RKhhAyJaMeL6QH8/CGxnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=59AoVz2istsXFBBqxHue9M0HNmlUglvw20I7+sBJ31c=; b=joPWL3KeZLbyPviPcuOr2msCTrsISV6ZW+v4InbORn4Vs0/daUDLw+zO6lFP/cUfY7lpSz+AhD/IAPttg1gMZXonQ73SJjaRuZUWfVSst944GMA/X9Obmvh03yQgGXf9dGnJSK6XNh0motjkeS7cdHNtgLxudFNuoJ8U3eYIIU4o3bPCiZytIGbk8iLAvtPtRRAjfHdVbTYGbfGz5SEjjqtRdbmr8rbbhVOrrDHE3EC3TRBJcqiJnl9sYtcn0FHSsFaB8RCtIzr+FKiHwL0TXVFmfTruJ5HAEd4tXZQRLuT7Ag8Ua0JsB8NerZTebMwXQFG+s9U7QmYs1ol+mMd9Cw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59AoVz2istsXFBBqxHue9M0HNmlUglvw20I7+sBJ31c=; b=mBDPTo68GJJErhDUp7zsIlGSuK+XE2GqzCre59g603O8Y7kuc4tbBtVtmsEqvuDm3w9F/4/uUQGubFApY3CMjdCHxIPUY2xFs5lSp5k31RTI4myzbKAj0mrLQbNh9WMVkrIun4YoPvmLEn31JSw9yn1L3qXc0AplqezLgwHMAkE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 78d2e71fab0a6df3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FC5vdW7sY/c/FbVOXdUZaXNS49umovAJnYr542NyCNRiqoaOnN39S2yJh7aOs//M38x2Gfdn4ZmYiigOT0AGB9XRotY3GIq8mZMPVqP/igqV/OWr4pLhTmWkoohW5leNEEO5aH7gwK+tx5AInY+cXklSmBVP27Mng259DAtrwvq2GxcO+5iZ4yRF/hISM/JIF9oGXVXVMSz8/rqAvIPLpk/xMEDAisve5+72mApm9eIP9+xsALYOdKgBgyue2kNefy/rYLms5kt9ExUt4SYw4YFNUaKNB1q7ZG7vMUR3w+L/4/T9DM8lSdZHTu6J6rg1f8tgjDqq3Lca+4hUhSmIHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=59AoVz2istsXFBBqxHue9M0HNmlUglvw20I7+sBJ31c=; b=FEWK+j7uocb6/+Yz6+bwM4Np9nPvTA5bLcn2+o9GLhjjQPNHdkd/ei5nrGmLhDlfMJ5MLhc6R7mZ2HzN744ylqfsrXjCmiRBWwX/Y/yuOsG4bPOMx8dHsSXdcCTES4CQfhdcUi3XOYRjXKCKYmupfSHhhZv6DMG17+mlkConC1ItzkDZvfKvQD/1nMCquQcgqrIVPuRDQvm4dEPa0JdU8qFHlUK4wycLA1r/AS5TldeXX60F0P7mHCkI5yGQfj0a7GH/XPPuKe+xm8DiRuU29ZGU1JZJv2q8q6+2P0R7LlJTi9WLfu0uZAfy9W15AR50vHAnbho5w9L4q+72YvK7pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59AoVz2istsXFBBqxHue9M0HNmlUglvw20I7+sBJ31c=; b=mBDPTo68GJJErhDUp7zsIlGSuK+XE2GqzCre59g603O8Y7kuc4tbBtVtmsEqvuDm3w9F/4/uUQGubFApY3CMjdCHxIPUY2xFs5lSp5k31RTI4myzbKAj0mrLQbNh9WMVkrIun4YoPvmLEn31JSw9yn1L3qXc0AplqezLgwHMAkE= From: Bertrand Marquis To: Stefano Stabellini CC: Rahul Singh , Julien Grall , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOAeMLlOwX5Mka7ZrpAabJW7K3K4ewAgAFZKACAAAQoAIAADY8AgAAHN4CABGESgIAACJcAgAADEoCAAAPFgIAADnWAgAAKUACAAJguAIAAkgwA Date: Tue, 6 Sep 2022 07:24:05 +0000 Message-ID: References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1e257f07-9599-49ff-2d7c-08da8fd8cd1f x-ms-traffictypediagnostic: DBBPR08MB6106:EE_|AM7EUR03FT028:EE_|DB9PR08MB6570:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n0WGGTsmwMXhrFsofcDP0KNENT24Ln65FIRgTiC9v+AtFTzIMapoElOIOt6VmtVM/qDFZyXEgCd0+TuzQfDOprLrbIgePn4kuArb2CjLvCQKdDIjVF01G1cAvq4yYVnNg4MYj3x/xIyDzRkx/XjPJb6W3htvk+ULjHTyOcr+Be7lowmAU+4YT/I0ySuPiRekWOP+XzGZSUh/BwRsKJJHmg4b1/k/Szd/lMJSPJ1l4Qkd3W8YcNv1QnYlgnRDcQXAnFY/gnY8TvH4uPAv5kxvWnhelj0fcF54F4x9w5RPaqdIiqjHuCF92DsRHUfiZqc14UCBbiAloRmkuSMvkY+3gOBx0MiUVt0HkqnkJ9mn3jaf3LhlyJTcZGeUvVinFGRmBOEqfoG+GTBPytJBw4/0iipThNXw7ewwODleo3DfdrWIHo9G/cIoUdkq24FOuJk4qcb5Mr2CHKSxfQfgJafcaM/ioi/wbvyNp2I6tiUuyFfhjlDPLZlvYZguJEUHr1QAXMf5jQ6xZRHewKD1OBvm5mufIYIVkCOO5500Vke7uu87N/vHVxCs35qS3OsMYdodgVGP1uKVbf7AF5G+qgQRkw1RH1sYx4SgK3yT4sv1rXRV/2Aky9UzGKZC8hTMTr0XHKBcO6azYXWcdLEm7noQgYHZiJBpELQqt0X6wN6RQr8zE3N8UuVTSK3aAbSRl66Pv1mqX6PxY0DG1aMAa3yXipNE9Szh+vcE3Pzg8ljaOJDWF9sqk3mSwHSiB9gzcEboNkha5aUxd3YnoRtz1xxSZqfZGqoUJXZ2LADJ/UDhTS8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(366004)(376002)(39860400002)(136003)(36756003)(6512007)(54906003)(6916009)(316002)(38100700002)(122000001)(38070700005)(2906002)(33656002)(8936002)(5660300002)(66556008)(66476007)(76116006)(4326008)(86362001)(83380400001)(8676002)(66446008)(64756008)(91956017)(66946007)(71200400001)(6486002)(41300700001)(2616005)(186003)(6506007)(53546011)(26005)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6106 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3c95cdb4-3a7f-4760-8deb-08da8fd8c7cd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ekontJ8S2gYXf7JGLIm9GteatibEEng9/gPeIDere8DkEzRPesBA9clZuut6OPvzBoAdCIxJIS0oGTYyOKC3Bb0aNInABAWSRdTGiNEpNX2UrHEIg+mgkrhCcOS8PFpUVjnqnN/5IOrftdzv/eeEZXrMuoXGDsLiAEzLOeov9xpCnm8rhBoVdeXcq/9F5RWuO5VVtiFEp+Bs6oTdv+KXy15ZTYOVneH2oFhxZRg81mOzj4AQfKQT3e/lgltXhlo+817OZWYMbHkKX85Z40pDG2/xvsG2TeO9wWJ0tD+aKsiLVCdpDoQnsyxhw0FM5Kbxw6RFg3jm4XiPNOP/ZAcwztfPnwqCIs7G5xyORBckd/JWWw2pkrguQpXOb47TCFkyQkz9Pv84SYhoO+ZfxscBNT+6ZX/IRBW8AXjVAbD5eQFmaKyrLnj2dsKcUeABfztE1fn7QK0HiseOUVGai3mUUDslC9XURVG5huCjAi4gKgigeFQS/dStZVh/Bt7PN3ZlEE/CCthR1fJlRE6OuV1bQj7yhm7WwpdTNKr1gRAkTLkFyd6eKNDwk1jNcBW/3QQK0qDpVjZfVKLEKp5+1RKOkaRY2y3EZZST/7cAXEXda8+OylCu19BLMR0680XuQvofQRFmS8ZA5H5tt/IOmvamZ7HYop24xQ0YDwyTvCLmEpEfrNIkFY8sjd7bd1BuQzmNW0j8be3+WwrBMmpLIcBYNkZlBywtqWvNyg6YDkK+aILTws2DysAc5jv8IHhSig4gBBLa1C4538/O4NgoZRYM9A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(346002)(136003)(36840700001)(40470700004)(46966006)(82310400005)(336012)(186003)(2616005)(6512007)(40480700001)(41300700001)(6486002)(478600001)(26005)(83380400001)(6506007)(86362001)(47076005)(356005)(81166007)(107886003)(40460700003)(82740400003)(53546011)(54906003)(4326008)(2906002)(70586007)(8676002)(36860700001)(70206006)(316002)(33656002)(8936002)(6862004)(5660300002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:24:14.2801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e257f07-9599-49ff-2d7c-08da8fd8cd1f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6570 SGkgU3RlZmFubywNCg0KPiBPbiA1IFNlcCAyMDIyLCBhdCAyMzo0MSwgU3RlZmFubyBTdGFiZWxs aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIE1vbiwgNSBTZXAg MjAyMiwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4gT24gNSBTZXAgMjAyMiwgYXQgMTo1OSBwbSwg QmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPiB3cm90ZToNCj4+PiAN Cj4+PiBIaSBKdWxpZW4sDQo+Pj4gDQo+Pj4+IE9uIDUgU2VwIDIwMjIsIGF0IDEzOjA4LCBKdWxp ZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4gDQo+Pj4+IA0KPj4+PiANCj4+ Pj4gT24gMDUvMDkvMjAyMiAxMjo1NCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+IEhp IEp1bGllbiwNCj4+Pj4+PiBPbiA1IFNlcCAyMDIyLCBhdCAxMjo0MywgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+Pj4gDQo+Pj4+Pj4gDQo+Pj4+Pj4gDQo+Pj4+Pj4g T24gMDUvMDkvMjAyMiAxMjoxMiwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+Pj4+IEhpIEp1bGll biwNCj4+Pj4+PiANCj4+Pj4+PiBIaSBSYWh1bCwNCj4+Pj4+PiANCj4+Pj4+Pj4+IE9uIDIgU2Vw IDIwMjIsIGF0IDU6MjAgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0K Pj4+Pj4+Pj4gDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gT24gMDIvMDkvMjAyMiAx Njo1NCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+Pj4+Pj4gSGkgSnVsaWVuLA0KPj4+Pj4+Pj4g DQo+Pj4+Pj4+PiBIaSBSYWh1bCwNCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+PiBPbiAyIFNlcCAyMDIy LCBhdCA0OjA1IHBtLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+ Pj4+Pj4gDQo+Pj4+Pj4+Pj4+IEhpIEJlcnRyYW5kLA0KPj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+Pj4g T24gMDIvMDkvMjAyMiAxNTo1MSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+Pj4+Pj4+ PiBPbiAxIFNlcCAyMDIyLCBhdCAxOToxNSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4g d3JvdGU6DQo+Pj4+Pj4+Pj4+Pj4gQUZBSVUsIGl0IGlzIG5vdCBwb3NzaWJsZSB0byBoYXZlICpf eGVuc3RvcmUgPSB0cnVlIGFuZCAqX2VuaGFuY2VkID0gZmFsc2UuIEkgdGhpbmsgaXQgd291bGQg YmUgY2xlYXJlciBpZiBgYGRvbTBsZXNzX2VuaGFuY2VkYGAgaXMgdHVybmVkIHRvIGFuIGVudW0g d2l0aCAzIHZhbHVlczoNCj4+Pj4+Pj4+Pj4+PiAtIE5vbmUNCj4+Pj4+Pj4+Pj4+PiAtIE5PWEVO U1RPUkUvQkFTSUMNCj4+Pj4+Pj4+Pj4+PiAtIEZVTExZX0VOSEFOQ0VEDQo+Pj4+Pj4+Pj4+Pj4g DQo+Pj4+Pj4+Pj4+Pj4gSWYgd2Ugd2FudCB0byBiZSBmdXR1cmUgcHJvb2YsIEkgd291bGQgdXNl IGEgZmllbGQgJ2ZsYWdzJyB3aGVyZSBub24temVybyBtZWFucyBlbmhhbmNlZC4gRWFjaCBiaXQg d291bGQgaW5kaWNhdGUgd2hpY2ggZmVhdHVyZXMgb2YgWGVuIGlzIGV4cG9zZWQuDQo+Pj4+Pj4+ Pj4+PiBJIHRoaW5rIHRoYXQgY291bGQgYmUgYSBnb29kIHNvbHV0aW9uIGlmIHdlIGRvIGl0IHRo aXMgd2F5Og0KPj4+Pj4+Pj4+Pj4gLSBkZWZpbmUgYSBkb20wbGVzcyBmZWF0dXJlIGZpZWxkIGFu ZCBoYXZlIGRlZmluZXMgbGlrZSB0aGUgZm9sbG93aW5nOg0KPj4+Pj4+Pj4+Pj4gI2RlZmluZSBE T00wTEVTU19HTlRUQUINCj4+Pj4+Pj4+Pj4+ICNkZWZpbmUgRE9NMExFU1NfRVZFTlRDSE4NCj4+ Pj4+Pj4+Pj4+ICNkZWZpbmUgRE9NMExFU1NfWEVOU1RPUkUgPg0KPj4+Pj4+Pj4+Pj4gLSBkZWZp bmUgZG9tMGxlc3MgZW5oYW5jZWQgYXMgdGhlIHJpZ2h0IGNvbWJpbmF0aW9uOg0KPj4+Pj4+Pj4+ Pj4gI2RlZmluZSBET00wTEVTU19FTkhBTkNFRCA9IChET00wTEVTU19HTlRUQUJ8IERPTTBMRVNT X0VWRU5UQ0hOfCBET00wTEVTU19YRU5TVE9SRSkNCj4+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4+IEkg d291bGQgcmF0aGVyIGludHJvZHVjZSBET00wTEVTU19FTkhBTkNFRF9CQVNJQyAob3Igc2ltaWxh cikgaW5zdGVhZCBvZiBkZWZpbmluZyBhIGJpdCBmb3IgZ250dGFiIGFuZCBldnRjaG4uIFRoaXMg d2lsbCBhdm9pZCB0aGUgcXVlc3Rpb24gb2Ygd2h5IHdlIGFyZSBpbnRyb2R1Y2luZyBiaXRzIGZv ciBib3RoIGZlYXR1cmVzIGJ1dCBub3QgdGhlIGh5cGVyY2FsbC4uLg0KPj4+Pj4+Pj4+PiANCj4+ Pj4+Pj4+Pj4gQXMgdGhpcyBpcyBhbiBpbnRlcm5hbCBpbnRlcmZhY2UsIGl0IHdvdWxkIGJlIGVh c2llciB0byBtb2RpZnkgYWZ0ZXJ3YXJkcy4NCj4+Pj4+Pj4+PiBIb3cgYWJvdXQgdGhpcz8NCj4+ Pj4+Pj4+PiAvKg0KPj4+Pj4+Pj4+ICogTGlzdCBvZiBwb3NzaWJsZSBmZWF0dXJlcyBmb3IgZG9t MGxlc3MgZG9tVXMNCj4+Pj4+Pj4+PiAqDQo+Pj4+Pj4+Pj4gKiBET00wTEVTU19FTkhBTkNFRF9C QVNJQzogWGVuIFBWIGludGVyZmFjZXMsIGluY2x1ZGluZyBncmFudC10YWJsZSBhbmQNCj4+Pj4+ Pj4+PiAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGV2dGNobiwgd2lsbCBiZSBlbmFibGVkIGZvciB0aGUgVk0uDQo+Pj4+Pj4+PiANCj4+ Pj4+Pj4+IFRlY2huaWNhbGx5LCB0aGUgZ3Vlc3QgY2FuIGFscmVhZHkgdXNlIHRoZSBncmFudC10 YWJsZSBhbmQgZXZ0Y2huIGludGVyZmFjZXMuIFRoaXMgYWxzbyByZWFkcyBxdWl0ZSBvZGQgdG8g bWUgYmVjYXVzZSAiaW5jbHVkaW5nIiBkb2Vzbid0IHRlbGwgd2hhdCdzIG5vdCBlbmFibGVkLiBT byBvbmUgY291bGQgYXNzdW1lIFhlbnN0b3JlZCBpcyBhbHNvIGVuYWJsZWQuIEluIGZhY3QgdGhl IHdvcmRpbmcgZm9yIGBgRE9NMExFU1NfRU5IQU5DRURgYCBpcyB3aGF0IG1ha2VzIGl0IGEgbG90 IG1vcmUgY29uZnVzaW5nLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBTbyBJIHdvdWxkIHN1Z2dlc3Qg dGhlIGZvbGxvd2luZyB3b3JkaW5nOg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiAiTm90aWZ5IHRoZSBP UyBpdCBpcyBydW5uaW5nIG9uIHRvcCBvZiBYZW4uIEFsbCB0aGUgZGVmYXVsdCBmZWF0dXJlcyBi dXQgWGVuc3RvcmUgd2lsbCBiZSBhdmFpbGFibGUuIE5vdGUgdGhhdCBhbiBPUyAqbXVzdCogbm90 IHJlbHkgb24gdGhlIGF2YWlsYWJpbGl0eSBvZiBYZW4gZmVhdHVyZXMgaWYgdGhpcyBpcyBub3Qg c2V0Lg0KPj4+Pj4+Pj4gIg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBUaGUgd29yZGluZyBjYW4gYmUg dXBkYXRlZCBvbmNlIHdlIHByb3Blcmx5IGRpc2FibGUgZXZlbnQgY2hhbm5lbC9ncmFudCB0YWJs ZSB3aGVuIHRoZSBmbGFnIGlzIG5vdCBzZXQuDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+PiAqIERPTTBM RVNTX1hFTlNUT1JFOiAgICAgICAgICAgICAgWGVuc3RvcmUgd2lsbCBiZSBlbmFibGVkIGZvciB0 aGUgVk0uDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IEkgd291bGQgbWFrZSBjbGVhciB0aGlzIGNhbid0 IGJlIHVzZWQgd2l0aG91dCB0aGUgZmlyc3Qgb25lLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4gKiBE T00wTEVTU19FTkhBTkNFRDogICAgICAgICAgICAgIFhlbiBQViBpbnRlcmZhY2VzLCBpbmNsdWRp bmcgZ3JhbnQtdGFibGUgeGVuc3RvcmUgPiAgICogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5kDQo+Pj4+Pj4+PiBldnRjaG4sIHdpbGwg YmUgZW5hYmxlZCBmb3IgdGhlIFZNLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBTZWUgYWJvdmUgYWJv dXQgIlBWIGludGVyZmFjZXMiLiBTbyBJIHdvdWxkIHN1Z2dlc3QgdG8gcmV3b3JkIHRvOg0KPj4+ Pj4+Pj4gDQo+Pj4+Pj4+PiAiTm90aWZ5IHRoZSBPUyBpdCBpcyBydW5uaW5nIG9uIHRvcCBvZiBY ZW4uIEFsbCB0aGUgZGVmYXVsdCBmZWF0dXJlcyAoaW5jbHVkaW5nIFhlbnN0b3JlKSB3aWxsIGJl IGF2YWlsYWJsZSIuDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+PiAqLw0KPj4+Pj4+Pj4+ICNkZWZpbmUg RE9NMExFU1NfRU5IQU5DRURfQkFTSUMgQklUKDAsIFVMKQ0KPj4+Pj4+Pj4+ICNkZWZpbmUgRE9N MExFU1NfWEVOU1RPUkUgICAgICAgQklUKDEsIFVMKQ0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBCYXNl ZCBvbiB0aGUgY29tbWVudCBhYm92ZSwgSSB3b3VsZCBjb25zaWRlciB0byBkZWZpbmUgRE9NMExF U1NfWEVOU1RPUkUgYXMgYml0IDAgYW5kIDEgc2V0Lg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4gI2Rl ZmluZSBET00wTEVTU19FTkhBTkNFRCAgICAgICAoRE9NMExFU1NfRU5IQU5DRURfQkFTSUMgfCBE T00wTEVTU19YRU5TVE9SRSkNCj4+Pj4+Pj4gQmVydHJhbmQgYW5kIEkgZGlzY3Vzc2VkIHRoaXMg YWdhaW4gd2UgY2FtZSB0byB0aGUgY29uY2x1c2lvbiB0aGF0IERPTTBMRVNTX0VOSEFOQ0VEX0JB U0lDIGlzIG5vdA0KPj4+Pj4+PiB0aGUgc3VpdGFibGUgbmFtZSBhcyB0aGlzIG1ha2VzIHRoZSBj b2RlIHVuY2xlYXIgYW5kIGRvZXMgbm90IGNvcnJlc3BvbmQgdG8gRFQgc2V0dGluZ3MuIFdlIHBy b3Bvc2UgdGhpcw0KPj4+Pj4+PiBwbGVhc2UgbGV0IG1lIGtub3cgeW91ciB0aG91Z2h0cy4NCj4+ Pj4+PiANCj4+Pj4+PiBUbyBtZSB0aGUgZGVmYXVsdCBvZiAiZW5oYW5jZWQiIHNob3VsZCBiZSBh bGwgWGVuIGZlYXR1cmVzLiBBbnl0aGluZyBlbHNlIHNob3VsZCBiZSBjb25zaWRlciBhcyByZWR1 Y2VkL2Jhc2ljL21pbmltdW0uIEhlbmNlIHdoeSBJIHN0aWxsIHRoaW5rIHdlIG5lZWQgdG8gYWRk IGl0IGluIHRoZSBuYW1lIGV2ZW4gaWYgdGhpcyBpcyBub3Qgd2hhdCB3ZSBleHBvc2UgaW4gdGhl IERULiBJbiBmYWN0Li4uDQo+Pj4+Pj4+IC8qDQo+Pj4+Pj4+ICogTGlzdCBvZiBwb3NzaWJsZSBm ZWF0dXJlcyBmb3IgZG9tMGxlc3MgZG9tVXMNCj4+Pj4+Pj4gKg0KPj4+Pj4+PiAqIERPTTBMRVNT X1hFTlNUT1JFOiAgICAgICAgICAgICAgWGVuc3RvcmUgd2lsbCBiZSBlbmFibGVkIGZvciB0aGUg Vk0uIFRoaXMgZmVhdHVyZQ0KPj4+Pj4+PiAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNhbid0IGJlIGVuYWJsZWQgd2l0aG91dCB0aGUgRE9NMExFU1Nf RU5IQU5DRUQuDQo+Pj4+Pj4+ICogRE9NMExFU1NfRU5IQU5DRUQ6ICAgICAgICAgICAgICBOb3Rp ZnkgdGhlIE9TIGl0IGlzIHJ1bm5pbmcgb24gdG9wIG9mIFhlbi4gQWxsIHRoZQ0KPj4+Pj4+PiAq ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGVmYXVsdCBmZWF0dXJlcyAoaW5jbHVkaW5nIFhlbnN0b3JlKSB3aWxsIGJlDQo+Pj4+Pj4+ICog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBh dmFpbGFibGUuIE5vdGUgdGhhdCBhbiBPUyAqbXVzdCogbm90IHJlbHkgb24gdGhlDQo+Pj4+Pj4+ ICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhdmFpbGFiaWxpdHkgb2YgWGVuIGZlYXR1cmVzIGlmIHRoaXMgaXMgbm90IHNldC4NCj4+Pj4+ PiANCj4+Pj4+PiAuLi4gd2hhdCB5b3Ugd3JvdGUgaGVyZSBtYXRjaCB3aGF0IEkgd3JvdGUgYWJv dmUuIFNvIGl0IGlzIG5vdCBjbGVhciB0byBtZSB3aGF0J3MgdGhlIHBvaW50IG9mIGhhdmluZyBh IGZsYWcgRE9NMExFU1NfWEVOU1RPUkUuDQo+Pj4+PiBXaGVuIHdlIGxvb2tlZCBhdCB0aGUgY29k ZSB3aXRoIHRoZSBzb2x1dGlvbiB1c2luZyBCQVNJQywgaXQgd2FzIHJlYWxseSBub3QgZWFzeSB0 byB1bmRlcnN0YW5kLg0KPj4+PiANCj4+Pj4gSSBkb24ndCBxdWl0ZSB1bmRlcnN0YW5kIGhvdyB0 aGlzIGlzIGRpZmZlcmVudCBmcm9tIEVOSEFOQ0VELCBFTkhBTkNFRF9GVUxMLiBJbiBmYWN0LCB3 aXRob3V0IGxvb2tpbmcgYXQgdGhlIGRvY3VtZW50YXRpb24sIHRoZXkgbWVhbiBleGFjdGx5IHRo ZSBzYW1lLi4uDQo+Pj4+IA0KPj4+PiBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVuICJCQVNJQyIgYW5k ICJFTkhBTkNFRCIgaXMgY2xlYXIuIFlvdSBrbm93IHRoYXQgaW4gb25lIGNhc2UsIHlvdSB3b3Vs ZCBnZXQgbGVzcyB0aGFuIHRoZSBvdGhlci4NCj4+Pj4gDQo+Pj4+PiBCeSB0aGUgd2F5IHRoZSBj b21tZW50IGlzIHdyb25nIGFuZCBjb3JyZXNwb25kIHRvIHdoYXQgc2hvdWxkIGJlIEVOSEFOQ0VE X0ZVTEwgaGVyZQ0KPj4+Pj4gRU5IQU5DRUQgd291bGQgYmUgdGhlIGJhc2Ugd2l0aG91dCBYZW5z dG9yZS4NCj4+Pj4gDQo+Pj4+IFRoYW5rcyBmb3IgdGhlIGNvbmZpcm1hdGlvbi4gSSBhbSBhZnJh aWQsIEkgYW0gc3Ryb25nbHkgYWdhaW5zdCB0aGUgdGVybWlub2xvZ3kgeW91IHByb3Bvc2VkIChz ZWUgYWJvdmUgd2h5KS4NCj4+Pj4gDQo+Pj4+IEkgdGhpbmsgQkFTSUMgKG9yIHNpbWlsYXIgbmFt ZSkgaXMgYmV0dGVyLiBCdXQgSSBhbSBvcGVuIHRvIHN1Z2dlc3Rpb24gc28gbG9uZyBpdCBpcyBu b3QgIkRPTTBMRVNTX0VOSEFOQ0VEIiB2cyAiRE9NMExFU1NfRU5IQU5DRURfRlVMTCIuDQo+Pj4g DQo+Pj4gSSBkbyBub3QgYWdyZWUgYnV0IEkgdGhpbmsgdGhpcyBpcyBvbmx5IGludGVybmFsIGFu ZCBjb3VsZCBlYXNpbHkgYmUgbW9kaWZpZWQgb25lIGRheSBpZiB3ZSBoYXZlIG1vcmUgdXNlLWNh c2VzLg0KPj4+IFNvIGxldOKAmXMgZ28gZm9yIEJBU0lDIGFuZCB1bmJsb2NrIHRoaXMgYmVmb3Jl IHRoZSBmZWF0dXJlIGZyZWV6ZS4NCj4+PiANCj4+PiBCZXJ0cmFuZA0KPj4gDQo+PiBQbGVhc2Ug aGF2ZSBhIGxvb2sgb25jZSBpZiB0aGlzIGxvb2tzIG9rYXkuDQo+PiANCj4+IC8qICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgDQo+PiAqIExpc3Qgb2YgcG9zc2libGUgZmVhdHVyZXMgZm9yIGRvbTBsZXNz IGRvbVVzICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQo+PiAqICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgDQo+PiAqIERPTTBMRVNTX0VOSEFOQ0VEX0JBU0lDOglOb3RpZnkgdGhlIE9TIGl0 IGlzIHJ1bm5pbmcgb24gdG9wIG9mIFhlbi4gQWxsIHRoZSAgDQo+PiAqICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAlkZWZhdWx0IGZlYXR1 cmVzIChleGNsdWRpbmcgWGVuc3RvcmUpIHdpbGwgYmUgICAgICAgDQo+PiAqICAgICAgICAgICAg ICAgICAgICAgICAgICAJCQkJCWF2YWlsYWJsZS4gTm90ZSB0aGF0IGFuIE9TICptdXN0KiBub3Qg cmVseSBvbiB0aGUgICANCj4+ICogICAgICAgICAgICAgICAgICAgICAgICAgIAkJCQkJYXZhaWxh YmlsaXR5IG9mIFhlbiBmZWF0dXJlcyBpZiB0aGlzIGlzIG5vdCBzZXQuICAgIA0KPj4gKiBET00w TEVTU19YRU5TVE9SRTogICAgICAgCQlYZW5zdG9yZSB3aWxsIGJlIGVuYWJsZWQgZm9yIHRoZSBW TS4gVGhpcyBmZWF0dXJlICAgDQo+PiAqICAgICAgICAgICAgICAgICAgICAgICAgICAJCQkJCWNh bid0IGJlIGVuYWJsZWQgd2l0aG91dCB0aGUgRE9NMExFU1NfRU5IQU5DRURfQkFTSUMuICAgICAg ICAgICAgICAgICAgICAgICAgICAgIA0KPj4gKiBET00wTEVTU19FTkhBTkNFRDoJCQlOb3RpZnkg dGhlIE9TIGl0IGlzIHJ1bm5pbmcgb24gdG9wIG9mIFhlbi4gQWxsIHRoZSAgDQo+PiAqICAgICAg ICAgICAgICAgICAgICAgICAgICAJCQkJCWRlZmF1bHQgZmVhdHVyZXMgKGluY2x1ZGluZyBYZW5z dG9yZSkgd2lsbCBiZSAgICAgICANCj4+ICogICAgICAgICAgICAgICAgICAgICAgICAgIAkJCQkJ YXZhaWxhYmxlLiBOb3RlIHRoYXQgYW4gT1MgKm11c3QqIG5vdCByZWx5IG9uIHRoZSAgIA0KPj4g KiAgICAgICAgICAgICAgICAgICAgICAgICAgCQkJCQlhdmFpbGFiaWxpdHkgb2YgWGVuIGZlYXR1 cmVzIGlmIHRoaXMgaXMgbm90IHNldC4gICAgDQo+PiAqLyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQo+ PiAjZGVmaW5lIERPTTBMRVNTX0VOSEFOQ0VEX0JBU0lDICAgICBCSVQoMCwgVUwpICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4gI2RlZmluZSBET00wTEVTU19YRU5TVE9SRSAg ICAgICAgICAgICAgICAgIEJJVCgxLCBVTCkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgDQo+PiAjZGVmaW5lIERPTTBMRVNTX0VOSEFOQ0VEICAgICAgICAgICAgICAgICAoRE9NMExF U1NfRU5IQU5DRURfQkFTSUMgIHwgIERPTTBMRVNTX1hFTlNUT1JFKQ0KPiANCj4gTGV0IG1lIGhh dmUgYSBjaGFuY2UgdG8gcHJvcG9zZSBhIG5hbWluZyBzY2hlbWUgYXMgd2VsbCA6LSkNCj4gDQo+ IEkgYWdyZWUgd2l0aCBKdWxpZW46IEkgcHJlZmVyIHRoaXMgcHJvcG9zYWwgY29tcGFyZWQgdG8g dGhlIGVhcmxpZXIgb25lDQo+IGJ5IEJlcnRyYW5kIGFuZCBSYWh1bCBiZWNhdXNlIEkgdGhpbmsg aXQgaXMgYSBsb3QgY2xlYXJlciBhbmQgIkVOSEFOQ0VEIg0KPiBzaG91bGQgbWVhbiBldmVyeXRo aW5nLiBBbHNvLCBpdCBtYWtlcyBpdCBlYXNpZXIgZnJvbSBhIGNvbXBhdGliaWxpdHkNCj4gcGVy c3BlY3RpdmUgYmVjYXVzZSBpdCBtYXRjaGVzIHRoZSBjdXJyZW50IGRlZmluaXRpb24uDQo+IA0K PiBCdXQgSSBhbHNvIGFncmVlIHdpdGggQmVydHJhbmQgdGhhdCAiQkFTSUMiIGRvZXNuJ3Qgc291 bmQgbmljZS4gSSB0aGluaw0KPiB3ZSBzaG91bGQga2VlcCAiRE9NMExFU1NfRU5IQU5DRUQiIGFu ZCAiRE9NMExFU1NfWEVOU1RPUkUiIGFzIHN1Z2dlc3RlZA0KPiBoZXJlLCBidXQgcmVwbGFjZSAi RE9NMExFU1NfRU5IQU5DRURfQkFTSUMiIHdpdGggc29tZXRoaW5nIGJldHRlci4gU29tZQ0KPiBp ZGVhczoNCj4gDQo+IC0gRE9NMExFU1NfRU5IQU5DRURfTElNSVRFRA0KPiAtIERPTTBMRVNTX0VO SEFOQ0VEX01JTkkNCg0KUGVyc29uYWxseSBJIGRvIG5vdCBmaW5kIHRob3NlIG1vcmUgY2xlYXIg dGhlbiBCQVNJQw0KDQo+IC0gRE9NMExFU1NfRU5IQU5DRURfTk9fWFMNCg0KVGhpcyBoYXMgdGhl IHByb2JsZW0gdG8gYmUgdHJ1ZSBub3cgYnV0IHdvdWxkIG5lZWQgcmVuYW1pbmcgaWYgd2UgaW50 cm9kdWNlIGEgZGVmaW5pdGlvbiBmb3IgYW4gb3RoZXIgYml0Lg0KDQo+IC0gRE9NMExFU1NfRU5I QU5DRURfR05UX0VWVENITg0KDQpJIHdvdWxkIHZvdGUgZm9yIHRoaXMgb25lIGFzIGl0IGV4cGxp Y2l0bHkgc3RhdGUgd2hhdCBpcyBpbiBzbyB0aGUgYml0c2V0IHN5c3RlbSBpcyBldmVuIG1vcmUg bWVhbmluZ2Z1bC4NCg0KPiANCj4gQW55IG9mIHRoZXNlIGFyZSBiZXR0ZXIgdGhhbiBCQVNJQyBm cm9tIG15IHBvaW50IG9mIHZpZXcuIE5vdyBJIGFtIG9mZg0KPiB0byBnZXQgdGhlIGdyZWVuIHBh aW50IGZvciBteSBzaGVkLg0KDQpIYXZlIGZ1biA7LSkNCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQoN Cg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:28:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:28:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399520.640711 (Exim 4.92) (envelope-from ) id 1oVT00-0004lI-OM; Tue, 06 Sep 2022 07:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399520.640711; Tue, 06 Sep 2022 07:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVT00-0004lB-LK; Tue, 06 Sep 2022 07:27:56 +0000 Received: by outflank-mailman (input) for mailman id 399520; Tue, 06 Sep 2022 07:27:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVSzy-0004l5-Kq for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:27:54 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a1573a9-2db5-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:27:51 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id q21so6296364edc.9 for ; Tue, 06 Sep 2022 00:27:53 -0700 (PDT) Received: from leoy-huanghe.lan ([104.245.99.30]) by smtp.gmail.com with ESMTPSA id bd13-20020a056402206d00b0044e66ee9b62sm4352880edb.42.2022.09.06.00.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 00:27:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a1573a9-2db5-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=r97Hr2tIjhJhFdhmIL0iyamjWyuw56fyzIW/bYy/ves=; b=nj37FT9i8EAIVCZna21mXMP+De91OIM3128LkxFzo9+3RJu4WhovL6P/uhLXEDYS0+ GoWnF82Y93/qRsY4r1WnCYaTMB1R1vWKhaV9C7ceC0aYApcj46OI5Zzsu+fb1JFSM708 g0R+oECRFy64aOrlIURD4S3exqjvK4J9EMH+9veWtHO5ByPsv3+Bgcw3tEzwsoVu69Z3 tn3agyPiBp6A6IOXueVToB8ZHlCy3It6C/kJpJw35UYVALktZlEeFNbHhZwv5D38Opd3 F35CdCeFLFA4e9Nrrqnn5kXlGFNer1wiqT5sJTj4kwmlcOE/jAkRT38Q3C7x2mW0Ec5u d88w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=r97Hr2tIjhJhFdhmIL0iyamjWyuw56fyzIW/bYy/ves=; b=QiC1Hfglhx4xnxKXxkM5vBUZGaQ5h2AQ7LpNDg1E/zleH8ckEUpUAPH3CMqTeKOjgA VFb1NcGg234NANFt+ebqt9gHIrAbbFjfktfVv1XPFTdro1MzDjaYsABRgS3iny9zsW72 4MzDJmtozL8h09BSmgGiuVfhTh3j5+ZLofJd545jxP7p3KN2y8u/u0PlDlWMZp0ZmCIc wAkaoNd4UisOVqc3MnSyp0F//oVrmU+LYwoYsdI5n60PPw1tqM4EKJtBAmUfGu2CwRdc rBItLUDCSmlnQ3WgLCXX/ITcLyzDwkZNm+Co0Q9fnTGZln1C1tn+RfiRu+eecsp33sr4 5hhA== X-Gm-Message-State: ACgBeo1vmCtkwgZ7kfYey75e039h6sTyByLJvGiuUSsCEPYBXUVPLs8v aYQ7qf1UHpIG1904OBE1cDLLIA== X-Google-Smtp-Source: AA6agR4m9A61zk+lILhAE2bAfwnJhWShz293gbKx4fxg9D6A03n23xPygakWw1BdFf+yz/ig9/qZcA== X-Received: by 2002:aa7:d98c:0:b0:44e:affc:7000 with SMTP id u12-20020aa7d98c000000b0044eaffc7000mr4439480eds.269.1662449272818; Tue, 06 Sep 2022 00:27:52 -0700 (PDT) Date: Tue, 6 Sep 2022 15:27:47 +0800 From: Leo Yan To: Ard Biesheuvel Cc: Marc Zyngier , Julien Grall , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table Message-ID: References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 06, 2022 at 09:22:00AM +0200, Ard Biesheuvel wrote: [...] > > IIUC, you consider the general flow from architecture view, so you prefer > > to ask Xen to implement EFI stub to comply the general flow for EFI > > booting sequence, right? > > > > If the conclusion is to change Xen for support EFI stub, then this > > would be fine for me and I will hold on and leave Xen developers to work > > on it. > > > > As I mentioned before, proper EFI boot support in Xen would be nice. > *However*, I don't think it makes sense to go through all the trouble > of implementing that just to shut up a warning that doesn't affect Xen > to begin with. Another option is we can set a bit for xen feature, so Linux kernel can read out the xen feature and make decision if need to reserve memory for RD tables based on the new feature bit. This is somehow a solution is to create a general protocol between Xen and Linux kernel. How about you think for this? Thanks, Leo From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:30:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:30:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399442.640722 (Exim 4.92) (envelope-from ) id 1oVT2S-0006Wj-4V; Tue, 06 Sep 2022 07:30:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399442.640722; Tue, 06 Sep 2022 07:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVT2S-0006Wc-1O; Tue, 06 Sep 2022 07:30:28 +0000 Received: by outflank-mailman (input) for mailman id 399442; Tue, 06 Sep 2022 07:09:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVShx-0005zG-Vq for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:09:18 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-westcentralusazlp170100000.outbound.protection.outlook.com [2a01:111:f403:c112::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d09e7e7e-2db2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:09:16 +0200 (CEST) Received: from PH0PR05MB8703.namprd05.prod.outlook.com (2603:10b6:510:bd::5) by DM6PR05MB4970.namprd05.prod.outlook.com (2603:10b6:5:31::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5; Tue, 6 Sep 2022 07:09:11 +0000 Received: from PH0PR05MB8703.namprd05.prod.outlook.com ([fe80::95af:33a4:b350:c335]) by PH0PR05MB8703.namprd05.prod.outlook.com ([fe80::95af:33a4:b350:c335%8]) with mapi id 15.20.5612.012; Tue, 6 Sep 2022 07:09:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d09e7e7e-2db2-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dY1wPXHnrMEnxZciiGfS4XSgRUh/IXWahcmOFtN/+OdybMsqd+W9x/lxWaIUsqZoTHsH4rsItI3kf/WVJyG9N4L1/3650PE0b5ekY7q7/TkyYk1kaFTRV71pcqZg0cYrsNOH50wqJfo+3oaq1+hLEdabZ+g0ZXt8ot9tZR/4nLnlzrX7nNcByzU06t59VYkKLaeR5Ca7notRErd3djgctnEd0RhZjM82yjSahbJ+wXD8lh6GP3XvVrWWQZ0NK6ie5ynRxZ4jtoffE5znaOCBXc1E5adrXc9H20HBkP+h+M2P4AsoPbXJZVz0STnp89ZuoKucMcF56QktfLboXeanuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tVqjBGkFgXrs31AA2OHw7MU01gBpvRs6t5y6CM6f2Tg=; b=lOjDBVufiEWaMCHFThqVBpo69/Ca31qNmAVV5ydA1N/za1AnL70f597eaeTUBLXh7c5GOQ8Cx1iP3NgeHOT/gpLn9pkmeyCzmcVRxIDxq3GRLtBeaYyTT+bQZt4vVfZGcjnMHn5XMX5nisIerqCYxNqztaQBm686q3OA1EwFNuEh4Uo0fxQoJN1wvBrLQcVSnIaEJZLsd+aYS94sZ8qLcjGPPwAKg/8L83hf9DmRz+kTHdVJEaVbrIdJxk9/TIuA21lA8Db30Mp7jWNW0m40fbeWAT4dB4iZbyzWe270UXcfEKsTJfKpSGMP7n8rD821EzIvoB4/5Vw7pE3xM0srww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tVqjBGkFgXrs31AA2OHw7MU01gBpvRs6t5y6CM6f2Tg=; b=zn+MsRJlDS55rB9koppwTf9JIKLqRyfwc9/3fsa+EyQq1LsG/Ej88qKLWxqlQ9HMBg9TQdzHm5bHYB8dNb5HZ77UVn+5BWw2vEp6rM6MeB/yDVsMEcgd9VZRx+u8GRb4FhMwPCoBW+1jbfjxu8akK3rfxsEI3r68Bek3vxInxPI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; From: Ajay Kaher To: helgaas@kernel.org, bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: x86@kernel.org, hpa@zytor.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, srivatsab@vmware.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, vsirnapalli@vmware.com, er.ajay.kaher@gmail.com, willy@infradead.org, namit@vmware.com, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, jailhouse-dev@googlegroups.com, xen-devel@lists.xenproject.org, acrn-dev@lists.projectacrn.org Subject: [PATCH v2] x86/PCI: Prefer MMIO over PIO on VMware hypervisor Date: Tue, 6 Sep 2022 12:38:37 +0530 Message-Id: <1662448117-10807-1-git-send-email-akaher@vmware.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR05CA0061.namprd05.prod.outlook.com (2603:10b6:a03:74::38) To PH0PR05MB8703.namprd05.prod.outlook.com (2603:10b6:510:bd::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR05MB8703:EE_|DM6PR05MB4970:EE_ X-MS-Office365-Filtering-Correlation-Id: 361688ab-6f30-4422-58aa-08da8fd6b2f1 X-LD-Processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rpEmG/ZTZD41ci8rzga319nfcfWs6F4whtCEkJI1igtHShj/5o1VLFdArTGqtjMdJUQ3j1333o5vV/Px1O0GG2Uj3zj4cq7EBbEGguwtuYnG5WIzK014XG1a0SNRRgHxy+QGhgx78DPW/4hP/rPKdkm46Fq32f/JlnYXfu9fAgz3YWw6gWVRZ1uLE9Wk41ANTglPoqfvyd1FcExNpN3JePJe4sH7NLghX6okgRdiytGbNtziY91ftsvWi29UMKDMINRi6zUmWJZpuv5MPmedTsHEu0m1L1QttboRINoi06f0XUdZXfLYw5MTbIsktHtLW33/6Y46vb4nt2jCe269qOC9cXOy4nQHmZTBL7j4jq4mYUEtRuiKN51HVsLHxts5DVJxTmG3pK/89SJKCisLEDJ6zIC/ib/p3bZ2vvQyJKUfxzcfkErOwElh4SEXu5yJ7swQ8PiEghfIm0g2kc8nFLG3skw8+p01cV3BkoKkxArc7qtWQUDYczpG+TJEs+gZXNp2TfgFvX69zGcuhV16L05T83k9fi5MHBweme39oWZYLD1PXSJ4DBHvkTEXmMrK+OPt6NjIbuCdWOty8rltMwG+zYD4+ZaCzZobICxj/++mWLqADs7AixCOHeN9sNIplsC374NGmwCnH1vmWGSVj29LORst5AuIwRxWUKbF92Q4ee4VRAjEGZOlb+Qd5wTOhuAtFMiJrTWcvOMzkK/VbE/ocOYSloUCw7SUZd4AUcgfrKYFhnkJgpTdnwMIh3oVz6eR6dz2TT9zucNl6YOmTGKhfQFshJnL4y0VEi1NzK3XWey4TwqPevATsZhAuBHb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8703.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(38350700002)(38100700002)(4326008)(8676002)(66946007)(66556008)(66476007)(316002)(2906002)(7416002)(26005)(5660300002)(8936002)(6512007)(52116002)(83380400001)(2616005)(186003)(6666004)(41300700001)(6486002)(6506007)(86362001)(36756003)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmthdHdLNFUwaVhQU08zS2ZzaUQwd3ppUUpKM3BFeVVnTDZYTzRjZGQ5NHcy?= =?utf-8?B?Y0kyRWhmVkY3dTZyd1VnWVEyNkNBM3VnU1ZvZE1ZMmFTWDM5Q2l0dGs1WWk0?= =?utf-8?B?UU5zWTVGMU1ianJsdldkNHk2elk0K0xHcEZEWXNrQndlZFV1cmhyeHhVcGhR?= =?utf-8?B?NjRjQnh2MUhkKzRFSThZT093M0U1MUR3OVZhUkFTWmdaSTg1SmUrT3EzYWpz?= =?utf-8?B?cE9oaUdJWjZtb2IrZ1h6SERzSDI2Ni9oaGVaNHBIS1RRNC9YNHAyamNSSjIw?= =?utf-8?B?cHpNaXpsU25RaFJBY0lZcGFkS2JIU2xDNFdvSHpWTjJVcVJsMmZURHBNSWJU?= =?utf-8?B?NjI0NVFSS0NyOGFBdWdBU1pQRTB6eDZZdG1HbzRUdjZQZWVFWExxVlBaMklB?= =?utf-8?B?L3gyNDc5a1ZoczAraXc5d1E4ZDNPYkJhOG1FejNXMFBieEcrVG1zQzg3RkxZ?= =?utf-8?B?VWYxNFM3QnN2QkZTZEg4WWJuUXRrUHJYdTZwYy9GM2JjL1pLNTdtcW5JaVZn?= =?utf-8?B?RkRPTnQ0a1ptKzhuTDdldUhXWk9XNFdXSVpYTWpJSW8rdHBQcno5MEg0MzVX?= =?utf-8?B?bzk3RTBCazl1eFpyTGl0WHFvcnFTaGVqS1pSOUFGWE1KNm9CVWY4Y1hpRVJ3?= =?utf-8?B?VVoxZ1ZzaHliR0VNWW4xTGk3VHRLZnV0djVjVnJTRUUvUmJXNnVUZnpBNGQv?= =?utf-8?B?bEY5QWZQNzRYc2JRdzhQUDNYY2xyVHhJQWsyb1o0QzQ2YlBma3JWUy8rZzdu?= =?utf-8?B?ZGMycC9YRjZTTGsrKzVaTGVaRmIvRlNiaVl0SGVrckRoY2R5cndpVjFoZ2k1?= =?utf-8?B?N3RSQmFBSEpNR2s4QnoySVNOdGFFR0VnOEFTOTB6Q01tZWF4bFRwRTZwaFdv?= =?utf-8?B?Zkl1ZzRNZXZiNS8rSHFESmpZMSt1bUEzUExKUUtPRFpQUzNkaWFQaDUvQnFE?= =?utf-8?B?WXNJa1ZGcndETUkzTmgxem1QUlJWMDhOb2k1R0xTNytwWmh4cXo5d0xvcW9k?= =?utf-8?B?enVhVFFPcndROGliRHlOaXMzdUZiSmFyNFZ3dVptbW82dWg1Q0N6NFNXeHFx?= =?utf-8?B?NHFMazJuSHR5QU8xNXUrNThURTQxV2YzcHFJMWhSN2w5TlV6RklscVVQSTBX?= =?utf-8?B?bUN0aytXbjV4cnpSWDkweXhNOW02UTNMdHZSSFJxN1Z4QmFyQ3FnMFo4bU1i?= =?utf-8?B?c2NVeEp5NlBJR2xlemJ0U2xtUUl1S3RUOG90VUgxck1OeGU4RVZHL2RXL3hJ?= =?utf-8?B?T2duVnJOTWE0Wmt5aUNEYlhWZ1A0Sm4yL3JXdWFiYU9VVGhTUU5iQ2hORUVG?= =?utf-8?B?QWNueGlEVGZsOHpwVnU1cTZQRTZET3l4Z2VaY3VKQy8vRE9Hd2gxaU1HYzIr?= =?utf-8?B?OGMrNHhVOTJETkFxUkpyT2hlSEZqT1ZFeHpFTGxpb0pkSG9tWXA0cHpxcEIv?= =?utf-8?B?NmFiZzVYaWYxM212L01YRFJVR1NiZVNaaTFrOUlUcjk1ZDgzRE00ZWRKazVm?= =?utf-8?B?TTBHeFBqb1ArMEMzSHNOWUlHYmxPM3Z0TlRLUGxoNDNkd3BjWjc1M1NrN2U0?= =?utf-8?B?VjFuK1JYQWt4ZWphSU90TWxIYmhLVGpoWTlpSlhrbWNrWjVWSWllemIzMVF0?= =?utf-8?B?ZnFqcVJ6alFhWVhvVE1DUlE5TmJYWndzc3l2cW1VNVJQSVNhZXNlR3FkVW9k?= =?utf-8?B?WnY2aTRjbWNiZmdVNWlvS3dMdXhndVZxYU13ZEQvc2hLSDFnWG9sZXpDTVB0?= =?utf-8?B?V1FtUHBTcy9RNHRNbzBkSWlENk9CWGFoUjVYWXRWa2hzWkdCeEtnNFhKSjJ2?= =?utf-8?B?VEMxT0Z3QXEySTBjZmppRTBOVlpHQjhKL2VEd3lSY2I2SmpyejRRRElOKzR4?= =?utf-8?B?eHRRZWwwZG1zcHRobDhOVkNIL3dEWGtUSlZ5ZDhEQXFlRG9rY05BR2NhYjVM?= =?utf-8?B?WWpQbUlsckhyb1NZRGxrVXlhTHBzYktvQTVzeWc0MG9JMUg3QzBFVW9qaTJ3?= =?utf-8?B?eTVOUVZjQnI1VmJwQjZIQ1M2YVpVTVA3MW9GWnM2eW1MZ0p0dmUzSzFmZzY1?= =?utf-8?B?ckdBY0FibkhWUHVydFFZVFhtTDZLZDV6emQ0SE5UZVBRVFFBSHdWRDV5ZDh0?= =?utf-8?Q?3d+euH4uv/iBa1JTsHAqiuoX8?= X-OriginatorOrg: vmware.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB4970 During boot-time there are many PCI config reads, these could be performed either using Port IO instructions (PIO) or memory mapped I/O (MMIO). PIO are less efficient than MMIO, they require twice as many PCI accesses and PIO instructions are serializing. As a result, MMIO should be preferred when possible over PIO. Virtual Machine test result using VMware hypervisor 1 hundred thousand reads using raw_pci_read() took: PIO: 12.809 seconds MMIO: 8.517 seconds (~33.5% faster then PIO) Currently, when these reads are performed by a virtual machine, they all cause a VM-exit, and therefore each one of them induces a considerable overhead. This overhead can be further improved, by mapping MMIO region of virtual machine to memory area that holds the values that the “emulated hardware” is supposed to return. The memory region is mapped as "read-only” in the NPT/EPT, so reads from these regions would be treated as regular memory reads. Writes would still be trapped and emulated by the hypervisor. Virtual Machine test result with above changes in VMware hypervisor 1 hundred thousand read using raw_pci_read() took: PIO: 12.809 seconds MMIO: 0.010 seconds This helps to reduce virtual machine PCI scan and initialization time by ~65%. In our case it reduced to ~18 mSec from ~55 mSec. MMIO is also faster than PIO on bare-metal systems, but due to some bugs with legacy hardware and the smaller gains on bare-metal, it seems prudent not to change bare-metal behavior. Signed-off-by: Ajay Kaher --- v1 -> v2: Limit changes to apply only to VMs [Matthew W.] --- arch/x86/pci/common.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index ddb7986..1e5a8f7 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -20,6 +20,7 @@ #include #include #include +#include unsigned int pci_probe = PCI_PROBE_BIOS | PCI_PROBE_CONF1 | PCI_PROBE_CONF2 | PCI_PROBE_MMCONF; @@ -57,14 +58,58 @@ int raw_pci_write(unsigned int domain, unsigned int bus, unsigned int devfn, return -EINVAL; } +#ifdef CONFIG_HYPERVISOR_GUEST +static int vm_raw_pci_read(unsigned int domain, unsigned int bus, unsigned int devfn, + int reg, int len, u32 *val) +{ + if (raw_pci_ext_ops) + return raw_pci_ext_ops->read(domain, bus, devfn, reg, len, val); + if (domain == 0 && reg < 256 && raw_pci_ops) + return raw_pci_ops->read(domain, bus, devfn, reg, len, val); + return -EINVAL; +} + +static int vm_raw_pci_write(unsigned int domain, unsigned int bus, unsigned int devfn, + int reg, int len, u32 val) +{ + if (raw_pci_ext_ops) + return raw_pci_ext_ops->write(domain, bus, devfn, reg, len, val); + if (domain == 0 && reg < 256 && raw_pci_ops) + return raw_pci_ops->write(domain, bus, devfn, reg, len, val); + return -EINVAL; +} +#endif /* CONFIG_HYPERVISOR_GUEST */ + static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *value) { +#ifdef CONFIG_HYPERVISOR_GUEST + /* + * MMIO is faster than PIO, but due to some bugs with legacy + * hardware, it seems prudent to prefer MMIO for VMs and PIO + * for bare-metal. + */ + if (!hypervisor_is_type(X86_HYPER_NATIVE)) + return vm_raw_pci_read(pci_domain_nr(bus), bus->number, + devfn, where, size, value); +#endif /* CONFIG_HYPERVISOR_GUEST */ + return raw_pci_read(pci_domain_nr(bus), bus->number, devfn, where, size, value); } static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 value) { +#ifdef CONFIG_HYPERVISOR_GUEST + /* + * MMIO is faster than PIO, but due to some bugs with legacy + * hardware, it seems prudent to prefer MMIO for VMs and PIO + * for bare-metal. + */ + if (!hypervisor_is_type(X86_HYPER_NATIVE)) + return vm_raw_pci_write(pci_domain_nr(bus), bus->number, + devfn, where, size, value); +#endif /* CONFIG_HYPERVISOR_GUEST */ + return raw_pci_write(pci_domain_nr(bus), bus->number, devfn, where, size, value); } -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399535.640743 (Exim 4.92) (envelope-from ) id 1oVTBN-0007XV-6p; Tue, 06 Sep 2022 07:39:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399535.640743; Tue, 06 Sep 2022 07:39:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBN-0007XO-3o; Tue, 06 Sep 2022 07:39:41 +0000 Received: by outflank-mailman (input) for mailman id 399535; Tue, 06 Sep 2022 07:39:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBM-0007HG-1k for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:39:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 0fdbd0cc-2db7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:39:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A66D176A; Tue, 6 Sep 2022 00:39:44 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CDA833F73D; Tue, 6 Sep 2022 00:40:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fdbd0cc-2db7-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v12 1/6] xen: do not free reserved memory into heap Date: Tue, 6 Sep 2022 15:39:14 +0800 Message-Id: <20220906073919.941934-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> References: <20220906073919.941934-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pages used as guest RAM for static domain, shall be reserved to this domain only. So in case reserved pages being used for other purpose, users shall not free them back to heap, even when last ref gets dropped. This commit introduces a new helper free_domstatic_page to free static page in runtime, and free_staticmem_pages will be called by it in runtime, so let's drop the __init flag. Wrapper #ifdef CONFIG_STATIC_MEMORY around function declaration( free_staticmem_pages, free_domstatic_page, etc) is kinds of redundant, so we decide to remove it here. Signed-off-by: Penny Zheng Reviewed-by: Jan Beulich Reviewed-by: Julien Grall --- v12 changes: - no change --- v11 changes: - printing message ahead of the assertion, which should also be XENLOG_G_* kind of log level --- v10 changes: - let Arm keep #define PGC_static 0 private, with the generic fallback remaining in page_alloc.c - change ASSERT(d) to ASSERT_UNREACHABLE() to be more robust looking forward, and also add a printk() to log the problem - mention the the removal of #ifdef CONFIG_STATIC_MEMORY in commit message --- v9 changes: - move free_domheap_page into else-condition - considering scrubbing static pages, domain dying case and opt_scrub_domheap both donot apply to static pages. - as unowned static pages don't make themselves to free_domstatic_page at the moment, remove else-condition and add ASSERT(d) at the top of the function --- v8 changes: - introduce new helper free_domstatic_page - let put_page call free_domstatic_page for static page, when last ref drops - #define PGC_static zero when !CONFIG_STATIC_MEMORY, as it is used outside page_alloc.c --- v7 changes: - protect free_staticmem_pages with heap_lock to match its reverse function acquire_staticmem_pages --- v6 changes: - adapt to PGC_static - remove #ifdef aroud function declaration --- v5 changes: - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h --- v4 changes: - no changes --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - fix the indentation --- v2 changes: - new commit --- xen/arch/arm/include/asm/mm.h | 6 +++++- xen/arch/arm/mm.c | 5 ++++- xen/common/page_alloc.c | 40 ++++++++++++++++++++++++++++++++--- xen/include/xen/mm.h | 3 +-- 4 files changed, 47 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index da25251cda..749fbefa0c 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -121,9 +121,13 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Page is static memory */ +#ifdef CONFIG_STATIC_MEMORY +/* Page is static memory */ #define _PGC_static PG_shift(3) #define PGC_static PG_mask(1, 3) +#else +#define PGC_static 0 +#endif /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index c81c706c8b..7f5b317d3e 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1496,7 +1496,10 @@ void put_page(struct page_info *page) if ( unlikely((nx & PGC_count_mask) == 0) ) { - free_domheap_page(page); + if ( unlikely(nx & PGC_static) ) + free_domstatic_page(page); + else + free_domheap_page(page); } } diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index bfd4150be7..0c50dee4c5 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2694,12 +2694,14 @@ struct domain *get_pg_owner(domid_t domid) #ifdef CONFIG_STATIC_MEMORY /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub) +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) { mfn_t mfn = page_to_mfn(pg); unsigned long i; + spin_lock(&heap_lock); + for ( i = 0; i < nr_mfns; i++ ) { mark_page_free(&pg[i], mfn_add(mfn, i)); @@ -2710,9 +2712,41 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_static. */ pg[i].count_info |= PGC_static; } + + spin_unlock(&heap_lock); +} + +void free_domstatic_page(struct page_info *page) +{ + struct domain *d = page_get_owner(page); + bool drop_dom_ref; + + if ( unlikely(!d) ) + { + printk(XENLOG_G_ERR + "The about-to-free static page %"PRI_mfn" must be owned by a domain\n", + mfn_x(page_to_mfn(page))); + ASSERT_UNREACHABLE(); + return; + } + + ASSERT_ALLOC_CONTEXT(); + + /* NB. May recursively lock from relinquish_memory(). */ + spin_lock_recursive(&d->page_alloc_lock); + + arch_free_heap_page(d, page); + + drop_dom_ref = !domain_adjust_tot_pages(d, -1); + + spin_unlock_recursive(&d->page_alloc_lock); + + free_staticmem_pages(page, 1, scrub_debug); + + if ( drop_dom_ref ) + put_domain(d); } /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 35b065146f..deadf4b2a1 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,13 +85,12 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) -#ifdef CONFIG_STATIC_MEMORY /* These functions are for static memory */ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub); +void free_domstatic_page(struct page_info *page); int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); -#endif /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399534.640732 (Exim 4.92) (envelope-from ) id 1oVTBJ-0007HT-Vy; Tue, 06 Sep 2022 07:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399534.640732; Tue, 06 Sep 2022 07:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBJ-0007HM-TI; Tue, 06 Sep 2022 07:39:37 +0000 Received: by outflank-mailman (input) for mailman id 399534; Tue, 06 Sep 2022 07:39:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBI-0007HG-Ly for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:39:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 0d4519ba-2db7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:39:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B7591756; Tue, 6 Sep 2022 00:39:40 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id ED0623F7D8; Tue, 6 Sep 2022 00:39:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d4519ba-2db7-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v12 0/6] populate/unpopulate memory when domain on static allocation Date: Tue, 6 Sep 2022 15:39:13 +0800 Message-Id: <20220906073919.941934-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so they shall never go back to heap allocator. This patch serie intends to fix this issue, by adding pages on the new list resv_page_list after having taken them off the "normal" list, when unpopulating memory, and retrieving pages from resv page list(resv_page_list) when populating memory. --- v12 changes: - it should be acquire_domstatic_pages() calling unprepare_staticmem_pages() on failing - add in-code comment --- v11 changes: - printing message ahead of the assertion, which should also be XENLOG_G_* kind of log level - commit message tweak - move "xen: rename free_staticmem_pages to unprepare_staticmem_pages" ahead of "xen: retrieve reserved pages on populate_physmap" - with assignment having failed and the page not exposed to the guest at any point, there is no need for scrubbing --- v10 changes: - let Arm keep #define PGC_static 0 private, with the generic fallback remaining in page_alloc.c - change ASSERT(d) to ASSERT_UNREACHABLE() to be more robust looking forward, and also add a printk() to log the problem - mention the the removal of #ifdef CONFIG_STATIC_MEMORY in commit message - commit message typo fix - Do not skip the list addition in that one special case - add lock on the fail path - new commit "xen: rename free_staticmem_pages to unprepare_staticmem_pages" --- v9 changes: - move free_domheap_page into else-condition - considering scrubbing static pages, domain dying case and opt_scrub_domheap both do not apply to static pages. - as unowned static pages don't make themselves to free_domstatic_page at the moment, remove else-condition and add ASSERT(d) at the top of the function - remove macro helper put_static_page, and just expand its code inside free_domstatic_page - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page - Add free_staticmem_pages to undo prepare_staticmem_pages when assign_domstatic_pages fails - Remove redundant static in error message --- v8 changes: - introduce new helper free_domstatic_page - let put_page call free_domstatic_page for static page, when last ref drops - #define PGC_static zero when !CONFIG_STATIC_MEMORY, as it is used outside page_alloc.c - #ifdef-ary around is_domain_using_staticmem() is not needed anymore - order as a parameter is not needed here, as all staticmem operations are limited to order-0 regions - move d->page_alloc_lock after operation on d->resv_page_list - As concurrent free/allocate could modify the resv_page_list, we still need the lock --- v7 changes: - protect free_staticmem_pages with heap_lock to match its reverse function acquire_staticmem_pages - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore - add page on the rsv_page_list *after* it has been freed - remove the lock, since we add the page to rsv_page_list after it has been totally freed. --- v6 changes: - rename PGC_staticmem to PGC_static - remove #ifdef aroud function declaration - use domain instead of sub-systems - move non-zero is_domain_using_staticmem() from ARM header to common header - move PGC_static !CONFIG_STATIC_MEMORY definition to common header - drop the lock before returning --- v5 changes: - introduce three new commits - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes: - commit message refinement - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" - change name from "is_domain_static()" to "is_domain_using_staticmem" - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. - move #ifndef is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - change name from "is_domain_on_static_allocation" to "is_domain_static()" - put reserved pages on resv_page_list after having taken them off the "normal" list - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 - fix coding style Penny Zheng (6): xen: do not free reserved memory into heap xen/arm: introduce CDF_staticmem xen: unpopulate memory when domain is static xen: introduce prepare_staticmem_pages xen: rename free_staticmem_pages to unprepare_staticmem_pages xen: retrieve reserved pages on populate_physmap xen/arch/arm/domain_build.c | 5 +- xen/arch/arm/include/asm/mm.h | 6 +- xen/arch/arm/mm.c | 5 +- xen/arch/arm/setup.c | 3 +- xen/common/domain.c | 4 + xen/common/memory.c | 23 +++++ xen/common/page_alloc.c | 173 ++++++++++++++++++++++++++-------- xen/include/xen/domain.h | 8 ++ xen/include/xen/mm.h | 8 +- xen/include/xen/sched.h | 3 + 10 files changed, 192 insertions(+), 46 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:39:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:39:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399536.640755 (Exim 4.92) (envelope-from ) id 1oVTBR-0007qd-JD; Tue, 06 Sep 2022 07:39:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399536.640755; Tue, 06 Sep 2022 07:39:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBR-0007qW-Fb; Tue, 06 Sep 2022 07:39:45 +0000 Received: by outflank-mailman (input) for mailman id 399536; Tue, 06 Sep 2022 07:39:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBQ-0007HG-54 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:39:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 128107ba-2db7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:39:43 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04820139F; Tue, 6 Sep 2022 00:39:49 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 383BE3F73D; Tue, 6 Sep 2022 00:40:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 128107ba-2db7-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v12 2/6] xen/arm: introduce CDF_staticmem Date: Tue, 6 Sep 2022 15:39:15 +0800 Message-Id: <20220906073919.941934-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> References: <20220906073919.941934-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Signed-off-by: Penny Zheng Acked-by: Julien Grall Acked-by: Jan Beulich --- v12 changes: - no change --- v11 changes: - no change --- v10 changes: - no change --- v9 changes: - no change --- v8 changes: - #ifdef-ary around is_domain_using_staticmem() is not needed anymore --- v7 changes: - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore --- v6 changes: - move non-zero is_domain_using_staticmem() from ARM header to common header --- v5 changes: - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v4 changes: - no changes --- v3 changes: - change name from "is_domain_static()" to "is_domain_using_staticmem" --- v2 changes: - change name from "is_domain_on_static_allocation" to "is_domain_static() --- xen/arch/arm/domain_build.c | 5 ++++- xen/include/xen/domain.h | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..b76a84e8f5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3287,9 +3287,12 @@ void __init create_domUs(void) if ( !dt_device_is_compatible(node, "xen,domain") ) continue; + if ( dt_find_property(node, "xen,static-mem", NULL) ) + flags |= CDF_staticmem; + if ( dt_property_read_bool(node, "direct-map") ) { - if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) ) + if ( !(flags & CDF_staticmem) ) panic("direct-map is not valid for domain %s without static allocation.\n", dt_node_name(node)); diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 628b14b086..2c8116afba 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -35,6 +35,14 @@ void arch_get_domain_info(const struct domain *d, /* Should domain memory be directly mapped? */ #define CDF_directmap (1U << 1) #endif +/* Is domain memory on static allocation? */ +#ifdef CONFIG_STATIC_MEMORY +#define CDF_staticmem (1U << 2) +#else +#define CDF_staticmem 0 +#endif + +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) /* * Arch-specifics. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:39:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399537.640766 (Exim 4.92) (envelope-from ) id 1oVTBV-0008BP-SN; Tue, 06 Sep 2022 07:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399537.640766; Tue, 06 Sep 2022 07:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBV-0008BG-ON; Tue, 06 Sep 2022 07:39:49 +0000 Received: by outflank-mailman (input) for mailman id 399537; Tue, 06 Sep 2022 07:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBU-0007HG-9E for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:39:48 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 14cfded2-2db7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:39:47 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9596176A; Tue, 6 Sep 2022 00:39:52 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 96A743F73D; Tue, 6 Sep 2022 00:40:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14cfded2-2db7-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v12 3/6] xen: unpopulate memory when domain is static Date: Tue, 6 Sep 2022 15:39:16 +0800 Message-Id: <20220906073919.941934-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> References: <20220906073919.941934-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never go back to heap allocator. This commit puts reserved page on the new list resv_page_list after it has been freed. Signed-off-by: Penny Zheng Acked-by: Jan Beulich Acked-by: Julien Grall --- v12 changes: - no change --- v11 change: - commit message tweak --- v10 change: - Do not skip the list addition in that one special case --- v9 change: - remove macro helper put_static_page, and just expand its code inside free_domstatic_page --- v8 changes: - adapt this patch for newly introduced free_domstatic_page - order as a parameter is not needed here, as all staticmem operations are limited to order-0 regions - move d->page_alloc_lock after operation on d->resv_page_list --- v7 changes: - Add page on the rsv_page_list *after* it has been freed --- v6 changes: - refine in-code comment - move PGC_static !CONFIG_STATIC_MEMORY definition to common header --- v5 changes: - adapt this patch for PGC_staticmem --- v4 changes: - no changes --- v3 changes: - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. --- v2 changes: - put reserved pages on resv_page_list after having taken them off the "normal" list --- xen/common/domain.c | 4 ++++ xen/common/page_alloc.c | 7 +++++-- xen/include/xen/sched.h | 3 +++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 7062393e37..c23f449451 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -604,6 +604,10 @@ struct domain *domain_create(domid_t domid, INIT_PAGE_LIST_HEAD(&d->page_list); INIT_PAGE_LIST_HEAD(&d->extra_page_list); INIT_PAGE_LIST_HEAD(&d->xenpage_list); +#ifdef CONFIG_STATIC_MEMORY + INIT_PAGE_LIST_HEAD(&d->resv_page_list); +#endif + spin_lock_init(&d->node_affinity_lock); d->node_affinity = NODE_MASK_ALL; diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 0c50dee4c5..26a2fad4e3 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2741,10 +2741,13 @@ void free_domstatic_page(struct page_info *page) drop_dom_ref = !domain_adjust_tot_pages(d, -1); - spin_unlock_recursive(&d->page_alloc_lock); - free_staticmem_pages(page, 1, scrub_debug); + /* Add page on the resv_page_list *after* it has been freed. */ + page_list_add_tail(page, &d->resv_page_list); + + spin_unlock_recursive(&d->page_alloc_lock); + if ( drop_dom_ref ) put_domain(d); } diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 1cf629e7ec..956e0f9dca 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -381,6 +381,9 @@ struct domain struct page_list_head page_list; /* linked list */ struct page_list_head extra_page_list; /* linked list (size extra_pages) */ struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ +#ifdef CONFIG_STATIC_MEMORY + struct page_list_head resv_page_list; /* linked list */ +#endif /* * This field should only be directly accessed by domain_adjust_tot_pages() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:39:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:39:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399542.640777 (Exim 4.92) (envelope-from ) id 1oVTBZ-0008WC-5j; Tue, 06 Sep 2022 07:39:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399542.640777; Tue, 06 Sep 2022 07:39:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBZ-0008Vs-1i; Tue, 06 Sep 2022 07:39:53 +0000 Received: by outflank-mailman (input) for mailman id 399542; Tue, 06 Sep 2022 07:39:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBY-0008BB-5e for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:39:52 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 15e35273-2db7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:39:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA30C139F; Tue, 6 Sep 2022 00:39:56 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 772053F73D; Tue, 6 Sep 2022 00:40:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15e35273-2db7-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v12 4/6] xen: introduce prepare_staticmem_pages Date: Tue, 6 Sep 2022 15:39:17 +0800 Message-Id: <20220906073919.941934-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> References: <20220906073919.941934-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we want to use acquire_domstatic_pages() for populating memory for static domain on runtime, however, there are a lot of pointless work (checking mfn_valid(), scrubbing the free part, cleaning the cache...) considering we know the page is valid and belong to the guest. This commit splits acquire_staticmem_pages() in two parts, and introduces prepare_staticmem_pages to bypass all "pointless work". Signed-off-by: Penny Zheng Acked-by: Jan Beulich Acked-by: Julien Grall --- v12 changes: - no change --- v11 changes: - no change --- v10 changes: - no change --- v9 changes: - no change --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - adapt to PGC_static --- v5 changes: - new commit --- xen/common/page_alloc.c | 61 ++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 26a2fad4e3..adcc16e4f6 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2752,26 +2752,13 @@ void free_domstatic_page(struct page_info *page) put_domain(d); } -/* - * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of - * static memory. - * This function needs to be reworked if used outside of boot. - */ -static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, - unsigned long nr_mfns, - unsigned int memflags) +static bool __init prepare_staticmem_pages(struct page_info *pg, + unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; unsigned long i; - struct page_info *pg; - - ASSERT(nr_mfns); - for ( i = 0; i < nr_mfns; i++ ) - if ( !mfn_valid(mfn_add(smfn, i)) ) - return NULL; - - pg = mfn_to_page(smfn); spin_lock(&heap_lock); @@ -2782,7 +2769,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", - i, mfn_x(smfn) + i, + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info, pg[i].tlbflush_timestamp); goto out_err; } @@ -2806,6 +2793,38 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, if ( need_tlbflush ) filtered_flush_tlb_mask(tlbflush_timestamp); + return true; + + out_err: + while ( i-- ) + pg[i].count_info = PGC_static | PGC_state_free; + + spin_unlock(&heap_lock); + + return false; +} + +/* + * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of + * static memory. + * This function needs to be reworked if used outside of boot. + */ +static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, + unsigned long nr_mfns, + unsigned int memflags) +{ + unsigned long i; + struct page_info *pg; + + ASSERT(nr_mfns); + for ( i = 0; i < nr_mfns; i++ ) + if ( !mfn_valid(mfn_add(smfn, i)) ) + return NULL; + + pg = mfn_to_page(smfn); + if ( !prepare_staticmem_pages(pg, nr_mfns, memflags) ) + return NULL; + /* * Ensure cache and RAM are consistent for platforms where the guest * can control its own visibility of/through the cache. @@ -2814,14 +2833,6 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, flush_page_to_ram(mfn_x(smfn) + i, !(memflags & MEMF_no_icache_flush)); return pg; - - out_err: - while ( i-- ) - pg[i].count_info = PGC_static | PGC_state_free; - - spin_unlock(&heap_lock); - - return NULL; } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399546.640788 (Exim 4.92) (envelope-from ) id 1oVTBd-0000aE-Ep; Tue, 06 Sep 2022 07:39:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399546.640788; Tue, 06 Sep 2022 07:39:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBd-0000Zv-B0; Tue, 06 Sep 2022 07:39:57 +0000 Received: by outflank-mailman (input) for mailman id 399546; Tue, 06 Sep 2022 07:39:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBc-0007HG-9X for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:39:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 199c58bf-2db7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:39:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA13D176A; Tue, 6 Sep 2022 00:40:00 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5829E3F73D; Tue, 6 Sep 2022 00:40:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 199c58bf-2db7-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v12 5/6] xen: rename free_staticmem_pages to unprepare_staticmem_pages Date: Tue, 6 Sep 2022 15:39:18 +0800 Message-Id: <20220906073919.941934-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> References: <20220906073919.941934-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The name of free_staticmem_pages is inappropriate, considering it is the opposite of function prepare_staticmem_pages. Rename free_staticmem_pages to unprepare_staticmem_pages. Signed-off-by: Penny Zheng Acked-by: Jan Beulich --- v12 changes: - no change --- v11 changes: - moved ahead of "xen: retrieve reserved pages on populate_physmap" --- v10 changes: - new commit --- xen/arch/arm/setup.c | 3 ++- xen/common/page_alloc.c | 13 ++++++++----- xen/include/xen/mm.h | 4 ++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 6e0398f3f6..7814fe323d 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -653,7 +653,8 @@ static void __init init_staticmem_pages(void) if ( mfn_x(bank_end) <= mfn_x(bank_start) ) return; - free_staticmem_pages(mfn_to_page(bank_start), bank_pages, false); + unprepare_staticmem_pages(mfn_to_page(bank_start), + bank_pages, false); } } #endif diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index adcc16e4f6..18d34d1b69 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2693,9 +2693,12 @@ struct domain *get_pg_owner(domid_t domid) } #ifdef CONFIG_STATIC_MEMORY -/* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ -void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub) +/* + * It is the opposite of prepare_staticmem_pages, and it aims to unprepare + * nr_mfns pages of static memory. + */ +void unprepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) { mfn_t mfn = page_to_mfn(pg); unsigned long i; @@ -2741,7 +2744,7 @@ void free_domstatic_page(struct page_info *page) drop_dom_ref = !domain_adjust_tot_pages(d, -1); - free_staticmem_pages(page, 1, scrub_debug); + unprepare_staticmem_pages(page, 1, scrub_debug); /* Add page on the resv_page_list *after* it has been freed. */ page_list_add_tail(page, &d->resv_page_list); @@ -2862,7 +2865,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, if ( assign_pages(pg, nr_mfns, d, memflags) ) { - free_staticmem_pages(pg, nr_mfns, memflags & MEMF_no_scrub); + unprepare_staticmem_pages(pg, nr_mfns, memflags & MEMF_no_scrub); return -EINVAL; } diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index deadf4b2a1..93db3c4418 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -86,8 +86,8 @@ bool scrub_free_pages(void); #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) /* These functions are for static memory */ -void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub); +void unprepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub); void free_domstatic_page(struct page_info *page); int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:40:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:40:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399549.640799 (Exim 4.92) (envelope-from ) id 1oVTBh-00018c-TJ; Tue, 06 Sep 2022 07:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399549.640799; Tue, 06 Sep 2022 07:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBh-00017v-O3; Tue, 06 Sep 2022 07:40:01 +0000 Received: by outflank-mailman (input) for mailman id 399549; Tue, 06 Sep 2022 07:40:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTBg-0008BB-3R for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:40:00 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1a7238db-2db7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:39:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C042139F; Tue, 6 Sep 2022 00:40:04 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 77E0C3F73D; Tue, 6 Sep 2022 00:40:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a7238db-2db7-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v12 6/6] xen: retrieve reserved pages on populate_physmap Date: Tue, 6 Sep 2022 15:39:19 +0800 Message-Id: <20220906073919.941934-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> References: <20220906073919.941934-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a static domain populates memory through populate_physmap at runtime, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. This commit also introduces a new helper acquire_reserved_page to make it work. Signed-off-by: Penny Zheng --- v12 changes: - it should be acquire_domstatic_pages() calling unprepare_staticmem_pages() on failing - add in-code comment --- v11 change: - with assignment having failed and the page not exposed to the guest at any point, there is no need for scrubbing --- v10 changes: - add lock on the fail path --- v9 changes: - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page - Add free_staticmem_pages to undo prepare_staticmem_pages when assign_domstatic_pages - Remove redundant static in error message --- v8 changes: - As concurrent free/allocate could modify the resv_page_list, we still need the lock --- v7 changes: - remove the lock, since we add the page to rsv_page_list after it has been totally freed. --- v6 changes: - drop the lock before returning --- v5 changes: - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes： - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level --- v3 changes: - move is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 --- xen/common/memory.c | 23 +++++++++++++ xen/common/page_alloc.c | 74 +++++++++++++++++++++++++++++++++-------- xen/include/xen/mm.h | 1 + 3 files changed, 84 insertions(+), 14 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index bc89442ba5..ae8163a738 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) mfn = _mfn(gpfn); } + else if ( is_domain_using_staticmem(d) ) + { + /* + * No easy way to guarantee the retrieved pages are contiguous, + * so forbid non-zero-order requests here. + */ + if ( a->extent_order != 0 ) + { + gdprintk(XENLOG_WARNING, + "Cannot allocate static order-%u pages for %pd\n", + a->extent_order, d); + goto out; + } + + mfn = acquire_reserved_page(d, a->memflags); + if ( mfn_eq(mfn, INVALID_MFN) ) + { + gdprintk(XENLOG_WARNING, + "%pd: failed to retrieve a reserved page\n", + d); + goto out; + } + } else { page = alloc_domheap_pages(d, a->extent_order, a->memflags); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 18d34d1b69..215f4c234b 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2755,9 +2755,8 @@ void free_domstatic_page(struct page_info *page) put_domain(d); } -static bool __init prepare_staticmem_pages(struct page_info *pg, - unsigned long nr_mfns, - unsigned int memflags) +static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; @@ -2838,6 +2837,25 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, return pg; } +static int assign_domstatic_pages(struct domain *d, struct page_info *pg, + unsigned int nr_mfns, unsigned int memflags) +{ + if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) + { + /* + * Respective handling omitted here because right now + * acquired static memory is only for guest RAM. + */ + ASSERT_UNREACHABLE(); + return -EINVAL; + } + + if ( assign_pages(pg, nr_mfns, d, memflags) ) + return -EINVAL; + + return 0; +} + /* * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, * then assign them to one specific domain #d. @@ -2853,17 +2871,7 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, if ( !pg ) return -ENOENT; - if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) - { - /* - * Respective handling omitted here because right now - * acquired static memory is only for guest RAM. - */ - ASSERT_UNREACHABLE(); - return -EINVAL; - } - - if ( assign_pages(pg, nr_mfns, d, memflags) ) + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) { unprepare_staticmem_pages(pg, nr_mfns, memflags & MEMF_no_scrub); return -EINVAL; @@ -2871,6 +2879,44 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, return 0; } + +/* + * Acquire a page from reserved page list(resv_page_list), when populating + * memory for static domain on runtime. + */ +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ + struct page_info *page; + + ASSERT_ALLOC_CONTEXT(); + + /* Acquire a page from reserved page list(resv_page_list). */ + spin_lock(&d->page_alloc_lock); + page = page_list_remove_head(&d->resv_page_list); + spin_unlock(&d->page_alloc_lock); + if ( unlikely(!page) ) + return INVALID_MFN; + + if ( !prepare_staticmem_pages(page, 1, memflags) ) + goto fail; + + if ( assign_domstatic_pages(d, page, 1, memflags) ) + goto fail_assign; + + return page_to_mfn(page); + + fail_assign: + /* + * The page was never accessible by the domain. So scrubbing can be + * skipped + */ + unprepare_staticmem_pages(page, 1, false); + fail: + spin_lock(&d->page_alloc_lock); + page_list_add_tail(page, &d->resv_page_list); + spin_unlock(&d->page_alloc_lock); + return INVALID_MFN; +} #endif /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 93db3c4418..a925028ab3 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -198,6 +198,7 @@ struct npfec { #else #define MAX_ORDER 20 /* 2^20 contiguous pages */ #endif +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags); /* Private domain structs for DOMID_XEN, DOMID_IO, etc. */ extern struct domain *dom_xen, *dom_io; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:43:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:43:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399577.640809 (Exim 4.92) (envelope-from ) id 1oVTEn-0003os-Ob; Tue, 06 Sep 2022 07:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399577.640809; Tue, 06 Sep 2022 07:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTEn-0003ol-M2; Tue, 06 Sep 2022 07:43:13 +0000 Received: by outflank-mailman (input) for mailman id 399577; Tue, 06 Sep 2022 07:43:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTEm-0003o0-2A for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:43:12 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d21f3dd-2db7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 09:43:09 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id qh18so21226397ejb.7 for ; Tue, 06 Sep 2022 00:43:11 -0700 (PDT) Received: from leoy-huanghe.lan ([104.245.99.30]) by smtp.gmail.com with ESMTPSA id q3-20020a17090676c300b007030c97ae62sm6150708ejn.191.2022.09.06.00.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 00:43:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d21f3dd-2db7-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=eh9PbLozRnOPRRmksXqXS+0hoLk4T4gMMpNPc3VabkE=; b=p6zSmfxguCCnxrxCAbKkmDokuG7aiSWsL8cAQvxLYyLr/j8V9so6DrUxCVYQnSS7ou cROwDMfQTehuDQEUKQqQ4Rq1lSfcsE+6VHddjAgGpzeng/garJpkCNRZmr3SlruskVYw tKZvGSosIi0oMSi8eyVBxtialyIkGokHsr/VKOJKEjPxQ1fqnLGMteB0vQ7vOfRnyqUu GNplksvDZMP58ovUO160AM0P5vJSS0CPyn7yWrb2OND88m87s6XiBKtQkPBhuS3LLAHh gztlHP+nDf4cLCvFmI9VIY80H44NKkwGDjHErjaHGPy9q6ttmP0XL4IUoicd9cNiXVqj ojZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=eh9PbLozRnOPRRmksXqXS+0hoLk4T4gMMpNPc3VabkE=; b=36zoTO9c/nsr2altRjFLhBv0aNeeeVSiM7PdC/vw8JmPkIl0dPlLBoyKsn8AvEHqnd mORJtkqAstnA/QoXsVjlOUYXVRsbKwDLZexZ5Y/hrV5KiMa1mOcAaZe2uubJZYRmLpWw Kx9oMq7dOE5zpgr8lJGqY5pVaFxAsHJUHUltv0gjud3jAglM5oL/nJlKTFMAfpZWS36+ Eky6kI6MGYCOkyJV5OhHvCa3v8rjWmwZSl9YSRC2T1YOwZpcIchYsYk445uMm24TCfC6 d8CrSWEtHqnimZLbXjsKJ1HQ3/4rlqu/epFZ+HK4MqhgpLzba6NrJ+YQ8gWrK1c0U2jT aAwQ== X-Gm-Message-State: ACgBeo2Yws7SsFRjBZhColK3h70W1sAPzNHfajvtl0HgA9l60GFD3vrK ll9A22ieaQc4qKyW8roPtlDKbQ== X-Google-Smtp-Source: AA6agR7JcMHkHh8ZUZn6sBc9XLLw2UwJ67ykot+SgRWzq1/xgyoWWEGY6GA1e1ONf1nwKOdT8fXtxg== X-Received: by 2002:a17:907:272a:b0:741:8105:49e2 with SMTP id d10-20020a170907272a00b00741810549e2mr28479988ejl.171.1662450190557; Tue, 06 Sep 2022 00:43:10 -0700 (PDT) Date: Tue, 6 Sep 2022 15:43:05 +0800 From: Leo Yan To: Ard Biesheuvel Cc: Marc Zyngier , Julien Grall , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table Message-ID: References: <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 06, 2022 at 03:27:47PM +0800, Leo Yan wrote: > On Tue, Sep 06, 2022 at 09:22:00AM +0200, Ard Biesheuvel wrote: > > [...] > > > > IIUC, you consider the general flow from architecture view, so you prefer > > > to ask Xen to implement EFI stub to comply the general flow for EFI > > > booting sequence, right? > > > > > > If the conclusion is to change Xen for support EFI stub, then this > > > would be fine for me and I will hold on and leave Xen developers to work > > > on it. > > > > > > > As I mentioned before, proper EFI boot support in Xen would be nice. > > *However*, I don't think it makes sense to go through all the trouble > > of implementing that just to shut up a warning that doesn't affect Xen > > to begin with. > > Another option is we can set a bit for xen feature, so Linux kernel > can read out the xen feature and make decision if need to reserve > memory for RD tables based on the new feature bit. This is somehow > a solution is to create a general protocol between Xen and Linux kernel. > > How about you think for this? Just supplement info. I tried to set flag EFI_PARAVIRT in Linux kernel, but kernel cannot boot up successfully on Arm64. Seems the Linux kernel will not map memory correctly after settting this flag. This is why I didn't move forward with this flag. Thanks, Leo From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:53:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:53:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399602.640821 (Exim 4.92) (envelope-from ) id 1oVTOR-0005O3-MB; Tue, 06 Sep 2022 07:53:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399602.640821; Tue, 06 Sep 2022 07:53:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTOR-0005Nw-J7; Tue, 06 Sep 2022 07:53:11 +0000 Received: by outflank-mailman (input) for mailman id 399602; Tue, 06 Sep 2022 07:53:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTOQ-0005Nq-Fn for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:53:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2a52529-2db8-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 09:53:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5B1E0B815A0; Tue, 6 Sep 2022 07:53:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E4FDC433D6; Tue, 6 Sep 2022 07:53:07 +0000 (UTC) Received: from 82-132-237-87.dab.02.net ([82.132.237.87] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oVTOK-008FVO-Q3; Tue, 06 Sep 2022 08:53:05 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2a52529-2db8-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662450787; bh=YsUP0GvS/xdqDCHgCtBY2s4ikD0bQL4umny0jSvCzIE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qat5r2sr07PCvITo1/BJCVEDhPmDpAVjdSxluUVr1VjM7CdZPn7nOjgoa6Z4AqVbK PqXZcQIEaykRj5HuQ+tkiUh9H1mB7cpfIzb+OJfocTuSJ/WXe6cKYrP95Ebzz4zrue Xf7st8AGv+v+gKLNB49WGyjG5U99cP/tUY5gXAeMSi6WBwgqwkvQeiYcv6Yj0v3Vps FqRlKRy/CHn+9KLNd494mGl+1GJ5MXv9MxjUbQeQMAuKKD0vvs1kFUg66h+kbk/2/I F08bEVVaeBM8DysYSnM9X80V0pX2Tqukax0HkFCLwRRFoRljRc8YlGgmb3mWt2bO8Y EwMLmMAWApdTw== Date: Tue, 06 Sep 2022 08:53:02 +0100 Message-ID: <87leqxq6qp.wl-maz@kernel.org> From: Marc Zyngier To: Leo Yan Cc: Julien Grall , Ard Biesheuvel , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table In-Reply-To: References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 82.132.237.87 X-SA-Exim-Rcpt-To: leo.yan@linaro.org, julien@xen.org, ardb@kernel.org, jbeulich@suse.com, Bertrand.Marquis@arm.com, Rahul.Singh@arm.com, peter.griffin@linaro.org, xen-devel@lists.xenproject.org, jgrall@amazon.com, mathieu.poirier@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 06 Sep 2022 08:17:14 +0100, Leo Yan wrote: > > Hi Marc, > > On Tue, Sep 06, 2022 at 07:27:17AM +0100, Marc Zyngier wrote: > > On Tue, 06 Sep 2022 03:52:37 +0100, > > Leo Yan wrote: > > > > > > On Thu, Aug 25, 2022 at 10:40:41PM +0800, Leo Yan wrote: > > > > > > [...] > > > > > > > > > But here I still cannot create the concept that how GIC RD tables play > > > > > > roles to support the para virtualization or passthrough mode. > > > > > > > > > > I am not sure what you are actually asking. The pending tables are just > > > > > memory you give to the GICv3 to record the state of the interrupts. > > > > > > > > For more specific, Xen has its own RD pending table, and we can use > > > > this pending table to set state for SGI/PPI/LPI for a specific CPU > > > > interface. Xen works as hypervisor, it saves and restores the pending > > > > table according to switched in VM context, right? > > > > > > > > On the other hand, what's the purpose for Linux kernel's GIC RD > > > > pending table? Is it only used for nested virtulisation? I mean if > > > > Linux kernel's GIC RD pending table is not used for the drivers in > > > > Dom0 or DomU, then it's useless to pass it from the primary kernel to > > > > secondary kernel; as result, we don't need to reserve the persistent > > > > memory for the pending table in this case. > > > > > > I don't receive further confirmation from Marc, anyway, I tried to cook > > > a kernel patch to mute the kernel oops [1]. > > > > What sort of confirmation do you expect from me? None of what you > > write above make much sense in the face of the architecture. > > Okay, I think have two questions for you: > > - The first question is if we really need to reserve persistent memory > for RD pending table and configuration table when Linux kernel runs > in Xen domain? I have no idea, and really I don't want to know. The architecture doesn't make it safe to reuse that memory, and the driver does the right thing by always reserving that memory when the FW is supposed to support it. The "oh but it is safe on so and so" approach doesn't scale. If you want to have such a thing, just convince people at ARM that it is possible to implement a GICv3-compliant system without the RD tables, get them to update the architecture to allow this scheme and advertise it in a discoverable register. Xen could then implement it, Linux could check this bit, and we'd all be a happy family. Because that's really what this is: it isn't that you don't care about the RD tables being reserved. It is that you don't care about them at all because they are never used by Xen as the GIC implementation. Your approach of "huh, let's not reserve it" just papers over this. > > - If the first question's answer is no, so it's not necessary to reserve > RD pending table and configuration table for Xen, then what's the good > way to dismiss the kernel oops? A warning, not an oops. > > IIUC, you consider the general flow from architecture view, so you prefer > to ask Xen to implement EFI stub to comply the general flow for EFI > booting sequence, right? If you want to use ACPI, you use EFI, and not a vague emulation of it. If you use DT, you can reserve the memory upfront. The various alternatives are in this thread. > > If the conclusion is to change Xen for support EFI stub, then this > would be fine for me and I will hold on and leave Xen developers to work > on it. > > > > [1] https://lore.kernel.org/lkml/20220906024040.503764-1-leo.yan@linaro.org/T/#u > > > > I'm totally baffled by the fact you're trying to add some extra hacks > > to Linux just to paper over some of the Xen's own issues. > > I have a last question for why kernel reserves RD pending table and > configuration table for kexec. As we know, the primary kernel and > the secondary kernel use separate memory regions, No, you got it wrong. Only with *kdump* do you get separate memory regions. kexec reuses all of the memory visible by the primary kernel. > this means there have > no race condition that secondary kernel modifies the tables whilist the > GIC accesses the table if the secondary kernel allocates new pages for > RD tables. So only one potential issue I can image is the secondary > kernel sets new RD pending table and configuration table, which might > introduce inconsistent issue with rest RDs in the system. > > Could you confirm if my understanding is correct or not? It isn't correct. - There is no race condition. Once the RD tables are configured, they cannot be changed. - When the kdump kernel boots, none of the primary OS memory is reused, so it is safe to continue and use the same tables in place - When the kexec kernel boots, all of the memory except for the reserved memory is reused. If your RD tables are used for anything, you'll see memory corruption as the GIC writes pending bits in the pending table, and you'll be unable to configure interrupts correctly. In conclusion, using kexec with GICv3 is completely unsafe if you don't reserve the memory allocated to the RDs. > Sorry for noise and many questions. I understand this is a complex > and difficult topic for me, and it's very likely that I am absent > sufficient knowledge for this part, this is just what I want to > learn from the discussion and from you :-) I suggest you read the architecture spec, which has all the details. M. -- Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Tue Sep 06 07:54:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 07:54:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399609.640832 (Exim 4.92) (envelope-from ) id 1oVTPW-0005w4-V0; Tue, 06 Sep 2022 07:54:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399609.640832; Tue, 06 Sep 2022 07:54:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTPW-0005vx-Rn; Tue, 06 Sep 2022 07:54:18 +0000 Received: by outflank-mailman (input) for mailman id 399609; Tue, 06 Sep 2022 07:54:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTPV-0005vl-GN for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 07:54:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTPT-0005hO-EJ; Tue, 06 Sep 2022 07:54:15 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVTPT-0006W5-7w; Tue, 06 Sep 2022 07:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=a8Wh/kJtL/F/TQEAqDvvb/FehWLQq5CpfEz41666VF8=; b=cFNeC34hQ7X4atEEK4UENrUpwf E1ZiHkOiAxwed3IQGiWqp/TPmAoBW7gwepM8Ow68GlXEmw8qs3AJ1OTx1cvdr8JvH3OYTlToHRU0n oyMwZO37i22JEf0A4bMwjau4G9nXRpBoIMWgdqybRDD0Bd5bX6p2JsRtgMqbxTx33RSQ=; Message-ID: <7bf75eba-f5c5-6c63-5c45-10c5d2d20254@xen.org> Date: Tue, 6 Sep 2022 08:54:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Content-Language: en-US To: Bertrand Marquis , Stefano Stabellini Cc: Rahul Singh , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 06/09/2022 08:24, Bertrand Marquis wrote: >> I agree with Julien: I prefer this proposal compared to the earlier one >> by Bertrand and Rahul because I think it is a lot clearer and "ENHANCED" >> should mean everything. Also, it makes it easier from a compatibility >> perspective because it matches the current definition. >> >> But I also agree with Bertrand that "BASIC" doesn't sound nice. I think >> we should keep "DOM0LESS_ENHANCED" and "DOM0LESS_XENSTORE" as suggested >> here, but replace "DOM0LESS_ENHANCED_BASIC" with something better. Some >> ideas: >> >> - DOM0LESS_ENHANCED_LIMITED >> - DOM0LESS_ENHANCED_MINI > > Personally I do not find those more clear then BASIC > >> - DOM0LESS_ENHANCED_NO_XS > > This has the problem to be true now but would need renaming if we introduce a definition for an other bit. Internal renaming is not a problem. > >> - DOM0LESS_ENHANCED_GNT_EVTCHN > > I would vote for this one as it explicitly state what is in so the bitset system is even more meaningful. This would be fine if the flag were doing what it is supposed to do (i.e enable grant-table and event-channel only). However, so far, it will expose any Xen features but Xenstore. So of the features are strictly not necessary for the grant-table/event-channel support (e.g. ballooning facilities, runstate...). The name would also really confusing in the definition of ENHANCED (XENSTORE | GNT_EVTCHN). Does this mean the domain cannot use the runstate? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:01:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:01:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399624.640842 (Exim 4.92) (envelope-from ) id 1oVTW7-000821-5G; Tue, 06 Sep 2022 08:01:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399624.640842; Tue, 06 Sep 2022 08:01:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTW7-00081u-2W; Tue, 06 Sep 2022 08:01:07 +0000 Received: by outflank-mailman (input) for mailman id 399624; Tue, 06 Sep 2022 08:01:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTW5-00081o-Ul for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 08:01:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c078073-2dba-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 10:01:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 933D21F969; Tue, 6 Sep 2022 08:01:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 631BD13A7A; Tue, 6 Sep 2022 08:01:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WQy1Fz7+FmM9RAAAMHmgww (envelope-from ); Tue, 06 Sep 2022 08:01:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c078073-2dba-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662451262; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LykPbpb5bX1WhruUNGP1sKPZqUQwdvS2N9veeSktZmY=; b=pD+ASQHSAYfnCXP/CzGZe0KiKy1C4ke5t5GY78Rxgp3BIdsYedHxXqMF10g3+09ns2HSTq 9RHvnwu5+vfbyZL2m55Mbsk/4FRQIQhrEl/I1BdLKTaRnN9pB4NAkyq9Brps3pS2hykup0 Nljpw9VHKbxVOnYLRZSymJIj4CedzPA= Date: Tue, 6 Sep 2022 10:01:01 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 05-09-22 11:03:35, Suren Baghdasaryan wrote: > On Mon, Sep 5, 2022 at 1:12 AM Michal Hocko wrote: > > > > On Sun 04-09-22 18:32:58, Suren Baghdasaryan wrote: > > > On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > > [...] > > > > Yes, tracking back the call trace would be really needed. The question > > > > is whether this is really prohibitively expensive. How much overhead are > > > > we talking about? There is no free lunch here, really. You either have > > > > the overhead during runtime when the feature is used or on the source > > > > code level for all the future development (with a maze of macros and > > > > wrappers). > > > > > > As promised, I profiled a simple code that repeatedly makes 10 > > > allocations/frees in a loop and measured overheads of code tagging, > > > call stack capturing and tracing+BPF for page and slab allocations. > > > Summary: > > > > > > Page allocations (overheads are compared to get_free_pages() duration): > > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > > 8.8% lookup_page_ext > > > 1237% call stack capture > > > 139% tracepoint with attached empty BPF program > > > > Yes, I am not surprised that the call stack capturing is really > > expensive comparing to the allocator fast path (which is really highly > > optimized and I suspect that with 10 allocation/free loop you mostly get > > your memory from the pcp lists). Is this overhead still _that_ visible > > for somehow less microoptimized workloads which have to take slow paths > > as well? > > Correct, it's a comparison with the allocation fast path, so in a > sense represents the worst case scenario. However at the same time the > measurements are fair because they measure the overheads against the > same meaningful baseline, therefore can be used for comparison. Yes, I am not saying it is an unfair comparision. It is just not a particularly practical one for real life situations. So I am not sure you can draw many conclusions from that. Or let me put it differently. There is not real point comparing the code tagging and stack unwiding approaches because the later is simply more complex because it collects more state. The main question is whether that additional state collection is too expensive to be practically used. > > Also what kind of stack unwinder is configured (I guess ORC)? This is > > not my area but from what I remember the unwinder overhead varies > > between ORC and FP. > > I used whatever is default and didn't try other mechanisms. Don't > think the difference would be orders of magnitude better though. > > > > > And just to make it clear. I do realize that an overhead from the stack > > unwinding is unavoidable. And code tagging would logically have lower > > overhead as it performs much less work. But the main point is whether > > our existing stack unwiding approach is really prohibitively expensive > > to be used for debugging purposes on production systems. I might > > misremember but I recall people having bigger concerns with page_owner > > memory footprint than the actual stack unwinder overhead. > > That's one of those questions which are very difficult to answer (if > even possible) because that would depend on the use scenario. If the > workload allocates frequently then adding the overhead will likely > affect it, otherwise might not be even noticeable. In general, in > pre-production testing we try to minimize the difference in > performance and memory profiles between the software we are testing > and the production one. From that point of view, the smaller the > overhead, the better. I know it's kinda obvious but unfortunately I > have no better answer to that question. This is clear but it doesn't really tell whether the existing tooling is unusable for _your_ or any specific scenarios. Because when we are talking about adding quite a lot of code and make our allocators APIs more complicated to track the state then we should carefully weigh the benefit and the cost. As replied to other email I am really skeptical this patchset is at the final stage and the more allocators get covered the more code we have to maintain. So there must be a very strong reason to add it. > For the memory overhead, in my early internal proposal with assumption > of 10000 instrumented allocation call sites, I've made some > calculations for an 8GB 8-core system (quite typical for Android) and > ended up with the following: > > per-cpu counters atomic counters > page_ext references 16MB 16MB > slab object references 10.5MB 10.5MB > alloc_tags 900KB 312KB > Total memory overhead 27.4MB 26.8MB I do not really think this is all that interesting because the major memory overhead contributors (page_ext and objcg are going to be there with other approaches that want to match alloc and free as that clearly requires to store the allocator objects somewhere). > so, about 0.34% of the total memory. Our implementation has changed > since then and the number might not be completely correct but it > should be in the ballpark. > I just checked the number of instrumented calls that we currently have > in the 6.0-rc3 built with defconfig and it's 165 page allocation and > 2684 slab allocation sites. I readily accept that we are probably > missing some allocations and additional modules can also contribute to > these numbers but my guess it's still less than 10000 that I used in > my calculations. yes, in the current implementation you are missing most indirect users of the page allocator as stated elsewhere so the usefulness can be really limited. A better coverege will not increase the memory consumption much but it will add an additional maintenance burden that will scale with different usecases. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:02:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399633.640854 (Exim 4.92) (envelope-from ) id 1oVTXG-0000Bh-Kj; Tue, 06 Sep 2022 08:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399633.640854; Tue, 06 Sep 2022 08:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTXG-0000Ba-Hs; Tue, 06 Sep 2022 08:02:18 +0000 Received: by outflank-mailman (input) for mailman id 399633; Tue, 06 Sep 2022 08:02:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTXE-0000BU-IM for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 08:02:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTXE-0006S5-6j; Tue, 06 Sep 2022 08:02:16 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVTXD-00079p-Ui; Tue, 06 Sep 2022 08:02:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=El+QVsS2/X1R3UXn6/d7ocFaeEG3ltdXzscPuUJt/PU=; b=ygpsCcsb1lUKegigcplpQyEMQw o2k1000CVU8bRzcih+llMzDmps72Kt0E0k6Xc0TsTlkAj+Lftk4YM9Yo6Z9e4BBC42uLYzswz6fT8 iS+FbBXADRUmybwJIwh+knwWfR5CJkITQrGYD2SVQcq8k5WETofb5D+E47ROv8pw6afM=; Message-ID: Date: Tue, 6 Sep 2022 09:02:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory Content-Language: en-US To: Henry Wang , Michal Orzel , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-2-Henry.Wang@arm.com> <8325d0ce-1fd3-d754-9eaf-d73b19f8d53e@xen.org> <4030d661-7b25-4957-e2dc-069fb4030ea0@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry and Michal, On 06/09/2022 07:41, Henry Wang wrote: >> -----Original Message----- >> From: Michal Orzel >> Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory >> >> Hi Julien, >> >> On 05/09/2022 19:24, Julien Grall wrote: >>> >>> Hi Michal, >>> >>> On 05/09/2022 13:04, Michal Orzel wrote: >>>> On 05/09/2022 09:26, Henry Wang wrote: >>>>> >>>>> diff --git a/xen/arch/arm/include/asm/setup.h >> b/xen/arch/arm/include/asm/setup.h >>>>> index 5815ccf8c5..d0cc556833 100644 >>>>> --- a/xen/arch/arm/include/asm/setup.h >>>>> +++ b/xen/arch/arm/include/asm/setup.h >>>>> @@ -22,11 +22,16 @@ typedef enum { >>>>> BOOTMOD_UNKNOWN >>>>> } bootmodule_kind; >>>>> >>>>> +typedef enum { >>>>> + MEMBANK_MEMORY, >>>>> + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to >> a Xen domain. */ >>>>> + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as >> heap. */ >>>>> +} membank_type; >>>> Whereas the patch itself looks ok (it must be modified anyway given the >> comments for patch #2), >>>> MEMBANK_XEN_DOMAIN name is quite ambiguous to me, now when it is >> part of membank_type enum. >>>> Something like MEMBANK_STATIC or MEMBANK_STATICMEM would be >> much cleaner in my opinion >>>> as it would directly indicate what type of memory we are talking about. >>> >>> I am not sure. Technically the reserved heap is static memory that has >>> been allocated for the heap. In fact, I think thn name "staticmem" is >>> now becoming quite confusing because we are referring to a very specific >>> use case (i.e. memory that has been reserved for domain use). >>> >>> So I would prefer if we keep "domain" in the name. Maybe >>> MEMBANK_STATIC_DOMAIN or MEMBANK_RESERVED_DOMAIN. >>> >> Personally I would drop completely using the "reserved heap" naming in >> favor >> of "static heap" because "staticmem" is also something we reserve at boot >> time for a domain use. >> This would also directly correlate to the device tree property "static-heap" >> and "static-mem". >> Then such enum would be created as follows and for me this is the cleanest >> solution: >> MEMBANK_DEFAULT >> MEMBANK_STATIC_DOMAIN >> MEMBANK_STATIC_HEAP >> >> But I think we are already too late in this series to request such changes, The naming was introduced in this version. So I would not view this as a late request. > > I am ok with a pure renaming to static heap if Julien is ok with that. I think > Julien has done most of the code review and we still have 2~3 days for it. I am fine with the version proposed by Michal. I.e.: MEMBANK_DEFAULT MEMBANK_STATIC_DOMAIN MEMBANK_STATIC_HEAP Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:23:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:23:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399643.640864 (Exim 4.92) (envelope-from ) id 1oVTrE-0002ix-9D; Tue, 06 Sep 2022 08:22:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399643.640864; Tue, 06 Sep 2022 08:22:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTrE-0002iq-6P; Tue, 06 Sep 2022 08:22:56 +0000 Received: by outflank-mailman (input) for mailman id 399643; Tue, 06 Sep 2022 08:22:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTrD-0002ig-G0; Tue, 06 Sep 2022 08:22:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTrD-0006mG-Bc; Tue, 06 Sep 2022 08:22:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVTrC-0004WJ-OL; Tue, 06 Sep 2022 08:22:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVTrC-0006CS-Nt; Tue, 06 Sep 2022 08:22:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=r5q92fhLye+JzusVU8ToPpBktDJaTTT1l6XYzvYL0yE=; b=4xNTGYzwTRYBn63t6ad3xw+LBZ 1Eoa9QtJmm7Go+sfAEohJKT9adJrnHyVinX2+JVD+ebIVv0B/W/vLrhIgP6RICHLkXBde9ooLknGt Zbmefq+gTjaTCjfojB8yE1/8VSkrMCdiiG1gAUAtIjhIhqbIL9orbv/pnKaYt1QJndVg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173011: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=61fd710b8da8aedcea9b4f197283dc38638e4b60 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Tue, 06 Sep 2022 08:22:54 +0000 flight 173011 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173011/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 173000 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 61fd710b8da8aedcea9b4f197283dc38638e4b60 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 33 days Failing since 172148 2022-08-04 21:39:38 Z 32 days 74 attempts Testing same since 172945 2022-09-02 23:10:19 Z 3 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5434 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:33:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:33:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399651.640876 (Exim 4.92) (envelope-from ) id 1oVU0m-0004F5-79; Tue, 06 Sep 2022 08:32:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399651.640876; Tue, 06 Sep 2022 08:32:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVU0m-0004Ey-4R; Tue, 06 Sep 2022 08:32:48 +0000 Received: by outflank-mailman (input) for mailman id 399651; Tue, 06 Sep 2022 08:32:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVU0k-0004Eo-TP; Tue, 06 Sep 2022 08:32:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVU0k-00071Y-Rl; Tue, 06 Sep 2022 08:32:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVU0k-00059O-B4; Tue, 06 Sep 2022 08:32:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVU0k-0006Ri-AR; Tue, 06 Sep 2022 08:32:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vkNLd4ykDW2GjZS2p4FJ29QjC8pj1V78xx7HjmZL5Bo=; b=K4gkPnnNEvNk/WdBJk4PZAz7Nf KWDUKOuSodpWBHM5RpvwkMmzSfA7OFCnS5laPmX2KnvFqzVWKMQe/XXsfzPUHSvPokBOTjp+jrTG1 ysmaDmzHfFd31hvf7whheIn+nEVTXqOxzwycVO92KGXn3LvGRp2tuTpwIdNKMKB9/5/U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173018: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=c05a218a9758225ddf94eedb365633f2154551da X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 06 Sep 2022 08:32:46 +0000 flight 173018 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173018/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf c05a218a9758225ddf94eedb365633f2154551da baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 32 days 252 attempts Testing same since 173009 2022-09-05 15:47:58 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1685 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:54:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:54:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399659.640887 (Exim 4.92) (envelope-from ) id 1oVULq-0006n5-2Y; Tue, 06 Sep 2022 08:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399659.640887; Tue, 06 Sep 2022 08:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVULp-0006my-W5; Tue, 06 Sep 2022 08:54:33 +0000 Received: by outflank-mailman (input) for mailman id 399659; Tue, 06 Sep 2022 08:54:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVULo-0006mq-VB for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 08:54:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85b740de-2dc1-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 10:54:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9201.eurprd04.prod.outlook.com (2603:10a6:102:232::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 08:54:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 08:54:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85b740de-2dc1-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFllZfIwO8ofzT8h3+JbmVP43a1q0ItTHoAWluVOGUHlZr1wE/2bAR9ZylRFmY8Alj48HwXZMTv/BTlE2q7C8LX1GeqANwhFb4QVxRpVfTnHuQqCa3XIls1R+KqZuAgsWWNLgG0VBM+ZCkXo+6t2OW/xY1kBYNRZgC4Qn+9r1TcmfN6VpPo8HHiW394+ufFcrpLnUk+9bwDetqUfUmgDtTLt1mfm5F39VwdSC5+k0wyNelXLag+eB3PLLhRtpPKbdPk9N/x75jt7kMTfbz7Tam65+elCQfho5UxXTMRxt2e5kc/8rKEIH1pLF5ZUbefyC03g70XgcjVGNYhnTtgMKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBzlqSA3kdDDMPrJpGenrmU0q80ch7fAe9qpVfZO2SA=; b=h+nVkBamSJzNegneWLi2QhAldi6iO0c2ohM6BvJtnIhvg6GOGl+H8l1UcVEIRMWF3vjiFXlEs2+NnhH+YTamLzjxHBR8wxSCYBHX8nIZXX1SFsEnLXN4eIk/dHejUeRWf/PIsbPSgfKljAZ1pNxkIo0B6hZ8I+2wBA6Ip2LlmH5IrCMxv3bguQO7jxkUEjIVU+zM+0Dxm3WuanLa3NbHAUJnE/qB4iuR5R7lf3+be1YpqENBYv5NjdZ0LGoS/3Ih6Gqr3QBTrLBiZERlGbKGimaLbVI8CUM3vAjLiXEIIh0lLxwymfPrE1p3N+FC5vB7xAlIReoa4rv78iBlYInInA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eBzlqSA3kdDDMPrJpGenrmU0q80ch7fAe9qpVfZO2SA=; b=IZKxpThj3qG9lyuDKtjWzaxtNbZtMr+OBa4qcd6YSmJJHK2nyFJ3g6veZZ/z7BufalLsJv+JsVBlCPgoeOndKqQrcdUBcdEeNzLG32PElS5qb0w8KuPcyPTj8VRCf9xEYqwjEEVGTl4SpbK2sINRodpHgK+8dKHhawLtFJz0oXI3mT0hYlqKIelY/Cw6/0jLF/BARyQpkdpMqxvMy960uO/rfSO9bT/c4MwEueEvnnipDFF/6PQfKgoeVCrsTzmdbSiJTxU9f44nH8yKW7yKYCzBk3VRUrBixNklGJEWM6f4JKxtJER3x1VNW1rDQEnaxijok43cnK3NYjzxLsQQSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <13572055-eabe-9010-f33c-d7554ad50973@suse.com> Date: Tue, 6 Sep 2022 10:54:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1d8a566c-a2e1-4dac-9ac8-08da8fe5690c X-MS-TrafficTypeDiagnostic: PAXPR04MB9201:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tXeH3dtYV3AAZRIhoOhZAkUwgffEc/WB4XEx3MYoLK1CaQ+cEJz6Cm3TlfcngB0jHPe7YyPGLhZ4WIfFQjsolzikpoRugwDwJGLH9gyc+TC34kXrS8c3GvnYHlUWUNZgWOfCntDnpTjLM7nFwfZkBmSSnhTdsHdi+kBVV2/KOU8kWN0W1GJF/FbyswcqS5Cqbn8Nw62yJBVRA2xSU1zpaxCbRMkdQXIPbBak3FgrNmkWwJTBBNLVdyBn8E+rLfjDeC98srsGsB54PUhfAG1YrmBvLGw9H92UKSMS731BEEykNQdjJwPN2uCcxb4H+MNBvGpofnkc2wDdDwlrNyzZZa7crWYDHwKeYacuCFs4BqAayggcNHL0KAZokZ2qeze2675GF2jqqfSclT+UCHfsqYtXHg7aqFAjk8AiI04R+72nwtViqr78RT1j9wrhSGcsnGSjleTaiOAGDphgQGoh3DMvBcKcqft/IiAEsa44HPXH1H56IONvRawTXwHTyACe0+fc4mpUTruQ0PBSO9V/eaifNR6JOvOSVMK6kM4VrXpcJN5Pfhwnq5f7egShLfhhC7ghKq23fOyuOWVbqxKA6QMrke4VkzuENYib2mI84YIkaCdo+3LmEu3nwXcoDnqaV4+mafomVs/opqxb5YzO+7eIEddbF5sJSv+Ov09tZFPGHJJPrrdNMYXziHv+1T08V4JqmIETPVNwZCc19Vs8cS1EO1undvINqs2qSZjt7gEyWReamXM8yJZ7Wi13b3SJ0LizawzHBnm3P5FjjLwAsOr0HoCyHtNMEohirUjmIls= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(136003)(376002)(366004)(346002)(6486002)(38100700002)(66556008)(86362001)(53546011)(6506007)(6512007)(26005)(66946007)(478600001)(316002)(41300700001)(54906003)(31696002)(6916009)(66476007)(2906002)(31686004)(186003)(36756003)(5660300002)(4744005)(8936002)(4326008)(2616005)(8676002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amVIa0lkOUNiS3V0Vi9zWnVpVmYzSXF2QzJ3UDdVSm85d0NvRGNMSlNPZE80?= =?utf-8?B?Q3lVUTlxcUNZSUZtSVZUOEJVN1ZsSW4xYkZNWlh5Q0ZUcS9lQzR4ODI4Kzgw?= =?utf-8?B?NC9MbkNhWGM3eWRLSGk5NXRNQUpkMGNMQXRYcE4vR1VnRWs5TmJMU1FQWkhT?= =?utf-8?B?RFU1anRFamxNZG5mbUdRSkx0VkFHUCt6RnE0UHBVQTBSV2VUS1VsUzlxZmdO?= =?utf-8?B?TTN3SmJ0Q1NYWlBlZ2ZMZTM4c0xKblUzNVc5SkVqRnhYelNaUG1vK2dOYk9r?= =?utf-8?B?QldUN0FHa0ZDa2pLZXhWeitxM2xCSllHNXRaSHg3Tm01N0pmbGlwK3ZnM3By?= =?utf-8?B?SVZCZ3RNd0Q0WXgzTGFIcC9LbmpnSG4zcUd1Y0NHeEhKRnFxU3NJUy8raHdK?= =?utf-8?B?ak1pbllkTHExNmh0N29NSkVKRGkvNmJzSHZ1bmZxeE0xUzNiVUxFMmdaRE5M?= =?utf-8?B?ZFpuLzJESm1xY1RYMDY3Q09FRXNLdC9WeFc2TDgwUFBaTGkvNWRyakFqMFBj?= =?utf-8?B?MWJqbUJUTjZKenZneThvN3JiNWM5RDdIRXlXQWR3TGxUSUNZTC8vdUVLcXZl?= =?utf-8?B?eG5MRGFKa1RhaENFTWgxYWRHRFAxc2lhd1dOMmRhdEJQc3NncGpQT0pnb3V0?= =?utf-8?B?ZUJlK2pNZk00S3JjcXdBcklubDVHWHd2Nyt6bWlBRzlDUzF4YmhkSE4xcDU4?= =?utf-8?B?eGV0TmVKcll1dWNHL2ZZWUROYktHZTZBcUlnenh1a21tRngwV21DR2trNHN1?= =?utf-8?B?eWR1VDV5WFJyaUFmU1YvWW9CaFFrQ1orUW10a1VRNEpDU3pqV1YvaGRQVXN4?= =?utf-8?B?TE02ekVXKzlpcjhiMGtjUU1QLzBEVjlhU3NJU2drM0RDYnM3MEJNZkJIQktN?= =?utf-8?B?ZVRCVnhaazNpb0RsNGovRm9YRHNhUVh1bmZBSVpiZk92bzE3UDdBdWl4TUdM?= =?utf-8?B?UFdkTE45Q1N4djUrZ3pWVDBqck1zeGJOTGRRV05JM2RyMGVzNmgwQmdiTC95?= =?utf-8?B?YitkRm9OL0ZEMFg0VlljSUp5N3pCRmJNMzFnYjd1cjZpWGFjYUxPK1FMd3Nm?= =?utf-8?B?akEveHJwci9QWHNvN3pnUDNTRkNnd3V6QUhndlpZWEQzYU1ycUk2ZURRVXZB?= =?utf-8?B?eTBXMEMwWVhXTGZ2SnNycUttanRGazI2Mjk1NDFsWjJpb29aYXQySnNUZXAv?= =?utf-8?B?WlVjclVJb0IvclkzYWtBbGU1NFZKTkpIdHdvcEw5NDJlSC9iQzZZWHJQQ3dk?= =?utf-8?B?eW96S2NUYXZ1aGUvT1JVN2ZiTnpuREJCVU9RK2xDNVNaaTllMWdQQjlZT21I?= =?utf-8?B?Q2FkSkNDc3VQaVZLby9STWtnbFFWUUluTXJOS0I2SzBUalhUNHg0endQNUt0?= =?utf-8?B?RjJTaVBUTUhSWDBjVEV6NUFOVUVsOEFYeEU5YzZDSzVETnVFV3JnTWhOSVJz?= =?utf-8?B?NzhwMFBBYkRWOXRISkt4VWZ2ZDhUVXltZElRVzRIcXpQNnladVJkRkI4Um9C?= =?utf-8?B?U2VXVEt2VFVYZ2R3blEwL1dpQ2ZVd1hiNG1jaDhOQ0svQnFVM1hLQ0pVcUJk?= =?utf-8?B?ZmlvT3RpcW9JZGt6czA0VThzOEVqcGs4MzgzbnhMSjNzWWtNRXRNQ2l6K0xB?= =?utf-8?B?LzMxVzR6T1ErMHVYT2wxTy8vSXNteUx1eUJFeDl1MDQ0VjV3TUpvaEoxdS9E?= =?utf-8?B?dUxrVUtGanpKM3dRZ1BZZDBSOStkV1YwVUQyV2lOcTdOdlYzUDVMa1hQd3Jp?= =?utf-8?B?REZFRStzbHlrb2hFU2Rjdms5cDNLMWF5VWJMNEdRZS9ldUVaWldxbGZBYXVp?= =?utf-8?B?OHQrTzh3RDgza282Nkxzdm52cjBPdFZQUFc3dEdsT2pvbTUxK2pUYmswY2Y4?= =?utf-8?B?WkVudWNPeE5RRWdKWC9YQUhrUFRVa3FOZmlXM3c2TEc4TEhFMVNTVDFoMnZC?= =?utf-8?B?YXYyb0JpcHFRbFFLS2p3cnlXNlllelBUSkxrSE9WUDZxQkdsSGVBY0dQU2NP?= =?utf-8?B?cDZxSEowb3Zka0JCTnNLbll2TVNHeWtTSGpPSnJBc01EOXNWb0ttaEVLVzNn?= =?utf-8?B?Zm84RkFPSWRQL05WSzQveThyaWZVVVZpUnU3d1MvTGcyY09mMzJlem4wckFR?= =?utf-8?Q?2GfoXJznXmV0bDTbKFgYCxa33?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d8a566c-a2e1-4dac-9ac8-08da8fe5690c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 08:54:29.9844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wcq5ZzOqjeY7dy16y0Pvgc7tDVfzX0ctdGX6YdQUpSzWVf22bNmLw/u5wGQhcKYH0D8kvU0wgGp+NIg7LNcBpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9201 On 01.09.2022 11:29, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:59:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:59:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399665.640898 (Exim 4.92) (envelope-from ) id 1oVUQV-0007aV-LH; Tue, 06 Sep 2022 08:59:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399665.640898; Tue, 06 Sep 2022 08:59:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUQV-0007aO-I2; Tue, 06 Sep 2022 08:59:23 +0000 Received: by outflank-mailman (input) for mailman id 399665; Tue, 06 Sep 2022 08:59:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUQU-0007aG-Pk for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 08:59:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 323a60c6-2dc2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 10:59:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADD3E139F; Tue, 6 Sep 2022 01:59:26 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 146843F7B4; Tue, 6 Sep 2022 01:59:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 323a60c6-2dc2-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v7 0/9] static shared memory on dom0less system Date: Tue, 6 Sep 2022 16:58:53 +0800 Message-Id: <20220906085902.944529-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. Penny Zheng (9): xen/arm: introduce static shared memory xen/arm: assign static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 xen: Add static memory sharing in SUPPORT.md SUPPORT.md | 7 + docs/misc/arm/device-tree/booting.txt | 132 +++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 165 +++++++++++ xen/arch/arm/domain_build.c | 408 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/setup.h | 7 + xen/arch/arm/mm.c | 42 ++- xen/common/domain.c | 3 + 10 files changed, 766 insertions(+), 9 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 08:59:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 08:59:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399666.640909 (Exim 4.92) (envelope-from ) id 1oVUQY-0007rJ-Sx; Tue, 06 Sep 2022 08:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399666.640909; Tue, 06 Sep 2022 08:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUQY-0007r9-Q0; Tue, 06 Sep 2022 08:59:26 +0000 Received: by outflank-mailman (input) for mailman id 399666; Tue, 06 Sep 2022 08:59:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUQX-0007aG-FV for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 08:59:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 33e0d0c3-2dc2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 10:59:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 868541756; Tue, 6 Sep 2022 01:59:29 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E9E503F7B4; Tue, 6 Sep 2022 01:59:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33e0d0c3-2dc2-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v7 1/9] xen/arm: introduce static shared memory Date: Tue, 6 Sep 2022 16:58:54 +0800 Message-Id: <20220906085902.944529-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085902.944529-1-Penny.Zheng@arm.com> References: <20220906085902.944529-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This patch series introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng --- v7 change: - add docs about checking for region overlap, etc - update docs to reflect that the host physical address is optional - end/bank_end may end up to be lower than paddr/mem->bank[i].start, So check that they don't overflow. - replace strcmp with strncmp since the string has already be validated - provide a dummy helper for process_shm_node() when !CONFIG_STATIC_SHM - remove useless #ifdef CONFIG_STATIC_SHM - change the order of property xen,shared-mem to xen,shared-mem = < [host physical address] [guest address] [size] > --- v6 change: - when host physical address is ommited, output the error message since xen doesn't support it at the moment - add the following check: 1) The shm ID matches and the region exactly match 2) The shm ID doesn't match and the region doesn't overlap - change it to "unsigned int" to be aligned with nr_banks - check the len of the property to confirm is it big enough to contain "paddr", "size", and "gaddr" - shm_id defined before nr_shm_domain, so we could re-use the existing hole and avoid increasing the size of the structure. - change "nr_shm_domain" to "nr_shm_borrowers", to not increment if the role is owner in parsing code - make "xen,shm_id" property as arbitrary string, with a strict limit on the number of characters, MAX_SHM_ID_LENGTH --- v5 change: - no change --- v4 change: - nit fix on doc --- v3 change: - make nr_shm_domain unsigned int --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 132 +++++++++++++++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 165 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 7 ++ 4 files changed, 310 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..1c50fc6351 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,135 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An arbitrary string that represents the unique identifier of the shared + memory region, with a strict limit on the number of characters(\0 included), + `MAX_SHM_ID_LENGTH(16)`. e.g. "xen,shm-id = "my-shared-mem-1"". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. + e.g. xen,shared-mem = < [host physical address] [guest address] [size] > + + It shall also meet the following criteria: + 1) If the SHM ID matches with an existing region, the address range of the + region shall also exactly match. + 2) If the SHM ID does not match with any other existing region, it should + also not overlap with any other regions. + + The number of cells for the host address (and size) is the same as the + guest pseudo-physical address and they are inherited from the parent node. + + Host physical address is optional, when missing Xen decides the location + (currently unimplemented). + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + DOMID_IO, a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x50000000 0x10000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x60000000 0x20000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x70000000 0x20000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as "my-shared-mem-0", host +physical address starting at 0x10000000 of 256MB will be reserved to be +shared between Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest +physical address space, and at 0x50000000 in DomU1 guest physical address space. +Dom0 is explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as "my-shared-mem-1", host +physical address starting at 0x50000000 of 512MB will be reserved to be +shared between DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest +physical address space, and at 0x70000000 in DomU2 guest physical address space. +DomU1 and DomU2 are both the borrower domain, the owner domain is the default +owner domain DOMID_IO. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 33e004d702..1fe5faf847 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -140,6 +140,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..b2cd425dac 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -361,6 +362,168 @@ static int __init process_domain_node(const void *fdt, int node, size_cells, &bootinfo.reserved_mem, true); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + const struct fdt_property *prop, *prop_id, *prop_role; + const __be32 *cell; + paddr_t paddr, gaddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned int i; + int len; + bool owner = false; + const char *shm_id; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + /* + * "xen,shm-id" property holds an arbitrary string with a strict limit + * on the number of characters, MAX_SHM_ID_LENGTH + */ + prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); + if ( !prop_id ) + return -ENOENT; + shm_id = (const char *)prop_id->data; + if ( strnlen(shm_id, MAX_SHM_ID_LENGTH) == MAX_SHM_ID_LENGTH ) + { + printk("fdt: invalid xen,shm-id %s, it must be limited to %u characters\n", + shm_id, MAX_SHM_ID_LENGTH); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * it must be either `owner` or `borrower`. + */ + prop_role = fdt_get_property(fdt, node, "role", NULL); + if ( prop_role ) + { + if ( !strcmp(prop_role->data, "owner") ) + owner = true; + else if ( strcmp(prop_role->data, "borrower") ) + { + printk("fdt: invalid `role` property for static shared memory node.\n"); + return -EINVAL; + } + } + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + prop = fdt_get_property(fdt, node, "xen,shared-mem", &len); + if ( !prop ) + return -ENOENT; + + if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) + { + if ( len == dt_cells_to_size(size_cells + address_cells) ) + printk("fdt: host physical address must be chosen by users at the moment.\n"); + + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } + + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); + size = dt_next_cell(size_cells, &cell); + + if ( !size ) + { + printk("fdt: the size for static shared memory region can not be zero\n"); + return -EINVAL; + } + + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * Meet the following check: + * 1) The shm ID matches and the region exactly match + * 2) The shm ID doesn't match and the region doesn't overlap + * with an existing one + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + { + if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + break; + else + { + printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", + shm_id); + return -EINVAL; + } + } + else + { + paddr_t end = paddr + size; + paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + + if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) + printk("fdt: static shared memory region %s overflow\n", shm_id); + + if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + { + if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) + continue; + else + { + printk("fdt: different shared memory region could not share the same shm ID %s\n", + shm_id); + return -EINVAL; + } + } + else + { + printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", + mem->bank[i].start, bank_end); + return -EINVAL; + } + } + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = true; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of borrowers, which later may be used + * to calculate the reference count. + */ + if ( !owner ) + mem->bank[i].nr_shm_borrowers++; + + return 0; +} +#else +static int __init process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + printk("CONFIG_STATIC_SHM must be enabled for parsing static shared memory nodes\n"); + WARN(); + return -EINVAL; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -386,6 +549,8 @@ static int __init early_scan_node(const void *fdt, process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..995eee1d09 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -23,10 +23,17 @@ typedef enum { } bootmodule_kind; +/* Indicates the maximum number of characters(\0 included) for shm_id */ +#define MAX_SHM_ID_LENGTH 16 + struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ +#ifdef CONFIG_STATIC_SHM + char shm_id[MAX_SHM_ID_LENGTH]; + unsigned int nr_shm_borrowers; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:00:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399678.640920 (Exim 4.92) (envelope-from ) id 1oVUR5-0000H6-CI; Tue, 06 Sep 2022 08:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399678.640920; Tue, 06 Sep 2022 08:59:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUR5-0000Gz-9V; Tue, 06 Sep 2022 08:59:59 +0000 Received: by outflank-mailman (input) for mailman id 399678; Tue, 06 Sep 2022 08:59:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUR4-0000Gk-FG for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 08:59:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUR4-0007Uw-82; Tue, 06 Sep 2022 08:59:58 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVUR4-0001F0-1k; Tue, 06 Sep 2022 08:59:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Ads4QvyUHYv6Lul4z7uLaa22n2NkmCOs2z0DnIPhCPI=; b=iinxC0M5XUmO3T9CanvsArJoJP Vd+HGbLWdX7zLqWgt2ulwqhMW6RMsTZ8mQJY18FIWnssbOLiKbCWzcO6juXp+kOrpZXS4i8u55lMN aVSNHHz+xXaLEcsfJ03+wlev6kbFjEGCWqD8xPMINlvYS/iYfHG4kRPPKNuoE+mIfmx0=; Message-ID: Date: Tue, 6 Sep 2022 09:59:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-4-Henry.Wang@arm.com> <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry On 06/09/2022 02:53, Henry Wang wrote: > Thanks for your comments, I added my reply and some of the questions > that I am not 100% sure inline below. > >> -----Original Message----- >> From: Julien Grall >> Hi Henry, >>> + >>> +/* >>> + * Find the contiguous xenheap region that fits in the reserved heap region >> with >> >> There might be multiple. So "Find a contiguous...". I would also drop >> "xenheap". > > I will follow the wording that you suggested here and ... > >> >>> + * required size and alignment, and return the end address of xenheap. >> >> I would write "and return the end address of the region if found >> otherwise 0". > > ...here. > >> >>> + */ >>> +static paddr_t __init fit_xenheap_in_reserved_heap(uint32_t size, paddr_t >> align) >>> +{ >>> + int i; >> >> Please use unsigned int. > > Ah sure. > >> >>> + paddr_t end = 0, aligned_start, aligned_end; >>> + paddr_t bank_start, bank_size, bank_end; >>> + >>> + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) >>> + { >>> + if ( bootinfo.reserved_mem.bank[i].type == MEMBANK_RSVD_HEAP ) >> NIT: You could avoid the extra indentation by reverting the condition. > > Sorry I am not 100% sure the extra indentation you were referring to. > Are you suggesting that we need to do a > ``` > if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_RSVD_HEAP ) > continue; > > bank_start = bootinfo.reserved_mem.bank[i].start; > ... > ``` > > ? Yes. > > If so I will change in v3. > >> >>> + { >>> + bank_start = bootinfo.reserved_mem.bank[i].start; >>> + bank_size = bootinfo.reserved_mem.bank[i].size; >>> + bank_end = bank_start + bank_size; >>> + >>> + if ( bank_size < size ) >>> + continue; >>> + >>> + aligned_end = bank_end & ~(align - 1); >>> + aligned_start = (aligned_end - size) & ~(align - 1); >> >> I find the logic a bit confusing. AFAIU, aligned_start could be below >> the start of the RAM which is not what I would usually expect. > > Yeah I understand your concern. Here I want to make sure even if > the given size is not aligned (although less likely happen in real life > given the size calculation logic in setup_mm) the code still work. I don't think I agree on the less likely here. The regions are provided by in the Device-Tree. And there are more chance they are incorrect because the value will be specific to a software/device stack. Related to this discussion, I can't find any alignment requirement in the device-tree binding. I think we at least want to require 64KB aligned (so the same Device-Tree works if we were going to support 64KB page granularity). >> >>> + >>> + if ( aligned_start > bank_start ) >>> + /* >>> + * Arm32 allocates xenheap from higher address to lower, so if >> >> This code is also called on arm32. So what are you referring to? Is it >> consider_modules()? > > Yes, I think the current arm32 behavior in consider_modules() is what > I am referring to. In fact, I just want to add some comments that explain why > we need the end = max(end, aligned_end) since technically if there are > multiple reserved heap banks and all of them can fit the xenheap region, > we can use either of them. But following the current behavior we can only use > the highest bank to keep the consistency. Xenheap is currently allocated the highest possible so there is enough low memory available for domain memory. This is in order to allow 32-bit DMA device to function. I am less certain this makes sense when the heap is reserved. Because an admin could decide to define the heap solely above/below 4GB. That said, nothing in the document suggests that domain memory would not be allocated from the reserved heap. So I would suggest to write the following comment: "Allocate the xenheap as high as possible to keep low-memory available (assuming the admin supplied region below 4GB) for other use (e.g. domain memory allocation)." Also, I think the documentation wants to be updated to clarify whether the reserved heap could be used to allocate domain. If it could, then I think we need to explain that the region should contain enough memory below some 4GB to cater 32-bit DMA. >> The new wording suggests that the 1GB limit only applies when the admin >> doesn't specify the reserved heap. However, we don't support larger heap >> than 1GB. So the limit should also apply for the reserved heap. So how >> about: >> >> - must be at most 1GB or 1/32 the total RAM in the system (or reserved >> heap if enabled) > > ...here. > >> >>> * - must be at least 32M >>> * >>> * We try to allocate the largest xenheap possible within these >>> * constraints. >>> */ >>> - heap_pages = ram_pages; >>> + heap_pages = bootinfo.reserved_heap ? reserved_heap_pages : >> ram_pages; >> >> You can avoid the ternary operation here by setting heap_pages in the >> 'if' above and add a else for the 'ram_pages' part. > > Sorry I might understand your comment in the wrong way, but do you > suggest we need to: > ``` > if ( bootinfo.reserved_heap ) > { > ... > heap_pages = reserved_heap_pages; > } > else > heap_pages = total_pages; > ``` > ? Yes. > If so I will do that in v3. Thanks. >>> + * in the boot allocator. >>> + */ >>> + if ( bootinfo.reserved_heap ) >>> + { >>> + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) >>> + { >>> + if ( bootinfo.reserved_mem.bank[i].type == >> MEMBANK_RSVD_HEAP ) >>> + { >>> + bank_start = bootinfo.reserved_mem.bank[i].start; >>> + bank_size = bootinfo.reserved_mem.bank[i].size; >>> + bank_end = bank_start + bank_size; >>> + >>> + init_boot_pages(bank_start, bank_end); >>> + } >>> + } >>> + } >>> + /* >>> + * No reserved heap regions: >>> * For simplicity, add all the free regions in the boot allocator. >>> */ >>> - populate_boot_allocator(); >>> + else >>> + populate_boot_allocator(); >> >> For arm32, shouldn't we also only add the reserved heap (minus the >> xenheap) to the boot allocator? At which point, I would move the change >> in populate_boot_allocator(). > > Sorry I am not sure what this comment about...as here the code is for arm64. Right, I wasn't sure where to comment because you don't touch the call to populate_boot_allocator(). > For the question, yes. > For the latter one, do you request some changes? If so, could you please kindly > elaborate a little bit more? Thanks. Yes I am requesting some change because I think the code on arm32 is incorrect (the boot allocator will not be populated with the reserved heap). I think the code should be moved in populate_boot_allocator(): if ( bootinfo.reserved_heap ) { for ( ...; i < bootinfo.reserved_mem.nr_banks; i++ ) [....] init_boot_pages_pages() } Note that to handle arm32, you will also need to exclude the xenheap area. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:00:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:00:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399679.640931 (Exim 4.92) (envelope-from ) id 1oVURC-0001Oc-Lc; Tue, 06 Sep 2022 09:00:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399679.640931; Tue, 06 Sep 2022 09:00:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVURC-0001OV-HW; Tue, 06 Sep 2022 09:00:06 +0000 Received: by outflank-mailman (input) for mailman id 399679; Tue, 06 Sep 2022 09:00:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVURA-0007aG-WC for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:00:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4bbc61ce-2dc2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:00:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81ABA139F; Tue, 6 Sep 2022 02:00:09 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A70BC3F7B4; Tue, 6 Sep 2022 02:00:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bbc61ce-2dc2-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v7 3/9] xen/arm: allocate static shared memory to a specific owner domain Date: Tue, 6 Sep 2022 16:59:35 +0800 Message-Id: <20220906085941.944592-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be introduced later in the following commits. Signed-off-by: Penny Zheng --- v7 chhanges: - adapt to the previous commits' changes --- v6 change: - fix coding-style - role_str and owner_dom_io shall be defined within the loop --- v5 change: - no change --- v4 change: - no changes --- v3 change: - simplify the code since o_gbase is not used if the domain is dom_io --- v2 change: - P2M mapping is restricted to normal domain - in-code comment fix --- xen/arch/arm/domain_build.c | 36 +++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index be98ff83b1..4be8a00171 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -822,9 +822,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, static int __init assign_shared_memory(struct domain *d, uint32_t addr_cells, uint32_t size_cells, - paddr_t pbase, paddr_t psize) + paddr_t pbase, paddr_t psize, + paddr_t gbase) { mfn_t smfn; + int ret = 0; dprintk(XENLOG_INFO, "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -838,8 +840,18 @@ static int __init assign_shared_memory(struct domain *d, * DOMID_IO is auto-translated (i.e. it seems RAM 1:1). So we do not need * to create mapping in the P2M. */ - ASSERT(d == dom_io); - return 0; + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, + PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + return ret; } static int __init process_shm(struct domain *d, @@ -855,6 +867,8 @@ static int __init process_shm(struct domain *d, paddr_t gbase, pbase, psize; int ret = 0; unsigned int i; + const char *role_str; + bool owner_dom_io = true; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; @@ -891,20 +905,28 @@ static int __init process_shm(struct domain *d, return -EINVAL; } - /* TODO: Consider owner domain is not the default dom_io. */ + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will * only find the borrowers. */ - if ( !is_shm_allocated_to_domio(pbase) ) + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { /* * We found the first borrower of the region, the owner was not * specified, so they should be assigned to dom_io. */ - ret = assign_shared_memory(dom_io, addr_cells, size_cells, - pbase, psize); + ret = assign_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:00:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399681.640942 (Exim 4.92) (envelope-from ) id 1oVURL-0001pP-Tq; Tue, 06 Sep 2022 09:00:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399681.640942; Tue, 06 Sep 2022 09:00:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVURL-0001pI-Q0; Tue, 06 Sep 2022 09:00:15 +0000 Received: by outflank-mailman (input) for mailman id 399681; Tue, 06 Sep 2022 09:00:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVURK-0007aG-EM for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:00:14 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5197c71e-2dc2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:00:13 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53905176C; Tue, 6 Sep 2022 02:00:19 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 78A923F7B4; Tue, 6 Sep 2022 02:00:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5197c71e-2dc2-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v7 6/9] xen/arm: set up shared memory foreign mapping for borrower domain Date: Tue, 6 Sep 2022 16:59:38 +0800 Message-Id: <20220906085941.944592-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v7 change: - no changes --- v6 change: - no change --- v5 change: - no change --- v4 changes: - no change --- v3 change: - use map_regions_p2mt instead --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mapping now. --- xen/arch/arm/domain_build.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index dbb880b5f2..d0ff487cc6 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -990,6 +990,15 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } } return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:09:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399695.640952 (Exim 4.92) (envelope-from ) id 1oVUZq-0003J4-Py; Tue, 06 Sep 2022 09:09:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399695.640952; Tue, 06 Sep 2022 09:09:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUZq-0003Ix-NH; Tue, 06 Sep 2022 09:09:02 +0000 Received: by outflank-mailman (input) for mailman id 399695; Tue, 06 Sep 2022 09:09:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVURU-0007aG-2M for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:00:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5750893b-2dc2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:00:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E62C1139F; Tue, 6 Sep 2022 02:00:28 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 82CF83F7B4; Tue, 6 Sep 2022 02:00:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5750893b-2dc2-11ed-a016-b9edf5238543 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v7 9/9] xen: Add static memory sharing in SUPPORT.md Date: Tue, 6 Sep 2022 16:59:41 +0800 Message-Id: <20220906085941.944592-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit on ARM, static memory sharing is tech preview, which shall be documented in SUPPORT.md Signed-off-by: Penny Zheng --- v7 changes: - doc refinement --- v6 change: - new commit --- SUPPORT.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 8e040d1c1e..1979824ce5 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -299,6 +299,13 @@ Allow sharing of identical pages between guests Status, x86 HVM: Experimental +### Static Memory Sharing + +Allow to statically set up shared memory on dom0less system, +enabling domains to do shm-based communication + + Status, ARM: Tech Preview + ### Memory Paging Allow pages belonging to guests to be paged to disk -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:21:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:21:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399703.640964 (Exim 4.92) (envelope-from ) id 1oVUls-0005xF-U2; Tue, 06 Sep 2022 09:21:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399703.640964; Tue, 06 Sep 2022 09:21:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUls-0005x8-RD; Tue, 06 Sep 2022 09:21:28 +0000 Received: by outflank-mailman (input) for mailman id 399703; Tue, 06 Sep 2022 09:21:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVUlr-0005wy-Io for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:21:27 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50086.outbound.protection.outlook.com [40.107.5.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 481d5f4c-2dc5-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:21:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4944.eurprd04.prod.outlook.com (2603:10a6:803:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 09:21:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 09:21:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 481d5f4c-2dc5-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GadAF7jcpK67JKFwn79SowcTw72/PwV7E9CyTLJhpdpEm2gaKnhHu1LTiIOtrKLLWsnp9uDd2nl/QA0NKphRvvPz5Jj1kv5JVP/iOzGfoO8hdiVqPgkZflJHIIf0U1e4pqlfQ2BRDjCKyp+K+G8fBsmI/vEzNtgeoaziOgV/KtZykVm3J/CBgwSJz6TfAmh4nTeUPxxpiRZkftDXvTdOHX0Eyu9dasQfJxEKglD4hQP05zVxwhPrFjGbZGilsppA/EI5gWFXQymxtlpiMDO2uwtbhWePsI1HdiRFWmNs4kZdqU3LrGB0QGhn4JU137AVFB6K7a1tJe3Lj+8dXYFCaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6IvH2vWjfNyw8BT5s4X14T5wXVPWT10Z9HdGeXBvR8=; b=IR7s6yQzJbJ19iDHnKnRghmUmCcXcBFIyEW8SGavQkDy9TscGsafUgoXskpGbg3RD2HMEy7lcGZEd3+/b78np5i20n9XiUtEYWj086XCREwSqsNCgdMQnsmNr2z2mZrbFXxCAt/c8MX99skRO5WWwCpgzkxoVv3/yBJc3iTQyWlFO3+ET6zfJgahXyb7zl94BTXfpxTowDA8weYmW2OjVmBzOXLK9qEBmPf4ae0vzhp02sUvdocaKf5Y2EBkmrs+KAhBVctMo2GrZmkVdA3CCJhC7ld86errwq/xpoUDbH9KuYaDu8hY+cQyrOLL0bJLEquCcHwkMm+SJ/JapZD6RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o6IvH2vWjfNyw8BT5s4X14T5wXVPWT10Z9HdGeXBvR8=; b=4fP50mM9yyVar7Cibzpf2jEQBbRjADflWWUlSLO4sb3tgitima98FMOXINOq43RL8auDqAS/8IVVluIXKZ/78EYt7shMFXDB61Uq0ZZKFQtuB6netlI8fBSob/ohqdEcI5pRHBvmMo5lET1RE76MAQqI+2jaXJO1XEp2cXR5ZL6DJc1l6BYfOP54pVI2rrrIJ++nYPLraks2ZgLisVnk/JNjb9x1CDilZQbDgPz4BugZeKeGofzZIUYTzB1M0dDKQIqX38CiNfiEt7vg7bwBGlcOpRQNxwnyQ2KejdVUSeqBFLO0CHmb9koh9joPx7rFK9TnzAUBAu79vziRkeW3Wg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 11:21:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 09/10] drivers/char: fix handling cable re-plug in XHCI console driver Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48425ba4-a1e6-4394-8181-08da8fe92927 X-MS-TrafficTypeDiagnostic: VI1PR04MB4944:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5eksSORK4+wFBWv42WQLJD+F3112eNUtqt7NHptJJw1/3gN2QnAWWfPiXnThpf83AjCCTBJvBK/z2Cu7QHVSnjc3t0nwarj9CJKQFjSYUI3xqaIdDC8+m6G1EIVqwYyCaBH7CXcmgh0J+Db5vQsxoVDBjjXo8D0BDJHq5pkeXsSccrvZjp64eaV8j8HsHParh5FVkNX/XmATPIo8o8j9ZuL/feaR60S2H85g7rqMHkKSMVIcGA1OZQsk+790N1xXvmpZMx4UvhQ8wpxKoKvIoC9vhup+HgqtqNOM8IjWXvdA5I/mFXNGYhb9MNc2+brEDRdD0JKk98po9mYZ0+QUa2X2Mtf8fjVac7ORjb9CQQRtcluJpFc0ChvHWBR4VKr/DQ99bPWun5QiNfuHDoHGYlFfuczJ1PRPhiIMK1TLpR8xo9w5egSqGe6RtlVt5h5R0I4yMYvlPVkhZXbdeH01/1bRRGocY3x2EvhISV65TbSsEAh/j6YOaHkTn8IbACseEpxKvP067mCz/BmESbw77L8xZyBBB3omlHTr+tdsGooWCHibXwUftveqkvyu70wnsNobXBREPG82p4X6qxkmUPqFIouDy6T+lzRKZmFP7yc29JGZMimwn8U7u3RzxRu7og6fKHm6IS2TsyQD0ITehwT9UTP3UEmGTEkxa4tZhchF3bGGKCNL+ykwMTvv5hrK8Lt+LS9Wmm5THS+wAzuLHgVf7frjAOpeiUlT0hK5zyNy9tvXhDADr03H2PCcjaq+Wf2KDy5dyLFzOH5GGkewYmj3XOx34HyqLl9K7V0l3ec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(136003)(376002)(346002)(6506007)(6512007)(53546011)(478600001)(83380400001)(41300700001)(26005)(2906002)(186003)(66574015)(6486002)(8936002)(5660300002)(54906003)(316002)(6916009)(4744005)(2616005)(36756003)(31686004)(8676002)(4326008)(66476007)(66946007)(66556008)(86362001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkxIN05lbG1ZQUJVSklmSHBxNnVUNHg4ZURlN21WWVNWeUpwMnJUVFE0aS9p?= =?utf-8?B?UVp6aWlBc3NlOHFZQmQ2bUJlRXVod0R6Y1J2anZLaWY4STZmbGsvNncyTFRZ?= =?utf-8?B?M3dKN3g3NFhFeFlnTFBJS0ovRFc1bDVXaTNTcTdmVnZ0NnNZaU1pUHkzM2Q0?= =?utf-8?B?ajlmMHdvTFhQbmZLOGNOaTIvb2VkaFZJTzZuekdNczI2NW5USFZOckRUWFJs?= =?utf-8?B?bWZDMmJoenR5ajdGU0REWUxHZzRpdDg1TmdrQWQ3S3Y0T2pPV3JMWGwwZzFF?= =?utf-8?B?MDZoSjBySThKSGRDZHJzQ2xNRVFjdVA1RGU2U1ZlNU9zckhWcDR1WlZQcC8v?= =?utf-8?B?RjJydTgzNFhXaVRNL0ZmajNnUXBJUnJpVjduaCs3Vm00bkJxU2lZOHV5cmhX?= =?utf-8?B?NlNkVXMvVG0xS2RpWnl2aUFLWnNHdER3ME5iTE5xdG5oTjc0amdHNjlZdE9U?= =?utf-8?B?d1BLUUVwbFN0TWdmUFV5Mm1hWnpiU1M4Y2ZJZnJWSVYyK1VKdGkvazRvMXdE?= =?utf-8?B?Zksvc2M2b25keDlxTGxUd2d4UW1pL2ZIY2V6N2pPaTNSR3FaZ3pNMUszbmJt?= =?utf-8?B?SmJkdytkVnlyVlhEa2pmR3BoL0NrVGRvTW5CWEtmc04yTG1aU2IwNHNxZmxa?= =?utf-8?B?WGU4VlQvN0N1MUVNbDRGK2tZMEJVKy9vVEFjNGJxaHBGc2Y5ZG9IT0tJRGNJ?= =?utf-8?B?YzJTVWVXaU11a3lGb2dUK3JGTmRzWlFManVCNVJ3TTVwdTYwZFlWeURIaGZS?= =?utf-8?B?ZkFkSG5naG9GTFVmeEtMbVFIS1lVQVBOekc2TnN4Yzc2cmNCTXE3bDZlRjl0?= =?utf-8?B?VUZCNWVFTEcxcnlLU2pPUFZKcGRuVU9ab2E3WHh0aGkxZnV5ZDQ3b0NwNnZy?= =?utf-8?B?N2xZVWNYZ1VjUVY2SVFRM3hVOGg2aVF5QVhJUCtlL1RtNnhaMmlRTGw5Skc0?= =?utf-8?B?dWkyQy96VHR4aVY1c3JGYjZKYzRLNlVqWEJ6SnllRVlIWGJJdXU3bHM5bGh3?= =?utf-8?B?ZlYyUUFtdXFIZ3Y3SHlBbVlER2tjS0EyL3h1cEJjUlV1UUtBMHlxZ29pVEdT?= =?utf-8?B?TVZ0YUtscVJQUloxTVRqU1lmV3h6Z3haY1NSa0h5VFZQRDNVbzBnZGFxQkNl?= =?utf-8?B?Rm9pVEdGZlFsV1NDRXJHcHFMc1lvYnBMRkpmbm02OHFGKy9hNEcrSmtMUnFn?= =?utf-8?B?M0hWWmRvZUNEU0ZuRTR4QjRqNjdnZTJTbVRRVWZxcExCOUVMR2ZNOTg2YkJr?= =?utf-8?B?Mm5yNUMremhqdjA4Wk1ML1J2TzhId1l1dE9ObW9YQkZKU0oyYW1NSVJSWDhz?= =?utf-8?B?Z09vb2k2UlhQSGMwUXhvVHpvWTNjWHZodWlZRHFZazE5NlpqVFBSTkhDY2R5?= =?utf-8?B?MWFBT3oxSllBUTFvMWQ4REF6dC9wS1lWU0ZxNDR5cEl6M3hpTm4zOHhrYVhj?= =?utf-8?B?ZjBNcHpsQjJKNFh5QzNEd2dyMUNsTkxLNkphbzJoeTFsVkE3ai9la1NzM1ln?= =?utf-8?B?dVp2YTFCNXpXTGFZVGxqazhhWW12dkZ6MzBUeDB2SGZuNE9xN3ZwQVQ0eHh6?= =?utf-8?B?U2NvRUo0Lzh1WXN2ZXFXSVlYMytyY0VVWTJUdmMrN2hqWnBvYjZYSVJmUW8w?= =?utf-8?B?dXVxVlBENEc4OUN5MDZ0U3c4WFRNdGZKOTZ2S2w0cTAxL05zSlpSSGZPOEti?= =?utf-8?B?UDluS0pUZGVaY09aVlFOcUN0a1MrbUM4bVh3OHlPM0hDSGNNc1MxRTdXelZV?= =?utf-8?B?RUhhemUvTkVQYU53WUVWTFVab2hhYlpIWWRHOFVtQWNaT1NCNk03QjB1dUN6?= =?utf-8?B?YkRVOENqNnJvZ0F6Z0p5M1V0NU5LRGZ2c1llVmV3WCtDaENIUkRvLzdJOFZZ?= =?utf-8?B?ZWhBb3dvK0tIYVBWbGt2aVZNekZUeXdScEZoTjBYaDAvcVpEUkVQaTI0cGhV?= =?utf-8?B?Tm0zaFVpeWRhWGFZUnk4TklSMVJqcy9uSkMxMkoybHZ2SXZQTHdqSHUwQjVG?= =?utf-8?B?QVFNTnFQSWp2THRrVmt6YmU5YWx3NUpXbE8raVF3V0lhTlQza0NFZ3R5M2xL?= =?utf-8?B?MmZwcmdXTDBEcmFlR3drdlVxcExXRHdpREtxL3pDS3EzWUNkMDB3d08vSkpI?= =?utf-8?Q?Hm5i9I/f/htiPiWdSlBYceGMs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48425ba4-a1e6-4394-8181-08da8fe92927 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:21:20.8359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P4tKp8dicxxDYyvqlfFTWLRtyT+2+1kN50Rp/Y8aP80JzjZw17tqHTD3xOwJdYT2uNbAm0HQJvgy7p/C7d+nfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4944 On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote: > When cable is unplugged, dbc_ensure_running() correctly detects this > situation (DBC_CTRL_DCR flag is clear), and prevent sending data > immediately to the device. It gets only queued in work ring buffers. > When cable is plugged in again, subsequent dbc_flush() will send the > buffered data. > But there is a corner case, where no subsequent data was buffered in the > work buffer, but a TRB was still pending. Ring the doorbell to let the > controller re-send them. For console output it is rare corner case (TRB > is pending for a very short time), but for console input it is very > normal case (there is always one pending TRB for input). > > Extract doorbell ringing into separate function to avoid duplication. > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:39:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:39:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399709.640975 (Exim 4.92) (envelope-from ) id 1oVV3L-0008F5-H1; Tue, 06 Sep 2022 09:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399709.640975; Tue, 06 Sep 2022 09:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVV3L-0008Ey-EB; Tue, 06 Sep 2022 09:39:31 +0000 Received: by outflank-mailman (input) for mailman id 399709; Tue, 06 Sep 2022 09:39:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVV3J-0008Em-RL for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:39:30 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20077.outbound.protection.outlook.com [40.107.2.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc67c12f-2dc7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:39:27 +0200 (CEST) Received: from DB3PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:8:1::30) by DU0PR08MB9001.eurprd08.prod.outlook.com (2603:10a6:10:466::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Tue, 6 Sep 2022 09:39:23 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::bc) by DB3PR06CA0017.outlook.office365.com (2603:10a6:8:1::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 09:39:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 09:39:22 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 06 Sep 2022 09:39:22 +0000 Received: from 27659bedd814.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7595D721-0F25-4534-B7E1-B9CD564ECEA1.1; Tue, 06 Sep 2022 09:39:13 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 27659bedd814.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 09:39:13 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB8188.eurprd08.prod.outlook.com (2603:10a6:10:3ef::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 6 Sep 2022 09:39:10 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 09:39:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc67c12f-2dc7-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GmzlmGZQfNWypm25pveE4q1TIO1hbeAzi1dOHnDO33XVcYdhGK7sB9h82eLGGaU9Xm3I4xWHUyWn1hy+2g0WilV0XnaGye4R8Wd8Lb4VRLY00W965EXDezyEZRVh7o5pKfIZvfG2B9P/LUmiKFni7BzsWHbaNtdRkzI7DDosZre82dZk5oVPNrvcFwJxPZ29J1no+pjNroRGq4hmnX4rzlveBab/MzRI3PovDxz+IWaaBCuX+BdFgAFJ06el9bVNustZ5uLHpcYzIBTrmo6ftRVW9OA+6FRild38gB01W71Md8xSXhmwJBd6GU/bLX4uB17VT6otl4SsEpnalr9yvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qSqeE592xvhkUBWetSl34h7RM7sjBOZA7wawoa34qmU=; b=TQ3uFQQxbp9kZpcgsfQZ8i02ZeBIPjSXopyEzlGp8WDDE4rMgMdmGBE9Pl1uVd34C0ozaFnLqciO9TufNoP3FLd5GhzFix1XepoAgTDaN8sKfBgGgUAagnnL8rFtbj6TEsXTG9PCCeMq4gbWwObxHvL7kO//nlzqfOkqpKANtBkIP7NlfAO9XW7HnGscrFJD279Qm6Ea3A/e7DgEjjhYoi65jiVB+FIxORGX2NHqot36sjxfTZaq3mhuZ3DxCfklDw/HQx8BkjTzCpfH7VTELYpOBwFhmAAYJMAGP/ZBG7tJ5EooRWGD8Q7XQBxrq3CoSGqpfEqppVDrbOgxXGCoDQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSqeE592xvhkUBWetSl34h7RM7sjBOZA7wawoa34qmU=; b=h9XN0jaM1r41Kw3uRUxFFGtGqWzc/XSI/0emCz66zXkxYfNSBuyZY50pLL6ZgiJ1f/vUZCSKnwCW6lcPtcmDFqTcoDqcgOV+4cI1JukZ7kZto7aOe+opKFlbn6qU6O6fyqdrZkE2CkvuFvxlDi/qRf2hW5mpKt1UGhQPE8IAER4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bee93cb2331094b5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsPcP2LOmCtCaCfq1O9eq5Tqdf38bd9YoEXmcB45tpmWUaXwFOz8iLofVStNz1c6noRSdVXjx5Wgt5UUD6t69g76re18EYY1tN6dbQj+Qb0ARxCdO2XQiN4CxYdA9WNcxh7BBgH7R0XFA4kSQKLXQxMh8Pyns3NIrQTkKY81FCVcJbiJnR16DkREYPRiFHBilhgcWe/HOypLUuCVEZRbcrNcVoWZr06kPAbBLwp52bCf9+WlHUcBJqZK9bZDTLYvWvwxM6t9gLebVfD+0G+zLxlXFBLWRFZ1sChLgYG07XbSugyrzBKxNkZOu4wfuLMkr9Eg6FSmk+iRZRT77Luamw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qSqeE592xvhkUBWetSl34h7RM7sjBOZA7wawoa34qmU=; b=FLisW3OzzA4VoBErPLu3eoyiNvNwIltO1+7Lp89/XPRTCmlNcOU65/5rujm9BO6tHIA0e8aAYxVEiEHMobqGbr29NLGf7TPADHEoWtRNmAem29WypzRh/NDPK3TUEEeijZRf1Q9pNVwBWEYXbFTEV2bEELg/pyO0t4L19277TOJxRpMxSlsVcq6SSTjVqfblkkSjnoSyby0tqbIvSMytB26Sj8vfesGTWJa0JmIHkHnbBfo6acLa/57WeGpE2+Tv/SxgeXIvt9RXsvbSI9JXQvnL33s+TAgffwE0SToOIx1qDTjU0GArOmVrkC4enf7XchBVAFhjWrQ0pjRKsixqsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSqeE592xvhkUBWetSl34h7RM7sjBOZA7wawoa34qmU=; b=h9XN0jaM1r41Kw3uRUxFFGtGqWzc/XSI/0emCz66zXkxYfNSBuyZY50pLL6ZgiJ1f/vUZCSKnwCW6lcPtcmDFqTcoDqcgOV+4cI1JukZ7kZto7aOe+opKFlbn6qU6O6fyqdrZkE2CkvuFvxlDi/qRf2hW5mpKt1UGhQPE8IAER4= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Paul Durrant Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYveWaAk0wZPH8TEaypPBHbuXyK63NTxAAgATeK4A= Date: Tue, 6 Sep 2022 09:39:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8d96e6cc-88ba-4453-3a2b-08da8febadf8 x-ms-traffictypediagnostic: DU0PR08MB8188:EE_|DBAEUR03FT042:EE_|DU0PR08MB9001:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Z2JLkn5/StRdOft2S8jmd49GTi2E/0XVMOOKhhIwxMQN+J+t8cvPhTWW3XydXbvIuqcoqnOwWP+6x0eh40H+lNnCD+B8z7lgQqvhYYYuAdqZh++IbvZCU4V+nvUbBypCVXhv8+wJ6C11EjnN7/N+aSSgsYmHgIYQj/heYToRVCls6GVOj1UM+vdOsQ1sdXB49LSetWmh4/zLx2aXQWhWccL10ZXtIdbPAAa6P77RwXdyuXSE0JTw5gNAEx8DVkkcmuroM9gvSEtPYB1ynzEY1n8VJpIxud0hQYn1Maq400ktw+VoRce0yFO+317SF8majzAbqYz/X4hkiN7W4LF0UFBLImP9srepl+X/+4F+4mIlFbaYcCIzL+oFHOoSdgN/GvCTqmuu4JhN+j95AuPXalQUCx7zADhtcaDeDqCl2hDbSiADlflY3eVYazah1G+gswiwqFKs58gZlF5oy45HMF/Q0mtxf4LGww3BkFfNeWsG1biWVut8jszPXc0zHNsFce8fGX1sBFb0T9yjm8raDRSRtPmdl3KgvzqEKWuESpiDDBPwsE7G7JG541VG9/lIYYwrxrtpaoMgdJ5TJCNg3WrM0X+7vkkMPdvCsHa9Yhl9x1sgmIht2GVxV1dQo0C4rSA/gXoVlTHVQi//ezf2WxWhEUiLmOPm+d7z8PTsXC14iM/Gcb9lljvv2lN/VgXdSoIkm5FEWzrm8/lgM47btfgzeTZa9WlxPxbU3NgktKsgyBlmEqJsa6OTgmCceyAfFLGXn2yJDZlNP9AyLtUXo7SU1SC7liFZDyGOcVPIWT4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(346002)(396003)(376002)(41300700001)(8936002)(33656002)(38070700005)(53546011)(122000001)(478600001)(66476007)(4326008)(66446008)(64756008)(8676002)(2906002)(66556008)(83380400001)(91956017)(5660300002)(76116006)(186003)(38100700002)(6506007)(6486002)(36756003)(66946007)(86362001)(6512007)(54906003)(26005)(71200400001)(6916009)(2616005)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <7CB62400E190FC4E97642FCDD0F1CF1D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8188 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 65283d5f-09fe-4f9d-330e-08da8feba655 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8VllG15073d8iFNKb4vV27w8g6OI5LVh/f36sJxvm0UIS2M4WTLj4GlZ+3tP8O96WwbMRkJWP6P23ZjcYX3nNb1Grr23OzIwQ6L8bCJXyI9APj2NwM5KxaP8pUlkfFbYlNkVeDD3ZMc0DB0aFG698osTCZgSk5xp2q3UmKM7pf2moK61NX+kC9lv/bCxuazskwHFFsKGkWHNDUaCjQZWfUe/+yfmrM67C/he2x93oqT54AdM97YhdVgG2qEP43I7/NLG7K5AMeUhlUWcr+W8B+yhwHJy2eoFKYPaR/ryBjncqHfpM7ZF6ettePU4EoOHjmHkxZS7FP+yeprHLMOyjPSEa6rc+OAMTR+yA2z4fLFKa9Qfv1y8uvaSkhk+R3KomGqaE0YOa348p8XK8E7RwQyofruxpevW/eMV0sJ1Gb0g04C2+a+i3qxrDrOw58YznjcERCwzCZabpgqNox3OYg92CwOftBf18+kcPk6uB/Bw29eKN1WrPNPnRjt0T6s8HugAI6+RWBLwz6Yrny1AnFO1cvMaq2T0NFIv1WZeJL2uA7UVGrphyXfX8HixCo//NFVGTK6qeaE07BJoKkPuw8rySKbBU16eGNjxuOlAfWKGsJyQ8iFfvpFQoCFyeDwcVhbxezBQSudmtQzH6FuHHctei2MOA6XjlD8dPIes+np0BcK3Wtj1SfwAJ0XALZ6B/Tk5ZAMpoJQYtZljtroCeMqox6k0w9wrTYcZ2nS3Y9JPE00lU8aH7C3z4yHHYE9A8imFAHV5XFdG2D0Aajg/6g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(36840700001)(40470700004)(46966006)(70206006)(356005)(70586007)(47076005)(36860700001)(5660300002)(33656002)(54906003)(316002)(6862004)(36756003)(40480700001)(4326008)(8676002)(86362001)(2906002)(8936002)(82310400005)(6512007)(41300700001)(53546011)(478600001)(83380400001)(2616005)(26005)(40460700003)(336012)(6506007)(82740400003)(186003)(6486002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:39:22.5002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d96e6cc-88ba-4453-3a2b-08da8febadf8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9001 SGkgSnVsaWVuLA0KDQo+IE9uIDMgU2VwIDIwMjIsIGF0IDg6MTggYW0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgUmFodWwsDQo+IA0KPiBPbiAwMS8wOS8y MDIyIDEwOjI5LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IGlzX21lbW9yeV9ob2xlIHdhcyBpbXBs ZW1lbnRlZCBmb3IgeDg2IGFuZCBub3QgZm9yIEFSTSB3aGVuIGludHJvZHVjZWQuDQo+PiBSZXBs YWNlIGlzX21lbW9yeV9ob2xlIGNhbGwgdG8gcGNpX2NoZWNrX2JhciBhcyBmdW5jdGlvbiBzaG91 bGQgY2hlY2sNCj4+IGlmIGRldmljZSBCQVIgaXMgaW4gZGVmaW5lZCBtZW1vcnkgcmFuZ2UuIEFs c28sIGFkZCBhbiBpbXBsZW1lbnRhdGlvbg0KPj4gZm9yIEFSTSB3aGljaCBpcyByZXF1aXJlZCBm b3IgUENJIHBhc3N0aHJvdWdoLg0KPj4gT24geDg2LCBwY2lfY2hlY2tfYmFyIHdpbGwgY2FsbCBp c19tZW1vcnlfaG9sZSB3aGljaCB3aWxsIGNoZWNrIGlmIEJBUg0KPj4gaXMgbm90IG92ZXJsYXBw aW5nIHdpdGggYW55IG1lbW9yeSByZWdpb24gZGVmaW5lZCBpbiB0aGUgbWVtb3J5IG1hcC4NCj4+ IE9uIEFSTSwgcGNpX2NoZWNrX2JhciB3aWxsIGdvIHRocm91Z2ggdGhlIGhvc3QgYnJpZGdlIHJh bmdlcyBhbmQgY2hlY2sNCj4+IGlmIHRoZSBCQVIgaXMgaW4gdGhlIHJhbmdlIG9mIGRlZmluZWQg cmFuZ2VzLg0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5j b20+DQo+PiAtLS0NCj4+IENoYW5nZXMgaW4gdjM6DQo+PiAgLSBmaXggbWlub3IgY29tbWVudHMN Cj4+IC0tLQ0KPj4gIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9wY2kuaCAgICAgfCAgMiArKw0K Pj4gIHhlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMgfCA0MyArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysNCj4+ICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vcGNpLmggICAg IHwgMTAgKysrKysrKw0KPj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jICAgICAgfCAg OCArKystLS0NCj4+ICA0IGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BjaS5oIGIv eGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BjaS5oDQo+PiBpbmRleCA4MGEyNDMxODA0Li44Y2I0 NmY2YjcxIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BjaS5oDQo+ PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vcGNpLmgNCj4+IEBAIC0xMjYsNiArMTI2 LDggQEAgaW50IHBjaV9ob3N0X2l0ZXJhdGVfYnJpZGdlc19hbmRfY291bnQoc3RydWN0IGRvbWFp biAqZCwNCj4+ICAgIGludCBwY2lfaG9zdF9icmlkZ2VfbWFwcGluZ3Moc3RydWN0IGRvbWFpbiAq ZCk7DQo+PiAgK2Jvb2wgcGNpX2NoZWNrX2Jhcihjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwg bWZuX3Qgc3RhcnQsIG1mbl90IGVuZCk7DQo+PiArDQo+PiAgI2Vsc2UgICAvKiFDT05GSUdfSEFT X1BDSSovDQo+PiAgICBzdHJ1Y3QgYXJjaF9wY2lfZGV2IHsgfTsNCj4+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jIGIveGVuL2FyY2gvYXJtL3BjaS9wY2kt aG9zdC1jb21tb24uYw0KPj4gaW5kZXggODllZjMwMDI4ZS4uMGViMTIxNjY2ZCAxMDA2NDQNCj4+ IC0tLSBhL3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMNCj4+ICsrKyBiL3hlbi9h cmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMNCj4+IEBAIC0yNCw2ICsyNCwxNiBAQA0KPj4g ICAgI2luY2x1ZGUgPGFzbS9zZXR1cC5oPg0KPj4gICsvKg0KPj4gKyAqIHN0cnVjdCB0byBob2xk IHBjaSBkZXZpY2UgYmFyLg0KPj4gKyAqLw0KPiANCj4gSSBmaW5kIHRoaXMgY29tbWVudCBhIGJp dCBtaXNsZWFkaW5nLiBXaGF0IHlvdSBhcmUgc3RvcmluZyBpcyBhDQo+IGNhbmRpZGF0ZSByZWdp b24uIElPVywgdGhpcyBtYXkgb3IgbWF5IG5vdCBiZSBhIFBDSSBkZXZpY2UgYmFyLg0KPiANCj4g R2l2ZW4gdGhlIGN1cnJlbnQgdXNlIGJlbG93LCBJIHdvdWxkIHJlbmFtZSB0aGUgc3RydWN0dXJl IHRvIHNvbWV0aGluZyBtb3JlIHNwZWNpZmljIGxpa2U6IHBkZXZfYmFyX2NoZWNrLg0KDQpBY2su DQo+IA0KPj4gK3N0cnVjdCBwZGV2X2Jhcg0KPj4gK3sNCj4+ICsgICAgbWZuX3Qgc3RhcnQ7DQo+ PiArICAgIG1mbl90IGVuZDsNCj4+ICsgICAgYm9vbCBpc192YWxpZDsNCj4+ICt9Ow0KPj4gKw0K Pj4gIC8qDQo+PiAgICogTGlzdCBmb3IgYWxsIHRoZSBwY2kgaG9zdCBicmlkZ2VzLg0KPj4gICAq Lw0KPj4gQEAgLTM2Myw2ICszNzMsMzkgQEAgaW50IF9faW5pdCBwY2lfaG9zdF9icmlkZ2VfbWFw cGluZ3Moc3RydWN0IGRvbWFpbiAqZCkNCj4+ICAgICAgcmV0dXJuIDA7DQo+PiAgfQ0KPj4gICtz dGF0aWMgaW50IGlzX2Jhcl92YWxpZChjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwN Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBhZGRyLCB1aW50NjRfdCBsZW4s IHZvaWQgKmRhdGEpDQo+PiArew0KPj4gKyAgICBzdHJ1Y3QgcGRldl9iYXIgKmJhcl9kYXRhID0g ZGF0YTsNCj4+ICsgICAgdW5zaWduZWQgbG9uZyBzID0gbWZuX3goYmFyX2RhdGEtPnN0YXJ0KTsN Cj4+ICsgICAgdW5zaWduZWQgbG9uZyBlID0gbWZuX3goYmFyX2RhdGEtPmVuZCk7DQo+PiArDQo+ PiArICAgIGlmICggKHMgPD0gZSkgJiYgKHMgPj0gUEZOX0RPV04oYWRkcikpICYmIChlIDw9IFBG Tl9VUChhZGRyICsgbGVuIC0gMSkpICkNCj4gDQo+IEFGQUlDVCAncycgIGFuZCAnZScgYXJlIHBy b3ZpZGVkIGJ5IHBjaV9jaGVja19iYXIoKSBhbmQgd2lsbCBuZXZlciBjaGFuZ2UuIFNvIGNhbiB3 ZSBtb3ZlIHRoZSBjaGVjayAncyA8PSBlJyBvdXRzaWRlIG9mIHRoZSBjYWxsYmFjaz8NCg0KWWVz LCBXZSBjYW4gbW92ZSB0aGUgY2hlY2sgb3V0c2lkZSB0aGUgY2FsbGJhY2sgYnV0IEkgZmVlbCB0 aGF0IGlmIHdlIGNoZWNrIGhlcmUgdGhlbiBpdCBpcyBtb3JlDQpyZWFkYWJsZSB0aGF0IHdlIGFy ZSBjaGVja2luZyBmb3IgYWxsIHBvc3NpYmxlIHZhbHVlcyBpbiBvbmUgc3RhdGVtZW50LiBMZXQg bWUga25vdyB5b3VyIHZpZXcgb24gdGhpcy4NCg0KPiANCj4+ICsgICAgICAgIGJhcl9kYXRhLT5p c192YWxpZCA9ICB0cnVlOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+ PiArYm9vbCBwY2lfY2hlY2tfYmFyKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBtZm5fdCBz dGFydCwgbWZuX3QgZW5kKQ0KPj4gK3sNCj4gDQo+IE90aGVyIHRoYW4gdGhlIGN1cnJlbnQgY2Fs bHMgaW4gY2hlY2tfcGRldigpLCBkbyB5b3UgaGF2ZSBwbGFuIHRvIHVzZSBpdCBpbiBtb3JlIHBs YWNlcz8gVGhlIHJlYXNvbiBJIGFtIGFza2luZyBpdCBpcyB0aGlzIGZ1bmN0aW9uIGlzIG5vbi10 cml2aWFsIG9uIEFybSAoZHRfZm9yX2VhY2hfcmFuZ2UoKSBpcyBxdWl0ZSBjb21wbGV4KS4NCg0K SSBkb27igJl0IHNlZSBhbnkgdXNlIG9mIHRoaXMgZnVuY3Rpb24gaW4gbW9yZSBwbGFjZXMuIEFz IHRoaXMgZnVuY3Rpb24gd2lsbCBiZSBjYWxsZWQgZHVyaW5nIGRvbTAgYm9vdCB3aGVuIHRoZSBQ Q0kgZGV2aWNlcyBhcmUNCmFkZGVkIEkgZG9u4oCZdCBzZWUgYW55IHBlcmZvcm1hbmNlIGlzc3Vl cy4gV2UgbWF5IG5lZWQgdG8gcmV2aXNpdCB0aGlzIGZ1bmN0aW9uIHdoZW4gd2UgYWRkIEFDUEkg UENJIHBhc3N0aHJvdWdoIHN1cHBvcnQuDQpJIHdpbGwgYWRkIFRPRE8gdGhhdCB3ZSBuZWVkIHRv IHJldmlzaXQgdGhpcyBmdW5jdGlvbiBmb3IgQUNQSSBQQ0kgcGFzc3Rocm91Z2ggc3VwcG9ydC4N CiANCg0KUmVnYXJkcywNClJhaHVs From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:44:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:44:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399717.640986 (Exim 4.92) (envelope-from ) id 1oVV84-0001Nk-3n; Tue, 06 Sep 2022 09:44:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399717.640986; Tue, 06 Sep 2022 09:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVV83-0001Nd-W5; Tue, 06 Sep 2022 09:44:23 +0000 Received: by outflank-mailman (input) for mailman id 399717; Tue, 06 Sep 2022 09:44:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVV83-0001NV-4r for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:44:23 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a798841-2dc8-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:44:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a798841-2dc8-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662457460; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bPyyuT8mKNP4f28QVf9lsNEun9V5OpHrXza/LRAjcSM=; b=a1kdPCqFyzQbzUdtJIobPYYsPYUGeLHadfWpIu474LhFk3FnKJX35Xaq 7GniVqH9JQcjkbQO6P2iLy1M+Pexfj0Ml/LktASwBQ9n4q6wXADLLy0Mz 1lT0RgasWSOedzjRtQAb4CQf4hrqUtCeNUr9fC6SNf18euQqCj3RKhVm1 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 82351095 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:zcNVl6uI5d/yLsUlTE1iRdepFufnVI1eMUV32f8akzHdYApBsoF/q tZmKTuPO/bZazb8fdtyaNu0/ENSsZSBx9JkTgI+qi8zHnlB+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4G1A5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fc49wPRXHkdHz LsVJylVTzqmq9K2zr3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYICOJ4XSFJg9ckCw/ E3/+XTpGDomKtW62SWhrlyBoMHvpHauMG4VPOLhraM76LGJ/UQ5BQcKT1K9rb+cg1SnRtNEA 0UO/2wlqq1a3HKsSt7xThipukmutxQXW8dTO+Ai4QTLwa3Riy6GAkAUQzgHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LEqOzlZvqGDL0y jaGoTIWg7QVhNQMkaKh8jjvgS+op5XPZh444EPQRG3NxhhieIevaois6F7axfVNNoCUSh+Gp ndspiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqR1KJYsB6BKkwjmucpkIwRtbCHdpPMlRLFcFf 3TvVRNtCI57ZSX0N/cnONPvVazG3oC7S427C6m8gs5mJ8EoKVTZpHwGiVu4hTiFraQ6rU0o1 X53m+6IBG1SN6loxSHeqww1ge5ynXBWKY8+qPnGI/WbPVm2PiT9pU8tagfmUwzAxPrsTP/p2 9heLdCW7B5UTffzZCLamaZKcw5QcSBhVM+t8ZMOHgJmHuaBMDh4Y8I9PJt7I9A190irvrygE o6Btr9wlwOk2CyvxfSiYXF/crL/NatCQYYAFXV1ZT6VN40LO9nHAFE3K8RqJtHKNYVLkZZJc hXyU5/eUqgXGmubpG51gFuUhNUKSSlHTDmmZ0KNCAXTtbY6L+AV0rcIpjfSyRQ= IronPort-HdrOrdr: A9a23:+CPVr6lXUAtNCgqPKQXSXCcNbU/pDfIs3DAbv31ZSRFFG/Fxl6 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyXMbEQt6fHCWeDfOod/A== X-IronPort-AV: E=Sophos;i="5.93,293,1654574400"; d="scan'208";a="82351095" Date: Tue, 6 Sep 2022 10:44:12 +0100 From: Anthony PERARD To: Jens Wiklander CC: , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , , Juergen Gross , Wei Liu Subject: Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator Message-ID: References: <20220818105601.1896082-1-jens.wiklander@linaro.org> <20220818105601.1896082-4-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220818105601.1896082-4-jens.wiklander@linaro.org> Hi Jens, On Thu, Aug 18, 2022 at 12:55:55PM +0200, Jens Wiklander wrote: > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de093914..a985609861c7 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + config->arch.ffa_enabled = > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); There seems to be missing a call to libxl_defbool_setdefault() before this. This could result in an abort when creating a guest for Arm. A call to libxl_defbool_setdefault() probably want to be done in libxl__arch_domain_build_info_setdefault() in libxl_arm.c. > return 0; > } > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index b98c0de378b6..e0e99ed8d2b1 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2746,6 +2746,9 @@ skip_usbdev: > exit(-ERROR_FAIL); > } > } > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); This should be done in libxl (as pointed out above) instead of xl. > + xlu_cfg_get_defbool(config, "ffa_enabled", > + &b_info->arch_arm.ffa_enabled, 0); > > parse_vkb_list(config, d_config); > Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:52:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:52:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399725.640997 (Exim 4.92) (envelope-from ) id 1oVVFU-000376-TW; Tue, 06 Sep 2022 09:52:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399725.640997; Tue, 06 Sep 2022 09:52:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVFU-00036z-PB; Tue, 06 Sep 2022 09:52:04 +0000 Received: by outflank-mailman (input) for mailman id 399725; Tue, 06 Sep 2022 09:52:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVFT-00036t-Lm for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:52:03 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2042.outbound.protection.outlook.com [40.107.21.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e42ca8f-2dc9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:52:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3493.eurprd04.prod.outlook.com (2603:10a6:209:b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 09:51:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 09:51:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e42ca8f-2dc9-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ztdh6pP11EmKUdhcgZ6sGw8/jTYFbAJReNaRHieS2+kxDlxhXGPqptM7VqPHjqgLIJnWjlhGFidqPGBz6x+r18+4yTveXRVJoLeyVPfbD1LfAdzc06KUnipPImkf8ZdETz47ZdHX7c2M5GNaA1hnWsn3iqZpBKBZb5KSwbbw3EkPZuAu9vWVzzb8sCS4aQXPHmvRv+1Y1azVIDfYue2iKlwtgUdaQDmwkLcq99aTFAPpV4GNBAmWtmm2WDm96nBgJNhWrqVgOiPonlhWWa/l2PcriTyPFc1eHtjfis6SeyDxd3jCpoZlB/R5aJFq4/BZJyCsAzJxbSmcXi8p2PRHsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zLLg6gFadAmdbcUunSG3/Bs98NLHgzdwTmQ+0ku3QMU=; b=d2dBhvmOyhNCYWJy1yCB+iD2iR6C+KTgvDkHLF7JFaQ5nRPEhjGG9n7w2rU0VDiHU0yPpPLwafWz+mPiSkCzsvdDtlYmarbICMQFc55RH55MbfAIhFxoHw4vHu9G8+idYAYWtr/7kZCB/nhiv29VRw775MZnxGjCfscd95JHeZ9/ZfM2rK1SLn7X37awOlq0WaQdQk/G7kZomimL+Njzs5KRokGmjLpD+9ncFTAlwD7k3hNGhaMp1/wDtdExZIMuMQyhZ02lVbgFG6rymD48NClBMRV6YEW1/2jrvAbC1HwqbhXG95pJpbyBn03I9a4oBUk+MgcAosvmGZDrs/8jNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zLLg6gFadAmdbcUunSG3/Bs98NLHgzdwTmQ+0ku3QMU=; b=Ee4kDCHL/YBf9jJ9SQ+GkwGSyUkkZG9B8/b4wrI3wu+wZKX5noVjRDrX6egRVBkjSC7oMBsqQLo2JhKuLV/YQvybu1kuiQ+8aeUmdxlAn01NhhsgnHDt4m/A/yRMBSLPme+KErhP+pv1pac0dbdU4htmYQhZXgROAFtm9NIDsjqmHKsC+1lgr6EsHJr2rLtkPyYlKvK9BwwW+U6waiotWHGOEyKQh56GIPKtpAUgHqEPpyvUoeBoKr3caZNzk9GS1fYqUhVvlNQEQyrHHHSBgo0eASt1ZbDpgMvAnN+9kyW05dQDdzOHXELFYNiJFhog2d4F2+U9kQykK+xNmcFOHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> Date: Tue, 6 Sep 2022 11:52:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Setting constant-time mode CPU flag Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Simon Gaiser , Andrew Cooper , Xen developer discussion References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44e67ad2-ab7d-4d8e-31f3-08da8fed70c9 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3493:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6xYwqskpewSKFz5mzeBgzqxkUYK0b9U7yDUfwI4JIHz0l0DWMg2KYi0ZCb0sJ8pZchSz1HG0G5kH4oT2Hvf29aVkgfD99kYpz49VVNlIH56nGUO4rzqK21OBLijfsGHD/Ht+WGFIvdSdYBE7XJbmXjcVMf4dgA9c7i4s2jK0ZU5jCU+RowdomZ666SWKAjbyx4/Vu0k1ID91BEJSMgVew6M1pfGq81y+lai/8XqzH/gwiOxXAymrtEj43FIQKF5RJWr2wU9PEClrApXssWnHxe0EVJ1uMctAFje1Hr4MHsvB1RVpxdAqToLGIh4MHLGmSDS/ioB8FmpG1bd/Jgso9LcXq8eKhGVm8WWGhs46xD4pkzyQer69o4BflZ4/jIFPvbfERusGz0tI4UYdo7c73JRSesxdXBnLJtiNkoLb1okO/aTI187ZwOpTxjO/hIbT6r36wX3AFz8svza9DsX7XScVe5GLihvRdV6keXRZe8aqd/dqfG5aabvbJ2A3SgTJSVq+w86gKGyEoitKL0sm7zBjW6omX1REqDr/TanTgbfMAwig2kyJ/D6kqDE7EZ/Uxgp2Ur+wQmUZEE9x5FfdvasdSwcNhK1UwU++sDBjKArg24VSetm4sJOUthrZ2tq5P2m5hxuLPeuz37JX1YQ/7Vr/jf0G747wOv9AF+Ly4TU60H/yQX7Ym3aXT6qvvoCqq8yaVAtMr9V1lugtTJlcJUgIfYmpce5AoEgtFnRpsSebv/5KxhME1MKZIfhwgLhyMoJoHrdHCZS0tZuq7vsWGb+Z6lcjhVCBj7JodznEMuR5V1hHc0ICLYQ7BO+l2FU5Mlzp3oUIp9yrL72hOJbBUg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(346002)(39860400002)(396003)(366004)(31686004)(5660300002)(4326008)(66556008)(8676002)(2906002)(66476007)(66946007)(36756003)(41300700001)(478600001)(316002)(54906003)(53546011)(6486002)(966005)(6916009)(6506007)(6666004)(6512007)(26005)(186003)(86362001)(38100700002)(2616005)(31696002)(8936002)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTdYeWRGMk1jaFhHWXJwMHpRVWxOVGpjWUlVVU1rWlllKzBRa0xYaGJvQWlQ?= =?utf-8?B?eHRweVZPZnExVXI2dHh6Mkh2akNRRmtWdUU1N1lZUmdYU05Td1NPbjNPalUw?= =?utf-8?B?bk11MGhSbTcxNmJ2Nk9LQXdaY2JWb0h6UFJPZSszOXNVRjk5ZXZUQldCRXl6?= =?utf-8?B?bTEyMGVvQTBiU1prdWRtTy9vcFQwemIrVUs3WnA5VDIzMmhVZk9GQUpqNnZh?= =?utf-8?B?UlhvTUFjamJRdVhwQUFaK2p0MFpXMUZ5cGFpcjF0aUdTRVV6TFRBKysrbERP?= =?utf-8?B?ZHZpY3RPNWtpcnJqbE1FYjhNMmQzM09MZExzOURXTUp1R2hKYWMwMWN3Zmpi?= =?utf-8?B?RklIWmM4eC94WTNNYTdXM2JhSDdmQk9hbld2TUVQeG9seUNSK0N6M1Q4S0k1?= =?utf-8?B?aUhCL3RMNm9rVjg5TDVVL0VYbGtyVVQzZHk4WHluM0NtWUNJTHRhSmRYY2Ja?= =?utf-8?B?QWdKcnc0UmZSYWR0Z1BBMEF5eWNGNERUSW5XQ3ZPYVRDQVFXVFhBTmdpa3k1?= =?utf-8?B?T2pWMFlKMVVyMnBaZklaYkpxTmZiVm1mb3RsZXh6KzhKcEkwd3g0TnRPM3Nk?= =?utf-8?B?L3c2MHNCTEZRMHhwL2NuQkdrNThMWlRzZ3pOcjg0R1ZuYzNRUlBHbUxWQVg2?= =?utf-8?B?QlBPTndDd3cvRE9JNGE1MWhUSjVPcXFHVUJxYWV3KzVFMWx1VzNXa2hLRDds?= =?utf-8?B?ZjZqREpmRmp4STk1UXJaQWpkbGI0NjlZNlJ0UVM0c2ZSS3lnaUNraVF4OUsz?= =?utf-8?B?bVhNWGEyOFkvVzVPbWVRZ0tSVjdEUDNaQ0ZIc0V4N2lLRVQyTmtYMkNIV3NK?= =?utf-8?B?c3NjM3ZROGJjeGZjaDlqQ1lMQnBGM0R0djdEWU5rQytsQmtkTHYvSnBlQlIr?= =?utf-8?B?MTZaSDdITERRNzhoQWcxZnBiZW9TSGVQWXhnaWtoTVh1TDEraDFzandEdFpK?= =?utf-8?B?LzlSWkxNTUZ5VFJTdHp3VU84OCtJV0pLVC83VWszWEZ5bnFMRXh5VCtxNUxP?= =?utf-8?B?a0JqVmZDTXFQcXZjbVpHYWZ2RG0xWEtHemRMU2FmOXBtUHJ6TytxOXhRREdG?= =?utf-8?B?RGk2UEtDcm15YytoVWcrNEJTSHRydmcwL3JlTTZFMm5ia0Yrand6UFRIaGpC?= =?utf-8?B?Ym53RFljOVU5M0JaQ1hia0xDWFpIT1h3cld5OGdDbERUWFhiR3FKaGx1b2kw?= =?utf-8?B?dmt4OG95M2NxUGhQSWRUSjQxK0xaRFVYd00yaS9DUHhrTURFckFRVHFEUSty?= =?utf-8?B?Y3JDSlNhQWRUWjljdTd2STRjbDdPUlpra2pFVm9tOVVGUWlJUkM2d3d4bitX?= =?utf-8?B?NXJyT1NSd1NyOVAxbGkvMkVXVW9nSE1hN0tZYUI1WEJPaXNrQlZPWDVjRjda?= =?utf-8?B?TWxEcGFTVVE3RWNTVmlRc0lZUmJ4L215ZTQ1YS9NL2drd0NEWGFJRHQ0bFN1?= =?utf-8?B?OEhnb2FqZUJuUmg4RkI0RG0wUHVPQllHUUpNUEdOYnNDczhqblZ2UXViNUtx?= =?utf-8?B?SEVSaC8zMzU3SkJMK3NUUldDaE1scjdzWUNEQ1NZRG9GOEFMT2loL2FiRUNm?= =?utf-8?B?b1J1VXdwZktPSEFhZ0NYUTR2WGhEaVBKUzYwbitHR1o1Zmc2UHU5RS9wT2J3?= =?utf-8?B?TlpScnpiM3hPRC9ab2pzSE92bWJjd3JMMllwRmZqc1JFNmpmdTlJeDk4WnRT?= =?utf-8?B?RUVwNEV4RjYrNE12WGhhYXEvZ1pUU0JlYXVwNVhta0Y5V0ZDTURlbS9oTmQv?= =?utf-8?B?Nm1weWFtZ1doakpMbzZyWmJUZFlKaElvY3FFcE5WdWw2SmNDVkMxYmlOU0RG?= =?utf-8?B?ZjQwOE1oWFF5V2VOMG5UY1huQmp0dUlHeis5eitMYUxxVVJDNUZqeVdKbklv?= =?utf-8?B?RVR6VVVNdkpQT2dEcm05OEFDMkpIdVhpSU9vQTdJN0xyQ1RVZWg3YzA0UVRa?= =?utf-8?B?N1kyUmV4bzZmOWRqOXhiSmxvU0xKZmdhak04SjY5cEN5YU5pWUJxcXl1M0lO?= =?utf-8?B?VUdibE54dzZXaEQ2RmpseWRQblM0cGxKTkpUMG9oVzQ0QU5rU1F2emkrejcv?= =?utf-8?B?bHl3UE9nMHpLK08vL2E5THZqVXNLNDdLblRxT2l6TCtJZm5jL0xhS1JWQnNJ?= =?utf-8?Q?s8AT7R/vW9HYK1QYu5PewMTjw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44e67ad2-ab7d-4d8e-31f3-08da8fed70c9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:51:59.4225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V+kyb+jjnUQOcOc2ob+KS/gZtkgXXeJmaok9GvsOEKJfWPWq+p0sbQS4fpSo8/+pLbG9Emjo4bG2Vv0X/s0giA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3493 On 02.09.2022 04:05, Demi Marie Obenour wrote: > On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in > a CPU register to enforce constant-time execution. Linux plans to set > this bit by default; Xen should do the same. See > https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. > I recommend setting the bit unconditionally and ignoring guest attempts > to change it. I don't think we ought to set it by default; I can see reasons why kernels may want to set it by default (providing a way to turn it off). In Xen what I think we need is exposure of the bit to be guest-controllable. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:53:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:53:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399732.641007 (Exim 4.92) (envelope-from ) id 1oVVHK-0003m9-Au; Tue, 06 Sep 2022 09:53:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399732.641007; Tue, 06 Sep 2022 09:53:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVHK-0003m2-8C; Tue, 06 Sep 2022 09:53:58 +0000 Received: by outflank-mailman (input) for mailman id 399732; Tue, 06 Sep 2022 09:53:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVHJ-0003lw-63 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:53:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVHI-0008Pt-Ob; Tue, 06 Sep 2022 09:53:56 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVVHI-0003e9-EN; Tue, 06 Sep 2022 09:53:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fG7RIjXOPLfhyzD4onYNGManxHoHwmBVxGNiLmP5nLE=; b=rXb/zRrD3pp3iFvgqVDwWtGFPb /4KHpzLHSgrQY+s2v6IeN9qjaP5hece2ufdh/84wJSlBzfm8OGozXMIpRtmr4hYUJDKU4U2sNqWJz Xi/RBXGLNbECkTS7lBCeockNZX++Jff6mFRpj2HOT+tnBvVXg1O/h73nOOC9QG47ftLQ=; Message-ID: <6b230e0a-1075-1ce9-9ceb-9d3dd5410f9c@xen.org> Date: Tue, 6 Sep 2022 10:53:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 06/09/2022 10:39, Rahul Singh wrote: > Hi Julien, > >> On 3 Sep 2022, at 8:18 am, Julien Grall wrote: >> >> Hi Rahul, >> >> On 01/09/2022 10:29, Rahul Singh wrote: >>> is_memory_hole was implemented for x86 and not for ARM when introduced. >>> Replace is_memory_hole call to pci_check_bar as function should check >>> if device BAR is in defined memory range. Also, add an implementation >>> for ARM which is required for PCI passthrough. >>> On x86, pci_check_bar will call is_memory_hole which will check if BAR >>> is not overlapping with any memory region defined in the memory map. >>> On ARM, pci_check_bar will go through the host bridge ranges and check >>> if the BAR is in the range of defined ranges. >>> Signed-off-by: Rahul Singh >>> --- >>> Changes in v3: >>> - fix minor comments >>> --- >>> xen/arch/arm/include/asm/pci.h | 2 ++ >>> xen/arch/arm/pci/pci-host-common.c | 43 ++++++++++++++++++++++++++++++ >>> xen/arch/x86/include/asm/pci.h | 10 +++++++ >>> xen/drivers/passthrough/pci.c | 8 +++--- >>> 4 files changed, 59 insertions(+), 4 deletions(-) >>> diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h >>> index 80a2431804..8cb46f6b71 100644 >>> --- a/xen/arch/arm/include/asm/pci.h >>> +++ b/xen/arch/arm/include/asm/pci.h >>> @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, >>> int pci_host_bridge_mappings(struct domain *d); >>> +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); >>> + >>> #else /*!CONFIG_HAS_PCI*/ >>> struct arch_pci_dev { }; >>> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c >>> index 89ef30028e..0eb121666d 100644 >>> --- a/xen/arch/arm/pci/pci-host-common.c >>> +++ b/xen/arch/arm/pci/pci-host-common.c >>> @@ -24,6 +24,16 @@ >>> #include >>> +/* >>> + * struct to hold pci device bar. >>> + */ >> >> I find this comment a bit misleading. What you are storing is a >> candidate region. IOW, this may or may not be a PCI device bar. >> >> Given the current use below, I would rename the structure to something more specific like: pdev_bar_check. > > Ack. >> >>> +struct pdev_bar >>> +{ >>> + mfn_t start; >>> + mfn_t end; >>> + bool is_valid; >>> +}; >>> + >>> /* >>> * List for all the pci host bridges. >>> */ >>> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >>> return 0; >>> } >>> +static int is_bar_valid(const struct dt_device_node *dev, >>> + uint64_t addr, uint64_t len, void *data) >>> +{ >>> + struct pdev_bar *bar_data = data; >>> + unsigned long s = mfn_x(bar_data->start); >>> + unsigned long e = mfn_x(bar_data->end); >>> + >>> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >> >> AFAICT 's' and 'e' are provided by pci_check_bar() and will never change. So can we move the check 's <= e' outside of the callback? > > Yes, We can move the check outside the callback but I feel that if we check here then it is more > readable that we are checking for all possible values in one statement. Let me know your view on this. The readability is really a matter of taste here. But my point is more on the number of time a check is done. It seems pointless to do the same check N times when you know the values are not going to change. Admittedly, the operation is fast (this is a comparison) and N should be small (?). However, I think it raises the question on where do you draw the line? Personally, I think all invariant should be checked outside of callbacks. So the line is very clear. > >> >>> + bar_data->is_valid = true; >>> + >>> + return 0; >>> +} >>> + >>> +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) >>> +{ >> >> Other than the current calls in check_pdev(), do you have plan to use it in more places? The reason I am asking it is this function is non-trivial on Arm (dt_for_each_range() is quite complex). > > I don’t see any use of this function in more places. As this function will be called during dom0 boot when the PCI devices are > added I don’t see any performance issues. We may need to revisit this function when we add ACPI PCI passthrough support. > I will add TODO that we need to revisit this function for ACPI PCI passthrough support. Thanks. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:54:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399736.641018 (Exim 4.92) (envelope-from ) id 1oVVHj-0004Gd-Iu; Tue, 06 Sep 2022 09:54:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399736.641018; Tue, 06 Sep 2022 09:54:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVHj-0004GW-GE; Tue, 06 Sep 2022 09:54:23 +0000 Received: by outflank-mailman (input) for mailman id 399736; Tue, 06 Sep 2022 09:54:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVHi-0004GK-RX for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:54:22 +0000 Received: from mail145-24.atl61.mandrillapp.com (mail145-24.atl61.mandrillapp.com [198.2.145.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0e75fcc-2dc9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:54:21 +0200 (CEST) Received: from pmta06.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail145-24.atl61.mandrillapp.com (Mailchimp) with ESMTP id 4MMLMH5spqzGlspCP for ; Tue, 6 Sep 2022 09:54:19 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 4be0d71aa2844790b36dc51616f2ea80; Tue, 06 Sep 2022 09:54:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0e75fcc-2dc9-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1662458059; x=1662760459; i=andrei.semenov@vates.fr; bh=urDc9A+qx5y028VCP4ahYiB7xtOwiFvSVqTYVaRjrX4=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=Z6KD2qtT+Z2ahFmsa37xdWPqH5K8SLBGt41IjGSa7nWCjuQLjF0uErnqPdjQXQrP8 sarOjwIesHgBxOuHSlN3zw/IJoH2s+IyFQQYNRX4YtrTqrnLfyfgSazcvyke/l2yVV xoIkzpcPNLsGpKImPREdC6MFAkrq0U2B00e1yIQk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1662458059; h=From : Subject : To : Cc : Message-Id : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=urDc9A+qx5y028VCP4ahYiB7xtOwiFvSVqTYVaRjrX4=; b=mwCBXM+lr9uH7RZxQsa15zRbtIzvdbt1MOsxTZTOz9ekEr2Y4iM3PylJWh2IN3h3ehC0DR /E9MHIpXHN7hdHOJ/jWAgVaco1f81EoFDOGzt9j9DpRsOq3NXd7niVjDpk0xFmrZyIRumV7L gSe6IOcmZB4EHdd+xgHeY0I4KmkDA= From: Andrei Semenov Subject: [PATCH v2 0/2] live migration: optimisations X-Mailer: git-send-email 2.34.1 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 5cd6f291-6f11-459d-97c0-d09b574c3896 X-Bm-Transport-Timestamp: 1662458058793 To: andrei.semenov@vates.fr, xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Juergen Gross Message-Id: X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.4be0d71aa2844790b36dc51616f2ea80 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20220906:md Date: Tue, 06 Sep 2022 09:54:19 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit This 2 patches implement some optimisations for guests live migraiton. Andrei Semenov (2): live migration: do not use deffered bitmap when inappropriate live migration: use superpages for physmap population on restore when possible tools/include/xen-tools/libs.h | 4 ++ tools/libs/guest/xg_private.h | 3 + tools/libs/guest/xg_sr_common.h | 44 +++++++++++- tools/libs/guest/xg_sr_restore.c | 60 +++++++--------- tools/libs/guest/xg_sr_restore_x86_hvm.c | 88 +++++++++++++++++++++++- tools/libs/guest/xg_sr_restore_x86_pv.c | 22 +++++- tools/libs/guest/xg_sr_save.c | 23 +++---- tools/libs/guest/xg_sr_save_x86_hvm.c | 21 ++++++ tools/libs/guest/xg_sr_save_x86_pv.c | 39 +++++++++++ 9 files changed, 247 insertions(+), 57 deletions(-) -- 2.34.1 Andrei Semenov | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com From xen-devel-bounces@lists.xenproject.org Tue Sep 06 09:57:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 09:57:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399742.641030 (Exim 4.92) (envelope-from ) id 1oVVKy-0004xQ-4W; Tue, 06 Sep 2022 09:57:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399742.641030; Tue, 06 Sep 2022 09:57:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVKy-0004xJ-02; Tue, 06 Sep 2022 09:57:44 +0000 Received: by outflank-mailman (input) for mailman id 399742; Tue, 06 Sep 2022 09:57:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVKx-0004xD-7D for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 09:57:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 58af8677-2dca-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 11:57:41 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C7BED6E; Tue, 6 Sep 2022 02:57:47 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3169B3F534; Tue, 6 Sep 2022 02:57:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58af8677-2dca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Date: Tue, 6 Sep 2022 10:55:47 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series merge the applicable Linux fixes to Xen. Bixuan Cui (1): xen/arm: smmuv3: Change *array into *const array Christophe JAILLET (1): xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Gustavo A. R. Silva (1): xen/arm: smmuv3: Fix fall-through warning for Clang Jean-Philippe Brucker (2): xen/arm: smmuv3: Fix endianness annotations xen/arm: smmuv3: Move definitions to a header Robin Murphy (1): xen/arm: smmuv3: Remove the page 1 fixup Zenghui Yu (2): xen/arm: smmuv3: Fix l1 stream table size in the error message xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Zhen Lei (1): xen/arm: smmuv3: Remove unnecessary oom message Zhou Wang (1): xen/arm: smmuv3: Ensure queue is read after updating prod pointer xen/drivers/passthrough/arm/smmu-v3.c | 741 ++------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ 2 files changed, 708 insertions(+), 705 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 10:01:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 10:01:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399749.641040 (Exim 4.92) (envelope-from ) id 1oVVON-0006Tz-Hy; Tue, 06 Sep 2022 10:01:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399749.641040; Tue, 06 Sep 2022 10:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVON-0006Ts-F5; Tue, 06 Sep 2022 10:01:15 +0000 Received: by outflank-mailman (input) for mailman id 399749; Tue, 06 Sep 2022 10:01:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVOL-0006Tk-Ki for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 10:01:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d642f1e0-2dca-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 12:01:12 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CABB7176C; Tue, 6 Sep 2022 03:01:17 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C5BD3F534; Tue, 6 Sep 2022 03:01:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d642f1e0-2dca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Robin Murphy , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v4 05/10] xen/arm: smmuv3: Remove the page 1 fixup Date: Tue, 6 Sep 2022 10:55:52 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Robin Murphy Backport Linux commit 86d2d9214880. This is the clean backport without any changes. Since we now keep track of page 1 via a separate pointer that already encapsulates aliasing to page 0 as necessary, we can remove the clunky fixup routine and simply use the relevant bases directly. The current architecture spec (IHI0070D.a) defines SMMU_{EVENTQ,PRIQ}_{PROD,CONS} as offsets relative to page 1, so the cleanup represents a little bit of convergence as well as just lines of code saved. Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 86d2d9214880 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Added Stefano Acked-by Changes in v3: - fix "q->cons_reg = page + cons_off" Changes in v2: - fix commit msg. --- xen/drivers/passthrough/arm/smmu-v3.c | 42 ++++++++++----------------- xen/drivers/passthrough/arm/smmu-v3.h | 8 ++--- 2 files changed, 20 insertions(+), 30 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index ba24a26ad6..15bb4d7e19 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -238,15 +238,6 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { { 0, NULL}, }; -static inline void __iomem *arm_smmu_page1_fixup(unsigned long offset, - struct arm_smmu_device *smmu) -{ - if (offset > SZ_64K) - return smmu->page1 + offset - SZ_64K; - - return smmu->base + offset; -} - static struct arm_smmu_domain *to_smmu_domain(struct iommu_domain *dom) { return container_of(dom, struct arm_smmu_domain, domain); @@ -1581,6 +1572,7 @@ static int arm_smmu_dt_xlate(struct device *dev, /* Probing and initialisation functions */ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, struct arm_smmu_queue *q, + void __iomem *page, unsigned long prod_off, unsigned long cons_off, size_t dwords, const char *name) @@ -1609,8 +1601,8 @@ static int arm_smmu_init_one_queue(struct arm_smmu_device *smmu, 1 << q->llq.max_n_shift, name); } - q->prod_reg = arm_smmu_page1_fixup(prod_off, smmu); - q->cons_reg = arm_smmu_page1_fixup(cons_off, smmu); + q->prod_reg = page + prod_off; + q->cons_reg = page + cons_off; q->ent_dwords = dwords; q->q_base = Q_BASE_RWA; @@ -1627,16 +1619,16 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) /* cmdq */ spin_lock_init(&smmu->cmdq.lock); - ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, ARM_SMMU_CMDQ_PROD, - ARM_SMMU_CMDQ_CONS, CMDQ_ENT_DWORDS, - "cmdq"); + ret = arm_smmu_init_one_queue(smmu, &smmu->cmdq.q, smmu->base, + ARM_SMMU_CMDQ_PROD, ARM_SMMU_CMDQ_CONS, + CMDQ_ENT_DWORDS, "cmdq"); if (ret) return ret; /* evtq */ - ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, ARM_SMMU_EVTQ_PROD, - ARM_SMMU_EVTQ_CONS, EVTQ_ENT_DWORDS, - "evtq"); + ret = arm_smmu_init_one_queue(smmu, &smmu->evtq.q, smmu->page1, + ARM_SMMU_EVTQ_PROD, ARM_SMMU_EVTQ_CONS, + EVTQ_ENT_DWORDS, "evtq"); if (ret) return ret; @@ -1644,9 +1636,9 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) if (!(smmu->features & ARM_SMMU_FEAT_PRI)) return 0; - return arm_smmu_init_one_queue(smmu, &smmu->priq.q, ARM_SMMU_PRIQ_PROD, - ARM_SMMU_PRIQ_CONS, PRIQ_ENT_DWORDS, - "priq"); + return arm_smmu_init_one_queue(smmu, &smmu->priq.q, smmu->page1, + ARM_SMMU_PRIQ_PROD, ARM_SMMU_PRIQ_CONS, + PRIQ_ENT_DWORDS, "priq"); } static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) @@ -2090,10 +2082,8 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) /* Event queue */ writeq_relaxed(smmu->evtq.q.q_base, smmu->base + ARM_SMMU_EVTQ_BASE); - writel_relaxed(smmu->evtq.q.llq.prod, - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_PROD, smmu)); - writel_relaxed(smmu->evtq.q.llq.cons, - arm_smmu_page1_fixup(ARM_SMMU_EVTQ_CONS, smmu)); + writel_relaxed(smmu->evtq.q.llq.prod, smmu->page1 + ARM_SMMU_EVTQ_PROD); + writel_relaxed(smmu->evtq.q.llq.cons, smmu->page1 + ARM_SMMU_EVTQ_CONS); enables |= CR0_EVTQEN; ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, @@ -2108,9 +2098,9 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) writeq_relaxed(smmu->priq.q.q_base, smmu->base + ARM_SMMU_PRIQ_BASE); writel_relaxed(smmu->priq.q.llq.prod, - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_PROD, smmu)); + smmu->page1 + ARM_SMMU_PRIQ_PROD); writel_relaxed(smmu->priq.q.llq.cons, - arm_smmu_page1_fixup(ARM_SMMU_PRIQ_CONS, smmu)); + smmu->page1 + ARM_SMMU_PRIQ_CONS); enables |= CR0_PRIQEN; ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0, diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h index c45d2f16c4..0742bc393f 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.h +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -130,15 +130,15 @@ #define ARM_SMMU_CMDQ_CONS 0x9c #define ARM_SMMU_EVTQ_BASE 0xa0 -#define ARM_SMMU_EVTQ_PROD 0x100a8 -#define ARM_SMMU_EVTQ_CONS 0x100ac +#define ARM_SMMU_EVTQ_PROD 0xa8 +#define ARM_SMMU_EVTQ_CONS 0xac #define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 #define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 #define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc #define ARM_SMMU_PRIQ_BASE 0xc0 -#define ARM_SMMU_PRIQ_PROD 0x100c8 -#define ARM_SMMU_PRIQ_CONS 0x100cc +#define ARM_SMMU_PRIQ_PROD 0xc8 +#define ARM_SMMU_PRIQ_CONS 0xcc #define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 #define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 #define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 10:01:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 10:01:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399750.641052 (Exim 4.92) (envelope-from ) id 1oVVOQ-0006lW-Pe; Tue, 06 Sep 2022 10:01:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399750.641052; Tue, 06 Sep 2022 10:01:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVOQ-0006lN-MW; Tue, 06 Sep 2022 10:01:18 +0000 Received: by outflank-mailman (input) for mailman id 399750; Tue, 06 Sep 2022 10:01:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVOP-0006Tk-8u for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 10:01:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d8d31f61-2dca-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 12:01:16 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 468FE176C; Tue, 6 Sep 2022 03:01:22 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07B2D3F534; Tue, 6 Sep 2022 03:01:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8d31f61-2dca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zenghui Yu , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v4 06/10] xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Date: Tue, 6 Sep 2022 10:55:53 +0100 Message-Id: <2730ab6b0fbfd14b1b3e5b30bb2bbb248ed2828e.1662455798.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zenghui Yu Backport Linux commit e0bb4b735404. This is the clean backport without any changes. Per SMMUv3 spec, there is no Size and Addr field in the PREFETCH_CONFIG command and they're not used by the driver. Remove them. We can add them back if we're going to use PREFETCH_ADDR in the future. Signed-off-by: Zenghui Yu Link: https://lore.kernel.org/r/20210407084448.1838-1-yuzenghui@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e0bb4b735404 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 -- xen/drivers/passthrough/arm/smmu-v3.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 15bb4d7e19..28fcb01757 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -405,8 +405,6 @@ static int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) break; case CMDQ_OP_PREFETCH_CFG: cmd[0] |= FIELD_PREP(CMDQ_PREFETCH_0_SID, ent->prefetch.sid); - cmd[1] |= FIELD_PREP(CMDQ_PREFETCH_1_SIZE, ent->prefetch.size); - cmd[1] |= ent->prefetch.addr & CMDQ_PREFETCH_1_ADDR_MASK; break; case CMDQ_OP_CFGI_STE: cmd[0] |= FIELD_PREP(CMDQ_CFGI_0_SID, ent->cfgi.sid); diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h index 0742bc393f..b381ad3738 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.h +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -456,8 +456,6 @@ struct arm_smmu_cmdq_ent { #define CMDQ_OP_PREFETCH_CFG 0x1 struct { u32 sid; - u8 size; - u64 addr; } prefetch; #define CMDQ_OP_CFGI_STE 0x3 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 10:01:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 10:01:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399751.641062 (Exim 4.92) (envelope-from ) id 1oVVOT-000741-1W; Tue, 06 Sep 2022 10:01:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399751.641062; Tue, 06 Sep 2022 10:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVOS-00073u-UX; Tue, 06 Sep 2022 10:01:20 +0000 Received: by outflank-mailman (input) for mailman id 399751; Tue, 06 Sep 2022 10:01:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVOR-0006Tk-My for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 10:01:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id da4c68ef-2dca-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 12:01:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93B66D6E; Tue, 6 Sep 2022 03:01:24 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 551413F534; Tue, 6 Sep 2022 03:01:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da4c68ef-2dca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Bixuan Cui , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v4 07/10] xen/arm: smmuv3: Change *array into *const array Date: Tue, 6 Sep 2022 10:55:54 +0100 Message-Id: <2693ef69907c51c351c1ab7f25ba1f4df4625b71.1662455798.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bixuan Cui Backport Linux commit d56d5162e317. This is the clean backport without any changes. Fix checkpatch warning in arm-smmu-v3.c: static const char * array should probably be static const char * const Signed-off-by: Bixuan Cui Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d56d5162e317 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 28fcb01757..c53d4c96a4 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -470,7 +470,7 @@ static int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) { - static const char *cerror_str[] = { + static const char * const cerror_str[] = { [CMDQ_ERR_CERROR_NONE_IDX] = "No error", [CMDQ_ERR_CERROR_ILL_IDX] = "Illegal command", [CMDQ_ERR_CERROR_ABT_IDX] = "Abort on command fetch", -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 10:06:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 10:06:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399770.641074 (Exim 4.92) (envelope-from ) id 1oVVSs-0008LZ-NO; Tue, 06 Sep 2022 10:05:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399770.641074; Tue, 06 Sep 2022 10:05:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVSs-0008LS-KA; Tue, 06 Sep 2022 10:05:54 +0000 Received: by outflank-mailman (input) for mailman id 399770; Tue, 06 Sep 2022 10:05:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVVSr-0008LM-BL for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 10:05:53 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d072883-2dcb-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 12:05:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5759.eurprd04.prod.outlook.com (2603:10a6:803:de::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 10:05:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 10:05:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d072883-2dcb-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcq+gXC8Cx560Qdwe5ViRlg6MF+1D9Ip7uRY+MFp8aj2Lmh4Wd4Clb3lHM0IVVx7nXT6sVK8TXNuB0puJ5Hyb8uAN1sIhNTn4P1oCYova7oWGWvUewYmRxsODQkkAyd2EJwF2ma72zE82055WT8HVXTrT/xUrOWNxOVRE9QwP1Cec9OlqltQ7rp/YBKB4lm/TSunVHyCapR1qMKUGn0EzMgHjVAC/ZJp7C0CLcLRa8AxhBBbWENJ7QlJe9zN3cR8ZvefgNamIV29dreHNuxaiBg/kpoyEpnq4i0yz1lKDlL+RP3GfEYEhRwRet9J/3bZamyrUVAyGjqCWD3BB+H6fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FLQF+2g4GDwLXRDnzsN1h5zIwD75Zx/nle5iRa5mjuI=; b=A8seNi3hLhhAji0lMUAcrGkCWHAWiDNlT1ecms5b8tvWlJXxkIcmchoA0EDopkPlN4ubq98oRtc/BFH8hdNlfhq1Cfsl/iLO46pFiea/ztEr1cVjYWwcRRD4a/+agCFOHaeA560jkpFdziBpPcwrVMkszbEZ/d0QP2e+JsA3m0x483noHC2VwzJ8P/GzcfRkcrVmv4zKivSppS+vvj5KbsZhAUKcP4jw5GZEDDJj8xer5nUThfB7irqtyajZ7cmPKwYKF/GLKJnLdfy13+ERq999z/+1okXqPQQkuU8ksGgSQR207J0xLqDNzRwSDI55U6lLKAox1k33NdNAOUOJSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLQF+2g4GDwLXRDnzsN1h5zIwD75Zx/nle5iRa5mjuI=; b=T+rCW1o5Ok6ZzNj6KpQlni9uTYLujndkyDf7TSU0swAHOnH+bgln4g6E3GaRsAhj6EQjtTiuITD6m6/KAYiJucIA3Cl3NUsXFVW5AERQ/2P87ohaf+hNb7Iz5ctboc9QFu0qk5L1+Sigd3X3w0W6Y21K3RabPg+mjI6RybCKv3eGQSOTjI1op9rn3eXZOs1NTSp4qRA8IGcUmhE1vDj2+0+tkIHF4MJI+H+FPKYfnZQkcgPf8rzAaxlDcpY/t99h9duWlxQLwuMQ69mbQk00RqiFkDrFM1vvYbGiDtcNc3WJOuPeQM5cwOnSmG1ibnIEy688R+rpp44lrrBU+TwPsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 12:05:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Xen 4.17 release: Current status before the feature freeze Content-Language: en-US To: Anthony PERARD , Henry Wang Cc: "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e6e5c94-c503-4a43-7851-08da8fef5eae X-MS-TrafficTypeDiagnostic: VI1PR04MB5759:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +cXigB/59Mx4CUp9elDTLIXK6nsf9xi4np9O+KC/GSaxSGIfItuPkWxLGPBXPvNUHVJojtTnnNao5ReS6tnzn3/SyoSYiTK9Xi+MXjjv3tnurepH+xgznxkNKL1JOgZkYms1g1ZrTEL2B2HKnN1EGpT31FWBik0ts9ZSODfNWOfz9TCkEWtjbZxTxiuS25gnGE8ABbOAvQuxHzk+Q5MqayTvoja0+YxEQMW49xWRHTmesjMzsG7Eju+0AmDuNb6dscZEfXNvuBoNXyXj9Hxb9CpNt39XfNcUvVLKcPnJd4m8xmpnQSxl4KGo+YBRqHwja+RIBXc5SHQHhFiu1ATHSOv6XYGjz9HbzkVAxpIqFa8MeBdrMu0qw60UL7jIhXjlfGEQ+yMry+7WeLDWzzTttLOknh8q9ctJY+0Y8xMXej5SNUgKRju11L5T5fiHCw7NamyWWzr7f7qcJSALsgM0N6XDd9+8ArsAJycRnAl/J4pMkPSRmWovpb+tabxn5nQQWIaHqI9g7p2Rqd0XweZs5DkfrSfMoNb0dm7h9NoLBrb93wLCJOxJdpN20hQQTim6ALgSgcsaK1qMk61z9L4NlgU2YoIZNKGo8YEMvwTcAkgy6rhh7AznTcQIecf6R4vNQHK3YVgoAYtxgl3u9YomYfD+oRlwemxfeni+tkWrKRULGoijitmMXHdFfRIS0SIGvK+NGPaPNH8BpUtLsl/fEUFvMox3YBcr0leZqnnRQzV53g7Q+cL+TVRH8NfgVMDEwJSiypXb7KZG+C8jAj5KSRxAZVsKFNkgDq50M43sAG/CKfWUDoLfWwE4QiLJvFRBxZ8LnZdMoTce8iW04ULzgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(396003)(39860400002)(346002)(376002)(8936002)(316002)(110136005)(186003)(4744005)(5660300002)(4326008)(2906002)(8676002)(66946007)(36756003)(66476007)(66556008)(31686004)(2616005)(6506007)(478600001)(41300700001)(6666004)(86362001)(53546011)(26005)(6512007)(31696002)(6486002)(966005)(83380400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDVreVdqQzVMcEV3N0c5bjBRc0NmbzE0elZ6MFNoQ2Z3UzFRZTYyK1l0QTdm?= =?utf-8?B?dHdhMThxK1cyUU5UTm9OR3hlRlE5TC9RalVSVmdNSFVPaXNXc2JqV1NQeU1H?= =?utf-8?B?UG44NWQ0STVlR0ZYZVFMTjlSeDZTZHFmMENhNGlXWDRWckRoVzlpMzhSMmlP?= =?utf-8?B?YnFvN1R3L2N1K2ZJM0hnT2VPSU93WC9ZZ1g2WWMwNDhFaVYrQnRwYkswNmZr?= =?utf-8?B?Ukxwdkx1Q0tsM1lNOFZXQXVqSzlCd084QTQwZjJSUUxTZG9FUkc5NTFXSU9q?= =?utf-8?B?RkQvUTFmM1AwRU1aQ0lQKzNaK1ZZL0EyZTkwNXhzZmlqVVdFVE1JVWJvN29k?= =?utf-8?B?QWdMTENxanIyMWRCY0xQZTlJdHk5SzVZbkpLNUJhckx6bEt5SHUwTHVueWZC?= =?utf-8?B?aU9GOTVOYlM0T3pHRkVJSFB5L3FOY2dXTE45OHZYQmlUMHV3TmtOQkJZd2hM?= =?utf-8?B?ekppV0lZMlZjZXQyVEsxK3p1Yy9ZbVhpOEZkdWtxWTAxVytKZ00rRjhBWmFr?= =?utf-8?B?RFlFYlVvekdEWlZocERsdk5yOWN3TDZjdGpobGpveEJWQVFaRXhBdkJqMURZ?= =?utf-8?B?RFNEREplTm1wUzZCTERDU044OHVxcUpUUlhqNW1rQ0o0eDdhOHIyK21rdHoy?= =?utf-8?B?TDhGSVR6VmJPZWhpdEx2Z200V0tJLzJFeEhOcEZ3ellvTHdHTU5aR0hneklE?= =?utf-8?B?eUxZVnlJQkJtVDBQeWRyODJqN29sZ3Bzb2taOU9IVGNFQ2I4RGErRlpMNk1W?= =?utf-8?B?ZUpFOHVSbUgzMDVWcG5SS2hXMDNIc29TVGQzaCtMbVZPSDVCRHRLWFlVdEw1?= =?utf-8?B?Y2tBbGZYRUUxZDVySjhhUGhyOEE3SjAxdm5wdk1TU3NQSEV6b1R4bS94UDdh?= =?utf-8?B?OWVHbmpPb0hTSHJqd0FuOWVUTkp0SGdZM29vWmZBYVk1MWpWOWQ0ZHJjb2Rr?= =?utf-8?B?ekpGaW40SFBYaXhsbG4yeWk2UlRFV3ZWTGk2cjNqcm5Ld2lHTWJrSGZHYkdX?= =?utf-8?B?Y3J0dmkzVkJ0Mmw3ZmNxb2tCTElTbUh2OXVOZTRzRHNqbzFncE9adloySTFC?= =?utf-8?B?WjBBSHF1WkhvM1g0eUI1OVVPVlpkK2w2YTJtQlhWSDJ2TDd3ZVUvOW1GWmJX?= =?utf-8?B?Z0J1VnNsRk1oM1MzQzZuQXRCWTVOR05tSXhLQ21vOTArOWdZb1lmcnlmMmFk?= =?utf-8?B?bmswcEgzUnVoNUxQVFc2RlV4TGJ2L0RRUUhMTGRLZWlOT2JxK1JXeUQ1UzJo?= =?utf-8?B?aTZ4a2ZOOXR6bUtZTzdCRWRmZG1vbWhNY0xUMmtnZjhQL0JtL3lYcWs4NGpp?= =?utf-8?B?MFJ3NElHY2F2bSswbG9HWmdNa0tkTkxzMTJWMUtScHFoOWZReGpYQnNEdGZu?= =?utf-8?B?b0dhY2VheHFDMWtCSmRvVTBocmVQS0VpSHU3RzdiRXZlUTgxSzA0Q2xNWUQw?= =?utf-8?B?WDFGY2hHMFdSNTJ6S083ZTlONnFndDBzbnIrRklDc2NGNTl3YUUrUGtPb3lh?= =?utf-8?B?ZVplSU1QSEtNREE1ZkRkRlp5bkQ0U2ZoZDZDc21RTWliczJZa3p1VzdWZHJ3?= =?utf-8?B?UFpaNkJVcjhWV2hOSngyNXBNYnFWZlhuYUluZlA4NUxpNzkyM1oyVW1TOU03?= =?utf-8?B?bU1pOU5sTUNwWFN0TlNqMm5yYkpOSTk1bW1GMFRNWjRiWXRucFVmQmgrQXho?= =?utf-8?B?UElLZVhiTE9uVXBEc3RoNkdtTkxjd3BoQ2NaYjFWelk5SkdrY0lxV3NCRmRu?= =?utf-8?B?d3Q3VU5FV2E2c004dGkzL09YbVZXWTY0dkFXUXJEck5COFRLNjR0VmJRMm5L?= =?utf-8?B?SWlSOTZvZndRQ2JDYlFUdTF3TEZucUFTSDZSaHczZDlwL0lDUXYrL3BubzBq?= =?utf-8?B?bk5NWlpIWmE1dFVjMlFYbzNkaEE4U0lpN2hzSlJ5QzdxZHRrYTVrc3d4eXhw?= =?utf-8?B?ZktiVXZtd2cxNC9qdWFJV1ROOHlRK2Q5amM0QWw0ellIMEV2V0dwNnk0bzQr?= =?utf-8?B?ZnNoNzg5UzU4eUFPNnF6a28wKzg4WGlRM3lac012WklZVnJlNFlnSEMzRzN3?= =?utf-8?B?N2h2OHdIckloN2I5MS9FYTVrY1JUbFRIb0dlK1NyTGo1T1czSXFqelIzQk1u?= =?utf-8?Q?jPkKxXUd5EHJNtHPghJ+JxYfg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e6e5c94-c503-4a43-7851-08da8fef5eae X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:05:47.6513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eY9kuONBRmkk2IESncSIsiEzoti4WwWqxjEm/uJrvaq7fJnbo0UtNGcKt0YWxHrMo3Geg5VIaJx+yZQzDL+D1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5759 (shortening Cc list) On 05.09.2022 16:59, Anthony PERARD wrote: > On Mon, Sep 05, 2022 at 03:44:33AM +0000, Henry Wang wrote: >> ** Common **: >> 10. [XEN,v2] build: Fix x86 out-of-tree build without EFI >> https://patchwork.kernel.org/project/xen-devel/list/?series=668331 >> Status: Reviewed but not merged. > > I believe this should be a blocker. And the status might be that I need > to update the patch. Right - afaic at least the description wants to be changed. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 10:43:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 10:43:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399780.641085 (Exim 4.92) (envelope-from ) id 1oVW2a-0004FL-GQ; Tue, 06 Sep 2022 10:42:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399780.641085; Tue, 06 Sep 2022 10:42:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVW2a-0004FE-De; Tue, 06 Sep 2022 10:42:48 +0000 Received: by outflank-mailman (input) for mailman id 399780; Tue, 06 Sep 2022 10:42:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVW2Z-0004F8-0h for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 10:42:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a42107b4-2dd0-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 12:42:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8374.eurprd04.prod.outlook.com (2603:10a6:102:1bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 10:42:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 10:42:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a42107b4-2dd0-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhNRA74FaOLlWZfpQJQLzaxUFK/6XmNdEGoZrFliBn6zfx1M7LMv04JvIy1GmaDjGhfSQ7Ce6VsTOcB37vDDs7YFngwACK/XNxaGt7wMm6ca0AP1uQ2AHRMUykXbKuWNuhqFAyxM/gXL7X1EQTceQayNRMh0D1Pj+Pr/5lLQtvj/kgiSlZux3rEnY3dHfpazXf70vQmTJEGR6yaerWO1oZEUJf3EyJRdCZhAhQJZmcIMyx4gb14CY9/Gbd+m8tnPvoRwxQ//lKyb4AkpVAo0wC9cXgoap72xDvKTUe+ZxYJLHNxanR4IGIV/0Bp5oNhkU9rQNNX2JIVJYaKoI/MfpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q3rZ+1mwFYsgypB89oHiViLaS3/xNfX43sEXZ6JhB68=; b=ElSpMMsHKERDq3mafud7Yqlj+D7EBQvPMcB0DnNW9ItJMlxCOpld+OJQ01lvGiPVZq9ok7hdJOdW8GL21S6zMs5kjhOOpq5q2h3c6VaOeBYnn1LquzTabLB5QPQG4twf6ah0T6MdBS5kQfI7YeyxLU5FCPMK2z8t7I3WKXBYMKM72uCGIYgOSmMeDRwKqw0uQssjm3c+1Weii0xnCPSM+HUzSGbukYuO0HRWbdJIU2FjmjpvwSXFJyflT6eGZnQfHjZOB1vbr9Gnnj2flxE3oVxlNIyWEWTJcLY7tgb4Fudkl26yKdqMr10MLHZL0Eha8iVYmsfh9ASX/hshITPRdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3rZ+1mwFYsgypB89oHiViLaS3/xNfX43sEXZ6JhB68=; b=Z9x5eTZXoeApRPCQL3kd8fKIIKvmuUts1SIngV0OwPdQ9iavFPtDwY/sgTdwYgr0lLbmvq8wVH1jqPPXanJJf/6D74SH6xNzZD0G+sT92MU7QSYXns2RTCEOACy4Nf3je/YXSASJLpe6S91D4Ifz9uY85BJRcI3hIwOEjiHFWZ//XBbvO/K4j3rGHG/L99W4B41G992pt45tx3gS5Gfk5tn1NRlIUT48IUHARXXzGvyr2Y3CifDR0YSoow9C6Qh3iXgQ+G4utmv2SyvXtCW7VLDFefDAlvvyaPf+aa1DIJ71YOKM+9TcPKgkIHfsuixyflLc3AM3bLvFTgF9aY/YNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 12:42:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v12 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220906073919.941934-1-Penny.Zheng@arm.com> <20220906073919.941934-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220906073919.941934-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c677957-7b3d-4fd9-0510-08da8ff4876b X-MS-TrafficTypeDiagnostic: PAXPR04MB8374:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J6q/nCHymDOHPSP/7UYZEOn0WBqWkQKsUH9xxXCNF9EF7+BcgNSy9KPKz1VRgWwHd66DUvC38fBqY1nwmnPF8NU3BUML55REcityKiprLeKhKnUo9vOPl6LEYjvDK0fi2A7uOBYopxCDlMG2T9PrMo4VVzt03ddW+2uXeJyVYccmd4KxKp1zSK4g/GyFerCkxnd9Gi4rERcAPbDEXRBRsVg+/VimxRuY+uKBcgVJIdmy3P2neNQUGGEooD+jeahGKkjZdLmNcOv+hcN5GQ+jpEmqBD6md6Fp6R95Hh82ScgOA9+iNkJRvNCgWraIFHeJSnA60ywk/5LI80Q5fdrtizbOMh9vNpFKt/HC6H2yLGrirIdqC6q45stIhONN+XeJqVjSwuK/L1K7mPZknofTu/W61mquKvfhqX8ddMogWbxZ9wQoTkqCiFU1bV3NoFUZy79FgxVg3ji+eWXTxjh1rWfuyQYQd5uaSrP6PVlh1o+A+ZtCMoo8aE0UdyNUTiZvwh+LWawCM4tdB30r4L6poz7ydI+ZWHBqpMyYqIxkJHDx3Mm5wF1Ni2H/2Rjc2CzVHbnboV7/CQeoz6EAkCQlGHICXz68KOPW+KLEqKKyp5BIaNZkEt3Fpza8PxVCJio2ICnybsEc0MneJd1vTKGOR6gQ7K91TVrI8ha8h1/ebty/Ygtl4BWyD0ctIjyf8DjywXX8GPcVrj1cbS3SzdXl9k7dCoyQ7wrCHseJcs7R2KC2jehMJ1dsGaOngGBF3faZTqgDRA55TzmZt5UvCUvnRLKcb7nVWicQbaK9bloiSb8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(346002)(136003)(366004)(396003)(6512007)(36756003)(5660300002)(8936002)(41300700001)(6486002)(26005)(2906002)(38100700002)(478600001)(66556008)(66476007)(66946007)(86362001)(8676002)(4326008)(53546011)(31696002)(6506007)(31686004)(186003)(6916009)(54906003)(316002)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlNSTGttZEdLMCtFbVpoQ1F0c1BYbjBIMHNNbElMaG9sNHpHSGQ1K1dRMTF1?= =?utf-8?B?SDB6QTZiNEF4ekttYlM0bE5HUzZUZmllb2VmbzM2SEdONHloSEZiMHBNSFVN?= =?utf-8?B?MTNZbHc0N3lGY25Vdmkzbzc2SER5YlFtQnQ2b2w0ei9CRDZKV3h3a2x0Szk3?= =?utf-8?B?TFJzWFlBc3JTYVBIaEU4QklzYTMyMjYxQnpQRldUWEVIUHNUTzN1Vk9UOG0y?= =?utf-8?B?S29kN2tZN3VtQzZyMXZHeXM3WDhXbnFSOXBrNnZyRXNKdkxlUC9Sd3llZDdD?= =?utf-8?B?QUdLUWhiVXo0UXU1Y1A0Z0ovVGNHMkw4c0NjcThGOW5IVzFoY1hjbUg5NjNG?= =?utf-8?B?YnB1MCtKMEJNVVUxSnRMRTlENnI2YUhCT2syMk1SRHlvZThPVEs0TkRRcG4v?= =?utf-8?B?NGlvMXpnZ1V3SUpKc1F2VEp4SUtManVDTk5adi9UR3dwcHByeEhOaVYzV2ll?= =?utf-8?B?bUwxa0Z1MmR6Yjg3ODcybnRzQ3VVLzJ1WnJ1K1ZGZzUvaUNOYWZ6M05aNlVN?= =?utf-8?B?SXg4UzkwQWYxdHB2ckZIa0cxUjJuWWMwQXZtT3JSS2Q5Y3M5R0t3ZGJoREho?= =?utf-8?B?b2U3eWh0V3hXNGVaY09SZTFqUUxacTVtbmY1QjNKWUhURGFOcnY2ZEZ3b0dY?= =?utf-8?B?RDRZcC9Fc3JmOUNIc3B5RnAxaXUzc01oOVN3dEl6aW56amZXU3Zpa0JmbE5s?= =?utf-8?B?a1VOVzU4SlZrZ1c0L2wrMTU1bFJHOHdQOTNKVGZsMldBRDdxakNuQkh3em84?= =?utf-8?B?Y3daL1NNZlllNlFKbThvQXlHcUVtTEhYYTlNS0VpVklncUJBVmwxZWpTb1Bi?= =?utf-8?B?SEJzMjRFalRybHFpUHI1ZU5jSkdYOGZMaTdqNDZBT21KWGpYcVBCdEg1Tlg2?= =?utf-8?B?R0dmY0k5ZTJRSU15ZzhEcnJ2WEtidHBRaGJXNmpucHU1OUhxNEpkTHo0T2lZ?= =?utf-8?B?U1FqOHYxK09MamZVWGFXRFVCWjA2Qi9qODVJUTJtTFpkbnhLdVlMdVFpdFU3?= =?utf-8?B?SkhPT3JwUWNSNDBwOGdsZHpjRWsxOVg1VndxV2NTcUhVTlBqalBIdzcxS25M?= =?utf-8?B?MG5lcnJWcHZFM0RGNjVhUTE0N1Zod0IvVGEwM0VPV21uUVRqR3RqLzdyRlhL?= =?utf-8?B?WW5OYks2d01WK2hwRWpsdXFCTVY5QWlqeVhOMUJITXhPSnNYNEMzUW5uTEdY?= =?utf-8?B?V3V3KzZ0M2tNZW5WRW1LUWZUMEdtWkRpV2N5QWdIVytvMHRNYjNGSkJ2Njh4?= =?utf-8?B?OGZiZE9lZytTaHdDL2paTnhlVlUrQUpTQmt4MnZ3bVZINEpVMjhKbm9ObkVP?= =?utf-8?B?alQ3S1hNTVZSVU1TTHdYWlp4cDFnQWlFWm95b29HckZ1L0IrWElnTDB3VERj?= =?utf-8?B?TUxRSkN3NTU4TXhwV3ludVpNNWlBOVVTaURPYnlMM3c2TEF1eWF1ZjVkU2VN?= =?utf-8?B?WFBZKzdwT3pmV1JqZ2FUR1prN2VKM2RMbkxKSUcvOFllUTVoSktHYm5vbkMv?= =?utf-8?B?RlhYSmZDakgwYnR5ckNLUkw2U2FIczhmdGZxTkVzeFl3NktTM3hHMXBPeEIr?= =?utf-8?B?Umd0UkcxV2Nzd1Q5ZHlvajA2NmVBbXlqSEZFTWZpSFJ4RFB4Zm55b1lWRkEw?= =?utf-8?B?TWZ5T3d4WjE5cGZaVVBSQStIb3NaQmNFVDM0WWVMQThxbjlLNzhsSzZZL3VD?= =?utf-8?B?SklpYUlxMzdxK0YzWFRZVFJERkx3cEp2MjVwa2E0VVRQa0VaQm9EQ1lsL2tW?= =?utf-8?B?YXExRS9mUmg3OFNiNnNEcEU2QlBuazFWSkF6ZitsZTJzQVU5S3E5S3RLbXRN?= =?utf-8?B?YUY4Sk5qTTAyc0NIMHhuZW9PYmZ0L3BGNE1CejVVNnhnLy9oRW82VURvek1W?= =?utf-8?B?cXB6a25rY2ZLSVFJSFpTOXFqRDVMVEE5RXBvR3FNNkdKMkdhRzQyRnhYTlgv?= =?utf-8?B?RDNRdHpGQXNKSkwzUXNkTG9udmc3L3BGZngrSXF0RlBIc0p6b1dVMUZ1Y0JQ?= =?utf-8?B?bkNQMlVqRXpZdU4wUE91MVdTb1lGTHZEVUlvSVlzSTViZXVyVWZCaEVPUVdI?= =?utf-8?B?OUhKZG1kbk5RK3JIVEtUSklac21TM3pDbWh6enN1YUMrUmNVL0ZrVjZCNGdy?= =?utf-8?Q?9xJ+7Ur9s5d+bdR7SQTFYGHwj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c677957-7b3d-4fd9-0510-08da8ff4876b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:42:43.4795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BT3ig55szJRqBGonfeITwHcCFia37X62xPCOr0KEgSv+MS8bxkiZ6JUjyY2h1U00onUe3vobQ6W6yc6xOouElA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8374 On 06.09.2022 09:39, Penny Zheng wrote: > When a static domain populates memory through populate_physmap at runtime, > it shall retrieve reserved pages from resv_page_list to make sure that > guest RAM is still restricted in statically configured memory regions. > This commit also introduces a new helper acquire_reserved_page to make it work. > > Signed-off-by: Penny Zheng Just FTR: I have no further comments here, but I'm also not going to ack this change with ... > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) > > mfn = _mfn(gpfn); > } > + else if ( is_domain_using_staticmem(d) ) > + { > + /* > + * No easy way to guarantee the retrieved pages are contiguous, > + * so forbid non-zero-order requests here. > + */ > + if ( a->extent_order != 0 ) > + { > + gdprintk(XENLOG_WARNING, > + "Cannot allocate static order-%u pages for %pd\n", > + a->extent_order, d); > + goto out; > + } > + > + mfn = acquire_reserved_page(d, a->memflags); > + if ( mfn_eq(mfn, INVALID_MFN) ) > + { > + gdprintk(XENLOG_WARNING, > + "%pd: failed to retrieve a reserved page\n", > + d); > + goto out; > + } > + } > else > { > page = alloc_domheap_pages(d, a->extent_order, a->memflags); ... the gdprintk() left in here. I'm sure someone else (Julien?) will provide the necessary ack. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 10:50:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 10:50:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399787.641096 (Exim 4.92) (envelope-from ) id 1oVW9l-0005kw-9d; Tue, 06 Sep 2022 10:50:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399787.641096; Tue, 06 Sep 2022 10:50:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVW9l-0005kp-6H; Tue, 06 Sep 2022 10:50:13 +0000 Received: by outflank-mailman (input) for mailman id 399787; Tue, 06 Sep 2022 10:50:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVW9j-0005kj-DV for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 10:50:11 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad6d70ff-2dd1-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 12:50:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7871.eurprd04.prod.outlook.com (2603:10a6:102:c2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 10:50:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 10:50:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad6d70ff-2dd1-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFnQvHIcKpip0Rajs3YxpaUkAXm3VOWj30EeZiyaEpXGTG5xx0ulsiY7rcC5/ChWQlgtSBYLNCAzS7IvXDddwykEKHrq518RGL5YnW58FKwdr2n1lulm923PaEUA0+re2A5ANTVFuVDaRMJQsXF0XoslrS9zSlotSJQZgaXRXx49hdkIdUxq+iyqpC2jAJzb0yLlh+uWCvkvXxx9VlGLlnuZ+iSNUEuIQMNXYWW+zQxeWuWHi1bm1KuC9/SjqxD0Xg4pV9MKppDQNKu97PBiGwL9Al7jPpryHWJJefguIWKoEtMv8b5hgjPMyVx6U5yn3CuZPDFuq0wLu5TXPSf4Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mVHFEzJy2bZkqN9lRm6SJEK5Ukvew4+JJEP8co6PMog=; b=hE6ePl/606ZrOJehSjs6x0MXntlzuv46bvzrRHCJ2mbLzx2PHiIV2Ai+ZFuwgEVIzotJK84e5U/xIgETOdRbiGy13P2kFxuHsOY3dDHKtyBQUXug/uthW3iE/qE+eRzxwBxWXPcCwP4cXMhZ9bzb6bA/yISooJ5t4eQmg++dcZ8zUm8mLgVsCdA01CF8YwMNFQgq1T1Aw4fvzAkK9AeHaHpBjQMqkQJc+IRfThXbnO759iUaiEd9puC1dqtMxQEO/1AuGEuJUhUCvtl4UCmT0unJgxIEB/3SmfHqKwkhImdlsHrc0UIOHgWHQmyQwmmQIt6uHQi7k64Lep0IIzt4Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVHFEzJy2bZkqN9lRm6SJEK5Ukvew4+JJEP8co6PMog=; b=Ypb2/ouYFyZgp6vZg6xUr8sttB4uN/KJl7XdRuZDkZjHHn0IhQgK7z5cwh/Yng6g7zRGMRzlPEMRFm09B6uYMuoXznXG5GY8n7WHqI21NXwNp3Pl5M6lqBeL/ol+pNu+86vRBJPNAOuHKugRyc0z7x7B2xHKjBi9N23mVuzPBXVcKeV8XNugLPs2J+Uj9Fs2dFniVemegjs/6q1o+Q7RJFdqXNs8c44EDIWesqf8MQCECU+gRmUnqe43/wfjkPSYsaDp6BlpMzjJ55ufKJl65kJMuGKpdxSJDKmdWbSpLKHsNDZdwcFW8vWsqibZvRjMPaTPq2NkIDQ9SzOJrjZiNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5d4367ac-f853-ff32-115b-55fb0fd159a4@suse.com> Date: Tue, 6 Sep 2022 12:50:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US To: Dylanger Daly Cc: xen-devel@lists.xenproject.org, Andrew.Cooper3@citrix.com References: <55eb8485-0c0d-51cd-c9b8-d517994ec6c6@suse.com> <7807b9cf-a09e-a393-ee7a-dc220a68e56e@suse.com> <3b2ad2ca-3c6c-4dcb-c603-bd5440350f20@suse.com> <2dHPPtixTlkUXYEzNPFRI4ezKHSe1A2VaThMjBpd1aM3NFkZQuyRdfmNWCigm1oXfdKhOwDJGoPBBIMLYtYhQlENV2eFVZ0G9EMOMj5e6UE=@protonmail.com> <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04099840-2f8e-4ada-ccf6-08da8ff5907b X-MS-TrafficTypeDiagnostic: PA4PR04MB7871:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iNEvaEywImMQlp4wCvdqUzRjFwqLvKI2ZkoBbEAeSyKzN2uC03JB2Gg9MiGaJDbOO8lCPMmotKn2eVsmSAO2CIADgjcJ3mye0w6ueqk3ta41XgA437oxAlk9KdTw0pqLmX2cEGWk1duDq5iKq88+omkQyZZsN/mEEufFF1Uz/lfzTn5h7ZG+ccxmY1lXy3vf15cUn2Iz1v167XDfJBmtOdnci5m+q06AjI491gW2ZC5KIlAPN+alUsLnHisyXmtAvtiq8ZKCPx1+VASpQv/4eSVo7CMEemnCXGQHiiRatPZ7mcz5KGV6lIVqlznnk0FGEc6tU4UJ6aB11w1d8w4aNF0Azg7p/F9LDyLcwZiAFOTgaF+KjuC1VKK2qBEH8vvzJVhLHjCLaklPp3A4YsH6lw9H2KTU63oN/igWOkpSecJu3fDlz9b0Qr0G7xTYngQDB6gS+2wRTRPigI0CHaBF082nCLYmkXEXgD4AIu1KOWSYclBCoYtQN1r15xMS5YBIjfPVp7YGx+djmqnZVvIu1JPOXVGcIAjlLBfUE96xKVbkjyyRo7GHc1aNpMe1WfU1cvAL1l0ZTJwtcYG08N1kSbxmd57mKqo+d4z1UeWfSSweacGZR6YnRZbXyaHRW3f6E3Lu56QKC3q4jsFXx51JFCJx5drwYgHzTiLgsB/BmGyn3LHHdFog5vUyK62XdWRcimGadLO1pG+F9Vhzo7B3SQ7mQq7K4ug2PbbTyNGa8KhDbJpDKFZfbGIodZMLILSt69hmoRiJ4XTB6kH8FZ0+3YxGpQLeesIrWlozdlJjDTo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(39860400002)(366004)(396003)(6916009)(6666004)(38100700002)(66556008)(66476007)(8676002)(4326008)(66946007)(316002)(2906002)(4744005)(5660300002)(186003)(8936002)(2616005)(53546011)(6512007)(41300700001)(478600001)(6486002)(6506007)(26005)(36756003)(86362001)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDRkRytSSzUxRy9BWnhOdGZPcnpSN0o1ZVJNWEZBS1l0U3RXWnFNL3MzVElJ?= =?utf-8?B?NzR5djNlTzVTdW1LV01pWjd5aERLbVpBSGJCU25ZUG9OTzRFUVVVYnZIVjVw?= =?utf-8?B?TlE3UlRYQVRrKy9VdVNkNHZQb3FwSW9qeFNBUjRoV0ZLdVhUK2R4eitHRDR3?= =?utf-8?B?ZTRaWjJmWk03Ry9vUjk1cXd6bjBYVEEwT0hzY1JSK1BCODhMRmNBcnJVZThP?= =?utf-8?B?bGVzQXFRZG1GTjRPbjRWcWlXdWwrSlQzS1hKaWlWR1dtOU5pNVczSlZPNnZk?= =?utf-8?B?VVN5Mnk4bkdUbHRZWFN3WWZjY1Z0TytvRUx4c3d3Q2FqTENyUXBiSTY0WnZY?= =?utf-8?B?OFVtbkxWaUcrS3BiWEEwNGhhYUxicHYyVDE3blpjQXZqdWpkbHNnSkhudHdJ?= =?utf-8?B?YzI4MFJNb2RreGJqR3BtUUNUUVV2TlpjVzRGNER2UG1IL2xPeVFLWWZwYmts?= =?utf-8?B?MzFXeHlFS1ZLOGc0VGVySE1uY2hSUHJYUVliQTdXNk90ZTRrd01KK1hCZjNp?= =?utf-8?B?WUhESS9IaDh4Wlc0dE1lQkFkM1AzSFk1dlpMMWQyd2tYcFJEYWZIZ2dsT3Q1?= =?utf-8?B?RGZTMDdSN1ZZMVZVMkdoWVp4QVVoZlIwT29XNHlQRG5leG93UmdOWFdIS1hO?= =?utf-8?B?cmorMEZTcGY3ejNMUVJSM0NsRGlqSVc2V2xJQXFoK0MwUVdoM3BzUFhBdGdX?= =?utf-8?B?TFVrNDF3eWxFdnErVzlNaXRmNWpENUx0Mm01bXlINkR2RXhCdGRlNDFydWNY?= =?utf-8?B?VElkbnQ3aW9lMUhUekxtNTNoUVlndHZFQ09xdmVNTDU5N1lNcjl0UXpyWmU0?= =?utf-8?B?eENhY2IxQjBrM2xrTDFhZUI0cmlyU2wzdU1ud3hQZlNOR0ZLWE9tc3FJN3Qx?= =?utf-8?B?TXJYS0lVcWJSb1Q3R0VodTNxMzlzZWxueG41dUl1MVdQTjVIeTdFL2Y3OC83?= =?utf-8?B?bkVpN3R1LzFCODJTa2ZVV2QxN2xwV3NDSVZVRU41cnhEVTUycFpsRVI4MzZm?= =?utf-8?B?eFZpZXJRdm9EbFZlbzlWUVRtUjhqZlVBME0wVFp0cHFBL3BkWG5MVW9TcXNH?= =?utf-8?B?bVM3NnJoSW5HNU5yTDB3WFlwRjhMcUZEMXZMdS85c0Q4M3RQQnA0aElJelNr?= =?utf-8?B?clhCOVhLakpoazE2M2VnN05HeDRyOUlxRlY3TUZaMGFpU0praENxQWdNdUpm?= =?utf-8?B?VDlkRXlyOWZZcWZqSVVFNUl5d2hVeXROWDBDSVI0bG16NzErNEtKK2pPTWVa?= =?utf-8?B?WGQ0aEM1Ni9ESnhUZ2NKS0x3cC9iNThQd25zcjMwbkFTQXVQc2IvRnhMVjdX?= =?utf-8?B?aTJYVlNMSEVyTVNjSEpqMUtsc0RjOXV2Y2lDRzNBZ1ZVSmcxNVdDL2NvTDlh?= =?utf-8?B?bkIyS0JZMHp2ZjYrQlZxTVp1bTFmdEZXcU1oR0llZjBaY2hGTVZ1QUFac3gv?= =?utf-8?B?RjhZaGVuTWFsYTBhaHVaeEVMZVhnZDF3TXNMcUl4MDZUQXBQTkNhcmtuR1pM?= =?utf-8?B?SW1yaCtJcnIrK0lwNXhZWHBGS2x1M01TWEpWMXZBOWxYRHh4QUIxYmR1YXFS?= =?utf-8?B?TWtBL1NpSERaeFo0WXVGYmQ2MmkzTjlPYTlraDduTEdkUHFPY2xYN0tTSDlN?= =?utf-8?B?NFJEOVhBd2hJbUd6RjhKc3IzVkVTVFlsRzdEYkNid1Q4bTQ4UlpiZit4UHJ2?= =?utf-8?B?a0FzSGtudkJuSjhTTDZtY1hmQVVyRDhXMjNPNUdJTkRaNW96aWJpcW9jcHNR?= =?utf-8?B?VW5SZjJDbkV3YVNyaGRhZ3o0Nk5yNDB0a3JjVUdOMUQxWGlqSGIySHova0Nu?= =?utf-8?B?T3owb3B3L3Qzdm5VNTB1YTJsd0c5L1EzaHNYRXFuQ3VzVzNpSGE4QUorWTVE?= =?utf-8?B?R24vNEc2aS9tN1FYdlQ1ZXhiQ2xIZi9vVnlKWVN2TmtncUs1L2M2RkYzbFFN?= =?utf-8?B?SW1udFptNTdsR1IvQW9FT2lhZTEwQ0dqREg3Q3JDQWpZbHFhVCt6VXFVKzJo?= =?utf-8?B?VnIwcFhGeUpRcWdtZzcvclhwQ1lxQWoxbC9sYVlDUHJXZTUxSXVLaE1WWjZm?= =?utf-8?B?aFR2QzVueUZSZ2l2NmNwTGYvV2ZRQU9zbjVmeHB5WkZqdGRFdUd4RVV6TGsw?= =?utf-8?Q?Fie60OircFg3s1MaD4KIG+3IV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04099840-2f8e-4ada-ccf6-08da8ff5907b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:50:08.2325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 481YdGljtY4cclPmC3V9k1u+zydEiOIIfa2P+b6bMgEBG9M9XknJ140e7AtuMy8FNyOpiKIXvKLOnrsKwb0ONg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7871 On 01.09.2022 00:12, Dylanger Daly wrote: > I think I've narrowed the issue down to a PCI device, if I start 2 large VM, then simply run lspci in dom0, it'll trigger a crash. > > This makes sense as sys-net works fine until I start a larger VM, then I see a 'chip reset' error in the appVM's dmesg, I assume the entire PCI Bus goes into a bad state. Sounds like this wants investigating from the Qubes site first then. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 11:11:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 11:11:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399792.641106 (Exim 4.92) (envelope-from ) id 1oVWUD-0008LG-2n; Tue, 06 Sep 2022 11:11:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399792.641106; Tue, 06 Sep 2022 11:11:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVWUD-0008L9-09; Tue, 06 Sep 2022 11:11:21 +0000 Received: by outflank-mailman (input) for mailman id 399792; Tue, 06 Sep 2022 11:11:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVWUC-0008L3-3W for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 11:11:20 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2088.outbound.protection.outlook.com [40.107.104.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0f44cf1-2dd4-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 13:11:17 +0200 (CEST) Received: from AM7PR03CA0018.eurprd03.prod.outlook.com (2603:10a6:20b:130::28) by AS8PR08MB6693.eurprd08.prod.outlook.com (2603:10a6:20b:39c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 6 Sep 2022 11:11:15 +0000 Received: from AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::c8) by AM7PR03CA0018.outlook.office365.com (2603:10a6:20b:130::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 11:11:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT057.mail.protection.outlook.com (100.127.140.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 11:11:14 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Tue, 06 Sep 2022 11:11:14 +0000 Received: from 2bbe0e0e3cdb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B2BE7DDE-FFF6-476F-A834-714134062663.1; Tue, 06 Sep 2022 11:11:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2bbe0e0e3cdb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 11:11:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6343.eurprd08.prod.outlook.com (2603:10a6:20b:337::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 11:11:02 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 11:11:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0f44cf1-2dd4-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L43wEP77iEry592Vdss9ekcZFdHFKzjLge9/cxvUqN3Gb7xflPYHoxgGPtmQGhtCcn+K8Ga5KDLT1WKtGbErQfzwN6q1LXFBpdCcBSM3UVh2DpFa3KEjIr1Fhn/KdY5rS5b/iQWIwYfld2wE8uhzy3tlWtzdPkJ8SwW10gmuvjyQEZ2vDzzV+JU5VMvzD7Aho2PWxQHbNQ0ZfNSu6159fbN9aFl87v/XDknGoT4BwbW9MFicXCFZ8k6gKDq7hwUSNQZ5sBCElWySZcPVuunNMq1IoMd+hAqNOm6Kv+b840032OfWE/uSP6INC7OaWH9IaylnZO2Xp1TOIRylqWV4Bg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIaVykuJDgreJnWqjs2cBJkNRw+ZlF/GYZztbXTqFXY=; b=NE1QSnX1hjzVA7R+rk0E1g2lF1MotWpAcfrmKJPIqtyfjpti8u0tT3eKlVVJXpp9wMJC7MBVekcH+KtnEnW/KZEaO18cq00fzrcxplJ/CqUC3ojFznXNmjtFCqT55PbjOT1/KFVT9HCSzW30ifmh+fvYzn0VjLedQU9EsfefqYTYC+9r+mkQPreH+aWfryII62M5vup9RN6NoPZnLHJCz8uYuGTFr2JFlwTMZ2qfg1Uff7icspHq7gBPlUu8fqTsSnlieOlNAXce0F9DMCckKfk7L/A4doCWW2x6xmDfWSlWf3vOcGxccOoovvgoDT6rJttadh7E2ZvzXUynAirXSA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIaVykuJDgreJnWqjs2cBJkNRw+ZlF/GYZztbXTqFXY=; b=1BKEaBEjIYYd46LHTEF/TX8Fappg5DmeePkFV2nFAX9aIwM+iNQLec1Uv+daECvHXBOiaghr4xSTW5Qr+vXmy59/37voNRa1uxOmvwuOPmA72xSXxgaBnaz9AAUFSyGTtPMuTD8hHKZoBDsfLFzMsmGhgRVhcUhmqyqmGMrKPm8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CnBk6YfNof9baC6HXotUHlnjHZcNj6+ykRxuugJNNx11C6y76kX1WFTbypM1fVltAE0de2g0thTnAF+36DiwO6hEWBilz2XMMlcKd53a6ZdONEwhnG/MAcpXCAdbrvgH1MP39dl0VLVgJpoZ4NkdO2pOqcbTPIjMS3vsq3vuNEl9pKS/zVXxL8zE0to2oY1ZyeL9jyUyDIv/oehA4kvtrJaXD+bLyhHjopf2n6CWowc5P2B2Vv1+Q02mXuf+1YaVEVDyqnca+C6S6VlLvcU1z6Kv9Osylk5iitm+I8t1KpJpbeJ0J8dD9Q67pjWhrD00pUMwIG0B/F9NVz44rvqC7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIaVykuJDgreJnWqjs2cBJkNRw+ZlF/GYZztbXTqFXY=; b=cABDTfWLx8RUHcF8eHGzHVXjZTl9o+1ylGEMkK4XpGstXFhmtJnOUbxk2kd1IZ27vzv5qfSiugWwlc2R8BcLevud+9mvFOwgLhRM9IuiwoB99hho/z5hOYKD9TgFT8eYBMiSeb2wpnrPACmmp6BoleS+AbkPnolhVBsZoUFtRs9fQC86Rpw/+PjM3LIP5fJNCeA/O5Rf0TimTCVw4VEkYQBNz+9YWCX15Lasnv6H5rnF/pS1Klk7bFnDxc21RQuoKyG969Mlt2zVmjT2z4wuxxFTAzUeCrGPuMZ0Lh+bx2B0248iOxZLTM96/iQMLxdQuhQBHgMHslvHmbjqONjWVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIaVykuJDgreJnWqjs2cBJkNRw+ZlF/GYZztbXTqFXY=; b=1BKEaBEjIYYd46LHTEF/TX8Fappg5DmeePkFV2nFAX9aIwM+iNQLec1Uv+daECvHXBOiaghr4xSTW5Qr+vXmy59/37voNRa1uxOmvwuOPmA72xSXxgaBnaz9AAUFSyGTtPMuTD8hHKZoBDsfLFzMsmGhgRVhcUhmqyqmGMrKPm8= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYwPj6dlOKXE+k5kuuj2vKrDnG5K3RJT6AgAB0+PCAAIHpAIAAAbyA Date: Tue, 6 Sep 2022 11:11:02 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-4-Henry.Wang@arm.com> <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8638985A6F4AB04A943EC4FAB6287BAB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 844ea119-9e50-4791-da31-08da8ff883a1 x-ms-traffictypediagnostic: AS8PR08MB6343:EE_|AM7EUR03FT057:EE_|AS8PR08MB6693:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3+XpGdWiqn9/OFx3HPkdwRP9rp8C+Gn4RGlqimnK5Sib47BQ03jvgaDsnB5HCnITDenLw0feckFY+gCMbQCHhF090agEJGMDATsGe5/txgCzZwR7o7OZ1fg47quXUyNamBMgIdO2tg/PiO6M2CiGBIcm2ZkjoD9n1QNAcOfpd7MCs2/J4T/2Efn9B218Ifak5RexoQWVd+nClnEAjTzkbHJs5SBYbZ+/+ABwPFwa7FxzTaGFdehzTv8tSTlFWUnWBNZDUIUJDg9ftYfFNQdAwAnmjxKX2/1+BtB3Dn0/edSXs8scMh+3W8x6tq0GJhlMdEj4mLdYSOcpk8yqdYqrCMtXnWYCDK3fovnMYGbCVKqZCVBywVNI1bF/MNkYrEC4ulThdCCgsqPvgQiYULE+FrJ0RJGDlaa7vCR8S6tn9J2UOBPJCNEfFxWvXEvGKLgYLXrbjVxvbJo7qgujtUq8NUYwXsuoa31akovbsXs3GsJrnyV83SjFFnU5Ua7U00onqduXdkjmrTGyZjhV+gCLWujnYgJogqKlOFrR2aE3iqMDfy0AcACSOpJkSTQ6tW3CXaIEp7+1BH3q86PNiWXH8ArJIHfY5C0+4NsRIc9ajgbb3SAg+OWI0R07Rx99aJKqVdfTb9Rd32gc9TfXW0tHKuS0f8v9sNfuUvqIR9BH1i4oSR/qrTfAHGAhlyOFTvpFLJinhAGbhQ9a5rw0labz9Aum6RU/H68q4LzKavsUjEYlPK0IRNLptD+yfiO5t+ZtjRghzFRZ9pd3wVFGGTzjWA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(9686003)(26005)(5660300002)(186003)(52536014)(8936002)(83380400001)(7696005)(41300700001)(33656002)(71200400001)(86362001)(6506007)(478600001)(38070700005)(2906002)(316002)(66556008)(66946007)(66446008)(66476007)(110136005)(64756008)(8676002)(55016003)(4326008)(76116006)(54906003)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6343 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f8c6ed9d-04d2-4e54-bfc1-08da8ff87c1f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NAFdPgDp2Gzr1kdiwzGSJzRzFjkh18RhQSNgvMCIL7/yT4hU0Yvv1sphKPlAcWUGw4BnRb8ZFQ9IAGYxsQ9H/w/ZzA4HDxhE0Kao+AeRM6G0NS9Ayb+s9FO+XWewZ8pW4Cb7xcPbjHwvezH4IosRtVYMiwqA6zXMx11Y44ntlxb0020p+p2l0ugOdldIts+PxfEWVKtJMv3832M+o+a3DcA4wgIdhQPBCjVNc/R2aIbZYkos2bqN2QJMwQOc3ifwtMR4EOuMgYaRHZfteDCVJMKA+4ffIKaUZ3FLPu7Zhw3yzwnp6jPnW4j7TmxIgVi2Jk/Hab/KS1yTE7K2H+YUSwnphBkzjh8HGCvzcxKT/9Ff2HuDWCuocXTHlOBYlrJ7LYgct6Q4RwIYVcMCAo4aSHYX06Dx7kW8Iocto2ixJpSvsv07VnCAmr7nlReUhlQjrgP9rWX8ewqNpoEi8t+rpjnGFzcZry6oRrbvb0+HanD+KAsTkD2LiQu7PCY1HLgr4PcshFffhyRk5y/JRuyWQ7hd5OoKFmKoaSOq1StqerM229Nb6cUY6JLZ9KlgpUS6M125Hd6d4RlMK84Yrr6Nf3cAfcWAB8Y9t4Ny8+gdACBEaXmUpNFQu2sk9X6dP4sQT4KbuWispB7rCuEL0UF4kaqhgV7NHYP/H4mgqz2hYCSknc/khiQMKt4edlaYcHOpEnr4h4VIO1ksGZtMD5U4iFaz4PqrrXYvmaDoK+rV5SSWGKEvI2cGmyaY/O+C1hOy1/94b8j69ZK4iVorhPIolg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(40470700004)(36840700001)(46966006)(36860700001)(8676002)(356005)(83380400001)(2906002)(82740400003)(55016003)(81166007)(70586007)(40480700001)(70206006)(4326008)(110136005)(316002)(40460700003)(54906003)(26005)(52536014)(8936002)(5660300002)(478600001)(47076005)(9686003)(336012)(7696005)(6506007)(82310400005)(86362001)(107886003)(33656002)(186003)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 11:11:14.8649 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 844ea119-9e50-4791-da31-08da8ff883a1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6693 SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0aW9uIGFuZCB5b3VyIHBhdGll bmNlLiBGb3IgdGhlDQpwb3B1bGF0ZV9ib290X2FsbG9jYXRvcigpIGNoYW5nZSwgSSBhdHRhY2hl ZCBteSBjaGFuZ2UgaW4gdGhlIGVuZCwNCmFuZCBwZXJzb25hbGx5IEkgd291bGQgbGlrZSB0byBo ZWFyIHlvdXIgb3BpbmlvbiBiZWZvcmUgc2VuZGluZyB2Mw0Kc2luY2Ugd2Ugbm93IGhhdmUgbGlt aXRlZCB0aW1lLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+PiArICAgICAgICB7DQo+ID4+PiArICAgICAg ICAgICAgYmFua19zdGFydCA9IGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5rW2ldLnN0YXJ0Ow0K PiA+Pj4gKyAgICAgICAgICAgIGJhbmtfc2l6ZSA9IGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5r W2ldLnNpemU7DQo+ID4+PiArICAgICAgICAgICAgYmFua19lbmQgPSBiYW5rX3N0YXJ0ICsgYmFu a19zaXplOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICAgICAgICAgIGlmICggYmFua19zaXplIDwgc2l6 ZSApDQo+ID4+PiArICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPiA+Pj4gKw0KPiA+Pj4gKyAg ICAgICAgICAgIGFsaWduZWRfZW5kID0gYmFua19lbmQgJiB+KGFsaWduIC0gMSk7DQo+ID4+PiAr ICAgICAgICAgICAgYWxpZ25lZF9zdGFydCA9IChhbGlnbmVkX2VuZCAtIHNpemUpICYgfihhbGln biAtIDEpOw0KPiA+Pg0KPiA+PiBJIGZpbmQgdGhlIGxvZ2ljIGEgYml0IGNvbmZ1c2luZy4gQUZB SVUsIGFsaWduZWRfc3RhcnQgY291bGQgYmUgYmVsb3cNCj4gPj4gdGhlIHN0YXJ0IG9mIHRoZSBS QU0gd2hpY2ggaXMgbm90IHdoYXQgSSB3b3VsZCB1c3VhbGx5IGV4cGVjdC4NCj4gPg0KPiA+IFll YWggSSB1bmRlcnN0YW5kIHlvdXIgY29uY2Vybi4gSGVyZSBJIHdhbnQgdG8gbWFrZSBzdXJlIGV2 ZW4gaWYNCj4gPiB0aGUgZ2l2ZW4gc2l6ZSBpcyBub3QgYWxpZ25lZCAoYWx0aG91Z2ggbGVzcyBs aWtlbHkgaGFwcGVuIGluIHJlYWwgbGlmZQ0KPiA+IGdpdmVuIHRoZSBzaXplIGNhbGN1bGF0aW9u IGxvZ2ljIGluIHNldHVwX21tKSB0aGUgY29kZSBzdGlsbCB3b3JrLg0KPiANCg0KU29ycnkgSSBw cm9iYWJseSBleHBsYWluZWQgaW4gdGhlIHdyb25nIHdheSBpbiBwcmV2aW91cyBtYWlsLCBidXQg c2luY2Ugbm8NCmNoYW5nZSByZXF1ZXN0ZWQgaGVyZSB0aGlzIGlzIHB1cmVseSBmb3IgZGlzY3Vz c2lvbi4gSW4gdGhlIGNvZGUgd2UNCmFyZSBzdXJlIGFsaWduZWRfZW5kIGNhbGN1bGF0aW9uIHdp bGwgbWFrZSBzdXJlIHRoZSBlbmQgYWRkcmVzcyB3aWxsDQpzYXRpc2Z5IHRoZSBhbGlnbm1lbnQg cmVxdWlyZW1lbnQgd2l0aGluIHRoZSByYW5nZSB0byBhIGFsaWduZWQgKGxvd2VyKQ0KYWRkcmVz cy4gVGhlIGFsaWduZWRfc3RhcnQgPSAoYWxpZ25lZF9lbmQgLSBzaXplKSAmIH4oYWxpZ24gLSAx KSB3aWxsIG1ha2UNCnN1cmUgdGhlIHN0YXJ0IGFkZHJlc3MgaXMgZm9sbG93aW5nIHRoZSBzYW1l IGFsaWdubWVudCByZXF1aXJlbWVudCwgYnV0DQp0aGUgb25seSBpc3N1ZSB3b3VsZCBiZSBpbiB0 aGlzIGNhc2UgdGhlIHN0YXJ0IGFkZHJlc3Mgd2lsbCBiZWxvdyB0aGUgcmVnaW9uDQpzdGFydCwg aGVuY2UgdGhlIGlmICggYWxpZ25lZF9zdGFydCA+IGJhbmtfc3RhcnQgKSBjaGVjay4NCg0KPiBJ IGRvbid0IHRoaW5rIEkgYWdyZWUgb24gdGhlIGxlc3MgbGlrZWx5IGhlcmUuIFRoZSByZWdpb25z IGFyZSBwcm92aWRlZA0KPiBieSBpbiB0aGUgRGV2aWNlLVRyZWUuIEFuZCB0aGVyZSBhcmUgbW9y ZSBjaGFuY2UgdGhleSBhcmUgaW5jb3JyZWN0DQo+IGJlY2F1c2UgdGhlIHZhbHVlIHdpbGwgYmUg c3BlY2lmaWMgdG8gYSBzb2Z0d2FyZS9kZXZpY2Ugc3RhY2suDQo+IA0KPiBSZWxhdGVkIHRvIHRo aXMgZGlzY3Vzc2lvbiwgSSBjYW4ndCBmaW5kIGFueSBhbGlnbm1lbnQgcmVxdWlyZW1lbnQgaW4N Cj4gdGhlIGRldmljZS10cmVlIGJpbmRpbmcuIEkgdGhpbmsgd2UgYXQgbGVhc3Qgd2FudCB0byBy ZXF1aXJlIDY0S0INCj4gYWxpZ25lZCAoc28gdGhlIHNhbWUgRGV2aWNlLVRyZWUgd29ya3MgaWYg d2Ugd2VyZSBnb2luZyB0byBzdXBwb3J0IDY0S0INCj4gcGFnZSBncmFudWxhcml0eSkuDQoNCkkg YWdyZWUgd2UgbmVlZCB0byByZXF1aXJlIDY0S0IgYWxpZ25tZW50LCBhbmQgY3VycmVudGx5IHdl IGFyZSBmb2xsb3dpbmcNCnRoaXMgYmVjYXVzZSB3ZSBhcmUgZG9pbmcgMzJNQiBhbGlnbm1lbnQu IEkgd2lsbCBhZGQgYSBjb21tZW50IGluIHRoZQ0KZnVuY3Rpb24gY29tbWVudCB0byBtZW50aW9u IHdlIGF0IGxlYXN0IHdhbnQgYSA2NEtCIGFsaWdubWVudCBzbyB0aGF0DQpmdXR1cmUgY2FsbGVy cyB3aWxsIG5vdCBtYWtlIG1pc3Rha2VzLg0KDQo+IA0KPiA+Pg0KPiA+Pj4gKw0KPiA+Pj4gKyAg ICAgICAgICAgIGlmICggYWxpZ25lZF9zdGFydCA+IGJhbmtfc3RhcnQgKQ0KPiA+Pj4gKyAgICAg ICAgICAgICAgICAvKg0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgKiBBcm0zMiBhbGxvY2F0ZXMg eGVuaGVhcCBmcm9tIGhpZ2hlciBhZGRyZXNzIHRvIGxvd2VyLCBzbyBpZg0KPiA+Pg0KPiA+PiBU aGlzIGNvZGUgaXMgYWxzbyBjYWxsZWQgb24gYXJtMzIuIFNvIHdoYXQgYXJlIHlvdSByZWZlcnJp bmcgdG8/IElzIGl0DQo+ID4+IGNvbnNpZGVyX21vZHVsZXMoKT8NCj4gPg0KPiA+IFllcywgSSB0 aGluayB0aGUgY3VycmVudCBhcm0zMiBiZWhhdmlvciBpbiBjb25zaWRlcl9tb2R1bGVzKCkgaXMg d2hhdA0KPiA+IEkgYW0gcmVmZXJyaW5nIHRvLiBJbiBmYWN0LCBJIGp1c3Qgd2FudCB0byBhZGQg c29tZSBjb21tZW50cyB0aGF0IGV4cGxhaW4NCj4gd2h5DQo+ID4gd2UgbmVlZCB0aGUgZW5kID0g bWF4KGVuZCwgYWxpZ25lZF9lbmQpIHNpbmNlIHRlY2huaWNhbGx5IGlmIHRoZXJlIGFyZQ0KPiA+ IG11bHRpcGxlIHJlc2VydmVkIGhlYXAgYmFua3MgYW5kIGFsbCBvZiB0aGVtIGNhbiBmaXQgdGhl IHhlbmhlYXAgcmVnaW9uLA0KPiA+IHdlIGNhbiB1c2UgZWl0aGVyIG9mIHRoZW0uIEJ1dCBmb2xs b3dpbmcgdGhlIGN1cnJlbnQgYmVoYXZpb3Igd2UgY2FuIG9ubHkNCj4gdXNlDQo+ID4gdGhlIGhp Z2hlc3QgYmFuayB0byBrZWVwIHRoZSBjb25zaXN0ZW5jeS4NCj4gDQo+IFhlbmhlYXAgaXMgY3Vy cmVudGx5IGFsbG9jYXRlZCB0aGUgaGlnaGVzdCBwb3NzaWJsZSBzbyB0aGVyZSBpcyBlbm91Z2gN Cj4gbG93IG1lbW9yeSBhdmFpbGFibGUgZm9yIGRvbWFpbiBtZW1vcnkuIFRoaXMgaXMgaW4gb3Jk ZXIgdG8gYWxsb3cgMzItYml0DQo+IERNQSBkZXZpY2UgdG8gZnVuY3Rpb24uDQo+IA0KPiBJIGFt IGxlc3MgY2VydGFpbiB0aGlzIG1ha2VzIHNlbnNlIHdoZW4gdGhlIGhlYXAgaXMgcmVzZXJ2ZWQu IEJlY2F1c2UgYW4NCj4gYWRtaW4gY291bGQgZGVjaWRlIHRvIGRlZmluZSB0aGUgaGVhcCBzb2xl bHkgYWJvdmUvYmVsb3cgNEdCLg0KPiANCj4gVGhhdCBzYWlkLCBub3RoaW5nIGluIHRoZSBkb2N1 bWVudCBzdWdnZXN0cyB0aGF0IGRvbWFpbiBtZW1vcnkgd291bGQgbm90DQo+IGJlIGFsbG9jYXRl ZCBmcm9tIHRoZSByZXNlcnZlZCBoZWFwLiBTbyBJIHdvdWxkIHN1Z2dlc3QgdG8gd3JpdGUgdGhl DQo+IGZvbGxvd2luZyBjb21tZW50Og0KPiANCj4gIkFsbG9jYXRlIHRoZSB4ZW5oZWFwIGFzIGhp Z2ggYXMgcG9zc2libGUgdG8ga2VlcCBsb3ctbWVtb3J5IGF2YWlsYWJsZQ0KPiAoYXNzdW1pbmcg dGhlIGFkbWluIHN1cHBsaWVkIHJlZ2lvbiBiZWxvdyA0R0IpIGZvciBvdGhlciB1c2UgKGUuZy4N Cj4gZG9tYWluIG1lbW9yeSBhbGxvY2F0aW9uKS4iDQoNClN1cmUuDQoNCj4gDQo+IEFsc28sIEkg dGhpbmsgdGhlIGRvY3VtZW50YXRpb24gd2FudHMgdG8gYmUgdXBkYXRlZCB0byBjbGFyaWZ5IHdo ZXRoZXINCj4gdGhlIHJlc2VydmVkIGhlYXAgY291bGQgYmUgdXNlZCB0byBhbGxvY2F0ZSBkb21h aW4uIElmIGl0IGNvdWxkLCB0aGVuIEkNCj4gdGhpbmsgd2UgbmVlZCB0byBleHBsYWluIHRoYXQg dGhlIHJlZ2lvbiBzaG91bGQgY29udGFpbiBlbm91Z2ggbWVtb3J5DQo+IGJlbG93IHNvbWUgNEdC IHRvIGNhdGVyIDMyLWJpdCBETUEuDQoNCk9rIEkgd2lsbCBhZGQgaW4gdjMuDQoNCj4gDQo+ID4+ PiArICAgIC8qDQo+ID4+PiArICAgICAqIE5vIHJlc2VydmVkIGhlYXAgcmVnaW9uczoNCj4gPj4+ ICAgICAgICAgKiBGb3Igc2ltcGxpY2l0eSwgYWRkIGFsbCB0aGUgZnJlZSByZWdpb25zIGluIHRo ZSBib290IGFsbG9jYXRvci4NCj4gPj4+ICAgICAgICAgKi8NCj4gPj4+IC0gICAgcG9wdWxhdGVf Ym9vdF9hbGxvY2F0b3IoKTsNCj4gPj4+ICsgICAgZWxzZQ0KPiA+Pj4gKyAgICAgICAgcG9wdWxh dGVfYm9vdF9hbGxvY2F0b3IoKTsNCj4gPj4NCj4gPj4gRm9yIGFybTMyLCBzaG91bGRuJ3Qgd2Ug YWxzbyBvbmx5IGFkZCB0aGUgcmVzZXJ2ZWQgaGVhcCAobWludXMgdGhlDQo+ID4+IHhlbmhlYXAp IHRvIHRoZSBib290IGFsbG9jYXRvcj8gQXQgd2hpY2ggcG9pbnQsIEkgd291bGQgbW92ZSB0aGUg Y2hhbmdlDQo+ID4+IGluIHBvcHVsYXRlX2Jvb3RfYWxsb2NhdG9yKCkuDQo+ID4NCj4gPiBTb3Jy eSBJIGFtIG5vdCBzdXJlIHdoYXQgdGhpcyBjb21tZW50IGFib3V0Li4uYXMgaGVyZSB0aGUgY29k ZSBpcyBmb3INCj4gYXJtNjQuDQo+IA0KPiBSaWdodCwgSSB3YXNuJ3Qgc3VyZSB3aGVyZSB0byBj b21tZW50IGJlY2F1c2UgeW91IGRvbid0IHRvdWNoIHRoZSBjYWxsDQo+IHRvIHBvcHVsYXRlX2Jv b3RfYWxsb2NhdG9yKCkuDQo+IA0KPiA+IEZvciB0aGUgcXVlc3Rpb24sIHllcy4NCj4gPiBGb3Ig dGhlIGxhdHRlciBvbmUsIGRvIHlvdSByZXF1ZXN0IHNvbWUgY2hhbmdlcz8gSWYgc28sIGNvdWxk IHlvdSBwbGVhc2UNCj4ga2luZGx5DQo+ID4gZWxhYm9yYXRlIGEgbGl0dGxlIGJpdCBtb3JlPyBU aGFua3MuDQo+IA0KPiBZZXMgSSBhbSByZXF1ZXN0aW5nIHNvbWUgY2hhbmdlIGJlY2F1c2UgSSB0 aGluayB0aGUgY29kZSBvbiBhcm0zMiBpcw0KPiBpbmNvcnJlY3QgKHRoZSBib290IGFsbG9jYXRv ciB3aWxsIG5vdCBiZSBwb3B1bGF0ZWQgd2l0aCB0aGUgcmVzZXJ2ZWQgaGVhcCkuDQo+IA0KPiBJ IHRoaW5rIHRoZSBjb2RlIHNob3VsZCBiZSBtb3ZlZCBpbiBwb3B1bGF0ZV9ib290X2FsbG9jYXRv cigpOg0KPiANCj4gaWYgKCBib290aW5mby5yZXNlcnZlZF9oZWFwICkNCj4gew0KPiAgICAgIGZv ciAoIC4uLjsgaSA8IGJvb3RpbmZvLnJlc2VydmVkX21lbS5ucl9iYW5rczsgaSsrICkNCj4gICAg ICAgICBbLi4uLl0NCj4gICAgICAgICBpbml0X2Jvb3RfcGFnZXNfcGFnZXMoKQ0KPiB9DQo+IA0K PiBOb3RlIHRoYXQgdG8gaGFuZGxlIGFybTMyLCB5b3Ugd2lsbCBhbHNvIG5lZWQgdG8gZXhjbHVk ZSB0aGUgeGVuaGVhcCBhcmVhLg0KDQpXaGVuIEkgaW1wbGVtZW50IHRoZSBjb2RlLCBJIGZvdW5k IHRoYXQgdGhlIGFybTMyIFhlbmhlYXAgZXhjbHVkaW5nIGxvZ2ljDQpzb21laG93IGNhbiBiZSBy ZXVzZWQuDQoNClNvIEkgdGhpbmsgSSB0cmllZCB0byByZXVzZSBhcyBtdWNoIGFzIGN1cnJlbnQg Y29kZS4gV291bGQgYmVsb3cNCnBvcHVsYXRlX2Jvb3RfYWxsb2NhdG9yKCkgc2VlbSBvayB0byB5 b3U/DQoNCnN0YXRpYyB2b2lkIF9faW5pdCBwb3B1bGF0ZV9ib290X2FsbG9jYXRvcih2b2lkKQ0K ew0KICAgIHVuc2lnbmVkIGludCBpOw0KICAgIGNvbnN0IHN0cnVjdCBtZW1pbmZvICpiYW5rcyA9 IGJvb3RpbmZvLnN0YXRpY19oZWFwID8NCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAmYm9vdGluZm8ucmVzZXJ2ZWRfbWVtIDogJmJvb3RpbmZvLm1lbTsNCg0KICAgIGZvciAoIGkg PSAwOyBpIDwgYmFua3MtPm5yX2JhbmtzOyBpKysgKQ0KICAgIHsNCiAgICAgICAgY29uc3Qgc3Ry dWN0IG1lbWJhbmsgKmJhbmsgPSAmYmFua3MtPmJhbmtbaV07DQogICAgICAgIHBhZGRyX3QgYmFu a19lbmQgPSBiYW5rLT5zdGFydCArIGJhbmstPnNpemU7DQogICAgICAgIHBhZGRyX3QgcywgZTsN Cg0KICAgICAgICBpZiAoIGJvb3RpbmZvLnN0YXRpY19oZWFwICYmIGJhbmstPnR5cGUgIT0gTUVN QkFOS19TVEFUSUNfSEVBUCApDQogICAgICAgICAgICBjb250aW51ZTsNCg0KICAgICAgICBzID0g YmFuay0+c3RhcnQ7DQogICAgICAgIHdoaWxlICggcyA8IGJhbmtfZW5kICkNCiAgICAgICAgew0K ICAgICAgICAgICAgcGFkZHJfdCBuID0gYmFua19lbmQ7DQoNCiAgICAgICAgICAgIGlmICggYm9v dGluZm8uc3RhdGljX2hlYXAgKQ0KICAgICAgICAgICAgICAgIGUgPSBiYW5rX2VuZDsNCiAgICAg ICAgICAgIGVsc2UNCiAgICAgICAgICAgIHsNCiAgICAgICAgICAgICAgICBlID0gbmV4dF9tb2R1 bGUocywgJm4pOw0KDQogICAgICAgICAgICAgICAgaWYgKCBlID09IH4ocGFkZHJfdCkwICkNCiAg ICAgICAgICAgICAgICAgICAgZSA9IG4gPSBiYW5rX2VuZDsNCg0KICAgICAgICAgICAgICAgIC8q DQogICAgICAgICAgICAgICAgICogTW9kdWxlIGluIGEgUkFNIGJhbmsgb3RoZXIgdGhhbiB0aGUg b25lIHdoaWNoIHdlIGFyZQ0KICAgICAgICAgICAgICAgICAqIG5vdCBkZWFsaW5nIHdpdGggaGVy ZS4NCiAgICAgICAgICAgICAgICAgKi8NCiAgICAgICAgICAgICAgICBpZiAoIGUgPiBiYW5rX2Vu ZCApDQogICAgICAgICAgICAgICAgICAgIGUgPSBiYW5rX2VuZDsNCiAgICAgICAgICAgIH0NCg0K I2lmZGVmIENPTkZJR19BUk1fMzINCiAgICAgICAgICAgIC8qIEF2b2lkIHRoZSB4ZW5oZWFwICov DQogICAgICAgICAgICBpZiAoIHMgPCBtZm5fdG9fbWFkZHIoZGlyZWN0bWFwX21mbl9lbmQpICYm DQogICAgICAgICAgICAgICAgIG1mbl90b19tYWRkcihkaXJlY3RtYXBfbWZuX3N0YXJ0KSA8IGUg KQ0KICAgICAgICAgICAgew0KICAgICAgICAgICAgICAgIGUgPSBtZm5fdG9fbWFkZHIoZGlyZWN0 bWFwX21mbl9zdGFydCk7DQogICAgICAgICAgICAgICAgbiA9IG1mbl90b19tYWRkcihkaXJlY3Rt YXBfbWZuX2VuZCk7DQogICAgICAgICAgICB9DQojZW5kaWYNCg0KICAgICAgICAgICAgaWYgKCBi b290aW5mby5zdGF0aWNfaGVhcCApDQogICAgICAgICAgICAgICAgaW5pdF9ib290X3BhZ2VzKHMs IGUpOw0KICAgICAgICAgICAgZWxzZQ0KICAgICAgICAgICAgICAgIGZ3X3VucmVzZXJ2ZWRfcmVn aW9ucyhzLCBlLCBpbml0X2Jvb3RfcGFnZXMsIDApOw0KDQogICAgICAgICAgICBzID0gbjsNCiAg ICAgICAgfQ0KICAgIH0NCn0NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJz LA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 06 11:12:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 11:12:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399797.641117 (Exim 4.92) (envelope-from ) id 1oVWVT-0000S8-DL; Tue, 06 Sep 2022 11:12:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399797.641117; Tue, 06 Sep 2022 11:12:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVWVT-0000S1-Ae; Tue, 06 Sep 2022 11:12:39 +0000 Received: by outflank-mailman (input) for mailman id 399797; Tue, 06 Sep 2022 11:12:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVWVS-0000Rt-2W for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 11:12:38 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cee82a46-2dd4-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 13:12:36 +0200 (CEST) Received: from BN0PR04CA0141.namprd04.prod.outlook.com (2603:10b6:408:ed::26) by BL0PR12MB5505.namprd12.prod.outlook.com (2603:10b6:208:1ce::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 11:12:32 +0000 Received: from BN8NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ed:cafe::e5) by BN0PR04CA0141.outlook.office365.com (2603:10b6:408:ed::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 11:12:32 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT097.mail.protection.outlook.com (10.13.176.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 11:12:31 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 06:12:31 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 06:12:31 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 6 Sep 2022 06:12:30 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cee82a46-2dd4-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MP8dAIYHMz1qG40QR/9itPE8lWxRrza29OrXX7xUZiiydtx4tizVlUs55LqolcK2B2Y6rKx+38o8mAHjFCK4MN5gHwwUIt4wLZ7QCrTPZsCurFtJegbjJ3HXXB4UyadrLs3aZjTv/3ypxS+XqFhhI+RpJnfMkTUec2nyjCI6c+w2Foq4qPZQam42hNL9KFZpy/HRT4LTBN+ucGvx1QYz6GLoTsoBUMZvVmPPa1cBVl/l9Hl77ULu5yktH+SEjm9gmzfbaKgdEpQjyPwK50UqsBk+jk9kEs/IWnn8HcQ6gXgbQYWdI5hr+ntGFUpBASQcaUQB9I1MYer1WL8cIRdrWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tYKTdce6Ew412qpvPFGnseQ1fl2n0OwYuljDeeAumP8=; b=b8d/vhOC8J28+Iuvlz9UbBScp7AhwFvbLvpQ4nv/TVnfmbuys0IK+Z1b51qqiOtXvb8CsP5Mgww6A6PjbbCS/alBoDwUbb4OU4gR7VH0+iqg7yGd4nzhwP5egHJmHb+4UbVK8+Mfq86NXA8OOQQxZSNq1z+3AiGH6SO/GrRN/5eVbGnhTAg6d1AZMkJNjUPN2VfNwcCVruID+bfxmWCv35jiDT9YUVLREYUesiM9zfxMz8GHByRhNx894Vk0WEnCbdSaFkmJco55sAu8g2VS8J73sQUiKduJXcbTLb9xqviqreCt59QRz+81s+9LnVxLcTVYlVwCISg7IPfAJm+j6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYKTdce6Ew412qpvPFGnseQ1fl2n0OwYuljDeeAumP8=; b=xedWu0lAuRoAPxKb0yM6290CZvaNOObBQ0NKBprUfF6FC9i/sZHxJ2CaMymIWYJ+b/0tekk9YeV1MYfs7Ecp+AIxGvx3zpbsVObBDoCIPqp4huU6VS/IwzQLgvN685zqSvSAmDnHrD+diM5b1n+Lho0N+EaS2DJlLLu8T7yBBWI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder] Add support for Xen boot-time cpupools Date: Tue, 6 Sep 2022 13:12:14 +0200 Message-ID: <20220906111214.26912-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b132ea86-d376-4cf4-844d-08da8ff8b180 X-MS-TrafficTypeDiagnostic: BL0PR12MB5505:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +2M1Cw+hBvXo9Rl+t9CMyvawXxf7cUsHsfBo/tYR6JUq4T8bSF7dVqnGDSiHBzBSMjmewOrTp4m5JXUGmiDOV86jDekJNj1ravzNm5kgNWbUT2B5OqR6KfJxffO0VEgQeGYSFAiK6gfqALFu3eND/70rrOGS8w3NB0bCY2ygjRyzZAs3I8hVoMtkf6lqOVGjGSMUqL9aWMJtVZfrfWLNeOByay3MtpbAY5vO+wOqFCi9dslpWFht2P3ZsNUthpE4ZzRqyYMykEBrus0oGC2UOlaYxVolUvMQakcjnGJ1skrJNLYLut5Uv7mZVjbao8Iw1+Lz0oUFnUQsmKXl/f6sBa9lxL5rnzMaH4CUbpiC0OGsxOsmHMTilkVEjOa1/qjQcxw1c/fIZ2rwhVqVd3sB/C1QqpGultIa2g4uBxStzOMaYJvrYjAnRyL/L5GvSFlW8nRUBKyeeEU0UJXAiCQA+G0rqWHEXDMzCootKlJs4Pq26u22t8j2CaoapVtBoB1tnazLX9/e5Kyyb9RJdXAbZpDtYqEDk51kOJfAEK2qZilFcXpC+FX1xDmwl2LVEOcgr8ZeC2Dw8kN0tvIov83VW/8PsFxWmhnJQ+WCAuhaOX2Uac3vB3yvV6C1BFRV/Bc625XRYsJZUIN2LnTd/PSdBA2449JtSo4D8NEjlYhyn5IT8UQRhiZ+UIKKfLZrSg1jeuCzfJbK+Cl10tXDnWukUwbzqxC3K2OQ8qjd9mrn007PeEJhd2I1lv9XnjJ/OUqyc6/BCCpp0rsYxW7bikA+VHqyeHxqaFB1+Re+i/zVUwo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(376002)(346002)(40470700004)(46966006)(36840700001)(316002)(36860700001)(356005)(81166007)(83380400001)(1076003)(6916009)(2616005)(2906002)(70586007)(82740400003)(8676002)(82310400005)(70206006)(54906003)(4326008)(26005)(5660300002)(426003)(44832011)(40480700001)(47076005)(86362001)(40460700003)(186003)(478600001)(8936002)(41300700001)(6666004)(336012)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 11:12:31.8372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b132ea86-d376-4cf4-844d-08da8ff8b180 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5505 Introduce support for creating boot-time cpupools in the device tree and assigning them to dom0less domUs. Add the following options: - CPUPOOL[number]="cpu1_path,...,cpuN_path scheduler" to specify the list of cpus and the scheduler to be used to create cpupool - NUM_CPUPOOLS to specify the number of cpupools to create - DOMU_CPUPOOL[number]="" to specify the id of the cpupool to assign to domU Example usage: CPUPOOL[0]="/cpus/cpu@1,/cpus/cpu@2 null" DOMU_CPUPOOL[0]=0 NUM_CPUPOOLS=1 The above example will create a boot-time cpupool (id=0) with 2 cpus: cpu@1, cpu@2 and the null scheduler. It will assign the cpupool with id=0 to domU0. Signed-off-by: Michal Orzel --- README.md | 10 +++++ scripts/uboot-script-gen | 80 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+) diff --git a/README.md b/README.md index bd9dac924b44..44abb2193142 100644 --- a/README.md +++ b/README.md @@ -181,6 +181,9 @@ Where: present. If set to 1, the VM can use PV drivers. Older Linux kernels might break. +- DOMU_CPUPOOL[number] specifies the id of the cpupool (created using + CPUPOOL[number] option, where number == id) that will be assigned to domU. + - LINUX is optional but specifies the Linux kernel for when Xen is NOT used. To enable this set any LINUX\_\* variables and do NOT set the XEN variable. @@ -223,6 +226,13 @@ Where: include the public key in. This can only be used with FIT_ENC_KEY_DIR. See the -u option below for more information. +- CPUPOOL[number]="cpu1_path,...,cpuN_path scheduler" + specifies the list of cpus (separated by commas) and the scheduler to be + used to create boot-time cpupool. If no scheduler is set, the Xen default + one will be used. + +- NUM_CPUPOOLS specifies the number of boot-time cpupools to create. + Then you can invoke uboot-script-gen as follows: ``` diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 18c0ce10afb4..2e1c80a92ce1 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -176,6 +176,81 @@ function add_device_tree_static_mem() dt_set "$path" "xen,static-mem" "hex" "${cells[*]}" } +function add_device_tree_cpupools() +{ + local num=$1 + local phandle_next="0xfffffff" + local cpus + local scheduler + local cpu_list + local phandle + local cpu_phandles + local i + local j + + i=0 + while test $i -lt $num + do + cpus=$(echo ${CPUPOOL[$i]} | awk '{print $1}') + scheduler=$(echo ${CPUPOOL[$i]} | awk '{print $NF}') + cpu_phandles= + + for cpu in ${cpus//,/ } + do + # check if cpu exists + if ! fdtget "${DEVICE_TREE}" "$cpu" "reg" &> /dev/null + then + echo "$cpu does not exist" + cleanup_and_return_err + fi + + # check if cpu is already assigned + if [[ "$cpu_list" == *"$cpu"* ]] + then + echo "$cpu already assigned to another cpupool" + cleanup_and_return_err + fi + + # set phandle for a cpu if there is none + if ! phandle=$(fdtget -t x "${DEVICE_TREE}" "$cpu" "phandle" 2> /dev/null) + then + phandle=$(printf "0x%x" $phandle_next) + phandle_next=$(( $phandle_next -1 )) + fi + + dt_set "$cpu" "phandle" "hex" "$phandle" + cpu_phandles="$cpu_phandles $phandle" + cpu_list="$cpu_list $cpu" + done + + # create cpupool node + phandle="$(printf "0x%x" $phandle_next)" + phandle_next=$(( $phandle_next -1 )) + dt_mknode "/chosen" "cpupool_$i" + dt_set "/chosen/cpupool_$i" "phandle" "hex" "$phandle" + dt_set "/chosen/cpupool_$i" "compatible" "str" "xen,cpupool" + dt_set "/chosen/cpupool_$i" "cpupool-cpus" "hex" "$cpu_phandles" + + if test "$scheduler" != "$cpus" + then + dt_set "/chosen/cpupool_$i" "cpupool-sched" "str" "$scheduler" + fi + + j=0 + while test $j -lt $NUM_DOMUS + do + # assign cpupool to domU + if test "${DOMU_CPUPOOL[$j]}" -eq "$i" + then + dt_set "/chosen/domU$j" "domain-cpupool" "hex" "$phandle" + fi + j=$(( $j + 1 )) + done + + i=$(( $i + 1 )) + done +} + function xen_device_tree_editing() { dt_set "/chosen" "#address-cells" "hex" "0x2" @@ -252,6 +327,11 @@ function xen_device_tree_editing() fi i=$(( $i + 1 )) done + + if test "$NUM_CPUPOOLS" && test "$NUM_CPUPOOLS" -gt 0 + then + add_device_tree_cpupools "$NUM_CPUPOOLS" + fi } function linux_device_tree_editing() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 11:47:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 11:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399802.641129 (Exim 4.92) (envelope-from ) id 1oVX2j-00041y-2K; Tue, 06 Sep 2022 11:47:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399802.641129; Tue, 06 Sep 2022 11:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVX2i-00041r-V1; Tue, 06 Sep 2022 11:47:00 +0000 Received: by outflank-mailman (input) for mailman id 399802; Tue, 06 Sep 2022 11:46:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVX2h-00041l-1f for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 11:46:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ba7a866-2dd9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 13:46:56 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B7B731F9DD; Tue, 6 Sep 2022 11:46:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 81DBB13A19; Tue, 6 Sep 2022 11:46:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id utBEHi8zF2MMLwAAMHmgww (envelope-from ); Tue, 06 Sep 2022 11:46:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ba7a866-2dd9-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662464815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rN62jLmJ07MrMIhtStpliV2D6UW+1D57JC08PYUNhdE=; b=Zks14FmQwVkNldjSfax/XKNm52r1dY96x0nHSPtJN8rcO9BinTgmxytNjc3gpeubm6p5It 78SgSmKBvo1SoxFI4qkaJZgZd0vdQKQnYmio786zxSjWjqu09XtVr9FGBI/O4DbxQA6PWn gI3qb30dvKQPHcUk3+8ptNixR7l/hz8= Message-ID: <919e328a-000e-0eeb-2253-6a4381b5ccaa@suse.com> Date: Tue, 6 Sep 2022 13:46:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Content-Language: en-US From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Dario Faggioli , Jan Beulich , Andrew Cooper , xen-devel References: <20200318221006.GS18599@mail-itl> <413cac496e18bcb04b0691ef633d206f3a14a8e3.camel@suse.com> <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl> <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> In-Reply-To: <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------nTBoxknjWjMhZn0Ls0BRkcLF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------nTBoxknjWjMhZn0Ls0BRkcLF Content-Type: multipart/mixed; boundary="------------0u7K0VDFQLykH0CsodesKjad"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Dario Faggioli , Jan Beulich , Andrew Cooper , xen-devel Message-ID: <919e328a-000e-0eeb-2253-6a4381b5ccaa@suse.com> Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer References: <20200318221006.GS18599@mail-itl> <413cac496e18bcb04b0691ef633d206f3a14a8e3.camel@suse.com> <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl> <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> In-Reply-To: <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> --------------0u7K0VDFQLykH0CsodesKjad Content-Type: multipart/mixed; boundary="------------u7wOl2ekWlGjgGimmsvjROCX" --------------u7wOl2ekWlGjgGimmsvjROCX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjIuMDguMjIgMTc6MzQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDIxLjA4LjIy IDE4OjE0LCBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+PiBPbiBTYXQs IE9jdCAwOSwgMjAyMSBhdCAwNjoyODoxN1BNICswMjAwLCBNYXJlayBNYXJjenlrb3dza2kt R8OzcmVja2kgd3JvdGU6DQo+Pj4gT24gU3VuLCBKYW4gMzEsIDIwMjEgYXQgMDM6MTU6MzBB TSArMDEwMCwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0KPj4+PiBPbiBU dWUsIFNlcCAyOSwgMjAyMCBhdCAwNToyNzo0OFBNICswMjAwLCBKw7xyZ2VuIEdyb8OfIHdy b3RlOg0KPj4+Pj4gT24gMjkuMDkuMjAgMTc6MTYsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7Ny ZWNraSB3cm90ZToNCj4+Pj4+PiBPbiBUdWUsIFNlcCAyOSwgMjAyMCBhdCAwNTowNzoxMVBN ICswMjAwLCBKw7xyZ2VuIEdyb8OfIHdyb3RlOg0KPj4+Pj4+PiBPbiAyOS4wOS4yMCAxNjoy NywgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0KPj4+Pj4+Pj4gT24gTW9u LCBNYXIgMjMsIDIwMjAgYXQgMDE6MDk6NDlBTSArMDEwMCwgTWFyZWsgTWFyY3p5a293c2tp LUfDs3JlY2tpIHdyb3RlOg0KPj4+Pj4+Pj4+IE9uIFRodSwgTWFyIDE5LCAyMDIwIGF0IDAx OjI4OjEwQU0gKzAxMDAsIERhcmlvIEZhZ2dpb2xpIHdyb3RlOg0KPj4+Pj4+Pj4+PiBbQWRk aW5nIEp1ZXJnZW5dDQo+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+IE9uIFdlZCwgMjAyMC0wMy0x OCBhdCAyMzoxMCArMDEwMCwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K Pj4+Pj4+Pj4+Pj4gT24gV2VkLCBNYXIgMTgsIDIwMjAgYXQgMDI6NTA6NTJQTSArMDAwMCwg QW5kcmV3IENvb3BlciB3cm90ZToNCj4+Pj4+Pj4+Pj4+PiBPbiAxOC8wMy8yMDIwIDE0OjE2 LCBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+Pj4+Pj4+Pj4+Pj4+IEhp LA0KPj4+Pj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+Pj4+PiBJbiBteSB0ZXN0IHNldHVwIChpbnNp ZGUgS1ZNIHdpdGggbmVzdGVkIHZpcnQgZW5hYmxlZCksIEkgcmF0aGVyDQo+Pj4+Pj4+Pj4+ Pj4+IGZyZXF1ZW50bHkgZ2V0IFhlbiBjcmFzaCBvbiByZXN1bWUgZnJvbSBTMy4gRnVsbCBt ZXNzYWdlIGJlbG93Lg0KPj4+Pj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+Pj4+PiBUaGlzIGlzIFhl biA0LjEzLjAsIHdpdGggc29tZSBwYXRjaGVzLCBpbmNsdWRpbmcgInNjaGVkOiBmaXgNCj4+ Pj4+Pj4+Pj4+Pj4gcmVzdW1pbmcNCj4+Pj4+Pj4+Pj4+Pj4gZnJvbSBTMyB3aXRoIHNtdD0w Ii4NCj4+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4+Pj4gQ29udHJhcnkgdG8gdGhlIHByZXZp b3VzIGlzc3VlLCB0aGlzIG9uZSBkb2VzIG5vdCBoYXBwZW4gYWx3YXlzIC0NCj4+Pj4+Pj4+ Pj4+Pj4gSQ0KPj4+Pj4+Pj4+Pj4+PiB3b3VsZCBzYXkgaW4gYWJvdXQgNDAlIGNhc2VzIG9u IHRoaXMgc2V0dXAsIGJ1dCB2ZXJ5IHJhcmVseSBvbg0KPj4+Pj4+Pj4+Pj4+PiBwaHlzaWNh bA0KPj4+Pj4+Pj4+Pj4+PiBzZXR1cC4NCj4+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4+Pj4g VGhpcyBpcyBfd2l0aG91dF8gY29yZSBzY2hlZHVsaW5nIGVuYWJsZWQsIGFuZCBhbHNvIHdp dGggc210PW9mZi4NCj4+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4+Pj4gRG8geW91IHRoaW5r IGl0IHdvdWxkIGJlIGFueSBkaWZmZXJlbnQgb24geGVuLXVuc3RhYmxlPyBJIGNhdA0KPj4+ Pj4+Pj4+Pj4+PiB0cnksIGJ1dA0KPj4+Pj4+Pj4+Pj4+PiBpdCBpc24ndCB0cml2aWFsIGlu IHRoaXMgc2V0dXAsIHNvIEknZCBhc2sgZmlyc3QuDQo+Pj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+ Pj4+IFdlbGwsIEp1ZXJnZW4gaGFzIGZpeGVkIHF1aXRlIGEgZmV3IGlzc3Vlcy4NCj4+Pj4+ Pj4+Pj4NCj4+Pj4+Pj4+Pj4gTW9zdCBvZiB0aGVtIHdoZXJlIHRyaWdnZXJpbmcgd2l0aCBj b3JlLXNjaGVkdWxpbmcgZW5hYmxlZCwgYW5kIEkgZG9uJ3QNCj4+Pj4+Pj4+Pj4gcmVjYWxs IGFueSBvZiB0aGVtIHdoaWNoIGxvb2tlZCBzaW1pbGFyIG9yIHJlbGF0ZWQgdG8gdGhpcy4N Cj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4gU3RpbGwsIGl0J3MgcG9zc2libGUgdGhhdCB0aGUg c2FtZSBpc3N1ZSBjYXVzZXMgZGlmZmVyZW50IHN5bXB0b21zLCBhbmQNCj4+Pj4+Pj4+Pj4g aGVuY2UgdGhhdCBtYXliZSBvbmUgb2YgdGhlIHBhdGNoZXMgd291bGQgZml4IHRoaXMgdG9v Lg0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4gSSd2ZSB0ZXN0ZWQgb24gbWFzdGVyIChkMDk0ZTk1 ZmI3YyksIGFuZCByZXByb2R1Y2VkIGV4YWN0bHkgdGhlIHNhbWUgY3Jhc2gNCj4+Pj4+Pj4+ PiAocGFzdGVkIGJlbG93IGZvciB0aGUgY29tcGxldGVuZXNzKS4NCj4+Pj4+Pj4+PiBCdXQg dGhlcmUgaXMgbW9yZTogYWRkaXRpb25hbGx5LCBpbiBtb3N0IChhbGw/KSBjYXNlcyBhZnRl ciByZXN1bWUgSSd2ZSANCj4+Pj4+Pj4+PiBnb3QNCj4+Pj4+Pj4+PiBzb2Z0IGxvY2t1cCBp biBMaW51eCBkb20wIGluIHNtcF9jYWxsX2Z1bmN0aW9uX3NpbmdsZSgpIC0gc2VlIGJlbG93 LiBJdA0KPj4+Pj4+Pj4+IGRpZG4ndCBoYXBwZW5lZCBiZWZvcmUgYW5kIHRoZSBvbmx5IGNo YW5nZSB3YXMgWGVuIDQuMTMgLT4gbWFzdGVyLg0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4gWGVu IGNyYXNoOg0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4gKFhFTikgQXNzZXJ0aW9uICdjMnJxZChz Y2hlZF91bml0X21hc3Rlcih1bml0KSkgPT0gc3ZjLT5ycWQnIGZhaWxlZCBhdCANCj4+Pj4+ Pj4+PiBjcmVkaXQyLmM6MjEzMw0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+IEp1ZXJnZW4sIGFueSBp ZGVhIGFib3V0IHRoaXMgb25lPyBUaGlzIGlzIGFsc28gaGFwcGVuaW5nIG9uIHRoZSBjdXJy ZW50DQo+Pj4+Pj4+PiBzdGFibGUtNC4xNCAoMjg4NTVlYmNkYmZhKS4NCj4+Pj4+Pj4+DQo+ Pj4+Pj4+DQo+Pj4+Pj4+IE9oLCBzb3JyeSBJIGRpZG4ndCBjb21lIGJhY2sgdG8gdGhpcyBp c3N1ZS4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gSSBzdXNwZWN0IHRoaXMgaXMgcmVsYXRlZCB0byBz dG9wX21hY2hpbmVfcnVuKCkgYmVpbmcgY2FsbGVkIGR1cmluZw0KPj4+Pj4+PiBzdXNwZW5k KCksIGFzIEknbSBzZWVpbmcgdmVyeSBzcG9yYWRpYyBpc3N1ZXMgd2hlbiBvZmZsaW5pbmcg YW5kIHRoZW4NCj4+Pj4+Pj4gb25saW5pbmcgY3B1cyB3aXRoIGNvcmUgc2NoZWR1bGluZyBi ZWluZyBhY3RpdmUgKGl0IHNlZW1zIGFzIGlmIHRoZQ0KPj4+Pj4+PiBkb20wIHZjcHUgZG9p bmcgdGhlIGNwdSBvbmxpbmUgYWN0aXZpdHkgc29tZXRpbWVzIGlzIHVzaW5nIGFuIG9sZA0K Pj4+Pj4+PiB2Y3B1IHN0YXRlKS4NCj4+Pj4+Pg0KPj4+Pj4+IE5vdGUgdGhpcyBpcyBkZWZh dWx0IFhlbiA0LjE0IHN0YXJ0LCBzbyBjb3JlIHNjaGVkdWxpbmcgaXMgX25vdF8gYWN0aXZl Og0KPj4+Pj4NCj4+Pj4+IFRoZSBzaW1pbGFyaXR5IGluIHRoZSB0d28gZmFpbHVyZSBjYXNl cyBpcyB0aGF0IG11bHRpcGxlIGNwdXMgYXJlDQo+Pj4+PiBhZmZlY3RlZCBieSB0aGUgb3Bl cmF0aW9ucyBkdXJpbmcgc3RvcF9tYWNoaW5lX3J1bigpLg0KPj4+Pj4NCj4+Pj4+Pg0KPj4+ Pj4+IMKgwqDCoMKgwqAgKFhFTikgQnJvdWdodCB1cCAyIENQVXMNCj4+Pj4+PiDCoMKgwqDC oMKgIChYRU4pIFNjaGVkdWxpbmcgZ3JhbnVsYXJpdHk6IGNwdSwgMSBDUFUgcGVyIHNjaGVk LXJlc291cmNlDQo+Pj4+Pj4gwqDCoMKgwqDCoCAoWEVOKSBBZGRpbmcgY3B1IDAgdG8gcnVu cXVldWUgMA0KPj4+Pj4+IMKgwqDCoMKgwqAgKFhFTinCoCBGaXJzdCBjcHUgb24gcnVucXVl dWUsIGFjdGl2YXRpbmcNCj4+Pj4+PiDCoMKgwqDCoMKgIChYRU4pIEFkZGluZyBjcHUgMSB0 byBydW5xdWV1ZSAxDQo+Pj4+Pj4gwqDCoMKgwqDCoCAoWEVOKcKgIEZpcnN0IGNwdSBvbiBy dW5xdWV1ZSwgYWN0aXZhdGluZw0KPj4+Pj4+DQo+Pj4+Pj4+IEkgd2Fzbid0IGFibGUgdG8g Y2F0Y2ggdGhlIHJlYWwgcHJvYmxlbSBkZXNwaXRlIG9mIGhhdmluZyB0cmllZCBsb3RzDQo+ Pj4+Pj4+IG9mIGFwcHJvYWNoZXMgdXNpbmcgZGVidWcgcGF0Y2hlcy4NCj4+Pj4+Pj4NCj4+ Pj4+Pj4gUmVjZW50bHkgSSBzdXNwZWN0ZWQgdGhlIHdob2xlIHByb2JsZW0gY291bGQgYmUg c29tZWhvdyByZWxhdGVkIHRvDQo+Pj4+Pj4+IFJDVSBoYW5kbGluZywgYXMgc3RvcF9tYWNo aW5lX3J1bigpIGlzIHJlbHlpbmcgb24gdGFza2xldHMgd2hpY2ggYXJlDQo+Pj4+Pj4+IGV4 ZWN1dGluZyBpbiBpZGxlIGNvbnRleHQsIGFuZCBSQ1UgaGFuZGxpbmcgaXMgZG9uZSBpbiBp ZGxlIGNvbnRleHQsDQo+Pj4+Pj4+IHRvby4gU28gdGhlcmUgbWlnaHQgYmUgc29tZSBraW5k IG9mIHVzZSBhZnRlciBmcmVlIHNjZW5hcmlvIGluIGNhc2UNCj4+Pj4+Pj4gc29tZSBtZW1v cnkgaXMgZnJlZWQgdmlhIFJDVSBkZXNwaXRlIGl0IHN0aWxsIGJlaW5nIHVzZWQgYnkgYSB0 YXNrbGV0Lg0KPj4+Pj4+DQo+Pj4+Pj4gVGhhdCBzb3VuZHMgcGxhdXNpYmxlLCBldmVuIHRo b3VnaCBJIGRvbid0IHJlYWxseSBrbm93IHRoaXMgYXJlYSBvZiBYZW4uDQo+Pj4+Pj4NCj4+ Pj4+Pj4gSSAianVzdCIgbmVlZCB0byBmaW5kIHNvbWUgdGltZSB0byB2ZXJpZnkgdGhpcyBz dXNwaWNpb24uIEFueSBoZWxwIGRvaW5nDQo+Pj4+Pj4+IHRoaXMgd291bGQgYmUgYXBwcmVj aWF0ZWQuIDotKQ0KPj4+Pj4+DQo+Pj4+Pj4gSSBkbyBoYXZlIGEgc2V0dXAgd2hlcmUgSSBj YW4gZWFzaWx5LWlzaCByZXByb2R1Y2UgdGhlIGlzc3VlLiBJZiB0aGVyZQ0KPj4+Pj4+IGlz IHNvbWUgZGVidWcgcGF0Y2ggeW91J2QgbGlrZSBtZSB0byB0cnksIEkgY2FuIGRvIHRoYXQu DQo+Pj4+Pg0KPj4+Pj4gVGhhbmtzLiBJIG1pZ2h0IGNvbWUgYmFjayB0byB0aGF0IG9mZmVy IGFzIHlvdSBhcmUgc2VlaW5nIGEgY3Jhc2ggd2hpY2gNCj4+Pj4+IHdpbGwgYmUgbXVjaCBl YXNpZXIgdG8gYW5hbHl6ZS4gQ2F0Y2hpbmcgbXkgZXJyb3IgY2FzZSBpcyBtdWNoIGhhcmRl ciBhcw0KPj4+Pj4gaXQgc3VyZmFjZXMgc29tZSB0aW1lIGFmdGVyIHRoZSByZWFsIHByb2Js ZW0gaW4gYSBub24gZGVzdHJ1Y3RpdmUgd2F5DQo+Pj4+PiAodXN1YWxseSBJJ20gc2VlaW5n IGEgZmFpbHVyZSB0byBsb2FkIGEgbGlicmFyeSBpbiB0aGUgcHJvZ3JhbSB3aGljaA0KPj4+ Pj4ganVzdCBkaWQgaXRzIGpvYiB2aWEgZXhhY3RseSB0aGUgbGlicmFyeSBjbGFpbWluZyBu b3QgYmVpbmcgbG9hZGFibGUpLg0KPj4+Pg0KPj4+PiBIaSwNCj4+Pj4NCj4+Pj4gSSdtIHJl c3VycmVjdGluZyB0aGlzIHRocmVhZCBhcyBpdCB3YXMgcmVjZW50bHkgbWVudGlvbmVkIGVs c2V3aGVyZS4gSQ0KPj4+PiBjYW4gc3RpbGwgcmVwcm9kdWNlIHRoZSBpc3N1ZSBvbiB0aGUg cmVjZW50IHN0YWdpbmcgYnJhbmNoICg5ZGM2ODdmMTU1KS4NCj4+Pj4NCj4+Pj4gSXQgZmFp bHMgYWZ0ZXIgdGhlIGZpcnN0IHJlc3VtZSAobm90IGFsd2F5cywgYnV0IGZyZXF1ZW50IGVu b3VnaCB0bw0KPj4+PiBkZWJ1ZyBpdCkuIEF0IGxlYXN0IG9uZSBndWVzdCBuZWVkcyB0byBi ZSBydW5uaW5nIC0gd2l0aCBqdXN0IChQVikgZG9tMA0KPj4+PiB0aGUgY3Jhc2ggZG9lc24n dCBoYXBwZW4gKGF0IGxlYXN0IGZvciB0aGUgfjggdGltZXMgaW4gYSByb3cgSSB0cmllZCku DQo+Pj4+IElmIHRoZSBmaXJzdCByZXN1bWUgd29ya3MsIHRoZSBzZWNvbmQgKGFsbW9zdD8p IGFsd2F5cyB3aWxsIGZhaWwgYnV0DQo+Pj4+IHdpdGggYSBkaWZmZXJlbnQgc3ltcHRvbXMg LSBkb20wIGtlcm5lbCBsb2NrdXBzIChhdCBsZWFzdCBzb21lIG9mIGl0cw0KPj4+PiB2Y3B1 cykuIEkgaGF2ZW4ndCBkZWJ1Z2dlZCB0aGlzIG9uZSB5ZXQgYXQgYWxsLg0KPj4+Pg0KPj4+ PiBBbnkgaGVscCB3aWxsIGJlIGFwcHJlY2lhdGVkLCBJIGNhbiBhcHBseSBzb21lIGRlYnVn IHBhdGNoZXMsIGNoYW5nZQ0KPj4+PiBjb25maWd1cmF0aW9uIGV0Yy4NCj4+Pg0KPj4+IFRo aXMgc3RpbGwgaGFwcGVucyBvbiA0LjE0LjMuIE1heWJlIGl0IGlzIHJlbGF0ZWQgdG8gZnJl ZWluZyBwZXJjcHUNCj4+PiBhcmVhcywgYXMgaXQgY2F1c2VkIG90aGVyIGlzc3VlcyB3aXRo IHN1c3BlbmQgdG9vPyBKdXN0IGEgdGhvdWdodC4uLg0KPj4NCj4+IEkgaGF2ZSByZXByb2R1 Y2VkIHRoaXMgb24gY3VycmVudCBzdGFnaW5nKCopLiBBbmQgSSBjYW4gcmVwcm9kdWNlIGl0 DQo+PiByZWxpYWJseS4gQW5kIGFsc28sIEkgZ290IChJIGJlbGlldmUpIGNsb3NlbHkgcmVs YXRlZCBjcmFzaCB3aXRoIGNyZWRpdDENCj4+IHNjaGVkdWxlci4NCj4+DQo+PiAoKikgSXQg aXNuJ3QgcGxhaW4gc3RhZ2luZywgaXQncyBvbmUgd2l0aCBteSB4aGNpIGNvbnNvbGUgcGF0 Y2hlcyBvbg0KPj4gdG9wLCBpbmNsdWRpbmcgYXR0ZW1wdCB0byBtYWtlIGl0IHN1cnZpdmUg UzMuIEkgYmVsaWV2ZSB0aGUgb25seQ0KPj4gcmVsZXZhbnQgcGFydCB0aGVyZSBpcyBzdGlj a2luZyBzZXRfdGltZXIoKSBpbnRvIGNvbnNvbGUgcmVzdW1lIHBhdGggKG9yDQo+PiBqdXN0 IGhhdmluZyBhIHRpbWVyIHdpdGggcmF0aGVyIHNob3J0IGRlbGF5IHJlZ2lzdGVyZWQpLiBU aGUgYWN0dWFsIHRyZWUNCj4+IGF0IGh0dHBzOi8vZ2l0aHViLmNvbS9tYXJtYXJlay94ZW4v dHJlZS9tYXN0ZXIteHVlMi1kZWJ1ZywgaW5jbHVkaW5nDQo+PiBxdWl0ZSBhIGxvdCBvZiBk ZWJ1ZyBwcmludHMgYW5kIGRlYnVnIGhhY2tzLg0KPj4NCj4+IFNwZWNpZmljIGNyYXNoIHdp dGggY3JlZGl0MjoNCj4+DQo+PiDCoMKgwqDCoCAoWEVOKSBBc3NlcnRpb24gJ3NjaGVkX3Vu aXRfbWFzdGVyKGN1cnJ1bml0KSA9PSBjcHUnIGZhaWxlZCBhdCANCj4+IGNvbW1vbi9zY2hl ZC9jcmVkaXQuYzo5MjgNCj4+IMKgwqDCoMKgIChYRU4pIC0tLS1bIFhlbi00LjE3LXVuc3Rh YmxlwqAgeDg2XzY0wqAgZGVidWc9ecKgIFRhaW50ZWQ6wqDCoCBDwqDCoMKgIF0tLS0tDQo+ PiDCoMKgwqDCoCAoWEVOKSBDUFU6wqDCoMKgIDANCj4+IMKgwqDCoMKgIChYRU4pIFJJUDrC oMKgwqAgZTAwODpbPGZmZmY4MmQwNDAyNDM0YmY+XSBjcmVkaXQuYyNjc2NoZWRfdGljaysw eDJkNC8weDQ5NA0KPj4gwqDCoMKgwqAgKFhFTikgUkZMQUdTOiAwMDAwMDAwMDAwMDEwMjAy wqDCoCBDT05URVhUOiBoeXBlcnZpc29yIChkMHY0KQ0KPj4gwqDCoMKgwqAgKFhFTikgcmF4 OiBmZmZmODJkMDQwNWM0Mjk4wqDCoCByYng6IDAwMDAwMDAwMDAwMDAwMDLCoMKgIHJjeDog MDAwMDAwMDAwMDAwMDAwMg0KPj4gwqDCoMKgwqAgKFhFTikgcmR4OiBmZmZmODMwMjUxN2Y2 NGQwwqDCoCByc2k6IGZmZmY4MzAyNTE1YzBmYzDCoMKgIHJkaTogMDAwMDAwMDAwMDAwMDAw Mg0KPj4gwqDCoMKgwqAgKFhFTikgcmJwOiBmZmZmODMwMjU2MjI3ZTM4wqDCoCByc3A6IGZm ZmY4MzAyNTYyMjdkZTDCoMKgIHI4OsKgIDAwMDAwMDAwMDAwMDAwMDQNCj4+IMKgwqDCoMKg IChYRU4pIHI5OsKgIGZmZmY4MzAyNTE3YWM4MjDCoMKgIHIxMDogZmZmZjgzMDI1MTc0NTA2 OMKgwqAgcjExOiAwMDAwMDA4OGNiNzM0ODg3DQo+PiDCoMKgwqDCoCAoWEVOKSByMTI6IGZm ZmY4MzAyNTE3NGRlNTDCoMKgIHIxMzogZmZmZjgzMDI1MTVjMGZhMMKgwqAgcjE0OiBmZmZm ODMwMjUxNzRkZjQwDQo+PiDCoMKgwqDCoCAoWEVOKSByMTU6IGZmZmY4MzAyNTE1YzBjYzDC oMKgIGNyMDogMDAwMDAwMDA4MDA1MDAzM8KgwqAgY3I0OiAwMDAwMDAwMDAwMzcyNjYwDQo+ PiDCoMKgwqDCoCAoWEVOKSBjcjM6IDAwMDAwMDAxYmFjYmQwMDDCoMKgIGNyMjogMDAwMDc3 ZTVlYzAyYTMxOA0KPj4gwqDCoMKgwqAgKFhFTikgZnNiOiAwMDAwNzdlNWZlNTMzNzAwwqDC oCBnc2I6IGZmZmY4ODgyNTU3MDAwMDDCoMKgIGdzczogMDAwMDAwMDAwMDAwMDAwMA0KPj4g wqDCoMKgwqAgKFhFTikgZHM6IDAwMDDCoMKgIGVzOiAwMDAwwqDCoCBmczogMDAwMMKgwqAg Z3M6IDAwMDDCoMKgIHNzOiAwMDAwwqDCoCBjczogZTAwOA0KPj4gwqDCoMKgwqAgKFhFTikg WGVuIGNvZGUgYXJvdW5kIDxmZmZmODJkMDQwMjQzNGJmPiAoY3JlZGl0LmMjY3NjaGVkX3Rp Y2srMHgyZDQvMHg0OTQpOg0KPj4gwqDCoMKgwqAgKFhFTinCoCAwMSAwMCAwMCBlOSAyYSAw MSAwMCAwMCA8MGY+IDBiIDBmIDBiIDBmIDBiIDQ4IDhiIDQxIDIwIDBmIGI3IDAwIA0KPj4g ODkgNDUgY2MNCj4+IMKgwqDCoMKgIChYRU4pIFhlbiBzdGFjayB0cmFjZSBmcm9tIHJzcD1m ZmZmODMwMjU2MjI3ZGUwOg0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZjgzMDI1NjIy N2ZmZiAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAyNTYyMjdlMTAgZmZmZjgyZDA0MDM1YmU5 MA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZjgzMDI1NjIyN2VmOCBmZmZmODMwMjUx NzQ1MDAwIGZmZmY4MmQwNDA1YzMyODAgZmZmZjgyZDA0MDI0MzFlYg0KPj4gwqDCoMKgwqAg KFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAwMiAwMDAwMDA4OGM5YmE5NTM0IDAwMDAwMDAw MDAwMDAwMDAgZmZmZjgzMDI1NjIyN2U2MA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZm ZjgyZDA0MDIyZWU1MyBmZmZmODJkMDQwNWMzMjgwIGZmZmY4MzAyOTYzZTEzMjAgZmZmZjgz MDI1MTVjMGZjMA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZjgzMDI1NjIyN2VhMCBm ZmZmODJkMDQwMjJmNzNmIGZmZmY4MzAyNTYyMjdlODAgZmZmZjgyZDA0MDVjOWYwMA0KPj4g wqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZmZmZmZmZmZmZmZmZiBmZmZmODJkMDQwNWM5ZjAw IGZmZmY4MzAyNTYyMjdmZmYgMDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTinC oMKgwqAgZmZmZjgzMDI1NjIyN2VkOCBmZmZmODJkMDQwMjJkMjZjIGZmZmY4MzAyNTE3NDUw MDAgMDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAw MDAwMDAwMCBmZmZmODMwMjU2MjI3ZmZmIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjgzMDI1NjIy N2VlOA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZjgyZDA0MDIyZDJmZiAwMDAwN2Nm ZGE5ZGQ4MGU3IGZmZmY4MmQwNDAyZjAzYzYgZmZmZjg4ODEwYzAwNWMwMA0KPj4gwqDCoMKg wqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAzMSAwMDAwMDAwMDAwMDAwMTAwIDAwMDAw MDAwZmZmZmZlMDAgMDAwMDAwMDAwMDAwMDAzMQ0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAg MDAwMDAwMDAwMDAwMDAzMSBmZmZmZmZmZjgyZDQ1ZDI4IDAwMDAwMDAwMDAwMDBlMmUgMDAw MDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAz MiAwMDAwMDAwMGZmZmZlZjMxIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjg4ODEyMjQ0YTcwMA0K Pj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAwNSBmZmZmODg4MTIyNDRh NzgwIDAwMDAwMGZhMDAwMDAwMDAgZmZmZmZmZmY4MThkYjU1Zg0KPj4gwqDCoMKgwqAgKFhF TinCoMKgwqAgMDAwMDAwMDAwMDAwZTAzMyAwMDAwMDAwMDAwMDAwMjQ2IGZmZmZjOTAwNDA5 YjdjNTAgMDAwMDAwMDAwMDAwZTAyYg0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAw MDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAw MDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMGUwMTAwMDAwMDAwMCBmZmZm ODMwMjUxNzQ1MDAwIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDM3MjY2MA0KPj4gwqDC oMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAwMCA4MDAwMDAwMjU2MjBiMDAyIDAw MGUwMzAzMDAwMDAwMDEgMDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTikgWGVu IGNhbGwgdHJhY2U6DQo+PiDCoMKgwqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAyNDM0 YmY+XSBSIGNyZWRpdC5jI2NzY2hlZF90aWNrKzB4MmQ0LzB4NDk0DQo+PiDCoMKgwqDCoCAo WEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAyMmVlNTM+XSBGIHRpbWVyLmMjZXhlY3V0ZV90aW1l cisweDQ1LzB4NWMNCj4+IMKgwqDCoMKgIChYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDIyZjcz Zj5dIEYgdGltZXIuYyN0aW1lcl9zb2Z0aXJxX2FjdGlvbisweDcxLzB4Mjc4DQo+PiDCoMKg wqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAyMmQyNmM+XSBGIHNvZnRpcnEuYyNfX2Rv X3NvZnRpcnErMHg5NC8weGJlDQo+PiDCoMKgwqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4MmQw NDAyMmQyZmY+XSBGIGRvX3NvZnRpcnErMHgxMy8weDE1DQo+PiDCoMKgwqDCoCAoWEVOKcKg wqDCoCBbPGZmZmY4MmQwNDAyZjAzYzY+XSBGIHg4Nl82NC9lbnRyeS5TI3Byb2Nlc3Nfc29m dGlycXMrMHg2LzB4MjANCj4+IMKgwqDCoMKgIChYRU4pDQo+PiDCoMKgwqDCoCAoWEVOKQ0K Pj4gwqDCoMKgwqAgKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKg0KPj4gwqDCoMKgwqAgKFhFTikgUGFuaWMgb24gQ1BVIDA6DQo+PiDCoMKgwqDCoCAo WEVOKSBBc3NlcnRpb24gJ3NjaGVkX3VuaXRfbWFzdGVyKGN1cnJ1bml0KSA9PSBjcHUnIGZh aWxlZCBhdCANCj4+IGNvbW1vbi9zY2hlZC9jcmVkaXQuYzo5MjgNCj4+IMKgwqDCoMKgIChY RU4pICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioNCj4+DQo+PiBT cGVjaWZpYyBjcmFzaCB3aXRoIGNyZWRpdDE6DQo+Pg0KPj4gwqDCoMKgwqAgKFhFTikgQVNT RVJUIEZBSUwhIGNwdSA0LCBzY2hlZF91bml0X21hc3RlciAwLCBjdXJydW5pdCBpZCA0DQo+ PiDCoMKgwqDCoCAoWEVOKSBBc3NlcnRpb24gJ3NjaGVkX3VuaXRfbWFzdGVyKGN1cnJ1bml0 KSA9PSBjcHUnIGZhaWxlZCBhdCANCj4+IGNvbW1vbi9zY2hlZC9jcmVkaXQuYzo5MzYNCj4+ IMKgwqDCoMKgIChYRU4pIC0tLS1bIFhlbi00LjE3LXVuc3RhYmxlwqAgeDg2XzY0wqAgZGVi dWc9ecKgIFRhaW50ZWQ6wqDCoCBDwqDCoMKgIF0tLS0tDQo+PiDCoMKgwqDCoCAoWEVOKSBD UFU6wqDCoMKgIDANCj4+IMKgwqDCoMKgIChYRU4pIFJJUDrCoMKgwqAgZTAwODpbPGZmZmY4 MmQwNDAyNDM1NWM+XSBjcmVkaXQuYyNjc2NoZWRfdGljaysweDJmNy8weDRiNw0KPj4gwqDC oMKgwqAgKFhFTikgUkZMQUdTOiAwMDAwMDAwMDAwMDEwMjAywqDCoCBDT05URVhUOiBoeXBl cnZpc29yIChkMHY0KQ0KPj4gwqDCoMKgwqAgKFhFTikgcmF4OiBmZmZmODMwMjUxN2Y2NGQw wqDCoCByYng6IDAwMDAwMDAwMDAwMDAwMDTCoMKgIHJjeDogMDAwMDAwMDAwMDAwMDAwMA0K Pj4gwqDCoMKgwqAgKFhFTikgcmR4OiBmZmZmODMwMjU2MjI3ZmZmwqDCoCByc2k6IDAwMDAw MDAwMDAwMDAwMGHCoMKgIHJkaTogZmZmZjgyZDA0MDQ3ODZiOA0KPj4gwqDCoMKgwqAgKFhF TikgcmJwOiBmZmZmODMwMjU2MjI3ZTM4wqDCoCByc3A6IGZmZmY4MzAyNTYyMjdkZTDCoMKg IHI4OsKgIDAwMDAwMDAwMDAwMDAwODcNCj4+IMKgwqDCoMKgIChYRU4pIHI5OsKgIDAwMDAw MDAwMDAwMDAwMDHCoMKgIHIxMDogMDAwMDAwMDAwMDAwMDAwMcKgwqAgcjExOiAwMDAwMDAw MDAwMDAwMDA0DQo+PiDCoMKgwqDCoCAoWEVOKSByMTI6IGZmZmY4MzAyNTE3NGRlNTDCoMKg IHIxMzogZmZmZjgzMDI1MTc3ODEwMMKgwqAgcjE0OiBmZmZmODMwMjUxNzRkZjQwDQo+PiDC oMKgwqDCoCAoWEVOKSByMTU6IGZmZmY4MzAyNTE1YzBjYzDCoMKgIGNyMDogMDAwMDAwMDA4 MDA1MDAzM8KgwqAgY3I0OiAwMDAwMDAwMDAwMzcyNjYwDQo+PiDCoMKgwqDCoCAoWEVOKSBj cjM6IDAwMDAwMDAyNGFjMTAwMDDCoMKgIGNyMjogMDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDC oMKgwqAgKFhFTikgZnNiOiAwMDAwMDAwMDAwMDAwMDAwwqDCoCBnc2I6IGZmZmY4ODgyNTU3 MDAwMDDCoMKgIGdzczogMDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTikgZHM6 IDAwMmLCoMKgIGVzOiAwMDJiwqDCoCBmczogMDAwMMKgwqAgZ3M6IDAwMDDCoMKgIHNzOiAw MDAwwqDCoCBjczogZTAwOA0KPj4gwqDCoMKgwqAgKFhFTikgWGVuIGNvZGUgYXJvdW5kIDxm ZmZmODJkMDQwMjQzNTVjPiAoY3JlZGl0LmMjY3NjaGVkX3RpY2srMHgyZjcvMHg0YjcpOg0K Pj4gwqDCoMKgwqAgKFhFTinCoCA1OCA3MCAwZiA4NCBiZiBmZSBmZiBmZiA8MGY+IDBiIDBm IDBiIDBmIDBiIDQ4IDhiIDQwIDIwIDBmIGI3IDAwIA0KPj4gODkgNDUgY2MNCj4+IMKgwqDC oMKgIChYRU4pIFhlbiBzdGFjayB0cmFjZSBmcm9tIHJzcD1mZmZmODMwMjU2MjI3ZGUwOg0K Pj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDQ2NjkyYSBmZmZmODMwMjUxNWMw YmMwIDAwMDAwMDA0NDAyNWFlMjcgMDAyMTkxYzA1MTdmNjRlOA0KPj4gwqDCoMKgwqAgKFhF TinCoMKgwqAgZmZmZjgyZDA0MDVjMzNlMCBmZmZmODMwMjUxN2M4NTkwIGZmZmY4MmQwNDA1 YzMyODAgZmZmZjgyZDA0MDI0MzI2NQ0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAw MDAwMDAwMDAwNCAwMDAwMDAyNmQyN2E4MGE3IDAwMDAwMDAwMDAwMDAwMDAgZmZmZjgzMDI1 NjIyN2U2MA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZjgyZDA0MDIyZWU5NCBmZmZm ODJkMDQwNWMzMjgwIGZmZmY4MzAyNTE3ZTdkZjAgZmZmZjgzMDI1MTc3ODEyMA0KPj4gwqDC oMKgwqAgKFhFTinCoMKgwqAgZmZmZjgzMDI1NjIyN2VhMCBmZmZmODJkMDQwMjJmNzdhIGZm ZmY4MzAyNTYyMjdlODAgZmZmZjgyZDA0MDVjOWYwMA0KPj4gwqDCoMKgwqAgKFhFTinCoMKg wqAgZmZmZmZmZmZmZmZmZmZmZiBmZmZmODJkMDQwNWM5ZjAwIGZmZmY4MzAyNTYyMjdmZmYg MDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZjgzMDI1NjIy N2VkOCBmZmZmODJkMDQwMjJkMjZjIGZmZmY4MzAyNTE3NDUwMDAgMDAwMDAwMDAwMDAwMDAw MA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAwMCBmZmZmODMwMjU2 MjI3ZmZmIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjgzMDI1NjIyN2VlOA0KPj4gwqDCoMKgwqAg KFhFTinCoMKgwqAgZmZmZjgyZDA0MDIyZDJmZiAwMDAwN2NmZGE5ZGQ4MGU3IGZmZmY4MmQw NDAyZjA0OTYgMDAwMDAwMDAwMDAwMDAwMQ0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgZmZm ZmM5MDA0MDEyN2RkYyBmZmZmYzkwMDQwMTI3ZGQwIGZmZmZjOTAwNDAxMjdkZDQgZmZmZmM5 MDA0MDEyN2RkOA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDA3NTZlNjU0NyAw MDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDAgZmZmZmM5MDA0MDEyN2RkYw0KPj4g wqDCoMKgwqAgKFhFTinCoMKgwqAgZmZmZmM5MDA0MDEyN2RkMCAwMDAwMDAwMDAwMDAwMDBk IDAwMDAwMDAwNmM2NTc0NmUgMDAwMDAwMDA0OTY1NmU2OQ0KPj4gwqDCoMKgwqAgKFhFTinC oMKgwqAgZmZmZmM5MDA0MDEyN2RkNCBmZmZmYzkwMDQwMTI3ZGQ4IDAwMDAwMGZhMDAwMDAw MDAgZmZmZmZmZmY4MTAxYzVhNA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAw MDAwZTAzMyAwMDAwMDAwMDAwMDAwMjkzIGZmZmZjOTAwNDAxMjdkYjggMDAwMDAwMDAwMDAw ZTAyYg0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAw MDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKg wqAgKFhFTinCoMKgwqAgMDAwMGUwMTAwMDAwMDAwMCBmZmZmODMwMjUxNzQ1MDAwIDAwMDAw MDAwMDAwMDAwMDAgMDAwMDAwMDAwMDM3MjY2MA0KPj4gwqDCoMKgwqAgKFhFTinCoMKgwqAg MDAwMDAwMDAwMDAwMDAwMCA4MDAwMDAwMjU2MjBiMDAyIDAwMGUwMzAzMDAwMDAwMDEgMDAw MDAwMDAwMDAwMDAwMA0KPj4gwqDCoMKgwqAgKFhFTikgWGVuIGNhbGwgdHJhY2U6DQo+PiDC oMKgwqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAyNDM1NWM+XSBSIGNyZWRpdC5jI2Nz Y2hlZF90aWNrKzB4MmY3LzB4NGI3DQo+PiDCoMKgwqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4 MmQwNDAyMmVlOTQ+XSBGIHRpbWVyLmMjZXhlY3V0ZV90aW1lcisweDQ1LzB4NWMNCj4+IMKg wqDCoMKgIChYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDIyZjc3YT5dIEYgdGltZXIuYyN0aW1l cl9zb2Z0aXJxX2FjdGlvbisweDcxLzB4Mjc4DQo+PiDCoMKgwqDCoCAoWEVOKcKgwqDCoCBb PGZmZmY4MmQwNDAyMmQyNmM+XSBGIHNvZnRpcnEuYyNfX2RvX3NvZnRpcnErMHg5NC8weGJl DQo+PiDCoMKgwqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAyMmQyZmY+XSBGIGRvX3Nv ZnRpcnErMHgxMy8weDE1DQo+PiDCoMKgwqDCoCAoWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAy ZjA0OTY+XSBGIHg4Nl82NC9lbnRyeS5TI3Byb2Nlc3Nfc29mdGlycXMrMHg2LzB4MjANCj4+ IMKgwqDCoMKgIChYRU4pDQo+PiDCoMKgwqDCoCAoWEVOKSAqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqDQo+PiDCoMKgwqDCoCAoWEVOKSBQYW5pYyBvbiBDUFUg MDoNCj4+IMKgwqDCoMKgIChYRU4pIEFzc2VydGlvbiAnc2NoZWRfdW5pdF9tYXN0ZXIoY3Vy cnVuaXQpID09IGNwdScgZmFpbGVkIGF0IA0KPj4gY29tbW9uL3NjaGVkL2NyZWRpdC5jOjkz Ng0KPj4gwqDCoMKgwqAgKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKg0KPj4NCj4+IEknbSBub3Qgc3VyZSBhYm91dCB0aGUgbmF0dXJlIG9mIGNyZWRp dDIgY3Jhc2gsIGJ1dCBmb3IgY3JlZGl0MSBpdCBsb29rcw0KPj4gbXVjaCBzaW1wbGVyIHRv IHVuZGVyc3RhbmQuIENyZWRpdDEgcmVnaXN0ZXJzIGEgdGltZXIgZm9yIGVhY2ggcGNwdSAo aW4NCj4+IGluaXRfcGRhdGEoKSkuIFRoZW4sIHRoZSB0aW1lciBmdW5jdGlvbg0KPj4gKGNz Y2hlZF90aWNrKCktPmNzY2hlZF91bml0X2FjY3QoKSkgYXNzZXJ0cyBpZiBpdCB3YXMgcmVh bGx5IGNhbGxlZCBvbg0KPj4gY29ycmVjdCBDUFUuIFRoZSBpc3N1ZSBpcyB0aGF0IHN1c3Bl bmQgcGF0aCBtaWdyYXRlcyBhbGwgdGltZXJzIHRvIENQVTANCj4+ICh0aW1lcmMuOmNwdV9j YWxsYmFjay0+bWlncmF0ZV90aW1lcnNfZnJvbV9jcHUoKSksIGFuZCByZXN0b3JlIHBhdGgN Cj4+IGRvZXNuJ3QgbWlncmF0ZSB0aGVtIGJhY2suIEFsbCB0aGlzIHdoaWxlIG5vdCB1bnJl Z2lzdGVyaW5nIHBDUFVzIGZyb20NCj4+IHRoZSBzY2hlZHVsZXIgKHNjaGVkX2RlaW5pdF9w ZGF0YSgpIC8gaW5pdF9wZGF0YSgpIGlzIG5vdCBjYWxsZWQgLQ0KPj4gY29uZmlybWVkIHZp YSBkZWJ1ZyBwcmludHMpLg0KPj4NCj4+IEknbSBub3QgZXhhY3RseSBzdXJlIGlmIHRoYXQn cyB0aGUgc2FtZSBpc3N1ZSB0aGF0IGFwcGxpZXMgdG8gY3JlZGl0MiwNCj4+IGJ1dCBJIHRo aW5rIGl0J3MgbGlrZWx5LiBBIG5haXZlIGZpeCBjb3VsZCBiZSB1bnJlZ2lzdGVyaW5nIGFs bCBwQ1BVcw0KPj4gZnJvbSB0aGUgc2NoZWR1bGVyIChhbiByZWdpc3RlcmluZyB0aGVtIGJh Y2sgb24gcmVzdW1lKSwgYnV0IHRoaXMgbWF5DQo+PiBtZXNzIHVwIENQVSBwb29scywgYW5k IHByb2JhYmx5IGZldyBvdGhlciB0aGluZ3MuIEFueSBiZXR0ZXIgaWRlYXM/IEkNCj4+IGNh biB0ZXN0IHZhcmlvdXMgcGF0Y2hlcywgcHJvdmlkZSBtb3JlIGRlYnVnIGluZm8gZXRjIC0g c2hvdWxkIGJlIHJhdGhlcg0KPj4gc3RyYWlnaHRmb3J3YXJkIGdpdmVuIEkgaGF2ZSByZWxp YWJsZSByZXByb2R1Y2VyIG5vdy4NCj4gDQo+IFVucmVnaXN0ZXJpbmcgdGhlIGNwdXMgZnJv bSB0aGUgc2NoZWR1bGVyIHdvdWxkIGJyZWFrIGNvcmUgc2NoZWR1bGluZy4NCj4gDQo+IEkn bGwgaGF2ZSBhIGxvb2sgaWYgdGhlIHRpbWVycyBjYW4ganVzdCBiZSBkZWFjdGl2YXRlZCBp biBvcmRlciBub3QgdG8NCj4gaGF2ZSB0aGVtIG1pZ3JhdGVkIHRvIGNwdTAuDQoNCkNvdWxk IHlvdSB0ZXN0IHRoZSBhdHRhY2hlZCBwYXRjaCwgcGxlYXNlPw0KDQoNCkp1ZXJnZW4NCg== --------------u7wOl2ekWlGjgGimmsvjROCX Content-Type: text/x-patch; charset=UTF-8; name="0001-xen-timer-don-t-migrate-timers-away-from-cpus-during.patch" Content-Disposition: attachment; filename*0="0001-xen-timer-don-t-migrate-timers-away-from-cpus-during.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhMmMyMjRiZWU1M2UyMjE2ZDQxYjM0NTE4YmIyZDExYjY0ZDYzYjZhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClRvOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKQ2M6IEFuZHJldyBDb29wZXIg PGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CkNjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+CkNjOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ CkNjOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPgpDYzogU3RlZmFubyBTdGFiZWxs aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgpDYzogV2VpIExpdSA8d2xAeGVuLm9yZz4K RGF0ZTogVHVlLCA2IFNlcCAyMDIyIDEzOjM5OjQ4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g eGVuL3RpbWVyOiBkb24ndCBtaWdyYXRlIHRpbWVycyBhd2F5IGZyb20gY3B1cyBkdXJpbmcg c3VzcGVuZAoKRHVyaW5nIGEgc3VzcGVuZC9yZXN1bWUgY3ljbGUgdGltZXJzIG9uIGFsbCBj cHVzIGJ1dCBjcHUgMCB3aWxsIGJlCm1pZ3JhdGVkIHRvIGNwdSAwLCBhcyB0aGUgb3RoZXIg Y3B1cyBhcmUgdGFrZW4gZG93bi4KClRoaXMgaXMgcHJvYmxlbWF0aWMgaW4gY2FzZSBzdWNo IGEgdGltZXIgaXMgcmVsYXRlZCB0byBhIHNwZWNpZmljIHZjcHUsCmFzIHRoZSB2Y3B1cyBh cmUgbm90IG1pZ3JhdGVkIHRvIGFub3RoZXIgY3B1IGR1cmluZyBzdXNwZW5kIChtaWdyYXRp bmcKdGhlbSB3b3VsZCBicmVhayBjcHVwb29scyBhbmQgY29yZSBzY2hlZHVsaW5nKS4KCklu IG9yZGVyIHRvIGF2b2lkIHRoZSBwcm9ibGVtcyBqdXN0IHRyeSB0byBrZWVwIHRoZSB0aW1l cnMgb24gdGhlaXIKY3B1cy4gT25seSBtaWdyYXRlIHRoZW0gYXdheSBpbiBjYXNlIHJlc3Vt ZSBmYWlsZWQuIERvaW5nIHNvIGlzbid0CnByb2JsZW1hdGljLCBhcyBhbnkgdmNwdSBvbiBh IGNwdSBub3QgY29taW5nIGJhY2sgdG8gbGlmZSB3b3VsZCBiZQptaWdyYXRlZCBhd2F5LCB0 b28uCgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Ci0t LQogeGVuL2NvbW1vbi90aW1lci5jIHwgMTggKysrKysrKysrKysrKy0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS94ZW4vY29tbW9uL3RpbWVyLmMgYi94ZW4vY29tbW9uL3RpbWVyLmMKaW5kZXggOWI1MDE2 ZDVlZC4uNmI1NDczZTVmMSAxMDA2NDQKLS0tIGEveGVuL2NvbW1vbi90aW1lci5jCisrKyBi L3hlbi9jb21tb24vdGltZXIuYwpAQCAtNjM3LDYgKzYzNywxMyBAQCBzdGF0aWMgdm9pZCBm cmVlX3BlcmNwdV90aW1lcnModW5zaWduZWQgaW50IGNwdSkKICAgICAgICAgQVNTRVJUKHRz LT5oZWFwID09IGR1bW15X2hlYXApOwogfQogCitzdGF0aWMgdm9pZCBkZWluaXRfdGltZXJz KHVuc2lnbmVkIGludCBjcHUpCit7CisgICAgbWlncmF0ZV90aW1lcnNfZnJvbV9jcHUoY3B1 KTsKKyAgICBpZiAoICFwYXJrX29mZmxpbmVfY3B1cyApCisgICAgICAgIGZyZWVfcGVyY3B1 X3RpbWVycyhjcHUpOworfQorCiBzdGF0aWMgaW50IGNmX2NoZWNrIGNwdV9jYWxsYmFjaygK ICAgICBzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sgKm5mYiwgdW5zaWduZWQgbG9uZyBhY3Rpb24s IHZvaWQgKmhjcHUpCiB7CkBAIC02NTUsMTMgKzY2MiwxNCBAQCBzdGF0aWMgaW50IGNmX2No ZWNrIGNwdV9jYWxsYmFjaygKICAgICAgICAgfQogICAgICAgICBicmVhazsKIAotICAgIGNh c2UgQ1BVX1VQX0NBTkNFTEVEOgogICAgIGNhc2UgQ1BVX0RFQUQ6Ci0gICAgY2FzZSBDUFVf UkVTVU1FX0ZBSUxFRDoKLSAgICAgICAgbWlncmF0ZV90aW1lcnNfZnJvbV9jcHUoY3B1KTsK KyAgICAgICAgaWYgKCBzeXN0ZW1fc3RhdGUgIT0gU1lTX1NUQVRFX3N1c3BlbmQgKQorICAg ICAgICAgICAgZGVpbml0X3RpbWVycyhjcHUpOworICAgICAgICBicmVhazsKIAotICAgICAg ICBpZiAoICFwYXJrX29mZmxpbmVfY3B1cyAmJiBzeXN0ZW1fc3RhdGUgIT0gU1lTX1NUQVRF X3N1c3BlbmQgKQotICAgICAgICAgICAgZnJlZV9wZXJjcHVfdGltZXJzKGNwdSk7CisgICAg Y2FzZSBDUFVfVVBfQ0FOQ0VMRUQ6CisgICAgY2FzZSBDUFVfUkVTVU1FX0ZBSUxFRDoKKyAg ICAgICAgZGVpbml0X3RpbWVycyhjcHUpOwogICAgICAgICBicmVhazsKIAogICAgIGNhc2Ug Q1BVX1JFTU9WRToKLS0gCjIuMzUuMwoK --------------u7wOl2ekWlGjgGimmsvjROCX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------u7wOl2ekWlGjgGimmsvjROCX-- --------------0u7K0VDFQLykH0CsodesKjad-- --------------nTBoxknjWjMhZn0Ls0BRkcLF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMXMy8FAwAAAAAACgkQsN6d1ii/Ey8f jwf/Q9/pbAUmCX0pee7N3vzzEURr2v2dc/EJsSFyzQ8L9EgKT+kFfb/4XMORP5yw18xn2USIRmpK +Ikdh4FZKIglD/S/gPzWxM+Vs0TKJyYCN8o57OtpbMiBdhcVrK07M5UX0urXEW5oloU5HvkEUR3N Wl0QWE95s/zsqYYjYNma01uEdsrrWGNIy3ROS9wyvnvhUN5yzZGH4J3gp87gmv5Vwh4CcKyz7oF9 SmOxeNYoo4nAsGvRsLbFY0MgC68vb3Tg3yRKjnEZms679OdBxRflo2jSZb1F3xI+zPco1t8fPoCz W+jRCzgKhyxaYEAOrlkN6tg5xT6EMBroN9PTqJtsyQ== =pte2 -----END PGP SIGNATURE----- --------------nTBoxknjWjMhZn0Ls0BRkcLF-- From xen-devel-bounces@lists.xenproject.org Tue Sep 06 11:59:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 11:59:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399808.641140 (Exim 4.92) (envelope-from ) id 1oVXF3-0005h6-9Y; Tue, 06 Sep 2022 11:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399808.641140; Tue, 06 Sep 2022 11:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXF3-0005gz-6a; Tue, 06 Sep 2022 11:59:45 +0000 Received: by outflank-mailman (input) for mailman id 399808; Tue, 06 Sep 2022 11:59:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXF1-0005gt-M6 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 11:59:43 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2052.outbound.protection.outlook.com [40.107.223.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 630abade-2ddb-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 13:59:41 +0200 (CEST) Received: from DM6PR05CA0041.namprd05.prod.outlook.com (2603:10b6:5:335::10) by CH2PR12MB4296.namprd12.prod.outlook.com (2603:10b6:610:af::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 11:59:38 +0000 Received: from DM6NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:5:335:cafe::eb) by DM6PR05CA0041.outlook.office365.com (2603:10b6:5:335::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Tue, 6 Sep 2022 11:59:37 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT115.mail.protection.outlook.com (10.13.173.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 11:59:37 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 06:59:37 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 6 Sep 2022 06:59:35 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 630abade-2ddb-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1jEoCTRY20PTycPhQ3SHq20PP/33yopoR7zjhBZh/PWWCB4psTOkKyr8/zJFSAgSOFE2EkcPc7+jhAx5aX7hgeytZlZftvg5Q0pcx69dmFsl0FDlhzV7hpzbP8K4Wy3vb/oeXtsZF9wysl92JYBfWtGS+uOZngLUcp8ezkImWKl38bwKU1OW9oqLPIXvHOma6AZYbLeo8V/q1Dqc3DZt9oJPpDLF6CDf1n2133bMXSasnB0KSXy0dTbCA0K9o6Qopt2Cj3qf35wpqo9Fi3b5aLiEiMBxQudEfxt1AY3DVADCr4mzv8aS+ad7yQHoKMNUas8H6xASzHLml5qVlcpjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WU5COqqDjHHT+zMG0/zoFpjUpQbL8wEzU+p85v79Uw8=; b=bYbEPa+grUl0b4RaemJVraIvQzU8opbTXO5Pnb3+zfK8Rsc2bbL5n7pIvmFATvdiG02P/JdnLjvPmuUdtV9Zs1kvXLsn5fIuEuSZHttG6RvDbJlKwODYoTbBskob0W68+a+7oGocS8cn0u1CqXd/eQeuE+k9YIbIVgj5F7TqDQ/oRB+ByyJpwnN+Aaj4fRJipDkl+mFMAESavE3QeOKjc63XqsVZi1oSeA7TEZYFX7cFGT6eLz7HzaZO4DJl++5mwFdkBFKM9PMpzobSQrOf52vRTL0n6tNbE/g2Tg29sv0liu90CeTNtV90pulUtJFOrPVoNpZnXKDcEkleXoA9Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WU5COqqDjHHT+zMG0/zoFpjUpQbL8wEzU+p85v79Uw8=; b=1sqwVFtGLr4uYlaNoo5E7LIbCYcz4AZbN8cz/Jfjh1be23QmvwqovTCNY6rqZj+ZcCntMMrpHvQFglrHvPZfOectDdZdLw/kCo+Xs10Befle14tO8lmmD48gLY3bRbT9PUzclM30OsoaV0DD7zwXCOoWhZnU1UjkCzl29NQtKLQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <55154517-40ac-691c-74ed-7ce2504f6c07@amd.com> Date: Tue, 6 Sep 2022 13:59:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 9/9] xen: Add static memory sharing in SUPPORT.md Content-Language: en-US To: Penny Zheng , CC: , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-10-Penny.Zheng@arm.com> From: Michal Orzel In-Reply-To: <20220906085941.944592-10-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ea6146b-51de-4ce0-eb05-08da8fff45ed X-MS-TrafficTypeDiagnostic: CH2PR12MB4296:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UKjjLL7yeodORFyn36HZeWs17vVbDf7KeieSFHGp4WAYpDB6YfPv3eFjkflclajrFOrBkCUSKnc8V18F0jqFz8pcWjWpdVPc239WPQcISfvd0PxIYqgrNvhmT+YyV63dsTAR2oDWuBQFe2HtdD0sVZxTu3vaxXlFYkvWigL/tIYLGjxALzIz0oz7lvHPRMicf1aLxvHc7ekbkOiQBUHeMAMcdprE/6L+7SSAx3gj4/dqhW27muu03coi6yC4YbSBNam3k4bPNOfOKVs0FlGHLnYodfGHHEIRFNm2dC0zU1rS6E5kOBs4f/eCSFrO+cBkGl7r1qEZ/JL9UUTke3WzziY/rmxVluc8yzGo6vKSz6O/vITTGMyU/OUBfvI4oL+0c7j11JLg2pNB5bYoIJeG8LSMnCU1A4WyqfvNzK5d8+KuUClhCgY5bORbbJFQAobctSEs2xPo1H2HCcyRxw/Ji2bs5Qn34dEKw7+tUow/52jauDcPRmGs6BLsXkPbUBSYZf93nSpDxUUC4Y3ewGQ/vnbPz1V293fcqaEmx9F4Ka3WqkBz1+H8bq7+M2ofugLG9xS0S+HEi27ztEauK/Ny8R9/zwdVa1aQPg2Pk0OPbiRbIBpW8cHmHxRZIxxYQ03YHTqNYQ05kWNnrgFYxiexW7wRcSgPVWApuRti/0rH24wnaDLe2QidnmZ93Ke8Slcy5ZynsIN4RkbOxNAJajfqzrENZHE+GofQq9SBVaVACSF3UBI4UNOKlyEwqEdO9VNkm+6OacYjtJteK/tiG1znBRr0mzlhUkWJFOwlP8TdEBNlyMCaa1uygCAuTnd/TcU7PFMXOHI6W2p6zhdK/MWpPg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(346002)(46966006)(36840700001)(40470700004)(316002)(5660300002)(16576012)(4326008)(36860700001)(8936002)(70586007)(44832011)(54906003)(2906002)(36756003)(70206006)(31686004)(110136005)(8676002)(478600001)(41300700001)(40480700001)(426003)(47076005)(558084003)(26005)(31696002)(2616005)(53546011)(186003)(82310400005)(336012)(86362001)(356005)(40460700003)(81166007)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 11:59:37.8061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea6146b-51de-4ce0-eb05-08da8fff45ed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4296 Hi Penny, On 06/09/2022 10:59, Penny Zheng wrote: > > on ARM, static memory sharing is tech preview, which shall be documented > in SUPPORT.md > > Signed-off-by: Penny Zheng Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Tue Sep 06 12:31:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 12:31:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399818.641151 (Exim 4.92) (envelope-from ) id 1oVXjw-0001cX-VH; Tue, 06 Sep 2022 12:31:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399818.641151; Tue, 06 Sep 2022 12:31:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXjw-0001cQ-SJ; Tue, 06 Sep 2022 12:31:40 +0000 Received: by outflank-mailman (input) for mailman id 399818; Tue, 06 Sep 2022 12:31:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXjv-0001cG-Ih; Tue, 06 Sep 2022 12:31:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXjv-0002rd-9L; Tue, 06 Sep 2022 12:31:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXju-0005OW-RR; Tue, 06 Sep 2022 12:31:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVXju-0000JZ-R2; Tue, 06 Sep 2022 12:31:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=liLgsIXO+mMCgjzubFOr2bI8WB/gkUH59lxIjvG5//w=; b=hos5KZ68BV/I+TmKnG8ecouLY6 EVrcaba+CoqpB8ddBNjPntf0N/tVkwEv98+Ty+UoykXRl4H84UXr0LRIhot9P64uQ3Nrau81I+R+E A6azRbdHewy4rkDS/lvJesU5CQnJklykKa1Up0YWCdtDLIcXFpNfZecKz+c8XZYjMjY8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173013: FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-migrupgrade::broken:regression xen-unstable:test-amd64-amd64-migrupgrade:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d84473689611eed32fd90b27e614f28af767fa3f X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Tue, 06 Sep 2022 12:31:38 +0000 flight 173013 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173013/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade broken in 173004 Tests which are failing intermittently (not blocking): test-amd64-amd64-migrupgrade 6 host-install/src_host(6) broken in 173004 pass in 173013 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 173004 pass in 173013 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173004 pass in 173013 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 173004 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172993 build-i386-libvirt 6 libvirt-build fail like 172993 build-arm64-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172993 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172993 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172993 build-armhf-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen d84473689611eed32fd90b27e614f28af767fa3f baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172993 2022-09-05 01:52:22 Z 1 days Testing same since 173004 2022-09-05 14:38:21 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-migrupgrade broken Not pushing. ------------------------------------------------------------ commit d84473689611eed32fd90b27e614f28af767fa3f Author: Juergen Gross Date: Mon Sep 5 09:00:05 2022 +0200 xen/sched: fix cpu hotplug Cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() with interrupts disabled, thus any memory allocation or freeing must be avoided. Since commit 5047cd1d5dea ("xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()") this restriction is being enforced via an assertion, which will now fail. Fix this by allocating needed memory before entering stop_machine_run() and freeing any memory only after having finished stop_machine_run(). Fixes: 1ec410112cdd ("xen/sched: support differing granularity in schedule_cpu_[add/rm]()") Reported-by: Gao Ruifeng Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper commit d42be6f83480b3ada286dc18444331a816be88a3 Author: Juergen Gross Date: Mon Sep 5 09:00:04 2022 +0200 xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() In order to prepare not allocating or freeing memory from schedule_cpu_rm(), move this functionality to dedicated functions. For now call those functions from schedule_cpu_rm(). No change of behavior expected. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper Reviewed-by: Andrew Cooper commit a83fa1e2b96ace65b45dde6954d67012633a082b Author: Juergen Gross Date: Mon Sep 5 09:00:03 2022 +0200 xen/sched: introduce cpupool_update_node_affinity() For updating the node affinities of all domains in a cpupool add a new function cpupool_update_node_affinity(). In order to avoid multiple allocations of cpumasks carve out memory allocation and freeing from domain_update_node_affinity() into new helpers, which can be used by cpupool_update_node_affinity(). Modify domain_update_node_affinity() to take an additional parameter for passing the allocated memory in and to allocate and free the memory via the new helpers in case NULL was passed. This will help later to pre-allocate the cpumasks in order to avoid allocations in stop-machine context. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 12:35:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 12:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399827.641162 (Exim 4.92) (envelope-from ) id 1oVXnU-0002FF-F5; Tue, 06 Sep 2022 12:35:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399827.641162; Tue, 06 Sep 2022 12:35:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXnU-0002F8-C6; Tue, 06 Sep 2022 12:35:20 +0000 Received: by outflank-mailman (input) for mailman id 399827; Tue, 06 Sep 2022 12:35:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXnT-0002Eu-60 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 12:35:19 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b1356c6-2de0-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 14:35:16 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 85D7532007D7; Tue, 6 Sep 2022 08:35:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 06 Sep 2022 08:35:13 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Sep 2022 08:35:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b1356c6-2de0-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1662467712; x= 1662554112; bh=nGfaxhLBr4/YrjbWe1CZXQFAEaOkkaaweyLMlfdKZN4=; b=h ++ay8hAqpMuC5tcRsHrG2wg4aNeBuNDfB3txTpn4ml9D5OS5cPpqfSAaqBceR+XZ cnyWO04s/LQMTKAQlJ1fl7S76G+Xbh01Gy8osYzUuzaKiyyyQGdO90SzHT+g41Zr ng4hP1juzRAkXjvzjTsR5A85DmnJKpkgaHU9VQ/Sny1ernW44MlUQgtO2GF2UWQz zQXtcxblrImpP+Dwci/q/+Lr9zdfIEA8Ky0idvMinhZVpoiA1d6JFXl9c0WIhMkp 41s70XWxMU3XXdXc+C3kyKFlfQPnbov4Mooj56207RBJdKGTiXdXpkztgABE6nhV HEdYoarhD58xZrg1MoRFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662467712; x=1662554112; bh=nGfaxhLBr4/YrjbWe1CZXQFAEaOk kaaweyLMlfdKZN4=; b=HRuhg9XkTHFcFbxIAuuoecxMtJ3RU79MBibGVJgjMPdn J0yiPmYGimjZyt8CTVqaDTfR7/fsP3JEMI6ocnKzTgGx5Y07MkIf3ful4hL4rSST 8wIEzqAbNhRq5kQsNbzC/7i9QD0rsXUvTVaNtksJU9uRR/M1NIP++V8YgLVsF+/e Mfbrw/oW1VKQskuGBKX7H6XIstHMNUTrxgXTCiwZBcwmu7NMOk/Lk5l/h/czWEv7 sOIOZWhyxj5jClmNrHQ68oIvVzjwB0oRFiJhRHCemyvnBiCpkSKXgjiEqu1VRAXH 1ABVT390gWcpuDTzcfGQYMHg74pWV3/fIh9PG32NwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelkedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 6 Sep 2022 14:35:08 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Juergen Gross Cc: Juergen Gross , Dario Faggioli , Jan Beulich , Andrew Cooper , xen-devel Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Message-ID: References: <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl> <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> <919e328a-000e-0eeb-2253-6a4381b5ccaa@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="plCgYlfOmdnx8632" Content-Disposition: inline In-Reply-To: <919e328a-000e-0eeb-2253-6a4381b5ccaa@suse.com> --plCgYlfOmdnx8632 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 6 Sep 2022 14:35:08 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Juergen Gross Cc: Juergen Gross , Dario Faggioli , Jan Beulich , Andrew Cooper , xen-devel Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer On Tue, Sep 06, 2022 at 01:46:55PM +0200, Juergen Gross wrote: > On 22.08.22 17:34, Juergen Gross wrote: > > On 21.08.22 18:14, Marek Marczykowski-G=C3=B3recki wrote: > > > On Sat, Oct 09, 2021 at 06:28:17PM +0200, Marek Marczykowski-G=C3=B3r= ecki wrote: > > > > On Sun, Jan 31, 2021 at 03:15:30AM +0100, Marek Marczykowski-G=C3= =B3recki wrote: > > > > > On Tue, Sep 29, 2020 at 05:27:48PM +0200, J=C3=BCrgen Gro=C3=9F w= rote: > > > > > > On 29.09.20 17:16, Marek Marczykowski-G=C3=B3recki wrote: > > > > > > > On Tue, Sep 29, 2020 at 05:07:11PM +0200, J=C3=BCrgen Gro=C3= =9F wrote: > > > > > > > > On 29.09.20 16:27, Marek Marczykowski-G=C3=B3recki wrote: > > > > > > > > > On Mon, Mar 23, 2020 at 01:09:49AM +0100, Marek Marczykow= ski-G=C3=B3recki wrote: > > > > > > > > > > On Thu, Mar 19, 2020 at 01:28:10AM +0100, Dario Faggiol= i wrote: > > > > > > > > > > > [Adding Juergen] > > > > > > > > > > >=20 > > > > > > > > > > > On Wed, 2020-03-18 at 23:10 +0100, Marek Marczykowski= -G=C3=B3recki wrote: > > > > > > > > > > > > On Wed, Mar 18, 2020 at 02:50:52PM +0000, Andrew Co= oper wrote: > > > > > > > > > > > > > On 18/03/2020 14:16, Marek Marczykowski-G=C3=B3re= cki wrote: > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > In my test setup (inside KVM with nested virt e= nabled), I rather > > > > > > > > > > > > > > frequently get Xen crash on resume from S3. Ful= l message below. > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > This is Xen 4.13.0, with some patches, includin= g "sched: fix > > > > > > > > > > > > > > resuming > > > > > > > > > > > > > > from S3 with smt=3D0". > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > Contrary to the previous issue, this one does n= ot happen always - > > > > > > > > > > > > > > I > > > > > > > > > > > > > > would say in about 40% cases on this setup, but= very rarely on > > > > > > > > > > > > > > physical > > > > > > > > > > > > > > setup. > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > This is _without_ core scheduling enabled, and = also with smt=3Doff. > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > Do you think it would be any different on xen-u= nstable? I cat > > > > > > > > > > > > > > try, but > > > > > > > > > > > > > > it isn't trivial in this setup, so I'd ask firs= t. > > > > > > > > > > > > > >=20 > > > > > > > > > > > Well, Juergen has fixed quite a few issues. > > > > > > > > > > >=20 > > > > > > > > > > > Most of them where triggering with core-scheduling en= abled, and I don't > > > > > > > > > > > recall any of them which looked similar or related to= this. > > > > > > > > > > >=20 > > > > > > > > > > > Still, it's possible that the same issue causes diffe= rent symptoms, and > > > > > > > > > > > hence that maybe one of the patches would fix this to= o. > > > > > > > > > >=20 > > > > > > > > > > I've tested on master (d094e95fb7c), and reproduced exa= ctly the same crash > > > > > > > > > > (pasted below for the completeness). > > > > > > > > > > But there is more: additionally, in most > > > > > > > > > > (all?) cases after resume I've got > > > > > > > > > > soft lockup in Linux dom0 in smp_call_function_single()= - see below. It > > > > > > > > > > didn't happened before and the only change was Xen 4.13= -> master. > > > > > > > > > >=20 > > > > > > > > > > Xen crash: > > > > > > > > > >=20 > > > > > > > > > > (XEN) Assertion > > > > > > > > > > 'c2rqd(sched_unit_master(unit)) =3D=3D > > > > > > > > > > svc->rqd' failed at credit2.c:2133 > > > > > > > > >=20 > > > > > > > > > Juergen, any idea about this one? This is also happening = on the current > > > > > > > > > stable-4.14 (28855ebcdbfa). > > > > > > > > >=20 > > > > > > > >=20 > > > > > > > > Oh, sorry I didn't come back to this issue. > > > > > > > >=20 > > > > > > > > I suspect this is related to stop_machine_run() being calle= d during > > > > > > > > suspend(), as I'm seeing very sporadic issues when offlinin= g and then > > > > > > > > onlining cpus with core scheduling being active (it seems a= s if the > > > > > > > > dom0 vcpu doing the cpu online activity sometimes is using = an old > > > > > > > > vcpu state). > > > > > > >=20 > > > > > > > Note this is default Xen 4.14 start, so core scheduling is _n= ot_ active: > > > > > >=20 > > > > > > The similarity in the two failure cases is that multiple cpus a= re > > > > > > affected by the operations during stop_machine_run(). > > > > > >=20 > > > > > > >=20 > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Brought up 2 CPUs > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Scheduling granularity: = cpu, 1 CPU per sched-resource > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Adding cpu 0 to runqueue= 0 > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0 First cpu on runqu= eue, activating > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Adding cpu 1 to runqueue= 1 > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0 First cpu on runqu= eue, activating > > > > > > >=20 > > > > > > > > I wasn't able to catch the real problem despite of having t= ried lots > > > > > > > > of approaches using debug patches. > > > > > > > >=20 > > > > > > > > Recently I suspected the whole problem could be somehow rel= ated to > > > > > > > > RCU handling, as stop_machine_run() is relying on tasklets = which are > > > > > > > > executing in idle context, and RCU handling is done in idle= context, > > > > > > > > too. So there might be some kind of use after free scenario= in case > > > > > > > > some memory is freed via RCU despite it still being used by= a tasklet. > > > > > > >=20 > > > > > > > That sounds plausible, even though I don't really know this a= rea of Xen. > > > > > > >=20 > > > > > > > > I "just" need to find some time to verify this suspicion. A= ny help doing > > > > > > > > this would be appreciated. :-) > > > > > > >=20 > > > > > > > I do have a setup where I can easily-ish reproduce the issue.= If there > > > > > > > is some debug patch you'd like me to try, I can do that. > > > > > >=20 > > > > > > Thanks. I might come back to that offer as you are seeing a cra= sh which > > > > > > will be much easier to analyze. Catching my error case is much = harder as > > > > > > it surfaces some time after the real problem in a non destructi= ve way > > > > > > (usually I'm seeing a failure to load a library in the program = which > > > > > > just did its job via exactly the library claiming not being loa= dable). > > > > >=20 > > > > > Hi, > > > > >=20 > > > > > I'm resurrecting this thread as it was recently mentioned elsewhe= re. I > > > > > can still reproduce the issue on the recent staging branch (9dc68= 7f155). > > > > >=20 > > > > > It fails after the first resume (not always, but frequent enough = to > > > > > debug it). At least one guest needs to be running - with just (PV= ) dom0 > > > > > the crash doesn't happen (at least for the ~8 times in a row I tr= ied). > > > > > If the first resume works, the second (almost?) always will fail = but > > > > > with a different symptoms - dom0 kernel lockups (at least some of= its > > > > > vcpus). I haven't debugged this one yet at all. > > > > >=20 > > > > > Any help will be appreciated, I can apply some debug patches, cha= nge > > > > > configuration etc. > > > >=20 > > > > This still happens on 4.14.3. Maybe it is related to freeing percpu > > > > areas, as it caused other issues with suspend too? Just a thought... > > >=20 > > > I have reproduced this on current staging(*). And I can reproduce it > > > reliably. And also, I got (I believe) closely related crash with cred= it1 > > > scheduler. > > >=20 > > > (*) It isn't plain staging, it's one with my xhci console patches on > > > top, including attempt to make it survive S3. I believe the only > > > relevant part there is sticking set_timer() into console resume path = (or > > > just having a timer with rather short delay registered). The actual t= ree > > > at https://github.com/marmarek/xen/tree/master-xue2-debug, including > > > quite a lot of debug prints and debug hacks. > > >=20 > > > Specific crash with credit2: > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Assertion 'sched_unit_master(currunit)= =3D=3D cpu' failed at > > > common/sched/credit.c:928 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) ----[ Xen-4.17-unstable=C2=A0 x86_64= =C2=A0 debug=3Dy=C2=A0 Tainted:=C2=A0=C2=A0 C=C2=A0=C2=A0=C2=A0 ]---- > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) CPU:=C2=A0=C2=A0=C2=A0 0 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) RIP:=C2=A0=C2=A0=C2=A0 e008:[] credit.c#csched_tick+0x2d4/0x494 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) RFLAGS: 0000000000010202=C2=A0=C2=A0 C= ONTEXT: hypervisor (d0v4) > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) rax: ffff82d0405c4298=C2=A0=C2=A0 rbx:= 0000000000000002=C2=A0=C2=A0 rcx: 0000000000000002 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) rdx: ffff8302517f64d0=C2=A0=C2=A0 rsi:= ffff8302515c0fc0=C2=A0=C2=A0 rdi: 0000000000000002 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) rbp: ffff830256227e38=C2=A0=C2=A0 rsp:= ffff830256227de0=C2=A0=C2=A0 r8:=C2=A0 0000000000000004 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) r9:=C2=A0 ffff8302517ac820=C2=A0=C2=A0= r10: ffff830251745068=C2=A0=C2=A0 r11: 00000088cb734887 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) r12: ffff83025174de50=C2=A0=C2=A0 r13:= ffff8302515c0fa0=C2=A0=C2=A0 r14: ffff83025174df40 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) r15: ffff8302515c0cc0=C2=A0=C2=A0 cr0:= 0000000080050033=C2=A0=C2=A0 cr4: 0000000000372660 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) cr3: 00000001bacbd000=C2=A0=C2=A0 cr2:= 000077e5ec02a318 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) fsb: 000077e5fe533700=C2=A0=C2=A0 gsb:= ffff888255700000=C2=A0=C2=A0 gss: 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) ds: 0000=C2=A0=C2=A0 es: 0000=C2=A0=C2= =A0 fs: 0000=C2=A0=C2=A0 gs: 0000=C2=A0=C2=A0 ss: 0000=C2=A0=C2=A0 cs: e008 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Xen code around (cr= edit.c#csched_tick+0x2d4/0x494): > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0 01 00 00 e9 2a 01 00 00 <0f> 0b = 0f 0b 0f 0b 48 8b 41 20 > > > 0f b7 00 89 45 cc > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Xen stack trace from rsp=3Dffff8302562= 27de0: > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff830256227fff 000= 0000000000000 0000000256227e10 ffff82d04035be90 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff830256227ef8 fff= f830251745000 ffff82d0405c3280 ffff82d0402431eb > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000002 000= 00088c9ba9534 0000000000000000 ffff830256227e60 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff82d04022ee53 fff= f82d0405c3280 ffff8302963e1320 ffff8302515c0fc0 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff830256227ea0 fff= f82d04022f73f ffff830256227e80 ffff82d0405c9f00 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffffffffffffffff fff= f82d0405c9f00 ffff830256227fff 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff830256227ed8 fff= f82d04022d26c ffff830251745000 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000000 fff= f830256227fff 0000000000000000 ffff830256227ee8 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff82d04022d2ff 000= 07cfda9dd80e7 ffff82d0402f03c6 ffff88810c005c00 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000031 000= 0000000000100 00000000fffffe00 0000000000000031 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000031 fff= fffff82d45d28 0000000000000e2e 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000032 000= 00000ffffef31 0000000000000000 ffff88812244a700 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000005 fff= f88812244a780 000000fa00000000 ffffffff818db55f > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 000000000000e033 000= 0000000000246 ffffc900409b7c50 000000000000e02b > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000000 000= 0000000000000 0000000000000000 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000e01000000000 fff= f830251745000 0000000000000000 0000000000372660 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000000 800= 000025620b002 000e030300000001 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Xen call trace: > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= R credit.c#csched_tick+0x2d4/0x494 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F timer.c#execute_timer+0x45/0x5c > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F timer.c#timer_softirq_action+0x71/0x278 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F softirq.c#__do_softirq+0x94/0xbe > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F do_softirq+0x13/0x15 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F x86_64/entry.S#process_softirqs+0x6/0x20 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) **************************************= ** > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Panic on CPU 0: > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Assertion 'sched_unit_master(currunit)= =3D=3D cpu' failed at > > > common/sched/credit.c:928 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) **************************************= ** > > >=20 > > > Specific crash with credit1: > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) ASSERT FAIL! cpu 4, sched_unit_master = 0, currunit id 4 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Assertion 'sched_unit_master(currunit)= =3D=3D cpu' failed at > > > common/sched/credit.c:936 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) ----[ Xen-4.17-unstable=C2=A0 x86_64= =C2=A0 debug=3Dy=C2=A0 Tainted:=C2=A0=C2=A0 C=C2=A0=C2=A0=C2=A0 ]---- > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) CPU:=C2=A0=C2=A0=C2=A0 0 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) RIP:=C2=A0=C2=A0=C2=A0 e008:[] credit.c#csched_tick+0x2f7/0x4b7 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) RFLAGS: 0000000000010202=C2=A0=C2=A0 C= ONTEXT: hypervisor (d0v4) > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) rax: ffff8302517f64d0=C2=A0=C2=A0 rbx:= 0000000000000004=C2=A0=C2=A0 rcx: 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) rdx: ffff830256227fff=C2=A0=C2=A0 rsi:= 000000000000000a=C2=A0=C2=A0 rdi: ffff82d0404786b8 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) rbp: ffff830256227e38=C2=A0=C2=A0 rsp:= ffff830256227de0=C2=A0=C2=A0 r8:=C2=A0 0000000000000087 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) r9:=C2=A0 0000000000000001=C2=A0=C2=A0= r10: 0000000000000001=C2=A0=C2=A0 r11: 0000000000000004 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) r12: ffff83025174de50=C2=A0=C2=A0 r13:= ffff830251778100=C2=A0=C2=A0 r14: ffff83025174df40 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) r15: ffff8302515c0cc0=C2=A0=C2=A0 cr0:= 0000000080050033=C2=A0=C2=A0 cr4: 0000000000372660 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) cr3: 000000024ac10000=C2=A0=C2=A0 cr2:= 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) fsb: 0000000000000000=C2=A0=C2=A0 gsb:= ffff888255700000=C2=A0=C2=A0 gss: 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) ds: 002b=C2=A0=C2=A0 es: 002b=C2=A0=C2= =A0 fs: 0000=C2=A0=C2=A0 gs: 0000=C2=A0=C2=A0 ss: 0000=C2=A0=C2=A0 cs: e008 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Xen code around (cr= edit.c#csched_tick+0x2f7/0x4b7): > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0 58 70 0f 84 bf fe ff ff <0f> 0b = 0f 0b 0f 0b 48 8b 40 20 > > > 0f b7 00 89 45 cc > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Xen stack trace from rsp=3Dffff8302562= 27de0: > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 000000000046692a fff= f8302515c0bc0 000000044025ae27 002191c0517f64e8 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff82d0405c33e0 fff= f8302517c8590 ffff82d0405c3280 ffff82d040243265 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000004 000= 00026d27a80a7 0000000000000000 ffff830256227e60 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff82d04022ee94 fff= f82d0405c3280 ffff8302517e7df0 ffff830251778120 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff830256227ea0 fff= f82d04022f77a ffff830256227e80 ffff82d0405c9f00 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffffffffffffffff fff= f82d0405c9f00 ffff830256227fff 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff830256227ed8 fff= f82d04022d26c ffff830251745000 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000000 fff= f830256227fff 0000000000000000 ffff830256227ee8 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffff82d04022d2ff 000= 07cfda9dd80e7 ffff82d0402f0496 0000000000000001 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffffc90040127ddc fff= fc90040127dd0 ffffc90040127dd4 ffffc90040127dd8 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 00000000756e6547 000= 0000000000000 0000000000000000 ffffc90040127ddc > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffffc90040127dd0 000= 000000000000d 000000006c65746e 0000000049656e69 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 ffffc90040127dd4 fff= fc90040127dd8 000000fa00000000 ffffffff8101c5a4 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 000000000000e033 000= 0000000000293 ffffc90040127db8 000000000000e02b > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000000 000= 0000000000000 0000000000000000 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000e01000000000 fff= f830251745000 0000000000000000 0000000000372660 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 0000000000000000 800= 000025620b002 000e030300000001 0000000000000000 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Xen call trace: > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= R credit.c#csched_tick+0x2f7/0x4b7 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F timer.c#execute_timer+0x45/0x5c > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F timer.c#timer_softirq_action+0x71/0x278 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F softirq.c#__do_softirq+0x94/0xbe > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F do_softirq+0x13/0x15 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN)=C2=A0=C2=A0=C2=A0 []= F x86_64/entry.S#process_softirqs+0x6/0x20 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) **************************************= ** > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Panic on CPU 0: > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) Assertion 'sched_unit_master(currunit)= =3D=3D cpu' failed at > > > common/sched/credit.c:936 > > > =C2=A0=C2=A0=C2=A0=C2=A0 (XEN) **************************************= ** > > >=20 > > > I'm not sure about the nature of credit2 crash, but for credit1 it lo= oks > > > much simpler to understand. Credit1 registers a timer for each pcpu (= in > > > init_pdata()). Then, the timer function > > > (csched_tick()->csched_unit_acct()) asserts if it was really called on > > > correct CPU. The issue is that suspend path migrates all timers to CP= U0 > > > (timerc.:cpu_callback->migrate_timers_from_cpu()), and restore path > > > doesn't migrate them back. All this while not unregistering pCPUs from > > > the scheduler (sched_deinit_pdata() / init_pdata() is not called - > > > confirmed via debug prints). > > >=20 > > > I'm not exactly sure if that's the same issue that applies to credit2, > > > but I think it's likely. A naive fix could be unregistering all pCPUs > > > from the scheduler (an registering them back on resume), but this may > > > mess up CPU pools, and probably few other things. Any better ideas? I > > > can test various patches, provide more debug info etc - should be rat= her > > > straightforward given I have reliable reproducer now. > >=20 > > Unregistering the cpus from the scheduler would break core scheduling. > >=20 > > I'll have a look if the timers can just be deactivated in order not to > > have them migrated to cpu0. >=20 > Could you test the attached patch, please? I did a test with only dom0 running, and it works now. It isn't a comprehensive test, but just dom0 was enough to crash it before, and it stays working now. Thanks! Tested-by: Marek Marczykowski-G=C3=B3recki >=20 >=20 > Juergen > From a2c224bee53e2216d41b34518bb2d11b64d63b6a Mon Sep 17 00:00:00 2001 > From: Juergen Gross > To: xen-devel@lists.xenproject.org > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Jan Beulich > Cc: Julien Grall > Cc: Stefano Stabellini > Cc: Wei Liu > Date: Tue, 6 Sep 2022 13:39:48 +0200 > Subject: [PATCH] xen/timer: don't migrate timers away from cpus during su= spend >=20 > During a suspend/resume cycle timers on all cpus but cpu 0 will be > migrated to cpu 0, as the other cpus are taken down. >=20 > This is problematic in case such a timer is related to a specific vcpu, > as the vcpus are not migrated to another cpu during suspend (migrating > them would break cpupools and core scheduling). >=20 > In order to avoid the problems just try to keep the timers on their > cpus. Only migrate them away in case resume failed. Doing so isn't > problematic, as any vcpu on a cpu not coming back to life would be > migrated away, too. >=20 > Signed-off-by: Juergen Gross > --- > xen/common/timer.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) >=20 > diff --git a/xen/common/timer.c b/xen/common/timer.c > index 9b5016d5ed..6b5473e5f1 100644 > --- a/xen/common/timer.c > +++ b/xen/common/timer.c > @@ -637,6 +637,13 @@ static void free_percpu_timers(unsigned int cpu) > ASSERT(ts->heap =3D=3D dummy_heap); > } > =20 > +static void deinit_timers(unsigned int cpu) > +{ > + migrate_timers_from_cpu(cpu); > + if ( !park_offline_cpus ) > + free_percpu_timers(cpu); > +} > + > static int cf_check cpu_callback( > struct notifier_block *nfb, unsigned long action, void *hcpu) > { > @@ -655,13 +662,14 @@ static int cf_check cpu_callback( > } > break; > =20 > - case CPU_UP_CANCELED: > case CPU_DEAD: > - case CPU_RESUME_FAILED: > - migrate_timers_from_cpu(cpu); > + if ( system_state !=3D SYS_STATE_suspend ) > + deinit_timers(cpu); > + break; > =20 > - if ( !park_offline_cpus && system_state !=3D SYS_STATE_suspend ) > - free_percpu_timers(cpu); > + case CPU_UP_CANCELED: > + case CPU_RESUME_FAILED: > + deinit_timers(cpu); > break; > =20 > case CPU_REMOVE: > --=20 > 2.35.3 >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --plCgYlfOmdnx8632 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMXPnwACgkQ24/THMrX 1yzsSwgAk6kBxfw+L5Nw2HZKhKUNYpM3+UJhrr2bl2HH8k9G3/RI0aJBU3K5P+YE Z/15IpZtKlACUdiIvFVWt9N5Hp+ZmFdO5rRtxdSx1VMmXt9kIz6t9YeCXor3Alg4 c6Ph69WyLuXom+SgBh1qN/yAhp/ObrbZc44D2KRmd5Cua7qBOtny3hqZCGKb7Z0z 21vHURtn1OYx/ltC37TIWo3ERqN+ZswnEHQNG3XA39pGZEWZl0Ns4hsVNKP9Yihg Xb772o4HishRTtq+sbfJyHYPx5d69M4owgp8aq49KbDSzI8wZl8H9itk+CmfZ0EC 4f7tFZQ1Uu5UTxSaCzZMLb4Ls7GKTQ== =WKhE -----END PGP SIGNATURE----- --plCgYlfOmdnx8632-- From xen-devel-bounces@lists.xenproject.org Tue Sep 06 12:39:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 12:39:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399835.641173 (Exim 4.92) (envelope-from ) id 1oVXrd-0002zr-4B; Tue, 06 Sep 2022 12:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399835.641173; Tue, 06 Sep 2022 12:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXrd-0002zk-1U; Tue, 06 Sep 2022 12:39:37 +0000 Received: by outflank-mailman (input) for mailman id 399835; Tue, 06 Sep 2022 12:39:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXrb-0002ze-TH for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 12:39:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXrb-0002zg-LS; Tue, 06 Sep 2022 12:39:35 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVXrb-0002mD-F2; Tue, 06 Sep 2022 12:39:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=eAuUBNTrdBVz7mvSFnLRVmufW2c9OSXvJBk9rWNvNgU=; b=oPD8rRl4MSXr4fjmXlu6xfDomP n7gevLEEvhXuFOhklaN56eEfupK6QYSq/Ytd3akMWNzyFPiXy3/4/Eo6WspQostdVMLBsEIhT2WsW hO2Xoqz+74XaRRojgRBgVW3rR5FL32t2Sbyrd2N71EpG60cQ1eX/BBsc8XldGGgvJnZY=; Message-ID: <60a55b4b-4bf5-7325-e603-6abdc56234e3@xen.org> Date: Tue, 6 Sep 2022 13:39:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-4-Henry.Wang@arm.com> <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 06/09/2022 12:11, Henry Wang wrote: >> -----Original Message----- >> From: Julien Grall >>>>> + { >>>>> + bank_start = bootinfo.reserved_mem.bank[i].start; >>>>> + bank_size = bootinfo.reserved_mem.bank[i].size; >>>>> + bank_end = bank_start + bank_size; >>>>> + >>>>> + if ( bank_size < size ) >>>>> + continue; >>>>> + >>>>> + aligned_end = bank_end & ~(align - 1); >>>>> + aligned_start = (aligned_end - size) & ~(align - 1); >>>> >>>> I find the logic a bit confusing. AFAIU, aligned_start could be below >>>> the start of the RAM which is not what I would usually expect. >>> >>> Yeah I understand your concern. Here I want to make sure even if >>> the given size is not aligned (although less likely happen in real life >>> given the size calculation logic in setup_mm) the code still work. >> > > Sorry I probably explained in the wrong way in previous mail, but since no > change requested here this is purely for discussion. In the code we > are sure aligned_end calculation will make sure the end address will > satisfy the alignment requirement within the range to a aligned (lower) > address. The aligned_start = (aligned_end - size) & ~(align - 1) will make > sure the start address is following the same alignment requirement, but > the only issue would be in this case the start address will below the region > start, hence the if ( aligned_start > bank_start ) check. > >> I don't think I agree on the less likely here. The regions are provided >> by in the Device-Tree. And there are more chance they are incorrect >> because the value will be specific to a software/device stack. >> >> Related to this discussion, I can't find any alignment requirement in >> the device-tree binding. I think we at least want to require 64KB >> aligned (so the same Device-Tree works if we were going to support 64KB >> page granularity). > > I agree we need to require 64KB alignment, and currently we are following > this because we are doing 32MB alignment. Hmmm... I think we are talking about two different things here. What I am referring to is the alignment of the start/end of the region provided by the admin. [...] >> I think the code should be moved in populate_boot_allocator(): >> >> if ( bootinfo.reserved_heap ) >> { >> for ( ...; i < bootinfo.reserved_mem.nr_banks; i++ ) >> [....] >> init_boot_pages_pages() >> } >> >> Note that to handle arm32, you will also need to exclude the xenheap area. > > When I implement the code, I found that the arm32 Xenheap excluding logic > somehow can be reused. > > So I think I tried to reuse as much as current code. Would below > populate_boot_allocator() seem ok to you? I would prefer if they are separate because the logic can be simplified when using the static heap (the xenheap cannot across a region). Something like: for ( i = 0; i < banks->nr_banks; i++ ) { #ifdef CONFIG_ARM_32 if ( (bank_start >= mfn_to_maddr(direct_mfn_start) && bank_end < mfn_to_maddr(direct_mfn_start) ) { /* Add the memory *before* and *after* the region */ } else #endif init_boot_pages(s, e); } > > static void __init populate_boot_allocator(void) > { > unsigned int i; > const struct meminfo *banks = bootinfo.static_heap ? > &bootinfo.reserved_mem : &bootinfo.mem; > > for ( i = 0; i < banks->nr_banks; i++ ) > { > const struct membank *bank = &banks->bank[i]; > paddr_t bank_end = bank->start + bank->size; > paddr_t s, e; > > if ( bootinfo.static_heap && bank->type != MEMBANK_STATIC_HEAP ) > continue; > > s = bank->start; > while ( s < bank_end ) > { > paddr_t n = bank_end; > > if ( bootinfo.static_heap ) > e = bank_end; > else > { > e = next_module(s, &n); > > if ( e == ~(paddr_t)0 ) > e = n = bank_end; > > /* > * Module in a RAM bank other than the one which we are > * not dealing with here. > */ > if ( e > bank_end ) > e = bank_end; > } > > #ifdef CONFIG_ARM_32 > /* Avoid the xenheap */ > if ( s < mfn_to_maddr(directmap_mfn_end) && > mfn_to_maddr(directmap_mfn_start) < e ) > { > e = mfn_to_maddr(directmap_mfn_start); > n = mfn_to_maddr(directmap_mfn_end); > } > #endif > > if ( bootinfo.static_heap ) > init_boot_pages(s, e); > else > fw_unreserved_regions(s, e, init_boot_pages, 0); > > s = n; > } > } > } > > Kind regards, > Henry > >> >> Cheers, >> >> -- >> Julien Grall -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 12:44:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 12:44:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399840.641184 (Exim 4.92) (envelope-from ) id 1oVXwh-0004PX-Nu; Tue, 06 Sep 2022 12:44:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399840.641184; Tue, 06 Sep 2022 12:44:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXwh-0004PQ-Jy; Tue, 06 Sep 2022 12:44:51 +0000 Received: by outflank-mailman (input) for mailman id 399840; Tue, 06 Sep 2022 12:44:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXwg-0004P1-DP for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 12:44:50 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1cf9f6f-2de1-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 14:44:49 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id qh18so22943676ejb.7 for ; Tue, 06 Sep 2022 05:44:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1cf9f6f-2de1-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=rN9vuEwRmPXxjRLgmgDthD3o4h45nfJ/Z2SWmvqCzvE=; b=ZnCPS5GzngMOwDnp6lSRawqA3KM7AcZCcq+lu0rJSqCXXCWqvHtiqhnv8plweBiK5X +8tJQqEPpaVbWK0SSm9RM3q7eQptaBzJS4nUIw2Vg3rhAhNLm5ioHnQnuwQwhukKZ0JV x2slmuh1dzAXwhdPoSn1Rs3J1m/YoU5ffK4FZl203sUBfCD9DsPzZYbcyKfhN0fzu66n YHP0TIZWTVY3h/NloZ/Ae64onSSep83mu6AHyhWvKvwbBvr8/ZPdkD1z56HU6JOy2Ykz ZWu5+HPBq5f/M6ap3Wz/ng8VL/XTf0W6CfXApbS1BdOfB8tw28Wn/tZtl4vQeS2QvpXP Ix4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=rN9vuEwRmPXxjRLgmgDthD3o4h45nfJ/Z2SWmvqCzvE=; b=jgbAWYcc7fd8mgE54rog8M4T35/+OgFBTNHD90Cn7IcUV1fRpizHLKResK+p+kfKCQ tTIM9Q/EvNGOe34I56VGXbPtcBHcJSQ9h6WPMW86C/QMcNe0N5eqXwBOQY+x5LnaKV5T X/nDS8w8NgqaISYMQZqnbZIoCxZDO1sK8vi8OxqjOVccLEWA+GPhmOpmnYvznH/ydtDr jYZxvnau+jd3gKm9cFwsvxYCIhnZwN9/LGV3V7AJOCvn9eu5n3AppXPK7slticiacJOB 6D9XyWNmJg4D+XHn+R/DqzRZYU82yzZiHb4rrc8i/gUZB67u8Hj0PJuN7eu9BTi4VAl6 alZw== X-Gm-Message-State: ACgBeo2eHniJ2byn1mAZPtd/ehtdOhb+BbFjMi15A45MRtikMLMbB0WD blqaZaA8AZzDHBlnr8W8G7ihK6nCa2oVpizWI7o= X-Google-Smtp-Source: AA6agR5IZ96LOZgvtvBE42jEneUzt1xYT+3KfILgLOiJahc/ui/Y/+eZkjODozMgv/B1b1siUENe1fm4TCNU7rIYEFM= X-Received: by 2002:a17:907:272a:b0:741:8105:49e2 with SMTP id d10-20020a170907272a00b00741810549e2mr29379893ejl.171.1662468288887; Tue, 06 Sep 2022 05:44:48 -0700 (PDT) MIME-Version: 1.0 References: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> In-Reply-To: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> From: Jason Andryuk Date: Tue, 6 Sep 2022 08:44:37 -0400 Message-ID: Subject: Re: [PATCH 1/2] vchan-socket-proxy: add reconnect marker support To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: xen-devel , Wei Liu , Anthony PERARD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 5, 2022 at 9:50 AM Marek Marczykowski-G=C3=B3recki wrote: > > When vchan client reconnect quickly, the server may not notice it. This > means, it won't reconnect the UNIX socket either. For QMP, it will > prevent the client to see the QMP protocol handshake, and the > communication will timeout. > Solve the issue by sending in-band connect marker. Whenever server sees > one (elsewhere than the first byte in the connection), handle it as a > client had reconnected. The marker is a one byte, and the user need to > choose something that doesn't appear in the data stream elsewhere. > > Signed-off-by: Marek Marczykowski-G=C3=B3recki Reviewed-by: Jason Andryuk Here are some of my thoughts on the correctness of this approach: The QMP data is json - ascii (utf-8?) - so using \x01 is fine as it won't be in the data stream. The dropping of any partial message works since the close and re-open of the QMP socket resets the data stream. There shouldn't be any partial data in vchan-socket-proxy to drop since the client side should not have sent any new data before it closed and re-opened. If there is partial data, we shouldn't send it into QEMU since the new QMP client isn't expecting any response it would generate. So that all seems okay. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Sep 06 12:45:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 12:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399844.641195 (Exim 4.92) (envelope-from ) id 1oVXx7-0004sA-Vs; Tue, 06 Sep 2022 12:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399844.641195; Tue, 06 Sep 2022 12:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXx7-0004s1-Sj; Tue, 06 Sep 2022 12:45:17 +0000 Received: by outflank-mailman (input) for mailman id 399844; Tue, 06 Sep 2022 12:45:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVXx6-0004P1-J0 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 12:45:16 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c19d80d8-2de1-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 14:45:15 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id s11so14958117edd.13 for ; Tue, 06 Sep 2022 05:45:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c19d80d8-2de1-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=4DOqWL/NrWGyyVP3oVT57noS3Z8hwqwZyoQH9c98O4M=; b=jJUxnvsIVLfOGYMFcrdetJoU2ApbsTJj+gPEu4jU+kQTIOQmqDg1EK6H/SoFfR0lP/ aSJU3gD4FJh8Uh5N3kam1blmqKBvP3GPoI0+S3sv9O6IBlFGG7NPf8tRQ+sFkyEykCX6 kEwbOvDVsQd32bFrLwJO+bajiNs5lG0ChNNJiS9pMzMxzJKn/MZgTJi3sB+Jxk86uU6v XIps+b3Ko+rQULtfGP6jeODb7DGehl2CgXuKVEqSkepc4WA5WqjNqm3ndLssyPSjhdAp HYlqPsSKwUth3MxF/mNvy1cGoEonYhKKFDGyNGkR70JqshwalTx9LZjSdFtxWeaWROCr Bsmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=4DOqWL/NrWGyyVP3oVT57noS3Z8hwqwZyoQH9c98O4M=; b=Aq+9Iaf3BBenGHog9hpvsAEqgYVgx+/MejuUipHeY6V52mMuPTHLgNeJszXozWEcZG mVdk2keefmE/1Cl47vbacWZysurmpqmKAPCdJgBXtOrr8OziGFZgqZPwm5co6TthcRDS 4mFEVIqGwaUJuy7We3m7MnVnJBIwUFVbYqu/WPUe4RSIFeZgHJj2Fg1aRSAlHshrMFI/ acmmKz2CIVCexQ0bp2nr9xZNcNHldrADXyTJlxMFaffmjC98F36CPIC47rb7O/3i3Rpv rL+lsebZbKzRyJgAheXX9emAwz8cehc28JqElRBMdEzuGmZIAlcoW8uffvsQGoL9Lc83 nS+w== X-Gm-Message-State: ACgBeo03R2tsW2KFKPL5+no4A5OIIiOEuu3X+1iXLWn69XBgkzllCZu4 Payd7mpLQ7CNxFnQLMSIUWEkNIVl7OlE25FHtxzrMGmooZw= X-Google-Smtp-Source: AA6agR7AQZsgLNazH+wMJwXhZNHf4xdM4OJP1uO9fmFzQ10DrHFBE+q1/7PU7ak1NeoTKbofVcbL35+vrrJmvkKbl88= X-Received: by 2002:a05:6402:518b:b0:448:f30:38b0 with SMTP id q11-20020a056402518b00b004480f3038b0mr40593574edd.164.1662468315457; Tue, 06 Sep 2022 05:45:15 -0700 (PDT) MIME-Version: 1.0 References: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> <20220905135019.3749982-2-marmarek@invisiblethingslab.com> In-Reply-To: <20220905135019.3749982-2-marmarek@invisiblethingslab.com> From: Jason Andryuk Date: Tue, 6 Sep 2022 08:45:04 -0400 Message-ID: Subject: Re: [PATCH 2/2] tools/libxl: enable in-band reconnect marker for stubdom QMP proxy To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: xen-devel , Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 5, 2022 at 9:50 AM Marek Marczykowski-G=C3=B3recki wrote: > > This enables stubdom reliably detect when it needs to reconnect QMP > socket. It is critical, as otherwise QEMU will not send its handshake, > and so libxl will timeout while waiting on one. When it happens during > domain startup, it can result in error like this: > > libxl: libxl_pci.c:1772:device_pci_add_done: Domain 3:libxl__device_pci_a= dd failed for PCI device 0:0:14.0 (rc -9) > libxl: libxl_create.c:1904:domcreate_attach_devices: Domain 3:unable to a= dd pci devices > > See vchan-socket-proxy commit message for details about this reconnect > corner case. > > Stubdomain side needs to use --reconnect-marker=3D1 option too. > > Signed-off-by: Marek Marczykowski-G=C3=B3recki Reviewed-by: Jason Andryuk From xen-devel-bounces@lists.xenproject.org Tue Sep 06 12:52:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 12:52:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399850.641206 (Exim 4.92) (envelope-from ) id 1oVY4E-0006SR-P3; Tue, 06 Sep 2022 12:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399850.641206; Tue, 06 Sep 2022 12:52:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVY4E-0006SK-MB; Tue, 06 Sep 2022 12:52:38 +0000 Received: by outflank-mailman (input) for mailman id 399850; Tue, 06 Sep 2022 12:52:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVY4D-0006SA-Vq; Tue, 06 Sep 2022 12:52:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVY4D-0003DV-RO; Tue, 06 Sep 2022 12:52:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVY4D-0006yk-Aj; Tue, 06 Sep 2022 12:52:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVY4D-0000Yz-A7; Tue, 06 Sep 2022 12:52:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=20kBTYt/iN+6f9WDcwKl35Hul4yQSHVIZO1kaEt3BIU=; b=vcIrXd/iXjhVuwbzcVIEHqnv5i SnEPZZZhC/yTEBh107nPaZl29LOhePQIJg4YjolB3iPPocC6B5sbbrLM2NZhr00E2Pd9MjTOnGcwF 8ogYKuRu77zq0lRLheJNdvOE801F+vUXHX81hgk2rKbtskS9hSQDiHFbfam4eWqtrfrY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173017: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-pvops:kernel-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=4a95d1ede45738d1c2fad0af36da962be9440a98 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 06 Sep 2022 12:52:37 +0000 flight 173017 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173017/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-pvops 6 kernel-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 4a95d1ede45738d1c2fad0af36da962be9440a98 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 788 days Failing since 151818 2020-07-11 04:18:52 Z 787 days 769 attempts Testing same since 173017 2022-09-06 04:23:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121866 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:03:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:03:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399858.641217 (Exim 4.92) (envelope-from ) id 1oVYEm-00089A-UK; Tue, 06 Sep 2022 13:03:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399858.641217; Tue, 06 Sep 2022 13:03:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYEm-000893-RA; Tue, 06 Sep 2022 13:03:32 +0000 Received: by outflank-mailman (input) for mailman id 399858; Tue, 06 Sep 2022 13:03:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYEl-00088t-PO; Tue, 06 Sep 2022 13:03:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYEl-0003RN-KC; Tue, 06 Sep 2022 13:03:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYEl-0007UV-5G; Tue, 06 Sep 2022 13:03:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVYEl-0006Pi-4n; Tue, 06 Sep 2022 13:03:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TJ/HYreF6iQ5r/fieQ8ZsITBw4h5EwbtKpd73jb1RhA=; b=0WdphUHcwXNwQKEQBn3pL6AsiN yg6DeAmNIfBQzawb2nCm6PGqAskoVQOc3v3NTREffyh5/CHh4NgfOnA49DJJCGbxn+0Jg20wfmYbL ge+MMuREG96vMDuj6e6moJZr99JBefpYRxBYpJi7VnIAGBTi3YxOo4PEdDLKWmWjifO0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173015: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=53e99dcff61e1523ec1c3628b2d564ba15d32eb7 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Tue, 06 Sep 2022 13:03:31 +0000 flight 173015 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173015/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-pvops 6 kernel-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 53e99dcff61e1523ec1c3628b2d564ba15d32eb7 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 33 days Failing since 172152 2022-08-05 04:01:26 Z 32 days 74 attempts Testing same since 173015 2022-09-06 02:36:14 Z 0 days 1 attempts ------------------------------------------------------------ 1699 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 174895 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:03:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:03:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399861.641228 (Exim 4.92) (envelope-from ) id 1oVYEz-0008RS-6E; Tue, 06 Sep 2022 13:03:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399861.641228; Tue, 06 Sep 2022 13:03:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYEz-0008RL-30; Tue, 06 Sep 2022 13:03:45 +0000 Received: by outflank-mailman (input) for mailman id 399861; Tue, 06 Sep 2022 13:03:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYEx-0008Qo-BN for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 13:03:43 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5397ab2a-2de4-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 15:03:41 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1662469413122228.98779621741687; Tue, 6 Sep 2022 06:03:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5397ab2a-2de4-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; t=1662469415; cv=none; d=zohomail.com; s=zohoarc; b=dQNZZNMBVGr0ay2duC2LgqAUT5e36Y/hY0tCQd1fCm1NBGAs1m9f8tdWdsnbqUtD2I5GFz68OHTRyB835JA+cpB+6xpDeffjV5bScaVL6B+8N01Ak+zZM5CrRN5BMz2ZA9KzxnkPmW4sXlsiZ4DZz5m7SiMGBA1m8YFH1szodR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662469415; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=R8Vmmbujb9hQkdWWvzPye+jAnykUiJ8pcszJcQ2IX64=; b=k++Glc7bTZWx+RbgMkLSI1IHy/iiP4amJVo5zTbml88hwJO2EEyq3s4lKGmtylMjQoiUAf/n1HepFWCetOeirZ24VpIAzIkqEafZsyiycPamqJ7Xh/gqGJWJ7Qr2vWd4T76w9V/ifaQqgfI/Qa5vfFKcKubdYb2lrH166WQA5bM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662469415; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=R8Vmmbujb9hQkdWWvzPye+jAnykUiJ8pcszJcQ2IX64=; b=bMrKlsk6VkyVfymQqUcRjcVkMKBacARnxBA3l+Zr/9Mf/W2bMitI/uw6V9P19Xrw u4nl80mqfm6nTlwXbluc7SL2oU8RtJwVOwfkJRW/gzuz9fZuXV0RVrFSWzO7ZG6WdAV R65Jsz9XwDXWoBFJmiqO3TBZ5NTDLxemWmwiHTjI= Message-ID: <582d350e-938e-b53b-a7fd-56625437fe91@apertussolutions.com> Date: Tue, 6 Sep 2022 09:03:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Jason Andryuk , Jennifer Herbert Cc: Jan Beulich , Andrew Cooper , Wei Liu , Roger Pau Monne , Ian Jackson , xen-devel References: <20220830202706.1618386-1-jennifer.herbert@citrix.com> From: "Daniel P. Smith" Subject: Re: [PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable. In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 9/1/22 08:55, Jason Andryuk wrote: > On Tue, Aug 30, 2022 at 4:30 PM Jennifer Herbert > wrote: >> >> This patch introduces an optional TPM 2 interface definition to the ACPI table, >> which is to be used as part of a vTPM 2 implementation. >> To enable the new interface - I have made the TPM interface version >> configurable in the acpi_config, with the default being the existing 1.2.(TCPA) >> I have also added to hvmloader an option to utilise this new config, which can >> be triggered by setting the platform/tpm_verion xenstore key. >> >> Signed-off-by: Jennifer Herbert > > Reviewed-by: Jason Andryuk > > Thanks. > > Is there a particular reason why CRB (Command Response Buffer) was > chosen over TIS (TPM Interface Specification)? I think of CRB as more > of an embedded device TPM interface, and TIS is what is usually used > with physical TPMs. My experiences have only been with TIS devices, > so that is influencing my outlook. Hmm, this patch seems to reference > the Intel Platform Trust Technology (PTT) fTPM (firmware-TPM) as using > the CRB interface: > https://patchwork.kernel.org/project/tpmdd-devel/patch/1417672167-3489-8-git-send-email-jarkko.sakkinen@linux.intel.com/ > If PTT fTPMs are using CRB, then it's more than just embedded > devices.. This continues to create much confusion. There are two CRB interfaces, one is the PC Client CRB interface defined in the TCG PTP specification, which is based on an MMIO HW interface. There are claims that Intel's PTT provided one, but I myself have never seen an MMIO CRB in the wild. Then there is the Mobile CRB specification, which defines a mailbox/doorbell HW interface, particularly for Arm devices. The Mobile CRB interface has no notion of locality. As a result, there are ongoing discussions on how the specifications may be normalized and enable locality support for a mailbox/doorbell HW interface to support the recent Arm DRTM specification. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:39:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399869.641239 (Exim 4.92) (envelope-from ) id 1oVYno-0003qP-TO; Tue, 06 Sep 2022 13:39:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399869.641239; Tue, 06 Sep 2022 13:39:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYno-0003qI-Q1; Tue, 06 Sep 2022 13:39:44 +0000 Received: by outflank-mailman (input) for mailman id 399869; Tue, 06 Sep 2022 13:39:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYnm-0003qC-Qv for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 13:39:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5b683a1a-2de9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 15:39:40 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E9021A2D; Tue, 6 Sep 2022 06:39:46 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 534543F7B4; Tue, 6 Sep 2022 06:39:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b683a1a-2de9-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com Subject: [PATCH v4 0/7] xen/evtchn: implement static event channel signaling Date: Tue, 6 Sep 2022 14:39:22 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The purpose of this patch series is to add the static event channel signaling support to Xen on Arm based on design doc [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg01160.html Julien Grall (1): xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Rahul Singh (5): xen/evtchn: restrict the maximum number of evtchn supported for domUs xen/evtchn: modify evtchn_alloc_unbound to allocate specified port xen/evtchn: modify evtchn_bind_interdomain to support static evtchn xen/arm: introduce new xen,enhanced property value xen/arm: introduce xen-evtchn dom0less property Stanislav Kinsburskii (1): xen/evtchn: Add an helper to reserve/allocate a port docs/misc/arm/device-tree/booting.txt | 102 ++++++++++++++++ xen/arch/arm/domain_build.c | 167 +++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 23 +++- xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 2 + xen/common/event_channel.c | 121 ++++++++++++------- xen/include/xen/device_tree.h | 16 +++ xen/include/xen/event.h | 8 +- 8 files changed, 387 insertions(+), 53 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:41:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399873.641250 (Exim 4.92) (envelope-from ) id 1oVYpb-0005BR-9B; Tue, 06 Sep 2022 13:41:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399873.641250; Tue, 06 Sep 2022 13:41:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYpb-0005BK-4b; Tue, 06 Sep 2022 13:41:35 +0000 Received: by outflank-mailman (input) for mailman id 399873; Tue, 06 Sep 2022 13:41:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYpa-0005BE-Lm for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 13:41:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9ea8b979-2de9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 15:41:33 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 068B61A32; Tue, 6 Sep 2022 06:41:39 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 68E1C3F7B4; Tue, 6 Sep 2022 06:41:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ea8b979-2de9-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Stanislav Kinsburskii , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v4 2/7] xen/evtchn: Add an helper to reserve/allocate a port Date: Tue, 6 Sep 2022 14:40:40 +0100 Message-Id: <30832afe5dfe3a1b350c26e40a5c5fbcb93b8c57.1662462034.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stanislav Kinsburskii In a follow-up patch we will want to either reserve or allocate a port for various event channel helpers. A new wrapper is introduced to either reserve a given port or allocate a fresh one if zero. Take the opportunity to replace the open-coded version in evtchn_bind_virq(). Signed-off-by: Stanislav Kinsburskii Signed-off-by: Julien Grall Signed-off-by: Rahul Singh Acked-by: Jan Beulich --- Changes in v4: - Change the Author to Stanislav Kinsburskii Changes in v3: - minor comments in commit msg Changes in v2: - new patch in this version --- xen/common/event_channel.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index f81c229358..565ab71881 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -305,6 +305,18 @@ void evtchn_free(struct domain *d, struct evtchn *chn) xsm_evtchn_close_post(chn); } +static int evtchn_get_port(struct domain *d, evtchn_port_t port) +{ + int rc; + + if ( port != 0 ) + rc = evtchn_allocate_port(d, port); + else + rc = get_free_port(d); + + return rc ?: port; +} + int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) { struct evtchn *chn; @@ -462,19 +474,10 @@ int evtchn_bind_virq(evtchn_bind_virq_t *bind, evtchn_port_t port) if ( read_atomic(&v->virq_to_evtchn[virq]) ) ERROR_EXIT(-EEXIST); - if ( port != 0 ) - { - if ( (rc = evtchn_allocate_port(d, port)) != 0 ) - ERROR_EXIT(rc); - } - else - { - int alloc_port = get_free_port(d); - - if ( alloc_port < 0 ) - ERROR_EXIT(alloc_port); - port = alloc_port; - } + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; chn = evtchn_from_port(d, port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:41:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:41:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399877.641261 (Exim 4.92) (envelope-from ) id 1oVYpz-0005e9-Fq; Tue, 06 Sep 2022 13:41:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399877.641261; Tue, 06 Sep 2022 13:41:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYpz-0005e0-Cm; Tue, 06 Sep 2022 13:41:59 +0000 Received: by outflank-mailman (input) for mailman id 399877; Tue, 06 Sep 2022 13:41:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYpy-0005BE-KA for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 13:41:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ad33ea26-2de9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 15:41:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 505E51A2D; Tue, 6 Sep 2022 06:42:03 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 114ED3F7B4; Tue, 6 Sep 2022 06:41:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad33ea26-2de9-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel Subject: [PATCH v4 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Date: Tue, 6 Sep 2022 14:40:41 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Set the default value of max_evtchn_port to 1023. The value of 1023 should be sufficient for domUs guests because on ARM we don't bind physical interrupts to event channels. The only use of the evtchn port is inter-domain communications. Another reason why we choose the value of 1023 to follow the default behavior of libxl. Signed-off-by: Rahul Singh Reviewed-by: Michal Orzel --- Changes in v4: - fix minor comments in commit msg - Added Michal Reviewed-by Changes in v3: - added in commit msg why we set the max_evtchn_port value to 1023. - added the comment in code also why we set the max_evtchn_port to 1023 - remove the define and set the value to 1023 in code directly. Changes in v2: - new patch in the version --- xen/arch/arm/domain_build.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..fde133cd94 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3277,7 +3277,13 @@ void __init create_domUs(void) struct xen_domctl_createdomain d_cfg = { .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - .max_evtchn_port = -1, + /* + * The default of 1023 should be sufficient for domUs guests + * because on ARM we don't bind physical interrupts to event + * channels. The only use of the evtchn port is inter-domain + * communications. + */ + .max_evtchn_port = 1023, .max_grant_frames = -1, .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399886.641272 (Exim 4.92) (envelope-from ) id 1oVYrJ-0006R7-TI; Tue, 06 Sep 2022 13:43:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399886.641272; Tue, 06 Sep 2022 13:43:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYrJ-0006R0-QJ; Tue, 06 Sep 2022 13:43:21 +0000 Received: by outflank-mailman (input) for mailman id 399886; Tue, 06 Sep 2022 13:43:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYrI-0006Qo-3G for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 13:43:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id dd7f1455-2de9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 15:43:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 673D11A32; Tue, 6 Sep 2022 06:43:24 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 424C83F7B4; Tue, 6 Sep 2022 06:43:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd7f1455-2de9-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value Date: Tue, 6 Sep 2022 14:40:44 +0100 Message-Id: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to disable xenstore interface for dom0less guests. Signed-off-by: Rahul Singh --- Changes in v4: - Implement defines for dom0less features Changes in v3: - new patch in this version --- docs/misc/arm/device-tree/booting.txt | 4 ++++ xen/arch/arm/domain_build.c | 10 ++++++---- xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- 3 files changed, 31 insertions(+), 6 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..1b0dca1454 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -204,6 +204,10 @@ with the following properties: - "disabled" Xen PV interfaces are disabled. + - no-xenstore + Xen PV interfaces, including grant-table will be enabled but xenstore + will be disabled for the VM. + If the xen,enhanced property is present with no value, it defaults to "enabled". If the xen,enhanced property is not present, PV interfaces are disabled. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 707e247f6a..0b164ef595 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) goto err; } - if ( kinfo->dom0less_enhanced ) + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) { ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); if ( ret ) @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *d, (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) { if ( hardware_domain ) - kinfo.dom0less_enhanced = true; + kinfo.dom0less_feature = DOM0LESS_ENHANCED; else - panic("Tried to use xen,enhanced without dom0\n"); + panic("At the moment, Xenstore support requires dom0 to be present\n"); } + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) + kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; if ( vcpu_create(d, 0) == NULL ) return -ENOMEM; @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, if ( rc < 0 ) return rc; - if ( kinfo.dom0less_enhanced ) + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) { ASSERT(hardware_domain); rc = alloc_xenstore_evtchn(d); diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index c4dc039b54..ad240494ea 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -9,6 +9,25 @@ #include #include +/* + * List of possible features for dom0less domUs + * + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. All the + * default features (excluding Xenstore) will be + * available. Note that an OS *must* not rely on the + * availability of Xen features if this is not set. + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature + * can't be enabled without the + * DOM0LESS_ENHANCED_NO_XS. + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the + * default features (including Xenstore) will be + * available. Note that an OS *must* not rely on the + * availability of Xen features if this is not set. + */ +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) +#define DOM0LESS_XENSTORE BIT(1, U) +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XENSTORE) + struct kernel_info { #ifdef CONFIG_ARM_64 enum domain_type type; @@ -36,8 +55,8 @@ struct kernel_info { /* Enable pl011 emulation */ bool vpl011; - /* Enable PV drivers */ - bool dom0less_enhanced; + /* Enable/Disable PV drivers interface,grant table, evtchn or xenstore */ + uint32_t dom0less_feature; /* GIC phandle */ uint32_t phandle_gic; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 13:46:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 13:46:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399893.641282 (Exim 4.92) (envelope-from ) id 1oVYtw-00075L-BU; Tue, 06 Sep 2022 13:46:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399893.641282; Tue, 06 Sep 2022 13:46:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYtw-00075E-8I; Tue, 06 Sep 2022 13:46:04 +0000 Received: by outflank-mailman (input) for mailman id 399893; Tue, 06 Sep 2022 13:46:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVYtu-00074g-FT for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 13:46:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3dc6a792-2dea-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 15:46:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3836.eurprd04.prod.outlook.com (2603:10a6:8:f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 13:45:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 13:45:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dc6a792-2dea-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAK2cknF+APzDmk46xbDggNy6ljcyNYps9PQ5OyHUMGZPJrPbGfNgEWgq0H/qHyhm8p5ExMQBZAKQHsCa6knZVxp0NOqBPamhhyzcb+CfcEZFnyfwTqWaywQirKMLIB3436EujGLHVjvHRu+ct0T5CdC9DGjmBJ9EZ3KjjPy2hCH+ATlPyvOVCRPp3l6aCXx2BxP/mRWs4ChINW6swcasblC2XXKwEBUbllBbpgup9mVc1a1YhuEWDub23fcPKIoad6hKYLFISSKxmN5cqo4VgdqMYSTXCOEyRF7pGeKD0IBuhZMI0j5MGKlBwX2rYab5c719EZu+HOj7j+/Sx0YIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GGXccUyWSLHz6EGoEyQUK+LDy6zqf2bKneLndoVOg50=; b=bxxHTDGEDKlR6dZ2rBHc31BL2L8lbwN3b4fpz/JMVrlenIGXcd50umIOL5WoW8Ug1Rpw53aYx4K5Yt5II3Zq4YCNZBkVovgtT9vI/gAOmjHEk7SEZoc1MslhsuZ1SGuPbYBt9zlSJ0lk8zQdFv60jf9kEbMeoWkAzLB2id3NuJyUkrVSG0Z1VeDYhRQyxAIOHTtd3U4huqDEVZZi7rxDRRHm5TzDxlu+P0wZ+AAJYoXXNDK7n+f7SMoYKEpLO8p2esECIn3DQojE0IarogekktbWTPFVQ33Wuoqr2tVp08dY6sd5amztM+lpbRUbsWlEsHOVOStHrd7iSRYAr/Bbjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GGXccUyWSLHz6EGoEyQUK+LDy6zqf2bKneLndoVOg50=; b=37PM90K4r106L9xn4LZjVHbd5WO8wmuwJBa4a7q/brIUWbIJM4roucSnM5NpM56IxfWQU4b9xNfRZhcWHIsJxv1jyHgkDZSRYme9LQ8AulAMTOB7kBNqYI53x16a0604V+kg3HnjMhWmYbOeTcq94gm6lgGcuNSPS4uEvm67Sd6xHD1wq1ZQUfsM+YfmTqJYpUFHwwhEBRXVbwXK+AI1t3WE6c3E4hZWZS13dURdcigjwnwpHliFwBZmYrjMNSseu+MMZMZ11wouDSFJ4gXv6cKFSvf1gefiz0WKwsu0xSbFGro1gUQ/ke9diN1QVVlS3BNUd3unN/FxMe9fV16Gdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <16e6c4e9-ea98-aae1-d3cc-1f46e979d642@suse.com> Date: Tue, 6 Sep 2022 15:45:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Content-Language: en-US To: Rahul Singh Cc: Julien Grall , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Michal Orzel , xen-devel@lists.xenproject.org References: <80a13d3afcd46ecfb94a919fa0a8cf2bbd3be0a8.1662462034.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <80a13d3afcd46ecfb94a919fa0a8cf2bbd3be0a8.1662462034.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2c61abe-6699-471b-ea0a-08da900e2079 X-MS-TrafficTypeDiagnostic: DB3PR0402MB3836:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RmYrqG8dvUNwGUVrWeyIshiqzonQLfa2pPiMHUFfba8QHy1lr8sgzeLJj14vEEEHGgrI2Gw8BdmcnuOIHdx44DAN6v0wDgX04/u78mK+F1MhjwR7Bl0GdegqaarwEr5pp8mS/mdomUC5drVId5x5qMyKW5V4UQI0Wacf4/jOw4DoQDSj0wJIPgA2CZWiQFkp1ifSqfiJbmocihL/unPI4tf9/HfJ1pGMHA8nIdtDIOIjO3bWExjdA70WmH5KAhSF3mFTnpxzvM4vpzlec/K7zE5rmAj8OsJ4DKq++Bhy0ElsJ1MYPTag8K6JbegUS5rvHHwRDbXwZoE+JI9nniwCWgct2Q0iccKDAvmbXLe9LqBoK0K5kSoHy/4l8wWSui98b1Ydh5/NrDonMFn0IX1YdXEnmAfzYhjbU7UzlFrFVZQmZqoRZt8lYVJIsQazF0tMmtr2APmPclgCbwHE+ZaV8IcLba99gm81/KwHcDeK92I/ENBhAkx1ETQH3k27/CyGsKWQ+YppgmYlCCZDWKVfK5RSQyuuS/qFiJuLvfSoXV7lVaEpwBwKQpXZ1Yv7vEkQneMx33GV7RxO7XIa//O46J28CiFyiqnAl/T8TVKPHV7ZwQFlGZY20HOptIgceDzy7o48Jxd1XzcQNHLqclhHbJhjbGg+88ccYWU1sCfgvFX9wxC0fkrEn872Q/SgeqQDivC/Q3xbyNt4uKG2S9Yr36TdBIUx1RA2NvT9dG/KRgw5NNii/mRqm1XD+ftyWkcR+uGiY/UfC5iDxXwVLe+rJLtWDw68QAfqIDpFXQ7cUH8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(136003)(376002)(346002)(366004)(31686004)(83380400001)(316002)(6916009)(26005)(6506007)(6512007)(54906003)(53546011)(36756003)(8936002)(86362001)(5660300002)(478600001)(31696002)(2906002)(66556008)(4326008)(66476007)(8676002)(66946007)(186003)(41300700001)(2616005)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFZUR1lkc2hsZCtvQS9oOVBvbnIvN3V6VTllaU54SUttU1M3ZFBmWmxXM0hU?= =?utf-8?B?VzM1MkZ2ZS9rREVhOEhhSzFDVTgyR1Q4RWdpTk9mMDhSQ2p4SXNNVDlNRW9W?= =?utf-8?B?UkxiWkFXU1d6WkhNMDlZb0M2MS9WYzl3U2V1K09SRVYxZDZPL3Z2Wk5ETEF2?= =?utf-8?B?ZitzUVBZQlB5U0h3d0xJWUxwWUkzREQyODJ1NDZLOUI0V084T3IwV2lHYXdS?= =?utf-8?B?RStaQitxVkxpUnFPSU5ZNHV6TkRIckF2ZERYbWFFeTh4VnJxMXh4VlFJeHpX?= =?utf-8?B?cXdjVXc3QWRRRk1yZEtDRVlwTzl1UlZCWVF5R3lOS1k5a21scnFBa1BrTnB0?= =?utf-8?B?aFEyL20yM2hFbEVwdUtjWWdCekFFRGV4L3hIaWo5OHR1d0tqQ3o2aUFxdDg3?= =?utf-8?B?WnIrMGRxMFFtKzFaV3BNMnNzOG1VSDBOeHZYcFJHaTFQL3kxNTZKRXZiT3VW?= =?utf-8?B?UnZMSkxTOTllYmtDS09jZUIwTVNRb3E5bldrK25lc2hzWGhteDR0aXAwRDhY?= =?utf-8?B?S1pDQVROaitqTXEwZkJ3cDhYZFRJSUpPaXkvWGVGeVF3VjFSaDR2UUdXR1Y0?= =?utf-8?B?cDJ1b0NPMjRCT2JVQmp4TlRHdlBGeHRncGF6N0JIeXFWZHJWRWRjUnlseUp6?= =?utf-8?B?OW54dWNMY1BZWkZNMkw1ZG13T2RHWmZXUkhISXpqV0RSMmhkWm16ZHdzcWJQ?= =?utf-8?B?OS9vRWR4SnByKzNZQVV1VnZ2TmhLNTdTTjlISHRGbFN2NWZ2Vi9tSTFDNGlO?= =?utf-8?B?SUNpM0J0cU0vTlkwM0x0S1hYeE9xNk1kalBZZ0VLTGdkWWR0dnM5Mi9idk1X?= =?utf-8?B?NVdSZWxhbW9rQWZBSUVhTFNLODAxNEY0dkdJdSt5cEk0L3dKZlNvbWVTSnNk?= =?utf-8?B?eU1FT1p1VTdWdk5lTmtlWG9nUTVTUVM0Yjg3SGFkSGh1R1drL1lKMDhDK3dq?= =?utf-8?B?L1VaQVNENGg2TW9ZeERCQ2ErakFsUlNlRk02L25xUnZuUG1NQVRuY0RVeG9D?= =?utf-8?B?bnovY3NoR1lPVE8zL2IvTG1rb25BNHFBYnpHNEp5OVQzS2NCQXhsZHkwQmd6?= =?utf-8?B?Vy9GdjdZbTBVZnRZWUtMZmJ4anQ1OVpDZ25RTVp1d2o1OTU4S0hPaTBpL1p3?= =?utf-8?B?ZXVSaDBIb3JZcXFtdTFhdXEzOTlaVFpMZkhEdWJOd2F1Y3p3SHdQbEpmVUxw?= =?utf-8?B?VTVrVFZrNWNZV2xVQ1pBak94emZSanhZamdBcElrVjR0Z21FK1c0NUl5cmU4?= =?utf-8?B?aGd0cjF4c3ltM3Joa01oVEhHVDlZcmxVK2Y2M3F2Tm1kRUdFSk13Z29uR3Yr?= =?utf-8?B?aVlvTEY0Y0tUK1RGZE5IMEpSM2RGTUZnTXdlU0M5UmgraWNualNxUnZkR3Fz?= =?utf-8?B?QTB4bG4ySFQzRFYwcUpZRVdVVXNTOUpPVWdrZkt4TWFVdjlsRzdLSnc2a2Zt?= =?utf-8?B?cVNUUDQ4dmlrZ1lKZVV2czl5YWh4Q3kxbU43NXdOcUhOdFN3Q2NzUWxtQngz?= =?utf-8?B?VjZoeWJMdWQ1MnowajYrZkIxSzBtcllRcmRhbzdsWHdmTHAwb0Q4Z0hpQUN5?= =?utf-8?B?YmpPcWNnNERRWU9LODB4S01WbFp3S0dmRFh5Ry9tdCtHa0NzUU9taXR6Z2Nt?= =?utf-8?B?cE5UbDRRUWYvRWd0RXo2c09EcG0ybm5vTHE1Mmg2bkxlSndtTVd0Sk9HOTJx?= =?utf-8?B?bjRwQ2FUOGdJemlqVG96V3RIOC84c2ZFcHNLTVdldk1QcEp5K3hXd0VQMVhV?= =?utf-8?B?SmYxb01xOUpkTlhKVWpJYjdJWmQ3a05CUTMyRzJicWkwQjhoQ0tsOVV6bXRh?= =?utf-8?B?SnBPN2dLKzZtaHRKUStWWmg3NDlWTE5nNUx5RVI0NkxmSDZGS2ZZWTFSWHM3?= =?utf-8?B?NFZSdzdJaitJRnlVVUIxUzdnZ1lKZ2NOcnhyS1dyM054d1FMbkxTMmpoQTlJ?= =?utf-8?B?b0dJVU1ZNFFxK1hmNjh3Y1NtWnR0VFo5T3FCaW5NVDlWbjRGYndhaDNvSWNU?= =?utf-8?B?YnY5NGp3amdKMVAzZ0dqYk9vRFMwMEhMQVZDSkZtY1NtZWFhZXR4WlByYVFR?= =?utf-8?B?L2NESnV5bTdLTVRZUU1VS2RNNFJsSFVjYjQ0a0FCcisvR1B5SVhmT3ZDUHA1?= =?utf-8?Q?+CHTXNecSGZCPOgpA0d2ckAOX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2c61abe-6699-471b-ea0a-08da900e2079 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 13:45:57.5930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uyduPU+LA4q9ZCwbUSet9FrcPHwrzOnCE7UmcmpVbCvxchpflgFnEFHi3I5nRac0FM2IxYgD2M2DA3/F2E9yyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3836 On 06.09.2022 15:40, Rahul Singh wrote: > From: Julien Grall > > Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event > channels code assumes that all the buckets below d->valid_evtchns are > always allocated. > > This assumption hold in most of the situation because a guest is not > allowed to chose the port. Instead, it will be the first free from port > 0. > > When static event channel support will be added for dom0less domains > user can request to allocate the evtchn port numbers that are scattered > in nature. > > The existing implementation of evtchn_allocate_port() is not able to > deal with such situation and will end up to override bucket or/and leave > some bucket unallocated. The latter will result to a droplet crash if > the event channel belongs to an unallocated bucket. > > This can be solved by making sure that all the buckets below > d->valid_evtchns are allocated. There should be no impact for most of > the situation but LM/LU as only one bucket would be allocated. For > LM/LU, we may end up to allocate multiple buckets if ports in use are > sparse. > > A potential alternative is to check that the bucket is valid in > is_port_valid(). This should still possible to do it without taking > per-domain lock but will result a couple more of memory access. > > Signed-off-by: Julien Grall > Signed-off-by: Rahul Singh > Reviewed-by: Michal Orzel Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Sep 06 14:00:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 14:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399898.641294 (Exim 4.92) (envelope-from ) id 1oVZ7i-000195-La; Tue, 06 Sep 2022 14:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399898.641294; Tue, 06 Sep 2022 14:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZ7i-00018y-Hg; Tue, 06 Sep 2022 14:00:18 +0000 Received: by outflank-mailman (input) for mailman id 399898; Tue, 06 Sep 2022 14:00:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZ7h-00018o-Kx; Tue, 06 Sep 2022 14:00:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZ7h-0004UK-IM; Tue, 06 Sep 2022 14:00:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZ7h-0001ID-3J; Tue, 06 Sep 2022 14:00:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVZ7h-0005wz-2q; Tue, 06 Sep 2022 14:00:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sGoP08Al6I/+tNzLu7HZFPg38WjnKUwKy5bGoPZHhsQ=; b=aw2pirlhRGOlkSMl9/4zaLgpHS VwO7RMFXz7QJ52AOybaYHP/WsHMZPlUPB5psFF0FxoSQVEoKHFOj8/8Jkt+Eh5jf7Iyv7q63i86QL ftxTAEywrfHiDX7f9WmkOgBbxnLyVYim8df5wY5A/OYuBUSPGXysRHUAQoGbJTbrS3uc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173021: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=39596c41c82d9472f8a9f448b435e77afccc23a5 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 06 Sep 2022 14:00:17 +0000 flight 173021 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173021/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 39596c41c82d9472f8a9f448b435e77afccc23a5 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 32 days 253 attempts Testing same since 173021 2022-09-06 08:40:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1962 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 14:10:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 14:10:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399907.641305 (Exim 4.92) (envelope-from ) id 1oVZH5-0001uT-Jy; Tue, 06 Sep 2022 14:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399907.641305; Tue, 06 Sep 2022 14:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZH5-0001uM-GQ; Tue, 06 Sep 2022 14:09:59 +0000 Received: by outflank-mailman (input) for mailman id 399907; Tue, 06 Sep 2022 14:09:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZH4-0001uG-Kp for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 14:09:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60080.outbound.protection.outlook.com [40.107.6.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9650d26a-2ded-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 16:09:57 +0200 (CEST) Received: from AM6PR05CA0012.eurprd05.prod.outlook.com (2603:10a6:20b:2e::25) by GV1PR08MB8644.eurprd08.prod.outlook.com (2603:10a6:150:85::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 14:09:52 +0000 Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::f) by AM6PR05CA0012.outlook.office365.com (2603:10a6:20b:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 14:09:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 14:09:51 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Tue, 06 Sep 2022 14:09:50 +0000 Received: from 7935866243d6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43F65E42-6CBF-4687-A809-D154610BB888.1; Tue, 06 Sep 2022 14:09:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7935866243d6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 14:09:45 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBBPR08MB5930.eurprd08.prod.outlook.com (2603:10a6:10:200::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 14:09:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 14:09:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9650d26a-2ded-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=clBx5H1/ykbqBsGObriM849E8XZP3FVRPC2mNIaLY65DoF59foN1VP3zxRNE0gSvcp2IqPc1XDuIwktLDx1w9nlHmetEW+tHMC+ApB1XlrVLex/rYRKXbLRqLFlmOm4RV0fWkLPgjKbWEzdtvyUFPZjjb8jYFBwuqmP/9eBgLdeDIavqshCPAWV1p6gQ0NYO3y6qF4tk0LuegK/vRAbdOeSl7yLvGUcW3Q2NVf8P7p9R/BoB+XdYVsSHkQf0/FLOkmh2BWA5mxEGpByry4bRNYr+Ey2KzU/IBCGw7oJ2MGvyBFiPDfZZGQplqvHC2SMOH+CjcnMXyWfTUz43tHTmPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bxu96chCDBqaYjLX/zGg2u2uo2j5PR2UXkDDmkdqWNU=; b=PDHvtD2Q1xzabuTyTwSmir4ZqIIjg2S5lUXzOdA9E6p7+NALwhmjrrAzBFAgDZCYqW+GG00d468hsXIPJ3ctGncBRsiQVcaWfeVZH+lv6aRa4hzqZEOVWBqajuaF2kSY/wwUk8VoFlzvqnV9MM9mYhck7LUhbX/cNzEryov20DM+Id7vLpaJKYwQMG2CUGJY5kx2sdO6/KZyqyiZQaFtzjZqS8sWipFhSzoWpxI/N1iT86ATvi9lrdFCcaipTTC8Z8aUC3l3/b4BwD59ti14dNyJ0b2Z0fIMunQx77BbUsS7EXKIRFAkU0CEBwoiHhdwqjVR5fI8n8APFWHklodBYg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bxu96chCDBqaYjLX/zGg2u2uo2j5PR2UXkDDmkdqWNU=; b=Y+mZlwZt0NVx7lKfViY5IG0nske0vxUEP5XoDWUntEWGtX9x1cvPTtKAZpO9Vzg+NQ69Pny/ZC8RSmsCv1JI0ntLMs6SpsvXjjQFTFuo4iY5JeCItloSuzYSslHdPlEe5vyebgGYrzIA54xXlyfi0SXUxeQAIZT7cxU1hPPv0gI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RtUY7Mql4NoYgUdxyFLz2eklmnraDEFn6KZzEYODlQkAjUKVwkmsq5pepFqpuRFCZyp8+scAXGKLv7DPPVqH+lY7ZO6wkIWr7Wltu7l2ZsC1dt0g80GiIfbcb6iFH3YeP9NxGYS44YI2doHe/PuUqSiIXCMmOmCpvJekplV/KDVs33vZr/mStftu/dsr06VD0TXOJo4MdPKb94whJZjufU8/N3bYFlyNFdVeca5TcDldsRDsayzfIq7liZyd8M9k9MPJZof9nbuuGeanWGskyKGNRe+pmo6n0SCl/NuJivVNxnmxQrCprd9LR9jDxToaZ1RUb20vqYYBtgxQ8Z16gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bxu96chCDBqaYjLX/zGg2u2uo2j5PR2UXkDDmkdqWNU=; b=l/e6WBDMLYT5gwinC8+G7T6JrrmmBxBYbbiOuDI1uan7Ulk3KaKZk9/4Q1ZbwcCLkQNTXamska51ThU+kG7YalYPyYVTWRGCIQTOXw3cduM2wRtK2rvsx41M+c8P57PqaYEYREwDzclfwrHy03yocfzOv0TcehwlBhJ63jWshb+Bkr3Euryp0P2s+jBbbt52PElmMOgpTZqTFOzCKylhq7satblR5iIel0PdJ/tNt+4FXqup7ghTb/Ke57wKZ7CwAgeIvVwLtAc8A7IGDYjglWF7RJ2VC7RF48RJxq5QVP0I0RsY6vMXDxpVSZPIfxgot2il4PitVhQcwb8f8keZRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bxu96chCDBqaYjLX/zGg2u2uo2j5PR2UXkDDmkdqWNU=; b=Y+mZlwZt0NVx7lKfViY5IG0nske0vxUEP5XoDWUntEWGtX9x1cvPTtKAZpO9Vzg+NQ69Pny/ZC8RSmsCv1JI0ntLMs6SpsvXjjQFTFuo4iY5JeCItloSuzYSslHdPlEe5vyebgGYrzIA54xXlyfi0SXUxeQAIZT7cxU1hPPv0gI= From: Henry Wang To: Jan Beulich CC: Wei Liu , Anthony PERARD , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" , Bertrand Marquis Subject: RE: [PATCH v2] x86/public: move XEN_ACPI_ in a new header Thread-Topic: [PATCH v2] x86/public: move XEN_ACPI_ in a new header Thread-Index: AQHYuGftYa+h04RcYEK+Oaks92E1n62/YK6AgAdDISCAC99TAIAAAF8A Date: Tue, 6 Sep 2022 14:09:43 +0000 Message-ID: References: <7dbef184-7e55-51d7-27e1-93153b5f0bc9@suse.com> <9af0809d-ab7f-09d0-3fa4-5b73fb605fd6@suse.com> In-Reply-To: <9af0809d-ab7f-09d0-3fa4-5b73fb605fd6@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C1978315DF4C45418D3CF74C9698E3FB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e41a67a1-9d1c-448c-f385-08da90117717 x-ms-traffictypediagnostic: DBBPR08MB5930:EE_|AM7EUR03FT059:EE_|GV1PR08MB8644:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cFdB90B1sk2737YvQ/AEJ60jX5oRuDwyWRR9r4q0gzspVhdGv+gVie6e8/b0dNFA/A0Zuhi4KtOEMulZvAtWc30IzjZ67lHBj0RTiZv1vDBN0WvdPk9Xip3B1Pk/TDtMwJW/TRRDwwgwn2PGK53M+DuY1/fgYZE0RubYFbm5wWQ8oERNCkAP4VRrVxogqsEIae9OGmTY8IOPA8cEN0rVzpkD8cvliXAdS3pZMY1u2KsjjzYQbW9143cevSibOsxR+1jSLP22Q3Ryt9P9ADVnX0PNNlP4SIkc8V+dDbI0zj0p89XNiZP5irtnx0pPdDGK5vv08KWvxE/FowJQffLHFkE9v+SqtR2NXDVXIqhOyuWxVhQlydpwIDRNbJx8X9qSXWhFqEP2N8lYc4wX3ezduKUwmXCry7JYo2GU4qg1xWMI9LAu/5bYzGBomWRQJEUBRErDbwTa008K+my614zFwclbkpEovaiD2VHXAHr5oXdeuzEZ2m6SvyBVH5x9+PJXbElenRQtxuG2nqr9IzBCwG4fmTfh33bzw4SyokoDQuaz5mXmUnrg7oiY21aDsy29d+YkvQ6/EMLBd4vTurE6YxTNruPrk1Kyer1oYHYmiGXBHjNRwP+DzPPU1eAj3frGrWpFetnYYCK1tWIvvHvSM+hb17L+CENy1P6GAwCY+LbuIA2IlaHZPwSJKJQR33dMTHahS5+Os8pT5nTk83BjuRSMivKGoFZEqcElMn3tbkA+HGBlYYjNmQhSd2iLz5WTI237yI8Nljv7qomhIjhH0Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(316002)(33656002)(5660300002)(83380400001)(4326008)(66946007)(66476007)(66446008)(8936002)(76116006)(2906002)(6916009)(52536014)(54906003)(64756008)(8676002)(478600001)(71200400001)(41300700001)(55016003)(558084003)(26005)(9686003)(66556008)(186003)(86362001)(7696005)(6506007)(38070700005)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5930 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d1151b19-dd31-4caa-e1e1-08da901172bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WLL4nrI0e5kSd9C4C4tMOLXC7792o2RH2C4q38xRLiQiuNvOk7zvAtsCJFC7mzaNcQmYxVPygnsiiQqb8cxFAkS3WAJRkWiUXFe1GHENp8mzkc5mIDn7ct3oB2UMprtmDVXmqJg+xdtnjMLPYlcJNQqPD81WfMJbWXVpSCkrGwp45CBF67Zd+Ucf21fLt/N9k5W3PXeMTw7IjBZfRFeTl+w9V/2vcKiK/MnfGSt5m85+Iz9GUuzQxBrsidEIKXZoBT7gjzn8rDABb5ZsB5gJU8XCeIRz+3CAGUSxjGViT+tKnD14iIAx9xdrafc1htDnvPmPk4YvuoEALJt9NCh5ySGgFzGoFxd3s3vjzSDY6UU/WU60EUlbiZwnelu5abq8bJvRgNi61iZQrcjKb8IUpk9yKm0A5QLdQjkoOEBCX+lsaP9AOHGPO4Lp+CXQ5O7WlLuY6xtRSEzr0JgMt4eCySjy/fQA+gvHR+vcjpIetFl4QhHFi6HkDy4RKh9P27d1ezo33FjL2z9auSMd4zs8PqMCHVgUNiyRHBAPdNlyUsqihIgBnV+mLFzVIQocT2hV2Mh2cYLYq3ONYC6bhPzwfP5aSQJ5Rs3psbE7ZjxPvJNAiW5obu6tLyDSVdqgDBzgoFbyNhWxvXLJ7vNGFB052GKxIlPyUIIyVEBXqHFSQ/eOnIlQ2ne2YTlUjoFOSV5xbJ4Kwk7wryMyQx2GaJsYqh8J2lWxxmVe9rujTtdSAr0AvyU6jhmuXXSUR4vV+NlwU6HI2+V44kKf6xu5LHJ30w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(39860400002)(346002)(36840700001)(46966006)(40470700004)(70586007)(70206006)(55016003)(36860700001)(336012)(47076005)(83380400001)(40480700001)(8676002)(316002)(54906003)(4326008)(478600001)(52536014)(9686003)(26005)(86362001)(2906002)(6506007)(41300700001)(186003)(5660300002)(4744005)(33656002)(6862004)(8936002)(356005)(81166007)(82310400005)(40460700003)(82740400003)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 14:09:51.2623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e41a67a1-9d1c-448c-f385-08da90117717 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8644 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPiBBY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnku V2FuZ0Bhcm0uY29tPiAjIEZvciB0aGUgNC4xNyByZWxlYXNlDQo+IA0KPiBJJ3ZlIHRyYW5zbGF0 ZWQgdGhpcyB0byBSZWxlYXNlLWFja2VkLWJ5OiAoYXMgd2FzIHVzZWQgZm9yIGVhcmxpZXIgcmVs ZWFzZXMpLg0KDQpUaGFua3MgZm9yIGxldHRpbmcgbWUga25vdyB0aGlzISBJIHdpbGwga2VlcCBp biBtaW5kIGFuZCB1c2UgdGhpcyBpbiB0aGUgZnV0dXJlLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5y eQ0KDQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 06 14:10:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 14:10:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399912.641316 (Exim 4.92) (envelope-from ) id 1oVZHr-0003Gb-2l; Tue, 06 Sep 2022 14:10:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399912.641316; Tue, 06 Sep 2022 14:10:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZHq-0003GU-VN; Tue, 06 Sep 2022 14:10:46 +0000 Received: by outflank-mailman (input) for mailman id 399912; Tue, 06 Sep 2022 14:10:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZHp-0003GK-S2; Tue, 06 Sep 2022 14:10:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZHp-0004f4-P2; Tue, 06 Sep 2022 14:10:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZHp-0001gN-7F; Tue, 06 Sep 2022 14:10:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVZHp-0003pD-6o; Tue, 06 Sep 2022 14:10:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iXOKvvNbk2uE+8tdt5Vabji4qVbh+aheybH4QhyH9dA=; b=kct/JYjqnDfOa/yE0fHA5cYM00 TuYabMU48nK6KTm+oRwnriswCDLulZTAbSWSnR6vh8feIZtm8JW7hCVKrfX7C/BlaDXGFYNviN7xm hm74SEZgCGNMwWV8p4bO2/WUReaRn/QeTsj8GDNTZF22Xisq+Q3ngakb8LZ7X+WJnkhg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173016: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Tue, 06 Sep 2022 14:10:45 +0000 flight 173016 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173016/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 173008 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173008 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173008 like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail in 173008 like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail in 173008 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173008 like 172128 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173008 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173008 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173008 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173008 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 33 days Failing since 172384 2022-08-11 11:13:58 Z 26 days 56 attempts Testing same since 173008 2022-09-05 15:47:43 Z 0 days 2 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 14:30:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 14:30:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399924.641334 (Exim 4.92) (envelope-from ) id 1oVZb7-0005vW-PK; Tue, 06 Sep 2022 14:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399924.641334; Tue, 06 Sep 2022 14:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZb7-0005vP-MV; Tue, 06 Sep 2022 14:30:41 +0000 Received: by outflank-mailman (input) for mailman id 399924; Tue, 06 Sep 2022 14:30:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZb6-0005vJ-Mz for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 14:30:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a649ed7-2df0-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 16:30:39 +0200 (CEST) Received: from AS9PR04CA0160.eurprd04.prod.outlook.com (2603:10a6:20b:530::28) by AM9PR08MB6145.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Tue, 6 Sep 2022 14:30:37 +0000 Received: from AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:530:cafe::17) by AS9PR04CA0160.outlook.office365.com (2603:10a6:20b:530::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 14:30:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT047.mail.protection.outlook.com (100.127.140.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 14:30:35 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 06 Sep 2022 14:30:35 +0000 Received: from a308c48dd9b1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E39CB183-FF5D-4EC4-948F-F4BFA95AD3AB.1; Tue, 06 Sep 2022 14:30:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a308c48dd9b1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 14:30:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB8745.eurprd08.prod.outlook.com (2603:10a6:20b:55d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 14:30:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 14:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a649ed7-2df0-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NowjZdoPxQ9RUEE7cYxQR1Kx2LlPZnUswwaXumMrGE9hCVrUUFw+KwoSpL4EXgrFynJWQBCga9oDAoXOa0Yto4J96tvRQ/iFWdv9Z5c++F62fueqK8Iwdj5QCLLPl8RuSSw70lZJYqRIcFIr5s0gXb4v2HcUchA0ml3rHhnMNzSUJ/scgt71AWU/bIMNM/Gdj7306yE0Mp0b9jZ1lIIlk0Vz2ys+gbtNl92OQdIc2yUOSoA2qHVXcQ8sAPBQc8zYs5Vuiwdh9Ytn67cfKrU5AvaHvNjhLG/tdJx/QO3P0OTGdpF/tQ2Giwk+xCoRPj8sjQ7xknzc+v4ZizIWikctHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYrRyGRwB/wh2JUK5OtpOX1GoOrTZc0vCS1+BzEN9bc=; b=Gp1LB25Es6QlPN0rMpLEZLk8i3EifTAUjLIjXDYVQ9N9933UX3rwuB4C6p+9n6KXBjlg6sxVojC1pXHKR7BSeoY3pBswOSw3mgC76K2QhsMQjRh0jzd/R/U5T2anTM+SEQdqphQK6mkgAptz4RjKkZOduwvVZgN9NamFjTAml9ldtbNbTofZR+xX9fQj5vtWkC0HIaES/SsKZyIu9QH7SRszQPIEqP2moC9/rnMvFcf9vvgvtiSYXElLBksSjaozwN35M88MrHxHNnO55btc5UPNhl8ABv+2dWneaQ04CcTHfDe8XhRQ+yokOc6bCtV0zuCQQuo5sM0OtwcvQ60i4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYrRyGRwB/wh2JUK5OtpOX1GoOrTZc0vCS1+BzEN9bc=; b=9CM9PRkbD+NQA1v/DG8z2FDSuuJB4okDnKs9RJQQgMjyKzaEgM2zBz+v6uevPmBL07BvbmWlgwvNh2TTlNtgbMVVDE1nXHeYiGnYJMZkpex2zSYTzaQyxl2Ln5cXgn4Xk7EczGHPWchfyQhXOLZF2Yhb1piI/9pORhcY6bjzPLM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aw7SiJ7DcIhlMK3EGma/dLveikmvRJ2qonXEvyNNicaStnQMSFVZb3+FcRYNnl4M4iya7p9ahW9QZRZDit5IoJqzEPt2eXuJTfZJGfXW5PDeocWO27v/vbk7XvyteONlfPFmBsd7Mbpj28AMlyVlSn7aslrP5pnMn0wQD7AczLRiwq44qTM5dlUE1t3wbpeuo1eGN/EpPMo3LXLPWJ1x4Yfgo6yJBy00wTdHESB7MMEWgwTgNNqFXie2HjNK1lOfwU8sTNz45lrFKQeDqABIWi1fRtXhnWRhkDSbFvMVKbYOMf9v5wryDOCHN8zAfyl9+qJyoNBp/46WAzmp9TevLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYrRyGRwB/wh2JUK5OtpOX1GoOrTZc0vCS1+BzEN9bc=; b=CMIS9sNdsEPxXJxe+vzHTEIj9So2e3TiH76+K7VC08mexiL5JFUqWtyZCgsk6yQm8oM6B3G1px/gM9njy9UrWo8qEdwPwo6t+/GEZUKzpl6LZpQ3lcAbcNgBpCQUYNl4HLqe4WpCFirz9vpcptxiYvbU8R3HUAe/YdpYjKWSdV0DKPs9Y/1wD80P+9I8Tu6S/EaqdXwiMoTId46GQN35I0vmPDMv2g9e3F3/oArPrWZKSUh6J75Op5gcCStY+QBeJqCuqm/uZYkAHnKu23EQQKteuPDb4sG177DBmxhFDaXw7WLYGm1lAdYUXE+qqJ5vr9Yn9lcjudb1+3dq5PXF7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYrRyGRwB/wh2JUK5OtpOX1GoOrTZc0vCS1+BzEN9bc=; b=9CM9PRkbD+NQA1v/DG8z2FDSuuJB4okDnKs9RJQQgMjyKzaEgM2zBz+v6uevPmBL07BvbmWlgwvNh2TTlNtgbMVVDE1nXHeYiGnYJMZkpex2zSYTzaQyxl2Ln5cXgn4Xk7EczGHPWchfyQhXOLZF2Yhb1piI/9pORhcY6bjzPLM= From: Henry Wang To: Andrew Cooper , Jennifer Herbert , "jbeulich@suse.com" , "wl@xen.org" , Roger Pau Monne , Anthony PERARD CC: "xen-devel@lists.xenproject.org" Subject: RE: [for-4.17 PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable. Thread-Topic: [for-4.17 PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable. Thread-Index: AQHYwfulNVt1Od0JyUqnzZeYC4k2ya3SdSuw Date: Tue, 6 Sep 2022 14:30:27 +0000 Message-ID: References: <20220830202706.1618386-1-jennifer.herbert@citrix.com> <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> In-Reply-To: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D1C06505EC665B4C916BD6A615069347.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c9fda72e-436a-46eb-c4a8-08da90145cf6 x-ms-traffictypediagnostic: AS2PR08MB8745:EE_|AM7EUR03FT047:EE_|AM9PR08MB6145:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D/pX6qA89XrlGyUHxtGLlM3ltoe1rpuHGUrJU2ArtefsUG5FdB1WaBLj1HLY0UB0mtIIm4hYVNpztc2uumF/B5jPJ5sR8zATyebVM+Qjdjmzv80yZonLimxF/EWQspI506N++5pqZamExnz7LGIuRXFwhYtRkoig6RKwU/hOQr6tJzKRa83DfwM1bSl08AMZrEF5JySQfXnUaeyW2oMlKC3+CRXjKEs7uusdGGTCzG//bytPRk8qSTk8wYjufe2sA4Tyvd1rRVrr22zvAzUcTCPQpOdn8HnLwgnbefW40Na3LOED8y2uYuG4oyp3edVAdhnq6T1P0LF0hxZsiniMkIU8e9kHVTOaPSmEEeAnHX/TxTg/re45e0hrUzTEQYNgmNH64vT3E0n0ANtABtXS093g3lVGh1cZwk7GaHxkzEtK+Q350ljcSoNnhC4XxRh9sR6g/k/dY6/T1a1f9vsWPo39T15R725WLNPOD9EYWwwW+liPBPcTfbEu/Vai+C86KJimH03yjYcdYKVJlsu+3TG90ICGI28013jwCJ2TwyhznTPMhEFsNtZ06HOlL+KgaF455l/F86liHmPUa/Wr4gsX0Mi9E4JC22KVPJtkJ8hreWnaSJC0DMqtc0LuKyUYSga3uP7Urz+kE3AWHmJMxq/toITKERFuRv+4brT9IAHK4Wk0nQ/PvjQWfbKepxfcI2t8/OIBubyltgRtCwM7eJoPhb+aOb+z/vSEpyOMtwLYPMXBUhmUFJu4fjPYRYBnC3fm2NsA/pN+dE67GZcDMQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(186003)(316002)(38070700005)(38100700002)(66946007)(66556008)(66476007)(9686003)(66446008)(83380400001)(26005)(110136005)(4326008)(76116006)(8676002)(52536014)(7696005)(41300700001)(53546011)(64756008)(5660300002)(71200400001)(8936002)(86362001)(6506007)(55016003)(2906002)(122000001)(33656002)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8745 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 442ff8cd-67ee-43c1-cc33-08da901457c7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HIhEwqa9AJey6oHycLr5Wka02f0/OXUOXsM54vwNFo6emhyRgRQZcFtfAWDL0qR5FJzGsNMotA+bkyFz7dud6RUY2YE1LfGze6vOLE3ARpQ78pdbYQ/MtxzjMhwrX9Li0AC/ByWXk0yxdA6rQ1/vGn/nTZzrH0O8nzJnSTS5EuZef1wMMUzj+vYh+XORPdkenV05c9d6BHJF2n18aSb8/LG3hSpeMBnCshjKN643bngcLcF678zTrQmTOUU3BzSjqZ+7DwUDYN5CU3iBz8DRm65NzUPG5pO0ZFSGFMHrSFPTiHNLPrXXmJH5zzthHMNYblm0Mmk6sxJeHkVIe6KmEIm3KNk7TqszvklDzWMnbYviO3a0s8WrroX5NUp1oPCT4SqCVHdePYtFTdk3mz8eD951qtdOzqTA4kHoR9tumCt+2/hy+MlEZ1aXONdM4ALArF9bg5cAlEbpmCiCvVIv5sEFgEhAbkFgKD/4s/ld4IuQH1uJlAnOEoZyZ9z8dlLiIRnQy1XzvnKD1HGCqCmLr8KIghDhuNPyRws5m1klXyLMnqsIaJd32aIWJnJao9MP6ACiY6xbkcHqIaHBAfz7hV0IXrjZUwUFv/iYt8iWboOadguoBMBMbILA+pc0n9adiqbimZBiVOCMgAcJZVEA38XzwcZD0wW/d273+VNAgCL/GlloMDvJxK5ny8QPwOsfJ8Toz2QNRMimwKw6UCHL5Nd1KUPt+oBc7kT2qN90eMXtF2Er3OSyIXIXVkr+0+VSH8KqpQux/3f61ds58hIsCg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(8936002)(5660300002)(36860700001)(33656002)(2906002)(55016003)(52536014)(83380400001)(8676002)(40460700003)(82740400003)(40480700001)(4326008)(70586007)(70206006)(110136005)(316002)(86362001)(82310400005)(47076005)(81166007)(336012)(6506007)(26005)(186003)(41300700001)(356005)(478600001)(9686003)(7696005)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 14:30:35.9299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9fda72e-436a-46eb-c4a8-08da90145cf6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6145 SGkgQW5kcmV3LA0KDQooKyBBbnRob255IGFzIEkgYmVsaWV2ZSBoZSBpcyB0aGUgdG9vbHN0YWNr IG1haW50YWluZXIpDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQW5k cmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogUmU6IFtm b3ItNC4xNyBQQVRDSF0gYWNwaTogQWRkIFRQTTIgaW50ZXJmYWNlIGRlZmluaXRpb24gYW5kIG1h a2UNCj4gdGhlIFRQTSB2ZXJzaW9uIGNvbmZpZ3VyYWJsZS4NCj4gDQo+IE9uIDMwLzA4LzIwMjIg MjE6MjcsIEplbm5pZmVyIEhlcmJlcnQgd3JvdGU6DQo+ID4gVGhpcyBwYXRjaCBpbnRyb2R1Y2Vz IGFuIG9wdGlvbmFsIFRQTSAyIGludGVyZmFjZSBkZWZpbml0aW9uIHRvIHRoZSBBQ1BJDQo+IHRh YmxlLA0KPiA+IHdoaWNoIGlzIHRvIGJlIHVzZWQgYXMgcGFydCBvZiBhIHZUUE0gMiBpbXBsZW1l bnRhdGlvbi4NCj4gPiBUbyBlbmFibGUgdGhlIG5ldyBpbnRlcmZhY2UgLSBJIGhhdmUgbWFkZSB0 aGUgVFBNIGludGVyZmFjZSB2ZXJzaW9uDQo+ID4gY29uZmlndXJhYmxlIGluIHRoZSBhY3BpX2Nv bmZpZywgd2l0aCB0aGUgZGVmYXVsdCBiZWluZyB0aGUgZXhpc3RpbmcNCj4gMS4yLihUQ1BBKQ0K PiA+IEkgaGF2ZSBhbHNvIGFkZGVkIHRvIGh2bWxvYWRlciBhbiBvcHRpb24gdG8gdXRpbGlzZSB0 aGlzIG5ldyBjb25maWcsIHdoaWNoDQo+IGNhbg0KPiA+IGJlIHRyaWdnZXJlZCBieSBzZXR0aW5n IHRoZSBwbGF0Zm9ybS90cG1fdmVyaW9uIHhlbnN0b3JlIGtleS4NCj4gPg0KPiA+IFNpZ25lZC1v ZmYtYnk6IEplbm5pZmVyIEhlcmJlcnQgPGplbm5pZmVyLmhlcmJlcnRAY2l0cml4LmNvbT4NCj4g DQo+IFdlJ3JlIHBhc3QgdGhlIDQuMTcgZmVhdHVyZSBzdWJtaXNzaW9uIGRlYWRsaW5lLsKgIEND J2luZyBIZW5yeS4NCj4gDQo+IEhlbnJ5OiBUaGlzIGlzIGEgZmFpcmx5IHNpbXBsZSBjaGFuZ2Ug YW5kIGEgY3JpdGljYWwgYnVpbGRpbmcgYmxvY2sgZm9yDQo+IGdldHRpbmcgV2luZG93cyAxMSBz dXBwb3J0IG9uIFhlbi7CoCBHaXZlbiB0aGF0IGZlYXR1cmUgZnJlZXplIHdhcw0KPiBzbGlwcGVk IHNldmVyYWwgd2Vla3MgZm9yIG90aGVyIHJlYXNvbnMsIHRoaXMgc2hvdWxkIGJlIGNvbnNpZGVy ZWQgZm9yDQo+IGluY2x1c2lvbiB0b28uDQoNCldlIGRlbGF5ZWQgdGhlIGZlYXR1cmUgZnJlZXpl IHRvIHRoaXMgRnJpZGF5LiBTbyBpdCBhY3R1YWxseSBkZXBlbmRzIG9uDQppZiB3ZSBjYW4gaGF2 ZSBlbm91Z2ggYmFuZHdpZHRoIGZvciBtYWludGFpbmVycyB0byBwcm92aWRlIGZlZWRiYWNrDQph bmQgaWYgSmVubmlmZXIgY2FuIGZpeCB0aGVtIGluIHRpbWUuDQoNCktpbmQgcmVnYXJkcywNCkhl bnJ5DQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 06 14:45:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 14:45:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399932.641346 (Exim 4.92) (envelope-from ) id 1oVZpW-0007cQ-4l; Tue, 06 Sep 2022 14:45:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399932.641346; Tue, 06 Sep 2022 14:45:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZpW-0007cJ-21; Tue, 06 Sep 2022 14:45:34 +0000 Received: by outflank-mailman (input) for mailman id 399932; Tue, 06 Sep 2022 14:45:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVZpV-0007cD-2Q for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 14:45:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2083.outbound.protection.outlook.com [40.107.21.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8dcd071f-2df2-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 16:45:32 +0200 (CEST) Received: from AM4PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:205::45) by PAXPR08MB7672.eurprd08.prod.outlook.com (2603:10a6:102:246::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Tue, 6 Sep 2022 14:45:27 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:205:0:cafe::a4) by AM4PR05CA0032.outlook.office365.com (2603:10a6:205::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 14:45:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 14:45:26 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Tue, 06 Sep 2022 14:45:26 +0000 Received: from c2cd1d0554f8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B6384AFD-9329-425D-B653-4D333266D458.1; Tue, 06 Sep 2022 14:45:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2cd1d0554f8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 14:45:15 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB3PR08MB9109.eurprd08.prod.outlook.com (2603:10a6:10:43c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 14:45:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 14:45:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dcd071f-2df2-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=U1LE+jtsBkb03mh9FMDEy7Ic0NPd+Olz5uLEdbpKzqgWUbpBzwnToY9b6FRd0B63vWzTf3pgaRuJMpahutjBNkGsCvvSUg/l9Vbve19bK0md9+UnyzJ3BEfLP4bnlHE5mi/aXihfqTPyYSDkWXrPFlakR73P1sOaP1sB8HCzMFlnEBWbDe/gV3YVQiPDeUaH4SEL9vHX0IoV1kxAHF/3VxcwiRFeukSwFQXwCppFRAn0xQu5t4Z9p00mNC3dAbOcirCOYf9Kp00ogEu4x808g+6sR6yVVV7VLKHDvtvyq6ENlUZwGWelwzU32pojQ2kUUGCq5JaiIKFkADLnnObXSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6z8KUo+QFq4Jyj4JVloTBzfjaAx35/FUsJVSJtNT8Pc=; b=SxJ8zzZYF3xcPABeGzrp179ihCbinQwl9GqCyQe+G/L6lG55g78M4AeZAfArmYR+nCIAeBCZp6/LOoz9PtkpUdYc1T4fu9V/PUSOeE5Yj3L4JKu96uDeNFGMoWlGlv7ifAgcGUh6Xs/8ocY5ZqnMad/l8R+X3qrYzd5BGHOq7ncf/s3Tiotq+uwXssH4FNkx3VW4+88Do/m4+5ULsPQunLJ41rvmYbqiHwPCW9+9wxG6M3oyNyxfvCH9Gc669nWcmqL5CcbkmtcG43YVEsDoPEqPfH4FikFmunHEG9A4xQFYZ4I7J4d/wNK0L4HvP2Ua0t2jamZ1wz1UOMmlNOOe1Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6z8KUo+QFq4Jyj4JVloTBzfjaAx35/FUsJVSJtNT8Pc=; b=kB4t5mYCPid/gG5zaImco2KgiDSQ926X9vObua9R0jkb+0jeDktwuKi7I2qGz8Cm8oMG+tVTJq0WKYW3+6PmSPIgdvv1Py0AJqmCIFrg/F5VAswYkJCjH+7sfsxt1EbhsB+0H6WzV20VDZWySmr9/gdnt1K4HnfJS5wvhWXpssk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ba5932f8dbc783d0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fw/K6CKZZvrwHlzym+dw0BhiQF2pNx+n06FABGkjVAzUCYOT7VeOlB0XnO3jNsaSvII27lAweZIYKGOyZegRmgH3ZQUB+OZ1ArgiqheGDajHXQ4PfV1SdFzCn8vf4aWMTXyhabuHdSZ3zxSmsAHAOQTy3U+H9l2FEKEIiFts//9ngyvpydCZrWF8y7Ee/F8UDbcNXmRE+2XK+ssdf1vaMUH/XwKtlaWjgyK62iL3j24X2Igm9RTxqmzaY53jKxtIk6wdTP943SnKSHHhAIvOAaEVF2UV+kcXFCfaKR4CaY/YwXMHavwINEeAahrGmPFIbcpmE1L5qtBaEcFO6k1k4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6z8KUo+QFq4Jyj4JVloTBzfjaAx35/FUsJVSJtNT8Pc=; b=ACibcI/rmEPKCC1GmFSZovPnZeER0FNBeCdZ3xv+Yc8u0TgPam9Ce8sEsJF8BiRRhmMwlwqGTAU5QFgx3d9OVZhxk29K1S6+S5cj5sAs3kWVGbdXSAvJ2RCcuLShW8ofHgcB17BcgMzmO5zOW73ByPrPXPGOm3EcIuy4SYQIC9VRoDE+b7DHL919WzH+PL4WN19n9fx6uz5A2hrHKba+QXu06Ccge0hCcW76mkV7C2Prz58DMy3uTbGcW3Guj2rhyIpMPn7GnfLngz4lAe+apWVZk8rkAuRBLFScfZGTaPrJjkgaCHS1YAhnDQp7dVuFNqSdrpUZXPj13N2BYmKLfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6z8KUo+QFq4Jyj4JVloTBzfjaAx35/FUsJVSJtNT8Pc=; b=kB4t5mYCPid/gG5zaImco2KgiDSQ926X9vObua9R0jkb+0jeDktwuKi7I2qGz8Cm8oMG+tVTJq0WKYW3+6PmSPIgdvv1Py0AJqmCIFrg/F5VAswYkJCjH+7sfsxt1EbhsB+0H6WzV20VDZWySmr9/gdnt1K4HnfJS5wvhWXpssk= From: Bertrand Marquis To: Rahul Singh CC: xen-devel , Zhou Wang , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: Re: [PATCH v4 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Topic: [PATCH v4 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Thread-Index: AQHYwdelUBSV4OOcQUmjNGIzTG/77q3SetoA Date: Tue, 6 Sep 2022 14:45:13 +0000 Message-ID: <4671F8E2-2952-4904-989B-335652EBFB10@arm.com> References: <4404a056ba2dfc7ed2a69270dd2c28d0d343dfa3.1662455798.git.rahul.singh@arm.com> In-Reply-To: <4404a056ba2dfc7ed2a69270dd2c28d0d343dfa3.1662455798.git.rahul.singh@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 639ca176-c90d-483b-573b-08da90166fed x-ms-traffictypediagnostic: DB3PR08MB9109:EE_|AM7EUR03FT015:EE_|PAXPR08MB7672:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8NGkfPn+Jgat/V++sP30yq92dujAIih9eGSXUGcpnuv2f8wP/I9lqcXECNMjRkSd2slX+VUWEYk728nezsVEZugzu3CUSOf8IGwThycGrndTxTzSwxU6bBAa4zUedh5/rI45e9+Wt3/04Ts9b5oXuUgYIADWfY/80BHdGX3145UQv764/xxmhdjJP7SS+6X5OzM7Z1N85I8MiTpQfn+Hl303cWVPVy+xdjKBaJiR2DZ6wcfkRaVzjFmxl/Md/m/g8MJjJ11XWJsztYLp5379uWcnzJ6Kjr/KBF0bWrAxihE4RfSBgUmXPpD/rOdOwNXlNBGk4SXrMvQQKWephpZYp3gtLb+REvhdPiT4icykq2OvDuuJoVfeM7BwIJKxDwlQrYNn3GHeFUrkshw/11WoSgsPruxREAGHH9MsZ2P7UGo5eBbw9KAIIyPivm3Bp1h+f3HfpWsmsn3mu4UcIgSy53B2dYhmrpPdv/jyDI0lT3/jjU0ZW3Sc+l/WSL2FUEyL/thdiQr/LpNywN4P90m4kevKm6sIxgZWXLddcqyrjDu9SNsqoaAqgAEUl8jQtrYGsjGN6uarxSdcRavBwdmvSpwFcxGuoSJ49G3kuYnOn1byOvMirAcmEc8PLx+Qtc7/a1Nww/P8/g7afCmN0YMHctU3XTa9LXs918vpu7IixrNlxE74JgdhTCNr3HKz8dSSTz/jGB8KZoaASm581PkUH1QuElag5YNLbbrpbWHhDwUVXrU/eQjafcMhpwKEmbAXMZm+fniSplHsoPROkeJUSt+Pd9XC3xKpjD3uErrKfQRN3KBZIAQzgWagA12Vy4Vh049fr4q6Vk3ZX+sPXbjgXg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(122000001)(26005)(38100700002)(41300700001)(86362001)(53546011)(83380400001)(2906002)(36756003)(6862004)(33656002)(6506007)(6512007)(5660300002)(8936002)(64756008)(66946007)(8676002)(66476007)(66446008)(4326008)(91956017)(71200400001)(76116006)(478600001)(966005)(66556008)(2616005)(38070700005)(54906003)(6486002)(6636002)(186003)(316002)(37006003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <312E94AEFB81C2499C31987C72EE0416@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9109 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3a55b2ed-4a1c-464b-d9b4-08da901667e5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PinrbXDYAO/kncFb9cGDXPS4r6X6RxL92zcUl9lZAwpUOOTrmQgegnEA+PzlGv32qkgzxsTNWD3ZOaG1DpZHkxIR2icVCz+9ga66VguN8s4qKDBq63U46+RcXI8adj4sRFH4Xsq63ajalI5FYvLLwnce9ehM08IqZ0Vr8IyDlLnTWnmHNl9ss+Pe7uKjb17rmy/70mVFqYiA3SISObZJbLrMQ5x6SLWwKPEFbdLVxL61NicgNfISPgQeDbsnxl8VRTiG7/OfzNtoRWNjC5LS7kFn5fhiq6XOSihQHbfDw8LC+lW8bH9QizWM2Fa7mWOzxs42GtSt/EgyYX6CJ4Wt5NGGPMz8QbTHWnJQBVpLNgLcBl9d9hi1HBZ2HbuwiV3ufL5Y2vOqd6YcqmsnYI70WorjHtzNtB9wHS4M9zTt47GVIkSCmpoZnD2qzvVsbsXZCDR4kfwx4ofRsc6ZI5iRNdYtxDw4PIk1qaaDIUZw/6J2eJTeXpIBSfCoWANKc/aPfF/8RDhMK57KBpqGs80iq6urcLqRbkoNC6jCubP7PAg/PXv/oOVw1rZfKhdzrVMyTUPOx8Qmaq7PYQupGofT5eGfjaj0NUSYArsgMT6mz2msx2z9U13Q5CxBjp1psW59zke4/YzJzKv9JdKrJY4j3Hf3uKbJLPN/RI5avgcCD91Wl2bazjAU8JTDUMKg29uoTdOImdjKPD7nPiTRwkk+jPuPScnY4WktsWPWTZMmxFekAH/yWqiGTCLy4mOvmrbUP/6zLeRGxCXXMJfiuFVTYOs47zW37cg4KWpQy2BvdKc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(136003)(376002)(46966006)(36840700001)(40470700004)(6862004)(41300700001)(5660300002)(966005)(6486002)(8936002)(107886003)(33656002)(8676002)(356005)(4326008)(478600001)(70206006)(70586007)(82740400003)(82310400005)(2616005)(47076005)(2906002)(86362001)(186003)(336012)(53546011)(6506007)(83380400001)(26005)(6512007)(40480700001)(316002)(40460700003)(81166007)(6636002)(54906003)(36756003)(37006003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 14:45:26.7227 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 639ca176-c90d-483b-573b-08da90166fed X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7672 Hi Rahul, > On 6 Sep 2022, at 10:55, Rahul Singh wrote: >=20 > From: Zhou Wang >=20 > Backport Linux commit a76a37777f2c. Introduce __iomb() in the smmu-v3.c > file with other Linux compatibility definitions. >=20 > Reading the 'prod' MMIO register in order to determine whether or > not there is valid data beyond 'cons' for a given queue does not > provide sufficient dependency ordering, as the resulting access is > address dependent only on 'cons' and can therefore be speculated > ahead of time, potentially allowing stale data to be read by the > CPU. >=20 > Use readl() instead of readl_relaxed() when updating the shadow copy > of the 'prod' pointer, so that all speculated memory reads from the > corresponding queue can occur only from valid slots. >=20 > Signed-off-by: Zhou Wang > Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzh= ou1@hisilicon.com > [will: Use readl() instead of explicit barrier. Update 'cons' side to mat= ch.] > Signed-off-by: Will Deacon > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = a76a37777f2c > Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes in v4: > - rename iomb() to __iomb() > Changes in v3: > - rename __iomb() to iomb() and also move it from common file to > smmu-v3.c file > Changes in v2: > - fix commit msg > - add __iomb changes also from the origin patch > --- > xen/drivers/passthrough/arm/smmu-v3.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthro= ugh/arm/smmu-v3.c > index 64d39bb4d3..229b9a4b0d 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -107,6 +107,8 @@ typedef paddr_t dma_addr_t; > typedef paddr_t phys_addr_t; > typedef unsigned int gfp_t; >=20 > +#define __iomb() dmb(osh) > + > #define platform_device device >=20 > #define GFP_KERNEL 0 > @@ -951,7 +953,7 @@ static void queue_sync_cons_out(struct arm_smmu_queue= *q) > * Ensure that all CPU accesses (reads and writes) to the queue > * are complete before we update the cons pointer. > */ > - mb(); > + __iomb(); > writel_relaxed(q->llq.cons, q->cons_reg); > } >=20 > @@ -963,8 +965,15 @@ static void queue_inc_cons(struct arm_smmu_ll_queue = *q) >=20 > static int queue_sync_prod_in(struct arm_smmu_queue *q) > { > + u32 prod; > int ret =3D 0; > - u32 prod =3D readl_relaxed(q->prod_reg); > + > + /* > + * We can't use the _relaxed() variant here, as we must prevent > + * speculative reads of the queue before we have determined that > + * prod has indeed moved. > + */ > + prod =3D readl(q->prod_reg); >=20 > if (Q_OVF(prod) !=3D Q_OVF(q->llq.prod)) > ret =3D -EOVERFLOW; > --=20 > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 15:07:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 15:07:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399936.641356 (Exim 4.92) (envelope-from ) id 1oVaAp-0001jo-U2; Tue, 06 Sep 2022 15:07:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399936.641356; Tue, 06 Sep 2022 15:07:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVaAp-0001jh-RL; Tue, 06 Sep 2022 15:07:35 +0000 Received: by outflank-mailman (input) for mailman id 399936; Tue, 06 Sep 2022 15:07:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVaAo-0001jb-2y for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 15:07:34 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10044.outbound.protection.outlook.com [40.107.1.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1b5326a-2df5-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 17:07:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6827.eurprd04.prod.outlook.com (2603:10a6:10:f8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 15:07:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 15:07:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1b5326a-2df5-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R82mIS7JIoFCRyzz41wwGmdXhuFixEpqjNeCWV4RPMuJ0raThafLYHBOaZvoeZHIlHgMllFjQFlhtXWYZn3yvtWznN5p7dVDVeHIk/EeB5iHiUkZDjxGuQ2m8SVj9FLnuNXgM8VQS19XNfqqqgsjsl5L2uRo+W6H9H00mg+Uk5A/XhCROwksCQnn8xXA+8N8cRlJnSEPzFNaaIWeqVmya04ZEjRmB0WVEuydFuMP6b8nFyG100WZtWb3OlO8DjixZVaoeZUGcuZyBBcs9bGbBFLJMvXcL5gY3ROt8T/s8sKzt/Hbu/znRc0/+/QcQxdGP+1KjjttKa9XW51fRWx+rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Umexq5UWJnA97aYzPkpzxzfWCxk71cJvwc4Lp5srJgg=; b=Jubbda9TwEZyjIVQ+J32kZ5clNq5AQFOPq2I5otl4PFatF+WvgKOZ74d16/MQXl/VVWJfngSpIJKKWHyCFri69MscyheairB6SQSgZTUmuFsHOs02c2EqHaUjpc6Wtd5F9pPr57A86Hfx2pOiLjl12sllZMShxF+obqxSpZJJQ8Rt/oNTWPQW1LGNjhgCVZqx8vZE8pvfTqvjZFzMGmZwYQlOjVVJb3+jiGtDnmguDe0hd2/RuwH0We8gbvKQArRSht/GS2huf+k0+GvkBnmyhZbNilNdE0UxkcRlx8UdQAFhShFUTQS5oIkFhTOihO2Vhx/egjbddw6WX2wC9uwAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Umexq5UWJnA97aYzPkpzxzfWCxk71cJvwc4Lp5srJgg=; b=CaRn9BBfpltcSufvop9qraRnFxCy11NPei/GZ86+jsXDTLa3LB3PTuHvZ3jS6eicG0WdM+6iEzB8RYakVn5qnlyVKGGTs2yrJh0jxRFrsvQVyfBeW/liA15cymPJaL5xDTInYgjf4Orx2iKzno0s1EZhqm+p4XwSWp9jrf2icBGWDvcB7iFbJKoqHZ/aQMBN9z9Z9Mx+eV2feDrA0Y4RcvUf8Ch4iLpO+HAdzE140T7qcHugjhFRc18koFdDSnuuZnQIDrbGAJW8EBns01O3nKNtiyp1nj6BXufgfgtGvyCSngDb9foHtWmFcVqUIQpCj9SO+cq0Q51V0oc1g9gp0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <08c9df71-0470-c9eb-94f0-776eaacefa5b@suse.com> Date: Tue, 6 Sep 2022 17:07:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38a3969c-a2eb-48ee-093d-08da9019842b X-MS-TrafficTypeDiagnostic: DB8PR04MB6827:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lK0plYduDxur2+SMijmSleQsJta64BJBbu3xWNSkK5ImdCDX6XszAJk3ODieaB3hhtMS8DXdZrUJg0jHrHLuNHs9iQntwJZtzZjlJ78xN1gqNohV7CO1/zzNH1eBzz3tGmRyO0APWqNWg1EdwbBnDn28Sn2EH2P7Jm+lx2TalIIprL2XtV8nKAWAN7939Sg9338swVwpOfcHof3b1SjNvuntK5SPEo9OyDSAUgIaVC0CbcqqN72oqxcbnTgT6u9o9QNyHhUPI659XgNVch1SvU+80NmyChZPjRxDSzkpw0tQogSWYMEnEynhveEBux3Cra1iK9roLP1w+LlvpUTubsiFZfe5PvlP1M3x8HSlFcTQaaIMmUhC1+w9JoW2zkNkskH8OfW3usS/ywb5G2gtyUMbP7I9m+Auwmpu0hxhRoibBhi3B79ZSLrYd7Bus4QOPXc7zAFgwAanoaLEdDdaKow+xGqeHjcayDr9F28Ya75UHV18ltJSN2aumXV7WM30oEXI2EMDz0ZmPzV6DgrTiyIH2W7xwY2cip+7Tzi7wSboL1e36rmSYFyxc4gZqXFmXwcBBnf94LoEJJFEIFr7UJOiBVjOvfhECcfU84SN1hcCb9RCW4Te4WKwYVpjmPWWa3hlruR/INeEVfbDS1elCQNh4O9ewcZsXEV7mb9VMMqwdZxVS9vFWfrK7nBcOMtdnemC0s5/Z2u/9ZerDDHno5wAEZwwGmJxn+FCY7c3MuHOQTP+C1eriD0C/v+KxpnhhfmZWkOhObhOZ69Kl4VOL+anaxBT4D8JkV3gsKMWKGc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(39860400002)(376002)(366004)(6916009)(53546011)(31696002)(86362001)(31686004)(38100700002)(36756003)(316002)(54906003)(8676002)(66476007)(66556008)(66946007)(4326008)(478600001)(5660300002)(8936002)(6506007)(41300700001)(186003)(26005)(2906002)(6486002)(6512007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0I1WC85QjhjRE0waFRNbW5lS1FUN0V6ZGJHOTUwM2NBbGs3OFVqaEpNR1Qz?= =?utf-8?B?OVJsZmZRamsxRHdYR1ZxZStkZ3pTWlFGSXlNU0pHVExxbVJxSUpNMExSVmZi?= =?utf-8?B?dWFhSE03ZExvUUxUalRHYkwrYTJWZ0dTK0gva2ZsNlc1ZkxydDQrYjJEV2Uz?= =?utf-8?B?eXpVYmJZU2RodndKckhseWdLenFQczlNMjFna01mOEVOYktTWEN0TXgzSjBs?= =?utf-8?B?Y1ZSRzQ5SjRlMUw2VDZhWmxJcE9QeGo2bUx5NmxBZmxhbmpoU1N4eXB0Z05a?= =?utf-8?B?VGROb0owYTQrQUZzMlJ4cU1CdTBMS2lFdXA5Z0h3NXM3YWdGeUFWNHlHcjJK?= =?utf-8?B?S3NBaFlKdHZaSWFtR3JzZ2c3dUE3UnZJaHBHU0N3L2YvemdscFVzb2xQSFdK?= =?utf-8?B?d3VmTnQzZTMzZHdBdkJGMGFUYnF3RzVJVmVQTkkxNmYvRXhMbEdrNk1uSUlx?= =?utf-8?B?Z0dQK0J4YjZTQW1xdnZTdXZFc3U1L3psNVk5V0hmK01oek16RjhiTDg0RHhp?= =?utf-8?B?NElaRFk4c0JGRC92dDZjbWJDS2JiNmsxeHo5TzBFNEVXZHdKcEZVZlRPdEZY?= =?utf-8?B?Qml4VkN2REFqWWhlMUhTRlRQZUNNSE5tc0JZSm1GUXM1WU1BVHp0TnV2MzJh?= =?utf-8?B?dWkwMHhJNXExRnoxaTdCVlBGNVRsNk43WjF1LzhDaWdZRXdHd0s4SHN2Sm5S?= =?utf-8?B?VVdSMjNSZ0xiME9sSTR1VEVjMUlRSktYY0tjbXk0U1VQSVNFbjNSNnQzR2Nn?= =?utf-8?B?UklvNlVSR2RnSEM2QnhJZHYvcklxV3EvYWJnb09YRU1BaHpyZnh5MTJ3UWhU?= =?utf-8?B?OEdxQWdVUHZ4N3hReXVoRnQzNUZPb0M1NTNvMG4ycm5uUi84ZVIycGYyZm52?= =?utf-8?B?aHFDOFk5MWpiZlRFTzBzd2dMVDJNV29hU2VXZkMyc3craUJoYzVjOXFQcE1u?= =?utf-8?B?QUlSTkk5VTRDUU8wT0RBSEttcWIzOExxQjkvSmJuNFd4eEpBMmdIaW5OTDVP?= =?utf-8?B?RjlRc2hpVjhoOTVVOThPdXVBbHJCdVpSVUUyVEd5cHo3eVBGeDhVczRzYjRF?= =?utf-8?B?RG1vdDU2TEpBeHJmVDJoV0F6YVBCejFDKzZhL3VLOW9yY0ZIbHZqSFZDa0xZ?= =?utf-8?B?UURQeExyL29naU1IL1FmK1h4Z0hlUytjdmR3bG9VSExKV08xQkdqWXdwRDZT?= =?utf-8?B?SHRLWHBoMGt4UENucmVuM1pBUXhUYVc2b256VUFnRUlGbnUwbVVEekRzNWs5?= =?utf-8?B?RUNubExPOUIvenp6TG5rY0pVR2hVbXhERkYrK2hSd05OR2xJYkMrZmtJMzFw?= =?utf-8?B?TGVxNWZLZ1FwTmpkREZGM1V5RHZUbk4wNXhBcUlGRDd4TEpUZC9YdmxPNER6?= =?utf-8?B?bWtKWTA2MWFVeWRRLzBwcmhIVTBQZk4zOVI0dFhJY2FubGZObUVZVlAxaUh0?= =?utf-8?B?SXhiSWx5azJqaVN2enliZTdYWXJQNzdNYWtQVUJVSnlKcjJRWUsrVmFpRUsx?= =?utf-8?B?OHFCNHoxaDlXUWxmNnZCMHRteFdwd0M5eE9jZSsrOGxKUWRpd3hpK3Zwa05v?= =?utf-8?B?R2RZNGVLUjBVelZVSFl3dlhldS9WcXowNTE0aTdqaERqL3l6Rk1WdzRZT1ZF?= =?utf-8?B?YUxvaTl3aVNpbHorZkFRVFNtMHRReVRsVlpJaVlwMHl6cXhlQzhUQUhIQmhF?= =?utf-8?B?YTNTQmdadWFyUDVjU1oremQ4ZFh5V0VhN1BJVm55UlpZRDNRQlE1dFJ6TjVO?= =?utf-8?B?bzlZMEoxK1Y0TFdMc0hsSXFOdXZHOWFlMnl6T3U1bkhIbzlKanFaeERheFRm?= =?utf-8?B?RzFVNWYxQzRzdU9oMFhiNjZRU0NORTlTWWp6NVgzd3ovU2k3bk1jSmx3dXVR?= =?utf-8?B?SjRuTWEvKzBXL0MwWGJpSXVXdTNYMklQL2FzcDM0cFRUVzl3UGpmbFlJcE9K?= =?utf-8?B?bWlTcG1YWHU2NnAyTU5iZHpSYW5CalplU3owdzFqOWc1V2FMUlNLaDI1T3hn?= =?utf-8?B?b2VvUVRLUEZBc3Z2Vlh1Nk4wQUhQeFNDTHptS3NCelJwTk54QUg2M0VOQ0E2?= =?utf-8?B?Z0JBdnFQdy8xVXArSThsMnVRVHdiS0lyckord0dMS01MVHlwVmxKMy9pVFpT?= =?utf-8?Q?Srvo569/hWDg8NarcwY35C2jY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38a3969c-a2eb-48ee-093d-08da9019842b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:07:29.3122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kAWcqb4jKtetOitI/SqrwwcK6j7MdDxdXB7d2Xvt5ZWsm7o0gi24ahvp+J9DXTNBpI79u7izgSBeYl81TUih0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6827 On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote: > This allows configuring EHCI and XHCI consoles separately, > simultaneously. > > This changes string_param() to custom_param() in both ehci and xhci > drivers. Both drivers parse only values applicable to them. > > While at it, drop unnecessary memset() of a static variable. Are you sure of this? What if there are two "dbgp=xhci,..." options on the command line, the latter intended to override the earlier but malformed. Then ->enabled would be left set from parsing the first instance, afaict. > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -409,7 +409,7 @@ The following are examples of correct specifications: > Specify the size of the console ring buffer. > > ### console > -> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | none ]` > +> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | xhci | none ]` Personally I consider "dbc" more in line with "dbgp", but I'm okay with "xhci". We may want to allow for "ehci" then as an alias of "dbgp", though (in a separate, later patch). > --- a/xen/drivers/char/ehci-dbgp.c > +++ b/xen/drivers/char/ehci-dbgp.c > @@ -1464,7 +1464,18 @@ static struct uart_driver __read_mostly ehci_dbgp_driver = { > static struct ehci_dbgp ehci_dbgp = { .state = dbgp_unsafe, .phys_port = 1 }; > > static char __initdata opt_dbgp[30]; > -string_param("dbgp", opt_dbgp); > + > +static int __init parse_ehci_dbgp(const char *opt) > +{ > + if ( strncmp(opt, "ehci", 4) ) > + return 0; > + > + strlcpy(opt_dbgp, opt, sizeof(opt_dbgp)); > + > + return 0; > +} > + > +custom_param("dbgp", parse_ehci_dbgp); We commonly don't put a blank line between the function and this construct. (Same again further down then.) > --- a/xen/drivers/char/xhci-dbc.c > +++ b/xen/drivers/char/xhci-dbc.c > @@ -245,6 +245,7 @@ struct dbc { > uint64_t xhc_dbc_offset; > void __iomem *xhc_mmio; > > + bool enable; /* whether dbgp=xhci was set at all */ In dbc_init_xhc() there's an assumption that the "sbdf" field is always non-zero. Do you really need this separate flag then? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 15:19:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 15:19:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399941.641367 (Exim 4.92) (envelope-from ) id 1oVaLt-0003O2-UR; Tue, 06 Sep 2022 15:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399941.641367; Tue, 06 Sep 2022 15:19:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVaLt-0003Nv-Rb; Tue, 06 Sep 2022 15:19:01 +0000 Received: by outflank-mailman (input) for mailman id 399941; Tue, 06 Sep 2022 15:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVaLs-0003KR-Mq for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 15:19:00 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b307981-2df7-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 17:18:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8E679B81604; Tue, 6 Sep 2022 15:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EAF2C433D6; Tue, 6 Sep 2022 15:18:57 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oVaLn-008Nzo-1U; Tue, 06 Sep 2022 16:18:55 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b307981-2df7-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662477537; bh=mNJaIZb91PSi9lvS5+CXgUk5XGql3Zf6HOlb64/gTRY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fqsPje10yjJEAchvtSZ2UACKrRYrs7jup+8WPZHs2QwB/7GDnYaESRZ/RfadGDLBC V51G6xVy4eti1IMODx4iRnJOhx7JRyGK88plNCmtUZMfRz+9ZPsV2CKlW8qBPbyprS AQ7zgmW38Dd4KfVMErUULP5or/ocKmQfBoS37sE6ppsjYA3GG8EwZlSXoLRMANT5Hp Df16hL+EzG7fvTZCs0pwari7NRQELHaynNmVLqN5NMlNi9S7TCQUqzcgcA/eHS6ppB LoJnQNbSq4XsFrQHPit21rWdDhh5Gy/FWLEVhg1Yy6l6BYBCiSHifXBVpOMitxU3yT RRcgrL5MlNDuQ== Date: Tue, 06 Sep 2022 16:18:54 +0100 Message-ID: <87mtbcv8dd.wl-maz@kernel.org> From: Marc Zyngier To: Leo Yan Cc: Julien Grall , Ard Biesheuvel , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table In-Reply-To: References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> <87leqxq6qp.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: leo.yan@linaro.org, julien@xen.org, ardb@kernel.org, jbeulich@suse.com, Bertrand.Marquis@arm.com, Rahul.Singh@arm.com, peter.griffin@linaro.org, xen-devel@lists.xenproject.org, jgrall@amazon.com, mathieu.poirier@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 06 Sep 2022 16:13:25 +0100, Leo Yan wrote: > > On Tue, Sep 06, 2022 at 08:53:02AM +0100, Marc Zyngier wrote: > > [...] > > > > Okay, I think have two questions for you: > > > > > > - The first question is if we really need to reserve persistent memory > > > for RD pending table and configuration table when Linux kernel runs > > > in Xen domain? > > > > I have no idea, and really I don't want to know. The architecture > > doesn't make it safe to reuse that memory, and the driver does the > > right thing by always reserving that memory when the FW is supposed to > > support it. > > > > The "oh but it is safe on so and so" approach doesn't scale. If you > > want to have such a thing, just convince people at ARM that it is > > possible to implement a GICv3-compliant system without the RD tables, > > get them to update the architecture to allow this scheme and advertise > > it in a discoverable register. Xen could then implement it, Linux > > could check this bit, and we'd all be a happy family. > > I agree that my patch is not based on a scale approach, this is also > my concern. > > To be honest, convincing Arm GIC team is a bit out of my working scope. > I am working on automative project, when I saw verbose log with bunch of > kernel warnings with Xen, it motivated me to chase down, this is the > main reason I tried to explore some solutions at here. And it is fine to explore things. But I don't think there is a cheap option here. [...] > > - When the kexec kernel boots, all of the memory except for the > > reserved memory is reused. If your RD tables are used for anything, > > you'll see memory corruption as the GIC writes pending bits in the > > pending table, and you'll be unable to configure interrupts > > correctly. > > This gives me impression that when do a power cycle, CPUs are reset > but GIC is still alive, so for every booting time the same memory > region should be reserved for RD tables. > > To be honest, it's a bit weird for me that if a system cannot reset > CPUs and GIC together. There is no reset involved across kexec. That's the whole point. Nothing is reset, nothing is powered off. This is why kexec is so fast, and this is why it is so fragile. Thanks, M. -- Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Tue Sep 06 15:36:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 15:36:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399948.641383 (Exim 4.92) (envelope-from ) id 1oVacG-0005ss-H2; Tue, 06 Sep 2022 15:35:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399948.641383; Tue, 06 Sep 2022 15:35:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVacG-0005sl-Dw; Tue, 06 Sep 2022 15:35:56 +0000 Received: by outflank-mailman (input) for mailman id 399948; Tue, 06 Sep 2022 15:35:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVacE-0005sf-Tn for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 15:35:54 +0000 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [2607:f8b0:4864:20::d2b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97627148-2df9-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 17:35:53 +0200 (CEST) Received: by mail-io1-xd2b.google.com with SMTP id e195so9235491iof.1 for ; Tue, 06 Sep 2022 08:35:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97627148-2df9-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=GqM67eToD1ny8VVx70XQz+yqa9cCdNaLyhnIUfKzWx0=; b=o3N3QM1fYFh9QHqMEdh1kjn5ZTr3F8RtlpM5O2++y+WOWtF5VqFnmXM7INH/3C3eUV rtXiQP5g7p+1RoMGkcw8HpDxL1pIoLr71CH6AjbQWmEBhVb8u4LGn4/JVRQUuf+w77de 2tDN6e9GHnPV23R5EjAA9O+pg1qluKyo7jxsmW8SNYXPzCoVSh4f84J4gtZ4tZnhWZiK 26iwawWesNsxFg0dhAaf6JAFTmg9hfjLKKg0EVBzsaVgBhhTWcI8VbgoxxYwcOBeZkXo 2Fqq2sP/TfasoLql4YXx1PjqBffK+ktlknPqDflzAqCaK7N0WDBoy9seeNTqaG/m1+h6 JdKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=GqM67eToD1ny8VVx70XQz+yqa9cCdNaLyhnIUfKzWx0=; b=4OjoP2vWcbNhy3mi5/DvyAhDVTE6KoqOvhyEGCyFlnS+kK3KQMwKI+T3Og9EQkjE1M zX/G9WG1x4ZXX3Qx7hPmzxJIt2G9tHpPTRdRglnDNvroLC3RsJ1fAPBqI5AxlWL1dKmY nxq6gqmqpEUF05jYwi4tZR5Q9Twy99QeXkTSp9NIxb57a+Um8uZMn+iMMVD+RtggNCg4 pkjLrbKVCH5q46P6wy1MK0UHU0oZk00rh6ZsB1M0nEGAJTp0M27/dmEEAYVeBbi3J/gZ aVOyLkzJl3mzAoEi9yns73LjEJC59pR1N5FExJZIfXGOmGZtwEhmsV/rDU0JdcZiBbZ8 Z+2w== X-Gm-Message-State: ACgBeo2hktIztPzVuCtFrJDiJP4hj9GdbUAHjKKDJm1eLqGbGDzq41cV 6EdrJwD1ct2euXKJ9VjJB9Aa0fsKfWxVd0Ew9a5zPQ== X-Google-Smtp-Source: AA6agR7WoNKp8qX4Lx0DqP9V0mYU3T/qwubSi65FPamgmh5UtOzupuJjLfCYByP2mN5n26WVgQyFhPUIZ+awIHTyQbo= X-Received: by 2002:a02:740b:0:b0:349:bcdd:ca20 with SMTP id o11-20020a02740b000000b00349bcddca20mr30610852jac.110.1662478551322; Tue, 06 Sep 2022 08:35:51 -0700 (PDT) MIME-Version: 1.0 References: <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 6 Sep 2022 08:35:40 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Michal Hocko Cc: Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Tue, Sep 6, 2022 at 1:01 AM Michal Hocko wrote: > > On Mon 05-09-22 11:03:35, Suren Baghdasaryan wrote: > > On Mon, Sep 5, 2022 at 1:12 AM Michal Hocko wrote: > > > > > > On Sun 04-09-22 18:32:58, Suren Baghdasaryan wrote: > > > > On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > > > [...] > > > > > Yes, tracking back the call trace would be really needed. The question > > > > > is whether this is really prohibitively expensive. How much overhead are > > > > > we talking about? There is no free lunch here, really. You either have > > > > > the overhead during runtime when the feature is used or on the source > > > > > code level for all the future development (with a maze of macros and > > > > > wrappers). > > > > > > > > As promised, I profiled a simple code that repeatedly makes 10 > > > > allocations/frees in a loop and measured overheads of code tagging, > > > > call stack capturing and tracing+BPF for page and slab allocations. > > > > Summary: > > > > > > > > Page allocations (overheads are compared to get_free_pages() duration): > > > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > > > 8.8% lookup_page_ext > > > > 1237% call stack capture > > > > 139% tracepoint with attached empty BPF program > > > > > > Yes, I am not surprised that the call stack capturing is really > > > expensive comparing to the allocator fast path (which is really highly > > > optimized and I suspect that with 10 allocation/free loop you mostly get > > > your memory from the pcp lists). Is this overhead still _that_ visible > > > for somehow less microoptimized workloads which have to take slow paths > > > as well? > > > > Correct, it's a comparison with the allocation fast path, so in a > > sense represents the worst case scenario. However at the same time the > > measurements are fair because they measure the overheads against the > > same meaningful baseline, therefore can be used for comparison. > > Yes, I am not saying it is an unfair comparision. It is just not a > particularly practical one for real life situations. So I am not sure > you can draw many conclusions from that. Or let me put it differently. > There is not real point comparing the code tagging and stack unwiding > approaches because the later is simply more complex because it collects > more state. The main question is whether that additional state > collection is too expensive to be practically used. You asked me to provide the numbers in one of your replies, that's what I did. > > > > Also what kind of stack unwinder is configured (I guess ORC)? This is > > > not my area but from what I remember the unwinder overhead varies > > > between ORC and FP. > > > > I used whatever is default and didn't try other mechanisms. Don't > > think the difference would be orders of magnitude better though. > > > > > > > > And just to make it clear. I do realize that an overhead from the stack > > > unwinding is unavoidable. And code tagging would logically have lower > > > overhead as it performs much less work. But the main point is whether > > > our existing stack unwiding approach is really prohibitively expensive > > > to be used for debugging purposes on production systems. I might > > > misremember but I recall people having bigger concerns with page_owner > > > memory footprint than the actual stack unwinder overhead. > > > > That's one of those questions which are very difficult to answer (if > > even possible) because that would depend on the use scenario. If the > > workload allocates frequently then adding the overhead will likely > > affect it, otherwise might not be even noticeable. In general, in > > pre-production testing we try to minimize the difference in > > performance and memory profiles between the software we are testing > > and the production one. From that point of view, the smaller the > > overhead, the better. I know it's kinda obvious but unfortunately I > > have no better answer to that question. > > This is clear but it doesn't really tell whether the existing tooling is > unusable for _your_ or any specific scenarios. Because when we are > talking about adding quite a lot of code and make our allocators APIs > more complicated to track the state then we should carefully weigh the > benefit and the cost. As replied to other email I am really skeptical > this patchset is at the final stage and the more allocators get covered > the more code we have to maintain. So there must be a very strong reason > to add it. The patchset is quite complete at this point. Instrumenting new allocators takes 3 lines of code, see how kmalloc_hooks macro is used in https://lore.kernel.org/all/20220830214919.53220-17-surenb@google.com/ > > > For the memory overhead, in my early internal proposal with assumption > > of 10000 instrumented allocation call sites, I've made some > > calculations for an 8GB 8-core system (quite typical for Android) and > > ended up with the following: > > > > per-cpu counters atomic counters > > page_ext references 16MB 16MB > > slab object references 10.5MB 10.5MB > > alloc_tags 900KB 312KB > > Total memory overhead 27.4MB 26.8MB > > I do not really think this is all that interesting because the major > memory overhead contributors (page_ext and objcg are going to be there > with other approaches that want to match alloc and free as that clearly > requires to store the allocator objects somewhere). You mentioned that memory consumption in the page_owner approach was more important overhead, so I provided the numbers for that part of the discussion. > > > so, about 0.34% of the total memory. Our implementation has changed > > since then and the number might not be completely correct but it > > should be in the ballpark. > > I just checked the number of instrumented calls that we currently have > > in the 6.0-rc3 built with defconfig and it's 165 page allocation and > > 2684 slab allocation sites. I readily accept that we are probably > > missing some allocations and additional modules can also contribute to > > these numbers but my guess it's still less than 10000 that I used in > > my calculations. > > yes, in the current implementation you are missing most indirect users > of the page allocator as stated elsewhere so the usefulness can be > really limited. A better coverege will not increase the memory > consumption much but it will add an additional maintenance burden that > will scale with different usecases. Your comments in the last two letters about needing the stack tracing and covering indirect users of the allocators makes me think that you missed my reply here: https://lore.kernel.org/all/CAJuCfpGZ==v0HGWBzZzHTgbo4B_ZBe6V6U4T_788LVWj8HhCRQ@mail.gmail.com/. I messed up with formatting but hopefully it's still readable. The idea of having two stage tracking - first one very cheap and the second one more in-depth I think should address your concerns about indirect users. Thanks, Suren. > -- > Michal Hocko > SUSE Labs From xen-devel-bounces@lists.xenproject.org Tue Sep 06 16:05:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 16:05:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399954.641393 (Exim 4.92) (envelope-from ) id 1oVb56-0001Tr-R3; Tue, 06 Sep 2022 16:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399954.641393; Tue, 06 Sep 2022 16:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVb56-0001Tk-OB; Tue, 06 Sep 2022 16:05:44 +0000 Received: by outflank-mailman (input) for mailman id 399954; Tue, 06 Sep 2022 16:05:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVb55-0001Te-WB for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 16:05:44 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bfb9d491-2dfd-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 18:05:41 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7EDB23200980; Tue, 6 Sep 2022 12:05:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 06 Sep 2022 12:05:37 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Sep 2022 12:05:33 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfb9d491-2dfd-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1662480336; x= 1662566736; bh=/b6rewTD15B8psl8ty/HKy9EqprqbU19r3TMw5yOkrg=; b=E a0Jr9DymTMgk0LTPGt8Gs3LJtRxKkUzN9yeFBLHtFm8G3DoUfjsYdajA42K3nlnc vko4dJb+ujYLA4jW5BowPOssVE+I2ws7+XwWfCBP1mQD+CpZvmA33fneoTEbvLI+ NJ/REGJXUopb7BUFDtiuL7fSfaOAyu+SRtRxidML/ldceYE8h/8gQHao2AAp+kZv xcPn1ezb8ux1ZruLQrJFxZWP8DI5dKDCEWDuRSWaWK2Njca33dPTTql0RcYz8QP6 zIC1B7HXTgBuXY0DGoRAjsb6XSqyP/LTcY5Xu3ooQSedRVTjIQ6l8ngMtupPDPdh H8rjV/noQrxW3Ojux1nMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662480336; x=1662566736; bh=/b6rewTD15B8psl8ty/HKy9Eqprq bU19r3TMw5yOkrg=; b=hMxt2vq79N2J/uLCLtChtd1L9TZ76YA/Z+r/T+e40b4E d/Gfq1nnAEWsVNxH/OM5c1musYdTggsq5p8Br+EjyoVwU2zFMMpORWQ0BF615Adn S5w2AnKqqYq54dsW8Mp2/PNhZ4zbM2ZApGeLoT86b9EAq00eB8qZb6z0VhjzZ1pp sJn2LCyVEhwRsJt0oSGeWzh4xO02jzvb2dVe6sLwAEsU8X5A/gLuEwVUxJ/FgO0a AaqmZEBu7vto8tlr0mLbr9Hs2zkbmT757hX9wTOunY+zP9rwfCFUIEY5r+h2uvx7 VQzPAQplWKw096sFA7Cw6Ll0cKESw2zO9CjWdOqBbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelkedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 6 Sep 2022 18:05:31 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability Message-ID: References: <2f7b3495-7963-fa4a-f4c0-5b668238d337@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3eL0aqiAVgK7gIV0" Content-Disposition: inline In-Reply-To: <2f7b3495-7963-fa4a-f4c0-5b668238d337@suse.com> --3eL0aqiAVgK7gIV0 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 6 Sep 2022 18:05:31 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability On Tue, Sep 06, 2022 at 05:11:24PM +0200, Jan Beulich wrote: > On 02.09.2022 15:17, Marek Marczykowski-G=C3=B3recki wrote: > > Marek Marczykowski-G=C3=B3recki (10): > > drivers/char: allow using both dbgp=3Dxhci and dbgp=3Dehci > > console: support multiple serial console simultaneously > > IOMMU: add common API for device reserved memory > > IOMMU/VT-d: wire common device reserved memory API > > IOMMU/AMD: wire common device reserved memory API > > drivers/char: mark DMA buffers as reserved for the XHCI > > drivers/char: add RX support to the XHCI driver > > drivers/char: allow driving the rest of XHCI by a domain while Xen us= es DbC > > drivers/char: fix handling cable re-plug in XHCI console driver > > drivers/char: use smp barriers in xhci driver >=20 > I wonder in how far it would be possible to commit parts of this series. > Aiui patches 3-6 belong together (lacking a suitable ack on 4), but are > independent of 1 and 2. What I can't really tell is whether 7-9 are > independent of 1-6 and could hence go in. 7 share some context with at least patches 1 and 8 (but no functional dependency), and 9 modifies what 7 adds. But otherwise 7-9 should be independent of 2-6. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --3eL0aqiAVgK7gIV0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMXb8oACgkQ24/THMrX 1yxBkAgAg+2f1fYspzmSsXSSczfN5GJTvZ2CxTF7FLLPCLx9xwSMg5jqeo6T1/6g OP6fuBKY+4E0iQn+yNF+2vLMHo0QzHay7IQXxZ91gvIsypjedQF1CkvaGjnJ4gg/ 11URSDJ+/StsmGJJd18tLCI9oBT1KDPKrs7gm+9q++M7cl4ykmOrGTKhlOmaXd4R OVhCBMuDA8KBUy4Cd/hmzzwI6Pgh4+8iej3yEs7po+6tfr0JNgq4iRuu6nreVcTm 7i7R4n6O+4cdLeGxLDgunvEFhu1Eoq/BE1uBwre6CMab1H/c3YbYNlPFTiRG/A6Q 8E0kYIDdQqJ3UADUvF/SXGhO98T8eA== =jD8S -----END PGP SIGNATURE----- --3eL0aqiAVgK7gIV0-- From xen-devel-bounces@lists.xenproject.org Tue Sep 06 16:17:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 16:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399962.641405 (Exim 4.92) (envelope-from ) id 1oVbG8-00038m-RX; Tue, 06 Sep 2022 16:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399962.641405; Tue, 06 Sep 2022 16:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbG8-00038f-Ob; Tue, 06 Sep 2022 16:17:08 +0000 Received: by outflank-mailman (input) for mailman id 399962; Tue, 06 Sep 2022 16:17:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbG7-00038X-6P for xen-devel@lists.xen.org; Tue, 06 Sep 2022 16:17:07 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5773a119-2dff-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 18:17:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5773a119-2dff-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662481024; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YfF7/bF8WU/pjrvwWc2SIoOahm/BgDfKpK0v/DTvpPU=; b=MoSap0l/zEhuXVYLoUdHF6iS7HH9xrteBGGyc57NfGsYa4S/mhlFzx5b JPigDkBJykn/oD6mMsS0y/QDrIqsBjnJ7CFP9lADtA8h1OUPNvbzDbz27 LQzOfKmk+zZQbFkW+AZiXJB/J17aWViAhCxGggsvKv6Uyhzv7zKPuIH3c E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79564824 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:N7Mde6gBBSZwekD1TIwTXH+AX161IRcKZh0ujC45NGQN5FlHY01je htvCmvSa6nYZDPwLdknaoqxoUoEupHdn4BnTwM5/3pnQyob9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaQr414rZ8Ek15KWq5mtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4ePIZf+b91Wm5y9 v0JGBsAaxOgoM2nz+fuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI ZpCAdZsRE2ojxlnM1ELCJU4jaGwi2P2aTFwo1OJv6snpWPUyWSd1ZCyYYeLJozQGa25mG6Do 3DG0jzFWSo4d8yvxBujrF6+37bAyHaTtIU6S+Tjq68CbEeo7msXBR4NSUqgodG2j0e/X5RUL El80i8vrqV09EuvS9Tmdxm5pneeuVgbQdU4O+gz9AGMx7eS+wGYHGkJVBZFadovrshwTjsvv neLgtfoCDpHoLCTD3WH+d+8rzyoPjMOBXQffiJCRgwAi/H8pKkjgxSJScxseIarj9v+FDfsh T+XrTQigKk7ic8N3r+8u1fdjFqEtpXPCwI4+AjTdmak9R9iIp6oYcqv81ezxehBNouCTh+Co X0NgeCa7eYHF5bLkzaCKM0WALyn7vCCdibAiFRiG50g8TWF63+nfIZApjp5IS9BO8IJaXnjb UnVtA554J5VNWGtK6htbOqZENgwxLTnDpHpW+78acILZplqaBTB+CBobFSXmWf3nyARfboXY MnBN5z2VDBDVPohnGHeq/ohPaEDxyt5xjrRHp/HzBW24ZGTYX22bpgUPw7bBgwm159osDk54 v4GaZXQk0UEAbOgCsXE2dVNdA5XdBDXEbiz8pUKLbDbf2KKDUl7U5fsLaUdl5uJdki/vsPB5 TmDV0BR0zITblWXeFzROhiPhF4CNKuTTE7X3gR2Zz5EI1B5Pe6SAF43LvPbh4UP+u151uJTR PIYYciGCfknYm2ZpW5BNcOs89c4K03Daeey082NOWFXQnKdb1aRpo+MkvXHr0Hi8RZbReNh+ ub9h2s3sLIIRhh4Dda+Vc9DO2iZ5CFF8N+eqmOSfbG/jm2wr9UxQ8Ew59drS/wxxeLrn2HFi FjJXkZB9YEgYeYdqbH0uExNlK/xe8MWI6aQNzWzAWqeXcUCwlee/A== IronPort-HdrOrdr: A9a23:H/svbKoH2zbWblF2jXmc52kaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="79564824" Date: Tue, 6 Sep 2022 17:16:49 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V5 2/6] libxl: Add support for Virtio GPIO device Message-ID: References: <8ce51411dd910ead787be4aabb7239fcb3689972.1661159474.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8ce51411dd910ead787be4aabb7239fcb3689972.1661159474.git.viresh.kumar@linaro.org> On Mon, Aug 22, 2022 at 02:45:14PM +0530, Viresh Kumar wrote: > This patch adds basic support for configuring and assisting virtio-mmio > based virtio-gpio backend (emualator) which is intended to run out of > Qemu and could be run in any domain. > > An example of domain configuration for Virtio Gpio: > gpio = [ "" ] > > Please note, this patch is not enough for virtio-gpio to work on Xen > (Arm), as for every Virtio device we need to allocate Virtio MMIO params > (IRQ and memory region) and pass them to the backend, also update Guest > device-tree. A subsequent patch will add these missing bits. For the > current patch, the default "irq" and "base" are just written to the > Xenstore. > > Signed-off-by: Viresh Kumar Most comment on the previous patch would apply to this one as well. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 16:49:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 16:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399968.641415 (Exim 4.92) (envelope-from ) id 1oVblY-0006v1-Bx; Tue, 06 Sep 2022 16:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399968.641415; Tue, 06 Sep 2022 16:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVblY-0006uu-9S; Tue, 06 Sep 2022 16:49:36 +0000 Received: by outflank-mailman (input) for mailman id 399968; Tue, 06 Sep 2022 16:49:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVblW-0006um-KJ for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 16:49:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVblW-0007z4-7S; Tue, 06 Sep 2022 16:49:34 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVblW-0006Wu-1A; Tue, 06 Sep 2022 16:49:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AavnYCVndaxZ8M1n1FkbJ038HCZ5aYrZ/ftYuVs5Gg0=; b=NkwqR/tFQwH9cDoZLXptrDK5ei F1CtwpuHdKwNwmEL0l+42s8s8w97icZrFUIe1tFpYzSwVkwrbWbrQTRy2QKDlMqRkzEGozMFfqS6M B8lIHbvNUlxkwQmFVDTq+EqLsGy19km2sYmeyS5LzxZs0htGIi4hsLgDpuqDo7ZcY8qg=; Message-ID: Date: Tue, 6 Sep 2022 17:49:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/09/2022 10:55, Rahul Singh wrote: > This patch series merge the applicable Linux fixes to Xen. > > Bixuan Cui (1): > xen/arm: smmuv3: Change *array into *const array > > Christophe JAILLET (1): > xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation > > Gustavo A. R. Silva (1): > xen/arm: smmuv3: Fix fall-through warning for Clang > > Jean-Philippe Brucker (2): > xen/arm: smmuv3: Fix endianness annotations > xen/arm: smmuv3: Move definitions to a header > > Robin Murphy (1): > xen/arm: smmuv3: Remove the page 1 fixup > > Zenghui Yu (2): > xen/arm: smmuv3: Fix l1 stream table size in the error message > xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command > > Zhen Lei (1): > xen/arm: smmuv3: Remove unnecessary oom message > > Zhou Wang (1): > xen/arm: smmuv3: Ensure queue is read after updating prod pointer I didn't get the full series in my inbox. So I used the branch Bertrand pushed on gitlab [1]. That said, I had to tweak all the commit messages to remove the tags Issue-Id and Change-Id. I have also added Bertrand's reviewed-by tag on patch #3. It is now fully committed. Cheers, [1] https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc/-/tree/temp/smmuv3-fixes > > xen/drivers/passthrough/arm/smmu-v3.c | 741 ++------------------------ > xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ > 2 files changed, 708 insertions(+), 705 deletions(-) > create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:00:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399986.641466 (Exim 4.92) (envelope-from ) id 1oVbwE-0001PX-T0; Tue, 06 Sep 2022 17:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399986.641466; Tue, 06 Sep 2022 17:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbwE-0001PQ-QK; Tue, 06 Sep 2022 17:00:38 +0000 Received: by outflank-mailman (input) for mailman id 399986; Tue, 06 Sep 2022 17:00:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbwD-0001PI-BH for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 17:00:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbwD-0008Fr-1F; Tue, 06 Sep 2022 17:00:37 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVbwC-0003ch-Qx; Tue, 06 Sep 2022 17:00:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=thc3RkjNwpk19NBiowmfLh0ne6M/EVXpRATymosj1YA=; b=kLDqs6PzCR1D21Vt+NrzBca1y3 FAGftkPuLvVr/rkf0PhAYz4WCTMWWWuMAj5ECbjWI4xNOmcYg93cXkLezDBUTkhDIMjmS6EBW99PZ ANoQYOyTP6qLPAb/yC9jVHJ9Fw4ceHvJOMoKSn/CoCsPHo6zZxWCNs1MujaPWelI3764=; Message-ID: <7eb683c8-f03e-1fec-4da8-3e1fcc5dda71@xen.org> Date: Tue, 6 Sep 2022 18:00:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v12 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220906073919.941934-1-Penny.Zheng@arm.com> <20220906073919.941934-7-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220906073919.941934-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/09/2022 08:39, Penny Zheng wrote: > When a static domain populates memory through populate_physmap at runtime, > it shall retrieve reserved pages from resv_page_list to make sure that > guest RAM is still restricted in statically configured memory regions. > This commit also introduces a new helper acquire_reserved_page to make it work. > > Signed-off-by: Penny Zheng With one remark below: Reviewed-by: Julien Grall [...] > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 18d34d1b69..215f4c234b 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2755,9 +2755,8 @@ void free_domstatic_page(struct page_info *page) > put_domain(d); > } > > -static bool __init prepare_staticmem_pages(struct page_info *pg, > - unsigned long nr_mfns, > - unsigned int memflags) > +static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > + unsigned int memflags) > { > bool need_tlbflush = false; > uint32_t tlbflush_timestamp = 0; > @@ -2838,6 +2837,25 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, > return pg; > } > > +static int assign_domstatic_pages(struct domain *d, struct page_info *pg, > + unsigned int nr_mfns, unsigned int memflags) > +{ > + if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) > + { > + /* > + * Respective handling omitted here because right now > + * acquired static memory is only for guest RAM. "guest" commonly refers to any domain other than dom0. However, I can't see why this code couldn't be used by dom0. So it should be s/guest/domain/. I will modify it on commit. > + */ > + ASSERT_UNREACHABLE(); > + return -EINVAL; > + } > + > + if ( assign_pages(pg, nr_mfns, d, memflags) ) > + return -EINVAL; > + > + return 0; > +} > + Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:03:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399992.641478 (Exim 4.92) (envelope-from ) id 1oVbzN-00023h-B0; Tue, 06 Sep 2022 17:03:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399992.641478; Tue, 06 Sep 2022 17:03:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbzN-00023a-8F; Tue, 06 Sep 2022 17:03:53 +0000 Received: by outflank-mailman (input) for mailman id 399992; Tue, 06 Sep 2022 17:03:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbzM-00023U-3a for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 17:03:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVbzL-0008I2-AH; Tue, 06 Sep 2022 17:03:51 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVbzL-0003kL-3p; Tue, 06 Sep 2022 17:03:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GBPrQv9t/0DaG3asVLYtXAKvox9Tzk/QbmxUg+pM8sU=; b=es+wTLA234smCGUGr+VPCFYCxJ XziBoCnrXNdm8DKf3vfMZNOQ4LRxOq+kIJDCi23pDeTRz41JOou9pVPw08F/VZYeIE3DR99zq1Q8f 3U1BoGnhAVFjAbNb7r+bRehX7q+tvcOJVu4GECfT8GjcHq2uFo69rRmuMmMdPT3QxGbw=; Message-ID: <0da6388f-980a-9d6a-dedd-0af8e62887b6@xen.org> Date: Tue, 6 Sep 2022 18:03:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v12 0/6] populate/unpopulate memory when domain on static allocation Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220906073919.941934-1-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220906073919.941934-1-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/09/2022 08:39, Penny Zheng wrote: > Penny Zheng (6): > xen: do not free reserved memory into heap > xen/arm: introduce CDF_staticmem > xen: unpopulate memory when domain is static > xen: introduce prepare_staticmem_pages > xen: rename free_staticmem_pages to unprepare_staticmem_pages > xen: retrieve reserved pages on populate_physmap The series is now committed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:07:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.399997.641489 (Exim 4.92) (envelope-from ) id 1oVc2v-0002gn-Pc; Tue, 06 Sep 2022 17:07:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 399997.641489; Tue, 06 Sep 2022 17:07:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVc2v-0002gg-N0; Tue, 06 Sep 2022 17:07:33 +0000 Received: by outflank-mailman (input) for mailman id 399997; Tue, 06 Sep 2022 17:07:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVc2u-0002gX-F3 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 17:07:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVc2u-0008Ne-37; Tue, 06 Sep 2022 17:07:32 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVc2t-0003vP-SU; Tue, 06 Sep 2022 17:07:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=OrPL6edFbHNf4PgbW9O3IPHljYt4yiYIGbM2xSYxvA0=; b=TFnyYwKoyEBSFGsR/53NpPyD3v +LiuieeCsQieXy09nUk4XwJ0Kyj0Z4lfAQbuFS0eBU3WWyDnDrDt7M1LenoUSENrgOdIL/p/lKKqt EcgSlGv5MvQ5tDFOJgcq0xMUT5GT5PySj+YBSNRxwEGlQjNcbbXLNH4+K74CUboqt0Ug=; Message-ID: <6fbe179e-07b9-67a1-e5a6-d3a5cd1abb76@xen.org> Date: Tue, 6 Sep 2022 18:07:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 1/4] tools/xenstore: minor fix of the migration stream doc Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-2-jgross@suse.com> From: Julien Grall In-Reply-To: <20220905124746.1975-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/09/2022 13:47, Juergen Gross wrote: > Drop mentioning the non-existent read-only socket in the migration > stream description document. > > The related record field was removed in commit 8868a0e3f674 ("docs: > update the xenstore migration stream documentation). > > Signed-off-by: Juergen Gross Acked-by: Julien Grall I think this also want to be backported so the documentation is accurate on older release. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:08:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:08:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400000.641500 (Exim 4.92) (envelope-from ) id 1oVc3Z-0003EP-2b; Tue, 06 Sep 2022 17:08:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400000.641500; Tue, 06 Sep 2022 17:08:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVc3Y-0003EI-Vd; Tue, 06 Sep 2022 17:08:12 +0000 Received: by outflank-mailman (input) for mailman id 400000; Tue, 06 Sep 2022 17:08:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVc3X-0003Cz-Mo for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 17:08:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b78018c-2e06-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 19:08:09 +0200 (CEST) Received: from AM6P192CA0101.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::42) by VE1PR08MB5565.eurprd08.prod.outlook.com (2603:10a6:800:1b2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 17:08:07 +0000 Received: from AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::fe) by AM6P192CA0101.outlook.office365.com (2603:10a6:209:8d::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Tue, 6 Sep 2022 17:08:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT008.mail.protection.outlook.com (100.127.141.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 17:08:06 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Tue, 06 Sep 2022 17:08:06 +0000 Received: from d53e5faaf5cf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 45E8E883-DB05-4797-896F-767EE47C74D5.1; Tue, 06 Sep 2022 17:07:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d53e5faaf5cf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 17:07:59 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by PA4PR08MB6189.eurprd08.prod.outlook.com (2603:10a6:102:ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 6 Sep 2022 17:07:53 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 17:07:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b78018c-2e06-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=D0YK+AXLhQN3604KKcC8OgW7Hry/hkB/aQaSYV7aOde4s1pZkLwAoKeyVDFuU1JJLvYxQA7LhmIr/VwH/lJGTFyxE/iUiVfy1lh4dAz4OPjLeQZTld4Jz+BK0y+c14z6t4fcJJ3q52sp1S0s9KUBScN5WGJ598Wq304qIZs01RxcGB2W9Q4KwFSEuTb/4cdzVLejRKRpAcv5yg853mJ2gG+D2+2BQo0JvpMjau1mFs7CB5MkFLbcz44mkczqIl/DksevpTuksqWYWCrNdVHT7w3FR2uE4mElvlSIJ2e8BPDSUpP2CMI/ulFaCiBo3ZVI3PsvCaR3O//hxcRFg0i70w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lVHP1rld6IvDe38z2JNpji9FUKe0XMZ1+DJ2DQoL18I=; b=IlD5mWVsN9/u6o4Y4WaFq8+2fN6Pqnbv1OZvXEeTysLGcu31GHExWF3bSlxJMP6y+w6dS+LcE0dAw3/qsWuzI91iaQhd2xuV0yfDa6/saFO6C+2blBIYwsTjkshDPfO+e6x0ZWzSp4bpf8SoxaxtftI/kIHeqHh2d7hBmsPij4odh4q7XvQOGYIOiwERNvNRwYPPaQjHQbEtD2ABacwapjtf6kdqwpPyHICF0GkuGZCiyFyyKDkaqTBWwl/evuLHhY+k/B3vF2FoC6xMb6NRgg0LhHDTKir3jvVSve361I52pdN7cdguyEU+FnsJ96MilQhq3SjwJ1AoYSfHT53bBw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lVHP1rld6IvDe38z2JNpji9FUKe0XMZ1+DJ2DQoL18I=; b=8O9w3Rlo43sZrONZEafA1i7Hav80rn5PBep6LxvJuyHTDLwpfo1mqFZGkFeeUHb3obQs3djBKINsM/ZwTVmFs9GdmzjuAMDtOpZC2dOwZdPo/9XN15a6EWf7YR1F7GMRRlp3JO2aKlXRGJddtGIcP3G44VnMmW5ONCb6TDBIitM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4ee5f775c1f9f123 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRhDKthjr6AWY9R3Zwce5m6UrGn75yzKNwoxaERj2vbEJYzUSxLCRvpTylzth53ngi2bfB92mjSm9cKYf1cMz6+QHhWAqbxqV2vcgCGSCabftXaS4oZTjPtBA+cUtkTfYs+mqh6WSIJEfaWkqJeZeL5+5Mzmv4cJt8WN4z7TfgQg4lAMIfXk5SdLgu776F4fi4PjKJEdeigKfxdmp6XRidKjE+l3JNYk9IE091Ln+UWAcjhlbUCJxL3eiLu3I5kMiRc51aYZ5lWcNuLXuUfLEe+kzK5Y/yPXmJC2/UHI07mNpVFlSQpc7ESxKfLECntpz+nFLxlIeubwipcfaZ0eIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lVHP1rld6IvDe38z2JNpji9FUKe0XMZ1+DJ2DQoL18I=; b=GeAzTUPcpG/88aoWHt7RBpmzqfFggzikYeRDVUElsiAiDvv5jyQqzV9C3g2T2cLL+aBJH4kEWKq3cGwrmkszI/l6xylGgK1iBPbseU4OT258AR9oP1qmOOIqzD3BbXxHvarqXS1x0Me+z016d5s4/BL8Z+8EVVlSfv+wgIuYBA7xPK2dzwTJVn4xGnb85z9ag7RSzTnJpyYAKTpyYmkekjOffOXP/Av0124GYgG6hAT9j9zNI6S5IeF+WSlN2KW3AsYm2k5wvSzNLVarwIBLfAwd2z9AL/6l7Ub2fzX86rc4k5NtW2bNgj0o1aBPSehef3puAN+pk1W9HpxOQC4Mzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lVHP1rld6IvDe38z2JNpji9FUKe0XMZ1+DJ2DQoL18I=; b=8O9w3Rlo43sZrONZEafA1i7Hav80rn5PBep6LxvJuyHTDLwpfo1mqFZGkFeeUHb3obQs3djBKINsM/ZwTVmFs9GdmzjuAMDtOpZC2dOwZdPo/9XN15a6EWf7YR1F7GMRRlp3JO2aKlXRGJddtGIcP3G44VnMmW5ONCb6TDBIitM= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Thread-Topic: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Thread-Index: AQHYwdclHjvo1Mpgb0O6C3wbnsmdma3SnZgAgAAFHwA= Date: Tue, 6 Sep 2022 17:07:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c4d8747f-2f4a-4184-ff26-08da902a5e29 x-ms-traffictypediagnostic: PA4PR08MB6189:EE_|AM7EUR03FT008:EE_|VE1PR08MB5565:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AKzVO9RALx4oP1/IeuovlHIxHExklv+OlnIJGDj6k8gi3S9Ls/reK7qYNNQRo+usCEt+NQmPYR/eIngg3eGDHEnFxVFCnv7VfCMZOeMlLVB1AcEI/ZLFGHxX91Dkpv7ipUE1qCYixNnMpeIXwWRr873Om2kH8S0x2RfRpSneY8Fcqmzvr6nxahAVGuFDcUEQwGlgq3jSBBuuFPEvIdRnRtKpuNxifKB4yE1FGUhe7Y9HYctpyufts6PZoza2L6IqmPeJRMPXP384JtBQM4h85Nn6F86TnirS6eoLHeUG7dgvAky6ykKWHefQSCEmINcT9CWsCO69YbIl6sMNKFh3BY1OnuCc+tyT3zUcDEWFzVpHqLLnxsVXKKBVZGEwQ2+q7MBCk4AJQOsZu3uGfSgmESvleboknjn1HRkHLVpaFSxL2kCdb98/JoZtEnK24gUV75ZRH14LpuipVTE0QtsCky3RcXldJhl+aVgDRNnm9KKsJLiD+KUmj+3u+WFPsfvSmHggqeyqOJODiBWKhChifivJFmeB3/gUTHg3gk6SSjuxxJxci1MD6nNm7uLi5CTGcKqaUwzHmXMusuXMTTpuFMJ0CVI8q4fjgOx1+WetNpAUGRzfpZTTkwtWt9ZccqbuFqAnY5OEAXHlQOzZsKAgt/9pWIU0Tw98MCuE60b2A2217GXWltajtG8Qye6MQR7YN6GXaJcoMeYfenRv4UuWTwR4/rLM3GAU/14udiWyRm2EsShEsLERE6Fm3A2DTqclt7QoAUNKgR73YcWhHt5UnvQaOcXl9fy3BRGdRgsvp0Y= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(2906002)(316002)(33656002)(186003)(66556008)(5660300002)(8936002)(66476007)(76116006)(8676002)(4326008)(66446008)(6916009)(66946007)(64756008)(36756003)(54906003)(91956017)(41300700001)(6506007)(478600001)(53546011)(71200400001)(86362001)(6512007)(6486002)(38100700002)(26005)(38070700005)(83380400001)(122000001)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6189 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4e693e6f-cdb4-4708-e33a-08da902a5609 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KhnE40Rgqpjlz/9Wm7HAY7RuyIiQyXHIa0oq24FDg4o+35eLo0oivan3amUM/ry8cTiHwuQjoKC6QOmjNa6611ikBJgHB8j3j27/TTpnBDvKSk81aHU6CWpO53trlMo88UAlfPEPaVTIKpjYxA/4n8AOKcSmxZN419PZUiKC6bkU71Urc1vcNztogrOoMc37rPqWOwsN1nsCMUQuMsEw4Q6hSw8ITxDG7Cp6XYWfTsLhto2rnwTZJo33wswj+sEdxFyT7A5GNHloZd1qHNRJRiMr4PwuYVRGdDcNaP21dpp+FDkWvX0PPgU0VYoTVD6wTpBrgNMzp02yaCNw3vZHgJ0ZB4EjWN42WqcwnNS3I0jMnHNF/uYPg6gyCqJ2TVVx8sB+4w0RHV5NSRISU+qkQ3HeZ7w0uphD3NnTpru2mTtikBjtEyVvA1B9Mddf8LA/4acs/h+fueIVWO8d8aoJ9Uv5xXGho6uPKQzOewaI0T4MDyG4P2qqeWhSi6D/ip8ZtePrPAIdwucoRy8Q4i8MQFv1xCNEGZ/iWfl00+dyH9cuM44UreTrk029rCwe7Eav6F28yv0tX/G5tSczUK05tw3dePiQRxco5p2CUaJ06kNjx0IKwVYGQYYgpQ3nHqtlGOsxr/HRZ41OrH+XNyifVPC3BmrmXDFqZmyK91UsdQRNa661cWpEUvHQfTmPbV4WAYfxqD2yHt0KqTsDhyPQSDF7sZEASIENTpGONYJAJrcfbA9ODGFR07gbQCJfm9A1yYe/YKl1qIrd9if9PtNXEA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(376002)(39860400002)(40470700004)(46966006)(36840700001)(6506007)(186003)(53546011)(336012)(2616005)(5660300002)(47076005)(8936002)(40480700001)(6862004)(107886003)(6486002)(6512007)(86362001)(26005)(36756003)(478600001)(41300700001)(33656002)(40460700003)(82740400003)(356005)(81166007)(54906003)(8676002)(4326008)(70586007)(2906002)(70206006)(316002)(83380400001)(82310400005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 17:08:06.8558 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4d8747f-2f4a-4184-ff26-08da902a5e29 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5565 Hi Julien, > On 6 Sep 2022, at 5:49 pm, Julien Grall wrote: >=20 > Hi, >=20 > On 06/09/2022 10:55, Rahul Singh wrote: >> This patch series merge the applicable Linux fixes to Xen. >> Bixuan Cui (1): >> xen/arm: smmuv3: Change *array into *const array >> Christophe JAILLET (1): >> xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation >> Gustavo A. R. Silva (1): >> xen/arm: smmuv3: Fix fall-through warning for Clang >> Jean-Philippe Brucker (2): >> xen/arm: smmuv3: Fix endianness annotations >> xen/arm: smmuv3: Move definitions to a header >> Robin Murphy (1): >> xen/arm: smmuv3: Remove the page 1 fixup >> Zenghui Yu (2): >> xen/arm: smmuv3: Fix l1 stream table size in the error message >> xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command >> Zhen Lei (1): >> xen/arm: smmuv3: Remove unnecessary oom message >> Zhou Wang (1): >> xen/arm: smmuv3: Ensure queue is read after updating prod pointer >=20 > I didn't get the full series in my inbox. So I used the branch Bertrand p= ushed on gitlab [1]. That said, I had to tweak all the commit messages to r= emove the tags Issue-Id and Change-Id. >=20 > I have also added Bertrand's reviewed-by tag on patch #3. >=20 > It is now fully committed. =20 Thanks for committing the series.=20 Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:27:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:27:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400014.641534 (Exim 4.92) (envelope-from ) id 1oVcM5-00064U-Ta; Tue, 06 Sep 2022 17:27:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400014.641534; Tue, 06 Sep 2022 17:27:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcM5-00064N-R1; Tue, 06 Sep 2022 17:27:21 +0000 Received: by outflank-mailman (input) for mailman id 400014; Tue, 06 Sep 2022 17:27:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcM4-00064H-Qo for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 17:27:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcM4-0000JJ-J9; Tue, 06 Sep 2022 17:27:20 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVcM4-0004pu-Bg; Tue, 06 Sep 2022 17:27:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5xqRxTSdQfnAJhNEOLAqBnxtUNiNRaBHYlGG5mw6X1E=; b=shLFaw1bPTnQPAESu7rTDIlT7C SkVsZ39L1TnZ7z/ilBokcnrLIC7tiI8N1F8xFowB6OYEKFD1za91/e3Ipkx9AGGjYmQD4AV9v5AXg gaBHbBED2s8UjuerOlzQtGVKGD90nhYfORIp/ELquk7BNx/YgpDiZcQJ992losRqkC4M=; Message-ID: Date: Tue, 6 Sep 2022 18:27:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-5-jgross@suse.com> From: Julien Grall In-Reply-To: <20220905124746.1975-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 05/09/2022 13:47, Juergen Gross wrote: > Extend the definition of the Xenstore migration stream to cover new > features: > > - per domain features > - extended watches (watch depth) > - per domain quota > > Signed-off-by: Juergen Gross > --- > V3: > - new patch > V4: > - add new record types instead of modifying the existing ones > (Julien Grall) > --- > docs/designs/xenstore-migration.md | 160 ++++++++++++++++++++++++++++- > 1 file changed, 155 insertions(+), 5 deletions(-) > > diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md > index efa526f420..c70505c43a 100644 > --- a/docs/designs/xenstore-migration.md > +++ b/docs/designs/xenstore-migration.md > @@ -43,7 +43,14 @@ the setting of the endianness bit. > |-----------|---------------------------------------------------| > | `ident` | 0x78656e73746f7265 ('xenstore' in ASCII) | > | | | > -| `version` | 0x00000001 (the version of the specification) | > +| `version` | The version of the specification, defined values: | > +| | 0x00000001: all fields and records without any | > +| | explicitly mentioned version | > +| | dependency are valid. | > +| | 0x00000002: all fields and records valid for | > +| | version 1 plus fields and records | > +| | explicitly stated to be supported in | > +| | version 2 are valid. | I think it would be useful to outline in the commit message why the version had to be bumped. > | | | > | `flags` | 0 (LSB): Endianness: 0 = little, 1 = big | > | | | > @@ -77,7 +84,10 @@ NOTE: padding octets here and in all subsequent format specifications must be > | | 0x00000003: WATCH_DATA | > | | 0x00000004: TRANSACTION_DATA | > | | 0x00000005: NODE_DATA | > -| | 0x00000006 - 0xFFFFFFFF: reserved for future use | > +| | 0x00000006: GLOBAL_QUOTA_DATA | > +| | 0x00000007: DOMAIN_DATA | > +| | 0x00000008: WATCH_DATA_EXTENDED (version 2 and up) | > +| | 0x00000009 - 0xFFFFFFFF: reserved for future use | > | | | > | `len` | The length (in octets) of `body` | > | | | > @@ -129,6 +139,7 @@ xenstored state that needs to be restored. > | `evtchn-fd` | The file descriptor used to communicate with | > | | the event channel driver | > > + Spurious change? > xenstored will resume in the original process context. Hence `rw-socket-fd` > simply specifies the file descriptor of the socket. Sockets are not always > used, however, and so -1 will be used to denote an unused socket. > @@ -241,9 +252,9 @@ the file descriptor of the socket connection. > > ### WATCH_DATA > > -The image format will contain a `WATCH_DATA` record for each watch registered > -by a connection for which there is `CONNECTION_DATA` record previously present. > - > +The image format will contain either a `WATCH_DATA` or a `WATCH_DATA_EXTENDED` > +record for each watch registered by a connection for which there is > +`CONNECTION_DATA` record previously present. > > ``` > 0 1 2 3 octet > @@ -406,6 +417,145 @@ A node permission specifier has the following format: > Note that perm1 defines the domain owning the node. See [4] for more > explanation of node permissions. > > +\pagebreak > + > +### GLOBAL_QUOTA_DATA > + > +This record is only relevant for live update. It contains the global settings > +of xenstored quota. > + > +``` > + 0 1 2 3 octet > ++-------+-------+-------+-------+ > +| n-dom-quota | n-glob-quota | > ++---------------+---------------+ > +| quota-val 1 | > ++-------------------------------+ > +... > ++-------------------------------+ > +| quota-val N | > ++-------------------------------+ > +| quota-names > +... > +``` > + > + > +| Field | Description | > +|----------------|----------------------------------------------| > +| `n-dom-quota` | Number of quota values which apply per | > +| | domain. | I would add "by default" or something similar to make clear that the value in DOMAIN_DATA will override any quota set here. But see below about 'n-dom-quota' and 'n-glob-quota'. > +| | | > +| `n-glob-quota` | Number of quota values which apply globally | > +| | only. | > +| | | > +| `quota-val` | Quota values, first the ones applying per | > +| | domain, then the ones applying globally. A | > +| | value of 0 has the semantics of "unlimited". | It is unclear to me why you need to make the distinction between "per domain" and "globally". IOW shouldn't be the name of the quota already indicates that? > +| | | > +| `quota-names` | 0 delimited strings of the quota names in | > +| | the same sequence as the `quota-val` values. | > + > + > +Allowed quota names are those explicitly named in [2] for the `GET_QUOTA` > +and `SET_QUOTA` commands, plus implementation specific ones. Quota names not > +recognized by the receiving side must be ignored. > + > +\pagebreak > + > +### DOMAIN_DATA > + > +This record is optional and can be present once for each domain. > + > + > +``` > + 0 1 2 3 octet > ++-------+-------+-------+-------+ > +| domain-id | n-quota | > ++---------------+---------------+ > +| features | > ++-------------------------------+ > +| quota-val 1 | > ++-------------------------------+ > +... > ++-------------------------------+ > +| quota-val N | > ++-------------------------------+ > +| quota-names > +... > +``` > + > + > +| Field | Description | > +|----------------|----------------------------------------------| > +| `domain-id` | The domain-id of the domain this record | > +| | belongs to. | > +| | | > +| `n-quota` | Number of quota values. | > +| | | > +| `features` | Value of the feature field visible by the | > +| | guest at offset 2064 of the ring page. | > +| | Aligned to the next 4 octet boundary. | Stale sentence? > +| | Only valid for version 2 and later. | Can you mention explicitly whether the field will unknown or 0 for version 1? > +| | | > +| `quota-val` | Quota values, a value of 0 has the semantics | > +| | "unlimited". | > +| | | > +| `quota-names` | 0 delimited strings of the quota names in | > +| | the same sequence as the `quota-val` values. | > + > +Allowed quota names are those explicitly named in [2] for the `GET_QUOTA` > +and `SET_QUOTA` commands, plus implementation specific ones. Quota names not > +recognized by the receiving side must be ignored. > + > +\pagebreak > + > +### WATCH_DATA_EXTENDED NIT: I think it would be more logical if this is defined right next after WATCH_DATA. > + > +The image format will contain either a `WATCH_DATA` or a `WATCH_DATA_EXTENDED` > +record for each watch registered by a connection for which there is > +`CONNECTION_DATA` record previously present. The `WATCH_DATA_EXTENDED` record > +type is valid only in version 2 and later. > + > +``` > + 0 1 2 3 octet > ++-------+-------+-------+-------+ > +| conn-id | > ++---------------+---------------+ > +| wpath-len | token-len | > ++---------------+---------------+ > +| depth | | > ++---------------+---------------+ It is not clear what would be the value of octet 2-3. Is it RES0 or UNKNOWN? > +| wpath > +... > +| token > +... > +``` > + > + > +| Field | Description | > +|-------------|-------------------------------------------------| > +| `conn-id` | The connection that issued the `WATCH` | > +| | operation [2] | > +| | | > +| `wpath-len` | The length (in octets) of `wpath` including the | > +| | NUL terminator | > +| | | > +| `token-len` | The length (in octets) of `token` including the | > +| | NUL terminator | > +| | | > +| `depth` | The number of directory levels below the | > +| | watched path to consider for a match. | > +| | A value of 0xffff is used for unlimited depth. | > +| | | > +| `wpath` | The watch path, as specified in the `WATCH` | > +| | operation | > +| | | > +| `token` | The watch identifier token, as specified in the | > +| | `WATCH` operation | > + > +\pagebreak > + > + > * * * > > [1] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/designs/non-cooperative-migration.md Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:51:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400021.641549 (Exim 4.92) (envelope-from ) id 1oVciv-00015Y-VB; Tue, 06 Sep 2022 17:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400021.641549; Tue, 06 Sep 2022 17:50:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVciv-00015R-SQ; Tue, 06 Sep 2022 17:50:57 +0000 Received: by outflank-mailman (input) for mailman id 400021; Tue, 06 Sep 2022 17:50:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVciu-00015H-JT; Tue, 06 Sep 2022 17:50:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVciu-0000hS-Ib; Tue, 06 Sep 2022 17:50:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVciu-0001E7-2b; Tue, 06 Sep 2022 17:50:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVciu-0001iM-28; Tue, 06 Sep 2022 17:50:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0f1Ldte6gLO6sx8edsl7I5lgWVKh4IO9StaFO8YbOBU=; b=tS8Cqtt3KseIsLMvNBo459fcvU G3kTcpsaI6b1AeDtNNqLclL3JlP2o25cIbGL2jgsAW6rPVPA2QhFt89A/QORSH5NL9TtGTtPwBrBx v4OSUEcp08fyTfTcUK43RlRtffm1Zt7KIUqBkZG5pkdHoUFno4EW2MD/j+2wV8tU/6sM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173024: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=f7da805b506034f50ebf7d9c2a247a80ee8e987a X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 06 Sep 2022 17:50:56 +0000 flight 173024 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173024/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf f7da805b506034f50ebf7d9c2a247a80ee8e987a baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 32 days 254 attempts Testing same since 173024 2022-09-06 14:14:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abner Chang Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1985 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 17:56:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 17:56:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400029.641561 (Exim 4.92) (envelope-from ) id 1oVcoP-0001j7-LK; Tue, 06 Sep 2022 17:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400029.641561; Tue, 06 Sep 2022 17:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcoP-0001j0-Gm; Tue, 06 Sep 2022 17:56:37 +0000 Received: by outflank-mailman (input) for mailman id 400029; Tue, 06 Sep 2022 17:56:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcoN-0001iu-CW for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 17:56:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcoM-0000o9-VK; Tue, 06 Sep 2022 17:56:34 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVcoM-0006Bs-PS; Tue, 06 Sep 2022 17:56:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1YY25Gsv032TcI3kXiyGuPIuU9TCO+941wu9jmBSMp4=; b=tI4LCNpx5PCopXaU3sGH71VZM/ 8J3gZZP5wYLXyx3onjqcTl1vfmchiUliM56KzYbeTGZwvGDAcpABvojH+R92yCcgY0WXa+akGvdb6 iD4bhil/hXHYAWnWC4YuakHl9rrFOXN4ewI2mPISjQ3oBlcUz7lGcmluCsJAo7k+lQXA=; Message-ID: <3d6d92f5-6f5e-6250-d693-0f0415e7e5eb@xen.org> Date: Tue, 6 Sep 2022 18:56:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 1/9] xen/arm: introduce static shared memory To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-2-Penny.Zheng@arm.com> Content-Language: en-US From: Julien Grall In-Reply-To: <20220906085941.944592-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/09/2022 09:59, Penny Zheng wrote: > + for ( i = 0; i < mem->nr_banks; i++ ) > + { > + /* > + * Meet the following check: > + * 1) The shm ID matches and the region exactly match > + * 2) The shm ID doesn't match and the region doesn't overlap > + * with an existing one > + */ > + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) > + { > + if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) > + break; > + else > + { > + printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", > + shm_id); > + return -EINVAL; > + } > + } > + else > + { > + paddr_t end = paddr + size; > + paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; > + > + if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) > + printk("fdt: static shared memory region %s overflow\n", shm_id); Why are you continuing here? > + > + if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) > + { > + if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) > + continue; > + else > + { > + printk("fdt: different shared memory region could not share the same shm ID %s\n", > + shm_id); > + return -EINVAL; > + } > + } > + else > + { > + printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", > + mem->bank[i].start, bank_end); > + return -EINVAL; > + } > + } > + } > + > + if ( i == mem->nr_banks ) > + { > + if ( i < NR_MEM_BANKS ) > + { > + /* Static shared memory shall be reserved from any other use. */ > + safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); > + mem->bank[mem->nr_banks].start = paddr; > + mem->bank[mem->nr_banks].size = size; > + mem->bank[mem->nr_banks].xen_domain = true; > + mem->nr_banks++; > + } > + else > + { > + printk("Warning: Max number of supported memory regions reached.\n"); > + return -ENOSPC; > + } > + } > + /* > + * keep a count of the number of borrowers, which later may be used > + * to calculate the reference count. > + */ > + if ( !owner ) > + mem->bank[i].nr_shm_borrowers++; > + > + return 0; > +} > +#else > +static int __init process_shm_node(const void *fdt, int node, > + uint32_t address_cells, uint32_t size_cells) > +{ > + printk("CONFIG_STATIC_SHM must be enabled for parsing static shared memory nodes\n"); > + WARN(); NIT: The WARN() here seems pointless because the call trace is not deep *and* it would not be printed unless you are using earlyprintk. Anyway, the only reason I am not acking this patch is related to the question I asked above. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 18:01:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 18:01:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400034.641571 (Exim 4.92) (envelope-from ) id 1oVcsd-0003G1-5c; Tue, 06 Sep 2022 18:00:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400034.641571; Tue, 06 Sep 2022 18:00:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcsd-0003Fu-24; Tue, 06 Sep 2022 18:00:59 +0000 Received: by outflank-mailman (input) for mailman id 400034; Tue, 06 Sep 2022 18:00:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcsc-0003Fo-2T for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 18:00:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVcsb-0000yb-Pp; Tue, 06 Sep 2022 18:00:57 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.11.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVcsb-0006WG-Ij; Tue, 06 Sep 2022 18:00:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Ng6SYtBg0jHyvkM+YgAbiGzd686ewQLK4Sf7vwOmRMA=; b=A9HFGxT8H13RMPZ1VXnYNq+xDQ IEn38RzU7PK5J7GBlJYorBdqvVmCFCeCiFz+7RnwopNoAOdUCxnYEfXkmDI/cwF5eWoynStojWhfA V7DLDzXEUMPhjINcPSl17HJSwzz8L6eft9U1++AmNbjmgIxJZ9SWxPkPdgZuD0xMjoT4=; Message-ID: Date: Tue, 6 Sep 2022 19:00:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 1/9] xen/arm: introduce static shared memory Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220906085941.944592-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/09/2022 09:59, Penny Zheng wrote: > static int __init early_scan_node(const void *fdt, > int node, const char *name, int depth, > u32 address_cells, u32 size_cells, > @@ -386,6 +549,8 @@ static int __init early_scan_node(const void *fdt, > process_chosen_node(fdt, node, name, address_cells, size_cells); > else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) > rc = process_domain_node(fdt, node, name, address_cells, size_cells); > + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) > + rc = process_shm_node(fdt, node, address_cells, size_cells); > > if ( rc < 0 ) > printk("fdt: node `%s': parsing failed\n", name); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..995eee1d09 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -23,10 +23,17 @@ typedef enum { > } bootmodule_kind; > > > +/* Indicates the maximum number of characters(\0 included) for shm_id */ > +#define MAX_SHM_ID_LENGTH 16 > + > struct membank { > paddr_t start; > paddr_t size; > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > +#ifdef CONFIG_STATIC_SHM > + char shm_id[MAX_SHM_ID_LENGTH]; > + unsigned int nr_shm_borrowers; > +#endif I forgot to mention that this will clash with Henry's series [1]. As both series are meant for 4.17, please coordinate to decide which series should be merged first (this is to avoid last minute clash on Friday). Cheers, [1] https://lore.kernel.org/xen-devel/20220905072635.16294-1-Henry.Wang@arm.com/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 18:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 18:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400041.641582 (Exim 4.92) (envelope-from ) id 1oVdZz-0007gt-IG; Tue, 06 Sep 2022 18:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400041.641582; Tue, 06 Sep 2022 18:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdZz-0007gm-Ez; Tue, 06 Sep 2022 18:45:47 +0000 Received: by outflank-mailman (input) for mailman id 400041; Tue, 06 Sep 2022 18:45:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdZx-0007gc-Ne; Tue, 06 Sep 2022 18:45:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdZx-0001hj-K5; Tue, 06 Sep 2022 18:45:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdZx-0004Xz-7y; Tue, 06 Sep 2022 18:45:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVdZx-00081c-7T; Tue, 06 Sep 2022 18:45:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7jtTOOBnaSUpql2t8Gg/8k4HhMHEmDryVVh6M/KZwDo=; b=NY/SgPtld+gkNtfUZLgYKS/Ddj lRIMWonRAda+Da9H7KGVL4vj0cgSyFranUnQzbQMqvLFbANqdN5i8E5N+sZVNT6ru7C5WrQkrcWIa KZUWQzSXSZp1xEDAxRcdVAVqkZd0SQWXm9wP0pQAjXbqTe2SgxpiOBEIGDV8jK61CeyA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173020: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=fd28528ece590dc709d1a893fce2ff2f68ddca70 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Tue, 06 Sep 2022 18:45:45 +0000 flight 173020 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173020/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu fd28528ece590dc709d1a893fce2ff2f68ddca70 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 34 days Failing since 172148 2022-08-04 21:39:38 Z 32 days 75 attempts Testing same since 173020 2022-09-06 08:26:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5661 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 18:57:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 18:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400049.641592 (Exim 4.92) (envelope-from ) id 1oVdl2-0000sG-RY; Tue, 06 Sep 2022 18:57:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400049.641592; Tue, 06 Sep 2022 18:57:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdl2-0000s9-Ow; Tue, 06 Sep 2022 18:57:12 +0000 Received: by outflank-mailman (input) for mailman id 400049; Tue, 06 Sep 2022 18:57:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdl1-0000rz-Et; Tue, 06 Sep 2022 18:57:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdl1-0001tP-D2; Tue, 06 Sep 2022 18:57:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVdl0-0004sl-UP; Tue, 06 Sep 2022 18:57:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVdl0-0005XF-Tv; Tue, 06 Sep 2022 18:57:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1pbigw597JTT5pE48hVBPm036xfMufq0SjgnFZKNXmg=; b=GzP625cIQ5kl2TZtzp/wx8wa0k CcrqH/1cajnWcDrXpiDztt9DCiMyGgY3sgtU2167e0vC/ItD6VnZZKZg9oRmfvQmuAnUtsUgwg3sQ 37LByBi29gH7rSv+n1IU5CPZGnqm66m/hGOjA8qvUGS2C2FoF2pw1kZrlBwBUQIb4jf4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173026: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=48f35317c2e2707fc66a839690fe41e6f16180de X-Osstest-Versions-That: xen=d84473689611eed32fd90b27e614f28af767fa3f From: osstest service owner Date: Tue, 06 Sep 2022 18:57:10 +0000 flight 173026 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173026/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173002 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 48f35317c2e2707fc66a839690fe41e6f16180de baseline version: xen d84473689611eed32fd90b27e614f28af767fa3f Last test of basis 173002 2022-09-05 11:00:30 Z 1 days Testing same since 173026 2022-09-06 15:00:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Daniel P. Smith Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d844736896..48f35317c2 48f35317c2e2707fc66a839690fe41e6f16180de -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400057.641604 (Exim 4.92) (envelope-from ) id 1oVgFX-0008LF-67; Tue, 06 Sep 2022 21:36:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400057.641604; Tue, 06 Sep 2022 21:36:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFX-0008L8-26; Tue, 06 Sep 2022 21:36:51 +0000 Received: by outflank-mailman (input) for mailman id 400057; Tue, 06 Sep 2022 21:36:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFW-0008L2-0i for xen-devel@lists.xen.org; Tue, 06 Sep 2022 21:36:50 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 214c4654-2dff-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:15:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 214c4654-2dff-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662480935; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dC3wKAwJzVhdLJUzJPu+iEcsBHvMOMD1jcKQFpuYgNo=; b=GZO0wmUSQKly795LS7IwQfQn6QC0ZPvC7v/hEuZiaXshi+qNT9AYWNsD t8yYhMBaK/az2ErDao0BmfwAsvwlP4TAvUll0Z647T/bj40Eeguv4htmQ 9jcCcjuop34VPygtycBiHunhYGJ8Xzh4SC5I2noEEj+0zi7FwyMrWb7Uy 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79862586 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:KUtKB6KVwXAqOJLaFE+RkJIlxSXFcZb7ZxGr2PjKsXjdYENSgTxWn 2IZWDyPPP7cMWT0KtAgOd6w8kJUsJDUz4ViS1BlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/Pb9ks11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE5O5BBWEEJq0jy91vA3BK8 M0hMmAuYUXW7w626OrTpuhEg80iKI/gPZ8Fu2EmxjbcZRokacmdGeOQv4YehWpuwJAVdRrdT 5NxhT5HZRLcYxpJKxEPBYg3huuAjXjjaTxI7lmSoMLb5kCMnVwviuW9brI5fPS2XdpbmmCcr VuBoWPgLDQrEsG45ROspyfEaujnwnqgBdN6+KeD3vlujV6I2n0ICDUZUFK6pb+yjUvWc9deK EFS+i0qqKUp3EiqSNDnWFu/unHslhsVR9pRHvB88AaM0KvZ+S6dB24NVDkHY9sj3Oc0WDgr2 1mhj97vQzt1v9W9S32H8ayPhSivIiVTJmgHDQcbSSMV7t+lp5s85jrRT9BoHaipyNLoGC3sx CyiqCk4jq8Uy8kR2M2T7V3Bxj6huJXNZgo0/RnMGHKo6EV+foHNT5Kp81XA7bBDMYOQVHGFv X4Ngc/Y6/oBZbmWiCGDSeMKWqq17vyINDndh19HD5gl9jK9vXWkeOh46TVzNAFjP8ACdDLBZ E7VsBlWophJMxOCdrNtap62EIEmwLbIEsygUvHPcsEIZpl3fRWAuiZ0aiatM3vFyRZ21/tlY NHCLJjqXS1y5blbICSeYPwy2J8Z3QAF9FjLR4H/yiWey+q9ayvAIVsaC2diftzV/Yvd/luPq 4YEZpXUo/lMeLagO3eKqOb/OXhPdCFmXs6u9qS7Y8bZemJb9Hcd5+g9KF/LU6hshOxrm+jB5 RlRsWcImQOk1RUrxehnA02PiY8Dvr4l9xrXxQR2YT6VN4ELOO5DFps3eZotZqUA/+d+1/NyR PRtU5zeXK4TEm6WpG9HMsCVQGlemPOD3FvmAsZYSGJnI84Iq/LhobcIgTcDBAFRV3Hq5KPSU pWr1x/BQIprejmO+P3+Mav3p25dSFBHx4qeqWOUfYQIEKgtmaA2QxHMYggfeptTdkucmWrDh 257w34w/IHwnmP8y/GR7YjskmtjO7EW8pZyd4UD0YuLCA== IronPort-HdrOrdr: A9a23:BzwtNqq258buRqSaUzDUF9waV5opeYIsimQD101hICG8cqSj9v xGuM5rsiMc6QxhPE3I9urtBEDtexzhHNtOkO8s1NSZLWzbUQmTXeJfBOLZqlWKcUDDH6xmpM VdmsBFeaTN5DNB7foSjjPXL+od X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="79862586" Date: Tue, 6 Sep 2022 17:15:21 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device Message-ID: References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> Hi Viresh, On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote: > This patch adds basic support for configuring and assisting virtio-mmio > based virtio-i2c backend (emualator) which is intended to run out of > Qemu and could be run in any domain. "to run out of Qemu" -> this is ambiguous. It can both mean that virtio-i2c is provided by QEMU and also that virtio-i2c is provided by a different piece of software. > An example of domain configuration for Virtio I2c: I believe a proper spelling is "I2C", not "I2c" which looks weird to me. > i2c = [ "" ] Is this doing something meaningful (with the whole series applied)? > Please note, this patch is not enough for virtio-i2c to work on Xen > (Arm), as for every Virtio device we need to allocate Virtio MMIO params > (IRQ and memory region) and pass them to the backend, also update Guest > device-tree. A subsequent patch will add these missing bits. For the > current patch, the default "irq" and "base" are just written to the > Xenstore. Is having irq/base set in a different patch still useful? While it was probably useful to do this way on the virtio-disk series, it doesn't seems useful anymore. > Signed-off-by: Viresh Kumar > --- > tools/golang/xenlight/helpers.gen.go | 108 +++++++++++ > tools/golang/xenlight/types.gen.go | 27 +++ Those .gen.go files aren't up-to-date. You could just add a note after a '---' line to tell the committer to regenerate them, or make sure to regenerate them before a new submission. > tools/include/libxl.h | 32 +++ > tools/include/libxl_utils.h | 3 + > tools/libs/light/Makefile | 1 + > tools/libs/light/libxl_create.c | 13 ++ > tools/libs/light/libxl_dm.c | 19 +- > tools/libs/light/libxl_i2c.c | 226 ++++++++++++++++++++++ > tools/libs/light/libxl_internal.h | 1 + > tools/libs/light/libxl_types.idl | 24 +++ > tools/libs/light/libxl_types_internal.idl | 1 + > tools/ocaml/libs/xl/genwrap.py | 1 + > tools/ocaml/libs/xl/xenlight_stubs.c | 1 + > tools/xl/Makefile | 2 +- Could you take care of the change in `xl` in a separate patch? Also, we will want documentation, at least changes in the man pages about the new commands and configurations. > tools/xl/xl.h | 3 + > tools/xl/xl_cmdtable.c | 15 ++ > tools/xl/xl_i2c.c | 142 ++++++++++++++ > tools/xl/xl_parse.c | 80 ++++++++ > tools/xl/xl_parse.h | 1 + > tools/xl/xl_sxp.c | 2 + > 20 files changed, 699 insertions(+), 3 deletions(-) > create mode 100644 tools/libs/light/libxl_i2c.c > create mode 100644 tools/xl/xl_i2c.c > > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index 2321a648a59a..ab18c0b8c794 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -829,6 +829,15 @@ typedef struct libxl__ctx libxl_ctx; > */ > #define LIBXL_HAVE_BUILDINFO_VKB_DEVICE 1 > > +/* > + * LIBXL_HAVE_BUILDINFO_I2C_DEVICE > + * > + * If this is defined, then the libxl_domain_build_info structure will > + * contain a boolean hvm.i2c_device which instructs libxl whether to include > + * a i2c at build time or not. "at built time" ? Maybe "at guest creation time" would be a bit more descriptive, or "domain build time". Could you add that "i2cs" is available in "libxl_domain_config" as well? Or maybe a more generic description and macro name speaking about the availability of I2C. > + */ > +#define LIBXL_HAVE_BUILDINFO_I2C_DEVICE 1 Also, can this be put at the end of one of the LIBXL_HAVE_* list? Around line 1444, just before typedef **libxl_string_list would probably be better. > + > /* > * LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST > * > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c > index b9dd2deedf13..84fe9f80c8fe 100644 > --- a/tools/libs/light/libxl_create.c > +++ b/tools/libs/light/libxl_create.c > @@ -375,6 +375,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, > libxl_defbool_setdefault(&b_info->u.hvm.altp2m, false); > libxl_defbool_setdefault(&b_info->u.hvm.usb, false); > libxl_defbool_setdefault(&b_info->u.hvm.vkb_device, true); > + libxl_defbool_setdefault(&b_info->u.hvm.i2c_device, true); > libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); > > libxl_defbool_setdefault(&b_info->u.hvm.spice.enable, false); > @@ -1753,6 +1754,7 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, > libxl__device_console console; > libxl__device device; > libxl_device_vkb vkb; > + libxl_device_i2c i2c; > > init_console_info(gc, &console, 0); > console.backend_domid = state->console_domid; > @@ -1765,6 +1767,12 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, > libxl_device_vkb_dispose(&vkb); > } > > + if (libxl_defbool_val(d_config->b_info.u.hvm.i2c_device)) { > + libxl_device_i2c_init(&i2c); > + libxl__device_add(gc, domid, &libxl__i2c_devtype, &i2c); > + libxl_device_i2c_dispose(&i2c); So, every HVM guest are going to get an I2C device? I don't think that make sense, especially on x86, or even on Arm. > + } > + > dcs->sdss.dm.guest_domid = domid; > if (libxl_defbool_val(d_config->b_info.device_model_stubdomain)) > libxl__spawn_stub_dm(egc, &dcs->sdss); > @@ -1797,6 +1805,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, > &d_config->vkbs[i]); > } > > + for (i = 0; i < d_config->num_i2cs; i++) { > + libxl__device_add(gc, domid, &libxl__i2c_devtype, > + &d_config->i2cs[i]); > + } > + > if (d_config->b_info.arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART) { > init_console_info(gc, &vuart, 0); > vuart.backend_domid = state->console_domid; > diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c > index fc264a3a13a6..362c0596f497 100644 > --- a/tools/libs/light/libxl_dm.c > +++ b/tools/libs/light/libxl_dm.c > @@ -2112,7 +2112,8 @@ static void libxl__dm_vifs_from_hvm_guest_config(libxl__gc *gc, > static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, > const libxl_domain_config *guest_config, > libxl_device_vfb *vfb, > - libxl_device_vkb *vkb) > + libxl_device_vkb *vkb, > + libxl_device_i2c *i2c) That function is about taking care of adding Xen PV virtual framebuffer and keyboard to a guest. What is the relationship with between that and I2C? > { > const libxl_domain_build_info *b_info = &guest_config->b_info; > > diff --git a/tools/libs/light/libxl_i2c.c b/tools/libs/light/libxl_i2c.c > new file mode 100644 > index 000000000000..2c46351ce3a4 > --- /dev/null > +++ b/tools/libs/light/libxl_i2c.c > @@ -0,0 +1,226 @@ > +/* > + * Copyright (C) 2022 Linaro Ltd. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU Lesser General Public License as published > + * by the Free Software Foundation; version 2.1 only. with the special > + * exception on linking described in file LICENSE. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU Lesser General Public License for more details. > + */ > + > +#include "libxl_internal.h" > + > +static int libxl__device_i2c_setdefault(libxl__gc *gc, uint32_t domid, > + libxl_device_i2c *i2c, bool hotplug) > +{ > + if (i2c->backend_type != LIBXL_I2C_BACKEND_VIRTIO) { > + i2c->backend_type = LIBXL_I2C_BACKEND_VIRTIO; > + } > + > + return libxl__resolve_domid(gc, i2c->backend_domname, &i2c->backend_domid); > +} > + > +static int libxl__device_i2c_dm_needed(void *e, uint32_t domid) > +{ > + libxl_device_i2c *elem = e; > + > + return elem->backend_type == LIBXL_I2C_BACKEND_VIRTIO; I'm not sure I understand the result of this function. Is QEMU needed to present VirtIO I2C devices to a guest? > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index d634f304cda2..014a3ea8364c 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -278,6 +278,10 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ > (2, "LINUX") > ]) > > +libxl_i2c_backend = Enumeration("i2c_backend", [ > + (0, "VIRTIO") Could you start with 1 rather than 0? This will allow libxl to find out if the backend have been set or if an application let libxl choose which backend is more appropriate. > + ]) > + > libxl_passthrough = Enumeration("passthrough", [ > (0, "default"), > (1, "disabled"), > @@ -626,6 +630,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > # - "mouse" for PS/2 protocol relative mouse > ("usbdevice", string), > ("vkb_device", libxl_defbool), > + ("i2c_device", libxl_defbool), How is "i2c_device" useful? Would "i2cs" in libxl_domain_config be enough? > ("soundhw", string), > ("xen_platform_pci", libxl_defbool), > ("usbdevice_list", libxl_string_list), > diff --git a/tools/xl/Makefile b/tools/xl/Makefile > index b7f439121a3a..06801962f11e 100644 > --- a/tools/xl/Makefile > +++ b/tools/xl/Makefile > @@ -23,7 +23,7 @@ XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o > XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o > XL_OBJS += xl_info.o xl_console.o xl_misc.o > XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o > -XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o > +XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_i2c.o Could you add xl_i2c.o in a new line instead? > > $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog) > $(XL_OBJS): CFLAGS += $(CFLAGS_XL) > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c > index 35182ca19630..c409ab1578d4 100644 > --- a/tools/xl/xl_cmdtable.c > +++ b/tools/xl/xl_cmdtable.c > @@ -406,6 +406,21 @@ const struct cmd_spec cmd_table[] = { > "Destroy a domain's virtual keyboard device", > " ", > }, > + { "i2c-attach", > + &main_i2cattach, 1, 1, > + "Create a new virtual i2c device", > + " ...", Is i2c-attach going to work? It seems that an i2c device is presented to the guest via the device tree, but I don't think it can be modified on the fly once the guest have booted. Is there i2c device hotplug? > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 1b5381cef033..b91ffba14d40 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2583,6 +2657,7 @@ void parse_config_data(const char *config_source, > if (vnc_enabled) { > libxl_device_vfb *vfb; > libxl_device_vkb *vkb; > + libxl_device_i2c *i2c; How is I2C related to VNC? > > vfb = ARRAY_EXTEND_INIT(d_config->vfbs, d_config->num_vfbs, > libxl_device_vfb_init); > diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c > index 359a0015709e..a44c765aa515 100644 > --- a/tools/xl/xl_sxp.c > +++ b/tools/xl/xl_sxp.c > @@ -140,6 +140,8 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) > fprintf(fh, "\t\t\t(usbdevice %s)\n", b_info->u.hvm.usbdevice); > fprintf(fh, "\t\t\t(vkb_device %s)\n", > libxl_defbool_to_string(b_info->u.hvm.vkb_device)); > + fprintf(fh, "\t\t\t(i2c_device %s)\n", > + libxl_defbool_to_string(b_info->u.hvm.i2c_device)); There is a notice on the printf_info_sexp() function: /* In general you should not add new output to this function since it * is intended only for legacy use. */ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) Could you explain why this function is been modified? If not, there's probably no modification needed. > fprintf(fh, "\t\t)\n"); > break; > case LIBXL_DOMAIN_TYPE_PV: Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400058.641615 (Exim 4.92) (envelope-from ) id 1oVgFo-0000Df-Ez; Tue, 06 Sep 2022 21:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400058.641615; Tue, 06 Sep 2022 21:37:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFo-0000DU-B9; Tue, 06 Sep 2022 21:37:08 +0000 Received: by outflank-mailman (input) for mailman id 400058; Tue, 06 Sep 2022 21:37:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFn-0000Cs-4L for xen-devel@lists.xen.org; Tue, 06 Sep 2022 21:37:07 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5393d51a-2e02-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:38:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5393d51a-2e02-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662482306; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3WhlFr3nKiparYrd+aDZOzFlNnQ3JOj8V/5RuSbTFTQ=; b=GeC5lnQdGdo+OBQtuSAKz1PWfyA/cuIU3NSdtV20LawpHh2/kTa0vauJ jIePn5d/E2UBugLvOH5BgZXWIcBDu/G17CaPJyw7aem1IZXtVgLQjGVVV K/0ODxAwRA33Ngz26sGE6q4ZxNakNQELO3d9Jr79tj0ol0IdXbpxsrOwJ k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79874608 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3Aidd06q1CaEITcVb/H/bDix16xf2zMnBdZdB3s?= =?us-ascii?q?9h9DyJ0z/FvzIkanZKB8/OS+U9bHOpMeNiCB5Vf1yJ3P5qbDhymA2h6DsXYn?= =?us-ascii?q?qGX3gqNxGmMvFsvv8UKhB9hoMGJO8APlKYaKLNxYXbSBPIf0IGhEUciULn4F?= =?us-ascii?q?BPkg/SdoH5a8pQPEdkQex/F1R4dNjdkyjJwG6/DJ996bmm8BfJWhkFnj5KGN?= =?us-ascii?q?6TZntUcoQpQpd1jqQjEwXVm3knq6KMUnKyBTwXQgb1fjga6AnBURFN+HoCGJ?= =?us-ascii?q?HUkwLPSrgyfU8805RkVN5F44AItNWlnBApeSaA3wJyaswzxjz9WWSUNIO1Le?= =?us-ascii?q?lCr1gDEWCZ/UEdaKFBt9jtuat5Vsho70Lcn5rQFlSQPAg6pGQ+wne2kW8H5k?= =?us-ascii?q?X2t87hb02AvEe2qgbItZzRPWNRYs+zlTZMEyVaRh/jgsvOG1CmNb79jj8AEY?= =?us-ascii?q?bBGsi7PEtkI4WrAFo1SSLU/8bPGmsa3CI9ODIt/0e16BZIkNbKFQUU1J26ts?= =?us-ascii?q?zCFJsolWFKDEA35h7IbvLiLgahXPG+/Ro0pLmv/Gi/Q/yUe85e6hfKMQAu46?= =?us-ascii?q?HZzWSohxociu1V3m5CX/xLYdBuMcvo1TSqd3W4FuT1U/xPPPpOz4O+KMxTrc?= =?us-ascii?q?aEMI1IYmicpijWllnewoKlAivHqT4xd6eRRDlY7057bkvCNZQ19H+pXFhPc0?= =?us-ascii?q?fRzZzlAy3NVg+pCR8VeE1B/Evb5oYWMui3aQRzs4b/Y2qrX9Pf899Yv6Ylk4?= =?us-ascii?q?Ms9R9njmLFyM9AtgWux5MCGQyRybSECkXiivLc69T5uYyXQJn/bdG3W2ILAn?= =?us-ascii?q?hgWotnXQ9iE0gXYAagdGcedhtkzrkOPcb/Un/o1+//N/hpuw7oAKoHpLlgsP?= =?us-ascii?q?Gmo0CX3J8WSyJyy/6dDSlZH8QUq0tD5ZuPzbinQh6A0ziyYJUBQ7vVg26qOP?= =?us-ascii?q?1jKhYbV+eBjSH44hOL4sOxj/W+3/u9OIIq+9ZyzqWeaa3Uws4Zg1kQ0uN0zH?= =?us-ascii?q?MmvHHLWmpap2syJNRiOWCFgciw+Q2qMwYcvUc35wrJ01OMjk7YdWqYPNolHL?= =?us-ascii?q?CoO5paJCUrW07hQizit1V1BpTvtTCtF9AT2RRsJZyhn3PTMYRCdClGGQaAg7?= =?us-ascii?q?3zN1t88yiZZyPgQ4N2nk+IcjqD+DTEX2t/q6WH67B4gkTZY7NFepVx6aHyfb?= =?us-ascii?q?0qyq8NVtqm+Lco5xnkDICxD/UTtTu972BEk1hnm/FVEuT+1VgmPPrjiI43mH?= =?us-ascii?q?SbllCV8y/fqKZbVLjs2vqDi0IGQzQP58XofgsaFFyWd7JkaxgaRONd+YoDPn?= =?us-ascii?q?2pgbHN+MX8kSRolUnBYGFX7h5XNCTT6Dbxpb+hdtPAosmBXLayjUBEPE0BXc?= =?us-ascii?q?XrRUgwxjlgq0IsSYKqfjv8y07oUlwZLDxqjO7CMvYaCYi/4ZfIglIbQ2SZg3?= =?us-ascii?q?22FkU1Cjs9kiR5FaOVaK0e8VyHvx6U/dpIryDftL8kKyvmnezA7FLk9bW6jB?= =?us-ascii?q?y2M0r0c5aODJQLhC7saPi2xTipxfFibAFd2ks0jyTw8f8bvD7OBv/xSuRWQ4?= =?us-ascii?q?yf6feywJ+A/GBQByZq9EeEI1h4y3DTKj1Yzs/hUfQrVdotNmvrE1aCDNfA/t?= =?us-ascii?q?7a+8NIoiKyNK5YOnaYM5gwp9bhQpxf4S4LVX16CFSu6Uvo+wFQjQMk4NHM0d?= =?us-ascii?q?648vj6CKVMlKfla+Mu7CnYZ6kpYxoh8L8q9eOWju1DN/kN1SzkbTG0xl8Ymr?= =?us-ascii?q?+K8HcDNO7nTwCpOHPJki5XKuN11NcNywz8qnaVv0PX+mVF6/NM2rQuOtnWTq?= =?us-ascii?q?E7UdOrQnsRS0lWs4T9ODhw8tGlx02qI3RuZEZcnEs3LkrMM6PeWHpnFjSZce?= =?us-ascii?q?vvFA0RaSm6HTd0JE6z+P9K0Gj3UqC/qHsevaWeqnaLsD2xPtcXMxnUff0ORm?= =?us-ascii?q?Do+IZzOXkQz4N3W5yXZdcte3qrAHVP2wjCFRxkSS8IeTVda0MkZ9oMqawD4I?= =?us-ascii?q?aWKtSG7FDp6JAZV58v1SvV8SfvquLu0pEU2naGsjLVc2rYfx6QP4/R3DgwaC?= =?us-ascii?q?X7TaRxv+1i0s8qdYb8tXWq1wbWPp/3q9MDEdU3DZeKGpgSGYu0ek1KsdiPxS?= =?us-ascii?q?XL2XXH7F/z8aSKckfJxP1PQ0PcAd2HUMvrb5Ub8CZGTyYSv5c4eeDhtoc2qy?= =?us-ascii?q?FLgWGKbh5l9YPwmqWGQw7UQjzAS+Dbnxg0V0pHp6sViu47HgvUFvTILcQ8x1?= =?us-ascii?q?f4tQ8uF90KzchEgqNUuwbw8+mm6PAC24/zkXrLjZw+rDdMivrLWsJALRHNII?= =?us-ascii?q?v4LSw8eMEij6hwte5cmjUmXmA4BFO0gvHFZMM6yGkVW2wqWfaYwrwQ/lwmUQ?= =?us-ascii?q?rmtTFNiApqr+xSfpfJ9CcQEIgD2Wy9sbuay4l8lJvFKV2V/52PtJDSl3kzMe?= =?us-ascii?q?JfeuYk4otyOR0zx++BNZvNJcjQCDzGvbcjZqsaL+R7PJz3rApCHI4Irq23bh?= =?us-ascii?q?vD7zejPVcpjw8MUICAsUSJIh+MP/vMszS8ytJZ8JnNH+5yysz06TCRi6A1np?= =?us-ascii?q?hW6SONae5LtABFZ62J3/Vk815oDKy+OmMFcNOy0df9ORW/Y3LqmezCGnCMTi?= =?us-ascii?q?YgQRy7xYLvC61z97/H6FmAB47Rqt07tkYzys4Gzir0uLqZ3wgbbo/ahe5AaP?= =?us-ascii?q?fxJFrN/Eo7DFVzRbHqR/29f1paMHsofmq6MVBMJ8HzGw7Fu5gzaX95AzXqH2?= =?us-ascii?q?XD7o0TWepWAWElD1GI3Pq0nPhHOVQ3kH2xI9Sz6R8cDyjqHxuaaVxlYhbgz+?= =?us-ascii?q?r7xUpFKZ+9yuH1NLETcuSxFU9kucD2H1+JoDCWFeYbzRGd0ajYureo3DwN7u?= =?us-ascii?q?x4z+zDmHFmSVJrUaX4fP1e5HRMrsAL5herp3CH0OlYi1klf1g62tVmkez1DS?= =?us-ascii?q?mNA0OaHE7CzMp3oYeUMzEtLsywt3+Jc82UJbP1f8BZn46kk1qvbyrwl7jdUD?= =?us-ascii?q?VHBjqfCv5Q3OYOaXLoK38axVQr2stjHUmTfnqduuGRVbmgicCDutgv1xtgTJ?= =?us-ascii?q?YuEaK+9BZY6VNa0c4xfm4n0zHytUkuW/zeDAnW3xw6+xyYqynVDd3e4u1vR0?= =?us-ascii?q?YhwkKdy2l8iF3qGbMWyhyWVwR5UjYnaXnnX3A+UWU61KSyq2Lp4hSb/RAuKq?= =?us-ascii?q?BdjBJGYcIppe9y7c+q4qm0/sch1JT/EWwqg7L1y1fQWs3Zli4VYRjX6gKkYl?= =?us-ascii?q?ZeKPB4vdjfqB9OrUtYWwYEkJsYS36obJ5X6u4T/XT5uPE+V4OBOaPa6mRQDh?= =?us-ascii?q?e7SX+Q+KXEApbV20Rb1dwg5AcA07mtYDSiNMdG4ppDF3Jp7yPldXPwOBDBiO?= =?us-ascii?q?uFN+4fuxAl5GIiLvOtSt8aRU/Hy7E480zkirXg=3D?= X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="79874608" Date: Tue, 6 Sep 2022 17:38:13 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V5 5/6] libxl: Allocate MMIO params for I2c device and update DT Message-ID: References: <7b871a16d981dcdc0046e6a69f77e2bcffe79065.1661159474.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7b871a16d981dcdc0046e6a69f77e2bcffe79065.1661159474.git.viresh.kumar@linaro.org> On Mon, Aug 22, 2022 at 02:45:17PM +0530, Viresh Kumar wrote: > This also relocates the code responsible to call make_xen_iommu_node() > towards the end of the routine, so we create the node only once. Could you do this part in a separate patch? Then, I believe the rest of the patch could be squashed into the patch that adds i2c support into libxl. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400061.641626 (Exim 4.92) (envelope-from ) id 1oVgFq-0000Vt-Te; Tue, 06 Sep 2022 21:37:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400061.641626; Tue, 06 Sep 2022 21:37:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFq-0000Ve-Nk; Tue, 06 Sep 2022 21:37:10 +0000 Received: by outflank-mailman (input) for mailman id 400061; Tue, 06 Sep 2022 21:37:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFp-0000Cp-1H for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35332725-2dda-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 13:51:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8891.eurprd04.prod.outlook.com (2603:10a6:20b:40a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 11:51:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 11:51:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35332725-2dda-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mCIQAkJ1XB3iG7Pf9U8yolHSHiKhDevwi4qmyZVk07KmJIMoyTtIthp3TUzlrsYJfqRpd8VeX8rC3fV1z1E+CFthFRGSkM18V8lPLoIWVfz5jL2tmMD6F0478sY0hLFC23nQmwiAAVFmYWbOaFSljebDCXz0eczAgrLhhOZ7HoQOu/WzNA3Qo+CCICUJ1UVh5JoBqRE5vko30KZUqAIHTvYFPw79lopVl7Nl9V9P52MLnY2XbzErPtJQjNN8PIywNx50ysdwM7JbtuZFWOSoQmtDiBegcEWS84Qmv4ORkWKVgP2xrmCydOOQul0gQhqwqihMYz6bCWb3gV7XQ9TFEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KuqUDT6vQvR3rdyDHnxL7NjaJgm9JF/D6ix3Nnbj8to=; b=OYFT5i8UX2113QK9/yL3FMA5eEToVgBbzUZOLTkXkfIHNanTflMyqO7vGbY6H21C1AToTrJ5KTN/Q4+n+Mtv0OgtgPXCW2Z9pyTZ4lFN+3F0owgG26p8GRm6GD+c7QbGpCT6huJt2+MwjgMMaRhZklsH+/SBQ7lVC24uABaIWkkoq09Mb0yT9vdlrKddBwA+EkcqbbIJeLWyar8BiFf6JBv8Zn8XyhMdqmWbSBZC8bDlUGn9HL1iiGC+RTJ3y7oh6E2cYwf/cxWx2v8GhlTXhpJhLvkxj8ZGdlUwFffuBB8gcJR7NBaOUI2afvrikJL2K9QKGe5J8mvcqYxHGH/IMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KuqUDT6vQvR3rdyDHnxL7NjaJgm9JF/D6ix3Nnbj8to=; b=fR0++6Pp/CXqXNYoI/9wfd8XNb5/GdQPkm1HAEW0SlBUWcmAVZ8V9G80waCNm8xZF/NlTSjTJi6PuSXBviVJWeuf1IuA0/szLxZsu1Tj1MfBhqeSzhFtlW+y5u3GTLEpvOXdhWTvojyxaBmWOazg7DAvafWZ6vUl7ktzkbhIlccw5dnGVYKKGapyiHeNn3x186eZui5i4erRxjvissWiLwYh8ED7kqFWMDvg+BcYFI1ewg+hBV8lEeofIuEcXesN5+WWQV/eFNoNp12hoM8m6oQcsa1joPsYuZMHJBjN5EjbXXaawg4vTRYojWTXnlk17ESsuqCCrL59Em03gMPqpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 13:51:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US To: Dylanger Daly Cc: xen-devel@lists.xenproject.org, Andrew.Cooper3@citrix.com References: <55eb8485-0c0d-51cd-c9b8-d517994ec6c6@suse.com> <7807b9cf-a09e-a393-ee7a-dc220a68e56e@suse.com> <3b2ad2ca-3c6c-4dcb-c603-bd5440350f20@suse.com> <2dHPPtixTlkUXYEzNPFRI4ezKHSe1A2VaThMjBpd1aM3NFkZQuyRdfmNWCigm1oXfdKhOwDJGoPBBIMLYtYhQlENV2eFVZ0G9EMOMj5e6UE=@protonmail.com> <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> <6JMvOsjmpWkAsnm6AXzNsjtj5_jy5vG_vG_PwTyDzX0z1buoX89r5UEpSGKf-H7CTBtg9gNlq4Icy7Q9OIDjfrxp2AqNMXbyKTCD0y_d0Hc=@protonmail.com> From: Jan Beulich In-Reply-To: <6JMvOsjmpWkAsnm6AXzNsjtj5_jy5vG_vG_PwTyDzX0z1buoX89r5UEpSGKf-H7CTBtg9gNlq4Icy7Q9OIDjfrxp2AqNMXbyKTCD0y_d0Hc=@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0502CA0015.eurprd05.prod.outlook.com (2603:10a6:203:91::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ed66096-529f-4b98-5298-08da8ffe1836 X-MS-TrafficTypeDiagnostic: AM9PR04MB8891:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xs2CltwMxslrr20kG+6biNx12N07wDk7KiS4d9UvHcW2WPM3lUyja543ArZDje00RERV9o2whVWOgAayamWUGDxDGWtUnWVezqYS9g7GlQYSVk4LQRwhCMgs8BZq44dLjtckvNy4b8tzauXHXDtDhJZ0maeVKF/uvls1pFNL3sYacp3tC7Cka7CSsF5o6opNghAJU+ThWcIU+98J054NlRZHbwR8qQXArYvKCJLaUeZsAsUX5YkPpkY9tWapIgilygVL8aQH3yX+wS52CYAxppk9n+0ikS6QoLsAvOVQB3dpweqssce8bmu1X5knTJTMH2cCSUFp7yEB5juKiSMGhG939fDuvXe0A+GcIAnltUx+OU5khnuTAuGQWZW1tMqCqumh8AccQFqw/2qBkHY/hfGrQO56VJk8NMnDnoDjCbmJLLEIU4MP5g5IgSBx/D5VuQmpC2CkIOSHKU22W9Ml6YG5Ay0Sf9SDNpQkPAeEITzYxDW8Sna8rCGI0SBj4wBc6bxYWCp9FQva81xI+VTJOFmkm9UolvMcmUMcm8R7piVlK/yIa1A1HgFSA/18zBMM5jwzSbbecUm9r853vUQAx0rRhIwmkH52PuupJGtGCRlqsIUaQOmt88SvPOFQjpOwUHoBMxzQV1haJuiFpJAbv31jmc6fkj+RZltOlt2dLM3NtQHkUXmQH4zSWn80wXYDcwTjiU18szBHGjEaBkYbz1oS83kFPiK2CVi5/id2H+5h7Bqfr/v3P86Vw3yrNvRPguc+5P55nuStpgMTUJZhybYMlGMzwzIzn1lXAUvmP9+3N1Y/X4+1rDFZrKvuF7WGiKjcp/iQLjYMTY5jT0TcgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(136003)(39860400002)(366004)(396003)(186003)(2616005)(38100700002)(8936002)(83380400001)(5660300002)(66476007)(4744005)(66556008)(66946007)(2906002)(8676002)(478600001)(6512007)(6506007)(26005)(6916009)(31686004)(41300700001)(6486002)(53546011)(316002)(4326008)(36756003)(84970400001)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aC85MG9mNTBxVVBGV0dtQmJpaGJhR2V2ekFDcldEYWV6akFQeWI4Y2F4ODAw?= =?utf-8?B?cS9uM0Y2YVpqa2pVN1REd0MwdlJFY2x3MlpOR1R6MG9vSlBoYW1maGhKVVFL?= =?utf-8?B?cDhQREpNWEZpRkFKNXhvN3RFdTdDbVdYMURuTE5Dc1FOeTUveEdpNHEwLzVq?= =?utf-8?B?OVhXb2ZFREs4Zi9tUklvSVdBZTRxSkR5a1Z5bHJSekFlZ3JQNkhnSWFsUTFU?= =?utf-8?B?Um1hWkVpWEJ0VXVKZXJQLzc2bU1yNEQyL0YzWjRmUTNUSWc0Y2JDZDRRNXZV?= =?utf-8?B?V0RuTzhmY0k4YkxKUGtyTE1TYVoxN2t2b1RrRFErWE5KdTQ1NURBWnJjZzkr?= =?utf-8?B?L2dIVXZOdVBBamFjejJZSjY4V1EvcDlkVW5vSDl2MkEyMVo1aWh0eUlUcFJB?= =?utf-8?B?ZFoweWhTMkZ6Z3hWbDZtMm9hbVhmN2RCV0hSL3ZvRjNybnNzeTdZWUtEdGlv?= =?utf-8?B?dEtVeWtmeTF1ZFZYSVVOdk1xZE9pUFg4N3ExTUE4Y1BGbno2YkRDNy9WTmtP?= =?utf-8?B?SVBNVlIyekdwOTlPVnlOS0MvaDhTWTZoRmFoN1BYTW1NOW9POWptYUNUNnZX?= =?utf-8?B?YjVFbHpYSUZnNnJiR2FGK2dxNitacUlGaVl5ODVBaS8vSzNVenVBdzY3WWVw?= =?utf-8?B?UGQyMW1HaVl5NnREM1lQSnNkVkZETnRWQjJjTUR3WDA1ZXlTRzZ6OTJUdEo1?= =?utf-8?B?N3IzOWQzWkVEeEZSOENpVFAza1kvNzJnODJTazFtUVNzbGNHSzJXWlJ4WWZ2?= =?utf-8?B?NHJSbUc0UVErSlhZSHRHVVNVb0pHM2psRDVaMFhMK0dxQXRVaVJDRU1Pb1pi?= =?utf-8?B?U0dlT0hvOUV2a0tKRVJNNFBvTzN0R2ZkTlhiZWZseGhwdUdwVG5KckVQeFRh?= =?utf-8?B?YjJvMFd4OGVOTUtXa3hYVi92Y3dURkZhSkYwTjFJWFNla3hDWC85UnNlbmV1?= =?utf-8?B?TWwyWW44anJGa2RyaDhDYkRhWHB2MHUrZTJjSjJjRytPNllUN0MvZEdFNWNB?= =?utf-8?B?NFpEWklJM2NRY0RNTyttRVBOUFpoOGVsWXRaMkN2Snd2NDlpY1BYWlgzQ1Ry?= =?utf-8?B?Vmp0RDNsMlhydXZjNFIxZDRwd1cxZVh4VHZGQ3BBcHhzelQydzh0eTAzc0pO?= =?utf-8?B?K09TYitZZW00eGRMM1RBUVk4T0hkaW9RK2lXa0dFYmxkcWp1Yjg1cE1GSjRq?= =?utf-8?B?MlNuMVhIZ09uN3ZtZ3gyOHhpL0VKMmFIMlo3Wll1T3htQVJTckszMSs1dVFP?= =?utf-8?B?Y0pPQVpmMjR3Wk9LQ0N6T1dZdFVGMk5YRXdsQWtqazg0dGF5MHdkanNNQ2ta?= =?utf-8?B?bm41aVdMcjkvT1pvZ1VmcHVlUExTVjlNajh0Q2dxK05URXFkTy85OHJCOVkw?= =?utf-8?B?RFZXcnhadG9Na1BSdlRvOGt3dXRJMGhXZjRoZ2NPa29ncGtNN2h0dy9DcHlK?= =?utf-8?B?ZlVWT0lLbHdyWktvaW0vNFB0Q1FJT3dWVkFESTFmbFdYYnNOZ2dNYVBSZlln?= =?utf-8?B?UHplejJobndKbXdvN0FKb01maGVRWmdXM0NZQlZXSDliWXpxa3N6L3ZHc1c2?= =?utf-8?B?OVdUc2xreHJWYTR3eXh5MVliWk5UY0NlWWZlZS9DZDRiNnZMek9TQ2svTWp1?= =?utf-8?B?N3VaSVc2UzJodGhGZVNnT0dxaHdXL1YvUDlZWm9TVW1wa2JSaXF6NzlXdU9Z?= =?utf-8?B?d1FzWDhLMEMyRkdubGhrS3haYndDNHFQYTZiYTlGYUZvemVxd0Y4VEpxN01k?= =?utf-8?B?d1RmdXRvYTJnUGdBK0JQcmRPSHFSU0xaWHBpVzFnVmtvVDhCczN4NDJmbGZl?= =?utf-8?B?RjRoOTBBelJpMTdsUkJTZGp2dXUvQXBqcEFCVHR3MFlqaTQ4QWczZVFsRlhv?= =?utf-8?B?UndlYmdZR0kvWnJlSDlWSWUyNVFQZjd3VkszMExWODJOQTRVZ200WStSY21n?= =?utf-8?B?czRKdGNDREtidklYalJ0aTZUcllyMC9qbUJyU1F0ZnhRcEIxOURxb3FwSUw0?= =?utf-8?B?ZkhRc1lVbXhidEdTRTAxeGkrVXRHTi9iSVErMEh3TDhTQmYyWGx4SVRWeWJP?= =?utf-8?B?WGZmTkszZ0Z3cWNxUVpEaHpRU0hOVC85NjlPSVZoWmIrKzJXeXBmOE5jN1J6?= =?utf-8?Q?cYstmGHm3C9Q72yrlgdajbdCU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed66096-529f-4b98-5298-08da8ffe1836 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 11:51:11.9993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xQ3HdWizFPyLzz8kOx8R57v0wreLXFNf82b+DIPSM1O0y8zCzpRjSoonc2YzIkjy6wsabaz/6+1s6l1SoQQp9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8891 On 27.08.2022 19:52, Dylanger Daly wrote: > Thank you for your reply, Xen appears to crash immediately on startup and appears to hit the patch Oh, yes, silly me - map_domain_page() can't be used that way. You may want to give the replacement patch (below) a try, albeit later replies of yours have hinted in a different direction now anyway. Jan --- sle15sp3.orig/xen/arch/x86/e820.c +++ sle15sp3/xen/arch/x86/e820.c @@ -700,3 +700,16 @@ unsigned long __init init_e820(const cha return find_max_pfn(); } + +#include //temp +static int __init ryzen6000_init(void) {//temp + if(e820_all_mapped(0x7AF67000, 0x7AF68000, E820_NVS)) { + mfn_t mfn = _mfn(0x7AF67); + const uint32_t*p = vmap(&mfn, 1); + printk("0x7AF67000: %08x %08x %08x %08x\n", p[0], p[1], p[2], p[3]); + printk("0x7AF67010: %08x %08x %08x %08x\n", p[4], p[5], p[6], p[7]); + vunmap(p); + } + return 0; +} +__initcall(ryzen6000_init); From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400062.641632 (Exim 4.92) (envelope-from ) id 1oVgFr-0000Yt-AC; Tue, 06 Sep 2022 21:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400062.641632; Tue, 06 Sep 2022 21:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFr-0000XB-15; Tue, 06 Sep 2022 21:37:11 +0000 Received: by outflank-mailman (input) for mailman id 400062; Tue, 06 Sep 2022 21:37:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFp-0000Cs-Gl for xen-devel@lists.xen.org; Tue, 06 Sep 2022 21:37:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2306c22a-2e01-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:29:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2306c22a-2e01-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662481795; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0G/6mXL/Y37gyhQ+RC+HyWT47eAXf3k8XGHQflSS00o=; b=WSSWx9Oy3+kf2yf5PfhPGeinJnfTfHn6qA603bz5+RhkK3h0qDpyRYXJ 0P23MLRI/YUekptwf7JKBhto0sHUKZSFJTRCJqwf4xUg8bQPd7qgAbu3C EIPURbt3Jlad15tmSksd92LGRLd6nB9ezvPSrXlBltClTn9N8u8ZWHAHA 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80309892 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/4G4RawJIhQ3HtDeT5d6t+dWwSrEfRIJ4+MujC+fZmUNrF6WrkVTz 2EeDWuGOvePYjehKNonYInkpkxQu5TSmNFhQQM/qCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Usx5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1qVmUXBa8j+9xeAFF/6 uY/MnM8Qz6M0rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzJZQFPPVEGToozhu6yilH0ciFCqULTrq0yi4TW5Fwpi+C8YIuPEjCMbeJz3U2ni FnexV78CxwRbfjE1mG37W3504cjmgukAdlPRdVU7MVCn1m71mEVThoMWjOTpv20iVWiSslfA 0MR8ysq66M18SSDS9j+Ulu4p3qBswU0X9tWGvc9rgaXxcL85AKUBXMNSDJbX8A3r889RTEs1 VihksvgAHpkt7j9YXCA8raZqxuiNC5TKnUNDQcGQhEC+MLLu5wog1TESdMLOKu8kt30FCy22 zeLtikznZ0XjMgCzaL99lfC6xqyp57CQwgpoArKX3656R9RYI+jbpavr1/B4p5oPIufC1WMo nUAs8yf9/wVS4GAkmqKWuplNK+o/fueMHvfnFtmBbEl9jKk4XnleppfiBllOEpnO8ADPyT1a UXevQdQ4p57LHqubKlnJYm2DqwCxKztBZLvW/bSY9dmZpl3fRWAuiZ0aia4xHz3mVQriuQzN Imzdt7pCXcBFb8hyDuwTv0al7gxyUgDKXj7HM6hiU79iPzHOSDTGext3Eaygv4R6PmggT33y NdlHsq6+gpFd/e9UwT5/ttGRbwVFkTXFawauuQOKLDZelo9ST9/YxPC6eh/ItI4xsy5gs+Np yjgAREAlTITkFWdcW23hmZfhKQDtHqVhVYyJmQSMFmhwBDPiq7/vf5EJ/PbkVTKndGPLMKYr NFfIa1s+twVFlz6F801NPERVrBKehWxnh6pNCG4ejU5dJMIb1WXpIW4JlG+q3JUUXPfWS4CT 1qIj1qzfHb+b146UJa+hAyHlDtdQkTxaMotBhCVc7G/iW3n8ZRwKjyZs8Lb1/okcEybrgZ2I i7MXn/0U8GR/NJumDQI7IjYx7qU/xxWRxAFQDeEsufvZUE3PAOLmOd9bQpBRhiFPEucxUloT b4Kpx0gGJXrRGp3jrc= IronPort-HdrOrdr: A9a23:5R4ZR6qHimWS2n3Kjoydy3oaV5oreYIsimQD101hICG8cqSj+f xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U 4JSdkZNDSaNzlHZKjBjzWFLw== X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="80309892" Date: Tue, 6 Sep 2022 17:29:31 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V5 3/6] libxl: arm: Create alloc_virtio_mmio_params() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Aug 22, 2022 at 02:45:15PM +0530, Viresh Kumar wrote: > Create a separate routine to allocate base and irq for a device as the > same code will be required for each device type. > > Suggested-by: Oleksandr Tyshchenko > Reviewed-by: Oleksandr Tyshchenko > Signed-off-by: Viresh Kumar > --- > tools/libs/light/libxl_arm.c | 46 +++++++++++++++++++++++++----------- > 1 file changed, 32 insertions(+), 14 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 1a3ac1646e94..0e3051bac5e4 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -85,20 +103,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > libxl_device_disk *disk = &d_config->disks[i]; > > if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > - disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); > - if (!disk->base) > - return ERROR_FAIL; > - > - disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); > - if (!disk->irq) > - return ERROR_FAIL; > + int rc = alloc_virtio_mmio_params(gc, &disk->base, &disk->irq, > + &virtio_mmio_base, > + &virtio_mmio_irq); > > - if (virtio_irq < disk->irq) > - virtio_irq = disk->irq; > - virtio_enabled = true; This change to virtio_irq and virtio_enabled, as well as the chunck below, isn't explained in the patch description. > - > - LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, > - disk->vdev, disk->irq, disk->base); > + if (rc) > + return rc; > } > } > > @@ -107,8 +117,16 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > * present, make sure that we allocate enough SPIs for them. > * The resulting "nr_spis" needs to cover the highest possible SPI. > */ > - if (virtio_enabled) > + if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) { > + virtio_enabled = true; > + > + /* > + * Assumes that "virtio_mmio_irq" is the highest allocated irq, which is > + * updated from alloc_virtio_mmio_irq() currently. > + */ > + virtio_irq = virtio_mmio_irq - 1; > nr_spis = max(nr_spis, virtio_irq - 32 + 1); > + } > > for (i = 0; i < d_config->b_info.num_irqs; i++) { > uint32_t irq = d_config->b_info.irqs[i]; Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400063.641638 (Exim 4.92) (envelope-from ) id 1oVgFr-0000f1-Lh; Tue, 06 Sep 2022 21:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400063.641638; Tue, 06 Sep 2022 21:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFr-0000dX-CX; Tue, 06 Sep 2022 21:37:11 +0000 Received: by outflank-mailman (input) for mailman id 400063; Tue, 06 Sep 2022 21:37:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFq-0000Cs-JZ for xen-devel@lists.xen.org; Tue, 06 Sep 2022 21:37:10 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d260ed1-2e03-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:43:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d260ed1-2e03-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662482617; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pa1RL658MOY2x+MYF4zQp4voWWRCaFCGRfsvy99OMWo=; b=Vp09P5ZDm4EMHpCzpnc+TFMr3ZFzY4z4KJhdTPfksklee7IgkY1rq33S SbSL34gRg9MFC69F/33iNdtSjAIB9tXSSluneRA9Gke1jd3S5sX8MJjUT b6MRNPpnhI1WRTt+W5R8AjnBXhHgz9MysaRICuVdcsxi2YCAcUGg0dYXu 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80311183 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:EaDUKKI+4Vk12QjLFE+Rt5IlxSXFcZb7ZxGr2PjKsXjdYENShmMEz GUYWmmOP/uMMzPwLt9wYI+x9k9Xv8LXytAwQQFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/Pb9ks11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEk7ZILkE0F5Eh0d0sBU5ez LscEhUXV0XW7w626OrTpuhEg80iKI/gPZ8Fu2EmxjbcZRokacmdGeOQv4YehWpuwJAVdRrdT 5NxhT5HZRLcYxpJKxEPBYg3huuAjXjjaTxI7lmSoMLb5kCDlFcoieG9a7I5fPSlHsly3X+Hj FncvHXiOkwkM4KA43mKpyfEaujnwnqgBdN6+KeD3uFuqE2ewCoUEhJ+fVy/rPqill+lW/pQL kUV/mwlqq1a3EmqTdS7Xxq8pXOflhodXdNKFKs98g7l4q3Q7gWCD24IVAldeccmv887Qz8t/ lKRltavDjtq2JWXVHac+7G8vT60fy8PIgcqZyAeShAey8L+u4x1hRXKJv5mGbK1j9DoXyn3w iqLoTIWg7QVhNQMka68+DjvnTOqrZXPUkg6+wTLQmW5xgd4Yoe/YMqv81ezxeZNKsOVQ0eMu FAAmtOC96YeAJfLkzaCKM0THauk/PbDMyDZiERHG5gn/i6qvXm5cuh4+y1zKk5vNYAfZTbjb UvXuAVQzI9SOHqsfel8ZIfZI80uwLimH9njUP3ZRt5PZJFrc0mA5i4GTVWMxWnxl1NpnawhE ZCDNMKtFmoBT6BmyjOsQKEay7BD+8wl7TqNH9ahlU3hiOfAIi7OIVsYDLeQRrB6yoGEoi/Jy v1kbM+l2ywYVNfbeBCCpOb/Mms2wWgH6YHe8pIJLLbTeVs4RgnNGNeKn+p/JtUNc7B9076Ro yrjAhIwJE/X3yWvFOmcVpx0hFoDt75bpGlzAyEjNE3AN5MLMdf2t/d3m3fakNAaGA1fIR1cF aNtlz2oWKgnd9g+0211gWPBhIJjbg+3ogmFIjCoZjMyF7Y5GVKTpoe+L1S0rnZXZsZSiSfZi +T5vj43vLJZH1gyZCooQKnHI6yNUYg1x7spAhqgzih7c0Tw6ol6QxHMYgsMC5hVcX3+Ks6yj Vn+7eEw+baQ+OfYMbDh2ci5kmteO7ImTxoGQzmLse3e2Ouz1jPL/LKsmd2gJVj1PF4YMo37D QmJ55kQ6ME6oWs= IronPort-HdrOrdr: A9a23:CrupV676w5DMWc3LnAPXwMrXdLJyesId70hD6qhwISY1TiW9rb HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ 0QCpSWY+eRMbEVt6jH3DU= X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="80311183" Date: Tue, 6 Sep 2022 17:43:30 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V5 6/6] libxl: Allocate MMIO params for GPIO device and update DT Message-ID: References: <4a238937ceb803f494e5633a3a779866383bd463.1661159474.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4a238937ceb803f494e5633a3a779866383bd463.1661159474.git.viresh.kumar@linaro.org> On Mon, Aug 22, 2022 at 02:45:18PM +0530, Viresh Kumar wrote: > This patch allocates Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree based on Virtio GPIO > DT bindings [1]. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml > > Reviewed-by: Oleksandr Tyshchenko > Signed-off-by: Viresh Kumar > --- > tools/libs/light/libxl_arm.c | 51 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 4c1012e56893..86c1e560900f 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -121,6 +121,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return rc; > } > > + for (i = 0; i < d_config->num_gpios; i++) { > + libxl_device_gpio *gpio = &d_config->gpios[i]; > + int rc = alloc_virtio_mmio_params(gc, &gpio->base, &gpio->irq, Indentation seems wrong here. Also, you could declare "rc" (without an initial value) for the whole function rather than declaring it in each for loop scope. Then, this patch could be squash into the one that adds GPIO support to libxl. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400064.641659 (Exim 4.92) (envelope-from ) id 1oVgFt-0001LQ-SL; Tue, 06 Sep 2022 21:37:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400064.641659; Tue, 06 Sep 2022 21:37:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFt-0001L9-OO; Tue, 06 Sep 2022 21:37:13 +0000 Received: by outflank-mailman (input) for mailman id 400064; Tue, 06 Sep 2022 21:37:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFs-0000Cp-Pz for xen-devel@lists.xen.org; Tue, 06 Sep 2022 21:37:12 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 82615bf4-2e01-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:32:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82615bf4-2e01-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662481955; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+yqhlErwciJVAhXvw/R0wfVyEAMpDzNkidgSvAR/+DE=; b=SoLJft8MiPWh9mHsIHiK+EEcEsrN2QAUti32LXwP5LDsH17UxS9tZcth y6Iobvtfpf3KTdHJlY8onXJGpcffm61opnWFS/aFef3te/bLqyh5wq/Fy /wxMBWUsOYgRVy1wDlgS2R3W6DWq7SEYcmBN7DKtNvkJf77FG/ZrN77U3 c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79867428 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:owW9DawxTTKPT9QdOwR6t+dRwSrEfRIJ4+MujC+fZmUNrF6WrkUCz mtLC2rUa6qINGuhLYwkb4Wx90sC68LRzoJqQAdr/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Usx5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN12AWoPHdAl3dpUAEV81 +c0GhYqZBa60rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzJZQFPPVEGToozhu6yilH0ciFCqULTrq0yi4TW5FMggOaybICFEjCMbclWnByj/ mLbxjXgCU4WK9Oc92um/X3504cjmgukAdlPRdVU7MVCn1m71mEVThoMWjOTpv20iVWiSslfA 0MR8ysq66M18SSDS9j+Ulu4p3qBswU0X9tWGvc9rgaXxcL85AKUBXMNSDJbX8A3r889RTEs1 VihksvgAHpkt7j9YXCA8raZqxuiNC5TKnUNDQcGQhEC+MLLu5wog1TESdMLOKu8kt30FCy22 zeLtikznZ0XjMgCzaL99lfC6xqyp57CQwgpoArKX3656R9RYI+jbpavr1/B4p5oPIufC1WMo nUAs8yf9/wVS4GAkmqKWuplNK+o/fueMHvfnFtmBbEl9jKk4XnleppfiBllOEpnO8ADPyT1a UXevQdQ4p57LHqubKlnJYm2DqwCxKztBZLvW/bSY9dmZpl3fRWAuiZ0aia4xHz3mVQriuQzN Imzdt7pCXcBFb8hyDuwTv0al7gxyUgDKXj7HM6hiU79iPzHOSDTGext3Eaygv4R9K6vmSWIz vFjFMqu+TdEfN/YRSPRyNtGRbwVFkTXFawauuQOKLDZelo9ST9/YxPC6eh/ItI4xsy5gs+Np yjgAREAlTITkFWdcW23hmZfhKQDtHqVhVYyJmQSMFmhwBDPiq7/vf5EJ/PbkVTKndGPLMKYr NFfIa1s+twVFlz6F801NPERVrBKehWxnh6pNCG4ejU5dJMIb1WXpIW4JlG+q3JUUXPfWS4CT 1qIj1qzfHb+b146UJa+hAyHlDtdQkTxaMotBhCVc7G/iW3n8ZRwKjyZs8Lb1/okcEybrgZ2I i7MXn/0U8GR/NJumDQI7IjYx7qU/xxWRxILTzWHvebqbkE3PAOLmOd9bQpBRhiFPEucxUloT bw9Iy3UWBHfoGt3jg== IronPort-HdrOrdr: A9a23:akVhwqGmddJCPsP/pLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo= X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="79867428" Date: Tue, 6 Sep 2022 17:32:28 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V5 4/6] libxl: arm: Split make_virtio_mmio_node() Message-ID: References: <981b663f6a44f9f82f32cc58219f6af26f73d66f.1661159474.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <981b663f6a44f9f82f32cc58219f6af26f73d66f.1661159474.git.viresh.kumar@linaro.org> On Mon, Aug 22, 2022 at 02:45:16PM +0530, Viresh Kumar wrote: > make_virtio_mmio_node() creates the DT node for simple MMIO devices > currently, i.e. the ones that don't require any additional properties. > > In order to allow using it for other complex device types, split the > functionality into two, one where the fdt node isn't closed and the > other one to create a simple DT node. > > Reviewed-by: Oleksandr Tyshchenko > Signed-off-by: Viresh Kumar > --- > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 0e3051bac5e4..4d0469f8166a 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -1267,8 +1275,9 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > iommu_created = true; > } > > - FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, > - disk->backend_domid) ); > + FDT( make_virtio_mmio_node_simple(gc, fdt, disk->base, Renaming that function to add the suffix "_simple" doesn't meaning full, could you keep the same name? > + disk->irq, > + disk->backend_domid) ); > } > } > Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400066.641670 (Exim 4.92) (envelope-from ) id 1oVgFv-0001gE-GU; Tue, 06 Sep 2022 21:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400066.641670; Tue, 06 Sep 2022 21:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFv-0001fk-Af; Tue, 06 Sep 2022 21:37:15 +0000 Received: by outflank-mailman (input) for mailman id 400066; Tue, 06 Sep 2022 21:37:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFt-0000Cs-Dd for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3cf15d02-2ded-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 16:07:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB6383.eurprd04.prod.outlook.com (2603:10a6:803:11b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 14:07:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 14:07:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cf15d02-2ded-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2Mydo6mFl4YSH4geYRiIB+6IzNVsWosx7YsVjqSmrfuBLSgv35ZP1aiFeS1sGj9u1X3xQn33qOxSN9xixrEDnMewucadncaVzCzm37Z/5xG/1wdaMMOY/gznGspTAXLy5syBe2/46HVxhNYtk6ziIsUvNlVhmudSczZs6XFXlDVHiyFvZTVi4F+sBGPX/2Ey8/K0Y3/xRj71XQrs4yQBm1KLrm3HJBe/MmDfnvVeJZoNY+teAkC/Y5jyGTa2fHBd506IHzRwO333s7WqgJyF8m8bVo7FsIIqR7idYotEgkdQQ5dLSVMBEB610q4C/LrMF0FAbigdjV+hbXJ5DY5EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IsibSvCp7VNwwiXz4RMjfBGywk5CPpJX+sjS0XubjwA=; b=FKVLH80hWkxvdfjKBYDiXpN6LlDNSSQRxWKegj6uIZnI2GMwnTCVJ5d4/sZFz0kTsSF1JOZ6bwwKNej2T8Iyctli2tTro+yANC8hbESlkyRzQsVlXJXp9drUER/iirD9oGyuXpntHh0sU9RsOEY/mv3473oL7Tox6LAdlFINX38VG0rtI1NWqtGDnxQzl85Dm94iQUeQ5LOobxohVciBl2GM/8FqC9GSBVmj1VC7JUMar8l95Jt48zMGnDgaXzNWIpZ7bUuLKATE6+g8W98gqw1xj+xwnnOViBtm6Am5+56yET9QROuriufwZPKCJZFl/d7bvWt+IdXzdigkDEoM6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IsibSvCp7VNwwiXz4RMjfBGywk5CPpJX+sjS0XubjwA=; b=CthVjGGAHayxla+N6JWhIGVp966rY0VsBFm73V5YCeVR2Ltrj5HfoByTum5ySNQursNrN1E4xDd7cegorOwK3Wh+dw6OJb0NyD1aYWWE5PhNAgcO1LL4f/GHN74AE01C4n28bxoGnEnGqobazvp5VpWJCOdtctPOErbqPb3IkFnY110mnTRiP9JMgHfgXpoDE9bqazZlX2cD0E8Vgt9OzXOmtC0BFq/ys7Zhs1AbR4mCiibxLkT2/HOzEbdITgPAzNe2GxDiDTrD3cxV5ASaRC7BMEz7sNgHStJ4j9RqDiF8dtOUI+/SGMhcuNmn9OJ09XTKzljVl3db1lheffbFGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9af0809d-ab7f-09d0-3fa4-5b73fb605fd6@suse.com> Date: Tue, 6 Sep 2022 16:07:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2] x86/public: move XEN_ACPI_ in a new header Content-Language: en-US To: Henry Wang Cc: Wei Liu , Anthony PERARD , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" , Bertrand Marquis References: <7dbef184-7e55-51d7-27e1-93153b5f0bc9@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de1d297d-a96b-4525-f936-08da90111cc5 X-MS-TrafficTypeDiagnostic: VE1PR04MB6383:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N6y+v385j9B7jCtFaanAZ6xvsq2fwO4d40t+KvFIDmAmDZ3vd0IzEpLhLKbIvzL2KkAXUPPPv7R+gl7xLxlldpl2zHEgYCsfhKuvDAPcSbipi95I7F6kqM5a4DcC7F9197wXc/4bAET4/PjIlLw/bZpZexhuwiqk22DdiEMx9UfY62uuHvEJFlpCMIZDoKWui6q8dcYYOdEJaHtM/HCB2hwkmOXzISmYEmQdQPp6+fppQMIj7O8RvVCytH3RZIuq2B044feN0EelK5A/DsavSBzKGupH+W8gL3JBBUbEDZljtcheVp4Exszt9hfSlyys3T0acu9PVZKfqgjmx6iajf63eurR/Pu8c1iaHS9XYs7lksAjj6NkNkoZPQZgaVTJtaQCqTxxN5U+i6z+Q4Y8W3icf/05VDmVSE3Gjh7Gj+1feIQyKYzqliIJhQCAztEPv3nQIeOFA0oBxYQuT9SL2qqwWIjR1vAseoRR4NdA+mQxm8ZEOnR+jjfbiLUF/w+CEf9RoBFcJSPHIYR0SPmePN5WQBfB7uVfYFqkPzG5SGMjrXsWK7BhRDYa5kaITlRdNDVzg1RKcT5RiORXg9lmzwH8+vbPNJZPo7aOb+kfAX30Xq7gEn2eMX02oGZEcJ13Xjwq3vjFK8iNvmPthR51ryj1eDkyPaoX8WAQ5dirREiU1FhHUCn4aOjnsJgunBOkCbl8lqF0ZKoC+Vkf9xoI//w2wq3IhrgXCCt+q+l1LhQV+V8BpP/1hqYzZz1jsYeG1FLM1N7XnsJ2/vB6rsovq6egwRkiJit81qX+HABeKrg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(346002)(136003)(376002)(66556008)(31686004)(2906002)(41300700001)(31696002)(66946007)(86362001)(66476007)(5660300002)(8936002)(6916009)(54906003)(316002)(36756003)(8676002)(4326008)(26005)(6486002)(38100700002)(186003)(478600001)(6506007)(53546011)(6512007)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDREbjl4VGNqc0FYZkhud28yQ3NjemhMUnpFaVFQOTdGSVlBNWtMN3BSVk0z?= =?utf-8?B?di9wcXdDOU8rNElLM2M5Q0VYOHAweUpnN0QvU1EvM3A5V0NmcTQ3VnlERFdo?= =?utf-8?B?TkRHVU1SRkU1VzB5WHZUTURaUXN5UFNwRjRTV1BuMitUMHhhWmg3U29ud3Bk?= =?utf-8?B?RXdVSE1Rckc0SXk2ajFuNHpxK1c1Tkl6RTJNcTlFUHY0MTZtVGtKcDVORGhi?= =?utf-8?B?QkVhWTVySCt2K2FXbTZnaVNiOXpvRWJKa09FUVZxZXM5VFZBLzBkSlVoSkk0?= =?utf-8?B?dXpldmlYRVFSSnFWWkJIS3E0UHFTdDcwYzFvNFFEMzJRS3FFZWVsRExjT2gv?= =?utf-8?B?ZWZPSXEzVmlvS05oS0RzazRnaFZ0d25JZmp1WThoQ2dTd1JuZGZqc0xMYjBr?= =?utf-8?B?Ky9SVE43akx2RGZ3OTlrWkYrZFQyLzNnOXBwUGtWdXZVUitWcEE4MUYwTWs2?= =?utf-8?B?bk4wdkgxcm5STEh0YXl1eDhhVGdMMHFrbkQybDlpRDJYTWdWOVpiTnkxWXBD?= =?utf-8?B?Rysvb1ZmeGlYcngvOER0MmVQK3pwRm1vamFVdWRnejZtNDhZY0JsNHpPQVMw?= =?utf-8?B?TzdrZURCc3JuOWMzL1BVMng5TytUc092ZGZQbWRsZGRkdlFBSGZNUDhoZW0z?= =?utf-8?B?QU5ZcHlaYis0SklEYzRENjBZRFZTb2xkZC91YlFOLzVPL2RzK2lEeEN2WnpD?= =?utf-8?B?TjF1M1BUM2ZFZXBGdWlidDl6bjU1V3JrZlJ4QUtwRXJFMUpIdXNIMGxNRDVh?= =?utf-8?B?T3duM2gwMGdZY2JHL2ZGSXdvQ3ZXZ0RMN0lNTitobUNIb0t0SjY5TkNBVVkr?= =?utf-8?B?RGNuS3hJMlJEMU14MXJWNGl1dExVaEovS1pmS0FoaUlYZUV4WDlGbDVDSzlH?= =?utf-8?B?N3o5Y2JzK1ptOGpLc0pDak5ZYy9valZ1Ti92OXFlTFZaSktxeWhiTU45Tllw?= =?utf-8?B?UkUwVjhORGhJaWc4dkM4R1RUenh1VUVCSXdOa3BLSVZPVjZxeTU0NkJqem5K?= =?utf-8?B?aGsyeUM3dVZtMGx0ZXNBNzdvTG9vRE1mQU5FL3YvQ0h4UG5kLzhzWjlySjYw?= =?utf-8?B?K3h1cjNuUE9KeFlMcXJoWlZFRFZxQ2trd1JPdDRLck1sOTdWcWtEcUdId1Q4?= =?utf-8?B?a2lrbURDbGg5alhCeTdyZ3d0UVEwMUpTOXlPRkdPNUxIUkFSZlVZdnJqTjU3?= =?utf-8?B?R1cxVzJiK3pLdWlpMVp4cUF6M0dLWUJWWmxuYzNZcTdBbkV6VFkvWEt4SFNJ?= =?utf-8?B?RzRzbVB4RXpzakkyLzFGaVBqNTBaMzFZbUo4TThocmY2QmREQ3BEdCtXZ05o?= =?utf-8?B?NkZINHRZbXpLZmFBQURVL01mY1lhTGNXcXdIUDRWYjJEZ2JFdkNRcStkR2E4?= =?utf-8?B?bjh6T2JIVDhrbnVWWGZlUzhVK0pGSWJMbm1tTjBCTTFIei9rQUpOdVpnM3Za?= =?utf-8?B?RUNyUWg5b2Y2TENXQnlBMlZhOVdBZ0dQSEhQZXZweUVsK2VPclVFSXJ5TVpX?= =?utf-8?B?NmhkS2ZYTDVVMk9RV2pkbUNHUkhGbzVYbnYwcE1PRElIWERRdm5GMmx0a29r?= =?utf-8?B?Sml5TDN4NjFwNzduLzM4V3FDckFQU2xNM2pnTU00T2VsTXA1alB6R0pmZWkx?= =?utf-8?B?VnpqcGpHc2pCc1pud2JzS2NQb203aVdzZTBZTU04ZXRnRzlBajZYSjlUa1dE?= =?utf-8?B?TWtscS9HekJlMEN4NUdTSzExLzVxSUZnQ3lrbXltUVprMEtaUzc4MCtuRFlE?= =?utf-8?B?NzlHREN6blgrNXg0S0lNRWZacElySXZSZDJLVXNZZGt2WWpja1ZVckJMRC9i?= =?utf-8?B?L3BOZlVjakxXcmVZMmlKQjE2WHY3UnRoS2ZieWVUZU1SWlAveUE0MkZMU2RH?= =?utf-8?B?eGZHVUMxbWVqck1pN1RyMkFSMU96dkU1aXZ1aHJIOG1yOExyaDhuZWlmd3c2?= =?utf-8?B?THNJUUw4NXVjZU9mRFlUMURsS1FSSFBFMndxR0dIQlg0VXdzR3FLb2tTdk1i?= =?utf-8?B?bW1hVkZvcVhBTllZS0RmNXM3TVhFb2RPTmpkMlU4UmpXYktIUXladllkUmNH?= =?utf-8?B?cWFUN1RoV3YwN0J5L1czOU03dEpvcjQvcTlsZXV2NkVTeGZwZ1owMlBnZmRB?= =?utf-8?Q?8Z+9DfU1936zKAbweQxu6WxMb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: de1d297d-a96b-4525-f936-08da90111cc5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 14:07:19.9020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: djdkx0TLDdoX6OfRI0tacIQSdIyhio73T+KiOhplgAgE50G50DOViUBwsp/2ejcNBhBGsjFi/UDqPj8roKXHHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6383 On 30.08.2022 02:52, Henry Wang wrote: >> -----Original Message----- >> From: Jan Beulich >> Subject: Re: [PATCH v2] x86/public: move XEN_ACPI_ in a new header >> >> On 25.08.2022 11:48, Bertrand Marquis wrote: >>> When Xen is compiled for x86 on an arm machine, libacpi build is failing >>> due to a wrong include path: >>> - arch-x86/xen.h includes xen.h >>> - xen.h includes arch-arm.h (as __i386__ and __x86_64__ are not defined >>> but arm ones are). >>> >>> To solve this issue move XEN_ACPI_ definitions in a new header >>> guest-acpi.h that can be included cleanly by mk_dsdt.c. >>> Inside this header, only protect the definitions using ifdef >>> __XEN_TOOLS__ as the defines are not used anywhere in the hypervisor >> and >>> are not expected to be. >>> >>> Previous users needing any of the XEN_ACPI_ definitions will now need to >>> include arch-x86/guest-acpi.h instead of arch-x86/xen.h >>> >>> Fixes: d6ac8e22c7c5 ("acpi/x86: define ACPI IO registers for PVH guests") >>> Signed-off-by: Bertrand Marquis >> >> Reviewed-by: Jan Beulich >> >>> For the release manager: >>> - risk: very low, the definitions moved are only used in mk_dsdt and >>> external users would just have to include the new header. >>> - advantage: we can now compile xen for x86 on arm build machines >> >> I'll give it a little for Henry to possibly release-ack this, but since >> strictly speaking this is a bug fix, I think it could also go in without >> (as long as not actually objected to, of course). > > Thanks for informing. Yeah definitely no problem from my side, so: > > Acked-by: Henry Wang # For the 4.17 release I've translated this to Release-acked-by: (as was used for earlier releases). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400067.641673 (Exim 4.92) (envelope-from ) id 1oVgFv-0001kR-TE; Tue, 06 Sep 2022 21:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400067.641673; Tue, 06 Sep 2022 21:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFv-0001jY-NW; Tue, 06 Sep 2022 21:37:15 +0000 Received: by outflank-mailman (input) for mailman id 400067; Tue, 06 Sep 2022 21:37:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFu-0000Cs-Dt for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:14 +0000 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [2607:f8b0:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c3ecca8-2df4-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 16:57:33 +0200 (CEST) Received: by mail-pg1-x52d.google.com with SMTP id bh13so10888662pgb.4 for ; Tue, 06 Sep 2022 07:57:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c3ecca8-2df4-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=pF/gnULvOoDPcgMgAG77rrQ25WG1y2OXxs5BfOhNSrs=; b=DPToRcmFaax2fzEHBCH1R7HkYiMi9nDUepCC1PbOvnym4q4Z3VjbLpQHx4kZHjhbNk M9zcFWQB7KH8yAeiyYT5KKkI5cRKxNXGUXKK25slBSYXsnWIFMT2179D/AKMK7oJWkdB w4zeYZhvG9tmhr6ef88ddFCzPa1OIpjzwcQd8/nxGlwuh8RoLLRALPqYtIMG9Ci80+vG MJqVSCstfo/yvMsqBtO2xeid/3RipEpSjtSK/KbUpCaKU7kZM+fws5zHEUi15fNJ4mk/ pxa10mZvHqFJY1waSf4G6NTE2jo5hkFNdoX9pg+um7OBifqBUnMZ5SmI80/0LgCfM5Pt phvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=pF/gnULvOoDPcgMgAG77rrQ25WG1y2OXxs5BfOhNSrs=; b=T8FpeUL2TpPx3VbmjKgGQxWYR3wnaw59UXjSL6MRmdBWRkB43iPRUH37OaPgD1F82K eA5JDuDXRMPcrD8/lmqU4Z8hELkJWhiTm5Pz/xhRz5pElhok8uo2bcmLEkFKzJMXmzsq gYJCtIZ1+63109D8qY2zA4SkqPWF2baVhzGVT8dQuSw/DOiV56fzn4+NEA2M9sHkRB8k qAyT1G4Z8pH6gIp/4W0Don4MeS2KQ9DoZtm3lDCLScSy/4JkfucjrDULnqqmwuzT43r6 KxlH7VXUf/a3edEJz8sE4mCO5s0kYv9UKod8PnZqxVN1kgXicnlbNPZLVdoZO2CxW+qM Ux0w== X-Gm-Message-State: ACgBeo1x2Mk3cSGPsp4H/xNbTuOZjJEth+L3az0Ywj+HBu/B2F/w5ZuZ clGI4qa52XIIvwu3COMAHT1WwopFwl3SPg/+mqhFFg== X-Google-Smtp-Source: AA6agR6AA52LIhLBVoJq/Dg1SzWGRN/8ovoGFEPxK0y3Z+yRKzFsl2ZjzJDd9FAxmChifk292LZFSVubGWwrVcfQZ9M= X-Received: by 2002:a63:85c1:0:b0:434:3bc1:df34 with SMTP id u184-20020a6385c1000000b004343bc1df34mr10806444pgd.107.1662476251681; Tue, 06 Sep 2022 07:57:31 -0700 (PDT) MIME-Version: 1.0 References: <20220818105601.1896082-1-jens.wiklander@linaro.org> <20220818105601.1896082-4-jens.wiklander@linaro.org> <4627ccd9-8a0a-d63d-6672-7a14c8605179@xen.org> In-Reply-To: <4627ccd9-8a0a-d63d-6672-7a14c8605179@xen.org> From: Jens Wiklander Date: Tue, 6 Sep 2022 16:57:20 +0200 Message-ID: Subject: Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Andrew Cooper Content-Type: text/plain; charset="UTF-8" Hi Julien, On Tue, Sep 6, 2022 at 12:17 AM Julien Grall wrote: > > Hi Jens, > > On 18/08/2022 11:55, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > This commit brings in only the parts needed to negotiate FF-A version > > number with guest and SPMC. > > > > A guest configuration variable "ffa_enabled" is used to indicate if a guest > > is trusted to use FF-A. > > > > This is loosely based on the TEE mediator framework and the OP-TEE > > mediator. > > > > [1] https://developer.arm.com/documentation/den0077/latest > > Signed-off-by: Jens Wiklander > > --- > > SUPPORT.md | 7 + > > docs/man/xl.cfg.5.pod.in | 15 ++ > > tools/include/libxl.h | 6 + > > tools/libs/light/libxl_arm.c | 3 + > > tools/libs/light/libxl_types.idl | 1 + > > tools/xl/xl_parse.c | 3 + > > xen/arch/arm/Kconfig | 11 + > > xen/arch/arm/Makefile | 1 + > > xen/arch/arm/domain.c | 10 + > > xen/arch/arm/domain_build.c | 1 + > > xen/arch/arm/ffa.c | 354 ++++++++++++++++++++++++++++++ > > xen/arch/arm/include/asm/domain.h | 4 + > > xen/arch/arm/include/asm/ffa.h | 71 ++++++ > > xen/arch/arm/vsmc.c | 17 +- > > xen/include/public/arch-arm.h | 2 + > > 15 files changed, 503 insertions(+), 3 deletions(-) > > create mode 100644 xen/arch/arm/ffa.c > > create mode 100644 xen/arch/arm/include/asm/ffa.h > > > > diff --git a/SUPPORT.md b/SUPPORT.md > > index 70e98964cbc0..215bb3c9043b 100644 > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > > > > No support for QEMU backends in a 16K or 64K domain. > > > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > > + > > + Status, Arm64: Tech Preview > > + > > +There are still some code paths where a vCPU may hog a pCPU longer than > > +necessary. The FF-A mediator is not yet implemented for Arm32. > > + > > ### ARM: Guest Device Tree support > > > > Status: Supported > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > > index b98d1613987e..234c036aecb1 100644 > > --- a/docs/man/xl.cfg.5.pod.in > > +++ b/docs/man/xl.cfg.5.pod.in > > @@ -1616,6 +1616,21 @@ This feature is a B. > > > > =back > > > > +=item B > > + > > +B Allow a guest to communicate via FF-A with Secure Partitions > > +(SP), default false. > > + > > +Currently is only a small subset of the FF-A specification supported. Just > > +enough to communicate with OP-TEE. In general all the basic things and > > +sharing memory with one SP. More advanced use cases where memory might be > > +shared or donated to multple SPs is not supported. > > + > > +See L for more > > +informantion about FF-A. > > + > > +This feature is a B. > > + > > =head2 Paravirtualised (PV) Guest Specific Options > > > > The following options apply only to Paravirtual (PV) guests. > > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > > index 7ce978e83c9a..4ab5a7b044d6 100644 > > --- a/tools/include/libxl.h > > +++ b/tools/include/libxl.h > > @@ -278,6 +278,12 @@ > > */ > > #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 > > > > +/* > > + * LIBXL_HAVE_BUILDINFO_ARM_FFA_ENABLED indicates that > > + * libxl_domain_build_info has the arm.ffa_enabled field. > > + */ > > +#define LIBXL_HAVE_BUILDINFO_ARM_FFA_ENABLED 1 > > + > > /* > > * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing > > * 'soft reset' for domains and there is 'soft_reset' shutdown reason > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > > index eef1de093914..a985609861c7 100644 > > --- a/tools/libs/light/libxl_arm.c > > +++ b/tools/libs/light/libxl_arm.c > > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > > return ERROR_FAIL; > > } > > > > + config->arch.ffa_enabled = > > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > > + > > return 0; > > } > > > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > > index 2a42da2f7d78..bf4544bef399 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > > ("vuart", libxl_vuart_type), > > + ("ffa_enabled", libxl_defbool), > > ])), > > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > > ])), > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > > index b98c0de378b6..e0e99ed8d2b1 100644 > > --- a/tools/xl/xl_parse.c > > +++ b/tools/xl/xl_parse.c > > @@ -2746,6 +2746,9 @@ skip_usbdev: > > exit(-ERROR_FAIL); > > } > > } > > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > > + xlu_cfg_get_defbool(config, "ffa_enabled", > > + &b_info->arch_arm.ffa_enabled, 0); > > > > parse_vkb_list(config, d_config); > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > > index be9eff014120..e57e1d3757e2 100644 > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -139,6 +139,17 @@ config TEE > > > > source "arch/arm/tee/Kconfig" > > > > +config FFA > > + bool "Enable FF-A mediator support" if EXPERT > > + default n > > + depends on ARM_64 > > + help > > + This option enables a minimal FF-A mediator. The mediator is > > + generic as it follows the FF-A specification [1], but it only > > + implements a small subset of the specification. > > + > > + [1] https://developer.arm.com/documentation/den0077/latest > > + > > endmenu > > > > menu "ARM errata workaround via the alternative framework" > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > > index bb7a6151c13c..af0c69f793d4 100644 > > --- a/xen/arch/arm/Makefile > > +++ b/xen/arch/arm/Makefile > > @@ -20,6 +20,7 @@ obj-y += domain_build.init.o > > obj-y += domctl.o > > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > > obj-y += efi/ > > +obj-$(CONFIG_FFA) += ffa.o > > obj-y += gic.o > > obj-y += gic-v2.o > > obj-$(CONFIG_GICV3) += gic-v3.o > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > > index 8110c1df8638..a3f00e7e234d 100644 > > --- a/xen/arch/arm/domain.c > > +++ b/xen/arch/arm/domain.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > > if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) > > goto fail; > > > > + if ( (rc = ffa_domain_init(d, config->arch.ffa_enabled)) != 0 ) > > + goto fail; > > + > > update_domain_wallclock_time(d); > > > > /* > > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) > > enum { > > PROG_pci = 1, > > PROG_tee, > > + PROG_ffa, > > PROG_xen, > > PROG_page, > > PROG_mapping, > > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) > > > > PROGRESS(tee): > > ret = tee_relinquish_resources(d); > > + if ( ret ) > > + return ret; > > + > > + PROGRESS(ffa): > > + ret = ffa_relinquish_resources(d); > > if (ret ) > > return ret; > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 7ddd16c26da5..d708f76356f7 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > > if ( gic_number_lines() > 992 ) > > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > > dom0_cfg.arch.tee_type = tee_get_type(); > > + dom0_cfg.arch.ffa_enabled = true; > > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > > > if ( iommu_enabled ) > > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > > new file mode 100644 > > index 000000000000..b85c492928d2 > > --- /dev/null > > +++ b/xen/arch/arm/ffa.c > > @@ -0,0 +1,354 @@ > > +/* > > + * xen/arch/arm/ffa.c > > + * > > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > > + * > > + * Copyright (C) 2022 Linaro Limited > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms and conditions of the GNU General Public > > + * License, version 2, as published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public > > + * License along with this program; If not, see . > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > + > > +/* Error codes */ > > +#define FFA_RET_OK 0 > > +#define FFA_RET_NOT_SUPPORTED -1 > > +#define FFA_RET_INVALID_PARAMETERS -2 > > +#define FFA_RET_NO_MEMORY -3 > > +#define FFA_RET_BUSY -4 > > +#define FFA_RET_INTERRUPTED -5 > > +#define FFA_RET_DENIED -6 > > +#define FFA_RET_RETRY -7 > > +#define FFA_RET_ABORTED -8 > > + > > +/* FFA_VERSION helpers */ > > +#define FFA_VERSION_MAJOR_SHIFT 16U > > +#define FFA_VERSION_MAJOR_MASK 0x7FFFU > > +#define FFA_VERSION_MINOR_SHIFT 0U > > +#define FFA_VERSION_MINOR_MASK 0xFFFFU > > +#define MAKE_FFA_VERSION(major, minor) \ > > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > > + ((minor) & FFA_VERSION_MINOR_MASK)) > > + > > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > > + > > +/* > > + * This is the version we want to use in communication with guests and SPs. > > + * During negotiation with a guest or a SP we may need to lower it for > > + * that particular guest or SP. > > + */ > > +#define FFA_MY_VERSION_MAJOR 1U > > +#define FFA_MY_VERSION_MINOR 1U > > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > > + FFA_MY_VERSION_MINOR) > > + > > +#define FFA_PAGE_SIZE SZ_4K > > + > > +/* > > + * Limit for shared buffer size. Please note that this define limits > > + * number of pages. But user buffer can be not aligned to a page > > + * boundary. So it is possible that user would not be able to share > > + * exactly MAX_SHM_BUFFER_PG * PAGE_SIZE bytes. > > + * > > + * FF-A doesn't have any direct requirments on GlobalPlatform or vice > > + * versa, but an implementation can very well use FF-A in order to provide > > + * a GlobalPlatform interface on top. > > + * > > + * Global Platform specification for TEE requires that any TEE > > + * implementation should allow to share buffers with size of at least > > + * 512KB, which equals to 128 4kB pages. Due to align issue mentioned > > + * above, we need to increase this value to 129. > > + */ > > +#define FFA_MAX_SHM_PAGE_COUNT 129 > > + > > +/* > > + * Limits the number of shared buffers that guest can have at once. This > > + * is to prevent case, when guests tricks XEN into exhausting its own > > + * memory by allocating many small buffers. This value has been chosen > > + * arbitrary. > > + */ > > +#define FFA_MAX_SHM_COUNT 32 > > + > > +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) > > + > > +/* Memory attributes: Normal memory, Write-Back cacheable, Inner shareable */ > > +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU > > + > > +/* Memory access permissions: Read-write */ > > +#define FFA_MEM_ACC_RW 0x2U > > + > > +/* Clear memory before mapping in receiver */ > > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > > +/* Relayer may time slice this operation */ > > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > > +/* Clear memory after receiver relinquishes it */ > > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > > + > > +/* Share memory transaction */ > > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) > > + > > +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL > > + > > +/* Framework direct request/response */ > > +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > > +#define FFA_MSG_TYPE_MASK 0xFFU; > > +#define FFA_MSG_PSCI 0x0U > > +#define FFA_MSG_SEND_VM_CREATED 0x4U > > +#define FFA_MSG_RESP_VM_CREATED 0x5U > > +#define FFA_MSG_SEND_VM_DESTROYED 0x6U > > +#define FFA_MSG_RESP_VM_DESTROYED 0x7U > > + > > +/* > > + * Flags used for the FFA_PARTITION_INFO_GET return message: > > + * BIT(0): Supports receipt of direct requests > > + * BIT(1): Can send direct requests > > + * BIT(2): Can send and receive indirect messages > > + * BIT(3): Supports receipt of notifications > > + * BIT(4-5): Partition ID is a PE endpoint ID > > + */ > > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) > > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) > > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) > > +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) > > + > > +/* > > + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition > > + * count only. > > + */ > > +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) > > + > > +/* Function IDs */ > > +#define FFA_ERROR 0x84000060U > > +#define FFA_SUCCESS_32 0x84000061U > > +#define FFA_SUCCESS_64 0xC4000061U > > +#define FFA_INTERRUPT 0x84000062U > > +#define FFA_VERSION 0x84000063U > > +#define FFA_FEATURES 0x84000064U > > +#define FFA_RX_ACQUIRE 0x84000084U > > +#define FFA_RX_RELEASE 0x84000065U > > +#define FFA_RXTX_MAP_32 0x84000066U > > +#define FFA_RXTX_MAP_64 0xC4000066U > > +#define FFA_RXTX_UNMAP 0x84000067U > > +#define FFA_PARTITION_INFO_GET 0x84000068U > > +#define FFA_ID_GET 0x84000069U > > +#define FFA_SPM_ID_GET 0x84000085U > > +#define FFA_MSG_WAIT 0x8400006BU > > +#define FFA_MSG_YIELD 0x8400006CU > > +#define FFA_MSG_RUN 0x8400006DU > > +#define FFA_MSG_SEND2 0x84000086U > > +#define FFA_MSG_SEND_DIRECT_REQ_32 0x8400006FU > > +#define FFA_MSG_SEND_DIRECT_REQ_64 0xC400006FU > > +#define FFA_MSG_SEND_DIRECT_RESP_32 0x84000070U > > +#define FFA_MSG_SEND_DIRECT_RESP_64 0xC4000070U > > +#define FFA_MEM_DONATE_32 0x84000071U > > +#define FFA_MEM_DONATE_64 0xC4000071U > > +#define FFA_MEM_LEND_32 0x84000072U > > +#define FFA_MEM_LEND_64 0xC4000072U > > +#define FFA_MEM_SHARE_32 0x84000073U > > +#define FFA_MEM_SHARE_64 0xC4000073U > > +#define FFA_MEM_RETRIEVE_REQ_32 0x84000074U > > +#define FFA_MEM_RETRIEVE_REQ_64 0xC4000074U > > +#define FFA_MEM_RETRIEVE_RESP 0x84000075U > > +#define FFA_MEM_RELINQUISH 0x84000076U > > +#define FFA_MEM_RECLAIM 0x84000077U > > +#define FFA_MEM_FRAG_RX 0x8400007AU > > +#define FFA_MEM_FRAG_TX 0x8400007BU > > +#define FFA_MSG_SEND 0x8400006EU > > +#define FFA_MSG_POLL 0x8400006AU > > + > > +struct ffa_ctx { > > + uint32_t guest_vers; > > +}; > > + > > +/* Negotiated FF-A version to use with the SPMC */ > > +static uint32_t ffa_version __read_mostly; > > + > > +static bool ffa_get_version(uint32_t *vers) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_VERSION, > > + .a1 = FFA_MY_VERSION, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > > + { > > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > > + return false; > > + } > > + > > + *vers = resp.a0; > > + > > + return true; > > +} > > + > > +static u16 get_vm_id(const struct domain *d) > > +{ > > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > > + return d->domain_id + 1; > > +} > > + > > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > > + register_t v2, register_t v3, register_t v4, register_t v5, > > + register_t v6, register_t v7) > > +{ > > + set_user_reg(regs, 0, v0); > > + set_user_reg(regs, 1, v1); > > + set_user_reg(regs, 2, v2); > > + set_user_reg(regs, 3, v3); > > + set_user_reg(regs, 4, v4); > > + set_user_reg(regs, 5, v5); > > + set_user_reg(regs, 6, v6); > > + set_user_reg(regs, 7, v7); > > +} > > + > > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > > + uint32_t w3) > > +{ > > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > > +} > > + > > +static void handle_version(struct cpu_user_regs *regs) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t vers = get_user_reg(regs, 1); > > + > > + if ( vers < FFA_VERSION_1_1 ) > > + vers = FFA_VERSION_1_0; > > + else > > + vers = FFA_VERSION_1_1; > > + > > + ctx->guest_vers = vers; > > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > > +} > > + > > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + if ( !ctx ) > > + return false; > > + > > + switch ( fid ) > > + { > > + case FFA_VERSION: > > + handle_version(regs); > > + return true; > > + case FFA_ID_GET: > > + set_regs_success(regs, get_vm_id(d), 0); > > + return true; > > + > > + default: > > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); > > + return false; > > + } > > +} > > + > > +int ffa_domain_init(struct domain *d, bool ffa_enabled) > > +{ > > + struct ffa_ctx *ctx; > > + > > + if ( !ffa_version || !ffa_enabled ) > > AFAIU, this check means that even if the admin requested to enable FFA > for the domain, it may not be honored. > > If that's the case, then I am afraid this is not a desired approach > because this issue will only get noticed after the OS has booted. > > We should return an error if the domain has requested an unavaible feature. OK, I'll return an error. > > > + return 0; > > + > > + ctx = xzalloc(struct ffa_ctx); > > + if ( !ctx ) > > + return -ENOMEM; > > + > > + d->arch.ffa = ctx; > > + > > + return 0; > > +} > > + > > +int ffa_relinquish_resources(struct domain *d) > > This is called from domain_relinquish_resources(). However... > > > > +{ > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + if ( !ctx ) > > + return 0; > > + > > + XFREE(d->arch.ffa); > > ... the allocation of FFA is happening in arch_domain_create(). In case > of early failure, the relinquish helper will not be called. > > You want to split this function in two parts: > 1) ffa_domain_destroy() -> This will be freeing anything that was > allocated by ffa_domain_init() and will be called from > arch_domain_destroy(). > 2) ffa_relinquish_resources() -> This will be freeing any resources > allocated afterwards. > > The former will not preemptible while the latter will. Which should be > fine because arch_domain_init() and therefore arch_domain_free() should > never contain long running operations. Thanks, I'll fix this. > > > + > > + return 0; > > +} > > + > > +static int __init ffa_init(void) > > +{ > > + uint32_t vers; > > + unsigned int major_vers; > > + unsigned int minor_vers; > > + > > + /* > > + * FFA_PAGE_SIZE is defined to 4k and we're currently depending on > > + * using that page size. > > + */ > > + BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE); > > + > > + /* > > + * psci_init_smccc() updates this value with what's reported by EL-3 > > + * or secure world. > > + */ > > + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) > > + { > > + printk(XENLOG_ERR > > + "ffa: unsupported SMCCC version %#x (need at least %#x)\n", > > + smccc_ver, ARM_SMCCC_VERSION_1_2); > > + return 0; > > + } > > + > > + if ( !ffa_get_version(&vers) ) > > + return 0; > > + > > + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) > > + { > > + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers); > > + return 0; > > + } > > + > > + major_vers = (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR_MASK; > > + minor_vers = vers & FFA_VERSION_MINOR_MASK; > > + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", > > + FFA_MY_VERSION_MAJOR, FFA_MY_VERSION_MINOR); > > + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > > + major_vers, minor_vers); > > + > > + ffa_version = vers; > > + > > + return 0; > > +} > > + > > +__initcall(ffa_init); > > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > > index ed63c2b6f91f..b3dee269bced 100644 > > --- a/xen/arch/arm/include/asm/domain.h > > +++ b/xen/arch/arm/include/asm/domain.h > > @@ -103,6 +103,10 @@ struct arch_domain > > void *tee; > > #endif > > > > +#ifdef CONFIG_FFA > > + void *ffa; > > +#endif > > + > > bool directmap; > > } __cacheline_aligned; > > > > diff --git a/xen/arch/arm/include/asm/ffa.h b/xen/arch/arm/include/asm/ffa.h > > new file mode 100644 > > index 000000000000..4f4a739345bd > > --- /dev/null > > +++ b/xen/arch/arm/include/asm/ffa.h > > @@ -0,0 +1,71 @@ > > +/* > > + * xen/arch/arm/ffa.c > > + * > > + * Arm Firmware Framework for ARMv8-A(FFA) mediator > > + * > > + * Copyright (C) 2021 Linaro Limited > > + * > > + * Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without restriction, > > + * including without limitation the rights to use, copy, modify, merge, > > + * publish, distribute, sublicense, and/or sell copies of the Software, > > + * and to permit persons to whom the Software is furnished to do so, > > + * subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#ifndef __ASM_ARM_FFA_H__ > > +#define __ASM_ARM_FFA_H__ > > + > > +#include > > + > > +#include > > +#include > > + > > +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) > > +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) > > + > > +static inline bool is_ffa_fid(uint32_t fid) > > +{ > > + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; > > + > > + return fn >= FFA_FNUM_MIN_VALUE && fn <= FFA_FNUM_MAX_VALUE; > > +} > > + > > +#ifdef CONFIG_FFA > > +#define FFA_NR_FUNCS 11 > > You wrote 11 here, but you seem only expose 2 in this patch. However, > AFAICT the call count is deprected in SMCCC v1.2. So do we need to > update it? > > But if it is not deprecated then... I suppose that as long as we do support it we should try to return an accurate number. This value is used in the macro SSSC_SMCCC_FUNCTION_COUNT together with values from other services which is then returned for ARM_SMCCC_CALL_COUNT_FID(STANDARD). > > > + > > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid); > > +int ffa_domain_init(struct domain *d, bool ffa_enabled); > > +int ffa_relinquish_resources(struct domain *d); > > +#else > > +#define FFA_NR_FUNCS 0 > > + > > +static inline bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + return false; > > +} > > + > > +static inline int ffa_domain_init(struct domain *d, bool ffa_enabled) > > +{ > > + return 0; > > For the same reason as above, this should return -ENODEV if ffa_enabled > is true. Thanks, I'll fix. > > > +} > > + > > +static inline int ffa_relinquish_resources(struct domain *d) > > +{ > > + return 0; > > +} > > +#endif > > + > > +#endif /*__ASM_ARM_FFA_H__*/ > > diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c > > index 6f90c08a6304..34586025eff8 100644 > > --- a/xen/arch/arm/vsmc.c > > +++ b/xen/arch/arm/vsmc.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -32,7 +33,7 @@ > > #define XEN_SMCCC_FUNCTION_COUNT 3 > > > > /* Number of functions currently supported by Standard Service Service Calls. */ > > -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) > > +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) > > ... it seems incorrect to me add FFA_NR_FUNCS unconditionally because > while the hypervisor may support FFA, the guest may not have access to it. OK, I'll add a runtime check. > > > > > static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) > > { > > @@ -196,13 +197,23 @@ static bool handle_existing_apis(struct cpu_user_regs *regs) > > return do_vpsci_0_1_call(regs, fid); > > } > > > > +static bool is_psci_fid(uint32_t fid) > > +{ > > + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; > > + > > + return fn >= 0 && fn <= 0x1fU; > > +} > > + > > /* PSCI 0.2 interface and other Standard Secure Calls */ > > static bool handle_sssc(struct cpu_user_regs *regs) > > { > > uint32_t fid = (uint32_t)get_user_reg(regs, 0); > > > > - if ( do_vpsci_0_2_call(regs, fid) ) > > - return true; > > + if ( is_psci_fid(fid) ) > > + return do_vpsci_0_2_call(regs, fid); > > + > > + if ( is_ffa_fid(fid) ) > > + return ffa_handle_call(regs, fid); > > > > switch ( fid ) > > { > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > > index ab05fe12b0de..53f8d44a6a8e 100644 > > --- a/xen/include/public/arch-arm.h > > +++ b/xen/include/public/arch-arm.h > > @@ -318,6 +318,8 @@ struct xen_arch_domainconfig { > > /* IN/OUT */ > > uint8_t gic_version; > > /* IN */ > > + uint8_t ffa_enabled; > > AFAIU, this will be 0/1. We have a 'flags' in common but not in arch. > > I don't think we should use the common one (I don't think FFA will be > ever used on x86?). So I would introduce a new field flag in > xen-arch_domainconfig. > > Also AFAICT, XEN_DOMCTL_INTERFACE_VERSION has already been bumped for > 4.17. So we should not need to do it in this patch. However, if this is > not going to merged in 4.17, then you will need to bump the domctl > version (assuming this is the first patch touch the domctl after the > release). OK, I'll add a flags field. Let's see who will have to bump XEN_DOMCTL_INTERFACE_VERSION. Thanks for the review. Cheers, Jens > > > + /* IN */ > > uint16_t tee_type; > > /* IN */ > > uint32_t nr_spis; > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400070.641691 (Exim 4.92) (envelope-from ) id 1oVgFx-0002Dd-SY; Tue, 06 Sep 2022 21:37:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400070.641691; Tue, 06 Sep 2022 21:37:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFx-0002Cc-L1; Tue, 06 Sep 2022 21:37:17 +0000 Received: by outflank-mailman (input) for mailman id 400070; Tue, 06 Sep 2022 21:37:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFw-0000Cs-Ir for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:16 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4200651a-2df7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:19:10 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id gh9so2159634ejc.8 for ; Tue, 06 Sep 2022 08:19:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4200651a-2df7-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Ma2iDt0aE81Ahc9ZUJZycp2jvO5tJvy1n9qVt6gCQwI=; b=mZ+FcifZ+4aqabfna498JJgJVm7ZJdYQe8WPPtTpmukN0ltsFgbqVaNbL1sFWPnx0F +kFG3VCNFENVAovNsysmwpOZ9RuJ0ufsyH/pTm2Y0z5gRcOpO/R+heCj40VC0B/407ah gIy12X9ei8z3+szxvE4NyRdxrjANyShKAEl2/x/Zm5O/QSiE8OYXer9bdBZdxhHaAE7q f4tiV5HYLbiMy7AqJzsjwqwX5vSbICO2tfPlRmT+E50cm2MApRR8eNqmx5TuhyMcbdUY 7WrJdlicqbcwsKebKLfXD1Wod6uRLkMhZP+32t59uXM5n6TIYOGjSb2jPimnfwACXEvM IUDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Ma2iDt0aE81Ahc9ZUJZycp2jvO5tJvy1n9qVt6gCQwI=; b=eIjK40b8TuGirYNurrA5KVpn2mgDPMTrGX/lKCPlmZ7uk8QIj+a03u1dgqFcSsFwwa N44Ne/zpQ7DloC6QEiraz/DpHX/kBy6eAReBlKVTeZ+m/qjZC0OVAO9FgB3MdXvDMdHF autROhVzpfEEv4xlXgsZ8iOOEbhsVMhp4RJEY0UC0xHVB/ccYvO1uPJMplxB14hJVTVw SvA+/QkjEnMUQD+97kISqgWX3jt7wiQQFoj7Q0nEcqLfSWWh0ne/k/tnkknUqb5KN4P2 K752DcRYBxcLeCAgV0H4spsxSxBFR/IjzGwv6HyhphQs2u6ySEsOtFL6W8sRUyBZJh8F BNPg== X-Gm-Message-State: ACgBeo1Sk2RhRbyg4paAv96xj1o2tlPwpbp2wpbaBSzC5ShYUhm7i6FA GT39S0t1xenKET9rsD+78FYh+giehq37KUBdw+8= X-Google-Smtp-Source: AA6agR5G9HfMrf0VgwjZaDpL+Bw3LD81rl/8ufqZpYLsPbGzQjkQjICo51PcirHskBDNf2s6ND3MqbShzMKHHJ8IDw0= X-Received: by 2002:a17:907:2ce7:b0:741:6e62:4558 with SMTP id hz7-20020a1709072ce700b007416e624558mr31784827ejc.273.1662477550254; Tue, 06 Sep 2022 08:19:10 -0700 (PDT) MIME-Version: 1.0 References: <20220829151536.8578-1-jandryuk@gmail.com> <20220902165921.GA354189@bhelgaas> In-Reply-To: <20220902165921.GA354189@bhelgaas> From: Jason Andryuk Date: Tue, 6 Sep 2022 11:18:58 -0400 Message-ID: Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state To: Bjorn Helgaas Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Bjorn Helgaas , xen-devel , linux-pci@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" On Fri, Sep 2, 2022 at 12:59 PM Bjorn Helgaas wrote: > > The conventional style for subject (from "git log --oneline") is: > > xen/pcifront: Handle ... > > On Mon, Aug 29, 2022 at 11:15:36AM -0400, Jason Andryuk wrote: > > An HVM guest with linux stubdom and 2 PCI devices failed to start as > > "stubdom" might be handy shorthand in the Xen world, but I think > it would be nice to consistently spell out "stubdomain" since you use > both forms randomly in this commit log and newbies like me have to > wonder whether they're the same or different. > > > libxl timed out waiting for the PCI devices to be added. It happens > > intermittently but with some regularity. libxl wrote the two xenstore > > entries for the devices, but then timed out waiting for backend state 4 > > (Connected) - the state stayed at 7 (Reconfiguring). (PCI passthrough > > to an HVM with stubdomain is PV passthrough to the stubdomain and then > > HVM passthrough with the QEMU inside the stubdomain.) > > > > The stubdom kernel never printed "pcifront pci-0: Installing PCI > > frontend", so it seems to have missed state 4 which would have > > called pcifront_try_connect -> pcifront_connect_and_init_dma > > Add "()" after function names for clarity. > > > Have pcifront_detach_devices special-case state Initialised and call > > pcifront_connect_and_init_dma. Don't use pcifront_try_connect because > > that sets the xenbus state which may throw off the backend. After > > connecting, skip the remainder of detach_devices since none have been > > initialized yet. When the backend switches to Reconfigured, > > pcifront_attach_devices will pick them up again. Thanks for taking a look, Bjorn. That all sounds good. I'll wait a little longer to see if there is any more feedback before sending a v2. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400071.641702 (Exim 4.92) (envelope-from ) id 1oVgFz-0002bi-9x; Tue, 06 Sep 2022 21:37:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400071.641702; Tue, 06 Sep 2022 21:37:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFz-0002ad-4V; Tue, 06 Sep 2022 21:37:19 +0000 Received: by outflank-mailman (input) for mailman id 400071; Tue, 06 Sep 2022 21:37:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFx-0000Cs-C6 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4b380e1a-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:00:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D92E31756; Tue, 6 Sep 2022 02:00:12 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BF17D3F7B4; Tue, 6 Sep 2022 02:00:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b380e1a-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Julien Grall Subject: [PATCH v7 4/9] xen/arm: introduce put_page_nr and get_page_nr Date: Tue, 6 Sep 2022 16:59:36 +0800 Message-Id: <20220906085941.944592-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit introduces a set of new helpers put_page_nr() and get_page_nr() to increment/drop the page reference by nr. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall --- v6 change: - no change --- v5 change: - no change --- v4 changes: - fix the assert about checking overflow to make sure that the right equation return is at least equal to nr - simplify the assert about checking the underflow --- v3 changes: - check overflow with "n" - remove spurious change - bring back the check that we enter the loop only when count_info is greater than 0 --- v2 change: - new commit --- xen/arch/arm/include/asm/mm.h | 4 ++++ xen/arch/arm/mm.c | 42 +++++++++++++++++++++++++++-------- 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index da25251cda..765aeddb4b 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -356,6 +356,10 @@ void free_init_memory(void); int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order); +extern bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr); +extern void put_page_nr(struct page_info *page, unsigned long nr); + extern void put_page_type(struct page_info *page); static inline void put_page_and_type(struct page_info *page) { diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index c81c706c8b..71942f15e7 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1461,21 +1461,29 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } -struct domain *page_get_owner_and_reference(struct page_info *page) +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, + unsigned long nr) { unsigned long x, y = page->count_info; struct domain *owner; + /* Restrict nr to avoid "double" overflow */ + if ( nr >= PGC_count_mask ) + { + ASSERT_UNREACHABLE(); + return NULL; + } + do { x = y; /* * Count == 0: Page is not allocated, so we cannot take a reference. * Count == -1: Reference count would wrap, which is invalid. */ - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) + if ( unlikely(((x + nr) & PGC_count_mask) <= nr) ) return NULL; } - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); owner = page_get_owner(page); ASSERT(owner); @@ -1483,14 +1491,19 @@ struct domain *page_get_owner_and_reference(struct page_info *page) return owner; } -void put_page(struct page_info *page) +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + return page_get_owner_and_nr_reference(page, 1); +} + +void put_page_nr(struct page_info *page, unsigned long nr) { unsigned long nx, x, y = page->count_info; do { - ASSERT((y & PGC_count_mask) != 0); + ASSERT((y & PGC_count_mask) >= nr); x = y; - nx = x - 1; + nx = x - nr; } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); @@ -1500,19 +1513,30 @@ void put_page(struct page_info *page) } } -bool get_page(struct page_info *page, const struct domain *domain) +void put_page(struct page_info *page) +{ + put_page_nr(page, 1); +} + +bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr) { - const struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); if ( likely(owner == domain) ) return true; if ( owner != NULL ) - put_page(page); + put_page_nr(page, nr); return false; } +bool get_page(struct page_info *page, const struct domain *domain) +{ + return get_page_nr(page, domain, 1); +} + /* Common code requires get_page_type and put_page_type. * We don't care about typecounts so we just do the minimum to make it * happy. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:37:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:37:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400072.641713 (Exim 4.92) (envelope-from ) id 1oVgG0-0002zb-Sd; Tue, 06 Sep 2022 21:37:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400072.641713; Tue, 06 Sep 2022 21:37:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgG0-0002yz-M9; Tue, 06 Sep 2022 21:37:20 +0000 Received: by outflank-mailman (input) for mailman id 400072; Tue, 06 Sep 2022 21:37:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgFy-0000Cs-Ex for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:18 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4d2e4e45-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:00:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B4FB139F; Tue, 6 Sep 2022 02:00:16 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 21DE33F7B4; Tue, 6 Sep 2022 02:00:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d2e4e45-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Julien Grall Subject: [PATCH v7 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated Date: Tue, 6 Sep 2022 16:59:37 +0800 Message-Id: <20220906085941.944592-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini Acked-by: Julien Grall --- v7 changes: - change "unsigned long bank" to "unsigned int bank" --- v6 change: - adapt to the change of "nr_shm_borrowers" - add in-code comment to explain if the borrower is created first, we intend to add pages in the P2M without reference. --- v5 change: - no change --- v4 changes: - no change --- v3 change: - printk rather than dprintk since it is a serious error --- v2 change: - new commit --- xen/arch/arm/domain_build.c | 60 +++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4be8a00171..dbb880b5f2 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -761,6 +761,30 @@ static void __init assign_static_memory_11(struct domain *d, } #ifdef CONFIG_STATIC_SHM +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned int bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( (pbase == bank_start) && (psize == bank_size) ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + + return 0; +} + /* * This function checks whether the static shared memory region is * already allocated to dom_io. @@ -827,6 +851,8 @@ static int __init assign_shared_memory(struct domain *d, { mfn_t smfn; int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; dprintk(XENLOG_INFO, "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -840,6 +866,7 @@ static int __init assign_shared_memory(struct domain *d, * DOMID_IO is auto-translated (i.e. it seems RAM 1:1). So we do not need * to create mapping in the P2M. */ + nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, @@ -851,6 +878,39 @@ static int __init assign_shared_memory(struct domain *d, } } + /* + * Get the right amount of references per page, which is the number of + * borrower domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of letting borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + * So if the borrower is created first, it will cause adding pages + * in the P2M without reference. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400104.641725 (Exim 4.92) (envelope-from ) id 1oVgHd-0006Ei-BW; Tue, 06 Sep 2022 21:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400104.641725; Tue, 06 Sep 2022 21:39:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHd-0006Eb-7p; Tue, 06 Sep 2022 21:39:01 +0000 Received: by outflank-mailman (input) for mailman id 400104; Tue, 06 Sep 2022 21:39:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGK-0000Cs-CH for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 91499e18-2de9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 15:41:11 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E3681A2D; Tue, 6 Sep 2022 06:41:16 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D148A3F7B4; Tue, 6 Sep 2022 06:41:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91499e18-2de9-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Michal Orzel Subject: [PATCH v4 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Date: Tue, 6 Sep 2022 14:40:39 +0100 Message-Id: <80a13d3afcd46ecfb94a919fa0a8cf2bbd3be0a8.1662462034.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event channels code assumes that all the buckets below d->valid_evtchns are always allocated. This assumption hold in most of the situation because a guest is not allowed to chose the port. Instead, it will be the first free from port 0. When static event channel support will be added for dom0less domains user can request to allocate the evtchn port numbers that are scattered in nature. The existing implementation of evtchn_allocate_port() is not able to deal with such situation and will end up to override bucket or/and leave some bucket unallocated. The latter will result to a droplet crash if the event channel belongs to an unallocated bucket. This can be solved by making sure that all the buckets below d->valid_evtchns are allocated. There should be no impact for most of the situation but LM/LU as only one bucket would be allocated. For LM/LU, we may end up to allocate multiple buckets if ports in use are sparse. A potential alternative is to check that the bucket is valid in is_port_valid(). This should still possible to do it without taking per-domain lock but will result a couple more of memory access. Signed-off-by: Julien Grall Signed-off-by: Rahul Singh Reviewed-by: Michal Orzel --- Changes in v4: - fix comment to remove the reference to Guest Transparent Migration and Live Update - Added Michal Reviewed-by Changes in v3: - fix comments in commit msg. - modify code related to d->valid_evtchns and {read,write}_atomic() Changes in v2: - new patch in this version to avoid the security issue --- xen/common/event_channel.c | 55 ++++++++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 20 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index c2c6f8c151..f81c229358 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -193,6 +193,15 @@ static struct evtchn *alloc_evtchn_bucket(struct domain *d, unsigned int port) return NULL; } +/* + * Allocate a given port and ensure all the buckets up to that ports + * have been allocated. + * + * The last part is important because the rest of the event channel code + * relies on all the buckets up to d->valid_evtchns to be valid. However, + * event channels may be sparsed when allocating the static evtchn port + * numbers that are scattered in nature. + */ int evtchn_allocate_port(struct domain *d, evtchn_port_t port) { if ( port > d->max_evtchn_port || port >= max_evtchns(d) ) @@ -207,30 +216,36 @@ int evtchn_allocate_port(struct domain *d, evtchn_port_t port) } else { - struct evtchn *chn; - struct evtchn **grp; + unsigned int alloc_port = read_atomic(&d->valid_evtchns); - if ( !group_from_port(d, port) ) + do { - grp = xzalloc_array(struct evtchn *, BUCKETS_PER_GROUP); - if ( !grp ) - return -ENOMEM; - group_from_port(d, port) = grp; - } + struct evtchn *chn; + struct evtchn **grp; - chn = alloc_evtchn_bucket(d, port); - if ( !chn ) - return -ENOMEM; - bucket_from_port(d, port) = chn; + if ( !group_from_port(d, alloc_port) ) + { + grp = xzalloc_array(struct evtchn *, BUCKETS_PER_GROUP); + if ( !grp ) + return -ENOMEM; + group_from_port(d, alloc_port) = grp; + } - /* - * d->valid_evtchns is used to check whether the bucket can be - * accessed without the per-domain lock. Therefore, - * d->valid_evtchns should be seen *after* the new bucket has - * been setup. - */ - smp_wmb(); - write_atomic(&d->valid_evtchns, d->valid_evtchns + EVTCHNS_PER_BUCKET); + chn = alloc_evtchn_bucket(d, alloc_port); + if ( !chn ) + return -ENOMEM; + bucket_from_port(d, alloc_port) = chn; + + /* + * d->valid_evtchns is used to check whether the bucket can be + * accessed without the per-domain lock. Therefore, + * d->valid_evtchns should be seen *after* the new bucket has + * been setup. + */ + smp_wmb(); + alloc_port += EVTCHNS_PER_BUCKET; + write_atomic(&d->valid_evtchns, alloc_port); + } while ( port >= alloc_port ); } write_atomic(&d->active_evtchns, d->active_evtchns + 1); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400106.641736 (Exim 4.92) (envelope-from ) id 1oVgHe-0006Ue-KG; Tue, 06 Sep 2022 21:39:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400106.641736; Tue, 06 Sep 2022 21:39:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHe-0006UT-H0; Tue, 06 Sep 2022 21:39:02 +0000 Received: by outflank-mailman (input) for mailman id 400106; Tue, 06 Sep 2022 21:39:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGU-0000Cs-EE for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:50 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id bd567900-2de9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 15:42:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5BAFF1A2D; Tue, 6 Sep 2022 06:42:30 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5B613F7B4; Tue, 6 Sep 2022 06:42:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd567900-2de9-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Julien Grall Subject: [PATCH v4 4/7] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Date: Tue, 6 Sep 2022 14:40:42 +0100 Message-Id: <1be278df2743b89e4b3a14e73b5e3a9064b2269a.1662462034.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently evtchn_alloc_unbound() always allocates the next available port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_alloc_unbound() to accept the port number as an argument and allocate the specified port if available. If the port number argument is zero, the next available port will be allocated. Signed-off-by: Rahul Singh Acked-by: Jan Beulich Reviewed-by: Julien Grall --- Changes in v4: - no changes Changes in v3: - fix minor comments in commit msg Changes in v2: - fix minor comments --- xen/arch/arm/domain_build.c | 2 +- xen/common/event_channel.c | 17 ++++++++++++----- xen/include/xen/event.h | 3 ++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fde133cd94..707e247f6a 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3171,7 +3171,7 @@ static int __init alloc_xenstore_evtchn(struct domain *d) alloc.dom = d->domain_id; alloc.remote_dom = hardware_domain->domain_id; - rc = evtchn_alloc_unbound(&alloc); + rc = evtchn_alloc_unbound(&alloc, 0); if ( rc ) { printk("Failed allocating event channel for domain\n"); diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 565ab71881..f546e81758 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -317,11 +317,15 @@ static int evtchn_get_port(struct domain *d, evtchn_port_t port) return rc ?: port; } -int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) +/* + * If port is zero get the next free port and allocate. If port is non-zero + * allocate the specified port. + */ +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, evtchn_port_t port) { struct evtchn *chn; struct domain *d; - int port, rc; + int rc; domid_t dom = alloc->dom; d = rcu_lock_domain_by_any_id(dom); @@ -330,8 +334,11 @@ int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) write_lock(&d->event_lock); - if ( (port = get_free_port(d)) < 0 ) - ERROR_EXIT_DOM(port, d); + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; + chn = evtchn_from_port(d, port); rc = xsm_evtchn_unbound(XSM_TARGET, d, chn, alloc->remote_dom); @@ -1222,7 +1229,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) struct evtchn_alloc_unbound alloc_unbound; if ( copy_from_guest(&alloc_unbound, arg, 1) != 0 ) return -EFAULT; - rc = evtchn_alloc_unbound(&alloc_unbound); + rc = evtchn_alloc_unbound(&alloc_unbound, 0); if ( !rc && __copy_to_guest(arg, &alloc_unbound, 1) ) rc = -EFAULT; /* Cleaning up here would be a mess! */ break; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index f3021fe304..f31963703f 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -72,7 +72,8 @@ void evtchn_free(struct domain *d, struct evtchn *chn); int evtchn_allocate_port(struct domain *d, unsigned int port); /* Allocate a new event channel */ -int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc); +int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, + evtchn_port_t port); /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400107.641742 (Exim 4.92) (envelope-from ) id 1oVgHf-0006ZO-1B; Tue, 06 Sep 2022 21:39:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400107.641742; Tue, 06 Sep 2022 21:39:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHe-0006Yo-P3; Tue, 06 Sep 2022 21:39:02 +0000 Received: by outflank-mailman (input) for mailman id 400107; Tue, 06 Sep 2022 21:39:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGd-0000Cs-G2 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:59 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6dee2aff-2dd7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 13:31:20 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id lz22so1644213ejb.3 for ; Tue, 06 Sep 2022 04:31:20 -0700 (PDT) Received: from leoy-yangtze.lan (n058152048222.netvigator.com. [58.152.48.222]) by smtp.gmail.com with ESMTPSA id gk3-20020a17090790c300b0076f0a723f6bsm782752ejb.58.2022.09.06.04.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 04:31:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dee2aff-2dd7-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=u1lE6IuDeB5I0S1Xvxbo8D+JPrxouKQRMpg3Oo16TQ4=; b=s2NPyyRkBPiN/qGw85S06CQztG4mMVk/mX9w8QrnNYh9NrfGGz5pRElk7U+osZP7AU SaWbgZRWR0PwVlcrXqt2w2ZFzF/Jk/Mik5bZ8KdC3UH2/D5gUbpjLIEVLcGfII53GsY8 QtN5hy4VgPcaZ799AKjEl/RDLkjx5wMIaxDh8QTwkwy2hi7nlDP1xZViDczo7EmBe8t6 vPv42rJqlrBL59Pay7f1XN91QLiUQ04I1VRZiFxtHsyz/WgQ1n4vLMO1kowpZahgaQHK RcWDYz6SMdIaP2a5ksSsPHLfaLrGpWfTQVBVfgiJ5PelEmMZwFi04XQLL0EbVDmVZ0ts UdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=u1lE6IuDeB5I0S1Xvxbo8D+JPrxouKQRMpg3Oo16TQ4=; b=j14Cmg6/wrMwPhm5kj4ARUdhjNfLoX9+JvXHKVFY2zToTZUQVLhIHXnPsW32JWPfgc B3sFKGyub8snkB38z5YWNoRYS+2gHqdjH/0WliY4YCqfAFmMjOEBcCtcblowglc1+6AF KziBVlzR2ZNFx77cEIakN2S1JBVveaXLHdTxXq6w3eCE0mu3th+dCBZm09bwXoTDF/6U 92Koo/7SU9+gJMwJMj3eBq3cAKqve06MJIXlzxav6qPhaXq1LJgYlRUUk2h8YWQ1PXG5 GxRqv+6nEiczZFk4hfdwJ1qZullCEcKc25FU31JVpiwdX9dFZ4XM8euW32V8CLbEoRc2 NjPQ== X-Gm-Message-State: ACgBeo2FvqHWbGcC/a8lyvK3MJwAczohq7wcuWKXfFG5uYOYiORKeht0 sfuvJfUTPyZGqB1oX1JzJ/YRIg== X-Google-Smtp-Source: AA6agR5vL4G0ofH226R7BMWLaaJ7Afuu5Iu3WJag+usCmj1pYjafbXi9JlLomiHiC4GmBTaLhiGdUg== X-Received: by 2002:a17:906:5a4c:b0:76f:3e98:b453 with SMTP id my12-20020a1709065a4c00b0076f3e98b453mr1268994ejc.509.1662463879954; Tue, 06 Sep 2022 04:31:19 -0700 (PDT) From: Leo Yan To: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: Leo Yan Subject: [PATCH] xen/arm: acpi: Include header file for version number Date: Tue, 6 Sep 2022 19:31:12 +0800 Message-Id: <20220906113112.106995-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Arm64 Linux kernel prints log for Xen version number: [ 0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found Because the header file "xen/compile.h" is missed, XEN_VERSION and XEN_SUBVERSION are not defined, thus compiler directly uses the string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string. This patch includes the header "xen/compile.h" which defines macros for XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via hypervisor node. Signed-off-by: Leo Yan --- xen/arch/arm/acpi/domain_build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c index bbdc90f92c..2649e11fd4 100644 --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -9,6 +9,7 @@ * GNU General Public License for more details. */ +#include #include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400116.641758 (Exim 4.92) (envelope-from ) id 1oVgHj-0007AX-K7; Tue, 06 Sep 2022 21:39:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400116.641758; Tue, 06 Sep 2022 21:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHj-0007A5-Ci; Tue, 06 Sep 2022 21:39:07 +0000 Received: by outflank-mailman (input) for mailman id 400116; Tue, 06 Sep 2022 21:39:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGt-0000Cs-1Y for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:15 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00043.outbound.protection.outlook.com [40.107.0.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d05d552-2dfb-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:50:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB3356.eurprd04.prod.outlook.com (2603:10a6:7:8a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 15:50:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 15:50:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d05d552-2dfb-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIwv1472R+qR0mhXPVS4RGnUZn0onvYqV4ZO7E7Cf9fssVWklImcJgh7ciacrH6nnK3/BeREG8TsK5Q4EP/x8wWrihJf2zWr1NQOJ3gEkMoDxFKTpyr03XTTdomx5RixvcpN91taYyREJUmSD2GrdrlhFj8RPt6A1SQuX0khdFcWgqbzwD6KEeXZUD9KU7Niw5VW6CtVLUzyYhppPNY9zUltExJq7Sxkzv9OPBECiLMUB2Rx8j0xVhaoNIZIt1BtnGaBf2TBIxwGepv9HolVWRCCn/z1qnW+D7Szf1Hv3FXwbs8obPWnzTh5HzIbhlkR62DaHX+QoBNlvcmpG2705g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vB4j2pxCH2RTjllMuol6WACmZJs5T0m0lZfjkdgonzw=; b=ZzF8LffjX9dQGqGmwDT5ZDTcEpL4YkWsAr+vXZ1yIgihGnsQXUhjNAEt5G87E+9N6NfquXPH7OQAP2OlHu7iFe5hab7VUhV338KfMlf0YbNZZquLa7111ZmOxtv04R3PwZVXGdXJVr+RURfAxZyfRYdBUWOPW4et+ehTItXVV0rL8Kc5sImEetnVcz1+q44iDYpaXm42xzg2ljfhLZvVkGwqlu43z8E6lz7/U4D4djoGe+xNKyV1oRuzrP7YgGh+mbIocPKhIDCn70TBKn58ECrCyjRbhzLgyv0x6DDyP8+e/kPzlyOjWDekkANQpGZ5UAi8/6zVDLtVIozzR6u/RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vB4j2pxCH2RTjllMuol6WACmZJs5T0m0lZfjkdgonzw=; b=C3pTykEAfZ6+RcJulIrEUHpjyPb68eqfjG/mMas1127Kg0nVCX+dF/lb/fxW0ehr2/QhqznsWXyXLdapBPEgZoyxvt4GEAwbHahdrpqwFnWCOnYzOcDqOEOvGdPjin5iKo7zZ05DHNflthegNUsLZJtYlvvDEKPxIiKf1Q6y87+l28gqulW4W7+uFJBAUfXyAnTOVlV8oa29ygkRW9DvwXbsPLJA0lLttK+th2MefxhpGKRFAOfJ8cbKMbFmQ0cCYejU3f7sbdjSIGr7zV5Hx8KYuW+E0pTiqUS1gjNoNcxTL2VSshw4LB4+juNutF15vNSw8j7eK4jMITdnMT7M2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 17:50:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/timer: don't migrate timers away from cpus during suspend Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <20220906124135.12998-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220906124135.12998-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0402.eurprd06.prod.outlook.com (2603:10a6:20b:461::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d28384f-19fc-4026-39c2-08da901f7f2a X-MS-TrafficTypeDiagnostic: HE1PR0402MB3356:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fDuL1bf7P6Mjj2kLQwQrgVPWBe5wYmqhSw/6+hZYsxilqghQjJZ93ufmREVEkpjWkIyp1GdKQEmkMXsAJuratUf4mUxq3Y/UphnE/PXmF5+EfOJRt3DD5zbKyT7yXU4vEaeLf9UYdf2fkZtIPrC4eWbTvjAh2jrG1XzeUD3S0Yz7IIRTPj9HhLwM1WcN/3/bdVI5vkDezfd0z19SRDmYGQTFVoVC/d7ve+SCDNN5MobkW18NpxuA4zgyLMLtTo/wuzdRe+Ecq/sk2S1U3XBEU5CUU0jo2f31j8ymaKoTiLzueWE07jc06BIEcJA7shl3m5vJKPMavb8Xm7WJidfVgT5fQmCvyiBmucdbqN1D74CIt1I9AESvtG69iLhZbeZXTuzE+80/T87zmo+KJczrgauOB7QFLlQAfySiMr9yajG0ZbgLbL/uDDd6+7yRFPHk4O3ARd5QIsdac9+WRifI2xxOn6G69xjoyzcow2qCf/Hb0Vm7CeWBurhtPbaUG6WheWFQ5ryJEjsQ4jtz9AqMny9cHQYsXWtVVuZ8B1MLDon3IluoYCeNqBwQ4zqmN03kQb2ysHll3ddP3/gAy4E60MozZRJjXnknoL+TlsB9S3C6A1Q/AZXigiMo7xJ3OrtZg5312ssptwk2BhJVhWUrIYldDUrh/LL1brB9rjVSv/m5P7HknGkshA4aB9m+IGKbUSP+bHDiNjxlrVZfEgZBitGXt6vH+N199xDp3cFU0mdA8zSDIXzZp66R87S7NxqEcHbpPNMGWdSUrLCko/bYZup7XXlKpp1k19GptCEVqb8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(376002)(346002)(366004)(31686004)(53546011)(6666004)(26005)(6512007)(6506007)(41300700001)(2906002)(83380400001)(15650500001)(478600001)(38100700002)(6486002)(36756003)(66556008)(66946007)(37006003)(54906003)(6636002)(316002)(5660300002)(8676002)(6862004)(66476007)(31696002)(86362001)(8936002)(186003)(4326008)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG4rRERyaFN1WGFTRVhTc2pMa2dVdVMwMlNIWjFNQ010UEFCTk84UmZFcWlm?= =?utf-8?B?azlvZmM5SG1tMjVZK1ozT3NTZVh6NWErYVRNZHJPanljYWRJdThXZjdzeFcv?= =?utf-8?B?dzNwV3dQZDFpL0t5L0lGTEljZEZUYXpTTE5zY1k5REx0dS9GZGhsUXordDhC?= =?utf-8?B?NmQrY0JYM3I4RTdpZGUyejY4UmFXbVp0ZHhQdkUxWHRaT2U5WGdkQlpydEJR?= =?utf-8?B?RWg1MFlLV3k2SzhUVDdQR1NoTG1aN1ZxU0tpL00zdjhvc0wwQkJVb1pLQTkx?= =?utf-8?B?M2RsTGZ6Qytzd0NjbkViRVZFbmFRcXA5Y1A4aWtER3g4Y3ZibnExVHJmaHNi?= =?utf-8?B?MGViQWFWV3pjTGhzeHpwSWVkcWRjRGRwRW9zVmh4di9hK0dwRU1rWTUxVElI?= =?utf-8?B?UW9TMFI5L2NQb0JWWjduYWhKYWJoWG9Ic09OMnRYK3k2RmVrVnptWjJ0K2hN?= =?utf-8?B?RVliUWhBSWs0RElmVEM1KzFHcGdjbkxmcFJoZUN1R0VBVm1kcDlRcmZBYWFm?= =?utf-8?B?REpjMXIvQXFHWTFhRkZvTjhhWXRodThLVVpjaEdrVHJHdnpoZVJ2eU9jYkVI?= =?utf-8?B?bHl2S3BmcnpRQVMwTUxrTUd2QXAxSW5UYU9zdnM2dUhoMXRZb2ZMMzlWbUtn?= =?utf-8?B?N0ZnV3gvQUlvbzh3TG54K2RaNHRMUkJRVlRRSkUwY1dPTmtmWXBzODJLbHVF?= =?utf-8?B?elh3WEVCcSsyR1pnQzl2cllaTGZrMlVVY1RoRkRyeGE0NDdVamtZM3JWSjBy?= =?utf-8?B?bEpjS1RUNlhXWmRQSEpUV3JaY0U4aS9rUlJMUEJzRVhSc3VvOFVjb3drWUtz?= =?utf-8?B?N0ZaTWR2T1RvRXdySzRzNzh1djQ4TnVNUmljazQ1Q2t5S2FPdXk4dWp3V3Ev?= =?utf-8?B?WGxpRVErbU5SWjcxWkg0c3laa0t1eWZYTXdwUlhBRmxqVU4wVkV4bXdtamZs?= =?utf-8?B?TU5tSjZmM0h4M0dGckRuSjZENUwrc1RWRXRPMEE4TnVxMjQ1SnY4NE9NZTha?= =?utf-8?B?WU9NWVA1QmVHTFdrMzlvOFRBZEs3SWo1dUp0UmF5S05WWUFqNGpOMkZybzdw?= =?utf-8?B?Z2ZqbldlaVk5aGtTMW03eWpQSENmL2xQRUZJYjIxUVdEdWtsdlM3YzZLU09o?= =?utf-8?B?bUpDR0NrUUxiZUUzL1VHbkx3cjd4ZWExWDM5VlBkOWNNOTdkUnhJUzFxMWVm?= =?utf-8?B?MVFTV0p1cWc2dDRzR2hZcjJDeFRPaGRwR2dOZVlqcTk1T2dUTFRuazNxMXVZ?= =?utf-8?B?NzMzU0JFb3JuYlFxR2t1TjFtaXArTndBc2xLS3pRWHdsbEt2ZGtYdXpyQ0th?= =?utf-8?B?dFBob3lCWmZjZlgyeGUyWDVCdFFLcmNuMExRdEs4R2dwa0ZVZDh4MitPWm1W?= =?utf-8?B?dGdyQUpXMW9iNHJjaEJha2lNaEdQSjlpTC9HQVJSaXp4cEYxNElreVEzbTBB?= =?utf-8?B?TEd0WWxXK3FXUERDMzM0Z05rR1hTN3NBRGFPcndGeml0UGxhZXVad1UvU2FL?= =?utf-8?B?MEowZHIwRTZLdUUwMndZdytQMytHUGtkeHJjN2JheGJTQ2VWaEVoZHFHK3pR?= =?utf-8?B?RXA2ZlZkeldGQ25sRmMvRlBuYllvYTFpQS9mQVdWRW5GT0N5Ulp0dVA4d0Rx?= =?utf-8?B?S09Oa2lEWFgvSzU0M010VG5veVZodHdHQXQxTkF3alQ0RmdsVC9OSktscWZ0?= =?utf-8?B?ZWNpQmQ2a0lScGozRHRGRkwydXhBdGN2L21wTlg4Nm1rbldxd1NMR2xOdWta?= =?utf-8?B?UklqSGdjaGpwQWQvVzhmT2psRzVrN2YreFhLZE1Sb0dqNXphNDZYbXZ5NUtF?= =?utf-8?B?d0pPVFRyZVFNQnEwT2ZxMlQ0RTJhNDRHQkcxOXVjc1g5YUFhcnQrZzZTdkk3?= =?utf-8?B?TVUwanZEUDJOcGFwZUFqaTBnY0k3VDRmRUhFSEFJUjhhYTBuUS81RzZtRTBz?= =?utf-8?B?anlQdlVxZWNRL0VVMXdjUzBDOG5qQWxvZzhGQWVZNzZvYk0waHcrcDQyZnB2?= =?utf-8?B?QlJBMWRNR2p5Vlh6RGd2cGRWYVE2MlRhMVFaVFI1Y3F1aFVLU0dQWjlKUkNP?= =?utf-8?B?eW5EYVl5L2FzUHRSZEtwZnNVSmZWVm9OV1BlMTcwcWNrMnlIV1A0eTlsejNS?= =?utf-8?Q?78IwbUFCnqOzqUaPC2Pk1EHSL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d28384f-19fc-4026-39c2-08da901f7f2a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:50:17.9299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XD2ufk48oBKJvARsiZSsZVMDzYyMtJOaPfIvyw3lEXKvhk8svamA15nwbsLkl5urGgAsSTbk27Ni4Hn7y1ts1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3356 On 06.09.2022 14:41, Juergen Gross wrote: > During a suspend/resume cycle timers on all cpus but cpu 0 will be > migrated to cpu 0, as the other cpus are taken down. > > This is problematic in case such a timer is related to a specific vcpu, > as the vcpus are not migrated to another cpu during suspend (migrating > them would break cpupools and core scheduling). > > In order to avoid the problems just try to keep the timers on their > cpus. Only migrate them away in case resume failed. Doing so isn't > problematic, as any vcpu on a cpu not coming back to life would be > migrated away, too. The description fails to make clear what the problem is with a timer which "is related to a specific vcpu". In principle there's no issue with such a timer running on an arbitrary CPU. An example of a case where a problem exists may help. This might then also clarify whether it wouldn't be better to remove such assumptions from the (few?) cases where they are made. Plus this might then also clarify why this appears to be a credit1-specific issue. Also to me "just try to keep" reads like "best effort", which isn't what the patch does. I'd like to suggest to drop "just try to" and maybe further insert "CPU" before "resume". As to this not being a problem - if there are assumptions on the CPU a timer runs on, why would this not be the case after resume? Timers are migrated to random CPUs, and hence it's not very likely that the vCPU would end up on the same CPU the timer was migrated to. IOW to me it looks as if this would work only if _all_ APs failed to come back up, and the system would continue with just the BSP. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400127.641769 (Exim 4.92) (envelope-from ) id 1oVgHn-0007Z7-7V; Tue, 06 Sep 2022 21:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400127.641769; Tue, 06 Sep 2022 21:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHn-0007Yu-1K; Tue, 06 Sep 2022 21:39:11 +0000 Received: by outflank-mailman (input) for mailman id 400127; Tue, 06 Sep 2022 21:39:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHA-0000Cs-4I for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2087.outbound.protection.outlook.com [40.107.21.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 139e8272-2dd6-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 13:21:39 +0200 (CEST) Received: from AM5PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:206:1::28) by AS8PR08MB6677.eurprd08.prod.outlook.com (2603:10a6:20b:39a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Tue, 6 Sep 2022 11:21:27 +0000 Received: from VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::b2) by AM5PR04CA0015.outlook.office365.com (2603:10a6:206:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 11:21:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT047.mail.protection.outlook.com (10.152.19.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 11:21:26 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 06 Sep 2022 11:21:26 +0000 Received: from 478a74f64546.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24A74AD9-070C-4590-9DF5-BA9DB30B1EA2.1; Tue, 06 Sep 2022 11:21:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 478a74f64546.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 11:21:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7491.eurprd08.prod.outlook.com (2603:10a6:102:2b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 11:21:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 11:21:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 139e8272-2dd6-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HEHekkQnyWMyFop2e3ZmtlRBgyByvtHDYQiuHEsnShM54w6ksCu9XD9tfuFV3JsTXHZC0tWhd9OFupVg8N0sYuX3AWmfB1xWZ0jXH6pMsnuYwW2Wy823GTfblEDfOD+KW+s7KQZ88pU1oQ7J4l3NXYCapCRNqxGH9LWBE6iEvUsJ8e0S7yhe4CPW+2mpzE1nhFi5SUUWdvkGCBQxnzO3xte1v5Zi0E9qPam8rt+jPMwKTUNMU8uAJJ9123TsuwcwBbc2W7po/42jKI72wfLujOQhS+NOekrIj8svqnUOt7UhIPNArrJZLzT++iw+tetZuGUw4FOnHkVXe+tomVs6TQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r1SSNS3eg7SXX1hODtJoNFP6P0KDOOlpSytHYp0jhc0=; b=nFjen6jxxr7H48ZyOkvLJm/Ee2RygKfix55g+MGtMaiHHM2UBR/WFEzjGnVY8bfNml5J9hjR3vXpFHgKETHE/gSMgGlLMWsVlRr86CCRZNn2xX6BjeVbpoP+rz+DPn+WNCawuhbjGzJfal/j54pQPTdC+Kewv5+ksEWOsWvy+1gvVZlI0X66UVC7xO8SaU0yV+yV3Zjn2BTOAEcarynf3faAK5rKc3DHtiWq8dsAtZFtQFH6EwSbCfU/GqkOgNdCEndOKz74lvPeRqWteTpCcWmdrLNEdzJptBwxta9Eld1tu66UbqlYr7eiYgk52KP0NFuyFsewHraAE4+yGFrjKw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1SSNS3eg7SXX1hODtJoNFP6P0KDOOlpSytHYp0jhc0=; b=aFnbO1fhH027Ynm9UBrdyKUMQ6nIkKOiLlTnH0gag4uUeFjX3Obe2zqukmbaeAHp10y4KKj+gU8YqpjOsBE4Kav60SP3UjPpFiPpECvsmtaEr2GiGcwJTB2wMl/CgV7zIKAOuiQq5Abt5IrOtrosGt78BYq3peKb6pfuapwCjZg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ps3QuBWg9Z3ZzvV9gYOWf73ZNxisbyNA7soXWh++S/RAI+cAML/dq+1XouhS4J/HOHCAxr6hWbUYV5uSGG8aElMnhLxRHne37G0sHUOOuStxERXHU/OatKY9uBSYALRWwEwHMGPOK0gUSMlQn1MPPv7aSD6uAJg71b1UwbQBszp/vZkKDdAOksVT/rGTr5sUs9SJPFAq3K1kH/+J3RgrjMh1PZITuDiVwFR1RYAwMYTspE81IIJ5gBGEN6VzQfq9/kYzdpBfIvSOVXSEIi6pNr/2mf7jblPdlAMppj1/an0bROLxo77ztxvQKt00gRO9Crfoz2Kggml7YJwLDeNBXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r1SSNS3eg7SXX1hODtJoNFP6P0KDOOlpSytHYp0jhc0=; b=gHyx66Uak4u8FvFKaJtl7hSpoEEIrRlpvQLiwSw0oceXlJrjo1+0aPY/gGHPa96WhJQX79yeO4xj4E4dqZeAcfXqs2G8qaMAb90LeM2tf8n50Pqb95QhtnY+QMAeOpYPNm6XJMUby0i02NR1Ax1uYnXoSNpodzm1SL1k7j4cFyX3Go68tHr17AmZJJr9V2sqjtFcvI8mzjW5MUb+BylInw0ZT3czM4rVCoXOX12Qjw3s+g0JtHNZ5MQvokftDdgLE0r7yHKCCJOcCBeAgy2y1GuaIRvDHVTwXd9YupKQ2mY1AXrK6ZGdiSLa+GX2TW+df7MXA8LlrR3O0qI4uv4Llg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1SSNS3eg7SXX1hODtJoNFP6P0KDOOlpSytHYp0jhc0=; b=aFnbO1fhH027Ynm9UBrdyKUMQ6nIkKOiLlTnH0gag4uUeFjX3Obe2zqukmbaeAHp10y4KKj+gU8YqpjOsBE4Kav60SP3UjPpFiPpECvsmtaEr2GiGcwJTB2wMl/CgV7zIKAOuiQq5Abt5IrOtrosGt78BYq3peKb6pfuapwCjZg= From: Henry Wang To: Jan Beulich CC: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" Subject: RE: Xen 4.17 release: Current status before the feature freeze Thread-Topic: Xen 4.17 release: Current status before the feature freeze Thread-Index: AdjA2VmJ6EcVoZ5cTOOgVSRHep4cQABAa48AAAGq5sA= Date: Tue, 6 Sep 2022 11:21:13 +0000 Message-ID: References: <3ff2be60-0a25-638d-53ce-bb7d861c0a9f@suse.com> In-Reply-To: <3ff2be60-0a25-638d-53ce-bb7d861c0a9f@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5E96B3AF57AD0B4EAC4D5AA659E74DF4.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1c0281f8-b4e7-46a3-de84-08da8ff9f085 x-ms-traffictypediagnostic: PAXPR08MB7491:EE_|VE1EUR03FT047:EE_|AS8PR08MB6677:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CB2quD2MZeMcduzY9C52PdY5mpW52g9N63+MbTopPe3aenbhRfFmTLRtXNwYS0B+7ZL/nu5u3VUEGTIx8fdVJxci8FiJcbUWhg59x905aCrN0dmrSoyF2kz3eGX5vMFZVjIOsBWFCLjUAK6MTW4axguz3Q0goxnKg1b8ixs5yHQTpP5SbJgNDi4/O2Gu+uFTv3HE7qOzjHg1KzPG8y+BO0dgUx4Dek/3XFd66Y48aKuKc6yHuwzLOEd+F6rDBja85pQLONyggD/SJfxdqfIIYySC4vLXmuunU/VILbngMZRs1gbV0k8xIdIcHMruVYHpaH2+drpXbAQJbdhbCHOz9xDpSZjgg99VEhBiKbkNH1g+kr/eIWvrTayETqkPmKvWOXpEbv+70JtTisashs+zdQgVhWqQE14r0nk+r3CIaeDgbfOS5NQrz5on7vzTW8mblwiio5H14240cEL/WpmJkLegbbfqRFUxZHtaeGoq43QflCRZmuopKWeVBqLNokPzPY8RaJy3si9X16FQ1qMSdrziW6yyYgyAOZVe+REQVBsIfDytW6yEXXAy59iPACJtpEfqUQni8FIVcCo80wallve3HydJ4J5+7jhg0yDBk1kSDdXsMPVOUOs71twobocY8ANNflj3ykyLlUMu7iJkDKmsKl+FGWGEXtZB3q3as1tfXZdiPTYv6bo9sBOEUtJ2SVvJhzKwWEfXDrMuGfpUrcpZ9zHIHsGnqWEED7fh/RDjExAnU+ukLTy8Hs1Hrlv5dlbvrizHKFbT+op6j+DBB879ctl8byfWn9iG7DliKABMqpICxI3cpRBfaIZzeiq+jHyhe1PeSLVIjdFe/jRvGw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(6506007)(7696005)(53546011)(966005)(6916009)(41300700001)(316002)(71200400001)(54906003)(478600001)(26005)(86362001)(9686003)(38100700002)(122000001)(83380400001)(38070700005)(186003)(55016003)(2906002)(33656002)(52536014)(5660300002)(7416002)(4326008)(8936002)(66556008)(76116006)(66476007)(8676002)(66946007)(66446008)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7491 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1f50d413-a88e-4651-b3ed-08da8ff9e83f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LuQG3xYN7ozjEYFv4ADtVAcMWa0l3lZ+5Na0bfyyd46RF2QCCqAOyEsJaUIgWd8PlPo28JLved0jrYNj6rSfyk3KuqlKXxVglZhCEchd4MGaAka1X5TUlp4EYmQlJYYvSo/ISvqLKIW/ZvWppqYHzJshluvpWbGX9vut9LxWf9Yu2rrOD7HKlTsBjWGRwxxJdRvtJJ7qZDLiBjhOPOedSFJcpSMSbajN7XfNcyZ31W1jQQKKCvrv4THlzouUO4OSuHOOxxXuuzNkHyqIrUn51c3c7PAUTdgRSapSgag7in17E7wDVbUlHw2KReXKqciAj6cDrKC7gjExP/93trO/wKwEIOHNNxMAkVd1dBOdw1yAL28ugJfiMHH02O06kwUyflKw9nOniXEc2TH1erLB9zBxSa4ic6AVKa3iywkjfqSjCrnseHZAgF84AacyBs1Tu/OFhHLxEOqOGHERTHR86E5u1XkYOIOa96nwkTS7DtnzoYD1AeHCJK8ZUJBcPE9t5XNYNi4iHsSZEsPtkNMek2jSB4GvVlADlN9qQ8V5L6INjo1mj4G7/rnvPpJe9kvNkh+qBLkLooAffTOQ/4+E+saUTCZEARaJoMqn8TkftE8Bd7MUyKyyUvQydLHoLYjISHeUBI4iTCdT6wsA493LnHoMes4g/0OokNSqTAWhDJAyOwYeXKQ+4YPntQGrBjRMJxJA8e9fm4H2pMyMrZa4JueWWDCaDpC95zsXaI94o1e52bydMlK5otNx/s5xvSxr3uqfamWqwkVej+69aFV1thkfAqQhIlh80+oPn2UnWlhdXIProh3WGUWlE3mrnzZrom5AU2e5cJIDGf14ByJT7UGE4LJodrNeL4foBLIGtV8NVWHWQRogKN8MLzhM/eyilsAm8dPBMHF5ik1Tdh9HWw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(39860400002)(396003)(40470700004)(36840700001)(46966006)(8936002)(5660300002)(36860700001)(33656002)(6862004)(2906002)(55016003)(52536014)(83380400001)(8676002)(40460700003)(82740400003)(40480700001)(70206006)(70586007)(4326008)(316002)(54906003)(86362001)(82310400005)(47076005)(81166007)(336012)(6506007)(26005)(186003)(356005)(9686003)(41300700001)(7696005)(53546011)(478600001)(966005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 11:21:26.9874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0281f8-b4e7-46a3-de84-08da8ff9f085 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6677 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFhlbiA0LjE3IHJlbGVhc2U6 IEN1cnJlbnQgc3RhdHVzIGJlZm9yZSB0aGUgZmVhdHVyZSBmcmVlemUNCj4gDQo+IE9uIDA1LjA5 LjIwMjIgMDU6NDQsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4gKiogeDg2ICoqOg0KPiA+IDEuIFt2 Ml0geDg2OiBzaG93X2h2bV9zdGFjaygpIHJlcXVpcmVzIGVuYWJsZWQgaW50ZXJydXB0cw0KPiA+ IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC94ZW4tZGV2ZWwvbGlzdC8/c2Vy aWVzPTY2NzExNA0KPiA+IFN0YXR1czogTmVlZCByZXZpZXdzLg0KPiANCj4gSWYgSSdtIG5vdCBt aXN0YWtlbiB0aGlzIGlzIHRoZSBzYW1lIGFzIGJsb2NrZXIgbGlzdCBpdGVtIDEuIFRoZSB0aXRs ZQ0KPiBoYXMgY2hhbmdlZCBpbiB2Mi4NCg0KT2ggdGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlv bi4NCg0KPiANCj4gPiA0LiBJbnRlbCBIYXJkd2FyZSBQLVN0YXRlcyAoSFdQKSBzdXBwb3J0DQo+ ID4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9saXN0Lz9z ZXJpZXM9NjY2NjkwDQo+ID4gU3RhdHVzOiBOZWVkIHJldmlld3MuDQo+IA0KPiBUbyBiZSBob25l c3QgSSBkb24ndCBleHBlY3QgdGhpcyB0byBtYWtlIDQuMTcsIHVubGVzcyBzdWRkZW5seSBuZXcN Cj4gcmV2aWV3IGJhbmR3aWR0aCBhcHBlYXJzIG91dCBvZiBub3doZXJlLg0KDQpJIGFncmVlLCBp biBmYWN0IEkgbmVlZCBzdWNoIGluZm9ybWF0aW9uIHRvIG1ha2Ugc3VyZSBJIGFtIHRyYWNraW5n IHRoZQ0KY29ycmVjdCB4ODYgc2VyaWVzIGZvciB0aGUgcmVsZWFzZSwgYXMgSSBwZXJzb25hbGx5 IGhhdmUgdGhlIGlkZWEgZm9yIEFybQ0KYnV0IG5vdCB4ODYuIFRoYW5rcyBmb3IgdGhlIGlucHV0 Lg0KDQo+IA0KPiA+ICoqIHRvb2xzdGFjayAqKjoNCj4gPlsuLi5dDQo+ID4gOC4gYWNwaTogQWRk IFRQTTIgaW50ZXJmYWNlIGRlZmluaXRpb24gYW5kIG1ha2UgdGhlIFRQTSB2ZXJzaW9uDQo+IGNv bmZpZ3VyYWJsZS4NCj4gPiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVu LWRldmVsL2xpc3QvP3Nlcmllcz02NzI1ODgNCj4gPiBTdGF0dXM6IE5lZWQgYWN0aW9uIGZyb20g YXV0aG9yLg0KPiANCj4gRGlkbid0IHRoaXMgY29tZSBxdWl0ZSBhIGJpdCB0b28gbGF0ZSB0byBi ZSBlbGlnaWJsZSBmb3IgNC4xNz8gT3IgaGFzDQo+IHRoZXJlIGJlZW4gYW4gZXhjZXB0aW9uIGFn cmVlZCB1cG9uIGJlaGluZCB0aGUgc2NlbmVzPw0KDQpTYW1lIGhlcmUsIGFzIGl0IGlzIHF1aXRl IGxhdGUgc28gdGhpcyBzZXJpZXMgcHJvYmFibHkgaXMgbm90IGVsaWdpYmxlIGZvciA0LjE3Lg0K DQo+IA0KPiA+IDkuIFVzZSBkaXJlY3QgSS9PIGZvciBsb29wIGRldmljZXMNCj4gPiBodHRwczov L3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL2xpc3QvP3Nlcmllcz02Njg1 MzcNCj4gPiBTdGF0dXM6IE5lZWQgaW5wdXRzIGZyb20gcmV2aWV3ZXIvbWFpbnRhaW5lci4NCj4g DQo+IEFpdWkgdGhpcyBuZWVkcyBhIHYyLg0KDQpPaywgYW5kIHNhbWUgZm9yIC4uLg0KDQo+IA0K PiA+ICoqIFhTTSAqKjoNCj4gPiAxLiBbdjEyXSB4c206IHJlZmFjdG9yIGZsYXNrIHNpZCBhbGxv YyBhbmQgZG9tYWluIGNoZWNrDQo+ID4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9q ZWN0L3hlbi1kZXZlbC9saXN0Lz9zZXJpZXM9NjY2MzAyDQo+ID4gU3RhdHVzOiBOZWVkIHJldmll dy4NCj4gDQo+IE15IGNvbmNsdXNpb24gZnJvbSB0aGUgdjEyIGRpc2N1c3Npb24gd2FzIHRoYXQg YSB2MTMgd291bGQgYXBwZWFyLg0KDQouLi5oZXJlLg0KDQo+IA0KPiA+ICoqIGRyaXZlcnMgKio6 DQo+ID4gMS4gQWRkIFh1ZSAtIGNvbnNvbGUgb3ZlciBVU0IgMyBEZWJ1ZyBDYXBhYmlsaXR5DQo+ ID4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9saXN0Lz9z ZXJpZXM9NjczNjMwDQo+ID4gU3RhdHVzOiBOZWVkIHJldmlld3MgZm9yICMxICMyICM0ICM5ICMx MA0KPiA+DQo+ID4gMi4gUENJOiBhdm9pZCBib2d1cyBjYWxscyB0byBnZXRfcHNlZygpDQo+ID4g aHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9saXN0Lz9zZXJp ZXM9NjY2MzIyDQo+ID4gU3RhdHVzOiBJIGFtIG5vdCBzdXJlIGlmIHRoaXMgaXMgc3VwZXJzZWRl ZCBieQ0KPiA+IFBDSTogcmUtd29yayBwY2lfZ2V0X3BkZXYoKSBhbmQgZnJpZW5kcywgaWYgc28g cGxlYXNlIGlnbm9yZSB0aGlzLg0KPiANCj4gWWVzLCB0aGF0IG9uZSB3YXMgc3VwZXJzZWRlZC4N Cg0KVGhhbmtzIGZvciB0aGUgY29uZmlybWF0aW9uLg0KDQo+IA0KPiA+ICoqIENvbW1vbiAqKjoN Cj4gPiAxLiB4ZW46IGFkZCBsYXRlIGluaXQgY2FsbCBpbiBzdGFydF94ZW4NCj4gPiBodHRwczov L3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL2xpc3QvP3Nlcmllcz02NjQ5 NjMNCj4gPiBTdGF0dXM6IE5lZWQgYWN0aW9ucyBmcm9tIGF1dGhvci4NCj4gDQo+IFdhc24ndCB0 aGF0IHBhdGNoIGVmZmVjdGl2ZWx5IHdpdGhkcmF3bj8NCg0KWWVhaCB0aGUgYXV0aG9yIG1lbnRp b25lZCBoZSB3b3VsZCBtYWtlIGEgbmV3IHRocmVhZCBpZiBoZSBjYW4gaW1wcm92ZQ0KdGhlIHBh dGNoZXMsIHRoYXQncyB3aHkgdGhlIHN0YXR1cy4gQnV0IEkgdGhpbmsgaW4gYW55IGNhc2UgdGhp cyBpcyB0b28gbGF0ZQ0KZm9yIHRoZSByZWxlYXNlLg0KDQo+IA0KPiA+IDIuIHhlbi93YWl0OiBJ bXByb3ZlbWVudHMNCj4gPiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVu LWRldmVsL2xpc3QvP3Nlcmllcz02NjA1NjUNCj4gPiBTdGF0dXM6IE5lZWQgcmV2aWV3cyBmb3Ig cGF0Y2ggIzQgIzUuDQo+IA0KPiBSZXZpZXdzIHdlcmUgZG9uZSwgYW5kIChwZXJoYXBzIGluZGlj YXRlZCBvbmx5IG9uIGlyYykgdGhlc2UgbGFzdCB0d28NCj4gdGhlbiB3ZXJlIHdpdGhkcmF3biBp aXJjLg0KDQpPaCB0aGUgSVJDLCBvayB0aGVuIEkgdGhpbmsgd2UgYXJlIGFsbCBkb25lIGhlcmUu DQoNCj4gDQo+ID4gOS4gTWFrZSBYRU5fRldfRUZJX01FTV9JTkZPIGVhc2llciB0byB1c2UNCj4g PiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL2xpc3QvP3Nl cmllcz02NzA4MTINCj4gPiBTdGF0dXM6IE5lZWQgY29uZmlybWF0aW9uIGZyb20gbWFpbnRhaW5l cg0KPiANCj4gQ29uZmlybWF0aW9uIGZyb20gbWFpbnRhaW5lcj8NCg0KSSB0aGluayB5b3UganVz dCBkaWQgdGhlIHJlcGx5IHRvIHRoZSBhdXRob3IgYWJvdXQgdGhlIGxhc3QgcXVlc3Rpb24gdG9k YXkuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400138.641780 (Exim 4.92) (envelope-from ) id 1oVgHq-000825-Sp; Tue, 06 Sep 2022 21:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400138.641780; Tue, 06 Sep 2022 21:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHq-00081N-JJ; Tue, 06 Sep 2022 21:39:14 +0000 Received: by outflank-mailman (input) for mailman id 400138; Tue, 06 Sep 2022 21:39:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHG-0000Cs-5N for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:38 +0000 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [2607:f8b0:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a9f8d7d-2df7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:19:26 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id o126so2695771pfb.6 for ; Tue, 06 Sep 2022 08:19:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a9f8d7d-2df7-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=XWFZ4vpQXZV3nrlkQj2xV+OEMAM0JTmWSZ9iqG0RFzM=; b=tuEY+cBXOGTWnnKi0v2V50lRBvidObSqy8a28X+SQ5zwCK8JJEFavk/Z/NcWwMRAUt tZKhO07uOtxBe8QQo9q8R6pfgtZFSikbotcz9pr1LufvWVUcAy9HmDypTZA0TblKCXe1 knDMC8P4/KKlhMBiz4khWgZKQaQfPoE+SSSsGaj8uQzbSKFM7TOPWofZbuPM0BTyxsPu Udrk+mXataxHYELqkPvnLzj06d3cRR8NsfbF3T2SuOIabvPA6oz+j/q8lLU1drBFkeo3 ttUw3+x8DePE9kPXgP/9XVXA2pbcTNhT/ub6DrLVweRIuXsI8l60v+kyEwFki93bDyLU xgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=XWFZ4vpQXZV3nrlkQj2xV+OEMAM0JTmWSZ9iqG0RFzM=; b=qWTDMhfOS7QF+FRvD6eAGhBp7ghbeL4wDkvJnzxANnZYJbKb8Sxf93p8UMF0AyRv9l w+FTdI2eczMgcIMQYJ/eJN7LeMJIuZN8hmUuZoQjtu+6qw4szJ2SXrC93JxYpe/CjIrd pKodkbqlaZzr0wctkZKcDZO3tETJeKkT6zIwRPn5HYbjaLGzMUO1RjC2LPZ9XIuCpfa0 RvnBON23aMp2qcMV0MZ6nDIW8Rd19OFMaS3AGvh80zJurh4WUAlaJqAKsHcIx8kp3qjT q5BOQ3L0NGQYKo8KmT/CJWbRVj3ixpuKsNoffvCv6uGYxlBo0VYeWnR0iZLa1mk0tFPP fqlQ== X-Gm-Message-State: ACgBeo2UV8zFuCJKyF40Gev9BCrFb8ACP9o5gG678ysGrtvdMtjhNP5w /7PcfG9dctQ1cvmQ8H+fPJqa82Z57A+mTeWrZwra4A== X-Google-Smtp-Source: AA6agR5giouvQtvY8QQNPBjopg3XanTewoWbTfcX4JBOo1MdYfK6cJRXpBDlqkeJeMFaQso6UIk48fKNDA4zrFNmR+A= X-Received: by 2002:a63:1a23:0:b0:434:4395:8b5a with SMTP id a35-20020a631a23000000b0043443958b5amr9763601pga.428.1662477564378; Tue, 06 Sep 2022 08:19:24 -0700 (PDT) MIME-Version: 1.0 References: <20220818105601.1896082-1-jens.wiklander@linaro.org> <20220818105601.1896082-4-jens.wiklander@linaro.org> <057e2a04-545f-0de8-1d42-8b19ae19f009@xen.org> In-Reply-To: <057e2a04-545f-0de8-1d42-8b19ae19f009@xen.org> From: Jens Wiklander Date: Tue, 6 Sep 2022 17:19:13 +0200 Message-ID: Subject: Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu Content-Type: text/plain; charset="UTF-8" Hi Julien, On Tue, Sep 6, 2022 at 12:25 AM Julien Grall wrote: > > Hi Jens, > > More remarks. > > On 18/08/2022 11:55, Jens Wiklander wrote: > > +/* Negotiated FF-A version to use with the SPMC */ > > +static uint32_t ffa_version __read_mostly; > > NIT: if this is not meant to be modified after boot, then I would > suggest to use __ro_after_init. This was introduced recently and will > prevent the variable to be modified after boot. Thanks, I'll update > > + > > +static bool ffa_get_version(uint32_t *vers) > > This is not __init. Is this going to be called at runtime by a domain? > If yes... Correct. > > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_VERSION, > > + .a1 = FFA_MY_VERSION, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > > + { > > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > > ... this wants to be a XENLOG_G_ERR to rate limited it. XENLOG_ERR is > not by default and will allow a domain to spam Xen console. > > A rule of thumb is any code reachable for a domain (other than dom0) > should use XENLOG_G_* when printing or gprintk(XENLOG_*, ) if you want > to print the domain ID and ratelimit. Note that the latter doesn't > require the G_* becauce it will add it automatically. Thanks for the explanation, I'll update accordingly. > > > + return false; > > + } > > + > > + *vers = resp.a0; > > + > > + return true; > > +} > > + > > +static u16 get_vm_id(const struct domain *d) > > +{ > > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > > + return d->domain_id + 1; > > +} > > + > > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > > + register_t v2, register_t v3, register_t v4, register_t v5, > > + register_t v6, register_t v7) > > +{ > > + set_user_reg(regs, 0, v0); > > + set_user_reg(regs, 1, v1); > > + set_user_reg(regs, 2, v2); > > + set_user_reg(regs, 3, v3); > > + set_user_reg(regs, 4, v4); > > + set_user_reg(regs, 5, v5); > > + set_user_reg(regs, 6, v6); > > + set_user_reg(regs, 7, v7); > > +} > > + > > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > > + uint32_t w3) > > +{ > > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > > +} > > + > > +static void handle_version(struct cpu_user_regs *regs) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t vers = get_user_reg(regs, 1); > > + > > + if ( vers < FFA_VERSION_1_1 ) > > + vers = FFA_VERSION_1_0; > > + else > > + vers = FFA_VERSION_1_1; > > + > > + ctx->guest_vers = vers; > > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > > +} > > + > > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + if ( !ctx ) > > + return false; > > + > > + switch ( fid ) > > + { > > + case FFA_VERSION: > > + handle_version(regs); > > + return true; > > + case FFA_ID_GET: > > + set_regs_success(regs, get_vm_id(d), 0); > > + return true; > > + > > + default: > > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); > > This one definitely want to be a XENLOG_G_ERR. But I would use > gprintk(XENLOG_ERR, ). I'll update. Again, thanks for the review. Cheers, Jens > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400142.641789 (Exim 4.92) (envelope-from ) id 1oVgHs-0008Ni-4L; Tue, 06 Sep 2022 21:39:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400142.641789; Tue, 06 Sep 2022 21:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHr-0008MW-Ux; Tue, 06 Sep 2022 21:39:15 +0000 Received: by outflank-mailman (input) for mailman id 400142; Tue, 06 Sep 2022 21:39:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGA-0000Cs-JT for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5eee24f9-2e00-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:24:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5EA6614A7; Tue, 6 Sep 2022 16:24:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6D5CC433C1; Tue, 6 Sep 2022 16:24:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5eee24f9-2e00-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662481463; bh=I9HEnsbD64k69AXnJTEmM71NuSK/jsrCbllGo7OZAcE=; h=From:To:Cc:Subject:Date:From; b=oGNhKoZ23xmRmuMfF5By9jdWcF+k0B2GSVOYstp81XQgpGtsjDdL+emiHg7zYoqMj IflTD2XbgUMEVE/Eq55++YXOFYXbNtIs8Gmh4D6kxh0WCjoFV2wYWFFrXiAIP0sotW sVPNy5kCa//2GRAZX2RitE35UUcpj++7o4GjeAnIO5cfR6zH3DGGR6970lnX1UCQ7G lzKflOjgv6TtMc7FcduohNII9+XludVGhDPdV8Q4YxDYfRfUE0PCsybDCpBZjUn0dx +ZQxwz7p95fO4m4IyNAHH1pMMwsmcNjx3DNhIWXEM4EfoVws9j9iTM1KyjDy5d4N/t udVbnIp9osezw== From: SeongJae Park To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross Subject: [PATCH for-stable-5.10.y] xen-blkfront: Cache feature_persistent value before advertisement Date: Tue, 6 Sep 2022 16:24:14 +0000 Message-Id: <20220906162414.105452-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit commit fe8f65b018effbf473f53af3538d0c1878b8b329 upstream. Xen blkfront advertises its support of the persistent grants feature when it first setting up and when resuming in 'talk_to_blkback()'. Then, blkback reads the advertised value when it connects with blkfront and decides if it will use the persistent grants feature or not, and advertises its decision to blkfront. Blkfront reads the blkback's decision and it also makes the decision for the use of the feature. Commit 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when connect"), however, made the blkfront's read of the parameter for disabling the advertisement, namely 'feature_persistent', to be done when it negotiate, not when advertise. Therefore blkfront advertises without reading the parameter. As the field for caching the parameter value is zero-initialized, it always advertises as the feature is disabled, so that the persistent grants feature becomes always disabled. This commit fixes the issue by making the blkfront does parmeter caching just before the advertisement. Fixes: 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when connect") Cc: # 5.10.x Reported-by: Marek Marczykowski-Górecki Signed-off-by: SeongJae Park Tested-by: Marek Marczykowski-Górecki Reviewed-by: Juergen Gross Link: https://lore.kernel.org/r/20220831165824.94815-4-sj@kernel.org Signed-off-by: Juergen Gross --- This patch is a manual backport of the upstream commit on the 5.10.y kernel. Please note that this patch can be applied on the latest 5.10.y only after the preceding patch[1] is applied. [1] https://lore.kernel.org/stable/20220906132819.016040100@linuxfoundation.org/ drivers/block/xen-blkfront.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 9d5460f6e0ff..6f33d62331b1 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1852,6 +1852,12 @@ static void free_info(struct blkfront_info *info) kfree(info); } +/* Enable the persistent grants feature. */ +static bool feature_persistent = true; +module_param(feature_persistent, bool, 0644); +MODULE_PARM_DESC(feature_persistent, + "Enables the persistent grants feature"); + /* Common code used when first setting up, and when resuming. */ static int talk_to_blkback(struct xenbus_device *dev, struct blkfront_info *info) @@ -1943,6 +1949,7 @@ static int talk_to_blkback(struct xenbus_device *dev, message = "writing protocol"; goto abort_transaction; } + info->feature_persistent_parm = feature_persistent; err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "%u", info->feature_persistent_parm); if (err) @@ -2019,12 +2026,6 @@ static int negotiate_mq(struct blkfront_info *info) return 0; } -/* Enable the persistent grants feature. */ -static bool feature_persistent = true; -module_param(feature_persistent, bool, 0644); -MODULE_PARM_DESC(feature_persistent, - "Enables the persistent grants feature"); - /** * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffer for communication with the backend, and @@ -2394,7 +2395,6 @@ static void blkfront_gather_backend_features(struct blkfront_info *info) if (xenbus_read_unsigned(info->xbdev->otherend, "feature-discard", 0)) blkfront_setup_discard(info); - info->feature_persistent_parm = feature_persistent; if (info->feature_persistent_parm) info->feature_persistent = !!xenbus_read_unsigned(info->xbdev->otherend, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400144.641800 (Exim 4.92) (envelope-from ) id 1oVgHt-0000Jk-IF; Tue, 06 Sep 2022 21:39:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400144.641800; Tue, 06 Sep 2022 21:39:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHt-0000J2-Bd; Tue, 06 Sep 2022 21:39:17 +0000 Received: by outflank-mailman (input) for mailman id 400144; Tue, 06 Sep 2022 21:39:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgG0-0000Cs-EM for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 52927a1e-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:00:15 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45732139F; Tue, 6 Sep 2022 02:00:25 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A951A3F7B4; Tue, 6 Sep 2022 02:00:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52927a1e-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v7 8/9] xen/arm: enable statically shared memory on Dom0 Date: Tue, 6 Sep 2022 16:59:40 +0800 Message-Id: <20220906085941.944592-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v7 changes: - no change --- v6 change: - no change --- v5 change: - no change --- v4 change: - no change --- v3 change: - no change --- v2 change: - no change --- xen/arch/arm/domain_build.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3b7436030e..29865637ef 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2690,6 +2690,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( res ) + return res; } res = fdt_end_node(kinfo->fdt); @@ -3762,6 +3767,9 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; +#ifdef CONFIG_STATIC_SHM + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); +#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -3796,6 +3804,12 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, &kinfo, chosen); + if ( rc < 0 ) + return rc; +#endif + /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); if ( rc < 0 ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400151.641809 (Exim 4.92) (envelope-from ) id 1oVgHv-0000eY-7j; Tue, 06 Sep 2022 21:39:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400151.641809; Tue, 06 Sep 2022 21:39:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHu-0000dQ-S0; Tue, 06 Sep 2022 21:39:18 +0000 Received: by outflank-mailman (input) for mailman id 400151; Tue, 06 Sep 2022 21:39:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgH2-0000Cs-3O for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:24 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9e51f6b-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:00:51 +0200 (CEST) Received: from AS8PR04CA0058.eurprd04.prod.outlook.com (2603:10a6:20b:312::33) by DBBPR08MB6137.eurprd08.prod.outlook.com (2603:10a6:10:20f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 10:00:50 +0000 Received: from AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::fe) by AS8PR04CA0058.outlook.office365.com (2603:10a6:20b:312::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 10:00:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT055.mail.protection.outlook.com (100.127.141.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 10:00:50 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 06 Sep 2022 10:00:50 +0000 Received: from c34f0b802c65.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 86102521-4DD4-4D27-86DC-C7CAD9EE89B1.1; Tue, 06 Sep 2022 10:00:38 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c34f0b802c65.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 10:00:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB8147.eurprd08.prod.outlook.com (2603:10a6:150:7b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 10:00:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 10:00:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9e51f6b-2dca-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gyxy1pwlk6grGTE7fEwGTkvcXZWJQBlwmhnm5JsC3YsZDI1zmvKN4cZ/MR1yTEcDMYIHkgIc08LuENX0yiTnF+LR/LnYsE4D7etd2hG9T0sbaZJn7T1z1MXzaOITd3cjTRNistifXWMX7p6nbvgCi0eDykrN/rvy2xrtCEKF9nLkmxDvE3Xanrw7agJNEqI8RSFEtG/IlvuQOIdlQY0U6sjrvl8GPOFrOib9E1h7uJi4ti6A3qCDGZAP8e0MMmEdSB3s6Poo7/R1xxsxoFGFEzdynx5cQOENbfHMCG2ZJh4yzImqybGaSwMcE/ruK7f1/RG3mGeIJ+Syn4o9448jkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uqXOBE/4K+xmcwfQerBOpcHweArZqwBUheZmGKsYVuE=; b=Hw2fFRaheSvaacXDRYAVf5ERV9AH7KlAIYgB5bZQL0v/Gftbe/0PdBMTfFuAGIPMKqP4luQILp3r3K3Te6kcNukq1drVYVx7CF03cYnb9BGOMGWaQ4qeadyKqN+0ezIznIVhrwEH4/5SwMqF0TDavOJy7bXVHFVTpMQZ0HEMoqHXjwyuqkgt7JaajjNMhrjWbKm0/EW6rSduJwJZbSm5JVumrxJflWhFD6/gr65fYa1pFxzl6H2Jo9uDru4karOfMLb0YGR3/WwK+yR73jVPGGfI8TYL1QtlkJq7V7FhjlcVTdXuw/z0M/d+3Hkfa6t33Fb4QIkp6IBhy0+hNhVaxg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uqXOBE/4K+xmcwfQerBOpcHweArZqwBUheZmGKsYVuE=; b=Sah+39erY/rmspJu/NKkh+8XlezaOhe2H3TNtOvTYpgNiclnsASKqMwF3K8f3G3OOK/btIIZlUM/HWTjOuz6PwzYJWMWZ00WpHGHlfrgUDZJLVLC8Z5vNoydRejGgX+JS9lNYMoc2BEi/qllssABhfR7QM62BM0DQC63aDBAIso= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9314e1500273893b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mD14zzNVcO2rdA7jO9MdUyAFRtiYlKfesBpdFtnUtqhlR+6A2FrmjrEXQSqdI6CKPHOJ7c/TpVYMk9WFpi9BvhP/62VQmHRomjpnC1cuYe2oSVjAaxmtw71x9q8CckaPPIcbwlAp5RVUBWrX2WRZZ5+8ekUY3Kw4dq/BIyVeLhMPVakf7EDEjtXzWAiWbN41lOilkeFVyB44T6EqxvVyvkvzBgat2TWOA9X7TdlVr3xyRv6Z3X2HxHFblCEkUajJfaGy25VdXhj1KNJnDl6DSYecu7Bnxw12hpB0S9bsJwM21teWBEvSygYi7gWcmQY3CxR5Tmp8p739MM7YzeC1Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uqXOBE/4K+xmcwfQerBOpcHweArZqwBUheZmGKsYVuE=; b=WkwK9fe+Lx1E7mr1e0yRqTuDng80KYjl8FgpK4wPrL7mlfpgruJRQ/Ec14AnS1yT9imbfFK1NI/t3qyYqgDIV+vHniGP5VojA/kHk7pqHxe9nzOIqw0o77ehP/LlPg+2IIQTJVkSINZABUuvsL5z5o/Akiw0simiuCPCbbwWXG7/OO37ACVBw7967KQc8IKvsXXzxvgxZwtnWTecmEou3ClNaWl0w0CxvHCaUu20YRsyYJWFWYFNMulrbnBFmhpa8CgEbK9uE0sSU9Ox/L0hin0eDvyrIA8z4HieYsKD8bZm8YUpiLfa6ESUYqdtCWAlk+nNIBjzMCL1uN3Zbph+dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uqXOBE/4K+xmcwfQerBOpcHweArZqwBUheZmGKsYVuE=; b=Sah+39erY/rmspJu/NKkh+8XlezaOhe2H3TNtOvTYpgNiclnsASKqMwF3K8f3G3OOK/btIIZlUM/HWTjOuz6PwzYJWMWZ00WpHGHlfrgUDZJLVLC8Z5vNoydRejGgX+JS9lNYMoc2BEi/qllssABhfR7QM62BM0DQC63aDBAIso= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , Rahul Singh , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYveOAeMLlOwX5Mka7ZrpAabJW7K3K4ewAgAFZKACAAAQoAIAADY8AgAAHN4CABGESgIAACJcAgAADEoCAAAPFgIAADnWAgAAKUACAAJguAIAAkgwAgAAIbYCAACNQAA== Date: Tue, 6 Sep 2022 10:00:36 +0000 Message-ID: References: <28b9679c-8223-ae71-d629-4ec31a72dcb2@xen.org> <36A408C8-36C5-4A39-80B4-F564445635C7@arm.com> <616b36ec-5a42-cb9a-2131-3aea1bec7c67@xen.org> <46897765-5063-49CE-8A8A-F4DA50570A08@arm.com> <6B0D4F4B-C7CC-4C04-9BA4-71976CAA82C5@arm.com> <1874D575-E3B3-4221-925F-AF71D3EF0289@arm.com> <7bf75eba-f5c5-6c63-5c45-10c5d2d20254@xen.org> In-Reply-To: <7bf75eba-f5c5-6c63-5c45-10c5d2d20254@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d021253b-f14d-49b1-3867-08da8feeadaf x-ms-traffictypediagnostic: GV2PR08MB8147:EE_|AM7EUR03FT055:EE_|DBBPR08MB6137:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KEa5/bUP2BNzMru+WDIK8eZoXfJcWr0Uf/lbyILSfSZ4ij82JLGsgVf/1De2gNzTbVQg0evEY8fhz0mRqgX3VIjeWdPEb9l8sJArl9r45EEgm150iPtwrjZi7VGFPSC4A7kIHlX86i2ogyE6n822+qaUhsiRqUy1t82nw7Ln3/afud8gJDpvxuuhwh5SWbjGKOC+RgEGAivmIKRlFNw7hERhiGLTz2OA++6TPAr3/pIdTyvnWO0WhKBw91aIz1ca+djL4N1KyUfIPBkO4ygYr/LdPhEbTD8/kSWhmcEfheG6SWoZ+uZU1csut1q/p+SAtebW1wmWxRE9rnlO3/dXsPmOP7GRwiCh6StyFxUucH0KQ5R/8HbzGGVU+bR4AHcgx+XksAZXG0QAu3i8iLItS/ynzBsI/nCXSwhre6nnrjIf1HGK+8PnHY1A5JbTlL3HNSiEkzchwOml2ymyG3wl95AUEfOSZYtOsPLmBmUf4A1K9P4MkSH5TRJxHvX9Voik2qZ4Dx187jItTuS1o/xCumjcMBJ7Dnvw6RMUcWWVeLjuVee5d1lhcJ3N0o6R4uRT9zzqvRGx+9GlJEvs13z/KFUGPB4PMKfgPcpZ/WDBaJK5Z419p6M6plHt2Xdgdfflxjs0I8GM3/aYIt8dtYoISnmsXlLDmvf4nLr8N5kHN4M3Ny8J0+0pEOokWu1BuOPTfxacTk9njSE9TeL3/f1TeDorInmVWXM21Qy5JxO7QQilLB2xem5s/w+IGZzKcJewTTMmD/qw/UwtkitG6JRwUthRCfV42qnkgQUUvwPvGos= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(54906003)(2616005)(83380400001)(186003)(6512007)(2906002)(5660300002)(53546011)(41300700001)(6506007)(86362001)(33656002)(36756003)(26005)(71200400001)(8936002)(6486002)(478600001)(38070700005)(38100700002)(122000001)(66946007)(91956017)(76116006)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(316002)(6916009)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <57B67C3FF5FD454981B6E3F11F87FD0A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8147 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ccaf6b2b-190c-43d6-ca85-08da8feea557 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WR7oZitfuctMzNUxv6nJJbvQwrnir/vFWjeCrneJ5hB4I38f71FCkpaxL22WGZ6QTbmDJQEhv9vDU5rU7iV/a4XG6MdccnKRiGWW38vlkzMjPzELR/OON3EQtXzCHsZ8p/DQxahKrJ0b2mJZUjPP8a4r/7KlbMiEy7tqn3EL4PuiqHR2v+2rkEHSFJb3HoY9hFKJVFGwUNiNrNFN2WFavosuJFcBa8bbT6meGUQITa69KOev9/rAdJHHUKV9f4lNl3k539izKmj21CS1FT+xzdXuOBvYl2WyFqFhIw/+2FNUcltNKJqLAWJOHxu0ZBOH/J3+i+WqWVhk3okrfG6TbPGyBWQKK1RMqAWc91AIQmtmO++ClxPBIFl9QYpsJBkARqXWc6FSdifyiHlN/hEVGNVmdGxHDWTnh+jhK97HVl15uziLfTuw2QraAqyL0neozX5UNMV2OxnPvR+SsG+lUKBG8SUCQS9VEATr9BKPKYOVKWH0g2qhrPUEA/VEOdTRftcv8Ux86sJ5pow1gxHPTXxLFi5kB7JjVdP0VcmqCe4ieMmPcuZcF5Cirimqq6wlYbP+Q7nLyfqXqrBQ9RJCbkxuQJ0G//PaStPWkzMkA7gWY93NSbYYfozb7qYzaHtTatzhW1pk4PLHofs7njWPR+TEodHsaxzTfVFyrbupOxAHVBGNecTbNccT6yKUpLKUrNEiRVF6VCCpL+hUlhtNee+0A+QzW0SFG6HLigExbuZJ+i8LdsvF5xELFd36YTgFYSRkYOBg/zFr4Oo7NuLY/w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966006)(36840700001)(40470700004)(82310400005)(47076005)(186003)(2616005)(336012)(107886003)(478600001)(40480700001)(6512007)(6486002)(26005)(41300700001)(86362001)(6506007)(53546011)(81166007)(82740400003)(40460700003)(356005)(316002)(36860700001)(5660300002)(83380400001)(54906003)(33656002)(8936002)(4326008)(8676002)(6862004)(2906002)(70586007)(36756003)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:00:50.4651 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d021253b-f14d-49b1-3867-08da8feeadaf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6137 SGksDQoNCj4gT24gNiBTZXAgMjAyMiwgYXQgMDg6NTQsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgQmVydHJhbmQsDQo+IA0KPiBPbiAwNi8wOS8yMDIyIDA4 OjI0LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+IEkgYWdyZWUgd2l0aCBKdWxpZW46IEkg cHJlZmVyIHRoaXMgcHJvcG9zYWwgY29tcGFyZWQgdG8gdGhlIGVhcmxpZXIgb25lDQo+Pj4gYnkg QmVydHJhbmQgYW5kIFJhaHVsIGJlY2F1c2UgSSB0aGluayBpdCBpcyBhIGxvdCBjbGVhcmVyIGFu ZCAiRU5IQU5DRUQiDQo+Pj4gc2hvdWxkIG1lYW4gZXZlcnl0aGluZy4gQWxzbywgaXQgbWFrZXMg aXQgZWFzaWVyIGZyb20gYSBjb21wYXRpYmlsaXR5DQo+Pj4gcGVyc3BlY3RpdmUgYmVjYXVzZSBp dCBtYXRjaGVzIHRoZSBjdXJyZW50IGRlZmluaXRpb24uDQo+Pj4gDQo+Pj4gQnV0IEkgYWxzbyBh Z3JlZSB3aXRoIEJlcnRyYW5kIHRoYXQgIkJBU0lDIiBkb2Vzbid0IHNvdW5kIG5pY2UuIEkgdGhp bmsNCj4+PiB3ZSBzaG91bGQga2VlcCAiRE9NMExFU1NfRU5IQU5DRUQiIGFuZCAiRE9NMExFU1Nf WEVOU1RPUkUiIGFzIHN1Z2dlc3RlZA0KPj4+IGhlcmUsIGJ1dCByZXBsYWNlICJET00wTEVTU19F TkhBTkNFRF9CQVNJQyIgd2l0aCBzb21ldGhpbmcgYmV0dGVyLiBTb21lDQo+Pj4gaWRlYXM6DQo+ Pj4gDQo+Pj4gLSBET00wTEVTU19FTkhBTkNFRF9MSU1JVEVEDQo+Pj4gLSBET00wTEVTU19FTkhB TkNFRF9NSU5JDQo+PiBQZXJzb25hbGx5IEkgZG8gbm90IGZpbmQgdGhvc2UgbW9yZSBjbGVhciB0 aGVuIEJBU0lDDQo+Pj4gLSBET00wTEVTU19FTkhBTkNFRF9OT19YUw0KPj4gVGhpcyBoYXMgdGhl IHByb2JsZW0gdG8gYmUgdHJ1ZSBub3cgYnV0IHdvdWxkIG5lZWQgcmVuYW1pbmcgaWYgd2UgaW50 cm9kdWNlIGEgZGVmaW5pdGlvbiBmb3IgYW4gb3RoZXIgYml0Lg0KPiANCj4gSW50ZXJuYWwgcmVu YW1pbmcgaXMgbm90IGEgcHJvYmxlbS4NCg0KVGhlbiBsZXTigJlzIGdvIGZvciB0aGlzLg0KDQpD aGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+Pj4gLSBET00wTEVTU19FTkhBTkNFRF9HTlRfRVZUQ0hO DQo+PiBJIHdvdWxkIHZvdGUgZm9yIHRoaXMgb25lIGFzIGl0IGV4cGxpY2l0bHkgc3RhdGUgd2hh dCBpcyBpbiBzbyB0aGUgYml0c2V0IHN5c3RlbSBpcyBldmVuIG1vcmUgbWVhbmluZ2Z1bC4NCj4g DQo+IFRoaXMgd291bGQgYmUgZmluZSBpZiB0aGUgZmxhZyB3ZXJlIGRvaW5nIHdoYXQgaXQgaXMg c3VwcG9zZWQgdG8gZG8gKGkuZSBlbmFibGUgZ3JhbnQtdGFibGUgYW5kIGV2ZW50LWNoYW5uZWwg b25seSkuIEhvd2V2ZXIsIHNvIGZhciwgaXQgd2lsbCBleHBvc2UgYW55IFhlbiBmZWF0dXJlcyBi dXQgWGVuc3RvcmUuIFNvIG9mIHRoZSBmZWF0dXJlcyBhcmUgc3RyaWN0bHkgbm90IG5lY2Vzc2Fy eSBmb3IgdGhlIGdyYW50LXRhYmxlL2V2ZW50LWNoYW5uZWwgc3VwcG9ydCAoZS5nLiBiYWxsb29u aW5nIGZhY2lsaXRpZXMsIHJ1bnN0YXRlLi4uKS4NCj4gDQo+IFRoZSBuYW1lIHdvdWxkIGFsc28g cmVhbGx5IGNvbmZ1c2luZyBpbiB0aGUgZGVmaW5pdGlvbiBvZiBFTkhBTkNFRCAoWEVOU1RPUkUg fCBHTlRfRVZUQ0hOKS4gRG9lcyB0aGlzIG1lYW4gdGhlIGRvbWFpbiBjYW5ub3QgdXNlIHRoZSBy dW5zdGF0ZT8NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCj4gDQoN Cg== From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400162.641824 (Exim 4.92) (envelope-from ) id 1oVgHy-0001Vx-UW; Tue, 06 Sep 2022 21:39:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400162.641824; Tue, 06 Sep 2022 21:39:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHy-0001V8-ML; Tue, 06 Sep 2022 21:39:22 +0000 Received: by outflank-mailman (input) for mailman id 400162; Tue, 06 Sep 2022 21:39:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGz-0000Cs-2U for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c2c3449c-2dfe-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 18:12:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB3147.eurprd04.prod.outlook.com (2603:10a6:7:25::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 16:12:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 16:12:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2c3449c-2dfe-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hcuj8jS0s4Dw2Vl69S4meIqgY+w7HxZAzPOzT7vk69vXF4t1uSfR87zorUMyGGnyrsNUX2KMWBHMNqgqpfMIspSrwooxomfck25ehIkBTwb1JprdddhKoCYoA3JC5jNZiZBtKrEs42Ee6OR6X8fKR2ifghGUuqjjGYVuW/Ol42t8bfWhVJYlUkghUADRSDInfQN/8Jm7zmcdG3mmL4cwE9XTCFAX5G2Qbpt/7THM4LWClNVK4IFD8RQ4I25YhigxB4xtAhbObyYt2YdFR1Wb5KjPYaXU9U7zZIhBiitA5tqPZCw38jGVoktBFYCwPPlDQwp0AiMOet2mg7+xnJPENA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DxuBNvZHj7YoYsRCVtTqWxYiumkKpcJG7SRauKxVqPQ=; b=Nu1afNiAuQQ8r8xzCP5ajjTTz1U+ZKITsxjoxUHb8pwi7J2583gQBUBRKXtjaKEWA+7GgRVIHgshY2S6NlRx+F/pgK1aTf1DsS5lJyKeORIMTx1o+a6qL86MEZtxTA2iH8elSTklfEVzLYZ2rwhqcPjpFQkNiya7Ifkj+tJx72CKSl++0Re/8cuzOly8aVIzV6jX+wLZPAujE+WuMOb6u/eC4+NEBY3xfrN8UMEml58GpMMmKGTTgzZtOxT8QC4niFWRFQbD3fqLEOJmgwVJ5t2A8z1kOAtTAHJA5FfSAAPNfcPMN1JkK8ohcqrtItnG+iCbuLZIEiXT3TevPED9GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DxuBNvZHj7YoYsRCVtTqWxYiumkKpcJG7SRauKxVqPQ=; b=HuqshmxvqDi70hX/CBm4iVGH+cmDqJWb05eYl5Mgsk6iPEL6gimoEyhnafB5yZBpqOthayd1dlPObjlPqrYicL2x99QhSEvykCaOsTcLbLif55jRvebZ/X2c8przMopGhHgyMXKYU/EykYeU0S5D49NE7V/7H7OG/KruaUxd0Kem5a0m5jV8stnd1BlSgi4PAFGjSvzClNUJfdpwB+Q8XG4pcvZJsV7gdG9zg+9p0IPgVIQ2CbHte5o/igKnijGZzEytoEnlvfhpBKgpyDpLajhcMhc+6M0bagGusw3yuxAT16/AVUG/vO99aPye50Bl2HzQDvcwmI3kFY7hi5Q+rQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8d798929-fe9d-287a-8fc3-74fe44d0afb0@suse.com> Date: Tue, 6 Sep 2022 18:12:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org References: <2f7b3495-7963-fa4a-f4c0-5b668238d337@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 397da13b-b9a5-4fef-bae5-08da9022a5c9 X-MS-TrafficTypeDiagnostic: HE1PR04MB3147:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hh9lvYCpC0IqAgpHE5Jjsfi5FKKkmIB5s5D9Vjkp10kT9Fq0YYkgnqGfq+PoWZliOO1jDNgOCY20nmOrqWBAh957W5pYY9FCTY4rzUZjxAo37K+WfIjFuM+WnfM6ktFOAT8C34pYoPFnHB0QNFLtHLcUcZfJYYAwyZe9A6XIDFDrbbSXSRvvdypgJ3kbSp+3HnTAqDB08wLc9ibO3Fej8PfOkWC55ldByG/xZf+R6shM0AgBEoJ6TrMPUCeIrUQSpJbbBeOBQhlGGdRWM4f1IDQydiv88aGU21Ro3ILATXu4E/g3uc5V5yNFe2x6+68pK2XPXDJttbnMKIDlPi89HrRpB1uQpUtkLiO0UOfgQuP5OvKU+ZUKe80DiIU+RD7JM1ZXIHUTC+MsPRTXV+w2QgFj2cFvfQkGz7Xl1kMSpzlE94bqhGozuhjh4ZKZY+xbdYUYlYU5fVxYXtoke8c0gVPtPAVM0OCL9WAAcO7uNPFJpEUH4PwFtogU0s+vRN0aVVyV0f9FZ6Zf8I25u3lkVvG+2v9tL4JYw/0CM4oFnr4+4Ke+bNM21my60OXfG0Fdm6NVFWhxVQ/X+2Rawnq/FCrIeBhc7hrBiXdXBwRfMmrCmnPsk/XSwAIyHdv6q/3FjSmMY/k1WlUeGjOI6ABl7wIIoIQpvBpdwPmf5d27Toeud4h+tW3hSPYEnW5mmVq1otKI3mOJmk3kSIWAAZBWxY0w43LmMRlGK3C/ikVDhOoOmZCO9f9Ww36DDbSPvFry/A6XVQa3W5HwPWwcA7DVZn6x2hgBJR6Gdc6BqZEg9cY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(39860400002)(136003)(346002)(396003)(31686004)(2906002)(186003)(8936002)(4326008)(5660300002)(66946007)(8676002)(66476007)(66556008)(36756003)(316002)(7416002)(6916009)(54906003)(6486002)(6666004)(6506007)(41300700001)(26005)(53546011)(86362001)(31696002)(6512007)(38100700002)(2616005)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekdIT3Yza212U2RtR1lEbFFiM2NkNG9IQnRESFQybDRNOWhVdWI1YWt2bEtw?= =?utf-8?B?TEd1N0RZLzljKytHN0l2c3M3SU5YbUMyU3RHTmF5REtPcUxaNWFwMmRKSEpZ?= =?utf-8?B?U21IS3JkS2JpMWNYK04rLzJtZUNqaGEyZDdqNURZWms4RW5sT3A3VUZoN3FP?= =?utf-8?B?K1BOV2dyYUI4ZmVPSFVUNjZoclZ2ZXBHZEJoV29VNGllbW9pWnZrTUl2NmlS?= =?utf-8?B?cDlQMjVFL3kyWndwMEhmbWUzVFpvVkVUdFJhM3E1bVFBNlRUYzRyeU96eUZR?= =?utf-8?B?WGpyWndTTkxvSms5Y1pydGxkNUZUYVlad1pxN0lpYTFPa2FnQkpGYWRHNThs?= =?utf-8?B?a3AzRU9CaGMvK0tBOTVNbGV3OUVENEdCZGhEdWMweDV3ejRSZXZoYml0K0wr?= =?utf-8?B?R2lUdEFwNjFWa2JGTmYxQVA4dEFkQTZYQ2pLQ3MyN2t0OUJBSXJ0aXR4aUJp?= =?utf-8?B?alRORHlCSEZ0dFVrWXVLRXhsWnNFbXc0WlpxNFcycGM2SE1CTFdIRFhodFpW?= =?utf-8?B?cnkwMkpIVytuQXp6TG9hUjFUTVE5blMwblBpTzhzWmRGNmV4ZG14WnlxUHZB?= =?utf-8?B?R1A2K2JaVTVHbnpNVkN6YXYzRjhFYVoydWNCSVQ0eERtV1U3L3drV2s4TDU0?= =?utf-8?B?SjJpRWFrQzV6My9mN2NvWXZ6UUE5d3RqNnZCOXh3M2x3SmdmNVVJdkJPc2Fm?= =?utf-8?B?OWdJWjVqQk5UM0NKWnQzeVZGK25Nb3RidzVpUUhvc3FiTFNrSUxkTm9PQ2ww?= =?utf-8?B?UTVMeDFzSFkrVDZmQlJWYlBEZEtVaklEZnRibWZ1ZXZ2NkxLb3hhK0JCVFZM?= =?utf-8?B?a1VFZHMxU1g3Wmo0WjFhYTF1WUZ6eWc4WE42T01SNGVpQU9WRWYxM2swaU1I?= =?utf-8?B?ZGYraVh3TFF2d216UlVyRDBMa1dTOFNQTmI1NEM1U3hDaklDS2tGTjFLWDYr?= =?utf-8?B?ejAvY25wZ0NQRStBczZrOTFxczczajhSV2lIaldIL1Q2bldibFNMaElEckty?= =?utf-8?B?amNYSnBjMzVHNjZvdUNXREt2MWJRQWwxQXExMG01SDNPdnpTSERWb29PVHhj?= =?utf-8?B?STlsaVlNUXlvMnN5d1FqdURmczNCME5hNVZHNU1MN0FUU0FQYzVuSlNWY01Y?= =?utf-8?B?dnJHTFBVWFBURWtkYlBtdHVFcUU5dVFTaW1aNEkxdmlYZXd0QTdndW5CREFQ?= =?utf-8?B?NVdWQ2NLQ0lvVjdLUzBVT2xYNkdzV2hRL1FvYkg5MDZHY1p5YXlyRjhsYmxN?= =?utf-8?B?YzZMUHdsaWdMUXFXYTFoYUhIYjlmYmh5NHpTa0VTOWh5STdEVEZFcDA5RUk5?= =?utf-8?B?UXJ0MHdlS29xS2x1Zkd1KzU0SE1ZYUcrRGxyN2h5YlNZLzFUczRDK0RONExl?= =?utf-8?B?cTZnWlBselBNTzlXTnNBaXpVdFJqeUdQUFUxaUxsdzd3OG1PZ3c5RHNqTDYw?= =?utf-8?B?dXNmdTI1czJlZ3VqMDYxL25JRklVR29UbUVZYTRaeUw3WnhOM3l1MTlUMFd3?= =?utf-8?B?ckNVakxocTFBVC96NzlHLzB2ZU5wRGhvd1ZKMnlSTWQ3dDM0emVQME9uMnlt?= =?utf-8?B?eEZEM2xFeXlpcEhCSEhNaWMzRENjMVNLR1dES1BIVnFUa0FpK0psQVlmUlVy?= =?utf-8?B?R3c0TUZCc1ZPMkdNNklDbldUSUhuUnRLaEdCaGdESUVlV1pXc2ovb0dFc0VG?= =?utf-8?B?bHEwQWUydzU3L0oyOEtPOEhhc1VFTFM5Q0hlQmlWWUdKQXdEOHM3RTE5b1hE?= =?utf-8?B?NW9MeXZ1MlhrNHI3LzJrc2E4NllDb25DNmVVOXpQZDZNV0hxei85by9JTW9s?= =?utf-8?B?KzlHWkFySUdheThGKy9LUEE3WU5JcEJZSnNhRjNlVDRCVWdXTC9zbUJJdmRL?= =?utf-8?B?Rk5JR1UxRXgzTnRGenlPR1NwNEhhZzRSYW5EVTlHYW9PbjFRTU1pSEthTjFR?= =?utf-8?B?bXkyckgrRzlSK3lTTHpiWXNjY3NXYitkNmpmQ1ZxZzFnUlV0RElHN0luNk1I?= =?utf-8?B?cDBjMmxRVWc0MTlkbG51bXoreWIwa3ZjNFhpTm1oWitNSityV2xIM0FiTzln?= =?utf-8?B?RlhHZjkvVkRMRmdnMmF2NFpXb3R6K2xZTC9sSEw0SHdqTjJVcjA2dUVTQjFS?= =?utf-8?Q?aX9CUYjvmMYFj02nkticWCbDy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 397da13b-b9a5-4fef-bae5-08da9022a5c9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 16:12:51.2657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DB6dAJ5wA66D6fU5PgEOW+zjX/2y+xOxJsIQpUHjCKBxf7ltU/B7D4SS5hvy3bbNnilovFiiZ+fx2UjvVsyurg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3147 On 06.09.2022 18:05, Marek Marczykowski-Górecki wrote: > On Tue, Sep 06, 2022 at 05:11:24PM +0200, Jan Beulich wrote: >> On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote: >>> Marek Marczykowski-Górecki (10): >>> drivers/char: allow using both dbgp=xhci and dbgp=ehci >>> console: support multiple serial console simultaneously >>> IOMMU: add common API for device reserved memory >>> IOMMU/VT-d: wire common device reserved memory API >>> IOMMU/AMD: wire common device reserved memory API >>> drivers/char: mark DMA buffers as reserved for the XHCI >>> drivers/char: add RX support to the XHCI driver >>> drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC >>> drivers/char: fix handling cable re-plug in XHCI console driver >>> drivers/char: use smp barriers in xhci driver >> >> I wonder in how far it would be possible to commit parts of this series. >> Aiui patches 3-6 belong together (lacking a suitable ack on 4), but are >> independent of 1 and 2. What I can't really tell is whether 7-9 are >> independent of 1-6 and could hence go in. > > 7 share some context with at least patches 1 and 8 (but no functional > dependency), and 9 modifies what 7 adds. But otherwise 7-9 should be > independent of 2-6. Well, if 7-9 don't easily apply on their own, then I guess I'll rather not make an attempt. You may want to consider moving those ahead in v7. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400173.641835 (Exim 4.92) (envelope-from ) id 1oVgI1-0001zP-Gj; Tue, 06 Sep 2022 21:39:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400173.641835; Tue, 06 Sep 2022 21:39:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI1-0001yu-Av; Tue, 06 Sep 2022 21:39:25 +0000 Received: by outflank-mailman (input) for mailman id 400173; Tue, 06 Sep 2022 21:39:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHP-0000Cs-6p for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6c0d7c1-2dbd-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 10:28:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 35DE56135E; Tue, 6 Sep 2022 08:28:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C90BC433D7; Tue, 6 Sep 2022 08:28:12 +0000 (UTC) Received: from [104.132.45.97] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oVTwI-008FyB-Ac; Tue, 06 Sep 2022 09:28:10 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6c0d7c1-2dbd-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662452892; bh=JGDZV4T5KqIUpWXzuAVRjEy6irYKEPX4ILzJnv+kSAE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O1u7vNxwtyMrk58/eS5t9n9L72A9DrfeDXVvWrISnYJav0Xgtjaa0GAJx0oNbBeB8 +g7Z/Q0kpLcyo8zirOOHbegGhjcv/JmI9rbPu89kr8TvKxNwYO48+JHBYWCZ82P6ZE ZABbaxqu7PP6hRNzY75VXZeDu2cs8RFg5l2W+SgBx4PfKpyICzHeYTKh9tcMInGbsE oDLzGMhi7frOnu5nWXNVMmqjEp3gCMFU6pBChBtRCyumTe4PJIcPBlWRTK8DokgNDz NjqBzp9++Y6dN3BD//G/ozx1SIxHPnjZhyaZn5XQOy2bQXJ7evmXEdZQEvyneE7Uc+ yIQNUxgBdpZdA== Date: Tue, 06 Sep 2022 09:28:10 +0100 Message-ID: <87ilm0rjol.wl-maz@kernel.org> From: Marc Zyngier To: Leo Yan Cc: Ard Biesheuvel , Julien Grall , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table In-Reply-To: References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 104.132.45.97 X-SA-Exim-Rcpt-To: leo.yan@linaro.org, ardb@kernel.org, julien@xen.org, jbeulich@suse.com, Bertrand.Marquis@arm.com, Rahul.Singh@arm.com, peter.griffin@linaro.org, xen-devel@lists.xenproject.org, jgrall@amazon.com, mathieu.poirier@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 06 Sep 2022 08:27:47 +0100, Leo Yan wrote: > > On Tue, Sep 06, 2022 at 09:22:00AM +0200, Ard Biesheuvel wrote: > > [...] > > > > IIUC, you consider the general flow from architecture view, so you prefer > > > to ask Xen to implement EFI stub to comply the general flow for EFI > > > booting sequence, right? > > > > > > If the conclusion is to change Xen for support EFI stub, then this > > > would be fine for me and I will hold on and leave Xen developers to work > > > on it. > > > > > > > As I mentioned before, proper EFI boot support in Xen would be nice. > > *However*, I don't think it makes sense to go through all the trouble > > of implementing that just to shut up a warning that doesn't affect Xen > > to begin with. > > Another option is we can set a bit for xen feature, so Linux kernel > can read out the xen feature and make decision if need to reserve > memory for RD tables based on the new feature bit. This is somehow > a solution is to create a general protocol between Xen and Linux kernel. > > How about you think for this? No. If there is such a bit, it has to be in the GIC architecture. I'm not putting anything hypervisor-specific into the GIC driver. Others have tried before you, and they ended up fixing their hypervisor instead. Feel free to talk to ARM to get the architecture updated instead. M. -- Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400181.641846 (Exim 4.92) (envelope-from ) id 1oVgI4-0002Vw-98; Tue, 06 Sep 2022 21:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400181.641846; Tue, 06 Sep 2022 21:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI3-0002SU-T5; Tue, 06 Sep 2022 21:39:27 +0000 Received: by outflank-mailman (input) for mailman id 400181; Tue, 06 Sep 2022 21:39:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGC-0000Cs-AL for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70089.outbound.protection.outlook.com [40.107.7.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a6a3d4c-2dc1-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 10:53:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9201.eurprd04.prod.outlook.com (2603:10a6:102:232::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 08:53:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 08:53:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a6a3d4c-2dc1-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvErLYQQOBZ1sX5nKBS3NXhTFftCGnxNIf+yrLjlvz4rCni6mQRQ9P6VMqdb/rn7ZPN0i2gxYO3BP0qsTVkHfzWMiI7YgrdAS/xJccvlkOJJAvNWMysHrl011EP+DnGXUF2twwm4LVxnwmmgOIbZdV9DrAYhTZBHsLm6yRkKRZoVpTuk2/KjNLtTRq5bWLywdUMp5btxh5MO71zqn2lqCUJ+ckfP56cFMkj39yPmF4vOlAJR/WyJpjEhboaiUxTjebhwVfCJWZs77vud1GwHvzEGBR+XwG7Lm4xjcmaUPRdpY/ZMC3HMl2923lJUdp3GJj27Z+AroZ+CulSfP4UFoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFe3S9fToKmfWXmXNYX7xeWC318ja0UwmItRMLycIc4=; b=mvTonxikV52o+rmA+vgh2sVj0oeRPQTnR7VG53CirGwcrn8fm4e4Zmp5DUhlNy2lql5B2PPU8EHvLXIlmlrHdoT/8LqsfhYECXoSOmNg2HKoTKMQUCQ9qB/irYyEsC97tSNrbFq6Tlr/C4FXHCDEtnl+0pa0tr/utZI0C/Rj75LpWJt0lf/UjP4Oy1qzLG9Kj58N5gf7pdrA5XfTqXjkflBXCF4+nUEGoP1VGJdlbKOYLDS72mGaIZTXcTygDOCapBJD3Y4g1W8+73y7HLMFqCH5XtIPnAOjRniQxPBUvCsxRtnuEsAYnPVyk/wf6vh6XeWjgx+Tlib7F0WD4b8QjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFe3S9fToKmfWXmXNYX7xeWC318ja0UwmItRMLycIc4=; b=oeTiUCOnW+6vxP98ZkPwrpaRlYB5OaaqL3EgWM+2TbyDnID2CQ8J62SwBLwb8WPC7RZpy8qHIWTM7dcuHXAAlM4YR+F0oTLQXu/P5dm/5GW2y9eJcS1CDSWx+tnu8CUL8Gkqzlbc25ja5rYdQS/c0w8PFnXExHfNj0XYB8LqQD+DZdtHUqTpT5DXjGb8OTIzY1vhmqCiVImmIEk/L95zKZAbMeMGOWjk493ABFaY5XZ6U75mNA0ypsyDPco7HpzxlPMUWqaKVu6LMazUjpt8HKmrRryj8T7+QgHSAxnf1lyOOqZTEDR2yg79117HfPmvMnPC4umpjE1u7YBUpAxmIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 10:53:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Rahul Singh References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48d37ba7-b010-4506-a1c6-08da8fe54ff3 X-MS-TrafficTypeDiagnostic: PAXPR04MB9201:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nz+BfkijkhDianvZGoT3Rr0HM1bECrgkKAb1leHHfIscEnlkFZ7muxVWF3jkwD0Ra7ZewEjkk0dBGKkCTCO9KaNzC1Ewd+4tiUvd4eAiiemgHlVdjygqW42Vb1rPLnoTjxtc/eLcD0oUb0SFMWkuteGm228dpeoDZ+iJenZgiadw4hxeZVZHTPJjgTr/jdrWk+Ds0+VfcFtQ2lhcG/2l02SAdZGHDEwdht1Z/ljcsiK3InbcnmLLTx7c4bUChWiEhry00mzb+KgqsLKGqf2kCiIlPn372KgHUUWeSrw5gtvBaTIPcmlwkFaE2QPxaH0shN7wi7PWM1P3jb/qTPiCCcwilyUGeU2jUtHKiTSeNRRQo1bhqcrhCnfLZwCVWOlwe9X4ulBNsL3ULuQazt9YjgCYTqTOBs6YT5i+a+WybW6OrcavCxU/uAQ+JaLPoDHpLPXxJRsApT5ZcXdp9fObxfm777kIqoEueoJw/GBwhrXsNb0Q5lC5b8sN0KlIyQoswyVb6jKaHX3Dmwo1jx6Q98ZknAsUMzf4/FagfDixuakBqVU/IBw1GtfIET7BfmCQHVBDYjBxuvxwYLZcqjAWzWD9tfDbngEoKlnP15RCLT3cOwpJbwdznjeRqxNvN4P1sUHKnzYq6mClchGtwLckdUUbNKkPSxCzQVrkrEjQIsIOhbN7spqKN2Pp48CY05htuH5a9MpklXV+Sl+JyGp9CvQpy91LciDPDcZe20FKcj30lCudHH0uG3H+7+pDXfQmxSbzIEncbqEobCC2XVgxteQA1Vtkg3/deceEhHxr7bA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(136003)(376002)(366004)(346002)(6486002)(38100700002)(66556008)(86362001)(53546011)(6506007)(6512007)(26005)(66946007)(478600001)(316002)(6666004)(41300700001)(54906003)(31696002)(6916009)(66476007)(2906002)(31686004)(186003)(36756003)(5660300002)(8936002)(4326008)(2616005)(8676002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTJPQkJKSUxZQmcydzdHRlFSZHZYVEpFNjZCdGhXZDIyVkdMQVAzWVlZaUVk?= =?utf-8?B?bnM5ZUNlSUJKbzNZd0drUy9SbTBkTkFrZEFocEp4Z0MwbFk1OTlTWDhabjYw?= =?utf-8?B?bGd0VWlJKzVyNVdRdzR6VWsvcitmRHF3d3ZxOW5nUWxWSDhTeVBhK1BYU2tJ?= =?utf-8?B?cERrbXdzU0U2L2V1SlFHSWpRNE1MSFhDT3YvT0NJU1BhQ285YlBnLzFJYzFN?= =?utf-8?B?Q1l2UXhWS3BuKzltcGczcjVhVllXdzk5VC85dHJYNVRpT01TUFZadWdHVGd5?= =?utf-8?B?Z0JwbVoyWlFTVGU1RklpM203OFhRTlV3dS8rZzFKWXBaRjZhN2laRml3eXlP?= =?utf-8?B?RjBVb2kzeEhZRGZ3QUJvZUwyNURWY0dESGJCVFJlblcxS09lT2FORUJvVVlH?= =?utf-8?B?TzB2M2puRDZ3MWhuOW9uNXd4NlExTkxreGZWcTBGQ0lGMUplYitseUh1N2Vr?= =?utf-8?B?L0YrQ280bUhNSVVxUDJnb2c0UytoQzBiYWhqQjdwNmZuNHhGdElSTzRXcTI5?= =?utf-8?B?ZVF0TU8vLzlDQ1c1U2FlUm9ENkg5NUNSWlRlZUFpTVZJUzgxUDhaa3p2eko3?= =?utf-8?B?dzVnRlhDQW9aV25kOXhVNWptZ0FqS1BLSkUyQW5aY3N3Ti9HQlM5biszVVA3?= =?utf-8?B?YVlvM0ZxWXdpeWRRbHVmWStBYnU3VUhDQTdwSzR5U3BUMmdDL05ROWVNNmsx?= =?utf-8?B?TVRsTFhETEppeFZTTWVRc2trREFyTXVXUXVKTlpQWFFOYnZHLy9VZ0JiUFlO?= =?utf-8?B?ZmlFejJNcnh6d2RxWVM1MnFJT21ESnJLN0drN2RLaVdhb2Jha1h1RytmSWNY?= =?utf-8?B?ZU9JcUVkSWFON2hWTmFrbkhGRm9FSEIvSnBDcE9GcWlRMkNudXVIYXIvL1hD?= =?utf-8?B?amNlZXh2S001TWlSMVo3c3ZhU01scFRFTEdFVHNhMzlSMWk4N3NSamc0L3R3?= =?utf-8?B?QUtDS3lRN1ZETHBtYmZKWnA3NHRoZ3RaQktuWEVDb0NIQWVISllxTTdwb0RQ?= =?utf-8?B?TFZFUUwwc0xzZUxqVGFveitsSm9JRjhnOU5SVXlvaDhUYzVCT0g5bWFNRGdE?= =?utf-8?B?cHFVUzQyR0lFR0J1MUVHNlJNNFpPRjFTbDdUYkVkMHlrZFFVSkcvcGxnb1U2?= =?utf-8?B?c1Fsc1FMS2UrdDE4NWgwV0J3akN0bkdQS0wvUlRZVFhkbXQrcDRLZWx5ZFFC?= =?utf-8?B?ZTl2c0ZkOFhYcm5hK1NtS0ZKRGRXeTh6THpSQzJoY1pONklxaExzOStmZnhy?= =?utf-8?B?ODllVVJkOStaTGUyMzUxR0V4WUlZNmJXbzFYUEhBK1NXL3BrMTdJME85ZitW?= =?utf-8?B?YWMvWnhScE02WWFmTnJmci9Jc2g2RUV3US94U21KcEE1NENZRC9kWmJ4c2o0?= =?utf-8?B?QWw2TDQ1cG1aOHg3QWY5SUlrekxRWk00Q1pUZ1lVa0dHZDZyZFNoTnprcDVT?= =?utf-8?B?YmQxUGt6RzJ1L3VpWHdNeFpPbEtOL2xRTmlLM0gvdncrMCt2bDlPVkJQaW01?= =?utf-8?B?eVVjSHJNQnJrbmZPajE1UGlUVHR3M0hMeUxmS0J0UVd1bTBQZlZpd2hkcXNo?= =?utf-8?B?d2J3bHVwQkkxZHhMZGRnTGVwQzZDTnY2SXpvWHVFKzR5SHVmNys0dmIwVE9q?= =?utf-8?B?RUFMRE0vZHUwT1FmbW9qVlJhcGh0dkU0MGtEdFVlUU1McnpFQWhXbHRvc2No?= =?utf-8?B?OWVDMTFsYk92bTZhVWRFbzVkNFJlVmhXQ1Mvak1yTUQ4V0lVTGVKRHVLdStC?= =?utf-8?B?bnJUV0MxZE84Q2ZvZFlIZEtCS01BYTVHcDVFcU5qKzBPaVVsajhqQnVBWkRy?= =?utf-8?B?UTdxaDdvOXk0QVRpY2c2Vm9kSU1OSnMyeStwWlRuWUREQjBDZTJTSm9MTVpv?= =?utf-8?B?S2J6TjRsYzFlRXVhR2V5Zzk5TldFcHBWVmdSYk1GcWYrcUNSNHlVNTZIb0hS?= =?utf-8?B?bGdVYnFDcmV3ZVUyaG5NRE9lS3gwQ3lFR09keEZhNWRGMHJ1K242MklETzdF?= =?utf-8?B?YmZHbFlBMkdTWUhEb3I1Rmt1aUl1Szh4WkxHR3BIMHBHWEpkY0dRekJhMDVi?= =?utf-8?B?Tk16c3Y2RUdkYTZpRWlHaTlVM0pRMWVJTXArbGoxc1F2OE94bnJLOW1IZWZ3?= =?utf-8?Q?m6VsS/X2UFJ1LPEfPM1/Fdr49?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48d37ba7-b010-4506-a1c6-08da8fe54ff3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 08:53:47.8933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YI2GbW3w7bJQh1tJuj4xy+ocMrMRKGq74IfhU4cSHI7bddY+aTXTms0+c4V87TSpI+Z9bXR0Rv6MmT8ze4l8Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9201 On 03.09.2022 02:24, Stefano Stabellini wrote: > On Thu, 1 Sep 2022, Rahul Singh wrote: >> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >> return 0; >> } >> >> +static int is_bar_valid(const struct dt_device_node *dev, >> + uint64_t addr, uint64_t len, void *data) >> +{ >> + struct pdev_bar *bar_data = data; >> + unsigned long s = mfn_x(bar_data->start); >> + unsigned long e = mfn_x(bar_data->end); >> + >> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >> + bar_data->is_valid = true; > > > This patch looks good and you addressed all Jan's comment well. Before I > ack it, one question. > > I know that you made this change to address Jan's comment but using > PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= > PFN_UP(addr + len - 1)) check means that we are relaxing the > requirements, aren't we? > > I know that this discussion is a bit pointless because addr and len should > always be page aligned, and if they weren't it would be a mistake. But > assuming that they are not page aligned, wouldn't we want this check to > be a strict as possible? > > Wouldn't we want to ensure that the [s,e] range is a strict subset of > [addr,addr+len-1] ? If so we would need to do the following instead: > > if ( (s <= e) && (s >= PFN_UP(addr)) && (e <= PFN_DOWN(addr + len - 1)) ) > bar_data->is_valid = true; But that might mean (in theory at least) a partial overlap, which has to be avoided. The only alternative that I see to Rahul's original code is to omit use of PFN_DOWN() and PFN_UP() in this construct altogether. Assuming that's correct for the passed in (addr,len) tuple. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400196.641856 (Exim 4.92) (envelope-from ) id 1oVgI6-00032w-LT; Tue, 06 Sep 2022 21:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400196.641856; Tue, 06 Sep 2022 21:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI6-00032C-Cz; Tue, 06 Sep 2022 21:39:30 +0000 Received: by outflank-mailman (input) for mailman id 400196; Tue, 06 Sep 2022 21:39:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgG4-0000Cs-5F for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:26 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2046.outbound.protection.outlook.com [40.107.104.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52214944-2de9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 15:39:25 +0200 (CEST) Received: from DB8P191CA0004.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::14) by AS8PR08MB5925.eurprd08.prod.outlook.com (2603:10a6:20b:23d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Tue, 6 Sep 2022 13:39:22 +0000 Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::17) by DB8P191CA0004.outlook.office365.com (2603:10a6:10:130::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 13:39:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 13:39:22 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Tue, 06 Sep 2022 13:39:22 +0000 Received: from 45ba75dd94ea.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2DAA1697-7755-4562-9DB6-B556C53A27F9.1; Tue, 06 Sep 2022 13:39:16 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 45ba75dd94ea.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 13:39:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB6032.eurprd08.prod.outlook.com (2603:10a6:102:e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 6 Sep 2022 13:39:15 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 13:39:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52214944-2de9-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Cd85VEMN9pp0Eko9Acsa9JaTC5VjEvXegEXy6tY4IdSoO4OLQcXk6pNv8P8oL4L8sgIlb3Ks5Kw9HcKUz0f7NUNEt7T5L0h7WLcwiwJpwpKnmwOv6zHhtTJawn8Eb3+21AAs/FhEj7TL5gr8JUa3xJmkDk35RjKvzv8uVwHak5+aDyeIj7aaKMTWosRcpy0IZTv6S6iQg+Rwu062/K/ht4PpJ8iX0+htRt2KRZSDLUJhZ9/etxU1CNaHN3a3qykxosMm/jjEPiYDb+QooWQ1COsdXX7A9kDnQILdbcGzyj3pp+14VN3a7c+Cg9vnggQ3fTbJi3Yozb1SDEpKhEQojA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aVAlHBxa9WEe0XuoVY9Uw69t/Lji3A7G+OQ0S4NLccQ=; b=H9SXldM2KfDSa5PNSHABhd5HKx7LxMZGjh4Ki9cElbsFx4dCcacgmFHyiRrE98QYWe+19iXKVYaUShYvn8P1VySzbfw6u9HTPoUqETsTdGnoxyygokVC9+C4cK3wSjqk0XO27m6pkTBt9egeYzKi0YVicyKfXGd2l2SzqNH4dg9XV0TiccZs0Yc6VXa0ndukbsgj9V2LubwuOGlmw8RgzfOBJvney28Q46lGRwd5ifUEZMiGgQMQkchv+N3Sb2od7VGJo5cnQD7MXFqm3Zuaw6Te/bkvfB03jZBioF8pjSEe7cguCapUJh6g7YEOCCO+OTIlOdHOP5/VyaY6/ljkbw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVAlHBxa9WEe0XuoVY9Uw69t/Lji3A7G+OQ0S4NLccQ=; b=ZEXJrBJ3ivSJ/npKiigwhNkNQjF40pFFKSg0CPTtwb4fU+JrOAhbVwIMtDAXNOlN3LJoVJX0RxShdYSwUlJCYPsOJh2sbdgOhxjuEzYJ7TnyZ5FGXEoO4oXnTbuNzooukslznTT/ljJiE3aJlbZVXsXj0z6yEgdX0stx7LetGzc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPaVyECqfOwxfk9qt7xaGPPieg5IXlJI8bxTI3elFNAryx8CpF/6sdYYyD72BzvzSoY2E/3ocmliFZeXOMuYWRPW3NOzvx0xZN6QkVcSMbU6mPVBNLG3Qbpj8uA3v26PMii+fwEgSMEu1OYnlOhq1+03nZJtsk7kbtnn2mzZxKXjJlwbzXUyuHjp51XXAy9wiIf2YPdQkOkWVE0rwg3JwRLsAx3M14kMQfZLH04JcBerMVNzeZ+g3yKq6mRehq/umtQYva/RP9ZIxAkzYjFuAW+SceZ1MQHK/LrFyQTU/2n5LSapeTJElZL1Za6MOFVl27B9jG2kbSOjaFcLA8qBDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aVAlHBxa9WEe0XuoVY9Uw69t/Lji3A7G+OQ0S4NLccQ=; b=nqMwpL1F8s2ShKWHr8qdgzG2O9Gq6dB8rkCvvTV0KXAu1TGrjIWwwsLH/AOVRG8du8VYhm4LH7Mz3FEoRBSRFzCDDiBFRqZ2yUAkonwmkoLHJHqIkXfaPd6GEFPmcLdjM3fHftGI/OwZkDcKKafEUqWKfEf+vNl+jOiGhDiEdVBXwDbtrnHIQRqlcqc26zF7F3/ZEhPVKaX6eSworHgHqfw9BExasC2JjyBCYLa0c11KmogKrMcQThcgeexHZ2KMds4mndU3PEZxiBPyQ9uIZuFNV1aXyBjnGbBRL0KokacBfU/wdufD3CWhPnfB+o8kqeCZylJBz9PUCF7dsM5G5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVAlHBxa9WEe0XuoVY9Uw69t/Lji3A7G+OQ0S4NLccQ=; b=ZEXJrBJ3ivSJ/npKiigwhNkNQjF40pFFKSg0CPTtwb4fU+JrOAhbVwIMtDAXNOlN3LJoVJX0RxShdYSwUlJCYPsOJh2sbdgOhxjuEzYJ7TnyZ5FGXEoO4oXnTbuNzooukslznTT/ljJiE3aJlbZVXsXj0z6yEgdX0stx7LetGzc= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Topic: [PATCH v2 3/4] xen/arm: Handle reserved heap pages in boot and heap allocator Thread-Index: AQHYwPj6dlOKXE+k5kuuj2vKrDnG5K3RJT6AgAB0+PCAAIHpAIAAAbyAgAA7oYCAAA2RAA== Date: Tue, 6 Sep 2022 13:39:14 +0000 Message-ID: References: <20220905072635.16294-1-Henry.Wang@arm.com> <20220905072635.16294-4-Henry.Wang@arm.com> <57082fec-e9ce-eeda-d051-d75a4bc35909@xen.org> <60a55b4b-4bf5-7325-e603-6abdc56234e3@xen.org> In-Reply-To: <60a55b4b-4bf5-7325-e603-6abdc56234e3@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4A80D8DCD9C86E4ABCD61424155355CC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1a79888a-8432-4868-db93-08da900d3508 x-ms-traffictypediagnostic: PA4PR08MB6032:EE_|DBAEUR03FT008:EE_|AS8PR08MB5925:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n39a4i1zSjFJkOSpmscS54yEn5RGFOqcv/LrYe5wtgFdNWbV3Lmc2H0M5Qus09EHTE3NHeSu/RwctuOEzuQ0ds5z8DxbhcbSjsz9dMg2YlaAYrD9PdekLUChYbZAB7V6NCC249GFPcZBO30rIVgNx7FVap3GguqSIjBSZFC3bpWquz5yTXL62Ifhr5WPhkjx8JmnCv+DKD6K8KnF8Y/ZRHVsuNlHNGOW+hGRebej0MBsB2U6N1M9xVRVxWfwfdInKqH09xvEqPTAnbOL7PpqfaT35UO7RDqd3gyqrDAcjMA1QfzOjcIJQhXjgXCCbXGypmZ/71uykqrO/Xsp9JWKStSAJwoik7oNL5xU2jQjDcJootM7olMK6QLLrlrg5TuxL/R2Fqiu6HRU8Micltv9/DqwVq5aDYaXqGS6q4MyX0t1ZLURZqJrKA+1Nc7QW+7pZlTnB13XMpR2MpupCYpvdXSJh4ugWhEct1zQikvptbLTCZhYP1fXstqkk6jGRNKD8jUBRHwgMV8hPEwqXqw+ni/5pHAufhoiOivi+vBcLPeNNfCSQLapQE4gH9wqQpBhoc+5romHdPBq3UAtK5I4ozoBQpiu7SA5firDNAq36ulBd0R1LiQY1AAEctWgmqlnMwVY/tIxMolF1a6wOOSVwgVBDciuU/0oZareYIentkUhiH1i0xeAQqcthuqT0CyyGIQ3S8MHG/9Ku7nXKkKrGebAHU3vOJXca7t+xcF0GotmKFPB/ZkH6/oNzEUi7xwgJwpTAkyweuxcnceX/VIDHQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(39860400002)(396003)(366004)(26005)(83380400001)(5660300002)(52536014)(2906002)(8936002)(6506007)(7696005)(41300700001)(33656002)(9686003)(86362001)(71200400001)(186003)(478600001)(38070700005)(8676002)(55016003)(66446008)(66556008)(66946007)(76116006)(54906003)(110136005)(316002)(66476007)(64756008)(38100700002)(4326008)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6032 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25a15f10-d255-4c6a-a4a8-08da900d308c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 05TXMvAndogZI3fqzq/csrXDizBk7pA5JuKKkMrNU0jau+BwY5pjDICLB3nt4CpripYjk2ZCQnwUif/pZTnJgNcVeCxjmZbbfKQZDiYEctUqxMSHSDFe5ROHWC86AUHQvde5ylTWsYXorkV9HCQWs15Ar/Ad97bWUGcjjVqDVJO0NzmusdjgFHKxAyDZpMkjWjCTTjTj1r8HXIvh0WPtVh0Xo0iRI9jZyuL97XSOl+79dm9+JQmxjMzO+QX08zx6wpbsG95NZJVIT3PCpBmw00fcPxv85o5/topWmFUAVHJI4/jenBuKoujdxZLtfaaUeXtA+cUdT92fMKTZbvO4Vrdaj0r/9Kon0HpUtBiPhgEn223XFUi7tO95bJ2eh9C3MAA4EWebXnwMIe4TrNp6VrfojcjvzqEOzesOLm47MsJ6eCto0f0EaUOXTAwzrYx6yeyX90jl5HO2LJXdXAQNFLaw1YVXPXP8RCSRtPQk8df20767BRfy7LeemDKoUuXQWab0QvxUEwiY2qLSwvPmmc8vHD3IFj9yvZcUIsgrr45EM15/C8Uw+Xg3/AuIpExh1xRxgu2ibZHtroF626P+0JCSeaCbtFrhdgc57L+Qfo/W8AQ+Q/k9QUFlmdg2pCZVoJYQ362tsrFOJgoRCkUsLxc8ejdHvi9an9gHxoT7PnSPVOS9J1O4RqTCOwJMdgLF0BQr2Nlrl3A8SH2JfqUslVreHgqxR31vaC8/L/00xRPJO4tPyYeac0hEYrY94fqM46gQuhAS5IUpnuRcXrrVwg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(46966006)(36840700001)(40470700004)(316002)(82740400003)(33656002)(70586007)(70206006)(8676002)(4326008)(86362001)(81166007)(36860700001)(356005)(83380400001)(47076005)(41300700001)(6506007)(7696005)(478600001)(26005)(107886003)(9686003)(40480700001)(55016003)(40460700003)(110136005)(54906003)(2906002)(82310400005)(336012)(186003)(8936002)(5660300002)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 13:39:22.4937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a79888a-8432-4868-db93-08da900d3508 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5925 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4gSSBhZ3JlZSB3ZSBuZWVkIHRvIHJlcXVpcmUg NjRLQiBhbGlnbm1lbnQsIGFuZCBjdXJyZW50bHkgd2UgYXJlIGZvbGxvd2luZw0KPiA+IHRoaXMg YmVjYXVzZSB3ZSBhcmUgZG9pbmcgMzJNQiBhbGlnbm1lbnQuDQo+IEhtbW0uLi4gSSB0aGluayB3 ZSBhcmUgdGFsa2luZyBhYm91dCB0d28gZGlmZmVyZW50IHRoaW5ncyBoZXJlLiBXaGF0IEkNCj4g YW0gcmVmZXJyaW5nIHRvIGlzIHRoZSBhbGlnbm1lbnQgb2YgdGhlIHN0YXJ0L2VuZCBvZiB0aGUg cmVnaW9uIHByb3ZpZGVkDQo+IGJ5IHRoZSBhZG1pbi4NCg0KQWhoIHNvcnJ5IG15IGJhZCwgeWVh aCBJIHNob3VsZCBhZGQgdGhlIGFsaWdubWVudCByZXF1aXJlbWVudCBpbiBkdC1iaW5kaW5nLg0K V2lsbCBkbyB0aGF0IGluIHYzLg0KDQo+IA0KPiBbLi4uXQ0KPiANCj4gPj4gTm90ZSB0aGF0IHRv IGhhbmRsZSBhcm0zMiwgeW91IHdpbGwgYWxzbyBuZWVkIHRvIGV4Y2x1ZGUgdGhlIHhlbmhlYXAN Cj4gYXJlYS4NCj4gPg0KPiA+IFdoZW4gSSBpbXBsZW1lbnQgdGhlIGNvZGUsIEkgZm91bmQgdGhh dCB0aGUgYXJtMzIgWGVuaGVhcCBleGNsdWRpbmcNCj4gbG9naWMNCj4gPiBzb21laG93IGNhbiBi ZSByZXVzZWQuDQo+ID4NCj4gPiBTbyBJIHRoaW5rIEkgdHJpZWQgdG8gcmV1c2UgYXMgbXVjaCBh cyBjdXJyZW50IGNvZGUuIFdvdWxkIGJlbG93DQo+ID4gcG9wdWxhdGVfYm9vdF9hbGxvY2F0b3Io KSBzZWVtIG9rIHRvIHlvdT8NCj4gDQo+IEkgd291bGQgcHJlZmVyIGlmIHRoZXkgYXJlIHNlcGFy YXRlIGJlY2F1c2UgdGhlIGxvZ2ljIGNhbiBiZSBzaW1wbGlmaWVkDQo+IHdoZW4gdXNpbmcgdGhl IHN0YXRpYyBoZWFwICh0aGUgeGVuaGVhcCBjYW5ub3QgYWNyb3NzIGEgcmVnaW9uKS4NCg0KSSB0 aGluayB3aGV0aGVyIHNlcGFyYXRlIHRoaXMgbG9naWMgb3Igbm90IGlzIHBlcnNvbmFsIHRhc3Rl LCBJIGRpZCBtaXNzDQp0aGUgInhlbmhlYXAgY2Fubm90IGFjcm9zcyB0aGUgYmFuayIgcGFydCBz byBJIGFncmVlIHlvdXIgc3VnZ2VzdGlvbg0KaXMgYmV0dGVyLCBidXQgSSB0aGluay4uLg0KDQo+ IA0KPiBTb21ldGhpbmcgbGlrZToNCj4gDQo+IGZvciAoIGkgPSAwOyBpIDwgYmFua3MtPm5yX2Jh bmtzOyBpKysgKQ0KPiB7DQo+IA0KPiAjaWZkZWYgQ09ORklHX0FSTV8zMg0KPiAgICAgIGlmICgg KGJhbmtfc3RhcnQgPj0gbWZuX3RvX21hZGRyKGRpcmVjdF9tZm5fc3RhcnQpICYmDQo+ICAgICAg ICAgICAgIGJhbmtfZW5kIDwgbWZuX3RvX21hZGRyKGRpcmVjdF9tZm5fc3RhcnQpICkNCg0KLi4u IHRoaXMgaXMgcHJvYmFibHkgd3Jvbmcgb3IgSSBtaXN1bmRlcnN0b29kPyBJTUhPIHRoZSB4ZW5o ZWFwDQppcyBhbHdheXMgc21hbGxlciAob3IgZXF1YWwpIHRoYW4gdGhlIGJhbmssIGJhc2VkIG9u IHRoZSBsb2dpYyB0aGF0DQpmaW5kaW5nIGEgY29udGlndW91cyB4ZW5oZWFwIGluIGEgYmFuay4N Cg0KU28gdGhlIGNvZGUgSSBwcm9wb3NlIHdvdWxkIGJlOg0KYGBgDQpAQCAtNzEyLDEyICs3MTIs MzcgQEAgc3RhdGljIHZvaWQgX19pbml0IHBvcHVsYXRlX2Jvb3RfYWxsb2NhdG9yKHZvaWQpDQog ew0KICAgICB1bnNpZ25lZCBpbnQgaTsNCiAgICAgY29uc3Qgc3RydWN0IG1lbWluZm8gKmJhbmtz ID0gJmJvb3RpbmZvLm1lbTsNCisgICAgcGFkZHJfdCBzLCBlOw0KKw0KKyAgICBpZiAoIGJvb3Rp bmZvLnN0YXRpY19oZWFwICkNCisgICAgew0KKyAgICAgICAgZm9yICggaSA9IDAgOyBpIDwgYm9v dGluZm8ucmVzZXJ2ZWRfbWVtLm5yX2JhbmtzOyBpKysgKQ0KKyAgICAgICAgew0KKyAgICAgICAg ICAgIGlmICggYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLmJhbmtbaV0udHlwZSAhPSBNRU1CQU5LX1NU QVRJQ19IRUFQICkNCisgICAgICAgICAgICAgICAgY29udGludWU7DQorDQorICAgICAgICAgICAg cyA9IGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5rW2ldLnN0YXJ0Ow0KKyAgICAgICAgICAgIGUg PSBzICsgYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLmJhbmtbaV0uc2l6ZTsNCisjaWZkZWYgQ09ORklH X0FSTV8zMg0KKyAgICAgICAgICAgIC8qIEF2b2lkIHRoZSB4ZW5oZWFwLCBub3RlIHRoYXQgdGhl IHhlbmhlYXAgY2Fubm90IGFjcm9zcyBhIGJhbmsgKi8NCisgICAgICAgICAgICBpZiAoIHMgPD0g bWZuX3RvX21hZGRyKGRpcmVjdG1hcF9tZm5fc3RhcnQpICYmDQorICAgICAgICAgICAgICAgICBl ID49IG1mbl90b19tYWRkcihkaXJlY3RtYXBfbWZuX2VuZCkgKQ0KKyAgICAgICAgICAgIHsNCisg ICAgICAgICAgICAgICAgaW5pdF9ib290X3BhZ2VzKHMsIG1mbl90b19tYWRkcihkaXJlY3RtYXBf bWZuX3N0YXJ0KSk7DQorICAgICAgICAgICAgICAgIGluaXRfYm9vdF9wYWdlcyhtZm5fdG9fbWFk ZHIoZGlyZWN0bWFwX21mbl9lbmQpLCBlKTsNCisgICAgICAgICAgICB9DQorICAgICAgICAgICAg ZWxzZQ0KKyNlbmRpZg0KKyAgICAgICAgICAgICAgICBpbml0X2Jvb3RfcGFnZXMocywgZSk7DQor ICAgICAgICB9DQorDQorICAgICAgICByZXR1cm47DQorICAgIH0NCg0KICAgICBmb3IgKCBpID0g MDsgaSA8IGJhbmtzLT5ucl9iYW5rczsgaSsrICkNCiAgICAgLyogVGhlIG9yaWdpbmFsIGxvZ2lj IGluIHBvcHVsYXRlX2Jvb3RfYWxsb2NhdG9yKCkqLw0KYGBgDQoNCktpbmQgcmVnYXJkcywNCkhl bnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400198.641863 (Exim 4.92) (envelope-from ) id 1oVgI7-0003AP-Q8; Tue, 06 Sep 2022 21:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400198.641863; Tue, 06 Sep 2022 21:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI7-00038p-62; Tue, 06 Sep 2022 21:39:31 +0000 Received: by outflank-mailman (input) for mailman id 400198; Tue, 06 Sep 2022 21:39:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgH4-0000Cs-7z for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:26 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id cde6cd7b-2de9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 15:42:52 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 323BA1A2D; Tue, 6 Sep 2022 06:42:58 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B15993F7B4; Tue, 6 Sep 2022 06:42:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cde6cd7b-2de9-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v4 5/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn Date: Tue, 6 Sep 2022 14:40:43 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Static event channel support will be added for dom0less domains. Modify evtchn_bind_interdomain to support static evtchn. It is necessary to have access to the evtchn_bind_interdomain function to do that, so make evtchn_bind_interdomain global and also make it __must_check. Currently evtchn_bind_interdomain() always allocates the next available local port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_bind_interdomain to accept the port number as an argument and allocate the specified port if available. If the port number argument is zero, the next available port will be allocated. Currently evtchn_bind_interdomain() finds the local domain from "current->domain" pointer. evtchn_bind_interdomain() will be called from the XEN to create static event channel during domain creation. "current" pointer is not valid at that time, therefore modify the evtchn_bind_interdomain() to pass domain as an argument. Signed-off-by: Rahul Singh Acked-by: Jan Beulich Reviewed-by: Julien Grall --- Changes in v4: - no changes Changes in v3: - fix minor comments in commit msg Changes in v2: - Merged patches related to evtchn_bind_interdomain in one patch --- xen/common/event_channel.c | 20 ++++++++++++++------ xen/include/xen/event.h | 5 +++++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index f546e81758..f5e0b12d15 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -381,11 +381,16 @@ static void double_evtchn_unlock(struct evtchn *lchn, struct evtchn *rchn) evtchn_write_unlock(rchn); } -static int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) +/* + * If lport is zero get the next free port and allocate. If port is non-zero + * allocate the specified lport. + */ +int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, struct domain *ld, + evtchn_port_t lport) { struct evtchn *lchn, *rchn; - struct domain *ld = current->domain, *rd; - int lport, rc; + struct domain *rd; + int rc; evtchn_port_t rport = bind->remote_port; domid_t rdom = bind->remote_dom; @@ -405,8 +410,11 @@ static int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) write_lock(&ld->event_lock); } - if ( (lport = get_free_port(ld)) < 0 ) - ERROR_EXIT(lport); + lport = rc = evtchn_get_port(ld, lport); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; + lchn = evtchn_from_port(ld, lport); rchn = _evtchn_from_port(rd, rport); @@ -1239,7 +1247,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) struct evtchn_bind_interdomain bind_interdomain; if ( copy_from_guest(&bind_interdomain, arg, 1) != 0 ) return -EFAULT; - rc = evtchn_bind_interdomain(&bind_interdomain); + rc = evtchn_bind_interdomain(&bind_interdomain, current->domain, 0); if ( !rc && __copy_to_guest(arg, &bind_interdomain, 1) ) rc = -EFAULT; /* Cleaning up here would be a mess! */ break; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index f31963703f..8eae9984a9 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -75,6 +75,11 @@ int evtchn_allocate_port(struct domain *d, unsigned int port); int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, evtchn_port_t port); +/* Bind an event channel port to interdomain */ +int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, + struct domain *ld, + evtchn_port_t port); + /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400201.641867 (Exim 4.92) (envelope-from ) id 1oVgI9-0003RD-3U; Tue, 06 Sep 2022 21:39:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400201.641867; Tue, 06 Sep 2022 21:39:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI8-0003MR-8u; Tue, 06 Sep 2022 21:39:32 +0000 Received: by outflank-mailman (input) for mailman id 400201; Tue, 06 Sep 2022 21:39:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHD-0000Cs-4f for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 431331c0-2dce-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:25:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3156.eurprd04.prod.outlook.com (2603:10a6:206:c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 10:25:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 10:25:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 431331c0-2dce-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aw0v3xaFpjGjm1m4gB3WfEWnC2HMwEae8r863CQgLEh4k91kcnK3m+cS6wF5nW2pSWYLIG1ILCvcbabJSFD2aL8K0VJ0QmMUwDloapQRvhmsWMnoWY5uSdU5V6mKj0Lf2lymXLepObnP8NDjyXR8xU+n0iHo6aAv2DUUCvTgdYKIiV2f5deYGiBYYKE35e1/E82MGOqaWYDp6TNSB5hGWQ3jmkU/f7pUzmUsoZSbXuj71hEqGj+iUqGAwICLbKJ48dXMcsjTPm0jEGBPnWWI7xdiVxaTZMvz23wdD1DG3S1mqjOGHZWB5CZd1ipP0ycT9NAKubUpaFUlvIbnF7jsYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/t1Gjq3u0TsbiycCR2ZrlpGHJV23MQwsr3aB3gBMaPc=; b=GhvywZuQAIXFSyf4FAWJODpff4QnA5Z84ygXKPpS5nXugdcN3BviIJKo4TIOtFLJ6RaFug372Q4k3KZSX+QNiRhiG8KcWFgEROD4yae82BeISWVKV1q6y8HrbWCzJ1rGeQ69F2eLEnZ8qhYs27FGwOFbffgs11oCX5KxMk2raheSrluj5FUtCheiQyW1ZdZrGuupDflF4WBS7HLUWbl+KmUhNwq2hRpQD6azuZMALgCixkvMXGcpqKYiuLbvSJZuCDiqrVL7Nz4mvzseuG+6rMFEqVxCYbEVttUTmuPvyT//U0aCKxU+hSBxsNWK7uHMquFFqs9qhlsZB68C2zeRww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/t1Gjq3u0TsbiycCR2ZrlpGHJV23MQwsr3aB3gBMaPc=; b=XgfNmaHzYFhVsXAeQqjLlmq6GzKTEEw36716NQ6thBhFKuuX5yV3TqZshuE3bBoQoc/qots4f9h1AXQaUBK6PPCXlmAXR9AbBZQ7aPoC4EgHu6p6Gw1U+MOy8NxuxT4VGI3/IIjM/s5h56lBKO00FKhxU2ZCKxETjvNGEu7uaBQdUVlV8AGkob+JfjlGQLGtmAvvMnbzDS+riyecYQEKFdQJ1yIHr+lOCX45nWXikCfDyLcCcj6WLOAtHBwFA7fvt4DIZ9zbqCUZYSt0SYaXYuC72qKxVarUxWvIrNSBjDzOasAMXc65LBAx+0oUm+95pK0CkzJ/anS1kMSRXSMqqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3ff2be60-0a25-638d-53ce-bb7d861c0a9f@suse.com> Date: Tue, 6 Sep 2022 12:25:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Xen 4.17 release: Current status before the feature freeze Content-Language: en-US To: Henry Wang Cc: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44001619-6ebd-42a5-7e2e-08da8ff2271b X-MS-TrafficTypeDiagnostic: AM5PR04MB3156:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lREvP+F6zQ/79GmBDdyXOOHqpWccH+dh0ZwcgRrnLFYzWlbuDWVgpHdQ+0dv0rdnBEK+BllY4akkrgZ+ZMp/K/Vz88XxRwqzZx0gO+9G94kpW48zhD2Qag5j+27MokuT852BhcAocmy0/LkJaT7xNbjRN0VnBjVMhSSD8lTMQ13KGGhK8lo37RyGTS67LXO6usN1ZhVklFKvCqetP31ge+1EnHi8TLW3A+Nv4ORFLWOCd2EeHUNTdHeyA1y2La1jADS+d81yfLFUyTQNvb7T1HJv56KU1k9noi2wCOVCts1bpuOvptN7iU9qD21dg/m9fyxScbwZ/GVKWz7LWCfwtcLHN5xAF+DaSSnMi7PFH1P2U5Q5uqD1p5eEKGEneHFI6DjqFJdd/pOxWDiKJFyarMXO/FcyZ8QTYYgfKbiDzyV/nj5wFD9pGawG4gNBjbygQMDV9Zq+hB3+0jZNXboOSHMDb7lTrICLawZY6iG0dAluizWoy74sXq6f69ZlqwQuOBseDgwZkjVb1Bj7U70MibAVARkTHB1t/w7yVLPC+PZkRphZI0SWXsPwFxFVfrln9zid1gltco5SSF/xB1y3E1O42pQhm7JWJcbK3cy1ARsoCdgzIiWxF8SDDgVFuozy3STzwZYod01z94dvfTQQvCb83LmhKOfzAvHaEOqneVvhTNF1RtRN98kac8uBfiLcz1m/FP675Gyxqkw92/ip9buCtith14g8F+dfeDpeUCfrJ2vtT9gf+jDdYHy5bBFYNo/kUTW+VK81aPHoUFiefxVlMSXc9SpsikXcKFlZAJ5yOGlUO+wS4odH/HR9PfBT3XBbZfqHbGEfAnqG2NODNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(136003)(39860400002)(346002)(376002)(2906002)(4326008)(31686004)(8936002)(7416002)(186003)(83380400001)(2616005)(36756003)(66476007)(66946007)(8676002)(5660300002)(66556008)(31696002)(6916009)(478600001)(26005)(6486002)(54906003)(966005)(41300700001)(53546011)(6512007)(86362001)(6506007)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckk2U0lka0hyc1g3WXB5bmlLUktrdjlnQWdIcEpYckRjQ1lVVWhLWEc1cFU4?= =?utf-8?B?Zy96aWswdEp6a0tyclgxWW10aG44aDRLTVJUcUNSRjc2WHF6U1RIc0tqS1Nv?= =?utf-8?B?MVY5bXpWSGdtd0w0dFFxcHNtbGMzb3VhN0xCSG9pSXF2K00zM3hyQU1TWHN6?= =?utf-8?B?OXB5RGxPS0pTN0RYNlgzK1hYMWdBTkJybGlVSW5xeW9ERGVYYVRXRVRHc2dB?= =?utf-8?B?Yys2aEtmS2F1ZnBFSzNWL1lzTlpZcnRTZmpHWkliWFR0UFk0bTdGNEkwNVVn?= =?utf-8?B?U2VXZVIvR2FvcWliaWZQMVgxUWt1YzYzQVhCQkd2VVB3THNpSHpsWVBsNVFh?= =?utf-8?B?UER3N1ozdWR6TnNMcENBck1SU2FVWno3WmhjbzFNYUsrRHZPZzZITFlIVWVU?= =?utf-8?B?alpuRFFFQW4rczJYdUNlUEFGM0tsc2Z6OFVBVXhoTHQ3RWRxa2JyTUlNWUR1?= =?utf-8?B?bGxUN2dKd0JqaE9DL0VHTkhhaE1mVHpuVUg0UEc3QWpwVngvQ0ZsTGNDSUMv?= =?utf-8?B?czMvZkVjcjJqbmZmUklWVS95N01IOFBoYWxxek1tT3BDeEVVN0VsM2FNdjhF?= =?utf-8?B?ZytKblFqUkhlenJGU2lVSmJ4Y3AwYnJXd2phaGMrNWdLOXB3bEpoN3NyMm1J?= =?utf-8?B?ZVpVa01kU28vZmhjQnBoQ3lHV1BaaDVRd1ZCYVEyQ0xONU1HUXFrUXdTYmhR?= =?utf-8?B?QlhUenlZSlNlQ3J5clZ4OEV1UzFTeW1YaXJyR0VkRGVDc05MZC94dkN5TWhD?= =?utf-8?B?SzJOMllVOVVIc1VhMFBNdmNzK2tFREljMWJJVlFuNVh1aHRWVW5YbE9ZcTVH?= =?utf-8?B?QVdLV0Y2SFNqd2pxbkg4dEdabmlXSWVkZ3RZTllWRVFHdnBDZDU1OWpTQWRo?= =?utf-8?B?TGJITDk0cWRqUjNqTlQ0MXRuZ08yWkxwYjRNanlGVlJpcXhra3FCc1hjWlFQ?= =?utf-8?B?SEYzZGxsM09ZQnFBcDFsa2IyKytQc3MrMFpqMjVidUFUeEVVa1RadEM4b0hu?= =?utf-8?B?S2liZWlIaXFPSnFBcjNEQkJmbElobjdyRGFDVTl2dDYrbit0QkNiWnFjYnlv?= =?utf-8?B?cEkxVDBPQmJnUWlNY09xQVo4U1FmQ2hTa3ExSjRpbUdTd0hSWjEwSkxTVjNl?= =?utf-8?B?UEpBb2NXSzFma1pJRUZXR3N2UFkxRzN2Q2tkbjliQmUycjRwcG5URGVpVmJM?= =?utf-8?B?RXhQeE5sRERDaUs2dmJ5U3BJRGxLUThwNXBuSHZRRzYxUXhOcmdDb3NCbzZH?= =?utf-8?B?NVpvMTlWb0VXSG10a255bUQ0bU5lYVUrRnh3M3hvMlNuVGZFQ3MzaUVjdWt5?= =?utf-8?B?T0dyS2thSlVDUzRQYlFxQW4ydEsrZFZjOHVEOEI2ekVseERxVnpZOFc1L0dm?= =?utf-8?B?K2tJcFQrOXZ4aWRSck1waXFtUWtrQU9VazNjbkRpa0JSenlCRjV4b2ttK3E1?= =?utf-8?B?VkIyang4ZkhVTjEydmJhVXVZZVdBZ2ttZEJXZTdLa1dYTXU2ZWgzR0tTeXZk?= =?utf-8?B?YkNNb0tOazJQcHdGZWIzeEZtQUs5L3VZNE5pUHFUYXJzRGhmWlhna0RlKy80?= =?utf-8?B?SFh0VTNpR3EyL1ZJZlladEpMdnRHYXBtTUw4RitEQ3V4Um9ZQTNaNHJycFhz?= =?utf-8?B?RGNCOXg4SlJNbkhWSGNRMlNjOEhhZTBxMW9yY25vRGhCSkk4dXpKL2YzeWNK?= =?utf-8?B?N0J2a3Z5MkEzR3FCZjB0eVRvWTBjSnh5QmxmMkZ2aGI3NmhxOG5PbmFEZ2li?= =?utf-8?B?azVvN296WW4xT0M1TWwxaWlISlliRTk3OHp1SjNkUnhGbURndnRXd29JUFZo?= =?utf-8?B?SlVQdDhrQkVhNlMzTHM3Yjg5NVR4TFV4dFcrakFmRGVpVWZWNVJJWXZnc21S?= =?utf-8?B?L3NTVzFrYWtWeS9jTDgwWnBEK2UveloxbSswZjJDTWxSbUZlL0k2L3hGbUp4?= =?utf-8?B?SWpmMldBdXJ6ZFVPUEZ5M2NYeUp6Q2FvK2lnODhnYU5rYmRSbzFBVlBsYjEy?= =?utf-8?B?MUY4Mmw2d0FoQmtQd1hRVnMxMGl0VjJ4ZTR6Z0RxKzEvNjlhYlBzV0lyUFc0?= =?utf-8?B?ZjBMOEl6QldiL2t2eDNMYXorOVJrSUludkN2Ym1VdWhzN0pEYURBeERab1lI?= =?utf-8?Q?9rFPR9MFfFkfpR6KveD/MS4wl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44001619-6ebd-42a5-7e2e-08da8ff2271b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:25:42.8723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dZ/jr8AX4yaNSrZH0+SgXKBsAn6OLHzDOWp6ipokPlDPptLaHqbjhI9vao4uTHlAR+F86hqxT+l4Dgjnjc3nkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3156 On 05.09.2022 05:44, Henry Wang wrote: > ** Blocker List **: > 1. Patch: x86: enable interrupts around dump_execstate() > https://patchwork.kernel.org/project/xen-devel/patch/e717897f-980d-ad44-31d9-39f5e7e1c45e@suse.com/ > Status: Waiting for review. >[...] > ** Arm **: >[...] > ** Automation ** >[...] > ** x86 **: > 1. [v2] x86: show_hvm_stack() requires enabled interrupts > https://patchwork.kernel.org/project/xen-devel/list/?series=667114 > Status: Need reviews. If I'm not mistaken this is the same as blocker list item 1. The title has changed in v2. > 4. Intel Hardware P-States (HWP) support > https://patchwork.kernel.org/project/xen-devel/list/?series=666690 > Status: Need reviews. To be honest I don't expect this to make 4.17, unless suddenly new review bandwidth appears out of nowhere. > ** toolstack **: >[...] > 8. acpi: Add TPM2 interface definition and make the TPM version configurable. > https://patchwork.kernel.org/project/xen-devel/list/?series=672588 > Status: Need action from author. Didn't this come quite a bit too late to be eligible for 4.17? Or has there been an exception agreed upon behind the scenes? > 9. Use direct I/O for loop devices > https://patchwork.kernel.org/project/xen-devel/list/?series=668537 > Status: Need inputs from reviewer/maintainer. Aiui this needs a v2. > ** XSM **: > 1. [v12] xsm: refactor flask sid alloc and domain check > https://patchwork.kernel.org/project/xen-devel/list/?series=666302 > Status: Need review. My conclusion from the v12 discussion was that a v13 would appear. > ** drivers **: > 1. Add Xue - console over USB 3 Debug Capability > https://patchwork.kernel.org/project/xen-devel/list/?series=673630 > Status: Need reviews for #1 #2 #4 #9 #10 > > 2. PCI: avoid bogus calls to get_pseg() > https://patchwork.kernel.org/project/xen-devel/list/?series=666322 > Status: I am not sure if this is superseded by > PCI: re-work pci_get_pdev() and friends, if so please ignore this. Yes, that one was superseded. > ** Common **: > 1. xen: add late init call in start_xen > https://patchwork.kernel.org/project/xen-devel/list/?series=664963 > Status: Need actions from author. Wasn't that patch effectively withdrawn? > 2. xen/wait: Improvements > https://patchwork.kernel.org/project/xen-devel/list/?series=660565 > Status: Need reviews for patch #4 #5. Reviews were done, and (perhaps indicated only on irc) these last two then were withdrawn iirc. > 9. Make XEN_FW_EFI_MEM_INFO easier to use > https://patchwork.kernel.org/project/xen-devel/list/?series=670812 > Status: Need confirmation from maintainer Confirmation from maintainer? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400215.641889 (Exim 4.92) (envelope-from ) id 1oVgIC-0004On-SX; Tue, 06 Sep 2022 21:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400215.641889; Tue, 06 Sep 2022 21:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIC-0004Mh-8P; Tue, 06 Sep 2022 21:39:36 +0000 Received: by outflank-mailman (input) for mailman id 400215; Tue, 06 Sep 2022 21:39:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGo-0000Cs-0c for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:10 +0000 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [2607:f8b0:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9409470c-2df6-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:14:19 +0200 (CEST) Received: by mail-pf1-x430.google.com with SMTP id x19so11707463pfr.1 for ; Tue, 06 Sep 2022 08:14:19 -0700 (PDT) Received: from leoy-huanghe.lan (n058152048222.netvigator.com. [58.152.48.222]) by smtp.gmail.com with ESMTPSA id f21-20020aa79695000000b00538405dfe4asm10234125pfk.111.2022.09.06.08.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 08:14:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9409470c-2df6-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=yXjISJhrY/N3Iy39LpKe7XmBe/2D/mWjQT063XPGd4E=; b=OymWPPqRv+u6skIwxE/9+SFKWH1CAraBhECGYGkoQcB2yreDn+fep/6gWgum+17xEc PfbtnD26KQFas8BU1kpA8xwCUNRdYIrBJhUNIIBqr+DacgqEp7nq8N10ql58fyVWlKH3 s3KjlNs6+g6Dynm8oAWLDBbBFxYWz9Q+/5U0fmF53fgtHqUnzq/uypYikJpeRoDHZ5nM ZEDFvq+D3cOAqUHD86RHW52kZrF5FxR16dRlKCyMsl8RNWfQ/U09V4hnVDrYFo200LAd pxzhUY70cgupJ/+/tXRoFMXr/ajgd25/BiY0IJ2CNfTgMu/3j+Ik/M9sCPWWTMqc1k+I 2X/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=yXjISJhrY/N3Iy39LpKe7XmBe/2D/mWjQT063XPGd4E=; b=h6KL1gEeFamp6XRd2aSwrnIoX/xn7ttV6Nr1z8ro6Ah1ZLpxgV3AtWnHAEBfghGsg6 GayCmWLqKlREckh0oZkMbpqOARDZnVCf5Fz3i45I+9IPTx+72FbtpoQ1AjgOGtfTCwoe mnRcya2nYEs8AkaOsmpPZogXaxPYONdhrCUPaLEEIwAof8CNixHtOZwIqY8x7K3dBbEf yaMLl65CXdvX5A/nx4l61inV3VZZzRaf8wbrqJkaNKIClbW9iXeYeg9G+YxSYViATPX0 NKZTNywJ0LrcmOuoxedyaL5Qe/mkZoibjQZtsUwhBwWGzV7MTR8Ke7SXNjGJMri3wtOS oFXg== X-Gm-Message-State: ACgBeo34u5D8S42NUKyUDdRj+N9Ult4QE1jJ7+2VSEmunmNKMYCZ71ux fpB3aps9k35bkbcgsj4kVyLQkA== X-Google-Smtp-Source: AA6agR6TSIGQwaHdJVaO7Ov5llyWeP9bLlt91wN7uSHBHuVQSSoutENLbzU+d/ottHaH89FzmnBPlw== X-Received: by 2002:a05:6a02:305:b0:42c:4b07:8280 with SMTP id bn5-20020a056a02030500b0042c4b078280mr34996840pgb.354.1662477258266; Tue, 06 Sep 2022 08:14:18 -0700 (PDT) Date: Tue, 6 Sep 2022 23:14:14 +0800 From: Leo Yan To: Bertrand Marquis Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Message-ID: References: <20220906113112.106995-1-leo.yan@linaro.org> <09F01AC7-6125-49C3-80BF-637BBFDC739A@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09F01AC7-6125-49C3-80BF-637BBFDC739A@arm.com> On Tue, Sep 06, 2022 at 01:09:28PM +0000, Bertrand Marquis wrote: > Hi Leo, > > > On 6 Sep 2022, at 12:31, Leo Yan wrote: > > > > On Arm64 Linux kernel prints log for Xen version number: > > > > [ 0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found > > > > Because the header file "xen/compile.h" is missed, XEN_VERSION and > > XEN_SUBVERSION are not defined, thus compiler directly uses the > > string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string. > > > > This patch includes the header "xen/compile.h" which defines macros for > > XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via > > hypervisor node. > > > > Signed-off-by: Leo Yan > > Very nice finding and side effect from stringify. > > Reviewed-by: Bertrand Marquis Thanks for review, Bertrand. From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400216.641895 (Exim 4.92) (envelope-from ) id 1oVgID-0004Uk-HS; Tue, 06 Sep 2022 21:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400216.641895; Tue, 06 Sep 2022 21:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIC-0004Rw-Rc; Tue, 06 Sep 2022 21:39:36 +0000 Received: by outflank-mailman (input) for mailman id 400216; Tue, 06 Sep 2022 21:39:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHC-0000Cs-4f for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 435b8c81-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 10:59:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B059C139F; Tue, 6 Sep 2022 01:59:59 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 18B4D3F7B4; Tue, 6 Sep 2022 01:59:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 435b8c81-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v7 0/9] static shared memory on dom0less system Date: Tue, 6 Sep 2022 16:59:32 +0800 Message-Id: <20220906085941.944592-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. Penny Zheng (9): xen/arm: introduce static shared memory xen/arm: assign static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 xen: Add static memory sharing in SUPPORT.md SUPPORT.md | 7 + docs/misc/arm/device-tree/booting.txt | 132 +++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 165 +++++++++++ xen/arch/arm/domain_build.c | 408 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/setup.h | 7 + xen/arch/arm/mm.c | 42 ++- xen/common/domain.c | 3 + 10 files changed, 766 insertions(+), 9 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400219.641899 (Exim 4.92) (envelope-from ) id 1oVgIE-0004n7-Pg; Tue, 06 Sep 2022 21:39:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400219.641899; Tue, 06 Sep 2022 21:39:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIE-0004jp-5I; Tue, 06 Sep 2022 21:39:38 +0000 Received: by outflank-mailman (input) for mailman id 400219; Tue, 06 Sep 2022 21:39:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGl-0000Cs-0K for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:07 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00087.outbound.protection.outlook.com [40.107.0.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 930a3132-2dc5-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:23:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Tue, 6 Sep 2022 09:23:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 09:23:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 930a3132-2dc5-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFWbR77luFoFB1moDkvx7RG2MTpRoXKQOpfXG5kdNppOF6fOw/nQGeKQub0L5fJ1ick1JsyfwR7uNJpDr4mnxNTkyz9vp32bxOHTwyGLCdI3kbP3IsOoJNodKvjTwytsCJXaZV4Hz6FCX4fJfrdDRFZ9I/dFW2GqQJ2x/Fr9dkWOByqcVM9SurrLsMYtfZVhESggGw2WiTlkZhzpKl8DxrjkJ3vQcBJzNaXLoyzBOLYtk2sGgrDonYLugPr7xGa6KEmJrOYSXRIQh0IUDMmMmxD5lqUJTZvkknCUy+YF/daqCCrrmtjD+dAEmIqDNkDXg+dyuLpaU+L/fIZiJh60KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=57/bYk9q+8WaTm2K+86JZhQVBKn50AlbT9LrSB7MjhA=; b=ahdW7lEI/MivnvHD2rEZPi7nKQEVm3SgudmSocf+JkHuDusF+GYUuV+q3zpOeG4IFPln1ZuruSZNQekMWHWJ+BKazWCFibVtfFjRQupxoEH2iztmxhl/tbueRCSEKHJINKhgqWBvDHE2qG0VEQnXCdyA+mFkFX/KOqcT2WTfTOMB0HIlHKQ4NVFYUxlkocqz2MbYO519NIqJ15hfRvqTkgt6AQu7p2ByvZgiUVsXkjcB/0Eo9OoEVlniFqWIGiPyMgSMlXGEyTBy6Y24ZrTTuWdUwHWybbuZV9d1N/zfddbaCP1bsddf7bfQZR7ebvFI2ROzQ94CyFMpOT8ndBrzBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=57/bYk9q+8WaTm2K+86JZhQVBKn50AlbT9LrSB7MjhA=; b=W3URmduITWsAaApIdxtaJ1Mfq42hhtLbfGOEYGafZCORxC4+HiKZOCkAif1wHkFGMF1Hp2ovBUngT7T3bnn8uCyJ5VO+nGYdRnSc4WBu9IOqg17JxPDpFmxpa5CCFYS+ZmtWW23ZH6z+FUkvwHxwYRpPa4vnjA62hkyQHsHlR/e5O6FlxUikHEGIQZSb5HTxWEgayJhwZpAYOK1JYU9HZxdH6UA6ZnIVFiXbFkZzu0HmXSKMyIO+gYOTSCOftVHPO4q3EButoc0HHsywW4inEx7okoxJik78G9fYWf9le25yePzGZhPUtxbkwSGzSkF84iWeHR9kpTlN8uTkr7lCZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 11:23:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 10/10] drivers/char: use smp barriers in xhci driver Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <992c6512e54435a006c6de28515d1242518cb974.1662124370.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <992c6512e54435a006c6de28515d1242518cb974.1662124370.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0065.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29c0b282-a13d-4461-c99d-08da8fe9788d X-MS-TrafficTypeDiagnostic: VI1PR04MB4893:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uQWAngC7X5P+tkdi9cuBb7Jt0JnNfawY7s3AEcdSaJ8SyDoRDH3xu61jIzLTmmax4ihE1onjFqFb9NVSMQx5oK/d3NROtTyH+HPXE3tDnZJN8LT6bBn4VZoMMWP+dFo5fRN4D1nD+Qq3I7Nb/GU4Gckj7VObs9KtM6rzYtyDAHx7CVqcuXhqhGRvr8JdNXDrp/+fp/3eRwnpKEsE2fsXxc7KkJ8sqITaQvWzvvu4Y/jY8EEAD4Qlpinso3DMSiJn1V6XZMMbMlWbKfwxAiaFHdPy0dz5qCe7Nr864n+0xebhZEWkNw8NV68dXtLanl3ihmNjRRPiLRk9VjyYVHYXl4dV3xfvoOCRdjmaP4wVUnt6FBFcIs45arFC3WtElsDBoLHrlT9Gl2FhLCoZUo1jgJuIXjooA7aRdEyR5ma4TGHdR5VObwm9ZHIjehewvzrArhLn/M2A5vnQZ/x0N6NxQMfa7VeIwYrUDV4o3mLIsDQKwwdr7oYVu1/o863t2HD0ewANdE7e8yQT1MAV210D3mvtVjQbRpL2AQa884zOzyq9Fe+toICP3TEno1GZgcgDg6DBdJopeaXm8jKfPSrvise8azsimOOH3UAv17wAHYx3wxYW2+gz8xyE+lBZITn0dO/WSH25xJ0qz7kxQzAXkGQH2/FMaTZSmmqAwoA88uofWFD2OHWMRj/7BBj7Ns4WVjSrrHoZmcE6t2YoWYzThusPPNNz2ude6Fn1o8/x80FBmv7uVa0p2xUSC4yn5XruJYnFur/8J5Uhi0asxlAQgxP8QAcOuR0V9d/MTmXosZM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(136003)(39860400002)(366004)(478600001)(83380400001)(2616005)(186003)(4326008)(8676002)(66476007)(66556008)(66946007)(6512007)(31686004)(36756003)(6486002)(41300700001)(53546011)(6506007)(26005)(31696002)(86362001)(8936002)(6916009)(2906002)(54906003)(5660300002)(4744005)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bU1McG1NVzh3c0UweExRVWNPd29Yc0dkelM2ZC9ucHZoUW51ekFCN1BCemE4?= =?utf-8?B?ZzVWT0pEbFd6SVRUNk9nM25aL0ZRcjI0UjdOaDdUUEYwWnNBaTlyZUlLckZJ?= =?utf-8?B?VnRlYitMWmlyOENKY3FpQjlHdkFwSWM0UGZZclRCbXJiY2k3ek93M1A2NzdY?= =?utf-8?B?azhldG5yTEdmTVdyUW9xd2F4Y0Y3TzJ5TzBYcUJ4ZmZIc0lad0QzbVZyei8x?= =?utf-8?B?d2Y2L21PZTlUYXhCSENQNk5HMFMwVXJDNHJtMUtUWXdpZXNhVFJ6T01HWVh3?= =?utf-8?B?N1dsdzlNT1d5R1lyblA2dC96Y05QRmlrdC83ajlETkFTWlA5TFdpaUc0cmIx?= =?utf-8?B?REJRVUNZYncxbk1zakE3VTRHUWE5YmZualJqd2FyQ0dvUkRDSG1WKy9OMkxE?= =?utf-8?B?bjRuVWpNbEpabGJZNGRCRjE1Z0hJUlZoRk44QnQ2b3E0RG10RjZjelZMMytJ?= =?utf-8?B?ODE4QWtRS1Z0cVoxeVBnL1VOOUw5V1VQakhTMDU2N1pBQzJhcDhRV0taRGli?= =?utf-8?B?NVdIeGNwVk5Qa044WFloeU54bEhmOTdvb2VUSzROMFdVY1g5dVN4VkhOZVRt?= =?utf-8?B?VS9DZ25GMWZXLzc1UGd4RTNZcVZycEZNM0JxUXREbllKK2Zqdm9aZDlHN0xm?= =?utf-8?B?SGtkbjY2WG05R2ZlTU9JLzJDK3YvYUQ1NWZGUUZRUmx6c0JUVHQxcTBaSlN0?= =?utf-8?B?YmxKNXFENHRYcVYrL2VKemgybk4yWXh5TVZVa0VkMERSaUVMUFpXUzhwQStJ?= =?utf-8?B?MFBxNXlNQjNYb0FrMUhIeDJZV3dFYkxHNXQxNWxyY2lzZVc2NDgrQmVSS2Zr?= =?utf-8?B?THB3bnJmKzJubG5aOXZkcWE4djhDb0dWbFk3NmdBTmJjZ2xHVWhZR1ZrVFVo?= =?utf-8?B?Nm9lVjdqdStoNDYyTUdZL3l1YldHbGRJMFlpUmEzZGlLbXV2Tzd5SWNPRDBL?= =?utf-8?B?aURRdmgyeWs0OUh4UU5mdkdiellLeCtGWTFIZUprSWFmSitBKzMvRmNrM0w0?= =?utf-8?B?NDlFTlpsNDlRU0lJTUJSMGFvanp0c1FFeXRKSkR2bVFZSlNRbmhWZWFEb3NK?= =?utf-8?B?OEI0cmxaN0xkUm11Vk40a3hqLzFlZE5VVkhiR2F2cjRrNi9KRVk3R3E4STNB?= =?utf-8?B?cTE1eDc3WEVhdEZXUkRWYXpqczJxZmxGeG9HM2xnZElPM0ZrdzJmTVlka2Uy?= =?utf-8?B?Nkk2VnRXcUtYVmFZeDRmbHZZOEN2cUhGK1k1L2tLTTkvRUdZd0VnSlhTMHFI?= =?utf-8?B?RW9rd2h2NXdRalRnUTMzZlVkc2RrV2UvMjJLYnZtanYwQlF6bXFkamw1bHMw?= =?utf-8?B?b1FkSmFwanVDb05HdVVVa2tlbmRJR1hENFJ3cXdmMG9DUU9HcnZnVHlKK2F3?= =?utf-8?B?T1ZNaHh0bkZZcFdzV25XN050NDk4TGx4RllGV1BWRW4wUHl5czdhZHlRVnhW?= =?utf-8?B?bm1ScHMxTDV3emQ0R1R3bktZSS9OTnpJcWoyTmphR28yN1BvS3loRWw1anFS?= =?utf-8?B?dG9aejJMZ21DMnIrY0k3THBQc2VHd2l0b1lsS3lxUXhCbXRjL3Juc2FRbFZo?= =?utf-8?B?akRXbEROZ1lUc3E3bVNSWkVzTU0yZ2FBbXhHUDdJMTd3RU5UMUpDZ3ZqR3h4?= =?utf-8?B?WkExaTFQUUoyMW0vYk1WWXRYakkyVVB4Wk5oSmNvRlBIdlUvZ0tqMlJmTHg3?= =?utf-8?B?Um1tSi9acUl2b25DRE91NithaGw0M2xOTFpYWGwwR1pyODBpQVlFRTBLRWJI?= =?utf-8?B?SlI0QTVSalFEZmZHd2ZwYlFvK2Y2Vll4NWJwNlYrMUlKV3R2STJaQ21IYkFI?= =?utf-8?B?U0dKYThKSjhMTGhoSlE0dUFCclk3eklOOUtXSjBiVUU5SHVpZ3lxakd0cnU5?= =?utf-8?B?Y3VGeEJnSEVTWHh1NDVLLzRWN3ZpSmtMUXN4TXhpZS9TakJlSXJoYkp2bWI5?= =?utf-8?B?aUxFbVFRTUhjM1pKemRyM2xBK29JYSs5ellpMTlZbmdzMTUvMWlvOGkra29r?= =?utf-8?B?KzBDdnJJcktJQnZwSllOdWJxVFVzTnRYU2dNUm03MkcxQk5WVVRvaHVtMWNv?= =?utf-8?B?QzFXd0hCVE1wV2V6Z1JvZlpDNDlienF1OG0zZi8zTU9EcVNTbmdiMnNhSnFE?= =?utf-8?Q?jUq2D6mGyaJF9MxF83bh7+vYe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29c0b282-a13d-4461-c99d-08da8fe9788d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:23:34.0618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fxhzbGuhzZk46zHVbxO+mXvwaAIUjLk3h/2lM66KaNMyGQ0WzGK1MfvHsGfbAUTecHV9Em9aiW9CkQ9o79iTKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4893 On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote: > All (interesting) data is in plain WB cached memory, and the few BAR > register that are configured have a UC mapping, which orders properly > WRT other writes on x86. > > Suggested-by: Andrew Cooper > Signed-off-by: Marek Marczykowski-Górecki As said in reply to Andrew's comment: What about non-x86? Drivers like this one, even if presently depending on X86 in Kconfig, shouldn't be making assumptions like this. Such is imo only appropriate when a driver conceivably would only ever be useful on x86. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400229.641922 (Exim 4.92) (envelope-from ) id 1oVgIK-0006NJ-H2; Tue, 06 Sep 2022 21:39:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400229.641922; Tue, 06 Sep 2022 21:39:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIK-0006Mf-CT; Tue, 06 Sep 2022 21:39:44 +0000 Received: by outflank-mailman (input) for mailman id 400229; Tue, 06 Sep 2022 21:39:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGk-0000Cs-0I for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:06 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8a7fee73-2dc9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:51:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7573D6E for ; Tue, 6 Sep 2022 02:52:02 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 534653F534 for ; Tue, 6 Sep 2022 02:51:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a7fee73-2dc9-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Subject: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Date: Tue, 6 Sep 2022 10:51:36 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series merge the applicable Linux fixes to Xen. Bixuan Cui (1): xen/arm: smmuv3: Change *array into *const array Christophe JAILLET (1): xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Gustavo A. R. Silva (1): xen/arm: smmuv3: Fix fall-through warning for Clang Jean-Philippe Brucker (2): xen/arm: smmuv3: Fix endianness annotations xen/arm: smmuv3: Move definitions to a header Robin Murphy (1): xen/arm: smmuv3: Remove the page 1 fixup Zenghui Yu (2): xen/arm: smmuv3: Fix l1 stream table size in the error message xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command Zhen Lei (1): xen/arm: smmuv3: Remove unnecessary oom message Zhou Wang (1): xen/arm: smmuv3: Ensure queue is read after updating prod pointer xen/drivers/passthrough/arm/smmu-v3.c | 741 ++------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ 2 files changed, 708 insertions(+), 705 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400231.641932 (Exim 4.92) (envelope-from ) id 1oVgIM-0006kw-8F; Tue, 06 Sep 2022 21:39:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400231.641932; Tue, 06 Sep 2022 21:39:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIL-0006in-Ue; Tue, 06 Sep 2022 21:39:45 +0000 Received: by outflank-mailman (input) for mailman id 400231; Tue, 06 Sep 2022 21:39:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGX-0000Cs-F8 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:53 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2079.outbound.protection.outlook.com [40.107.244.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2dc477e-2dd1-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:51:13 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by SJ1PR12MB6217.namprd12.prod.outlook.com (2603:10b6:a03:458::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 10:51:09 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b8a0:a7b4:2921:9c2d%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 10:51:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2dc477e-2dd1-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ScqUo3pTSLIE0fK1pvhU2ZhQwHuUcU/wFpKzzrsMV1W/wFMOdsGYzjl0NWTmdx0HnH/xiF0xxZhAlRf+7G4aVpAbSRfOIBJZPTKPDooFuN+G27JqyJBQgNUA+AnBUGeImDhYp2DI9+fH4l/W7AQ83MdD5Ri+jkwvfUuby2mxI+tbBp1Awx3B+NHT/eULrF6X/psGiFY67aw6f4oh7JxIW+NKp0rrELvnOAPnsY+N2U9brXEYkQmd0hje0l33R9IqXZ6mtNgjHcjLfeyfWJJwBUgLHoF7qzzetiNSivjgICPpK96Tf+AqpqcerZSYx7PMEaBVSnvoGHC18xCIbJD/0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XmwWHSpQbfryGmhk5r8bJldYLtnloo1qnabN9mGlnpQ=; b=C7IxtzgKteO581cKfBme53pPT7dpC6y02TF/lL6LT/lPVI4U7o1GbOh0fsVF+7pioMvF1C1BR0wuRvHVbAhu/Y63oCnVgf+djue/3y1iYGzmM7x5VGvvz6WshMj3Yz2oyxKlhgbb5ckWDTtoOjR5YLQDN904e4SaZN21r1fKAiCSQUqIiL7u6Mm/LtA9D+QOJ92XCA9wFuSXSiLYeO8Mu4NB2YWn34crieO0rn4Hwef8LvL3lZbkqhxPW+K6/uKLSVcJplXBSiIJbzdKR/0uiIsDj/IJsF5kjLwbkzbkLs/nnd9ghl0I7hn7YoiZpQeJG8F4Io30U00JRiCrXCgpgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmwWHSpQbfryGmhk5r8bJldYLtnloo1qnabN9mGlnpQ=; b=UN58jIYhkstmPhMuo96D13RhQUYcMApMWqunPLfy+mVyFF2h8OVxzOnHUbnU9UkuWq/J8cCI5sG0Fb4zIo89tbmeH7UcoUrJBkQPg0vBfUYC1uy+rZmmXcZDvHCtFjjPZnqtjZqds4NHK2FG+JFc0LfsCy9rsU6qNaJ09m56KYQ= From: "SHARMA, JYOTIRMOY" To: "SHARMA, JYOTIRMOY" CC: "al1img@gmail.com" , "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "olekstysh@gmail.com" , "Stabellini, Stefano" , "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" Subject: Re: Enable audio virtualization in Xen Thread-Topic: Re: Enable audio virtualization in Xen Thread-Index: AdjB3no6hd1w0/5IQgSmD9pfP52J3g== Date: Tue, 6 Sep 2022 10:51:09 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-06T10:51:06Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=8c1f8858-b144-40bf-a6e1-9757941221e6; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76032c41-e33c-4cde-0fbc-08da8ff5b517 x-ms-traffictypediagnostic: SJ1PR12MB6217:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I8gwHKbLtApv6ZVE2OnA5oOoKElw9QdpfXdb0jTE650dEUf4rghNim22rRLu+g5nPwEzxQ+2deQm9YWsFpq5p4faXzlzT8AIsmsepFjiYJ7IxQQ9SKxubPx3jx/HgzqjkBZYx5DE4oUWBcLR40ss0Q6YbHiCJeGRUYPAFnZDt8+l/gIuWZecCyamFMHqvfevGJOBMEzUcWASsDeZ5gIU9oH3EqTPEXFx76tGoqRmyK3gxOJiq1ls8Q1+i2Y/azpxyDBy9tb7FtmVu9lMrHY5eyDPH6e9IWDZ2yaUh8DULkMaUjJOiwkgfwZrYSx5QNCATmC1ljNExd2jPG6Ok5PwLUl7us+zVs54AdPj7WE/mfnpAawJDZ7rn5M/40IiA99ZDuhY++16DHbm+GwS+DIFImQuQijxOO9/eLCpbG8hmelSdbVBzzE3+gNaISDj3qrJb4qQScEPOIY3NBaebKcEmeSqHcdLUxwz9YXTPKWXaTbwPChVMtrPjg8ljqjHFN1Iih4PSeGx7cisfTXnMLcGq3J8Gb/1Q/txMti9BLHFTrIHrAv6ci7ofLqKkaylq8HqWJb99zfLnvNHhALcJ5Jf6EkkMVpaqUhaUb7uLwwgVt0cPRbW4AeHquCQNCnQ45/PjOMkFZOo95djdgGWv/OAIOpE2mJoMQmCusfw3xV/qH9MbOCuXbBV6uqPYUbMIYzVckEeGNocBwajhZf2G15jiOHIgOQJRNa8udPDmrkmhi0bIcBrNtOf0TnRCqC35RBl1x9PpMulMRvsZud3VR+8yw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(86362001)(6200100001)(26005)(4326008)(9686003)(6506007)(8676002)(2906002)(7696005)(4744005)(41300700001)(6862004)(186003)(64756008)(66556008)(66446008)(33656002)(38100700002)(5660300002)(478600001)(8936002)(122000001)(52536014)(54906003)(71200400001)(38070700005)(66946007)(76116006)(55016003)(316002)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tHe2XJJiHipcYwFlAQMfL/pP0nh/dz+WD/+xSSxDsGJjsL8WWB7ccAyjI2zG?= =?us-ascii?Q?csqh68h8wVrqv3NoI/0nao6b/0aT1HBmtfEnnJj1t5j3i69ZjWBXK6FkzhXP?= =?us-ascii?Q?SkYf0H1x77tI6F3WPlQfQRvRhG/oDHCayDXYKe4rauTFKhPvXBzgFcfvrwFa?= =?us-ascii?Q?R2oUSPKRnhaiVHFdeK+4rKIgY25VOk3heRqHOI7ZwCYlW3XBt41doF0wFzZG?= =?us-ascii?Q?XO/Wh8GK31WNpFLzG+dLp2gsg6wqDabJDlPgpgkOSCZSMgdvta5NM+1twfOr?= =?us-ascii?Q?m0UAb8QSPvKgI7MEweIWhUbieyh5wR3bDYcd0gXJu+foVr4oibvxxZh1OFm7?= =?us-ascii?Q?NkqwDXN2BhnrQP+mEsJiXlXnsr7k52Wot6UnSITdzuRkFVEXx6qXF4LCOb4H?= =?us-ascii?Q?5rEVCSJeA5KT1AzUQYri5cfrIAvye9XOFkC3F0GK0cQzNny+QpNWEtrxXtTn?= =?us-ascii?Q?Gy/ccJCEdoMBZsyVnB/i8q4nMorMPHN88LC83rECLoslZFVgePGEpqWpPzG2?= =?us-ascii?Q?K2nxxuil4f4as7dhDdPKNBoKXMMiyMkBANrXYLqTXN/7aN7Q0gJd/cNESU2A?= =?us-ascii?Q?l8o3NEsCbYrPSFSA1S3li4f5KXysrG5kfUwLn13Pu1maljVEMl3esqvxZ/8P?= =?us-ascii?Q?rv5ZPQ8flI3OMMeGMHwLLOs56owxgdHAZM5G/TAfxs6zgolnlEyAi8JG5X+s?= =?us-ascii?Q?hfeZCbNCZSOac45AWRxLkjp+/6KPG/2TvjzSIsSBIBysjMd2PJBB43iE9peV?= =?us-ascii?Q?8guofHPkpiuElWCM3s2wOf4Stw/QdqPvLaZiYWiUWt2V3PMwArK4iUSmcbXH?= =?us-ascii?Q?Ywcmg9WYPgYolIVRbwbQ1motAp+tEVc4lofVqDBR20871dYRACLoZBYNynd2?= =?us-ascii?Q?hyVsGlxTC1dYHkOwN0WTJTmPJ9AH3ZOzRcI8zEQkVAfLxbn2OzvNA1lfW6jO?= =?us-ascii?Q?3hmsicqSs4lKk7nLs/A11gQOZxO4N/05T1DQStWyZQgWl8Fp6td5aJWIz7b/?= =?us-ascii?Q?0mnfECmM9fffHxdXDLyE032+HZS6NSWvL12bfPoJPr7g9xqW+M4agOl+R2Wj?= =?us-ascii?Q?YybGN/2aTE4JtC/HgPziTQLz6CHcpFu5XSUL3v3xynk9S7VyE4RWhMK3KKYw?= =?us-ascii?Q?0DzdEFMrkd1nuRAGrlbhMtI11gGFxT29el6Ld468p8Yxde/LXcuDwuzwIoKt?= =?us-ascii?Q?xkkXKbCgS48buq34HFwknwKQy0Bf6CWjOCIqPFcJJFX1oDMXmdiWtjiz/nr+?= =?us-ascii?Q?XauBenbti1//TOFKWrD1gV2jJlcIU3oi0GbBB9kWENp4rhh9UomC3RoBldsW?= =?us-ascii?Q?zQ98gwsrm+HMK/m1V5FgRhLvvyKbgpxprr0HlPpiRF3/zclXinBenes0KjYg?= =?us-ascii?Q?8TU2MdVwsKbxaKtNwCiDtWIelmzrmpPFWnntl2kdKCaDjI7jc6LMx/uWWxBN?= =?us-ascii?Q?M1sXXPMm/FrAqh1cjgMpaaPVXMXZT86GtkQ9bzLeUf5pwJ+yvQgi21tJKawI?= =?us-ascii?Q?JkMzujlQRU8hrNHCTaIfgNjEgkpF81RYgZP3keTPt/mwG6Q0YdRWE98Ofje1?= =?us-ascii?Q?2+G7zBU9zx2OXVm+vQFtfrjhHJYSsiSRMGX+4LgD?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB42973A8000A347FE631FCA579F7E9DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76032c41-e33c-4cde-0fbc-08da8ff5b517 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 10:51:09.4137 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IdfZjSdniEfS7wg1pxPBfTb2uijC2UX/D8OhrSo/SCmDsxp2LQ3iFF/eOJINp2Hasb7dhAg/OXTHTeWmHIrGZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6217 --_000_DM6PR12MB42973A8000A347FE631FCA579F7E9DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] I am continuously getting following log when I play a file in Dom U: 06.09.22 16:16:38.071 | XenEvtchn | DBG - Notify event channel, port: 76 06.09.22 16:16:38.096 | AlsaPcm | DBG - Frame: 0, bytes: 0, state: 3 06.09.22 16:16:38.096 | RingBuffer | DBG - Send event, port: 32, prod: 704,= cons: 704, num event Frame and bytes cannot be 0 for every frame, right? Can this be the issue? = What could be the reason for this? Regards, Jyotirmoy --_000_DM6PR12MB42973A8000A347FE631FCA579F7E9DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


I = am continuously getting following log when I play a file in Dom U:

06= .09.22 16:16:38.071 | XenEvtchn | DBG - Notify event channel, port: 76
06.09.22 16:16:38.096 | AlsaPcm | DBG - Frame: 0, bytes: 0, state: 3
06.09.22 16:16:38.096 | RingBuffer | DBG - Send event, port: 32, prod: 704,= cons: 704, num event

Fr= ame and bytes cannot be 0 for every frame, right? Can this be the issue? Wh= at could be the reason for this?

 

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB42973A8000A347FE631FCA579F7E9DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400233.641937 (Exim 4.92) (envelope-from ) id 1oVgIN-0006tj-9Q; Tue, 06 Sep 2022 21:39:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400233.641937; Tue, 06 Sep 2022 21:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIM-0006r8-OK; Tue, 06 Sep 2022 21:39:46 +0000 Received: by outflank-mailman (input) for mailman id 400233; Tue, 06 Sep 2022 21:39:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHT-0000Cs-7F for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:51 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130087.outbound.protection.outlook.com [40.107.13.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 253ff66f-2dfc-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:54:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB3356.eurprd04.prod.outlook.com (2603:10a6:7:8a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 15:54:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 15:54:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 253ff66f-2dfc-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TIPnV44K0ew46faJv1fCjxhnZZ6LmTl6/ooqtVAx62RB6xVWZ2u3Xhewsu6XyhkGudBtA/QztbnP/B8oVviBuG9RTVlMlAVviIPnVa9k1E+B9NoGX/KvdavheivwFmNAG0cSnwJl6VWqkkbmRs8ObB2uRMMTnofcmiD+FhES0N1ijiJbrc0dPl8++zaeBmo4ff7eynFW6B94iGGXlrLLJqIFYLv+LaZaeWbuqzNfe48hqBy4pBVABvszNSb6qwn/MtY98x49AyUJhNUGxLaDBuDH/qUqWNUfZuYysxdSQg7Fjm4+tSQhorqsFs9lAwWobm6IPyt/0nl++7NDWX8ABg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1iDBAHzV9MbG1FBjlh7WM0trQYZ4f3zj/7HPeYAcyrE=; b=ButTz2teH3HoO2PMOb8OqkqALGEpZRqnAk+LMQsk3/VDyJy4tf362tppy5AlG0hjAGnHgDivaA4Y/MEr6dxxUrR18CLJejB0pXXhGcQdw9KllFMAkqGzYcQnAfq3jAaamxI4sEwNSFIrUfLbdL11fmsX9p5owylR9OukFm3rqFskyddOCUKFHextvWx6WcOjVJG66J1zkIAb3HShgSurI5eIIu9shsXxZi89vE3UbGOfPvTNJDVwcDVLneMVWbd0nFQQKd+FRoiL65PHR/D2PTwOeEVz6mNhu0yD0YrCrD8DJEr+tXLKT0F4co8zs5i9ERbcANPQzULY5SD/KvbIIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1iDBAHzV9MbG1FBjlh7WM0trQYZ4f3zj/7HPeYAcyrE=; b=5mltI3BqFqD/ncFNdaOVNjAmsSw+eHAG24AWI27+uzizAXiAEzcZuhbAdrfxq43bpoDgZbN/n3a9lm0WCWcVpG705Or6xZxjZYOgxPMju4cylViFvZYZ7bgNcDGZp981CyJEUML0vx5hojVkF/8VRAPQzq+zaUidGDdlvho2bipgbHRY/gn4SraNwuJ1g5n6+L2AKFMTuFQUpjjQlwLxnHYmZNcuQlEeWWBJSq0YAZXW89OJybPdjL3BLZLWYtdgfC6ppyUll91aBZjXOMPXOyn3z/hAKtv3iHqk6EqhuX2XdPoYbLpp5s2aB5Oas2bb1HkfgL0sfahxa2J4c9IxwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5289a154-177e-4805-2123-f5f2226394cd@suse.com> Date: Tue, 6 Sep 2022 17:54:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <08c9df71-0470-c9eb-94f0-776eaacefa5b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3272b511-efff-4b6b-cba9-08da90200899 X-MS-TrafficTypeDiagnostic: HE1PR0402MB3356:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uKTTyzd14e/rkLKEvYVOT6004T0HR0jpu6hghjtXttGYm+EC61jNa054jQoSfllETndc3oHfKFVcUtmmingO7pc4VG6QEpDuOo1vlZixz8ZHNLbJasGQX5v5INTA8cb9zUXT1KFBRAkoBQNA7nZP78fz3FFCwU4vtJAI6RrwbR3M+RgUNNRSheXeoqR07Pln5RC/DHgeelRZRBr6nzGhXww5v2/2ieoHRqFGxOscP4lIPxmE+o6YIVN6G+DNyWtA5jb9e7OFRgQjNhppxWZDauHjrWqDs+L0GPDhY2A0jRoqaDcaf74DHrG/2RuIxxtMNWNN6x/ZPHI3n5usYoBKbcwqhAVS4gUAgIM9CAacuFhpfdEdXKqYT7UhJhga34nz+Tt2dTKMQ9yUl98F9X6ISbK+o+LpGQOjpxOwbTaCPCu8yw84o/D/FRpFjqOypUEbVShdHaqpw1nNzXVd0Xq86jrs2S8Xu1OkeQduUTpoW6uuo+KdxVWiAJNCFDbTXebg2tR7He6iJvfJBXv/Kd6zc6m2MwOrnlU1mWExCJOLzWoudSG+09e0M3kBPItl3f53PZxGtgbsbi+2Gfl5xhcp2kUzCbfDv/dSyXkRxPaskFvLHGW3hOSXQOvH+qpy1rW1yN46Jy4J7EajZzhLAZzmWEsmSInDvhbJm5w2M5UC4YSSJ6kqLcbsGDpwjs7IpNWVBOGAwN0WLt1hxpOaKokQuZp43QcJktdNN2cm/OOs9jnJf0QlWQh8jBObuC2B3tO9sZPe27KhFeNheuK+dOJhO9Y69xTDF9j/MxXTEoV53Ds= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(376002)(346002)(366004)(31686004)(53546011)(26005)(6512007)(6506007)(41300700001)(2906002)(478600001)(38100700002)(6486002)(36756003)(66556008)(66946007)(54906003)(6916009)(316002)(5660300002)(4744005)(8676002)(66476007)(31696002)(86362001)(8936002)(186003)(4326008)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjhqRjhTc2NrNnl4ZVNFVkpTQWdEeEk5NjQrVldWUWRUek5jcVUxUU15am43?= =?utf-8?B?YTFHU2VmQ1ZzNFlGT1dEQ2dDUXltSllkSm5xVDFaQTNoQlNJL0tydEhXSGFE?= =?utf-8?B?NjRvVFVqNFR1SUROampoR1V4TGJYdmxZdDU1QTZlVnlRN3ppNFhucjlCdE5Y?= =?utf-8?B?V0NzV0FFNzg2NGczcFd3UTdwY01qc3dOYXBzWmVjK0I2bTlTdTJJbFdpM2Qz?= =?utf-8?B?NVJmbkltdmM5ZWNRbk4ydHlGQWI5SzBRdk1tY0tPTEdBUDB0clJBSjdXR2xL?= =?utf-8?B?cWttc2Z4SjVKK0N6amdFVXZMS2hEUFMrV1dNRXVYUS8wVDZqVjlrN0ttclFq?= =?utf-8?B?dnUveDg1YmxSU09INjRMeE92QW5uSTNmM3Q5L3pIZGhxdURaVEtGRjhYZ2JR?= =?utf-8?B?dytOUVZkcVRjQnBtL01DL1ovNUFXNFU0WVA4SGRTZDdzc3MxbnRDd29rcGho?= =?utf-8?B?cFZkSm5naVdwU0x2eEJrNHhwMVNmZDVyOEJPQ21tNS95ZUVWL0E0TlVlMFBn?= =?utf-8?B?S3FQcG1mRjdXNGhyWVhFWmdEY0NhS2pRUGFWR1lkQ1lZTFg2V2J1ZE4ycnlW?= =?utf-8?B?V0QxYUQ0OTI2NUpBVDFCQ21rZjk5UEh2clhqcWpHa3ZUWnFJNEcwNWd5bTJC?= =?utf-8?B?MXdhSWdRN2l6K2UrRkZEejRONVZmbDlnalNJTkhWMGlKR0V6V0JESVJRenA5?= =?utf-8?B?NEg0cW0ySlRybTVyMEFMb3R4MVRCRmsyOE1ybGVPbWxkRE9FOGhKUGh3cW0y?= =?utf-8?B?MjFMUTdXV1JBa21iYTNVVE5xWDhreVlTdkxxVXA2OWJ3WVVqVlJXaTh5NWJH?= =?utf-8?B?eG9VU0tFMWdxWWFCRXFKTEd0a2R4NlBGUzFRRTBDTTN2Q3VHdXdiVm83UHdW?= =?utf-8?B?N0NpemVPQTJYY2J6d1BlT0E3dEJEQmx5YUhDQlVUcWQ5RUZYNGJETWI2UlIy?= =?utf-8?B?UlZ1N01NQ0VzS3N5M0FNNXBxVFliR3JUYktBa04va1lSZXpOeG5WVUFkRXBz?= =?utf-8?B?ZlBwaTFML3lCbWpIRFJGaXZIc25CVjZXQzBaYzRBbkhYU2hPOVpUTzRseGZJ?= =?utf-8?B?emFCSlBIUDdaWG5hR0NuYnZCcERod04yQUdoYVZIOHMwUHFORzJPaXd1NnI5?= =?utf-8?B?TlVGalZLanJhQ0NZaUVWckw2dFRiYzIzSW5YbUhPWTdsUC9rc3ovZGp2ZGRz?= =?utf-8?B?UlE0NVpMbisrWVhVNVFGQTF0NU92eUNtZVh4dnp1VjU4dXFLQnIzVFZZZXFS?= =?utf-8?B?TGQ0MFZpNFhPVTEycHBiYi9iV0JLOE5WL1pvTnIrZ2MybUtDOCtLM2VJazcv?= =?utf-8?B?QUxQMVBvUDFxT2lsa3BqQUxyQkcxRmgzVDZTdDZhcVp6NDFLeUxaUWtBZTNJ?= =?utf-8?B?YlJPdlZGQ3N0cUVFYlhDMm05MW9nUThjYVhnY3lvZ3JPMjE4VGZxbGZXZDdu?= =?utf-8?B?Zk4rS3kxVGU4SE1rL1pvSG1iQ2VRRElOaEVKUXRSMGV6WjZnNTdMa3BlajhX?= =?utf-8?B?TnBZd0kwQkVkN0R4NElPditnak13dmQ1N2g2c0kvOXF5bG9qREJJbU54VWlp?= =?utf-8?B?Ky9DRmxzZUVRaktpR2JPVUZPN2YyRjFJam52YmFQYVorMTVZc2czODlSV2VH?= =?utf-8?B?QVEyMDNGdTFyREcrMlVvTXFXTXZiMy9CL0tibG1IZVUvbThPejgrSU5VK0FP?= =?utf-8?B?Zi9uNUIyVm1HVXFacTVIOFlhTi9ZRVplRW1PMm9MZkQ2U0Z5ekRGR3laM0Z6?= =?utf-8?B?eG5QQU0zcDdXakYybVBOUmQvbi9pVkhUVllpMkJ3RXc3VEJvTmF4ZVFBdWJC?= =?utf-8?B?Z0MySXh6RWZrd0VCY2Frc1lseUFkb1l4d3E0SlIvdGZCTFo2aHlvaVhhM0J4?= =?utf-8?B?ejExbXFxSUZtOVNBQXo2NzVJMEU0by96UVZJUUQ5Z2dPTm1IT055YlN3OVc0?= =?utf-8?B?Q0NnU2lQMEZnRnhpZUxENitnZ0YrU0hjNERwSGcvWjllMlZnaHhuMU1SZTUy?= =?utf-8?B?emNCdGNvWmNpbWFQYzRIaW5hQ29ScnF2SmNjb2VqYzFVZGErdStFVCtIRmpE?= =?utf-8?B?blRoUi82MUlLamplRHJXMEJ4VncxL2w2OHFpczA3SVBzSzgzeXhuQnc1UmYw?= =?utf-8?Q?cjcSqUzh7iIAFrR19oHiOj3jW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3272b511-efff-4b6b-cba9-08da90200899 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:54:08.5558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pwpQLdD6uRqScWhTlvHpNXgHJ6OSSJa482T1HxXNPsXP5U/KIv2RLpUEAtYu+5d8ghcgrJ2eDcAluFwNeutj3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3356 On 06.09.2022 17:46, Marek Marczykowski-Górecki wrote: > On Tue, Sep 06, 2022 at 05:07:27PM +0200, Jan Beulich wrote: >> On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote: >>> --- a/xen/drivers/char/xhci-dbc.c >>> +++ b/xen/drivers/char/xhci-dbc.c >>> @@ -245,6 +245,7 @@ struct dbc { >>> uint64_t xhc_dbc_offset; >>> void __iomem *xhc_mmio; >>> >>> + bool enable; /* whether dbgp=xhci was set at all */ >> >> In dbc_init_xhc() there's an assumption that the "sbdf" field is >> always non-zero. Do you really need this separate flag then? > > Not really, sbdf == 0 means "find Nth xhci", where N=xhc_num+1 (and > xhc_num can be zero too). See the "if" at the very top of > dbc_init_xhc(). Oh, I see. I'm sorry for mis-reading that code. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400235.641942 (Exim 4.92) (envelope-from ) id 1oVgIO-000748-27; Tue, 06 Sep 2022 21:39:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400235.641942; Tue, 06 Sep 2022 21:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIN-000710-Go; Tue, 06 Sep 2022 21:39:47 +0000 Received: by outflank-mailman (input) for mailman id 400235; Tue, 06 Sep 2022 21:39:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHL-0000Cs-69 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:43 +0000 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [2607:f8b0:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77817fd5-2df6-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:13:31 +0200 (CEST) Received: by mail-pl1-x62a.google.com with SMTP id u22so11572406plq.12 for ; Tue, 06 Sep 2022 08:13:31 -0700 (PDT) Received: from leoy-huanghe.lan (n058152048222.netvigator.com. [58.152.48.222]) by smtp.gmail.com with ESMTPSA id cp12-20020a170902e78c00b00176ae5c0f3dsm4612341plb.171.2022.09.06.08.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 08:13:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77817fd5-2df6-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=jA89J5PXWFSo0e0TqoV7gOHS44VOEBuMtm2R8Su092w=; b=cp2rtOrnzJS3wbldxOBy+V7nGWzxJIjTr7pwwkD0dyDexznSGikxJRK2/RzvLruA0z E8H9PSYBBQCpo4oJ9h3xdPtkRgaSeKUEjQwXyDXffk0WfQPi2oDNMzR+VI/xJiMHNtBD fKEtVgDoG7NpQKnzwV1Is1k2koaW44tUhY1OFMqXlvaXUKe1s+bQlfeMJBp3d9YHgynu IIznmJ6v+DnQ++XXPtpNZzxBrwArAAXjsmqZpkrmKKmzELd2EsABKSMkkHUzPWgJ1NLY N63bMg8XkRc20GX7QaiDXS2t6juTD97kzcUDP6DUe1CoL4NYx3jYDgSLNuCH3TD1z3EP SrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jA89J5PXWFSo0e0TqoV7gOHS44VOEBuMtm2R8Su092w=; b=6NIdTXZpfdbKbU9Sn5jSAp/v/BOXGDyYTL471NT1UwC1FxuAVQvJNnk0/LQQEwBNF6 I87L9IXADzem0zsseiJVfI/vyfoixGvHGtZZ0Wl9ODNzXnq2VefJ+yBTXjoFL10NSQle YetMio83uKfKI0sWbemd68XA5KFoHwjQn/18Sf1x6DYeSFmb3K/NkWvWZ9pm2bG7C1Z7 9iVPDJEksEClmk8zy/QEIO5CjWfv9YcxC071AYhpcIkpgrOkU3ijEsbd6NeXTmjkqzDX p5AVHmvhvbsH/0Qgc3hs8zD3OlQ/hRXnNT3Hi0DwS6RZG1+8LbWuGRCDUbZ8jtYwH7YE Izrw== X-Gm-Message-State: ACgBeo3hsLo0e/tTXD2UCimuZAm3+WoeSZ+AM+TsJFDHwwz2Mhy+DCUc StG37ukCxu47Xx+/4bu33LOVuw== X-Google-Smtp-Source: AA6agR4WewInFzFmv6YhxACWQaFEDh/Lc3sUXlRsCzH7xXMcaUoc77SE2+K7/mZAaAGR6MRmT7o+LA== X-Received: by 2002:a17:902:e844:b0:172:d21c:3fe2 with SMTP id t4-20020a170902e84400b00172d21c3fe2mr54473636plg.43.1662477210088; Tue, 06 Sep 2022 08:13:30 -0700 (PDT) Date: Tue, 6 Sep 2022 23:13:25 +0800 From: Leo Yan To: Marc Zyngier Cc: Julien Grall , Ard Biesheuvel , Jan Beulich , Bertrand Marquis , Rahul Singh , Peter Griffin , xen-devel , Julien Grall , Mathieu Poirier Subject: Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table Message-ID: References: <871qtcsacd.wl-maz@kernel.org> <12a8c169-55aa-5e9f-19f8-acd77ea2a8fe@xen.org> <52f24132-ba2b-d4ab-ebd0-613f673b5658@xen.org> <87r10puiey.wl-maz@kernel.org> <87leqxq6qp.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leqxq6qp.wl-maz@kernel.org> On Tue, Sep 06, 2022 at 08:53:02AM +0100, Marc Zyngier wrote: [...] > > Okay, I think have two questions for you: > > > > - The first question is if we really need to reserve persistent memory > > for RD pending table and configuration table when Linux kernel runs > > in Xen domain? > > I have no idea, and really I don't want to know. The architecture > doesn't make it safe to reuse that memory, and the driver does the > right thing by always reserving that memory when the FW is supposed to > support it. > > The "oh but it is safe on so and so" approach doesn't scale. If you > want to have such a thing, just convince people at ARM that it is > possible to implement a GICv3-compliant system without the RD tables, > get them to update the architecture to allow this scheme and advertise > it in a discoverable register. Xen could then implement it, Linux > could check this bit, and we'd all be a happy family. I agree that my patch is not based on a scale approach, this is also my concern. To be honest, convincing Arm GIC team is a bit out of my working scope. I am working on automative project, when I saw verbose log with bunch of kernel warnings with Xen, it motivated me to chase down, this is the main reason I tried to explore some solutions at here. > Because that's really what this is: it isn't that you don't care about > the RD tables being reserved. It is that you don't care about them at > all because they are never used by Xen as the GIC implementation. Your > approach of "huh, let's not reserve it" just papers over this. > > - If the first question's answer is no, so it's not necessary to reserve > > RD pending table and configuration table for Xen, then what's the good > > way to dismiss the kernel oops? > > A warning, not an oops. > > > > > IIUC, you consider the general flow from architecture view, so you prefer > > to ask Xen to implement EFI stub to comply the general flow for EFI > > booting sequence, right? > > If you want to use ACPI, you use EFI, and not a vague emulation of > it. If you use DT, you can reserve the memory upfront. The various > alternatives are in this thread. Given I proposed two fixes, one is for Xen and another is for kernel, but both are rejected, so I would like to hold on a bit for this. Maybe it's a good point for Xen maintainers to review if it needs to support EFI stub, or welcome any other suggestions. > > If the conclusion is to change Xen for support EFI stub, then this > > would be fine for me and I will hold on and leave Xen developers to work > > on it. > > > > > > [1] https://lore.kernel.org/lkml/20220906024040.503764-1-leo.yan@linaro.org/T/#u > > > > > > I'm totally baffled by the fact you're trying to add some extra hacks > > > to Linux just to paper over some of the Xen's own issues. > > > > I have a last question for why kernel reserves RD pending table and > > configuration table for kexec. As we know, the primary kernel and > > the secondary kernel use separate memory regions, > > No, you got it wrong. Only with *kdump* do you get separate memory > regions. kexec reuses all of the memory visible by the primary kernel. Thanks for correction. > > this means there have > > no race condition that secondary kernel modifies the tables whilist the > > GIC accesses the table if the secondary kernel allocates new pages for > > RD tables. So only one potential issue I can image is the secondary > > kernel sets new RD pending table and configuration table, which might > > introduce inconsistent issue with rest RDs in the system. > > > > Could you confirm if my understanding is correct or not? > > It isn't correct. > > - There is no race condition. Once the RD tables are configured, they > cannot be changed. > > - When the kdump kernel boots, none of the primary OS memory is > reused, so it is safe to continue and use the same tables in place > > - When the kexec kernel boots, all of the memory except for the > reserved memory is reused. If your RD tables are used for anything, > you'll see memory corruption as the GIC writes pending bits in the > pending table, and you'll be unable to configure interrupts > correctly. This gives me impression that when do a power cycle, CPUs are reset but GIC is still alive, so for every booting time the same memory region should be reserved for RD tables. To be honest, it's a bit weird for me that if a system cannot reset CPUs and GIC together. > In conclusion, using kexec with GICv3 is completely unsafe if you > don't reserve the memory allocated to the RDs. > > > Sorry for noise and many questions. I understand this is a complex > > and difficult topic for me, and it's very likely that I am absent > > sufficient knowledge for this part, this is just what I want to > > learn from the discussion and from you :-) > > I suggest you read the architecture spec, which has all the details. Thank you for many suggestions! I read a bit for GICv3/v4 arch spec at last week, but I need to do more homework. Thanks, Leo From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400242.641956 (Exim 4.92) (envelope-from ) id 1oVgIR-0007j1-2K; Tue, 06 Sep 2022 21:39:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400242.641956; Tue, 06 Sep 2022 21:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIQ-0007aj-2A; Tue, 06 Sep 2022 21:39:50 +0000 Received: by outflank-mailman (input) for mailman id 400242; Tue, 06 Sep 2022 21:39:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgH0-0000Cs-2n for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:22 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c744202b-2e10-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 20:21:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c744202b-2e10-11ed-af93-0125da4c0113 Date: Tue, 6 Sep 2022 14:20:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662488510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/bRlcVcrWdQKJLJipKk17c91ZfuMwNoEsJqygzANM10=; b=e2VD/HcikFLJhe0V11ErS/Oin4ybn/TXkbGiMkiUOxLxKEWpdcoX4otQ2quaeh2xN9tkEz gJSSZJlOcx5MH/FwRLBQM+nMzvd03D3L1jInmtTiFs1YUwF1FG/7tFAS2gRVdaASeb5tb9 7SVVXyTQbLTanYnVJHubYmXd6a/lpqA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220906182058.iijmpzu4rtxowy37@kmo-framework> References: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Tue, Sep 06, 2022 at 09:23:31AM +0200, Michal Hocko wrote: > On Mon 05-09-22 19:46:49, Kent Overstreet wrote: > > On Mon, Sep 05, 2022 at 10:49:38AM +0200, Michal Hocko wrote: > > > This is really my main concern about this whole work. Not only it adds a > > > considerable maintenance burden to the core MM because > > > > [citation needed] > > I thought this was clear from the email content (the part you haven't > quoted here). But let me be explicit one more time for you. > > I hope we can agree that in order for this kind of tracking to be useful > you need to cover _callers_ of the allocator or in the ideal world > the users/owner of the tracked memory (the later is sometimes much > harder/impossible to track when the memory is handed over from one peer > to another). > > It is not particularly useful IMO to see that a large portion of the > memory has been allocated by say vmalloc or kvmalloc, right? How > much does it really tell you that a lot of memory has been allocated > by kvmalloc or vmalloc? Yet, neither of the two is handled by the > proposed tracking and it would require additional code to be added and > _maintained_ to cover them. But that would be still far from complete, > we have bulk allocator, mempools etc. Of course - and even a light skimming of the patch set would see it does indeed address this. We still have to do vmalloc and percpu memory allocations, but slab is certainly handled and that's the big one. > As pointed above this just scales poorly and adds to the API space. Not > to mention that direct use of alloc_tag_add can just confuse layers > below which rely on the same thing. It might help you make your case if you'd say something about what you'd like better. Otherwise, saying "code has to be maintained" is a little bit like saying water is wet, and we're all engineers here, I think we know that :) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:39:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:39:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400244.641962 (Exim 4.92) (envelope-from ) id 1oVgIS-0007zL-11; Tue, 06 Sep 2022 21:39:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400244.641962; Tue, 06 Sep 2022 21:39:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIR-0007tU-EL; Tue, 06 Sep 2022 21:39:51 +0000 Received: by outflank-mailman (input) for mailman id 400244; Tue, 06 Sep 2022 21:39:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGw-0000Cs-1s for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:38:18 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a48817ac-2dc4-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:16:52 +0200 (CEST) Received: from MW4PR03CA0060.namprd03.prod.outlook.com (2603:10b6:303:8e::35) by CH2PR12MB4327.namprd12.prod.outlook.com (2603:10b6:610:7d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 09:16:53 +0000 Received: from CO1NAM11FT087.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8e:cafe::84) by MW4PR03CA0060.outlook.office365.com (2603:10b6:303:8e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15 via Frontend Transport; Tue, 6 Sep 2022 09:16:53 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT087.mail.protection.outlook.com (10.13.174.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 09:16:53 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 04:16:49 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 6 Sep 2022 02:16:49 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 6 Sep 2022 04:16:48 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a48817ac-2dc4-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zrcud4zjm0uLzTOtZtqnpcTpBxy39XYDL4qU2Touq1z8gGCjPNSjxNhwN3myTikb0aWtEA3vUCK+BZyknARs+VwiDZrJAr0kAEnc7VFjST0p31cv/9DaCi25SiSuJ2HiwXy6WzRJQ5wcUeHqG7hxibJfJZzUt50yXYOzKNjq0XPGchGbstiascCPRJ3un77gLjmagumJoKwfndMPTa5PNLowg0incw2FW0C8ZAtnuNgDAmWAT1BV/vFOLaHKhhDxWKitd5RAmROptyk0zNYf4liH4p8hx66PF2XLjkEIo8Qan0OQ6/fiLO3OrMpsMn/rlpKxxVJ3N6qAUk7MVWLyPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zcADeNm6ohzugDn4jUd/ihSrmEXvgLlWBWbXBvvAnoE=; b=dMbXrn6E0y5QcDPTveZ1CVcAHaV1Rcm8Ywq5bWK3s4Ff61Ka4meYj2/CGKFC3NbnlVxqEzxmQSE6VLhdohgZwZxefFlPyEXmbyV3uuxGR7xm8w2SOsg2kb0bioRv1tbuRyB3W2p1Vqt1zmvsrV5q0825GGN3geZ/VDaccUSxgpIuBZCeafsbRs2yhtDntRuQBgvdPLMRPCItyzp75NI/SUhKK3N3sjHoMf7c/g/Ogg1ViJKpQDinUtym8f72TlenXMTsvt9togFHCbohHYUpR9j2KJF4sXspAsaSW/xuDyB8WRfvj+o6ZjK3GemmGDqf7h0NqVb+vf0663nwDIs7Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zcADeNm6ohzugDn4jUd/ihSrmEXvgLlWBWbXBvvAnoE=; b=V43bjm45nuh3hVpbS2VH+IEXRlX7/TW4jWgrZvyzi209+IsoBca2vJ9HLQypesix3VVKcGzMwPmJUSrDHLbJ1xSWwqsSXFfuTnmjN7pzaqmUTVzcffeZw3g4xIYOKqH9KCz2Sg2yTgOPVF1BU2mcUsZD3i9MIzLU8rvDkji0qdk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <606db72f-2283-6e37-4920-a21da1d70b3d@amd.com> Date: Tue, 6 Sep 2022 11:16:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [for-4.17 3/3] automation: Add a new job for testing boot time cpupools on arm64 Content-Language: en-US To: Stefano Stabellini CC: , Doug Goldstein References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-4-michal.orzel@amd.com> <98b712c1-2a02-9baa-b816-3c28cccaf74e@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bfdd8f3-0238-4bf3-9ac6-08da8fe889f5 X-MS-TrafficTypeDiagnostic: CH2PR12MB4327:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0GoFJ9vkGCYiJ0cSolY6ywRgY0cqIpqbgT9R3K4Baw6uRq9ALt8ga8VZB77LthXac7tTyIIfB9cg6BbHNQi2CEfOzd+3XSRakWMjhC+CqBnRd5vEH9+H2M4+OmjBV84+ae4vCdFnFnegRYHXseEqGL042+dfX6rXboqnEmddrCvcGjq2uDAQGREq1OIcLVBhMlNmVVd6wXklZVGWAPFHu+4vYAGqhAitHR6jElL5tPmxpmuUqi4tgqkH830eNQrGmCo1lbgLXlshDNIwfqijtHElRx5V/E4s9XwRNnVrqfVwkochwNgKHy88quqVsGWkCWNR5tPUmQyhnpiw7MF1qj9sYM6/Dl/8Ec0KFE2uvfgEh2T1n2+VfP73jy2hr/xaZn3FBp/hc2/ldXtjlHcoELTIcmQ/qR3SsVpClTVAVlC2ChtncfycL8h02djm9dqHae5O7qDbnXWwK9QFJNl5q0E+H1Q3Cwf8avGtZgDCOysqx+cWIPEfuaTWIahMvZKdw/Gy5V9eVS/sDR9ca9H8TYRhoB2H/8JIogSXGXZy5081o64kZMUUKVVdSjojkw0D3R/3ONbMLgPw/A9R2AwNE9LNXhMxfiw1+fc+6aGk90IEiUdtAzO4xiQnx2BzgUvRJBQLIcG7/Nx2W4wc/uZysvUTBYoq0iFCt6Iyes2wmA9HvGcO6Qd9pUHHxlkvnVxfcXbcUE88MUui+8rdtJm/KLE0RV2UaRgDcgQia//OAJ/pR8T62I85BtUy94i4X5gypaqXqM1YCi8GCuk5vkm6gJUZuJAflEybK6mCpEO/ixC1t3gkfBY8wcfwBHgS9f3cjP3vbcFujDj9Uow8mtrMB8uOqIOQTICdPO7qx23gzq0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(40470700004)(36840700001)(46966006)(26005)(2616005)(83380400001)(336012)(40480700001)(2906002)(44832011)(8936002)(5660300002)(41300700001)(36756003)(86362001)(31696002)(426003)(47076005)(31686004)(53546011)(478600001)(186003)(82310400005)(36860700001)(40460700003)(356005)(70586007)(6916009)(8676002)(54906003)(4326008)(316002)(16576012)(70206006)(82740400003)(81166007)(157313001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:16:53.4230 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bfdd8f3-0238-4bf3-9ac6-08da8fe889f5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT087.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4327 Hi Stefano, On 06/09/2022 01:21, Stefano Stabellini wrote: > > On Mon, 5 Sep 2022, Michal Orzel wrote: >> Hi Stefano, >> >> On 03/09/2022 01:49, Stefano Stabellini wrote: >>> >>> >>> Currently this test fails with: >>> >>> + fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled >>> + [[ boot-cpupools == \b\o\o\t\-\c\p\u\p\o\o\l\s ]] >>> ++ fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle >>> Error at 'phandle': FDT_ERR_NOTFOUND >> My bad. The qemu version used by CI does not generate phandles for cpus. >> So the fix is very straightforward and requires putting custom phandle for cpu@1. >> >> diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh >> index c2184850293c..158d5665d71d 100755 >> --- a/automation/scripts/qemu-smoke-arm64.sh >> +++ b/automation/scripts/qemu-smoke-arm64.sh >> @@ -50,8 +50,9 @@ fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled >> >> if [[ "${test_variant}" == "boot-cpupools" ]]; then >> # Create cpupool node and assign it to domU0 >> - cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" >> + cpu_phandle="0xfffffe" >> cpupool_phandle="0xffffff" >> + fdtput binaries/virt-gicv2.dtb -p -t x /cpus/cpu@1 phandle $cpu_phandle >> fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool >> fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle >> fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle > > >>> Given my other comment below, I would leave this code as is. >>> >>> >>>> +if [[ "${test_variant}" == "boot-cpupools" ]]; then >>>> + # Create cpupool node and assign it to domU0 >>>> + cpu_phandle="$(fdtget binaries/virt-gicv2.dtb -t x /cpus/cpu@1 phandle)" >>>> + cpupool_phandle="0xffffff" >>>> + fdtput binaries/virt-gicv2.dtb -p -t s /chosen/cpupool compatible xen,cpupool >>>> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool cpupool-cpus $cpu_phandle >>>> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/cpupool phandle $cpupool_phandle >>>> + fdtput binaries/virt-gicv2.dtb -p -t x /chosen/domU0 domain-cpupool $cpupool_phandle >>>> + >>>> + # Check if domU0 (id=1) is assigned to Pool-1 >>>> + passed="${test_variant} test passed" >>>> + dom0_check="if xl list -c 1 | grep -q Pool-1; then echo ${passed}; fi" >>>> +fi >>> >>> I would prefer to keep the device tree editing here to a minimum and >>> instead add boot-cpupool support in ImageBuilder and add CPUPOOL* config >>> options to the existing config file for ImageBuilder created in this >>> file below. This way, we keep this test cleaner and we help more the >>> user by proving a way to set boot-cpupools more easily in general, also >>> useful outside gitlab-ci. >> >> I agree that ImageBuilder is a great tool. However, I would opt for keeping what I did because of the following: >> - current release schedule (we could benefit from having a test for 4.17 feature instead of waiting for the corresponding >> change to be done in ImageBuilder first and tested), >> - test is already prepared and requires just a trivial fix, >> - we should not enforce users willing to add tests to gitlab-ci to always prepare the ImageBuilder changes first. >> ImageBuilder is not meant to support all the features strictly because some of them require too much >> end-user knowledge and digging into device tree (it should stay as simple as possible), >> - all in all we need to have a way to modify the dtb and fdtput is certainly better than sed as it does not >> require additional steps for decompilation/compilation and its commands look more clean than using sed transformation. >> >> Let me know what you think. >> >> On a side note, I can add boot-time cpupools support in ImageBuilder to my TODO list so that we can check if this is something >> ImageBuilder should support. If yes, we can modify this test after the release. > > > Yeah, ImageBuilder doesn't necessarely need to support every feature. > However, a tool (if not ImageBuilder, Lopper, or a new ImageBuilder > script) should support CPUPOOLs to enable the user. > > You are right that ImageBuilder is not necessarely tied with gitlab-ci. > This is especially true once we start doing more interface-level > testing, such as hypercalls fuzzing with XTF. We are not going to be > able to use ImageBuilder to trigger every possible device tree boot time > combination, especially the ones that are invalid. We want to be able to > test Xen with invalid device tree input as well. > > In addition to interface-level testing, we need user-level testing to > test features the way we expect a user to use them. This is what > ImageBuilder is for and that is why it has been used today in gitlab-ci. > On ARM today we only have user-level testing in gitlab-ci, but I'd love > to have more interface-level testing, which will surely require more > device tree manipulations outside of ImageBuilder. > > - user-level tests -> ImageBuilder, common valid configurations > - interface-level tests -> not ImageBuilder, various valid and invalid > configurations, maybe automatically generated? > Device tree manipulations expected in gitlab-ci. > > > In my view, this test belongs to the "user-level test" category, this is > why I would prefer if it was done using the same tool that we expect the > user to use. Ideally, it would be ImageBuilder because that is the tool > that we have used so far (but it could be a new script under > ImageBuilder or Lopper). > > But I understand deadlines, release schedule, etc., so if you think it > cannot be done properly using ImageBuilder in 2-3 days, then I would > take this patch as is, and we can revisit it in the future as you > suggested. I am OK with that too. Ok, let me see if I can come up with a clean solution in the ImageBuilder. ~Michal From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:49:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400295.641988 (Exim 4.92) (envelope-from ) id 1oVgRT-0004qj-1L; Tue, 06 Sep 2022 21:49:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400295.641988; Tue, 06 Sep 2022 21:49:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgRS-0004qc-Uv; Tue, 06 Sep 2022 21:49:10 +0000 Received: by outflank-mailman (input) for mailman id 400295; Tue, 06 Sep 2022 21:49:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI5-0000Cs-ER for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:29 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id da70436f-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:01:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A07BD1756; Tue, 6 Sep 2022 03:01:26 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 617C93F534; Tue, 6 Sep 2022 03:01:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da70436f-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zhen Lei , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v4 08/10] xen/arm: smmuv3: Remove unnecessary oom message Date: Tue, 6 Sep 2022 10:55:55 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhen Lei Backport Linux commit affa909571b0. This is the clean backport without any changes. Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210609125438.14369-1-thunder.leizhen@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git affa909571b0 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index c53d4c96a4..c47e7dea04 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1647,10 +1647,8 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) void *strtab = smmu->strtab_cfg.strtab; cfg->l1_desc = _xzalloc(size, sizeof(void *)); - if (!cfg->l1_desc) { - dev_err(smmu->dev, "failed to allocate l1 stream table desc\n"); + if (!cfg->l1_desc) return -ENOMEM; - } for (i = 0; i < cfg->num_l1_ents; ++i) { arm_smmu_write_strtab_l1_desc(strtab, &cfg->l1_desc[i]); @@ -2435,10 +2433,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev) struct arm_smmu_device *smmu; smmu = xzalloc(struct arm_smmu_device); - if (!smmu) { - dev_err(pdev, "failed to allocate arm_smmu_device\n"); + if (!smmu) return -ENOMEM; - } smmu->dev = pdev; if (pdev->of_node) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:49:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400301.642000 (Exim 4.92) (envelope-from ) id 1oVgRe-0005BA-Az; Tue, 06 Sep 2022 21:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400301.642000; Tue, 06 Sep 2022 21:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgRe-0005B3-7H; Tue, 06 Sep 2022 21:49:22 +0000 Received: by outflank-mailman (input) for mailman id 400301; Tue, 06 Sep 2022 21:49:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHo-0000Cs-CJ for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:12 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cab9a6a-2dfb-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:46:20 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 16FD53200488; Tue, 6 Sep 2022 11:46:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 06 Sep 2022 11:46:18 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Sep 2022 11:46:15 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cab9a6a-2dfb-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1662479176; x= 1662565576; bh=V7/fLWTP7eSQOSpSIE+MW9OQc508pI6balfpUeNEzQo=; b=i cdOFr1alaippbqRJ8AByRl0JHs70eO9yY/jCHb8HKT+9PgnmMUc30FRbMHFCBlUl 4ApiuFGwz+bCg/6aW3rfMT9Vhao57CtXx+whNsXqsPcn5saO8kdVvXx/nyv0Ip1Q 6nK5XvzIZrzrjK++8kGvLEJ4SXdko8o9cUPawIkLu2cz5lcTZUNG0M1x4oKUTxes UAtrLZ0mFxvOZSX2jEjKd63YleveMceW7K/DU3f9l3ci47im2QE9tJ60zBfZAVJr fPoSbFFi4+c/rQTPu42hnWKryHEF/QBkvmfWMN2mvOpDj7xQRZ9KPDWnNK4uLdnK K7zPojUmuVNpGcpfwGKWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662479176; x=1662565576; bh=V7/fLWTP7eSQOSpSIE+MW9OQc508 pI6balfpUeNEzQo=; b=NXengI6HxWhkhBAhHesl6KYFhcX3GIyW7LySC7cgT6q6 4mJpeNhKqf2WHh1OiTrDSb6tjz1s6w2iLZMHdJygIh/RiJJf7b7KsPsy37f205Po xw0ziCb0/XmuubaLgq8h3y1kRPyVCsZm6up3cKkVTE5B6nTQLhQnYPlb6O0iJxk8 VG0kOQzpD8B31XmMUL2KPvNDonSHs8McNhLhNKKyY3LdRlx44p0KVvvUe1wSPlax t9vTeXwySl684h7I3LsAArAQz85GH96TnJcd5VOvEi7e8DgdbrBpCUJ31YmVdT4D gUolqY31Xq0ArhZdcEDJB2w28gzsrB2T9GFA6aK1DQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelkedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 6 Sep 2022 17:46:12 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci Message-ID: References: <08c9df71-0470-c9eb-94f0-776eaacefa5b@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QVef3WGluHOc9mqh" Content-Disposition: inline In-Reply-To: <08c9df71-0470-c9eb-94f0-776eaacefa5b@suse.com> --QVef3WGluHOc9mqh Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 6 Sep 2022 17:46:12 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci On Tue, Sep 06, 2022 at 05:07:27PM +0200, Jan Beulich wrote: > On 02.09.2022 15:17, Marek Marczykowski-G=C3=B3recki wrote: > > This allows configuring EHCI and XHCI consoles separately, > > simultaneously. > >=20 > > This changes string_param() to custom_param() in both ehci and xhci > > drivers. Both drivers parse only values applicable to them. > >=20 > > While at it, drop unnecessary memset() of a static variable. >=20 > Are you sure of this? What if there are two "dbgp=3Dxhci,..." options > on the command line, the latter intended to override the earlier but > malformed. Then ->enabled would be left set from parsing the first > instance, afaict. Right. > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -409,7 +409,7 @@ The following are examples of correct specification= s: > > Specify the size of the console ring buffer. > > =20 > > ### console > > -> `=3D List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | none ]` > > +> `=3D List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | xhci | none= ]` >=20 > Personally I consider "dbc" more in line with "dbgp", but I'm okay > with "xhci". We may want to allow for "ehci" then as an alias of > "dbgp", though (in a separate, later patch). I've changed "dbc" to "xhci", as "dbc" isn't really surfaced to the user anywhere else. As in - it requires some deeper knowledge to draw a connection between console=3Ddbc and dbgp=3Dxhci. And yes, when going this way, "ehci" alias would make sense. >=20 > > --- a/xen/drivers/char/ehci-dbgp.c > > +++ b/xen/drivers/char/ehci-dbgp.c > > @@ -1464,7 +1464,18 @@ static struct uart_driver __read_mostly ehci_dbg= p_driver =3D { > > static struct ehci_dbgp ehci_dbgp =3D { .state =3D dbgp_unsafe, .phys_= port =3D 1 }; > > =20 > > static char __initdata opt_dbgp[30]; > > -string_param("dbgp", opt_dbgp); > > + > > +static int __init parse_ehci_dbgp(const char *opt) > > +{ > > + if ( strncmp(opt, "ehci", 4) ) > > + return 0; > > + > > + strlcpy(opt_dbgp, opt, sizeof(opt_dbgp)); > > + > > + return 0; > > +} > > + > > +custom_param("dbgp", parse_ehci_dbgp); >=20 > We commonly don't put a blank line between the function and this > construct. (Same again further down then.) >=20 > > --- a/xen/drivers/char/xhci-dbc.c > > +++ b/xen/drivers/char/xhci-dbc.c > > @@ -245,6 +245,7 @@ struct dbc { > > uint64_t xhc_dbc_offset; > > void __iomem *xhc_mmio; > > =20 > > + bool enable; /* whether dbgp=3Dxhci was set at all */ >=20 > In dbc_init_xhc() there's an assumption that the "sbdf" field is > always non-zero. Do you really need this separate flag then? Not really, sbdf =3D=3D 0 means "find Nth xhci", where N=3Dxhc_num+1 (and xhc_num can be zero too). See the "if" at the very top of dbc_init_xhc(). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --QVef3WGluHOc9mqh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMXa0QACgkQ24/THMrX 1yytjwf/UlINwGQ3CDJK60Agz88bEOg0oOhqZrjAu5H0t+6yypWKZWBmyLkHfnz5 /oRMJ+fjcy2+S+JFi/8QWna4vg9+uYeLkrpQjHu/0e71EsHhq+FbEX4Pi2LcY/7k WCI5NvtIJJyIxhsBNIp4a8+5AtKLCn8m5buboIlta5FNGcoGsceDFoWSiEbfb6Gx TUAjXXWse3DzjSeFbe1BeXcN9hKz3+4FD017N3QsLJwcLDXkHDcGwGH1+OURPAQa q6ZiMeQ3f0SoR6Z9QVUyPdlyHtSHGw/tXoHgq67r/vM95JeAuua8ijahNlsZu96I wx88tuzbtI6G44pNT7t5L4wlmtv+tA== =Jbn+ -----END PGP SIGNATURE----- --QVef3WGluHOc9mqh-- From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:49:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:49:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400308.642011 (Exim 4.92) (envelope-from ) id 1oVgRl-0005e5-RE; Tue, 06 Sep 2022 21:49:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400308.642011; Tue, 06 Sep 2022 21:49:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgRl-0005dr-ND; Tue, 06 Sep 2022 21:49:29 +0000 Received: by outflank-mailman (input) for mailman id 400308; Tue, 06 Sep 2022 21:49:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIS-0000Cs-HU for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4020852e-2de1-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 14:41:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3E83D338B0; Tue, 6 Sep 2022 12:41:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F1E6F13A7A; Tue, 6 Sep 2022 12:41:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wFyTOQFAF2NiSQAAMHmgww (envelope-from ); Tue, 06 Sep 2022 12:41:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4020852e-2de1-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662468098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8y5B8SeVYhFEQ1i+eFOmTPV0zpAN2fLm9xCblFTGrrY=; b=WFFiWAmKMwR0GYGaGXHvkDhG/1Dz1fNnkG4tbPLcc1xbEwsY0clI9tciugJ147AZL/zfkE KLAniDghG6hgg4kCrLoKZhD/FH+QUoPQ5dHw+HCM3JBg2uOLfC4f0qzB/7OhXHbZipdzvB m8Yp7fnvvHIjhFUSdXgqb+hOOFRnH3Y= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH] xen/timer: don't migrate timers away from cpus during suspend Date: Tue, 6 Sep 2022 14:41:35 +0200 Message-Id: <20220906124135.12998-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit During a suspend/resume cycle timers on all cpus but cpu 0 will be migrated to cpu 0, as the other cpus are taken down. This is problematic in case such a timer is related to a specific vcpu, as the vcpus are not migrated to another cpu during suspend (migrating them would break cpupools and core scheduling). In order to avoid the problems just try to keep the timers on their cpus. Only migrate them away in case resume failed. Doing so isn't problematic, as any vcpu on a cpu not coming back to life would be migrated away, too. Signed-off-by: Juergen Gross Tested-by: Marek Marczykowski-Górecki --- xen/common/timer.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/xen/common/timer.c b/xen/common/timer.c index 9b5016d5ed..6b5473e5f1 100644 --- a/xen/common/timer.c +++ b/xen/common/timer.c @@ -637,6 +637,13 @@ static void free_percpu_timers(unsigned int cpu) ASSERT(ts->heap == dummy_heap); } +static void deinit_timers(unsigned int cpu) +{ + migrate_timers_from_cpu(cpu); + if ( !park_offline_cpus ) + free_percpu_timers(cpu); +} + static int cf_check cpu_callback( struct notifier_block *nfb, unsigned long action, void *hcpu) { @@ -655,13 +662,14 @@ static int cf_check cpu_callback( } break; - case CPU_UP_CANCELED: case CPU_DEAD: - case CPU_RESUME_FAILED: - migrate_timers_from_cpu(cpu); + if ( system_state != SYS_STATE_suspend ) + deinit_timers(cpu); + break; - if ( !park_offline_cpus && system_state != SYS_STATE_suspend ) - free_percpu_timers(cpu); + case CPU_UP_CANCELED: + case CPU_RESUME_FAILED: + deinit_timers(cpu); break; case CPU_REMOVE: -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:49:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:49:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400310.642016 (Exim 4.92) (envelope-from ) id 1oVgRm-0005hD-7C; Tue, 06 Sep 2022 21:49:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400310.642016; Tue, 06 Sep 2022 21:49:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgRl-0005gK-WE; Tue, 06 Sep 2022 21:49:30 +0000 Received: by outflank-mailman (input) for mailman id 400310; Tue, 06 Sep 2022 21:49:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIB-0000Cs-Ex for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:35 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d403bdd1-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:01:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A078A1756; Tue, 6 Sep 2022 03:01:15 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D0BD63F534; Tue, 6 Sep 2022 03:01:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d403bdd1-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Jean-Philippe Brucker , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Eric Auger , Jonathan Cameron , Will Deacon Subject: [PATCH v4 04/10] xen/arm: smmuv3: Move definitions to a header Date: Tue, 6 Sep 2022 10:55:51 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jean-Philippe Brucker Backport Linux commit e881e7839fba. Also, move Xen related struct definition to header to get it compiled. Allow sharing structure definitions with the upcoming SVA support for Arm SMMUv3, by moving them to a separate header. We could surgically extract only what is needed but keeping all definitions in one place looks nicer. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Eric Auger Reviewed-by: Jonathan Cameron Link: https://lore.kernel.org/r/20200918101852.582559-8-jean-philippe@linaro.org Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e881e7839fba Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Added Stefano Acked-by Changes in v3: - remove clean backport msg in commit msg Changes in v2: - fix commit msg - also move struct definition to header file to sync with Linux patch --- xen/drivers/passthrough/arm/smmu-v3.c | 665 +------------------------ xen/drivers/passthrough/arm/smmu-v3.h | 674 ++++++++++++++++++++++++++ 2 files changed, 675 insertions(+), 664 deletions(-) create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 229b9a4b0d..ba24a26ad6 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -90,6 +90,7 @@ #include #include +#include "smmu-v3.h" #define ARM_SMMU_VTCR_SH_IS 3 #define ARM_SMMU_VTCR_RGN_WBWA 1 @@ -103,22 +104,12 @@ #define ARM_SMMU_VTCR_PS_52_BIT 0x6ULL /* Linux compatibility functions. */ -typedef paddr_t dma_addr_t; -typedef paddr_t phys_addr_t; -typedef unsigned int gfp_t; - #define __iomb() dmb(osh) #define platform_device device #define GFP_KERNEL 0 -/* Alias to Xen lock functions */ -#define mutex spinlock -#define mutex_init spin_lock_init -#define mutex_lock spin_lock -#define mutex_unlock spin_unlock - /* Device logger functions */ #define dev_name(dev) dt_node_full_name(dev->of_node) #define dev_dbg(dev, fmt, ...) \ @@ -159,12 +150,6 @@ typedef unsigned int gfp_t; #define readl_relaxed_poll_timeout(addr, val, cond, delay_us, timeout_us) \ readx_poll_timeout(readl_relaxed, addr, val, cond, delay_us, timeout_us) -#define FIELD_PREP(_mask, _val) \ - (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) - -#define FIELD_GET(_mask, _reg) \ - ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) - /* * Helpers for DMA allocation. Just the function name is reused for * porting code, these allocation are not managed allocations @@ -197,27 +182,6 @@ static void *dmam_alloc_coherent(struct device *dev, size_t size, return vaddr; } - -/* Xen specific code. */ -struct iommu_domain { - /* Runtime SMMU configuration for this iommu_domain */ - atomic_t ref; - /* - * Used to link iommu_domain contexts for a same domain. - * There is at least one per-SMMU to used by the domain. - */ - struct list_head list; -}; - -/* Describes information required for a Xen domain */ -struct arm_smmu_xen_domain { - spinlock_t lock; - - /* List of iommu domains associated to this domain */ - struct list_head contexts; -}; - - /* Keep a list of devices associated with this driver */ static DEFINE_SPINLOCK(arm_smmu_devices_lock); static LIST_HEAD(arm_smmu_devices); @@ -261,635 +225,8 @@ static int platform_get_irq_byname_optional(struct device *dev, } /* Start of Linux SMMUv3 code */ -/* MMIO registers */ -#define ARM_SMMU_IDR0 0x0 -#define IDR0_ST_LVL GENMASK(28, 27) -#define IDR0_ST_LVL_2LVL 1 -#define IDR0_STALL_MODEL GENMASK(25, 24) -#define IDR0_STALL_MODEL_STALL 0 -#define IDR0_STALL_MODEL_FORCE 2 -#define IDR0_TTENDIAN GENMASK(22, 21) -#define IDR0_TTENDIAN_MIXED 0 -#define IDR0_TTENDIAN_LE 2 -#define IDR0_TTENDIAN_BE 3 -#define IDR0_CD2L (1 << 19) -#define IDR0_VMID16 (1 << 18) -#define IDR0_PRI (1 << 16) -#define IDR0_SEV (1 << 14) -#define IDR0_MSI (1 << 13) -#define IDR0_ASID16 (1 << 12) -#define IDR0_ATS (1 << 10) -#define IDR0_HYP (1 << 9) -#define IDR0_COHACC (1 << 4) -#define IDR0_TTF GENMASK(3, 2) -#define IDR0_TTF_AARCH64 2 -#define IDR0_TTF_AARCH32_64 3 -#define IDR0_S1P (1 << 1) -#define IDR0_S2P (1 << 0) - -#define ARM_SMMU_IDR1 0x4 -#define IDR1_TABLES_PRESET (1 << 30) -#define IDR1_QUEUES_PRESET (1 << 29) -#define IDR1_REL (1 << 28) -#define IDR1_CMDQS GENMASK(25, 21) -#define IDR1_EVTQS GENMASK(20, 16) -#define IDR1_PRIQS GENMASK(15, 11) -#define IDR1_SSIDSIZE GENMASK(10, 6) -#define IDR1_SIDSIZE GENMASK(5, 0) - -#define ARM_SMMU_IDR5 0x14 -#define IDR5_STALL_MAX GENMASK(31, 16) -#define IDR5_GRAN64K (1 << 6) -#define IDR5_GRAN16K (1 << 5) -#define IDR5_GRAN4K (1 << 4) -#define IDR5_OAS GENMASK(2, 0) -#define IDR5_OAS_32_BIT 0 -#define IDR5_OAS_36_BIT 1 -#define IDR5_OAS_40_BIT 2 -#define IDR5_OAS_42_BIT 3 -#define IDR5_OAS_44_BIT 4 -#define IDR5_OAS_48_BIT 5 -#define IDR5_OAS_52_BIT 6 -#define IDR5_VAX GENMASK(11, 10) -#define IDR5_VAX_52_BIT 1 - -#define ARM_SMMU_CR0 0x20 -#define CR0_ATSCHK (1 << 4) -#define CR0_CMDQEN (1 << 3) -#define CR0_EVTQEN (1 << 2) -#define CR0_PRIQEN (1 << 1) -#define CR0_SMMUEN (1 << 0) - -#define ARM_SMMU_CR0ACK 0x24 - -#define ARM_SMMU_CR1 0x28 -#define CR1_TABLE_SH GENMASK(11, 10) -#define CR1_TABLE_OC GENMASK(9, 8) -#define CR1_TABLE_IC GENMASK(7, 6) -#define CR1_QUEUE_SH GENMASK(5, 4) -#define CR1_QUEUE_OC GENMASK(3, 2) -#define CR1_QUEUE_IC GENMASK(1, 0) -/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ -#define CR1_CACHE_NC 0 -#define CR1_CACHE_WB 1 -#define CR1_CACHE_WT 2 - -#define ARM_SMMU_CR2 0x2c -#define CR2_PTM (1 << 2) -#define CR2_RECINVSID (1 << 1) -#define CR2_E2H (1 << 0) - -#define ARM_SMMU_GBPA 0x44 -#define GBPA_UPDATE (1U << 31) -#define GBPA_ABORT (1 << 20) - -#define ARM_SMMU_IRQ_CTRL 0x50 -#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) -#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) -#define IRQ_CTRL_GERROR_IRQEN (1 << 0) - -#define ARM_SMMU_IRQ_CTRLACK 0x54 - -#define ARM_SMMU_GERROR 0x60 -#define GERROR_SFM_ERR (1 << 8) -#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) -#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) -#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) -#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) -#define GERROR_PRIQ_ABT_ERR (1 << 3) -#define GERROR_EVTQ_ABT_ERR (1 << 2) -#define GERROR_CMDQ_ERR (1 << 0) -#define GERROR_ERR_MASK 0xfd - -#define ARM_SMMU_GERRORN 0x64 - -#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 -#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 -#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 - -#define ARM_SMMU_STRTAB_BASE 0x80 -#define STRTAB_BASE_RA (1UL << 62) -#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) - -#define ARM_SMMU_STRTAB_BASE_CFG 0x88 -#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) -#define STRTAB_BASE_CFG_FMT_LINEAR 0 -#define STRTAB_BASE_CFG_FMT_2LVL 1 -#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) -#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) - -#define ARM_SMMU_CMDQ_BASE 0x90 -#define ARM_SMMU_CMDQ_PROD 0x98 -#define ARM_SMMU_CMDQ_CONS 0x9c - -#define ARM_SMMU_EVTQ_BASE 0xa0 -#define ARM_SMMU_EVTQ_PROD 0x100a8 -#define ARM_SMMU_EVTQ_CONS 0x100ac -#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 -#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 -#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc - -#define ARM_SMMU_PRIQ_BASE 0xc0 -#define ARM_SMMU_PRIQ_PROD 0x100c8 -#define ARM_SMMU_PRIQ_CONS 0x100cc -#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 -#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 -#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc - -#define ARM_SMMU_REG_SZ 0xe00 - -/* Common MSI config fields */ -#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) -#define MSI_CFG2_SH GENMASK(5, 4) -#define MSI_CFG2_MEMATTR GENMASK(3, 0) - -/* Common memory attribute values */ -#define ARM_SMMU_SH_NSH 0 -#define ARM_SMMU_SH_OSH 2 -#define ARM_SMMU_SH_ISH 3 -#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 -#define ARM_SMMU_MEMATTR_OIWB 0xf - -#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) -#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) -#define Q_OVERFLOW_FLAG (1U << 31) -#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) -#define Q_ENT(q, p) ((q)->base + \ - Q_IDX(&((q)->llq), p) * \ - (q)->ent_dwords) - -#define Q_BASE_RWA (1UL << 62) -#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) -#define Q_BASE_LOG2SIZE GENMASK(4, 0) - -/* Ensure DMA allocations are naturally aligned */ -#ifdef CONFIG_CMA_ALIGNMENT -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) -#else -#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) -#endif - -/* - * Stream table. - * - * Linear: Enough to cover 1 << IDR1.SIDSIZE entries - * 2lvl: 128k L1 entries, - * 256 lazy entries per table (each table covers a PCI bus) - */ -#define STRTAB_L1_SZ_SHIFT 20 -#define STRTAB_SPLIT 8 - -#define STRTAB_L1_DESC_DWORDS 1 -#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) -#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) - -#define STRTAB_STE_DWORDS 8 -#define STRTAB_STE_0_V (1UL << 0) -#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) -#define STRTAB_STE_0_CFG_ABORT 0 -#define STRTAB_STE_0_CFG_BYPASS 4 -#define STRTAB_STE_0_CFG_S1_TRANS 5 -#define STRTAB_STE_0_CFG_S2_TRANS 6 - -#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) -#define STRTAB_STE_0_S1FMT_LINEAR 0 -#define STRTAB_STE_0_S1FMT_64K_L2 2 -#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) -#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) - -#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) -#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 -#define STRTAB_STE_1_S1DSS_BYPASS 0x1 -#define STRTAB_STE_1_S1DSS_SSID0 0x2 - -#define STRTAB_STE_1_S1C_CACHE_NC 0UL -#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL -#define STRTAB_STE_1_S1C_CACHE_WT 2UL -#define STRTAB_STE_1_S1C_CACHE_WB 3UL -#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) -#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) -#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) - -#define STRTAB_STE_1_S1STALLD (1UL << 27) - -#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) -#define STRTAB_STE_1_EATS_ABT 0UL -#define STRTAB_STE_1_EATS_TRANS 1UL -#define STRTAB_STE_1_EATS_S1CHK 2UL - -#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) -#define STRTAB_STE_1_STRW_NSEL1 0UL -#define STRTAB_STE_1_STRW_EL2 2UL - -#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) -#define STRTAB_STE_1_SHCFG_INCOMING 1UL - -#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) -#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) -#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) -#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) -#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) -#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) -#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) -#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) -#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) -#define STRTAB_STE_2_S2AA64 (1UL << 51) -#define STRTAB_STE_2_S2ENDI (1UL << 52) -#define STRTAB_STE_2_S2PTW (1UL << 54) -#define STRTAB_STE_2_S2R (1UL << 58) - -#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) - -/* - * Context descriptors. - * - * Linear: when less than 1024 SSIDs are supported - * 2lvl: at most 1024 L1 entries, - * 1024 lazy entries per table. - */ -#define CTXDESC_SPLIT 10 -#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) - -#define CTXDESC_L1_DESC_DWORDS 1 -#define CTXDESC_L1_DESC_V (1UL << 0) -#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) - -#define CTXDESC_CD_DWORDS 8 -#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) -#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) -#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) -#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) -#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) -#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) -#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) - -#define CTXDESC_CD_0_ENDI (1UL << 15) -#define CTXDESC_CD_0_V (1UL << 31) - -#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) -#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) - -#define CTXDESC_CD_0_AA64 (1UL << 41) -#define CTXDESC_CD_0_S (1UL << 44) -#define CTXDESC_CD_0_R (1UL << 45) -#define CTXDESC_CD_0_A (1UL << 46) -#define CTXDESC_CD_0_ASET (1UL << 47) -#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) - -#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) - -/* - * When the SMMU only supports linear context descriptor tables, pick a - * reasonable size limit (64kB). - */ -#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) - -/* Command queue */ -#define CMDQ_ENT_SZ_SHIFT 4 -#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) -#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) - -#define CMDQ_CONS_ERR GENMASK(30, 24) -#define CMDQ_ERR_CERROR_NONE_IDX 0 -#define CMDQ_ERR_CERROR_ILL_IDX 1 -#define CMDQ_ERR_CERROR_ABT_IDX 2 -#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 - -#define CMDQ_0_OP GENMASK_ULL(7, 0) -#define CMDQ_0_SSV (1UL << 11) - -#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) -#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) -#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) - -#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) -#define CMDQ_CFGI_1_LEAF (1UL << 0) -#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) - -#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) -#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) -#define CMDQ_TLBI_1_LEAF (1UL << 0) -#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) -#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) - -#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) -#define CMDQ_ATC_0_GLOBAL (1UL << 9) -#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) -#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) - -#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) -#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) -#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) -#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) - -#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) -#define CMDQ_SYNC_0_CS_NONE 0 -#define CMDQ_SYNC_0_CS_IRQ 1 -#define CMDQ_SYNC_0_CS_SEV 2 -#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) -#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) -#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) -#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) - -/* Event queue */ -#define EVTQ_ENT_SZ_SHIFT 5 -#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) -#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) - -#define EVTQ_0_ID GENMASK_ULL(7, 0) - -/* PRI queue */ -#define PRIQ_ENT_SZ_SHIFT 4 -#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) -#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) - -#define PRIQ_0_SID GENMASK_ULL(31, 0) -#define PRIQ_0_SSID GENMASK_ULL(51, 32) -#define PRIQ_0_PERM_PRIV (1UL << 58) -#define PRIQ_0_PERM_EXEC (1UL << 59) -#define PRIQ_0_PERM_READ (1UL << 60) -#define PRIQ_0_PERM_WRITE (1UL << 61) -#define PRIQ_0_PRG_LAST (1UL << 62) -#define PRIQ_0_SSID_V (1UL << 63) - -#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) -#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) - -/* High-level queue structures */ -#define ARM_SMMU_POLL_TIMEOUT_US 100 -#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ -#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 - static bool disable_bypass = 1; -enum pri_resp { - PRI_RESP_DENY = 0, - PRI_RESP_FAIL = 1, - PRI_RESP_SUCC = 2, -}; - -#ifdef CONFIG_MSI -enum arm_smmu_msi_index { - EVTQ_MSI_INDEX, - GERROR_MSI_INDEX, - PRIQ_MSI_INDEX, - ARM_SMMU_MAX_MSIS, -}; - -static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { - [EVTQ_MSI_INDEX] = { - ARM_SMMU_EVTQ_IRQ_CFG0, - ARM_SMMU_EVTQ_IRQ_CFG1, - ARM_SMMU_EVTQ_IRQ_CFG2, - }, - [GERROR_MSI_INDEX] = { - ARM_SMMU_GERROR_IRQ_CFG0, - ARM_SMMU_GERROR_IRQ_CFG1, - ARM_SMMU_GERROR_IRQ_CFG2, - }, - [PRIQ_MSI_INDEX] = { - ARM_SMMU_PRIQ_IRQ_CFG0, - ARM_SMMU_PRIQ_IRQ_CFG1, - ARM_SMMU_PRIQ_IRQ_CFG2, - }, -}; -#endif /* CONFIG_MSI */ - -struct arm_smmu_cmdq_ent { - /* Common fields */ - u8 opcode; - bool substream_valid; - - /* Command-specific fields */ - union { - #define CMDQ_OP_PREFETCH_CFG 0x1 - struct { - u32 sid; - u8 size; - u64 addr; - } prefetch; - - #define CMDQ_OP_CFGI_STE 0x3 - #define CMDQ_OP_CFGI_ALL 0x4 - struct { - u32 sid; - union { - bool leaf; - u8 span; - }; - } cfgi; - - #define CMDQ_OP_TLBI_EL2_ALL 0x20 - #define CMDQ_OP_TLBI_S12_VMALL 0x28 - #define CMDQ_OP_TLBI_S2_IPA 0x2a - #define CMDQ_OP_TLBI_NSNH_ALL 0x30 - struct { - u16 asid; - u16 vmid; - bool leaf; - u64 addr; - } tlbi; - - #define CMDQ_OP_ATC_INV 0x40 - #define ATC_INV_SIZE_ALL 52 - struct { - u32 sid; - u32 ssid; - u64 addr; - u8 size; - bool global; - } atc; - - #define CMDQ_OP_PRI_RESP 0x41 - struct { - u32 sid; - u32 ssid; - u16 grpid; - enum pri_resp resp; - } pri; - - #define CMDQ_OP_CMD_SYNC 0x46 - struct { - u32 msidata; - u64 msiaddr; - } sync; - }; -}; - -struct arm_smmu_ll_queue { - u32 prod; - u32 cons; - u32 max_n_shift; -}; - -struct arm_smmu_queue { - struct arm_smmu_ll_queue llq; - int irq; /* Wired interrupt */ - - __le64 *base; - dma_addr_t base_dma; - u64 q_base; - - size_t ent_dwords; - - u32 __iomem *prod_reg; - u32 __iomem *cons_reg; -}; - -struct arm_smmu_cmdq { - struct arm_smmu_queue q; - spinlock_t lock; -}; - -struct arm_smmu_evtq { - struct arm_smmu_queue q; - u32 max_stalls; -}; - -struct arm_smmu_priq { - struct arm_smmu_queue q; -}; - -/* High-level stream table and context descriptor structures */ -struct arm_smmu_strtab_l1_desc { - u8 span; - - __le64 *l2ptr; - dma_addr_t l2ptr_dma; -}; - -struct arm_smmu_s2_cfg { - u16 vmid; - u64 vttbr; - u64 vtcr; -}; - -struct arm_smmu_strtab_cfg { - __le64 *strtab; - dma_addr_t strtab_dma; - struct arm_smmu_strtab_l1_desc *l1_desc; - unsigned int num_l1_ents; - - u64 strtab_base; - u32 strtab_base_cfg; -}; - -struct arm_lpae_s2_cfg { - u64 vttbr; - struct { - u32 ps:3; - u32 tg:2; - u32 sh:2; - u32 orgn:2; - u32 irgn:2; - u32 sl:2; - u32 tsz:6; - } vtcr; -}; - -/* An SMMUv3 instance */ -struct arm_smmu_device { - struct device *dev; - void __iomem *base; - void __iomem *page1; - -#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) -#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) -#define ARM_SMMU_FEAT_TT_LE (1 << 2) -#define ARM_SMMU_FEAT_TT_BE (1 << 3) -#define ARM_SMMU_FEAT_PRI (1 << 4) -#define ARM_SMMU_FEAT_ATS (1 << 5) -#define ARM_SMMU_FEAT_SEV (1 << 6) -#define ARM_SMMU_FEAT_MSI (1 << 7) -#define ARM_SMMU_FEAT_COHERENCY (1 << 8) -#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) -#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) -#define ARM_SMMU_FEAT_STALLS (1 << 11) -#define ARM_SMMU_FEAT_HYP (1 << 12) -#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) -#define ARM_SMMU_FEAT_VAX (1 << 14) - u32 features; - -#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) -#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) - u32 options; - - struct arm_smmu_cmdq cmdq; - struct arm_smmu_evtq evtq; - struct arm_smmu_priq priq; - - int gerr_irq; - int combined_irq; - u32 sync_nr; - u8 prev_cmd_opcode; - - unsigned long ias; /* IPA */ - unsigned long oas; /* PA */ - unsigned long pgsize_bitmap; - -#define ARM_SMMU_MAX_VMIDS (1 << 16) - unsigned int vmid_bits; - DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); - - unsigned int sid_bits; - - struct arm_smmu_strtab_cfg strtab_cfg; - - /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ - union { - u32 sync_count; - u64 padding; - }; - - /* Need to keep a list of SMMU devices */ - struct list_head devices; - - /* Tasklets for handling evts/faults and pci page request IRQs*/ - struct tasklet evtq_irq_tasklet; - struct tasklet priq_irq_tasklet; - struct tasklet combined_irq_tasklet; -}; - -/* SMMU private data for each master */ -struct arm_smmu_master { - struct arm_smmu_device *smmu; - struct device *dev; - struct arm_smmu_domain *domain; - struct list_head domain_head; - u32 *sids; - unsigned int num_sids; - bool ats_enabled; -}; - -/* SMMU private data for an IOMMU domain */ -enum arm_smmu_domain_stage { - ARM_SMMU_DOMAIN_S1 = 0, - ARM_SMMU_DOMAIN_S2, - ARM_SMMU_DOMAIN_NESTED, - ARM_SMMU_DOMAIN_BYPASS, -}; - -struct arm_smmu_domain { - struct arm_smmu_device *smmu; - struct mutex init_mutex; /* Protects smmu pointer */ - - bool non_strict; - atomic_t nr_ats_masters; - - enum arm_smmu_domain_stage stage; - struct arm_smmu_s2_cfg s2_cfg; - - /* Xen domain associated with this SMMU domain */ - struct domain *d; - - struct iommu_domain domain; - - struct list_head devices; - spinlock_t devices_lock; -}; - struct arm_smmu_option_prop { u32 opt; const char *prop; diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h new file mode 100644 index 0000000000..c45d2f16c4 --- /dev/null +++ b/xen/drivers/passthrough/arm/smmu-v3.h @@ -0,0 +1,674 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * IOMMU API for ARM architected SMMUv3 implementations. + * + * Copyright (C) 2022 ARM Limited + */ + +#ifndef _ARM_SMMU_V3_H +#define _ARM_SMMU_V3_H + +/* MMIO registers */ +#define ARM_SMMU_IDR0 0x0 +#define IDR0_ST_LVL GENMASK(28, 27) +#define IDR0_ST_LVL_2LVL 1 +#define IDR0_STALL_MODEL GENMASK(25, 24) +#define IDR0_STALL_MODEL_STALL 0 +#define IDR0_STALL_MODEL_FORCE 2 +#define IDR0_TTENDIAN GENMASK(22, 21) +#define IDR0_TTENDIAN_MIXED 0 +#define IDR0_TTENDIAN_LE 2 +#define IDR0_TTENDIAN_BE 3 +#define IDR0_CD2L (1 << 19) +#define IDR0_VMID16 (1 << 18) +#define IDR0_PRI (1 << 16) +#define IDR0_SEV (1 << 14) +#define IDR0_MSI (1 << 13) +#define IDR0_ASID16 (1 << 12) +#define IDR0_ATS (1 << 10) +#define IDR0_HYP (1 << 9) +#define IDR0_COHACC (1 << 4) +#define IDR0_TTF GENMASK(3, 2) +#define IDR0_TTF_AARCH64 2 +#define IDR0_TTF_AARCH32_64 3 +#define IDR0_S1P (1 << 1) +#define IDR0_S2P (1 << 0) + +#define ARM_SMMU_IDR1 0x4 +#define IDR1_TABLES_PRESET (1 << 30) +#define IDR1_QUEUES_PRESET (1 << 29) +#define IDR1_REL (1 << 28) +#define IDR1_CMDQS GENMASK(25, 21) +#define IDR1_EVTQS GENMASK(20, 16) +#define IDR1_PRIQS GENMASK(15, 11) +#define IDR1_SSIDSIZE GENMASK(10, 6) +#define IDR1_SIDSIZE GENMASK(5, 0) + +#define ARM_SMMU_IDR5 0x14 +#define IDR5_STALL_MAX GENMASK(31, 16) +#define IDR5_GRAN64K (1 << 6) +#define IDR5_GRAN16K (1 << 5) +#define IDR5_GRAN4K (1 << 4) +#define IDR5_OAS GENMASK(2, 0) +#define IDR5_OAS_32_BIT 0 +#define IDR5_OAS_36_BIT 1 +#define IDR5_OAS_40_BIT 2 +#define IDR5_OAS_42_BIT 3 +#define IDR5_OAS_44_BIT 4 +#define IDR5_OAS_48_BIT 5 +#define IDR5_OAS_52_BIT 6 +#define IDR5_VAX GENMASK(11, 10) +#define IDR5_VAX_52_BIT 1 + +#define ARM_SMMU_CR0 0x20 +#define CR0_ATSCHK (1 << 4) +#define CR0_CMDQEN (1 << 3) +#define CR0_EVTQEN (1 << 2) +#define CR0_PRIQEN (1 << 1) +#define CR0_SMMUEN (1 << 0) + +#define ARM_SMMU_CR0ACK 0x24 + +#define ARM_SMMU_CR1 0x28 +#define CR1_TABLE_SH GENMASK(11, 10) +#define CR1_TABLE_OC GENMASK(9, 8) +#define CR1_TABLE_IC GENMASK(7, 6) +#define CR1_QUEUE_SH GENMASK(5, 4) +#define CR1_QUEUE_OC GENMASK(3, 2) +#define CR1_QUEUE_IC GENMASK(1, 0) +/* CR1 cacheability fields don't quite follow the usual TCR-style encoding */ +#define CR1_CACHE_NC 0 +#define CR1_CACHE_WB 1 +#define CR1_CACHE_WT 2 + +#define ARM_SMMU_CR2 0x2c +#define CR2_PTM (1 << 2) +#define CR2_RECINVSID (1 << 1) +#define CR2_E2H (1 << 0) + +#define ARM_SMMU_GBPA 0x44 +#define GBPA_UPDATE (1 << 31) +#define GBPA_ABORT (1 << 20) + +#define ARM_SMMU_IRQ_CTRL 0x50 +#define IRQ_CTRL_EVTQ_IRQEN (1 << 2) +#define IRQ_CTRL_PRIQ_IRQEN (1 << 1) +#define IRQ_CTRL_GERROR_IRQEN (1 << 0) + +#define ARM_SMMU_IRQ_CTRLACK 0x54 + +#define ARM_SMMU_GERROR 0x60 +#define GERROR_SFM_ERR (1 << 8) +#define GERROR_MSI_GERROR_ABT_ERR (1 << 7) +#define GERROR_MSI_PRIQ_ABT_ERR (1 << 6) +#define GERROR_MSI_EVTQ_ABT_ERR (1 << 5) +#define GERROR_MSI_CMDQ_ABT_ERR (1 << 4) +#define GERROR_PRIQ_ABT_ERR (1 << 3) +#define GERROR_EVTQ_ABT_ERR (1 << 2) +#define GERROR_CMDQ_ERR (1 << 0) +#define GERROR_ERR_MASK 0xfd + +#define ARM_SMMU_GERRORN 0x64 + +#define ARM_SMMU_GERROR_IRQ_CFG0 0x68 +#define ARM_SMMU_GERROR_IRQ_CFG1 0x70 +#define ARM_SMMU_GERROR_IRQ_CFG2 0x74 + +#define ARM_SMMU_STRTAB_BASE 0x80 +#define STRTAB_BASE_RA (1UL << 62) +#define STRTAB_BASE_ADDR_MASK GENMASK_ULL(51, 6) + +#define ARM_SMMU_STRTAB_BASE_CFG 0x88 +#define STRTAB_BASE_CFG_FMT GENMASK(17, 16) +#define STRTAB_BASE_CFG_FMT_LINEAR 0 +#define STRTAB_BASE_CFG_FMT_2LVL 1 +#define STRTAB_BASE_CFG_SPLIT GENMASK(10, 6) +#define STRTAB_BASE_CFG_LOG2SIZE GENMASK(5, 0) + +#define ARM_SMMU_CMDQ_BASE 0x90 +#define ARM_SMMU_CMDQ_PROD 0x98 +#define ARM_SMMU_CMDQ_CONS 0x9c + +#define ARM_SMMU_EVTQ_BASE 0xa0 +#define ARM_SMMU_EVTQ_PROD 0x100a8 +#define ARM_SMMU_EVTQ_CONS 0x100ac +#define ARM_SMMU_EVTQ_IRQ_CFG0 0xb0 +#define ARM_SMMU_EVTQ_IRQ_CFG1 0xb8 +#define ARM_SMMU_EVTQ_IRQ_CFG2 0xbc + +#define ARM_SMMU_PRIQ_BASE 0xc0 +#define ARM_SMMU_PRIQ_PROD 0x100c8 +#define ARM_SMMU_PRIQ_CONS 0x100cc +#define ARM_SMMU_PRIQ_IRQ_CFG0 0xd0 +#define ARM_SMMU_PRIQ_IRQ_CFG1 0xd8 +#define ARM_SMMU_PRIQ_IRQ_CFG2 0xdc + +#define ARM_SMMU_REG_SZ 0xe00 + +/* Common MSI config fields */ +#define MSI_CFG0_ADDR_MASK GENMASK_ULL(51, 2) +#define MSI_CFG2_SH GENMASK(5, 4) +#define MSI_CFG2_MEMATTR GENMASK(3, 0) + +/* Common memory attribute values */ +#define ARM_SMMU_SH_NSH 0 +#define ARM_SMMU_SH_OSH 2 +#define ARM_SMMU_SH_ISH 3 +#define ARM_SMMU_MEMATTR_DEVICE_nGnRE 0x1 +#define ARM_SMMU_MEMATTR_OIWB 0xf + +#define Q_IDX(llq, p) ((p) & ((1 << (llq)->max_n_shift) - 1)) +#define Q_WRP(llq, p) ((p) & (1 << (llq)->max_n_shift)) +#define Q_OVERFLOW_FLAG (1 << 31) +#define Q_OVF(p) ((p) & Q_OVERFLOW_FLAG) +#define Q_ENT(q, p) ((q)->base + \ + Q_IDX(&((q)->llq), p) * \ + (q)->ent_dwords) + +#define Q_BASE_RWA (1UL << 62) +#define Q_BASE_ADDR_MASK GENMASK_ULL(51, 5) +#define Q_BASE_LOG2SIZE GENMASK(4, 0) + +/* Ensure DMA allocations are naturally aligned */ +#ifdef CONFIG_CMA_ALIGNMENT +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + CONFIG_CMA_ALIGNMENT) +#else +#define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) +#endif + +/* + * Stream table. + * + * Linear: Enough to cover 1 << IDR1.SIDSIZE entries + * 2lvl: 128k L1 entries, + * 256 lazy entries per table (each table covers a PCI bus) + */ +#define STRTAB_L1_SZ_SHIFT 20 +#define STRTAB_SPLIT 8 + +#define STRTAB_L1_DESC_DWORDS 1 +#define STRTAB_L1_DESC_SPAN GENMASK_ULL(4, 0) +#define STRTAB_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 6) + +#define STRTAB_STE_DWORDS 8 +#define STRTAB_STE_0_V (1UL << 0) +#define STRTAB_STE_0_CFG GENMASK_ULL(3, 1) +#define STRTAB_STE_0_CFG_ABORT 0 +#define STRTAB_STE_0_CFG_BYPASS 4 +#define STRTAB_STE_0_CFG_S1_TRANS 5 +#define STRTAB_STE_0_CFG_S2_TRANS 6 + +#define STRTAB_STE_0_S1FMT GENMASK_ULL(5, 4) +#define STRTAB_STE_0_S1FMT_LINEAR 0 +#define STRTAB_STE_0_S1FMT_64K_L2 2 +#define STRTAB_STE_0_S1CTXPTR_MASK GENMASK_ULL(51, 6) +#define STRTAB_STE_0_S1CDMAX GENMASK_ULL(63, 59) + +#define STRTAB_STE_1_S1DSS GENMASK_ULL(1, 0) +#define STRTAB_STE_1_S1DSS_TERMINATE 0x0 +#define STRTAB_STE_1_S1DSS_BYPASS 0x1 +#define STRTAB_STE_1_S1DSS_SSID0 0x2 + +#define STRTAB_STE_1_S1C_CACHE_NC 0UL +#define STRTAB_STE_1_S1C_CACHE_WBRA 1UL +#define STRTAB_STE_1_S1C_CACHE_WT 2UL +#define STRTAB_STE_1_S1C_CACHE_WB 3UL +#define STRTAB_STE_1_S1CIR GENMASK_ULL(3, 2) +#define STRTAB_STE_1_S1COR GENMASK_ULL(5, 4) +#define STRTAB_STE_1_S1CSH GENMASK_ULL(7, 6) + +#define STRTAB_STE_1_S1STALLD (1UL << 27) + +#define STRTAB_STE_1_EATS GENMASK_ULL(29, 28) +#define STRTAB_STE_1_EATS_ABT 0UL +#define STRTAB_STE_1_EATS_TRANS 1UL +#define STRTAB_STE_1_EATS_S1CHK 2UL + +#define STRTAB_STE_1_STRW GENMASK_ULL(31, 30) +#define STRTAB_STE_1_STRW_NSEL1 0UL +#define STRTAB_STE_1_STRW_EL2 2UL + +#define STRTAB_STE_1_SHCFG GENMASK_ULL(45, 44) +#define STRTAB_STE_1_SHCFG_INCOMING 1UL + +#define STRTAB_STE_2_S2VMID GENMASK_ULL(15, 0) +#define STRTAB_STE_2_VTCR GENMASK_ULL(50, 32) +#define STRTAB_STE_2_VTCR_S2T0SZ GENMASK_ULL(5, 0) +#define STRTAB_STE_2_VTCR_S2SL0 GENMASK_ULL(7, 6) +#define STRTAB_STE_2_VTCR_S2IR0 GENMASK_ULL(9, 8) +#define STRTAB_STE_2_VTCR_S2OR0 GENMASK_ULL(11, 10) +#define STRTAB_STE_2_VTCR_S2SH0 GENMASK_ULL(13, 12) +#define STRTAB_STE_2_VTCR_S2TG GENMASK_ULL(15, 14) +#define STRTAB_STE_2_VTCR_S2PS GENMASK_ULL(18, 16) +#define STRTAB_STE_2_S2AA64 (1UL << 51) +#define STRTAB_STE_2_S2ENDI (1UL << 52) +#define STRTAB_STE_2_S2PTW (1UL << 54) +#define STRTAB_STE_2_S2R (1UL << 58) + +#define STRTAB_STE_3_S2TTB_MASK GENMASK_ULL(51, 4) + +/* + * Context descriptors. + * + * Linear: when less than 1024 SSIDs are supported + * 2lvl: at most 1024 L1 entries, + * 1024 lazy entries per table. + */ +#define CTXDESC_SPLIT 10 +#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) + +#define CTXDESC_L1_DESC_DWORDS 1 +#define CTXDESC_L1_DESC_V (1UL << 0) +#define CTXDESC_L1_DESC_L2PTR_MASK GENMASK_ULL(51, 12) + +#define CTXDESC_CD_DWORDS 8 +#define CTXDESC_CD_0_TCR_T0SZ GENMASK_ULL(5, 0) +#define CTXDESC_CD_0_TCR_TG0 GENMASK_ULL(7, 6) +#define CTXDESC_CD_0_TCR_IRGN0 GENMASK_ULL(9, 8) +#define CTXDESC_CD_0_TCR_ORGN0 GENMASK_ULL(11, 10) +#define CTXDESC_CD_0_TCR_SH0 GENMASK_ULL(13, 12) +#define CTXDESC_CD_0_TCR_EPD0 (1ULL << 14) +#define CTXDESC_CD_0_TCR_EPD1 (1ULL << 30) + +#define CTXDESC_CD_0_ENDI (1UL << 15) +#define CTXDESC_CD_0_V (1UL << 31) + +#define CTXDESC_CD_0_TCR_IPS GENMASK_ULL(34, 32) +#define CTXDESC_CD_0_TCR_TBI0 (1ULL << 38) + +#define CTXDESC_CD_0_AA64 (1UL << 41) +#define CTXDESC_CD_0_S (1UL << 44) +#define CTXDESC_CD_0_R (1UL << 45) +#define CTXDESC_CD_0_A (1UL << 46) +#define CTXDESC_CD_0_ASET (1UL << 47) +#define CTXDESC_CD_0_ASID GENMASK_ULL(63, 48) + +#define CTXDESC_CD_1_TTB0_MASK GENMASK_ULL(51, 4) + +/* + * When the SMMU only supports linear context descriptor tables, pick a + * reasonable size limit (64kB). + */ +#define CTXDESC_LINEAR_CDMAX ilog2(SZ_64K / (CTXDESC_CD_DWORDS << 3)) + +/* Command queue */ +#define CMDQ_ENT_SZ_SHIFT 4 +#define CMDQ_ENT_DWORDS ((1 << CMDQ_ENT_SZ_SHIFT) >> 3) +#define CMDQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - CMDQ_ENT_SZ_SHIFT) + +#define CMDQ_CONS_ERR GENMASK(30, 24) +#define CMDQ_ERR_CERROR_NONE_IDX 0 +#define CMDQ_ERR_CERROR_ILL_IDX 1 +#define CMDQ_ERR_CERROR_ABT_IDX 2 +#define CMDQ_ERR_CERROR_ATC_INV_IDX 3 + +#define CMDQ_0_OP GENMASK_ULL(7, 0) +#define CMDQ_0_SSV (1UL << 11) + +#define CMDQ_PREFETCH_0_SID GENMASK_ULL(63, 32) +#define CMDQ_PREFETCH_1_SIZE GENMASK_ULL(4, 0) +#define CMDQ_PREFETCH_1_ADDR_MASK GENMASK_ULL(63, 12) + +#define CMDQ_CFGI_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_CFGI_0_SID GENMASK_ULL(63, 32) +#define CMDQ_CFGI_1_LEAF (1UL << 0) +#define CMDQ_CFGI_1_RANGE GENMASK_ULL(4, 0) + +#define CMDQ_TLBI_0_VMID GENMASK_ULL(47, 32) +#define CMDQ_TLBI_0_ASID GENMASK_ULL(63, 48) +#define CMDQ_TLBI_1_LEAF (1UL << 0) +#define CMDQ_TLBI_1_VA_MASK GENMASK_ULL(63, 12) +#define CMDQ_TLBI_1_IPA_MASK GENMASK_ULL(51, 12) + +#define CMDQ_ATC_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_ATC_0_SID GENMASK_ULL(63, 32) +#define CMDQ_ATC_0_GLOBAL (1UL << 9) +#define CMDQ_ATC_1_SIZE GENMASK_ULL(5, 0) +#define CMDQ_ATC_1_ADDR_MASK GENMASK_ULL(63, 12) + +#define CMDQ_PRI_0_SSID GENMASK_ULL(31, 12) +#define CMDQ_PRI_0_SID GENMASK_ULL(63, 32) +#define CMDQ_PRI_1_GRPID GENMASK_ULL(8, 0) +#define CMDQ_PRI_1_RESP GENMASK_ULL(13, 12) + +#define CMDQ_SYNC_0_CS GENMASK_ULL(13, 12) +#define CMDQ_SYNC_0_CS_NONE 0 +#define CMDQ_SYNC_0_CS_IRQ 1 +#define CMDQ_SYNC_0_CS_SEV 2 +#define CMDQ_SYNC_0_MSH GENMASK_ULL(23, 22) +#define CMDQ_SYNC_0_MSIATTR GENMASK_ULL(27, 24) +#define CMDQ_SYNC_0_MSIDATA GENMASK_ULL(63, 32) +#define CMDQ_SYNC_1_MSIADDR_MASK GENMASK_ULL(51, 2) + +/* Event queue */ +#define EVTQ_ENT_SZ_SHIFT 5 +#define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) +#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) + +#define EVTQ_0_ID GENMASK_ULL(7, 0) + +/* PRI queue */ +#define PRIQ_ENT_SZ_SHIFT 4 +#define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) +#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) + +#define PRIQ_0_SID GENMASK_ULL(31, 0) +#define PRIQ_0_SSID GENMASK_ULL(51, 32) +#define PRIQ_0_PERM_PRIV (1UL << 58) +#define PRIQ_0_PERM_EXEC (1UL << 59) +#define PRIQ_0_PERM_READ (1UL << 60) +#define PRIQ_0_PERM_WRITE (1UL << 61) +#define PRIQ_0_PRG_LAST (1UL << 62) +#define PRIQ_0_SSID_V (1UL << 63) + +#define PRIQ_1_PRG_IDX GENMASK_ULL(8, 0) +#define PRIQ_1_ADDR_MASK GENMASK_ULL(63, 12) + +/* High-level queue structures */ +#define ARM_SMMU_POLL_TIMEOUT_US 100 +#define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ +#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 + +#define FIELD_PREP(_mask, _val) \ + (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask)) + +#define FIELD_GET(_mask, _reg) \ + ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1))) + +/* Linux compatibility functions. */ +typedef paddr_t dma_addr_t; +typedef paddr_t phys_addr_t; +typedef unsigned int gfp_t; + +/* Alias to Xen lock functions */ +#define mutex spinlock +#define mutex_init spin_lock_init +#define mutex_lock spin_lock +#define mutex_unlock spin_unlock + +/* SMMU private data for an IOMMU domain */ +enum arm_smmu_domain_stage { + ARM_SMMU_DOMAIN_S1 = 0, + ARM_SMMU_DOMAIN_S2, + ARM_SMMU_DOMAIN_NESTED, + ARM_SMMU_DOMAIN_BYPASS, +}; + +/* Xen specific code. */ +struct iommu_domain { + /* Runtime SMMU configuration for this iommu_domain */ + atomic_t ref; + /* + * Used to link iommu_domain contexts for a same domain. + * There is at least one per-SMMU to used by the domain. + */ + struct list_head list; +}; + +/* Describes information required for a Xen domain */ +struct arm_smmu_xen_domain { + spinlock_t lock; + + /* List of iommu domains associated to this domain */ + struct list_head contexts; +}; + +enum pri_resp { + PRI_RESP_DENY = 0, + PRI_RESP_FAIL = 1, + PRI_RESP_SUCC = 2, +}; + +#ifdef CONFIG_MSI +enum arm_smmu_msi_index { + EVTQ_MSI_INDEX, + GERROR_MSI_INDEX, + PRIQ_MSI_INDEX, + ARM_SMMU_MAX_MSIS, +}; + +static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = { + [EVTQ_MSI_INDEX] = { + ARM_SMMU_EVTQ_IRQ_CFG0, + ARM_SMMU_EVTQ_IRQ_CFG1, + ARM_SMMU_EVTQ_IRQ_CFG2, + }, + [GERROR_MSI_INDEX] = { + ARM_SMMU_GERROR_IRQ_CFG0, + ARM_SMMU_GERROR_IRQ_CFG1, + ARM_SMMU_GERROR_IRQ_CFG2, + }, + [PRIQ_MSI_INDEX] = { + ARM_SMMU_PRIQ_IRQ_CFG0, + ARM_SMMU_PRIQ_IRQ_CFG1, + ARM_SMMU_PRIQ_IRQ_CFG2, + }, +}; +#endif /* CONFIG_MSI */ + +struct arm_smmu_cmdq_ent { + /* Common fields */ + u8 opcode; + bool substream_valid; + + /* Command-specific fields */ + union { + #define CMDQ_OP_PREFETCH_CFG 0x1 + struct { + u32 sid; + u8 size; + u64 addr; + } prefetch; + + #define CMDQ_OP_CFGI_STE 0x3 + #define CMDQ_OP_CFGI_ALL 0x4 + struct { + u32 sid; + union { + bool leaf; + u8 span; + }; + } cfgi; + + #define CMDQ_OP_TLBI_EL2_ALL 0x20 + #define CMDQ_OP_TLBI_S12_VMALL 0x28 + #define CMDQ_OP_TLBI_S2_IPA 0x2a + #define CMDQ_OP_TLBI_NSNH_ALL 0x30 + struct { + u16 asid; + u16 vmid; + bool leaf; + u64 addr; + } tlbi; + + #define CMDQ_OP_ATC_INV 0x40 + #define ATC_INV_SIZE_ALL 52 + struct { + u32 sid; + u32 ssid; + u64 addr; + u8 size; + bool global; + } atc; + + #define CMDQ_OP_PRI_RESP 0x41 + struct { + u32 sid; + u32 ssid; + u16 grpid; + enum pri_resp resp; + } pri; + + #define CMDQ_OP_CMD_SYNC 0x46 + struct { + u32 msidata; + u64 msiaddr; + } sync; + }; +}; + +struct arm_smmu_ll_queue { + u32 prod; + u32 cons; + u32 max_n_shift; +}; + +struct arm_smmu_queue { + struct arm_smmu_ll_queue llq; + int irq; /* Wired interrupt */ + + __le64 *base; + dma_addr_t base_dma; + u64 q_base; + + size_t ent_dwords; + + u32 __iomem *prod_reg; + u32 __iomem *cons_reg; +}; + +struct arm_smmu_cmdq { + struct arm_smmu_queue q; + spinlock_t lock; +}; + +struct arm_smmu_evtq { + struct arm_smmu_queue q; + u32 max_stalls; +}; + +struct arm_smmu_priq { + struct arm_smmu_queue q; +}; + +/* High-level stream table and context descriptor structures */ +struct arm_smmu_strtab_l1_desc { + u8 span; + + __le64 *l2ptr; + dma_addr_t l2ptr_dma; +}; + +struct arm_smmu_s2_cfg { + u16 vmid; + u64 vttbr; + u64 vtcr; +}; + +struct arm_smmu_strtab_cfg { + __le64 *strtab; + dma_addr_t strtab_dma; + struct arm_smmu_strtab_l1_desc *l1_desc; + unsigned int num_l1_ents; + + u64 strtab_base; + u32 strtab_base_cfg; +}; + +struct arm_lpae_s2_cfg { + u64 vttbr; + struct { + u32 ps:3; + u32 tg:2; + u32 sh:2; + u32 orgn:2; + u32 irgn:2; + u32 sl:2; + u32 tsz:6; + } vtcr; +}; + +/* An SMMUv3 instance */ +struct arm_smmu_device { + struct device *dev; + void __iomem *base; + void __iomem *page1; + +#define ARM_SMMU_FEAT_2_LVL_STRTAB (1 << 0) +#define ARM_SMMU_FEAT_2_LVL_CDTAB (1 << 1) +#define ARM_SMMU_FEAT_TT_LE (1 << 2) +#define ARM_SMMU_FEAT_TT_BE (1 << 3) +#define ARM_SMMU_FEAT_PRI (1 << 4) +#define ARM_SMMU_FEAT_ATS (1 << 5) +#define ARM_SMMU_FEAT_SEV (1 << 6) +#define ARM_SMMU_FEAT_MSI (1 << 7) +#define ARM_SMMU_FEAT_COHERENCY (1 << 8) +#define ARM_SMMU_FEAT_TRANS_S1 (1 << 9) +#define ARM_SMMU_FEAT_TRANS_S2 (1 << 10) +#define ARM_SMMU_FEAT_STALLS (1 << 11) +#define ARM_SMMU_FEAT_HYP (1 << 12) +#define ARM_SMMU_FEAT_STALL_FORCE (1 << 13) +#define ARM_SMMU_FEAT_VAX (1 << 14) + u32 features; + +#define ARM_SMMU_OPT_SKIP_PREFETCH (1 << 0) +#define ARM_SMMU_OPT_PAGE0_REGS_ONLY (1 << 1) + u32 options; + + struct arm_smmu_cmdq cmdq; + struct arm_smmu_evtq evtq; + struct arm_smmu_priq priq; + + int gerr_irq; + int combined_irq; + u32 sync_nr; + u8 prev_cmd_opcode; + + unsigned long ias; /* IPA */ + unsigned long oas; /* PA */ + unsigned long pgsize_bitmap; + +#define ARM_SMMU_MAX_VMIDS (1 << 16) + unsigned int vmid_bits; + DECLARE_BITMAP(vmid_map, ARM_SMMU_MAX_VMIDS); + + unsigned int sid_bits; + + struct arm_smmu_strtab_cfg strtab_cfg; + + /* Hi16xx adds an extra 32 bits of goodness to its MSI payload */ + union { + u32 sync_count; + u64 padding; + }; + + /* Need to keep a list of SMMU devices */ + struct list_head devices; + + /* Tasklets for handling evts/faults and pci page request IRQs*/ + struct tasklet evtq_irq_tasklet; + struct tasklet priq_irq_tasklet; + struct tasklet combined_irq_tasklet; +}; + +/* SMMU private data for each master */ +struct arm_smmu_master { + struct arm_smmu_device *smmu; + struct device *dev; + struct arm_smmu_domain *domain; + struct list_head domain_head; + u32 *sids; + unsigned int num_sids; + bool ats_enabled; +}; + +struct arm_smmu_domain { + struct arm_smmu_device *smmu; + struct mutex init_mutex; /* Protects smmu pointer */ + + bool non_strict; + atomic_t nr_ats_masters; + + enum arm_smmu_domain_stage stage; + struct arm_smmu_s2_cfg s2_cfg; + + /* Xen domain associated with this SMMU domain */ + struct domain *d; + + struct iommu_domain domain; + + struct list_head devices; + spinlock_t devices_lock; +}; + +#endif /* _ARM_SMMU_V3_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:49:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:49:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400315.642032 (Exim 4.92) (envelope-from ) id 1oVgRq-0006Io-J7; Tue, 06 Sep 2022 21:49:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400315.642032; Tue, 06 Sep 2022 21:49:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgRq-0006I6-GH; Tue, 06 Sep 2022 21:49:34 +0000 Received: by outflank-mailman (input) for mailman id 400315; Tue, 06 Sep 2022 21:49:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIY-0000Cs-J3 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id e2bdeef3-2de9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 15:43:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 194701A2D; Tue, 6 Sep 2022 06:43:33 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C62643F7B4; Tue, 6 Sep 2022 06:43:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2bdeef3-2de9-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 7/7] xen/arm: introduce xen-evtchn dom0less property Date: Tue, 6 Sep 2022 14:40:45 +0100 Message-Id: <055660c342c85cd97d6e3a5551c84e62f49dece6.1662462034.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=Y Content-Transfer-Encoding: 8bit Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send notifications to each other. Signed-off-by: Rahul Singh --- Changes in v4: - move documentation to common place for evtchn node in booting.txt - Add comment why we use dt_device_static_evtchn_created() - check if dt_get_parent() returns NULL - fold process_static_evtchn_node() in alloc_static_evtchn() Changes in v3: - use device-tree used_by to find the domain id of the evtchn node. - add new static_evtchn_create variable in struct dt_device_node to hold the information if evtchn is already created. - fix minor comments Changes in v2: - no change --- docs/misc/arm/device-tree/booting.txt | 98 +++++++++++++++++ xen/arch/arm/domain_build.c | 147 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 2 + xen/include/xen/device_tree.h | 16 +++ 5 files changed, 264 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 1b0dca1454..c8329b73e5 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -382,3 +382,101 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Event Channel +==================== +The event channel communication will be established statically between two +domains (dom0 and domU also). Event channel connection information between +domains will be passed to Xen via the device tree node. The event channel +will be created and established in Xen before the domain started. The domain +doesn’t need to do any operation to establish a connection. Domain only +needs hypercall EVTCHNOP_send(local port) to send notifications to the +remote guest. + +There is no need to describe the static event channel info in the domU device +tree. Static event channels are only useful in fully static configurations, +and in those configurations, the domU device tree dynamically generated by Xen +is not needed. + +To enable the event-channel interface for domU guests include the +"xen,enhanced = "no-xenstore"" property in the domU Xen device tree node. + +Under the "xen,domain" compatible node for domU, there needs to be sub-nodes +with compatible "xen,evtchn" that describe the event channel connection +between two domUs. For dom0, there needs to be sub-nodes with compatible +"xen,evtchn" under the chosen node. + +The static event channel node has the following properties: + +- compatible + + "xen,evtchn" + +- xen,evtchn + + The property is tuples of two numbers + (local-evtchn link-to-foreign-evtchn) where: + + local-evtchn is an integer value that will be used to allocate local port + for a domain to send and receive event notifications to/from the remote + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. + It is recommended to use low event channel IDs. + + link-to-foreign-evtchn is a single phandle to a remote evtchn to which + local-evtchn will be connected. + +Example +======= + +chosen { + + /* one sub-node per local event channel */ + ec1: evtchn@1 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec2>; + }; + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x2>; + #size-cells = <0x1>; + xen,enhanced = "no-xenstore"; + + /* one sub-node per local event channel */ + ec2: evtchn@2 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec1>; + }; + + ec3: evtchn@3 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xb &ec5>; + }; + + ec4: evtchn@4 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xc &ec6>; + }; + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x2>; + #size-cells = <0x1>; + xen,enhanced = "no-xenstore"; + + /* one sub-node per local event channel */ + ec5: evtchn@5 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xb &ec3>; + }; + + ec6: evtchn@6 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xd &ec4>; + }; + }; +}; diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 0b164ef595..bb96fa5096 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -33,6 +33,8 @@ #include #include +#define STATIC_EVTCHN_NODE_SIZE_CELLS 2 + static unsigned int __initdata opt_dom0_max_vcpus; integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); @@ -3052,6 +3054,150 @@ void __init evtchn_allocate(struct domain *d) d->arch.hvm.params[HVM_PARAM_CALLBACK_IRQ] = val; } +static int __init get_evtchn_dt_property(const struct dt_device_node *np, + uint32_t *port, uint32_t *phandle) +{ + const __be32 *prop = NULL; + uint32_t len; + + prop = dt_get_property(np, "xen,evtchn", &len); + if ( !prop ) + { + printk(XENLOG_ERR "xen,evtchn property should not be empty.\n"); + return -EINVAL; + } + + if ( !len || len < dt_cells_to_size(STATIC_EVTCHN_NODE_SIZE_CELLS) ) + { + printk(XENLOG_ERR "xen,evtchn property value is not valid.\n"); + return -EINVAL; + } + + *port = dt_next_cell(1, &prop); + *phandle = dt_next_cell(1, &prop); + + return 0; +} + +static int __init alloc_domain_evtchn(struct dt_device_node *node) +{ + int rc; + uint32_t domU1_port, domU2_port, remote_phandle; + struct dt_device_node *remote_node; + const struct dt_device_node *p1_node, *p2_node; + struct evtchn_alloc_unbound alloc_unbound; + struct evtchn_bind_interdomain bind_interdomain; + struct domain *d1 = NULL, *d2 = NULL; + + if ( !dt_device_is_compatible(node, "xen,evtchn-v1") ) + return 0; + + /* + * Event channel is already created while parsing the other side of + * evtchn node. + */ + if ( dt_device_static_evtchn_created(node) ) + return 0; + + rc = get_evtchn_dt_property(node, &domU1_port, &remote_phandle); + if ( rc ) + return rc; + + remote_node = dt_find_node_by_phandle(remote_phandle); + if ( !remote_node ) + { + printk(XENLOG_ERR + "evtchn: could not find remote evtchn phandle\n"); + return -EINVAL; + } + + rc = get_evtchn_dt_property(remote_node, &domU2_port, &remote_phandle); + if ( rc ) + return rc; + + if ( node->phandle != remote_phandle ) + { + printk(XENLOG_ERR "xen,evtchn property is not setup correctly.\n"); + return -EINVAL; + } + + p1_node = dt_get_parent(node); + if ( !p1_node ) + { + printk(XENLOG_ERR "evtchn: evtchn parent node is NULL\n" ); + return -EINVAL; + } + + p2_node = dt_get_parent(remote_node); + if ( !p2_node ) + { + printk(XENLOG_ERR "evtchn: remote parent node is NULL\n" ); + return -EINVAL; + } + + d1 = get_domain_by_id(p1_node->used_by); + d2 = get_domain_by_id(p2_node->used_by); + + if ( !d1 || !d2 ) + { + printk(XENLOG_ERR "evtchn: could not find domains\n" ); + return -EINVAL; + } + + alloc_unbound.dom = d1->domain_id; + alloc_unbound.remote_dom = d2->domain_id; + + rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); + if ( rc < 0 ) + { + printk(XENLOG_ERR + "evtchn_alloc_unbound() failure (Error %d) \n", rc); + return rc; + } + + bind_interdomain.remote_dom = d1->domain_id; + bind_interdomain.remote_port = domU1_port; + + rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port); + if ( rc < 0 ) + { + printk(XENLOG_ERR + "evtchn_bind_interdomain() failure (Error %d) \n", rc); + return rc; + } + + dt_device_set_static_evtchn_created(node); + dt_device_set_static_evtchn_created(remote_node); + + return 0; +} + +void __init alloc_static_evtchn(void) +{ + struct dt_device_node *node, *evtchn_node; + struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); + + BUG_ON(chosen == NULL); + + if ( hardware_domain ) + dt_device_set_used_by(chosen, hardware_domain->domain_id); + + dt_for_each_child_node(chosen, node) + { + if ( hardware_domain ) + { + if ( alloc_domain_evtchn(node) != 0 ) + panic("Could not set up domains evtchn\n"); + } + + dt_for_each_child_node(node, evtchn_node) + { + if ( alloc_domain_evtchn(evtchn_node) != 0 ) + panic("Could not set up domains evtchn\n"); + } + } +} + static void __init find_gnttab_region(struct domain *d, struct kernel_info *kinfo) { @@ -3366,6 +3512,7 @@ void __init create_domUs(void) panic("Error creating domain %s\n", dt_node_name(node)); d->is_console = true; + dt_device_set_used_by(node, d->domain_id); if ( construct_domU(d, node) != 0 ) panic("Could not set up domain %s\n", dt_node_name(node)); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..5ee28b270f 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -106,6 +106,7 @@ int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); void create_domUs(void); void create_dom0(void); +void alloc_static_evtchn(void); void discard_initial_modules(void); void fw_unreserved_regions(paddr_t s, paddr_t e, diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 6e0398f3f6..cf15d359d2 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1077,6 +1077,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); + alloc_static_evtchn(); + /* * This needs to be called **before** heap_init_late() so modules * will be scrubbed (unless suppressed). diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 430a1ef445..a28937d12a 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -92,6 +92,10 @@ struct dt_device_node { /* IOMMU specific fields */ bool is_protected; + + /* HACK: Remove this if there is a need of space */ + bool_t static_evtchn_created; + /* * The main purpose of this list is to link the structure in the list * of devices assigned to domain. @@ -317,6 +321,18 @@ static inline bool_t dt_property_name_is_equal(const struct dt_property *pp, return !dt_prop_cmp(pp->name, name); } +static inline void +dt_device_set_static_evtchn_created(struct dt_device_node *device) +{ + device->static_evtchn_created = true; +} + +static inline bool_t +dt_device_static_evtchn_created(const struct dt_device_node *device) +{ + return device->static_evtchn_created; +} + /** * dt_find_compatible_node - Find a node based on type and one of the * tokens in its "compatible" property -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:49:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:49:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400346.642044 (Exim 4.92) (envelope-from ) id 1oVgSC-0007WW-To; Tue, 06 Sep 2022 21:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400346.642044; Tue, 06 Sep 2022 21:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSC-0007WP-PO; Tue, 06 Sep 2022 21:49:56 +0000 Received: by outflank-mailman (input) for mailman id 400346; Tue, 06 Sep 2022 21:49:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIW-0000Cs-Ii for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:56 +0000 Received: from mail136-23.atl41.mandrillapp.com (mail136-23.atl41.mandrillapp.com [198.2.136.23]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2f74d4e-2dc9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:54:24 +0200 (CEST) Received: from pmta11.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail136-23.atl41.mandrillapp.com (Mailchimp) with ESMTP id 4MMLMP1T42z1XLFCT for ; Tue, 6 Sep 2022 09:54:25 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id a8dca91a88494f7f8b1011af811f372b; Tue, 06 Sep 2022 09:54:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2f74d4e-2dc9-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1662458065; x=1662760465; i=andrei.semenov@vates.fr; bh=pQxC6Pftr2jRoWbYvo9cSoey9URYE0qRetJUWBPSTIk=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=J90RHZxdhtwm0LlZD5oP7VGWGxM2WYnsvbxujyoIj7OZyxJ2L8DcSnznz0iwWhGQx 4j8zU2jvtl8f6/tVakm3nXQpuDvU0ui833kHI6YphNgRKEWWa9VteIIOMYKVAUwOhE Y+9kAWW5xFh7MBCSzKb01D1BXCvqY4p5wCLaB1t4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1662458065; h=From : Subject : To : Cc : Message-Id : In-Reply-To : References : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=pQxC6Pftr2jRoWbYvo9cSoey9URYE0qRetJUWBPSTIk=; b=e0+uul0MFDsDLUDNu96xRuh9CG/82ragY2k/HAkqMg56LHNA/ReMr5e51SC+DdBmoopGXO Eadu31KqK0bTJRk/lzpfBgCrt940lXdKeR9B5VbqIeAcRYbJiwTxiyU5SRABg3Jkkvm2CvQn CIg/M9VSPS2AD5mopYBo9SHRA4HeA= From: Andrei Semenov Subject: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible X-Mailer: git-send-email 2.34.1 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 5cd6f291-6f11-459d-97c0-d09b574c3896 X-Bm-Transport-Timestamp: 1662458064080 To: andrei.semenov@vates.fr, xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Juergen Gross Message-Id: <657d6dad39f4ab87569470c94afb4cc6d005e829.1662457291.git.andrei.semenov@vates.fr> In-Reply-To: References: X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.a8dca91a88494f7f8b1011af811f372b X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20220906:md Date: Tue, 06 Sep 2022 09:54:25 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Implement an heuristic for X86 HVM guests which tries to use superpages while populating guest physmap on live migration. This should impove memory accesses performances for these guests. Signed-off-by: Andrei Semenov --- tools/include/xen-tools/libs.h | 4 ++ tools/libs/guest/xg_private.h | 3 + tools/libs/guest/xg_sr_common.h | 18 ++++- tools/libs/guest/xg_sr_restore.c | 60 +++++++--------- tools/libs/guest/xg_sr_restore_x86_hvm.c | 88 +++++++++++++++++++++++- tools/libs/guest/xg_sr_restore_x86_pv.c | 22 +++++- 6 files changed, 154 insertions(+), 41 deletions(-) diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/libs.h index a16e0c3807..bdd903eb7b 100644 --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/libs.h @@ -63,4 +63,8 @@ #define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1)) #endif +#ifndef ROUNDDOWN +#define ROUNDDOWN(_x,_w) ((unsigned long)(_x) & (-1UL << (_w))) +#endif + #endif /* __XEN_TOOLS_LIBS__ */ diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 09e24f1227..dcf63b5188 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -134,6 +134,9 @@ typedef uint64_t x86_pgentry_t; #define PAGE_SIZE_X86 (1UL << PAGE_SHIFT_X86) #define PAGE_MASK_X86 (~(PAGE_SIZE_X86-1)) +#define S_PAGE_1GB_ORDER 18 +#define S_PAGE_2MB_ORDER 9 + #define NRPAGES(x) (ROUNDUP(x, PAGE_SHIFT) >> PAGE_SHIFT) static inline xen_pfn_t xc_pfn_to_mfn(xen_pfn_t pfn, xen_pfn_t *p2m, diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index 941e24d7b7..96365e05a8 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -137,7 +137,8 @@ struct xc_sr_restore_ops bool (*pfn_is_valid)(const struct xc_sr_context *ctx, xen_pfn_t pfn); /* Set the GFN of a PFN. */ - void (*set_gfn)(struct xc_sr_context *ctx, xen_pfn_t pfn, xen_pfn_t gfn); + void (*set_gfn)(struct xc_sr_context *ctx, xen_pfn_t pfn, xen_pfn_t gfn, + unsigned int order); /* Set the type of a PFN. */ void (*set_page_type)(struct xc_sr_context *ctx, xen_pfn_t pfn, @@ -175,6 +176,17 @@ struct xc_sr_restore_ops #define BROKEN_CHANNEL 2 int (*process_record)(struct xc_sr_context *ctx, struct xc_sr_record *rec); + /** + * Guest physmap population order is based on heuristic which is family + * dependant. X86 HVM heuristic is interested in observing the whole + * record (the first) in order to guess how the physmap should be populated. + */ + void (*guess_physmap)(struct xc_sr_context *ctx, unsigned int count, + const xen_pfn_t *pfns, const uint32_t *types); + + /* Get the physmap population order for given PFN */ + int (*get_physmap_order)(const struct xc_sr_context *ctx, xen_pfn_t pfn); + /** * Perform any actions required after the static data has arrived. Called * when the STATIC_DATA_COMPLETE record has been recieved/inferred. @@ -404,6 +416,10 @@ struct xc_sr_context { /* HVM context blob. */ struct xc_sr_blob context; + + /* Set guest type (based on the first record) */ + bool set_guest_type; + bool pvh_guest; } restore; }; } hvm; diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs/guest/xg_sr_restore.c index 074b56d263..af864bd5ea 100644 --- a/tools/libs/guest/xg_sr_restore.c +++ b/tools/libs/guest/xg_sr_restore.c @@ -86,18 +86,21 @@ static bool pfn_is_populated(const struct xc_sr_context *ctx, xen_pfn_t pfn) * avoid realloc()ing too excessively, the size increased to the nearest power * of two large enough to contain the required pfn. */ -static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) +static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn, + unsigned int order) { xc_interface *xch = ctx->xch; + xen_pfn_t start_pfn = ROUNDDOWN(pfn, order), + end_pfn = (ROUNDUP(pfn + 1, order) - 1); - if ( pfn > ctx->restore.max_populated_pfn ) + if ( end_pfn > ctx->restore.max_populated_pfn ) { xen_pfn_t new_max; size_t old_sz, new_sz; unsigned long *p; /* Round up to the nearest power of two larger than pfn, less 1. */ - new_max = pfn; + new_max = end_pfn; new_max |= new_max >> 1; new_max |= new_max >> 2; new_max |= new_max >> 4; @@ -123,8 +126,11 @@ static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) ctx->restore.max_populated_pfn = new_max; } - assert(!test_bit(pfn, ctx->restore.populated_pfns)); - set_bit(pfn, ctx->restore.populated_pfns); + for ( pfn = start_pfn; pfn <= end_pfn; ++pfn ) + { + assert(!test_bit(pfn, ctx->restore.populated_pfns)); + set_bit(pfn, ctx->restore.populated_pfns); + } return 0; } @@ -138,60 +144,40 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, const xen_pfn_t *original_pfns, const uint32_t *types) { xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = malloc(count * sizeof(*mfns)), - *pfns = malloc(count * sizeof(*pfns)); - unsigned int i, nr_pfns = 0; + xen_pfn_t mfn, pfn; + unsigned int i, order; int rc = -1; - if ( !mfns || !pfns ) - { - ERROR("Failed to allocate %zu bytes for populating the physmap", - 2 * count * sizeof(*mfns)); - goto err; - } + /* Feed this record for family dependant heuristic to guess the physmap */ + ctx->restore.ops.guess_physmap(ctx, count, original_pfns, types); for ( i = 0; i < count; ++i ) { if ( (!types || page_type_to_populate(types[i])) && !pfn_is_populated(ctx, original_pfns[i]) ) { - rc = pfn_set_populated(ctx, original_pfns[i]); + order = ctx->restore.ops.get_physmap_order(ctx, original_pfns[i]); + rc = pfn_set_populated(ctx, original_pfns[i], order); if ( rc ) goto err; - pfns[nr_pfns] = mfns[nr_pfns] = original_pfns[i]; - ++nr_pfns; - } - } - - if ( nr_pfns ) - { - rc = xc_domain_populate_physmap_exact( - xch, ctx->domid, nr_pfns, 0, 0, mfns); - if ( rc ) - { - PERROR("Failed to populate physmap"); - goto err; - } - for ( i = 0; i < nr_pfns; ++i ) - { - if ( mfns[i] == INVALID_MFN ) + pfn = mfn = ROUNDDOWN(original_pfns[i], order); + rc = xc_domain_populate_physmap_exact(xch, ctx->domid, 1, order, 0, + &mfn); + if ( rc || (mfn == INVALID_MFN) ) { - ERROR("Populate physmap failed for pfn %u", i); + ERROR("Failed to populate physmap for pfn %lu (%u)", pfn, order); rc = -1; goto err; } - ctx->restore.ops.set_gfn(ctx, pfns[i], mfns[i]); + ctx->restore.ops.set_gfn(ctx, pfn, mfn, order); } } rc = 0; err: - free(pfns); - free(mfns); - return rc; } diff --git a/tools/libs/guest/xg_sr_restore_x86_hvm.c b/tools/libs/guest/xg_sr_restore_x86_hvm.c index d6ea6f3012..2e525443ab 100644 --- a/tools/libs/guest/xg_sr_restore_x86_hvm.c +++ b/tools/libs/guest/xg_sr_restore_x86_hvm.c @@ -110,7 +110,7 @@ static xen_pfn_t x86_hvm_pfn_to_gfn(const struct xc_sr_context *ctx, /* restore_ops function. */ static void x86_hvm_set_gfn(struct xc_sr_context *ctx, xen_pfn_t pfn, - xen_pfn_t gfn) + xen_pfn_t gfn, unsigned int order) { /* no op */ } @@ -161,6 +161,8 @@ static int x86_hvm_setup(struct xc_sr_context *ctx) } #endif + ctx->x86.hvm.restore.set_guest_type = true; + return 0; } @@ -192,6 +194,88 @@ static int x86_hvm_process_record(struct xc_sr_context *ctx, } } +/* + * We consider that PVH guest physmap starts from 0 and coninugiously cover the + * pysical memory space for the first GB of memory. HVM guest will have I/0 + * holes in the first 2MB of memory space (at least for VGA). Therefore we + * should observe the very first record (wich comes in physmap order) to find + * out how we should map this first GB. + * To map the rest of the memory space in both cases (PVH or HVM) we will use + * the maximum available order (up to 1GB), except for forth GB wich holds the + * low MMIO hole (at least for LAPIC MMIO window and for potential passthroughed + * or emulated PCI devices BARs). + */ +static void x86_hvm_guess_physmap(struct xc_sr_context *ctx, unsigned int count, + const xen_pfn_t *pfns, const uint32_t *types) +{ + xen_pfn_t prev; + unsigned int i; + + + if ( !ctx->x86.hvm.restore.set_guest_type ) + return; + + for ( i = 0, prev = INVALID_PFN; i < count; ++i ) + { + if ( !types || page_type_to_populate(types[i]) ) + { + if ( prev == INVALID_MFN ) + { + if (pfns[i] != 0) + break; + } + else + { + if ( pfns[i] != (prev + 1) ) + break; + } + prev = pfns[i]; + } + } + + ctx->x86.hvm.restore.pvh_guest = (i == count) ? true : false; + ctx->x86.hvm.restore.set_guest_type = false; +} + +/* + * + */ +static int x86_hvm_get_physmap_order(const struct xc_sr_context *ctx, + xen_pfn_t pfn) +{ + int order; + + if ( pfn >= ctx->restore.p2m_size ) + return 0; + + switch (pfn >> S_PAGE_1GB_ORDER) + { + case 3: + /* The forth GB of memory is mapped with 2MB superpages */ + order = S_PAGE_2MB_ORDER; + break; + case 0: + if (!ctx->x86.hvm.restore.pvh_guest) + { + /* First 2MB are mapped as 4K for HVM guest */ + order = (pfn > 0x1ff) ? S_PAGE_2MB_ORDER : 0; + break; + } + default: + order = S_PAGE_1GB_ORDER; + } + + if ( ((ROUNDUP(pfn + 1, S_PAGE_1GB_ORDER) - 1) >= ctx->restore.p2m_size) && + order == S_PAGE_1GB_ORDER ) + order = S_PAGE_2MB_ORDER; + + if ( ((ROUNDUP(pfn + 1, S_PAGE_2MB_ORDER) - 1) >= ctx->restore.p2m_size) && + order == S_PAGE_2MB_ORDER ) + order = 0; + + return order; +} + /* * restore_ops function. Sets extra hvm parameters and seeds the grant table. */ @@ -258,6 +342,8 @@ struct xc_sr_restore_ops restore_ops_x86_hvm = .localise_page = x86_hvm_localise_page, .setup = x86_hvm_setup, .process_record = x86_hvm_process_record, + .guess_physmap = x86_hvm_guess_physmap, + .get_physmap_order = x86_hvm_get_physmap_order, .static_data_complete = x86_static_data_complete, .stream_complete = x86_hvm_stream_complete, .cleanup = x86_hvm_cleanup, diff --git a/tools/libs/guest/xg_sr_restore_x86_pv.c b/tools/libs/guest/xg_sr_restore_x86_pv.c index dc50b0f5a8..f8545f941a 100644 --- a/tools/libs/guest/xg_sr_restore_x86_pv.c +++ b/tools/libs/guest/xg_sr_restore_x86_pv.c @@ -59,7 +59,7 @@ static int expand_p2m(struct xc_sr_context *ctx, unsigned long max_pfn) ctx->x86.pv.max_pfn = max_pfn; for ( i = (old_max ? old_max + 1 : 0); i <= max_pfn; ++i ) { - ctx->restore.ops.set_gfn(ctx, i, INVALID_MFN); + ctx->restore.ops.set_gfn(ctx, i, INVALID_MFN, 0); ctx->restore.ops.set_page_type(ctx, i, 0); } @@ -947,9 +947,10 @@ static void x86_pv_set_page_type(struct xc_sr_context *ctx, xen_pfn_t pfn, /* restore_ops function. */ static void x86_pv_set_gfn(struct xc_sr_context *ctx, xen_pfn_t pfn, - xen_pfn_t mfn) + xen_pfn_t mfn, unsigned int order) { assert(pfn <= ctx->x86.pv.max_pfn); + assert(!order); if ( ctx->x86.pv.width == sizeof(uint64_t) ) /* 64 bit guest. Need to expand INVALID_MFN for 32 bit toolstacks. */ @@ -1113,6 +1114,21 @@ static int x86_pv_process_record(struct xc_sr_context *ctx, } } +/* + * There's no reliable heuristic which can predict the PV guest physmap. + * Therefore the 0 order always will be used. + */ +static void x86_pv_guess_physmap(struct xc_sr_context *ctx, unsigned int count, + const xen_pfn_t *pfns, const uint32_t *types) +{ +} + +static int x86_pv_get_physmap_order(const struct xc_sr_context *ctx, + xen_pfn_t pfn) +{ + return 0; +} + /* * restore_ops function. Update the vcpu context in Xen, pin the pagetables, * rewrite the p2m and seed the grant table. @@ -1194,6 +1210,8 @@ struct xc_sr_restore_ops restore_ops_x86_pv = .localise_page = x86_pv_localise_page, .setup = x86_pv_setup, .process_record = x86_pv_process_record, + .guess_physmap = x86_pv_guess_physmap, + .get_physmap_order = x86_pv_get_physmap_order, .static_data_complete = x86_static_data_complete, .stream_complete = x86_pv_stream_complete, .cleanup = x86_pv_cleanup, -- 2.34.1 Andrei Semenov | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400348.642056 (Exim 4.92) (envelope-from ) id 1oVgSG-0007ue-CY; Tue, 06 Sep 2022 21:50:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400348.642056; Tue, 06 Sep 2022 21:50:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSG-0007uS-69; Tue, 06 Sep 2022 21:50:00 +0000 Received: by outflank-mailman (input) for mailman id 400348; Tue, 06 Sep 2022 21:49:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIJ-0000Cs-GS for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:43 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140083.outbound.protection.outlook.com [40.107.14.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d2ff0d9-2dcf-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:32:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7134.eurprd04.prod.outlook.com (2603:10a6:800:12e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 10:32:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 10:32:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d2ff0d9-2dcf-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nyuEAr3yxqu33u5aujl4OtenHRyY3sX5YejnBtXQjN74LrCedYyCFz1oASJDjQdbhOF0WJmPpHMR07QvICq4znv1WK42N/nZIr+PvZvCn7g2spbKFyRkRIGu/1YlmuMqgHQlu+M/5yK65DaQN71FikMHmPPq19oN0vDH41TDbQ3xcPa+eVWS9gd+YAc6yIOxkc8uNGUXxgKf6bER/bdUgDcBVLkM7qaIWp4Q8iq7Vs7vjW3Nqf2MA5OxmP6HyX/SWdlcDrYW/oF0t6DZWKQX2mn+s/KoJVPw514UH6wQyOxBUd+9VaWDqOUZ8RcTpUCfLtAmAt1JXp37W201cUQ2LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Ux+tUw5q0jp5KZY1D27e/BBjcFYHXCAZ+7fbJZGQ2A=; b=MV9BzyGvocQG4Txxq05kJgfZ6qDoOxmSXnrhDtM0lmskwYHsQZ9q2raG7nqkUIGPQK0tnJlWQ//Bzdl6AF3F4lKdq1rPjUnqjxMFk7FA80lGiouHktBDIIDANPP4HreOY2OWqH5Cz9q+NkNCmvNuQ28CVcfGj3Dp6hStmTdGUZFVWxV/Z0t+rQG8+5xKG/kxrJtPTDBdCz/bHK17G6mziX3WcNHaIB6p23CxsM71JoOgAFcW54D6UlYHCp0ZXC0u6f+M7qsSs+8CyweNWUIT5wJZq6Ze63yX00W69kdXDjaB0/zio/xAaI/Vy0DbsBdBEYVawiEQgpQUCSNaPACXPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Ux+tUw5q0jp5KZY1D27e/BBjcFYHXCAZ+7fbJZGQ2A=; b=m1l90+HDYozS8hhKh7ZQM93eC+bLHUit7Kt50sLo8f2/taH++om1k6HBieZsRnGG9Rj/hcg8rMVXAxpFKm9mxOCv9YnXsOS5nJuxK6UY/u9RWWoBBaXIaj6o7oZAXoD4cn9+RsjN4pdFuVUV9RiKBaOydy90MNWi4jqfWFmx33w3c6/oeCz/FpbTVOl/3ZkkUhDb7+R2LKhmJVLcnknwNlcv9fywkOy3gTsmBfAeVriu1zl76ANh6a1YVVMpL+8X/NIdUbwvrG9PY7C31TMV5Jl5VPA7tH0PXjmTZGpErTESrO1Zot2d5yLjZd7ENd8bTJCo3BQ3AnORvW1z56hQYA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9a98a83a-32e5-67fe-431d-7bc5f070674e@suse.com> Date: Tue, 6 Sep 2022 12:32:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [RFC PATCH 00/10] Rework PCI locking Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220831141040.13231-1-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8859c1b6-4198-41b0-8e4f-08da8ff311ac X-MS-TrafficTypeDiagnostic: VI1PR04MB7134:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k0mWRJrU0D5Di/xsU/AT8AP/br6NGAdZrIXUN4zrdepa8py5Szrqv4KxxEyHkZx8G7HgE+g2iM/oyYGDxLXS/93H2rHoqR9TDiEimzg/H0HlXhKRw9NUH7DZXcPdgjf/o5U7d+Fu4ol92t51h2Q4ezM6Hi6+GXTrKthh0AS3+hrEUF2zoBkvUjkgNeZ4YwSsvMya6V7GzsIx5FwvuHGnBgAGDrHDAHRhB4+WOscJSHykW6TlE3/H33Pc62nrgUNTz52ILix1z4M9FJbBBkvTKZy9HqD0nLK590TaAv88Nwh5j3mfvzK9edXGRGA/YBWwLbWkZrs9uuz4OAjaK1IkjiyiphuCnbEzFw/uEmEdxaDYh4/ZBab8EsRycFfKUbSEisM4XtTdFSuH4Zi4N6F42DBVowv440ezwaJhOITpk+D4OxoAKYkECH+b93FkUzxe32G78GWWcAUzJVfGE5eWG2ozsDaOCOpYDioKQWtm8X/xu/O1jfDR0lEX6EPVX4CB/Lzwo1VqIBCanczPq9XPJd1ECBJ5QQF400BkG2r4wdwZwNrVLcgY9jsI915CKrQ7Unnt9zO6qeww8Zy2NA/f2bdwwVL80pb78z4Y1z3Vvpz1rHrywZrJJMXX8u4fLIkCHHzwbPahVz33osUJOkLHOxE6VOMsbPIINCUPH2ppnWJ1CQn+FWNHAY6oBNJToHTqdJeYbKBlMqxTYbbfLykM0XQSHqbWHGuGuPV1oETNYqqmwJW2pxutSGZM+qOunSPG00wUsYLTZV5g4GZJxJhbhKRDClkUl2mQiGiCZXwnhCo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(346002)(136003)(39860400002)(366004)(38100700002)(66476007)(66946007)(4326008)(54906003)(6916009)(66556008)(316002)(8676002)(2906002)(7416002)(5660300002)(2616005)(8936002)(186003)(6512007)(83380400001)(6506007)(6486002)(26005)(478600001)(31696002)(41300700001)(31686004)(53546011)(6666004)(36756003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVJ2K3h2SEFIcWtZcC83aExtTUJmcGZrcXlzNkdXTTlod29iRXlCRlY1ZEN1?= =?utf-8?B?LzNQcG43SnJlM0U3ZXFOV3p4VmI3Mld3SHVVci9RYVNRdWpZbTgxSHVPWEZs?= =?utf-8?B?dEgrZ2VScU5saUZuN21RbkRNU0dqWWZKUTEzU2VWaEZxQkh5Sm9BK1B0L2U5?= =?utf-8?B?UkVHVzhGWm5DWFRDbHBSSVBUNVZ5bElVRTR5Q2x3Ymljd3JVVVVKaDZvdFB5?= =?utf-8?B?V1M1ZDdtVUtUSTFtNkdVT2p5TS9nYmUvcHRsNWROR1d0VjZGU09IdkRzVzdr?= =?utf-8?B?QW94RTczSnBjdnRONmNkeDVrekJEemFDVGd4T3hZN0xsUDVIZnlvbUs1eFd4?= =?utf-8?B?YWtZdG5OZlN0SXBBeE1CMkI0cFRmaENhZmlQTzcrZ20xMzZsSGRyU2piSUcy?= =?utf-8?B?VXhEeFdrc05janE5U1pJekcyd3JoWUJnV0JPb3VTSGhxb3dhWndRQ1NWc2dX?= =?utf-8?B?TURDeEVYMWFJdlpwOFRjYVY3LzBXbk93T3BtTGQ3SkEwcjY0Z1kwemtRb2dw?= =?utf-8?B?RXZvQUtHclh1MHR6VkZTMStKN3p3N09SS3FwL1ozSVRGWUJrMk12Uld6a3Fy?= =?utf-8?B?OEJIeGw5TEp2dGpMUTlGVHRLMSthRG11eTZWMkkyM2ZSaVR1cTA3L09rRDlX?= =?utf-8?B?ZGlYTVFjTXRnTUs2ditobzVkQXBOTGR3cVRwcG54R1IvRDVNRXhsS2R6eVky?= =?utf-8?B?V2h3L3JTOTRXZC90bmlrVUVja1NBN0RCZHJhQTJPelNsSzBTa1AwUmZUc2lV?= =?utf-8?B?WnFmaGRFRyt3L3ZTKzRyZmZETkhSaUtVMTI0K2RmcGJQaENiUGh3aGowemdk?= =?utf-8?B?Ly9xSjMwcVZEZjhGQm9idEFvNXlGeVdyYWpwN2VLSWJRamxYWmFOVGNlUkZw?= =?utf-8?B?c1pqNUIzS3Z0d0pCZVhjRllVQW5oTWNWOFZ4eXUzQVJPNmN6VU1aZmwxRWtl?= =?utf-8?B?MnFhQm1OUEhsdW8xSnBMZ3dKbStBOWdaTFRGKysxNUI0WnJvV0hKNnBQMXl3?= =?utf-8?B?UFJhU3Urek9JdUU3YWREY0VKR1RTQUJTN3NwbWtxZFZjbm50NU1zRG1QYnlo?= =?utf-8?B?d1BPakJ1RjRhSnVNajc5dVZWSWN5d1BZLzZoN0p2Q0xaZkNqVjA3eFdVZGY4?= =?utf-8?B?S1hpQzRnT3k4WjQyUnVXY2N0ZG90NytHYkI2OUkrNmFzUlpBQVpwTEtvSElB?= =?utf-8?B?bldWL1FxeDZyS3F3VkNpeG1CZWgxZ3hZVGpUd0JNcVRsSWFlZHk4OTV5SmZC?= =?utf-8?B?L2FoTEJwV1lKV3loV0xqSlA3Z2M3WWVwY2lmQnpMYkJiNHlZaU41amY0VzFv?= =?utf-8?B?emxSYUFSemVmdFBFNzE4YXNubEtBdllBQ1luQXpPZUtMRkhualFEMkc2OWc1?= =?utf-8?B?K2IwdXQzOGFDYlAvajlYSHFITTEvMmMxdDVuWVMyUCt6eFRQZjBjNzVvM3NU?= =?utf-8?B?NTZoRG80cURyYVRyZVYyb2YyeWRUVUFkelhla2hwZ1EwZ0dxaVFaWlcvQjRF?= =?utf-8?B?UUNWNGNndVcwZEhFYjljeGY3TFJNNjBPRUN0ZCtpaWtlUFVzcktUWXF4SW00?= =?utf-8?B?UmxrN3llSzVlTnFUdFZlTzhCZ3RlQmE2S2h4RDlDWThQVWxHS2dLZVNNd2Ji?= =?utf-8?B?bFpnQUV6MEFwamIyaEhhLzQzSjR5Z3Zva3FodDdzY3ZzdUFjUzJvRFRKRk82?= =?utf-8?B?QVRkdktNb3g3dkwxK3EwMWloa0VDckdRMEJyeTFpNlg4T3JIWWw4dUJnamgr?= =?utf-8?B?am1lRmVlVTBEamxEb3E2TStCVEcyeEVHQmNMd1p0d0FnOHlXOU9zdnlaWThy?= =?utf-8?B?bWxaN1VlSXRxbWdXOG1ZQUNDN0dmUXIvV0k5alJLaWFBc29lalZmSzM1bC9w?= =?utf-8?B?cStIc0F2Wk5TWDljbGoveGc3c2ZYb0xnRkFvNDVFSjNPR3huMGh2ZGl2T1lX?= =?utf-8?B?UHlMRjJJZTg1Vjl4Tlo5TjA2blh2Q2hhNiswWjVqUTVFclBablNMc3dXRkwz?= =?utf-8?B?OFpEajB1VHNUb29kT0gxTnpGWFJ0WU1iaExmR0dicTNiYlhJeDJoUXBRQi9h?= =?utf-8?B?YnhjeWdTUVVwUmU4M0sveUhxVlQvQXNkdHBuOXN4dFZvc3VHSFUvTDU4MVd0?= =?utf-8?Q?HZRs0fZml/e6aLY/buipweBcr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8859c1b6-4198-41b0-8e4f-08da8ff311ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:32:16.3942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0YL16EhstA25N4s8LdjxfTE0phqaRniry1MWNpeTDG3naFxTliKwaE8IkA4SZZDb3+Guh/jrp4ZnTG0Bme0yQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7134 On 31.08.2022 16:10, Volodymyr Babchuk wrote: > Hello, > > This is yet another take to a PCI locking rework. This approach > was suggest by Jan Beulich who proposed to use a reference > counter to control lifetime of pci_dev objects. > > When I started added reference counting it quickly became clear > that this approach can provide more granular locking insted of > huge pcidevs_lock() which is used right now. I studied how this > lock used and what it protects. And found the following: > > 0. Comment in pci.h states the following: > > 153 /* > 154 * The pcidevs_lock protect alldevs_list, and the assignment for the > 155 * devices, it also sync the access to the msi capability that is not > 156 * interrupt handling related (the mask bit register). > 157 */ > > But in reality it does much more. Here is what I found: > > 1. Lifetime of pci_dev struct > > 2. Access to pseg->alldevs_list > > 3. Access to domain->pdev_list > > 4. Access to iommu->ats_list > > 5. Access to MSI capability > > 6. Some obsucure stuff in IOMMU drivers: there are places that > are guarded by pcidevs_lock() but it seems that nothing > PCI-related happens there. Right - the lock being held was (ab)used in IOMMU code in a number of places. This likely needs to change in the course of this re-work; patch titles don't suggest this is currently part of the series. > 7. Something that I probably overlooked And this is the main risk here. The huge scope of the original lock means that many things are serialized now but won't be anymore once the lock is gone. But yes - thanks for the work. To be honest I don't expect to be able to look at this series in detail until after the Xen Summit. And even then it may take a while ... Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400356.642066 (Exim 4.92) (envelope-from ) id 1oVgSK-0000FD-LP; Tue, 06 Sep 2022 21:50:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400356.642066; Tue, 06 Sep 2022 21:50:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSK-0000Eb-GF; Tue, 06 Sep 2022 21:50:04 +0000 Received: by outflank-mailman (input) for mailman id 400356; Tue, 06 Sep 2022 21:50:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHm-0000Cs-Af for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2055.outbound.protection.outlook.com [40.107.20.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb574e56-2dd1-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:52:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8803.eurprd04.prod.outlook.com (2603:10a6:20b:42e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 10:52:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 10:52:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb574e56-2dd1-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5ZwRvcD3YBWu1xBcdo/29R9L+5LhfnPgUwQQWYL9+4yPRgk55VVMhIq7dWFzLnBVNEGBXBj3tv9Bk5qXNFmfrg1nGACTCWzewQ8CHShyyxpALkPLUDzy2MzCPSLZDmpEWT7TW9aSc+bYso0lWNGk/Eu/qRFAIe2xkfZjxthLkHr6D/ZwnjoBi85v5qqDCF8sj9p0b28/i7nqopsEvQacUNuZ6sesA33zGt7FsPBDyEQRET7pKJZkBDO9VJC/yFAw/78ctO1q6hHbxPLrCDvTowDN6s+4NV8JCKIDTpBm/hfXbJIM0cvaD0FigdcDLQSBMFvSIeB3qAty+fSfFSIeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jik0AS91Z62dGz9zQ9cTsb2Do4NvlItXiH4vIWsfFF8=; b=S4UTvLl6TPpwuNNLRrrZ7fa63Ccq8fuhZaJnO0V1ntzKSVnEMAC3oMFOd1z2kKrdHr5vIoo1b6otzD4klROugVS+1wAPUtPKQklQKdt63hTQkFn0QECHOMAxQDPEJyifEZbsWEjYzdYAXUtYivSxh0zkDqHhFwg06KVlb/VcgrwPy2T60vBAd+pE7tsJFJIo03TmlRpBfSwxF7ESb7Mfd7upYCfCVMAQTfqUImL/KnHj5lLB5fGXmukSHPouMfIXL2Dk8OxTgKNfd4Ku0G5ADwJ7b0z5Th9V3L4Uwu4/zYZnRRsVNJn48/9OSJqkxOvMBfhy8nFlW4Nz6zdoVF6TCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jik0AS91Z62dGz9zQ9cTsb2Do4NvlItXiH4vIWsfFF8=; b=J8vDJroaGE9L34+44xj96W9qCtuUcGFwJS9skI/wfxnqeI3eXqcRUy3AfQG/MaG7KH6t8E89NtYY8ojJ2s3nUSRKz8K7Fr89/ofojQsNI8tU5NKFSr/YAeTYmMDacI6Dy9OZan0ATm8vkgEiSKyXz8NbrmzO9SaoVIRyve2E+yvSq4Vv0bgjmIgbVKYcip3jgfM2NfxWoLEUaJ3+xQ2EQklKpM97pYjP8usdkIVkMKGc/C3INEAXjwk7+tRIGPDWotwxixCJZBjhtG+YRH8CFRsyb/AtZfVeaC+RfMS+8eH9C/PGPMvirBGA84kH+j4vJC3Si+db7FvljMcNhEwUoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0fb4cab5-beed-777e-ae58-5d8b79893c30@suse.com> Date: Tue, 6 Sep 2022 12:52:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US To: Dylanger Daly Cc: xen-devel@lists.xenproject.org, Andrew.Cooper3@citrix.com References: <55eb8485-0c0d-51cd-c9b8-d517994ec6c6@suse.com> <7807b9cf-a09e-a393-ee7a-dc220a68e56e@suse.com> <3b2ad2ca-3c6c-4dcb-c603-bd5440350f20@suse.com> <2dHPPtixTlkUXYEzNPFRI4ezKHSe1A2VaThMjBpd1aM3NFkZQuyRdfmNWCigm1oXfdKhOwDJGoPBBIMLYtYhQlENV2eFVZ0G9EMOMj5e6UE=@protonmail.com> <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 282c9be2-b28b-46f9-66f0-08da8ff5de69 X-MS-TrafficTypeDiagnostic: AS8PR04MB8803:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qll4QXRwj7CJPVWqElbVoa6cCISQHujFSnzqcVghbSwfc0voQwx54XuU7tQQyqpQUc2kKbimdDI5mGctWk/tAW2aQk02MZNeNYZkOuTfsYNKH55DG8Z9+rrFJcI4WThhbFAifO46ebvIvLhOpTanuP2Ds5aoL25HN9PPPSK9yPFRBghnM3f7LTvQzcv3EQkQhIuGIjmhVJOT5NmzqlLQz1ngqv2jUZWwPolv2RHSokVs4nIjvSB+DqFr8QCQUbw/nfKgii1AkFNf8DCLDGRBPSnf4BKt7P2x3srHk1UuOTx1enZC1818Xv40+AGIXjDQR9LxGpXdsWelh7ubDt5iTffwYuCL8OmM22Oi+oxAgVi2Vk9X2ATq/mqi51pUV5DzGzSDBTujnZ6INqm6p2uRTVs/EM4ISD5Q3DcNXsn7REOPYbQibgrSGg1aXs4H5GpsswZhd/wDPxaN5hHKPYufx5iC2VSL/XUNac1HLRmU5bkzWcbGVXJokqmjY0Buq9sd5LqC+KiXK8TRIT80cHFnyh7ZpaXJqFUNQd3TVfYxvoQONGZ1NPOiX8fGEjocurp9UbADMnjizw69OsthpxS1Mvewn1NGMh2F+o0UiVs/UtVFAxkQufOohJPGQRBtgZjG0U7+be1ZvGFhjsT0sQy/IHDgYNhmaL26xAQKuxfzxIeeq2CyaqRwiB+5oRzt0LqrrGuX3UfDfyT20tr+46OFkF/awc2H330XmbJZeOnrHCh1xuVn8HuTXwX6NuQGP2F1nfH3f/fbOrTn/wD10cqy0mUIScYuoAP98p2CPpbfhwc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(346002)(376002)(366004)(39860400002)(83380400001)(8676002)(66556008)(66476007)(5660300002)(4744005)(66946007)(8936002)(6506007)(6666004)(478600001)(53546011)(26005)(6512007)(6486002)(41300700001)(186003)(2616005)(6916009)(316002)(31696002)(86362001)(36756003)(4326008)(31686004)(2906002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTJLMWNsY0EzbitGQU9RaUgzZG1jK3h6U3pEbzh2U0kvOVRUaGhJa0RSSlBs?= =?utf-8?B?WXB3b3hhU1pyUHhCNzFkUHdCQzhlWG1tZUxMNkFOM1RrOFJmaTFJU3NadER2?= =?utf-8?B?QnBUQXN6d1RCUlZOYjE5TGhBSTF0ZjA4dEdBR0FnSXNNZmZIMWVXSTl3SXU1?= =?utf-8?B?U2dkNkpXS29NMkRQVzBoZzRLaldUTkUxTXNOSXBtOTQxazJOa29mMVJQZXhz?= =?utf-8?B?NDlXWXNhWW5xc29jdUl0YWx2YlRGcXR1SmxCQlU5SnJTL2xETm85STZwUXkz?= =?utf-8?B?VFRIbWFwUTJuSTM2dFovL0o2TCt1M0ZieEJwakY3TzRsWkJCalBOQ21PSTdQ?= =?utf-8?B?TnBRUGFIRmxOcDF1WkN3MVFWWkl6c1hWZVdoRlVGU2hhNThKbkIzRjRpMG5r?= =?utf-8?B?cjZXRGVBR284UkdVY21YQm9aZElIbEp5S2dUeG9iaGNzckFmTkkvZVBJZmt5?= =?utf-8?B?Y1lXMTJQVXE1SkN3SjRFNGp0M3czYlFJL3BJb1pFMVdJRFEyZkVtbTNZczNP?= =?utf-8?B?eVVqSlZSMjJ3MEJDSmpwQWVacG9DNGxtTU1SZzJidG5rUXNkaWJ2bGFxTEx2?= =?utf-8?B?RW5pdkdXMndqRzA4SXdSNjR0MzhHVVMyT3BLcllheFBhdGQ1TWZsUUdib1dv?= =?utf-8?B?dGVnSVFoVzYvd1llWFVXZUtuaXNTamhROVlDYSs2SWFlb0JsMXkvcWJ6Z0cx?= =?utf-8?B?WWFMV0Z3d0tyT1FJS0h2K3VBRmRBc1hCcElXMXF4WHRhRWNxdk5XVFZmRkVP?= =?utf-8?B?a2c5T3dFYk4zeEFaajdUSnBuMyszNlAzdjFmdVowakJJcGUwTkx6cUIzQ2J1?= =?utf-8?B?QnN0VWRNeXFlc0cvT3U3Y0szVVRoZnRnYStqRk1oMnI1VmNUYWZCODFvVVZJ?= =?utf-8?B?SDZPcFJacG9QYlBJcnh1TU9QQ1BMWnZZRVpIYW1zelRRK1JWMzFHWFJoSlhU?= =?utf-8?B?bTM1TExsQTRQU3VqbWsvYWxqUFF3WkNsWTdmd3BuNnJDcFd0Wm9PNXZ5Kysz?= =?utf-8?B?SkM3alJQMjI0Z2V2RkdGWUhQNXFNVHNpcmN4dTVKZjlndmRSRE5hU1N1M3g4?= =?utf-8?B?Tzdqcmh1czNQd1J6ZlB6Y3dtS2paU2pjOW9CbXFxSmRGR0dKVW1meFpRdW9V?= =?utf-8?B?K1lwOTdYUVB5KzhDeW0wcHVKblpBelNCVU9rcDd1RXpqdVpFc0JERG1JMkgr?= =?utf-8?B?VHNpbEdKQmxSMkpKcStUb0UrR0pXM3ZwRDhkQUg4YjNsN2N3ZHZaZjBZRVVt?= =?utf-8?B?dlUySW9xb3NtSUtHYVZrMjlnTUx3R3p5cTF6L05zZENhTnNSZ3FZK09Id0FD?= =?utf-8?B?SExidlVRT3lkSUpUODNEOW5WS2Q0aWJCaVdWODVBMnpvNE1uVmdQWng3Z3Ar?= =?utf-8?B?ZXNFOEUrSUNtMHdoYmo2ZGZYc1BVOGNNQzE3MTEvNUo0V1VCWVVpUGFFVXRr?= =?utf-8?B?WTF3VWp1SHA5TFdwenBxcmpvZGhvZ2NwSkdoM2JqNXdSTlFDTnd0ZUoxOWdG?= =?utf-8?B?RXNkVGJ5MzVwdzJIS3RKMWY3RHE2Q3FubVVEVDl4Z256UkdUQzNSVCsyem81?= =?utf-8?B?bENBSTVBRjN2dUFLWEluL1c5R3dVMzVjdFV0NnZMdkdsWnNyMTR1MDVwZ2dw?= =?utf-8?B?MXY4R0FCK0Uxb0p5OFU1djhxV3doMmhqRFRPTmxBWUFLYVBTZW1zOWNUMlVD?= =?utf-8?B?azZ1d0I2SkNueEcwb2Zld3lJWGVlOC9TODltWmd5dFFFbmUvejlyb20xSXhr?= =?utf-8?B?alZOTGM5NmNFVlVPQk9la1pRR0t1cTh1NDBHRVVkSzAyOXBTZjhRZmZuQW1J?= =?utf-8?B?dC94MCt2Nlo0d2xkTmJMZXNpdkxaM2FGaEZCUGphekpXb1VSeTFSbEt2TGtM?= =?utf-8?B?OTlkNmE0UWVGekliR05McVZGclhXbmgwcStJZzRZTHlLaXdxb2luenpjb2da?= =?utf-8?B?YTJ0aUJadVAyTUJ0cFVDZkgzS3oxUm5iSGZzQnY4SzhyWHNZL3ZsMUtCdDdD?= =?utf-8?B?S3lObDNMTUJyOUJYSmI0Y3J3OVpyM2RFdUFrcVJubllxZ0lUdVNGRHd3ZGJ0?= =?utf-8?B?U2I3bWdNcGhTS3dwMW4zVWdlbDhmdFZYMjI1OGk4UXZjYXR4c09ZWDJzaito?= =?utf-8?Q?KtlkxPptrwfMtm6EYLRCgekxN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 282c9be2-b28b-46f9-66f0-08da8ff5de69 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:52:18.9117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GFSE0wgEG7q/Jz4ICDc1eaGC3kJmZZdtkuF8X9vlMlQ+ZfdePscyRiluie3eCKc5PAh4zuC++iBF1DBPVOFmTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8803 On 29.08.2022 17:26, Dylanger Daly wrote: > Please see the attached iomem and meminfo text files from both Qubes under Xen and functional Fedora Workstation. > > After some investigation, I've seen that I'm able to run a few small VMs just fine, however as soon as I start a larger VM, PCI devices appear to stop working, I assume this is because AMD moved PCI register addresses and Xen doesn't know about this change, so it's mapping this memory for other appVMs to use, resulting in weird behavior? Does that sound correct? Not really, no. Even if BARs were moved, they still shouldn't overlap RAM. But yes, BARs moving without Xen knowing would already be a problem. But then the basic question is: Why would BARs be moved? The only reason I could see (in the context of VM creation) is if PCI pass-through was involved. Iirc you said it isn't, though. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400374.642077 (Exim 4.92) (envelope-from ) id 1oVgST-0001Kp-SW; Tue, 06 Sep 2022 21:50:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400374.642077; Tue, 06 Sep 2022 21:50:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgST-0001Ke-OU; Tue, 06 Sep 2022 21:50:13 +0000 Received: by outflank-mailman (input) for mailman id 400374; Tue, 06 Sep 2022 21:50:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIA-0000Cs-F6 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 476269f8-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 10:59:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69E5B1756; Tue, 6 Sep 2022 02:00:06 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C70633F7B4; Tue, 6 Sep 2022 01:59:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 476269f8-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v7 2/9] xen/arm: assign static shared memory to the default owner dom_io Date: Tue, 6 Sep 2022 16:59:34 +0800 Message-Id: <20220906085941.944592-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. And DOMID_IO is a fake domain and is not described in the Device-Tree. Therefore When the owner of the shared region is DOMID_IO, we will only find the borrowers when parsing the Device-Tree. When we found the first borrower of the region, we need to assign the region to DOMID_IO This commit only considers allocating static shared memory to dom_io when owner domain is not explicitly defined in device tree, all the left, including the "borrower" code path, the "explicit owner" code path, shall be introduced later in the following patches. Signed-off-by: Penny Zheng --- v7 changes: - page_get_owner() can only be called for pages that are marked inuse, so use page_get_owner_and_reference() instead - reference shall be dropped using put_page() - adjust "d->max_pages" when acquire_domstatic_pages() fails - switch from assert to BUG_ON() because this is init code - refine commit message and in-code comments - rename allocate_shared_memory() to assign_shared_memory() --- v6 change: - use if-array to check psize, pbase and gbase are suitably aligned and valid - use mfn_valid to check (pbase, pbase + psize) - check d->max_pages will not overflow - refine acquire_shared_memory_bank to not reuse acquire_static_memory_bank, then input pbase and psize do not need to be used as a pointer. - use if-array to check if page owner is dom_io - in-code comment refinement --- v5 change: - refine in-code comment --- v4 change: - no changes --- v3 change: - refine in-code comment --- v2 change: - instead of introducing a new system domain, reuse the existing dom_io - make dom_io a non-auto-translated domain, then no need to create P2M for it - change dom_io definition and make it wider to support static shm here too - introduce is_shm_allocated_to_domio to check whether static shm is allocated yet, instead of using shm_mask bitmap - add in-code comment --- xen/arch/arm/domain_build.c | 160 ++++++++++++++++++++++++++++++++++++ xen/common/domain.c | 3 + 2 files changed, 163 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..be98ff83b1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -759,6 +759,160 @@ static void __init assign_static_memory_11(struct domain *d, panic("Failed to assign requested static memory for direct-map domain %pd.", d); } + +#ifdef CONFIG_STATIC_SHM +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + struct domain *d; + + page = maddr_to_page(pbase); + d = page_get_owner_and_reference(page); + if ( d == NULL ) + return false; + put_page(page); + + if ( d != dom_io ) + { + printk(XENLOG_ERR + "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", + d); + return false; + } + + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + unsigned long nr_pfns; + int res; + + /* + * Pages of statically shared memory shall be included + * into domain_tot_pages(). + */ + nr_pfns = PFN_DOWN(psize); + if ( (UINT_MAX - d->max_pages) < nr_pfns ) + { + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", + d, nr_pfns); + return INVALID_MFN; + } + d->max_pages += nr_pfns; + + smfn = maddr_to_mfn(pbase); + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + d->max_pages -= nr_pfns; + return INVALID_MFN; + } + + return smfn; +} + +static int __init assign_shared_memory(struct domain *d, + uint32_t addr_cells, uint32_t size_cells, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + + dprintk(XENLOG_INFO, + "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, pbase, psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is auto-translated (i.e. it seems RAM 1:1). So we do not need + * to create mapping in the P2M. + */ + ASSERT(d == dom_io); + return 0; +} + +static int __init process_shm(struct domain *d, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + + dt_for_each_child_node(node, shm_node) + { + const struct dt_property *prop; + const __be32 *cells; + uint32_t addr_cells, size_cells; + paddr_t gbase, pbase, psize; + int ret = 0; + unsigned int i; + + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + /* + * xen,shared-mem = ; + * TODO: pbase is optional. + */ + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + BUG_ON(!prop); + cells = (const __be32 *)prop->value; + device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); + psize = dt_read_number(cells, size_cells); + if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, pbase, gbase); + return -EINVAL; + } + if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, psize); + return -EINVAL; + } + + for ( i = 0; i < PFN_DOWN(psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) + { + printk("%pd: invalid physical address 0x%"PRI_mfn"\n", + d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); + return -EINVAL; + } + + /* TODO: Consider owner domain is not the default dom_io. */ + /* + * DOMID_IO is a fake domain and is not described in the Device-Tree. + * Therefore when the owner of the shared region is DOMID_IO, we will + * only find the borrowers. + */ + if ( !is_shm_allocated_to_domio(pbase) ) + { + /* + * We found the first borrower of the region, the owner was not + * specified, so they should be assigned to dom_io. + */ + ret = assign_shared_memory(dom_io, addr_cells, size_cells, + pbase, psize); + if ( ret ) + return ret; + } + } + + return 0; +} +#endif /* CONFIG_STATIC_SHM */ #else static void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, @@ -3236,6 +3390,12 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, node); + if ( rc < 0 ) + return rc; +#endif + /* * Base address and irq number are needed when creating vpl011 device * tree node in prepare_dtb_domU, so initialization on related variables diff --git a/xen/common/domain.c b/xen/common/domain.c index 7062393e37..fbd290ece7 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -783,6 +783,9 @@ void __init setup_system_domains(void) * This domain owns I/O pages that are within the range of the page_info * array. Mappings occur at the priv of the caller. * Quarantined PCI devices will be associated with this domain. + * + * DOMID_IO is also the default owner of memory pre-shared among multiple + * domains at boot time. */ dom_io = domain_create(DOMID_IO, NULL, 0); if ( IS_ERR(dom_io) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400387.642088 (Exim 4.92) (envelope-from ) id 1oVgSb-000208-A2; Tue, 06 Sep 2022 21:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400387.642088; Tue, 06 Sep 2022 21:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSb-0001zw-6z; Tue, 06 Sep 2022 21:50:21 +0000 Received: by outflank-mailman (input) for mailman id 400387; Tue, 06 Sep 2022 21:50:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHv-0000Cs-C8 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 50df1d04-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:00:12 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C1BF139F; Tue, 6 Sep 2022 02:00:22 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 910463F7B4; Tue, 6 Sep 2022 02:00:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50df1d04-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree Date: Tue, 6 Sep 2022 16:59:39 +0800 Message-Id: <20220906085941.944592-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration when creating shared memory nodes in guest device tree, this commit adds new field "shm_mem" to store shm-info per domain. For each shared memory region, a range is exposed under the /reserved-memory node as a child node. Each range sub-node is named xen-shmem@
and has the following properties: - compatible: compatible = "xen,shared-memory-v1" - reg: the base guest physical address and size of the shared memory region - xen,id: a string that identifies the shared memory region. Signed-off-by: Penny Zheng --- v7 changes: - allocate reg for worst case addrcells + sizecells - replace assert() with BUG_ON() since it is init code --- v6 change: - change "struct meminfo *mem" to "const struct meminfo *mem" - change "unsigned long i" to "unsigned int i" to match the type of nr_banks. - accroding to the Linux binding, "xen,id" is meant to be a string, not an integer --- v5 change: - no change --- v4 change: - no change --- v3 change: - move field "shm_mem" to kernel_info --- v2 change: - using xzalloc - shm_id should be uint8_t - make reg a local variable - add #address-cells and #size-cells properties - fix alignment --- xen/arch/arm/domain_build.c | 147 +++++++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + 2 files changed, 146 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d0ff487cc6..3b7436030e 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -914,7 +914,22 @@ static int __init assign_shared_memory(struct domain *d, return ret; } -static int __init process_shm(struct domain *d, +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + const char *shm_id) +{ + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); + kinfo->shm_mem.nr_banks++; + + return 0; +} + +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { struct dt_device_node *shm_node; @@ -928,6 +943,7 @@ static int __init process_shm(struct domain *d, int ret = 0; unsigned int i; const char *role_str; + const char *shm_id; bool owner_dom_io = true; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) @@ -972,6 +988,9 @@ static int __init process_shm(struct domain *d, if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) owner_dom_io = false; + dt_property_read_string(shm_node, "xen,shm-id", &shm_id); + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will @@ -999,6 +1018,14 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; } return 0; @@ -1329,6 +1356,117 @@ static int __init make_memory_node(const struct domain *d, return res; } +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + unsigned int i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ + char buf[27]; + const char compat[] = "xen,shared-memory-v1"; + /* Worst case addrcells + sizecells */ + __be32 reg[4]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); +} +#endif + +static int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + int res = 0; + /* Placeholder for reserved-memory\0 */ + char resvbuf[16] = "reserved-memory"; + + if ( mem->nr_banks == 0 ) + /* No shared memory provided. */ + return 0; + + dt_dprintk("Create reserved-memory node\n"); + + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; + + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", sizecells); + if ( res ) + return res; + + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) { struct meminfo *ext_regions = data; @@ -3106,6 +3244,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( ret ) + goto err; + /* * domain_handle_dtb_bootmodule has to be called before the rest of * the device tree is generated because it depends on the value of @@ -3482,7 +3625,7 @@ static int __init construct_domU(struct domain *d, assign_static_memory_11(d, &kinfo, node); #ifdef CONFIG_STATIC_SHM - rc = process_shm(d, node); + rc = process_shm(d, &kinfo, node); if ( rc < 0 ) return rc; #endif diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index c4dc039b54..2cc506b100 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -19,6 +19,7 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; + struct meminfo shm_mem; /* kernel entry point */ paddr_t entry; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400389.642099 (Exim 4.92) (envelope-from ) id 1oVgSe-0002Oo-LH; Tue, 06 Sep 2022 21:50:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400389.642099; Tue, 06 Sep 2022 21:50:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSe-0002Oc-HX; Tue, 06 Sep 2022 21:50:24 +0000 Received: by outflank-mailman (input) for mailman id 400389; Tue, 06 Sep 2022 21:50:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIM-0000Cs-Gl for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:46 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 68ef33a5-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:58:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BE18D6E; Tue, 6 Sep 2022 02:58:16 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D16E93F534; Tue, 6 Sep 2022 02:58:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68ef33a5-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zenghui Yu , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v4 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message Date: Tue, 6 Sep 2022 10:55:48 +0100 Message-Id: <19503760e0f4ac61d11b4f381050dd1f436010c0.1662455798.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zenghui Yu Backport Linux commit dc898eb84b25. This is the clean backport without any changes. The actual size of level-1 stream table is l1size. This looks like an oversight on commit d2e88e7c081ef ("iommu/arm-smmu: Fix LOG2SIZE setting for 2-level stream tables") which forgot to update the @size in error message as well. As memory allocation failure is already bad enough, nothing worse would happen. But let's be careful. Signed-off-by: Zenghui Yu Link: https://lore.kernel.org/r/20200826141758.341-1-yuzenghui@huawei.com Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc898eb84b25 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index f2562acc38..340609264d 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -2348,7 +2348,7 @@ static int arm_smmu_init_strtab_2lvl(struct arm_smmu_device *smmu) if (!strtab) { dev_err(smmu->dev, "failed to allocate l1 stream table (%u bytes)\n", - size); + l1size); return -ENOMEM; } cfg->strtab = strtab; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400390.642109 (Exim 4.92) (envelope-from ) id 1oVgSf-0002jW-VE; Tue, 06 Sep 2022 21:50:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400390.642109; Tue, 06 Sep 2022 21:50:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSf-0002iq-Qe; Tue, 06 Sep 2022 21:50:25 +0000 Received: by outflank-mailman (input) for mailman id 400390; Tue, 06 Sep 2022 21:50:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHq-0000Cs-Aq for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:14 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140053.outbound.protection.outlook.com [40.107.14.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29ed7b06-2de5-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 15:09:39 +0200 (CEST) Received: from AM5PR0201CA0022.eurprd02.prod.outlook.com (2603:10a6:203:3d::32) by AS8PR08MB6118.eurprd08.prod.outlook.com (2603:10a6:20b:29b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 6 Sep 2022 13:09:37 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::92) by AM5PR0201CA0022.outlook.office365.com (2603:10a6:203:3d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Tue, 6 Sep 2022 13:09:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 13:09:37 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Tue, 06 Sep 2022 13:09:36 +0000 Received: from e5e0fdbf346f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C8B4861C-460E-42D3-8FC2-30ED1DC68135.1; Tue, 06 Sep 2022 13:09:29 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5e0fdbf346f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Sep 2022 13:09:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8465.eurprd08.prod.outlook.com (2603:10a6:20b:569::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.19; Tue, 6 Sep 2022 13:09:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 13:09:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29ed7b06-2de5-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XvTnAT7UeuHEgnwLxFKjkJwYC5OKf/sSInD73MpC+aKvkx9H7NYkkA7nZIhl5b7l61ft8P58rplFXj1EDKLyqDuwUaVsqqFnIQ5igZMYjPQipV24ZjN2q88WU+BxQ8rUspCpJJVdLBCXe2ixNSgoJdcVKq9GyjxcvYUGD+PQ+4JGF/eFNSKej/509c/dZJodgKPcloosfflT79TWr1Mz4g+ZbpWGJhHg7GYTEU6Yrj96vCPXXiQeE4bIGBfkqKwjDd9NWx3K0v0bNj7XThu++oAQKqOMxvhiWfwEwqZWPSUxKW/CSjFTHsg+9NX9qfYCLoOR06GLMz92mon6MFF1vA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u2lfvMOkncCIuRb+EZwQay3iR+IhRohamSnzjyZQXLQ=; b=SskBLFsoI8ipThe31t2mK0U1Pr72CEyMD8PJ79ch5oi1qg9qns0W9vfEjJT4cNQZNaDucxlgY3c62GDTm6B4axPDGHFHOPsHdkiYSYgSJXecXuT5s+jTf+GIcKVHXgtPiepngWATK8vN1aZIyBdMPRlxY1G2KfN9GJvfmR98TLm8qBWfg588M/p2bglWM0NP2twfRK6LJI/sMsHOpTac/qhuWqpje+iVEix22k6mxjZNbw5gilYS8ekbfgamO5Lck+rhslRtLA/KiutZ0ngw5FjwfGRWkX0SP9Hlw+gQqIo2kwiEJY7+ZGg70LH51tmSZKSPn4hseB4l/MTVeSDvAw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u2lfvMOkncCIuRb+EZwQay3iR+IhRohamSnzjyZQXLQ=; b=TrzZ00S94AuATuSz+6nSicssg+7mw+5npaMntKE1KvCqYU8kNeakqospDNXTkoheYMvm7jo5aHil6UppQ01aTDGtusfpSFfcoizf0ijW5H8g21iieah6JLK+VNZXMJ6uNk9U8CgCC8nwzB9ZYMO6Pk1srRoti81mX3AnyFYz/38= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2029b4c1f6e07c5f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Omfpsp6htz0t58upEcgko9eb/1CRGgF/9FpGnkmc3v9Pgihkkm4lLYWlRKEPyBsEpyY/GjD/pnXz4rseA5IPk2Rxe8MIi+nlA5SYZUIFYhXSRK1XZv5Zns5p11xbPKbXAI1VRvc6hb5zYOISS1wLKcqeT04EfqlVc1jIYYOui049/HCZ/cuJJPVpdsdMLQDqpLTNd4TdcHiHtqmlxtEYjeeRWOCYBHCtsATkxFR/qzqaChuvTyEZl02gLOKhJx4GBkk4bSLd+hxZ0Mivdz74dvSBIH1l2N/DO5zHa45mpXHparhVEajMg+a+U0RPsIID9dG7+UiML+Rcq+6KhoosdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u2lfvMOkncCIuRb+EZwQay3iR+IhRohamSnzjyZQXLQ=; b=bfgGGOoQ2/gzdiRBMc2pU/8Kr5IQWbH35yUHSpbY34cwK8NIX22sQPrLfkY2UI3Fg1EzR03SMOKbHleKlUBl+qbtPUaLxEwVqD7UWApAB5dzU2RHlzIRfoiE3ZYgO0WwfZOrh42GIFKv2fHIOSF8VqMirV4Zda1jYkNIVcKDPe3szyz+Xi3kRdseHilP5sjdCBruDHtyhN9pfQbDcV88UhOrGPJBx2o2xufpGaUZQqhoNGWth7LK4fCXpbAaHpRnaAMjhRvZVGRx4N1ViBcNjoTs8uAttcjmed49d8stdItbJcqQ5inrWth9P1/BtKUJCsWaytibFJ4jmxyqDoOptw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u2lfvMOkncCIuRb+EZwQay3iR+IhRohamSnzjyZQXLQ=; b=TrzZ00S94AuATuSz+6nSicssg+7mw+5npaMntKE1KvCqYU8kNeakqospDNXTkoheYMvm7jo5aHil6UppQ01aTDGtusfpSFfcoizf0ijW5H8g21iieah6JLK+VNZXMJ6uNk9U8CgCC8nwzB9ZYMO6Pk1srRoti81mX3AnyFYz/38= From: Bertrand Marquis To: "leo.yan@linaro.org" CC: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Thread-Topic: [PATCH] xen/arm: acpi: Include header file for version number Thread-Index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3SYAEA Date: Tue, 6 Sep 2022 13:09:28 +0000 Message-ID: <09F01AC7-6125-49C3-80BF-637BBFDC739A@arm.com> References: <20220906113112.106995-1-leo.yan@linaro.org> In-Reply-To: <20220906113112.106995-1-leo.yan@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2f2d538a-032c-4bfc-b295-08da90090ce7 x-ms-traffictypediagnostic: AS8PR08MB8465:EE_|AM7EUR03FT015:EE_|AS8PR08MB6118:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ODZUjAK9ir4fuCw89rbVUDubjz7HJ4p1j0bgV91kHn4vnMz5O2XWooOJB7XnsJHNR4a93VEDhwD7UNpDiYh4DIfTE+NmqIuE5G1Jd3KBsu/G2Wubwh43PeaXZN+9eiQx/sfwG8h7kDEc2wb7jfbvjX9je4wqlvRt4eTOOBgFydLxVu4CB+AJkzGqa0bB0nxMgzWh1ulvDCEaGQ93b0ApXkDhu6UtPFxZzGYwXHAa2lA53Ijkea0DJI1pbfHOMWau0DG5CmapuONSIbybdbiSkTt0TdNg8dHrySYWhVWDwLoehz7VFUgGfFkI9HJsjKRkLw4dplT2s1wKJYEr+BPv1taWuJiwshY9Yzg/2qlzc63weOZyOAw2ukP1CERqe9p+YCNp4VriuMvFxDheqH/oK+770iceW2UDi0XsFTmtHxnKpI/JLw2mxMpSrAx/MporYesDyqUdqzlu94VRmXXMKAX+KXVqsmsOti24jhbL/8BZ2WUlDQWJx5VGn3bBJWF1YsGdVCUk7QmywqqY8ZUVrdXADA5gbaWM411iHaA4736XtUhLK3kwSOlWFZH//xoVwssvWPVtrUSJZJPJ3gXbLq4anAGtjpWJ3d3eSz8Jlm+ftBvXgAsiqQqeAzOlm65tH6VqiHG3F7m62ySgxXYIBGTb1cSaQo1Zrr3/15ukXz0ABeWI/x6zaZaNQGAM21KHLBlNCVTcAa8T7O/MwSstkA859PV8BMZNvymoHps9tZywJAlSLQzBZisCT3AycxvbG4oEYzL2AZBrIu0WtrqOpWW9SQG3HuDFYsurv86U3D8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(6506007)(2616005)(6512007)(8936002)(2906002)(66946007)(66476007)(53546011)(64756008)(26005)(8676002)(4326008)(66446008)(6486002)(76116006)(478600001)(41300700001)(5660300002)(186003)(38100700002)(316002)(36756003)(54906003)(6916009)(66556008)(91956017)(33656002)(71200400001)(86362001)(122000001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <211465EF80024A42BF646BA32D373279@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8465 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 388fab50-19db-4813-f1b5-08da900907b3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QoBAEG+TB1TmXcQARJ5snLo1Edm5d8i9efkcjFavSI5tqV2I3BWW0L2zLBWI1m0sVlLlaJwDjoKaq2OGU/FMLtu9pSKJA8+pXwQNJclzIPizp5xcLZjtrTHCddTbTjiXBYdZnS1oiuj85QPPVEVdSQxAZmhdGkNTKXphyg7puNgEX/nM7cKfhtptnux0QHOW5zyJ0OqznDo4+BXF4Nnj9svbjcfVZ2W5c3iNm4Ok59XefpXpr2sbzhVPKVC57iel2WuVo2ccQVK1UKUo8ZOa3amOuvBK1mzd8v2xqSmBkFC92jiIRHZ/ASA2rWek3r2qtlktwwNpWDL0TuqzH9NymtmlTNXhDG66nkVS17MF4a2gvUdEVi4rkUS0zgpjU7GkIq/42IaJjYoQbQ8FXaVzLLEenU46Zp53ldjzs2kxnPkWdduh2+HhXKEiGWt2Sz1szBIEyOSnf5PgutSpJz8xcVWusj1eySxsbbbuXw0JvjVTH7AnJMZxjI7ZATDq+NPk/nM1Uz95nTgtyiF3s9/3tqlBuJLJRHwvmFG+AmqpDtKjtU+5b77F+AxcSrEFLQvniqm7FF87BzP4/VGyNi4bw7lW9njDR8mg6p86lILpKQ6IMYsiivKEnYcyU4tT+hvWK/9Kzj2IW0Pygo1UtpB6oj4W0blRVBi8MpsMDYA+00ZOyZmkUsZT9x+n8B4/C4BL8UKAJQ/0BuNKK5Z2EB3rJxkaMc/0lkzzvk45glyp2JiFj+iMo/FAs5Vn/EEYKem18WikG6AL3T68pNndm19AUw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(39860400002)(396003)(36840700001)(40470700004)(46966006)(36756003)(8676002)(36860700001)(70586007)(4326008)(70206006)(2906002)(316002)(54906003)(5660300002)(6862004)(8936002)(33656002)(41300700001)(82310400005)(6486002)(40480700001)(6512007)(47076005)(336012)(478600001)(2616005)(186003)(40460700003)(356005)(81166007)(53546011)(26005)(6506007)(82740400003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 13:09:37.1494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2d538a-032c-4bfc-b295-08da90090ce7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6118 Hi Leo, > On 6 Sep 2022, at 12:31, Leo Yan wrote: >=20 > On Arm64 Linux kernel prints log for Xen version number: >=20 > [ 0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found >=20 > Because the header file "xen/compile.h" is missed, XEN_VERSION and > XEN_SUBVERSION are not defined, thus compiler directly uses the > string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string. >=20 > This patch includes the header "xen/compile.h" which defines macros for > XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via > hypervisor node. >=20 > Signed-off-by: Leo Yan Very nice finding and side effect from stringify. Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/acpi/domain_build.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_= build.c > index bbdc90f92c..2649e11fd4 100644 > --- a/xen/arch/arm/acpi/domain_build.c > +++ b/xen/arch/arm/acpi/domain_build.c > @@ -9,6 +9,7 @@ > * GNU General Public License for more details. > */ >=20 > +#include > #include > #include > #include > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400394.642121 (Exim 4.92) (envelope-from ) id 1oVgSi-00037s-7T; Tue, 06 Sep 2022 21:50:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400394.642121; Tue, 06 Sep 2022 21:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSi-00037f-3I; Tue, 06 Sep 2022 21:50:28 +0000 Received: by outflank-mailman (input) for mailman id 400394; Tue, 06 Sep 2022 21:50:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIe-0000Cs-Jr for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:40:04 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2069.outbound.protection.outlook.com [40.107.105.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51fdf2d6-2df7-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:19:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5538.eurprd04.prod.outlook.com (2603:10a6:208:116::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Tue, 6 Sep 2022 15:19:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 15:19:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51fdf2d6-2df7-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SYMGqPpnjogP8Al98+icrL464+9P70ZKJCnJa/r82Dyp+lFCcv0x/dqqPjGpMWmz1e7SN2H6kPOeD3wzW/TSnWRIvWoHzaGF2uwl6cHXApr2g02VF3PUchaENodAn/E+VrXrRJmTv+EMXUxChNLmj/Ns4flnSkcBEs6kFFmrrJllR98BAg8xECTAem/tD/g3GLp6cx8yHDjgB0+BPGszg06xqTxM7JMEarPnrs90a2xvB1ZDDpOLMdjaWlLVr4/DRryOjST5jolRS4qy4c2dTEexNwzQaXHWR8KYuu4bZ3UPV7Fa+0xYskFj9daKo7VogoC92BJmQV5XmJkzBCuyhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDEf9qVEL1hTifWUUb4Tp4Q2nMlfRlUG6qWgu15qKVg=; b=SyNWjMDV/pr+03Z6X6Ya9ZNzUbdVrrCyMVcuDUnds/p540nJo5Zyj7s71KuT9WF4bajXmTb/s7YU36i7XT/xU9s2o06EKoWXKYz0JQkFGoo0kSFhajHxnOMfuPQYBtyGbtdzQKTzkRjHbBd8gaHNxt6abBCVktsyacFupP0ZCMUsPqOiEUQYZXIt8wv7QLcEbRkNSlwLN6lueNb+DCxPT70md0juLDKnJhE34wW0VW6sK8Mq2bgARwzfNBPEMK/7MiLnUplx+PGywpWjYDfzyq0IpQ5OHZQspiwAODX/YWUJdqqCQAZADzF8wzAK8W8NUMrtQg9y5aItzFT2jq5tIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDEf9qVEL1hTifWUUb4Tp4Q2nMlfRlUG6qWgu15qKVg=; b=iqGOwWYCgXg1y4HHPBoYuj/s7aD4mmsJjXh5x0rQIjT2E5o5C8UrEgMVYcqSPJKEmVPUSakkdLT4/k0NMjiOQuLKFzKnJoPvQs0gceYr4tSbIfRgGMh47ccxWpJF+uZEydMSKqYZZ4gcmsPMyR3hDmw3ZvaESSTA+noAe6It7k2ZhNOF+vMsRCQWHglCoSRVxebpWUhJHY81qrVttHZOYlRTHh7isc7ZU3AK5LYwH/mPO1+WmbyT6FiO5u2wW523xmxE6vnkZaKw1kGFF9ajYtzwwf4K8aZXJMmLHnXouZnZ2+7X81mf49w8s8GPGn3ijcDLYIjbrc+ee0js5lTcyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <788681d2-123b-8af1-0f29-cae0c72a920f@suse.com> Date: Tue, 6 Sep 2022 17:19:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v1 1/4] automation: Only filter build-*/ in gitignore Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ac93ecb6-e7e2-4eae-aec9-08da901b3528 X-MS-TrafficTypeDiagnostic: AM0PR04MB5538:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A9ApIci+jiV2kEub7pv5WKd3kL3zkZQ+eWlsTC8SR9ypdK8mY3vEAbBYZ88jc8Op9XlvGyjcxaHoKQpexOzAHYTXoq7IaJ6M3BzvHFtK8DpaOabKU420G/kzdfEIuZntFx33wU5xbbR8J9dkfGCeCk1M71fkVpU9CgEf1PHzStjlR8czFsQDm3ceMIn/4hz0lZ+URVsdLCFP3Won3UuKq0uB89WU5a+OnZRn6FXJfQDlZKNqzcS0xfHi93Xnd1p4kOSrQcsxM8TGy1KmmPXgidr4OQlHnh9WJ60iseiITl9P3xgCewBNA3q2HLC/FD2/ofDOYtDtmAX5CdkdITXk9kmI9F3ZPbY22gCu1HPqedH4o9tObKAnUAgc3vKsw7qTEoIsiE8yEchlDkeLw7yp8IymaCQoT6GqUcvHwdXPMOWchcDtlbdB5P/9ab7VUno0FnQVsUAQMefVBrTnP0a/354KBO2qUqT6AZcPv1wUoznhTAAWBrqEAkG92nkYAn7PuIsnXqmmEmKhao24SQmHceMyxHHoOpShzXYotslknGohcaRcrnc0rVZZTJ2AVfY8qx0pTmqNGoDdmcrkl7fyBP/iYLi19/siHajQYqpUcLofpoyeC1CRZpEJsCVomcZQiNtiaZnK3WsJ4EwbCIQCa3V4d+mEuHoWB5GV3Bz3siCYPQPfZEDxgnxpk+O3z2ITnDmm3FsQ2bpzALByFHVWF1HyDWIq9gXW6JkXvlqu40d5ME8bLMX7+ev9cmJwRCFKYeDfMM7a35IT7ArL5QFWX1aBapalvEL3MhM2ditjxbA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(396003)(39860400002)(346002)(8936002)(5660300002)(2906002)(31686004)(66476007)(36756003)(8676002)(558084003)(38100700002)(4326008)(66556008)(66946007)(316002)(6916009)(54906003)(86362001)(31696002)(6506007)(26005)(2616005)(41300700001)(186003)(478600001)(53546011)(6512007)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDAyZ0N2dUVmRFdVMnNraTZ6eFJpQWJoNGN5dXhWYm93Zkh6QmNaMGdLVHNx?= =?utf-8?B?UFAyNjhXOXJMN0xvZ3ZGRm5tb21RclpTR3VQY3JGcSt0c3FDdEZ6ZEhKRHhT?= =?utf-8?B?ZW5Wc05ESmxuUklCQnZ2d2V2MFFZR0Urd3g3UkN4U1NJZ1BGSUcvdFJXc01j?= =?utf-8?B?Vk1oSmtkQ0NUSzM1bXAvVlhUcjM3cU1nOHpBTzdndUdhV21QTUEzRy9RWXk2?= =?utf-8?B?SnRjZHZ5dWg5dG1oTDV3WHlNQ2NYQ1FsT3JaVnU5VkUyR0N0eERjN0gvZWMw?= =?utf-8?B?dnh1YlpKQXgvK25lTzNYaVBXQjlmY0N4Y21LT0ZXejRXWW9BRnBJR0dKZnha?= =?utf-8?B?VzJNbXdkOUUrRy9wNnJnb05lQXpwa0FSUmdPZmlKejBoY2NmUXhFWHhHbldS?= =?utf-8?B?Um02TFFyaEMzRUhVR2JSSEplMU52Slc1cFZSS3JaTUV1dWQ1eFB4ZHlwZGJn?= =?utf-8?B?MCtENHdsL0NwNE0vVTFBSml6dzg1dCtvWVNKQmhTeC9HRGFCL2M5VnExSGZJ?= =?utf-8?B?V1QvM1NuczUwREFtZGFaQkUzU3NSeUNOTDZjZ3ljc2xlMW13Y05yQ1ovdkdr?= =?utf-8?B?OGFoU215Mlp5OHU0NkdyUG9ZaGQxZWZNdmxvcGhva2MvM1pNUExneWJ6OFkz?= =?utf-8?B?Y1NwWkRsRGZTbGpOQWV5anJzNnFmOEI0aDBCd05WbXAwVjJtMWpmdEEwdnN5?= =?utf-8?B?eXpoOGFvR1J5Y2RJWVNrdWZ4UzU1SHl3dE1XUFd1VTAyaUxEZXJWYkxXRjRm?= =?utf-8?B?eHB0dnBEVlZxaU04bTJyZVdxUlFRZ3pLZHV3bjJTdUJaR2ZSdkx0UWFoNnFX?= =?utf-8?B?U2hUREJIVXRCS2pBSUN3TGh1d1FuenR2VzdYanVlQmVKeUNkN0ozNjVvYURm?= =?utf-8?B?cWJ3K0xRQi9XQXFycmZXbnFTaDNBc3BiMytYWCtic2Vvc1pBcE4vRndpZmhp?= =?utf-8?B?a2JpakZTVC9ScmVLeFBYcU1Sd211MXNaV0pINjBGbXhUTFZkWjBJNWE1Zll5?= =?utf-8?B?M3FRZDkzbFYrVjRlMnM5b3pDaU1ITGs1eUdzZ2ZpVVpURkRCMisrcFJaRno2?= =?utf-8?B?dXVTcHdOZnZaRngzUHo4ZTAveEFKVUpSS1FEcjZkMDQwdStyVjNvSzlVUVZu?= =?utf-8?B?by9wZ0I0VW1ndkVwOTVCVHBEODdNYzZEMjlwcEEwbEdPTTA2aTB5RC9UdXlB?= =?utf-8?B?dTdYc3VlOEYzbUNMK1J1dStTNXhqUU5zMWs1T0ZzQkN5VjhoQk9XL1dOakl6?= =?utf-8?B?OXVrdHVHcTBWbHgxdzg4L3ozNVRnK2dFeTYrSzJ1WFVCekxJSUtoeHpXVlVE?= =?utf-8?B?NlNVUjIzZUNFWk9QL0xRUENFeW1lcVg3em5yV1lUS0dqa3BPcXorSW1wcVdT?= =?utf-8?B?MjBvaysvakZhRUU2Zmc1RDdueklnRG8xeU9DbXhSaDdndUpSeW9xaSsxa0JC?= =?utf-8?B?R1pWNW5nSzA4T0FLbyszVDcxTGxRNmV4TlZNZE9yL0UyTzQ3ZzY2QWpvcU5q?= =?utf-8?B?UVNuQW82U1NTaCtTZ2ZKRVhmOXF5elREYUtOWnMzcTFKVWxHZENaMm4xd2l1?= =?utf-8?B?TVloOHAzdEFjNUZHdVI4VUl1SUlueWZyNWhZTkQ4UnRPaXMzTGtydzJ6RCtu?= =?utf-8?B?VnB0RjRVR0VucGZROTU5b2pVRm9QN3FKNGlBMU8yVWk4SGFkQzc4SVdMZWVD?= =?utf-8?B?NFlqMU50bStmcS9BaW9STDlnYnpsck8rZ3ZYcVRaeTNrTkdkRTJlZFdsUFhn?= =?utf-8?B?UzNZZDdNblExRzJldmpTOW9ROEdJK2JhMmRhWkRsbElGVHRQcnFrNm1jK0ZB?= =?utf-8?B?a2dGMEx6R2ZJYkErL05lTisrSkZ3eTBESlQ4VndkcnRPbXhVYXpiNmFteW8y?= =?utf-8?B?T0Q3bm1EaVlWYXJtVGcvWHg4djdQdU9PTUxRMzN6V0pjNWNXWVY3TFAzR1M5?= =?utf-8?B?L2RNS0k0dVlZekJNTUN4ZlZYb3lUNUhLZk5qRGhnU1h2dlBZWlk3ZjMxWHAy?= =?utf-8?B?MjZQVC91WXRtcDBsdlFNWXl4T3k0d1ZuNjdFakZBR2ZBb3BYbWVWREhDSitV?= =?utf-8?B?MFFzVEo2VG5kWHZITVVnWSt0bnI1b1NtQzh2VnV5Z3hZd2VzVmdScHE2d1NJ?= =?utf-8?Q?mCkowj4y6tzko4fkxH8YWfGxH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac93ecb6-e7e2-4eae-aec9-08da901b3528 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:19:35.8128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T5sSqjRoWgWOJ/RJ/gtlGqVUYFa4JlwuWdEyoo5kC9O9zeVXBMGN8Bgm6rC34heIGekrkQVzxg1EkqpYBBdylQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5538 On 24.08.2022 16:57, Bertrand Marquis wrote: > ...because there are some script in automation corresponding to the > build-* filter (build-test.sh and build-each-commit.sh) > > Signed-off-by: Bertrand Marquis Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400399.642127 (Exim 4.92) (envelope-from ) id 1oVgSj-0003Jh-2i; Tue, 06 Sep 2022 21:50:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400399.642127; Tue, 06 Sep 2022 21:50:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSi-0003HR-R7; Tue, 06 Sep 2022 21:50:28 +0000 Received: by outflank-mailman (input) for mailman id 400399; Tue, 06 Sep 2022 21:50:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgHs-0000Cs-BU for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:16 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4506b3cb-2dc2-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 10:59:52 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 897E81756; Tue, 6 Sep 2022 02:00:02 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id ED8C93F7B4; Tue, 6 Sep 2022 01:59:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4506b3cb-2dc2-11ed-af93-0125da4c0113 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v7 1/9] xen/arm: introduce static shared memory Date: Tue, 6 Sep 2022 16:59:33 +0800 Message-Id: <20220906085941.944592-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906085941.944592-1-Penny.Zheng@arm.com> References: <20220906085941.944592-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This patch series introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng --- v7 change: - add docs about checking for region overlap, etc - update docs to reflect that the host physical address is optional - end/bank_end may end up to be lower than paddr/mem->bank[i].start, So check that they don't overflow. - replace strcmp with strncmp since the string has already be validated - provide a dummy helper for process_shm_node() when !CONFIG_STATIC_SHM - remove useless #ifdef CONFIG_STATIC_SHM - change the order of property xen,shared-mem to xen,shared-mem = < [host physical address] [guest address] [size] > --- v6 change: - when host physical address is ommited, output the error message since xen doesn't support it at the moment - add the following check: 1) The shm ID matches and the region exactly match 2) The shm ID doesn't match and the region doesn't overlap - change it to "unsigned int" to be aligned with nr_banks - check the len of the property to confirm is it big enough to contain "paddr", "size", and "gaddr" - shm_id defined before nr_shm_domain, so we could re-use the existing hole and avoid increasing the size of the structure. - change "nr_shm_domain" to "nr_shm_borrowers", to not increment if the role is owner in parsing code - make "xen,shm_id" property as arbitrary string, with a strict limit on the number of characters, MAX_SHM_ID_LENGTH --- v5 change: - no change --- v4 change: - nit fix on doc --- v3 change: - make nr_shm_domain unsigned int --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 132 +++++++++++++++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 165 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 7 ++ 4 files changed, 310 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..1c50fc6351 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,135 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An arbitrary string that represents the unique identifier of the shared + memory region, with a strict limit on the number of characters(\0 included), + `MAX_SHM_ID_LENGTH(16)`. e.g. "xen,shm-id = "my-shared-mem-1"". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. + e.g. xen,shared-mem = < [host physical address] [guest address] [size] > + + It shall also meet the following criteria: + 1) If the SHM ID matches with an existing region, the address range of the + region shall also exactly match. + 2) If the SHM ID does not match with any other existing region, it should + also not overlap with any other regions. + + The number of cells for the host address (and size) is the same as the + guest pseudo-physical address and they are inherited from the parent node. + + Host physical address is optional, when missing Xen decides the location + (currently unimplemented). + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + DOMID_IO, a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x50000000 0x10000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x60000000 0x20000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x70000000 0x20000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as "my-shared-mem-0", host +physical address starting at 0x10000000 of 256MB will be reserved to be +shared between Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest +physical address space, and at 0x50000000 in DomU1 guest physical address space. +Dom0 is explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as "my-shared-mem-1", host +physical address starting at 0x50000000 of 512MB will be reserved to be +shared between DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest +physical address space, and at 0x70000000 in DomU2 guest physical address space. +DomU1 and DomU2 are both the borrower domain, the owner domain is the default +owner domain DOMID_IO. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 33e004d702..1fe5faf847 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -140,6 +140,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..b2cd425dac 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -361,6 +362,168 @@ static int __init process_domain_node(const void *fdt, int node, size_cells, &bootinfo.reserved_mem, true); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + const struct fdt_property *prop, *prop_id, *prop_role; + const __be32 *cell; + paddr_t paddr, gaddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned int i; + int len; + bool owner = false; + const char *shm_id; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + /* + * "xen,shm-id" property holds an arbitrary string with a strict limit + * on the number of characters, MAX_SHM_ID_LENGTH + */ + prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); + if ( !prop_id ) + return -ENOENT; + shm_id = (const char *)prop_id->data; + if ( strnlen(shm_id, MAX_SHM_ID_LENGTH) == MAX_SHM_ID_LENGTH ) + { + printk("fdt: invalid xen,shm-id %s, it must be limited to %u characters\n", + shm_id, MAX_SHM_ID_LENGTH); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * it must be either `owner` or `borrower`. + */ + prop_role = fdt_get_property(fdt, node, "role", NULL); + if ( prop_role ) + { + if ( !strcmp(prop_role->data, "owner") ) + owner = true; + else if ( strcmp(prop_role->data, "borrower") ) + { + printk("fdt: invalid `role` property for static shared memory node.\n"); + return -EINVAL; + } + } + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + prop = fdt_get_property(fdt, node, "xen,shared-mem", &len); + if ( !prop ) + return -ENOENT; + + if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) + { + if ( len == dt_cells_to_size(size_cells + address_cells) ) + printk("fdt: host physical address must be chosen by users at the moment.\n"); + + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } + + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); + size = dt_next_cell(size_cells, &cell); + + if ( !size ) + { + printk("fdt: the size for static shared memory region can not be zero\n"); + return -EINVAL; + } + + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * Meet the following check: + * 1) The shm ID matches and the region exactly match + * 2) The shm ID doesn't match and the region doesn't overlap + * with an existing one + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + { + if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + break; + else + { + printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", + shm_id); + return -EINVAL; + } + } + else + { + paddr_t end = paddr + size; + paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + + if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) + printk("fdt: static shared memory region %s overflow\n", shm_id); + + if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + { + if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) + continue; + else + { + printk("fdt: different shared memory region could not share the same shm ID %s\n", + shm_id); + return -EINVAL; + } + } + else + { + printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", + mem->bank[i].start, bank_end); + return -EINVAL; + } + } + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = true; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of borrowers, which later may be used + * to calculate the reference count. + */ + if ( !owner ) + mem->bank[i].nr_shm_borrowers++; + + return 0; +} +#else +static int __init process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + printk("CONFIG_STATIC_SHM must be enabled for parsing static shared memory nodes\n"); + WARN(); + return -EINVAL; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -386,6 +549,8 @@ static int __init early_scan_node(const void *fdt, process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..995eee1d09 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -23,10 +23,17 @@ typedef enum { } bootmodule_kind; +/* Indicates the maximum number of characters(\0 included) for shm_id */ +#define MAX_SHM_ID_LENGTH 16 + struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ +#ifdef CONFIG_STATIC_SHM + char shm_id[MAX_SHM_ID_LENGTH]; + unsigned int nr_shm_borrowers; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400403.642143 (Exim 4.92) (envelope-from ) id 1oVgSn-000400-Gj; Tue, 06 Sep 2022 21:50:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400403.642143; Tue, 06 Sep 2022 21:50:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSn-0003zk-Aj; Tue, 06 Sep 2022 21:50:33 +0000 Received: by outflank-mailman (input) for mailman id 400403; Tue, 06 Sep 2022 21:50:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI7-0000Cs-Ec for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id dd83d0cd-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:01:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A1963D6E; Tue, 6 Sep 2022 03:01:31 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 482E73F534; Tue, 6 Sep 2022 03:01:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd83d0cd-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Christophe JAILLET , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Robin Murphy , Will Deacon Subject: [PATCH v4 10/10] xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation Date: Tue, 6 Sep 2022 10:55:57 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Christophe JAILLET Backport Linux commit 98b64741d611. This is the clean backport without any changes kmalloc_array()/kcalloc() should be used to avoid potential overflow when a multiplication is needed to compute the size of the requested memory. So turn a devm_kzalloc()+explicit size computation into an equivalent devm_kcalloc(). Signed-off-by: Christophe JAILLET Acked-by: Robin Murphy Link: https://lore.kernel.org/r/3f7b9b202c6b6f5edc234ab7af5f208fbf8bc944.1644274051.git.christophe.jaillet@wanadoo.fr Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 98b64741d611 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index b8ca4b0a24..9c9f463009 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1644,10 +1644,10 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) { unsigned int i; struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg; - size_t size = sizeof(*cfg->l1_desc) * cfg->num_l1_ents; void *strtab = smmu->strtab_cfg.strtab; - cfg->l1_desc = _xzalloc(size, sizeof(void *)); + cfg->l1_desc = _xzalloc_array(sizeof(*cfg->l1_desc), sizeof(void *), + cfg->num_l1_ents); if (!cfg->l1_desc) return -ENOMEM; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400411.642154 (Exim 4.92) (envelope-from ) id 1oVgSp-0004Qs-PU; Tue, 06 Sep 2022 21:50:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400411.642154; Tue, 06 Sep 2022 21:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSp-0004Qe-L9; Tue, 06 Sep 2022 21:50:35 +0000 Received: by outflank-mailman (input) for mailman id 400411; Tue, 06 Sep 2022 21:50:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIP-0000Cs-HA for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id dc1713fa-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:01:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F8D8176C; Tue, 6 Sep 2022 03:01:29 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1F1DA3F534; Tue, 6 Sep 2022 03:01:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc1713fa-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: "Gustavo A. R. Silva" , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , kernel test robot Subject: [PATCH v4 09/10] xen/arm: smmuv3: Fix fall-through warning for Clang Date: Tue, 6 Sep 2022 10:55:56 +0100 Message-Id: <8ac83afdb6be598dc9965f86041f5a515486a7c4.1662455798.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Gustavo A. R. Silva" Backport Linux commit 5a1ab5c0299a. This is the clean backport without any changes. Fix the following fallthrough warning (arm64-randconfig with Clang): drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:382:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] Reported-by: kernel test robot Link: https://lore.kernel.org/lkml/60edca25.k00ut905IFBjPyt5%25lkp@intel.com/ Signed-off-by: Gustavo A. R. Silva Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5a1ab5c0299a Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by. Changes in v2: - fix commit msg. --- xen/drivers/passthrough/arm/smmu-v3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index c47e7dea04..b8ca4b0a24 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -492,6 +492,7 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) switch (idx) { case CMDQ_ERR_CERROR_ABT_IDX: dev_err(smmu->dev, "retrying command fetch\n"); + return; case CMDQ_ERR_CERROR_NONE_IDX: return; case CMDQ_ERR_CERROR_ATC_INV_IDX: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400415.642165 (Exim 4.92) (envelope-from ) id 1oVgSs-0004vH-C9; Tue, 06 Sep 2022 21:50:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400415.642165; Tue, 06 Sep 2022 21:50:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSs-0004uW-4f; Tue, 06 Sep 2022 21:50:38 +0000 Received: by outflank-mailman (input) for mailman id 400415; Tue, 06 Sep 2022 21:50:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIV-0000Cs-Im for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:55 +0000 Received: from mail136-23.atl41.mandrillapp.com (mail136-23.atl41.mandrillapp.com [198.2.136.23]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e242cf91-2dc9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:54:23 +0200 (CEST) Received: from pmta11.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail136-23.atl41.mandrillapp.com (Mailchimp) with ESMTP id 4MMLMM6jwpz1XMpv1 for ; Tue, 6 Sep 2022 09:54:23 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 8ccb6ebb1d8746c59fc358783ad67ab1; Tue, 06 Sep 2022 09:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e242cf91-2dc9-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1662458063; x=1662760463; i=andrei.semenov@vates.fr; bh=9M3+qLiWJriRB2iQVM16e9Wo2zoVHPoQDkx5vj3yF7g=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=mTKiS1YJJO9oWbo5fP2flAiNRZAbs764ovofQu4SwmSqn5ZWs5+Sdn7RJdJY/00Ac DjMemgAr1Jt2f/br6utVVFIoU9crLUFM2D4EYj2zJ4/NnEHJE2MeGcGmRxFI14t/3m qfdtZ/yClmm2bh7kexV/SEdeuzRpTzABXhuC6+Eo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1662458063; h=From : Subject : To : Cc : Message-Id : In-Reply-To : References : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=9M3+qLiWJriRB2iQVM16e9Wo2zoVHPoQDkx5vj3yF7g=; b=gjWmycH6CEwrpfiB3zwMaU/QSoFfJK3wtu/hv2SbUeXbCJNGwQ20xIr8hIrB195GNlh0Bb oe0EJK61jWYXowjy/eWAHTMIGuQXid8iunbsE1q2CjXpiRJjoz8XbpYoAQFk3z59jRa1hmDn fc0PKVBfS/RvexpzBCSd26GcYAty0= From: Andrei Semenov Subject: [PATCH v2 1/2] live migration: do not use deffered bitmap when inappropriate X-Mailer: git-send-email 2.34.1 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 5cd6f291-6f11-459d-97c0-d09b574c3896 X-Bm-Transport-Timestamp: 1662458062869 To: andrei.semenov@vates.fr, xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Juergen Gross Message-Id: <1e7862a0d83c61b7550747591275c38e87d4fbd2.1662457291.git.andrei.semenov@vates.fr> In-Reply-To: References: X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.8ccb6ebb1d8746c59fc358783ad67ab1 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20220906:md Date: Tue, 06 Sep 2022 09:54:23 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Use deffered bitmap only in PV guests context as it not used for HVM guests. This allow to reduce memory pressure on domain0 while migrating very large (memory wise) HVM guests. Signed-off-by: Andrei Semenov --- tools/libs/guest/xg_sr_common.h | 26 ++++++++++++++++-- tools/libs/guest/xg_sr_save.c | 23 +++++++--------- tools/libs/guest/xg_sr_save_x86_hvm.c | 21 +++++++++++++++ tools/libs/guest/xg_sr_save_x86_pv.c | 39 +++++++++++++++++++++++++++ 4 files changed, 93 insertions(+), 16 deletions(-) diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index 36d45ef56f..941e24d7b7 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -96,6 +96,24 @@ struct xc_sr_save_ops */ int (*check_vm_state)(struct xc_sr_context *ctx); + /** + * For some reasons the page can't be sent for the moment. Postpone this + * send to the later stage when domain is suspended. + */ + int (*defer_page)(struct xc_sr_context *ctx, xen_pfn_t pfn); + + /** + * Merge all deferred pages with the dirty pages bitmap (in order to be + * sent). + */ + int (*merge_deferred)(const struct xc_sr_context *ctx, + unsigned long *bitmap, unsigned long *count); + + /** + * Deferred pages was successfully sent. Reset all associated information. + */ + int (*reset_deferred)(struct xc_sr_context *ctx); + /** * Clean up the local environment. Will be called exactly once, either * after a successful save, or upon encountering an error. @@ -243,8 +261,6 @@ struct xc_sr_context xen_pfn_t *batch_pfns; unsigned int nr_batch_pfns; - unsigned long *deferred_pages; - unsigned long nr_deferred_pages; xc_hypercall_buffer_t dirty_bitmap_hbuf; } save; @@ -349,6 +365,12 @@ struct xc_sr_context union { + struct + { + unsigned long *deferred_pages; + unsigned long nr_deferred_pages; + } save; + struct { /* State machine for the order of received records. */ diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 9853d8d846..602b18488d 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -132,8 +132,7 @@ static int write_batch(struct xc_sr_context *ctx) /* Likely a ballooned page. */ if ( mfns[i] == INVALID_MFN ) { - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); - ++ctx->save.nr_deferred_pages; + ctx->save.ops.defer_page(ctx, ctx->save.batch_pfns[i]); } } @@ -192,8 +191,7 @@ static int write_batch(struct xc_sr_context *ctx) { if ( rc == -1 && errno == EAGAIN ) { - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); - ++ctx->save.nr_deferred_pages; + ctx->save.ops.defer_page(ctx, ctx->save.batch_pfns[i]); types[i] = XEN_DOMCTL_PFINFO_XTAB; --nr_pages; } @@ -641,6 +639,7 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx) xc_interface *xch = ctx->xch; xc_shadow_op_stats_t stats = { 0, ctx->save.p2m_size }; char *progress_str = NULL; + unsigned long merged; int rc; DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->save.dirty_bitmap_hbuf); @@ -669,7 +668,7 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx) else xc_set_progress_prefix(xch, "Checkpointed save"); - bitmap_or(dirty_bitmap, ctx->save.deferred_pages, ctx->save.p2m_size); + ctx->save.ops.merge_deferred(ctx, dirty_bitmap, &merged); if ( !ctx->save.live && ctx->stream_type == XC_STREAM_COLO ) { @@ -681,12 +680,11 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx) } } - rc = send_dirty_pages(ctx, stats.dirty_count + ctx->save.nr_deferred_pages); + rc = send_dirty_pages(ctx, stats.dirty_count + merged); if ( rc ) goto out; - bitmap_clear(ctx->save.deferred_pages, ctx->save.p2m_size); - ctx->save.nr_deferred_pages = 0; + ctx->save.ops.reset_deferred(ctx); out: xc_set_progress_prefix(xch, NULL); @@ -805,18 +803,16 @@ static int setup(struct xc_sr_context *ctx) xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE * sizeof(*ctx->save.batch_pfns)); - ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); - if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages ) + if ( !ctx->save.batch_pfns || !dirty_bitmap ) { - ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and" - " deferred pages"); + ERROR("Unable to allocate memory for dirty bitmaps, batch pfns"); rc = -1; errno = ENOMEM; goto err; } - rc = 0; + rc = ctx->save.ops.reset_deferred(ctx); err: return rc; @@ -837,7 +833,6 @@ static void cleanup(struct xc_sr_context *ctx) xc_hypercall_buffer_free_pages(xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); - free(ctx->save.deferred_pages); free(ctx->save.batch_pfns); } diff --git a/tools/libs/guest/xg_sr_save_x86_hvm.c b/tools/libs/guest/xg_sr_save_x86_hvm.c index 1634a7bc43..3c762a0af0 100644 --- a/tools/libs/guest/xg_sr_save_x86_hvm.c +++ b/tools/libs/guest/xg_sr_save_x86_hvm.c @@ -211,6 +211,24 @@ static int x86_hvm_end_of_checkpoint(struct xc_sr_context *ctx) return 0; } +static int x86_hvm_defer_page(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + return 0; +} + +static int x86_hvm_merge_deferred(const struct xc_sr_context *ctx, + unsigned long *bitmap, unsigned long *count) +{ + *count = 0; + + return 0; +} + +static int x86_hvm_reset_deferred(struct xc_sr_context *ctx) +{ + return 0; +} + static int x86_hvm_cleanup(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; @@ -237,6 +255,9 @@ struct xc_sr_save_ops save_ops_x86_hvm = .start_of_checkpoint = x86_hvm_start_of_checkpoint, .end_of_checkpoint = x86_hvm_end_of_checkpoint, .check_vm_state = x86_hvm_check_vm_state, + .defer_page = x86_hvm_defer_page, + .merge_deferred = x86_hvm_merge_deferred, + .reset_deferred = x86_hvm_reset_deferred, .cleanup = x86_hvm_cleanup, }; diff --git a/tools/libs/guest/xg_sr_save_x86_pv.c b/tools/libs/guest/xg_sr_save_x86_pv.c index 4964f1f7b8..5fdc7e9590 100644 --- a/tools/libs/guest/xg_sr_save_x86_pv.c +++ b/tools/libs/guest/xg_sr_save_x86_pv.c @@ -1031,6 +1031,7 @@ static int x86_pv_normalise_page(struct xc_sr_context *ctx, xen_pfn_t type, */ static int x86_pv_setup(struct xc_sr_context *ctx) { + xc_interface *xch = ctx->xch; int rc; rc = x86_pv_domain_info(ctx); @@ -1049,6 +1050,15 @@ static int x86_pv_setup(struct xc_sr_context *ctx) if ( rc ) return rc; + ctx->x86.pv.save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); + + if (!ctx->x86.pv.save.deferred_pages) + { + ERROR("Unable to allocate memory for deferred pages"); + errno = ENOMEM; + return -1; + } + return 0; } @@ -1116,9 +1126,35 @@ static int x86_pv_check_vm_state(struct xc_sr_context *ctx) return x86_pv_check_vm_state_p2m_list(ctx); } +static int x86_pv_defer_page(struct xc_sr_context *ctx, xen_pfn_t pfn) +{ + set_bit(pfn, ctx->x86.pv.save.deferred_pages); + ++ctx->x86.pv.save.nr_deferred_pages; + + return 0; +} + +static int x86_pv_merge_deferred(const struct xc_sr_context *ctx, + unsigned long *bitmap, unsigned long *count) +{ + bitmap_or(bitmap, ctx->x86.pv.save.deferred_pages, ctx->save.p2m_size); + *count = ctx->x86.pv.save.nr_deferred_pages; + + return 0; +} + +static int x86_pv_reset_deferred(struct xc_sr_context *ctx) +{ + bitmap_clear(ctx->x86.pv.save.deferred_pages, ctx->save.p2m_size); + ctx->x86.pv.save.nr_deferred_pages = 0; + + return 0; +} + static int x86_pv_cleanup(struct xc_sr_context *ctx) { free(ctx->x86.pv.p2m_pfns); + free(ctx->x86.pv.save.deferred_pages); if ( ctx->x86.pv.p2m ) munmap(ctx->x86.pv.p2m, ctx->x86.pv.p2m_frames * PAGE_SIZE); @@ -1142,6 +1178,9 @@ struct xc_sr_save_ops save_ops_x86_pv = .start_of_checkpoint = x86_pv_start_of_checkpoint, .end_of_checkpoint = x86_pv_end_of_checkpoint, .check_vm_state = x86_pv_check_vm_state, + .defer_page = x86_pv_defer_page, + .merge_deferred = x86_pv_merge_deferred, + .reset_deferred = x86_pv_reset_deferred, .cleanup = x86_pv_cleanup, }; -- 2.34.1 Andrei Semenov | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400417.642170 (Exim 4.92) (envelope-from ) id 1oVgSt-00053S-93; Tue, 06 Sep 2022 21:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400417.642170; Tue, 06 Sep 2022 21:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSs-00051k-Uz; Tue, 06 Sep 2022 21:50:38 +0000 Received: by outflank-mailman (input) for mailman id 400417; Tue, 06 Sep 2022 21:50:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI6-0000Cs-ET for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:30 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da6a6b6b-2dee-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 16:19:03 +0200 (CEST) Received: from mail-mw2nam04lp2176.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Sep 2022 10:18:53 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5289.namprd03.prod.outlook.com (2603:10b6:5:24c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 14:18:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 14:18:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da6a6b6b-2dee-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662473943; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=h33p7WuFVa8KR5uNEATucKr0vqD/jF7WN4N9ZgbkFzw=; b=XAJ/hm8QjQgx3n8Vwc4Tb2Qri/whr27s7EJbIXZYsx5DAuJie152Rea/ BaHdICssmY33CjAmUpMJTSS2TAx0p1hnQbpb4+rV/odjvmrx/Y8M0Pju6 cDKwKze+1T0My3E5CF5QT67NluGg07KzyRfIfn+urBHqNVR95ydbVfDvV 4=; X-IronPort-RemoteIP: 104.47.73.176 X-IronPort-MID: 79541581 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lOwV2qsZPaLtP6jJHIAchoSVEOfnVGNfMUV32f8akzHdYApBsoF/q tZmKW2CafuCZDHxKI10Od6zpxsO7JeGzIcwTwU9qi89F38Q+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4G1A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FY4W2dYpXDFSy eIBIQEsbhWliqWUxK3uH4GAhux7RCXqFKU2nyk8iBTmV7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9wnT/PVpi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv Dnu9GXlGBAKcteYzFJp91rz17KTxH6rAer+EpW1quRIgnnKl1ANCQ07U1zl+duFrkShDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ul7Cmdx6yS5ByWbkAkQzhbeZoZvck5bTUw0 xmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kOYgnnS99iFOuwkYfzEDSon zSS9nFh2fMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswKByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:U/49xqOSfzJHqMBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.93,294,1654574400"; d="scan'208";a="79541581" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsTdL1ut+ZKIqBvEOA9e4m87TW0ALk1Gt2oPLTjj2ST2Cd/uPSxVIyqcaLY5rrlKdNOWq1tv0sqDUAztWqmDSe3sl2VywmsFz85cca3gAKVaZqsDDVJiGwBAcdBVec/dW7UoWyc1HQkRxkkDYTu+5jU0ZJS6ZHlwDUzNi+I79SVvDhOUmmHiVRtPyLzVx00ov++FPC/Ry9V8m8H6ysX1JBm9r6D6OXNowS/4jmgwe0VyN67Qr3Uq82YroNy0bkF71QyzoWcyMK716RBR5knW+rZOWCWuQ1LPo3OIYqVy9ge/lRk7dwGrTy5U+SF9YSvr3ccADdvSIFTlKdqjq1Ua6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h33p7WuFVa8KR5uNEATucKr0vqD/jF7WN4N9ZgbkFzw=; b=DN8mJgkUcg6q5ppLqtQVEZt1zfUvuK9JeNmlgrV6wWYUEtkZbSNgMLF1v7D4Ifde66uzZwdpHIsJlsIi2it2EJI5BjYZzwp/fbFztT0V15J67cA+nR0T3e9BXUpduGNjElf0fjroPb8CP25mVMvZD08TnqpTQnjqszP1U4kQ3PhUYz4D48KsG4tpSivBkLWt3orXIOlnyTnXJo0tNjJBcr3E/7Bv0UBj9SbB90DVpWrv/ejvcnCEpqy+4z3HqqEpUb165dQDiI4L+zTXbQVE6WDAknA3A2CBqRZ09mObdw8ogna3mdozkN8atqozJOKB+VMDy4GUQSiJhCCPTTD4Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h33p7WuFVa8KR5uNEATucKr0vqD/jF7WN4N9ZgbkFzw=; b=UcpOVhOIlEycR41oRSQrlAqWpGvFXEYrku2w0FKynVpNLq1kvYFvq77cQBxLfzniBSx7oaDJHJOPcdoJWR49LvQJVITZmO/oDX7T87QHRtfHNIV6GgV6e3ApxBi3s9PjYgiIiQbyVu2fnsCURXYIm3iGLWxEQd5oWmHkm4znW/c= From: Andrew Cooper To: Jennifer Herbert , "jbeulich@suse.com" , "wl@xen.org" , Roger Pau Monne , Henry Wang CC: "xen-devel@lists.xenproject.org" Subject: Re: [for-4.17 PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable. Thread-Topic: [for-4.17 PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable. Thread-Index: AQHYwfuWslla8fUdWk+aob/m3t7waQ== Date: Tue, 6 Sep 2022 14:18:51 +0000 Message-ID: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> References: <20220830202706.1618386-1-jennifer.herbert@citrix.com> In-Reply-To: <20220830202706.1618386-1-jennifer.herbert@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d655b6a-0a19-4daa-a901-08da9012b911 x-ms-traffictypediagnostic: DM6PR03MB5289:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zg4kNtD1TWFrZdkiua3gOq1Tl00hMnLJtTtXtTOZqpK3yQQxqJuXPnIFFkAz8RBGMfNr7Zj+4e2oCBLk3i3KsdcPvT8dlFP39BrMVhI4vh5VDEXnXG86JC6BqCCYxCmpaBI786Ckb9GjijvpHnHi3Lcg12wv7NCgDNnhR5YWYa8NGS4zD3xJgaI6zJlwejB8+MRIZwFFpeZPWaJxICzIANGxuNOiUtwifLsDYez7iFwJqfquf+9qIiMEfHxj2BlAUn8Rg8OKwU2qi2TcBii2m/3hvOH9hI4ZMiHzrqCsYzoR5MJBOsRoTQsSezXcy2i66tSnwPpKALrUZE0osAjZFp6Wf1pdVfRzTmaHAnxK6QDwKz3atei6RiKqvFWl+HNSbrosPShZQBd+sObjdIGH2G31F018t4LxjhKO+ZETYRlun92pkPBz8lkWtTM2RizVqyhXXpAbc3wTu9GfEgShEHfgATRRbxPkGU9pFkozmeL/9/D8P20BAnTj2+zOz6X9dOvM6U1n40W3POalW38V7qgIv+7iK1Uby7O+CljMgtsjc5VsNQOYt7uwrdanDzHubbiV+MtnNyftLqHfbcqK+FAJa19eOYH4iF6+JGI+PwmIiFtWUz2USvDomoVcJW8mGDJCpWMVQtkf9bkNnkmZor5t8yXIT1z6OhNN3A66/BA/5/41/PVimN962J33HuNp9V7IaDJZzxUTi1NnCuKpd+2W0yX8hPWAmhUkaoMqh8nRv5lBdYt9n5o54WmXNGFbrPsRYOUBAhm84oPSfn6MwFhJ8W2/Is3bMXHwFGmIC/Fu3L5IHpIaN2uys0tkjzikHkkDzC0z0DQYa3J6TBojEg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(71200400001)(6506007)(26005)(478600001)(6486002)(41300700001)(6512007)(186003)(83380400001)(53546011)(5660300002)(2906002)(8936002)(2616005)(110136005)(76116006)(66556008)(66446008)(66476007)(64756008)(91956017)(4326008)(66946007)(31696002)(8676002)(316002)(86362001)(38100700002)(31686004)(38070700005)(82960400001)(122000001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YU5mSkt6Q0tvc3Zmc2VjeGZEWko2Q0x0OVVkV2xrOHJZaTZZazhZcEdBK2Vo?= =?utf-8?B?NGJjZmRHd1RiVmNCcGRXVUNFaE54TDBFNzJoQm55VGJ1UmFWNDJreGl5Vm4w?= =?utf-8?B?YmFjWXNYcWg1R05LcnpYampBbzRqOGF4cnRXUUVnMjRiUndxWnNxWXBEMWF4?= =?utf-8?B?UGZKdkN1N0xvc0xZYjN0MXl6d2JDN2tnT2R0aTFkT0dHc1lkam5UZHU2UEMx?= =?utf-8?B?NndHa01Vd0ZISy9zbWhmUTJVcWpxR2t2Um1Vc1RMSXdLVytmcld0di9veTBy?= =?utf-8?B?M2llaWNWR28rSnVnL0s4Q3F6TjdHRGNwc0FZZTBmUzZySk5ELzRkWmZ6WGlQ?= =?utf-8?B?N0YreGVXRjNGaTJIKzRHd3FQZVpoVlQ3TTRyTHAwWmpGQ3Z2QjQ1WEVMKytR?= =?utf-8?B?c01Wa0dTdHVzbTh1dHBxK2llYzVtNk5ONXVwKzh5V1kyNmVxbzVCYnJ6TjB1?= =?utf-8?B?dWxXek9CSFg4NkZ3cWl4N1BoZ0NkTXB5M3NIdk1zZ2k2ME52alN3REJoejRL?= =?utf-8?B?bitFcU1KMUFvRTRpNk1lemdyemVscjZqbGEwT21oeVdrTm5tUUpkaEd4bUlW?= =?utf-8?B?VXdPdEc0ZTJib1AxcXhGbkdva1pLdVVSUGhxRmw2VnR5ZWNtRS9ISC85VDky?= =?utf-8?B?dnVCbWgxWUVaWUhNL01BVEl3bVc4bmlMY0lNT1JnOHVldXYya0l2b0kreUE0?= =?utf-8?B?aDluVkl4TncxSDZRSDZDR2F1aTF6QUNpQk5ZbkFzQWh1OEhRVGY2bHNvTTli?= =?utf-8?B?bFZHT2dqenJyejBBVmhCY2lhUWhoV2h2dENzYldiaTI4cHhFdmRpWmxwMGVw?= =?utf-8?B?OTVXRFdUU0pNUkRQU2Rra2NzM3RDZ3NMQXVKcXprcE9SV01pZVlLeUJWSmFp?= =?utf-8?B?blN6NUNndEhWdm9CclI1WURPbkNobTh2QUczajRXTXFQNWZJRjVJejFZVmVM?= =?utf-8?B?QS9sV015K0hQcEVreTBodzVtYkpKVTJQWStSQ0ZNYjZUMzB2dFNKRGx3OUd5?= =?utf-8?B?aGZWUmRkanFCWUFhZ0xBZ0VjbnpaVE54WGxKVDd2MFIrL0ZUZmJtOHpIZEJ6?= =?utf-8?B?WU8yeGpVaDZjTlRhdzJEaG15ajZaMW5lK0VnSkl4Wk55bzhrdmdIalFaZTJP?= =?utf-8?B?SlRPSDkyWlpNOFRhY0NVWHVSNFAxZ0tyc2c3M21vTzZFWS9tUy84NzdBZS9H?= =?utf-8?B?MHBJUmlhR2szM1ZTUnFXSTB2RHZDOWZvTnN4dGZqM1F0Ry9tUlo2cG9XWVZR?= =?utf-8?B?c3BhMHQ3WDZhVVBJbmtCdGk5MFRVVzlGSk5wTEUrOWtDTTJhU3oyVktKUWUr?= =?utf-8?B?WTJuVmQ2LzBITmpTa3dRZi9vdENZRnhFa0N3M1R4U0s5bjVvWnBTZUVnOG12?= =?utf-8?B?U2p1YXZKSDlJTzlpM1BjSUU3L1NHcGNyOGdyUWNmc1R6b1h3ZDExWktXb0Yx?= =?utf-8?B?QUUzOENIV3pIQzU1b0FmQmtRYm9uRDladnRIVDNmZGJuZk9VcWNjZlF2ZGxG?= =?utf-8?B?YXJtSFFyalh0VDdWU3dLTGVSRHIxMG1sTktkb2pkTlRXY01UWCt5azNyWnBl?= =?utf-8?B?eWJYZ1VsUVpFUzloYy9uVGNrRVhLcWNHS0NCZ1VTSldyVVZER2UyNmhDSFRq?= =?utf-8?B?ZGRFOWdCejB1eGJzL2lzRWxRT2YvV0pqRGROdGExTC83VVN0YWFlOVRJdXow?= =?utf-8?B?b2FUdE5sRmI0aWJNdmtqenZuQk5RMFNWUzdBOGwyL0R0YXFmc0ovdlA4T3Zs?= =?utf-8?B?dU5kbWg0UWE3b3hIa2p3SXZZTDFwYkZmRkt6bVRhc2pMT056SDdoNWQ1SDRy?= =?utf-8?B?OXRxQUtQckJmajVFcjREc1ZXcmxFcjd1aW10bExTRHhiTFNIdnU4RXFWcW5L?= =?utf-8?B?LzFkNUtPdHluRDZTcytjOEhGME5paTZERjNKZ0ptc1BVV0RtWHJFVGhuRC9J?= =?utf-8?B?YzlwdFgybEFHcmwxVFkyeDVER1g4OWVXTU1iVDhDTEZJNFFiRHRQYWNnQmdY?= =?utf-8?B?Qi9CNkpxWkFweUZJSEpJZEQ5bmxHV25EcHp0aUJPYzQrd2ZOcGlHRHRSUTBn?= =?utf-8?B?aGVNbHpWK1pKT2d3c1AvSnNFeVorUmRTVnF1bVNCTEhtbU5YWWFhTGsyVmZ6?= =?utf-8?Q?eFDv+SUGsRgzCuIItIZnzKmhi?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d655b6a-0a19-4daa-a901-08da9012b911 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 14:18:51.4631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I474bHb5Yl73RNIS4m/C6qPjQj0Yzd5czyCKjspSZo1gS12fs1dabIU+4ygh9Q0KEm8GsSOwD12ANiSSJmRkzXKSYpuzFYnmctHAHarhZL0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5289 T24gMzAvMDgvMjAyMiAyMToyNywgSmVubmlmZXIgSGVyYmVydCB3cm90ZToNCj4gVGhpcyBwYXRj aCBpbnRyb2R1Y2VzIGFuIG9wdGlvbmFsIFRQTSAyIGludGVyZmFjZSBkZWZpbml0aW9uIHRvIHRo ZSBBQ1BJIHRhYmxlLA0KPiB3aGljaCBpcyB0byBiZSB1c2VkIGFzIHBhcnQgb2YgYSB2VFBNIDIg aW1wbGVtZW50YXRpb24uDQo+IFRvIGVuYWJsZSB0aGUgbmV3IGludGVyZmFjZSAtIEkgaGF2ZSBt YWRlIHRoZSBUUE0gaW50ZXJmYWNlIHZlcnNpb24NCj4gY29uZmlndXJhYmxlIGluIHRoZSBhY3Bp X2NvbmZpZywgd2l0aCB0aGUgZGVmYXVsdCBiZWluZyB0aGUgZXhpc3RpbmcgMS4yLihUQ1BBKQ0K PiBJIGhhdmUgYWxzbyBhZGRlZCB0byBodm1sb2FkZXIgYW4gb3B0aW9uIHRvIHV0aWxpc2UgdGhp cyBuZXcgY29uZmlnLCB3aGljaCBjYW4NCj4gYmUgdHJpZ2dlcmVkIGJ5IHNldHRpbmcgdGhlIHBs YXRmb3JtL3RwbV92ZXJpb24geGVuc3RvcmUga2V5Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKZW5u aWZlciBIZXJiZXJ0IDxqZW5uaWZlci5oZXJiZXJ0QGNpdHJpeC5jb20+DQoNCldlJ3JlIHBhc3Qg dGhlIDQuMTcgZmVhdHVyZSBzdWJtaXNzaW9uIGRlYWRsaW5lLsKgIENDJ2luZyBIZW5yeS4NCg0K SGVucnk6IFRoaXMgaXMgYSBmYWlybHkgc2ltcGxlIGNoYW5nZSBhbmQgYSBjcml0aWNhbCBidWls ZGluZyBibG9jayBmb3INCmdldHRpbmcgV2luZG93cyAxMSBzdXBwb3J0IG9uIFhlbi7CoCBHaXZl biB0aGF0IGZlYXR1cmUgZnJlZXplIHdhcw0Kc2xpcHBlZCBzZXZlcmFsIHdlZWtzIGZvciBvdGhl ciByZWFzb25zLCB0aGlzIHNob3VsZCBiZSBjb25zaWRlcmVkIGZvcg0KaW5jbHVzaW9uIHRvby4N Cg0KSmVubnk6IFRoaXMgbmVlZHMgc3BsaXR0aW5nIHVwIGludG8gYXQgbGVhc3QgMiBwYXRjaGVz LsKgIFBhdGNoIDEgc2hvdWxkDQpiZSB0aGUgcmVuYW1lIG9mIEFDUElfSEFTX3tUQ1BBID0+IFRQ TX0gYW5kIGludHJvZHVjdGlvbiBvZiB0cG1fdmVyc2lvbg0KKGluYyBzdWl0YWJsZSByZWFycmFu Z2luZykuwqAgUGF0Y2ggMiBzaG91bGQgYmUgdGhlIGludHJvZHVjdGlvbiBvZiBUUE0yLg0KDQo+ IGRpZmYgLS1naXQgYS90b29scy9maXJtd2FyZS9odm1sb2FkZXIvdXRpbC5jIGIvdG9vbHMvZmly bXdhcmUvaHZtbG9hZGVyL3V0aWwuYw0KPiBpbmRleCA1ODFiMzVlNWNmLi5lM2FmMzI1ODFiIDEw MDY0NA0KPiAtLS0gYS90b29scy9maXJtd2FyZS9odm1sb2FkZXIvdXRpbC5jDQo+ICsrKyBiL3Rv b2xzL2Zpcm13YXJlL2h2bWxvYWRlci91dGlsLmMNCj4gQEAgLTk5NCwxMyArOTk0LDI0IEBAIHZv aWQgaHZtbG9hZGVyX2FjcGlfYnVpbGRfdGFibGVzKHN0cnVjdCBhY3BpX2NvbmZpZyAqY29uZmln LA0KPiAgICAgIGlmICggIXN0cm5jbXAoeGVuc3RvcmVfcmVhZCgicGxhdGZvcm0vYWNwaV9sYXB0 b3Bfc2xhdGUiLCAiMCIpLCAiMSIsIDEpICApDQo+ICAgICAgICAgIGNvbmZpZy0+dGFibGVfZmxh Z3MgfD0gQUNQSV9IQVNfU1NEVF9MQVBUT1BfU0xBVEU7DQo+ICANCj4gLSAgICBjb25maWctPnRh YmxlX2ZsYWdzIHw9IChBQ1BJX0hBU19UQ1BBIHwgQUNQSV9IQVNfSU9BUElDIHwNCj4gKyAgICBj b25maWctPnRhYmxlX2ZsYWdzIHw9IChBQ1BJX0hBU19UUE0gfCBBQ1BJX0hBU19JT0FQSUMgfA0K PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEFDUElfSEFTX1dBRVQgfCBBQ1BJX0hBU19Q TVRJTUVSIHwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBQ1BJX0hBU19CVVRUT05T IHwgQUNQSV9IQVNfVkdBIHwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBQ1BJX0hB U184MDQyIHwgQUNQSV9IQVNfQ01PU19SVEMpOw0KPiAgICAgIGNvbmZpZy0+YWNwaV9yZXZpc2lv biA9IDQ7DQo+ICANCj4gLSAgICBjb25maWctPnRpc19oZHIgPSAodWludDE2X3QgKilBQ1BJX1RJ U19IRFJfQUREUkVTUzsNCj4gKyAgICBpZiAoICFzdHJuY21wKHhlbnN0b3JlX3JlYWQoInBsYXRm b3JtL3RwbV92ZXJzaW9uIiwgIjAiKSwgIjIiLCAxKSAgKSB7DQoNCkJyYWNlIG9uIG5ldyBsaW5l Lg0KDQpBbHNvLCB0aGlzIGlzIGEgbmV3IGtleSwgc28gbmVlZHMgYW4gZW50cnkgaW4NCmRvY3Mv bWlzYy94ZW5zdG9yZS1wYXRocy5wYW5kb2MNCg0KPiArDQo+ICsgICAgICAgIGNvbmZpZy0+dHBt X3ZlcnNpb24gPSAyOw0KPiArICAgICAgICBjb25maWctPmNyYl9oZHIgPSAodWludDE2X3QgKilB Q1BJX0NSQl9IRFJfQUREUkVTUzsNCj4gKyAgICAgICAgY29uZmlnLT50aXNfaGRyID0gTlVMTDsN Cj4gKyAgICB9DQo+ICsgICAgZWxzZQ0KPiArICAgIHsNCj4gKyAgICAgICAgY29uZmlnLT50cG1f dmVyc2lvbiA9IDE7DQo+ICsgICAgICAgIGNvbmZpZy0+Y3JiX2hkciA9IE5VTEw7DQo+ICsgICAg ICAgIGNvbmZpZy0+dGlzX2hkciA9ICh1aW50MTZfdCAqKUFDUElfVElTX0hEUl9BRERSRVNTOw0K PiArICAgIH0NCg0KVGhpcyBsb2dpYyBtYWtlcyBhbnkgdmFsdWUsIGluY2x1ZGluZyAiMCIgbWVh biAidXNlIFRQTSAxIiwgd2hpY2ggaXNuJ3QNCnRlcnJpYmx5IGdvb2QuwqAgRnVydGhlcm1vcmUs IEFDUElfSEFTX1RQTSBkb2Vzbid0IG1lYW4gImhhcyBhIFRQTSIsIGl0DQptZWFucyAicHJvYmUg Zm9yIGEgVFBNIi4NCg0KU28gd2hhdCB0aGlzIGFjdHVhbGx5IHdhbnRzIHRvIGJlIGlzIHNvbWV0 aGluZyBtb3JlIGxpa2UgdGhpczoNCg0KcyA9IHhlbnN0b3JlX3JlYWQoInBsYXRmb3JtL3RwbS12 ZXJzaW9uIik7DQpjb25maWctPnRwbV92ZXJzaW9uID0gc3Ryb2xsKHMsIE5VTEwsIDApOw0KDQpz d2l0Y2ggKCBjb25maWctPnRwbV92ZXJzaW9uICkNCnsNCmNhc2UgMToNCsKgwqDCoCBjb25maWct PnRhYmxlX2ZsYWdzIHw9IEFDUElfSEFTX1RQTTsNCsKgwqDCoCBjb25maWctPnRpc19oZHIgPSAo dWludDE2X3QgKilBQ1BJX1RJU19IRFJfQUREUkVTUzsNCsKgwqDCoCBicmVhazsNCn0NCg0KWW91 IGRvbid0IG5lZWQgdG8gc2V0IHRoZSBOVUxMIHZhbHVlcyBiZWNhdXNlIGNvbmZpZyBpcyBzdWl0 YWJseSB6ZXJvZWQNCnRvIGJlZ2luIHdpdGgsIGFuZCBwYXRjaCAyIHdpbGwganVzdCBhZGQNCg0K Y2FzZSAyOg0KwqDCoMKgIGNvbmZpZy0+dGFibGVfZmxhZ3MgfD0gQUNQSV9IQVNfVFBNOw0KwqDC oMKgIGNvbmZpZy0+Y3JiX2hkciA9ICh1aW50MTZfdCAqKUFDUElfQ1JCX0hEUl9BRERSRVNTOw0K wqDCoMKgIGJyZWFrOw0KDQo+IGRpZmYgLS1naXQgYS90b29scy9saWJhY3BpL2FjcGkyXzAuaCBi L3Rvb2xzL2xpYmFjcGkvYWNwaTJfMC5oDQo+IGluZGV4IDI2MTliYTMyZGIuLjU3NTRkYWE5ODUg MTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL2xpYmFjcGkvYWNwaTJfMC5oDQo+ICsrKyBiL3Rvb2xzL2xp YmFjcGkvYWNwaTJfMC5oDQo+IEBAIC0xMjEsNiArMTIxLDI4IEBAIHN0cnVjdCBhY3BpXzIwX3Rj cGEgew0KPiAgfTsNCj4gICNkZWZpbmUgQUNQSV8yXzBfVENQQV9MQU1MX1NJWkUgKDY0KjEwMjQp DQo+ICANCj4gKy8qDQo+ICsgKiBUUE0yDQo+ICsgKi8NCj4gK3N0cnVjdCBBY3BpMjBUUE0yIHsN Cg0KYWNwaV8yMF90cG0yLCBjb25zaXN0ZW50IHdpdGggZXZlcnl0aGluZyBlbHNlIGhlcmUuDQoN Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYmFjcGkvYnVpbGQuYyBiL3Rvb2xzL2xpYmFjcGkvYnVp bGQuYw0KPiBpbmRleCBmZTJkYjY2YTYyLi40NzhjYmVjNWRkIDEwMDY0NA0KPiAtLS0gYS90b29s cy9saWJhY3BpL2J1aWxkLmMNCj4gKysrIGIvdG9vbHMvbGliYWNwaS9idWlsZC5jDQo+IEBAIC00 MDksMzggKzQxMiw4NiBAQCBzdGF0aWMgaW50IGNvbnN0cnVjdF9zZWNvbmRhcnlfdGFibGVzKHN0 cnVjdCBhY3BpX2N0eHQgKmN0eHQsDQo+ICAgICAgICAgIG1lbWNweShzc2R0LCBzc2R0X2xhcHRv cF9zbGF0ZSwgc2l6ZW9mKHNzZHRfbGFwdG9wX3NsYXRlKSk7DQo+ICAgICAgICAgIHRhYmxlX3B0 cnNbbnJfdGFibGVzKytdID0gY3R4dC0+bWVtX29wcy52MnAoY3R4dCwgc3NkdCk7DQo+ICAgICAg fQ0KPiAtDQo+IC0gICAgLyogVFBNIFRDUEEgYW5kIFNTRFQuICovDQo+IC0gICAgaWYgKCAoY29u ZmlnLT50YWJsZV9mbGFncyAmIEFDUElfSEFTX1RDUEEpICYmDQo+IC0gICAgICAgICAoY29uZmln LT50aXNfaGRyWzBdICE9IDAgJiYgY29uZmlnLT50aXNfaGRyWzBdICE9IDB4ZmZmZikgJiYNCj4g LSAgICAgICAgIChjb25maWctPnRpc19oZHJbMV0gIT0gMCAmJiBjb25maWctPnRpc19oZHJbMV0g IT0gMHhmZmZmKSApDQo+ICsgICAgLyogVFBNIGFuZCBTU0RULiAqLw0KPiArICAgIGlmIChjb25m aWctPnRhYmxlX2ZsYWdzICYgQUNQSV9IQVNfVFBNKQ0KPiAgICAgIHsNCg0KU3R5bGUsIGhlcmUg YW5kIGxvd2VyIGRvd24uDQoNClRoZSBlbmQgcmVzdWx0IHdhbnRzIHRvIGxvb2sgc29tZXRoaW5n IGxpa2U6DQoNCmlmICggY29uZmlnLT50YWJsZV9mbGFncyAmIEFDUElfSEFTX1RQTSApDQp7DQrC oMKgwqAgc3dpdGNoICggY29uZmlnLT50cG1fdmVyc2lvbiApDQrCoMKgwqAgew0KwqDCoMKgIGNh c2UgMToNCsKgwqDCoMKgwqDCoMKgIGlmICggIWNvbmZpZy0+dGlzX2hkciB8fCBjb25maWctPnRp c19oZHJbMF0gPT0gMCB8fA0KY29uZmlnLT50aXNfaGRyWzBdID09IDB4ZmZmZiApDQrCoMKgwqDC oMKgwqDCoCDCoMKgwqAgYnJlYWs7DQoNCsKgwqDCoMKgwqDCoMKgIHNzZHQgPQ0KwqDCoMKgwqDC oMKgwqAgLi4uDQrCoMKgwqDCoMKgwqDCoCBicmVhazsNCsKgwqDCoCB9DQp9DQoNCkluIHBhcnRp Y3VsYXIsIEkgZG9uJ3QgdGhpbmsgdGhlIHByaW50ZigpJ3MgYXJlIHBhcnRpY3VsYXJseSB1c2Vm dWwgZm9yDQpiYWQgaW50ZXJuYWwgaW5wdXQgaW50byBhIHByb2JlIGZ1bmN0aW9uLg0KDQo+IC0g ICAgICAgIHNzZHQgPSBjdHh0LT5tZW1fb3BzLmFsbG9jKGN0eHQsIHNpemVvZihzc2R0X3RwbSks IDE2KTsNCj4gLSAgICAgICAgaWYgKCFzc2R0KSByZXR1cm4gLTE7DQo+IC0gICAgICAgIG1lbWNw eShzc2R0LCBzc2R0X3RwbSwgc2l6ZW9mKHNzZHRfdHBtKSk7DQo+IC0gICAgICAgIHRhYmxlX3B0 cnNbbnJfdGFibGVzKytdID0gY3R4dC0+bWVtX29wcy52MnAoY3R4dCwgc3NkdCk7DQo+IC0NCj4g LSAgICAgICAgdGNwYSA9IGN0eHQtPm1lbV9vcHMuYWxsb2MoY3R4dCwgc2l6ZW9mKHN0cnVjdCBh Y3BpXzIwX3RjcGEpLCAxNik7DQo+IC0gICAgICAgIGlmICghdGNwYSkgcmV0dXJuIC0xOw0KPiAt ICAgICAgICBtZW1zZXQodGNwYSwgMCwgc2l6ZW9mKCp0Y3BhKSk7DQo+IC0gICAgICAgIHRhYmxl X3B0cnNbbnJfdGFibGVzKytdID0gY3R4dC0+bWVtX29wcy52MnAoY3R4dCwgdGNwYSk7DQo+IC0N Cj4gLSAgICAgICAgdGNwYS0+aGVhZGVyLnNpZ25hdHVyZSA9IEFDUElfMl8wX1RDUEFfU0lHTkFU VVJFOw0KPiAtICAgICAgICB0Y3BhLT5oZWFkZXIubGVuZ3RoICAgID0gc2l6ZW9mKCp0Y3BhKTsN Cj4gLSAgICAgICAgdGNwYS0+aGVhZGVyLnJldmlzaW9uICA9IEFDUElfMl8wX1RDUEFfUkVWSVNJ T047DQo+IC0gICAgICAgIGZpeGVkX3N0cmNweSh0Y3BhLT5oZWFkZXIub2VtX2lkLCBBQ1BJX09F TV9JRCk7DQo+IC0gICAgICAgIGZpeGVkX3N0cmNweSh0Y3BhLT5oZWFkZXIub2VtX3RhYmxlX2lk LCBBQ1BJX09FTV9UQUJMRV9JRCk7DQo+IC0gICAgICAgIHRjcGEtPmhlYWRlci5vZW1fcmV2aXNp b24gPSBBQ1BJX09FTV9SRVZJU0lPTjsNCj4gLSAgICAgICAgdGNwYS0+aGVhZGVyLmNyZWF0b3Jf aWQgICA9IEFDUElfQ1JFQVRPUl9JRDsNCj4gLSAgICAgICAgdGNwYS0+aGVhZGVyLmNyZWF0b3Jf cmV2aXNpb24gPSBBQ1BJX0NSRUFUT1JfUkVWSVNJT047DQo+IC0gICAgICAgIGlmICggKGxhc2Eg PSBjdHh0LT5tZW1fb3BzLmFsbG9jKGN0eHQsIEFDUElfMl8wX1RDUEFfTEFNTF9TSVpFLCAxNikp ICE9IE5VTEwgKQ0KPiArICAgICAgICBpZiAoY29uZmlnLT4gdHBtX3ZlcnNpb24gPT0gMikNCj4g KyAgICAgICAgew0KPiArICAgICAgICAgICAgaWYgKCAoY29uZmlnLT5jcmJfaGRyKSAmJg0KPiAr ICAgICAgICAgICAgICAgICAgIChjb25maWctPmNyYl9oZHJbMF0gIT0gMCAmJiBjb25maWctPmNy Yl9oZHJbMF0gIT0gMHhmZmZmKSkNCj4gKyAgICAgICAgICAgIHsNCj4gKyAgICAgICAgICAgICAg ICBzc2R0ID0gY3R4dC0+bWVtX29wcy5hbGxvYyhjdHh0LCBzaXplb2Yoc3NkdF90cG0yKSwgMTYp Ow0KPiArICAgICAgICAgICAgICAgIGlmICghc3NkdCkgcmV0dXJuIC0xOw0KPiArICAgICAgICAg ICAgICAgIG1lbWNweShzc2R0LCBzc2R0X3RwbTIsIHNpemVvZihzc2R0X3RwbTIpKTsNCj4gKyAg ICAgICAgICAgICAgICB0YWJsZV9wdHJzW25yX3RhYmxlcysrXSA9IGN0eHQtPm1lbV9vcHMudjJw KGN0eHQsIHNzZHQpOw0KPiArDQo+ICsgICAgICAgICAgICAgICAgdHBtMiA9IGN0eHQtPm1lbV9v cHMuYWxsb2MoY3R4dCwgc2l6ZW9mKHN0cnVjdCBBY3BpMjBUUE0yKSwgMTYpOw0KPiArICAgICAg ICAgICAgICAgIGlmICghdHBtMikgcmV0dXJuIC0xOw0KPiArICAgICAgICAgICAgICAgIG1lbXNl dCh0cG0yLCAwLCBzaXplb2YoKnRwbTIpKTsNCj4gKyAgICAgICAgICAgICAgICB0YWJsZV9wdHJz W25yX3RhYmxlcysrXSA9IGN0eHQtPm1lbV9vcHMudjJwKGN0eHQsIHRwbTIpOw0KPiArDQo+ICsg ICAgICAgICAgICAgICAgdHBtMi0+aGVhZGVyLnNpZ25hdHVyZSA9IEFDUElfMl8wX1RQTTJfU0lH TkFUVVJFOw0KPiArICAgICAgICAgICAgICAgIHRwbTItPmhlYWRlci5sZW5ndGggICAgPSBzaXpl b2YoKnRwbTIpOw0KPiArICAgICAgICAgICAgICAgIHRwbTItPmhlYWRlci5yZXZpc2lvbiAgPSBB Q1BJXzJfMF9UUE0yX1JFVklTSU9OOw0KPiArICAgICAgICAgICAgICAgIGZpeGVkX3N0cmNweSh0 cG0yLT5oZWFkZXIub2VtX2lkLCBBQ1BJX09FTV9JRCk7DQo+ICsgICAgICAgICAgICAgICAgZml4 ZWRfc3RyY3B5KHRwbTItPmhlYWRlci5vZW1fdGFibGVfaWQsIEFDUElfT0VNX1RBQkxFX0lEKTsN Cj4gKyAgICAgICAgICAgICAgICB0cG0yLT5oZWFkZXIub2VtX3JldmlzaW9uID0gQUNQSV9PRU1f UkVWSVNJT047DQo+ICsgICAgICAgICAgICAgICAgdHBtMi0+aGVhZGVyLmNyZWF0b3JfaWQgICA9 IEFDUElfQ1JFQVRPUl9JRDsNCj4gKyAgICAgICAgICAgICAgICB0cG0yLT5oZWFkZXIuY3JlYXRv cl9yZXZpc2lvbiA9IEFDUElfQ1JFQVRPUl9SRVZJU0lPTjsNCj4gKyAgICAgICAgICAgICAgICB0 cG0yLT5wbGF0Zm9ybV9jbGFzcyA9IFRQTTJfQUNQSV9DTEFTU19DTElFTlQ7DQo+ICsgICAgICAg ICAgICAgICAgdHBtMi0+Y29udHJvbF9hcmVhX2FkZHJlc3MgPSBUUE1fQ1JCX0FERFJfQ1RSTDsN Cj4gKyAgICAgICAgICAgICAgICB0cG0yLT5zdGFydF9tZXRob2QgPSBUUE0yX1NUQVJUX01FVEhP RF9DUkI7DQo+ICsgICAgICAgICAgICAgICAgdHBtMi0+bG9nX2FyZWFfbWluaW11bV9sZW5ndGgg PSBUUE1fTE9HX0FSRUFfTUlOSU1VTV9TSVpFOw0KPiArDQo+ICsgICAgICAgICAgICAgICAgbG9n ID0gY3R4dC0+bWVtX29wcy5hbGxvYyhjdHh0LCBUUE1fTE9HX1NJWkUsIDQwOTYpOw0KPiArICAg ICAgICAgICAgICAgIGlmICghbG9nKSByZXR1cm4gLTE7DQoNClRoaXMgaXMgYnVnZ3kuDQoNCkFQ Q0kgdGFibGUgbWVtb3J5IGlzIGNvdmVyZWQgYnkgYW4gRTgyMF9BQ1BJIHJhbmdlIChzcGVjaWZp Y2FsbHksIGlzDQplbGlnaWJsZSB0byBiZSB1c2VkIGFzIGdlbmVyYWwgUkFNIGFmdGVyIGJvb3Qp LCB3aGlsZSB0aGUgVFBNIGxvZyBzaG91bGQNCmJlIGluIGFuIEU4MjBfUkVTRVJWRUQgcmVnaW9u Lg0KDQpUbyBzdGFydCB3aXRoLCBpdCdzIHByb2JhYmx5IGZpbmUgdG8gaGFyZGNvZGUgc29tZXRo aW5nIGluIHRoZSAyTSB3aW5kb3cNCmF0IDB4ZmVkNDAwMDAgdG8gYmUgZml4ZWQgbG9jYXRpb24g Zm9yIHRoZSBsb2cuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400419.642176 (Exim 4.92) (envelope-from ) id 1oVgSu-0005HD-7V; Tue, 06 Sep 2022 21:50:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400419.642176; Tue, 06 Sep 2022 21:50:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSt-0005D4-T2; Tue, 06 Sep 2022 21:50:39 +0000 Received: by outflank-mailman (input) for mailman id 400419; Tue, 06 Sep 2022 21:50:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIc-0000Cs-JM for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:40:02 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0169a57-2dc6-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:31:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7638.eurprd04.prod.outlook.com (2603:10a6:20b:291::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Tue, 6 Sep 2022 09:31:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 09:31:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0169a57-2dc6-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwB539alk/EfTCCkzB6LA94ppQm+cACmKw37kuGP52T1aMnthqppJl1RBjWZcP4NaaThZw2/gCqmAHVRip4xM6DGUD2dgcro8jFf6lAoNucJ8EALOt1MScoMq0tZSKMnwZ/kotO4QVcTEpAC0c6TzdviN0/Ob3Ahi2UOOsw6pLvDd7gNqqmbBHDUQwaOcU3Ag5/+hpVWD8jcdwLOaTR/NpvSnXAyR4QSDr/59fbexPpOQogFBO7X7clbn8bi+Rr5oIYxcZaE1QKvuU4BYuPYfFMZwYWT4qrwxG3VmZc8LqHzlSzo8+GmQ42z0dD7UVPnrFpg8WuNUroYmuqXx4pMdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8LuHYQ+oWu7WAhdqIncHHg95MqTmJvPsU20Mr/RymWM=; b=iFXmpzup/lo5JJ7Qz2aSMkbPP4EfTyqGtNoOxVqySPjAAFvhE6roWtDtn7LRP/yM+kWyFKFkVdspgaOBbr67mFtX2E0RZD0qZVPDA0kvMN7jph626NKoJJrBD2O8QvT5GWCOMpucPd8eZB1uC6Ch9AubL8QH4zQJVtC2ngIs26NsOPOXsS28uKw5pLpLAJcVXRlvNx84rx6dKbmoaqpYfEytD7OgKNG8bZuiM4OZPckQi1pCB4+elSNGWyT9TcbywpQFGDLZD3unaqU7q0I3QXT6Ot7ipl97F7FNRJc6TG9/Z4DRO8yUaGxyLgHVJn4jjrOIGu69vSP/Du+X+JQ6Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8LuHYQ+oWu7WAhdqIncHHg95MqTmJvPsU20Mr/RymWM=; b=4eGsLuOzH+3+mYfI8jp/Tp8P7wXZBkZvaNoGqhj1VdzBVuRO+ovgx6gUVl1cGFddSoxujkXWFlXHJQyoxE6kWztkSG/RT81xhjjpTeZsDPeUNwxEnewuaYlJM+7Eve2sF6gm43hRXM8qgdepZCQQ4ETFWmGJpMR4GJrCdqlE3xe83lPk/9dMOVuMfEwA9aoakPX8jiHd0D/0bucTwycEWBJaB2jamhcqyti3PYMZQlqzMBOOudrn1t5CvJXzNHeEeCA7jrDv1fkKdENtOY8APUqsxMtNg0lFM6QlD/Qmqj4cZKo5jp2FB7EjXZ8LWn1qnqrNrlUKa1bsep7oZD395A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 6 Sep 2022 11:32:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 0/3] xen/sched: fix cpu hotplug Content-Language: en-US To: Andrew Cooper Cc: Henry.Wang@arm.com, George Dunlap , Dario Faggioli , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Juergen Gross References: <20220905070005.16788-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220905070005.16788-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3dcedee0-268a-4058-b2df-08da8feaa5d3 X-MS-TrafficTypeDiagnostic: AS8PR04MB7638:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z5gVM+WaVjLwj+I/kDLtmWhgnKjtyh5pnyW5HgDF4tKh17lXrlr4gGZ8uSP/Fwu/t5T+hvIlxXZRMN9lgR604crh9VDPieYT6eP+wMFK75suRnHxOoOLkIdpOiGDVTlwvrqSM7xO5v7AuPIuEEImww/YdKuVUIJPt8n4JM0DVkj8gCesO084OvxNJbenjXJHH9/PHzXt/CU3PONtr7uHQamxAfscVxE2Lz6isgMaNGMYey89ipSeRXVZyeeOtaVNOdTCx1kcxzNE4a1v/VlIR63sehOgGL3s5dl/R/w8+mD2MQs6eHCmPv1I5OAGlg6iQv8NkVDAaW16e080+0f3wPS8UW7lsX6dQWnRSswork/CGa0aMnj9kQmGEokv7ga5zDRKS8BhgxLpI31SENCCu7qUvmVb6yEHmtdL9viaWm/ZrVYgk/pQkelxEZXSHV/Yw3mzWzcE91mfgVcj2RmZWE3r0g0AKQdLbfkk9jd3dtoUhGbWzEbxUi6xQ8Is6l3TJo/Bg6azMLVEbyi5qdeuJpHJfbYRKkTbQSujiIno3wWgV52zJnD7rGFvuZi9oFuQeWMgC1mce0SBuzGvRY8yveCbT8bfSDAxZRf8Mek4JhB22OAiftyWwf+nRIPlM11PwCA7nnVmeWL2ByaeE4cWzvEpswNIsWYwWBdaD6BI24mRArd11CGMa4sCg2wLiPG+7sNzPDJDedywfgpAa/U96A7A8C7L/o1xpOoS+pYKJkiIC7RSFfVqoETcssTscXIl2ZGaM/mk/sJGKGZuw89Wcr2QqyMkk93y4sZLPu4XTR0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(136003)(39860400002)(346002)(366004)(6486002)(2616005)(26005)(186003)(31686004)(6512007)(53546011)(36756003)(2906002)(38100700002)(6506007)(4326008)(107886003)(6666004)(8676002)(86362001)(5660300002)(66556008)(83380400001)(316002)(66946007)(31696002)(41300700001)(478600001)(66476007)(6916009)(8936002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0RzMDVuam1iTk9iQWJFQ0tvY0FsNGNPZEt0SUlrMEVxWW8rZmNxY3h6eTBp?= =?utf-8?B?Z2EwNFdpYlNza2lFNGxZWENNL21hdGw5U2tSRWFZVk5LR0l1aHpYcGxIUUhw?= =?utf-8?B?dE1TOCtwOXNzRGc3SFgzZmh3NmxibVZpS0paUi9QQ3RzWVNSZ3VZZDlNTGpw?= =?utf-8?B?YVl1djQxS09iVlB5L2N0aXdFQnVNajZKcmFpblN5Sktod2NXRjVCSjEvV1Zq?= =?utf-8?B?Q2x0dkZGeTJlQ2tXL1BRaE4yK0pJNDNaSVROeEtMWVZybGp5K200NHNxcHdv?= =?utf-8?B?czZJZHY0RUR6ZkpPaFZwei9yL3ZsRnpBQzRwSEhkYlA0THlLZnQwdnJ2aUlY?= =?utf-8?B?UytWdHNqZGoxM0hkbnZ5UUFnd3JmV3RQVTVRWjdJd3padUl2K0hIVXk0RTg3?= =?utf-8?B?NGdDc1pZd1I4WlhGSDVYS0t6clpsTk93QnJpekNBSlF1RWlLcDRhMnVieTE3?= =?utf-8?B?WWhDS0JYTWsyNndhc1FnR3lVSVF4bG92QStMcDlZWkV1ZUdVQ3AydFBzK2pV?= =?utf-8?B?T0VZd0lJUEV6SEdNZXRneEhwMDdzcllsMXFkK0ZzbTdxcXdic1R1bHpqa0NB?= =?utf-8?B?NmJ1V3R4Z2ZUekpCb205OWRRQmhXOHBhME4zUmRJTlBOZDd5Q2NHeHpLakRt?= =?utf-8?B?NVhHSGFCQ29yNkRuL2lIR0srdHY0VnNYd25SWWJuUG9NZGRVQ0F6dStIY3pZ?= =?utf-8?B?Y0NUdUpHSDY0cjBDZzBJdmNvQlIyZXhiV2hqUzJoMktXZFVsL0VLNjMxOVNl?= =?utf-8?B?NE5mZTk4NlI4K09KZGFwOVBac1BPNnN3TVVXVlZha2xwZFZqSDgzM1RTY0Nn?= =?utf-8?B?NmRYd1BFSW1lYTAvVjVQejUwcDJqaEYralRORTFBOENMRUFIMzdqNktjbE9k?= =?utf-8?B?RmhYM1c1bzdMbDFKOUFnTlNoUXljSXpjOE5DRGtTOC90UDZIdXJ3bXA5c0Ry?= =?utf-8?B?WkJuYjM5Tm9rTXZOeWsraXpiMlRvc3l0dmVMTmRSZDFmTkNxdTliL2xQd2d3?= =?utf-8?B?NzNzVGlTc3RkbEpmaVQyVFJEYUNuTVg1WkRDd1VjWWdZUWhTNXJuQ3NUWDBo?= =?utf-8?B?ZUQ5VDhSZitEUEFvTnA3QitMNGt0SmxtNTladEFsTndDMkpubktKSEgwdUxH?= =?utf-8?B?VHludGJzaUxxbEVlZTlsQUdxdDJtdzA1UWFKcXFoSWlzUjhQS3M1V2xlak93?= =?utf-8?B?Vk1XbmxzTnl3WFBGdXNSTmdpaFFjeUpCWTlnaThHVVhRd2EzRm5Gb0VTbWV5?= =?utf-8?B?bmUwRXZUT2c2U3pGUGJhRVlJeWN5cnBBTGQ2alphYWJVbWdIMzloNGFsdzll?= =?utf-8?B?NEVWdVZobk8wSkUvZlJNVjZ4Vzg2TjA2aENMR2xvWXJxZk40aW9IL2VCMy9C?= =?utf-8?B?U3BiTTM0ZUJGb1JpbkpRZktCTnMxM1dzOUdYY2RIbXYwbGU3YkZMRE51N05z?= =?utf-8?B?cFNyMmRBWWFkRU96YVpvaFVoMjVXK3BDT1FvZUx1MW5MTG50YnJ3cWRPalZk?= =?utf-8?B?SlU5RC9YUkI3ZGhLbVRzK1U0SlJHTEd3eGRkL0t6MVZWODRJcmFBQkpQbUxt?= =?utf-8?B?d21xVWZ0OWh3WHVNTzloRzMyR0xaSGxQcUdFRlVhVU5NbzdSOVNvQTZsZEds?= =?utf-8?B?akJLZlVOblJHY01MQkNtU1ZUN0Q5NWI2ckc4bEpacElZRjB4NVY2TEtYSGlt?= =?utf-8?B?NTY3OFh6cEkyYVVIcWFVaVZaaUhrRzJBVVorZzJidVFCbExTVUU4MGMwRDNj?= =?utf-8?B?MXBBdkFCdHJpdTMzcWQyVGhhZXFZeXo3NTdSa3ZPd0kyeXIvdFh3QWNoR01H?= =?utf-8?B?MUNUMzdjb0xqNm04NTkzMEJ2UVk0OUZReDhCREZGMjJkQWU4L01hbHlXalEv?= =?utf-8?B?Rm1XK0czcVFKdjVjMUNWeHpnKzlPbGIwdXJjQTNWU3I3MllJR3pCQTVEQ0hW?= =?utf-8?B?Nnd4SUVTNmF6STd1T1RsL0F1ODJiclhZNW9Zck9GR3ZVMUZJT0tvVU9RdS9v?= =?utf-8?B?MHgrL3hDZDFPOGl1NGF4SWNtVnBleW9zMll3YnJmcTJSeFJNZFNrWVdBWFAr?= =?utf-8?B?VUVBSFc0a3IveFBnZGE4c0ZkZmROaHZlNDlJa1pMaU9ubW5sd3poeWR6dWsv?= =?utf-8?Q?Q9np2CABDokIv42LOPqU3q0fB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dcedee0-268a-4058-b2df-08da8feaa5d3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:31:59.4986 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z3NSAxiqsN7szkOJfX3fvHiq5Mdj0YwDLj2HJyWrHMjvZFiJiezEKDn8Z/YWsPHD+S2VDxspjkuo6VBkbgWXkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7638 On 05.09.2022 09:00, Juergen Gross wrote: > A recent change in the hypervisor memory allocation framework led to > crashes when unplugging host cpus. > > This was due to the (correct) assertion that allocating and freeing > memory is allowed with enabled interrupts only. As the main cpu unplug > operation is done in stop-machine context, this assertion triggers in > debug builds. > > Correct that by pre-allocating all needed memory while interrupts are > still on, and free memory after interrupts are enabled again. > > Changes in V4: > - addressed comments > > Changes in V3: > - addressed all comments > > Changes in V2: > - addressed all comments > > Juergen Gross (3): > xen/sched: introduce cpupool_update_node_affinity() > xen/sched: carve out memory allocation and freeing from > schedule_cpu_rm() > xen/sched: fix cpu hotplug > > xen/common/sched/core.c | 214 ++++++++++++++++++++++++------------- > xen/common/sched/cpupool.c | 92 +++++++++++----- > xen/common/sched/private.h | 21 +++- > xen/include/xen/sched.h | 9 +- > 4 files changed, 236 insertions(+), 100 deletions(-) I notice you've committed this series, but I wonder why you did so without a common/sched/ maintainer's ack. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400420.642191 (Exim 4.92) (envelope-from ) id 1oVgSw-0005pf-E7; Tue, 06 Sep 2022 21:50:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400420.642191; Tue, 06 Sep 2022 21:50:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgSw-0005oP-49; Tue, 06 Sep 2022 21:50:42 +0000 Received: by outflank-mailman (input) for mailman id 400420; Tue, 06 Sep 2022 21:50:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIg-0000Cs-Jk for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:40:06 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d169255b-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:01:05 +0200 (CEST) Received: from mail-sn1anam02lp2049.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Sep 2022 06:01:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6090.namprd03.prod.outlook.com (2603:10b6:408:11b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 10:01:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 10:01:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d169255b-2dca-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662458466; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=YY/6obn/oZCyp1UymDaXYf+htUl6d+AT8k5qFf412T0=; b=FMG6aNNcZcepxbqoBKf+aQq+rrjtNrCCSHYXgg2fhTJTzUoY/8K8aDxq ifE/2EPNGfEE0uW8fi8/05vOVf4TNIYg9BTQ7iTqdwHnasAMRDquxyqMP RWfz76inz5l+WnD3/wtjBfwAk+kiMzdV1HpEhWD1HCnbc+Nt0S9EtH/le k=; X-IronPort-RemoteIP: 104.47.57.49 X-IronPort-MID: 82352064 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:n/0RGazVOzkECeXagU56t+fexyrEfRIJ4+MujC+fZmUNrF6WrkVUn GIWXGvSO/3eMWH1eosgYYXloU4PsZSEmNZnSQo5/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Usx5K2aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN0tCGo3AKc/5t9zLmNWt qVCcxEibUiM0rfeLLKTEoGAh+wFBeyzZsYknCglyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCSgNWEJwL6WjfNfD2z75Qp9yrXydvHSfcSHX559lUeEv GPWuW/+B3n2MfTPk2HYqCry2ocjmwvUBJM7RLSRy8d6p2Sr1EA9ViIGUwOC9KzRZkmWHog3x 1Yv0igkoLU29UerZsLgRBD+q3mB1jYQVt9RO+w89gCWy6DQ7hqZB24LVTpIYpots8pebTkjz FqAhd7qLT1prryOSHiZ+6uUrDW9IiwcJykJYipsZRAE5t7liIA1kBPUT9xnHbK1j9v6AjX5y XaBqy1Wr6Uei4sH2ru2+XjDgimwvd7ZQwgt/ALVU2m5qARja+aYi5eA7FHa6bNbKt+QSFCE5 CIAg5LGsLFICoyRniuQRulLBKuu+/uOLDzbhxhoAoUl8DOuvXWkeOi8/Q1DGaugCe5cEReBX aMZkVo5CEN7VJdyUZJKXg== IronPort-HdrOrdr: A9a23:7d7LNap4kYpiOcs5s6YD4zUaV5rUeYIsimQD101hICG9Ffbo7v xG/c566faaskd1ZJhNo7+90cq7MBDhHPxOkO0s1N6ZNWGM0gbFEGgF1+XfKlbbakrDH4BmtJ uIC5IOauEYdmIK6/rS0U2ACNAnz8CA8Ke0wcnj71oFd3ARV4hQqz5jDACVC0t3QxQDI6EYOt 6z2uprzgDQAkj+SKyAdwU4tiz41qD2vaOjXx8HGhJiwDWyrFqTmcbHLyQ= X-IronPort-AV: E=Sophos;i="5.93,293,1654574400"; d="scan'208";a="82352064" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RbNMt1NUVAIYSyZbOyeXvjSDBJkmo4uktvvsjiD2bxkocKrDf0Q0ehFduniCRMzeRU8oPHRqLLSBzNqJclB77MS0CiYJTwxN8vleI4bsk560w6TGOX/pUYcsh8CufdMf5GYVeZGEiXaKyggr6njKPz0b/m4cv7ekmoLWBD2OYEov4K2SYOJ0nk2GCeJhjGAPSXeJHvlVthGOJxiZRT7D7Ap+mgfm9kWUf/PT2F5U1FowML53wTmPiotoi+Jb/Z6tGSpoiX+kxXpnqvK/QD3wTOn3wz+E2F2suLB2PLzWAkwlC0B1zZkV+84avcDYr/edY0frSZH6oVGU6pIeK6lGCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YY/6obn/oZCyp1UymDaXYf+htUl6d+AT8k5qFf412T0=; b=Zo831SaqRQG/svZo2KUJ3CGRR5qUe5YumsyfcasHUhHYSsEFpb3o273bK81lyxscTcT5dFI7+QAwwZ9zD3uqQh6g4DdhCcjRKlM1LwMjv5c/BUgeM1OEo34tRYr/t/KpId3qLvZhkl1EVuUQ0zHRJDc/d6AIvFAmdyIYiwGoSl3iFFS+vHELjYYqLXQOmFlZOBQ7BPKcOQcci6QpN3D1haHqze7BeC9w6TzusCQ5AEtYjmFrE9ukA0G+mKQJdejMSsIEe0XRJu2dyDchQFaDxrmZSxZPworsBr4xCqe4WPW9umAKEy3nplMRE3/72OU1BnDuUQxeuVnquEY3X6WPhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YY/6obn/oZCyp1UymDaXYf+htUl6d+AT8k5qFf412T0=; b=SdRN3BiRjwyGxDAbCewjfNLoa3Q316pBojpHES2VW3pmA3UTt81rG2/0e915s34TjhnMuxsrxqXI1AuK2VkFuykOzBTcOuJydmCLN6TfWBwTKlroibYBulVO4v2t0CyD6mlFQGA2EZnpJ8KXu3mhTDLEd0jV1c94iaUbtWCxyXo= From: Andrew Cooper To: Jan Beulich , Demi Marie Obenour CC: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Simon Gaiser , Xen developer discussion Subject: Re: Setting constant-time mode CPU flag Thread-Topic: Setting constant-time mode CPU flag Thread-Index: AQHYvnB5EClBFIJhzEiMDRLhBKntOK3SL8OAgAACfIA= Date: Tue, 6 Sep 2022 10:01:00 +0000 Message-ID: <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> In-Reply-To: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9ab73aa-071b-48e5-330e-08da8feeb370 x-ms-traffictypediagnostic: BN9PR03MB6090:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HFB0oCGBHnhGzm319R4Ckzi+Td3DvEqLIovLyFFU/AVcCndORxh0ZuHQrfn9MKaEgvZR+oPQiQ8rFl287dO4Xt/JUwrwbboWvUj6tMgGmQqfbSo8DCiQbx8VOgwQoltvq/Eeq3GhVs8TZfVgsRbmRK/Bqk/IGpoaBFWtvphyhr5O3jfDCCcEMjj5gHIF1HvyLw1HYRyLRYyx/6g8jwMt5Bkm2UOd2KshchwJQ5WhLGQj6ugau2KDQV8M0v+RnR3u5eghkmvevVnblNMsuPL1Jtf5f8egqqT60Qor3gfKiLN2pzXbc+gjF0IiVqoi2XWCMK8fIGFfWZdYTI5NVgdiB8fRbDlSAMF2UNEgdZ44Zvw0ULNUHhnjhIly1Fl6EX2ok0Mc3NkmF8KpD89VFM1uOvXAQtJq6QiXTKSBHh0D/t66gKkyn3+eYVZoOrWXUp5DZ4hARLKqt06+A+W816z73LYV00/+8tgOKZ07fTTj4aeXRc8OnFxdgT2Z6OcatvvJgGyhasdl1+yxfXWF2k3WHiOIo3MhpuMuwFBHe9pC74mqppW/Q791647eJOSBZu8gM0JNVOS7RfynqpQcb2FRTctEva8LGlyPr4sHn03KDDc95GGPgDpDawcsqxV5AgOsDuz1gQ++8Zrsx6gwmC86286TNcIP3XdS4TICXyO056mqUW9EUe71jThOmAdbjWO2VdN+iWMSll1cSmJf/81DhMnsLfX3DOAS2DckNXew297fdPvceqKvxQ8Xxr9DaewAzWdVik7eetwls7AfqZap92FbLDLqC9zv6rrDyp0Ww5Q9BE5/BIBGPnhpfkTF2Q+NcOJ5+IMLhOpmFHOXV6RrEwJHOiRE1VM/HgsA5YQmjnw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(6512007)(26005)(2906002)(2616005)(8936002)(5660300002)(6506007)(41300700001)(53546011)(31696002)(86362001)(31686004)(71200400001)(966005)(478600001)(6486002)(186003)(36756003)(38070700005)(82960400001)(91956017)(54906003)(66476007)(4326008)(110136005)(64756008)(66556008)(66946007)(76116006)(316002)(8676002)(122000001)(66446008)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aE9BRjZUWUptMWxab0FQQ0VWYmFOMW9qZnNENTB0dDBQSGN2NWJ0eXE3WmdX?= =?utf-8?B?c3J1TngxNzFmSXNtU1ZJVGlaVXJicVRWTkhPTmk0Skp0VWRJTEJOSGlQeGJF?= =?utf-8?B?YkdsYXpQQ2k3Q3Z6U1hqK21uSlkxOG1pcEc1a08xNXRwczl3K0ZUUWZPTFBJ?= =?utf-8?B?d3Ntb3NRZ2Z1T0IwcXJwb2FFeHc5eXZUMXB6cFZKbkVTTElydjlnTGJNbW4y?= =?utf-8?B?UkJESWN6eHIvS0FzTHVEakJvcXZKUnVTSEpCdmhNRnhJaGNzYnZ2UGo2cERQ?= =?utf-8?B?WjZBQWpLQWRYTFRVbFcraVNZVURCWGNBVjdpYzB5cUhPMEhpbEFaWk81Rlp1?= =?utf-8?B?TGM1TEZjYlZ4RHN6UGhldk1TY2tONFhYVC9JRWowQTB2T3Q0enRrYndYQm5x?= =?utf-8?B?eXM0ZzRMcFBCdmxWZE1YNFIzTVp6L2VJNVdLQytIaWFGLzNqR0p5VVJubnFL?= =?utf-8?B?Q3dmWHl3dW0wdW9QWC9xazJrSFl3SXlrSThGNE9RdWR1b1drL09lMGticUFs?= =?utf-8?B?RWhITmNqTHA0ZENHSkFLVGFMdGQ5NWk0Y3hpY0lKaWphNlhQSUdVV3VEdmVl?= =?utf-8?B?Uzh1TStRbEprSTlPWGs3Ykh6Q1JBUE85TjBOdVhhMmFGQldEcUx5VUVYWUtl?= =?utf-8?B?UFNvZVlCTzNPZnFaazBjZ2g5aFR5bDFCRkRvZE0wWktJaDRJOEdCb0psekVR?= =?utf-8?B?c05zWWJyS2Z2RmVoWUJXajUyM1VRL1ZGb0JxT0Q0M3ZoNC9XRloybEdjOU1Q?= =?utf-8?B?KzlLNWttc3dycnpObmxjMWdCZnI3ejdzdkcxTUwvNm44Nkt6MlEyZmQ3Z1lt?= =?utf-8?B?QXZ3UCtIYitKQ1dtbWRWVFovakdyWGZ4RnZyQ25QUFBrWm1ISGJ6WkltdWh6?= =?utf-8?B?eVJlV0JXVXIzbzRkY1Fkalk0QmRMcmZCT21qSFZmYjUxaUhBZlJKNnByR3U1?= =?utf-8?B?bWM4Qm5OVS9CM2xDejBxUVBOODdJOXZmOTV2VWpLeENUQkszVTUzZTU5Tnp1?= =?utf-8?B?TGM3M1dQNnlYY3UwS2RPaHo0QU01UnhIa1VXN3poczIwWmV5TGZFSUEzS0RR?= =?utf-8?B?RTh4bTJuekRWRGQ2L3RXWW9rRzdSVk9oTzVaK0MyOWZzZVIvT2hGeTM5UnhP?= =?utf-8?B?WDJBSW9nUjZWYXRiNXVvZlR3alVCQkdlWXZiR3g0d3duTm02VjlqSEJIclBx?= =?utf-8?B?SDBJQnl4MWorQkFHTktGTzl2NFVNQjRpSjJDTFdOcjhhWGF3aWRQN09mTkg3?= =?utf-8?B?cnNJVVExZSsrZGd5YW11NVFWOW12TDhCNzlJK1NmS2ZkMlhMZjAwVnJ0ZWU1?= =?utf-8?B?SkszMEpyN0drSFh3RnNMM2xqZXVBSzExbkJQNnN3ODdOd3FKSmxKWDdRZFBa?= =?utf-8?B?a2w1cFdiZTFhYVBheXNsT0RKbmNabGRUV2greFNkZFM1OU9TdDRoU3p3M3lp?= =?utf-8?B?QWpGR2wrVGtaWnlxOU9GVUVpN1ZyUzFTdlYreFJOelRNTW8vWjZaUUJIS2Ew?= =?utf-8?B?UjJJN2UrV2xMcklVVzFPMHl1L0FWcjZPaTBmRC9CcmNncktIUTN4WDdaQXNh?= =?utf-8?B?OG1OWDh2RWw5UlZ0N1JUTjFUdk16UWgzY1l1RjNhNS9ZZDgvVnlrUHUzQ0VC?= =?utf-8?B?djNFekoxaXR2RUx3VERCM2ZIQzBmRjc1OXZvU0hhNFRrZjlsTXo0eXpzYTQ2?= =?utf-8?B?dDhCYmtwcllsT05tUm9sbTFsOXFzVGFGRkV0aXQzZkd3cWc3QitoeWNVRVAy?= =?utf-8?B?VjREb2p1aFZodmZyVW9jUTBkcFFHUW1nOTRLVHV4WGxmWXZROGQwczFFTEow?= =?utf-8?B?UlhVRDY2Q3VTWXVCbFU5NitKZDJRMEQzeGVMdWFOa0FQSkdIMXE5NjYxQ2dk?= =?utf-8?B?OHpmRnFZQVVhMlMvTTR4ZStlOWE5cmkrRTRIenFFUnJPL2gvZ0VWNkVibFNj?= =?utf-8?B?a2ZLSCtydEpLY25yVG5CbnIrdzRjenBNb0lKWEdtMjhrWWc4V2ZkQkYrai95?= =?utf-8?B?RlVZT21tcWFFQjhUV3hBeFF5dWsrSjdJS0dibzBUM3BRanZwU1Bub3FCeVQy?= =?utf-8?B?UFlJWmNINklyU0NDZG9Vc3V5TnVJMFFQYWsvZENmaUd4UU5CS3QxeUhZS29k?= =?utf-8?Q?DJ6V4bbTpHoWvuOtFES38KUHq?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9ab73aa-071b-48e5-330e-08da8feeb370 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 10:01:00.1340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tP25vTL3y/pHEjVsFeaj6i90ltqcsqRSayiHF7Lcr5hoU/cYfsaVQozXqnXh9Ar7faOSak3tl1m/scaKULri8sPB1k8nS3yyfzl1Gapnxe0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6090 T24gMDYvMDkvMjAyMiAxMDo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAyLjA5LjIwMjIg MDQ6MDUsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4+IE9uIEludGVsIGNoaXBzIChJY2Ug TGFrZSBhbmQgbGF0ZXIpIGFuZCBBUk02NCwgYSBiaXQgbmVlZHMgdG8gYmUgc2V0IGluDQo+PiBh IENQVSByZWdpc3RlciB0byBlbmZvcmNlIGNvbnN0YW50LXRpbWUgZXhlY3V0aW9uLiAgTGludXgg cGxhbnMgdG8gc2V0DQo+PiB0aGlzIGJpdCBieSBkZWZhdWx0OyBYZW4gc2hvdWxkIGRvIHRoZSBz YW1lLiAgU2VlDQo+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sL1l3Z0NycXV0eG1YMFc3 MnJAZ21haWwuY29tL1QvIGZvciBkZXRhaWxzLg0KPj4gSSByZWNvbW1lbmQgc2V0dGluZyB0aGUg Yml0IHVuY29uZGl0aW9uYWxseSBhbmQgaWdub3JpbmcgZ3Vlc3QgYXR0ZW1wdHMNCj4+IHRvIGNo YW5nZSBpdC4NCj4gSSBkb24ndCB0aGluayB3ZSBvdWdodCB0byBzZXQgaXQgYnkgZGVmYXVsdDsg SSBjYW4gc2VlIHJlYXNvbnMgd2h5IGtlcm5lbHMNCj4gbWF5IHdhbnQgdG8gc2V0IGl0IGJ5IGRl ZmF1bHQgKHByb3ZpZGluZyBhIHdheSB0byB0dXJuIGl0IG9mZikuIEluIFhlbg0KPiB3aGF0IEkg dGhpbmsgd2UgbmVlZCBpcyBleHBvc3VyZSBvZiB0aGUgYml0IHRvIGJlIGd1ZXN0LWNvbnRyb2xs YWJsZS4NCg0KV2UgYWJzb2x1dGVseSBzaG91bGQgbm90IGhhdmUgaXQgc2V0IGJ5IGRlZmF1bHQu wqAgSXQncyBhIHN1YnN0YW50aWFsDQpvdmVyaGVhZCBmb3Igc29tZXRoaW5nIHRoYXQgaXMgb25s eSBhcHBsaWNhYmxlIHRvIGNvZGUgd2hpY2ggb3RoZXJ3aXNlDQpjcmFmdGVkIHRvIGJlIGNvbnN0 YW50LXRpbWUuDQoNCkFzIGZvciB3aHkgWGVuIGRvZXNuJ3QgZW51bWVyYXRlL3ZpcnR1YWxpc2Ug aXQsIHRoYXQncyBiZWNhdXNlDQp2aXJ0dWFsaXNpbmcgTVNSX0FSQ0hfQ0FQUyBmb3IgZ3Vlc3Rz IGlzIHN0aWxsIG5vdCB3b3JraW5nIHlldCwgc28gdGhlDQpmZWF0dXJlIGNhbid0IGJlIGVudW1l cmF0ZWQgeWV0IGV2ZW4gaWYgd2UgZGlkIHN1cHBvcnQgY29udGV4dCBzd2l0Y2hpbmcgaXQuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400447.642209 (Exim 4.92) (envelope-from ) id 1oVgT6-0007jw-OL; Tue, 06 Sep 2022 21:50:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400447.642209; Tue, 06 Sep 2022 21:50:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgT6-0007jl-J3; Tue, 06 Sep 2022 21:50:52 +0000 Received: by outflank-mailman (input) for mailman id 400447; Tue, 06 Sep 2022 21:50:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIK-0000Cs-GO for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d91f7c7-2df6-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 17:11:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6827.eurprd04.prod.outlook.com (2603:10a6:10:f8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 15:11:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 15:11:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d91f7c7-2df6-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rz+xqaB9PY33Qj/NrKXNYyRdd2ys6wsXzpRVBSQIZyWJzT098amWnoukX8O/Poha4FwyKfWDyNAfReknYCCKYUn6oJRSsrLQe8+NYMrzpR4PQMvBSK4yGCHNzatl4d490mT7wOtfPU1kCLQqZ19DFBxb8SYaqg6j0bN3NghxrP5oXPo6iJRMhO96bm8x1OX6ZaswtSTPjSCzDpl17eDUptLUAwdvjhfGdl6RPKFrMTcMKJrfQhfJGKh4kQQQgiHOth3x3beIJvSdOdwtilDlHPD6nO/HgBEyAW+AG3Yis8hdFmBp/d1kK2x/o3C1nXs1FqyuQXtFLGHA3ZNUW0QH7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30Ay8RqTnTPXL961VxLLliKVEkAYCeGeNk6oKO1WFQM=; b=ch1GXyLOQd1scsTyYfMxn2PaDXaiYYKG5a0m/oxbYFqUI9RWkJbicYOJO5HnYAtPhkxKIx7m8GML/luz63DHaQkHt9NTw/L5omv0zMxQRELZGyOE20hGgzQb8DQIRZKrKRSbSF0Yd3ITuXC1okneQdDUe5F1+awFhZrmQ3j89Kj/NGwB+CHdKUgoHUmZQgXBV/6Y6MBsYu9EsUAxNZfBScId8nJqqWMzahuwiz9DAUKnrZIVPgmGp10eEdxcqc+dK6N5gJkqkKufRqKYHX9bMLjMSC2iwPhvho77oQ5XXPVwxENYMaC5yMGeLbQa9cF5KtnNTrEajXObRuaFNaqmWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30Ay8RqTnTPXL961VxLLliKVEkAYCeGeNk6oKO1WFQM=; b=kFlO+yxqYfd3txM18Ro5Sf1NKkJk1l+XVUWYqU5wOIdxFoAIcnhr6vdI+NC7eXraHGcG2AbsfN3Wk2h2RmbHyOdoISu7CO/DUBkejnhNWP+lsdcNX6QGe91jqimJVWu0FDZVnfv+ApzhyRcNgrFPz0lbniQPkcZ1eOgai007m99prliii7Wr6j3XTHIH7SFvVwHWUHn/HFHLwkg0JbT8jF5GbirI6uSUS2Y9RBWC+Rvfrvw7eLrb4utJgHXVqTjBC1YP+uHt35K/rmiXfGjVDUkcpVvQ/sXtIF0dryeWMEc4UbqKvP74gZ7MrgRElzHp0a11zpUZSS4IES4a+10BQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f7b3495-7963-fa4a-f4c0-5b668238d337@suse.com> Date: Tue, 6 Sep 2022 17:11:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa5ea817-3f82-456c-77da-08da901a1130 X-MS-TrafficTypeDiagnostic: DB8PR04MB6827:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Klrls4rd2eAz0dwz5XEwFcvbeeh5B48QEEo6E+Phrpp7xdh0BxM3hYoJ1ONKk4lao8FRsLzet2oTShYl+YAJQjYaHXQehOI1aDaSjMEWsfWb+OSbau/C0M93khVWyW5evcQVplDKsxAYbg7TW+fkDjlQ6ehPcdqxhWbnR5SBLqbzrK7PJc3nUoPL4JwN20I6B1SSit566mMzVtu2G5iDDc1iGByOcGnRTMbm/G4eZ+RPu/747XJCbRlhU1gntS97cQqaGWiW710auGDfPQ7KmvqUEY+xeML8DOX1/iRyKGiajYVezEC48jLw35HMweRz6HqlZaC2OLWND53NhkDWEr3wERKiPNleVXn/WRlAS1iKWKTsJYnpDr5o/xWm0fyIm05rGx20tuVLJ2r7scxHf1KNRjlimgSfqWYSahXYCfPDk/56ieUy9bAGTs5DYtfLCKamqLE9CMa4bMjYnWhOigRKLfef5nnDvlOEBi1rAbLW07lI1+yP3Uqj0bxlDQuyIrFIo6ie77nMOmKF2AP7tAhDKetunXZb0FKECICPP4Vaz9t2Z80zaAY/d52zcpFU9wkyOzqo32bEovohliKWLcReSCA/c3rsA9Yotmc7+5ASCJzEgKXX3Sl4oNTlriEVMnx8gRfMsEZQCudihdMUp1ZUWru7U0MiSeIomaCi/ZoEPcQf+yBfc0Ho4J6wcUYtVgxEcaTNGt0VGTnQu2bclR1BovL4VmldWH9otfT5KaiZe+DwHL0hLqnJHTOet8DkzWz+9oJosXrzkiio8EMeovDGTgZXdb+6uVS0zavjyqI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(39860400002)(376002)(366004)(6916009)(53546011)(31696002)(4744005)(86362001)(31686004)(38100700002)(36756003)(316002)(54906003)(8676002)(66476007)(66556008)(66946007)(4326008)(478600001)(5660300002)(8936002)(6506007)(41300700001)(7416002)(186003)(26005)(2906002)(6486002)(6512007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QndqRFdxaU5rNE1FOWJWVndVSnNOSXpYRGNGb0dMUENITFVoMlk0cGtTNFFP?= =?utf-8?B?Q01qdytTTGFVK2o2cC9KQk1sYVJnTkZtRVZTWVNBSmUzVmNBUEdPWW9NVXFy?= =?utf-8?B?Y3hzZEdvYVh3UW1UMWpLNm5udmhBRGpORVI0WEcwUmRRVTBDeUhtU1hobHhZ?= =?utf-8?B?Z1htYjM0azdMYzBGbWRrR3BsT09hYXZQanhnTnBSaHltQ0xJYWlPOU9LUUdC?= =?utf-8?B?Y2R2RWFtSGEzaS9TWXF0NVhROUlMdjRmbGVPcngwdnRlTW5iVzRjZllKTENT?= =?utf-8?B?bE1FM1IxMFBLM0kwRWI3ck95ajhsOFV2dmVWUDhsQ3k3Z0xIMVFsY1dtU3FL?= =?utf-8?B?SzUvdzB0cHJOOUo0NEdpeS83NldXSVZDWEdaWDNmdzMyNG5NT0tkUDNXblpq?= =?utf-8?B?Q012bU1EWDJXNVc1K3FQY0N5czIrMUh4MmxpbzRiUFFmVkl1dWhONHNkZHJs?= =?utf-8?B?Szk4SHVvOEYyRTgyeHUxTCtHN0RDNnNtSTFzRHduMGEzdUhwRFZzWlZhL0pT?= =?utf-8?B?Z1hjMEgzeEdaYWRnQlZJdUVKcjZ4c3lGNnczVTl4YXFMM3pRZ0h2Q2xIcjQ3?= =?utf-8?B?U0ZZdklqWnh5VERjd1F3eC9ldktCNjJ0VW9Id3crVkJLbHU5SWhLYTExZUpK?= =?utf-8?B?dVNJcmNHMEg5aGNGaFdmUGNYVzVma2t5dEphM042NHpVQ2tLM09ZcnpQa2Vi?= =?utf-8?B?Tlh5a0xad2tZY0EreGFHdkVyOVhXR2docTQyc21hc1pybHBpRTZ6bCtvVThy?= =?utf-8?B?MTR1YTVLT00xdFFLbTQrUFRDdUpuRXBVR2M3QXFEKy9Kd3RSWnNpemw2NG0z?= =?utf-8?B?bk5zazVsN1QzNktad2NEaEFTaU5xaVA5empxNDg4Ulo5cU5ac21nelhVcWZI?= =?utf-8?B?WUJsM3NjbDdqQlN0VUUyNVBnZDk2RGFydmZINmNlK1Q3dHhCYVpRcDJYUVBP?= =?utf-8?B?ekc1bVRzNU9ocFp4cWJEWEJzNUNYVDgxc2RrZGV6ZXFUcGk4bXR1aFcwbEh6?= =?utf-8?B?aHVkRHZXMEJzNGd5bnRwckhVZnFoT0hINnU1WllxamFwVWMzSHc1NXpoRkV2?= =?utf-8?B?K2Fyb3ZabVFSTGhVSjFOTjkybGxRTWE0K2g3bkhWeEozWE4ySEJvdU1PMTlW?= =?utf-8?B?M3lTa2g4OUlUWUdvd0xZK2w3WCtCT2MzS2c1d2ZmQW9WeVVySTJkU2RnK0Iv?= =?utf-8?B?SUtDcmF5ODhLd3hpbWlRdjgxZ0ltN2M4S1UxaVVPYWIySk56Q3doMVRQdFl2?= =?utf-8?B?MGQvLzFaYUl1dUtHTDFZVzg0NEd4RENPQm1EbG9vdndQUVE2N3YrUGRlMFJW?= =?utf-8?B?S0VHK1ZPZlpWZVNnTUdScUlOeEpncW45NFdVR21HNUo2T3ZxRi9yZkx4aC8v?= =?utf-8?B?c2JYdzIyQ1J6SDM5Ly9lZlNZSTBpL21YalhlQlRkbzNhZnl0ZnB1dkQ5Nnp0?= =?utf-8?B?SCtqSjhRM01ETHVtWE44Z0ZVejRQbFVrR3dvLzNsd2hTNmV3OENqSFZpTTBs?= =?utf-8?B?YitnaHFJL2FrWjNWM1BSVVlyZXE5a2R5a3RkZHJFNUh1L0pKN2E0azhHVWR6?= =?utf-8?B?QlRoVFhUQXYwWWdsOU9MaENMdDdaVFd6ZUFOMThCd0RrRVVZemRyRlpYS0VV?= =?utf-8?B?V2diWGoyeW5nalR6ZTRwcVY4b3R4VUxTbjlTajJvNWpKS2Z3NFZ6WDNiayts?= =?utf-8?B?Wk5rTElFamd5RXl5ZTZRSXdOQTZrblMwV3dFVk1pQmEvQ2RVNWN6SkRzOVJk?= =?utf-8?B?c0pOZzVoSlBweUttdXBNdHJHa0NHdmxMWlBDai9RNllPOVlXOUN3eS83STFP?= =?utf-8?B?TWdJOE92Z2Q2SXZXUmhUTlcxOWZlZVN3NStXWWtFQ0lwaHFGdklPd3BqLzJB?= =?utf-8?B?UVpTUGRWMTV0WTd3ZkE0NDFPejFDL0NyZWlsVnl3NkRuTmxuSDFmcE5kVjZl?= =?utf-8?B?VUVlWm0rT3c0QWNqU3ZYb1Flc01TcXk5bGRObHEwakVpZHNXZ0o2MGpJY3BL?= =?utf-8?B?SG5vd1NLUWh5RUxoNDVCQTJVclJIRlg2RkpVSFIwdEFnL0F6dTR2Nk9NdW5m?= =?utf-8?B?dGFFRkxpTmdpSWpRTXZxbWdFM05JYU1jV0FXd1JlV21pRStMRzE5d0hQZUgz?= =?utf-8?Q?Lnhw8TaCM6OCK+YwJG5XYkb3N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa5ea817-3f82-456c-77da-08da901a1130 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:11:25.9066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DG7XWNpB3IrwVhPL2FtR6G2JuuIsEHyu1q75yWOaQPCorgz7TdoZd6MGb8Xu45r5/3/gfyYgWcqInCP2MlPrcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6827 On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote: > Marek Marczykowski-Górecki (10): > drivers/char: allow using both dbgp=xhci and dbgp=ehci > console: support multiple serial console simultaneously > IOMMU: add common API for device reserved memory > IOMMU/VT-d: wire common device reserved memory API > IOMMU/AMD: wire common device reserved memory API > drivers/char: mark DMA buffers as reserved for the XHCI > drivers/char: add RX support to the XHCI driver > drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC > drivers/char: fix handling cable re-plug in XHCI console driver > drivers/char: use smp barriers in xhci driver I wonder in how far it would be possible to commit parts of this series. Aiui patches 3-6 belong together (lacking a suitable ack on 4), but are independent of 1 and 2. What I can't really tell is whether 7-9 are independent of 1-6 and could hence go in. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400451.642220 (Exim 4.92) (envelope-from ) id 1oVgT9-0008A4-6Q; Tue, 06 Sep 2022 21:50:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400451.642220; Tue, 06 Sep 2022 21:50:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgT9-00089R-1o; Tue, 06 Sep 2022 21:50:55 +0000 Received: by outflank-mailman (input) for mailman id 400451; Tue, 06 Sep 2022 21:50:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgI3-0000Cs-FC for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:39:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 864b41a0-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 11:58:58 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B867D6E; Tue, 6 Sep 2022 02:59:05 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E64CC3F534; Tue, 6 Sep 2022 02:58:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 864b41a0-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Jean-Philippe Brucker , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Robin Murphy , Will Deacon Subject: [PATCH v4 02/10] xen/arm: smmuv3: Fix endianness annotations Date: Tue, 6 Sep 2022 10:55:49 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jean-Philippe Brucker Backport Linux commit 376cdf66f624. This is the clean backport without any changes. When building with C=1, sparse reports some issues regarding endianness annotations: arm-smmu-v3.c:221:26: warning: cast to restricted __le64 arm-smmu-v3.c:221:24: warning: incorrect type in assignment (different base types) arm-smmu-v3.c:221:24: expected restricted __le64 [usertype] arm-smmu-v3.c:221:24: got unsigned long long [usertype] arm-smmu-v3.c:229:20: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:229:20: expected restricted __le64 [usertype] *[assigned] dst arm-smmu-v3.c:229:20: got unsigned long long [usertype] *ent arm-smmu-v3.c:229:25: warning: incorrect type in argument 2 (different base types) arm-smmu-v3.c:229:25: expected unsigned long long [usertype] *[assigned] src arm-smmu-v3.c:229:25: got restricted __le64 [usertype] * arm-smmu-v3.c:396:20: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:396:20: expected restricted __le64 [usertype] *[assigned] dst arm-smmu-v3.c:396:20: got unsigned long long * arm-smmu-v3.c:396:25: warning: incorrect type in argument 2 (different base types) arm-smmu-v3.c:396:25: expected unsigned long long [usertype] *[assigned] src arm-smmu-v3.c:396:25: got restricted __le64 [usertype] * arm-smmu-v3.c:1349:32: warning: invalid assignment: |= arm-smmu-v3.c:1349:32: left side has type restricted __le64 arm-smmu-v3.c:1349:32: right side has type unsigned long arm-smmu-v3.c:1396:53: warning: incorrect type in argument 3 (different base types) arm-smmu-v3.c:1396:53: expected restricted __le64 [usertype] *dst arm-smmu-v3.c:1396:53: got unsigned long long [usertype] *strtab arm-smmu-v3.c:1424:39: warning: incorrect type in argument 1 (different base types) arm-smmu-v3.c:1424:39: expected unsigned long long [usertype] *[assigned] strtab arm-smmu-v3.c:1424:39: got restricted __le64 [usertype] *l2ptr While harmless, they are incorrect and could hide actual errors during development. Fix them. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Robin Murphy Link: https://lore.kernel.org/r/20200918141856.629722-1-jean-philippe@linaro.org Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 376cdf66f624 Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes in v4: - Move Stefano Acked-by after Signed-off Changes in v3: - Added Stefano Acked-by Changes in v2: - fix commit msg --- xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 340609264d..64d39bb4d3 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -1037,7 +1037,7 @@ static int queue_insert_raw(struct arm_smmu_queue *q, u64 *ent) return 0; } -static void queue_read(__le64 *dst, u64 *src, size_t n_dwords) +static void queue_read(u64 *dst, __le64 *src, size_t n_dwords) { int i; @@ -1436,7 +1436,7 @@ static void arm_smmu_write_strtab_ent(struct arm_smmu_master *master, u32 sid, arm_smmu_cmdq_issue_cmd(smmu, &prefetch_cmd); } -static void arm_smmu_init_bypass_stes(u64 *strtab, unsigned int nent) +static void arm_smmu_init_bypass_stes(__le64 *strtab, unsigned int nent) { unsigned int i; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:50:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400460.642230 (Exim 4.92) (envelope-from ) id 1oVgTC-0000QN-MW; Tue, 06 Sep 2022 21:50:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400460.642230; Tue, 06 Sep 2022 21:50:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgTC-0000Q3-Hr; Tue, 06 Sep 2022 21:50:58 +0000 Received: by outflank-mailman (input) for mailman id 400460; Tue, 06 Sep 2022 21:50:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgIh-0000Cs-Jp for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:40:07 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d1d902db-2dca-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 12:01:04 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12FC3D6E; Tue, 6 Sep 2022 03:01:12 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C75AA3F534; Tue, 6 Sep 2022 03:01:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1d902db-2dca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Zhou Wang , Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Will Deacon Subject: [PATCH v4 03/10] xen/arm: smmuv3: Ensure queue is read after updating prod pointer Date: Tue, 6 Sep 2022 10:55:50 +0100 Message-Id: <4404a056ba2dfc7ed2a69270dd2c28d0d343dfa3.1662455798.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhou Wang Backport Linux commit a76a37777f2c. Introduce __iomb() in the smmu-v3.c file with other Linux compatibility definitions. Reading the 'prod' MMIO register in order to determine whether or not there is valid data beyond 'cons' for a given queue does not provide sufficient dependency ordering, as the resulting access is address dependent only on 'cons' and can therefore be speculated ahead of time, potentially allowing stale data to be read by the CPU. Use readl() instead of readl_relaxed() when updating the shadow copy of the 'prod' pointer, so that all speculated memory reads from the corresponding queue can occur only from valid slots. Signed-off-by: Zhou Wang Link: https://lore.kernel.org/r/1601281922-117296-1-git-send-email-wangzhou1@hisilicon.com [will: Use readl() instead of explicit barrier. Update 'cons' side to match.] Signed-off-by: Will Deacon Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a76a37777f2c Signed-off-by: Rahul Singh --- Changes in v4: - rename iomb() to __iomb() Changes in v3: - rename __iomb() to iomb() and also move it from common file to smmu-v3.c file Changes in v2: - fix commit msg - add __iomb changes also from the origin patch --- xen/drivers/passthrough/arm/smmu-v3.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index 64d39bb4d3..229b9a4b0d 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -107,6 +107,8 @@ typedef paddr_t dma_addr_t; typedef paddr_t phys_addr_t; typedef unsigned int gfp_t; +#define __iomb() dmb(osh) + #define platform_device device #define GFP_KERNEL 0 @@ -951,7 +953,7 @@ static void queue_sync_cons_out(struct arm_smmu_queue *q) * Ensure that all CPU accesses (reads and writes) to the queue * are complete before we update the cons pointer. */ - mb(); + __iomb(); writel_relaxed(q->llq.cons, q->cons_reg); } @@ -963,8 +965,15 @@ static void queue_inc_cons(struct arm_smmu_ll_queue *q) static int queue_sync_prod_in(struct arm_smmu_queue *q) { + u32 prod; int ret = 0; - u32 prod = readl_relaxed(q->prod_reg); + + /* + * We can't use the _relaxed() variant here, as we must prevent + * speculative reads of the queue before we have determined that + * prod has indeed moved. + */ + prod = readl(q->prod_reg); if (Q_OVF(prod) != Q_OVF(q->llq.prod)) ret = -EOVERFLOW; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:55:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400518.642241 (Exim 4.92) (envelope-from ) id 1oVgXN-0002yg-Dm; Tue, 06 Sep 2022 21:55:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400518.642241; Tue, 06 Sep 2022 21:55:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgXN-0002yZ-Az; Tue, 06 Sep 2022 21:55:17 +0000 Received: by outflank-mailman (input) for mailman id 400518; Tue, 06 Sep 2022 21:55:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgXM-0002yT-57 for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:55:16 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95d68aa6-2e2e-11ed-a016-b9edf5238543; Tue, 06 Sep 2022 23:55:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 243B8615BB; Tue, 6 Sep 2022 21:55:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E6CBC433C1; Tue, 6 Sep 2022 21:55:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95d68aa6-2e2e-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662501312; bh=LuXSCf+/dyfRqqCH7TweTrKu2nhhJw+Y2SyCDFvD4DA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CPI6K38w81sioYQFUp3mGrbW5/9ZidJ37Rn4C0B2AcGmqJ2BTshCMSXMFqdcp/Nh2 s0UZ9lgRDtErl2uj6A18nrH3wj98oD+8HoeSd+O6HEze1TZIS41GBzMq5kYL1z42JP nsPBE4mLggnDTPPea8dUonYxkBnywF/fb7+zJFp8TjDCon0bGhXvWM+JYXmeu3aLIV BhfUcJvVvGMyF/rbysx6n3zqfkoxduf05faMtkTz0aS48vHtC898L+mSV7wdcPvcoQ z49gwgT3JxJrRno2ZKbtqnFSkHlwhIazRicN4NRFgv2/X+Ge/DulGUcAnL1R8GQLkR 9shzwm/729Tkg== Date: Tue, 6 Sep 2022 14:55:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v7 3/9] xen/arm: allocate static shared memory to a specific owner domain In-Reply-To: <20220906085941.944592-4-Penny.Zheng@arm.com> Message-ID: References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-4-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 6 Sep 2022, Penny Zheng wrote: > If owner property is defined, then owner domain of a static shared memory > region is not the default dom_io anymore, but a specific domain. > > This commit implements allocating static shared memory to a specific domain > when owner property is defined. > > Coding flow for dealing borrower domain will be introduced later in the > following commits. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v7 chhanges: > - adapt to the previous commits' changes > --- > v6 change: > - fix coding-style > - role_str and owner_dom_io shall be defined within the loop > --- > v5 change: > - no change > --- > v4 change: > - no changes > --- > v3 change: > - simplify the code since o_gbase is not used if the domain is dom_io > --- > v2 change: > - P2M mapping is restricted to normal domain > - in-code comment fix > --- > xen/arch/arm/domain_build.c | 36 +++++++++++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 7 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index be98ff83b1..4be8a00171 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -822,9 +822,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > > static int __init assign_shared_memory(struct domain *d, > uint32_t addr_cells, uint32_t size_cells, > - paddr_t pbase, paddr_t psize) > + paddr_t pbase, paddr_t psize, > + paddr_t gbase) > { > mfn_t smfn; > + int ret = 0; > > dprintk(XENLOG_INFO, > "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > @@ -838,8 +840,18 @@ static int __init assign_shared_memory(struct domain *d, > * DOMID_IO is auto-translated (i.e. it seems RAM 1:1). So we do not need > * to create mapping in the P2M. > */ > - ASSERT(d == dom_io); > - return 0; > + if ( d != dom_io ) > + { > + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, > + PFN_DOWN(psize)); > + if ( ret ) > + { > + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); > + return ret; > + } > + } > + > + return ret; > } > > static int __init process_shm(struct domain *d, > @@ -855,6 +867,8 @@ static int __init process_shm(struct domain *d, > paddr_t gbase, pbase, psize; > int ret = 0; > unsigned int i; > + const char *role_str; > + bool owner_dom_io = true; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > continue; > @@ -891,20 +905,28 @@ static int __init process_shm(struct domain *d, > return -EINVAL; > } > > - /* TODO: Consider owner domain is not the default dom_io. */ > + /* > + * "role" property is optional and if it is defined explicitly, > + * then the owner domain is not the default "dom_io" domain. > + */ > + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) > + owner_dom_io = false; > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > * only find the borrowers. > */ > - if ( !is_shm_allocated_to_domio(pbase) ) > + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > /* > * We found the first borrower of the region, the owner was not > * specified, so they should be assigned to dom_io. > */ > - ret = assign_shared_memory(dom_io, addr_cells, size_cells, > - pbase, psize); > + ret = assign_shared_memory(owner_dom_io ? dom_io : d, > + addr_cells, size_cells, > + pbase, psize, gbase); > if ( ret ) > return ret; > } > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Sep 06 21:55:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 21:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400519.642253 (Exim 4.92) (envelope-from ) id 1oVgXY-0003I0-LC; Tue, 06 Sep 2022 21:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400519.642253; Tue, 06 Sep 2022 21:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgXY-0003Ho-I3; Tue, 06 Sep 2022 21:55:28 +0000 Received: by outflank-mailman (input) for mailman id 400519; Tue, 06 Sep 2022 21:55:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgXX-0003HI-6O; Tue, 06 Sep 2022 21:55:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgXX-00057c-4c; Tue, 06 Sep 2022 21:55:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgXW-0001Kv-1p; Tue, 06 Sep 2022 21:55:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVgXW-00048S-1O; Tue, 06 Sep 2022 21:55:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qhwfN+vuW8JHU5CxRymiDovHn5fvvbjufEXK6BMyTiI=; b=EIYRpgQlvFZfy/7xKpD8tQzRLa 7rVSD9HBpH3wg7Y/AMawG1PRFHwn5jBPWJuc0Ww4g/FhCTWhYRpeGWG1QCFXYXgkYnLvmPQwqnl5j joNWVXMSMG3if9QB34oAG5gQkxJIJ1WTCd925pBpdwdC/wFAiLQkh/DNdJqpTiQ3PVEw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173029: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=172015009a6acc20357a2698800e13058ba1d3db X-Osstest-Versions-That: xen=48f35317c2e2707fc66a839690fe41e6f16180de From: osstest service owner Date: Tue, 06 Sep 2022 21:55:26 +0000 flight 173029 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173029/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173026 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 172015009a6acc20357a2698800e13058ba1d3db baseline version: xen 48f35317c2e2707fc66a839690fe41e6f16180de Last test of basis 173026 2022-09-06 15:00:30 Z 0 days Testing same since 173029 2022-09-06 19:01:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Bixuan Cui Christophe JAILLET Gustavo A. R. Silva Jan Beulich Jean-Philippe Brucker Julien Grall Penny Zheng Rahul Singh Robin Murphy Stefano Stabellini Will Deacon Zenghui Yu Zhen Lei Zhou Wang jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 48f35317c2..172015009a 172015009a6acc20357a2698800e13058ba1d3db -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 06 22:02:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 22:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400577.642264 (Exim 4.92) (envelope-from ) id 1oVgeE-0005Gn-Cu; Tue, 06 Sep 2022 22:02:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400577.642264; Tue, 06 Sep 2022 22:02:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgeE-0005Gg-AC; Tue, 06 Sep 2022 22:02:22 +0000 Received: by outflank-mailman (input) for mailman id 400577; Tue, 06 Sep 2022 22:02:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgeD-0005DV-Ef for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 22:02:21 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93b7027a-2e2f-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 00:02:20 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05B80616FA; Tue, 6 Sep 2022 22:02:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7152BC433D6; Tue, 6 Sep 2022 22:02:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93b7027a-2e2f-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662501738; bh=b2DEvnD6idHHsGoq/wgg1baSL6ZdkFsOHLYIFITUJ9o=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZIYHIgK2xMcJYfW3LMDLU9orpk7Ke5sPVQibtQPwKG7Dh2eNG/OpdQjfQFEJxvzRr PDXuwuruI0lQ72G0TCso/Op0SUNWEo6YE24ylLm31vNLoxyUgJ/WM1OnBG5fjexK77 +6xGwBA+wW7ZfWsxQJTxa827bgCLYV7XmTmXH5rbUgZpG69cbjV0ghKO6ix7oejXc7 BQMM/A+B7bKXUeRxA1dMlhv4kaIRdmZvyuMgQz0UCHko0M9eUTt71XVCuFexrep+X9 i3o7xwgMFndiWVVCo7qSV5nxXB1whs7bOOlrY/CZLAAQW3JBkIGjqbF9P17Nb5IzYK qrlYxu2CYNMfA== Date: Tue, 6 Sep 2022 15:02:16 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree In-Reply-To: <20220906085941.944592-8-Penny.Zheng@arm.com> Message-ID: References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-8-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 6 Sep 2022, Penny Zheng wrote: > We expose the shared memory to the domU using the "xen,shared-memory-v1" > reserved-memory binding. See > Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt > in Linux for the corresponding device tree binding. > > To save the cost of re-parsing shared memory device tree configuration when > creating shared memory nodes in guest device tree, this commit adds new field > "shm_mem" to store shm-info per domain. > > For each shared memory region, a range is exposed under > the /reserved-memory node as a child node. Each range sub-node is > named xen-shmem@
and has the following properties: > - compatible: > compatible = "xen,shared-memory-v1" > - reg: > the base guest physical address and size of the shared memory region > - xen,id: > a string that identifies the shared memory region. > > Signed-off-by: Penny Zheng > --- > v7 changes: > - allocate reg for worst case addrcells + sizecells > - replace assert() with BUG_ON() since it is init code > --- > v6 change: > - change "struct meminfo *mem" to "const struct meminfo *mem" > - change "unsigned long i" to "unsigned int i" to match the type of nr_banks. > - accroding to the Linux binding, "xen,id" is meant to be a string, not > an integer > --- > v5 change: > - no change > --- > v4 change: > - no change > --- > v3 change: > - move field "shm_mem" to kernel_info > --- > v2 change: > - using xzalloc > - shm_id should be uint8_t > - make reg a local variable > - add #address-cells and #size-cells properties > - fix alignment > --- > xen/arch/arm/domain_build.c | 147 +++++++++++++++++++++++++++++- > xen/arch/arm/include/asm/kernel.h | 1 + > 2 files changed, 146 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index d0ff487cc6..3b7436030e 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -914,7 +914,22 @@ static int __init assign_shared_memory(struct domain *d, > return ret; > } > > -static int __init process_shm(struct domain *d, > +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > + paddr_t start, paddr_t size, > + const char *shm_id) > +{ > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > + return -ENOMEM; > + > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); > + kinfo->shm_mem.nr_banks++; > + > + return 0; > +} > + > +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > const struct dt_device_node *node) > { > struct dt_device_node *shm_node; > @@ -928,6 +943,7 @@ static int __init process_shm(struct domain *d, > int ret = 0; > unsigned int i; > const char *role_str; > + const char *shm_id; > bool owner_dom_io = true; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > @@ -972,6 +988,9 @@ static int __init process_shm(struct domain *d, > if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) > owner_dom_io = false; > > + dt_property_read_string(shm_node, "xen,shm-id", &shm_id); > + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > @@ -999,6 +1018,14 @@ static int __init process_shm(struct domain *d, > if ( ret ) > return ret; > } > + > + /* > + * Record static shared memory region info for later setting > + * up shm-node in guest device tree. > + */ > + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); > + if ( ret ) > + return ret; > } > > return 0; > @@ -1329,6 +1356,117 @@ static int __init make_memory_node(const struct domain *d, > return res; > } > > +#ifdef CONFIG_STATIC_SHM > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + const struct meminfo *mem) > +{ > + unsigned int i = 0; > + int res = 0; > + > + if ( mem->nr_banks == 0 ) > + return -ENOENT; > + > + /* > + * For each shared memory region, a range is exposed under > + * the /reserved-memory node as a child node. Each range sub-node is > + * named xen-shmem@
. > + */ > + dt_dprintk("Create xen-shmem node\n"); > + > + for ( ; i < mem->nr_banks; i++ ) > + { > + uint64_t start = mem->bank[i].start; > + uint64_t size = mem->bank[i].size; > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > + char buf[27]; > + const char compat[] = "xen,shared-memory-v1"; > + /* Worst case addrcells + sizecells */ > + __be32 reg[4]; I think it should be: __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS] aside from that (it could be fixed on commit): Reviewed-by: Stefano Stabellini > + __be32 *cells; > + unsigned int len = (addrcells + sizecells) * sizeof(__be32); > + > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); > + res = fdt_begin_node(fdt, buf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); > + if ( res ) > + return res; > + > + cells = reg; > + dt_child_set_range(&cells, addrcells, sizecells, start, size); > + > + res = fdt_property(fdt, "reg", reg, len); > + if ( res ) > + return res; > + > + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", > + i, start, start + size); > + > + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + if ( res ) > + return res; > + } > + > + return res; > +} > +#else > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + ASSERT_UNREACHABLE(); > +} > +#endif > + > +static int __init make_resv_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + int res = 0; > + /* Placeholder for reserved-memory\0 */ > + char resvbuf[16] = "reserved-memory"; > + > + if ( mem->nr_banks == 0 ) > + /* No shared memory provided. */ > + return 0; > + > + dt_dprintk("Create reserved-memory node\n"); > + > + res = fdt_begin_node(fdt, resvbuf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "ranges", NULL, 0); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#address-cells", addrcells); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#size-cells", sizecells); > + if ( res ) > + return res; > + > + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + > + return res; > +} > + > static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) > { > struct meminfo *ext_regions = data; > @@ -3106,6 +3244,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > if ( ret ) > goto err; > > + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, > + &kinfo->shm_mem); > + if ( ret ) > + goto err; > + > /* > * domain_handle_dtb_bootmodule has to be called before the rest of > * the device tree is generated because it depends on the value of > @@ -3482,7 +3625,7 @@ static int __init construct_domU(struct domain *d, > assign_static_memory_11(d, &kinfo, node); > > #ifdef CONFIG_STATIC_SHM > - rc = process_shm(d, node); > + rc = process_shm(d, &kinfo, node); > if ( rc < 0 ) > return rc; > #endif > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index c4dc039b54..2cc506b100 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -19,6 +19,7 @@ struct kernel_info { > void *fdt; /* flat device tree */ > paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ > struct meminfo mem; > + struct meminfo shm_mem; > > /* kernel entry point */ > paddr_t entry; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Sep 06 22:13:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 22:13:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400636.642274 (Exim 4.92) (envelope-from ) id 1oVgoU-0007Ql-FI; Tue, 06 Sep 2022 22:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400636.642274; Tue, 06 Sep 2022 22:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgoU-0007Qe-Cg; Tue, 06 Sep 2022 22:12:58 +0000 Received: by outflank-mailman (input) for mailman id 400636; Tue, 06 Sep 2022 22:12:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgoS-0007QF-KK for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 22:12:56 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0de98ffa-2e31-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 00:12:55 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84C17615B0; Tue, 6 Sep 2022 22:12:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18614C433C1; Tue, 6 Sep 2022 22:12:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0de98ffa-2e31-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662502372; bh=lBcGXX22EEBnypmILhKJ7XGiGfYojBp0b6PI0XiwAOI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=o43ymXLoT6AghsTSpmEYitnUfi2QlosXoj8pP1P1SAmIhUp+agB4O3GKetUH8SyEp +C99naS1he4w+VU02AzKWGlr2+BCeXK8MHfdP4wEPOkHRsQSNn6b4YkoxXa9pfq3is ZbrnciNVTboKys0N/TwOov9HmeDQIm3EenxeR4lY+vXgiGVzgYpOnwGZpSiM1uTOen lP6NQsd7oOS6ImMcvSML7pQuYIU6Cz/8VSce2hUDOpbeNgaWzDTn4MU5Q8HgwGwJQt CG6BlAjWwqgOtL0kbxgl6w1NU4lt0+psIwaH5RJ8oVoP2aT1ejPTWvOi5aBKZMjKd5 zA2+inR37ewyA== Date: Tue, 6 Sep 2022 15:12:50 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value In-Reply-To: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> Message-ID: References: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 6 Sep 2022, Rahul Singh wrote: > Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to > disable xenstore interface for dom0less guests. > > Signed-off-by: Rahul Singh > --- > Changes in v4: > - Implement defines for dom0less features > Changes in v3: > - new patch in this version > --- > docs/misc/arm/device-tree/booting.txt | 4 ++++ > xen/arch/arm/domain_build.c | 10 ++++++---- > xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- > 3 files changed, 31 insertions(+), 6 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..1b0dca1454 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -204,6 +204,10 @@ with the following properties: > - "disabled" > Xen PV interfaces are disabled. > > + - no-xenstore > + Xen PV interfaces, including grant-table will be enabled but xenstore > + will be disabled for the VM. Please use "" for consistency: - "no-xenstore" > If the xen,enhanced property is present with no value, it defaults > to "enabled". If the xen,enhanced property is not present, PV > interfaces are disabled. > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 707e247f6a..0b164ef595 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > goto err; > } > > - if ( kinfo->dom0less_enhanced ) > + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) > { > ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); > if ( ret ) > @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *d, > (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) > { > if ( hardware_domain ) > - kinfo.dom0less_enhanced = true; > + kinfo.dom0less_feature = DOM0LESS_ENHANCED; > else > - panic("Tried to use xen,enhanced without dom0\n"); > + panic("At the moment, Xenstore support requires dom0 to be present\n"); > } > + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) > + kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; > > if ( vcpu_create(d, 0) == NULL ) > return -ENOMEM; > @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, > if ( rc < 0 ) > return rc; > > - if ( kinfo.dom0less_enhanced ) > + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) > { > ASSERT(hardware_domain); > rc = alloc_xenstore_evtchn(d); > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index c4dc039b54..ad240494ea 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -9,6 +9,25 @@ > #include > #include > > +/* > + * List of possible features for dom0less domUs > + * > + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. All the > + * default features (excluding Xenstore) will be > + * available. Note that an OS *must* not rely on the > + * availability of Xen features if this is not set. > + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > + * can't be enabled without the > + * DOM0LESS_ENHANCED_NO_XS. > + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > + * default features (including Xenstore) will be > + * available. Note that an OS *must* not rely on the > + * availability of Xen features if this is not set. > + */ > +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) > +#define DOM0LESS_XENSTORE BIT(1, U) > +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XENSTORE) > + > struct kernel_info { > #ifdef CONFIG_ARM_64 > enum domain_type type; > @@ -36,8 +55,8 @@ struct kernel_info { > /* Enable pl011 emulation */ > bool vpl011; > > - /* Enable PV drivers */ > - bool dom0less_enhanced; > + /* Enable/Disable PV drivers interface,grant table, evtchn or xenstore */ missing a whitespace > + uint32_t dom0less_feature; Given that we only really need 2 bits today, and given that uint8_t and uint16_t are free but uint32_t increases the size of the struct, could we just use uint16_t dom0less_feature ? Everything else looks good, these are just minor things. > /* GIC phandle */ > uint32_t phandle_gic; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Sep 06 22:22:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 22:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400652.642286 (Exim 4.92) (envelope-from ) id 1oVgxq-0000jG-CA; Tue, 06 Sep 2022 22:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400652.642286; Tue, 06 Sep 2022 22:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgxq-0000j9-9T; Tue, 06 Sep 2022 22:22:38 +0000 Received: by outflank-mailman (input) for mailman id 400652; Tue, 06 Sep 2022 22:22:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgxo-0000j3-7b for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 22:22:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67af75d8-2e32-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 00:22:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8B04616DF; Tue, 6 Sep 2022 22:22:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52E55C433C1; Tue, 6 Sep 2022 22:22:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67af75d8-2e32-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662502953; bh=8n8aMCWIfJIlAuCHcbpzkSDHpKkDTpXTJEtaU2PtQ8I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uO1HfR5AenOtZwvziWvYSCFADRYyUkfnabsWDD6nZELMQHf+DbbQMXSKLRWjIbpmm SoBU9fMEpzqzEuYeIQwFmCh8vWi17ohE1Lxp6mukER0u77s3U9qr7dePcG00pItVAN XyB/e/I9UHqXQiIqByLmhuVmUIpAy/3uPQr2mwXSjw8fB+x4K3+Pi19CmkcyUc9eqR JjuL7p6NLaOOosbp3yBoRwYYxC9RDmNwA2yIDP25/pO7AhgOLfQ6lVYyjIPogi1oJC R3SHy/RxsbjV/LdrWpdSRQPQR71iK4o3zw8fZD9//k/THq0B1vu91REiW49qGW3q3H swPO0JWCxokzg== Date: Tue, 6 Sep 2022 15:22:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 7/7] xen/arm: introduce xen-evtchn dom0less property In-Reply-To: <055660c342c85cd97d6e3a5551c84e62f49dece6.1662462034.git.rahul.singh@arm.com> Message-ID: References: <055660c342c85cd97d6e3a5551c84e62f49dece6.1662462034.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 6 Sep 2022, Rahul Singh wrote: > Introduce a new sub-node under /chosen node to establish static event > channel communication between domains on dom0less systems. > > An event channel will be created beforehand to allow the domains to > send notifications to each other. > > Signed-off-by: Rahul Singh > --- > Changes in v4: > - move documentation to common place for evtchn node in booting.txt > - Add comment why we use dt_device_static_evtchn_created() > - check if dt_get_parent() returns NULL > - fold process_static_evtchn_node() in alloc_static_evtchn() > Changes in v3: > - use device-tree used_by to find the domain id of the evtchn node. > - add new static_evtchn_create variable in struct dt_device_node to > hold the information if evtchn is already created. > - fix minor comments > Changes in v2: > - no change > --- > docs/misc/arm/device-tree/booting.txt | 98 +++++++++++++++++ I have just reviewed the binding, only three minor comments below. Everything looks good. > xen/arch/arm/domain_build.c | 147 ++++++++++++++++++++++++++ > xen/arch/arm/include/asm/setup.h | 1 + > xen/arch/arm/setup.c | 2 + > xen/include/xen/device_tree.h | 16 +++ > 5 files changed, 264 insertions(+) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 1b0dca1454..c8329b73e5 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -382,3 +382,101 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > +Static Event Channel > +==================== > +The event channel communication will be established statically between two > +domains (dom0 and domU also). Event channel connection information between > +domains will be passed to Xen via the device tree node. The event channel > +will be created and established in Xen before the domain started. The domain > +doesn???t need to do any operation to establish a connection. Domain only doesn't better to use ASCII if possible > +needs hypercall EVTCHNOP_send(local port) to send notifications to the > +remote guest. > + > +There is no need to describe the static event channel info in the domU device > +tree. Static event channels are only useful in fully static configurations, > +and in those configurations, the domU device tree dynamically generated by Xen > +is not needed. > + > +To enable the event-channel interface for domU guests include the > +"xen,enhanced = "no-xenstore"" property in the domU Xen device tree node. double "" > + > +Under the "xen,domain" compatible node for domU, there needs to be sub-nodes > +with compatible "xen,evtchn" that describe the event channel connection > +between two domUs. For dom0, there needs to be sub-nodes with compatible > +"xen,evtchn" under the chosen node. > + > +The static event channel node has the following properties: > + > +- compatible > + > + "xen,evtchn" > + > +- xen,evtchn > + > + The property is tuples of two numbers > + (local-evtchn link-to-foreign-evtchn) where: > + > + local-evtchn is an integer value that will be used to allocate local port > + for a domain to send and receive event notifications to/from the remote > + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. > + It is recommended to use low event channel IDs. > + > + link-to-foreign-evtchn is a single phandle to a remote evtchn to which > + local-evtchn will be connected. > + > +Example > +======= > + > +chosen { > + > + /* one sub-node per local event channel */ It would be good to say that this is for dom0 in the comment, e.g.: /* this is for Dom0 */ > + ec1: evtchn@1 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec2>; > + }; > + > + domU1 { > + compatible = "xen,domain"; > + #address-cells = <0x2>; > + #size-cells = <0x1>; > + xen,enhanced = "no-xenstore"; > + > + /* one sub-node per local event channel */ > + ec2: evtchn@2 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec1>; > + }; > + > + ec3: evtchn@3 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xb &ec5>; > + }; > + > + ec4: evtchn@4 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xc &ec6>; > + }; > + }; > + > + domU2 { > + compatible = "xen,domain"; > + #address-cells = <0x2>; > + #size-cells = <0x1>; > + xen,enhanced = "no-xenstore"; > + > + /* one sub-node per local event channel */ > + ec5: evtchn@5 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xb &ec3>; > + }; > + > + ec6: evtchn@6 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xd &ec4>; > + }; > + }; > +}; From xen-devel-bounces@lists.xenproject.org Tue Sep 06 22:55:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 22:55:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400674.642297 (Exim 4.92) (envelope-from ) id 1oVhTV-0004fK-UA; Tue, 06 Sep 2022 22:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400674.642297; Tue, 06 Sep 2022 22:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhTV-0004fD-RB; Tue, 06 Sep 2022 22:55:21 +0000 Received: by outflank-mailman (input) for mailman id 400674; Tue, 06 Sep 2022 22:55:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhTV-0004f3-8M; Tue, 06 Sep 2022 22:55:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhTV-0006tj-45; Tue, 06 Sep 2022 22:55:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhTU-0004hS-LF; Tue, 06 Sep 2022 22:55:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVhTU-0002SF-Km; Tue, 06 Sep 2022 22:55:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Lf9uwMJ4jL4+zMVBuGs5+R7Hn+/3LBJMto/VW2YzVqA=; b=zcNEIFfSjQu2ELPW55cnusJMpV cenJx0qtWjp4HGnQJjnIOc9q7K6yWQXutkuGQ9sgsP33SJDZkzprPGt6d5t3/hucgiziHDhZpFQQx BTQFDLAzKy7JQqAgxYf3fTicdGN9NkCQoXzYqViv18Xn/W5X7oR5kzoWEbdSaDugKVmg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173022: FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-migrupgrade::broken:regression xen-unstable:test-amd64-amd64-migrupgrade:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d84473689611eed32fd90b27e614f28af767fa3f X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Tue, 06 Sep 2022 22:55:20 +0000 flight 173022 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173022/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade broken in 173004 Tests which are failing intermittently (not blocking): test-amd64-amd64-migrupgrade 6 host-install/src_host(6) broken in 173004 pass in 173022 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 173004 pass in 173022 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173004 pass in 173022 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 173004 test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 173013 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172993 build-i386-libvirt 6 libvirt-build fail like 172993 build-arm64-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172993 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172993 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172993 build-armhf-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen d84473689611eed32fd90b27e614f28af767fa3f baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172993 2022-09-05 01:52:22 Z 1 days Testing same since 173004 2022-09-05 14:38:21 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-migrupgrade broken Not pushing. ------------------------------------------------------------ commit d84473689611eed32fd90b27e614f28af767fa3f Author: Juergen Gross Date: Mon Sep 5 09:00:05 2022 +0200 xen/sched: fix cpu hotplug Cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() with interrupts disabled, thus any memory allocation or freeing must be avoided. Since commit 5047cd1d5dea ("xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()") this restriction is being enforced via an assertion, which will now fail. Fix this by allocating needed memory before entering stop_machine_run() and freeing any memory only after having finished stop_machine_run(). Fixes: 1ec410112cdd ("xen/sched: support differing granularity in schedule_cpu_[add/rm]()") Reported-by: Gao Ruifeng Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper commit d42be6f83480b3ada286dc18444331a816be88a3 Author: Juergen Gross Date: Mon Sep 5 09:00:04 2022 +0200 xen/sched: carve out memory allocation and freeing from schedule_cpu_rm() In order to prepare not allocating or freeing memory from schedule_cpu_rm(), move this functionality to dedicated functions. For now call those functions from schedule_cpu_rm(). No change of behavior expected. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper Reviewed-by: Andrew Cooper commit a83fa1e2b96ace65b45dde6954d67012633a082b Author: Juergen Gross Date: Mon Sep 5 09:00:03 2022 +0200 xen/sched: introduce cpupool_update_node_affinity() For updating the node affinities of all domains in a cpupool add a new function cpupool_update_node_affinity(). In order to avoid multiple allocations of cpumasks carve out memory allocation and freeing from domain_update_node_affinity() into new helpers, which can be used by cpupool_update_node_affinity(). Modify domain_update_node_affinity() to take an additional parameter for passing the allocated memory in and to allocate and free the memory via the new helpers in case NULL was passed. This will help later to pre-allocate the cpumasks in order to avoid allocations in stop-machine context. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Acked-by: Andrew Cooper Tested-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Sep 06 23:02:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 06 Sep 2022 23:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400686.642307 (Exim 4.92) (envelope-from ) id 1oVhaD-0006Ki-OR; Tue, 06 Sep 2022 23:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400686.642307; Tue, 06 Sep 2022 23:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhaD-0006Kb-Lo; Tue, 06 Sep 2022 23:02:17 +0000 Received: by outflank-mailman (input) for mailman id 400686; Tue, 06 Sep 2022 23:02:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhaC-0006KP-QI; Tue, 06 Sep 2022 23:02:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhaC-00073o-LR; Tue, 06 Sep 2022 23:02:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVhaC-0005M8-9i; Tue, 06 Sep 2022 23:02:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVhaC-0006UI-9E; Tue, 06 Sep 2022 23:02:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fn6B31UmqpC3T0tB7t7EivFWMkLeTo9geMEMfkjNbNk=; b=n/qIx52nsvzqTNOeVp/NqYfG5A sNTbNvnv3AEOjHMCw2LgMkpQW6xatdoNYPiJ0Xui9JtRendLLRvimZLlaIASBY/oob/LrT8CEEUQe za3v4lYeZlMbX73cEyG6zuaANMTn9zE4z5PKPUrztycIhkKeqGB/i2bW4QYTg1BiyMBk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173028: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=5eeb088ad64124229b32a5593fada578b935e207 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 06 Sep 2022 23:02:16 +0000 flight 173028 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173028/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 5eeb088ad64124229b32a5593fada578b935e207 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 32 days 255 attempts Testing same since 173028 2022-09-06 18:10:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2086 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 01:44:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 01:44:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400706.642319 (Exim 4.92) (envelope-from ) id 1oVk6S-0004nX-M0; Wed, 07 Sep 2022 01:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400706.642319; Wed, 07 Sep 2022 01:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVk6S-0004nP-Fv; Wed, 07 Sep 2022 01:43:44 +0000 Received: by outflank-mailman (input) for mailman id 400706; Wed, 07 Sep 2022 01:43:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVk6R-0004nJ-VD for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 01:43:44 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 803c38d4-2e4e-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 03:43:42 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D17706168D; Wed, 7 Sep 2022 01:43:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD0E7C433D7; Wed, 7 Sep 2022 01:43:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 803c38d4-2e4e-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662515020; bh=pIQ7CzoQIWvBC9kI0XwUVB0Gk6PP72e9L19w0qI7g7w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=qtUtHW2nAAzZxAeEZ6GLGeZ6u7fN+mCil43a3fW6myNduT8qpcRSKRkKDoAZiDty8 myiIqFSbVMp6AREvZ65ub+Lo3MH1FusnQFY6EdwF1xsF+kFh3QVG6VVpYiz6g7NDGw hVdyevZwpo6qRulFIFnA8CC2nK1CMgLe69JpXigaNY0M44XyF6dVcTW/23Z/Upnv2Y 06glFz8ckcnYi2pZ71e7RUrV9m3dZescd1JAcL2kd4V4wvtfBYAY/xt8MiFHVgpTv8 3VDFxc28X5Ei+MD8PvciwuhlQ7t4WEXFv3XQ1OwszVxdib7fKg2R//oFOjJUTbIuaI jJAEc7j32M7og== Date: Tue, 6 Sep 2022 18:43:38 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder] Add support for Xen boot-time cpupools In-Reply-To: <20220906111214.26912-1-michal.orzel@amd.com> Message-ID: References: <20220906111214.26912-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 6 Sep 2022, Michal Orzel wrote: > Introduce support for creating boot-time cpupools in the device tree and > assigning them to dom0less domUs. Add the following options: > - CPUPOOL[number]="cpu1_path,...,cpuN_path scheduler" to specify the > list of cpus and the scheduler to be used to create cpupool > - NUM_CPUPOOLS to specify the number of cpupools to create > - DOMU_CPUPOOL[number]="" to specify the id of the cpupool to > assign to domU > > Example usage: > CPUPOOL[0]="/cpus/cpu@1,/cpus/cpu@2 null" > DOMU_CPUPOOL[0]=0 > NUM_CPUPOOLS=1 > > The above example will create a boot-time cpupool (id=0) with 2 cpus: > cpu@1, cpu@2 and the null scheduler. It will assign the cpupool with > id=0 to domU0. > > Signed-off-by: Michal Orzel Great patch in record time, thanks Michal! On the CPUPOOL string format: do you think we actually need the device tree path or could we get away with something like: CPUPOOL[0]="cpu@1,cpu@2 null" All the cpus have to be under the top-level /cpus node per the device tree spec, so maybe the node name should be enough? > --- > README.md | 10 +++++ > scripts/uboot-script-gen | 80 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+) > > diff --git a/README.md b/README.md > index bd9dac924b44..44abb2193142 100644 > --- a/README.md > +++ b/README.md > @@ -181,6 +181,9 @@ Where: > present. If set to 1, the VM can use PV drivers. Older Linux kernels > might break. > > +- DOMU_CPUPOOL[number] specifies the id of the cpupool (created using > + CPUPOOL[number] option, where number == id) that will be assigned to domU. > + > - LINUX is optional but specifies the Linux kernel for when Xen is NOT > used. To enable this set any LINUX\_\* variables and do NOT set the > XEN variable. > @@ -223,6 +226,13 @@ Where: > include the public key in. This can only be used with > FIT_ENC_KEY_DIR. See the -u option below for more information. > > +- CPUPOOL[number]="cpu1_path,...,cpuN_path scheduler" > + specifies the list of cpus (separated by commas) and the scheduler to be > + used to create boot-time cpupool. If no scheduler is set, the Xen default > + one will be used. > + > +- NUM_CPUPOOLS specifies the number of boot-time cpupools to create. > + > Then you can invoke uboot-script-gen as follows: > > ``` > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 18c0ce10afb4..2e1c80a92ce1 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -176,6 +176,81 @@ function add_device_tree_static_mem() > dt_set "$path" "xen,static-mem" "hex" "${cells[*]}" > } > > +function add_device_tree_cpupools() > +{ > + local num=$1 > + local phandle_next="0xfffffff" I think phandle_next is a good idea, and I would make it a global variable at the top of the uboot-script-gen file or at the top of scripts/common. The highest valid phandle is actually 0xfffffffe. > + local cpus > + local scheduler > + local cpu_list > + local phandle > + local cpu_phandles > + local i > + local j > + > + i=0 > + while test $i -lt $num I don't think there is much value in passing NUM_CPUPOOLS as argument to this function given that the function is also accessing CPUPOOL[] directly. I would remove $num and just do: while test $i -lt $NUM_CPUPOOLS > + do > + cpus=$(echo ${CPUPOOL[$i]} | awk '{print $1}') > + scheduler=$(echo ${CPUPOOL[$i]} | awk '{print $NF}') > + cpu_phandles= > + > + for cpu in ${cpus//,/ } > + do > + # check if cpu exists > + if ! fdtget "${DEVICE_TREE}" "$cpu" "reg" &> /dev/null > + then > + echo "$cpu does not exist" > + cleanup_and_return_err > + fi > + > + # check if cpu is already assigned > + if [[ "$cpu_list" == *"$cpu"* ]] > + then > + echo "$cpu already assigned to another cpupool" > + cleanup_and_return_err > + fi > + > + # set phandle for a cpu if there is none > + if ! phandle=$(fdtget -t x "${DEVICE_TREE}" "$cpu" "phandle" 2> /dev/null) > + then > + phandle=$(printf "0x%x" $phandle_next) > + phandle_next=$(( $phandle_next -1 )) > + fi > + > + dt_set "$cpu" "phandle" "hex" "$phandle" > + cpu_phandles="$cpu_phandles $phandle" > + cpu_list="$cpu_list $cpu" > + done > + > + # create cpupool node > + phandle="$(printf "0x%x" $phandle_next)" > + phandle_next=$(( $phandle_next -1 )) > + dt_mknode "/chosen" "cpupool_$i" > + dt_set "/chosen/cpupool_$i" "phandle" "hex" "$phandle" > + dt_set "/chosen/cpupool_$i" "compatible" "str" "xen,cpupool" > + dt_set "/chosen/cpupool_$i" "cpupool-cpus" "hex" "$cpu_phandles" > + > + if test "$scheduler" != "$cpus" > + then > + dt_set "/chosen/cpupool_$i" "cpupool-sched" "str" "$scheduler" > + fi > + > + j=0 > + while test $j -lt $NUM_DOMUS > + do > + # assign cpupool to domU > + if test "${DOMU_CPUPOOL[$j]}" -eq "$i" > + then > + dt_set "/chosen/domU$j" "domain-cpupool" "hex" "$phandle" > + fi > + j=$(( $j + 1 )) > + done > + > + i=$(( $i + 1 )) > + done > +} > + > function xen_device_tree_editing() > { > dt_set "/chosen" "#address-cells" "hex" "0x2" > @@ -252,6 +327,11 @@ function xen_device_tree_editing() > fi > i=$(( $i + 1 )) > done > + > + if test "$NUM_CPUPOOLS" && test "$NUM_CPUPOOLS" -gt 0 > + then > + add_device_tree_cpupools "$NUM_CPUPOOLS" > + fi > } > > function linux_device_tree_editing() > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 01:50:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 01:50:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400713.642330 (Exim 4.92) (envelope-from ) id 1oVkCc-0006Do-7s; Wed, 07 Sep 2022 01:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400713.642330; Wed, 07 Sep 2022 01:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVkCc-0006DN-5D; Wed, 07 Sep 2022 01:50:06 +0000 Received: by outflank-mailman (input) for mailman id 400713; Wed, 07 Sep 2022 01:50:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVkCa-00061n-Jq; Wed, 07 Sep 2022 01:50:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVkCa-0000Qc-GO; Wed, 07 Sep 2022 01:50:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVkCZ-0007Xt-Ul; Wed, 07 Sep 2022 01:50:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVkCZ-0002Er-U7; Wed, 07 Sep 2022 01:50:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lf/sufDVhVMGqHWJx/pyUqtTBFw+gVO7VRTv2A+wCCM=; b=LVvYrLeT9DTYZzbzVBlqf7VR+T HRzK7eCOK7FaO+0MoxdDP40neHdnE5smQiPcdjlq8IBn5IUrlvVua6hhiwzPC62t6egsAvnn0yx2A FoHD/eZq41akQ1h/Ikzo8WfvQYTLaNL5nAVuMNY8DNcB7KgyOlUVsQpnzn0hdR0V6UXs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173032: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=5eeb088ad64124229b32a5593fada578b935e207 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 01:50:03 +0000 flight 173032 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173032/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 5eeb088ad64124229b32a5593fada578b935e207 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 32 days 256 attempts Testing same since 173028 2022-09-06 18:10:54 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2086 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 01:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 01:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400721.642341 (Exim 4.92) (envelope-from ) id 1oVkEp-0006rk-Lg; Wed, 07 Sep 2022 01:52:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400721.642341; Wed, 07 Sep 2022 01:52:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVkEp-0006rd-Ii; Wed, 07 Sep 2022 01:52:23 +0000 Received: by outflank-mailman (input) for mailman id 400721; Wed, 07 Sep 2022 01:52:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVkEo-0006rX-1e for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 01:52:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b541c14d-2e4f-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 03:52:20 +0200 (CEST) Received: from DB6PR0802CA0046.eurprd08.prod.outlook.com (2603:10a6:4:a3::32) by VI1PR08MB5376.eurprd08.prod.outlook.com (2603:10a6:803:13e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 01:52:08 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::71) by DB6PR0802CA0046.outlook.office365.com (2603:10a6:4:a3::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 01:52:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 01:52:07 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 01:52:07 +0000 Received: from 242bada1413d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FAA7F4A4-75DE-4C1F-BEED-D91DA6774E46.1; Wed, 07 Sep 2022 01:51:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 242bada1413d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 01:51:59 +0000 Received: from VI1PR08MB4541.eurprd08.prod.outlook.com (2603:10a6:803:f9::15) by DB9PR08MB6555.eurprd08.prod.outlook.com (2603:10a6:10:257::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 01:51:55 +0000 Received: from VI1PR08MB4541.eurprd08.prod.outlook.com ([fe80::6c0f:3fa7:3279:802d]) by VI1PR08MB4541.eurprd08.prod.outlook.com ([fe80::6c0f:3fa7:3279:802d%2]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 01:51:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b541c14d-2e4f-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lhqrgkjGTtYacmPQGIBqtiHQ919KU/0JyGGsLrT53PKKg5pK9qa174p0WsQjDgLwAgXOOhVFY6SvJG+hmkCvaPk3e2lWS2DITs00cuAE78M5cAabTMNqYUHDU8QekiS0nFIJpMO2WclUTeaqPmvNHWNoMlOr0oRtyuH3gW6q7jyTThegzKzaifdi59axnogt6v+eoG4pZulAgiiCWmc6xe4QbJLuunEsTmUZTBdIyugICV0eUZW9TgZN4wIZGWWYDRQrctBcmMapDpSMukRY2bZDYa8rZs39XvVkmgPiBgb8dh3jrZkgnOsw6fxa63ojh/uG9o2pyFcybvDorctlgw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HE9saJQTobUGhxaXnO3gVZQOTovetEBZrp3nW3mrBo=; b=RwcNvGhyKq7bq6LPElydsVERykJWy5NOnxwUW6SisElHKBkjgLMh5xPeKS6UUXjImuO7oqN+3ouKppBIK7ukDmyguzo8PVwW1To6iTonv3p9vz71lk5juyY+EChYGloLqmyu9/R0bEtKOZIarhdE9txQHMn0Bkw76ExTSSRz2mzVvDCAcUqA0v0t1NwwBvWKmouw+Ng77w/M369JaLZ8rso5dW4adfJWtX30rFdUtMtBShNE6YY8/ERDiKUp34Cl0EgxHBJ/SYE/Slg9brcKub95o04PQgGdrS9B25q+24/lW7iXlxmviIpoamtnRkE5YS0q+tP9Ebl7Wr5ePqEmGg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HE9saJQTobUGhxaXnO3gVZQOTovetEBZrp3nW3mrBo=; b=naSz46mPVrZOPR2pnoOfXxCSsUThe1DIOwe9dkhlhzs95+FDf78CHJHolXLOUFZwnTQlHw0j8AAtROle5BPAk5oUwlm+M70ujnUMYW5wa/B5goHGLy3m8ctHqaJO1XQzON2BD4r/oVG5imCR/3cFie6WY+WYsSFtDdFMsq/iDug= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jfZC/KJI0XiAk3M0JW+2aVH6TH+L9tn8a1lA/jTytwQhWVPozRmEH0Aw1GFtIslBKbUu2Z5GlE0OMS8m5bYrnjjZSWhpQcMbzDf2GnjRqzgZMm57Yn0V0H5kOCwIAV+qwIq4jXw383izcCHHs0ltjB9q+R9LcNmvutOPTBx5U4hoC0EwbtW8CFzE7+Zci6bMvalAd9UVi54/ImgbYE7V1UDHy9AVwF3IiHL0NDs0c9xVtgJL3FOjfvuMamSZRTPLS2H5+Qjma0vS/q+/dlHsyI5LUdlCN8M6PTJ6C9nqtVt5Wn40Fh55jYQnxw4Br2cY+xAZ8U4unIiWWvF8y2+Apg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HE9saJQTobUGhxaXnO3gVZQOTovetEBZrp3nW3mrBo=; b=TC2rrQhEL49YPxFwWc61uSzu/VyUlB9j/fj9w9T+j0flk3mXHKhMoiOMMXd373gv1f+qZa9s70gJm0Z629u/F/pVNTqJAhNZ2ssgAG7qNMfrXaBJrr1B571MnILs4UI4/7o+uri5d+SkOI/bT864vdQ12Gji6MBlswEs1XE7wmsYOS1CGC3SAtIbeeuttadWRdMY9IBVYiR9AtbaOZVxONSGxBREMorrZm/91Nb14s+kXajdktzPkIA+hpyEZXm/nIC9yVytRRHc40y4XJLFb4zxDeIBgsn+bl6ks1aVlL3duAWudBw8/qJ/bBBKfi/oQE+1d2DtjSKTbkWOK8v+Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HE9saJQTobUGhxaXnO3gVZQOTovetEBZrp3nW3mrBo=; b=naSz46mPVrZOPR2pnoOfXxCSsUThe1DIOwe9dkhlhzs95+FDf78CHJHolXLOUFZwnTQlHw0j8AAtROle5BPAk5oUwlm+M70ujnUMYW5wa/B5goHGLy3m8ctHqaJO1XQzON2BD4r/oVG5imCR/3cFie6WY+WYsSFtDdFMsq/iDug= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: RE: [PATCH v7 1/9] xen/arm: introduce static shared memory Thread-Topic: [PATCH v7 1/9] xen/arm: introduce static shared memory Thread-Index: AQHYwc8YBf6RzKF49UaCIf2FqNDCyq3SsZmAgACDQLA= Date: Wed, 7 Sep 2022 01:51:52 +0000 Message-ID: References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-2-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4530EDB4B31BD24FA2F91269C60EABDC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 899befaf-ed3e-4b25-435c-08da90739269 x-ms-traffictypediagnostic: DB9PR08MB6555:EE_|DBAEUR03FT033:EE_|VI1PR08MB5376:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BLClUycMK30LbYPUVVF3PaVBthmlOJsAclLDzoyGkziR57h3/lf8UT6IL/CE8f9cHWIJgPB41DhysRXZFUdNMWQimZsqSZQZNIXLWWU11rstUnlVTOto7Dwuic4uMGU4a7r6EtbmE8cVQkmWXT9nDztBSWq0/OGGtFUTruO6usL5lQzKfJoLk2seaOvWq0nuPM0bIrbUg0/3DGzOiWk/dpxwyJkJfHUiWy/3aGd15FeXB+Ugi5kJ9qjXPXLFZ12abwlC21ws3pUWb7loi6yo/3nLa4UqYkJrIR921QJ2MotTi+lGbNKjHZXYXPFfRDa3MbtNZZf2irFk5yNTjjJyqcPFUQfePrH10bMP2eqw2N18SK3NPXLiF6tkse9yf8ScOZUn/PsSHmXKl7wQuLn6g4e1mAv1J9PaceA8LC8uHltc/3dBxmF7CTcjlkZ4/V+bV3O5TTPQRHdNyxYOtbsE+dm4X+lfPfyIYWvJwoGMpj2ICOhKGTb+/HIoAGbiPxQ60oP8jeA7EK91uHzM+WQKcq871pIMTj3ioI7uPIA4XlxFFgzb9gN3B5pKVMfu4pzEbnUgc+74SMutAb1ndw03y1wwfw3vAJZpzCEsXpieFbw9Hmtbgs56FngiKDjooNIus4BQYEwcthPf9swIMW50+Xq2abJn74E7X6ZNFkiomKDV0T26hiAvIEVIDVIs3s9K7e5bKHlSaVeL4W0zkGac9wI9BPdAua6MlVU2rQjXpI6+RVCOeY4ouzqRzvDg+0vENtUSiCFPRvNR4C8zu6gREl05wP4FZ21EN7X2AByGAoX4LVAF3GzQUAVw+cHVehYeYAnBLJpa6RXmXxboOrczgjdM9d1CjgUDzxvdBsiGuXU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB4541.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(38070700005)(83380400001)(33656002)(76116006)(122000001)(66556008)(2906002)(66446008)(38100700002)(4326008)(8676002)(64756008)(66946007)(66476007)(186003)(5660300002)(52536014)(316002)(8936002)(86362001)(966005)(478600001)(9686003)(6506007)(55016003)(41300700001)(53546011)(71200400001)(7696005)(26005)(110136005)(54906003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6555 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 854dcd8c-dfad-44eb-8eb6-08da90738991 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UMJPP3L8+3tPWVYIwLF1GCkivSc/0mzhS0STBElEwc4CEHkcsCcf/sbnQ3wI0Pc7TXFD4mAZCoSM8J3gGBFucmApUqtsdUIWHZ19E9ex5MnmHFLLeSQ44R26iseUFlAguFse12Asnmmo1PojDNXZ5728BA1ks3HC0q8tanDio6huwsLqvHIZ45iK/R8oddUE9S8AFv8pFKYMtKrII0VLB+XflDZPoCrqYs6B85lO82AVC/8Vv6RTUomMmndKyF5X16sVH0PY1FbCyE6W2wsu2EdP8kyAOzRfTBIgnDRBeKuXNw4ZOJ+T58nY1JAGPBTQIlaXNM9uukapiofeLbFtQy6kGKrlg5tGUiD9LeSSAoV/dKEoDpoMJkNB9dnEK9Im2pCJrzzizbRec4ZOZagmxDpO1/K3DVA4m4TimYzx1x4MwbRrON6/MrRulbLFJDu2k119yVd4pXvCjLcMJVbkW/CrjYoyHAuLRoLrHdkSlip7J3koXJh1XzGUq6pE0Pkm2cIQsYol8XC7WX+zaXyiA73gtS47k20fEv1thVnHrMRz/UTV8THTxWZ/LxlyfP7kjcx88GbCoxYFf4lmvoL2IU6iuiUSuszKD/VKMWDSQhEkBQ4/o7FzxbEbeSjv92ltba+M8k7UV7roLjmdkzA6l3W1Vz/cp9kYjBCH5koZFlaTF4sKd8LqIbaAowNbVKRtVm15KRhsL1m5WvpzkZPMa0uFzgEZThYghdszM54NmDBRopX1ACZX6Ha84qLhnYX1T1AzmZ0TgrV3300Jp/GU5iY52YD7yPm2U96q15y5DWE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(39860400002)(46966006)(36840700001)(40470700004)(356005)(40460700003)(81166007)(70586007)(82740400003)(36860700001)(8676002)(4326008)(110136005)(70206006)(82310400005)(316002)(83380400001)(40480700001)(2906002)(52536014)(55016003)(5660300002)(8936002)(41300700001)(9686003)(186003)(47076005)(336012)(26005)(478600001)(966005)(53546011)(6506007)(54906003)(7696005)(33656002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 01:52:07.8357 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 899befaf-ed3e-4b25-435c-08da90739269 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5376 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgNywg MjAyMiAyOjAxIEFNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFy bS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBC ZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIg QmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBIZW5yeSBXYW5nDQo+IDxIZW5y eS5XYW5nQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjcgMS85XSB4ZW4vYXJtOiBp bnRyb2R1Y2Ugc3RhdGljIHNoYXJlZCBtZW1vcnkNCj4gDQo+IEhpIFBlbm55LA0KPiANCj4gT24g MDYvMDkvMjAyMiAwOTo1OSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gICBzdGF0aWMgaW50IF9f aW5pdCBlYXJseV9zY2FuX25vZGUoY29uc3Qgdm9pZCAqZmR0LA0KPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGludCBub2RlLCBjb25zdCBjaGFyICpuYW1lLCBpbnQgZGVw dGgsDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTMyIGFkZHJlc3Nf Y2VsbHMsIHUzMiBzaXplX2NlbGxzLA0KPiA+IEBAIC0zODYsNiArNTQ5LDggQEAgc3RhdGljIGlu dCBfX2luaXQgZWFybHlfc2Nhbl9ub2RlKGNvbnN0IHZvaWQgKmZkdCwNCj4gPiAgICAgICAgICAg cHJvY2Vzc19jaG9zZW5fbm9kZShmZHQsIG5vZGUsIG5hbWUsIGFkZHJlc3NfY2VsbHMsIHNpemVf Y2VsbHMpOw0KPiA+ICAgICAgIGVsc2UgaWYgKCBkZXB0aCA9PSAyICYmIGRldmljZV90cmVlX25v ZGVfY29tcGF0aWJsZShmZHQsIG5vZGUsDQo+ICJ4ZW4sZG9tYWluIikgKQ0KPiA+ICAgICAgICAg ICByYyA9IHByb2Nlc3NfZG9tYWluX25vZGUoZmR0LCBub2RlLCBuYW1lLCBhZGRyZXNzX2NlbGxz LA0KPiA+IHNpemVfY2VsbHMpOw0KPiA+ICsgICAgZWxzZSBpZiAoIGRlcHRoIDw9IDMgJiYgZGV2 aWNlX3RyZWVfbm9kZV9jb21wYXRpYmxlKGZkdCwgbm9kZSwNCj4gInhlbixkb21haW4tc2hhcmVk LW1lbW9yeS12MSIpICkNCj4gPiArICAgICAgICByYyA9IHByb2Nlc3Nfc2htX25vZGUoZmR0LCBu b2RlLCBhZGRyZXNzX2NlbGxzLCBzaXplX2NlbGxzKTsNCj4gPg0KPiA+ICAgICAgIGlmICggcmMg PCAwICkNCj4gPiAgICAgICAgICAgcHJpbnRrKCJmZHQ6IG5vZGUgYCVzJzogcGFyc2luZyBmYWls ZWRcbiIsIG5hbWUpOyBkaWZmIC0tZ2l0DQo+ID4gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v c2V0dXAuaA0KPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gaW5kZXgg NTgxNWNjZjhjNS4uOTk1ZWVlMWQwOSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5j bHVkZS9hc20vc2V0dXAuaA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1 cC5oDQo+ID4gQEAgLTIzLDEwICsyMywxNyBAQCB0eXBlZGVmIGVudW0gew0KPiA+ICAgfSAgYm9v dG1vZHVsZV9raW5kOw0KPiA+DQo+ID4NCj4gPiArLyogSW5kaWNhdGVzIHRoZSBtYXhpbXVtIG51 bWJlciBvZiBjaGFyYWN0ZXJzKFwwIGluY2x1ZGVkKSBmb3Igc2htX2lkDQo+ID4gKyovICNkZWZp bmUgTUFYX1NITV9JRF9MRU5HVEggMTYNCj4gPiArDQo+ID4gICBzdHJ1Y3QgbWVtYmFuayB7DQo+ ID4gICAgICAgcGFkZHJfdCBzdGFydDsNCj4gPiAgICAgICBwYWRkcl90IHNpemU7DQo+ID4gICAg ICAgYm9vbCB4ZW5fZG9tYWluOyAvKiB3aGV0aGVyIHRoZSBtZW1vcnkgYmFuayBpcyBib3VuZCB0 byBhIFhlbg0KPiA+IGRvbWFpbi4gKi8NCj4gPiArI2lmZGVmIENPTkZJR19TVEFUSUNfU0hNDQo+ ID4gKyAgICBjaGFyIHNobV9pZFtNQVhfU0hNX0lEX0xFTkdUSF07DQo+ID4gKyAgICB1bnNpZ25l ZCBpbnQgbnJfc2htX2JvcnJvd2VyczsNCj4gPiArI2VuZGlmDQo+IA0KPiBJIGZvcmdvdCB0byBt ZW50aW9uIHRoYXQgdGhpcyB3aWxsIGNsYXNoIHdpdGggSGVucnkncyBzZXJpZXMgWzFdLiBBcyBi b3RoIHNlcmllcw0KPiBhcmUgbWVhbnQgZm9yIDQuMTcsIHBsZWFzZSBjb29yZGluYXRlIHRvIGRl Y2lkZSB3aGljaCBzZXJpZXMgc2hvdWxkIGJlDQo+IG1lcmdlZCBmaXJzdCAodGhpcyBpcyB0byBh dm9pZCBsYXN0IG1pbnV0ZSBjbGFzaCBvbiBGcmlkYXkpLg0KPiANCg0KSSdsbCBwdXNoIHY4IEFT QVAgd2hlbiBoZW5yeSdzIGNvbW1pdHMgZ2V0IGNvbW1pdHRlZH5+fn4NCg0KPiBDaGVlcnMsDQo+ IA0KPiBbMV0NCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIwOTA1MDcy NjM1LjE2Mjk0LTEtDQo+IEhlbnJ5LldhbmdAYXJtLmNvbS8NCj4gDQo+IC0tDQo+IEp1bGllbiBH cmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 02:56:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 02:56:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400731.642351 (Exim 4.92) (envelope-from ) id 1oVlE9-0005Gr-Aj; Wed, 07 Sep 2022 02:55:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400731.642351; Wed, 07 Sep 2022 02:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVlE9-0005Gk-85; Wed, 07 Sep 2022 02:55:45 +0000 Received: by outflank-mailman (input) for mailman id 400731; Wed, 07 Sep 2022 02:55:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVlE8-0005Ga-GH; Wed, 07 Sep 2022 02:55:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVlE8-00022E-CZ; Wed, 07 Sep 2022 02:55:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVlE7-0001wT-Qc; Wed, 07 Sep 2022 02:55:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVlE7-00072V-QB; Wed, 07 Sep 2022 02:55:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Af7edIF34VSLXEQZD1VBQc6NU/rnfoYRdzDMjyK+JjA=; b=LiBqAJYm+wDGbTQQVgJsqls1hR tkrO60fNLnQAfImSCFJBuBUlRTOwW64FGrVT5KxiSx2acXKIRqVH7yAub0nu9k5hcN9yNyB+vfTA7 b/LpFnLB0RS8dTvW8CSW5m/0h/om6KxRLZDisAAuXj5zzdi52T7/ton5eexnOATTbbXs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173023: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=53e99dcff61e1523ec1c3628b2d564ba15d32eb7 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Wed, 07 Sep 2022 02:55:43 +0000 flight 173023 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173023/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 53e99dcff61e1523ec1c3628b2d564ba15d32eb7 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 33 days Failing since 172152 2022-08-05 04:01:26 Z 32 days 75 attempts Testing same since 173015 2022-09-06 02:36:14 Z 1 days 2 attempts ------------------------------------------------------------ 1699 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 174895 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 03:09:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 03:09:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400740.642362 (Exim 4.92) (envelope-from ) id 1oVlRc-0006zF-Ih; Wed, 07 Sep 2022 03:09:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400740.642362; Wed, 07 Sep 2022 03:09:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVlRc-0006z8-Fe; Wed, 07 Sep 2022 03:09:40 +0000 Received: by outflank-mailman (input) for mailman id 400740; Wed, 07 Sep 2022 03:09:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVlRa-0006yy-UQ for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 03:09:39 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 805a1b24-2e5a-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 05:09:36 +0200 (CEST) Received: from FR3P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::20) by GV2PR08MB8097.eurprd08.prod.outlook.com (2603:10a6:150:75::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 03:09:30 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::58) by FR3P281CA0149.outlook.office365.com (2603:10a6:d10:95::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 03:09:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 03:09:29 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Wed, 07 Sep 2022 03:09:29 +0000 Received: from 380f7bb3f62b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F9A47109-8776-4C56-9B67-B19185259512.1; Wed, 07 Sep 2022 03:09:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 380f7bb3f62b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 03:09:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB9828.eurprd08.prod.outlook.com (2603:10a6:10:45f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13; Wed, 7 Sep 2022 03:09:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 03:09:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 805a1b24-2e5a-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EKspQJ7IzGCOmnCXD4bkOAEuldb2lPX5LlPdvkP2zUM8YQ5L/QpElGlMhA+WgMMPnUmmro0i0/myvLVhkoIPnxNZAQYu8ZdZZXzlQ64KvSEkfTlmHSOgPoZ37PXhGIdxn2WssccEJtBcSCF61vai6po6of6vqRCi5YFwZqTw5POZNh1IPNTUEcKbIDtpyBN/JLhkXI4eEgGzrI8UKBayoa/vEQiCd+VneLRCNHp9fXB1MeRM+HnoGPf+t4FcIBoZ06I/NDIcAxwBro9XuuGMe/Ue/acVjnO4uBJChJYDalOH+eePSos1HTA36B4eT742fKXnBrCYgJg9ql9E6FgEeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nvDLjZV8x2Ckt0IlK6yzfNZtsY7rtC/+LV3YMoaR5Yo=; b=ixfPXI253ejPEj4FwkjtT6ozGB+8LvU0IgrY8Q8lWFpUQ3dnwIzeaHeqQ1yLJD3ndq1CGjNRcQm26INHLnjMjSezwDEK8uQuvHWcX8Sc4ds2Pkd+BuG7f6sg5MNCAY2wif57R+/3ZUXoHZEEcisjijgxh3fAVqBZmrHg0+OaSimHuzGgQ6hzOoUBz3iYWHnWh90GlhXUtII1dFDxfTilJNA6N5MLAcW3EViuXe4OBDq7mJN18Z58UE907Zv44QIj9KCNSc3u95jUeZ+VUhupWeiGN8lEI/leqi5Us//rSoeh9u17my67uKfPIjoHWUq5paxmqjyqGM+hifjExx7asw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nvDLjZV8x2Ckt0IlK6yzfNZtsY7rtC/+LV3YMoaR5Yo=; b=Q54ZWhTgptMIASh1zClf8pOD66YU5767NS/WlaaJS2hLwPAIwMcGdobWMpgPDalCYIVewk73UZqvAMx9/dkx9+l3keeFDAvcsypuBwj07eH3CPnoOAq3RQVVJfFBZ0xm4gWk1ky8QPoAV2t+dt2OPQoh6JDJKPsBh6YbMwhbqrA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqH/fTjCNZ/EWh2jKbJKg4BTwIvEI87d1q/SyUYa1oDpFSR9+yyXnKLO4Yv4kW6YvQ9tZgDZjzT2QyhX6BDgo/D3fWB1YVe16hz+LXoXcW64KRk4cvQzIwQ3QG60nOWPfSX9qMwjqd4TlaYoUD6INNODt4Q2ucWSX8zCmll1lSZBXP8nT+9ikBbsfP7UiUUIxUED67hHmpiRolTucJB3vJMdcOp/yLRmF24K95G2HV4Yd44fDvUWp057x6pgYxN2jN2067zyoSY+KDSebI8r3wf7qL1c7niJgqKn5heVds7/G7VOaF72tlgKxgk4YiYsBZR+uV50pEJs++YBECVRKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nvDLjZV8x2Ckt0IlK6yzfNZtsY7rtC/+LV3YMoaR5Yo=; b=oWO0e/rGDGofh4x7hi9zwd3Ohld/+mB6J7pAMc5wzUzC4qBiHksCAFuAP4SkvRzTDyaxf45ZYwPH3DcUk8b5iLJ+8Cl2myFqiZMu4/RbUZzA9eptNQKfHc75LaZ2Fm7Eb0j8ti9uHVPweXRHIwTCfgq99aposzqtt0DdoNZvA1jPSLmVwzMkVQhKZu9H761T/VWjWiF/qEYIUEiNJbHY6GHVEBJzF3QlEPaxJRsuV3QpciWx8dHIS8ttfGB543XkoCGbaypKcvdXfVg+OuC8UrIqZ0EEp01huGIwGeSzk6gmblVV1iJkR7KodQFv8NLG8UtaW0FwRvQA2TfWyZXG2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nvDLjZV8x2Ckt0IlK6yzfNZtsY7rtC/+LV3YMoaR5Yo=; b=Q54ZWhTgptMIASh1zClf8pOD66YU5767NS/WlaaJS2hLwPAIwMcGdobWMpgPDalCYIVewk73UZqvAMx9/dkx9+l3keeFDAvcsypuBwj07eH3CPnoOAq3RQVVJfFBZ0xm4gWk1ky8QPoAV2t+dt2OPQoh6JDJKPsBh6YbMwhbqrA= From: Henry Wang To: "xen-devel@lists.xenproject.org" , Marc Ungeschikts CC: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: RE: Xen 4.17 release: Current status before the feature freeze Thread-Topic: Xen 4.17 release: Current status before the feature freeze Thread-Index: AdjA2VmJ6EcVoZ5cTOOgVSRHep4cQABjJclQ Date: Wed, 7 Sep 2022 03:09:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EC1756BEEB58CD4BA2EC50FA58518809.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 597f4a35-f234-42c6-4ff3-08da907e6148 x-ms-traffictypediagnostic: DB9PR08MB9828:EE_|VE1EUR03FT016:EE_|GV2PR08MB8097:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sdoWOrmNhKdICSKQAC/Ykl3AE7OfdMDsUhZhnIzwttI9UrIVBasbZ315ig4kxS445OlHC3kvruaihoUJNPt8jWr5RnjTURDU6begoQEVmXjo3/gUrFkthSu50DJ55OWmMuB0W2DUjV2CLWjNZv6gDWJc7CQOwdeuUamLpo14VNoT5T06Wy0nVsdIrHIr1I+BwXEittI9//AcOgWOZlpu3YWYpU3A5+yuEjaBUnzoSuZ3dKrRQvLA7go/+TVGzpVzW1nztji/BjHrSgkrnCtQhTe9qhTDBv4ShUdXOfr4Ze93T0cXMxPOGpvLVZe7VFwFhe5oI0hIQ96lLOlYj22Fn2PD+dF2RkPEKW0rwmXyJnpw47qsHuhk3U3JhmBiF80pmMto39kxX96IyZMcMdK1jefiQiiuv84VQRi9tkNfAnbracaQXE9CpS2GUKAkUTqdA3Nwo1QeJnzGOMnB4iNl1Vn3alW3xNDP2vL5e6K3vcYpnBxkhEfESvWEkiJKUzMWSsJAl9oLwXFlhBKiDrX8cTWhgNs6tfa75vB5SWcRWAo0fwwDWErAe6VqDWJJm4Cgefrn7l5xl54tB1x+ZvEGcd16gtZSTgFGisTp1H5c+iSQtyPn7IQWhiiLHvMuNS5JOH3q+LoIycf7KM3BBcidnfvi66FY3CLw5aSjv8i+7chIjB18Hj7o1TEeuhxnR5YzOuYaRkC1jV4xSRtBWPHkeU/mUccXB9onJOQMlrxDUljukO7QF6sBDsLiwbM3aYNaXe21Aq5Jz4Fi5wNpZq6w3yujY7s54/8Z58681lPWHWdESZZVSM1a/8Ut6Qf5ANuj+i9YqnCErsafGi0boiHD6RIGHTZSOqmrZzceimoPDYo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(8936002)(7416002)(5660300002)(186003)(2906002)(110136005)(55016003)(26005)(9686003)(41300700001)(7696005)(6506007)(33656002)(86362001)(83380400001)(52536014)(966005)(478600001)(71200400001)(38070700005)(8676002)(64756008)(66476007)(66946007)(76116006)(66446008)(54906003)(66556008)(316002)(4326008)(122000001)(38100700002)(134885004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9828 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a9caf962-a561-46fb-4e6f-08da907e58e3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wp9jbpCfrKQbfGzpZQUC+B/gzdecL+r6E5RXNnj2YlBMSa+lFqWWxArKNWFP8/ikZ4kkIE1VCEKkzIHORFmadVIRx1DZroyNOYD8+q3dj4B3q75qwgDCziG3Uu6QLe+Wgcncb95zlcaxWwbMl9/QyT4NKv3Oqh59IoEH3SQrA1lMf5CKt5JZYni/wwi7oPyCDBg+vkxaDgbeGdLV5qer28gMyPkYKLSKsxMoDGTbo3WKWd6dDx7QF02wZo96bMm97dBjRIgwn39+mDwJYszC+ySQ8FGuy4OD55oQbsBaYjxf3pLHTZkQStvJJVtm3lOWoHOgy4UssWKifJfA7UV+hWaLEdU2JUc4GKRSn2Arvn3pwWLIDUzx1IW2jE8qRJaTtkeXI4rYNHwGTkEyRH+vOE1+xXfVqKxj0Fsc4Va1GSIY8cXuV8pxwyG+QXgXzhyi8Rko4YiVo+7TViiRs0PXisHFb+7Oe+AUkRjbt0YVrBMV+oYp/Q+ppWVwZ2N1DAgG57dOAPZsyWb93+U6UWyURD2ISuOzYDSLxnK/No0MUkrLQFFeRInG5dmwWDuFLaxdGUychgdIMd5j8Zp/M4+Ov2HlvlZGh/znQRlvsZrcoeQBR1C4A/JObYA7FkOpxgfIl5FQSHh73q9caXo3U69xGonU/4a2vvT/7mUO/G+fy+hgQoNkS2Q0OARaK8enh3gzqcWUzRa7xmwpTbySSGQuK490muhhRjgKyrm4v63KRn2ilr3yMQ5r9dDm276KqxnOC9ZI2p2a6FttmUXfzg9VhjbC4U3lVlr1Xw8QkZHqNKg5a8BgvgcrBuWubzkYQ1zL7rvM8CD+LKr53UPpj3LMZmPohQn6prQjI5rJgvsRaz0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(40470700004)(46966006)(8676002)(966005)(70586007)(83380400001)(70206006)(4326008)(33656002)(7696005)(6506007)(478600001)(47076005)(107886003)(2906002)(40460700003)(26005)(9686003)(336012)(8936002)(186003)(52536014)(5660300002)(86362001)(41300700001)(82310400005)(81166007)(316002)(55016003)(82740400003)(40480700001)(54906003)(36860700001)(110136005)(356005)(134885004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 03:09:29.7660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 597f4a35-f234-42c6-4ff3-08da907e6148 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8097 Hi all, > -----Original Message----- > Subject: Xen 4.17 release: Current status before the feature freeze >=20 > Hi all, >=20 > As the feature freeze date is around the corner (Sep. 9, 2022) and we are > currently summarizing the series for the release, here are the list of se= ries > pending in the mailing list. Please add the ones that I probably missed. > Thank you very much! >=20 > Also, as agreed from the September community call, the tracking of Xen 4.= 17 > release will happen both in the mailing list and the Gitlab. I will send = the > Gitlab link once the work is done. Thanks! Marc and I have created the Gitlab boards regarding the release. The general board: https://gitlab.com/groups/xen-project/-/boards/4673887?milestone_title=3DRe= lease%204.17 For people's convenience, we have created boards for each class - The blocker list: https://gitlab.com/groups/xen-project/-/boards/4723605?milestone_title=3DRe= lease%204.17&label_name[]=3DPriority%3A%3ARELEASE%20BLOCKER Arm: https://gitlab.com/groups/xen-project/-/boards/4723207?milestone_title=3DRe= lease%204.17&label_name[]=3D%F0%9F%8F%9B%EF%B8%8F%20ARM x86: https://gitlab.com/groups/xen-project/-/boards/4723261?milestone_title=3DRe= lease%204.17&label_name[]=3D%F0%9F%8F%9B%EF%B8%8F%20X86 toolstack: https://gitlab.com/groups/xen-project/-/boards/4726525?milestone_title=3DRe= lease%204.17&label_name[]=3D%F0%9F%92%BBTOOLS Misc (common, driver, CI, etc.): https://gitlab.com/groups/xen-project/-/boards/4723491?milestone_title=3DRe= lease%204.17&label_name[]=3D%F0%9F%92%BB%20MISC Please inform if you find any issues. Thanks. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Wed Sep 07 04:15:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 04:15:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400750.642374 (Exim 4.92) (envelope-from ) id 1oVmSt-0005uG-GR; Wed, 07 Sep 2022 04:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400750.642374; Wed, 07 Sep 2022 04:15:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVmSt-0005u9-DI; Wed, 07 Sep 2022 04:15:03 +0000 Received: by outflank-mailman (input) for mailman id 400750; Wed, 07 Sep 2022 04:15:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVmSr-0005tz-F9; Wed, 07 Sep 2022 04:15:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVmSr-0003Um-DW; Wed, 07 Sep 2022 04:15:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVmSr-00060G-25; Wed, 07 Sep 2022 04:15:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVmSr-0005hG-1a; Wed, 07 Sep 2022 04:15:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pym4BQc4DFDXROQIxS2wm9yGX3mXkMqAa0SYOrtluuE=; b=4c1C9saZoe9jQWw4dILREHZzvH 2bX0O5fPgU4A3oXTI/UrieMk5nZ9zhiV6IH119FLQFn7+lf7d9wRRESF6nHt7g+kGv67C92eU4+oy Cn07sEonxN4H6LMZhR9BiM2Edalj9ZSNS6EXwR+nZoe5C8xutAM224XK0AQPtikzngGY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173033: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=5eeb088ad64124229b32a5593fada578b935e207 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 04:15:01 +0000 flight 173033 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173033/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 5eeb088ad64124229b32a5593fada578b935e207 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 257 attempts Testing same since 173028 2022-09-06 18:10:54 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2086 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 05:13:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 05:13:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400115.642385 (Exim 4.92) (envelope-from ) id 1oVnNB-0004SR-U0; Wed, 07 Sep 2022 05:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400115.642385; Wed, 07 Sep 2022 05:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVnNB-0004SK-O3; Wed, 07 Sep 2022 05:13:13 +0000 Received: by outflank-mailman (input) for mailman id 400115; Tue, 06 Sep 2022 21:39:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVgGa-0000Cs-Hy for xen-devel@lists.xenproject.org; Tue, 06 Sep 2022 21:37:58 +0000 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6992bc6d-2dd9-11ed-af93-0125da4c0113; Tue, 06 Sep 2022 13:45:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6992bc6d-2dd9-11ed-af93-0125da4c0113 Date: Tue, 06 Sep 2022 11:45:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1662464731; x=1662723931; bh=YQDEkl5PHuF3bxc5C85L08mT6YRDC5fd/Vd9AFIe2Zs=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=VvloPzWLu9wmAT6kKEsQ8gqzcB6EFV/Su0wljPgP3MQ5N9k5mKxDtluuFj8c1T7Iz hOcnnncNegigyKsiEtXbBt/QsqtpgUwpRoX2kD+8k2B4k9jjffGQRbFJuvEtdlNgw9 6AvnI0Cxkg6Ii0IHFuVj85aP+DGGuq2I001P7xCsMX1Wa4Ox6zEaSz5Y7nmUWg2OCl WHTXWkk1GXzPi21AlHcKBbSp6z+bnakuDdPsbciqa3j9em7rPt00B7SmpCWmEJzBTU JAP9wvAoEGIdYUfTEDrMkzy0YfeHMdCY0MOZpzVYj2qRnikiq+hwfc7FCp9iZylVxV mjNyDm13Ngefw== To: jbeulich@suse.com From: Dylanger Daly Cc: xen-devel@lists.xenproject.org, Andrew.Cooper3@citrix.com Reply-To: Dylanger Daly Subject: Re: Ryzen 6000 (Mobile) Message-ID: In-Reply-To: <0fb4cab5-beed-777e-ae58-5d8b79893c30@suse.com> References: <7807b9cf-a09e-a393-ee7a-dc220a68e56e@suse.com> <3b2ad2ca-3c6c-4dcb-c603-bd5440350f20@suse.com> <2dHPPtixTlkUXYEzNPFRI4ezKHSe1A2VaThMjBpd1aM3NFkZQuyRdfmNWCigm1oXfdKhOwDJGoPBBIMLYtYhQlENV2eFVZ0G9EMOMj5e6UE=@protonmail.com> <941ccb01-adf6-d2ef-9a8a-ea8fdfe69ceb@suse.com> <0fb4cab5-beed-777e-ae58-5d8b79893c30@suse.com> Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA" This is a multi-part message in MIME format. --b1_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA Content-Type: multipart/alternative; boundary="b2_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA" --b2_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkgSmFuLAoKU29ycnkgZm9yIHRoZSByb2xsaW5nL3NwYW0gbWFubmVyIEkndmUgYmVlbiBlbWFp bGluZywgbGFzdCBuaWdodCBJIGFjdHVhbGx5IG1hbmFnZWQgdG8gZHJvcCB0aGUgZG9tMC8xIGNv cmUgcGVyIFZNIGlzc3VlIHZpYSBhZGRpbmcgJ3gyYXBpYz1mYWxzZScgdG8gWGVuJ3MgQ01ETElO RSwgSSBvYnNlcnZlZCBYZW4gY29tcGxhaW5pbmcgYWJvdXQgQUNQSS9BUElDIHdoZW4gSSBkcm9w cGVkIHRoZSBgZG9tMF9tYXhfdmNwdXM9MWAsIHBsZWFzZSBzZWUgdGhlIGF0dGFjaGVkIGVycm9y LgoKQWZ0ZXIgcGNpYmFjaydpbmcgdGhlIHRyb3VibGVzb21lIEFNRCBTb3VuZENhcmRzL011bHRp bWVkaWEgQ29udHJvbGxlcnMgSSdtIGhhcHB5IHRvIHNheSB0aGUgZGV2aWNlIGlzIG5vdyBzdGFi bGUgYW5kIEkgY2FuIHJlbGlhYmx5IHVzZSBpdCDwn46JCgpUaGFuayB5b3UgZm9yIGhlbHBpbmcg bWUgdHJvdWJsZXNob290IHRoaXMsIG5leHQgc3RlcHMgd291bGQgYmUgdG8gZmlndXJlIG91dCB0 aGUgc291bmRjYXJkL290aGVyIHdlaXJkIFBDSWUgZGV2aWNlcy4= --b2_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 SGkgSmFuLDxicj48YnI+U29ycnkgZm9yIHRoZSByb2xsaW5nL3NwYW0gbWFubmVyIEkndmUgYmVl biBlbWFpbGluZywgbGFzdCBuaWdodCBJIGFjdHVhbGx5IG1hbmFnZWQgdG8gZHJvcCB0aGUgZG9t MC8xIGNvcmUgcGVyIFZNIGlzc3VlIHZpYSBhZGRpbmcgJ3gyYXBpYz1mYWxzZScgdG8gWGVuJ3Mg Q01ETElORSwgSSBvYnNlcnZlZCBYZW4gY29tcGxhaW5pbmcgYWJvdXQgQUNQSS9BUElDIHdoZW4g SSBkcm9wcGVkIHRoZSBgZG9tMF9tYXhfdmNwdXM9MWAsIHBsZWFzZSBzZWUgdGhlIGF0dGFjaGVk IGVycm9yLjxicj48YnI+QWZ0ZXIgcGNpYmFjaydpbmcgdGhlIHRyb3VibGVzb21lIEFNRCBTb3Vu ZENhcmRzL011bHRpbWVkaWEgQ29udHJvbGxlcnMgSSdtIGhhcHB5IHRvIHNheSB0aGUgZGV2aWNl IGlzIG5vdyBzdGFibGUgYW5kIEkgY2FuIHJlbGlhYmx5IHVzZSBpdCDwn46JPGJyPjxicj5UaGFu ayB5b3UgZm9yIGhlbHBpbmcgbWUgdHJvdWJsZXNob290IHRoaXMsIG5leHQgc3RlcHMgd291bGQg YmUgdG8gZmlndXJlIG91dCB0aGUgc291bmRjYXJkL290aGVyIHdlaXJkIFBDSWUgZGV2aWNlcy48 YnI+PGJyPg== --b2_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA-- --b1_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA Content-Type: image/jpeg; name=PXL_20220905_214013238~2.jpg Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=PXL_20220905_214013238~2.jpg /9j/4QRkRXhpZgAASUkqAAgAAAANAAABBAABAAAAGw8AAAEBBAABAAAAZgUAACgBAwABAAAAAgAA AA8BAgAHAAAAqgAAABABAgAMAAAAsQAAADEBAgAVAAAAvQAAADIBAgAUAAAA0gAAABIBAwABAAAA AQAAABMCAwABAAAAAQAAAGmHBAABAAAA9gAAACWIBAABAAAA2AMAABoBBQABAAAA5gAAABsBBQAB AAAA7gAAAP4DAABHb29nbGUAUGl4ZWwgNiBQcm8ASERSKyAxLjAuNDUwNTk0MjA4emQAMjAyMjow OTowNiAxMjo0Mzo1NQBIAAAAAQAAAEgAAAABAAAAKwA0pAIAJgAAAAADAAAzpAIABwAAACYDAAAn iAMAAQAAACkDAAAiiAMAAQAAAAIAAABgpAMAAQAAAAMAAACdggUAAQAAAC0DAACaggUAAQAAADUD AAAXogMAAQAAAAIAAACSkgIABAAAADIzOAASkAIABwAAAD0DAACRkgIABAAAADIzOAARkAIABwAA AEQDAACQkgIABAAAADIzOAAQkAIABwAAAEsDAAAMpAMAAQAAAAEAAAAKpAMAAQAAAAAAAAAKkgUA AQAAAFIDAAAJkgMAAQAAABAAAAAJpAMAAQAAAAAAAAAIpAMAAQAAAAAAAAAHkgMAAQAAAAIAAAAG pAMAAQAAAAAAAAAGkgUAAQAAAFoDAAAFoAQAAQAAALoDAAAFpAMAAQAAABgAAAAFkgUAAQAAAGID AAAEkAIAFAAAAGoDAAAEkgoAAQAAAH4DAAAEpAUAAQAAAIYDAAADoAMAAQAAAAAMAAADpAMAAQAA AAAAAAADkAIAFAAAAI4DAAADkgoAAQAAAKIDAAACoAMAAQAAAPAPAAACpAMAAQAAAAAAAAACkgUA AQAAAKoDAAABkQcABAAAAAECAwABoAMAAQAAAAEAAAABowcAAQAAAAEAAAABpAMAAQAAAAEAAAAB kgoAAQAAALIDAAAAkAcABAAAADAyMzIAoAcABAAAADAxMDAAAAAAUGl4ZWwgNiBQcm8gYmFjayBj YW1lcmEgNi44MW1tIGYvMS44NQBHb29nbGUAuQAAAGQAAAAQJwAAQEIPACswMTowMAArMDE6MDAA KzAxOjAwAJoaAADoAwAAOAEAAOgDAACyAAAAZAAAADIwMjI6MDk6MDUgMjI6NDA6MTMAAAAAAAYA AAACAQAAZAAAADIwMjI6MDk6MDUgMjI6NDA6MTMAKAAAAGQAAACyAAAAZAAAAJgCAABkAAAAAgAB AAIABAAAAFI5OAACAAcABAAAADAxMDAAAAAAAgAQAAIAAgAAAE0AAAARAAUAAQAAAPYDAAAAAAAA LQAAAAEAAAAGAAABAwABAAAA/gEAAAEBAwABAAAAgAEAAAMBAwABAAAABgAAACgBAwABAAAAAgAA ABoBBQABAAAATAQAABsBBQABAAAAVAQAAAAAAABIAAAAAQAAAEgAAAABAAAA/+AAEEpGSUYAAQEA AAEAAQAA/+ICKElDQ19QUk9GSUxFAAEBAAACGAAAAAACEAAAbW50clJHQiBYWVogAAAAAAAAAAAA AAAAYWNzcAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAPbWAAEAAAAA0y0AAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAJZGVzYwAAAPAAAAB0clhZ WgAAAWQAAAAUZ1hZWgAAAXgAAAAUYlhZWgAAAYwAAAAUclRSQwAAAaAAAAAoZ1RSQwAAAaAAAAAo YlRSQwAAAaAAAAAod3RwdAAAAcgAAAAUY3BydAAAAdwAAAA8bWx1YwAAAAAAAAABAAAADGVuVVMA AABYAAAAHABzAFIARwBCAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABYWVogAAAAAAAAb6IAADj1AAAD kFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9wYXJhAAAAAAAEAAAAAmZm AADypwAADVkAABPQAAAKWwAAAAAAAAAAWFlaIAAAAAAAAPbWAAEAAAAA0y1tbHVjAAAAAAAAAAEA AAAMZW5VUwAAACAAAAAcAEcAbwBvAGcAbABlACAASQBuAGMALgAgADIAMAAxADb/2wBDAAMCAgMC AgMDAwMEAwMEBQgFBQQEBQoHBwYIDAoMDAsKCwsNDhIQDQ4RDgsLEBYQERMUFRUVDA8XGBYUGBIU FRT/2wBDAQMEBAUEBQkFBQkUDQsNFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU FBQUFBQUFBQUFBQUFBT/wAARCAVmDxsDASIAAhEBAxEB/8QAHgAAAgICAwEBAAAAAAAAAAAAAgMA AQQJBQcIBgr/xABMEAABAwIFAgUDAgUCBQMBAREBAAIDBBEFBhIhMQdBCBMiUWEJMnEUgRUjQpGh FlIkM2KxwRdD0VNyGDSC4fEZJfAmRGOSJyg1VHP/xAAcAQEBAQEBAQEBAQAAAAAAAAAAAQIDBAUG Bwj/xAAzEQACAgEEAgMAAgICAgEDBQEAAQIRAwQSITETQRQiUTJhBSNxgTNCkRVSoSQ0Q7HB8f/a AAwDAQACEQMRAD8A18Yg19UXSX3XFtp2MNj95XMy7C7u646cjzdhuvLZ7TKpCIbB3Pus6krGh3Pe yw6UNeADa/us6KiaN1AHIyOlDnMOov5UALW3PfdFPAQ0aeEpziAAgLlfsLIORc/2VucXNAsqLggK IFkl/pKbqvfdKkBG90AEZY1ztR2I3QUUTW+ZDAHVBcft5sseZhdIA11w422XoroT0Yj/AEbcSqYD KZhdocLrrBOT4OWSaijzfWZYq/MdI6GSn1bgBxF1jSZQlpmedJuwnsVtXyD4OsIz1Rtq8aomU7QA WxgWJHus1vg/yFLnAZdgfB6huL6i1fUx4Jvs+Xk1EY80ao6bLUmJ2jpWP19yASs+DIWJ1A8uSCWX SNgWlbLOsv0+sO6b4K7NOB17pXQH1UXl/d+F9z4fvDFgGfMljE8TpPIrGmxYRY/5W/C2t24kNVGP FdmqFvT7E4vScNla0nlBW5AraUAup3Ec6Q03W7HLPhf6Z4lidTQjRW1VP/zI2uF2rlK3w19IsIr4 qSspKeCeQ2jbNIBqP7qxgot2zlPU8XRo1OUamGIvfRzho/6SsrCMDNYXQU8Q1u/3bFbwK3wZdOqt 4fLRtMTjcRtsAV131S+nvlDEcIkrcoUn8OxmIamjV6X/AJC08WKbX37JHWPHxsNQuK5OdQ6W1lKK cnbWBe6yMI6a1WL072YXD/EZbatDG3stunSXwvZHzZlc4RmjCY6jHKV2mouwdvlebqbDsrdBvFDi WBQUTIsCcdDY5OGEn5WJ6fa6vo7Q1inya/8AEMvVWXap0dbTyYfUt2s9lgfwjZWTgB8VpHXsTZbx s9eFzp11pyAHuwikdPUw3jq4WjU0kbFah/Eh4fcZ8OudJKOYOlw6V58qS21uy4Sw742mdVqYqe06 /NRM0DUPV7hfS5MyLVZ3qHRUx1VA3aDwV8k2udJG0FtyRtYLsfozmg5XzJR1s7C6KORpewGxIuvB VcHtk/aOf/8AuZM21EbnyUdmj/awrgcZ6F5qwJvm/wAIqqiH/cyI3W6HoXVZXzXlWimiooJXTRNc A9gdfZfQZhxvJmXs1UGXK3DaaKevYfLJiGj8XX0MMVW2mz52XK48s0QUGRKvFq0UskMsBH3ecLaS uy8K8JGZMwUf6jDWuqGAXuWXC2beITwlZezo+mxPCKVmHVGseY6nYAHi/wALsbCsKyv0N6awVOIR xQU1NEDLLI0XcbL1LFj2Jr3/APJ5ZaycZV+Gj3PvR3NPTiV78WwqopoBsZmxEtK+n6R+Gqr61MDs Hqg9/wDWHi2lbjMrdQemfXzL9Q2Kmw7EKQ3jdDVNZffZeMckZfwzw5+LerwihmimwOtcZW0kbrtZ fsPwuMsdPo6R1jZ55zR4EuoeUvTQ4UK42uHNFwV0Lm3L2aci45/DcfwaTDJybBzm2BX6IcMrqPF8 HbVxQtMOi7bjfhaaPqJdQhmDqh/CoKdkctPJYyBtja624RnjdKmjpiztTSl7PM0eqGQue4OcewWf Cx9VZ5ADAsdslOXadLjIyO7ieLp+XIn11RBT6iP1EmgD8lfNPst8WYlZpfL5bXgfIKe7UyBoMZeO L83Xrzp34IcM6iUQjjqZmYhpD/SdlhdTfpv9Qcn4a7EcGY7E4mi5ib99l3xweTo8zzRj2eS30z5b RDVC1x3I7BerOivgwPWnLMFXheJkPLbF7jtqXReCZExRmLzYZitJLT1jDodG9pDhvZbIPBJkbNGX cEjjhpHNwyF4eXvFtW66PBKL+xwyaiL6Z476w+AXqL0noKjEonMraKEFzntHZdQ9Ksux5ixuOkr/ APmPk8tzTwN7Lej1rcKzpHmV74mkfoZPS4XtstSnRrpFiOP40+Khgca2edz4yBvyvSsCzY7iqafJ 4vlbJ1Jna2J/TPxrH8GjxHAKqItlj8xjS61zbheROsPSzNvRLGv4Vmak/TnVZkg/qHwt53RqlxDA 8g4bheJROZV0kQY9zj93ytev1dIIjjeWC0Bj5Gku+bFcVhtuH4V6txkjwvDVRGIRhoDXC9/dY9U0 McwMedTj+yxqU66QWda3AWXgOEVmZ8XhoKZhMj3AavYLyOPNH2Yy+tnYfRLKeGY9m0Q4uA6mJa0v I4uV7lxD6YmAZ5y9TYjg+LSUL6mMPaf6dwuqeivhfxTFo6WmponsndZxlsRv2WzXpXguN5bydRYV jb4nz0rBEx0Xdo4uvSoPEtzPn5ctukaK+vvQPMXh7zlJgWISuniv/LnIt5jexC+Cj/Uvi8sQOPub LaN4yulNT1j674Fg0dP57o42vGkcD5K57Dvpr5fqqJhxCvdBK4XLYgvdkwQUVJurPFi1jdp80ani +qijYxrHAd9uULnus7zAY79zstmucvpeYfRRPrMIzA+zbuML2f8AlZsH00stZpyW+SorqiHERGdL u2qy8/hjKO5y4PT8unSXJqwAlia9wY6Rg312S6SCnxfE4oo/S4n1gm2y9++Grwm4JivVLG8n49H+ spqJzmknYkBc/wCK3wJZZ6VZehzLlhropGyWlY7i11iWnaltvkq1qauuDmvCf4Xcg9XOnkZr8La+ aNoZI8N3JtyuiPH54I8C6DYfT5ly1UPjoJn6JICdwfhe3/BHllg6fPrsMrmsnLdLowbhrrcldM+P /IubJ6DCGY9irMQw6pqLMhZcBpvxZevBhTn42zw59TKFTSNYeGYXiYjinZHJLDpBALTwnVdLUWMh opGA8l7Stwfh28GmVqrJFBXY7Qsl81gLI7ciy+6xnwo9HMeknwww0cc1rOga9upp/wC64ThGLcUz 0x1jSUpI0dRUlQXXgge89w0cLPGFVtZFplpJY/8Aq0lbVj9N/AMBz/hlXhcxqcHlk/nxuP2DlehH eFPpfg1DqmwGFzGAAki6m2Crc+zT1bkvqjQxV08lAQHOlBb/AEubZU2slewGJtgOdQsVux6teA7p z1OyjJDhmHswmtMZMFTG2xv2utPHV/pTiXRPqdWZZxR5kLHmzz/U2+xSWKEouWN9G8eo3S2zVHyL aZ09YyUPs3vZexvCp4W6nqJU0mIyQeZSvPpuOd+SvJ2H07ZqoxADRdbgPpw1NPV9OXQgATQANJsv PdHpyJ7bR25gnhl6f4FlyCkxbBaKqmayz5JGgH8BeafFX9PXAMSwZ+ZOn1MMPq4R5s1IzcSjvp+V 6J8TOWMx4/UYK7BK11LBG+0wabat12pkWmqaTKVFHXDXNHEA4k3uvfGUseOOa7v0fEk3PI8aPJHh D8IVFg2CxY1mjD2SOkF4qWdtyPkruTPfhw6W9XMNq8KdhlOyriGkSU2zonduF3IyRlfh1R5Z/TgN LQRtb5XR3RTIWNYR1AxjFn1r5MLnkcNJfcOddZU5Tcpp1Xokm4Uv08oYJ9PjFsB6wUcEoZNl8Sav O23aDtde8qbKWSchYRTYbPBQUbQ0NHnNbd/919xKGiduq173BK6P8RPSWTPmKYTXfxJ1EyFwaGh1 gUWR55pPgSUsUW+zqPxYeCrCurVFT45k2hpmYmxwcWRNAbKF9x4VPC/Q9IMsvqcao4ZMVkGpzXNB EY+F3pknAH5YypDSmc1Bhj2ed77LkvOfV4FUSPHludG4bjjZZyZW1sfK/TEMcq3v2fCVOB5B6sUd fg9RheHVrGExSM0N1tPuO4WqTxu+Dio6FZlqMYwguly3WEyROLbeSf8AbdbMehXSYZPzPi+PSYq2 qfXPdaAu+3f8rq76oVIZOgtOQzURWN1EDtY3C7Y2oZfH2mc4yybd91R4q8LPgbl8RGRZcVqp30Q1 aY5mBfL9TPBrjvRTqXhWCVjHVuHVtQIoqojm5C7F8G/jjl6DUNXgWM0EtZl/UXU/6dpc5pA42X1+ fvGGfEX1GytTwYPLh1Bh9YyTXUMs53qWK2za9H0rc4qSPePh96H4F0VyJSOipov1ppmyTz6dxtch fU4dmvJfV6kxHB4JoMXjZeOppnNvo7br6KcR4lk9zY3Hy5qUBrvgt5XT3Rbp3lTJOP1VRl3ERUYl VE/rYg+9jf2XDHHepSb5RxyzcZRhV2dZRdNun/hS6qy5oxOFlFhlYC2CYi7Yyey+vxDxvZYmzLh+ FZbo58bFW4MZJGw7m/tyF899QjAZ8x5VwGip6Z1SP1Q1ANuB7L6Tws+GzCuleWYcZxWCGbF6lgma +RoIpxba1+F6ZKEsccs+2ePfOM3CHo7ezLlzDOpGTKqkzDhkDaephIfHM0Ex3HN+xC0w4Z0Dy/mH xXVuTaWoZPhDKtxBadnC/C9w+NPxeuw3Dq7KOTa1rKh7TFVVjDwOLNK1hZQ6hYxkDqTSZko/Mq8Q hm7ep0ri69kUPHD7ezphc8k7i+jZX1o+mdkmgyPUYvl6nNJW0sAke299VtyuF+nN0Fw6fGMWxnEK Zkww+Ysju0WJHBXxuevHt1bzRkltDLkGqwSinhtLVOY68jbWv+F399NPGjXZJxuB5BqDKJX3Nzcr i90YOz1ybcj0b1N63Zf6SVeGUuMMkArneXH5TeCuL6wdGcteIHJcUWJQNi8wCSCq0jW0H5WF1wjy liWJYdBmBrDPTvD43PHG67RwGegxHL9JLRlr6JsY0FvFgpxihHJDs8qUsspQl16Pk8nZVwXof01i paOG1JQRet7W+qS3dcZ0v6yUXUyqxCkfA+AscRHFIPvYuwsQ/R1mA1f6gB1II3agRtay6j6F4/k/ GcXxSLBIoxWU0ha8t5G+6sanCcpdkmnjnCKfB4g+p94csHykYc84LSx0YqJNNRFELDUe/wC6160D S1j7buk3W376qcB/9A4JGjU81bQW97LUHRR1Qe/y6eWbT6QY2XAXqdZMMZez0aSTxzlBnefhP6c0 edOruDYXiDQ6B0gc5n+63ZbvZ4WZDySxmE0LBHRU4DIGC2wC0j+EbFqjDuuGVJi58Lv1TQ/zGltg St6GN1jKTL1ZVPZ5jWQF5aP6hZeLLDY4r9PZl+51T0Y66SdTsSr8OqcNdSVNO4i5HpIXjj6qHQ7L eEZWjzlQ0opcVmlDZDHs1/uV688POf8AAc5VOLx4dhYoKulkIldosXb+66b+qpg0mJ9APPjNhS1D Xv8AwvXjUY6hQS4Z8bdJ4t8nzZpqoY5ahscz3WA2CzKiN8M7Xdne6XRvNRh0TGD7CTf4RCodVvIH 9PK8OeGybR+jxu4oyANOymyIi0d+4VQu85xsF5LO1CpbAfKxzJqJHICyn2LnD2VUVN5sp91otAU7 JWOvbZZIpzYOdysqIsikMUh3SJHOjmLSdQQchNaBYlNDLi4SgDq37JrHC6FBLNIJPKBwVlxLSQga 4gG+xQjLEnpNggdqO6ptzeyYDdouskQtodfflMfs3V/hRpDifhMuCzjb3QtAB3mAEjhFc9lTDpFg rv6SEJRG2cd+EEkjvM9Me1uUka4pCRvdZbHDRvyQqkVC6aUavVyVkWDnkDeyxGRzRza42g/BTI5J /OJc0An2VKNsOFdrHnZC9ob6u6EfzW3HIQEkN3AK3k9wqF3G52sobEcoAbbq3AE8q7BUAb9kAD2a trq2x2NkRIB4RDjYbIAmi3KXM0gXCZffhLmksQLbIASxwZf4WDL+pv8AyxqK5iOHzISb7pbfQCQN x3QGPHCJoB5uzxyFbQ61vZENy5ysanDbsgDhuB6uU+A6nAfKxxsd+QnRO/ntHAWWDnKdv8sJ7Wm4 uLrHie1nBuewCyml0nZeeR2j0ZLJTs0bBSZxO19kMcRuADyneSAzc7rm2bRhaRqskzMBYbDhZjow RsNwsabU0bWHuqmRnD1rvLYdO5K44uP6Z5IXK1TS82Dd1gzQOYbO2aey7xZyZwzjdvpCJsjmWAP5 TKuLy2nQL3WNG14bqcuq5MDH6pDqVsc1g3PKZHfyeEDqXWwG9rG6rAThYfKWG+6aGm9zuqNrrIGR ENYRypuNwVGAEW4JQ2LL77oT2EBfc7kKO2Fyq1HTsrP23vdBQTd2290D47N54Vst5ZdfcJbZi8O1 bJQ6E7skueCqJ1v23ujMdyLG4QG7JAW8KotmTBHpaT7LIgf2KCjvJG7V3TYIdLueSqDLZDcenk8r I8i7QLcKQMIKy44S9217BcG6NJDYBZgFrW91kC5tfhJbKyQloNnDkJ0QIaQ4brk2dkMeA4AoCDZX qsCFARusAKPbkbeymsO2squLcoOASoBo0t2sqdYFK1kNuU6JwkZY2F0AvUPyqZfh2zSjdENWxupI 7XZpsLIBbmhp2UbcDcqrb+6t1rbICgwN3CoPLT8pjBZp7lC/c7gqpgB13PuOPZZLHta0DusYEsKs OOr4VsDZKhltwklzSERYCDtdKsLW7ogC99mcLBlcXgrMnAZvdcfI8tcDytojMWoLSNJ5WI5lzZ3A CypHt1n3WNJI0ahe/Zd0cGID9r8/KGU+YRc7+6UC9jrf0phsSNtloyESI7DlAWevXe/wo6xKcxrf dALDGlpLkAft6RZPeWtabWKS0g8IAhqcPUd1YFu90LQSDfZHC0PBBKEJcliGNrg/c3CLT7cK2k90 KE+xIHChbe1jsqcPUCrcbcd0BBe9rKx93t7qiPVdW4jkIBM0fmVDSftama2yXDeyJj97Ki0NNwBd AAKgtBaVBMHR27oWM1uN04xNDduUAItI0N4UeNAta6pmxRHe55KASXkG5/smWLWg+6S9rpJBvYLL lbZrRfdAY8twAVVSfIjYeQ5Olbqj23SpR5sbWkfagBLBo1A3CXJbQCEx5IYAEBbqACEsoC4Avyly tAdbiyMyNZZtrlLe69wBv8rSIwHhp77pRa9x34RaHXuSrI1Dm1kIVcMba26IXAFiqmcGMF9kMZJH ugLNy66gYHc8Kw0m6oOsLICX0GzVXliQ3cdyiDiCSdkp8ZcbhyAsnyCW3uCh4N1RaHG5PCIR+q97 3QBxyh7g225Q1Md5dI2sh8sh92mx7I5GOO7jv7oCCBoIsblVLMQCALOCsRkWde6pzA/e+6AqncXg hxsfZEBcWJUDGt37qg70nfdACNj7qi1riSqDnk/HuisB8oZZZc1rR2VjsVTQL7qx6UKiyTb5Ub62 kFQj1XKotJN27IGgWDQbJ0TtIO10pwNxdWARewuECD0i11XlNdcOCjbht0IDr3PdCkbACbXsFbgI CBGLg91ZZr5NkTWhoAvf8oBgYdO5urYy5IKEOueU50jQNhc90KixCBa3KJ0T2t33VQODxzZZDZAR Ym4UZoRZwG/dV5ZB3TjK0tIIF+yU9zmjdQBhoJ4QOuDuqZLumFweON0AGkncbpbQRd3ysuEtOyY6 naWFCoww177u4TRJ6QB93uh1ua7SRZvumMaGgn3QMB0Zeb8lTRa1xwjiu4Ed1b47Ab/lCGHU08ko uwXtyAr8ry2AajfummV8clmHYo2RMeDq7qAqxfTHa/yseG9i0nb3WRJ6QGNPpSnBob6PuVATGFg3 7qOFyq0uABKseo+yywSx4vZWzWH3BsELSHOB7BG5x4AuiATmtLTp5WK2NrS4m9/lZJ2F+6S4ggj3 WgW0nSCAmF7nNGrhCHWaGt5VkEcFAW0DdCz1X3Vg2KjABwgBaSw3IRGMukDg1HG06jqThKQLAIDG 3J9iqIeHW7HumlgLrkoS4hAwQLbWuFRAbeysGziTwhjm84uFtNkBbTturbcKhtcdlAOd7KAGV9iA U1sYBDuyW+MagSU/W0tFxsFLBRLQ7buqnf5DNTTup6C4WCqY6hYjZLKjCD3Sya7WI7plS58sjHHe 3dOEAsC1HIzRH/8AKBivObouRuOAFb3l7BpG5Snbtu0BW0E7/aUIXG18b9+6e1hdudgkCVzXb7qN c4kjsoBgiDybcK22F29lGu0g2QuN27IAWtaHGyO/pulm7ANlGOu4X49kAQd6duELiXHZEQQTYelC ZNJt3KAIxagPcpeh0b7DcJzWOY4bk3UJIOooBT3WlF0zT+yVs+W90+1ze6AAyeRba5QsaQ/W5FIy /bhUSCzSdiFQF5zXOIAQSEAX3uOwTAxttuUu7ozc7qANjiQDp5V+Zp7Kai6xA2VOcHcjhAU2QSH2 sruAb3sFQsb2CrRrBBQAyWe67TsjiAB5ugjgF3AEo2QaAbndUFS7rGOm4aRunSDQ25S4xqkBKoGM FiQhsfdOA90IbYHZUChztwi2CJzRbZAQSbXsgCEgBseCr1NBsOEDA4G1rq9IN9kATmgtvdCBZpNr oQCDYm4TGHQNwhoCOQSixFiPdWY97cBW4anXCIBAxb2PBAaRpVPGxHdPO4S2n1HUECEt2kGrgJms GQ3UcA6yMRg7dkBbADwr8ux+Cqb6BpH91GuIuSpYLcy/Oyst0NvfZB5gPKpxDhsdksyE0F3dR1hs TY/KuOzXAOOyCZhfJcHYJZaIGlvdW0kDdWCSN97IHEjcJZA3OFkIG5KlrgG/7KEen2SwWG2Nz3UJ tsoLN53+UPNyU4NF6ibAIrABLZYG/wDhGHb8JRKKJFihvq37hEbflXqvydKFKjdpBuFYdsflQDUL 3uqdsONlCMra3KFv/M22U1tBtZFTt1vN9h7qopHsDTqvqPspdzwC3ZG2i0yOcH3Hsga7RIQqC3X4 5I5Vl5a06hcKAEknshfJqjLQLlYBGC3qOwUNifdEP+UATv7IQNKAq5OxPpVlgeQFQFuOEyO2q6pK LP8ALcAN9lb+fVbdKc/+ZqPCjpLuBduOyUUPuABdW67SEsPDnEE7BRztYuDt2WgLe/e5TGTjTpty lCNxcd9k2KOwuRuhKKNMOx3KoscDpJJITS7flLIcH6ib32QUC2NoGojdE4tDhsicA4AKFo27rBQZ W3t7KydDdhZWTsfhLcTJsFbIhgeXDdWSHG6WGkWseFek2SylyEu0gCylwNjyr7DugdEXeq9glGbK 07nuVdjp32VB2k8bojs2/uoaIH2N7X+VNYe71BUSLj29lYYALoZsExMc8kIdJFwiLw3a1kDruFwV aAOgPDmngo4og0enYBA11wbiyayX0bbKAF0jhy3YI9WuMG1lHEGMd1f9IFkADW9lRuznhM8shupK Li4G6Ahf3AVs7kbFC08KxcG/IQIrWLkXsVLaXNPJQuZve26s+mzjyFotjDIHHcKENIt7JbN3G6GR 4EwaD+VRY422SpANQPsikG+26ANceQoQJr9QN9lYj1D5VAC2wsUQdY2IsqCxEQNWyC2tWwnUd1bg TwP7LLBTY97lWNiq30nbdU1wsNRtdVAJxIBVMju0uJVggfuhJJ2JsCoy+hcdQS/TpJHujc/S8i6v W6DZlt0sguN3CxUIW5hkkBJsAnPItvYIY2F34ROaCCDuVWEJ02NwboiPTe6A6Q6wPqHZHbS255Kg YBf6bFRgDnItJJBB29lC2+191QVO6xDWhCHnTZ3Khk9B0n1BLaC67iNwqB7SA25P7KbGQG/7Jeou HCsDSQSd1QZDRpO+9liSEySfCY55F+6UzZ11AZUbHOPljYELHkpGU5dYm53KNkxa4u5JRBhkadX3 H3UAqF7ZWOB2DQlUzw2BwvuTsVZYYQ9p2JQwxEN/+UQMjzX7Fu4UeXOA/wCyg9DALq9WhvuoCPsb e490bhfSeAgc25Dihebm5O3wgKn3JPKSHiyYXG9gNkksAcd0Kg4WBzy4bhFqa17tuVIxpF7pU7r8 IUsNu42VtZrN7cLGfMYI2u/qJ4WWyS0QJG6pGG8N2BOkpJdY7FXJMx++10ovDje1lbCGCF17k8qz HqcN7EdleslrSChc8F2xSyhghztyLpb26idJsO6WKNuouDiD+VGMLHG+4QAubp+UDn2NwEZ0i5Ua L79k6ALJNPH3IxO4329SoAEk2sUTgCObJYLhqnR21b3RTSNNy07pL4rg73JVMAZsUslhNuTdQOOq 3AROd/ZWbOAIUKVqDdgblA0aH3I5RABrrqSXeb+ygG3B4KS+MWNzsrJDeOVTyQ38oRgNAaC0cIyP 5YQi1gjd9tleiANA+4JoItvygAACXsDZEBmsRuJG4QOka7fSAqDLvsg8tx1X2C0Cw4bWRBtjuLoY manWKeGG2/bhQGOXPfeMbImxPa3m4Cbbe9lZO4aVQIaTq52Ru52QOdaTTZMiaQSdt0BGs1I73bpH 9lT7tBtsUuO9yCoBoFlNyCFARZUCdWyWC3DSN0DXNZzwVT3lpAO90RYCN1LA1zY3N9JSi3RtdDoP Yog35UAIJ1JrXNDtyl8X/wC6W4a+6AyHOa9pDQqO4J4QRuDdrKy8EEAcICXsPlUCXNd2KsjjdWxj ub3CAVTxOa86zsrmYI3ek3+FdbqdFdvI9kNO9pYLn1/KtgjSWjZGBrbvyr0jV7qA2v2QFEFUxz3S EWsEQPyhdvuDZAGTc2R3AAPsscSFpsN0RcW2Nr37KAY52ohLtqfYndXqIZeypnqF7WVsF1bA+WIt 5aN1Yu9wFkDmPdwUPmuidtyVAG8E1LRf0ptQwXFh+6WfvDncpxd5gAugLZG1jdnblVC4xyG5uEsg 77q4pC1xAGr3Q0ZZ1Su1xn0jkpsVS6Q6S29u6xmTPa0ta2zSnCQxM4A+UNJjo5Xl5FrD5WXF5b2k P5XH6DrB8z9rrNic0C2yyaTLOmLkoRPYWsEQc17jfgISYwftUOiOWcHOfZxuwJb4wXkhZcoBbYBY MxLHABeclmXDHsNCyxNJE3i6w6GoIdu1cu6NkkQPB9koov8AUEt29ktst+Qr02PwrIF7dlKKAXg/ lU4D8oy0WJSjfhKICRZInlDY3E+ydIbC6xKlmttyfSqAcMppJZBOd4muvwtjfhTq6LHsAoxJEHiI NuFryw2uZBH+n0+ki/4XtHwWZ0oYMSpsLdK1ol9Iue664918HGcLRsYz7Uuy70txLFMNiEU0VIXM LdrWatV3TLrhmmn6ttxaSrlmqG1TiWl1xa/C2x5hwgZn6YVuF07wHS0rmg/OnZao8m5Ffl/qJieH VdOY62GqdGA4bm7uQv0eOV469n5bJDfma9G2vIWZ8L6sZLpqqaFkwcwCaF++l3dfOdWsx4V0Y6f4 zU0jWwVE8ThBG3be1v8ACd4fMof6MyEyWoPlmoHmu1G2kWWZ1Y6fYJ1gynUUjp2VTgx3lSQvBs79 l5IteTa3wdci2Rv2jzL4H8zTY3myuqKmqdLVVQe6RznXub8LvfxB9FT1EpIK6Cumop6L+YTEd3WX nXww5Or+mfWCpwmtjdHHG8tY8j7gu9PFJnLNuR8Ppq/Arz0lR/JkhbzuOV7skGs0VD2jxvbLHbOr umvWLG8IzvS5XxGofXU8UgjbM9xuPyvX9dj9Fg9HDPVTtibLYC5XjLo90MzNXYmzNeLsdCJneaNf PuF3H4nm1NJ0Z/V0LnvqKctDnxncDuVnNCMnFWdYS2x3I7ypKCjbIaqCGFjpW3MkbQC4H3PdamvH XSHCvEZUPbdj5i0+37r3j4S874lmLKT6GtlNTHTC8c7zckey8hePzKzpuu+H1zjqjlp2hn5vws4I bJzjJ+jM57tm1VbPUPgpzJWVuT3YXWSunEbWujLju0WXQn1ZMDpxk7D60RtbLrsH25XcfhGwbEsE oW1Bif5OgNc5w2sum/qz5moZsk4PhJnaKh8msMvuuUFslb6o75V90l+mtHBtMNPHI9oLNPf3X0eW Zm/xKmcd/NkDQPi6+bjAbhdMwdv8r6/J2HNxPG8KaHBkbJmk/wB18yaTlwfoIP62bbfBI9seWYIp Xanxt0tB/pC7a6s5byzV4hSY1juJMoTQuD26nAXt2XTvhBoKmGNjmRuNOdO9tlxn1IskYxjXTSLF 8EllE9A7VNDE4gyNX0dPBPJGN9o+LrHw2do0HiYwbMmZ6HA8ux/r4yfLfJbYL5b6guHVdZ4fq00z 3tfG4Oc1m1xZeDvBL1apssdUMMp8ckEMEjvU+Q20m/dbT+puUcO6z9N6/CqarjfDWw2jnb6gDbZd skYYs0a6PNKE3icn2zQzgua84ZNdJUYVXVtLCT/7RI3Hey7X8POea/MPUunxLG6qatrr6TLUD1b/ AJXujoX4NIsIfVsx/DmT/ppDG0yt9LxfkXXS3Xrppl/pr4hsKwnAI4o/1ZDi2KwDT7LeSt7aZ20u 2UFFo2R9OdP+hMODfUDCD+brSZ46Kdw8SmOxgCO8twB2W7XpphtRh2RqCGovcQtsPiy1NfUa6S12 F9cpsbpIy+irGeYZrbBw3tdcISW3IhKLjnh+Hk6SRkcEgI1P4uF2r4cun7M6Zro2yvAdEdTWLpmC WaWcx/dGTuV2v0Yzmen+d8PxbzNMDHBsrfgr4l+j9I/48G07w5dN8ewnMIroZQ3DI7NluebDsvUw mbI4sLmOPGnkrq3w6ZzwXNuQY5MLq453S+t5aRcXCZlnLOYsv9T8QqZqg1WBTtvH5h3Y72C+jH7r /g+Bmlskmzp7rV0gwDFuv2X9FHHBJWtDqlzW2Dt13tmvNGG9F8rUQp6PVAXtibHGOflfIdYMDlo8 /YFmmV5FFA4RvN9mb8r6jqflZnVLKdNFhVRBLpe2VsmvY/2XrlLeoKXXs8sbjua/6OQz/I7MfSnF Hxx2/U0bn6Pgi66h8JnTPDMFyxJmV8LXVWp7GbfaAu7sNweaLJYwqoc3zzAYTvccWXxPRB3+mYMR y3W1NMfJmc+JrXi5BO+ykZOOKUY/pGt2VSZz+UOrNDnTNVfglNTSMmovve4bLwf9XjBHPGWMU4ji Y6Pbvvde5sC6eNyl1BxPMMMo8jEGhr4wRZpXRH1DulTOrHS3TBUwipoiZmBztyrjUVkTj1RznJuN S7s094UWyUYcDcW7rt7w4Q002eKUSBocXjnvuunKajlw/wDUUznD/hpCx4b/AGX2uS8xjKWL0WJw Ou+J4c4DuLrxNVKz9Rjp41Rva6X5bocKyrTVlLA3z5IgQQOdlx3TfqTiGbM449hVXCyGDD3Wbb7j +V194YvE7lLP2SaCn/iEVPWMY1jo5HgWNuF2DRYXgeXc5VuO0mL0UcWIb1DDK3n3Fiu0Ep7lL/o+ TqFLHNNHxuOTHDfExh8jogY6ql0NeRuD7Lsbqr1KwXpxghqcYqXwNcPSWDuut+tWYsvYVjuX83tx mmZ+gk0OaJW2eCvrc0vyN1tycaKqxXD6imqWA3EzS5pt23Xomt2yUlwjxxW1SS9nWn/3cuScNpY4 jT1VYLhrpWsu1d95KzXh+fMtQYphTgaGpZqba23wR2XTFP0d6P8ASXKU82IGjkhbGSZppQ4nbsLr zZ0Z8dmWMidTKzLcsjafJlVUFlPLteM8X27LU8ePJFvEuUahupbj7npi2sy/4vcaEcT2U8sjmOcR s4EruDxwmN3QPHJZH+WI7Oa75X14z30vkkGPtxXC4JAA79UZWtJ9lr18enjSgzti02R8tVDarBI/ +dUxm7ZD8Fac/JkjkaqjypSgvHd2zvj6bWK1YwivpZXOdDO0PYDwF9X9QGkmmwXLkwiIpoam75ew 4XX3gJ6x9OMq5IijxPHafD8Wc0Mc2d2kAfld3eJDqH00z50mxugmzXhtQY4jPH5E7XPDhxay88cm 3Mpo9ubE5Q2nafRPFYMV6V4BUQAFopQCB7hau+sOF58h8RGZ6jB6jEKeqfVl0UTJXWLb7WC9GeEP xvZBwvJUGVswYtHhslM9zIZ5TYObfa5XfA6mdDq/MT8zvzDgsmJaLebLK25HwPdbxyUMkpNWmebP jc4xR1D4Qs5Z5xXP/wDCs2VNT5UMBLRMw2LgPdehvEZ1Tn6UdPpcWo6YVdWZA1kRFwR3Xmbrn9QX pv0+xqjdlNkGMV8Mg8+SAWbovuLhdnYZ4vOiXWXJtHPjON0MQNnyUVU4Xjf7LMoqU4yrg70442kf GYL4x+pOY8LkkwrpxLWBkWz2hwBNlq+8T+eMyZ26u1OLZpww4ZiBk0/p9NtIB4W2+s8Z/QzJNC6n osfpYGMabNpGgcf91qT8RPVmDrX1cxTFaCG9C2VxhkIsXC/K1lyQintjVnLTLJKcd/J8ThkrxibH hv8ALWz/AOmtn2gp6ytwWepjjqKiMaI3OALiPZaupK2poZC9kQLeL+y+syZ1QxnIGOUWM4TUup66 meHtsbbey+W3bo/TyVxpG8jxH4dmbEcnNGVmufXxyB5A7hfSdOa+vo+nOHzZgc2nrI4R57pDYD3u vIfSL6puQ8ay9SQ5087CcWijDZpA27HkbXXxXil+pBlfMeTq7LWRpJal9bGWPq7adIPsvdGW+Cxv pH52cZY8kpI2F4TjOF5nwmpZhtZDUxuBY58LgbXHwukeneDZ8y/1Hq8MllP+m4pjIyZ43kaTwtYv hw8aWYOh2Yo3zVE9ZhUm08E5LgQTyvaOJfVdyRSYCZIsNmrMQLfSxh9Id8raThajymamnKnL0ey8 xZ1wDCsew3CMRrWwV1Wf5DC62or4bxJ5UxvNeVqaPAZzFURSBxDXWJC1A9Y/FVnHq/nyLMDa2XD/ ANLKJKVsLj/LAPC9JdL/AKsk+V8Cp8Ozngb8WngaGfqIPS54HcqRUYSTg7aInPLFpqkbHsmPky/0 9oDjU4a+CnBnledhYb3KLJuesD6g4fVnCKqOrp4XmJ+h17FavfER9Th3U3KT8Hyxh02FMmP8xxO9 vZdL9AvGNmfojmF+KU87qygmsaiheTZ/uQkowSbl/JmIvJuUUuEbVco9Fs05b6t1WNz4s+XAXyF0 NIH30b9wuvvqV54wPCOiM2D1s7DiNWddPDf1bD7rLqKo+sHlqTA5DBluqZinlkNDnejXZeBet3Xr NPiDzbNj2OzOYwXEVOD6Y2+wC6rJLcsk/RFhlzCK7Pcv0yumWS845WranH4KDEK8G4p6poLhc+xX 13j06R5T6ZQ4NnrBXU2EupqljJaOms0SD8Baw8tdR829Mqz9flzEZqMvbZwY82P7I829ac6dVYxR 5hxqpq6du4jkcSAV45ZXKbl+n2IYnGKijfl0I6qYH1X6a4VV4VVxTPbSsjmha4EsOm24XzXTbotP kTqnjONsqny0dcS8tcCA0n2Wl3o94iM8dBcVbVYBWTMA28tzrscPkL0bX/Vu6i4hg0mHHAKSmqpI zGKqMHVe3K3CW1NJ9nhz4JuSnXRtSqK/L+dMw1WBSTQ1tRSASSQtIcYyvlvEJlTM+Y8hNwjKVQaS te4RufctszutNGR/Gf1D6dZ1rMzYZVH+I1hP6g1Pra8e1iu+Kb6wuf6aJjarL1DM8CznEEXP4XVX GScX0cHicoNSTtnsDK/0/Mqvy+Rmh82J4rMdUtSHbgrX7nfIeW+jPi4hwInXgcVU1wkltZu/K+uz B9XDqZilLMzDsNoaAPGztFyPwV5I6hdScb6v5knzBjNQG4hK4udK3bdWWScrczenw+J/U30Yjj/T PNXTt1PU4vhc1J+jDA+RzLsGnheHfC94jMm9Euu+Y8FnxGJmBVspibUt+xp1bH8XWuOqxrMsNF5D sbq5aM7FjJjwhoKUOY2qhle6p/6zuVzuotN3Z75Y9ztH6EuofTjB+sWG4bW08raiIESNqaeQHWw7 2usbP3ULLnhz6aufWStbFBGW01M53qkcBx/daXsgeMHrN0uoY6DAsxTCgYNLaeU62gfF1xPVTxJ9 SetzoHZlrzUOgFmMZdrR+ykGpLZJ8HhngyRnviuTcz4e/Etl3xGZaqI4GtoK1l2TURduW+4X2WTO juWOmeJYni2ExfpX1l3zF7th3JWg3I/VbOnTPF2Yhl7EZcNxCM3DmuNnb3sV2xjvj962ZlwaXDK7 Gv5cjSx72DSSD8hS2m0uEZlik0nNWz039SvxLYNmdlNk7B52Vgp5P50jTcA912H9O3o3kPFen0lf W0tBildOLv8APAcWk+11qgqa+uxevlrcRmfPNISXFxJO/dc9k/rdnjpg50WXMUnpaUnVoY47LeTK 0tmPo9OHBJfeXZsh+oP0twDpRJgmdsqwUmCz0bw6SOnAaZLH2Xovwk+LTK/Xvp7Q01RXQ0+OQxiK amqXgGQgWuL8rSxmvrVnjq/VeXmXGqisgZuIHk2XGUeIYphFQx2DV0+H1DNhJC4sI/svPLJu4l6O ywzdn6G8Gy1lzIj8RxGnZSUQmJlmka4AW5utZf1IPF/QdQaaTIWXJhUUbX3qKhhu11jwvIsvVTqf WUf6WozliMlNp0lhqHWI9uV8NLSTfqXPleZ5Cbue43JK7RzbXuXLPG9HPco1wFSxiChi0jS3TZVF CyneXNPO5TqqV0tOyJrQ1o9liwxOaCCb/leec3OVs+vGO1UP1aiSkwte0uLSAiLHEXtsi8yPTp8w B/suJ1QsOBNidynNkMDgWmyVFEwOuT6kTi1xseFUUY+pY6UO7ptwTfuVhRta6bYGw91mPdt9ukqg IH1X7d0V7AgDZA1peObWVg2FkBLlhBSnEufcceyaQSLBK/TyNkD9Xp9kIwnnQAQFYddlyLIZmF+w 4R3aIw0jdRogrcAkHlNDiItX/ZJc30lFTvJGk8KUWw4y4jhN78Ka9J4Ql291ooXl7fKAHSbHZGx9 1Hi4ugKEruLqNlNt+UOmyK3GyAsO91PtuQqsC5VqDnWCAIjglQjugvr9PFkQGkb7oCgLlWPZQqwL boCNsbgq9NuEP7ohIG7IC2hKnmZCQZNm+6Zezb8JVQWugs4A35WQZFJL57SY3Xb79lUmux0rCgqm UsL2tO3slx1cjt/6T2QGa1lm27qw3Y72shEl23IuELnbm3BSwNa5ojuRumwyNe9t9lil9rA9k6Nt y3291AcjDC5s4kDrt9lzFO4lcNSOeHm+4XJMmEbCe64SOsWZ41MCbHJrdZ3Cwg90sYN05r9Om/K4 nQyHODXEALj5wTKSO6fI8uJ0HfukubZpBPqQgmWME3bsVhzQ6nAyH+y5Dyi4JM0F2AHcromZaOEr KfQSWi6wHkNHqavoqiB0LR6biy4qpY152HqXeMjm0cW4lrboXNmcwOOwXJihbpu879li1Ebz6QfT 7LoZMcPNvdGN+AgbG65vsArNwbAogNa9Qgu35VMuR7ogza6MyCAQL9lT/VcI3SFrUIkvwLqFTBnk ZTUsbSbuJ4CSyQOmOoelZDaMOka8723AKZLS6narW+EKxccYJNuELmAXJTmRaAb8KhHrBF0MkpSG s5WbAAd7i/ssGJh16QFyEMQG/JUZoz6NofqJ7dlmQSel+nYLDiJa3YWusmIggji64M6IKnga2UyD 7jys+403tcrFiaWtvZZEb9I33uuTOgDwGu/Ktpb7q3xB5BvulmItICgCsAdjsrHqcqkI0lo5QNOl hPdAHa5sWqmiz7eytjvTdxVtaOeboAnC/GyHSL37o2g6dt0JAF7lALJDQXXuijs9pJVho7i4Qvlt 6GDZAAwFjudk0d7pTZNxteyZfU24CAssDhuqDANwVR3Fr2KjWkcFUE+29+CseQ+WSSsh9xyseoeG s9yqgY8rw478LEnYGj3PZMnu+xb6UFRbSCeV1RhnHVF4yD3Kw6l5prS6SR3Cy6l7dXusaSZzmll7 g/C7I4sA1kdRGCwb91NrcJcMYYCLWRPve3ZUgbdNr22V6m7FL8stsSfSjLGOYLG6EoBjmulLePym yU/lAE7XWPWxmZ8LovSW/dbushlQ+pIjLbW7oUZNDaIOHJS4m+VGSdysh7xp0cpZA025PshBLQXj ZEGEXuExgDfiyFsrvKeLXueUKC11zayJoD3WOyCIOG57poAvdAC/Ygd1HCyjQCblW4XKAtoBCo/a QqJ0qri3qPKAsABu3sgbNa4PZFG65I4AQuDdaAEOLxcA2R6jx/2V6dO3CDQQ4exQC3hzZQ4jZNfJ 6+CiLS7bshIAaQf7oCB2o7mwQyE322VhqhveyABxNrDdCdQbso30ElGPU0nhCGPJpjbq5KTrL26j smTssTc3CXcbDsqiMEOO1zceyF24Nkz0h2wuoxjS72HyqQp7/wBTE1pGkt7+6sehgACstaPt5Qk6 TugK1Otf3VHbfurG42ROHpugEl5P4VC4v2RHYBQA3uO6Aq22/dMH/hUGCyJ2zSUAGk3v2UcCTzt8 omkmwQFt3OB3QEY64IBUtY3vdLbEWg2VgaBygDADt+PygdEHOFn7+yjyHMG/9kLYrG90ATyYxp7l UwhoseUWm7wXFU5g8yyAsncDumNZY+re6Es9IsrZcGx5QFmwvflQPbeyto03uEDm73IsgC0au6li wje4V6rWsNkL3X24QBEX4VA9kLQ5pvfZFe/GyAvtZQBW2xCm1wEBYbvzsjYzQbqEXOyJxtshUUB6 7/aCiDrX3VOG1iqabf8AZZZofFH5nqJt7IXkuda2ydFGdwdgp5YB5QgqOMA3ujcCB7IX3jPp3VP1 uYCdkKE1+k/Kc1+3Oyxmtu5OjIvY8hAW5ofybIw7Q2yTPsRvumNvYXN0NFXdHe3dU1x0kORyF3YX QG0jdzZ3yhC3lo023+URHe1klhDXAcpr3FwBAsFCFbEoRD6thsijBBJI5TGusVQLedWwCRoIvcLK +0k9yhcCAo0DGYDbcbprGPBCYC21jyjLxqFt0QEyiwsQkcHlZE7id+UhwB3CjAbBuidzwh9RAsrv pHqKJAoHdEHgE3G6F1huOVGSBrtxdUDGuvcqvMABPKsEW9rqgA0+91QASXm47K2tc82VOBvsbBXG bPBvZQBSU5A7lKYx0VyRueyzXSE/IWLrtLdyWBcLnPLhaxCNtrWcd1Z/mPu3YKwwEEnkKNgC+1rX +UbnahxZBe23ZENwVAGCLXIUuBta90OnZW23chAUGFjubhXG+z9L92lEXFzRbYITvvtsgHOZHb0j dY80epp3sUT5SDtsUJcCd+UAAYQ3lUbN5RNcSSCOFHWLeLoCuWGyK/8ALsBuha7SLHhF5g3I2VQL 0F7d1GRhhuRwo2YWt3UEms2cjAL5bDbYJOpuq5/ure0vdudglOBLwOyIGSA5wu07qiXf1I2uuABs UTrORgWAxou3dW25adrKMDYjueVZfc7cKApoIduVbrFU4g8bkIW3dyLIBgIAU0h2xQXaBuVZc225 QBfYNhshcNweyt1gObJZeeQUATTZxCh2OpJMlhf+pMY/W0n2QFh1ypcmQWP7IGnW4owdLvlVAlR7 FJ4sbWIT6g62AgbhY5dYC60BurVyd0Wv0JbWtI2N0ZPo0gIBTiSfSiBvsUIu3bura73CAYSGmygA PdANyj0kC4UKhZ2da+6J21lZjBs7uFBYgn/CWUHUOyNtiNksG77aTZEW+SQb3ulkYzyzySlvuTwi c8ki3ChdqsAjICG2O6Im3Cljq3UI3URbIXDvyVNIcNuULmh3fcdkTZA1GLEvADrdyrF4jcjYrIfE x9ngblC8DhyICXgusUbWuaBfdGW+nfsgfIWfaDfslFshdY2Isp5xZYNturuXi7gAVRYAgILA/JRA EoBcncJzLafUbeytAx3Ehxsjay7D7qpRY+n+6kEuqW19+6UAHDRYcomkgj2TqoNYQAN0sbkW4VBC DYmyhiDo/UbK3E3sFUhFg0qABlo22Dr7pjpQGC/KRJE6ONx7WSiJDEw33JUBKmfypBss6Eh1GHOb a/ssZ9P5rWk7lZN7QiMdvZUMS6DzDdkjm/CjWuDS0i590Rjc03Fwijc7e45UsiI2waP+ysER3sEF jGb/ANN+6Mg2uO6pQACSSVHAqyQR8qrFSgS5srAFlAQ02PdXJs02CqBjteJHljgWgdypISHgDgI2 xmZtybELIboawBw391QY2nQCT3UY0t3HCbIxv5KBuq9t7eyANrTe6YTpY4qg4Wt3SpJTuFALedO5 N0xrtLN+6QXXFisgfZeylgY1osluO6Jzw6PYbpJmDgW2N1AFva99ldxa4GyqNu2/CuQ2bsFSFixR OsG3HCWDaPdKaTKdzYIOzI1lzQRsge71cqNYQbXuFRjINxutFDOnTcblBqve6Owtq/uq1ixKwAdu O6txcAB2RBmqPzPZSPVURajtZVGaFujMg4390Pllpsm3OnSOQrc0lo91DVCDCS63ZWxhDtJaQOE2 5BGyY1zje/AQjBc0NtZWIy48oZZLEauEwO1NuFQjHl8xsun+lC5ji7fhZEn8za+6xxrY891Cl2sV AbXV6h32KAOBvwqjJD6iAVejUSOw7oHyCIFxCbG4uiLrWCgFsIDiD+yERnzS4i4TbNO55VawWm6A XYeZ8JjTba6E2IujbGA643C0Ci3VY33Cq3cpjmtaNzZJ0uc8AHb2RFoTM/QfT3ROqXQtBAu33Rvp bvIde3wnaWeTpte3cqUQw4quSpidK1pDGmxTHSB4Y+3HZEHiKIsaPR7IYYL3c47eyoGusdwLFCHH SdkVj2QuDmjdZAO9tRKsXJudwo4BzAbo2NO1+EBG3vcXsE8aJACO3KxZakwktDSWHuseUyQvuLhr kNDfIAxB0zgQy1go4l0nwqZK+YaDwnRxBgte6tGSNcG8lKebH2RGImYEHZXLGL/KgAjhA3VuIN0Y 9I5S/NYTYlWwT7Leylze53REstu64S5CGkWNwtAMODja3KF7QHgKm6tjblW5wabHcoCi4M308IfN fJIBwj2I3P7IC0u3B0lAE4hzwCf7qPdqdZUItgb7pphOm5QC7Am4KhsQCN0LGl7nN4TGRgbXUoFu FwLoRs6x4RtdqcW+yBwu78LIKaBrJPCF0AvrCFzv5gsNu6N5LQOSCtATILNKFhaGgOO5THgFp9kp 8YOl3sjATKdrpbv57BZIpi8Obbc8LHmn06SBYhHDXOY4OKiSHAmpw6SmsbH90jUSNJ5XJYhXvqmt Jb8LjfKPmajwrRUQ69IbdNYNFgf7qEb3sra8HkG6nsUEHu/ZCXlxI4UdYN25VNBcCbLRQTEWm5Oy vUD9vCJrjKC1AGlpssiyybdlV7iyIH18Kng61CWW1wDOFjh+qQ2TJhexG34S4oXNee990IMLyRZE wkhCQQSEWv0hASNhaSXbhUZdjbZHr1N+Em1laATXaxtyFTtyLomFo7KpCAbqoE03Kscqi+wBUuCS VQWXIW+o3RfcOELWhrlAOaW337IXNBB3t+EErRfbdUzUNncKgKNo390bXGyF9gWgIg0DdRgBwtY3 2VPk3Vy8WusdzyTYg/lSwG+zjrABKZCS4b3CSAYjd3BWTGRpuAlgjvylhu5Ka59+10Dv8IASRtuo 03PKoxkKNJBsoA3AOaO5Cu4ItdA27SfZFYHsgICGmylwVXBCuwIQFFqAtANymubqVEAmx4QC2Fr3 c7I3HSdv8JU4YywbyjpgWn1b391WBkY8wOPsNldPL5kZBFjeysgxk27q3hrS0gKABzXRuOrhLcxr jqGyOWbUTdtkp7/LsWjV8IBlja4P90I/ujDxIy9tIKkY0G3CqAABddEYrMCyGxsve+6NwAPuEBhe WG78JjXDSQrlHmHbZB9osjAthdqO+yYAD3slNu0nYpoLrjbZQASxPMjXB1gOU4Brt7C6JwaW7hA0 AboAS3fdRps+3Csm6ACzrngKgeG3O7roIS5jzYAhWHX4QRudG7nZC2ZkD3FxJ4Vl7Syx7pBk9O2w R6m2bYcdlDaFNLgQO/uVmw62Nu5Y0hEd3tOo+ydDO+WLcIUYJ9buFkgOsFisYHcLJabNAUZqz6CR +iwtsuPqqhzGuIbc/Cz53+ZEBw5Yroy1xvYheUoGH1nmxb7OXOQPAjaXHdfP3bGLNFjfsuRicZIw L7IaM6WUcg7IHPIANkmKAixBJCc4bW7oCNffsqJv2VNJaCqvdAU4ahukSNv6TwnkHlLk4IKMAFkc cR0m7+xXMZSzjiGTamCropiyeN4e3fvdcDBFqnDLm3KwBWtqMSMWklrDYWXTHKhfo2oeG3x85ZxL A4MOzjXjDK5jdBc/7X2Q9dOsPRnC814PmulxOmrKx8gMvkEE2v3stXVYzEJBpfh9oRxKsNsTKhrm Fkr3D8lfSx5XFNnzcmng5Wbks9eO3pXH0trW4VmA/wAQfS+VFTDY3sugfCN47cOyk/E4c3Vpkw6a V8kQ1XLBda6JMPleQGQvld2bbdM/0xihj81uHTxk7D0rrjybuKOM9Ju5s3BxeN7oZiWa2Yu3FzTV LTu4i119Nmn6hPQx9M2OvxAYg0WIb5Oqy0r0mQ8clPmGgeWnsNly3+lK+nj0Pw6Zp+RcL0zmppcd HljpEnTfBt6r/qYdHaPCCzDpaictFmwtZpAC6p6wfUjydm3p/X4JhlEWz1bCz1b6fla3abJVc4ue 2hL9uOFP4PFDL5UlN5E1/tK4LJXUeTq9JCLVPg94+FXx05M6UYVNR4/USxucHG5vYnsvgfFJ4xMB 6vZ/wbEcIpi3DKJ7dTrbvAO68q4jkuoZT/qJKYSU+1iAsTBsuVGJVH6OiieZncXbwublPs34MTaN kmFfUtyNlTpyyhwqhkOMxxEaCLAm2y8B9YusWO9eM4yYtjVQ5wDv5MTidLB7BfL4rlTE8rVDm4jh 8jjzrEZt/dLp6imrA2NkOh19yublNKmehYoTaZmU9P5EYilcHO/p0q8Kra7Bq/W0Esa7UFI4wyVo JJI+UdHRV2PYqKOmkEdzbUe64dHrSSR7T6GfUhwrpRliPDqzCpZ6yMWJt9w/K5rqP9WPDc24RV4Y 3KL/ACZoyzXKNVyV5gp/CznCto2zNp2zMe27SGXJXCVPhizfRCWZ2FTP0b2EZXfE5P8AguTwZo45 upM+HqcerMTxKoxWjD6Nz5DI3TsWgm69J9CfqIZx6MYe3DsQhdjuHNsGtkd6mhed6zK2O4RU/oq7 D5aF99P81paCP3X3OWvDPjubI2Pw8umc8arNGpd5eSLuSNNYnDa3wemc5/VyzJiWGugy/lyOjneL OlkudP4XlHF+umbM4dQYs4173vqoX+Y1pPdZWcugGfMisMkmBT1VMPueyI7LhcnZKlzpV/o4JpaW uvpNO4WIKNyS6OEMWOMvqz1Vg/1Vc5YJhUNKKCOodFGGDzAB2XTnXLxi5v8AEHQx0eJ4dDSAf1RD t+VydR4Js60uF/ro6OWr1DUGhlzZdRZwyVmfp9JoxnCpaWIGwe6MiyxJtxuKO7xwlJSZxFHQDDIW ONnv7/Ca+pHmFx/q2IHCxsOqyWlz3BzHn+yzaqCBkWovsDvsvlp88n0UklSPuOnHX/PPSGUSZVxl 8LQbmme+7D+y7AzF9QrrVjNG2ObFYqIt+10DbLzbHVQyTljRpsfuK5GIM8jS5w03uTdevHl2dI82 TT48nLOz8Z8YnVfNmDyYZiWYaieml+8jn+6dl3xYdUspYYyhwvHaqKJgsHFxJXUgk86fTARpOw2X cHQfo8eq+IVFAZyyoaB3912WVzOKwY4ADxndaZpn/wD7S1Dxxa52Xw1R1w6kUmNzYszMtbHWSu1u e2Q8r0dnr6eHUHLWGyYlhYdXU4brs1tzZeYBgtTSY+/C8QhfDVxv0OY8WIN12ua+yOXjxN0fXDxj 9Yv03kyZqrJox3c83WLjHiT6n5ww/wDR12O1DqUjS46iSQvTHTf6f1T1WyZFieGYjG2aVt3N7NXU HXLwb9QPD7RvxGubHU4SDvKzsFlOcrow8WGMlZ0bhrHDz2veZJXnVITyVmNgYLPiJt3BXGYe5tU4 1LXhpPLQsuSJ76aV4cWt4uvM2/Z9SCUF9ejlcLxzFcvVDpcFxKSiLt3NjcQCVlz56zliUxc/Mdc0 jfT5xsuNyjhQxCtgp3HU1ztyveHTP6f2G9UcqQ4hR1xhmkYC5wNrGy3FtdM5ZXFu5I8IYzmfM2L0 hpKzMVXUU44iMxtdcTS4tmvCG66HHq+AAcNncB/3XoXxSeDDNPh3MOJzgVmByu0/qmn7XexXnqOp Lx5b43gdiF1by1dnn24JOjJnzVnHFKQxYhmOtqoXf+3JM4/+VxzMOY+F7pXPEgNw483TmvLCQ0us PflZUTi+PVKNDPciyw5ZK5NxhjXRx9ZiOL+SyJ+N1T6YbCJ0psFjwNMA1B+su5e7clZ9dBDMB+n9 fc90mOON8Xlk6HDYiyOUpLkjx407oxGzSASGOpkiY77tJICXC0aSBiUrgeW+YbFev/Bd0Ry31Sxs 4djFK2aJw2DhyV3j4qfpsYBl/pxiGY8oyR0FZh8ZmfG7YPaOVtP0JziuzWPNhPnNbplLADtZ1rqj gNax2oVUrbf9fZZMDKt0mhkZe1ri0kDuFnSUtW71+Wb23uClTfCJ/rrk4mkgFM/XOS9pO5PdZE+F UMzyYnSRPPLQ7lNik1zNjkZcX4+VmT4c+aUSR0jiR3AKx9l0dorGuqOKhwOFzrSSvd7AkrkMPoxh MvntALeC0LJlZVRR3kpnsHY2WMJpZ4XBlwBySpOLaTkaUYJ/VGXVVba1ttmgneyprqen0tc0zOO1 1iU9K86Wk8912R0J6U1fUrMX6aOIyRh4a23dc0rZqUtqs+Emy7/ESJf058sd2tSKmmp8PGiKF7Xj /c1boOh/goytlLBaeox7DoKud0YJilALRtuldbfAX0+6pZWrXYBSwYXjDWkwz04GkuHY2XvhHE/r J0fHlne7mJpyoqWpq6cBsDZQewbcptVlesw6MTuw2SOI8u0Gy96+F3wW4mzqHNS5iw90dFQP0yvl B0ykHbTfkL3ViPRDpfV6cBq8AoJJXR2LAwBxHuszxLHKrs18lPpcGhyPU+MNgADjsuTpMl4jXReZ FhstVcb6GkrYf4h/p2UGF5hpMZyM11Lhcsv8+kvfRc9vhenui/huyf00yLTvxTDoKqfyg+WWdgOn ZPGoxU0+wtVFycUjSHXUP8Fe6Grw91M8/wD1GkJNFhM2Lytho4S5zuzRyt1nVfwidL+uWWaplBRw 09cWnyaulNtLvleevDb4Da7LXUurjzbCw0FC/VBpH/Nb2W1jhJOV9B6qnTRrpxTpXmPD4DPNgFa6 AC5kEJt/ey+PllNM50NnxngtfyF+iz+F5LZK3A3UuGslY3SKSSNuoi1uDyvBHj78CFDJh1TnvJNG yndDd9ZRRNAbbu4LMMeOf1dp+jPynGV0azZWA0oe94AA4JS8LDpI5NEbTvs6+4XeXhd8M1T19zHV 4Y/WI6c2c4Fdq9e/p05m6L4Ocw4U8VeER2/UNLruYLrg8clKme/zqlJezy5geCYpj1UynpoH1Eh9 IY1tyV93XeHjP2H4a+vly7OIGN138s3stifgR8KmD0eXKTOWJMiqpZ/VFG4XsvWFdnjJpzTBleoZ TPxKYaWU5Y0g/C3VPa1dHnyahro/PrJg9XWVzaM0r/OkcWBug3v7Ls/AfB/1MzNRNqKHLFTLCRqD jGRsto3Vzwk5Lw/O1Bn1tHT0WH0Unn1UDW2be/Nl9PmPxmdMMjYN5VJOKqrY3TBSUkd9Vvx2Xp2J RU4K1/8A0eL5UpNxfDNRObvC71HyThj58SylWx07RvMyIkD+y6VrIX0cz4J43wzNO7Dsv0QdIuo1 D1yyUcTlw3yqaS8b4KiLn+61W/UX6H4NkbrJQwYLTspWYm5rzGxoAbqO5WYxjltNUzpHUNNW+zxx 5z5IS0Osbe3CyMAo6iSZsRdrdIbN0jdbQsi/TLwHOnS/DK51YKWvqKYSam73Ntl1B0a8HLMH8Uce UcWcZqWjtI/a9wFxjG21+Hrllo6m6b+DbP8A1Hw5+IUFJKylAvqew2K+a6peHTPHSZwkxfDZRAeJ 2NOn91u+zXjmDdEMhGrio2xYdRNDfKjbyFxGHjLPiU6cSPrcPjlwusY5gD2jU0+49iuuOSUdzX1/ TyS1ElLYu/w0ddNekOYOrWY6fCsPgeamY6WkN1W+SvQ+N/TC6p0OGfq6Z1NVSNbqMIfYrZP0L8L2 UegkVW/CKfz6mR7nCplAL2t9gsn/AO6BwodQRl2eCWFrj5bXkcv/APhb3JzrGtyOM800rk6ND3UH KeN9PcYqMKxmhkpKundpkjkZYr5akdBX1LGX8tvcXW7LxzeF3LvVTp/iGZW08VHjFBA6YztbZ0jQ L2K0mRYM+TGKiGF1nQvIBPeyk4xnFZMa4PVpc8pSePJ2Z38P/S1RZA+zz3K718PXhgzN1rxcR0NP K5l95yLNHzddYZQwluIZjw6KpdZksrWPt7E2W+Hw2dOML6f9L8Kbh9LHC6ohbI57W7uuPdeCVxkj 3ZZNR4PAmZPpX5khwp8tJizZK1rS4Rchx9rrxB1I6e5g6SZlqsIx+gkpKiF1iHggOHuPhbu//uga /wD9Zn5J/hUj4SbCqLSQF8f47eh2WM/dJMXx2voI/wCLYdTl8dUxtnccH3C9kYK1DIuz5Hypdw5S NJMk8ZZqbJYH/ClPc76tQ91x8lOWtqWglzYXGw+LrMpHg07HEabjheTLDxy2n2sc1KO4zLkWAWG4 08tS9vlnzWi+rssgOvuN1jtAikkeT6nbBcaOn9llxvfj5RwMBB33KFguzhU27TcbJ0Uy42MdsTZw RSXcbA3WGZCXC6yw/THe+6hPZbTpFt7q4z5m1twseWV2i+1k5jhpB4uhGMNmbDlL/VEbEIXMeXhz TshmjJeDbbuVpAP9QXGwaUVtXCKIaQDYEe6J4A3agEPBuLDdMju3kWVaTe6hkts5AMcbjZCT77hC 46ha6to0gA7oaCuLC3KO26rYm9rKONwUBAVeoJYdYbomkFAELNO/CGVzWEObv8K3N1DlL8o3NygC 1B3ayI8KBlhdUbgoC9zsr9VlYbbf4Qvd6dkBffhU5o/ZEDdu6AkvCAYAXtItsseWNsLTqNwshtww AbH3WLVt1+m6yDBcdTiALsKyaaMHjhUIAxgaCsmJwa0ABAMAba10LgLXVtG57qnbg9rIAbgkbLI0 kMGnZYwiBdcFZjLFl29k9AyqSQEuvtYLJw0l8ri46m9lgtiL7Ob/AGWbQB0Tzta64SOiOTia4yEc BODdTiDsEmCXf3KyriSPiy4s6AiFsXquo6JstigeXPGm37pkLDGdJvb3UABisOUlwa3e90+R13H4 WMfUbAclOQJqAXM3C499NocXkWsuWmgcW3A4WJPswh3K6xZhowJIxWN2u0hYbhp9Nr2WUa5tLqJb cWWIZTOTI0WBXVM5tAmIWPusZ8Bbc8rJYXPJuLFE9jmerTdq3ZDBaHNaXFQa3sJaszytbbuFm+yV u06YxsVbJRjFxcNxuETGki42WUKZrG3dyVI49LkCQEZNubKvMOokm1hwsn9MebWCxZ4/ZCsJsvmN vY7I2MMjSWiyqFpsNrLIpoyXezUBIYw2O5HqHdZlO3WzjdVEzzBYCwWXQUpF78Lm2aSDhgs1PbTk 8LPhiYBvumOjZG24HK4NnajD0lrQ1R1229kNRIGFU55dGG8rACcLkHhRpvck3VBzgLFQyAANt+6A nc3VFtgSN9+EVgdu6tsegoCtPov29lC8MaNP9lbuOdkGoD2QFGs0Fot9xTZmlpDr3CVZjrahf2TC /U034CAonVwVTyNN0L/t5siYWtZvugFMG/unNeeAEAB1bDZWSRxsVQQtLnE8Ky4aebIS4+6BpBdu EQI+ujcNPBGxKCWWKws4FZkUcD2kOa0lYlXDBG3Zm3wtLgCJWse245WGR5shYTa3dFNU6HNDG37I Z93AgaSV1RzfRxVREBI432Cwg10r7N2+VylTGGMOocriZJvJuGbhdUcWPYwsaQ7cqHgJbJXFgN7l MBDwL7FUzZHEvaWnhDGC0HTumBvqRNjAaexQouIEA33To7gnshazR3Vm9kKK1EuJUa5wcSj8sat0 JbpO24QBteQb+6rd3ayoEueBymM59kBRG1lDZoUc+z7KG978oCmO132sAivqvblUywv2WPG5/mkd kBkuDjawSXxOLr/4TwSGpReQ5ALnqSGBois73RMHmMFzZyMH0m4vdU2IWLjdAXa7bE7qzsPdAXjg FTVYW5KAvVZURff/AAqbci5CjbIC37DbZDG0u73RWJCoP8txAHKApxDRxdCZGuFuEDySTbhCRYXI KEFvLnOI7BLcdLgCmPlDXW/usdzxJKAN1URjC0B11HgWROZbZAQCLKkAZcE7ndWDqduoSQbFQlrT 9yAK5a7j0qFxfwrdLdgBCUXmO1kA1waQBwUljtTj8KF2p6YPt2FvlASw02RFmk7m4SwQbhHp1BLB bXtbzsgBDiSoXdrf3QOYbAjtyEAYFzcKnMBJsbK7gM5slxs8w7FAV5Yay5O6pzrkC+yZKwNsAhdG NTd0AclOWAOLwb8BBbcXKOZrQAWm5Sgd0AdnkkNuQgc54NjyExkhBsNvlVMWRWkcdLfdASKQvcA4 JkrTKNlGTRygPZYj3SZpnRP9IuEAxoc1ukmyFzDdLjlMjfVsUxot3QELCe9wraLO2VanN3tsjZI0 8hADu1+w2KJrvUr1te0/CGMlx4QDmvNrjdQuJsTyiZsNtihIO6FQ2Ml/IVutcW90DSQyya1t7Dus mh+oBt73Vh7HA25S3+gD2QR2c7iyFocLONttkLpQ46fZS+xS9Dee6llLNweNvdHv+6FwJFr7KwNr Xulk4BcbWLha3dGx9jf7rqnAObYjZDGTeylkMpp9NzuFh1Lh5g3sE4yH9kiRnnXBHCtgBpIfbv8A CyY3OIssZjQ13PqTw4tBQDQSLjlAHEScKRl2gm6oX335SwW9+p1gVehxfc7hI8tzXg3WQ1zg7SeE sAy/dcJTnO7f3RyEl10I3BAPKoKOx90QHN9tuFGi3yVYvzawQF3JFlHi4BI4QBxBKYDcAlAC4AgW QBvq/KZYb2O6AEk3IUsBuuQAFTLk2KC5HHKIEtF+6AJzRYpLm37pocqLBawO6MDGG0ex4CUxhf6n CwV/02REnSBZZBT7ucNOwUkGgADuprtsVRBJ23CoKc24sFZaQ0JZ1A7FHN6mNDSS74SgG27gB7pE sIdI1uoi3snMJawFwtZCXi9+6tAZcE2BufZUbNCpoYHXOxRE2BtupQFWGob8qi3fYoA4k3LbIyNI 1FQEIDWk8qA7CyAu1PsDsiIsdt7IAngEBVo9Ktx1AWChdsOxWkAHAgbDdWON+UYJKlg47KUCmAON u6ksYDxbsiYGh17boHEvkLeUoA7gom3L/hU+PQbXuiYbghKAb2hx4uln0m42VSHQQAo5x0j3UBTn +UL23KKNxkF0MbQ4+s7I7iMkN3KoI1twRbdQx2HqQCaQPvpsw904Sgji6gFScXQFusWGxTXSAjjf 2S7O7crSBRDSzS7n3UZ6WENKstB2PJVaRYtHKpUXT+km9iq0FkpPZHGxzB6kfI08n3QMTJIdXwqa 1hHNwkucTLoIKhonMdqD7X7IEZDWtYdt1NtLvcIQA1vO6jTcWQMqG5h1O+66jiWgm10ezRbhC53p soQCMuJunAuItbhKB/pB3UMkrZAAAW9ynZUOebAE7IXCxFuCqFp5NJ2FlcbrBzbbpRQW/dudlbmg uuDsqDbA3RD7UIyG4FvdRvHyi5ahJPA2QhANr3RdroVDa9uEKiyxpN77pPm3ktZMLDcOvsppa8hw 7cqloge4GyMtDwD3Uc0NF0LfWLd/dQUE+IuGzv2VO9JAPPZQB3BKouAKMlFjfkboXG+3Ct4LwHcW 91HkHg3KFDkaI4gRylt/nAe4UaC64dwibZt7KkYNQ+4DW8pdKwU8rpJHEk8JxcACe6S2Jz3avnuh RtXqkdGW7e6s2aBcIz6wN+EL3h7NI+5QAPcG8blU86SHEqMYRLY7lSpGt1gLfhLFipqgygtHdGwa WNBFwFbIW243TA6wsogBa7ttgmD0u2QPcC4WRNcCedlAHuWne6X6gd9kxrbG97hW8eYb9hygE1Eo Iawe6J4LbEHaykwY9l2C5CpzjpbdVAFpb/VyiDwl3Djtz7KaSFWAnkclQPDjdWG3G6qRhFiOAgKJ s7awCaTcBIBujZqBIO4VATi11vhU5uogtv8AKG2/CZ9pv/TZAQR9+6CQBtx3KIzDsllwc4lALdYD 5T2AuAS3hpO6YHBrfSoCWIdsLhVKG/8A4SvUW2HdDIw3uUodka7Sy3uijB0lV5V7X3ullxBNuEJQ Y9WyDTvtsibuLhWNuUFF/a24QglpJPBRaPlU8BzPkJZSmuDmkDdDJZkdv6ijFm7DlVI1rwL7FZAN PI5rC0jZXG4x3aNgmtaHNsOEssGoFAyXF0Tdr7obAn5VOBB2QyMbbUDeyJzrXtukWAd/3RPfb0ha oEIDtnHZSR4a2zQo2Iy7XsVT2GABrt7oVCzPo/KJtYCQLIPTfcXKqw3IFipRRpYXuLuAl+UPdCyR 99PZNlYABbcqGRchGixF1cUhbHpvsreSGgNsShJ3AIsUAdgLfKBzLO2KJxDh7fhKNy78d1UaLcCG bpsYIaN0o6nQOIFyDwipXGoZwRZUUHJpdzsfdXGNJBCXUtdYadiERf5jWgCxClgyDqALhukGUREN cALoZnub329litcZpHOfsGhWzJllzbWAvdA9uwtylRSnc2+E6NweNzujBY1NFu6j9mXeUbiG3N+E iWXW0+ylAtlntsOEX6gxEBwsEEBNwBwnkMe/RsSlBAtroZX+Xbe3ZBM5r9hvZC6hEFR5vN1ZaA/U 1QDPLaNLxzaxVnYW4JSX6m7gXSP13rs5paQbK2DKaw3UdGSb3TNdmB9rX7JZddpcAoBT3aiUkx6T c900gtue5RNa5xF+EBTRs0Aak19mC+lWyNzbge3KXu771sUTUHkb2SpGu1c3B90cLCJC132+6OVh b9o2+UAkMLXAonAE7lFqueFT26XD5QCnvLCDfZZDaglgG1kiRoddU1ptYoDKBGgkAflJJde44SRK 9p0CxaE8P9NgENCgbXN7FX5+n7t1RbqBtylsaHD1DhZoyMDr/hD7i6e1sb2EjYpckTWkFpuUAAA3 HsgJvyje7QeOVbRqGpKApwDyL8KRjU8gDYcJzYjp1OCqUaCC3ZWgMka57LADZY4Ol3qGwRtqtLrF EdD9jyVSkdURAA2uELSyY3aLBCYwwWA3RRuDCeL27KEsSdpLf4UaHOJ7BW54L7gconXa254QtlW0 8c+6D3vyibIAFR3JUohDsOVXJuo47cKBKBPzumRtF+UAKF255/sqApSGk3SbDSLIyARYm5QOFgfd UBMNtuylgSbIWEiwKMmzt+EALXWJsiuH7HlKkuH3YLgoo/uPuUAR9jwrFgFGs0tIO6oOtygLtdCC QSiBvsFZuCPlQAh1yj1D2VFu6q1jugLcz+q6gdqbYndUSALgqXvuqCSC7hbsmO0ltrIAbIddjsss E0B+7h+FTJTq02t8otyELjp3KgGPdtYJQd7ndELkX90JIvsN0AQNz7oiGix/whjb37p22m5CtAQ8 ajtsFZNrbKEDUoQSoCE/CsccKb+ylwgL20+yhAtyhaCSrsgEuZqlBPCYAdd78Ig3b2QX0X9lpAMT bbhWXtA132Sz6gC0XurEWoWPCACaRsgDmnlRrLWN1DT6dhwnMjta42UQDLQWhCWgOv7IyQwDuEsu BujAd2l1zf8AZRzgBsbpZB7IXtcTuSFAEXa7jhC2zSq4sjvchWgKnLmytYOSgbPNHLocLtunSQ66 hshNrBKqGy6rgXF1APDy+3ZXuBwlMbYje6a4qsELRdLN0ZcSNgg1EchAG0aD7o2sDtzYpOu3KPsC 3goAtTWHc7LIj9cZsLX7rEcQBuEyCfQAAFDSY9rRANLhqv3RiQRHSdgVR0zAEmxQtZ57XFm5ahbG Fhc65dpCymQjQPXdYMcjZiGOOm2yyS0N2BKhuz6F0segDV6x2STG4NLnE2WW6KExAhlnjusSple6 FwYL2+F5TRi0jx5j9W++y5ynbGYwR+6+epG2Zc7klfQUsQdG03sUKOLRtpulOkLSQf7p7hoYT3WP u4XKFJv3Utvyo42aSN0MR1C5UoEcTdLleWt908mwWPK4d90YEsn8ouNrkiy+86MdN4c1VrpZLPcH ai34uuvy3VVRs7u3XpLwoU0L6yue5zQ8kNsUStozN0j0H0o8NWG50mbDVULTRsFtZbyvvc0eCHJe AxtlkfT4a2T7Xv2LvwF6X6E4bQRZRhDIGh7GEk25K19+OjrJj2J9YaHA21EtNR0Eg0shcW337r9F jxLbSPz2bUVI7uqPpm5UxvLn8WosenjqywvY4M9B+F8j0W8OeFYpmqrytj7NbIHFrJnNsX7r0n4M +tn+u8mRYHi9hXUjQ1hcfvbbZd4VGR8Aw3FX47+jjhqImlxkaLflITjBtSX/AAJZJpXZ5ym8HPTf LmLUdJUyCKeoP8uJ7+V9fWeDzpnhtBLV4jS2gYLuke4BrQvOnUTrJWZ66xMdTVRjgpK5sUNj2BsV 7fznk7/XvTZ2CiqfAKqBuqZpseF3yuUIx57PPDI8ltnTdN4J+kuPxCqoG+bHIL6opgQf7JWYfp+d LsWwOajp8LNPUkfy6nVdwd2JK6rxuDMPhqxWCOmxeatonHSY5HXsvXvTXNjcfyJS41VvsJGa3Enh cckJ4vsnaNY8m9UeROkvhXw3J+cJssZtoW4jDuaR5bdjm9rkr5jxjdDss9I34Vj+C4bDh0AkAlLG 21W7LYHS1OFZmpmVdI+Go0HaRli5pHa/ZeRPqfQk9FqInj9WN/lbjnU5KLVHOUZY3dn1/QzKXTjr h0tpRUYXQ1U4j0TNLQX3I5K8L+ODwOHpBU1Ga8oMc7CtZc+maPsH7LsnwK5gqMLx+lhiqZWxSaWP i1bf2XuDxUYRBinRDMfmMDiylc8Ej4XGDTnt/T0SnLGt34aEoazzXNGjS+3qHsVyWVq2WjxKOpab Oa+9j3XATTBmLVTSbR+a69vyucw7RT1EGj1Mc4G5XizQ2ScT7eGflxqRto8IfUPAc3Zcw19dTxma MCF8TgLh3F16bz3V5YyRggxCuwqB1OXAHTEDYHuteHgslbFi8LtfpMjXabbLZBnbLeGZvytJTYlI I6N7AXPJsGj3XXClFRt/8nx9Taukda576B9O+uuVBXvw+INkjLoqiBmlw2Xzvh96DUHTQVk0kXmU EJOl9Q25sFzD+teT+m+X48CwTFIMQnpf5bGB4P7Ls+CvGZsgSVL2iI1VK9xA7bL3uWSKafTPBCVq 0fGR9aum+O4tPgRq8NknYS10MwbvZePPGZ0qyf02z7lnqBlx9PSVFVM0TUVJbQ8XG9gvEPV5+N4Z 1izDUYZJVMnpqlwaY3G33JZ6rZmztjmD0uYp6h0VJI0NZKdgB+VyzxWJfQ9mnjPI93o3e9Dc4Yfn rJ9FVQ0cULmwtDm6d72Xkr6kefcEyZlurw+pwOCoqsQjMcMhYLtJH3LvHwe1scuT2MbcFzA4D4Xm X6t+DiTD8uYhaxjc5pI7hTTr78+0Y1OVwao1q4FTSNow2U8uJuFk10p8yKJvqaSAqpA51PDIHWYB uuQwbDv4ljNPALB0jw0X+V8rMlvZ+gw28abO8OjPh6p+pVAZIwBK7a7uAV2Fmf6cXUFtD+rwWkbV jTcRtNtX913V4eehGNUOA4dS4XLaeSVssrweG7bLYDhr6mhraaikdGyljgDdzu5wC7YqS6PLkm0+ GaCc09Is0dNcwNw3MGETYbVF1gJGGx/B4XqHwrdKsw0+baObBI3SzygPlcBtYe694eL7p/gGYcmQ V9dQRS10UwbHOW7tB+V9B0OyZgvTnptHilJA0v8AI1vktuQBey+i8ePxrJBf/wDTwvPKUtjOxsrz YhNl9kOJUwp544xG5vZ1hytQ3XzpvJV+ILG5YYAwz1jgwNHe/ZbXenXU+k6kUlS6ljMZicWOB+F5 9wzpThuc/Ejizq5jfKoJPPDD/WeV008VDfHIq4PFlySlKDh0fQeDPJWYuneXH4biVK40lQ0Ssnft p24WP9RenNR4cMZ0sBeLWd7LuTNHU2DJmasFy6KJz/14DI3N2azsuu/G7RjEvDvmcOA0sg1ccLjg j/ui2uGaz5ag0nyaMsJ0UmFkkXkc+wWVWSzPLKdnDjusCmcdErOfLkJtdfR4BAyqxigbMbB72gkr jqI7Mjo+5p57saZ3V0F6H4rmaoiqW0rnRusG+nlbS/C90rzJ03w15xSqP6GVl46a+7T+FwHg0yVh kWQqesNMxz42tDCQCuzM9dS6rK3ULL2CxCMUlYCJrj1c7WXLHFz4R4s+XY/sdT/UMwd2PdGo6DT5 hnqWt0gXXRvRb6dVJmXLFJi2MzinE7AWRadwPdeofFlQOxLJmGzsF446pmq47ErtjKggwfI2HEv/ AJMVK1zj7DTcr6O949NGu2z50VeeTvijxlmL6W+U8Vhk/SYy+GoHB03XGZP+mTliobU0+K1tTO2M kNN7XK7zpPFr0wwCqxQxYtUVdU2YtkhtqcHDsAvtOk3X/A+r2I1NLg8UjJIfU/WLG3uubeWCdxNL JvacWa18+eCE9MOuGDYBNUA4JiTwIHF27hfheiOo30ycuYhk+WrwOf8AT4rHF5jSeCQLr6bxpNqp OquS54I5DHSEP81ouGm//deqqbH463p2a8O4oS5xO2+ham24wkl2do5Vbt9Gu7wI5DfQ9SX4XNUM bVYdIY5i0/dYr1d4qcq49D0ezlOzGHS00kRLYLfY23C8VeHnHq7B/EHLUUcr9FXizgQO93f/AI1s e6/YQ7HOkWYKVrb6qVzyOeBdXLHx5kl0zi5+bE5s11+CnweYd1Pwg4njMQNJE432+51169xLwe9F 8GbHSYhBS0dQ8Wb5kjWud+xXA/T5xSOTJ+NYaxotTVAIcF1B9RfD8dpM9YTiMM0tLRysDIJY3kev 22XfxueoeKLo8rzuGFTas+j6qfTVyZikLcTyjOTVl4d5T3gscPiy7G6f+ATI2A4NEcao21dT5YMj WcA23C8z9COpnVHD8bwHC63+IyYaZ2H9QbuaW34uVspxzMDcIyfV4w5jnGCnMmgjckBY1CyYGop2 enE/JFyZ0DjPgc6XZwwiaGHDH0pN2h7eQVrC8afhPq/DNmCOppKo1GDVjyIr9vhe+I/HHmWTEBS4 HlOTEC55Dg1p9NivH/1BOsnUDqO7CMLzblkZfoYniancW7y3+V08OVJ71wTHmVxUZcnlKiMooI5X bvcePhe0/p2SU8XVGCnexpErgWhw7rxjhgLRqkPp4AK9O+CnN1HlTq5hM1bM2BrpWhrnGw5XyGts qP0vDg7NvfVnBsRxjJlbT4ZUmlqQwlsjTZfEeHXLGYMCw2o/i9X+ohlPoBN9/ddlZvFTjOR68YU8 OqKmmPkvadtxsbrq3wzHNlDhOI0GZmuJhlPlPf7XXpxNvBL+j89mSjmjZ29TvgkxKRjYgyRnLwOV 0ZnHIOYMx9bqfG6LEP0uG0GnzGB1tY7hd2szFhIxsYa2sh/iDhqMWoav7LpbrhljO0Ob8Nq8pvf/ AA2ocP1v/TvyFcFqdPi0c8yWy10md6yiN1D50gDmhoO/dfJdUMvjNmRaiBtYaBpZfW02FvZcvVYj SYPlGmditS2nh8toklkdYA2+VxmbqBucOnlVS4RVNeJ4T5UsZuDt2XGFxkn6s6z2uNe6PmfD509n yLgMwfiLq+Gd2pl3arLs6jcZKt5fHpc3h1tyF0/4d8vZoyxQ1dHjsxdAx9mNcbkfK7DpuomBVecX 5eirIXV7Gai0O3/C1mtzfsmBpxV+jqPNfRw411fgzj/GTSzUUg002qweB7hdmdV6B2N9K8xUun1T 0EosP/s3XXPWXpnmLHOpeC41hNY6DDWPaKiBjyC/fkhdjdU8xUeUOmeNV2ITxwQw0Tml0rg25LbW XZyvx16PJt2uf9mmzw9eI9/ho6uVNdUMMuFsmdFUwt5d6uy9Rde/qH4N1gyVU5Zy1hVXTQ1jLT1F U3Tt7AFed/CHlDJnVbrribM0Pj/ST1r5aeGQAtkIdfgr354mvCf03m6WV2KwU9Pg9RhtKXRzQNEY dYcGy6Z3B5bfbPq48dYkj7bwP1xxDw+4M9zbOZqZ+d1kZz6RZcnzrBigxMUuYfNEkZ12eN+y6n+n Z1zwHGciDJrqlkNfSSvMIkdvK2/a67b6m9F8UzP1UwfMtFWzQwRECeMfaWj2XHE1HK9zo82eD2qj 6br5gEuLdC8w0Alc+f8AROcXg7uIF1rh8Kea+kWXsx1M+fZo5q6J5jiE+4Yb91sl6uZ3wPK+W5MF xGuihqMSgNPE2RwuSRa9l5CzL9OHDsRyyMUwGfz8VnJmLH/Y8ncL1YHtwSUnVs805J5Uquke2sg1 +Wsay5TVeUn078Jm9THU32rWH9UdmIYd1swqqkYXU0dI2SJ/YkHj+69zeEDpHmLo/k+ow7H52F73 Ax08ZOmMfuvJX1YsUw5+YcrUbpGfqjbWL7gXXLTfXM1dqiZGnGMkubPkei/1EeoeU8kswU5LlxaK OIRQVmh1o9uSvpPCF1dxjN/iYZjOOC+I4nqjey/2tPAsvT/hDw7p5VdFcMgEdBJO6D/iBKWknbfl eYus2esh9BPE9gWJ5fmikpWyAzinsWsN9+FhTjcor2fQafDNh3VrCsOxjKU9LithRGzpCeAFxnRe vy7Ll52H5dex9HSu0ksG11VPj2BdfOmrpMGr4qilxCK2pj/Uw9wR2IS+nHT/AAzoplStjbII4GtM 00sjr3IB3uuakvB4vdnmnfn8no+8oaj9RWTN30t722XSlViuQX9Zn0lbFH/GwR5WocOXyXSLxxZd z/1KxLKdV5NC2OV0NNUl9hKQeF23i3RnLOOZ1pc0vpj+vi3ErHbO+SrBPDJqfHBnJKM4LbyZXXmm FT0bzVG0Audh8oYB76dl+e1tLUUuYauPynOnD3a2MFyDdbr/ABq+JfAujnTatw0TRVeL1cZijpg6 5bfa5XgTwE5Fy71O6119bmARSxPd53kyAWuTey74lGOF72bxS3ajdHqjzdgMM1Pi9M50MsD/ADGl pe0i9jfut83h3x5uYei+V6prw8ija11uxA4K6U8WfhjyLiHTCuxWip6PCaqgiMzJmWbqsF1F9Pvx k5bjweXIWYaoUMtPM5tNVzutG/ta68soxnHdA+lPJuWxnpej6q5bwnrBU4PiGHtpsUldaOqLRclf YeIbCv4/0TzTSB1vPoZLH32umYr07ypmzMlLmkyUdRPG0aZWOFj7b3XnTx2+L3Aul2TKrKmGVDK3 G62IwlsbriJpFtyuqrJKDj2uz5Mv9Skn7NNeLNdS41XUcZvokLHf3WVMGQ00YbsbLEbGa7FqmpJP reXk+5WXMNb2RtXDUz35LPt6aKWJEiG25tsl6fV7opHgP8tWzZ1m8LynrsouLOb2UsXDYImzPjeQ WhzfkKeYXP8AYLIKdcEbJ8Ufm7Eog4dxeyFjwCSCgJPSAAb3smabMAtZCJPVudijvrbsUMkLT8JA c50hBHp91kSegc7rEsSdjz2WiMzW+pmkbK5A2Nix45gwhp9KyDJEd3HYBCoT97dkLhdoHKaySOa4 b6QELmBtt0BQFiAQjB9Q2QlW7Zt1LNIsm+/AVB4JsqD7jdEwairYI4g9lI9gbjdXoA7qybb2QFO+ NldiWhFdgtqVOe0HbhAFJby9ilRP3AO5TNTHEX2CGUgAOYO6AGNjjM71mx7Iw3TcFAHkG9rFW9zi 4Ad+UBbzZmypgcWA3sFTxc6bqyC06QdkADpdR24HdBI5r7EAhNey0dmjdVAwaSHKApkeoX7Jczh5 jdOzRymgloI/pKWW7KMDYRdhN91RdqBBS2bDnZNAuQAL3VQBiHr5WUG6Wm3HdAY/KIcbWPZR0nls JO4KjKjIpf5hBvYBcmBpaPlcZSj+WHN2CzA4uaPdcmaM1l4SHHhZomLwC0WC4lj3PIBJXI05LWAD dcmjojIZId9gqc95N1C7YGyKN1zfhYNCW1BNwW2VwtEj9R2ITXwEuIsEtsRbuDv7KF4HucCSLbLA r4vNbYCyym21i6uWz57afStJ0SkYMNDRSRaJh/MKxKjCmxbMNguWmpIwQb3/AAsapaRxc2XSzFI4 r9KYTxe6uRgBDbXCzHHXzylSxHY22TcZcfwwjFqJI4HZKp4tWpx2sVyAisCbIaNhu8Ob6T7rdk2m FLT2aXF3pVwBn3c2WdUUQLTpdseyxm03lekjYpuJQ2RgfBcd1ifpb2vuuREepgA7LJFOBGABc903 FSOIFMQRpCy201mnbey5EQRthNzZw+EDGarKbi0cc2mkcAyMblcjTxyUcQa+2tPB0n+WA0je6TIT MbvO/wALG41Q5tSdQF7fhMdMSbE3CxI7ab8lW4j3KyaCmOt49JITLsFtLT+6GMEWKMm6ywCTqF+6 jhcDbdQ8cIm7jdQAN3KNrTy47KyAlv1e+yAqR92+yxtybXT5I3P+3ZCyAg3PZAG1pY23+UTGaiQe FDcomtsdzshCBrHu52CGZtrBvCaQwD0hBJa1yUKD2FuyC5BSw8h/wmX391QQA233VSGwvb9kbSFb 7OA2SwJERcNQNkFSbsATn3PGwWK673q2QQAGAnSCfdKleNBe7ayypSTHa1h7LiKyTSdAvZdonORi 1s76hwtsAuPnZYgN5We9ocL33WPJEWuuSAupxZjeY6Aja4WYHCRodptslsb5jt+Ey+l1hsFSIoWc dzayISbW7oHxEHzL7DsmNDS0GyGiw4PPuoQf3QBuh+3BR3uCgLbc3v2StRBATbahZUA0bWuUBImh ry4oxyUouud9kcRDrj/ugJINtXdSOUMZc7qatiEDubHYIC5rvDXAWCYBqZdINQ5pDNN/lMaTwgJr ubDf5QEOLuEekMuQgueeEAUjvLDUTto735S5vUwd1bSCwAoBIILgTsnekD3uqc2x2CmosF7XQEcS G8bIXu0MB91I5tbyCNlbyNVu6AFrnMcARse6VPJ5bttwU2V9227oWtbp9QufdACHAN2/yr8zUwiy q1twEFw3a3KE9i3tF+LpLWBkhd7rIdbTZK0WO5uFpGQnO2BQPuW3GxV6xpsAhvba6AvTdl/73QTN aQCG6bItQYy5OyCSXWzZATzPMZYD4U0FtgQgb6Wkd0eskC+5QFBpJTNTjtawSbnVdFrNuUBZZ5e9 73TLi1uUoMc5G297FAXK06dQGyU17rcJn6h7HhrQCDyqc2zzY8owCQXsKbRs8sOLuEkjc7rJhjDW Xc6wQGNJIzzb3sLoy5sli0IZadr7lp/upo02ttZAWANR91YYCd9kLz6dufdWLBgJ5QFPbYmyGrjE 1KWW3I5Q+Y6SSwCyGgOaW2BIQCKNjYKdsXJHJTZBfspG3UCDs5QuPA5QAlgaLHlU1qhB78q2klu+ xQBNd8bK7MPKoNIHKkhbCWtcbudxZCUFpDW7d1GHyzfspYltiNwpHcvsdwhRwO9wNlDvwrJHZDcg E9kKhsPqFiFbQ5lt/wApW7dJum6tTVk0h7mF7Bb+6FrfLbvylh7xYNcR7p2prhY7uQ0A3gi91TLv Nrb+yOJhBI4ULSHqUCiAHWv+yEN0u+FZcNew391C4k+6UZLc62ytrQd1bDE+/mO02RNbFo9Elz7K UBagBbcjhVqDdjuSrLhoIUAox2dqvZNJEgFjslmIzANvb5Rtg8gAE3ugIYTo2KHS4ImyWBvwhMn7 qoEDDIdzayNswJ0n7ghD7EO7pZaHSagLXUAwgDkqNAtcBRrQ525srkAZs08rXIIDdENhvfdL8sln NyUwghmm9z8KWCjHvqVkguCptwOblCXXf7FWy2E4EkkIDqtY8JjpA1uk8pJJHKgYbAGi3JKm5NkD bAh45RGXVzt8q0QjAN7hEHi3CDUS+44QueQTtsgHm1r2QvNgLIHPc5gHCrZ0ZPcKUAxyoXfCUJdY AHIVMJa4hytAY4awiilEBJtftuh5+1Da+55VA8ztkiseQkki17Jw0Bo90t7Q5/sFkFuibIxpDrOV adINzcKi32KjgXC3ZVAu/p42VkarDlLZsSCdlcTnXO+wUYI6MMHyqjfub7q5XF7OEDBZo/KUWhwY Tuo4AFW52ltrhU2Mvbq7JyQq2yjbhUC4fhE0+4sgB1KmkAkjYo3i9vZAbRklAC17pCQjY3S7cqgA PUqL9TrpYosgOffshc0hxN7hHbZU55a2+nYKAoWc3fYqgbO9IuUkuMsofYtHssiLYkoB/mH9M8EA AcLFgeSzdNeQ9pBP7JUdm7H9kADydRTA7SBp57oxGCCTxygc0hpIWkaRHEm90NyN1bB5jLk2KsNE Zu7dRgsPJ+5U46Df+yqf1gFgVuALR7p6MsouMj+AFZd2IVNuSNt1TmkEkhaLYNg4+6phs8qhyrfd u4F0IU95Ha6ZDH5jTqNj2CVG7kkI43Fr99h7oKAEHlu9R9XsrGrWQTZMfbWHX1WStXmPJIsUFBgW N77ogQ23uoQHWvyqNgbIUZJu0HuhDtgCjMZLL9kLgdO25QpHm1kBOl24JHuETg4tGrZWyQizLAtQ EtxZCN3W7qfaTYq2Da6Aq21ibhGwBosByqLbWJTHEEttsgKcdNrjhKB1vuBZMf8Ad8KNtY2QEcQQ g5VueGuAPdKYx7HPcTcHhAOO7fhY7o3Od6ARbum3JF0TJCDZAJL7AC+6M9vdKfcS3snAFzh2QBNF xuqaTr08BW697oXnXwLFAETo43Qs2JdyqALb3Vh9uAssFGRrHlxvdRztR1AqtAcblQgAqALUbbco L227qwbu9lfJ3QjJE4E78K5NIF27hUY9r8BA1lrgf5Qoxk4YN+U1swc32usdzTYBytu+wQjGSERC wN7pT3ueBYcKaLbOKJp0iwQpWkNHmcH2U16TqI2V3IvdBYuO/CvYHX1MuFWrbdQO4ACEWebey0CE agCFZebKfZ3Q/dwgL2dzspPtEGtVEbeysHVZALjjBbuUz7fwoDeSyJzRZAKcA87bKCMi3dWQAdkZ fYWQMojYO7hU55cb9vZQuu2ynlnSEIgmk3v2Qu3NhwoWlrUsk3CFHNiJGxsqOzt91Tb+6jj34UZL KLiCbqFwsLbKnyAtQizgFEWw/wCkoGuuNJCP06eeFCQ5aALSWHkpnmCQWCUG77lWG2QEedB2VMfd 4Rltx/5QACOQdwowG0gymwTI4g5+pw9I7ImPBFtKgcIyWjdTsjKqZ4g28QOpJcXPAL+UQiaXbq3D Uduy0UTpGrdCWHVcFG+wNrKxtcKMA29W52RvdsPYILbm6HglZIXG3XJcH9kz9XG97o9NnDugjb5R Jvc8oi9rnatIB4uEKCx4aXbX+VXnRuuTsAOUWkbgcLFqKcvGhu1+VfRDJgnEcnpALHDlKp6sS1D4 4RZrTuU2n8uOERixcFQjbEXOjADjzZQIbNHq77pV9Ox5TS64DrlAHtfLpNtkKxD2kAnm6uOlNtTr WTzGxrubjslmbsftQyXHEC02tb3UibYkoQbDbgonbtGnlUFvsWm4skNjEhICbMXGH2KVTv8AJHq3 uqCwQ12lHTNOovtuhDmteSd7o2SAbAH4UsC5HSeZubt9kwAFqp8Z3eTt7INbbaNVieygC3uN9kMo Dv6QSFYsGgd1A43N+FqgQlzmjUdvZG0O0u4IA2S/tHN1bTc7oACCeRYpgfYNVWuebKPZYXuqAy91 xY7eyXMbgX2UcCWC2xUlY1wAd9yGrI4WYLGxTNyAL3ISms/mActCuaobBINLbg7IZJLINQaB6vdA 4GTvsjaARq7lRu2oHjsgAkAaA0blWSANB+5HH6ueVbWtMhJ2Pus2BEcbtwRsicHMZxZZkYBFr3uq ewAc3Sy2cXPUGBhsLk+yTT1Lnciy5aWlY8drlY5pGtNmhQgEelws3Yqix9y1wsB3Tm0mmxBsVUzH AGxuO6tFoQ9pPJuFXmOa2wBshYyR+/8ASE54Dg23I5SyAMqnE6CLhZmkOZuFgyxaLP7J8E12e2yg sRK3XJYN290UMYabuFwEb5fQRa3ygE40Wbv7qoDpO7gLXWIDpc4u7p/nF4sbC3ZY8zHPOw2WgAXa nCw2TgQ7a+yoWbHYA6vdB9qAJwaLW4V3G/KEyAcINiboAnnULW4VDsCoZG32Vk6h6eUBNmixVF1v whfe4Ue0hqAh3NwUL3FzgVGdrq3DfZSwRp9ZRPFwh1aeyNsoMgaQqCo4i0X91QGkg90+V3psNkq2 /IsgL1bqOta9kp50f/KtoLhe+xUBbnaBcblVqLm6kbgQL8qM9VwQQlgpslzsrILhsltjLSmNeWgj 3UAI07ajv7ImgX4SnU2qzjymhxAG1z3VoEuJHWbsoAASLi6px0j0WJR2uy7maXW5WQLGpj992qTH Uwbd1cnqs0KAX2ugJrs0EBQNa8A8FFxYdlZsR7WVAQOlTzNZ34QAXNzwobB2y0CnXubDZW3hXq3s lnU0lZYDN/2VFoJAKEO2V6tTtKgI0EFEeVQBHf8AZQXJN1QQbuHso9oII7KX5Va2m4HKWAYpNPpA 2TBsqZGGjZWf8pYI0+odwmOPp2SCbDhWHmwCgDa4d0NtztsmNAPKpzDcWKtAEF2+ki/ygPmgDYE9 0Q2PyoSQbj+yqBQYTudirLA2yBznWuh88DYhSwN5TGi4sTssZk2+/CITh3F7qgY8hnAQFw5so+T0 i4vdE0NcRfZT2CnP1WFrKOmj4cD+VHNsVbNNt7X+UoEEkTtuPlRwHLVT6drrOB/ZUG6RsUoByAOa EFg2ytotYnhFsb+xUAcZuyxT2vEEV2i11iMi1A3dY9kdOCbte64CGrGGnBAedi5MbDLpHrQEa22b sBwmNNmj1oas+wjYJGaSbD3XH1Mv6HzWhweHbLkNvKdbmy479Mw0z3PadV+SvKzoYVEQDudl9FRO boBuvl4ma5NEZPO6+qpGxsgaLXIChUGTd5udj7pEjvUQsguNhdth7rEmFpudkKHfXEQ3cpMXmb6m kJ7QGj0HlG0uIu43QCbnjukTbG9k9wsfylyC6Axo9VRVi502HK7c6DZmjy1jvkySaGveHEk87rqi NoY8ngHuoJJqCZs0Uhdvy07rcO7I0mqZvo6D1FNW5Ro5qeRrmSRhxLe+y1++O7IVdReIyPFpaN0O F1MQcypcPTI72Xy/he8dNf0z/TYVmJhnwdtg2Vp9TR8r1h1X8QHRfrbkiF1VmOmFRCBJEJ7BzDyv u49Rt79o/MarTS8ia6Mbwa9O6qKrjxmYmCmFg1o7r2tPV4fjEM9K2oZLdpY9gduAduF4h6R+NXpD k3Lj6N1folpWub5g4eeAQuhsN8cX8M68zYzS4yX5bll0vpS7ZzSVqbjOndUWpSVJdnZvWDorUdNO sArKaOT+DVcwmje0X0uvwva+NYliVN0ZFZhrSa9tE0sB2N7LzVnjx29F8yUMNJiM4M5IdqtfQV9x gvj86LMy7BEcwsZHHEGGN7L8dlieR5K90I4nBNNHSOVso5w64YiJa8OdHBKfOub6bFezcoZXp2ZA ny/HI6LREWF1radl51w/6gvQXKJqzhcpi895c8xxW1lC76lfSltHUvjrCxzm/Y3ly6Zcjlx0ZxxV Ucd4fc+YllPrtXZQhndV0Ur3io1u1Bjr7EL7n6huAMxjoi+dx2pZ2usfwvC9D4yctZf8RkmdMHpH twiZ389pFyfldpeJv6guQupXTRmHYM+WrrJj/Op3NsGlblslNSX/AGSWHJsaMLwfZOxasx2iqcKi M24e55+1ouvcXiNzFT4R0axZuJ1McJfSuZKSQBxuvAfhq8feRulGXhh+JYJNBJcapo2+ohdUeMLx o1XX3EBgmWvPp8BPIcbavysxcISU36GTHknBQPNsscEtXilRBZ0BncI3H2JXI4MBO9rbfbv+FxsV G6jibR31bgusuSppv4bMHMGq43uvm5Jqc3I/QYobMcYHvPwZ4Y+aopaljdTGvAO62HdUsuPzX0vx PC4JnU8stKfLezY6gOFqC8Mvivo+iOKTjHKJ9ZQSbtDBfSvUeN/Vly7Fh7I8MwKaZwFvVwB+F2wK 6r0fO1eOSTo8XS4viHT/AKlzQ475tM2CstI1zidQDubFbluhefcv9S+mtDJhFSyWP9OInsB3abWW kfrl1bd1qz1WZgNGKESuuA0aQub6IeJjN/QHFW1WEVT6mlNtdK9xLHD8L155Jukzz4sF43xybAMQ 8Drv/VyvxOSds+GVcpmJI/ey+b8VPhJyflbKUeN4SBT4nAA5zX+kPPwvhm/V9nbQGOqyh/xYbYOD tiV5a69+NHPniCrI21E/8Nw+F2qOmp9gRfYFblPfFbvRww48uOVLo2u+CbCZ4emtFW1DNL3tLW/h fAfUw6WYhnvpPFW4fE6V9DLrkaBezfdeKeif1Kc0dH8uQYHPhgro4QRG49lmdS/qc586mYNVYLBg 0EFJVN0PIHYrxxybJ2dtRp3OkeUcFa5hqKKXcxPt/Zcjl6pdR442cXDqd4ez8grjXTTnE5Zi0CSY lz2tHBKypBJBaoaPT3XiyLc7R9zDcYKLNvngc6x4Rm3CY4ZJ42YhobG6NxHPwu+epmSsdx7NOCYl hNa6ngpZAZ4r7SNutF2Veo2Yci1LcQy/XyUsjSHfyyRuF3bhf1H+slLQfo21jJAG6fNe27l0xS28 ng1OOS5Rts62ZYnzZ07q6SCLzqprQ9jWnghF0+fRYx02pMIdIxlQ2n8meIuF2utY7LTlVeOPrJXO lvmiaFjxuxo2svn8G8VvVDL1e+oo8YlfI86nFx5Puuyzx2KDfTPF4JuTkkbnOjHT2r6euxaKqEQZ PMXQua692kr56voIcj9bWYzU1LYqPEW6HuPAd2utSNd4zutNXWiX/U08bv8A6bXWXB5l8TXVDNzY 4cUxmplEZuDfv73XVZk5NyfYjppqopdG7bqPkhma8SwjHqGZj58PeHgNfs9qxus2B02deluIYNPO wOrI/LcCQRcrSvSeKfqphdKKanzVXRRAW0mQkWUHii6uyRSRtzJJLG7s93CqyKKXPRnJpZuTf6fM dZOn3/pZ1axHLnnNmjH8wOYbix3XBU2KMpqqElpbYjS5LxCpxfNOPuxPF53VNfL98r9yUyqpWygR E208LxTyPJK2fU08PHBRZtA8Aniey87A48s4ziDKTEm+lgkcAHD3uvW+fsqYLnKfC8ZjxKmpquie HMqHPbYt7haCWNqaB8U9BVvpqlli2SM2I/dczWdZOotZQijqs3VrqaMaWMbMRZahLY+znqMLyPg3 udT6HCM45HloXYnTHymiUFkrbuc391xnTvq1ljMuWm4NUYpSUtbDH+nkhfM29gLXWiWi6h54gj2z TiOh1zb9Q6//AHSIsdzGyZ1RFi9W2Y7uk883J/K9O5bas80dNJttm7PKfhh6VZZx7EscLaHEJ6mQ yu82Rpa0nva66W6yeJXI3h1z/QT5SZTB3mCPEoYC0hzCd7W9lq5PUPPr3ER5pxJrL20+c63/AHXF zMrqmZ1RXVj6uZ+7y9xcSuvlclcnZlaHa/qb98sdSenXWXLdDisNdhtZDIBJome0SRutwQd10P4w /GblHpDlKoyvgFRDiOLVUZh0UzrshBFtyFqBpMTxLDC9+HY3XYeXcxxyOa3/AAVhVAqsRdrrqx9U 4ndz3FxK4qW2mWelk3SPbngazrl6rz7+vzViENLVMmdPDd1gTdbNcY61dO6vCKiCqzXhjIponRvY 6oaHWIsRa6/PS6BrKlop6qoppGC7XREhDWR1E0gfPilRLJ7vkdf/ALpLI8kk2dvjbIbEbL+k3icy n4des2P4PDVR1WUsQmLm1ER1Fpud16ozJ1k6E9X8MoxjOYMMq4YniWNtQ/Tod+60V01E9oMhqi53 GpxJKF1GZ3O11kmkb7PIVlmqW72Z+GtiizdX1f8AF30k6V5WbDhNXhmKVETQKeOjDXNaRxuFx/Rv 6hHTjqTgLqHNeIU2BV32eVK70St47rTF/DIS31yyuZ8uurlp6QNaCXOcNgQ6xCeWM1yY+LKKpM3p UXWnoJkemmmpcZwdhkJe90ekvK11/UH8T+WeteZKPCsqMFXR0YA/VEcHvZePXUcMDtc09QGP9nXW Vh0FNT1LHxt1xcknkrHnknwYhpGpcmW6mqI8OimLtIA3Hys/C8fqY3xz073QVEW7Hg2II7pdfVCq cGsGiMcBYU0pZtE0An2XK7ds+sntjRsA8MH1MxkfAIMudQYZayCAaI61hu5o9j7rvXOH1OOllDlW tky3VST4uYz5cLoyA1xGxv3WpCHDnVgAfC6Z/wD0tugqMJhpn2lp5IgOSWL1RSq0j52TFGT7O66L xc54pupBzcysmkqROZBqd6dN/tsvfOQ/qpdPK/LcEuZxLh2LMaBLBG24c74WqP8AUxQQhkfrHAFt 1TcuzVTDUvoXlp4IbyusrnW5WcVp4wjwz134vPqDz9cqP/TGVo5sLwhsmp07TZ77cI/DT9RfHejm Gsy7j0ZxPCof+XLNcvaPa68eRUUUEw9JiI/pc3dch/DZ8We2KKl80XtdrblN3G1rg6Y9PH+TfJsb z99WnAq3LdZSZfwKZmKTRFkVQ592tJHOy8PYZ17zxS55bm6DGKhmIiQyOOokHe9rL4OuypNghBno nw97vYQFYY+TSylaXE9guMnJKoKkbjp8bncnZsKyb9XOlw/BoabM2WJa3E426XTU5ADvk3XlvxS+ NfNXiGrn0rXyYZgTHXgoYSRqHu73XV46aZnrKVs9Lg1RUNcL3jjLgvnsQilwGZ0NfRPpakDZsjdJ /ssxUktyRnJhxTklZxWF1+OZXxSkxbCa19HiED/Miex1iCu0c0eLTrDnTBH4Hj2POq6KZmhzQACW +xsupv5tSXPe+zb3AWZQ01PvL57XSAcXXDe3K2fQ2KqOWyd1EzH06xWlxDC55aaogdrY9jrWN17D y39WfPeCYRHSVeFQYlUsaGmWZvNl4spqWavkDGEvJNgBuvvsD6D53xyiNTQ4HNLBa+vyjuF6oty9 HmzQg+JOjn+tXiyzj10zNTYzXudSOpSHRRxuIay3sF2H06+pp1W6d4XDQPbHjVLD6WNqBu0e115s xfA8UyniMlJiVDJA9ps+N7bEI2UzJWDyw10b+wG66ZpSfa4OeLBiVtcnsms+rv1CrKNzI8tUNJUO FhIATb9ivIvVvqzmnrhml2N5lq31FU7ZttmsHwF9tgvhl6h45g4xbB8tVWIUL26w9rCRZdZ5oosR yvXuoMSw5+H1jDZzJG2N1xalttEjp8SndmHg2a83ZZqnU2F5nraCJwtpZUOa234WPWSYvUVjp6uu fXVDzqMkjtRJ/Kx3QVcwMrIvNB7jkJlLUziRl2OLh2IXBW2e144Ps7K6XeI7qX0iJbgWJzU0d7iM POn+y+2zb47OsmecLfheJ4xI6mlGmQMGnUPkr5vph4fc59X6nTgFDLUHk6W7D8lfY598GnUzpzhD q+twaoqaaMapTFGTpHvsvXCcm6S5PDkxYvbOjqPGMVw+u/W0tRJFVtf5nmMcQQ73uu4sH8b/AFww LDBQRZqkmpGN0tD93AfldXYVlysr8QjpmRudLK/Q2L+rV7WXpTKX07+pub8EbiTKRuHRyN1Rsn2c 4e9lpxyp/Z8nNwwpUjzPnDO2Y+p+LzYpmCvlrql5JIkeTb8LAyrm/NWQMXfX5Wrn4fUkWeWu5X2H WboLnPojjJo8foZqeQklkzRdkg+CusL1FWBabyyd3X5XGcJLlnpwQxLiB2dnfxQdWOo2CQ4LjeOz Ow+IaXNjNtY+V11h9PXxaZ6Wt/TysN73sbqxQgRBkMhJvdxJX1WRen2KdQ8cpcGwWlkqquV4aAwE 2XKLljO3jirbQVJ1f6jYZAaekzPiMMIFtLJnAL5nEsTxXM1a6oxismrKg/c+V5c4/uV73w36WWda nLcMtTW0zaqRgd5TX7t+F5j69+GXOPQGvEWN4dIyB/8Ay6to1Md8XGy9EJSyKkzzSWBSTkjpumkb G57GN0/lN16je3qHdcfS1D3vmlkIa1g3Cy4qgOjZJ2dwvHK75Pp0klQzTqfqIujbZt9uUIcWAm/K WyYyyEAWKyZMi43VadQJGyMwuYBfuqDbmwUoAXsEL/5bRZMLA4kXsgdEAd+yhqynDU3mwVxv0Cx3 Cst7Ig0adhcoZQ5gBG43QujZqB7+yuKS/pNlCdiFbBj1LdZvbcLGdTulsdRH7rOcdkskJYDiprR6 w7hRrhKeeFTCftPBVxxNY42PKoCFw63ZM02G6AAh2x2V3LjushEDNXB2T42aBukh5G3CIykn2Sip EJJcfZX2Huqvurcd7KooLmA7k7pdiw78JrgEI/m7H/KoBNn2ICaW344Q6fKFlQcSUBbrE/hXY6rl Le8taTZHGLs3KAtw1EjgjhSE77jf3ULQ3gobm9wUAUj91DuxC5pPZMjF2WsgFEaQFdg5nsqcAHcl Xs5uygKNg0WTGyAW9wgbEXKnDyzYqgbISRcoA4PBaWogNlA2zvyssGZTH0WHAWYA0NaRusSnc1p3 49k6SbQNI4WGjSZkxtvIQCs+E+WwWO64umaCQdViuRhYGkG91yZ1RltOptjuht6gL23Ua9rXBxVP cDdcyjo3OEpLjdvurOnzCWm4WMyQtPOyyAWtG3dTg0inaQdgLpUTy6Q6+Ux7A6x4KqNnluvyrwOB wYHAlKmhcXAWHCMO2VOkcH7bqEEGla4i3IVVcIAbpCzABYHgpU+5CCjB0AAEjhGyIEkkbJzi1pAI uEWkkXaLj2VtkEeUy17JJpwW3te6e+4PCYy/ln4SxRjCDSAb2CbG8MdtujbplAB5QBulx9lGwOa6 KRh1N9XZJBA+EwMFrgblIleWvsRZAWx41G25VaCXGw2VtDQ7ZMGwSwAyPcC1kRjBv8KSBzGgje6k lwAQVbBRuBtwqJtpBTmbxb8pTmg7HlQAOJP90xsgbtbcqnNAFv8AKq9vlQDXN2+EBFxsFTXGxJRM f6VSFBhNt1NlHu2HZBc9x+6heQrgbgXRhpcLf4QAXbcKNcR+UIHpEZ2N1jyO1m3snElDFE113FCg wsBuFTwQTZM0WBI2urtYDugMRstja26aZhbhR1nu43VFpPbZaoFtcHtN1jOic03BsmPcWd9kvziT 8IuyGPO92k33PuuJlGpxLjuuUq5AG+xK4yoFhdd4nJiRFquQUGrzGEEDZWX2Yd7BY8brm7d2ldTk NFmj4VXBcq2IsOFdgNygCHHwrI9KFv8AhWL3T0Us7cFQXBO11HBUgCDgEJbYX7qW2siaRp359kAv SbXsoS5tiLFG9x0249lUQu7S7YWQBNAcPdUWiQersiB8vhDruf8AwgBEZN+35Ua0j8phJLfZBcBA FYIXtDeVWsOdZW4bcoARyr5FyEIJUAvySQgL3P4RauL7oAbbAXHsrc4AWtsgBeLvFtvhG8cbJIN5 L72RCQvkdtYDhAQ8W7oiCGAhA9w7ndCQQzlAO2OxS5mho7IdWhlygneC35VojEk2cb8INet1j2Ru tov3SZfTbflUyEW6nIZW/NipGB7onRB/9SjBi6HSnnYJxis0AbpjI9OymrTuTdUANHpueQqe3zLa eUVw8G2yBjjf5QFBm/q5RaAWm6IMsSSblWRcXIQFBrrbFFwhG1rItW5FkANt+yE6u3KK93WsrDdi e6ApoFzr5VXL/Tf0owLjjdS1rkoBRa4P2NwETQ617Jg3F/8ACHzTYgceyAH0P7i/sqI9twiMcfIF iq+14t7IBbXeW64HKbBy56F2+5CpttxflAFI+5NgghIY7fclCQ4E2KtjSN+6AN0o1cKn7jVwqLRq JIUdu2yAjR/UHJzgXtBNiRwqZC1rRvz2VuhIHpKAn7q4+SbboQWxgA7uKNl3fBQBtGyg1Odp90Zj 0jcoms3BBRmkIdE6N1nndNgYb+rZqJ8Ye+7nbohKLAEbLJRpEd9ilBvr1duyZZhsL2QyDU2zDuEL YTJDq3REm9wodohcboWg23FlCBOa2Qi5sfhAWmOQC9wVR23QtfeQXU5APkankE7KjEIX+kWHdPDx qQy2a0n3UAOx7omtB3JS2EEcJwYCLIC9LdrbIi7zHAHgIBHY7bq7GM3PCAOWMW2HCxgwjcLNB1Rk rHdZoutAVffcG6MWdcg2VtNxuNlNLbHspQAJ2BA2U1Bx5V04M2pvATvJDALDdaBivcQ4i5UjlDXA ncpz9EfqeL/CW6Brzqj777qIDTJ6tQtZQm+9gEsxONttk0C8fygAd+ULhcb7qyQHC6MAavgLIAEZ aG2ROZpbchETfjb4R6Q62pbBjPY+wLVbWO03Nrpgl8t5af7IPKex2px9JUsAsGs+1kbSC7flC5wY btV8i4G6oBezS0kblKcXaQTun3uAOEL3aSBa91AKa17/ALTYhT+YB6imS0LnaZGylnu0d0R02API VArVc2KYwACxKry2k8boHAiQNO3us0BwFtxuik2HBQAlnCp8pcQD/dLBA0taS+wUaQWDSUBcSdLi SrA08EKAMEbBLlDrg/0hRwJcmiztiELYAAJBPHynOd6dtggDbCxQvdYWQgbvU0EdlTt3b8pTJCBp 7JoIA9R3QqA80+Zbsje4F4sNkDxqcLIiLW2VYYYaHXSywN7K7nUrO4JChSAEhTcN+bqNKlr33V4A qZxe4ABMF2ixbsFRve45RtB4PJVFmMZNRNgjYSG2tdWIiC4W3KKPuFkELrjT2VNdpIFlThYq9Y2Q WUPU74UJvcdlLWJUj3BAGxQyEwNtdW6zBflVtG3m59kEQ1v9XCAZ5g07cpL3kgp0sTbbGxSQwhWw DGLbkXTCQ0+4KqxF7J0LGvbZyWBLad8hJYVT2Hg8p5k8h9mG4KXO0gar8q2WxIuDyjZEXb8IeB8o g46RY7qlLdETc9gqFuEYcSDuhc03BCAsTEtLT2UB0jm6mppUuwD2KAjTrf6jYKnXvZvCJwFtlVyD blAWbaeN1QP7KyNI3Qgg2QBO72KAh21uUR+1U3i7kAx5c6MX5QXHco9yEAjsN1LIwiwOs7myAu/t 8IyQ2xJ2VFzHbAJZSB4Dfyh1H22Qk72ATW/b7KgDa6to3urtuqvYmyAu1ge6qxULtt1ARY72QEsT tt+6oj9kRNlQNygKdbbfdVsNyoRcqFZolEsAduVRuDuN0xjLbndRzRLveyhKBjO5vwptq2QzFsRa Bcg+yIf4Q0hhLXG3dVZrR6dzdLsSVLad+6E9lSts8KxuUJu4g3Vs+UKGfuVFwvv/AHQvNuCgJG+6 pLKdKQ4gI4HaL35S4vU8nhMewGW91bFhus+/ZU3ZpsLlQDlQILI0XFz/AGVXs/4RcfKp7hqHwqWy 72NwLqnSFzSOFVieDZWGhvPKAU1jrXCaGghECLW90N7ICEAWQ73vdETsqvsoyMp13C5Nh7IWkHgq AG5vwpGwOJsLWUsdh2IuFHgOaW3KICwuhBDnenb3UFARQ6Qb7qEk7AWRuO9wd1G7FUgskgWtuo27 wQO3umGFzgTsgDS0oCi3SAUbHAbE7q5ALDdV6SbEKGinzuFwRsqYbi6skudayt7LDb+yEZevVq/7 oWNLuTsg+1t0dNck34VQ7G3AAAVcA2KBxDXndR/2jdWylWBO6oG4NuVZcI2ke6WyI31e6MMsXcTc KamjjlNNw21ljx2L91kyGQCeVZtsAlvOl+wTA29igJYi5QFzgmF1m/4QvjuGkG6GiomNL7kWKMtA JtwqDRqGys2uRugIx2xb/lY7YDrkkJu7snBwvwptuEIwGj0AnlHs4AAbJRJ0Xvc34Rh1zbjZCEkb YWCjQAAb7qBvpO6jWEC5QUG9t2j2QRhhYS7twlzP0ltnd1c4Nm7+kqoEdG3dwNkUT7MNrEjdA4tc zSp6WtsFoFySOliAtY3SPIZ+ra831ALIjaNN73VOYdYcoCEDe43U2LVHude4F1G+phcRuqAZPSAb XUY+/IUc10pG+ybHFZu/I7IBDjZwF91kRw6/6ljzeogjayW2Y+eB/SFAZbraxdDKdiSOEuSZokA7 q3P1CyJguF+o78IgGucQW7Duk07CyT1cLJLbtOnkqgpoa5hIOwS3Sh5AagaHQsIdyVIpGt5Fr91G BgFxe6W+znc7ImRFjyf6Sk1bSfs/woARK9j7MJITXTvDb8lLij0sv/UmB3p+VALdUvIvYhFTVOh/ r3B90DpdINxdURqjB02QHIPDZNwbDskT2iiuDf5SWShjbOVzSCSPS25KAQZXgbHYqiS5trkfhPjp XPZcbK5IRG2/JQDw9jYAH234ulxgC/8A5S2uaQC51yOyPzruHp291qgLqBfZosFiOBa74Wc5zSdi PwlBhLrkKgGFpO/KNwsPlV5hYLAWQ7kH39kBZA7d1TorOAKjbm1xYpjj6veyAQYTqIsqMZa24TfN cZLkelUZBY2GyAQ9g0arbqonWHFlYcAd+EYLTwpYBAvIjmjDjzuFYAJQlu53VAtrbDflU/a3yqe5 U7U4N2QFEf2TmubYHuluGhqFrtr2QGTqDgluGygbvc7BLdJyL7IC3N1M9yoxxt8BLjL288FMYdV2 2QDWvaNjwi5ultgMYLjvdRodza4QBWPfZVfYiytrdbdj+yotN0BbHADSeUOrSCDsEOvRJconWk3Q AxgauUWsk2uqZHud/wBkIa5rioBhdZyINCW35REEDlOQVIS0hUHk9lC0POxViYag21yqCNvpIvdQ faSNyi9IBJ2V3DRcC4QCGi977FMDw5gA3KFz2u+EIYS4aTZAG48C26VI1zHAt5WTptYkpbm3dccK IFx3dYnuia3kXVGSxAtsi1boCjEQPf3QNZpJsE4SDSRfdQPusgAEgXUJuURaCeVYAQCy07dlLEph +5C83tZARtwEWxG53S9wQBwiIJCtghaLg3UeL97IC07WKtovyUsFWLbb7I3xRvG1rpcriSAN1PtI UAt7fLNiLqN0697gH2TQ4ONyEt3pN/8AC1YJINjpuU+NofEDwQlay21u/KG13fCgH3ulvsQSo1xJ N1QG+x29ksAtuDySjB2KIt4NkuT0G4N0AzkhQNupFIS257oPUHc7KAMCxuNkTbsJ+UGqxBvdOinj JGo6R3KBFB40kN5Sg0+6a7yi86DsUBNuOENH3LDa490D3CSN0R7qtXqCGWVrTx+68p6DioIDS1Dg LEE7Fc/Rk6Pe64WZ0d93EElczh9vKABuoT2Zk8x8oNABt3XHTxmQG5XJvpwW3LrLDkaBshoCFmiM C6Y9xDfTwqAs2yp0lhbshATvuUD7/lEDqtYKn7AoDFqZC2MhouSVUEryy1rlDJIddgLlNy/hVTj2 JikpnWkebWW4kdVyJ8uoqpHMhiLrc2C4eXDZI6jTI2Z2o/aASP7L3D0m8PdNhGG08uJU36qrnt6L XvdelaDwPZexbBo8QnihonPZrOtgGnZe6EJTXB4smohF0zUbUYe6Bg1RyQt9nggLkqfC6mopA+HD 3yg/1MHC2l5E8A+ROqMWIiur5Zm07iyN9KRpv8lfA5s8HuG9FOodDhDKiSrwuucA2SVlwF6IYXN0 nycfkY4q6Ne0WW5pW6n08jT3DhumHKVQ0DTSSuB7tBW5KLwUdOIcJpK6rpxGZGhzpXus0m3yvpKH wSdOaymZPG1j4ALkx2Isujh4/Zh6q3VGkqbKD7tEkDm6uA5pCVLlOKj0mWE3PBut2tF4Qej2MTSU 8TYp5mEtLQ8XBXIUnge6YxukidgsE4cLancgLPjj7ZyWrj6iaSKPKlU6ndNRhr2d2WXFS4M98pik jFLOTbWBstrvUzwN4VkPN1FimDwGTAaiUMmp2AnQs3rx4Mcr0XTafGcKomGSng86R2kG2y55cTSU oys6/Li/q1RqpxPIWP4XSxTRUM+IwubcyRxlwH9lxtJVeU4xPp/087exbbf91tM8D2K5YzLQVOV8 SgpRWC4idUMBLwNrBcr4r/p75fzvgNVjOVoGYdjkTTI1kIAbKR8LljxPJw2blqIwSZq1o4pJWPe6 wd3ueUusd5lN6TZ4dZNqcKxHLOL1OEYrCaaupJHRSMdzskTFjq1rGkHVyAuE8bg6Z74TU47kdhYJ 0Bx/NeHxVOGvNU1zLkBt7LMn8O2bqGMj+CyykDdwjK9I+AnPNFQz4lhuKsZKIAHwh4vqF+Fs7y/g mA4plqlxAYZTPbNHr/5YuvVilGJ5M02lyaAcfyJjmAv0V+F1MUQO5MZACPLXT+qzbVNp8OY98rjY Bt73W8o5R6b9WG4hhb8EpZ3wOLJf5ViD8FdSZb8H2FZH6ntqsCpGx4S52t3mbkG/Ze6MIyfPFHzl q6XRq4xbwl9RaGndUx4HVVDALk6CbrrSpyTi+FYs2gxmgqcKlebAzMLAf7rf1nHqnknpXX0OD43W U1JPVWEbZWjddP8Ai06RZF61dLZsVpZKFmI0g8+mqKewLiN7EhcJV6Rlapp8GtPKngszVmrCGYlh /mTwPbqaGi9wvmc79As69PIj+swapEZ2D2xlbNfAf1Kgr8FOU6yKMVVD6Q/Te4GwXdniXzDhWSem mIY5X4ZT1raVh0sewbkhMeO57X7LPVSitzNDcVUWB4kYRVxmzoyN1mU0zp4WnRp1cschzLiZzLnf GMcjhbTQz1DntgZwwX4Qfq2tmbI8hrDtYLyTjsdH3MUt8E2HUVrKYiNpDSeQAsfz7vbbSXfAX13T 3IrM4Yu2nF5HyO2v2C9P4d9PTG8x4bHVYVeVzhfV2CxCLm6MZMih2eMqurqxA4mEBo4I7r6np9ll 2c6+DDy8QySmwcdrLsbqz4Ueo3R+mNVjWDPdh5PpqIhqFvmyHo70zqsUFJW00xbVGXZjdiN+F1lp ZpcHF58dcHZJ+nzmnFcEbX4BO+tltewFxdedupPTLOPSPH24dmegkpg7YOc2y3Z+HOgzLhOWoKTF qYQ0TWXje/73fleUfqhZcOLVeBubC27gLPA35svViwLJLx+zw5NX46k+jyV0M8ODetErqSGoc2sI u1gX0/VX6d3UDIWFT4nSP8+mib5jmhp4XfPgk6Y5py3menxzCqL9RBpbHO+Qelo72WwjODHVmTsU jmja8/p33aRcXssSxKDUWWWptWfncp6mrgqZqWoYWVMDixzXciyRNI+afZxuTa6+l6qNMHVjH2RD TqneLDjkr55kbGR+k3kadyuGfF4Z7T04cvlhYVO5/wCrbDq9BHJ916t8MXhbwjrVSSxzyH9dY7ey 6CyDkKpzVikTo2OeC4cDlbJ/CV4dcx5Wxegx2CY0VKLGVjgRrCuOFuzU8iijz110+mvmbIOVavH8 DmZiDaYGSWnDrkMXiWeGspKwxSNLNDrObbuOV+iDqlTms6e47A4m8lI9t/2Ws/pL4GZusmM1eISz mjw+KZ2t1vuJPAX0McI5MTcuKPmfJcMm3s8M1Lo49L4fSTs65WNA6QTuO5bb7itr1V9LLJk8OiXG JmzEbNbtuvgm/S5hw/OEEIq31WEv3dIdrLksUX1JHqerinyjWvWxNkJcx4LvhDHQvgjc97nOe4cW 2C93eKH6e0PSnA4sy4NVj+GslDZ4yd2rtXpR4Ecr9Vek9FXMe2nqJYrNmLbm/uo8NfbdwdPlLpGv joJlemzPnalo8WAbSvla1xcPcrYtj30zsp5xyiazD6ptFUyw+ZG+3G1wvPDvD2OiXXWlyrW4g2fV UMkZK0cDa11tZw7L76TBYHRz3jZQ+UIm8E6eV0eNY6d9nmzahtWj8+XUPp7W9OM7YlgD6ltYKOZ0 RlZwbFcG6je8aC1zT3JaV7Oyn4cKjqf16x/DcRJBkxJ73E9m6l7xpfA30ny9g0f8VoIC1jRrklsA T+V21GHFjkrYw6qTx3Ro+1Pp2eU1zT+dlkR4RVVDbw05kNrmwW4rOn08+kfUHBJqjAYhBUtafJkp 33YXfK43ov8AT2wXAaV3+pAyZzHkNiYN3N7XK83jxfyvgfMfVcmoxmCYlpOulcGjm7VgTUzYKrSX mM23afdb45PBx0qdC6nOCsa5wsTfdeMfGr9O/AMn5NxDN2UqiaD9K0yPp3nb3UeLFL+L5NLVtfyN dtK2plje5zrNB2XLZfy/U5hxCCmiveR+kW7r53DZagaWy32NiF2v0Qq4x1EwVkoAh/UNvfuLryNO F2fRTU1aNgnhK8DWHzYbTY3mSDzI3AObG9vK9GZs8G/S7NmHTUBw2CFz2lutmkvaV3HkmnihyZhT aezWmna4W+QujckZKzdVdb8WxqXFC7A45S00znbfiy9OFylFyTqj4+ok4SSq7PCeZPANi+ROs1Jg dPTOxDBaufVFX2Ia2Mng/K2G5K8MnTzJWVqbD63BqCrkDBrkqWi5Pxddu4hS0ss8Rnia4NN2vI+0 rqTxL5IxzPWHYZSYFiDsPfG/W+RrrBw9l2U3mlGK4Z55bscZSk7o6U8Tv0+cn9QMrT4rk+kZg2NQ NMjWwfZMOSLBcJ4NfBzBglPNiObMMDw12mGCobuSO5BXsHpdh1bhWS6KkxGb9RUwR6XyXvqXP4XM 6riqXutG1twCEnmlFShLmvYxxlKpL2dT5n6H9Ic9OnwKuwChfORpcyFoa4fuF4vzR9PefKfWmhpM KdJNlavfeE3u6M3vZy9ZdJenVYOpONZmqcQfKDUOYyDX2vzZd+1kscEkbpWAsJ2d3BUk/A9qd2hB zy/1R1tl3pxkTpblWjw2thooNLWsM9Q1oLnfkrrDxK+DXJXXDKc1ThtDDS4xHEZIKiAACTa4BXY3 XzpPT9S8KgFRXmjjjILQHabu7L63phglfgWUKTD6+f8AUSU7PLjk7lo4XNNxj5EytyeTZRoKZ0Kx eXq7JkuZ/wCne2fyS923ey9Z5n+lHmOmyb/E8ArmOrWQ+a6OV9tW19l8h40K09OfFjXVlH/LFPOy sc0Dnuf7r0/gP1WMm4hlAUlVg1ZSYqabyWhwtG5+m17+y7Z8bhJOK4Z6cGeUov8Ao85+CnwuDPHU Y0uNNBiw19qpum/qB3C2m4xX5P6O5ap4JoKSlomFsLY9LdTjwNu68ffTaxZuYc7Z0xN7hqqZHSsb e9rm69O+IbI+CZppaCOvlFPUzTBjZHHay5qKeVQbpHPPOaxua7Pk/EZ4Wcndf8lOrKaip8PxUQ+b BW07GjVtextyvA/h68G2I5u6rVGC1LHDDaCa89W5pDXAHstr+TMpRZZyZT4TBO6rjZHpEjjfUEGV 8Oy5l6SeLD3UlNWuJ81ocA7V8ha8iUJQ7/DjDyRaldWcplnKmG5PwCjwjDYGRUsEYiDWtG9h3Woj 6neW6Gk67FkULICaZspDG21X7rcDQUrhVSVDqgTNd9oB2C1y/Vd6f0jsRy9mGAtZXSMdDJ7kDhY0 v83FnTUZNiU0dbeDXwO4R1uyY7G67EZIHP8AToG4AWD1/wDAR/6MZvy1+mxkYjS4vVCBrC2xbcr5 Pw0+NrPHQ2g/g2G5cdjGEtJsGRk3t8hfZdRvFnjnXTPWWauvwz+DnD6uPyqctI0m+53WIL7vd0ez JKSjwbI+ifSPAuhPTmGlw+BvnMhEtRUlo1vNrlZXT/q3g/VeqxfCWsZM2luyWOVuzxxwvtMMi/ju UaQVO/6qmY6S3y0LqvpfTZSwrP2I4dgT2/rm388MI/yt44qam32jxZN0dqXs+Yb4IsiUnU2LN1DR iIiXznUu2jVzsF971m63Yd0Ugwo1tMZKaocItDBu3e2y7FrGSvxamDS4QsG9uLrrLrZieTqPEMN/ 1jSNmpA68b5G3aHLUMjzSSyc0jGSLxxbiw+pfS/K/iN6cNZidG3yaqHzKaoLR5kdxsVor6vZIi6f 9Ssw4FFIXRUNS+IOPexX6Fsr1+HYngME2GaP4cIwIQwWbpstFPjVwOTBvEFmiItN5qt0jQO4K74Y vIp45dIJ7JxmvZ0xg8XnPc4k6AbLal9LzpTg8mA1mbHU7JalrhGx7gCWlawsMpHxQNvSyxxOH/ML SBdbaPpb4jGenGM4dcCWGYO03vsvFki4Rdn3m90Tvfrt1squlmMYJRUVDJWyV7gC2MX0i9r2XNdS +muD9aumstBj9AKnz6cyx6mgOieW3FvZcX1wzfgXT7EMKxvG6aOoY5/ksLx9h912JgeM02O5cgr6 N3/D1Eeph9hZdNuyEJxX/Z8Kb3Tkm+KPzr9aMqRZJ6kY3g8QLIIqh8ek/BXx1IxxY0h12NNmhd3+ N3Do8H8RGZaNrgT+pc4lvyum6WBlLF5bDcc7q6uK37kfR0E5SxJSMiWTS0DYkhcZNNNDMHtBPws+ xc4o2xBzQXCxC8B9AGPGnvDRLE4C3ZZDaxjrHcXVsfGxttI/dDoY7e26MD/Ls4PvsVTnXcbD90Di SA1TToFu6yKCaLnhFpQDU2w90wc2QFWsd1YPrH/ZDI/TYcpZd+UA6QtbsRcpA+6ytpJvcqrHsEL6 GfHdE1rmHcbLHL3RkdyVmay+IC26tkI090JIvwULpbEADlTYmygD0gqmxHUN9kMtwARwpC53fcLV mrMjRZw2QSAX5Tg8Wukytv3UohGAvII4VTuLSNKjSWj4VvaXC9laCCADgLlBYl/pPCDSbk3TYm2N 0CKl3AFrqi21gEwE6rdlThc3SilKWVjdRjLu35QAkOJ+FbSdwDa6kjbm17JQvwgCdc37q2c7JjW+ hLe5reOUSA5hH7KnRB9yhYdTLjuitpbdClx2a0jlUWkuVsta/dU4loJ4QMay9tkZcXOAKx6acuFu VkgjubLDRDJp4zrBGwXJwuuy3dcfTu0jfcLOjeC24XFnWLHxs29XKa2APNr7pDJCLOG4T4pLXP8A UuJsI0DyLX4Rxwll9Scyci2yCeU6d9goVAvYCQqeCxl0Ebr91bnOtvwhALPJBB2RNa4yH5S5JCzd FHUb3I7IB1rd7pM7jYWUD9732RXs73QoDBdhJ5Kay4A3QXN/j2RsJshCp2nsP3WM972m3IKyZX6h +UprGuAbyUBGRi+yc4MbzyhjaY3EnYIZT5jgQgFOkkY46Rdvuk3MzgXA3WVI+7WgC1uUljru4sEB NQEgCyTGQzUUtoaDe10183mADsgFh4dGQlsBbsbpjgGjYbqXDIrnlABr3tdU5xcdlTAJQSdkBJaf dANJBF0N22KFrubomgC6AncWRO2Cos32OwVG5O6oKcSLBRptsRdEWm3wqaNPzdQWWTYWQlxIUILe Vem4CAW0u1WWQ1g082SD91k5oMrLNNiEATWk3QabclM02aLm5CF7gfhAAWhv/wCJE3Ta90Rb6dkl tg42N0BJacFvusN9O4C/ZZUpcRssd8jgDutxI0cTiWpotdYVU7TTtcDqKya1r5SdV7LFc3S23IXe JwZiSPc+K3BI4VRtEbAL8q5wI3iyoi7xbcLoZCBB3VhxIso0EEjkK9GkXQFi47/sjI07hCGgNBRW H90BRdsL7K7WFzwgc4a7WTC24DeyAEG4VkC+ynGxGygs9wsgKN9XKnsr0kuOygFnD2QEKJsYcLgo XNN/YIdLtYtsAgLc+w4ulay53q/snFvzuha0X35QFgBpuBdSw3uOVHPsAG7oWS+Y4t4sgIRYG+yt oaQd91C7VsQh0hu5QBwtBLroJHAOFuFccml4BGxViO7z7ICFzXgWFkBLRsjc0NOw2S5C03sEBHNA +bqpSALDcqFpPJ27KhCeSUARBEQFr3SJm3IT5JAbNBWK95L7W3VsjAf6XbbpcnqO4THWLvlDMTqG 2/ZUyUyIPFrkFC5pbsD+6aLgb90twcGkgIBgJ0AjcrHkdckW/dEHPAvuAqDgPyfdAVGdBAO90Qi0 uJBVhwG1go1vqvdAFfSQL3Vl5vayEtu5HpBbtygAP3DZQD1bcIy3a5KEAAfKAgZp5UtZqouKW5yA brLBcC6JjhIy/dLY/SQDurA0H2afZAR8mgcAJFy523CKZt2+4RR2A42QBOhOm6UX6Hb8p0s3psNl jO1kg8oB4cHC3ZAdnIYnWBuE13qaAgFi54OyZrAA90Eto2W4KqO+nflAEbl4uiA0u+ELnG97KnC7 7IAi5wUYZR72VPdawCY2pEezhygDaxhbqd9w7I47OdfhLLDq1dir1aReyAyT6m3VNcT8K4CJW3um eQD/AFWUZpChcu25VhjrEEbphaRYDdG4FoHuslMV0TmWBNiSnxXjk55VSxk6XEqB9jfulgyNAB1O dcIJZW2JBWM+V0l7nZCB/SlgZbUB2uqawtfyjbHdlroftk0kbe6MFvPa9kRZpZZ3Kt+i1+6gvL2W QQtAsp/VvsET4jpBQlthYi6oI4+WDY3uhicJXWc/SPlC6+oWG6XUsJaNt/hAZxIDgxvHul1AsQLo aZ1oxf7uykj9TtzyqAQHahp4RPOki4srjaWv+EVWA6E9iFQB+oZBI02uCmuc5p18tKwoCCPVvZZE jy5oubBAGJGO3cFARqc5os3ssZpO9+FkNlDWAWuoBcU7pHFunZHctIbypKCW/wAtwYflLBLRdxu7 3SgR7Gl2x3QknXsdvZWSHN2RNbdqUADcuR+ab3PZUW7XGx90JuDuLlUBObrJdbdR93x27oy70oXe m3ygI1lmC6t3pGyB8mltiqPqAF+VGAxuL2S3gfdZExwYdJ39kZF+VkCxI9w24QOvq35TmuABtyOy s76TayABjhqtbcd0XlF7ibqjHZ2r3Rs4IQFSxkNAA3SQwj8rIBLvSEL2kPABQCnNs7flE2NrDcHc qiSTur0XeHF2w7IC2tLT6uChB3VPeZOBsrDSwWvsgGtPp3S5A1zrA7pjRraQOLLBmnNK7eMuHugM gMsUbgHWuLW7qopmTR3a0t97pjRcHdAIuTa3ZXqNrk7qyywO6uJtud1bADX63HZWXadgmFmk7d1H xgd7FQWAX7iygJddV5el1zwrHJ+UAbHXFkRkAsSLlLBtvZBI48jlAMfIX3I5Vs9MZuLFKp3EBxKg L5b69gOEATjqQgN9jdDsN73smNIIuFsEsWndXpHbuFRl243VOcARc7rAIAGG7lYsDdvCB13jm6GP ULoBjrDe6Et37oXGzd+fZGxnmMv3VQKDSFLF7CL6fwrHpNuVRfY7IWio2hrbE6j7q3NMosCo0XRg CPayhBbmBoseQqa1pv7qTPu7YbqNju0nutWaILW53UddoBQtcAbHdHYu2P8AZSwSIiZ2g7FR8TWk gm6N8IZYtNnJZYXHc/3SwW0jTb2RNe0AnuEIYWcqOAI2GytgpztfKIbnZTT8Kh91lkF3uf8AyrLL i97kKgNAJKGI3cdz+FQN1am2BsQqfcCyFrbSA/KZO7TyLqEoW1ocfUdlQaGuJtsraBIL/apJcO2K FKsDuo03RMNyppDXFaoEsOe6oixVuuLkcFVbb5SiIltlXbhFe42VKlK7W5Qo77KiSPwgKsfwqFwr BBGyuOO7uVlkoJpIFiFHjU2yJ1+Adlj+aQ6wSihh4uGlv7pjhYICb2vso7d1k9gIkABCWgD5VOGm 1zyoTbYrQKDd+UwMCAEBFqv+6lAFwDSkvIDk2UEEBLHqdv2ShQcZAdc7BGWBzr3uqsLfKpvpBJ4U BbWlvdQnSo0qwBvdUEa6+6gALjdR1rbcIWu9SpKLJs7hVKLkdlQeDJY8q5XA22sssoIdcjdE06yQ Eu3sEyF2kEKAhDhzuoQO6syXB2QWL7KkCDQDfkKX8u7vdXC0ulsdgpUt324UKCXkjjZW5zWO2cL+ yAX029lRia31clAWRdRpNkQ+29uVALDhCewRI8c8KBxNyUTxcW4QN32tZChajb3RMbcXKq2hUJWR u/mO03QjHaLAW5Kx5TdrjfhMEpedjssapjdrBBuDyhDGiqS+QtN7LkYXNZaxvcbrD0ATAAbckrJL mstfn2QEcB5l9j+Fb9TngW2QaruuOE292/KGhbwpESAdz+FYuHeo7Ky0uvbv7K2RgzVPpsOUgS3F +6jotDXajeyuCmJjL+3ZGQLzC+OwHqRRkgHUbFDEdJ3KKQNc4XKgADy70kbEo3EQmxvZVK4Nj1Dk J8IE9P5ruyApjwQOykhaRYbFKbd17Cw7KyCQhUU0aSboh3VBpLSi+xm6BlAeoC2yU8F0thsjjc92 9tlYAjfqKELcwtA90QkAs0jdBNTudaYPNvZR382xB3HdUrMWVgdLv/ZOAuzextwrNNqdck3VlgbZ ndQyBYv+FVg1p1f4Q1DpInNY1tweSmllrb3uhSMeNFmqy083/ZUGWOyjw48K2C2tdc+yXdwcdvSq 1SB1huFkxRgDf/KWCqe3mXdYNRyuaCS0/sEmojOg2uuMqBOxzJGOu0chLBmtkc9xGkgD4TW04l9R Fj8JFPiWiVutoIPKzBUNe5wGyqAl8AZIBYX90U7GRWA3ceUTnF/ykuNn3dyp0AnDTuRa6JpNgQbJ evzHWPCIPDOeEBHvLjfsl2vy3YJg9YJFrKyHCO+yoBbK6232hU6TS0kBXCPQ4OKQ9zgbWuEAXnDS R3VPBfHtsUD2gdt1GyG4aBdKBckbi0bWTHbsDeFDIX9rWQSO1EW5ClAVJEXvDRysuAxx3afuSGSe v1J7HQRuMkhtdKBkMlY2MgH1LAlm1yEcq6tgDtUbvSVjtBduPuUBbofXq/wmh9xpAKLyyWB190ID i0kfsgCZC1u5591R9BO90s6hfUT+yJnqcOVbAqZ7iRYKNDnHfZZcjALW3QkC1+EsCHXDbe3dRjrG xPKtnrkt/SpPA7V6UsFedpeQ4elU9wINht2RvYGtA5PdA8WACWBbgDYWUbHZ23CuN4Mlirkd69lA WdnWuhINiieL2VAWVQFFhNvdNsNFu6htYpRdpeCNwtAPllrbpR9JtfZN2Iv7pRALrIBwIcOUlkOu Q3TW2ARNNuyARJHdwbfYKNdoJupK8F57IomCS6Ar9S4PDLXuqjqi6TTfa/CYIAXf9Q7rHnp/IcCO SUBlvfYgAJLpvVYHdW24bdxuUvQOe6AN2534UYbC9rq2xF1rnYpzmNYyzd0ApoGoE3CGQkybK3G5 F1QHq3QBWF7FEbAWuht6rlWyznoCrCM7Dcq2xtA1d0Ejj5lgE8REbnuoBLmGTvayj9RaLcJpaAgd a/KWBZbqsAnMjsQghBDr22TPOsbFLATi07WN0px9VghfKdfCFoLpN+FEAy06gOyjbklHpOom6vTb lLBWx7KtQadyiaN7FRzATwoCgQTsqFxcWRBgB2Nij4O5ugKFwEBYQ6/ZG6QOKAuvZC0WSFQcQbdv dVa5sBdQyXOnhCBW22KC1iUTRYG/Kp59kBY/CBzdLiSq1O1C/CYQEALG3JVPaL8JsZs4G1wpJaQ7 CxQAljWgW/ylP342TdFwbnhAXNA59SAJjSW78pTh5Drl17pjXHT2KGSIP3PKAG5eOVGxuJ34TmNb pFh/dHtpA7oBbeLBXftwhkcW8BVc6dR5QBCKw5uidFG5hBG/KBlyOdkRLWjc8oAbNAFkKYAA26H0 oD7toaSe+yxKyN3lOPDQsuJnlucRuSVdQ0SRlrhyvIeo4Ntawt8ssBPvZczhbwGNFiVw1U0RO0sb 6guTwmRwF3CyERyss4O3CxgbuJujdAXv8x5PwEWhpaeyGhRJbvbb3VOYAL8on30aUvtZCBNeGtIt skyP3+EZ4SZNwVUDDmcC/blfX9HZI4s2QOIu/wAwL5Dy7OL+4XJ5ExZuF5mhqHODbOFwtxVs5y5R uB8PlPRY5mTDmSRxvbFAH2d8BYv1Feo+K9N+jrWYNN+hmrJPKEjPSdJ5sV874Pcw0mZaykrqadpc 1oa9gO4XP/UsyLW5x6UUE1LE6anpJw+XSPtHuvs4aVI/PapNS5OnfAH12xPLdcMFxCSSXCq4teXy G5a/ub/K2LYzlfBM3R009dRQ1mi0kcjm3I9rFarPDBluXEKuhggGs62i7W787LavhUtNlvAsNpKy obHI2MNvIbEmyzO0/r2aUKgmeV/GT1TOGYbBlnCag0xFmuMRsQu2fC1M7F+kNIyeZ1RKbskc83J2 XXHi16KMx/DxmzCY3TPp/VPFFuXD3C+i8F9XUPyTWROjkYzXqYH9l7ckIvApQ9HixvdNqR8R1Y6G 47kHGsSzjgWLy09FAfO8jzOf2uuyPC31breplFUnEQBLA2wd3dbldIdZc1Z5xnPmJZTaJJ6WeYsZ TRgklp7n4XdPh26TV3SuKP8AibtM9S24jaNm/ld8qvD9mrOWNKM7S4O75MTwvE6mTDXVMLqi3/JJ Gq34XzXVjCmnpbj9JHuDSSAD32XnHxIY3iPT3rVgGJYY90RqXNu/Vsd9xZenqiYZlyNK+U7VNGdX bctXz/Hs2yT4O8p7lLjk05dGMbq8E6ntdSzPhmpKwlpa7tqW4bJeJPzFlCmrJ93yRXv+y1G5DyVi M/WPF4YID+pbiEjGx+zQ47rax0vgqsudPaeHE3tbMxl/wLLrOKttfpbvEr9GljxjYZLgviIzPrYW +ZUFwFrcrp6ipiMQDgbk7rv/AMc+YKDMvXrFH0D2yujfpke3cEhdEsf+hq2FoOpwtcryaqnNUfT/ AMe5PG9x6J8Otb+lzTTSs9Otuh9luL6QvEnTzDw8l2mO2/dadfDZhklZjcb7faQeflbhOj7H/wCh qSNwIGlcIxSs3qGz4yHHen/SPM2LCfMUFNilSTNJSvkF/fhfTdMOplN1LfPU0rHeTE/Sx/IcPdau fH9g2OZL6+1uIVQfHQVjGmmnaSLjuF66+nn1iwTGsnR5fkqY48Uj4a8gOevqZlCK4duj4+ng5xcv 7PNf1Ramuk604WyEyaYacOY5psGleY4utOfabLv8AmxCpiw19tw8g2K2meMXwrS9XqylxTDCDWmz H3F7C64KbwL5I/8ASpsOKwuixaOEufU8AEBdZShPHFmdO/HOUZnUH086gSZnbM9xdNJYF5O5Xsjx fYNHi/QPNccoBZHSuk37Ed15L8E+WYcJzniFJQSCamw+csEgPO69u9c8sVWb+kuPYRTAuqaulcxo b3JC8cJOM4v+z06qMZRdI/PpQzimrKqN9vL1lZNdGwwRaP6jsuT6gZGr+nvUmowPFonRTNJ1McLd 1xkkeqqYCQyNp2avNqH9z7GjnvxI9VeFTpfPjuiogGupksG7cLaT05wbGctZawjD2tZAyMD9RLJy 7fstcPgd6v4JlXHoMOxKYQyh40l5sLLaDnOhkzxkV0eC1lnVDA6KeJw/7hTE1Hh+zzapPs5DOWXM MzXlysocSgjrKSWMhzXAHsvNvhl6FZZpMy45ijaVsjKGpc2Fpb6Qb+y756bZaxLAsonD8WqTVVNi NTjuvkejNDNk7MOPYNVx+UyoqHTxyF3O/C9UW4wlBM+WmnKM6/6PpqXqlT1WfRlmngs8N3J20rpv xeZQp835pyhh85Aill/mOI4sV2hifTypp+r1NmujEf6XyPLlYTY391hdf8BNfheFYxDH5kuH1DZX uB4Z3XTC1jyRlH2jGV7ouL9HMVVXh/RHpfDUUFI10MDWgsaLF9+6+mocchzZkz9dC0aKqmLtI7Xb wuDxWjwfqzkIU1JWxSRSRjQGvGzgOCsvJWByZXyWzDaoxMnjYWlsb7iy5Uny/wCVmpOSVLqjQ31v h/h/XDMLdPl2q5LNPtdfJ0cYLZ3Sfc9xIC9TfUb6PUuSOoNHmKgeGnEHEvj9j7ry3TytZGbi5Asr rFeSz6H+OknhUfZ718AOT8MzHiVP+rgjlAIIBC2HdWs0P6a5HFXh0bYixzWgBuwC1P8Agv66UPTz OdDHic36amc8WceAtr2Y6nAur+SZKSnxCnliqowWPZIPSbcrz4lckpdHXUWosyqTF/8AW/TGorXt IM9I4kfOlfH+FcQx5CqKdgAmZVyB5HfdfYZSfg2Xcow4DJjFLI6GIxPc6VoJ7e66n6ZdQMr9Ks3Y 3l/FsbpKU1U5kpNUwIcCd/8AwvTW6E4r/o+XxGUZP/s5fqF4jenPTzqHLh2N180OLwsBO5LAD7LI yx4rMm59zDR4RglY+SWoNmmRmkE/BXEZ76E9MOqGZxmDEa+jqqmQDUTKz1BdZ+J/EenHRXKFHi+A vw7DsbwxwfTNo3tLnge9l6ccMMkk07ON5HKVdHbnjDwWsx3pDNSUcTpg17XShu/pCR4OcWe/puzC pIZIhRvIBc2wIXB+Hvxg5F6+5HhixOvpcNxMxhlRTVbw0PPuLr6zqP1pyP0LyRV4jDWUYDYz5UdO 8HW7twuF/wCt4a5NybjNT9HinxnVrqfxGS4hTyXcWsYLHgghbE+ktdNivTPAJ6lxfUPpGanOG/C0 84P1oper/XmTEMx1jIMOmqg5mo8C626ZFzrlHDMnYfHFjuHtgbEA0+e0G1vyrnacFFej044zabkj yt07MdH408VooiBC6V7nAbb913Z44KGtk6J4tW0FQ+nfSM1EsPZeb/Eh1iyX0l6+YZnnBsVp6oiw rYqZwcXe69DYR4tekHVrJ2nEcYpoqSqjAmpqs257FayTqUMj9HnlzhlDo1/dEurnWvKUUE+WzWYt hDzaVtnENHutpXRDMWN5myTS1+YKd0FY6MFwcLEnuutKLrv0J6X5WqY8LxzBoqSFpd+mp3Nc5y6i yD9TjItZm2sw7EGNwzL9y2mqQLEm6Z5LKnsjRNNFxpv0fe9UvGlSZGz3PgDcuVU1VAbBwveT8bLo rxN+KfPeb+l2KRx5Ulw7BKmIsklkjJdZeim9c+gGa8ehx6XMGDzV4G0tURf/ACuhfGb40Omz8iYj lrLhpcXrKiN0QfABoaSLXC6xlihtaj1+nkXllKSn7Zquw2SWpqJ3EWYXHf8AddidPaiHDsx4fVuc AI5Wknja6+Ep2yRYc+V40uc8uNlyVIwmmbUNkLDzyvkZJ75Nn7DFDZFH6C+iGYaXNHSvA6uiqGzs NM1mppvpIC6mw6PPGSeslVTNa+rwitl8wlpu0ArXd4VPG5j3h+qTQYq5+JZfmt/Kc77fx7L25S/U 86MzwR1VY+op6q32+XqIPtcLvp5NXSuz5Gqx/a+j1jmDG8Nwmmpf4nVxUjJ3hrDI8Nu72Xw/X/Ac xY/kI/6VqTFiEJEgex33N7/laoPE744Mf61ZwDsDfJSYLQS6qVgdYmx2cvQPh3+qHhuB5diwPqPT zGWnaGxV0IvqA7OXVQeJqS7RwalOLVcHuzoxNilP07pRjxLKqNpEksm1/lfV4Fj+D43DUQ4XX09X 5ZLZBE8OIPyteXiK+ptgOL5ZmwPp3HLK6riLZax7dPl35AXljw9+MHH+iWcP4kJZq6hmderincXB 1zuVXBSTlJ0zEHNSUUjZ9S5Oz1gPWX9RSPLcuSS63fI9l3HnHP8Ag+Vq/DqXEqqGB1W4MYJHAEle OsQ+q7keny86amoJavE3N9FODYB3z8LwX1z8UGaus2bhjNZXT0zIJNdLDC4hsQvwjbzNOS6G2eNO MfZuU685SxHO2S43YJXGmqadwmj8s7S/C5jppS4tgGUKaXMFax0jYtbrmwjFu5Wr/or9UrG+meCx YPmWgdmGkiAEcrtpGj2v3WT4g/qnP6o5BqMDyvg9RgdTU+h8pfc6fiyzyl430aakpb65PgvEdmbB OqXivxOR1U00H6ltMZmu2IvbYrYjlbwX9Ksw9O6Blbg0NRJJTCQVQsHA25uFo6dWVddVyVE1S+Ko JD/MJ31c3uu2cseM3rXkvCWYXh+bJpcODPJbE6zrN/7qajM20ke3TYJQxU+2eyvC5nnAehHiYxrK 4q2QYK+d1KyZx2O+1yvdPXXppV9V8tUzMIrTTVcTmy09Qx21loMdm/MD8XkxerqXur6iXzzJq31X XrjpL9TnOXTjLkOD4rQuxIU40xSPN9vlY8rclNdm8umbhRtQy41vSnIDajHsQLhR0155pzYFw9lq S6s+IXMGZeseLTYFiU8NFVVZ8tscna+1kjrx9Q7O3XPLz8DlposIw57g57YLgutxcrzphmLVOEVk WJsdeeN4kYXdyF3jNQW99s8MdNkyPb6RvN8HBzE/o1R1GZpppq6R5c0zc6Oy84fU7yHjmZIcMxih jfLQUEDjKGnYE97LzRkD6qXUXIOGQYXLgVJiNFC3S1zmkOXE9Y/qO5y6zZenweTBYMLpJ2GN7mAk kH5WcDcJPIy6jA3FQS6PQX0zTkfG8CqqfGIKGbEw+wbUEX/G6+y+oLhPT/I2WsMxfCaGipMabVBw FMGi9rbkBamKDEMZwKsM+DYrVYfO52rXA8t3/ZchieeM246WRZgxKrxWnb9v6iQut/dcJSuW4+is U5JG9Lwn+IbBesnT6mw9lZFHjdFTtilhJDSRawcPdfSZA6CU2QuoGJZmgq3TyV19bSdm33WifJ3V rM/SzGqfFcCrJoXsPpDHEXHyu85fqK9Yp8Mkp4cSdTRvbpudyL911xuStRdX2eXPh63Lo2V9VfG9 k/pl1KjyrV1DdcLgKya+0YK7MzllLLfXrJ1E+CaLEaGS00M8Eo4PytBma8x4vmrEqjHMWq3VuIVR 1Pkcb3/K+yyL4o+rHTijZT5ZzBUUVOzZsJOpoHwCrSjJbOGjmsU5p7+bN2+a845d8OXS+SfEqtkF LRwkRMkcNUhtsB7rT1XZvovEP4qaSurWk0ddVbxe7L8Lr3qp4hepHWVkEebMYmr2xDZh2b/ZddUF XX4NWxYhhFW+mxKA6mytNi0/C35vGnTtvs549POclapI3w4j4Tul+MdPW0TsKgpoDAD57bAtNuV4 d8NniFwTwu+IDMOUKmXz8tVE/kisJ/5e+y8pUHjX61UuCS4ScyzT0bmlhDwL2/PK6orMZxLGamet r5yamZ+t0l97+68sZ2mpHvcJ3x0foczZlrJnXbA6Tz62DEKMETQmJ4O/IK+S629a8r+GjphJJLUx ySwRGKkpI3DU51ttvZaS8teIHqRk+hbSYVmKeOkDdLQHm7fwvnM2Z/zVnOYvzBjlTXB5v/OlLv8A C6QnSSk+F6PDm0zk2orlj+sGfZ+qmfsVzJM3TJVSmQ3PFzwvnaW5Zdx3SpnRNpo6bQQS6+v3WWAA 1rQLABcsmV5XZ9XBhWGNEY7SUwvDSo1txZCW2J2uuJ6WUHXduNkeqwG2yr+lC4+lSyIyC4FoPChJ sEljyWAEIi7cX2Khoc1xJ37dlY/slxyNJt/lMJuL9wgKLb2JU/bZW3dR1yfhADHYk3CY5wDbAWKA s9N+6om7rd0IyFvCdq9IHdJ72uia/ZCIJzRe/dVTsD5CXbKMcLK5ORp2Vo1QwRFshv6mqCFxk9Oz ULJH6rOOyZ5hGwKChobYfKB4F1b3uEZIF0try5u+yIUTYlWHXbpQabXI5UF2C6oDBFwEy+nssYzN L2tBu5FLISNue6gGl4aexVSOJII4SJIy5oIO6Ng0AAm6oGNZv8I7eW3Va6BrtwrdKQbEbICCS/I3 KWfuCNo1n2AVXu24FwgBB1bcKi1rnb/3Rlu23dUQAUAxjRY27INZ/KZH6d+yXM4HcbIAmkXHZE4a xpPCSy5F+3unRWJO6ArS2Aek3S5JSGl/YblG6PVffZImhdLEWM3vsVKBydDWNqIQ5ly35XIwPOgE d1xmF0zaSkay/wCQVmGfS5rQdlykjSOQcAADe1+yJrnBw9lgtlAnYDws2WRxcNI2C4NHRMzonC1y RdSV4ff2CRGbtBPKexoc31Gyx0aE3B2CNp30nhEIgzhC7UftF7IBMpAda1/ymRhrxvyqLdRRhjWm 3dASZrGtBaQSOVGtLtJKjdDDaygdbugJI652CgJFkTS0nfcIeXbICNGp9nbKEaCSEL49Z+6yu3pt dAW55maASAQgBaPSdipo02N1ThqIsgLkA7c/CSAWp7WnQQe3dK0GW4DrWQDmkWGyqwsR7JbrtICY HBAC4XH4UA1ss7ZTU4GxGxTHsDoyAd0BjuAh+Qqa9p3A2QmKS5a6xarbHvbgIC3uAF7bKF4aNkTi Gt3FwkN9RO4sgHX1cFWDa26WGjkcqar7AboBwddwB3CBzgZbBRlwfUpsDcHdAXKNwqG+91cjrjjd Rv28IANNyj1CJtwf2RHS0C4QPsUBYeX7gflSQahtyhYSwjumWLwbCyAU17r6f8qvLs025VFw1KhK 7VtwqkAgCGbrCnJJNgs3UTGSVhTNLrkcraRGYM19Lmu7rjZL227LNqJjpN9jwsRzA/g88rvE4MxZ PtJ5SorC7nFOl9DC210iNmrcrZge0HSTdWJNcekchSJu9ibBA5zWSkN3Qo0keX8hLMvA3RucAACL IomNFyd0JYrRq3RM5AcbXRO24CpzPMDSdrIUY7Y25VRncnhC86r78K4t9goAnn/8qAO9Vu3uqmdZ 1giLtTQLKgZrGncbe6AOFz/3SXk6S0co42jSL8oCvMOrmyKPk3NwUMoBcAb2RRAD06gQoC2ubc3I AQiRj9XlblEWAbAXBQxsbDfSNigCbdoGrlLcdZtwrD99+UY0k8KgFtmjfeyhl9VhsCpISSLcKy0H kWIQEdudxskGznfCeXC4b/lL8sNcbEICNJ78KnnWfTwqtpJIUDrNtZAIv6tkLhpkungAdrJVQ/Ta 42QjFPDS/wBLlHx6iCNyr8tjQXtN7oZZS1o08rSMlk6x6hY+yXIXNaANkxrNbdRIulFxlkAd6QEA Lnmwb3VWBFzsUYaCbq5GgiwNigF6rHcI72se5WO5roBdx1LLYPMY1wQF6Tp+VYaGM9RQvYQ77th2 Ud6nDZAULk2PCtzhGN/tQVDi14sdlkRvYyMamhxPKATqjc4aTcEIHOGrYKy1rXktFr9lbDc2tugC DLsuBuELnbWO11YcWE2P7JT4nSWN9vZAWbAW5U1Ai3BVabWB2+UD36Tb/KAY8ekbIDEQNV9vZNb6 m7qni4tdAKi3cbonO9Smkje3Cp25uRygJLZxF+FcYOokHZU9wIF+ETB6dhsgHeV5gJ2CQbRuAdyr 1ub3U0CQ3J3CAF40u23usqKBszbOIJStQDr2WPNT1D5C+OTS32QDzUML9BO42TpGlltO90mKOMRg 2BkTA52m5QD4g4t9j8JgddocEuBpcC4qy7SwgKM0jJBDBzuUIv35S4XhzRfYqw8EkFYZS5XXNvZK fI53p02UeC92x4VgOcVUAGML3WHZP8u1tr+6jWWIICafusDyjAIYX7A8KFpHIvZLEgY+wO6ZI4AD flSgA6wI2V63NcNItdGWiwKhbYXVQC80nlLLr3shcbndW1ga290ZUGxotq7qpRqA23VahtuiJOoe yFoARO1D3Rub/cIjcO1Aqh3c47qkophtwbqpDr9IQarEowC4auygYsR9wAETni242UeXAAAcqBvA O6jIgmtaQiLmNCp0mllg0BLbIQ6yIrCe5rh8IDpFt7oTuTdDa3ZaIE5wJsFbSd/ZRkR5JTS0DZRg F5AYPdCT6blDUk2AaL+5QNa9rB7KWBzHWIFrhXPE4kObwEEbCBqvZE8uI23SwKe2+/KNkZIFgiia XO9QtZZDHDcDlLAp8TbBx5CGQgAEKTucBbslXJIAUBHE8tG6KORwNiFRDtx291Qu3k3KCw3Oce1w gcbOve6sEt7XCK3eyCwmOawk3VNniJI1i6BkYe/nlW3DI3lxIJB7ql7DLQ87G49wlgab2TbtiAib 2QWAB23QgprvLuHXVgi/KjvQfULlXo1i9koDIyLEX3VyBmkX3SgCHAAWTXWIt3UBA0W2FkLWHhU0 m6LzCdhygBeLCyOPYJbm6nXRNfuRwgIXEO34TG6XtueQlWLybIS1zOeEA5/F/ZJB1DbZFc6djdA2 Ozrk2QB2BbublB9ou7YIiLHdCdLtigKe4Fo0HZEdwgaWAEBS9hYoCAWNh3UFm3UBF/hFcXF1bADn aRe/KV6nE23TyxsgseUL2Oi3tslguK+nn1KF+k7goor2v7qOc69gNlAS4O5CvzLensUJ1PNrIpWt awW5Q1RRGg2JvfdDyqJLtyNlbGl3HCoIPQ4W3TZbWHuVCLD07lA5pda5UMlGPVY91d7cbKE6eDcq g65F0LZXl3IIHqCc31bnkJXmOF7IRKb78oLGvcHiw5SSxwVEuvtyjaSQL8oUrUSRdEf8KP2NkF73 QB3I3RNjDml3BVRNJbuseWcmXy2chAZMpb5fO6W30tuEDGuLrPTuwACqBQBtqVvLiP8AwUJ2d8KS OOoW4slAXd2vfhNvqG4Q+oNueFI3EsNlojDjkaT7WVuaEBADduVGu4uUFAhxDi1FqubKj6nkiyIM 3udkKUSWi4Va/hG3e45CEjZRkReobBQISBa/BVMvf3VKXblECGt53KJzm7JZcC/4UsBF1m2Sy0tu 6yNzT2TGNIj91QKBu25RNN1UjmlpPcDhVG8ujabWuoAnMDiCTxwp3U4KvTqJsVQDYW4VNFzt/ZC+ 7TZWy4/KAYbAglA1tvUrvflQbj0qIFuItwl6iNk5otESRusdr9ZIIQBtILkx7Lcn+yAOAG3KJ17X uqCNAa3dBqaLqxdwNyluZfZAMZbcjf5QOB1Xuia3Q2wQ6TfYqMF62343RN3O6rR6lZ45sVkEcRvZ Uz2QgWG6Y0AersgBcC7g2KEE6dzui1BziQULxYA8oCw3U0ohtsliQN+Log64PuEBbn8C2yFzyO1k IcX7JlgGH3QUVq2Vhwvuo1hsCUuVwDwePhAN0hx1JcsbXEam6kYkadrpcz9I3OyAJ0BDbt/ZRrTo 3sVQJLQmNQyyzGBGNvykO0cW391kg6tiNgkamh9rXQtBtbpAS3OseUw3aLnhA8C17IUoaXcko282 4CW0t034si1tA1E7ILJJBqBB3CfGAyn0m3wsYVBkedBu0Jnm9vdBYnTe4tZWWtaATyjfpcebEdlR GoEbIShMjb9+U2OXy6Yx3+UAb2KrRvtwhaDi9bb8fCJzSAb8IALEW7dkYJkuCUJ0FGPQhDtVweEG vRcDdTjZCEY4gkA2ARMaC433VCP1Ao2N0OuUBeovFjsB2Uc1rGAN/soZGtKWJG6r8kqgM7EOHKjt 9/6kuW7De+yF8weRoPpUAbmlzfUeFCCXDbYDlKdJawPKp1T5YcAblVgfYgmw2V3sNxdY0VSXNGrZ yks7htp57qAyIrAE2uUT4nF1xslRuc0Ae6aZtDSCd0BGt13a48LBqGaL2O3Ky3vBsRz3SjE6U37I DjnanOGltys2AE8hQxPa6zbWWWbRxAcuWgLALbWPKkjGv/8Ate6t2kWLilQvbFJqduCe6gLh3fpI /dSo0R90NS+SSceULN7oJA0WB3J5KqBIm977FZL4tUbdB4WPFGXuDQDb3WVKPLAY12/wgMd1JI9w GrdR0rKazXeoq5ZDqFzx3QudEXA2LiVQIdMZJOPSsiIBoO26U0C7iBYJkb2gjUUARLb+lLdpB22Q vbZxLeEwMEmkj90Atm/Ld0uemE9mX73TnhzX7bqOjLCHm5QFFmtwb2aFZpiBdnblQytaCeLo4pSW lANfCG09ydysVrw3nkrLsNg7cJM8LSbt4WAYwcC+5KcwBxNikTxubbQ25Ujp5IW3JNygHOBB52QS SBrd91AS690mU3HFkAxjjYWHKcw2bxb8pMRc1o2RPHygAc4lxtyl6XXPdXYgmxRB1m35QGO67HE2 3TI36mknlC9+p3CjW+2yoLbKb2KG5vfmyBxLXKRuLn2KIBnURwqtpO4R6Sze9wi0iTcjdaAGnbYK mxXJJ7Jhftb2UBt/8oCi5Qm5shkkaBb/AClBxbuTdASp1NtYfkplLZvPKIWlHFwhNoQX2sgMnzGH j7ggLm3OuPX7LGildKSQLBEyWTfe6AsPa8mzS0exQjSSo1pLtR7q/Ls4+3ugDDttkbTYXSgd+UTi bWCAXI4hxPZCDqsQmEAjdRoDQARzwUAAuNyUQdbhR7fZCgCkJFjbdZNPcsu9KhOo7o3FxICgAe7s UBCJzXX3uqvZZATiWR7JTW+YLlMtq2uiaLCwVoCg22/KZGLgk7FRrg1xBCCWQAgtUA0EE+6twBN0 HAue6JoNr9kBCDfZQE33KIt21A2SZAb+k/lAE/Y3urb91ieVQ3AuVbmG9+UAsjyifYogRsSrc3WA CNwltOu7R27oA3XuC1UYh9x5RA2G11HDW3ixQFNue6ljfbdTdjbKrG10BfcXRlt/hDEA7lGGixN7 hAAQQOdlLtaLk39lZLSRtsluAB49KCi9RO4SvK2J7lPvdvpCG9kALIiGgf3TXiwBKqwI2uCkVjjG 1oB5KoH9kNyN7JbHdk1rrWKgBIPPuiftFtz8IbODiexV207qgXAx7zY7I6pvljSVRe4v9I/ZMsJh 6j6goAWECMXR2YfZKDtZLCPwr+3b2QH3Ymde9r/KqSQg7oS0jcKFrr2cvMelO2YVZYytNtysil1R kW4WDWFzahvsuQin8tjbN1ErJTkBOSyxGwVF17EbfCgDxsRp7oXtJQC5TqdsoWaRv3TH28s22Nt0 vUf04JN7lAAeEp4JCcQlu3CBiALOPykGkhiqA6N+lzj93yslwAWHVxHzGFpvpN7e66RdOzDR2z0W 8QmN9EcwRVMDnSQXBcwnZwWyHJPjt6V9T8muoc11wopJIw2WmmF2u9ytQ1Ti8VZdjoS949IsL2WP Lhz5QHlkjNuADwvo48lejx5sUZ/8m0vpn156SZN6wVFPhFVT/wAKsXMm2Dbrj/GF4yssVEGGvytj b5cWp5g+SKFxDS322WsVmGyOYCyKaIN/93cKo6F8j7BxnPvquVv5G13RyemUo1ZuQ6ceP7p9jPTu B+NYjT09S2ARTwTOvc232XMdPPHF0Qy9QvpqbFo6LzHl5DW7ErS1PgMr9zSyMJ9uFlU2TKqqA8qJ 5HtZbWVTVUeZ6Vxdpm7Ko8anQqnxOXG24rTTYkG6TKGDXp/K+Yxb6k/SSae0FfKC27S8tWnR2Va+ mms+GVjR7g7rPiwTSA/9O2UW3CeRKXBuOkTjyz274wfGzlrqI/AGZan1uoZhIZyN3W7Lt7JH1Pcg UuQaeixdkzMShiDCxjfS8gLWJ/Bo652hlE97idmtasXEcvS4fJoloZGXH9bD/wB1d8peivTRSqz1 T068a2CZL615gzPV4N+twyvcTFYf8vddq9cvqc4NmTJ8+F5MoaimxGdmh0ruBcdl4IwrKWJYlTv/ AEeGT1kX/Q29livoY8MqhFUUUlHIDYiRpBv+6Szy/CrSwqh7auuxbF566ve6WtqSXuc43NybrIma +ocHRtBkjPDu6t8zaacTusGadjdJhke6djmXs9y8Dk27ke7HjjjjtifadOOqGI5BzLSYtIHGCBw8 ynA2eAvdmWvqy5ZwLLTKFuX6j9WwAezVr+oMo4hm/Ef0lKwkD/b7r6s+HDNNNTh/8KqJmO4cIrg/ uu8FuomSMKqTPv8AxV+NCLxKTUlEzBvLZTtvHUOG7PwujsmZxx7I+IwYvguIy0lbTuDmlr7ce65L FejOZ8GjfMMGqGhoubRlfN4blmuxWrFL5boqi9tLgWrvLFPs8+LwwW1M9pZN+rZm7LeGQ0mOYBHi srG6PObsXW7lfKdZ/qa5w6m4PLhmEUH8Gppmlsmi+o3+V03SeGzOlfSNmocDlrm2veMXsvkc2ZBz LkuZrcZy/VUMd7ebJGQ3+64xUr6OU8eKTtHanh88XePdBaioq4qMYm2oeJJg83JPdd9Y39XPHcRp pGQ5fjp3FhDGA737XK8rdOPD/i/U1xfhJfO8/wDtRlc7nDwhdQcn0z6p+A1VRCBchsZJAXXGpLlK 2ScIOKifDdROomOdZc6y5txqKNlU/wDoj2AC+elg/WVTb3b7H2Sq0V2A4r+graWejl5MczC1ZUVR FOC4mwb3Xmytylcj14YKEaj0ZNLiFRhlY10MmiZvD2Hddt5P8avVbp3RtocHxeSaFv2smdqt+F07 5wjd5os4f5VSVYefMDQ1w4BCyn+HWUVNVI76xD6hnWqpDnzYsY3PFrtZwvl4fGf1clxQVn8eeXDe 7l1Ya0ws8yRgdfbSFgxSur8XjhLRDTu5Nl2jkcXZ5fi410eicS8f/WPFaRtK/GhAxrbaohYn5uvm arxc9W8UoZ6KrzTUyUsws9mrYhffdMPBRjfUvBm12DMMzZG3a4+6+P6u+EnqR0ippq3FcAlfh8e5 njGwHuV3WWb/AImfFii/sfK4F186jZJpJm4TmCqhEpLtTZDsSmQ+LHrNHJdua6yU9y55Suj/AE/Z 1Fx+DCaiUwMneGtPe69VYz9LrMTsINdgeL+Y4N1hkjb3+Ejmkpf2ZnhxVyeM+oPVnOvVmvo35srZ Ks0+0d/Zcc6NtKxp06ha65jqDknMfSfN0uBZjpzE9pIZIRs4fC4Spc6GItePSeHLhmc933PThUEv 9aMGoq5ab+aH6G3208hfQ4H1rz1gdOKPC8zVtPSgW8tspFguEZRxGFxleDq3aF2h4fuk9F1GzTTY dNII2zPDS72WMeSSZ1nTXJ8FP1DzfiFWZXZixHznG5P6hwBKTVYzjVfUtrKzF531Uf2SvlJcFsHz f9K2tq8KdWYDicDJ9GpjJD9xXgzqr0zzF0mzdLgWO02iZji244NvZe65yjaPHWFy5Rx0+es7WbbM leYxxomNv7XWHVYli2MNYcSxSprj/tneT/3VQxSU5Y9hAYOWkLGkbLU1bnNfpvwL8LluyUdViwp2 kEaephZ5sFVUUkjeDC8tsVj1NfjmIw6a7GKyrgH/ALc8riP7FZLI5IGvL6gOd/tIS3V0ckJbI1zf kC686Uouzo8WOXaMdscBiaY3PjlH9TDYp8OMY6IjC3MFdFT9mmZ1h/lDSwsqZo4mMcA541PtbZbK +gfgWyP1c6bUlYypEMk0YD5eXarb2XVS28icYpV6NZskUgkdJVVMta539TnFyCSlY1oDK2eJp/oJ Nl6G8ZfhRl8NONxR0GLCtpp3Atjd9wC6JdG6SjjEse7m3uAtSU5cnKMcTOIbgszryMqiR3BdynDD GVzWxSOaGDvwnPLKH+ouaf6SLLIpYHVTAaaJzgVlqS7NqGJco4yXLTWusyaQRf8AS+//AHTosKjj +xxmkH+83XI1VDVtjIc0taP+lceZJYnFsYDZB3cbLEt3sqWOzNqCG0nlOdueQgw+QukEPMYCgkH6 EmZoEncp2EUT6ySNkQ+47OXI9DarkYwGW8LwZSDs0bq5sAuwSSUEzWDvoNl668InhOl6qZhjqaqO 1DEQ6WRwuLLZDT+F/pph2GxUFThlK12nTeUD1H912x8dnz82ZdJGiKN0cZDYQYw3YghZpwmas9ba YzN72bdbAPFd9Pp2XsaizLkSlbV4VUvDaqltvDf+ofC7t8NPgewPK+Bw4nmeGOrlmYHiBwFmg77r 1Sgtqk3aOK1K/jRqRcYaBlnUb4iOQW2R0QZiBeaen1C32lt1uw6qeC7pv1PyxV4dDhtNh9W9hEVX StGpjrbcLxv0W8BeO4Z1lfguN0LxgVG8k1zh6ZgOLflbjCE4t30cFqVGVUeFZ8nVLWGoFI6Mc+lh WBHUSxSGCSIm3HpW+2q6TdLssUUGEVuA4aS9ojBkiaXv/wDK8oeK/wCn5hM81HmrItOaOPzWirw6 MXDgf6m2SGx1HoktS4NurNbFDljEsYIbTYU+qv8A/TbdYGYMo4nlRzZq3BpqJl/ukjIH91u48Ofh iyx0jyTBUYph8FXiD4hLLJUMDvLFr23X0OcOj/S/r3lWuw8UVHVwyB0Qmp2i8T/ghYdbqfX6dPk2 uTQWK9hlLhEH6/8ACszxhwa3Sw+1l3X4pPC7ifQfqDPhzgThjnaqae33MPC7c6M/TdxfrN08p8x0 uJx0cs4tGJO/yuGbA4O/TPXjzxlG0eQCDUaC54Ok7BpX2uBdOMwZuiYcNw2ormW/9uIu/wCy7Lo/ CVjuSutlHkLGyKiufOAHs3aWE7FbgemPR/K3QrIsbaeigbJBAJKipewEuIG6tKHH6Sed1aNE2Ysg 47lF+nEsHqKQHtLGW/8AdfOT00te4BsmgsN/LW/LEMrZC8R2T6qGpw6jq4Zg6MSNaPMjPuCtZfUj wV4hkXrX/p6gY+qo6t16WXSTcE8L1RxxnFpdr0eSGtcX9uv06GyF0Xzb1Lboy9g7657BuQ02XA9S ulueel1hmXAJcOp3GzXuFgVvO8PHQ3COi2RKGhhp43Ym+NrqiXSNRcRuF50+qpg1NN0tweXyWh7q rQ5zW7gWXmxpSlsOs9Q4reag4at7aIiIAEnnuE90zjG1rpXElehfCJ4Z6Tr1m2ajrJHwU8Lzs3uv QviS+mVhHTvI9ZmzDMekIoi17qZ7NnfupLHU9rZ7Vn+tniPI2SsTzfiUFDQUr66rmIbHGxt9+y7o xnwP9XaTDP1M+VZ3Q6dQZGLuI/AXub6d/hzwTLeUmZvqoI6zEJ/+U54BEdvb5XpDMXXPBMDz1RZb lm0TznSXPZ6Wn2XTG3GTUVdHhz5rXZoWxnLeKZarZcKxLD5sOqI3aXR1DS1wP7ru7pF4JuoHVvCP 4hhdI+ChI1MmkbYOHwtofiJ8I2Weuc1FijIYKXE43hxna2wkF77+67ArK2g6D9JIJmUzW02GQhro 4m/dYf8AldMrxzitnbOKzZHcZcJezTH1r8H3Ufo3h7cTrKB9dh/D5oWkhn5XQFLM1s0hl/lyjYtK /Qn05z5gviHyDNVS4a39BOXQyU1Q29/2Wob6hPh/wnob1avgLXMoK9nn+W7hhJNwPhFDenCqkiY9 S4yVu4s8w1jAyeLyyCJT6tI4WRBRQsnZCwOmc/s5Kp7GVpbbcX/C+86ax4O/N+GT41I1kHmhrh2t deRqrs+x64Oz/Dz4Jc3dd5HT0kX6XDmH1TSCzf7rlPFD4Bs3dB8CGOOdHXYQ3aSVjgdBW3Tw+1uS WdP6GgyhW0c0ccTXSxwPGsOI5I5XW31C6Oaq8NWNMi1Ps5pd32UxLfNJrs+dlySx3KzRVBKKuSGM /czkrkXENfblYBAp8VkjjHqvus1w/m77q5oeObie7FPyQUgnNOq/AQl5bxumudqYQkhoa0nlednV kubbqgSSNtlRuBsEyHZpJN1CBNYS64PpHuqe5upXDJpdd27O4Vl0ReS0bHgFCsXBIGutbcrLvqHG 6xJHeR6y257I4Klz32O10IOBsLAKw7UPZE4bD4SXEXCAdse+6W8b/KEkAXuiYdfKAsccKrH/APEi Z6pNI4WUYA+xFgR3KFRhjn2Vhx1eyfJAGWJNrJdRE5+h0e9+VopT2uLhfhW2TWSCN1kSt0Qb+yRA 2wJKgGMkdfSRsjLQ74QWHARWDiLmyoDMdm3vwktaQw3N7o7gAi9wFA5pAFkAtsQDr24Q2Ln8bLIH e3KDQ66AJrdgFJANyhaTZE+xAQCm3LrhPY0OG4SQdxblHrIBugAfopopnudyNljtlPlQta6xdumm nEjtcx0s7XWM6n0T+g3H9KAzXtfEAQb35VeW6wKqMuH3ngIRI6/wjA5ptyf2QSHUTYbKxfm6hsTt sgI138ot4QsOgW7qOIvblCNyCgMpl3MtblNpWiKUXFxZYpmc1t+SmRTFwuRcoDkGsa57nnZoF0EJ /VsLhs0FKmqbwaQ3S4osPf5cBDjsubNIzYWMJB/qHdZPmXG3IWPEAWbbXTGNLSbBcmbRmwEuANrL MMY8sbrj43loHcfK5WnfTSxkSGz+y4tGzFfdxuDwo1rhuDsVkz0wa27De6B5DIwO6gEuYeyEOt+U YkFxfhHZhafdAIDPNvZAQL2vuFlACMGyVLFFDG2TfUUBGBvF1ewN1QAJBCuQFxtbZACbb77FS2gW BuFVhwd/hWRY3PHsgI4amqrn8IwPSrAB2tZALc60ZugiII9KOP8A5wa4AsPJKoWZK4NHpQFuaeVQ abIuxJ/sl+Zfa9kAzVe2yFws4m6ttgPlC4m97XQFeZY7i6jngm4CPWzQbt3SmkObe2yAott+6Foa x1iU1pa8AqGBr90AsAatkTQL34sqDA07KOIAva6Ash2q99lbm3OyF7nPaNPCskgABAR1zwo0kHcb Imu2UN3HhARwLjygDSTuisRe6IdlUBbCQ4gBE55umAjUqfxwgEPLTfbdC1lhdVcgkkKwCSLbBaBC LNssOYaLWO6zX7DlcZU7SblaRlmJWR25F7rDfpZYN57rNfIZSbi4CwXNs4k2XaJ52Ys7zr2S2G7r ItWqU27e6JsYO43K2QOyoN0jZGhcgRW73g8gKGUMfsELnlo2Vwj1b8IBj3iwPCEusLlBK277go2x mUObwAhSFxkALExrXN3tulRu/TAgeqyyGSF7STsoBYb6ruCJ3J09lReSbqNs4bCyoBt3IRtsG3IQ NOo6UZBaLd0AmSZo2IO6BrRquDZOeRtcfuga5hda1kAY/N1ZuoIwD6Sr1bIBbhYXV2Gm6I2IQhth ygKbureLNuBurDbd1b3gttbdAL0lzd+UQaLXQAG+26PdvKAVy83/ALKni9gm6dLi8b/CXJNccWKA t+zbrGn9cRLh+E2SRzo7cWWOXEtsd0MCI26W290wsOk3RE3aNt1N7LQMUB2ob7K5GOkeQDsFkab3 BCDQQduPdACwXIamzNAFu9kTI2xnVyVUxDhY7KWDHaQRpfuE2AHdp+1Yxs19rprSRuOCqBpAvYcK X9xZUbX2VTbsQFPaHc791ZOho3FkuFtu6MC5OrcICXLuVYBG6p0h4aNlZdwgJovu42VMZY7HZV9z rcqSa2NJtv2QBuYZBtyEsRu02I3RRVDo4i8i59kttW6QfYQT7oAmuINyLhW43F7WCU4uafVtdE4H YIAj9oQkG+/AUs4jZUNRBFkBYDSjI2sNkJ0sZc7FC1ztjyEARBudtlGG52CZckJNRM+C1oy4H2QB hvqBBTO977LEa7y23N7c2WTG/WwEDYpYCjj/AJl0wga/goWNJB3VsG+k/wB0A5l9QA4TntY210tg Gm39XuiER5duss0UNLimaAR8q4yCbAbhNA03JClFMfSDcd0bBpFuCiOku4S3g+YLm4U6AwkN25S9 dyQOQrkc0PACq+/pHPdAKcAHhx7KSP1uuOOwR39W4upoImG3pUAxrXFoJ7o3EabDlBZ9j6tvZVEb Ek7oC2sFiSUMgsRvsidIDtbdLe+9kAZaL3B/ZEX6xYdkoE82TG+rk6UKmRxLRfsq1+kjuUb3WFub JRBBBPBQtkNtJ23Rw3c0tuh0fuCqcCzdp3QjGObpbbv8pVyCqa5zgS5WQRuEIWCSbk/sqLhqv7qw L2VPa7ULLSBYAaDdCQXDbZGG3duhcb3ASwXcxj3RNqGsADmndAHlttr2VOcT23UYCc4OeABsjc3S 3fhDG3e7kTiXbW2UAJOpgtwFADpBG6ppsbJjCGE7ICNbd10Zc1jthZDJJpGpYctQdXwgMmf/AClh oHHKGGR1R6rWtwrLSbkH1IBjQ4bchKkIadt7K4nkMseVTmgi5FkBcUmocJml34S27cLJY27QXHhA KY3Sd0177Ms0290VmgG9isGSQmqa1psFoBuOl1xu5FfUC6yMsDHguNx8JMj3eZ6R6EBV/M3cOE1p JF+yFgJKp2oG39JRgJ93O2OygeG32Qm7Y78oNy3i6yC76TbhEHbgqy0G3uhc3SqAi7UbMG6Zo0tu eUljLjmxTHHS217qAoP5sEhz3F259KdbY2PCBo1gj+pAGOBpCKojeGi3KGAFuxTnAC5J5CAACzAS bk9kBj9d+R8oaYiRznB2oMO6bINX2lAIdGAb2U07XRtu5+khMDRYghAY4tfhHYW+FbCGXuL3Qnm4 Fh8oAowC643RyO1A2CU17tewsE1osDfugFXNrDZWG3BVyMAHO6pr/Vb2QqJawHZUIy8ncBFJ/M42 WK7UJLA3I9kKzMjjIvq3HwlSM9fp2CKIhvc/uhfZ7jbkIZI3c7FXqbezgqiZYX7qzGHEkq0CrBv5 ULNQvwr0juoLm+6tBCyw8oQDq2TgTYgnhCCHj0ncJRoI278qOeCCAEO455VgWKMFsbvvwge3TJtw Ue7rprAwt3O6yRioyWg3sk00dqh7jynabOPwrj0i5QgM5Mtm2tZUwaRbsic8OVCxHKtFsjiLcbq2 PsLKnflCN1WLL55vZXpFiASEQNgpe6hCmtAbuUB9RREXuoDsNlQA1tibIhdx3RG2x91L77cKGig3 SDuhbsrkfZqAE7KgJ7b2sVbG6dj3Q+YWkbItfcbn2VAUjQ0brGAcXG/AWTvIzflLaw7rNAm4be+6 c0nyed0rSdNkxosyytgWGh11cbgeOys2A5S2ODSdrBZAZdcqgNR53VBvq5REgcDf3QBBwsWkbpbj 6rKdlbTZpVsEVt24KHVZvwr1h7fSEQRUz3taDazb2JSpXEG0R1A73WQT5kZa7ugjjETQ0EWCtgqn vvrFimvA90u5JVuaTZLATQCDuoW8If6SOPwoSSLA8KWC3OB2VMA33Q3NlYhcG7d0bFh239ktwJKK zm22ura0udY7KAWwuub7hXI4Pbp/wrc31H2WO13rO6AfHH5YJG6bG8SiwGwWOxxuQCP3Rtl8o7gA KgY9rbdrpbgANlAdTi5WWl422UBTRc34Ka0BgJvcpTWkH1f3TGtDjdAA6Q3IHAWOJ2TuMdrOCyvS ZbWsSFjztax5LR6kMlhjI/udb4KJ7Y3AW3S3UQnIc537KOYICDyEND2kW4uAia7UbWslRF5kuB6E 58jWbrVGQHy6HaQCb7XQiPS+5RHkutv2SqbWQ7Xub7LJoyBc3uNkqZ1m7bhXrOhxvtZYIe5tze4u tEsyS5pZp4JQSRAs07hAP5jWkbG6yCNYAWSHHazACGvsCs+CQyMGocd0h9E29gdgnxk69IG34QDC xoB23VarNOyN4MbL8uWPHI9wOobIWyX9Oq/KsDSAT3V/cLWso+RrG2O5QgZDQEokB1+FbZG6g08l SSMauULRHtEjQAfUoGbb8hDE3y3Ode4QNcS8uuhDIDrEFR0h1HvdUz1HfdR0jWP3GyoFvb5ZuTcL EkdI6UOaLMCdLWse4gjYdk6GRr2WG4UATJA9huLgjcJT42sHpFgU0gNcLf2QvfpNrbIBDS5rvt1B GYGyOLuCeyNuztxsmOLSbhu4Q0I0a+1gEYY0uAveyvzL39NlTT7i3/lDLKaHNeD2UkcHHixRODgS bbFUwXBJ7IWwf8JsUh0EISxsg9WyjYgDpDkIH5fouSh1X25IVyEFvO4SgLG91UVFt/6t0D4hILON rcIm3BNjdVruDcXKpC/1Fo9DW3PukxAh13jcJ4II2ABUc1ttjdUBsqWNDrDlJbJqeSN0DG+W8l3C EOMTiQLgqAa7SWlyEOAj+3bsmeVZge7/AJZV1ksUbYBGLl5shaMd0lm+x9lbi2SMWG6qopJGYkST dlkxrfXsLAKkE2laQdJsE6N+kXtb4TtZmBt2WO86b2QDBqcdV7BR8jnG2xSS5zorX0hRjdFt0BUj HWsW/wBkTCQ3SBYfKIyWcL8KOd3UsFPkcWFo+5MgJjiAl5PF0uK0gLuCikf58Olxs4cKMDnC4sw7 nusHyqxj3B7w5ie2N0bAAbqNkdchxuEAt8fovdLDdQAO1kc727aDc+ymzo7E2KgI19jbsETvUCgj IuL8JpAbt2KAxiRuEQGltgicAxx2/ZY73OBuAtIEcDq4UDdTSUeokITcDZUAaNR3CJkYDrt5V30j blL1lr+LBAP1ajpsrcLdilghjr83RecDfZAASAhvqaW2unlweBtuqjIYdVkAjy229YN0sNu6yyZC XOvyl3590AcUZsQP7IJGh40uPCNsQsH3N/a6B9mA35KAEW0Wb25srbszdLjc8AlpufZEJXOHrFne yANtw3flTvyrPrG3Ko7fHygBJ0u2RC8hFtlHNA9V9lUfrJPACALZxt7KpHAAW3QzA3BGysM1W33Q AGQ6eELXWfYplgHaSgdFs4lAPilad7WsrklGr5WNG7WLDb3RNfZxv+AgMh8lmg3SrF24N0iNrpi4 u2AT4WloPsokBrQGtuVT3EW07hUWFxtewVh4jba23ugFykkfJUhsAb8q9evkcKtQ1fuqCw+/3DZE Jt9NtuxVSxkWarDQ1lj9yywWXG1r/wBkLGl11RBIP4VwCxN1AFYg2IRFz3fYru0jYqg8NNhvdAAd TTfk90unuHOHF097LNv2QNAd9oufhAFYxnfdR03/AE7I2m49XKhF9rWCoEeZqcQeETLHuo882Cqx 07BQFt9Lj7FHqABsEAabblUTovc7KoFtc03B2QuiNr32QR/zidJTNb27WurQLa4sFlCLjUhKmsgW 7KNAsSA8coXjWQHMurDbG6tzzq9ggFsjOs32TQ0M5VhwAt3QkXCUCzuR7Ky25tyqt2Cvk7bKAFrC DcIGPcZrdk2zkv1MeD27oCSXYfSq8xvflFKLuFu6Axb9igPvHO9ZHZE4gDfdAWhr732VndpJOy85 6Tj6zd9xv8LkMLcIm63x6yOB7LCl9JJtusijc+QGxsR2UaKcq+WSch726b8BJLiHIm1MjwGvsbbI NBL9ROyyCnjVzdDNcQgAJ4Goe4S5pGtHP7IDFLjYDjZASbpm9r2QkWQgh7gTYrAlkNVVingJ12We 9l2uJ7LBpHChxNkjd3P2WkQ9AeHroW3MVBPXYhTmSM3N7b7L1z048EeDdRsKbPM11BBfSwkDdcX4 P2002TqMztafMsDce5Xt7OrpMpdF8XrMJDYaqOkdJEQOCByvraWuqPj6zLtPI1N4GMiR5vky1UYq aidjbvihILmj8LC60fT0yr05yyzMGAGpmljN3xOFwR+F5y6K9dcxUXWKLH56qWrq2VLhVSueT5jN XC3BZPzRhHU3KVPOyOOpp54wHxvAIBtwvZkltlyujwYsjkuGeP8Aot4Qsm57yRDW4hQg1Dtt22su xMpeDXpk2vkowyOaeE+qJu5C7S6sY3Q9Fel+N4hQxspnNjd5LQLAOPC8++CbOWI5jzliNViFTJUS 1sZe/WbgG+1lXTi5Q4Rjy5G6Z2pjHhZ6N0MraWvoKeKZ3Ac4AlY48DnS0TCelwuLQ7cdwV9D176F HqRNDiVLikmG1NKNREb9OshdQdJes2YMEzMMtYnOaiOnm8pr5DckcDdcoRlNXFieWSdUY3Vf6feC Gndi+VnimqqYa/07W/8AMA7bL6Hpv4ZcldQMmxw4rhYhr426Jw5oDgRt3C9T1WOYfhVHDJXVMVM2 UCzpDYEoKDD6KJ8tVSBpE4uXN4ckc8oxaa5/Tu3JNUzVtl+gy50T8SdVlaQMGX5JzCZJQNMZJXrP qh4IumvWTLMr6SJkNY+PVFWU4AuSNl4c8Z1C/DPEhilIbgzTCQEfPcL3b4JcfxCuye2gq6h9Qymj AYZHXIHstZri0y4sjnF0zUD196K470Cz1V5dxhrn0zXE08zv629l8myobTUMTrXPZbEPq4Zap4os FxksAkN4jJbda56Q+ZQ+r1MA2K8Wpgo1Jez6OjyvImn6O2egWOtwrqRhsVU7/g6i2su7Fbmuh4wH NOToi2kpppIToILAT+Vo36fT3x/DpDdpEgsVuA8E9c1+E1cTnlzywOsT3WIdcDURaO4MbhyW7Mce Xq/CKSSeoZezom2Pwui+tHgjy3jmI02MZXpYMIqTKDKxvpa4X7BdrdY4clYFmDCMbzNjowSpbIBE /Xp8y3ZYI67ZdzrmzD8BwWp/XscbedG7a6+jj3KpR6Pgyk02jkKWkyd4fcgU9Xjs0FJTsY1r5pAD qdbgLiqiv6VeJfJVXQF9BXQvaWFrWt82Mng+668+pLl6XFeguuC5dSzBxaDyLLU5kzqNnzpzUzVu XqmWjjm9LyXmxARRUoeR9mk8ksvjie5ei1HhHQjxKyZXo52y4cZbRkb2C2UVsdHNhslRJDHNF5Rk s5gNxa60l+GrNFdmDqpT4njNR+oq3PB81ztXqJ3W6nBZxWZUprEEGnDTf8LyNvcj3yi4QbkaR/HX nOlzh1yxCmw+ggoIKX0fymgXIXQlNFHFRuhI1P51LsHxVtlb4hc0taCxzKxzLH2uvho2wQU73ag+ V2x+FrWNOdI66Bt4tzYWFUUdTKyHUdbzp37L1v0p8B1R1Ly1BX0OJ+dVSi5j7NXn7pBkd+c894dQ RC4Lg95/C28eHnpzi+Vspy09G1sD5CC2ocLBgAXji6aPZkntRr66i/Tr6m5Nw+fEKKmZiNJEC57W G7gPey6CwLp/XYnisuH1NM6krIXaXNe2xuv0D0D45qFkEk8dXI1uiQg3ue915OzT4ecu4x4lYWQU 0cVPJGKmoja0C5vdfRxxhmTjJcnzZajJBp+jF8FeAZzy1g+F0HlaMGaB5sruTf4XdXi6i8/oFmyz BIRSusCLrm885zoukmE4XR0FJG0TythY0CwA4XHeItpxXolizWDUZoA4gD33K44se2cWurJly7ov k1TeG/pbmKtzHhdVg1K+SujlErBY25vutxmRv4vHlqkbjbGR1ojAkYwbXsuoPC1kTCcndMI8eZSt /WPjLtZG9h2C+56XdWR1KxDEqVtN5P6OQtLr82K9GdKUntXRwjN7Vb76NZf1Xneb1awOmaxkTmRa 7tFib+68W12IAQxxPNyV7Z+rBRGHq/h1W4fyxStYHf5svELKQ1j9m3AAsVnUq4xkenQTlzE5zLWV qrMuJxwUzXSG1/TuAF7T8LfhezJiGJwVdAx0DBIHvqHNsBZdL+FCKnfnCKGZrXaxo9QvZbl8kYVT 5N6ewS0VK3WIfNLWDd21182K3dnty5GlR9JljDarC8BpqWql86aFgYXjvYLXH4k+gtX1w8Tb8Noo zaOxlcRsB7r3Z0l6oydRv4m51MacUcpjIPcr4PKUlPT+JbMjZIbTTU4MbiPbsF9bTPxOe5ej42eT nscH7Oh4/pdYJHRRxz42xsjhdxLbXPsvjs2/TB/hc8E2Eziri1DXvw33XtDrj1pyd0pdQjNZnEc+ 7HQgnT+bL4qg8cHS+sow2hrKmY30MYISbn5KkXkklJRtHaeba3FPk89Z3+mdgc/TqorqGYU+MUsJ lHPrsLkL4LwheFTLHVZmMUeL04M9A8xyOLe4NlsuZWU2bMmvqKRw8mtpi5pHa7V5K8I0lblrrPmv Bf0cjKaV7y6Uts3UCd0SeSEm+GjhLNKMoq+zzP4r/BVg/QWvoMVw6tM1FiDzGKcNtpN+y90+EvIl FhHSLLs+H1etn/MdpN9+4K+D+pBQtf0yw7EtVjRVNwL+65L6emI1c3SaWOZ5fC6XzIw47C/so4Lw KXs9CySk2m+DzN4/OmmL5n6/0cNZMXUFe1gp29mkld89Kfp5ZGpcqUdTjrHVVZLGHP8A9oFlx/jm a8dU8izlpEUcgvJbb7vdevI3mfIbXwOsRQamuH/2Nl2yusWNrizzYsj3TSPPNV4FOi2P00+HwUUD qkCznRPGtp/ZdP5W+mnRYN1AkbV1Bdl8uJj7m1+F5jiz11Zw/qbjcuVMTrpaoVz2shc11jZ3FvZb BfCF1H6mZ1nqqbP1A+lkgjB1ltg4/utZ8UsK3XZnBneXhn0H/wBxn0iwihayrwKGQbN8yTkldU9b Ppt9Pc35cq6rL0UmGYgyMviEZu1xsu5PEv4hqToLhVFW4jgM2K0lRJp1Ri+grprHPHLjuOZaknyx kfEAwx3bUysOjjgLjihmmlJdGsmSMZbW+TUlnnK9d09zPiWXcUjInppDGL7FwB2KzsEnFOKcsZax 2WT1rzViWfuquI4vjEDqSqlef5bhYgrGw1zWwRC3qjIJ/uvFlioTo+5ppPJj5NyH0+YKZ/St88DG tkc5ofblcz17yZmTqD1QwWhwbEZcPgoWCeUxuIDhzY+663+mfm6lxjJ2L0EczfOhLXGIne3vZdr+ JSTM2AYhg2L5ZifNUuk8uURne3z8L0aV3lPna2KjCmd0YZTNmy/DDWgPayMMkDm7OsOVh5koHYtl Gsp8MmEBdEWMkb/TslYRjkrMi01bizBFKYQ6cE2ANt0MjoMzZHq4cArI/wDiYXNimY64a4j3C5Pc nf8AZz+jil/R1X4b8i5gynW4ozFsVkxSlfIXRulcSRuu9A6R1e5vpEQ47FdB9CsPz3hGMy0WKfzK GlkcyWaQ/dv2Xdc+ZcJbjseHnFqWGvcNqV0rQ9/7Xuu+pX+zjng46ZxjCn+nR/VLpvX5r6v0uIzV 5p8Ppo2mKPVbU4LvahDqfBGOqAJDHGARzey6g8R2Sc5ZkrMGqMpS+UIZB+oJPIuuzXYrBl3JdLPj FXFSeXC0TSzODW6gN+Um1PHBIQhsyScuhOeqGLMWRK5rqh9HE+F13A22twuuvDZ0rk6e4dXVDK41 FLWPL2Ra7hq7BlqMK6nZHqYMOrBJR1EZj86A8G3IXXXQXJ2bcrS10GM15kooZSyGF17uZf7lYOSx Sg3RjIoeWM10eXfq10kdPhWT5raZZpXMLm8kDt/lfFeG/wCpLgvSbIlFlXF8vTyw0IIZVQg2I+V9 L9UvPOC11dhWDfqmS19JGZRE030f/jX13gL8PfT/AD/0WgxTHcHgxOomdpPm2NvhXJxhjuPRhdza XR1Zkrr1Sda/FhhGbYmMio3TMZC29yNwLFbJupbYanI+JxTSiGOoiMYef6b91ri8TPTbKPhl634B X5cbFh2DTzslnp2uuYnX3sth+GYvg/V7p0yTD6mKuoq6l062OvYlv/cLzt3KL9Hok6iz53oJ07wr p3gr6ehxAVstT/MedQJBPwvp8Xy9l6fNtHX10sP8UpxeEPsCAvgeh3RXFOmGIVlXiuLSYgHOIjDn XaxnbleNfH/4mJsMz0zDMnYuKfEachks8T7j8L2Qg8uV7ZcV2eBNRxpNW7NlDYIqqsbO2qa8N4Y0 ro7xwZAo8+dB8agqXthngb51PI7s8dl0f9PHM2fc81+KVmYqqaooIYx5crzdrifZd/8AjAyvjecu kdVh2B//AH0PW9u41NA3C4xx7M8YXZ3nzjluVGn/AKM9cM3dB83OqctwNq5Yn6JGc6zfdeiep3j4 zl1WyHVZXxrK8mEsnZeSqMZsbLrXwj4flnDuu0uGZ3/Txmnqv+XUn06r91st6/YB0wf0dx+rdS4O AKQiGSHRq1W2su2dwhmaqz0wb8MX+k8BszZ/D1hBFi8uIcflcp1CwjIsvVHDX4kWDGNQs0Ec9ivN P0/vFDgODx/+n2L1kdOZJSaGoc4BhN/tJ916zzl0DwnOOcaLMslU5tdAQ4Bp9LgvNCShkbvhmM0d 8VS6OxMQom1lJTxNe5rBYjQbLhepVBQ1WTqiPEYhNQQtD5mu/wBo5XxnXDxGZS6AYDHLj1c01LwG xUzCHPNvhN6fdWMp+JPpxNLgVfHLDVxGKeBztMjCRvccrEVKLU/SZzlNSi4+2ZnRjFst4phsv+lw xmHxmxZGLDUvAX1ecD04rgGJDcyReXb5uvfXTfpxhvRDAMRYJ2QUJJmfI9+zRyVq08fviJwXrt1F wvDcFmc/D8NqP05ff0yHVYle7HJPLKa6o8UVWzHXNnkXDaSV9HIW4bNM1gsZGNNgl0LGVFZHDpdG 8u2Duy3XeF7w19PpekWGvq8Ggq6iphDpnOsSSR8Lw546ehGW+nXWnCIcttjo6eskDXw8aCV5JSjK TR+gWXbSPvPptV9VhXVCOidO/TVQ6X6nk8fC9teN9zY/DnmsuAJbCNI9918f4QfDFhXTbLVDmDzh U4xURh/nBwIaCBsu9eqmRMN6lZNrcv4pOI6WqbZ5JAKxjkoZYy9I8Gr5hJRXLPzjF7Ysan1NJc65 ssuR7B6tYHxdem/Hx4WsL6C4nQYrgmIRTQ1btBhY65B915ZoMLNSHyvcdTG6iOy3qeZ7v09mjyb8 Sr0ZjH6hwfyrDQOUmnnNtAATw8XsRuvAewoA2sFQIbtayK9twUDiHHlAMaRpIQGMncGygaRaycIw 4XBQCnMcRY7o6eEiT1DdMbHfumxOOtAVIzyjub3WM+Ubtt6k6UlzzfYDhILAZQb3QEjbGW/zHlvw skBrCCDqvwjfFG9guBdKcGxW3QC3AmQlpsVXnSsNybo2u32V+qRxjCtlQH6iWYgHcdwsrzjG0WCQ +ldEflGxwuA7cpZRhnEltXHsibY2twlOjD32bsrDDG4C90TAzh6sm5uo52kW5KEOBFlbBNt+VBsb FTtvsrj0/wBW5QBWuw2O6pgceTZS51WA2RHsgKsQfhT7tlDsbqAE7oAXjYhoAKpjRoJc7cdkRtff kILApYKmc2pYGuJ29lYaI4+NRHCjYLHUDsjuLkDugEai47ixRttwUL7l1rcIy0gAqMFtFvwraAXI XXIFjuiHoCWAX+h1whNyboncKw8u2tslggBDt+PZG2TRvbZQi3dL1tN9RtZWymQ2T9QLkWsnMJDd uFixhpbdpWS123pXNmjOivYWWVE7XsVxcM51Wvf8LOhl4FrH3XNlTHvDmvAvsUcc5a7jf5UGlzLk 7oGapLn2XNo3ZnsqyPcj2VSuMtrLHiadVllwRtcLd1goAjNr22VtNj8p0gIFhwsdw0glQDhctcUo t8xtuQFcJL+T+yYQGA2QAxG5sETjcoIXBjiTyqkmudhugLa0b+/ZU/sFGOJGoojxfugBbJc2U3d3 sqjj9V1b9troCOi0i97lU54YNhuoDxvcIja+4ugAvrHCAR23TT6dh3UYQNnC4QC99O391NZt7pj3 hgLQOeEltyDbcoAnvvHYCyphDYrEIw08HlLLC4kIQkXFkRcQTspGzQdJI3VSNDRs5ClNPqPz7qjc Gx4Qnd4ITbbcIBb3OY024VtB0glEXWPF/hU3ugL3t7lUx5F1brgbIBYcndAEXF2yYC3YA7pN9xZG GeXJrugLcHA3CCWYtFkwzmxKTq8w7hAWHjSPcqjdvARMAvupNqbbgfK0mDHLnOcfZYNSwOLrnhZz tr73PcLjqpwDTe62jLMXZjedljVOhrCTuSinjLWXBWMXen1H+67RPOJdpDQe6kbrWsCqJ1O3bb5R /b3FlsjCL9i5C31FRzgBbbdC15abAKMDSAAqDwywI57q3NOgE7IS3ZRFI5tj+U2FhY7UTYdwgYAW nWfwjbYN33BWiFP0udcbonjYWQ7M2G6Ev3HZAQm5siGxsOFTm3IRtsN0KU4eWLt5RWLgCVWoEcod d9kBT2Dl/HayosbueNkZIt6iqNhsgBY7TfuiFih03Vt0suXIAjbuqPB+FTmaxcnhCHagWt3+UBA/ dW4/Cpr2i7QLuVtLrXIQFMkBbcdlTrne6E2jO3BRts4+nhALk9PJSNWp2/CyZow882ssYs0O5ugL cfSgdvdVf91YF727JRgEgqW7Eq9diQUD9ytAKQ6raTwrvtY8oQbHZQEX3O6iBZfYJM0gB35UkNxs d0LmOmAFwLKAFsQcS48pzIfLb8fKlPYAtdvZE7+bJpBsgFOBuSHIHOLrBC9h862pNaB7bq9AtjRb lR2lzrcFMjs5hNuEprLu1HlUEF2m1lRk0n7Sm2u7lG1u+n/upYMV8hZew9SJkrnNu7kJmkB7gUog NcRYowM80FuzdvZR7vNYdAsQqbIG7e6W57mO9J2KWC2MJZqeLuChv35Uex0kZcw3I5Cpsb9PO6WC jJo43RCS4v2KIRhrLOtdU0bFQB6m+Wb2JWG5zwbDhPki1C4KU5jwdytAyInhjfUrdO5ouGkt9rJA LmfdueyzGyhkF+XeyAw6ioZKA3QWn5CyKd38m1kt8onHqaAVIHaXaeyAymMPPCs87cpzLFu1kt7d L7jdCoqIPFyU0F19+ArbL3srfILg22XOzRTX6bne6bE4vBvv8JIBcSRx2To2kR3PJSwQGyjt0GzL o2uBbsoBbht8oWPtyE0jfayqS4A2BQAg6ySE3QfLuTY9kFObB1xyjeNhYqgWG6RubpgdtcDhJJ9X OyYTpHpTkEL9XDUDm3sraXNBIP8AdVrJNkAbQAPdVKW2BvYob2Fx/ZW6QW3CUCxbQe6v/mNA4sgE of6QLK2fclAY5uhoA5VSC9lO6hI7qAEmwVuIt7qiNdvZQtPbhABrPDeVGXBuTur0lo2CG44PKtgZ qQkguKoN35smuia0XA3KgMd7zqsBsm2BHNyhIFiP8qo/Te6AgJBN00aiEttjybJhNhsbhADp0nc7 lW4gWPKB49Q3IRANfYd0BJGBwFyQkGPQb8hZMxGwA4SnNIIN0BdPO0kgNsFZ3uVAwAAj/ChIugBc NFlbm6gFDeR1lXHpugGQAHi11b3vcbWsgY8RC45TIX6iXOKAx5JDrsOypsdvURv7o/8A3Seyaz1t IIWgJcS7vdU5xCGZzY3Wv6vYKN1Eb8KWVBB+gAq3VLSLWQ/d+EOm3ZLIPY8OG26Fx0uAAsoyzXbf 2VOhLyTwoChINZRmzhdUKORzQeB7pDhNTyljgC33QDgBvZWHWPuqu0N+VTXdrIAmbE97q32DgW7f KrU0bISwSC2o6vhAN182PZIMmpxudlWryNnI5YPQ11uVbBYdHH/yhYHlQu+TdKa22wFyVZFgb7IC 45D5hcVkRyB9ydli30i5/ZGzWZGuafR3BQD3C44WO9zmi1k97r7N3QSNcWg23UABmtHuLJYc88FE 5uobqjsPRYIAmucbXRNAuSdkvUSRdGQCN90KkR7tIKXGwPcfdMdwA0X/ACqZ/LdvsUDIYiG+yEMD d7p5l23SXAtcbm6EDB2FtgobkKtdm+yIEFAAbobkIjsqI34VBCNQtwhZHvcFFfcAK7+w2HKAt7dQ +VYFmiyrzGkbKw5trKFRW5dsVHN3VEgW08qnOtY8oGG91m2Q/wBGyh+2/KjeOUJRX9I4VW5V6btv dQDZACfyia0gKiExpuEBNy1UQbIrWF77oWlob9wJQAkOA+FTSNSYXatxwgO444VRossNrjcKWa7j ayjXuc7SDa+yZ5AjN3FVgVpt+FZaAy45REtPG4VFmk37FET2LYLg6jZG0iIkb7qnbOUI2uNyqUsu sR8qyQD8oWtL/iyptid1AW14OyIM1Dm1lT2httIVOva6lAHTve97qyW3AAQ2sCo1Vk9B6SN1A33Q tl1PLewRFwN/dRBA2uOVZvYKBhcDdSxG3CtFBd6thwqbK1jg0BE5rmoSyw1HlEBvl73QFu6FnmA7 8FG42G4WQRuw+FLkX3v+VARa4uqtdAVquoPTyoRZEG6yAgZUZBd+Fklwt7IBEad1+QULpL7EWKGQ g/bSBwjNnMAA3STKA24RRzW9SAsxaWm6xSGuubWss5jjIHf9lhslDdTXCxuqWwWsvfdRwBG4vZUH HUeyEEg3UFje3wrcHW+ELTe3umEXaB3QC7l3KYGlrhb7UJ9N9kXnFzdICFF3LqsP/pAsEwxgkuVM Fj2CI8f/AAgF6TY22KAsLmnVyntt3CVK8BAAx79mg7LIDAW7jdIh3de3CeAXA32VFABxvYqOt27o 9O3z2Sz/AC/u3VoEcP5bhdYT7hzWN5KzWt1b9vZLdStdIHb7KgXDAYna3G49k0uDnEhtgrkHqtf0 o3SCOPSRt7rA6FEWJIKaw7X7pZcCNuFT3lg24VMj76jysaYyCSw4VX1tuTYhMabjfdKDI21r33SZ 7OmDrJhs2+/CUb2ud0oD4R5h1EAEJrmtDdR7IIo7s25QSA2tewUFiZSS8W4KMM0nfcBCRtbuE+Jw 08boB8bmRhrrblFJLE4FwaLfhY7naTYi90mUkjbgoAnUcLpDIP6lDG2FzQ3YFWxoDQL2sqmJsO5Q FhwLiSrdZ3ZUHWZuoZGu4CtAAucDsNgrc9zRdo5VFw4JRtlDY9NrlQWLc4ubc7FW7YgDdWTdtzsq IDeCrQKbM48hR7tRvwFANQsdkNtrHZQB6hZCzUZSQLNHdCWgnc8Imvv6e3urQGCNp1HvZYumzCSf 2CytIbHzdY5FwQTyoBsZ8yO7QrII5CVAXRMICaXWiueUAJcCfhES2x3sEpp187AKgASb8IaDc3Uw m1yquDFuN1bzYBrXWKWQ5rgDvdDJDI4saw/b7KPYNUZP9JuimFgAFUr/ALbBWxY6WUvcHH+6EuBd zt7KNj1xh17fCW/YpYDYTYluyqIBznB3dQAtZccLGe1z5BpOwKoHvaXXHshBGw7pgv7JRaA8m25S wGG+/BSpbsdb+hGx2n7v7I7BwuVGBUcfq1A2b7JhY297n8KjNYFluUWmwFtyoCr3vurEeplx+5VP YWn8qiXabNQGPDG2KR/9StrC15J4TWQtiBJN3HdW5zQLlAA6x4FkYOsN+NktvqBITANLdlaAmS+o kpQJHBumTPbf/ulahyOFQEyxBJUu1wNjv7JdzZWwBu/JKoIHX7cK3DzNldxpsBYqiS38oCaTHCQd yqYNib7qnSHb2VTuGgECyAI1QiFnBQTa47jhWyWF8ID2Ev7Ko27EWt8ICAuAHsVLHuFCTcBFcndA Ux39NkM41OCJve/KIDUw+/ZAYjz5TtQ/si8x1RuBwnOhYG3dvdKbEWOs2+koBwIAFt1dhIPlQsDC LKagDZAUGBo33S3OcTtsEdwfyqLDbZAQjXtdW2LdRrLDndFuW3GyAmjXfbcd1ARu211Qe5ot/dWz cIAXsawX4/CEMa+2yqW+oAbo2Pa0fIQDHQWbsLBX6WsAumecHsCxJgdBsgHOe37gdkOpzgbWssNs p2HZZMZ0jc7KAPTsNkuRvqFtj2T9i32SXG7tuyAc1xcBqCp4Gq/dL1lXqu66gKLfVymN27WQ879k Qdbc9kYAcT5gA+3uhebOREFziVYaLb7lKBYc0sIJUY4Qm7d7pRG/GyvULbKgdMTcEFKD3E7iyhlN hflERfdGC9irOyobBURqBRAF33KOj8z09lQHfsEbDZpN1QJbTugcbHZNjaS0nlHuTcnb3RNFmHSg MYXvuVZ3da11byNXCG5abqAYbW4Q7ONkVwTZW0C6gBDdiQeFYueVe52HClrBQFDe6rui4aVbLcoC NeBt/UoXAg7JZYPP1uCJ3qQF7FWYrHlC0GyouIKA+2lZ5nGyXJG50dmncJshIdzshe4hptsvKelG E6OVo9Sy6KPa+qyRNKSAOSmUoI5O6WU5hsYLL3ukF7jdp4usiHTpHdBOwkkcKMCWv0HSOCimjsAT Y3QuFm+kboGucWEO+5ZBHDt2VOZcqjK0GzngewRCRnuryKMOqicWG22yXh8IEfnPaCGnkrMmAcw2 N7hYMbzFHoJIbqvYd10j2T2e1vB51AgqYGYTI4NnZINIv2WzLMmFyZg6S1VJF6i6jdb86eFoby3m rEsoYhFieFSmKZhvYFbAfDR9RDDRg7cEzs4xWGkTDuF9TBJRPja3BKfKPOfTfKVRg3VXFqSsgfE7 z3tYxzOTfstsXh0ywMn9N6aScljpx52l39AP/ZePerPXPowzMuEYxhVRTmoEgkmOw7912V1P8cXT 3B+kVazD8Vikr6iHRTxQOBc3bnZfQySUocez5kISiuT0b1fyNQ9YMg4jgzZ2udIwljmG/qC8s+Fj LtfkTqtVYRPC6KSmd5ZDttQHddeeDrxu4BhVJXw5wx4skcXPiE7iQN121V+OHobh+c2YpLXNmrTs 6eFhXJJQTXaLGE3Kzs3xcZqzDlnA6F2Cucwzu0kMaSXH22XWnSLobmbGMXhzXjANM02kEThuSvps W8ffQ3GvJdVYs2ojiOuPzY7hp/C4TGvqa9H8KBo21E87XCwMTNgtY8koxUEuTnKLWR2dneK3C6yr 6RMq6L0yUha57r2ICZ4UepMud8gNhqXmSooz5ZeeHBeXOt/1G+n+Y+k2KYNgEs82JVTSxkT29iup PCn49ME6M5bqsJzNBJI+Yl7JmD7QTeyslGGJwl2bWKeSe6PR9V468l1MfiOp8Re21PVwMER93L1H 4P8AKuLZeoZauptFSyNAAPfbleBPE/4zsB6p9WMAxvAYZZsJodJeyQe3K7+wn6oWScByRFD/AAmR 1eyAsZHCf6+xP+FxnmhJLcdseKeODK+q1mTDMRy7SYaZ2uqGetrAdyVrTo9cWDt1Aj2C+p6rdYsc 63Z3qMZxuVxjfITFDf0sbfYLhq2EilZC0bryZskclKPo9+hxyj937PsOmOHsxTFcPIIaGPBN/hbX fB5hM9HIJGtu1zLOsduFp9wDFajBKljoHFhYdS9n9EvqSQdJ8Fiw7FMuvqDGN5o+Srjf4e/LDdE7 ++p9krHMYy1g2N4cwyUeHuPmgAkt+dl5s8DnWDDMudR6IY1MGB7tIdIf/lfR9bPqg0XUDLEuE4Rg DnmqaWSNntpaCLXXhsYtPHiUlbFeneX62aDbSb32Xv37MSjZ8TDgcssnJG+rrpkCLrT0wrMLpZ7N qo9Ucjdwdl5y6NeBHAMPwKbDs30f692rSx3BsvHPSP6k+felWExYVVxjGaKAWYJTdwH5XYWOfV+x 7EcIqKeiyvFS172Fscuq+h3YpjlLx7U1RwnhlDK5RXJyeeOkeV+lXiTpMu5PZ5cDrPdE43c0/C2X ZHppm5Mo2Tt0v8oCx/C0FUHiEzZU9UGZ7rZ3VuNseXuEmzbfhetcO+rfmyho4qeqyvFKGsDXSRu9 hZeLJLk+o8csmLk6r+of0qxLI3WGoxt0JFJXyF2to2J+V5lllbFTtIG53K7j68+KfMXiKq3PxSmZ S0MbiYouSF1PHRR+UHEam/K4ZMm+dsujxSxRcTtfw65xgyxnnCauZwY10gY5x9j7rdp0ozLh2a8m MioKqN5LLHy3gkXC/P15zqGWMQki+4LexXYeSvEh1D6YSh2DYvUNiP8ASZDZWMVZ6c0G1aN0vTDI eJZNzjjU1dNNPSzuLoXPddm/suFzxg+JYF1dw/NrBEKHSIJ5S6wa35WrCf6jHWpzfJdiLRFwCALr 5bM/jC6tZpp3RVmMTGB5uWaiAvo49sXubPivDklwkbn+rmRJepOF4XJh00eqmlbOx97hw2X0GYcB kxzp/V4TUGN1TLSmM2NgDblaVsD8cfWfAcLZRUuYP5bGaGEi5aF8/U+LHrBW1Usv+ssQD5N3MY8g LnH0r6NSwTTfHZub6KYnh1NlI5WrZ4o6uhvFJG94GsG+4WZ0y6cjp3juO1Ilg/R10uuIh2/4K0c0 /iD6i0GNnFBjlQaxxs5z33JXI4j4nusGLTtlZm2tjtxG2Q2CuSVN0++wsEqXHRsD+pz0vosz9N5c xtcBW0b/AEG4OodwtVdFPK1sLGixaPUV9xmjrZ1Nzng/8Jx3ME1Zh97uY9y+NpYgSQ24FtyV555N 6o9WlwSxW37Ow+ludWZMzLS1+r+Wx4L7H5W6zw/db8sdT8h0TqPFKd1RDEI5IXyAOG3stB1MHMqH sBOkey5LDs243lapY/BcZq8Pl7eS8tH+FhKj25Me9cG/TK2A4L0wr8UmlxmnhpsRmMvlyytaGk+y +H6g52yrkbqThmbpcWoH0srP08vlStc7fa+xWlHFuoudMwsaMSzRiNSWna9Q5YJxfFa6Ly63G6qR g3aHyk2XsjOPcmfIWmndG9/POX+nPXjBYv1+JUtTEQHxyiVoLRbjdcB/oTpL0pyDiIjjwY08ELnO le5hkJt7/wDwtJsWdM4xU/6KmzNWMpQNmtmIXGVGIZkqS5lXj9bNE4WLHzOII/uosrhHapcG3opO W6uTa/4bvHTlKuxqvyri9QyhoY5nNpK17vQR/t/C9OU+b+n2CMnxyDF8LbqaZHTRyN1EW+F+fePC pzGXQVb2Bpv6XW3Q+fj9NEWfxqt8o/0+cbH/ACs71Jttl+HJJM9peNTxcf8Aq1n2bLeFyl2W6R2k OB2eQdyvZvgsz/kbBultLF/HKKCqDBriklAI2WmOlD2ROc4ukc7lx5UvNE8Opq6spXj/AOjK4D/C 4yzuXHo9OHSbYO2bi/G1nvp7juQGSMzRRR45Rv8AOpWxSBzn+4XK+Fbxi5Lz509psNxXF4aHFaCP yJWVTw3W1u1x8LSw6Oeun/4qvmncD90rySj/AEIhmvDXT08p5fG61x+y08qcFH0eb4klLcjeXH1L 6BZQzJVYwzHsDpcQeS6VzJG/d3NvddP9Q/qVZIyp1Bw+mwiWGqwfXpq6ljRdw+FqOnwkVEmhtS+Y 8lznG6WcHphMYZXFzwPuO60sqfMuSw0j/wCDd5V+LvoF1cwaODF8bopIyQ4QVY3aUGevF50ayTk6 SDD8TwuvhjhIjpKcCw222C0jTZaiYzzI5bH/AKXEFY0GHRTTiG0o93k3CLJFdCWjk3uPtupGdoep HUnGMaggZBSyzudDE3s2+yrD8Lmq2SGN1ieGr5uLCxhtUNB9Nuy5emxKqonNkgdYj3XnnJzluZ9P Dj8Udp2B0i61Zp6DZyp8YweqkjbG4CaC50vb7FbGskfU+yBjGCRuzNSugqg0a9FnAn8LVc7F5MWm 1zsbqtY22usCXB2VRe+GB5A5DRdbx1dMzmwqav2e7PFL9R+nz5gsuX8jB9Dh8g0yVTtnu+AF8x4Y PqITdGKRmG5op58TwRxuXsdd7D77rxfDSUcMhbM0x24P/wCVZDqNtS3TBE+ob20i69MnKttHgx6O KuTZtfxj6qHSx2A1Jwf9TDiMjD5bZI9g/sTZa+cy+JXMWJ9S/wDWEWIVEuIsqDJFKJCA1t+LLqJ2 XJaYB82HzRNPdzCE6lpj5zBE06fa3K57pwXCOkNFGUrkzZf03+rLl/8A07BBmvD6iPFYGBrzG3aU 25XQPir8emIeIHCv4BhFLNhWEh+oljrPeB7ry+7AK7E3am4c58Y4cyI3UjjioGmJ0D2Ptaz2pGbi 7SLk0kHL+R3z0C8b+cegEv6aJwxTDHAB1LU3IH49l39j/wBX11TgNXTUWUTHiUsRZHUeZ6WOI5sv BVDhr8Tn8qGmdUSHZrWglMxrI2OYLAZ6rCJoIzvrMR4TfKc90uyPS41GlwIzln3GOpuaKrG8eqpJ p6hzi4udewPZZ2UuvXUPpQ4U2UM01VFS3uIQ86AfwvjG1kUTjsNd7ELJlpTM4SMYBGRcrOSTk/se nHgxwioo5zOXUvOXUHFf4hmfF5MWrpP6nuuP7LtfoL42c8+H6f8ASUuvEcLf91I5xsPwuh2RBpD4 zdwP2lfSZayTjGaqxseGUUtXOTsyNtyfwFIyd0jU8UKpnrLP/wBVfOeacv1OFYPhQwr9RGWPqTu8 X2Nj2XjyTGK3HcYlxbFJHzzSOLneZuSV9pmXo1nbL9F59dlevp4m8zOgcAP8L4alkcJnQ1bDDJwA ey9i3pWlSPHDT41NNOzvfpP47uoPQuM0+AUdPU0R28mVmxAXZmKfVr6j45h89Mcu0kTpW6SWN2C8 o4Dl3Fcy17KOkpnVEj3aWtay5/wvoc59Cc/ZNpBiFVgc0NHy6Qt4C4qL3bkdsqTdM+DzBj9ZmjM+ IY/VedS1VZIZHOicQWkm6RPnPMdQDh78yYhLQP2MMkzi234urbVuqiGucGhp9QIWPU03l1Alia17 PypKTvk6RhHakZ1DXVmEyRSUdRJDPG4PjlY6xDhwV6FwP6gnWfL+Cw4eyu1GKMRNnO7rDgrz/SYe /F6iCKGN00riA2JguSvROW/Av1ZzXgcOJ4dgBFLMzWwSGxA/BWYyoxkhBqmdL536l5u6p41/FMxV 89fWXuHzOuG/gJ2Vuq2cenk4kwDE5cOlG4dA4tF/my5zqJ0Kz50pqPJzLgdRRRHifyzot+eFl9Le gWburdUIst4fJXHlzgDpH7rtctv9HnWPFFcg5n8X3WPNOEyYZimZ6uqont0uj1WFvZdNy01dO91V ciYnWD7H3Xp/O3gY6q5QwySuqcElkDG6iyFuogW+F5xxB1bgda+lxKGSmladNnCxB9lh79v16NY4 4N9p8n3eR/Ff1k6aUrKbBcz1MNOwaQx5uAPbdfN576t506r43/F8x4lJVVzTdsl/tPvZfN3llbI9 8tu4b7hZ2VcErcexBtHQwPmnebNY0XuV5I1Fntljje4+6yz4musWUaZsOF5vrGRNADYy8mwTsT8U 3WbGS59Zm/Ei9w5D7AL0b0s+mPn/AD7gjMTxKtp8DbJvGyYHUR8hfVYp9J3PFHRyfpscpK6QA2bq 0g/3XeCjfDPHkcJ2mjwPm3N+ac8vgOYcZnxFsRu0TvuuOppHU9PU3OoybAr7nr90Jzj0Jxv+H5ko X0zHn0SgXafwV17h87iXMke1zA26maMopWd8O2vqXSscwC5sVmsB5WIyUTONuLrMY4Fq8Z6KBLPW SltP8zg2THS2dwlB5bJuNiqKMhj2tJuhY17iSDYBCbdlYNigDicSd0esattiEFywcWSw6x3CAe53 m3ulAhvvcI4nAg9lbtIIcgHRN8zcbKjGxpd5gLvaypkocQ0CyM2DgXlAIYNJ35TY5BrLhyhlAe7U 1LDHNKGkZ4jErLk3JS9DYvSdz7qqeQEgHYqpLF9wbhBZHEW22KJseoXJ3QaQSj0E79kFiwHEG5RM aS4WRiMgm/CjfTfZDLCLf3QPNmg8JjGmTdKqAAWtBue6tmkM5bshkDhsEbGgNCt1+5sFbAsXturD jewUd6d7qjIC2w2KAt7LAXO6DSRsmE6gO6DhygLYSBZCWCIXJ3Vuv7pD4TK67iduyjBkNLXAKOtp +UsnSQAicQRvsUBNQ2TPLL49QI2SC2/dNhLxJ/024QC2/wAzb2RNuz5RujawlzT+yjSdN0AQsWXP KTO0Nb8lODg7bgJMrfMPKAZBYNBP9kwvDQbbJUZDdijJ1j4UNIuJxYbrk6d2tnK4uJ1nW9lmwm51 DZYaBnMJLrDssgXO42WNDJ9xTPMMcZI3PZcmbRlxkM3J3T45NI1BYcUZmYHk2KyHjQyw5XPo2NbK XA34RPOuEgBYsZdezk+OUtOkjbsp2BbXlrd7g3TmvD7JMzTcfKMAaRbZAHJEAbhLYwAl2q/wnvsW gDlJkb5dttkAQsVbmqmnbiyNw0tvygFGXygi0h7dR2SXs1gIC5zLNBuEA4OawcXRFjraux90IAFj bdX5vmXbuqCAt0c7oblLMRidcnZPDwWj3QC3Os4CyKMBpNlZAJ4UuNW3CAsA891Dbm6oEgHdQPsD fdAC9oe7WOEBeHA+yGRxDr7gewU/7KAGM2dvwie9wd6RcKjZxsOUwN0jZCMSZjqtbdG14vvsSqaB JUEAfb3RSNDzcbEKsWR4PZC1t+UzVdo91GC9woWw2M25Qy3bbvdC0EbAom2sQ7Y+6AW4emwVtaQ2 yoH12PCdY7oBAuzflDV/8VDpva3cInbHfhKB3NlpAVCbtLP6h3KwZLl7tXAWXK4tBeB6gViTs9Ot zgC7ey2jEmIfGwi+q9+y4yoha59g7g3WYHckbrCqWiRrnag14PC7I4FPlBYG2GyWY3K4Xatjym+l 29+FsgJjNtihYPVpvuU0WHPCFwBN27n3QWE0iPYnZDJI0G//AGS3sL+6jYm8E3chRgOsgi9kUjwG e/wFbLtFgEDtLXWO6AEEuBsjY4hhvypw46RsoTdp7IAmOOjcIdwd1LktACg32cd0BRILrWVuGi3d WbNO4/dUHXJBQF6PMvvxupq1NB9lNLhu1QkFvugIBqHsgks+wHZXIS1m2xRiwbuNyOUBT3gNsOUI HltBHJ5UDQ07qyNfBQFF2nf3UcdQtdQt22O6FshabkXAQAD7ywndT+ki9ipNMJKgvaLbJYJdueSg Lfdjbk3KSXl5vaw90+QAs53QujtBfshBTQA33+UwNFtkgHUAQUwOu1aMgveCbDlQEqFgbY3uqDif 2UBYO+4Q6NT9lHu0W3RGRtvSd1QQRMjcS4XWDL5hqrtNmlcmyISM9RWNPFY2tuEBTntiILd3d0LC S4yXshawg77poaAz5KlgW6EPcJA5Nc8aLAXKDWGCxTGSRsdfm4UAHnaWW4QWuQRwreNbyeyJo7BW wG2w3KpzjfUqc0gKoZvNd5ZZb2KIFsFzc7q3Wc0g89kMpdTm3ZA9/mtBAsUYF+Q5zXajY9rI2t9N j/dLEmo6blEbxgKANt4X87fCpzix+o7gqr6rK5GEcbtVoELbm99zwm6dLR3KTuy1+EQnNt2qAPZq YyJkhJB4WM5wceLI2m3BWgE+IbuN9uEiB72TEvHoWcGnQO6VVt8yMNADT7oBcp1Ou0beypgN7kWT o4bxAcn3Qhmk7lCoyYnFo3VP3dcIA/07co4B5ly7ZZNItpNj3KYxxfYEcKNj31DhWDybLALj3JF0 3WB6b7pDAD6iOUTI3F/sgDc2/wCSqLfKPIKhhcQbHhCGANJJu72QFOO97q3OuzndA2L0FxNlA8C1 +6AkQc25vcoyXBvuoQGi43QblAFEzkuHKNwBbtsrYwMbubhCXE8DZAK0kHcomiyIhrTYndVpB/C2 AbEuuP8ACNxuOETAG7DdU5wbc9kADWgG4G/KJlwSSFWu7Q63Ksm3zdQBh4cfZTlpKAFsYB5JVgoC 2nb2RcKgLqSWItaygBcQRylPAI2TQzTsUEhsdgoAGuIO9yssE+Xx+yxmSDSdvUrje83u6yAa4FzL 2AKUGaWWO+6jpbE8lW+/bgoCtN91ZDmN2VAkNsnNHp53QGOXO0k2uUUd2NBcN1coNjZBBKZHHVwE AzVf7kuRpa4C+xSrufUAD7U2Z4fOGHsEAQFh7quOd0RtwFQBBIKAscEqjHZ9wVZJFgFev+6AQTe4 JRMu5pI7IXAaj7pzC4MtYICo9zbkrIjjICRGWxm53KyPM1ccoBE0UZde13BLDSSbmwROkuTflVqJ CAsFjPwh12cCBse6hZqFrItJjZygIAGyB3KOSXU7TsAUpj7uvZU51ngoDOr5x+lp4ojYtPqKx6gt e0HlyH9OSzUXXPslEm1u6AJjdwSmWYSfdJIJF78Imtub/CAgaLlLJLXenlMJI52Kp9tx3QCfLMkg LvfZci5oLGtPFliRN/ujleWtAQB1EIjI07hY/Lt1bpHBo2uowknYICiwuNiOE2MWaQraezhYqn+g 2CAEO0nbujYT33CWQALnZGBpAsboAHgEm5t8JYjtxumSNDnBE2wagEWOpNabm5Cp5sPlW2S2+wQB EB24Qubq5VPl9XwprsN+EBb7FthyEsXfyUVwxvGxVsbqbcbICuBvur/p+UoO1u0+x5RkadjuUBYA tZXuo0k7KHYEoVEdsbgJZe0k/wDZECWndU5gJvwUKFGWhx2VOFne6nljnuoWoCaRyr2+02UNgduV TrA78oSyyDtbYKMb6iFNLncKw7y+RdUWTSChtpdzynNaCL2Sntu6/cKE7BuAdymE+m7UkN13unM9 MZ/CAW6TVGRbfhDQ0Guez3W7rIZodTEAeu/KFnmNa3/cdrrQEveWSlg4BsrDidroXHy5tzyjY677 gKlQyNt7W5CCqfYBpJJTA69+yWQHk3G6ywwwWiMAC6pzjIzi1lTQbfhQOOvcbKEI2oie7y3bO7Ib +SbWuD3UlEYd9v7oZSXEdvZaRpGRrBG290ot7q23YLDdRwVDBB2t3V78EKw2/wCyq93WQFW1OI7I 4WWcb8BRrCRsgcCw7mwQAxPjEzx3KaAGycJbtNtTR6lbHF4ueUAb9wbbLHaHk3vayeHjhRzNrhAQ vJj35SrlW72Qkn2QBajb2Cp7idkQbdU6wPCzQIyS502ujBBuOCFUYAsQicQDcDcqEFt9V9WyJvNw rI1kIWt0OO+yFGvlc0E3ukOe6SxIRPPO4VRyAx3QFtAaACnCFpaSCkueLjuiYHvnaTYMVAxp0NsD v7pDogZdxym1BEbgO6qYF9rc+6goQ+JxeSB6fhQNGpPa9zGFpSgSCTZAyaHMchZqD90xrg7cojZz djuhkHTe/sqAtt2V7tHuiG4WkaBGwKDzHNO49JTDyitfYqUGUbaQQUlxA53TiBbYLHqBuLIgg4By Ub9QPPKqMbAjhR3PKpLI2Qg6SLhSUvJFhcKw0aSbprJLAC2yllAaDqGyIBoeeyPy7P1DhIcDqJPK rBThrcUL7mzbXVi4BJCtrwdu6yBLRyLb+yAu1DnZZBiJaTwVjeSQTuhBob6VbwQ0W2VRHUznhEbE FCFGNr2c3KAsL2aQbIJJNNtPHdRzvK0v1XVAd/KNi5HcPaRykywmceZdHA0sjO+6gFX0Pt3WVFtc JbY22JJu5XT/AHklUEfcv3QC17HdXUTes27JcRa6UOcVBQVyeQmAl+wRvLWgkboImEAuJtfsgB0G 5F7/AAqawOfbhNazS433CUGF5P8ASfdWgNfTtJ5WFU/eGN/YhZMbCxhcXXPZDGwE3tuoAImPY20n PZGAS7SVcpc8i/KphLpC0dh3WwXJc2aq02FuSq1FzyrY1wcboBb2hh3KLcC4CSWETkuNwsh2ot9I 2UAJf6NPdJexzngnt7I2WBJKM2AKyCOIIABVvIjbbkKuGEW5Qu+wBWwUG7XuLImAWPe3ZCB6bFFG y5tfcqFYlodNN6TsFk2Y02/q73Quh/TeoG5PZSXgP7+ytkI71kAC5VaA13q59lBMWEOaLqP/AJjt dt/ZQElkcALCwVbhuyMsDgqLCL77KgF77xWQR2jd+yaYi5vskaNJsTwqBxIAuCqafNIBQOvsD2VR hxeSOFkBTM1FDGCGkFW5t3+yKJpeXAchABYkWt35T2R2aC03PyriaSHXCgdYlo2QCnseXXd2Qsdb a2/uoQWk3JKrWCPtQDGsDt3G9kurgD4XFpsRwqLGgXvYphYJGaSdlUgYmG6pbteQAO6yZpdNwOyX GxtPE4MvcpQcQ+x3uqgAXhwNxuqI24RPbocVWod1QVYgKeZYbj8IiQWpbgbBDNhg3Ut7oR2RncIW yrhpFxcK5GCXYIDxumRuDfyhRkcNm22CF8flNPcpokbtfnulyuvI227UAuPuSqY7U6yuU+rZACYz e26Akr9DztdAybvZR2p5uVCwNF+BZACZNTu6yA8Xa2+9uFjQeuQgb2F0MRc6cl2w+UBlkajbhC9r YrPJujEYcRZ2/sliIh7g83bZACP5j9Y+1ZTWaxbj2XHR1DmSFoG11ktqTr9kIxj2+XdA55IDQFBL rk4JTBGfMueEAB2tdXcA2CGQ3NwEAlJPFkKMNuQltaCLhWH67jhTQAOUAbObX2RSR69ik7tPOxTw 7W3bkd1AYnkuY8g7hU0O1kk7LODQWm59SxZKd2vUDt7KgfFbTZxQB15CbbBWDYWso5npuEBJXEuB aNkDnabXRtNhZBbU/fYIC2OJdbsjLwBc7JL5SJQAOEEr3S9kBlt0uCgHYLGglIIa/ZPc/QRbcICy CB7ofKJGw3TA8bE/2VGW9ygFFpvYhXrIHumari/dC9hAuOEBWu53V2J42QtdY7hMuEAvTZp3RtI8 v3slPl0v0hpIPdMa0R2ub3WWABIX7kbKxUAN7q3NJOwQubZw2SwQuDt+ymkOIVaCbgnZG0Bo+UsF g6did1TrBw+VRaXOuVJWjZOwWHFlz2QtnN+EV/TpsgNmt02RAMOuL3RNOkb8JcbbhMJsLIwCSLqj a6IAFxPZC31ON+AoBrQLIbBS5aEOr5VZWfXzuJdccKzcs+UI5NwjFhzwvIegW71cCxRUmoSHVuqf sb9ldPII33te6hTloXmwsLK5pAXoKeRsoLb2co+CxuDcowEXgAiyTLqsSETrg7hRsd9wVEDH/TMn Z622ekmLy+eQuRDR+SsOd2qbTwFQCDqjJKB4EbNRAcrkbpFrrGnJc0BxsB7Jz6DdFtxeQVTaeOO7 CNypUwgO82SORrT/AFMaV9p0n6evzzjgjjF42kX/AAva3TjwoUuc44cPko/IpW/fM5q9mKMpPg82 TMsas1yTYXHVPuDLIz5JRQ4Q0EtjedQ/pe662oZz8A+Qct00ZqMVDJXAaY3OAc4lck76aGS8dyiK +iMzK9zNTHB3K93inDl9Hj+RCXNGqZuE1UkmmKmc+3JasuLL1TIfXA+/a7VsN6I+GTA6rOdTlzEq WRr6STQdbfvF16Sm8IXTTBcdpMPqYYopagXa02BK9DwtUrPO9ZH0jTO7K83l3dSODPdL/gMQcGOb ueA4LedW+FTpRl7D/wBRieF0opmixfKAAsGk8H3RbN1MK3DMJp5m32kicCFyVVbYedN9Gjl2FCnl Df0/q7OT6vLdXLG2Q0Mz2EXBDLgrdVmrwAdN8w4W+Ckh/RVNvTIwA2K6/wCjvhEwvKGaKzAsx0Ta qNrv+HnezZ7bp4o5OVI18pQ4o1H4dgrq8mnp6U+cP/a7n9k2oy3WYCfMrsImiaf6nMNlsm8anh1y d0aqMJzlg8ApXeeGyQj7SO6756X9Kel/Wjp1h9RPRwVYqacangD0utuFxeBVb6NLOmnwaYGVFE1r KiBrdTTu0lcgZhUyNqLgAj7fZenPGl4GKzopjEmYsrh8+WKhxLmHcwn/AOF5Qw916a5O97aQueXD 40muj14c0ZqonIxUFRX1QZDfU82Fl97h3huz3idIJ6fDp6iJ41AtBOy+Hw3F6nDa+ndGyxY8OP8A dbdfBp1DwnOOGU0NXHCwtpwAxzBubLzxlydptxizVxV9B834Yx2vAqkvA3cIivisQw+swqoNLXUk kUt7WfGQV+grPmKZZyXhTKvEcPpnU0jg0/y2/wDwuu+oPhu6d9Z8pOr4cCo6Wqmj1wVkUYa6/Ymy +lGKkk30fIeqlCTVGm7AuhWZ8zQsdh9B+q1i4a0G6mY/Dl1CypSvrKnKlU6JouXRxF1h77LcL0B8 PmF9Icvyz4o+KoljJcZXfa1o/K5TBPEP05zhm+synHV0grg0tYx4baUcWC7LHCNqrMPWOXKNHWS8 h12cMWOHQMMVc52nyXgh1+OCu36vwW9TcPo3TR4LLPEW6gWgnZepvGb04yj0e6h5bzDl2l/SYtUz iSaNmzTc+y979G8z0udOnWD1zWMc50AbICBsQN15smOMXaO0dXKqZoFzPkXNHTictzDgdXRRvNmy SRkNKwqPEDU0picwNAOxWwr6qmf4aE4Zl+OigY43c1wYASFruoSGsYP925XPPh8aUv09WnzLL0cp C2IsuXAMHJKxampjmY6OOQsYw3DvdDLCHVUbCT5Xe3dd5dE/DPD1fldHHVmF/AZe1154Wz1yltVn R8dTBXRBjm3e3+qyZHGYwGgkjsvX+P8A0xc8YfCZ8JqRUMtqa0915tzh0szVkHMjsDx3D5aatabN Lm7O+V61il6PL8iPs+s6NdC63qxXspsPLDUEgaXDbddl9RPp2dUcCoZMToMPZVsjbrLYjvb8L63w g9Pc5YZisEuE0UjpTI17phcBrVtZaZDl+09/OFPZ9/fTuuri8VHinmtuj86bstVkONyUOJxupaqK Ty5GHkG9iF65yP8AToxnP2VKXF8KxB4mqIw9rew2XwfUrIVVjnWvHjHC50j65+lrRz6ls/8ACFlr OWV8h0dPjzRFQ6NULHffbtstZcXj5Li1CyxtGonrt4bc8eH2drsw0b5KBx0ioA9K6rpMRjrnMZA0 gW7Lbn9Vd4/9B42lrSH1AbcjfdaeqGSWhpGCGMF5NifYLnPHWNZP07Yc/km4/hnVUhpZyANROxC5 fK2CtxbEoo5iNT3DYngLApWNlqo2Ea5ZOB8r0H0T8OON5vxaKWCnk8ySwBtsL91wit3B6py2qz0V kf6cNF1HyZTYlRYqyF08YIeeA63wvNXiX8Fua/DjTsxatqoqzC5JNDXsPK24+HrppjHTfIdFhmIV XmSRi5BFl0l9STLM+bcl4BhNOHOknqRZg7r14Ypz2M+RPNOP3Xo07vc9zm6Xm/Omyy2mV4BaRcD7 SVtE6cfTVwXF8q0OIYxVCmqZ4w58QbwLLMzV9LbLlZSF+DVxFT8usFJYoW05HtjrLStGq7z3U7He f/K9rb3SKerMxN2ktHey2nZQ+mLgVZhFVT4xOIq0XaHtGqx7FdEUHglp8meIugyPilaKmgrRqZIB awWfBb2pnWOsg+zxZBUfqagQtBaHbbr2N4NvDzlbrI+qoMTs2WEXdK82Xd3iD+m5lvLWSa3M+BVs jKvD2mUwBmz2hP8Apz5Bpqyjxeb9UIqtjwHQtPqsCqsMa33wZy5+PqdbeK36cmA9Msm4jmvCcckj FOwvFO9w9X4XgGhpZaymbIxjiQbflbjPqIZSxbFOmlNX/rXxYfTOLJaYbB+3ddPeCbwY5fz9kxmY MwQ+ZBI4iKMCy1PDF4lJM+fj1bU9rRrXZRSRSue974/ba6YWsrdLNDnHjWBut4VZ4MOjsbxST4fS tndsGyvaHFdH9WfpqYTPmChxLKLhBQvkH6mnab7e4Xmjih+ns+TfSNWtLTeSx0bmyOtwbEpUUhhe 9mzPlzbLePlnwUdNst5YjhxHCoal7IwZZJGjm264rHPAx0bz7g0hpMGZDG8FrZqf0m61txMPUuPZ pRa8OjcNbXO9wUtgnc8NZ6vf4XcHi+8NFd4Zs9iKHW7L9a4mle83P4K6oy55sspL22BHt7rnPG4P k9mPLHLG4nc3QPoDX9X8Whhp2O8jUBI4BbR+mvgr6dZFytB/HMLhnqdI8yWXtsvL303MRY3M36EN Gp54K91eIbL+L5oynFhuEzPp3zSAPkYbEBTEtzUUebVzcVf4ea/Ej9PPKeecs1GL9P4I6fGYml7I S4GOb4XXfhI8C9R/HjiOcsObHRwcwluxeO34Xt7ojgGNZZyyzBsUldOyn/5Uzt3Eex919/SPh1yx QNDQy9wB3XreWUE4NWfLi5zW9OkdV434bOmWYcPlwuTCaJgtpLAG62/heEOrH09Mdyr1RoY8r0n8 Ty5XTajPb/73BPDl7AZ02xqr8QUmZG4vKMMabPpdR0f2XoSsdoYHbeW3suspTw1FytNGMeR5LlFU zqLp54e8jdKMmQQV+G0NQ+KPVNPVRtIvbe111x4gvBnkXrnkSXEss4fTYTi7Wump6ikaAJSL+kge 9l2518yJNnrKkEcFc6jET7kB1mvHys3ohkauyPlf9NWVwrWO9cTRuGD2C4UlDyXz+HbfN5Nvr9PK /g98FsOW6+bHs10TQ5rtENHM3ckf1EL0xiuX+meaa+py3V4Ph09a0aZKcQt1LsLBas1rqqR8fllj rW910TljpIXdb6/OkVb5l5CwwCT/AMLUIrJJvqjllnOMVzdniLx4eAym6eQSZyyXF5GDl2qppibi I/HwuivC74UsW8S5roqXEf4bDS7B5bs5bY/G5E5/hwzU5rS54g1aW82utZfhR8YzvDAaun/gJxSj qHDzfLF3NJPuu+3zYfJ/7I6YMksU3hvjs4rxAeCLMnhyqaGerqRitDWvaxssQ2Y4nutiHgk8LeDd N8j0mYcUpWVWM1sYlaZWg+W21x+68qdfvHdhviLwugwPD8MOHxMmbNKydp8zYjutkfRvFRi/SLLd YwDegYAB8NsvNkg4wUvZ6Hkk5U3wY9DnXKWeMYxDLThRVVVBdklJIwEkfha//HD4KKTK+PQZtylR kYbVy2qqUDaJx7t+F7FyV0vy3knPlTmePE2z49Wyua+Fz+ATxZdm9SMCwvMmBw4disgjhlla8bA3 IPC9EZrDkVcpng3TnFtumjyp4E/CXS5PwNmbMy0TH4jKdVLDK2+hvZy9DeJLLeH4n0azJ5lDDIWU rnsswXuAuwoIaaCkgpqaaOCKNoa1oI4HZVmnCqfHct4hh9SNUFRA6N1/YheVzbyqXSPRf+p2z89O BZEGb+pLsJhcYY56gMuPz2WxRn0qsqVeQv1v8ZqqbEP0vnEuHp1abrw/1Qwifo91kxWnwuqbU1NH WukjkYdgL3AXpHBvqHdYqXKLqDEcrvqaWSHyWV7IidLbWv8AOy92f/yVA7aWUpYU5FeBvwz4finX XEoq1ra6lwSS93bh9u62V9UOpmDdH8BpamtHkwPkEMTI2rxf9MXG341mjNlXUuJqqm8l3ixsTxZe tPENQYBWYNh3+oGsdSwziWzz3XkaUs6i1wTLuWJy9jM+ZHwLxG9K5KGrY19PWR6opnNsWOtsVgdB eiWG+HzIM1DE6GaSHU99Wxu5aOy++yNXYNjWVaf+DuYcP0BobGft+Fyoo6epw+aiYRJC5pa4Xvzy FznNq4LqzhGG5KTdujqzp71/wzqRm3E8DZEY46cERvmZYS9iAvIX1LfDHlyHJj85YNRNosRMv84R DS123K9Y5NrciYvnmTC8Khip8Ww55a8R8k3Xx/1DoQ7w74rMLARkEGy9mNbMsYemeOe5xeRvlM0d QQiWhN5dEzTpF19/0X6lUnTXNuFYhW03mwwzgzvtf035XxuF0UklTNAyldVPf6g1rSbLPjo5aqqZ QupfJmJ0hr22N14M0KyOKP0eKe/Gtz7Nrz/qZ5TdgUFHlmgmxapMTWNeW2DHW7j4K7t8LGeM+9Qs GxDFs4Uho4JH6qMEadTD3sV5b8B3gmp30tNnDNdIGUoIfT0bm2Eh9yPZekvEr4qME6G4YcDwiOOf MD4tMMDBZkIta5t3+F0xwteOKtny9RUJKblSR0H9V7H8ov6cR4fVuilzA1wMQBBe261K0VGWU0Rc TrkF/wBl2v4j8/Yv1Bx+bEsZfWOrZXl5bUNIFj7X7LqymrBUPYLEtY3t2XXUfWKh+HfQ8xlJvtjI /wCSXM73T/1fks3aSPhDaO2ppF0+BzSDqAt8r5p9VixOJALAi/Ypmggb9+ycWxtaCQEt8lyCOEFl DYcIdZva1gmax/dTSNzZBRbHnYnhG1hc4E/akatG39k2OQttugoYWBoRiNj4791QksDcXQOfp3Ow QUQMc0XHZWWukA1IXa9YI+1PBsLWQgN9reyjZASRa3yqvfcbq22cdghogd9ykd7cKxYblpCYW3F2 2urQBNyEUTiOVTNvuCYWte24NioKI1wdfUbKBvqt2KDygd7pgLmgC2yAJp8s6Rwku9cmq3CJxJRM F27oCzvwl31SWJuPhMPPKGMAyEICy06dhcBLLNR2Vy1RhkDWi9+ULQTv3KAYCdNkPDijc02G6Ga7 QAOUALWm9+yCZxDhYbJkWw3RE6thZABtYHurfuBbdUyPUTfZU93k7XuCgK0anC6c1wB0pTWkm90T RZ1yhoXUfYbGykRIh33Kt/raQPdBYt29kIw4nfuj2H5SvtAI7og9rdihAiNThbmyhu037d0JdY3A RGW7DdARtgL3t8p8LnOeDf0cLBeLgAusFkwHYN7e6jKjk4pPLNib3WTGdY3Flx0PpcXE3smGqL3+ kfsuTRtHLU59PNgFll2pt1xdO47dgnl7i0i9guTRuxs7ntGsA2WRC/XEHWuliZvlCNwvccqqTVGC CQG+ywUcXbC/KkzDpFkyRjdnXF0uSW1r7BALa97bXKZNJbQDz7IHSatglm75webBAG+Ql4HZOkku ywKxgy8lysiOVsZu4boCwBYJZbeS9k172yXLeyW09yEBZ9RShdr7cJ1+EL2+q97FWgR/rADlGtaD a6rXfkXshDi47hAE0lziOyu1hbsrA4QO1athcIC7bWQ6STsmO2F0g3LtuFbBbr35VtBA34VuANlQ Y7VzYKMlgse0PLe6snmyIwtDtXJVCwFrWUHZdO0N1XO5QlhIO6ZZobsUbGNePZVhGO27RuiLvdPc xtxulPsTYDhQUUHcK3s1nY2Qjdys7n2VKgi4EbjhWHei52QfZY+yvzGk3tYKAU86n2QOi03sdyhl cWzahcgonOLhe9ltAxphZhB/usCRoeLErPqGeYLE7LjKghgJ7BbRykYcrzG6zQSFjVlMGubIXbns swVTXMc3TuViMpi3U6V197gLqjiKZJd3Fkx8YHqHPuqc1gvvYqm/zAQDwtlIXCNu5uFbXbiwsClS ROdayy2gCns8XKFQD2kKjpa5u37q3v1WVWubnsgYc7i6O7P8IadokjOv7lGu0cBWADc3shCm3bcd lYbdpJVEX3ur3cAgBD9JsBsicb9lbm2Cu1rXCAAuc4bhC3bkJ0lr7f2QB3NwgL1EbIANzuiKokHh AQgk/CmkhwPKmpQvQFvAdztZUGAknVYIXsda4NwgcySQDTwgHOYAwkFKZqcbOAIKLcNDVTR7IAPL 9JACryiyPuCmmTyyDZFI4zNBQGM2mfbWeFQf5gLewWTL9oF9vZY/l21adkAhgDbiyIXv8eyMNIaQ RukOa4DlaIy9V7qgboXDTbe90Jk0kAgm6EsJ4DuUmQaiA29weVkEAi/CrQ3VdpFyhBkVUGmzhsFU 8zJTdvKS5oDir0NG/BQBeXcXvYqngaQO/uieSG8XVC6ABjQ4nUEwwsaAUDnniyslx5sAgLDW3Kpj PWh1B359kbT3UoFuOhpJ4QyEPZqZZpCLU2RpBWLIxziA3YAqgyRUAM9Yu5KZeQm23wmuY0tBtuOy q4b6uCp7AvywwEhu6pw9BunmxsgkAsbhKAhptseE5oAFiUuQjS0WUDzb3QDHtDgEt1m7XRai4Cws Qqda13cogCSCLDlX6g24G6FoaSdKIzGSPSwWI7qgyaZz3sva1kbmB5Juk0tS6KMsIvfuoJiHgFAP Di0gDhUfUbgKNcAbIwy52KM0gWNsb8/CMtLiA02CTJdt91XmP0xlgvc7lZKZgj0NtfdR8mhtgLpj 7Aix3slFupwBWaBcTtfI4Rz6yz+XyEo3YSG7q2vDmEOJaVAMbNoYA77jyglZYhxPKqOMWN/Uq1m+ k8dkLQZZdg3uFRpi/nhWCGn3RayeOEFCyC0BqPSL2SyXa9xb5Vk3sTe4QgwaeChdc7AWCjSDzyoJ CeENA20jcXRBuqwUeSHA8qOeWEHuryChA5p2OyhtYgofNe52/fuituPdLMkdZrARuPZQXcRbZM5F lGtDt+LIB0MDQCX+pLncy+2yN82ltlhTu8wGwIIVsDGPGrlNduVhQG25/wArMY4OCAS+Q6w0/wB0 LJHa9NtvdFMz1A9kUZsQFGCFoDt1RFhso8nzAbbBVJZ7SbWUBRBJsN1HNOjndUwi1tSsk6g3ge6A BvpPN0wE6uVbWjX7o3MB7oBTpNAN90DCCLhU4DcHcqNG2+yAtlw/buj8kOeT3UFmuBtsnWvuEKhe nSApe/yhqHkiwSIg9hu7hCjtzIPZHK2xFkDLmT4KdLGRZ3ZCITa+6IOBbYFW5gc3YoQzR3QoJuBt ui1SBt7JjGgjfhX543bbZDIkDUSe6toULgTcbIGuu5x7IBhBLrDdR4JbYlSIBztjuilYY3XJ2KAC MWabKvuO+yMuDbWsFHlpsQVQLjc9jzvcKnOLnfCJx3uDZDu4qAENO+6mhzXtsbhE0NDbF26Y22nn ZAL8wF13cKMHmPJHCIsB7KElv22CAuM6Sb8+yBztZO6IgNbqPKWbOBKAIeke4Qi4b+VABYC9kZb2 BuAgGxi7bnlK8z+YbpljYAcoHadxwfdAU1xc4i2yjiQ4eygdpF+6l9QuQrRpBOIBv3Qs9RPZQK2m zuLhKMsB7Dq5S3NJeADsnPd/N32UDLn2+VAL0nXa1wjcwA7lWxu+r2UJvu4K2ASAQEJe4ODRuERt /SrcbAbbpYBsGXKW51yDuU24IsVAG2t2VsFRkkXUcCRyobMG3CmoFAWbge6ovFrlFqsEBueUoFte DYqydwBulkWNuEQaWqAI31K9ILvlA1xc/dGObhGCwS0+9lbX37JYkJdwrJIv3CAYHAgkcDlLL9R2 4VknQR2Kpgv2UATfSLBQPa0EW3KGQlvYqm+ooAmAtBR69rd1XDVRKFsRLEL7nlMgBZ+FHsFgTuFA NBv2QoznlS4HG6oHU24QkfstIFl1ydOxUZYix590FnNsAiDdO4N1GSi5nhpGyokOIKCQGR26YANh fdVFKAI3U3KJ4I2sgBN7cKgK5QjY/KpzuQqMt7ABAMc42JbuQhLfOb6tihaC1M0lvqvsgFMZZ1gL /lGX6diFHytAJ7pQJcblRAtr2tk+EwuId8JTr3AARi4G6oCDg7Y7IhpDdzshcWhovskPu8DTuEA6 Swb6SlAOJ9lYbxvdM2aL3uoCo7hpB5VAkC5RB+wIVPN0Ace42SqqzI9zwoWkb33RR6SbSi4PulAG naJIu+/dDHTOebA+lG+TQLNFh2T6d2qwOwsowIMRZZqJrnB9hwqneWvIVB2obbFEB0seoguNyoXB rUDXkGz90ThdwtsPlGRCmu1u3HCPTfjf8q9Ol2+6EE6z7IilaQRbhCGaXc8ozY91egLQKLdPypuA iPA2UJB7KAG1yLhWSQ73CjrX5Q6bkkFUBG5YdljSbW1LKcAGCxsseRzXCxN1GA4z6RZW5t91G2DA oCXGwURGQAAb8JjbSD09konUbPVhzYh6VSmRqLY7WSzfUPdAZSW3G3whkmIF2bPUsBSAiQXFrpsD BqdcLBjnkMv8/YrKjqgHaQFCMyHMGg3WI9wbURtI9HdW95LrX3Q21G3dVEI6JrC8t3F+EBPp55TS QGm5ShpDDY3WgLlpwyDW47EpToi7SOx7o7Oe4B323T3Rh2w47IESSB3pbq9KNzNDQ0BCNTW37BWJ dViVC0C6OzhblCQdR7fCJ9QGytaRe6J/lxTN1P0h3cqDo4+aQvfpAsQmhmhgcfUnSRxSOJjcCP8A uo2AnvslCxRO4I4Tg++42Qy05iLXX9PsrbfULN2REQx0vo3CBhDxso++kl39ksAgbFU0Mks1tr/s gDtOwVuF7b3V7B+6lmQdTrmxu5BTF4c90vpJTWt0OLgqkb5lyTurYAjIEpKItaXaid/ygibY3cje Rtv/AHSwU5mgb7koLkdyEZAPe6Ac+rhZAWgWJ7IYiCSXcAJl7Agg6Utr9MbiOflADDVsle5vsie4 X23SKeBrHucdy5ZbIDcaeENFsZ5o22KJ40M0tG/urdGY2Fzfu9kD5nEDay0yUBpIADjclFcWsULi dQVPbfcLJArguDRayssteyTGwiTUSjDtzcqtAJjbE3Kkji1pssecuLgQbBLljlfYhyIGbFFLoJ9t 1jMcZXOJ7JjK+ZtIYn7EbAhIovVGWl1nXuVbBkOJt+FGtcHXZweUoyHXYJ0U5aCHBZAR9T/whY3S 4kdyrJAI7XSpNQdZputUB7XnVa2yotDid7KRSkggjdKeLHdASTZp4KVEfSboo3BziDuD7qv/AHbN +1RAJrw4kEXVFxa7YXCFp9fwmANa7c3BVAP3k9ghnLbWH3orWuQNkmpcSLt5QC3EnZ3KAwuG43Cv QbanI2uPHIVBTfQLHhRzTbhW5wuo4m6jMA+ygf2uob7IX8hU2WG6hzurF2DdLJsQEb27coCCYaTf YovPBFj/AHSTGTt7qmxWFu4QDHOsb8oTMb7qxC4gkqtJaLHhAG023IVTQiZo9WlCL23CN+7QOyAl I1sJLeXe6pwaJGttZzlcWzgrka0TskO5ahLKMD4ZC4lLlcXnYp85dPYg8pDIwNid0KKJLTs391Gg klx7J7m6hb2VadTQ23HdSiMuOXRawTpJQI9huUpx9IFrFSNzdVn7hUBiVobp4JUDQ42tZAWtEt+Q ilfY+lCgBov8go2BoG5sSqeSyO7QCo1hkDXEWKAsxXdZCyXyn2smkbek3KUQTuRuFAPINw+1roZN xsEsyH8qjNawPCoJydkTfndDE1znen7SmbA6SoAeHXVmyt3CUW8hUBCJr3lE2AAmyqO97cJ7Rvxu gMWRgBO+6Bj7A7p0oH7lY4js/wCFAZAJe210Gox7comgDcFCPuKoCDy4XGyHzHIgCB+VTb3QAiR2 uxCbYgXQhwc/cJhIDOVmwLMo4AuULC7UQQjaGg3G6FxcX/lQDWXBvf8AZAA7UborhvG6vUEBGm3K haCBbZUHi/wrJBIsgI0C/Kp1id+FWiz73VOOoEIAhb8qj3VtbZguqBF1qwRhAPFkwtuELACUbjYb KMCpGaQSChguAdR5Vvdxui0tJACgKde6HZZD4tIvdJNhygZ9rOPLJuEuMB4KZVO1C4S4XbWXmR6m uSPDXEgmwCAsDY9QKIxAu3P7LGmEgfYm4v2UJZn0Li43F7+6zQHMG26x6KPy2A25WVK7yma3Hb2U KR51M+UvdrdtiijdYauxVH1EngKAoEn4+VUsYfa1ronbDlDulgxZYtPKw6oljLcA91mTm5IKx6ph kpb8kJyZfJ6A8ILmfxyRjxve9z3W27opR00mXxNG1urRYW91p28OGaaTAMepzUEMa4gE3stvfh6q oqjLTJoZg+J41CxX1NNdM+Tq7jE16eM/qrmg9c24U6sfAyilvGxpsCOy90eDfrQM75DpaHEJP+Op gGEE7rxV428k1UPiEdjc1NI3DZg0Mla24Ll6i8E2QBE2TGJmFjHgCNp7j3X0tS3xH0fK0kbjJyfs 9S4ll3BsNrKjHn0cUdRBGXulawAkAX3XgTNXWys6h9fMNrqapfFSQVohia11hpBtwtheJYhhtc+T DpKiJ75WlromuBNivAXV7oTN006uU9fRU5/hFTUCSOQcMcTurpZJp7+znmTUqXR7Y6i5Eh6mZBOC zTmmZNG1xlbyNl5LxWXMPhfzFHQYfijpsNqNmsfJqBN/Zeos7V+KQdGKmpoHObiP6MCN7Nze3ZeM 8pdK8+9bcQp341LKIKZ9zPICO666dfSSb4M5U3NM9y9OczDFcg0mMYhO0Oe3XK/s1c3STYRmhjay jnjrPLO0kZ4K+MytlebDum1dgFR6zFE5oeO+y80eHLqJi+FdW63K8FUX4ex7myROPBvzuvKsEm5O L6PU8iSUWgfqkQSnpjgrWDW11TZw72XVPgXx6uo6ymwkVb20YlaRFq2+V6K+oXgceM9Ho5ybyQTh wA7hef8Awi5Mq/4hRV0EbxG3S53be66JXhRjE1Kco0ewPGHQw1nh/wA0eZEJSyldIAd9wFoawSdk UlXK9uprJCWgre/4pM1Ybg3R/FhiUzIqeSkc13mHk6dgFolieJ6uvbDF/JdMXN+G3K4Zlt06T/T1 aRuWdr0cpSTirrIJpG6BcbLYL4IK2KPGMPcfTGHhnOxXgKOnEz6cggAECwXvnwnYDKyHCJKcEl0z Tt7r5+Phpn180fqbAuq+D5cxjJ0rcyzNp8Mba8rjbSV1fN4hOn+QMuUeX8FxIYpK0COOFrrn9yvt vEDkqqzz0exbCoXuiqRTeY3R3c0XstOWXMyV+R+p7P44ZC+kqNJ134B+V9bE4eNb376PzWRSllqK N0eKRjMnTGtDmmFtTRPfZvIu260UZtrMw4T1Mxavwid9NiFDVObFOx5BFnLeh0jzphHVDptSVGGV EcrJKfyZGsNy24sbrySPAfJRdWa2skgbV4DVTuncZBcm/ZdMGSL3JmXjWGSc0a9qjq1mzqNmjDJM 24o7EpqZ4063HYBbf/BzUGo6aU7dYc3nY8Lyr40PDTkfppheE12XqOPDMTkLWyG//M33sF6u8G2A T4P0to3VFwZGjTcWuuGSKUXJHuezIltR4e+rXgkgz9gFcAfJMFr9rrwfQU8kzwL2AF7ra59ULpHi OdcgU+M4XH51RhxL3xtFyWrU5gk0jml5uHRkte09k1XOGBf8dK5yT9H0NBSmslgpgfW94HHytiXh G6LZgw0U+MYfGZPNbo0kbD5WvLAagxYzTTXADXB2/wCVt48C3VLDMZyqMPkqY2VUbQ0N1DcL5mOW xo+tlTo9LZbEuB0FPQ4hWxOrX3LWE2J+AugPGt08wjGcIwbEJaSJlc6pEZqA0arG112ln/JOI4t1 By9jlG57oKJ13hjtv7I+vWT588ZJfT0zGPqonCZgftpA5X08b2TjO+z4E5XGSfYjp3g+E9LelTK+ CBjRFTiR8lt3WC+i6fZ4puo+WnVkAsH6mkBY+CUVPm3plDhL5I3O/TCCYRm9nAWKxOjuQndNMBqc PlnbIHSl0eqwsD2WZNSUpPuyprheqOjOivRvCcW6yZqxLEIGTGgqT5bXDcm/JXdmJ9WRhXUfD8qR 0vlidv3u2AHwvmcBhZ016uYpLXVEFLhWNfzWzySAAv8AbdfS5tyEzMufMIzPR1tKP0bNNtQIcPe4 XWclOf8As6o5R+sLgdJ/UqwNmM+HytqCL/pJWyHbstNWHvjdSvde5aSQt/nXvJVF1K6UY3gcz45R PTuBLHA2NuVoTzrkupyDnLFMJqHgsp5S0WP9KzKSeBJ+j06PjO0/ZnZFibUY1T1T4w5jZA3dbsPC 1k6ijydhGJNgjuIG2cAN9lpNylicdJ/MjYTEDq/dbY/Ax4m8sY1kyiy7iOIQ0WIxjQwTvDRt8lfP 6fB9vND62d+4j1Qq4OsNLlbyLU7o9Rd7r4zxURPdi2UqgsvAKoM1dhcrsLFsqYDWZwhzUcVgZNCz TrZM21v7rguseMZRzPllvm5iw5rqKVs8Y89pJc39174ShGcGj8/kU3CSZ9xmHH6LJ+So66tJFPDC HO0+1l0dhvjq6bQVElPasjc0lry2IuF199lvqfknqzlB+GTYpSSufEYZoi8Ai21wV8dl7oh0kyJL PLU4lh1QXkvIrJYypFQpqfdnObnvi4fh2f046t4F1RY6bAnvkgG7i9mkry94jKXEqbxZ5LrqOCR1 KCxskrQR+Qvmazxm5H6JdWpcKy7DDV4I+Ty6qSnNmNN+W29l6fwzq70p6jxUWONx/DTJFZ8f6iRr XtPtYrqqwZNy6aKozar3Z9d1fdC/pVjwnLRGaB/3e+la9/AVjddhvVmUU+owVE74ZG9iL8r7/wAd fjUwjBcAdlLLdXFWy1fpmlheHAN9tl8N9PDPOTcEqqiuzHjlLSYi4kxsncGjc/KkXHHgcX2zrGM8 mbcukeu/HDhlVi/Q+vipWF4jka+QAX2SPBBilPXdFaOnpwAaWV0bwPdfWdUerPTiryRikOL5ow4U U8DmuLJ2uPHb5Xi3wt+MbJHSLNWMZTxCpf8AwepqC+nrSfTudliLT07hXNmJRlLUbvRwPjvxTPGE dc5K7CsQrqSl8trYGRX0E25Fl9t4Xs+9eXZuy9TZhZUVmWpnjXNIwglq9C5u6ydBs0VlBi2O45hc 1RTbwiSQEgfIXwfXDx89OMl5QjdlHG6XEa6OQAQU7fsavQ8kZQUdvJ5ceLJCbbZ6g6qZ0bkLIGLY 86idXijgMn6YC5fYcLydln6gdfmTBXTYJ0yxN7WAgtiadLT+bL6PIv1Auk/UDK8UeY6xuHyOjDZo 6pvodtuuZpfFz0FyfhE4wXH8MhiFyIIWgaj7Ly4vHBOM42zvn8zncXwazPG31pzZ1dzXhwzNhU2F UdK8mKB4Ngui8NrnmuYWM/kk8hd5eNjxC4V1yzfowWkiio4HAmeJoAdbuujY6hjKSMRWaWtGw7lM 0oydI+toeI0e0fp95yocA6y0NLVzMhE+zHOPdbROsX8Sf08xU4IwS4oY7wAdyvz94FmeuwOrp8So qiSlrKd2tj2mxuFsJ8PX1R6KjwOHCc8s1VFO3SKgmxeBwvKvq1JejvqVuR7U8N2KZpxLIokzXGYK 9jyzS/7re5X3OFZmwKuxmuwzD8QhmxSIapoGPu5vyvDnVj6pORjljEqHLEFQcUnhcyOYizWuI5Xi Dpz4p855AzwzNVPiEr53Sl8wkcSJmE30lehxWS5N02fKhuSUYqzapiGWM/4X1RnpsMmEuG1DxUOl c70tbfcLuvNWYsHy7gtM/HcVgwqJ5a3zZpAwOd7XK8Q5Z+rVkWqpo/43g1VR1jW2e6NuoE2XkXxS +MPEOv2Y3fozNFgNO+9NTklvHBWn/sS38JE2TxtqKuzbt1cy/imfem0+H5WrmMqZmAw1TXjSR2Nw kdDsEzHlDIcVHm2rE9fBcSTE7aR8rW54bfqX1PSXBGZfznSz4jh8Xppp4jqe3/p/C+n64/VTZmzL NdguUcJkpm1kRjdVyus5oI3spFNrYuhLHNS3u7NiWVuqOWM25ixDBcJroZ6mmF5CxwOv3AXU+NdL s50XWVlfhGIy0+WHOEr2uJuT3H4Wofpn4kM0dM84U2P0lVMZYX6nAu2c0m5B917Vpvq/01PhMfnZ dNXWBlnNF2AuRN4pVB3Z0ljlKNzR628YufcFyV0SxlmLVMbX1cBhiied3uI9lr5+nL0ry71QzljM 2YaeCqpWSOc2Gd4AdvtYLpHxH+KPH/EtmFtbXudQUEZvFRNeSxgXU+FZ2zDkutbV5cxepw2VvJhc QHfmyssvjgoQf/JvTYZOUptG2Hxo+FzIeUumz805dw2mwisoSPNfEQBIz/5XbHge6zZb6j9IMKwv DK2N9fhsflS05NnWH9QHstMWbPEd1Uz1gzsFxzMVVW4c/YxvcbI+knWXMvRPH6XF8Cq5IaiG12Rk hsg9iFxcm4KMmerxPlo3X1nh5qv/AFtOdYsTe6je4ONCHWa0+64PxxdYsJ6ZdLKyF9YyDHqqPTRA H1sd/uC8Ww/V8zZJgvkHK8LcS0afP30g+9l5K6u9cM49csyuxrMFW+WYn0RcNa32AXoWSnF5H0fM eFqUoxX8j1L4UuqPVbqXn3DMIdmOeup3HVIXv4F1tVxWhxA5OdRROJrzDo8xw/qstDXSrxB5g6K4 pDXYTTCOpZw8Bd+f/nceqMEbYZMGoZI28SaLOd+SuU8qyTTR7p6dxx7V+HX3XzKMuQPEzPTZpkaY qqdsjtv6Se62ydMK7pbiHTLCo6eTAailjowHtJj29O97rR11z63434guoBzZjkQp6l7RH5cWwAHs vlIq/MeF0+igxmtpqRwtobKbW/umfLLJJWXBjlHHRsFyT14yt4dPFDXz0NRHPlvEKkxSxU7vTCCf u/ZbD84ZSy/12yhSzw1oqKGoaJIZ4XAgghfnrglqGsfLUPfUSP5eXb3/ACu6ek/jE6s9GsKbh2AY sZsJBuKapOrT+PZZTaaknyMuNzi4s3QQf6Z8OnT6d+IYmykw2Bhd5k77OcbcD3Xwvh48YWQetuIY lhWETOw6vhkLA2rIb53y1afOrvib6jdZJ2HM2IzVMI2ZAHERs/ZfFYXmfMWUq2LEMHq5Iagb64zY /wCFqVNNyfJwx4Mikq4SN92WOhuD5T6iVmbaNzXVFXfWL9z3Xjz6mniSwh2AS9PaCpbLWAiSqLDc N9mrw5/92n1ogpW0sGZayliLdJDH8hdW45jOLZtxqbFMcqJqytqjd8rze6648ii1kk7o4S0uTI3j qkzYv9Njo1k7NmGVeMYzR0uIVJaAxsxBI/Zfe+OPoN08yZQZezBheEwYZiTKsFxi2Ejb73WrbL3U fOPTqs8zK+YqvDn86IXkBZ+c+uvVDqZTwxZizHUYjHDswyvvZcXJznuZ9HwyilFejfv0srqLG+le Dfw2aENlpGgCJ49Jt8LrFvhFyziueZc0ZolOL1Qfrijld6G79/daVMv9bOp+S4Wx4LnHEqBjL2ji nIAXP/8A3U3WiugdFPnbEXRdwZStY3KLdOjz6jTPJSkjZh9RfpZkePohWYnBQYZS4jSNtHJCGteb cDblaZKGQxxuLSBudl9tmXqHnPOkbocdzJW4jTHmKaYuH9l83R0UL7sGz2DYLjlyNqm7PVpsXjJJ TCgha9ztRkFwEyna+Rgc47JU7zJZhAJbssuJwDQOBZeY9rDYLjc8KXt2U44Ubcm3ZAIdMA8rKjOp nKxnRh8zWj3XIShrGEWshUYhuf2VsjLt1bW+ndObK0ssBYoEQWaBqNwlzgEAIrXbbkpkbWFhDrX+ UKXEQyMBW6XfhABcc/hUwFrrONkJyOjOo7IgzQ+90prtLrBMEgLveyFJUuMpaB2RAG1hyhPPwrcd I5QBtvbcIW2DiisQy5PKqP08i5VYDBOwsnFwYBq2StZ5IsVbiHDdKADj6iVTTsjaRuHDZBuXWtYK AJzS8gX7JWnQPlZAGm+yAtN0AvSOSEWktAKvSexVhlxv/ZAAXPc+/bhEGB5sSbhXY3FhsiDg0kON iUAD2ho2Kx2P0yXN7Jz4S06gbhLkcCRbcIBusSD0bFU0x6SJTv2So5gNgN00w+c8Hj4QAxP1X22C dq9PCU5mlxbwmRusOUAAFjcqgLk97o5EBBZsEKi2xEWPt2Uexr7O4siY/S03Qm26EBDXXItsgs4X Ca5x07JRf5Zu7e6AjYifv3HYLIjeOwWNHIfM9V7H3WTBZxcBwEKjLjaCOdvlMgjDHFyRqDQ0JzpQ BsOFllszYHNeLcEpmkscLm649k93t07FZjZLnc7rm0bTMnTZ1+VUklnXvsOyWZ9O10B33uudGrGO qXueNJ29k0SeYdLjuEhkPcovLDQXX3WaKZDSVY/lHUe6RFOTfi6c93mMHspRLDdIbX2UEjXW1WHy kyjSB7LHc65VFmY6WwOmxCOJzX+kndYsZNhbuiNO5rw7VulFszi3SRvcBA94byEvzHNHKRNUFztw lgyWOCsOubLFZMBunMlAdxZQD28kFKI0uNtk64IvbdKkOxI5VAOo8EfuVGk88hTcqEFqlAImx4UP qHsVOUVgPyoShYLhcKFpHfdRz97Izpv3QqCgaO+6ZIbH07JesAjeyBzv8oApZLN23KDWTaw3ULQ/ Ycoz6G2/qQC9J/dU52/yrBJBupbclADrPdUbv9I2Vu9lCLd1UBT43A7obFoN9k4bnlBUaImE2Lnd ltGezFLrAl26wXRtJN+Cmtq2T3YQWuHYrGkfu4DhbXZzZjTMa15dawWJM+7xd2yfWMfLGQwrj3Mt pLuWrqjmXIw6geybG3ULjZVC0SFxPdN8rQLg7LQJvtY2Vh40Fp5Sy43BCs+nd3KAppJ2R7gKrhu9 lGuMruLBARjST7hRzdJPe6IN0hW0AjflAAGkjZGwFvCnwFVyLoA23O5VvGtm2yxhI+53VtmI2PCA cBfvdCLG9juhDtLb83UaNIv7oC928q7A8HlCDfkImgdkAktIkAOzb7lZU0cd7sOyWd791TneoDhA Rr3XtbZR/oPNkyR9mgDlLlYS2/f2QAF+tx7BGBp3ASGtI3RurpWDRHHc97hAXIy7L34SGSObcXTZ HWb/ANR3IWODv6kA+xFjff2VTBw3AVtB+4nZG8EtvyEBhvldGLuFysaerMkelrSHE2usxzbtsd/l JkexnIFx2VRGCymLANTr3FyjewIoyJDqJ/ZDIT5gFtlTJTBY78Inwxh4cAQSqlNgqY/Ud97IBbnC N++9kMkwmkGk2srkAc4k7FKjgDCXG90BmbFgN90BAsN0BtYWKsEFwB/ugIQByd1TLvJBOyNwsNhf 8qmjSD2KApoEZta5KpxIfYFGz1XPdAxrgdTkATxZtj3Smt099kwguKprQAQeQgDYAUEzO/DUQ2aL e6KYkt08oBTD7duyFztTrEq4/S6yMtbr35QC3jVuOyCJ/N09zQGkApAY652NlGBrHbbqn20XP9lT b/so8GwI/sqBUd27jv2TQS2+kK2htxcKpRoeAFAFfa9t1Qve5UF9O6H7Rv3VAZcS8H/CyGyu0+lq xGOIeDf9llRMN7k2/CyC3tLmG45TYWCONrbWVX52Rsdq3IQ0Xwfcqi6535Rg+26jQCbqMovU6I37 +6t8Uk7tQ/dXI3zO9ims9ERAG6iNUF5OkDTwlPY69ymRvNtyqlm0j3VAANnK/wAIA/UbnumNs0g8 rILPqbvskSB4cC0ek+6yHDUSe6jzaKzhxwhLE6X3+EbYyRa6Fgu7c7Kw7RJs7ZClujEJbqN7opLN 5Fwie0VMTtJ9SQXamhp5bygGHS8bbK2MAaAeUFwBZGDtsQhC3G+xCE+kbKAEoow4k32VoUIe5zih a11t90bwQ4/91C4MaLlGQBzBcWH9kxji0WCRM9wFxYBXFqcy91AZEkmqwVNIFiUsnY3VtFxsUA0v 0tva4WPNIXbN2Cbclum+5Siwk7jYIBEjDcFZR1TMAGx90sFwkFxcLIbIC47W/CAxvIqY3X1hwTGz aT6uUwy7oXxBzg4IAY2B0hNtlclOWnWT6SjMzWggfcVbZi8aHBAK1E2sE0vOkW2SWktkLU5ouDdD Vi3c35sraC/kWRhliCRsmTBotbZAYz/QRbcoSHzu547I3GxCskNNgbK0CbjbiyrTfclUB6t3Ky4N 2UM2UXOjcN9k020Xslh4df3S9Tr2JuB2QBSEabhDHfVflVcucAftCPZv4QDC/S3YW/CmsyDccIQb 27/KYONkApw3RMjGxJUcNuFbhZvZAKncC+zRsozYEKtIvcG6q+jc7qsF6GtGondWXjTv/hLdub32 R2BaFAWxxdx2VD1OsN1bBpJCuxvtyrwCPu5oukl1jZNkcQfVylAESAnhQBupppYdUQ3HZWxj2s9Q s7uqdJIx14yQExjnObclAGDpaEmTlMDg1hJ3CGwcwFBQFgQiFwOVYZwoW78oCH1mw3PCgc6DZ43S 5PUwlhsQrY17wC7coAnESEm1rKtR02B/dE7YKjcccFAUz0gknlS97BC69t9kUYFwewQtEa25IuoN tihlcA6zfuVNcdW+yECuNSq9judk1jWNaSeUAaHg3CAB7dW4crYxxHCKOEgknYI7hvBVALm6B6t0 BcTwrdI51z2S2P1A/CgDAJG6PYD5WKJXueW2JHusiOMkAk2QAjYkomOJuo697W2VgEcIWiju66sF WxtgSRdWWA/F0IDy1RpI4R6LDlX5W+x3QAEk3QtYde+ytw0b33RCQPAvygIQT3Utcbqa97dlWr17 cIaRVrGx3CBouT8Jv/ZWAB8ISwLFvdERwbqPc1h9wlB2p23C0ihSOBsOCgjY4Ekm47JhF9+4RA3H FlGQqwdf4SbOabpju54QkXHdLFku8kclG7YD3VMnGzbcJjrO45VsCiCiaGixKqQu+3hVe1ha590s pHkh1xwo992ht1LG9lA0A+6WLAcwEC3ZG1tuVGgIigKJ/wBvuo69r23UZ6Wm43Sw9znEW2VAenU2 xO6otEVrIzs3Y7oWt1D1coCBrew5VvaGxm+yoOs4A8In6S219kAgPLG7C6YQTY2uq17aRuiiF9ib KAt0YaQgB1PIPCddhBAcDZKd6N+VGCFoJ/CNjD2QCS7CSFGvNtrqAj2nUSVGB1r2R3FrE3Ko/wDL NkALXHVcjZMbIb7hJje4A+yJhLjvsgCfINSoXFyeFC0FASTt2VQCDr32UvtfcKj6fwrJOkeyoCDy VA5CDt7K7KMFOGp1ybWRMsSqDgbqw0W22ChGBJqLi223usaQjVayy3O1OA7K/IbGdYId8FCmI06r tBsE6EaSdW6K3LtPKDe5v3VQLI1O2KJwB7pcbw0kFECOQr2Cnmx2QlpLr2Vh13cJoIDTusgUWa3b jdAWaZPhOEgHO6GQBwFjZADHuXEbp7SCLjYoGN0NFkwsBZtshGKLdLrEobBNPCU74VCKe0FtgqP8 u26LgfKotDuSlhlXLYnX4O6GLeLWBdqJzHVAdGNjbZE1hp6ZsR5HKgsBlnPLgPUOLp0FNFXtPnuD XjskFxY5parALnufw5CDZKCOmJ0O2S9X+1McHeXc7pbGm+6At0g0OLjuEqOoIAc0XuhliDiTf/Kj WFrbBANfLrF9vwhBvbsiawW7XUsHHndAWGg3JKEt3uppN+bKtQJ0lAG1wsULjfhWwFpO3pVOBANg gKfZpCF0ercHZRpda7gnMax5sTZAY7uEQJABtdNk0AtaAq0kmw3sgDnla5rdrEdgsOVpePSE43c+ 7hwnNtt7IDFijNt+eFkMcWm3+Uzy26rjj2Uexo3v+yFRYdquB/dIkbq2KMWHquqJuboGI8twftvd OZpLS3uqcQASTupAS65A2WkQTpsDbeyYynM7SSbKRxanOIWRCx7HHs2yAwKhwbaMC590UNPIeeFk HQ2XW4XTxdzr22VBivGhp9N0jS37g3ST2XIzXdHsOPZcc9xNgAeVADos4WTg69m90JDhayZ5en1A 7qJACpf5Q35AS4XGaLzQPTdN8hs+rUd7KMlbFEKdg27qgjSR+E3SCNxdBosqDnMkaQNQ7hQAysZE Q4De/CCpPoDmN3+EdRKZZQQ2wHZR93Wa3uiLwLbYQOe42Kpp1U7T3KGqYYI/5m8Z5siEjDE0NFgO LrRBZmLD/wCFPM1DiyW42PF1esXt3QhHEkWugc3082JRadRtwrkaWnfhCCWG9geR3KPWNViUovcN rbe6tmq24Qgxxs4AFATqk0DdULh/wruWS6wgCGgGx5Cs8bqmsa86iblX8EWQpQd6hsjsCLjZKD7O VsI1Ek2Q0Mc4t7XSXSF+5/snfcOUpwLSRyPdCE1W7borgnlACDZU42dYIGMbI3VayNwaCNRsD3SL DSbmxQNc6YWfsBwhke4mM+g3aVNFvV3KkZDWEf2QkHudkNl8ndW1wsQ1C22qwV2AJtsgIdxZA5mq 3ZG33VkhALEgaN0xszDt3QgNaOLlUyITSWA0/KAs291YlcwjuChIDXuYN7Ix6gBdCFl3lEO7FUY3 Odr1en2UebkNO9lbXtLrftZCinNNjbhSONrhe90ySNzT8FAWhoPZAOb6G2aVZAtfkpTLhm26PSRa 6AohVxe/7JiHRd1ygENMrn7jZZbSSy97fKhcBYWQ+Y0+koBMwda9/SlhHNIfM022VCMu3UAxrRa4 IVBvKvyyGj2RH088KghBDVRvpvZGSH8KE+nSgMcEi91etrWHUUwx3CxnR+ohx2WAPjeJWXaNwj1X FtroKYNiBF7hMMbQdV0ADG2cUe5+UAOq6Nuzd0ALmWF+6tu/HKhddpFlGhAFe4IOxQWAcEWn5UsA eUBHEj5CAmzvhG4fKq29gNkAIJsdkbLhWGaShN3AtugBeRv3RRuDRwhAEZsd1Zbq2HCqAb5OxOyS Q4m+6K2++6LXbb/woD7WrjdDAQR+6TQN80utvbdOxGVzmkEoKEFkbiO6866PXJ8ipJASbHcLjzNO 6qbpsRfhZ0kRFzZYcOoVTbbi6GD6WJw0NLmjjsrexr2jVx7IKZzjtp7co3ev9lhmgC63paNlbR2u o52jgXUaNQ1d0BTgHd72Vu2CEki4sgfLfbiyARVNAGw3RMZanLffm6pz9bgLKyQ0OF+yBgxVzsLD ZI3lj2m4IK9X+Frx4P6bVsGEZh1voXWbrJ4XkfzGPLg4XDTeyTI1mJSuH6J5DeHMF17dPk2s8mbG skaZt4z74mejfULKhZitXTMe4BzJJCNQPwuU6N+LDpdlnK1VStx+njbTxODLuFyFpmnwPzjbXO3/ APhuJsqky850ehsjqb5c7Yr6Dy7n9j58NMoKrPfOH+NzAsI6+zY1S11Scvum0vdISRzyAvSeefH1 0YrsFpnYhiDcV1EO/TtZchaf8Pwas8nyI421He7d1RwmaKQxuo5PN4sGkrPn56J8VfpuToPqT9GJ sMipJqiWGNrQ0RuZsBZcZW/U06Q5dp3RYe2eeLkiJllqFgyhPNd76WQHmxaQlsweSmkIdTyMY07k hdd0Ev4si063cs2ws+qj0wfR1QgpqyNz2END2/cfZeV8i+NfDMldcq7OIw0z0FW4h1ONg2/deUWY fBHGXGDWDwbJ+HZfqqqOUwUckw9mC61HNKKdLs29Pj7s98eIP6ieUuqWQjgmHUErKuRu7pOBdcV4 bPH9l7pblB2D4xhbXywP1NqLep4twvCj8AdHNodRvgnGw80W3XJHp/mGWnNW/BJX0rRfWxhN1wlO dU1wax4YRbaO8PFb4w8Y8SGJijw4SUGARn0wjbV+V0jhtLHR00rgfVa1lxlPO6Go8iSP9LbYseNJ XJCaOCIhrtd+68eWcpVFnrw4Y4237ZVEZLab7k3XoLoN4yMS6C1DIp8JbidK0i2rkfhdBUsbpXeY 3YDt7r6bL3S/NWfC5uF4U+qY3fU0crhHs75Oj3DjH1d8MxTBaijiyzNDVSRlgkJ2uV4f6m9UX9Uc zS4tLTMotbi46PlZFR0Fznhwc2tyxXNYD9whP/wvm8Yyli+CXbUYVUQQ3teWMhfQWKcqcTw44Y1P c2didFvFlnToNiV8GrnyYe/74C7U0/sV6Gj+r5mqkYIpcrwVX/8AGdcFeQMpdOcWzi/ycMpHSSE/ bpvdfaVnhV6kUtMZWZcllZa92sKjhJPo3ljhm6sR138WebPEJmyhxKuaaOCjcHRQNNmiy7e6dfVD z50ywWlwapwelxCmpm6I7bG3yvKmYctYxlzFo8NxnD5cMqHODWiZhbddx5a8E2fs5YLFimE0P6iC VoewgbkFdlJ9NHmjihBUjsHqr9TXNnUbDHU8WAR0hkjMbhy3f4Xk2jZM6kqqiWxnqpTI6wta5uuy s6eGfqh03hlmr8r1c9M37nRsJsPddc4ZNI+SSOeN0DwbOjkFi1cs85NKPo76fFjjconMQyQQtZI8 G+m1gvo8j9XsxdNsUFdgdXI0A7xhx3XyoY17tLd7coY/KFT5QcNXx2XgfJ7aT7PRNb9Rbq42kbBQ 17aUt2/meo/3K4TEfHL1qxujfB/GbB7dJe3bYro6qljLvKYwud3dysUieNl26gG+y6qTPPLT45c0 doZY8W/VzKtTJFSZmmjDnanMLza6z8xeMDrBjUjDUZtq2uHHlPsF8JkrIbs54xDTGqEUsrg0MPJX qs/TLz3ieCw1+ETwTtlZraHmx4XpjkclRwlgxx7PMeN9bOouYmRPxHMlZWeU7VEJpidJXKHxO9W6 nDm0LMzVFPC0WBjkINguF6q9J84dGsyHCMzYe6mna6224I/K7s6FeEqbrZQxzUE4ieRcs73UnPJj dMkcWFq0dQweILq3E1zG5urfLdfUHSEgr42aprccxWetxeoNTWzXL5Hncr091l+n/wBQOm2D1WLR Qfq6Gnb5j3s30gLyi6eWplEdrTRu0Ot8K5FkcbZvDHFGX17OToXCnc6NvpZ7BY8lfW4fOZaOplp3 XuHRuIN/2R1cLootTSRtuUFHRuqzHvcONlzi6PY25cHORdSs91VL5EmaMQNLxo89wuFxVXjONhwk mxescDt6pXG69jeGXwT4V1zwfz5cVNLUxgFzWnj9lyHiJ+mbjfT7KOIZjwnHo6qkomeY6AtsbLul v4vk87jjhyzxVQ47mKhc5+F5krKN7vu0yEBY0uKZmxBzxLmGtqi77nGocb/5SqWSeBhhmjIsS0ut 7ITKKGUmJxIdzsrU1wRwxyVjIqeYlwfI9znD1OcTuseWDEWTfyq+oYOwZIQFyFPVySss5vp9wgln ZDyDpPwuTcvZ0jCCVIwWRymV7pZZKuYb3lcXELGqJnvAkb5sEt7WieQVkOfNS1Xmxi7Hc7ru3wnd PMM6gdTIMPxqESxzOGzuAFi23yZqME3E6HNRXTsEE+JVYh/2SyEhZbsKH6Zt5Xzg8PB4W3PqV9NP ptmrKU9ZHPJhs8UJkbLGbNuBdansby9JlHMWMYLBO+spqWodDG7m4Bsuzba46OEZY9yXs4Y4QWtJ dWSyADhzidkVFhLN3D1D3vdZv8LrqWO/kkg9ilROlBcwBzH+xasryR5bPWli/CqvDWvYGNcd+Wu4 WBFhEET3OmYX27NcuW8p722mEhd/0gpVXG+msdMrf/tsKy1J8kk8bBLIYRGIo9LXDg82RFwaHEbW SKTEo2vJkcHvHZZlRNBNT6yeTwFh23yaikuhEEraste93pZ7bJ4w1mIOIbSukPYsF1zWQsnT54zD R4VRRu/nSBtmj3K2xeGXwM5fyvhUNdmXDIqtzmAtjlbuSrF0zjkybTUGcEipiRUUj4n/ANOoELkK F365ob5ZIj2DR3W6rqP4NulPVbBa6gocMhocThBayoptjE/5HC8X5Z+npnHC+pkGG1sUbsMExD6p vHl32K9kYRmvr2jyLUxh37PF8eATyOMzMKmmYO7YyVgTHS9zGwGE/wC0jcLe1gHh76b5BwOmwqei oxK5oBmqQ0Okd77rzn4rvABh+bKMZj6e0cTMSY4GSjbYMkF9yFEoy4svyUnyjV3QYJXYpeGnw2Ws d7Rxl1kuswipwc6azDJ6V/u+MgLcf4TfCXhnSvLQxTMtJBPjFQ27o5GgthH7rszM/R7pt1mwLE8L fhGHSAXidUQMaJI3e4IV+kXTf/wYeqb6XBofidDNoZFCZJDtYC65KbJOMz0pqY8FlMDRfW2I7j+y 2E9Pfp3twLrV+mxMasu0shkjkc3/AJ7b7Be3MVwnp5kChpMLrcIw6KncBFGySFhLv7jdJwjB8ch6 vcvw/PlJH5dQ6GaJ0D+NJbayuWEfpDE11nDe628eL3wBZZ6pZYqcfydSQ4HjcMRm0QtsyYWvaw7r WF0m6L4r1F6qvyaXFs8EhimeBcgg2R4lKO6B1xalP6yOsqYVLJ3eY90jDsuWwTCcRxqqEFLCZLmw AFyfwvZ/Vf6YeYen+TJ8zYfizcQEMZklpACHNaAuy/p2eFPDsxhucMdgbPT0r7R07xcOeNt1wlGo 22dJZq4SPG8Xhn6mR4c2ujynXTU7262uEJNwuvsWoazLOIupcZop6CZpsWSNLSF+hTGs85UyfV02 EV1bSYfLIQyKneAL9gAF598ZXhGy71uyXU41hlNDS5ioojNHNE0BsrbXINluEYzpS9nhepcZWq4N NpopcRkZHSPdIH2AJHuu1Y/Cx1Gly2zE6XAnz0zo/MDywi4/cL0t4HvB4zN+bpsTzJTE4ThsgDYy 30yPB91tKGEUNJhbKCOkibSMj8tsQaLBvFlyyYlintPUtSpQ3RPzZVzJ6Oeqoa6l/TVkbi1zCLEF Yk88gw8B0oJabBuqy7+8Z+VqbCvETmSjooRBEyZxa1gtdeqvCz9OvKXVjpVRY/mR1RHPVtu0Rn7f krtPF4/5GseZTjZrfosLkk0ObO5wcLlo3C726V+DjqB1lw/9dgeHOZE3YOku0Fdv5j8FcfTnxE4N k6Cbz8MxCUeVJINwCe62m4PgmBdDemZbDC2Cgw2n1zOYN3WG5WWlGqMTzcOmaXupPgv6t9LMKlrs YwE1NFELulg9ege5surMm5RxrN1ZDhuF0j6iomk8trAw7Ovbdb5enXUnAeuWXa2Wjp3z4bJeJ7ah mzgdjsvhej3hByt0qz9jOYqaKKpZUymalgczancebLveNJqSpo8cM+S++Ga4H/Ti6u/wwVsmGRvb o1+Wx4LuPb3XmrPmSc0dLcelw3MFBNQuYSNMzSNlvQzh4jcMyvn/AA/LuiTRI/y6ics9EZ4G6+c8 W/h3yz1z6Z11XU0cf8Upqd01NWRtAcbC9r9wii7Smqvoi1aTbi7rs0WiMxvFV5gcHb2COue4wMA2 LiLNHJKXVYdJgmP1+Hk6zTyuZ/Y2V09c3DMYpqqpaZo4nhxiHsvPlh45Uz7UJxyRUl7PTfh18BWd eu2HDFHuGF4U8AslkBuQu9qj6QeLsa4w5riebfbpI3XL9CfqUZNyT07osAw/BaqpxljdDKQNNnOt 7hduZG64dbOpPULDcQmywcIya+2ppBDiPdXHNv0fO1Epx5R4L8TvgKzp4e8txZhbI3EsOYbTyRHU GfJ9l5aglfUSQywNsT95C/QL4sY6Gfw8ZhjxNrTHPTlvr7EjZaAK1hw7FKqnp3BjBIQ2/tdblFTx ua9DBmk5eOXY98bRISBYlXoAF1TbiUNLtRPKyAxui3K8DPp0K1DayEuJeBaymnTv7omDublCsCaN weHMO6Y6WSUDWy3yjsLeyA3DrHdAHGLH3V6bu2CEekX7oogS65CAMEh1rKnxk2PG6MH1EqyRf3QF W0nfgIHt8x172TSRfjZCAC7dAHZpYADdyAwOJuTZEyOxuDysjSHC99h3QCQN+eFbvVb4ULgd7X/C MwkgEHb2QByWMbd0LRZwKs2LBso43sAqBlw+6CRumxHKZpLWjsVDYmzlAAQX2Kt+w2Cl7EeyMPt2 QAN9XdU8aT7onDuAqIuEBNg4bXRabm52CpwDW3vYoDqLb8hAG52kWCW9pfv7K2klt7IwLgG6AUXE tsUDmM5bymGxcVYi2J7IDGjZpffkrMvYXtZA2I3Dv8KPksbcIAXEudflQc8WQ6nduEQaXMO+6tgC ok0NJAuqgqDMNwiheS1zHhVCzy2m6hQrbkKEgDSqIBN7qx91ihAX3Yyw3QTN9LXHhE4PE29tCYC0 mxFwgMYyOI3F7eyy6fi9rbIZIwLaRcFNDCWjSrQFGe01rbJkspk2abEcrHeCyW5RRzN1EnZRlRm0 ptHqPIWY14ewEc/C4sTAtsOFkRCSOxBNlho0ZTyG3cT+ydSjzRubeywWuLnnVwU2Jx80aeyw0Wzk T/L2vdCfULKgPM34ISnuIcQCsm0xjCG3ubJ0Tho2N1h22u43CswtZvG878goQzHkG99ykFu6ZGLA JbyBJq7jspQGRgi19kfmlxtdKMhfb2V6Q3ulAfrGk90l1ndv8IdZabWVGcNdwpRbHMZYA8JhkaO1 ylNeCNimgsf+QpRC/N25VC0h5KB8YvsUQ2aG8FQE0ubyVYfvZC5ptuUJa5pFjdOS0ZJAsN90Ztb5 WIZHR7vCcJQ5o2QUNawPcAUEr2xyFvKWNzcHdBIbON+flSioyG6H8gXUuLgLGbJY/KLd4Dr2KE5H btu4ISC4KmXLrk3CNpAFnKFK0agOwCoSW2sjJ7DhCSL2Cpkp5DbEhCYjbUN0d2O2coZbCw4VRoUD YXOyU5xfKD2CY67hdJc+7TY7hVE6ArwH+rSAQOQuHkuGnZck6RjmuBusCpju3Y7LqjjIwTJsQCsN 7dR5WXUx/wAv+UPV3S6Yl4s9tiO66IwAz0NAUnqDC0bXT3Rg7AbrGqoSG77laBUMjZXbiwWRJGZR twFhQAB133AWRDI5zjzp7IBmxFjuhBLR6VYBDTZG0lvIugKaS9nKoXB9SjDuUb7AHa5QAcHfZGb6 NkDf5jd9lTXajpvsgKI1NNuUIbd2lMDNJsDx3UBsf/KAoHyAARqJ4RgXG+yEylp1EXRCXzD8ICG4 vsguDcj+yMvF7JcrS3gbFAEPtuhkaZNwUbbBtlNOl17oAXOuAFDJcWPCsixugcWlALaCDcHdEJ3t f9twVY9kDnWdfn4QFyXcbhoulOYXHdZTWgc7H2QEFrr2QANNgGq3cbKwLyfCtzfUbiwQCDuD2WI6 MSS7rM0XBIIsPdJIbckoZYIaWbDhW3Vb3KoEdibfKJu5tfZaIASXjdW0EDbYfKoOAcQobv8ASDsg FkAnc7o9FwQENrGx5VPLr+koCaAAbG5RaWtbc7n2S4oyHm5N0/yXAXHCAW14cbboj6d7XQxtu7Yb or3Nu6AAPc1w7NTpDs1JLTq3RsO3ugCJD4zbYhLi9TXEn1I3vbCNhuUtjdyboCwTqG3Cpzi510wP Dhayu44HKACNgvc9k1zY9Oq+6U4luxQsbd3wgGGx4Nwhb3CXUDyZGAG5dwnOBEZaOU7AqR+n7RuE Ama/YbFJkbM0k8AI4bNI9ygG2023Rhmrcm6LS2wuED9G1nb+wUYALiXABMLL2uUmVwuACmRuNwHG 6MELRG8O03WS1+oJLnC+khOjI0qAMcDdGQ4WAPKF1nAFqEB1+UNhOY/UAHW+Vel7e+pE0avuO6YC WCynZUUzZtyN0bjrZcBDwLdlA7YWTopb2F7AG7FJmcGWZbf3Tw+x2QSQgnUSliwI7NHrTWWIuNwk t9LtxceyyNvL9I4WSMDXpJ1cKPlud9whc1vySeQhAII2QgbXB+1kDxZ3CMXvwoGuc6wQDqZ/6X1E AtQSVEczyYxa6Al52Iu1WGtj9QFkBcbAQSdyqfb22+FA7e/Ct+/HBQtAggAWJ+Ux1zwdkosGm45U F2ckn4VFBui02JddLfBbcbhEBdtje6MM0nc3uoSjGdEXmxKfDG2NnNwiDQXWKCZoiaPVueyvoFP2 G3BVtbpIueUD3hzABsijs+wJsVATyHB2u/pUk/nD07DujkqNPoA2QtdbgWBQEkAay4/wqjDXD0/d 3CpzwDchU2znXGyAkgPKAyOHBT3R3+EIi0n3QAhjGOa9x3PZXM0F2oGxQui1uBPZRoN/dBQNzqBP KYQHOuDZCATyrDd+UARc7i/CY0lzd0trS477ItVjYcLXorBkYDb/AMJJOlwuLhZDvuFkuU3P4URB ZB1XRnewKWZC8na1lYB0m6oIQL7K9Fz8oW2LL9/ZM1bbrIGMc1hDXNupK6NzbAEKNs4AkWVPs7YI AWnYW4TLCyU3cntZHx3QFON3AXsVLC9ibg90p97XvsoCdNkA8saO90osGo/Ko30ixTCzTa53QCHN 7eyOJpJCp1gjDSALFAR3qftsrEdnbKD4CY0Esce4QGKX6pCFL+pW1ptr91RNnG4QUMbY325UPp2J QDZ1xwrc0yG4Q10U1p1kE3aivvYcBCDp2PKto5KEsMO2Q6i4iyGQ2btyrjF7IPRZAbtweVTXkPG6 GSPWb34RMbqHyhC5ngkAcowB5d/ZC1gdcnlC25JB2CAjneYLdvdQny225UAFtKo7fKFsjQHEG26q RtpLomKPsXbqhBEBzdlGADkoWm7i3ke6j26LG6hAg5z3aeB7pMrdFSGtJNwnm5ZtylMbaUOd+6AJ kbiSLKOZbb/sjkkDnnTsFRfZosb2VsFNjA9NrH3RCLSdRO6hdrF+6EFzrA/uUsDNPmA2sh0nTdRz uANvlTnYFOBYDy47DYIGPeXDusgRlrDqSqeJ2s6eyAnmEPsU0uAFwd7LHf8A8w33KYGhg52UABF+ FP6kZA7GyENve5uhQOX7BEBZV+EbiA1CEbKBso+z27BJN3WRBxbtwgCDbMsdyrDQALIbEm6Za4+V bNAR+pxCMt3+Aq9Md7/4QmQlvF1AVLI3Vp4v3UiFmne6S6xIJCax92m2yALU1o1EbogAfUCoG3Ze 10tzi0WQEkfr4O4UDjYpbY7uuCngbe6AFrtt0QseULrN/KgJdt3QFulZwDuqJBN0ElI0OBDt1NLo nWtcK2B4cHDZDbUbjYqm2aNwo51jtwlghdpPCBznE/CaPxdBs4lqtgX9zvwi5HCKOIC9jcphAAHu lgWGaXD2ReY0E3Vue0N37JLQJnloPPCyBsT2PDgWWHuEnV2CKNuglp3tyisObIAA+w4ShPof67gL MNi3cJD2g7G1kDAMzSfSb/KglcQWhAYQx23CKL7r24QyPa4tYNt0TXHm1koSgSC/Cds83BQ0A59z ZWGG1wrNmC9kt8u1gLAqgnYg7lXqJbbsrYy7Ld1NBA+UBOW78Kw4AAdkLuQFDquLiwUIS1iivYKG x43QMvfdCluO2ykQAZ6jv7IJD6vlW2IkgkoC3yEn0jZC31G5sD7K5CGcFK8l0jw4HZAMdGClPBBs DZZDWNsQDuEIhDySShGgGuvYnlQjW/fhW+EgbcIXB1rICpLMcGjdG9wZGTyUBabb9kRfGwNMhtfZ AgaepdO0k7ALIEtm6fdLcAG2jFgUWnSBfcrSKU5xQNu59kxwJbwgG5sNj7qWSwiC3fZDa4uqjJYX B2/yqsZAdJUIwortk1jslSNfK4vcbb7J8bHBljuqPFjsgMQEgEEpsbXyD0ndRwa+9h+6dAHQtFrI BZe6P0vO/wArJjAtq5KXPC1w1uNypFNtpQvQMrGgXslk2sAmO33BuoGNIF+UKA4DSCNioW2F72TC 1umyx5TpIBKAa4ANvyktdcm2yY6Zlg3ugcwtF7gD2QBPe4N24S/Nbw48o4/5jbHhV5DTwboKFt1y C17AJrQRbUf3Rtjsb9kJaJduwQlAvIBCcCW7grHezkk8cKRnVyTZBQM2oyHSTcJkc4aBqHxsqcRc 6Ruigj7/AOEIPI9Gq+1r2StLiy902U6W+o89lTWnQAOEAoNG9zYqE6RsbnsifDqdcm34QSWBBCAE OBFnfcmAPt6Hc9kp3r3ATYbsueT2VsBQNdGHalBI+I6nm7T2QvmN90E15LAfalgqqkDG3G4KuKpe Gt21BBJvGGcuQsjkBAtsjBkyzuDCALX90EbfQLjdW8k7G4IRMaWjfYJYKLtKC5J24RAarn2Quc5p 4SwCDZ9lYY0O25KAzDVq0klM1Xs4iyWC3EN5QNkIeic4G2o3sl31Pu3dqWCP3JFrfKKJpbYkqAkl W8Fg90QMXEHmXSy9xdXLK30tI4HZA/eX1bBRzwXcbLQDcGva0gWQNAc4kAbKzzz+yHyibkbIRgMk EkpA7K3POvSRdAyMREkeoqXLn6iLKGTN9PlgFov7pT2tI3CUJi51jsAr8zULoWwXxtBFlRIDTt/d Qerf2UDNrHdUWWBcC2ystJG+6tospflCCnMsLgJTSXi5HHZZOq/ZC0XPGyhRbSZCQNlGE6rHsjd6 ZLN7q2Q2cHXulAB7NtkwRh8e33K5267W2sqLmxOY3+pUWY0kTmG5RNuWlzuFlTM8wbrEc5wOmxso yBctFiiDtVgOUkROZvf9k0WBv3URbCsAbBU7Y25Utv8A5VgWsSbhaIC3b8Krk8boy03O+yC2ntyh bCafSb8oXa5WEM9JRsaL2J/dVITHxwgsqCPRsdz3KbYcoGOINzurubIUo87qCPfUqN+yom3dCj5J C5o2WM913JrATydkia7ZQbelAEGy3uzj5Tg4gDVyje/TEHDjshGl+4UolF3IVh1+VQGpWBblUpZb qN7qNLSTcWI7orA2sUuRhLv/AIQCpRc3KBry11lUj3F/qFrd1Qs47bBCWZTXagLKzaxuqgtpsrLi 64QWBq0us0ekomnUeOFQGkWuqBIBABuoUaSCCeEhkLpbuPCY22mzjb8pIxE03mRsAdfa6lgOGka6 /wDODXX4Kc6ndE8t1B/yFxTQ50l9/dcnTeZe5Gx90YFkE/H4RN9Y32sikAa423CXcEgBQUWRta6s DlQbD5UuUAL3dlBK1rt+SjFuUrywXl10A03P4QgnUU1h1DiwUewAFAAXb2V3J/KotFwbIhsd0Ap/ 235IRD7b91Tv8K2m5QF3spdp7K7XJsq42sgPvJXsMlns1BKhpXBzj/QUchc07hNpZ/NBbawC8q6P XJCJadr2Ou61l8/UzGkmGhwcCdivpquAvppGttchfLVsHlCNp7HdVGD6LDqlz4QXHdZYlHl2t6lx mFNEwbpO65Qw6TtylGwHG+/CY1wEdxygsL78q9BI22WSASz6LbblY7zqNynyRlzhcbIHwBndAAC3 UNkDrPlJtt7KF1vTb90gO/nlt7XVSIwaTD5sTxiKhp2kvlIGw4C9j9E/DrDUU9Main818lgSWrzB 00nio88YfJJZ4L9J+Ftb6AUdNUuovQ17S29gOF6sEN80jw6ibirR85W+ArI2IYOa2qk/SziMyP1u AaLBJ6WeCPpd1Dw+rBoBUsheYTNFJff3XM/UXzfieTOm1BS4XVyUbqlwaXQmxt7LqTwKddq/LOLw 4VXPdLRVTwHE/wC73X1pwVJo+FHNOc6MLOXhNwfpL1hosIo6GZ2D1LwfMNyLe116ed4RunsWC0mJ zwU9I1zA50kjBv8AuvSWIYDhWa4IZqiCOcW1NcQCQvH3jL6vCLTkvCXupRRvaJXNOk3HYfCsXHJU UufZ1nOUEdu4F4XemOKYSydlBBVQgXL9IAWHB4d+iGYa6TDIcJoJqpvpdGxw1XX1fhribX9I8OLp HSCeMh5JufYrqLq10V/9OajEM6YNjToJIn+YB5m9+bItzm4bjjJypM+qq/Al0qrfOgZhBpmuHEdt l0rmPwKUnTXOdHiODMdX4LLIPOjcwEsF1354Vup+MdQ8Or5MZnE8rAPLPwu4Zs0YJW4scFkqonV9 tX6cndTfPHkqXJt/x7o8w9cfCT07xDpPimLsw0QV1HSGaOWPb1gXXWPgexjIub8uPy9jcEM9fFIW FkoG4BXszrJhQreleY6ONttVHJpA/C1E+H+qqcF6nubTvMUkdQWnSSL+pact2Jyf6Zx5ZLJsPYHj B+nvgOccClxrIdGzC8XiBe6JuzJAFqrxPBavK2PVeBYgdNVSSFj7+4X6GMnVkuN5Gp5ag6nui0kk /C0aeMLCP4F4hMwxsYI71BcbDa115/Epwbfo9OPUyhlUX0zriOqNJy4bHgr2t4Hc+0MGNUlFUuDG vcBcheJBCzEi12oaGi5IXfvhhljhzTRiN3DgbhfPh2fZyO42bp4P4NJgTqv9JDURxsu4mIEmy+Io sB6cdaKCtgkwGhq2sJZIHRNDmn9u6+l6bOa/IkM7yCHx3N977LqaXqh0t6IvxIT4uynxKoe6V0AO 5d7WX08atSq7Pg5ZyUkfOdNfCNhnTbqhWVlPGyXDZna4o9O0e/C7H6ieIrpz0rzFRZbzDVw0lVOQ 2NhaLC/uuf6QdRmdTsJdisTA2FziGW7hat/qXGsk8QE/lsOiKBrmHcWP5XqhDzScX6R5JynFqvZ7 T8ZXTHIXUXpW7MEVJSnEI2edSVkQAuB+EH0++oEOJ5AfhWIPBq6N/ls4sR2WpuPq11AbhUeD1+Y6 mXCbBohlc4tDfZe/fp0VUc1WyB0o1TO1fkLwZFJOj6UIyjG2z1r4xeocHS/o1iuMOhilkLTExj2A 3JC0U1uI1WZcTr8VlAidUTGSzdgLnhbtvqBZfjx3w45g13JpmiUD8LR7Qh88ckYOlrXG66ZElgi/ Y0mR+aUTkKOoIfIBf0tuT7r6zpT0+GfMZjiklMX6iTy2n97L5WnY2KCSxuSLXXqfwrdKq/MGPYHJ h7CXRSCaw9+V8z/g+5J7Yn10H0wsw41SmqwvFSzbVZ2/7LpDrB4UuonQwNmxShfWYdIdPnxtuAe1 /Zbo8jYTiGVsCqJcZrGU2vSGudYBib1LwCizX04xOlrooa+J9O4h2kHt9wXtw1wpI+RPNKL4NMHQ vpbi2N5ipZqSOSStc4COJrdwbrc30Rw3GMGyFh1BjbCysij9TSb7dl054QulmAYDg9djcNO2aeOV 4ZI8X079l2tknrPRZxzfiGBQwFs9K6xcB2W8mJRlJQ9GfO5qO48K/U0y47Gs+4U2CO8ha0OIb8r7 jwM9Hs14C1+MRF1LRCwaHmwePgLtHxDZGos6ddcrUlW1ppywPmBF72O1l271FzZT9HMk0L8Mpo44 Q9sTWWsLL3TcXjgox5Z8/HKSlO3wjkusEM1V0kzI2QAyfoZLgjn0r8+mKB1LmfERC0BwlfYH/wC0 v0LZgrY8ydMK6cuBZUYe5xI9ywr8+WbS2HqFi7T6WfqpG+r/AO0VjEv9E7O0HeeKRx9ZWSSU74X7 SuFrrsnot0rxXOtTDHTU75Q12xAK69no/OrYWtsbnay2ffT8yvhRwWCaWCOWcu2Dh3XzFwfdm2lZ 2N4PPD3mjp1FLX1tR+mp5bERuG5C7t8TsBqOheZKdxJfJTFtx7rM639SJel2AUNZBBqbLMI3NtsA izrVszn0dxGrLLRzURksfxderHBpxyPqz4ubM5bsa7Nf3QXwDxdV8GjxXEpxRURuNWm5ce67fq/p c5Nko3xQYjpqLekvBF/7L0p4afJHSXDGwEHd1yB3uviOoXjNyV04zjVYNX0lRPU07tL3wi+67znk nkkoI4xyLHBb5Hm7K30yxSZ4mosUrWnBS3U2SMXLvjddaeKH6fuH9II8Mx2gxl9Xh01UI5aZzLFo J5uveuQfFJlnqjjtNhWF09XT1c27HTMLW2Xy3juwTE8b6bUDMOpHVDIKlr53tFy1qRTlkjGaqzTy uMG7OsMF+nD0+zz04w+phqJaeoqaVsjJozcaiF0J0K6O0vSbxNvylNWgVMEpjjmkIF97DdbFfDtX mbpXgsEjHReRBpId7Ba4utWNVFP4rsaxKif/ADI65gheDzYooXKUZLofIdKSfDNkPUTLWMf+l2KY fS1ZEsdO4h7eXC24WtDw3eF5vWPqpjLawltJTVLnVJd+VtZonTYzkOmdM689TRAvPG5YvHPhEq5M F8QmbcB0GNsnmOcLWDiCumLJ/onFnKV+VM7Xk8FvR3LVKx9fQRRgixkqJA0Er4Pqt9PXIWfcCMuV zDRVQGqJ8DgQ74uFnfUWwPHanI+H4nhddUU1NSvIlbA4i/5XkjonW9eZIYKnLVfiFRhcbg97ahjr aL7q48DniWTd2csmplHM8aXR696H+AXJeUMIjdmGjbiNfb1CSxAXYrvDN0fzD+qw9mWKKSRnpeRH Yj8Fdi9NsxVGN5JpcQrInMqo4LTA93gbryrV+OXH8Pzzi+XcM6cVWI1cE7mNkgjI1AHk7LzwhknO Sh6OzyqGOLn7PMvj58A9D0nwSTO+THeRhUbv+JpHn7Pay8I4O8aC6Qag8bA9lsO8a3iE6jdSum9X gtdkurwCgAEkzng7j3K14YIWywtLtgHWWtRjlGKc+z36HLvuMej0j4RZ4KDqXhT5GAnz2DcfK3dV dHPWZUbBSz+TPJTjRKOxstEXRTHKfA8/YRUSSCKLzm3cTYDdb0MqY3DmLI1JVUFSyoElKA18ZvY6 V89P7WenURaXPs6i6LZDzXljOuJ1ctc6owqpefPD33u4dwu85HMdiLIjcPAv+y6D6Lt6h4bn7GcO xlmjBhK6SGZ/9Yv2Xc+O5vwHCMWw7D8QxCKnr6t9oIy71OK9uoe6dr89HxsO1Rp+jqvxJdLqzqNi 2X3U2IS0DKSTUfKfp1bruTL1E/Csu0lO+TzDBCA55/qsOV1h4jcHzDjOB0LMtyaKwS/eHWsvscs1 9RlvpxBUZnqmxy00F6qdx2AHJUnzhgl2dIteaTM7Fadua8qV8Jc6na5jhrGxFhyupegfSiry5j1Z jsmLGelqHFgpQ46djyfldoZWzLgOf8p1LstYlFXUsodH5sTr6SV1X0j6R5zyRnSvlxPF3VOCOldJ BFrva5Ug2oyj0JxW6EjvWbyxXtEwa0/0PO1/hdHdfekf/qBmnDK2oxEUVJSEPaHOsC4LsPNXVbKu CZuw7AMTxCGnrql1ow54Gl3YG6+H8TfTXNnUfD8IblOuNJ5EgfM4O2ey/CmG4Ti3wXLslGW3mjtb D6InKRpxIJD+lMbX3vf02BWkgdTMV8O/iTx3E6GkbU1sVdIZWu7i5K3RUmJU+QOmkM+N1TYW0NJ/ PllNrkDdaa8KZgnWjxdYo+vqYYsJqq0kPcbNc269mBpRySbMx/nCKPSeM/VRZmjKtbgVZlWemqqu AwedIwlh1CxK72+mpjbsW6W4wwaRBHXFzWjte/Zfe4z4Y+lNT06kYzBcP/kUjntqYnAm4bzdebPp +dbMs5OzbmjJNTUspfOriyme9wDXWJsLrxOnjaij6Nfa2eluuXR3KmYc24dmHHsXNDWteBAwvsCQ dl24+hpv9GtpKiYmmfAI3St5c0iy6v8AEJ0Lm6t12DYhDXeTJh8geyJpNni/K+o6g51wzo90omxD HquOKOjpPLbrcPW/TYAe66tuWOEU+T5X1WScmfUZTy7hOVMBhosIjhp4ALhzbAuPufcrksLgqWeb +oqBUNJuwjsPZaVsu9e+o+ZuotT/AAXNld+mrK4iCmfIdDGE7AD2W3foZhGO4N02oW49K6oxORmt znHUd1nUYtivdbZ6MO91FxpGsb6lfT+hyp1rlxmlqNdTicYkfD/9M91870E8a/WTIOAMw3LWBOx3 B4QWgeUXBv4XYP1QsmYxQ52wfNFe9ooJYzAAOSfn5Xev088ydN8H6UsoarEsJgxNz9UkFVpD7/kr rqHHbFLng3pJOSl/yedunHXvMvUvxE4DjuaKSelrWVUcJppm6fLF97BbTM+UNJi+Tq6Gts6jkhLp L8aeVr08c+Y8lZF6q5dzllqqo6nE4pGumpKJ4LZLG9zbuvbPRfrLlvxC9N4K7DahgklgENXR6gXw utYi3svPKXMXRZ/ZSTE9DcdyjNBLhGWBEwUwtIyP37rsiOQMxswRSNDNN3RhfAZI6T5Y6M1eJY1S Tilim1PqJJ32DRyumcN8e+RB1orMsmN36VztEeLk+gm9rfhbyReWTlA8+KUccUpL2dj9QMYyFH1P pcIx+nhbXSND2Pdtcrs3M5pzkfFXQlv6eOhk0+2kMK+Nzj0Zyv1Vx7B8zuqI5qikcJYnxPBa8ci9 l1/4x/EJgfRHppWYY+pZ/FsShdDBTxuuWttYk/Ct79qT5RzS2Se5cM0pZ3pXxZ7xWoYDJrrJSGju NRXF1dBVtlZUVNJJTxnhz2EAr014QMn5e6udeMNfj36d8LZTJ+nmNmP37rZ9158OPTPHuleMNflz DoZIacvhqIGhrmOA2IIV1M4ymkj6uDdjx2zS70vzZ/o7MVJi1PgLsWkp3hx8uIu7raF4efqIUOf8 dwjKmJ5VqMLnntEyQsswHhfD/Tmwvp42mzLgmJQYbUV8U5Yz9YG6iL22uvTlT4T8mMzzTZmw8RUJ jIe2OFw03+F50ov6y4LPNcN0UfT+JrJ0Weei+Y6HVpeylfLCW/7mi4C/PdmWJ1FmOsjnjtI2RzXN 9iCt+/iL6yZU6W9McVGKYzAZjTujZA2VpkcbcWWhXMWJQ5gzVimINZaCeoc5g+C6/wD2XpjKtO4v 9Pn4U5arcvwxYmgNjcO6yyBa5WM7/wC+AwCwAWQ94Ldxsvms/Q22hDh6tlbiWgFRrr3V88qAo+tu 5t+FTeyrdjt+FZsOEAYAsmRusLBC31cqD08du6AbYAJQGp2ya0XF/dWIwCD7oAT6W/KBoc4k9k14 N9t1TQR8IAASW/KISOczR27qjzZXKPSA3YoB0bgwaQAh1PEhBvpKCMEN+e6dG820kXQpYBta37pj X+TZ5F7IL2NiUYewMN0A2WTzS08X3VaA7f2SjMCQRwqa8k24agHNe1wOyq/PshjItbur3F+6EKsS dlLWHsrb/lQnZCoXOfSLcpjCRCLjhA8EkEJjj/LG6AHXftsgc62yl7XUAuD2sr6IG1trX3CLU1ji Dx7Jb94XAGxssOjDvNs86h7qA5AysjCxnvDne6ZUtDALbAqjEPL1NO6AEiwsitYBSJzHi19whkd6 7BAWVG2JtyhBvuiDmtQDI4gDdKmeNe+wVOqNF7cKoyyo+7lChj1hTRpNzsrA3txZSZpcNt0AD5NH 4UjqnB+gDY90JaQ23dAGFrrj91UQyZG2de17ofIae2xSXSOI24CbES7vZRlGMp9LbhPjkAbpcd0D XWB34QmQvO7R+VAZLm3I073RsdofuOENGwl49W3sVVQ5xmsBweQsM0chFMC24G6pw1OvZJjIuC3Y p5eALHlZZpAOA07jZU14BNgnaA4D2SzHaSw4WShsk3RlgJueEsM0mxVSSOGzRdAGNhtwqkkDBflA Hgd+UEhFh3KAKWXUPTz7Jeq3PdWPuBsmFoduUBUcrWgdlkxkuiIB3JSHaBYBqMXBBBsPZANlhL5m FjrWG6bMPSB3WJIx87/RJoISbzNeQ5+oDgqUDOB0ix3Ue8aCOCsdkm3rKt8lgVKLZYY5zCC4n2KZ FKT247rHZUWFrq7kg+pUgzUdd7pjLySku322WLqDdysiOZsZDuVKLYwtAv7qRn+yS6XXLqH2oy4E 7bBQWZBdcDsppJCV3G6c2QDa+6lCwWuGk73VF1hxdCXiM2Ivco76rEcKULAc4OOyNgDhbhCWjVsr DbkAKolkc0N27JEsQDTp7przpJHKW94DVUDj6hhZcLDfMd26Vn1p3a5cXUyEG42XWJyZiVFUIH6T x7JTaxr/ALR6kNX63gEX+UvSLBzRpIXRGDMZUei52cgkkL7kpP3EEq9YdueFoEfGHt32smN2AA7p Zc0p0ekiywCNu027K3AHupqId8e6IN13DVsEaza45KF7iCLjZHpIHslk6n2KiBUreLbBRjWuNibB N0g2FrqANd6QOEAk2L7AqG45TnRAb2s4JT3ki5sqCavMFgOFd9JsOUAcQAAeVbmmO3f5QDWMBdc7 IJ3ahYGyHU4b8KyNVkBIm7e6u5DvdRp0bWur1XG6lgY2Nslt9/ZSWnaBsDslHf7Tb5S6j9QR6Hg7 KgW6xJDTuEbIg0aib/CVT3N7jfushrfTcf2QAyFxe0gbJshAaPdLJJ2Qi97E3QFRjVJcXUnf6zYo TsebJVQPQDflAJqIy94dqsB2Co3F7hCSb2VjVfdVGAuR7KEgC/so5wZtcIQLm5GyoLJa7f8AqVtI PHKmgcqm/wAp1zuClgjWXdfuhL9/ZG9zibtGyW8auRaylgp02hw73WTq8xuzrLGLbi4F0xps2xFk sC5LxusE0bm+ypwGk23KunjPz+6oI/cC/Y8oQ83Oyt7SXEHhEITyp7Apzw4nVykySWIIJCc6nGq4 WPOzTyUsBiR3LTdHrc4gooIB5Wq90IGkEApYCAu8g8q2tcbgJbQfMuSoHHzLA7q9ge2lu8F/9I5W K2tb+p0gnmyyopSWuaT8XSDTxRNJbu891kDqn7b83WAX+r8KeY+xDzwowP1bC4VQMyN4c1Y0lF/x GtpP4WRGCLXCMNde9lQYTqZ2u5uFlQRHU0k7+ycGm+4v8onlosWqMC5Yw6QG/CaLOYWgWKBs0eot O7jwjJ9Q2t+EQBYDGLA3RHzANQ4CsNJB90yKo0NLbXUZsOONr49QO6JvBvulEG9h/YJrWkN3UoFj YFAQ4H4Rgi/KvlQFgDaxS3NkMn/SoHOLrcLIjI0kHdQCdANiOExuzSFQABsBZC872AsgF7PJtsQj AJGyFgs4kq3PIIAG3uhWW1pe49rI2kC5B3CBzXA7cFRrbG1+UDHiR0kZAGyS3gjsO6hn0v8AK5PY qaTGSHbXQhVzsNrIibt/CG26nqDtPb3QWEwA9uVbmfCp79LgLX+VfJ3KFsSTaQe/umR+pxJ39lUg uP8A4VNIaOd0FmRG31XSpgJDc8I2v1M0nlKBJcWn7fdUglwudkyIAEXCEs0kgG4TARbhQAluuXYc K9RB3GyMvOkm1vlAw7AuQqKc3VseEIvxZE8km7UD3PaNhdAOubDdA522/KprwWb8qG2lAiAnTyoO 9lZAIFirFgbf3QMH+nhQnyhqPIUBs6/IKCqdchgQhTXOmJdwOyZqJcLJkTbMAslSXaTYoAg4l2+y vSHAlKD9thcpkYcWm4sfZUC3NI3Cl7N35Ue02O/CW/ZoI5SwDL6HgtTACQDfdVIy4BBsoy53KWBr hp3KEOI+1G4en3Qi7QLDf2UANiTqPKJztkwWFiRz2VSAONwAEAtty2xGyogAWRXFvlU/ZnyUAIa4 HbhC4uL7m6bG7U2wFrIyRbjdAY+q7wE0NsOVHt2DgFWq5tZAECSFbwfLdY2JQ20uUJP7IBbgWtAv wrYQTY7q7tJsUTWBvO6GgZANmtsFTZC0Bo7K5Iu9+EHG6Ess3vdW3cc7qgQQi1bAAIOCtOoK4xyT 2Qlx1EAWRatPPJQegQ2xKYwWvbuhFiLImjTyhC2+lDbdRxDbnlD9yAsFUTe6Y6OzQe6rRcXQFM27 qrhzgqc0tdc8IgABf3QqKIAJshIvzwmOb7FKIc7a6Aa0gjY7KnANCGNmgWIVyPFtuUKAQA4d7oiL O24QNe7Xxt3Vula0n4VQDJ7IWOO4JUa/zm3GwS2uN7JQHAgs23KUQR+UZJDbhC2U3ChKGMeZBa9l QeYuO6Ek69hsVendCF2Bse5TCABwlgWN+VYeShaCFiCoAADsgBF+bBEXC9kKW1oOyp7G2KhdpBKS +YCM23ue6AtzLWN9kYDZ26QdwsZmuR13mwT/ACxe8Z3VsBOaWCygBBHsqYXuFnFTVZQC3eqSyaRa 1lGAE37ojvdALe0EWKkbQ0bhQvBuCPwoxwAQDnkMi9Is75WKdzdyKWQvNkLbOCEDY0ON2iw9kZcB wlN3PdECACRuhQXsc/hW24bYqxLZtyN0IfrF0ALr7G6sSubYOCMN4UcN0AUR1coHuaC654RA2+EP OxAKAjJw6waimOkAjkpRZo2aLI7B1roAohpO5TC4E2QXDd/+6rVpu5AU5mu4vYpccMkUgdsmsOo7 Kny3db2VQDdGGxF+r1X4S9Q0+rZNIDo2ng90mXkeygC8+O1r3shcNW4tZTQHjhWIxayEoQ86zYKm NINrpkjCwbDdA31Gw2KEomlwku4bLJjFwbIC4g6SL/hEDoBKAkhOg3WM5xJAITiQ5977ISNbwAbo VBk2c0d0eu7rKgP5guO3KA+l6IoTz/MCuR93AX2Sy7U/lEXXG/ZAWHaD7oDcu1XsFYOpRzSNkBe7 zdHb0pJkMYuExkoLRfkoAQGk+oKmvcLtHCYXBxsAqLLN2QAsYWuuDyr0kSc/srYBpurNrjfdAH2s gLNRJ7KA6QSUQcTc9kAFghlDHgBzdRG4UIaTsVBwgBDjq2Gyl3E/CpzdG99yqc8uaAbi6tgeCdNu Qqa0B1+6sizEsje6gDjDSTq4+UiExiVwaTe6Nx1iwH7qmMbDGDb1IKGGoDDayEOEh4Sw4XJc1GNI 3AQAFvq25CawjTfuEk7EW3JVi4vshKClmZptquSeFI9OnYi5WK6MulDSLXVx4cHyXe8t08AFC2ZO kU9i87u4CtxcTsNkBptTw4uLg3i6cx173CAU+43/AMJbpoLDWfV7I5b2NhdcVJh0kk2u50g7oDkh olJI2twlNjd5pvu0q2Ra2XbsR3TYthpP90A0RtAACprRcgKvJtuHb+yqxjNzyUAdwx224KRHJokd fgnZGHuJ4VgC9yP7oCg5jiQ479lQGlpvyoGgv1d0UpGgEjdCCmkuvYWTYw5zTtZDG4ngJmuzSCLK slGOCbkPN/ZNY8ja+wVOaxzNvuS7aTa6gDdM5l99ilA34TPLt8hXHGL78IAC46rAWCZodsSbKGNx k7aU50Xo3NwhUY0xsALgpcN9RDj+yGRoadQNwiiIa7UeUIZTINe4FyjrHGlo3SWGvsgbU7EjZYmI 1M76XToudXCAyY2yOpmSP+5wupuRuVIhJVQRgHTpHCVJqjk0lAZDbj8IXgg3slwyEv034Rve1rrX KAoyNsbgAofMbJsD+yJwadyLpTI9LnEBARzb/hRrA25B/ZGwi1nC6jiBsOFQU1vcopSD8WVNcLG5 SKiQnhVAx5HCR5sq21AbhTUBvbdHGA71WulgjRqP4TGx+Y1xuW2Rs2PGydJMyNv5QGFG1sbT3Kp7 XFSSSzvlAJD78oZZC3YA7IQRwFZN3DurLREdhdAiDYK+ATyqb6uFY2NlQygdRF9lZN+90JYS434U Y3S74QhdyBwoT2tZR10TWgjflADp02KtqjQQSDwFOHIC7BtiTa6hiaTqJufdU5odygYST3QBn02s r2cVTX72Iur1A3sFCmJK0+dsTb2RNdd+6a6Pe++6XoQgQPqKgFgh2AJuSfZRl9JJO6pQzxvyq0/7 tgrIuN7q7dufygKGxtdRxANgCbq3EAXsh1am6hyhaK0hqO4c35S2vcDdyYCD2QUDqcNlZjGxJ3UJ uShPYIUZcDZVpJHF7oXkFoF0LX6SBdAMDbRGJ2491cMWnYO2CS+dxlay23urdeJ5GrlAODhqtdGD a6SxrXbjlOaBaxO6AGZrntBYLWUDv5e5s4I3PcwWCxqqNzgLGxKGfYuokJiJSYLlmykzXNAb2TWA MYAOUKZUTvQAeUbn6fyhYPQLhQtN+NkKL/dOjFwlAWO6Np0tuFGAajToN1i08AmmAHBWUYRURuud wphrBDVR7991kHNUmW3GMSFv+FkSYUWtva4+F9Ph+I0rYQ02uQkYnNDDA4sAs4Iao+KrKUxm7Rce wWEG6SdlydXVsjFi691huexzSb8oRibqPfYcIXNsRYor7WuD7IQBx4+UTgGN3Sn6zINtgmNcXE3C AJsgI2RF5KENA4VEEoAweLq3jbYoGm4RuGoAjZWgYz5Cx9ibo2ytuLbqp2iwCUxvqUBmNPf3SiHX Khv3R+pWgdgzNMw4WBHUuinMTW7rmXARx27+y48RDztQG5XiTtHukgvMfouVweINHm78rnJZvKBB /svnq8h8+q5IVObM3CbMfdtx8rm2v1i/b3XGZfYx5df7SuUqA2M2ZwFSoWTuEbb23slNcCd9kesE KCgJ5HRtbZY87iLEnlMcdblU7bkX4CIgm92lYc4IBeB6gs2Q+nZUxge03WrBl5ckgwvEqWtc/U9r w4j2W1Xwg5jpcwR4fLBMHWjF2342WpyOmEcwlcSWO20hdu9H+vmO9HMUgqqCZ0lMxwc+HsR7L1YZ KDs82bH5I0jZD9QPIWI51yPTz0VM6oZS+twjFyF558HeRp8Sx6mYad943jVrFiDdd+9O/Hz0+zhl ZpzC6GAPjAmimtzbddedPPFR0hyX1brqugxdlLh05dpZ/SD2X1lmi40fnVhyYsjtcGwCOsoMrYfT w1NVHFsGAOcLkrzX4v8AoTDmLCxnLBoPMxCAap4oxfzm+68w+Lrx1ZYzXX4fRZRqZnz0sgfLWMNm kX4C7M6f/Uf6eU3T+CixeslqK5kYjkjewm+3zyuaaX2T5EoTnxR6G8HU9W7pZ5M9mPY4hrCblp9l 0H1YwjP+auotflcGpqKWeYnyw06A33uuRyp9S3o9l2m8mKjmooXnU4xs7/hcwfqY9GWzurIxOKkj 7vLBcfi6Qy7JN0XLintidr9Auldb0smEdTLqEsQBa3gLqLr9i+KZF66YVW00hgjqnhwkG1/hfKV/ 1Y+nr8QfFHhVXpabCVw2svPvif8AHHhHV7Gcv1GXIXsbh72veX7X34XqjPnfL2jgscsn1NqdTWHH enFVPLZz5aJ2ofJatT/R3IeK1HVPFooIXSTMrpHGzeG6tl3DhH1Ucv4XktmE4ngcrqtsXll7DcHa y6B6H+N6k6Y9T8fxuowwSYZij3PDpBd0dz29l5HJRT/5PYsE96kkbachPky7kaFmKPbD5bNT3ONg 0WWkzxkZtps5eIbH6nDS2WmbMYw9v9Vu69BeIL6opz9lCuy5ljDZKSoqR5f6xptYH2Xh+kp6utq/ 1FVIXTSkuc9x3uTdPNGMJL2zUdPJ5lJ+h4DrClh9DjYOK9B+F/L1UcephEC4se25t7roHFC3C2sk ZdzibXXYfS3rXjfTjFYMRw+GOaSIhzopBsV8yL5Ptyi2uDeb0rpJY8kU9PKPSYhz8hakfHNlbHMj ddq6avEsmF1bw6me4Xa0X4BXb2X/AKuk+DYeykxDKzZZGN0lzHWAXnDxHeLyu8RVK6kZhsdNF5ms Pdu5ovxdfc08lBScumfBzYJyyxa9Gwz6fPXLBc05LblqSaKnxWlADY3OF3hcr4vfCTN1nxmgxbCI mCrOmOpJ7tB5WobJ/ULMXTzFKbF8EqJaarp7HXG7fZenst/Vd6i4BhzIq2lhxKWPa87bX/Nlwhlc ZucGdNRgtLg9rZp8HPTTCekgGNYNA2tpaZzpKm+k6wF0/wCAbJ9864jV0J//AEZRTGOLTvtcryp1 v+on1E65Ze/gwpYsIp3n+YaUkXC+R6L+LXPPQIyOwMxyRyEOkjk31FMk2+X2axY5uNM3O+JvJk2f OjePYLAR59VFpbvyVocztk3EunuccQy9XMMdXE69j3C9R4v9VfqPmXDjh78Jp4SeZWt3uvLeac4Y z1Ez1WZixl+uqqBYgdgvFKUqUX0ZxaeUc+9dGLQNEbjE/wBQtc3XtfwKdXcMy5milw7E5mQanBrJ HGy8W09M4PebXuNk59RVYW6KelmkinadTXxmxBWYtI+zNWqP0B9TMDd1AyI+kwqoY90gD2Oa/Y+2 6PJeF19FkJmG4oLVYiMIa9177WC0pZc8b/VvK+EMw3DcUltENIkdc7J0Xji641c38/MDja+kE2Xt hsarcfGniybm6NuHQNoyg/F8sV00DZBUPlY1ruQTey53BOmcWVOpuIZkpnshpqxlnxDgH3WkSo69 9SpsemxuXMlTDXSblzHkAFcriHi06vV1IaZ+b610RFiWSH/utucHJtPhmfj5HFcG4vrBgEBzDg+b qaqgL6GQNqC6QCzCV9JnzLuE9ZsmRQQYhH5JIkY9jgRdaIa/rd1KxNpikzRXywn743zusfyFyuEe JLqllujFJS5qqGU2mwY1/CrkqVPoy8E+bXZvfwGgo8GypDgs1bBUubF5bhrHqFre60peLfo9Hkfq 9mCSORkdHPO+WFjTwSV1zJ1s6kT1TqpmcMQ82Q3v55NvjlcBjOPY/mmvZVY/jMtdMP65n3K5eSot J9nXFppqam/QFK1lPiNI9rnO0m7geF7U8HPifwbpvmWKixm0FK5wDXk2A+V4xaIQbag93Ygoagna 8Lj/ANYK8ypn239o7TfnmWoyX1qy1TkY1RVFO+0jC2Ztx/lZM2acl5fy1/p6pzBQQRCHyiH1Db2t b3Wg2hzFmPDmltBj1fSM/wBrJiAFKzFsbrhqmxusqJTyXTOJXrjTik3wj5U9LLc5x9m7Por1Fynk +rrssDMdHOwymSm0yDSGntdBmHoh0sxDONRmnFcSpTJOQ98clQ3yyffdaPm1uM0snmR4xVwSg3D2 yEFMqs35pmZomx6vq2WtpNQ6w/yteRKW6LpnknopNKLXCNs/iP8AEB056NYNR1mUpaCpxmnlGgUm k6B3uQuwOlnjR6X9Zco09Li+LU9DXSRBtTTVTg0F1tyCVpFhFTVtlmqZ5XHv5ryboHwVDGh0MxiP YsdZR5FOtx1jpMiXBu469eLHIfRHppPLgeK0WI1ckZipqelkDrEjk2WuHoZ1PwnNHWN2M51rhR0V RVCdskp2G97Ly95VbNIGz1DpmtNw17rhZzg6dohljDQPtN7FZebhxiYxaRp3M/QPh3iA6aHAYZIc 2YYKaOIAAzi9rey8QZ68Q+ROlPXeHOGWsSZXQVMpbVMY7YA82Ws00skMu1fURtPYSmyN+EeYy/65 777gFyzBqCZ6J6fe0b2KnxEdGesOUYf4rmLD3UTw2SSnnlDdLvYr5fNPjR6I9MMtVVLhWM0z3xxl sdNRM+8gbC4WkpmFPgBDqqYD/a15sUynoY/NGpznvHuTdIypV6MS0jcr9m2HpF9T/IOIxzUGM0cu Gwl7tLjax37rsrD/ABr+HukrpMSjxijpMQdcvc2Ozz+VpYq6Cnd/Q5j1gfwinNyLuf3adiVryQu+ rJLRylVu6NivjV8e+V87ZYrst5SMOKNrYjD+p0W0A7crXhgtN+nhY1xLyHlzkcGHRNg1OjMY9jus yEsbdjAR+Vwnlc1t9I9mmweG/wCzkaKqc97wQ6Mg3YWr1b4VvHji3Q+rbhGPSvrsAfsBKSTH+CvJ ksTxSiSN+l4O4JVMhOLaY2weY74C5Kuz2TSmqZtpxr6qvTagw4ujo6msqwNhFa11r66l+JzNHUTq FXZkoq6oogZxNShzjeIA7Aey6flwU0TdTqR8e3+02S44hK4GIFpHIvyvVCTimkuz570qk7bNhvS7 6slJgGBUuHZ0wWXE6qBgjNVCfU8jubr43xOfUpk6p5YkwDKWHyYdh1S3TUSS/eR7BeKhluuxN4NJ h01Se7Y2EpdTTzYJIYaugfSvH9MrS0/5XVcK4rk889Om63cHfHh18aOY/D9ibZomvqsGkAFRRarg 78/lersX+r7lyqy/J/CsAqYcVcwtHnG7Wu91rjw6m/WkCOAyA8NAuuVrcq4pSxip/wBPVLaci/mG E2Ky5OT+y5Oj08Eqs+ozp13xvqXnCbH66sndUmYTx+u2k3vsvUfTj6qONZOy1S4ZjWHnEqmmaIxI 4bvaOLleJWPZJJ5bYRDIdr2sQuTpMlYpisRfRYfNXju+KIut+SAuD8l1I6RwYoK12d8+Jf6gWa+v +XnYJR0BwbDtWqTynkF/5Xk6CWsonNqYZpoKu9xKxxBXNYtgdZhL3trWTUDx/RIyy4yKZz2FjpQ4 Di4stSc2q9G8Onxt7rtn0UfXbqdQYa+gizlXto3tLHROld9vsuCwXE8VwipZiMFa9lWJPNEjXerV zdYVJHI6oL5B5jW9rrJipnVc5c0HS3hoWYuS4R6njiuaPX/T36qXUnIuBwYRieCQ42IWhjKqQnXY e66e6+eLrPniGnAxyZ9NhcbtUVFBcNB+Vw+TehGe8/0pqMBy/VVtOP62MNlwmdsg5u6dS6MwZeqc NI4kniIa4flemO5c0eKWDFN8sxsoZ5xPJ1dBiWFxGSohcHgO916Vo/qkdVcGwyGkpIqeby2hhE7L 6V5Kinlrw2WN/lm++j2XaeTPD5nfqTSmqwLAKiqp2tu6p8s6T+65Sk5do9EowUasy+u/i0z14kqC locyRwx0tM4lujYNJ7rpGPD8QwqfzKfEZ4HO31RSlpX0HUPp5j/TjEY6PHKeegL329bSLr5zFHf8 YxjJrtsN7rM2/ZnFihCLoc91dU10ZqcRnqHjdpkeSQvvcgdYeoPRivlxDJ2MS0Usn3tDrtd+y+Hp 6XyohIZWvt3BuV2J0y6VZp6oV0dJg1FJM950tOk7rKlLg6SjjrlH1ec/GZ1h6mYT+ixrF5G0pbZ7 I/SHfldSsxWvdN5wq3eeTe9+69L5g+nx1owbCX1seGsqYQzW6KM3da3svPEuAYjh+JVOFVVDJT4j Sv0SsewgtK9dzao8ajgUrR9rhHic6r5Ww5lDQY9UwxNFmFshBAXxGcc7Zq6h4g2tzTi1TidQOHzS FxsvSORvp59UeoWWKXG6ZkMVPUsD4mSO0lwPB3XUvW7wydQ+h0gkx/CJI6W+07PWw/uNlyUJ3UTU 3p+2dTPxPE8DqYarBKuegqYyCJIXFpH9l9jVeJXqzV4X/DKnNta+hLdDo3SmxC+HdViricW7TDsj /hz6imEsklyP6V53BxfJ6WoyVofhGKYtQ1T6qgxaqo8RcdRmgkLbn8hfaUfW7rBDH5Dc9Yn5bRYa qhxsP3Xw+D0TpS51y0NOwC798PfhjzV1+zA3D6CJ1PR/+5WPHpYPkqwi+2c5KEFTR0ZmXHsx5kqS /HMaqcRkJ3M0hd+eVg0tAY47MFwNyV7C8RX05sz9FMlVOaafF4sRpaY/zmC9wPcBeMIpDOXwOqHQ SX3XXLCW3euUYwShbSXJkueGzkn8JrxqYLcJZovLLCZNbQLE+5Tb22A2Xib5Pd2ALDZWeLoCbuv3 UJNlAXuRcotOyWyQXIdwnFwYBcbKmQmsLm3Vhpdwo2ItGrX6TwjY59iWi6GiFwY0Aqnv9OyIETMu W2ISXRkbg7IC2zaTud1NZe/V2WNI0NeHPdYLKqCIWRhrbBw4QEAu66J3qKoxEx6gqadDboAxaMBN Lho1ArGla94DuyyG2c0A8d0AYHmNDrqbDkbIfM8sho4R6rkXCApth+PZEXNGzeCqdpB2UaQeyGy2 8pgNiAoANNrqcNQlEO3CpwsL3RcXuEJfqHpQJAAb3uUTiWkHkKi4AJjXAMugYst/qO1+ysNFlWgv cDfb2RmwOyEFyMJFglQt01PsFlkExmwuUcVK2QB52cgowsRkLmtYOb8p0TNEYB9k6WmAdc2JCokf ugMV7Ax+yAC7ynvaQ67ksEXJ90IDpAKlgbnsjbH5t+yExljrX2QogabO1BHB5bXAgkX904MAPYpj gwj7Bf47IEUW+rbhWNr23UDlOP3Q0A8EnhKIc29xynuBBQzEgW5UJRjgABPgcGjiyBh9IJCbYWHY +ypQnaRwjjY14uTYJZNz7XVOjPllrTyhGPJaxoLDc+6dESSDsQk0rGxwaHNu73TImlp24CyymQWa njSNKeQS78KQ20XRlu3O65s0MBGmwSnuc02QiQtNrIvNJBNlkorU7Vc8JpqCxlgNkvW5ztxsrttx dAJbGS4uPB7JukACwV6rmx2VFARpud9gqe6zvhVb90Rbe1t1UQU53dMa83BvshfFf0cWUIsAFScj 3kWu1IdKAQCeUDuNj+yCSIOYC69wgsyHyEMAte6IutHukNmBaB3Cmq97lShYYZ37JjGODrl3pS45 Q0b8KPm8xwt9qULLfI0Pta4Qkkn0nZOa2N7LE7pDLNJ3ULY9xdpaCdz7KrkEAk7K5HjWze1kuV4D gb8qUSzKY69t9lGzF7yAOELWhrbjYFCZGRybOufZKLZlRyOl207j3TDs32WK2obc32/CESkmxd3U oWZ4ZwL8qjE83A2WP51nDe5VS1zoyBeyhSOa4FwPKxpXbae4Rz1ZLgLc91jSSXdf+oeyqRGxdRd7 LHZcbVGzdzY9lnzh0hLnAhcZUEeYGPBBPC6o5Mx4ySTcf3RNNwRpVytc0jaw90QdYAd1tGStBtcC yjYmuaQdijdG4WNxb2QG8l7+laAqRo2+EUcYte9ijIYNr3KqO+6AsH0ne5QuaWN1Am/wj21IrAcl AKjleW7omO1ncWKvZ3HCvQ4kE8BQF6wOEBeW/aLXRWAHCEjVsOVQEHEgEmx7odAab8qw3SN1DcC/ ZASwvwhleeOytxJaNPdCAbgEoCWJaLprQQhe7SQLKPcXWQFuA5SnP0nSjubAFWWNJBsoC2EOaAAr IaLoWN0uPsVTxZ26oBjb5buNire7SCVJRsCh+5mkjb3QA3JF1RId8FQscqAtcd0AZLC290mezgLD ZCY9dwqZO0N0kXKEsWYgQTfdDYbb7pp9Tu4/CF7QDstGRZaCqdsLX2Vk72QvYdYG5CjAYGwtsrLN R3KP0hlu6VDdzzfe3ZWgGJCzYC6F7g8eyNxaHWIKCWwbsFKAAfsQAi1XG4Qs/smjcWA2SgDHsdX+ EwjzRcHSVQaOFbQASByqWgmWDbO3ULxa3sodlQAN9WyUKCADgSsWWNshsRwn20j0lVoNvdBRTA1k RaNknTZwTtGxSy2xvypRASAdxsqawA6u6ZoHfZCG2CoCiFy4W57oNbYiSd1Uj3jYDb4SpHNLRblT sBFglu4tAv7I2NDONh7JLSb3ubI7h5JG1kQGaiSN7Jj5SFjFrnObpG3convtYcqgcZXAb8IIyHE9 kBLiArijOq/ulAdEwGS+n90/Rd/4VtGkW/7KiSDtuhUWBZ3KOJu5uqa4X9SJo/mWGx91lmhrLNG4 Si832RHa90sktPKFoLYj5UY1xJ9kTGN5JVtfrNhwFlkCDBoN9ihhkDLh/PZXYA3PIVnRKNxulFoC R7i644VC7nXKZwNICEjTf/woQmoN7cqx6jbayg3bcKgTGbuFwUATrtbzsla7m3Ca6zxts32Qua2w HFkAEp3BA3HdFEHTtJcdwia0XsSq0G5DTYIAnAgc8INRH5Khu0W5UcBdtuUBbvS0HkqXublU6J2u 3ZDKTE5t90BkMIA33S5XNvwoD7KPAvugAB7go5bOjA4QBu/CMBp72CAU12gAcogQQT/hSRojdsdi ia3bbhWwVYuHOyj2ayN7W9lALv5si0qAULja6Iu/sm+SCASUD2kGyAXYItWltgFYNuRureCGlBYL QABbursCUNjsiD7kXQFEWIAQOZd90xx0uBKEHexQDGO2skHU55AROuNktgcy9r6kAeryd+Sia8yA m6Q6KRp1O3Hsna2loDQgKBABB3uhIBHpH90bgBZRrLO5s0oCNHota6sbDTp/dG8lrgIwCnxM802c LFC0Y2oX0oXFzHW5TJg2OYtHKsNDtyhBBJeL3RE7bhXpuTbayt4aG7G6AUCQLhQDfco2x6gLIXAt cgDbzZvCBpIEpJ4GysElw3Qua7Q9vugoOEPdANZvdW+MNasCKoniOmx0rIFUJY/Te45CFoc3YWVm MlnKCFzXfdyi1lri0j0oKEA72PbumtHcFRzmtBHujgiD+90LRV3OBKQRsSOyyns8t1uyWbNQlC23 0XsoLk37Iyb7Dj2Vj7T2QlC/vcN7K3N8w2B4SNTnPIG6fE0ttf7kKiMaQd0RO9kL5S13F1TJQ477 FChON9hshDbn2TGeu9uypu5IKEob6QwC+pC5wDdkp3BskhxsTdBQ+R2oAKmRuJ92oWetvqNvZGJx Ftz8oKLsWjcpD3P1i26bI8vt7IQdEgPdAHEHP2IQyNGu3ssuKoY64IAIWNOAHX90CEmV2sNDdvdM MIfYk2Qtda1tvlFICTpad0KE1ojFmjZUI7m/CppcHFrlYBB5ugYWtkdtZ2OyBwa15sqfZwAteyqw G6EQQduiEZaCeUrUXOuOEx05jabcoUu1m3P9lANQ+VTJfNZvsruLek2QCnA8FG0aTyrLQ5wumMa2 173QCZARe/dIDNRss17b9tkp0ftsgAYA4aSiijEV97qAFva6sEuNrISyNduTdW1tmlx3VHS02Uc8 lwaOChS43BwJKp1xuEX6csHN1TgUFA6CVegfurFwLlU1oc4m+6AAN7qMj2LuAitySgGpw0tQlEbs NuETAAdXPwgcbN0kWRs9LbdkKyBvnHYWCB3oIb7JzDYFTQLEoRA8AKiL/lW70i6ESW3shQiLD3IQ E/3V3LjfsqIu/wCEATW6rkorFrbDcpbpNLrDcJwu1gcgF+kD1c+yjtJFlNPmvvwFTxugKadKQbtl vw08rIaLgqBjbXcLn4WkAgdhso71DdW25BAGyB1wD2RsFizPlEw3/KW3m6ZGASTfdZBJfTHf/Kwz C6R2tl1nmxBaeClRkXLW8BaoFsiIaL7lWYS125uCmyStZDdrdTh2WCK188lizRZZA2WIi1ksuDXt AFk/UHn5SnAOmHey1QQ8PAIFkqRt3XvZFNJ6QW7KrhzQTygADbO27qO5DQitsCqI0uH91kEcyw+F L2bsbhFIXarX2VbWPsrQA1bltr3TGRX52IVNseBujABHKgF6wyXT3TCdLSe6FzQDccqmMdq5/ZAX EHOFyNlZsX7BNANiLWQuItwAfdAKkJH3IXlzWj2KMu1scH/ssZh1NPqJ37oBjfSN+bphIa243KUx pN0QbpAPZAHZrwHHkKzVlvp0Aj3SXk6rBWBblCMPU6Q/CIiwPuoduNku93WuhQhcN9lCAbdygDnG 4ciYwat0AuUaRa10UZ4BFgmuDT+Us2FzfhAQs/mXI2Rtj1EHsq1EMDubqCQBu2xQFzQ63C3A7ofL JNgdx3RMkJG26Y5rGjVxdBQpxLGqo7vOrgIXuAJsbhRj7BAHN+EDQH7Xv8BEXtdYG6CRzYrEIAyw 6SAAEIboFjz2Ktp1gkG10TALeo3QyLAfHZ54CTLP5ji6+yKZz/M0W9BS3xNILBsgsOKSx90THep3 mbA8JMUL9NnHjiyIuLiGuHdC2Nt6hoOyqosSO5TmtbH9t7jlD5Vzq7oAWegb7K3Nv32Q2Oq53t2Q gOJJvshQQzfY8IywFwPKvyg4XaULbgb7ICvUXEdlGj2N/wAohzzdWCGlLIwg5pI33TNYcC1JNtah fYkH+6EEuiLS4DhKLC0g2ue4T43+bLYG4ChY4vvba6DsoHyw023+U++o3cOUDwbjbhQktbbkoGR9 4yAy+6GRutwsblQyu4LSow6HXHKACEtbMSQikLdd+6c3SXl1uySwB8iANm43UewECzrKy71EcIbW KAmm+3cd1b7Wt3UvYqSWAuOSgEu5sO6p0TjsBdE4eW0E7ko3O8qMH3WgYVZTOewBnpcOVUN2RkHn 3WUSban91juu5x0jYpQBilcQW33KjiRcEglR7DGW2QyM3LjuhAGj33IRBoUa8SDi1lC03AVIxcxO r0rJjH8u53JSw2wItdGD7cIPQku0PNkRAIuCVH2JVACyECN1AHd1A2+97KwSPwgKI3Covtyrv3QO 9RtZCobs5qoAH5slE2cAmtPwgZCbKm2G991HutZAd7XQDdYFtkJJFrBU9zWt53Qvk0AboDIYGlu6 FzQdgEDTdmrshFS1+w2IQAvDWvQMlbKbW3COVtxqSoA1lzflAjIuqtuSoN1OfhBQLnWsSNlfmNFr cqBwvZA5ga4dyg6AdMNViLlNtwqOkOta7lQJB3QdkPKrWb8IiDYnuhcS5tu6AslvKxt3uNhZPa0g epWRbhBYDLkjsQETCdVzv+Vdh2O6sC6CwHAjcGyOJ/c8qNaJHWOyqSNsJDb3ugsdr1d91CHPPsls Aab3ujM5e3YgAIBT2+qzhdMYwX4Q6yLG1yiElza9kALpi12nsjLrsS3C7j6bhRjud0KVK90cRvyj hcHNaD3VEjTdwuqtoALVGUymBu4Bslui8uQPvxwhbuL3sURBLSCbrIDhxN7pCNViEMuO1UpMZ3Hu sOBnlTknhZR0PLi0W2QWYVRI99i433TGyFhG21kEl3G1k2KlcRclATzS7bkq7+XsTdQ07b7HdQRA O3O60CpNYAIJF0UIfe5Kvc31cKMYXv5sFKA391RBAvdWW2PKEg2tdVAoEt5R67KNb7pbwb3Rgt9n hBGBqsFGu2I+VTrtO2yoHEEuAPZCW7ndWx5vud1CzUb6rXUB2RM4lx7rGc51/TsnOaTztdIdz7Fe FKj3y5FzMLmkk3K4OpYWyG4O656WQNIHN1h1DWEnUFTkXgBEOzhuSuZlaHv2GxXFUjo2W08rPE5d YW2QCyy7iCq0HV8JzhfhLJs7dAC5hDgQqkBed0wlA/f4QC3M0tsOUqxA9lki1kiYdwhLLLmiMajY e6WDUMd/w4dMHf0jdYE+qsPkgkG/Zd/9AuiMubpo55L+U0b7XXeJl17Ogaljg4l9NMyQ8tbwsJmG yFkkpo3FvOviy249PvBhk7GcMZPilCWl39ZCxMM8KnSiqz9LgUToquVhs6FsnH7L6MNO5K7PFkzR i6Zqap6mla8RCF7pD2tus59A8kOlo3xnsQwrax4hvAblDKuXabGcq4Rpq4SDNpF7hfb9FfDFkXOW SYJq3CI3VLWhrzKwbFbWG1u9HllqYJ0afKehdNHpbSSOPZ2g7ozgc0DXOfRyNv3DTst2ORfDz0lx TFKzDYcKp6mrpCQ8aQQFyuYOj3RDLmKQ4bi2GYfFWTG0cclgUeNKVLkfKVWaM4MHjklLZYpJD/t0 nZEzKM1bUCOlDojfcE2K3uO8IPSmqDZ4Mv04D9w9liCurOr/ANP/AClitBNiOWY30eIRDUIdrPt2 W4xxydWYeo2u6NP+I5NrcItJPTSStAuX6SQsjCcj4tmCmdLhuGmtYR9rG3stzXSPw/ZNzHkcYXmL LEbK2nYWTFzbFx97ryBk+ry50b8SWJZf/Rsiy4+pMThJywXSeG21H0dVrItdHhHEsErMsvMGJ4TL hs53a+SMgH90VHXRS0xbLJZwOxC3g9SPDJ02645Cc2HDYHvkjvBWRgamm3utPXX3oJifQXqJPhFa 7zaZ5L4H9i268mTA2t0TrDVQun2fCveyoa1rjqAOxK53Cck4jmueOLC2OmmkIFmLgYGtkeSLC24X aPQfN4ypmeAuGqN0oc4/C8Lbij2ydcgDwqdSjEJP9K1UsTt/Ma0kEL57FuhWeMstkkly7XQxtHqc IjYLex0WzBh2Yco4e6kYJI3wNc4uaDY2QY7njKpzWMtV1BTzVL9tL4xY/wCF9HB948o+bl1LgzQP gmUsXxTEnU7ZJIn6tJje2xuu2aLwY9Q8XpG1lBhUlQx41Nu0hbQetnhDyzjuZ8KzFg+Hw4fUNkBn p4GWbJ8rs7PfUXKvh3yHQ1+PhkFKGNj0tbuT7Lu8UaTjzZxlq5STtVRo4z90izr0tYDj+AzUcB28 7yyW/wB1zPS3oBmbrI8NwKOOeW19LtluUZmnpt4j+n1Q0U1JX0NXGWaZQ3VGbc/C8W+G3GcG6FeJ bHcuSOFXhjXE0/lm4ZvsFfGmrSoxj1bPN2ZvBX1dy3Svkdld8oYL3hF7rozFKTFsrYo6kxzCp8Mq GO0lszbXK/RZWYxFV5RkxRsQ0+Q6VrXAG+y0OeMHPFR1B614kHtbFT08xaGMbYbLPjc8bl+HeGoS mofp8HHibHxXbzZKgxCN9y/1t9gijpIqKJo29TbIsvYKJK973vAhJ2aV87pn0m0lYPmxWL6UEHuC kPqptTXyRuLTtsvWnTjwJ4l1XwqCto6z9KZm3Ywd1hdTPp79RenuGTVsTDiNNEC4hjd7fsvUsG5J 2eWWZRZ5gwuJ9VibY3ktik23PBXqzpj9P3HurGWo8UwbGoW6xdzHdl0Fk/ImKYlmuGiqKeSORj7a Lb3W1vwQZDzPkbAKuPEqV7KSoIdFI8kaQu0cTxq2efJnVXE1o9cPBX1H6ExyYjiMTZsNbuZo3XC+ R6L9Oh1dx2DDJXfpnSODQ7/ctwPj2p3Vnhvx9oaDNpAaVr88JHQDMmaMewybDI3QOhtI6ciwBv7r p49+Pejzx1X22s+1zB9KzHo8IZW4JVCSR7NfludYleIs+5CxLIOaK7AMaidHV0zyyxO5X6Jcs4fX YXgNLSYjOKioijDHSN72C0r/AFEsNZhHiPrmiw1nzLj5XPHj8kJf0dvkOOSMf0820dKBBZrjdqyP PIvC2bU93Y9kylbHFK91juCVm4Fgz8ar4IqeIyTyv0gAcrx1TPrOXB2z4eOkOHdT8xQYRX1BifM4 N1XtyvWeaPpMtmw+WowbMnkzCMvYHC4JtsFxvhX8JmaJMUpcYh1UTWAOMrxYC62R5awiqwXLxp6q oNVM1hGtw+F6IfTk+ZkyybpH54s75Vr+nma8RwLFNUtTRzGIvHDrG11g+dE+DS0mMnm4WwBvhaf1 48QWY4nlsdJT1LnTSEcAld4M+mH06giAqK6Z0pbuSBa69mXFHHKmzhg1jnG2ahJTFWReU99iP9uy qSURQNibGSBsHuWz/OP0tsGpMToqvB8V/wCCMg84adw34SesH0w8o4bkOvxzC8cqYqihgMwbI0EP sLkLk8UaTUuz0rVpOqNY5axjGuay7v8AcuQwPDHYrjuHQPN2yzNa6xvYXsvf/gp8IuU+ruXMXlzD TOfFTvMQLDYk3sCvjfE34TMB8OOf8CqMIqZZqGvkBDJT/wAvfdZjiTlt9l+TFqz0R07+n10xz9ka inqYXirfC0ySRHcEha+vFt0Cw/w+dVajCcBq5K3DbagHuuQfZbkOhOT6jDsh4TWUOJCaCrpg5wBu Bt2WvnxOdHK3GvEucOxOUzirkbpBNxZxXXDBTbtnhyaiUJI8LNFRUR6jTO/twqqKdjHskkE0Lh3A 2W73I3gp6Y5fyvSSYvg8E8/lB0ksmwG3dVjHhI6MZ5wmpoMPpqBpd6dUL2lzT/3XCo2e56il/ZpK ipH1Lg+LVKPeyYcLJd5joZQ4dw0rbX00+mjlPK2ZZq3E6g1uH6iYoGHYi/dd4P8AD10oweqioX5X ppZLAAui1f3Km2FmPk0rZoZkqmmRsbwWj/qFk5rHRyFzyPK7ELbb4tfABk3PORsRxbKdFDgGM0kL ph5TbNeGi9rLULFT1FNilRhlS/Uad5ic4dyDZSeNNbo9HTFqFN17M6nikr65sUdywm11sZ8Engpp 8fgpM0ZihbJQbPbC9v3d14Ay3TmOujYxurQ8Ov7i63r+FeanqOiuAvpxa8IDhbg2XjptnbMmkYOZ /Dp0ixWSPBq7LOHsmnaSyONulxHF9t14o68/Ter8CzTDWZIf5mETygmCQ3MYvuF63zt09zDjXW+j xPDcUfFFSgOd67Wb3bZd+yQj9LGJfUA0XcT3X04y8KXtM+EpyyOSXFHQXRfwx5H6O5KppcYo6Wes kiaZqmpaPSbcC6x+rfhH6Y9ccrTtoaSnirwwmKspbXv2B7LsjrnlCTO/TyfDoag0zCQS9ptYflYX h+yL/ozKsdOMQdXNJ3Jdqsib2+Xdz+GnJ71Cjyh4Y/AG3LmbKmtzpSskpqOW1NALESAHYlew5sAy DUVjssyYXhfmCK36Z8TblvwvsqaofPXVELo9LWcOHddD4v0fGaesj8znHjTfw+QOEDXfd8H4VT8s nJ8UMk5wSXZ5x6//AE6aeXN1PimTYT/D6ucGeDa0IJ3t8L1l0w6QZM6A9OY6V1JSMa2IPqJ6hou9 1t9yu1qqqbS4f+ocQYw3i118N1nynRZ+6fSRVVQ6mg06tbTb+6iyeVxhLj+y/aEXK7Pjc9dCOmni TyRUN/g9E11QxzIq2nja17HdjstNPWXw54n0g6x1eR6qZ0zhL/JnHBjJ9P8Aiy3jdCsmYZkvJ0FP hlWKyHc6g7VY+y1z/VHpv9PdZ8DxOmb/AD6mBri7jcFemDSnPFdpDHlcNs/0fkT6WJzt09pcZ/1A +jxCZmtsenZ211150D8IjsY65VeUMUnEsWGzHzyDubFdk9MvqbY3kLKFBg8+WZsVigjMbaiNhIFt huF9B4KOo7uo/ikxfMc7fJfiTC90JGnS49rLypOm2j6MpyfCPeUNPk3oHkyKDRBhlDTsA1BoBcfl cRnnIeSfEx0+lpKmODEKWriPk1DWjXGfcFcv1yyrgmZsm1LMde2OkbvqcbKuiOC4NhGSqeHBJPMo xcNcHXWYpLH5PZ87I5vLs9GqfLngmxA+IKoySA+bD6ecl9Sxt2hoO1/2W3Ppx08wnpnlChwHCaWO Gmpo2scQ0XcbbkpmDZWwbAMRraimZAyuqX+ZLI8gyG/uebLkKeCSXFnTsrw+FrbOp2m+/upnyeSn FHXFuj9ZcmtL6vGD0TcVyiyKCKOSbUZHNAB2/wD1C6k8DXhBwbxBVFZVY04/oKZ1nNadyvXn1OOn uB41kXC8yYjM+PEKOQw07L+l19zt7rX74e+umfukuLz0+S45KmZzh/w7Glwd+y9MoKenUl6JgzPy Sgz0R4vPp/4B0goKTMOVZJW4d+oZFLDM6/Pde2/CX0Iy/wBKumeG4lTwRy4lWUwnfUubu0EXsFrt 6reJzq11OipcJz9g1Rg1G2QSj+Voa4322stqnRGsZi3RrLMjb6X0LGkftYrxSvarPU7VqR83lbxC 4NnjPVRl3DqeYvp3GOWV4s3UNiAuBz14Ocl576n0GcqukjY+Ef8AEUjGAMqTe4Lrcocv4rkPAOrc 2X6aOOPHZJdZc0WJJXdmNCUzUrIJPLJcNR9wvVlficfHxaPkYYvLuc/0+D6v9SIejmTIZ6SiOmMt jijhZ6WtG1v7I48PwDxCdL2jFKBtZQV8FiJ47FriOR7ELG8QGO4NgOEYWMwwCTB5KgCeRw2b+V9X 05x3L+MYHG3Lmn+Gxj0eWLM/Zck9sFNdndwcsmyT4ND/AIselNP0V614rgNASKRj9TG+wK6wpoZD reXEtAuQvTn1JKF0niTx6pcNLDoY0jubLzpDBWxUbyygqHROHqf5RsF6dRU2mj3aGW7HTfR2x4aO gWOdeM30mHYZEY6XX/OqDwxt9yt13SDpPl3oVlCgwDC2MjkLQJJiPVM/uSVrZ+nX4kcj9I21tBmB whkmG1QG2LLLYHl3xK9J+p2M08WH5kilrqd38uN92kn2t3Xz5Sb+p6cyX8gfGFhMmLdA8zRRRmVz acv0gc2WgGuiZTZgqRMwtdc6Wr9HXVDEMNgyBik2Is87D3wOEjR3aQvz9eIOXAf/AFTq35fFqBsj ha/Buvp4nekca9nzINx1d3xR8VFK4vN22+FkeYUiKoE4Lmi26NgNieSvhs/Qf8Bi11ZF+yjdzwrC qIAadr/6rLIp4W6D/UB7oBHqePZN0lklgdj7Kk9hPcJBYCwHZFG4WsdkBuDtsia2+90LYwMDQbd0 p8gYbAHdMLxaw3Ue3Va9kBgzxea4AjvdZUwMjo9rhosFYYGnlE3079kBcrHaQAEvRpHqCyA9slhe xSZmWueSgJE+7i0j0qhe5sOFB5lvS259kDal/mWdGWn3KAYSTa7UW4t2VCY73CKOTzDYoBgGrcDd TSL37oz6BtyUuSYCxO5KGkFsLI77BKbvyUx/2ABCkuoTYbBW0ttvyoCLIBYs37hsUYADdVtuyGS1 x3REnTp7KWAg9rPyUH9Rui0gWJ3I4RPOrcjdLAcDg25PCklWD/LYN/dB5gEZt3SIw4HU3kJZaMjW Ts/YoXi7kULmThxkd6+wCuTS1vIv8IQxZib27JZNjsLp050sulRguFyFGA4dibqpSdyj0bGwWOQ8 u34WjJGyHVsFl9rrGazSn32Fr/KjLZC25uOEThbfsrBFksF5fYj0qCyElxVG5/8AlW/+Xewulh4d xsgst+1lVwRzuppuNwqsHd1oWEftRtOyo8BTVsEAxryDumB7XXaXEFID9XZE2wN+FllM2lk8kEE3 Ca2QON78rGYG6dhe6BtwVminIAEH4RhwBI7LFbPpIB9kzSHkG+6yBhGw7ISTeyjRudRU2O4QWUBd xU0ajsd1cekk3NlULvMc4DYjdBZHNICJr2gA3Va9Q4QFoDTfhBY4P1X4QuZtdIbdtjdO80EWKpAH Mba4Qabm6Yx2kkW2Q6gHcKADygN+6W8du6c3cuJUcwGxG6AxHBzW/KAF5OzrBZsjAW3WG0tffSQS qRhRkskuDdMkm3uNikABh3vdWLOPKUSyvNdru4klZMbwQSdwN1jtIY7cA/lR9SWuAA9J5ShZkCuf L6W2ACt8jWNBvd3dYTyGuLmf4RxkOaXEmx90oWZcdSHHVv8AhXHUXl32CxGzW4VsN5Lu2Uotma6p aHXBSpJTMdQ7LGqpY4CAAXE+ytr9AB9+ylCxjnucLOKsubEAbkpLpg43tZJdNd1t1pIlmZNUOlaA wIXSNlaA+MBw72WO2pMDrNHKks+oW2F+60QTWtNg3t2WPomAsxodbhZRnaW6XbrDdqa/0uI/daRh ijU1EROuIhMgldINRBb8FZLZHPaNW5+VQu51rKgRYCQOI3TnN0+rsqlju64Rt+3c3QosHVuAja3U L9vZUAY76eFRv+6AazS0WARm2jYbpDHkci5TC64UIC+wSm2vdU77zujawlmwsqCN3O5Qvvew+1W0 gAj+pCbhlzyCg5JIHtFwPSpu5t03WZWWt6UBjA44QpG83Ku4PG6Akg24CINUoEv5g9kWqzbFDY9g geb/AAR2VAZkH9lIv55JO1kJsI9RS2z3NmhAOJ3srNnNAugEjW/c7dLEpkeLCwQgxw0m90pr9Tie PhP0hpud/hYshPmmwsD3QlkJvffZJbE1r9V7hMa25NuELmWaTeyEKLi47KeWT3SG6gb9lktHoCAE BgB91XnWba2491HBrBubpQkM2w2WgNI0sLnA39gsbDPMEj3PHpJ2umME0Ty/7h7FXM0vaCDpKAbI 4F91NncpAeLAE7psTxdAX5Y1K9Psi3JKWDpJUsAklh90xwuARsVLHZNMfFyrZqwCLqAEm7v8IjGQ CgLS1LIgy0aVUcOo3aT+ELXaCdSuHVqvfa6iNFPBa7SdkLjoadth3KbOy7wSseo9VgTsqZZQN3AH upI2x2KuIDub+yIglhCEMIF+o77JjIG6S47/AJULfWbohIGDS7nsUApvtayrSReyY4arW3Uc/SL8 pQAi1C9ybIgwi55Rf0A22U3sHdkBekkXtwijfqPFrKg4m3YJjIydwgGxyAuF+U4yhoOkXKUGBtiq 8wNvcIVDmEafULlVNINB7bbJYPtwrc0OHO6yaCpb2s48pzmhpsRdXHC69rgWQapBJ62bDuhoIMAB IP7K2jVuNkLn3vblW0EtussyE61lQFt1TX+4VnbcBU0CbuO3PZGRYfJUNgAR9yIO7rJkDdosqeXb XViQyE9iFTQd78oAQSFVg5253RkjbbdUznhAQkB1lbHOa+54CuzeSEVhpuShaFve4u9PCjrBuruE MwOn0bK49hvuUIGJy+26Fw8zY9lTRuTayEP1SgboBti07G35VsOu9wqn2cAUNyBwgGmI6TYpYYAP lCJCBzsibIHG3dAU4AHdU0PJ2+xG5zSOEBe4MIP2oaCcAN+UPmEJLajUbN3Rua72Qyxkcms2JVuf qIFrWS4mlp4t8pxIdt3QCi46uEw6XDndLIIJuhcPZAXI4tLbbpj/AFWISrG26vVYgWQBus7neyrn siAABQ9rjhAA5wDioJDGC7kKPIAPug1eg77IaRYqvMuCNimRgRg2HKCNrXMudijDbhDLKc6yhtKz Sdlbr2AtdDI2wACFSGQn9MzkE9iVUNSY3lzt0Bh1MvfcJMkLrAhyDoYJ/Okc+2xTnP223WOY3AAD lEGSWO6DsPzbgtA3Q2I3KGGMh9yU0OD3kcD5QlA6i3gow8HkJUg0vsCq9W5QDGAOf7J80baWnMsh +VjRgtcCbhHjMn6ilDGndAVSVEczGHyzueUUtIzzi4ehvsEumfpijZ7BHOSTe+wQqAa0Amw3ROkL 2lpFiELH+q4CbGBuTyUFim+U4APZx3WVC1sdy3gpYYCUL3Fp2QoT5NVwd0uxO/b5QtJ1HUrOtz/+ hUWDoId8K3HQCCo8nVbsEEr7D3sqAmvjjF/6inXY4g91gOcHuv7LJDbReYOFKBZA82/ZMEbHDZY0 c4lFwNkyOQOFhyoRjraAbbJVzzsmG+k3/ulFwQILTpFyLpbm6RfTsU1r2uFr7pVXM9lRC1rbxgb/ ACgbKuLewSHyb8XssszsmNtNkBY1p+CgsGI62B1rfCezTI4G24SbEcD0ohcC4QthStBlGlVUHYG/ CjTY/JSZDqvdB2W0/wBkTHBsgNktpuU1rN0FEPqk/JRf8p2+6Ev0G4FyqcTUO1ObpPsqCPPr24Kg bfuqJ5ASw4ucQnAGwn1Fo3KtrTCTqbygAEfq3LkbnFw1Hv2QA3sfhXcXsNlDYtFtvyg1h0gaN/wo BpaGNJuCpHMHgAbFKA9ZCJoIPCAyNyLE7JZ9L9zt2Vkk2SZRc3BQFumvIRwExjS0FwNysQNLngnh ZjLllhyhGLe0u3KEMc7g2t3RSXabFE1t224QWU8SsjuH3Uj1adR3KM7Cx3VF1h7ILI4bcoAC03KN 7tLBYF1+/sha8i+17ILCdu4BC4OY9paFTQ4Pa9/2rlY2UVYGa3mMjuELZxjoy6QXHKmkscdtl9kz CcLjo9Qqmvfbuvl6qHy5Hlrg5oPIQGITv7Ky+wtZCQC654CF0g12/pQFu4HdAQAQSj80A+6G3O3K Bhg6tuyotDWqmvAdpPPsicLoBIZZxPYpgc4t09hwFLHSrbdu6ACAuOoO2VhtnEEojvyhde6AsWCL VvtwhcyzbjdQBVMDY7kbbo3MDRflKY7QnB+ohQCZY9LbqNLQ0bc90VRJc6bbIL6mgBCWVUPEQWOy WxJHCdLGHN3WLYtfa3pQWZUP81/p3CfLE1rTp3esamGl2yeX6ibcoUQ0EC1two0+q55THG7hcbhC bDdaBZAJsdgo2MA7FQEEWJVtOrtZTkEfYBU03tsiLbKn3FrBQAPN3Khc3/wjkbYdkABHKAq9m7I2 N9PPKD9rIgACNygGBpt7qzttwq8wtde6jvUdV9kATpSG83KDzSTwCgedRFirJEDbHkoCSu9JA5WL FsdPJvynuPmN9PKoRlo1d/hAMjaWuIKY52kIWkloJO6Nws3sSgElgBB5JRHhEwgu3CW93rPZAS9y Ugscx/OxRi5fymOALd0AuMFryTuOyKQm+37oWvLTsL3RlpPyUJZGu1Rm3I7oYWtkB1dlCSxhDRzy hp26SQTz7oUJklgWngcKAC9nbBUIvLeXHcK32k/CEoZGGwXI3aqmcKqOw2AVOIcAzhMEQ0Gx2Qcm KB6Q1MuL2Q29RI7FR5G/uUIMuGMNhf5KVM4eUAe6jXi1iiexsjQAgFsJsLFFPew0glFYMaAgdK5p sOCUA0P81oAFnBLu25vz7ow3UNjYnuhLQ23cd0LRAQB6d1ATqDrcKgA07KXL7i9ggot0xaXE8OSj UFp+FGAiQ69wgeCDYC6FHsdc6hwU4Ma9vNkMLbQ27oY2h9wDwgGNaGgewS5T5vpaLFMawBpudwlv aSb2QFNYGix5VsYHXDlbTfdDIQXixQyHJH37JLWFx3BAT/NaWndSR4IbpFrIDGEX6dztPBRMlD2u YdrboifMQnjS3Y+6oA1u1FXE1wde10bbs3cLIfO1NJb/AIUAxz7klwSQ/U42GyNkw0cX+VY0OkFu LIAo3AghLt5RJTNAYdrqneon2CAEPY4G5AcrAtZYsob925Vtqm67Dc+yAymuaDY8pUz/AFDSVTTc k9ldrnc7ICNJcLndIrpCIu/wsgR6Q6xWNUNIDGk3CtguGR76ez+ANkkPNrIzcDvZDYjj+ypCyqF7 87IS0k3JRAWNwVQWGgbgKreq6vUgfsL3shGEACdzsoDpNglm5A3Rhw9t/dBRbhf8obWCmq/Kl90K WB8qONgAFZNlQdvwhKKvshMgtts4IuVXli9+EKkA43/dNiaShLN73RBwHCEYMv3C3ZVw03CnD90R IJAvZAmUYG6bndR1pG/bsOUyQ2aEDiA2w5KAXqu0jsggtxbdGRYboWbP+FPZUOsPtPBSXRhhsOyt 0tpLW291Qdd1xuqUa06hsOEDmgclNYbNO1kDmtO6AVcDfsqu1zgAUJZrfpB2VSR+VNp5FkJY8Hy3 XI5UNnHchV6ZGAF23sge0CwCCxrWbcoJDYi29lTWnTa9kJFhsd0Iy3Ekqw6wQi5G5sic0aD7oQrU CoHEH3CJkbWxAn7lTeCUBLl3wo1gaS95uVYsFDZ10ALXc7KiWtJsr3fsEJjN7oAvNRMDXbnYhVpD Xb8IWSNubcoBrnhzTa+3dLaA0391bZLgi3KIuDRZAC4bc2CNhAAHKB4BaQowEDYXQ0hgjLuEy+hh vyijBMdxyFjSVIYeEKW942Nv7oHSWG2yYQyojBBskvIcC0DhQAEGR43WXO/yIY7epxSYYtFnHn2T njUAVAU4g2HBsqc0cnhEQDzyodxYLQKNmC9roA8ufdo2RXDhp7pbyYr7fuowO1EqybBIie50gFtj 3R+U4k3OyWAy+x5Q/dsCgdG4OFtwraCw7cqMEDTci1kJcdQCc0axvt7qFreebKABh1OKolwKMNIB IUDiRwgOxnOu7m6xpSXOIsjLtyO6Eu0heQ9jMeVuoW9kp7dYsRe3dOkJcVGWtuLoZEQtL3C2wC5W JmmK5/ssJkbWu2/ws2Eggi+yAFri6+yGx5sit6zY2Csj0/CAC91OUWmzbXSHFwPpQDHDSL237Ljm ySR1gL/+XfhZD5JBzysapDpRbvdCMyYGtiqZZ2jm1lsF8H74JMHoBoa3zAC4W/uteEL5GyBj9me/ uvcHgyzZQOfR0E1QyKYO0hrza67wXRzn/Fmw7qdNUYH0Pxapwj+VWspXPY5vINlqk6P9V8fw/q4M Xkq5Zanzv5pd33W3/F8Jixjp3XUQ0ymalcxrQb8t2WpPJ3SrFsv9WMSwmuo5Y6h1Y8x3bYFl9l9y Mqh9T80908rUjb106zfQ9R8oUs7wx75IwJYib9l8X4gc30vSPplibsLZ+mqpmkRmMWsT3XL9Gss0 HT/JNNLUyiKUxB0jnmwF1Oq2TcH66ZDrsNpqlkkukuhkjcDZ44BXPHxP7fxJnVR47POXgjxyfE84 1lRUVD5JZ4yX6jfUSu7uv3QfC+o8gxl1Z+mxOjZqju6w2C6H8MmT8WyD1KfhuJRfpZ4pC3Sdrgd1 2f4v6bNEdLh8mBz1DGTHQ5tP7/K9clWdbXVnnT/1XJHXnRTqvmbBc/QZersUdV4eyXyWxE3svYWP 5xwjKzKb+KVDadtQbNL+F5H6Q+HjMENfQ5kxOR1PLG8SAP2c9dl+L/Damr6UNxSnl8o0Ja55HIC5 5cUZTirO0ZqMdyO/aWCkdH+opWtLJRfU3ghad/F/SnB/E5i0cRsx8uvb2K2QeFHO9Rm7pvC6omM3 lbMkcdyF4Z8cOQZo/Eayp1am4i1jWhu5ut4V4pTi2eect7hSPXvgqxOafI7aWad08WnU3Ub2/C8k /Vlw2OixfB6tkbWveLBwG69ceFfp7iuT8Ap5653kUxaCxhBFwvIP1XM44ZjOZsJwuCZkktMz1Bp7 rksiUpSftHeSucaPBmHPLoHSub6dNl9HlI/p8bwzS2wlkAN/yuAo4nNpC0bF/b2X12TKQ4jmXDqR g9TXA39ivjSpy4P0kX9eTcL4MsVacq/ozuY4hpJPZfX9WsxdOumWNQZizTpgr/uY8gklfEeErLVT QUUMtiIjEAXEbGwXV31M+mGYcwYJQZiwqV76KgaRNAze3zZfRxbFJJ8Kj4WqUkrO4cm+Iyj6v5/o sPwIXwzTqbIeXD3XWX1TMEnrek2GVcLiY6Wcl7e1rd15j8BPW/L+Tc/00ePVraVrwY2PcbBrj2+F sX6/dMaXxA9LKnCqSeORlQ0SQytdcFdnKKnHbwkc5wlHE21bZoywbPmcssMe/CcZq6GnfciKEnTZ dxeFnMkmKdQ2z4jOaquncA6aQb3v8rYj0Z8EOV8o5cZDmfC6fEKwEN9bRbSPleX82ZAwOg8WzcGy jSx0FGx41wQkHe6smm+GejDKDiklybNMPhiOQIY+YzR7/wD8q0AdaonTdY80sYLWrZGtJ9tRX6B8 Kw79DlSKll2tBpcHDjZaUPHF0hqulnWOpxGIB2HYlK6RhB7kq4nWHIjg2lqYtnnyunlkfFAPuG11 2h0XyE/O2cqXCwT5TR5sjvgLrmrY1n81v3kbXXafQTPkOUsxQVkpDS4hj3E8AlfGr0foOJI2x+GD pxiGWqFuLVM/lYdDEY4oydrW5Xe2DV9FjlJM2KsjxKFxLSbAgfBXwvRXNGBZy6Z0cFJXRSMlh0ua 14uLhM6U9Pq3p/iuMxyTNkoJpS+n9d9j8L3Vad9o+NlbUl+HSGB9Dctz+KbFo/0cbIIY21RhA2J/ Hsu7+o3U3/09x3AMGgpAIq+QRDS3gcL5bM9GzJfWyjzPPXQwxVcYgm1kDbhfWdS+nsPUmpwTE6Su jYcPlE0b2uvqXqclKUXPqjywtQdfp8r4xaQYl0WnpDs2aRmp3x3WV0MwDDunPRSnxClpmRzCn8x0 gaLu2X13U3AKHOmRarBqqtgilfH90jwNx3XE9K8xYHiWT48ryVtNNUUTP0skbZAdYGyynWHb/Zl0 8u5/gvoj1WqOp9PXPlA0wSubqAWqv6nFHLTeIuvqHMd5JhYWEj+62s9M8j4X0lkxaFuJ04irJjLH G97W6Aey8T/VN6YYVmDB6DOMFfSsng/lPZG8F0oVcoqUtnRwjKTcW+7NclDaoiDtQNxsu/vCLgVF inUagdVMD2Mlbs4X7rzrhkgipw83swWtZdv9Aup9D0+zXTYlO3VTh41L5rSbP1TX1N4mK1YyH06l rMNpWl9PTh7ImDnZcH0P6kV3UvLlRiFdCKcteWaQuG6WeInIfVPKcDY8ao45HRBj6eeQNPHyuYwH G8idNaCohjx7D6ammkMhDqho3PxdeqKTi1XJ8fK5Rmvw676F1tPh3WzPtCyIB9RMJA625X0/XbxF 4D0Zr6WkxCjkraiZuoMYOy+Ixvq703yR1RpsyUOZqGduIDyJqaB4cWu/3FfV9RcvdLuscVDiOLYz QEQESCRlQ0OI9juvTOpTU5r0eBxlDHtivZ8ZhPjoy5mOKOno8u4g0yPEYcWehpva913hn3D5M19J cUpaVmuWsoXaR+RddK5/6ndFul2QcTjwvEMIdUQwOEUUJa95d/8AK6b8Mv1FMErmVGC52m/RUfmO bS1Vr+m/DvhZlFJKUF1+naCk73ezsPwH/rMtDH8CqqWSICfUJHCwuCb/APhfB/Uvb5tflqrDrfpt QLfe676rvFD0ayRl3EcWwzMmGPlDTJ+mjkHmSOt2C1edaPE3V9derZrMQmNPgQktFEHelrb8rtCc XN5Krg5KM/rjv2bS/BHiVXWdDsMjrHFz2H0gm/p7LpHxTtGH+KTKFS5hZTy+WHyu+0m/C7H8OfiS 6SYH0+w3CYs1UVJUwxgSsnkDbGy648aXW3pLmXKkVTSZggqsw0TxLRyUbrkkG9ivLhltm2e/Uwcm ketOqWBOx7pniVNTTvic2ic+N7HWvZt1qQ6c5T6rY/nPEIcpVuLw1Lah7bku0bHle1+gn1AOnmaO n9JhmbsVhwzEoIhDK2Y7SAbXXPv8avh86cGZ9Bi1J+ofdzv0cVyT+V2wz2RlFq/w8WfE55IyT49n 1vhJxTPAwStwPPTXS4rQOGqoeLFwPC+T8R/iszb0WzSIcPyd/HsOI9EkbS4k/kLpeX6puWIOomuj w+U4I46JJD9zx7rt+T6gPQrGoIZsWqY4OC0TRBxaVyWyGS5q0dcqnLHWN0zrzqL4l+s+b+m1cIun E2GU1fTuYJiHag0t9uQtU7xPBjmIR10ZiqxM4ytdy1197rbF1j+pl01wfKdTHlWpOKVj2GOOAx7b i11qhxfGZcz5ixbHJgGS4hUOmLG8C5uumTNDa4xVGtFGan93Zz+XsSpqathEcmtxNn/C3SeB7O+G Yz0nocOhrYpqunbvG0i9lpDhigpf5rCNZG4C7F6N+I/NHRTH6fFcFneI43gyQOd6XgdrL5+3cfoM i3Lg279Tsq5+oOqEFflmdzsOrCBO5/EQ+F3LjWYaHKOS46rH6wRxMY1s0p7leH8E+rblVuExS4ph Er6sxjXFDt6rbrzN4m/H1jfXcfw3CoJMIwM7eW0+o/JXv2uaW/hI/PU4SltVtm3LMdO3MXTmqZg8 7Zm1NPqgkab3BGxXxfhryljmTMuV9PjlSZ5HzF7dRvYLWR4e/qJZp6IYZHg2Ll+YMIjADWTbvZ8N K7hzv9WmmxvK1VS4FlyXD6+aMs857r6b9ws7fq4LplcMilGbXRsFwnqtlbFc4VGXKHEYpcWjB8yN p7jkfldXdS+iWZcV6j0uO4Hibqagc4Gpga+2v9lqFyn4ic0ZTzmzM9HWStrv1Bnc4uPqub2XszBP q901NhkUOLZYkfiDW2MjD6SbcrUf9UrgTJinkj9j31n7qNgfSnJ9LXZiqYqelbpid5h5NrLAzfAz rD0plhyriUZirogYaqN1wP7LTZ4i/F3mbxGYq9sxfBg8ZvHSg2b/AGX0Xh38eea+gdBJg00MtfhH MUJdcR/hFjSalF89m4xyz4a+ptc8PvTzGulmUp8Lx2t/WSNkLxM432/K1v8A1Euo2EdQuueH0FPV RyU9DaF72kEC3KnVr6qecc6ZbqsIwPDI8H/VR+W6rAPmNBFjY9l4nqn1uOVr62rrJKiplLnSSudd xJ+Vu6blL+TMRwzlJQS4Ru18K3R/pjJ0cwyKOhwrE5ZYw6aSQtc+5/K83Zozpljw9+MGarwumhpc HGlskUJFhfnZa6sM6n55yi3ysDx6vpIG+nTHKQB/lKqMw5gxipfiWMV89fWP3cXuu4rx2+bPqrE+ EfoEzlhOEdfOmI/QV5NHVxCWKSI8OtsDZYnSLIZ6RZS04nigFPEDJIZXWZGAO5K09dEPHl1E6H4e aPCWmvw4G4pKvcMPwuf6y/US6gdbcunBpqduC0krdMzaNxbr+CtKTjDYnweLNiksm+uTnfFr4kMU zf16xaryrmWupcOgtBEKaQhj7bX2XuzwBYVnF+SarG80V8te2sa3yHzPJcRz3WmGgnqaSp/WNcJp GG+lxuu9cjfUH6o9PsEZhOE1Bjgj2ZG4Xb/Zds0lKKUUbwaaUIfbs2S/UhyFX5x6EyVNGS04XMKl 4t24Xj76buaen+BZuxCozdiFJRYjq/4d1WW6djbvwunc9fUP6wdQMv1GDYvLA+iqGmN8ccWm4+V5 sGH1VQ6aqfMaed5LvS7TbdXc1h8ZnFgksrk1wbqPHRmjppj3RXEKkYrhdTiENnUppZGmQnsNlieA LxVYP1EyLRZMxKSLD8ew2IMhie63nxjgj5WmRj6yctjqa+pnbwGukLmrnsCzJjmTcVgxDA66WjxC E3jmjeQWrzwVxpnpnhlLmz9AA6IZYOfP9YOgd/Ggb+e53pXTviQ8buCdDc/4NgTII8T8/erla+/k i61g/wD3c/XRuEnDajMc76bTpDrWdb8rqLG8zYzmrEXVmK1k1XVyG7pJHEldlTdzdngjpp/xgqN+ UeOZI8SXT1jGYjT1eG1rA50YcNbD7fCXjuZcn+GvptLPUVkFLQUcRbGwOGqQ22Fu60X5V6j56yXC 6HAcanooD/S2Q2WNmbP+dc5gR49mCsxCAH/lSzEtH4F1IxS4k+DpPT5O0uf07J6tdUqfxA9aYq+V rIKGWvH37DTq2utvvTvov02qumeE0r8GwavY6jaJHs0OLiRvc+60KVkJgpnugc5jm7hzTvdcvgnW PqFl3DxSYdmzEqSntYNEzljPl3SpdHpx4HDFtXZ2R4yMsYFk3xFYzhGWKZuG4ZCbvhiPpB/ZekPp r5FwbMOfZsRxOWmc2nZqY2V2k6uy8DS1mK5gxKatxSukrauX755XXc791l4VjWZ8qVPn4JjVRh7h 3glLb/2XF88rs9GOFQ2yP0bZniwXE8BnosQqadlFNGYy1zxYgiy0GeKfJeDZO64Zjw3AZhU4Y2dz 2PvxfkL5+r679UaryjV5vrpmxbMa+c2C+Mr8Yq8br6isxCrNTVzkmSRzrkrrHJKEKZ4vA3lUkNMU bKRgjsHDcqmWAukxxu5udKeN27f5Xj9n1S2/BRtKECyMWURUMicNe/Ka4gu2CBrBa4Rh4Ate6pSj pJsr0lpuBsq023BuVYlc5pBCCiw8PdcDZWLHhKaHNJBCOMG6At8ZPeyQy8biHn+6yTt33SH2kcBz 8oBsQabkcoyfTvylNvHwmPedAIF0BbHlrrjZKqKkg6T6r90bDq52Chia91yOEAAaCN0cbLcK9QDr EbKMfqdYbBADM9xaQNliNc9xtdZcjCSbcIYIgCdSAKEOB3uso7NQlzdrKtdj7hDQOsXTfKEjdtkB DSTYbqMe4mwGyjKRjCXG+1kZBPCpoMhIvayNpAaR7LIIBYG6JoDTfsqDtQ3UsLWQFSjULjhVG4Rb o7duQhkjBIAKGrEmBj/UDZxKMR7WJRRsDCbo3NveyEYmZt2BoF1AwMbYFTUSbFvCmncfCECDrN4N 0uQ6vhGXbjf9kl5aX7mytkRTOTvdNLdTduVTAADbcqGQg2CqZAg2wHurde2yrc91T3WKooXr0P0u F7qFgZc35RmMW1HlByBcoCbkcqHa1le19lXdCE1KXurtqKhFigGQ2AI7o2nfcLH1G6Y6bSyzjuss 0jLaWkBUWC/KGn0mPUUxhvc2UKCBt6v2TGyAM0jYpbz7qMYXb9lgDwXOsE59omXWOC6MbBHTyanF smyAaw6he2yCUl7bRtsfdVqLJLAehGx4bc25QEaRHGA4Xcq0GYe3wh+15JNx7Ii4F127C3CjADmt j9N7uKSXEP07ppjJl1OOyqVpfLqA2HsqCnO7oNW2/KsO1OItayDVqkI7IB0TjY2bdWZbXJ9Pwlmo 0EBu/wCEudpcA8u29kI2Soqgxp32KwGSaHG3CCeQyyad7DhXHTFwvv8AhaRDLje17d0L3DVtYBUW NYG2G6Fzrg+60Qp17qA6TvwqbcEAqE6rkbhAQvGqwuFbpB5ZHcJdnOGyY1rQCDa5UAUT2OiJuAfZ E2XUwpEbGtubK43lo3CAc02bvuo4i4HZKkm9VgoZALG3KAOVtrWQOuG37og691QkNt90IwtLXM1O sPlIeWP4deyIEvBaRYFKfEyEbHdWjJIxpdc7oQTqJIurDrN91bSD2VBATuiY5VZQA3+FShG6EN1G 3ZQuA2Buh1FoQDizQOdkBcH3VMe9xs4be6J7WxcC90BIg0nZ24RPaACboQQOwCjnfKEFtsXJ2klo AO3sgkcCLtG/dWz08nZCke0aQe6AEHblDI6z+bg9kbY7Nvx+UANi0bbBU2S9wN3IgC6++yWx3lvO 1z8oAtTnciyY/cCxAV/8wbC10BgczcnZAGA4iySW+vflG47gtKJwadxb5QC5QRESkU42JIt8p0jv MaQOAhYPSgENYXz353WSGAkjhC0aXXG4RgHchAIeTuAblFJJelZG0eq+591YAhcSd7pb3hoPAuhC g3SN0Lt22RNk7d0LnbX4VRkHTcWtsFdha291QeL78K3mxFlWBMree5QRMI+CmmxdeyW1wDyeyAa4 lu/IWPK8ndv9k1zw75+EAYL+yAx3hwN+6yKYG1yiDAQb8oms0N2KAY74U03CoC4uTuoH7Ed0Ady0 BGJBbdIL9ZAJRF5bso0UcJGv2Pbugkfve23ugbtvzfsmtuR8eyhBT2GTcpsQs34QFrmusD6VHgs2 ab3QtkmebHusa/nHfhG7zAbkbKhYC459lbITULWAQ6y027q7bE8IAC51wdlLAbjcfPwsZ3qduU4m 1wDugEVzurYLDbDZWBtuFHO0NVNdqvdLBQJdYdkbmubYW2Vt/AT9Vx7q2BJc3TYDdNp2hnJ3QaXB wJAsiuXSWtb5QDH3tzvdCWhzt0drmx7IbXJsgCjkAJFtgjBYSDZIdGb3BRQtbcgndZNmQ9nmnU0l pHspG99tJdf8qgQ3a91A6wO1yULYWnlRoLRbspa+6I8LAopvNrbKBobezt1I2m5vwg8siXVdCDWs JtblWSTfa1kO7jcEiytztJA5KGrKZZ13d0s6jLcIw2+w2VO1MHH7q2Sy7k8iyl9Q4sqabhQnZQpZ u0X7KDdQNPl7m6OJwjFtN1UZsTLIIC0Bt9RTC0+yhbqdc7hQvuCNygFMfeVwI290zaO55KC9t7bo 7tYLndQF6xILncq3Nu38oX7kFosPZETwe6AToIPdWxpBJJCYXAm55SnO4PCAMiwuUH3nf7VUjzqs Bdqgs0WPKtGi5GNYQWJjZXWBI2SiRa11QLiCL3ChkaZfM+1TRex4S4QQ+3Yo3SAEjhVgo1DW+lwu qc8PI07KGNlxq2v3Uiiax5ubg91C0EWjax3U3ttyrLWtdcG6q+90ISO5JDlQIBeO1kQdq2tur0gX vyUAtzQ5oskOaQ8A8LLIbbfkJL2h7g7sENFuOkgBEHAdks7vUbcPuhLGB2oFRnqG6Fvf/sjLSBsE KXoJBDTulSU7nWGqyJrHg3vayjZg51r3IQyBDGW31bpoeCCLJjQChIDSbBCgR+lxRzM1Qm2xSCSH bpgeJHAX4QoEUNhdx9SJxsbBWZGseblLLvM42Qyw3OIaAVR0kXVD7dyq0F1rcIWgw3uEUzLxCxQt Ij5Vxtbclzjug5ENJ3DSjDnR6Sd0UjWxOJaFGevcj9kKNDdfqB39ktw1G190TXgApZcLqgF1w7ZG yQEfhC4ahtylFjgRYKgabk35CBwDjb3RAEDfsrIBcNkBTqINiuD6kyc2wx0TPuPJVSv3skFzjt2U ZllUcThGGj8LJZEIX2dyUmN+jvZNt54uTunoDS0EEXSHw8KOge2xDlbH6NnG6gFuaKZ41GwWY17J WarC1uVjmMSbuGoKX0tIAsPZAEPLPa3sg4NjupqA/KvSCDfkoKIXBwNjcBDu0bIKZvkvffcH3RQv JDr++yFou+rsqLO5VuNhbupcm10KBpGrhEO++yJ422StPygINifdMuQ072KC+nncqy74QjAFwbgX Vghz9PBRscW39lUQ/mXsgsvTZ26HcuN0UjXFxtwghuXWdwhANJc6x4RMi0yXBWSIg4gX3VPDQ/Tf dCoAxXfqCt7gx1kR9FrG6RNdzwgYRnAfb3V3B2slNA1fKeAAy/dAgDEjvp47JYeb8pgKBitesnuQ jYS7koWtDCSDyjY1pBud0IC529lCSANv7qv/AHAEUtyRa1kAQnAbYhAf8qiAN+VAQQrQI4ucyxOy XHUGmtsHA9inWNkqSLzBf2UKNkq/OGkNsPgomyhsWkX3WK4OjaCBe3ZMeXU4aXDZyFQeo342WLP9 yy42kxl52HsVDC1zdR3KARBFYAk8p+m2xS7FgLQd1GyHYHchAGYwN+D7qid1fmXPGyvYoARsLq/w pp7KjygL5Ko37cKXCIfagBtcfPuhtcEXt8ow24HugqDaKw+47bKgjRd2kG/ymtdvtyFiU12sIHI9 02KS4JKgGPJc0+6XH6TuQPZOB1XS3gX4QE2e487IZGX4RMdp/dGxwGxQULjBaeE2waCQhJ3+FC6z SgBEhI1eyF772NtvhW4i1j3S3DawKAJtjc2RX4VMJLLonnSLICayVdySqA2NhuoHEcjdAC5r3G/+ FCxzReysyFp2Ra7BALLSXBQ2a7lXfcqmlp2KAItuPhDM/S0AcIxs3Y3Qvs7lABe9rFG4iX7uyoNA 37BVq1XKArUOwsqpw8zb/arawuOykZ/mc7BAFU3ZINOyafsBJSKtxkqIyB6RynfdtwEAL3lo2VXD 2gH7ioGEG53RtbttyhKF6C25JS5HnQbFNm2HuViP1cDa6FY8EEN900bLG8skAXIKYGu02uhkN7bg m6WxtyDe9uVbfRcFWyQNNtPPdC2G5rnD/pQX03ACY88b2CS6XewCCymh2q/ZSPWx51H0lNbqc24C GRuixJ3QpCGlpA5VRtJHF1TW33B5RAltmgoZKc3f5UddhCOxJBKqQAblAC++kbcpjwPKFxusd9QR IGgXCM3cRc8dkNBXtH8qRnkW5UsbqwdKAprQHEu4QkC972CIusquCNxdCWU1rQDcgnso2wcNW6vy g7jZS4DgCgsjnFhJHCqO/PAKM/f9qrUbkdvZC2U95b6ijDtQBG6VIHSN02srdMyhhLSbuPCALclC 5rbWPKGESMaJHn0u7K3u3BG4KGSQhovtdXJtvw1VqDNvdIla5x5NkNUHE6+odk3YN+VTWN8ux2Kp 3pbpCGSo5DO4sItbugbeke4AAgozLpbYCxSw4y9v7oAvM1i4Fh7Imx6mhze3ZWD5QIcNyge7S24N r9kA/UWsu7lJLi/jhC0F2znp9NYix/ugEuhZo2Nz7LAgHlyvcQSFzM7o427WBPdcWZ/Jl0n1alUK Hea3TqG3wo+VjgOQimaDG06eUp8V7WKgDE4IHssapkuRfsjm3a1oHfcoXRNefUf3VQAZNqcBYlG4 AqvKaASOyptQDYEcd1oF3Y70tJ1D3QuGj5ROBLC8AW7WQNkLm7ixQA6wAbbqBn6hgD7hqgdpO4um McCCgBNOIwADsi07DdU69udlLnZAWeFTbq1L27oCEbG5Vt2GyMD0m+6q40oALqHhXZQm5QFsIDd1 RY0m4OyD7bo43tQzQBNyrtq34VnYqri/sgoF17c3UZfuiBF1bgHG4NghCHS/Y/3VEgdgrIHuhOxG wKGinxaxeypkRYbpof27KOcCRfshLBN9t0Grc3Kj3i9roS0c90Fg7B49iqkiLnbG6OwJVus1CCWU rzwjdCQdjdPdJpYCFjyOJN+6AFoLCbm4V2cHXCm55RuBDPTu7sgA1E88qmPubEqwHPB1+lyxTfzb X45QHIC1h8JZPICs2sD2VmxNxygAJUB2KnB3Cmq24WbATSLXHKsOQggndQm1lQE86uyS1vrItyjN 7o49gfdUCm3YSP8AKIbtClru3Utc/CAAarndZNM4N2fwsfSfdXq0xkWugJNUu84tjPpVlg5cLhYV na9tlmtN22O2yAHSGj08Km3B3RAX42Vhh1G6jAZNxuVbeObhKcyzgUW9/SbKWWwy4X2Uvcqhf4ur LDqDrqmi9A1B3dDUu1kCybcAbndJADybuQEiJbZP1XG+wS2tLT7hHrP6dwI2J5UAmQk2LUQFhflU WkWFrBWGm49goCtd/RwowWJHKDzWh591bbuuAUAwDSQi1Af0pPqab8oxKSEB2FONDjbZI1krka6E EkjZcW9rrn2C8SdnslwRxuLd1iVkskbPQN1mAgAXBusSrY47g8rojImmr3DTdpO+65pk7XNGkWXF 0TPLFiL+5XJu8stFtlaKGHN54UcdLSUPl3tdBILbcrIKBedzsFbkIkLyAEwxm11CAH1DcJM0QJ9I sshosLk8JchFigMWRvn6QdtPdcjgOa8UyhiUVZQVD4HRuDrtNiFxz5xGRcEj4QvMVRIDcj4XWLMm w/w7/UZpsNwuDCc1SAvY0DzXkAkL6Pqd4zujeL5kwzEmSNbX0rgXSQjn8rWRV0Tqw+W3DpJXAf8A MaFxkGHzRSO/4Zr2jYteeF9GM5VSPnZcMZStPk2qdZvqIZExXpdV4fl+pdUYhUs0tLT9m3yurvCj 4/8ALnSzDa2mzbPVPlluY3Bt977BeAjRQtHqb5El9trhZkdC+WNoNMZfYhhXXzS/jRwWlUncmbTW fVG6aDHTVMwGWomv/wDfTgAQF9U76pHSLF2htZSVIe3f1xggLUkMu1E4aIaSXV3AYU1uSKqXd9FO Lc2Yf/hbUk3bRxnpYrhSNp2a/qu9PcN0MwvDaythA3c1tl1T1r+pPlrqn03q8BosKqqaWoFt9gvA f+n5qV+n9NUNb7ujJCyBguIU5af0hLT3c0hbWXa+EWGjj7Z678P31FZOimAyYLV4J+so3WLZL2IX w/WPxnf+rPVnDc30mHGmp6Ij+TJvey6H/wBJY3UtD4MHkqo3C+pguFxlFgOMVGKihpsNeyqcbCJ7 CDdcHlnbdHd4MdnvKs+q1UUeUBhtHhAdWin8pjyLaTbleGc352xvqbmeqxzHah9TPM8v3NwL9k/G en2ZcCi8/FMElii5LxGSAuLpaqFz2tjcAB9wIsvJknOXCLHBFT3GbSStjp4w7Z1+65WhxqTLuJRV tOSJRYt+SuCkb+pcXxn0g8hZVLR1OL1EUFP66gbNauMW07Pfx7PXHTH6mua+meFw4bJg0FfDELHa xKPq19TbGequVMQwdmWm4e6siMRdckC4tddJ4d4YuoOY6Nk9BhH6jULgMG6xMS8MvU/AYXOqMr1Z LfaMnb9l7ttrg8WVQkzq3BaaX1TGUx1AeZL8G9+y9C9LfHb1J6QUbcOhr5K2ijFmxTHUF0fieV8a weqFPiNBU0FRewbIwi/919rlbw+5vzvAJMLopqkHb0tutwtLk1PY1TO5M3/VI6p5lwSpw2npqbD2 TN0fqImevf5XnLLnWfNmWs2DNsFe+bGWuLjNIbl2/dfb5k8KnVPK2Fy10+X5X00Qu7Qy5t+F1xkn IWLdSczxYNQRmKrfJ5ZY9trG9rFJOSPPjx44uz03hv1Y+q1HSCGppKWudbTqczsuj+uniIzN4g6+ kr8Wa2A0/wD7bBYLuSo+mx1WpKHzaOhhrWluq7CujupHQfP/AElfK/MGAS0lKz7piPSs757XtOks eKUrPjdUlS6IE+nuVyxphHpEL9Bte4K4zBIzNH5v/tu3BPdZby57tANh7rxKz2xVcH3GUetueOnL RFguLzxx9gHkgFc5XeMPrVNLduaqhkXO7iF00Kw1FT5FO4BzD6nOKyJo6mT0l5c0e267qbRJY4S7 R9dm3r91NzpUQTYvmKqqHRmzbPNgsnDfE91awGm/TUuba8RAWDPMJsvhXulngEMcZY5p5Pdd8eH3 wq1fXKR1OzFG0NXtoY48rrHI6pnnlgguUdaYj166j47G41eZcSc52xJmcAsHCeqnULAZxUYdmKqp ZL6tYkN7r1ln36XXUTLOFzVmHYlT14jYXubfiwuvIuBZbr5s0zYLWG09PN5Mg7XB3XZRkluXRiPi b2tHIYx1W6j5qqhUV+b690zeCKhwH/dcTiGZs1Y6P0mLY7V4lT9op5S4Be5spfTTn6hZLpsYoK4M mlbdup1rm3C8z+JPwtZw8OFVC7E2eZQzGzahu4uuai5rhl8eKD4R1FRPdTSTwuj0hwtchMpoDTxC FzbxG51oIal1Y2PzPutyoZn8AeZb+k8LjVcHpTp8A68UoKgOw/E6ina3gxSELJlzDjdUWsq8brJz xaSV1gubyRl1uN4/RMnGiKaQR2HyVsgyr9MzKGecnU1a7FnU9XMwOAh3tt3W45pR+qOeSEHzJGsA meQkuqprnlweb3RNlxSEGOPHa9sbtyx0zrLu7xUeFLE/DPmeGF1ea/Dqk3hkIsumJqZ8rWuf6Rbs u2RT4szj8U1wjCkw86RJPXyzjuHSErIjo4v0DpY5dDhxYo5cLjkjuHnT3ACQ/Dmw051Oexna+y5S 3yR2WPHHlI4+KgtIQ7zJXW7OJTxHFGy5Jj+SnQzvYzVSNdK7vYXWM9v8QBDhofwRwo5TXDJsh2Yz 8MjmcZIaiXfktcbJnkvi0tFR5j+LPfdbDvAd4ZMhdR8Ec7MVMK6aVlxH7LF8enghyR0zyTU5ryvM 6gnpCPMp3O+78LeOLycI8+WcIu5Gv6tw+Ehr6iE6v9zHbpIwqhs0sDwL8uWRQF1Xh8Zfqe532i17 rKMMxpix1LKQ3uGlVbnwdU4MQ+kghjA0XaeDdYc9BS1ERs71Ds7dclS6am0TWue4baXDdZEuTcTf 648OqC1/DmsNliWOb7LeM4XDcJp5Gm8QJH9V1yTqSOCHSN1VZh1ZhrPLqYZ6Q221stdJa8Nprefr d88rDg12bgoemXHeNwLGmT4RRNfUSkOZY32amxOfFEWxjUbXuvTfg+8MFR1mzPFUVLR+kY4FxfxY crKdNHRyUVZ50dgVSyJrxhz3XF9QYd1ixVgBMBgMZHIc2xC3x4f0H6YdPMuU1LX4Jh8gIEZmnYC5 x/ddLeJHwA5L6hZZqMVyXQR4PjzGF7HRf8uUW4svbGSlVnglqIqTs1H0GGGofqbTvmN7ANbdZ2J4 JXYdE2epweeCA7te+Mgf9ltf8JXgzy/kvKzMazfQx1+JtPqZO0Fjbd7Fd14p0x6TdUqaqwgYbQTk tLHR07Q1zP7K2lw0JamPDSND74RWuY+nbzsfyuYb0yzPXwCamwOsqo3C4dHESCP7LYFV/TVrME6w 0clE8SZPNT5rmndwbe+kr3U3Cci9LcJocMno6HD6d7RGx0sYs4/JKslGLVc3+E+UpLo/PycLnwWr dFWU8tHO02dHKNJBXN4dl3F8yzNhwjDp8RlHMcMes/4W4TxSeDfLfXDLf8QwGipqXHWN1RywNDWz DtdZfhM8LeHdDcuvrsapYP43IP5j3AERgfKktlXFnKOrlF7aNOuYch5uyxTebimWqqmhG+p8JAH9 18tNWtmp3eUzyZBy0ixuv0BR5oyH1DxWry/JSYdicjLsc18bTftstYv1AfB5/wCj+aRm3LVOXZex J58yJjfTTP8Ab8LKi26qmdI6xSZ4lgqXuieJfQb9ysyiL2RNf5up/AJ3Xsfwr+A6m8QOWanE8WrJ KaNm0ZhHf8r5nrx4JB0E6jYNgzMSfX0mISs0ucLWuVzcHu2nv8sas6Y6f9KM0dUZzSYDhM1dPyDG 3n919FnPwqdU8g0L63FMp1YpGbvkZGXaR7my3G+GnoVgXRTp/RugpGCtkgEk0xaL2tflfT5Y6pZQ 6rT4jg9DM2vdE50NRA9lx7FXGkm3Vo+Zm1DTqJ+fKiilFfIA3T/S6Mmxafwux+mPQ7NPVbFBSZaw mWuJP8yQNu1i9aeLfwbxZb6z4fUZUw6SWjxiQF8MLTaNxP8Ahe6/Ct4faLoX0/ipjBH/ABiqHm1E ltwezbrvmSxpSj0zUNT5U17NNHWTwzdQujETq3HMLkZRtNvM0EBdTu0zNMssli4fYt3v1Eadk/ho xoPiY6pe5gYbbg33stVPhs6K03V3qvR4LWSCGhBaHXPPutRhvxeQmLPUnjn2dH0URbO+RszLd2u5 X1OUMsYhm3F46LDoHVFRM7S0NF7lbVOsH01OmdJ0/wAQxDDaOWnxCho3SiZj9nuAvwuD+m14ecBp 8Jqc4YhBHVYhHO6CBjxfy7f1f4XmUrTZ6pZknR56wf6aHVPHcux4jHLTUr5I9cdNP6Xn8rz31O6M Zy6N5oGA5qw11PWuaTHIwXY8e4ct03UnxCUmTc1Q4BHQyyytcDJO3Zgb8J3V7oplfxG5SoW4lEGt BbNDVtYPMA9r+xW4Vw8keGfPlqpxf1Zqa6FeDTO/XamlqsIjEFE37qmf0sv7A91znVr6dHU/pzg8 2KshGJUkbdUn6d2ott3tytteE5cw7o90umocGpWU1Jh1OXMbG21yByflfL9AOr03WTB8TdW0jmxw SGN4kb6Xj91Y2rklcUc56lyajdNmg/y5KWrqKKpJZMwlrmPFjdYNEJXYi+MDUwL3d9Uboll/pzmj B8ewShjw92KOLpGxNsHOHK8PYRI2armla0gDY+yxlxpNSXs+jpc/ljT7R2j0N6B4v12zlFgOFPbT FzvXMTwF7ah+kOLxmozKWAtBeWe66b+m/jIp+udDTSEFsrSNJNltp6sNxeTp7jsWBF7MXkpnNpXt Fy19tiuSltlSLnltTo16Yj9ISCKIyUmaTUvtfQ9tgvEPil8Mdb4bc0UkFTUtmZUuOlo7WXq7HaLx j5aillhqq2rgaSQ2M327bLxZ1yzl1BzZmi3UI1TsSp3WLKm4IK9/gc4ts+bgzyk6s+QdVCQaWjS5 vITInEi/CwxIA4usNTlkxXbbfZfGlwz7i6Mi4J4RiwSwVZdsiNDm2IJB/ZUGixKuLZt7JjCHNIty qBcYDd9SsymI6nm7UWgO29lGRsfqbJ9vsgI2TzTccK3endLi0wktZu1MIL27cIABdztV9kYOp/p4 CtgDQBsUQNidrIAXA9ht8og021CwCIHbhC307u4QFs9Vro9Gnuh2JuOEbiNFygBLSbd0IYGlECGg W4KCNxe47oAie6WLi9+Eb2m9kNtrEoAdJO4OwRtvsrLdtuFHXtsgJu0kjZOadP4S2uIb8oiTYKGg 2gB1wiJ2StXp+PdXE4ObZSihckIgd7eyMWVAgkq0Cr9gqad7lWS0b2VW12UotBFgO5KEHf4V7N/q VtIcLKEBcNW7dwOVLN0XHKKleWOlY4bOQMaGB1roBe1zcXKB8YNyU+9xbgoX2LbX3WgJjcCbBHb1 3G9kvSGbjsmF4aA7lKJQL5PWAifsgeNw4oydVu4VKDuQiAFuOFTmFu90TrhoshADa5spv2UOytpu gQN/dFqtvyqRg7fhSigCMu3CXJC5zllNcb7ody43QAQsczvt7LM86zdgsUktFwoZnM3PKywZbbyD duyvzQw6QOEqCdzueFb3AO2busgyfNMrewCDTbYG5QNduExrr8CygLfdlrm5VskaSQQqIDvuO6jG F327FAFpIJ22VhthcGysg6LclVHcn1XAUsFuAcN7pOpzHbcJ99+1kuaccAIgLI9W/JV+UO2yH7jd E5pLdt1bAs2id7lKlL5B7BERvvdRpvx2WkZYunpWh+p3PyqkqWwPLGi5THP0rHe3W78rVEG62yC5 QO3NwNkoDyzvc/CPWS0EbD2UAWkOAVEaGHSNknzDY7p7do7lAY7JC4HsVGtJfdxsg3Dy7tdNDw3f sgFS1PkStboLge47I5HkNvbZQC7rngqpxZtuAhEKE4fYHlPsXM3/AGWIGjY33WZGSW2QjEPLmuA9 05jCWj2RFgPPKjPSPdAMDg5thyEksDnevZGx3lkl2x9kqd2oalqwUQ2N1jwoXNPAStZuNffhHqva 2yoC1DffhRjtTTveyS6LWT6rFFA0NB3uUBA0q3XsBdMIu0+6Ets09ygIJwBYjdG46mBY5brHFiEY Nm2JQBuaLXPAVOaCBbg90t9QwbHYFMgeJQAOFARo8t1vdXo033umOj1uAbyEgse2cBx29kBInAyg kXA5Ct+qoe/+lnwifZshAQMOg7cKgtsYibshm32BsUVye+ypxaTdALeZAWhp2HKY4uYLFWQLg91H APO53QFeW4j2VAeW03T2jU210uVnuoAITZh9ieELgSLN2Kj2lnCjHFvqtuqAY2lpOo/3Uc4tFgjl ppJmawCAhMVm7ncIBL3XIBSn3c8C+ybK2wv3SnWNrmxQBccf3SzJvZHtosgAsVUYL1ekDsrvoAI3 uhINlACOVSh2DhdV5dhsrvbZGAbbcoQx9Plm57o2x3uRsFUly3cb3VmQtbYICmx3KMu2IQRO9Jud 1Wt178BAVrIduFena/dE6xsUZbcavdAJa25v3TA67rFRwsNxZBe7r8oBsZ1PLQbfKJ12G17obAC4 O/sibY2JKAheQDflBLM2Fmt1z8BXO2x5+UkPN/cJRQo6v9QOC0H3UIAcN1Rs51uEOi8nKEKnu1pP ZTyx5QN9vdG5ge0jmySycSy/pyCB7qMAeVoDnNdco4pdWx5QvYKaqLRdwtwj0gm9rFQFvBcbWSQS DZZLbsa5xStILNYQFMNzZxtdGwmOSwNwsf7kwXdYXVQHudq5KcPs+VjAAPamgevVfZUDQLbE7oiL JTb6vUbBMuO24UsqCAsPgoYwA83HPdFbUEDmgEbqGh8bPWPZE0jznbbDhA0lhuETiD8KMFizi7ay IWIslEO7JjRYXJ3WS2GBYKizjdU14Jt3VF+k2QhT2uJ2ICU67HAXTHO8w2V2a6+3CAuwtyhfcixK HzBe3+E2wG/ZALa09kThcJhaP3Shs+7jsgDHFuyo2PwpcEi24U0clUElJ8sWS4XHvuSmmzxvsoIt DTbdQAfad1CNQHdAHjVYprXC1m7lWgW2TSbEXQv2O6Pa4uN0uR2r4SgJN2vvyFYd5oNlYdfZEwMb fdKAQDWsA7oCy53UY8Ani3uo9xLibLQBtq45RMZc24VRCwJKvSSNjZZsFkEj8IXtBbqKl9rC906V uiBl+6gElhl3HZEyzNlULiNSFt9RJQ0GBv8ACY1oZuTcIQL2PYJUkh32291TI8j03HKEHbfn3So6 gEEXuVYdblEApGCR1wSAlvYW2AOydqbZC46rG2yUBTTc2dsm7NNkJIvwiJBUABFnXuifKI+ShJsb dlUgD/myGggXO9fDUDYWiXV7omOu3T2RAgAlUBPLr3HHdLDiXHfdNjkOkgbXSy0tfcqAjm3O/NkG 4fcbJsvosb3ul7g3PCqFhOja4anXLkEaNtgbngqOHqAb391AULF3CNgvwgkPlnhRkuk7d0BZsdio NIQi73X4TLi29kBeppO4uqc+xIaLIXEDtuia27vhAB2F+VRAAud/wjm0jhU0EgeyACSzLOa7c9lb CXDdG8Autp/dCW6XWQlkG5O9kIPq5UJOuwVFh1XGyFLJu5QkW25VEEO4VDkoCiL9t0ReG8cqXAKj 7W24VZkJkjnd9kLxc3UYSDZQ3JUAQJtZvKt5MYHuULQ7fslyNcSLuQBF4aDqCNj2yNG6xn3DrE7I 2MGm7T+yGh7j6u1kIAv7BLcCTzura0uIHZCWE91ygDjf4THCyEWvsrRCa7i1kLWFrrnhFYWv3UDl AEbWuULWAXINwqeQWm6XDHbhxsUBkDjbdCSQ7gX+FbvSLA7oT790A1r9Y2QF7WXB2uhbs3lU5rXD ndANgcw3JdeyB13S3tslNcGXsnRgyNJGyFTKe4h2yXch3Ca5psg/AQtk5Pyo8EtKMMDeTyitZv5V 9BimM2urcLMKJ7/Jtfgps72Mp9R7qGTBa8kgN3WQ1tx8pdMze9ue6yCwX2KFoW8bX4IQOd6flMfH 7nZAWgiyCgLk7Ir9kQAaChI3uEFEDiB7oWyHXbsmadIChYChS27O5RSPLwBYG3ugG3ZVqvchAMY7 gO49k6N8Yu0hYuq3Ko31FyAqd4ZKQ0XHurYNtu6EkOB91I/S3YoAz3V6hZL3JRHhAWW3FwVYbeyA WV6yNhvf2QBllgUIfZwB4Qu1DkqNBfvZAEdni3CqZ+4tynMaBuQkTbvJAQAtAJN+6Y1oa0pTTdyf uBxcIC9WkXA2QyN72UAJsf8ACMG5O2yAU1tzZF5R77IgdB2QvcXX3QAkFLa5xJujEb3kWOw5VEll 9kBCdQQtaO25VF9hwrH3AoCB7pA5rRuETQS0F/3D2UZ/JLjyVGkkG42KAIOLbm11R3UJsFGjUbHh AU1pcgeXNCyHDS2zTskvuRY22VAIcdIJ3KjhdE0ekXCotBKUCNe6MfCLTrF+6FzRb/5UdsBZQFSX 2siBAallxLrIXPLduEAZdyOApBa5U0u0glVG6zgFSDbemytjSBe90VwTwltBDzfhQo0G7CTz7JTN UjbcJhN2m3KW3UFQQDSfcoQzU7VZW2+olOY06TZAYk4dp9GxTYblgJPqSy5zHEuFgghqmucQN/hQ jGSk67oo3lzgLCwVuc1zD2UgaTcDlCC5ZLv7qF4A9/hXJGRcFLZ6bHkoDKBDI9XCx3zCVxFxq9kc s0oYGwtD783UhjYbEsAeOShbB06RsiaC437KpSNRVx2DSNVigDJswklKfINF+UdwwEHe6Bzmt7bo UoM12cAjaCDvsrhe0t9rKy5j73dZAyfg3V2sDskNBaHEuv7I2uNrkoZsrdwJO1lbTcBVIdbfhQfy 9rICPbIHam8fCuF3mE35UMjmjlXEQ3e3KAN2ppvZA11zfYoZ6l19G1ljhhjeS09kCM5s7WtcCLuW PpbKC6TkcXSo9Qdc73RPmEb7EXJ4CGhfmummEZPoCdNdtg3gKgWgg6NyrfcOKEoWxpc+57e6axwd fb9lTbad0bNuEKU43Z9u6GNpv6jsmuFmEnZJdIC210IXPe40j90nU4m1/Uq0uvsSU1rCLED1IUYI nhmqX+6xp2vkLTG4AA73WTFI6Q6JdglS08ZqAGg3HfshA2x6RvyQmMaA4NOwPdURcgcBRwLXAXQF zRNcCQb2WD+hdJKHXsAs8P8AKfpIvdLfcm7dvhCAOe0uDO4WNIyVkl+yz2NZH63blYslU2WZ1t2g cIAHvDCDyqIEiDV5j9hshcQxxuUBbrsIaNwUmWMsAA7pwkttZU7f5K1YAYSGWJVMfq2srJ78FDHu +/CoDcBdRo091Cbu4UfsgBc8EjsjIDRcn0/KBrmaiLgkogQ9paUAWoO4VgBU1oa2wVH7TYoCnSmO 9lUc3mbWsqLBfdRsVr2Qges8HhQEHhVYNF3IIn3JQo/QNO+6EtF9lHOOkbqFoABvugLAuFe1iClu lDAg8szuuSQAhLGXYRdpuEAk9VlRjDDYcFE0AH/yhS9lO3CKw72QSP0A3QlkJtv3UJ81u6FvqZcm 6INuAAhknlMftexQuZoHN0DmuDh7BECXA3KFZbN/V2QvOsggK5XBkdrhKEmkgcrNkLeXcalTRf7j uo5pJvdTk91eQXqvsiYfYqmtvdRg1OIHKWC3Ou63J7pAi9RPCy/J0FruSeyF7dMnYEqgW062m6No F0v+YHkEWb7o2gWJWC2R5+LqrXNlOTZMa2wt3WqILAN1ZVl2kbqgRdUAudvZWCe3Clrk34UsWnbd ZsF6t91H9rKxYjfYqSNAI3Wig7nsqe02VsB17/ajc0DvcKEMdsO977+yYefgKmH17JwiBG/KlgFh BuO54VEmxBv+UwMDXXJVyAEg9lCibG4RC+pXa3e6Ay2dZCEJO6trXP4N7KCzihc5zHbLRbDJBZa9 ilAWOyHT6yb7nspc6hZZBkMqAznugc7U217C91cb2ONnDdWQBe4VLYbJLjfcAKONmXSWFwJB3CLa QC/psoUTI9sZvpJKY28jdXCINBJ2V3sbIZFMc4PtfZZIeLJDb6t91ZcAUKdrVQLr23XGSMO9xZcp J9xJCw5NDjzuvnRPoSVmIYyQEqSM3tynyv3DQbLGmlc3cDb3XdHMtpsy1lkRRAEOO+ywI6nW7SRz 3XJQhrQ25v7rQoJ0pDNgVWrWzbmyZJIzcdkDWDRsVgA0ZEYNxymNBfcA/KWPTcXUhuzUboQGf0Gz RdY0xs02TpGOcSQUh7jaxQMT5rTZjtrr7npr01kzri0EY2ha4aivgGMbPW6CbBouvRfhhmaKoXcC 10lj72W49o8+RtI9YdEPCxguPwshqcOElKwASSlvK+k6m+FXolkOaJ1bDHBPKQBE9+7ifhen+iVN SjJgkiY1hcwAWHwtaPjJzjjEviAFLJVSysp3HRGd2j22X6PTxVP+j81qM0lNJez2RJ4D+mWbMhxu pMCgbNND5kM7Dfe2y6o6CeGbAqTO9bgGM4OZRTvIjc9nptf8Lu3wYdXajFspU2CYs4vlY0CFx5I9 l6IzKaHKeE1+LspmCVkZeXNbuSkc21tNXfR2lKSV2dEVXRHpVlHNFPhdbh9KKio+waRe6+4x7pZ0 qyLl9+L4lg1FDQNAvI+MWK8Yu6kVXUHrxhlZVSvEQrALE8DVZbBc+ZFwvP2T/wCD4obUT4xc3242 WMy2bVZiM5Stnw2XOk/SLqHhMeI4XgWG1VM/cGJg2WBmnwhdN82YXNTjBmUsliGvh9JBXnbNstT4 eM2QUeXsbe+jmeA6CJ122uvZmV83RsyDRYzW7NdEHyOWZxlj5TsRm5Lng889EvD3RdO8cxHAMdwa GpoHv/4WpcwEub7Lqfxv9P8AKnR+bBsy4HhUVLWmoHmgN2c2+9l7zwTG8KzhRMr6B0VQ0E2fyQvE P1SQ8Zay2I2n/nEEngrop+WVNVwcpTnjpqVo7w6MxdM+uWQqUx4PSVmqBonjkaC7VbcLwf49fAu3 p9U1GccmQeTgrruqKRn/ALR9wuw/AridRQZuoYqerfHBKQHxNNgvXfjZo/O8P2aBEwPlFOXAe68+ OH32P2ejNOcYrImaJcGqjSURiaNby7e/ZfRZNxA4PjkdQ5t3H3XzNLqipamZgGsPNh3G65vCpRDN TOkN5HWP4XinDZkcfR9rE3kgm+zbP4KuqmEY1hlDRMjL8ReQx9xdeneqvUnBOmdBDV4rTNlimcG/ 8sG11r/8CVTDSY/TSNADjICDZbA+q7cpsyw6vzc2I4dFZ15dwD2svTBRlJL0fN1KlBOmfCdR+juT OumQmV0uE08E0jPMp6mOMB4up0f6XYP0VybLV1AjbDE0vkkkbw0L4SXxlZLljp8u5Yie+QSCCNun 0gcbLufO1E7Huj2LwTNIdJh7nkex03C921wjTXDZ8hzk+EzrnKfjH6Y9RM5z5RgkjNaLx/z2tEbz 7C68veLrDcr9GOv2UcWy3QUtK6rkDquCmsA4352XgLG2YzDm7EZ8Onlp54apzGTQAhws7sVzWXs2 Y/iucMNkzFiNXiFRA70PqwXH27rGfFFKoHv0sJ5Ps2b5umGaqbN2T6PEKeMRsfGBpB42WuL6r/UO rocZw/K8L7QVMep9gOLr254Tqv8AV9NqUar2YDbtwte/1asNlb1bwmsAHkGlDRf3C44ofaUV+Gss nGSZ4ow4SMoWRxmzW9j3RxF1RXGkbs8N1ErHgc6ONsjOw3C5jKuGPxPHWhv/ADaghg+Lr574kz7s eIpnevh88IWH9YqI19RXupYzL5eoG1yu/sw/SZxD9E6fBsfd5gZqax/c+y7Z8JPh6xKiwLBp6er8 qihkE8oDvuN7r2SzG6CnzO+jkxAfrHsAZTE8j4XTE3y2j5ubK06Rodzx0Pzd0wze7AcaoZGSNfpb MWnS8X5XszwX9E87YZmOmxymhcaJti4P4svTfjEydguMT5afXU0fnSVGh0wFnabja/7rthtZSdJe kJraCl0xUtOHtYBu7ZeyUVJKUV2eeOolzGXo+tzC978pYiZ2Bj/0rwQDwdJWlPAOlGM5p6qYpHh1 M+WaqxGQtLRfbUVuFyPnEdT+nMuINFn1ULwWe1xwul/CR02w/DsYzPi0sMctVBVvjjvuWG5uV6ML WGE1M8cpylljKHR2V4benOYemuTaehxqvE7CwOEG92FeVvq4yeXkDAbAnzJiHL1ZhPVusxHq3LlW SmMMbGarkcj3Xm/6q+C/xHpRhla0XbS1O/4Kmmi1nTl7RNRnqC2v2amKN/ksL5BcEWasqkh8xzQw anyGwAWJTyiZrqcbnn8L6/JlE2fNFA3SHxBwB2XhyqptH38buCZ6O8MfhexvqXWUs7YnwxRPDw8i 1ltV6PdPK7p1gho62udVvLQ1oJ2avm/Ctl+hwrpPQVdJFG2aVnIG9wEvKuf8cxnrjiWXq4CKjpIv MYAeQsY8e5Nr0eLNm2tRfs6E+oV01q+qmacmZdpG6qmpftYdr7rPwL6ZfT9uA0b8Zqak12gec5jg G3suxOvk0uF9csiV2m0UknktlIvpPsF2z1c6j0vSzJj8Yq4HVTY2/wDLaL3Nu6+g5ScMcI9s+fH6 ynK+EeTsz/TFyZiVCZMBxiSnfGL2eLgrMyt9OfJeIZQmo8Wlllr2sLfOAsL+65nAvqA0VcXQU2TK 6okc6xNOLtH52XfnR7qfF1Pwuepjo30MjHWkgk5b+VZQy4k966LHUeRR2u7NdvRvwr4Dh/iSlybV wCswqK+on+oLtzxb+Bnp3lHpxX5qy9QyUWI0nqDA67XBc1i2W8YwPxk0VXhsb2UrpC97y30uaeQv RfiqbSS9C8ztrHCNn6Ulrj2d2WckbyRS6ZuGd7JP8PP/ANOzLWH1HTyrninEeLwyAFjTwFgfUayF iE+RIMQmr3vo5ZfKlhB2J7bL4r6cNdX/AMeqzG9wp5XlrgL2sO677+oRhtXW9Iac00RkZFVB8p7N HZbjeLP449GMjeTFvkdf+DvwX5BqOl+H43jeERYnNVN1N84cBduVvRPoScWkwQUGE0WIRiz4Lhrv 8r67wuVcFZ0Py55JbZkGl2ns4crXL4qenGcMe8SGNfwmDFGOllH6aWkc4B3sVcOJ5Mko3VHLLneO MdvNnp7M/wBOXp9mHN1HjGEVTKeBknmS08LhZ4/ZeiMP6I5Bylh0FNFlqlmcGhvqh1Ekd15h8LfS 3rDkPO2EMzVXzVGCStuf1Di4t2vYlekvEX1IzB02yo7EsvYaMSmj5jAuVjKpKaxp2bUnGEpyE578 NXTzqPlypoKvLNFC+WMtZMyINew22IK0meJzoXN0F6m1mBPmMsAlJhde92rZdl/xGeILPGX5a6hy BHSUu7WzSNIc4/AK1q+KSrztinVqcZ6jdT4o5xe2Mi1mk7LSxtQlvZdNl3ZEoo+JogIYGub6wbAr an9L10MmWcTLg3zmgaT3tdapKZzqGURvOqN5uFsa+mr1Aw3L+JyYbW10cLqkaWMe4Ak9l8h9n38q ag2ezPEl05xPqRg2H0WGVv6SWOYPcdViuxciYLPguT8Nw+pmNTPDEGvkLr3K+M69ZTzBj+WRVZTq Hx4zE4FgDvS5q5PpFS4xlrp+Dmmq14gxpfNI4/bsve5bsCSfR8CCrO7XZ9bX0jMbwavoQ8ReY10Z cz+m/ddHdEujtJlLOuIV1FjLpnxvIlh13uSe67gyhmnA82UFXJgdbFUs1FjyxwJa75XVXTvpRjuV ermKYs+uc/DaglwYb7laxS2xnG6Ok6bi16O6qyaf+JRxMbeFw9R9l074mOnlH1CjwqnrsROHU1M/ zNYdp1H2X2OfOtuWcgY1h2F4jWRsrq2QMDL7tv3K4fxDdNqvq1kaGiwmqEE+sSsmY6xI+CsYPpki 5KkTLUoSpn1/TaogfkuiZDN50VLH5QlvfVp7rkqUU+O4XViX+dTvDmOBFtl8jkagj6TdJoocZmEU OHwl08sh7AblO6WdWcndWsCq5MoYnDXRMJZI1jt2HjcLM07lKPVljtqMX3R8f0i6S5Vy3mvE8Soa kVOJ+aToLt4239l119TOR8Xhxq3Rn1/qGbW5Hddg5G6J49kjqhiOYW4kajDq296dzrht10R9TXq3 geE5FpcrTVUcmIVDtfkMN3D2uF7ItSzxkpWkeFfTG47adnkjw3eNfNXQrA/4bhODuxmns3XA1uqx 78cLl88eKXFfEd1eypXYxg8mDNpJ22pHMs0NDuxPK7e+mtl7IlRh1dNjBw6TE5Cf5Vbpud+119P9 QvLmU8tR5fxfA48OoK2nk1PdSloJAPwsN43kbSPtzuMUme6qKeKbJtLK9zRC6jaSe1ixdU9CMEyh l/GMXGDGL+ITSufK5rtzuUrwu9ZsA64dJ6Klp6gfrqWnEFVTlw1GwtqHws3JXh+pMnZtrcdGIStB eXMhvZobfkrhCSSlH9Pn54XOM36O0cUjwqkrIp659NDO4/y3TkAn8XR1/k4pJSxwYkyN7XBwEbxd 49lrb+pV4icPxDM+F5ZwHFJDNQN1TT0cuzXn+m4SPp14JnXOmc24nUZgq58Hpml5bUyEm/sN1t4V 4lOcuTpCUnNqCtHvfxHZUwLNfSLHIcxNH8PghM2px+1wGxWkJmcMR6fdS6mryzM6NrZrwPjvc+y3 tdWcp/626c49gLy4Nq6R8dxyTbb/ACtJPTiPBOnXXwUudD/wNDV+XaTuA7n/AAmKf+mUbG1/JVr0 d3Y54m/EniGUnUlfglS7LlVFofVCAhzmW39Vl62+mjiLsQ6T4sJmuZK2sJsfYrsbE/Ef0grumtR5 OZMIkpW0TmspC5uoem1tPuvFvgo8W+B9NuoON5fxaeOly7itc40tQdmsJOx/C88XcGkezbcj251x zPkrJmZcEdmOmjMla8Rl5b87LtqnpaeXLkMdB/Lp3xgw6RwDwvlM6dPso9Xqehq62KLE44i2WCaJ 4Nu4IXxXiM8SmB+HDJcLw+GsxKwigow/cDi5/C6czjGK7Pnqahkla4O0M4RiLJVZHJGahjYv5rG8 lvdfA9Gc/wCSMbldg+VIRFLGP54jZYAjkE+6+W8O3i7yv11y/PT1lXBh2KNGmWnleBqB9l95l7KG RuksdbjFBUUlFDKXTzSvkbf3K1FbE4SX/BzlLe1NdI8b/V3wr9dgGWKoWLaVzz+LrWZhGG4hNSOf S4dUTxncuijJG69a/UA8UlD1jzVPgmCHzsMo7NY+/wB7r2JXsrwAZWyCei1C+Y4RWYlIz+bFNoL2 bd7rvlccWGMX2e3TXvlk9GrTpD1axLpFnykxeippW10Bu2JzC07Hhe36P6nfUSCCN9RkmSWnIF5n RkXJ+Vm+O7KXTzJHVTI2I09DQ0UU1QDV/pNNni+9wF67wWLo/wBWuntPhdFPgklNLA1hZHoZKwgb 373uvHcbTZ7ZTWaD/TC8LviOk8QGFVEtVhgw2ppx/MYd7rxX9XnpxheCy4Fmeip2QVNW4xy6BYOI 7r3X0w6a5C8PWH17sPxWmpqeoJdJLPUN2HPvstcf1QfEJgHVbFcIy/gFYytp8Oc4uljILXuJ7Fer C4rI3Ho+SruKa9ng6hc6UNLm2AGy5FnpAvdDQ05MA2sRuiYxz5DYr5+WnJ0foYXVjQD2F0Vjp37I 2R6SL8poDSdwuRsohzo225TYwLWI3UBDRsmNNxcoAWcm6t8bXjdUd+6otJ7oCnxAWAFlRAYNPuqe 5wdturcLsv3QBCLQA4kK3XPCWWMLG6nEFNBBNwUBQt3VBu9jurNlPOa123KAp5c0AAWV+aGx7i5R FxmBPdYz2PY4X3CAdF/NG5A+E1kPljZcZNI6BpkF9uyzaasbUMHN/lAZEjPRcJGnWL2WQ0GS4B5S qlklOQ2wsfZAU1xFgLWRHlLaLdlbXE7lAGPuVOcLAKEX3vuha02JchQ/g8JjfQQANkoEOdsb2TGS A9kNDTYNKHjhS4cFRdbZC0Sxab8qiNdgNgrN7Da6boaW2G1+6nJox5ojcFpJarA0WKyGRkbEqTBo YRYalLAsBxGrgFVufyrZq0eoWVthLjc8JZBbTcHa5Cpzbtv3TQ3TsNlR5+FbJRiOjLTe6uT0uHss tzW2GyRJGA4G+yWQW86nAW2RCzhpA4RWAcLb/CY1ojHFrqgqOEvO/CKSEduAhmc6OHUCseGuMsbg 7Yj3QBvsSiaEGrUwO2KJ5uLsOwQEfsD7oGE99yVV3EXITI49r9/ZATXYImuF0JbY77KbBALfKfMN gjY7zfuGmyVJuRZNYBYX3UAcUvqI7e6bruEGkEbBC8OkbZmxWQGXCPe91kRO1M1DhYUQP2u7e6yo SQ8NDfT7rIHWD2jkFFvGPTujFrAFA53YKWCQvOo35KkvpF77oQ2xTTYjm+yASyQkbhW5oA+VYA7I nNuLlALtcco9ekWASZJQwEXuscVQa73UoGQ+2vU7j2SXP9RsLBR0nmjcWCoNB/ZaRLKe4uI2QEgL I0XaCEqRg91ohcbmAeoC5SJSN+w4Ckjm2HwkulDjaxQhRGwT9X8lx7AJO7rBE5pawg8FAAGkwNse SpJdmlpRC4jAuraA+1+yEZbhe3ayj/UBbdBI7SCb7BFTuu0kIVCHUxBLr2t2TmG5aL2TTYsNxdJZ Yvv7IT2NO52Va2teDyreQWEgJDG3Nyd0IVVSmSQObtbslipdqtbZGWXJNrJcT7PNxeyqKNLxLzyF A23ZU1pLr2srkkLeDutEoGRwGx/uqZYG1kEsUjm3PdXFG5mgE3QDyHAA2/KInSL3Cp0nqsUgAvc/ V9vZAObJG47conRB26S2QRHTYWPdPj9Lbg3CnsHHVMRMu3Cy6V2iw02CN4ablWwhw2OyAY9/rBbs gmHqDuflVHK0tI4RCnuPuv3VAg7k3U0kBW9oY73AQ6tR2OyAJ0RcLAqms0R25soC5rrg3BQ+sPue EAYNh8qWJaTwoHDhWTq2CABryb22VySiw34UfGS0AflR8TTuUAN7uF+ETr/0i6qZzXNaByEcUgY2 x3KAZ+te1mgxnShc+Nzbjn2Kn61zvTYGyDUXAkN2+EBjTGzb91jSEvAcP8LNe0OjcXBYscd2Fg2B QEPpYNlBvt2QyXgkawnUAEUYLifZaMsYG737Kw0botm7HhACNVlGQmx45UB0u3NiqbUxQkgkajws eWUveSiA18lnbC9kpjruJch3deythAfvuFQGWEtOndQN9Nid1fmAGzdgqc0MOpC2Bw4hPYQGEEpY 9RvaysXF0BGXNwTdRrbDfZQuA/Kscc3U6IWNlHvAHO6EkD5VOaH791QU+QuF0thLgE7yi5qIDSy9 tx2QAHgdlRe0G5SnPMjt9rK9Adv7IAmvIJI4U9LXBwHrKsC5G1hZDaxva6AbHG1+pz/vKU5haCUw EP2Bt+UEg0jYoCi4PbayoXLdNtgrcBpQl5A+FKAGgDjn2Vtjtveylg31A3JULiW7ogHcR7k3Rh9m XJ+5JDTJa24TiPSLgbIwG5xaALbJjLWCWCZQBsmtaQLFPRUNLbC6WQHHdM1ktsBZTy/TrPChoo9r Ij2KH7m3buVTGva0l454WbBkRNMh2VuYAbXuqjkLGC3dEY9I1E87qAQ9v8y/ZVa7iredbrNCINAI N9/ZChBpb3Vckg8oxuUIeNRBH7qkEvYA/wCU1krW/cqksBxuh2c0bBQDNQebjbsqkGrYJekt37I2 uuN+UBQ2A3srLzxdDs4hSZjQ0m9lbA1pB3uhLvShgcPKcbf3QxuBuDyoAwxr73G6gIjBt/lAXGA3 cOVCQ/jZAU57ibqFxIIP91GM2PdU4gmxCqAJYWjnZCGkXsUzzCBYC4QNIB5sqwE1upGCQAqB2uh1 3dpGyyC7u7cIr2clsfpdZyMuGs2CAZpu7ZDJK57dLhayIbtFuVTruvcWHugADgNgg1eW+x5VgW5G w4QOF3aid0LYXmgN5O/ZWLSN5QsA1XI2+Vb3hrhbhVkLEDWbo7g2NlRc4/gq7eygJcFC3UTxsiA9 yrLxwrYAFtRurDS4k32UZE5zvS0k/Cr1B5ZbfuoaLa4P9KHTYkKr9m8o3Ahodw5DNlBoZuFYcCLW RWDWXdyhYQ4IWyEXIsqcbG5PCKwvdRwuEFhMcC4X3VPB0E9vZUIxa5Kprr3B2CEAadbC12wTLgNb v+6DjsmNA4KAXLcj3QR/hPI5sgJ0kfKFsjhpF/ZU/wDmMB7pmkOab8pLwWN+ELZcZL3W/wAphdpd ZLZdpBCtw1SA3sEBc1nDUOQhZdx5sFkNjYAbpbmC9xwhkINLd0MhJafdEJdLCDsh2cBYoBDSb/hE HklW+M8goWgt5QB90JPOyO9xtuhQAk3FrKiCe+yNunuheOzeEBAbFWDcXVAHdRpAuheAr6W77KtO oboNzzwja67bd0ILdHc27IwLbdldihcSCgKds7dU7VcaSr2PKu2khAW5+kXO6p3q02GyI7tN/wDK Br3Wt7ICOd6rBW4ABQDdUXA7d0BGkb3VavXtx8IS3U32VtGkoaokp9YcOEwSeaNNrFAQDyETbDhC UDpN/wAI2gDnkojYlDI4AiyEKLWg7De6y2BlgAd1isOp3G/uqleWm19/cK0WjJk9N9uFj6w7hCJX u2JVAEAqEDMuo2twrMnpSi06TbkqFpAQFyESt0l1j8rFhZJrMbzdoOya6C7g4hNjHq3HCANjiDa1 lT3EG4RlwIJt+6Q5xcNuEFlh7nvAKaAQeUMdmi/dHqANieeyFsWXWvtdW1wsSqmdoG3JV6LRAg3u hQHThp90YeC3VwkuZqOwRFpFggGtkDyVBsCqs0WAFirJFw0IADwrF2Dfgqtw4g8KzuR7ICekXtvd UGiMb8FXq5QOdq/CAIkbbKcm4VNuRwoBbugLvzeyDzTfYIHm7wbp7ZBoN23+UADTqNyshhsLALHI 9uETX224CtAMPJ1XSdXcpzQCN9glyRtYNje6gCDA4fKGGXVqY42I4CjDYE9kprml97epAZDGuaDf +6nmFthyVReSLcJbwWjZAMkcbXCFgubk7KnuIiV0zmvZYX+UA9gAYdwkvO225QSn+kXsqjabgDdA XdvJ2v7oo2Od9m491bKXWSJm+j8oi8U50M47BAW6MMAFrjuUtx39mqnVLtRBFgqLwTxdASxva6Pj khDp/qPCEkEbFAMcdtkgg3I7lMdsAAVThrILTwr6AQNmgKX+Eu3pvwj1fy7pZEWdxdCDdWwao7je 6rWGDdQoLGOD78qnwuc7URYJ2sHg2Vl12WQA3OmyjrW4Q8FESeEBA4WCsP8AXZUbAXJAshvcXBv7 oAjYPuDsic7ZLJHYo9F2XQAMN3WF09p0tJbufZY7meTIC3uiaeS088hBYM9ToG7QW33WLOQ6aN0T dA7rInIFrC5S53gAAN3QjMgHe+1ktkn8w6TZLiOnm9yrDLEuB25QgUjy64Q20s3Vgi9z2R3DzcjZ ABHcvDgSAE4W1c3ulMYdRI2CmpzXcbe6Aqcb2HKkTGt3cUbow313vdDJZrRYflAWXB0t+w4VO3cS hh9biQER2fZABbTce6trP7K9PqJQSThlm8IBroyGflLB08phnHlBpBJ+EqWSOOPVff2QDGuL9gjI DSO5KCNpcwO4uqkbbcO3QBkWJJGymx4KGMODCHH9lARbdAA9l5NSuxe1xCJnHumNOkoDHpSXPuRs EqYaqgOtws11msJGx5WOxusEuQqDa/zG2tZVpsbX3QAuZxuChLi3fuhRzyGN91LEDVwEppDgXHsr ZUGZpbbdAMfMwxlhNylBga2xRAMaLEepA+QM+6/wgGMZZ4I4TAbuseUlkmkB3+CqMxtrAt+UAdRE 82cN7HhPa67QdOk90qObWLg3S3TvjDu4KGQnvbqNipI4vjuBdwSIoX1F3AbKoy5rtIKAv9RKWjUL 2Vtl1HURYKnt1P2J2Vndmm39kAcR8xxuTo91P0bI5bsNwVT/AF0+huzlVIXMjeHXNu6AoReW4gC4 SX2LtwjbUFwJKS+W3ZAQG522srJ3t2QvcSW22BVSel9mm6qBZaS5APQ66O/dAdyVWQppcX6uyaXB 4sdku5CjgRwdkBQgZG7W03KZqve3CW2Jun5TWsIACpSA3G6okAWKt4N7IXNvyOEAbrWBVOO17IHA jur12aQVDLBkJLVULd99lNY06j2Tmnzo7gWQC9QBNirb6nEdkBadV0zVqbYpYsB5Fy211P6LDZUT qcbbD3S2uIO4VIGA4nlGL6rFQN1bgqMdd5HdDYwi1tkmq/mANHujfyN1R+5pUZgp5DWho7JbZHXt wmO0teSTsnRmGUGzm3soBF7Nsdwh1KTPDWkNNyPZY1PIXPIKrA7yvPO5tZAWaXaQCmOiNjYqC7GE E3KyARdW25Uad7FGQLK2ADqHBVF5aPb5Vlott/ZAdwoA2TNIuHHUE5zRUaS42eOCsURgXVua/wBJ CAfPMW2YlR3DuUNQNMjdXJREFhBPBQBB/r2CLXY/KWXDX8FGRpOoC6tgMuDhuN0D3BpuAqD9Tr8K 3H4VsFA6t3bBULseDyFHt2uQqikLuBsoWgpHm9h3VNswc6vhMP23Kx4xqJ3Vsg9jrdrKngvIIOyG 9uSib/hZALmadwq/Uubva5R8mwIVxFgJDtygB8/zORZKc/1WvsE021GyxdBLygHecLiyt8wFxZLY zfhG9rQwakAbXAMvyD7I3Wc0C9kpjrbC1lb4tYaS7j2QBBgB5uqjHKCW542TYhZu/KqKAG6XXRF5 eCCoHO1WI291ACASlCijcM2UZdzRflE3i6twGlLFg6w0pztJi1MvcpTQGO4vdMc/Raw2UKYcEjtb gTsE7zPZLkYDNdnCoggoSzt2pP8ALcb8bLi52kRl7SbrPqXlzeVx9TUtZE5ndfNR9GRjsF2l5O/K U+f9XEQ0FoGxKKkjcWlx+090yVrQw6BYd7L0o5GLTujY7yy68g4XIU97EOXE0s7XzkNg9beXjuuX p3vJvoIBHdLAcMXmuPsrI8l++4KNr9LbDYoGM82UArICeWyDbayACx+FbrsmLANvdE7blAKJFrBY 793ae5WS7Y3KRMNRuEIziYY3R18hJNjyu3OgGaIMAzK2CZ4iie8EFx+V1e6K5JHPdPpj5bmyREiQ cFvZdItLky47lRvk8PuJUlXkmkfBUxztdGD6HXsV4K8a/SXF8M62f6iNK+ow2ucBG6MEhjvkrpfw ++MrMnQ7E4aerkdX4YSNUbzwF6rzr9RfplmPKRpccwrz5JRqYGC5Dvyvq49RwfntRppLIpJHc/g6 6dvpsKgxKtj0lrQWki1tl6Gq855czDV1WA/rYamoc0xyQNcCR+y8IdN/qY9PsCyxUYfO99K+NhbD HpO4XRGAeOzBcL62SZqigkbQPeQ+IG+oe66Jxk7ZMmObVRR6Y6w9DKvph1Bp8bwuAy4XPUtIIbfQ br1p1GoMXx/o5LFhUz4sRfRh7XRmx+2+y8eYx9UXJGJQRB2Cy18LbP0PaDYrkoPqz5EbG2OowGrj YBpDWb2W5Sc2n+HOGGcYuLE9LPDtmfqVUfqcafNT0dO+zp6n7i4HsvX2G5YdTdOazA5/XFFA6Npv u7ZeOcd+rRkrDqANwbAKiWY3OgjS0L5A/Vyw+qp54ZMtyNc9ps6/ddnKU1TpI5+OXTO0vCdmvEX9 ZMawFtTK2ipXOa6B97bfC536keBsxTpVR1YaZJaafU1reSF4Gyp44cVyV1gxLOmGYYxzay+uFwsL L6Xrn9SWt6v5VZhAwFtLMNtR3F1hZU8m+uiy0kttI758F3S/G6ioocbjhfBRxgG7m8leifGn1Rwn JfRvE2YnPG11RA6JkZO73EW4XgXon9STFOl+Um4VVYeyXy7mMNabHZdD+IjxOZj8TOYWSVuqmo4v sga70j9lITipb2enJhnOKgdbULZHtmqLfypJS63xdcrDStrq2mfG7cuAI9t0iii0UnkPN2t2uE6C D9FYxv0ychfMnLdJs+3COyCRsY8E+SKmaWlqIAXCMhznN3tuvZ3iR6bO6ndIsTwlspjqWwmSIg2u 4BahOiPjQzT0L8yOiZFVX2DZNwQu6n/V1zJUwmnq8rRSAsLS5p+F69M2mmvR83V4XkXB0PkrNFR0 n6qwMxxhd+hq7S6hvYFblumHUnLXWvp+1+DVsU8c1N5UsbXjUy7bG4Wg7NmfMX6iZtxTHahjIX1U pe2E/wBIJvZfT9N/EHnfpDigqsBrJqdoPrhjedLv2Xp1GRTnwcoaSsfPZtOyV4BsFy9nesxPEQyq oHTOnihAuLk9/wC66y8fvTPJWXBl7+FwUmDYnG9jQIQGukF+681u+qT1fZCIaZkGq1tcrdRHyuhu pvXHOHWDNcGNZlrC+aI62AE2BHsFHO6c2efDhyQlSRvB8K2W5MA6WYbJKDqqIw4E77Lyp9VPpJLm XKFBmalcDPQPIe0mxc32Xj/Kn1CusOQMMpsNw7EW1NDAzRGyRt7BcD1b8aHVDrhls4LjzooqLVqL ohYkLhDJsbkenLppzqvTOm8FjkmiOrYDkFfR5Grhg+MNqHm5ifqC+fppfIgc0NO7bakVDSPl1va8 l3YXXiu3Z9qPCpm5XwRdecs5jycMMmxKClxGMAeVI4AldyY706nq+qOFZro6uH9FEzTK0u3/ACOy 0K4Jj2PZZxFtZhFfJRVUZ/ofYH8hfc1/ih6xyU7Kf/U9TTxNFgGPK6Rk10fK1Oncn9TdT4gcowZw y5TzCsip5KSQTeY94tYcrkaeowLql06ZhFPisLmOhELyHgOuBbhaMK7r71QxigdSVuba6ogds5gl J2XG4P1RztgUd8LzNiFG69yI5DyvZCUXFJuqPMtPkbbfs3z9OMuYR0sy6cHGJwgAk6pJRsvhMn4h g3Tjqfisf8bo/wCF4u7zWtElz5q0vYh1V6hYlpmrc110z7f1TOBXFHN2c31ImfmCs80btcZSbLe+ NybfZw+LltKujfXiWVMGj6gQ5z/i0ED/ACPKLXSNDXD3Xwfiky5lrq50tqsEnxqiY1x8wOEzSbgd t1piq+qWfsRp/wBNWZtr6mG1gBOVw0eYc0AER5hrrD+l87jf/K4rJt5T6NPRObbBx7AafKfUPGsL pqj9TBSvLGPBvdcxlrGIsGq4qlzLkG9vZfN0FK5lZNUzSmSplN3udySsubzTcxtBI5BXlc3Jts+1 ixbIKLNr/g28YeSW5Npsu43i0OH1UX2GV1h+F6EkzP02pszOzU3M2GMq5I9L5BUtF2/3WhSWLzYT NA4skHIY6xS4KuuewtlxOsY3/Y6Q2/7rtF0uDxZ9M8nRuu669Y+mGYMJo8RjzfQur8ImFRCyKUEv I7L6XL/XPpr1tyNJSYji9A1kkWieKolaCPkXWid1H+rcTHiUvp5AeUMVHK+S1PXVUTxsS2QgFdFk W1L8OL0knd+zd5hufugPSPDn09NjWDxTRAk2eHyEryflz6heC5R614nJhsbRliWbRM6wGsX+4f3W u2bDJJZf5ta98g93m6GbB6UR2e5xf3cFr5Daak7szDQ7Uq4o3l4T4wehuPOhxmTMFFRVobcOqLNe 1eLPHF47v9eT/wCk8oVcb8BcSJ6iN28oXgBuARVAuypfYdiTumUtDBTSnXcnsSsRmou12aekcuGb H/AN4julvSnApqbMOMCixOY+l0vAuV6d6x+LTolmPp/iuHVmZqXEoqmBzRFCbuDrbG60ljDIsSLh p3HdvKxP0NFRyFkkjoydruJWYy+++R68mmTx7EbHfCd48su9MK/EMq488xZXMxNHWvvdgJ7r05if jr6DUkgxN+M09XO0bSRQh71pNmloH05p5vU3s4E7/usJkOHx08hbqa4faNV12eSMpXXZ55aPhJej aZ1e+q1limmgjyfRT1gY+75JNhb8L6XK31VOnWO4SxmYMPfBPb1tdZzT+xC1K0WFxyWfsQRv2VxY fRyzvYWONu4KbotbSfEcvZuAxH6oHR+gwmZuFSTtmY06Y2x2be3YLV94hes1T1/6v1uaZQQxw8uE EWs0cLr+LC6Bj3gRuc4HYO2XJUFBDTu8wNAt2WXL8O+HSeOe4Cmp5i0B4uGrnsCzLimWcSgrsMqn wVELg5pY4iy4p9U+lc54bqB4akxVjpAXPHl6t15pJH0nVGwzo19VR2XcuwYZnGidPVUrNAnjG8gH Fyvm+vP1R67qNgdVg2VsKfhFNM3Q+Z5u94/8LxbFl+vxmFr6agdVxNFw5jCViS00+FTBlVh8tOR/ vYQusLjykfLnhjLi6O4+hfi5zh0GxWWvw+plqYKhxfNT1N3Ndcr1NTfWFd+jEdRlEvqi2xex1gD7 2Wv06KstjZCXE7CwXIO6b49LS/qKfB6gxEX1mMrtFxfas5ywRjHhn1nU/wAQOZerGdsSzJLUS07p X+ZCwOP8sX2su+ukP1Q839NMvwYPjmFjHqenaGxzPuH/AIJXj5s0tBKaZ9OWVANnNIX0uB9OsyZt B/hWDVFc4blsUZK6zcpNJoY8GJRqzv7r39RPOXXTCH4Jh9G3A8InbpmjYSS4HtddR9I+ueb+hWLR 4nl2okgj4miicQJB8hfK5hyLmfJUgOL4HU4dGDuZYy0f3WHQ0WIZirI6fDYpKiWTZscYuXI7iq9H THpsSbkeucS+q9n4YDJR0WHxx1T2lpnlZct+R8rxtnXqFj3UjM9VjeP1k+I1lQ7W58zj6d72C+4x PoH1EpKD9XLlLEBEG6vM8h1rf2XW1TLLQyvgq6aSmniNnMkbYrj9qqJFhw77k+QYMXxqgnFRh1bU 0Tm8OgkLbf2WVVZozBmJrYsVxusrmt4bUSl1v7pENfGxrXFzfL/7JT5IamsD4nC/exXBNxPe4RZ9 70x6zZx6LYuzE8rYlJT1LBYs1el4+Qu6Mx/Uu6xZqwCTB5vIpI3t0vngbpkd+66GytlOuzdiLKHD aV9TUyGzWsbddzVXgT6y0+EDE6fLjpKdzNYYfucPwu+Nu7PPkxY5P7HQdbU1WYa2XEa+oM9S92t1 3XJK+96Z+JLPvRmaR+X6uSmikbpu0kWXw+N5dxjKOYJMLxqhkwrEGGzoJmaSuUwTJ2L5zxWHDcHp X1dVI4Naxg2K3kk5cyNY8cIKonbNd9RLrpVwfp48f/km4ddl3Ee110NmjHsczzj1TjeLObJVSm73 8br0TmP6ffU7AsrPx39M8RxwGeSPRu0crzK2tnjdU0dSHMqInFhba24XJp7eDNY3K75ONbSFznWn kAB3Y2QrnaN4kp2C7oizdru4PusLC5IIyWVloJifSSFzNJTyV9Qynp2iQuOxaOVwqUUej69H22W/ Er1UyJAyiwDOVZDSt2ETnk2+BdcHmnqDmjqVibqzM2JzV1Q7l0jjb9gvSfSf6d+eerOCQ4qGswSm e27Jalti/wDAXyXXbwSZ66Ax02KYuP4nhD36P1FKNQYb/wBXsvRjbfTPHKOFvlHRGGYji+Vq41WC 4pLRzjux53WXjPVPP2Oxupa7MtZJC7ZzDKbW/uu2+lHh6x/rdjv8Hy3Raywjzqpw9EQPcldzZm+k 91BwzD31OHYtR19U0avKY8tB243XROSlVmZxwrvo8Gfp3Nqy905klPLib3WbQY7mfK8rpMIxmrom O3IhmI/wuT6lZAzF0ozVNg+aMOlw+sY4ts9ux+Qe6+cnqBTEFzXEHj2XnzQkpfY9mLxzh9OjNxPH sy5zqWS43i1ViL4/sdUSFxb+LpmH4rmPA3OGHYzWUVzuYpSEFA2WrBsNGrZq9L+F3wVZn8QlYZg5 2G4HE4CStkad/fSuUFTtmpRjBVR54qs4ZwrqcwVeZK+phdyx9Q4g/ndcF+gLpfNllMknbUbrZt1A +kthOGYFU1OG5qex8LC8uqNr2F1rZzjlSbJWasSweWf9SKSV0YmB2dY2uvRLiNxfB5MfjlLhcl02 mGN3BJCVCwtJvtcoKfZgsbrJHqsvEe7/AIB/UiLZw2PdU+oYYi6M6iOyt7raoywOB7rHooBTyucR e/YoB0L5JAHW2PusobDlJa9r2O0bFXGbjc7oBhCq1t0YI0odR1WtsgFk6uOVGA6T7opGlpuFIWlz juoCyQLAjhWBYbKS+ker/CG9xslAuxJv2R+Ux/HKKIAt3VujAaSFQUGBjdrXQvJI3VN+0qrWFuUo BNsf6QR8qPaLghgH4Ubx7K3PAbtygE8uuNrJjXuc3kmygAduoRp3QFh1+VZaS247IBci6moh1ux5 QFtIcbg2IU80ufp7JLja5HKfSkuGw3QouQFpu1EJLWsFlGLYkjfukFouRbZQoyJwLt01wHKxAQD7 JzJwXgEWClFHQeokHZE8FthtseyB7vMf6BZNYwEEE3KlmkyRgl1z291Hi7vco3sIYB7Jb6lsNtQJ v7LNlIWOv8IDKG3uCE69xcfafdAS0uVsC5JWOsNVieE97mwRN1W3UdFHoadAJHBS5XCVwuOOVQC5 2rcbBLki1LIlh0hvsgLxwOyGaERx2cimaQ5oPCOJw8zfZVPZ8nNrIQt4tEBa4WFJRg6jY7rLEtjp AQFxuVQYsURawNv6QmMBA2O3sie3bbZXHtylkojr2twEBkDCDff2TjZJMXq1HhQpPOLzwoTccKwW u4FihL77WVsgD2XPyiZqGyIMLiLJ/lgbjlWyCg5w2vsjbJpPKpyAi/5WTQ5zdZBJssqO2kW3WG0E C17p0bwwWB5UYGmTRultnLgSN7KBxaSHcJIJikJ7FZoGXDKKhrg3Z3ysiBgMbg42IWDA9kMhc3us hshmk9lKARYGDlC5wcwi9k6rc0W0jgLDL73ulADyi69ip5IHYXRh2qOw590IJZ9xVBbSG3uNlNnc cpbnX27Kmu0u2C2RjQ/Qz4SZHsvypM4bAcHlYpeNVhuhkeWX3sh8m53smCSzALKAixJQAelgsBdy WQS3flE8gfbuT3VAuc3dAAXBsZBSgdvlMb67i3CoRlp9XHslAFzS7Y8I4bQ3B4VOafdRwNrgoRhM eC4kG/whEuhx22QPOht+/wAJOpxvbhCGS6oIN7elW1vmbjYJDHBzS08LIjla2zRurQLmboYCseNx Eh22WRKC4c3HslWN7jsqgEXgg2G6Q9okcCeya4dxyhaBYk7/AAqBj23aN9kJIDgELJgXW/srJaTv ygKsHP5RNcb2tsgaNJ3P4src5zmjSQLICTNbcByKof5FE0MNye6SGuc67iimN4yO1ln2AYQ54B3s nOAFgOUmCr0Bsdtx3KyG2kkudgFoAuYHAaRYhMALG3J2S443Eukv6b8KnO1bX2UsBAFzHOaQVisc XEi1lkghkZtylAgX90sE3tzsic6zEDbHcgow3WVQEx1rfKIbAk8qtgVTwBvfdASR223KJpBbYpZf cAouQCgFPdpbe26jXh5B4PspK4lyhZc3BQBQu9Ra5tvYpgeeO3ZAZBtcboXSBtrIAZTsQe6S30E2 NkcpvvdY73eoXQBSM1i5N0MD7PLUvzC4kDhVM17Ga4+RytGDKe31W1JLmOEm7tkHmfqXxyX06RvZ FKfSb8qegVVMiIDrXeOEtrCAXuIt7IgBouRdyxpWyF4uPT8KoGXb0iyBziwerso14FiUYHnC6lgG NwuCeE0OYWm5CUBcke3sp5YcPwlgMu0jS3cFW3c24SwdBO+6IOOm5VAZNhv/AHVNOk/KFrtRF+B2 RNfZ591OAWL391HNtcqNDtR+VgV2IPp2ub5RcP8AcFQclG8BtybXR6gwbBcVEJJ2RvDtI7hZZlOo NOwQFzbm4CWAWgXTi/ULJReQ06hYhRgPWSB7Kc8IWnWNkTdiqgQssN+UtyaH6hxuEs2Dd/uQAl9t iD+VJC7SB290RcQywF0MV3MIJslgsMDbN3N+6trbOt2VxtdHz6kYHeyWCogNRFkekkXDbomGzLW3 Vj0hRgprd78FU8nhXtpdblRkZda5UNIIOLu6c8nygEtjN7+ya4HbZCionFjwLWWTI/UWh1gscsLd yeFPWXgndZA6UHXdpu1FuQLlABa/yhLwHC6gGOcIwPdDpDruvsiLNW53UcQ3bsgFAlpvqsPZTzC2 9he6pwA+fhZDWt8vcepVAQHFwN+VbRcXVsbyodwQoCONxsq5ABU0kb32PZFbb5QEaPXayjgBfuED o3OJ9VipEQ0aXbuQBtdckWsEtkLw8vJ2CbqaUDXayQdggI94lHOwSw8ONh2VtboJ07hPlDdA0Czu 6AWw272S5nEAEbo5muLBYbqmi7QHBAW19xeyF4Dnaht8JrQAy1lRZvwgKbcN3SY43OkcTwnkABU3 0Et5ugAlA1iwRP8AQwu5Kp4AQuNh7oCte2oGxRwyGUEOKU1webBpCdGwMKAovDjp9legPYbcqwCX /HumHQxuxBPdAY7mOAAPZEQC0IiWvNlRcL6bXQEa8jbsoXWVEaSogLJHJHCX5Lqo3a7Swbko2v3I PCFpa1xLHOt3CAYK59PJohAcOLlRzXi8jrXPslRR6pCSNk+QW73CFsTE06i5HuXG/Ctu4JCsbXVs gIBcd+EWw4UPwqKgKvY8IuVXYWUNxygJbflCRsreLi6ppaRygLBDRY91C31fKkliFUf3XugBeC3g 3HdQAhvunuj1boNIKAEP0+p3YITK1+/Kkkeoj2UYwAWCAjT6timtj9WolLEZc7bsic8tuCd0LZJH a3bbBDuO6gGyhOwKEKa67SCLlRjbj2V32urJF0LQTjYC6B9iOVT7k2Qs22QgbXaBZCRd4+VYcLjZ C95buBuEAT2iPlE0tLflDFKJT67X+Vbo276TwgAe4Xupew2QAHUe6InYWCAhaT8KA2Gyu+o2V2tc oCgShPN+6l+Spq78lAG032KhaSVTeVUTn+rVwgLJs090tpLuyYdm77oZDptp2QFE2IvshkIabojc DUe6j2l1uCgB9R3sdPuia4PHylmqe28bmEN90cfqZsP3QWWLkIgFTAb2PCMMs0oWwdjsoWBTTt7l C8EDYoEXa3eyhFt+SqHCJrbcoQFrdI1FNLQ5gchJDmlp4KoDQLD7UDYexGyBxI3AQa7G1kZcbb8I Ci67bq2ghqoOAHwiMzLj2QqI31C19kvRpJsmF7eQpq1DYIQUL3RGMOIddXYPF72UFje5ueyFoTUa n1EY4aOU+V2ltmoRcm7tyEEjz7IUouuBpO6aGHRc7pMdy7gBZWxaLIBUgJAI5VsBPbdHpB2B3VWM brnhAQC59SFwDRcFF5g3/wCyW8gnZAQnbhDp1cGyNh1GyXNJ5bwgGAFqW4kEko9QezUdigcDbjZA yAB7UdrNCprLN4t+UThZougsG5aFRkDiNiic2zh7WVEXPFkBQdrdbgK5XAR+5RObsCEDgHOt2QWX cmL5QxR6HhxCs7Cw4U17BCUG4l0moDZE52/GyEygAiyEyBzR2PKCmECHchE6Rgbta/whYA8bqv0/ quhQLX3VtBjbrvt2RFnHt3UkeJGNY3YDkICMqnSsN+VQbrO2ytsQjB3/AGRhha3Vf9kAp41bc27q mgAexVl4vzYqiQR7oAg7a3ZD5e9xwq03aSDwo2oHl7Df5VsDJDZmyRdzWktCt0pfsOEYNmi3KWBT Kg3+1H5t2HayN2kOG2ypzW82TgFNILBYkH2QD+Zs5WPUbcIhEQNzdQEEW4PYIjc7BC5h0g3sFHVD WR+kEuQB6SDuhN+xRRyCRl3cqRO1B1hx7oASdrIACD8ImkE7qEXIsUAelpbzaysSAN/8pY9JIKp8 gAAshLKlGo6gVItgSQhc7T25V6ixt/dCFO9TvaypwF7jdE5/F9ghLr7AWQAPIa3Udk2MhzAWlJqb vaGgd1k2bFG0NAJsqANYOxFgqDwHADcIiBKN9rKgGNZccBQUEZr7Wt+FZF2kDkpcZDjcbBGXEH0i 490BACG+pJDtbiOya46uShAaQ4DlAELsbtZLLmlwN9+Ep5c1tjsqjZsCeEBlWuLXSJi1xFmiyKMm 51A2Kt+w9IugMeSSQGzRsgdA/W15OoHkLL2IAtZRh9J9kAwu9IF7BILXNkvdFI4O02NyFA06gTwg BJIJLnfsrbK0EXGyXUNLuNkhjjp0kIDkGytLjYgH2WPUVYgkBtc/PCS0Fu9/UmFjZx6xuhooVj5H X02BTg+7bkJMMTaYlpde/F1ReWm3yqZHkvaAben3VOcAbe6OSTVThoP7LG0OIuSoWxgaA/c2aikB jcDERZKcBa7jsoNzYHZCGQT6A7TdyW94c/1Nt+VbGkkAHfuidGdy47oDHLXk3AuEZY97LkWHdNa4 O9N902+lmlzSWoDFjaWNNuE6CHzSxrjdt91T2F0epuzQlxSE2LTwgDqQYa0MjJDCn1FMyBmoD1FC 9zXsDj94SxLJOwh3CAEQyOZrA2QOLmNvbZPFeImaHcDZY9RJrYCDt2CoBc4hzQTZF54jvc7FIcHO sTclU6LUNyoAmBr3kqyWtuCN1NNo7N+4JWlw3cLqoBAg7IRcfKEBxdcbBG1lzYmwVoFXug3vtwjd aM6TuCoNNtkZnsEuABVRnzBZSwG54RR2jdfsoghohHKp7gDfhTzdX2jZJfu7fhaNBuLiAQVCbWud 1TniRg8scKAt03d93soAjpttugIG+6mq4NhuquSEJQuxAKdHr02VBuoWO3yo6YMcGqgYAQN0D7W2 vdW2QHbuhtd1ybWQUSMavgKNBYTcXTGkEbcqnXIQiQOoNN0kgsqWv5Cdp2VggbFCsj3BxKEEs+Ut zz5liPSeCmlmgbboZBdFq3dwUjyItRGoj8IxI5zrP2CsNDXe6jAprNDSGuLlQIjabD1Jkjd9tkJb Y2te6nYIyR2m90bP5huUoMNz7JheLj2UBQb6+UwWAKBo391eo3sBZAU51xYCyB2wAKJwQOIfbdAW 1vq55T5G2jAb9yQ4iMgX3TjMbj0/ugAewEN1bPHuhOp5GrhVMCX6roheRu3KAogNIJ2CNzi0A8tV NsWFrkgueSGWOlAO1e3Hsr1akA9Hptz3V2t+EBbdRdY/aqlf5Dw1ovfuhcTEbprZGyRlx57KoBF/ ose6XCy2rbb3VOddqBsjmv49KANxs7YbotVwCqle1nqG6vZ7NV7ICjsNuVG+557qeot5VNIcbHYn lQBl7PZCxocXFQQWJOq6JgLfx3QEHpF7oJLSMPumHSVbgHCw2QGE6TQNIG47p8U12gHulywEOuTs nQsYLIAy0c3UaCBe6OVrWt9Jul30hUtBHcbq9gOdkIJdyoWX7q2aKMgZsFLOI+FWoDtdG123wsgh 27Ib32KJ+47IHMNtkAQs3gKyGk9kFy0WtdAST2QlHadTI1zdlx9RTuID9nDuFyktOANgsKoYWRne 6+fE98hFNK6paWaNDR3VVDfKjcBujonaINP9V+Uuqu7ldkzmcbFFO5xMLg087rkab9YXN8xzdHws N03kH0+65AER0we517+y0B59IuQlv1D1NNj8KRPL47nhGSSLdlgDIADFqJu/2KGW5CBry1pHCsnU OUApxJVab3CMN+VRbbhCWYzhpdYcd7rGkxEYbI7ywHOfwFkzfa63KrL2APzHi8VPC0vkc4AIuDLY LYaqup9QgMxPJ9ljS4FMwDzIC0/9Q2C98dCvDMHw0lNNQsq6iaznNe2+kL1LmbwqdJctZSdiOYqG mw4xxF7pXi1zbgL6OOLcbR8/LqFGVGmF2H08MJ8yjMjwL6mtuphWFR1DnyxUrjvawYtzvQPoL0mz /lOorMNwOhqqR8hhMjmgybH/ALLqnO3hYwPIXWyjiw7AvOwWd4cQyP0j8r048Tm6OEtakrNZkmWp CQ4UtTA72DCLrNZlPFHxAx0FQ4e5jJW7bM/RXp1lzBafFMVwijiiZGCQ5gA/C+lyl016c4xlduK0 eAUppNBN/KB4XXxRgt1mHq76RokqMs1kDLHCqku7kRHZYIwmqaHGPD5QByXRlb1ctO6PZsxCbCKb C8K/VxktdFJG0Puudn8OXTbFxLC7LVJpPJYwf90ajHtNHKOocnwaEsOwOuxR5iiptbjtZoN0nFcF qsvVAiq6F8DnGwdI07lbhsxeC7Ask5+oMby/h8cmFOkvPTyb6blfQ+JvoF0+m6O4/i8mXqdlbTUm uGZjLFrh3Rwi0tvTPR8lLtGm7/0szNXUJqosMknpNOoSRMJFl8u22G1TqOaA00zdjrbYrZ/4Dup2 VMUwZmU8doqaWsLiGulANxew5X33jJ8CmWep+VJsYyrh1PhWOUzDJenaAJQN97Lm8Vuuh8yK5ZqS opxBqhkdq7h3useeqkNU1wvv6QEOJYTVYFjFXhFUSKukkMbr9yDZZL5BFilFTkAyDe9l43HbLaz6 cJrJBSR2Vk3w3Zw6jUUVXgdG2bzLEBy+lr/A/wBXqGIyHLMkjQL6o23XfHga6qMwE1lJiTDIY5Wi K3YLafFjELsqx4i2PXEIPNta5ta6Y39uejx5cjj0fnyzN0Lz3k57pMXy5iFLG02MvlOsmZA6TY7n ms/TYfDLLO42bHp9X9lvWyLmzA+seEV4mw2mmihkdC+KWMH44K+P6eeGLLmQM/YljdDC29RIZGxl otGb8Be9Qhz6Z4vlyqqNWEvgH6qVFI6ogw8gWvpkbYrpbN3TjMnTfGm4PmXDJ6SeR4axz2en+63Q 9VvGlk7o/wBS6TJ2Mwu82oIb5rBtHfu74XwHjffkvP8A0ZjxSkGG1OIFzZoKqNzS9o9kcdq5RnHr HKVLk8RZP+nh1EztlukxjCqindBUsD2RH7gCvjeofgk6vdOIpZqjCf1UDGlxMe+wWybwE9TZczZU Zg1UA+SijDWSe4XJ/UI6qVHSrozPX0Meuvqn/p2XHpFwdysYYLJPYejLq3jVmkqirKiWWanmYIHw vMb4/YjkLPMboWkteWfhcdhsrq3EKupqt5KmUyOP/UdyuXqWlsVncdl45x2yo+jCW5WcdT1Ejqoh 5sP9x7rJPmOmuyQPI/p1LsLo102pOoOMtpKubyoy4AuHZezML+lzTZlwtlbh+KGPzWBzSXcrcMTa tmZZEjXsyoeyf+ZGGG1re6+r6cZSZnDMcOHSS+RHUO0h/su2/EN4Fs79CoGYl5EmLYYXaXVEQuGf myy/Dp0FzHnHH8KnwuF8kzXh92jYWO9yuvi2tcnJ5os7lH0o8Yx/L8GI4dmVjXytD2Mf8heQer/R XMnQ7PcmWsdmbNMz7ZI+CFva6U4DjmXsDhpMZmY97IwBG3+la2fHvk+rx/xCPMcZcJGsDGN5uvTi i8lw/D5+TUeNpt9nyfhf8GFD1wo5pXYqGzMbd8f+1ZviR+mzmHplk+qzHgmItrIKJvmTMB/p9163 8FXh+x/p9R/xmteaOKpAPknYuau6PFW17/D7nAtJEgonloB5K88Y1KjWTPLlo0E4fVvGsub6m3aX H3XIw1zHUzruu4jcrjaNj6jFJoXelpJJH7rkm0kTWER2s02WMuPxyo+jhy+SFlYPAGueWuJD+Lr3 f4UPBjkrrVlllRjda6Osc27msNib+y8v9FujmJ9TMbgp6KmdIHP07Nutsnhn8LdR0bFNW1WIPc/Q CaZp2GysaSOWbLTpHjfxX/TcwbpLkWtzblvGZjFSeqSnlHIXgyGjlhb5rXFpeNwt63jVon4j0Axu maCf1GmPTbm685+Gz6f2VswZQo8czNC98krRoiHYL2whjli8mRnhjqJLJsNWklFC+0muQS99tkAZ ovcFwA3JC3Y4j4B+k+IU0tFS0JgqNNtdgbFfCZE+nFkvBs21zcXY/E8PI1R2GkfhcdmJq1I7vUtP o1ANqG1DjGXGEji3dPnlgZG1kgId2cQV7+8X3gzyZ0nzPlfEsGDoqOsqw2aF52DbjZepKjwH9JM3 9NqeSLBAyslo2vjqmusQ7Tfj8rHiUak3wyLU26Xo1q+FDJeC5qz1h7Mabrw98ojLAL3K2JdbvAJ0 prunGJVlNhjKGsgpHTidptezbrzH4X8hYHlLxFyZWrpB5UFWWRE8Ah2wWxTrRluabp/miQVTvJFA 9scY7ANXSGOPlUW6OWbUTWPej8/dLhLIq/EaOCEzRQTujjcRfYGyy4stzRxuilwmeUu3a5sZ/wDC 97eA/wAK+C9TMXxjFsdi8ylo6lzvKt/zDqOx+F7jzTkbot0ynoabGsJwvDX1fohfMwb/ALrrmhCG TYuTUNXeNSNDb6STD6kQTU81M8jZkgI/7rPossV0jy6mp5J3HctY0n/stzPV7wn9JOseWDUYe+gp qlljFU0z27n2Nl2B0r8LHT/IOVKGnbgFJV1IjBfUSRhznm3K5y8cVZuOqcuDRRWYBitIzzqjDKqO L/6giNv+y4STExT1Fru0/wDUOF+htvTnJ2YoqiknynSCnb6C2amADv8AC1ofUQ8G+AdL6Z+b8vvZ RU0r7mjabWJPYIoxla9mY62nT6PD8cj5gZWkOaF2D0l6WVfVDM9BQsbaOaVrAG8m5XXOFQmroXxs dbVvZetfAtXQ0vWXLsM0Ycxjg1wI79ivHJ0fU/lG0bJeiPhhyf0ayFC3EcOpamcxh8z6hgIbtxul 5v8AD30o8QOXMSpqbCKOOUAxispGAGJ/Yiy7X6s4HNmPIGJ4dSymCWeLS197WXXXhnyHBkPCKyji r/1b3u1Seq9nL24IvwvMnyj4Won/ALVjfs8n9CPp7/wPqrUjMbTVYThM5dG57fTOL3A+V7WzBTdN 8CmpMCxTD8NpZJWhsMRiaC4cL7D+ISSZj/QtDfKDLuI5XSPU7pVhGfer9F5+KGCqpGiYM12P4CKs 0/s64s88nkxRbXJ0t4mvp+4bm/GqfMWRYI8OfM5v6qBvDhflq9F9H+lGVPD/ANPKZ80EMUrYwamr kaCdVt9yu1XRvoMKp2xerymhpv3FlwPUfLlJnfI9Zh9TL5NJKyz33tZYeRzqL6OyUoq0/R85mLJ+ QfEFkyso5qWkxSgnaWeeyMamutyD7roDw4+BOl6V56xDEsWghqaCCUmgvYnTfa/4Xevh8ynhGT8C qMJweuFXDFKS8h2rSV2XTOfJi8zS5xjaNm9rqzk8bcF0c4KeRKTdHw+ZOqmWcBzXSZVqP0z6iYWE Tmizfj2XlP6gPg1wrPGVJc85Xw6KlxyhZrnp6doa2dncm3cLvvNGRcqV/WWPFcSnbDWx6THG92xc F2V1MoDifTXMVPH63yUErY9O++g2stqsUotezg5SyOVqmujSb4WPC47rz1KkwOre6GhhF5gw7t9w vRviV+mbg/TLIhzHlWrqJqumaXTQyj02/K839K+tObOiHUSuny9CZMY894khaLlwva1l3V1P8e/U zqJlx+W8dy1UYNS1Glj6lkRaH+97hMuNrJa6PqYZuULs9R/T18NeCYFkKizniNGyoxOq/wCV5jb6 Ld16DzN4gsAwLqBBk1jZZsZc4ao42+loK4XwYYi3EOgeB6SLxAtLR29liY1TZOy71o/iWLeSMVqQ GxOf9wXHBFTk7V0cdTOSitrqzq7x6eEyh6uZUOacGoGx5loRrLom2dK32NuVgeBTwmQZMoYs35go w2umjAgp5R9nu4r2NjlZSxYM6eaojgp3AfzZPtAXEMx7AKvBxRx43RgOAbqimbe/xYrTyN4ttHGC cMvfByWdGMdk7GWFjXtNJI0NtcG7SF+fzMORv4n1fqMLle2nEtdIHv8A9t3FfoPbSRjCvIe/z6cR EFxN9TbLSN4yqbCMH6z1+I5Yf5TfPcH6P9wO63pluhKJ1nNwypnvXpz9PDpbjvSrDWYlh7a2vqIQ 91cx/q3Gy84+Hrwx5ewzxWV+WauP9ZQ4TMXQxHcOsbi6+H6UdUvEvWZGZUZMjrq7CQCxpkjdax2s F214EMZxuTxIVz80UklLjksRZURTX1B/vuuK3bHZ63/Oz3p1f6hf+kuVw+gw0zMa0RxiNtmxrCyV j2FeIDppUQYrhx/T1EZhqY5297ci6zfEDmLDct5CnrcUp/1FM14L22vt3Wb0fzlgOd8o01Tl+l/T 0DmAbM0i/dEv9VxXJ4JJvPTfH4cP0O6IYN0XpcSo8Fp2sp5XGQTG2p4/K+Pyh14rcf61VuVDSSfo YXOZ57b6bjsu96GjdRebBcuifeznchdEu6kZLy51WGU4MM//AE3NPd07WbgnuSuuJqbk5K+DOROE Y0fAfUp6TYBmboFi+YZ8Ngdi1BZ0VWGDWBf3WmGkhFRRsZKLlvcrfr4wcLgxfw+5spqghsbKMvGo 7XWiHL+HTYnUugp6OWocXnS2MEnZaUd2FNnq089uaUV0fT5AwSmxDMWHUspsx8jWu/HC3zdFsnYb kbpdgmH4RTshj/SMeS0WL3EclaKcDw6fLuNwTVdFVUj2SNB86MtA3W+Do9VvrulOWJ3O1OdQxb// AIK8s+Oj355bkeLvFjkXxI5+zFPFl2Uw5faCGwUzw3WPla2er/SXPfTTEzNm7BamndKTeeRps733 W4zCfE1jOK+Iis6eDDmmnhcQZ+4A+Efj6yTheYfDtmGsraSOWpootcMpbu0r6m9pRx5I1Z+aw5HC cpwlaRo5ppmva3yhfVtuskRPjdZxs4chcNDqimY5tw1rr2C5ezjIXud9wXxskXCTR+rxz3xTGgB2 /Knl+onsjijDWFEA0bWXM6C2ANBsLIGyG5FvwnTuAkETRue6FkNnboCB/ZQGzjdNkh7gW27JbIyb 2/ygBLtbthZHAHb32Uc3bbYqoC5jrEEhQDjEXDf+6W2FzTc8J+oluyEE3sSqCOOgbKj6hfgFWQLE FC151AH7UQFuOnZGLEBDIR5gAuqJ0u033WrATgb7ImN2N0AJOw5Ru9DblRgEtsbKnizebKCYIDI/ UdrhQBsnZINLDcjlU4f5SWs8uTU0WvymSCzhvygADXa7d0+N/kPAdyUr7TuUBedYJ491Aci2bVq3 3SSbg+6xQHtk1Ddqy/MB9TeO6nQAJDgBwQo6IEA3VOAJQADX8JZbMiJ3A/yslpLTcbjusMAt3G5T RMS0C1iVDSZkOlc4G4S2G5vYG3ukiR7X2dsCml1x6eENWP1eYdht7BUY2ht+CpTSRxghzvUUsuJe bnZANjBbe5v7Iy1vNkDCbK9V3WsslI+8gFtwp5ILdgnQR+Xck3BREgC6AwnQ6Skub6iSsuXU7doS ZI9QBWiUIDS7dH/ShH3WCvgcbqkoWbkK2d1drNKplybd1CFuNuyAuvIGjhFJG64JKvSBzygBEQbw UGiwKYOCOVCAWoT2Ia46rg2snxkW5uUktDex3Ua7SNufhCjSLu3VEG/CoEnc7Iw4Fth/lAQN0m9y qI/N1GmxseeyMkA3QEaTKPUeEbLcHcJWh2rVf0lW0kG3ZAEWeoW4TWyFr0kuIfsdk0kbe6lAc6Ww LncFJuJTdTVcgXv8ISSybQdvylAY4NY2/CWZNY+AgqDptY6gVLaYwe6UCSO0i4CW27jc8IpHh5F0 RaLbKmRMmwvdYjJyyQ3F/lZEnru0C6xg3R6XchX0Qy2vu24RNc1ouUpkgAsAmBgebX3UBRILdQ91 JJLNFjzyg4JYSltsLtJugGxmzSR+6B8gfYogdLbAcoQ0NjPugLBDja+6smzSLJG545TmXtvyEIxd i/023UbHpaU/Z3GxQyW7LSIYmh1zcWKkbtD7D7vdZLrGwOwS3Rta4Ed+6oFOeGvu5xurp33e4kqp KQ6g4q/IDe6ANxuTbZULtB9z3KpwGrZXybKAFvpeD3TfS78oA2x1KMcC9GAiNOwUPF2/2V69yULn louFkFujde5Q+Y0GxF/gqOkcwNJ3Uu0vvbcqoELWusQLFR12jY2urdGf6eELtrXKWAmyHSI+11JG gHlUDqtYInM0jtuoANQF90LW3O26IMA53RxBrXe6tAtkLu+yYWhnwUuWocxp07u7XWF+pr3SepjT Ef6loGU+QE7G++9kTgC0W3QODYgLb35Vea1pA7lAWPSCEdyQNIuENmvJF9yha/yHEOFwgKlBFrqN OkJbzI93G3ZXBKXktc0iyAN17EW3KW1gYEwu2CW5xFydwgBlcBb2QuAcAQEcjmSMH9PuErzxHZoF wqiMER7bcq7ekg7BUJgDdVI8kg3sFTItha24aFbnbj5VuYHODmnbumWZJ2G3dZAkReokuQtc4uIO 4Cb5ZL7jdE9oDSLWKASW6lAC0bKNNwR3Rg2bxyqwKddvqARMkc8WA3SaklvBO6kMhijBDrk9lAZT omkjc6u6nm2uC3hMhb/W5IlLjNdo9KtgOE3JNtvZADeQ+6cxl2E3slhukklQDBIGAkm6VVFroCdY ARFwtuELIo3n+YLtKAXQN1McdQ9PZW9vmOuTwjbDDC93lkgnso8WIsEABdocCAfwqc8ukue/ZGG2 BPKoNBNygKa8xuAA2KNsup5uLBDrseLhS3q1jYJYDOmzuRZKmFmgt3NkbyHN9BuVJTpaEADHODdx b3Rabi4N1YtI2yjbRkhARr3x/wDwr8xzh6tlBYvuoRqNylAYZLAAFRmz7FLfJdrQG7hOY0usSgHM j5t3VuaIxe91GOLQQOVLsOxO6GkC2a3CyWudKNrWWKI/WbcKwHtNm7BRmrGlnq3OyLlLJvYd0d9V gOVkhchtbZAGtvd26uRhA5S3OAsTv+EFGQZAOOPZS+vtZDC0uPF1esgkWsgAcBrHumxuG9+ySTqf ZXfQDugLvrcSEsuOsgI4SDftdTyLgk7FAVbYKwQTa+6UHnVp3TDZh9ygGODTsDulEAOuOVCLuBH7 qWAdsUBYdbkKix0gJGyvUAqc8tGyAYIwynsDd11RbZqVG/UflND7jdAVcg7pkrCYWgbfKQJOQR3V eY5pte4QGS4jQGnlCPt3SnSggX5CMPJF0Bb23APdAOSmXsbc3QGzXW5QA7f/AJURbptsqeNQIbyk ROf/AFndAOYNJOyLsgbf3VAn3VYGSPAZYHdYouzUCbonuDnWurbGdVzwoCwSGXRNc0b23QO2IHIV hpvcjZAF5gduqBBVhlwTwqc3SAQrQLA3HsredJGkbKg424V3UBA63CjzsbqaQSLFU4327oAotxwp 5tyRbhQP0t9KEuDQdt0AbbWF1biBvZC3cbqi48ICOeW2PCnmOvc2N0D7vaqGwQFySOJFlGgGxJsh 02N7qwdQudkA70vcAOFcTBrS2u0jbsqLnOHpQGRIdDt+FbGAgrFY4vaQ526ZFIWbX/ugGFlgsV0v lk3Flll5eDbkqOoHyxanBAKgeNOod1TmavVdXI008NgAlNkJsPdAGL7hQ3AsmMYTwgMjQ4tG7kAJ NyrJHKq1huqvqQqCBDuSoXA9tx7IHAAhU2/mWvYIGG2zyFHNFlLAG4QEkuuRsN0IGaYG2+6psLmD c8qmyOfJq/pHZGX73Jv8IAC0AlQiyvVcq9r2KApqHU4PseCmNQmMu3CAF2yXrs3flBUMl3PZCy5A 1coDJY4aflCXl17bWULfL3G5Krci9rXQIsEiyjhvcFQfb8oWE3uShWE60gseEJd5VLK6PcjgITKL GykZEcbrb6uboQOImSlYXfceUTbtBtZDDG5w34PZE863+W3t3QED7c8onSDTzZLazyz6t0qqhdMQ WmzhygMhrwBxdLJu645VxMs0b7o7boAWgnY8oxtsVR5VHcoCwAhcHF1gdlfCsO3sEAJZZ1lZNtha ythIdvuqeN0BGtG+oqnwscOb2Sy1xO+4TgAGoBYZf0jhE2TyrtO6gabXvZDYmQEhAQgu3HAQm7HB 1kZdv7BTRr3Qtg+YTc2VOJaLHumBmkW5VyAbXCABjSWoTJpuHFE5l7Fux9lQaDs610CCEgbwjkJL BvysdxtYJmgPaAH3KFB2JsDsqB0uVsp3x6iXAhXp7kIZIw2JPdJe68u4un7XVkA72uhoCwI3NlYf pPx7q9Hq2O3sUuS5OkDZAOaS43JFlVR6ozuGk8FY4eYwmtcJm2IuEJ0BBG8R2fJrI7hMItvdQNDP SzYeysm+xQckbueVUgIdcDZU92kEDlDG5znboQNvwUvhx2TgQHEAKNi3JO4QC2He9kws8z7VHjSb AKNc5pshojWaRYORtcTsUAvquVHPtsgsIg8nYI9DLBwSTIftI2UbcA9wgCkjvuHXCXHMW6g8/hE9 rzbs1U9gNroAA5r3XsmadI24RFoIGkAKF2hm+5QAC7iQBsQgMexbaxRmJ+pr7+n2Cc9zQz/qQlGK 1hAAO3yj0arj/KO7dIJP7K45WuB2QUI2YNPJVPlLW7c+yZUANbdo3WIC4uuW7IOTMa3UwHk/CZE0 vGoiwCx4pXNATm1IGx5KFI8gAgpUZDHeoXCp0xa4m1x3ujZPHpLwNVuwQlFSkH7G7d0UdmsIHJWR DM18eot0g9liuc1ri5u49kFhCMgFQN2vayoSl1rCyJxIbwhbA1BouVQu88bKP5aCN0xxDWADuhkx y7TJturIcSf+yNrWC7m7lK8xwLvlAWTuAdwrDg7UALH3QQsL7knusplE4DUEBjWLW7G/uUDS5h33 WUKYxuOobFFoa4g9wg7MbSTx3V7htiNk7QQ4oG7kgoaIyMFuytjtJ0kXRBur7RYBUSA8keyGRbns Lrg7oGNIcSTYFUC1zrWsebpiFojmNDfVuSqAs33UchcPlAPu1rQOSk6bAgAoGuu8b3THTtD9ICEK jaRGSSkioAJZpNvdN8y5LT3SGsmjkIkIMfZAMEjTtexTNZazfcJTWNc7do24TnEWt2QFEteELgwb 2F1IwNLr8JTrA33sgAku4kgWQyyGONu/HsmNvY7FKlYXNAI7oVDHEPa02/dRg1O9Sge64bbYIh78 FCMtwEY5Snz8W3RON9uVUYsTcbIAjNG4NHJRARkjcA/KV5Y134Ulia5hKAa2KogkNy14O4ITDOBY yelKgaWR3Mh+ETmNc31uugKlkigeHMubp4le+PV27rF8htwOQmh5YC2+yAfLI0U1m/cebrEhe1jC e6Geq1RaQEqIucOL3QGU2WNw5RNAts/ZYpDWgadingsEYvsUDL8hjzflW+KMAb/sqaxrhe9kt7BG 7coADIdRaBsqdv3/AGUDtTvlXpJOyAoOLQqdLcWKnJsqLLlWwS1+EmznOsDZN0au/CE77DYqgGS3 B5HdL1XBamFvv/dTTdw22QiIHAttyi0XarAAOw5UGxRFI30tsB+6B2w34TQRZCQC03VAMMjYrgb3 VSW1AlU+MFo07FXs6OxPq+UBLjsiaboBYDm59lZvcWQBktA32Kx3N31cpzyHCxHCXYe6AON7Wjjl XI4NIJ3uli3dXKdWyAuMjVYHnsmtGgE32SIRoeT7I9eq+rhAEXAmwKJ4BjG5StQvcgJgcJORYIQG 4c0D2RPksOFJA0AW2SnhxN+yEoDVrfwmh1xpDbfKWERcSNtlCFubc7n+yAtc1973aiZ8q3u2ToAi yqRoI2Qhwa5F2KgBY1wF73+FZLrW4VAadx/lHYnhKALd7goZYfTdvKtr7Cx5TWMNy72F0BjuYXNF xcp7XAR2PKmu54CXa9zdQCQ5z3kdkyPVGDZWAAbow0WO6qArTd1yUYvf4VWsb3uhfJfYiygC/wC6 ogoGblMFyUAOkOO6sstxwrA332KuxvdACWgtsrvcWUuSTfZAeeUAQPZw2UY68mkcIb25VtfpN0Ay 11Tori4O6sOFrkcqPIAQEjBa03KMNDgleY0EXKozgO2QByPbGDcIGPcNx3UBZUNOt+khLfLYhrTd C8DiS/c9lYsTtsjZJ6LFqENAO1t0BI3+/COzSDflVax4VX3Oyvotk5Fh2VSOLXCyu4aR8oJfW8b2 soGR+zb7BGA1zRflDJ6mgeyoAgboZGFtvwqJtv2QXP5RawG6SFfRUVp1G44U1H2VNO1gpY+6hbO1 6uTR6b/gLi5JTcgrkKuPU645+Vxsj7XuN18+Cs+hItluyCY7IoXDclVO0vGy70c2YEt+47rPoW+j 1bj2WJMQ0AclZFK9wHyVTJlk2uALBW1p5uo+7QCRdRzixotvdZKLkY4lHG0ABE11xvsVLC6gBdZA 87EI3dkt290Biym4ffbay+v6I1EVFmimfJZzmyAi/wCV8XM/dzR3XLZVqxg+KQTi+zgVGmzm+jcT 4Xq6OvxvzpAPVANO3ddbfVGxqqo8pYDh1NO+Jssmp4Ybavhcp4M830GL/pHsqY3StjALb78L6D6g 3Sau6i5MocYwyM1c2Huu6CPcuavtafiNH5zXL7Hn3wPdXcSyNjUMFW57sJqXBrmX2afey2cspqDG IIa5sLJQ9geyRzd7LWp4QunNRjuP01JWUbomxPaZGvbwL7rYdi3UPLmTKuhweprIqWRwEccbza/Y cqvc3wY2RUOTxx42+qFbiePUOV6RzoKaCUGQD+tem/DNURYj0gw0G2kNc17b8dl1/wCKnoHD1Ey/ /qTL7GHHKQeYAD6ZW/8AyvpfCrhNfTdJf0tWHQVLrt0uBBa5e7K4ywrbweTDFptvk6z8QXS7LuRa TEM24Vihp8Vc/WyGNwBv+y+z8HefMSzbgNY/EpnzyNAcHuO9l0ljvQDqDnPqrXYZU1E78OdMXPqZ Xkx+XfsvVHSHpHTdIoTQUb3TQuZeSaQ2JP8A8LeVrx7W7ZMXDcqo+pwrqXl/HszVOAxTtdXQXux/ cjmy4DxHYQMX6L5ppG7F1G83HbZeWPELQ1WTPEJgs1HUS0kFdKHsdEbXdfhesM5Rz4n0pxCKT1VE 9C5mm27iWrzeNQlGUWdZZJTg00abugFRU4V1MpvJlczyqjTcd7FbosoyDEsgxSy/zC+Ag377LVT4 a+jWI5k6j1UEEEjm0dbI6oeB9u+wW0Cpx7D+m3TqQ4jMKeCkpyXvf6ey1kTlKz0vGljs0Y+JDC3Y D14zJEIyz/i3loH5JXxFKC6sbUSNvI3v7L7jxAZxpM+9ZMZxiid5lNNO4sIHYbL4+iAmnm1fa7YH 2Xk1LW+kfQ/x9yxWz0N4ZcVbT5riY4+iQhbl8kyQv6fULp7GEwWd+LbrTb4VMpVOK5qhjiBeQ8EA blbkslYXLSZKpqKoaf8AkhpDh8LjGujep4TZ50x3xg9O+lGP4xl/DMOfFWwklz2NAa967k6HZsqe oGXW49PcfqSXNaewWrPxndMq7pR1lxOufK6owzEZfOjfe4Zc8FeuPAN4nMDxfAW5PxSsjpMQiA8g vcAHj8r6ObbFVH2fLwx8kN7PH31EsPr6/wAR+LPiLwxjGt1tHBXndz804R5dNV12KSURsA14cY7D sOy3JeIDwfYb1pzDS43BVMp362unDd/Mt8rE679L8j5O6DyUeJ0NDTCkgIbUPaA8vt7reSUM0VT5 OGnksL2yidLfTfxSOnqTA5wMkrDe67U+pdgMWNeHqtneB/wkzZGknhde/TvyZHV09Zj1O8GmbKY4 hq7BemfFR05i6mdFsdy++QMfUxfyyezhuF5cH+qaZvVXkjaNBOGyxSuczlzSSFnVrnVMYjLtJCrM mV6vIuf6zBcQZompnlhAN7gHYoax7XYjFbYey8uVfc+5ge7GpHsTwYdCp89ujME3lEvBc+9jZbTW 0FH08wPB24niRp6Ska2EP1bE2tutbHgR674FkTFYsNxmpZRhxAD3bArYz1Co8G6zZPjosNxml8tz mytfrB4XohK2o+jzajhNod1swuDN3SPGoI9NRFLTGRpIvdtr7L4DwhZVw3K3SqSuo6VrJTr9en1G 3ZdiUYoMFyI/BarE6Z8ggMJf5gIAta/K+G6EZxy5l2kr8syY3RvMMznNLpQAb9l2cX45RX6fNjN7 k0c50m631HUjM2LYU/DjSihkLDI7k2K65zvknDMw+LTDHYlGyVraVsjYjw8gd12xhOBZUyXmfEMw RYpR05rhdw89ob+eV131lzfk3BsdwjOtNmPD/wBRh0oFQ2OZrnvZ+xVxvbL6e0csic0lLtM+2679 Qa/p7huBMw1ghiq6pkBe0fa2/C5jrFFHi3RvMLHt1skw17rWvvpuuCzHiGSeuWVcOrDj8EVGwioj cJWtLSPffZZ1f1ByNU5XqMCkzVh7w6EwOdJO0kgiy4x2x2v2nydMltSo0AYkHUWO1/IkbK4W/BKz MKL3Ma57dIee/wCV2r40un+WunvVyKmyvXx1kNY0ySGF2poJK6tpBI2SKN5vEB2Wc81ObaPraJ/6 VFm0H6bGXcNkoXVL42OqGgubcXIK9QeILqBimRqjLhw54DKiqEcwP+261n+C7xUUPRXMrafGy7+G vdpLh2HutjeJdaujfVLCaesrMz4eWR2kjbPKGuafwueKS3pyXBz1MZKLo5fr/DJmToxWVMI8zy42 zFo3v7r6LoxURRdLMDkbctdT6yBz8rrPMvio6Lty/U4DUZspPJ8oxlkRvsvh+ivjK6b4ayfLk2OR Np4XkU88jxp0HsvXtcsTSXTPmJuM0/1GLm3x6T5ez9jGC0WVZcQio5TEx0YOp5BXZXSPxJV+f80R YRjGAy5eqKhnmQxzbFwtfv8AC+Zn6ueHLLuYKjHJcYwgV0r9ck177+68zeJ/xw5aq+oGFVWRJBM6 hcHHEGgNBHcBdKxP6xXoxjlkk/t+noXx95IxXOeHZY/htM+WOlqw6R7Bv2svRHT6aXDOm+FiuiED qeibrB2tZv8A8LzH06+ov0vzdgFNFm2cUGINaNXms1NcQPu+F134wfqEZcbkI4P05xmOrraseXLJ FyxnsFztzgsVdHSUZwm5L2dG4biE2L+KXF8QwuRxH8UBhc0f9e/C2tZuwqXMPTiuoX6hLU0Dmknn UWf/ACtOXhA60ZRyD1Iqcw51e50UjvMDjv6+5stkDfqG9EqjDjK7NEMY0f8AKkFifhZySuacUeuW JrHTOufABiEuG5pzhlp7dIp5CduxDjdcH9TzIOMZliy3iFBSzVMEDjH/ACibtcfx7rz3T+N3Belv iKxHMuVKVk2Wq15/VMA3IPcL1dU/Us6HZgwmGSvqXTyACT9NJDq0O/dd7ccyyVZ4cmNzw7Fwecej fhj6wYVRYbjxr8QosK81kklHNKTdl/8AatoVJWOpsoNmY4PmgpNuwLg3/wCV4V6jfVW6dyZZxCgy 1Q1U9e6Ishe9oay/ZfHdD/qo0lBgzaLOGGi8dwHxO3IuuGV7+ao6wUopRS9H3+CeIPxI5vzlieH4 HlSjdSUs7mCaqj0N0A8377LzF9QPFesFczD6vPlPHRYbIzTFBB9upeqH/VT6PUT3ONDVtmdufKjG 5+SvE3ja8Y8HiXxigoMHjljwaldqYJByV6Hmg+o0ePBgyqX+xt8nmPAAWxaiSHXtZelfCTmihyn1 OwzEcQqGwRMlb6nOsBuvOtDTmkeZHCzL/wB1m0uJSU1deNxaDx2svmOpdn62LqNH6KanEYM6ZKmm wWqjqf1dMRFLE8EAkbbrqXw3dN82ZArMcfmqp/UvqJC6Ag3AF1rP8P8A48sydA2tw+vbNieEuFms vq0runNn1campwuSlwTAAZ5GFv6mW/puOQF68UZ7HBPg+LqMbU99cnvum6tZTp8+vwJ2JwuxZ50l gePSfZfDda+juK49n7Bcy4BWSwTB4bVAcaex2WmtvWfMdTnatzO+rnZiFTP+o1hxuDe69S5M+q/n nLGExUOKYHBjJhAYyfdr3W91rdDFNSgzisWTJjqZs6zfn3CelWRjiWYaxkcdPGL3Pqkt2AWHl/Nu B9b+mtRNl+rtSV0Low8bOYSFpw8RHjMzX4h8SppamlOE4fG236ONxLQf/Kvod4zc9eHqIw4W1mIY a/8A5lNMLj9lxqLXHZUst9cG3DoH0iqukVJikVVXGrjnkLxLI7siwPxL9Psd6jVOT6HFozjkLtDm 8An2B7rWf1L+qbnvqBlSXBsJwpmCTyjTLUxnfT7BeVsNz5mDBcdbmCiqpGYmJfNfNchznX910pTb lkMxx5IpRgjeT1W6AyZ/zjh2PU+IOpf0xBkjjdbWB7rN62dYcudCumE9VmCtZERAYY4nG75XFtgA Fq4wb6oHVLAsLbTfp2zVDGaBLN6wdrXK6B6y+IzPHXavFXmaskqSCdLTcMZ+Aq3SSk7SMSwZLaiq vs7+8IOM5SxnxO1mP5gq6amoJ6gyRNqradzfutk3X2i6YZp6S4y2SqwVoFO6WGWIxh4cBta260Lm J8MbJaardHPb7muIITGYvmWUPbJjNUYOHNNQSCPa11xnkcnubPq4tO8cFE20fTt8TmW/4ZWZBr65 lPVMqnCjllcAJRe1l6tzt0IwDPmcKTHa983nU9ixrDsSO6/Pzg2JVeAVtPWYbWPp66J3mRyRPsQ4 L0DhP1EeueA4Z/DmYyKloaGCaZgc9o45Wcbadp0Yz4HNJVZsm8cvXvBOkfSs4MydlVi9TaGOmY/d ot9xWubw30GYOp3V2jjpcarKaCSoBk1Sksa0newuujM79Qsz9UMXlxPMeJSVc7yXEOcSjyj1AzTk DE6bE8t1P6eaA3te116HkUIbUcoaZuTlM/RBlbLzsvZap8NkqnVwji0Omkdu4WWnLx4dOGdI/EE6 sqfVlyvk/UMjc6+5sSP8rrafx29dpHuYzM01Ow8RDgLrHqb1bzh1QqaepzpikmJyx7MdJvZcsM/H GX9mp4nOcfxG3fwy+L7o7hHTLDsLdjtHgklNH/MhlIAJtuvIXUjxZYNlbxf1We8u1LKnCg5sT3RA Brxtc2Xg40NO2XU+UhjtwAbFZMQpxWiJzHCK33E3XKHF2el4XKVn6Hcj9QcmeIXIVPWRS0mIUdZE PNpZHDU09wQizPnDJnh4yNNUzS0+GYdStLo6drgC4+wC0GZW6iZzyPK6TLWYazDYzsGxSkCyyMzd VM959Pk5izFVYiD/APXkJH9l1gl7fB48mGadpcm03op9RfDc79V6rB8VY2kwWsdalqXOA8s3sL/C 9QNy709xDMrszMqaB2KtAJq3Stvb8lfnzipXUbmzR1z6eRli17HEEFc+/P2da6nbTnNlaYWizW+c 4Aj+61tV8Ojfgm0uLNjv1HfF5h9HhTcg5cq46s1Q/wCNnheHADs3ZdU/TYpMhDM0lXmato2Ygwkx Q1drE9uV4ZlExmM+IVL62p/3SOLiqLKlsjKihnkoZ+0kTy0rGTL9NkUdcGCUblL2blPHw/ITOiFf XU4wk4oxzXQOpdHmOI4tpTvBj4usnZo6WYTguN4xSYPi9FE2ERVUgaXjta60z1mN43iQbBiGN11Y 1h+ySUuaglp55mtkgmkY9n9bH2IWMe2SqR1lCaTo314fkPppS9RpOoFNjNAcWLSJJf1LNJB78roD x8+LbJFP0uxPKuF4xBidfWN8uRlO8ODR7ErUpJimM0wYY8erm7WLTO7/ALXSZMMFZeplqnVEh3Op 1yV28ijUrujwfDbuKVX2YlEwzRSPAHqdsPhZ7hqe34CCkgax+oEho7I5njUXAbe68c5Obs+rjjsV IeZCGAK2uBA91jtcS1MBIHC5ndBvdwQN/dW0koAQUQJvcHhUDPPeGiM7BRp2VgB1nFUHN1bLKAL2 3IIKlyCPbumaLnnZCRvYi60BgIOyB1ySAmNbp/CWWXff5QtFBj2G7tgUR2FzwhnLhYONwo19xbsn AAc/ynh+kuHwglLHvD92/lZIOkXSA6SSW0jbM7IA2xh7dQcrlIjCS95hm0t4Kt8hcd0ICWkm44Uu Wizk8M9F+yWbEXPClgjXBwsFCCPut8JbiBYtG6Y1heASd1LADvUTuoY9LOCiJ/2i6sym3CtgU3U4 gE2anCZsTgwC6VI7V3sVTeRff5TsDXm8lghDdTtjaypxAOoG6uNoJJClAa6QMAHdU+S9u1ksuGvf dM0tI3NlCgvlkkcABt7rK/5MfuCkvmEcdgOO6prnSgD3Q0Mija867rIjOo3Ntlj6tHpVh50gcBCm bqAOwuh8wX25SnvLoyWFDEdQ4uVllOQFg290p8oBsN0tp1bILObLYi1+6hTIYRpQvFjsOUQH8skq o59cTm6bEK2BL6byjrvz2SpRqF+EbiXixOyj2WIVRGJaSNj3VSkR2901wsUqezrHlUyC15ebE3TH C25S42tBujdYgXVALXhriD3Q6vVtwobh5PsqBN9xZQFnftYJV7OTw5CbauEAOsnkbKidWzUdwR2A 7oY26382CEZJASwb7q4nG1nbhFIz2OyW12k2VIZAksLAbKAX3AQB7T2sFQnLJA0C4KhbDtc+yhdo AHN0UxFroNQ077oUjXmM6rXsqlaZnmUmxsod++yMAFhHdARm7LHsrcdURA5StegWIUDr9+UBAAGj VyFPN2IRPA/KUSGoZ7JY67tCCeMM9RG5Vh9iSHcIXTF7Q2260QSwe52VtlLCCDdDpLS4KAbWsgCm cHSB3umNIB4SL+o37KOkLHj03ulAyNVz2QuHqO+yAnyzchGHteN1TLK09wi1EC/KXpJcLGzVJpfJ AI9SlAv1O42UJIIF90ttRftYlGTsCDdC8BTC7RY7qtZDAHN391d2tO5uEMknmu+Ag4Da+7bHdJdf jlQEh3uoHEncWKpCi4Rs3O6U1/mm7eE1jWSuIJ3SZm/pHAMFwe6AcXgtVMNjcIdW3CrzHMY5wbqt 2QDWAk3Q1Tj6bDZCyoJaHFum/ZHJN5jWMDeFlgYWB7BdV5Y2IN0Trk2BslucW+lVAqWYxi10pshc TdDLEXkAm5COmpHSXsd0oBw78J5eA23Kx5In05t3VMuW3PN1KBcjzew2RNF7Di6GT1OFhuieHNts tAJzbMLeb91jOErSGj7SnhyouuLkX+EBQjcAAhkpQ8em+pGKh2nhUZng3tZAV5Oi1+R3UqDdo2v8 o2za7hw2KKZnlRggbFQhiNqnM9KyTUteAC3f4WMXBxvZG21wbbqlCc48DYoJBsFJHWKx5JyzvdAF I0kGxsluNwLbFHE8vaSULgGncIYALSBzYqbyD8JjthsOUHCqBRGhuxRRODmlo+4qFmpqx5XOis5o NvdQGUydlPcONndkErgy0j3gg9lju/nEE/ch0t3bMD8FAZbbTN1tFgkm52vayqMmNu329kLgXO2O 1kBZYNzfVfshYN9wraDpJKtrT5Wq+90Ax0jmkAHZRzyALnZCAXNRRsDjpPCAjpH2uzdV+oe7Z4sm lgjO1lUlnb90AHm6jsLomv1G3CXHKYyQAp5mok8IBgiudV0wAuugYB+Amtb6tuEAoN5345SnusRY ptQ0+W8DkrjnOdYN4IV4BmX1BVKHeXp1aQVKd1wL+yKZmtn4UAeH0uhhGrV3uVTZGOlc3Vc/CXC9 zW6RZp4ujijFOHbXcd0BbbxyWA2KI2NyqZKHDcWKN1gL8IgLOxKsOu35UD2njdW0AHdaAcYHcJtu 4UABBKFrjawCAc1wd+VZiBcHFL0houHI2yEgAnZRmhxc11gFVmu2HKBt9J7I7hrNVt1hlC/TdwRd BYsO3ZSKUv2JsikbcbdlAKnBI1D90DfUBaxcjFQ1t2WuSjghb5gcAho5anpb0wdb1LADdUzrrkHS ulg0MOk27LBANMP5hF1DJjfdI4C4U0gh1zayuQeouCH7mXVBTHgcBM8xxGzdkoCyYwnURewQFP8A TZwAuqEd2l5KgFwbKmuJGk8IAXG5ACg2IREtadhcoHAjf3QDW2v2KXIHPmBt6QqsRY32R69R24QF uAYdlGOuL2VONyhe8NbcICOALt1fljtuQrjOuMG1vymaLbjlAY5FnewUEmjYb/KkjH3uRsoY27EH ZAEzzGknkFVpLieyaNvlTTfclAAyPSbkoSPUSN051mj57JTrk+yAhOwDee6oGxV2I73Q6SVWCDTe 9keg+6DSBuTwja/WoCrg7W3Uc52kbK7WP/yhku7SLoVBAaYyL8qmO2tyqJ/pGyjPQSEKS/qv29kJ 1DccI+N1L7WAQjKZdw3FkJG50ph3AvskuNnbcoQKMOaOETnWJJRPjdpDibJRDtrboAtYsN7K2gOd v/dU5hFjbdWSBZAW8WNhwh0qF416f8qG26Aq29kE07Wbd0ZkJGkBYZje6SxFhfugOSYxrogb8oCN J2VMAY0AFU6U6vSNkBUloyCOUbRcXISni9u6MuJaADZAU2eSJxJH4RtrqkvJ1WZ7BJcxzzudgia0 25QDHzOkaAUTWt08b+6Q51tlb5Q5lggG6zG3m7fcINQa4PDbk90sOJAAGyYx4j2I2QAumc7a2ygK aNLgT3Sy2yFRCQQPdRtrklUQObWRW9BKBk1coBN8Io7uabqtIKELY+49kLzurO21lC0ObYcoCMF0 VxfdWHBrLWSkAZcGhGKgBgsseTi3ultaNgHb90BlyT+YAwDnulSRhpspuG+xULgSO/5QF2sBfdXa 42VWvyoRpHKAB7i0fKhtYX7qi4Xte5KXI8tAv+EAT27enhMYGhosN0AjLSN+QmXDe3CFQ0XFrDdD I4XGnk90t0jpGen0lBE4kG/KFoaXBzdxcqB9uyrUC3bdQOB5QlFjlQncKv3VE2QUEDflVf1KXsAo 3coGiEi6q291bzYfKEbtvff2QgwHQCShMjHAXN0trhKbKPprm42+EA64v6VRNigbtvwqJHtdAObq dtZKMup7m2tpTY5QxtwNwsaK/wDMc7+ooAiSXX7JjTdBGPjZGwat0Bdx3UvqO+6qUOHG6FjtvlDQ TthcbILa9yEwWcLFL9QOkDZBQzyxLYN5QyRFhBHZHBdjrDk+6GY+XcOO5QlCmtcSd7goiDbfj3VR 208onD082Qotwdz2TYyCBug0kssSqhZo25QDtIvcdkIGt5NtlTWFzjY3Rt9OyAU9hB3GykbCw8bF McNTSUIeQ2zkIRzfVyhN1ZIA5ugDyT7oLDBF91To3A3HCq+o7cqCd4IB2ahB7QCOLFUA63CkcrXm 2qyoT2c5pNwhbCkl8tuotJIWK2Vz5C4gi/YpwnAJBF0JeHm1rFBZQJcedkRaHkE9u6prD7JvmN0g abH3QgvzQwna/wAqvNLR7gqpDftZK1lp4Q0Nc4vYAw3N0y97XQxNuQRsU5zbW2ugF7F1gVVxqsRd Hw64F0BFt+EBRkJJHZUTqHuoRttwpEzVJYO3KEsFulrgebpjSASQLAIC0CSxKO2gX7FCEf6t7XSZ GudYNFgmXIdcK3fndDQAi0i43IUfGG7WubImlwt+Vc7g0tDdyUBjh9muYeShiaKbjf4WQ1oLru5S 3wOe67TshLHMlvGbhKAJcSP7ImtNvwoWlrdjZC0WQdQ90yxDNzskgkNudyjftFe/KGSrh5Sy433R McABcIHbSbjYoaDZ6WlCC22/KmoRtJP7JBe9xu1twhmg5b6LM2d2WTR1E8cYEvIWJIRsSbFNpqxj 3hkhsPcoDPmnErL2sVgvqGtda+6OqkbYiM7hYlNEXOd5h2KFMxjy8E3sUTI7uF7bpdmsGoEkKjTt qwHGUxEeyFLqKmSllEYjJB/qUL3Rv33vzZCx7zeEP8wjhxSmMdA8iQ3KChjWseHH+pV9oNzuhLbO 1dj7IgLG53CAqKxJ1H8Knix5RsaHPJKp3KEbFseGv9XHun+WHt1tCSQ0OtyFk08jQHN7WQgiwFyQ hDjICTwE17uW2v8AKUAQ0hARm4O3CXLITcWTY9rpLgbnbZAFGXBovtdMeAd0BPpFuQo12xuEAZlD WcJLpg8jayKQgCx4Sy9g7cIAybuuEJsq+7cGwUI1DblAWywO+6Y0XPwlhmlQ6gNggGujHZLsHMLT sqbIQN0QaHb33KAANsLX2UnFwAOyhjt34VlxLbFAVG+4sSo6NxGztvZDp08KxqDubBAV5Rdf4Rwu 39LbFW0uuQCN1InNifckfsgBe0kkN3coHemzm7onztimD2jn3VSSGSTVpsCgChfsQ7YBBKfN34U1 b8cq7gs4IQCWtI5RDY7FFYht0A25QE2Vggdv3QWubq3WB+EBT3AA7JVg9psbFETY/CuwvfgrSBGm 4/CIDflBpAJ3RNG11QWdkJburtuqO3HKArSQNyij4IO6giJAuUN9JIQFF4G1rJRILwQUyYFJDe3c oQYXta75VPLr3HCt7fLZxcqtX8u7ipQLuhAF1bXN7FWVOidFtAPypa5Q3twVd9lRZZBDgLqEbKrq A788qlRZbsoHlvyit25KpttW+yFGBwIudkh7iTZvCY5otsg0AO2QyyiSEVu/IRaATuqJ0khCAuuN 1H9kMhLnADdRoN7Wup2CjYuRHlC5o1bq9h3U6BfsjZzYHlLcbNuqik1EnghWwMMLeeSOUT3Oc2zT ZDFu11wbq7IAQy2xVObp2vsjda1kLiGGyjAGn5U42VWOq3ZEfTdQAykRsNkEcjZbNsdXumHdt0pr na7hoCAIs0uVtBI9RVl1z8orAEHlAC1zWHfdQHf2CkrBqBAUBvYBUEO7VWwb8orEWVONwdlAKd+F GkFt1LXIsreLt25QA+dtzsjid+ocIzsUstba/cJlLtK17RwgFzx+TNoB1FRzLc8p8jAau/8AdHO0 Fnp3KAwS0nsmhgDW2b6kxsTni9t/ZOgb/MsRdWiidRa2x5Kj2PNtJAV1NO/zCb2HZY7mPH/yhDIZ I8fcj830mx2QscwU+5u/2QMF2jZCoNrgDa2/yicwW1KvLEjwGndQsMbrONyoGS9wr5KrjZUhC7kd lDyFLqA3QFG99iisfdACdShFzygO3Kxn8skbFcQ7TY6juuXrL+XsuFnbpcPlfPxn05Ebe9rbK3Ee WTyUFzuoHh2xHK70cXyYTXmYu0i5CyKMPZfW23sra1sWrSLJkEu3qN1LBkuDnWVNBaSHbo2O1bop G6xe6gBurPPwo1vuoPU6wQAlJkHdOeLE7pG5cgMaWO4JtY+6qQSCna+I+pvOyfLu3f8AslxSNjiJ cNlpOmZPs+m3W3MnSfEosUwuaUBh9Ud9ivceRPqnYHJlwQ5joR5wZpkYRcuNlrmgqa+aJwhjZLET sLLHrMvVEwEr8OcXDf8Ali6+jjnSs8mfAsnZsHyV9R7IWX86VWJwYY+hpZyb2Zx+y678Svjwg6vY vhxy9h76WKgeHsqr2dJY33Xi6TBamU2hw+QBvILCsukop/MayGCUT/8A0yy1161lkukeN6aFU2bG so/VQwbCslw4ZiWD1cuKRNDHFps1wA91y2BfVvwjC4Gwvys9sHI0crXJNkrHqiPzP4RUuBF9TYys nC+n2Za5jhT4LVm3LvLJU3t8SRz8MF/FmyWX6veV/JkfDlmcTgbX21FfAYn9XjF564uiytpp72ax ruy8Ov6YZvoA6R+BVMrL3/5Bukf6bxkEB+EVUTz2dEVHuXKRYafH7Z3v138cGMdYc3YJjdLhxw84 c4ODXHuF2Nhv1Ws20eBDC6jBI6rTGY/NI+LLyG3C6kOFPLROjqHGw1tLVl4l07zLQUn6s4TKacDV 5jGEhajObXR0eHGuLO3ukPjVzJ0ozZjWLx0rWwYrIZXx24ubrk+v3jvzr11y7NgEdK2hw2b/AJkj DpJC6Ryx07zBnilcaCikqC3lrY9x+VxuZMkY/ko6cXpKihaT9zmWBWXkmjr4sclRg0NC6nj1sdre Ru5cnFC2Ok1E2kJusAVP6GgD43+aD2TaWSWYR6mEBwvuvnt88nqhBQjtifb5E6rZk6c4tDimCVAi nj20nuvQuE/VD6vYdRMp5cOpK5rNg4CxIXnTpp03xXqFic1HRSAzk2jYV3MPAP1elgElLQR1LXbg RldYXfBMig1UjrXrX4jM2dd8UbU43E2lgB1eVH2K+NwzMGI5eqafEMLndBUQ2LXNJBXauZ/B51Yy 3RSS1WWqqUR/d5cZd/2XXmG5DxufExhVTRTUdZq0iGdpa4n8Fexqb5PLB4oLajtDCfHz1jy5SMpq LF3GNosGyepfE9WfFB1U63YXFh+ZcT1UbDcMi9IP5912pgn0/upeZqFlVDSfp4XAOa6QchdbdXvC l1L6PUb63F8Ollw8f+9A0m35W1u9kePDLlHDZA8RvUbpPRtp8s4w+gaw3bGDtdfa4p9QDrdjmF1O H1OMNkZUN0ufps4dtj2SPDx4QMw9eZ3MpsQbRnsZdiu2c3fSu6l4JA+bDauCtc3jfcrlCVujM4Yk uTxlLieIZlxx9biMzqnEJCTJK83Lk+oFqlofyFlZtyjmDprnary9jlM2lxKlPrssOOYV1SN7v7kL yZNyl9j14q21HozRVnWGse5sg3D2mxC+rousXUDCcOFFR5gq4IW7NcyU3A/uvijKyDEHMftYXunt r4DMSZGhoGwva6im10alBPs+nn6r5zqW2qM2VxkIsWmZ264E5lx+mqTUw43WMqHHeRkpuf8AKW6G mrXsLdOq+5uEeH4OKjGBEXHybgFy9HmnXJz+Ni7SMqsz3nGogLKrM9fNG7+l8zuP7rAZUYpWAtfi sxZ3YZCbr3b0K+nZhHV/KLcVkxl1O6ZlwAb6b/C6q8Uf0/cxeH7DHY/RYwyvwph9RtYtC7QyzyLa uzzOGKDPN/8AHcfw+IU0OZq+GnO3ktmcG/jlcZUOxWOoEv8AGasPfvqMzl3V4Zuj2H9YM20eEYrU GGecjyrmwK9nZx+lNRz4FUVNFi96tkZcyPtcDbdedcyakzc1jStI1iT01S+rZWVVQ+vmaLB8jtRW RWV80dKXgaPYLkM05crMhZ1xHAK1xdJSSujJ/BWF5jaolrxYA91nJBwlTOuGUZL6iXPf/DYpnAF7 isadj43NeKmYNPZsh2XMOp2uLI9jGBf4C9D+Dro/lvqnmfysxjTRMfoAtz/+t1FLYamk1yeZZWwS FgEr9R5LjuidhlHb1mUn/cx+627dRPpf9NMZwCqmwyeooapsLpGyAiwsLrU9m3JUmTs24hhcE7qu GkndCHHuQSvdcpx3RZ5IzxxlsaOHGCUxsHVErGnjUSVlNwmOlfGxrjJGf6uyyHRzPjtJCbDgAJDX zR7GORw7DSvPJTZ7NmNO0hNRhGuQ2cNHv3SKbBqWim8w+sjflZ1RiDBF5bonRyO29WyqkpPNppLa yRy7SSAuLU0W4NcmHLURzuc7QdINrELEmoKWNplmp3xt51FpsvrunGE02L5pw+jqrSUwnaZANtQv wt0eRfCx0ozj05w6StyvSTGaADW5g1cbkLScl0c8kopcmiemkpI5j5Ba8Ebh290+GignLnGnbGL8 tPK7a8VXSvA8heIPHsBy1CYsOpnXbGDe34XXpwTFJB5cWH1D2Af0xkru1NdmYODjaOKGEUk7tMII eN7lZDcMhpmEyRCX8HhZNTgeJ4XS+fNhdVDE7bznRuaAiwjBsTxMt/SQSVOrbSwarrlKM+zSUUcY zDqeR12sBN+CFk/w8QkeXCzm9wvpXdOc1xNdIMtV5YNy5sLrf9l83VyzYTUuhq4Z6Z42LJW2IU2y StoKUVwmFW1ROiO1idgFktbojDXgXHBXEy1UM07Xh+vfay+vwfC347WUsDGckDbuoqZ1XLMejw6r xPRFDTvq3O2DGM1E/ssnEso43g0QfNgdTBHa+p8RH/hbUvBV4PMIyxgFJmvMNNHU1TwJIYpBcN25 K9I1w6dZuxebLNRhuGVtRpOqIRs2C7wd+rPJkzxjwaEaOUVoOuPy3t2II5X0uDdMsy5kp3VGFYJU VMQ31+WbFbCepX02aObqvBW5ccY8BrJRLLCW7Q77t/C9fNwrIvQfIlDHXUlHRYZC1sTpnRglzrcm 61kjDjbzZxWotV+Gh/FsHxXL1YaPFMNkpZuwe03KycvZMxvOWKRUOB4dPXVbjYRsaT/dbmOsvhqy J4k8i/rcHp4KOvcwvo8RhYBv825CxfCn4WcM6H4FLW4nFHV4u0nVUObwB3XNRilZj5LuqNS+ZvDj 1PyrSSVtbk2sipranSNiJAH7LrWjE1RK+lMLmT6tOn2Psv0H4V1IyhnfGKzAqWrgraiEFssDmXHs QvOeePp/5axnq/S5nw+GChwd8gmqaNu2p17m3wV2qHTVM5LVyT46NZeEeF7qZmjB212G5araqncL tcyMm666zfkrNnTyqNBj+DzYa9+38+MtB/BIW/bPmfMvdBsr0JlijpKM2ijjazn+y+V6sdGMo+Kn pZoxCihbJUxebS1cbAHxutsb82UhVfZcfpt6qpUuzQXLDE5o1ODXewKGWjglsGTgXG4BXcmL+HWo oPERH0/EnnNZU+U5wPIvZbBsW+lLkisyR5kL56bG/KDg8OuL2vuuOTHslUj3R1CnHcjVLgmXanEq qKCjY+eoedLQBcr1Jk36dXVfOeX4sVpKWOmbI3U39SdBI+Au7vAH4aMLb1TzHHj0Tax2X5yxgcLh zgV726u9cMF6Ovw2iqqaSSat9FPHALAfn2WtjUklyeTJqqV9GkTPnhqz101zNHhGYcNmppZXaY3t ZdspvYWK7yyl9NPqjm/AKfFKfyKGKdupkc7rO/cLarj+TMF6x5UoautoITVlgkgnkYC+I/BX1MFP U5dyc2AO/U1VNCQ0t21EDZbk48UuSQ1EpQbk+DUnH9Kbqi52meupWl3Lmv1WXRviN8GudPD9TNq8 Uqo8QpRYvfFvpXuDPHjr635WzdieH03T19VT08jmwgxOs4X2JI5Xizr74oOoHVzEa+gzLA3DBO8+ ZSOYW6PgLtLFNcSR48OoWR3FnnV3kTNjn9buxs29ln0tIa5rpIpvMI20WsQtpX0+/CTkHNPS+oxP GaCjxipqHAfz93M97DsviPGB4WsnZF64ZQpMrUEeHUmISM/U00Zvfe3C8iinJxPrvJtR0R4bvA9n LrzEKiBrsPwsHesm2b+3uu1OrP0rc2ZEy7WYvg2KNx/9MzzH00QIkcBzYLaZk3LtH076eUVFhlMy KKlo9Whjbanab7rrfoH1zrupeM41g+IYc6GSklcG1Dh6HNvwtQ3O5JcI8uTUU1H9NLOT+jOZM25q gy7h2Fz1OKzO0tpy3du+9/wvaWGfSNxrE8uwVNXmOCixN7A51KGn0OtxqC9+YB0JyzljqVU5twyh jiraoESOAHpPe3svi+tPVjMGUuoOF4ThWHyVVNI5rppGA7AldV951iOU8zUfv+mpLxFeEXP3hukE +MUv67CHn0VsHqb+/sujpKptVStc1xcL8L9E3UDKOF9TumeJ4bitHHV01TSO/lzN1Wdp2P5X59M5 ZYZlTP2L4RGNMUFXIxoPYBx2VcPKnKuV2dcGfbJRl0+jj4jHA1jNGpzh+67g6C+GnM/iBzPDhWCs NPRXDp6xzToYP/ldaYJ5RxaVr2Bx0aWXGwK3OfTqyjheC9B6OupImfqquRxmlt6iR2uvFew+hkdq 0dY0f0mcitwKKKrxislxIx2fKPsDrdl4m8WvgYzP4ca04nhhfjOXH7ipjZuz4cFtD6q9VOoGX+pF Bh+CYQ6XAGyATz6L3BO+67G6r5fo8/dJMdo6+lE0dVQvIY5u7XaLgj917NsopOa4Z8R6jdJ7Xyj8 8lNUCppm6PS5xsR7JlafLnbTt9rkqsy4U/As2YnhzBpMU7wAO1iVVWQ+KEn/AJoFnFeLNi8U6R9f FPyQUkEABbe6YHXSQSRsjbv3XM7oYEdj22QMTOQQENFh1r73Vc7Abqgy21kQuzfuoCNu02OyLVZ2 /KqMea4l3ZC0a5NhdUDg/UbKtiVJGBh4Qat0LYb2hwsUGne4Vv3sqA433QtFm7RdA6S5G3CeG7E3 ukvFuyEFzm9jbdA06rEphOoWslkEHYWCEMkbNtyClActKthIHKAPBcT3Cz7AQAZzslyF1zpKY46x uEIAuLJ7AMUTwL3sjbIHusBcqmhjYpGmSzidkMTREBY3+VaBTXBr3XF1HG49IsqeP5lxwja4kbC6 AFlmtIKOGwa6/CRbU/lMdI0MLRu+2wVAxpa25Iul6i4+obdkFKHNFpeSsgm508jsoBdyW8XWQz0M G1ksN225ULyORslAZ5oDthcqhICLHZCyZkLXG1ykue551Ftj7JRbMoNLHBoOxWUwBh9K42OSR1gP 7rKa5xbzuFGbTMwyhrQbbqyfMO6xGyOZyLp7Jg4bj1LNCw6h+iMAclVFcM3V6buGrt2VkHV8KUWw bNuVT+QRuFV99kzcNv2VRRTvu3OxVStaWk8q3tGsn2F0DX+azUBYXVIBoFh/2VluyLRfslvDgVWR gg7qH1FA5p1E9kxli26hCtTQLHZLNiOUdTAJGgg8IbizWkKkbDEbXM+fhAWeUedkVi0kjhLdUNqf R9rgoQY940bLGmkMZuBdOuI2ae6W8FgFxcIQBlVsLhPDwQLD1LHexr2ahYEKQG4N+UBlF19iVW6F 1wLgakbQbcW/KGkWXXb8qMkLjdVEAHO+EPnRvcW8EIQjy53bZCb2t3VB5uQoZAOTdbFhRvI2JTHG 52SWEOttyikfpdpUBb7aTYbpJBjIJ5TDJq9v2QOGobqkAe7Z3uULfQwEndDLURsAF7n2CL0SMve9 uwQE9Om57qa2hwDTx7pbHiU6bbBU55ZIG+Xt7oZGVMpdpKBr7kqPsXfCoAAbIAteva6yIXxMbZ5B KRGGAHuUDY2WJdcoBjiC4lu4RObpae6Q1pD/AEnb2TnTIASbsAsbqy3S25NlTn3bfn2VFwez1bEK AtvAtyo9zr/KppAAIQsc57yRwFQSIEkkbJrR5n3DZAw2KsyWNhygKbKBIY9Nr91b4HR7jgog0ubq 5QhzJrsLy1wUAiW4fujZIG7kbIZ4yz5+UpjHTnTwFKBkzuElnRHfuEcTDcat0t1DJEBbj3T3Oc2K 3fsqgQ6GSXG6dE4RXPF1iSHTCLG7kuMubHqJJuqDMnfrBJN3BY5G1wOULXk8b3UMpB02QBB2ne1y rM/mNsRZA0Frt+6u9wRayAjmbAjlC4FqIkho7qOsRfugAvvupJI4NAV3v2VO9Q4QAiXS25CN07ng E8D3UNMXsCHyHxn1btUIAJA5+4t+EY5+Eu41Ha4RtcG3uLdlSmNUvLDYd0oR3eN06Vu5PKVDG4vu UIxsv8uIWRNma6O39SM3LNJbssWYBn27FDIbYXvvcojG5vP91jNnl2sLhZMb3ScjdAUQG90JAlBB QTvtI3bdW14JLeD7ICw0tGwBKGRglYC4bhW1wJ2PCon1fBQF2vGG2tZG1g8q3f3Q8bBXcja10AJH p02VAWaQUbnADjdDYGPUeUAtuq1uFchLbAI2PLxuOFHDUz5VoAB7dIublWx3rF+EsRhgHdMLhYWU BTgA64CoaRsdro2yNB9SqaIPaHDZAFG0EkE+n3STI81Za24jCdGWsaSTa6U8mzrce6At85DrE7Jc mknYcpbo3uLSNwFZ1W+QgHQ+kInG5+EMZGnflU6xKALbVwhe5xcSpHvfdMDwwb2KAXECXC4ssggH Y7BJZUAuPsoJP1D7DYfKAaABuOFcrwyIuA4SBHJFIQ4+lNc0OZYmwKtgvC6s1cbiRsDZZL2nVufw saFrKRtmcXush72ka+6hUDb0kXV21MFjYhCOC5CCXH08oaMov0tA7orm3wk6SALi6cD6eFlgFriT 7D2Twf6R3S2MI3TWwvcCQPwVAIZGIpiHC9+Fm0zBBIC/7Slmle2xIv8AKUZn6gx3AQHNO0BuqPhc ZUxCeZrnuAAN9ymOqW2DNdvwkVcbZo9z6VEBE9fH+oLBYt42RWLgC07JJpYg0WH7phJaAG7hUEN9 Q22UDtyOyEO18q7bcoCwACd1X4UI25UG+wQEZc7ndRwJVg6RZRh1u0gXQAkE7BU06RYhSp1Mc0NG 3dXquAAEAVxa6okO5Gyrn4Kl7GyAANdq2NmprnmPe90qRxbK1o7o3HseyAps4mOlwI+UItFeyh2V coAxUaW/aST3CuDVUfACAOLAbcFDGHNuAbAoBzhqf91rdlb3X2KR6i7bZGXHjlAVbSebq2uB+FNX whPCAt4NjZRl9Nu6Hcd7I9BADggGbkAX4Qk3chYSHXJ2Vk3JsgK455UvcqPN1BsUNFjkeyt5BI09 lG91DZDLLALhykubqcSAmXF9ibqw3YlAFG5zo7O4QvJbsETTYd0uU3BQE1OtuUrWH3seFQAG5dce yjYxY27oA43Bx+EZZqPwhDNLRYXTCbHcICvL0jn91Q2BB3v3R62hUS0C52QC2xFoud1HfdxZQzaf wo2UP3QFxDW611HxGN/qbYKgdxbZXNM55AcdkKiNNiRcWQG/mD/ao6E/cD+ytr9W3sgoNwB7ITGH cKjIQ6x3TmltrnYFCCZGEMsy35QaC4erlMmIb9pUawOZ/wBSADVtsbJtyWC4WPJGRvf9kbKlobZA N037hTtZLdMzTqui83SwG1wUAWoMFkDHh52Nih83zJBpFgja0A3IQFFx12A5VA2dZU4knZXe3KAt 1/2VBunfYoZH6hpG6Fr9AsUAbyA4EpbIw2TUDcIi0PG5RCEgXCFRZOs2tt8qWAchOxA/wrItvfdC lNLpHW4F1Uh9duUYbY3S422cTZAU1hLrgK5G3abi4CeyLV9vPsgmDmsc08+yGSo3tcASeE9743Ab LAa7S+xCayTW70nYcoVBPiLmnyzsELNJaBe7u6p0rnv0t290flCKzroWyNbpcb8K2kElBLU3F7WC JoJiD7bHugCdwqJvuQqDdLL3VeaHDSB+6EZdtTubBQRnVqDv2Qi4U1aUBbnaHb8IJX2kGnghW6Pz bG6XIbkBCDIBYkphNzqv+yqI6dvdFpIN0KwNesHsiBAFkVwN7boGtaz1PNm/KBEHGysCwRF7LAtN whcSR7Kiir7c7omuDW2QsA1C6IuBdawULRHEFo90DTY+6Kwupp3+EBd77hS5AH/dXp3sOFNNhzsg BlNgLFXYSNBd2SneohMALW2QF2ZYWV2B2QBmpoAVlxA4QiAkfodpVxytsWn7ihcA43PKB+G+bd4f Y/lAxlP/ACmuBde+91eoFxQeUWNsTur+1u26EGtsWE3Q2BYdkoyiNpJCgqA8WG90BAPQbIWbC/dM jaCLJU/8sb90AZkLGlwG6XI0vawk2U+9nx7KBxlcBawGyAU+n1P1MeQja3lt7o54wxo0ndVGWxWL uSgCDfSAeyMizhbuqkf6h/tKogg3QIbuBuUPmG/upqJbeyuO1jcIUpwuN0tzTfZGAXOO6N0Wll7o LBZJZ7QnzSabG91jB4uCEbyHDjf5QoQcCb3sUEztTduUuSUssFIoHE6tR/CANspYy1rq2sGoOvuh e4Ha26tos4X2QDdI1AmyjyXGwOyFzWnuiZs034QANb6jujLBp3KSJGseQAUL5dIJugDdcvDRwkua 6KXU/gIonud6iFUpdI0l59KAa6XXuO6NhGg2PqWNE8uHp4RaCHklCEZdrjc8onvvYBV6iSrDNXey FstoLhYG6uUhjQOSihAY6wPKx6t2h433KEYW7mbiygIA37Ky1wYLm91T4wIwAhAXM842B2RxSkHy w3ccrGJeJABtZZTQCdQ2KGmVNSNeD6rOXHTU5gIN7hZ+4cSdygFOHkl5uD2QyVA0PF2m4+UbAJH6 OCoSIJAGj0qjC7zPM4PKFoJrC4lpP2lBJKWG3ZNLXG9jb8KRPDjYt490KKc5zHN8vk91ccMjnkyG 5KJzbm6tktza6oLDe17BAPRcP3HZG0+okmwQyN81vOwUAJYT6hfSmg+a3bsk6y4Bg2alSufAQ1hv dDI8gXseUxjNN7b7LFaXgkuRio0coCo5X+eRymlpcfVskU41Sud2VzzEvAagGCwJaCrOoNsLEKiQ GD3U8zaw5QAP9R22UBsLJbgTtfdEwWHqPCAjpACA4f2QyRjUCdmo7C97cK5vVFue/CAxXOINm7hN YCTsh1MDLD7lcfFygGuaSbONkLXaVQF9yhOw5QF+591e4tfZVYaVCbjZAXcq0sE+6tAESLKgATuU HdS9z8ICEHcg7IYo/VqO6bs7YDZE1oAItdABVyBzGhjd77lX5wc0DuoCAPV/ZCGsdxsUAXsrvpFu ym/fYBQua5ABMSQC3j2QAlwTC249O4QOjed28ICuBwhJDjyiGzt9wFf3t4sgEO9JsCi+3nlVLGdW 2yIgnnlWwDc8WuiuGtVNIJ5VOBNx2VsFvIuACjFgBflLHq7bIrc3KAjpd9uVPS/YH1FLLLOuNwia Br1d1QNaNDfVuUqwvq2uic4uQloda+yAuS5akBjpDYiw+U+wVlxIQGMYfLJN1AQb37JzxcJYaXAi yyyUQfCLsAhaLBQqkoPQCOUJbe29kTbhW5t+VSlNFr3/ALore5UGwAso/wBWwQpVyAR7qnv8tt+f dRrLA357IS0Fpuhlh+ZqbcBDbUNwmMDWMAslOcdXx7oQghI3RxNI3KIG4AvdWSdrLIAebXSmDXui N3PsQqs5h2F0YKewgWS44nNvblZTI9RBcE0R3dtsEovoVDC5zdyq1Bp0jdXIHl/pO3dWWtjb8+6q KgDudxYK9Iduf2U1bE8oCbm6pGWR2Vf5UuhLrFZIS39lfH4Qh2pUXb2UKR1jf3VscQDtcISdzcKN BQgWoyutxZQfdY8hA4esEdkYILi4qga1pc6wQPu24I3VtfpNwrdLqNyLkpwBI27WUcmlwkG1gQll o1coASLtsQFbDoFmqiN1YAuFAWRd177prbWsljc8IwbHhAG3bZQv0C9t0JPbhQk2sVbLYTmmZuu+ 4SHMcTYlODiNgbD2UtdxJCdjsUyC3yVAx3m+wTwy+4NlQaS6yUVC5xuNJs73CJrLtGo3d7qPj3H/ AHRgXuAqiMVI0sNwh3Ka8bAd/dA24v7KMhRHsh7IgAXEX290JFr2N1AQu0lXZVpu3dDf5QHbs3qY uNniFy5ck5wEZ9lgTDzGmy+bF0fTlyYv2v4uiIHJCsxhjQTuVHOa1tjsF6LOQl+k7IIG65vj2QyO sdhcIYJi2oBAQhyfktcy7SQrjbp73RseDGELiL7KFLBNvdCH6HXG90t12cbhQSm4sNkBHR2JdfdA SB8o7h0wBNgfdBIbOIH+EIY852PuuPkqTJC6Fou4rMqX6W78oKOGJlRG9zgLuCezPR6P8O3QX+PY bBW1jPNEhBawLYH008LGScPy6yvzDhsBh03ke4bMC6B8J08dHl2mLyH+pob8Bev/ABE0dU3w6Y3B QyGGodRl4ey4PHwvsaWCnR8bV6mWPo6RyHl/pHmDqxX5fwjDaKpjhJDDK0EP37L6fxQeEHCMSy1S YhlLAKaCvpnAvMMYBI7rXF4fc6YzgPUSGsgmlM1LJ6ze9wDvdbq+j/UCDqVkylrS0+YWhsjXDuF9 DJeJqUVwjxqcskaZ1Z0Z6PZdpunFK7G8GgjqY2/z5JmW4G/K5jpC/IWdMUxaiw3BaMnD5NJe2Nvq F+VxfjJz/V9P+ltTBhsTmPqrs8xm1rrqjwDVjKrGa9z5P5r4QTc/ceTdV1kxym+Pw80d+9JM70zp 1H6b9Pcxw4Li2F0cM0xAGuAWX0kHT7p5mcQ1UGC4bUxzi7XMjb/2XBdc+nWScx0tRiGOeVBiEUZM UriASbbWXm3w/wCdMQw3qPFhcdZLPRmcxsY47Bq5xhcN0W0bU5KW1ndPWLwU5IzxhMtRhOFRYbiz LOjkj2aSPcLnumPSjCmZDbg+PYDSzTUcLo3FzAfM254XYOfeqWFdPXUDcT1BtUQ0OHDd7br6Whqa fEKJtRTOY+KZt2uYbgiy86yzUKkv+ztJ1LhmpfJPUHCuiPiTxmKeiiGBmuMTqTSLNaTythmauk2Q uv8AkF8cuD0NRT1cN45mMbqZcbb+61eeKWgbQeKDMdOwFjXVBe4DstjPgqxF0nTuKnfK6Ty2DSHH hdcz2zVExzc8bkzUf4mehNV4f+p1TgmoyYdIS+BxHDb8L4BtWP04cRY/C9s/VlofLzvhE4aGuljt xyvC4DxRhhHr7LzamCi017Po6LJ5IOzuLw3ZzGS+ptFWvZ51O86SDwPlbrOieb6bNOUIpYGgPbyA Vot6YNEeL0WuwdqC3IeD2sZPlCSPVd4a0rhF3wb1CaVn2T+sMA6myZSnp9N2+l7mXDl811T8NWWc 652wrMjqdlPiFK8OIjaAHi/cLh/EV4kMo9Ac2YWzEcDFfiNYwuFSwAGMD3K4zob4gZevWcDPTRvp 6CPZrL7L6kINLfBUqPz9ytxb5s+t8SXiMwjwxZQw2rq6P9SZiIYoGD2XAZb8SPTvrr01qJcRmw+N k8TmyUlW8At2+e4XT/1WMvzYlkHBa2Jri2mlcSQL6VrAosk5nqcIOK0LsSNM/wBRNMHWN/gKbIrE pvtnfEpZMzjfR728KGe6DJHiLxPCMKIrsGqJSGEHZgvtYrZLm7F3YblPEMRjbqfDTukYB8DZaYPB xisuC9SKB1WyaOQzNa7zxZ2x7rcvmSWObJFa7SHRuonnT2+xeCK+6/5PXnTxwdv0fn86+Zxq849c MwYtWEySyTObv2F18XE00s0szW6WHhc/1DaD1Gx9xG5q5LD41FcPI/zaBhcA06+FdVGstHr0Em8K ZyOV8M/1HmGkopGbTEAu+FsE6TfT0yV1LytBXVFV5biADJewDrLyr4bunzc7dQKdtwyMNs0/K3Ad MukdDkHp4IsQq5DRRtMz9DyF5UnZ6ss3GKo8JdZvpXYhlnLtTi+T691fJTsLzS3uS0Dt7ryz0z6N 49mDNRwZlPK+rbJ5b4w3drr2sVvVydmbB82YHqwio/UUoBj9W9rbWK869EsiYVh/iUzs9lLGx9O7 zW3aLEk8j+6+njipRluXR8iWolGSp9n1vhg6NZg6YYNSR4rVXiEQtAf6dl8v9RhstV4f62njbd00 oaD7L73P3VvGME6q4DlenptFPXO3l9wuE8atCK7prQU8jC+n/Vx+YbbD8qY8bhki37OM8vkUuejy B4NvCjjuOyYdjxe/DoYGtLagix/ZbNMKwt2E4R+lmqHVbwzSZHcnZdd4BryT0EZPRx+TLFReYzQ3 4vdY3h0z5iGfcmifENT5o3uBkdyfZZnDc5Tj0jpLLtpPtmmvxfYX/BPEXmOF4AvUvcPwSuoGMLi0 arF5XoD6gFDNTeJTH6qWIxQSy+g22suh542S1EDox6Byt6um1Jez1aCV46Pq8kZFrs34rDhtEx87 3H1OAutnPhU8Ez8t4XR41is7qQkh4hbs4/leWvA1BRRdQqVs0bJPMLTZwvZbU+qeI1+XumNfPhJ0 10UN4dItZeJK2jvqJ7Yn0mJUIp8sV0UJLrU7mtDj/wBK1y9AvCLhPV7qBmaux5pbRUta8yMZy8kn a69sdCMyYlnDpqanFZPMqy1zXk+9l8Z4U9NHimdaGRnlTtryQHCxcLlfTxN4seSuz4mRrJPH6MGr 8GHRzCamnpJcEkdUTbRubc2Pudl8tmD6dmQ6nMFDiFIJGUsbwZaY2AcFzXiT8UuOdHOoFBgmE4K3 E4JofMkeQTY+wXzGH+KfqNmdlBLPlM4RhU8zWvrHtIs0kbqQxZXFTDzOTlFPoxPEz4JOl9N0mxjG qLCf0OIUMXmRSsPcdlxHgf8ADxkXPHS2aqxzAKaum1mJxeF6e645Zr879E8TwnC5BNPVUly+/wBw tfYrrrwU5Nx3I2Q5KHEaV0EDprgvG5I5XNfbC5N8pnRycMkY/wBHjrxTdDcm9E+t+AQYHRijoKwt kkjB+0X3WyPIOD0Ndk/LdXhlT/wMVINmcPu1a/vqG49R4p1go4oZBJU0dP5TmMNyCV7V8IMFXTdB cvQ1he6Xy7h7+SDwsZoKEYyXZ6MU3mjLd0jwNjPRKHqD428aw7ENIop6oXc7f0grYJi/T/ph0oyh DU4lgmGwYfTtDXVEsLST8krytnelqMseObDXRt8qmqZmvLybAg8hepPFR0+b1I6NY3hzQXSRwmWI A/c4DZejNUpQV8M8sMk1jnXo+Ynw/of1fwaqw+F2EPhmYW2YGsLbjkLG6AeEDIXTWiqqqOho8Y8y ZzoJnNDmtbfay1/dI/Bt1Nz0+pdRsqsvQMfZsvnFgIB9rhbN/DVlfGsidOaXL+O1RrKqh9Lpnm7n XWc+N4lUXZdNlnNXI+yGB4QKo0LMv07aUD/mGFob+ON15m8Z3hGyJnnIeLY+KSkwbEKKmfK2aJoj DyBff5XC9e+o3iCwzqhU0WSMPZPl9xAhLmbn8ldZ+JTJ/iMzR0tlqsx1tLT0MTdUtJTckW4dZaxY G0pOSPO8zlJxo1f01Iyhlex/qtMWNP4K7Z6eVQgxeleWhro3NINvldaueIsXMFU1rJY3Elo4B7r6 7BcU/SVsco3juL29gvDNVJpH6bTyuNs329GTDifSXBHM4no2glp72XUuUOj+HYP1iqqj+KH9WJDK GF3qN+y5DwT9WMJz30iw6hpqqN9bQMETo9QvZXN0SzVB16izizEi7CXO9VMHcBdtPLa5K6PkaqCk 06s7xxiaqpX0cVKAQ5wDyewXXXiDyhhGdMDoMMxybyMOdKDI8mwC5Dqj10yp0vrqSkxfEoIK+cjT C94BDfc3TOouB0/V7prJDhdY2QVTBJDUwkOA/cLGNODjN9Gcr3Jwj2cl0zwPDcv5XgwnCHiXDqcW ikDrghfR0lU2vZUwOYRpuHX4IXwvTDL/AP6S5AfFi9frjp2l75pTawH5XA9H/FJkrrNjOK4Ng1R5 WIUj3RkSWAkA7tPdMkblJx6MYmlFKXZ8/kDK+VcA604k/CJmPr5iTMxrr6T3Fl3xX0Rqq2E6yGM5 HZdR4J4dabLnUmozXQ4nL5lS/wAySN/F/YIurnimyR0gxmjwnHK8Oq5XAOjiOosueSAu2VvLJOH4 ccVY000cj16wbLmJx4S/M7QcMgkuXO4BX3OSnYUcuU38Gkjkw1rNMWj7QF8d1EybhPiF6cw0tHXN NDUBs0VRE7cd+ymCUeFeH3pdIzEq3y8Pw2IvfLI7cgBZ4liUE+b6LOShkeRriuzU94wp8Z6b+KnH ayhd+nxCoqhNRvA3FzdfZUvjV8RmF5WdHLg9TX0HlkfrI4jcN4Bvb2XVXW7rbgfWTxP0OaZXuhwK Oos58juGg2utr2ROr3RvE8gUVDTY9gstJ+lbG9sxYL+ne61qZLck/R7dLGsFyPPf00c0PzDiGapa 0O/iNURPKZN3ar73XpXxARZTwqLDsezREx0VPJpY5443XgvpR4mMp9BPFRj8GHujqMqYhMYn1MZ9 EdzsQtjOZsuZS685Og8+VmKYROBJHJC+4/wsKW3IpejjmgnB2c/kzFcLxjKVPXYI5poJIrwkccLy rnD6iGXelubq7KmZ8JqnVtLIWumYLsLb7Lu3O+bsu+HjpZLGamOngpIrU0LngOcuqskdP+jviVwd mZqxtNiWIVjbVBcW6mu9l0xxx1KWT/o8zySk4Qhx+n1PQTxM5S8QuPV9HheFQsihjEjZXhri74Oy 6I+pp0Cy/B07gznhGDQwYlFOGTzQt0+k8E2XoHot4UMs9Ec01+KYBMxtPObthv8AaF1v9R/rJlzL XRqvy+7EaeXF60AMpA4Odb3spGX+xU+DSjsi+OfRr18OFJ1qzAK2DplWVrIqU/zAy+i6+yr4eq+X urmXazqvHLFWxztfDUTE2kGpdgfT+8XXTboll2pwvMszsPr6n1mdo2O/dcl47/F9016qw4HHlrEB idRQv8xswbbSfYLjKS3tRPqxtxVmzOOtNbkSKqpG+c6aia5jfcli6b6H9XcCxbHqjLlNhBocYglc 2oIZYE35uuu/Bn40Ms9T8r0OWcVr4aHGKOFsUfnvDRKALDc/C9CNw7JORpa/Md6Gge4GWaqa9vq9 0h9YuL9njzr7xf4fZVks9PWxCBocwn+Z8Lp7xFdWMJ6UVOFPnw/9ZW1sgY06L7XXlnqR9RqPDOtV CMvRCqwGnk8iqc47Pb7hesqLPvSzrNhGG4pU19BVOc0SM/UPAdE7234VgvFNSl0YlN5YyUe/VnZe E1sWI5Sgq9IijnphIWkfaC1aB/EJROqOvGaxRsMjTXPaxrBfVd3ZbZvFh4usqdFemtRRYNitLiWM TxmngippWv8ALFrXNlrH8Oubsu4p1vixnO07IqSeq83XLuLk33XeE/FCcv0ym55IpelyfCwdO824 RHHX1WWMRhofu87yXaSB3vZbZPpp4s6r6LVNMX38qpJa0ndt/hdr5n6q9NZ+l2LSRYxg01A2geGR a2b+g2Gn8rVj4cfFpVdCOo9VNHUOqsAqax/n0wPpawu7dl468qtH1PJf1Rsu8QvVnHsj5twDCcNw gVFDWva2WqLSQ3fhdv4pUMbkmpllAY39E5zgeB6N11tgviD6UdV8EpKpmZMLkYQJBFPK0OjdyQb+ y8z+Nnx+YBlfLldk7I9SzFMUqI3QVFVCf5cLbWNj3XognPbGuj5MltlJ/pq/6iPbVdVcwSxuDojX SBv41FcJWtvU2H9lX6h9TUvqJN5XSF7ndySqLjUTucbj2WNZJSnwfZ0ycYUxzG7fKNu3/wCJA1pC Y38L5x6w28I+ELeyKO7ytmiOlLOe6W2UvkaE9zBqFxv8pbISZwbWagMlhDL90LP5b9QGxROs07FA 0OPKAMvJuUsjWQeEwC3dUBqNggJoB35shG7vYBFtEbF1rqnNJjNkLZYc65A4RkXHCCnsWG53Cpz9 tlLALrN7WKpztQtYIXv2F+Uxg1NuqQU5rg3bcJL4iw87rJLttkiWQPe0DY90BcerQQRc+6uLYm/K trwJAwlQRljz6rhQC5IWvcSfyo2MWBvt7I999tio2LW0gGyoF1I0lttwfZUXPiIEZuSnzSRwRfzP u7FI1eY30C5HdARlPLG/UeETo2ueHgWcmCpe1lntsEGvfhAWYddnX3CsNLb+6JoDvcKiTcoCcAqD 1bEqF4LrKm7OIQtiyDGSRuEYd57eLIHuLQbhLbM5jNhf8IQaXiPYblZcAHlXP3FcYH63Ejm6yacO LwSb/CGjMe86gTx7JTJ7z3tYBNePUgI9VrLLKZTZwQHXuUpzXGTVqI+AlOsG+x+FcThYb7/KhUZU LQL3TXbtt2SmH03CNrncndDRcrmNZY7Eiyx/KLYtDdm9kySzhqdtZE6UmC4HHdCWJYx0bfVyheCF ep0247KOF+6oKJDmjZA5vFlb2aTsUTwdI2TgyA8Eiw2KBwLXBruU9vYnYpNSNTr34QhTy5sZJQUs Ot+q26YzdtiqLiwgN2/CUQRI7/jXQnsLpgkJBNtgLC6hY1k3mEanFAWOkkuNm+yUDHe069Q4PZM1 A9t/ZPMPp9glODJQGi1woCnSuYRpRCp1OseVLNZZvPyrMQ5WkQp02rYCyRGA+UkjcJrmgPBHIVNA 1l3+EAZB/wDxoPI3JJuiDuyhfYFUBsAkLG3tpQzAFxvx7q4STfexVOsTuVAY0Qu42uQO6aXixF7F GWadwdj2SpWgb2uUQKZBAPVy/wCULmhr/Sdiqa7SNhyicPjlUjLis2+wQkF7rk7KyLCw5Q/bzshC 3Wul69jsqdIQ+43CJkpJ9bbAIAYzpG3KNztMe4sVVg9wtsreLg3QBUgBjOrcpb7DvZG1/lx7d0Li CNJG5QFt9TRbsimddnCUx+gaUIfdpadyUAbDpbYHlOis1ossdrN+QETHWNieVAGHBz3fKAO8p9zv dMDWpcu7LHhAMEjy8FtyxWXs3sLFYzRIRYH0pg9Dd9yUBcz7t0juhh1MKq4J3VWeSdI2VBmsxA20 kbDurEgLiTusB4sBY8J8NgwOQD3Oicy5IJV64wyyQ+MPdsLD4QhoYSDvdAG8j+lBIx+xsjADArEh eLDZAJLnbXRsu7eypzHA8XUZcXF7oC3NKo229lbnEKhuboCEWFxuiZIGOFxz2QO9QIB3UjaWm53Q GV54aQ2w3Q+drdpcLBKkcdVx2VxAvaSSgAna0PsNgUkyEOLHC4UlHmSDcpj2kN43QGO5ml1idirY Q3a6F2sH1C5Qjckd0IMLi82ulSBhJvyEAY8ONzslyus/ZDIcMpYT6QVckzzuBZKa654RA2IF+UAb rPjJ7jusWObW43Hq902U6Ba/KGCDRuRcHhAMiaC3e91Zbosnt0hoJG3uo6MP3BFvhAY7ZgHG45Rt cGm/KF8QaVZewGyAkh1epWZdYDbWQ6bm3ZNEQBB4VQAPpCtjiWk6bonM1NtdAI9F2g3CoEzOdH6g 3umeXqaHDumE8NPCMAAEdlKBiNDS7SR6lbw6PbssiGFrZAbXKXWOLHuI4CUDHkvLHpO3soIHBoF7 gfKIODmtJ5QPDnP2GygCbOWkAcInyarHhLdHbgoWscSb8ICi8tfflPY7Vyl/hQl7RcBAEG2v2QPB 0He/yFfmPsSWarqNJHptz7oDHa1wvc2+U1rSG3afV7hEY7nf+ybHohG25QBUzHTRkufuOxT2kBuk 8DhYXmeou1aT7JJqpDKADcFAck5oduOQqa4NeAe/ur8oloN1HRbD3Q0gg55ksB6fhMbBpcCFUW3y nR+okrNlIGlW0C3qO6v44Kq2lwvuoBtnOj9PIRQYgWEtLUkvs/mw9lAdzsgM2LGo9WhwAKGoq4ZD qtv8Bca6MAl9rlXGC0au5QD3QMkGoIWO+5l9lfmHRa6EBttuSgLaCRp7Injy1CC8ADb5QtGlpBNy gL1j2VkCwS9QJsidtZAFsrBBvZCeL9lQ4VQLIvdSO7b25VFxbsUQNglAN7gW7/csZpdG522xR8uu o6S53UBTX3Op2xRCx3CgiEtt0XlHSbcBALIBffuiI3KAAg8ornkIWifsqLbBWHXO4Uc6w3VTIDcO PChKom24CoXO/ZQBC9lBsfkog4XsqtYoCauULiO2yI7dkvUCboCz67C6IyeWNI3Q6LOBuqeQH25Q F7uPKZayFo7qzcd1WCc8FRTUFAR+FDQTWlU4e6rVbhQON0MkbZv5KgBDrk7KuXK9+/dAGHgDcIXy NvYN/dVq4HsluLidtggLJa4EWsihFmEHdSIBp9Q5T3zsJaLaQgBbu359lUh9PsVcsrQbBIdMHgWQ ASyiJuoogRLHeyqRuptjuEpkjmPDADp90A4WtYqnMBsQj/qsqaPUUNFx+ppsN1RNhuN1HSiJv5VF xmHsgL7coSLHhQ3aAOVYBtcf2QFX1W7IpWmVgA7JZJ7bFC8TMcD2PshkuRzHAMAIcE+NvoHusNjS 15cSmB7wdQFwgHOablYz6QyXsbBOEzjy23yia6/f+yAx2U7mNLXbhWGyOaGu4WXqu0jukQxEaieS gIGgEXFlZl3Nhso5l+CoGICMIPKLy77jcIQ0AfKgFgd7IAdYaTYfhWR5hvayCQ3AAVxvIvcICd+d 0bX3G5QkgEFVpHvuhbDLg5vyFbG3BVNFt0YAFyhLKP234VMPc7qiRqty1XwdkLYuUSB4cx2k+yja eRr/ADZZg4Hsrlkc29hdY7XGR+90Iw2WfK4227I2nydwLAorAC3CJjxaxHCAqNrWPL7buCJ3277o g5rnAEInAAWI5QpiSNtKxpHpK52rEENHHGANRF1wrmF0je4CZPMZHgcgCyEFzOA2B3CoH0iykrWh gPdCxxBBtcIBhuRY7KMZbvdE83KsDZABewS3NuUwtuFNG6AtsZbymd0LAb+oonAIChZ3B4QOcyce W8XHsmABg25KUI7O1n+yFQTImRmzdgidYjYoOAXdirGwuRsgsprriwtcIZCWi/BTImscS4Jc1O54 Lm3QoUNnxknlWXAfAS6eN9/hHOLgWsEAQNrkKwPTfsha3Qy5Q31WsdkBbQPNBG4+ETpCZLdlbWhu 4Qu3JcgC4PpPKuY2Zdu6SJLO4v8AKN5IaDbYoQAtD2B3f2S3ySN2F0bt7Hsi2sCQhBbS6XYko2/y W2dyiNhvwlykvbYIAJ7PA7pMRIJFrLIa0AAlV997BAVC8tNymPfqtccIGt3sTYoySflALLtr25Vs fp2DeUM0rYpAzuUTm3II2QC55buBUZpkI1jZWN/uCK/qAA5KAN2lwAAIsqvtZWW3k0gbjlQtINkB bNwr0kHc7IDttwVYaS290LY1o07dvdHMLRpQeS0AhG++kBCoxDHrYdyCmAaWjfdRzvLIJ2CskObq tYIQogE+6aCWiwCSLmxR6iEKU/njdS/7IrE7qh6ib7IAWm8gBNgnP2JDd0t1Lq7/ANldvLLQTYD3 QCbk3BG6BoIduLj5TJYj5l2nZW1122Ld/dDIwEWHslvtIQ3+lWftUYgBjjEd7Hb2R3urDedrEqgL BAVff8KOc0bg2RNbvxskPBDibbIB5mYWXA9QWIwOqZibbjhG2wdcohIWSenYICi58Z9SHU5xuTZW 9+sk3VDfdAU5h1h2q6MSkvshJ1CyAOc1wsEBkawSRbdUzcG4VRv1u1WsQoJw5jigI4XN0QcSAUET 9bCUYd6UL2WW2N77INdjfsEfmDvwnN8t7LsF0AvUNJIF7pUcWq772PsnuGnnZQgCwHdCAaDbc2Sw 1xu0cHunE22cVQJt2QC2gAaSP3Sy0F1rfumSOs33+FTpNQ2FigE6iSQShey453T20xc25VCGxuey AWBobcXCW2+q5F0927UgEm/ZAODgeOFRB1ahulsNjumtfbugI0g8hQkDvyhc/wBVgo7c8oArgDdJ keXNsmX7HhA4D90AtgN+ER+5S97BQcc2QDBud0DgR2VteCAR+EX3NQCtRAPuqLtIKMtH7oSRayAJ o9N1CVTTY83CIkPIsAgKLbFQi3ZQnVLt2Vude/wgBa4tOyOJ/rJKUTsrY06b3QBSNBcTdC0AKFpV g2AugDJNgCdlZs0cXQakd9geyAEAt4VAe1wfZMB2VC5fa26AUY9TvuDVbo3MeATdp9lZY1zi12xR tJaLne3CFoT6S5297JMzr7NWQQ2+oDuqIZuQhKEQgH7timmMXtdTSLcIH7cFAFYm4GyomxA7JDnE G4KvW4ixtdANPIVBoG4QNfbkIgf2WkAwAqOyl7BBJyCeFkFk27KAgoXEEgKwLDlWwEDcWKDgK9W6 suBCtAB2zeEF9wmIXNF/hSycka65sjuli47KXsEsjG3VpYKgJCtlDKqwVarqat+EsDWuu23skyN9 uD2RRi7yic0OdcFUoLG2sb7+yIbcoS7n/wAKF/CgLIBN1ALfKAyWUEoVINaHHcKOk3sdiqbNuFCA 517IUY30t2FrqcN3GyoktCEyuIsG7LNgQZAXmyu9wq0XJIFlenZaAN90LnWROFhsUiTfusGWE9wa Ahc67wEsnYItr3QgwIhubJYcjbYlAXosd3WQPB3CcY9RbvsjLbX2QCWbM90Vu6KNlgi06uELyKvp 42QjZ1yieCDayjgQASLWQWDybqXsVFNOrjlCFh3zyja623dU1gBv7cqOkCvBUE43IVh1ylCQFG2x F7gJwBmysk6bJTZRdMa4FKFltv22TLaN78oLt7FR7r23VNFSFxQ6rcFR77tPayxhKL+yGWZLuL3Q Xt+6X6nWsCQj3HIICjIWXN7GxUDm6rXSJm6DfkfCBjtUjVAZV0NvhWbgkbWU1gd0KdthnpIO4SHM 3IAWSPS26Fjg6+118tOj6dHGzBjXc7+yx3s807lHV0+uc2cWpektAuvSuUcX2ImboafZKpo3uk2N k+Y+k34Soj622dZa9EOR0Pa3e5HwjA2TKSYaNDt9lT7A2CyCMsQRZUCxwPY+yoXF+yGRoc0lp9SA Can1tve1kprDpuCm6Hlm9zZIG9xv8oDHmZ5pt8rBMpirhG5pIHuuSnj8mzgrmDKqJrgwCRvf3VXZ Gj2V4SupGHBlHhdbKyJwe22s7crZpmKjp889M6uhp5GStnpTECODcLQfg+N1GFzRy09Q6CeM3Aab Er1d0L+oVjPSulGH4u11bSjYCQkmy+lp8nj6PlavA8keOx+QegONZE6s1mC1+HuElZM90M7hs4E7 WW0bKFLhnRzphTCfTDHTRgzyEcu7rWb1D+pFhGac2YVicOEGJ9E4EPa2xIus7rP9TWh6jdOp8tYL QSw1NSP50sgLSDa2y908inGmeLHiyRjybGMxQZa8QfT6qoopYqqKdhMUjSD5b+xXQHhc6b4v006m 4hh+JxvYWvIa9rDpc3tuvEfh78fFd0PwubDcQw6avp3glpa69jddiv8Aq34xR4uKiiyjEaZx3e7d xHtdVSjFNL2co4cm+2ewPFr0szTnTG8JdgAnmjkcGvEb7CPfcn44Wf0s8Mj8kuo8Xq5TJijbEt5A Xk9v1i6wRgSZPjkedr3IsvnMY+rzm51SDS5apo6X/qJLirDNLaocHKeCcZ2ke0/GpgEmIdOYMYjn Mf6N7fMYD9zV9H4SMUrMS6XQSVM5niH/ACi43s1azer31KcwdZMlOy47B2YeZHeuZpvcLg+lPj4z 30RwU4bhrYa+h2cI5DwVynNRjsOsNNkm3JnePi06YMqfFgIqb+fPiuhzmsO4C9v9Dcg/+mOW4XTF zQYw4gjYCy09508WWbupnU+HPHooK+EemJo2/ZfeY99R/qpW5efgkTY2sli8l05b6gONitrKpO3+ HZaaWPFtR9b9Sjq1hPUHqLDh2HysnfQEMvGb2I5BXkWSUztjbbTobc2SKZ1TiOJzYjiEzqmrneXv c83Nys6inZHVytIB1C1l4s2VZH9ej3aXBsjyffdHqSnxTMFKPNDPVYXPdbivC3lSfCMvxzkObA9m xHB2Wj2hq6jBqps9HMYZmO1Mse67ryj9QXq908o24fh9ZHNTs2AkbdYxs7ZouS4Pa/1KuhdXmqkg zth9QXSYdGWS0zXWs33Xm/wP+KDC+lOZ4cOxohlLUP0GV39JuuoepvjX6o9XcNfh2L1QpaWUWkEQ trHyulKNhYHapC17dw7uV75zSgotnzNPp3uk5Ls379TMj5Z8SfT5tGyvgqaSoAeyWNwNlhdN+guV ekGT/wCHPpaWSmi9T5qhgLbAd7rSdlbxFdQcgxCDLuYKukLftDZDYfsuUzJ4xes2a8FqMHxLNFXJ RVAtIAbOI/KypJxq+DjLTzhNuKPXGDxYB1E8X2Jx4S6mp6Gmlu1kBDWOIPIWzGeniZlV1NNK3SYP LebgixFl+dPAcx5hy3XNrsPxSejrufOa46j+SuzIPFL1shp9AzpPLEG2DJHcBeWP82z1zwynj2vs +k8bPSKm6ZdWPMoqmN9LXyOkaI3XIue66ILA+q8txuwe6y8fzXj2e8RNXmLEZK6rDrhz3Xt+FUlM Q+IsG1rXWsk3kluO+iwyxQ2s7X8O/UtnTvNUFXMf5EUrSb9xdbiemHXXJXVbI0cDMZpmGaLy5YXy AEbLRHHSPjMmp+ltr3V4fm7HcEa4YTi01KxxsWxvstRUfZ3zwco8G+vJFPlLpTHVxw49Rfp6hxe1 rpmgtv8Auus8T6p9P8h9YP45DmWme2uAjqmtlBF1palzNm6aQmXH65xeb+qZ1v8AukPp8TnkbJV4 nPI7m5kJ/wC69S28tPs+YtNOlfo35Y/XdPM54nheZ5Mw4fqoP5kUgqGiw+d1wvVLqj01z/kvEMGd nXCoZtOpuqdt7jfYLRe/EcSEflNxqtEbR/yzK7T/AN1g+RKZPNbXyte7k+YVxb6r0ZWkak3+m9np b18yFmzKEWX6nFqYvpYxTEyPAbIALXCzMudT+lXTFtRhlLmygh815eWmcENJWh/9ZimHS3psUqop HDd0byLrHnZUVMt6nEJzITu5zzcqKSdq+GWemlKmvRsC+pXL09zFk6hx3AsZo8Txuep03pngkgrw jDTSU9M2J7QA1oOtYLKGBul0lbLU6d2se8kA/uswvdMxxD3FltwuWTJuZ7dHp/BFr9OzejHV2fpl j9NikY8zyXA2H5W0zpp49+lXULKkMGO4xFhdboDJ4KnZvG5Wm2jIii0NALflY89FFWS2LQNtyw2U TTPTlxLKuzdhF4y+iGSoDh9JmOl/SEkkwbi5XwGHeNDo9lnqC/EsKxUOixD0zgu0hp91qJmo8Ojj 8uQPB93XSaTCqSWR1jq73D16W6j12fLWkakuTdzmPxL9AcbqIMUxbFcNrKuMXjMjA5wXUHX/AOoF 02hydUYNlIMrquRmlrw0Njj9rLVQ6jidI5sZkYBzc3SWYOBJqadVz3WFk20aekaZsN8M31Iv9G0M uE9QJTX4cHu8idm7mNvsPkLubqR9ULpfg2TK1+VJpKvFnMIgg8vSA4jlakKzC4XkRmUB1trrDwmk hgxN0UjWva0X1pug3bRr4zqjtGTrTW5z6ruzdmTzKmKaTXIx2+11sn6a/U26N4Dk6iwuomqaKekj DPJEe2w91qQdXMkxTy4HDymjiydNQmsl2oDOP9zGErM5vK05HohihijSPb3in8dOV+ouZMIxPKNG 5tbQPDm1lrOduu5Onf1YcknLNNTZpppmV8UYZLpbfXZar6eKjiq3Rg6JR/Q9trJlTR0ZJMsTHyLr KalSfRiOnjtaRtYxj6t/TnCoJGYXgVXVSEegABov8rztgP1Ns04X1BrMcmpNeHSPu2kJNiy68Xw4 RTmNr2nc/wBKyXtIi0SRtI44XRSgl0clpH0bOKf6vuVJI4/1mV5zIPu0G/8AZdLeJz6ltV1byzJg WU8OqMMp5gBKZDuR3XillHExj3MZeTsDusNlTJE58c0YDnbXaOF5nNR6QWkqVthimNXUOqZZddS9 13H8rkm4kMOdHE/1B5tdYVIY6fvf5KKZrZpGOcQbG4XJyTdntraqR2h0v665j6G5hhxTAa57I3EF 8DTs4L1a36ueYabCxFDgsVRVhttUuwuvDUTG1oZAyIyynYBouvoo+jGc6vDHV9Plus/TAX1iE2I9 +F3i+DzSxptuzkesnX7M3XnPMmZsZcY5nN0CGI2a1vsAvvukPj06idDMKiwrCn/rcMj2/T1fqAHw V0AaSuw+uNNU0skErOWvbpI/uvs8ldHM19UJzHgeETVzgLlzGGw/dbc5P0YWDHXZ291l+oR1F625 dZg0gjwajJ/m/piQZB8rprIfULNPT/G4sYy/iMkFdE8SBwOzvg+65vOfh36idN6H9ZjOXZo6AGxm DNm/lfI4LS1WJ1EVLT0snmyO0MGnk3Ul5KtKjGLDht27PUlb9TXq/V4DJQPpqWlqXM0NqoxuNrXX mLMeeMfznjU+MYxWS1WIykuklldqub9l23/9xz1grMHjxKly7NPA5uoC25C6kzFgOLZQxCTC8dw2 XD62M2McjSDdSLm0HhwqSaOz+nXjV6jdLKBlBhtVI+kZs0OcTb9lgdUvGT1T6xYZNhuMYqWYbILG nbsCEHTbwy576vQvmwHCJp6dov5liAuO6reFXqZ0rpnVmN5fq46Jp/54jOkD5IVjKUH/AGWeLFLv o6igpGPDo3DzHG5N9t1jxUNVDdoqqiOIG2mKQ2CYK7QXMN2OYdz3KBmIF8ptKGM4JcFwk5OVyPdC MHGkPhmFA58LC6Rz93Pcbldn5F8SPVfpxStpcuZpqIKECzaZ7tTW/gFdd00cTnBsDTNK7b073XpL ox4Is/8AWrCv1uG0gw+lIBE1QC1p/C2mzGRY+pHTWfusnUjqZP5+Y8anxF3/ANIyEM/ssLJfVLPP Ttrm5br58NLjdzI3nSu6usvgQ6ldFsPdiOJMFbhwPqqKQ69P7BfW9C/p35w6yZZZjUOJMwulfux1 QN3f2W25VdnCMMK6OjMT8THVmtj/AJmccSp97lrJSLrrzMmP5hzlXDEMbxOpxSoG3nTyFxA/de9p /pHZzdIXPzNSvZ/08/2XXfWT6Zmcem+WKnGabGoqgQsL3U4duQFltvgiWHdyeN6qihqIRuPMHN0N JQwOY7+WG27g3S43ASy0c0UrpYnFsmgXNwbIotNO4thbO6/9MjTey4ppH0VtSM+mjqIHxyUlZNS1 DT6ZInFrh+4X15zvnfEKEUdXm6vqKUDSIXzkiy+88PXhezL17x2CjwenfFAbGaqdsyNvvdexsY+k W2LBTNQZrL8VawkRvbZrne111i+ezxZZY/aNckNHJC9zjMTIdySbkrkKbG8Xw+ndDS49VU8P/wBJ shFl9pnvw/5z6cZxfgmK4NUsqfN8qJwaS2XfYgr1/wBE/pdVWdspU+MZtxV2D1NQNTKVrLnSeLrr ODx05ezjHJiqoo151DnVExkqqmWqcDceY4uv/dYmNVERpGu0aLcOBsQV7r8QH0ws0ZAwCsxvKNe3 GYaNhlfBa0haObDuvCfmaaienxKExyRkxuikFiHD4XLLCUluu0dsDxSbSXJiuqa+piZHBidT5Zb6 m+adNvws3DaNzqZzWucXdzdY+GtgYyZrGWtwvRHhO8L+Kde8ebTPkNDht7unt2uuUJbVZ6nGMfR0 A7C2U4JjrZoHHlrHkBJNB5hJ/UucTy4uuSty9J9MnpFheFxQ4oZpZgLOqHSaS4r4fqd9LHIuL5dq 6nJ2Jz02Ixxl0MNw5kjh2K9UZxlzdHglkgu0apaGlNNKQ94e08EqHU2oc3b9ln5+yjifTfNtXgmL xPhqaWQxvjd2IWCHxSR+bCCfe68uWDhLk9mPIprgNE1AxxcEbCLrgdkMCZEbHbZL5sicQwXVKMsH OueUZdcW7pQJ0hwRB17FAQg3UcS6wGyl7nZEwFxF+CgLsWN35VyFwYHBFPpNh3Q67NAsgBEYlaHH lVHIG3bygLpA6zdh3QtaRJugDLXXNjYKyzSb9kJmcDpAUMzmANO91AS4F+6ppd2Oyj2nVe11XCAj 3JDQHPJKcRvzyqDWAkdyiAgO9dwmNcdXuqMVnW7omgxkgogXGXF9jwjdII3JbngsNuVUb7NLnblU BTATWLm3t7oGTmGYOayzVYlJJBChOrYBAMqZPOIdawQMOx90IcRsd1bTYlAVHIZdTXbD3RC8fKFo 9RUcRaxKAtvrJsia3dAZAxwAH9k/Y/agBDNeoEIHtDBZvdP4bzulPe1u3dAJs1vA3KyaUtaCO6Q8 NDb+6AlzeDZAZ0d3EklXe6w2SOIsrL3tad1KNGW5m17jUlNdo+7ZJilcRcnf2Ty3zCCQFOBY+Odr hpCyGP4HZYkcTQ7mxTDKGmwN0KFUyjUGjhBU1ZMHlRi5KTJJuSeSlsfYhxULY6KV0ETWuO/dNa4H dYrv5xuEWosYB3QlmWLEhXKRew3CSx+rvZEXEHYXV4LwRzbpUoOm9rJurVyhc3UTfhQgDTZgJG6A uNzdNILmelqXpLr6hwtAUCXyWvYppeGjTwVTmd+Ekuu43O6lgyXAOZzyscQaHbBMbwFHOPYXSwLc LHflAHlrrJunUbKmN1Pte9lTLBMRDy4kgIQQ43COeUB2hDTNtJuLhUgR4QopSCTbYJesN4N/hANY LDYJchs7Srkc4tuzZVpu0O5cgJO70gC4KBl9O990bmlzLlSMEtBUKK8wg2tsUWnU4BE+19gqJ0gk coYop48kElKkJO6skv3fwFLawezVQAxov8e6MNDjyhuBwhJcFAFYg7KOJJGyjXgiwV6rkX2VBZ49 /hRjdy48pnlNJBabnuseV+mTSEAAs55ud/ZG1ul1yN0iYeTMC3cFPZISASELQWxJ23SXO9SeSHnY 2KxmXDzflBRlMsW37qg0u7XQNcQQOE3UUIC9pjFx/YLGmkNgXbHsnSSFqxn6pXgEoB8djHfkpjXW FvdUAQLWsrFgRdALEQjcXXvfsmtIaNlHMB34UZcbIBjHgg+6gcDxyqe0svsgab/lAGdxuqbsCeEQ HHZKmJaQOT8ICGq0C1id+UTS1/qvuh/5bL6Q+6jQCLjZAR4Jd8KDlU8l4sOfdVG0s5KAPfdUSSQL qi+/HCob990ATtge5VB7g2ygYPdE46R8oAQ1oNyrLyTtuEnU7uUTCQDcoAHXvflAWtB1DYpsbDc3 4QGP1uN9kAp0hIIP90DmXHujfshdEQAb8oZoFrXAbi6pzbu4sjaHBt7/AN1RcDwUFCntvtzZHGCW 2J78KiRqJS7ku5Qg+qq2xU5BYbAdkuhkBh80uOl3AKXUueYSy178qCNzadreAOyAeahrhYEXCAuD rHYlJFLqNxcfhGInMFggHsIJCsus8gnZCwgBSwcdygIQb8o23JFlWkhVqIvZWwFJUNadP9SF0wda 3KEsY513Df3QFojcbJYMiOoDQQRv7pT2aiX3uFjvnIdpDdj3VxT3uCCWqWCzcu22Cjnb+yGSQD7d lASWAndAECSb2uicfR7KtVmg23RN9bbuQANbdpVeaT2Vglu1tlZYCB2QFibkKFzRudz7oHMDVY7I CMdaQEhM8sSXAFj7pUh1kb2sje42Gi/5QC5KIuBubFNhpGNDdvV7ofMcGkAm6ZC97hvygHsm8r02 1H5RH+ZudvhKBaCbm7vZLhqHa3ahpIQ0jKZaNwDtge6dcR7jcJDbVDRrP4WQCwN0De3dYKgdbeSr dJ3BQFoJQlhBshWN1gncbqA2ddLIcFbdQ54VIQP3Vi5G/KoDe/ZFz6lALuQ4omOPdQkudsFbhsgK 1u1G17IWu533VmfTsQnMax4BQAMbYhGeVU5DQNKBrjp53QDCCFY27bpbXEnm6ji4OuRZUDDu5AQb 87IWPKLUb7BAQ2/dU1ur8qE3cqe8scLIAtBah1kXAKZcve0cX5VSMDXEAg2UAtoMl77KwC0KAEn2 sqfJZwA7ILI5x7DdQuJaBbdPaQ4dgSlvYN78oCRgHk7IWHU8jshHKNrbXKAsgX5sgBu427JT7ufz ZGbC1uUAZvY7KNj1s9rKnEiO/dDruLIArWI72RBoJvbdCQOzrFGBdvKAWXHWiJBV2KjW23QFNaHH uFH2Zba6PVtvYFUXC6AgcWt3GxQN9VymeWXWsLq/LLAQRZAKDd+d0VyO6sABC48hAU4XF7qWPsrD Srd6QN0ALiBuhlIdZC4g3CKNpI3QADd5VsZd/CPSASO6Jo2+fZABaz7OKM2O/ZVIdO9rpYcbewKA MODXAndSScfdpQtAA3VSNvxwgCEkM7mgizgpJs70pLGhr7904uQFyRm4KAhzBsqfIbXVCbU2xQFt dcfKW6eW5Gm491fmlp4KYDqFyEAkEv2PJTozobY8DsgNhI0hZAax55uUAp9WxzS0DdYzZfKNyOSn fprkkcoG07mOvILtQD2TNk3CvWLpDRcmwsjZYHdAHzwVYFylEFpPsjjIcLhAERYqPYDaxvf/AAqa SBYpjbDhAI02BHspe1u6cWhw3FksxHVzsEBUrtIFwAhDbtD7pwjbpN/V8pZisPdAXGL73VuuD7q2 N0tG6VNIWPtfnsgDse6E7FQXc2/Co7IC7XG6jWhu6g3VuOyAB7bnlFpcAPZKElyRyUX6gsF+UA5s txYDcIWSOc6zhsEDpjtwCUwEgb/3QWXcAkhQgkggfuo4ta2/KsO2FuEAqeO4G6EAtaEb7ufzsheC zvcFAQcIw64S7Hsibcd0AfJBPZS+226EGwurvdAHuRZW3bZC13yiDkAJO6mn3P7K9iVENIsW47Ig QTYjZC0XvYK92mxFkBTQGuuBZHLN6LDlDq39kEzvTYC6AyKdrTESeUhrWyv0gkFHFIBHYcqh6Tcb H3QEkAHo7oWMDeUQZqdq7onXugoW427IXNJF28oi0777qhcFCULe4ws1EXSoK9tSS0tLbe6yCdrE bFY9SwNcNAAuhBhBHG4RXsBflXGLMAUc3a6AFwv3shBPF0RVICED9lRsOEN7Kie/CAIncHlC4kOu CqLhbndLLjx/lANcxh+4Xf7oC5xFrpdxe55RBwcgCFrblQnTwq+FC7SEAJmMbi8k6iqiqnXuQo7c bhU0c+/sgMh0o5d3RvcQGhu1t0hsZLQXBMDi0i7bhAMMmq1zZW9wsBdLc+xFhZCCC6xQqGMjZqs/ c9kTnbadHp4uoHEngFEDvv8A2QpUcelhsrAtsSr03sAVU0epwF7IAg2wVAAuREGK19/hQSeY7SAB ZCIMgtaSClaRKz1i6N4NrA/slkuY23ZCgvYdO3ZKJI/KeHkggjlAYrG5QjRQOyoelUR69I5RSgMc BzshATJc/hGLu4CXosTso55bxwgDBtdEW7XSb6VZce52QEIF0Fh7q3EqrWBKAXxsrDrbJkcWtpcT YpJBa7fjsgDAvf5QiMpjGXtvyr0Fh3KAAO08BACS/wBgmkWCq4J32QEGxICsu07Khyp/V8oAtYDb EXHdMbpay/2gpB2CXIXOsTfZCsygbg9x2QmXSeDdVHLdgFlf5QgDpXB2+6p877enaysi7iqDUAXm eYBcK2x7/Cqw0hW307+6oGF5azbdYzJiXG6KSRxBssVziABy4qAOaXflWQLA3uUiVj2EEqB+nYnd AZDdnXsiaQ65A2S437e6cJLAACwQC3t7hQEbIneruhcRaw2QFONroCTfhGSALjlLLrA3NigLJBQS EabBVquUmWcNdYfcgGNcWjcbJsT9RssUSPOxcE5j3N32/KAaToJuhHrG29lRJkBVRh7b6VQWxwNw dirDiHWHCuKIcu5WR6QNuEBcTARc90mVhbunMFgTrFvZJllDhsblKADRflWHG9gqIIIREWv7qAj+ EPKHXe4JUMoaADwgGht0ROoWSGyeygkIFwUBkAEFMY0E6juseOYuadVgmsmGkqoFeVrk1dlHt9Vu yNkrW7lJlk1ONlaLQOkG59lNOm/ykse4E34+UJn9SgY4u0pRdYHugfMALE2KxmTDzAHElt1DI18o B+VXmjtymP8A0x3a4rGe9gcS0n+yFMyMB/IUcDcEduyx6V5kkN1klwaTugITtuhLtrJUj9zZI84g 2PCEMwWV3HusXzb91BMLi5QWZVwSqeQLLHdO0jbYof1PYjZasWZHmBU512jdYwlDjbgJZkJKgMrz LFTzWlYmsqajblQyZmu3cWUMqw9RsibIRzuhbMzUHfCtp7rGbJ+yax1ud0IZDR3VloBQtde3so82 77LZsU51rjkpcko027qPeInEt3LghpqSorpNMUMkrj2Y0n/spdGW6FGRw7qzIQuzsv8AQ/HszUMf 6PDpGyn+uZpaF9LX+EDPNHh36v8ASxzG1yyN112jhyTVxXB5XqMUXTkdHNqCDwnNqQNzsV9BjfT3 GctNkFfQSQPYeSF8qbm9+ViUXHtHeGSM1cWZ7ahttyibKBxusFg8pwEjbgqGWzvSNlyN2ZrpA08W BQPkHZIDpZACGEt+AgdIBtax73QtjHvsL3ukvOoXQ/8AlW1hcQ1t3E7AAJ2ZKKpdtZF8MXUDPNEy uo8v1LcPcL+fKzSCPhdiweDmrZQOdW1H6apaN234K9OPTzyK0jzzzwx9s8xAkJ0bxY7rnc85KnyX jU1DNI2QNJAcw3uvm9JXFwcXTO0ZKStGa2XTbZU6XW7sPhIjm8s7jUFUpD36x37BRWaMjWGkgmyK OUFuxvusV2mwJDrppmYYg1jNMg7+6lMWOe4E7bkJD6n1bhUJ7AE7u7hQSseHB4sTwfZQE8zXxshL 3NPKpsTnu2DiT7BEaWcXPlPt+Fra2rSJaKEvKBz7om08kr7NYb+yy24BiLmaxRTPYO7WE/8AZXa3 0iWv0wLlQuJ7p8tJPESHwvYRsQWkJ9FgldiJIpqSWYj/AGsJWWmitpGE15aNuEXnGy5d+TsXjh8x 9FKxvYuaRdYLcGrXvDG0srnXtYNV2t9GVOL6ZjCYjYd0f6kgD2X0FJ07xysi1songHgO2TJemeYI 4i8YdI8DnTvZSmg5xXbPmTNchOoTCyQvmGoDgLnqbptj1UAWUZB9id1yOBdHcy47i8OHw0DzLI4N B5G5+FrbKroy80EuWfJw1T/NPlN1XPpFlzP+jcw1lOJm4bNJG7cEMW0Dof8AT4yjlPp9QYvmKmkr sckAfNK8EMZ32HwuPzh0foKStlZh8YjpmX0jSOF9fS/4+epjuR8XU/5WGB0lZq1r6CqwqQw1MTon +zgsaIevdesOuXS2OWKaVkID472c0Ly5VUDcOnlZObSMOzfdeDUaaWnlUj6Gk1cNVG12IkkLeRt2 KQXknhOtNXStYxjnuPDGi5X0NP05zFUQMkZhFWWuFx/KK8tN9Htcox7Pvx9p9vZUyzeNr9kTm+i/ AWI82dqvcL5SXJ9cxK70ymxSmu1NtZPnc1/PKS4Bou1elHBiJ92FIhiDwU9/raQkU5MbrFbZEcnT RhsY900Di6KORnlAW3slucbm3CyA7An4QFpjdcbgqw+49iFbQXBQAukdHYgbFJnNzqbse9kc7XNG 6BpBHugMapaZYxfZAZGxBpPpHusiXZcXiTzJCWjayqI0DJS+dWedG8kDcfK5pmT8UxSkbMykMjT7 L7Dol0smz7j1FSkF0RILltB6I+FrBaKmglxDD454IwBoeBuvXiW50jyZsrx8moCryVi0Ra6Olc19 9m+USSgkweupmtfUYZNC4ba/KIF/zZbg+tGIdKunGbMOwOLBKOPEp3N3LAWt/K7qk6LZJz/09jH8 Fw+d09OXMlihaLOI2XulgcabZ8/5cTRFT5NzFjTGz0mGVFWz/bHGXf8AZclRZFzY6QQHLVaC7sIX Lbf4cuhMuTsy4rRYpgcbKcS2he+MEaL/AAuwcYz1krK3Vajyu7DKKeSp9OtrG+l3twvR4EuH2Ylq 65RpjPRvOjzqGWq14P8AT5BXG1PTXNtJMGyZarGi9tPkn/4W+nqdm7LPSfLbMWr8JidA4gAMhBP/ AGXGZGzv066sYWyppqPD/NAuYZYmteD/AGXPba3KJfmK6NE2J9NcwYXE2prsAqaand/W6Mhc1gPQ 3MuZ6EVeB4TLVsAuSGmwW9/HukOTc5YI+irMDpZKeRpaC1gXXnSPot/6PYzVYVFBDUYNO8viOgXa PYpCEJX/AEbescV0aUoumWaHZg/gpw99JXuNgHNtuvrMw+GnqXlPCnV8uFmrpNOoujZuAvdf1EKO k6d5my3mLDaOKkqTKHkxMA8wA7gr0Z4ces+VOtOS6OmdQ0zanyWslge0Ek23UliUUn6ZPl7ujRnF jD6N8kM8Do52u0lrxYg+y5CGRjz53lFrrL3l9RTwc4RlaOoz3lyJtFE+7p6eNtm6vcLX3hc88tJH d997OuvLlxbFuXR7MOoWXhdnNYTQzYviUbI9i51gT+V6Pyv9P7P3UHC48SwmanfE4avLP3LzrgeJ S0FYJIxbQ4Fp/dbafAZ1TGP4BDQ1EJNUYwGm688NyZ3yOlZ4pxT6dfVuhjIkwpsrWjYsO5XR2ffD 7nXp3igix7BKyjjG3mOjIaR8FbwevfUbFOn9BQzYbC+V0sga+zNQCycxZWwnqf07pXZipYak1EbX gmOxBI4X1YwjKKlJcM+M9XOM3FGpPo34BMy9XqFlfRzGhpHi7ZHtvdfT56+lx1Ky5hkuIYXX02Ii Bpc6K+lzh8D3WzXHsaw3w8dG6nF4qMGnoI7thYAL+y899K/qK4DnvHpcHx6GLCzMLxSSmzQD2KsM PL2rgzLWO9vs1q9P+i+L5jz+Mo41BPhOI69AdK2wJvZerav6Tma3YYKmkzDFO5zdTWO2t8LkPFf1 TwWv675WrcqmkkmpnDzZqS1n797LY30pzUc3ZAw2vc0B7oQHAcE2XGTUJfU9LytRtmi3r74a80eG 7G6Ckx+SKZtbux0Zvb8rrxlQ6Jrg43jbwV6q+p7mysxnrfS4dM8+TSR3DL8bryVLLJVsZGwWA7re oxqNSPRpM3lgZz6qMttKSC4bLjqqoZK9sTIxG1v9Xus807JooozczXAXsPwueGPLHVaTycTGpzGX cewXnhHc6PZKWzlni90weWxNkF/cFG2knklDDMXDkElbU8d+lXkfHsPmdh+KSQVDmnQ6M7NcvDPU fws5o6R9QX5froZJ4dX8mXTtI2+1l6Viv+DPE9XBOjsTwmeFjK/Wt8kGLV5hq+G+qy7m6xfSkosA yrW4xgOYnvmponSGF7diAL8rsjwdeEzH8r0tFmKsqXYfHIQ8QE7kfheyupw//p1j7WnVpopAdv8A pK5we2aRxy5vq5I/PrljLzv9Wx4TVnU1tT+nLu3NrrZxkn6bmQM45UpppsQH6yaJr3GMh9iR7LzJ 4fvDTifVfPEpp4niH9a+WWe2zBq5utqvSbo9RdLMPZDDWzV0rYw0umdchddTjjjlwcsOeWSNs05e NXwnN8NWZKOpw+tFRhtQdPln7gfey6LwmUTwSRFo4vcrYN9Xynayoy3J/VI1xI7Fa6KCtdYRtGi/ dcs+NQhGf6d9JneaUo/hyMRZpLeey+u6Z4BS4jj9BT1R/wCGfO3zXHsL7r5TLeGVGKYs2mhYXF7r XWwbwt+BOfNkEGL4480lBs8Ajdw5XCH9nuyS2o76yb4HejWf8pUs5ozVSSQtPmRHTY2WvHxleG2h 8P8An80GBzPlpJTqY1xuQPZbqMl5SwfIuFQYRhQbG2FgaAXXcV5A8RnQ2DrF4ksKwSrcWwTQiZz7 cNHIXv09TbU3xR8XJnlGScTU9FR1MbSJKd+rvZpQt8yOS0sU0Y7EtNit5kHhM6UZLwiGSfLLK2Rl mukc3W5xWPm7wfdM+o+A+XHgrcMa4AhzY9Lh8Lh/rb/o9DzyNGGL0732qP00nltO77EBXh2HuxGY Ghp5Z5iN2sBK3m0vg36XMyRUYRUZYgkYyBzTMfucbH1XHdeR/Br0Vy87xC5kwuehgnwuie/yIpgC XNBtstrDFqUk+hHVXSfs15RwxtrTQz0L6OsdyXsIJC2k/T/6ZZNzR09MuJ4FT1bowGPfUMB1O/dc 94/uhGRMt9KRjuGYBSUGMCoDI6mJgDjfsV9P9PyHDsQ6PzYcxzWV9NODM5ncchZqG1SRrJlbVLs8 cfU/6T5RyDnrBG5WwmDCqiqj1ytp26QT+y8f4RlPHMXANFhtRWOP9UcZcFsw+pV00hxDNmVMbkcT G5pgcwe/vdek/DV0qyp056I4bWnCqaR74PPmlkjaXG+/JXfLGKxQkjjp88vtuXRpOd0pztDrnOXq zQzc3hK4OOgxKqrTTOp3xztOkxFp1X/C3jUHiN6N4/i9VgtTJQ0c8TtBbNE1ocuLwjwx9KM09RBm zCm0Nc1w1Op47Ft7rhtXtUaWrvlGnzD+jGdqmPzqbL1bOx292wk3/suAzRkbNOTpfOxjAayjjI5k iIH+Qv0Ny4Jh2ACmhw/Aqcsta8cbQGBcP1C6b5Zztlivo8cw6j8iSJwMssbbx7c3RSg6tElncWfn bpH00r/N1Eg/0nssqqpGz+VFBcOc4br6jr7kmg6e9Z8dwbCp2T0Ec7vKMZ9JF1x2XqTzappeb6HC y4zxuMqZ78U1lhuR798CHhCwnOIgzHjsIqIobObEdwSveuZc8ZM6bTYbgs8NHCZyIWQBrRp9rrpv 6dGLx4h0pqGuA8yKQNv8L7HrZ0+yljeb8O/i84pqicgh7ndwe3st4IrJLbI+brG8auJ8R4ovBTlv rLQMxzAKWChxkC7jTtAbK099u67L6A9KMG6BdJ4opKWJk9PGX1UxaNRtzuuxoqB1HlCGlweYSGNg bHJ91whzHhgxHItVR1hI8yAiYj8bquW6ov8ATjFOPK/D5XAM05E8QuA4rQ0cUWJ0bCYalr2D0k+y 6QyB4Bst5M6ny45LIKvDoZfNpaZ7dmm9wP2XZnQDK+Ust1tW3KdRG9khP6prD/V8hdwPe845HE1p Eejcjhdsv+mThF8HCG/NBSfZ8HnTrflnp7jNHgtXI6CeUhjWsZs3sAuv/EV4S8t+I7DKLE4I4sPx RpDhVhljIw77rmes9Hk+HqDgtRjzIXTXAbqNt77FdyGCGswanbSyaYNILHNPZYklCEZR7ZuClKcl LpHwOWcu4T4e+k0cNNBG1mHw/wA2Rjd5HAcrE6b9RMC8Q2VMSirKGKopdToJaeeP7h77r7jNuFUu J5TrKetAko44y6QHuALr4TodimTMajqJMraIzC7RNGyw3HusqO6Ln7K5y3KHpmq76hPhfwTo51Co BlqN1PR4rIHeWeGXO4C9b+Hn6f3TTOPSXC63G8L/AFVVU01zNG8XDj3XA/Vsw1rMIy1iTbMla4sa 4c8rzV0W6seIXDME8jJD6rEcPhYGmIMJAsu+THuxxyLtnr07duC9HZuDeDHAsl+LejyfI7z8DkLZ mB43t7LZJm7H8H6I9Pm1FPh+igpGiOOmp22Pwtavh+6hZ2x/xOZbrs/UVTRYzLKWyNmuLjgWC2gd SDhgyfiU+KxCajp4XSOa4X4F1wn/ACimayN7HfZ8N0p6h0vW3L1bT4phjQxxNoJm6m6Dxz3X2ORc nU2QqKXCqFxNK6QyNbwGX7BfG+HfqHlPPmW5J8twshdTuMczWssbhfBeJfxWf/cw47QvrcFqMapM UB0eRe8VvdalCTm4QXB8+E0oxlJ8nxPix6vdc8g9RaegyFgjsQwGSIHzmRa/V3BPZeJPEv138RDY 4pM4082B0E0ehgbBpa8H5XtLp39SDLXUTNWH4U/CWUQnk0SmZ3qZfg2su+PEp01wjqz0Ux6jmoYa x5onz0jni5a4NuCCvRxjShOPJ5Yq8jyqXBrN+mv0syxnDqTWYjmN1FVvc0u8mttpefgFetfHX4YO nb+kVVieFUdBgOKUo1Mmpw1pf8WC1l9JMjZ2zN1KdlXJdTU02NB7mh8LiA03tYrvfq70M8QGR8Ai rc+YtNiOXmvDJJHvLwyy8iw7Mv26PvqW7GpGxbwLZMoMp9AsCdTQMbU1DS+WUNAc78lHU9Zsw0/X 2XLVNhr6jAzZslSWbRn8qeBrFXYp0AwoF3mfp3Pja/3HKRmjrKemnVA5bqMCNTVYk8SRVTGXBafc rtBKWSaSs+ZnbqNujtzNXTfAc411FXYlQxVFTRuD4pHN4K+e67Zox3JuTPNy5QirqHDRbtGOxX3W J+fVYFEKd4gqJQ0j4+F8f1pzDLlPpnU1rYXVVTEwHQG6iT+FyxScpxjLo1kgoQlJdmD0HxvH8zZP D8yUfkzEEOEg+8H8rUV9Rjpjh3T3xEYhJQQCCCvtP5bBZt3c2C299Bs+VHUPIVJiVVROoJL6PLc3 Te3ey1l/Vb/T1vWzDv0zg8Q0oEunezvZeqFPLKLXBiE2trR4fqnyQeuGnLRfkDld6+Hzxe586CVI dhOEwYhSyeny3jdfL4D4eepedcujF8Hy7V1OGBmpsrYz6vwvmsFyfmrE8ehwOOgqYcYMuhlOGnWH A23HZfPcLk0j9CpxpbjY9lLA+unjCwNmYajHHZboGStMUEMmmw2JHyvc3TLJ0+ScrUdBWVMtbWRQ hs00puXu7lascnZm8UPh7wuJraB0OEsDS7zmGzQe5WzLw7dQMW6kdM8KxXHoxHikrLylgs13yF1a lGFej42bDCOW0+TT19Qurgr/ABCYu6OEQvbJZ/ptfdedqapjfTFkI9XdepPqZYQyg8SmIyxtDI5m NcT7m1ivL9FDHGx+kC/F121jUlGvw7f493Atg0tFzb3TdA/urbTtdASTYhAySwsey+XR9ihzW2+b KnjVayOBm+p3BRHQXkAFUUOaA2n39khoc9v7pj3Dy7I4mBse/dBRXlaW3VH0gHlOAAFibq3hpCAQ 433UFr7Iy24QnnlDQDwdVyl6j34TtVgboCWk+yGWCCCbpbwXPTQ0eyA33vshChL5Rs7dKmBkfdjr BG5zC0gndU5oEYIO5WaALCdiTc+ya1rSdRBS2gM3BuiEgvubBUC5phC8SG+3ZW6sbUAEDdC+RkhL SOUny9JJaDZUDL3aR3VxjQ31HlVZxF7KyQWtuLEIA222uhdLofZo/dW4FzULi1rfcoA/usTsrNgb JLHekk8BNY7zhcDZABexG90QYL6juEEjhC7YXKsvJF+EALxaUHsslsgAuNwsNri/Y90bWubZoQGZ qBbcJMzdbh2TQ0OYALXWO91382IQEcL8qE3GyEOuUYNggDY309lHaTHYoO3KF77hAF58ejQ0etZM TNTQSSsaGJu77epZIJDEBUwN78hAXANuDcoRJqcW8gq207QD6t1OC2E1w21clR12m3ZC2JzDcm6Y SDsUohGkRt+UBcbe6NzQW2Qsc1r9JUopQhdKdQk0EcD3WXrsxoO590sR7I9NhuoaLY4EkKXAJF0I dY+yp3dAFdxOkWsjDSBvslxXuicSTyrYFyt1G17JDW6H25WR5JcTc3U0WvuoBbhtcKBxDOLq5Bts hsQ29/2QjFhtyTdHEALnuhfcD2sjhHpcShkQ+z5COSEcbw17hZKDm+YSwb/KsvBeANitgj7lptsk tYYvURcFP2a8h3dDK5x2AvZAXFINJvwpZ1/TwUDvsGrY9ghdI6Ihp/sgGOe77eFA/wAlp3uSjkYH R6+9ljxQgtJJQBPfqjBbz3VF5LPdULAWUcQ0ABCcgFxttz7Ky303J3tdXrsSbX+EJNzfj4QlkaQe 26vcO3GyFhu47Wt7opJPKiLrXCAKNrWuNu6F7LG6xnVzWhtxymslc8XPCAfCRHfV/dA+xeNgQSlO kKkdwd+EAdQwOe0DsieC5jWMFnKjcm9lHOOoaeUAJjMexNiiIGm4+5NfG2UXd9yxXnS6yCwje3sr bI4CxKv7m2VFoACAp95Nx2QxxEOJPJROf5YHuq87+o8oC2klxF0bPWbA8JbWE+rgJsZDdyeVAMdH exCHTpJROlALRvurJ3QEJLhY72S9Oo39k9j9Ava6pxa7cNsqBL3WCgcCd90U0Yc0aUAFrbICg4i4 5BUYCDYlS51fChBDrqAcSAlyWOyuM3PqSnXdLZvCWAgAw27Kg0ayQnPLGRju9LBFt1QC06Xe6pxL nbbKXAJ9lA0k37ICaBcG6vSLGxS3PsbKE2CAp0jtQB4VyWG19ylOu47ItdhvygAJaXhmk6vdR5J9 PsnRP1tJIsQlNs5xKAW6znDShdYA7JzobG4uLpbmk7EIRiS0Ft7oWttwVcg0+lXE290ICXkPF+E1 0jTYNKWSL2I2TII2vdzsgocyM2vdJlve44TgfLcW33KRUMcPtO6ELYBa55VtLZYXvGzmFKN2ht97 ndckIoxGA2243sgMJz9DW6tiQhBsSTunTQtdzvZI2JAAQFF1972Rarj3UdFtYo2saGlAKduLlvwr 0Ai21yrkjkcz0b3S2U8jGkuKAB8OqUNA2RuYQ0N5sm6B5YIO6Hyj9x3QGO4m9iFQD9Q32T5Hx2tw UqF4LtkBkh408WPsgkjLmncbIxu4CyGoaG8mxQCGuLhv2TGtDRzdLBARdggLc0XRA6QqJ35UJBCA IDULBJmndTWa3e/sms9J2S3/AHXQFlnlFsl7l26yapwkhAjFnnkrDe5rgNzymxP1beyhUZVI98LG teAflOBBN0AcREA6w35RAWOxuFk2i+9wrve5JUG91Li1kDLvdTWSqVhXohHBxbYK2N23V7gKX2UB ZaQdihDSCpc25Vh9u6AJsbHNOv8AZJaSH7AhqabAajuUQJeBsAEBbGiQuKW6Es+U6KM8jZG4Oaft uEBiRXa47Jxic5pRSANsbbpdQ9xDQ02VBTo3bC1kLm6E9+pxFnX23QFo5JUAFieEuZxAGlNBsNu6 SXaXFAUA4tDiSCrF73uqLrnjZKfNYntZAZAcdXPZC42JNuUgPNrg3JRh7nt3PCqA3WVCS5Bq49lR NyoBjTbvdQm5sEosNhZWPT3QBlg1XCsC3ygDzfnZXchAFe4t2QnsByqvceytqAIWPKO+3KBu3bZW SAEAVjdE1DcKwUBZ7oCA03RcqWugGtlEo9ItZQvLwQdrJVw0nsSowOsgBIJKstsLpwYQ3flQtvYE IBA34R6Li191JBo2OythGm6AQ6xNu6YG3Z6UDd3H5T2WA2VBjvY4C/CKL1NuTujka7Y9kIA7mygA ALr3QujNud/ZMJIO3CK2/F0AjVYAEK3bAFSUXv2Sg8l3wgG3B7ISSOFWq/wqub/CAjz2tdC0gg7W srvbndGxrSebBACDfgIgSSjjaG6j8bIGEkG6AuwuraTfbspsAoyxJ3QBtJDNuVZJeBfdBEwyag0k omNIfocbFAY73aJSLbK2gOFyqkZaQjke6uD1ki3CAY1w+08IgAzhA22vcKyTqsOEAZ9Q9lY2SiT2 Rgn3QEkI91bW62k3VEAXNrpBe8vuwWagMhrgdjtZBJUBjtLd9kZDZIwW8oSGDYWLhygMKed8/p+2 3sqpqeV8wfKSWBZr443AkbFAJeBdAE4tZe3+UrXf4ULtRIQEgIA9RYVHP2SjMSQLbIJXP1CzfT7o B7BveyPa97JDJNPJ/ZODtXCAXUODTqKuObU0X4SXPvLZ249k7QNWw2QBu0jfsVASW7cIZDpjvsEI ltHceo24CAJsljY8+6vzLmxP7JbJf5Jke22/CxSfNl1tcbjsqgcgHbBXf8LGbMHAAG/urMn+FAOL vZWDYcpAlBV+ZsgHhyYCsYPPuiMlkA8KtVtlj+abIPOBde/CAz4yQbowLuBdwsTzg6xbufZMZKXW BFytItmVLpeBpFkpwbcq3SWFrWSn2cLA7oRMgb5YuDcIrk7hLlktEGkbe6IShkfCcFCIurGwO6X5 gIvflXrs24WSkedLTflB5mw7JT8Qjaf5nPsjE8UkRc7YISyOlFwDygc5jiPUDZU0t8jzWAu/KwY3 CokcAC0hAciHDVyprueVxclS6ncNV7e6yo6hstiHA3VohlkhBewSjIeLqebp2PCUCy65NuFC7tfZ Y8k7Q/kKCYbqAMkXVPe5xAHCFjw4kK3u0t32VoFEkHdEZb8bJD5Wht77pMcskpcGtN1CGfbve6u9 wsGMTtcdQ9PssuMl42HHKtD2R1SIdiEL6kWu0cqTMDhuAlnSHAE7jslFHtnc5oF0fnkWusbUS62k hNtfneyUB4u43KItAt7pQefb906Jt3A3ufZKAY90apwLWlxaRZI/U6u9lDVjwbuR3BN7brDNTp+T 8I2PcLO4afdVAyy0yblHFEG3JKx2T672KPW48brRLGlmp1+yFwHfdJdUvYbFtko1RLrAEu9kKPJs SRwpqv8AP5WKah8ZOthASxVuc4hrSVmgZ1g432BSpiXPvsVjid5vZhVNq2n0Frg47AlQljZXlguN /wAJBqC7+k3QVGqnjN3+o9lj0NTWVkoggjEryeLbqrnojZktqCTYpwduEmtpa6jlZHW0xpi7h1uV QDqclr99uVXFrsymn0ZOsOPwhLxdBCRMbNQ20vcA8XHa6lGh7JA0H5RPkY8Cw3HusMygu9TgCO11 Qq2OfpF7qAzWuAO2+yCR1xcn8BLjmaX2Bslz0zopmue4uYd7BUlhOksg8zdY01SXzWgY59udkMgn EbnyRGMDa5CVYsyzKbohLcrBhZO+PWSNA5IKA1J16Qbj3SinIult3VOlAZqvssH9TpOk73WRG1jb GW+gpRLGfqQGBw4RxVocObrCn1xP0RNvG7hSehkjDXN9JKULOSbIHbgomxi973WDTwStFpDYHgrL ZG6Hk3BUA8tuwlV6WsJ5turvdt77FBAQ6QR2vqNlUUxP1H62cCEeXGB6iVi+aYpC1n8x4O1t1970 j6OY51uzw3LuAsDLPHnSHhjSbX+V70yf9InE9Ilq8bigYW7Fwu537dlI/Z0ccmRY1ZrXkefJ1vB1 eyxDXahYR/utrs/0p34NA6WHEIMQJH2EEf8AcLxl4lvDDWdI8Te00phA7Afd+F6vjyabjyeT5+NS 2yVHnNs1gCOCmCpB7oJcPqnWYyB0YGxuLIamhNLF6ifMPa68+1nu3xfQ81DQLE3QGYb77LEgo6ic +gE/lH/DauJ9zG5w+N1KfQ3ILz7kpcs7rpTw8SfYdlyFPgWI11nxUr3tHsFVFsjml2zjxObk32HZ AJSS4kAk9/Zc1UZPxCCB80lO+INF7FpXozwM+FrAvEjnGow3GMSfSSUrg90Df6mhSScFyZWRPlM8 4U+VMUrqH9RDRzPYBe4YdwsBjnQhzJGua9u1iFu46teFnI3SjI4OHtp6c0tOQPNaBrsFp76hUJxH NNb+ip7h8zg0RN53XtWmk8fkR446teTYz5CGbzGkk78KR1EjJLCxCLEsBrsHLRUQvhLuzxZcjhmW J66DzmRyH5ANl5dsrpo9vki1dmHqe43JsELapkJLXG4PdfQYR09xfMFU6KGMsaNrkL7zBfC7mfFm 2gpjKDw8bBXxyXo4vU449s6akaQ67JvS73ToWODgHOBX2HUHpNivT1/lYhTuY87gEL5CndE+nYAb Sg+q6wzvGamrRkykQQaz9vYrDjqmzusBY/Kp0NRNVfpo2OnL/sY0XJXZOT/DjnfM0AnZl3EIYXcP 8k7rHfBZOkdcSERvFzcHuEipk0P9Ivte67qzP4WM0Zfwr9bU0lRDC3dzpYyLflfBZc6V5lzZin8N wjD6jEXA2JgjJAHyV6HgmlbR5lqcXVnxrppXcbfhUah7RY8/K9M5f8Eee8XpS6TC5aYt3JfGeFwW cvC7jGWovJex1RWA2EMTTr/skcM30jk9bij2zoaOpc2xPCYyfWXO1BtuxK9KdP8AwHdSs4wNqWZb qm0rhcOmZpNvexX02M+AvG8uUUk2K0UlKWAm97ArSwZH0jqtVjatM8jfrZLcAjsmGR7mBzZGgn+k r0dl/wAEPULOLnfwHLVTV0gdb9S7YH8LsrC/po56ghEuKYJLA4C5bq3Vjhk3tfZl6uCVniFpjla4 ySFjx7DYqSRCm8t4eJA7sF7WxfwBZ0iAjw7AXVn/APD03IWZlf6dfUHG5xFUZV/SMGxke6wC6ZNN PHxI5x1sJq0eIK5zSxmlo9QvdZWXstYjm3E6fDcLo31NXK4NaxguSV75xD6cuZctwnzcMbO8ghrG 2dcr0B4J/ARV9M83SZwzbQRMn/8A3ajeL6PY2WHh29mfmJ8RXJ44yb4C8WwrDYsRzWTA+WPWKYC1 hbvddK9ZelNHk+aZ+Hm8bHWLR2W+Lq501bmXB3foIoxK2+oPsAQta3ia6W4Zlb9T+tDGGW/pBFgv t4dFiz6dzxvldo+Lk/yGTHnUZLg12RPcwjcBFJNdp2391m5goY6HF54o3Xh1HSR7Ist5crs2Y/Q4 Ph0Znq6uQRxsbvckr87OO10z9VGSlFSRx92GMBtzKUx1HUykNFO4uPFm3uti3RH6TuM4vRQYhmqu ZA6QBwij20j916Oofpk5XwyjsyobJMBs4i6648Sn2zy5NQodcmleWiqIXaXxOYfYiyMYVVvZqEDy 33stvEv0u8IzBiEstTihpWNNgGC919Pl/wClTlCgkElTjE1RYbR6dl1lp4w7keWOtc+FE0yswKuc zUKaS3vpKB2G1QGgwO1fAW6rGvp1Zewxrya1jcPt6iGbtCxMM+mX0+xItqocUnmjPJbZbjp47d18 HKWvlCWxx5NMkWBVz3DTTvF+5aVk1WVMTp4/NdSv8s/1WW82j+nl09w+k0NgklkA2c6y6xzH9O6D M2ZBSRvbR4Mw3dLpAcfwukNLjkm1NCX+Qca+pp+pss11V9ke/seU6TJWLxML30bxH/ust3OX/p79 IMpiGOsPmYhp3dLIAXfgJ+ZfBBkxj45qKhbPht9T2FwAaO5WcWnxy4bLLXT9I0ZwYBW1E3lx073O /C52n6W5iqy0RUD337gXW8Kk8B3SvGKSGenoGCO27ovdfQweDPp9hlHooIDFI0bOJB3XOWDGpVuL LV5KtI0N4v0tzJg0BmnwyoEI3L9BsvmBFJHL5bmlh7ghbousfTHCsoUM1PLJTOgJIIe0bCy1geIb DMLpMySswkReTqvrjXqzf4948anZnTf5Dyz2SR08wPc8ht3W9kWl5JBKzqPBsSePMpaaWZp2LmsJ ssKoo6imlc2RpY8bkHlfL2yXNH2VOL6YEYaKhonuIwd7crb19PLph0xzn0nirG4JRVlb5miV8zQ6 UOWoAEveL8+62kfSEpqgOx2MyPdTuLZNB+1pCRcV/I8eqUnG4nufMWTOl2WX02HVGDUoqZSGthhZ 6/ybL4vrZ0YpMEy+/FsvR+SIWazTk7Fvwu28d6VUOM5upMc88sqoDdzb/duvmupldBmzN2D5YBqI onOvPIwWaW/7Svt6TJ45pwfHs+BqMW+DcuGasOsxbm0PZBRSS1OosMLISSf7LqWDwz1mKRea/CsR oieXviIb/kLeL/6bZXyu6H+HZTp56jgziBpI+SSvoMQythWJ4W6CroqSJj27scxuy66nUYM8k9jR xwY8+nvbI0Fz+GirnkdFQ/qaubgMZFc/4XLYN4PMw1kYFRhOJQuP9ZgOw/st2+SulGVcpPqq2mw6 llmLi7zw0O//ACL4bNnipyZkzGJqPF6Ty6Zl2umbGCAvG9PGc2sMbSPV8vLBXKXZqPzF4OMRytQx VL6uV0kn2wPj9RXE4P4M88ZknElLhFUad39ZiK2o0vVTpv1Y6h4XS4NDHXQvsXv0AtY72svROJUe J4ZFTxYJFhsFKBvHMNJ/bayuXBCFKqZrHrMkndmm7Bvp54/S036vF43wx/7XNsV8fi/hvfkbNuF1 dPSPrIqadj5IWguD7HhbwsamwqmwB82aH0McQbdzrgCy199b+tOWsPz0ynyrSQVEUM2t7nD0kA7r vgwY8kZWuvZznqcqaW7s9DZIzxQUXTaF+HYHJPiBgDm4f5OzbBeQeo9TnDqlmybCcu4NNh9ZUEiR ouA0lbD8k5goca6UUeZIMOgpppKK4dG0AD0rorw0VDsc6zY3UzNbK0FxBI43X0tFOEcU5NdI82o3 uS5PAGbfBxnfL+ImTNNM6WWQ/wAv+rWm4P4B875qi/UxYDLSU1tTXPFtQ91s38VmYxl7CYXMpGTS l2pkjwCWntZfbdJsarq3pBQVte01NU+KxEbLG3wvLmxxlijmcezpizzjJwjLo1f5U+mrnHHqhrTQ x/pwbOdddr4B9L2WmmDqvD2lreXatlsny6yClyuZIy+iY4FxfLyw+5uviKXqNl3KE9ZVYxnylrYQ TaFz23b8WG6+avs2ox6PdPK4pOUuzwVmvwX4FlNzqarwmI+nZ4YP+683dVfCpQ4fSVWJ4Q80ToGl 5a93pcLdlsD68+MLIlZQ1FNgjP4jWlpb5zW7BeEut3VDE8y5SljpIXRRm+qTjZfayYIS06lKNM+d DVZI5qjK0eN6qF0E8jXn1BxBI7r1j0C8CNV1fybh2YavMFNhMVbJpiinNtQuvN2UMsVmec34dgtL GZaiqmDLN35PK3eeHjww4B036a4TU5sqP1UNIxskUReQyFwF/wC6/H5NybUD9bvpLcdAYf8ATdrM r4bLKTQ4hRwx3L4QC8rrqHweVedcQfhuC4INZcWundHZrd+braL09xnL2OYZXVWAebJTAljxISWk j2uvlunmZ2YtmjFKeCiiooYZC30NALzflfc0c14ZKcE2kfD1c6ktsjxxln6TGEspYpcfx8RVThdz IOAfbdctm/wFUHS/AZazBaeXHIYm+thPrt7rsbxg5txvCMVonUddVUTY9o/IcQ1xXmN/iH6o4hW0 2E4djNSGzztY9kzC7U2+4uvpYdJNQWa1T9HyJaz7beTsbIX04aLqHSjG8y1X8Io5hrjpoWjVb5X3 WH/TpyVS08rsvZjfPNGdL4yGloPyQV3/AJwjxWm6Dwx0c7qfETSMMkjTa23qXgXNmdM65IxxkGVs wVDKuZo8xrQXB7/2XLHp5azdO6p/h3y6iWJJHa7/AAU4zi+ZqTBp444MHaby1BaCSPcL7aj8AvSf LOKwxYlij31jvUI3kNuuY8I+PdXMy1/6nPbXR0jW2jLgQXjsSCvpeuPibwLpbniLDajKMmOVFrsq IW3cHe3BXky45xyeOCt/0dMVOG9ujiMx+DDp5hOESVsjZI8PjAu9nYe64/A/A5kDHKNlVR180tM8 XsDtZfD9VvFjnPNuBPw+gydWYNQTM9U0rTu3sF3f4czXUXQ2Ssq5HulkjcQXixHx/ldp4Zxw3kqz l5IyyJR6OLwjwg9JWskpMOpmT1zRZ7y/U664eh6J9NOlucIDidTFDVOcDFG7Sub8NdHV1Gbcfq3v e6nMhtqJte/ZfGeJ3AKaXqdg1TK8vfK4Na0ndXFifkeGL9CWR7d7Xs9R1tZgsOWPOc5jsM8u4I4L V5B6x9QMmtwuqZgkt63Xp0Hsu/cf86DphDhtNTl88kQY0NPG2y8f5k8OGdGz1GJ18LG0rnFzdPsv q/4qEMUnulTPna7dkSaR5V6zdQ/08EkAcHyu3d8LyfjU7sTxPVfUXusLfK9zdTOjVLJE51ZTFt22 ke08LyBnXAMGwnNlLRYJLLOWyBsnm/7r9l8r/L2220fY/wANGEYt+zZh4CvB1kukyRTZvxyijxfE XgPaZ23a34AXtGHJWVGxNEWUaYxgek+QP/hdbeEcHCOjeDQOc1pNOHFl+9lweZvEP1HwjH66jost umpYZC2ORsezh7r5OgwyyY3Jcnt1M2pcmo4E2sVizts63ZZYGr7uVjVDblfnE+T9k0cdUjTY35Ui dZvN7qVw4BKoM8uDV2svSji0R742tJdsuMbK81LrD0e6KoeJRqBuLoWPJeGN4HdaIcpSSuLSOLe6 Y5zi4DhIpWPba52KcfQdtyowN2b3JKawEi4WK6UAXIT6WsDy2w2CyBkrSxl3b7LjruDjbhcjWzB5 9J/ZYEosNQ3QC5TYBYckbZJDf7Qstx1AW5WPBTmpqTG/0A9yiKekfB7ids5Rta27GhbeOmVZ+vy1 pa2zntt+NlpM6AZwhyLm5kkrwIg8XJ9luK8Pme8LzRleKbD545XFgBa07jZfQ0y2s+NrL2mr/wAW eI4g3xM1tL+olkdDIQLu+1e/PBR1JxLEcrU+BVTHzmns3U7ewXnbxh+G3F6Hq8M70NOcQo8QeBKG j/llevfCblKnynk59bNB5c0jPNe4jgW4X080m3Xo+dp8cXjt9nc+eaibB8p4vW0UXmVcdM90YaNy 4DZay+nWZKvHOtuHVuNB36n9bd+u92nUtgmWevOW895qrctUUzZquC7ZGE2/Oy899Y/DnXYL1MpM y4Ew/oKmoaZY4m3LTfstYrjFwl2zhkS8ia6PU+fMNy5ieWh/qJsL8PawHXLwNl4F6uVeGZQz5F/o 6teKaZ40iB1gbn4Xs3rTkjEM7dHX4LRa3Vz4Ggb6XXsumOi/g2/hdNFX5qldJUxC7Ir6rflb0844 4NtnPNG58I76wHNr8qdIKDGKyN85hpw+Rttz7rkumvVDB+qOEmrobRTN2fC8jU1Y+MYPDL05xTCy R5cdO9rA7bYDZeTvBhictX1gzBSvkc1tKHN8vVtsfZeZwjJSfs7qdNJ9HCfVYpHTYflN3q0tkcRY L5bwD1bKTNNMA4M8y3pPC7b+phh0WI9PcHmjaJKls9mg82KR4Oug/wDB8rYfmKq1efIBoDCDba6S bcIo1jVykqPv/qDxOm8OWYGsaHPDA4EDhaRcJhLo3E7NB7Lbn9QXxCZfyt09q8tzTMnxGriMbaZr vVxyQtSeFNc2hId6XSuJt7KZvrhjE7aCLWaTfRyLJdU0TYgQ0ncrY/4EsRGE12GPa4ESHQdlrqwW mM89LTEBrS8Xc4rZv4NMgh1NhU9PI17Y3BzyHD3Xzk3wj7s19XR6t8Q/VnC+j2RDj+JYX/FQHgNg 0gk/3XlnC/Ho7qnmHDcCwrB3Ybrna0tuDZvyvU3iP6c0HU7ptiGDVkscRdEXROebEEDay0s5dzVN 0P6r1EUkoqDQVRAkvqBAK+rj2Rx7n2fm5RlPLt9G6frfgLcx9Dceo52hwdhxeL77ht1osjyLjeb8 XqosOpKuqkhmdH/KabtAPwt1PQjr/lbr1kFlPJiFM2qdCI6inleGkgiyy+nXhsyl0vxfFMXoo4Jh WOMlnAaWX5Vx5FGLi2YnB4st1aNM2Wsu41k7NdDBjFDW0zw8WfVgi9z2JW6rwwSibpZhrQSQ2MbF eMvHLm/KuZer+Vcu4bPROmie1sslOGjSb8Ehe5+huE0WA5Bw+CGqhmc6IOux4Oy8k4tS3M90p+WN JGqD6neFmn69VOIGwa9gaPYkbLym+dsFHHIxuouAv8LZ19T7ptlnGMgyY/FiML8fp5btia4XcO61 gYXSufhsc0h9O211vUS3RSH+N3JO/wBPocs4XNiWKUbLbyvAC29eDnoHS4Fk+DE3zHzqhgdKG3G1 uFqOwHHRhGJU8+x8k6gFtH8HvjOydXZZgwfGsQjw+ojAZ6zsvOm01R9XUcqj0zljqBlalzhNlfDz I3Em/cHXIK658SeDYdUdUcgS1sLXRGctkeWX7i1yvqWYz0ujzR/qqnzFhcVXa7nOmbYj+6+V61dV Ol+b8JhfNmqkZXYfIJ4HRSglxHZe6HE1JH5uVtONcnZXWvMtZkbpjU4jhQaySHSGtbt6fhTBsTnz z0ZfITeoqaB2r8lpuF8nhXWrpp1ayTDQ12PUUbS0NfBNM0OuO/KZRddekuQsOOBszZh8LGtLTpmB sFFxGq5skk99XxRwfg0wCHBcj41URRNjmdVSMNhY3BTOlmccx13WzMGD4jJMaeK72sfwBfZfCZE8 UvTfp9nLEsJp8fhqsJqpXSsljcCA47r7rEPEv0UwbMAxmTM9HT4lMwNLmP3cPY2XWabnJvmzO5qK S4o80/Vvy7VYhgWX8XZE51PSl0ZeOxO61m0Lm1Igltp0iy2+eKHrr0i6tdG8ZoBmWiq5WsLoYQ4a i62xWoI6KSWrhgGqMuJi09xfZcNRJbIxfo9n+O3Rm0/Z2v0YfTnOlJEQ0gSB353C3ldLHsk6aYe+ laA404DWjsbL8/mUcVmwOaGub/Lnhdff8rZL4YfqL5RwDL1PgOdZ3UT2ANjnaLtv8rw9M+7ni5Qt Honoli2NYp1czHT41K//AIVx8pjr7i/ZYfUHEarDfE9l6qZTyfp5IvJLtOxXGYn44+huBVMuMUmM Qz1sjfW6BvqI+V1f1E+on0fzDTxVlGKh+NUbw6CQstay+hGac7rtUfn/AByjGn+no3xU9TMw9MMj 02I5bojXVglGtum9m+66Nyf4iOvPUjDKqbCcn08cMQsZ5W6Qfcj3T8F+pJ0qzFgEbcwyRtOm0jHN 1gn8ELCxj6m3SDA8GnpMEZL5nluETI4gxt7bcJjnGC2uNs45N88vdI9O9HMfq805FiZiUrTiwBZV Mad2O/C855Q6HZjyN4k5cUog6PCHyukc9o+7Ud7/AN14v6dePzM2Sep+JZijc6pwGplu+gLti2/Z epI/q2dNpcNfLJhFZDiYYbN0At1dhddFPY5beUxLBkcE/aOzPqGY7hrOlcOF11QyOaZ4khjJ9TnD 2C+D+mdTVTcLxys9Toah9iOwt7LX7138UON+IPPQxmuc+Ggp5D+nptRs1n4Xp7wufUM6edFMqjBc RwqopifU+SNt9RXCfGNRR6cOPJOe+XR6M+o3gNZiWUcu1VNETBS1d5pQOAbf/C9CdIv0WOdGcDhG mamdQNY8N3B9NivCvW36pGRs4ZcrMGw/Ls+JU1VGWgz2AaexXUfh9+pPXdI2VGE4zTPqsEe7VDHb UYh7fhVyfiUfw3sluddHPY74L859R+t2Y4sPw80eCOqneTWlzmem/K9aeGHwsZl6CZkaKzMTq7DZ Bcskk1b+wuujK/6w+X6UEUGUpZrcvc7SCug+ov1L8951zbDiuFwMwqggIdHSxuJAI9yuss0p8dHj x4ZY1VWzYt4uIeqk9PQydNal0EzDaUAWFvddOnox4i865AqGY/nKKjZLFqdTRu9bvi66Yy79YLGM PoI48Zysyuma3SXxm1/lcJ1P+rbimbMvTYfgOX3YTUzMLTLr3BWo5tkFBJcezGTT5J5HPmn6PH/X HJuL5Gz7U0eKziqrInkGQG5PyVxWXZJ2aZnAgHge6x6zMWK50x+qxfGZn1NTMS4uebp1NiJp3uDm EtbwF5ck907P0OlxvHjSNlP05/EFljLcEmWMUrG0dZUyenzDYE9l65669EZOr0uFV1BiDqaSlkEn mRP+5vsForo8fqqWrjxGgJiqoCHNc02Nx+F6Myj9SPqjkrCoaGlZ54jbpvUDWLfuumKLu4umebV4 3JcqzbPmvqBl3oJkOGbGq5tOyKIMibK71yvA4C4fox18wHxCZVxEYbKyOqYHwyRBwLgDsCtNHXLx XZ98RElG3MMzIaekN44oQWj8r57pt1kzj0dxB+IZXxmShqJP+YzVs78hblDGlz/I8mOGaSpLg3Yd E+ho6S4xi+IGuknbWPc8iTYN3uvmsS8a+S8D6x/6IndrdqEbq5rgY2PPYlaxsyfUW6y5ky9UYPVY myBk7dDp4GgPA+CF0PNmHGKipOIPrJn1b3a3SOddxde97qOp3LJyI4ZwaS4N9HUroRgHWCtoMXnr JBJFZ8bonelw7LA6wdXsueHbp2GYjiDTUNj8ungLx5jyB7LUplTx79ZMj4JFhNNiDZKSNmhkku7g O266lz/1gzb1SxM4jmLFZq2rLrt8x12s/AVj0lKVxRJ4ZNvYuWbs+gXiByp4h8gyQ4fUinq3MMNT S1BAfuLEj3C+k6XdHME6JHF62lmayGpc6V7nO2aOTytE2Vup2asg1rK7BMTfTz2/9txb/wBl9dmD xedZMbw6SkqM01QpHt0uYHncLk2m3tfDKtPlVWuUd7/UW8TmC9Ys30mAYO8yUeDT6Xy6tnm+69Te DTxLdIcq9L6LDKrGaPC8SAHntnsNRt7rT6WT1FS+sqXmeomdqcT3J5KXUYO3zA8TOaTuQ1xBWMmV ygoL0e7Dp3BOV8s2N+MzxM5apevmTMfyfWUeJHC7PllpbaSL8Gy9y9GOveUPEfkWOSOaB0ssWiro XP3BtuLey0AQQillaWOc7f1ajchfS5fz3mfJNZ+oy1jtRhMo3vDIWglZVtKyzwPazf3hmWsldDsE xKsoBTYNROaZpWl4aCebi68zZC67ZA8THU6so8f8moGHPdFT08hGhwvzvytVGbeuHUTPLW02P5lr 66If0mY6T+y+fwjEsTwKtbX4XikmH1zdxLC4gle3FJRtvt+z5j0spOkqRvIf4Rej9XmSDMGH0tJQ 1cTw+0b2hpP4X0/XnrTlLo90zrpcTxemhIpXQ08DJAXPOmwAF1otrus/UfEQI5s04iWNFrsnc3Zf LY1mLMWOxCLEcVqsSa03a2adz7f3K4OclJOTujb0kmqSo9DeFrxPZb6P9csUzbmSmkqKKrqHPaIh 62gm4K9ode/qQdIOonSrE8Epn1FRU1UdhBIzYHtutS1PhsMTSKyNzZHbt7hJmoaXUCwXbdYyZVkn uZ9WOKoKJsL8E3jki6a4w3AMblazK1fL/KN/+QfdbKKvOXTnNVPS4xPimFzaG64ql0rdTRzzyvzw xiN1I0RvLA3sOVnU+J4zS0/lw45WRwf/AE/OcB/3Vi1KV9Hmzae1RtM8Z3j+o8rto8B6fV8dViFN K1zqprrt27XXY/Qbx35A6r5PpqLO1XBh+MtYGVEcw/lvdbkLTNTUwqJnPklfUSHcuJusjyGGQmOe SB/wSCur2VVUcYaWcvs2bzs/eLTpT0oyFX1+F4/QVUkMZdBQ00gLnOtsLdgtOvUnrdU9YOqkuZMZ JFDJNqMZ3AF11e6m82o1T1Uko4s5xN1lGGAtLA3TGfdRZIxi1H2bhpW5XI3beG/xNdI6Hpbg9BBm egof08AEkU5awtNt141zr4mOnmU/F7NmXDxTVWASzaaiqhaLA3+5q17zxtjmfFG+RsffQ+w/sjbh zImNeSZGuPLjdebG1B8nolglM320fi26IdSsvPpanNVAKaZoa+CpcASFiZl8Z3RTpNgEVLS5jo54 4I7Q0tAQ429tuForiwGNjxLrc1ruNLyEdRhkUZJD3OHcPK2oo888Mm6O1/Fd14HiD6qz4zSU/wCn oGuLYi4bkX5K60bCadgZyTusalbTQNtpB+brNnfZzHWuDws5puTo9uDCsUaRQBtb/CgYAdxZHwLj lFbVbUvKeoJpBbdCIxe4KLSOx2UDQDYf3Q0DqaNk9jgSB/SqEcek6juiZGHDY7KE7Knfof6eFTne kJkga2PSd0ktGjYJQosG4soRobf3UaOEZIHKFEhvq3UewkXtwjLhfZU999uyEYjzLjndLkO2/KNz Gg8lEGNduRdCUJbELX7qWF90qTW150lXGSTuqQba24SpG2NydimDYWuhmGpnygFGMGW44WQ22myR Hs0k8qw8ntZANAF/ZC86e11YBLTcq2gtaSUBRGre4/CU6IbnumbO4RNGoGyAUxnp3Gyaw2Aa0WRw Nu7cbBMmmjjkaGj8oBPkhzgXcfKp0Ni49kc0trHsj9BhNvuQGCB69uFmMaewSIGAOJKyWuBPsgES us8aTxylyC77junSxgHZLsboCg259ldrbq/2VgXUoAu43sluc1rh2CcAA7fdIrIvMDS0bg3sgORp 4WvZdSobpjtdYEGKBvodsQhqsSaxzWuNr9ip2BsY8tuq10xlObiS9jygEuqPU0XaoZy9obxZKBkE 77ndC64HyhZ6wB3CqbVGy/ZOQWHX2PZWCGuva6uNpfFqsP7oRrG7f8pyDIY/UeNkTnXBFkhkm/q5 UMmk7G6hQzsUbCRueUAlBbxurDrtQ0XrLblRr9QJJVEAtt7pboywcgIB+og7Kw4HlKuSBZE0b+6A NzdQsgdFq25CsPIKpzwEAM0RcbX4CGJpANkwE2JB3QNdYexQCmRhzzfZX5LYjqsDZGRpJtuUIaSt WQXK107i7gBW1wY0kndMYwt43CAxF7uNlTJJItTIn7c3IWJXu11jSOD2WVpLRZJkpw4az9wQWPlP 8kAdljNaQyxO6tjnEXvsrLLuDt0JYLhpCW7cq3klxARRd22vZSwyw2w45VOAtsEYcHbdkLnNB2VI JJ3tZW5geyxP7IzYi/dUNyhoW6mZYC3CgiLRZMcbodVuUFARfzDYiyMDTcHhQgDdql9t0Ml8AhFC 4A7oVYCFoqc6RqvshZG2Rmu9yqcQLh24WK0OjkOl12lSyUZjbFU4HT+FGN0i9t1HAgFAB91ro/0b pBa9gUmSJz4yWOIcs3LeC4rmOrNPRMdNMzm3ZG6KlZjgeWfKLruQStDRqJsLr6qfpFnR0jpI8MdN p3NvZfOVVBMJ30lSww1EZ9cZ5BWVOL4RXFx5aBjm1lgI/eyy3xabG/KVHM2J3k6AQOHJrnFzrErX Jko8qt/dE5t+6g2NkstAEg8KuOya2ME8WQTMIJI7dlRQnVqJAG6rSRzsjMgDdQG6ESCRh90IU1wA N0DXAEm6ouAahbvyEA02It3QuFrKNBG6uQhoDnc/CAW55bIAeCqMhjfa+yCYkygjcIXOLnerdAH9 xv3V6rBAHWUNyEAfNlXO9liTVMkMga1hdf2TpmvpomySH1O7BAMbcSG2w91UZ3cRYpDZL8nZW6Rs TdTOEBkPJd+FTm2G3KCFxniMjOByqjk1X+EAL2Anf7kDRpKfpFr3Qmx9kABaHHdA2FzX3aUZuSmN u0X7IBDYn6y5xueyx5XTB5DgQFyBfexA4RzU76mD023/ALoDjoXg7F1wuRjfpb6d1jQ4Y6nGpyyG DgKEorcOPcFD5dnAgLINgzhUIS8XBsqWjFc+7rcIoi0kgp36IH5KP9GA0DhBtL8qzfT3WPNTF453 G6zWtDQB7BUYLnUNz7INpgNjDRzf3SxIQ4jsuQfTOsCBsUqSmAcD27oNoqGmjkcXOG6VJQht9PJ3 WdGxu4Z3VaTELO3uhKMR7BBDq7rGnp5a2EPjfpI91yDmB4s4bJLrR+kD0oSjAZR1bd3AOA9lkeUd I2sU8Oc3ud+yU6W99rIKKLLj5SrnXpITo77Jvltdv3UKkY9iEmWS+1uFlPp3AE32SW0Di/Ve4QoB hBjDrrIhiaNJBTadjG3Y/n5TS1mrsLKgEgn09ijHpAHCgcA619lTyPdYBYJ8z4RH52UY3XurOxAK ApvdE0XKvS3srDgD6UBRNnWUKokF17qaxfndAWR6VGRk7nhTXblEJNtkAQj1c7BMY0Fukbj3QtII se6OOzbBAMih0ix3Ue8gEgbhVqe2T0nZR7zbsqgILjIB2KlvdKMg1EXVmUW2KoG33UDQ9p+EgS/u jbKSq0QPyxb0rGljkF9r3TTLp4UdUA2BIUYMdxLdvdJkA4TpZWuKxZZbOOyiFht9I+UQsd+6xHzh xtexRMns21wjKZh5RtA491iNm+QnMlDCLpQMtsJ1WJ2KVPGGnkI2VALCeUp7w877D5SgCAQPhFul GcMIHZXdzrm+ygGagVC4DYJFnbmxQ+ZY2JQGWx3ymXCxGP7d03W4W22QDiVLg90rXdUHgrQHD0lE 1wJWM5+nkhB+oNtv7qUDMs1zrkrJY5trE7LDgaHsLnGytnlWP8zcdiUpgyXuBNrqtQH3JboSxnm6 rs+FiTT+b6WG1+6AznlrhwsV79IN9kdP5rI9/UQk1M+tzWAC55Rr8JZA8WBCY2Xe4WO6VsdmG7j8 IYq5jX6HDSflWqBn31DcoXt290XDARwUuQuaNZ2alFLBI2tZVqLSUmOo87dpuo55sb8KUBs0ZeNi kNZpvdTztlDLqFkARHsUJFkt1+xsgfMGbXuVANde/wAK9Nu6x3VFnaSbflUZxfnhAZgd2UsW7+6x Wz72umtfYc3QDywuAI3+ELTocdQI24Q636Nja26p9QNi4XJQBMnfEwuZ3QvD3nzC611QqYwbH0n2 KN7b6XX2G9kAEbiBuefdExwafYlYt5Zqn0i7U18L2Eku47IQyWuabDZEXAGw4WEHAnY2IVmQtsSd kKjNFiqIAN+yx2T3Is5W+Uj7mmyFZkNOq4VEaBb391jsrBcNAIKVWyy6wB6f+oqkMmOXRKW3SpHx tkd/MAcd7JMD2TSaWl0knu1ZjcDNS3zHRFpH9TmkKqLMOSj2KjZO6MuY0FvykS1DWEhx0uHZZTKK qeCxjy4D/wCnus2PLdRVBjBRTOldw4xlb2Ppk3xq0zgX1zRbb90YlaW6tQt+VzdZk+qp4TDPTvid /wBTSCuNhybWtjdI5sgiHLiw2/unjZl5I+2Y9pJGao3NcEH6uWJlnNv8LIwnA8Rqql4w2hqKxg+7 yWF1lmVGA1zdTn0s0UjXW8uWPS4H8J42PJFezh/1rZXaXRvYT3ssmH0u3dYfK+9wLornnHqSOop8 uVroJBdkpgIaf3svmc55Hx7ImK/ocbo3U07hcNcLbJ45E8sbqzg7g1T3XBHZZMMzi1xIBt7Lj3h0 cm/oafdZmH0GovMb3Sm19N73XOmdbCf/AMSwaVUFM9pNzsFVHVyPqnReX5enYtIWXLd1PKW8t5Hd Q0IqJoxCXFwfbloWM3E3NADKbU0jkjdJpahrXhzIruPY916J6NeC/qP1uwxuKYTg0jKB32yPGkH8 XWox3OjnKaj2efpWeYzzYxoPdqxm1MpeGiO47r1D1Z8EOd+j+X/4viOGvNO12mRzGkhvyuoskdK8 e6iZihwjAaCStqZXaQIW6rfld3iaVnJZ4HwDXvDjeMg/hD+r0k349l7ff9LPqZFg3618sTKox6xS X9VvleUM/dN8W6f45VYTi9FJSV1O4tfHI0g39xdRYm+jPyIWfFvxEB2m2lHDVOm2jIJ9iV9P0t6O 5j6xZwo8Cy/Qy1tTUPDCWNJDAe5PZet+pf0ts29Menk+ZJMRgnNNGJKiJh3aLbrmoW6NyyxjyeJH VD2v0uFrclSKknqruiAPwTZd0+HXwnZt8QuZ3UGERllLG4iSrkB8tlj3K9oz/SIr8OwV7m5gbVV3 l6gGbN1W43XRYrdPgw9RGty5NYTxUQO8t/8AJf7+6zI455GhrXBw9wV3/g3g8zVmfrH/AKCjgf8A r45NE08jCGRC/wD8L3Hl36ReT6XB4WZgzLUitt6nwENaT7brrLDslUmc/kxatGqB1PUWFnEf5SZ5 JqN2ouDm8raX1E+k7h+F4BV12VMwPqZ4o3ObSzMvr24BC8idC/DAzqB4hKXJOYZRh1JGS2Z8ptdw /pH5R4U1aZmGqt00edWVDcQjHlkh3e44WTEz0+S4gv8A9y2jdcvpbYVhmVJq/I8plr6Zpeadw/5g A4HytaOfcp4hk7E5qDEqKagrIHWfFK0tckdPvg5R9F+XFZNjPno4nRyuYTexTiDsOwUEw/RskIs7 i5UbJqbuL3Xko9ydiKqip3nWDqkPLVh17HwTRRg6QRexXKReXBd7gD+Vx+PEVb4JeCTp27LJoKlq 5Kg+SyM6WnlouFzUWVayrcHU4a19vtPJWxn6afQPpdn7LFeMZpIMZxmL1OZNbg9wF7WxLwp9GcGg MtRligo3dp3+kj8JB75bTlkn41bNCE2XaxrHx1lIY29nOC+eZSilrDFI0hnYrdz168EvT3OHTbFM QwJpoaqlgdLFNE4FpLRe3C1CY7kSvFa+KOnkfJHI5mzDuBffZfS+Nvjuh6PnQ1acqkfCShjCRdw9 kh7TI4tbJuO3cr6jE8mYxFHqmwqsYOA8wm3+QuJjytiAq44mU0rql/2sawlx/YLjLTzS6PZ58f6c b/DHuiMrX8bkLCbO8kjddoYb0VzbiLg6LAcTJt6gYHBv+QsDMHT+vys4xYvhr6B5NmmRhFyseGa7 RpZoPpnxMMjBGHE2cDurnxCJ9hp1BdkZW6A5yzTEKnD8uV9VTO+1zITZ34X1VZ4SeotDROqX5GxC SFo1OcITdo9ys+KX4R5oL2dAyyNfKS37ewXbfTPwxdROpWFjF8IwSpdhZBLaksOl/wCF8b/oWrbm GPDnU8kMpmax0T2m7d99l+gbwt4dguB9D8s4ZSwMZ+koWulYY7HVa5PCx/CW2SDy2rizQJnXI2N5 DxV+HYtSSUlVwBICL/3XzLaaama8uks4b2C9meNR1X1k64YjS4Nhz3yUtWaaKOmjJc7ddb558IvU zptloYzjeV5f4fLH5glAvob/ANVuF7JYJ0nXZyx6iNO2dAxOkdEXtAc48ArFfJJUSt8weW9vYL0N 0Q8H+f8ArBST4nguHk0Ue5dJsPwF9LT+BLqtjWPPoKfLet0b9L5LWA/dco4W+zc9RGCs8rOkmqni NrDfsbI30c9LYvdqd2AK964f9LfqPPC3zW09K5wuRr4PsurOs/gpzZ0gpH1WKUzpKdo3lb6h/hdo 6Wcv4nD5uNdnmuWllp4WSE6tQ4R0Y82ojcXaWAbpNe6rgkdHEdTG7EqOrI6SiBtrkPb2K8ko7eD3 xkpq0Mxj9QX/AMmQCH2SqXCqmdl4m+YbXNl6U8JHg1xjxHfr8QFdHSU0DeJOGn5K9Tj6VmIYXhZl p8YirK+xLdNtH4Vx43Pm+Dz5NTHG6ZrEZCYmuY5zWzexSfNmefV6gOzV6VxnwfZpxnq/Dk+LDzBi Ej9BLhZo35XsrJ/0iMGhwaF2OZgkbiNrubA30j8ldZ4HjlUmcVrIyVxRqmpzUMa55gf5fvpNgoyt e0lrgQTxZbVM8fSlNJhMsuXMdFRK0XEEzdnD2/K+V6AfS8p8yvxGfO9VUUTqeUsjia22v5/C2sUd u5Mx8qS4o1vhrwBJI1xaOfSnAQj+cxlluId9MXp5TTthgxJ8kobcQvsC4fhdI5n+mtO7qtRYRROd BgtSC8zBtw0Dndc9sbMvWuHaNddJhlRi++ktb+Eb8Kr8MkcYo4pWkWLSdwtyWBfTW6a5WoIziVZN UOsA9ziGj9lkZr+m50xxvCXOwmOenqA2/mF9wQihF9sr1c1wkaWJKOd5Lg8MeeW8gJbKatqCIoIW ySDut03Tn6dPRpuGPa+F2LyXLZXNl4d3Hwubb4EOhYxaXBYcOfDiYZr0sm9TR78KrHC+zfypOKdG jiqwDEKqsp6dsTn1szhGImi+5W1jwjfTYwGDp5SZizkx38Wr4fMZD/8ASBGxIXZFP4Ouk3QrqNQ5 ixV3m0Lj/LbVgaWyDjdex8NraPEsKp5sPljkonNHlmK2nTbZJY9jUl0zEtR5E4+zRx4z+keD5Qzf UUuXJ5qunp3mOfUzaJw/8Ly8YJ5pBCdwzYn3W5Pxx5l6X4NhtfhVRBSvzNJHrdHCxoPB3dbutR+I MhMtS6JunW86QPZfR1GFTwrIeDRZ5rI8cz5CXz49bohYMPISqGjkri7yw6Sod2asjy301RUXeS0t 4PutmX01PBnlfO2UmZ4zHCK5znny6Z+4FuCV8SVRlR+gk6Rr6wnozmLGKQVDMOqzq4DYSVdd0ezN gsZfUYNVMHZzoiF+h+oyXguEQ0tNhmWKKSEWadMTQGj+y4XqP05yqMs1mJYhhFM1lHGZjpjFtvde zHDHwmfJy6jJb2ro/PvQdMcw11iMOqGg8fySV9HSdAc6iAVIwDEKqHs5kLrBb5OlmE5KzTlWmxLD 8Cw7RK3SS2Bp4/ZfVxvyuJXYbG/D2St2NNZgI/ZbqEJOLix5ZzimmfnhHS7Mc9eKZuEVNM8nSSYT t/hfXYd4Ws6Y45sMeGV9c0i94oHWH+FuezJV5Yy91bwTA2YNh1fPioJOmNpdEB3su1sdxHCMi4PL iEkEFLBFsdLA3/sFrNCEWtq7M4885Jt8UaBs4+FLMmRcMNXilLVUkBF9LmLjMkeFXqFn4CXBcqYj W0pNvPbEQ23ut/GL4DlXqTg8L6qDD8Qp5Gh+l2l3KxczVlF0t6fVdThNHBTw0cZLImMs3/CkVCSS S5Oc8+WF3Lg0wxfTk6rR0RrJMBkggtf17lfIN8F/UifE3U1Nl6rrNBs50UZIC3CdA/EHVdWcTqsO raSOKSM+nRwQvq8azHJl/rJhOC0Zhp6KrhL52CMAud23XaeDZLbJc9nmhqZ5Fvi+DUXgf08eqWMO aI8uS0xG5/UGyLOngYztkvDpJsTwtwLRcujFwFub6mdQsP6d5d/ila5rIy8NuSALdyuss5eIDpXj +Tao1OaqDUYS7ynyDUXe1lcGOM2m4cf0M2bJB0pqzQpnHB6nL1W+hq4nwvYbAkWXDQVTCwN1k291 3d1+xOHqF1BnjwOkNUXTGOLyW3Lt/YLncu+BzPWNYSa2vw1+Gxlmtuptjb5XHVYFDJtxn1tNn3Yk 8h0FC9r2+lweB2CW2qNG4zhurSdguVzXlCs6fZnmwt4Mk0Ti1xI2So3RRyvDm69O5C8Tg4Pk98ZK atM+x8P/AFQxzph1GocUwdpFTPOxpYDa4uv0IZQxCvx3IGHVtQA2tnpGyEDs4tuvzp9N3DEepOB6 GWH6lht/+EF+jDJtdHQ9OcJqmjUxlFGbe/pC8cN0c1I5ZkpI+e6Y4vj+J0mJDHoHU8kM7mx6jyzs vM/iM6H1Hio6nQ4RRVX6DDaGIiasa3UC72XqPLefqXqZQYvS4dE+kqYQ6Jz3jvxdF0xyS7KGHzU8 9pKmR7nPltu7f3X3YZPHuk1TPz2XT+RpXa/TxRg30p8BoCG4lm0ym+zAwNJ+F8n1Y+mLQ4bLRjA5 XTiZ/ll727Nv3XrbrH4hOl3SXMEMOOvqKrFQ4lsVM1zy13yOFw/T3xjU/VLqLh+XcLyzWxYfUD/7 7qYyA1ai5tbnG0XiNRUqZ0704+lDkbAaFs+Z8Tnrp3AOc2L0MYvucV+nR0zjoJG4HHG6bSdLZXB2 o/ld1+JnEqnCuleMSUlQ6nlMRbqYbO3HZarWdWOqOC1sMGD43i4hMlvMbqktuvRg0Tz4/MmkebNr fBPxNWehOmf0xsMxvPuKy5nhNJg8ZPkxQnd3su8WeAnozgckdCyOZlSftGu9/wBrLtbwwY1juNdN 6SpzGHOr2sBdK9paXbckLrPrV40abp7mT+HYRld2OTRyGOR4HqDvgBcceHJkyvHiV1+HpeWEMKnk dJnWPiK8BeDUWSJq3AZxC6nGqQPFrtXyv03ujuAU2O5xnosQdBjLWeTrby3tdqzOvfiW6m9RcmS0 oyPVZZwyVhLppSdT22/wF8Z9NtmIf+vNdaaV1K2kcJ2tO2rkEr0arSOOnU8v8hp9TCWVxg7R6C8X /TGsy70ljY7GajE6oyWMsps4/sEfhx8GfTo9P6DGq3Do6/E66HzZJpLENJ9l9/40IZ5MitnazVBG 4A2+VzPhZxunxTo7SshmbJNTh0bomm5Z7XXS5R0EZJ8tnCai9W0vw8qYr4f+nuP+IKiyjiGCtrKV 7yC5ota29l6eq/Bn0y/RwYbSYDS0tIxouGgayuucj9Kcz1fiDrscrqZ1JTRyF8dQ8H1D4Xq1hpJM UjLpwKtrdmE8rzatKM1KH4dtNOUk4y4Op4PDd00yVh7RSZLp60jb0xanH5uuZm6H5VrcH002F/wr W24EYtoK4vxMdScayJlaIZce1uMTSARao9Qd8WXRGEZm8TOeMPm8iKiwyl02dJO0Ne4W3sri0+TL DytpL+2eTNnwwyPGzpjxu9Lsv4Hl+ofNURy1TCdBuL/utZlTQQxzTSwm+kmw7cr2x4ounmasDo6r EcyYs+tqng64nONmnuvDklQ8xywi9y7lZ/yGKMIqke//ABc5TcrfCO0vDBg9fmDqzhEdDg7sYnE7 T5YZqAF+638ZPwcYVgGHRDCaank8oeYwsAsbDZa4fpDZXwmTE8UxWZkTq2EFrXOtcErYX1HxLGqb NGAwUVLNNh0kg8+SDsL918bS1kk0fQ1Upx/4MbrZ0/y7mLLTv4rFFTxu2cGtHrv2WJ0e6ZZN6d5M kny/gVLTtDHSOkdGNcht3JC+g6u4fJieUy2KLXoIN3DhZOBU7aLp1BEWPqLwetkW7j8BfVUm8Ci3 7PkTglkc1+HSVd4xMq5fxaooMeoYKFjX6ARY6lm9GuoPTDrd1DxSowTA43YlQMBdUTxDS4HuBwul cweCDGOsWbsQnxCR2DYQ5/mQvmb/ADLE+y7o8OHhgwXw04lWQxZi/X1FVsxspDXEe1rr3Z1p440s X8jxYllbvJ0j6/rN14Z0bjbIcIdUwb+mPa68+Y19QXpxnKnfhWYMt1MTi613tuGuv72XcXiW6XZj 6mSUFNgsET4D6ZJZDbQD3XUOAfTwwrAsSZjGYsb/AFlMPXNTgANH7pGOnhiU7+xqOTLLJtr6nrjp eMPqMgYbWYPCyjpKmESRC2wBF02HNWFYVUTsxPMtC5zSbxvkazR8HdcfiVCZumzMKyfU0wdDA2Kn s8WAAsOF5povBLVZvzBJiOc8RqPJk/5sFJUGzj77rwY8ccu6WSVc/wDZ9HNlWOowVnamM+JLJsmf qTAsBr46/EHPDZ3UxDmAHb912D1VztU5Nyy2ro9BneQ1oeObryNT9I8i9IuuOE02D1TJZXyhojL7 uB9ie69iZ4yGzOtJRxyS6I4iHlvIK7TWKE4e1/ZwgsjUmlyE7Eamp6eDEpA39c6m80G19LrLoHo7 1Xzdj3VtuB1+JmqoXNc4xlttIHZd+Zzx/AsmZNqRiNfBR0kFOR/MeAbAey8I9BvEvkjDevNc+pxC OKhme6KGqkdsN/8Ast4ccZYJya/4E5tZIxR6b8UHVTEMhU0cdEJQHt2dGOSey1Z9fKzOOeaiqrqu OpqIHElrXNI0hbiMTwrK/UYsq6jF8OxHDyA9jRI0/wCbryN4pc15GyV+vpIXUjPKjLQ2ItIdsvtf 43U4Y4XgS5aPDqdNkeVZvw1EYlg9WyWV1U1zXMubELvHwGYVTV/iFy/PUsEkdPJqDXC4BXXHUPNs OO45K6ghDWSOLbgdl9T4W+qNF0b6qUlfisIdTuc1rpD/AEC/K/Ha6nkagfrcLlLEm+D9AeNY1heA 5dZUV1UKCi0i8oNrCy6czP4wOn+RqV36WpqMacDYtpwT/kp+D9VOnPXjJEFJ/qfDzE5g1wmZoI24 O64GLpv0PyFTVFTiNbhkzXm5MlQCB+BdevT+B4/9j5/D4eoeSOTg+HwDxaVnUvqphsWC08lJgj3B ksRd6yfchekOqOf8RyLg1PXUmHOrmNbqkDebLp/JGYuhFDmX9dgWI4XS1jTuHObvb2X2PVfrX05Z gjmVmbaGJwabNima48dwF7NscmSC28Hn8k4wbi+ToPrB9QvDnZcrMMw7BaqhxDTpdJU7Nae9l3p4 V8zVmYeiNPi85vNMHPa499lq96t9TMkZk6uUcFbiAmysJP8AiZYh6nC/ay2A9IfGF0CyzkmiwLD8 yw4ZSUjPLZFUGziu+r8OL/RiRzwxzZJeSfYjqD4r8y9Oqypp3Ukch1HyjLsCvvfDL1/reudJiU9d B+kqqI2dE1lmn2IK8l+MTxG9KseytUPwLF4cXr7kxNYBcH8r4TwaePzK/TqnmwrNzBhrXusyqhbf UL9ytaxafFhUlGmzrgw58jak+D1N1oxCqqur+GkvlhlLh5YDyAd16Az5U1kHSqUiQxSmBrC5vfZd IYh4xfDpjLqfF6/MNLXzwDUx1rub8L5/GPqXdHMTvhcNS7+Hn0eY+Owt8BeR6mOZwjFdGlpp47bZ 6W6TNkh6XUzIPTUGNx3PdeY8/wDiRzx0lx+u04e3FaW7tndt9l9Phf1CeiWXsCZG3H2lumzIWNu4 /HwvLHiG8ZvS/OsVUzABUfq5DfzSPSV9LQwxeWfmX1Z5tUs8scVjuzprxC+KXMvUvG5RVxfoGyP0 CGM+6728Ov04YeouW6fNmdcQMrZ2CWnooz/SRf1LxJls03UbqdhtNV4lHR0slSCZpzYWv3W7HLfU vJvS3pxSQQ5jwyphpaVoIbO3kD8rxf5HURnkUMf8TvgwywwU5fyrk8x5p8N2U8nvkpsIEAZGzTJF oAIWuPxD4BRYNm6pbQWDA4ggdt17g8QXjJy3LFXjBRC+vnuzzIjcD5WurNuYn5ixGqqZ5Nb3uLju u+pjghp1+s7aOWWea/R8yY/LkZb139ltz+lBlnEsKy/UV01O6KKrbwW2sFqdwWupMLrsPrJ4v1TY pg+SAnZwB4WxvpR9UzJ/TbLTaWkyZPT1UUbWNjjI0vsLc9l+Wcd7R+hy3XCPf2aMyV1H1cp6CmqS yIgF7eBZdj1tFTxYhTV8rGWsPWGi5K1YYj9W99fjX8RdkiB0gNmkyC+n82XA5w+rjm/F5Ym4Zl6k pYGf/Udc/svr7oParr9PjeKbb4/4NnPXLMOZ8Kyx52USDX9mlvK844h0c669QYIMVxDMz8KEhBdT sfuGn4C8vYN9YHOVJAIq/K1DV2/rublcJnP6s3ULHIy3CcMpcKjIsQLmy9mF+KP1r/k889Nmyv7J o2ndJslS5DyEcKlxCTF6zSTJLK71FxG4XmbOvh8zV1IzhVRy0JoMKdI4ulkYHXbfsvA2XPqQdUcB xSSsNUKovN3Mc4gL62q+rF1ZnaWQMoYb/wBRjuVjDrPBkbi1yZzaDLliotHvXoz4Qsu9Ks4x43Di DpZ/6onXaAfddl+ILKWYs54TDTZb/VU1U0emphdYBafcyfUA6s5irRUHH3UrgfsiYACuZy99S3rN lyIQjGY6qMbBszLlYy6peXyrljF/j5xg4mwSu8HOIY5lxozD1AxCWrI1SwzSuaxvxyvMmZegjMLz vTYPgtccVdrDZHtOsgX3XR2efqH9W8/4c6krMQipmuGkup2aSQuqMB8ROespYz/EsOxd8dbe5c71 X/uvbDXQeOW59mf/AKdkbVejfRkfKRwrpJQ4E0NBZT6Cx21tl54pM54b4b89zGvoHRsrXWdMCCLH utblb4/OsuJnyzmWWBpFrRNtddf5o6+Z7ztUD+LZgmrX3uPNdwvPh1GPHjkm+GdcmhyyaN4mY8oZ a6/UeG4jHjUD4QGvEUcoufgi65jO/UDDei+VKahppIGPjaGsL3DSLLQbhHWzO+Wpy2hzHX0Bv/7M zgP7LOzD1wzrmSnazFcz12IbcyzErzLULLHbJ/VejS0M8fK7Zvoy/wBUMO6r5GngwrFKB+ITRlkz DIBoJ52C6apPBRlyTH5sbx7FnOpneqSGOf0Od3WmHDM/ZpwCU1GH49W0TnG5MM7m3/NiueqPER1F lhMMucsSmiIsWGodZdMeo8CccbpM1l0Es1OT6NmXWrJnR7IEEseH1FG6bkgOBc0f3Xh3xAdVsBr8 LdhGXGtMJ++X5+F58rc34rXSPlrK+oqJJNyZZC664uolmm9UjtLTvuvRqNfCWPauWaw/4xxyKUn0 fedC88UGQOomGY1Xag2GYXLewut1mTuvnTXqhkGHC6rNdLQMliB/mShu9loOtpO5291ktxOrY0NZ VShjOGh5C/NRe3JvR9rLi3qj9EOQs5ZByZgL8Lps5YVPE7YFs7QQP7r43C+r/SvIOZasOzlQmaZ9 3kzggE/utC8GO1sLrtrqll+4kP8A8oKquqHP1SVEkpdvcuN19WOeEU/7Pmy0EpPlm/zPeaOj/Uyi p2Yzm/CKqlhkEzQ2paCTza661zZ4quhfTWvgp8JwvDsSq9m+c0MDWW73K0kjEahot+pmDR/1EqpK 2SQ7zPkHy4rHym1tbdD/AOnpdM3v0/i+6T5sy3NDi2ZaWmoZmaHR6wHMHsO6+bwfr/4Y8lUokosc oKqqjJeJJryODvyVpBNS4DZ8gPyU2nf5l3PJLR2Gy2tWlwuEZf8Ajr5bNwVH9UPIeB5rrIayR1Zh TSGwy08fLfhc4zxmeGnM2NMx+txOWnr+R50ZJB/C0vyzxv3jaW/B3QeeSACwfkbLutTj/lVP+mbW gTVORt964fUK6cY3gb8CyxTNxWpnIZDOYg3Sb2Xp7w7YpW1fSvDH4jSt8uWDzHR24HstEvRPO2XM j50p67NOGyYphsZ1GGMi4PutnWSfqe9IMLy7HSQUeIUnkQ+WKd8ZAO3AKys8cn+uPR5cumni5irP RWbvFFkXpcKiKjw97pwbPEDLAO9ivBviP8V1bmbGjiUDXU7o3a4L8sAOy43rX458mZwpJ48Hy06L zHXMjwLn5XkLOnUY5okkdCzQDyD2X1UsWki5X9mePx5tRS20j3T0i+q3RZawxuFZswKTEgwaW1Ub gXfvdcr1O+ptlnOOFOo8Go6uk1f7uFrDFTFG4l0Zdc3T4MXedTWwx6e3p3C+BHWShk3I+vPQQnGj 0tnzxUVmZcOmo4gY2OBGt3K8zV1bPXYpJUsJdLq16u97pUkz6kAO9JB3VPBicBFtq791dVrJalVI 76XRQ0ttez1/0E+ozj/SPCafCsVwdmNUkI0tcX6XNXeZ+sNRMOluQo3NHBdILlazRC6Mhznaj8oJ A5zybtH7LwQm8S2xPTLBCbtncbG6m3KRUtIHCyoPUT2WHiVS2AaXm1/ZfDi+T7z6OKqGiR5J7KtZ ezQeEbnNezUPUD3QaNxZe1HnZx1U3yLNZ35S6SPyn6weebrNqohbcX73WA6UxPaAL3WzKRy8bXGx aUcflurGwvfu4XuEuFrg0H44T6eBkD/MfufdRlGVUDYwWN7bXPdJp7MFrbhZM7/OZdiQWE8bLIBk kudkGzjuoG3aUcURIuUAlzXMB0pTvNMgIsPdZzmhreFjSbg6eUA79bDAGuGzztse67I6SeKPNfRb F21OFVUv6e41QvJLD+y6ljp9Gt8p43AWfl3JmNZm86WBrZIR2tuu+KTjLg82WCkqZ7NxX6rGJ45g jsPxHLkFQ0tsX6e/uuNwv6o+MYFl+qoKLCiZpWljO4AXkyu6S5npWOdHhU0rD3YwlYZ6d5ww6l/U jLtWYebiF1/+y+iskn0jxrFjiqs7Ny14sc15a6hOzfTRGGqfKXyxxEgOBXdmIfVdzs7y20eDwgN+ 4y3Jv+F5BwHLOP45WyUlNhs/6vjyi2xXPu6HdQYqmz8qVxufv8k2P+F3jmyPho4+HFV2euaX6v8A nhsIZNl+jJaLXtz8ricd+rB1LxY3wyhoqYHlhbey8+DwvdSMTgbPHlmtaSPt8k7pE3hk6lYaAZco V7fnyiFGpS5SJ48V22dyYr9SbqjiuD1lDJTxNfUtLTJGPs+QF1PkLxK9Qem+P1GOYPWiKuqiTO5w ++6ZT+HvqR+jdJDlaqDG7uL2LisC6QZmzPjJwkUckVffSInMI3UayHTxYXyjnerXjG6kdaoKKjxy djI6QgsEQsD+VyWXPG71ZyXhcWG4RXllOwENBF7bL5XPnht6k9NoBUYthOiieNpmtvYfK+oyj4Oe oedMsR41hLmSteLtjPdYbmdIRxpcHVWaM1Y31GzJPjOZa2StrpiXO8wmwPwl0jC93mFukNNmos45 PzBkLHH4XmahnoqlhtdzbNP4KCkkvBZrrjsT3XkyOV/Y74oQj/EzqqeEQgulMUwNwWlfaZL689QM jxMOXcekow0W0k7FdcOY6sLXPGzTwvQ3RHwm4z1uovOw6rjonEDSHlSJ6N21cnBZg8YPWXMVM6DE cxSSMcNJLDZdR1k1ViFbJW12uplkOqRw3ueV7Tn+ld1DYGuZiMEgIubuXXvUr6f/AFNyDRGthp5K 2Jgu7ym6gvaozmuzw7sUZbqPOlBmXGcDn87A6+qw57dwY3lq+kHiB6wx0r4v9a4i6nI0lhmPC++6 P+FbM/VPEzRRwvimjfok2PpPyvRlV9JfMdThmuPMTIqlzQRG7ssPG4u2zU5YZdmvKsr8Vra418lf PLiDn6zM95Ly73uvs8N669SsAoBT0WdK+ljA06BMRsvqOuXhRzn4ec0UNDmAGspK2QMjrYLmMfkr 1n03+lvQ9QspYZjTsxiN9TCJSwbi5HCSUu2c4rEl9ejwTjefM05yaW43js9a32klJusBhNPRiAOu L3svYPiJ+mrifSfKNVjtNjUEggN2BzrX+F47w+B0cximIdNH6XAG4WMkJJKT6OuDx3UTOpqiCCMm RhMvZMo3/qJXOikNK892HSltDLO12290LZ5owXshHk8B65Rkz0ySodU0deZtMmM1TbbgCY2/7rFk pJXE3xedx+XlY8FDJUVhnkqbtHAvZZUVKxjSzUHPJ7Fdd8uzksMVyY7KSsgmtBilS0HkiQpdSXiS 01ZK53+9zzcrt/oRkHC85Z5oaLEj5VPK8NO/ubLZBXfTH6bZswOOSmrZIZHx3D4wHAGy2szbqzjO GOPLRqEdStkh8wVExeOCHrBlp5Jm65JJX24JuV2v136Mv6KdUMUyrHVmtipX2Dx7XXuHwbeGbp1n /JtHNjTYp6+ceqFxFx+y1LfjdNnNSxSjaRrCNLSyBsYqXMlJ4LiFzdOWU0zIB65Gi+ocLZF41vp/ ZOyn04r80ZZa2gqaFnmOGm2pa0qB5bAxx/5g2P4WJwbW/suHLBycao5WfF6aJgpi31SGxcsXGMPj cGtk0lttiBusWWlFTUCbSS0HYLmsNp/1tTFE9uptxt7BeU927g4akwwRXELHkN9gSFZjo5pwwt0y Hs7a62qeDbpX0v6gZXp8OxTBYajFGsGu7Bd+3uvmfH94MunmQOmtVm7L1A7C6uFwbojdcEr1Y05f X2eOeSETWlLhcDphG6nNj3adkqroKaimib5TnFx7tXM0lFXyUdO0QOe57bh2m5KyazBMajptT8Mq HxAbyNjd6f8ACijO6Z3vHJJnDyyMgZoB8tndYMkURkbdodGT91l9JS5KxnG4HfoMLmrnNFyGMuVx P8Lr46luH1FBLS1Jfo8p7De66KMkjSnCqMUxMgDzG7SOylPhlXjrmx0tE+sl7tZHqIXN5nyJmTLF JBUYjhU8FJL9krozbfheu/pyYDh1Znyo/W4ZHWRQN1vMrL7LFOjEpKrPFGI4PVZdla3EsOmpQeC+ MgJ8ElLWwlojBPY2W4Xx7YHkHDOg8uIDLVH+sqXhsMscQa5v7rUPgGUsWxPEJ6XDKCareXbMhYXE Bdljk4b2cI5oSltRgU0VPZ4dTBxBtsOVYcyjJL4wyM9rLsiDw/8AUivj/wCGytWSE8DyTcr5rH+n mZMrYgyjzNg1RhznWsJGEX+Fjxyq0dN8GfOsFFoMhaB7Jf6eB8gfE5pH+0rufAPCV1HzdhzK7A8s T1dA9t2yFuxXF5m8InVLLFLJWVeUq6CFgJL2RkhRQbRPNCPDOuC9wIc1oDQOyjHthhdK8ep2wHus SGono6t2H1tPLT1DCWlkosb/AIK5GSnbVSQsB2ab2C5tbeD0JqStMuloXuhBF2ySH0gLs/Kvhv6h 5yw4VeE4DWVFG4X88REt/uu2fBv0Dper+eKVtc29LC8Fw9wFtbzBjOXOgeRWlkDIaGjaAImNF3Lc bctqRwz5ljXJofzt0qzb09qDFjmF1FI0mwe5hA/7LFyvkXF85VDKTD8Nlqp3m3obq/7LeNC3JXix 6cVTZsOiloZgWCR7Brjd7gr5jw1+EbK/QyXEpI2NxKUyOdFPM0Gzb3XXIqi0+Gjy4tSm/wBTNUs/ RYZPoXjHMNrGTt50xnYrqXFo3SYo+GmjkbGx1vW21lvVp+oPTXOXUWbKn8Ip6rEmktc+WEabr5Lq h4GunmfM24ZjDaeHB/08gdLT08Ya2f4K5Rj/APe6MZdT7grNZ2QvAt1P6q5fixjCqNv6KRuqPzTp Lgvg+qnhh6jdEXmbM2X5W0JNhVMbdtvyFu56h5zwroH05gkp6by6Sma2GGKIfGywcOpsK8SHSN7M Zw//AISvY5tp2C4NuR/ddVVKUlweeWoluqL5NIvSzohmHq3i0NHgNDPUPlNmlrTYfuu+cx/TN6m4 ZgklW1jppY2azCwar/Gy2Y+Hrw64L4fMvV9PSCOplMjpGVBYA5rP9oWLljxKxY/1Rqcqy0b4KQXE VTI3Zzh2CbN7exWkWWt2pb3TZohzFlrGciY9NhWL0r6OrhdpdHMCCCsKreW0z3EkydtIuttP1NfD zl7HunZzrSULYMcpjpfLE22sHu5dNfTp8NmSOpdJW1GZIIsUmiFnQSOAWpRqKyLo9un1W+4S7Rr0 wmrFS7yohrnI32IP+V334e/CXm3r3XujwunMdMHWfUSCzG/N1668dHhI6e9MqTLmI5VwtuFV1VWC OUB2xYSF7e6A5Iwjpt0jwxmDUIBdTtldpaA6R1hdc26ipI1PMzXLm36SmdsMwqSsw3HaStnjYXOg vYn4C6v8P3gcxrq7nTFcv1Rkwp2HEsqZZhbSQbbBbQsm9fq/HOq1bgVdhMtPSv8A5cNrnQ4f7vyu 0abJ2G4Fm2bHKKnbFXVrRHOG2AI910U3BVJcnz453J2nwjXoz6PcsNVvnLzISeBHayHMX0gMMpsM mlps4OZVWuHTbC69beLlvU9mU6eo6ZSEVsb71Ecf3uHwvCHVvAPFa/KD8ZqKyvZh0d5JI2HVI0Dk lajCeRXwcp6y8my6PE3VfptXdKepddlOpqf4q+ldpEkRvqC+fnweuw9odPhtZBG/gviNl3R4fxBn Tr1hNRnGra6YzgVM9WLd973W5XOHS7pZmHpfUwy0mCS0n6cltW0MBuG9ivJOLU9h9uM6gmaN+lXS vG+q+Y6TBcBw+SqqJnhuzTZtzyVseyl9JTAH5Zp3Zmx+ZmLvaDK2DdrL9hf2X0n04clYFgWZM7Gk bFNLBUFsLiASGE7EFd9eJPPub8q4pg1PlShkq5JHgzWZqaG37rrjhJ5FBHi1OfbjcjWl4l/p75q6 GMGL5abNmDBQ60kkTCXRi/8AUAvtvCV9PaTrFQy45nKeXC8MYR5UMYs6Q/utpuExtzTk+nbilO13 6mAfqInN2vbcWWOcK/gGUaumy5Tshkijd5MZ+29l2yZVLhqmeHHlyqubTPDvUf6TGX8Rw+ebKuPO p64NOhk7fST2F1rY6rdL8y9Hs14hlzMFHJT1dG8t1uB0yN7Oae4W6Dw91XUGvzjipzEC7CtZ0PJ2 B9guk/qyZBwqXprh2ZxA1mKxziDzWixc08XUeKpLG3bYx6px+6XF0al/4c1tLLNru53ZZ1IBHSQR gX23ugw+B8jW7agdrLtPoV0eq+qnUCgwWEXjMgLz7C9l4pfR8n6GDcopnPeH/wANeZOuuZKagoaV 7KMuGuoLfS1vcrZlSfTQ6VHJ8NBWUUsuL+RaWtY+xL7cgLvDon0XwXotlOno8Op2CpEQ8yUN3cbL sSjqXVET3FhYT7pvbpo+dkkm6Pzu9d+lz+kPVbGctF5fT0tQ5kTvdt9l8mXOMbRJw37V6j+pbkSv yt4gJK6ZpFLXsEsTzwfdeV4S6rrPLebRAcr1anGoU17GhyPJG2zLicHhNLLBBCGipexos1qzPLD7 brwPs+pZifAR229inSMEVygIc5geRYIOxJHr2N0xp07diq2cfZA5pBtfZAMLrutbhU95cbDYK2gM bv3V2CFJtZC4XREhn5KDzEBWkgqEjjuqc65S3kg8fuoyEera6zUBNxdW0i2/CiAqU7Ej+6Ux21xy siT1RkALHbYC3daJQy52Vh2m5Iugc6yEPQUG6w3sqbY7lWHi1rbo2ta8ICgRZQ/3CYGADlU6PbYq AVwPZRp+UegAc3QiMEjdCBhztIsUqZpkIITmREHkaUbwGjaxVBj+Wdgd08EabAbqGwOyEusdtigJ ydxYqw3e42V8/BV/A5QFFl3A3QkeokIrlo35VMdqPygAOolWDbbummMt5CBwLSNkALRZ+pG4aibb H2RNbsT3SKmOV1iwWKA+lyZlemxydzZmjV7lZ/UXpbBgWGMxN0oaDwy6+Qw+vraSYOjlMLh3GyzM ex7EMdpWQVtUZo4zsLrNMpxdGAKAEH8bqmH1Xsia20DGjhqJrrjdtlogcbw1xubXSI53zTmFw9B7 lNLRbfYlKLbOFuQgApw6lqXx69TFkOk1bdkkM3PyiYC08oA3PaWho5CprXN9RSy42J7oAXscdTi5 p7IVGY2Ye26cHAgFceX2b7FW2dwGx3UZoyJaprH2vv7IBUF+xBSmMjdN5khJcOyzNcbnAgbKIFtY A0G9j7I2/wBks78cKzJslAIn5VOFwg8wK9Y91AQje2pRjRFe+5Khe3sh1h3dAG1xJtbZF3slg2N7 qOmAB7lAM7XCE3adkkylzwACm342QyC7VtulSscb27rJAAG6XISDbgK2RiWBrG27q9gfZLdINdlW vULEWstEBkbp1OG5UgBLXOIsPlWJGh2+6hkba19vyoWijpaD3SnNIsQmPeLelLLvSbndZBD2KjXH dIdNbZTztNkA9hs43CJgBuTuEhsoJTBIAFbAdjfbhVa5srY/Y3tdDrPNrKkoIGxsU5kfpuUnU0i+ 91f6khlrcIUeMMraoOkpqV07BzYLDawxuIkjMTxy09lz2CZvdhYLGXJ9lx2I1wxKtdKW6SeyMpju eCQAgfwd7q3OAOnugIIWSAmTy4nEDdfQdM+prMg4y+aekM0Eu0luR+F8657beo2WLJII4XGIB/7J JWqNRex2evIOumWa3AnVNHUSQShv2O5JsvM2YsSbimYq2vvczvJBXzNC+oILnAEc6Qsxj55HXkiL B2+Fwx4tjuztky71VHIMDSCbblMYwWuRusQThgtf901tSNNjz7r1HmoyA3dD3SxOCOVPMNz7KFHg m9+yp7gHXvcJWt7wNKU5+9ncoLCkA7cFLIEbuLEpzGCwsLlW+MOaHHkKkoxZBvY7XQkhvyqkkPm7 tJb7qF8ZI0G59j2Qg4kAA+6RM8HvZBUO0uaRIC3uEkzQSv0teQRyChLDe24BCAygHfshbN5TtBOx 2BSKstppAHn1FAZBlv3UE3I7LAmldGB6SdXFlTK1urSWm/cFToGW6uexxDQD+yA1c1VZrm3Z7lVG 9sjhtYLKe0MjGmxJ2sChRDCIrtIupUNa2mJHJ7KPieD8+ykkEsrWgcA8KgdRNfBh7xeziqpQWMOo i5RGF7m2JsfYKRwhh9ZNkAWyJtrW5T4m079RDtxwlOljD7NafygQrQQb9llBgDN0IaD35RtuwWch aKMLTHsibDZnJB+FRlaBsd1Yl0i17/CzZpIOOEuaS51x7IfItvwqjqdXCaXuf2/dZs1RQi1NseOy ZFG37UMLrH19k6OSEk2SypBCFrSCBuic0A3sjboLdiCqcQ35VNJIjWMcL2up5TXmwG6WyUNdax3T HFwIsOULtGR02++49lctCy35TIoJiL7fhSUytbu07LSJtOPloTE+4sEEkDjsQs17iQHkEgcgo/Pj qmOIGkji6pNpxM8VrADdYk48pu5XN+U18ZOoFywjSCpkawtu08uUMbTg/PnfKNDLhXLVPZIBJDb/ AKguRrqSeC7ICxzB/UOyRPhTp4hqqHMcRuCOVKbMtC9R06hZCx7nOtZFT0EsN2Su1C2wTY4XRktc xwHNyLq7WwqCdHIAN7hR5cwWuN0DqkRgsBAJ4cdghiZqmBd5gPs4bFXaS0KbJF52mV2/5THMOonV pj/3LIbSUlXJZ0LtQ5t2XIvoYoow1kTpQdrcqqLZrbxbOGLo23Hmaz2sktqXufoDdR9lzjMsTzOd LDh01gOzCLrjavDGRu9bpKWRp3DxuteKRzuP6NiY9rQXDT8Jr3ssDbdVHWeYwtMTnC1g4BVGyIfe fVfYLnTvkoRdG14A3BQyzNbYNSm/zqskbNCKNkb68QyO0h3BWQQ6XG5OltkLXR1P2G1trlFNQvZW GAAyNJsHFfc5f6FZyzLQmpwrA6yeAC5kER0/sVqKbdGZNRVs6/knNM/Q71j3VSVbWi+oEfC5bM+T 8UyxV/osWpJKWpbzE9hBIWTk7pZj+f8AFI6DLeD1eJ1T+I4WE7/JXV4pLlowskWrTOChxAPGxu1P FWHH7rWXYucPDX1FyDh4q8eyfWYdSD7pfKJDT82XVtdh80T/AEghwNi0p4nVmVli3Vmca0k+huoq 3zyADU0gn3C5nIXSzNvUjFW4blrDJ8RryNWiFhdYe6+n6i+H3qL0mpo6rNOFS0lM8GzntIA/utRx OSN7l+nW7RL5v2HSe4QPkAkPocy3chd4dFvCX1E64URrMv4PLLhpFxVvFmrmep3g6z/0pwttfjOG y1NC02klhaTo/K3HA5GJZYxfJ57ZI2VtwbFMdK2JoBN3FdydMPDDmbrBjhw/LmHPqpRbVIB6Iwfc 8Lv530j+p2gPbieHanN1Bpk3afY9lVjV8sxLKq4PCr3ubIBa4Pe6CoqIri5sRyV3r198I2e/DxSx z5ooWtpJPTHVU51sc69rEhfedCPpt55655Jp80UuJU2H0VTfy45+TZTJjURHMpOjyK6WP72Ou1Ik qC4agu4uu/hrzX4fswSYRj9E46d2VDG/y5B7grpyiilqawxRwufI8gNjaLkknsFyljcVuNRzRldP oWYKl7wSNjuLKm0lSXWPoJ41bL3z4d/pdZk6r5Rgx3M1ZJlmCqYH00UjbvLTuCR2XJ5d+ldW5hzf iGGQZpjq6XD5PLmmZbY9gQpCO7lnP5EU6Zr3FLVxWJs8e4cniTSWh5v8L2f4ofANUdBIcPqKerkr IKtzY2lgJ9RNjsu7un30lKHMmR8LxeszK+OsrYGzOgEWzLi/PuvS9PFVNvhhZ03SNabYWSNb/MAY fY7rIbhXnSC0pMdu62zYH9IvIwgLcSzHVVEv/wDCaBp+OVzVF9KDp7hzixuLVk7D2fYFc9sE6s6e Xg1AOwK4IjOt3axWL/B6yB/8wljRxq7rcXD9KjIH6gvkxOrjj7NZa66V69/TgmyVjmFS5agq8wYH UzNZOA31wb7k27LqoYm6sw8z7o1t+XUNkcHFpjI20u3CwA0smLHvAN7i63N1/wBLXphVZHEzP1dJ if6QyPk8y9n6b2t+V5p8E/hk6W59zXmPCM3VTK2roax1LTQPcGukDSQr4ITTlH0ZedRaTPAkNJOb SkgxX3IKYyYvn8sbNC2oeKf6auFYfgUuNdOIJIPJaTLQE6gR7tWsbMmUq7K+O1NBiEJpquA2dG4W IXN6e4748oq1MN6g3yYBa0HkbLFrJXxm8TNQPdSOYVD9LQWm9jdZNDBUYhiDMPpYnT1Mp0MjaLkl eev09baXLOLMclVK0O1uA5EYuVyZw5ppiWySRuHZ43W0nwM/T3paHCI839RKEB1SzVT4ZKPtHYuu uR8aHgLwqPA3ZsyHhrHzQH/i6JrdvLPLm29l1xwU5bWzhLUKKNVmG5dx7FY/Mo8MqqqEGxfFGSP+ y56iyPjchscFrNY5DoHWW4DwBYPk2v6d1ODMwCnfilA61RNNCDq/BK9G5jwnItDVUOHYnguHRz1r iyGMU7QXH9gum2OObi1ZxlqLVxZ+dutwuvw4VFPWUklPbezmkWXI5cydj2YYGSYdhE1XC46WlkRd qPwtuHjs8J2WMW6ZYjmPL+HwYViNBGXSGMWD2d1yX01a3JWauisEWHYbTvxTDZDHUyvjBdq9xcLW WONRWSHRnFmlJuMuzUri/S7N2VYPPxLLVdTQEX1uicBZfPYFlrEcy4n+mwuhmrKlx0+TGwuK3neN bNOXcj9IMRjrsNp56quZ5FO0xjZx73sur/AL4SoOn2XXZwzHSQVGLYmf1FMx7Q7yo3bg/lejZB6f ytUcXqJLLsRrGpvC31HMZqJMl4lDHa4kdC4Aj3Xw2ben1dgEvkYvSTUFR28xhH7LfZj3iPyNhHUf D8kuxOilxOoJjeNbdMLuzSff4Xn76j+S8pDpDW44+KhixJptHI0NDnH4tyuOOKn9ZI5S1c4O1yad aGpZQSGnnaZLbByzq6eCKlHmkAP+0BYf6doks46nSC4Kw6SOc1Rge3znl1mN5Xlyw8cmj6uKe+Nj 4qFxjuz0NPcpH6aYPcC9pYPYr050h8CXUrq9h0dfSYa+koZB6JpxoafwuwMT+lV1ZpKV7qY0NRIB cRibn9ypiisj5ZjJlUOzw2JHOlLIwXAeyMTlo0NaS/5XrPIv04OpuaM11+DVkUWEz0sfmOe/h34K +lo/pZ9U6+qkEZgbGx1vMkNgfwvRPTRj/wCxzWoi1aPFkcc00RL2WcPZYstC6UamOtI33K9cZ3+n Z1PyZiGHxTUjXxVkohbKw3Gr2Nl91S/SW6nvjikOI0DJHgOLS/Zt+y5PFRqOpgzwhUiepiZanPmN FnFu90qKCRzC1rDr+eFsck+kxm2ny5UVD8bp5MWij1xwRj0uI7LqTpl4A+ofU3M9bg4oBgsdBMY6 mqqtha/9I73TwJq0zXmiePP0NWXi7PV7N3TGNla1zXgtf7FbSIfo+HSx8ucmxSW3Y2Pv+V1xnn6W WOZRzVg0P8YGK4dXTCN80TSBCP8Aquixxk6RiWoUTwCInubpdJpf2tuuSo6csZ6i0uttr2W0qH6Q uBERNGYpWAgapC25H4X0FV9J7K0GEPp4cYlmqA27ZZBY6lfHC6s5vUNK6NS9U6OGJr52NDr9uwWH X1ccIgLfsebXXc3iV8OeOdCc4uwXFYxJTOJdTzj+pq6WkpGvIbI4COM3AWcuJ42d8OZZVwZFRURs dHFD6QeXKVkYcz03O25Isu2fC74eK3xHdSKLAKOT9PTON55z/Q0blbVcH+m10dytl2KLG4pKp7Gg SVcsugavdcVTdGsmTZ6NIUGGiRzXCQtF/dZM+Flxs2YW9itzGcvpm9KsewWWoy5JJDUxtL2CN4cx 3Oyxui/0+Ok+J5akmxXCnVdWyUxOlEh2I5XpWJSg5r0ef5KUtrRptpsLPmH+Zqt/sN7LJmpTDG5/ mlwtYAjut6WD+BfodhNY/D6TBIHVunU6OV+p/wCbLyd49PA5gHT/ACyc15Va2hp2m0sAFgT8Jjxq b2+yS1bjy1wa14Kd72a7DUN7LDM8+I1f6VjCS8gWbyVyElLUEERk6mGxC5rpNhba7qzl+jkbrZJW xh49xqC5SjtdM9UZ747kbGPBD9OGjrMt4fm/PzPMhqmCemw/u5vu72XsL/7nLodjFbNgTMtYY+rj b64YgA8D5su4IIYcFyPFDSWjip6ACKwsBZmy0e508RXUPpz1fxrH8HxqWCsbWyAazdpAcdiD2Xr0 2Hy27o+RnyzjNQSuzY5lDwb9K+nfWNtJLhMFS2sYZqWkqRqbb9+V3hm3pl0tyfhIrcRyrhkEBcIh I2nFwTwtcPhs8UmbfED14ypJjtYDiLJBHqZ6GgXW0TqPkmizvgsNJidQYKGmc2eR17A6d9yuOSW6 aTfR3hBxg0jq7M/hN6bZqjpcWpMAgkqGFssTdgxw9iFzGfPD909xnp7X0NRlDDqdkNG9w8inaxzX aT/UBcrNzr4gsidLYMKoZcWgqZaktgp6alka9w4AJseF9JnLHG1XSnG8SYwsElFIWg+xar9uDgkm 3yePfprdNcpNwDNhlwmlrK+nxJ8bTNEHaGAmw3XYXWDweZd6wdbKCufTQ4ThtBE2WoZTxgfqXg7C wXyv0yqEU+H51mBMjZq5z7uPBuV7JocNc3F6qrlALn7NuOAtZLxZGjaismNHVPVrqh058OuSaSPH mUkNI0NghpI42mR1hzZab/F11Qw7qz1jqcbwmlfT4OxgZAxzVuI639MOk2fceo8NzmyCXFqj/kNl ef8A8gXTHX/6fmRsU6a1s2XKX9HiFJEZY3NsQ4AcL04nicfs+WfPm82PNwrSNXPhb8P9d4keqDMD YZGUjCDNIxv2tuvcfW36Z+BdOOn1di+CYnJ51FAZX6xzZeOuivV3NHhe6mVVTlykFXVMeY56ci5f Y8L0R1w+o3nvqB0/rsu1OUZ8FZXxeW+qMJtY88rzxjtyUz6UsrlG4nhWqZDQYhKJG65tRbq97LHf KYWuc0AhwsfhN0l8pEl3Sm5uflYWIh1PC65/ZcNQlGT2n0tO3KK3Hefgj6Fxdbur2GYfWW/h8Mol lZbd4vey3k4vNgnRHp1LLRUjKTD8OhGiGFvNgtS/0kg6TxBy2BcxtE82+Vtv6wVeA0mR6/8A1LI2 PCpBpe4my8+nqc6Zx1fFtHAZPzPg/iH6fVAraFsuH1TTHJDK1fOdCvC5lboXi+MVmD0kbjVOMkUz gC6Mey+46M02X48lwS5aIOGyAljgbgr6vDqSWjpJ2vJkkeSWly9+WW2UoQ6Pm44b4qcnydOYB4nK bHesc2QW4RN5sNwcQI/lkhdT/UQ6CZYzb0src5S07KfG8ODSyeNoBkF7WK7Sj6gZNwDObcEfQxRZ slms/SwatzzdcZ48JHM8OOMxsJ1vY0nbt8rrBbZx28Wcf5xk5Po6r+l90fwrK3S+pzT+kj/iddIW +cRdwb7ArivqR+IDFctVGDdOsHf5UWMD/wDSEwP2x34Xd/gKpRReG7Lht6pQ5x/uvEX1DZ3VXiGl fK0iGCmY2J57na4C6Rglnn/RjJlvDCvZ7x8JnSrBOlXRbDW4VCzVVUwq5agAXeXC/K4TpX1kzpnD q/imC12GSQZZgLmw1ZaRrI+V914e6eU+HzK7Sdb5aBpAPYey+Iyn1kGOdQmZNocLFLNSzEVEum3B XLClJTtX/wD4dc0ZQUFF0ds1WS8Bw7OEeYzTQUeISAxumDQHSn5PddV+KXpznvOFFQ1GT8TlpXRy XkjiNrrtnOuHU+L4hhVPLNofFKJWMv8AcQupvGF1/wAa6C5bwurwWmhqqirlEbhNwB8fKxh35MkY x5ZnURxwxzcnSR2H0owvHMA6fxxZgk8/FIYP5jz/AFEBabPEjnuuwTrZiGM4LUvpK2iqzI18R0+o O4W6nptmWbOfT/CcWq4vKqa2kbLLHbgkLR34qKJtT19zPQYfE6Vj68sjjZubkr24Ev8Aasi5POv/ AOGMHaZua8Mufq/qj0MytmHFtP8AEamlb5waNi4bXWsb6nOF0NP1qqnQUzYy6Fri5otc23WxTwZY Ni+XOhGCYfi1I6kfBEPLa8WcQRfda9vqb1Mf/q+1gcDM6H1gdhZP8fSnJS/C61vyQ2rmzwVVku1B hJt/SEFHNPK6zmlrR7iy9zeCHwFYb4icvVeZcexGWjp4pdEcMY2f+U7xteCjDvD7lqHFMLrP1FNK /TotYheDLDflagfajn8cVZ4bfUxyAs7t5skMjbWAse0hg7rPbRROY6F92TBt7+645z30dG/Ubgm1 l45RptM90XuVo9z/AEpK2tb1vipaeqeIDE7zGX2c0BbZequQY+oODfo3TvglY4OY9ptZasPpGZfq Zeq9ZjAjf+mhgdGZSPTc9rrZd4hc61+Tst4fJhrtNTU1bI734F1jTP7txPNrVtxtMw+qL2ZE6JVG HFxkqJIxStcB9zjtc/suB6YeHTJWTMuUOJVeBQYjis8Yle+SEP8AURc2C7RxDA6fN+TqODFtL26Y 5XOG/qAul55qMVockVdTlt8YrqWEugY9t2vsOLL6Mck0nFPt8nyJQi6b9IxZOnGVMxYe6GtyxQNi ePtkp2A/9tl1xkTwY9PcmZrqsfOFwV9XLLrgEjQ5sPwAuhsrdR/E11okr6ekwyDL9DTvMbqiRgZ5 gB7f/iXpzoJl7OWBYQ4ZwrhV1RubB32n8Lrljkw8ORwwzx5fRw/UzxCdMukGY4Mt5lFNRzTR62AQ jQG/O2y+FzjQdBfEFS0dNTy4dW1hma6MQAa734IXTfjK8P8AnHrZ1d14DhfnDy2xxyyj0fJJXOdD /p3y9NMyYBmbFcf8vEqSVr56WncRER7fld3DHGCkpfY8+PNNyaa4s9qUGV6TKWW6SgwLCaRrYIwx kYaGAABZ+H089RRWr4YYy7Z0bdxZcD1ahxuuyHiUOXZHR4s6Eine07g25XkbIHh06+5jwusrMw9V K3B5HOd5WHwkkO9i72Xghjc1blR9PNnjCVJWedvHBhWW+mniLOJ4NFTSNa1tRPTMAs2TuLLZX0Bx pucukWWsakooqOSqpGHRE2wtay1E+KzotjuR+sGG4HiGMyY/jOJvjD5NWs2JHK2+9B8Anyt0hyxh crdD6ekY3Se23C6alx3JRfRjT3tbkjx1T0VLlzx4T0+G0UBZVP1yRvZqAcRuR8r0t4v4Iqroxi9G 94YZItI22JXl3rxWt8O3i8wrO2OzGow7FSHseB/yxexuvZONMy/4hOmNTDhdZDVUeJRDTO0gmM/+ CumXLcoO+jzQjJ45R92dc+A2qoD0Qo8OpYBHPRyOZO61tZ7Fd60NFSnFqqppS5srhaRhFhcLr/J2 A5f8M/TiZ1dUMpqOnaXSzPcP5jlkdFOt+D9ZMIr63Cn07JoZnRNiDt3N7Erhktyc49HrxSThGOTs +kxLHaWDEwH5joaSOP8A5sL5Ggj83Oy6H8XPWfprF02xnDa7E6bEMQkgIp4YHB+p/wCeFwmavAVB nvqXiOP4/mXEW4dVPMn6OlnLQCe34XWPi58M3TDph0qmkjxA0+IB2mEVE+qQr3aWOLcm5cnizObu O3g1eY+aebE6s07Axj3OOgdhdfJ0VFJjWMQ0cIuXSBjR7m6+izC+nw6rlgglEh41krCyZVxZezVg +JVDg6nZUsfIfYat149c1GbcT7ujTWJNm7rwV+GgdLOitM2tqZBNi8IqKoRktcARsLr0Rk3GcHrK IYdhdSZmUX8m7nanbe5PK+A6H9fMldRcg4ZBh2N00TzStis+RrSPTbuuXyJlHA8h4nVVLMdpahtS 8yHXK0b/AN158Et+OpPo8moWzIpL32fK45gtA/xO4W+Kmb+rjozLLIBz7LhvHRnjMOR+jFfWYFWu w6aR7WfqY/vZ+FzWeM75MyZ1Ww/MVdmSkZVVMX6UMdM2zWr6HqZheReteTTheIY9Qy4dKQ68dQzn +69sZOUoOfKR5MiajJYzWt008Z/V2mxDDsPbij65he1rnVLSQ4X91tNyhmepxvIcOM1bGMqnUoe8 R7jVpubLofMk/h46EZMMGITYQ+WkbdulzZKh7hvyuQ6JeNXpP1BwF0FHiUWDinuw09VZmw7rrnUZ vdCPBjFvjjSm+Twr1D6+dTsB6oVddguN1EuIOrHxU7JGk+m/2gL2L4M+rnVPqbmnEafqDhL6GOjg D4Z9GkSE/suehxTw7YNm+uzVUZiwOTEJT5jWzTtLYj30t918DnT6mfTTKmeqPC8JfHPhQcW1ddEw bjtpspmyQy8QjR5dPhyY5bpyvk7/APEh11y70KyzS4pj9BNiVPNOIxFA3U4fK89Zu+oVW4ngBOS8 jYrJFKzQysmhIa3bkC3Zfe4n4qPDh1ewmE4tmnDqiO4cYKslpYfkHZfE9ZvHT0i6dZYfguTv4fmT EXR6KWOmYPIYbbXNuy54ljcUnG2d5yzeS01tOzPBJj1Rj+SsRmqtRqTUmWUyCxDnbkWXOZdxCoPi Hxyqcx74XUwgBtsACP8A4XzPgHxWozZ0qrcy1VMKWfEapznQtFgLe3xuvter3Xrp94e5H1OYQaeo nGrVEzU5yR+2SUYxtvg7yX0i91I6l+o1WRR5AwiA+mR9QLOabH+67z6GUDqTohlqBz3Bz6NhLwbn cLVT4y/GxH1uzBRxYKx8GDUZ1Rh43cfcrs7wr/VJwnIeT6TLHUGkqaltISyGuphqIZ2BC6ZovHih B9o5YYSnknk9M5bxQ+EbqBmLPeN47DQtrsLnvoqC672j5XgbqZkfFenmLOw6piMdRuQTwVsq6xfV WyLWZVqKPKNLWVNXM3SHTR6QAtbfVTrBV9TsyHE68CO/pDAOy9eXU+XTqE0k1+E02CWPUXFtp/p1 h+oNTHM+Y/zGvA27rdv9LxktJ0JbBI4G7g5oB7LSrX0kccrhGB5UnB73Xo3wpeOLM3htxAUdZE7E 8BOxgB9TR8L804tzTP0s72s2f+LzOXULC8bwXDMgvqoKl7S574mEtJ7bhdaO6c+JPN+S6ifMWb4a amcw66EttLI232r4ip+sJl4aaiDKUtW+22ohpHwSuvupn1cMRzFQxQ4FlmGgma7VrmfqX3sOogoq G1f8n5r4+Rzctzp+j3r4R8t4llzphJBiMc0M4lc0CVpB/IXjvxsszl0czrUZhwqomihqgX/qBJsN +F8Pl36wucqCkbT1mV6CrsLeYwlpv/2XTvif8e+O+I/BKfCqjBocKp4XXJYbly1p8vjyyySXDN59 LKcYxh6O+fpy/wCqOo/XqfNOMz1lfTwQuImqLuYCdrDsthPiQyViPUHpVjOFYVVGjrfLMjHtNiS3 e37rTR4e/qAZ48OmGuwzCMNw/EKL/wCnMyxI/I3XZWcfq2dSc1YTPSU+GUOEvmYWGSIE6b+y8Dzv Jm3M9MtLJYdse2fP5NzjmTLfWDB8JlzLidG1lc2OWCWZ2j7rHvay3F5tw4ZjyDLSU8Ar46il0tDX XuSNivztZq6kYrmrFzjEs5GJOdrdKw2N/cLuDIv1C+r+QsOpqGix98kMDQxon9YIHwV1y54uaa9H LFpMnjan7Nunhl6DYh0vmrcTxkgVVQ86I/8AY3sufxnJmKZg6wjF2wtNDTsDWSh9jdanK36pPW/F aOSn/idJCXtsJIacNI/+V8HQ+OvrZgtfNXR5wqfOkOpxc0W/YWR6hufkb56NLSSUPGlx2brPEj04 peoXS6vw2aTyZoozJC/kagOCtHvWTCqnLePVNHUOayeJ5baN+1h3X12M/UL6yZmwibD6zHTJTzC0 jmtAcf3XROMZorsyTzVdZK+oqHOuXvNzdfTw6mODSPG5W2zyz0M56lZqqkewvpqdK8S6idV24p+k ZNheHEPqJZmhwvfjdbYutowzA+m2L1czIaZkEB0u0htttgFpt8MHjoHhuypWUOH4QJMSmeC5zm7P +CuU69fUizr1yyw7BH0cOE0LrF/kk3cF+cxZH5d0j7c8dY3FI6Z6+4tDU5vrcRaWl0rnAe53XVhm c2kllaDrenZkxWfHhBUvFtPp37rBNTLPKImssxo7d16dXmhlyXBF0eKWPFUuzvfwTdMKXqN1dwx2 JYrT4ZR00rS8zusXWPa63vvxLL+CZQhov4tRx0UFOGeZ57eA21+V+a2CqxLB5mVdDNNRy9pInlpX OVHUnOD6PyKrMmISQP2Mb6hxv/lfPxpwy72ejKnKDSN8vR3PeQcsfxgMzph1VLNO5xL52jSPZcrW +K/pZhONOw2rzlhzaiS4aWy3H9wvz5w1dS+MllfOwuN9LJDv/lKkOIueJTMXW/rc43X03kx5JOUv Z8uOnyRioxfRvjrsO6G5rzJ/qGfMmEVVQ5wc5k9TGWu/Y7r57qf40OjnRmspaTCX4diWKRu06aDT pibwSXBaOTidVHIS6qma+1rtkKxJKh1TJ65Hm/LnHddJTg4/yZmGkkndm/yj8T3RfrRlrRWZpw9k b2Dz6eolDdJ7jfn8r5DGvEH4c+jGDvZT1WF1rmbsZSsbK95+CtF8kv6dwYyWSx5LHbLIilc8D+Y9 5HZxK86ztR2p8G8mh3vf7N1nS76mPTjNeJVVBXMGAwsdphMhAD2rkavxKeGmlzTNjsuJUD8YO736 dVvm3F1pG88zO0eW9svZ4coaepb9ztR7Nd3XSGZRbp1f4YloZTilL0bOfFn9QnKeY8CmwLJ3/HQS NLX1Lo7Afhcf4MvGT0T6QYJIcXbPQZgqXWnq3MuHD4WtpsE7m2liDGfBSDhhluWEc3sQpn1TnFQj 0jWD/Hxxtv2bmOt/1COkGYchV9DQV38VqJ4yI4XNtZ1tivD/AEQ8cGJdEOo0uJU5kqMDrX2q6R7r t032LR7ryAYnU4+2zuBYrIjL3xFs7QQeLhdlrVDD44K17sv/ANPTy75M294n9XTp/S4a+Wmwqpq6 zT6WDYXtsF5PzL9SDOWN9QzmKIiipWP1QUjDs1t+D7rxSQxjydJsOACmCoEsepws8cD3XmWqVfSN M3PQxk1bNp+A/Vwy/JRUpzHlb+IVbB/zYbbH33Gymdvq45ersDmp8Dy7V09a9pDXucA0f2Wq39Y9 7tLYBf8A6Vk1LTTYfG/U3W87stuEjqNrTokv8fGXDO6usfiZx/rAJv17yyN19LAeAV0tEyOKB75X XcdwO6yKd0QpgANTnc/CxWUOhxe52r2BWc+oeXs92m0sdMnt9navht8TuYfDjjc1ZhNOKynmI8yC QkAr1/U/WMzAcPENHleBs4A9czr2Wuuaok8z0sDAO7VjTtkmde2n8ryY6xy3JdnTJhWRUz3rjX1b +oWMYVUUTMGw+EStLfM0kkXXX2V/qZdXsrVchZiFNV05ddtNJH6Wj2XkoSupWbWdfkoY5D9zC3Ue xXt+VaqqR5/hwvk96yfV76oupntdhGGtkc2wcxhAb8rorMnjX6mZhzK3HJsYkjq2v1M0bBq6Ia1r oj5r9MnbSkhoJa17i9o7LEc7i7RXpYS4aPY+GfVU6w4fQspPNo5rN0mWSK7j+6+Fzx4+Orue6aWn q8xvgpnixhp/SLLzjPA1u7Db2S/KLxcuIHsV0lqm1VE+HjXKR3FlXxddTckROiwvMtZACdnGQkhf Qy+PvrfNA5rs71rmuGlzja9vyvPcrI3Ns0Frh/lKa15uOF5VlnF2jp8bH7ibGvARlHMXWnqHTZwz Dj8UzaOXzyyqlGpxJ7LaP1BdXyYM+XC8SiojGw+sOFivzc4BnjMGV5A/CcWrMPc3g08xZ/2X2MXi T6nNj8t2dcVkjItokqHEW/BXpw5d2RPJ0jx5dI6ax+z1f4t83Y5PimJtr8zy1QBLRAyT0/jYrw/X 4tUQ1fmQzOjkBuC11rIsXzniuNPlkrayWokkN3ve4m5XEMqWNBD2eYSeV9X/ACGrx5Eo4lSOGi0U sPOV2z7HD+smcKFoigx6uiZxoZMQEnE82Ytms6sSxKaoPd0ryST+6+YEcTrPaC0+ysRu2c15uDwv hxzThe1n1XhjIzoGyxB5AADTsT3QyUf69xc9wa/3TWPdOwBztwrAsT7rxuTk7Z6FFJUiUNTiGHPL aWvqacjh0MhAP9imS4/i9fdlXi1VK1vDZJXEJTZHR/YNvwmNnEjSJI2kW5XWPBzeOMu0Y7MSq4m+ ZFXTsd7seUo47WSOInq5pAeS9xKYYmEaWN0jlC6IOBBjuvVHPOHTMvBD8Mepkje3UdW/BBWF5jgd RcTY+6zZKbU0NI2HAWK6l3sLrlLI5y3Ps0oKKosy+ZpALg49yUuUeVKWuAcmNj9QDuyCSPU5J5JT 4kzSjXRGaSCSC0fBVuaQGkG4KKJhad9widT69wSD7Lmm0WintDAw77878I3VBgbpsDfg2QmnNtzd BJBZq6+WdUZcUyQyy69bdWocEHcLNOYcR0eW7EKnQBbQZXW/tdcc174r6TZTTq3PK5bn7I4p9maa mes2DnFnclYzG2e9t7n3UYXtaQx1h7JsEYaL23+VqU5S7YUVHpFxU0QN3vt+UySAvH8p0bh/lR8T X7OGyU6ARmzCQT8rNmgGSvptTSOUl8znk3TzFySblLdACLjYpZKQtsr2nZxCZ+qkkbpcbhAYXXVe Ub8LSlJdMUhkjmMN43G3sUrd3dGIj7XTGQWF7LN2XsU1r2m4TnOaQHSbnhNEfCswAhasUIDmgExv cD23UE4DN2+sf1FOFOAb22Vuga7soyUY0crnPFjYfCyXWLmuAJcO6JtOGWsN0xsNncW+FLZasqYR TtuQQ/3skx0g1gvcXNCzGs2uQrDATbt7pZaMeWBkg0tc4e26SKQXFzdZ+hrHAKnsba/CWy0cbLTO YRp3Cjg59tZJA7LLMYtyl6VeAY3lDTYD+6WYHfBWba9tlTo7WWQYbYnX3T3uHlabXI4Kc1m3whew jgBAYQG+4UuQb8LJLQOQqDLncbIZEAmw7hNbVuazQGgoxE29gFGgC4tcq2Beoxi7QN+yF73PtfZM A0n1f2VuYHDf+yWwGZWVDI42Naxw2Lj3TZqU0gY/0SAe3dYopt/hC5pbsXGyJ7XaFGZLiTptIYwR tHZYcz9TyQS2/ZC0aXXBTg0PK6yyyn/JmYwS6EDULC/zZMiY4uvwU8gNIsE1ttrrkjoVFDfc3JTm xjaw3CoEX2PKMW4JstGSnwh3JSTT77BZYF7lKLjdQqO2Kexb6tkmvhjlZ6mh3tdFDe/OyCs2GxJA XxEuT6r6OLniEUQs0AX4WNG71f8AhOqZyWm6TTkE6ivaueTgy52FzHFce2nMszbAXBXJudsb7hYF XMIXB0exBWujJykLC37h2UJF7JNJVOnjB079014vuAVAEyTTwNkTi5zdQGyoNDWgqy8PZp7HugES G4s0cpgaWNAJSf05icdLiQrDXBo3uflAMe4AblYolAlNwilaTa+1kttrPvz2KqJRl4Dgr8yY3BTB 2kPeG78LY/4avDlhEMNLA2nEz9IfK9w5K14ZHqXUmZKG3BeAT+624+FatkfHRggEyQgG34Xt00FO Vs8upe1cHPdZKrIHSXJhqMWoaaKoEZbA0MF3P7LJ8KuZsudUMovfLSUL6nzC0074gSGrzF9T6eqp sSwSmcT5ZOtu9l8P4Lc34zl/NVJUUskjonPAkjvsQvr5YKKW0/PwlKcm2esM++Futd1upsz4Tg9L BhF7vZC1oufwuxOt+e8B6M5dwyeroaeWeUNjbEWC913pSVLqujhmc0t8yMO0/NlrU8YOZMexzqrL T4pE+KkpZwKeOx0lg4IUxTeR0/RzyycKr2e9sm5opce6dxZgiw6OMmEvEYYCTYLrPJnioyxmLNEu A4tQjD5w8sD5ogG347r7Hw44lS4h0gwyR1vLjhPmBw2svPfilzH06kwCqqMAdD/HhIWu/T2BB+VI xUpyjRZtxSkz17hFNguLNm/TU1LPT8F0YaQbrqfOPhuwlmeqLNODwR00zXgyxNb9y4LwQ4lUv6aV LKmSSScuEn8w3O4/8L6/LfiHoK/qFU5VxGnFFLG8sinkNg8hYqcJuuUje9bFycL4vsLo3dAMxTzU kettP6XFou0gcheS/A74mqXC6SiyjilI2SIu0x1Dx3uvaXivojifQnNMUYDwaQm3wtUXhxjdBnOl ZuI21Ia23IIK0mvEn7smOcnklC+jZF4nvC/lXrrk6SrraSOnq4ojLHVQts7YXWlPF8KdlHM2MYSC Z2UdQ6JjvcA2X6GXSNrOnrQ23rpNJv76VoH604c/AOruYKc3JNbISD+VJJZMTb7R6MOTZl2nBQkR 0j5SPWTey9ueA/qjNguP01BPCJKd5DRccLxQHMbFcjYbkL0b4TcTNNm6iLRZhcLBfMS5R9nIrRuN zFiWITZLnq8Jbpq2xF8bfewXzXR3NNfnTKVS7GmuNU17o3xyssufgxsYV05fihiMxgpjJ5Y72C8I Z5+obircQqcBwrBosLe5/liZh9V72X08cN8JJLp9n53PLZkXPZ7cyF0zwPJVXidfh1I1k1Q8yvLR yedl476ufUSq+mXXF2EVVFfBYX+TLG4WLB7r1x0Dr67GOm2F1+IzGapqY/MeSb7laj/G9kevxjxF ZkhgpZz5s1omtafXf2W4JScm+aOOSTW2N9np7xf+J7IHVXpBT0dHWUtZUTaZWCLeSNx4APIXcX09 s61WJdM4cNqXunEHpZI/c2WqnH/DFnfIWE0+OVOG1jKB9nXcTay2NfTdrHOwRlPqN7EuHyvLNO0m fVjFQg2nZk/Vmxysw7o7htNSyPjE9VZzmki4twtSmARkRzyuddx4ud1t++qZgv8AEOi8VW5pMdLN qLgOFqBwF8D/AFSP0sF7/K75kvjwo5aKcnkkh8LBUQzFxu8cLv3w05GwnMWYMKwzGKf9THUvAew8 WXQOFOdUY6IWN/kudsexWybwKdHMLxzFocQqtL5owNO19PuvltSfR9rJLajvuk8BvRnMGGsYMOMN SWDV5brG9vZeT/Ff9PGLpTDDmLJ1TNVYQX2qoptzF8/hbHs15jwDpIaKWppX3qXiJsjd7H5XF+Ia B2YujGKPpmebqjbMGc3bzZe3Enwn7PhzzSbfPJ4N8HPhErc4V9PjtVrpcPp3amynYusVszyrl+my 7QNpaaZ0zI26SXOvuuvOhsrKPopTVVPEynApSWtYLWcAf/K+b8MGdMWzPV5hp8TLy6KocG6j2uUl Bfan0PNJuKfNnhrxE9HsS6n+KXGqXD4HTVdVM1mkC9hfcr3V0A8LuD9IKChrKiaSXFwwFzS/0NNu AF89kzBKeh8XGYJJmjzXUwfE5zduOxXP+IDFcwYXnDKUVLUyx4bU1YbJ5PI3GxXoyxeSUYL8OGOa xxcmYPjvbI/w1Zpc0Xc6IcflaLKeR8cpY5txey3+eKXBH5k6EZloo4jM79E5wb7kBaA3tf8AxeSA tLXMlIIPaxVSXxrfZcP/AO44OV1vjLWNaLuXq/woeFDEOrtdHUy/yKG41uI7Ly3SRNdVNkc4fyiP T7rb79PGro3ZHMcYHmuYCF8yj7U3UTvTpd0cyd0PwyCkoI4o6x+xqZLB7z8Lrjx6YO3MHRllC4+m qq443G/DTyVyPV6LE6DrNlGXzpZMMkfeSM30tXN+KXAXZi6WzviBe+mkZM1o72PC9+JePJCf6fDz 5N8JQ/D5roT4V8gZN6b4bJUYFTYvVuhbIZpow9xPsF2JSdMMm49h9TQOylT0sD2lji6naNvhJoaz E6bolSS4Ey+KNomuib7OsvJGA9bPEtmzNsuBYfhMTIIydVVLGGgfuu0ceTPKUrMS1Ecaimejul/h Tyn01zbiWIUVFDU0lV6mslaDoPsvJ3ip6P4Fg/ijytVRUcVLQ1E7HSMaLNJLl6Z6G5kz1lTM9Xg/ UmthfUVrtUD2us0H2CwPFf0CxnqlmfLWL4NIIxRSt83T9xF7hXDXmrK/R1lKSha/Tsfq30yyrjfS LF4ajAKKrEeHudEDC0kODbgheHvp3ZhwTLHU3FsBxCFhqsS1sicW/aQeF77zlmTDOnvS6arzBVtp 6WmotEj5T9x02stZPhJgdmbxJ11dhbSY2VbpIdP9LCf/AIXPGv8AXJP9O0ZynP8ApI93eNTIWH5g 6BYrHJE29BaeF1uCO37rpT6a/SPB25ZxfMdfQxVFa6bSx0jQ4AfuvVPXrK9Vm/pDjmD04PnzU3tv tuuhvp+4wzDsOzDlOQhtTRTBxB5HY7Kxn/8ApnFfpxTaz/0fZdbPFllTofmvDcHr8MbrnI1yaQ3Q 33Gyxcw4v0V8ROG0NVJV0VVWRvDomEDXq9iAupfHD4Y849buq+C1+A0LX4fFAIZXu45+4pGQPp2O 6eVmFZgkzGaWemkbLURtkIZa+97rrtxrFGSdSPLDJkeacH0j27geD02WsuUlHhdNFFDHGNDGCzbW WRLPSzUpFe6nDbeoPsR/lfM9R8v12bcgTUmX8TfS1fk2p6iE/cQNtwvJeQvC/wBYM04hVnN+bpsP oGvLWsilLnvavLjxxnzKVHbNklFpRVnmD6nGUMn4T1HosWy3PRmqmH89lJawd3vZeRsKY7Wwk+p+ 69J+OjoQ3pXj8IhxKSsjduRPJqcCvM+GYnHFUQwH7nbBb1EFF9nt/wAfkcuH0bB/pv4x/Cuoxo9I cydmx9jZe/uvQwR2THMxuNpppXhpeR9q1K+Frrth3SDqBQ1eJbwawC+/G62z1OJZZ8Q/TaVuHVcF bS1sO2l41Ru/7heTE9uRSbPXrFcW6H9F8NyphOVf4flWSF9JbU/yzwSO6+vwumNMyop3b6ybEey6 76ZZAwbw/wCTKqWpqjDDG0yVFRUPvtzyuvelPjWyxn7qbiOWPOip4mv00tS99hIvRki8kpyjyfLx TjCMYvgytGRcsdWKfD42tGY6ie7nf1bld55mpfNNDoB1CQXI9l13ivQXDMU6r0ud45iJ2buF7h34 XxfiR8aeWuguL4fhRjZidfM8CVjHf8pvuVqb8ko7O/ZIS27tx2N15/gzMsQPxyITYbDK18l+Bb3X OdMcy5ezVlyN+XSw0EYDNDBYBfN4DnPJniQ6bt8quhmoq+MCSEPGth7hXRDJvhqyVUunxCGgwuFp ePMeNTvge5WOXBY2uSfVZN/pnZUELnumicLQkEDddIUObMhS9TZcD/Txw4rTy7PsBd3wuvOif1A8 o9Sc/wCI5frZRhcGsspKmpOlsu+y7vp+lOVKnOTc5QmlmnLb+Yxw0/m912heFtT9o5ZY+RRcF0fI eNanhq/Dlml77FjYLtJ7FajegZ6qV+MmDpvU1MFe8lx8kH1f2Xtn6j3ivwehy7VdOMGmZU1cwP6h 8bvS342XS/gJ8UHTrokXxZnlOH1j7A1Om+xWv4YakezSq5OSPm+pzuucVZhUXVKnq5aaKpY2Kokv pBBW3fpVKZemmX3vsT+ijJt/9leD/HT4zOm2fek0GGZZxWHFq2edrwGN9TLLm/BP448HrcGosm5r q2U0rGCOmqHmwt7ErzSTnjVHrlzyd+5C6t4DVdXMay6cKc3F/OJbN5e5b+V9H4muqdV0c6a1GbaD D34lW0zmtZSC/wDMud1zjH9O8IxR2ZhWYZSVbwdVW6VjS8W/K8tdUvG9kbGOqzMoVs0FZl6CRpfM 0gteRzuukGp5E30j5M04QcY+zrV31ScxV8kdO/LMWC1Bc13/ABDHEFvcccr3700zjh3VjIFDjUMI fTVsWmWJzdr29QsuqXZd8P8A1TpoJ5WYLqc0Pa572Rnj5X3I6mdNej2UHRtzBhdJhdGwlsUU7Cf2 AO6zklB/+NUahCUWnPo1HeNnpjT5d8Us2X8twmiNfKHAU/psXHldmxfT7684XlVmIUOa56mkkhEv 6F0xJ0kcWuul+vPiPwzNHilqM8U8TqvCqWYGBh3L2tK9mZf+r/0+hyu2lnwLEKWthiDGNtdriAma STTifTwbnj+xlfTUgrcuZ7zXgmKtDMSgj0zNOxJB9l6p8SHVmq6UYDSVtBg7sVqqiUMDWN1FoPda h8veNHFMG6+Yjn7BpTRUtVPqkpeA5l91tS6c+L7ph1QybRYpiGLYdTzmMGaCqe28bu+xXnhJ+S3y c9RFyx7TtvImYKjMeRKPEqmAUVTVQgmJwtpJC5Olo6ijy9URlxkqC11nA+42XjrxN+P/ACNkfJWI YTkrFI8QxqVhbG+D7IiV034X/qZ1WDwjCepUorKZ5/l1kf3MHyurg39jy423Lal0j2B0EzlmqvzX j+C4vh7oaGklcY53NtffbfuuqPqkmDEujdHh4ka2YVAmIJ30hdht8c3QmgpJsQpcz07JXxl7owCH OPtv3Wsnxg+L+t8Qmb3DDw6jwCleWRR33e33K7xalPfVI4ZMU1Hx3bbPiOkfhtz11kYTljCpKikY 4+ZNbZgX1mCx548HfUOOoxTD5aWaN19UgIDx8L0/4CfGJ0o6XZHdgmPYucJxJzxcPZ6Xfkr5n6kP iX6cdXMMwrDsq19PiuJxO3qY27BvsSvHJbpcn33PZUUdg5N+q3X1QghxHKIqmXDDNA4hzvmy95dN eoEXUXKVJjcdHJQMqIw/ypTuLrRJ0nx3L2Xc2YbLmOq/S4e0tcXDcE/K2l4H9QnoplvK9DSnFh5c ULWBsbA69h7LFJdGM8GvtE8g/VQzwMwZ+wWBtJIIaJrmCZzdjvxdeI6OdsktwzY7gr2547fFL0s6 85Qgw/K0N8Vhl1+eYw0key8R4fRuNOC1+k8aSvdmyKWNRo8WhTi2pGczTrJFkYueO6x2tdTiztye 4TQxnkk+bYjsvnUfZtDG2uQ43+ELn2fY7sWNHM15O+6YJGFu53ULYzQ1p2Kr0n8rGM7dVuSoKho2 uoXsySQgLyXWWOZwDsVXmPdIAG3B7qFMpwPKDSTuBspVPFKwaj6nJzDaDjkKlEFnzYKnH53S3y2P sEL5W25sUIMBGrdM0sF77XWLFKDdx7bo2GOqbqDiDdZotmZoBiIZbhcb/URwVlGrEJ0aCQO6x5P0 9WdpDE75WiCnC6VqGqwO6fqZFqYHa2t5PuseSOMjzWkt/KyrKNcdPCETiMrHlkcyNrgb37JkbWyR guICtMGUyqY8fcmiTVxwsQU8Lxdps4fKYHiMBoBKEMlxa3lUXAG/ZA4XjDj2S/MDxsbj4Qhlfc02 4RQMa0Xdx7LHjlIb8InS+m9jb4VLRVVrDwW7NvuhDie6I1LHN08rHdO0bBCGS0o2mxvwsZr7jY7I hId9ihDLawP7pggaB7kd1ixvcdxwmCXtq39kKOkdqIalarPAKose77PUSNgELY5HkAjS/wBiheBz Xgm3CYyJz2mzgUgxTxEh7Q4e47K4JmtaW8EoZESVDQ8xAfzED4jFz3T32G4YC4/1IRE93qkFghaF MPf27I3PBIslXvq0EEJDprODXbKEMqZwsN0GqwGyDQWxl5sWpArGF+gO9XsqDK1D8IXOtull5aLk iyATteEAYOom52WPLJd+lpuUbp7MBABbwqpbGoI0EvO+yqTZV+kaDez3W/KKZ7actsbkrOrcEmrI 2zRUc7dP9QabFcTUUc007GFr45BtZzSF0eKSJuj+mUx5cRcWTi4Ntc/2Rswmrdp0xPkNv6WlLlwq fSTK2aIju6M2VWGTG+P6N861gNx8qnTW5WBDT11SJP0lPNVFnPlsJ/8ACCnfW/qYqZlHJPUyGzYQ 0lxP4U8Ul6KpxfTM5swKIPad9QCZV0VfhEojxPCJ6CRw5kYRdXhuV58ee7+HRTVMh38uNpcp4pF3 oXqab2laUgVID9JNysnGcp1+XZo4cTopcPnfu1srS0uH7puFZXqMerIqXC6aesrJBYRxMLiVnZL8 JuXoxm1DL/eNXsj1gg2NyvoMZ6K5zwOEVtflbEIacDeUxOsPyvi6iVvn+X645GmxYdipLHKKthSR nCoJ+03+AnU9RI/aQaT7LGp3CIgvbpvwTwE2SoZPKG6hq9wsV7NGcLhpPIWLUSeZZoKZ+q8hxiLg HELH0mEF7zck7JQ7MOpJp3B7SXgHceydFO+Vhc5haPlc1g+EVOOVTKHDqKSsqJTbTG267zwzwMdX 8xYSKnD8tvcwsD2tfsSF1hBydIw2l2ebnztDgCdj3UdJCXCxJPuvrc79PMeyLicuC5iwebD8QiJB Y+O37hfZ9JvCV1C6xQOfljCzLC0XL5fSF0eGUezLnGrTOoZND2ixDflJ86Igh7jcbAhd59TPBD1a 6S4TNimN5akfh8W76iAaw0e5suiXRiOT+ZGTbggbJ4m1wco54N1ZivdUOlIjhc4Di3dZNyGAyxuj t7heiOgHgrz74h4JKzDof4XhbG3ZVyt2cfYLjPEj4Rc6eG6PD5cfqo62jrHBsbouQb91mOJydI08 sE6Z0VJLLsGRXHuqikLxfe/+1eruiv08c/dYsIgxSINw3Dpm3bPLwfwkdbvp/wCeug1HHiRjfj2G utrnpgT5R73XRae3V8nN54p0eYL3frZuQLWumUkri0tlbpJPcL0x4dfAdnPxAmprYpGYPQROsZ5x wfay78q/o95jbA58Gb6SoeBs17C26y8ai2mzfli1wa53NnbVOYGB7AL3CXOJJJQWytjZxoPN16E8 QXgt6j+H2j/iGMUjJ8DdJ5Zrac6gPz7LuroZ9M89WMg4fmaPG2PbWM1NId6WG3BUli2pMws0WrR4 ThZ+mPmPIJPcI5p/Lic4NP5C7s8S/hYzV4ccyNoMXi/VUU3qp6uPdkg9gfddU4TgdTmeupcPo4C6 ome1jWgXO5R42o2axZY5LSPnIKiVzg5w9N06RzxJrc7TGe5WzDpp9JzB81ZEpcSxvEqvDsTliEnl Di5CV0/+lVgdfnmemxnM/nU1KPVh8ThrI9ykYKrI8tOqNaxnbDpkAZM3uAbqhOauQujg0NP9IC94 eJf6cE3S3HsOq8t1Hn5erahsUmrd0N13Nl36SuXarAqKqfmqcOljbJJaO3IuQF08caUmyedfhqs/ SlrTpdoP5soKOeCNz31Jc0/0kLcngv0rekwpmiprK6slA/5jJAASuSw/6ZXR+Kqlja6oqXsADojI PT+Qq44lwmZedrlKzSvTRRVZc0Ps4dwd1b4XUrS4lzwP8rdTN9LPo9LI53k1sTnd2yWsukOpv0wa HLOaMF/gM1RimC1FUGyxuHrjYebkLKUG6L56juaNY8LxLHqZpv2GqykWJNE2l+zRsdrrcl1E+mn0 mGQq+fD8Ono8UpaUyMlZJy9ovuF0P4EugvS/P+MY/hWaKOnrcUpZHNip5CNxfn5XXxQcXKPo5R1C vk15STO8xr6Z7D7tS6mYAjYGQ9gtpPi7+mvgTsq1GY+m9K+ixCjYXzUIN2ytG92/K1c4rh9TgOJV FFVwujqoiQA8WNwuLwpx3ROkM6lLaxYqvIIa8WceyyZPs1WvfsuLgjmq52mYer2X0VDgNdjNfT0V HE6R0jg3Zt7LjGDbo9TfBxFNS1sspdEwzAf+20XKo0kZlfK5r4HjZzHiy21eCvwLYRheU249m7Cw 6qqWgxRTD1EEckdlg+MP6fWAT5fq8zZLpXRVUNpJaNouHAc2XpioN7WeWWXb2arKXKmJVUQnhwmq nhP2yRsJB/COXKWIMfrlwurgcP8AfARf/C3YeCeiyJnLpLhtMzAKJmM4UPJqoZ4G6g4d7Fd1Zjy1 kOnqWUWJ5ewuWWcWDTTMJ3/ZYdRlto5ubfKPzr4zR6A2IQlkg9haxXIZX6cZtzPHJLh2AVlbCzmQ QEt/utpPjw8GOUqTJJz3lfDY8LkonB9TSwjS2Rp4Nl2d9O/N2AZ56Tvwx+GUbMTwxwjkDYm3c3sS uslHZvSMQyuUtrNOOaOmOdMFo46qry1VUNPHv5roiAfyuDwbLmLZqro4cPoJKysft5cUZNyt6vjk jwPAOiFcZMOpw+qeIIj5YBDnbL5PwJ+FbAem2QYcfxSgp6/GK/8AmtklYCYmncWuo4xcN6J5pRlt ZqVd4bOo1PTfqJclYk6IC5c2F2w/ZfCYnl52A17o66lqqKpZzFMC2391+hDEeu+QMLz6clVeKUFN ihbtTSlov8Lyx9TDoVlTF+k7s1UENNR4tTnUHwtDRK23wusYRdRkqs4rVXLh2agzUtEkk4JkAP2h Phr4nbiNwc4cWSMOhYYpJgbEbFvuuUwuCWsfBT01OZqmd1mNaLkleKUNkqPrRe6NmNFFU1rTI2Ig N7BZ1NFHKwNmIaTtYr0NkXwG9XM74fHiNNg8kFLI3UC4WuF9LX/TT6sQUTqkQRjTvoB3Ksce4xvg uzyw7BGUDjNHeaJ3seFjU8wfI5jactb/ALnBegsv+Brq3jtbUUtHhEs4hfoeeAD+V2DhP00estZF pNBT05P/ANSQALTx12VZYHj6SnbK6/mCMjgjhKeZYpQ2/mD3AXqHN/gI6p5PrIaTEMIilErg1s8N nt3+QvsMJ+mD1UqKSCpjFJGJACWvdYj9k8fFhZoPizxRU09Te+jSzm6j2PMALNpB3Pde18z/AEy+ qWD4bJUfpY65waSGU7wTx7crr7pl4Deo3UzGZqCmpf0XkuLJZZwWtYRyCjw8WmR6iEeDzVBDNI3U G6newWVSmUBweNJ4F1sIw76ROZnhrarM1LGbestub/hfL4z9KvOcOOMoqbFYzA4+mokNmlRYd3sv yIJXZ4e8ipY65aJGn2KywyJkJkI0nuLLYNhP0i8zDy/1eZKVgPOkEkJmcvpH45hODzVOB5lixKqD S4wSMLbm3AK5uCuka+TFdmvSjEdQ0ujOw908NDT6t2rLzpk/FOneP1eEYnA+lqYZDHIx4sQQuKY9 zo3PJuwBZnjcXyeiE1kVoKGtk/U2MbXNHCy2vfMHkjy3/wBNxwu4fCn4XcY8RuaDTU0hgoozeab/ AGNvyvf1J9KzIWFxQ/xLMVRI52xBAbc/BvutQjG/sSWWONUzU9CXOmDXTN250uRzmRshaye7T3I4 W1DqJ9LXIowx9Xl+qnY+Nl5DI77vcqZM+lvkLFcAhndjk88r2+rSB6SvR44Jbr4POtUrpdmrWncA wMcQ9/8AZB+jbT1AmAL4zywdlt2g+l70pZSuppq2tfXAbPEgbY/juvE3jB8GmKeHisOIYfO6twJ2 8czhv+CkcSnwmZ+ZFP7I8tVEcDXu1kwxP497osvYHVYzWDCcOL6mpldcBu7rJVXJHippdXpANzZd /wDgdwqjqfEjlynqGMMUkrdT3i/zY3Xmn9We9VVo9VeFj6auGYzlelx3P7ZoBOA+OkB0vI93X4Xc mavptdM8w088GFuZT1MYLW2AJZ+bL011exibLHTDMNfQgtnpaN7oxGLWIHZaXsjePHPnTXqlUYxN iM9fRCVwmpJCSJG3Xs00Jz5gfAz5W57as9p9HPp79MKbHcVwDM7ZsUxmidqaRIWsLDxYLvCHwU9D ssyU1HNlumdLUu0xiV13PK6a8LHiQHiI65x4jR0kuHF9OXTROFrgC5XrvqJ0yOeMUwjEY8QkoanC 5fMiLDsfcFNRay036NpzjD+zpXFfp4dF6zFmVMmAiFgdqbC02auufF54HOnsHRjGMZwOkZhFfhNP 5sLo2gCS3YlevMa6iYFlmrpsPrq+OXEH2b5THAvJ97LrnxjYiIPDXmp8bT/xFNZpI4vus43PfFGG 91yvo6L8JHgx6VZy6G4FjmL4G2vxWuivNO51i0jsLLsTpv4EunuRs14xU1OAU2I4bI7VSMqQHkDu CFyngCEkXhnwESO1yND97rvDL1VPM+ojqC5ztdhqHZTMnDLJfh1eRuK/s6lgyt0SqM2R5XocGww4 ub3pYIt2W5B9l5e8fvgyyng+QMSzvgFNHQvpm/z4m7Nt7j+y9WYF0Ey3gHXCtzhh+IhuJSxEz4eH aiCf6rL4T6kNZU0Xhbxs08TpTJIxr2tHDSeSuuFt5Ek+zxtyduXo1QeHPwq528QJkdl8NZRRuIc9 /HK+k69+DPOnQDBDi2PxMkoQ7S2VhBF12X4HfHVlfw14ZV5ezJg8ktPK4PFZALuB9l9P47PHFk3x C9OKTAcox1JeZg+Y1A02HwF3z4lHNKC6PZHK9qZ4GEn6iUNibpJFyVdVHTxxCQkuqW7gBZccUcUZ 0ua2RrQLnuseFjSfWNTnbXXypKnR9PGt6TZ7M8AfhJpuu+bIcfzG1xy/Q+t0AH/OeOAfhbW8axLI /SbAqLD6qnosNw8kQwQtY0X7LyH9JCvNX09zHC6xFNO1oJ5F/wD8i9KddumOU84V2D1eYq80skMw dE1z9LXG66YoqcqPn6puCbR8X4lfB3lTxG5VhnwmKnwbGmt1U9fHGACD/utyuf8ADP4ccJ8M/TZ9 K+OnrsXha6Wev0AOft2J4XdOE4dHSYDDT0pBY2MCN19rW2S8Xp435Zqoa6W0ckTmSyA8A8ldJZG/ 9d8I8kYceQ+Ky5mvJ3XrLeI4cWw4hGdUNTSSNBLO3/6lau/F54Nf/TPqlg8OGSNGEY7U+VALbsue P2WzLorkXImRJMQflavZV1NY+85Emo3vwvN31JcVkpMz9MoqUHzY69sjiDwNQXfFe/YlwzjJXFSv lHfPhp8PWWPDh01jfBTQnE/J86uxAsBe7YEgH2C8eeILqnJ4teu+BdMqZrIsrGo0vcxv82QX3d/h bGqKkGI5ChgkNxPQgEke7Fqf8OE4oPHNE2T0NjxGWnjc4W3BNlnGl9n7R2m2pQijaBgmWsA8PXSc 0mEUrabCcGpdZa1u7gOSflcN086jZf8AEjknEY2UF8NqGPgmZM3kHZfa9R6/CcPyfiMmNm+GPjIn b7t7rhOi8uUK7J8VXk2OKPCnktHlNtv3uuC5i5vs3kvyKC6C6TdIst9HsCGF5epGRRlxfJOQPMkP yV007qd1QpvE6MtTYPIMjzm8da1pAb+69H4Xgwwt9SRM+Xzn67P/AKfgLqPMvigyrljqzBkbEYXH E5XAMLGXIJSKc3wrZ58tRSuVGD42MJwnFPDnmyTFqeOodT0xfTmQAlsnYheEPAN4wcYyfmnCMlYx I2TAKh3lAjmNxNgbL3P408iVGdOh2OyUtVJCYKYymD+l4AvuFqG8M+HPxLrdlmjhJ8x+IsYGgc2d uvfjwwnppTk+jClJZlE3R+I/pBgXWLplilLiNHDLKyndLT1DmAuYQ24sed1qr8DnRvBs0eLBmE4j TNqaXDDJI0Si4JYeCtx2dpYcLyJi8kh0RQ0L7n4DCtUv078Whn8VeJ1L3W/UTTtb87my4Y5Xgkpc lyRcc6UffZsv8QnUo9F+kWNZlpqcSyUMVoYhwDwNlrB8JnjUxTLfiLr6/H5S3AsyThlVEDtFITs/ 4Wxzxm5dnzL4es0wU7S98NM6csA3cG7my0udA+nOKdTOqeE4RhsT/MrajQHW+wA7k+1l3wQg8Er7 E7eoUV6N+OMZSwPPMNNUYjSwYnT2EkLZWhzRfcELrnxP9THdDujNfiuGhlPURM8mnHAbfbZdh9N8 py5HyPheBz1rq2ajiEbp3ncrqLxt9Jqjqz0YraWnndG6geKvyxxJpXgxPdNRk+D3ZYqMXJdheCfG 63NnReDG8Tq5a6urqh8sj5zcj4C5jqpknNlLmiPN+D5p/h+G0LPMqMNe30SNG5H9l8b4B8Skf0fN A+B0TKOZzW6v/wBfhYnXbxD4o7FsW6cYXlupqsZr4TFBIxpI0uG7l2cWs7Uejhk2ywpnYvRXr3gn WzEq5uDCTRQjy5zIP6+9l3A5gcACAW+1l5q8FXQrFOjOVcT/AI2b4hiE3mOb/tv2QeJfrxiXR3qX kqnppyaCvlEVTTjuCbXWc8E8rjjNYZqGHdM9C5qLo8s4sW/cKWTTb30laAKbOeL5H631tdRTPo6q HFHvJabXOvuv0AVFSzEcAklA9E1MX2+C1aFcVyFj2fvErmDCsuYe7Eqr+MaBCwXAZr9RJXp0V1JG cyjOcW+jeX0xxSszT04wHEsTs+prKRksm1gbhaQvHbHFD4lc1RwNZGyGfQ4NFgt52UcOZlTI+FUU zhE2ioo2PLj9tmi/9t1oa8ZeLU+N9dcx1FPM2Z1TVOLntNxsSu2gW6U2+jnmglOG3s6Nka2CYOH2 8r1T9NfJOGZ48RNC3EII6owfz2skFxZu/C8u1FO1zwBwG/3XsD6VDDQ+IiKax1eS9mr2BFl8fJL7 M+xGNxpm4TqNT447K9ZFlvQ2u0WjDu34XCdJ/wDVlfll9LnajgjqGgx+jcSt+UjxEZ9xrpt0wxbM GA00dRV0cfmvbJw1vusLwydUq3q90pwzMWItDaqpJ1aRsLLqr2XR8iai83fJ8Z0OwmlyV1pzjgdB Timo5necyNv9Nyu1uoNHlvC56LMeZauCip8PePLnneGta4/K+LythHmeJDMmJRPvAyjZG5nbX7rq X6nWXMexnoFJUYO57oqWoEtVGL2Mfc7Lqk8uRR/SZFGGPro+J+oL4wsnU/TCryrlvGIcVxPEGWc6 kkDmNb+Quv8A6Q2YWMxLMOE+aA+WBs2m9rm+61g43M4VD3Oc5w2aBe9l73+mj0V6iTZloM3UUsuG 4Ix382R7TaVnsFdQvH/p/DphTS8sj119Sijil6d4LWPNzFWtBZ7i4XpHpRUR1PSjLslOdMbsOi0W 7egLzx9QzK+L5n6ZUTcKpZKp1NP5spZ2A72X2/g26uYB1N6QYfh+HVGjEsIYKWtppD62PHJt7L1T Telh+JnzYZd2onfDNSXimpq3Bet2aP0zpm1Zr3ziRjyCCHE3uuuc/dTc957wqjpMyV1dJhsDQyIO JLD+VtezZ4AqDqH1ymzdjNeTgzpC59HGPVN8E9gsLxwdHunXTfoRVzUWF0dA+FobDGANRPG3dep5 ITUYx/kzGnltvcujTxGWUZDzIZLbC/ZfbeHbB6fOvXLLWGz7xVFYwOvwRqGy+HkbHVSybaIiSR8L 7nw9Yvh2Ret+WMRq6gR0cVVGTJ/tN18PUtq77P0mLmNo/RNhOF0mXMvU1FSMio6Smga1uwa1tgsV uYcLo4i+pxqjNtyTM0NH+UqoNPnrIxZRzsnpsQpRaWN44c3kFeTct/T6ZW41iNVmzN+LzUj5C6Gl p6gtaG34JWMMU48ujyZ5tNKKs7DzJ1owM9b8t4TlXFYcQrcQkMdayI62tYO9wu6uomcqLp7lOvxy veIaakZqc4my859NPCtg3TfxA0OL4DKKrDaemd5hkl1va4iwuu9eu2TaHqD0rzJgeIv8mkqKR95b /aQL3XrySi5QSPLFSWOcumdU548WHTrE+kmIYxR5goqjFI4ddPSPd/MEo42Xa/Q/PH/qF0ywHGpZ mSVFVTh8pZ2cObrRDhGX5cW6kQ5ep6i8LK/9K2zyA5oda+63tdEun9H056dYZhFPJqtA0uJI5I3s rnxxhG0+zeDfLmR8Hh3i8yZFnrGcuY7itNgslDMYmS1L9LXkfK7M6fZpwLPDKvGcBqYaylc/ynVM HDyP+61bfU16UYR09zUzMVFURyDEpCXxMk9bHd9gvQf0y+vWUm9J2ZQqsVhocUp5TI1tTIG+YHex Pdds2GOPEpQfaOOCcsk25dJnJdbur2dMm+JHC8HkxFzMNlkYIqVvEjSeSvRPXzF6mi6L1VTTl8NT KxhEjD62bg3C4jPfh4yxn/qlhWfK7E2y1tEwNhibINBAOyHrtnPLNTQYdlp+P0UVZUyCLyTM06Bt u7fZcLjcXEsYuLmn76Ow+m2OtxPpvhde55kLKMOeXbuJDd7ry7g31EMm5TxXGsJzV+pE9PVPZFNG y7S2/BvxZepcjQYZl/K9JhzMRo6hkbLOdHI2xFvytRn1GsCwDAOr9bVYDWQCnrd5aWnILWyW3KmO MZzal0XLuiouJwHjn8TuCdeuoVNPl2F/8Lpog3zZRuXLyZNHHWvmAdos3UR8rLqPK8pjYzsw+pwX HwtjdVSvc7Tfi/dZzT3NL8PdpsXijz7Ng30eomP6l42XMAMdI4scfzZe3PH9jdVhPQmrZSSSxzTS tbeFxa7/AAtVngg8SdJ4dup8VXiLQMLqT5c77X0t9wtseI+IDoX1jwBn8Qzbhc9K8Bwp6mZrHA/g rzYKUraGrtwaRzHhKoqpnQLADVSSOqKmDUXyG77fK4bw+vrKHqhn7BH1RdSUdVrbC3cAnuuOzb4y +j/RnKPk0ePUtYKWMtp6WicHX22Gy87+Ejx45Hq8354xDNVbFg1XilT58T5jYOYCQBde5Rl9kl2f OjJPbfo9LYxWV+FeJ+hDHvMdbS6QHfaWj4XA/UShkl6AVug2ZHK0uI/C6tzr4/OkFZ1twGrkxTzM Nw5paa6BtwXH8chfLeN3xydM8/dG6/L+VsXGKVteRsGkaR77q4+JxbOc09jUTWHVFsNXMG7Mc47r lujdVS4f1ey7UVEojhZWRuc9xsAA4Lgf1DBG4uF5CLi64d4mkl88HyXMOprgbbrGtnCU/qfX0ilG FM/S1gdRS5oyPRvp521FNV0bW64yCLFttlqsxfwO5sz54hsRwappnUeXvPe5uIvbs4E3/uvl/Br9 SSr6M07MuZ1M2JZeBtHIz1Ph/HwvWGN/Vh6Q4ZTiqw+hr8Rn/wDpMYGu/uQrpcrgnS7PmavDOUk4 8GJ068GFD0L8RWTnYS91XSNjMkspbwQOT+69X+JBmLz9EM3NwON0mJmieImNuCfe37LX5gn1X8Bq usTscxfBZ6fAf0/kxxM9T2O919b1B+sPk1+D1FLl7L9ZVVErHM11Is0XFuFw3KM1I9K3Si07PD/T XH6yg6v4M3EpZZpBWMjlbUPL9J1b88LeNnjB58S6R1WF0NnT1FBobo3Bu3svzuZt6mVWN52q8w0c H6My1BqAxnAde69l9GPq45t6f4BR4Tj+AR4/T0zBG2USFr7DjddtVqVmyqUfRnBp5YsdPtnt3wM9 PcwdORmGjxXDZKSKeYuDyLC916sFQJa10TZG6mWLmX3A/wDhasMwfWbqZsNmjwfJbKWukHplllu1 h/HdeecF+ot1Mwfqa/OMuIuq3yjS+gJPkhvtZc3J5ZOTMQjkxxUEmbEfFT0azTnjrvlLGcGiqv4d SuZ+ofAfTseF6Zz7idNlnpfic9bIIo4MPcHGQ230WWsXEPrHZjroI2UmV6OnmaBqfI4m5XSPXn6g XUPrzhDMIxCaHCcLvd0FDdnmD/qPdez+ShF1weXxThOckncj7TwZNylmDxQYhXZqqKUUMlS8wiqs WOOo25/ZbJvErhnTul6MY7Uz0GCzNZSO8pzQwFptsW2WhiWoqbtq6GpfBURnUHRusbrLrM+ZuxuD 9PiGP189JazonzOLSPwvHlleVv0e/DhksdezFr60HHKl8Nix0rtHtZKxAGp+4i42KVH5U9TEyE7M +4+5RVbjGS5vqN+F55u5H0scXGKR3b4M+vFP4eurdHjFW0vpHuEctuQwmxW7PE4sq+Jrpo1tLiEV ThVdCH3jcC5pI7+xX53KljJtLI2nzbX1D3X3WQPEV1I6VUD6LAMaqKekJvpuTb8brhjvHk3RMZ8e 9U+jfCcQy34WejUsmIVLYcKwiNxbqd6pO4A9yV0b4bvqF5c6x56rsBxaSLCTO4uw4ykND28WJ91q Qz/4k+o3U6ibS5lzJWV1EP8A2JZDoH7Lr2nxerw2aKpo6l9POw3ZJEbOafghfRbi+Zds+fHBkVRj wkfo4puleVmZ0rc3TU9PPiU4DhVFwOgAcj2/K8KfUP8AG5hM1HN0/wAryQ14vprqkeoAjbSFrxpf E31VwzC3UcOd8VipXMLCw1Dt2ntuutqnGKmonkqJZXTzyu1PkkNyT7rrGUcbU27oj00mnHpM2X/T 18d+F5X8rp9nCcUmHvcRR18jrCNxP2u+F6P8ZeQen3UrptXY7S4vhsmYaVnnU07Zmky230my0cAT 6xPG4xvBvdpsuQlzhj00YhfitYYyLaPPda34uuHnak5mnoltUV0bcfBL4+cCfhMWRc51EOFzYePJ hrHH0EDaxPsvWVHi/S/B66vzdBmDCnufGZZZ21DDe299ivznRVVXRymZtQ+KX3DrFZjcy4rM0xPx GqLCLaRM7Sf2usLL9rurOzwOlfNG2an+phl3E/EHTsr4/wBJlSle+mbVnfe9tf4XpjO+aOi/XjBa N+J5nwmtpmubNCJKhjXNPbblfn+MM0sZLn2HPPdHDJV07mNjqpmB212POy7YssIy3J0zjLSSyQcZ O0zfr1N8XfSvopkqSCDMFDU1VPT+XTUVHIHuNhYcLW34VOqGRM0eJ/E80Z2fTRUc1S6eBtVbQDyO V4vqXyuuJpnTuvy5xJQy00LQ25kErhs5nZayZIxi1B8s1DTU1u9dG8Lrz9RHpx03yrNHl7EYsUxh 0RZTwQW0sNrAm3YLUHmzqDjfWrqQ6oxXEDLW4nUafOld6Y9R4+AutI4pfPaXa5rf7jwsg0k9RUeZ A/ynt3FjY3+Fwx55Y4tHR6Xdk3y5P0AeDPpzhvSPofg2Gtr6WedzPNmlZILXO/uvHf1OOtmDZlqa bK2F1sdU+mN5yx2oA/std9B1q6jYJQfoKbM2KU1M0aQxs7rW/uvmq3H8QxGSSqrKuSpqZTd0kjiX E/kq6TP4Z75K2c9Rp55Eoro5eodH+olkNgRtsuBxFheTpBew72A3TsPiqarU2UmzvdZcrDSRmNgH mdid1xyT8kmz6sIKEVE99eCfxvdJeh+TqbBcYw6pocQYLzVTWX1Fdl9W/qp9N8x1FLSUeCVeI0MM ut0sotf8BasI6CedrjUMicOxA3KxJoXa/KEAZvs8G6xhisMtyZyzY3nVSZtixb6uORBkiemwXAq6 PFBHphglA0E29185kz6xeHYdSxU2O5SnnAFtcMgH/daxTQthZ6yHO92hLjieDYx2HvdeqWVPijxr SVK3ZtVx76wmWosHnGW8o1DMTdfR5zg2MH3IHK875a+pt1CwLqbLmTFKk4hh07rS4U02ja2/b5Xj oM8tln6QO1huihMELQXN1k8/CizUT4ib7Nm9b9Y6llhDsNyXpmb/APVk5/sureq/1Xc/Z5wk0OC4 NSZeLjczRkvd+114ahlbFK5w0mP2AWZT1dM5jhq0u/pWZZapxRh6TmvR7Jyb9V/qblqgip8RpqXF TGAC6VtibLmMa+sBnnFcPmpKbL1DQSvaQKhhJcCvDzKZst3Tlrm9rDdJfTtbq0RgDsVfP+o38OB9 5V+ITOGK9Q2Z1raz+JYzFKJIzPu1u/Fl6Pi+rR1XhwWGg/hlAyaJob5zWWO3wvGkUAiabnUXe/ZA +ie4/d5f4K8jtu/Z6YYUlTO1OtXirzn4gMYjmzBUhwjGmOMN+1YmQPEz1F6OgQYLjtTTwctj1ksH 7Lq84c5jjI2TU4LEqJnl2h13E+/Zbtsz8aB3R1D8X/VTq/hYwrMWZZ6zDg67YBZrQfm3K+Syd1nz 90/xDz8u47VYZOw3DqeQgf2Xw8czYwNbCW97LIpaqnYT63x34K7RzziqRFp4buUegYPqB9daCIRv zdUy7aS59i4/uurc8db82dUMR/VZkxuqrn8hkryWg/hfH1D3SO2frF+6ptOy4s0G66LUyI9Lj7SM hghqGVEk13vP2n2WI7DvOha2MnbkHhZ0UAj39uyawDQXN2uuEpObbZ6oxUY0ZmA5gzDlxopcPxie khcPsikI/suRkz3m4OtLmnEmhvF6h3/yvnDG5sgeW6rd1dRUGWwtayzGTj0YliUuzKxvH8VxR7JK zF6mteDs+SZxLVIsczDQxD9NjdbHG7ewncB/3XGuiu71DUD2RX1MaxupgBXSGWUebIsMEqobXYhX 1p1VWITVM3vK8uP+VxYqJopCPPmgkPOm4v8A2WdJCBJrG7vlBIHSbmxKss05ds0sUV0jjp6mo1+u R8hP9Wo3TaSE1T3NlcQANropoS4iw3BVfzWfv7Ljb9GtiFmndCXWJeDwGmxXOZKr8MwvMWHz47HN JhzJg6RjPuLbhcOXFrNbSdY7JVVWvqdN2ANtvtdS36Dgn2boOlH1GvD/AJD6e0OE0FVUYeKWIAUn km5dbdeX/Gf44un/AF7pDR4NhM5qYAWsqp2jda+DFcXYzZPgIkcIwwtd7lenT55aeW+L5PHl08cq 2vo5apq/1bQWN9V+AuPewzuOwY7gNdwUbXaJ2iMm4G5KN9IJ33cTv7KZc0sr3M7Y8SgqQ9kMr442 6GAjlzVmtgpzGNRMjxx8LHjhMcYawmyyKaIRi/dc3Js6eNJ2imQsY/WbuI90iSiqJJS/zQ6N39JF 7LkA0OKp8JfdoNgs2dKMWkwpsM1zYsPO9lc0MDI5GmPU6/pPsqdG+Nxs8odLr77qLgbY/hx0kL4g 5wsGn2SaYy1Eul5IbfkrkZYS/ncJXklp2WnJlpCq19GyRrQ0g2sSPdY5pHuIc2U6PYpz6fU43ARt Zp2vYLFijHfTx39GoOSX0buQ4hci2L4H5VGEtJ3uq3Yo4t0EgIN+PZci6qZUU4iLrEe6p0d9rJPl DVwidE2r2LfK+JugC7e5AWQxzWQgskLXoo4wO11b4gSNv8JfFChLIW1M4c+QX73TZ4m0UmpjtYcN 2jhAcPbK+9yPwrZS6Ra5P5WS0ZUtS2WnjjDdICADSdTdiqjjA53TANKjKY1caqdukSXZbhYYjkpn AyjWB2XKOO53S5GBwF91SGG2TU/W1ukrIfG+oaP5jmn2VmJo4T42AlSimP8ApwwAOGo+6vyA5tiN lmBoBN91bmBoFgtX+kowW0rAPtui/SgnYkW9lk7DlX6VAYUsE7Xh0ch1BNYyokOqZ9yPZZjGAt35 RtaHXFrK2UQ0zPbu8kKQwuG5cQsprPSR3U02KllQp9MHkEi6uSn1jfsml1juiLgdxuEKce+lB/p3 SHUjT23XJkXF0Ajb+6Eo4/8ATOaG6TpI7hXJR6nAvJcVmkWakuO1/ZRIIWAGN2FglyukDfQf7onX cOULWuI4uqWxJLy25O/wly63gXNgskNDnWVy+k6bbIZMDRpJBJN1cdH5gJ4ssry7k7I2tMd+EBiE kDTbhGf8pwi1gnukujMe5KAtrCRumGEXV2IjDhuFQcSd+EIAYh+boTFYWTXGxsqDkAh7HtHpA0oW xCxLhuskkWQgA3P+EKYr2XFgNkcENtynuaCfZGAAAqiEYwFOawAbBA3YfCc22gHlR8lCY0DdFezr kXQatuFcLvMOkn+6zRot0gJ3bpCp5bpu02WRNQao76wfhYboXtG/C2KGh7Q0WKheEGlrY7EXKhbp iv8A4SwU6xulWFyja8OYB3QuFrqEYp0Y5QaAN7JrxsOxQFrrEkWQgsMAVtsDwqcS1CHEHhAPFjsh mA08XQGRzCNQsia9zyLNuPdAY+kcKBoAWS+ndbWW3CUIj5u4sEBGx8bWRtBaLKOeGyWG6I8bhALe 8sabWJSoGl8oLzYKbFxIKJzDILhCURxtIQL6T3RBruSE64ZAG6QXHug1OAtbZBQs8cboQCmbkq7b ISgGi5TmgcJduEWr3CqZUM0XConQdwha43VlpcRcmypQiC43Vjmx2QknWAOEbwXW7KMDDsELrkXG /wAKg7sUQceLXUAbXXZfuh3vfhW0em5V9vlWhRQN3X7pTnueTfgJoGogDk7KP/lOLbbqAQXXQn1A ow1rCb7lCYjr1dkICERZ+6sgXCIboALdkBYWknsngb/CFwvdCmMb3VOJBsE1zd+FHNGxsqiCJWkA EHdGxuwPJUcCTxYJgaQ24F0YoxNRMrvcJrd9ztdLhaXPcSdH5TdOpw3B/ChkKInhDUN1GyJvoKEh z334CGhPk2vujYNI23KJ7dQuOQrAOi3+UMgs1PdcmyIXe65OyMhsMYJNyVkGNpgDuCUKhIZaQEG/ wmPN3BAyIsFwUf2i60GMMvpDWoNLlIyBzumAghGaOy42/wAvVqsfZXEHeUQ7dKDfUQNwFlQi7N18 dcH06vg4eqiLbkhIisDZcjiTbbBcYz7164Pg4yVDHWLVxdYPVtvuuVcW6N1xk93PNuFWcjNwqQt5 C5Vro3g25XDUIlEo1CzVyJs123ChoJ/FlQG2kK2M0jUTdvyiDQd7ICnNsLHhL0gj8I5Dfa6XazU9 gVIOQsZz/LJ2uSstw2SHsFibbqkHYJWOo8VieQLtcCCtnHgx61YDiFRRYfU1LaesYwNaHEeorVyx r43GRvqcOFyVDmHFMEqIKygnmpKphu18TrEFe3C6OOSG9UbjfGb0L/8AW7JLa2gaJMSo264xbdw9 l1T4J+i1bhWMmTFaYRvpn6XRG21l5Vyb9SbqnkTB48PqGQ4rAxunzJ23dbsLrgcL+otn3B8z1eLU tPFEZ/uij+0XX1fKpR2v0fHjpZ42zbJ1K8RcfTfNeF4NNRDyqyQRte/0jnsuG8SPRdnWfJ8eJ4S1 kWMwMEjJG8vFuPlageq3jGzz1rr6SqxZzaZtC4OhMAIIt8r7XCPqJdTsJweno8MrNL4AGh824Nvd W4Rpx4Zxnpskjbj4esk1WXOksWEV7XxzSMLHtk2IuLFdJZe8Dgk6j11di05fgpnMzWh9y+5vZeF6 D6nfWTDobGallPd+hYmI/Ux60V4Ihr46a+5DGcrKnJNtPs5ZNLke20bhsn5Kw7IdTJT4XD+modP2 Fv8A5XjvrjQ/6b8UmDTTTNgp694dGGyb3v7LxBJ9Q3rVVyPDsV3tYWbx8rq3Hetme845jGNYvjc0 +Lxv1wyPP/L+AtRyxg27NrSyk6kje91YdDUdHsWp5ZmfzKV0Wt5Fj6ebrwL4LeicGdsxYniMr2mD DKhztLXgFx1bLyNmDxf9X8cyp/AK7G3y0FrF7dnEL5TIvXDqJ0/kfLl/GKii83d7Gn7z8rz+WPRX ppKe5G8Lq/1XwPov06qqnFaptPDBEWsic4anutsAtGfUTOQzz1DxnMYadFVUOewH2JWV1K60Z+6o 6Bm3Fqirhb9rXE6V81hFIx7SA3+WO57pkzR27Ed8Omk8m9nIVZLg22wkC9f+CjJ9JjeKxOfMxlQx wIDnWXjmskM7AyM+pvC5nL+dMcwu0uFYpPhdXDw6JxbdeSCV8n1ZJ0foRwmClpcrRUk80Tomx6JA 5wtx3WnjxtdP6PpV1xqMRwKpiqMPrT5zvLdcRPJ3C6erPFH1YqKb9Ic3VL4gLaRId/yvgK7HcfzX iBqMZxOaulfufNfde2E9icU+z5EtLuyqb9GznwM+NbC5cPjyhmutjpHN2p6qU6W29ivWOZul2Q+p 2YqHMLp6CqqoNxJE9rtftdaBat76aoLYqssseWmxCz4Opmd8DY2OhzTiFPA3gMqHC3+ViKafZcun U3aNxfjc625GyB0omwSSro63EZG+THQwkOc3bnbhcB9PSbL1BkV+KzYhS09XPJ/ynSAFoWn6vxfG MwV4rcVxKevkJu58ry4lclh2OYvhMjn4Vjdfh+rtHK5o/wC6xK77O2HC6pm9LxRzZHzr0txvBMWx ujAnp3GNola71W2WjHH8HpcvY5V4fFOyoZHKW62G7SL7LGrcw49iDiypzFV1OvZznzOP/lYZwuJs EgkqS+R++sG5UnNqKgZxaZ48u+zmsPtFM2Vg9MZvt3Xrfwf+Lmg6U5qbBjPow+TYOvwvHNFUQ0lM IzVcch3dSSemxABnmRtcOCDupDo+lL7cM3pV3iS6M9TcGpzWZmowxhEgZK4AtKwMweLbo23A6rBK nM0D6R8Rie+A3sLWWjaTCDqvFWygkcNkKcMOmhg/mTSFp29RXojsqj5stM3KzcJ0K8YvTPBIa/LF Xj0EWFUz3CllqHfe0ng3X1z/ABe9Cem9fLJR47S+dVG73Qb3Wks0EMzDrJu0ch1ihpsKhq2usSQB b1blZnOLlYWlfFPo26598c3R6DMmH4/hGJGoxGI6ZS0W1N9iV9VU+ProvmLDI6nGKsR+XZw1i5Dv haYqXDaYzGJ3oHuCpWQUsU4gOp1+ztwSjnbX9GHpX1I3O1H1AujOO4XVYecebHTuhcwGX+rbhaje qGJ4FX9RMYrMCF6CoqHOZI0bWJXycuE4ZK3y5mNZIONBsn4bRxvLoGNsxvBK5yyfXaujth0scct7 7MsSNpK1jm3ex33L0/4avGLP0HxynkrY/wBRhFtMkY5aF5Tq3SmoMbdgP6lk00RERErxJfi4WD1u ClwbcMQ+p70erMPirHRz1NWwXbEYwXNPsvk8R+q507xTDaujqMEqnxyMcxjCOTba61bNigEthTtc 7uRsk1MMfmEsjDCPhelZMaVUeKWittpmxfpl9TfD8qwT4fV4e6aj81zoi+92t9l9pN9Wbp5Q3EeX 6gT3uXRtFiVq0hr4qtjmOgAc3a/CAtp9YAY0P+RdcXmtt0c/grg9PdZ/HljHUnqbT4/hLJaDDaVw dFC5xube69C5G+r7hdBhENNmPL0s9VC0N1wH7rDla6KrD6djYyyxJHqssB1JDTkuY3V/lY8l8s9K 0qij074qPHXmDxH1DcMw6B2F5didqZAD6nn/AKlxfhm8VFF4dMyuxWrwd9fPM3S57RwvP1NqDRIG hgv7Jko8p4Pma3Hex3C3LK5Lb6R0xYFjdv2bE8wfWA8+nLcOys4ECxMjuf2Xm/BPGpmnL/U+tzrg kLcK/Wu1TUzWgsd+y86zOElv5AdLfsLBZb8QewsD4A0AbtAVWXjbFGHpoyldnusfV0zRRxBhy5BX SkWLzsPzsutusX1J+o/VHDGYfS0MeCUB/wCayD7pP3Xlw4pTOm0xwBp73G6XJVkVTXxv1NPLCqsi jykZ+JBnqXpx9TfqP06waHDJaaOvpIRpYJBdw/JX2OJfV4zhXYbLDHl+npqgghsrTx8rxZVywyzt Z+ntfuQq00rXPD4bgDspLI5c0R6OL9n0HUTqzmvrdmWTE8drTLrdqA1elovwvkqrDGU2MQSRyay0 dj3XLYZg78UmjgoI3eZKbBrQu88u+A7qdmPCIMTocFmdTzN1iZ3P9ln7ZOGdYRhp0zoqj/4qRxm1 M9ivt8ndeOonSiYOyzjs9FH2AedJ/ZcnnTw0dRunUt8UwSr8nUGiRrDp/uvu8F8BvV/M2B0uK0WB SS09S3XGHkA2PGy28bVWR5Mc+D47PXjD6xdSsuy4Nj2Yn1FDL97Yha/9l1JheYMbwasZWUtRJBVR kFkrHlrgR8r0lP8AT66wUlHJPJhPkPYLlo3JXzeTPB71Gz7iNXh1PhNRFUU9w8vZYXXenVI8yjhu 2YGGePnrjgWHDC4sxTOpNHlguAc635XUuYs647nzFZcRxnEJarEJHanPkeSSvquonQnOvSbNbMDz Hhb6OrlkbHFrb/zL9wu4cx/Tk6m02T6bMmG0ZqTLB+oMLTchtr8Kx3Lo08WK7Oj8kdYOoHTZhZl3 F5aWI7mIu2WXmvq5nvqE22YscnrIv/pvk9I/ZfO4Rl3Fa7EzhklM79fHL5D4wLkP4svWeXPpf56z PlNuMVNQaaaWMSRwB1ja1xsVlZJbqE8eClJo8m01RVYdaVkkhdfU2VpsQVzkHWbqZh0PlUGbMRip wLBnnu0ge3K4TqJkXMXSLOlVlnGmvZJC4jS/uPdcI107GO8pk8jDy6NhIWZuR64xxTjx0PxGrr8Z xB9di1dJXVjzd0kjrkpVVStqQBNG3T+N1j4ZiUE9W9spIeBs17bG6zqHEY5RIJWXfchoK5OTb5Ok ccYfxMSiwqmlP8tpaG8uLrrk43xiRrYKh9POzdsrLgg/lYdMJGkxMb97tz7BdudFvDxmXrFmOPDM EoZHxkjXUFvpH7qRlLpBxXs68xLMOaK9raeuzHWVcAFmtfO6wH91w02FPjma81XmE7lwO62Un6RU 1ThAfLmqOPESy4j0elptxdeRutfhLzl0Dx2SixOhkraZxHl1VMC5kgv2XphjWVVF8nhbwwdtHT9Z U4lLTMY3GqrymDZrJSLf5XE1L66dtpsXqJmcaHyk3/yvf3h8+mpXdTssUePZgrjhFHUN8yKBzbve D/2XK9ZPpSYlhmB1OIZRxBlVUQtLhSuJu+3subirq+RKeLtrg1wx4MwWkdLYjfVfhXLUUrZBaFkk gFrkWBXLYjljGcKx+pwGvopYcQpZfLlhe0gg3svdvhP+mvD1Ly47Hc7PqKCiqG6oIoxZxHvuuUoS h/I9flxqFxNfcIMbCP0wJcf6CmsoGtPmCWamP+0PIuvX/jJ8GeDdBM0ZfpMoYhLiL8QkEbqWQ6ns 37r0V4evpi4HX5X/AI11GqJH1FUwPgp4XaRECOXLKVdnJZoSTtGriCnY+YPdI6Q37m65Cenp5AAB 23WzTrf9KnAG4BVYz08xKeTEYWl4oJLObJYcA+64PwmfTvgzbgs+IdRaOXDTHIYxRs2ebdyuriq3 Wco5IRlXs1uT4dTaQbekex4Ug/SyggSC3bay3SUvgI6DUuYBhDIRUYk1nmfpJZwX2+QvNfjo+nxh eSstOzxkiMQUtKR+roIxvp7OCsYqTSI88L5RrdqqelllcHRu/wDtsCxxh1NI0mCR+tp77WW2P6fH h26c5+6RTVmOYXR4lWSv0uZPYyM/ZdZePz6f9NkClfnvIFK8YU0j9bhkQ/5f/U23ZTbzsXZqWZJp 1weBqf8AUilbHUwsqoj/AL0b8JpGtGmneL76Gb2X1fSvpzjXUDNNBgVEwvnqphEL/wBO/dbe+jXg B6b9P8lNizFhjMZxR8euaqnJ/lkje34XCVxe1mp6iK47NK9HRwtmPlwOLjzYXIWXHLHDPpfqa7sH NIK2vdJuinReq8Q+M4PhtFSYhHDGXNiks5od3A91zfjI8GeWMw5Jpn5NynT02NCcAyUsdjoPvZei uVGRxWpSjuSNSboqx8fmR0U8kZ/9xrCWooMNq6vd2HTG3YMO/wDZbtOk3hpyZlboph2H47g1N+oh h11M72DUD33K5rpj026SY8KoYJl+irfIcWvmdEHAFaUYKLb9F+RuartmjSTAalvqjwqsAP8Atid/ 8Lj34bVvlEBp6hj3HZjojdb8q7/0xy9mamy5Pg+GQ1dV9gfTtAJ9rkLnqjotkOeZshynhcjib+Y2 nbe/5V34v/tOa1E+aPz4y4RLhb9FXSTQTEXaZGkXH7rJrMhZobhZxVuC1DsNb6jO2Mltvyt2vW/w WZI6j4WZKPCoqOuZbS6MWuvvcjdDMs4D02pMr1uCU1VTsh0StljB1fkrElicdyOnyZKWxo/P9gWB 4pmp5ZhVFNVSt2IiaTZPxnAMcypMyPGaCWj1/YZGEXXuboznTp50L8UmdMFxDDIhgz6x0NPG5gIi Oo7b8L3j1c8PmQPEd02fSjDKNnnw66PEIY2h8T7bEELOTEoSovym4bkjQxLXQSlrZ2udL20rNbI4 Q6SLbbX5X2nXrori3QDPUmDYnGS6GQgSHiRt9ivjGR/xMa2nQeRZcpY6PZhzLLG0zEmLmuY0Alzi s3CMs1+P4kyiw6mlr6+bZkMTbklZ+C5eqsexGCipYzNO9wYNIuVtx8D/AIOMN6WZXgzNmOjiqMeq GiSPzGg+U21+6wopclnl2KzUXmPIOaskSNgzDgFVhev7ZJmENK+i6d+HzPXVGklqss4NNiVPGbOd Ewkf3W8HrP0eyf17ydX4DWw009SGu8qaMDXE+2xuF548F89X4fc5Yn0wxumEFK+Quo6sjdxvsCu9 JRtLk8UdVultaPAbPBr1cgjaX5Nq4Xt3LnMK666jdIs1dPalrMewqWmc4EtJZYG3bdb8+qWeZ8jY PTVdPTNq5JZhGYrG5B9rL4zrX05y51h6R4v/ABbDooy2kfOyV8YD43Bt9ja/ZI/anJElqpRltRpc 6MeGjO3XeYjLOGvfBHtJUOFmNPsuwM0/T36z4Nh1RUuwiOengaS4MIJIC9M/Tg6mDK3UbFMm3a3D qxzxCy24c0r3v1uzbLkvp1jOJwQ+a+OBw3Fw24tdZ2OOTZR0lqG4b0z89uE5Ex/Hcw/wClwyaoxN svkugiaSQ69uy9IUX01+stfhUVXFg8QErdQZJIA5ot3uvaHgH6PYVVY7j2fqunjqa2snc6IvaCGO vuQu0/Er4z8D6C4vhuFSRulrKiQCRxHpYzuV6VjansgrZ5J6yse6TNOvVvw55+6Kyh2ZMBnooCbC p0kxk+118HhOIxSlzJgAeBdbrOp3W3o7196M4nTV+PUM+unJbFIR5kUunY27brSrjuG09HnDEqem mE9NBK4RysGzm32WMmJtXVNHXSalzfHKYdFA99U8Sm0d9gT2RTwimq7wj+U73VRCSteDC0kAgGy9 TdEPAXnbrNR09a1v6DD5Wh3myC1gvDSumfYbpHlWZxaSHvEfsRurp6iWNup72Pj/AMrYtU/R/r69 n8zNEURA2Gm5JXXeZvpUZ2ytisENPjUFbQzO0teP6fyvXDBGfClyeSWojE8Vyzx1ZHlR2ts4hBJB HAAdWo91sIoPpJZilZGZsdpoS4XdbcBKzN9I/NeHUMkmDZlpKuUNJMb26bm3Auq8EVxuOfy4Gv1j XNJFrtdwfZC/zQGsY4F3cnhbBujv0uZ89ZYmrMcx5+G1kUrovKDLkkc/hdgUn0hsMpWukkzO+qNj aLSRv+ViWKMXTZvzqStcmruCSVpcx1rnu0qmODNQlBv724XujOn0sM/YNmqmbgUlNW4XPKA6V7xe Jvyu78vfShyxQ4XAMwZmeah+8ro26QD7C6144R7ZyWqi3SRqthqo2SNaZtFu4KOaqjbKXCcPW03O 30lMkV+EPly9ik76tjdg9w9Z/K4XJf0w8lHBpIMVx6mhxmK4kgdIA5n53WvHjatM6POjWe2s1uG5 czuQVGzwySXLSGD4sts+A/S96bOpDrxySrnII1REWC8r+LX6eeJdH8NrMfy7ibq/C4WmQxltnAe1 llYdz2xfJyeshHs8kST05j8yM+ke6XPV/qm+VGLtI3suBoJ6iUQ0zmkFztJ1DhdndNunE2csz0mD UrgJZ3tYXHtcrzOLXZ9Jcq0fCU1FGxzo7uLj3al1UMTCWl51Dfdq3N9Kvp29MMqZPpazH6Z9fiUs QfNLI6zWm17AL6qm8JfQbMFK7C6HBqOWfu6M3fddIqL7PHLPGLpmjiGuhdGYdLj8gJZw5lQ9rgTC 8HuOVuMwrwAdKMAzy2gx1jZTW6n0NPGNIt3BNl2T/wDcP9E8tMfWVuW4JI72L5nHSD2XRrGcpZ2u UjRLWVTaacRubYe5NrrIirIqmQRGNrAdtQ7rc31m+nH0sz9l+pnwehfhFaIS+F8B9F7XGy025syl NkXOmNZfndqkoZ3RMf72NrqPGnHdEYdUsktjVMw2xiSs/TtF2kgDZe7PBL4EKnqfVMzFmmF1NgEd nNFrOm+AvEGAx+XjFM9+41gknvZb6fBvVR13QfAJYrWMYaQPhcl9Ud8rajaLn8OPSLAoqfC34Rh9 HK5tohMQC78X5K+TzH4PelGEzDH67AaSpo4jqlNrAAleWPqsZ6xPBuomV8PosRqaKOKnNQP07y06 r/C6R6b+OrP2MZZgyJib31uHTyNaayQ+sNuNiV9JYJrGsl9nwVllkm1XRtYwnw99LKLCoqukyjhw p3Rh4vDe4991jnoj0pz3hcsMeVMLkp2nSTFE3Yr7rpnN+u6fYE9z/NDqKMaub+kLgIv9KdEcIxaa pxKOCCWR9U9k0o1XNzYBeBSkpUuz2typNOkzhsqeF/pnlsTiiy1RN1tII8od1406Z9EMpUXjbxGg GFRT4awufG2Vosx1+wWwTpznWk6hZWp8ao4XQU9QToa7kgHleNcfldgPjwpm0g0tns6Ro2G43C9e GTm5qT9HDLJ4oxa5s7M8Y/h/yPjnSLFqyPAaWDGYw0UtRE3SQ+9t+1rLF8GfhIy70t6c0tfi9DR4 pi1awTOe6MPDQeAF2B4u8Pqa/odjclNK+KSmjEpLfYcro/6c3X/HM90uM5Sxz+ZT4d66CZxu90d9 wVlKTwNx9HWGS8rvoV9SXo5lKTpLDj9NgkEGORVDYaeWCINPq2AIC5zwH+FXCel2QqXMmN0dNX45 WwiUSuaHeW12+1+65n6ilVbpNh8IF2urWFw/dd3dF6FkvR7L0TCWebRMuR+FlusEb7N75PI4oy3V uSM4T1uB68PrpwNM9Hpa5zR8hazPqPeCzBOm2F/6/wAqsFLSzShk1K3YNcd9l7zyz0dyvk/qrPje FYu6XGqskVFMZQ7/AB2Xzf1CcAjxbw146+QX/R6Zmj8KwW2UV6Z5XldOT4o15+Ff6euI+IbKZx6p xpmHUbvS0EX3/ZfHeLvwTY54XcOosVlrYq7DamUxtlj7EL6Xwl+N7G/DrFPg/wDBarMlBWEvjo4G klp42ssPxw+MLG/EZQ4Xg0+XajLtDSOLzT1IIcXEDex/Zaemk8lJcHtWoe2L/TypDF+qfHKXgPtt 8rlpqYyGJh+5xAWBhlAAIXOkuWb6fdcnh8hrqtxbcPiNwD7LySioyo+vie6rNmH06PDFgtdhLM21 ojqpGm+hzb79l7e6j9YMr9JKjB6LGpHUv8Qf5NO2Flxf227Lz99MOaR/Qydkp1PFQbO/Zdu9c25I xPGcHpsyiJ1ZA8PgMg+03TDHyZFE+ZrHti2mcZ158NOVvEflqGWeNmH14s6HERGNZb7FfT5EydgP h26WR08VhSYfFqnqGN9UnuflfeUbaOfAaYU+l9IGDTpO1rJWM0lBiWX6mKYRz0TYyZGusQQPdac2 /q+jyKHFruj4Ppr1JwvrlhGLA0sk2EXMHlVUVvNaRb+y11+Jzwf5c6U9bsOjph5eXsdmEtPRjfyi Xeofi62K9Hc9ZOzZLV0mV4Y6d1G/RNHGABcbFebvHxTPb1X6Z1EgtSSVrInO9vUOV6sEZLJ4/RzT W3yPs9YdKMm4b086e4XQYfTtpqeKnD3BrbE7XN14Ezr1AofGf4q6LIlfCKfK+BVBDg77qhzDuti+ I1IpcmVMjDdsVC5wt8M2stTvhjrH4T4rKKUAiorcVksLbuLnLODhykdckk5RSZs6z5j9H0P6Zfq8 LwzzKTDY2xx0kDeWgWSul2d6XrbkL+I1WGCmpKoFjqadtz/lfTZ/qaGjyrXT4lAJ6OKIuewi918h 0E6h4BnjAKluAxiKCkkLHMDbWK4pXic/dllXmUbPo8kZEwfp7SVlHgrfLgkcZDCCCQ5dHQZv6sUH XNrqzDpDkeRxi0RD1N9nH4XfWFYHA3NlZirJ53STMDHQv+xtu4XS+NeJiWTxAUfTihpWR+v+fPK2 5c3uB7LOOMskn7OOaW2Cd1yZnjabhlX4dcbixJrTHOwBmvkOtcLX94DfE3mbKGcKDJXnmbCKys/T shvfRc8/C9/+ODILM8dAcb/nOhnw+M1MWk2DrDgrVV4MaCat6/5ec2JxMFV5kgt9rQeV7scIPSuX /tZu5SzbFwqNu3ib6SYN1S6R41QYxAJHUtM+ohmNi9jmtvcErXD9Pvp3l/EevsrcVp2VBgkL6WJ4 uCW33K2t56gjxbJOLUzn2jnpJG6/y0rVt4G4RD4tZMOilD2UM0zXkOt7kflc8K3YZJlhxqaj1Rsl 8QGfMS6Z9MMXxzC4GSSUsDjqd9se2xstYHhE8U+Ms8QEFZjOIPqG4pVOjqZ5X2Ghx2b7WC2aeKDA q/M/Q3N+G4dEZ6yahkEcY5dtwtMPhe6RYt1M6wwZXpoZYZqaoaKpxGkxWduf8LGKKliY/lqGr4Rv Wx3LWGZxpKVtW1tXTxubMwGzg49ivhvEJ1GoOk3SzGaxz2Q1DqZ0VJG02JeRYW/C7DyvgkWWsvYd hcby9lLA2HW83LtItddF+M/pJV9R+nMtZh+qerw5rpP0w3D29/3C8uFqU1GXR3zQUY7o9j/BVmjF c4dJKavxac1EzpHWcTfusnrNkHGsBrq7PGXcwSYdURx6p6Uj+XI0f+VwfgKpzhnRSGilDhLHUPBL v+yx/EH1TzLVZyb09wTAZKmlrIf51dpJDbr2yhepcY9HllKMcCaPuPDT1jqerWW6qeuDf1NJJ5Tr Dm3ddxvZrt6Rt2K88+GbojjfSGWu/W1rJKOs/mGFvLSvnPFN1OzZ0m6g5QxHD61zMEr6kQTQjYG5 XDPjj5nHEzphz/6k5npvHaJtbg9bBw2SF7T+4K0Sw5rxXp34hMUnwGtdQzR4sYtcZIuNe4W9ZlaM Ty758ZsZ6a4PyWrRlX5FxvHPFLiWC0lFJU1MmKyPDY26uHGxPsvRooqp7vRc+xSi/wBN4eVppcTy phk9U4TTT0jHSHs4loubLRj48MFo8ueIbHYqWFtOzzy8xt2Aublbwen9JXYJkHCKXFyyOspqZrJb HZth3P4Wj3x+5ipM0eJLG6qle18Ak8vW07OtysaaW1TdHPIv9sIo6HoqrViAkADmWXuD6a2XcCzZ 1OdTYvRR1nl3ljEgvYjheIKLyzO+KOx0r2f9MutP/rhRsi5s7Vb2Xicr5R91R2xdm2zPlJjwyxNH lSSCmxONv8kSt9FvayxenMePVeVGR5sYx+KPJbMwNGgj/wCEPWLN1Rkjpvj2N0eg1dJTOfFrO2rs vi/Cx1exTrJ07ixvF4Y4qxjzG/yhZriO6qT2OVHypteRRvs4fpfkzDsp+IHNkeFwClpTA2R0bdgX m19l2nmPAcDpqt2P4vPHAynYS6SZ4a1oHfdfFYPgWI0HWbFcSLRHDWNDRfYWC6Z+pJkjPObOm9LU 5SrKiKkog99bTQk2lb82XoWPfkir7OMp7McuOj5/xveL7IVL0rqMAwPF6bG6+uvCIqd2trR8r4n6 RUZqaHOdW8nWZGtsewv2Wq900s1VM6fV5scpBZfuttn0p8rYrg2ScSxCajlp6KrfsXttc8/utZqh HxxPRgxPa8sz7/6ktcI+m+AUzyfLfiLHEc7gr0Z0mpdPTDLzCNOqijdt/wDZBC6K+oZk6fHOjP8A GqVj6iTCZmzGnZy9t97fK+58JfWTBurPSfCf0EzI6yhp2QVFK538yMgW4XOn4U16PO2nlafs1DeN TFcQo/FFm2so5ZGVdNU6WSMeQWn4XwnUfxF9VM8ZPp8DzHXVMmEwgMYXbNcAOCe62e51+nzh2dPE JX5hrKl02C1rv1cweLkyX+0JXjV8N3TLK3QOuBpIMINLETDI0AOe8DZfUyThsjHG7dHhwZNknvh1 xZp4wenbLENJNhub913l4TMFoMZ67ZYgrY2yUgqGtLHcXuujsBbHFFKHS6Wl+lrj3Xa3h4x+DLvV /AKieXy4oq1jy88WuOV8LJJvs/VwXCZ+hTD6OHDMKp4KdrIoIogGgCwAsuHwvF6Rzqj9TjVDUXeQ 1gkaNI9iLp8OKRZkyo2pwuWKoZU038pzH+kkt915Byr4BqitzLimLZtzXiphqp3SxUdDUlrWXPdy 3igpLl0fG1ORwmqjZ3rDn2iwXrlT5XopoBS4hSGpkMbg4eYDwbcEr7fqX1Ry/wBJ8tnHcxVX6XDw 8M8wC5ueNl54yZ4Q4+mvVCixnAMWqMWpmu/mjEagukjF/wDK7n8QvS2n6udLMZwCoGmV0Dn07+dM gGy9GWEVOKuznjm1CTRh5u6pZDzL08di8mYqaloXsE0NQ6QBwd2Fvdcx0bzRPm/IVNisr/PjdcRS AWL2jgrR3kTJ+Zcb60QdOK3G5nMbVGCWN8xEcdnW4vZb2Ol2S4+nfT7B8Bhd5zaOBrC8G9zbcreo hHElFOywjKctzXB8DP4qsj4Zneuy7i2MQYZLTCx/UuDfUuxMlyZcqaJ1RlyWnnpal5ldLTm4eTyb rVH9VLp5h+R+suHZnoaz/iMejH6mnDiNBabX/detvp0+IXKueektJl79ZT4fj2FAxSU80oD5G9nC /IXOePbBTXsY3KatnKZz8QWPZY8XOG5Spw6pwmtiEb6cnZp/3Bd39cpaihyLJiEDnMfRObOS02K+ ZxPw3ZfzD1kw/qMK7zsTojdrGuux35svr+rGIYLiGVq3Aq/HaPCJcQb5THzytHfsEck3HYvR58cH DdvfbOTwLN75undPj8sZlP6US6Gbk7Lp/p344ch5yxTFMOxSpiy7WUL3NcytlDQ8Dvuu58oQYdhm U8Ow2KvpqyGKnbHra9tpBbnlaY/qOdO8J6cda8QnwyqvDibvPcyGS4jJ5C1gxwyOW70dss8i2xg+ zgfqAdVcudWOutZU5V0vpYXaH1EYAbIRtfZdAyvbBRSMtd1gAfdcY6nklfG+nBax27nOXIz6KLS5 /wDMaW257rzZZqTqJ9rTYnCNM2dfR6gYcDzPNK3/AIgabH/pJXeX1Bcz4tlXJeC1mGTPpgKtrTKw kWJI5Xgv6eHitwfoTnipwzMzv02C4kAxtU0X8t3a/wALaBmXPnRzrFgbKLFMxYXX0LnCVrZpwwA9 j6uFjFPbI8etxuVpH2/SyskxXprgFTVO82SShY6QncOOndfG+HvF5cZfm2awFI3EpIoAB9oHIQ50 6+dOelvTuunZmbDJaajpXMghgqWPJs06WjSvPXgt8ZfTrEcCxHDcYx6kwOsmrpJohVyaA8E35K9G 1tSfo8sP/VezvHCMQxGj8RVTg1RVPmpjT/qGscdgF1l9UBrW+H2apcwemcNB9rrg8S8Z/THLHiax GqrschrKWSjbTw1dMNbW/uvh/qKeJrp11D6GfwLBMfhrqiaVswZFcFthxv8AldYY5KcXXBHF00/0 1eUIaKEyOsSOLrvTwV5gocK8QWXpa2YRwmdrQ5xtY9l0Lg08bqYFzg4OPAWTTy1mC4hFiVBIYpoX h7HtNiCCuGqcfK1Ho+5itYf7P0bZ2oI8YyRi1MSJIZ6N7b9iC1abOkvgYzD116n5igljlwTCo6t/ /FStt6dR4913n4W/qf0GCZeiy31OjlqfKaGQV0YudI7PC9GU/wBQ3w+YTRS1dFjccNRYufBBAQ5x /wDJXXT5ZYk6R8DNDJHIpR4PhPCd4ZmeF3rzX0dRjf8AHIp6QiCUf+2T2Ptsu9fG9mzOeTOhOJ4x kmf9LiFMQ+eccxxdyF51y59U/o3PmivqK/AaugaH2jrfKDnSC/Nuy5rrb9RTopnbpRj+C4di801V iNI+FkUsNrE7fKWvLGT5R0c5ZISvhnlTwXdQ8wdRPERhb8wYrPilbUTWa6Z2rV+Fs/8AFNlepzV0 NzDhdFEZpDTkiNo3Nh2WhvInVnE+mOeqLM+Wn+XPhtT5kRf/AFC62g5G+rX02xrKtO3MlLV0uNeW BUQsjuxzrb2/yuufLHzqUOkI43jwP9Z3p4GAaDobh+EVDPJq6N72viIs4C/dd/wTwzTEx2JafVZa /Kr6tfTbAoJ4cGynXazcNc0NY1x/C6T6cfVWzNlnMmMT4nhEVbhdXUmaKFxIMbTwAQvNlfklKf6Y xylUY1Z6qw/Dc/YV42sQxNtPJBlqsYGGSQnRI23YLt7xpx0Unhuzia3T5baQubr41DheVovrEZJ8 wHEMnVkk4+18BG37lebPF39RbF/EJhLsr4BQuwbLE1vOL95ZT7E+y6p24ySqjDhJbou3Z9z9Mzw5 ZN6y0eYMSzdhrcUZA8+TG+xaLkf/AI12P9QLwjdLul/SarzLlykiwTE4iAynY7eX8LXb06639QOh 1Z5+UMdnw+KSxdGw+hx+QuQ6veIzqJ1tbHPnLGpMQDG2bEzZg/YbLm8rlkbkz2+KTgtqPg2ME0UJ /qcLlMkjfSOBuHW3shwyikiom1LyXB3APZZMTAdcpN3W4K8k2nJtH1sdxikbBfpUde8ByljOK5Qx SeOjmxd7XQTyvDQ6Qbaf8r3b4hej9d1ekwpkFVNSU1JKHl0J+7e/ZaAqWorMFxCCuoqh9JPG8Pjk jdYtI3uF6uyR9UrrFkXCYMNqJqXHmQtDGSVcd3AAWAuNyumGbxtSXZ8vU4Z5U4y6f4bcOofVTB+g HS6nxjHJNVPRxMi0Fwa+QgW2v3TOlvVvLPiGyG/EcFqWupKhjop4NQMkRPYrR91/8XfUHxKvhZmG pbQ0jDdtJTemIH3svlejfiG6g+H7Mb6zKWLvhfNtLDI7VHIP/so3cv8AkxGGSqa46N8HS3obgvRx mJS0VTJUNqpjUSS1L/sF7kD4Wur6iviXy9jXVbCsPwWdtZPgrw+SVpu3WDewK6L6k/Um6y58wOXB p69mFQSN0Svo26XP/JXlqqxCfE56irrJX1FVKSXSPN9yvbDI8L8j5Z5/A3cUqRv/APCd4l8A8RfS 2ldh1VG3HaSnEFZQudZzHAWuPgrx94reksXhV6hZc6n0076qkmxQS1kTRu27rmy1tdPurGbek2Ns xXK2N1WCVwFjLSvLdQ9j7r6vqb4qOpPV7D20OaMfmxWlbxHKLrzQy0237Os8E2416N9uSOoeTfEn 01ZVYRVwYlQ1sGiSBzrPYSNwR2TMOw7L3h46XV7xJHh+G0DHzkveLX5svz0ZE6yZy6aTeflnMdfg 7jyynlcGn9uF9XnXxUdVuo2BvwnMGbq3EsNfsYHvs397JGdrbfBp4pN7vZvH8OfisyV4jKGqnwKv a2tpJDHLTTHQ78gHkLCzx4a8Jx/rPh/UCTEIqGtpy27H2Ou35WgnLuccwZKqmVuB4xU4VUf/AFaS UscfzZfXYt4k+qeM6WVuc8WnsLeqpdutQybJXHg5T0rnHbJWbp/G54jcpdLek2K4LU4vA/G8WpXU 9LSxPDnm4tc24Xmr6YfSfIEmBz54xjEKaqx6CcugbUSNa2n3537rVxjOZsWzHUCTF8SqK2bgSTvL yPwSn4TmfMWAUU1JhuMVFHRTG8kcUxaHfJAVlPbDYjqtO3LczcZ9Qrxl4R08yPPlDL9bDXYxisRZ JLBIHCFh+R3K1Y9EuuuJdEuqWF5tga6VlPKXSR//AFATvddX1NVXYnViWrqZaqT/AOpK8uP+Vnuo /QXTn+Vp2aE8iWPYkahgqe6XLN/nRTxX9PfERkc11PiVJTuMNq2grJA0suNwQeQvOfR6bot0v8UW KOwzMVBHTVTnSQOdI0RU8hO7AVqKw6evoBI7DsQqaIO2c2N7m6h82O6Cnhc+Z001a4Tc3DiHX/Kx DJtTX6Fp2p7/AGbrfHB4yMFyJlekwnKuPU9Ti1TM10ktHKHeWy++4K7D6ceMHpNnbIOGRVucqFtW aVjaqCpk0u1Ws69+VodqKWoDY5v1MlRG7kucXFPOGxSRtfHI4+7WOIRONIz4sjk+eDfzlrrr0byR h87aLN2Dw0sry9xZK0LEpvEn0Hnx7+OMzhgrcTYwxtnfKA63cBaETSshDGGWoDXcgkkBYtTh8LX/ APDvdIQd7Eiyw5KTsscMoxUUb28e+ol0Oy9jJoJ80MmmFj5kEZewfuF4v8b3i+6d5/ztlTFsrYs/ GI8MmZLMGNLWkA3tuteENKKlrg7Uwt41d1jfw5wedUd2e69EJY4fZF8EpqpG6+n+pr0mqunE1Uap 9PWNo9Apdrl5bawt2uvGPgS8TeRenHWLN+Y831jaIYnLJJBLI25AJJAuvC+I0cNOwFmok9kfkNNO xksYa4cOBsVzjm2XXs6SwqXZs78W31PcMzNlqoy508MzXVDSyauO3p9gtalXiVRjuJS1VVO6SeRx c57zuSuLDHRODWA27krOLIxEHMdZ55C3HM4Q2xOcMFS3MbVyugj1MvJb7rLuDws+I53h0z7T5i/Q ivp3ECWNxsQF0yKmWH0stY8gpNVSvqiCR+w2C8klZ793FGznr19VnKefOl2LZewXA6oYliVOYTJI QWR3G/5XU/hj+p5X9CsjQZYr8vw4rR073GMhxa8XXh2KlFLI12g2Hc7pdWYqiovoAHuFtTajtPL4 Vu3m0jC/rHZbir6iqfkF9NNKPXLFKNclvdfB9bfquO6n5AxvL1HlsUTMQiMLRI7UdJ5uVry0Rx7B lwnQ0rZbu0tFhsF3hnjBqVcnN6ZSTXpia+rfUP8AOIt6tQaPdexfDn9TbNXQvK9Nl5+CUuK4dA3S 0HYgLx6SR/LdHY9kTYXRmwhaQe5G4XnyyeaW5noWNKKR7t6wfVlzP1HypVYLhuW6bBTUN0uqC8vc R+DwvMHSXxJZ46P52dmnAK57KqR2qeDiOYX4Le660/h7SN36TzYqqmkYY2lj3NeObFd3nkobV0ee OkxKTk1yz3Ri31fupNbhwhpcFw2irSLGdzCbH4C849YPFJ1D69OYzM+JPngBuImjSz+y6egie4nS 7S75WYJpXtELnD8hYjlcUPiY7tITVU07qlup2iK1rgoX4fUQ/wA2J5s3cH2Wa2IhoY5xcB3Kb5hY Qz/2yN1yk93Z7oxUVR2b098aPVvphh8VDgubKuOniGljJiXho9gCvu6r6jvXLE6CWndmYsZK3S+R kYDrfBXncx0oB07n5SpY43xlrQB8hbhLaeWWnhLlnZeXPFp1UyzjMuIYfnKvZUvcXOMjy5pP7r63 F/qBdccbwetwyuzS+opKqMxva1gB0kWPC6FEEYi0Nbv/ALlbKO33HUpvv0ajgj0ZGE12Lx1zMRp6 6SCsa8yCe+4d7rtGp8X3WSlpYaB+da8wxN0N8qXct/K6oNXNTsLALsVR1UbyC+L18XK1HK4u+zbx Jqjmc0Z7zH1AqhVZgxisxPe9qmQuAXD002I4XVifDayWmfyDG8gj+yfDLojcxrNTHdz2RRxaXatP C1kzvJ2ZhhUVVH0VD1i6iUjBGzNmKxxjYA1LxYf3XFV+P4/i1Q6qqMaqppzuZXzuLifyUtk3mHS4 CylXTRmMN0/uFzjkoz4IXZy9B1PzrRRNjpc34rTsZ/QKh9v+6+exTG67MVTJLXYq+tqnm5lmcS4/ 3Vwtja8t34sUmXD6YvL2R2f7rW++jfjihvltiojG0kl33H5Sv0sTw0u+8bA+yyI4zoa125Q6A8kA WWDoYVRQmrlMRdbSNnBY5ppaRoe2Z+kbeh1iuRljkhaDHv7k8rHEpDS17bn2SL2uzLjfYmd4np7w ule/+rWVjGnErWndr+DZy5NkhiZpDAGFY5gJJ7JLJJ9sixKPRx8tMWStZq1X5J4We3DxStEjwHO5 HyqLHH0n+6bHC5trvLh7Fcuf03tTGxQST3ke4gOGw9lX6JrGlpcSD7rIjeALXVTAFo3Cd8s3SXRi 1mH0rWRNhaHvP3G2yxJqIU7wHN0fIXJOHlWMfPygnqjMNMjRdFJx6I4p9mAymaI3mVpt/SSFjClu /wBLRb3XIPkkd6T9vZJ0Ft7GxWbbNKKSFUkZ0yeaRb2smtdTyMLDHptwQpFBa5O5UdTg79lSUgXU 7XM0skaCfdOjdFSRhhb5hPJSTA2w9/dPZEPz+VrcYoT5AmdqLLflOio9Lw7kDssiKL3WS2Gw+FtS ZNtiYYbXv9vsm+c0elrdvlObHYKOjaTcAXWW7NVxRjsc0S3ZEIz7+6qWHUb3uU/TpN+6h5NlCmNu w3CgAdtbcpxbcWU0EHYInyP+TGdFGWFkjdTViyU8bW6WggDdck6MOO+yW6JpuOStNikcRJEZWkOc bKR05Y0NIuBwuRdAFTYNXZZIYga4NLeAUApG6g624WeYrCxG6ER2KgMXymuJLm6vyh/TNDg5rQCF nGMAcbKwywQlGG/XYg3seyjZCG6SPT/2WU5l1AwCxIUfZaFRRkm59Q907yNZvYXCNlr7cJrTzZUo DQSOLFU6B9tTCQ4JwcGbu59kzzC5uzboDE/XTsFpWByZ+opqhgEtOGuHBCZI0HsFiyN3AAugMlko a707AIJXlzy5A1ouASgliI31ILCY95da6IRuJ3cT+UFO1zTblZLjzsgsUItiVZiIAsVbH3duE10r G2ubE8KgQYQ8C6EUw3uNisvQDxsqa4F1koUYsVI2J5IB/dNjpW6tRYCsptieERbZSqFCmw6vgJnl hoHspqsNkLpOO6FooRB52VOj2IKj3Pu0tNh3QTShrjuhKB8puq4WM6n9ZcQD+yd5t9kTXgcoDFdF 6R6UqVjQRdot+FyDtxwkzM9OzblAIEY03DfT8IwwdkxpszSRYK2tAsCd0BZ3iI91DKRE1nsoNNrF R1rbIAfMNx6tjyEx0Yd8JVh7bpmpzrWULQsMOoX7JmnUblUbsIDtrqw634VICW8pbwGpkhFhvYJJ eADcXKAWCOe6VK71A6bppIIKHkfCAERcH37KnRhp2CMbK73BuhBPl6uBZC6K5BJ4WUG8K9htyhRc MBdIX25WWyOwRUwBB9k1gBNghOSRsDQjEmngXChIGwQiwIJQ0g3uFhY2JU83TH/1KtAO4VEm226F BuTYlUSBdQtLxzZEWjSBa/ygFB2rulPKc6MAFIc1DNCu6gbr7Iwwi5KbTi3IQC2gC4sq8oyPsDZZ L4O4PKU6Mt4KATOxsNu5WNptJfss5z9LLnc/Kw33cdSAaLECw2Uc2/eykdwAAU2WO4FuUAEL2eoa t1TgBtb91ZporA8OREN0oBdgp7W4VnfgIgLtsgA0FxN1BSkSt32RtbeUE3sBwjcDqQGNIAHO9rq4 7i1lflm+/CsNu+4GyEI4/KI3cBc8Kgy6LTYIAS27TbcoGv0bFZEZ1BwAsUt0GoboUtrHuFwdllwt JZzukwBtO0gkm/uqY/1Gx29kBlEWF77qEFyjW+m57qw4hpItshULDQTYqnCz9NtvdG+Rtrk2WO+r u3bf5Qowkg2PCtoB7rHZUEffuEwSA/CDkqQ2Njwkub6dN7hSeU/aBf5QBzmgCxKDogZpvYXUGpgJ b3TNB9tlC1DIpnlxgl270s+o3I3TXht+FR37IBV7bFWBsiJF7qnXJuAgIxpHayqSLVa/BTItRdYj ZNsRsRcIBBAjbYcJZcHN25TZhpOw3PukAboCzx+yWAALJjiLWQlqEoGygNuyPsFVt0KURfdXa4CK ylrICrahYn0o4wIthuEFkVz+6AYXjSTx8Kog4G+4uqBDnAJ4IOxKAovc/cnhW6pbINz8IQwMDjqu CkGMbAIaHXaAPZVI4tsOWpcgLgGqBtha90JYT9O1kNrncqxwq90JZVvUrkj1N5UaPV8KpH6ULQl7 dLgjaw31OF2+ysi4vyjD9LbHgoSjIgy3UYs4Oj2asyswtuF0zYiLvHLkvCcYfQvIY429li4likld K4uO10FEfIGM3t+yxJHFxudh7KXO3f8AKB7Hk3J2KtAg54RkG26FrwPTbf4V6t90sCwwEko9OkKr e3CJ2+1t1ATtbull2g2vdFovsdipFT6HOJOpAUDc7BFa/ZG2LfZU8FrrFABpVlqHUSSeyJtt+4QE DVHOLTsr27KFwB9ygLifeS1t0x7w3ayFnN7bqSAH8oCHcghGwF5teyXyB7hE95sC3+6AbYt43VO2 BI3QMeXC5ROdbYK2WynP3G1lZfeO5F3KnusQOUDnaHkuGyhCCzhxZxVtFtio2RrxeyoP1uIQFkb7 qm99lUpLW2CkJBaS7kdlpAIXKo3JSzMWuJ4CplRruSLKMBlp90LmElLD3OdccJ7T3VQFj7hfjujk OxaDcdrKpAZNgLK6Zum+q6AS6IObZwVBrIxYXF0x7ryeymkO3WTNAAA8blXYlTSGlQbv+EKibAbB V2+EZaSr0e/ZClFt22IVg3s26pxJIAGyMxADblAWBa26po5upYh1uys8/hWyFj7b90QcLcIRxuhs VCnZkbi6Rzbd+Vlj0s3VOaxhbpF790TxYXXyUfVqjiq2XVIRdYkbA2S/N0ddqdMSPSEtklud17Iq keebsOdzWN33v2XEVDyXjQLbrkpn6hZcfPG5zweAtHGzkaNhdG06t1mPbpAubrFoAyOPnf5WaJWP 22UZsS6TU0NamxkmOx5Sjpgd7gpTnOJvfYlQDnON+RdTWHNukvBduCgdJoFrXSgNkfYJbnXbsqdK 0s+bJQksw32SjLAmqDTwucz1PHAUwpldi1W3yo3SOOwY1t1jGF1VMNJNh2XtDwm9DqLFKeGvqomz VE1tNxs0LtC+kcpz2qzzVS9BeoGYYnTUGDSzwjcnSVxr+iueYZHQjLlQZW7ENiJuVu0pcIwDpDkF +J4rDFHQwM1SPsBcWXQPSLxSZXz11ckoKeigocPdJpjmkYCJLlfTjhqNs8D1jujVoclZowmuFHX4 FUUMj/t8+MsDt/kL7aDww9R8SoI6mgyvU1UEguHQtutx/iY8OEXWzBcP/hcFNTVFMQ9s0bQ0uH5X J4LFH0U6KuqcZijBw2MghzRd1tgtxgmk7My1W30ag8v+Cbq1i8IfSZYmb7h4tZZWJeBnrNQu1uyv K5nu0LbL4YetruqkOJsnp44Hxu8yFrO7VxPVrxVVHSrP0eC1eBzVNC4jVUMjuAPyunjbbgl0eOWt pKUjVLR+Czq3XzeXHliohk7OPdfI5t8PmeOn+PU+H5kwuaiqJiGxu0XDiey3s5E6qYD1FlhkwmSB 7izW6PYPb+Qi6tdIsF6rYI6lrqWEVkZ1wVL2AujcOCFmUYxkozVHRap02jTHVeCDqocAjxygpGyU bmeYGOFjp7lcB0j8M+aOr2K1mHU1Q3D6mkdolBGwK3cZTy5WZayLLhdc5lW6lp3sY62xFitUWTes 9d0Y8QmOVsEInpn17xLTHgi6jwxdtejPy93B1h1s8HPUno3ROrcQj/imFgX86EE6R8rpbDMTY5jI wCwtNng8r9AGT8Xwbr301jrKiiifTVcZa+Fzb2Flpw8aHRag6MdYq2mwlpbQ1JMjIz/SSeFxeJTV xO+LVVNQkdQikLZWviF2Hcn2QPa7WXMbuTY27rHwqSpj85sriWlvpHyu4OgfTdmfsdoKOdpcDKC4 +4uvKqs+q3xaOS6KeEnH+r410jDCZBdpeLBZHWvwRdQei1K3Fq2nfPhfPmxeq359ltq6VdM8M6U5 L/iLoA1lPCHlrG7kALIy/wBU8m+IKjxDLoo3zwuDopWTsuGnhevHH/2q0fKy6jbwuzWh4W/BTh3i CwiasqKoUlZAP5kBtqA97Lvir+kPgVRG4zZikgI+0AbXX2WWenOI+Gnr9h1NhdQGYVi0hYSftcwn iy9N9dsKzPjOWqf/AE1UmCVjw6QjkhehxcJrb0zySzuUXJ9o1beIX6amZejeWp8x4HiQxnD4P+ZC xpLmD3Kd4RvCVgHXiAx4rWmmqY9nNatomIwOpei9bDj00bnvo3tqJJeDdtu610+EXNJyt4gKjD8G n14f+qLT/tIJWZ1Jc9oxDPP2+zsLqj9KXL2H5fr6/DMd8n9PGZLyNtwvJvRTwi1fUDPcuDRTOqaS KVzXTs3FgVuB8SNfJSdD8y1LSWOdSOF/yF5++m7lmGnyni+JyNa+qdIW6jyLlZpyx7n6O3mcZ0cf hf0vun7cJi/iEhkqtIuSLbrorxK/TBpss5emxvItRJJVwtL30rjcOt7Lsf6j3X/NfTPN+A0OXsRd h0bR5kmk212PC+Gyp9UXLs+TzhuZqOpdiTIHRvlafTI62xXbxPHBSb7PNDU5cs2oejXU79VhOIT0 dYwx11O8xyRkbtIWWzE5GajPd5/papj2LjMeZscx1rAxtbVOkjaP9pddcjhuGNxCtpYiLukcG2/K +c++D78b23LsxaOY1DjI6I2PsEQbomvFG4A9gFtF8LHgayljWW4MQx2lFZ5jQ4tI4v2XfOI+DTo5 hrmROyydcu2tgJt/8LoknwzzzzqBpDkhbWuHlNcJG87IXYY8SB0oLiPg3BW2/qP9PnIeBVMWO4dC /wDSRSB81NJawZ33Xb2UPCR0dq8Koq+lyzSVML2BzXOF2uPuulKK3HL5NujRPVRvpZS6op5WXNmu LCU/D6SvnDjBSzSg7gsYeFvvxjw3dK80UNXhbctYV5jWFhdHG3XGSOV1j0n8P/TbKmYsVybV4JDP WxEvbUSAephPAW0oNMi1T9o0zMoMTdqcaKXSOfRdY/6l7D5bqdzSefSQt+UnQHpZlfR5mW6AGZ23 mtBJP7rrnqb4E8iZxrqLEMDwqmwiQSa5vKHpe38LnUWZlqmnS7NM4wiskbHJTUNQ8EctjJBR1+D4 jTRtkqcInZFa+sxkWW9Cv6c9N+iuQZa2ty/QyUlFGDJK+FrnE/khY2V8mdJ+vWThW0WA0VRRTghx ZHpLD7bLaitu6uDK1332+zRxS5Vx2tp/PpMOc+ldxIxpN1yGH9Hc2YrC+ejy9XVZH9TYHBblei+Q shZQzdjeUo8IpZjBJrp2TRh50/uu76o5ZyzPDSPgocPMtgxnltaCVqcYxlto0tW9u5M/OZiGGYrl eskixehqqR/Gmdpbb+6xqScxtLyTIy91u38afh2yb1J6aV+JzUdLSV9PGXsqo2BpP7haS5KU4dXV 1Aw+Y2GUxtf72Nl5ckKW5dHfT53mltaMzzjO1oaNLXcN7r63Aek2bM1wh2E4HU1zR/VHGSmZCy3S V+bsKhqTeMkFw7FbsPDFkbA8rdMYaukoYgTHrL3MBJsFxi7Z7MstiNPOH+GTqlVUrpG5Wq4iwE+u MgFfOYb0mzVjma25edhlQzFzt5AjN/2W4bLXi1wXHupMuW5MOjipRKadswbuXD8rluvOCYDkGTCe oVLhtPBikU7InPEY9bSe698YLcoyXZ8n5Tabj6NR0PhB6mPxg0cGWK2aXu4sIaCl548H/VvKtC6u qcqTiBjS4ujZci3dbw8YzEz/AEI7H6CGJ7hTfqbgAX2vyuP6a5ti6rZDhxGqpmtbOXRvicL7DYrp UdtuP9GZ6uSdRPzwOq64ymmkZ5dRC7Q9hG4I7LljRieFji7Q7+oe67q8dOTMJ6e+JTGaTBqf9NSS ESmMC3qO5XT9DGKmRhJtYgkFeXJDbLg+lgy+WCb7PdX08/DrhucMUfjWLwidkBBZG4L3d126+4F4 csqMqJqcyeWNMVLE2wIC82fTKxYy0+M0RH2sDmrkvqtUjoOkGE1EbSZXVoZqYN+O69WBQnkUZ9Hx 9bKfcDtHInij6ddf+ndXU4jNR0czGF0lFUuGtpHFrrsvoH1AGfclSVFPE2KKlldTwtbuC1vBWhjK WEY/iVe6XDYK2YNOl/6Yu/zZbi/p244/EOkVRRyscx9HP6w/m5Hf+y3qoQgmodGtPjntUpO2dtYD n/HMU6qVuXqrDmwYdBEXCYgguPwvuqehhjxYvghig7P0NALvyugvET4yso+HvGYqfEsMnq8TqBZj o2dvk+y4LwieIrEOvWaMx4o+N0WHbfp4+zRdc3ik476rg8++Kltu+Tqn6guHw1nWPJNRO0Pipnse b7D7hyvbclXEzpgaiAgRDDQWW/8A+ewXjr6j1CIsbyfVRO0zSSBjh8agvXWTqdld0twSAOD2OoYx J3FtO675VHw4miwm3OaPG/hB8JfnZ6xrO2asMb+lkrHVFI2Zos86jZ1l73aY3RMbC9hY0WDWWsAF 1PQeIXpvQvfgD8x0VNUUl4pIS8N0kchfc5Dr8Exmhlr8DqRVUsjj/Ma64uvLnUm3NxpHTC1tULtm nP6h1Cyp8SGPOkbqdGwM1WtYFe2/A90CyDXdEcKmxHD8NxWpmZreJmtc8H5XSX1O6fLOG5oDaeJo x2ph8yR4G5A+V094aenPXvOGRZMT6e189Phw9Ohz+/wLr0ajiEf7N6VylGST4R9H9U7ork3ppiWA V2VsLpcHq5XEzMpbDzB+AvEFJaby5uPhdueKTI/WTKddTTdURPUxyP0Q1U27b+wXT0cTWljWyARk AusvFLhH08Db7Z9VlykOIVoaywFwCt1HgUyjheDdHqOspaWFtS4Brp2tAcTbe5WmHKHlRVbDA67e 5utzngIxZld0Xghvd0b77ri2ztm4hwZnXDqjm3Kef8AhocNdJhXmATaCSZASu3swZaw7O+AUwxOj hl8xoe1szA7TtfuuqusvVR+ROoeGx1eDvr6OUAQ6WaruXcuFVv8AqTLtPVuhdROewPEbzbQflfQm 9sISgq/s/NQhulNSldny3U1+I5P6T1bsDY39dTRAQNa2wB7WC+W8OWYc6ZgwB8ubI3eaXAMJ2Fl2 VmuWSLJtdLMwTyQxF4awXDrLqvwy9UsZ6gNxuDE8IdhkNFLpgc5mnzB7qRp4ZSa5s6yqOWKXR5a8 bWQMDpPE1k2qhoIYJcQcx1QY2D+cdXJXvymYzLWSWfpYw2Okoy9rG7DZt14x+oJNh+CZ8yFi5la6 tE4jMYO7RfYr1/Rxz5n6YQx0srRPW4eGMkJ2BLLbpl5xwbNwcmpGsboJmCfqv4tK6ozNO/E4ZcQf +lZUOu2PSdgB+y2R9cIMbZ08qI8utc2uYyzPL7Cy1hdKcJquk3irp6THmuoDQYmTNO4WYQ52xB7g 3W1vP+YZsKyLiGK4bGKycU5fA1puH3FxZaz1HJFRGOnibPj/AA6PzE7IkMWYdRrw8+p4sSPlfZ4Z mGCtzJiOERQFhp2hz5BsHErrjwu5xzLnLLNfXZko30MwnIjje21m+67Ww+ipIq+prYA10k33vB7r hl4yS4GNJwTs8+4x4aMcxDrozOVHmN1FRxHW2IOJkd7tPwsrxt5mrMr9FawU9L+qjljMczyCQzbk rqrq5mjPmQfEJAKauxCXDK2Zpjp47ujDSfheiuuOCRZs6C49SVjC59Th7nAkXLXWvdem5KUJS5PD GK2zUVXs1EeEvP2N5W6v4TBS4rUQUc9cBJTtcQwglbqc74cMayDi1M9jZTUUTwGuFw4li0teF3pd mDOXWFmH4PTF8lDVguld9rADuSt1mM1tNljJksuIztZFSUZEsrjts3dcs625lFH03KM8W7+jU/4Q cMpMJ8TcGHyRaXfq5NnD7SHLZp4iMfqMrdFs24nTPLJYqCQBw7XFtv7rVp4fc74ZF4sKnEqidkVI /EXiOQmwsXcrbdn/ACxSdQ8h4lhDntlpq+mLGvabg3GxW9Rt8qPNCDlh3s0edFuqGKZP6jYbjcNZ MayOo1udqPraXcH3W8Lprnan6iZQoMYp26TLGNbSOHW3Wm/IHhnzI3xI/wCja+ifTwxYjq8132mE Ovt+y3Kwy4B0qynBDUTw4bh1JCAXv9INguerSU1tPRp4xWO2dd+K7PhyN0pxeOFj/wBRVwujZI0X DbhdXfTmqHVHTnGDM8yVT6nW5xO9j2Xf+ZsMwLrh06qoIZI6qhrYj5MrCDZ3Y3/K6P8ABvkjF+nO ac14JiTTEIXgBgadLgOCCpGnhkvaOXC1C/Gdv9UOlOWc2wy1le/9LiNNGXsqGP0uYexXQXhO6jZg zR1XxnBK3GKitwvDi9kYe4kGx2X1XiU6Z5+zrmyhky1iL6ehlHlzRtfYW+QvruivhsoOk038VhrZ ZMYqGj9ST9hPddYqEcL3Pl9HFTWTP9F0dv45mvDsBlp462dsXnvDGFx2JXITeqmeWuB1NNiF5X+o FPiGHdNqCtw10sc8NS28sf8ASLruzobXzYt0oy3UVErppn0rXOe/kmy8TxbYKZ7Vnc8kotGlvxJU NTl/xEZsZKCKk173E/F9iFto8FAnm8PmAS1UjpJJAXXcd7LXP4mumuLdTvGhjWA4HFeepkaI38AC +5K2ndEshSdKemOEYHVzNfJSQASutYA233Xv1K+kf0xjktm1+jWL9WCilf1moTJGWROpGlslubLx phQFLUsjG7SAPhevPqg9U8Dz11QosPwWsjrf4azyqiWPcB992gryHQTieNhY3dpss6hbMcF7Nf49 N7vw7q8LbKdvWjB21LWui89vpdwd1vPmpW12Ammhf5DJqfQx7f6bjstFXhybHH1bwbzXAEzMPPyt 5ssBmysxgldCf0oIkbyPTyvn+0j3ajo+A6QdGz00r8Tqp8eqMafVvLgJXbR3PC+X6u5eooOt2R65 0TQ+okLZT3NuCurPCLnTMmPdYs3YZV4q+uwqlleGhz77g2Frr0B1KyBiOb864JiVO/yYsOdcE916 qcZ1J9o+Wuce6j7HO+K4Fl3BJsax58UeH0LfMMswuG2XhPxI/Uy6f1GSMcy7lN9TVYlURug83y9M YB2Nj3XtXqxkCHqJ0vxfLlXd4q6ZzNTTb122P91+fzqVkWsyD1NxPLuJxsdUUszo27f032XXBCGx zfLXRecuZYuk0eoPp+Vxq+vmAVc1w6Zznuv2JK2m+JqZkHRLNL3tDwaVwIutZn0+enGNYx1Upa6C mtS0vqMt7bLa51PyfS53yFi+DVNwyopnNDvZ1tl4nlbzJs+xm08YY1jidA/T5A/9GZHXDv8AiXDb kfsvJP1daE/66ysIA1sj6Zz3bW2uuwfDB11Z0E6h1GRc0yRU1JV1Do2yB3pjIJAcSvU3Wzw25M8Q z8Or8UlE00FiyeNwcHMO9l9KEli1G/J0z4GRNY0oK2jRfS9K8+Ytl2bGcPwqrmwkN1SzRg6Q1fL0 tW2hDYbgyk6XE8g/K/QVjOT8jdHej+IYfJS0lPgcFM4PDgLv2/yVoTz/AA4LivU/Mc+BxmLB21D3 wt/dcs0/Jumj6ukyRvZtpn0GQ4YW4zTsmA0ueH2PBK3weGuogqejWAyU7WMvCAQzYXAWgjCcS/SV FLPuPKcCbd91uT8DviAyjmjphQ4N/FaajxKmABhqJQ0uPxdfNkrZ9LLKocHc+aerWRMo5rkgx7N9 NhtdCy5oZ5dOx72XU/Vfxe9OqvDzhODY3FiVa4gh8BNmH891ynU7we5G6v8AUOlzfj0ra18YtJBH LZko7XKx8xeGrodhdMKGCgwrA8RIBjl86zrjuQSvbDxxqVuz865ZJXCSo7YyDj9ViPTGmxYF9RM+ n1xtcNztsF51g+ofkbJ+PV2D5uiqKKqgmMcoijLtH5F16hypDhOA5Yw/DafEKSaCCIRhzJW2d/la oPqW5Zy7hHXbC34BLDHPibA6v0kFrXX5XbTrHllLyHLJDJFx8Z7u8OfW+g62dS80Yjl2WQ5bjhaI o3N0hzr7usuW8V/iKHh5ocvYhIR+nqanRMzlzmjmy60+nvg2VMndNJqpuMUYrZnapW+aG2Hud19L 40KXIHVXpBidNJmTCW4vSXkpJHztJa8drX7rLcJZ0u0ejJjyQxtJ0z7Po94xunPW6sp8OwHEpHYr M2/6WWItI9/yvnfHJUYtQdM4a3DJZqYU84Mk8Ty3QPmy1meEjrhgfQ/rTT4hjhi/SQkxyVMTePlb VpeuPRjrxlCpwqbNmF1OG1rLSwT1DYzbm26ZoQxZfp0ZeLJPFUnycj4VszSZl6V4dV1Mj5pmsOuV 5vqt3XV2Wum9J1a63ZqxepqZosOgkMRigkLS4rtPDOo/SrpPkv8AR0+aMIosKpozGwMqmF1rewO6 +G6G9YOjeWI8U/hufaGoqa+pdO/9RMA4XPG/Zcrpykj04o/64pnVHiczozwbZ1y/jOARYjWUFWCJ qaeQuiO/Fz3XSvW/6omEdROn+I4BHlZ1PWVLCwGR2sN+V6H8fmc+n3VHobU4VTZhw2rr2yCeGaKV rnx25tb3WnN1HFBXOZBeoaDpEpNx+V6lOHiUpL7HHHpt2WST4ApqmSoxCWp8oB8jy4NA2bcrvzw7 YkMI6q5fkc0Pa+pja7b5XSNPI+nkc1ga+RfR5TzlV5XxygxRseo0crZSwd7G6+c5bj70Y7IUmfoe 0xzZbaXAeV+mvY8favGPhG/VYj1xzdNM6ZsENQ8RtkBaLauywOkf1S+mmMYFS4dmllThVTFGI3yO bqY6wsuyML8a/hxwud+I4dmahpJni8hZGWk/43K74Z7Iyi12fn9Vhc5Rl+M+56/UtRR5oyji0Ly1 prGwahy25/8AK57xB0NTU9KKn9OXl8JZM/TzYbrwd1x+pllbMnUXL8WD0ss+XMLq2y1E7xvLY8tC 7lzx9T7o7WZDrXUNbPXV8kWhtB5Ru73ut+NpQv8A7M3L/ZKu+j1h0/xF2N9PcPq3ObI59KBsdj6V oQ8UlIMI8QGZ4huHV0h3/K2L9PvqtdKqHK9Ph1VhVdhksMZGlrAWX+FrR66Z7w3qj1kxzM2GNeKG sqDIxj+1yu0JLEsn99HXDFynC1/yfMYPOw4g0OcAI3Ardv8AT4z1gmYujVLhlDWMkrqTeWEO3A/C 0fOo2YdUTSOuWTG4I7Lsfo516zX0EzdR49l2vkbHGR5lKblkre7SF8jc5H3MkW1T9Gyn6jnhnxfq lU4Vj+CN/UVMdoHxDlrT3XyWX/ptYbl/pxQZh/VT/wAfEbJHUx+1vuFeV/rEZNqsMjizTlGsjr2i 73wWcwn4BXzvUn6weG1kTKXKWWahlNtrlqyAT8Bq+3DUZHjjhVcHw4YpYskpd2bFekmFSYD05wOi n2mjpxqBN7FahfHZimcKfxC5rqpsRrmYOyZsMLHud5Wn47L0Blf6zGVxhsbcayZXRTsbYile1wcf 34XljxieNeg8RMYpsAwE4ZCXBz3yW1n8leSD8c3KR1lGU5R44Nsng9xSHFOgGWJIJhUuZAGvLTez u4PyuqM3dMMep/F/hOZn0slTSyt1Mexl2Bo91rH8PXjs6geH1jKGirP1eCuFnUkguAfcL0lB9ZXH 4tAdkymqXMH/ADXSEOP7Lisj3uS9jNgbSSNgni0xYYb4e82yH0unpTC0fJ9l5K+nN0fzXhuNwZpn pZsPwPyXMc6oaQ6ck9vheX/EH9SjOfXHLkWFMwGDBKEPEhZG4u8wjuVznS/6rfUrIWAUuG1WBYbj FNTsaxt2lhDR+F7scnDTyjHtmYwk521wbHfGfkWszv0ln/htLLXYhSzNkigiF3P34AU8KPU5uJ5U p8m4xE/DMzYbCA6lqNnOZ7j8Lw1P9ZrMczHMbkSka87ai8nT+y80518Y+fc2dXIs/wBDLJheIw/Z DTgtYQP6T7rxxe6GxmvHOGTfFG4jLPQipyp1prc0RYi+ro6wF7mPP/Ld7Lq76lXVzBsp9DcQwF1d CcWxAhjKQOHmab829l47qPq5dRpsAdQ/wGlp68xhjKsN31W+4heSc+dQc0dWczy49mPEpcRr53es yu2aPYDsuylbU5vo4vTydwiu+TYd9NOs6Tz4BLJjM9AzNVOAb1paNLfi65v6mOScgY10+jzFhlZh 5xmMkNNM5vrbb45Wrp0Ndg9S+ow2qko3uFnGKQtJCmL4pmPHMLjgr8UqKimh+yJ0pIWVqHHJuTPZ 8eW1RSEZfn8yneLXLDa6zaJ0sFZNUxEWLbaSsbDIv0dAdZDHlMq6WTVTyQSARj7wTyvE5W2z6sVU UjYB9PvxoYL00hgydmNraWiq5bCrc6wjcTte/ZbB+o/SvAur7MNxEVBewESCpgOoPYfYrQBVUwlD TTnRIe7XW3XauQPG51s6R0keFYbj8k2HwjTHDUDWGj91cUnCVpng1WF5FSNzXU3rBk3wxdPvMxnE GhkLNNLRl95pzbgBcf0D8TuSPEZlKb+GVMeF1jg5k+HTuAkaDtf5WjvqX10zp1pxs4jmavfVVJPp c4nSz8Dsvm8u5zzLkjFBW4LXzU9YP643Wv8A2XeSjXL5PHDFmvhcH6CenPRzLXR2vxfF8MmZFT1p dLM97hYHk7rWv49vGHhnUPP1NguAtIpMv1QcKy//ADXA72XlLF/Ez1Vx2jNDVZrxGKmcNLoWzODS D7rrmdlRVTGeskdLNI65e43XTHlUHvlyyrTSl9KpG7nwYeL/ACz1vyjDlzFK+GHMdLGGGnndbz47 WuOxPwum/F/0Tk6D42esmUayGmlo6pszaQbAG9yAtXNDiNXlfEYa3CcVmw2vhILJ4HFrgfyF9TmD q91HzxhP8NxvN9TjGGk3ENRJqAXOGRQk3+m82knJVH0bufD74lMm+J7prTTsqYGV74hHX4dO4Nc1 9t7DuCV9piWJ5H6E5bra1v6PBqXSXuiY4DzHD/uvz84LiGOZWlFRhOOVOFTi3qpZCzf9ly2MdR89 ZwjFJi2a67EYBtpmncbqpRfF8GJYMv8AJLk3J+HXxz5P6uY/i2B4hiFNhuLwTuFLE86RLF2seLrs DE+luS2Z/izpJiNPT4uHXbM+Zlj8LQS6mnwmqjno6yWkrGm4niJDh+4XPVmbc3YhSl1TnDEatrAB pdUu2/yufk2SbgSWjyZIKM+aNzfjQ8QWUOn/AEaxWkqcapqutrojFFBTyte8kj2B2XnH6btX0lpc OxHGcaxygps1Sz6mx1srYw1nwStZNU3Ea9uqurp6xnIEshd/5WBLQSxeuB74/lj9K6vKlj2x7OuL TyhNykbjPHV45cE6dZEqcByVidJiuN1zTC6enkD2Qs72I7rVf0865Zh6bZ5izdhNUYsQ88TSuN/X vuF17Jh8z3MfLJJJ763ErOcIw1jdGoDYgBZWp2Q2xO2LTbZOT9m7Pw//AFDenXV7L1DBjNYzCscc wMnhntoLu5BXx2B9Tuh/TDxS43j9FmDD8P8A1tOGTeWQIvM7m608PpWwTiWjllpH83Ztb+yGXDpa kukllfUPdy9zjc/3Ux5Ixi6fZmenk5Wjcp42fGZlzL/T2g/0ZmikrqyeZrnvopdTms/Yr6Dod49+ kmLdM6CDHc2xUuKCPy6iKqJ1vPc/haQamgMYDXySuHZpNwrOEsADtflkjsbLnvhSSRvwytts3xYN 41egWTqU0WG5ipIKcPLyIW7AnklZMXjZ8PtdWfrmZyw/9WBvI64I+NwtC0dKyFu7nlp5uuViwHDp oGvbLa43HCtq7sngbjtN2uPfUt6G4DWfpn4++uiOxlpoS5pXlbxweOrInU2nykzJ9VPWtw6rFRNq Zp2uLC37LXYcDpw7TG+9tt9wrieIK79P+lY9o+53C648kMc1Joi07ra3wbdsj/VV6XtyZRU+KU1Z T4hDAGOYxoLLgW/K8t9BfG1lTp94kc0ZnxbDWS4LjEznQ1bxeSAF3/wvGFRRUb6rZjmM9mohSUU1 2Nh1Dvq2KrzRW7b7MPT3JN+jZf4ovqlYFi+Tq7BOn/mOq6ppjNZ/tBHZax8TxfEM0VkldVSOmlJL nOcdySmOweja67QG25F7rKDIKVv/AA7XeoWcHLn5koOMTvj0qU975Jg7I20b5jvITYrsjoD1+xDw 8dRKbMlBStqmMPrjd3Hddblxp4A1rbB25sk+dJIx0YhGk9zyvFZ9BxTVGxnqt9V3L/ULphiGX3ZV qYK6uhMb3eZdl/jZdUeG/wCpDjnQnK0+CyYFT4lhomMsUbiWubfnheM4cILZS58lr8Am6z5KaAtZ qF7bE+69mPOo43jfTPC9InLc3ybKqD6zGFSTh9bkWYO/3RS/b/dfPdT/AKt9JnPLmJ4TheXpKNlV TuhDpDc3IsvAUUFKIrRODCRwUltDEx93sYfkBYWVRaa9B6KMl9mYdK+WSSorHuDZ5pTKL9je69Yd BvqT576H5aiwJ2F0eMUcB9LXttf9xZeW20gDX73B4v2TIGsADXNa4e9lJZVOW6R63jShtR7hz/8A VpxrPmTMTwWXJEFM+shMQla4uEZPcAryL0x67Z46TZr/ANSZerp6WqMhe+EPPlvBPBC+YmaISQ3u lhj5G3lI0+628y2bF0edaWN7n2e46T6v2fYcPEFTlajdUBtv1G9725svNvXjxddQfEM4U+P1pjw/ V6aeIaWALq6RzS9oBIaPlHJHHIW2LQ2ykcyh6OXwldi8Po4I6N0b2XDTcO9ijYHRRkxl4l/pezYh PiDS3QAnQh8Tr2Fl5nK+z6aVKjszpv4tuqnS2lFFh2Y6x1KwWZDM8ua39l2APqV9eGxObHidK+K2 kEwgkfK88P8AJns8mzx2QMsHOa4h0Z4FlqOTacZ4ISfKOwZfGN1q/jlRjUecq6OrkdrdY+kH4Hsv oXfUY66VlHJSnMpe2RpY97mjUR+V0mBHBI57STcW0rEkbAeYl0lncuWjHxMdUgjmjHG5jmzEzFJo Malk811RG71ar3vddyYN44OvOEUMdLDnOaSmjHobLYrpqN0UZJay9+x7K3vbLs8XtwsObk7Z1WGK jSOc6o9Zs39ZsWhxLOeJPr6uEaGX4AXzWCYriuVsRjxTBMRloqtu4cx+lG6jj1X03/KqSmYQAW7L TyyapnLxJKkfc/8A3TPVySNscOccUpWt7QzloP5svlsx53zfmqpZX49mCuragfbLLUuJb+N9lxJo 2g3DywjhXUR+cwMlJe0LUcjQjpoe0fUYd1K6hZdpY3Yfm7EoYXizdNU7Yf3XzuYsZxrNVUyfHMSn xSa99cry5xP5Kxp6FlVStjic9hbwLpmEU8tOC2W7ndiVje10a+PjUtyQ6RsktOwX8treQEyRjZmM BOzU0sdqN+/N0Hl6gQDYrDPWLqI31bdNJFaVvDiFZixuWLyarEJY4/8AaJCLJ9LUmlcY7Xcf6gmS 1RB9bTLf37KLh2c5xU+ziKmCoijML6yolYeAXkt/ssVmCx6Q8TljxvZriCuafKXN06QAk+UL3stv JJnGOKMfRgMw8MBeHSauNZ3JRDB31b/5sz5Gc+snZZkj54m2YQ4HtZCKue24DfwtrPOttnRQj+Cs OpfLqtDBpjaFm1NLLVShzZSxo/pCVTEs9QNyVmmQgbnlcrO3HRjuw/8AU7ONh72SzlvDWAvMp1W4 43T3yycDhKc0u3cLlNz6MyipdmFBQROf/MuGcJpwql1WhjDj7lZIjDm27Io4/LdcXuOCs217MbIP 0NioKelpdXpEh4asYYO2tjGqKIS3+5osU+RvmOu4bq4qYk+l5b72Wrb7NbVXQMWEilHraSfndHHR HceWzSeNllxNkFg55d8lFOwEegkOWrMbI30cOyk8qd4LbX49kp7NMjhI1oHYgLlZIjy7lJkj1mxF ws2y7UYz7OiDT6moWNZCwmKMG/IcsgwgfAVGPSfhQtUTz3Phazho7JEsZcLXsPhZAZfgKFnupQuz G0sLA1+7flA+KOJnoLHD5CypIWObY91hS0jWg6VbIIazU8OJ47JdRHHI8OeCHDYOCa2ExjlFp1Df dLsw7ZiU8EMM2p0jpGnlrjdSRrHzExsDGeyyjTh2/soItBuFbZml+GHLh92ggAtKQaEN307rmABa 3dJlLG7E7qGWkjizTMFzaw9kgXsW29K5N4a7/wDGlGINGwV9GaMSGCIMN3OAG4QVP8yxaS4+6zfI aRe1vhV+maDtsqhQmNrTG0FtyPdP2eCCOfZWIwPZMbGAbqkqio4W2AaC35T/ACXFlnOLvyjuNPIR blnCF4MezmWsNkE9OyVpBZufZZgb6d+VNI1bcq0Uqnklgpf08bfRbgooJZadpAb8o2Alx3TG+kWP KUC4KyoDj5gDmFG0xxy6mD7juqDtPbZGC129gCqa9ATWcdhYpEzS6KwPPZOqJg3j+6SJbEE7hTgy zBfE4Agi6SKQOF3ON/YrkX6Xb9ko6HA73siMowvLJJ32V6S12/CeSHN4tZC4Bw+UsWDYA77/AChd q1bEhGTdwHKN7ACANj7KEEl7ySCdkBY13KeW6bXUsL8IViDCDt2RNpgLeog/CdpCtpAPClEK8sXB vuPdU8FwvdEHb3VvsG7qrg3Yryh/U65/KossNyhkdY7C4ROcHN1FGSy2tDeOVGDyjqtuVbKiMb2u U9j2Pbc90FhAk8omjlUSHCwVai0WQtgTFrf6dvdXG5j27CyGXcAFC0Br2+yCx4h22TGMIG6dEGiM bkoXx377DshUKMTSdxdUImnt+yI3abH+6Jov3WCWW1mkbbXTWR+jm6AktFyigluDdAW1ul3CyTK2 Ro+FjkhzT2QNf5bCOVKAwQsBLtt1GBrbktuErzbtHtdH51he2y2iMTM5wlDm2DfZW97Q0kcpTzd4 N0UlrNFtyq2EW12qkLj9xNljBovc8p7hpZZLDbuusFIQ13/wpoLidlR5+EbXFo5QCwzSTflXbZGS HEXF1RB7BAAW3QuuXfhM4uVVtyUBHOLrLGms4j3TjcJZZqN0AIOw3upffhRrNLldruQthD8KyzUL IdwU1huFKIAGAC1kbWDlXYmyuwv8qgNlk0EDZKaN0YCoHh40qtQIulkkD4VBxv7BQDSLoCLEo9m2 Kr3ugAAV2UIsNlYBKAoi6x3nSb8rIcN0tzNigAZ697botPwhYzQSW7lMZc8oAHNv/wDKDSb2JTng 2sFWhQGNY3t2Rb2snFqEt3QC7FQN3TbCyo2CAC26YLAKeysmyoKI7nj5VGpLLAbhQgO2vsULWA3H ZATzdYCEMu+5Kss9lANvdARwsSeyhYXi4FwjY0HYhZERa0hvYe6ATTRu0O9NtPKEPJuueDqUUp1E aiFwz4muJLBYXQqFOuRtsr0hzBqG44RBlu6sNJQhAT7o2vaDxultaQUcYDDd3dDQ5rvSSEDZC8kI wxjW3L9ihLC2xaLgoArXPKp8RNrbBAH+qyyGOa7a+6AU2BztuUmppgw+5Kz4m6JCNV0qqe2OQDZ1 0Bgvi8twKjwHAWFrrKLPLN3i7SlSRRucHgGw4CAposBurvvxdQjUQeApvfZAUbd+yB/qdsjc2+yo ADZACBsTa5SXXvwnndA8O1C3CEZTfUo+RrNgfUjbZJkYDJdvCFKbrmmbqNg1Mc4l+3F1IyQ7i4RA 3Js2yAW5uo2soY2m22yZp9/8IthsRuhGYc7GtfYcJdvZG8PMrttkTGgNuRwhBLjpI7ow3ZNjs51g NkckYZuNkAnT24V+SQBYomtD+Twmgi+3ZAY7JjC8tPdZcbrb3S3xNeLnlSma5wLXDhC0ZBcOQqN+ 4ulPbZ9gUcQc47nYIUjnvaQBwUTX2IaqNgbndRti4n2QBXFlUp0tFlG2de5tZBM4OFmG9vZClAl+ 5QkAmygLtA90TWudzYIQB7NuVcW2xtZFoOq10t40ktUoDXSst9yG4cDYrEkhceL3R0rnNuHAkowB IX3N+FTBqACZLqc0kiyqBrrglUg7ywxwtyobDY8owQDd26VI8F+26BlaQQe6ItFgVC3/APIiA7Hc IQWTtYJE0piO37LJNm322SGPEtwQgKhm1HUU8OJuUUEbBGSW3KEs1EngBAS4OyoWvxZRpuETbICa QrDLhWArcLBCghujfglPjhBAINx3StTWEauFkRuYQQLX9kFCKqzRYCyxXB7WamFZkzC35KU1rWuN +/AQtDqeQujBcd/ZNJDvhYsQ0uN9kQks9AW9hcXNA2CxA0D02TZ5JnOtHs3uVTXaBfugIYRwQo4a RblE52oXKEvLm+xCAWwEGwGya2PTchVw3UVeolmyEZYN+UD3WHCjQ61wiIFv+6EEPva52CDfm+yf VMIjbbe6xt/Mt2QFy3LRpVxgtZfkqOFyLcBNGnax3QCmSv0EkEFBHUPDiHlFNqfs22x3QuhfYOts gIJ3SPNxYBCAbk9k2V4Ia1o3KAkgEb3QAeXvcq7W5RAnTuqeLtQFGxKu1lA21lekW3QFDfhQmwVN O5sr0FwuEBQ4RNAO191Wk327KrH3sgBkDmnZLDn+YA69vdOeLN52VB+ogW2QFQSEOdq2CNslz/5U eA6yoWaNuEFhlwvdS4KF24U3CAI2ANyqjd5h23UJulB2h2puxQtGQDquLWIWPKC6X4CIzuDwQ3bu jc0PGq4CEAYATuSmSMD2WvZA6zRfuh3cdjZVBMJkBYLg3VPaPZEx7mcqOcXFQCrG6v1CwcFfCsu9 0AGgHdv3KNZYerlGHD2sULmlxJ7BACx2sEcAI99uyttg3hWQOe6ABzSSHeytsg322KjgSLBCWWFr 2QDGO7gbKnSd9NwlmQ2DRsodRdfsrQDYA6+3KnkmO4O6DUWuTI3kk3IUAvi4HZW0EkbKPIa73RtO wHb3VsBO4SnE3TDv3VX34UAAJKexwDLJId67dk0N3QEvfa1goWAclCb29lYdcb8oAhYXI3VEte2x VAX4VBoYdzugFF5jOhrdvdQDyRrcUz7jxayshpaAd1bAMm8d1GRfy9RNhyUb3Wj4vZJc5xZ6bgd1 AC6Rk7v5e4HKYIwG27IYmNjG3dNifq7cICmsY0WAVOsNgic4XJCEt8wX9uyAm4f8I3A6NuUAeRyF GvLz7WQC3e5G6INsPhH9w+QoBfZAC1jHHco3RNZwbj4SZmG2xRRjTH6jfZAV9pKIN21XSmte4Gw2 RscbWsgDaLE33ui5CANLnKPOk24VYCDSCqFyVV9uVYNgoC28fKYIyEsHcI3TbnZAdmU51Mbf2WSW giyRE3SbBZJIAsQvlH1rs4mvguPlcYfS4j2XMVzxq2XDT3DiexK9MOTyT7GBus/CVK5gu22op0Qs y5WBUT2kOnldDmh0L9I32WbTO1Rm7LH3WHDOJ2AEAEbXWfHs0D2UZsBzTLYnaytjdRAKcWtI2UYA Qdt/dZBiOD9Z030hBNq7LLc3SDfYJJbz7FWwYwJc2x7KpXWZYcpoi0pcwsRtuqmKH0cQpp2XN3Xv ZbC/B5iBOXKQXu4Sgfha8KnS9sc7HfzG8henPCz1xgyZi9LSV50Usjx6ncBd8a5R5cq4Zsr8VuDv xbw74xSMYXf8LrIHwFqT6Q0ta7NIFE54fDICwscbCxW5CmxrC+qmQX0UU7J6SrgMbnN3sCF4tyP4 T6np/wBWjh2kOwuacyMkdsXAnhfaf/io/NQ+mZ7ke6PD3mLFswZBw+XFGlz2xhus8kBdNeP+DNFf 08NPg8LnYeHap3M/8ruLPudIeiPSmfEoIGiKgjDWtNrXXAdMuotL4j+m1W6qigaypjc17Lj0/K4Y ltlua4PRnkpKkdF/T1rhLXYix+zm07W2PuOV3D4hs/ZFwvD8SoMagj/ioiPkuLRqLu264nw/dA63 pPnPEp2zXoZHOLRcEblZviG8MEXW3MOG1X6qOiihIE0jbhzgOy9acPNubo8ORtwpI87eD2vq6Pql +rY2X9NUyOa4f0hvZep+uvXKbo7jGGSPpv1VHU2Dhe1rlc5lfpJlvpzhlHT4dBFA+EAOnfbU7bnd dKePWHD6jp3h+NCth/U0UwswP3eFZbMmRN9FTko8Lk9O5ezJQ52ytFiVG9roaqK+x4JHBWlPrZRN wzxEZlhYLCKscXEf/aWz7woY1H/6TRSfqhK2Rmu2oWbdeKepXTjDse8V9dRtq4ZaWtmE0jw4be4X NKONTSf/AAbSlOcbPavgzxFj+mkcHAaLtaV4L+qbSNp+q9A+4L5YgQthWG4hlzo10/8A1j5oqSmg h1OOsb2C1A+LPr2OuXVGqxCma51FA8xwn2A7rcFGEG2+0ddsnmVHVUAke8G269LeD2pd/r3DtG7A 8By85UrbwhzXbELujwwZuo8qZ1pXVUrWDzQSSV8eTSdo/TpOUDd/QVFJU5PjfUNDqUQfzAfa266k 6K586XVWasWwnKFMKfE/NJn/AJZGo991zGB9VcsVWRvIdjFPT+bAWh75B6bheRvDjnzLWUPETmSK uxemmike90VQCA12/uvfiipQfNH57UQmsiaR3v4sZZabPeSJ4musJwC8Djddi9fOoOJ9OujcuP4R A6rqqeNrywd22uV891UzT0+zvPg367NVFQS0NQJQPNb6h7L6POGfsh5jyPXYccwYbPTTUzotLp28 WtddV1C10eWbkt39mpPr74/M+dWoXYU1zsJw8DQ+nhNtR73XLeCKeoqM+0VVuZjM0uPfldQeI/LW X8qdQ/0WXatlayWRzpHMdqa3dejfA5mDJ+XcdYMZrI4KgFukyGw+Vxzu5VE9+HDWPc0bNuuuFvzL 0Yxumi9WqjLiPcAX/wDC86fT0zBDbH8KZINLSHBpPsSF3riPiM6WNwaWkq80ULIXRmN8bpBcgixF lrPd4haPox14xTEMo1jZsANSXMbEQQ5pduu+JrxODPFOMvNfo70+qf0xrcamwLH6SmfUOaww6WNv uT3XQWUvpwZozvkSlxl3lwyVUYMMLhZwNu6924F4y+jHVTL9JFmTEaanqWgOfBWDZjvcErG6q+OT pN03ylIMKxynxPyoyIYaJ17OtsAo574qD9GcSlhm2vZpizPk/EenmccRyrioDKuilLCBxcFfQ5Ej d/qGkkkO7JGnf8ri+oedZepHUTFc0vYWfqp3SNB5sTtdOwOsfCHTRG8odqHwvmy4lwfocbeSHJvR 8JeKsxHp3TuuLtYAP7L4DxT+KTNXSTMeH4XlrAP4g+Q/zDI0nV7aV5B8KXjwb0umjwjMkYGFuAaJ h2K9W4147+hWIOhxDFaiCqqIBdhMYkLfwvXh2xlclZ8XWQyOow4Otc/9feuefcjVAqspx4LhU4DZ JGNIcWr1d4Zq59X0fwiGS4mghs/VyCvJ/Vj6nnTOTCI6TLtDPWesF7XxhrNP4X0OUPqi9JcIyrE2 pppaOXyxeGBosXW7rWSUWqiqNQxN8vs6N6geL3O/h865ZzZT0VRWUktS5jPPB0AX2IXZXhE6o5k6 4ddG47XlxpjES/T9re9l5p8Z3iryJ1zw+lkyph5psUMwMr7WJavtPCt42sleH/AoqSvww1Eth5s0 Q9V7brWaapbUYwaeSXJ7H+oE7MuD5Epsw4HUSRQ0D7yiK92/JsvOHhN8XWdMxZ9w7A8cxx1RhryG ASn1C/yV9b1K+qD0rzzknGMIZQVL3VVO6ONk7PSXEbX/AHWunAs9VuWMwMxzDZRFI2bzYx7C9wF2 UlDAlJcmFp5Tzyk+jeP4n8q4hm7obj2HYZF+orJYNTWgbm26+E8B2XK7LPST9HVUz6Z4kIIeCDe+ /K8zdOvqzUFBl+mosx4U+rq4YxG8t2127puYfq74TBh8tLgGUnQPsQyRx9IPvYLjGUnjeOuzc9Lt y+Q9Z4JgTofFFidbFE40zqIanW2a/wDK+G+oNlzHaTpw3NuXDK7EMPkDnxsdazf937LyX08+qTLl vF6zEMWwn9TNPe9wf7XWd1R+rFS54yhiuBxZZ8ttdCYrkatIP5VUnDIpr0alhuDi0eb86eNjq7m/ Lj8rVeKtfRBvlvc0C5H5XSQpnhrXPfqqJHann3TI6iNklVWNbobO4vAPa/ZXTPbKRI5eTU53lmz6 ukwLDBUj7TIWKU7Mche5+l0Lhck/K3g+FrHKTH+jODinmZLaOzwDfn3WhWIw0TnTRPIc7uF3T0T8 aWc+hV4qGV9dQA/8lztguEI8nfNDfE2G1Hh5xw+J2XF6HD3wZdjqBUGTTsXX3IXa/jGihm6VmOpq WQQNkYbE2JcPZa+sS+rh1Bdb+HYPRgW3dM3UV0n1o8cHUXrbNSHGXNgpKY6m00ALWE+5X0lNuUZP 0fAWCWPcl7Nz+VaQSdA6aBsZkMuGaQBuTduxXzfhPilpMiT4dOdbqWpeNR5sTwtUeAfUl6r5Zy7B gtJUsfSQR+VG17blreLJ+QPqN9SOnUNd5NFFViscXu1jgn2WHKoyT9nbwyk48dH0X1M8AND4i56s 7fqow5re4Xl6gqnGdoNhY72XKdUOumP9cs+SZhzBc1QbZrezV8tSyPjcXyu03N7rnPMpUl6PZpsL x3u9nuHwQeJXDOkuamUWKkMp6shjpXbBq2P9WenOWfE105/hrq6KWjqWiSGojcCWH4WhOmrHOaND 3B43DgV2LlTxUdSOn2Hfw/CMXniiZ9h1E2XHHJxluXZvU6ZZIv8ADbx0a8K+SfDzkqupphDXSPY4 y1lS0Em47Lm/C3lmiwHBMdqsPmgdBW1r3tjjNrAcf91przH4uerudaV9JiWaquWFwsWB9lw2AeI3 qnlFpiwfMdZTsvezJCLn+69cpKUXulyzw4cWSPCXCNjX1O+j0mP0GGZwgqWRMommGaPULu7g2XVn 01usuC5LzJUYLiNTHTx1oLWOc6wv2Xi/NvX7qZn6J0GYcx1FXTuFjFI42/svkaCuqMMs6Kpkppr6 myRmxBVeZygoX0dMWk2tt+zfN176D4b14hwuQ4gynfSyCRkzXBwI+F9VWYjgvSTp1UsqMVgbFQ0Z aHTyAEkN/K0UYZ4kequB0RpaHO9eyFosNUp2H7lfO4/1b6gZ1a5mJ5irq0H7g+U6XfssctKLfCM/ FnCTkl2dj1U1Nn7q9USUtQ7/AI6ve587ZLAAu5W5zw45bwjp/wBJ8LwumxaCqe2PVJK6UE3P7rQF huJVeEgTU0pZVNN9jvdfT/8Aq91D8praTMNfSBo28uYj/wArOfVPJUPSPTj0ait3s2D/AFQ+neEz Q4bmqkqInYi5pika2QEke9lwHgq8dHTjo5kH/TeNiWmq4n/zJWDZ2y1+YxnvOWZ2iHGswVmIsbwy Z5cuAmw4saZWi55IcFjLlWRJX0a02jeKLT9nuz6i3i2yN13yxg+E5ZrH1pY/zHhwtoK8LUtEyaMx 3LQdib9kqlwR+LQuljha0Dlw2XLYdD+ng0yCzm7Li5ej04sPitWZ2G0jcE8n9NK5++4K9ceFHxoV /RvFqahxIiTBXODZIztYHuvIsk2pmlpAI7qSiGSjLqmbWAO3Kj5O04qUdpvaofEB0iz7Q0mKVuNU ELmASRuq3gGM/BXnrxfePXL+WMMZlvJWLRV1RVgiWrpXXEY7AELUxS1VRiH/AA9PXzthGwY55ARf wV1NJ/xMr3tJ5vderHKKVy5Pj5NNK6Rti8K31AMr47lCPAM/4g2hroR5bKqR1xK3/qK72x/xZdI8 i5aqq/D8zYbWPZGXNp6eRupx7DZaHq3DWl+mOZzY7cXKwjhLg0tE0nN7atit78b5ZVo5JVZ3j138 SmOdZ+puIY1LO58TJr0sYPpjaDtb9l6u8HP1FI8piHKufKwzYePRBUvPqj+Pwtc9HSGlaTGSHe6W yihqnuNVq1X9JbyueTNv4PVDTKMFE2a+NzxD9Jc9YRFNlerhnzZGdfnQgC7PkjkrI8LX1J8KwnLE GWc+MExpGBsVYCDdvsb+y1cw4dLHWljJH+rglcm/DvJb/OY5x/6eVzjJXUjn8RLpm5fNv1Luj2BY FWvwarfJiToiI4WRWBfbbheY+g/1KqnKmccVnzTNLiODV0znR04d6ot9iLrwDJgtMzQ8ucGnseU5 mFQSRnUwg/0uXVZIpUcviyfs3Kt+o50BxySKrr6l0Vcz7TJT6i391034r/qV5YxzIc2X+n9U6ear aY5JyLaW+wWsZ2Bxb6jz2ISosMjil2ZssrJFO0PiSb7Pdfgu8ZnTXofFVOzFT1EWKVDy6Wray+q6 5LxjfUXpOqOAf6fyLPK2inBbI+xa4/leEP0Imb/ymyHsHBWMLbTMDxG1jz2aizPfvfZ0WjW3a+jk 6LEarDXsrG1DmVmvzA5p3uvZ/QH6nGP9MMCgwbM1C7GqKEBrJSf5jQvFMtPHNE0OdZ49kX8NhdTX bKS8fKSzbncjt4UoKCPe+cPqY5NxfN1BmGgytPR4nSn1TuFtaV17+qZgvUrIMuXaDLpMlazTJUPd /wAr5C8EClfJHpnDX24uLIG4TTVRLZImxtHt3Ull3U66OS0ypqz3f4cfqZYD0gyXFgOLYXVVbYw4 xuZvc9l9rS/WLwmnxScjIszoiQfOEgDnD/ytbkmHQxkWDXMG1iEqXDTqBjaADyQeEU4t/ZGo6SKX Ho2bVv1jMrzxH9NlCqFUAbF7xa/7L5Cu+sji4eRDkyARg+kmQ3I+Vr5/SCnedIa/buEDInMkuYmn 8dlpZIJ9cGfhK7TPWHiE+pVmLrhlqPBI8Djwqic4Okawk6j+VyPS36pmf+mWWaPA58Ao8So6aIRx PcSHADhePJtWoN0jSfjhGKZgAuST7LUtRFrbXBpabbyd3Yt428eq+sUXUKkwmKmxNj9Tm9iPZdm9 Qfqs9QM9ZZmwSnwuDDxNGY31ENw91/nsvIzIA0m1i32IVtpbH0saL9wuU9Q5NN+gtMqphxR1WN1M +IV8xMszy9zXOuST7rKpD5Ac0mxHFljUtI+n1Fzy66ymRgWPf5XOWWU/5HphijjVRRy+CZnrcvV8 OI0Mnl1cLtTHd7hejsM+pr1dwzLv8Impqapi8vymzPbZ1rW5XlOeGSOQSMeSQeE91U+oiaJbC3cD dZT5s1PGsipnZ2U/FN1DyNmSrx/AK9uHV08hkezTdpJ7EFdnxfU866UrWl8tHVG27jEN15qdU0/6 cMaL+5QxTRRRWa3910eVt2zHx41R6Dx36knXHE43NbWx0TXix8uNeeMwZlxjOGZqzMeO1BqMSqjd zymGR0zbkm3sUOgOO4vZTzNdGIaaEJb0fQZD615+6XV763KmPT0Ln8i+y7PxH6gviAxDDJqCbMUb 45maC8MAdb4K6N8kw7tddp3tZKe1sjruG49ly3ruj1SgmuRmNZrzBmXFHYhiuJSnESdQkL9yfyuw 8v8Aiz6xZdwtmF0mZ6htHG3S0h3qA/K61l0uteMOI4cVjPbrcNXpb8Lqs7Ts4PTwaqj6nNnXPqXn aOWlxzNuIVtM/Z0MkrtIH44Xy+D08EMczXP1ucLk9yVkRyxt/liMub/uPKNlNHCXSRtIJWJZG+Dp jwwxO4oCGR0+zIz6TYAd1T5a+hrGS4dWVGH1Dd9UMmkhZEA8hwfxfdYuIVDJJNXLzsSFz8jOjSl2 fSU3WPqbhMeiHPOLMaBYNNQ+wH91wWK5pzXmGoNVX5kr6upPL31Lif8AusemqGwggs1g+6CUxueS 2PST7I8kqpHHw4+2jKouoefcMgEVNmvFKeFnAbVPAH+Vj4piWN5nrG4hjOJT4nOBpEkjy4gflDDP 5V2Si7HBZDJw9oZG0NYFYZZR4QWKCdow6WvxvDnObh2O11HGdnMZK5ot+xSag4rONNRidTUMcbuD pnG/+VyIeYncXBU3N9LbG/stKTTs24Rl2jjZKdzWW06nf9RWOKeUAOaZY3D/AOm8hcvIC7tuga3R 8qvJJu7GxdUZWCYZDikjW4jiFVpcPtkeSAuJxjC6XCcReymll8q9g9jyFlyPk0ek2IWO17ZTaZmo +6vkkYUIr0JNFJ5RbFW1AY7fS6Q2KZRSPpIzE8BoPB91Wl4NmNs3smiEvcNe57LLnJ9m1FR6Milh d5hcDclOno5mNOiXSXcrH80w2aFUkkkvDyLdlLNvoGShjEZLwHv+RssX+F0soOqEA/8ATsssOeed 0Dg5zvb5TczPHbFU2GQxh2qPU35R0zaaFzyKRrttinRPlgJAIcD7q/05c4vvpK15JfpHCD9GJDhg rJHyFoib/tICyKPC4YbkGxHsLLKZHYi7kzi9rH8LDm5dmowjHox5HF50/wBPyhngjmj0ucW/hZBg 1gHj4UdAH2HdclaOrRiiJnkeWQHn3cAVxk+GyOmDSyMR9i3ay5h0VgR/ZY7oXX3JC6bmcmcXJhz4 jZsjSwch26YKVr2FrAGkj7gst1OSDc3Qx05B5K1ufTOO1Ix4qINaALXb7i90ySDWxwEbNXYgWWSY ySB/lG2NY6NoxYY54Yg1z9bflOZRxyfd6b+2yyPLvt2UEVj8K7pembUV+CP0/lD+W61uCVDWOY9n mAOLdgQFkeWSLKCBvBFwls2GHCqYQXBhPBKGKmZRzCR0hkeoIgBp5CYxgA5BRP0FwHJI+o+5tkoy yxuDNF29j2TdfoN+yuOUuaA6xQrFSxeYPU2/wgdStlbpJIH5WX+ED2XBtsoQwp3Pgi8uF7g8cFY0 UlTUPD6ghzxtchcs1rQPtH5QSQhzwQLJZKFCoELRaEPWLMXOk1hmk/IWd5VgTbdDoIF+SrbJRjRU rCS4khx7pkkAlYGm9h3TWh3BCc1twEZaMJlK0DS5uofKaYg5oawBrR7LKDOwR+UAL91klGE2MxHc kj5TWVLWbCP1dnJ2rk2QujBHFiheUCJ3NkD3NDvgopJ2VDXM8oNDuQEWgWGyjbNJ7BCiI4hC3SBt 7IHsDifSLLIPqKstsN0FGHUAPj08LFFOIjcLPkAJ2QFotwoDDdciypjnBun91liME8KjGLGw3SgY z2GR13AFC6EP5CyiyyEtT2SjF/TgE7XCvQQzTfYLJDfdC9oAsrYox2t0m4NlJozKbsJa7uRyUYZu ntjA+Vpsy0YkUMjHC7r/AJWUGEuvx+Eej4uja3fe9liy0LbTDV5h+75VSu07G106UWYbcJUbWuuX qWdEGRqjaR2RPPmNAaLEfCSyQhxB+1OZI2yhqwXU/mAEmzkJpPc3Waxt2gotKFMSOiaDfuE94AaB ymhoCXI8NFrKgWAHcqxBbcFRlQzXYjdOG52CgoT5VyQRf5QupxYBZGoAqtV+yChH6YEpjIGtNxe6 Y1pRBu6gA0gG4G6YDcG6gsPyhN+AllLfAC24sEBprMLvMFx2Vh+nbkpLg7Xe+ypbLEIvchR0Ad2T Ptb8K9XsefdBZjmmAKhhATnOINktx2PCEsSY7IXBMNrb8pZBvcLSIC5nsg09tk0AqtNjdW6Fgx3j JLLXTYuD/uQBmq6jQWOUsWGdRPwhFr8oyNigNgLpYsuwJNuVWojlADsqaXdzYISxt2nlFI1pAtse 6Q5pAuD+yXUPcXADZUjYTyHbNO6oA7DlSEtjO/JRtiN73QWCy++1kYfc2PKMN25ULQELYwOuELng H5UIBaLJD3XJv/hQbjKaWlRxDQsNjzYb2sneY4O23CMJjWnULhOjO22yxQXahtsU5pttdUrY4zlp shdOdSWHjVa10TSHuItulksjp7kXvZA59zZRzhYtNg6+yUQLbm5QWGHe6u2oJe5VPLgfYISww8M5 RGVjm7FY7jtulcDY7IB8so2tx7pDpLdrgoASRbsiDgNkM2LkQ8DlG8A991jklrjbdDNjmuACGR1j cK2W0XPKRJJqNghLKdIS429liPc57ysq1xxuh0gDjdVHNsUA4DdQ3NkwtvsqDbBUgJGyndFpS3iz rk7FUoyw+FCdxbcLHDi2SxJ0rIBaXDSTZCWXIwl4LSnetvfhCBdMvpFuQhCC7xqvdNiIDhcgn2WP GfKJ0jlEz/m6jx3Qth07X+c8k332WZZpvvZyw5cQZC8aWf2QSVYMgPGrsrZbMrW5CZNJ5WK5zgD6 kL5CWC/KjYsfNZ7DZY49LTcprHB1gUsi5cD9vypZLFulIaQDa6BjixlubovKAO5uFWi3e6WQoGyh dsrsq4UYBDjquoHl0pcTsoQhDbIBj5N0ReNO3PdKtYobFrjfhLA9rw0XJuEd7732WE4uILeyfHJp aBZWwNJQudcbqnuNvhDqsENF30hLIv8AhGCDdWGhQyBHCA7cbLJZGG7N4QBt7XV6SDfsryC3SWJs UMcjtLr7lUW3OyOMaeeFOQTX5gHKm4CsDVcDsrLbtt3SwMhqjFta4TGTiWZ1uAsPyi42/wCyZGx0 R4/dWwZmppB7o2MGm6xw4N/dZDJY3MtdZNIjmkj4SA6z9IWUHsIs03CxHtIedI2WqKPPrFkJAG3J VRENd6tgmXYSfhZAotIG42QON7e3smF3zt7ItNxeyAxgdT02Q6pG34CjGgO3Vtbqc6+1uFbBbgLW PCEtFkVwGbqr3bsFAId6XHdEDdvCt8Y2PdWAHA22sgBJAU1Dm6CYaW7qozZvF0A02Kst2RM0uZbg hA13q0lAKeLIWjUPZMlvxwgF7BAVbcoXubHu7/CYD8IywWuQCEAuN0bhc7gqwGtOx2RRwscNth7L LocKOISGGEa5SNgEBjt3F0JN3boqmhxHCZ3RVdO5ntcW2S7n+pAFch1uU8tsBvdY5NgFQk0uCAzR ZrLkIXFrmi+xSP1gLrW2VPnY57QOUBkWvZQPBH4ROjOgG+5Sg3lC0NBBChdZJAO+6K+1kIGNyqII d7hDrNtkQN7ICgwNdcd0X9PsqG5VON3ICObfuqtvZE4EDblV+QhoEhQt4V6uBZG5u1+yGRenf4Ql vOyYRtsqHdC0L0/KF/HN06wQSaQDdBRjsaQ699kyxA2SYS6WRwHAWQRosDuUILv2IVtuPdWD6j7J jRqIQANcQeN1biXWtsUbmkOv/SoGg7oaF+ppBJNk8TEiyWSSLFRpGq290AZHGymneyYG6m24KW7d 4+EBT2Pbu14H5RSAeWLm5QSaXGzuEQc21hwgB8u9tymtBjZYbqo3XcRwpI8hAAWGR1wbIoyQ7cjZ JkeQ4NbwUwx+W4OugH3Oq4O9ki5867ijL9O6WT5jvlAMfIXHSTsqvp22Q2sQhLjclAEX6nBoQiTV K5g3A7qmEC+6EO8pxIG5QDSSLqNG11A4yNR2DW27oALAgoQo6/tso3/CAoWaChY29yEVi4WsbIQX NOm1kAxvpG6Em1xblWQpa/KEogHpSg7+q97J2gFuyFrGgEEIWgHODnDawQy6NGyZpGqxCp0bbuO3 wEFC2AADtZFIdTCUDYbO1OO3sEx7LgeyEoTEwyPsNgVlyMZE35HZY51NN28BPleHxbAakKY5drBA 2KdRgtYblIDnNbsLJsdwy/dAGAXPJUBsCAVL2bcbFTbT8oAdZvdAx5JO+xRtu+44QxAOJHcIRjDS 3YdRPq5S2xtp26QSbJ/qYfUb34SHAukshSQybEkIntc5zSNgrDbmyNztLbDlAKmic14AfbV3TNJg t5hD79wqcGviOsX+ULGBrACbjsgLZdzyUYtc2AulyOLftQtc7VfugGPAeC08oXRCE27ogdw7uEL3 mVxKAEA23VeWNer/AAoHb3Vg2J2QF++6jVWoHjlF7boCntLmnbdcf6mzWvZcq1uo82WHUUvmyel3 q90FDGN2uTb8JhcC2wFiktcKdwbKU55uPSbqEoULAWCoN+Pypo0nZG7ZqFoC5uNG4HujuSdzYoAN NiTYq2nU9xveyoDdY21C9k5rY7gXsfdY7R6QXHnsjOljtxv2QDHtGr7illgBu7dG9oIab7+yG++/ CAosBNyf2ROaGgHm6ondQ2QlkcTcW2CS9l3G3ZGJHNVk6jcoLABGkjuFUBL3EEXPsieGNF1VHpbP rJt8ILCe0G4I0+yBt27WTpf+IlPYLHk2k03QnYTz5TNVzZULltzwd1Umowlp3CuM6mi547IKGka4 wkSREygjhNaCGnfjshEgtrsgAGlt72H5SxEAS7V/lXK4Sx2HCWylbG24cT8FDQX9VgU1s926Dula LW7KEBrge6Ch0rWsAIADlitje5xB5Kc53mnfsruCNu3dCMRu11iFHANBKMH1FUdPfhB0SMa2Fw3U NnNHv3QtlEbwI/t7op2BrrjhALf6L6VURcWnspxf5UBI4QhbXHe4RECw91QFgq2tvygK3B34V3sf ZVc2UKAJzgLbXJUuPZDdXraTZyAgNyd0TAN7m6F7g21lA4NJQBNeHD2UMYAJSwwX1dkTQQebhC2B Y8HhQk6djt7Jjru+EFrdrIQotu0G9lLOLvhEWE99lYOndATnlESC3ZA31kuUvcHbdAXpCHg+4RAX H4UsUBNI7hQbbdiqs5puRsiG/ZAUTbayEv2OyO3shO5KArXpIQk+o34Radt1HDa61QKdocAWhUG2 IKouDQqEhO4CAh3fY7/KsNCh2N/dCSL87rILN7ndEwEMs7ul39ijbu3dAGFaAIiUBYcGji6jXOuL 7NKEmw2Vl5kYABYoBpsflBYXvf8AZDfSLHdETwgLVEEqrW7q90BZN9rKrbqXVk7IAQQ3vcFXcKgQ DfsoLOJ7IA7ANSnEw8d08i7RYpMrdwCCgIy7Nz3VkOG/DfZRseo3v+yJ1y23ACACxFjbZQtDTtz3 Vi5/Cp9u3KAva6g+47qm3RBpAJQFOFwR3QtYSbHhHf3Ch3QFOBa0hqXTsc65Khk8s3JRxzAj2ugG iMt3SaiPU5pB3Tv1AaLEIBMAd23VsAtsBc8qOc0qibm6hA2PZQFgBAeeUYIAKHUDurYO2g0Ag25R TgBoNuFjwzeYG25CyJjqZuviqz6hw9S4yTXA2CwH+p9nLMkllMzhGwFvysGouJweDfcL3QXB5Zdj ohZluViTxsaHEjdZxIABbuVx9aS47BbM0LpyQW+11yRlBcADcFYFO4NLWkfsuViDbAgBRmiwDp9l bToabG5RXBNihNuFkAPf5vpHKAAt2IUv6tlfJugKISJm3WR2SnNJ5SwIbE+L1NN2nsn0sk75AQdG ncEdlAA2w3TGnyzsNl2jNoy42+Ts7p14qeofSmQQYLipmgB2hlOoBfR5w8dPU/NFdTVVRURUk8PD ohZdGTUlO5/mMbZyoU7CQSSfgruszSo80tNCTujtjPvjD6ldRMvHL+IYu6fDJPvaTuSuDyZ4gOov TyiFNgWJS00NuGvNl1++laXHSB8J8Eb4tw934RZmjHxIe0d1YZ47OtuFS6nY55wPAcOFlYn46ute LQ2fj0sT+Q5nZdGmKSd9i7YIzMKLZt3E9l2jnaJ8SC6Ox8Q8UnV/HYwyfNdT6d9pCCvl8z9Xs+Zs pxTYzjNRVU7eGOeSFwpqGTsa4sDHjul3BdsL3W5ahtUi/Gxrmj6fLfXzqVlKgkw7B8wSw0L22MQd wvmjn3Mc2LyYjNi1S3ESbmcPN7/lLkHlfbax7JN3XuIw5eWWSTNLBFPdRymMdVs/5mws4fV5rq6q itpMT5Cbj2XAYU1tFHZ7WyOO7iVkAXef5YZf2QNogx7rk2PZY3t9nRY4p2kObMA+7RZl/tCsUjw9 08Mz4XncOaeEuClMTzc+g9k6ST06WbKJnXroGTMGbqmA0rsfqzTDYM80jb+6VFUVtEGvbXzRzt/9 xjzq/ujaXIdDWvuQSfZdVkaMtJ9krMQxCuIlnxKpqJP9zpnXCxZjjjTZuK1jY39hM4/+VkSk39LA Arp6mSNxAFwPddPPJcHKWKD9GBFSz0lYx8z31Mnd7zcrkZXfqLOZLLTyD+phIKqN4fVNc51x3usi sqYi46W7fAWVladlcE1SOCrYameoAlrJpL/1PeVyEeHiFrXjUTbd5N7pr6lkjQ0xX+UcMkzm6T9o 4VeWTRnxxvo4OuoHyT3ZK/S7k6iENTgTo4QS6SUWvsbhfROjZa7xdA2WRmwsI/8AaVh5JMeKN9HH YdTFlIInxhjUdJLLQVJ0/wDLWXJeTfj8IdBHsVjczuuESrqqWpBZLYA8Fca/DaOMXu4tPzdOmg1X GkH2SoKNznWds1dI5GiOCl2F/C4mwamxtePk2WLLhUGtl4SNXJauQlgvZjXEAK4mPaRd1wtb2zns S6MGDDmNcdDQANr2TpsMjkHpFnHvys9sRubFWIyVNz9k2o404ZHFG3U0G3J0rlKd1PTxgE69u/ZW LuBadwlPp26SO/urvYUUgY8Jgq3ulcGar7bbpdREaYAshGx4BumMo7N+4g/BTo4Xg2LiR8p5HVFp XYL5GTxNaIowfkJM2HQui1mJod8LImpRs4GyVYsuC64+VluzQmNjXQeWeyk1CXRERyabhUGkOcfd FFI8i3ssEE08JijLJCXLHfI+OQucDp9guRkOogWskyR6hY7qqVMMw4y2RxJtp9isvS2WFzQ7TtsQ lfpGngWPumtj0bLW9mdqBpo2saGuIcfkI3MZKNBdotwQU5lO2Ttur/TtDvwsuTNUjFp6KOCZznSX c7hZZLfTdocB/lKdTNe65BushkewCJgJ77t9DNI+EgVn6UF3l6/grLvZtrJD4w7kXWrLXoL9UKpo kbCIrdvdIYSZbkkBZTLBtgrtfayN2aXHQD4WvZcnUfZH5Yda7RsmMAAsQjAaQbo3wRIwpqeOW12b KN0xvswaR8LJcxoNh3S3MH9lNz9Fo46SlLajzWPsfZNdUyaTYEOA7LKdGAQVWnmwUsGHTzEElzd/ dHUPfPFZg39k10IHCZFGWnV7IVMwKKKppHbSFjD/AEdllyapSC7lOkb5rgeLdlYASzNmP5fPylMp tDieR7FZum5VafdLHZjRB0Tjpa1t+CAmsmklOmS7gmCIW2RBukKoUKFnOcNN/wApL6ch92nSVnAA NSHgG91pEaMZrbA33v3Vfpm6g6ydpV2+VDPsGRtmXbYOHBWOZKgG99SeWl1wFbBoBBQpTHudH6wD dQBx77Ixz8JgA9kKAGm+rlXouASN0Vj2VggIWigCAo5riN90wHsr4WrFGP5JJJG11G07mHUCQVls FwrAuVGZ2iGtcT6im+SCPhEfT2VeYRe26hVEF8TSNxYBA5riA0HZSSW4sdlYlDmgIbQp0N+6EQlt 91kBzSbIXANKtlMV8RuiEW24Txv2V8rm+TFCmxWKdGzdDJxYLKdpbTx6fu7lBQoDZEG7b7q7axZU RpdZCkLARayAwNKMusUTQb3QCBA2/FkTYAL2TnfAVgDvsqgC2ItCOw2HdHE70/AVG3ZQAlo3sgMY PYI7En/4V6dJ3UopjmAO7WQGnHssm3KBKIINMBa1gja2zd0wpY5U9AkjQ5o2WF5LWvN23JXIlw3s sZw1OulAxv0+5tsERi0i/dPuX7WsqI7FCUYcgDnbhOjNwNlHs3RC52tb5SiUR7g0Xsjjl2uO6Esu 0g7oY2GM7rdgbo1XKS5u1kzWSebAIg27gVAYxb+6X5I1XtusogAXQ6QSrZBIaiaN7kXTC3bdURpG ytgVIzU69tlbWEvsUTblW9290sAizTzum+XcbhKLRe6MS6RudlAG5jWodNvtUcRYbpsdiLgcKAU5 gcLOuqYNBHsmzbbe6Vu0fCFRbHONSdJ9Ke8G1+ClRjSb90Vi8m52USNAuc1rRvcoSQ5t7WSi/wAu o0ubt7pzmtHHC1RlsVpG/uh03KY5u23CAMI/urZzZekbKbBWhJ3UZpKgg87bK2WJQt4RhQ0mG61h bdRzfTvwowho9W6YwtJ9XCGhBswbbqNI0kjYpkwDXegXS4oX6jf7UA6JrZGb8KWadh2Q207BEGoC +6r33RNbvcjZU8C9kAO4bcq2HUFTRcaUYFhwgAcbdkNwO9lch91QAfYW390BTXkHfhOj9RVjTEwg +pDCRclAOjAsb8qi0ge4VtsBdU554QCnXJ4sriaTe5Ru3N/ZQm/Gx9kJyWNjY8K9Db/bcJbgXDck WRlzw0aBqCtEALbi4BAQnYbrOdNE6ENcPX7BYTgLkKFsS5tzsqLbBNc0BVpuNuEKKsEJFjvwU7jk Ki0FAJc2w53VFqYW3VFpv8IBVkLm33Ti0WQlt1AJLNRCa1parDLFHsGkFSwU3flQ7q28qOHsoCgL 7dlHUjXDUDwh7omkoCPLQB7pAaRJtwnluw2SreongIWzNje5sY0t1FNIv2sfZYcMzobkcJxqySLi 5KppMbYjskTbp4eA25O5SDMXD7T+UNWC2oYRp0C/unaxtZYhu0mzeU9hLtjshLCfYO3VAi+ykz2x gF3CEOa6xH7ILMlpuoCga7Szjf3Q+bY2OygsMkOdcIC4tPygL7NJHKWHlwNzZKFj427knko7BoPc pPmBsQ33Vl5cAVqhZA46t+FbnAlAXkAHSlzPLiC3b4ShY79RY20/ugedR4QPI0hCHlKI2W5t1RFl dt1HGypLAaoTYqjLqBCC9/2QWE4m/pTXCzWlY9zvZANY90JY98hA3UjaHNuktDnkk7otL1KLYwDS qNm891BfTcq7BwuVQQEH8JUps7YXKt0nZosqe02/8oRiSNTrlObJe26Vb3V6bclCGQ0k37qCQG7b JLH6XJzXN3uP3QEdIWcbj2SnPL97J5vZpA2SnizrgIAOQnRNG3b3QWuQVbZbnZAZBcIhq2t2SDVg i9gk/wA0ucHizOyt8TWtA7oWxja5ofuLE7J0NQGPO97rCZE1544UGzyPZUWZbwHP13UJB4SY3NBs TZNu3sdlCC3SEbBQPJ5V6dRuNwqH3C43QFe6Sb3IJ5TJvSbjdEJWOt6bH4QCrBo+VCQNzyiLQTfs qe0E2QyY0h3PusZj3scRys6Vlm6rcLHeCXekWB7qpEAheZNTXflE0B8lu3uo2N0Lyeb9wrHsO3dU yFUM8hwsQQlO3F+xTJBe191b3Mjjta5QggXKjhqFr2VBwV6QDe90ZGXf0hLdeRwaG3KZGd7AJsYa yVru4CIhxksv/EllrFqdBLZ5FliMaTiT3PGxN7rlHUjHO1N2KoL1gAX2V6ja43CWWjXpKON/lXFr tKgJqKJtzcJY1E3A2TGO9KAp1gR6UAh1u1EEeycrDi0DZUFOhAHKxiw6/hZusPaUkMD2n4UYBi0h 13cIb6ybDZEWgNsFTQQ33UoAnYbcqj6W3Csbu3CJzAQADYJ0BIOreyhNkRNnAN3CpxGqx2V7KiDf hS2yg+AibG7UAEoUAGgoXtuLJjtTSQQhvYE2SiCAzTdZEbRYAjdL0bhwT3m4bZKAt53QW1OAA5TD vsqYXMdcKlsKShlgeCSCw77IGNN7jhU+V5uC66ASFu10A/Sb3uo+TTsCsd1RZwHYoi4G190FBgm9 7/sjs5wQNDS02O4Rl9m+5QgUcguR3UMlrmywopnOlfYInyljwTuFllOQiOqx4Kua54Nikxz2aC0c K3yGS+3KpAC+zSCboGzkG3DSiY4NuCLqeUHA3UovoyqWYN1AXKqC8UrnONwexSWEx7NKNsuo+rlO RY6Rmu7wkvmICPUQe6TVnSAWi6Gg4qkvBGmxWTHU7BtlxnnPsC1u6yWvDWA/1HslAzX2kALG7hVK S2LtqUpnuEdgAkVDXOkc/gDlQgqR7z72TtLjbeyGNrXWOq4THsbZwaeeyCyaNIuTce6JhaTtwUiM kRljjf8AKuGQWsAbhCjJY9RFzcJJFSySzWgxJ/mgm3dD59nAXsEAbQGjjnlK8pxk1J8hbYaTyhJ2 5QFOZq5SpIyAANk4j07bpc0oABN7oCi0Wb7oiNWyU2qZweVPO1GzXBAR9UyH+UR6jwQs3AMXmwHE GVMTQ54NwHLAkfE14LgC73UNQy2+xQH2Obc3VucaaMz00cL4xYFg5Xx7A94LXt0uHuijrTCPS5W6 bznhxkAd8qJUHyXsG6eUtzN06OPzCdJBIVPa4C43IVAhwER1EXVQs8+XU3gJzf5pIcBbul6zA/TE Nj3QHIB4e0A9kt5sNkqklL3OD+eye+xFuELYtpKO1+1vygdYAi9kvznkcGw7oENablzbWspYK43+ Z2srLbEIUpr7k+3uoSELja4Cq23KAIO0nfdGN0sabbm5VxC97lAMaW8dwhDg67Sl3Eclh3RhmpyC iXDLAbqvtKs2DrAfuo725QAPO6U8lxAt+6cWXugd6LWF0ALXeRYab/hXJCWkTXP4TmPBG43+UuR7 nXb2QUWCJRdo4Vx91I2ljLN2S9Zja66EQwuVFY0dQZTsOFk2uNkLYyFgcx21ylQ/803P7JgeYxts lTvsLjlAN84Mf7oWz+a4ixCSxuoB17lPsR7AoRFPjaW2PZKN2J9rm3KCaP1AXQpTpiLfKtxJ9Pug c3gW390XdAU0NYPdSQeZbeylr/ChG6Ap17BNj9IF+UA3J90TboCFp1XQlh03Rl3qRggi6qBji+rc IjuO2ycS0bkXSnFhuQFBRcRubWVuiLjubKNc1tvlMfIwWugMd12ONyh3vcK3PDzsra6xHcoA45nP LW2GyqQEybFW0AOJ4VEb3vdAyzwhJsFZO/yobudwgJe7UNt72RPYWW9iqttyhkj3WQGMucHX29ld t1ZOkXQvIgtc13OyyJNqa5NglO9ZsbopvVEGdkFFQG8BceENw8XabJjW2i0dlTaaw2NkAVw6191Y ANxdCG6QbncKNeARbc90KWWm/wAIS3e4KO4NyTsoHAtuOEBTWuv/AIQkmL1K9biDpQG7xYoBoOtu pyBjXPkuPtuia4AbIWPc02CAsTOEhaY7Af1IXanO42TTIS4A7BA8OZcnhAVpu3TdWHhp0oWv1nbg 91UI1SWJCAa4jbZAHXdwmvbY25+VjteWy2HdAMab3A3QAltxb+6aXaN7AkJL5NZDiLfCANsZDNV9 /ZU4FhBcgEhd9p4Vyuc9gDuEIwpSNI0C5KqMFrDqNyjijDGC5uEEri1ptshAmPaTylFpLjYqMBAu Ud7m4QWSwfYPbf8AKK19gLIXuvwhkJZZC2Mc3YBAf9vPyquDHYndLLrmyCyPDmkG1wiB0u2HKhJc 0gcJL9braeUKZAsWkX3REAtuTchLsWtFx/ZWLDvdCE/UjUA64+Ux40t1D1ApFQ4OAsEUcp8v4CFC jeeXbBWeSRdLdUax+yIynYAIRl6lNWypzrlCXIQZa7fdB5JI1AIfMsCCrjne0WtYIA4nmO+scJYt LKSB+Exzy43O/wAIS46vTYIVEeSWgWJQhohcHE7eyO9m+5KFw188eyFCa/zH37FSRrSCBx7ImsFr AWTHQBoDgblAYxhG3ZACA6x490c0oLyPZLLvSdtvdBRZN9wdkt7yXcX/AGUiGsG3KNrHPOkbkc2C AEOsLWt+VWog2QyOu4t5sprsALboGG4Dnug8y7dwoXXNrqnAP42shLKc4N7WVC5Cjhc3VA2QhCTw VV7H2VkgC/JQ6tYudigCJJ4UJNt1AdlDwPdAUHbKXv3VkcIe/CAvdQgHcobnkcKi4oC/6htcK3FU quboBjG3CLgcqmu2QuOyAtrru3TO49kEbe6aRZt7oAJG+YNtvwhJs0N5KvW8OFuFZAaQeSgojWki xUsB2UNxeyG5CAsX3sq3cLDlXc+1lVyLnhAW672aSowFjCN1GWO57q9QuQgBuTdRvNkVgBe6DTqd sgLAOqxQPJA2CIahudlRKtgUGm+/ClrEoyLnlCRZUCrOL90wWIVHlXsSFkFiO/dGRYWG5CQ526Jr jcIBgvb5VoQbkq9kBAbK7qr37ISbfCoDLht7q7jlKLtlC7soQbcbe6sEHbhLik0XJF0mSUOJNrfh CmW4aTa4KopEMbmxaySQfdMDtW4NwgDPAClttlQKiAtp25sjJ233QarH3VlwOyAvUBx2VeZq5VbW 91drIC2v03FkLxc+90V9rqmEgkq2AYwWj1I9QAPc9lT/AFMdYboW+hrRa6gLDg4bjdQjZVsLlULt 54QASx+bYcK5GgAAbWV39lC5ACdgO6sbXupqshc4EhAHfb5QSPAFirJAKGSx73HsqCNkDhtujsAs UOEd7clEx8mkX5UB2thcYdPIGm91nT+kOFuFx+BsdB5hdufdZspdI0hvK+QfSOBrXOY4lriCSsQP cLX3ce6zK9ribW3WLGDqsRZe+HKPM+wtRABS3gSH2TizUCl6gy/uFWQVC6OOUB97lZlJKZah9hZj eD7rj3+qUG13BcnSvtETp0uKyyobI7Ubqg06b8qOjOm6Kwa3lZKAI1NkQd6UI3B2QFEbKtFlDq2U uVKAflh1tkTYxeztwhaXDumxuBk9X+FpAoxhvAQFgIWVYNPGyEx2JPutEsS2IX2uUwM+Exhbp2Ny EvX6zfhaFhabjixQGIO53KsPubdkwNPI/slkEujBbYoom6T8Iy029ir0mylkKMIeSCseRhaTpsnF j73aTZBJGeSd1oCGlxd6haycXenfdA65Rj1BCgC17oi1pufdQsv2VabHZEATHvcHZUWaijN0IG61 ZAHtDeUnQL3CyXN1BK07oKEMh1ahexTI2lnKYxndWQLgISiixvICovLAidY/Cmnbm6EALtbgEUgO 21lYYQQbXUJu6xFkANihc07WKbayjhcCyGhOndTSmG11VlUSxflgH5RtaPZC4EFWy+q9tlqzLCNr omAEoXCwNlTQTudkbJQ7QG7oHMuoHANsTdQuuNlLKiAKx6VQsN1WoAkKkYxzwWke6w5G+s8gJ+m2 6B7Q47oQSBYbqrWamObbhTRcLIAsTZWQABsja03vbZMDA5vCGqEbXAHKojTu64HusprGhu7bkKNg MrC11tPsoKFNlaWjSNvdXYk37JzaZlOyyW9oGy0iUCwepHexSxs9Fw73VAZd2VAXJUtY83AUALjc FCl2t2QnURtsmgaQgDHFxIFwhSBxDdzugDiBdMLL2sd+6MwAd0AN7tBshfJYbBEd/TwFbRb091CW DuR7ICT7oyCAQq0XCpLAIGm99/ZHEETY2abG90egNG+yrBC0cBYlS/yXsA7rKcbD08pJpdTw97r2 3siIWCLXQl4900xgjbhJc1oBHdKLYYfspbUfhLjadQ1DZNY0hxA3CItluJGw4SnWf3TXOvcW3So2 WcVojKDO6vSmbD8q7CyiCE2N1RZt8poar0qMUJ0kbdkyysqtrJYLBVWBKlvhGG7IaKba6O+6EN35 V2N1QGHdgLJrBsgZb7f6lA8t2J2VBJNhwladJ1XTS9rhylhuo/CwAXta5wUEem5ARWBfwoS6+249 lbAsCzuETxvdELht7KiL7oAAN1YCLayllAQccXTWWDOd0vnvZXp0jYgoB0Y0+ooL6nXQSSOay3JS 2SkHdAZIDDvfdU03JJOyx4XgSOcblvsqlkc+W7DZqAymuAcfayJo1C3ssfUQLlEycXsgG3LRbspq PHZRseo+6tzbG3sgK43B3VOcSB7q7i226XJKWi+lAEHah8hVbYpAqL7cJodvsUBFC2/BRWNt1RIv sgKtbZCGajYInHf2RMYBveyAWYtOyXKLC4bv7rKJ0+xusfzCdrXCoFC5CtwJFuLJrvS0GwSy7YqA poud1R3JUP23VXsfygLAARdlTWk9lHEtHsUJQLxz2Qtba5RNu9EhQSLILAlG87Idy61hZCUQN7jh FGA4nZCXOZwridYkk2CEaKdDpNzuClysHbYLIdOGi7jsViVErXOaAbKogwWFgQmh1hZYQLnPAvcB ZcVi610oDWsJ3d+yFxsCgk1lwANgFH2Nh3VKWH2Hujj33HKBgJNiNlC4RuKFsAtdJKS5tgEywA4R iUOFhyobKXZkWdwq0ox8qjylAEtHc2S3gaUxzdQ90Yj9Fy3dQCGAWt3TQ3bblLMZab/KfCDdADxs VQu0p8jBG3WeyoPa9odyChsE3G9ro45DY6hZDxva/wAIvMsdwgLDNibKg09kxz7gbbIDzYFAE1+s FrhZAWa7ngqnE37IWk35QEA0lErtdQgDe6ACTc37ImgeyFwurA1wkDYhAFJCC0OHJQtGgWtsoXOD BvurjuXIA72alvJF9rojIL2tsqtd3OyApshafUE0eo3SnDf3TGEAD3QBWD2m+yqB7b6dSjyG9rpA bpJcOEA2WJpfqBS3m7b91euyhBAF7ElAU4EhQ7NsrPZTQHG17AoCMaLbpTzpKZp0DSHXPuluvcf5 QFONlGgOVjjcKiy5CAhZfuhA3Ru2btyiYwv+EAt7CON1PxyjtoNiVRbYXupQARDcFW5ult0rzQ26 IBEWBshaVDdzQVT/AOypEG57bAXuUPkl42KBrTY9ldiBs6yFKsYXWO6YSXkdrKogHNLn7lAZBcgb qUBkkhAsjbUMcwtDvX7JcWnV6jyoaJrJPMad1S2Wwkfcj1c/hLmFnNN1V0FmRE1pitJ6rpYABs07 JfmAs1A7K2c8oWxomdfSePdLlcORuh9T79wq/UNjaWltygsbE4EEFSSMEcXHwkxT+vfYLJD26bk7 KULMUxWHpRMu9p34RSAaTpN1jlj2tOk7lUyZQkOm3OyppBuCseF5Y31H1JsZ1XJFrK0C5HNADbfu rDWhA2Zp9I5UJuoAyQlO2uLqnlzTzZB5n7oCOcTtbZQAEcqB2x2UbwdtkBLWV3IHChuBe+yLcAW3 QFPBay6X55DTtuobknbZW2MG+yApspI32VPlOoNVPjJO3ZAAR+QgHnb2Cp2p7b9gkuLpthyFA4tF jyFaARI/dF5esDfhK1C253ui8wNdYbhWiBOcCNuyuCQbh10OsG1hso4WH5ShZktma24O4QuBINhc JGqwAsmNmLeBspQsASO0kOFlI4zfVfb2KKUiXcFUX+mytFLkOrvwhd6m7hS9iqL/AFWQBXANgg0n USo4kOG3KO+25QlCx9wJKY6RrTpaUtwLm2uiYxhFjuUopA97TzsmtJQsLW3FlHSgG3AUoBFwvuoY LG44SdYkdt/dNEuhlgVARzXXtZBquTvumtLXi5O6F0TNJPdaRGIa4Wdq4WMZHsdYNu1ZJbYXsqcb ttZU5spjiW7AJRb6vYlGDY27KnWLtkAOn1b72QSRCQ6k5pAvsgc7bhQCzTgfhUBfgXTQ8kW7Kn8g IBYaBcK4/UShc4NNrqTyeXSudH96nRll/wAkSAyWb8+6yHaHsuw3+VitpoamJvnE6rX5VRPjjcGN vpCpBgj9d+6I73BGyskHfhCLkoWiAlrbDb8qg2297K7hQ2ShRNfI5CNri4AgXQcAomk2sEIGdmns UkSEOIHdGQSRfhR2l3ayoKdY9kLhqOxU4BsjaA1tyN0LQstN7j+ygAIN9lWrSdu6U6QtJDjYFC0M c46LN591TIdtTuULJQHaR/lOkbuN0CJFGCbcJ3l3BOoJXkSEXbsFjRF2pzXE2QjGzFVcGMDghE1r Ryrdp02A390IJ1WRsdcJYheZQDs33THM8s6QboCzyL90sjc7qy8tHCpjiTwhWD5R3J4KXLEQOFkt eC0g7AJbZQ5+l3CEEwQGU8XAQnabT+yz2EtFoyLFImibGS8G7vZAB9jwPdEfS+3ISo7yvudrI3uG oICr2uA21+6ERajdxA/KeBZtyq8rzBcBAU1ujvcJgO97KgAWWvYhE0BDRCGWF+UPmW2HCJ9hulPN xcDdALlqA3YBFA4lhd3STC6R2p2wCZQgiJ5fsb7IQyfOdos0+r2SRMSbHlUQYzcGx9krR6yShoyY piH2Av8AKprSyoJdweEuNxDtlkvk/l3AuUJYdO6X1u/p4AQVM5DS1vdXDJI1t3HQD7pr6Nwa2TU1 7TxZRgwf1RhAaQbJrZGyWOsgoatoIdcWtwsSBpAuSoU5JzON0xhsbXCxw5wiva6kEm9ylAeJGl1h yllwM3CqIl0ziLBQP9brjdANebpTi5pvfZELubf+kJTxq5O3ugHR1BuN1cjtbrAg/Kx/LBZs43Cq N5FwOUoAPOmQ+6T5ZY8yXt8InBxcT7o/JLmi5UAUREou8Wsrc1shFtiqIbCd+FROsBzdggGiNrGg E7oTTMnNtwmRlrtjv+ULm6TcFALEzqUaGE/us6KciHfcnusAEuluQslxLW3BQDAW3v3RiNrWE8uP dIZCXt1FG2MsH3XBQBOl0OGkb+6n6ggguF0I/uVDwQgLmm1vGnZZAn0x2EWorGjeIrtcLhNp5SSS 3/KAItL42loLDfcJhI2HdRxcTcn9kpsoLuOENBusUGkyXF7BNib5hIdsEnVokLRx7oRlaC37fUQj YH2u7lFGAx1wbhG54LvZKKgAN9wmXAsgdcIJZdHIuUAwuCAA3N0qOQk+oWT7hzfTwgBDwLqr3Ow3 VPaARYogReyAE2O/KHUXG9twrJ9WyFxDgd7WQlh+c1rbE2S3NMpPshLGusbklE65bZCC4mBji1o/ KyoW2BJ4SogACO5RucWs0jkoaLklAHGytuiQWJF1hU9PM+p9Z0xpjWxmRzXBzXA7OQGRFTNZL92x 902qoYpWbSEH/pWJI/VE5jfu90uhZUUsh1vDmFCIzMOpXUodrOoHi6a6PWSb2sr0mc6m8eyWYZmO JLTZCgOGkG26Am35SBVy6y0xnb4TGueXBxGyAaBflT7eVJHCQbGxTG0rjGHatV+yEQoPB22sivqG yk1OWt2N0oyFtgNkKM/qRXsN0LRcXUIACAJrr7WQPLRyhcS0g8Ap4hZKLl1kJYkN8x2x2R/p9XdT ybO9JsPdPibfa+wQUYT4xGdtyiZvzymyRnc3uq0kboKKa4h2kq3Wi9TuFWkveCP8qpmeYS1x2QoR e1+43Vtc1xvwk6QwelEPtv2KEsN9rmxQqmgPIvsie6xsOEICp+VWpCXbIaD27KnDUPZDc+yvUhLL BsLFNY4C++yULFqGV+hlhwUFknYA5rw7YqVDdADmnssedxlg0g2sip6oGDyyPUPdBZb2O8kEHko2 nTHYndKEpLdPYKy4usELY1stgQG2KrZLRNvfdDIYRXIBsoRpsob2QtlAXaA7nsj8y40u3CG9h7lU W7AkEXQIhe1mwQwM0yFx7q3MBF77oGSBziwgoUc6VxlDQLgoi0B3FilvdoaC3kJpkuGutcFClj08 oXsbvcXVbveLFMe51tghBcbG2s3YnugkgLnaNV09gA2QOiFwQd0BjmEtcBdSpBbpF04RuLySbqpA 172i9yOUMsVqsQia4F1uE1pZvcJboQ31DugJcA2tdDI65tbZWA1o5uVCRZAA0bbq9IVF4BCrVYoC 9NgbIHEs4Rn87JZfY7cIVF+fwCEQIb25RRWLxcbLKkjjI2QtnHySWuANj7pTS4Ai+x7J9Q0NHG6T FdzkJ7LZGWo7lhVk2HyEt0hBva6FYwO2N+VWq5QB99zsq5QyMLroZJXkjSLoQ/sr1G+yAa4kkE7F TglAwlzt/wC6YWexuhUAXEFRznOIsr0HYngIWawTtYIUyYahgcA7crNm8sadPcd1xDbMluRdZskz ZC0jayARVsABsNyo9pZSAAb25TXkS20i6GXzXxhjbXQFUEbXM32K5GhomUTZHlweXrgppH0psTyr irZQ0i5ugFVFocQkF9nHhMNiULYfOcXyHdQv342HdAW4aQSga+7T7q3Hgb7pbWFp2KGRhBtYqr// AKlAS7WmTEFu2xQC3C7eVTbWte6XYk7HZHGLn2QDLq0JaQoSUBdwVd9ygBU1WKAMDlVY3CgeAqJu LBACRd1lNW6ou3NtiEAd3HKAbqUuqtqAsqAQDI02S1gLpQOloAVi5QBcG6g533VXur/ZA2Wq4O6v lBISDYblDSDAJI9kbovbhVBqeLkWR3drtfZAA1ouL8KOj1EmyZKxsRs31X3v7JYJDL22QULc31BF p07nZGSCbhLe/dCMtzg4WvulcXQaw07oTN7BCDLoXG6V5v7KeZ7lCBu5Sze/wrEtvlTlUA6w1XHI C7m5CvS13OyIQxhwI2KhQw4BR26o2JO6pzm2VQDBACBxBPKBrwe9kqWYMNhuoQbqA2KFzxYu9kl0 gA25KVqJFvdCWZYm1C4VAF26xw8s27JjZbhCmQHODNN7t9kcZDRa6xxKCnMkaG7oBuq26vVsgE7C fZG17T3QWXzuoCN/lVfe/ZQEKooV7BE77AUAeLboNXPf4SwMa4PFlYNuEoXAJUEu1ilAdcjhVu5K Evwp51u6UCnNLXj5UdG7Ve9x7K2S6juFRluSFCFm1lRNmoHvsfhKfNYn2QoxzwAl+ZfdIklJ4KoP 90JZkGTup5oJF1jaiTsia17jsLoSzkWTU7iC9uw5QOkptRs5wCxhE+IXfGQFPSd9P+FWWztakmsC Wb6jdchE4t3IssKkMbqZgYd+9lmarAAHZfFTtWfS9mHXU4c4uJ3XFFvrIA2XL1btIN1xg3JK9WOT OU0RkYB5SaiNgaTfdZA3YLlcfibS3SWn8rt2cy2Rt2tuVmMLWvDS5cfSyaTflZlJGySQvvf4KFRm yG9rk/slHd23CMnZL+1ve6yUYGA7Ki22wQ6y0b8oS+5QFvv77ILix7qydRO6B128IKJHI5zuP3WS 2LUbk2SGHbblZDG3YASqjLGt4AvdE4bc7hL0HaxRtbvzdaALGhl7d+6AJrgNVkL2XIsgKDQmna3s lAEu/Ccd7IAXygWB491C8EgDdBLGXDi4RwNDYz7/ACgDJsqDGuJII/CBkgdcd0qSn33Nr+yAOWIh 2w2PsgvoP5TftaG+wSnH1b7KgIEEITsra3SFTgSLqgojZDujtwr0X7qgUdkP7IjcfJVWJF7IACCC mMbdtyhdsAVGei5O91UZYIbqdcI/Tx3Ua3TuoRvdUhQvdRw3ueUTLkkpb3eo3CAhcSLKHgKHYi+w R+XffsqGwAFC35TNNkLwQrQFuFt+bomm+6p3parisbKkYbmiOMOduqLtYFhYFXK4uZpVE3AA2t7I UU9pvtwpxsjsVQF3WtuFigQnTbugLgRe6J5G9xY+yAAdlqjPAQBLb3uELjpWVDTkxkpErC4W4slA WDqKK2yIREtBAUDCsiiNFrq7C1+FVyLq7+lao0W3hE07hD9rd1V9Nr8JQGPOqT3CAsL3HsFWvuEb eLnYKgxZWhrhvuiDTa5/wqePNqLjgJjSCDtYoZBaLO2PKOxY7YqmncCwTLaSgsMb8qmzaDp02BQN kFuU0uDme590NFMaQ8/Kt5AOxvZKbK7U6/tsriHp35V4A2MOeL247qHS037qhLoPpGyU+UE3A3+E Mlm5dfsr5UbKZBYCyh9I2KpCtekgd1cjrlLa0vffewR6r322QANdckBEGF3J2VWG5U0vAvvZSy0N ZD5bbDgpRYGk3KNzybAK9AdsVSiC7WLcWTGEhW6MX2Fio0XRIpRAcbE2KSyUNJaeQjlF3AjshmiM tnAWt7KmaLhABc5xv8Jgbq3ulsaLW7pjQWqFolwXbKyPTzZRzQ0X7quWgDkrJBbnb8K7DTe+6a2L exFvkqSQDTsd0KioTdHKLt2G6TA0sv3TfW0X5QoIGysk8hU24JuFAd9kBAwg6u6qUOcAUdtuUTWD uqBMRDDuE5xAO2wKohvsCq1e6gJyeVWuyvZw+Usjf5VVezLCDiXfCtxGlCDYKiUKgvZEGlBfcFWS QfhGUPTwqLdjZUZCqEgBsoSxbmaLnVc+xVtZqbe+4VmxKgF9ggsMtAh3G6HTZv8A8KtBvyrtbYoQ gjtwUJs0+ytjruKJ4uLoWxsMoNgCsl7Rp/K4tuz73ssqOp0iztx8oUYXNa0pBla4EHurke12yEta W8boASxjTcDdPYBbjdJNmi6YJmiO7R6kAzSHD5QOi1AWNlBJrjuRZUw7HdAUWFg3NyoCAPdWPWL8 FQjZAUBq+EsXPwjLtXGyoNt3QFEW54QuI+Ebm3FgdlPK+EAki5PsrAumPbpZ8pdyBcNugJ5vlm3c qS3I3QFmoF55RNJLAgBa8tcB2TLtdvyVWwuTyqbpN0BG+o7omMBJVtt7KiRFckFCMEi5tZQsA24C OOVrwhJuSEICYY3N9RsEp9EHOGkpxia8XPZCXloGngHlCGEYZY6i1zZZLbxlOedTbjdxSWscbgrQ GXvvfdUQSbqQgG/wiPKoLYT3S3vBeQdkWoh1uyTKCZLgKAdGLm6INId8IWkEbHeyJkhcLdgpQIbA 7FVq0/Ks91LXSgWwjmyPXrbtyk+XpBN1cY1bjhQDhHqFibK22jaQVHOLADylzXu1x7oVBlxlGnsq 0gWaBsEUkcjWB0QDh3uqG4v3Q0U4bqAHfurvsLhG0bICgdlCAVd9yhb6nHbYICBhIudkL2ae26su cX2GwRg353sgFjblV5ZIJum3F0I52QCyws3PCNp224RSXkic0ix7IIYntYNWwHdAU6TShDy03HdX ILG/JUlbrADdkBbm6De97oW3cedlbdm2O6mze6AjnaQbKMdsCSguS7nZU0WNr3QD3vFtkovLhxsq sQ7fhNDQRccIANOoKyLAm6gsAbKgL732QFBxLUQOo/CHSRdQGyAIlAVLX3BupfY/CAmnU2wUafKB vuVbZAALhWAHEkoAGyC9ynMANyEvQDe5ARNOjk3CAp9iLjlADvuEfNyFX/UQQgJoc4e4SZI2jkbr LBFx2HKx5HES20mx7oBbXWFlPu24ujfHoOrkFIc4uJtt8oBhBA3HCx5nFx2P5ChncTa91QNygDa7 S2yW2QRuO1yfdMFgN0mQta4EboA2uJ1ajv2SXOmjeHNkJbfcI9Rk/AVts3ndWgMEl3i/FlUkgbcj cWQuO+wS5CQLEJRC2MeWl17Md2TRIWsAHP5WO5z9OkfaguXHc8JRLM8SAstfdAS0N4u5YZJ90bZD YAbq0Wxrnl1yRZH5w8og7Jeq7bWULbhShZTZPT6SVRe8bAq9AbwFYaoUoMeHA8q3GTWLXARNlLfT ZMklDwLCxQC3Bse4+5WyQ7u7oQAN+6mogn2WzNl6y526EPu+w3CG5JNlQOkkqUWx+nUNjZR12tty VbCCwEHdJdMRJ7rJLLY4k2dsjs7VfbShlBkIIFkUTXcO4VoWHeyOKziR3QG5dbshcdO4NioaBe4M cW3uUkgh3sjc5pN+6Fvq3WgRrtJ2O5VaQX3Juo5oBRbA9lQKc0hx2vdVYhpHdMItvdWwX3BQgtm3 KfIPSCEl4v3VscWbHdCB29I91dwAge5xf6eERGw3QhdxpNlCAWi6Eiw2VgXABQoWnbZAWkXPZHex 2Quk33F0IQPBHG6rlu/KliRdCJAHWJULZRg173sUccVuSiDQ8g3RaxqtZUWWbcJUkd/wiJN7DdA9 xeNINkBQYRc3/ZU03G+ytrXBliVTgWni4QhZcH2ANkMjnM/HurLmOYTazljvkdbc7ISxjZzcA2Ke wh3ZYD2mIB97/CfBM6Rl7WQg549Du57ICxrWA3uVYId6fZU+xsEBVwR7KnNu1QM1GwSXyEPDbqAY fTZU4at+4Rm2nflJL7Ej3VAvQCS4prGgt2/yhsLWKn/LPypZlipY3eaCEzQwAEfcFVy513cog9rA b8JZCjcgCyrWWOKoyg8FQbi6pbGNcDa6s2LtkthuCiHCAIqAlD3Vk2UsgQPuVdwQgLlRNgqA9htd G8lljyEkbgHumteLb7oaFPo3PnEur0gcKGkNSQdueFkteAONiqi/lOvsO4CFMc0M0lSdgA0Jppy4 b8hX50pmc5nDuU6UOaG73vygMKoMkIaxrt3d1k1eFuoaGJ7vU55uSoIQ+piLiCAV9Hi7YJqOJrpA yw2ugPlmN0N1coS7W0kAgrJlEcfpDrn4QtaNN/8ACASxxLfV/dKlPcLJc0W2CTKQDYiyGWALOaCd 0uQlrgGmyHUQ49mqE7AlCEe4g+6VK0zEadimB3Ym6obO2QEb5jRzwllzmvud7rKa8j8IXWdfbdAL 3B+VYsXboQSzci/yrJvv3QBG52vsja8R2ASibjuiDr22Q0gnM1Ouqc8sce4Vtcqc7V2H5QjDZIHN s9EKN1SweWd0tsYIsf8ACYKWwuyRzD8IVDG4XPDu43CI0xY25tYJ0D5vI1Pk1DtdIlmI5N7nsgoU 9liXELGdJY7jlZpN4yAFhSXL9wgKDix4d2WRGHOu+2w4SWgOBCcJ/LZpshkua8j2h59HcJ8MjYWi xPl/KxwRI8lx2A4S4nGW7W8IUyapzZB6TslMp/TbVcKhCdxqvbsr/wCXexQByE2A5AHCNrGvZ7IW VILbab/KbcPaABZDQiWndGbMP5RWIjuRvZGD5ZO97hAA+X0jhAQE/p7dkuMnRv8AarJIBbyAhEmt tvZAESgsLqylk2KywETa6JryRZK1HhGzcpQCcwPFihbJ5Xpt6UfI2Sy4WSgEAGuJva6u4vygDlLg lEBhFxyiYdIsUh0mh4uDZNc4HcG3sqAqqofG1rWDn2TWvHlDUReyxQXHc7qFwsblRgyGHWNXsrDy XWCWx7NAtt7pkQDQXH7VAQtNwXcJonaw+gAhJfIHjSOPdDGNAtyAgM3zGEXcbFAANy1Y5j83k2AV Rl0brAXCAzA6zFb3hzGjSLpVy69xY9kcbbj8IWyAcADdHoGyg+7YK+UKFs48JE8fqB7JzTZDJ6uL oDDkc4EEtNgiY8k3/pKe5hIsN0Bishkg4vZQy90Lrg2Bsh08hAC+Ug3HCEuu38ozHa3dC9v7IAg4 C1uUWpLAACsOQDGkEgqSODXB/YIAfhU4h2xQGV5oqGtLdghnqAQGtA1BJ8zyx6eFTGAuLnf2QWG1 993N3+ETn32tsgJ9ksay4/hAGa91LsDssykxkvB1tuFxL2ioab9kmmneyWxFmjZAfSQ4pSVGotYL j3CJ0bKiJzo279rLghK0O2GkHlc1huJxUzLOGpC2Ko8OfUVTfMBa0crLxctonMjgHqPZG7MEXmWc A1o7hcZWYj+qrTK37ALBCmbLCY6PzJCNdr2XEC8hJOyyKmrfPABcrHhjeWXvwgGsLtNkRNxzZDrD h+FA4HlCMAuDDZxTI6hkThdhkB7BU4MfseEbS2Jl22uOEIPdVRAeXoLCmMAaw/Kx9XmeqT/CrzCT a9moAiLnZQfdsf2QuNiDYkIgSTe2yFsp/O2yBzCTqPCMk3QkEclByUfUOLBEG+m3ZUyxVudbYIGC bAgcJZO9kwWe435S3fd7oQhNhugLgd01jHE2PCRUgROAuCEFhagoHbpRdcbIbaiBugGiYmS1kc20 duyxasvYwNjHqPdMpWvc1ofu/wBkAJI08JOizzYLMngu7m3wkPjdGRsUFEjvfhOYzXtexSZC5jQb WHuibVxBoLXC6AymQNubkCyGRoadilCYOIINz3UL9TkLYZJNr8Kar/CG/wAqH2vuhBjXWCszAgDm ySXFuytkZG5PKnJoY+x42QFp07Czk5oBFzsruAqSzEAN/VuSnSPMTmN7InNDnA23CNzWy2Lm3I2C ALTqItt+FODYFPi0aB3PsqkLXm9rIUXa5G9lNVjZW8gcIbgoCwQ03KWWNLjbYlMJD227jusSolML mm17eyAyBE3SO5TXM1R77ALG84ObfhP1iSIIZMPWNRBtYInWI2KOWjBcDGfzdJJAB3sgAeBZD5m2 yVI7Re5v8BRlHNNEZmj+WOyckDknDGWG5SC4uHNz8JLpXSnSGOPuQFkUkMMF9TySR3QpkUeqxLuO y5Jul7eLLjoHCI7uFj2WY6oa1l+EAmsj0nbce6w43blOnqC69vtWGZ26rdkBkH1XshLRbYpQnFtt 1XnX+EAy9tiqLwNr7pYdra46wLdliyTNA53QhmCQH9kTX78rjTVXttZHHOXHblBZybXJjTcey48T kbd0+WZzGNMY1FDSZlD2PATHb23H7LCdVhrAXEB3cKNle9oeBZl0JZlttrud7Kw4OJKxxIbpzXgD lBY2LYE3sUoyEkm+6moX2KB9twhbFFnnEl/A4VaPVt2SnVF32B2CXNWesBv7oWzOEepu5VvaAzTs sV07bA6rfCEz99WyAcbbXQiwSvPaf6t0szgHc2Qyx1xzdLfID3SH1Gke4+FQla9nKpLHgAC/ujDg Gj3WCx9z6nENRmYMNgdQUBmF4shLrcLF/Uj2/cKjPpbdp3PugsY6q0EtLSELagOvfZFSunqqhjWR +c87BoG6bXU8lBJoqaYxPO+4srRLVgNdqCIGxO6xCXON2AgJrQXi7jullLe+ztj+VDJuAlCFzi6z hYfKqGF8x24TsWZQkAGytsgWI68brFUZLJ/yLM0yAd1X6jkBYIkcUZjfp1OcLISzMEwKNtRYrjdw 6+9kRlI44ULZyjJQ4XUa5upccyoIHCZFVAP9XCtMto5WNwO9wrLmkHSd1imogu1rbknukysladTD 6UotmY0iIHVvdLbICCOyxhI4bvOyyYRJUU75GsAa1QJltY48cK3s0bnlLpamSYkabAKqiYGSxNwD 2QgFa5tM5oc2+oXWFJUXd6BYLLxSpbVObbljbLt/o34QOoPW7BmYrl7Dg+he8sZI821FS0uzNnSL nl2+4Vl7ueR7r31lL6WOeTADi2HBzzsS13C5zGvp10eWKU/xJk8Rttp4BXrx6eWT+J4s2qhh7NdB kcrEpC9AdWvDK7JYlqMOqTVRtJuwizguhZ6CaB72ujcNJsbhZyYJ4nUkbw6jHmVxYvztRCNs3q3I SdDhwFQbc8Erz1R6rsc6W3yhdPbhCYXAXLTZCG3PBPwrySyzJqQkm6dFTySutGxziewCyIMFrKmp igED2vkcGt1CyEcl+mCGkni6b+knsD5L9Pvp2WwzoZ9MigztkejzHjGP2fKwSCGJ4DR8Eq+ofhty j0tmdROmZUlreTvZdsOJ53UThlzRxK2a7iwsdZ4I/IVcHYrsrqPg7MRxiZuFxQmCNxAMZ3K69lw+ aCQskbocOxUyYpYnTLjzRyR3JiN2ncqFxHdZQwypkF2xlwTYcDrJZWsFO8l2w9KyscpdI35I/px4 P90xkjg2/IC+sg6U5iqWh8dE5zSLhcfjeTMbwKMuraCSFnc6dkeOS9BZIt0mcPHK5w2uU0yyMGpz fT7rGjmdE0hoCtplqHCNt3l3DB3K51Z1se+YW5CrzCW3ablfU5d6TZkzJIBT4XOGdy5pC5PGuhma cBJdJQvDLXDhv/2XVYptdHF58adNnwMc7zsDv8qpXvLQ47D4X0VN01zJWPH6fCqua5tdkRK+2wjw /ZonpGmtwuamiP8AXMw7LXim1dDz46uzqWNzpAbHcKo/Mc4hoLiOV2ZVdCccZVGOhikr3A7+Qwm3 5XKYT4c8yYjL5UsctHJb+qI2Wo4Jy9HJ6rEu2dPOke0+x9lDM78FdyZj8NGOZccwy1Uc5cLhoaQ7 +yxcK8M2eselaygwKrqA7cOEJtb+y1LT5IvlGlqMbVpnUhlc7koLkrv0+ETOdKLV2D1FPYbuLCgi 8K2YJS7ysNxCZ4/pbCSLrotJmaujl8zF1Z0M1lzc8d1H6STp4+V6LwvwX5+qiX1GXK+CnH9T4iCQ ucyr4J8zY/m2hw2lwmpcfNBlEjfS1ve91wngnj7RPmYv08/Zc6bZmzZGHYTglZWxH/3Y4iWj8lfW UvQXMAjP6uCWl08gt4W8rpn4fsNyD07psLocPpoXMpbSjyxd77e66Hz30nrpKWpnr6BkEfmHSdIF wvfotHHU+zxZ9e8atI1IZp6eYplmIulk8yPtsviiXNNl7s635CjbQzO8oBkbTc2XinEKOCGunZcn S8hcdVpXgntPRpNYs8bZ2HhUYjgLwbl2/wCFnQuduTv8rCo4y1rA67WmwXI6BGObhfl4/wAT9VP+ TMKtfyLWXHXtcrkq4amkhcYb2Gy9EEcJltu4qpWloPpDrpkQSax/lROINl3RyMC4iksQbn2WfSvY 0bCxXGR1DXvBc0uIXKtkEzAQLW5QqMkC4/Khs3bm6WyU6bK73FjysFIY9ud1Gste6t4LCAhL7G3K AVcCTfZU4c7proQ4hw5QPYQeFAXAzhZZYR/+JY8WxAvZZTXBruLrRGAdQlaxNcLC3dUHNaXOIuVA /wA0XG3wtJkKH3BFyh+VHO22WgVrDX777K2yhxN9rcILX35VWDjpOxRgY2TUwoQ4Abo5YRHFdiUW nSL/AJWQMYW3uP7opNyFcMF47ggoZAHXA+4ICrXN+bKSN2FxypDq1EEI9V+QgMZzPWLmwTw3i3CN zGv7KABrTbsgElpL/ZQ7bIZZS7doR7kXPKAADdS+xHCO1hfsluaXHbhaIwC8cDchAW7Iy0td2VOH q2C0jJB6QCd1ZcOys7gKr77jZaAGrfbZC7ZoJ5umGxNlT27hWiWUWmSx7I3/AMuNUQTa23wheTJY cEJRLKbNuAeUbnAuQeWQL91HAkWA/dKLZbnXAAGxQs2JVtu1p2Vx23B/ZUWS9zZEyw2Qag0qw4O4 QWDJJpdYBOePLaHHkpA3ff2TdWsWN7ILEPBc4kDZE2wHyrD9LtJ+1W6wOyGR0DneU43tbsh1BzC4 hJc7awNvwre7TEGjf5QBMlJuOyguEuIEgohsojZeu9xZQmzbq722tuULiLWsqSwWuuFbgS1Exmnf sVZsQhQbNDBbc+yo3sQSoG2R2uEAMTNFyEQbe/8A5UFgFGybm/shEU1twR3U4NjurgJDXF/7IC67 kFFv0kbf4RMKhcbbhAHi9ggss+m/yhZNyAqlJPCVGd+LK0LMl7tANt7pY+y/BRHcklQNsL8/CgRI 9bfuRm7d0Ni4gpcryHafZCjWz+Vc2BKI1TTGAWd90Dg02KtrG6bgfuqgZGqCYXYNNuyBzrgrHAId sVkNcCLEK0EDclouraW777hQ90NhblKBTXevjZVI/S/0nYo42km3ZLLA19uQqA7bblI9bCfYp77c oC/Ud0BI2gC/dQus4WKgfYWVfc9YBev1cothv3VaQXcKEXJQDA7WLEqB19jawSw3YKEbICHn2CE3 4BKMkFRrLn4QFB5tblERYXKqRmgbG6J13MAtZAUw3RAg37KmjS35QncFAGBtdUG8oSdDbK9Vm35Q hA39kt+xRl4Iv2QatkFFtuWqEe6outwqL7jdaIgiQLKOdeyBt9VzYhW5wBuFLLYdjyVNDXEHuhLy 3dU5wtcDdLARIDgNwiF7JDZQ0HULlH5mw+VSBNBJvdQt5N7qNdYfCp0g0qUQjHd7Ixcj4SbkgW5W Qzdo91Ci3wAtvfdA5ukBOkFwLbfCA7DdDRNIBB91ZNiAlgnsNkXblAE/iyBrbBEeFVi7goCA7hPI DWmxSA0B23ZNDw4/CAG5J2RO3bzYqBgvcFC43f7IALkHhMbpI35U1Bh5uqNjYhAR508KyXEAqXHF t1LDg7IBTy4n1cK/+WBfdXp1XF7WVWHB3QC57sLSTcFTS3TsSCjlHmAC3Cp1QYI/SwOPyhLLYQ8H 49wqJbeyvzhO0bBp7hLeBGeboSwongStDuL8rmW01PJHfYrhhHccXKKmmfG4i5IQDZoWRS+k7IJN LRud1UkgkluSLBBJplIF0ISRzWgEHdKDrOIHBRtgANuyoNtKW34QB8BUXEAlU7Y8qA3BurYLDiQT pVW3uqBKsu2SwF243V6rttp3S+yNpLRflaALYdDyboydtlRfyShcLuBugDDS4qEEFWQbbGytjOdR Qoogm9zYK4naODsqkuCWgXHuiDPTuoAw/WebqPbfa2ypkYYbqSAh2xQ0C+V8b2sZu08prWkC6Tp9 d1kNcbLILYNTghcXB1uyPWGm9lWsObtygI61hdV/YKmtIG5ur7ICrE8IRqabFGDZWTqHsQgBvYWU JsRZSVwBCFh33QBzFxZsVhCV8ZNySFnXbcF3CxpmudMNI9HdAVFKXt4ROLuRwppLHem1vZC4u3QB Xur73S9W2yoPP7IZGXaCiaLnZK57ImvINhsgsZI0hu6EEgWshNS5l2lt0Ikc5mrYH2QtjHxlrSBv dW1tmAHkKmXdHc8qEkAboUuxCHc7IibBUTayAJrbEbKpgCRZW1927qOsQPdAIFyOE5sYDdzuVGuD W8JjI9YudkBjSnS6yN8YMe+xUka17xbtyVbm37oBbHaW2uqFQW7OFwjEek3PKCRms7hAHrLuCbFP YARvysZkuj02Rhjr3DtvZANnjYIy950tWLIxrYrt3B7pzKlr5xG8amjsUNY9pJbGAAOwQHHsiG/u mhoA22siY243QOIDuVRYDnNcbXsUtzdPyVCBrLgmNcw24UAtrrHhM+4qOs0kpTSb7rRLGOBsha3V 92yrWd7JRJVJYwgbi6osA2QBwYCTclWH3CECEYvz2UbGRf8A8IdW3uia6wtdAFe1lHuuFR3HOyq4 cLIUZG4OFu6IncCyGMtFgPuRSSaeeUKCSWuvyUtspJNwo1xJNiiLfT8qEC1XIAVO2O/CpgsjAs3f dUgLXerYcoyCAdtihc4tKJrHObsgEunLDp0891bWhx+Uboy0XIuqDQHC6FK0PG4KaXEgDVuqLdRF iqez03GxCCiOm07H+6RKSW6gntYHMLjylsAOptr+ylGhTfVa5TGnSdlGNvcWsQoGkHfhUFfc7dC9 wDw0gongXUcRwQhmwiGhmxSt2jZQt1DY2UtYW5UIUHKarH2UcGtKW9wuFEB4NhyoXboQRZC73HK0 BpdcKBxHKV5g23V+ZZSwO1JFVUGFo0t1XQve53BVNkIFuVQRj5O6B8n8+zuOxR6/hDIGkXcL2UZB 0NQ0Nt88pzwHi7DsFxhcW3cBsVKaWVst9yzuqQ5Jh2uBZC6ItGrgJLqh7ZLgen2TH1zJGEA2Q1YQ cSdtwjIuNljUlWNwNysgzDfWLEoZK/Tl3cD8oY6ctDg6x9rKF3nnTc2Tqdgg2O7T7oKEMpQ42fuO yoxeVe3CznRFzbtKTIwBtigMVr2xG4F7onC41cfCrzGMJCBzz24QFBxDgb7LG1FtTd3CyD8LFk9L y4/2QDXvL3XDv2UaQCkar7po9Y2QB6rBLlGpQAj7lSwYKAJN7phPotygJ2U2A+ULwLIAN05h+dkl xu6xFkbb8BWyDeyvbdL1W5UDvc7KgYDYKnb2QF217qakZovUSRdS+53QtO6sBDIxhTBygbYN25Rt uQFTQQ3IUlI991NyBZUyEySWdt8oUZFJYWBVAua7kkJbmaXEX4Vsvvc88IBpgN/Ma79lKlr6toEh O3sULGujcC42aUeq5NuEAplOIgHE3/KtztXBsmadvhLewgbIAX37cJRaH3JNymkEAXSnyfAQyxRY OEt4LRsLp3LboYzcXJQgkxkNDu/so0gi99019wfuuEsEC/yhaI1xRMHKAFGw7EIQY0BzbEIHtDSo H24Kpxvb3QCiSEQOyp491VrNsFLAzt7IHE324QPa8t2ulEPCAyGuIOxT21LmWsLrGjB0b8poJaFQ Nkq3aS337LAhL2zuc43HZPcL7oCz1XQtjnVL2nYXCF5AtvyqcbkKnWvuFLLYbXAdkRLXcoY2Anmy pxAdblCdlni3uiFonNDTzzZKLgDdDfcHgIQyZHWfdQes87JUrw8CyNuwA9wqaQ+BgYD3KMOuCT6U mN5YSAboHCSV1v8AuhRsEjZZC29yFmfprvs32WFFGIXi1i7uuTp5O9v3WeQYksDomEuCw2732XLV U12kWvfZcXIzyjubBX/kFOS3cXVyOFueUl0gA5WWQMHdXqLTsktlG5V+bfhaFmTNPG6NojBMh5Sb lrSCii0g3VSStLjdUpARbdWHBJdKOLFVqsAeyAyfS+10qoFrWNrJJq2xdiT8KnyuIuRYHhRkY2nf Zx9kxx2JWHHLY2HKyQC77VkWU7zCPRwnRTvLCwhY8kjozpI3TI3Dk7KlHtdtxZNZZrTY7pAkZfco tRJ2NgoA/wBRb0u2KyonjTxYnuuNnLRI125sVlS1LQ0AXDjwgMsn3VsGhY19AaS7kIvOBHIQqMgP t3urElyVjCUDYofPaHDfZaKZesBCXi+yxhUaybFQvaD9wUoWZXnC3sUDpFiMeXvI7IXTBp5Vr9J0 ZReCUJfpN1i/qLnbcpbqm9xbcKMhmOmBPygklHK4mWscZdPYIzJLK4AbKAzzMAOVBJcrjJKkglv9 QVwVBJ0uOk/KEZyrZb3CLc8crEiefdZTD7oUYw2IJ3Cou1PKjWWHO6W55BIHKCi5ZhEwn2WG3EQ8 uDfUSLWR1csUTC2Q3fzYLEhqhCwmKH+YeDZCGTFM5rbFhaPlEZRIbWWMaurnHqYLfiygbNw2Mgf7 vZWmLMphF7FZUbmgLjGP8sXcbkJ1PVx93cqCzKfSMmcSTyhEfktsDslPqmtPJA+FGzhzbi7ghTJb cCxNmohNoFr7eywv1Dh3FvZX+oDh8+yAzGvAvYbFCZbXtwsB9aIwbi1ljGue5+5Nj2QHLtmD3WG1 vdNY+x91w8EzpX6b2Pa+yfFXBri0k6hsnITRzILXCxKMBtgFx0dVqOzbrLheDsXIWzIDiBbsmB21 tljB7ZDpbINQ7IZHyMdYjb3QhkennuqLQ47BCzW5twCUyAGxNrflDQpgsTsqkNjfsFkyw3ZdjgCf dcXVyzRTGEaZD8FCDTIHG42KprrHYrCFQ4OOptiOfhU2tbISGkbIQ5Ev1A2NljytF7HdY4mFrgoX 1m/2k+yEDe8MG+wU84WFiLLAdWv12ljOlU+oicdgWoU5AyF7hZybHK1rgb7rEIuxr2nZR8sbWXP+ EKcnqa4XO7kLagE+oLjm1zGi4JIRCrjeLjYoUe+E1hcyM39wsBmEjztDpQN+PZF+omZJrY4NA5XN ZGyDj3U/MseE5epJKytnP9INh+Sq1XZl0jiKjB6inaXwyeY0b7FDCKhoBlBaCu9M9+EXPvSLLf8A HMepzHTt+5o4BXSVdPM6QOef5IIBaAt+N1ZzU4t1ZXmEu0tO5THGSIXcw2HdVJCIy10PqDu6y2Tv bL5MtizTchY5OhhvqS4cWPyliuI2OyuQubORsY/6R3RMpP1JOqIt9ioLCNUTYXtdNbcAXda649+H zRyWkdbsLFMloJ4owTKSrGLl0QzRIQedk1s5G17LjzHI2MDVc+4KC1Q0C0T5PkC6NUNyOXbPc+k7 oi9zT6hsuMjM7W6gzSR/S5G6tdO0+otk402VphTTMqarAILf7KMn8zvZY7aKd4DgNTj2vZZJw+qM Y86Lym9nDdFFkc0jGqPOdcMeGtVTYVK2FkrJy4k7tWT/AA8vaPJDnyN4N7BNhyljU/8ANf8AyY77 EbraxyfSOfkh1ZgvgmAGprgAPZZtN6ohvZY9cMSwyYRyvE0XBIGybVFwjZ5ADr82WHFx7OiaZlim 1MJ1Lj5o42tfqeRZZVPNI1lnsIQVMDal+kCzSN1k0cfK6JtMXltnDgnuhwmGtxKp0RCXQ7gBhIXI 0ENBNmGgZiTi3Dg8CQN7gFbvfCf0L6QZu6T4TiuG5bo6vVGGvdKwElwHdY3U0mZkaXsN6YZhl1SU royTvoeCCuNxfI2NYTIZq6lLQzckDZb88Z6N9HRj/wDCJMAoaSvLdQjiZo/7Lzf40PDPlPKvT5+L YfH5LXnQ1lu59l9XDp45KT7fR8XLrJQk69GoaSaB2z2Frhx7JEkwdH/KOt3svvano1juJ1Ev6PDq upZe7RHC47JLujeYMMid5+F1tPIDsJYi2/8Adc8mmlCVM9uPVwnFOz4djzGNDxpc7ueyx5o2NfYO 1yDgDhfXYd03zFj1W6kosKq62dps5kETnEf2X11H4Yc/FzXjLGJQ3F9csJt/kLi8Mjp8nG/Z1CKh 0LbPjId7oP58kJkFtIX3uYekmN4ViMeHT0s7sQkPopmxEvK+wyn4Q+o2Z4waXK+JjXwXwlrbfup4 ZXtM/Jx1dnRfm3duN/hFTwS1NQyOGMyyyO0sY0XJJ7WXoPGfBH1Ky7QT1WJYBUU0MYLrlhuuF8N+ SXs63ZefidDJPh9HVsdUjQTaxSeHJBW0WOpxTdJnI5a8EnVDMNBFXzYBPRUsgDgZG72Pey6s6i9P q/pzj0uF4gxzKiLkEL9BWec4U2HdHsVxnDqMOZDTWgidHvYNWnbO3TTO3iQ6jSR4Jg09fVVJLxLG y0cYvaziu2LA543JnHLqowyJfp5YayWZwc1pt7hOY6cP0hwcQu/s/eCnqF0zw51XjNEaYB2ggb7/ ALLnunngH6i5uyq7MAwiohiJ/lRPaQ6Qe9lh4JLtHVarG+meXZmySSkuG49k5lVO6PyxwF7Awj6Z 3V3GKprm4IyKBzhqkneGhoXacH0mc10dB+pqa6ndIG3dDE7f8KxwOTpHCWthE12fqpYjpc3dNNQ7 0m9iexXqbqr4OcSybhdXKY3CanBJBC8r1eHy0znB+z2u06Vc2lyYF90dsOrhm/izKbU2aQRd9th7 rGkqjK9rLeWe91HRPNXAwEMc+zQfZe6OiH0yqrqTlDDsyVmaKWlZV2Mcb9tQ+PleaMdzpHpnkUFb PDBwusawyNjLoyeVjTsdTvGrv7hbTMx/TSr8m4NLNSPixIsZew/qXSeQvp4Zv6v5vqqfyI8AoaaS 0kkzbXF+QvR8bJs3pWj5q18d+1o8Psgnd/MbGXNUNNOD62OA/C3C4P8ASTyxQ0UUVdj8lTO0eoht mkr47qj9NmLAqDThFGa2Nw064dy35KuPT+TpnWWsS9GqYtINtyfhOFBVFms08hZ76TZbZ+m/0l8r 1mFRV+YcTqqaqdv5LdgPzdfeVH0xsoYZA44diUtawtP8uUAb/FlPjpScWzMtbStI0s/zI2FpZe6b DQzyC4pXyD/paVtayn9MLLGc8cxJuKVFVhsNPJazW2vuu5Mo/T66OYGHYZBWurKxotZzwSStSwbX TZY6xSjdGkGfD5ogP5LmtPYjdKFDOT6YnOH4W7/MX08+nIqG/rb0sDzYPaABf8rkMH+m30kwVn6u rimqoSL3c+zVh4aa54MLVybraaOBhFW9npjv8DlfW9LekeLdTM7YTl+lgkbJXTNj1ht7Am11u1d4 AujlZSF2H4W1hAvrDtSxuk3RvpJ0p6gNio5qf+NsdaIPI9J+CusdNvi3B9HLLrXGl1Z0zhP06sld Hso/xOuD6/Eo4g6ZztzxvYLyT4mulmCxYaa3BKR0oYTYaNwFurx+bCI4HyYpJC2AMJ/nEaSLfK11 +JPqZ0/w6kxNtBBC573ua0MAIBuvtaLFjzY3CUaa9nxs2XLCampGqyue+mIjMXlOBsQQsWKTQ7W8 age3uvqc/wBfT4vj000TBE0knSBZcLgeFvzFjdFhsfpdUStiBHybL85mgsc2j9XhyOeNSZiU9LNi M/l00D5XuOzI2klfZ4R0hzRXQCRuGVbWkXF4StzfhI8DuQemmR8OxOvwmHFMZqYmyvkqmarEjsCv RkPTnLji+BuW6BlOdr+U0f8AhXFGMuZHmzahxdRPzn4p0nzPRS2dhFU75bG4pdL0ux2rk8sYdVtk PYwn/wCFvjzzlzKXT/NmF+dhFGyGvlEQa9gLQb8rseqyTkTAYm19XguHRRkA+Y6FtgvoZsGOKjKP Nnlx62Um0+KPz6xeHfOBpDUHDKjywL2ETrlcXJ0lxmKYRS0FbG4m1jA4/wDhfobxjDsmS5eqMTgp 6BtPFGXNk0NDb2XynSOTJnUukqpIcEw2WSnkLHvZE03t+y4rBB43PngPVzU9io0dYD4Ws95ijM1H gVbNTAXMphcGhFjvhozhhZbG/DZC8jZgFz/Zb+4cbylSyT4S2WhojEdLoCGsXzWH9L8g4jmiTEYB S4hXEXdFrDwP2SOGKVyizhPVZW/ozR1l3wZ9SscAlZl2sETuCYzuvpx4K84YZE79Rg04lH9LxY/5 W37q/wBeqHo/UwU8WGNkGoNLGttt8WXP4xXUWeemQzFFSCGURGdjbbi3uvVDTRSjuXD/AP8ATmtb kdp+jSj/APcZdQfOEoyvXTQk3Hlxm3919xlrwBZ/xtrZpcGno4bcShbiOkOZYc05QiqTFGPKu11m i2yrDOq+B5gxeqw6nfFG+ldolMxDRf4utLEoTlHZdGcmryOCkpUae8z+CivwaGWKZgbUxj7bWXQO bchYvlCaSOWOzIj6tQsLLbv4p+oGTMGbNbE6ZmKgf8pjhd35WtPrTmOr6j4i2kwbDamoZI/T5tNG XB1zxsF7tTo8XhWSKp/h59Lr8sslSOi5MXp4mOAiu5w3IWDHA2rbqY4D3F137l7wgZnqcMFXVUE8 OoXAkZay6v6n9KMR6cVwE+0D+3cL81LDkir28H6iGpxZHtT5PhKiMQylvN+62KfTd614vU4zl/Jl KBHSwynVpNi7utd7SDRuBZc32cvb30rcObX9bWykAMp49VyO6+fqI7orn2enfsi2bVOrmdMYwPGc NgwmpLZtTSaYM1eaDyuV6hvmq+nstVLFCzEXRao45bfd7brJzXnXCct5gw5mJUTLTu0xVjgCWnhf L9XMp4xmzGMEqKKoe7CGyNfIyM7L9Lge3x8VXv8AT8tl/wBm63Z5DxXwmZ56x1lTNVCPC6Wa58yw A/ZfK1X0pcQw2lqKmTGm4g+xd5cYt87XWyjHMRw7LmBsfW1TKGmZHYvcbDYLprFvF/0+ye51JJUT 1pF/5kTNQK9c8+XVfZQ4R5Yxjp5Vuo1/5Z+nG/PmY5MJjq34Z5e0kksfC7awn6RmFYYQZ8fgqJWm 4ZID6l7Q6MdVcN6rT19bheHfpaaI7Slou/8AdeZvEp1PzbhHUitkwqolgFGbwwMeQHLGPT/Jy+OK o6PUyxY90n2ddZ68BNHlKGKGTC6aeOR3lskY3krkcqfSww3FmMr8UqoaCJ41eW0cD5Scm+KnqV1G z1geAYtgsgghmaTIItnge5svdOfc/ZfyhkiWvzM99HSeWNcUezzt2U1GCWDbFK2MWfe7s8wU/wBM /I2G0Oule2se0ffYEE/svOHV7wo4fguacNw+Hy8Pa6bS6Q7WF16yxjx35OyrgEceUsEr8XgaPTZh /wArxr18644z1VxR2LzQOw+J7wGtF2aN168OnlOLWeCo45cztbJcnufJPQnFaLpjDlLCcaLKBjGy NqmG7ibXtdec3dGDnTq5NlzGcUJEPpeNXqcBsvTHhOrMYm6Ktqq0zNf5JdE6X+oW5XT3TWE13igZ UVDiHFx9Tu+646PTLDKcoej0Zss5wUZ+z5rrn4EenvTnAHYlQT1EEszLESO1eo9wuZ6I+ALppj/T 6ixDFaI4rVykuNQTx+bLubxfVVZXR0FDSUctRe99Lbgr6Pww4BieWukUsOKh0LpJHOijfsWg9l1n tnpo5JfybOCUozcYvg6gyt9OXIFXmGpqK2Npw+JwMMMW3912rhvhC6QsP6eiy3TyyxGxkLL/AOV3 BlOMYbhdVPK11gC71d9uy8yZq8WGZ58bxLBMp5SeMQppS0uEZOv2PC8cVly5HHHxX/wd3WPGnNhd Z/DbljKmGCroqJlLGObDYLxn1ayNg1VhNXFLVRxGztLdiu7eqefOt2eMrVH8UpGYfTs3dE0WOy8i 9TMuY/imXpMUqap8ToWEFlyF+jx6aK0/+9JyPlvLJZUsbdM8p49Rx0OLVUETg9jJC0Ed917+8A3T zLeaY6V1ZkYYoWRl76+eG4aR2BK8M5LwhmPZ6wyimIc2araH6uCNW63zdP8AA8IyL02oIsCpKegf +ja3VC0AaiBuV+JU4wzLjs/WaiUlipdjMm9J8jZ5wmukiyscEfTvMLnlmkvt3HwvgMK8NWTsX6j/ AKWWeWuo4j66STgrubo9i2KzUNfSYtOKl4JcyZosC32XA5Qw6to+q1dW1sYpacgiN5Fg5fbUf/Iv 64PzzyOo7jHzTiHTDodPDhr8BpoCWg+mIEge918dmfqr0Mzrgr8PkxKmoKmTYANDXBV4rcu1+Z8U o2YRhkuIVEjdPmRC4b+V0DhPggzNi85rM0R0+H4eT6XDaT/8S9GHTY/FGcp03/ZyedqbjFcHrTp3 knIfTjI8mJYTS0uJ0j2+b+ofGCXHm17L5HDfE500xXEZ8PzDhVDhml2hkjo22I/Nl99g2R4Mn9Cp MDw6OTEWQQkNEfqc78LyZhfhOxrqvXVMmJUzsEpi8ua+qjsQPws4MOHKpSyOqZc2ScKpWd35Uw3p bn/qkP4ZSwYgWN1RyOaHRu+PZd2OoMXwjF46XCMAwuPCALOm1NDmj/7IXRvh08M+HdDcfqnxY6cV l5jiDh6P2WR146d5/wAwY02uyZj9bQmZwbLTlxEYHc7LE4eTJtT4S9kjajua5Z3Pn6fKWE4PPU4t JQxSxML2tcRdzgOLLh+juc8Jz7gUlfDhtHBHTuLQYmtvt3XmfOXg9zC7CocYxvPr5Jw3VK2WW0bT bjddo+Efp/Pl3JOOxOr210k8jhHIw+njZSWKEcLe6wpSc0qo7Iyb1Wpc5ZzxHBW0jDDT3AeWc22X xPXXrDV9GcTgfhuE0svnEDUAA43K+n6SdLcRybmTE6/EI2NbKbseHX2XUHimx7LtdmiibX1wibHI AbO22TDCEs1R5jRqbcY7megoepNWzplHmCoo9FTLDrEY4BIXjXqP4kMxZokkp54WNp4XEBrOT+y9 XYS2DOPTqgocLqY5aQxACVrwe3C6zzh0QyjgVPNX1A/4sMN9QsHFerRQxYsjb7sxllOcUjWd12z1 mSpmqJJI3xUUlwGWXl+p1zVEj/Jf6jfhbDerNZlyipqsYnDE6AkhgNr/ALLxdjmZ6WLF6ptNBGKc POj0jhcf8ok5p2e7/Gz2JquTPp5P1lPZhAkb2WXC4lgY/Z3usTBZIjUue0f06Ss+NgfKQe5X83hK 0f0TJH7CKho0kGy4uRoHC5msiawOGrYLiXyx3OlenHbPNNAx27rDxB3mR2WU14dwkPZrksRsvScj hNT4iQBt7rkaEucLk7HuhnprPItdpR07vKcGDhCo5SBose6jLPkcPZMpovLGp27So3UJC5oACwUC Vxc8C1lVrHi6J1w69roSe6AgsLdlbhqKtoDrXVaiNjslAXp0uCcx3qtyClkEq4QSCqiMyPKA3urc LNuETeLOKSXnXptstpECdIHs9rIms9F789kOoRvsUTni/p4CoI1lvhM8ttrkXKESNtzdGxzXWVBT dnC49KaZInEse302sgIHvslSP1SBoHpWWCjAKSP+WSdR79lAfLcDa5KcT6R3VMZ5pvwUQI+QBtyN 1jvlvbsnTR77rHkbp7JQDE1hbkoQ5xJF9u6Frw13CuN4aHau6UBjW2sqedil+YHOABQOvHIb7gog G29jfhSxaqabj4QvnbqtvdbRGHbVshLdrd1YdfdVI8EXvsqZKNm291RBtcJjy3y2n3S2us3dADvq BVjdxVg3ChKApz9J4up5biNR27oom63WJ/dJqJyyUR9yqSgy5w3O6hO/wiZHZtnG5Puo6F1trWQy Df06fdKddlh3TC+zgAlSnRudzdaAc1gwdz7qQX0m/wCyj92hUPSLICgCHb8Iw4hpQavlTXZnCAou dqF9wU1t+OyW+WzBdA+TVuDsgGPBJsAi0lwA9ktjy7gpnmnVawQqLA0jbkqgwOuTyoXgOsVYNroV lngK7XCE+oDe1lBvtdCFSSEEbbKxwpqBNjyoRYoaJYC6vsh3KIXIQFFpttwh2G5CMXt/4REAhAAT qN+yl79t1e3Chb8IAHGwb/lVKWsGpu59go/YIY7Nv3QzRDvZxRNjLxcIb69jwo0mN5AK0iB3AFid 0VwBubLEcwyvsSQnuGmIN9u6WVBteO26x5CTPvsq8xzXABMfpJDrXcoxY3Tr24CsPsNKTqIcOyaR Y/JULYErjHYt5TGOFtRKW49yLqpHl0Dmhu5Vso9zgW7Kjwseld5cdnncLIY4A35BUIM/9txCSxzn XLtym6w3a+3slDYm3dascht9RsgcQ06Tb8qwSz5VE3NyoUhbpPuFNPspclQ3UIy2i/OyIBUNj+ET XbIUqyhNxwi5CG1lbBGt9N1C4NN0TWF3B/IUcwA7qAFsgO7lNZc63shkHrAGzSmNi1Eq8Ap7rcbh LAumubYWulPcWC6hLLfs33TIWahuLBJbIXhOmmMVNZv3IZEvOlxb2VM5vyEpkjyRqbe/+FkNAB22 HutAB5B44VBjSbg3RAhxN9gg1tjebG6yUpwsduVHmwv2Cs3cbpZbrO6vBC23mBN0PqPdMs2O+k7e yGxLTslAN9iALXS3Me2x/pTGHywNfJ4uVWsvu0iwQCxISPdGQQLn7VbW22tsjLLC3+FAC3S4C6YN jygEe9hsh12NrobMjS14+7dIljJ77qxI3Y9wrdJflAXHszflU03duqBBHKjGFp5QBSG3CqJ4Fx3R XvzwqLAHByAtuwIPdMjAaN1Rc13OxVNLb3vdAHIRp9PKFrC6ziq5N1Gj1eo2CAJ7A42/yq0CJw73 THU8YAcJgT/tU8oR2eTf4QjFkHVwboH7/lMkfqdcISwvQIXq77lFoIbfjunCMMA2UcQ3Z5s090KI Z6gbFRo1XB3QztYz/lOJupTt8tpcTclCUCS1jrWVtDQRcXuqPqedtkdrjY7hCDQ0jskububbIo3u vZyou9XKEMfQ6/wr8sNsQd05zQklhadjcKgEzSNlaAPT7phYGyFw5Km3Y7qtRBuUoBON9lRFhsoS LlUSNNkoEIPZDfcCyNj9I2G6XqJJvyoAw4cI2u0jZLG6v4VsB2vyo67iLKA2KsbnhUEcwu4KMCw3 VAlXe5VNItxDmAW390HZGBff2Vs3vshRQvw5FYF25sic0KOYNtrrLABuHbd1Ha2yANFx3RhwaLW3 UYXMN+fyoCze9ioBY3AVl26rsgC1X7IWkkqXA7qN4QFouQO6FVuUAuTc3I4VsIO/dDLJoeL7goNZ LrMGx5QljvMElwdiq8yw0gf3SyLEEK9SFLb6Tv3QSSWNrIiQSkvd6rWQjIDZFc2Stasu2CGQxIr8 wbFK2AUuEAx8pDTblYzamwc4gg34TNVkL2h1id0A+GUyRX4TBu0ArHHAtsmB3yoUd2CsFKD7o9So CAublFyha64siF1TRT2lw22IVxkjkqEG2ytjS0X5SgRzCRYNsqsCU0PuDcILg32UAIIsqLttx+6J 1rJDtRbvwhCpTIS3QAR3Kkpc4CxtblWwEN2OyOOD0kuNwVRZiy7WLfu90oSOYXOPJWVK0h1uwSXs 79lCMpswc3fYpcpDrEBMa0Ft0qTVfbhCANAJsp+nt3t7JgYANSQZXiS3IK2A3O02vv8AhXa4SQbX aSmW0tuN1AWbX4QP52RB2ra3ColALc24RWs2xQ+ZbhQOuUAQaLKBoB2VjsrJVKXsNlGtAuhHyoDs UKwrWddSb1kK7gtskuJYDpCGQi8Qsc8njsmNOtgd7rGZJ5jC14uFksIsAOyAjXbEHlWLm26p0ZJu ra25AOyAvk7p7W7KiATpA/dDcxqFL9VjcIWNHJ7IvNLhwrtt+VktFNaLX5VxxNkDgSqY117dkt7/ AC3gWJVRQX0+l1g7ZQjQ5PYQ9qEx+u53CpGB935UAtdFf4sq5VMgPHCW4agSeyyDECLoPLc9u2wW bAhqsEW90b49A25SpDoA7JYI6xNrICxpO6jpLbnuleaAbHZQjY0AAqiduUAeDcBwKAS6jbkhWyWN aGEEOP4Qk227IPNuEBmG4PZQWMDt1NQJv3STJtsh823dUWZOr5VX1NWOZhfdD+p5twqSzI0gDdEH BvGywzKTuDsrbM4b8oDMDrC3N0kwW1W7pIqbHccpzahvtyqUx44ZoHEh3pPZZrJi9ouOEsuDgUvS A3ZxCgMyEua4vDv2WQa0zMDSBsuNJe1oLbm3dFDI6R+kgt/ZU1ZyjJjpFj+yF79R3WH5jo3W7K/1 Fz7ILGzQCSx4S/K0A+ynm3byq87YjdCcFNs0EpUoBb7flKlnINglFz3O9R2QyW707BGJC1YMs7g/ 07q3PeWhylizNdJqU1BYrHk8lHs7dkoJ9lkyM990xrdYJ4WE6d0Ni43uU2ndJO71DQPnug7MiwIs TuqJAKxZ5WxSBt/3RicadIO6AY5/O6AybJbmOLdQ4QBkh4aT7FAZDZNt1DKBYdvdLjheR6jZU4xN k0+YCVrktjBPYm26vzt+UuS1M6xFxbYpLY5Z3nQwkJTIZxnJsQN/ZPZN6bnn2XEyPkpiA/k9k0SP aC5x2CcmjlWVDSeLJwffuuEjrg7YC5HsFktrDYm3CWLOQe7cK3EWBtusNsxkZrc1waO9lBVRHYPV 7KZbpfMFijvpaB2WLG8OOxBTpXlwuzcoAzKG8m35SnzWt7LGrJGxMDpGOb8jug/UsbSksaXnsClA yJZw4FYzpBukPrPLaNxcoZJXySM2GnuQUowx7ZL/AAE+ItdsFjmk1m7JO3BCTC4NefMeWub2HdKB kVDgCQASVjGUl1rWWSHGr2i9DuxcFhSCWOZ0cli/3Taxf4MMhF97ImSE91iGmkcb6iSOwCMax6mg EDmyVIlmW2S6Jr7u22WJFP5jw0Df2THzNYbOvf4Q0hxeC8Byqnpqiep0sHovysdpZO6/mWd2BXIx 1klK0Bov8oaM6fD3wubZuoWWBNTa5OLH2KczGS9wY6UNd7IKgT6teoaT3KEMd8ZB2SnPMbrEIqmK YeoHc8fKuBhmjIJu4IOAfOuLqvNF1hOkAc4AkEFWJ9I9TTdCGZ5gur8wflYTJvMNmA+5Vip302Qp miSw2/uoHcbpHmNcy7Tcjsh87W03aQR2QGVoLzYC6IRBzLHcrGo6jVLpAJKzXHyQXWs4hZYEBlhz wmavSO6kUBqqc29LjxdFFRSxtImIbbgqihzIwxoeSiMrdJJH7rGEbnO9LgWjssgzwtLWPjLh7hAB FKNXp3+VyFK9wG4WK/yG7Mu0K4nvYwm5LArVCzkJjH5d3Gy4uuY2qYRE6xHdSSf9Q0gmwHZYNdOJ IAYTpDdnfKn9izGlbJE4B0jXfIKktNUFgc2Mlh7hfW9KOkOZur+ZYMFy5RPq6uY+kAbD8r1fQ/S1 6uMoBNWRw0923EbXXKLk5yyJHhyNk3ABB/6tlDK9riDyOwXqcfT/AOpFVnmPK/6J362UXjkedLP7 ldt4J9IjqLO5sddVYfRk/c8v1Afuurx0+Tj54Po8EQ1zY2Wc0gpkeiZrnAEkdgvcfUX6V2esjYey pgrosUikeGaIBc3P/hcjgH0k87zZZqsRxXEYKKdkJligZu4m17FaWNWXzxSPBYiLx6ntaDwDslPp JJN2H0Dkg8L0l0T8EeP9aepeL5WpKgQPwx5bNM/YCy+u8S/gIxnw25XZi9VWNrKKQll2G/q9lrxf bax54tWeOGSfppCAWyLKqHSSwBwYLW7L3r4Tvpm4l1by5BmnMFY3D8Iqm6oqYtIe8e6+F8aPg8pf DK+jmpJnz09YS1mp1wpDFvbSI9RFPlHj2NzWwFzmFrxsCqEEgdcvsTvsV9Jk/I+KZ4x+lwmjhe+S aQNa1rSXOuewW0Dph9JDLeJ5Eoa3HcSqqXGaiMPfC8XDL+65uG2W2R0c0lZqg8kmMSPfe3ukSSyM IIF2rvDxR9Faboz1FxXLVNJ+oho3WbIOD7L4HJHR/Ouf6aolwHAqqup6cXklbH6R+63PDKDMwyxm uGfKR1jJY9JjPme4WTS6rlrjZc7mPIGOZJnZDjOGS4fNILt8xtrrhDHDHIyz7uXOUXHs6xkpdE0h 8hDje3ZY9XWOMgIGo8ADlVUOcypPlm2ra69Z+C/wPY518xuLF62N1JlyneDPUyD7/ht1xcldGpPb GzynSslkYXTahfgFpRzUz4ItZvZb7YfBd0Vp6OHApctUctd5VvNIHmkW5XhjxSfT+ren+aaaTKsb 63Bq6YNiba5ivyCvZHFGS/s+e9Wa9o3zVFmMic6/BA5WazC5S0NlhfG4G1zcC63M9A/p49M+l+VK bFc407MbxKeMSyPqj/LiuL2A+Fz/AFT8BvTHqplWqdliFmHVmgmnmpjdmrsCrHGnw3RierkukaQq qnlw+7nM9J7rEoaCvxmXRR0k9QRv/KYSu7eonh0zTlXqe3JNZSl+IOqRDEBwQTs5bafCf4L8p9Ce nEUmPUlJiWM1MQnqZqlgLYxa+kXTLh8UkjtHU742kaMKrB63C3kVkc1PJ2jkbpKysKypimPROlo8 PqqiAGzpIInOAP7L3x4gsmYL4sPEvR5a6Z4TEaOjk8qvq4GaY222J27LYB006N9PfC109osJdSUe mSwmqaprSZHnncj3UnjaaVHFapvk0E4hlCvwppLoZo3DmOVlnBBgmR8x5idow/Dqipuf/bjJ/wCy 3v8AX7wm5E645Mnq6HD6TDsRMZkhraRgF9vjlZXhh8PmWejfS9jpcHhmxJgL56maLU54HtdVw4tE jq5N0aSqHoBnadtm5brnOA+4wmy+UzHk7EsvTSUtfTyUdU258qRha5b48jeInJPUXqHiGVGYPHAK YERTSRACRwO4tbZefPqZ9GssUuT8OzRheHwUWOtk062MsJG87hd/j1JY5KmzgtepLenwjWbkbwu9 Ss/ZcOP4JlqprsN1W8zTz/dfMZoyHieWKqWhxnDpcPxGHZ0L2lpC3FfTm8Q2VM8dOqfJVo6bH6C4 kg0gCQe4XH/UH8JeEZvyxW59wtsdHilBGXTtAsJW/wDyvNgxqc9kj0z1LhHcmaY4aQxXL3ltjwVm Rn0W/wArPx3DAXv1Hy7HYLhpBJTaGsJeCrnwvDLaz3YMqywUkchqIuUljxeV5HDdkdIP1LSN7dyj ro201I8MGp3sF5mj0PoXkfJeJ9Rc00OB4XEZqyrkEY2va55XtXAvpT9RqhrSJImtc0O1SGw3Xk7o R1ArelvUfCMepYg+WCoYSHC+11+iXpdngZ96eYZj7QP+JpmyOaB/Va9lwUn5EjhktRs1OVv0q+qO HwumiFDXOaDaCOQXP7leVeqfSfHulOP1GEY5Qvoqlp0uY4cLfN02zhmjNOYsXGI0D6HDqeYxxiTl wvyvLPjb8NsviG6wYPheBaIKpkF6qYDa3u5fZxpTe2R8WeonBJmneTDpWnS31AHunwYRpbqk2aeX dlstp/pI43TtEk2ZqQk8xWNz+9l1T1h+nRnLIfkupYf19JO7QHR7nV24XB4Vu+rPYtZGjw26N1JU WL2yR9t0Do6qQudHE/R7ALZ90b+kwzG8uRV2bax2GzzNDvKbu5l/dfYY99IvA3YVIMDzVIKto9Hm tu0n2Nly8a6bN/KVXRqLdrjF3Gzj2RNMvZt1sV6U/S3xPMXUPFsNzWJqPDqPcVjR6Jfhq9ER/Sg6 V4e2MyYrVmods0PI0n9uVfHH9J8tVaNMs8MlQwPDftG4svSXga8LdH4kuoTsPxSrdTUdM3XI1o3I C9FeK/6cTuluVp8yZXqW1NDAP58NrFo9yvqvpQ9Nm6s4YzHVeRV+UIGEctLr+of2XX43CknwcnrU rVcnC+ML6eeXeleQDjuB1jY3QG1ni2r4WuJ1DHDWPEgOtu1gtwX1BMnZko+iWHUlVjb65rKoEn7S 7fg++xV+Gb6dvTzF8g4ZmjHoH1+J4hCJXRv3Y247BezNghDBGd3Z5dNqZ5M0lRpzk/U09R5cV9Lj sCFnMgqdFnxOD17vwnwl4Bj3jQGU9P8A+z9LKTJEwb2B4Xsbqf8ATl6c5onpYcIiOEMaQJQw6nWH t+V89YXuSbPfk1LUXJLo0o0eB108pdFSlp+dlyEWE4vHK1lVSSeW7h7W7LevlzwZdJMg5bhjkymz FZoWgGWRpe9x99lzWLeFXpzmHA3RRZdho2yxnQBGAWFXZByqzzvV5Uk6NBtTBU09SIL+UPd211Rp /OxOmpxLp1mziF6D8XvQ9vSLqPVYbTyefTSEviLf6R7LoGGi8uF08r9Dm3se4UyYvGe3TahahXRe OPhwqrbQQtNRI7gDclMpOmONYiDUfw2vjvuCIiQV2J4WcHhzJ1Qw8VGCS4/J57WthYwu29z8Lenl fptlWDBaKnOWqOKTyW6mPgHp23G64Qabpm82Xx8I/O/X5SqsE1mqZJ5jhbynsIKwMDyLjGaajysJ w+oqj38lhdb8rdx4yfDTk3F+nv8AEaHB6TDsTE7W/qYmAGx5XYHhw6HZJ6N9LInYbhdNUTeT+oqa qWMOe91rnc9l6smOOxTgeWOplu2SXJo0j8PmfhSySMyviEkbBcu8k/42XzM2Useo60Ub8OmZU3Df ILDr/st6OVfF90xx7Mtbg2JNosDdFIY2vnDQ15B97Lkcp9NekWeOrNZmjBqWhxbEoobPLGB0TT7g Wtdc3hcV9kcHq3f1dml3DfDB1CzDDFJDlmteyQXB8kjZLzd4e8xZQoGyYvg9RQho++RpAv7Ldn12 8RGAeH2lgkrMD82N50t8qNoFl13VeIjoj4hsKwrAsegjjlxGQMZFIyxjeeLusu8dNJRUmuDg9Z9t qfJqByR4ec6dQmPfgOBV2IxA2/lRkhfcS+CvqdhlA+etytXUrWjdr4zdb2Mi9PMvdO8vRYdl6gp6 CmYwWexo9XyT3WfT4tQOkkhqcToZCL3YXtFv7lYjtXo9Hmyt9n59steGrOOa8ZmwzCct19dWwn+Z C2I+n8r7ei8AfVrGKkRxZOq4Gn/3H+kXW3jEepWWsvdYsNy/gUVJLieKNtNNShrgBf8AqsvpOuHV Gu6a4fRTUcEU/mvDHF/a69DxpSSUezktTOm2+jS7nDwJdT+n9I2XFcFkdBKP5YjFyT7LYV9O7wfu 6V4AM1ZloGwYtVtHk00guYx7leos41Jxvo/W4nPEw1LqN1Qy7Q7QbXBC6P8ACF1szFnGpqcDxab9 eyEnypALEAG1l1eOOTE5RjTXZyeqn5FGT4Z9p4wukFb1N6cjDsKp2zSvm/mMcNtB5K0wdZ+kEvT3 NldhBIMkDrEA3BW33xw+IrGujOE4fhuA0pfU4gx2uYN1aGrT/wBRs54lmfHavE657pZ5Xuc97wfd d4YpfF3yXZz8yWq2KXKOro70tS+M8cC/ZchlzK+KZzzNRYRhMbqmurJBGxrRflYmIvFTMZoxsL3s vT/01sJpsX8RGDPrI2yMifqaXC9ivz+R7T9RFNqzuDpf9JPN+LYdFWZixOmoDK0PDD6iL/C+vxr6 R1dBRvlocyxvnYCRGWkArZpmTGqHL+Ey1WJVjaCkaDqmcbBoXQ+K+L7pVkaKaMZn/jNSSf5UHrP/ AOJevBjlP+MbPhajI4v+VHgnI/0t81ZoxCp/W4xBS08D/Lu7cldq4d9H6hBY+rzX5ru7GxkNC736 IddKXq511rRlnzIcCjpdczXO2c/8LtDxFdeKDw/ZZpcfxKCSoppZxF5cIu4r6Esc1lWKCps8cdTP ZuyO6PA/UH6XVbl3E6ZtPibP4VK8MfVMGosv8Fdh4D9IfAf00Ms+b6l1wHFrIx6gs/qf9SLKmecu swjLtHVw4g+Rrnee3dvwLcr2L02zNU450locYZE+Sokow+NjhYuNlnUYZwilkSUrNYsycm03R5Px n6V+SqXBJGUFbUS1waS10nBNl1d0u+lmzG81TVWZaj9HhkL9LYmD1SBdj4z9Qev6e4niWH4/Rf8A EQSOayEDdu9hqXrnoln2p6oZCwvMVTTNpXVrPMaxvYdlnLinih912cI6nyzSi2efKr6bPRGnlbRA y01U4fa6cFzvkAr4zMX0xOm+DYhDWVmMTx4O51g2R4H7IM+VmKYt44aCjZX1JjicA6JkhDNPtZd/ eLqd7coYbRxA/wDMabNvdajjlCcIt9nZ5d0JuPG0+Fwr6c3R0UkUopJpodIIcJLA/N1z1T4Eumce Dugw/DmAuaRrcb3XaeXoamj6JAsc8VZoiWb73tsvCmLfUbzV0dnqMAr8rGu/SyPb+olJDjvsu2HF lm5SxP8AizzZHGCipLmR518aHh5oujmLE0VP5NNOSNN/8ryRDopw+ISnUDcEbr0H1+8TWOeI3MAm rKZtMJJAyKnZvpvsvdPQ/wCmJksdPMKxnF5JKvGMQpWzvbILtYXC9ly1rxyaj/7ez6GjnkxRe41R slkZTtMjg3/7XJS21TfPc4izSNl6a8aPh1oelGMllCQIGk2DO268vRztqGxwBti0c9187LieKr9n 2MGZZ02heIUoIY8XsSt2H0uJhJ0AjvIX6JdIvwFpWr3tigZCRqke6zQO/wD+t1u9+m3kjEsm+Hek GIxmGWtPnMYRu0EL58o3lidclpWd213SmmxPPjcxz1DnPA2jB2C6+6rU9L1bzvhmTKuB7cNpniST UNnkLl8MxvH4Ovs2Cfq3PwcU/nFh7LsSfAGTZxixDyGsbGyxfp3cfyvvKUsTVvpcH5hVk3NKueTj cI6e5dyXDFSYTlyn0/1SCEe3uUvP3S7K2esGdR4pR0UBeA1suhoe38L4bxMV/UnBMKgr8hSGdzz5 UtGBci/9QXn/AAboD4gc0VdLiuL5iFIx0olkppZrnTfhRRco+SUuSOcVLxxiesck9IMm9I8Fe7CM HpYnMYXPn8oF7/kldK1vjo6Y4ZjtbgmaGx4e+KQsa4x3a7e116FpMOqKHI0tE+QV9XHSlnoN9TtP /wArXpiPgTzr1gzW/EMRggwfDZahxldUsBeG3/pXp0uPFkUnlfRw1E5wcVjR6f6cYf0f6pdRqXMO WY6XFa+BhcHBgc1g/wD1K76xdmKQ1cMeHw0UdK3Y6zZwHwF0N4ZPCvlLw55nrZMHxl1XXVMWmWne /g97BI8SHSvqT1JxuKLLGNVOA0l/VNDJ/nZeaSWTLSfH9nthNQw2+TuzPldl+hyzVf6grKSnhdEW yPkIsLhaqcvZ8oOmviEipcvU9Hi1JieJNjBkaCNJduvSOa/AZiYwBtRmLqbieLuYNc0dVMWsNhc2 3Xl7w69E3Z68S9O3Dqpj8Jy3Wa5HuOoyWd/le2Dx4cL5uz584Sy5LSo2s9S4aVnTKuhbTsEctKbM A2F2roLwH1kLWZlwlkETRTVBe2QN9RB+V6bzhl7+P5Vq8PY4R+dAY2uPbZeEeg3WrL3hz6tZgyrm qpMctVPoZVn7RvsuWHbPSziuz05U4505dHYPjUxqGvxnCMKZdzIals00bm7OAI/uvUuSK6OvyXhE +HxxshfAyzLabC3YL5DNPTHKvV+vwbHW1NLWw0/r/kvDhK3kAkLherPiQyP0KjocKrpmioe4Rw08 NiI/a/sFiclmxxhBcozG8eRyl0ztPM9NMMPMjcXGERs9T5S0EW/JXxOJdbsi5DoyMZzfRzuA7yBx P9llYnU4X1myEY6PE4HwVsX3xSi7bj8rpTCPAp02wihmqcyVk1fVSuLvOnqPQwX4AXPHCFVlb/8A g6Snuf0R034u/EVkHN+WKk5bqTNPYtfIxvpctVWantlxNz2cPcXArZD4rcrdOOm+C1OHYI6mlYWb PYRe61pV8n6yefTuA46b9huvoa2cPBGES6HHJZnNn2HQfphV9YeqGD4DCXBs07WyPHZt91vZoOlW WOlGRsChxISupcJ8vyfLeQA4DutMHgn6vYN0d6zYfiOPWZhznaTMRfQ73W6Z3WTpn1iyuymizdQM ZJZxYZ2hw/Yr83p21nd9H1NWm8dI7IqMYpcTytJXU7i6B8Jc3be1l8R0PxI4vS4tWSRtYI5iwOAs XJkfVHp3lHBDQ1OacMMDI9BAqGk6bewK6w6eeIvphgWYsTwmnzXRsoZpC9j5JQG7r7MYvxzhE+Hu +0ZtcnUnjG62Z0wHGJocFxmXDqWInQ6ld6ueDZdb+Fbrp1c6l9UKLA5sekkwq95pqthFwO116sxn C+hOLYk7GcWx7C6sFxeWy1I0n9u6+Lzr4wegHRwwswKKira1pDdOHsA0juSV2nPFDGlGLs4wWZzc 5Pg7668Y3UZd6Y1T2VT4qnRpM8fN7blazsU659YMHzGafKeYKzE3MJcKbQXgb8L23D41uh3UvLLo cXxiOlglZpkZUC2n9wV89TeIfwz9IsMnrcIxahrahoLrxt8yR59gSF00ufDjxOEoXIZsOTJkU0zs /wAIWac3Zn6SnGc8UrocXlkcXtc2xIHwvi+oXi/y501zfNQU2TZ6vESS1k8DNnH+y67yv9UrprVY rUUuJRyUWFSEtYY4uB8hfZ4b4rPDbUVbcR/jNGKokub50epwPPBXDH4lOUssW76pnbK8qjGOPg6m 6l+K/qB1JnpsGjypiGDYZNM1/nsiIOx2ufZevMblxDEugsEu8FayjbqcNjcC11476sfUDwnN2MNw Hp9hUFXC2VrJKp8Y1vaT/QF7my/ijKTpLhlXiVI+dr6Rj5KfTcuBF7WUzTgtuyNc9GsKlLdvfJxH QNtU3pxE6rldNI+/8xxuSF5bzXgjX+ILD2CzHmqD9RdYkXXZ3U/xqZQ6V5floqTDJYq9sZ8ilDQG g8C61j9RvF/mDEOowzC2XyJopg9jGHsDey+npoywLJlyran0eXLF5pRxwdtG3zrxl9uZcrx4ZC2p dUyx6IXQHh3a68AdW/CTmakw8nGKdkcTiS2ZvI9rr7rp19XfKbcDp6bM2X6huIxMAdPHYtcQvgut /wBSrDOomHz0mD0UkcRFmCU8LzaTUbE4Oq/TrqNNNpS5s8RdX+nByHiXlyTid5/qaVw3ReldU9UM vMa3Wf1TDb90fUDPFTnPEZJZd5HEmw4C+UpKypwSupq+imfFNE8PZIw2IcF8PV7XNuLP0GjjkWFL J2fpFylitVS9MqeajaJq5lM3RGTyQ1eX80Zr669RKupdl1lRhEdPIWOvHZp/B7ry90a+q1UZPy9Q 4Tj+APq5KeMRmqa4HXba5C7BxH6weHR0rm4blctkF93EAFezSZY4Vyk3/Z83VYMuSSStI+0qekfV nG8fwitzhjk2J/p5Q5tOw7t3vwvW3UvLtZiPTukjjhdJPDE0uieDc7d7LWqz6s+JNxh1c/LzXnVd rNSz6v6x+Z6lrmR5XpBfYBzv+69eTVKc47aVHnhosig9y5Hdds357yzT1WGx4rJFQSuNqON1iPiy 9RfTXwnFaXpViFXitNPDNNKSx0zSC4e61gdWfFpjHUrHmYvJTRUs7XavLaPSCu0sgfVS6lZCwSHC WYdh1TSxNDWu8sBwWtfnxTSWMaTSZlLdNHsfxGdMMRw+rxrHW1MvmSvLmiKQggLgvBFVl2eZXYhj Mj6ht2iGWS9wvInU76j+ceqmGupamggomE+p8I+4WXQ+BeILNGUM2NxvBqyWkna8Pawk2P5WM2tg 8ShH8Nx0WXyt+jcp4hOl+aM69QqB2G4W6qwwkF04Ozfe67jmweHLnTUYJO4tkfTmNoaP6iOFqSoP qrdU6SkbBH+lLrWL5W3P7L5nNn1Her2Z4hE/FmU7PaBq5LNujHdLhGvizUnx2bhehOUcQyrkaakr Y2RSyyve0NdfY8LzN4gelk+H4tila3EqrC5LGRskR0h3fstduG+PrrJhRIizRUOF9g/cf2WBmvxm 9TM9Uj2Y3jT6pjha9rbL36HUwxZ3km+GcdRoMuTGoxQjq/W1eH4nI6pxGSvq3ktD3vJcbraR4AOl lFgXQbDJsVw+klqa0+eZZmNLwDuACVpsoM9zNzZQY1X0/wDE46WUSOgkOzwDwvcuXfqjYThGUosJ jynPSSxN0x+S8aG2Xkz6pajO+aR6ceglhwri2ex+rFLQU+OVDoKtkcTL3iAsLLV34w8wQYhmuSGn kDmg20tNwuW6leOHHc709RDRRfofMO7r3cvNeO4pXY9WOqqqUySONyXHcr2avLix6dQXLOWk0eXz 75KkjiXvJHl782W1b6YHR7B8qYJJmjEsdpo6usaCyDUAWfBuVq0/SNkoHTh1qhrvtHsuawbqFmzA MO8rDsYq6alJ+2KUiy/GZIb+F+n6mS+tG+/rq+irqrBZ21lLLTwSAuDZgDzzyvq8Z6r5Xy1lqjnm zBQQMAaDAZWl7vi11+fdvVzN+IDTUZoxGQtGwkncsCqzpjmJzF1Ti9VO4Dl0xNh/dfoFmxPFGL9H wnpJqba9n6CcxYlk7rJluOl/jNK+ncLlrZwCP8rquHo30cyXDO7G8fpKgNu6007TpHt8rSbQZ6zH R6o6TMVbTMI30zuH/lSqzPjNc20+PVFQBvZ8xP8A3KzHWeNeOLaieaX+OlOW5vk3hdPfEX0ZyTPP hODYxTUsTnBuobBx4RYnh3SvN2dIs0T5zoJALB1JJMzS78grRU3GMTkefKqHt0/1AlUzHMRdUOEl fMx1vuEpWoalQk5QbVnSX+PlkilI3X9WfFB006TYjROwiPCquaOQB0tPpOlvfhc9VeJHoZ1kweni xTNNE0vaNcU7wA0kbjdaKqrE5pJC39RLO73e4m6wP1L2vsS9pvwHcI9VBtN3a9nTH/j9qas3sR9W PD90uwCWlp6rBqqJzSLxaC5914tz/wBculuI5mMD2sOFGq84NbawAPC1+nEKhxs6aT41ElY8kjpS bklystYlF7Hd/pqP+OSa3M3g5J+oL0JpMu0uFPrThrYacRaQz02t7hee/EB4q8i0UTMY6b4uJMWb JrE52I343Wr4Ag2JIHyj/UyW0B50rnpta9Pb9s9OXRRyJK+jbT0h+qHkeuwWlouo9BJJikVm/rI2 ag7blZfXf6l2TXZajpchVL31LthqFtHytRYndwQHfkJraxrdjHb5C83ym520Ho0lRtB6RfVYocPp RhWd6OapaOKyG1vwQu0af6lvRXB3S1WFUr21kovI4w7uP5WmmScOd6RsexTHMfEA50YA+Cu0dVD2 jD0MXTs2X9XvqKZdzq6obRUD2xTNLLtFrhePOq3iLrM3Yc/CaGEUtHvc/wBRXS8WIP06HH0oZwyT eIknlerJ/kX4/HDoxj0EI5N0iqHEJ8OrIauneY6iJwe147G69sdFfqeZm6fYPHhOP4PBjlDEA1ur 7tl4oZStNOS4+tIdH5W53K+Ddy3ez6ksamuTZ3F9XnCIGk0+RnU5/wCiQL5bGfq14vW4i2enyxEI 2H0tMm4C17R1DX04a+xt8LGfMARpbYA9u69+PWyh6PJLRYpctGyH/wDO/wCKspdEOUacVFv+ZI+9 ivk8z/Vb6gZhpDTMwmighPBAuV4MfVazsLfCpj3scCX6WnuDwt/M5ulZhaDFG6R7Dw76nfVzA68v pqilZBsBTPju0L69n1b+p80BjmwvC3ueLFzIi399l4Mmku+5k8y3coWyEEm+n4C5/Le7c1Zt6PE1 yj1ZjH1AepdXj7cSoKqCimBu4Mb935X0+F/VQ6v4TF5Uj6Kqb3MkW5/deLPOcCSHcqanlt0nq5y6 KtJjXFHrDEfFt1M8RmbKLCKmqeymqZAw0tI4ta255W0/w15BxTI3TJ2CyVzn1nlB7JZDvchaFcs5 nxTKmIsrMIrHUlWOJGkLuei8cPWHDqAU0OZ5fSNIk0jVb9lharLuV9HHJoYN3E2f9WsY6p5YE0tL mRrqcucHsDvtavAvXnP+M4lVTRV9eZ5G3u8OvuunMW8U3UvMUb21uYqmZjvvF+V8Ni+ca/FHF9XO 6WR25JK/Tw/yGBYaUaZ8h/43M8lt8H2eXPEb1FyNNJHgua66lhado/OJb/Yr6aXxkdVcXhIrsxS1 rB/9Sy6FMhc5xcNyeFkQMBhcBcXXwFrckZNn3/i42q2n02aOqOO5wqnvrql0z3dr7L5R88xeS7lF FB5b9QN0L43OeTdePNqMmaVyZ3hgx419Udo4U39O2a4s6+y5GACRpN/UsGeMwYtK29o1yFJY2AG6 /MYW5Qs/Q5P5sVUMLoiHLg5oQx2y+gr78XtZcTM1pbdfQxdHlyGDcNN77JrSLXSXGztNrhN06Wr0 HATP94PYpkUTHWOxclTOA5QwEiQlqwynJCQMZpe79grbc/hKsLXPqKNjiLeynspZF3bFQ7cqjufZ FqFkAAO/Ckp21Kg46vhRo82/ayAEusPyiY7SLDlKsfMFt1cbi+qLRyAtIjMxrwRv2UfIAd27oACL Ii/UQCN1shGTDcvbdExzagH06EpwN7WVjU3YbFUDTBp7qwNDrA3VP+0G6HQdjeygHDYG/KG+97Kn EmxVkbKUC4yXusreXB3p2KAO0OVMdaTUdwgCbJ5pcx2xCTOfndOqntNjELO7pQj1sueVQJ+Vb9xw meWBbVsFJRdthsqDHIN9k4hrm7m5V2AbblW0CyEKAEY4urLIze7QHfCh3QPaXH/4VJZDuLArHkic 629gntGnlUR6rk7IiFTHX5YbsGhWeLe6o7qi42VBLgD5QPkYxt73QSEnvsltBm9NtwgMmnk13I2S qhmp2vujjbobZE9twAqgYp8wkEkphnkDbA7IvK0EC97qi0u2JWjBGgaSf6lGsuDqVMBYi17fCFRC 8tbwoDdt1Adig182QMsbkjuqJLfuQtf67d0Ug333QCi7U/1cImBjnFrTugc21roogGPDgboDJZGW MsBugc0h1zsU9jxblJkPqJJ2QpTDdxJTA4FpslROa9xsbJb5zC/ywL3QMaXBo3KguTtwkyBukBxI cmuBYG78oZGOe2PnlUHGXdACCDq/ZWySzHIAr2Fu6thIvdA0bD3Ri3PdAQONt1Y4UBufhQblDVEI smsYHNvqslnYqroLCLb7WSZGgOJCyTby9ljVDiG2QosPPZMbZ4BPKxwSCmRu2t3WkYGkW3A3SXuc Cd025I2WFWVPkEEjlQDCHE3umsI07rEiqDINrJ4eQ0bJYHE6lbX/AN0lru6geASgGh2o2R6QPwkM f5Lg5w2RSuM1nN9LVChSBjTY3IPsj2aBa4SvMBba3qHdMBLgHOQ0G61gqJ22QONjcmzVRdcoCy4g qw6+6WdnXVhy0QZqVtdv7pRPyiaqZG3ui02slsFzynNbqNzsoykvY2U0gu3TGsF9uVDFc3WQDGwx u91Ugu72RPBbx/dLF77m6FssFpGk7lW1jgLg7qCwARB1xbshBHqFy7ZDcf1brIk9TbFIezdCEY4t dchFI4SCxQF2rY7WVagPlVAsvsLWAWO6VwNr2Ca5+99v3SZBd1xZQEdWtYLWvZLEvnPuBb4QOjBd uNk6OIAggrQCBI7qAndWQLqXDAsgmq3KjKgNd9twkTPuEDH6GbndWgZUr2yvY/u3gBELu9gUiMNM RN90TQS0b2SgOabGx2+U4WLRY7rBePM4dZQlzWAB1gEoGXKSxtz/AISA7V6rWRgXLS83CxjUiWZ7 WDb3ULY8kK/+ySLA2KPzBwgGj8IgUAPcIwLBCosC/Cm4I2Kpr7G42TBMfYFCgvNmlDGNLbpmppO4 /ZE21rAIC44i+3silh0ge6j5zDE0AXLjurmeABY7oBIibq1HlXISQB2CokkBNjaR9wQGPqc2QNty mA6UUsrRdtt/dIJ1G10BkRyFxtex7KzGT9+6WGiPTYpz5WkA90Asxta3Zu6RIQ0aSN06SQgAtN/h Lc7WQXCxQli9YtbuFNelt+VbgL7KaRZCAOfrI7IfM0vtyjIuQNihAaAfcoQJ0rXC3dL1I2BpNiVR aB8oAQ5WTcKnnQQhc6wsgCHBUcbKW1K5YnRR6r3CAC6vVcpbHlzdVkTTcE8FWwGDYhWXbpYvZUTb dQDQ4W3RxPAduOFjeb7pgltZaTKZTiHhFptHtykMfe57Ig/ZZZoPgWJTWNs3YXSBJxq3ROkPLTt8 K2Cz+FHGzkkveLm9wlumF7XIUBlC1791eu53WJ5pb2uibUg88oLMoWumeRrHpWKJA7cFNjkfp5QE fGW7FQOsLKOdq73QOeGoCybbnhU+eMtsHAJWsPeATYJNVTtc6zA4H3tshluipZWl1mu1FZFO4gA2 2XHCF0T/AFcrJjkIZ8IDNBu03CURYX7pfnXAF1PMFyL8oaLbze6F7hf5V+WHcEkpJge15BQEeT7W +UBdY83CuUSBlwNX4SGB7/vGlDI8yAqi8WSL2da6W+YNda4Qhka7d1Yk9ysUzbX7Jf6qNzreYEBn mSxG6YHjuVxx1O3YQfwmNleBuNI+VaBnteB3TmzCwAN1xf6jSNzsiZWtvsbqA5YOAKIOH4WDFVCQ 2vZObUxsNnFbBkGXeyjZdN7kJZeH20C90E9HUNb5rIzK0D7Qm1gcZduUBlBJ3WM1/msv5T43D+ly VqlsXabsBsSjTLbM0TNJ+FXnDjcrjv1hD9JYQfwoKlwcNrhQl2ciH/sp5xPdYrZb990QIbezlWUY ZC6S5P7KPcHBJDwXc3KVVTmFu3B7LLINe4NHpNilGSw33QUksczD5lw4dlhukPmFrbn2UBn67g7X CWfMLXOa29kNPUPadDhpPyqcZ2z3bpcDyAVaHBUQE0byTpd8oIajWdHcKo6d/wCrs9rms5KzamGl 0Wpz6x87rVMlinMcwhxGyS+YknYgIWT1MgcwNN+xISHRV7S7WWFp4sUoWGdZPpUGpr7cpdOJAbSe lU4ujkuXtc345V2spyAu21zZU99jxshoiZg5zwQBxdWCZ3OAGwUBepWXAcpc0zIXNYSC/wBkp5LD fgHshqzJ1jdW039khpJaCVRc4ISx9hwAAjAu24WOCTa26J0roW8/soSxwebco2vG3usNzpGt8w2D flUappZqYbgeycks5FsgvymEh3K46CcTRl7ftHJRxVzHGwOwUbFmYA0m1wEqSXy5AOSjZStnPmGQ NYO6yGTU2sM0F3YvssGkwY5WyengpkjWFli31DugliZC70HlCJDwUs0LHpHsChdIWDj91cs8bWE+ x7K6mOGKJj/N8wPF/wAKmWK86+6nmC6khYIw5guPhIZKHXJH7BUhlslaB6imsewN2It7JApWui8x x0gcAIGVVJGdJlAPsVLBkSuD2XC4usLgWuBuAVymlrmEh48s73CxJq6kZCY4x5jvcqWDFqA+en1N bYgLGihkc0iVgDD/AFL7TIvTLNnUWtbTYHhU9SHbARsJ/uuysU8E3WHC6I1cuVqkwAar6b3H7LrC Dn0c5SjHmzoAtFOCPLeD2cRsVTgJCAX+Wbdjyu9cm+EXq5n+rdQUGWKnU3YPcyzf7lfYV303OuFP T+YcstqWjny3gkLp4+drOflieUJKgRv0Hn3Qioe7gDSPld4Vvg26p0eZaLCanJ1c2erdojk0EMB/ K5Dql4CurvSfL82OY3goGEwtBkqI3hwYD72V8P4Tyxfs89GscHabX/CIySEXdYA8WXo7ot9P/qn1 owL+M4NQtpcPkaXQ1FQdLZbey6qz70Ozb09zo/KeLUMjcYDwxsbGk6je2yy4U6HlivZ8G5z7bmw9 k6GN4aSfsI5XsXKf0r+qeZ8pU2NiSCjfNH5op5jZ1rXXQGGeH3NGN9V35Cjic/FopfKlDBcNN10j hclaJ5InWPlVGo7lrSdieEZgqoxcFr/wVsTwr6O2b63DoZn5ppYJXtDjA5puz4K+U6h/Sf6mZQwa orcNqafGjA0vMcL9yB7XssbFdGPNCrPDHnTsA1wkN905kweLgJ+LUGI4DXVNBWxOjqKeQxSRObYt cO1ljvwrEGND30NVHGRfUIza3upKDjwzvGSfKfAZqHDkbe6dSETvA7KonRAeQRd1uSpQMbTVJDzq vwFijouTlmyxUrHlzNQtx7LGbXny5CwMs73O4SpIqisqRS04L5ZDYNbyvePhV+mFV9UMtw4/nGom wTDpm6o22tJIPffgKqumYlLYrZ4Hc5+kNc4tPuhl8yJltWpx4W0LrF9JOiw3L0+I5IxuSvrIGEmj qGj+ZbsCO68m9EfBjnPq11Lny0/D34U2hl0Vk1S02Y2+9vdd1jtWjg9TjTp9nmuWWSMNs11++yn6 icjtb8LcvP8ASc6dnCI6WkxWpNUG2fNIQSXW3IA+V4X8XngWzJ4bp2YrT68Zy9O/QKmFhvGT/uHY K48aycXyYlnp00eSH1Ac0tLtLvdXA3zZAwvDieCTZehvC34Qcf8AETnanpoKcxYPE8Grq3CzWN7j 8rYd1h+nz0M6cdIcTrauIYfXUlKXMrZZbGSQDYAfJWfHUtrNSzpI00S0k1LKRJyeLboY3zavSNjx sve/gf8AAczrrilXmLMTJ6bKtLUlsbHts6oaDta/Y2XvLHfAP0Fx3D34VDl6OgqA0Na+lkLXtPYq bIp8mZZqjuRoaqo26QXOIkP9IS6emkdcMge93u0FbOG/S1xjDOuVHC5kVbkEya3VbyDIG3vpI5Xs fFfDx0B6RZcbNimWsLo46cAGWdt5JT+/K6zxwhXNnKGqc/XJoMio7REVLJo/ZxbtdJfTTySsbAXz vOzWMG6/QXmfwqdJ+q3T99LQZdw2CkrqfXT1VLEA5txs4Fa4PDT09yJ0f8XU2U86Qw1lNDUOipau pt5ZcCdN1VijNNxC1LT+yPDrsKqqR7RW0c9O53BlYR/3S5qLy3GSN2w5X6BeuPhA6edbslVlFHhV HRV0sZdTV1GxrSx1tuOQtI/VvoHmDpP1DqsqYrTPiqG1PkwuO3ntJ9LguUcW9Nr0dFmSdM6uoIa3 E5vIpIHzyHhrG3K5KoyzmGitFPhtRC932tdEQXLbx4DfAPhWQ8rUucc70cddi9S0SU9HK0FkUfYk Hug8VvWHpXlbqnlvLmH4Jh0+JyTsFRWRQtEUO9rGyY8e+VIs82zs1IuyTmHD2MqMRwqupIH/AGyS wlrT+5UwfIWP5rneMFwKsxMtO/6eIvt/ZfomxrpdlTqP03bQS4Vh9XT1VJeKWOFtg4t2cDZdd+EX w30vRfLGJtxDC6eLEp6t+l5YCfLv6VXto5+Wdmj/AA7ojn/E6gUrcpYrrHANO4D/ACF9lT+E3q5+ mDoMk4i9vY+Sblbx8N6t5XxDrPW9PKWkgmxSjphVSysY0ht+3HK+o6j57o+nGANxSoj1M1BoaGXP +FpStpKPJtZW4ts/PzP4Z+pUFU2KfJmLCoc62gQOJv8A2Ss7eG3qD0/wmLEsxZdqqHDZb2mfEbN/ K/QLlHPmAZ5oKetglpHSzcMBHmA/g7rkc8ZBwXqDliswPGaCGto6mMsLJYw7SSOR7FalJRdSjRzU 5ytwdn5++lXhR6ldS8PdiWV8DkqqQf8AuyNs0/i/K4TH+gOfaDO7cp1eCyR4/JL5YpmDn5/C/QD0 T6UU/R/ItNlyIxysgke4SMbb0k3A/Za3PHR1Ln6Y+LyizPRQsBwxsTvJttNxqv8A5XXEoZG1+HOe XJCnI8y538DXVnpjg363EcJfPAYfOeIQXlote35XQU+GeU6RkzHRSscQ4O2IK/RP0S6v5f8AEV03 pMdooI3088YZUU0oDjG627StYP1MPDxgHSnPVDjeBtEDMYDnyUjRZrHe4Ux4lmexKmZ+RODtv6nh ZgbHANIsTsD7onxCjoyTLZ5N1HxSuBDRYMNwiy5gtTmvNNDhRJ1VMgZtxuvLODhJxkfVhJSipHN9 PciZg6qZipMHweB0888gjYS3kld/9TfAr1H6TZVbjGJYP+ppmgGZ0LdXlj5WxvwReC3BuiGXqXMe KRR1mPVEQlhJFxACLi3yvQOF9Qso9U34vl+Msr5ISaerpZWggcg7FZg0n9lweXJkkuI8GkDw2eDT HfE9jeJQ4VUR0ENFu+WcWH4XqCh+jfjIaz9ZmemYO+ht133g3S1/hO8StFVYLORlHMZc2ShaP+W8 n/wV606p1WYG5JqX5XhE+KyafKDuwvuf7L2ZorG4uHTPN5ZZYty4aNTHWX6U2aum2Wq7HsExhmMw 0kfmPp2NIeQObLqzwk+Cmq8TmNYnDVYkMHjonaZA8ernfZbyGTmkyQ2fFWML2Ueqpa7gnT6uf3Wp XwxdS6nAfGVi8mESObhuIYk+F1NEbMILjwFxjUk3R55ZMsJKKd2dt4h9HnCMKwaaelzWTNFGXXla QCQPdeIcu+E7HM9deX5CwouqiyXRLVxbsY0HckreJ4hamqpOjeYamjc5k8dI6QaTY8Lz79OPJWHP yJiObZomS43W1j2OlcLvY0Hi5XojLdgbnzXR1llayqC9nXGBfR6yrRUVO6tzLUVNVpHmRtj0tB+D ff8AsusvEN9LcZNynV49lCZ9VPTMMklK83u0crtzx/8Aiszx0Yz9h+G5PrGUMTWCWodI3aTa9l8q 36p+U8w9G8Rw7HoaiLNT6N0Q8ptmSSEWvdc4xlGKk+jnPM5SqCZqxxGjOHVEpdGGTseWPA7EGxQv jijkbLYST21aTwjxTEjjVTVzH0mondIR+Tf/AMrEdhr2yAyPsXgBgvvuV58qjF/U+thcnGn2TXFX 6w2IRy83aEcFNWTEx6fSPa62l+Ar6fWWMx5Ap8252oRXNr26oIHi23vdep67wT9EaORlIzKrYpJN tcdyf7rz43vfJrJJY1yaEjhkVNEXua9z/kJtM5lS3y5b82s24K3MZu8BvSjJOdMGr6jC3VuD1Uvl 1EFU4aGAnY3Fl3Fh/gi6JwPhqqfJ1CS0BzHEam2/devZCKTfs8nyG7UVyjQbLQCmdpJkYCNtTNv7 rEo8JnfO50RLxfgAr9BuavCV0uzDhEtM3KWGNdps18UYBC+a6a+FrovVUczaLK9HPUUknlTue2/r HIWqh2cPlTU9jiaJm5Uqp2ue2jl0cl3llyx6zDZad7YG0jn1BFx6Tuv0YRdDenVLF+iGUcJEbm2D P07TsumavwEZDk6o0uYIaGCmwqP1OoGtvrd/8KNQfo1LPNNUaPKLIuY69l4MHqnX/qbAdx/ZHXdM 8xYS0Onweqbq4cY3Lfv1Uzd0u6DYXR0tfgmHNqKl7Y6ekip2a3XNr8XsuUzb0eylnHKDa+lwOigq PKbVRPMYAG17FFFVyuGPlO3H2j89tJkDMFSNsKrtzYaadx/8L6Wi6CZ3lpP1jMtYlNAdy79O5u39 l+gLpXFlHO+UaSuosEw9zIT5DrU7DZ7Nj2X17JMv/wASfhMQohWsZqdShrdQafhYkkpVR08zcd0W fmxxfLpwSd0ctJPSVcZ9UcwLT/Yrim1Jnje98eks/wAraX9VLo1lXCcIoc20UMFDizj5T4ogGiQe 9gtWdRA+DD3jlz3X/C1kxbIKa9m9PneVtS7RiNNXU1TIomuMryAxjBvuu6cqeEXqnnHD4qymy3X1 EMjdTC1h3C5/wD5Ew7PviEwinxaFtTTRODhA4X1G63s5qxGh6a5Hr62kpYoIMPpXPjja2zdhsNl5 UtzpHXNl8cW2aI6nwT9UsNozUS5dq6cN+5sjd1jYJ4M+q2Z3PloMqVs9PGbPmaw6Qfa63PeGvrpR eIDJs1ZPRRx10Ez4Z4wz02vsRdPypm+XCetuL5VL2RYeYRNTwBlvV3XtjitNPtHzFq3JJ3wzUZg3 0+OsmM3DcsyQlveYgBfJ9U/DH1C6QUrZMz5bkoqVx0idrbsP7reN1J6knJuYsr4THEHyYvVeQ51/ sHuuL8TeWMMzH0VzK3EqZlS2npHys1gGzgOQueONySfs6yzTinT6Pzt4pEygqQ/QdXAaOEjCsJnx nFqShFozVShtr+5svrs408RxGd8LWmIPdpFuN1wmGSvpsdoZAbOMrLEdtwVrVYVhfB69Nl82O2b0 fBR4asr9JOneG4xTUbZcZrIg59S9u7Rbsvmetf1BcL6Qdbosj1GG+fRt0/qa9zrCIn4XoXoVMZ+j OUXPtrOHREkf/ZWmXx2CqxzxEZvqo2yFrqnyWtsQbnbYLppYRne4+ZqpSjOMYvs2U9V/EvkfGsSy TDlzF6euxXEK2MGWjcC6OMkXBP8A4XpXNNZV0GVK+egBnq46ZzoW/wC51tloj6D9M835H6g5dx3F cFxCnwttTG6KWVrrHccLehi+ahgORY8ZdSPmDKZszoWi5A03IXObSklE7+FwjJt9o4nplX4viHTm lrcwRiPEpWudKx39G5XPPjlbliraJjUOdC8see+xstcPW36k2I5rxNmVco4f/C6easbSzzyf8wjU AbLYrkwA5Cwt0jy5v6BjnPPc6N10yY5Y6lJVZ5cck1si+keKvAvVQ4b18z5SviEdVVF8l++zt12B 4/8AF8PpG5Fp8cjNRgwxATVEZHpcByCusfBkP4n4q8+VDfsikktbgDUvv/qfUkA6PUNe8Xlhq7NP sCF6HjSzxUvZhTcdPJ/h6P6MdQMtdRMkQVOVHRx4ZBaFscIAEZHbZeGfq4xuxCbI2GRMMlRPPYMH cE2/8r736XtTNSZGxTDST5D5BO1rjxddd/Utxv8Ah/VXLeI1NNJUU2FBsrCBsSDqt/dc8EUtRXo6 zyb8CmztjwReBvBej+H0+csf04pmKriE0DZG+ilBF7Ae69jYXisOLMlfCCGxnQbjuvAuR/q3ZE/Q UVFjmAVtA6KNscj47ObcAC9uy9xdO85YV1Ayjh2YsFaRhmIRiaIlukkHvZeXLcpOTR68Ukko2aaP H1ljEsO64ZolxKExRT1AlgJ4ez4Xu76f+dun9V0IgAdhtDWwDTVslc1rnWHJuvLH1OuoFJjfVWuw ZlOGy4bA1pl0bk/lL8Jn06sU6r5NbmjF81V+C4ZXR6qanpHFod8kgr6mri3ihLrg+dpVLdJt+ziP qR57yZm3PVHTZcmhqI6ZmmSSG2hru4Fl4LlpIqWcnWHAm9wvVXjF8I8Ph1raaOlxqTGXVJJdrvdv 915bqqRkUTWknWNt14My4R9TSvlimxhs1PK7dmu+638+BOjp6bw2ZdfSxtjbOwvOnudrrQUyMujj efsjcLhb6vALjVFivh0wKOkq4qgwstIxjgSw+x9l81K8iZ683GNiuoWRM34j18wnH8vYkY4aZgZU RF+xZ3BC73x+WKOGjhqKQVLpHC5IvpPvuuicewvqTh3XqmrqGMnKlVZssh/pF13XmzO+EZIwxuIY 5XQUdO0gWlI1OubbBfWzdRaPzGnajKcWfP8AXrImIZ/yA/LuE1f6CqqQGiYO0lre6nQHJL+mmQ6H LFTXOxCtowfNncbl1yq61fxvF+nv8TyfVAYq1olpXM9Qe0/hcd0EynmLKeV6qtzbiQrcUrB58j3H aMe37KJ3g22e2dLOpJcUeRerNHBmTx94FDYeW17LtPxyvZfiFrTgnRrNFbG8sdT0D9BBtwFrx6od bsqYR438Dxygr21VLFVimneHekOvYrZP1CytT9VOmtfg8cv8jFaSzZWG4AcLgreVVOCkcYf7ISaX ZrU+mBjL6DrZjcUwa5+LQvkLgNwb3XvjxDdMourlDRZflxVuGMDvMc69ibdgvCPhuwOHwr+LU4Hn qsjoqeWN0VFUO2a6/wBpJ9l77689Nazqpktv+nK80OLte2WnrY32GnuNubhdtVOHmTj1RjZJ4Xa5 PouluWo8sZOpsCFSK6Khb5Xmk31bd07JlbWVLsXjrLCkikIiZbhq+e6e4e3o102ecw4iXyU8Zknq Kh27nWXNZKzjRdRsmPxfB2gMqmvY0NIuCNrrwyVyf4dMcksa45/D4Dpe7pJUdRseZldlLLmV0hdW WbdzHd7ey6X+qDhlZV9JqCuhkMdPT1BbIAeQQuf6BeGnM/TzrdmPM+N1LXw1b3PhMQ2cCeCuG+qP mmgwToRS4bNK3zq2qa0MB9X5svpRlHHnjJO0fMhGeXE4OO2meHvprtdH4psNmD3MhbE8PaL2dcG1 1tZ8WUbpegGa42N1PkpSGryV9NXwsz4KyfqHjLAyKra0UDTy5ttyV2J9QbxR4H06yLLlChqYqvHa 9hjkhY+/ks4u72K8ySnq+OrPoydYW65a4NPOcIZKqv8A0kTS6d79Aa3kuuvqsP6A52p8L/W4hlqq hpAzUJ3MP2+6+28KeQZOrXiJy3RmnNTRQ1QqKh1rtsDexW7fqlg+XsF6Y4w6qwyB9HBRuaYwwDYN sLL0axwnncVzfB69O54NOmfnUxiiqMJdJRwNF9W5WPM10NEyQuvMdrcr7Tq3Lh9ZnPE3YdG6np/O fpbfjdfCyMcyndGHF7+WlfNz4fDLln1NNm80LJg1U8Yk1722LTcfO6/Qr4QGl/hzyfK4aXTUocR7 dv8AwtC/SLI9R1Oz/g+ARPZTGaVofNIbAC/uv0N9J8t0eQumuBYNHPCYaGjYwuY8Ftw3cr56tT4N 5napjMMznQ5nxXMWCYW7TiGHDy5ZGjYOI2XwfRLpvj+Vs145iWPuFRNVOPlzvOpxbf3Xz/h5zLhV Rm/PdY7FqRktRXluh8rQ6wOx5X22YOvOVMl55pcvYljVLH+tjL2TumFmu/2lfRqUbivZ8VqM2py9 HGdZetvTrptidJHmnHDS1Zd6IonkkW9wDsuGovF104zjjuE4NgdUcYkqZA3zPKPlxH5JHK4HqX4c OmPWnOMGY67GqaaM2M1O2oYRKex5uFgdUM99IPDDgmGSw4bhXmtlbDG2nLS9jT/USF74wwygkrcj 5E8uojklcVTO5uumY58u9GM1YpQylk8dFIYpIzu022IK1VdJfGp1L6fn9HK+rxyCd7v5srTJoJPK 2dUvVHpp1qyLNh8GaMNnoayHRLEKhoIBG4IJXx2A5V6G9Bsj1zKmowY0Tg575qh7JJH37N7/ANlw jCEYS3xdnqcpTywpqq5Pp/C31LxzqlkSXFsf0Nla4aSwFpt8hfI9ZvGdk3pljjcP/h0+LV0L9MrW xkFh+PdfLdBfHB0mrMWr8qwVMGCRsmc6nmmcGslC+yzzivQDGM40+Z8exvBZsQjj0i87S0+xcB3X lpRlT6PblT2JR7OgvER45jm/o5jmH0+Q8XoI6+F0UdXVsLWW/wBw2XVn0v8AEMQrertRRRTzNpGU pdURsJ0k87rsrxzeLXpfP0lmyvlaqo8Zqahpjj/TNBbH7br4n6d/Xzot0iy/PPmLGm4VmyrdolfK CWaewXrb24qijnjg5yW7k9V+PfDWSdJ21Esd445wAT2J4X2nhCx2TFeg2DyPcx76ZjoWhpuRbsV1 x4ifEl0Zz/0pxagGcKGtlDDLDBHJdznDheHPCt446fohn+sgxmqlkyzWOLHMBLmxi+zgFzct2FRl 2jrHGsORyj7PWfSTpzmGg8YOO49X0MkEUj3Pa5zbAtPdezMQtFiMU/mM1W3jPJXm6v8AqD9DsOw2 XG6fMMdXU6P+VHH/ADXbcBeH81/Udxis64R5ppTLFl2CQeVQuOzmD3H4XSb80k+qR47ljTXLtmyX xOdXsU6RdPGYjglM2fEZZA2Nr23B9xb3XRmSuvniFzphM9fQ5LonULY9pZvS5zrdguJn+p70gzDh NM3H6A1R2f5OgP0O97EJeYPqm9KaDLtTT5fpKwVflkRtEQY0G23C5Y1FcNWztlcpvh0qPBPifz9n DHs5VVRm6jbSYmJC10TW20i66CmlZWMna9xY212i/JXYvW7rZL1Xx2uxari8p0j3GMO5sSurK+Nz aBlU37h2U1mRTdI93+NwvHB2bP8A6RnT7CnU2LY/URMdiMbQInGxIXufqZmrMODZoy1Q4TSOmpau bTVSsbfy2/K0f+Fjxi5g8NWPmqp6c4hh8p/mU5da4Xun/wDPEZUqcMZIzKdS7EwN2ucA1pXkwraz pqoyfR7I8TeCTY30sqmRusYHNkcB3suYyfRSTdFqOmiYZHz0GizNybtt2WvLEvrDT4lSz0s2Q4pI HNLNL5r6vkrrzK31X88ZafPCMIpH0OsuhpXbiNt/tuvXCaeNL8dnham8jml6o+8pPAFmjq5nfF/4 i12DYayZz46mQFriL9l688IHhwl8NjMawiqxsYpJVua+IPfd4aPYLxsz6yOYGxPjGTKQyuFtYlIA +bLpDG/qEdScY6htzZQStpp4xpEI3YB7WXq1Oref+VI8WHSyxUuezZD45eiGYutFFl+iy/SmQwTH zn8WaV1Nkf6atXlNsWJVeZf+JLmyuaPthI32K6Kwr6wPUOOlZBV5bw+olYLGWxBcfldddUvqQdUu pVHLReczCKN4LTDSbG35Xm+XJY1jvg7y0u3K8iTs3EYzgOJf+lownA6tlViDKYRMqC/ZzgLXuvIW BeBbOWd81TYnnLMlbh2HPJJpaKoOpx/N9l4j6cfUc6ndM8rjAKWYVVn6o6qpu54+N1l4j9TnrfVF 8QxmGNsmxayEXt8FdtNqZ4rUK5/UdMmmeVpys9pZG6Z4J0X8WWD4TQYhJiMDoSNc8he9jiOCvXXV bpp/6hYPFTNkEbmytkOr2C8G/T8ypj3V7PE2fs0YmyadjhKyOR/8wk8iy97dZP8AUwyrUDLMzKar 8p15XHjZXJmebLHb30XwKEJOXRh9QsyYF056a1gxathipoaMw6HOAL/TawC8X+AHqnl2XqdmOkqa +noTNNIKRkzw3WL8AleJevnVjOuOZpxXCsZxuprDRzOjeC86b/hdK08+M4TXQ19BXvo6pjtcb2P0 kFazRWGLx3dnm08JZpqVVR+gvqd0gyz1RrYa7FZIao07SGguBaB/da5PG1kPpxlGlOG4HFBHiLXX l8pwNl5D/wDumeqIj/SzZprmxkaSI5SLr5TFMy4xj+ICWvq5q18n3yveXE/3XTHqNuHx7rX/APR0 noZvUeXbycHJFFDi9RFD6ozt8Lu/wV9UcP6NdY6PEMY9FKXhpfwG3PK6NlmbT1ssdrF/BPKoNfUh zXXa8btcDuvh5EpM/TRTUKP0OY5WZO8QmQf00GP0k2HVUQL/ACpm3F+x32XXGWfCt0P6Y4ZNU18N DO4kufU1U4df8brRjhWcMzZdJbh+NV9G0doZ3NH+Cs2q6i5oxxhhqsw19W232yVLyB/le/DKo0pU fJy6aTnuas3d9AsD6W5J6gZkxLLmN4fHFVWbHH5rW297brkPF5jXTzM/TqowrGsdohU6S+nbHM15 DwNloopsQxeiaXxYxWQFx5jld/4KCfGMbqXgy4nUVlu8srnf9yq88llWS+UR6TdBwXs7/wCgtJgu NeJzCqTF6mFmDU05MsspAY5oOy3J0PX3pVhGHsoIc2YXSMpQImwecBa3sF+dyrmqIakTRzvjmH9b CQUqOurJJTPLVSSSd9TzdMmo+RO5sq0eyFI9vePrEMq1fUasxbLWLU2Jsrhrm8gg2P7LvXwL/UQy bgPTqmyfn3EI8FqMN/k0s7x6ZGdrlarZ8VncNWpxHfUSViNeyokLi0A/lb1OoWTavSOOm0CxJ/2b 2sQ8R/hww7M4zc/HqCpxUbioZdzvyus86/UI6UZv6l4XSvrHPwCIfzZ5GbF3Y2WnRs7hqbGXAjsT cIo5ZKm7SwAe6jzY0lJPk38JpON8M3s4r9Rnodg+GCmZjrarS2wgijuAFre8YPW3J/VvOrsUykzy KV7dLmDbU6/K8kCFkUrdTnWJ5Cy5KVhex0cxuOy54tQ8KdPs3LRLI42+j0N4H8l5bz717pIM3YpB huH0h85n6hwAc8G4But12Yer2T8kZSdPJjuHingh0xiOZu4A2AF1+cWqnlirGyUrpIpxy+Nxaf8A C5Fua8wzvbFLiNbO0cMllcR/3XGORSncztm08pR+h6r8XfXehz/jtSIHiaN0hs69xZeW2tZ+qa9g adXcLjsSxF1a8RSXLj9x9k2Fro/KbGdm8lejVZ1mkq6RnQ6aWng1J8szKasiwjM1BiFXAaqlpZmy PiH9QBvZbM8p/VxyflbKVLR0uW6nzYIWxNpzsLgWvcLWW+XTTyOkaB797q6JlHi0emKJkcje9rL5 csac1M+lJOSo2CQ/VaibnF+PSZdIe9vl2bbZvYIM2/VsxmrqoZsKwFscbCD6n2uPwtfsWGNBcyRw bbbnlY7qNsct4wCO4K+k9SqSrk+Y9EvRshoPrHVZpWtq8oRumG1w7Y/K606r/VMz/nankpcGjiwG jkFj5W7wPyvFFhpN22P91hTGobJdoa5pHBC4+RM09Ij1d02+o51K6dwTQfrXYs2Qkh1QdRH919xU /Vu6pmndFFQUEZcLayy5XhSOukpZNTmbfhSqnkrHeaSAz2C6LUL/ANkX4kV0d7Yt43+qtbmqTHoc wy0dS92rRDswfsuxsC+qd1rw2nbHUYjSYi4bB80Iv/heO2FhH3kk9io+lG5DrhPlO+rL8THVNHpv qh9QLqd1RpDT1+INpGuFi2mBaP7XXVHTrxB506WZhlxjL2Jup6qU3lvuH/ldctgde+o7dlHQP1lz OFjNneVVR0x6bHDlI9LYt9Q7rXjb7PzNJTQnbyoW2C6hzH1IzDnGvmxDE6qSsrXnU6Z+5/uviGRO aL6iCVkwyzQxOY5+phHC5QySiqRZYITdtHY+V/EV1HyfSCmwnNOI4dTu9OmOZ1gFxmaOpeZMz1P6 vGMXqcSndv5sry4r4dteYo/L0XaOLp1POZBd447LvDUzgqTMT0sJcn2WW+tWecluvhGZcQooh/7b ZnaR+17L6iq8UPU3GabyqrNddVRu7OmK6mHlvc4uJF+3ZEyceUWMGw4IWlq8iI9NF+jmsy9QMczC fKxGulqXf9biV842csc4A3ceQimcxrHBjfWe5S6eMR+s8rjkzSydneGJQ6Me+l9nCx9yuQp8VxGB t4a2cMHdkjhZBJXPLSDE1w97LFNQ4O29I/2hcVJrlG3FPs5h+K4nPD6K+peDy18hWAyeoLjqqHMI /wCpI8+YH0GyoAySDzG3+Vt5p+mRY4L0Zr8Yr2AD9dM8DgF5IH+UptTNPculcSeSTe6RJAGn0g3R xRuaRfv7I8spKmzXii/RBIWBw859/bsjZVOfpAkJd7KCBrHkjdCY7OBA0uBvdZWRro08UX6Mudnl xt1MOs/7ghp9PmOY4abC+oOKTLNUPIJcHIHyvdcObYe6jm3ycniVHe/hY6vZM6U9SabG81UEtfSw iwAbq3/C2PSfVg6VU2DiCho6qUNbpZCWEWHtutM3llo9BuPYq2yPabGFt/8Ap2RSalbZweBej2D4 g/FFgvVfG6ivosOEGsWaHAbLyXi1YypxCSRxLi4myTHUSFhMgIYOyKSpjkazRCHBvfuvpanXzzwU G+EefS6JYJOS9mMKSQ3LTcfhLZM6CW5G/wALMjkk1E2s09lU8bZW/aAfdfMU2uj6jimuQHVLbl7G WedrpUbtNte7b3snMhsy9tk3y72JCy3fZUqEzRCUGRkzQP8AaeyxzGbXBB/Cyn0rDfaySYRDfSUu g0A+ob5bWaACOT7pbZgLnSOdkRgvvyqMF+OU/sztoHznF1yb3TInRPcBLt8hC2Ei10X6cEpbJRkw zR0zjomLmnsUuqmNU8ONgW+ySILHi6cIwClmki2FskR9WmTslC8ZvfU4FZHliwICvyxe9uVboUYo e+V5JdpUfO9o0f0rIdCCfZC6EWNk3CqMcTuYQWO0fARxyua8SXa4g/ae6nkX2OygpgTY/wB03Mo6 pqDNK2bS1h/2tTTU/qDcDQOEDKcNAF9kQjuQAtObl2wlQTbgENP5QnzYW2jAsebprXBpsOTyVfI5 XMpgzMs4OBs48psQETdhcnlPMGq6EwlourZBbYYJTs9zHd1bsPbG4EkuCbHAAwvsCmh5ey3CqKqA ie6EjSNvhBPGKklzm2KyWgaBvugLmg87oaMP9KWfbssd0bw+/f3XKuASnMF+FCUce7XK71dgo1vq BCztDb7bE8oRCGlQyY5LnDi6AxX3WUWbmxQaSqUR5V+yHy9QtZZVgBeyEuBBsFCUYnkm9gpd/Fzb 2KfqBNuCr0j2QlCGRu1AnhZkYAHFkAjJ4BKa22n2shUi3sFtzYFKfSAm4Nyqc8uG6ZFI25O+w7oD DfTlrvhC6EhZD5mSPPqt7Khye6EoxvKKnllP1eqwCNtnc7FCCBHtu1Tyd1laBsq07oWhAhCsxEhP AuVZbdBRimGyFzC0d7LK08qtBsUIYzXyNaQCbI4Wtdu4EuWRosN+6tjQNrIWiMjub2WRHH6SUI/l 2uiJPZHyaXBCGtICEsaTwraA7c8hGWAm+qyA7IfJ59Y+25B5WXGS0iyRTxtZMXj7idKzCwscb7H3 XwcCagfayO5WKnBkvdcXUx8gbLlZDZl7rjJnDcHle6PB5p8nHuOl4A5RPF2oHG0nurc4C4K7WeZm PUAP/ZJheWvsPwjdGY3l776AnUzIqgOc1tiOFCoyaUHTvuUxu8pubo6ePyoSDyQksJa83Qo5xAQ6 vhU46rb7qnkMbqG5QDA27bjdKe/y7nhFTvdIDtZLqGkjfdAVTPcS4vt8JkD2tmL7eo91hBj2PAub FZVhHbbdaQoyjJqBCjL33KBp2RMkaTuVtGR+gWPukSOBHsU0SNcSLhIksH8hUFgFzSAUTC5osTcp d7d1bX+vnZANa62zjuo6QsabC6TIbuUbJblAFHK57bkWKYHWCDzNleoXQDGm4Vlm2zt0pshAIVB+ kFxKAkgd3KgBICkcvmgm1lZNt0BCABsoDsoXKhvsqArqi4oHkgbFVHMGixFylGWXraCdRVel4uHC yoiOQkP2uEgUrYydDjpPYqkMgBsjLsN7coXgt5S4h5NwDsmucC25N0AkNOr3RgaDsEBeSbj+6AyB 51E8IBznKakuM+YTZCJrOIPK0Bt/dHZjGE8lY7ncFTzBtYi57KmA73Co8IHE9wpqvshV2WXWCr7m 7BQmyrXZB7LADDfuqdI07k2QPJd8JT4C4hzj6fZSy0Ml9ZGnhEBp4RiMMZZvdKbG5jbXuSqQcHnb b8oJXsaCXG/wpcAD3WPM4POkcoBdTO5hBh78rOpSC1pfu75XH6DbSfdZlMTffeyEMmXSORcpUrtd vhVLJqcBwgc7TygCDt0wJJIsPlE1/wAqFH23V2CUHfKsFLFDAQ0Im7C/ul2JsmfaAqVAPI4VXAsE LyC8pUji/wBI3QMdJKQBpNwlSP1Eb7pb5msGg/clCRrnXuRbsrRLHMI33RB1j8rCdKSSR/ZRsjj+ ytEOQbIN/dLlLZAdTNX5WKJnDnZGJbnm6yB2iNoGloF03QNICxxfujDXOs0G1+yFRHRab7oC2zbg XKLzY2ktc67hyrjla/XpsbIGUX+dGAdlQeWt0DhKA0OLnG3sEbHtkPIWqIAJHMeSSshjz5d73UZA 2UFru3dKebExsvdToDHSkizlPMA7rEc8NBEj9Lu11TXlvJH91QZbpCDyrEvvskREykho1EC6w3Yg 3zi10b7juBsrVg5LzRv3TGuuN1hsfG4XBtfsqZUN8zQ1wLgpTByTHAFNa7uuONT5btPcpoqC0XJ/ YJTL6ORa/fYow/Y7rjm17A6xPqPZNEuo2BsSlMl0ZEkl7dkkzBrjchJnkli7BwHsmNaySLVI0i44 ClMDPOaO6HzhwFjANBuwEAdikyVFQHm0Di33aEoHI6/xZV5nsuPZW2BDgWkdio+tazf/AAlAzHP5 SHyhvfdIFWD/ANJPYlKdKZLkC4+FKFjpZgTcmx9kvzTyEoQPltJq2HZLlEs8gY3+Wwd1aMjnTG4J T2TWt7rj20dU6XTHI149zsmaJID6rOPexWkmLM7ziSo6TtY7rF88tAIG/wAp0E5kcHFot+U2sbkM F7G7T8FBJE94BjZqI9kVTiMcZGshovwiixARv1Q/8u25KtMtoxTMYGHWxzT7BMjnErRa/wC6mIsM zBNFMHtJ3ZbdDS1EcrC1otIFKLY0CwJVNkAO+6BznaTcWSXSiEjV9x4CAyjUDSQ64HZYkUmh5dxf hDFXl7ZGy05BH2u9lVFVNLX3DXuHABV22B4mdpJsSrFRqF+6jJn1IDXhsAHuhnoIY3jzKloae7Cr s/oy5JdjS92n2RR1ZawAm5XETU7muPk1LnMHIITYJGxxFjyS93cdlna12aUl6OZbKLc7ohKNO64J lXHG/SZrH/qCytcoc0teJGnsFNrRpOzk2zgGwKv9YAQCFgtqBHGXva4H4beyOmxKmqNjZruBfZac Gib4vizkmyawCEJN5CXLDpaeQSOD32B3CyCJIrl23tdc3waHxuBdvwslhDrG649sgew2+5XAHvcL Pt7hAZVRGD+6xHwlm/KKSqEc2g3cUyWQvaCRpHyrQBeNwNybISSx1ihEjfU5t/yscmSTU8PBA90o lmUCBexV6xblYDKlxcRuLI/O39R2UMmZe2/Kp8hJ+FjNqWgi3He6Kc2AcHD4CGrD1jdLMrbhYxnm f9kZNlAZR/zIiD8IZMokO4KtvO5WGJmg7A/2WSHag0junRRxjFiTwlPLW2N7+6Od8gY1sID3dwUs xSvaSGFxG5AQDRKxrSe9kccoqmht+FiU0/mO0Phcy3JITqgNp3h0XqadtlqmQj5GRkt9uUh0rTwU b6cytL72HcLHoZWOne0t1NHcpRR3mAtv7IXu9NxvZPMLXEgbNKTUxtgjs12o91ErAD7FokaRZXGX SH0jUfYLsfoj4c83dea51Jl6ENLeDLsCvQdb9LXqjh9J5zn08j7X0xG67QgmcpZIw7PHIkfHs5ha mMEzm3AB+L7r0dgfgK6oYtnWLLk2Gfp5JW6mVVQ4tjt+V3DB9JTPrfLE+N0cd/uMbtVltY/1mlmh Vo8Jxk6rStLB3umPAiBMX8xvIF17C6i/THz1kiBk1NW/xlriG6YRcpE/0wuqEeV5cThjgfO2Mytp nStDwAL9+6vh/Gcvk4/08hGQvhu6PQ5JfZ0YtYv9l6P6E+CrMXWzMGIYM3E4cPqqAls7ZN9JHP8A ldsyfSYz5TY61lVmOgiwgkAysBc7+yixJOn2SeojFX6PC3kySgEyiC3ZyKWSONgcHNcR7HlbL4vo +4cIGSPzm+oe4b3i0tB+F1V1t+lfmrJmV6zF8s1kOMGjYZXxNcQ5zRubA91fHF9MwtTH2eJ4wZoy SBH7IYJi06Cb/KwIaXEQ91GyCWWqbIYvKAOrUNiLLlsRynmbLtCKnEcCrqWM7+ZJE4AD3XOUHF0z 1KcWrTCMchaS0Xt3SmHUSCDsuPo3TzSh7ag6Tyz2XMVAdQ0gcLSPPJXOqNWn0YFLIJpnOH/LHJKk mJVPqZEGOaD+FzOVst4lnTEIcMwykc98rgC2NtySVsi6D/S+wOsynT4nnuompZ5mhzKaM2Lb93H3 WkuTMpqCs1d1j/1EN2k+aOQoKwxwCMRm5HNls365/Snwr+BVOKdPMVfPXwsLhRTAHzLdgR3XRXhj 8BmbOq2ZpabNOHT5bwugmLKt87CHvsf6QV38W5brPH8qDdHjBteYpHNfqYP9xGydS1YqS4MPqHf3 W7Ku+mx0kqsGGHUlM4aWW86RwdIXe5WuLxeeCjHfDXmmGoofMxPLFe8iCrY0/wAo/wC19uFYYo5O nyZ+TtdSXB5skqXtiLQ4tf8ACuKWpLLlw1j32XszwN+Ct3WbHmYzj8BOX6U3kc7iT4C9WeLTwo9F en/SHE6qnw6HC8YEdqNjX3klf7ALl4/ttfZ2eZR9moyKtjbA4s1STD7gBdY8tRURua+SItYd7EEL Zn4FPAZhuMYHDnDPeHtmpHEugw+Zv3tvy74XqLNnhE6G9SaaowhmA0tLVBpaP0fodGffZa2JOmcZ 6hrlGiSZ0c8zTCX63D7QidhdbKbRUFRM7/c2Mral0l+mkcm9bZKnHYKfE8mxHVTh1i93sHBens8Y T0R6SmkpcSy/hlJPK5sbIWU4Lj21H4VcIxlXZhapON9GgmRtVSP0VlJPTn2kYQEukwmux2ZzaHCq iqcP6YGkn/C329Z/CD0160dPKymiwmjoZn05lpq6lYA5pLbg3HZeJPANXZL6U9bMZyJm6koxVRvd FR1tYA5shBsOdt1rYpK16Nx1F/yNdVRhs+F1Airaeqw+UG2iZpFv7rJko3U9P57p/NiPa63reJ3w VZE6/ZKrHUVBT0GOiMyUlbSNaA51tgbcgrTVU9C8wYN1KGRsThMGJ/qTTshP9W9g78FI4lOLcTa1 CumfBYRhGK5hn8rCqCWqc3ezGkrM/wBPYy+rNEMKqXVwNjBHC4uP7BbxPCp4P8r9CsgUtRi9DS1+ NyxCWomnY1zYwRewuuruoviC6V4H4hsHwLC8v4fS1RnDZ8VEDGsBvbiyYsW+0YnqVjdPs1M12Ssw YNE2TEMHr8PDhqYZ4nNDv7hcxlvpdm/ONKajCst1mJ07OXwxEgfut9vV3ovlzrB07rMNfQUkkk1O XUtSyMX1EXBBtwVx3hp6Nx9IemVHg9ZRwRV13GchoN99rn8K/wCur9mXmmnwjR9hnQzqHVTeVHlL E497XMDrH/C+sg8KfWMRCSnyhiMkbhsPJNyt02S+ruW86Z9x7LOHU0MtRhDtMkzWjS78Lk+qnUym 6WYdBWTU5lbIbaWMvb+y6WrpRItVSt9Ls0aO8N3VQVraeXJWKee42t5J2PyuG6idGc6dPY4nZhwe fD4JQNDnREgn2ut/uTM5YPnrDYK+ikppnyN1GMW1N9791i9TulOA9Usp12CYrh9PK2ojLWSviBdE 7s4HsQsTkoyqUaOqzSmt0GaLMueEXqlmTLAzJhuDyPw8tu3U03ePjZfG5U6G536gZpblzCsJkkxM yGOUEW8uxtcr9BnTzJMORclYVl/UypZQwCIyabard7LVd1w6wVfh38auJZjoqQNpGVQ8ygY2zXxH k7KwistqPo5PUzg0pezzh1U8HnUfog19VjOG1FTRtbd00TC4BdRQjz36mA6R9zSdwv0UZQzRlvrz 06pMVhgirsIxOAF0UrQ7TcbtPyFpx8fnQbDeg3WV0eBtLMNxKP8AUNjtYMJO4WYYt9xrki1LhP7d M81uYwElhuFjtgFdLE4usyJ1yPdFI9rabU0etzrALsDpn04kz3nDDsGiNn1DgNJ4JNv/AJXmcdrp n0ovdyN6V9BMzdb8xiiyzTBszuC/gr6DrH4ROo3RJ0cmYsM10ruKiAXb/dbgPDF4ZcG8OuT/ANS9 kdTjL4vNmqCB6Ba+kFfbV9Tk/r7lnEsGkZDiFK8OikBsXRu9x7ELcEv/AGXB4c2ZxdRfJqD8OXgE zF4kcvT45Q4vHQ00L9H8wcn2Xd9F9HjMBlArM2wxxEbhjbleh+hWQ63wsddKvKMFXJWZSxlnmU0R H/KkO916d6n1mZKXDqD/AE1EJZ3VLPPL99MV916cn+uSUapnNZ3PHftGnPxG/Trzr0Hw9+L0tX/H 8Fbu6SIHVGPlc34QfAFTeJPJVTjmI4ucMkil8vy2bkLbX1ekomdKswnFmMkphQPL2uG19J/8rXv9 NDqFUYX1JxrLzZS7DayWR0cXZtibFZq4OddGFnakofpidQvpIz5cy/WYlgGahLJTROkdHM22qwXl rw/eD/FOuPVSsy82aaGkpXls9WAdAtytxfi2zPiOUujGOVeHemV8RjLx/SDyvmvA1krCcA6JYVit NDGcSxLVNVz6fU51ztf2XSk8PkkR5pLJ40edx9IDLNPR3jzNUVFTb7ZGWavL3ij+nTmnothU2P4T KzFMKgBdIWG5aF6K8Z/jlzZ0t610+CYE79DhOEyB9U3TZ1SL7hYXVj6m3T/qV0exTB3YdVU+LVVO YxHJuNVrErrDFOKTmvqzgs85y+no1gYfUz1lWD9oYNJas/8AUQ0xcx1w8nlYFG81VTWTU/8ALa55 eAVzOH4BJj2LUFBF6qidwbf8rxThTo+3GTq2YFNQ0s875DM4v7XCGRsbnua+7rcEbLcP4Xvp4ZGo un1FiOb8KZiOIVkbZdLttIsu08V+n10TxeGSH/TYptYsXQPIP+ViO1fyOEsrukjQ0WGG4DjoHBO6 GOq8x+knUTwBcErcZB9Pbpf0/wCpNIK3DRXZcq2kH9aRZj+wuu5YfAh0ThcZ25TpWOAu1/8AtHuu zhjSv9OXyN3EVyaFHeex2nyXsHNyFTA6aZodd1u1iFu36oeAXpriOFjE8Kw1r5aZwe+FltL2dxcf C+pyV4NOh+K4DSVlHk+leC0ankk3cOb3+VjZBK0zDzyTpo0YPoWu3cJmsI3OkkJJw00cro4onzh2 1wF+g6fwtdK58Mkw12T8L8l7CwtbEA4A7XXSmSfpuZCy71BqsYrZBX4WX6qfDLWaw82JUcYegs8r po0vQ4FXMdY0tS1vIAYbFSPDA2cR+TJ5hNtHlm91v2x6n6MZPx+iytiGB4NFXSgMigdTtLiPzZcP 1V8LfTR2GMzFSZcw/DJsPcKmWSKIAPYNyCFIwTaT9l+TVv8ADRgMs4u0gx4ZXFjtv+S6x/wubGSs x0+H/qzl+sFOBu8wkf8Ahb/co5QyTmnL2HYpRZdoJKOaIGJz6ZouPfhZsuSslZjbWUDcJw+U058u aJsbRoPsbJshdNGHqMj5gfnOqdLpyHh8MwNix21lyEFCZobB4G3K9f8A1O/D3lnpHmvB8by/EaOX EifMpwLM/IXjvDHve17n+kN4+Vyy41F/Xo9mmzeWPPYNHh1TU1rcNo4HVNRK7SABe5XasHhJ6rVu Hsq25Jr54XN1B0cZ4Xo36XvSLBc+dQa/GsYp2Vn6EaoongEar7FbNernVDD+juBsxGopgaMEMLGN sP8ACxCLbOOpyyxq7pGhTHujeeMoxuixHLWIUjeCXRGzf8LJwDoHn7F8ObV4flasrKZ52nbES38X W93LOJ5c68ZFmnfh0LqCsiLX6mAuAPzZcd0Ir8JkwzFsuYdhraaiwWpNMxzmg+aP91l61GO1uujh HUytX7NLWFeFXqxWxPqGZTq4YgL6pWEB3911pnTIeK5SxCSlzJhMuGVLftbIzTqPwv0GM6hUlP1E ZkuupYjVzQmendE27dA51X4K82fUx6X5breg2J5imwyFuKUbm+XUMYA4XVUYt7Wi/Il23waZ4Z2v wyVttAZ7919j0U6YO6k56wHAofTJiErW35sCV8bQ0rayge1zrEf5XfngwrWYV4gMozOIIjqWxgLx zSi6PpwqSs3KdHeiGUfDx0/iipKOESwQh9VWOYC9xA339l8B088bmQOofUPHcpVdZBhrqaTy6X9S 4NFQ0bHc/K9D5oiZW5XxBsjAWPpXktcLj7SvzqZ8pMT/APVPMNRhkz4qiPEZGxyRE3b6zxZe3BBT ifFz75ZlFOje1lvqVguC9TTlWmrqfEW4iDNTCksfK/6XEL6vqX1BqMiSUBhp3VEMzwyRwbfStaf0 ujjFb11r58eq31UjKVwjE19QdbkXWxnxA9WsJ6M5KkzBi1AMRgbIB5ZANvndYlFRnVHRRnjxu2fd RyR4jh1NWyQtmJa2Rtm7tv7LqbxgTxjw3ZudLHqElKWhrhfnhecclfUSq+sfVbBct5ToYqCgllEc jZrFzxfe3svSfi6wh+L+HrNdPrs9tGX/AJIWtsoSVqjO6O1tHyf0/MQrsQ8N+B/qnhzIdUMQbwAO wXwPVjDck0vjUyxU5u/Sxukph+m861nyG+m/7hfZ/TurIpPDzhtJG8F1PM9jmey8cfUmxKqw3xK4 dJ5hhc2kjfTSk2AIPY+916sONZc8ozdI5zko44yNsIGmncWBnl6f5enjjZaU8w9ej4bvGJmzNL8L GJVZrXtfTv8A9uo7D2W3DoJUYhiHRzK0+KVBqayWijc+R3J22Wo3xF9G8T6x+N7NWW8BiZU1jqiz tB2B7kppIKU5QbNZpK4z9HpnAPqEdQfEtPS5d6ZZKkwrFTM11RWzOL2RxX3N7bbL3lRYg/K+T21e Z6+PXT0rX1dRI6zA4N9X7XXVHh86FZZ8KfS5v6l1NS1bYRJiWJSkC5tuL+y19ePLxj471ilqMsZI NWMq0chbPV0bXEVJ43I/pXKOJZJNQ6PNPI4zVvlnU/VTEMjdUfGJBJhb4aTLFViYdUyutodvuVt3 HRXpXXZD/S02HYNNQGjEYqNDL/b91/dfn4wLLNdmDMdJhlE2Z9fPIGtjF2vuV7vo/Aj4j6LJENVR ZwmjoXweY3D/ANUdYFr2K3qXvmqVHugtuOrPHHiFy5huS+tWZMKwt7JqCnqXCN0Ru23wviIowyXU Ru7i65HOmXcWwTN9fhmMan4pFI5sznHcuHK4yEvfREyD+bE7SLry5Y06Pdg/ijuTwd5Zpc4+IfLO EV8QlgqKlurUL8G636Zv15d6f4i3DIbSUtGWwxRj2FgAFoj8DOJU+EeJDLVVWG0bKhtzfhb485Vm IwZWqqvBo4Z6xsRlYyT7X2F7fuuEF9kNQ+GzqrwuZmzhmXL9cc2YcaIxynyHvYQ6Rt+67Uw3KWE4 ZjtZi1HRNgraoWmkaLa/yutfDz1czD1VpaqpxDLpweip5DD5r/SXvHNh7Lt0VUcuIPgjqWOliAL4 WuBc0e5C9OZ1N0qPlYYqUE32ebsdy91Tb4iKOspJicmlw82G9gRddheKOgpq7oDm9tTBHO0Ub3NE guGkb3H4Xz3VrqfnLBuqWE4Fl3C3VWHvLTVTadmtPJuvsfEDiOHUfRDMzsWnip6aTD3sJkNruc2w A+brtXONszFq5q7o6D+mThdPD0Xq62GINM9U4aw22qxXSn1aM1V0mP5Ny5TzSNpi7zZmRvIDt/6g u5/pfZmoazofVYRDUsfU0ddKfL1erQTsupvqk9LcbmxTB8/0jH1mG07P000UYJ8r2cVv6/Il+GJy TxRbPaXhkpqGDoVlV2HwxwRPomuc2MbarWP5XweQem2e6brriGYsTrXxZdOoRUuvY+2y5/wcYtSY r4eMrRw1TJpI6YMl0vBLXX+FwmHzdUq3rzW0fnthyTTu1tmcLGQH+kLjj7mjpk+0YOPR3RnTHpMt 4fHURRGofJK2MM9rnlfBeIDozg3WPKdLTYnXNwmpY9rmVZdYAd278r7rMldg02KYdhdfVsjrJzqg iJsXkLoPx44FmLMXTvD6DLEFTNXNqA5xpXFrmAfIXnim2kdJKP2k+ju/p5kOg6eZLjwnB5pKqKGD TG+R+rU6x49hfstEXiQnxaPrZmI4hrp8RpsRk0hhs5pDiQt5/QeKtpOlGXoMUEja6Kla2fzTd2oD e5WnvxM5SrOqHi+zRh2CUxq55q0RBkY5N7XX0NKlFzUjhkSksdG07wQ4vXY94ccq1mJVDqmsfEdU jzckDYXWvr6huIxy+K+nmedTKFkJAtw4ELY54b+neI9H+lWF4LitQwNp4NegbCLbe5WpXx19VsAz T1+ravB64VZgmENTMw3aLHex7rjipSkzrlduMF6NzPTKthzD0rwKZrHRxVOHxjST7tF1o08YFPJg XiJzJQwzPdFS1R8txduBdbifCL1fy91U6JYFJglUyWTDqVlLUQ3u9rmttuOd7Lwf43/B/j9T1hdn LDoDV4fjlewSAbeWSfZNOuZKzGokt8b6PVv03uo+NZ56LfosWjkLMNeIoKh//uN9v2XpfP1dX4Xk nGqzDIjPiMVNI+CMcucBsF8n0Q6fYb0U6RYZhkcbYG0lIZqmQDdzraiT+AuR6VdX8B6yYHVYhgM7 Z6aCd9M+531A2K8bvc3+H0Ht21+ngjwN4/ieK+JnFq3HNQxWuZN53m/c11/tK2L5vjwJuFSTZg/T tw+AanPqiAwfJXn/ACf4d58n+KvEs3UVP5WBVdMX9iBKeV994nOnmMdU+nMuXsGAE1VM0SOdIWBr L7m69c9sskdro8eNvHjlxZ5CyBikWJ+M2JuXJp3ZdZIXxtjcfKd8gcWXu7qb1BpumeTavMNVC6eC nLdTW+xNrr4Tof4bsD6NYZTPa0VmLtjDX1jxuPcD4R+LPB2430BzdF5rYyyifIx2q24HC7arJjzy ioelV/pzwKeKMnI7Nynmmgzll2ixnDZ2VFJVxh7HMcHAXHGy1MfVdpafDeuGHPYNElVStc5o727r 3B9O7Fqev8NeBsiqRNLHLI2RhcC5rr+3bheP/qEZPk6s+LXLuXIaiFklRAyla8vHoBPJWdJj/wB2 30bz5V41Nnfv0pRHD0PrmPP82WsLwCd9Nl1V9Xlnn1+UnNtop43CT8m5C9k9GumGVvCv0ep4JquO Cnw2DzayulI9RtuVqe8dviqg8QPUKpZgw0Zeoj5cLzzKRtqK3p5KGoeT0csv2xqC7PJ2IVpp5AG/ 1FfR9LCR1NwJ44FVG6//AOEF8h+mdVSvfqu0cBfS9OMSgo89YNJWP/TQMnYHyHtvyvFmnvm2faxJ Rikz9JWT3MnyZgzgbRuo4/jloXWvTnCunNP1SzDT5aqWS5mpmiSubG4lo1f4X0ORsz5el6X4I+TG aY0jqFjnSOmDbgM3Xibwj9WMrYd4tuoeEsxeLyKmZzaSpc7aYX2F1iCck6Pn5mnNJqz1B4maFkmO ZALReqkxRrG257FdtZ7zQ3I2RcXx6SMzDC6N9Q6Mcu0tvZfG9Q5MnYrmvAavFczUVHPhshkip31D Bqd77lch1FxnLWZOn+NYfNmDDxTVlK9hf+obs0jfgrbuSimN1bkkaqfEF9UDOXVPLs+D4HQtyzSy l0chjcXPkbxz8rqjwMV0mKeI/KDZHuklkrjPKe5/K698RGEYDlTqVLhWX6tlZh8JIMrXXbck9139 9NHCsp0PXaHFscxSCnnpIjJCJHho4+V6M7jFVE1poWt7NvHXmSKLo5mxzxdgw+Xt/wBOy82/TFr3 1PSjF4JH6nR1r3Afld9Zt6y9NcRyxiEdfmfDTQzxOikY+du4IIIstYHRzxgUXhZ6647h8dQ3EckV dU7SIPVoYTsR8hMUXPDKKPJOX+9cHbP1WOnOIVmacvYvQUb6gVrBTyaWk2N//wAi6Yy79MTOmM5M OO18kMMcsJmZC0esC1wthEXit8P3WLDaWprszYc7RaQR1ztBjd/+EuuPE19Qvp7kTI9XguUcRjxr FZYTBFJSn+XGLWvddo5XsWNxOSi4ZHKL4NOOPZVny7myuwKpkEU1LI6PX72Nlx0EMrcwUcEkhlaJ mgW/Ky8WrajNeYqnE6icmaomMj3k+5usKucMKxKGaOUSvicH7HuCvn5ltbSPu4m3FNn6NvDVFFTd CcothtobQs2HY24XQPWjxlZtyp1C/wBPZaydJWzQP0PilYS959xbsutPBt9RnIdN06w3LWba5uE1 tGwRte4emw7kldwYt46PD5hWYnYw/Faerr9Gg1kcAc+3sFdKkuZRs+frXKVKLo6w6x9Wus+dcuYV TY5lCPAMNrK2JpkZcuHqH9l7afh9VRdOW00MjhVw0FgW8lwYvBvVL6nfTvFMy4RQYXSS1mDQ1Aln mmbYbbggLs7EPqo9G6OheJKiolm02EcTA4Hb3XpzZU1GMVVHlw4pXOU3bZ5Vg+o3njo/U5hwGbCZ cRZ+olZFU1l9UZuRYfC9m/T0xnFM1dI6rH8U1unxStdUhz+4PK1Q+Jnr1gXVHqjPmDAsMFLhJfqN O0WD97kn8r2R4ePqo9POnnTzDMu4rlusoRQx6GmkaCHfNkzzi19ezpgwNU5ej7/6hHUnqF0mz9hW Ysv4hUUOCtpxGfKvbX7my536enXzM/XnFsdmzFiTqoUMYLGk8kn/APKvNvi7+pFk/rPkKsy/l7BZ /MqGFrZqpouwnuF5P8NnilzR4a86wYxhcvmUUvpq6R24mZ/8qSyx8ailyRaefleRm2Dx19KsSzfi uWMTwihkr8QEwjbExt9JvySu+sEZiuE9FjBijGx4nBQ+W9gPB02Xhl/1kMuvpYnHKU89S0XN3AAG 3ZdbdXfq7YpnfLlRhGBZYGDCYaXTyTa3Ef8AhXc5QjH8OS08lklOuzYr4ZcBr8vZLMNVE6GOSZ8w u2wNz2XifxyZn6o9IutNbnjKb3UNJ5IjFS4+ktAtaxXXmRfrA5lyrgNHQVuXKTEjTxiO5JaTb5C6 p8TPj+zH4lcFbgzsIhwuiJ30b7fldMOSKyuc+jpLTz2RjH0dT9bPEf1B65sp25txU1cdOfQxosLr rAStfohcS58g/ss59GxsTC5xJA3twSsGWMRvE+kkt4Xkz5d8qXR9bFjUVZ6a+ndUU+XfEjgElXUx wfzNN3mwPwt2HWDCKnNHTjHMOw+L9RVVlM6KINPcjlfm0p8TxPDK+HFMPnmppo3B7JYSQ5pXr3p/ 9UXqZkzK9PhNRor54W6WVE+5I43XDH/I56mLnHajZ74ROiWK9Ecl1lHjL2urKiQyhzQLNB7LApMZ wXHvFFTswipZXVcFKW1rmPuIyP8A8a1uYr9VzrHiVJUUsRw+CCZhY57ILvbcch3Zed8reJHP+Ss4 VOYsFx6ejxaolMss976ieQb9l7+rbfLPlLTy4ilwjeH4i4IIsw5TxSqljphSVjfLJO7yf/C+z65g VfRnMAuJGy0DySHW2LeVogz54vOq3USphkx7Ms9a6Eh0YFg1p+AFnYx4yureN5ZGAVOYakUEkflP Go3c23Czjp02+j0PTyakv06/zZVB9VXMhb6WTuY3e55K4J036L9LWHd8Ugdp97LHZiz3SmN4JOok uJ3JQ4jAyVzZWPLvdizrcvmao9umxeGNM3R+BjxyZQ6nZSwzJ2IVDMJxmhgbDH+ocGtlA22K7jzd 4UMj566p0ueMRip6yojAJpxby5COHEdyvz/4dW1mD1EdVhkstNMDcGM2IX3dL4i+qeGxCmgzni9P HbTZtS4WH5XnxSa4s5Z9N5OaN4vVSuypm6socj0GLYVhmI0U0crxLoGhjf6R8ldw1T8OnwV1LNV0 0lO6Dyj/ADBYi1j3X5rsWzpmXFcUdilVjVbUYg7d1Qah2s/k3XIs64Z/po2sGbcWbG0WDDUvt/3W 5yimtrMeLI4s7g8RdPg3T3xC4tBQVLaiho8QNQHNIIHquQtsnhv8WHT3q90toaaLGYaKuhpW01TB M8NLSBYkLQzV4pV4pPNWYi+SrnmN3yPN3E+91eHT1+HSF2GV9RRaxuI3uZ/2Xp1Wo+RJUuiYNK8W Ok+Tfh0vy10p6OZkxrHKDNmHCoriXzGaqZt3915m8aniPyD1szXlvp3h+OxPwwVQfiOIMd/LY2/Y 91quqMYxPyy6fEamYdx5pKwBVyVBMgkkEg/qPf8Adco5Xu3zPNLRTUNl0uzf10Dxnoz0oy6zDcvZ wwsloDZHzVTA95t7JfX/ABXo5n7I+JuxzG8HrHticWSMma6QO7WWgtlXVyPdL+ola88uY8goZcVq vJcw19Vbu1zzZc5Onuiz0R0/0WNnb2Btykeun6asnDMqNqtL5XEFpYHWHK3R5P8AE30YyPknBcJp s2YdS0FLTNZEwSCwAHGy/PtDKxkN5w6WNx7GxWU4F0OuKaTS3hrzcBaUoTVSPT4dsfqe6vqOdWun XULM9HiWT66KtrHN01c0fEm+3/ZYHQD6nGNdFsn0+Wzhra6hp26YhJvp+B7LxFEx9XBqIJtyUwQR zRNFmgjm/K7Z86nFQXo5YNN40z0B4oPF/i/iYzJTVs1DHhsVMywjj7j3K8+Rvlro5ZZHX9SOCnDZ fSbN4Nk+VsdK3TELBeKU3JUerHijjMR9JK4lsTiY7XK708Jvi7zJ4ac0tkjllqsElcBPSOJIt8Bd J+eXxPaw6C4W2WIXPpYd3MeP6g4crCrs6SW5Ubj5/q49NYsHbPFR1dXVlgP6drNOl3cXK8GeKbxn 4t19zvHi0IqMMwmBvlw0TZCQB7kDuvMAgiqdLoLNPcBZDWujYQbF3yvVDNGHKR4JaVSabdo91eG/ 6peN9I8sU+XswYZ/qGgpxpilkkIkY32+VzniA+q7XdRcoTYHlDCZcBkqAWzVDn+rSRuBZa+hQCcX cwAnvfhY8mHVDT6AS33W1mje5rk6PSxkqvgyMVxuqqqv9W6d3nl/mB999XvdevfDj9TnPHR/DqfB 8eMmYsJgs1gkdd7Wjtcrxg5jmMc14ub8oWQO/pIP5Xny5nklZ1jhio7aO/8AxUeLGu8R3UA4+KL+ GxxBopw02kjtxuF2x0W+qJnzpllWHBMQacZbTt0QyzEEho4B7rxXE79HIXPaHE9kt1i8ua4b729l y3sjwQqj1d18+ob1D68Ye3Dal8WFYWw3EFGLF593FfO9IvHX1N6MRfp8JxR8lDe4pqj1M/svPxqG eX6APkrHfI9wBvqC6+WVVfByWlx3bR7vZ9XrqoYC3+HYY+S1hIYuD+F5o60eI3OHXDFnYhmjFH1b 9WqKnGzI/wABdTshcd/tameWJBbkjuVFk2oq0uNO6PUPTL6jHVfphlaly/Q1NPNhdM0siZIy5btb ldJZ86j4v1EzHW45jNQ+WrrX63uLr/sF8foD2Bjth7hBLTy7BhNhxdajl2tyXZt6eLadHqbwbeLL A/DZU10+I4U6prZHhzJg25A9l3P4jPqlV/VjKdTlvLOFjCoaoaJapxuXD2C18Ruft50bJPlwRxuh hfyGE8LzxlKE998m8uBZIbDmK+c4jJIJ3nzH+pz+5Kw4i0VBNwQG2CXPPoYACHE9wpCzh3ddZ5XN 2zphxeOO1F4PjeL4TUOkw+eSmqWO1NljNnD8L76l8TnVagoXUUecsTipiNBjMx3C+HdzcbHuQl+W wHURrHe65ruzbipdma7POYWyyVTMbro5Xu1udFO4Eu9+UmozvjmJ1Mc9VjNVPOz7ZJpXEt/usOSO K+prQ34WKaSM6i42B9l2WWSdnFYY9UfRjqTmr7RmCvsBa8U7gLfsVxeJY/jGLM0VdfU1gvcCeRzv +5XEshdDJ6TdqyamaaZrA0aLIsslyieGN3QUOL12HWMNVPCb3/lyEWKypsz4liUWmqxermaOGSyu cP8AuuPbG4g6tyeSoKRt+LhXz5GqsrwxfNACaQzh3myCx/5jTYp81b6C0Vs5J51E7qCNwGkbBW+M vFixrrLz3yb2LoWajyND2uc8Hk3WVJBSyyNIeWvcLkH3QU1KXxuGnSD2ROw+UnVwey6PIyqC/C6f TG53mwyFnGpruU+amFQ5phZaK3DjumQF8cWg8+5WU2IeWDezj7LDm2aWOK9GNT4ZJquIy0AdnXWR GwuY4SNBbe1jysiKWRrQA+yF8Re6991nyOqMvDBu6OMqaJsDSWwkntYqo45adjXtYC09nDdcmWOG xNwrLWuba1rLO+S6NvFFowDC6ucBK3QBuPlZz3j9OI7AtHYpUkbnH0khZ1LDE6MBwu5N19s2oqKp HFvo4Kpt/sA7BLNJDMLRs0ni9rLPqaXypC1os090tsRiFuflS2VxRx8dFJTSfebHvdZMlJ58dmuY XDu5Oexz2pfliIEG4v7K2Tavwxo6SdgcJA1g92nlFS1D6V9mFrmH7roZYpHerU4hMDGuj2bY91rk OEX6C8ppmEjZNB9gUdQHl4eXhyRHSFspdqNvZZbYtRueEpFUUY1RC2p0uHoeNgQp+lkYzWx3mSju VmiMWIA2UYPK34Vv8LtTOcyb1kz1kCrE2CY1W4Y9o2MEhA/sF2JJ41uttXA6KqzrV1LCNOmU329l 01U1oa5ocLfhSWrjcwED1e5XSE9js4TwKSOWq8YxPHK+orqomaed2uV7u591wWJy1NbiDCLiNnYb LIp8UqI97CxT2Tguc88lJ5nLs1DDCHSMMOa9obodrHdFLV1LA1o9FuFmfqGaDZo27rCkqfMfYt29 1hOjtQt9L5j/AD5Dd/usSsjqC5j4ySByAs2R7i0i+yQ6R0TTYrLZKAdM0tOsEOskU1LpkMjH3B5A TQ1053Iun01C+K7rlSzNGGamZ8vkjZnYd1kRiSB2zim0lLrxAu2BaOCjdKBK8DurdihMsJeC4hY4 iLTxcJmuSnJL5RIDuB7JkRdO0loQWYz2NI3asU0bdd2myznuDTzYqmgOubBZBhP/AJf2N9XdDG+S 5LvTf2XIeUCLoHxhwtbhWyUYbmOeLarp9PIYALm5CtrA26vb2UsJUR858wvay5srirqi+7bNHfuj ieASTZFExzi522hVBkvHICQyzjyflMYC07FE6nswG1kDCGnlUpkk+cyzuFgxtLKh0cQdGQfuC5Bg DQDdZ0TqcR3t6z7K2DAZC8kFzyT8pghc83vdPdIxjt97qi5wk9JGkqChL4R3Cx5oLcBZj3gbJb3B zblAYLqZr2i4vdY7qNsdw0WHyuScRbZJkIAO2yWSjBFOz/baysRANWQLdhdQjtZSydGN5YI34UEQ aNtgi0P1WdwjjjcHWJ2VAvyCbhU1nlnhZOk3QuYWC5F1pEEOjaeQETI9J24RtbrHCsnRuFkpTmi1 rBLAEW1rXTC42uqMjbAd/dWyCn04G9uUos07O7prnm1ygddzgLKCgdACHyAd9IT3t02HdUA4C6oo R5djcbI2N33TRuFQAO5RuylsA+EW1+yUfTuEbHm9yEs0mMs0j5VWDhurc+4O1koF2rfhQrYYiFkD 4QeeU07Ab8qWNkM9mN5FjsiAIO2yaSQpa/ZDNA2c+1zdW2HTwOU4R2FyLKi/ewQ0lRTo9DfdAdm8 bITL6rE7qzcjdA2Rhvt2T4tDb6jv2WLcjhMAcY7k2CEHSOjdH8rClFztwid9u3CA7kIBTDc2H900 NB2J3VadrD+yvy7C7ri6Ao/9lY2QFhBtyoHG9rIRjA0EqpCAFYPuqIugLadkTH6jvsAhAsFLXCFD IBOx2QOaeyotNtuEZ3aAgF/90TOVPdQAOQBjdEDbhVaw2Vgi3sgL2/dQbFFa4VWbe3KAKxI2UbG8 7EbKNdbdFC8gG+6AsM0RkAcJLyS1ZJeHNN0okjYDZC0JaT7og3WLhHoF/ZF9o2QoLXDg7InDcILi 4uFbnh3CEIWaCh2Kpj9RIPKImyEFll0ErSz5Ce4jslPDibHhAIiu6TT2Kuqb5b2sA5WXGGMttvyl yNMk4d7fCATNTeU0SAoWyF1ieVkzytk9F90DYAwjugI2QBRxu02Cos0k+yoeoEICtIsFAAy4tyoL hS+6ALyoS2+n1KnxtB9PJVEC4JVus61rhAKIbEdRFyr8vW7UNroyweysg6dihKKturaNfCmk352R t9A9KFAcAHW7pTidVrJpju66p4J4QEZdwIsr4Cpt/wAItVx7oCwQVb9mbDdLLiBwr8wgcXQEieSb P3Punn37LB893mWATWzn7HCxQDjG6R2q+loTPT7XStZc2w2RgWAF0B2ZiwGGYxUDfTFKWkexusrz HykPcLB24RZ/pP0uasUikOi9S42990kVHnNYB9oFgvgaV7sSPu6hKMqRcxB2C4ypADlypYC0k7Lj pmDVYbr3RZ45HFvPrumGPYuPYK54rO4VlwMdiuqPOzj3yukpnl122OyPBZG6D6xe/CuWIObbhpWI 2nEVQPL4v2K1RDn3OD3XBULBe6x2sbIz0uId7I4nPAs5uyIqD0DVq4HshlF27KPeC3ZCSWtUKVGS 0enZW6+nflCCrc8OAsEANiSLdkRfp3KoO22SJZiL33+AtIGTHMHg72Qxu1k3FrLHpiyQuc4loHZW JoGwvlNR5ZHDT3W0ZY8MGo+vSlsB1kkl1uy4qOVlQS+Wo2v6WtKc/GXU40Nh1N7Hkla2sxuRnioL nkEafyjElu+64eoxPzIw9zCx1++ySa213Nc53xdXaxuRzwnDuVNYcDZcPDXM0gyOt3sjdWwOcHRS O1Hte6OMvw2uTlDNp2BUFRc7XXFzYg2fTHE4CQfdccrIZXU9JC5lW90WvZrwEcJJ9EtIzjI5jgSL BY0tfpfYgrjIat0TZCyoNW2/pAG6EY3Kw6KikfE/luttrqU12LOdgrLu9Q0t907zByN/wuMppRPD qkIAd2uswTRxQgA9uVCmQHgDcq9bC0kmxC46WtaGXvc+yyKQzPkaQzU32VoAGqaXWDrkdk6Z8dOW BxBc8bBKq3QRTBz2+UfYtTqLBqzGX6qGklqZGnZsbC5aUZfhhtCZyBuX2d7IdZt9yzK/KGZnkxHA qlzxxaI3XC4hheL4LGRXYXWU7rbPfG4NC6eOVGNyMz9SBsefyrZUB9xe6XlfLGK5pp5G4fSvralv /txi5/wuQqelufcLjE8uW8QijtcfySdllRvgOaXZgS1QguLEn2CVLWNkjuGFqwo466SsfDUQSQzt 5ZI3SQuwcn9D8+5wa1+D4FU1UZ3EgjOk/utxxyk+DEssYds+GosRZGSHutfhZIs838xpub27r7bO Ph26mZBhOI4xlKo/RD1F7WEgD3XWj5oqqoFRCDC5hs+LuElCUeyxyRn/ABOYbIHSAFACHVRIBsAh fVsqHsbG31u7JsdPM2YWLWu+Vg0DJUDvdv5Qib5SKuaokmLSxpA2uEh8xgF5Bb4UoGcZrndHrBXF fq9crQ3a/us1lgbOfZ1r2SmXhGVqBCqSYBoFtuySJmdjxzco4pPONtOkDue6UzVqhwla229yVUh7 hYtVSyOhvG9pf7XSNNTFHvz79lVyTgyHSHUdrflJMUgeXg7LHcKmc7vj0299099O8UovNpctUQF0 ji/m/uslkjgRbZcc107TeNzJGjkk2WZT1DalpA2eOWptf4SzJa/Vc33Ujka7Z7rflYb5tLrN2Psk 1VRJI1jBHd19yFkGbNIGnY39rITJKxv23BWNGRGW67kd7IpanQ86SQ08XCU30hwZLai/IsU1koce Vx19XqMod+EYljOnS46hzZNkvwpyXm6CmNqQBd11xb66Nj2tdK0X7FZtPWxCPZokN7AhKoqGSRuM ZkF7JLA5sev+o8Kq3EvJnjh02DgvtumHSjG+qOaqPCMNp3SvmcPtHAVSvkxOVHwMkb43iVxBd7FK NT502h9owe4K3CdN/pmZCp8sU781wyTYkYwXuY6wbsuG6ifSz6e4rhctbliumhnjBfoLg5rvjZem MIyXJ4nqVHg1L+imH36we6W3S8SEuIvwWnhbfOgXgH6YYjk11PmOhFdicchZIGu0uavsMR+nj0Sq pJ6CkpxR1mn/AJfmAub82K28cU9rM/KTVo0pREhpLnHSO5Cxoa6IueNVj2sVtzyZ9L/J2B9Q6yfG p5cRwWRmqGP7Rf2XTXjh8D+ROjlJgGNZZbNTvqasMnilddpaSOP2V8CbqLKtUn2jXozEjACXk6e1 wVm0s7KtvmDXsbelbm8m+B/pLmLorRVVTl+OeqqaNrxUNFnhxH/yus/DX9P/AAalzvitdmTDr4PT yE0sEg2eL7XuuXjS/wCiy1O11+mrCQtpZi6drmN76mHdME8Erg+ncC3uAt62cfBx0az9QVWFuy5R xVIZbzaawdGffZakPFj4UcZ8M2f3wNa6qwKrcXUk7QSLex+VVh3fx7Mx1f2pnTr5YZh6gSRykMjj dIdIc1o7kLu7ob4Nc7eISirKnCmiigpxcSuv618L1r6EZ18PmLihzFGZKfVYTtBLT8XXCndHreWK dM+XdaIBzXek7XKTK91NI2Rjb35S6ad1VE27fTa4AWfR4fLXuuACwHuiVnUxW0pq36hCZDzYLMrs n5imo/1UOXq8wgXbIyF2kj3XtbwQeDYdXMQGO46DFglI4egDeU+y2V1+G9OuntDQ4HUUWGUsYDYo oZ2N1O7d+brpBO6PNnzLEfnlw2pmjnfHUsfTzDYtkFiuaw7L+KYySzDKOStcf/psJ/7La94w/p/Y N1NipczZHoIqTF2yNdJSQNAjmYeSu4/D94X8ndAchx1FdQU02JmHzaqeoYCGG24F132xo8/yrRo1 x/LWP5Y2xHC56dh7vjIXG0TYxIJmH1u5aVv0xHI/S7xJ5WraT+FUFREC6Hzoo2h7HfFlqd69eEKv 6P8AXijypSSOrKHFJx+lmI2a1x4P4XZ4lK0lTRiGrTdyfB0rl3IGZs++Z/pzCJcSkj2cIm3ssDHM mZnyZiApsw4NPQSnhr2kLeb4aPDVlroB06gMkEM2IPgE9XUytB03FyN/ZeOvETj+XPEt1+wzLOXW sfRsqRBNVMjADiDYgf2WMWPddLo6ZNXFSo8J5R6QZv6iyacu4JU1/e8bLgfujzZ0dzz099WYcuVe GQE2E8sZDT+63q5Wydknwz9PYqWCmho4YYw6SXSC+R3yfylVMWSfE3kGpoZYoMRppWuYWOb6oXdj 8JDa/wCS4PPk1EoSpGj3p/0szF1DqjR4Bhs2JVdr6GNuuymeB/rFMwvdlqan+D2W3LoD4f8AK/Ra hkpsOggmxQEiScC7gOwuVwGK+KZtB1zj6dtwp5ke7SKl7Tpd+LKqClJqCsk9bsinPizSx1C6TZu6 YYiaLH8MnpXkFwe9hDXfuuwOlXg9z91gyucdwM+XSi9muH3FbZ/GT0+y5m7onmCsxijhE9DTumgn DBrDgNhf2K8k+Anxd0eVH0eQsSoGxUk0pbFUgW0m+11qUIyx74oY9W7cWa9Op/S/NXSvHXYfmWhm pZGut5jgQ13yFwVHSsqNIhcZHngELfV4pvDllzxB9PKplXTRNxGKJ0tNVsaA64FwLrVd4X+gNLj/ AIgosr4hGJaelqHNkub3s5Yjh3Q8i9HeOpe7bI+Z6Y+CXqT1mw41+B4cY4ANnzHQD/dMwPwJdUsQ ztLlqeibTVEZs954t7rdli9VgPQ7p1U1jKdtNhmGwaiyJti63/crwR0j8ecOM+IuqdiVP5GDVs4p 45pALtBNhdSEHKLlXCOMtQ1NRPH3Wvwa598PUlPLjYbVUdRbRJGSQCey+26ffTq6hdSstMx2KP8A TU0zdUTb/ctwfVPpVl7rVlP+FY3CJ6OW0kcjPuHcEFLxPEcL6GdLWy7/AMNwmmEcbXcuAFgs7oyS pcm3nnF89GqzL/0qOo+LMINVDRNadzK+1/wvpKL6RmdJyRU47SQgd+SV7t8LXWXEurwzFV1v/LFR qp9H2sYeAuY6w5j6gZTzJSYlgNCK/L0ERNXFtqPz7rcYyc9nCOM87jDf2jXZV/Scz9FWeVTYpTTw k2DnOsF1Z1d8APUjo9SmrxGnjloPMa39ZTvD2gH4C25dHvEDg3V+qqKGkgkpa+mH81rjwV2PmHLt FmbDJMPxKnZV00nLZQCL/hJycJbZIKbnHdE1LYT9KTNOZck0eN0GYKVlVU0/ntjnBHa4C6i6DeEC q6ndW8QyTi1cyjrMPkLJdJs11vZbwcFwP+BYP+jD9bWMMbANg1vYBaYepfUHHOivipzFU4bI6Oqp 8QdMHN/9xt72K6YoxyqX9BZZxkovtn0HiC+mLm7pZgtRj+W6huLUUALpIIiS8Ad7LxZLJNT1D6ee B9PVxGz2OFjdfol6MZ6b1g6U4Nj1VTtjdX0/86BwvvwQtPv1H+n2F9O/EDWnCKZtNDPGJixgs253 THi8tw9o3HUOE0n0zzPHJ58Wo/uoyOKSpaY26y0f2SaTWXNaW6WPXc3h56XU2feouFYPUf8ALqJW tJ97ledQSfJ9VtVaOwfCx4Msb8QWIipmifRYG0jzJ3NsD+F2D4ovppVnSzA/49lR0lfTxtJmYy7n A+9ltHynlTDOkHT6DDsHoAIKKEExwt9UhA3PyVw/S/qlT9W4cWikwWqoYKaQwujrm/f+AeykG7s+ Zl1G1pGuzwTeCzJHXDK1TW5jrZJsQpneXNSMGl0Z/C9L1X0wejI9LmTwHcNLpAF9FSdMoejniaoq vLcjMPw3MbC6roWCzbjuAu6OqeTsWzZT0rcJrP0klPIH3J2cO911nxJbXwcJZXKLtco12eJ/6XdH lPKGIZnyVir5W0bDJJRvbclg5IK43wG+FXpz1jy/VtzF6sZpnFroid3C/b+y2Adcsx02QegeOvxu tghkNG6JztQ9RI7LXh4AMwvd4jYG0s7mYdKHnS07G97bf2XZJ5MTb7NYcjUtqPS/VT6dnSjAMi5i xZtL5b6Wkklje7bSQCV4v8IHgpm6645PUyvdTZepJ3CWo7ubq2DVs+8ZNVJR+HvNT4pPLc6DTzyD sQvivp44CzCeglPURtax9Q83IG5K5Rilh3PsLUSWXx0Mp/A70RyzDSYdX4XBNUTDTD+oeA+Q/A7r ojxWfTRyvLkyvxvIML6HFaZhlFPf0uA32XWf1EOo+bOnnW6gio8bmilhY2op3hxAaL8AL4+s+qRm Kv6Xz5eq4C7HDGYxW3sHbW3XfxTjjU2+GcI5ZZJvajxbVMqqeSpw+pd5VfRyOjkHyDZHgk89bHK2 puZGfaUILq19fiVXIDV1UjpXW7km5X3/AE2yjBmEUEM0mh9XOItubE2XzZRVn6LG5OKs+VocPrau UiGB8ju+lupcyco4w2NzosGq5Da5LI3bf4W6/wAN/hRyL076e0BmwSkxOvqGCSSpqoQ92/YXXZRy LlVla6hjynTNjdzK2naGq42u2jy5c7xukfnxiw/E46otkwyYFvIezdZrsuYji0mhlLNIRyyKJy3Z Z/6S9M+nmacPx2sy/S1UmISimdTSNBay/wDUGrtLD+lmRMDa2voMuYXTAtDvMFO2wB/Zeu8UUnV2 cflSd36Pz7YrgmL4PSls2D1kEVtnvhduP3CZh+QMyYrQCfD8Cra6J24dFC7/AOF+grFMiZQzdRvj qsGwmtY5pbcxMdZcF0opsoNfi+XMGwekhjwqTy5i2JpaSfmy5vZV0c46pt0aGHdOM40lO6SfLldT xDc+ZCR/4XC0WFV+I136WKgmlqr6WxsjJJPsv0TYnDlerr24RV4fh8kkjbiJ7Geofiy+Jh8M+SsM ztBmLDsDoKOdjtelkYs53vZZjGN3Lgvy3dLk0eQdBOoFexksWV8Sdq+0eQ6/9iEnF+hHUbCXRifK 1aL8WiN1u78QfXyg6IVeBsmweCudiEgjBsAWb29l99iGG0mO5RbiEeH00dVNTieMvjB0nTqCqS4t dmZap21H0aFqboT1Eq/LYzK+ItDxu4U52/wufrfB31fhwv8AibMrV0lIG3LjEQ5bwemGZ6XO2Wv1 P6OIOgeYZC1gDS5u1ws3F+peVcBxVuEYljdHRVzhcU07w11vwU4ukgtW9ts/OxiNNiOWat+H4ph0 tDUDYtqWFrr/AIKxKWF0sj7P25Wz36pGQen2YshQ5soK+hbmOmcGs/Sub/Nb82WsPK0ZlqNcmwDb kdrrMsaVP9PXgz+VM5LBsJrMYxGKhoYH1FZKdLWsBO69F5Z8AHWHMdHDXRYIYIJRdr3kC9/hc54E MEwzFOr2Hy1UEcoMuhrXC9lty6qZsqMgZEq8Sw+nEklNF6Iw3YbbLFU6RrPm2I1C4t9OrrFR0jpv 0Ubngf8ALvdfNYV4C+sONF7W5ffKY+Ws2W1zww9cq3q5hdfT4wxhxSllN3RsswsPC+lGc3YV1ndg Uk3lUc9PrY0jYvXpruLjyfNWom6knwar8A+mz1bxdjmDDYaC2xdPJYBdT9c/Bv1K6A0f8VzBhoOF atBrIDqbf5twt33VHPMuTP4J5QDjX1bYNuQD3WD11y7QZt6P5ko8Uo2YhTihkk8uQX9QaSD+yynu pNdmZ6mUZNH57IJTWwhjTZ3uucyrgLcUzLRYeTqjkkGtx9lxE0TIcwV8bNoWSvDR7AFfRZLmdJmS lkYdB1D1fuvPmxvE6Z9jBPyx3I3geFHo5lvpr01wyqwykaKueIPfM4bk2XUHiS+oM/oN1jocrRYO 2vwlzA6tq5HWMRP+0d16O8PY19Gcr6nan/pG6ne5WpT6kWH1mJeI/F3xU0zYmRsa1hBGo/Hvde7R Yo5Z1M+HqpyUlbo2A4h41cjZ6osAp8BqBW4vXTMDfK2dDc916VxuXE4cryOw6764QXbq3u6y0o+H PpDnnJeZcEzVUZWrW4BHPG8VLmkX3uVufxTOT8K6bOzFT0MtRKykE7KUfcduFNTjjFpQOqiotvdf ArpzUY3/AKQbLmAiTENTi8WtpC5uPT/Bap9M90gLHFhcb727LWh1Q+pVmfM2YWZfyzRDBXumEE7Z WgvG9iN1sa6bTuq+neCyzP1SS0bXyO+SN1zyYZYUnL2coZN7s8e+BljKfrb1EErbVXnPu0//AGuV 3L4x/EPi3h1ylhWMYThbcYlqKnRJA829Nt7Lpbwv1bofF5nylhsIXPk2H5XfHil6L4j1owagoaNr HimnDy15sLd16cqg86/KPMpylhf/ACea+lHWnrB4t87UldhrXZZytSSN/UxREgW7jV3K9hdTOoOX ei3TvEK7H68NpmQOa1sz7ulOm1hflfP1+P5P8JXRmKurqeLDKCmjaySOFnqllI4v3JK1ReLfrR1G 8R2NuxY4PikGVYXFtJFDC7ytN9ibCxK3DGs8vqqiv/yRva1T+zOf8NGc+n+OeKaXFsdipqDBJ6l8 sIlA0NcXcm62j9X4OmubelWL09dU4K/DpqRwje0x3B07WtutGHRPpLW9Ws8w5cpfMhrJH6S5x0Oa b/8AyV7Nzn9LrqTlrKNRXYXneeskhhMjqIzOIIAuQvNqKnlt8H2I49mFc2eDMy4dDRZvxmhwmTzK GnqHtilH9TdW1lnaNMMUMxLjbdcXiNDXYDjNVhlUCyrikLZL83BXLEgwwuP/ADRzdeTJW6ke7BzF Nnrn6dNBRVXWrDYaiFr4xu0vbffstsXVqnxGpyDisOEO8vEHxFsJHOrstTf0/szYVh3WGjbXzMpW kgMkcbAFbYOqkuJsybVV+CPa+qpY/PY2+0gAvYJCt6OGsXDo+R8NmF5ow3JL2ZrJOI+YdJc3ct7L tGKibBPNIxjWvl+4gWufddbdBs4ZwzvhEmIZlwmPCqd//wB7t4e75IXY2H4hTVuI1EcFdHUPgOmS FjgTGfY+y3lf3fB8vDFOEbPOFfkTqXhvWCSrw/FXS4PJIJH07nmzWLlvGzhrJ/DTjIqYGTSsY15c RctN9yFm5lZ1GpevNDWYXCZcqyfyqov4a38LmPFvi+EYb0IzOzF544Y5qYsia8gFz7XAHzsu9tSh wcko1Np9HyfgKwuDD/D9hTomhr5nFziF5F+olmOrq/EPl6kdI91FhzGSGDV6Xm/cL0l9OXPVPmXo 3/DmzRmeimdaO/qsV0d9RDpHi+FZ8oc6UjJK7Da70TuA2piPn2XWNLPI5TcpQi2e+Om00GI9LcGl pWCKKagZZrRYAlu/+V1p0c6NYxknqXjmYMRxJ9RTVlxFDruG/suT8KPUjBOoHRjB2YVMHy4bC2mq Yibua9osT+64fJ2A9QarrNXV+JYn5eV4nu8ml4Lx22XCPG9M7Zo3LHKPo7bzXj9Zg1bhkNJB5/6q bQ9zuGD3XwnXTozlbqVJhcuNVkeGVkLxabUGulb3buvvqzG8Gqc1Q4PNUNGKBnnRxOP9I5svPvjX yFmLOdPgdTlxs8k1DKJHiBxB54XGFuSSOmRJwk5cneEWVI8sdOq3B8vhztNI9lMJH6rnTYblaHM/ zYi/q9WS10j6fFKescHFhs5pDlvg6aYlW1XTyhfiNNLTVUNIGyNl5uB/nhag8wdG8W6w+KjHaLBa f9RNNibnPawizG6t3FfQ00lBTTPK/tkxxRtu8O9W+r6KZRlllMspoWa3k3LjbutYfiGrBS+NmrxM tu6nr4izVtYXG34WzzpnlWTpB00p8PxfEWPjooNUkzjZkQAuRdaiPFP1synmXxISY/l6R1VhcE7f PlB2mcw8BccC5k0d8jcs0IL0bpITHi+UIfMYDHUUgJb+WrQb1vmqG9fsyRiV1qeve2Mh1rAONv8A wt2Xh7615d68dMMMxjAqiMgQNhnpWuGuJwABBHbheBfEv4Ha/BevGEY1hIdV4RjlfeYu5jLjuFrS yrdGT7Gb/wA0ZVwj2n4HM345nLoPhc+OMIlpv5EMh5ewDYldj9c63G8M6UZgqcvwuqMVZTuMbG8/ NvmyyMr4ThXR3phTUzWfp8Owqja6RzRvsLuKwOlXWTAetmE1NZgMzKmhjcYn6uT2Isvnv+bkuj6U pR27f08ffT8xCpxPqRj36vUakxF8pf8AcH33BXtrqFW5YwvCDU5plpaehJ8oSVRFrn2XWvS3w8t6 Y9ZM0ZnoZWswjFmh0dE0f8p/9X7Fch4k+jdZ1wy3h2AwyMhpRUiWeV7iC0D2tyvZknGeSLi6VHhi tuKSq2ecOhE0eA+K3E4cNrZKvA5GPdCGvPltB+OF666s9V6XpRl6lxithMlJLOyKR97CNp/qK4rp v0Jy30xw+njoqUS1rGBrq2QXe5fH+NfBaPF/D7mJ9RM1jaWISsGq2q3Za1E8eonHYTDKeGL3HeWD 4xSY/hVLiFDMyppKpgkjljN2kFaYfqYvjpPFDWsBuXUzXPaON1sx8FWZqDMPQDLn6KsZUiCEsc1r rmMjsV4r8bPRfDurPjKy9gEOIRRVGMQsbUvJ+xoPH5XTRw8eeSl6O+XIkozo9ZfT0fAzw54LSMeH SROLnC9yAeF4/wDq+0DYc3YBiZ3vTGNbE8hZRyv0D6cU9FSvipqCgp/5tQ5w9ZA3JWnrx7+I6Dr7 1Jlp6D//ABWHOMMOk7PsbXV089uaWT/k82eW7bBfp5jY/wA2KiLGenWNVuAu/vC5iL6PrfglQWam NnYCO1rroilp5I6V0AeAXG4XZfQXMlNgHVjABWztigM7A6QmwvcL5mSTlJs/QY0oxP0EaIcUwdrZ SBTzQgO7bELrTo1hOQqPF8xNyc/XVUtQYq31kjWd9gvrKbNGCyZLbVNxCE0rKLW57ZASG6dyvE3g X6q4LWdZM+Uc+KxROlq3+QHvs2Qavf3XXHjc4Np9HyMrjvVq2emOquHtqOteRGRn+YS97rDgBfWd feqDujnSfH84RUv66TDYfMZT3trN7WWPmmvyhT5soMcxbMdFST04LIGPqGgb891xvWtmUOpHSzF8 Eq8x4aaKsgN3CpYb7XHBRLc4pmXKt+1Grvr/APU1zX1iym7L9FhLMvx1LCJhC8uLh+VzH0vg6q69 0bTd3lUsjpPyV466lYFRZZ6lYxheH1InpaR5ayVrtQI+CvfP0o63JOE4xiuI1+JQUuOlhY0TyBtx 8XXo1c1D6QR302FbfK+z3X4x5o4PD5msvtd0Fmk/0m/K+Z8BNW6r8O+EapDKY3PaHXv3X2nVzqB0 zxfKVfg2Y8y4WylrYnRmN1S0km3tda4eg3jfi8MHU7Gcm1tbHjOQRUudTzQWLogTsQViC3YHFdnj nKs91wZn1PellfjfX/An4ZRSFuKwsjfIxmoF4sOy6nzN9N3qTgWT5cxt/TujigNQ+KTZwbz/ANls oj8T3h86oGixKrzBhwnjIkilrrMdGeeTwvgvGD41OneA9KMUw3AMepMZxCrgdFEKOUOAuPhepZ/J jjhaPNBzxzbi+PVGmukkNNVz0z4w2aN5Y9oHcFfV9LasxdUMFu30ipYT+Lr4qiqpKnEp6543leXf 3XMYdi9RguIwYrS2/U0zw9oPey+dldSpH6XHzHk/SBkqZpyHhE0DfMtRMc1g7nTwvM2fPHDX4Bme vy9g2SK2sxmjkMcsDgTpPubdl134XPqa5DxXJmG4LnarZgeKUsQiMzh/LdYLtbE/GN4ecr4hW487 H8PqK6qA86aGIPkfbha09LmUbPl6qMrSi6Oqcf6+9QurOa8n5cxnLDsFoq3EI3l7WncA8X7L2j1K nqcM6dY5PQMc+rgoZHRsj+4kNPC8hVv1HuhNfmjDpvMc0QPuyd0BGg35X1mYfqcdFKIinhxV+JOe w6hEz0t+CT+V3yyUnHYqSPLjhPbNyfLPI+A/U4zvk7L1dlapyvDWkGSCOtmc7zmAkg6hwVsI8H9T W1nRPBKqvYY5aoOns7sHG/8A5WlLqP1jy5iXXPFs24Vh98JqqvzhRkWba99gthnS76rnTjB8o4Zh +L4PU0ApomxBtO0EAAWGyanaklBdnowYGkpNnH+MbxC9QfDZ18/jVD51bgdYwCOlffyhYbheivBZ 4hKjxJZbxbMdVh4w6SnmEPlNdte25svEXjm8cHTbr1kFmEZaoaiXFw8OjqZWaSwdwujfCV4zMweG bMDpJoXYhl2paBVUQP3O/wBw+V6pyxT06UVUjGHFJ5JTZsM8XvTjEq3rdkzFsv0UlXXTPHm6W3DA DzdekOoFNV1nSKroXtP6+elEZa3u624XlWi+rH0gxSmjqqnDa6KvY2+l0QJafYFdbZ/+rthNfEIM EyzMxjZATLUG5cAvJGTnti/RwnFxcnH2e+uiMdZQ9PMMoa2mkp5aSLy7PG59lrZ8U3iC6teGzrzm BuFYrHhcGJu86OF7A9s8d9iL912Zhf1gcpDCacT4FUNrRYPAHp+eF5E8YXiyw7xP5tp6miwX9K2k jDIal/Nvb+666dJ5Hu6OjxSnGK54Os+u/iGzt4iMTw+qzlVtlFEC2FsYsN+dv2XwlAx13xgEjSSq MLpZ2GQAgWG3ZNqcVbh9Q0Rsux2zn+y+dlmnNpdH28GKOKPBsI+knisNJmzF6SSVjJJozZjiLm3s vc3i3yZiGe+klfg+FUxqcQmkaY9I3bvuVo0yD1NzD0kzLBj2X6x0dQ0hwLHWuvaOWfq/ZqwrC44M ZylDiE7WhpqGOLQfkqYZU9x5tZi3R2vpmwjw4ZCxDpv0nocLr2l1c1nrB91wnROhOE9VM6UwmZI2 WQTFkbrhhPYrXfnP6s/UfHm1NPgmHUeE08zNIIZqkZ8gldP9KfGr1I6PZpxHMIlkxg4iXOmZO4m5 K9y5jLd7Plxi90VFdG3jFKGeh8SFLi81NI6hkozAyW19LvhfB/Ukpn1/hnxmmi+9xa/f2G5WuPFP qWdY8VzMzFoZ6SJkbrxU7ogWtHsVwnWzx6dSuuuVnYFjMdNTUrxZ5pWaQf2Wqi3F30b2ZKca7Z55 we0rDGL/AHWK+tyDmip6bZ7wvH42lwpKhk1h3sbpeSemOI4xh0lXTytDGglw9ysPEKeSGvNHMLhu xK+PmalJ0fdx/WNG/joj1ty14hOnFHi+DV8U5mgEdVTNeDJE61nAjkLrDpz4E8g5I6m43meWjZic dbK6aOmqxqaxztzstO/S7qznroni0lZknGn0DpD/ADIdV2O/IK7RzX4+OuWNxNbLmSSgmDbE0g0n /C9mCTcauj4ufG3k3VZtnrujuT6HqVg9flhtJg2LU7r1ENJpaXs5sQEPjH6cR9TuhGY6Jjmmtp4H TU51Ws4DjnutKOE+JnqtlzMP+oaTMlQcRd9z3vvf+6y85eLzrFnehnp6/M1XHTTffHC/SD/ZdYyi 5J30dPHOcaa7OT8Lmb6TpZ4hMv1eMvbBFRVemcEiw3st5GaKfA+t/TbEcIocYp30eMUvlefBI1zm NcPg8r83h/U1lS6on1mSR13TX9RPvdfW4D1Uz5kqMR4HmnE6CLsIJzb/ALrrqsqy5E4neGGoUzfp 0E6LYR4cslPwaHEBJTsvI+qqJAL/ACb8Lx917pMneK/xiZWyzT4xSuwnCoS+rqY3j+Y5pvoBWuHG PET1XzDQvoq/OuKVFI8aXRvqXAOHyvgcNx3G8DxP9bQYjUUtYDq8+KQh1/ysLIoNyk+TzPTSnFQX CR+lvLdBh+S8u02HsqYoqCmb5cL3yCwaOF0dRdFsm5M6+z9RqDGaCF+IsP6uJ8zS8yHuN+Fo4rut vUPFoBT1ec8XqYgLCN1Y+w/yuEZnrNJksMfxIG99RqXk/wB7rGKe22pdnaen8iUX6P0R9YsFyn1S yZU5dxvHqakwytFpTHVMYXt9rkrgMg9M+kPTrJT8JwiPAnYXHGfOfK+N5eO5c48rQTPnvMWIU4hr M01swbxG+oft/lBTZnxlzHRuxmvY3gATu0kf3Ujlqop8Hlno9097VnovxO9SsrZN8WzMw5OpKduH YdM1z46cDy5CObWXt3DPq49Lq3JbjNQV9JjDKbR+ndGNGvTawPstSVZhkb4XzPmNRUP3u43JXFvw xgiu4PuedlM2byO0e2OD60z6bPOcJuoXULGcwMBa2omfKB3sSbL5+lqQ46JN3arlYtAJaaYiL/ln ZxWW+IR3kYQH/PdcJT3HshFQVIdh2PVmXswR4jhkz46iJwIc02LSFtH8Kf1QcCOU6fLvUjW2upmi Nla3cPb7OC1W+V5cpc9+gu5IWJVMDqgBuq/+4BZRnJFzXBvSzV9RDoplHKFfV4FjUVRXMjc6GhhY W65Lf25XgLIv1I805X641mc6uN1dg2IO8uroC7iO+2n2IC8VPHlBlhrae52WdLC4MaYtLQeWkXXT c10eB6RydyZu3y79SboBmKhjxGrxqTCq9zd4J4Xar9xtt/deE/Hb47Hde8Sjy5lmeSDLFHJdpabf qHe5XjQ0dO1mota5/ccLBdTGWXYFrB2ukctdo6fFjdo7f6AeJzNHh6zlDi+FVTzCHfzaYuJjkb3B C2BZg+qn0z6gdLMRw3MeXZ3VNbTOglogA9riRa4J4WqIQWboIu33KezDIDHqax2ofN1z8jUrNS00 ZKj0T0C8a+Y/DrnWorMAdLVZYmkcBhdW4uaIyb2HsR7r23QfWQyc+gBrsqVf60tuBC8aQf33Wpxs UsrdMrG6OwCf5MQa0MpXOPuF0WTdK2gtNFRqLPUvVbx/Zxz31ao820F6Glw+YPpKRp2Db8Er0tlH 6yuHNwuCLNWSZn1bGaZJKZ4IeR3APC1jtfI06WRAe9wngwyxhrj6gd/letyjOrOUMCx3/Zsi6j/W JirsBlpsl5VdSVUjS3zKx4IjB77d1486PeLHEumPWep6gYjh7MZqquUyTNk23J3suoP0URaC1rQz +rbdDNRRvhe2GQB1tkWRYukaWFN2z2f4gfqn5j6r5Qqcv4DQvy7T1A0zVEbv5jm/7QfZeFqqqfic 8kr763m5JO5PunvojoLXaS4dwEqCNsZNzYrzSnf8TrHDGMtyOy/D94mc8+G7M5xXK1YPXtNR1AL4 Zh/1Nuu7es/1NuovVrL1HhX6WkwYwzNndLTNILnN4tfheRKiE+YHAtckwzNbKWvFr9/ZcoTlB2hP BDI7aPX8v1S+sdVlOfAZqijlgmp/0zpjD/M06bc/hdV9HPFT1H6Oz1r8sYhNFHWSmZ0IJLNR5Nl0 s55gvpc14PeyzsBxBlHibJfPcxttweF3edekFgg3yj1xh/1SOueD1bZKiso6sjby5YfT/ZNzF9VX rdjzG/paqiwwj7jBTjf+68tZjxKkxNrtDW3P9QHdfOQ0zmQl4nLHA8AqeVP0b8EFwj0/X/Uq674h TmnfmUsjPJjjAcf3XxGcvGf1Wz5gs2D4nmarkopxZ8V7BwXT8dSI26TZ5PchYT4/Lm1svzexWfI1 /EeGF2ztbpL4oepHRaKamytjklJDKSXRE3bc97L57GurGb81ZufmOuxmofjZdrFVrOpp529l8hXz R1LG+XHod3TcPl/TgOIBcBZRZJJ7kySxRZ2hmjxRdV81ZelwHFc211dhco0yQOkuHD5XV0LJZI3X Lt0yWdz3aogA75VNrpw10bwLe4RzkyrFFc0VSh0Um32d7pWKPDpGua4B3u3snwklhB7+yT+nEVzb V7XXNs7HPf8AqvnRmDx4YMy4h/D2N0tg/UO0gey4fB8WxOgrDX0dfNSVTDq86NxDr/lY0smqMt0A E90hgkjGkEgKxk48Izti/RzlfnHMOYK79ZiGNVdXU8edLUOLgP7qS5vx+GDyhjVf5b9i0VDiP+64 HyXPNr2CzaQMjaWW/crss21UYcEYk5qag3kLnuO5c43JTKKonoJBLT1E9NO3YPiJB/uCs2JrnXCJ 1NrG4C4uW46JKjHmxzEp2fzsQnk+HSkpNO5r9T6gPvzrKyf0jW7lmr5KN7nOAbYbfC6LJKKpGdqu zGfTTxw+bG4mH3vY2WR+kkloTN5hfbsTdU4yOiMZPp9uyjGSQRgMPpPZZ3sOMX6BgEtmh+1+4RS4 fGyQPcNzvusuGHUQ5yfJAJBa91z9mkjCjwds0zSwAMO5sbKVTI4akQtLmj3JuuQiD4mFjdwgNGyc XlYfyF1jJw6JKEZHHTUXl2kbGJmcHdLdRMkfdrHNHJF1yNzGdDBqaOyXNMS02GkkWWLb5YUa4F00 0MeqJzGuhtz3WLN5DvVFGWfA4TW07Q0Dm6joDGAWbfC1ZWjAkdrcG6AAO9rKTNe6Rp+4BZbqc31H uoGW4CjdgxakR6R5Yue4sqjpnCMSO4/2rJLW343RBhtYhNzXCKYoMMrmtLdHubLKE5ge2OC5jPJK b5TSyxCcwRxtA2KzuZaHSulbA0NcHDukSzGOA+nUT2TTMxrVjiQF97/hZLY+LEhDRmJ0ezuxHCkd GZqctY29/wCo9lf8uSP1C6S4eX9krmj2W0TsdBGKaExuLXA8nuFgiKOne/cuue6dZjhcOu7ujdC1 wBI5VtsUjEe6IkCXdv8A0pbgZW/ypHht9rlZZiEbDYC/ylwtNzcABQlDWU8TIQQdUltynRW0EnZY 7GO1kXs1XGSZHB32BCod+qZE0gWN0tml9QJHEn4ukyQNLr2v3ChDmt9lFwO+zPna2T1sAYbWXFzw SRssAHi91kRB2ixcSCmNZZtu3ZGOiYbMWNIkta2wKZI597xgWS/KKY1xaAiKCfXs9qoN2LQLBOcC 4g22VjRuL7q3Q7MXybO22QuAbqBaCD7rLaBe9kJYCSbK7iUcLLFIb2HpB2CjGVDthwuULORZFFGN Q4F1kEp43Mp7XsbLDmgOo7kX7hcs8NiG7r3WDObuNuFSmPTsfCd3myN+qR4de4V/PKgdpIFlAQu0 7dljyQB1ySsl/wA7JVtQslgTTsfESQbBZUU7JTZxskllhzsqMQAFkIZkjATeNxCFks8e3mXCXG7S AFHOOq/ZZA4WkaS8AlYslPocSDb8I7kgkbBWHktN+VQYr6Yv5/ygdRLKV2UBjtp7cIxFtaye3lHs BubIKMdkRBseE1kAadhZNbY8G6OwCBAeVvwjEaNrNSOMa3c7jshTHMdxvuUmakbJY2uVmvIY6x5Q OANghAJKcQxtA3KbG3ywjc0FluUvcE34VNjHOBAPZUACCRsEtsgBsdwrLtzZQyWYA9twEJhbfi49 k+GW0LrjdYczyCbG3wELQ4wtNrABA+PfYLGbLMHB1jpCyPPBcCQhAQz4VhnCafU3ZTtptugALADc i6OKIOvtyqc2ydGHNjB2Q0EyPyhsbIxIXborNe2zjZ3sg0aDaxt7qMiRbi29k6AjVbkHhKcy/bZM gZpNwsM2jKMYaRtwguC/bZZBGqMWSgLEXChpBaAd0LoQU8N4twqsEFChGGm42R07A12p2wUfvwra DcAoQKqjM7dTeAsBpOuxN1yhfZmnssCdrQ+4QqBJuhkGpTWArBuDZaKAG7W7KCNu3ayscKX24utW UsuANgFdwBdIc49k24ey991CBF/lgfKoPDrgjlKfH5rb34VxOD2lg5HdSyhPiY8WIBQmmjtYBMih 5JO6twIsVLLRjSscxoACOJiebOA91btLWmw3UsUJs3TsEL4mkjZMYwAHUDuibH7j8JZKBFMznlY0 8YY7cbLOeLLGmcHmxVsjMSOmL5dTCs2D9QLte0W7FJa5kDg4k2XJCqZJGNO23Kpk4hh8qeWSRjrr CqZbElu11ydVIXNeL3XHvZ5sgPDVpMyzDLjIWtHPuuQic6JlmncpYpbOu07ISCy4ubqmaEhjpHlz isqBhabcgoIWa3nfZPiFiQSslGyQ6mgNO6xZ2ujOk8rkaWMhwc7hY+JND5rsCIGDHdx4sVOxsLox 5sZcRHqCkJu07WJ91oFMZdFG/SbAd1YuwADlEduyAyPOBaA8bKnMimbzpssezgCbbJbd3d1KKZ0D C5zmncDhQPLCNW3wsCSplju1u3yihnewXlNwU5IZzJ2zSm/ZZMhJaACuKEup2pgs3unx1zZCATYh AMMmlxBF1TjpbuN0PnguIAu5MB1tF+VAVb+WDdLduFckjWAtcSltdqCAjBqJ7bo9Gr8e6AkhEyTU 2x5QAOjub+yv5Vv3QtHuiMsjXajYBERqNroC1CXlvytAsgC6XI4K9e91HN1WNkABtpVOtYW5Rkcb KnjjbZADp1NVhu1+6tu4u1WSCN+UAt5BPyhurtvdEXfCAobBUeER4S3PN7EblAWQQrH+VNiNypcd 0ARBIQxvBcQ5LEzg8jsha8Mk33CAyn7EBQ7C+6EvDyT2HdDYytIbt8oVDJLNAcNyilkEcYceVjxs cxuk7lHJdzQ0hAy45C9tzuFP6kqNpaLXTDxtz8oQVGzVMS47JzxvY2CWD5ZuQrJ17oCMYWX1I2u1 XHZA8kjdUy2r2QFTWDbDhLYL/CybNsQRdK8pu5CAFxDBtymX8xo1bFLZDZ++4QzzXqA1osEAxoub BA+7SUReGPt3RD1HcIAGN1C5VixTCLx2bylMZpuSgL/ZThXYWG6g534QEtur2AU7qwLoBYJN0bGg FWfQb22VglwvayAjWEXPZUdyPSiaS7YlExtroWitJYN1GuB7KzuNyoBZAi3W07cpLnuG4FkzUSbB AQ4ndAymku5Ka0n8pTW2PymN9PdCB3sFbflCXAGxKsWshqwJtWg6RcqomuDPVsU3ubICbGxCEYEY 9R3RAXJVizRdLc+zgexQgza9vZV9wSY3kCR3ICcwHy2n3QEA7q0O/F1NkALoW6gbbpgdY2A2Co8K nHSLoBbyC42Qk2Vgcn/ChPpO26AFt1YBF7qy2zAe6XZ1+boBoYXAEq3N0gd1T5HxxCzbqmSFw3QF 29KvU3goC3flE2MC190AZjsATwgLwftF054c7bt2CSGFnaxQBb2CBzwDYI2jurOjuN0Aph9+FbhY 2smeSXNDh2Sibvvq39kBTiG/lGHtO54QOaHO1FWW3t7IBT4/WHgbJkL2ulu4XR+UCDvZK06N78oD JJFzYKg9p5SmPINrKFgvwgO5+s0Lm59xQN4851rflcRSN0xRtPK5nqUXTZqmqpb6pZCbH8rjIwNT b+y/NaJ1hSPv6p3kY8MvHvyuPmiOpxC5F19Hp5KxJI3gm53X0EzxyONlDpNrbrHuA0tcbFZs4LXC 3PdY00TddyvTE80kYjyGmxQsZ67gXsjn0hpWPTTPa8tDdTfdboyZ7CYvUNyeye2b/cqdGGtbc7nd KbuTc/3UNB2DRze6jjtZT7ASd1C24BUBCAG/KU4posTvwsQzF0pYAdPugGkjQSTZYzidWoiwHdNl dsAEBsW6Ba9u60iMzsr5br8045HTUETpDIbOtwF7I6PeA+POMUM2Ksd5bh6rtsF8H4M8MoqjHD+o iY94dcFwW2XKNFS0mUpZqeFuuOElgHcgL3YMam7Z8/UZdibR4DzP9OnKeXcap21mImhp5CAWh3qI PcArI6p/TDwDAsjS5ky5j1RNJEzzGxSsvrFvZdRdYvEjmbEuvcprah7Rh9SY2QBxLQAeLLZl4e+q GE9Zcg0kVW2N07Ygx8J49l7pwipUfKjnnNWjwj4ZPA3ljq5gFY/MTpIaiA6WtbdpJ4uu08J+mX0t izV/DHYlJNVMbqNOZN7L2LV5bwDo5geN47SQMpIo4HSuHAuB7Lw50H6s4x1B690mNGsJFTVvaGX2 Md7WXRY4zTkujzvVZFLa+ztqv+mn0ZoIx+tMlK53/uPkAXz+M/Sp6YVbY56HFJ44nEEEOHq/cL0h 4gOkdd1QwemhosSkw4wnU90byCQvMuVOsmPdK+oNNk6sqH4phbZBH587rubvblMePek0zpHUT3Uc Z1W+lll//Q7pcpvMeMU0Ze0vdvIQOFx/he8IWUM1Zdq8MzZhAnx6lf5b2zsG3uRdbCpseo8MwGHE KqVrIHMB1OPuEjDcJwmoqG4xh7ISZ238yID1X+QsxyJJ7o/9naWSadpmozqj0SyN0e8UtPhk9EyP A3OF2f0A/PwvYmdfBN026yZCp30bKalqXQgw1NKANJI2vZeVvqYYfJgvXGinaSW1cAIttY34XpH6 d+cMTxfLRwyvqHTwQizDKbmy1lhGLTRvFnnOFms7xA+HvG/Dhnc4Zi4dPh0pPkVNtnNXX87Nbmtj 3iO4W0X6sGVqWu6fYdXOjBlgk0teBuLrVngsh8sOdc+XuAV5M+JJKS6PdpM/le1mfS4cKmeOINvI 7YAL1x4X/ChU56xWjqMVhd+jc4ENtyF526R0EGL53pHynUwPALTwt2nhkwCkiyHDXRQRiTRoZYcW C8sYp8nozScVaOvs5+ADpzmnJVTh0eDw0eJvhtDVstdj7bE2+V426P8AT6r8NfWanwfNOECow4VH lVFTI27XMJ2c24Xt/CMtdXmdZp6yqqB/pXzPTCJABpWV4xMu0E3TmHF6mGNtZTTsIkI3IvwvpqK4 jfZ+f+Rkcn+HY2OZbyDlnKUmYHYFSS0jIhK0iEEuBF18NTZF6deIfIlcynwCjhpKiNzHSiINe02s ux8nTYXmzpLhctWxr6B9C3zGu4Hp3XUGZPEB0x8PORa79JitNNI/X5VHC4F2vfYrGOL5S7TO+TK7 XPB4O6NZawzw/eJaqy/VMY7C21ZZHNK24IJ2W2OTCsAxDABWHDqKohEBeCYWkEWv7LSbi3Vufqz1 ogxyojbCx9ZqEbDYBt9luZyeQ/o7BKDqL8OLwOd9HC55I/7bNXLx8mtjL3SbCOvXijxWjbh0VNhs NQdbIm2BAK2CZlrsl+HLp/HUVkEFFhlK0M9DACbLyL4RKwYX4ga4SNtNW1MoNx3vsuzfqctn/wDR mn8sOLTUWcBx+69zgvKoI+bkyzeLcjtXA895I645OdXYPJBWUMw0PjkcNQ+LFaePGn0/wfp91/ra DLsX6amls+SFpuA4ndfJYTn/ADlldswy/jFXRQ33bTl2m4+F8ti2K4xm7MDsUxqvdV17tnySn1H+ 65apJKj36LHk4nJ8sU6mfBWRuisXWuvucp9NsZzzVRsoKOWeR2zSwL53DaFk1Tu6x2AW0f6f+UcE /h2HianjmqtIeS4AlfIa5SR9+X1VnjaD6fHVbE4mVUGESiF4uC7uvjc9+DLqbkgtOJYFUGMi+prT x+VvezZjlFlnDHVVXVxYdSR2DpXkAAL4TMHVvp3W5ZnbX5jw6qgdGbl7g4nb2XuxwTS4PjS1TU3E 1AYV9Pvq1mXBKfFMNwVr4ZANF3r6Ki+mB1ar6E1NVHBRPb/Tq3K2i+F3qXFnnAcWghaxlJQ1BZSh n9UfYp2ePEtgWQeplLlPGNNI2ojD/wBXKbMb8Fdo43vcFG2TJqtsVKzUTljwJZ9zLmmpwGWOSCqp vuJFg4fC7Ww76VPUaocG/qYKeMi4dI6y9xZ+66ZUf1LwEYBWQ1dc6QMc+lIs4E8G3K7i6udTo+mn Tt2YKgbNDSQQe61KNNJR5Z5VqZU5N1RqA6s/Ts6m9K6F2J1BZiGHscNc1M7VpX1HST6bGc+qmCx4 jNWfwijeNTDO2xeFsAwHxldMs84bFhuLSWfUWaYJW6g5y7rq8QjocgVVVgkbWRw0rnwN02AFrhYe Px9xpljq5y6dmsrGfpKZnoMNkfQ4tHV1DRcNLrAr4np/9MzOmZcUrcMxfEIcNqoSdET+XD3Xtfwb 9cs3dTM55lwnGqlk9DRzkxuvdw34/C+26w5qxPLHXbKzaINbDVgRP22d+Vqvs4tEWqlKO+zx3gP0 f8YZXaMSzRGykIu7ym3P4C658Rf0xsxdJMDmx/KtY/GaaAapYCDrA7lbPfEX1fl6NZGp8bbEZCZA JCOGjuulK36g3S3GciYnFW402DEXUzmCFwB1OLeEipShua4OktTKM9ifJpcljdDUmKojdBUsNnsd yCuTw5gmlA0XJ245Kzc9YlS5gz/ieJUtjSzzOczSNiFl5dZGXl2n1MII+d14pRSk0j7GLI5RtnrX wl+AmfrXTvxXHJnUWDkWBYPUV6Yf9KjpzDNoZi08klrBspBN/wALujwJvgqeiGGyxARv/raO66L8 RueMy5W8S1DKzE6mHCYpGaacX0vF100sHOXB8zW6mWFKSOqOqv0un5UxGixHDMWjdgzp2tnaQQWt J5XacH0nenWJUFJXsxureXMDn6SNHHZesurGJNruhmLV+osdLRa235vZB0ErHZi6JYOHuLpDTljn dyQu8rlDc/04rNJvbfqzzLX/AEuekOPZcrKXCqqV+KtjLRUCUOLJO1wtYvXzoRmLw451lwbGGiWH zSIZQLa29ity3hNimOO59dPI6Qw4g6FrXOJtY/K8VfWBphFnLLTyyzpIib/7rLSw7puD9Exaqf1c vbo8FyQMq6ylld6tRAt7LYh9MrDsNn6k1Ynax1SyAuhcQDYrXbhDnHSx337FoPZe7/p049FhHV2k bNI1onj0m5tuvI0q4PuTVxs9veO/P+ZunHRepxPLbxE7UWVErfua0jay159GPqOZ36cRtw+qiGN0 msnTMfUT+Vsn8aWWq3N/h5zRh2G0prayaG8UbBckhaqugPgozf1WxuWlqMLqMLjhaQZJgW+r8lfR xRTwH51RUtQ9zNh/gX6qz9a8UzbmyopxQmd7R+lDrhvyu4c09Jp8V6i4dmeHEzSMpzeaFx2ePZef vA/0uxnonn/H8p4iGsayPV76wLWIXF/U6xrO+Sst4XmHL2L1dJhhf+nmjpHEaXHgm3Zc1unlpe0a z44wgo/2etMUz3hE+c6DLkU7KivcwyBkbwS0e5Xm76kVC/EcoZZFtMEVbqc7+2y89fTWzHjGa+sl RU4ziE2I1LKYlsk7y4gEcbr1h9QDBavE+jLTQ0slXVx1Ic1kTdRHzstxisOeMTnJScGztfoPVx45 0Wy8W2a1tI1u3wFz4hqMZytiVLDMaefS5kc0exB7FfEeFfD62g6B4BTVzHwzmDiQWIv7r7zBH0ww +voKOuhnqm6tQY4EsJ915ZcSlX6etuLUW/w6H6C9OsxYXn7EcRxLGXVNK15aYjJfUfwvjvqc0EMn RqCvdBHI+GoDQXC5F/ZfX9L8k9R8sdVMRlxVxdgE0jnxuJ5Xxv1L8xYc3o0MHqKmKGeSRr2gn1Ej 2C9dp5U49HzouoU+7OjvBL4vsm9F8mzYZmSqbSudY6tNyuufH14xcjdecu/wLLtJHNO2QEVpaW8L 7r6fHhbyh1OocSxfN9DFi7JgRFC532p31B/BjkTpn03fmXKeGnC5qQ3e0H0uHsvHNxjJpH1dze1s 144exlLgrJXHdrbcLncqufNDG4C7XP8A7r5OGR9bhEY+2/YL6rLVc2mp4I3aWaTffZeRH2otNWbf Ppz4h+ryHiNMB/LikaR8Ffa9ZukFJnXqdh2OYniv6OOkaPJjc7YkH2Xn36cHWXLeGx12AVtdHTV9 UW+WHusHfC9N+I3oljPV7+Dy4Hi5w39JIHyFr/8AmNvey9WGajLk+JrYOZ2zQu/RZdjmLw4RRABz RcO2XD5wpKbM2RKsVrzBTyRHW69rBcXmbOeFdH+l8FXmOsbFT0ULY5HyOtrICwsq51wLr101qXYL VNfS1EborRPFxcbLcU1Lf/Z5ZODjt/o4Dw59LMIyDS1lVhVeysp6l5eGtdfSV538fB/gPVLJGMRt 1SiRlhbe+r/8i7+6FdE6/pQ7EJMSxWoqWOkL4mSO9DGcrxH4/wDxB4LmHq5gdBQVjJ6bCZbTvYbg kHhfQg92dyu1R4sVbVCqaNkeNB2O9JqktB8yqww2sN7li1XeFWmbReKDCqeZugR1rxID2dc7rZF4 duteWOs/TnD34TUxvlhp2wz07iNTSG2Oy8W9fehtb4bercfUPCXvrcLnq/1T4xsY/VctXHDk8cMk P09mSO7LF+j371lwnBcSyPiLscLWUbWbvPIXy/h4y5lHAcClOWKsVImu6Qh191kZWzfljxN9KWS0 Nax9HWQaKiIH+ZC+24ITulnSnBegOV69sVXqpWapXTzutYckLyRlWNwfZ0nBPKpo5fA8GxihzVXV DiDRTu31G5XwfUTqrkTp/wBWMJwuvwRk2Ya2wirGxi7Cflcp0o8SmVuq2PYjhmH1sQnpZC1oe4Dz LHt7r4nrP4XKzqV1jwPOsFcxkWHlp8kOIvYrtCL8m3I64PJl4hugrdn1fiwweuzJ4ec2U1A3TVy0 ZkA7gDdaYui0tVB1DwaBrnea2ujY4g9w7dbt+v2aqHJHRrH6nEamOINonxgPdbUdNrD3WurwBeHW i6pZvkzRicjG4fSVb6mOMOAdIb7bLvjaWnk3+nbD/wCeq9G0mSoi/wBDmW/obQ3dY/8ARutUXhgx Z2F+KiaqcN5cUe3fkguWwjxTdccv9A+leJSVVRHFVTU7oKWlDhqcSLcLTPkvr3VZf6kQZrZH646k ymNvH3XXPFJQwTv2dVF5NSvxG9LrhhcWOdKsy0sjQ8OoZHNPs4NJC0QZUwmsqc4VMTGOFV+qc2MN O4cHdgt0HQ7xN5G8QmQ4w3FKWlrZoRFU0U8ga7cWNrroTMHhEynkXxD5azLg08EuD1EpfV075QdL ieeVnBmjHFLG/Zr+OdZJdHrLw+QY7T9HsuMzG/XiYpm3uNw3+m/zay+P8ZOUMWzl0VxGkwhxDoSJ Zmt5cwc2XOdf+sdF0i6TYpjlFV0prKaH/hYi8EOI4C+c8MPXml69dNBiuKzU0dW9pZUUpcALcXN+ y80ITj/tSOuaUZXD9OpvpyTSGizPFrPlQvYzSRbdd1+JDxB0PRHCqIVFIayXEXGJrBvYe9kXTXKG SemGYcYnwzMNBSNxGXWaPz42gHnbdc3nfp5kzqBj+F4tjdRQ14obmGF8rS0/J33XWc4Szbnyjzvy PFUeDzJ4VcJxyTqliGZoMLnpcHxAksc5paN/hd2eKPq7iHSWny9idG2R8balvmRt4kG1wSuxznrJ OANZRR47hVH5YDWwioY3T8WuvOXjx6oZVb0MlbFi1DXTzVDPKMUzXOaQb3Fjsu7k9RlTceDlHdji 4p8nqDJebabPWWqDF6XaKpiDyznSSNwtLfi9gkl8UubHCN7G/qQ1l+62P+FXxD9Ph0kwujqc00FJ XwxNEsVROGuuR2uvJHV3Gem2evGoJsWxamGAN0yyS07xpkePlawpYck0zrLe3GXs9u+Cd1Wzobh1 PV076d0GzC9ttQI5C18/VzFMOq+Gfp3NM76YCUDkFbAc0eLXpL0wyAZcPzFQvjpKb/h6KJ/qNhsL LTB4gOttf186lV+Yq0u8mSU+TGf6WDhY0s1jcpv2jeSLnlioro+BpHlzaZvcd16E8LeJy0PVjAnM vq/VM3HbddCRsjYxj3NtptsuyeiHULDsk5/wzFcTOijila99ubArwObbdH3VHhn6A31X6TCf1TwH BkHmO+bNuuo+h/iJyr1ix3G8LwendT4jh0xjqAGWDrHm6+BHj26NYxkGpbDmuKKrNIYxBKPVq02s vH/hS8YPT/o31GzLPj9boosRle6Ophj1W372XfDi3wlL2j4uaM4yjSPcnW6omoOsuS68McIYn6PN AuDc8LlfFzmPHst9DMXr8vPmiro2B5kg2ewe666xHx29AcyVNHPPmWPVA8SRl7LG/wC6w+ov1DOh s2Xq7D6rFhiLKiJ0ZhjZcOC6pfwuPR557nvr30akOonW7PvUetfQY5mbEMQow636WaV2gH8L0T9P CKqp+suHSRgyPY9oLfjiy82dV8ay9jXUGprsrRuiwt0rntB7C69G+CfxQdN+hmYqiqzTQzSVMltN TG24Z82TPmVvb0fT0mNeG65NpnirynPnHolmGggLvMbAZdu+nchdV/Tzz5Q4v0ymy42RjK/DZnao 77lt1x2K/U56F4jh1TGcWnkjlic0xywkarjiy1p5Z8V+KdMOtWMZrybI6DCH1jpGUx+18RP2kfha xY9+FqXH4eTY1lckj2Z9SHw4Zo6gdQ8Fx/AqN+IMqYxTFoF/KN+VwUn0xMIg6Pur8Tl1Y/5Ou7Nt Bsuysv8A1YOl+L5ep5sapp4sVa0GSDRcB3ey6k8Q/wBVbDs35NrsAyPg9RST1DfLNbObWHfSArHM 3GOJro86jPHNyXs16Y/gFTlPNFXgdQQ91JKY7juAV99kCd9DjuGyMdpMUzXtbfixXWUmKVeNYvUV tS909XIS5z3dyuUwesrf1BdHKWyxnUDdfOytKTUT7+JtxW4/RN0ixwY50wy/Wag8upGXI9wF5a6p dQPEZJ1brMLyXQU3+ny60Ms7B/3XjPoT9SbN/RTDY8Hr6CLGcLj2DJCdTfwV3kz6zGAyRhs2R6jz m73Ewtdbw8ej5erhKb4PrOoPTTxA4pW4fimb6uirqNkrf5VKb+UL/C9j4plusx7pMcHiqHUtbNQB vms2LX6e37rWRmv6uuacTx6KbC8sQw4RGb/pZHai+3uV9WPrMPlw/wAufIpp6pzNOpkpLQ73sV7s jnNRVJUeaGBqL92eeMxde+pvTfO2LZfpcaxKkbDVPp9Uj3Ek3I2Wy3wBYFjUXSSfG8ee9+I4pUGR 73/c4e5Wovq94gH9Qs9Q5phw9kc7pvNdE0WaT8henOn31bMYyRlKnwR+TYZjBGGRyNcWgbK6qUeI wOuDS7Y7md4/UkwHPeB4xg+a8pVtZh1BTxFtRNTEjS++x2+Fn/To64Y91KrK3CszZimxirp49cZm fcncbbryJ1g+pjn7q1l+vwR2D0dHQ1bSzQBctH5Pdee+nXVbNnSXEo8Yy1ir8PxMO1l7TsT+PZSW VeNQfZMOkk25G6PxW9B8f6uV2DVWEtYRRShzhJ2AN7hdz4DQVmDdPWUlQ7zqqmotHsSQ1ai8A+q9 1mwiFjKmlw/E32sXyxbn52XE9Q/qcdYs80zKamdTYFDf1tpYzqf+/svOtziov0Y8DjNtI21dAsv1 OBZGH6iJ0bqmpkn0W4uf/wAS8JfVD6bZidmuLPOD6m01FTCOd8by3Tbuug8q/U563ZVw9tFqoq6B gswzQjUP35XxnWrxvdUeueCS4PmAQUtFO3Q9lOzSCF3wyjjyOcuivTSlBROlqzF8ezRRRNxPE6io or3bG+QuCXRMZDK8xmzW7aUNHFJHRRQtNmMvv+U6OJsRLhyey8WTJulZ9nHiWOP1PRXg6z5hWSOr uAT4jUCKnknbqceG791usxmnos+ZPqqemniqaaupy1j2OBG42K/OG6tfRy2AkZIDcOZyF95lLxLd VclReVgea8Qp42fa18jiAB+VFzLs45oNqzdb4ceg1T0OGLitxAV5rJDI1/ZovwuJrsx4JmXrzh9L htVBV1NLtVyGQDSR7e61Iz+ObrtiVFJSTZynkY5pa6xGqy6tpOpWfIcdfi1HmGtp68v1maOUg3/Z e7eotzm7bVHzPjzaUfSN+3W+lop6TCq+unZBS0NS1+suAN19LmGpocR6fYhIKqnlpp6N/wDMDxpI LfdaAcyeIHqxmij/AEGL5wxCrozzGZdj8rhouqnUCCkdQDNuKR0r26fK/UOLbfi64qUNqSfKPQ9N Nyba7BzyIaLqHj8UJa2mZVyMFuPuPC46hxSSnPmsDmSxuGmw5AK4maR01YWTF9TI52p8h5J91zTc VDGmCSJoDR6bDcrhqMyzys+lp8bwx2s2feCbx/YBPhVBkzN0rcMfEwRQVMmzLj/cewXrXM3SLp71 Tzhg+c62TD8TkomWj9TXRyexd72X5/5a5/LIHtd7tKzabOGd8Dg10OYcTpoDwxtS8AD8XUxzcHad Hm1Om8j4Vm/fqVmjKE2Fsyu3M+E4FUEt0tc9lmtB4twF9xRY5gDcFp6RuMYdVRCERktnYQ4W3Ox7 r84L5sbx2d1VWYlVS1D93SPncXO/JJTaLHMwUkZiGYsTpoWGxDJ3WH9itycaVM88NNOnfs9MeNZu BdP/ABUVNZgHknDiWzvbC4FuvvuthfhV8bvT/qXkGkwmvxGPCcXo4RDJDKQ0OFrXBWlCsFTitQZq rEJa+X/fK4lx/uscPkhnElHNNSVA2LmEtv8A2XfJmjkik/R0hpnjhtN9eT6Xo709znW5lpM24dT4 lXXMnm1TRe6zM0eNjo/k3ExR1+dKCd7jYmndrDT8kLQQ+XE6mQiatnkv/UZXXP8AdKli8pwY90hv y5264txlzJ2c1ppRVQ4N9eaOuXQPrDhMeGY3mbDKygc4PENVLpaSONiuak619FsqZVfSsx3AJMKg isKeF7HEtHbT3X5+xHTvdpfWva/tuRYprqCby9ba57hxbUtRlCqbZPiTi9/B6M6geIzBsm+Kmuz3 kmjZHg8U+plPEAGyWPsvVmI/WCwLGMl4hTNy7PTYvNTmJhLrsDiLErWRBhxja5hb5rnb6lljC4Z6 QxRtAm9yFyzTU3cT2eJyik2cviuMy5pzViGNVYDZKx7pdA7XQMnbLVAX+02sseiidRwhkjbvbtfu siCCMuLjtfuuD55PXCO2NHPYTjVXgGIxYhh8xgmiNw5hWwfw3/UywvB8sR4F1FvV+QAyOtj3JZ7O Hda246yOgcWtvIDyCk1EFPVku0Fl+VlIxlxvIqRt96k/Ut6VYZkOv/0liUk2LOiIgi8rSGOK8M9I vHxnDpr1QrcySGTEsJxCTVWU0h1FwvuR8rzC3DqNoAjYS4n+pZkUD6JrQx7RflpC9ayQUao+d8OT knJm3LDfqsdH6zDG1FU+tpsRLLmkMXBHa68JeMDxpYr4iceipcOdJTYHTE+TADYH5PyvPEtA+Uuc aaF4/wB1rFIjpWxOBDAD3CQyqHLXJp6JXafB9t0X8QebuguZ4MYwatljexwL6dzj5co9iF7UzD9W HLWfundXgmZciyy1FVCY5GsdePXb7hfjda9qqnbW/wDMADRxblYUmDvDbQTbexWJ5XJ2dZ6aLVHd fRnxmZi6DdQKzHcuOc7D6p9pcMnBMT2fj3XsKk+s5h/8ODKvJMhrtO8kc1mX/HK1oTUD4ohdjHkc rHgdEHFstMAT/V7LMJK/sYWljFUmz0DnLxwZ6zZ1bhzrR1ctDLTSF8EDL6dN/tPuvUGXfrJVlLhk UeYMkNnrWMDXPp5CBIe534WuIkNYWusADsR7Jk0EUnlls5bYb3XdzjN8iGmjHg93dV/q7ZlzTgk+ G5Ty9Dg36lhjfPK7U9gI7fK8vdEvFZmnoj1CmzRC3+IVFRI59Q6U7vvzuuq56fU8adJb3IG6U+l0 MIY8m6ssiUaijrDTRi7PWniA+pVnPrXlz+BUdO7B8OeNMzY3WdJ73I5C8mRwira+WSYMlJuG+xV/ pQ1jdfI9kUkDS0FltlweVpUujccEYz3UdhdE/Efn3w4YzJiGU8Q8ts201PL6o3j5bddy9RPqV9Tu pOGUdLJBS0MlM8Stmhj31juF5bgigkuZmaiOLqRtgZNqEpZ/0Kwy7HdGZ6eOR2elMT+on1rzHk6s yzWYrTTUFXGYpXmFolLSLW1c2XXfTbxI9TOjzZf9N4s+jjluXtB9Jub8LrWSopzY6Tf/AHBGWxOs 9lTI3/pK3LMnwkPj432ekcL+pd12wmbzTi8Vbp7SRAtWTjP1O+tuOlvlYpHQO9oYl5vpwCwtErHA 9ncrGnifDcR2AJ5Cz5k+0X42NKonoGr+oh18mhMT80hsfYCNoJ/flfA9QPF51Vz/AILLhOYMemqK Kb7mcArreWmEsbfMdqcO6W9kLw2OQbBRZmn9TPx43bPvOmHiR6mdIqGWjyjmGajoph6o9V23/BXE Zk6t5+zdm+LM1fjVQcai+2rY71Nt7EL4+SCRsn8veMcArk6F+gbbkixuo9ROUnJm3ii+TsCv8RnV jG8IdhVdnKrmw+QaXRvk5C65NK8yuIf5kmrU93Jus6SGKwc9wJ7AKqSIU8ri25D+VPPOqHhhd0AG PlHoPZFJhoEIPnGOoFi2Rv3ArI3Y46NgqdE1w1XOpcWz0vqkc1S9VOpOHYc+ghzZW/oXs8sxGY2L fZfM4XU4vg9U6rpcWnoqvUXedA8tcT+UchljNjISw9kDGxTFw3a5bhklBUnwed44t20ZlXj2YMxO Lq7G62ukHDpJ3GyxnY3jFPEYJMYxGGMndomcR/3S4pn4e/W1mppKa+sNc7/lW/Zdlnk1tZjxRvow f02kukL3TvfzI83JS6ZlRQzedRVdRRSjcPheW/8AZcyIPQAQqMB/Zedyb5Z3Srg4Svq8VrJL1OIV FS73lkcT/krCkhYWF0mou4J5K+impNRvZY76Extvpu1dHkbVGFjSdnCupHmIaJiR2F7J7MJ1Rh08 zgb7Bx5WY6Ig+n0lQ0xlI84kjtZc1Nro1sj+FwUzYx5d7DtZONC7Xcv9FlTWAPaG7291nPhAbc7B Zcm3ydVwjiXYJTyOc4EEjfTeyS6ihvpLix3a5us6elAcHxPId7IHxtnY0yMIe3ghVZJJcGJQUuzE jw2KFpMrBJfueyVFh9OZ7Ma6x73WeGC++6vyzrGizbJubZFFLsCoweOFrTpD3ngLIo6KmFtYEL7+ 91JdencrFNM/zBI4knsjmy0lwclh1DU4liraeKOPy3bGQjdc5iuUHYZzUh4cPt9lxMVTJSQh7HFr +btTjW1Fe0OMrnD/AKlncwo0ce/CWwSNdpa5p5NrJxjbGx8bYbBw2cFluglfDoO4KFlPILAm/wCV FNrorxq7o4tkFTE0tEUb28anN3Rw0jtYaAIvey5URuMZbIbD4QigjbGXeaSbKb3+m6T7KiZ5bS2+ opjYIXNPmM1tPIVU0LtJ727prTa9hust2aFzS0gAjZEW24ugGGGo+yUtbza6KWMP3I3Swx7fteW/ ClirKlw8QTA6mloHtuhHmx/bI5zfY8Iy15PqN/lEAbW5WtzJtQl1EyphcHOs490rDaeOhbJG86gQ QCeyyzBc3v8AsiEDbcLDbI0mfWZE6gtynh1TSafO80EA+y+cqKrz62SoI1l7iSkR0ke+1imMgdH9 xB9lzrmy0Mc+GUgNjDHHlYxpgyYuLy5Oc1p3ItZWI2ubcbrpEUjDexupxIuOywpKYOk1XI9wO65Y wi++4SzE2911VE2o42pH8sC1mDsFgsLY3HSLtPZc1JTB1wsGaiMZu2ytmaMcu1neOwKA0foc9uw9 lnNhIiudygN9A2I+FN1ko4p1G1zrkIDR6HXaOFyrmA8pb2C9ghlo4j9BGXFxbqKcWP0BrdlllgJN lQGk+6IqML9LUMddspsffssxjqmKHSHtffkq3klwsdk4MFhyUKY36RxZs6xJ3QPiIcATdZZe2I3N 1T3suDbnuqQxnxhzQCL/AJQOa7TtbbhZJsELm6htytIUccyGQvJkt8AJ/mX5590b2HlARtYKgUYH OkDrkrKbG5zQDsriFmdimNdp3KFFmG4skgvgfdrjp9lnCMv9QOyF0Y3FlhxC4FiUOAIBusqGokYL s9P5SGNANrbLJBDhZbVIzYrUSHuv6ncpIiIde26fILcJfmGy2mTgdFMBGWna6W6ANOoFMjA8ouKx XvkcQLWb7o2EgvKDzcHdIkpWEn3WTJKxtg1p+ShkjIbqJXNlo491ML/KTLTNJ3C5Brxf3VFocVkh xwpgOB+yEUoB4WdINISwdQ9lQIERaNv8qjBvcuO/ZZBG1kLgD7qf8AoRtaBYW/KK2rkXQFxtuNvl FctaLDdXsFOhbubbpJY6/cBZAue/KINsPdaAqMEHhMO3a6svBIIClrgX4UZsl7Eb2RSuBA0lCW3d 8KGMHhZJYBjBRBg7hUTo5Vjci6AtsDb3tdPYxrWbjlLBI3RB50rSA2Jthsjc2zb90mOQgG5spDMA TrdcKhBXuha0Fyo3LiRwpezggYdhcA7o2sAJ9kDntaLkI2StePayEoYBbhNErWMAtdY7X3RNbYEn +yhaHB7dJ30pXnyFxYH7fKRrc4loFlQNnbj1e6FCN23INyEAcH3v390cTXROc+1wQseT42U6A1mk cppABta6xAXD5T45DclwSzNgTXvZKFrrJfGXuDhwkEAud7pYsWSL8XT4nNcNuViAvJNhdHE4hxFt yjLZlEXBt2WM8uJCOIlmq5vdQM1b3AUAl+vWPZExrS8anJvlb77JT49Lt1UUY5xgP3aghbUGUX07 Kmi3O6Jt2nYbFaA5kDHNLgd0qWocwaSNgrDie1kRDSfULhRgx5JNRG6sydgUEjBqtayDRuOb+yyQ c2cN73VtkMgOxCAxOAHpKcx2ltnDlWyhAencITJ5gLTsEXmC1grs0tF9ksAQRE3N9h2TI/5xLBsU UY0A6TcFVsw3H3e6rA1sboDpJv8AKW5++42ULpGtud7pbpi5pFuVkGU2QafhYzSJZjz+yJrrs4Tm uiaz0j1d1bBBYNNzuEgz2dZxt7KVOrQHNGyo0rZg1x5ARAK+rjdU46RdVERYtakP1eYQTsqA3Tay Lqx/dK2BumahYJYBMZ5BTA0WHuh1fKlzq24WQU43uLJZG/umv3aR3S2tIFrair6BdgVCw22TGU8g O7HNChvqs0WUArRvyrLdlZ2cqvcICNdaPTbkqiPdEL22VnlALLdgoAS5HcKmkFyAgYSit2IuiACj ri2yAoSMYdI7oxJYFKLHMkDm7hWdyboBrZgW3Dtwjg3fcm11jMiHN7prmF7AWutb5QFzm7rXv8oi /Q0FLcNIFx+6p7g/a/CAayVxPKovcXWI290EXdGSXAoLKsL7JkI1XSXv9IAFimwDQN+6Aj78KnRN Z6juie4g2G5QyE3DT3QtjGTRO2tshkDewShHbjYBMYdXJuEIVG65I7oyHAe6IM1G7RZExxa4tAH7 oBAcXE35QiUtmYwX323WUYnPs4C1isplNEQ1zvuQ0MfQGMMe8DfhMLRa1rqSvu5pDybC1lQfY7hY bNJCXMLfwjgYSeLBGwXfunaLXHAWWzXQUf8AL25CB7CHFHGA3b/KYW6ioaQsO9NjyrAuNlRYG73V B5vtwqCywnfhETYboS+7dlLXF/ZCUFo1DY2WFUNIce5Wa13p25SQ1ridR3QpiMYSiALAjda9ghcd It7q2WgeFXCtwF1YbqBsEslCTypcFO8kubzZLZRm5sVQVpNx7JkbAONkQYWixUG3wslJqcCbbKzq eL3Vnv3Qh2llyhQmG3PIRt442WK2X17rJDjp2Qtkc2423VlxDd0PmWFrIrbDUhAWDe7t0qpIdbS1 NI1A7WVxAOuALlVEMTyA6Oz9yoIxFsDcJsgDJSDvdKefLdYA7qmGY9UQ0XB/KS2JxGsbtVvgdM4q 6eN8RLHkgfKplhtlEg024QuY1xOyMWZew5UNxcDgq2KManBE+w9IWaaXzpLNNnJEchjm0tbyuWZh jvJFSZALf03RhAsw99Oy+7vysCqiIdd2xXJ/xRs7B/SW7ELAxKobK5oaqKOLq3yUbx6vS7ZW7UA2 x3O5T66E1ELGnYhLli8qEG9zwhkqJ2p2+9kYfqda+6xqWN7C9x3CjdTnEtBugM2R5ZtZKvqYfcoG Ode7tzZQh1zpNkJZZfpbuFHyNljB02shNyLKA3IFkFgh9m2aLApIjJkJ7rKO7SABdABobvygsyKe QWAOxT7lsoaDcHusKM73Kts133PCFRJ66OOo0adRHdZEVRHLvayxbs80ktBv3RDR5e2yEsZUFzHg N3CC+h2x5CqxB1E7fCsNF/dCjGkuIBVEm5HJVkgfCAv0kWF0M9ll3ayBzSd7J7HNdsbKi2ziSduy GhBDj2VNcfdM12v7Jdh2QF+YRzuqLg4qEe6VLcCzUDDDyzgbKy64F0kFzRpPdHGLmyGQg3e/ZQ/h R50mwUugIbkAKOjAF+SrA2VAWuhqgQDe53V2DtgN0R+N0yNt0JRjOjuhdEIxd6yJGFxNilBzZBZ3 ZCURgAbccLPoaNk1wCd/ZYo06QCNlzGEPijdfgIBUmEGNt2kn8rBqKeQelosV9JPIyzi1+y4mqcw x6h9yGmcMdQ2IsQqleXM2O6dM9t9X9wkOaHbgGyGSiSYg3uj1AAbbpQBadk1rhwRugLdcjZRpsPl RgN7HYK7WJPsgL1FWDzcISQqLjfhAECN7f2StAc67jv7I7ofL1SaigI5ml1yFYcN/lFKdYBOwCRJ K1tg1AODtPCB0RkNwbfCtpDm3Rghu6ApumwBPqCW9xPbZMABN1C3TtflAABdwTAN0JaGb90QfqF+ EBRcCbHcIvsbcITa47lCXOBt2QBtJLdtkTW97oNW2yNotY3QtlmwCs2sq1XChPa10FguOlTWXtGy IWPIVOFhshCiw3CsbO3Cr2tuQi3O3BQAPGt3srAso72PKMWQqKabG4uo9++6h9I3QjflChAA90mU FrhbhN2QSnshkFj3NB9ij1lpF+EDG34ReXv3KAPa1/dVZBYtsOVbrjdAFcEISCSgMmk8Irlx+EBA 0XVhtnX7KrD3KtrrHfdAVKLnbhBGdJO4ITnW0n2KXDEHDbYIAwSW2CrSG790R/l8cIQdQ3QFuDC0 b7qAWsUBbpO6aDpHugDJ1C55Styb32R+Z3shuHG1kABNyra3UeVAy5KtrRr3N7IAzZjPu/ZJa0Dd OfbTsk6bkb7IC2sA3ULS0XHCJoP7K+LoAPLDhqBIKgha4K7XCj/Q3a6At0YLdkoxvdvYf3TmXLCS kAOO9yhaO/uvFLHh2b2U7Ro9V7FfKQOJdsF2b4rcDOG9SmtOwIuCutY3CJzSfZfmNFTxRP0GqjU7 Ga7jm1ljTTEXJWQW3YfdYE7Q11je3dfTiuT58nRjzz23tdYckxN/dZdTIwtsBwsEgPvYL0xR55MT JJraQUiKV0brA2F02SEtBKxpASNhutmbObbVCRjbC5ARtAO43K4ejqHhwaVybJHMd2sVk0h7mg8c +yBmovs7YKmOLSXHeys1glNtNiFClPk0myCRzSzix91dQNwbbpYaHtJN9kBjyv3ssWQubOwd3bLK lZcXakubZ7HEbjutIlHo7wrYmzCsbaHv0uc4WuVtx6Xytq8pwP8AM1tdHcgfhaJsAzVVZeqIpqWT RK03A917k8M3jsw/LbI8KzbMaaBwDRODs38r6OmyKHZ83V4XKNo6C8QeQ66g8S2YXVdI6lpZaovh Dm28wE8hbHvBJ0nOW8qsxSrc6LWA6OI+w7rrfrB1a6EZ8/TY9UY9R1OJUxDmE21Eey53BvHd0hy1 kSqp4MWMNU2mMcMTe7rL0SyqeR0fNxpwhTR6hznFl7qdgGJYGcQjqPMjdE+KN+4Nu4WvXpn0/ruj XiHp8LfTyto4Km9O7TcEE+6+X8NfjAwvK/UXF8Tx6uL6GqqHFkbpP6exXovGfHH0Nx7G6eesqBFV 07w7z2tva3yvbHbjjtu0eZ4pylvo7o8WWc8dyj0tkxLBNTZnizg02IFl5K6TdFc59TYafN2KU8tF Rh4ke+X73b32XeeZvqEdCcSwsU1diDcRpWgHy5Irg2XBSfU36OUGGmlo4pREBZkLGBrVyhmqG1In jccls7o65000vh4rYsPc981PTAhzTYiw5XVfgi6sYvjNDU5dqQ+rp4Gao5n8tI5F11V1B+p3kqvy ZimGUFEXvrIXRhpGzQRZdMeFLxvZP6OVtazHo5Y4Z5HyNmY0m1+BdYyS2Q2f3Z1WGc5b0c79SDDs YxXqlgmI1VA6npNJiied9buAQvQPgXyBiuWsuxYjVRPg8xodpcOQvLHix8bmVOsuOZcfhAkq6DDZ hI4PZYu3uQu5stfU36e5dym2GTDJ6WsYwBscbdrgbLjGTk/seuEZRi1R9F9UrH6JnSqjo3zs/VzS 6mx39RH4WqvBGNnpjI4WcNrL7br54gsY67Z3rMXr6iSTDWyn9PAb2Y2+2y+PpKZ9PEZmnZ4uG+y3 qcqcVCPo66DDKEnKSPs+lLxBmyn0DSC8b/ut2PhUrDJkCOmcbgWeP7LRnl/MDsEr4qkMBewh1gvZ fS76mFF06wCLD6nC3/qI2aQ5o52Xgj3R79RHdHg9E5z8QGbI/FTBlfDcYkiwxrw2SncLBwvwF6F8 TWV5c4dGsRpmte6RjWyhjNySFqKzv4zKvMvVSmzlQ4YIJ4Hh1mcvF7ru3E/q6Ys/CoqWHLRfUtAE hm+02Xu8kbTXo+N8aSTNi/S7K1RN0Iw/B6kvp5JqHyzcWc0FtgtHPiTyJjWRuqeO4dW/q/0kVU7T O9xLXAnsvVdD9YXMlPRiGfLUIDW6Rb2Xlzr/AOJqv8QrpJJMPjoZZJQ52gb2VhlpS/sqwSc066Mf orlqfGs14dRUYLp3SNF/jut8HTTBp6PpZhWH1F3SClEbv7WWgfpx1Tq+k+N0OMUdMKuemt6D3Xqa X6umcYKKOlosFihaG2Jfvp/C86lbPbmxXDg7crZh4e/F1SyZgmbR4VVzGWCTt6vdex+t2RcN8RPS mpoMPniqBUsD6eZrgRey0vdX/FbmDrnmGLFMep2NfGLMc3lv4X0PTnxo586UUbIMJxWaembxDI/U 0L6CmnJSvlHzZaWc8Ti+jYv4ffA/gfTTKGIQ5soKXFK2ZxIdK0OsLrXr9QHLmW8q9YqeiyrSxUUc cf8ANjh4uvpMw/VC6rY3hUtAIqeMSN0mVjfUF5hxTHcXz1mKXF8YqX1FXIbl0h3XLUTW1tvlnXS4 ssGovpD8uyyMA1g3O9yFsi+nz1AwylxekpKyujiqA0tYx77arrXJBIPUzYOaNrLk8HzViuV6yKrw 6okgqGOuyRjrEFfOg0uWfXyRlNUbtvE90cxjq7gtO3A68xyAgPge+0b2++y6cwbwG4XgWA1NXjuI vqJo4CfKikIa137rwxhvj4624VhzKaHE2TeW0NbI4b27L5jM3jO6y5gBbVY7JDG/Z7WGwK+ljzOK UUz4E9HkWTfRth8JnSqTIWH1kwq2vp5JXaIxzbsvO/1LOhVXmOsbnikxEsipIQySnjktx3XifBfG h1byrQGCjxYshN/UDchfH5n8RXUTPbaiHG8x1E1LU/fA92y6rMoZfJZ0elnKO09K/T0yO3P2f2zY hW+XS4fIHsM7t3EFbU+p2SMMz/kmuwCsdGYZ6csY4OHpNtiF+fvLvUfNnTucS4BiTqVjr38t1iSV z9X4rOsEo0nNlaI7WDfMIAC8flcsm5uj15dJ9dsT6/MM83RjrPV4ZWVArGYdVkF53BaHdiFuL6Kd RsB6o9JaMUVdCDPSiJ4DxcEtstA9VjmL45V1GJYtUOq6qZ13yO3JPyuYwDqFnHKji/AczVmGt/8A oxyuDR+3C6ZMzyv7M549DsjwbxeivQfL/QfHMaxZuMQWxB5kLZHNbpv8rj8zZnyl1H6sYNC3F6Xz MJl1MdHKCHm/F1pYxfrP1PxqjLazN1fURn+nzj/8rhMMzpm3DP8AjIMaqIaoH79ZBWd6tts5vQyU dtH6AOsVJk/POT6/BscxKiNJPA4WfI0225HytCPVDK9FgmfsboaUtnoaape2CVp+5tzZYWI9W884 ntV5irZAebTuXEU9RUS6nyF873HU57zckrk8zjDYmdselay+RmTheHvll1M0tY3gFcjRPdhtW6aQ 3Ze5AXHxl8bbtdZZrnmSiIA8x3deXcz6ypcI2ZeA/wAWmVMDy/HlzFq+PDySA0zGwK9OZ1/9IM9Y 3h+ZMax3DXSUQuwuqGgH2v7rRKyija0OcZI3HvEbEI6ubE3COL+LVj2f0tfK6wC9ONpK0z5+o07y UblfE74s+neA9L5cMwXHqTEqmQiJsEDw7S35QdAfFn00wjphHT1uMx0FZHF62u2G/stLU2GVbpCf Pc497m6uSbE2wOgbK58fFrldHkio7DlDSzvczcj0L8TvTHL+bMfYM00wp6+czGWV4ALt15H+p51y yf1UxHB4cBrosSq6Z5AlhdqDW914UiopJAWyMkjN+WuT3YQyNgdqe9/bX2VeoSuS7ZuOjS2u+mcl GC2VkreWsA/wvr8l54xjJ2I0+IYfUyQzxODmOY6xBXxNI2Rg3dqIWTC6Rz/UdI/K8ilfJ9J8m1nw 8/Uey3iWVYsOzrVspsRpm6HOm/qAHPyvvca+pN0Vy5TznD60y1JG36eIDUVplqMNjry4vu1/+8O5 WKzBo3S6NWu3F16YzhVM+ZLRty3RZtu6afUS6aszBieMYxUEVdSNLH7BwaOy+d8Tf1CukHUjp9iG W6aGbEJ5m/y3PbZrHe/ytV4o4onva+n1+xabWTMNwR1TO4bBg3DXALflhu3LsvxnVM7n6KeIXEOi meoswYUXOpmPJLONTfZbAcu/Vl6b43h0YzHg88EwbaRoYJBf8LVXJEyGj8s/8wG1guPjw/1Eta1w PZ4uo5qTuR0nguKijal1J+rJk2gwJ9Lk3Cp6iZ7NLTINAj29rLyl0x8duZcj9Sq3MbzO+jr3F08R Nxz7Ly5Bhoa/VKAwfC5J144iYgws7ghFqFBVFHJaKL/kzZJjP1fMMp8IdHRYGauv02Dn3aAV4M65 eIXM/XzNkmM5grHGLUXQ0zHEMjHYWXxAp6WojD2xNEnfZUcHEkb5NQAA4XP5NKoqi/CW/ddn23Tv xN556S0clPlqtlgjcSWuudir6keKjqb1jwuTB8zY9LPhjvVJCdrrrqkeIZS0i9uyQKhrcRkM0Jc2 QWbbsvLuvk9jxRZm4MI3RsDDdrNrLk62BtS4P1eWxvYd1xVNSGkOuEbeyyqiuMpawsLSeVLOqVcH KYTnCvylXQV+F1L4amIgtdcjdersl/VSzvk/AIaCqw819TE3SyWU3B/K8e1DoKiMRSO8oD+oLHdA 2C3lz+a32IutJtOznkxQyqmd0dc/Gzn3xCs/h+MPbBhxfcU0WzQuJ6V+KDPHQ2qa7LmKSRM2vTOc Sw/suo/LcZg4NDR7hZJaNepw1fld1naVHlWixr0essyfVH6wZgwCpwuaKhhbURmIzQR2eARa9wvJ suMVGJ4xJWYo9880ry9zy69yUqWlbKD6tO/9KZHG1zAx3bglbeolt2xNR00Yy3NHYfTLrznToFjn 8UyxVF0Mgs+B9y0j+6+u6v8Ajm6idcMLosLr3x0FLB93lD/mfldJmqiezyZb2HB9kh8cdKQ5l3tv 3XKORrs3LTwny0dmdLvEp1A6H19VU5arXeXVG8lO83YT72XPdQ/HB1f6k0DqLE8wS0dFINL4IPSH A8hdQ/xGlqAGOiczblRlPTcEmRvNnK+SuS/Hxv0czlrqRmHJdfDiOG108FS03DmOIuV2gfHh1woI xBR5qqqeEj7L3uumJXxyMa0ttbhYsoc42DyCq87fZp6fG10fbdRfE71S6qUYos0Zhqq+kA2jJs0f 2XzuSutWeum7v/2czFV4Yf8AbG8gbrg3skN72I/CpkIZYlgJ9rLMs8pKl0IYIY7aRyvUTq1njqxX wT5sxqqxZ8f2OmfcBcPTxthia43Dh2909+qUBtgANxsskWcBdgK5ubao0oKPQvCc043l+oMuE1s9 GfeN9iuWZ1Vz/wCeJnZpxASdnOncbLi/0sbnfajjpGNN+bdiik1wjDxRbto5rG+qWec3UIoMazJV YhRtFgJZC66RhmY8wYNEI8MzNXYTE4WdFTzOa139isB1Mx7r6bX9lG0rQTyfhdvkyrairFD8G1GN 4/UVf6g5grqmoH/u/qHX/wC6zaTNudYjaPM+Jsa7kGpfx/dYEUTItRYyxPJToZ7SXNwos1cmfBFi 6ufEq+WSSbGquaZv3O891z/lY80VXXwsgqMTq5or3bHI8lo/Zch5MDpXFrdn8q5ICS3SLAbBHnn2 mbjggl0cDPQ1DZG6aiRuna7XkJMuG1Ec7HtqZTJf7y4k/wB19I6Hf1NH5SywjtcLl5JvtnTxxXo4 OfD5poyaqslmd2DnkohROpmRvFi0G+kLlSW6vXHqSKiIPmDm7M/2rLk2FCKd0XHMJ27ttZY9TEyr laCdIastrA0bBKmpnk+lZTaOnBh1OFUz3Ahm/fQTukSYNGIi6P0H2O+yzzTuZGbX1JbRLbd110jl kuERpPtHFHCmNduy7bfcDZV/CxoBBfzx2XMEEixaqaHNPGy2803wc3CLEUFJIyV0b2hsYFwfdLfh pEpLLBp5Y7dZWp73fdZEadxIc524XFtt2zoklwYRoIYZGulp2PaeQNln0tC10x0hsdORs210h8Ul TJYu2WUZBTMaw+ojgBdPLOqsztS6F1OEUkUvmCNrz3sqiw5pc0vaIWdmlNL/ADLEA/gqpp9Zbrud PAWXNsOKfaGSuZREmBgNxYlIM7oRqY0782TfMZMPSCFA3Zc+SoxYdDy5z2Xv7pX8OE0t4rN/+1us 18er4twgET72bstqTRGrBZ5UILH6S/3bsmmnbLYB1m/KX+gbrv3PKb5Whm+635ZEUUvQApQwOYQD 3BSm0Ljw7T7XXIxRB0bXFMdCHdtlhs2kqOMYyQPDZy1wHBaLJ8kDZntfr027J0cIe7jhR0NjZS2V VHojHU72FkrbO7OAS2SGJ2nTdt9iUbo9lYiuFpSaJ32ZJmhkFpLbjskaY2EWJkb7OKuOnBIumCIA qNuy8Ffe0ADSPYKeQGi4vqTARe1lHkubYbFCGG7zmyvc+xJFrkLjXT19PMdLbsJ5C50A6LOOo+6F 7Bbha9GaOFbG+OXzXjZ/ICymyCna4xEguWTLGLWWOItHdYZUKbM6b/mncJ0MohvZmoH33VeQ2x90 TGlosBssWX/gbIYwQ6NgY48rHfDqcXclGXNbyqdZwB4VsgmoklbpLDY2S2VE0rx5zvTxynFuo83K F0Gx3WhbLfK6Egxu1AdkEcz2QyNDA7WbkFNjYALFMba9rK2BTTqcD5YYR7K5o/MFwAHJui//AMqE i3IUIwIZA1tnx2I7pNTqmdc2t2TC8Am9iUN9R4UILEVO5vrga51uUh9LHN6bFg+CswR87IgwX4QI RFCYhZjjYd01kxhkBbs4clNEYv8AChgDR7rVlobJVB7gLanFPjJLdxYLHiY1u9t1kGN9vyqVBOhj e0EDdA5l22GxRwsLBud/lWRq/HwrZpggPNnOABHFlcv82xcDdL1Xd3TRuFBZUb5QLAkBX5e253RN FjdU4nkFCgug2+EBgczcf2Rea4HcbKfqdV7bAKMjMGWB973WLJTuk2I2XJyO1WISdOrlQzRhNg9N iOELqRsg3Gyz9I/Cot3+FU/QMKOnEQsOEbYbeyyC24KAjS2yWBJiHuq8u3f9kaIC+yAToLf3S3U7 Cblqyy1AW7qURmK6EEgAWCyo4m6BcXCjWfujZcApREF+niuDYh3wo52l1uVbXENJcN0km7jfkqGg 3FrhYbFA6ANbqcAUTWNZdwNyo7URc8FCUA2O7bt4VGPfmyaHWFgrDde6CihaTnZZUTw0AbFYrh6S Bso1pZpshDNc63bZARdNjILLd1GtOq3ZC2Y74fMtcpb6dwBc3kcrLey53S3auOQhRMfrFjusqNpa PTa9kDWWcLD8phBvYDZaFFaC0F7je3ZU2Vrxshmp3fdq29kMbLA7FQBPPFkt73D03uFkREeXYjdA YNbrX4UDMGTc77K4xa5TaiKztt1js1l+m1h7oZApi51RZ+1zsuXq6chjRysWGja6Vrnu9LTe4XLs mp6gaWm9u6jNWcGXeS/cITYjdZdfBokPdYYfd1j2WQTQCUIbd23IWTGBK8bJtPE1s5eW3HcIRGO6 MFm97o4YGltybnss54ZJu1mkeyj49DbaRYqM3Ribse2zbg8jspJI4TgMaGA9gshg0P0lv4KuNtpi Htv7LFlKbMWPDXb/AITf1TQSEwsa11wNkBgAcZCL/ChS3sFQzc2KB0JEQAPHdUHAuvx8JlyR8IKL hkPlADkKhve5Ua3SdioXWC0KCNrWISHensngXFyFWjU74RBCNj+UcbdXCjzY203CsNLeCgoKw47o g0ix2VAgbnlEHB7t9lAizGXNHa6IARttyraDc/8AZU7j5UIU4A39kId5IIAvdWRshkZqCApr7nfu o4tBtwUpriCm6NRve5W0wLl9Lb9kogyW2uFl+Vq5slyNdbQ2wCWShTmkMtZYrwQRcLKlc2KMB79J QvjDA2XVrbzshKMWpgLYw61liloHJuVyFVUfrYtDRpKwo4/KBD27rSZloU4NcNtlikkyaWjdZ4hJ FwksgcyQvO3wtohTIbgX5TQA3Y/3KN8VmAg7pJDn8chAJkLpHFobdA1hLiCLALIaCHk90bADck3Q GKB2V6biw5ROOt/pCMAHe26AWIbWB5KB9KAC4Jrn6SNR2QB95NA4PdAJ0aOT+yuNut1twEUsVnbO uFbGmNuq1wfZCUTy3RNNjsoyRxb6huqc8l17qNk1E7LRRrSHDbkKF7r8IBu24U1XF7qWSi3lzwbb FDGCRZ23yibe6aGjmwVsUWyKzLXvdR0ZIt7IWP5AViXQLX3UspR0htgN0Bu5tjwrHc9vlQPDAPZQ CtDBcgKrB3G1keprSS4XuiYwSHbYIDj5idVgELW25XMRYR+qks14ZtyVxMwMFYYH7u4BHCEZRFhu h03CbLGIranIWAFDIHlbbqtJDd+AmvFuRshtcewVsAg7BEUNrKwrYJbfmyNouPdAeeFGPLXbBLNW EbBEbEKizlx49le2kEcIUosDuQqIsrJI47qb3QyUCqRkCxshadX4QhTSAbOTGhtvhCXA7WUsO3Kp UWX6TblXrb7bqrDTvyhFroGGSXCx4KJrNIICAuuQVeoAcqFQbRpI9kQlL33vYJReTwrZNoaRp390 FmRK8Gzm7kdwlF/mb90qF5ZqB3BRsvf4VIND3WsgNLraSdwge8jhAXSWs11iVllHMjOmxsgjPrLF cTnFhDzdyCIES3KgoyiNI3RQxNmeHaRbuVQcTfa6yYHMZGb+n3VoGFWRMilBiFx3WLMbEG1lnFzR rAFwe6xHR63aUZGIJuhEhvsU4U5JNjsFUlNpsWm47oioOndrLtW9lHND7/CGIui2t+6O4cCRsllB sLBWDY7qROaHXKa5of6m22SwY7byOJPHsjcANioWHi26LSBzuVQJO7+EyCn84l3sluJa8+yOmmdH qtweyyDObTNdEbOs72WBKSXcabJsch1ar/sgqAZZL3QC2kAbm6IC/wAJb4nXHsoQQUIOEwYbWVFw k4KDQHtNuUvyyxw3QWMkc5rfuJ+FUOoi5Cos1Ao2DSAEIML9EZvsUuGcNaQRclEWh5s42QviERDg 69kNEL3hlidlI5SL73UcDMNR4+EAAaRYfuqgOYQQTwUvbUdQ3TGkabW3VOtzZGBbhcqN3FhuQhkc QbjhVRm7nXUIw7E8ogLKB9iQrQIouHcbq45hTuEjRqI7IHHdU19iDYAoU5UY6JI7PhANubLBdLqe XAWUnmD49wLhLgaSwuPAQAuuTdCdhujLgb7Ki0useyAtm/Cvh26IMs3ZU4HiyAmhpubXSmgg7iye 15btyFHOD9kALTtyjB9KVpIarDjp5QBagCAQhc65Qm7tjwiBQFFUS4N2TGQlzS88JcliPYBAXqOj dA0knYKy3U0AFNZH5XPdAXHbSUV7jbhQAEGwQtG/KAhARsJsD2SnWY65O3smRAyMcRYDtdAG6w9S x2yE1F3cJkhHl27pdJC+5LhcoA3OBmLW3IKbDH5Idfsn09KX3cBYhDIx3mWNzdAVDUg3AaoYXl4d wCshlO0AGyYWkkb7IVFsADAEzyrAG/KkbNNjyETmuc4bWCy2bQJjLd1BqPZZMcOkG5QNiJBBO3ZY Ngt2O6cz1HhL8osF+yZASWm6yBrrRtA5UJsL2ULC4W49kDnuZ6SL/KUUU6z7gEgqjdpsDsoQATvu hG3JuryAtmkBE48AcIXAuN+AiDg6wtuqC9Onfusdw9QPdOfe3ukajr42QIuW2nbZDSM81jtRR6gT Y7KxsSOPwhsVIzTYDhNpvTcWvccodIc6yeweW2wQtCb2JBRG502NgqlsPylN17EoQN7XF97bIQ27 gDwU8na97KgW6r9lC0TyNDd+6U+ned7XasmUFwFirElmaSeEFHGviLXXPCyISCwgn8Iqloduqp4w QTcbKmS5G7bcqryX9ViBwmOtINuQiLAW87oBGohu6jHE8Cx902ZgDW2VNJLQAEKU6NpaSDcjdKc0 PbqNgfZPewMBv3SnRtFghGhLIw1Y9WzUbk2WVISCCNrJErS9hv3WjDRh3MgDQeFbgexsVkMhEdmn upLEGyWHtyqjJgsmdGdxeyayvfrIc46D2SXEMJ1K4I/Miv7laMmVUSM9Bj2vyjp4A99yUgMDNiU+ GQeaCQbIaHytaAd72WBK0Elq5CZokcTewC42ZxD7AXURmgGt8u4BJuqaNNymFp0oZGFjLnhUgGpW PYFBH9pI7JbZtT7cIZHG9rqg5CSTuOFACRsgDa8OBA5Qk6dzyoBot2RktNroBfnB/AULwbbWKPS2 xI7qGIOiJshoC90Vm2CsN0NQnmyGQiPSibJ6UBJ4QAuvbshoNz7lFEdL7kIY4/UAfdWXtincw9kF Fvvr1X2R+qVu24QeUXkuHCLUY22abC3KAEOOnfhELFA1/pIPKtvpYSgKe4NNuAlSk7WCt4DxuiD/ AEja9kIwTGdrpzWBu4VFwkAttZQkkWQoLzcqAqhuVNJBvfZAEbna1lRbaxUfd/ChBtugZQdfsmxt 8x1kLXN+0blXoLQT3QBSARk7hY+kA3TXeobqpGao7DZCMjS17dzwUTagRO0gm3uFj+UQEzSNAsN+ 6EHGuduCTZKknJYbHYoHN9fwhf6drXShZbWh7bE7owy3CFrSW3ATbDRcbFAKcN9wgG0l7Jhie71D YBC9hJB5QBu9fwquNBCh24VANabnhAU1uoE+ym5ULvXZvBVSehwF7oC3Mur2ba6E3cQqcCgCeR7p GxdYNsEwN9W/CFwJvbhAE1tiQUVrDfhLsQQbpjG3G+6AoGx+E3zGhvG6rRtxsq0NvsgLcAWbpdri w4RkEX2QW08oCF5aR3VOudwo5p5twow35QEAIKbEdt0JvYbbIXlxs1o2QDBEfMLj9qIt32QMnLjo KMWaPlACWuJRH0hFbeyFw3sgA4citckqgy552CIg224QAtBuiOysWa26hIfxdCoBz9W3BV/0+yox 725VhttkFlG1rFTQCd+ERG6F25ACBoJjQ08InOAB41eyEEAWJAKoMs/VyUKigS51iLfKsm5Vk6ne yp4NxvshGVpbexU85pc5gb6h3ULgEGj1XBvdCF+l3J0/Kgs0+k6h7qvQ5jmnYqRsDGgFAE4kgAhE 3S1pb2Uc4EccIdOo37oKJoOm3Kpg3tbhMvtYcoHE8IAn8cKMslyPJjtwhY+zbIB0mwuN0LexV3Lm 7IC4BpHdAE+RsIu69irY8PFwELGhw9Vj+UN7OOlAG7m1tlALFDq/cogfhAUXOJAB2VPu3g3V7KFu yAsAi3yqkOojZXfZFpvY9kAPEdhyha2zRdC9x1ajwFYcDvdAexPGvS//ALc00sfZu5XRA1TtY5o2 avR/jBgZLmsgj1Niv+6830Mxkh22A2v7r8b/AI2e7EkfqNdxOzkL6mAGwXH1kWo/A7rLift6rlIr fsuOV96PZ8mS4OHmDWXSLWaSE6pbsT7rDifcFu916zysc8jy/UsZrhYgpjnmNvqWCam8pHF1SGZA GOl2WbodNwLWWJRsa31clchHM1hv2WWaQVPGQ0ghMFGyJ2pysTh2wVueS3S6xChRM87Gn0jUsV8p eC3j8I5Xhmw7oNP90AMbgG2ckPf/ADACO6dpOrdU9gc4GyEsXVQySlr4tnhC+GeqGiZoN9jfZZ0Q N9junOD3CxG49ltMro+fnwCJjwSXkc2BuAh/g0EjtWt1mn7SudMZ5Av+Up1MZNnen2VTa5TOeyL7 MQYdEbMLHC/DgVG0sFPrjewOLv6iFmCnkA+/b2VGAuG4v8rp5JEUUukcc/B4WuuA5zTuLFAcKc0k aGkHfcbrkmxPB249kwxkgXO61HIzEscX6OGfhkbh/wAvS73umvommm0GNshHFwuTdDe/slugsO6r ySb7KoJHC02Gl4JDGwPHss1rXGLS2JssnGp7U90bvZOhBZ+Vnc2a2oDD6COGNzaiJvqN7BOq/MeA 2PZoFgETmPlJsVYNtnG5CjbNdGNFTujs5zjrV1mHRV0d3aS/5Cfs+4QvZba+6u4y1ZjRxtip9AaG yN7tQGGaoH3M27OCyPL0nfdUYQ7cbFNwSSOPmo3SOJfE2/u1KpaU+ePLGkdwuXbEbc7fKjadoNxy lsNJizRR8uJJ9rpbaWIOPouPkLMLPSLi/wAomsFlbZKMeKmhAN2Aeys08b2kWFvYrIMbXBQRWum5 2UxKWBtPIXBgcR2WVBH6nPtYnsr8st3BCpkj7kAXUbb7KhrKcF4cXIqqctGm2yjH+kkjdMAaWAv3 KXRWV+hfWQavMLCBy1JhBDiySQuttZyyYK4lrmtGlo90ltnSF5AupuZKESRNc/dv4S5qVrhZzfws 8gbbJbmhxKu5shw0lGTINTjYcbpjI2l2h8hA7XXIPhBCTJRNeQSVbMsx/LdT3bcOYVbPQSWjYpz4 SBY8BL02SwASWMOkKMlcGHbZHpt+6vSG7WsFbFsxWCN8l3M4WeZYhDZmxskyMaeEDtLRZZIDFI6S Ty+3us2O0ML2avUfZIbHZgdwSq02de5uqCNMgkAe+7U4VL9QIAIHBS3va7vYrDZO9s5aR6fdUHJi rdG4kx31JMlQ5u7W7/CISXbtumAtIAVKYchfK29rO90TInPHq5WVpb2Vj0qEMPSYybWQPY6Vukm3 4WXIwWukhvqCAx44nN2Li4H3TA3yb6E9zA2x5Q2Dz6UAG7re6NgLHgk2/CIN3Fgiv7qgLQJDqIuq exzQPLtdGJdIALbhMYRbblVsGKIHPJDyT8J4haxlt03+q9kNiVkACFrW3GyS/W5pDSQPZZZcNG43 SJBwUBhwUeuo1OFg0XQOmjkkcA0XBtwsyslf5TWxixPKS2k8qJznWDihaKY5wFgVNGt1zurp4rsL j/dMLLbhCC5YhILEJbKa3AAWSQpa4NkBjmL9lHMAHKuSQh1lIyLkE8oBflmyrSeQOE1xDSrDNQ/K ASImkXtdWGXTzEQ29tkOm3G6Ao2aBcBZDISY9VtvdJawG3/lZFReSIMYSwKgU5vAshMYJueUxmw/ Cp17qGwDECqbTgbpwidI70nZEYXNAuf7KUSzH8mwvZMDOEdjdQnSLlaRhlNsCi1BrrWVEF7QWo2B uk6uVCFggm3dMa0XsRf5S4pw91g3hMMw4tb5Q2GIgVPJvtpCUyo0u33WU1+u1kAlzf5YAFiFGOcA LndNcwu4SXse26FRfm+q17p/lkNueFikEWIHqTHSPA5QWKmsHcrDcTqLjeybUvIIPdA27wSUMlNn abaTsjfMARv+yQA2O9x/ZDG9pfqIugMlztVjZAbX4Vl9xfhASgAe623CEvFkVvVdKltqNkKWCEL3 ObsXc9lbBY7jZXNF5hBabIQASabb2N06M6Zw7Yn3KxgxznccJtM+73IBsshMxAbygLCHfKcAXkg/ 3Sze9roTkKE2vdMQW0hWLDugLUvte6Bx3uo31Gx4KFD1XPN1D6tlCwNdYboXMLXfCAyWvLNLSbhM ZNqNuy4+Zznj0ncIwS1jSD6ihTL8zS82G3uqJ1OuEoyO2Fldy1wt9qAYfZEwE8oDa4IKZfQN0AbR YfKHyy431IXSBrbq2PD23vZC2JJe2TlOaS0boCNTxbcK3G/CAJzuArB1fKUD2IujbftwrZAZBe54 skWIHunP977oLe6hBbdiVTj7JlgEJB7KUBLowTykyuMdm3uFnMjEjwEt9IPN1FKAEbCG3RaUT7sN lL3VAst+UQ2UIUtZqAl7XKSN3lOVAC6AQYwTzZExrgbcppbdWOEBQBCZosUIBO3CY0dkFFtYAdk3 SCwi26G3urF7fKCims0N35QvqntP23Hurewnk2UdZ7Q1aBT7VIDS8x/hMgjMQ0a9QHBVCBrnCyaG 6APdAR2nbaxRN2CAt18bIo9vSDwnYLuQgIdqvfZE/lVvawUZpFGo9ehzdlHNY6+1lIQDLYkfkqqs 6dm2NvZQMUWFoKEWvumNOtlzygICGStKFzduER3Hwq02GxuqDHeTewVPY4i/YJj49Vj3RRDkHhES zG2P5UaTdHKwMfZqFoIVZAiSALqr77q3bAe6snWBtaylAFwsrjbY7q2N/wAKzb7ibBAW4BDpBbfY ITMCbDce6Q0mR5FyASoUy4afzCbm/wAKqhliBxZMp6UU51tk1X7FDM/U49yhbMcc+6trrbcKuXKE HUgGRkOB2umNG+4sEgl4NgFkse0ANcdygLaQ1w3umiWziLJTmNIBad1AQ07q0Aw8hx1cK2+o34VE g7KmE39KAYNijLrjlJF73Khf7KANxJHKIbMsgj3REdu6AtoDW7m5QyHU0i9kbGOcdhdGYWnZ3KA4 +ojeCHN3WRGwPZuN0ZbpdZMiaC4k8ISgKaMtDtXHsmxNZG7UwWTy1rhcCypsbSLW3WGzSRiubqkJ O6UKQEl1rLP0AXuED3arNbwO6lloxoIdILrJ0UGkk25TTYNsDdObbQGjlRsqiYxYHCx29kE7PSBq Nx2Tnwm4Ue3gnkKFoXfW0XHqCFrnuNjynFlxcq2gDfusmi42GxJ3VCYbtI2KPWBsN0DXBx3CEA8o Bw9lAwtJ+U+QWslkm6FBaPfe6J8RIFgjabccKiSCSEAIbobbugAuCrLz3VA23VsFh2xFlWwRHc3V G9ksjBc0Ec7qi30ghE1pBJUFySFDI+KTSwXFypJbkLGZdpNzdGZjayoDbyoSCdwoDccKy0kWPKgM dzLHhEzuTsUZGlpvx7pYcNVud0AwktbdVq1cixR7ceyCR2vjZAPp6GKvcI3NB2vdYrGshe+LT6GG wRMklppNUZ7IQSSXHfUblVAXPEDuwWKwaiOS2kbk91yoAdwrliBYABYq2Sjj46Utg9Rsbdlivsbt JuuXmYI4Bq5Kwo6ZmoOG63ZKMEMlBDTx2RubZ9u6yKolsobayQIyJSXGy0mZoE2Zvyh2DdgikLO2 6NgDmbhUgptt+x90LG+W07EgrIazUCbI/sG4uEBgPpg8XJsEbqfU0NZz7p0hD+/7ICHMaSBugFPw 58A1OlDieGjslMikabP47BZgp9TfMv6vZSRhe4E9ggMN0BP5SnRvjFwLrOjGtx7WRiMMJubrVg48 hxFhsq0uAWY+DfYpQj9egG7lAL9WxtZMDiBueU58HlgByF0Q55RAx3OtuCiYQRc8qGMtNlBJ5Ttw oCCXV2UJCB8wlHoFreyAEuCtAM83RMJaUv7e/KNz2gDsVANje4NI1f5SZ9LmutYvHdY89S1jhpN/ gJQmsS4clDLFhj5g/UdwjijcyGx3cmOJDLgWuij9Lf5huhBcWq1nndWeCiNrqu9laAtxvt3VhXps b8qAfO/YKAAgk7BCL6vYBZEbXN+4BKnDrC3ugCb5k0ZIBsO6jJ2SN0n7gsmOaT9L5cTAS7ZxSG4f +lAda7idytFsoO7AH8q7jg/3UfMHGwFkq93HZSyD46fzSbFWYixpBFvlJZKY3enZE+Zx/qvdLBGb /lWG3dzwhAuRdMFw64SwC6wNjsobHZR2ngqyBbbcq2AdJGx7pbyY7clMcDpvwqtqKya9FtOq21ld vUQhJ1GwVMOl3ugI0/zCEy+g6e6BxGq9kbWl51N7dlopb7sHqFkoAOfcOsEckhlFnf2SHN8twQjH h1g4d0Icf3V3IaDbdLdvweUCHslkANjsmxzam3cLrCaH8ApkTZLHVsFSmUZW+UWgWusX1+Ze2w7q g8sdZEyV0t2WsssgbZBYgmw7pcTIwSYnHncFXLGGxW7qomlrVUUP+okqnCzfhMaLA6hZSQRmO7Tc qgSGammykJ5HsiiI5vbsnSOZSRF+nU5QFBwMZ9wkeYXWuoKvzYzZtiUAJNlANfpFu90JYAdkJAjN jumtiMps1wCAHyXEbKNiIPqN1bajyyWcv90IeSTqG6gDOwQuJAJQkuLgrcbm1tjshAWuMjbjYdwj ADrIxG1rTbZJLrdrhChSRhnBuhdd24RCxAKsc2QFAbKOaHBTRvyqsQgBbq47K7WPsrsb/Cp24QBj 7kMu4RMcNG/KVK4k+wCAWz0vDTwnkNiPpHKQSSLjsijeSLkXCECAIO3dXpId7qy6424Q3cTtygLa dD7kX+FH+t17WCN7AGgnlL2KFBe3UAeyyGSaYSEkizNhuqaToIOyAZTAEkndG9wabBY7BpBVkj3K Ac5l23v+yWXFo2F/yijfsBZM8vU025QCGyI3vDh6RYqnRb7qMAbv7ICxcs+Us3umm7lC2/HKAWrI NrIvLN1C3RwgKD3ENadgEyQMLR7BJ/q4RsAPKAINBsVZBvc8BTRbe6cKe4vfnsUAkgi+/KoAl1hy sgUxb8/lXHDp1G1ygMYgahqCt8Ti7S0kNKYyPUSTwFm08bX6SNz3QGCIiLNsnhjo5B7LkBTg3NrF JMRLh7KFoBznadjb4Qg3t3Kf5F3JrKcaibbKWWgYo7nuikhJbsLIwSwnbZRkjzqBPpJWbNUY8ccj HerhZcbi/c2sj8kyNA7hR8OgC6jZpIst79uypoJuf8Jjm7D2QuOgiw2WDRURDTd/ASpHudONIs0p 1r88KxGDx2QBBwDbAi6F4OxKprNJ3KKa2kAG6qBjlvJUc0HdG71WHCA34sqC2+ppCAnQ5FYtshlh JOq6poIuNtu6Fz9Lh6VGgPi27K23O1roCSM2D0LTqddFqJBBCBvHtuhRjG6ZC4g2KEzNa4jlMdJZ thz7pQs524F0KMvHYEjdC4tvtwVUg1DiyjdwLoKL2PKF0dyA3sit6lNPcGxQoPqZyoGC+/BRObe1 yo4XNuwUIygGucGkbJbcPYXOLnlp5ATZLAekKargKkAY0tBH+VDcNtfdGA577NbdBO17ZAANu6EL Djax4Uu5rSQFcu0YsRdXHcx3PCFsw5atzDd42VNqGvPO3unVEAqIi0HlcdU0z4Y2hpsArRGzNklF gGi4PdJdJrPFgEFO/SwAqz67kj+yphhEjlBKSGk23sq1amEAbhIqJ3RuaBv2VMmMCycOa51nBSjm fHMIT6h2KMUwdLrdtfsmWa2YANt8rRix033Wshi1Md8JzxbmxKGxF/ZRlsQ18r60Nc7+WeUshzq0 hpuL7I3gk7GxTW07jCPKNnje6IGTNStYwDV6ishmCtlprmYA82Kwm0tRMwOc71DlG+R72gcWVBh1 NKYX2BB/CT5YbyN1kOjc47Eomx6RvupZKMZrQLgjZEGljjZtxZZJYy24RCdjBctsFQYAOxLhdMig ErSQsqcRFt2jdyS2Mv8AS1+gjhAinU+htil3P2jZVKXxP0vkD3HhQB1/VsgI4+6FwPIROtsrdbRt ygopl3n2WQ6AMAuRusZvKcwho9Rv7XQEjYI5Q527QsZ9nTSPte+ydUO1NsDulSWZSgN+9AFGX2tf ZW/YBpNyqhvouT+ypsbvMuftQFWLeVWonbt7J0nqffsqDRe9kJyLIuwW5S3NNllaRovwgAB7IKFs ZtsUYs1SwYpYu4QUBp3RBu6YWBp3KAv3IA/dByTdpIHCtyrUQLd1QG26FLAs64RN1C6EBW24uboA XFw5QCRzjYiyYH3JvuFC7SbjuhKIGkAkoDsQL/lEH77q2RAi5QlFaQoWi6jiRuN1Ru74QFggNsmR gEJDiQEQcQ1ANeTpt2Sg0hp3UB1nZQs7/wDdDVEazbZCW7blFYgXS7E87IZLaQHbBSQCR1zyEbAG oXC7r9kBQFwLKy25F+UDtWoAKiXtN3BAMcN7BC9uwCIudYe6Hd7t9igFhpv+FkRMuN0IjtcORNFr En9kBTwWnnZQH4RO3G6FosbhAUbq9iOFHuLTvwqAJuRwgDaO5OyW5lzcI92suUDZC5pICAvXpKsy AHhA8EAEjlWY72tugIHNcdhY+6IAg3Vd+LIrbDfdAFqJG+yEHfdS4A91ewO/dAG1rXO23CkrCB6R +UIlEZ9O6cx7Sw37oaEtb6Dc7qmjSCFTgXOJ7KwCAgKcdCtrtW6t4BG6p4DG3QUWSLG6WSRwrB8x twrBsdxsgJpDmgnlVq3so9pDrg3BVm3PwgsoXJUdf3VC2/ZWCN0AO+oX4TQbO9ISz6SL8Fclh0EM zw18rWflCGC+ifp12O/ZCIyOSLr6SaiAj9L2uA9iuJkph6i7shTjwLm3f4RhtuyuIapthYBWTe9k AINrkBVpvYqwSCoSShLBcNZV2DGX7Kw0uPNlCNTbOQditbw27Bcq4S6QEPbYq2mztI4CO+5Qglz9 Dw3lWXW55RWHt6kue7d0BNQRXvxsULC1x2RhgBv3QF//AKlS2oeylrcbq2m+190BXAUfKI2flUbk 2Quia4WJN0ALR50JF0DY7CyqGORryB9qcRugPbvi+GjH5apwtrj0LzZRx/poYh3fuvWPjNwlow2m qR3dYleUGbYhAzlrWL8N/i5Lx2frNdFt2ZjmhgF1jzHUDdZzo7g6uOVgV38tptwv0UHyfFkcVV7k NBWI2IM9SfIbuvYlKjk3IIJK9yPKxE413C4Wop5WT3AuLrm32DykyubvdUg/DftDT7LkhDqsbWau HpJS13O3uuepwTpDjZp4WWaQj0teAFT33OxQPJbVSBou0HlEWAPBHdRFFvh8z8q2x+W2x5R6i1Ll fcar2SwU5u9rfuhLCD7/ACo6oL2WA42To2vDNTuEslFsaIyCCsrVe3ykx2kOw4RtGs/IVQZYA/ZW WX7KywgK9re62QrSPZAWjlHdDcd90oC3MVWCKQ2Fyga4OCAssBZe6U5t7+6yCLt24QOjstAx9Nxv uqAsfwjsdxxZDayIFsJ3sbK/J1O1I2gEbIuO6rIAGhvCF7drptrqnDUbFQpjX+OUbG2N7o9LWOBt shcC6T0jZVGWWbD8XVaQB8KPY4c90FW14LNF7AbqhDdQczSOUDbg2vspTNJiuRYowBflChtb8qwb FU70tugjk1m6Chpb8qRM1bgW3QgkH4WREDZCjf0jnMWPNTPj2Kzo45PLvewSakOay99+6jBhinuL g+rujbaNpB3S2uLXHflQPJcQoBjJA4EO29lQmY+QhpQFuxQiMCxbsUMB3u4qnkavZXc88pMjHOlB 7LQGFl+UmRo44WW54cBbkLFla+xLtkBjvIDvdC8790cUZfJxe3dPkjLBqLb/AAtWYOPFT69I3UdG ZNzdre5ThLG9/pi0u7lOaQbscOVQRr4nQtbGdVuSoWlrQjigbBcNCGQ6XNuCRfsgAdTiYXad0Jaw REOFnBN87Q8CMflSWPU7fgoUx4btfbsnWsb3ViJoIIKhIvbugL8yx2GyIPLuUOj91ZaQhCpTa3sV NO/CA3e9oJ4TOHEIAWs17E2QF/6d+kbgpr2EiwKZE1haLtuQhQGus29uUJsRdOldc7DZCGgNJ7+y EFm+m902JxIvwkyH9lCHaRbdCmWzc7ORFu6w2te2xPCyPO0kAhDRTmkusFCyzTfn2VuJuS3lL9QH q5QlAyNEzdJJaexCqKn8lul7zID7oi8g8XTGeu2pSigMADSy2yWLMNidlkCwdZIqgGG/IVBdu/IS 5C5tiG8o4iXRD2RMJ3vwhODG8h73B2wCNsN7kDjklZBddvpG6PWAyxFiUJRhOj17BX5JYAQU7S1z uOFem17FALJc4NZxdGYBCS29z2KsN1bjkIuXb7oKFNbZ1kZJVhg1XKuwJ2QANZpddWGBxujbGSbK ywgkDshbDa0NbsgdvsiJ9AtyqG4uhkG1lNIdzwisSppugFubpGxsfZDYl/wmmME82KMRuBuhaAjj 0C/BVSm5tZMLnAbtulu35FihoERi/ushl2kb2Hyksu1wPsnFxJuUMBF5YCQUtkrnk6mkJrZW3IcB 8IHOuSBwqaRC4fsgcWOsAVAy4VCFrTe+6hkGWNsltwClFvljdHI0G9ufdLaNezhdXgAFofG6/KWx oYy/Fk5rtTyy3CN1L5zNN9LUQFg3bfsgcLi44TXAAaQdggP+1aAFrpbo7OFuVkMaGnfdJYwmd5d6 R2UBG+rkI7NAtwFLgj0oHE24upwCm31EtFwrBDeG7p0bC1m+wQtkYxxu3b3UALXOc07bKi303JWQ 18To3NBvq9kAiaG2QWKtsN7qi4eyYQAfTuln17lpFkBRdxpRuHpue3sqa0DdNjbqBLkALCDuicwa QUJAA22Ql/tugBdH7d0TYrkdiE1gBZc7FAX6e9kAwtcHDuoHFwNxZSN4fve6to9XugLEZDhbhE4h w3CM9vZCTa6AWXNuPYJkcjJRYCxSSywJVNYGsLu6AY4mJ4bwCj3F/ZKidqBMnKOM+bqHCAgN+Vfu oW+XsUsyWcLoAzbZLkdpNgnNYHEe3ulyxjzdygBG44UHwje32NlWktjJJQFRgg34RSO0kHm6Btzv 2VONhuUALnEv4U5RAahsgMbhugAJubBH9qFrDqujIFtygAt6rqH4CPXrYQBx3SiS1o90BfmBvKdE 0OFxwgZHf1PGyvWGnS3hWgMLLfhVYkqz9qjfygLtcKmAsPN0f3Cw5VAGM+rdWgC9wbcFAJQCmutI 61tigfFYbCylAaHD3VgXcLOWPYMAuibze6gHWc2QHlWJRE43O5QMD3O+6wVTRg2I3QDQzU0klW14 a0jv7rHLi02G6Iy2cFbAcMAeSXGyoQiOQ76m/KjnEn/yEoyuLyLKCwg25PYKEFoVNJPwq12cb90B ACRe9wUDnuYbAbKFx4CIEki6Espt7XvZARfk/wBkx3dJcEIDMdPA/dUAQwu7I9Blba9vlVIdEOn3 K1YooeplygLr8bBPEZEIt7LHe07qgZHJY25Ct2lw90qNlwmtZo4F7rLAiVha024PsmU0QcL23VMf re9h7JkUhbsAoDJ0hguQNlgyus8kG4Wa67oVx7mWbsLm6FoIvMwsNiETW7j4TIIAAXbo2uaTa1rI Qq2ooJIPLb5hO/ssyGM7nTsjbBqJ1bhCoxac+bHfghFIwBouskwCN40jZWGeZ6SLBCiGwcEHZFpt 3WV5Yhe2NvFrpbgGk7XRsGOb3siEAvcmwT9Adaw3TxAHgB3ZSwYjoi2xbwic0usR2WdpGgtAWKWa DZxsCVLLRcf23HPCb5Albq5KKMNjFm73RhpBJGyllSMRzfTcDhCwkct2WUNQHCF7A8WDrFSxRbRc iyJ/8s8IRHpAGq9kYN227rNlFtIcPVsCgewB2lguPdGQrLrt4391LKhQjs4Huj1kFDcqnbhLKMbJ cdkBJJKgaCFAy4JBUFkAublGLXKUL2O6Y0+m/KAsNQke2yLVZqDVsgGNB07lTT7oS6w2UM4ZYOHK As7HZS9yqcfVxYKDc3QWC4XurAFt+FZv7KEt/CBAuHtsqLf7ojY91Hi2/ugBAIROaHNuD6lGHa6O ONouQUJwYukkKaSTuf2WUIb3OpU+LYEDjugoS0kG+4RueSNt1YFyrI08BBQDC2Vj77EDZBSgBp1b lRwDXbCyuxbz3QUUJx5hZpKPe/Cp9W2nsdFz7qv1esai3SECG6vSluItZULyjU0WCKRgaAQblWys tpAbfhU6W/2qB2phCWGEBEZBqNTmb7oI2FzLAWR6S59jwnxjU6w2WgYs8JcAeSFiTtc5lwFyj4w0 kOOyUGAA7KojRw5Y4N1aTZQOOm4XMu0FgaWrHlp2kWAsPhUy0YLpTFG0nklQuMh091mPpQ8Rjs3n 5VsgHmkbD2VsGKKYgDu5H+mfKL3sPdZRHlOBco0udLYH0FLFWYjIXtlDTuEzyruIvwsx8JNiCkTQ Pi+QfZSy0YDj5b7AJuhv3ONgntaA03FyqEIlbYhasUY4kjebN9XyEE8Ibpmjv5jf6fdNfEKZ9mjf 2CoOfI8bWaqSgauQTQtlP3EbtCBrS6IOIWRIxo2A2SzcdlbAlsZeCbcJbmang2ushp1E24VNLW7I SjHZAwOLRtfcpNXBI1l4RffcrJYPLlc87tKH9SGOLQLgpZDDAJjvf1Dsga4uaQRcIv0ThUOeHGx7 IXxvDHW2HdQgo0w0+k7qWEeztimM/lsDe4ULmS7EWQyAZYnjSHer2VuJc2x2t3VPgjPqFgUBudrb BAMH27qw0jdQNvGHDf8AKt4LbC6tgH9kLo9ViTwiPshc8t4F1AG5xAQPcr+62yYGMdt3QEog2nlJ BNnd1mvIkIbqFj3K44yvDTGbbcFC6QvHO62BlZE2N1ha3ugEY0g3JQtYZdyb2Vh29htZZsBgAbd0 XlgNulPku9o7p7iAAE4Atg7onX33sqaLE24RadQ1eyAUN733S5iSGBh3B3T9AFyoG3G9rlUFFvmO az35WPvHVljCT8J85fFpLeUdKwta59gXu7lZNgSNDXAd1QbpCoRSeaXPOxRsda+oLYFvNzuE6Kby m2b3Vag4EBv7qhxY2ugKc4E3tuo1scjiJHaB2KsPZq0mygpPOcO4QAGcNfpA1N4uqcTrs1vPdZBj Y0kAcIC0gggLAFNe+OUAi1+6ygHlvbdU8amCwufhR4McQBO62AS0O7WI7qjdu7Rv8Io4HyNuOEDA W3HJQFsaJmEvO/sq8zSLAbIS1zXE8fCCzrXtsoBzSZG8IP8AlgtCOKcRt9Skr43MLm2LiqBe7bel W6Zz26SNkkSP7hEwkA6u6AmgRgloVwgl1ymt3AFkf9QsNwpRBM2xvyUlxu6+7T8LIfp8z59ioYw8 6rAfCUUXG3+o/wB00G997pb5A52hu1lATF8+6lAMi5ve1lO47hCWh24KtosLXSiFP55UDmuaiLL/ AChsGc7FATTvsLBMADR8oGuBJubIg8B4B78KFAe4X35U27FHPpDgD93sgA2K0Cr+26ofdvsiDNr7 WSyD5gN9lkDAwgje6joSb3KK42VNNifdAKfTODNlUTCGEFZBqQBpIQmzjsrQFhha0+/urY7ymONr u7KnOduLoSSN7XUBIi6Rji7cnhWw3NuVIpPSbCyjCAL3uUAW3PsqddxBCMNsb+6p9muIBQAkCxA5 QtF+UbRve4U03vsgKjJ1WTHPcDZvCFp322Qi7nH/AMoAnXcPlUBo2O6Ywc3QOA1ICiTbZXq0O1Ab K7i3wo62mxQE1uL9R4RG0m4KUX6trbKA6OEAT22F2o4btbci6q+wI4Vgki7dwgCL9QtblOa1o02O 47JLbnfusmKJpIPLkBR1k7FO1O0WsmNi0jV/hW3UbkcBSy0YlLIwzOa/YJlNVtEha0d7BG5rZDfS L/CIU8bCHtFnHlGwjOveO99ysd4LTYDb3TCbxgBQXe3S4fusWaChIt7o3nS3ZLig9XOyyA3UCLLL ZoW5mpgKoDnbhOP2gW4QuBItbdSysjJdFie6ORvnAG9gN1P0rZGAE2Kp0PlAC90sqLcTKLDaysjY XQAO5VkF1lCltIHyrD7mwshcwjZU0bWQlhag03SZifuHHsmOOlpB5QXu33VQK1BwvwqIPZWRxZW8 hrbk2K0aQAcC0+6qJzngh4QteGm5Ti8SEW2QovSGghvdUXaDzuUcg0u2NykvYDICSgGs9VwdlTWa SbnZL1XcSDsml2ppQoBO6jASbqw7Swg8q230j3QWTcmyoANvujc2yZSMEhINrD3QtleWC3UCq8u9 lP1bNTogN1cUj3OI7BClBoJAtwoWWKNlnPvfZEGa7uvwgMY7gpMkmkW4TvPa5xaNiglY0k6t3BAJ 8yUMJYbH3RU9Q5//ADDcpR1AhtrAqzGWHbshgybXG/BVmSxsFjSSv0tAFksyubKPcoDLGzb8EpFU C9l3bhW2RzS7VuOyuSpY9jQeVojMN5DYw4DdB+pc3ayyZ3xgtHssUuDnmxQwW0u3I2uhcG8uFye6 sPtdC51za26qIEBpbuNkEj/NbZgsfdXVTbNjJsCi1tjADPV8rRGDE90bbSblRs5bqcW3HslyOJeC Veo2teylmSOka9urj4R09SKch33X5CDSCLKpAWgWCoM5uM04YWkOa88bIGu8x3tdcZMZA8HSC0K/ Pllc0t2tzZAcwYgwEk7rDcHXJVPmDmWLigbVtLSwjcd1KAbXE/NlbnNdH6v7JeouFmozBqjG6oK1 NcywSX6mm7RdZvkNjY0W3KVINrNQGLNA1xbJYhwTCdTQShMuoafZVqJFkADt3bKySFLb7q28IAT6 uQrLrBELFQs2QANF3c3Cj2+pXa242UuboSiNaNW6eCZWabbBYxNza6KxIs0kEIUt40m17qNOkXPd U2HS4Pc7b5TXxiWxjcHBALcTaypt2nYbJsoDWabepLjY7QTdAVfVseExjQAEqM7m6O+3sgCfYjfZ A32V33ChAY0nugBdcDhCO10WshtzuFRcHjYbqgt1rKt7i3CgF278qXvt7KGQmjdA5vsiY8Ib90LZ cTbncbJj3ABLgkBHq2KJzdfwhRbRvtvdGeAqEZadjdEW6vwhkS423Uju+44CN7NI2Qxm7ggKLHxn 07og4kbopJLXAFkouO10FjHEWFkBcb8KE3sFb3Ai3HygLFhuURYT8BCB6fdWSSLXQAyODeefhVFK ZXHWCpIy4BvujYBYIA5BpZdtilN9X5RPB02CEEtOwQElk8ttz2Ujk1gEqabu33CIANaQN0BC8G6r iyA3Cg1bIBgtL6XcK3taJGsbs225SwEQOm59kFhOIAsd0puvVcfYjuZNwrHp2J3QFSE6N1TXEt2V ka91ANIIHCAqyIi/wrbZqF7tR2QEOzTYXKGMksIPIRjZU7hARp2JIQF+6IcKnAEoCBxPc/hNa73Q BtnWso68fyhotwLySeyjhrjKoEAXQ+ok77HshLLjdp2Gyt7tYsgN2kKabm/BQWGz2vdRwuCqa3yz ueVT99kIRgNvdHYWugbdvCs7jdAUP5ptdBIxrGm5uR7Ky4Ai3KIs8wG/KCy4KlrG6vMcHDssoVPn R3sT8hYPlWunU4czbshbLkeb+kaSpu0KP7oWX3vuhQ2m4V2vwhv+yo87IAjZvPKrm26gGpVps4oC xbshLrOACK4HdKe/1DSEMjXWDblJdGCd9wmctseVRIPHKAER6P8A8SMfcAoRx7ohv+UFFTAMAtvf sg8vcEFHcfkqMN0KSMaT7ofKu4ucbWRuOnshZufUUFFOdt6RYBLuSnvbuAOEo2BshDZH4uMNFZkD 9SNzE8XHsvElDVMMxLhvwCvcPihqCOmFdA3eRzx+y8MNlioquOB/Lm3/AHX8/wD8UrhX9n7HWukc rLVki1rBYFfK17AGG/um1QcY9juTssd9A+GO4Oor9VBUfnpOzEkb5cZssBrxrNgsyYuAIKxY2ck7 L1WcWLf6rnukkNeDq2KypQWNLrXBWG9plie5oIIW0EA5/kxgWO7gLhfR1WoNgEe4DRdcDQRfq4A1 5AcDwVykD3QN8u+r5UZPY2M7uJVOku8iyBwOrmytwF7hZRQhwkTRFzdynAkJmxbd3AVBgBpY0NKz I3Ex2ds1U6RktgG2IRuBLQBsEAUbSwXZ3Vsjc1xO9ylB5YBpP7LIdUhrBtutpEYx7SGBACQmNeXM 3GyU7fgrRCyCUDmgkWUaSeTso0H8qgCUXHCoMGnfZM4/+EOm43BQFt9I9x8q3s1OuOFekAXuhabk 77IBL2W4VxtB5VyuseNkLTqIHcoAS4NuiieHx37pNQxxJDR/ZNpYSIzq2J90IM4HugJJKaIg1lyd 0AYdyVaKSzbbhEHNPZUTZC+7xYC34VsGQwB4PF+yp8YLB7oI3CGM/wBTirDHPbqvseyEBkFnttsO 6B7Q3dP0atx2SH3PPuhQHNl8t1/tPdFEGOgaG/cOUTy5xAO7bcK2sDGbDlACLjlGJDzeyFrC925Q VP8ALsPdERjBixbKIi0n57LIfMZWWKx2Uw0gu+5GI9PdRksVJdouOVUIBcXOKZK2/G6BvpBHuiDL c8nhDcudZC0aHbm4Uka5l3N3uqQY+zRYlQHUlvhvGHa/V7K4t2+ooAh6TtshlD5v2TnWsDsUAvYg coAIRZwGwTpgHi17pDDpcSTchV5mq/ZUjMd0Xly7HlE0HVfkoy9o+47qhpPf+y0ZCDttyboZJnwg FjQ4fKkjTG3XyliQyj2QAedIX6tFrp7Xg/cqDiG2soxuo2cdkBbiA7bhCG63bn1JsjA2wA2SGOvI drH3KFHNBHPKvUOyvYi5VBoO6FoBpHmi6ZKxpf6Qlstco2S+S1zi3WT2UMhNs7UeLBBGXO3a27Uc bneS92nd3uro3PYCLbKlCA7myExAgkFCJGsc5pBDj7qRgtvdAD5R2J4VhpB45RSSWaNu6j7lotyU KimjVcE8I45Ghp1C5QshLTdxt/5VmO7uEKU03uQj0ahvyoCBsi1AlALDQwk2uo86mgjayIgG3uhk abcIAWyADc3cgmJMW4uo2Etdcq2sBJ1cIAoGExcqFmnhMG1rbBBK6ztlQFazARso8h4Fxwo6QGOw G6Ft9G53SgVYG1kYYL3JtZAHBu3dRpMpLeFCUG6zidPB9lQZdpHdOhaIQQUOsMcXcoUUGgN3ULg1 uyp7tb79kkm5t7oBzH7XBsjbINX/AJS2M0jdEWXFygC+4E8K2g3QN9gsjTZvN0JQu9uVAB34Uc4K nuAj/KBjCxlrg3V3BasVkQ0F2sg82VskFiLoZMpjDpNt0st3seUtr3ttY7Jnml3PZWikFh2QueWm 9kTjqG3KEvFrFQhLh+/dA6Sx42Rhgc24KEwkC99ghQwTpBHCG4vvugO5sCqabbdvdCElPtypGLc7 qyQDtuoxtgTflWgF5TIna1UjS8XadlbgfL9aSJjq0AKAGzLc7pbXAO9050AAJHPdUYhYWsCgBcbb gXQva6p2ssgMAaL7oXAxkaeCrYFQtbGdLtyjeW32FkwBsTi7Ykqoi0ygOFr8KAx5JbGw3Q62Oe1h bfUe6dVwvMlohuPhY0XnCe8rLOCAzKijjp5gGHe3CotIdfsl7vmLnbphaSfYIASAxt7IHzGaPSG7 3TZGbX7KMGrdjbIBbISWgWKJrr3HFkYnIOnTztshfRljdZOxQFAXBvsltjFyQUZ2t7KEi1wEAQaL WJQSR3FkYZ7qnAbeyAqNoYNuUZuT7FA4+wR6S6xBQFukIFiVT9rG+6otN91L3cUAwMuAAfUqc3Ts f7JL2O1XZJpKvQ8j1OuUBNB13OwTS4N+3hLBNrOUA0goBxJc0X3SnhpNkRdZuxQEAkXKAfGA1t7o SLk/4VN2Gysv0kEbKgXJE6QDkFWGE2a/7UYd6lRcRsTcKAZ5YiYbbg8JXltc06wmPeCduAEAN+TY IATHoZ6LqPB0i6N8ulwA2KYZWuAaR+6A48P0y6T34WQYgW77qVsDZG+jZwQQNdsHElAHoDRYDZKI 9QKynNBFuEHlNbffdAA9rpAOze6VI21gzdZIcPLsePhJ0EOBB2KAJt9O/KFp1G3dHJYDY8pbWguB HKAPdn790FRMYmi+47pttRVhglBDm+kISymTCSMEbInOOk6v2WPO1uwY61lZcZIxfkIWyX18pjC0 XBSobEkp7i3y7gblCFkMc0tubKrBjLNJIVPa4gEC3uh/pQoTLdyr0Wdc91QaHN33CS5zvMtf0oSz K1cW2CSRpdqV3uLJchLnbb2QgYeDcHYqi3f3slktJHN0Tw5u4Q0iWudk23p32WIZXNNroH1Z2ahk yydbrDhCYxwUEJN7g3CyNQABQqFBukoSASL8I3us78oCbGyFsN7ho2SXM9BJ7I3kXAvurdGBHf8A 7rXonsS14Db2TGNc4HdKibr2Pus4NaQBa1gslowfJ0uJ7+6ydmttzdSRgANtypE0v42KEoEuexno Gr4TILSRnXFpcnQ01yTchZEcd2/KFENdZti0BE6naW67WKa+EahflW4X/ClgVF9pCa148vSBYqmx JjYwO2/upZUhbWkBQNN734WRpAseVHAdtlmy0IsHG55CmkEcXRkbi6gLWu3SygxMs7ZZNhx3Sm2v cHZGXjT8qWCOCU+JrrAhGTvzdUZQ46bLLLZUMQjce9+Lo2O16kLW6nWuiNO+FtxvdLFll1vT3S3Q km91elx5TQTsCAQlkENYGNPv7q9WobmxVu3dYbIP0/8AN1F37KAu4F1AzUDvZEG7oXs22chfQF97 Dn3V6PSqLbuFyjPFkILAsiDSWqBh55CMWtZAAWjTv3UcA21uCic0vaB2QlrdgTwgBbe9kZDdkFwO 6q23KAYAN/dQAO5UaAeCrKvABPyrAsFZ3VXQFFx3CG/uj5Koj1HdQrI2w5VOJcduFekG26Y1oA+U ILG2xRBw4B3Us7fb+yTpc1+oIVD2lzBvvfsjsXN3KSZHPsSELnHV3Q0E6JzRcFE15LN1T3ekC97o Q0ubqCAsvD+1iFDvsQoAoNg4oCnMY4eoXKG0ZbbkJkTdYOpIc8NNrIRjGyl48to0gK2+l26W5zWD VayZG5swuEMgusHXCgBJ34TBF6SBulSBzBzuqgFpDXXRuIa3ULXWM1x4PCtrdrcqgsO/UP42CFxI OyNh0b8Jb5NDi4C4VALC57je2yay728JIcZruAt+FlMZpZcf2QFaSW8JJaQdR5TnvdayCRlm6rpY FPYZhubWUj9Jt7JkX2qwNR2FkBHO2ugO4CYWWPKHT8oANJ1Xvso6MkixTDp0WPKWQAbgpYA8gF1y N/lUYTuRwnuN2oBY8K2BGn0kjdJbHK4/bYfKyWtdcgmwTXyPLNLQPyrZGYQYIxb35VSRMDbgb91l GC49RQFlvlLIYr2fyvj2SWwA7Bm6zC2w33TotMQL3hWyGL5IDdxusV8Wlrm9ys6qa6camHSsGSll dazvyrZlo4ySJzbjv7qm07yL24XIuobD3KGOmljd6z6T2VJRieXta100MDmnYDZZQjDftF/yl1Ba xu4AQGF6mC3DVROrcG6t0p1i/wBqjnsB2HKGQDuN0TI7jfhW5hKmrU0BwsEBTWDs4FFNEIwC03KB tNG14fGSfcJrxb7gqgI0l4udvhVps7fhNc5rQN0mRwc4A7hUDYWhod/hBGAHklM1NaLDcKw0PsLK UBD4C9+sbBMIva6fM3UzSNgFjxjRcHdQDWNsFQNrq2PJFgEuQGJ1r3JQBEjTvwhBCWC5xA7BZUdP c3KtAxZ5CXAImPGnd1j7K52Bs4JFwPZKLWyPOkbKAe2QSC3JCpwvYHZVFGW3t3WQ6O7bn2WrLYgX AIHdAY3BpcSmAiysgSCypTDYwuJN91m00rmABA1gA3FgnQt9JtuFnkljH206rXJUeNMJcAqfZrQP dVK67Q0cILFtkvayI2ed+yoRgNOyIN7jlLFhefpis3lJabk3KJwDNyd0I3VLZHnTvylOm0ni4TxY +lDoAvtdCivMbPsRZKmPlAD+yeWWIsP7KjTazZ3AQyhcb/OseLLLibC6M+sXHZY4jEIIAv8ACWDD Y3jId7qEHEEkkGyJtwbpMLG6iA4kFNlp5f0xMW7rrRqhk7CbSAD9kku3V0k8rLsqAA2yASNbIRyO xQpZAY+7RclQnUQTsrMLi7WPtASpXa2XCAY1zb7InuB42KRHfkBGdyd7EICySw83Kgd5m+10LGk/ JVxu8l+pw/ZZsBhok+7ZBpLXgo2t827hsAiDQe6gAnAL2uO5VG7QiIA53Qu3VsEBLtuFTm6RZWTY gBE9522UAG9kyPgkhLO5+ET9rW4QFuLX3Nt0I2F+6LUA2yE7rVgEtvc3Ua8MFiFLEuB7eyuRoKyA HSNLTbYoAbWtumGFp7qNZbnhAGX+ay1rWSnx78o2ktG3CoICRAtHujcbKC4Co8oCAbKOI2LVX7qA hjT3KAZq0gd0LgA3Uga/UERHp02QAsOq57K3C9kxrdTQ0D8lEICdh/dACwbkWVGE77LKZEYwNrlW 7btugMaOB72aeCqp2SQudGYzv3WW3UDsFBJPJNxdrQpYKjp3N+7krOgpyBqOyxzK+RwDW3PwmiWW MaHtIHulmkG51nkDdBJqPHfsqguCbi5TQN9wsgWwECyYHBzQ0hRou+yYGBpv3CGkRrTxuEzSb6eS UD3+YARyria93dYsobYpIzvwshh3Cgvps4boWXDz8rJrgJzwwlBrD3XQSWEtjvdE1tyQFaA0Audf so83IHdC55YdIQl2p253SgEC47BUQWO5/ZUC6M6glOc979R2ChLMpovdxQF7XekcoCSHWvshAAcb bH3VQ7Lffg8pTgTsCjcC0XJuUDWkgkbKlKYS1wF1Knccq2WLr87JUnrLlTSFGS4sVmQEaR7e6w4r N2eLp8LwXaexQpUnJIKU423vcp00QcBp2ISZN2gN5HKqBI3lt9kbHEdisYyPYfVsnx1NxYi/ylAa 52qTYbKjI65A5Qtc7zPTwmRvu43G6UABM8HS7YpjHkNO9lHsDjc9kMjrN9IuoC4omBxfe5QxTiGS UX+4WHwi4YEt8QHq/qQEjDqXdzyQ73TP1MjXekjSUjX+odpeeOAiYBqLf8oUqoaNbXN57ogdY1d/ lEGWvfgoBpBKAlwe17KjIBvZU9haS4HnsludZlyhljTPqH28JU/rsQ3cd0p0uxsm00pDTfhWiNla fRz+UkxB/JuikOoEAn4SWtd5Tu5CplgvF3lUQBvb+yEB9g4i4V6j7IQIkcoZw4AHt7qnylrm3Gyq Z4cbA3FlpGRQYHuBO4Ty0hux0pYA8tDHIXEtJ2CoC0k7khXsQg0gkhV5JHDkIMIte3ZGQS0EC6UW O2HZRj3aiCdICAsi/IskfY8hp5WQ59gLm6X5YJBQBRMs7fe6GVrWnZuxKcAWb2sUp8uzgQgDkexz QIxpKazVpDgsSOL0F1/2TIKoyNLOLIB4me59nG4SJWujJN7XVOebGwt8oWu9PrKABp1O2TGsIJCg bYAgWHuqvzpO5QBWBCA7AqAlvyo9DILZCLDumNfc7oG+wbcpsUY0ku5QpTwdOyA3aLq5HO1EAbBQ G7L3QpYjDfWeSmNdslOBO99kJN+EJdDnaXsLXcJVOWwNc1p54KhvpsVI2g3uf3QWUSXSDkj5TXv0 sISWtd5gtuPdNmcAR3Qotp3t3VlpI3VgtcbhWT2KEYLSQCFY+037qED3UNwAAhCBoFhyiZGG8d0N yD8BXcvG3KCypBfuhaCBuj2czmxQ/wCUBA1lud0Lha1lZYSQUYAc5AVFG06iTZPawaQAbrFJs74C zmPY4XHNkKjH3BNtkUYFwSbon6Xbt5WIJ/LeQShTIk3J22Kx3t0G4WXG5sjL35WPPEWk+yEYt0zS PlUXBxCU64dcC59lcILybm1kIHqGr8KzLfgbI2taWnbhKABvbsgGNcHNR2sgYOwFii3AKAnAsoBt e6l+ApfbhAS11VwHcqcNJAVAh443CAvuofhU0F33GxVgBu90BHNuAieAeFTjeyW93lndANJUbYnf hCy7xccBXYkICatB9PCoHU65UaQASN1Gv1m1rICWLPwoOUTjd1rIHnSUAy3uguL2/wAqA6mlDcEW QBgA3sUN7uPsFbRZvKpqAokg3SwCH6jwjeL7DlQ38sA9kAQddosqILjcq2WAROFztwgsESAbW5V7 khCYyTsEV7G3dACW3IUeTcbItwd0LgeUBe97lV/VvyrYbtNyh/I/dAG2UXtzZVrDt+fhBYD4RtaL 8ICtI5PCMgtFwqLRdEbgIC77WUD97cIbqGw5QFu+FTVNQJ9PKrUCed0FhHhCfSNuURKEvDXC4uha I02BJRA90JOsXA2U7IQpxtuBuqa0jc7oi7SNxdUTtxZAWraN0KtgIvdAH3UBGrc7qCUNG4uVTgAz V3QANabklEz7rIdRIBV3AvY3KAKYaGXPAWO6oEhAFlKgPkDWl1kryRE9qFsyxfTcnhUC0i5AVtds rsD7IKNkfiIArMjYoBxH6r+y8I1LhUYxE9w+47L231SxiKty9XUMrrsmjIcvFT3sbWANbcQvLWnu Rdfgf8T0z9hrqo5OsGstFrWWJK58ZPqNiOFmPu94PNwkVcdgSeF+pj2fnmjiZH6nG5UjDSDdKqCA /Y/3UDdIC9COLGOF9iPSsaW7QdDbArKvsseUuAuOFtGQKdjY33aLuKzmgFlyd1x7JLFxHKzKNzTG S7n5VYGaTa97qBXe/cAfCrTY7FZNFFxaN+URuWqO9Q9QQk7WvsgDaxrdxymQm9yeFjBpubG4Ripi iFiqA3gargfsnBokG4slAgEFpvdZDRdoutJgt/paGg7JQdyjfH87fKWWgbd1syFcAXJS2udf4Vlt zwr+0ICE3I2VeYeLWCJwJbfugc+xQEuHGwuib/L3vdDFZxO6siN7SGyWd7IBcr9TuEbGWcHDhLML gzkH8ImExg339kBka2k8KnBrj7JJkJciabmyGWXI8WsOyG6j2gu9lQZsdytIvop9jwd0LgQza4Ra bdlXflSjJcDLt3Ky2RtLbE2WOGtAuDuo6azbE7JyaRkODW8G6xy8O2sqc4OGx29kskB1hcBQo0D+ yAndE0gg7qRRaiSeFUZsjeNSGUeZIwngITNpuwcK42nSbqkMouFgbpDJQ65G6jd22SzFoYbcoBjX 7qF+p1rJcLXBpJVtLr35QFHm1lGvO7XKPJ+4/wBkJka83HKAFsP8w8kpzGtY4h6GRtg0tO/eyjon OIJNyhAw46i0fb7qngNNlZkuOLJbnXQoB+6w7oDG7e3KbHbWnsa1pPcqonZhGAvb6uQrZF5Y5WQ4 OLjYbIHsDmn3VMmM90plDbXYe6bNBoaNIRtJDONwr/UXsdKoEBxtYhE1pvcnZG9wceLH4VAHhACJ ryabX+Vcr2AiyMMaB/1e6B8bHncfuhS7jTcG6YQBGNlRgbGBpNwqmeSAOyFF6dT9uE6EiEnVvdA8 aAD2QOkMrweAFCDf4jaXQGXCZJqkaC2wQO8stGkeruUAeeAoXoa6R2ncAkIQ8y3Lm2so4BQt9til gXYusSCAE17g0AjlQbCxO6p1rKlLfIZtJdtb2TDO07WSAAb24UFrogE+PUbgqeRI1pKu127ILzRj b1NVAcZIcByidJp52SWufyRYo9Wq+v8AZAE462Xa1C1o078hC6YwtDQCbqnEh2skWQjCBuN9lBx7 qrl2/CvgAILLdbQfdAy7m34CsDUwo2nTHYj9kAsi7lcbTclXvuijFgbqlCHqAuUt7dO/ZMttyhcR xZLBA4OjIAH5Qsiu0A7H3VtIa7jZX5h17BQjGCEnjsh0u1+rhTzX8K3OMzfZBZTY73sdlQuy4vdE G6RyrLRZDIrYh2+6ZoGkA77IQ2xt2Rf1fCpRMkVzcH9lI4S74smubq4N1GsChAtmj5VPfYHZR4DW JRdrueyAZE4OvtsqdEXkqRuDWkhCJ3OI2sEADWOaU0PuLBXrCAPAKoCbG1uxO6oAWslPPqvfZMbv Y8KFK23So3uEhadr8Jstg8LEqo3zuboNiN7oDNcw6mnd3wseaXy5tAA1ORUNU8TOY71Fo5WMP5uI mU8DhUhkRXidd5G/unOdEBqaQ4+wKCenZPEdTrD3CwqXDv0s5k8xz2nsVAZurUbBC9xabclSSPUQ 4HhA8Me27X+odkBHH3G6Y+W5aQ0XHdJsS0Em6YwgAbXCAyYydj3VSWcDcepUJRY9kLgdP57oABH+ 6axpad+FUbTf7gkvqtUhj/ygGmmudQlAb/tVecGuttb4WGyl8mYvlkLoz2umTGEgGBp0/KAySWuH pO6ohxsHAlJH8uMOAuVkQ1AmsHDcBALtYna4Speb8LLcwFxtwkysLvwEAsHU211Gi35SnEahZ1kw N0uuCgJ5jWusdirLtRu0qiWgm7blA1zR9otdANadt+VZIASx6D7qte+42QpCATe+yuQktbpKGwKg BB5shBuzmj3QuCl7flUDd26AaxomaWt7IWgNJa7YqEFv2HSkyRuLg5ztwgY192fhT7hdUJDazhdH wLWsgso3twra0t5CllYdcq8CinOJFlemwV9lRN2oBbtTiCACmmUyNAtY+6C9mqz9lgd1AGG6Rzcl AXWKuMENN+QoTfdAUSXjfsraA82J3VgC17qOI1BWwWwAEhBe77dkThyRulg2fc7gqAkrLkBX5Yia O5TYRrdf2UlHrsUADDYoXSOF2jdC4Fr/AIRmMb2PKAxXRhxDr7q3P0NBHdMe1jPTezz2SwwvIuLW QAtmvYj+nkIn1Rkc2wsAheC13pUaD7bK8E9mQ6VxZzYKo3AngpLmvA+OyuPXpIO35UDMo2slDeS3 ZUXAxgE7g8pJkex53FvdCGW4sjBANykxE6nO4SmOJdcndMLjpt3QtAObeTVeya91287pYKondCWC WgndEaQHcchLla4WIG6y6dnmC97FAKga5otfZMc4Ab8pVQHR8G34QQguIJ3QqHgXLSbq3xebJbcf lZMJF7EbJjmxyDYfuhaMER+vTa5HdHLCXMN+yyHs3GkbhNFO6SLc7+yWDj4IxbZZjGAD8qNp/JaS LWKZGfhSy0KfT3sb2UZTgOG6yfJ3uOPlW1g1XspYLbG21wLFHYWQl5B4UvcqNmi73bwqttwoXWUB 2WbBANrlXfZCSSNlDfuUBHE2V3sN0INr3Uvt7rICJFktzQ7YqcDdQAnlVAtlmGw4RbKNaApYWVBL 8KaRf2VDcq+SgIb32KjHyAnVx8qBWXf0qUAidQN+FbQGNG+yXqsFZfdpHdSgA99nccKNkJ+Qgdu0 I4vS07ICwUQJsrAuhJ0q0AXxj7r7oHOcR8KyblCC4ErIBY94vtdZtOwVDPY+yxhG4kOCyoXfp3h4 3PsgMiny5V1kjSx2iO9yjxrCDh7A7tbe6y6bOElONBhGkey4nE8UqMYq7Odpi9kBgtubnsr1C3G6 kvoOkXsFWm52VoDIh6bqxzyl3cDYcImWBQBk2sq5PCh3Vt4BKgK+VYIuptpVX7tQAkkG4GyheU0H ZLL9RsUAepzwLbBG2wHqKUCWvt2RXJJ9kLYZc3hKc26oN1cogyw5QWAW2Fkbdha/Koix3VgAnlUp XFxyo7Zqp5AIsrBunBSRn0km9kqWONxaY3aiU650kW2QsYG8C3yrQK8sgWcLhQEMvpFk5xsB7pJO lQyxfnSB2yD1b33ujub3soLkHZQgNijjsTsha4OcrHpk9J2VATnA+khVoJFiFHHQ4EphkDksCo4/ JPwVkvAcwaUDC0c7qnvsCG7JYALhci2/ulOdq2cbBWd+ULhcq2Aoi7Yt3CIykPLbWcOUJlfTOAjb rBTBpeQbWceUAJka3YjcoTs74KuZjTvfdCAXgDsEsFuHFiqHIRgWIBQAfzLnhCchuO/CULF+yNzg Tyq2JVHZCB2df4Q2DQSmbA2CQ+J4l/6T2QlDGHXvdM0NtdAGXsBsUQa6Metun5QoiSMvNhsgcwj0 uN0ypdJduj/CHynark3ulmRQB+wKnNLXEd7I3NETr/1JEUcn6h0jjs7i61YKc4jccoWU8s51a9vZ MDdTyEtwe1x0ut8LSBUrLAtBsVx80JLvUSVnukJcNr+6B8YduqZOLfEGi3sjbEA1qyJ4xsNO/ugD SGaiNkMlPGo3+EjfcOTrkm4QyEP2QhULtLrW2QvqWl5YUQOllhyqbSiWbWUAgi77gWAQtBkcSQuY bTxNCwZYyx50K2VC2gNZuijIaCbpfm7lrhYqg/kFXsoyN7pnkA7Igy0lvZBC0D1DZNY4ElyyKLba MEu2Cx3uabkG+6Ob1tssdwGkBoNxzdUlD2MHl6r91kavMYC3ZYzJdAAB/ZZIeDFYCxTsgJAa67tw UDY4wSBcFEQS253VMFnbpQAhDvMNjcd0xz7OIG6CmfYyD34UIEbrjutAofhQu2KYDdqC1jYlRlIw CSzbgH5WXDLFDEWcvXH2/mXRjT2G6yQyNPd4/Cj3XGw3QeYXN33ICjQdNygCYdrFNuywHDljg2PK ZJI0gDTZyAGqIbYFKtpA3TCxs4DnusWoZGta27XKgoAXO+6trrXBSzc7qGQbDuoaDBI3Uje4PB7K 2m4siZYXQyW8BzuOUqSIlxFk13wd0TSGi990Bg/8t9h391k09a+mBA3B7FImD3zarbIDq1cLRbDk Y6oe5wNj7JQhLdi/f2TWOcBdR7O/JUNDrl0RaPwkBhYNNrlQiTkBMYHHclKBQFmq9DRY9+6jhcbE KMOp5FlAWGi+xReQHjUVbRoF77IXSjSbb/hALc47taqDy37kUDC654I91JPUUATradQ4QtIJuVNW war02A2QFEAlUQoT8KB10BWndWTuApcd1NVkBA6zrAKG3uoHAj5Q3JvsgLDlCdTlQFio02KAJwsF Xso4aio4WQEJsqI2up+6vshLBc7Sq3vdELXJKu1+2yEsHso1u10bW3B22VsudjwqaKjAJsnGIPsO 6ADe6ax4aSVCE0+VuBuqbNZwFkTnaudkIZcE8lCmYxxIud7BJkc472srY/THzuqf67IKGRPcG3td MbOY+YyQUFPIGOAcLj5Wa6ZpsGD+6wVGO2dpuGjS5Mp4Xv1OmdcHhE6P1h1hf4TowH+l2wUZoW6P Q4aeCiawg7pzo2tj5usZxtf1KFoexgLbixKhhud+UqN3p547J0Ums2UKAGW45Rt1RglPLAxxKx/M Ny08LJaGtmEhuOyvzADcHdLY1rAdP9kQZYXVILN3yXKKMESbJjdJHsmANsCOygEuJ1lD5bnG4+3u rjvKXOG4BsprLbjsqgNgaS/j0hLq3jWA1E2cgbbJTj/UqilE6rFWQNiFYAtf3Qu9IuN1AC46hZDr DQrvdtwhfYsudrdlotlxW1ahtdBG18RlMnfhA6QeXduzvhVJOZWC21lS2Qluv2RxMBJdvssZji43 WTTyWPG3dUtmVBEHxue7YLjZ6qOIOaTvfa3us6eYm4aLN9lgGFocXEAm/dBZIA6ZmqYafYKFzY+B dE+8nwg8scIQyIqlnA+5MMgJJOyxA1jXC3KYXGIjV3QDxM3cEXHZCXgjZIkY4NLggjeXt/ClAy9X ZGACBdYbZbOsSj883AulAKSxftt8q5CQ02SZX6CDyj16xvsFRZQedG5UbILcqPLW7XuhGniylFsa x45PZLaWyh4JsVV7AhYlQHRg23J9lTNmSabS03II+Ev7WLGo3yRxua91x2umCo1bO9KGSSO9V2ng JUVWBvzc8IxZ8h9kmSMA3aNgqjLMgyucOLBKEtybq45nTDSG6UMkfqDRuSqUoytc0g7pUYtclWG6 HEFUSLhUjCc6wAVG3ICovN7HhVyhC2mxV+ZpO26EqNJv7IBj5CxosNz7JbyXAF2ysus4d1UnqIQC yXAgNWYyNzmB1tklrN9kZne1pbbYIB7zZgJNrdlhv9d97KeYXjcqg1AMjAa3c3Qhlnamq2+3CLgb ICF40kIHNuExsYO5S5HEOAHCAK502VBpDdlQdbuqE9tiEIyzZ1gNyqAJJB7K2u0HXp3TA3WC8myB FxMt6iqMt73KtkgeAL8dkEkQKFKLmndCSDuBYKBgao8aHIC3Ou2wVCzSo3+yjmi6BkvsVVhax7ot lRs1CNF8bdkI37XCq9yi3a27QhAR6Src7VuoCXXuAoHNAN0AWkWUOyrzAe6hN9xwgBJP29kJkMJF u6aWa2/KWbWLT9yAYG3sexVuBBQR3OxOwTJHBoG9ygB1hvAvdSPclC7i/ZAy7blAE0eojkBGwEb3 2S2E7qy8+yAZI0Ft7kLEewBwuFlawW77IXaTYX3QC45NJAFwmvkueboHQnXsrfxsEBGsa597En4X IYVlysqS+QxO0njZY+HzthcXOaCRwCvtMPzlRU9E0SnRPa2kDZDUY2fHVeGzUkrhI0sAWIZGRj0i 6z8dxeTEazWHegrjH/cLBCPh0ZDdyHKPFxcbKmu9O4VF477eyEBB3KnCO2n91LbXQAXJ/Cr7SDbZ EOD2Q6XgG6Aj7Hcf2VGzgBwVZba1+FNggKAuLIrNNgd1GjTdUNygDa/SbN4KqQCM990Lxbg7oHSX G6Aad2nQLpTXaedirhebH2Kt7ARtygCMn90Ov4KHeypr97AIBodqHCoxj8K72I+ULrl6AJttNuVX fZEODcKrtI25QAn4RNFxxuo0A91Tfu+EBbvSOFTXXBPsr5PwoxvIBsEATTr3UNg69t0WjT3QPeGD jdAC9rnm4VsDrHVwrY4Hf3TNXZAJ0jjgISnkAi6USHbjYIAS1Fb3KokHupyAgL3sr7KKyQLBAVyp cHYobnVb2V/cbBAWGjkboQ65RWIabIY2/wA0A+3CAKQ6W8IHNOkd7qg58r3NJAaEE0hi0gcIB7PR sDcqFoeRc2skucdIIRMc7ULoBpdbZQi+w5SnG7rBNagBLSCL9lbSHmyAgudsdkYAbuEBHMVOBIsE zzLi9uVQs1t+6AAODWEO5KTFKIZDrB0+6a2IEhx3TJS3YEBAIuKg+k/hEYCACSL+yNjG7aNimShr RzugFN9OxUsELS43uLotRHZC2e7er0T6ShlN7DcFeTKth/ij7bN1E3Xunq/lZ1dgtWQzhpOy8T4p AxlbK24BY4hfg/8AFtJdn6/WxdWMidcc7WQ1ovFsk0p0A3dcdlkSsMjLcFfpU6PhnAVERDr3Ua4A AErJxGP25CwCDKQbr0xdnmlwZBSJrkWTAQGc7rHkdcHldkYADbHSNyVyEbdMQDha/dcdRG85u61l l1FU4PDG2IRgyHBgbz+6NjQW3Cwp5WhrWE7lM84RRgB25WaLZksa07uP4SqgANIadkoEuO52Vlpk u0cILEN1tJ32QujD7Ao36g7SePdDx9pvZWgzOga2w33CzG2I2K4qKcBtyFkxSkm1v3VRTKe0uba/ CWwhzrd0VnN3JvdU0NYbrSMhO9KFu53Kjprm3ZWyznhUBPKS4DdZMzAwhK8tun1f4QCCSHDSlyxk yAgW97Jos7YDdG1n+5ASjaGQvvvfi6vsb82RsFm+wVGwNyrQEwv1vsRayZ5rY3WISGFzpbgWCbLp fb3UoBk3VNv+yrUNNgVRdbZVEYTthdLLgRdGHbAcBHHQvnJ0bjlUyLaQW/lUBd9nDZWWmJxBHHZQ yB2xG6GhgYIySOED2at0bo7Qawbn2Vl2poFkIxbW2TC7SAAqA0G5QyyCTj+yEA1D1bIuG/lLBubH ZHfe3ZAE3YKi7dWDfsgcbdkBVRcN2NrqMJLO/wC6jhrAuf2QeYRt2QjKdKQ7T/lXHCbnSdylf+4D fa6zo9J42KEMdkHk6jqLj8omyHSFlSQ6mau4WI7c7K2VEFySoo3lEBYHuhQb6d7IBWBr7W3VuNyQ lOIjudiqjI4VZkfp4TeTYDhYAIfJdpssqO7jueFShv24Swwd9ymloICBxAdspYoHTY3A3QlxLvZG 59jYDdA5pJuNlRQQeL/KuzXBJLS0hMjiL3bbIUcxgAIusWZ7437C9lm+UbfKBkYeHucPS0boZYiB wlbqcQmNjBJ9uyTEKaW/l3aUz7CAT+6ELDDuFUYu66hmax1jvdSMtD7g7fKlFGvaGkWQOkHsiLw4 7bKi0O/ZQFA3ue6g+ULSGnfZQm42N1UUjSIjblGHi9iAgLbhC8EkW7KkCdUaDp0H8qCscNrbIrjR yEgOAfci4KCx36gSN22Qm5IUdpaLjZU1190FjdQa31chJabuJ5Hyo8jurYLHZAHew24QEEAlEf8A CpAFC4kHbdE7bY8qoxZ3wgnkJNmC5CAPspbblJYXkjVsmA3QBjhUd1V1Cdt0Fk782Us4k7hUbWQn ewVA1pI53uiadiRskAEHlHqGnlCDdQNrbKy4F1rLG/UGN4Gm/wAp/nRvGxGpQF335VHce6FpDngI 5BYqgpm23ZFYtVtLQBfcpNRI4AhhsVAR7iD6hYIRv32ShK94HmndZbC0RgWugAAFtlALFWWjhVey Avb2QSMB4RAkKHhALAB5UN7W7IlWq3ZAA86h8oWDQLX5VuOo7bIT733QAsPkB5HLtrpccR2d790w uvzwrD9rIBl7gBGxhdt2CSw6TvuE5rx2QAvkbGCLXJWN5IuSDuVkFoJKUWuD7AbHugKhYblt7lPE RG52CpjGxuBO7k6V+tqAQSD8/KNr9tuEuwaCiY6zCgKkDyLsNkJ0tbqfYn4Vh5exwtb2WPoJuCgG F3nNt2Vxehhb2KqNmltuESAJhDYyLXQC7QexKIGyhN0BUdT5TCDuUTqgFgt+6Q5gdyq8st3vt7IA ZyHD0rHY6TWLEp7vkIRs4EIBusFu+xVg27oXWJFt1LDceyBh6vdDq1OsVV77BURZyAMuJ+FdyPlL PZFfZAXq3V3SnOtuhEhtcoBrpeATZRzDJY6kiSdrQE0PBaLIBrSbAFF6jxuk67b3VGRzx6DZAZTC QDfcqF391j6yGi19XdNE2pnqbc/CAZq2CEusCFGEE/8AhBKT/TuhKCadX4RhgJG9rJTB/LPYo4yQ N0KHptcqfCl1Vze4CE5LLbt2CU5xYCDuUbtWo2KHTuSTcoUXHU2eW9k6KdrgQWrHewXuAhBc2xDU ByUZbbYK3x6t+Vj00hZue6P9Ta4vdAVLvyLJRe1jrC5VSOLni5sFbw1p3A/KAU+Fpn8693DsmF5J vtugeWtOxuCo4gNv2QjLtyUs3uEbTYAn+yq2rj+6FRNROxPCm5CEDSiJAPwgFyEOHyEu1zZO2PHC rYG/CE4KaADZE55sgO5Kt1tA90LRd7IWuu4prY7AE8JghaXbBCUKaA7kpsTQHAkbIzTO20t2ROY8 DRb8lBQ2SBkjfSblY36ZzXekWKyaUiI2cnyED91LKhEDNP3FN0NFy0IPKJOxG6YyItHypZaBhYSd 1kOaQzYqBulo+VHjTbdZZUKBc7ayNjbbWTAWgi391biEsoLSW322VgWUuOFZFu6gBJ3VXDeExkYD blKkcLkDYKdghco1UAD8oj8Kgmr0H3QE2+UZHp+UoxuPCAsydu6EndW2M23UEZb6igLLhwi1WSy1 x4ChNhdAN1WKgFj7oR6g0jZXqKAvi6lrDmyoHlWN9igK2G/Ku5O9lTrNKgu7sgKuLqEIH3DlG31X WQE31chXpIBRB4AuOUxzbtF9r+6gBYNI3Qlwue59lc0UgDQ0XCNtPpAubkqgXE9pBGnf3KtzLC4s mMp2xO1OO5S5XgO2GyiQIQXAC9kqRjr83UdMGu/Kj5W6b3VsAtuOURBJuDayX5u2wugE9xcGyWB2 rUCO/uqYLD5S3S2G3KjXOfwP3VsDQ6xKvVc8WKQHlhud01kgceFGAiLglDqIPCZpulzXjsRugC16 tjsr+2wQRPEgOrYonuta26hbCDrkb2VvAA43SSSDcJjZCTclCFDc3Kkjy3gXUA391UjC+xvaytFQ BnI+EbXFwSi4GTT3TmtAFj2SgW7gb7q22B2N0JPIVMY4O+EoWHYaiq4KN2x3Q2AuoLITYKtRAuRd WNwUt5LgWoLHuBLRZKkjJHdPjDRDu4ah2VF10FmLe3bhDBVMnc4NBBCa4WDjyUqijAa4uADr8oQt 7QD8oeObhFI6/Csi7QgKa4Xsd1TneX22KItsEBeHbWN0BCTceyI+nYclDuCEZFlQDYh24VkX4G6t ove+6tx0NuFAXE7y3f8AhML2uN+6QBq3A5TC0be6oI6xcDbZC8eoFvCMt2APCD7dlATSHH59kMnp FiVfJ25Utcm+6tAAN1Nv3VEOHATBt+FZdcKgAX2VPJaQTumNtcE8q3Bum53VArztLgTsile6Zvqd cJMgY48o4W727IRgv9Vmjsgha/zDv6flZHl2ddAYi5976UIYz3A1FjumSj037eyc+Jg9tXuhsLEE 2PZCCIoSTq7LGmLDOWueG37lZ/lgxEX/AHCxzTQOuJmaj2VQMd8Ri/q1X7rHZqjeW/cs99LoaOQw cfCU9zIZABuSNyVtEYjy9ZJcP2SpGC2nt7LM1xSBwafUUl8NvlUyzCawsk4u1KlFpdlnua4Dayw3 RXed97oZMeR13bD8o45S06SbEpsjWNdsL7brGe53m6tPpCFozYw5wsSAhETmFxJH7IHllU0avSB7 KwzySW6yR8lBQDoGaw53YXusZkj6qV2hlmNNiVly/wA1luyTI4wtDI9r82QdAm0W2ndW2oDY928p jo7sBPKQ9h4tsgsy3FjowW8rGDubhBG/y5Dc3HsmlwJ9IVsAMju4khNiGm9+6WXm4Hujc+3CqIM+ 7uAVNJCwi55dqHKzQdekd7boVFWZa1t0DmC+/CYQG723VHeyWGQ2IFuEGtrXWKux57Kg1rtyFGyC nD17GydE7TyEtzAXXR6rHYICPiJfcHYIw5x9NkLHzi9owWJgnAZc7P7KAnlEEE9kNy117XVMqC5t ncpgeLbj90BjTMLje9gSpNGY3hveyyHaCRfcIJGapNYN0Am7m87hEGNcdXHwrcJDYsaHKzcC7hY/ CtgtpuVdxfc2UaNiUBIGxSwMBF1RHe+yEEi5KjHA3BUBTiSNt0MjdIudkfmNZwLlC54kFxyhUKab otR291A0pmi9jZDRGyuPptuqcN9z+UwWLbgboHO9G/PsqATYHZQuDB7komG7bWQvbcqAAO1DlHoD YbjlA2zHbndWXb8oCMfvY8FWbg2KjgDvZRoQjKuNQ+FYcH3AVBuonsiMYgYX3GyERViPhCG2N0Ws SRl3CWHXOxVNBf1K7ISTZRpN0Bf2lWNUjvhC78Io3EEBQEd6SfhAHC/KyHaQ25HKwZXBkh2VsGS0 3Ks2WJFM4jf9lktdZpKIhdhubKgbqXuLqid91RwFpt8og4EWsltVk77KWApHaNgpC899wguXO3TL NazblQlhhtjdU5wuo4ER3G5QFjnNB4QqCaTrT2O0C1rrHiuD6tlkMcSRbhCjGgWG3KZ5Oi5Khs17 fZZWoadwoyowdNnXAuVkxgm3ZGxrL+kJgYOVmzSRb3aWi/KWJLE33ROGsfhUALi7Vk0N8wBlhyUL 4w9hvsfZXov8FUWaTuUAtsbhZZDbMaCDvfdA14vY8Im6ex2QGQ94dptzZKc31XVk2OyFx9QHKzQL jaGuumyAkA3/ALIR6OUOvUDY8JQL1b77Ky7RxvdKIvvdWOeVQOpz5bS0clU6Mh2omwSwCHbFGWuk BBOyIC5XkG7RsltcZXBvunB7WtMZF790uOPy36jwEA0U7wbchA8FjtJWTJKTHt+ywJXOe7bdUBB3 PsgLBId0bGhrLncq79+6ARMBHsFiue5z9tgsqYendYgPlPLiLtWi2ZMLRcWTn3jG1t+6xoa2IHUP 7KqicygFm4QWFNUluw3KsDzQDwsIlzXgkX3Wb9jQTwhbGiMA/AS3ENNlHTBoBvZqxjOJJDvssiw3 Oc2S5Gyj6gy+2ysC9lUbBrIA2+VbBUs0jYbjk7fhVEx0NMHF2onewRSB0gLWtuBusf8AVskhuzlu xVIOjLS7U7Y+yYWOe4uFrpUcfnsEjiRZG2ZsbfuuOEFlBgt6zYqy8OAAKVJOHyae6poayX1cIUuN xDzfhEyS7iTwhe5p+wIS7S21t0Mjg4F+kLGdI4zWvwUVhYG4B/KAx/zg4FCMqYETtJP7JoY2TZ21 1JHNkdcn1DugdYm4NrIEW9gjkAabj3S5XFosByjb9uo8ofMu27gPhVEKJmjjBjLCflMtYBzj6jyF WGtp6qsEc7X7928BTEGiGoeyP7BwVQIewh5cdghkA0XHKoyOOxNwqIJAuqQFtje6O1kBAF1bTshE Q8qDlQ2UaOUKWBdypziDZWBa6Em533KAM3BFiiLyLbAoQLi6s7oCi0E3srbpI9kJNje6sAkoCG4P NwpexsrItyq2ugGeZdtgk6tyCEd7bXsg3ugKA3RsFzuhDST7Jlwxu6BBGMnZouewS7vYbPGn4VOm c1w0HdM9UwBed0ADhY3GwS5JbOA5umvjLQN9ksAfkoAnhwaLC5RvjBjFz6vZA06SoTcglAUNiAru LqOte6qw5GyECH4uo/8ACoXRbnfsgFgbogSNlNromge6CwLoHtBHCN7SVBxYoQW2MhpvsjF9HsmW s35VadxvyhUU1xA90ssBfqJsnPiEXqJ/soGhwva90IDHZzvhMmhLxtsh+0WtZTWTa6ChROpunuii 9LdL9lDHY37q3sDzcoWiib3srAuL2U8uzbAqwLAIQBwI5Vb+yY4WPF7oAC91uAEAYNm+90suAHCa TpBbyEs8j2QFOa4sDmgojK1zGgsBI+ETNcb9V/QexQzEOPpQWWacCzif2SyQ53Nvwo6Tym3Pfi6F v2hx3QDGuN/hUBdEwahvsFRbpKAsu3tygMwDiFbm33CGVjQwEc90BbHat+yYHF3wlRfbxZMHCAg5 Koi7lO/OyoEEoCE2Vg3CqQ6Vd/TsEBNQdsN0o332RwtLWk/5VuAPKApp2VPO6F/pICI2O5CAo3uq YbEq3ttu25QsDr3sgGB1jurDhq34QB1ydky217oC7a+Nktx8siyMk6dlRbrAPdAWeAQh27DdFtbb /KpwsL8ICb7BRzDe6uMhxIJsVHekHfdALLnhEw67k8qoSXXB3TIWNOoAn8ICoxrOyYG7JNO7S4tt bdZJcG8IBLwQ8e3skl95g0Gw7p+ux3WLv+qJtsgGltjzdWDZCXHUbq7oCat97oQ9znkWspq3Krk3 QBRHQ12rcofMLHXHBUa6xKl9TRdAGKgg2spqIn1n2SyExrdRs42CAtvJPuhdCHNIPI3VyO0Os03V G5N+AgFw6n3HYJoabjurjYGkkFEbB3NkBWj1XCskgq+OCr7/ACgF6bi4Ku+1jvZXa10BLggDvayj iB+6EklwuquS+3ZAG1+3whlIdblTUAbKidV7DhALGpjrhMLHPsTc/CbBC6W7rXXJ02FyO0u088BC 0cUGEW5RFoBtqXMzUJiY4kNuOVxL2+ooKNvOPUdNVUVTDNEHh7CDcfC1s5+w0YfnrFKZlxCyZxH9 1sYxrG45WOLSG7G61/dWWiHPGKvtdxkJ3X80/wAZOptH7vVU4cnyb3Na5oasxri9q47QHSBwN1nx XDQF+0SPy77MSuY0tvfdcFI4arAEALnaxoAJK4SYWksBsV6YHnkEz1NHeyRO/Q4i1lks9LA4boKt rDHqtuu6ORj0wDHk9irkeRMCDcJMUtnO22RSXkiZo+6+6rKPL2veNQ3Ti0EcWshfE0wgj70psrjd pCyArguIJ2VR1L2XaBt7qmuILgRsqsQedkBVY81LAL6fwoXmFjbDUfdWWi1ilhzjdt9kBTKkyO0E b3XIRiTbSeFx8bbPueVykZs0e5QGXE8Fu5BPdVLIA3YbLGZEWEuDr37JgdYi4uqgPYWOZZMEYDdj v7rEkZqBAOkFVDG+L+ou/K0DPYGgHXuUt4DthsEhj9UoBNyOylXLYhrefhAU+YRv0gXRuN7HhUbN aHnkBCX+abjb4VoBkuHG4RWsNwrabsIb9wXHwNqmVjnzm0ZGwVBlxzMc4gBC3SHO3uqqmsAD4zb3 AS43lxv2Qg7g7Irj90sOV6ib2QjDAB3KbDWGEkN4SBe3KiEKlldLIXd1TTt8qOHJBVN4QB6nNYR2 PZWwuACW6/A3RRlwQDzayV5Vnl3ZHf8A3Jc0o02BugKcA87cogLfKUHbXBsiDrjkIAi10gOk2KAu cG7i5CF8xjaQ07oGSOLdygG69vlDq7odSB8hay4F0AWtoO6I1ga9txYHYLEa7U032RFt47HcjgoY OSkqmxNGtwseyVI/zIvSLXKwHhzmEv3txdCap2jTew90NHIxxOFt7poB4ssaneGxgl4d+6yGVQds AhSObouDysdwa9pFrIjL5hN+VQ2/C1YQpsWjhPjdwEOytlieEsDrA8FLd3Cs+jf3UIJAVAs78cqv U3kpjo3DcJEhJZc8oRkleDa29lkQvu0uAssNjTIzYWWXG3RGBugQz9QW8ozMHU72AWLljvOwVMDm G97goQxadpiLvcpr5gbK5Tb90nSCLd0Aw2Lr3BASHVUd9zbdGXshJDu/usbymzSWABCAz2PDxtum MJYCLbIIqfygBdOcLx27hCgH+YowX29lbQALW3RtFhc7IQE+rYbJUlhsCskW02ssTTpkN0IDYubY G1kQBA33U0Em91ZNtkBQ+VL243VPOnsh1IAyQTujDwBykFygPsgH+ZvyoDcpN/dW1xO3ZAOc4tbc IPPc1ps3dWDb5VOcLdkBfma9zsVd7cJZdshEhB/8IDIB3VXultm9wrbIDygDI5VDflTUAq1C6AY0 tHKj2gC90pzxZCxxeDfa3ZAESCd0rSGu1BR7t0x8LhFqOyANkwFj3+VJZi82usby9RIuqMbmvAvf 5QDoan9PLpPq/KuV3mPvwlvieSCG3/KPSLXcbEIBbrgp9O8lhvtZDZpAIKZGR+yALWSFRcdXwrPO yE39kBZdsq1INW6EvAQDXPslumtyNkvzBa90ovDja6AffUbhDq2StehqmsIBhOyAO3UJ2uN0svsg Hh+yJrvlYvmAhG19/hBZkl9hcJ0Z1sBtYrGa7ZZEUgDCLICPbqN0JdsjIJF7JZABugKfs27kAl1C x4TJYxJFe/Cx3SGMDggoLDjaI7m5IKJ37JTX6t+PhWXboQIHflQgBDqUL7oULWEJcfdU4ghC5wsg GXCB4223S3ygDmySJwXWBuUBkEbbnZU3Ym26UHvB0kbc3Vu1Fw8r1fAQnQ9r79kwQh4Lgd1jijmq 43Nbdjrc+yDDaeagkcyZ5kB4QDXANdzYqFwO/JCOpic+z2C47oNLYmanjkd0KWXb9lCkh7X8H8KE kH8IA3W0+yEgPjIB9QSy/wAw2vwjLSGjTv72QGL9ps4E/KyWPGlU+RkbLO7+6U1gtq1WCAeDdEx2 nhKDXaLg3Ca1pLbkWQFnfjlW1zuELXAi6Fz7gAH+yAyCRq5RNkF0oNDBb7nJMsxY8Ai35VJZm3F0 QKx3a2AOG7ebhHG/W29koWPUAIultlaDuU0StPB2QoJ9R5Sy/Qd0T5A1Y0s0TvvfpSiMaZm2J7If NDthusdr6WPbz/MB7Kz5dtUTmn91CGYPsPZJABNwUcZcYwT3VhrWtuTsVS+gHO3FyqqXOkb6eR2T XUolYSH2PYLBfO6Fjg8EvBs1KIMDiyFusWddOgdDK8NmcWsPcJYE0kDXzQWb/vumCi8xgkDwW/Cg oORjBOY4zqZ7oqpzaVgDRcqaQxvoFz7qCWMf80XBUs0LIc8AhuxVubpFrb/KdNC0xiSF5I9liOqX XBe0hUhZdbZLkd5ZsSnsLXt1EBSqhY2mbI4F1ztZWgYnm+uwTo3tLSL3KS6F4cAdIB/qKU6EUsuo VAcObKEsz3SENF9gnwzFjA4grCZWNrC5o0kN9lG1ZY86nBoHYqNMtpnMRVodYWsnx6JXWLgSuNir Yp47Mcwu52KZSu1AvHI9lns0Zr6Rkk4Oq1uydKGEgaNgsUuEY1l1llyOMlJeMhryNiVk1Rxsswjm twsuNz7NJadPuuPljdHYyOEkvs07o3VNU+IRxtcL+44V5ByrnCQ7cBYtRIGO33RwzClY2IgumIvd Kqg6R1yLbbkKsAwudKftIATXMJHofc9wlsrD+icYmhzxtZYbJpdZfLqjPsG8rI6M4l4HINkxk4K4 iWvH6gNu0NPubLkGeVI0ObJuOyNNdhNPozvMuwWSJHNBQtlsbjfbsFbgyVuprt1EaI11iPZF5gHK SGHgFIM2mYMcSL8KkozPMB4UEobvssRx0SaXOAR2bcjXsO6EM02c0O4uiD2hoBAKRC27D6tTQksn jnkLW3aW+6AynX1EAWCWQB2umSSCIAEgkoDSyPF2kb7qUAdQb2QiTVxurp6V1W7yw71BLGiOUscS LGxKvILEukkFGJAUmaVwOkQlzOz1jOqvKcA4/wBgoQ5ASjdMY8BceakAiw1NKbFUtPx8FLKZcgBF wktnaSQeQl1FSI4SWm7vZIpXxzRlznhsg3sVOwZnk2dqa/fsEdU94EZcdhys/JmUcd6g45BheBYf LW1MrtLRG2//AGXpX/8ANudXYsINayGF8pZ5n6Yu9Vv/AJV2N9HKWWMHyeYm3ZGHM9V1TzrDXXAI 5Czs5ZZx3pzjc+E49RS0NTESHMkaR+4XzMmJx6/Sbnkj3VcGu0ajNS5izmJCHjc2Cwn1TYiWAaz2 Kx6fGo3zhhYbHbdfSZH6f451RzTSYJgFI6aeoeGgtB7qKLZu1RwDqgW9Qbf4KB7mmnDgQHE8L2di f0n88wZUfihrI317I/N/TNeL8XIXjiuyvVYZmKbL1WPIrYJvIk1H7XXsujxtco4LIm6MQ+Yx7SdB jI5B3QyReWdQeXD2Xv3pr9J2DOuT8Kxt2aXQvrYhK9vOm/svi/EV9NjFehWS6zNFDmNuK4ZSbysc 2z7fhSGNyMyyqLpnjfQY267gtt7pcYkc4mOSzb9wvTXg48Ez/FJQ1uIVmIyYXQ07rXA3K9UN+j/g VE0OjzfUut/Q6Ow/uuvip0x5qVmsYVEEZaxzg53c3RseyWV/lmwbuvevXf6YUGQOntfj+GYm6rmo 2GR7fcLXzRSGOZ2pt/KeY3D33ssTht5RuGVS4OVEnG90bXAg3F1iVA8qr0Da4uPhOGq+y4o7DHaW n/aUJb3G6Z5XmNBO5HdCWlhSwU1vCvuq1HVxYISSDwtAcJGFtrboXG42KoM0sv3VtHx/ZSwJc0M3 tumsLXfc7SE0hmklwS5GtawWQoFx23PujYXBtwlgWsQLBNa7YIQG5c/lWVQFiSoogWDYJTpNLky6 DTd/uoBoDdIcW+r3Va7uOyNjtrISLNNwgIDc7hKkcI3WG11N+f8ACjtzv2QFaQSrJ07W2VB7bWG5 Vx3IIPZAWd7bq7sI2tdU0b8bIWxhzyeEBJrNbzZUwEAE7q5G6yFQuBYoCxe1rKAb78KxwqO5QFtA H4TbggWQi1t0DpfKGwQDHixsgHJumRy+cwA8+6U9pjcfZAR3BsgN9vdE1wcCiAGyqAIvZSQ6RwmE WF0sjzAR2WgUCS26p/rFr2VjY6eAiMYvcG6AxXR2euawHCWVlHNNNIGFp9IK47aN4cReyqsdLKNU Uvlt7tHdANlaGvc1pvZKJsD7qRHUy3eyFrgCQUBHNu2/ZL0A8/3T7cb7JNW8xNHli5PKAZG0PBbb ZYz4zr34BXMYZStdQPlc4Bw7FYL2A3N1CUUHiS1xsAseaBjnarJrfjhEWBwFzYK2SjjhTMExMYsh 1XeWrkf0rQ67TsqbStaSXALVmWjjHkHbe4SJIgACPuK5Z1O0BzgOUp9K2RlxyFqyHDvp5Adm7Ktx 6XNuVyBc9h03uEIY18m6pDAMJYeLK3Q8W3WaWXfYjb3VyRaNxwhTALQCBwgLAXg3WTPGLXWNGwFx 3shB4aPfZY8pAJRl3tuseS4B3v8ACEZjltpC7silkOgFlwmRR+Yw3CsRkNsG3uhBRJ0Cx3KaLgKj SyBoLhYJrdrG23sgDhs4lSJ/861uFJ2eVZ7TYFAJtDr7XKAbOSHBAL+6oyguN+6ovva3CpbCIubB XcWsdil6yHbcqEan3vuFChHbburF2vv2QSHWBvZFewA7oZDMzmuOnZpSZIQy7gS4lHr9O/KjHBvK FoTq9wnMu0bG4PdSQExuOmw7JcAe6LnvwgoYDbYqMadRHAKJrbfcjLA0goWhUrdILWuLXHuEulY6 JrhI4vJ7lPk/mPCF7HbAAoKIXWNrbe6DYi557I2RlxIKt8Wkb8oKFXc5KkBJFish0ZsN0Bbbbugo jHNPZQgadghbweyjJNyLITosEFE6QNHKUGuL7jhM9LneqyCw4XNLDYi5SpJ2sc2M7uPslyRu1WYU NJE1kxkmO44JQWZFwBY8oNVyQCgkkMri6M3aEvU/YxtLnd7IVDg0Dfuq1XdY8qRlzhdwsfZUYyH6 roUPdjflUNXuqkBvyivcDZACR88prWgRlp3KAtt8qxIAT7oQBg9JBFgoGAXsdkeoWKFzgG7cqlBs ib7qf0q7ekKEBcqt7I72/dKkJ8wBiEZklrjFtusKWMueCsuCSQzGHTcEX5RGG5O26FRhhgvYbJsd gLJ0dO0k32KSBaUtIQBGx4QHc2RG97WsPdWAOyooD1B3GyJzRsQr5G6oiwsgBv6h2CNj27hA7dqZ TtDmk3AIUFD4i1huL2RP1XuBcJbJg4aLcJ0h8toIOoIUUxjpHkFZjGeW38dkmIEODrLKiju6/upZ aKN5Wh1t+ydGCWDULH2Ul/lgcWV/7Ss2aSCawAbK9NmndWQRwFC3a11k0RjSI78pukaRblLa8Nbp TNbAABystgqYEgFuyS9pJFzY+yyWOUNiTsCQqgILQLCyJkYvYq7Ek27KiCN1QNFmD4VtDSbkpYBe 0i6p3pZ8hAETrdv2Velp2KXHJ5j7cInvbGbIAhyr44QtdsT2UY7dQBF2x23QsknDiHWERVg78Kar g3QFE7m3Kg3+479le1xuN1TDcnZAG8HyLA7rGZUCm1AjU52w+FkSWLObJJMb225eqCMuWgXuoebB U0EGyjggFzkEgA3SXs0HcXBWU2Jo35uikYGC5GyA4xzWB2zfSEWvRE5zW2F9ghl9LjbhLFT2Lbge y0B2rW0G1vhWZzUMDQLWSBIXvNhZvyqkc9hvCQfdSgOeC9mm+4QtiDRxYoWSOcAeXd050gLT2d7J QLZJva26oy6fyUIjdp1DlK0kO9V1KBkQ1Hll49wsSKJrA8Wtc3RkWJfbf2SngveN7LQMlsv8vSNg hZpY0jkeyrVpAbb91L7oSxLXvbLqI2KOaTX2R6xJYOtsqe1pGx3QpTH+gC26JzATclCRZu/Cp7bx 3vf4VRmyODJQW3tbug8kFvpfuELyG7jZVDpaNWr9itCxgFjYm6IuDrbbd1NbQbnhC5w3spQKLgSG 22UY5oaRyENw47C7lCdrEWSiGZh1QKdxcGj8lYtVIJZXEnkqNdoAsEuYgt2G6UAGeq9uytzvhUy7 W37lQtVBRs4WVOI27KAlhKo7/ugLBFlWq/29lWnZGwEBCItCbg/CMDuqtflCkFuQrab3KrTpOyrU RsgDHCs7BLuQiBugD/pCE7EFXdCHXuAN0BZ33AuoY9LNX+E2mmbA14kFyeFjvLnSAg+gndAXHJ2U qIy9uyOzdQ0i6IuCAw3DTuDchZUN3NuRbbhCNDX7hNBDiSBsgKk9TR7hLcAN+6N7iNggNrWPKAAD fdWTuoQhdwgDBuqPKptgFC4A3KEsIDfnlW95YLHdKIJcHDZqZLY2A5QhVr8KWKgOyu4QtFqAAndU rBsgoh5so7ayl1G7HnZCjA7i4upr0ttZAXG6jiSgAc4uBUZsLEKd0X7ILIdwrFrKtgFCbkBCWEeA gABKu5vyruAhbL44Kjmuk9Q2Vb6bI2Tf0/KAqWHS1pDrjult542WRLpI0g7FJDQTZu5QlAOlIBBC CVrYGa77nsmuO5BFyhOn0hx1OJ4QUYxvUMBOx9k+NlmgFH+nIkJ/p9kRcNW3ZBRTvSBdWbEXVSDX ZRp2tfZCC3HSFLAD8q5AC6/Ku1yAgAtbhECr0nuoQRugBdsCgGwarc4lqE7oAqg3LAO/dE4NjaPV cpL7kj4R7PsfZAWXnTsoDdu6px2AVFwsgLa8dxdFra8W4SxYGyOwAtblAELe9gga8tfbkFQjYhDv xwgH6dj8pJDgbXQOlcEQeXAlAPH2qr23Qxn0qnut329kAdwRuhHp/wCoKtQEVzuVbXny7jugII99 XspJIFYJ0lLcG6ed0A6Eta0AclGCQ8m3KTG0gtN72Tb2PPKFoEm0oGyN1rXPCS5w139kZkEsZAG6 FFsJc4nkK/L+4lPjYWQ6g3coTGQ38oZEBypH5ennlJJ0lAUXKtSpzgh1bIAy65V6kAN0SAvVuqqn uLGgbAeyg/Cuwvc7j2QDQ5ro2kjcIg4e1ksWRgCyAImwSXEhx3Rk2G6Hk+6ANrhYX5Rm5Nwk2sQT 2RseTwLIAnOIdZDe6OzRcjdyTd73X4CAJztA1HshILiHDZEbHa91A6+wQBNFzvyrbE7Vwd1TXWPy nsmI/wDhAlYFO6WCUNsQCeVzRxfyYw0jcLjhL5lgW8d0D4tbiSdxwhoXWVUs9Rq811u4BS9YO5Kq WEt37lL8m+5KEZsnxnMYERbq2PNl5Q6uRtqM21FTf0OHC74xieVkhDuwK6B6jzmWvm2OrVsV/Nf8 avtZ+21LuJ8hC4AgBciwXA9lgUr26B6d1ntk2Gy/ZLo/OPsxq6O7dlwtU3Tzay5uqu5ht/lcJPE4 vueAvTDo4T7AiJLeLhOdE0sJKOkbYWtuVdUzSy17XXc4nCSgMmNuFlU0d9z+ywK9+mdrQbOuuXo4 yxoLtyAr6KEWW+Ep7e4CZM4uJduAlRhzjsbgKAuT0t3NisWQ6bHUuQkhkcAdK4+oaYwQRZygGxjV Y3uETrHtZLpzaO/ui3cdlQC30n8rOgdvZ26w2sOyfHKGk3CAz2sA7q7AEHlYzJ2uaXc2VNqmSX0n daQMouabn/CWZr7NWPG467kppAL7ggLTA6nhYxjyTeQ8JcbC0nULn3VAG1wbJrjqaPdQFts4kHhW CGbBCbBvskSOcwDe6tgyo5RG642WNUtdK4uLjtwl+YQfdG6QbXulgS1rhseCmtcA2yXJJfjhAX2N 9yiMMyNYRtcsQyXFwrbUHhUGXq2UDrhIY8uKYSA35RgMomkWtwUsHa6hkA3KyC3PMaoSucR7KmSC a7b2TG6QNPcKoEdI78oNidygnc6MXtf2Srvf6gN1QZGm/KogAbJes2uSL+11AS7g3QFOiuSQVZaQ 0fCF7i0KeaQBdUBh17AoS8E2KS+Ql4srkYCLteAR2KcgJwAO3CHWADva6x3PIPN0uQuFr7E9kMmW XarAm4U/TRyyWefT8LFE1hYmx+UTZiw6ibD3ULwZRwSFjw+GV9r8E7Jk96dwDNxZYQxR8b7dvdHH XumeQG3VKZQ1NZc8lG15IugLzYBygI7FKMoY3e5TA2zbpbXBvJur8wXSjQUfrG/b3TdWlJErf9wu gdJ8rQHul0uKxZST8oS52oOJ2ROlDANr3QyxkJvYWTyA1twbpEUrC6197cKi/wBVr7IWxrnXIQ6h dA59uTZYzqlrS652CGTJMjTyoHsG9lhOrogNihbXsJLUBlvgbO7flMggYwlv9QWPHNcXBVR1mhzi Bcnm6tFM0SsJsXBE1zbbFcYydk0ljE4+9k+Owu8H0j+nuoQzSrd7LGa/UPTumawLAlAOGwWPIPVy mGTTGTwsR1UZAbDj/KiKxgKB0rb7HdJdMHem9ilMpZZH3BslEM0jXZA7a6WzXC8NIure86rW7qgF zyON1Qkc4/bb5Sqqcxarct5SaeubUMd/Na23LSgMts2okDeysOfbjZYTGshJmjcXH2B2WUzEj5QD hpJ7kK0y0xwkLSh88PNrKoa2GxD3MN+4N1hT4jCJwxkjRc8FFFkMwye+ygncwEAb+6VU048psvmf tdcdNXshsTICfYhKa9Gdy9nL+c4MJPKptS0i64ynrjK8EuaY/cFMnxIMlEbacuaf6wjVGr/DlWTB 3CNsgP5XGxOltqFtKcyUE+5UXIMo77ndQm29wFjOk9jZU+ZsYBcbq0DJ81geCdwmS1PmgAbhIEkL wA3nuELnthH5SgFI7TY3srbK42cFhzVLb6XBx/HCj6uKGAujcXuHIKgMz9dKx4DmmyZIYpHBrpNL z2WNhc5lGupbdp+2yzv9P4vXNM1NhU8sDd/MLCbBaSvpBuuwf0rG2IkuEkTN1FrSSRysfTLFO1jm +VIDYsfsf7J9RDVy3kpKSSbT9xjZdHFrsiafTGea5vKMy+lcRFibpnua5uiRpsWkWK5AlxpxIBcd 1kq56Ce/blY0szoyAdyTYBEzVLYhMiwmqxGoayJhfKTZjR3KFQDZWvGlzS1yTIWiTSCV2nF4Vepe J4ZHidHgdTOxzddo2HhdaZgwLF8n4kaPHqCooKgG2mVhH/cLpsb5RyeSKdA3sAOVBKz+oWWKxsgl DrFzDvdOqJPMsGtC5nQa1wLrjhW4Ruub2WI6R2i9tLh2CuGR7hqY0auPUqlYYy7CTpOojmyGOYSu 0m8Z+VymS+nuOZ9zNHg+BUzqmtmO1uGr0Hjn03+s+H4S2tbSRVLCzWWNPqstbX0Ybrs81sqGh+nV ustjyBYhKxfL2JZMxupwXHKQ0eIwO0ua7m6SZ5o3gFzSOyji49kUk+UckyQaeULtJNlxpr/Ldpfb f2N0cdW15JcC32UpmrMme7GkAm3wsRj3FpDwTbhZEJeAdYHlnvdIMzI5Tpe0j5SiWg2PBGyj3aRf lL/V05eSX2PG3Ce4MlhJabhSioWHhw2VGUBLihsTpcCCkTVJilEZjN/dWrBliUBAZAdvZJ/VNP3W HuqZIyUkgiyUA3yA/wDwVmUtIyrga6MWkB3K4uOgFXXNeZC1jebcFdv9IukmMdSsWhoMJo5JWSOA dK0XAQ3FX2dZzCq8wRvazymnkHchP8uGEh9M8au4K2n5L+lNk7EcvQ1OOYvVwV0zAXNbazTb5Xx3 UL6SWH4L5ddgOYZZqSOQGaN/pdo7kLvjhGSps4SyxTNcbq2kLHCaUslttpK47+JMB0knbgkLcBhf 0q+kWMYFSzTVtdLO6MEyxSjTqtv2XDYl9KLp9UU81Ng+OyisZ2ls7T/YooK2n6OM9Qo0anX12iIX cLH2Kw34o21pW+ntdbYcqfSSyWyR8WYcw1dW9w2jpgGho/dedOo/gcyz038ReCZJo6uoxbC66Rrr Sfe1rv6TZd44FN1EzHUqR4g/iMG93AewBTBVNqBZr7bcrcB1Y+l10hjyFiGIUUVXhVdS0pla+N+2 oDuF5c6ffSozZnvBv4tHiMWFUUtzTmbd0jb7Gy5LGmrs1LNtdHh2nma+VzJH6R7otPkyEx1LiPYr 3ZmT6RPUbBsNlrqHHsNxBzG6v04uHG37WXc/gr8C/T+XD66qzvBHjuNROLJqOVwDIiD7Ba8Nx3Lm jK1Mbrpmq0OdO68gc4N/2gqo54Y5izU63s5byqjw/eG2pzOzK8GE4dFjD/tpqd3qC86eNT6ceUcB yDiOcMoVElFV0DTI+kfbS8ewsufj3Ol2RapI1qUgYY3Eja11VPIah7234WFR+Y0OjlcWlhLXA/Cu nmELpC3uVxlFxdM9sZKStDJmOgcbPBHsjLo44vMc7SOy5HCcl4/mCI1VDg1ZXR/7oYnO/wCwXJTd NM5wQh0+XKxsY3tJAb/9lqMW+g5RXFnzVV5sMUdRE4EclZH6fEcQpjO6ilENtpGxkj/svrMldMce z5mSmwelwuofK6QCSJkZu0X5W6foN4YMl5b6VUVFiWWaeqrHQWlFTGC4utvylVwYnkjFWaIqKqe+ F0ccoc5nayyKKpdOx5kBYGbOK9I+NDw/YtkvqrVVuB5RlwjDpZCGQwtu1/yLLpZ/TnOmG4aayqy5 WRUzhdxdCeP7Lo8ckc8eeORHBMhim3il1BCKdtyS/SB3uvs8J6C9QsxYN/FsJyfiNZQHmWGE2C4b COm+bsdxj+C0+DVJxDVpdSmMl4PyOyLFJm3lgfPCpaHOYxrpR/uCyMsZGzDnXH2YdgGHuxCslPpi aL/su4T4HetlPTCpfkyrjgc3UCG7kfjlcz0go84eHPqDg+IYzlzEKSnhqWmoldEbBpcAd/wuiwNq zHmgfE454QerOE4d+uq8j1xhG5MUZ2/suoq3Cn4XiZoa6nqMPrGGxilBaQv0r5ax6izblHD8VpNM tFW07ZWahcEELUj4mvChnXr914zXX5RwyFlPQHSQ0aA4j22TFgeRNr0eWeqjjklJ9niVrJIrRl19 uyfTi82l42A7r6fqT0Yz50XroaPNeDOozKLRyEchfLU9Tqie+13s2J915XFxlTPoRkp8oj6aZ1cJ g+0TRwF2z0h8MHUDrrK45Zwovgbu6eUaWf3XwlHR+aKSNrdTqhzRZb0/BxlCDJ/QbL8MdNHDNJD5 kjw2znXHdUs1tRqU6ieALrNkahNZJgLsQpGtu4U/qP8AhednCqoauWiqKZ9DV079MsEtwQR7rfnn /wATOX8h5vhwjF9UdI+7XzSM9IPYXXhbqx4F8T8UfUfGM55ClpsLw2qmOoz+lrz7he5aZ7d0+EfK x6yMp7ezX1PVSF40RhzT/tKJ0sYY0uGg97r3ZD9InOjaR/6nMdKZwLgQ8X+Lrr+h+m/n+bPJyzLL FE4tL2VdQdMZH5XNafdbiz1fLgnR5QAMptG6zPcFBPA9oJMgePwtgeX/AKSOcZ6p0eLZgoKOk41Q guLlx3U76T2Z8oYNNiGXsfZjDo2lzoC0g2XHYvR188PbPCNO27QLbIn1uuEtczS1rtIv3UzBRYnl HHJsIxWF0FdA/Q5hBCRMyWYtDo9LAdVvlYar0dVJSVxPSvhp8DGOde71FdVSYVRv3idoPqHvdeja r6OTYoy+LOAd/wBD2WA/ddK+HX6h2dejlFHgrcv0uMYdE0MIBs8AbBewukfULqz4ts4U+MTB+UMk Ujg/9NFdr53Dtq7qYouV2eHUzlBWjxV17+nJnbo1hz8ZE0eIYPGbPnpTqeAeNl9t4ZvpjYl1cwGL Hsy4i7CMNfvHCW/zJB7/AAtp2ec0YLlyDC8MxZkNc2ue2nbSzWcXn3IPKy84YHiD8l1lFlh8eG1Z htDoaABtwPZd9q44PMss+r4NT/i3+nXgHQfpvU5swfH/ADpqeUN/SucLuBXiyF7Ims/4kREtu5p7 r371o8GfiMztDVyvxd2JYX5hk/RTT3/x3XKeDn6e2FZwqcXreolE6Q0x8r9MPTZ3denNhThuvo7a fUOS5NedRiMUto43h5HNisunkM7WQQ6pC/8AwtyOK/To6BUb2U7aI4bWTj0l1R6nfIBXl/xRfTpw npHlWuzplnHXy0dCQ+Ske4X03vsvHDFfR6vlJOpHPeD76eOXOpORIsy5qqKgzTk+WI+AP3XIeJD6 YdHl/KOJY/k7HZmS0UTp3UkrL6gBvYr1D4B+pmEZ76G4VSUGmOpw9gZPHfcn3suzfEFm2iyV0dzP itdI2OnipXg373FrKY4/ejGeT22nR+e6CrmpKh8VQ21Sx5jdq7Ecrkmi4N9wdyk43PFjuasQxGFu mCaV0jAONynYk50UAEe1xytanD4Mm09GmyeWG5n1XSzLeH5gzxhGF1fopqqdrHu9gStyGTPBX0oo Mo0UU2XKfEJHxBxqJW+rcLTf0+e6HNODTRbOjlYSf3W+3pzioxXp3glWOTRMv+dK82P+RnUy2wNY Pj96TdEunlEykwCNkOZ2uOqCndfy/a68H0Ym0aIaaeR4NrtjJC9D9esvuzR4psfwytmcwVWKBpfM 7ZrC5ba+lnh06c5YyHhMUOXcMxEsp2OfUmFrzIbbm6+1qoQjji/Z8rR5ZuG9+zQxHDidMwTOw2oE HdxjIQMllfKXwwSSauzWkreTV4V0azRmSuynimXaHCqtrPSKiIQteP8ApK5fpz4belWWGzU2F5aw vEo5CS6d8bZC2/b4XzvFGm2emOrbdI0RMmmmmDBTv1g20gG9/ZXXQ4hSzWlwqsiv9rnwkNP4NltO 60eFDCJ/EhgL8v4HHR4O57Japkcdoie/wvUfV/pFlbFulVfRyYHRWoqNzoXsgbdhAvtsp4FFrd7O 8dV3fo0TM6W52xijbWwZWxGeF27XxQuN/wCy4ary1jWFB8dZhtVRSgX0VDC2391vQ8IOHT03TGKn rMKbFGHuMNRNEAZGX2/7LkfEj4fMo9WunOMx4nhkFNVQwumjq4I2tkDmgnn2K1LHFSpGXqm47omj jAemWesew39dheW6/EaI7GSniLh/hcxhXQ7qNiJeYspYjDp3LpYSB/2W2rwB5vwrEunldlWLD4qe XBpnRlzmi8rb8n34XeGc85wZYzRl/A/4bTyjFZC0ekWbbk2WViUW00c3rJSinE0MR9Mc21uNSYWM Fq5cSiFzTxwklfS5d8O/VDH6v9PS5PxTzezXwlv/AHW5TrHheF9PcWwPNWF4TRUkzKpsdZMyBoMk Z7G3f5XYebs1QZcyVV5jipGSGOHzWCwBNx3K7uGNKLjHsLVz5v0aLs6+HvqZ0/phPjGVqmkYRfzW xkgfmyrpz4ZupPVhsjsvYK+pDeZHjS3/ACt4uA12CdYciQT1dPDW0lVGPOhc0ENPcLm8n5LwfJGH /osFoIqKnBuRG211zmo11TJ8icqrpmkLHPAZ11wWlM0+VZZWblohs4kfsvmsh+FTqjnDGazDKXLF RBiFMbPiqWlpv+63v4h1Ay7hdWaasxuip5hyySVosuoc5dTMsYR1ly5HhmI0lVLW3jqH0r2uAPa5 CuPDb5RzeokuU7NXH/5uzrhVzb5dayMbuId9q696q+FnqH0cp21eL4XUPoTsZo4yQ0/K3t9ROotD 02ylLmHEJA2jY5rSbe/C+EzZ1R6e9SemGJtrsWwyelno3PfBJKwuBLTYht73W4Y9y3beDOTU1JR3 U/w0ER18jy6ExHVe1yNwvYng+8AOI9c8Pmx3HfNwvCgR5Ur2kGT8Bcx4VPB4zrR1exTGaqlfHkuk qy6NxHpmAPAWyrqz1Qyl4X+lb6+dkVDh1HF5VPSxWBe61hYLlPFtmkj0z1C2Wz5Tw7eDzKPh7qqq qw5grauQemaZoLme9l9IzxIYA7qqzIj6acYlICGz6bR3HYlYXhNz3V9TOljcx1j3vfX1Ekker+lh OwWDnLP/AE2wLqpRZfq8NZ/qed4MczIvUCe911hDdKqPl5MkqUkz47x29Bsr576P41mKqoYYcYw+ EyR1LGAPf8E914x+nb4aunXWdmLMzeBU4pRyeij1WcW32K2Y+IPC6bEuieZaac2iNC5wLve1wtMX h0o+qEnU+qn6VhzcYbM6Muv/AC9IPdadTw2+0dYTeLLsX5yerfHn4Kum3SXpbVZ0y89+HVVG9rW0 j5AfNv2Cy/pgY7kF0TZsQnpKLMzmhsMdQQCb7bX7rz54v8t+IPDqKll6q1xrcOmcHaab1RNd+2y6 R6WV0WG5ywbEaeWWOakqI3gRvsDY8bLw8xR9HC3ktn6Gq8llHUyNfdoiJa223C/O715Mx6yZxma4 sf8AxORwI2P3FfoByni/+osiYXWh1hVUbCD+WrQz4maaPCevWb6d0ZaP1sjjt3JXv0+PdCSPG8t5 4o9ffTZ635nzP1Po8DxGvnlw6OlMTYHvJbsNjZex/HvHLL4asxww/c4NJI9r7ha4vpwVk1N4hsEj pmOe0sd5hYNQAI7rZ14y4WVHh2zg1zg0GlIaT732XDEqyo9GsjSaR5V+k1i07nZswtptQQsZIxvs 7gr2V1865Zf6EZYgxrMEUs1NLL5YbD9w+V5c+mD0rx7KGTsRx+vojRR4m67fNBDnDsR8LkvqqUMs vRSir4pNH6aqs4E7EFevNjTz7UzjkyqOLg4PrV9STpRmnpbmHB8LfWvxGopHxRRSxaRqI23vutTe HS6Q+ZzN55nP0nsmNjhrIvNf6rm5NlmxSU8UbWxsL/YlebUVjXjR30sZt75Ci10tX5pvxZZUbLHf dUDr3A2RXsV81n1aGB4ANggfd1kL3W2VtdwRe3yskKG4sVera1lQIuqNrXVsF3J2uiAt3QNsSjdc 7DdQFSXsAkPJIsEwklCHgHhAW0WYL3RtNx8qtYcLKh6T7oArnhSyG/KgcgLcAVBfVcBXq9Khd6Sq gQEhxsoX++6om7dghc25vfZQFixCAxuRt9Q2VuvY35VsC9IG/dWb2+FTRsbonFQFBxAG2ysEA3tu qaN7obnsgGusd+FWwabpevm+xQ6iRv2VoDb225QgjUg8w8cBRxANxuoBmm7uVHt7BEbOAcNlDwrQ B3YNtlc5JgBPKok3AUc/UA0qAFgswJrDtyqtaPSFbAGt+VQVIbH4KV+6bINrpJdqG2yoCDNe97Km iwNjeyJu1rorBriR3VAHq7i4Q6bu34TQNZQ3BuO6lgUXjWbCyK+rkINNyQmgANBVABJvsrjdd9iL oS4X+FA9rSfdAGZHMkIDrNPZLEoe4sPCTLJd3dAyTRfbZZoGaGADnZEWWH/hYTqp9hpT4pnSsBd9 3GytAZff2Qued+Srub34V2BCoMUve7a9gmMJF9kflAk72Uc3S0lDNGDURhpLri/ssaSXyvUbWWVK 0OvfYrBm1EabXC0mQyGzCRgLRcpgddmk/csWGUx2DW8JzWHVqPJVFFSNDm2ISPIZfcWJ9lkuab8I g33SyUYUcJYSLbKGhY5xcQdXsstxDdxwl+YSSQPwlkox3wtiO2xPslEHzLGwCdLrPI3PdC6leGtd e9+VbJQuqlDS0M9SU91mj3KyZaQaAWm/ugdE135VLQPlks0u/wC6VJE24724VyudHfX9qMbMDr3u EIQRsaDcbJJYS42+0dk5pY4WJN0kygnYekIKC8sOAIso5tzygvcEtJ0ottjdCAvOhwHZMaxzze1g hZG6WUbbLN/TOeBpda3ZCiHUxfYbhKMZabA8Lkj6GWI3WA6F5LncNUAcJL4yHAWHCsxtY242S4CS zb3Ti0uaLqlF6gdiLprXtFrjZAYgra254ugCs1ztuVem3KBrP5g7InNdr5uFLBb4wRcFCWgi5Fwm aQbt7oNJbt2UsAEN06h/ZLLPOIc3b3T4gA8gpb2fzPRsFbFGPKyzrImQ2PwU4wuc/wD8rLgiGjey WSjFFPpaSVieXeY7rlpLBpNuFxxaS4uHCpKCAGk2CVJhs1ewiIb/ACmCRoAs4An3TnSS01mtcWg7 3CCh+HYdHQ0roZgPNd7rPhw+moIw91i472XHxuE7mmRxJCKocJN9RuOAhUcbiMUlRUOljPlxgrHc 14bsb/IWcPUHMfweEDI2033eoFCmNF62HVyrhm8txbYHdMmaRuG+koYodRCAsanPItZJF9e43uuR MQJ3HCW4AuJ4I7oQxZHtY4NdsUoxHe27VlPp2TMLnmzuyxzN5DbOicW9nDhByDBI2e8YOl4901xL G2vdVHDESJWjdESHmxCAC/wiabOBDdygcdDrHhMbIQQRugBpXuFS917WCy2ya91jwtGiQnkoopGs uCgI92p7bbWO6klnPJaN0FwXmxVu9I2KFIW3tcomWaLW5Q9kYNgEAqRpAGnklFNHaNp7lNDrDhU4 6mhqAEwkRJTY3cBZum7A08JZYWvBHCARBTyOeQ70rkYNMbdLvUlN3RA6TdRgY1p1aj9vZPj/AMJD ZC8cprAQB6llmhzWh7jt/dTyy91gdgqaSAB7pkYDfVe65s2UROwnTYtUaXvHrGlHr3VF1wiBA0FE yIXue6VrINxsn07tbS5w3RgoxGPe+ykfqNxymmxPCEAA/KqBflWvbYlLc3YglZJI03Sm6QNRFz7K gFjbR3B3Sntcwgngo5Td3pFlZBcwNJ3QCpHMZ9nPdWHNkbY7lW2Oz7Ft00QBpLgEAkkBtkTSLKnw SAXtspGwk+rZQBaiVVgbhE8ad+Alk91KBVtNt7o727bISL23VOdp2tsiQI43CAMs6+yK9xeyobha BHG9rHdEXB4tyUsOBdwmxtDTccoC4SD6SLFPliGix3QMBkdcdkUlUASD2CA4Srj0yG17KQRbG4uE +oe0uuVcbhawRAwqgFgvw1IDtiWHcLKqmuLTcbLjy0tcbbBaIZMch0G3J7oIXF0tz27pbHltgO/d ObayCx5ncAQN1Ylu0XG6SWkbhLY9xcW2vdCWZb3BzdktttVzsnCAsi1X3SDZ4J4Qdlufrcqc0u43 VxsuCjhuHHZBQljCCSVd+/ZZD2/CSW2Njsgop1pGgJjYdTNiqZFruL8I4/5TfdCow54nBzQ3cIY2 ayfcLNAIPHKMU2kamjcrVijFsCACkxvj1EE91kSwutqcCCVjvpTBJrI2KWShrnCIhwF1H3e4HhDJ 6rf9llRMa9lzYEJZDEk2eEJcL2TQbyEEJcmkH/uqALEonC1hdFHZ4sELmE3vsgJsTukygg+lM727 oXS6HW5QFR3LvhG46LWShOCfZFrFroZHhwdHsNyiZH78rHjfd6cJt79whoj+SkndwRF+t17WVXuU BByr7oCbbogdkBas7EAIQTdXyUAZZqaQ5LLyGaUepCGjlAAz+ya6zOTdGGja4VSRAIBbTqdcpjAG u52QBosd9kbQAgKlBa2/KU0+sXWRq1Gx4S3RA/lAC4juULbW4v8AKPSW7FAXhp3QMYAA35S3t23C szMPwhfILcoQSZXu9PAVMe4O97KnOvdUx1roQybahq4srSmyImvHugD7KtzxtZVqCHzAB7hAM3/d WAQkiYdzZE2U25QWOG5UAICS2VEXmw3Q0GfypdIdJfvZD523IUIzIvdWLcrG/UNA53UNRYXCpDJD uyslYzJySr86wKEMoEIXbBLbKNkYIJQ2Ed2C53RRANjd7+6Bx9KDzrNtwgDbER6ibooqdjZfMB9X O6UJPTtujfOWgEggfCAeTfVuAgIDUjzRa4ddB+oFtyhmxpNt+yHU0hLM7LbusEt07QdiCEJY4uGo C6jpRG65WNJI21wboGzAtcCdzxdUGeZw8BV5lisITOLfTYWTWTax8jsoBzjZAd+FC/U0drJckul4 shQgN1Y2BSxKO26IO1BAFa9k0w3YXWSRJo5Ricu7j8IBeog8bhG3U8g+yEvGpEx5/pQBF41fKm6W 9jg7UoZwCgBm9JQwtOq/IUkla48hUJg0boQySQBslPYXHnZAJtzZG2QHlCltOxCNrhG0AbkoQQQi aN7hAXvqQvj1cK3O5ukCqAJCAy6YeWDqTXFrhsL/ACsMVBLgDsmNfY+yFQ5lOHyNHAKZWMAMbIW8 clA2S1iOU91QGkbboUqSoEEeg2LiOPZYfmu2+E6UsLtbrBcfLWXJ/wAIRsbJUG9ikOluflKfct1E 2JQNAJ9VwPdDATnEnlV5hG3KotBO3CmggXsbISy2vt3TBMCk6b9lHMLeRZCmQyX5VmVIaxzt2gkf Cmkj4QWNc+4tdNa9zjcHYLFaxzybAlWC+MHex7goLGuleSQN/wAKNqTqsRugAb6dJdfusqmwmqnh dNHGXNHxyqk30G0gG1Ad2RiUX2KxnNe2QgsLSOxCbFSh0Tnl4a6/2lQo9rhzdG94DVjRaXvtchw9 1Wu8pYSAB7oUvWCeeUD32PpclPeHbAIoKWaokEcUT5XO2DWNJJQy3RTah1zunx1DybkWb3cuWdkb Gmw+YaGSMAXIeCCuLGG1zpP07aeR77/YxpJW3CSV0ZU4/oxlVoI3TRVhx+6yzqDp9mCuLSMKrGxn +p0ZaP8AIT6zplmClu40ExZ/utdVY5NWkPLFOmzinTattQKxnOkDjYCyt+G1LJPKbTTOmabOs0lZ Dcu41I0Obh9S4Hv5R/8AhPHL8Nb4v2bHcx5ImnDtH3Lyb1dop8Gx6eBzS3TvcjlbJZ8rR1ERDd3k WXh7xZ5ddg+P63sLCdr+6/lf+Oz1lUT95qsNRtHSFC7z6drrWJXJRNAj3CwMMmbLSjSBcLlKWnMj S5zrfC/cro/NNGFUAB2/C4qrteze3ZcxXWYbW3XCTyh0nyu8WcZBQm/OyCpILTfa3CJouNkipuRb suyOJwz6f9RWhx5C5mC7RckXXHBpjkuFyERJiuRuVp9EKnlJbayUJ/04DrXPsmyt/lAgXSLF1iRu ohRyVNjLHMDHMse2yxMSLZXGw9RQBvquRb5RSG51WUBiwt1MIOxCY2Mg/AUZYPO+57InvIab7BAA ZQ3vugY/ziWg290h0jGC7/t7lBhMVbjVaaWjh1ufs23JW0Q5jDY2Uznea7U13ZXLQNbKHxuBBPF1 99l/wy59zBSh1JhlRIXC4sNlg5p8MXVPJNM7EK7BZ308Y1XaL2H4XVRb5SM74nyEsWqTRbTZVJdp AAWLDWulb5knokabPYeQVmslbIL8rBpBxn0/+E1ovwEhsg323TYr2NkKE+xFkl7LCyYflJmeW2N9 kAviUC2yx565kbi0C5RTS2u+9rBcnkrJFfnbEmUtFA+UynTdoVSsjdHA/wAYivoIOv2ATG1kUtI9 42cDwdl7Dy79LnM+ZsKp62mxZkFTONQhkFiF0pmDwk5vyj1LGUax7J6rVpFtwd7LWxnn80Wzp8VL ntJaPz8LKjAMBcZGgj3Xu/Lf0ocex3CY62pxtlE9zQTEG3K5aP6UbKWIiuzBKSfYbLssMnwR5ors 16QzyB2oDW3jlchAXO3cu7fE94M6vw/0kOKYbjLcToNVphexjPyuiqerbJSfyzre4WB9lzljceDc cin0OmfJCAbXBNtkiqq/0pDvMaQeW33XIZfw6tzFVRUMMZfKTpFhyvZ/Qf6cL+pFKytx+V9HA4A2 F9RUjjbE5qHJ4np6mOoiLmmx/ISKjziwSRuC9+9b/pRTZRy1U41kzF5MSqIWl5oSN3ABfC+F/wAC OLdU5y/MbJcMo4fTMwtIcCu7wSq0eb5MP08eVNcG0zPURJ3tum0dUDGfVzySFtSm+llkBjyxuNFj zsBO8XuuvMc+lrR5dzZTPq8VfLgMpteEG4/Pstw0+51fJHqopWa6JYoYXanTEn27JLsUjbZocB8u Flt3Z9LTpdT0cc0mIzadOpz5Xi1lytJ9L/o3jWCvNFLLUeY3T+oZJcA/FlHi2vsR1cJGnakxeN2v WQ7TxYrFlxxvnAHZvG69T9R/A7VZb8QTMi5e11zHShxcd9MZ7/2XuTC/pe9OnZCMWK0nmYsae/nt JGl9uVnx06Zr5EXyjT6Kp5A0aX33FisCWoe17nEm57br1fk/waR4t19qcnCtP6GnnNntO5bfhbBX +A/ofkPLkM2YaGJrwwa6mV1tRW/C1KmHnio2aTDMJG2u5o9wVJHviLbOMmni4vf+y3O4z9O/o31D y8+qy5ZkcjD5b4XXF1z/AEs8AHSbAssQ0uK4EzEMQiJEksp9l08UVzZ53rI3wrNH8lQ6Z+p0UocO A0FJFW+abyZCYweNQsVuhzRP4U+mmYarL2L0dBDX0/pcws1AH2XmTxL/AP3OWMYPU1OT2wMxBrbh sIA1fhcpY69G8erhk4ieDosLrXDQKWaZg4fGwkf3VS1s2G+mamfABsHSR2W27wR0/SfMeRsJwmow 3D6vEpBZzKhg1LuPxIeErpjmfppjUoyzR0VRFA6SOenZYtIHOy544qbo6ZM6xq2aL6LEzUP0vN3X 2I2WZNUBkoDth7rExPDG4JmjFcPidrZTzOZGbdgbIcULhSjULOdtdZnDa6Z6ISU1aOVvHcESBw9g rlfFGRpN79ly+TekmZM3UjH4DQS1Ugbqc4AkLjsSwXHcuYp/D8WwuWKr1aQHMIufhTY30acqFS0v mQmVpsW8tSGTXDSR+xX0VT0rz1DhgxSPL9bJRu31sjcRb+y5PKnRbPvUCEjB8AnqHt2IDNwrtl+E 3xXLPj56uORjWtjIeO4CRI2QM1OFh/2X2+ZOgfUTIMTpsZytiENOBcy+S7SP3X2fh+6B4r1szRBQ 00BlpoXh82nfYdrLosclyY8qfs6pm6fZkGFfxSmwWtqKZzdXmRxEgj3Xz1JXPc5zJI3RSs2cx+xC /QR056R4dgPTNmGjBqSKoipDAxskQN3W5K06+LHw75v6eZ7r8XxHDhTYfWTuMb4WemxO1rKxxNqz yfJ2z2y9nRRqydnMJHYpEtSyAFz7OaTsAu7umPgn6ndVqBldhOGzsoZBdtRKwhjv3X1OM/Tb604A zzf4QytY06gxh1XH4RY3Vnq8sLps+F6V+EnPXW7Bn1+BUohi/pL+CvkOqfh8z30Ska7M2HvipS7T 5w3B/utlv0/OqtVljHJ+nuOYQKHE4fR5Rj0lpC7l8fXSTFurfTulwfL+FRVuJvl3JaLhtvdXFByn tkeXPqVBbk+DRzPTF1O2Smm1A7kLsDpJ0azB1lzGzBMBhaZyLue82C5zqP4V+oXSV7nYzl6qpqTV /wA8MJj/ALrvrwPdKc94zmfD8byzCYoKCVrpn8Nk33Buu+bA8Z2hnhOG4+Xzv9N3qdkrB6jEaaF1 UIYzI4MHO3AXlWIVFDiM9JWQvp6uJxbJFJyCOV+kbG56ufIlc6qjEVWaV+tgFw06Vpgw3wo5r8R3 VLHqrBqQRtZUPEspGlgOpTHh8kHL8PO9Wo5FF+zzG+pcx17Wb7hVBOKsOa0+se69/wAf0e8yVlGH vzRBBIG/8sje/wCy6E6u+AXqH0WzDRUckTsVpq2QMiqqUFwF/f2XLxJ9HplqILk8+wz1WkxzQ3A2 uO6hjqmOa6F8Tf8ApkNlsNyt9JvE8ayvSV1fmD9BXzxh5h/23C5TCvo/U4jqDimZp5TpJa5htYqL GjMtTBGtWvirGTGSRjR7aDe6F5xGmgbJU4ZVNiO7ZAw2I913lj/Qk9JOt8OWMYrG1lEyoDWODr3b futtWU+hHS7Gem+HNqKbD3sNKA50jG7XHupPG8bpnTypx3I0TQYzSvjAa53mezk6WciRgaNTnBdi +LHptlzpb19xPCMtVsdZhZPmDynXawm/pC64w6YHEg55DmtGwXNo6wluVnPZIye7NucKDCpn/p4K t4a6V3DbrY3lH6TWXMw5aoq6TFTC6VgfqG+q4WvfDcWkbLBNCPKma8aXt7LdJ4HM3Yhm3o5RfxGZ 0ssDQzUTc7cKpyTJltRtHnHEfpA5ZlpXsp8zzRVYadDLbA/K6zyR9K3F5c8z4dmGaU4RFs2qaNLX j3HutgVJkXOcPXGbFn4gXZUdHdkDnXIcvrDn6KTP02BecwiJgdZosQfkr3Ju6VM+K82RK7o06+J3 wQf+hvUPCcJw6qdVYdiVQxsb3ncAlepsa+ldl3MHSKlqMPnZQ5iFKKjznXsXab22X1/1F6cUWM5Q xJzdREoa23IOpeusqYmybpPhVVVkviloIw+3JBbZdcsdsIZF7Okc8sial6NZ/hr+mzSZ3nqp81V8 raamkMX8r7Xkey9Hz/S36O1FJLTME76hwsZQ8am/gL0RicEGT+kWMz4BGaa1PLLAe4eRsf7rWxl/ N3iWyRmifHaLDa3MFHM5z3Foc7W2+wWo4vLclwkeF6iaaj22ef8AxmeDPF/C1mNk1PUfrst1hJp6 gizm/wDSV1jlXw/9Sc+4U3EcBy5W19ERcSQsJBC708ZniOzd1mosKwfNOX63AZqJ7S6GqBF9zc7r 3P4KPE10kyV0fwvBq7MdHh9exg8xtRYb2915cuLarPr4cktlyNPGYcCxzI2Iuw/H8OqsNrG8xzsL UOHVjqtjmhm44cvZ31SOq2TOo+c8EiyzV0GIGNl5KmhA3/JXjChmEFPdjABxdeTa0enHPerYUonD wbANvwsmOmkrGt8mN8r/APa1pO6dSf8AEGMWvI5wFltl8B/heyJiOTIsYxTDafFqyQBzg8hwafwn R1b2q2aoP4FjFMWTswiref8ApicVjVGITPmEU9FLFNe3lvYQVv0znL0z6XYjFhlXlGEtlZq85lEH saPk22XVOeOiPh/67upZqKfD8JxUyA/8MQ17/wDpLV1UUz50tW4ujTfSZcx2pHn02EVE0PfRG5wH +FKxtXRgtrcHnp22++WEgH91vrr8r9MfDv08jqajBqKDDYWNa+R8Ac+U25N+6x8BwHpR4isqOqIs sYfW0UwMd/Ia1zdvjhdYxVXRh61btvs1LeEPpFhXWDqbhWEV8LjTiz3ta3stxdP0Y6b9Psqx0cuX sPFDEwRukkhaSfkkryX0D6NYF4evF5iODmpbLHVxl9Cx39AO4avZnWrL1NmPp1i1NV1JpIWxOl85 ptpsLoof7FFvhky6lyg5x9HizxmeDXIWNZAlzjkjC/LxVjwRHRn0vH4X3Xgr8K+A4Z0njq815fiq MQqxcsqYxqAXkHJnjCxbpV1LqsHrsR/juVI5rMikdqsAVtU6N9T8E6tZMocXwZvkwyMBMNvsNl7d ZjWBKN3/AGeXTTyZYbmal/qLeHqPJ2eGYvlDKU2G4bpvOIIyW/nZeP8ACg2sb/Ne6Mj7mH3W3Txu +NDLmQKnGMlSYS3Ea0wFnnSR3DSQtSddiVHieKVFVGWx+c8uDWcNv2Xmy4GsalXZ6dJmlKUoPpGR H5UcziLBjG7rncl4rHQT0uIAB7o5gdvZfMR04MUt3XDha6z8AphStbGAdAOqxXiUfR9qKpm9vwkd RsN6idK6Celhiinp2NjlAaL7BeQ/q3ZUw4YHg9dT4fDFVyv3nY0Bzt12T9MOsMuTMXiBO5adJSfq W4fFiv8AorD5WgtkqdRB9rjle3SRTybWfB1Lkp3/AGa5Mk+E3qn1AwuGswXK9ZUUDmi1ToIZ/dfb z/Ti63jDjVswYBtriJx3K3K9MaEZY6TYLBh0MbfJomuDQNjZt10x4fPEtmDql1Vx3LeIQQMpqGRw a6HkAHuuc4/aTS4O89SotRT5Zp5ougefJs1HLE2A1MeMsfoMPlm972Xe1H9MTrZXUMVRFSUjC8X0 PlDSPyCtxsuWsvOzT+vGE0wxfYGp8kaz+683+NfxY5k8OdfhMOA4XDWMqG6pXzmwHwP2W8WN5JqO NcmMureKO6b4NfWE9BOsfhVzDT5lr8BH6OmkaJ6hjdQLb77hbhekGd4eoPTXBcZa0Wqadrnt9jbd eBIPql4Xm/LtTg2acoOnbVRmJ/ljUy54Nl6/8HeIQ4v0Zpq6CPyqeaV5igt9jL7BXLjlCNyQjleX p8HgXxBeEXNfXjxBZpxDLuEn9CJ/K/UPbpYHe918pN9JrqzMx5iraBrwLtBl2/C2y9RcadkDKOI4 vheFirqI2F5hhaASbfcbcrqXwp9bMY6qDF6fHCDXQTlzdAs1rPZbk/LDelwjyY80sE/G+WzWjln6 ZXUjEs7f6exianoZC3UJj6hb3C5HN30vc+5UzRSYTHjlJUQVJDWVDiWhbLpc2ui8UraCee9M2g0x 341Ht/lfE/UKxWoy909wTE6SofTVEVe0xujcQ6+yzGCc1FrtHWWoexyT6PJkP0h8zOfT+bj8BbI0 eYQdmlXmv6PWYaXCZJsGzNT1dYG6hE8FoJ9lsg6cZgxTHOj2F4tUEPxCeha8WHJ08r43w9Z4xnN2 JY5Bi0hcaKZzANxZZdtP+jHmdr+zRZ1F6dY50czZVZYzPRiKtiNtQGx/C4GOUeS6MAhy90fVswBl J1TwzEmwtj/UwD1AckLwrTnW58pO2wspnwbEpL2fQ02byr/gPB8rYvmSs/R4HSz1tVf7I2kr6Ws6 NdQ6Jl6jKle2w+7yXLvfwYdbcg9JswTzZuYIy+3ly6b2XvnEvqNdAsNpoWmRtadIDi2na6y8W6me jLKWONo08VPT7N2GR+fLgFYxp/8AqQuXz8lW+nqTS1tIaWa9i1zSFuCxP6h/h5xOnlbNhYkY8EC9 I3/wNlrh8W/UjJfVPqLS1eScPFHTAet7W21brrtW2zzYNTLK6aOtKWJsrI4o/cXW236YuBYTPk6r qRTRvnp/Tqc0Eglan8ApBHUvjc4F53/stpn0scTgODYzTeaBI51jHfuPhR8I98+MfB9n9THq7mHp h07whuX8RkwuarnLXTxbEALxn0y+o1m3Bsu1+XMZqZcb/UM8llU+5c0nuvYv1PenuI5y6WUVfR07 6iPDZi9zWC5Fx7LxJ0O+nvmrqVk+TNEksmGU0bXThkzdJk5X38MMb0qcqs/P4J43namzaV4Rcdqs y9E8IrKyXzpH6iHc7HcL6XKWQajLud8wY7UVIkgrrGNmr/lgfC668FGFz5Y6P/wKqk8yqpJ3Rgk9 l5I+ob4gepPTjq1HhmAY7UYbhQpQ4wRghrr8m6+diwyyTlCJnU5IRcUjY7geZMNx2snZh9SyodTu LJbEGxXiTxeB2WPEZlrEYR/OqHxaHDkHUF9n9NatqMxdKavFsQrH1WJ1FRrlLzcrgPGhgWI4n1yy VVsppDQxyMDn6bgkFd8VYczX9HGblGFs9XdSMVFP0tmmqeJqdvmX9iBdcl0vxjC8XyLhkmEzCSii hDPxbkJOPYXR5j6fSU1WAIv0gFj/AEnSsPo1gMeXentJRloDHFxs0bEEr58v4/8AZ74Scp3+o+xg rqWsjmfDO2SOMHXY3AWorxH5+zFT+IKtpumWP1VCK+oME8dISQXk2IAC24U+AUVJS1MNPH5UdQDr DTzddBdNfC1kfKfU3F8do4hXVAmMw871eVITcr6OgyYsSySyfh49X5FKCijgfCf4Uoul1DHnDNdX NimbahnmvnqHk+U0i9t+688fUT8a9PFR1fTzKs8cvmAiuq2b7/7QvQnizz11LxmelyF02widtRiQ MdRi1rMiZax37LwB1S+m11dwnDK7Gqzy8UkZeUvifqc48m61igv/ACTav0jFxnPYuEuzx9JRzmB9 U9xHmG5F+d+V9HknDMPqK3DhXPDYHzgSl3+24XzdTS4jh1ZPh1cx0VRTOLHsdyCCvo8uYK7Haqmp 4SCXPDSCbBfM1Et0m32fpcKSikjev4XcudOaXp9h7MpCirR5LTJdjXODrboupXVPAen+ZBQ5syrA 3ApxZmICna9o/Oy81eF7wnZ/yPlaDMOUs4so56hgk/SSvMkfH22XpvIuMZrzJO/AOoWV4KvSNLqo RAxu+d/dTDBdvk+RqZS3UuDpTPPiR6I9J8apMeypBQ1eIyPDahtJFu1p9/Yr1zkbN1Dn3KmHY5QN LKWsjEjARbla7/HH4PcuZBdNn7LtQzDKeWZpnw+/oJvuWhezPCjj9BmDofl9+H1EczYoBG5rbXab d16c+OCjGUH2csM5ytSPNviI8WODTdYpskTYI2YYNUNLqyaO4efYfC9Z1lLhWLdKX1b8CpJ45qHX 5PlNNwW87hefOq/gHpc8Z8qs1UmPPpaipqGzzB42ABuQvUuBUFE7KcWFU1XFWx01N+mLo3B1yG23 sumaePZjUH12c8O/dJNUfEeHbEKDEen9PFh9PFDSQPex0YaBYg8L4jorknL8vXDqHmAUdP8AxD9Q 2Jo0j+V+B2uuweiGRMQyFgGJUVWGx+fVySxMaftaSvm8p5U/0b1vxionkfFDiTfNa9+zJXfHyuW5 Sc69luVRR8x4svFqzw04pgLpqU11JVXM8LG+vT7grpjNXj56P9ZsmVuD1WGsgxCtjLI2VTA0h3vf 3Xani08I2IeI7MOD1UeJsoYKM2JB3099l8tV/TN6YUWC67VAxpkf8uolkGgSe9vyu8FhUItvk4Rn k8kt3R6H8OFfRYp0ewL+HvD6eGHywB2t2WXnbFcE6MZbxjNP6CR+oeZMyBt3Pck9BchVfTTpjSYF K+B9RCXeuF1wRfb/AAiwPP8AhObcZxvKuJ+SaqiOmWOoLbSNPsF4k25N+j2ZVDav30aYfFx4msa8 Q2fb1tK/DcOo3GOlp3ts4tvyV0VHTmmkcwEaHcr399Sbwy5ayfhwzXl6aCjn1F8lOxw3HtZa/cKt ijfPDvjT7LWqrhxXB6v8fJyi1Ls+yyPi9HhWPUlRVQmoZC4PDCObFb2fDJ1Dw/qN0cwDE6GIU0bY RE6G1i0j4WinIeCU+ZsyYfhj5xS+dI1jpTtp3W8Tw3ZAwbpj03wuhp8ViqJnxBznGUWJt2C8Clud H0tQ2oWeZPqJ55wd+I0WWP0bI62Mid87QGkgn3XpzwyYR+i6C4R+nJjdUU2uN7DvuOV50+pP0nw7 E8mxZ4jqoIqrDyGzAPAdK3sOd19n4HfFXlLPXS3CcvVFbT4NiWHxiBkNTIGeY0cEXK+xlnuwRivR 8DBjS3ZH2z5zp11pzfH1/rsoV2JTSwx1DgGyHUbXXd3iZq5MJwzLeIQucyogro3SPiOkln9QScP8 PmTKXq/WdSocTimxWo3kHnjyx882XIdSM5ZCzLi1LhVdmrD4qjUCIjM0gELCcd6cEeeMJLHJS7bP tsxZ2p8I6cV2Y2a3wU9IZwALuNm34XlnIn1KcjYjgtX/AB+nkw6anLgS+2mQD4XqcV+XGZX/AEsu JUFRhwgLHgyt0ubbe+60V+JvJeC4P1RzGcExMVOGyVb3QQROuGNLvtWsEITUtxqUcksqp8UcV4pu pWCdXusuJZhwSnFHQSyXjDRbUvhp4ZKljAH2BsN+6VTYa18rC9obG0d+VyLwHRNDRuHbL5+Sdvg/ R4MXjios9d+BzwaS9WsWixnFNUeBw2fI4/17/atknVLqrkvwsdPo4Q2KnMMeikoox6pXfsvJ/wBP 7xN5FyTkKfAcxYizDq1rg4PefSR7L0fmjqX0B6j11LWY1mDBsQmpnao/1EwIaf3WsNNpvo8esnJf VHijIvUTqB1i8TGHZkxfCcUhwySUPpY5Y3CFrQdrDjhbGusWc8Syd0jxbGsNa1mJRQl0IeOD+F8P nPxWdGenWBiqdjuE1PlsIp4qOziTbYC3C+XyZ43uk3VXL8lLjuMUmGvkJaaSd+zm9l7cslkkpKFJ HzMcXjT5ts+h8H/WfGerWT6ibM2huLRP0lrTYFvvZfNdYs95k6QdbqCty1hE+L4NUw3xHD6Rm5P+ 4W7rFZ4sPD10mlqHYbi9N+pIu79Iy9/hdXUX1Vcm1vUSSidgT2YDezMSl2c75t7KxlFzcorhro4u U4wUW6dnfktXk7xQxQw1f8Sy7jVK2zYnP8qZv/yvFXjO6I9XeluGVNLg+O1+ZciVTS6Y1Ti58R9n L0viPjH8PtRjEONVeICnrWgHzYm2J/IHK6i8Wn1Icj4tkGoy1krXjMuIRmKWWRlmxNta+/daxzlF 7Yrj+zKjunvfZ199M3PtXgGeW0kjZf0NQz9O5sbbhrvlelvqaZjq2dCsRw2jY9wLmvnDb/8AL914 X8C3ilyn4fs04gc207qmnrnlzJ2MuYivS/i98c3SPqR0axnCMv1prscq4dELXMtb4K8uPJGOa5H0 s0ZyijWjhYEkTGsG1wCVyNa9gka3kBYeWmWpIdYs83Lh7eyN8jpMR3aSwGy46vKs2VzR9bTxUMaR 9bkqZpxqhDRciUbfut7nRVurpPlzYjVSs7c7LQbh2ItwKtjrIZWufG4OEZK98dIPqj4dlDI1Hg+L 4X+pqaJoYNNwdI9l5IWmb1SU4JHTPjQ6Q5nn8UWNOocOnpaGpcHxV7AQwuPsfyvVnhewnrv0PyeI sQoTnHC5mNkgjkktIwHfY/hdK+In6keXurGSpcHwnKs8OIkh0dXNa7CO4K+Z6MfVSzT07wKkwfHc HbjEFOzQ1xcdQA4F19bJmWSEY10fDjBwTRsRrMiZb8QOAfqcwYDLhOOtZYljiyWF3b1DlTw59F8V 6TT4z/EcWkr4ah//AA7JXEuY0LyNJ9YfBP0snlZJmZWObZp8waNXz3Xn9/1I+os3U8Zra0yU8V42 YYLiIsPx7/KxultcV0zhDE3NS9m5mfCKeqqW1HltMg/qtupi1mUDmGFswd6fLktZ35WsDE/q65mx DDWRYfk2GhrGiz5ZHl2o/AXVPVf6jnVHqdgDsHilZgLCQTPRs0vNvledOTpN9HsnBpOo8m3TPEGO 0XT+rZleCKDGGMBp4mgBjd9wjwRtZmXIrabGGOhrJ6Ux1OoW9ZFitTvTb6n+f+n2Vhg2KU7ccrGM DYaqrO//AOEe6zKP6rnVdlYNeBYdPTvdw1tjZdo421ZycZtpJcUem/BTg02U+ueesAe1zWxPeWgi 2purlejuq/TrGsz57y3j2HPjEeFvN2km/O66U8D82aupeaMd6m5hw2HDafEomxwNjP3G++wXdvXr OGa+nuQsezJgsMM/8PhdMKeXfUB7Lc6eVKD9CUNmFpo4HxX4nT0nSimpK2ZkVVW1sLGFrrHVqvsu yKzK0WZOnUODTEvZJRNZqv8A1aNj/dap+l/VfP3i+6uYH/qCpLqNtWJBRNJbHEQdrA/hbdWYdJHl 9tAJnRyiARCUDghtrrOSLxJfojDenfR8L0aybVdNMjVGH4k6CJ0cj3CQO2DOxJ7L63LuM0GP4bUm hxmnxS92F9PI13l9rGy1FeK7xE9UsCznmrKVLmGpjwOildDKGSEOlHFl0J0l8R/UTozU1FZlbE52 NqCXSQ1Dy8OJ77qZcezmT5ZcLlLhLhGyuXwEY1mLqLjdXjmaJqjBKqYzRObK7zBc302WblHwTU+U eodLJSZhaaWmkEpp5n65NiteeJeO7rbWSyTOzPPDI/gN2DfwvlqLxF9VmYpNi7My1D62Y3kc+Um/ 7L2fMybNsmqPGtDt/inZvR6v9OKTqZ01xHLdQ5gjmg0Mdf7XAbFaSsCyF/BfEhFkfG8ZnghjrDDP OJf5Yj1cErHq/GP1oqw6L/VtZDEAQY2HYrqitrMUx3FqrFqyullxWpdqknDiHXv7rnps8YRcW+D3 x0zyZVOS9G+SXNWQvDP0cEtLWUjcPoIPMZHBI0vmda/buVp18T/imzF4k841VRVyPiwCJxbS0DXe ljQdifldXYhmDNVfSNo67Hq2ppWj/lyyuIt+5XHYfAIWvbER5nckLxyyRjdcs6vSOWTno2EeAXxy 4fkanoch5s0UeFOOmnrCf+W75+F75qsm9Os65mpM1sqaKoxSG0kdYJm3I7crQO+la57XSS+S8HZz Tbf3X2TM+Zxo8KFPSZpqzTNbpEbJiLBeeOWUHaZrNp//AFq0bNvqCeMTAMjZJqslYLWRYhjmIRmO TyHhwiba3buvGXgN8WOW/DnmTEGZqonTQ4kS41TW+qI37XXluT9RWVrquvqJayqcb+ZM4ucf3KM4 ZFXAfqPSey6ZMy8ajEmLTT375Gyzxk+OnpP1Q6MYpgOBF2IYxUttAJYwPLNuV1h9PHpH0uzFh76z OmNUsWMtdripJ5Gtvv8AK8TMyxFA4PadXtdVEyakqy+CofBLawdG8ghed5NyUaPSsLi20z9FFHj+ WcGwaCCnxfD46GGPRHadgAaB23WtXx49KeleCZPxrN2EZihxLMdbWa3Rsla8tudwAF4PfWZhiYZI 8fxHQfua6dxH/dYEwrK6INqK2WphBvpc4ndezDn8Ts8OTSSySUn6NsPgGwfo/gnSSlxWjrqOhx6V gdUzTyhkrTb5XbPiK6z9Lsb6e1GAVeb6F2t7C+CKcOLw03sVpEhgqqV2qlxOqpWd2RvIB/sgqqMV by+WeWZ/+4yG64RyJ5HI9mXHKfBvlyl4ouldBlCi05mw+mpqWBkflseBpAAHAXgP6iHjSwLrDhTc j5Q/4vCo5A+XECCNbh2b8LwvS4P5bSW1FQwd2l5sUUFLA2awcXke67b1CTmjHxnJJN8IZRhkFIIy 2zmgA6u6kIBJLRZqyqmnaQ3TbjeyBjA0bCy8s5vJLfLs+kkoqkWxtuUen2CgIuo5xA2XBl9C3ixF 1d/7KEm3HKhbc7KEKcL8IgwFu53CGxad7FQXvugCAFrWQ2N9iiv7qgL33QFnS3YoDpKKx07qhHqN r2QA3DVC0k/CIxgGxUc5o2B5QAtFjyoG3N7qjt2VsN0AWndS+okKONnAKmmz3FAQ2AsCll29kUhD bWQWDj7IA4yQdldiSbqMGnhU435KAgFlEcQuDdC9gugI69lTWXBLjb4VXF7IxYjlAAWAoALXVm4P GynNloEcBZDBYOJcbhESLIW6QDvZUGT5V2mxS3XG10LNTTe9wqeTr42QFht7FH5QJuOENt9lBIdW ngKAbe6hbsgvsd9lerb3WQQA6jfhCYGg6v8ACY03R6bhUCPL1H2ViItcLm4CMt1EKzYHdWwDI6zh pCrygGl1t0R3VWOiyyDFa1xkv7pnqvpI2Tm99gClHW53q5QAiH1KSMAaQBunNaVbm+nYboDEZBYk uH7KzG3SU3Vd26F502uLq2ShUkOhmpp39igo9Tb6k9z9txskho1E7rQH3ClzdU1tgEEwJbsUKM1W 43UJu0LG1uYQ22yyWvbpsRygMOYXebIHR+kbbrOdEC0lKcL8IZaMdjWtt6UflGS54COQe23ur1en laIYswLSP8Ki1219wnaLjcXKj4jyOFk1RjPFlTG737I3RkbnhRuwt/laIxbjvxeytjiLh3CJU425 KEBLL7DhKMPqvZZAVOOyAB0DJG6XC6w5ItEgY0bLOPCURd1+SrZkF8DdINt0p9M17LadlkVrHTxs jjNnH27IRTvhjaA+591bFCDGIGBttvZR0TX2sLKPY9xs439iE2MEABQE0eU0WRxvtISAgkvcBpRs 9NjbdQUHPd26w5XPsR27rkQNbtwlPYGHi4KpaMOLSGgAWTGaiTvZNDGO+1tkqYOBs3ZWyEc4EfKg OkX7oWxOLQ6+6ZFC4gh57pYKDfQTwSqiBvZP8oAboQ20gsLBQqRYYWu3ROjDlcnII5TNVwNhdQpj mIA/CFkYF9vwn35QOb3QEDQnizW2CxrG6a12yAGQarg90owhgsAmvJIFuVQJ7oKEuw6OdhNtLhuN 0wbQBjwDbumauyBzQd+AhKFtAaLqpG3B33RPGpoAQOGoW7rRKMa9zzumte0ts7coHsDD/wCVGDm6 oHMLZhp4srbC1jrjshjjtuE9jCN+6AU43BsbJEhP7d090bnE2VGGzTfsgMWRh9NhcX4XJ6gaLQWj SfhYjYeN/wBlkucHR6QOEBiwYYKpp8l3CtsQpwWuF3jbdOoJHOMjWktQ08h1PEm7gdkBxztRedTb BW2ING29+y5ORzZGlpaAeyxSGxnYcIBPk7C4sgdZhNlkF+tJkZcXsgMVkl5CO/ZMvtZQ07NQeT6g rAAcUAJeAPlE2QFw3QGJ0hu3YK2w7k33QDjJckISd1I2i+52WTFACASOVlgSwl/dMbci3Ka2icH3 DSG+6JsTGE7/AN1CoAImtJvfZUW2uPfhRj9H3bqMocbQBe6axwaeeVj+Y2/siFnEeygMwE3vyEzZ rblJjeC32Rlwc1RlYYdcAhC54PJAKW+Xy2WCxDUgPGooiozw0PI3WVHpaLBYDJ2/3TmSfKMpl9rq mgl/5QMkvbunNlEb7lLBDG432VBuhwvsnCZrt9VkErmyOvf+yoALQX3HCXIDzfhMbI1vOwQGRh77 H2UAMM33A7lOZIS0+yxnPhbJ6HXWXTkFtuUKE9rjGDfZL0djz8Jk5GkC6Aek3KlChU7CGpAI0W7p 0vq4dssZ7msPIPwqQMj5UBAO6T+oa47FV5vdUGW0j22VEMaSQLDuEkSHbe6LzCVADKNxoRhpDflA XkBNZIHs32SwKiqjFNpIO/wsWrqLyOI5BWa6rjikGlgc47G64+tjk/Uh3l+k7myABkom3t+bpntp TWMjLw1rSAR3Rml9jZUGI8veC0C4+Ut1MZGkcFZ7ac33RyFjQBtdVA4llH5Z3VFlnH2Wa97HO5CS 4C5A7qkoxXGRjCWplO0lu4s5NbG0HdPZoACCgS4xss43ukuaALjhZT3MIsLErGs8Ptz7BBRALRF3 ACbAwviDxbdAdRiexzdN/dZcJbHTsZ2CFEsYdyUotDw43tb3WYA3VudlbomOBsEBish1x3uiZT6m 23/dPjMbDa97LJ1tLfTa6zYMExXOnVeyyGN0MsSgdGAS4mybCwPbquNI7q2AJIi8XPA4WNU0vnWu dh2WQ6pYSWtNwEuSUabXv8BLBjtpSRwgfh8znXBIHwsgVGkWG6JtVpFzdUlGPPTeUwEbnusJ8BZf b+65R1Q14WLO4Pe1oPPuqGjHDvLYLBKmnFx/4RzSRxkh7gCOAsGSovKHMI0+xVRkZ+oF9ilTzHkA kJczvNdqYPzZFHUGFp3a8OHB7KmWUyCeZpkjaS34VsL2OGtpFkP6qaMXjcWtPYKzJIYvMdIHH/ae VaJY/wA722V+ZblYRfI8E3FvhCJHDuFBZnF4J2OyAy2dYFYnmuso1xBBF/lBZml+43Rh6xy+JzgQ S33up5rGb31D4Q1Zltdc8q9Xyka4ZQDGSCOQUwm2kXuShLD1aW7lRl7XvsUMlot3nYbrH/XnW46f SeAozVmWyWz7PNgiE8c02ndzfhYtHTz1bj5cZkPYBZVVh81C1rpIzG48ghFufAbVAVDHaj+nIcBy LpJqHM9Mg0lBDTvc93lBxPs3lZceFTzs0mCVz72uWFWmY3x/RRn2Glyn6lp5Nik1mG1WFzNE0To7 7jUNiscNfUSgRsL3uNg1ouSVeS7kZrp9/uulSVDT+yfW5bxPDqds9RRTQxO3DnNICxKPDKvEZxFT U0tRKeGRsJP+EpmfIn0ynvc4Xbx7KBwc2+uzvYrnTkHG6eHXUUUtHtcCdpbf+64iPCa2tqxTw08k s99IYxpJJ/ZKaM+SP6YriWtve6Frzt7r7qm6G55qQxzMsYiWOF9RgcBb+y4/H+m2L5apzJX0c9M4 Ddr2EWWtkvwz5Y/p8x+o/uibUb7iy+gwPpjmrMkLZcNwCvq4XfbJFA4td+DZctmPotmbK+HMqsQo Hwgi7mHdzPghZ2sks0IvlnxnntJ5QumLXDSLtSXwvieWuBBG1l9/006C566tiZ2WMAqsSih++Rjb NH791KOjmkrbPh3aI5PVd9x27JQkeLgcE7LuY+EbqZHUtpjlqp84m1tO65HHvB9n7KWFfq8Uw800 jgLRvNjv+VtQk+Ejis+Nvs6NPmNPqafyEJqLD5Xe+XPBR1dzHTRVNPlardSSi7ZiLNIX3mGfTN6y 4nG2WPBWMid3e+ynjmu0R6jGuLPJLqjWLEJ9PTwztJMml3yV7PpfpX9WnSBtTh8EYPB1i/8AhJxP 6VnVmjv5MFPO7/a169EMEp9GPlY+mzxnOxsYsDcoGiQsvtYe69I5o8DvUHJRjgxbC/07pHhglcLt v+QuwcJ+mN1Q/hEGL+ZRS0b4/MLA7fTa63LS5I1aJ8vG+meKhI6+yms9rr13lv6fWbM95jkoaKph pAw6XeYALH8r6nMn02cZyFSF+LV36lrjbVGNmlc1gm3tNfJhtuzxBfS0est9lkxBzQCeD3Pddg9U ejtZ03rzTVEZkp3bxynuF13PM6NoYDqsueXDPF/I6Ys0MquDsOWbSCRukNqBJdrtr91j3eSTc3K7 08OvhIzn4hq0PwqikhwlrrPrXtIb8291zSt0dZTUVbOlqeT9PKNtY/urnleJCXOGl39K94dRPpw1 HS7DGVUkstVEWeuZ7b2d+PZfS9APppZY6mP/AIjjma7Uh4pKQesH2K7SwzjHc1wcVnhJ0ma53Bz3 N8kE/CB1JK5pNj+LLdRD9KrpLhTI2OrphUHaPzHgav2K6n64fT1wfJGET1WE6SxguSR/Su2LTyzP bHs8mXV+N8mqcg3sUbY3O4aT+AtiXh98DvSvqriQoq3H6uLE2PPmUpIaD8BeqMyeAHpD05yzPPFR hj4Y9nTHUXLnHBJ5PGy/NjW5I0iuY5m5aQPlFDTyVMmiONz3ns0XK2D5L8EzOt+e6v8Ah9L+jy7S SnzJQLXF+y9lZN8FnRjIkFNhv8Oo3YwWgh8+73n4C9EtHKLqznHXwaujR3JgGIU7Q99NKGe+k2SZ YZ4LPEZaPe3K3RdUfDtgeX4phT4FT1FG7kOjH+Fry8UnTalyeHz0VPHSRPcSImf0rrk0E4YvIuUM WuU57DzJ+qkebI3yhws4BrgsbixHK5CjpKjF5WU1LSPqag/0xtLnH+y+SfUujE1ttyboXO0kFpX2 WHdIs4VuzMBrWtO5LoiAE3EOkeZKOOxwqoe/2bGSVrazDyxTps+M/UDTuLFCKk24X0sXTHMzzb+C 1nNrCJ11zEPRTNZp7vwaqYXbjVCVrxy6onmh+nwjZSRuDp91NRYDZ3PC+1HRzOpd5P8Ap/EHR+7Y DZfRYX4WuoeLwmeHLtayAb6pIyNltYpN0kR5YLtnVIkmcQDtf3VMa9rySzX+CuxMV6E5tw2UQvo5 ZJL20NYdX9l9Nl/wf9UcwQNkpMt1Xknl8jCAFZYJw7RlZ8b6Z0q/y7H0lrvZKbGX73sF6JxTwSZ+ weBj6qkDJnfbHvcrEHgr6o1enysCkeHfbpbynhm10R6jGu2dAElhsCjMmw4XqWj+nf1N/h4qq7Dn UtxfQ5puvnsb8G2a8Nik8uBz6hgJ0OHNl0jpMslaRl6rEuGzz9HMHEAphlDCQTYrmswZIxLKNa+D FaZ1LO3cNf3XE4ZhFbmDFIaKgp31VZM7SyKMXLivNOLg6kemMlJXFiJCQA4PvdUzQ17ifUV6x6b/ AE2Op2fMOhq5WQ4X5o1Nin+4flfeyfSuzlgFK6avrIpj30DYKwhKfSOc80IdnhGORri4vNiBsFBV PfZotf3XujCPpe5pzRE+WhrYYgw29XC5bDfpJ5zZPesxeljiHYfcV2+PNOjz/Mx/p4EbO5hG+490 99eHsFwLj2XvDHfp3vyFEX4iDUsJt5tuF0Z1X8LT8qU0lbh0rnsaNRYVZaXKldcG46uDdWed5ZnS k+o2X3/R3oTmnrXjjMPy/QvlaSBJO4ehg918hg+EGux2noJQWh0wa+3YXst4vha6U4BkHpnRyYNS thJpWyvl0+p5svNGLc9h2yTqO48f5d+kVjFXh8NTW5ijM7mgugjb9u3uirPpbTw10dJJiQiLiBqc Ruu9+oviezLkzNcsdJTaqKJ/q23cB2XxGffHNQdR3YDhWGUtRhuM/qmCWS5F919+GiqKeRcH5/Lr W3UGBgv0dsMMcclXmki4uQ1twuUxj6XeBZbonSRVv6uHjUG3I+V7Hzqcw410sw4YA11TiMsLNbgb EXAuVy+SY6zJ3TgnMUzWVEbC6R0z7j/K8UcUYu/76OMtROTps8DT/SiwzE8NfXMxtsLtOrRpsF1h g/07sLxvPQwA4s9+k2c+HstpmXscpMWyfVVsZ10+l3qItcBeZOi+Lsn8QGIeXsx4dpF7919THp4T jO10cYavJa+x5o6vfTdwno/l4YxQYjNjEpuDSPtqd+FldDPpoxdVMP8A4zmFsmDUL/sgj2evXPiy zJLk6vwOscw1UbJA59NbZ4HK+t6C+J3Cep8rsLpsGkwt8LbAW9Oy8k9N/rU4o9Pnk5cs8b9T/ATk fpXS6qMuqp72tKLryT1D6CiuzDS0WB0b3T1MmgMjaTYkrZV4vs6y/wASbh9OwOfcNAA3JKy+kXQJ mRMBps34pQyYxiVQ0SxxRt1eXtde+WkwvAnLhs4fJyxnSZ0v0E+ldg0OWoMYzdNLVYnK0PFHazWX WL1D8NGVcj4hU0FPhzbRkglreFsC6eZxq865eqXyUE+HSRegMqGWK8qeISmxGkzLUNheW+YLk+6z /jsEZSljn6NavNJxTTNeedegWOZ0xyqhyVgE1aYCfNLGWAC+cPg9zzTPa7E4o8Me4XEcp3K9/dKP EpkLpxHU0GYpBQ4gbgvYB6l8p1l8T/T7FZGvoJ3Yi6/peG20rlm0Mck6i6OuDWThj55PAefejWL5 MojLNGXSM2e9g2XWFiXkEEuvay9WddOu2EY9lmTCsNgb58gu557BeY8Ca2TGqUvALXSAbr42pxLB Lbdn3NNmlljuZ6d8Ivg9qerOM02MY+x0eCwPD/IHMo5sfhbNsrdB+iGXZYaH/T+HUGJOaA3VGC4m 3uviPBfhTKXp1AWt06ohwPhc3nTolUV+ZaPMDMSe2dtS1waH29N+LLtpNMsy3tnz9VqZRdIws/eE GjxbM0c7IIDh7+I2C12r7St6MdK+jeV4sWr8m0chiAL5vKDjcdyu2MzYrNh2EYe+KJ0swjDABv6r d1xWJ4JQZly4GZzrWUNNLzE54aLfuvqra4pz6/8AyfO3TTs+QyfhfTnrhlqoqsJwWmpoGgj0xhpH +F5Q6/8ASWhwLMMOH4K7U6SQMMDW3uCvbODZUwjKWAsp8iywSQvdZ5Y4EW/ZeWc/1FZ/660VLUNG vzhcr3afHie5pcf/AJPLkzTVJvk+66VeGnKOQMrNxDGcGop6iaLzXmojBI2+V8JjvXHppgmL1VDF lekljgfoD2RCxXozrIWM6d+uSwbCAbfha6cVpaeXEqlwibYyFdNNgjkTbRMmonF1Z6rw/GpKhsbb jUCLryr46IBJUU8rdy5g3C9DMxD9Cx7gLu7LoDxkO8/D8MeBqdLHv8Ff5q0X0zxkf6AytbHZ5Jwe 7IB8LmWyF7mW991xFEWhgaD6gSCuQh1WvexX9Fi7Vn5CXbAxaVxmJt2suFkhJdfhc5iBa5oN9xyu IuHleiHRwmDFexAN0mcHTyn0/ocTyFgVcjnVJ7NK6o4MTI71WWVC4ua0dgsUsIcCVmwgE7Ksgcx4 aErSeeE11wbkIWyaiW2RFQJLuDugkeQ0ad03yyOT+yvS1o24+VAxAijHrIIcqkkY4WAuhLi972g7 BCRpaAlEMGrBdC5o45XYXQpkUOdMOmkaHNLw21tuV8GWeZKYI3DzHja6+y6Oyuos5UNLJ6niUXK6 IyboOgkVDVYZDGIYi0NG+ngWXmzxv+Kw9LMdrss0mFCrBi0uc8DSAR2XeHhjrHT0r2m5u0AH2XjT 6r2GwU/UDBZYmNa+antIRsSQvvaZRWJn57PkksyjZ4lxPERjtfJicdP+mbUSFxY3j5WXFPFHaNti 4+ywoQGUkMcZ9BH3eyfhtI2GR00rr6eN+V8bIqkfdx9GZDEbkEbrIhaWE3GyWyQzvL2iwBTzOZRa 1rd1zOwmRu91iVOpztKzXEkFYoYQ9zndghGIpaB2KTshabC4BPutlHgU6OYO9lJLJTMkqi0OJc29 lrewcOZI1zDZ3mAn+62leBDFnsr6Qk3jMYBXpx1uTPLnbULR3D4pc6Zu6a4HFhmQ8HNZiNRGQ2fT tH/ZeBcNxvqJSdQ6DMGbMKrI6/z2h0xadJ333K2G+KjrhL0d/SVraD9U2QWBLNW65fKFZhvXLopJ iNfh9O2aSIuYGRgOa61wvqbIuMWz87DLKORn1tZiGJYl0abVYG4HFZ6QPjJ512vZa/cfzz4r4sUq YqWgk/TMcWsLmg3F+yza7x2Zs6J11XlJ2By1FPSSlral0ZcA0Lvnwn+LF3X3GqygxSnpoy0fyyGa XA+xXojj8Se+NnLJJ5Jqd8Gq/wAQufuqmKYvUYZn+SppdTrmndHoa4X7e661oYSyOJ1M2zWixutr f1RulWHYz0zpMYpKSKPEKOYNdK1vqc097rV/lDI2Zc4U7/4Hh89WyI2kexpIbZfP1EE6cT7OkzKS qR394OsrUmL9Q6I1DGvu+9iPlbgM0umyF0ulqcFgBqmU9wWjg2Wn7wryV+TupdDTYtTzUM7HtB85 thufdbhczV9RN0drZ6OP9VUOoy6Ng31bLnijtasmrmpQdHVXhV6j5tzVU4rhuaad5pXPc+nqJW2L vdv4XZuD4nguUs9VeFsdBQNqD5gYSG6nLpPw09RsbzdiNJQVeFOw9tC8te8ttq3XT31Jc+1eSc8Y FLgtQYcTbGH+h3O+119F41vcf1Hw4yltR3F1i6H9TM29daDHsBxZrMrgtdJTl5AH7d13V1hfVYD0 cxSp8zVWUFGZGuHdzWrW90e8X/WHNGaMKw7ysQdokaCGsJY9nytjnVbFI6rofiTsWeymdV4c4Sl5 sGuLVycpKUV+Hd4nCLs1MVniV6q9UsRiwOnxCdhkl8qKKG/qF7W2WzjwlZFzD046cMdmmr8t72+c 6KR1vLNrkm68ufTs6M4JiWa8VzFUsbVPoZyyma4XA9XK7O+pJ1qzB01yU2hwZxpYa1ha+ZhsfkKZ vvOjajGEU12dOZ58WVHknxO4zjeF0keKSxOEDXEg3HB3WwXph1CZ1WyLFijKc0xqIvUwHgkLQLlO trMXxmOqLJqmrmff0XJJut3Pg/hraPorSxVsL4J9OzXixsRsvLN7n/weyGN44WeNMBzE3KHiyrqo lz4o8Q8l/wC7rWXtfxIdH4Ot2U6Jj8dOBQRESCXVpBB914xzFlOqy34mQzFKR7Y8QxESxyuHpPq9 16v8ZEWJO6KigwiCWpnfpZpgJDrfBC9mRuWWNHicl4XZ9T4e+k//AKPZOqKGPHDmBriZGzagQNuA hyP1nyxjUmL0mJYrT4XiUMronxTShhtxcXXwXghGN0eVamgxSCeKGINA/UOLj+LldBeK3wwZx6j9 WK3EMrUopqAjW6WGQtJd+AusMSyTlGb/AOzyuSUIuJ951A8AGR+sucK/G48zxzCrJdIyNwe8E9wQ V4q8Wv09sX6CD+MYJO/FcDduZRfUz4cu3fDL016p9LuuOHU88GLOpy8NqZZpXOhLL+xXu7xdGjd0 DzS2qYCP0pDCezknamoN3Y08lhcnHg1TeB/EX0HVvBWOnkaXShum5sFuR6qMbU9MMaa47foXm/8A +CtQPgy6bZkx/qHgNbQ0jpIoKsyyzBuwaD7rcNnmnFV0/wAVppRo10b2G/8A9leGMPHmr+z62qmp Yd36j86eY7ydQMXkaP8A94ft+6OHDXYoQx4tZ19/yszPlA7D89Zgp47CSKqkA/8A5ilYDNLDUxtm O5tdZ1XOV0fR0bvFE2mfTXy7htVg00ctNFKWDcuAXafjJ6BU3UDBqKLL+X6UYlFL5hqI2NDrLpn6 bGY6ShqpqSeobG6T7WF25XvXNmTzmSSGWOvko3x8aACCsYZKE7l0ctUpdRPhumeSYstdFYcNrsPg kqGUmh8b4xubd10x4bsBzRgWeMSfT4JEzB3TuEszmgBgv2XqjDsJdhGFTRVE5nbYuLne1lxGVcRw nG8ErjgE0ROp8b/LPEnG69G6LUn2fMnKdxjZymIUGC5xoqrDqqKmr4HNLJYy0OsD2WtCbqDTeDnx EZopct4aKzD3yDRCTv6juOPle6+heV8wZRlx+LGoXWqKkyxSl2q4XiH6iPTqbLXUDDc7taY8Jq5G x1LrW9QPK74oRTlGT4Juk9tGxrIubH5wyTheOSwfpnVdOJnRD+m4vZa2uvPiQxHPfWvEMq4phtPU 5fw6sbDHci7vVyvdnhozphmc+kWENoKqOo8inEbtJFwLLp/PnghyKMUrM2VtfLS15qP1crpHWY6x vZc8O1OUfb6M54y3xZ3ViuMnpf0GGJ4LRQtkpaFssUDG2G7b9l40yL9USfDMcmps60EUVK0kNfBs RuvcGXsWwDqP0/fh+H1UVRTmnNKWBwOn02XkXJ/0yMNOY8SxLNeJwVcMtQ6SGJjLgNJ2CzBQjCSn 2MjnLLFx6MTo91uyn1u8WOH4zlyh/SgMPmSFob5htfdeu+uPUh/TPLQxSKASySTshbq4Fzyuiun3 g9y30/6tw41lnEoqd1OLPpoJBwu2PE7laXN3T+PDqerpoJWzMk/4iQNLreyQ2PJG+hqG5YpbTn88 5WoeqXTNlBikbXxV0THuJbfSSL7Lg6vDcF8NPSaWbLWEMZFA0OcGjdzu5K+iwLEBh/SunkrKinE1 PShpcJBYEBcfR49gPU7IlTg9ZjNFPUVMToZB5jSW324uq+VXpMyt0V/dGb08z1J1L6bSYzWUzKVs 0D7sabi2k3XV3grpqKHLGaW0zWtqf4pKHSNG5BJsuyOm2V8L6eZHZlaoxSmlpomub5nnAFzT73K6 06XYtk3oz1FxzC2ZkpZqXFpPNgiZI0iJxO4Jup0pwj0yK5OM5HVvWPrTnTLXihwfLNBjkkeGzTM8 2n7aCV6+zfPRnD6GCqpW1schFnOFy07WK6Zzj4dMk516nQ9QajMccVZFYkNmbosP3XL9TfFX0z6Z UEVJV47TYrVAtjbBTSCRwPG9lZbW47ERbkpbmcj4mc5YnkTpzTVmDzmnqWysGsDgL6DJuNYljvSF +KyzE189C57X3/qDDb/K+dxTqN096sZQgoMRrnUcFZGHs/UMLSz53X3+XKPC6DJDaDC6ptXQwU5Y 2QG9xZYbSioNc2OXLdfFGgfqXj2M4n1GxapnqJqjEI6uQtMpJLTqIsF6tyX4VPEZn/pjQYzg+b5K fD6yG7KIT2cG2Xlfq9jAy/14zFMIw6OHEH+ki4I1r3f0k+q7kbKGScOwbEMCmhmpIhGXQiwdZddZ kWOe1H1NNfx0a3epuTcxdPeolXhObvOdi8EhbK6a5Lv3XF4VB59ZVVB2jGzQu1/Fv11wjxHdYBmL BMOkoKNrLES21OPcldYRvb+nDIza7twF89y3co+jib22z6HC3Br6cvuAxw/dbg/puYnPVdLMQjmj IjbMDE4+1uFp8wuJk9bRMkkEVOHjzHew7rbx4VOv/R/IHTilwqPNlFBOGB0rZXgHVZG7VDNK4nam YupOZcG66YNlqVjf4PVM1l7f/K+/xXI9NWZuo8Zpo2x1DdpnDbWF0jmnxa+HuLNMGK4hmqklxKlb pbNFqcG/Gy6T6q/VKy1SZooqXJuurw2B4dNVSNt5rb7gAr1Lmtp+e5i3Z9R9SETVMmVYoIJJRHJq c5jbgbr0l0JxmPM3RXBHztLRFSiORrxa2kLzvL4/vD/1JweGPN7jSSizmxVMRcQ74IXE9TPqUdJ8 j5BqMNyO92J1r4jHBFGzTHHcWuV6v54o4kuUy/dSb9M9iUkVFmfKVbSQlslPodHoHuuk/DV1lxrG c747kDF8DfQnCXONPUPi0h8d9t14L8N31GcQ6dZqrZs2F9Zg9bMXP0b+WD7L1Riv1QuiOBh2KUEM 9XiEjRr8mEB7vi655f8AXug+bJHHJbZ1TR899WXJ2FPyDhuYBSxDERKYvNa0Au/J7rozwk/TuwPr vkukzTjNa+CJxsYIJCCf2XC+M7x85P8AEbkimwegwqsppoXl7S87E/K6U6O+OnPfRXBZMNwc3pH/ AGBxtpWJTXiil2fQxKbbtcH1Pj08Fx8NGNUeI4VUmbL1dtE2V13tcOQvKlBG/wA9pLyYe4K7Q67e KbPPiImomZoqzLT0hJiibewv3XWtHNG4Os4g+xXhlJvs9eJSgqZysFQH17RG1zGi3qC98+D7IvWR 9FT4tljGJafC2AO8ok2eL8LwRQYlC1hifH/NH2lerfDr9QTM/QShjwyfDY8RwpoA0nsPhdI88I6Z WnBo2i5W6tvzB+lytm3LdU3EJ2+VJOYdUR7XJ7LrvN/hLwbJuf8AAczZcilewVYfV08jvQ0E3uF0 lB9YrJ0kQNXk+rNWBfUwtAv/AN10n1k+rHm/PdLUYZlzCYcBonmzZ9RdKR8nsvRGNOz4Txym2mjZ j4k8hOz70lxKnjhM00MQliiYNRcR2AXWHgUytjOXMtYkcVpKihDpCWQzMLLfgLxR0z+rZmjKOWo6 HHcNdjVXC3SyVx+63uuSrvrH5rkhlio8nUMJkBDZC4+m/f5TyOMXjD0r8iypHdvULDMUxrxp4bJh muStjIcGsNwAOSfhez+pWCVWaemmM4S8mOprKN8OodnFvb91pQyn4484ZZ6qVGeZ421GITEkNcNg D2XeMv1ic6S0zoBlSie//wCrc3P7L05Zq4OPozHBNwkn7PImd8m1+Rs8YjhOIxuZNS1Dm6nj7hq2 O63K+AbFsPq+jFJDTPjNUxrdbWncbLTl1l634r1zztLmKswyPDJXCzo4hYFfS9FfFhnnw/1Ifgc7 pqUm7oHG4IXl1GTzTs+lig4Ydr7Nnvij8CFF11zSzHqauFJUOsJ4rbSLV54rOgdL0E6mMwSimEsL o9UgcfUwrujNH1UOqmNUBgw6mpcOlcN5Qw6v2Xk7qHnLNHVDMlVmXMlY+sxCXkvK7z1EpY/HPk8e kwvHlckYdNBHHHq87UT2XKYGH4hiscUY59LW8XK4XDJWTQxtkZpcdi6/CzYcQZRT/wApzjI3iSMc FfP6P0HPZuR+nX06xLKuSZa6shETZxsNQuvovHX0tlzfkOLMFIL1+DP83SeCy+61c5N8cHVbpnhE FDgOLmJkQteXcEJua/Hl1p6gYHWYXieLxPoKppbI2NoBP7rWmn4pqTPl6vFLKqijcH4cc+QdQOie EyU07HVsdMKeRod9rgLL43oT4Yazo91Mx/M0uJRVMWKPc8stbTc8LTbkzr/1A6ZRh2X8yVNGdRc6 IPOm5X2OIeOvrZjFE6mqc2VBY8absdYgfBXsj9m9r4Z4pYJunJco3f4v1RyZgWYafDK7HqGmxWY2 bEZhqJ9iutPFX4cqHxLZVoaKPEYaOWnlEgqTvqb3F1o7xbOuaMUrW4nXYlUT14Otk7pDqB5vdfVO 8VfV92GRUTc310VLF6QIprE/lZp4Wp43yjbwTzw2yRtcd4IOmGTOm7qasjoo6yKMasRc4B1x+V3V 0Dy1gnT7IdHhlDjcNZTi72u8xvC0KYz1n6j5giMGJZrxKrgP/ty1DiP+6uPrF1Bhw0UEeZa2ClA0 gRTkG3st7nlg1OXJY4MkJKujfHgfVOlnzvmDAMer6BtOCP0obIDrYdiD8o8Jxfpx0zx809HW0NBV Yi4k6ZGgX+StAlNn7NNDUCeDMVZ+pO3mGc6v8lIxnN2ZK6qjqK/Gq6aXVdr/ADybf5XJ7L74L8bL w5H6AsQydk6tzVFm2bF6TzYt/M/UNA/vdfDeJz/RPVzp3U0Lc0YdJV0jhNBEyoY46h2sN1pCZnPN VVH5LsyYi6EC3lvqH2/tey+z6LU/63OuHiuxSakpnTDz5ZJzYi4utxcdybl0Z+NJ3E3j+GvE24j0 fwiMu1fpIzAd/wDak4TimRel2IY9Vz5moaWStkM8zJpWs0n2AXD5J6v9JOn2SqDCos1YbSU3kguc +cC5I3JK12fUOqem2YK5uMZNzY3EKnd0tPSz6mhyzBKc3bpGcsXHbGK5PivqLdfcD6z9TaJuBT/q aDDmmIPbw835XlWhYI2OcWkhxSsMhEzv1El3uO3rXKxU3Plm7StanMpJY0uEe7TYPFHs4qtomVDb mNrt+6dTYFSxwai0/sbrPqKRmgeq1+VUcYjjt5obb/K+a+T299nDvw2OKMERh5cbWPZM/QwYe4Pb HeQ/4WQ4OdI4F7XC+yyqWmbKP5hFx7pZKUXwjDwkTfxR1S4ua0Dhdt9IOv8AmHo/manxbAKx0Yie HS05PpeO+y68jdFTyta6xb3VVlDTyHz6WUMJ+4e6qNyW5UbashfU46U5vwKKnzo04dVOYGzRvjEj HG3suQzr9SbotlHLb6XL9ea17mFjKanh0hoPutNslJDM5xEZMo9xykfwstBkdEGW7Ar0QnFdnzHp G3wbd+l31NOiWF4WIKmnqsJrC4vlcILtcfe66R8avjC6Q9ZMtzxZcifX4yYyxlTLFpP7XWvielpG NBLgC7sVX6FkFpNDI2N31912WbZJzXZr4d0pdI9LeEfxu4z4bqoU9ZTGrweV386A/wC33C9t1/1U +kddTU89ThM9dVt9TWmIO0H8nhak66vp8Qp2tAErmnc2UibQspw2OAahy5cZSc25N0ztl00ZqkbM erH1X8s5kyViWD5cwKtp6+ojLG1EjgGs/C+U6WfVkxTJ+XKLDccy0zEo6WPQJY3kPd+ey1/NgidF rEV/2QtrBfyxAS/2A5XaDhtpo8y0zi7TNosH1jcsVEcnnZRroXWsA2QO3XVeQ/qq1+SMfxqony27 E8Pr5zM1r5CHRj9l4Sjr4oXGOWlMDjx5rEcNQwh0flNcHf1DZd4yxwi1V2Y+NulucujZo36xeWZi C7JtQyYjc6xsvic9/V8xbFMFrKHCMrR0/mtLGzSPu4Ai3C17+TTxOJLdV/gbJk1NeNsjWscz/p7L n5MVU4m1pnF2mJxnNE2Zcx1uK1jA2etmL3AD3N1yFGKijeXUUj4nfdqb2KTS0VPWMJewMc3glZZq o4hHCX2+QvNOSlye2NxO+Oknj16jdIKZmHx1jqqnj2DZdxZdyt+sBnung8v/AEth1Q7/AOsS7V/8 LxDLSRVDtYqLnnSViT0d7OLmADsNiucWonPJhWRq2d1eITxq538RwZR4lGzC6LvBBcA/JWJ0X8WH UXoC5sWXas1dHYaqSVxcx37LqP1VEkcToNEdvv8AdB5crJ7RNPpOx4XSeZzo1DTwxxaXs9QdQ/qS 9Ys/0Bw+GePBWSNLJP0zdJcPyvgumHjB6rdGsSmqsMxSSsjnOqWGocXAn3XTNVTYlNJaJ1nc3G6b SxTP/lVdxIOCo8n4hHTxvk9DY79RjrrieIGpZmD9BGdxTxss1fK5p8Z/WLqCKUYtmOdxpHaojCAz f8hdVMaQ7TI0PLeN0GvRJpfZgPO1lFlcXaD00Du3C/Hh1qwWJsNBmadkjdg+S7jb91j5n8YvW/Pl F5FfnOrghG7hTP0F35summEQTfyT5jD3umyQaZA5kli42sOyqzNGPiwOy8C8WfWfLbP01HnfEzEN g18pIXBVfW3qDiWZJsXqcfrHYpN98okILv7L5iCJkDixshdJzure93mAuj9Y7qLUPH0PixkzNzj1 GzrnRpgzBjFXWw2t5UryQVxGAUTqSM7WDuFnue2cgu590xrDY6Nl58mV5HbPZjxRxrhGJM6voqhr 4HeQ7VdszeQV9o7rX1DwehjY3NdZIyJtoxHKfSF8rpnB/mDU1HIyOZli0A/hcYva7Ok471TKxjqJ nHOlPJT4zmXEqqhefVFUTFzT+y4mGkr6FrZKPEZIyz7TG+zguTEDWR6NIIVNjDBs2y6vNJnGOGEV VD6XOeeGRhrc2YpHCdtH6l4B/sVxtVDiNRU/qpcSqX1JP/NMzrrKc0bc7dlVQ8ygNEZbZbWonRPj YrsKHMOZsOhdDHmXE443bFoncWkf3WBSU0r6hz5Z3SyE6tTzcn5Wd+okEYa5gNvdPpnMmILo7OCj zS9GlignaRT4wA0clWYjo0g2sssw2N+UuaMuHp2K4Wd+VyYDKEvl1MmkicdiWkgFY02BGN7hqe8O 3u155XKtLmnSf7qy1zTfUSFtTcXaMyhCf8kcQzCW6gyV8ptuA83CyDltlSPM8ohw/qDiCuQkDpZG l3ZHUTvBaGO0j2W3mk+zCwwXSOMlwqnhj0va8v8Ad26WKJsjNLoSWEe9lybfNkk9ZuEzSRdo4WPJ L0w8GOXaPnThDSdDS63zurbg0lOPTSiRh5K54xaQbBY4NQ15sSW+yvll0ZWCEXaRhT4NFNTgyM0j /auPbg8VP64omOc0+1iuQnjrhPcuvGeyKPCpXuMsTifdpXK37Ojig6aR0UZtsbcLJop9TT5oAPuF Kby9DmPA8z25RMihkbpZdpHv3SzaQqenpXnVf1323VPgilYAI26+L901+GjZ5dwpNQu2cHW+QibF CWYbKCLWYB773S6iibLIWFjSfdu109kkkXplOoe5V+SJiHtJA9wm5mVFEgwljIxewI5usxsNIGAO 2I7tCXHGWbOOoH3ROZcaWBVTaKoJdFmRrXhsb/7rJkiZM0FxbqHduywmUxabkblZEMbQeSo8jNJI XVU7JwwBm42uqlicxjRYBg9tisl8ZbYglA4n+o3CLJL9NOmqo7C6WeLLqn0Xo58OwDHJjQuOqOKX djfwCvqc4ePHrR1BwCowbFsRpZqCoZokbHGGkt9jay6TikiAIcT8XWO+Ty5PRa1+yiyyjK0zyywK RkZezrmbI2MNxLAMVlw2sDtV49gDyu46D6gvXbDIBAMeFRHbSXPAuulyGynV9rkmSlDr3tb3suj1 U5S3Mr08GuA8yZyx7OWK1uJYtO6prK2QyzDkEk8rHhDGMs5tnW4ToIP0wNrm/comU3mP1HcrE8ss rtm4QUFSMR9Ax7w/WQPZMdFGHNcBuFneWBYW3VOiFtwFm2XamYpjZJc3IcRa3ZHSwRxNFhd/ujED TxsqbAWSWDtiqjSRUrWl4HN0H6VrHFzRYp74mxvBJuETW6wT2VKY3ljVu0OHsUt1w46RpA2sswxg HlKmAOwHPdCVZiGMAjufdC6JznaufwslkXuiDQwWusstL0Y7TJGNNyhEY1hxZqKyywF3uUYaFCUY wfI64sQ32RMZZpBaAsoMa47cq/0+oAqCjB8poOwUaxrb2FisqVnlgm2yW4i1xb5VXAEse4H3CFkQ EpdpAKc0sG3dQC5XSyELQh07IyLbKlGwARdWBp+VTg4uG/Cp7Lu1XsFg0G+Ozdki9iRdVqcSQCrL dI33KGS2gO/IUMRvdC02ROc6432QEtyqJ0i6K6W434QFtcXfhG9212pcTiX2tsmubpNmoCnOGm55 SmDWSbcIhC7ubXVxgC7RygI43BHCEMsmaQT+FdtXZAAdkHYphaQVQbflAII1d1dnNtbdNdF7KvUL BADc8Kr3Kt9wqa4XvZAGL8jhA5xdwrc7yiL8FVpDd77FACL3TLhKBcXX2ARlwHz8oC+QUG/urc67 dtku/dAWSR2ulvezQdbf7IxwgEYeC07XWgWycFo0bhPEmsAgWKxmMbTt0NRtfZRgcRvdLv69tyr1 E91QaAb3T0AmvIFu6K+9/fsgI73RtA2uoAw7iyYHfsUq4HCmqyAd8BQ2JSddjzdEH2KAOyuxI4Q6 kQeAgF67utpt8oxZUZARa2yoPaHcoAgR7KpHahsq1tCrWAUALm8bIZAWBM8wNCVJK078rQMcP3IR AB2yo6QSQeUJd6eUBkN3bY7KOAOxWM2c8HhEaoDZUBVEDnR+nb2KRTmUPs83HumGoJt6rBUTvyhL MkuBsShm0mMlu1uUmN9zv2RSPIYQDyoUXq9I7qi8KpHXYNrWS7hx2IuqYHtNxdDNPZum10BdoHNr pTg+Rw9vdVFsYSPLSr3Bsrc63pQEho24KoGBmq3t3VuASmTG1lbpPSqQu6pyxZKnywbb/hCKwOG+ x+UBkEEk7oQoyQEItNt1AC20T9QuqeS4cpgZc3KA2cTYoCmgnYbqgC15BTANPGyIs1DdCUKZGbgj dMDu3BWVGGhoTYmwi9xclCmMNRb6BcjuheXBt3BZJa0XLdt1Um4AsEBheZoduDpPcdk7ywR7plS6 ODD/AFWLnHYIIi0w3J3QAthaHfCZ5bWO/wBwWKyuY1xbexHujjrGOdbYoKGPbqOwQiP1BGJruuB6 UQHLu6AAjR2Qd00guCAOt2Clmkiw24VmK3ygMoHG6nm77myWKDEYAuhLB2VecL2RNl/CWUW70kC+ yhsL9rI3kW4/dImswAk2CWCOcRuh1e6RVVzIWiwuSlGcySNDXWuNwqYMoyNBN3AIdm+q9whdTxyG xkDTbcoYnwwQFnmea/tZAE+QAeptwo17RbsVhnGjC7y3whyYIzOx0huwWuEIzM1aBsjE423XCUta /wA4sPqt2WY6ta0nWwtNlScHJCQg32QPlBN+VxBxTS+1wRwBdGa20bi5th7la9WQzXuJcS29x2Qw yySOsWm641le6Q7G7v8ApWb50sbNQcQ/2IVq+haOQJdGPS23uk76r2WNFjMsbxHUs+7g2WZIwloe 0+kqFFmTQbkboSNW+ykjXOBd/SNrq2kNjJtf5QCy1oBHB+FifqCCWt3KyJZGtla1rg8n27JE4hij eWyBkh/dUjEvc5tyQR8JLauTVp0HdPhiqqgEt0yEC/KTK4zO9TvKkZy0C6NGbS9mc1obFdzgHHsl MY8guAuPyuOmkdM4Akm3fhMiZLYN8xzCeARsVdjfI3I5BsRO6fFIdQbqAAXD1E08XoLjZSlbKXax 5ui+7gLhYaoto+nOLBkflgCw7rjqicyyDjdIq3xsawNf52vjTysmmwyo0B36WoY0/wBT4iii30HJ R7GSQyPjGlwa7sTwkmAg2keA74KZX4dPCI/N1OjPDgNkdFl3E6pzpKeiqahg21MjLgrsbdEeWKXZ iTAAWZKHJ0JYGkF+4CzX5Gxd1OZ/4RVMh58zy3BcbRYfXS1zcPpKSSrrHmzYmNLiVXja7RVkQ9k4 b/VsnefqF2m6z8Z6VZ0wGiFbiWXq2ko3f+8+FwaPyV8/HTz0uoPI0kc33WVBy5QeSP6ZstYxjbvU FTR6NU1x82WDQUNZjmIR0OH0k2IVcjrMhhYXOcfgBdhTdDOo2B4KKytytVU9JIbAVMZB/sViqNOS Xs+EfURwAyQkzN9vZMhxEuj1uaWhfex+GXqgzCzi8eUa59Bp8x0jYjpDfdYOSujucepGYn4Jl7DH VeIRi74dJu1bUHLlGfNBds+WhryTqbwsoVtyO57rtCXwZdYY651Ocp1MkjdtMLOV9lgX0/Os+JQg xZTqIJP9sxt/dVQt0SWWKVs6IjeJYXODbuHDQg8qWoaDBYOP9Ll6AxLwD9asKcCctSS+/lbq8R8D /U3A8tzYzW4RPTQxWL4wCXLU8TirOS1eNurPPBfPTyiKoj9R9k8sigk0awXOF7ey7r6N+EvNXXXM tXhmFskhkpTpkklFg1Y/WDwZZq6R5xwnAcTlL58Tk0Qyi9tzZSGKU3SNS1WOKtnSb3x6iAQH/Bus qmp6hpAaQb7glesKj6YGfcMwUYlSMdiE7I/NMLe4tdedszZVxLKWIz4ZiVLJR1UDi1zHggghbeGU TcNRjn0z58tdqs+1xyqkB1WbwOVVRHNTyapdmdie6vzLxOc0gahYrjX6elU1ZiyTxxyFkZ8x1rri 6100k1mR6T/cLLwXBcTzLjkOGYLSyVldM8MYyNtySV7fwD6VnUCryPT5gnxGGOvki852HE2cNr2/ KlW6RznNR7Z4Yimho4/+JdaQ8CyxTiLJZC1lyBvchd8ZM8NWJZ76zU2QsThdhNQX6JZp9tO9ri69 yYb9HPL1FHE+ozXNKbAusywH4XZ4mnyebzpq0aqGVLZnBkRvJ8FW6tdFdrxoLfdbQ88/SYwxuEzT ZXxf9TWMaS3zCPWfZeOsqeGOSTxAUmSM7SNwinMojL3m2o9rFangqO5GIauEnT4PP4xqNxDR6vkL kImOdF5riWx+7tluEwP6VHS+goxMZJp5XtBDjuF4u8WnhhoMm9WMKyXk4uxB9U5rXQRC5bf3ssY8 DyJyj6GTVrHKmePJ6qF8umIlx4JCc39VKwMiJ1W5cFt06BfTAyVlrLdLiOeB+pxF0YkfDezY+9iv t85/T/6YZiyzUHLtHFHJY+VNC8Gx/IW8WFZJVJ0YyazYrSNLFEarzRFOyzvdZjpo2uLS4agu0fEF 0lrOkebKjCah2qMOs2QLqJtGIp/U7WXcXWM2F4pUz14MyzRsyfO9W7SAeClymCmcDNIG34uqdiga TSFuuT+kN5JT6bA8SxMhz8HqZ4yNj5RK4K30dpSUfZxlf5bmiWFwLfhY8DhUQl3maSNlztbk/EaK P+bh81NG4beY0tAXFR4BXwMMRpZCDu0iMm/4W1GVWc/LD9FCN0f3kke6hkYwW1rlYMg5kqINYwqr lpxv5jYXAD97LE/0nikcpaaCeQk2sWE2Vp9mt6MeOVrXAuN/lZAm0P8AQ3V8rkYemmaqxgdTYLVy MI/phd/8KqrJeOYUBFX0FTSTf7XxkLaxyatI5eeD4sxamZlTF69iBsuNixPzCYg3dvdfU4B0wzXm pzhhWA11e1vL4oXED919dF4eM/4bSuqqvK9XDEBcmSI7j+y5qLboSzRXLZ1m2sYGEvuSOwTKSsje QHbavdfVUHSPN2MyynCstV1bpdZ3kQl1j+y+yyx4U+p+Yn2gyfiDXd/MisB/ddHhl0RZ4NWmdWmW ljeGlpLyo1oDtgQCuz81eGbOOSIpajGMInpnRDUS5ht/ddcU8bYap36gizTbbsuE8c4cs3DPCTpA TU7RCTIbAdljxTQAiNlw53AKdX1UYl1vGqIDYe6+16S+HfPHXvEPJyxhM00TdzMGkNA/K5ps6ykl 7OtZJ30072vpiR2ISwZIpmvDbMdyHL2fTfS76qOY18sTWtt6i8/9l8Nm/wABHUrCcap8OdTGonld pja0W1LtCLkeGWshF0zzTVV7GvsG6UDat0rLkWb+LL1nhn0zOsNdOyKbAoKcP/rfJwPlfQ419L7q blnD3VcrIKxrG3dDTu1bL0eF+yvVQPFsk0kDmnytbD3CXiTvNpQ9jHMde3yvus/dOcTyBictHiEL 4XxOILXttZfEVBqpy6QgCFhB/K5uDj2jvDIsitHFR0ks1QyFrHyzvOlrGi5J9l616O/TN6p9VMuQ 40aSPC6ScaomVbtDnD3seF939MfoJgXVHqDPj2P0zKyLDrSRwvFxqHwtknip67S9AMjwz4RRNlrJ BohjAs1gHH4TBeaW1Hk1Obw8s1hZo+mN1EyhSP8ANgiqWt3dIw3aPm4X0WQfpM5zzjh0WJHGsPpK d+4a65cf2XoHo/8AU5wjNGGYnhfUIR4RiADmxuaLteLHZeg/Bp1Pk6oYJmDEYXH+FwVRjpQDtY77 Be/Np/GueGfPhmlOVvo8fRfRyrpqQ/qszwNmHDWM/wDK64H0ms4VWbJ8LgxONlNEf/vmQWbb4Wzq iwLPr+qclZVVoGXQdUcZO1vZfW1GasLqc2R4VS1LJa638xsTrln5SEElVWcp5cif1dcmmjxH/T+q Og1NhRkxUVDqxwY6XlocTb+y7JyX9JquxvIAzJPmOKd0sPnRU7W2uLX5Xo/6kzjXVmUqAEkebrIt 2uvUeQ4oh0Xy/FG0+X+kjDtJt2XaWnUYQy1wxHUTlKUG+jVH0O+mTi/VHMWKQYrXuwjD6GQt80C+ vfsu4Oov0xchdMcAkqp80M/UlpMYqDbUR8LYwMNky5liZ2X6Jk9bJHdrSbAu9ytfnWPwh9bOr+Y6 3EcbxMsBeXU0cc50Rt9rBdtPgxZMjt0keXLqsuGC3WzWB1BwSPL+aMQoYS2SGCVzGvZwbFDlLp1m XPDpG4DgtZimj73U8RcG/krtnrh0Bzd0wxc0GY6RzXNdcTG5En7rYn9P3rX0cyt0tjw2euwzAsYc A2eCoaA6Q+9yvnarE8Uuj7Wm1CyY1XZqyxjpBmLJ9G+oxfDJ6QjnzG2AXxPma6lrBt7raX9QHqhk 3HcBnocHnw+tmcdpaS3H7LVnPGYKgvPF1mWPbFSOuLN5JyRMQmDyGgWt7r0j4OfBpjfiSzTG6aF9 Nl2E3qKngH4BXm6aZnmse1t/e/BW9f6aOCQYb4d6GqhhbG+rd5jjaxJXjlJqaSPROVRbE4B9Ofov lfD20Laf/j9O8k0o1E25sV5765fTZe/NOHyYGTPhM0o8x7R9g7r0v1p6KZyzF1QoMy02ZX0eFQvG qkY6wdv7Lu3NeK1GX8lU9THH+qfExl2gXLj7r9BjxrGoO00z81PUSlfqjoLKHgl6GdF8rxYjjWFU 8r2xB09TXm4JtvsV9Hlvoj0G6vYfN/p7A8Pnib6XPpW6bFdkZoyhhPWXIFNBmBj6Wllb5hbq02/K 4ToV0jyZ0tdij8o1X6xr3HzGMk1NaR7LybEk5e0XyuW38ZrR8bPhXZkvO1Hh2DRNdBWvLKeMDe54 C9VeEHwH5R6ZdPafFs+4NSVuMztEpknaD5TSLi9+F8H4g821+PeIrC3V1IY6KhqmMa1x93cr2/1W kaOkVdJG6zXUgLD8adl7s2nTeO+5HLHnmt3PCNe3i2wzJfUHOuGdO8k0MAkln8qSriYNLbngEL1N 0e8LHSvw0ZLo343hlFNXytb5tdVsDnF1twLrx94bsPbivikwmkeDIyN5kJfudV1sW66dMcL6mYTH S4pXGjhgGoWdp4C4zwqOVY2Zjkbg8h8B1N8NnTbr3lKrdgsdMZ7Exz0tgGu7A2XGeHrwa5R6TYdJ iOOYPRYjijLkSPiD9A99+6+18MmSKLJ+TMVZhlW6pikncGvc/VuON19tkikzBDUYjHjXlz0TnHyn 6rnSszSjuh6X/wAnRSk3GX6dT0PidyNiPVBvT+nwSM1WrQ0mABv/AGXH+MPonlTHemldXPwumgqI oy4GNgFzZfU0mN9JqPq3FRUmGUwzNqIFaI9g721e64vxnjE5OmGIOox/w7Y7utyvXhxrzRik0n+n HJkeyTbs8reCrxIZawPMNH02xrDKYtmfohq5IxZp7C69G+JDwtZezTgNditGzyZTG5zo2gaT+Fq3 6TCR3XXA76tbq9n2+991u6z5Hp6ZVR9qLUb/AP2VwnGEM9LqzMVOWJt+jSh078M1L1C8RlJlGoe5 uHPl/muj5ABW3Wjy1lDwxdNxTYbSRUlNSRWaI2jVIbcn8rwp4YXf/wB1MFW8D/muYT+690eLCmgk 6e1DpBf07fC6R08PkRi12ajmyTxtt9HmDph40aTGeuzcHxOkipcPnl8qOWVg916y60dDKHrLSUL/ ADzBG0tfqit6h2WlXMMeKu6lsp8ObI+tM4FP5e51X2st5Xh/p8fpuj2W2ZmBbjIpW+c1x3b7X/ZY 1m3Dk+pvTKU09xj5sx2k6IdJRUSETxUEAiYHC2o22Xyfhm6t4h1Oy1idXWM0SxyO8prdwBvYL5vx uDEJMj08EN/0j5PVpO23uF814BaiWPLOZHuJdHDKAB+AuscaWkc2uWYlJ+dRTqj7PGeq+e+n+PVG IY5h7qzLbn6WaWAOYPdfW9LeuFF1SzJPT0ELoIIY7uD+brrvxB+IvCWYBLgWGRmsxGYFkrdG0S+H 8DWF1wx3HKyvglgMxJZrFtX4WpY4PBvkqZ51kksuy7R67zlkfDM74T+jr4GSMDw9pI3BCDEMKgwb KdRT0w0RwQFrQD7BdHdQfEbiPS7ODqLEKEz0THhjGg+p4J5XbuMZrix3prPicMZpxU0xc1ruRcLy LFmjtT/i2fQlPHJN9OjV/wBdermZOnWfXYhhWIupIoZ9b4G7a9+FsJ6aVNF1h6L4VjuKwlv6ymD3 C+4NuVq68WpM2Z44WAkyzNaCNyTf2W0foBh5w3oFl6iljMTmULb32vsvdq4KGoSj/R4dPklLE3I8 G+NTp5hlHg8/6Ued5JOguFzZa2sWj/T1zrDSLnay2b+M3E/0lDWMkIG5AC1l5ge6fEZXNFwCSbLr /l4wWOLXZ6f8POTySj6R2f4W+j0HWrqlh2D1shbRNla6WNnL234/C3dtiwvw45HocKwHL73wwwtb FDRxWsbd7dytUP0xKF1V4g4X6bxxwkm/C3OdQc80mQ8rHE6uBtSGtu1rl+X0ly1DVWfb1cmonxnT nNknX7JuK02PYNLQMBLA2ojsfyuo+iGQWZE64VFDQVDn013GRodt/Zd3dGOsNJ1MosRdFRtpJ4eW xj0uH5XwnS2mNR1xxep0nR6rFfd2cZItVXo+I5fxafJ9znLp/mbM+dqasFdHT4VTOBYL+o+6+c8T +eMGyp0+qKTEJ2uqnx6Wt1eo7L5LxVZrzpgbp2YDWz0UDGmTzGbhareuvVrOeIV8jsZxqetkvp9T ibL3YNO4xjnyS4XVHnnPfl8cVyz1R4PsXgzB4j4o6JwEDWFztPvfuvWni2xienp2UzJS2MtLnAG1 wBwvDf0p6GtxjqtiuMyRvlp4otOvkal7d8YmHSSUGHSxMLpHtIeAF4fLDUapuB6p45YMdM5rwtRC k6TVmJRRiOWQO2PcryP1xx/NdBj9XmSnxB8VdTyHybPsGgX2svYXQSeCTotHhdHPG/EQxwfG0i4P 4Xl3qX0wzV1IxWbAMOp3MmMjmzSuYQG3K+vpYx8uRyPnZm3jTPMuYPH11MmopMPxCpgmYAWXLd15 36k9YcSz/B5VfK6Rxdcn2Xv3Fvp14RlnBRV41XefXW1P0nYleRfEj0ewfpuWyUYDnSDYDsvLqsuV wcI9H1NGsKabXJ0RlrCG5izHhuGRkx/q5mw6rXtc2ut2fhT8G+QOk+TI8QdgzMbxh0TZXVlQwPcb jgDstNPSGIDqdl7UQy1WxwLuLg3W/wBypW10PS5gwuSNmJPga6I25Iavyat5YwZ9vUSai2j6DCso YBj9E9suW4KCMXb/ADIgLj+y6qzxk7IXTXNOF/qsMp684jL5YgDR6STzZdb4q3r3n2slwwTzUTGX AngIa0hdev6J9UGZ0oaHHK6SslimDmVL3E6dweV97wKLtv8A6Pzvls9uTZPyLlHDXYlU4Vh9NFpB L5I23/AuuFzbgmUMRye7G6WhoWxxs8xr2saNlxvXDIlfmbp3hsDJJP1tNG3WWHZxtutdnWWvzplO qGF0mYK7yn3aKDUQ0krtptPuh5t3RznlcJKBsc6RYjlfO+APnipKKVlOS158oXFv2XNUOdskYhU1 GHxtp4zCS1zS0ALpHwHZLx7C+jtY/H8Pmoq2qeS1rzfU08FfAdf+neN4M/EK+jqjRvFzZt26lcGL HqssqdHTLlnjij0tl7JvT7Fc2S1uHQUNbXN+5rmhwB/C+S6r9fZOlOPx4YcIp3RyPbGxjGjuV548 C2dGz5zxCKvxG1SAQY3yXub/ACu4OqHQrM3UjqfT4trjGDxSa2uJ3Nl2jDGszjldpfp51OWy4n3f VOKlk6aRZqkoYxiMbWzRNtYNv2X0/SHNVPmXIEGNz0jInRxEuAaNiPZcd1Uwh0/TaPA9bWSmEMaC 7krkOj2UpcudMosLqZI/MeHXHAF1xml4b/v/APB03yckmYOVuumXM2T11HXVdJh7oXlgbUENv/de ffEZnfL9BjRdRV9G6BrLufA8bm6+K67dGYcMzHXySzSMjnc58boZbWK8C9WJa/LdbU0wr6iXy3EW keSvrwwY9GvMnaa6PIsks0vGkZ3iOzVhmbKx1RC5sk8dwC3uF9L9OTKFPmXrrBPVRtkjpWawHC+6 8zHEJaxs8kshcT2K9EeA3qhgfTbqcJsZqf0jaghjJCdh+V+L/wAhlWaTcD9hpcDw49rZty6vZkrM kZK/X4Y9sVWdmC1reyHw89SK/qJlaubjLzPX0+xPIISM55boet+AYazDsdgpqdoa8lkoPmBcr04y nhXR7Cq4VGMUjo3gm7ngWX2MLx/HUY9nw9Tu8nJxPSvNlVivU7FcGIEdJTvLmtAtc3Q9Vs119H1X wfDaOeWNkjwHhrvTZfOdPs5ZHwjPWJ4s3MsHnyPIMRkAF7rPzfjGC4p1FwzHYsw4Y7D4yPMZ5o1j f8r3PGnlv1R41J7eOz7LxHMZT5HiDmAvIFzbuvB/VuiH+ha+Z27WsK9jdeOqeV8ayy6mo8Shq5hb S2N914f6y9QcIw7J1TBPVRiSRpDYQ4XK+lopRhpnHJ3yeXPulkW08J4fC+ozk0wfeZgR/db1egHm wdEcIM7XCV9EGm/J2WhjEq19PjT6mieWua8vaW9t1sF8IP1AaTDsOoss5zcWCnbojnPDm8L8U2o6 jk/WThKWFV+H0/VsyYhm2sp6WGSWpa4jyg3krob/ANI8w4b1CocWxLDJ6SATsdGHNIvutgtN1B6D 45muDNjMYgjr2N9UIIs4+5CHM/iJ6SZjxeOlrXRTwxPuyYtAsv0mTULLBQSPzmPA4ybZ2fiuYcdy j0lwuvweJ0lUKdrvKIvtZeKep/XTPWZH2xavf5DpQGU0Js0b9wvWmN+J/pTiGXRh0WY4aZzYvLjY HfFrLw14gM55foaCSbAcQhq6lknmtcSNzyuWlglFykjpkjJpKJ7syDW1ruhbf1A8iU0xfYCxIsuj /DWz9b14nDLyOhaQ82XyHQr6iXT6syZR4JnaSXDsRhj8qRzW/wAtwHyu5MreKToNlysfimB4rSiq kF3SCwcVpZPrJR9keGUUrGeN1jpm0cpH8uG5J9tl8j4L6R9ZjM9XHE7ydH/McLBfFdTfGHkLOGby zGa+I4NGdmtNy9fUZZ+of0SyFTNocOp7Mtb+VH/5WHqI4sKxPsqwznPcjH8TsdfSdRjWMpZZadgu CG3Fwup6rxsdTMlzww0E8LKOMaI6edux9huu5c1ePno1m+idaG9Rv6jZeR+oXiE6fVmZxWy0RrqG OS4gY3nde+Uoz0v2VGFjn5KSNl/h666491D6Wvx7HKCKLE2XLmU7fS4e+y88dYM94rnTMFSY6J0L QSA9wsvnOnf1LekeWctxYXHg1VhzNIboY3b/AAvlOpXjFyRmfD5qnBq2OmmAJZC4WLl4NDqMOOUn Jcnq1Gmy7FR9TlnwZYP1bpjX4/WfopzfSQ3c/uvjc/eDPK+QiyCmrRWEu39W4XQE/jy6h5Vq5IKO enkor3Yy19vyuExzxu5vzO7za2jivxqZcLMdXjlmlvZuGky7I7UZvXvotgmAYRPXUc/l1MTdmX+5 eaaZkuG1NJUSN0sDw4X+F9tnXqtiGdw5tXK7XJ/SDsF8LLNLMA2Ul+nj4XxNXOE5twPvaXHOMKkb kfBd1AwvMvTiliwyqjkqWxAPjBGppt7L7es6cZum6i0OINxJ8+GF+t0JvpZutM/SvrFmno9jrMTy 3iElM9p9UWq7HfkL1/lz6s2d6HDxTYngtLUvDdPms2P5W9Ln8Sp9Hl1Omc1cTadUY9TUE0VHPV07 pngBsbnC9/wvjuvmVZs55NYyhpXVtREb+S0lpctS2dPGnmHNONtx4Mloqtjg+NoedII4X2uXvqm9 Q8EgYyooKarLdhIbglfUhnhCammfLeny5IuNGxnw69PcYyLglXPjHmQskBcyB7r6P7rpbrNj1BhH WKgxoOEzIpB5g4Fl5bxX6pWccaj8o0jIGH7gxdRdQPFnjGcGukEOh55evoLPHnLJ9nlWiyxpbTbh mp8PVLIzBhdQJGzx+nSQbLyVjXQ3F6TFKmLUPS7uF4hyV4uupORHObhOOSNgLtQik9TR+F9DV+On qTW1D56iqhfM83c4Mtcrjh10UnyeyX+OnLk93NjZNTOcCHO5C8/eJ9sr8CpJ5Ll7HaTfsF3Vgpma xwc71HgLqnxRUzn5I1NFyDz8r/OGmX+2P/J/bMruDPIVK2NlY6xu0/8AdclELkiy4rC49DS55u49 ly9Pze34X9Fx/wAT8rNfajEqx5V7rjHnm3BXNYjATFq91wb3XuCbWXrgeafBBcDbhYlWy41XtZZV i4CwS5ItTbO/suyODMNjw1hJNx2WTHI1zGlp3XF4tMaSMaBybLIoZRJC023VohnuDnAEbqaC0B3C CJ7gbHZZc4EVOCSPUpdGkY1t73UAL9uPlW1us7qBpBQlGG+N0cjgN7qPbb5TpzYHukWcWWvutEOO r3fpiydgu8GwsvtOmNRE3NdFVSO0ua8E7r5R0QY2792t7LNw8X/4mjeWyt7LcVboy+jdL4UfLfg0 M7AJQ9l9QIK+K8bvhcj62CPE45Xw4jTxlsbSNitc+RfFX1D6eUzKfCsTkpzF9rXH0lfTYj9RLq/i UMlK+qhlB2Lizj3X1MOVQjTPh6jTSyzUonRWbsj4p07zNVYBiYIdE+1wlzlrYmjcJWas5Y1n3Mj8 RxSQuq5TdxTPPadLJGG42LrL586bbR9fEmlUjOoJdUJa1n7o/wBUDcabELFYKilcHtb/AC1VbWfq YtUNmSDsdlzO5l6za5CS862vSWPNPSeY4+Y8dghhr2Si5AjB5ulMlmRTWoSNe2vhe3/BV16wLKGK 0mG4xVxU5eQGSSmw/uvC9e6Kp0P87S1vG6x4qmJ5DH1RBHDmmxC7xtElFSVM3wdUMlZU8QWC0TKn HKaGOns9r4pm7jlIgzxkHoPkt1B/qahcyJu8RlaS7ZaODn/MeFxinpM1V8ELdgxs7guHq63G8ald LU4tU1RO5c+Uu/8AK9yzUuT4s9E97aNvOQOq/RTqriWJRYtT0jqh0hGskbi/K7Nybkro/wBO8Ufi +AYth9HLKdWl0zAtHmGS12EkzUtfJSSH+ppIV1OL4xUSOE2M1Ly7jTMd/wDK9j1W53Zj4D20bKfq C+JnLldlebKeHV0VdiM7xqdA4Oa1v5XKeBjN3TjK+QoaaTFcMoq2VgNRHWaQ5x/JWrqGlc9zp8Qn fK8DZz3En/Kxppf5gMcs0LB/W15AXhzZt3COmLSPFzZsn8evUbIcDMPxDLlXQf6ghcB/+j3CxHub L6Dwn+PzDIcJiy9m+qjDomBrJ5TsR7Fauaem/US+Z+rdVW/3PuU+vlgGzg6N/Yg2WIzO8sDnCjdl njxq9GOneBVddQV9M7EJG6mxUTRqe/8AZa/W9esH8QnXlmM55nZT4RFJpgimO2kbi68dy+XMATPI 8D3N7JrG00pY0Oke734IXoWaUU+Ozz49Cou2zdTlrxJeHvINPE6asw6krIYwGOiaLnZeVfG949MM 6k5fZljJNZJ+gLv5kwNi4dgtf9cxskZDY55XjYOc0m37rFhmp42DzGOD29iFPIkr9nSemjOV2e/v A54xMq9FGzUmbZ5aenmAIlbvvblO+oR4tsi9cMrUWH5VxB1a+J+olzd14Llq219F6IdQbyLLAbGK fTL+lkBHZzTZcfJNOzo9NHg9NeFLqxkTpxiX6zNtJ51yNALb6bLYrhv1MuimW8v08ENXO5zW/wDK jZey0wUNRFiVQBpYxzR9r+6a+OnqpzHHAA9p9Whyir2alDdGrNoPV76h/RnqNSU5hoKwYrRya6eq MVrH8rnssfVCylRYFHDj1C6uELdILG3cQOLgrVLLQ0RDWRNIm9ne6X/DnB5Ej7PbuWg9l2cqPJ8S PJtexP6svTqhwyp/g+AVcdY8HSC0NF/c2XRGQvqb5hytm3FMQrKZ2IYVWSahDN/7Yv2Xh+SghmY1 8TNNudQVh7I5GxFuqM82WllUVX6YWhi+bNqNL9XbIhp2mry5UtqWj7owLXXm7xNfUdxjrdhM2X8H w44fgkrvUSbvcON142r5IHS+VFEXAcm1wsiDEWRxeUIGtI4LQos0YcpcnRaJN2+T2V4YfHvgXh8y ocLr8uS1dVb0zxt3J/K+6z19YGtxaiqKDC8qNZFPEYy+Z24uvA051wMdK5u/9JF1itFLqDnxtuO6 5PNb3Hqemi4qLORxLMBzNmavxaoZodWSGQt9iTdXRxQyVBLptMo4aCsSojjEkJY27D7IHYTGat87 pnQ+w4XKU97tnohjWOKijtDIvVvGendZHWYZVupKmIgtIK9EUX1ReqOF4U2mbDTVL2t0+e9lz+V4 ybDHI8Rvk13GxJSpZnQSCOM2aFqMlHsmTH5D03mf6h/WfMlPLB/FRS0swIc2Juk2Pyvk+l/jO6kd Ja+rmwypdWfqXmSRkpJBce66TZNUXIMhc3s1VGHRPMjgWkb+y283P9Hm+LG7Z6Oxr6kfWyvqfMbi TKUH7Y2N2C+D6oeLzqL1dwWHCs01DK2kDtQ27+66pgqBNUuDxr9gQgdW01NWCKqabO+0jssvO64O i08E7R2fkLxF596WBrsuY3NRxf8A0dXp49lzGePGL1W6l08dBjWYZm0g28uE6Q78ldOVNogeXwnc H2SmT09WAxzixw4IFlI5pRLLDCb6OzMpeI7qJ08qHjBswz0JJ9N3nSR+F9HjPjr62YpRuoajNNTp eLa4Rv8A3XSjaaHzdVRLrDftBN0mLEKyOpk8tsZjA9Jdsunm3LlHF6aLZ2DhniN6oYbXGshzbWU8 7zu58huUnN3XrqdnOohfi2b8QqDH9gZMQ0ftdfD0khexzqprXuO4aCgjfHLMREwtcOfhc99HWOCC VNH1T+uPUmKkfh7s4Yk6mfsYjO7Tb8Lh6bPebaN+qnx+vgeTcvjmcDc/grBke107Y+XHYld5eH/w f5y6+Vobh0DqbDgfVVPFm29wtRyyTsPBjXLOp5+pOenNGrNWISD5qHf/ACuDlx/MVRVGplxqpM/P mGU6v+62I4j9Haulw7zIc06atrb6CLg/C6wyJ9MjNON54qsBxStZh4g3jmmdYyt9wFqU75Ry/wBK 4SPJcPUnOrm+V/qfEDFbSWfqXWt/dcz02zPh+EZtpK3MJmq6ZswlkEhL9ViFsPb9HTC44Q5+b5Gz adwGekFfDZ4+kbmDAqeSpwLM0dcGkHTIzchbjKUlVmHLDHtHp/Jfim8O/UXL1BFiNbQYTJFA2MNn OjTYW2IWd1A8ZfR7pL06xGDL2YaXFJ3ROZBBTyajqI2J+F5Jzz9LDEcE6XzY9HXCoxqniMz6dlxc AXK658IHgWp/EK7EpsQr3Yf+gcY5YS+5Ll1jBfzk+jzOOPI6jweVM+ZxkztnTEsakaGmoldIGN7g lcHHNQvN6imcx3+FsaH0nqun6mR4TNjHlYLM3W2djb7dwu5oPpY9I8BMFLjGPSSVUtmtbK9rC4+w F1xyVklbPRiywxR2VwjUO2amez/hw1luwPK5KiqInW1NDX+w7rYZ4mPpV0uWcpVeO9P6iSWoo2GV 9NI77mjckLXzguV8fxfGH4PhuFzVuKRyeU6OJty13yucsfFo9kM0ZuolCV7am4JDD/Se6JmGmpmL xE6Fh5cx1lyWb+jufskTGbE8Hq2Rhusv8s6Wj5Xy9PiNRO3UJi1nBb7LnF7XZ14k6HVNC3zzFrLv k90cdGWtsy5PsN05r9UDSN3ONrr7fpj0xxnqbmSDBcIp3S1Ezg0kDYA91pzbZh44L0de19GGlrJT 5pP9IFysVsNHG8NDHAnm/ZbmeiH04sg9PsrMxDOpbiGLyRgySSusyK6+V6//AExsl5ty1VY5keqd DXsjdLHDEAWzW3sCF2jOTVHmefHHho1NBlM1pYyB0u3AF1xXltp5y99PJHFf/abLbv4Qvp95foMK jxjO9E2SveSBQOG7bf7rrupuQvDniecKnJZwLCKnG4vS+l8sF1/wsSUt1HF6mFXXBogphFPKdAbr 5AcFmPpTWaWi4kH9DBytmnj0+nrlvL2Tv9a9PKSPBnUTtVbSEnS9h7tHYr4rwA+B+m6l1Zzdmpod g9O/+RAN/MI5uuLTqzrDOnHrk1/YlSV8AjNThU9MwbB74y0FGaOSofHHTwF0rhYNY25K3F+OPAuj uR+nBwn+GUjMdlIjpYado1A8briPAd4JMJy9l0Zvzdh8FfPV/wA2lp52atDeQTddfH9dzKs6NSs+ XMawYNnrsMnij/3vYRsnxsfXxthpYnyvP9I5K33Yj036NdWn4ll84dhtRVxgxy00TQ2RnyAPZeb+ nv0/8GyJ4g4pK2lbWZeYTNRxOsQRf+r8LooRppcM5LUp98mqs9Ms2TATMy1iEsJ3D207iD+9lxmI 4fW4LL5dfhNRQPGx86Itt/cLff1q63dPPDtJhuG4rgkLI6khsTYqdukD+ydm7pjkHxL9L6rz8BpI 6erpi+GqELRJGSNiDZYUW0m+jD1MVKvw0MYDl3GMzh38DweoxVzfu8qMu0/mywMcwvFMvVRpsawy ow2XsJGFv/dezvDN1KwPwsdbK/B8QpoqzB3VjqSQyMDrDVYO3WynrH4eOnviR6bOjfhlFerg82kr 6aMB7CRcEEflJQcZbGdHqU4710aB2VjIYmm/ms9ysmSlB0ywgeoXsF9N156L13QjqViOV6yXzWQv 9D/dt9l8PFVSwNDHEm3BC5zjKDpnqxThljugZLIK2GV0usuZ7LPjrIIY9b2FzvZY7cSqIYQXQ6mH unQGOdzS4bO7FYTOwUVRPLIA1ti82a1egunvgh6qdT8AbjGDUEb6Rw2a82uuj6L/AO/Y3RgfynAg n8rbr9O3rtS5vys7Lc0TmYhStDQQ2wIWm2uEYklFbkeDav6bfW4OeJ8AZHHzaJwJ/wALqHqL0Kz1 0LmdFj2B1UVMdjKYjpH72W+Hq31Jq+n38JdBCJo6mbRKXNuGt99lwfiHwbCM39Dsedi9NTPEtIXR OkYCdRG1r73XeEXKrXZ8uWqak0n0fn/o5XVjyQTod7pkkMMLv5V3TXsTbZevcl/TG6kZ2po6+J1N huHVLjLHJO6ztJ42XJ5m+k31QwCikq8MxeixKUC5gY4gn8Kzw7JNWeuOqi0mzxTUBrHet4+QlB1M GOubX47L0x0l8AfULqfj9Rh0tG+gbTSGKoqalto2ke3uu9qn6O2YW07/ACM20c0gFwCwtBPspscO 2dVnhLpmvOnxuoghELYhOy/3Epupk5cTH5O1916lzr9OXqZkXGKekjpG1kEsga2pj3b+F3lhH0iK +uwmmrMWzbDSyysDnQNYQYyRxfhTn2x5oLs1xtqIoyGF4c87c3X02TslTZ6zHheAUsjY6mueI2vf wLr3Pnr6QFVSYBNU5dzAK3Eo2F7WP+2Q+wXnXob0bzDlrrtSZczJF/CMXpJw2Nr9rkcEKyg9txNR zQm+Gd04r9IzMgyg3EcPxds2I+X5pjJAB2vtdeEMw4XWZOzJiGB4nY1GHTOikJPcGy/QRjEXUPL/ AErq6el8iqxOmpXaJL3LmhvA+VrG6AeEeDxKdZs1Px+Z0bWzOkqbDfVff/KsMLnjcr6PO9SlPY0e KqeaKsmefPDL8AFMbGWOdE2scfxsQvbXih+ndB0OrsMxbDq8PwKtqPIeXneMldzZf+kzl3M3Tujr aHM2jEKqITCZzSW7i9rheWWNxSkenyRZrDtVPY2KStlmgHAleSmxQUEbw6aXSDzfe62q5N+kllLD aF7s2ZlqKsN3JgAYP7lfRUn0zOjeMU8kGGV0tVI3Yh7tVl3i5VVnlllxp2akPMgdG5kL2ObfYtPZ ZQb+ngvG7VZtyvRPjC8C+M+HDEBjGEVH67Lcx9O3qZ7gry5DW1FRKxrBZh2cFznBx5O8Mscq+o4V prYnNaDrvZH+pbAwMlhfJf3aVzuXcNgGLUrPLL2Oe3WAOd1t18Nfhz6VZ06e0MuIZaiqqx0YL3TR i9ypCK9mptwjuNNTRSzStIaWOv7kLIqYWve0xSObbsN1ud60/Tl6ZZzy5WyZdwr+DY4yNzoHxvIY XAbXC6c8DXgwy7VvzDNnnCosSrMPqXUxjf8AaHA//iXR4047o+jhHULpmsKV08rbRwvdb2BN1VJV FrS10cjXj+kjlbuc89N/Dj06x/D8GxnBcOwysrP+W21hv3JXyWevp89Kep9VTYrgFdFSx6g8tpJA WvHtcLUcf/3KjK1mNt16NOr34jvLTYfM/wD+ywlYNTiGIU5vU0lRH/8AajIC32RdEej/AELyEcSx DAaNtFSxjzamoj1uNgvnMvN8OPXvDJY6HDcFkcLtc0MbG9pWHFegtWk6NINGyDGo2BtJPLL7RtN0 6bDqynILsOrPI4IlhNv+y3ldIfBJ0z6f4lU4tS0UOLtlkL4BM0OZGD2Huu3azpnlKqkNPLlHCZ4H bO10sZAH4stx2Lh8mpapNcqj86tHRGrqzBR0Ej5nD/kxxnUf2WSMHxqjmdEcCrW3/wB0J/8Ahbxu oHQrpx0zzFh2dKTL9BQy+aIZYmxDQ+52Nl2fjuWcp4fluXGTlnD6ljIfPIFOy9rX9l12wpNLs4y1 Ncv0fn3/AEWLYY5v6jCZoInH7nxkL2t9PzwpQdUcXfmLM+Fv/hMDrxtljsH/AN+y2DUfTbp11kyU 3FpMp0kbHtcWN8kNdcfhfGdCuvmD4fmao6f1VHHhk9JK6GnbE2wcAdr/ANll4209q6OUtZGSVezr /wAa/g/yNL0fxSsy1lJjMcisYDRtIIK08V9FieWq2fCcUo5aKoPDZWkOav0MdfOseC9FckyY5jTf NpzcNhtqLzbiy0j+KTrHhfXPqcMawzDosLptWnyw3SSAtRwyni3L0cseWSzuJ1XQNp20jon+qQjn usfDI6mWX9BSwvqKiV+ljGi5KbT0jJcZlcHfy4wBYL0f4M8j4dmDrBhxro2StMjXNY4fK8UnR9qM W0fA4f4VOrOM0Mc9Lk2unZILtMcZ3H7JOMeFXqVgNN+orst19MAd2mI//C/QBHhzcIwFlPhrYaZz IwGOe30j82XzuXayR36tuOYphVbECQAwtGn83K3BWraPBkzOM1E0O4D4XeqGaoXVOEZTxKrhadJl EVgCvrMveAPrTmISaMsVNE9nepda/wCxW3rCc8YblvrGMAwqeGrgxRvmOgprFlO4d9vdfedSeq2B dLML/iWYZv01ECGmUDYLsoNOkrOEtV9XK6o0e4v4IetWA4hDSVeXpSZHWa5m4/uF9Vhn0/8ArLWW ijwWZhPJcLAfkralnHxK5Crsi1OKYHj1LUV5aHUjCfUX3Ftiu08g5gfmLJmG4jO5pllpxJI5u1jb dWUUlaVGY6mbdN2aWM0+ADrbkzDziMmAOq6Nn/MdA4OcP25XG9KfBd1M6yTV0WH0zaaSjfpkE506 T7Fbc8M8WfTWuxKvwquzNS0lZTzOgdBOQCSNl99kKlyyzD6rEsrsgdTVjjJJPBxI78qSi4r7I6R1 W7pmpKt+l31ew6J0kkNNUv030wShxXzOG/Tm6sY9i/8ADjQxYfO4el1Y/SDZe+MC8SGYK3xGuwev qJafCoJnUraN4+7e113X4hMXdl3L+F4zSudHXsqmNjkYbHSSLhdpYHBqMl2cI65zi2vRrSwz6S3V d1U1lViWGRU5+5+u9krqJ9KnqRk3A5cVwnFqfGJIGl76WJxDiB7e625S5kFLlL+LEOkbHS+c5ttz Ztyuisi+OrIObTW02I1EeC1VNI6N0dS8DVbuFxjCT523RqeqTaSlTNIE9HXYRjNVh2K08tFiNK8s kjlbpIIKz2atN3m5913L42s85f6j+IauxDLUcDaNjLPfTW0vd3NwumHB7qSMAeom5uvHnioy4Pq6 abyRtj2Qte75WQyMg7BSKmPpdvdMc0tOq9l5j2lObugLL72Rl2sH4UbyiFgeULfKswghE7fcJesh w22VMlmnHdUIx7InE6t9lA4FCgmMEAW3VxRhjr2sUD3kmyOnALxdC0P0uPPCWQbW4WVGQdrhUSL2 UKY4juLlTy7b32WU0McLIZGhuwKoEEWab89kDIfMcL7lOfayHTY6gdkMFxAuuO4S3vDJg08rLsxk GofcViSBr5NfdQ0Me6zOLFRoIAukTPLi0DsmmQubb3Qo9s0ZuHAW90uOaLU9sR52Kx3StYC1wuSr p9MDJTbdw2uqDGioxFO5+u5Jus6SztJAAt3CRGwGMaiLpgeLWWbA0sa8C5V1EQjbfltkkut+FGyX BBNwlgwq29RTkRD1IsK1spGxvB1X7rKiaxjzY7+yyWBhdYCxTshQj23UDmxnT391U1ZHCN+ULvKm jEwdv7KcAb6SOeUnTpfseVQcCLjdC6S3OyCzJc4WAI3SXCzrW9JSXS6gQ07oYzK0es3F1AP8hrzu LIHUzGm9rpuvYEEFBK4gXUaKRkYB4R+VpF1ih7tzqWTDMx7Q0vAPe6zXJbGAN22ui2vsLWSpHBhs Df5QmU8raRka/fjlLAJbYiyEyHnlCai1lRY0R3Oyjmgc7pRc4tuFiurJBIGlpWhaM3Yix3/KmvS2 w4SDNYcFCZ7bWVA7VqBBRN0sZY8+5WK6pbERraRdPc7zmhw4CllF6iHHuFQBfckKtfZGw/ssgH7g TayvcDlFcAc3UuHBaQLa6xBTDU6RtygDrC3ZCbFyiAJndM0tI2RGIEW7KtLQqMg7K0CPgANwUl7j G/fhGZidiNkDy13KhgYbHdVueEouubXRB7mA2QiQxxs35WPL6yLX/CYZXEC7UNtZ+fZQpGjfhS7b +6BxLRwsd1S3zLFAZXmt9uFLhwFisbzmuPFkYkDfwgGk3Q6eVTZLqGQHugCY03Ue71W5IVg3G2yC aURtLgN0AEkkjXgDdp/wlmR0MmsceymH1lPVSu8+XytKKoeyWYeV62HghAGyq1k7C6PzvZIlfHS6 RcazyEp87iQGxkA/1W2VohmGQoRN2WIHPDuQR7XS/wBZqcWkaSO6tCzkDJsgdKeFgz1L4o76mu9g Clis9Ic8Bt0otmeZrCyT+pu7YbBYr5y8tDXNLe5uowsDvTML9xyq0yWjNdUCW1xuERf5nfhYLp2R uAdc37gJ7AHC7X/ssFtGS06grIFrFJLnxi/ZEHAsJcUBYF7gHdBUPbAy4Nz7ISzySJ3H+WRsAqbL DUOJmcI7cIBMdS6a40kfKyhTkR3ulQVFO95ibIwu7XNkuofJDG6OWQRDs4brdMBtY55OogD3KB5d GbchcdBjFG3XDVOMm+xaVcdcJJdETXFh4JKUyWjkxKWDi6sTtdvdcdWGoiZcODR3uuMOKCN3qLyB yQEr0Lo+lEwA5RsnHvsvnxiLHM1McZfgDdE3FZYgP+HlLT3DbqbWZ3HPGdpaSHglKEr3G1wR8LEh rYZoS4RO199rWSYZpIXPc2KZzT3DbhXa7ou5Ucm6cR2ujFSC3Y7rjTUSmF2qneWO4c5hFktkjJJG xQB8kx4YwXJTa/wyskX7OZZU8b3TfOuN1xT6PFaUB8+GzQwn/wBx8RA/umRySvdpcRp+FHFoLJFu kzPe8adkNJA0MkmlfpjHuuOa2qqKkU9LG+pnds2OMXJXM1mT80YZTCWrwDEI4nC9jC639rJFOTpF ckuzEFRSyE+XOLexQyyiKMyB12hfSQdF871WW/47Dk+tkwbl1X5Jsz8riMCyTjuZKo0uD4bPXSg2 LImF2n4K3sf4c3mgvZxjK4PaSBdqD9Yw3tddgUvh06m4lN5NJlCvqZONMcBssxvhK6vB4aMj4nC9 3DHRkf8AhVRb4HmilbOszMHEAIHwvl3YbEbrtmt8GfW2CNj/APRtU9rv9rN1wOM+HbqVlKn8/Gcr 4hh9ODYzPidov7XstPFJK2iLPjl0z4KLzJCAN3XtZDiVaMPIZJBJqHJsuyMgeGjqb1Y86bKmBS1z Kc+t7eAfZLqOgXUqm6gUuS63B30WP1NhHDUttqv+VnY2aWSMumdbMmbWxtMbtN/fssyKk2/mzjUO 1+V6AzN9OvrVl3CJ8VlwL9VHEwveKexLQO9l59mwiamqn01bG+GqhOl4cLEEdioouXRPLBOmxrTZ walTTSQzN0gkXWQPJ/TkNd62rAZWFjXucQXdljg7GZVsEml8Q4+4LFLrSf8AKIHey5PI2Usx9UMw Q4LluikrKyd4aAwXt+V6A6lfT56ndLsktzNLTPrY2x66imhBJjFu6sVu4RylkiuzzXXFrwzyzZw4 CGtEzqdhbMIj3BXe/hk8HWM+JjM09EMQbhdPA3VI8n1N/ZeoZfoy1wu6PPEZtwHxmy2o80cvNGrR rfpnSmdg1Mk/BSZMUH6mRjyIrG1l7X6wfSuz709y5V4tg9dT42ykYZH+SSHaRyQCurPCv4NX+JHN FThj8Z/hslIT5/mD1bHcAHldnidWjMdRBurPPIq2G9pAT8FHDU/qGlrzo9nFbUMT+j/lHDcHqqqf MdQG08RkLgLAWFyV4cwbwk4tnzrBJlTITn4/QslMb60j0Qi/LikcbcbN+aK7OkXVOj+VEGyvPclG 1rnuDHsLXEc9gtsWUvpE5IosAp48z49O/Fnj1vpzpYD7C/K678QX0sabJWTcQxvJ2Ly1f6JhkNLK Lue0c2SOPccpaiMezXM2CUP0h4cAiY5xdZH+glpcSdHMHRyRPLJWH+khNbHA81L43+pgu0X7rEob XR6oyU1uQHradxY/KxJKoRy6DsfwkNrpp3BkgLntPbus2eoLqcaqN/tr03WKK2l2O/8Ab1Hi17pT ZwR91gkyVJZTabEg7bA7JUbHxNBMMpB+L3SjO+K9maJzHbe7U4zMtqB591xhqyPQWEAdi0hPihfM 25jl0WvdrCQlMb4rmzN1h+4fc+wQF2sX1aWjujo8LrqhhkpcMqKhjeXtjdYf4UMUzWPYISXE7s7j 9lvZJqyeWH6GYYqyMWkFx2KxJpG0x03v+65KhyhjmIeqjwGuqCOTFA4/5WBi2VMajltLhdZTvH9M sZBP91pYpPpE8sP0VDNQkESsLnHuEwU1BUHSJHQ34Ky6bIeZqmJj6fAap7XbAiI3K5J/S3OVJD5t Tl+vgj7ufA4Af4VWKVDyw/ThZMMbRsEkNV57AftVzVOiMHSWkjgoamjlpHuiF2zN+5jm2IQue5+l 9RvIBsOAucouPZ0TT6I+R7IPOHfslUVVFWvcyUPicB32V1E0+ITU9JRwOnqZXBrIY26i4/hdu5X8 InV3NUcNRS5UrbSAEB8Zbz+QuXbpFlNR7OnzM1sjmMOsBLdK6SW+nSAO67ozd4MurmUKN1diGV5o Kdn3zBtw38lYGVfCV1WznSmehy5VyQ/0v8sgOHxcLo4NI5PPBLs6sjm1gjTcj5VtdbexXftL9PLr Z+mfUnLkzdr6f6rfhdX9QOjOceltU2LH8MqKMuNrzRlov+6vim+lZI6jHLpnyznPk0hndcVidQ+G UskuDbayyZqieIhw3I4suV6c5Sf1D6h4VhFS/Qypma0/I9ly67O7kqtHO9FvD/nTrtXTwZYwWpxH yLeY9rfS2/yu+v8A8151gNG+rFEynka2/lPf6lts8PPRvL/Qzpfh2HYPRR0r/wBOJKiXSNT3Wvcl eesufUcwV3WPE8qZhpm0mGQVBp460bNuDa5XpxY3NWfFz6pwkkma68J+n51fzJiU1NTYR5skBtIT s0fuuzsH+k31ZqKVs5dh9K4jdkk2/wDZbDp/ERgdV1qwXBcr1sNVR1jP+IMNixxPH/ddrdW8zYzl XLNNX4TRSVtQ+oZG6KIG4aTuV3UEqPOtTOdp+jTbn76cnVvJz4m1WGQVUUrw1k1O7VcrlM2/TN6g 5M6eDNVXidOIms8yWmFwY22vutztW6slwijcKVtTUua17mTW9JtuvjvEZQS4j0LzLTtaA40ZLw3s O6qhGUor9NwyzttvhGmzw1/T9zT4h8NxHEaatZQ0lK8xiVwuHuB4C+Q6/eEbMvQjN1Jl+tnFXPWP DYNA+662m/TTqIaXpnjWFw7mCvc4/F+Qvi/FPmTKtH4psu1mbKds2H4fGzSHizQb8rpLBFTlF+ja 1MnGL/WeZukv0mM25xyszGsdxBuGGePXDA3dx27hdB588H2bMq9YR09o4pMSr5JAGNjZ/Se6/QHl zE6LHcCw+vw17TQTQtfFo+3SQLLUv4xutGOdJvGPX5hy/NEypoY2jTILjjcLlggppo75Jyg1z2fY dPfo8U1TlyOXNeYH4fiL2gmOEatHwVnZi+j/AElHhss2AZr8+qYwlsdQ37iOwI4XxmFeLzrV4s6/ DcrZda7DnF7fNqMPZbvuXH2WyPJwk6bdMqWXN+JxiooKfVV1kr7DYblahBpWfOyahubiul7NAXVv pziPTLNtXgWLU5ZXU0hYGkc29l89Q5TzNiUTp6fDJ5YWi5IjNgF6T8QXWDK/VHxcRZgq2sOWIZ2s e4DZzAbElbRMuY94f6jIFM+imwOChkpwLgtD/t797q5scVLjs9+DLLYmzQ/NDPh8RbM0s7ua7kKo 2Oq6RzoxZpC7N8TBwGt6u49HlwD+EiZwhLRZpF+y64Y51NSOY1ty3sF55weP2e/HlWRXRweHQzyV TqWnaZaiQ6GgC9ytkPgp+mjT5xwiLNfUeN36WcB0NBw4g9yvFPh5hoG9aMrTVkLZIP1sbTHILgm6 /Qfi7KukyFHHgsLWVhpx5DGCwB07LjD7yOepbxxPKPUH6YPS/HcvVceVYZMKxdrCYpNd2l/a/svM 3h2+mdWZwz/jNJ1Cc7DaTCJ9Jjphc1Lb7WcvcPh6p+pWB5xxSjzg98lJUnzItZuW/hdxVOZmUufo 8Egom3mi8yaotv8AAXulBR+vZ8qGSU47ujzBjvg98M+S8ZwrLuJ4XBS4piHopxLKblw4v2BK+Q8Q 304sjO6fYnimVYRBiFLG6VjLCxAHAK7q63eGLC+sHUfCMYq8wnDI6GznUkTrSPcDcWN9l9Z15kq8 odC8TZhmqolp6Ux6ju4i1rleuEI3CMX32fNeoyXNyVJdGmvwueEHGvEP1X/g7opKfBKGQ/xCqsQG AHdoPutqObfDP0R6FdInxYhluiko6KLT504Hmyut78ldc/TIroxDnHDjC1tQ2pErp7bvvuQvmvqW ZhxH/VFBhf6l4w+On80Qh1g53ykdIsmp8aPZLUS8HkZ0j4UfBnh3XnrBiGbxStocjUVUTDSkX12O zVsdxTo70ho3QZbq8uYSJ5o7MiMbQ8ji/uvi/p9YfHTeHPDpoWNjlqZHudYf1X7oOpvRXEsS614J mp+NtDhIGNptZDrDta65QxLySxt0kdXkfjUu7Oks0/TCwKr60UmIx1chyVUuD34fGN43De1/Yr0l nnBOnHhv6XxVUeUaGXDaEBgYIGOeR3JJG5X33UfG8RwGmwalw0tbPUStjc53t3XzvXPBsn5nyfBg 2e8QbQ0E7m3cX6NR7i6xCpyTkeXUyljjKKfNGDlXK/TLrdkmLFqHAqSTDq6K20IYW3G42WtjqDl/ KvhS8Y0MrqKKswjaQxyC4jB+FtJ6U4NlPAMmQYLkmpilw6Bto3RP1gfutPXjwlrqnxEY+3ENTp4n hg1e117ceFZt8OkcIZZx22//AI6NteA0PTrxE9MXNooqSuw+uis4NaNURI/wtP3jH8ME/QjqDW0s JLsNmBlp3220nsvdn0mxNJ09zFNO9zo2TtZFZxLQByF199Vx/mYzgMTIxeSPc97ryaaNylA92fI8 ajPpnOfS78JWFYRlmDqVjdMypxKpJFI2Zt9A9919b4//ABC5dyxX4fk2CnjnxmCaOomAAAaw2/8A C768FE0U3hzymIiP5dPpeALWIWrjx8T1FZ4hsyzPcSWy+XETyWj2WdNp1mlJfhc2olGEX+m2jorn DAeq/SClfgj4HxupBTSwgAiN2m24XXXhx8JVN0Nz3j2Pz1DK+rxJ73MeBtGCb2XnD6VlTm2ubXTx McMuA+XPI82aXDi3ytiuaIK6TLuIDCSG4iIiYXO/3LirxNwO2x5oqS7R0BnPxGfpeumE5CwSKCKq Mw/UzloOpvcBdxdT89T5IwOSrpMPdiFRpu2OP3Wt7Ic2IUnirpcUxmOSOuirvKlEnIdex5WynP8A njBOnuWnYxjxazD7hrnOF7XXbPGClFQOGnyTnGSlwdYdO/EnhmaMNrYswyx5exWN1mQ1O2r2t7ru XC4IscwCE1TY6mKeO5Bb6XA/C1weITNWF9Yes2WTk6B36DzmCaeFpDX7/wBl7vzzmWu6c9MIq7Dq b9RJRUrSWD4aAtZse1RrtkwZE5SlPpFdOujeE9Ocw43iWGQthOIP1FrWgWXi76peOTZexvJdTT7z xvMgcNtJBXsPoJ1touseWf1bXMZiVO4sqIGH7SvE/wBWRjzVZeqSf5bInCx97reli/K1L8MZ3B41 t9s7c8DHitxHrCz/AE1i0Oqsp4rtm92j3XxX1JOiGA0+CRZ1poI4K8u8qZrQBrPuutfpLYTVVue8 y4lJFIyCnpWsbIW+l5PIBXof6lwDujdHG3eZ9WLNB7d1cTTz7SZLhjuJp/xRji5wlFmctXz1TJJZ sUY2kdYO/wAL6zNwbCZbm7WiwIXA09MQzDzLGQx72kH8leLWwjDJJRP0Ojm54lZte+m34UMFyfk6 HOuMUkNbidQNcMkjQ7R8helcx+JjAcvdRqfJ8lJLLVSvDGvYPSEPhHZHF4f8rxt3aacOK+XqOtPT +XrZLlaqy4BmGF1mVz4hufytabGppvbZ8rWajxyqz4fxkdHqamxbAeo+Cu/QYrTTsMxYLeY245sv SWGVlRnPpfT1FO58VXU0NmOBsdZbz/ddf+LWmfiHR+oki4iewgjtuvpsp1OI4J0Rw6SmYHV0dC17 GuFhfTcL0bfrGXuzxvJH7R9UM6H5UxbJWSZaXH6uSet8973STuv6b7b/AIWrrxrZtosd8T09Rhsj HCgc10c0brWe0+4+U3xDeODq1X4jieXZqpuDwRPdG51M3S5w4Xk2kx+txXMtP+omkq62rnawvddz iS5evLF6aE8mXuSMaZeZxjj6Rv46UY7X4v0HwbE6l/8AxsuGh+o++nZeNvCtDT474nswV2NgVeJH zJKYyi+kg9r917T6X4Z+k6MZdonjSRhjA5v/AOAvC3hyxenw3xcYpFXPFExlTLAwybanXNgPyuWg ajgyV7R018m8sInfP1As+4zk7pfTQ4PWS0UtXJokliJuR3C8OdF/qG4/0PgnwnEaKTMOGFxs0k6m +53XuPx95LxXMvS5+IUETqmOhcXugjF38bEDuvG/Qf6d2J9ZclnM2M4rJgMxcTHSPj3dv39gumPx LEr7PJFv5D3vj0ec/EX1tf1xzNLjUVH+iikN/JcNwukXSSuBkAJDSu5vEx0sk6J53fgoqW1fl+ku Yunp5jExxa3Zw3Xj1V/+x+h0rXOw9u/TO8JuXesuM12bM1Rmtp8NkHk039D3fK2lT9J8k4VIyKny bQSi1gGU7bNC8YfSAr2/6KzDRte03lEhb3C7x8VvVjPmV6qnw3J0EtPUSn+XM2IuLz7L52kxyyya RNZljijukz63qt4W8jZ4yvUh+EwYbO1nmNlY0AMI33+Fg9AunXTrM+RmNZlTC5jh8hpX1DqdjjIW 7Eh3K6AzhR+JGs6V1OKYzjcYonQ/zaGmaBUEH37rvzwWYJW4N0Vo4K+mmgfM9z3ea0hxv3K98obY bWfLx5YyyJx6PtanBenNVjByczCsPZM6PUYooWjT8XXVQyv036c9b6LKT8tUNXHicPmtqqhrXmJ/ +3heZPGpmPO3QnrDJmPAKpzIqlofCXOJ39l854R8dz94kOtWGZjxMOnbQSj9XO8HQ0fCuXCsaTvh msepeW0lzZstxfCcn5Mw5tXNheHUcDiGhxgaB8dl81nXolkbq9l60mGYbJrIc2qijbqH7hcT4t8l Ylm3pTWjCZ5I6miZ5wjiNjJYcLWT0Y6q5twfrtlvC67MWIUWG/qQ2elmkIYRfuvXhwOWHyxlTR58 uZR1HjkjazgeScr9CsiT/wANwuBlPSx+Y8iMXeQObr5Lot1wwrxA1+L0DsBpxRUl43Oe0OB7d12H 1DoZ8zdNMRgwsCpmqKUiINN9Vwuk/BV0sxbpthOYJcZopKGrqZydMjbXF+V59kZY3Nv7WbeSUckY f+pyuRYsH6b9eMVy5Q0tPBQVsfmshbGLsfzsu2eoXULCOmtNRVGICGmgqJAxzzZth/5XU9Dk/EMz ddocwwQF9FSEskqWusL+yPxudPX526R1dbTaxiWG/wA2ANvY+9wtyipZYxk/RryOGKUoo+l6ztyh mvpnW1tQ6mqaWWElkrSCTstGnUrDMOw/OeLtoL/pRK7SDwvrc1dRs/Yfqwl2Zql1MASaTzDpj9xZ dUYjis2IvcJZNcjnep3clZ1qhhxeO7Z30Slll5PRxtW4vqKeEtuHuAt8XW+bwNZIw7KHh9y7JS08 Uc1VD5skjGgOPwStFHlwMxihdNII2sc0ucd7C63oeDPqPl/MHR/CcNo8VpnT08IYY3SAHj2uvi4e 6Z9rO0sfHZ8dj3iezIfEZR5PheylwWGYMncWi8lzxdd1deMTgwPJf8dbGDUUkjHQyN5BJXWVV4Uf 1HWqXNZro5MMld5x9R1h/Nh2XK+KzPGCZbyRhuCVNbGJ6mpjj8ovGoNvyV93Zj3x2H5VTyNSUzsP MGbsSpujkmP0rmur/wBH54cG7Da647oBn6v6lZDZimIgOku6Nzhw4hcj+owxnSOaJlTTVNM3DtNm SAg+nhfHeGPFMEwvpp+mZi9Ix5mkc6F0zQY9+LXWfqoSSXNndpuSb/DXv9RWmgbnqpiNNHC4OLho AFwvDcsQNPLFe5FzsvdP1GZ6esz/AC1cVRFNBp0h7HXvZeHJKZ/lPnY3dzdOldf8k4LDFrtnp/xe 7yNSNi30ko3x4nXvB/lPiII+QvRX1JqMHouasD+ZFIR+QRstZ3g68WFd4bs5QmspfPwmZ2ma2xDS Vtqd1b6OeJ3I8dJVY/Qy0s7Q51NPM1r2H918f/H3jnyrR6P8jjc7r/o0x5b8OWfOpRmq8AwCevhj aXulsdIH5W2L6bGW5cmdIZ8FxE+Vi7KgmaA8hff4jm3pV0U6czYRh+NYbhtO6LQx0MrS4m3JtyuI 8Pmful2XqGpq6TPmH11ZVkvkZLO1pb+y+rqF5LlFUj5+Gc1tjM668bXi+zF0gzFJlTBKB0QfAHnE D3uOAvhvpwZ4xDqf1HzLi+JSSTSwRDd7r8nlH9RHHcm5uyy2uw/E6KrxSBp0vgkBc4fsvL/gI8Xe B9Ac611JmCFww/EjodUD/wBs37rWXJGOGMIdvs5xxTyZXN9Jnsf6gpcMxZfqXsLo2jSCOdyvUPSW KSTovgYcwueaNoa3udtl0VnbxBeHXq1VUM+ZMfgbNSnXE2V5AJ/blY/Vvx6dOOn/AE/MWSsepMQr qcBsMEZvpaPhdZ5fLhx4oLlHGCcMs5T5s9HZlrq3BOmuJVkZfTVMEDng29TbBedvBd1ozX1IzJmW nzBiz8Wo4pHCnEkeny7HhfKdOPqh9L844CMNzkZsNq3M0zPey8Ut19Pg/jQ8PPT+mqqrLtfTxvlu XR08WkvPPdaxcY8mOULk+n+DNFucHF0kfK/U3o6OoyRTu8iP9YNhJbfdeX/D/wDTSqOtWUIszuzD /ChIbtiiNy7/AOFx3jI8YEPW+Z1NgrdFEw3bqNiQviOg31As29DcrS4BDRNxCnuSyVziHMWNTOMc cMftHo0sJuUmumfR+JfwkVvQLAZKh9ZNXxs9Lnyer/K8aSO86mqDIACD6V6a6x+NnFOtODTUeK05 ZE83Lb3Xl+tqDVPLo26YSdl5NQ47Ukz6mkhKEnaENqGujiisC4OG63pfTnzXhtb0Rw3Dqariknhj AdG1+4NvZaNaikjFJG6IWeTuV2j0E8SmbvD3maLEMGqXVFKHXkpHn0PC+Vtual+Huyxbi0jcR1Iy z1OzT1Rbh2HzyR4Ux4lbJrtG1t+/yu98UxKhwfCsOwvE6qM1TmNZpLrayB7LwTln6xeW6jCwMUyt U0+JBti9jgWkry/1z8cuY+o2eXY7hFdLRQxj/h4WkgMtxsv0KyeVRc6SifmZYJY9ySds20+IuHFo OjOJQYHHOKt0dh+mF3j8WXxnggy1jOA9OaiXGmVEVTPLq/4ppDj/AHXh7p39XnHcuZYgocdwNmMY hA0M83VYPt3JXI419YbHKqgfBQ5YpqKR9wHh19K8nmqLxfvs9CwSUt7XR2J40c04TgHXLDqiZ7Yq Zj2OntYC4K9lRVGFdaejlP8AwavY6kqaVrWyMNy0hvC0R9Y+tmNdW8cqMZxKsMksxJDL7NX1nh68 cuf/AA9xy0eHzNxLCXm5o6kkgfj2Xpz54pwSf8TGLTZJKTrs9X5cif4YPEfS4jmdhNDNKWRVJ2bY n3Xu7qzlys61ZIo3ZWr2RNqW7zB22g97hacPEV40q/xF4dTRYphUeGz0+7HQG+/Yrlejf1Hep/R/ BKfB6Z0GJYfANLGVIJLQuT1KeVSXZqOintcaNv8AkLL9B4cels0OOYiZ6aC8ksrjub82X1+R844F 1Cym+ty5Wxzw1LHAAv8AU08bjstK/Vn6hGe+sNE+ir5GUVJI2zoor2K6y6feJ3PfS7EBUYFjE7Yw b+VrOn+y55HGtzfJYYssZba4Nq2C+GvNVP1kgxaspnMw2GpM4lZLfVuu0PF1nKjwDpVi8Uz2B8sX lNiebFxPstXsf1OesssPltxJjGAWuWXXWPU3xQZ66vFhzFjEs5ZwGmwC9WPUrLNTycUjzT02SKcI rs9f+DHwl4rmzOdHn/F4/wBNRU0xqYWXBMm/svX/AIp/EFguRMkVuHOqGR1MsRYI77habcr+KTql 06hZBgubKqCmaC1sWq4A9t183nnrXmjqVWGpzBik1bV2sSTYLzyywWVzZ7I6Wcce39O4+n3iag6a 9Z6LMT43VFHHUXlYOS0ncrbvDnXJ3iW6XOdhOMUUra+AfynSDXE4jgr89tXK6a4DLG99a5bLXULN GU7twfF63D79oJS3/C5fKc8imej4KWPaja90Q8KWF9P+sIxnNVfRvfRyl1NqkDmu32Xf/iH8SD+n tJFT4DUU08sz2xg6hsPdaQh13z8+cPdmKufK3e7pif8AukZg6zZpzQxrcSxSeV0Y2cXbrrPLGWXe zjHSZMcdkTejhdFD1Q6bRtzJi9OJaiPXcyizCR8rmug+Q8udJcFrcPpsxUNeamQyHTKy4v25WgqH qxmxkQhbmfEGwgWDDUPAA/uqHUbNGGfzabMeINc43JZUuP8A5XfJqFkhsUqX4c46GUZ7pO2b/Mwd LOntdmU45iE9BC8D1tEzQ1x9zuudwTNOQMIfpocawqPQNItMwW/yvz3T9T814hh7hU5kr54+7H1D t/8AK4MZpxsnXHi1W03v6ah3/wArzyyJqpSOsdFK74NwPi7zNkrEM5YTWz5kpoQyVusxygggfhdw yddunuJZAgoMPzfhssopw0RmVt727rQrV49iOI3/AFlbNUf9UshKRSYpLFNpFTMwdy15F16FrYVG NdHN/wCOk23uNoGXKnopXdXJcYztmSnnrIX3ZTtkBhYRwV3z1H8a2QsEy+2gy7ikWJuazRH5VrAA bLSDX1UpnJc7Xq/qJ3WVR43W0sV4pnntYOXmnq3PP5H0dPgNY9sT0V4kuvNRn3E5KcSEtLr8rzZN NI+actIA73Wa6sBJmqSX1HIaVxpPnve8+nUbkLnqdVLO+ej2aPSLTLjs9N+ALrRlDov1Oq8UzdUv o6WSENilYL2dfutivVXxq9IM2ZKlpabMkVc2SPZhC0omj81w8oAi25Jsqa2enf6Qbd7brz6aaw5N 56c+Hyxo279HvHj0ayHhf8ONRJRzOuHyNYbO/ddi4X4/uh2AVstRDX6537l7Gb7rSQ+cuI/lhw73 G6TLO5rwBcD2uvfPVRm3/Z89aKq/o3L9U/qA9Hs1YPUw0sz5qp7C0O0rWV4g824ZmXGHz0J1RSv8 yw5sunW1s1Oef7q6pz5oGzOkLnE8LUtbtx+KHRYaL/asjfR778HHjX6W9B8BgoK3CKumrHtAmnYw uDnDvsvRWffqQ9Lc60AggYaiRrSGiQWsSPlac4mOksAAT8onCSLYt0n3BXzMeR45b12evJp1k4PZ GU/GRiXSnqZW4xh1U6XDZpdYgvcAX4XrDLH1UMn4jC2SqwiKGrcLPe0WJWomnZJVyaWn+6z3YdPh /wDM0F7fgr2/KUpW0eZ6KO3abKer/jzwbNDC+B4ipzv5TDcleI+sXUmq6rY3+pc/yaGIHS1dbvmY aO4afMI4O6woI56m7XyFjD2XfNrrhsic8Gg2T3tj/wBS5lRDNSOc2ogcHNe3bcL2d0b+p/nPp1g1 HhGMYTT4nT0rRGyXcPIHuvGDWR0u257EhZdLT075mP1nUPcr417pbz68salGjZPN9XeGtpdDMuSU 05G/lOsbr4x/1VMUocSM7cA/UC+xlfuF4SxGiFRMHQFrXd9XCKpwZjaQSvkaXgX9JXuhqXBdHhlo YSZ73q/q0YvijDFJhLIYyOAeF576u+LTEc/YmzEYKdkE8btcb7cFedBF+qcQwaLe45Q1TJvS0GwH cL0LXNY3CPFmH/j8akpHq/J/1MeqmVKWKl/VR1EMYDWhzbAAJmdvqK5yz3RvhxGGNzntIcW97ryI 4nTZ/qPvZLjjc93Gy8WLUSwtuLO09JjyVuR97h/WfM+Xs0vxzBcRkw6re/X/ACzt/ld44b9R3rHh eHtppMTjljtbW5m5/deXJWxS2uLEJL6dwOxuFzeaTe5nRabFVNHozFvHj1LxucSz4mXSA+m17BZN L4/OqkZaz+MPsNrBeaA2SP7f8q2B7XE8Er0Q1c4pI5PRYbvbyekMZ8Z2acyMtilQZ3jgk8Lp/OGe 5s3VRnnBaCd/kr5JsAbc6rn3QSlxaGncArrl1080drJDQ4sctyRm1cAkaNNmC17e6wwx7IvMa7S4 HYt2KY0mSMAko42FribX+F8x8n0VFej7TKXXTPeVIG0+GZpraWJgs1jpiQPgXXM4n18z7iFPqrMw 1FRG7kGQm/8AlddirpWMDX0oc4d0uXyJRdjS34K6wyyx/wAThPBCf8kfV1Ge8bkYKiCsmBd9xY8g 3WH/AK0x8SeZFX1QlPOqUm/+V89FUS0ezd2HslOnllk1G4PwvR8vI+2cY6THHpH1jep+Zg4wyYvP Fba2srhMYzNW4pIBNUSTy/7nuuuNk1PPqZqJ7lIdTPBCxLUZJeza0+NO6CDZHykk2PcoHXifZrjf 3CyY4iG791ToQDcN3Xmbvk9FBw4tXUFnQ1c0R/6XkLJdmTF6hoY+une0+7ysVxMgAcwbIHMcR6dv wtrJJdMw4RbtoyG4xVskv+skDh7uKy6nH6l8I11bpTa1i5cQI36dxcKCmvuAu3ycm3aYeGD9FCpH mFz2B9zf2WZHPoBc0PYCNgHLGFPvwnAv02AXKOWcembeNNUw2mSsBe55AHZ3KN7YNAa1jtQ5IPKx WwPc8lzyPgJwhdYWdv8AKjySk7YWOKHRuggIuXg+xWLWVT5XbR6APbdZLwXABwBI7qnNJ97rp58m 3bZfHG7owo5WlwErRb8IqgxmRroSdI5F1kOpwRuLlLNOP9tvlcdzRdqAc1k8l7kNA4VxBzAQJTpO 2lT9OWm91DHZRvmzSSS4FCndqNzb5WU0XjDQBcck90DWkEbpxIbYqGkYroHRSemxulSNka7UNvws xw1G90twN7X2Qj5ET1s8zAyRxcB8KzU6orE6SOwVuiv+Up8JA43VszVBtkdEA5rgb9imTzmaNttj 3AWOIiedlkRwENV3OqsbV+GKNTXXsi8xx7LKbFbkbofIHssWXk22nBamgxEvMbhGDyQvh/EVgwqO l1XOBct9X4Xop7Y6mAtka121l0/4gaPyek+YCWgsbHYBfx/BL/Yj+k5Eqo1yxxFtcDezeFzUAAK4 Y6jUUzHXvcuXKRP1VVh/Zf0TDzFH5LN9ZsPEdXlWXztQNLuV9HX3Dfwvn6q99xdevGeOf6J/WhgD Gi57lLe18bg9x9J4QuBab6bInOdMwB3C9KOBg1jPONiLhOw+MiRrbKpGEu2WfhrAyS7huqAKpoa4 gNslVFZrZGzgMPK5edjfL3buVxNXABdvYm6heghI3axG6Iy2FliO9LwOLK3OcT6d9koWML9YO17p MjS0XvZRkpbsQSrkvOLMFj8qkMKqlBaRfYIcNa5kD5Nflt97rHqoXl5FvzZZMOHurnU1KwkBzgCf hVPaD6HKGUcaz3iLaPCaWSpc421BpIXoCh+nb1WxDBXYjSxU4i06y0vs63wvSXgq6X4Vh+X6ap/T MMxAu8tuSV6n639Qm9HelGKYwxjjLFF/KDTZt7d17sGN5bPn6jOsXZrFyF9PrP2a8SnpameHD5mE tu8XJP5XyvUHwo576YZtpMAxkRytq3BtPO29nXNgvanhD8Wv+tMySQ4yxrZKomxd/TuvW3U3orh3 Vs4XiD3s/wCDc2SNzDuusMEXKpM8mTWSULia0qT6bOapcBgrxikhlks5zBuGXXOYN9K3N2LUoqTi jQ13cEbr3N4hepNP0T6Xy0EdS12KTt0RNJ9W3dZnhEz1iueemz6usu6oYDpN9rnj/svQ9PGEdx44 a6czxTD9JjHJqMvOPsD2cs73XBRfSvzTJUSxNxeKa17M12JXqjPmc+qnSXONVmWWOSsy8XkOhcy4 t+V2h0B610HWnH3ysozRVNOzU5gPK1LAox3ejtDWTk9rNYGPeBHNuSc60WBY3D5FNWkNjnJ1Ab8r sbqJ9Lusy9kGqxyixRk8sDNeni4tdbUs8ZCwzO/k/qvLM8DtTHGxLVwXUrBW4Z0rxenvrbDRvtb3 tyuMIQlRmeryQf8ARqT8Lngpw/rlguJjEa8UdXQvLDqO9+Fw/iX+n9nPoFhhx3C6h2NYHy7yAS6M e5HsuX6EdVMc6fdTKw0Urnw1FY5kkN/SRqW2XCo6bqJ0zviVOxzJ4bPiIuCCE8cbaPV8me3cfndh xeaaP9PKyxva55Cz5sIs2J7ZwJOQCuw/E9lHDshdd8doMMiEdGyUuDDwF19CDXPMzgWkDYLyZIeN 0z6ODIssbORpsNqcYroKKOLzpHkCzRe69z+G76d1Ln3CW4jmyKdtK9gcyFgsfyvifA10yw7NuZqe or4RNIxwNiL91tD6n4ziHSXIUE+XMKdWzWDCIm/YmKLmzy6rK8atGrjxXeASTorilLmHLn6p2VpX Bs4eLuiP/wAL0n4XPB30t6s5Hp6nFaIVFVosbEXOy9H9IccxfrtlDG8Lzpgb4aaVpj/4hnpcPdq6 z8M2Ds6WdZMayjTVLpqVkrvLaT9o9l7fFtbS7R8+Gpk0rMPMH0/ehOXMSjoqi9JU1LtMTC7e/wC6 8n+Mv6f9J0Oo6XNmWqt9Xh736ZKVzd2373WyfqF0lqMe6h4dmKTEIYaWkc1ximOx3XTfj/605Xy9 0tq8CmqYajF6tlqeKMhxHyu0Fuo4vUyi2vZ194HfDx016i9PGVeJ0FNW4g0fzontBI/Kf41vDL0h 6f5Clr4sBp6OukaWQGJoBLuy+f8ApdYvLHU4hTzSOL6mPXpJ2vdfd/UrjfVx5TpACYXTapB22Oyx hxqeTb6OubUTgrOnPBL4CMOzBhkWaM0U4loKiTVBTOGxHyvWdb0G6F1WLHLk+BYcMR06fLj0ghdg 9CmQx9DMCFIQwNpDcs7OstOnXbqrmzKPW/MldS4vPFUw1jhHI152Acqsdtv8OWXUyclE728ePgNy /kLAZc2ZFp5aJtNd1TCT6NPuFrvw9z4aaeVj9MwuCV3j1M8a3UPqJlk5fxDFTNRPbpkve7vyukaG llIBcBofsQF5clbuD6eFTS5MjD8Pn8yKZzzLI7cAL6jCun+bs1TOkwrBqiv7XjjJC+78P3TqDN+f 6TDq/wD+9ANTj8LdZ0S6K5VyFkaCbD8Lhlk8rVq0C7tlzUr4O83tVo0U1nRfqLh7S6oyviEcTdyW xGwWPguQcxYrXuw+iwKsqKy3/KMRuv0I4JFSZhw6U4hgtNRxB5bpmjbuF0/nnDsm9Nup2BYtTUdB JV4hKIBDCG3FzzYLu4xfC4PCtVKL5XBpuZ0C6il7o25PrYXHuYiuFxfpXmfKVfDS4phNVHU1B0sa Yjz2X6E8145l/KGHfxHEYaeJunVd8Y3+OF1/nihyF1FyJV4u6lwySeGIywT+nWx43CzjhfMlwblr IqVGkybw0dTfLil/0ZiU7Jd2PbGbW91yc3g96sDCXYgMsVMdO1uote31EfAW7Tw9Zmjzl08p/wBS I5padzoXHSLWHCxq3r9kalzvUZQrqiGGsj9IDrafx8KrGraSMz1W2n+mhzAul2bMZxw4RR4dPLiT Xaf0/lm7fyu4p/AL1sxOlinbgbpARqDRzZbjMm9P8gNzbV41glBSSV013SyRtDgCuo+vPisxfpJ1 KocApsKjlo5XtY97ja4J5AWtiukjhLWSStGprM/he6n5Oq6SDFMtVFO6V4jZJpOkn8rsKD6fnV6u wymr4sOAhmFxfn+y3A9RzTY10lmxyqpIpp4oBVQB7b6Hciyf0Ezu7PnTyjrpGAuYCx5HFx8KuMdm 5Lo3HUZG0maesd+nf1ZwjBpMRdQl0sbdQYxvIXnjMGH43ljEjh2YMOmoKth06Zha9lvewzxa5KqM 04xgWMYhBhb6GUw/8SQA/ey19/U7xbI+Zq2gxLL+J0FbWRm96K2/wbLEsTrqjWPWeSVR5PDnnEgt bHpI/qX0WUOn2JdRMYoMJw6mdPVVLw1pa29r91weGgV0LQNnuF917U+nPh9HUdU6SOaOOR8Vj6hu F5lBNWfW/wDWxmXvpOZzx7Do6ifGI6N7mg+W5cRnL6UPUrKmHTVmHYhTYkI7uMbHXNvhbNvFdnrE unPRjFMVweYUuINAbFJp4K+a8GfUnHeo/TYVOaK1lZiodpIHGk8bL1Qi1DfXB8fJqGsmxGurpZ9M jM3UvLVZXVGLCgrqUlpiI3J9rL7LAvpNZnroJG1OMxRPDbhjzYn8L3L0+xGtw3xJZiwFlS5uHeQK gRgekuPIWP1pz7jWTeuWU2UjX/pq4+Rs46HA8ghd3j++2P5Zj5TUN1+zUl4kfBZn7w+RnFK2mM2C g2/UsNx+66Ow6qcWh7Ru4b3W/Hxm5dpcw+H3MkVbGJgymMoaRcAgLQVQSR01dVxu2Y15aF5skE4b z1afUPJNxZ2D0synT5hz9hdPUnXBNIA4dlvp6K5Kwvp900w2nw2jZA1tKJH6BYk2vytD3SF7hmfC XseWgVLSCTvyt/nTarFd04wWS4eX0rAT77LxxtyPVqWlDg1tZ7+pBnLKfW/ERU0zG4JhtU6mbQNG 0jAbXJ912dT+OrCusOZ8ttwTCX0uOCoa1smrYtJ3C8U+LPpXi03ilx3A8LoKmSWrqDNDG1h9Wr2X 2nQzoLnzpL1Jy/ieZcBnoKCKdjnTSDaxN19nNjjSo+Fp4KUG3Lk209UcNzDjOQH0uAT+RjEjA4Sc WPskZAOMZYyFEc3VMEeIMbZ0j37E/KLqfnc4B0dxvMeHufrhoHSwuY27gdOxAWoCq8W/UfqLisGE 4vmOpq6R04AjcdJA1d1zw4ZZIOukZyz25dvfBuHqauqxHIGOTVc0chNNLpcy2kt0kheNfpqyNZnb PIvp1VEjmt4uNRXq/KuFTzdAqalp3OkqqjCzpJ7uLF438ClbJgfXXGcFdDJHM3zW1GppAa65Wo08 c4ob3HJG+D3DX5yjwfPFNh2JHQysP/CuO93ey6M8R/hrzV1X6mYRjuEYpJRw0ha5rY5SwAg8nfdd 75oy+MXzbhdQGxvFI65uLkfK81+Nrq/njprnPKcGVK/9LDUyD9Q3QSC2/eyxhtyW38OWoScGp/vo 7+z7VYllforjcuIy/qq2lw14fIwfcQyxK1IeEnqNguS+uMuL4pJFBTV1S90jpgCBv3W4Cmn/ANX9 KS6tcyd1XhzvP7hxLDdaT8rdFIuqnXfFcm0VR+ipv1bmtka/SWjV2XSDisUk+z04OMyfqjZn4mPE X0e/9JsVgZiODYrXTUxYyKPT5jSRstJM0sFbjuISR2hpJJHOja3i19ltE6ifSoyphmRJaygrsRdi kNMZJHyS6mOcB7ey1g4rgFRgWO4jgszR5tHK5lx7Ar5u6NcH2INOZyX8Nc0U4hOpnJK9tfTx/S0/ VCije0Bz7XJHdeIYDUuihdFIAy9juvVvgszbQ5f6sUAxCqZSRlzdL3Gwui5VHom0k7NrviHyvU5m 6fVkVHWPpJrANs6wK+f8MHTfMvTjJM9PmHExiUkzjJANWry2nsvqesOXa/qL01qKbLtboqpYw+GV jvuPZfE+GjLWfstUdVFnmrfKIvRF5p7L2x5wtXyj83kS86dH2WSsde3OmK0E9LJHPI7X5ljay+Ap PDh07wvxDuzzHXn/AFZJeQ0pl5J5Nl25gWP4RmDMlfHh0rKial9MsjCCPwvHfUjL+b8P8YuF1VE6 sZgz3td5rWEtdfkX9l1hFTk7dcHDJ9IpVfJ2l4+My1GG9F8SoIqWR0VUBqmb9oA7Ifp4ULYPD7S7 3fJI6/uF994qIMNquhGZf4u1pgipS8E9nALzf9Nnrnhdfl2oynNUsjlEhfTscbXF7KUpafhcnqx2 8rZ54+oXRfo/ExR0YleKZjI6nyybi62d9IMQgrOjeAVMZ0xuw5jSfnTYleRvqMeGbFM5xs6i4FJq rsNYGzwt5dGPb+y7l8FHWfLvUjpFhWAQTBmLYZB5FTRzH17d7LOVp4o0axNu0jC6V9DMAyN1PrM4 YfmoVWKV0rvNpHyAggngC67s6g4vV4M/CX0kPmzTVAa94Fy0Lpmg8MGJ4D16bnCnxJ82DPkMhodd mxm9+F2hmjqnhmG9SMJyzJNTSGqbd2tw1MI4WZvdJNcnDGnGLT4OE8QTenUFHhVXnzC4q1rpGtik fHfSV91hkOHVOSSzL4iZQzUumnEYs0DTsun/ABmdFsa6vZIonYCZJKyhlDxSxOsZR/8AK+06FZYx TIPTSjpMee5k0EBc5khvo+CUW1Y075TJPc8j44ZpI6s0ldS9ZMwUtcC2ojq5GPbaxHqK3K+C2rbU dAMvU5l82Sni0uubkDstaGYumE/iD8XOOYTg1QyN09bqlmDtg3VutrnTfJWCdAOmzaWSfyKamh11 E0p5IG5V1Mt0lXs9OJJYkpejU59U/L0tL4gKmsI9NTCzTbbgLyZhGT8zZjoTU4VhVRVQw7OkZGSv SHjf64YZ1x6yyzYS0yUFCTDGf95BXvX6aHT2jo+kMs+JYVDNLUyF15YwSB+63q6cYr8R69FcYNv0 aaMV/imD1TaavhlpJBa8crNK5WgDJowT6RyFsm+rRkTKWBZVwvEaLCKShxaWXSJoWBrj/ZaxMNkq NLnud6A21vleGeNxSZ7MOZZbPp8IlbHKZHO4day2F/TarY29VRTtcBFJTFxAHey13YLTPqIYg8EN LwdXvutlX06en/kZwfjzq6KKIwlscbiLglS+D0tfRmwDqLjWBYBhrKvGoG1EZlaxjHNvckr4vrZk 7Ec64LhEmFVGnDmPY+WmbsHNSvE5hsmK5HgdBLAf0lQyaZ75Q2zR7LnMq58y7UZBppG4/QxPEIbe advpcBxYlenGnCMciPz+RbpSgkfSVdfQ5TynSvra1mHUkMLWmV5sBYLq3GfFx0xybTObUZop6+UX u2E6iPyvqMYdlvqzkOtwCqxajqTURGJ7opR6T7jddA5T8D/RvprT1EmYMcjr5pHOkc+tqWgAfi66 Qjj58tnJzk5LZ1R6Q6b9RMudQ8GbiWXNBpZjfUxgAcebrwr4w/Fx1F6Pdc5cFy9Vxx0MMTXuhcD6 rr0J0n8QXQ7J+Yp8l4DmCkp5aYlrXh1o3fgrD6g+HvpN1V6iPzfjmaKKpLg0GCSpja0gdtzdbxyx QyPcuDyZVknFOPdnVPh38eWbOpOaMNy7mbLD2fqngMrWs1MK9a9cuoeVuneVY67NZnbh+13U9wW/ 2XVPUbrR0X6BYTh7aB2DT1tI4GCOme1z2/JIX0T+q3R/xE5QZT4hmDDpY6iMGSkmnaCwntuuUtrk pVUT1/ZQcV2fB0H1EeimC4PLDhFdiNZ5LSdIgc5xd7XK8AdSOvH/AKweIh2dMPjfSCJ7RBDp0OFi LXWxbDMpeHjoTlysnYzL80Dg50jnujle74XgDMWf+mnU3xT4fNhEFNl3KUUrRLIAGtfY8r2LxJPY n/2Z0s8m65m3XKmI1WZukuH1Mp01dZhwvtw4st/3XirwbYiMoeInMuAVLPKq6h8rXXFjqvcL1lhv XjplgOVKMszbhcVDTxNY0fqG3IAtwtcPiw8QOVco+IDDs29MscikqhaStMbrte7uF5cCbUo1Vnsy puakev8A6h2H12K9OcLipoZJ4Yqpr5fLFyP2XcHh5qqur6PYHDWU76Xy4GsYX+kub2J9l566afUd 6U9QcsUzM4iPDq9rQKhs7Q+MuH9QXBeJD6iuQcs9Pv0fTfGmV+LPIbGImkCMfutr7Y1i29Ps8snN Tck+Pw9xag2hlBYJWtYTpduD8LxZVfUHo8Bz9iuWMI6aYhX4hSyuic6iZ91jzay+W8Pf1M8r/wAA iwvqK6amriLGtYzUxwPuu28B8Wfhtw3FJ8Uw/G8MpMRqN5ZBF63fkpCOPHKSyKzjPyuKcODxj45P Ftm3qlgtNh3+isQy1hMZLJ31zSC9y8MYcHUtTqduZLnT+V7f+oD408t9ZaVuUMn0sNTTwSFz8RbH YvPsPdeHYxJSPZKWmVzbagey4ahpxSjwfU0kZLlnpnwdZNwzOfVrDaXFAzyBICWPF7/st0VZQUPT fJzpcFwxjhTw6hHE217Bfn6yZ1GxHIuO02OYVIYqmBwPPK2RdIPqt5RqMpwUWcoXRYjDGGPIaT5m y8MHUuT16pt46R7a6XZ7OfMpy4rPH+nku5hhH3Cy618NMtdRZhzphlXA6Mur3Tsc9ti5pJXQsX1X ukmDzSU2H4JWRsBJL2RhrXH4C69x36puXMNzqcay5gNRJTytAnhk2Ll9LHFNT/s+NHe1FNcozPqH 9Oc250604Ocu4ZW1dO6nbG2enBs1/f8A7pnhy8MfXzJmYsKq8SxWT+BeYHS088m4bdfQ031funlR oOKZTrmTezGhxB/JXWvXH6r0uZKeKhyPRz4VTuP8yol+8D4svUs03jWOkq9nD47xzlL9/o90eKzI 2JZ66KYlg+HXdM2IPMbDcvsOLLXD038HXV7F6p9fgcU+EQfafMYYw6x3/K7Q6cfVzocKwSDD805d mrKmFml1ZG4fzfyEGcPrEiKmkZlrKAjJFmOqH3397BcU5YouFJ/2bWJynvd8nu3w35axzJXTPD8F x2I/rqcHXKXX1krzF4isd614r1sqcJyjLX4bh72BtPJBGSwn3uvKOT/qjdTMJzdPi2MStxHDqg3N E1npj/C7Lm+sTilPJeDJlPVPO3mSOIsP2XmUlCTk12d54Mk0l0kfY576d9Y8pU2F1mfc3OxWj8xj mUods11+69zR0tbjfRuOniZ51bV4eGNH/UW2C1mVPiuzr4zc8Zew2kwV1DRUtS0y0sBuSNQ3JW2H CqZ+G4BQUrY9L4qdrLdgQ2y3lyOoo7LCop2fA9C8t4vk/IlPhmMU7aZ9PrJOq9914v6e4/hWI+Or FohUQinjqnBr3Ha/YLgPGt44+oHTjOuJ5GwQso5o2WkqmjcNPt+y184ZnfNMWYX5kpMRljxAzee+ fV6nOvcrq92NSc/aPHiw+TaorhG97xJdDx11yg/CG1H6eRtnRS32BWtbxIeA2m6YZUkxSTEScUia X+zHr5rC/qgdTsDwqKh0xvmYwM86Yk3ttddQdYfFT1L6ywCLHMUd+icf+XGbCy1h1LhjeN9M6rSS 8++PZ1bQzn9HNKNnNdoeR7r0T4UM10OXuqeCVVZUingDgC88BefqGnENMYiLxu3JPusqKufQOYaV 72SsN2ubyF8ma3Pg/SY24qmfokx6B2fun7oMFxBrP1dMBHUxO427WXirLP068wY1m3EcRzRnfFqH DZJC4U9JUm79+b32H7Lwfk7xddXsiUUVPguP1EcDBYRyOLhZfSVH1EOu1fTS0kuYGRscNLvLYA5e vBlcIuKPi6jRyyZPIjY10U8K+FdJutP8UwfMFRjMEcBD46ufW9hPC7A8YPS/EuqnRvEsHwosixFz hI2R4uABytMuGeJvq5guNSYnQ5qq4a2QlznE7FfWYl43OuuN4dLR1ubXyxyN0utYOIXd5KyKafR5 paWUsbhJdh9OshZhf1so8oyVrZX0tQ0T6HkN0g7rd/lnA6XAso0tDG4NhbTNY5xOw9O+6/O9T5nz FSY5LjsOLz0mKyEl1Qx25P5X3s3i161x4R/DZM7Vb6BzdJY19iR+V5c+bfPjo98dMscEkuTunx4d EIOjHUr+OYfVRVGGYtKZh5cnqa4ncFe7vAr1oynjXRzC8FdjFLTYnS3bJBLKA43/ACtNWPZvzTnC ogkzHilRiMURvGJ5NVkFNVV+ETfqqCqmpnHvFIQu+bN5Yrno5YNG8UXfZvFxTwz4RmLrG7Os+Iw+ Uwh8VPAQCXe5IWb1yxfLuOz4LgFVj9DSTiYOMc0rbC3vutJNP1h6h0kfl0+ecXpY+A1tS4be3K+c xnMuZMSrG1WI41W1kxNxM+Ykj5vdRZvspTfRw+HKmoLs/Q9JHQ1WSJcOGKUskc1OYBMJWhti22xu tKXjd6KYd0X6m0tJRYy+tGJ3nPlS303K6Wjz7nOm0tos14myMcMNS6w/yuPxGvxbHa6Oux/EZ8Tq IxZj5nFxb8KLOscZJO7O8dI3NSfoyabDW0r3eRd2+7nclcmxos3bhYNJPPUMc1jmN7gONim/qDGw CWVsDx3cV8uTcnbPtxSjFJGeasRt9TSFRnbO02Kwdc7/AOYyeCePuAd1kzV0Tqdt2NYSPuCxTRq0 FqGwb2V6rGy4xuKU5l8lszHyXtysl05hb67W90quyWmZfb4VlgAusRgklILPtPdZRpSxmrVqPNlA VI+7bpDxqsQjMgc4Rkc91iSgzh7GPLC0qMplGMaNQNz8K2MkIGlv91gxVUtG0xxxumkI7JMdfUNl LpQ+M+xWlFsWjlw5zX2f6Ufmtvs65XEz17pmh32gcpArRENbo5wP92gkK7X1RlzS7Z9A2QWQuu83 BsuJpcSZOSdZsOxFimy12/puQPZHFrsKafRykrQ0D1AflIe8skF3ej3WAa2olZrfRSuhb/UGEKzW NnaGU8Mj3dwBchVRb5JuRyD3tALg8aVUUrHB13cLDkw7FIoNcuGzuhP9XlkWWG2oLifLhfqH9Nim yUVyTev05J0rA/Z4PwrdMG2JRwZFzdXwNq6bLNfUwP8AteyndusDEsLx/AJNOLYFXYez/dPE5o/u QtqDl0jPmhdWZJqIzYmx/dEZmkcrFwLLWYM3yy/6dwapxkx7vbTtLi3+yDGcPxjLE/k45g9XhU/t UMLR/lPGze9Ga0hwJJsPdY8tUI2kg6h7hYkDpJ4y/VphPseVy+Tcj5hz7igw/LOFz4nOTa8TCWj8 lc9rN7qV+jDirRK37r/lRlY1hO6+qx7w/wDU/LeJNosSyxURTPNmtYy5d7cLCx3ojnvKlI2txrLO I4fSSC4nlicGLSxOT4OayxfRw7KqOZ/YOTWyymdrWjf37L6vI3hw6l9ScJfimXMuSYhRM/8AeZ2X 1uXvBx1nxrEWUjMo1cL3bCV40tW3gmu0YeognVnVFVGdemUAg+yxxPHA8sexwZ2K9JTfTp65sDpJ MFZI0f0iQF3+Fxg8B3WWWsFMMuS67232AKixORXljVnQgewElhJCU6qdI+3luLf9wGy7c6ueE7qj 0ZwaPEswYOf4Y+4NRT+oRn5XP9O/AX1M6kdPRm3B6xjaN4vHA8EOf+FrwSXJzWoxt1Z0G+qMDbtb rKjcQlnexj4XNY7uF2t0x8KmcepfUmtyRIW0OIUpIkc/Yi3dfW9b/AL1F6GYD/Gg52NYey5ndCwn yvk/Cx4pXRt5oo8/mA0btQc4tdxdN85xZdwsPlDTV8lRTikqGtbK11wT3TquUShzGssGDey5uLi6 Z0jJTVoUGkg2ssCWcB5cWH0pss7oYw+xAdsAuyegvhrzd4hMcfS4FGWMb98zxaNn5KqgSU1FXI63 bWxzAC5aR7o/4jHTscCbld99evAf1G6EYOcXq/KxfDRbXPSXOg973XZPhn+n1hniGyTDmBmZXUbo 3hk8IFyHe1lt42uWc4Z4ZG1H0eMosT0yHzHAtJ23ss39S2Rmprb/AIK2aUv0kMtwseMSzRLJGdmN aywuvO/ih+n3inh/wtmYcArX41gLnATyFu9P8n4Wo4XLpmXqYRltaPJn6p1zZzQewJsjMrHwgvfo ff8AK9u+D7wO5F8QOXKrEMfxKdlTG6xjpn2cR7hdida/peZFyjk2txjDc01OGQUrC4uqSCL9hdTx PdtZ0lmikpI1ufqvL+6VhZ2ud1HYpTO4dpd79l6c8K3gdqutmbKluITSuyzSvLTXsuGyW9l7Kqvp ZdLYWeVRV9T+oOzvOeD/AGCqw80zk9TFctGpj9Q14JMokb+E+jYKhjnMcduxXp3xh+AfFvDzgxzR gdf/ABTAw7+cy3qjXlTCq2Oena+IkOPIUnBwOuLLDJ0Z4bZ/ypI2Vh7Bh5KGpqo4iHO9OywXTS1T g5glLD3DbhcqbOzddnIyBsVgXWJF7e6Q+bSRc2WA4Plfrc8lzNrEEIJq5ksbgGvLW7FzBey6LG2j O9M5MVTbXveyv9QHbg7rgoTNNMI44pZSftGg3KdI+pieY5KOoieN9JaVNjI5pHLSTD/cNXsEptQb m+wHusSmdUVEmn9HIXjj0FZNZheKQRConwushpzxMYnBh/chXxyq6HkiDJWNf9r7WSTiMYfpuSfh SkwnEcXc1lHhs87n8NiYXOP7Bcs/pznGk3dlbEYm2uXOp3WH+FjY/wAMvLD9OOhqRJchGKpgNnAt A5JRUOW8w4tXGgosEqpa4f8AtNiOpc7R9JOpNXK2EZLxYknSLU7t/wC4V8bLvicK2XzB6TdqKJgA JBuvusY8OnVjLeDfr8QyTXQ0rmay4xG7R8gcLrOlq3w+aCNMjHWewjcFZ2sqnF8JmbIS0FILWN/m HtuUxszaxj42mxtcn2WdkHp1mzqriRw/LWGT15adJcxhIus1TNN1yzjHzxyjU2wPYDusSSvLAdUT wPey9CS/T265ugZMMsOLbXABF7fhfF5k8MfVLJ1fR0WIZfnp31cghifI0hpce1118Ta4OPmhdWdX xVweBpuPgp7Kprudv2Xf7/p7ddqmOOVmWWOieAQ8EC11k1n05Os1DhL6yowsRyMbqEDCSXLO13RZ ZYx7PP8ASvbU3s7cIJT5ZLpTdo5AQY7g2M5HxuXCMXoZ6LEInFro54y3dKZiIfUmKSP1WsCeFXBp 8mozUlaFymETCGCEyySmwFrld/8ASTwW9Teq1C2rwbBn09IR/wA+oBY0/i6+z+nd0KwrrF1bqH4z EJ6LDW+c+Ii+s34W0fxA9Y8F8MnTB2IRULGtZGY6OkhZpbqA724HCuKLnPajz586xRcvw1RZ1+nf 1nyzTurJsMiqoW//AESHH/C5nIn0z+rmecDZWSvpcIc77Y53WNvleyujf1H8h57yTUUubsQGFZiA fG6Et9LubFpXcHhP6yv6uYRi/ll1RQ4dUGOOpIsXg3IC75YNOmjwLU72tvs1y4p9Kfq9hkLnRz0G JOG9opbf97L57J300eq+as01WCV9NHgjYm6/1krrtI+Pcra5NnDNFL1TOHCnnfgs32SNZqDfnjZd oVAdDNG4Q+Y54sZAbWXScOEmVZptuvRoZ60+CDPXQ/NODYPi9QysjxabyaWaE3Djey7rr/pFZ1iy lHiseYIZaySMSOpAN2gi9rr0v9S/F5MOxvpl+lb/AMVDiTJA4bm1wvYv8Tqj07grYWiSodRNksdr +gXXTxRUYtezUtQ0mvw1V5D+kbnPF6eObFsZhoYpOQR6gPwvt8R+jdN+ifJR5wYatlyGlps4+yVj nj66u41m/GMhZVw2mlqDO6nhqWtLpYxe2y9ueGHLedcqZBMvUHFDV4nKPOc6Y7xg77rrkwSxq5Hm Ws3VFcml3xA+HrNHhux5mG5gDZYZf+VK0XDv3XW+E4VjmJxVFTQYRUVkEW0kjIyQxe2Pqbdbsu9U c+4TgmDvZUw4TOGVFQ21nG+4B9l7c8K2GdIsW6G4Uylo8KGqnaKzzdOsvtuSeV4suNxaPZp9Q5J2 aRm/qWvtWRvpTzpcLGy5R36V9Fdkmo27r0d9Q+gyXT9b6OiyW+B9LDBeb9NYxtd7XHK8wQQPlqnN Is0C+kd1wlHae7Hk8gJqZHU2hwuGmwC9WeEfwC5g66zsxnGQ7DsvG38+Rv3D/pXmbLlMzEcYoY52 6IjUtDwe4uF+hTpNh9LhHR3AYcKgjiiGHMMbIxYXLVzSue01ke2LZ5RzT9KrpVX4FJQ4RLVUOMtZ qbUl99Trdx7LybkT6eWP1XXhmUMzyOZhUfrFS0XD2Be/+lmXOplB1JrMZzJVy1FC+R0cdMDsyO5t su681Y9h+WcTwySaja+rrJBCyXRdwv8AK+o8ah9XzZ8GOpyTtrimeaaj6cnQPLeGxOxmgEThZoqZ p9ALl8H1U+lh06zBlqurso4lU0GIRwulia1wdG6wuB+69F+JfoNX9bsIpKRmY3YHR0zxKGsdp1O+ T7L63AsAqchdIaylqqwVlRR0DmfqGi+sNZsVyUUR5Mnk2ev00U9MPDxmXqp1SnyVhzJJp6Wr/TzS W2aAbEk+2y2x5X+n70qyB03kixvDabEKyGjc6oqZ7BuoDc3/AGXT/wBNulgxPq51DxWZmmodO8x6 +SNRuV2F9UfN2L4J0rwjC8JxKbDjiFVoqDE4jXGB9pt2Xpnp15VBFWpbx7v+jxB0V8I0XiU6yY1T ZbjZhOWcOqiJqq1xoBtZvyVsvy94QOi/TvLVPglRgGH1L57QmprCDNI74K6m+lrQRS5Ax3EIYmsD JxC53dx9yuzepXQHG829TocbOY3QQEh0NI+QgMIPYe6x408m18Udc05Y4JpWzzP4g/pqUEPULBsZ yc2RuB1lSGVmHMbcRgnkH2XrPLvhp6S9HMhSTVuWsOmpaODzaqprIWvJsNzuuz8Yq6/KmSTKxv8A EK+BgFwN3ni6wc04Fh+e+nElJmWQ0lBWU/8AxYc4NAaRuCSsO5UclOSu36s6sy90j6Cde8CdVYTl nDK2ilu3VTxeXYj/AOzwtdXVLpXlvws+LSnjNHHUZRkna50U9iWtPI/ZbOvDV0yyV03wCriyPiX8 Rwl8jrubJra119wCtYP1JKqtl68VkNWC1jHaow48henBjU5OL/DySnJwjK+W/RslpOmHSHr504kb hGE4dUU1VAWCeniGuFxbtv7rUv4sPDDi3huzX+jqKiOqoqyS9JLHyWk7A/IWwv6UrS7odiL5XOe+ StLmm/8ATbhdT/VZe1+d8nxll42QucXHgOB2XDHBSk4s9GTficZ+xn08PBLS1dFFn3N1OJGh16Sn ePuPOo37Luzxq9f8kdF8Pw/BYsFw3FcbryI204Y28LL8u9l2b4JcRfjXh3wCskFnvY5n7DZa0PqU 0YwbxA1NJDI43iE+pzrndXSwipu/R31U5ral2zaL0Wr8s9YOg9D/AAuGnNBWQGKeJjRpjktZwt8F fA+GfwrnoVmvMlQIaasw+umL4nStu9tz2uF0t9J3NeN1WV8awOWjl/g7SJ2VDr6dZ2IC2BV/mR0N VJE0mVsbtAG5JA2XKUtsnE1LFa3fh05jvXTAcA6z4VkSiip211S3VM5jR6fjZfY9W8+VPT7JdTi9 DhhxOrZYMhYOR3K17dHa3EcR8bzq7HGubVy1UkbY5eW2Ow+FsrzNmLCMsYcZ8Xngp6MD1OmItZdc kIwcUlZwwynLc2+Dr7KHiAybm7D6NsmKRYbic4aHUdTs5r+7ePddg5hyth+cMvVGFYpBHVUVTGWu Bb2I5C1ydSc2Ydn/AMWWXnZap2x4FHUMMssLfQ9wIuTZbEs45xpcmZPrMcn3pKSHzDp9lrPi2bWv ZrTyi7cj5rot0Xw7oxg9ZhmFMDIZpzIDtexWv76l/Uav6Y+IfJuPYO1v6uhpxM5wFifVx/hbE+k/ V3AusOWI8ZwKYyw3LXtP9LvZa2vq64UyDO2Wq5vqdUQeW5v7rnhjuk4v8N5aSioe2e6vDD4h8O8Q mQaWujBNa2Fv6qMjYOtvdeBPqd+HvB8gZjo844NCyip8XeWVEEYsPMHf91259I+lmGT80yy3EIma yE9iO6H6ubHT5LyvBGfU2oc949gummxVk8Z59Q5JKX4zVhI7yKpkFgA626rDsvVGaM14dgWHjVVV szYW39ybJ1bStiZHPck8/hc/kGsbh3UDLlfB6Zm1sNnjm+oLwaiKhkcV6Pv4ZOcEzcT4LvBfhXh/ wWHGcRjiqsfqYg4ykA+XcX2Xd1D1WyznXMmJ5UhmjrX0wLKqFzLix2svrsqVDqrKGEzSHU59JG9x /wDwQurunGa8gYh1Jx/DcCo4Icyai6scwDU4A8krpiittny9RJxmo/p0FXdGq/w4+JbB8Yyi7y8s 5gnPn0t/sceR+F6j6zUeP1+U3yZdkkZXRWcI4iQ5/wACy678Ur5aXE8m1rbtayvazXfjcL7nrfnX F8g9Ka3HcHhZNX00IlAe3UON9l2UUqkuzzSuEZK+DlsvE03TVsmYjJCXUzjVisfct23uStVnQLNc OD+Od1Jl57Y8HkrXB/lO9LwT8cr5Xrn9QXqd1MwSty3+qgw7DpbsmkpG6XvHt+F8B4LcQqG9fsv1 EYdUVBq2B1xclt916J/6ISU+2Yxp56cekbq/ELjEuC9FM2VcJ0ytontH7iy80/TCy3DB0+x7HPLZ +prKotLrb7G69LeIbBZcwdHcwUcQJe+kc63vsvPf028ViORMcwcemajqySw+ymOvjy/WdsjlHMo+ jrz6i/iCzX0nz3lekwOqfF5bP1Xlj7Xb8H+y+HoPqpyYx06rabGcKiZjPlujLWbiTa3C5T6ofTTH sfztl/GqGhnxGlmi/SRsp2lxZJfvbsuscA+lTjONdN4sx4li/wDCsUezzDSkcAi+69X0jiTaPm4Y qWWSbZ4gxPGn5hxrGsRLRBLXzulDONNzfZcZHBK6pipYf+ZM/RqPzsuZzzkx+UczYlgr6kVFTh0h a+Rp2NisSkv5tNUC2oEA/wB18nLzL7H6rFtUFtNovgw+nNkis6e0uZs9NONVtZ/NbG12ljG+y9V4 b4TukFDTPpIcnUU0bxpJfHq2/K5rwpnzfD/k4uaBqomO27rpbqp4ts74B1Vr8k5XyRLic8ZtDU6C Wn5XXTYXkbjA+RrM/iinJnF9S/BL0jytmrDMYxTDxBgtbOKdtJA37ZDxf4Xa9L4J+jeCQit/0tTT NjZfXKb2b+F5h6nZo63ZlxPC5szYQ+koqSobJHFELAOvfde2sd/jON9Eqr9JEBjNThpLGHs7Twty xSi1fszHJGalx0jqPPfg06Q5synU1uF5UpqaVkTnxvpo7F5Hx3Wd0G6BdMTkOmiOVsOrKiNxbK2o ha6RpvwbrXf/APdwdXel1dVYBT4jGTTTPjdTzMvoIPG69y/Tyrcczd0/x3NePmYV+J1hdpkBDfkt C9uo0r08am0zw4cssjUorg7zg6UdNXPmw6ny7hcEjm2fFHA1pt+y6yw3wIdI8IztLmFuBtqaiUl/ 6aY3jB9w1efvHHmnqB0A6hYfmfLFY9uHVgJdNITpY7/aQuzPBB17zf4haOorMy1VLFUUL7CGCwc5 vuVx8NY9+7gs8spz27eTtPqH1A6ddBqrDqCqy9SUn6shkYjpmAHf8boeq/TjIubMjNzjWYBTvNCz 9XFEyNrfNtuGu27rq3xn9J8y9UOpGTf4PQSVGH0coM8zeGm97L0fmjL9uk82DPabCg8s3F9w1RbN kNr+z7NQlkWWakvqlwYHS7DslZyylh+NYZgGH03mxgmJsLT5ZHI4WdhtTlXOf8Rw9tFh0zKZ5hlY 9jefxZfL+FvLdVl/pu6GpY6OR0rw3ULG1+bLW34xqfPXR/rHi8tJi+JUUFU79RFLC9zYyDv2Nl3w aXz5JwjLrkxm1GzHCbj/ACOb+pv0hy3kDG8LxLAMOp6F9U0mYQWAd+wXgyv8utgjkjG7ebL6rOXU nNnUEt/1Bi9Tien0tdUOJsvlHyPwuDyi3UZNvwvBqqT2vs+1oozS/o9OfTbyHh+ePEHhwr6VlRHS AzDzG6gCNwtvvXTqR/6NdN67MNPSxSClAtDawI+Fqg+lxmbCMr9dpX4rVspfPiMcRkcBdx4W03xK dMsQ6ydNZcAwqVgdMQ/zHH0kLw6eUPJ9ukXV73F7eyuh/UAdfel7cZxbDo2U1UC39PI24PysXohn +TE8Yx3KdVTQxz4POWQthZYNiubA/K5Xw+ZArelfTGiwHEREx9LfU9rtiF8D0EqMPxbrn1GrcPqm zQxzNj9LgQT3X05KEpTcel0fIjKUFjjLt9n2OZ+tb8s9XqLKH6TVHURa/NI4K6e+pJljCsT6AVGI 1VLH+rbI0Ry2s5pPyvtOpGXWu8ReV68SRySVDCzyi6xaB7ri/qFGld4dsXNXI1kcelzQTuXLthSj kg177Ep2p/10aOauFrGPY7dwdYL6ToJUy0vWnK7w6xbXR3+RqC+cxSZrXSSXu6QnS0dli4TilTlv G6HFqUn9RTPbID+DdfL11eaWw+5p3LwJP2fpOxCctyPUSAHV+gJAHyxfn+6r0OI1mesYpo4ZZa+S ukPlwsJeRqNrWW4Pwe+MDKniAyDh9FLWw02Y6WFsNTRzODS8gWuAeVzmG+FvIOX+qtTnx4omVDyX +XKWljb8nfZe3SZowxtS9nxtRjk8sWvRrW8C+CY5gnXbLEWLU9fE+aXeOrBBA/dbcusPUeDpbkyt x2opxNTUcZfJfsur6+hyNmjr/gWK4fW4aarDoXB4he0ajbbhfZeIWLAc1dLMxYNW4vS0jaqleA98 rdjbbZFBSnFG8kvHCUo9nhnL3jyzR15695Sy5hrjgmDGqD3eVs6YX4cvfPXjFY8G6N5oqZi1obRP Di73IstFeTc7w9EuuFHikcsdXFhtXYysOzmh3K3L5c8QvSHxDZBbSVOaKD9PWQhtTRz1DYnXI3Bu u2eCwzjXSJCLljb9tHVn0zNNTkDMOIRO/lTVjhf3Nyuhfqn0kUHUrA2epk1fStbdvexXtrINV0m6 AZVqqXCcxYXRYSHGUj9U0m/xY7rxTn3rZ0z8R3i0w/8AjWMQx5QwyExR1MxAY9/xdZ3bpua6PPi6 jCXaPa/gyzSzHPD9ltl3OkoKcU8hP/T891rg8S3TbFOtPilx7D8EppZaqqrAwhzftF9z+Fsxyh1F 6RdMspwUOFZmwakwu2sNZUN3v3NiupcW6u9C8H6tx54w7NmHHFZY/JnZE4aHDi9/dcMWeONvjs9e fHKSjT5R9j0l6TZB8GPScV1QyKmn8oPra4t1PkktuAvD3ij649U/FLNU4dkzAq+PKFM4t8mna7VU C/3OIXujqF1+6IZ4yk7Dsx5mwyow+YA+U6Xe/uLLi8gdfegGQcvjD8CzThdLE250uN3H87LvjlBR cmrkebPCcpqKfHs0f4jkTG2ZnpMBq6GWixKoqBB5M4IcLn2WxDBvpHVU+SaWsjzvUMq5qZsxgDi1 jHFt7Lzf4xusGB5l68/6pypLDUyYfP5kckIsx5B2Xe2UvrEYxT5ZhocVyfDU1ccIi1xOsHWFrkLy Z5PfwfVxc4+UeI+svTyu6QZ5qMCrak1s1O4s80m918k0uZA9x5te6+26o9Qn9Y8+4tmOrgbSmqcX RwDhi+Sqo2thjjG5cLOsuWWV0evTxqLOc6QiCm6l5WqppGxxmvjJc7geocr9DVRVT1mQY6vDJmSV P6EOp3sOoOdpFvzwvzhyRmMRiEmKaIhzHN5BXs/wk/UVxfo1Rty9m6STEsMZ/wAp0zjqYPYFeWEn HJfozq4uUeD3/wCF3G+pmZc7Zhqc/UppoYiYqUFtgWg7Fdx4bJheL54xCqp6hkldSDyp2A7s9tl4 xzX9WXJIwKq/g+EVDsUcwiN4sWgnvdeNcg+PfN+RereIZwZI6rp615/UUMhOh7br7PGS5dHw0nCG xc82e1vFJh+d39bsOxXLlHXOhiLQJIZCGHfe4XprMtbUT+H3FqvHItFW7DniRr9gHadj/dePaH6w OUMQijZX5PqI5hYu0uBA/Gy6o8R31LK7q3lWryvlXCzhGG1TdE1RI71kf+F6pZHkxxjSVezw4tN4 cspO2md0fTRzfhFLmrN2HVVXHBiVTJeCBzxdwBPHuvtfqH9EsbzlhWG5lwKnFQ2iuK0HkM/3Ad1q LwjqLjPT/NFLjOD18sNfC4PErHHkFe3cN+rJiOIdO34Nj2Fx1WJyQmB82nZwItc/K4Sz7M2+J9F4 ZSxbGj1Z9OfqPQVvT+uynPWxMxXDZi5lI5wD3MPcBfTV3RbP1X4laPN8+KyHKzNxSF1w0/hadcC6 3Y5076kjOGAVslPVvm8wFjrAtJuWkL15hv1f83UVFHDLgVLWSNYAZHggkrxR1GybcfZ28TcFGXFG x/qB1RyxlzPWDYDjFRFFW1ZBpi9w2K+L8V/S/F+p+RBBgsImrojqjY4XBWnTrR4o819Z8/Q5qxCV 1FU07g6njiftGRxZdz5N+q91RyzhkNDiFNRYwYWCNsssdnEDa5tyV6sU1Ha4vlHi1Gnnn3ccM2N+ DTp1mDpx0/qKTMcLYa98pdpv2Wv3x25cZ1M8UUeHZYliqK6skbDUGMghrhsSSsXNX1W+oOZ8Cnw+ jwynwuSZhY6ohuHAH2XlPDOsOZcu5yZminqTPiQmMxfIdRJK9k822U8ratr0TS6aWOEcTXRvF8KX QfC/C70abhk+I+fLMDW1dTKbBriLkD4C1yfUI8QeCdUM+RxYO7zG4aTEHg3a8juvgs//AFIepfUb KDsv1sUVFCYhEZYCQXD5XmKernrnPlleXvc7U5zjuSvmaXN41JyXo92fTPLJJ9I3H/TN6/5ezP0p hydNXxxY/SOcfJe4AuafZfN/UB8LAxuehzbhGp000vk1Lbdj3Wp7LWasZyLjEONYBiEtBWREESQv LT/hd7Yv48urmaMv/wAIrcaE9K5oHq+78rGPO8NuB0zad0kzb/4YciYV0R8PtFS0zonsggNTPIwi 7nWub/K4Pw+eLOl6358x/CY9FDSYe4sga8gOlINj+Vp9pfFh1Qw7BJ8IGZasYfOCHQB507r5bAOp +bsrV5rcMxCWmmeSTIx1iSVrHKEk/J2zlOOVOOzpdm7LqJ4cIc19aMLzjRvgDY3NNRAHhuoj+o/K 7C619LGdV8oNwGasbSUhA8wkarj2WjWm8S/VmnmE8edcRgIP/wBU7fC5DEfF51jxBghnzvWyR2tZ klrrg8m2fAjjdSVdm7Ppz0Wyh0zyrTYdS0NHKYN/1MjW6y73ui6x5mw2l6W5hLq+la/9K9oa6Vp3 twtFdV4jeqj22dnDFJAf6DO6y4qr60Z4xbDZqSvx2qmgm+9rpTcr6mGMMn3nLk4yw5Nu1R46NnX0 2MfoI2ZvNTXQtnkqS5rXP7X7L436pOMYXmnGsp5cp66JlW5wD36gQGk9/wC61n4RmzMWB1UkmEY3 WYU8/eYZXNv37K8ezTj2bq2KpxnGajE6mMaWyyyEuA/KZM0Y5d67O0NC1iUUb0/DbDkbo70Sws0t dhkbo6cPqaiKRuuR1t7rX74yfF7N1dzPVYNhbwcHpJCyP2O9rrxZTZrzHSgU0OOVopjsY/OdpA/u mzVMrw3yvS5xu6QnclcIaiMJPJ7LLSZJtQb4DzNVOeCwuuSdyUvDsQM2I4dC+X/hmvbeR2wbul1/ 8xw81wcfhAcNZJE0B4aw/cwL5uXJ5pOTPuYsfiior0byfC/1kyTQdIcKoZcxUEbqanAcDKAW7bry nm/rLkHK3jIpMcixpuI4NK60kwddjHX91rfijqsKkf8ApsSq4orf8tsjgD+d0M9c2eIMmYXScl19 /wC6648/ij9D5ubSLLO5Lg3r9UPEx0TxPJ7MNxzNVK2hqw1+mN4uADfss/APFv0afgtJS0OcaI0s MQjYHv8A6QLb3WhKKidPZut7m9hKb2XK0VOIWmORpI7Oa5d8WXHX+w55tJOS+h6Z8beO5VzH1Yrc RyvUw1NJK27nQ/aXe66z8MmZcmZZ6sU+JZ10vo4XB0TX8B1+V1i+GQP0CRxB4ub2WDiOGscwOfF5 ju7m8rP+S1ny3GPpI9H+O0nxk2/Zu+wz6h/RWPD4aR+NCndEwMDQy7bW+Fr58UXXnAcf6vzZo6eV PkQizw+Pa8o5d/deTaDCIP0/p1NJHdZlBE6KUwPs0EbEBc9LqvDBx9sxqNH5sikbN+iH1Rsrz5So 8J6k0r34jEwRy1UbA9kotyR7r6zPv1Lum+G5clhynHLNM5hDYxGGtBWpR+GaHSG2ok7bbIHy/oi1 xiv2ICsM1TtrgzLQWqs+06y9UKnqjm6rxirID6hxIad7L4mrp5GU0TI4/MuNz7Ia5kNSGTAWkHAW RDUOaWhxsOF01Obytfh7NNp/BGn2dq+F/wAVWYPDFm9mIUcRqcKlOmppwL6gvcx+rtlCqaySfLMl TMBdpsBpP7rWRPGYYCItMjXbm4uuPkgFg5sLb9wNl4oS8fRNRpvMqbNinUf6sjsdweehwHLLIHyN t5lQ69v2WPkT6u2MYJhkVHjOVqWfyhpD4CWkha9Z4jLCPLGh3soIpvKBfCxw7kcrr5b7PHj0Lxu0 z114p/G9QeJLAYIzl84fJSn+Wb33+SvivDf47c0eHKCoosMwamrKWd13teNzuvP9PVCmY4PjOk/0 n3WKyz53Tlm/sFrJmc0kd8WjULZsMxP6ueKYzgs9HJleGGaZhb5hOw/ZeKOofUPFM2ZndmCnk/TV Tn+YwxG2k3uvh6qX9WwNjOg97rKpY2wUxE0hsRs72Xp+ZWLxRRxX+Pi8nklyelunf1G+rHTvCIcN bOasRABn6n1tsvuav6rHVavo3N/S4dA4ggvjhsvHVKIqljR5+u3dyUJP09S6GzZGnjZeKOVxZ1ya KMuEeisuePTqzlitqaigx3+VUSGV0Tm7XK+zxD6mPUzGsJkoMQFJLTTN0vOkBxXlKen86BjWOETu 6wDhIfczSgDtpXo+U7uRzWiSVWfQZgzHLmrMNZiRcIjKOF8qyntK7TfZ17rKdFHTt0xOLrdyrhjd pdfkrw5pvJK2e/FjWNKKE1dMycBxbrJ2O/C5PK+a8z5Hl87BMYqqMNO3lSkWWG+Ixt59Pce6T+qG 7PLIHvZc02dXBS4Z2nSeMTrFh0YiGdMS8kbNY+Q2C+fzL1azZn1wqMbxyetm58x8hJBXyDzDURBp 5Qvp4iAwDSPhetamajtPC9DjlKz6yj6tZ6wekdSU2a8QFE4WMJndpI9lx1HnTMsEzpqbGqqNxJcQ 2Yi5XB/pW6R6zb2uiZCwGwaQfdcllmvZ0+LBvk5mtzfjWYXlmLVUtYG8GV2pcUyaVj3SN23+0qRy vgIBbse6yImCQ8LjPLKb5Pbjwwx8xOOxClFb6w3f2BWNSQYhhrg+Csngtx5UliucdSgH07FKfHvZ wWsWWWN/U1kxxn2Y9Xi2LV8RbUVlRVNtY+c9x2/uuObFPTN82GokiJ5ETyFyzmWJ3sPZK8pt7gWX s+TPJ2eL48Iu0IpsUqJdTXVlTIRuWSvJC4StiNRUFwaQSf6VzszCHEhu47rBlhd5l2iyjnYjiUeh NPALWkqHCw21JckXlklkrnt/KCSKUSbglZAidJGABpPus+RorwRZgvYZO244JCtjpY2AMafzdZ0c Lxs+xt3ThHpZbTv8KrPOPTNvCmqZxVRJWBmrWdPtdWIZJImlkpDiPU1ZUkfmmxaWgKpaR0zB5btG lcnNydtm44ow6Qinp9Gplg4nklAKBzJCQbt9lm07C1m+5909rLhNzfZ0UUujA8rS4A3IUio4mzam SuIPIWcYrbHdWYGjgLKZHE42eleJSWODh2BCCCGYzljyGi2xC5IxhvCW6IB+ousfhdlNnGUU+zjX wyxl4Ba435ISpKgGHQ5lnj2XLCMB17XRyU1PLYnZ/wABRsbEcJDEJI7ucR/03VinYDYOIKz6igaZ G6B+UBayOSx3Ky3yb2mM6jLhdp3+VP0Rte5H4We3SHbHdZMbtXYO+VLG04tlG7+u7h7o2UkcTt3P auVbESdwERpwewPwpuY2r0jiXslO0M5t7FZNNC7ywHuDnd02SBkZ2bz2CZFAWt1H9grvZNq/DGnp 3yenXYeyCKkbGDbd/us10LnOv2ViEtO26jbZ02mIadz7bbpcuHl/qLtJ9wuRA087/CksQeNhZRKg 0cKaWSAao5CXd7rGkp5CdR3PcLnHQ6Qlhgadxddd1nPacEYzfjdQyaWaS02XLyQa3EgWS/0weDci 6gowIKh8TS0NDgfdLfdztTW6Vn+QGgi26X5fvtZWyUY/qczSeFX6e2+4WWxodcA3RED2UKjBdE63 JP5WRTTmmbYN9V9yUwC6MNuEKIeHTT+YRuUfk6hx/ZNDAjALeFkCGx6ftJamjzNhe/yUY35RMdtu FfQFSNSzEHgbAHsnlw3N7qnObpuBuERDHfTGQWcd+1kPk6GW5TmzB97NLSOQUxjdW9kBxwYWv2uC mBrnfc4u/Kyyxt9xuqAaDYIBIj/2ktPwnwvqGX/nOc32KrQQ6/ZNFx22VAmQOHO6OK5aPZG5mscI /KFm2NgENIIQhzd7FRrAztYoz6TYb3S5HFoAAQoVTaVmkuI+QseOBzWi8rnD2JROYZWXFzZWGlrL BAAYbG4P7ovKBHJP5VOBZYE8prNkAn9Lcm3CW6n03CyyhIWeiUYppr7qgwrLItyEqTbbsqhQsMPd UWb/ACmarlXfdUgp0aB0eyygwOHNrJDgNSAW0aT8BZMQbKbjkJJAJITIbQg7XugHSMYAdgSkBm17 hLfJoJa4kOPCGMF97njshbMhzLN5NkobHcpjagOYWAbhKkgedxsUIOjaDurLASlMeYwAUbJNQKAh sNlBYqE7IDwT3QDQyw4QvLQdOwJVMcbbopGMeRc2cO6AAN3sEQjsbotmtsdyo02ugK035VhoChdZ WDcXuhrsgG6MAEoW83RtGoXCAB8V90vS4FZQs0WIukvvqKEomoAfKlw/ayBpu78KF2lx33KACQ8g JRbcbFEQ4uueERA02G6EFBtu900C7R3Sw3f2KY2/dAF8WVOFkR2OyEm5sgAIHKBzbblMsoR8XQC3 D0juja2zVbha3srH+EBYANlRtfurICrZAbqKCsbK22oEr4Dr61tV0xxaAG7nM3+UNNjr6ZrSJRp/ K4bPeMNxXLdfA91w+MgD9l/F4Jqao/pb+yNflWxoxcNG2htrp9DIf1BOkE3S8VhEWJ1wLiXRyG39 1j0+uM+YDuRwv6Rpv/Gj8jqf/Izk8SGo3Bsvn60OLg7uubkeHU2p27rcL5+Z73yEHYL242eGfIn1 ONjwpZxd8K2Ns43Vub3aV6kcBRYNVz2TqKXRKb7j/slOcLb7FVSv0PO1wVQco03vc39kmUAnYbrI poxM0knSR2SzT3de5BCwaMKWl1Pva6LyAwgnYrLLD2TGweYSSf2QlGCaUX1NF1jQF0sj26dNlzMd I5r9Z2b7Jj6NjjqYLEq2VI+dJa1zrtuRzdNwdkhqmStaRZ+11nVGHDcdz3VRQSNpyyNwBbul2WqN lXg3xhzcq0kZcC9zwOV3B466KXEvDpi0FKzXKyMPOne3utd/h58RD+nVbSx1bnGnY4BxvwLrZLlr q3kbrLlJ1FV4xSeRWQmOWKVwuLhfZ0cowXJ8DX43Lo1neFTA8SxXNtK2ha4Pa8NBB733W6PpvgtT g+V6SOtqC6bSCdRXirpD0dyt0P6mV0sGJ0k+G1Ehkp3NmBIuV974sfEJHlDL9L/AMw01PM0tvE14 cXj+69MI+VujzS5x1R8x4/umON4rilNmWlL58Pgj0OYzcN+V2B4BsVdJkqahJtodc3/CyenXXLJv U7pPT0+O4lTN86HTOah4Fjbtdcx0MxXpf03NbHQZ0w6QyOuIjM2zLr0ZeIbX6PFixOEmzqXxOeKL FoM44v0+jwgz05FmStF7k8LP8DuVcbyjmasr8coJqKOvYfJe8WDgu0swUvRx2bTmmvxnCaiq2cX+ e0j91lVfic6WMqoWwZpw14hIa1rJG2ajalFRijUVKLs6z649Z8d6SdYRI2aV1HcSNp3E6ZA4r0Vi 2YHZ66Q1ddHT+S+voHuETu12leE/Gv1pyTmfNeCT4fjNNU1ELml7oH3BZfglegMn+LHpoOmVPSx5 po454cPLRFJIAS7TxZcLi2v1HSOKUlya1cr4XU0vVCqoYGOfUMqz6W7knUtw3SaSah6ZU36+PyZR B6mu7WC1r+HrO/T2n6yYzmDGaqJ7pKtzozcaeb3XoHxI+PHJeRcizU+W8WbimMzsMbKeI3Ed/dRx Xkuz1/bxba5Nfvje0y9f8VqWEFlRJcALqISNZoibs53ZVmDMWIdQs0z4xikxlmmk188fCdTYfHBU GYyagB3Xh1M45J2j6uli4Y0n2e1fAhiFTQ49SmJptqAcB+Vsy66Z7lyN0hq8YhgFROyIOEbhfstP vhj68YX0ozCyqxZhdR33czkL2v1Q+oZ0lzL0rxLDKXEXVNfNTeW2B7ftcsYGlJJnj1ilJUkehPC/ 10m6t4QBNSx05ijFjG2wK+Bw3DTl3xdTyOvpqRcPttuvJ3hH8deTekOFz02Ph5bLM53mxM3A7Bd4 f/nHejv+pzi4glkqT9sjmi4X00475Nez5GzJGMTO+pdi+ccByzBiOBVlXTYe1tpTSuI0/JstUMuZ 8VzhXmpxjEqivmjHpdPIXEC/yti/iA+pJ04z7kLHMApcKkqqmsgMcckjbgXC1qwuibIx0Lra3lxB 5tdZnkUcSiu0ejTYXLJKU0bJfplUNUcefW6CIQzyx7EXXoD6iOXJ63p/hmLUsRfPRz+ogXOkheQf C/46cjdD8ApKDEMGmMkAAknibu4rsrrJ9VDp5mvKdXRYbgtVXSyNLWwzsFiSObrzYcjUr/D06vE5 cRR6j8Geb8PzT0XpKGCtjqKmnBjmja67mX9wvGnXjwP5yx/r86rpsMFTlOrqvOlqbbgE7heV+k/i /wAf6SZ+q8dwIOosOrHl01DfU2xPZewI/q/4XT4Q1kuAvrqu2/8ASF18m1uvZ4p6fI6l7K8RfgU6 ZZU6UYljNDRvo8UpKUPErXbF9u61l4ZFMJHQEjSx5sfwvUfiR+oBmDr7gsmA4dh4wWhnP8wMO7gv L7nDDqqmYHan29a82Ta3aPraVZP/AHO8PD1mT+F5vpnOdpJcGFy3d5FqJMT6QUkdFVNFU+l0tlab 6XW2X5/MOx9mDVTJIwdR3JbtuvS3S76iWculGFx0EcLcQpmCzWyAkhcofy5N54uS+p6arunfiOzd niuwU4jUw4KHl0dX5mlunsgy/wCGLqJlPqphEuM4m/Fo45RIzzXl2n3supcU+r1m2ronw0uXaaCU DaUmxuusaP6k3VAZrZjsjYqqRmzYXG7bL6HkbXJ8mOGXtG3Drj0+qupHSbFMJY/ysUdTEwysNtLw Oy0wUePZ2wfOs2WqjG6+A007oZIC92l5vZdrZi+rF1KxekfTswymo3PaWlzAV5jretmM4rnRuYqu FkuIGUTWaNiQe63CTjBxsz8aTyKdG7PwU5PxXKfSpwxRxdPUP8xmo72IXjz6h/TbFsmdSYs04G+S npKxuqeRoN2v+CunsP8AqedScCwqCkoqOnpmxRhl3nY9uF1l1R8afUjrHSClx2eGWhvs1reFyxz8 bcjvm00sjSNgn02c+xYtgGI0mIYqanEnyX0SPu4j912h4mPDRivV3POX8bwqWKKOicDOJP6rFadc odV8ydO8QbiWWcTloas76mGy7noPqHdb8Ko2RsxJsoAsXvF7rKm5S3Way6N7UkbfM8MgwHpgMMqt Ml6YU+kOtd1rLj/DtlGXJ+QHUs0gHmyOeGX+0FaVs1eLTq7nfEG1NbmCZoDrtjDrNBWSzxg9acKp P00OaZHMtZoYd7LXGzbZmOmm3dHef1NOi4yJnP8A1VhlQx9Nibv50cMhu13uQvCsNLNVyAySSSjs HuuF9PnLqXnnqJM45jxqpr9RvomdcD9lxNC8UwEJabnvZcs2a0kj26PSeJfYyoJmUrWx7Mk4uF6N 8HHVDDOmfVGnxPEpjHFJZt72A3XmirpnTObKBcsPC5KOqcGtMbjE8fK88WmqPoNPo3/ZiflPr904 lw8YlS1FNXQ+kslBLHHg2XA9Gel+XfD1g08FTmGKV5JcZamVrQAtHmD9RM54FE5uEZlq6Nn+xspA AWFjvUrOmY2+TiWZ8Qrmd/8AiHH/AMr1xktm1Pg+Jk08/JvSNuPS7rXk/HPFBmaZ+N07XlnlQEP9 LrfK+365Y9ljMmesqVDcy0FO7DKgSSNdILuF1o4o8TxTC60VVHik1JWDiVjiHfuVMQxLGsQrjWVm O1NRUn+szOv/AN1p50pKS/KMLRScNrN63ia6mZVqeh+PBuOUUrJ6YxgsmaTx7LQy7yajHsRbCdcQ kdod/uF9kzFMTx6SmfDJitZNTHcxvkcQf8ocNbGaISRtDJO9xyuE8v02I9um0/jnvZ9DgmJVeFSN fT3jfG4Frm9lsG8Gf1BYsv8A6fKOdpiylNmQVbzs38la5jWGCmLpXkOHssarkNTTtnbK5oPsuCp8 nryQ3qjfPmDqV0SxOvoc04ni+ENraX1RVmpuu357rr3P3jD6RZvzBR4J/qSnrcOLx5rxbQ0/BK0m /wAQlkjMb62aRlraXvNkuko4pHHVI+x/2uXqU0mnZ8yOlaZv1zH4ruiWD5ZFBW5qw2TDzD5Rg1gh zLWtZagutmYcm4L1iq8SyLVfrsGkn85jRwze9guiamFjBpbI9wG1pCpSiOns4SaJewtyu+PJ44tL 2b+Mlk3Nm3Xw8/UjyNS5MoMHza6WimgjEYmA9IA23XZGEeLjw3ZZr6vGsKxrD4MRmBkmdCw63n5+ VpJq56d7Q2e4cfcWBWIW0rWnyWlxHNjey5Lai5dMslUzaHn36omG0/VSkr8tUpmwGM+VU+cd5Gd3 ALu2r8eXh7zjh8FfjlTFLO1gc2Ooi1uabcBaTqSopJCGkEO93I3R0sJLjE5w923WXNPpGPhNJ2zb b1P+qf0uwnJuJ4RlahrJ658DooLRhsbTbbda1MA6xYzhucJc3Ukn6TEPPdOQzbV3suuWS0UswBbp cOA4LkqwRwsjdG4AHs1c3k2x2o7Q06XL7PUmOfU+6qYzluoweCeGOGSIwOcQC7Ta3K8rmsrsSrqn EKh5mqqpxdI89yU6GCiDbvF5DvdNEoe8sh9IA5XkpHpjBKW4Ojo5YKdkbr2O65VuLVWGS074ZXRT Rm7ZAbELDhnlipyHO1W7JMkrq5wcBYDbddUzu0mezugP1K8xdK8KbhOYoXYxQxWEcgN3Aey+n6xf VkxjNmAVGE5TwZuGvqGFjqx7iXtBHZeEaGkqZ53w09JLXG27GRlx/wALDxLCKzCQHy4VV0LHG+qW ItH+V6YzXdcnz8mBP2eiehPjozn0bzFLXyyPxOmqSTUMl9Rcffdei636xT6dw8vI0Na8f+/I/SW/ gBa7cOirKmUMoqV9VK8WDWNvdZb8m5plke12XK6/JIp3bf4UnlnklbRFpoRXZ6N8SH1Is19fMvPw GGhZgeGyC0sUTrmT8rz1076l4/0yxumxfBKl8NXAQ5rQ4gHe9l87imGVmBuH8RwmWmJOz5Iy1Jjc +dokga4vPDRyuksklFKjpDDBfxPaGZPqn53zLkOTL9RgcQqpGeXJUm57W4XnjInXvOHTnOpzVglU 6nrdet8cd2tfvcgrhKfo91Iq8KZiVPlivqKN7dTZWQlwt77L5ujpcRmxB1AaSVla12kwlp1X9rLn udUbWOC6PZeM/Vj6o4lgTqGkw+noKpzNLqpou78heZ6zrPn/AB3NIzJPjFYcUEvmiV0hvf2Hwuab 4ZerlTgwxGHJle+iczzGzeUdxzsuuThmOUla/D66nkpa0O0eTK0seD7WIVjKcE2jg8ONvk9S4d9T TrDl3C4qSnq4DPE0N8yrZr4+CsLMH1M+tuasIrMPmqqRsFSwskfBAGkA7bW4XXuDeDjrBm2hhrMP ylW10MzQ9j2sNiPdY2ZvCv1WyLSPnr8r1lNG372+USf+yw5U7EoY/Z8dkfrPmnp1mqXMOF174MWl eZHznkldnZ28eHWHPeWpMFxPG2yYfM0sc1jbOI/K6fy1krGs55hZglDQSPxF79Bic2xaeNwu0uqH gZ6pdLMFgxiowqatoXxiV5pmlxjFu6ksknJV2b8eNo6hwHEn4FXw4o+H9c5r9ckZ3vvuvfvSb6p2 DdNMhjCIMoyNrWM0s0j03+VrupqiUPdDZ0Tm7ODubr63p300zF1VzJFguAUprKmQ6bBl7LEm/wD2 PSoxcWkfY+IvxLZp8SuY3V2KkspY3Ew0zT6WBdT08c+HucamJxid7Bels0fTl61ZOoo8QGEMmpnC 7i2QHT+QvpaD6a3VrGclPzBDU0xcxmsUZddx+F2yOWRI4Y448apHmKlxTz4Y2Uw0gcL6nA+qWdMp QSUuFY1NSRSDcMfYj8L7LpB4QM79Ws51GW4Wiir6aQsmJNtFjuV3vP8ASL6gOrxCzMFNuLiSV1uF z5jwz0vJFQ7PKGJdVuo+KsdFV5wxKogd90clU7T/AGuvnqrNuZ/KDH45XFg7NmNl7nofpFZ8a9ra zMVGY7+pzD2WZi30eMyxRGWizdA9x/oIXoU3LizyPx3yeEsO6jZqwb1UGZK6nkcLG07h/wCVjY1n HNuNRH+JZhrqhrv6palztv7r2NmH6UHVDBKB1RS1NJjDm7iKF4DiP3XyfRb6d+bOruMYvhOJ4hHg VZhjy2WKYG4+Nl2eSU+LRyawwdUeRaaSpo6sSU1c5lSNxIwm/wDdZ8uYcfrJ/wDicaqf/tGZ1v8A uvR/XrwE5g8PeN4QMZxWCfBa+VsZq4ju25sdl39hv0joM5ZHpMawTN7XTVMIliZILtNx3IXkyX2z 0rxS9Gu2WmqJpPMnrnVB51OeSUMslbAxop6uaNnby5CF9r118PWcPDvmt+C5no5Y4iSY6uO5jkb7 gr4dlTTiBoheZCOx5WXOSR0WPE+UMc7EZIxHNiFU+L/Y95IS46MeZokcY+4feybFVicBwBsOy+z6 fdOMW6q5ko8Hw2jkmmmeGAtbe3yudyrs2sMe6PiKuNsBA/ikzndmmQ7LHip423M0msu/rvdbU8tf SFy9iOTGzYviE0GOywXb5bvS11trryrlPwtS9K/EHDk7qPQv/hrpxHTPsNE7DsHA/hevE5tcM5uU FKmeWgaJjdJl3TKZtJC7WfUey3cP+mn0JrcPFRUYPMyIxiQvjm02Fubr4bHPpidH854XPFlbGJqO Zt2tc0iSx/uCsKS/TjLJCL6NRLtNXbzHXZ7WWFUsooHn+XKT32Nl62ofDFgXRXxLQ5LzvU/xHC5Z AGzN2aATsStoFB4LOjc+DU7WZXo6mJ8bSJrXLhb/AMpK06bDzQatI0FwPpXWkpyA9n9Ltiqqp5J5 LsEgvsdLbhe5/EP4acoYv4lKfJORMJ/SMc4CYx/ay53XvTpl4LelXSXp9BHj+CYficsMXmVNZXRg 6Tbfn2XLJCUWkwssFHcjRL/EBTaWTxksPexCzX0NHVMY+NrXE73Dt1u4zB4QugfWzLdVNg2D0ji0 ENqcPdbS63wtQ3iV6I1Xh96oVmCDzDhz3F1K94tqb7KvE3GzMNRHI9tHwMuG0kZa0g3I2vuqNDVU szf5cZhPBabLGqKapromaToe0737rkqLBMTxGenpaKOasqHEaY4m6iSom49Hs2x7oVPRt1tBA1dt QumudBFF5c0TdQ/qaF9nUdD+pFTCyT/RmJSAi4eyBy+cr8o5owCU0+JZdr6V5NrzQOAv7XIWrlMx uxrls4OYtl20Wj7DlHSyRNdokibpH9Vl91hnSTPeJ0QmgyhXT054lbCf/COq6I9QsPp3T1OVK+CI b+qF3H7hKl0hux1Z8Wysi1ujiIAHchMjYGTaiGPDvbay+twTo7nPNXmRYblPEayZn3eVTk6fyuZw fwtdVcVrv0sOTsThl7PliLWD+6xtkdFlg+LMLpl1gzN0gx5mLZak8iqbve1wQvQkP1Yer9JSinno 6CZzBYP8sBx/K83Zx6P9QOnNd+jx7CKigkcbMcYjZ34X22RPBL1b6mYb/EcHy/OY3btfMNGv8XWu U02ZyuE1TPi+rHWfMHWzOE2Yscpo4a+p2kczuF8U6kkbUelxaw76brvTMHgS655bpjLPlWWqjYLu 8n1aR34WPknwf9WM8PkbQ5enifDs4yggD43W80p5nbOOJ4saqLOkdBqHOikjDXDdpKzTF5kcbNG7 eTblemKL6cnWfFH+dU4OyniGwNxqK6o6s+HrqF0SnccdwaqbR/8A+x5Z0D915djSPTHLB8HwrIwx h8zj2T6N1K1pfIwn2ssOnrvMa1xbqB5BXIUkX6qbyomanSbNYOblZuuzokKbUz6neTcMvsL9ksuj YTI+EteeXEL1J0c+nTn7q3hUeKzTNwihlF43P2JXYWIfSKz7FA40ubqSZ5HpjcDYfutwbmcZ5Ywf J4ck0zsDmSaSOLIpIhUOYJDpk4Dl6aoPpndWBnBmEVk1K1h5qGuu23uu0aX6Q2bKiVpnzbSxNG5I uV1eL9ZlanG+jwr/AAt4Nnyse3mwco+ppDGKaQAyA8DkL1t1W+l11Iybhs1fglXFjEUDS9wjk9Vh /wBPK8dQYbJgeNVNNXxkYhC8xysdy1w7FcJQcVZ1x5Y5GZTKyN7pIWMc7QNg5fV9L+k2aOsmYocG wChkq55HafSNmD3JXzEXomdLp+5wJHwtxX07Mg4BhHSyPHqClj/W1QDXzFo1f3XKLt0bm9sXI8wY X9IzNFTQxPxXHqeGRzbujiduPhfJ4z9KbOVBjTIIsaa6hJt5rzYD8r1R49vFtmPw/Zny/R5fAfJI wzTRu+0tvsvg8D+pbQ9S+nkmGYjh4oMemIY7Q7Y78hfT+PPYm/Z8FauU5NRXRwOXvo7ebTiXGM6F hcLhtOy4H7pGafo9+RTPfgOdHzTAX0ztstg/SzGqnHOmOF1Z1OmfSgtLjfUbbLjumOBZlw04jWZm qWanTOdExp9LY/lc4JRu/Rcuom5Lb7NeeRPpO1OMUNc3F8aqaaoi1COQbB5HC6oyB4InY319GQMb rXBlO7m+72hbnKHFKXEAX0c7KiM7a4iC353C8OYhWHLfjspQ31GodpLu4BXaGGOZvihHVSVRbs6c 8T3018K6T5BxDNmAYk4x0Y1SQucePddK+Frwi4r1+zFTQPZJDgrGh9RVEbNb7A+620eJnJ9R1B6d S5apg90lc4McG+yyOhfS3D+iOQ6PBmMjjmsPNka37j+VnbB4dz7NeeUcm30eTuqX0rOm9FkmsqsJ mqqbEKSB0hm1feQLrV0/C69mOYhgVHTOrpYZ3QRhu5dY2X6IOpzpH9OsxOpwXyChlLQ3k+gnZaNe m2MQ9OOuNHieOUzoKKornOkdOy2n1bkgpiwrLBt+hHNKOdQ/T4ys6I9U8Bw01tVlTEWUOnX5jYnW Dfe9l8jDiEkU13NlErTpfDILEFb4j4nOklXkpz5Mz4PUwMgsaWQgEm3Flpb6645hGbutOZsXwGGK mwp8h8mKG2i/uLLxyxJRbPpQzNzUWfJT1T4gyXy9Ljw2y+gyXkXG+oGJw4bhVL5tTM8A7faD3XAx v84U7ZBd43XorwaYocN6qUUhtpMrW2Iv3Xkqz1yZ7i8OP0+skZVyRDV5yoRiWMTR6nveSGxgrL6m /Tq6aZ5wWqfl+Y0dfpcYvKcHNLuwPdep820M2MZJrKSgm/TT1NMWxScaSRyuq/Dd0ozD0pixOHHc b/jL6uQyRuLtWjfhfQxwqO5M+FmztTUTzN4avpy4PBiFVWdQKUzGKUthoOAQP6nfC9AVuXPD/l/M zcpz4Bg7cSYNLad8I1fjdd0yY1JS5tioP05/mtuZbbLrLN/h6yHmXqtS5nrJdGYIiHti8y2q3x3X aKTlyeWeWah/dnQPi+8CWS8b6eVmaMl4fBl/EsPBnk8kaWyxjkWXnfwO+DXD+smYZcczCXOwbD5d oB/7pB7/AAtiHihxCrwvorj9Nh9FJUB9M4OLOGtsur/pzGGPpPXBjQyc1JMg791qeNzw7n+m4Z9s 9iM7xN5A6OdN+l9VFWYDh2HVL4wykZDEA+R/b8rqTwIeEnBjHX5vzBhkFXSVL3OpKadgIaL34Xyv 1QMSmrupeUcNdI8Q0sfnBo4vzv7r2d4V3iboRgEv2mSn3cO6SxbMSl+nSOVuTsGuyH0dzdis2XZc HwuXEA03pI4w1/8AYLofAfAHlrK/XRuM1FNHWZfLvNpaIi4aebOC7Pw/obgGUurT84UWPyPxuaX1 0z5LgtP9OldxZ4r6+goKN1DH5kr5W6nWuQFhw21Xs5LI8vL7R1x1h6v5G8PrcOpK7BIYYZiGM8mm boaP7LNxHKWRPEt02qGVOF00mHVtOQJxGGvjv3BttZcz1dosjVWC0kmeqaldTbBs1Q0elx+VzuAY PhVBlFtNlpsX8OmhtC6I3ZpI5CkVSTRzlJ7nfRqn6A9U8F8IvW/FctTUTKzCzWmn894DvRqsHFbG +sHQbIXiU6f2ko6WV1VD5lJXU7BqYSNtwtNfiBwbEcJ6/wCZqKteXSw1b7WNvTfZbiPBXPFN4eMs Rsn8yZkREgLruaflenU41jkpI9OOUnhT/TTv1N8POK9LusrcjVcm0tSGRkH7mE7FbiPC14d8tdA+ m9J+noYRiMsDZ6qqkaC4bX5PZeA/GXXFni3q5Q1zjTGItJ42I4W0HKPmY90twwVJu6rw9jXEdwWW TUYktsurNQzTWOnyeL/EH448t4b1iwnAcFo4aiGCpaKvE3NBDLGxsvYGdMs4f1q6VOw+B1PVYfil KHMqLAgXHI+Vo3600QwTrrmbD2bxQ1skb2g/J2W2D6c9dmas6JhuMlzsLhlLMOMgOrQORfuLrnng sW2SM4FOcbb7OzegXSOl8PvTOfCdQeynL55JPccr5Lod4kJ+svVjMGGUscEOBYewsibb+Y5wNrkr t7qzQ4pifTLMdJhDNeJz0cjYWnbcjsvAn0821mX+seM4XiLXCvdE9tS139L9S3hisuPJkl2cc145 Qgme2+s2e815Fw+iqssYE/H3uktPC3lrfcLIyr1nwzNDaCl86GlxmYhs2HyO/mMPfZchnzqnlnp+ S3HK0Uhc06C4fdtwPleIuhVQc6eLurzJF5rcIaXmKR5Ia72K5Y8KnByroSnOGTapcGwHMmWsNzZg tVhWKUkdZR1DCx8crQ4f2K4TpzkSDp1gceC0Tmmhjc50bA22gHsuH639Wv8A0eyW/MjoGVVJG8B7 XG2x7hc90zz7SdTMn0GYKNobBVR6gL3svNUtt+j2PZKSXs1Q+Ibq3i3SrxmZhxzBJjFVU8wY9jNg 8exWyHoF1ap/Eb0t/iNZhzGxSM/T1UL26mPNtwtWHj+wl2W/EzjLS4k1J88ObyQQtiH066R9J4dM PlfG5n6mV0g1gh37hevURUVFxOOF74ycvRrx+oV0SwLot1RpYsvsdSw1gM4hvsAe3915rjZLDSyS XJfJ/he1Pq2Usruq+AVZP8htMGfve68RzzTOqYi0EwtaAQuOoS+tHo/xsnki7fCZ910oyG7qDnPC 8DqJBGJ3tbrt7rdz0o6Y5f8ADx0qp4MGwzU6GnEtS9jf5khtcklaaPDfiL3dbMrSM9I/VMBt+Qt7 ePYvS4PleqxKsjc+kp6YySxsbqJbpuRZeOP8qZ9DV1VI60yt1Tyt19ocRwI4dK6kkY6KXz2Xbfi1 /ddMdC+l0vQLxL4nlvDq53+m8QpjUMgceHc2su4vDj1WyV1Sw/EJMm4b/D6ekmLZw6MNOq6+b6h0 9VQeJrK9axh8iaEtLm/2XtUVKTij4ibUVkbPvuqOSsfzLiNFU4ViD6aCF41xNcdx+Fw3iKr8Dwfo XjUGZKiJlDJRmN4kIu9xGwA97rgfGV1tzP0LyLTY1lnC/wCJSaiJmkXDW+60/wDWnxUZ7671bhju IStpA42pWktYz4su+HFcVkfRxzSk5uEUewPpZZhkr+reaaaF7hh0cT2QxE7EA7H+y9L/AFHsYdhv h6q6dj/LFVO1jiDba68e/S5mkpeqTRE27Zo3iRw4G21166+pDl2sxfoXNVQRGWkop2vqNPLW+/4u sbovNaPXqVKONRife+DLAYsA8PWXWwRsYJ4hLcNsTf8A/IvAvjM8Tuden3ijnkwvG5qWlwrSBQRu tG8DkOHcle//AAaZrosz+H/LTqOVkopIPIe1v9JHute3jB8Mees8+KjEKeioHVs+NlstLJGLt8vv c9rL06ZJZpbjwZq2w3GP1k+pXF1n6XTZUqMtfpKyoh0OkddwL7WuvGmB4fJh8TGzAanvLj+F7E6o /THzZkPJLsfix2mmqoYjLNCdtFhcgLx9TV0tdcOcHOpXGN7hwSNl8/PJ9cUfc0qgl9T6rprkmPPf UzCMGqnEUlVO1jrdgTut0vTPwa9L8mZUo6Z2XKXEZXRgvmqWanE2Wm7oXXyQ9V8uytOktrYxq4uL jZb9m136XLMNXpJbHSiSwH/TdeTH9nwd9TLZE6erPCp0ozm+pgq+ntNQCI2D42BnmD3Fl19058LH Tbpj1OxDL2JYJQVsOKtM2GQ1EYcQ0cj8hdT4Z1l8SWcc5YrSZSp2uw8VbmU9TWxWja2+17hc9gmD daMN69Zdx7qFURV8cX8uJtBFqDL88cBfW8Eorlrk+Bh1Cy043aPUFT4fek2XojV1GVcIomggedJE 0AE/K+O6h+GfplT4acxjLtLUPpyHhlhokbfhD44KXG6zoHXjBIZaivjcyYhhLSAN77LW9B4yesWb MOpcg4g5jaeS1ND5Df5pttuQvPjxOS3WevJlcpOFG0nJnSDpdmDBabEqDJ+FRs0gkCnabEe/uuer 8i5Bzfhs2DS4Rg9XTWLDC2Jg07W4HBXCeHHJ2J5d6IYXh+KyGLFKinJkO+phdf3791rI8T+Y+pfh p6vYhRQ4rViirHGWnmc8lrmk9lIpNvk5yc4KKS5Zsa6M+EHInRzEcSxKloosRrKiYyxSzsDhTtP9 LQsLGfErkOm6oRZDrMNglknd5Yk0NLdfsW2TPBTmqXPPRjDcVqcVfiVdILVIe65Y72t2XT2YPD/j 2L+L9mZqfC5GZfikbI6ZzfSXXvspj2u9xz1DnFLadm9XsMyz0o6h5YzfT5fpY46h4pJhFA0Ahx2d 7XC9BT1OFUWFPxOSGnZSxxec6XQNm2vf+y6t8ReVn5xy9TYXSx+bWtc18MYNnEj2X1dNlvEa3pLJ g1Sx0WIT0LoHB51aSWWC1NKUYneE5w3UcngWY8u9SMvfrMPlgxHDKkOjOwIPYghaP/HHlLL+RfEl jeH5djbDQk65I2cBx3IXI9Us19WPDtnvEctUebq3C6cTPeynjcWsIJPZdFY1jFfm7MU+I4xWPr8R qTeWd7r3KmbGsK/5JpnkyzUlwYzKYXnkjdpGm391tn+lRlfDIektTXx0kTqnziHzOaNQK1QTxPp4 PLFhva62j/Siz3hLMi4rgNRXww4iZtUdO9wDnD4uvnUtx9/Ik4OjvzxG+KCo6F41gtMcNNVFXPAN +4vbZfZdRZqHOPR2XMNfh7ZX00AxCljtZzHgXBXwHiq8OmLddcey1JQTQQ0mGyiSVz32cd72C7D6 isosl9GZ6XE6ptNR01J5Ujy7Y+m1vlfV+r2pLk/KxlOM573wc30pzlU536aYXjDtEdXPBchu4BGy 4Hoz1RruoWJZmpKuFgbhNUaYSBttZXDeFCsgrekEUtFURS0QfIIQ13qbvwfZYvh/a3K2Zc2YRXFl PX1Ve6pbGXgkgqOCe6vR13SvHb4PD31fcJw2hzTlOopaOGlrpmOM0sbAHPHZeAQyKWEzB41i9rrY N9X809XmDLVQKqGR9PGYvKY4F+5vuFr5paWJ0JiAIl03AXHOkoo+jot1yvo92fSYxkwdXcSoRa09 EST8r2d9RjCKfE/DRmCaVl5qXTJGbbrVD4X+vFb4bOptFmTyW1FM/wDkzxu/2Hm3ytw+H9XelviV 6dmlqcWpJqDEYQJ6OaQNc0kcfsuGCSjO2Nari4xNGuTelGZ86TOnwSglqWsY6R8scZIb8E2W276W OCzYH0TxWmrpCMSNcRNC/YtsLBd0dOun/TDoLkqqosKmwmKhYHSPkmljJI5NzdcJ0mzb0hosexDG Mv5vw+B9Y4mSjNS1jA7vYFenJ9m2jhhk9q3Lk658Z/jbxnwyZyw/CcKwCkxeKppTK+SZ5DmHtaxX C+AjxCZz8QWY8dxLHa8upAfMFCD6Yt9rL5T6nGXMl5nyPDmqjxqhqsapgWaIpmuc9nxYrzN9OXxU YJ0SzvU0OYH+RhOMAQvq3naFwOxPwuzeNYuFycoRnKT/AOT1R9SmGSXOPTyWT+VRx1TSZBtq9W4X tbLtdDifTujno2eZE6gaGMtz6OF1d1F/9G+vNBg0+MZowmvpcPqBVwaatgGr53WRiHit6P5QpH4b DnLDKd0A0NZHKC1tttlyct0VFdo5Qi45JOT4OufDL4YcK6TY3mXqDmGJn8Tq55Ji6cbQMuTcLpvx geNDGs+tqshdJ6Kpqg+7KnEYGEueOCxluAvW9R4g+lWYspTNrM4YXJRVMZZLeYXcCN9l1v04zr4Z +nE8hwXMODw1kji4ySyani/yeF6o5lKW/KrrhHmeOdbMLNNecsoZny/XynM+FVmGVT7Ob+raQXk9 917S8O309859ROlFHj0GeqrAY8QYT+jje5osnfVA6u5D6iyZfhyviVJitRS+qWajINyDsCVxXQT6 quJ9LMl0GW8Yyq3EaSiZ5UMkLtLrDi68uVttM+xhj9Krk8/+JTw54x4ac1UuH4ti38X/AFt9Egdq df5XWNG18mpgaGEbBx5Xbnix8S0nigzzh+P0+EfwempG6TDIbk/K6enqnPkb5e2rc2XizPlHs0yc Y8oysMf+nxSnlk2bHI0uP7r9A3h+xGLFOiuUZ4ZmTsdh8frYbi9uF+fN0cwiJe46T7L0x4SvHfjn h7f/AATEzJimXnn0RzPJ8v8AB7LhF1PcztmuUKijY7l3O3UU+I2uw2sw5zcqvcRHORZpH7rvvGKG XEcTpbU1PNDEdRdJ97D7tXimt+rF06psPfLJgtVU1pb/ACmQNBGr5J4F15KqfqSZ3puswzm6peaJ t4W4MCfIEfyPdfUct/J+dalje2m+T3V9QrHc2UWWsDo8rx1RZPUtZUvpHEODSRzZeisg4eYelWE0 dcHyH+HME/mm5ddnquvEGD/V36fY1QRMzHlWqZKAPMLNMjb/AACFxvVj6tGUK3J1XQZIwqsbiE0R ia+qYGBtxbay2pKUFBLow4yjllk7sR4Nc44TlLxZZuwGarhoaaqnmjpQ54AedRIb+V3748uiGYOs GTG1GBRfqJcLa6RsHd+29lpbqs945JmcZkjqpocSZUmqjnY4hzX3vde7emX1dMSwTL9Bh+asJbiV TCzy5ZxsZB7m3ddJZds96fJY4Z+Pa0d4/S6zbR4TlrMGTsSqY6XMEdUZH0kh0vNtjsu5vER0z6j5 r6hZZxjKmJOo8KoZB+phDvuF9zZahc3eJ/E5vETiPUfKNOcHjnk8xtNEbA/kBeqcF+r9juH4TCyp wIV9bG0NcH2aHG3Oy4LI9++J6ZQlLGlk/wDwbN8dxijwjCsNhxLGIMMln0xtkqHhpkfbgXXy3iKy vjua+jmLYTlxxfik1PaNwH3FaWuuvjEzz1yzJBjGJzvp4qZ/m0lHTOLY4HA3B+V2309+q71Nyhg8 FBiVFTY42EBjZagWdYfIUVRakmctkpRkmuzY34KunuOdN+jdLh2YYRTYm+d8k0fFiSvA/wBSjDTn 7xL4bgmDjzcWkhbAI4/6ieCVmYj9YTN2JYbNS02T6WjqHtIFU2Rx0H3AsvIVT12zVU9WP/UIztrM cZKJWCQ6gLG4Fl0WenKftnLHhlFRx/huy8HnQ2foT0gwvCq97f1rohJO0HZriL7/ACvA31Uut2BZ kzXS5ewWpZU4jh2008RBDDfcXXx+c/qp9WM2ZJnwNmG0+EVs7PLdiEALXgEW2XjyaqqcXq567EZX 1VZOS6WWU3LnE3JXLFlSuTPfkxSnOP4bmvp1eILJ2aOj2C5PpsSihx2gYRJTyPs5/wAhdf8A1J/C XX580dQMAu6rhY2Gsi5uy/3BaqcBx/FchY5DiuBYhLh9dE7Wx8Li0grvyq+oN1nxnKz8Cq8ZZU0j 2aHOkYNbh8nukMiTs3nwSn/ybf8AwmdOsK6WdCcuUmHsY3zKVtRUydy8t3uVx3R3xP4f1P6lZoym 2Ly5cMmLYnAghwHK044X41OrmC5akwGnx6eGF4LWva4jQ08gL5zIXX/qB0wzDNj2B4qW19Q7VK6X 1F55uVm48tmXHLSr0bmszeGhkniLwjP+EeT5ZJdWxPdbS7/cB3XZ3WnpbS9WMo1GD1TnxF9iyZh+ 2y0iYj40+tGK4w+vZnOvopnHUYYPSwfC5Z3jn66yUZhfnKZ0NrO41f3WvK7i/wAPMsD2yVdm4rpJ 4fspdJcuR01HRwVlWf8AmVcwDnE/BPCy+vrqY9Fsx0z6yno45KN7BJM8aeOAVo5rPE31XqpXz/60 xJrnG9mzEC64fMPiA6iZtwM4RjWZq6toSdXkvnJuvVDZke6cyeLLGG1R4Nr/ANMzEKNvSrFqCOri lqI699wHbkXPZdJfUzgpM79bcj4G2sigihs2pkLhZoJ3JWvDLGf83ZSfJUYFmLEMFOxP6aVzQf7J WNZ5zPnetNViuMVGI1lrGomeS8/us+SEcu89GLDOKS/DfB0CyHkToB0ojdhmKUgw8xCpqKx0rbON rk8rWX49PE/TddOov8OwCTzcBw9vl+YDfW4ckLy9HnjMkWEDCpMxYj+jtpdAZ3aSPblYtI39OwBr dLHEkuO97rhHP4peT2dMmleSSi+jFmllleWOF4w2wC5jI00NDmXLslWRDGK1jpHuNg0agsCRj5JL NHpCXU00UkbopXaieAOy+fkm5ty/T6+OKhBRP0IZL6iZVqunNDPHmGgfRxUbGSS+e0afT+V4m8Pv Vnp/kfxdZ0dLjsMVDWNcIK6eSzHnuLrWXT1+PYbTmOHGK6KltbymzHT/AGukPa2SMVEkj5ZBy4Os 5erHkjGHPZ8vJglLIpG+DrB1k6OVMOFUWZs1YfOBO2pgbTzh5a4cElt7LmK7xC9J8dy/VQT5rw00 T4XMeySUC7bexWgVr3TN0mWaw3BedVkuWlnrGlv8RkDP9hef/lSM12Zlgk7X6fd+IKTL8HV7MAyz K2XBTUOdC5nC7k+m9nrp1kLqtWYrnjEY6KpjH/Bvm+1puvLUeGlgdvcju48pbsOimcC6L1f7gbFM mXe1Z6cOneKNI/QBj3iz6RGmNPNm7DqyGeMh0ccgdtbgrV/lnxgx9FPEpmXFcsSB+U5KogUgPolZ deQm4OyncSJpmg9w+6c6li/TuDm6muH3OO5WFkcXXoj07lLcbqKD6g3R3MOGUtVjE8cJc0O0SMbI WO/dfEeIj6jXTyg6a4hRZMr3YnjdRGY4otFmsB7krUTS0DIoNXmuDAftvdRj2N1GBvmuaO69UMuN K2eKWlmpcGXiWLz4zjtbiVadc9c8vkPsSeFx9XTVFJuwki4c0BPgidIwPkdyb6fZchT1TRdhbfa1 yvJlyb5bkfVxY3CNM9y+FT6ndF0qyrRZZzlhdTUUFMwRsmg5YB8L0Ufqc9DGvkxGlp6j+IubYEQD Ufglakv4ZBUvu94Z7i11h1NAynkJp4Y5R+LFXFNQR5s2m8vZs8xn6tWRcUxMUdTlqeow4O9T5G82 7hfe0/1X+kjsJc2GCujlZD6YdFgSOGrURLhtO6ASEgPI3ZbhYlPhbHFxLG/m1l1WdNpNcI8/w5K9 r7O1PEZ1swzqt1TmzTheDswujfL5r6doHrN+T+V676PfVYy1046Z4Xgjsuvkr6ZoZI1g0td83Hda 8DTiON7Xx29vlcfLSmAamQRuJ7ELWfUvO0mzWDSeGG09n+Lr6gsfiXyXFlqgwP8AhkTZRK6Vxu4k dgey6I6BeJvNvhxzY7GcGvOHt0yUsh9DgupaJjhIbgRO5sFykE1LYipbqkHBAsuEsz27GzrHTpcs 2HUH1k8TlpGNrMjxGqDbEsebE++6+OzP9WPP+L1TG0uB0cFLqB8r49j7rxFLVGVwELPKaOCd1mU0 UEzbyEarcrSzKLTRiWmUj3DD9WzOlLRtphl6kgIFi8D/ALLoLr14sc0+IaRv8VZFT00Z9IYN/wC6 6UmonOcRq9PY3ToWhsJYV7cev8VuK5Zz+CnSb4RnlgNC1p2PYrFETZ7NlIc4cFFC9xbpdctGwVSR B4Nr/Fl8qeR5JXI+tGKiqRjUn6vBsXjrKSrdSVEZ1MkYSN16QyR9QjrXknDosOp8XirqOJoaz9QN TgB8rzoycxCzow8e5Rmdr2m4Db/CwlTtHOeNSXJ6Ezn4+es2cqOSnqMcNIyQWLaYadv2XwvTnxG9 TOlFbX4hl3EnMmryXVBeb6ye+662pZmUhc+7nE9jugGJyySaf6PZTzZYul0eR6SD5Z2JmXxR9Usw Zjhx6ozFVRYlAbskY62krFz/AOJjqZ1TwX+F5ozHNX4cNzG88n/yvhHvYHF3+FiVEZq7W2AXdZpp 3ZFo4row44my1LZ33IYLAFQwyCUyts9jttJWT+nmDA0geX7hOZeNtgFwdybkz3qNJJHHYfXYvlev bX4RiE+HTg3bJTvLCP7L7Ot63dSsUpWQ1ecMSnhPDXVDrL5aWPfVufhLkvIA0tsPhbi3Ho4zwqRl w51zVhFWKumzBWw1PPmMndf/ALptf1Wzni0ToqzMVfWtedxJUOK4oUrBvdxPyUDovKdqY0By9ENR ODs5vTxapoxBT/q3PfUvIceSTchXFR1VE8fpqqQMvcFry1ZcZ0l2rclE5zjxsPZYyZZ5Hcmdo44p VQT6yv8AId51fUy2FtLpC4H/ACsZuHuqoxL5hYfZpsU5kkkQOlmq/ur1vfYEab9gkcs4x2mFggnc RcUFS0aP1lQW+xebBNdhzo4TMS+YDkBxCaHSsYGiwHyjM0sLR3b3AUc79B412Y1iWh7ZJR/0vcTZ CKaR7S7U7UewNismSQStBjZpPdMbIQb91pTaVIw8MW7YgQMpGiRu7jyHG6tlNNVv/wCGjDDzdquS ITG7rj8LLw+Y0eoNJBXJyfZ2hBLhHHvwuoo3tkdL6r7hchLCKh7HA2KkrDUuL3m5RM9DQO4WXJs7 pJCamleZWvYSXNWLVUBmA85jXHm45XKEkNBB3WO9rnkm+yWRqzji18LNMLLdrHdRkUsw/mBt/hZh Z2/yhMFnCxW97ZyWKCdoE0IY0GP1O+d02Gm1Bzr+W8jcDZHC10btjdPjbd9zZXfJeyvFFu2jH/QR vaA5uojkoH4WwOuImEfI3XI+X7BMaLfIWdzN7UcZJh4kEd7AM4HZDNTtFyI2lx9guUMYO6B0bBtb dSyOEX2cNFSuY12s6ieAeyS2lk83VpY4j3C5p8AJvwsaSku4FpsfhSxt4MCeKomlaG/yW9wFJaC5 b6r25WX+mc11y4n4VmI322WtzfbM7EY7YoowGuGoflQwMc3SPS1ZPki6vyxZSypUYYphECBuwoDS tc8G1vws/QAFPK325KFcb7MVsXk3td9/cpbv1LwY3SXZ2AWYYze3dW2GxuVHyZ2iA13llpkINrWR tlENOGBuqS/3Jvl6juFZitZFx0XahMVVM24PB7qiHOsf6gU8ssFNAP5XRNhJLoCORxcdTR+yCWEa TpGk/CfpA+FRAI3WnI1VnGR0row4ued/nhZcTZTEGhxI908xgjgEJjGBrdhZcmxVARwkNudz7lUY XyG7DayyLX2TG2bdYNGMxj2A690D42k8brKJ990Om+9lbAjyzcAHTZMEbyf+YUwMFzsiDbKAAxOL LFxB9wpTXD9LnE/CcdmpdP6JS4qMqZkugIbZmwRDVGy5aHOHdC6buOEsz6mnc7Ika9lsqJWO1W2+ VJT+pN3tt+EAkc63+0K2S+og8LumEjHdCHOJA47KeVqbpIWYWN1ofLOq1v3Ukw0YjaeRmwNh7Iiw kbkg/Cy3WakvsCVysyzHDbXVAOBO+ycLFt7KtHwrZBTo9TVUcYZcdlkBuyEmxt7q2KMEU4mkLgNJ Cc1upmh27Uwx+W7Y8q/LAG+ylhAx07BwLW9k2GNkcgfp/urYwFp3sjis3ndEwypJW31atkszNJFz YHhFM0TXa0WWHPTSMfG5p2alkZkuaNWwtsjjvp5VGbzBct/soHWvsssoZ0u5VBocbdkOsEj4RRuu b8IShRpfVsAmshQudY7JjJzaxH7qWUhhFlQjAVmUFEN97JYAfGCRdZD3iJjC1t7Jdro2nSD7KNG0 y21Ot2w3QPb6r3RRN9J3H5QuFiolRWwXAEcIC322TWeoFQgWueFtMw0YzhuUq13WtdZwYHiyx3xE OIFiSt7jKQp0TXekgWSTEHHT9vyVkhpDDq5CxpGmS4aDdSzXYt8YaRqNx8IwxrSDf0oooHlpc4bD m6uF7ZgQBsoXoF7A47N9KTJFpH8vdZsYLSWnhLa5kMh+UMmNFGRtx8K3sLW6huFksDXSX7IZGNDS gMOMuc69lkAB3OytjAG3H9kenU3YWVTADaUPfb3WLUxGB5ad1yDb6fY+6ExtkN+SVuyUcZTy6Jby D0+yHD3GSolYbWJ2JT6mhLTqLkAw+VjmyRkXSyUPr4TDpDRz3Cuajhjja4glxT23dEGybuCa11mW IBWLNGC3DGj1FpI5RNhaNmNss9kh3HYqw1rBxulgx2wAc7lU+Mt43TrnvYXTIo26vUd+yWDjZISb I3wusBwFmTRaXG25CXpJIJVTBi+S5h23CsNdq9mjlZWkj8ICwi/sVqwYrm3cTurc8tHynOjLNyUp 0YkNhyqZENIcTcpboSSbG6fJSltrG6jmmE3FuEIYJdZ+gggoCQ19vdZznAgOIGpY9W1rrFo3WkDH l9JCx3Nc47/4WZUC4Z7pT4XDa37oZMdjfVpBCYBpNjultoyx9w5PA29yqCWFrhRqoCyscLLBYV2V EXVaiDa2yhUFZE0DdCOR7Kw+xIVLRTtI7KwRa9lRF+6g9iqiUS4BJtZExwbcjuhIsEtz9DCRc/CE LkOndU7SLEcoWvdMNxbba6BoLTY8ogZbXDQCRuo9xa27RqSo3kjcWTueOVQAKg2sW2VmUgbJZOsm 53UaQdkKh/mEyAt3CJ15L2CBg0nY7FGCG333QoDZDHdqto1cIHNs7Ve6gN+drKUC5B6hflQuOrZD IQ8gg2t3VlxcRbhKAQJvchMuCkslsSCiL7g25SgFKQW7FIBNvdQ3DDve6KJtgXFEC2Rg3Pf2VcfC kbiXm3CJx0j1bqgV+6ot3ve6J3qAIVtQlC9Go3v+ydcDayXYhyIm7T7oKEzRF0oltsED3B32/unN N2WdyhbGGt0tG/ugYQANgG29yikBLQL3VMDh2TA8EWI3QhiyXD7XsQmxDSL+6Nwba/dUCLgb2QFO 4QFETc2UABHygLbfsqkjDnglW3UBfsibd17oAQCSUQHKhNhsoCEKinBWBbZUTfccKA23KFCIN7A7 JjbN9PdJ12FyoXEPDr7lANcXH4SgXk7jZMuSTcpb3kCwQDWsaRsgfECS4chJhkLblxsPZN8zW3mw QMSbvHNgpG3SNjdW9unYcKfbayGRMmrVsEcYJA5umhum590YIb2QAFpvxZURbe6a7doSSCb+yAsG 6rSXcIAwkbFW0Fv5QF+phta6YQdiePZU4ubxyVL6hayhaLcLlBpA7qi31DfZRwIJsBZUlGxmjxx1 SGgONgk5nxB7cHmYwkuc2yZgmW52T28s2PwuaxrK0jqNwtcgcL+SR2po/odtJnhrGw+mxiuifuXS E3/dUxuposszPz2QZzxCntpcJCLLDpn3jaANxyv3mnd4lZ+W1D+7Y1sLnNIdwVxdfGCdDfSR3XOs la1ttN/lcfXtY4E917InmaOHDdDi3kKSsLQAD3QEa5dr2CdMLEe69SR56MSUa9jyhjY9rmW3AKuQ 6n+ydSytbJpcL3VZEZzKlwd6WW2RsqjKTcabdkpkhjf6ht2QGUuluPtPssmjMY3XcjZZkDLs3Cxo gBYDcLPaA1llls0DbzG2uq06BYIoWGxN1Nnd1hs0kImbe5WGyMF5JWbM2w5WHMf5bnA2AVI+Dj3t NNI8AamuN/wkVGY8ZwmzKKtnpYzy6N9rKsOo6vGsRFLRMfPM91hpF16m6PeAbGupdGyoxapdRUp3 tbcr3Yt3SPFl2r+R5POdcehlJjzFWOm51ec47rjcRzJieO1jZsWxKorHssA6aQuK91Y59NbDaXNF FhcGO+SJ7eqXYi6wesn0vcQ6e5Uq8w0OPRVtLTEa47epw+F64Ka4XZ5d+M8UnMlcY/JixSphiH9D ZCB/ZYza+qicXRYjMx531B53Xu7w+fTpwrqxkx2J4lWzUUmkubo/8rtnJ30uMgHFDRVeNy1dWd/L DhqA/C9Khkcbb6DniXSNXDcwYhIHRzYpUPYeQZXG6Q2QG+meVo+HcrbziP0pemDKgQfxV9PKd7Pk sVxGK/SVyk2SN1PjTo4eAWO3cuSc26OCz4fw1QBgnkaf1L3O49bt0LmsifpdUvb7WcbLZL1r+ljB lfLLcWy1UzVFTT7vjvfUF9L4fvAHk/OfT2oOYKLXjGkt1Ftixyy8c+zt5sT4Rq3pWVFMHSR1T2R9 zGSkGphfUl0z5Jfdzzcle1sK8MeWennidfkjMdUx2CvdqY5x2HsCvUXWP6buTM65EecrRwYdikbD JTzwWLZNrgG3uuLcrovmxpWaomx0VMxkkTi1xtsSsos8yBzb6Q4XBT+ovTPGOl+YJ8Ex+llp5oJC 1sjgQ19jyFx7ZDPAwDZjRa64uLi+T14pxmvqNgMtKzymSNkJ7OSpqakdMGywDzDuSzusqgw2Oqqg GFxkdsLdyvYXhL8E9X1ExWnxXHaZ/wCgeQQx7d3BVfom4xXJ4oZPh5m8tsQZc7B47prcIc6Quaxx udmx3W3/AK2fTI6e5iyfVVGX6ObD8bhhvEYnWDnD3XQ/gv6fYFlrqNJk3qBgUdRXiRzInzsG4vsd 13+yR4vNiZr4ZguKNlLWYfO63YRE/wDhLE0uGTEVMM0Mt7aZGWX6Cc6dOuk3TLDDiVflugii2F/I G/8Ahdb9ZPCz0463dOn1uE4NR0kskBkp6mBgDgbXHC7QxvJy+jm9Xjxy2mkigwLHcWkkOF0cte0D U5sceu37BFV4NjeExa63L80X/VJAR/4WwvwG4Nl3pz1Ux7LGL01PX1LZTFFJOwFux+V7/wCquUsg YLkipxbFstYfNTxRlzgIW+y5+NqWw6yzx22fnnp6wVT/ACf0jvPcbBobv/ZfQYd0zzXi7ddFlmrm b/ubCd17+8L/AIYcA63dYsazh/D2UmAUs5MFLo2O+2y9p9SeofTHoH+gwvGqOjpHTlrIo4423Pa5 2XSOJt0cJ62EI2jQnj2B41lOrEeKYVNhrzx50ZbdSlhjxCLzGn1Dn3W73rl0e6adZshPrKjCoJoH Uzp4ZYAA5ptsbrSTjmE/6fzZitJT6m0kFQ+Nlz2ubLnOG076bULMrQVOdUgiLrPPBcrqpamJxDGs lI5AUho2zyiVzrOHAXYvT7oDm/qjPpy7hc9UTvfT6T+6xfpntbOtHVTS1rpYSCfuaN0LpKVkoa0P j17gjay9Nf8A5u7rLV+p+XnQR27G5K66zB4XM+5ZzJS4DiWE1H6qofojdoIBP5XaOOUlwed5MaZ1 sX6GaQLjjUd1VO5kcbpXhpJ+F6IP08OtLqqGKPL5dTyAO857rBoK5PNP02erWVcElxSWKKWCNmt8 MbrlTbJ9jzY1xZ5p8r9Sy5drYe1+Ff6ZsVK4te1pv9pXoHIngG6k55wluJU1PJHA86WtOx/dfb0n 0quqdfTmTzIqd3IbJIqoSfDHnxrmzyMJ5Yog5jGm22xWOZsRqjaSRrIh27rvXN/go6odPMcpcNxL DiY6l2iOZg1NJXeWVvpSZ7zFhMFfV4tS0TJWg+USQ5YnCUezUc+OV0zw4Y53euObdvLAVcdU+P8A mubodwQV7O6k/S5z9kjDRiODEYu5v3NieHEDvssnJn0ws29Qcs0+J0ePUUVQ46ZoCd4XDsR7rO10 a8sUeLWB0xMuq4Psbpn6uOLS+ZhJ4BstheB/SHxiow6RuL5qjhnsbCJl915f8Tngkzt4dtNZJN/F 8HJ2nivt+QsvG3ySOoh7Z05JUslgJjFhblceGFgY7zDJrNtI7KqGsLaLS5ou8crksq5bqq/FI6KB pmqKl4awAe65cHou+UcTXQeTKC2ocwEbgFC17KUt8uTU08khbLOjv0tsOzflWkxTMmIvpZ52B+ho 4BC+wrvpU5Groqijw3MjHYjG24iJ3v8ANitxTZ5HniuGaqmMdrdJsYjxulVDoC0FrSXjlxWw7Jf0 0qFvUWryrmrG3QPdGZaZ0B9D2/8Ayu1qP6UnTvK9YKnGccqJ6F3p9bg0D4XTZ6M+eNWaoYMXh0eV K5j77GxuqlpWuiLoSGW4aFsy69/SjyrFlCsxfIlXOKyGMyNhe64ftday6jCa3LuL12EVzSyrpHlj m/IUeN1ZqGeM3tTIKNzywO9VxuCu+PC94UMX695mjAjezB4nASuA2I7rpvDoXVLGPOxOy3K/TbwG kw7os2eGJgnlmvJJb1ccXWUqN5bUG0fLP+ln0gjw+BtVLPT1bm2c90lgXfF11bnn6VOU8qVUOJ4V jc9RRea3VA4i+kneywPqX9bM6ZO6pYfh2HYhPheGwRCaIQuI8w+/9119kn6lOasTyz/pzGsJZXO8 sQsrGjdva5X0VhqKk32fBWbJkbUD1/hf0z+iVVg8FRU0tRM4RNe+UT2F7bkr5fHvps9H8/YXVUuU 8V/S18ILWuZZ+kr0x0KdUY90MwiSZx/U1tNdzib21f8A4lh9PMg4X0YGLYrimIUsUUrnPM0j7Fo7 3XCN80zrLLK1uPOuQvpY9OqfK0tDmh8+JYpcsFUw6Qz2t7rzjkXwd5Iyt4wqnINbM+rwZo1RsmO7 vhbOem3UGl6hYlic+GV0VfhcDi2OWI3F14kxWpjH1CP1L9mQztia8nZd4Rbckxjyy4fo5nxR/T56 eYXk2nmyhg0lNjkknlxhm4df3X3vQTwN9Pun/TCM54wOixDEXgSSzVLR/LFuAvT+cIZf1VDVOsae N41A+66+8RmRKvqNlujpafGX4TRk3eWP0h+2wJXGK3JR/SZs0lfJ5r8Rn01un/UbJsuM9OaUYTjL WmSMRPvFMPa3Zaq8c6ZZiwDOsuTZqN7sZbL5QhA3vwt+/h6yNi2RMquw7EcSOJUzDeneXarNWsDx kVEfTnxX1WP09PaqZOJQ0Dne66wwpuUO6OePPKDTfTPicO+mh1TxHK9Pi8MkEdVM3UaVz7Fo+SvO GYMDxTIeY67AMbi8jEKNxZIB3/dbR8v/AFWsl4blWGlx/ApTXNi0FsbLB5tbf2WuDr91KoerHVir zHSQMpaGd5tG3m1+6+dR9WE5OdHyVDUl8u24Pdc7k3LNbmnMceGwts6Zwa3b3XEx0v6OIzAXaTcF dpdF6t0OdMGq2tF/1DARbkXVXHJ623Vm0vwf+DHLnSrLNJj+N00FfilREJC6doc1gP5XY+MYJ0i6 5z4xk+bC8MqqljXRudHG1r2ni7bey7NwYU9X04pC52mndQi/xdq6O6CdF8Nynm6rzbT4tDV1lZK5 pgLxdrb/APdd8ONSi5Nnw8+SW9RZ190E+n7lrpL1Jq62tP8AEIIpC+lilaDsTtyuz+vfXjK/Q7MW EZdblSjr6nESLNZGwWadtxZfd9QP4pQ54wiqo5dDJHaXHtbuF8j4iaPpLh+J4FjXUaSOGtjeBTSO J5v8fK67U2m/ZwyZJQi1F9COr/h86dddumFRUy5eo6SqmpDNHPHCGOjdpv2WuDwdeFDDuovXrE8M r3CfBsJnJc1v9Wk8LbZi0tFi/TGvmwW36GSgeKcxiwLdBtZeIvpl0/6PqNnt0wIqXzSXa7kepdYw vFJ/hvDllv8As+0emOvvVHJnhd6TTytw6GR0UBgpqNkYJcbWF15m8CHhtwXqTmLFOrmYKOKYV02u lonNGlpJvx8L6f6p9MxuSsvMb6H1FUdRAvqHO6+u+mfislR0oxSgkdrjpKq8Z9gW8LnPGo4VNezp inOWWS9I7Y6h+IjAOnPUDCMmz0Y1VREbQxgLWg/A4XCdYvCF056pZjw3NFdh0dNiEMjZS+ECNsnt qXG52y9kGbqtV4rmvEGUWKEtFJ5zgNB+F3LmyCSXp1URUsz6iV8AbDLFy72IWpY4wUeezz+WT3f0 cJ1UzlU9IOmD6/AMMbWto4AxsUY9DABYONuy+T8NXWSv625Tk/1DhLRUtkcDI+K0Ujb9rr6/FMbp un3Rh2JY1TSYjFTU15qd41F47g3XD+HbrJlrq5lh9Tl7DhhEdM/QaTQG6b97BeaUL5Xoxunvi2/X Rra8bcuE9HPFIzHsrxx0NTSOZJUU0AAa48m4WxPwv+IPCPErkB1Syhja+lY2CqhkaHN1W9j+Frq+ p5kluXevDcRje6QYrA2T1cNI5C9CfSln/T5YxyJ5LXVLw5oPJsvdnwxjjjOPtHpwuU4u+kdEfUs8 LmXunefMPzPlqNtE/Gnky4fELRh3dzR2C9RfTW6JZeyrkKTMcVEybFaj0vqXi5b729l8r9UejkmO Va1wP6Wnc9pdbYE9l299OWV7+g51Eua6qcWknsuWbH/qjP2ejTZLjNekdV/UL8VuPdN5KXK2COdR PqCDLIRclt13B4G/EDRdXemcVBUubFjWH/y5mnbzR2cvHP1WcMkf1bwWRsT9DqUXcB6T+6576Z3T 3F8SzbWYm0yU2H0rBrfc6Xk8Bd80IrBFr8PJhcpOTb9nv3LfQnLeU8/4nm/C/Mp8RrxeZoN2n5sv PPiL8T9TRdY8u5Yy5KXx0tU1tXJG6xcSdwvZTwx8bo9Qu4aTY72WsHrp0prelPiOw6pkmknw7Eq4 VUM8oJvc7suvDhXkfJ1zNxSiuvZsVzU7G6jIE5whxbi80AMRPYkLzNgPiBzd0UrxhfUWjfUxzy2i qIwbi5Xp+qzNFh+RnYy1pMdPR+aGHvZuwXgbqX1jx3xVCnwvBctTxVWH1BDniM72PN/Ze7SJS3Rn FUeDVP7RcJM2G5fxqPMGEU1fTFwhnYHtDvYi641+Q6CPMhxulgZTVUm874xYy/8A2rcr5nIlHi2B dGYYalj4sTio7Bo3c1waumvDP4j6/MGbsSyljr3z1gleIHvO+xtYrx+N3Jw6R7N8ajHIdffVaidD 0vwiu1EOZUGNu226+M+mP16x7F66XJeLVD62lhj1UzpOWC3Zdj/VUoJa3odhxYwuAxBuojhu3dea fps4HjU/VOixPDqCSSjjDhPUWIa1vBC9UoxemUn6JglunKNnsf6jWQaDOPh5xeoqKWJ9XRgSxTFo 1M/daMqOjYyolP26NhZb/wDxtVtLT+H3NTKl7IxNTlkeo8utstBdFEGyVgedw42/K5uEXplN9np0 r/3SjfBymW8KbO0Et1ercfutvX05ehuDYZkmLNM9LFLWzEljy0HSPytTmVWmOMs7n/K3KfThxOao 6ICnnJJhls2/sV4v/U+zkltgfZ9T+sGdsvdTKLBcFy5VVmFSENdVsjuwKeJ3pNRdS+mbsYqomUWO 4SwVEFSQNbSORdcR4kPEpiXSfP8AlrAsLpaSpbXPDZWyi7hc9l2z1FMuMdKMQ0xkz1FJrLAPcXIX pi3Ha0q/s+G2m5cnF9H6ipzD0YweOWczVEtL5TpCd+LFJ6c5Di6aGuq62spjBqfJrc7dt+blcd4Z HzN6XMjkdp8ovjbfkFapvGNn3qhknq/j+D1uZcVp6OpqHPghEjhEYydrL048DyznFPhHkk3cH7Zz Xi76o4f1B8QeMVGFTiTyJWQCeM9wbCy2xdC5pazo9lh0r3PmNEwGR3JIHK0H5Ow2qrs0UUet9VUV M7XvdySbrfZ0IoqvDukGBU9UwsljpQ0bbgLhnnFtJej6Xh8eJbuzxZ0hh/XePbMHmnzYmPda+9rF d+fUFr67CugeM1lHVSU4bZhax1gQfddA1jX9AfGRDiuMN8qgxWp/++37Ms78r1t4nemz+uXRHF8B wuUSyVcQlgfHYhxG4sV6crXlhN9HzIxbwNGmDpt4quoXRtrhgeMPhpHgl9PI4lpPuvh+rnWzMvXj HoMUzLPFNNBszy/ZbB/Dd9NoYnNX1fUuh8uEXjipWixIHdeSvG90Myn0Jz7TUmUpZCJ3ESU0rr6N +y56qacns6PZpNlLjk6SpY2z1bYw64LSSAtkv0v+imW8dpMSxnFaJlZXQP8A5fmgHT7LXLhcEcMk cknpcbLaH9LLHIW02O0JnYHPaHNaTYn3XyZNtpI+xJbYts99OoKKkhbFHSwsjGwboFl8j1CyXlfN OW6uLFKTDntiYZQXtYCCBfn9l194t8N6iYnlSii6dyObXeb/ADmsNiWlebz4OesWYsNFdjWbqtk8 zQ51KKg2G32lfTwYYySbnTPzeTNJzcdto9ddCczYDnXJMMmH0FLAKWR1MYmRtIBaef3sufgzhlzF 81V+WpY6KStpm3kila25H4K608JnR/HOlOXq+lxose977x6H3v7leM/qL9OM35Mz/wD6uw3F6+lo sQFhLRuI0EdnEIsUZ5nDcdHOcIxa9nuKqxrKuQOplJTYa+l/V4qPKNFTNbYf9Rsuwc+9QcD6dYVH W43JHTwO2Bt3WszwAZVzd1B6n4XmOpnmxPC6DeSsqZCXNIHG69/+KHppL1M6TYzQUrf/ANJshdJT P9nALM4Q8qhZ2lvhicqG4hivTLqbQ0FXiMdBXtJ1QPmaCQV9Bn3NEPT3pxiWL4XTxOioqcvhjZ6W mw2H4Wovw/58q8ldX6DD814tI/DqefyZYZHlrWuvbuts+c8u0nU/pTU4Rg1XEaavptMczTqABHwp kxxhk2t8GPu8e72fFeFbrri3XvLeI4jilBHQtp5TEGs3DwsnAupEuD9aK7Kb6SOOjqW+bTmNmkg9 7qeGfolXdC8rVeE1FTT1Eb5PM8wHf91nRZawrFOtv8fhxmlLqWn8t1IHgu1e6LbFyro8z3uMb7OW 6ndaMJ6V41hNNjFWyio6wkOqJbBjPyV1Z4mOr3TDO3RjH6X/AFNg+ISSU7hGxsrXu1fC5HxtdGqf q50exCJkkQxCmaZoXF+kut2BWjXGsDq8Hxiqw6rdPTugeWOhEhO6qhBYvJ7O2NZZ5XCwInRMxWuj jdqhjldoI7i6+96fyQ0+bsGncwGMTsa7VxyvjcMp2fpHNbH6yNieVz+XK1uDy0c1Q2/kzNkI+Lr5 sueT9LBOKSZ+gTpp5dH04wYxNDWNomvs0bfbdeW+iPXfNuePE1mHA67Ew/LtPK9kNO0WsQV2p4XO v2VOp/TLDqakxOCKtpoRDJTyyAPFh7LGpPD5lTKfUx+bqXMcWGTVDi90LpGgEnnkr2YfGovcfn9S sjyKmc51+x6tyniOWcYoJnxufWNp3tA2c0ne65rrnjVdg/S6euo3PZOAx7pGEtIHfhdK+LXrtkrC cRydhFVj9LKyOvZLM+CUP0WtzZdpZv6v9Oc1dN6+m/1bhscdXTeXHrnbqvbb08rvtajCTXBx2tuR 9d0sxubMfTuhr6lz3+dTi4fuTtutH3i5poaDr3jrqenbS66pxc1otc3O9luR6QdS8n0HTrD8OZmO gqJqSIh7vOA1W78rT/41sQwzH+umJVmEVDKmJ8rtRjNxz7qqKampcWdcDayRro6t9MkLJD9pC3B/ TZq3TdEI2F2oNf8AbfcLTrBIPLLHD0t4svRHhM8YOMeHvMUcFVqq8vzODZYCeB7hfIx/yP0GZ7sd ezvX6tuS8RkzBl3MMMUstM+I0/8ALaTZ19rry5k/wpdRaHA4M2yZdmZg2lpFU+/B3utrFT4hui3W bKVPLjlfROpXASeVVEXY5cB1B8avRPI2Um4LRYnBjELGti/RQNuA29rG6+2tRugoUfnMSlhlJejt vw7Pnk6IZcYXAVH6UDUN+Fr88XXjB6gZd6l41lChxObDKKB/kyaW2dIDsbFe1cqeMDo7BlWknhzB RYZRsgDvI1AeX7iwWvjx49TOlXUWp/j+UawVOMvls/T/AF/K6aPZHJJ5Fwcs0J5NtGwfwUzz13Rn DqieR8gcS/U86ibj3XnfOeIPpvG/Hi1RDI2jikY1vpNl1J4PfqC4b0ewKPLecIJn4cbFk0W5jXqr /wC7O8NmY8Qp8WlxijbiTLEGWEh4/K5Y9QoZZSq74OmXDLHFRhxR3v1lz4/JfTivzVQgTPpIvMY1 22v4Xk3pR9RjHs95kjwSqyU2pqHuAaKV5va/PddfeM36gOV86ZJqsl5CvWedbzKwt0tAHYLzz4Nu uuV+kfVRuP5pmdG10YYAeLri9kMf2XJqGOebI3F0jcvmPGamDJE+IRUl6p1OZBTO97faVpa6u1U/ X7rk7CZ8OGECKq8l0YswXJ5C2I4l9TPo5TQETVU09wQGRx6gQtaniQ65YV1C63VWashwOwykBDmt a22pw7qY57cb4OmySypo9mUP0lsBdln9U3GqwYlPDraGy6mBxG3/AHWvXqv0oxnoz1KxDKOKPa+o gcXMeP6mdiV3jgn1KuqeW8uMwtkjZXRMDGveOBb3Xn7N/UjHerOc58y5inElfMLagb3Xk826LUj6 UcUlNSMWlLTK1xuXNXcHh3zTh+WuoeEPrJhCyWpb6ibDldQRxnfR6b9ykUpdVeYWPdHLTu1BwC8N 8n0GrTR+iOOSHNGTmPopWysnpbRvjfsCW7bhdU9A8kZ3ylj2KtzZXPr6cvcaVxdqDW32C1n+HXx+ 5x6HMGH4sXY9gTf/AGHE6mD4K7yzx9XWnrMCniy1l6Wnr3sLWvqP6SvqYZva4r2fns2PbPc/Rsap sUpMVxyenia2Sal+94INvheWPEnknOlZ16yjjOFz1jMFErGPZTNJ376rdlryyH44uqWUM81GZm4i +shqnE1FJJ6mkX7Lv9/1ecZptDG5Pjq3f1Pe4jddU1idxdnDJjnlirTRsS6sVsFD0kzDNXENjjw9 9y730rxx9NzrLgU78Yy/WVbKfEJZ3OgY82DxcrzR10+pXnTq/kusy7Bl5mD01UNMksZJLh7Lypl7 NGOZLxClxnDa6WjroXB7HRuIsb3XSMscccozfZ2x4ZylddG4fx/+G2fqrkh+ZsFeWY9gzDMGtP8A zWDcj8rmfAZ1qwbOnSyhys5zaPHcJaYpqSR1nOt3A7rwrhP1VOoNFlU4LjWBw4pIYTEam27ha1yv M+C9Z8zYVnqbN2FVc2GVz5/Ma2E6Wje9iAuLyKWNQb6OsNPJSlI3ZYh4eKiTrlHnyLGpZITbXhxJ 0C3ddl4/1AwTCsz0GA1VfSw1tUCWRSvAJWqml+qh1PpsGGHz4bTPqPL0frSPUTbleYs6dZc858zk MzYljdV/E2Sa4XseR5e/ZFJZEt76OKxyg2oLs3S+L7ofWdbunAocNe91bSyCWKCJ+kS8XBX2XRPK 1d096Z4RhOKWbJRUtnM1atFhxfvZaicL+od1kwPCIaKlrWzzRNDfPlGout3Kwce+oZ10x2hnop8X ZFFOwxv8tgB0kb29lVbjsvgzLBPfvSPuMx9MZfEr4xsy4dh9VHBBLWEvnDtmtB3AW0/p9kPL/QTp /HSxSeTTUsN555X/AHEDcrQTlDPmbspZilzDheLVFFij5PNfM07uPfddnZq8aPWHO2X3YDiGYJH0 D26HNAsT77rtmyQyuMb4R2WPJGNVyfX+MLrzhWfuu01fl6IfpqWYNlqGn/naT/8AiWyLweeKvLPW fI1Fg7posNxughbC+lmeB5gAtdq0pYRQuZUSumaZZHEm7u5XMYXj2L5TxSGrwiqmoK1jtTHRvsuG pzqe1L0enFppbHfZsU8UfgswyHqtR5owqaP+HY1XNkrg94ux2oXt8L3dgNJhXTXplDFh4jhw/DaE vZYjTs2/+StGObfEP1FzlQQUuJ5hqYmQEGMtceR3RjxH9V5cAlweTO1TU4bKzy3QSO5ba1lmc98U pPo5wwTxtqBt78MPiiouvFNjVHLJDT4rh9Q6Ixg21sBNiPdZ+VOiOCZB6yYpm+KpgpH4i03a5zRq J52WjzLWac4ZQnfVYLjNRhVTckzUzy1zr+9lzsvWrqVi72ivzbiNQ5u4e6c3W8ezlKVWYlhyut66 N4/WLo1l3rfhFLQ4lVM0U84nD4HjWbdrjsuRwjJOR8j0lO2KHD8MEIDWzOe1hNvklaIp+svUimkB izni1NH/APw53WWDjOfs55sgY7E834hVtj+0PqXC37Kv6RrfwR6d7lJRNynjfxTAMc8PeOQtxmi9 DNUYZM0kkewBXGeBrq7lAdBsvYZLmCiixGnY5kkM0oadvytL36rGJWmKqxutmpnbFkkznNP+UVNU 4rhLjFQ4jNAzkeXIQQpHLjeLxf2d46eTn5H2e3vENUZc6m+PLC2VFfSV+C62MkIeC0gWuCeFsOzD 1h6cdFMjyFmKUNJQ0ENo6WB49RA2AstAj46iSrdUfrKiKsG/nh5LgfysmqxTGsRpjDXYtVV8R/ok lJC5ZMkbVdF+NJRaXs7b8UXiDq/Eb1PlrSDHhVPKRTt/6QeV1gyQMqZY32DDwVxuGUjqR4c8aW8f K5D0SVAe8ekLjmzb30erSYPDDafcdEM00GTeqOB4niBIoKSoa+R3xdbjKrxb9I8cyDUSTZvo6eOW lLXRSPs8nTa1lo5qgwS3jdZhG9uywCwSyCM6pGA3sXEAfsuUZffcdM2NzVGx/wAGHit6fdKcwZ1w 3FKp9PSVta6emna0Fpbcr0tWeKvoLmrOOE4xJnemjxCgBbHE5xaBf/ctK9LRxP31uYR7eyxJ8JpD OSGB7j7XBK9WTNGT3Lhnh+I1FQTN4fVXxVdGcayXi1FPmXDMZY+nePJa8OuSDb91pCxCopqvH8cm pQP0klS8wD2bqNv8JM2DUsUTbQzRkncB+yOnw6IkAEtaPdZWdRhtR1x6VrI8j7Pa/gI8TfTPoNg1 V/qymmZi0sto6uNodpC9X9UfHv0Ezt08xrCJ8dFaaqnc39E5hBcbbX/dadarCJJZdpD5f+0JE2Cx gf8ALY9w76bFccc0pWz05cPkPSnhw8bGO+H/ADnVmAfqcmzVDj+gPZl+37L37hP1MOheK+RilRVT UuINj0/zILvbfloK020sTpbxTx6I+Bt2S58JpqeS7Ggk+wsu08qlKzxvStpV2e+fF99R2l6kYFVZ cydRTU9LM0xmqkNi4H8LwlgNKDhkkOq0pf5hPdxXGU9LUSyF7mnyAe65uGRvlhtONAtuVyyZVJba 4O+nwyxNtl0eO1mB18FXSt8qoppA9rh2IXv7o39VTEMKyzT4Zm7D4qySmiEbZI22L2gW3XgQNZ5Z Y4gvPcoW0gp4Xfy2vJ4XnUq6PTlx+VUbM5Pq9ZIwqMx0+Talzj/TEQ0X/suph9VnMdHnyrxOjyvA /BqjinqTdzPwvDTacsu4M0Ovzyr/AJsrm3a2w52Xojnas8UdJTNjOL/V7pMYwSow+oyJJI+aMsc7 zLt3HtZeHMO6wVuCdWH5ww3Do2vbOZ6ekkGzd7gL5OaisWywHRYbjlOc2CYxyPH80bXWVnaTijtH TJScmbAsL+sXX0dBBTYnkMOqmNDXOgkNnWXmfxeeKubxS47hFe3Cjg9NQNtoP3E/ldPy0MM7RJHJ pePlIjicSRMQ4Diw5XNTaNvApS3HZXQbxVZ76B4s6owKrnqMMl2moSfS75svRFT9WPqTptRZcodL e9Q31FeNI2MbLrjm8k+3ZZE8ZqI/5szZD2tstrN/RynpdztM746jfUJ6wdQcTw3EoJKXAaijP8tt G0gf3K5vB/qh9a8FphDVMpcTkI0+ZNGCvLRfLTyWYfSifWVBFi5rmjsRuuktRdKirSxUWn2fQdY+ seZeuecm5kzKyOGrto0R7AhfHh7GPtG06juSmuhkq3l7t/hGyDQRcbrjkyvJV+jvjxRxKogPYWMD /VJIT9pXIZdzFjmVsUjxLBaqfDa2IhzHxPI3SCSRqHbulS1LpSA/cDkrjZ0fKO7HePPrVFTNpaXM EtMYhpdIBqJXxmefFD1Y6pYWcJzBmuoq6Am5h1aR+9uV8GYojq0uLSVjMpWtuCS4+66KclymeF6W LZ9DgHVPqLkqE0+C5rxHD4HbmOGZzWrkcM69dTcLxWTEYs2Vklc4bzSTXcf3XxjjNEbN9TUyGOK+ qQAuPuvStVKJt6XGzMx/NuNdQMY/VZgxCoxKsJuDO8uAKRiVG9s8LoXaJe6AP8n1RNGr/sijkkc7 U8XP+49lxyZnkfJ3w4Y4VSE19JJ5IfO7Uw83TsGxvF8DidHheLTwQu5jZIQmPJkHq9Y9igErIz/y QLey4qVcmpQU1TLq8wY5VwOjqsdxGSN33RyTuIP+VxcTK2n9VHWyxH2ZIWrNmMcln2IPsltlcCC1 uwW3lkzksMY9GBUz1tZIGVVbVS220Sylw/ylnBzG7/l2jPOnZchUNFU8PsQ8c2FlQbJG8eokHkFZ U5Ncs1HGo8oVTUz6dnlsrKyGH/YyQ2/wUuTDYZJtXmPkJ7km5We2WSJwLAHN9imPqg51/LDSPYIs jTsPHF9ox6ehELAXT1EY/wBoebIf4dGZXGxlb33N1lGrMtgQjjksQQLBdVml+mVggvRiU8FHTSFw hLb9ibrkoYaQO1iMbpJa11zpsboPKI4NlxeSTOqgl0OqaUEjTINPslNg0P8AcK44/VvdPLbcBZbb 7N/0CXF5LSduEp1PHp0Pia8fKcG2QlrnH5UBjz4f5Ud4SGH2O6xm07Hwu8xjXSd7rknNd3N0p0AO /BXRTaVGNi7OKqmQiEf8Obgb24QCjjqqFz42MY9u1gLLknQHi+yptGAbi4+AtKbMPFF9mCyIPgbG Dew3JSzhjXAao2OA7kbrlBC1u1rFGWANU3NmlBJUjAhpGwNBjOlw42S56aScXAYX/Ass8xj8KvJB 7lNzI4J9oxfVHEAQNSVaRjCWtY6++4Wd5YIIIv8AKAQFv4Us0opKkLpLzC0lotrbIooqekcdDdUn +5MaxtijELeQpY2x7oVViWrAdfTbsUGl3lhrR6vdZAjO9j+yPSDzz7oa2owHU2o3JN/dA6EEgnkL kDGLIHRLViji3RPjlbILu0/0pxropJNU0DhY7D2WUY9W3dB+nBO/KNkoqGsvI+zdLXcFPmrY2xtj Mer3KUIAOya2MW4F1my0gGNhABj1A+xUEUZN3t1O7FN0ho3TYrOvcXHuraFCZBqHG3t7oWxaN2tD fwstrQeCi8oFBRginJJPJ+VlObJJGGk7DsmiMNRaSQAs2a4Lij0MAJ3SJqVpf5m5cFlBuwQEWdvw oQxzcjTbb5RwwxhpDj+ycG3dxsrkjay9rIDHcAzgXCw56YyG4sCs8D0kqnMG2ytgxPLfYB29lJIu NJWYGi3CEtF0sqMRrHgAXuAheHOaWnceyyy0XQ6P7pYsxm6Wx6CxDCA0nSNIWS5hLh7ImwtISydm PotumxNb7b/KMxqwA0XtuoWwHw6jv9ySyNwJu8g+yyfMeQSRsEJ9QvZWy2C2BrgbG5RtieGWvsUh jCyS99j2TzOGzsjN7FLMgywEuFzuFiVEJ13G6zqi0T3Eu27LELvMdtuoRqzG/TC+oi6p1NqKzQ3Z TShDHjgIH/T7KGADi4/dZQbtso5t+yFoQ1hH9ZI9imtbYW5UtbsiDrIWg2yaG2smsOoXtskhwcij dZ1uPlSy2SUb2tskvYNisuWzWC6RJFdlr2uUsouMbm4/BR+Swdt0Rgs0WKLS0cG6tkYl8LS25VNp gSLHZE8gtde7QOEpjncXtdCGWbNZpO6xJXhjrAhG6UaSL7rEcLuud0BZdcqnCx91GkXNkQcD2WgL LP7ISwX9051iOEJbfgqgX5YKosITQ1TTuhGJA0gbIhYb90R2PCoiwuoZITqO6AteQblUDpdc3IT2 Sh3G35QtC2NLbXTGtueUdgq0pYqywAEbWC91GtARAgKMqRerSha4E/Kjjf8ACQTc3uoUzHHbhLLb jZFC8d9wieeSArYF6bjhWGC++6JoNt9lIjckEpYBIt2ToYS4E9kAtqTYWukNgbBLAbdtu6IIXnRt wfdSN1uTcqAkj9Db+6uP+YLlVJuNxdRuzDsQLICowHvN+AsaVwEhAWVTOZ6iTcrEnIdLdvCAhsVV lNmlU526EohHKFzeCETXnVZGQB2QUYx1NPunNYQLk3V6bORA32VsAW5NkIdc8JpFuyQ4nslighud lbjZVGB7phaDvdLIgXbhKGwNjcpzmWBSQCO2ytloh3A91BwrZ6d+VNDi654Syg6w3Yp8ZBCVUR3s Wi/4TIW3ZY8rII54Y7i6gcSCR3VloJVtbZRgjGja/KcAC7fZALA7qnOH9lAN8uxUDQeeyxm1ThwL gJzZWvFuDZLA4Fp2VeSHC/BQMcC0/wC4JrXbAlATQAy1rlBFA8xuAA2TA+5Ok390ioqKiOM+S3Y8 3VstmPrc15adgmCQEWSjIZGC7dL+6uFl3D5VsGTG4ixITy7SLpbmeSWh52QyyAEb7KNmi3bi5PCR cm6Im9jf0oiG323HwskFt3FgiBuUfl6RsULQboSiwCheNTflGAVRFgFbFCri47kImt8y5OyLyw4X 4KEssrYoU52l+wuiBcDvsCqe0hw7n3UuXCxO6WQtxsfSboS4lyjRpuja2/ZSwRnNlduVQADrX3Vp ZUCWqrWGya1msGxsQluNnWabFWxRbAHEDunuaGEA7JYYWvaRuEVYQaprRwsmgPL9ZI4TQFZDW2sq cwg6gfT7IQPcC3dDva1lNW97qB1xcoUJrrKA2O7bqAhEEADmEu1N2+FHFrhvb8Jh2WPK2xLhygCN mCwQAHXflWxrtIJ3ureSCLICnRgvudh7IpIWiMOj5UbZ/fdOaNOxKEMMOJ9J5PKpkbWP2HPssnym Al1t0iQPuS1UFPiOskLH8gk3cmiY39QUkGp1gb7XREoWA0DjhQt1Cys7DdWGkdlocCwyxFuO4RnY gAWCMN9V0IF327IKBdsfhDHLpk9O5TRGSTcIo4GsNzsUFEnaJG+ocpD4fJaLO2WTK+xtyEP3ixG6 FoRJsA4ce6trC5hN0cjdRDSPSqAaxxa3hBRQjJZe6Y3dluXK7gjlVGQ5+m+5QUF5LnM1FCQ5tje5 WWxpjiIcUPliQNHCCjG1OkvtugcdI43Wd5TITrJufZY80Be642uhaMcyi1kNwnCAtOki5QSQNtcK 2YoB/qFkBbt8ozZoVE3bxZVMA6C1pN7pRbrBvuj9Qab8Kh9hstWShIYACseVzSRp5CzCCBusdzA1 2yWKFvic9zTZVJE+9gdlmhtgLoRB6gSditJko4uSlc/e55UlhMbQQd1yD4vWGgGyVMy502slko48 NLhyjsRunGHyzY7gq5mMhDbnc9lolC3t9II5VE3aBayNvvbZRri9+wuhRbxZoHuo0Adt1lMY1vrP bshdd9yG7KUDHIIG4Q7g2tdFPIQ3TZMpmtiAe839lQLsTtb9kD3AG1twsmRgc7UDz2WPIzQ/URdQ lATMfJPCG7NHKuVhEhsNll0rHTnV+wSZqkR1JiI3HdUlAaTsfZW7U0g8XTHA6dXZC6QDSbXQdAhr ebbqWI4CKSQvdfSG/hQ2cNzYoAWbd7FGedQ9ksNsb+6NmxseENIEytBs42KMaSNzsqfCx3PKCxbs N0MsjQCSOAr3CHYflQP3QBG9hsrJBHyh17qG1kBcbAG2vf8AKmu92hULlW1oB+UFlgbKieyh5tex VAEHdAF+VQcCdlXJVFtuEAVi4/CsgDZW3ZCTc78ILIW7iw2UuWu2V3/sq4KAK9+EAFtyiPGyob88 qWASLqWPKs+lQEkKgG5RkAgcXUIVAb7oVFEEmw2V3NgByoSo02F0DIW8K9N+FHEHZQksAsLoEC4X Om91NIPBui2vqIs5UAOeLoUmoe1kTi0224VXAuOVDwpYJq1jYWVOjdp9lY5Vk32PASyWLfG0ix59 0LXAM0lNc0PO/ZCINYJHZUWC7YhQ7O32VhmkG6rSQPVwhAtWyGR/FuyIgWFgpqAFgEKiF5ICG22/ Kc1t47W/dA+zfkoGgYiBt3ULdRUDg43Asi45Ngs2ERzLgfCrVY7kWVPna0aeUhzryXvt7IUa9wJT GxEtBSjJG6ycOBZyrIzcN/pqKB7tMYF+NljYlgGqlkBG9tl9p/LHqJH7rBrS2SOS/AFwv4zGTtH9 KlBJGrzrPgr6Dq1iUYHDyTZcHTMZq9RIXY3iFjfSdVMcme3SNPpK64w+B81E2Ymw5K/oeiyb8MV+ I/J6qG3I2Zwa0iwXHVt2ahzZchGBpBuuKqpi2WQcgr6Mezwy/TAjeGPva6t7i92o2AROtawFkEg9 Fl60cRE7g1hO10mE7aiqqHXbZAyQuj0C1lowZ+omIuuD+6GGUFt3A7LjBSyxy6mykj2WbHJo2dys sHMQyAAEG2yyW1foOorhBWgei9gBykyVxdcA8LDRpM+mZWs8saSluqmg2GxK4COvJAvyiNXd2rgr NGtxyFdiBawAHcFYdZLJLA0MvvzZcZVTl8gbfZW/EnwaYxcg7FUl2epPBnkWixLM0M1VA2cg6jcX W1zDMMpMu5NqKunZoZT0zngAW3AWsDwT49SYdjwbNIBrFhc+62pUhixfp9LRQEPdUU7mB35Fl9TR 90z4P+Qm1F0apo/E7mXE+uMuMYhVvLKKuMUdKDdvlh1ltMyHW5f62ZFgbVFtRHLGDJDfvbutOeZO m+J4D13xTBZaWVhFW5weQbOBdtZbVfCZ09myTlP9dXzlrZANLHHjZeudxm0j52FPZuZ9nmlmX+gv T3E5ae1NC2F3lsvyfYLyP4Ps+4hnTrNW4pVVj5Wyzv0Nc7ho4C9c9bck0HV7JVXh8FbHJOGuLNDg d/YrxD4a8sYp0v62DC6ylfFGJS0vttyvXBvY1+ki03yz1x4hOkmPZwrGYtg+LT0JiZcta64t+F0T 0/614vhudaHJWLzvxK0zWCZxILd12p4w+sGaOnEWFRZepZamkqR5cz4he110R0h6W5rxLOdJnXGs PkgpXSh+qTY+61hilFSZwaudRNg+KY1h+FUkEde+NkczQ20hsFj4fljDcNMlXh7I4o5fXaP7Tsuj /FrVSx9ImY1FO+M01nAMNlXg/wCpWKZ46as/iDnT+XtHI/m35XDxNQ3Rf/J2eRXVGurxxT1dB4oM Qc2V9OJGgNeOWn3Xu3wKZrrMydPW0WI1D6uWmFmySG5I7Lxt9QzATJ4iaB0LbyVAAIHcr1t4I8iY 7kvL7KrFmCCmnZqDXDkHhZypOao6YmvE77PL/wBXTDqWhxvLToIY2SS6i8taAV4Iw/y30xaTZxGw C2CfVPxLDMcxKg/4mP8AU0oOiIckFa/MNhY6kErf6Vx1caaPd/jpbonaHh4y3SYr1BwyOtAfC2Vp LXLeL03y3DQdOI5MHiYyp8n+UAANwNlpD6FPbBnXDpW7a3W57rdl0ZxGan6Uxua9wqhD6Li+9tl4 sKblwenUyqPJ110mk6sR9Waulx6nezL7rkvebtt8L5HxYZUp8sdR8s49h9PHS1E0zWmaNtje6+f6 UeI7PTuvlTlrGq6Oupn1DozEG2LBfZdw+LnBJsZwzL/6WF81TFUteQ1pIA919eUayLd0z8/B2uO7 Ozc6ZYwjO2R6KPHJA2kMTJHvcbX9PuuluoPiJ6cdCen9TQQ4vDI5kLooI2PBJJC7Fz7lPE879E3Y TR1JpK2ajEbJQ6xaQ1aIeq+Xsdypniuy/jtVPNWU1Q5pM7i4Hc7hIVGF37GxZs1ez0X4cs1SZj65 Pxpsjh+txAOZvyC5bVuv2CnHOheLwXs5tHrDvbZamPBvlKuxbqLgrKSMubFM15PYFbhOoeD19d0h xbDoWF9ZLROiaAL7kLlHIp5VJ/p79Th24tqPMf07K8NOY8Na0CONwcCD37roX6qlJU0nUDC8RDi+ B0JDbm2lw9l9z4RuosPQfqZX5ZzZG2jmxN+iOd5sGm+w3Xd3jH8MM3iSy/R/wiRgqoHNcyW+zm8r 1zlFZpNdUfKcV44/0afoPEB1Ky7hDsPo8yVrKPR5fl6yQG+266+pauoxieWeokEkr36nk8k/K3PY N4J+n2TOnEMWYsCgrsRjgcZ5CQDe3K1Jda8EwTL3VjFaDAXj+H+aQ1rTszfhfMyL2foNLPG0tqo4 /AaAVOIxvebsaRcduVu58C2TsKoOl2H1sFNG2oewO1houtJGXK5lHWMY+xAcN/hbjvAZ1PwesyJT Yf8Ar4hLGNOgu3AXmcbZ9CVOLO/MfzjQUWYpIqvNtNhBYbeRO9rb/wByF1v4juo3T9+R5pf4vh1b jUVjSPgkaZA+/IIXw3iL8GNf1o6gx4jQYz+kwuT1SlkxDmnuBZfNY94EsmZNy5Ga3FamTFd/Kknl u0v7clfZw48bcXZ+YlOVs9W9GszyZi6U4RidRIZ5TT3e925JC6ny/wCMzJ2OZwxrLeKmOlFK5zNU p9LrbWN12L4fsoVGS+mEGFVlRFPa4Z5brgNK1W+OTpZV9N+reIVVLNLHSV8pmDmO2uTe2yuHFjnO cZeiZFNuFHv3oF1ow3HOrePYBg0nn4Y9xkja0DTGb9rL7Xr54ksL6IZjwmnxcOGHzi8r4/uC85fT f6eMoGOzPV1UZnni0hjn2d/ldn+P7pnS596Wz1tPVQ0uJ4f/ADWyPI9TByFmMcc9QlLo65Y5IY6X bPscteJPpb1ZrqaKgqW4liTHAxwPZdzflV4wOoGKdO+kpxjBpjTP2GxLSL8LV/4QOpuFdMerkFVj 0sQjL/L829hytp3UylyZ4kMgwYSMx0kVNIWyEeYL/hefJsWSl0h45whb7Ynwe5zxjPvRyLFcbqnV FRNcevewXy/hszFVwdY885e0iClbOZdG4ubncL77JNLkzw95Ako/47Rmip26/wDmtBNh7XXwPQPO +TcVz9mXM4x2ip5q82jjkma2497lRRVSpcG4yktoPiO8Wn/oT1Ew6hqKdz8PlH817x6APe/uujPF v41+mmbemFTQ4fX02J1dVT2/Sht3McR7r7z6guS8ldVOnLKx2OUIr8PcZIzBM0vf8bLTrJgkNRi9 UYGu8iGQtF3XvZdGoRxp1yTDhllyPcxNDAZoXvNw50tw09hdd19FpIafPGFVJaCQ8AC3e4XVMFN+ nlLrh22w9l9VkXNLcDxqnq5GnTC8P2+Cvl37P0KjUaN9eCYu6Ho63EYNQe3DtTQN7EM7Lxf4ROoe IUvXOvOPVU1VLikkjI9ZN2b7bLsrw8+Njp/jWRKTC8bxGOhkhjERbINiLd1z+BZx8PuSsxz5jpMz YazEJHa2sdMCWX5sF6sck4tH57URlHIn+HO+JCofg3UHIddTPMc5q9MunlzCQuY8WkFZVdIp8QoJ XslpSx40GxN+915G8QnjSytmTq3gQoKxsuD0ErXPnbvex7LtXqv41ulGbej0uGYfmWP9XKxodE4H U0jkG67qFKLIuVKuj0j0zjkqOjOD+dI6aWehBcXG5uW7rRN4jtGG9ec2NczSW1T22tbutpvTzx99 LMH6a09JieJiF9JTiLSwgl21tlqw8R2bMAz51axHHcuvkkwyrkLjJILEm61FpRkmdsUJLImj57BH scGEGw1DZbffpv4/BN0ynohMy7X3Db7rTjTvYJgInWAF+V290Z8Q2YejeM09Zh2IvjhY8OfCXelw /C8ap2j7uRbse1Hs36rXS/Gs04zlTEMMwyeuj/8Avdzqdtzudgf7rq7pz9NzMRyUcy47UnC5A39T FS39RaNxdegcs/VO6dV+FU4zdh/lzsALnRsEgJtyAvn+sX1R8h1GE00OV4Kut9dpI3t0gs7iy+hG UpQUZLhez4STwtqKPXnhpr5T0joKZ5a80LDA0jvZaqvFfnfqDgfWbMeGYzjWIPwuoqXOp6Z7i2MM PAC9XZO+qn0pwjLsdFUYFV4Y63qZEwaCTyvKvjV8VOS/ERHhRyhQPpq6CTVLPK2xLfZa0044ZScl /wAHDLjyZHGuj3r9NmlEXRCSY/8ANlqD/Vc2XUPXLJeK4Z4v8NnwuknkiqaiOaSZrDpZvvuvMXhh 8beK+HmX9LWtdXYG4gyU7dy0/C9Q4p9W7p/G5tVT5XlrK7Ts4gXH78risjjOU17O+TA4pKPo9v8A UXEJsOyvDMHtayINfM922wtflfDdaKXEupvQ+b/RVU19XIwOidGdyR2WtrxF/U7xzq5gzMHy9hZw GiJPnP1anyD2XznQf6juaujVKaB9KMUwy5P6eYbg+4KkY7YJp8o5zjOUnxwbS/Dbg2acq9NYP9aV gFa0EujcbeWB73Wsjxs5jwrqX4pIqOiq4ZIHPbA6eN3pve3P7L6LrH9V3Feo+R6/A8Ky27BqmqYY zVMlJcAvDsOJ4hUVTq6WoeawkvEhN3Xuu8MsYRlOT5Zzhpsk2uOEblelfgY6T4x05o4MbwePE6uS MPdVagSdrrVl4tumGW+l/WuvwLLDnnDWSENjcblp9kWCeLfqvlWkbQYZmyogiaNIaX72XW+JZixP N+YKrEsaqX1uJTu1vmeb3K+NbbPrQxyUuRr6N7QXGo/ltFjGeAvuenOKw4Pj2GyzvDIWyB5cPa6+ Bp5GCcslBe1xuSuZnmjc1hgOhrRwtLlUe59G9fw89UMvdUumlLhVNiDJ6mOn8qWIOAc4W9l8n0u8 L+KZJ6n4hj2I47VS4MyQzUdG150jf+paeci9dc09L65lbgGISwTRnbQ8gLu1n1SOsRw11Ax1HJG5 hYZXx3fY97r1YpOKai+z5GfE3O6s2lVXiLydivVKnycypjmqgS101xaN47L4Dxo+HPMXXb/T4y/L EyOkkDpxNw4XvstPlL1YzAcxzY6+ulhxSebzjMxxBa7nZd4YJ9RnrXl2kipIMZgxBkYDWOqGhxA+ V1k4Y5ReN9HnennljLd7NvWSMOqsn9KaWgxryYpKGiMcmk7Wa0rWR0E8SuB9I/EfmLEaqUtwWprp IXaBwC7n8LozqZ44er/UiCSkxHHn0Mco0yR0voa4ey6TpYfKe+epqS6WQ6i7kkpDMoxkv06YtLJy Sfo3x9cOm2XPFb0ifDh9XBUmVnm0NYx1zG+3+F4/8LPWGLwpdRqvIGcH/pYamXynSy2+4Gwdf2Xh HLniW6l9Oqf9FgGYamjouzQSW/lfK5gz5mLPmPvxvMGLSYliZ/8AeedwuCy/Xxvo2tPNTs3sdUvD 5lbrxmPA8yvxCORtKGyMbBILSjkXsuN8Q/iSwjw+4HhlJDLBJVROZG6BxBLYxYH/AAtLeD+IvqZk +lFLg2acSoIALNayU7fhfP5h6i5sztiDarHsWqMQqD/XO8uJXrg8fDnK0vRylgmr2qjffiNZl/xJ dITBhOKxso8QiBc6N41RkjcEdl810A8PNL0CFZUSY951LIb6ZHANHyStI2A9X88ZOlH8GzHXYawf +3FI4Mv72XI4/wCIfqpmCjdSV+cMSq6STbQJyAF5t1Jxj0yPTSlNSa5PW/j/AM8YB1d69YNlvB6+ KrqGHyX1DXAsjufde7vDx0/yP4eOldKTilKyeOBslXWyyNudrn9logjOIRVAqY6lza0eoTavXf8A K57FOoufcWww4dXZoq5KIixjMpIIXWeVTgoX0e7HpHGD/WeqvH34zIer+aJsq4BpkwCjfZtQ3mV4 7/hcx4EfG83pLjMGVMxv0YDVlrWyHiF3uvB0NKKZxkfIJpvdx3WWHtnhJIOvsWncLjPPcVBdGsWm WODXs3m+JfJvTnxGdM5hPjmHOqYY/NpqqOdusfHN0rwqZv6a9MenkOAQ5kw+mrYLmoM0zW6iNr3K 0csxjMdFAYqbFa2KncftEzgP+6AVGLu9D6qdwO5tKd108kZY9jZ546aUHcTa/mHxpMpPEo2mqMeh kyfSyhpfTv8AS7f45Xfmb+rnQ3q03D3YjmfDnVFHJ5lM98gDmO/BWiqBrWNJmqZA8+7id0eqJzg5 1RI9w2BEhBCPJjdOPAWlyNcn6DMV6o9N6zKLsPq82YZ+glj8t+moaCW/jsvm8pdX+g+RKIU2D5nw Oh0/c4TAOJ+T3WhltW6LY4hV6He8hICXV4SKkA/qCWv/AKg9crXpm/i83JG+7E/GX0goIpmuzdQ1 LWtcT5LtQO3C8PdEfEr0+wXxM41jNVXRU2D1FQ40873bMuStcZw400ro31Mp+Q7ZVG7D4yYZ5Hgk 8jZdI5IwTSXZtaX3Jm2/x5eK7p3mvo7Lg2D4rT4tV1E7biMg6Gjul+EjxS9EulnTinomY7Hh1d5L TOJRa7+4utTv8NpGjzY5nzR+xN0c2EU9XFqhAPu0GxXN5fooeirSpNyPXXjp8btX1qzG7LeWqwf6 ZhOz4jtKfe68hwRshjP9Uh3cUuLDaenfG2xa++5d2WdHBK/WQxvljbUuWXO5R8a6O+HTxwu/Zm0N XLTNjkHPay2AeDXx4ZI6O5NdgWYJHQVOq7vZa9Xh00bWwyjU3+kooaeCuPlVkTBL/utYleVyuj1y W9Ue5PFD45Mi9V874DiOA4XK2bCZhI+tkH/NaDwvQlJ9VbprT5XgbJQVc87IGsMDW8m1j+y1PNwi GkdZgDr8bK4Y3Mm/mQMcPhev5KcVBrhHhekVOvZtPwL6s3S2goHUz8vVlDck6ImAN/svI/jZ8U+U PERU4VJljDH09TA68s0o9RHsvNElFC7U6aIgDcI6WCM0rnRRsG+21iu8dRHGm4dszHScpy9H1nTP OkOQs20OOVlMaump3te6IDewWw+L6uOT8MwKkhocu1U7o42sMZ9IBstXTq+WjDg8bf7bXuqiFovP lga1jjsLWXiUrlbPZkx740menfFh43H+Jj+HU9LgjsJgon6/MafUd/dfQdFvqY5z6P4NFgtZTMxz DIBaMS7vaPa68gmUshNow252AKssYIw58V/2Xonm3JJLo8sNLGK5ZsHxv6x9dX4ZNBR5O/R1Lmlr ZjJq3914T6h59xzq3nWpzRj0rpZZXlzWON9I9lwVNG2pc5jWaR2KzYoI6YNZOdVj2XJz4pHSGmUZ brscaJk3qfNpd2B7L7Lpf1LzR0pzBFiWAYg6KSJwdZr7B3wQviKoQTv9Lr/F0ylpWBkgicRIRsSV zTro9koKSpnt+L6sOfaDD20smA0clUxtjO8Xv8r4HNH1QusuNsdFTmlo6cgj+REL2/K8uYUZIHzx 1bPNd/SSbrIp3HRKNLe9hZbjk2s8L0iu7PR2XvqQ9WcBwx0MMomnJv5swJAK+Q6l+NXqh1goDhuY KiCTDnHdoZa34XUOHRYhi9XHQYdRuqat5syJguXLnMydHeoWU6JuIYnl6qioHDU5wiOw+dlr5Mou 0jm8MFLk+r6aeJbO/RimLct4jJRMebujb9pK+/qvqQ9ccUpZKR2IQuheC3VoANjtyvOtNiNNUeXG L2/q1cgrIu7WWi2jtssLM29x6ZYlkikPxvMNdmPF5MUxSYMrJH636NgXe67OyR4r+q/TzDW0GXcy TMoW7BpdqLB8XXUkYYwva5gfc/1dlAJKbeJwA7tIVc5TdsrxRcdp23j3i06yZiEgdnCuiY/72MeW h39l8ZhPWrqJl3FJsQpMdqDWTCz3PlJJXyU08xma9slj/tB2Vk+UT5jxqO4N10hk28I5fFi+T67M PiU6r5iLaauzTiJZa3liQ6bL46AVNbWT11fUOqKl5u9z+SUxs7mvGvQ/sCCic5kUbtTOd7hc5Skz vjwQg7RDKGhzQCwnggcI46oMgtI65G245So60SNLG6Cfk2S561sDNEkBc49xwsc/h34OTw3G8ZwG 9ZhGL1OHSe8DyP8Asn13UfOOMx+VWZixGqbbe9Q7/wCVwsUz/KGgWYTuHbJNViH9MXoI/qtdaWSU TzTwwm7aCnhnxWotUVc8r+dUri6ybW4fV1TmsdiUziz7WiQ2CqnnkiiErJWOJ+490T8RhcDpdeQ8 kdliebI+mWOHGgIYMbw1t6XGauFrtjplP/yktiqKSX+ZrqXvN3TSbklchRYlTWDHSsMo/pcbLk21 pqW+U6NjR2IK88suWXDZ2jhhHlIxDG5kYDAOLlA1rdIbJHqv3RzsNO7SXXv7LGexzhcONlIto6di n00pmc2nqJY2EW06tljw4WH1Dg7VI4cm53TxHIJAQdgey5OOoDW+llndyu6ytHB4YN3Rw9Tg9Lps 0ysP+3VcIaTBY2uBB/c9lyr4/Mkv2KMMAFhso80qOnij+GC+kjfqZIC+3BA2XGz4DHLIXMjaL+ws voDG4cd0p5cFFNrkPGpdnDtwz9M0MgAa8jkpstEKinDahjXub/Usp8Rc66B0byduPZRycuyxxxh0 jDhpqd/8pkTvM7OJ2TYo20MpjlIa93BanNaYiTpsVBTNqiHHZ3uVd7qjKxxTszHtgqmhpsdt9ktt C2MegDZBFTind6ueyyPM0t2XNs6cBwm8ZY4WSmVRp5C0NGg8m3KsSBrb8oHO1nfv/hZFiSHNqfME oAd/SeFkMpWPY50pjc7kWCxpKcOOxTKeiHJJWlJrow4xfZkwSlm8cgZ/0psz3kAxtjc7ubLHdD5b fSN/dUI3DSTsFdzLxVGNiFLPK2PRMWb7t7KS0nmRNaTqcO5WY5oIve6rQCRypuZKRxpgmOxcRba6 T+ge94DnjQDf91y0kZA3KS6HV8BasUKdB+mka8yuIPa+yyIPLl1iU6mnghIdTk97rLow0Rlh9K0T arsxzRxwOD6eoex3sSm+W6QB0j/MPush1My/uFXljVYcfKu9o0hGkm44B9lYd5JbcarcGyZp3UDf dc3Jsu0a8ec0ODvLePZXrbMweYNb28OKCIWkueEx8ZLvTsFLKW9/mRadIJRxyQeXpdT2f/uVthbp FuVbmW35CbmUAuPLb29lCA4i/PuiFnfCJ7WvaGg7rNsgiSNsbfV6gk1RjqmAeUGsH+1ZJZp9JNyk uAvbsm5ijCqYPMjtf0jslta5x3Oyy3xhyF8Pp2NlLFC27gi26CL0SerhSSGeNmphDvhD5TnAatir uLwMlqBJcWNh3sgadQI7KGEtFuypoG1lLALaYmT0n+6yv1ThGYzEAfcBCL322VOFze6tgXqfC4EA pzXjzATsfeyokgWVNdqfuLkIQy5akF2i+va90o27JcE4bUPD2WuNiifKwjblCku7sUp2q9ymNIcN t0RtZVMCZAZmWPPuk/pncncrLAF+VHEX9lbIIikdFGYiPQUUDLA2FgiG/Ka30jaylgxTDeW5490T y4mwNwEwAnc8FTRa6goS4u22Qke2yfpuo5vqsp7MsSxrwbBxt7LNgpmuZfv8pbWhjgdlHym9hsqW xzYnA2G4Rai1wBF0hs5Yb3umCYPF7Wd8oLGOijcN9rofIaB6b/3SHve4drfCn6l7HcbIWxpsCRyk OYCb2VEO+4m34RN1Oaf8IRgtaWk2NgrLDe99kcYAadXKkzT5ZQgNwWDhC8ahawSonG/wml1jcBAA YARzuh8vS72RklxuiNiEAhzT33CEwtIJTyG91QiPIKAU1mluwRF3oTBYA+6TsTzugDiAsdRUcAEL bhFyEAmRgcN1TWACwTHDfhQNQCw31cImxg8orW3Vj87IAPLUAawE6blHfdEGNcgBjDHi4Rte1x0g cITHp3Gw+FR2tp/dAGWgnhQWJKsE87omuBUotEYLg25RAECysWaLjlUTff3UotEsFLBu6g3KGawA HdKMlF/JUHqGwS7Eu/KawhpVsqBLLlFo2CLYkjgKtV+6WQRI27rJLnW2sszQHm/dC6HzNm8qotGJ e4CNht2V+Q4vLT6bI9Om4O6CgWi43CosN/hGG2R2QgjyxwoW2RAWddFe90NUANkLjdG6+2yGyGQQ 7+yhU0q7K2ABYqFoTAzY2U0fChRenhEL8KyLEKrfKEAkic8CxT2xFsY0oW31W7LIZ6vSgEwMsT7p 1t0WgNFhyhdcICOJUvqFuFRcUQFgL7qWUtrTcboy0ON+wQcm4KIHZLIWfRulyO8zZW8n3VaxayUC tJtb2U90wObsENg66IAoXI3HZA9ACBqupp5UHPClksFabbWRNbYbKx23V2uVTQDvZVp1d0boySqI LCpZkAyhrHM5JS3DS0dlZaC7flXIPkFLABFgLclU4aiCdyO6ZyEN+yWAPL81p1G6CNoBI9k5zTa4 STsTblLA4Fo+UP8AUdksPIttdMabi6oKLnAIwQG7kEoTt8IfLDje6GhpaNJKFjCL3R9goQ5yzZKL DBo22KEMJVkk2VgkgEoQNm+zt0d2P2O1ksNFr3QlwI32IUNIZoYHblDYFptZCXNADr7IWu0nVzfh AR7QTfgJMgvM3S3b3WU2Qu5CQ53rO+krSFCnQHUSePZKH8xxbwsxrhbfc+6BzWg3sqZFCiaRe9yq lja2Ow2KyWtGxQGONsmp+49kBisj1x7nZCGG5sVkPcz16dh2CW0Ad1bABbx7qDcojdW3flLAJAG6 XqFztdNIuqZpYDfdyooSWBx3FkQFrAImnUSCrcBa4UYKDvdH2Sjudt0beFAN2spt3KSTtymlodGC D6ggL0lwAtt7rGrWOogHch3sspry4aW8pU7HFumTcoCqZ3ov77rJDrBY/wCnDWMaHbp7dtjuqwWd m3PdRoDQDxdFpFrWv8qHa3woATYX3QOmLANP7ozbkqnFjm7C5QDhKZ23vYqEhgDr7pcQ0tv2KKUN sPlAPLrN2F0ImNiNisdk1nD2CY1pdchANiPpNwAPdY8zAx1wNinAMt6jYqpNwA03CAxmU5e7lSWA tJANyFkFpjAIP7KwQTuEBhAPY4d05sTib83TDHc7bKNDo9juUBWmzb90qMOcSSDZOEbgbu/KuR2n hQFOBDSsF92uPyssuc4bK3wja43SwYsbSDdPPpG45TGxj2S3g3tZLADpL7AbKaLDfhCxpBJIJTA6 w3/yqBcbSXn2RybNshDrO2R6NSgAa4gAW2THtLRdu6JjdPKMNLu9lGBDHHvynNNzbiyWW+vYcKyL vtwoAyA42BF0EcRuTZU6mfqvew91kMHltAKAS4Fo9Ld0TbnmwRv+EHIQFNHqIPCZewsl6SeeEIPq 2KAYNUb7j+yuaXUw2G3sqcNLdV0mSRzH6bbO7oCm+p3P91Ha2H0gXU0atgeFA5w2tsgMgPMrA5+7 glvNyqiaWgi+yJxDhZClyWMYsN1IXEi3AVsA23U0b3CFILl9uyvQQTvdQCyp8mht+VSlNFzbgqwQ DYpXqkIe3YI3SACw390JZb7NO26APL/wFHDuFTBsbnhQlhki2kIAO+2yttwPdQN42QgAF7lEHlrb HuisOyl7ccICBuo77FS1hYqjdxuDYhU48IaGQAB1+5UkptLr2vdSEEJm4O5uUKSOOxuT+yS9l5tQ 5Tg+53CHTaQOQCnMeCSRsmB50gdk6QmRhAAv7hA0AICiNKtqpxGpUDvtygGgewUJsPlFwED9wgI5 +yHUPa6AgjfgKbk/CAIk29lHuNrDmyq+yhcdgOUANLH+njc151Ocbgo5rhgIVzEMYDbdLFTrZpcO UIKc94cBe90TXPbsNyikZpc3e4TIxqcT2VAh7y47ssAqJHPF06TY6exQOiD277AIUW5oIFt/lG5p c0AdkTLNZa1/lEYy2xBsChBTgWWBO6HTpBPdNLPVubhVK1rmXCFKZcAX5Ksn1bpTdWoD2Rm60CpD 6xsmEem7RYodDncC6cG+m1rFAYpuZLdj3R+U0b3urFmvOoXUksd2/wCEBYjafhJjhvW7cDushjQQ LXF0TWBrjvugCmfZtnIYHmQWItZU5l3C+/5THEggDZYATQDcFCWlzgAbIzs26FuphuDurZomn+Z6 hdLkY0OJTPM1uuhtrJcQrZmhMrGtaTZYzmk2AWZUG8WyUHhzQGt9QREaEOi1OEfLihNK6J4HuuVp oWtbqeB5gWPJG8lzni3stWSjCfGCLHlLhh1NcWtLnLIfEWsMp3HsFKWFtQ0yQS6HjlpUsGM7aQNI sbXIQAudJYjYdllOoZnSeaXA2VGEkk23CtihZa61wEioBFnBoJXJCIOjF9kMlPFGRZ2590sUcYYy 4i4sPZKfGKmqawt9IXJiEiRxO6xo4rTucAbhWyUQ0bS/TfgJM1MI2nS7Sfhcndrmudbc9lhupAbn UVdwowHRuIHsUbGvjaRb0nus+KjboOp1va6MnXAWgXsruFHCmm1Hm/5WU6mYyAl5uewCc6n8wAjZ WyC5sdwlkowtJaGX2usqOAPP23B7lWykD5xqOw4usyOJ4Nti0eyWKOPld+nlaxjSR7rGnpWukMjr XPJXM+Rd9y26xqqlAfe2lp7K2KOMfEBHq1bDgJZBFiBcFcy2lY9gba6F9FZgbpHPKtko4eYubYW3 91bXgAaiC/5XJVNMXBvp1W7DukVmBljW1INmu/o9lbJRjNDXu+6xVAgPtdOp4gDu1FNTs+9jd1AY 5Ic4pTZNzcJpjLnE2sgfFpcVolE1C6JVp24uq1EO0kbIQgBc9R+zrWRABhuEwt1KWBcYve3CtwDd +EbAIwflSRvpSy0KaS8oigA35RbNO+6pShyrtvsppsbqwbC6AjiRZCTbnuiv5gN9kAbc2ugoIHZU SL+yst2sTZDYE2QyERdQixUvpuhvqKlAtzb8cqC/J2VkHlA+7lQGbnhQnb5Qxgg7q3N3U9gjbC99 wo2/fYdlWg3uj1Nt/wCEoqJaw5VXA4O6oes24CFrA1xJJVKGdRtdXpHF+FXnN79lA4ON27hCWRzb uuFYtt7qi6yEusd+Fnoo4WceOELmC432QmVrRsoDq3QFlrQQbqaLbgoXHcBU+QMIG9zwgojrg7qE l1gUTbgbhQtLt/ZVEooN337IATdMaQ47qOaLGyWUpklthuFTtze2yENLeNkbST2SwRjWgX4VxMa9 xJN7IHv09gqjOkXCUCSxea4EDYcpPlh7yOLLJ1PLDpHKqAsYS1ws4pRGL8prQSBeyoTG3Cy3tZ5L 7ey4tn2jcqMhuPoeoFNOwCRl1lz45BWNcYzZpHHsur6RjYWbXJRnGZsOgne0X9JtdfxuOPk/pDk2 eVfFniMdT1Ad+maGuLAJLd11bhDHxUwY92x7L7zrG19Tmaoq6n1PfuAey+Bw95c5zjsF+90DXiUT 83rOZmfKAyP0n9lw9UbX/wBy5J79VyuKqwTLqX1oHzZ9AjYb91Ujb2uUt0m3uqdqc3fj2XoPOY2I xgNGnf8ACwY3Obw2y5N7W233SQ2xNwLLZkXrIYCBuo7gOcblMuG8WIQOsTZDNlfe3iyjYAPUHfso BupYN33QWSMCQuA2QPDdW/PumDj0rHl9As7kpQsCQ2ffmyVWTFsfmNG/spITY2KS7an51OJ4Sgmf X5Bz5WZMxqmroZHeUCC4NK2OeGvx0ZZfSMwzMGLMozYNa6dwAv8AutXzLxUMf6dgdIDdwcsOuq2S 2MsPl25LOy9OKTi7PFmxLLwzbp1g6l9FqvEqTM1bjuHz1jXjencNZ/Nl9rUeM/pXDkiWnpczRRTR 0rhHEXWJcRstJ4NNOLiSR7xw126yKeLzdLJW6QeH34C9Xlt2eRaTbGkzZF4dfHFlbJ9djTMy1lTP HNVOLJr3Abdd6UfjJ6D4jmKPFhi8VPLyXvAFlp5p6RkbDH5gc354KCWmpowdVOJB7sNl7YahJUzn 8H2bn81ePjoPWuZTYlXQYnG03Y4MvusTFPqJ9GYcNZBRV73NYLNgaywstNH8Pgqv+TeG3LXFIlpY 43gMOojmxXneWuifCp2jZ/1m+oj01zbkbE8Aipp6iSeIsi9OzSvjfC748Mt9KcmvwbFD5WmUvDj7 dgteL4zGzVG3VvwUx1U1rAKinZI62wHdbeotUdY6VLs9i9ZvF7kXqj1Ow/G6jCZ54KKUPMzRu4XX f2KfU26f0GR6iHCW1DcQihDKeme0gXA7rWBS1JgcZYo2saOxF1x9RJDXVvmujDGjkNFgV5XmcZbk bWmjTR9f1U6p451kzbW43icz5HSuJbHfZgvsAuNoIRTUjBckuG7VgUdUynieY4xcHlZlLi7XjU8W BXOc5ZHcj14sUcSqJ9BkrObcqY7S1RP/AN7yB7W/uvbmXfqdQ5NwGOGKgdUVDG6RGRtey8AzQU00 nm6dRG+yKUwSQgPY0D/dbdaxz8aJkw+Ts9CZc8Y1XhHVivzq/Diairfr0NH27rvTFPqyYzLNE1mW mVUDQPXMBf8AYLwTTwWaSyQOFthyibNrZoljAseQLLr5pSdswtLFI2ETfV3qZsOMFblD0+WWjQ62 /uvD/VTq1UdYs+SZjxCmbSanHRE32J7lfLyGR8rTsIx25WY6hinf5gtYdrK5M25UiY9HGElM7S6M +Iqs6HYuK6mp/wBSxxuBbhd54p9W3PopzS0WEQNiG3mPN3EfheOJKU8g7JD4RHE5xEbieG2Xni6a Z6p4o5FTR2F1R8RWYOs2cqfMNdCKKeGxaITbe/K7UyR9RTq30+oIKKmq2YlTxN0xtqW6rAe66JyF 0nzL1IrGU+A0L6lzzuWDZq7gf9Pzq/JExsGGukc8X2GwXoWTd2eR4McVyY3Vz6gPVvqdhr6Gepjw uGQESGkGkvHtdec6KAVj5aurkdLVSEu1E3Nz3K7mzl4MuseRaZ9RWZanq6eIFz3RN1WA7rpWN00N TJAY/wBPO1xa5r+x9klZrHHGuYmfh1LZ7nNcXP8AyvrcpdUc09Pas1OA10kEv9TA42P7L4OmFXSz F1w4ns0rLiMzJS+VhF/dct1O0dqTO74fGz1pazyqbMU9O3izSuAzP4nOqWbWMZi2aayURnUGeZ3X WLK8NmLhK6M+wKOaKEuM5l1352V88ouzyvTxb6O1qHxj9UcHpRS0uaKqCNotu4lfM5i6vZ06kzMl x7G34lo3Z5hvZfDSFsjD5TA8HklYj5Hsc1rH+Xfay09TJm44YxfR2Xh3W3P2XI/KwXH6vDSy1vJe QFi5o8QfU3NtC7DsYzRWTUzrgh8pAcvjKN00rnQeZckbEL2P4dvpy1XXLIwzDU43okkB8uAdlIZp xOzhGSt+jx/DNUU0TS6QS338y9zdc9TZ4zbTUXl0mY6qOEDZrJiCPhfaeJLwt5o8LWOU8WLyMqMP q3HyJG8kfK6jNbTTNLBJoc7bhR37I4wycHKz5uzVWRuZLjdbUxO+5r53Ef8AdXTY1j9PG1sOI1Eb ewjlIsuKpw+ghIjOpvckp8FcC1x83SR2Wo5ZRVI5ywQsdiGY8ae9jazF62UHYMfK4gqsOknpah+1 4Xi5J5JWPNVwyFvnOa54N+VlUmIU7wQ2QucOG2XOc5S7Nwio9GXDO27nEEflBSTWqnubd7LcBBVy tliD3Xb8BSGYU0IfCNbvYLl0di5W/qJC5kktO7nYkLFdh+tx/wCMkdIexeVmyummg/UPaSAftaFx 1RiMIeHBsjXA927KqTXRhwi+0NpqbySXSSOcQo/D453GRrC8E3IB5TIK+BsJez+Y53wsebGJGs9L Hxn4YVd8v0ix448UMrMNp4Wxmz2OdvocdkyqlhNGyn8tsdt7gLFdihnc11TG4uGzSQQsmKqNQNMV L+oubANFzdLkzpGMUuBVPA14FpbWNrhcrFgf6hhtNr2+26wXZfxV4dfB6tkZ9XoicseGGZkw8szx TN28l1wVuNoKcX0wpsHj1ODR6m9imwYUyKMuka1rvYGyzGYBmKX+dDhNVNq7sjcf+y42uw7GaSe1 fQVtMf8AriIC9KU2uDEvGnyWaOOpk0E2A3APCBkLIXERubG4bXYOVydHljHK2Ez02B1tTEBfzI4n Wt+UEmU8ap2uqnYPXRxDkuidYf3C5tP2Z3Q/TBgmlbI+N7CWkX1EJM1PLA0VMOHyyxk/e2M6V910 w6f4n1HzXR4TR000hlka17Wxm4BO63WdHPCXkzKHS+hwnFcvUlXUiMOe6WMFxNvdc93NHKcoxVmi GhroKo6nHyntO8bhZZVR5NXIHQsYLcj3XdPjK6E4xk7q5mLE8Jy5JRZfbMSx0TLMaF0Fh8UOIQOO p8c7NiArOMsb5JinHIrQ6vjeA1zAGNPLeUlzJmxhzCABvYlZcVMZqd0fm2c3i/dc7k7pdmPqDVNp cEoZ66a9gImkj91xfJ3pRPmJaNuIUrXX0zDvdZz4osMoIHNOqd2zvhdyy+BzrW+HzYcn1UkbW3JD bbL4DE+iOfMCxVmGYtljEKKoe8Rjzo3BpJ9iQtqLfRPLDqz5ptbTxMLQzzHu9lA/QLvDgD/Su6G+ BvrFHHDJHlSeRk4D4zbkFcrUeAzrFRYW6vlwcw6G6jEdzZb8c6sSyRjyzoWpkjMDHQbW+5qGSOmf AZWttJ+F3DlnwadU87U0tRh+X6ibyXljwGWsflfb5b+nD1qxovacEjoQ3+qeS1/wFpY2+zl58b9n mGnfHMdBcQT7q21MDZvKLS1wNtS7Z6l+FbqV0sxenw7MeBSQPqH+XBLC3UJD2tZdq5O+l71azvl+ HE9NPhJlF2xVryx9vkLcsTiuyrPDtnlKpw+SUlzZA8cgAo6DCv4kNMsvluaNtRXp7N30zOtuUKGW php6fFKeJpc8wSAm3wOVyHTn6aXUHqXgQxGLEqeikaS18DiQ4FcpQkufRpZ8b6Z5EqKTEqIugnLJ Ib7Oa4HZJpJ20Bcx0D3d9QC2B4T9IbORp5DiuZIb/wBDIuf3XnHxG+DfPnhokFbWxuxTBXG36uIH S3/7Xss+OTW45/IhaTOn48QjqoP5cZFjaxRMkZM9rntALe6waGd1S/zfSyPv2Tpq+GVzo2EB3AXK uT1dmdLXU7QWWBKx3Smekc2JovzsjpsAmkoJZnODttvdBg0L9bXavSw+oe6RbsqXJ6p8LHgRd4is KdXVuMOw2LhrmbkLvbEPo1BzXOgzyYtIuPMYTdfI/T16p49gnUihwGiP/wCjar0uY48LY/18w3H8 VyRPHgAkfVPIDo4XFri3vuFvHHfOjy6rLLErRqe62/TA6jdKsBqsdwyupsfwulYZJfKd/MDR3svI cdTUU0kkE9MWPYS0m3ccr9DEWJjJ/RWCTMLS8Cl8qVk7tRcSLWN+V45yv9NPAup+KYhmzGsQfhtJ XzOmho4Bs1hN+ey9jxJxbfo8WPVS3JP2asYcUhaHMeQH9mk2QMnFQ516gQnt3W4HEvpVdIcYw+Wn oayqbVhhb57XhxDvc/uuhckfS9kPVmowfGp3DBYfU2p07yN+Fx8S9M9nyYmvNwgL/wCdM15b7Gyc ZaVrSI2lxPdblq/6bfQPCoY4cRDqerI0iSWo06j/APZXV+fvpKZNxB0dZk/H3hxkBfC6UWLfYKbK VoLUx6NWJqg1j4izZ2xJG4WK2maXMa6rkijHc7gLdnlD6b3R7KeXYZsew6etqI4wZ3yP797WCyYv BD0Kz/QVeH4Rhhp3aS2+ggtPY3KiS9klqEnSNMuA4ZBU5jwylq5XTUcsrY3OaN7XW3fIn07+lOZ+ nmG1FZSxOqJ6Vr3SgjULjkrxN1b8KjvDX1hoafE5jUYA+pEkVRbYsvx+VtRyT0vwvMORsIrcFxqr io6qlabMfcEW4XeWNQp32cpZty4NJvif6LUnh/6uVuXcIxNuLYe9xfDo3MYv9p911cJ4XuFvOpJP +ttgVsWo+heWpPGtVZazBE/GWCXXHrOqzj73Xf8A42fB90/xPpDV4tQ4ZT4PX4XE0xyU0YaXW7Fa yYY2o/pnFqVKNv0adoB/Lc2aklqG8+aAbBMhjrpQP00D3wk2sNytyPhH8NPTHOXQfDJ8Ty/T4hUz NIllfe9x8hdhdOPBZ0vyLjGJ1VLglPiFPO7VGyoGvy/gLyvHFSafo9csyik17NH1Pg+ITs10+BVc 0gG7mQuXFR1bYq9xqoJKeVuxZMC0g/uv0GQZSy3SYzHhlP0/ghpT/wDvQp2Bq8nfUO8JGS8XydLm nC6eDBcWpgXEQtDWyosEZOkeT5rXPo1c0tQyW4Y6/sVj1FUWzaGC591j4Y5lBDUE/wAxzHFu35su TwChmxGdrxEZHOkAa0C5K8m1xbR9aElJWjkqHp7nLMlN5uH5erK+nI2lijJC4vEMmZoys1zsTwPE aBnvLC4N/wAhbkvBRlzF8MyphkOIZfjhw8wB36iaEbm116SzFkXLOd8PnosVwWirKZwLSJIWn+2y 6QjfZ582ZQdI/OxhlDX5iqI6Whw6Wtq3i7GMbdxX2b+hvUuSmDXZVxBjDw3yDt/hbPehfhjyZkTx JYxUUcTKh0JMkVM9upsIv7LtHxLeKOl8P9RS0v8AA4axs5Be93paG/i25Xolh2ukeX5sdts0p430 xznlVjX4ngVTDDf/AJj4Tsufyf0R6i54p3uwXAZq6M8EMNv+y20YT4gehniFwiLDqySkgrZy3VTv a0O1ewXfVLQYD03yJU1GC4bTQ0VDTOlDY2AarNvuqoPi1ycvmPm2aL8Y8KHWjLtJJU1mSqpsDQXE sZc2/ZfI5d6UZyzRjAwyhweodWuOnyXMOoH8LaNk36nGFYtjNbRY9l4U1NHI6ON8R16gDbuu/wDo Tj/TjqXiNZmbKuDw02Iv2me+INePey7ZMLhe6NCOs31sfZqVb4ButzqbzmZSkki06i4EAhfH4j4e eomBYvT4biGVK7D6iV4jZJKwhrnfBW9fO+b8HwGSBtfmanwI6tmyvaNfxuutetvVPp7WZOkndmPC q6uobTwRRzNc9zxxa3CxDDvaTXZmWrkrSZqwr/Ab1xayNwy0ZGvALC07kHhIxXwM9XcsYa+trsFl iMbS57Ggkgd1uRyPnSqzV0mpcfjAhqZqXWxv3aSAuA6BdTMR6lUeLxYoyOU0czoXu02BH4V8Wy21 0RaqTkl+ng/wJ+D7HqrNlPm/G6KKPDqd1miY+okfC2G9ZOm7M89OMQwOip6dk0kRbGXxiwNl5oxP qli3TDxSVGXqB8jMGneHGl4jN+4XpbrhnqsyV0cx/MNAwGsp6QywtP8AutsuksTUouK7OM8++Etz 6NHnX7w25z6DY7O/GqVkWH1MrnRTN77rrykc6WJslyf/ACuwvER4jM5dbY6SPNReG0zjo0H02uvg MKMUkMQjfcAbj9lnVYXhlye3QTlPHTCo6OqxCuLWsLnHZrGi9z2XsDo/9NXOPVPKVLmCfFIsIbUA FsMoN7Lz90iZTuzzhrZmamGdjf8AK3zZIpqfDch4UyMCKFlI1x07WGleJcntzy2rg1e4t9JfOdKH upsepa0dhG6xXyuVfpk5zx7MVXg+LYhS4PURjVCZzvKPcWXvCDxe9FMr5jxGKXM1RDXwSujnjm1O a1wPZdfZo8WmWeoPWzKZyjUSVtNC8RyTFhYCSd7e692ODapxPjvUPtM6YwT6QmL/AKrRi+boW09r 64GElcB1R+ldWZNpP1uF5kdW0IcGyCQG7b91sP6/9VqvpH0tmzNTUb62ojLSYmC9ge5XmCX6m2U6 zLk9LimCS1VTJCQ+GI7An32WoY5zjvrgxLUuOTx3ydbZY+krHi+C0NbJmlrHSsDnBnqAXMY79IGi OGOdhmc3uxANuBNHZl/ZesfCjmN+aOkLcahZLGyslfJBDK6+gdgF596jePWo6MdZcQwvMeEz1EEI 0Gmibbb/AHA91IYp5JNQXRJapxpyfZ0X0z+mFmPHc2T0GZMTFJhVK/RJUw7l4/6b+67tl+lf0vp6 sUIzTUtxAtu2GYtLnftcL1H0H684R16wf+K4PhtRQw/1ecAvLniJzLXf/dkZWo6OqlpomljXhlwH Dvx+Ujjc57UqZZ6mUYJt2j4DOf0vMKyhitJWVWP6MvPlEchZcPbfhdnYd9JrpgRBVjGK+oDgHWuA C39l6b8QFDLiHSDFXQuMc1NAJWG/BCrpdWYpUdDqGqaJKjFDRXYJDu5wGyxKNwT9mVme/avyzzvn L6VvSjGsEkgwkVeG4iyM+XUl+q77bX+FrF63dF8xeH3OlRgmMBzmskIil7Pb2K90n6kGK9Ic14rg mdsMmmqaeV7RGwWItwvHfid8TlR4ls0Gukof0VJCf5QP3Eey3LTqC+x00+oy5JKjrGSVtTEx422U YLgDskseGxs20tI2CyowwgWXxn2fou+wbaeAmtI/CotAVW3sFDVliWztNv3Vtvc9kLWBpuVNVie4 QWHJMC2zeQkB+q3dFIAWXAtf2SriJw5VslhbavlDsrtd2ooXPFuEM2E6xO6BziOAhMoPHZRztQsO VC2W4mQgnkIgNR3NghI9N+6sAvG53QnAySDSy7TcFAQWi9lkghsO6S4agCDshDH1H2T2PtEQDYpU tgLAqowx7ObWQBPqzTtbcaiTZEKgyenhBI0em/Cj+Nu6AyYWMEbi99j2WN+pIdxce6D90dgQgGee HgXCrn5CXbe3ZMatWVFjdQNAcSrG6i1ZaHtLbAN/dVK/VYNCTuDsbJgBG91lggDrgIgFQfY+6B7J ibsbqHwslHtjIBtyja9wiJtc+yxA6oY7UG8disqGpuPW2xHKAKNxcDtZVrIaQeVU9Tqc0xD8hVM+ 2kDYlRAlrt3NlA4MGx3VujuzdKJDhp9lSBumOq7ljPlIcf8Aarc65033QngggFCWEZODuAeyp5sz hATe1+yZfzRYbILFuqRG0NLdyoHkWuFT4iXD1AkKS+kAXuT3UYCNiCXbKMjZpuOUFXdjG/hDSn0r JBhvvZDvsmarcJb3Em3BVRbLvvwgcTvblESQy9+ELZNTdVrD5WiE0kgE7lW1m26B01uN0wOu0FAE HeW30qE7XU03+FGx6dwdkBQ4Var7IyQBukvuNwgDafhMJuElgOxTCNuUAD9yANkwvFrIA31DZGAF GCr7KrItjwo5pbyiKUQDZFINYFhuFTXAdrqaieBZUgJZYqEIg4i6rn5QE0enmygOptlFYswXPCAD Q94IvspGC13PCa15tcDYoSBugC2O4IQyvu3Sh02GxQOuEBcelo3Uebfj4QhmpEBobY7+yAD2KO4s hd9vCtjdtwgKLbnayjtbuBspexsExhICAU0gXFj+UrywHkgrKeb7HYJBbpBsgLDb7ogO54Qh1vwo 55LUBHuAVCzu6U86gCjiIYN0AVvUpbc2RCxN1AN0AJbYK2ek/lE4qA2CANrxfS4IHMIfvsFbhexH KsOudwgL07/CqxJt2RtNjflLmd6hyhbLMjQbFFfUdljOdvvumxAg35CFsIsde4NkLg4C7jeyYXEf CGQks2QEvrAcByqPyLKmvcPT7IiTbhCIrSCAjJBZYKw0aLoGkDhCk4NuPlW5tt2ndU43N1QcCpRQ i1ziCUstN00kgfCWXJRCg3blWBv8ITdOIswKixDhpUaQb7KSHVbsoNigKDbklWQhIcHbce6stuL3 3QFOahIN+EdiAq/KEoohzW3RMOttzspcyNIVhwFm23QoLuUO3ZE4WKoOBt2UoyWGi90bbjugdcjb dXDdwN1TQTXjVuUTnW5SxE2Y/dYhG6zX2G6EoLtfsiJaVRdcWAsqAtupRCNtdEbIAQCSeFNV3BQF vFxYcq9ItvyoDYqG5K0CiAAqbGSLhR5t+ULJDuBsogFxseVYaHDdKuC65NymscDcKloqRuk2CoRE tJvsOUbxqsVQ1WI7KUWgWtCIc7IXEtHF1Gkk/CoLJJKFz2kkXuUQcGHfdIkgIk1N4KEojhuqsALl X/hVLew3WAhgYNN+EA0SX0du6uQ3jsDuUETRE3ba6FonLtJ4RyQta7Y3QeXqdu7SiEegfdq+UICI xc3U0OtYcqwDq/Kc1p0HcA25QIxXXBspY2uqfqad90Hm25QIc1xBTQdYuBZVTAEXdZG5xa70jZC2 LLtjdAH3Fk2SM31FLaWOdfhAguAllwAIPBTyWHg3SzH/ANOyCgA4BukC6BrT7oyRfhWdgtGS43kX HZA5pLjcK2Em6u9hdw291QC0iM2KYPURdJke1zRb+6OMh1rFAMseyW9gcdxcpu4appvugMVsDRUl 7z6LbBD6G3A7rKkj1glYz2+w3QAk2FuQoW2RNbqabizuwSw1xvq2sgKIsN1TWBpv2UBuU0Rn9igA Ia6xAsqcOAAmiOwNhulWIuSgIGht9lLWCgdqbeyltkADudlLOJAHdGR8KElhaeAgDh2qQwHeykpM jjc2sVbWgOMvBshaS+5KAjGWkB5ICIyeogqmsuSbq9IQBsIHdQm7kBFiD2RXG6AhNwqAA4UUG/4Q Fss5+lVIA0m54UdsNbNyFGw+azU42JQFsZcar8q9dgS07hWAQ2x4S3NHZABI7Wbkm6KKWw09grLL lGYmmxGyAhfrI34RMdfugjYCCQEbBZAC9xumRuubHlUbX34Rwi5tawHdRlojyL3Si0k37Ipvv09v hRouALqECa2w5v8ACNjx/UlPbpQN1OaSRcBQGQC0mw7oHhsLvVvdU+VgaNBF+6E2lBN7FAGGlp/6 TwrdCJBugJI0i90oyOMoF7BaQBLdElgnMtZDVSM9Jb+6APDmgcXQDJCGjZC0louTsUMzgC0A6k6I BzbFRgB7xE3UN7otLZWh17FC8Nb8/CEva1gHCqAbpHkBpOyjnFltkUdnW3UmDjp02O6jBGguF7bK w3S7c7fCc9oYwA7/AAklzSBZQEEZ0kk/hCxug7i6MKE7Eq0UTOXyRFrR3RMkZK1rXjS4CyLzS3gB DK1uoOPJSiFsi0vO23uq0EcopSXNBabAKxUMc0C1yEAp0bioyIk77WT9WppI4Qs4JUBNNuCpx3UE mocIC4Akd0KgyVTrOIFlYkEjQf22VkBu43Q0DK4hmljfSktjPustkwaSbC3shaWabgclCUY97bHl FHGHHfZNdED9pCSGWk5QlFuiLeDdGy9rHhTfi+yJoN/hAgHM7oWopHbgItIZuChop7bEEd1PIu6x /uhLnF9+yyPNDhwgBbFoAKmm5umaA4AqtItygKdYDhLaRexRvj/uhZGSSSLBAG0EfhE1gJPFgiGk sJaN0DGOcDc2KAoNBJs3f3SKY+bI4exWWRZhA+5IpI3Q6ri9zygI51pLHhGHWNkcjAXXtuhLfZAU 4hwItZBYHYBXvdEAB2QC7eot7q2xu139vdPIDGg29SWXufwgF1JFwLhA5g0NIVSQF7hdFIy4DWm1 kBTwQARujjkO23KWxunk3CvWGuBWkBj3AGxSJrk7cJn3uLlfuLbqUBDCdRHZG5jnt5Uc3Sd0zbSC nQFs1N2O49yiDGkFEXbDZX6bbmyWBJtq25RWJHKLSARwq03eW9ilmiMIGwPqRGQ/slhgikvdHKD5 W26EYDbPue6u54aLH5S4Guudtk0NN9ihA4hK46X2/KkkZad+ULYrvJc8t9lboy0ffq/KcgBsm9j2 TC4H1XSjq9v7J0bA+I+4UAQdqCLSb78JTJdiHX2TWu190KgXsAO3dFHZjCFbth7qj+LIUVJHrbfj 4VMjbyNiE0sBQhlj8KgvTqeTfdGxnnEh/AS9RsTsETXNLbg7lQEc0R3As4eyXC2ME2aGk+yN1gri DHX5uhKGCnDmgByx5YTr08LJjtGS43VvLZQHt2PsrQoS2nDRdu4Cw6mEO9R91yUTwWkNIusarGvS 3hLFGKCRa26NxHOiwPdUIXMkABus10L3NAIF/hLJRhRsa24IvdC+Lb2F1lmlsHOvuseZ50aSN1LJ QiSNrZQ47geyt7muALAR2ITaQsiFpRqJWaI4Zt2iwVspx8UQI+38oaiNsDSbG/ZZj5BFMIgNyh1f zLPFwlkoxIWCRouE5sR30iyOSPQ67dggdUFtgQSfdWwCHFpI4IQOY6Q3PHyst1MHMDy6yAta4WB4 SxRjyO0t1EWI9kDXl8bnv2/CybNfta5SpgC7TawCtkoFpDojbZ3YrDpYJ5nSF1QHRnlt91luDSwN CGKniE2zC091bIYstK2FpIP4CkUQG/vzdZz6dofYm6U4DURxZWw0YszGONhysQsBcWngLlZ2BsOp jdRt2WC0Hcu9JKtkoQwezbhAYNbyeLLOZEGts7YdktzbBxvYLVkow2sAkuRsiA1P4sn6QWOB4PBW PCzTqde4CEopxET7e6kt+AqcC6S5G3yreTtsgFgEE3UIAsU0MD3b/wBkL2bLSJQJcTwhsTsoRYbF UTuqSyWsrJuBtayqxRAX2QWLddw/CjCLWvYo7ljrcpen1XCAZwN+UFyLgcpl/hLc8sJNkBC6w3R2 GyQXa5WtG5d7JxdY6TyEBTvhRnJRWCpzDcb2CAFshLrBU+Mt9RITPTY25SSzYkE/hAEPUArLbjYq mHSNwhNgdQQDJoA5g089wqhcI26QEF3XDtVlNZF7blQDxHfeyone3ZDFJJbdtkZu7upZbBLGg3RM 4O6mm1/dJBIvulFHW1C55VkC3CprxpsUeoEKCwShuTuN/hE92xtwscPLXXtytIDdgLohvuBseyrk b7XUuGN5uqCOFuFGg+ymu4uFBMW+m37rIsry9Z08fKosEI33VyyaR6Tuo1xeBrWiWUJXAiw2Kt8Y c8E8q76Tvwr+QfSgouRwMZA5WD5RGyc6znWBQ6H+yyQ2xU2WpBF6WlziOFwmP4ZJDTPaWlptYrtK F7Y3hrRZY+N4Myqg1OA9S/jUMjs/pbjRr+68t8rMVNEPS0s5911tAz9MC2+oHcLu3xVYK3CsWhk0 2b/SV0lhszZ76h6htdfutBK8aZ+a1f8AIy9IczjlYNZGA0+65KPcniyRWMFjbdfZi+T5rVo4B1gb d0zU1zbXtZSdlnk9kAs7hek8j/A36dGoblYkjnFpITnkNabrCle4u5sPZaRlhtN2gX3RBnqIVR7M NgrYNTvlUyXp07FCSPdNkaDv7JBsTsUAEbiS63IWM8GZ7iTv7LLBDeBZY8gtd3BWwIcywtfdYksj hG5jdndisp5Om55SqSIVla2Mus2+5QiOZyNlbEMz4pFR0zHyukIDnN7LYD0M8AmCYxlg1mYYHVUs 7R6HD7flfGeD3A8lwVNMKieA1jnA/wAwhbNMpVGBT0pipJ47sZYRs4XbHFylR5c0tq4NJPiv6ERe H/qc7D6IOlwyVnmNA30/C6hjZHWVDZBJpi5tdbePFPg3TbFcAzPXZkfTxYnBA5kPm/c4220rUBNh sdTiErcPe805e7SHdhderNi8bRx02byWchXwWpiKZ95b8hJgiqTG0aXSSH+lovdZVBh7xMyIn1Eg ELYF4MPDFgeYKZmK41SsqpHAFkbxf91wjG2e6TpWzX+7LWPSObK3A61wI+5kTrf9lxlTTV+Hh8Ul FUwv5OuMrf7WdO8rZIw+CL/TcVa1wADWQA2/ey4nMnh/ybnXBJXHLVBA6RhdeSNrSF7/AI/1s+dL VxTo0RUGB47X0zn0+EVUzOS9kTrJE+A45S/zpcLq42D/AHxG3/ZbyeguW8j10NXgdDgdIRh7zHI5 0QIvey+/rctdOJcadgVTl7CpKs8xuY0Xv+Vj455Ja1r0fn9wzCcXxiUspcOqag944onH/wAL6DDe l+csUmMFLlevk7i8Bt/2W5jFOmeS+lHUClrKTBqOmoqtwY5rWgtuV3JjOC5OyrgzcZqKKmpqd4Dt TWACy0tPGNX7NrW/W2j8/ON5GzPlWYxYzgU9B7OfEQFyeAdJM3ZthL8GwSesb7sYbH8LeHnLphkD rHlUymmp56e2sSAA2ssrJuT8sdM+nVXiVFhNP5NDEXAsYAXEKy08U+BHXNqzSHiPQHqXgtKZp8oV 4Za50xE7fsuNyb0gz5nyvfQ4Tgk08rb6o3MI0291un6A+Ieg68YziOEnAoKdtM8sLnRghzeFxFZF gfSTr7BheHYXFDT4qdTnWH3H2Wlp1u2sr1rpOJqbp/Cr1VqZnRRZdnbo+5wYeV8bnrpvnbpw8sx/ CKmmi/8AqOjNv7r9AnUPN+C9MsNir6mnhjjlO58sWXWnVp+Quq3TbEJKyfB5I3QkfzC0ObcLm8Sk uDPzpqVGh/Ca+Sou2RpLOAVyg8/VpiIAHa65bMOSDD1CxbBMuNdiEEcrvK8ppOoX4C4/HskZuys0 T4lgldSwj7nujcAF4ZR2uj7cMlxTY/TIym1SD91iiGN07H8B23wsXDKp2IsLA8llt79lmTUrpIo2 xPFojc37rHs6N2esfBT1Ui6fZj/h5pmTCWQEvcOLlbf6nM7oen78bo6ZkkjaXzWRsHJA4WinonMa XHW1YvfU0fvdbwOnOMQxdH8HrahoMTaRrnh3BAG69UVymfM1VqLo+T6NdSqnrNgWKR4xhb6HyXmN 8c0ezm7+61r9a/BriHVbxD49h+Q8N8qjjc575WjSzVfseFs/w3OGF55yVjzcnNZHXtY5mmNtvX+V 8v4WMs1eAYXjUuMN04q+VzpXO+61z3XucklJ10fDxOSlFJmvbA/pG56rWXxLGqehkO4Y1wJH5XS+ aPBV1Jyb1Mp8nS4e6uNQ/TFWtB8sj3utrdf1x6T5ezrW1lbnieKvpXlk1LLKS3V7ALksC8SeQOqO faLBcJfFiLxZ0dS+O2l3wVx2t8tHt+TL9PC+CfSSxvFKJr8UxmKhqi0FzW/K+N6p/SrzrkHBJ8Xw vE48UpoRd0EbrvI/C9r/AFBc9ZuyDlrC8Ry7XyUFJqIlkj/3dl5Y6Z+PnOzKNmFYkz+JS8+ZKwkF v5SOFSSZzeukp7T5LoD9MjMvU/C3V2O1smBU7rljZGWd/Zdh4h9H8SQzMwvOUU9W29hJtutiPSDO tPmzptS48IBTRmAukaNwCBvZdC1njh6adP8AE6ynqIamqqDO5odBHdznX4AVjittRV0dMmplFJtm rrrR4Tc3+HDNdJSY9F+opaqRohqIfUwi/c9ltf8ACp00rMG6T4JJh1ayKaamDjZ2wcR7Lyb40vGD l7q/kpuX8Ky5W4fiHmCSOrrI9JA+Lr0H9OHN+I4xk7+HV8zqhtNGNEh/7LlL/XLhcnWGaUo0zy74 78k5tzH1fwfAM4YgKjD5ZWilfGbgA8r6vM30mMLrOnLMbwfMHk1v6Q1JbKLNNm3tdfeeP6kfR9as pYnKzTRtLLuPex7L2bBX0+ZOi5nw0ecybCy2ONm51aOP7r2ZmpRhx2cseWSUq9GrPwfeBLAOttHj dLmHE5IajD5zDeHk2Nrrteb6S+WaXqBFQ0+Yp6ijtrfD3A+V2B9PXBMXy/1AzjHiVBPR+ZM8gSgj uvZtFQNOcaiuAZq0abg7ryzx1Jr8OnybimeTKn6ZHRbC44Yav9W+otZx1f5sulPEH9KjB8Jy3W49 kXFZWvgj81tPM2xdte2y9N+JDxSS9C81OiiwZ+JVEo9DHb6x8LqLMXjb6sZtydXSYP0sl8iSJzWy vaSALcr0LBNxUq4PK9T9mk+TU9V0WI4JidRhuIxOjqYHmN7H8ghZtAdcskf2gN59ynZwx3Esfzzi mIYpAIMRnlcZogLaD7WTcvwifFI6Ww1yEDUV86UabPuYJOcU2er/AAWdMsrZvq2w5koTVyPf6QRt a+y2E0fhI6IZzpKjCosu05qY22lIYA5v7rhfA70myxhnTzDcThpGy4iyMOfI4cusuxMH6xVP/rFU ZXbl39NRv2NeI7XPye63ijui6PJqszxySNeHV/wC0nTzr5gOE4a9zsu4tP6Gu5aCeF7nf4X+inSf JjJcwZdoKingYDLVVMYJv77oPFWybD+oHTvGxGf0dHWaZZDxuR3XNeMnBqjNXh4xsYZAayqfAHwh g1XHPb4Xo8cZbX+nzp5ppNfh1vV9BvDL1bwl8WHNw6mkkFmSQSBjmn4CwOgngEyNkXNOLVc9PT45 h7zqprnUAvCvR7wvdTuoNbE7Bo67DqVly6oa9zGtd7Laf4Wen+ZenHTuXC80V5rsTa4tBe67g22y 1OHjtI448mRq3wfIYp1A6CZXz0zJ1XhWH01cD5cj3QgRxu9iV8xnTwa9K+qOesOxjB58PDCdUlPS uADxe/AXlLxc+GzPOL9d6gZfwetrKXFJ9Qqacn0knm/Zd1eF7wm9WujnUTD8XxXGP1OGCO7qeol1 Bnxf3Wp4VB2mYx6iXvs9ZDpTkLpLlpr6bK0NW2OzTpgD3H5WbmbozknqBlZ8VXl7D4W1MWoOdA1r 2bbb9l8x4t8ezvgPR+epyPT/AKrGw5pdHGNRI72C8kYdkHxQdTsuQYxUYnUYLE9gaKN7tLi3ubey uPE3Dfurk7zzf7NnZ6o8P+D5MqqXFMuU+AUYGEzGEvdG1wk35XM1uO5Ypuq8GR5crYY+CeHUXup2 EcexC6U8COFY3g+dc3UOOT+bV04DZgHXGu/K+/6gZAzHiXiCwnM9FG5tFA0Mc5o7I4pzab9GMkpR in/Z8f1/yxlPw8Z+wDPuGYJTUdGHaKiGniDA4+4tsvS/TzqPQdSMkU+Y6SN0NHKwvAd2AXmP6j+O 0lH0zwullkaKl0oc0X3P7LtPwe19DjHh9wSnpqlk+iMsla0g2N+CuLxpQjJ9s6LJJuS9Hi7xt+M3 Dp5sTyfSYEKim9TJKh0Y+78rW9SPEfnVDQAZnk6R2BK2++Ir6bGD9UMaxHMWGY+7CaudrnmF4/l3 3Wrbqz0uk6MZtmwWTEosTkieWl0TrgEFdtTKMoLazr/j7TakqZxWX8NjqsQLpd26dwtuv02uneAU XTmTFIaJj6qR5cZXNBIK1G5enDpZS46S8WBW2n6bmecNGR5MEfVxx1UYuGOcN18lJ2fYy/xbPVvU HG6XCqalE2YYMvXkFpJSAJAP6d18H1tzH09xPINbUYjjGE1NRSxedC5szC8yNFxa3yuvPGB4cc19 b8TwYYFXNbQMP80GUt8v3IXVmMfTzwXK+R6iXE8aq6nGZT6ZHTkxB3zcr7OPFjqL3c/h+ZhPJLJJ Sieu+gGeBn7pXg+KvYPNMZYRa/27XXz2B+KPKGMZ9xzKddLDh9VhhLZH1RDWu/F1yHhpyLXZB6aU eGVdRTz+WyzDAbj91rJ+oP0Qxnp31HxPNxxSZlFi0xkHkvtp+FmGPHOc1L0d8ssqcFF8Hu3BOtOC v69DA8tVjJYKsXkhhsY7++y7F69dfsJ6JRYecSLS+rNmjheIvpo9La3GMy0+dMQq45oYIiyNsr/W dtivWnjT6NUfV7pZiQMrKXE8PidPT1BIsLC5ClwlmUX0c5wnjxSb7ORwjr70s6jz4THVVFLV4iSH wsmaHmN3ws3xQZ+xjIXSHEMcy/IGSxtBZICQQPcLUX4ZepNB0v6xUlZj0oq6GCfyZS83DTexIW3T P8WV/ER0ilwbB8x0cFLXxNLZNbbgW4sSklDHlX4acZyxVJ06PnPBV1YzJ1n6YSYtmVzXPjkMIPOs e5WP0gzlVYR14zdlV0FoJX+dG1o2b8r6fof08wXw59NHYVNjtHPDHeQyula0E+177riunmLZIzL1 Sr85UmYqWKrdGac0nmtHG11ibjcmuhCE0ox9j+uHidw7ornzBcLxlwpsLq2apap52augfGd4uelW c+gON4XhePUmL1la3QyFgu8H3C7C8cvTPJnU/pjiddXYvRfxOggdNTETN1OI4AsVpTiw+njrJ/NB /luLWjVccrqljWJSXYw4smXK9z4Pvejvhpzh1wqX0+XKcvjtcC9kvq74WeoPQapZNmTBJ4aN+zaq x0n91sn+mT06mwLLP8aqGujZOzVGbbEFfafUvzpgFF0VrcNxGpiNVK0/p4jbVq+F4oQeSXR9aeXw tRNNNNjU0ERYy5adlzGFSskpxEABI51yVweHwRNwsSPI1uJ5WRlmR0k8sp3Yx2y4VtlR9KDpJnrf wd4o/B+tGXxAwv1TtDyPY7LbV1qzvX9PMoHHKKMTx01nTM03JatXvgMr8kYRnR+NZoxSGCWCxiZI 4C1l7p6y+KzpFjWQ8VwlmcKN1VUw6GRxuuQflbx15KPDrG2mdjY1FQddOj1PWESUtNVxCdsfBDh2 /uuXyzKzKPS182IxvfBQwOL2Ws4taF5v6a+N7pTlfpnS4ZiGKBxo4zG5rQCHke1ll5Q+of0tzLUV OFYtWw4bhzvRGXm4c07epeyUJRuK6s+Tu/8Ab+j5mX6h+VqLFKqjyrlSrqq4PMZjcSCbG1+F3F4Y /EJi3W2XFhjmAPwSoo3fyvMYQXtK63m68+FrImKS4zTy4ZPXEF2uKAPdc+111hin1RMmYR1Apo8s Zf14G/01FSW6D+y6zeKaqCPLBZYr7v2cX9TvC8yYZmvBcSw/Eq2OnqrNihpZCA1w+AvhvDlgHiEp swYNidTX1wysJW+b+rubtXo/NXjp8P8AnWmo5M0MZUSRWewSMD9BXz3Uj6nnSrLmU/0mS6SbFKhg 0shEXlsaFvfDxKG3kqxzWRt9HsTPGcKzJvS+uxunoziFdT0/mRU4N/McAvFuV/Hn1YzBi76HC+jz 6mrcSC9jXNAHuSAg6dfVTyZNhTaXOWGTRPta7AHix7WK+uh+pf0JwGlqZ8MimjqnC4ihpwNZ9iV5 IqMLTVnfI5yaa4PF3ihz51Q6h9Qaf/X2DOwSNso8imaDZo9ls88HTqtnRLC21eotjBEer/bbstUP X3xeu689XsOxuqpP02A0Mm1Mxvqe0Hkr2nkT6oXSXKuTKLDYaOqpnUsLWGMM5cBvZdM2RTikke7H i/1KR8nnbEJemXjRfi+Mx+TFJUtexxOxjJ+4Fez/ABB5erep/RbFKLLumuqK6EOhDDcPFr8rWB4t fG/lzxAVVN/AMuzUVXTDS3EJdnlq5foB9RjMHR7AGYNikf8AF8PiH8nzrl7R7XUyZL2y9o8iwzjF r0zYJ4Psn4z0v6MnC8wQikqqdz5HRk/aObrs7IeOYXjeEVlfgtR+rike5pN72eNiFrR6t/Vkrs35 aq8Gy/l04dLURmOSrL7m1t7Dsuo/D948c1dFZp26TW0c8hlkhmuWm+6w6yty9si8iSXLSPYfUbqB 4mYOptRg+VoYpaZ85bGySP0MZfYknZdaeKrp74msa6eTuzPi1DVYbEwyziiAaGjuFycX1gsOe0Sz 5Mf5rRYua7n9yvPviU+o5mjrDhtRg+C0pwrDKppZIwOuSD2XqjPxLdSOEcU5Trs8r4TTupm1ME1n FriHEHuu0ehGJUlFn/CG1zY3Uz52gh/HIXVOEskYx2txc6Qkm/YrmqR7adjCxz2VDDdkjey+Rlmp zbR+pxQax0+z9D+U56eu6fUgwh8dnUoEYYRZp07L5HpBNmyPEMWocyQSNjhkJhnduHtvtZarOj/1 As/dIsFbhkkf8UpYxaN0l7/uvpMR+qr1Uq6hxo8LoGNJ9LQ3j/5XbE0otHydRilKalRsSy/l6pyx 4gsYxOpY1lJicAZTv4uQvhPHT4ecx9c8tYTT5YhiNdDLeSSSwGn5WunqV9QTqnnutw6p86LCaijN 2mAWuVyOD/U361YRTtp5KulrWDYOkiBcf3XsU6kpxfKPHLDNRao9WZO+mNl/KeH0GYcczH/D8YpQ 2SaSF2iKMjndex4MCgxzpRPgmF4szFmz0rqYVjXh4ddttyFpt6oePTqt1TwkYfik0dLSHYx0wLA4 fK4Tp34wOqnSWhdHgWJn9O/cwSuu0H3C5Tm3K2zePBKUar+j2Vk36XuJ4liFdLmXGIqOFs7n0/6Y kuIJuvU3h46V5c8PH67AG5ggqa+pIeGzytDv2F1qrzJ9QDrjmel0nHn0AIsXQbG35C6mruq2eK7G G47XZhranEGm/mmY3C3LLPJamzcdNLHSiujbZ4mfB7i/XHN+H12F422LDHj/AIrVKbt+W291151b 8E/Tro10skxaWepkxdjm3nkmJa8/heCMN8WfWECOPDc2V1Mxo0iPzDZfR5R6m9Ses2aMNy7nHNks 9BNM24nk25XohqckEk5cI5rR1JyS5Zt98OE1NifRXA2wgeQKfy9u6yOnmQcM6RHHJZcVjayunNQX TODBGD23K5PpFl/C8ldOsJwakxCmqY6eEAyMeLH/ACtdf1L8YzJlfMs1dTZnkbg9Sy0dFTz8G3wV 54f7ZS5pM55Yyg40uTJ8TPX3K8fixwGro6uGWhpnNZU1MRuDZe+484ZD6rZIgpzjVFWYZVwgOiEr dxbghfnvp21FeG1ksz5ZZOXSOuVzOHZ0zXl2AwYZjtTTwnlkcpFlvNljJxjfR6oaSexuuzZ74qeg 3RTJnT7FaiOooYKhsTnxRMka54da/Zar8MljGurYdEJlLY2nmydX1+PY+8HF8Vq6yM76ZZC4H+5R QUILWtc20bTs0LxZ8++l2e/SaeWJc8H1WT8dZgGYcOr3jVFFO2R4+AbrdD0P8VfTvqHkiiov9Q0l FXMp2wyQTSBp4t3WkH9O6I+kAsPZPZBUxR6qKofSyEcxPLSuMZL2erLjc1wbmsM8M/QtmbanME5w vEqipeZntqJmFpce5F1xOYoOg8+esLgocawbLVbhkweTSPY1kljxfhachiGYaUlrser2Md2853/y sKpY8EzySSzyHl5kOor3eVNJqR8nFpJQdNH6Bc4Zz6fZwytW4XWZgwqpoJ6d0Za6oYdrcjflaUq3 BcuYP4hMSwmnxFoy5DVODqvXdpbqXT75sWnOtmJVsLBwBM6w/wAoaGB+qRlS5z2v5e47uK3DPHFF wvhnWOl/2b5G+DpL1a6U5K6aYXQ0GbcLbSU8QBBmaDe2+y8KfUe6g9OeoONYJWZTxGnqsYbcVM9O QdbewK8F/ohGD5NRURtJ4a8kIqbCnGZ0gkMzm73duVcOeGJuafJmekc5VXB768Efjty10hoZss5u jlhpXOtFUxMvbtuvW8viS8OWZ8Upsaq8cwyPFISHxSzgiQfgrSlPSipZ6wWv9wsM4Vqe0ucXHjmy 8rzbp7rN5NI3HbE3M9XvqA9GYGjL0+KOxagrW6J5KUXaB7XX0eUPHh0IpcvUVHQ5kZRU0EYjbFM0 tLR+/K0nx0kcNmmMhx/3C6F+DRSSFz4mlvcDZalkhtSOcdJLtvk9RePvqLkHqX1YgxrKFVBXQviA nlY0We73XmynhjfTOkcxrLnayxqbAqZjg5rfKb3F7rKu0OMcf2hYzZ3kikj3abTLCG/1vbcbDawT 27fhLjb3Kmu1wvnM9w7WO6gcNWyVu4elW0Oab2WSjdY07oNdybDZG+xaLcoWgBqAEkyN27IT6ge6 hu02beypwDdkMhtAtuoYmEcoBt2vdWCXGxFkIKqGuhAMcZkHeyIM0xeYRY+yyY3ua02Sw4uDtQQo rXqj2CgHBVtZZ2yJ7dAGlBRbzdoACB7bNFlORyrIbYWQgstBbv2QNjaBa25RkgG11TAWk33VsFlo sBe6HvYJjRY3S5HHXwoaCa0u7bK3tLeeFcZ/srnaTZocAgoWD7IgfSFbI9DCCbn3UawW5Ql0W129 ky4AseUBaGn5RBoLtR4QpTgduytrhwrc5jrW2VFob+UIye5TmzyRi42Cxna7fCtuohCGQ+rc4AWH ykNJkcSOUGo91LuYNuVGBt9J53U1F0guEJ2APdEJBexCFsa5x4JuEmY6BqamA6mnhY017G5QWEHA 7jkoncXtuksks0XHCA1zI3+oGypBo3OwuEYcGO+Epkwlf6DsUw6L2vdyAqppHXEgd6T2S3N1MaCN weU0zOd6Dx7KnG7R2QAVA83SCo2zAArsCrNgON0BV7HlLdcvujcdSo+ke6AtxGjbdKkI8v2TNQYl SDVwgFxnUbLLYx2k23KXHABuN0TmubwgCeHkWOyLT6QLoWF9jf8Aur3sgI5na+ypzbtte6u3Cojd AUCCN9kTCLm5V6dVrhEYGsOo7oAW2tcIhuOLK5XARAsCg9TR2QFDlQtJPOyvTbdESduyFsVblVfY /CJzSb+6BmwIJUKgg6w/KstB7KA7XValLIyEAKnDVtyFZdcKF1jdWyFh2kEWQ37d0RcBvygey5ul lCc3ZCxl73TQ30c3ISXnbZUhdrDlS4PKBrgBurG4QFneymv02VW3Cs2vwoaoWB6kTbhG3clQ8Kko C4dz2Q2uVHHSQLWChFjtwgos6WWaRuVTxYWAVmPU8OJ4UkBugQtzg5tgLKmAceyMM0Wd39kckTi0 Fo3KllZQBkvpF7IQbHlKLqineQ1hI7kImnUb6SCfdLBkNaHjfZRzQAFbI+991JTobulkYBHyrDSr bYt+VY1BSyFjYWsqcAeyvkqXVsC9DeeCiAs2190LiL2uh3DrjdLA4i+/dU4ImuvyFR49lQKIu7bl E51rC+6rcm4F1NN3HaxUYCeNLBuhFmjY8pjgdKS0FvI5T0X0Wb87WV2FtgrJuLFRSwgbEgg8q3Mt 3U1chSwLdyllYIFjyiJ3sTsrDQAq0XJPulmRchtv2QhwdY3RyQl8ZseEpsDm2KqZoaX6hZCDp2G6 B7NJvdWzlUpeoE8K9iUF90bVlgIjVwLKFgsSDuquVAN+VoFHYajyha9hda1j8prXAG4G6Gdwe25A BQlAl3lu23ui0k7g2S4yWmxF/lNNmtvdCkLALd/lWWgWturaNRv2V7C3ugKDfhE0AoiCG37KR6SC Xc9kBRjDrAFCXiN2ki/ym6gBwhIY4i9wVlkB0uabnhUDc7K9ZOx4VNNuFoUU8aiqEe/sEZuTsrAJ tdToonQebI4RypM0sF7qNdsDwgGWuDYpJ8xosEwG42UJ790sgpjnOJBRN9KIA6uFTiRyUsF/d23Q uefbccKy6xFlD6nX4UKILnXJcFHEuTXt391RsdwLBQCz/hEGhw/Cp50/hUWuIu1ARwuLcoHtLQOw TYwW7lRw18hCULieNQBKc68jrM2HuscxG90xkjwbWt7ICTR32vcpLIBZ7iL6RdZLib3SpnObE7QL koKDp4RLAHX5TSNLANyAqp7MhaODbdETcIKIy0g0kpDmh0hbawCsARvuChc8eZccoUhDYzYdlkx1 DXM0lov7pB9b9lHbEFaQFxtLnvuNlbYib9kwEA/Kp8na6UAdNhsq062lpQyzBt+yBzXxtZJezX8K koI04a3Te6tjPLItsFY9Qui0lwF0Mka6xtyrLjf4RCIA7cq2WLiHDb4UsC3O03J3CW7S4XHKdK0X t8JcMYa49ylgH5A3UmOlpNkx7g124t+EDy1x+EsGOGF7C4CxTGwvbG0kqGBzXel1wnRxuG53+FQL ktHb1WWNK4vJA4KyKlgeRqOkpDRd2yApocG6fZHw3hEG6TflU9wdteyAHct+UErfUwu4Cu2k2uo6 7ueEBcm9rXsgDze1kyMHi2ysgAkoCwABdXpBs7ugLwQLKrnVa+yAO91GbIXekgDdWfTugCvq+FCP SRdRpLuRZQ2JspQDgtG097odLtV7bK4yCC3uo4W73Qth22QEXKis2CWOCg4Emw3QiUNcA7b5RB1j s1ETHKC0j91SFts7dp2TLAH8oImtDgGjZHICDdQC32LjcfhNDXFnsUvS4kFN1G3soBWjfflW3uiA I7qNaSoCiLqMZoabd+ys+nv/AGVgkG/IQCnU7dRsbKo2WJCaXBx9lYIHZAYweC9wtuFRYX87FG2P 1lyJx17NFj7q0AIKQNBBN0p8Rue3sspgIFiblA8gyWWgJgiY13rPq7LKaA38rCcA2pGobBZckwNi ALKewInJBJ4+ELR5wsAdk0gSHdW0+W3ayoAY0tPKbHHGTrc4gjslWu27dzdUWW5NlAOdVCRxsDYI GeW99zf8KongsLC390TIgBtuUoGRobpO6SQDydkYdZpuN0mxO6dAlrDZUSL+r/KN1wGj3QAOldYt tYqlK1atr7KjpjNzyneTovtdW+Jr2jbcIAItX/4J4TgNAQgAkAbJoaR3/ussoEYH2gBLlfHTkiVp IPcIwND7g3Pwky6qgkvBAChRjJKaVgEQIHe6yBG0tNjcLEhh0tJCdDKdJbwUAg8u7omOswi1wVHE CQgqRgnjhCWWN7AKgA0lEQQhvftugLablMafhLDSEdtG90Ap7rvTA3Uz/wCUve5RCTQzcXQpYjPf ZPghZ+QkxyeZDI47aeEmhqHTOsdkByUrABtsAkP928JzjqFr2CRJIGCwF/laoEYbm6sPBcR3S2za 2kje3sow6nXOyyBjCGG26Y0hL1XPsFeoBBQTtgULSQRYKOffZUDYXKChms7i1kppceUYde9kIt3K AENNz/2RG5Isr3vZG0Fh9ygFWN91JHEAEbIyd9+VVtRsgEvkLtiN1QYCmOi0u9wgLbPuN/hAUAb2 V7EbqruB3CljvtsVQQuIGwUuSLlU3sFezL3N0QKcAd+UL3WsAj2d3sqLWk6r7owEG6gLoHNDybco gSJBvsVJGiJ1wRuoAADcNKY5h3sN+yDVrIcmRyFrwCLBAHHEHN9ex90EkflubvdvuqmeHizTYoGa pWaTtZAHqFjZW0WFr7lDvbSP7q7iPY7oC/TcG9yEZs4XGyU4EHV2RN3bsryC/KJG26VLG+MnkBOY HPcA3Y/KVUzmOQRPG6WC6VuthHKPSWkW3TIB5cRIQWLjcEqAIPFiB2Ckd5G77KhGDzyjb6GHsUAJ Fja91DZtvdRlnG52UtqN0KgHML9+PhDotayc4iwKB+1vcoUtuwN1bHNG4G6oA2I4UDdJ9ygGtc0n 8oHyiPe2yJgHcWJSZJhE4sI1ApYGQgSP1DZXUAvIt2QMk+LI+xIN0AI2AJ5RteSb8IW7C+1ygLLk HdDLGh2o2vysSeNwk4uE9sdngk7Jrne4vZAYogY1wJFyic52n0CyjnlxJsrjcXBw4PZShYco1UoG ked/uS2sDhaQ2cowvidd4VynznbiypewJGaR6QXD3U/TvOl4tYdk1j9I0lC8/KCixIHAtcNkPlNa NQ4KDVZNgeC0g7oShZjubt2S3QnVe3KzXNBbcLGkJF0Akx6pWhG6Eh5F/wCyuJxB3v8AkpjiRd3I VsGGbPksOyp0Gsmye0sYDZvqKOzNIAFirZDDF6YXduClvpBUPDr7LKla2QEHslwu3NjsqShUsAM7 QeAEMtO02HZON3zj2VTEl/sFbIYNRF5ViBskPb6drBZNU4vIHYLGc08jf4XREYDodVjdVJCXvG9g slsJEYd/dUzTMLDchDIsuaxpAILgkuadFxummmDQ8AWcfdKjZILhxsqADGWsGyB7Ta6yXN1G7uyx XPJcfZVEotp33KtzSDtuPhDGzznEXsBunNI0uYOfdUhjEkAkndCJCVb2Frd+eyqNlzugHNOppKqn eHOdqb6VTzob8KrHTsNlADTgNqC4DjhW515HGyENcCBwmBvJVBRNwibfupYAXU1Cx3QC3NJfccK2 tI7bIgQrDtvhAAW2ba97qgwBtuyp4seVA0kX7ICnANsLXVNdpdcC10xrS6yMwd+yAKIlwOpQjbY3 VE6dgqL9lKLRYALSCfUlFoCvQXC97ISPQbH1BUoZZxY3QB9pLHhXF6m3OxUcLBDITXEkg8dkQAJ7 IWtNrqy30rNAp4JNuyF4s3fdHvZRw2AVo0Kv6LqB9zZOuCACEt0Qa643QyKcJA3YXTomue0atimR PAO4Quk8xx09lQW4AEg8oA43seFAAHAuO6PUNXCllsExgAkBGGXF7qX0gjsrvbZEQ3JzUxgkNxtd Kqqv0AE3suTE0VSSXG64vF4WtaXtsGgcL+KY1yf06TVHmDxf4XBVZTNbp/mskFj7heScNbenY5vN t1698Tzf4jk2ZjT9r72XjzDJnyEwNGmx5X7b/F2sVP8AT83ro07OagBI9XKx60HawsEyLUHAE8K5 xqYbr70ez5naOBqR6yRwlxi7hZNqmjWQOEqmBBNzZetPg8UuyqsFo+Fhlms78LMqLkkHj3WMyRrd uSFtHNjdDYxYDlUABvbdCGOmu4KwDwtohb7u2usd7NBuOU03B/CFkLqguINlAK1kC5SJ9ThcDZNk jMVwTdKu4/hWwY8ziI7AbpFJSz+XJK0eu/CzXjc/hLFQ+EaWcE7rSZD7jpbVvjzfhkYnkgcXgksd ZbhvDhQtOCslfMXSujA1ONzwtK2BYi/BsShrGOAe03aT7r290B8ctDkyjioMcJY5osJL7WXqwzSk eTLBuLo+98ZPhnzR1fz80YOZYjawLnWif+QtfPVHpPmvodmZ2C47C2Cdxu17DcEfC2b5i+pF03ps PD5T+rqAL2ib6r/la7fEZ11d10z5LidHTPp8PabRtlN3AL255xyL+z5ulx5cc6fR8BhrpH4nTkPu /UCSStsPhJzBGzAsLaxzSPLaCB7rU1BTtp6llRqLwQLgdl3n0h8TWN9MJoG05EtJEQdLjwvHjdPk +nlTcaNqHix6g55yhkqDEsi04raxv3wtbqNl5uif4mOp2UP4nUsfhNG9v/L+15B52XE4R9VfDqKj bFieW21BA3LRq1f3XCZv+qnBW4e+DAMDqaYyNIc15AAPwF9mGaKikfnsmHLGdro9Q+D/ACpi2Xf1 X8Ub5NS43maTu5w7ror6gMGcMiZ1ps3YRW1FNh8w0a4ATod82XxWRPqqRZcpNGI5a86fe8jNifyu v+uv1CpuruAVuC02CMhhqu8hvp/C1HNCMmyT005Ufb+HbFs+dacfoafEcUmrqKnla5znuPp3Wwvr fk2pzF0VrcKj1OrIaX+QQOXNb8fhamPD34wavoNRuhdgv61styZRzddp5q+rBmupoDS4bgUcGxaD IbryvNeS/SPdLSXjUT4Dpx1lz5lTOkeX6rHJqWnjqTHPSuJAAvbutrGX4RmvotWYfSOE9RWUha08 3JatF+aOrGI58zXLjlXFFh9dK7W4xdze67tyH4+OpHTOhgpMMqYqumjFgyQXICk8rnK0VaTbjpHu zwg9EM3dKM5Yi/FqYQwPke/zDsXtJX23WjBTmfrllCWghe59M4Gd4FxyvA2O/VT6oYjhz6VuHU1P I4f/AHwBuF11gXj76pYJjBxR9Syqk1agHN4XRZftufZ5vizXBtt8UfT6TqP01rsMp6nyaoRHy3g2 IIC0h55xbOGVsZrMuVuIV0DoJHMcPNNni9r8rvrMH1SOp2YMNlo5qGka57Cxrg0gj5Xl3F874nmn Mr8Wx55lqZXXJtblc55owhtZ1xaSSnukj2N4COnrK3MQxesgFQ9jx/NkbqueVsS675SwOp6WYlDX UlC+B9I573GMamkNWtPw5+MPL3RjCTTVNIZHNOrYblcn4lfqRTdV8oOwHLmFSYY17dE9S87ub7Be DC1KTcz35lKlGJ4/r/IpcaxT9KA2EVDmx6dtrlPDfJLhftchcVhdA/FozUSSFgD9ZJPKyf1Ymr3t YbstpBXKf8nR68aairPQfhbylLnPMNPE0hsLZLuLtuFuiwWKkwPpOKWeWJkMVGWEucLfbZaActdS sw9PJW/wiQwlxvrbyvq8Y8UnVfFMLfQzZpqRQvGkwtfbZdoSTas5Z4747Tb54UmQ5bw7Go5q6je2 qq3PiLZBqtc87r7TBeouXcGz/ieE1GK00T5ASQ6UbrQ9hfU7N2FeuizJiELyS67ZXCxQnO2bKvEX 4k/HqqWrd90plOor2zyQdu+z5cdJO+DbpnHwWdPc89SZ8eqMXpJMMmlNQ+nZMA4uve178J+cse6N dAsSwmTCqelp65jwxwhe0m3uVqJqOqGfW/8ALzNiNh2E7rf91xEmbsXxmsL8VxCoqp+f5jySq8qr liWlkmb1+pOF5A8UXTqKgnzDTR0UoDgWTtDmG3tddeDpD0E6FZV8rEcRo5KiNlzNLK18j7fC06wZ yxallLKHGK2hb3bHKQFi4hj9dirhJX41V4iW8tklLv8AuvLKddEjopb97N3XRTxU9LMwYfNgGD1k NHSwktLJSGh49wuIh6R9CcNzxV5rqcWw580shmZBLK0xRvPcArTJBjkVPTCSjqaijm/6CRf+ywaz NOJYmTFJi1S4DsZXLpDNttp8nqyaNTXJsO+oT1Q6bYrh9DhWEVGH1mJktbDJh7WgtAPchd+eDDP/ AE36d9L8LZX5gpaHFqiO8rJZAFptp6Bmrz5ah8r+xc69kdVLXVA0mtnfG3gCQiy4TbnK7Nw02xUb fvHR1A6Z556YyVlPmahrcVw52umbTyguv7FdNeDfx6Ybk6lZl/Nda2PD3/8ALkkNgw8d1rRlZNrD JJ5zCTu1zyVyrqZr6cAt9NtjexC9KyRa2szHTbTd1mnxydFcg4XU4tT4pT1FbM0ny6RoL3ut3svH XTf6h1fSdXsQxavqZDluqm9ETzs1t1r+dQxtj1ukkNvc3TKNkcbXgSOLXcAlZ8qicfhNvs3OZi8X fh8z5NQ12Zn0tTV04vGZAHFvwvleq31CekuX8p1UOVKzXU+U5kcEcdgSRYbLUW+kjkc1g1Au+b2Q QYeY5nl0AlYzklXypKosvwluszcezV/qTMuJ41IwCarndLpA9ysvAaqpp66KtkjBsdvhcUKGKKcy tF9Y+32WZDKWMsHEWXiu+z6uOKhGke0PDP4+Zehx/Q4yx1bhTjcsB3avSmK/VR6RwQivo8LqJMQ0 3sGC91qXqmMmaC9pcT35WM+mjpmEtga/4AsV1wzUezhl08c3Zsvz59VTIOe8AlwvFcp1dQy+qM3A LXDhyfkv6reWsIwRuG1+EyVtMxuhkbh6gz2PYrWM+CA6Xki5G7FIvLja/VA1x7Gy7eVPj0cnokzZ 5iP1dsr4Rhk1Hl/JToJSDoIIa2/4C6Qy19T7OWCZ6rMdlpP1NNUn1UkjjpAXjGhqdMpBpLb/AHEL IqjDpcGsBeUU0iLRKqs2X031i8L0xy1WS3vmt6gx4H9iV0X1r+pNnLqliMTMIdJgGHRv1MigcQ4/ BIXj4RlkY0RkOJ/KzP0ulgcGtJPNlvyx/BHQxi+z3nkr6tOYcq4BT4XjWW48XkhaG/qXON3Dtf3X HZ4+q5nnNdK+iwTCosEp5h5euPeQA+y8NmD03fJZv+1NZUsoZY5WMDmNIdws74rk7fEhZuN+nTlz Mf8ABcZzLjpdJU4o4PMj3ep4O4JXZHjI6x526HZHOY8q4ZBXQwm04mbq037rVlkv6g/Ufpvl2HDc C0QtgAax8jbi347riOo/1B+q/U7BajC8WqqaSkmbpexse39lIZIue6XR4dRpZSW2BwvXXxVZy8QG LQVWOWiZTG7YYrho/ZZfRXxjZ86Fuliy9Uv/AEjzqfTS+pp/C6Ow98sp8yR9i993DsuVnpmPcXB7 S23Zc553J8dHox6WKXJ6a6m/U06rdQsuy4ZHHBhTXs0GWnZpdZeUp6zEcTqJsRxKokqamV13Pkdc kov0mmYiGQkO7XWVMRT0oa4XcuM8m7o9OPCsY2hlMkZId5enclfZ5Q6s45kerjr8v4m6CVuxa1/K 67bK7y3AX0u2IHdJpZqaFxb5Lmm/K52dZRUlTPTTvHr1lpoLUmOPpmNFhtdfCZy8YfWPO9MafFMz 1s0XfQbLqw4rILsYCAeN0HnVDngF40HkWXVZGjyx0sIts7RwTxe9X8v0ApsLzbiFLGBpIEh3C+Wz 11pz91WpGU2ZsenxGGM6mMmdfdfLmLU8FhLQE5kDQeN1Vmkju8UJej6zKXVvqBkCkZ/A8fqcNa0D QIXkDZc1iPij6vY7RT01bnCsqIahpZIHy7EHsuuZWesWkdt27Ipo2SMtyFfN7oPFGXYdLJKDeR/m SFxc5zjySvq6bqLm7BKJtPR47U01IOGRzEafwvjo46eP0yvcwe4WQYGSAaZzKz/aVPPJu2HhjJUz mZeoWZsW8xk+Y8TmP+11Q7Sf8rAosy5iofMbQYnU0ziblzZSCUun8uj2jaL97opZXAayz9gElmc1 TNx08VyKq815qrWGHEMer5aY7Oa6ZxFliUzo4nW1F9z9zis1r2TQu9Gn8pVCyCJzhI3W0rl5H0aW NQ6R3bkDxz9Ruk2GQ4Vg7opKOFmllxey606odZ829dMwCvzRXPkIuWxFx0t/AXA1ElG4FrYwB723 XFyUTPMDopTe61HI49M5TxRm7YZoXNIs+8Y2DVzWCyQUAMclg125XC+ZJTSNH3BNnY6rIPA7/Czb vk7I5zHaDDonx1NPUTQud3jebL56qgh84eTI+aQ8+o3KfIJTCIg4aB7rHfSubZ8Z0yDurup2jLgn 2ZMcTBEWSNkZcfadwkxukAdH+jErLWB4IT4J5gB5xDz72T/NINxcXVeaT7M+OPpGFFhrpGlzmOaP blZrMKMVNyQD8qGpmabNNx8qGSSY8m3snmZfFD8MnDMNoJ2OFTcSdrm6CWjhoS4xRNcD3tZVHTF7 htY+6z9JYA1+6PO2qNLHFGPLgrJ4IyQWlw3WPFl6OFxMcTZndyey5VsbpBYv2HARRONOfRc+91y3 v9K8cX2jiqKjaJnFo0HixR1GGMmfeSNl/cCyzJ2DVrtY34CoDzBcf5RTaNJJKl0YFLQmlqC1uzD7 lSSV0MpBY2Rt1mvBc2yxzT735WrJtX4MgZTVA4ETuVkMZBKwx2Ybd7LGjomg3tdWylEbiRsE3UZj BR9C5MIdI+0Li0HslswsNnMLrEjfUs1hkadnEBGG3Nyd1mU2+LNbI3dCJYvKDRG3b3T45nBl7C4H dWDpKF8d37bX5XKzdgU9W6OQl7zY9kDcUtVO9I08DZE6mbfnhUKZpF7bq7mjNGXA5jgHubqA7FOM dLUyOLmAe1hwsIMc0gA2HCyIo97e6m5lZUlLF/Q8hw7XWPLE94LXPDm9llPhDXFQsA2XSMv0lL0Y YhEYHrIA/p7JQJBcJBqaeAFmujHdKliNtl23f2ZMZn8mZj4ZHQ25siixqs/WtfHUvbOw3ZKHaSEW kjltwhNPG43LQCsOQSPpHdXeotDEIqbNmI0kP+1kzrf9185mXN2Yc1Pibj+NVGMaPtbM8usmekjT 2S/07GP1gAu91087SqJzWGN2wqeJvpDbtbbhNjpGlxLkELSZLX2WUdnGxsvK3Z6aQQuW6DbSOFer QLWSZI3SG4db8IGh9tzdZYHmR4sRuibXuiO7LpbTpsXcIrtJ23CGbGTSw1QDnN027I5KmGTlgDeL LHYQXnZQOa+QghaUmWiP0u2a2yTM0Pbp0rKcLGyGwUciJGDHG9jiOx90Yie06mvLT/3WVoB5VgBo XOzaRjhrnD1dlflN1Ajcp1rKAd7LSZGhbyCQXIXyEWsNk8sDxuOEBItZbUiJCXOe5vsgEkkTxsNK yQBshkY11h3Us0XHUeY7TaxR6Q4/CsRtaywHq91TBpBuTdZsjGsDQdt1HTHcAJfmWPG3dWyRrTf7 kMlB5vubFFuRcIXWcT88I2DQ2w7oBZuOVNQJ3CtzSe6MjjZDSKABUINhbZUTY7ItdhygoF2o7BRh IFiiaQX2VkWKCgbXBQAkDfdNcSANkNtkKLaNJJO91ZO2wsjcL9lGgDkXUsCHM1eoKmC/Kc1obtwE uQWdYcKkQwN223SnAuNgE2Nh0+6EBwcSdkAJY7ZVI3W4D2TnASNsDuquGC1roKABsLIuRdTTuPlR 1rBCUCffujZdwtbZAT2G6NgLdidihAXRBpDhunAGZoNuEDQGA91bH+3CAhBJ4sFN7WVuFyq03Fyd 0AIaR2VkFx3O6NvqA33QtjBde+6Fop3yhAumSc8boQ23woKBc4tOyFzSXe6O1ztuodygoHYGxVPj geSNPqRm2pCIgZNV90sCfJbG/U0beyss0u1p2n1qiwPJb3CpaBYfMdcKyObohEYmXtui0BzNRQUJ Dd7qnNJBRstq33UdyfZCULAsEVibHsoxoN1RdvZBRHxg7qmNupY6rK2nSCpRBgNh8KXuhB9+FXdK AW5VF9jZS1xsVDZOQFfYKwQN1W5G26HS7fZUBtPItf5Rc7d0toJHsmucGsBG5QA6dIsrHHCq9yru QfhQ0iX2VO3+FHPHZQWcOVRQBGklQMvui06j7KgbOt2QnRCbhS23G6vSAShbI4O42QhCDYE8BF5b b3v+ysOBBuhLt0KXsqO43CEIiNghCg5wPwkuLi/4TnG1grDNVroBUjLOFuFLi+xWWYWu4WM6EROu hUUdigc+x3vZMuAbpmpluENCYpOR2Rlm9lH2cBpFlbW255QFSMDxYt47oTGGgAI3XOwKoMCz0CNZ vdW4AuCsizVLDlOwU9jQb32Rsl02NkBINu6rWW9tlAGZS91uyjmDa3ZLcdrjYq2yXIuhljWgOFyb FIkFyGkplwGmxsgI1AX5KEFjYJjCXbIWgjayI3cdtigL+FYaha0hxv3Rt2G6AQ9paPcoo2WG6cHD dUTtshSnXtcBRzWlgN9z2VFyEMubnlVlon27Kxyd1djeyLR6fyoBbSTdW4AqafLFjyVZAJWiAWV6 T7KWVPeYyBa91kF6fhC/09kzUQ0e6F1nIAGu9+ETiA4WUDRZW1u97bIQKMagUt9I6+ztkT9X9OyS 98rBfcqlQBjcCQd7KNB0oY5HyusByn6C07gJZojXAjdVdpJtuhdbVaxUEeje6oC5FgoxhBvyrLSG kqCTSqQj2nYBU+PVwUxrmkfKW5xHHKhSFjgQEJFnImOJ2dyrcyx34QF6rREt5VBx0C43QNe4Gw4T TdzbpYIJPSf+ytrmO/ISyzUPZKFmuVA7UXXtuiYQeQQflBHextsUNzuSgGkX/Kprd9+VUbhb5TBY 790BN2lU48bFG0gi55CmrUdxt7qAVLc29kVgWBERfcb2VabICMFuEX/ZCAbqysgpwtuDdA4Xsisb bKnIAXC/HClrowPSgLrOsBe6tgotJKEgt2RF+nY8qiNbfdQFBmrgJjbtFrK4xYbqSOACAW+47omO vsQo5gLfdA1wjFuSgCLd1UjSTsraO57oZDuEBRYQL3Vxg2Kq5Ku5A+EAQIaLKHhLHPymMuSQ4WQC yw6iUTo2tAcOSmuaGD3uqdpICAx3Mc03GwKJjTcJksukAWQxtLzq7KgIMB31JU0Y1A3Qta5rzvtd Oey7CUshjSUhmdsdisuVnmQxMdYBmwUo23BJRuswlWyWK8oBu3Kq23yiB3uo31FLNC26jyr1lna6 NwsL2Sz7lZILeS6UOOzfZWXWILU22ttuwVBunhCUBpBcCdyrfF5g2FgEYAv8o2vI27KihLxqj030 EIIg9t/VdNmZqcD2V6NOm3CtkMOqifLueQhicG7ELNnYTYjlK8lz9zYflUtGO2XS51gbBQBsp1ab LJ/ROeDsLIdGg6bcIQSxoLiVC0A8LIbFo/BVPYSbAKWBGvcDgIG2ZcvI0nsmmP1AFDO1r7M0KgWX C9goPuCOZgFjwPZDG5rdyeUATgBsOVPuHNigO5d7qwCWoC9XudlBa9xukzvEdmnko2zNpmAu4PdA NaA1+obJgeHmwCWXX9XAKFspD9kA4t0lVpv3QCXU4glG03KACV5abNshYCbmyPRd5FtlGxlhNzsg HAiNrSG7pjt9z/ZJEtwQRYBUZbCx3PZRga0k3JsCpcnkJWshoUMm6yBxDS2/sqbI3QT3QMkbpuTs lyP2uBstMBB24B7lOlvFYDdY+rUQVkn1crIF3uNgiaQRvsj2tbhA4CP1HdAU5wHayhIsCBa6MvbJ HsELRdgIQA2HvcoJoS5ocOydsAhka7UN9lbADGNqG2dsR3SpotH2lZLWgcIHxuvwoBRADWm5v7Ki LmydpGkh2xS2A+ZvuqCC8fAViAzbk2TbeqyAgsNwUsGPI51OCQL2TGMnfF5rSGt9inMcwOJeLi2y jiHwaXAhpPZWwEWBrA4m5t2SiQ4cbomRhtrH0oyGgn2UADY/MeAE+SEh+3ZBGQx+oGwTJ3gAOG9+ Us0UDp53VuIc02sEq5LQVYOw2VKQ2Y0uH3BSIuljudkT2h4CokO2Z2SwW0iHYi/ypLpFr8nslvlN rEbhA6QTBv8Aub3UA4M0E7pQhGvUCjabjfdRp3SwJnsXAf5TmWaLIQL/AP40uQuDxsgMgkBu1iUB cGj5VNt3O6W8bm91AHsTe90ZGtt+6UIyLBG0XNlSBeVdoSnyBj9BF04njfhGY2TAF2zlAYo1C9xZ pVU0XlSn2KymgarOBICoMDZCbbdkKSSTQ74KU59xa2yqS8km3ARyEBo23VAsf8OfSDYoxZ1nWI+E RBfGCFkQtBYLhQGPck+yskiwPdPcANQG5Sd+/KFTLLbAbqFGG7A2VOaLcqlsAAsuRugYTcgpw4sg HKhlhMuHC5ROdcoHgm3ZCXAH5QDC0Hc8qhtzspe4twgALW2JuUA0na3KQ82v7poNm78rHlu07oAn PJA905rPRclYuq1uyeH2j7lAA9ui5CoG7LqSNL7ae6OBnpLDsUANxpG26F7QAEZA3HdTQB9yoINm G+1u6RpMp23AT3X0EWsqije2MkEBKAt7AANF9QVCQ3Ad2RBtjq4KhAIPugKda977qXcANKsgSEAb FS00NyYy5o7qAt1nAc3R6dZB9kprxKA4tLU29hYbhAQ3eNJ2CuMeVud1RubaeVCxwG/KoI9133Gw +FToBK4Oc65HdU32JTGgNNgf7qABzXjYHZHfSbDhW66jSACTuhQtNwDdWX+pJjjIl1a9TT29k07u uBsFCghri+6vTuQFZN2m6FtwpYDcwBrb8oH7mx7I2tKjm90sEa0XGrdXaziQqA7qwdXCApxL/hLf CbXcnt9QPuobubugMdkdt+ytpDQT2KZoKFws2yqBROn5BVt42VNHq32CZ5bSNiqBd3ByYb6L2UbE bd0RfazUAhjdJvZNjiBOoorewV6tIudkI0C54lfp08IHx6HjaxUkkbqLmkXQiXzG3vcoEEW3KF7Q Aqa5znbBHYO2IQooQMe4epNZE2NwsVUEDRc78poDQeeEHZcpa1txz7LFkBdYkWWQQHH/ALIXxOLv wjFAaSAOLK2AG4I291dwWlv9SphJBDtkBUsbXj08hLMOocJsbhG47XTJJmOLAfTugow/0+hrtSVF ThrSXEC65SqDWFjuVj1uioa1rW2KpGYzWNa7ZSSEckqntDAAOULzpFjdVMyzEkgsd+EyKna0HZP8 gbajsURieHgAej3W0zJxpZJrcLelVGQx52XITQhl/crDERkubWIVsUVLE0jzC7f2WLOPNsWiwWUI f5gLzcdwqrYwI/5QSxRiNIddo5ssZ0JJd2Kdpc2VpLdO26jj5kthsFbJQuCmLG7kEd1J2MaP5J3T ww6Q0bkpLqc0s9juCrZKFsjMwGsbjujNOOxRRyPNQI9PoPdPrYRCW2ufwrYowHHSS0tv8q3WLPSs l2kkG3KCWJkYv2+Eshi7k7I2EuaboYwZdbm/a1EHta0Eb3VslAO5sNwrAB5UkaWsLx/ZFGWuju7Y pYoEAE2HCjxYiyvQHbDZC9jgWhLKQs1FDM7SAAVYqI23aT6r2TajDpJGtkjG/sqCRsd5VwLpzRqj 4VDW2MN9hvZMiILD7hSwYz7XPZLIvtdNe0uuRyhezSLjmyWAAbdlZjGxPKjGX3ujkIvbhUli3G3a yEuvsmHYDZCRsTZCFtcdNrbq2kvG+yBrttjv3U1Fxt7IaGloVBoNioznfcIwLk9ghKBc2+5NkBUf 6n2vsi0oRgl+g8Km+ngWJRPeAUsuvv8AKAJzdF3HdC1wcNhZQOI+R8pukOF7WWaKAZLdrq9V91Yb p5tZQhvuqiUbV6PMdTCweYT7brkJ8wfq6UjWCbWO6w8Twxohc1rSPlfEYhUT0Ep9R0cW9l/GI8vg /pLddnw3iBqNeW542OsHDf8AK8l4azy6lzbhrjcr0v1aqHV2GTNJuGi4uvNlPI2OtkLmXPAX7H/G 2onw9a/Zmwv1OcSQTdHUOvGSbLFhi0Pc4E2O9kVTLrj08L9BFWz47Zw1S+8tu6JjbtueUMzCZL2R MBG69Po8r7JMwab+yxLNDibBZNRcjlYDonNJN/2XRHNmTE/SPcJzmukaCG2Q0L2PYQWG/uje17XX ubLSMiZWeS03/wAIYJAIHEGxsmSP8xwtwsV9obk8IBch1R/KUG2CYHBzvhU8Bp3KtAW4XuUiSM2W QS08HdRzLqoGNHD54DZHW08JkbpYpLOjE0R90wsHtZU6JxZsT/dbi6ZmganBhVs1MjLHnjfZDHg9 VTxafSL9gn09bLSRGNxMh7Eo4amY3Lr3K05ESHQ0kkUYa46SBe3uga6nkY5khIdeycyUvvc3Kx5o nhwDWgtPxupuAEtGY4T5Epc4++6VRxvgGuRjXy39rLMjhLQidCHNuruZNqMV9HIS6VrLg8jlSma1 sJcyMee09xsspgla2zH6QeypsDhcl13H2TdIjimZdNiLxH/PZZvsk1Pl1dnFoB/CW+MuYBfYJtPC HNI1C4TcwY0dPHG5xLdYPHwq8gN2I2PdZTGbnuiewFvCikypHGzxPDbMcbJlO50bCNLS8+4WUY7i yU6LsTZb3tikzAkfL5gJAYR3aqq2SVT43l1y3myzjC1w3Qti8sm3Cy3u7JVCIoYppml8YuP8q30T dbhrHlX2b7LII29IsfeyWae255Usm1GS97Y6YRQDSy26xaZgY+7RYhO0+gAK2NseENlxVUpqQJGj SO6Ktkie30O1+4V6QQUMMccJJA3KlsUFR1LaWMER6ifdZBqWOa46LE9gsZ1yijFylhIYx5Nrgtar ligLhI0DzPdNIYGDUlmIcg7JYMZ8Ecl7gglIZSNieS1oBWc5oH5QFl7q3YOP8t8JLgAQeyVobJIH GMB3chcn5d7hLMTSSLWKtkoW1rQAGAhqyIi5hsRsVAxoIULtXB0lE6BT49JuW8+6twL2Bp4TWNMr bF11QkZq0XFwlsUKjh5b2PYpT6S19vws9rLAnhC6zhZLFHGxxSQy6r3IT3OfK476Qebd0wtuUQbZ LFChCGhKebG3ZZDnWG6U4ajt/lUqFCR7RZSMljr8+4KIjSEQHpvyEshjSMY9xdp9SbC7QxrbB1/f shax8jibWCY1rRzuQhQ5C4iwAFksxNd23903WXCxVCwVspW7W2HKZE9zI7JT5d7WQh7i4hSxZc4d I32Pwqp/MiYRs6+26K1jvuoR7GyzbJZBVCMlj2/d2WMaSEudqbYk3FlkuYHAH+r3U0lx33K1djsp sVo7NbsjFKQz0mw9kcV2n4RvEgF2C4HdZf4ShbIPKbcH1KPa2T7tyFDqNiVN90KJcAR6dkBhGm5G 6dpHsiIu1LAiNgPICYY9vTsrayyLkG2xVsFxMu4BZBgA3BWPG7S4X3Ky2NPPIUYESNa08coA3Vsi lOomwQMdvuoCSRC+4BHyr8h0dnMsCiezWAHelLdLIyUMYCW+6pU6GtJbuefdPE12aidvZY+tw2ty lyyOaLWUNWHNUWO1gFWsus1rbj3Snx64wUqWrNGWkHYoRsyjEG7kJbo/UCNgnwSCoZqvdC7Sx4bI dIPCGRYZYbkfujZG5nfZPkpY/KBZIHEKqWmdUNc8mwarYFaTa6vTvyjPawUQEEZV6SNu6ol17g7K wS9/uVClngKNNn7bK9YjNi1Pip2Ss1nb8qUB1PJ6t+AnOcSb8hIiYL3aNuE1xMIBJvdYZoNsh1Da yyCBa90qNjbau/O6LSZGkXus2BbiLoiNNrIDM1rNFrvQCQagTsiYHOAN/dCG8KD1cI7bfha3AG1v hXa+xVadTQVNKu6wCbj8KWsUR2F0Drv4WbBW4d8JoudgUMcZsNXKF8opXhzgXA+yAYQR9w3UeSG3 H9lTneeQ9o9PsiLtTfwgFCV2wsnme7AAPUEi137KxdtygDbMSdwnsGs790jyzoL9lkU7m6Ab7qp0 UI01rpUsOlZge0/deyXVHX9o47rW4lGDbYodAR2PcobLLdgXoAKgA3smaf3QE6XcKFsuM6HHZNLx a6AWPZEG2CnRUwQ472VxuIuDvdW3YmyvfUCpZkq2sG4RxC43HCsDe4Kh2IV5AvuSOVfHq7hFYc22 UI32Sy0BqdKdQ/sjDjbflC4ubuzlG253I3UfIoousPhRpuqcLqN2cs0asPQCb90NyHEI2nna6Ag6 lTNllxsVV9W39SjiQULWEEuWgmFcDYhQjV3VXuD7oRtzyhRrdhugkNh3UsSjFy2xCBiHkht0cYAa CVbgODwqMYIsOEZkcwNABuo77koQk23OyYGub8qAv8K73Ub87Ky0EJZsC10LyA33KbovwgdHqcWj lLIBGC8gg2WQWkNVRs0MsOVGvLdncJYst1i1u+6AmxA5R6NXCtv8q5IvZLKKkd6g0Agn3Vvbobz+ ynqmdrLQ0K32sBe60QWHWQ6e6e1gcpIwWsCpYQvzA3YDdWTftsUDmlgCheQ0CypSE+Ubt3V/cAe5 U2LfdUHENNgpQLc74Q2Bur8tz47qfaAEogTWWbfhRzhYd1czxoACFoAaLqmSwLXvb8KmE3tsArLb 91B7eyAKxAO9goOEJfYXUuTugDbZl+91Dt9ql7jhQcIbDbCS0uclkGxB2CIxvBB8zb2ROCASGG3o KoBztrb/ACmA2JIUJLueUABY4dlGsLdwN/lMF7blTzrCxCAUwOc+5FkLzrf6OUZJcb22RM0t34QC y53BVgktRkByG1gQEBQbdRxspuGqnepuyAW5l7G6jnAC3dNazUzfZV5A03vuhLFNaefdWXaeUWjT 3KoR6v3QlkbZxHsi0WCERBjNtyq1OvcqWKGWsEACsKwwg78KiigdOyJryTY8KAXva1vdE1lrHshQ dHPZW9vpG6mvlBqBUsoWq6lySh03F1f2hLBdrFTYAjuqBuicbW2SzNls9QNlVwBwheHWu3ZAXOAB IsUsgerUSbKtr2VtBDLqNbffuoCgDdWW3KjZtLiHMJUN3Au4QE0G6ItJ45SRrIujBMYFzuUBLG/y oD6rXVuDpNwFA0+y0AxIR22QyN8wbFWQQEBvq22UNIhjLW77qmbph+z5VNG24SygcIxdwuoGg7qP aQ244QFEoHbOuOETm3btygY+12ndRksISAo3DWNtkot0nbZG0m+xQWA4FptdM5ACjhvdQG4UIyrW PuFTgQ4WGyNQ302KArTfnZCW2KgdbY8qx7lCBOFxfulEbo3Ovwo62kDuhaKbe6E31X7Kr6Rsi0+Y LAoKLuOxv8KD7rHhRsQb+QiJF1pFI3Y27Kyzg3Qb89kTH6wfhRlDAH7qOdosSEI73VPsW/8AhQCn yF533Vi5IsN0EjbOFk+L4VAGqx/8K7lzft3QuBc+42ROLm/Chn2LaxxJJ2CK26httdGeAgoXewRa fSN1HNIAVgEoKIQLBX5gA3F1RKjmcexQUFqjI9I02Qvbr+3lVo0mymj2WkaFujN+FQvquU8mwt/l LItyeUYKe6zdkAAI3TANfpt+6jo9A32REBDALbqX244RbOaD2CjnDTcdlSlOcNiQqeRYElDISIg7 3NlRN2hvdZYCY0Ek3QGQ69twiMJJBBsAhaC0nZQDQ4EFY9/WRbb3Rxk6jcW9lchDSABytIBxMNxu mPs3eyBjH3bp5KZJGQdJNiOUYEOaQCbbImEFljsrfOD6AEAF3bEKAbpDB6TdTV6R2QvadrGyu+3C gCDrbDe6ot2VaieOVbAWus/ugIJA0bqPk02PYqSQufc9vhW5zX6QRZrf8oCB4/uqczflUw6iTaw7 InN1FACWkbg3CVqIcbBGWlnJVMLjc2sgKcwO55Ua0MOxRkajc7KnsANwd0BTHFxRPaA4X3UDSFHk 2+UANrG6W4BztkwNJBJVhgYLoAWtIS9REmkt9J7prhsLFDqsCCP3QhYbp5Kp5vxuhbci4N1DqB2G yEsKwuDZGXAOuoDYhDJsLhCph67hULG6Qx9uLo2v3twhSpgCOQCmseGxgd1RbC0Xk3ceEJZpO3CA oEOci24PBUt3tuhcb8oQdGQxtm8ICPUSrZs0KnHlCURoug8oWJHP5VeZZ1keuxsENBNPp3Sy0l1+ ysnfZXbVcXQywbkAgKweyJrLtKjCHCypRco0lE1pJCjm63D4T4WanW4ShQoiwJKC9hqHCyJWbG6x m+km/ChQi8kXAuVLueB7qwLC/CgdYgoCw5zLkncoTYC43J5RG17lWBd1rWCEF3aSLlE4bbKpog52 21lTpLR6QLkd0FAFg/JQBzbEOFiETduULg3XvuVUQANvzuliJpeOya5xbew9SQ6VxI1Nt8rRBjYQ 15BN/lRzBYgBW12+yhY43IOyAw3N1yercBOMLJ2hrjccgJcuqF5BHKKOnkBa4W0/lANtwy1gBsh8 pzXFZZgJ0pUjPUW7oDHbGGkuPKOMl252CDUXOtY2CYyzhYIAhJa4G5QB7rHVsboCDBMDsU6V3mb2 5QAgE2+UYaNQBKjBY772CF77epAW544CHVfb3VN3F1CNttlKAQhuN3bI3Wa0M5S2khvurdb91QRg 3seUzUQfwkx+p2+4TmAhyywWyUvdv2VxvEmoOUDbOKJrANwoCowQ8+ytjg9pA237o2CxNkPkdx37 IWi2ttyo4WHGymh4sT27Ir6ghoBnKuzmHm4UsjaB2QiEOi9ZLiiiHqRu+d0qRpcRY2/CEodLGzYN NyoYiy1woWeTDvuVIHmQEHeyFoXJEDv7Kh/M2O6aXA7Jf2nZqEotlmjT7K3gOGyFjSe9kTQN7lWi gkBoCY1wtxsUt4/luPKbA3VDdw3UKU6w2VHdvp591NY+0DhUPZACfu53QueI3DTyjDdzZA9t+AgJ JqNnHullnt2Rg77lU9zRcclAMYQWhQ7HlLYDbYWHyitY77oCOfc2KEtJt/5RloaLjlU7cXIQBOY2 Rt/ZV57ALW1EJb3aRpOyAX4aLlVAY4lxv2VtBa7bulM8xhs4Jw5tdLARFiCU6Iam6u11iatbrcAL LjkvHoCgJIQ0gjj4SpCS64UcSTa9lTmXsb7hAVGzUTurleXNtayoEhWQXFAWx2lgFrFNbIRsEm1z yjELnjUDwgDuA/VbdU4XN7qywghXpBPsgKuQoLeyE3H7KAl1rcKgOwPZA64Nhyo5xZa+yrVqN1AT cgKmtu5W1pI+VPLIcDdAH5IcRY8IZAWgkblPErWssRYpRcwjd1vygAadYvZLezUdwiLy23Fk5oaT e+yoMVwBsXbBXrtsOE+Qtm/lgWJ4KqGNsTS141O90ADS4u0gK9Ol253TS06fSN0rynG5d2ULZQaR ueENzqJKvzdQ0jhQ2LfwhCyS4cqrOtb3VM9Q2Ruu0CyAU5jtwUh7HtuTwssucTultfoks4XBQB0k Otmo7eyY+V0TSCbgoQ8tuBwUDtnXcUAsytAsRspuDcbhCQS83HpVOaQLAoBly06mnZOe4FoJ7pbW 2aN1b2F1gOEBbWtc7SCL88oA0l/PCYGMZuD6irbCWnfhAEwEm5NwrLARso0EavZA2Q3sjATYLD0j ZE1trhQS6AUBl1bnhZNFm5OynHKFpub7lFqB7IwXvqO9gqDbuNlZbcFXE3ZAUx13lqMnSbW57pYs wk902M+bygsVYtJPZE121kZN3aVHNDDbZAA6Tyx2srOh9t90qW7tgLoSdAG9itEHEAndTTY7cJAl P5KNhuLqMoT5t7NO6oPvzsULmgi/dC0+6IBvmLON0D5i5pcf7JrLWvyVRjv2tf3VBjx7+qydBGNL rK2tc17Ra4TrBt7bEqdgW1hjaPlC6Rt9PdMLy4WS3aWG5Bv7qdAJu7bXIVy2A2G6Nguy9lbowGXv v7JYAYQWjY3RayEMYLwQTYBW3Y25CWAGMDHl5CEjzJLjYJ0l7WCqFlr3QAkNBsUL4mvc022Cp7tU 1kUlmkNugBqpg6wHI7pcY3F099O0R3HISGuBKqARgFiSblLJDzpcOE4NJb937JcgtuBuqSgHFtvX x2ReZqHpKIxtkbY7qhA24Db/AClihbxrbqPPshbDcHsVkeU1rwCLBE70P0+/BVsUYr6Qv34VOpdT BvusvSTY9koO0yFu+5U3EowJMPJJN7/CD9HpAFhdcwWNHI3KRLARJstJijj/ACGxWI3ISp6T9Q7z B27LPc5sYcHDdYsjt7t49lqyUY9TC6SLTELP7FC2OQQgSbvCy4HuDrkf4T3x6mku3VslHGaWu7Xc hjjbqc2YaQeLpp9BsBYojTmpYLkek3KWQxYYPKlfAweh+5KyZcJhaxob/dHALyuHFhsUcMgYXNeS fZLFWYwomxsPpLwsaSk8/wD6GrlA7TcDukzAObpBFyrYo4llr6G722ujkpZXsu0XKyY6TyybbkrJ hmbTH1C6WSjiosJe46pGfK5OKpETS32FrLM80VDQ5uzR2WK+EOkJta6tijAdPdxBAG6NkYLb33R1 FC58gcOEyKAxSBpFxZLFGK2le4OtsEAi8tpYdyFn1DaqEa4mB0Z2IPKc6j82ASGzXWVTFHDNjc1w JGyqb1PuBsVmyxF0dhylMhMQ0uF791bJRhm4BB4RxAStLQd+Fkuo3t3IuFkR0gjZcMtfulijEGHR wytFySRcqSU9rkcJrnEOLifV2SXTaSdTt/ZLFANBB+FeoubsBZUJA8ndTyyO+yt8EADmsdueVHRl p1atlU1M19vVZLLjby7nZSzLDL2kcKvLJGyjCGNAO6IEl23CoB8p7+OPZMjNtjtZU1ziTujv6Dsh op7w78BBYHdU0c91dgnIs3E4lh7RA46dguuc04Yx8DyBYruaqY1zSCA664HFMtQV0DvSLkbhfxaD imf0ufKPH3UulkjpJPaxuSvOdQ5sdY8HYl1l7d6rZHazAq54YRoYSLLw5XDViLoibESHdfr/APGy Uuj4GrVI5BmhwGm9+5SakC4IWdEyNrQxvI5S5omuB27L9KmfFaOIc25OyMM9Oyj5hBJpLCQe6ouc 0g9iu6dnnaox6mOw2KwJSWyAA7LlanToBvuuPmc0AkjddYnJh0byHkDcLPdI5x06Nu5XGU9Qx0gs uVjk1M0jYnuulGTDmAaXaVhlvmN9W6zZoyx5B7rEfs6w4SgILW6zbslOjcTc8JshN7jayjXtcRqB /CUBEUd5Xb7Kw1z5gP6QshtOTGSPSUDQ8fd/cICE2cW2TImXKQ15Mh2WVG745RAoNY4+kXITBoba 42QhmgHT3Rn7bWuVTIIfG77DurcbK2NDQPSB+yMgad0IA0akz0gWFrpTn6XWA2KMxNFnclC8Al2/ CiIjVb3ULDYLVkKI2upHZrr3t+FC2yq1t77oWhzGBjSRueUNi42QB5sVZNkIUW7lC5t+dyjPcqrF yAGypXqF7d0Jfd+louR7ICy2wQ6SmODrbobboAbaAe5RMG6l23Goq3kA3BQAyENdY90YYNAKRK0u dcJrHDy7E8ICNvfshDTrveyYLFVp1usEAVQ/0ttuSiLSWWBslaCHAdwj2O190BLEfKKw2VAXsqPK AaI7tuCqdEGi9rlA2Qi4Rk6ggMe26lr9kbgL/wDwoyxHsgLa7Q0ho391UNOyG8m7nHkFFaxRgndC 8BMkMgOoafZLktdVqMgso5jjs7a3dVEBAuUYjLht2Qtu3jhNY/kDcqAxpmWsUsAp84vYd7oLaTYo BZaC0+6plwwghN0/CrSgFB2nYBQNvvZMLbqcIALWVEb3TLKjxwgFObfeyl990zTtwq0jTfugK47K w26INUA5QAts0ouXXClgoRtsqAr6SNrom1EjNgdikg2+Ud7qAJ9nEFU5pvzsoERFxwgA0KWR6fZU WoAL9lALKOGkjvdU87fKAYxgc4brPg0RC5NysCJpI2O6yHEabd7ICqrS95Ldljtbp3RF2n07/lUJ A702/dAF5XnODibAIGSXc/TuGpkbi1pSqT0iW/8AUUBeou37qnt188oraXFTULqgAg6duAsSua0t AOyy3fAvuglpmzs3NiEAqik8oBg7rIni85w18hLhaAA3TuO6yQB/VyoCmQhrbgrIjm8qmfG3lxWM 3Zw7hMJF9kAAFj8IuArLC23e6a1rSQPdAIs7TxYJsMbnXc3kI52FgFrFDGyQ/abIUjQdxI3dPjcS 3Q4WaqjhcdyblObc7EKMqLEZMYa02F7p4gBA1G/yoxvltBdYAp79OgBc3yaoQGgGwOybGdANkmR7 WOAKcw6hsDZYKBR0wdM97juf8IpqRofzdG5/ljZQP1Ae6AGVgEY0hSBuprgUxxvb2UO7vSdkAhx0 u0gKyLi/CMx2eTyULybj57IAXC7dgpbRwn6Q1vCS+wKCgCCSCEUsXmNIFrq2g234Qa3XJHAQULaH AAcWV7tfvwnMIlu29ihljcW2HPuqZI5pHrHCASNI3PKCFkzH2lcC34RyRhz/AEhXkBtOlmxTYbaS Vi3IdZOa8NbuhTLDuFbmix3StrNLUdhflUtiXtDeEFro5BZ22yC9ihGQNuqsA7i6I6iAQOVBdr79 1lkJpFthYqBhHJTB6ueUBuoAHWafdWTtxspdrNnblUCbj2VoBtO/KInb5QabFEFoFkC3sqFgVDxd Kc7f59lgDri/CFxAKKOPW35TYoWDd9/i6AUGB7bjdVo7og8iSzRZqY4XKFsQTpVg37q5muc3YKmt LRuhCtNxvwVC0tAsdvZE8bBU4HUGhaQ6B2ab8q7ghX5Zbe6G1yVS2WBb5V6rKMHpCsNF0CKADnWK cwAC2lLDQdxz8o2uNvlDRTjZ1uFGi/dQtvuoNkIRRUfdQFRj2GCrYLFLGwJTGHcbrJSxFY3b3S3t N7EJhBHBVOaQQSgLYNLTZW1297XQudYWQuBG4VQGSPGg2/sk3AtqULXyi7drKEBzR/uVZGMYPSSO EpwJJsmgaGAI7gCyyDGdE5zb8kIPLceTayyi+x4SyS9x2sqPYsM07DhHrDXWIuFBzZU4Bx9leQWJ dRIGwQXv6fdVb12amCK49ilkAtYW5sqdG57bjsiNo3aTyUJBbxcBLIW0ENF+UYbbdKc4khGCbfKo Lc30hVa1kHmEbEEohypYD1aeQq1gBURflQi9ks2MaQG35Uae5Qu34CrulgYQNWyG10NzfZHG0uue FQUW2sqc1pIuhLy1/vZGCJbW2tyEAJGm2yLSLbqSOBNh2UJu3hACfQ6yo/HCE37qb2sOUIELAblW bG2kKgLjdQN2UsyESLfhUDcWVFujk8qyALXSzVCiWh1r2VnYbIixjnA2QubZ1uyligb27qy0mxvs r0j9kQAI27LRQVCLjlFpVWO+1kBGgnjhWSQLd0LZLc7IiC86gssFBhJu5VpF9hdM1EqjwlgonT2Q izh3TWNJYXchKF3A7WCWCN45Vl1yoGbKaQf2UMFgg91Um4HwrLAhfs3blAGZNQQBuo82VC7hxZX9 o3O6oCL9wNiPdU5+g2PBS3Htyi1gkX3SgF7Jh0kG/KAkF1rIrHUtGwWvLTZXY6lcnHCW27d7oAi4 3t3VXVu03v39lL3beyzyCXRPfsLIWn08bqX32UBbZ2hujT+6uRwDRbhCW7oXHe1tvdCELR2JSwxr Tfkq9RuqNyQhCz6t0QIA43Q7jayF79LflCDOTclXseEht3Dc7pzOUBYBvdW6S5FhwoTbhUze5sqg Q2kN7Wso4aQd7qW9NvdV5TgOboAR+EenULoDqDgOyYzY2PAUKmU4NjZe1yki97jb8J0tnIbdgdkN FhxcbK3gAgEoWje6Jw1cj8LVksq172UDQG3B3RemIC/JQ2324UKR+wFvuKNrNQseVTgNTb72Ue0k 6gbBLArTZ5FkTfSjcS5vpSnOAsDyUARJ2RA3Nz2RNYCAFYbbayEMaW5kBHCY51m7bo3EN2ABSw64 IIsoUNjhI0EKyCBtypEAwKONyTdAUW32KDSQ097IgbDdXG+1xblACPc7q7gBUBckK9IsgKeQWE8r GlcdrJ0jCWkApQaQ4AjdaBl0sUbotTpQ13sVUrC/Y7D3VthDYi57QT2VNd5jPwoShJu1uk8KAWcA eCo70vB5CoQPdTSSuNrcBGCpXAPYP6QURs6UvaLBY9M4VLQRwFlbtUKQPCEm5VWuiOwCAEt244S3 u188hNcTp23KFrQ4XOyoChlMbtjZHI7WSSls/wAJjgDZQAPsbEbWQsALj7qSQmM3J2Kkfp3G6AIj dXf2VX7KDhWgR25FtircC7e6lxb5VlpAulAfTzAEtNiFHmN2zefdYv2G6bCQQTsgLczYX2QtB1cq 5LlA11zxwoC5nhpBPAQRSsLtjcFSpsYzfugp4o2Ptq3VYMqQM0drpBFyEyS2rZA1tz7KAomwvdE1 wJsoWAki+yrySBsd0BA25IBQi+mzvdHocwXUIL7G1rIAHDjdUWfF0RaVZaQ0IRgMszYC3wrdNfa2 4RNYbX7oDGdWooEgQ+7lWq+3ZF5e5U8q97IA44x7bKPDQbhQStY3Rf1IXGx3uhQi2OVvqHqCo7fh LDC5wtwshzO57IBYuRtyo4X9Kt12nYbKybC6ADiwU1Ii24Q7XQELA/cbWUtY3KJpDb7JLT6zc7IA 3HSwu7XQteDu1XI0SNAvZCWtZwhGMkcbCxUjYbkgKm+sBNuQxCgtcdW43TmCx3Nkhkm+4sfdVIHP mZ/t7m6AIyBzyN1RjL7b7InAB9wrNxe210BZAAsEtzblThEXADcICrXv8Ii6zdxx3Vawd1dg5tig FEm5vuCmOiGgW2KgBDdJ/uqYS0EXugFuba10BLbE239062rcoS0WtbZX0ShTg4tuExkbTGS4XPsV BqIBA2Cpt43X7IiUYb7CfcaR7JxFgNJRyxCd2sdu6S4XI3sQtEF1YAA1i/yEcWkNGl23yrdzY+pV ouBYIBzJSDe+yGR2+oIWNFt0DwL2vugK8zta3yoHA7jZQs0s1c3RCPTY8goBYjEj7nkI5DcC21kQ A1elQNuTflAC11hvuVT/AFAbbIy303I3QtOv7uEAIad7cI2tupYafSi1tHJ7KMBelrDdJdGXWtsE QcHj3RNlFiLWsoABF5TtjdNZIHEgFBq8wbBW2Le44Rl4G2te11BfgbJjW6v2RGwAsoUT5lkfmem4 O4V6Q4kcJLiGOtyEKXqfNtfSj06I7DlCwgHZW4GyAFr9d28fKZGNJtyfdCB6UTRYboAyedkjS4En /uns9N0twve6AJxLo2gqAaGmyjHDTZW46hdvAQAMbZwJUdcvNuEwC52Nz3U1tbcWQABu/KgAsTdR ouO6gYBdWwCRcEHuikqHta1jW+nhVa4Rs9O53UALIibkiyp0jePZOu692jYpbogSSUBTXeyXrLHW Kb22SnxnVdAWQHG4CrSL8bqAloVkICB2oEWshAIRNJcD7qFpBF+EALgXltv3Qz32a0ow3Sb90uUW N3GyEBY8bNk5KZFL5LyAL3QOg1ND+R7om/bcbkIUN5N7luyo2B+SiA1izlbbntwgFbRtJcCslhPl 3A2KEtD+drIg4OGluwCAQTdQWaFbixrrHlXYW22QF3CgaHDmx9kJGk3KKO1yUAwRq/J03LUDpw23 b5U/UgD3CApsjwfVdS7i47KzK14uEp733s3hAMjqvLk0Obe6fO4abNGlx7JLWDYkeoJstg0OOxQA O9TAHfcltcLW5RtaZCqb6bmyAtpLHXI2TWu13PCW9wc26Bjx3KFsc9txYoHUkcgsX+rtuiDr/hKE QDtRPq9kLRbaZwPqNwEYtoIV+btZA/duypKKY8NeCeyA1AL7EXJR6dlT4GtAPJKhA2SEn2VkahYc LHALL24ToSdPygA8sNJtsEDgffZZEjSBusd7bBAXHcd0UjS4CxsgYLEEH8pxZcXvZAAQdAvygdK1 zdJFiO6NwP5Q+U1wII2QBMZqbyhdYyAFMaAWi3ZCYw6UH2QDJQGsOyxL7XKyKl3mDS072SKeMh1p Tb2QBcd+eyNv2m5VujG26GQWbsgL033TSSGXSQC1oumAjTugCadbSqsGlCZGsbZovdA5+w90ZUGR cbICNrIm6m2JF7qcuJ7IUOPZvujFuLIB6d77KxIw3sbn2SgQmx3GyoHS6w2BUL9XCgGkXKlAPa3w q1aCbKAh42CssDm7cpRPZIjrde3Ck279r3VwNcwm/BUIKclKjhLncoJI9j3IT4WEG5KL02clkowG C532TGvAHwpM0F22yKOJ3GypSo/517C1lT2XNj+6yBaIcWS9LXuBN+UJ7AbGBwmF+1iFchaHAN2C Aus7fcKFD8y2wChO91QN0Y4UAoC5KE73KJx3KpjLvBP2oC4XFref2TGAG5co5rXH07KnglotugAd ICSB2Vh2ngpOrS6wCY/RcAusUAZlNxbhFqOxsgDONwrD7GxO4QCnR2dfe6vyS5wumgAm5ULr8f4Q CnucxpHZY9+SnyONnHtbusVrnX3F/haA4DurI2ur1C4BFr8I3t0NQAMFnja4TXAb2CVC7S834TS7 USPdRgXqAFjuVQfqeLqNB3tyjab88qAhuW+nhMLA4D3QF92kDZVbQBugHENIuQlX1ybKtzY6rBGx wa7jb3VQMGaEvmIUio2MPuU83Eh25RtBaeFoUBFSB17bFVJTOa07iw7LNhANzspUgPi9OzlUyUcB JGC425TKWIRNd5oIvwsp1Oy+rVuOyYWGVouL27pZKOPkhAcC07I3RNERcRdw4WQKNxvbYKOiGggn cKijDj1PbciwRCmZJvfcLJjjGiyuSEN0kbBLFGM+AAWaf7pJgaW+oepZjtpNI4KKONtQ4gC5CWDB ZG63p2antZdl7b+6zYoWi7TZOdC1jNufZSwccKcOiuTuriisbnf8pztLRYbqy8BosLpYMaSkEkly 9wHsFctLaKwfqHsm7ub6bX+UMjSWf7SqmQwhGWNN0bYdcRdwQrqIybWN1bWlrxcm1loUSH1CzhdD c7t7LIdYGzeUt9yywH7pYowJKUPcbrDmpgx1jv7Lln20Ad0BiaSCN/dVMjRxVPRXcbm35T3RNa6x dwnVFM4FzgdvysGdrmQ6mguK1ZmhL3B8m23yqLQSD3QROLhct0lZD4tbR2KGKA027XRxgAqNaRYH lVI7SLq2EiGweVbdoyEABcC5U4+mytiynDS0m4VNdcBJkF9kbYzpCpDc7NO/W31+kFZbJQ9oIsV8 qcVaWHUSFx9LmOWKqLHO9BNuV/Eq55P6a2Z2daGPEMDxGMgXdC//ALLWRjNIRmqqjYf+XK4f5Wyv H8XaaGqAcAHREX/Za38zXw/OuJM7umcb/uv0v+H/AJSPk62KaKay0riDZPIHln/useN2l+/crKe4 dvUv1x+eOIqakQhwLQfYrCbM55JIWRXs/m3I5WIx9iQQvXBcHkk+RliRcrAqHa7bd91nH0hYVVGX mwNguyMPkRXVDRNGKZnHJC5mkcHxAgeqy4uhiaH7jZczCWxtszhbMCKmTVa4sQsBzi95+Fn1s7DY Bu/crii7S8278pZoNg1E3ChjLDcjb4VNcQNkwyOeLHhSzJbJQ5pHwkmTS4Ntsr02NgN0WhrW7j1q AVHCWSucdwU9rgTZK87y9nHYo426m7LSYH6NgVSYDoYNkD9yfdaIy1OeUDRZHbcd1SUUeOFTrlMI VWugoDSRZFc2srG35V2vZAXp17eyExgi52RXIO3KuUAtvezvZCCCLbBQ3bbe6N4Gi/dADYcXQtl2 Nt0Bc5h2FwmfdspEwtu0lCCXssdW9yrhPl3IG57pxbfnZQ6RsgAMxc3SR+6BzHabgphto45RRAEE EoDEdH5hHqsQrElvTyUZjDiQDwr8jYO5+UAN3coC4tBt3WQYi1t7oWtLfUWoCma4/v4ViQA+ydFe of6tggngETvjsgIPV6rqrepJMrgCAjaSWNJQDGg9lWsge6Yz7CRykuaQ0kboAnSN0fJUjZqbcOSw zVZG1rmGwQBlui2rf5UFi66cRrjAKWWNa3lAQjew4VhiASg7W3ROkGmw+72QCKm9OWu1bFNYXPZr uCFYhM8dpBYqBvkt0t+1AKa5znaQNkxn8g6juUTS223KF25udygFSyl79XCmokb7kKi03v2V7AFA V8gqchRrdZBBssyKJuggjcoDD1KN3TahrY9r7pJeG7IA1RVtGrfsr0XQAFotyqczjT+6IlSNt9ye EBbmANubKfcNgiJuLBV3QC7bqnXBsm7XsqtugEkkFEN+yh+5GB6uNkBTXW7JjXILi6gdygGWv3QO HdQuAAUJu3Y2QFG10LwWEX4Vttax5TCwPbY8oAAQAC3umghwsT+EprdFxyiERe27dz7IRCp3aL7F DTyAglw3TTC8NOoXStAA2QoTb7347ImmzUQOtoI7IfLvt3QEJsCSh5Fxuo8OBt2VwgvNgL3QB07b eohGGtJJCd+mIZa9lXlMYfUUAqwDr2QPO9+3snu0tGxusWWSx2F0A2JzdJPcKmNe5/FgUEJLyNtK e0Eb3QFzekC3Puq13HNyruXcoXRg3sN0A0A+UCSrjeAULHECztgoRruW7rJszo9OgEbko22Y+5CV BHqaLmxCyQwAkcqNlRJwJwADaysOBcPjZB5drlpRMYNXysmgJ4dTtQRxOcG2TNBcpYA2vuFKALmi MhxN79lbDqN7bKBvmA3902MaOTt7KAW6z3AHb4QlxjuAifcuNgiYwO3PIUAIDmkE90ZAJB5Vkkmx 4UAA27IZYL3nhBp1bq3N1uNioBp2KosFwPCFrSDZHJc8K2exbx3UIC6NwsQia8tbYi6Zqa4WPISX vIdsNkAp5JfcJsew1EbqBgd6lbiGNsR+6oALdQ7flKazS7c3RmS5FuFbRe9+6WAmOANkwu2uEqJg 3vyj1W2VsEazVcuKsMsfdXta3dAXEH4SwGQUBBB/8Ig/UVHgg6lOAQv0kK7X3HCpoDhc8qOBH4Vo AObc6rKX7Ii4q3ECyoKvuraNlVvhFsAgKcb7HhKIFz2TCdRsEs/d8hCoyadgF3FybI4ytN7BIBu0 2TGuBYBbss0UFxaWWafUFbCQ33KBrNDiT3TwG2QAEOcCe/sgDi+7SN08N3ACp2zrAbqGTGO50lSI jVZZH6a/qKxNYbUWWwOd6nboS3Q/4RSuFxYbKnAEXQF72OyofhE54DbKACyGkUGgjlFYe6lxbhCb HZChW2Qkb8qAW5RNbc7lACeFdiWhVp1HZXct2KELbtybq9tXZQaTYKtPJQoRcPlXqDkIBBQg6Sbb oAy0/soQCbX5VtfdvulucNaAKK8LyCbtKjoyJgGDUDuo9o91PIcXAtfa3sgCmeQOLWQsdqcFUg3I vcqmXaC48hANme0WFgEsHa6BxMm5TAzS2ylEKsL3Vct2F1bQdVkboyxhVKY5dZ22xT4zZg33WL6z IB2WSRosO3ugFkh9Ve3AVvN22KjTqfsf3Ukj1HYoCmAAE21H2RAem52QRgsKKQkAIShVwCSj0l7b hDYFvyi0aQLGwQUV+6vjcqrhThwKlCgibhWQbXG6vZ3bdWAEYLaNtxuqe0j1XsFTQS4nsicWubc8 LIEeYCeE6NlnXGyEtb2F0bSHNsrYsSQS4o2ktG/KGV2n0jlRly255SwR++9lTRfhEZC3YjZW229i jZSjZlgVZ/whdYvAKY4W2A2QAO9Vr7KGz9hyha8l1kwNFyQdx7KABtw6xVSdxf8AdGYyQXEgIHN9 PN0AMZL2O+FTdhZGC1rbcKNALSRuqCAcKON7b8KC4A3QOuCoAiWnaykZsLX/AGVNbcpgYA32KAvW 223KG92m6q2mxV27W2VIw4nnQRyFX+Aga7Re2ygs61zZKIHsRZBpDb2N00sjt9yXbfbj3ULRTbuB Vt59yiaDYqEaG37qigjEdOrTt8JJaHbnYLIp5nMFidj7oZqfzDtt+E9ihbGs4dz2U8ht78H2VOge 2Rp7IiS12/CtkoEbE7furaTdUXAjhVqsbgbqWaGEG1jshNiLIXOe+1gi1Dy9I+5VAq13DiyMWF1R cGsHf3RcWQAabjY7KwzSdt0VgL34VarbgqUBZcbWIV21tsitc3KGSQ39IshGAYyxylvlEQXWJKB1 weFAwrXugI2N90YNwUsiwQlFMsXcJz3ahsLJLASTfZMLTsLoQIcKHYKr2Fibq3EKgoOvYIdZa6wN 0UbNRPwiY5oJuEAsyayDaxVaHPJI4VuIcSQNkbXaQLFWjSAcyw7qAWZcmyYZCPlW0B17gWWSgssW XaLoSSCoSGHS3ZU4kOAtdCcEcwyOB7Jhaoy4BPA9lR+EATWNJ+VI3ea8xcKm3vsLe6YCGuu0eo90 KA6MxOseEjUHy24WSSS65KU5zXzDa1ubIAybWAQvdxcpxAI2H7hKBFrEIAXPFgRypbULqFoadt1d yT8ICxYixQOJDgP6VDGXb91drHdAQXuoTpdxsrJI3A3UadfPKEBLC43GygbY3R3so47cIUHTqcCO ET2B7hfj3Sw4geyNr9VkBT/QLayQhhda9xcI5Ga27cqMAaACLKoFmMOZxuhfq0kW9J2ARgnSQ0pb i62/bZAIgj8hpAFrm6cDtzdDKbNFlL2aFATc7AKFu3ur7bIWgi5NygITxYJczHObcH9k239lX/lW wVE3SwX5Rk627IXH1AK3Bzdh37pYB+42cdgrAAVFpurLdh7qAsWJUIBUawgKFpurYIAQjkHoAtuo xptusmKnMrQlgwQN7O2Cj2NjIDHXusqoiaG2Kx9IaQW9kBTiRyqBF9tgreS65PdUyDUNQKqBHGws LEqRucXgOaB8q5W2AtsQpf078qMEc71KAgINN+OUDgdW/ZQDtWrsoeRZAx4vYbpoNkABkdewRC/d WLX32VusN0AJ53N1XblU4i97qwQdkAbDqbZW4IWttwo8OFj2QF3AHCoNBKT5u5TA70oCPjY88AOH dLeS4kDdHe4UsQNkBcMRba/dMJH5QAuPKovN0AUos1u2yWXbJg9XdDIz0lARo1AFLkIFwOUcQLhz sgmjNtkALbvjLhyEHPITIRoZb3UDDttshLIGB3eyjou6NsRJJvsqL7GyDsEXaEeohtygPN77IwNX G6AEkBwJTNQLeEB9iLEKbFCl62N73ViTV2S/JAN0YdsBZAFZU43PyruFCRcEBADtdQnSVbrWVXBb tygLsDa/dURa6sNLeVHNAdc8ICW2VObxurDr8IwARvygE2I2HCF4DTumutGbpZaHWPuqgJbG/WbG zEQa0gnZP8v0kBYop/LBF7j5VshekAXCFpPNtlC4b27K72ZcpwRooN2udroHxXdubBOa8PtcK5GN JRijGMbtIAO10wXViwNkIcQSoCD0k+6rcFHa+/dW5pcqiFbFvwh9IaArtp2tdQt7hUrEyEsPp4KF 0J0ayRb2TwLbkXQaTq42JQhTGFrLhGfW3dMIDXi3CpxA2G6lAqI6e10yNw177BKMgjCU57jbsEoG dLKOGD90qR5ZHqJ/ZY8cpc+yIMLnbm49lAE2USNBJLb91csej1B2pDNMzy9IG4RUdpG3PAQtkjk8 w77EJwAvubpDjpkNuPhCHlrtjsgMkDbZMI2ukxPdsLixWQbNbZC2CBshLSB8KzcqiTx2QpTCP3Vg adhwoQGkG17oXOGqx2UAYJYPTuUDgRuUbGm47JksRB2KAUwgjbZTUSjLL790t1wbEbICuQbmybHF c7G6WI9tkbJTE4+yMDD/AC7hAXgAlA+YucSlB4PwpYCYXPk+E8tDjYHdLY4NH/lLkkAdsVQRzNLt +VYFzcoN5Xar/smNGoWQEAAV3F1A2zfwqDd+d0BTgWuBAuEqqBebk2CaWOve6rQJG2Qgpk4kZ5Wn 0hMjs0aRx7K2aItgN1ToyX6iUKF5eoogbXA5Q6idgFZuBzugL0i25QgaTtwjIFrnlDwgB0N1XO5U Au8nsrIuVQu0i6AKVmqwGyotc1tm8poN0LzpI+UAsS+WC2SMO+Vcbm2va6M6e/KHZp24QAbOf7BW QWvuOB2RsZckq7AboCg+4uRYq3PD9IP9kEjrC7Uh2oSDa5QGWb6zp4Vb3PykROc15J291k2D2oAO 1kGi7rKBjmuN9vZRly/nZAN02CF19Vwi7fKoje/KGrKFweFYcBcnhXeyE7jhAES0bg7IXPubg3Hs qcNghG3wgLJ9tiijOlx7qrd+6rSb37+yGaCI1uNygLbuseEbWb391ZItdAAz0kgKzIbqEgBDqF+E ATiNFlGbN3KEg6wrc0tO/dAE022G10RbZt77pIJuic4nbkIUqxB1e6CQF7tV9x2RkkAFCAASfdCF Wc61yrLS4WJ2VkatwoWDTud0BbQH2DnbBU8AGw4VNAayxRMN23IQAFhB+E9kYERvyha2zr8o9Ws2 vt7IVCyXEgdlCCDa92qOH8w2JRFhYQQdV0Fi3RvkFm8JccDmSbggFZRe7UNIsO6ComM9PI1jdLxw ULZbYyxvKpxLOUunL2RNa/d6ZICQARupYLa8k7DZOGwCx/sHsnRt89m5KooJwLNxuCpq9FyqaCGl qp0JLDdLA3zGGLc2Pyqd5cdgHXJC4+oBLQL2+EP2xi53WQZcl0UTiwg82WNSy+ZJuD+6zDYXFtlo Ee9sh3QGRrEOgDckoW6bWIWSINp1C5Cs2O9lNtO39lGtI37IWyBzVHHblQwh7bjlUIyAb8oCabi6 IXLbBBGTwRwnktAtcAHlAUCGM9/lLEnrshJ5aDqCqINadzulACpLgBoF3JkcnmxgSMAeO6YWDtv8 qy1rR8rQA08WCosubnlWXer8KAlzfZAR3paOyAEi5Aui2O3Ksu0DdKAreQEHYK/JuL24R+c3sDuq D79lkAGMPc0FHNdrdKgIF9rIJHbGwuVQA31BO8qwuTZIDTYJwLiQL7JQADS1xsUbALb8qEckdlQJ udtioAiNtlLXKoAaTvuqBJCqAN9J33TGW32SnW5TI37KghG+r/Cj5ABYDdWXdwgAv2QBxkNaQDuh c5xFkcYBalznRaxQFCO54Tb6G7IGNcG390wfba6AQXv80C9mqTxsYPS7c9kcjg4Fo5S2+XGTqGp3 uqAGxHY32RuGoj2CMtbbZx3VkaG3G9lAIdqc4bI2aYrkcn2TmOD26rWKW9okeLbBALDyH8Jt9ew2 KGSG/BTYbRt9ygESwaTb37qiC3blMkkc38H3S7m9+QhGJljLXe3wgDrOs47J0zi4h3A7pABdfa9+ FUQPyg65v+EDGuc7cce6yIIdDbu2PsrqJAW2Gy0DHfe+m37qFpLduUbJGad9yo14390BjFpLrPBH yqcA0GyynN8yM6hwsV8ZtcHZAR0ZIsUE0QMVmt2WTALDfco3xgbdlbMs+fqKR0jgWbfCY2hlc2xN vlcjNT7WAseykUTmMDXG7lUzNHFSQOiHqN/lYxna52gjdclXUcr5RYen4QVNNHG1hA9XdbslGJGz +Wd9/ZKf6W7pz2aXC3dIkppnC/IuqmZosNa8XRgABXHEGNGrYojGL7HZWxRswx7G6qhq3xhtmN4X HxY3JWSNINz3sufznhRdHI63qJ5XwOG0smH1hDnkhxX8c2KdH9DlJxOfx+vngw+Rz3+gtNl4nz89 wzlUz6bhzybr2ti+GSYrh8jGOv6eF426gQyUuaKyCZp1Medl9/8AxaUZcHz9VbhZxjG67PJuE90g 8sloF1hwEiG4+09gnxm8f5X6w+Czj6u7iS9YQIebrOrm2KwzHYgr1xfB5JLkNxNlg1OrWeyzTubX /ZYkrdUhDjYe66o5gUsnlzG4291ycEjdJPuuNDA1w3uFlsJ03GzQtMyLqnBpOndYkTN9+T3T3u8x xB2Szp1blEasYIxa1r7qOG9h2Q69BNt1BMWm9rqEZQFiVFe/3EXurHG4VQQLY45TZ3Ka1nkj3aUo sDSDeyyKYN1Wl2aeFQyOBs1A9ji652Ce6AyPBYfSOyJ0WshvBCpDGAN9I3RgWsjNK9h1H7QqNu25 VQJwEPN7o7bBXpsNxsqRggC23KJrduUov3Nhso0E3I4QlBubpFyUoNLySjaQ87uupcNJaOEICGkB Qg+39kfItwgLgNu6FRACDe9ioBvyiDb8qCwKFYNwDY8IHG+3KeGg9kEQ/mkaUFANbdtztZU1plJA Rfc877JkJETyQdrIUx5LR+g8plrMFjslC8lS5xvp9kb23PKAI+sc2AUJOmyto7DlEB+6yShMhLW3 HKIkvjBcTdObpAII3SowLlpREoxpBuLdk1guy108wN1ge6YYQO2y0WhGsDa+w7JImOvfhZDoIySQ 5LMPqAA5QlgmTWfSLBGCRGBwsplH6NljVLHNeLbWQBm+ixKA3IshDzJyOE6147d0ADmNawHuqEIu HAHUUUd2t/mDb5TGm72ltiBwhBcrZ9IIbshbIb2P9lksrnzVLqXQA0C+pY80JjdsboC9vwlynS2/ ZE0l2xGykzBosOEBjhxIv2TIyHmxIAQaDYAFMii1O2G47oCEENJHvymmR7WgEp5Y00+kcrHcCW+x HugEVWx1E32SA3WLlZIgMjru3smxU7XmxagFRA6fwjGwRlgiuLpaAhF0JBvsrDgVROk7oCFtu90W 1roASTsEJe4u0nlAGSb7KKDhQDVwUBQbd3CsHYob3cADuoQW+kb7oKJuXcK9O/CgBadlRuDqJQDC G8JbgLXup5gO6pz+OEBYA1Iw4FACNzdWLCyAa0C/up5rotgNktzgBe6FrzcoA31L3g7KmgOYb7Jb 3kNNkURuzc8oBTHmNPa4PbcbH5VxsawnV3SZXHX6eEA217AlZEMQjNwksAADij1hp+ECHF4dchJc zzAd7EIPP0kj3UMhJ2QEbGbXQiEF1zusqK52UEjHPc224QCY3DWAeArLmkOsVbnsLj8INgLtCAID YI2Ai+/KGGPUbu78LKdFoAKFRVPFqJEm1+EccbYXEDdBK/VI23KeyzSTbdYbNJBQxP8ANu4+lNlN nAMUgGq9yr0jzBcrDNBsFzY8q3N0G4RNDd/dUxx31KFLa4sA73UMQcbk2JVjZ26sG4+VALLS07Iz s0EqrG5JUfqDfhAUfUPlU27b3VatvlFvZDIReALe6Au2R6GuN77oXC4QpTdJ97oDzyjt6hZA4b3V sMsG7hdXf1KMaodnKEoYRqPFkQDSBdLD2tNj3T9MbQChaFyObEBbcFXURAMF+6sOjfK2443COslY 5gDeUIYggbY6eyHRbumMLdJPdU4agShAbA/KuwG/dDCS0owd1aKW0XN7qy3bdU2xUdza6UQqxDhZ R9h9yJlwQjlYGi53v2UAnSDYg2CMgN44S3BzGHY2RQNDm3PKoDDdW9kJbqePhNjuCb7BWWkm43Sw K1i5BG6hZqQker5TtAIBSwJc21tPKjWXffv7Jnlm6Gx0uurZpBt9LdWn9kTnNAsEuJ50WKh23QoY aCOVbtm/CBsgc6w5VzODQARZGZZYlA2CLWAb91jAh+/snNaCy/dQlFa3l2yVE0GVxdubpwNu6vT6 fk91bLQLmXdbv2UEZAueO6aSwsHv7qg7Tfe4QULNlTXXNkFyTf3RtA/dU0FYMFzwqO1nAIjbuo0+ 42QFbOPKhFzbhG1rbmwsVHek7oBRvxx8pnkxkavN/A90t9+wVtIeLFo2QBiMBusHhSxePSLISx7h 6dwjBIFuPdAW21vlLewm9kYsD+VfYhAIZdosjLbi/wDlCPu+FfmbabICRkF1nd+CnhoabXWOSXkb cJxuW272QAeWbm33I9JIsUuNpG97Jh3sRuUAD2hpFuFZla4hVKbOWKXObKdI2QGdGNRvdMc3UOd1 gte73T4ZNJ/PdQASxEHUDayW1znNLSblZRGoG26x/tdbuqCoBoJB2Vk+s2VutZCbXG1kBdvcqnvt 2uiAug8wkltkBR3Isr7fhF5RZvdBaxIHBQEvfgKi4t7K2kNPq4RH3P7ICvMc0g6eU2x0lxCJpb5Y HdVMToAAWWBUjywbJRc54LXE6Ux2w90Gku+FCMfE4CO1rpYeQ+wTGAWFlT/QL23uhOiy5oPq5VF7 S7ZSKnLg6R527BDHAHG/+EKx7acTg2cLhJNLJG/cbe6GaIseCxxCMzyBgBddUpBEdVyikO9mpTpy RYbBNDrMugF20uHBKIu8p9yBuoLOBPKU+7ueeyAMvN7juq1G9jwlxucR6uyYNyhA5o2wwOeHX+FU YDYGutbUFHgObpPCpzvSGngKAq10Qgdt8pdydh/dMikcL3QckfC4cG1lP6d+Uetp5Kos1n07BALI u8Dsjc3RZXIwjfugbrLfWblAwSxxN+yp0RcNjZMEhFgjDC8bKgxxCBY6t0wNIO26Iw8bqgNJ3KhQ gSAqf6tlZJVAXN1QS/AVAuDuSrLfUraCVAMc4uYBdKcHEnujDfUicwubtz8IDDe8MeGnZPDRpSXO idOGX9d0+QPikANtCABwsNlTBc7Jly4j2RFliSLbBaQFOiN+QiiF73S9Tr7myNovbdUFgbm/CA7b hMcNks7WQhYJP4VEXHwod7owbaRbZQnYDGaze9vhSzi/cXCt8ZjdqB29lGzmQ202ClF5Fu2KEjZP e1tr8FKDNR3UKRkZdwnGOzRqO6CLZ1gnSNsLnc/CqAoNFxsqls3hGXbbcpcm9itECiJDSeLoC4FQ B7Tudj2VEBt7KCiPG2wVN2sU03MaWGEjYqWAyNgUPJsoftACu1juoCNbqHYqm7HflEBYWCoiwQlA h+m6tr7lRovdU9tgEIGBc87K2+lKLi3tyra8X2QBPdvdLsQ8kbptrlCAWn8oWxsTzpJtYoQ8b/8A dLabHfhMa5jRsEFk+UIfZyY0Aj/whe0AIaBuSbnhV2PdXo9yoeeUBRvZCWu5RXJRN9V/ZCIG5At3 U3cLAojpGxKrSG8b3QoAvq4uhkeWHYJwcG/lU2znEEcoBUcxVibU6xCEsAcSQraxpKqAxtr3vb4R h+ocbBBGADvwERcAdlABI0uF7INOobFZAcHAg/2Q6WtG3KABkoA3Cp7tZ2NgidZw4VOa0Ae6ABtg bE7KGw+Aq0KNFxuUBANTtuUbXknS8WUjFrm6p59QtyqwQg3uOyIDY3UDyw8KtW6gIGE8KnAx7kph G2wQWa8eo2IQEY4uIuuSpnaBZcTNII3DdEyd5BcHHcK0DNqLPJBWGW2dzsjbMXj1Hf3VahqQEBFr EKX0m3ZD3VOeO6Aklr7Kgd7IdVzdSxJUAYsHXAVFodclVYk7bBXptv2KAAMDXXambfuqvpPuELbl 9zwgCc252VAkEgq3ODd0IcS6/KALSCVZAtZDyoCb7boAoTZ1j3TZnhrbWQNO+3ZC8l/KAUbEXVxk F1ibI3AtsLXChgBsQ7dAMDGe6nl34KVYtRtkLQgDLHBu4Si3Vuj/AFMVrOJBQ+YHfagLb6R8qO3I Cl7kXUc0k7boC4z5YISm7uO9witz7pZBb+UAYA1cqzxYFIL3AomvF7k7oZobaw5SXOF7I2+rfgIH 2HwUKiWuExjD2Nilxmw9SyG2I+UHsVdxJ1HdDc67EWHuiduUMhJb8oUJxNkTX3GkJQJIF0bbNN0B bRa4KsnSD7KX1FU8ngIAmtDhccKNIBtZDDdrTqP4UbdwOyAN/qtdKLvUWnhMLbjnhA4W7IC2kgbK HUeFCfUABYKbtdsgK3I0uNkJdpNkZaHuJ47qWaD8oC2b7pc3J9kwWQ1AIjBAQGO+MRC/N/ZVe7U2 Jt2eo3KLywRwhn2LuNPyjBaW78odO9lRuJBYIaKkjaQHXt8JLgbta3i+6bLZr990D/U5ttlTLGMZ eYjsByqcSzYImjQCQbpTpizdw2VQRQ3fe+yN177KmEfcRcKawR8KhkALgQNygDnNFnC1ksTFj722 WQ9/mNDj/ZCCHu3uN0Yks3i6SWkkncItTm27hAEX35F1HbEE8INYuo5puNRuOyAZ5XqDrphaDwUo uvsOAjLwAQBugAnLSRpFwBupSuIFvfshuYyDbYqH0uDr2ugHuYQ090vTbY8pwIeB6t0PlWuShbDh AvzZ3smOdd3ukxguuUYG17rNCxgkIFrIRKBe6sboXNDY3PIv8IWwo5Q/bkIZS3Vc7EIA91Q3+U3Q 4I4ogT693DlQoccmrexsO6hqNQ2GwSvP0vLALBBLIQ3YbkoDJY7zBc7fhY04cSQ3fdPg9I3CBxtL fsgG07CWDV/ZE+Hnuha8kqmygusdkAD2lpsNygcwtb2JWQ5u97pZjPfugKY4GO1t0jTqfvwshseg WtsVPJ1nbZAJA8v7d0xxMrLD0pzYLCx5QmEglAKD3WtyEVgfgoywtGyFzbji5QAuuNt1ektFuCgM jmkXF0fnCRwFrICgzSL8lW06h+FYOrZTRpd8IAWmxJRA3uhJBV27oAnE8gKmtvZWwlp3CgO5AQEc NIulhrnWI4+UzSXXBS2Sa36BsAgD07c7pbtVuVkkNt+EuwefZAANxe1yFGuLuW2RBmna6sNugAcX AbcKo5juSwuHwiBsSOyIPLb27oDFdKHyAhpATA6xuN017Q4dglvDWfbv7oCnn1XHJ7Ioy5jdzuoB dm3KE6h+UA1zTPZx7Kwyxve1lI3BrQCUTmf1Ht2QFE3Nwpex4VNFzccKpHEBAW4AG9+OyBri5xHZ Rj7C53VNl1PtayFsaLWvyAhvqvtZQu03araLC/t2QWCBqG6l23ve3wjBvdU5ot8oQB7nmxUuQy7g rLTceyIjgIUuMxzN3cAR2KFxYTYWJ+EJpmPvcKRQ+WdtwhAnmzA7v7JLnO0rIIB54SZGh17IBYee XcJoYbA8A8KhHdm5smPIk0i9tISgQN0tF90BsXeyhf5XpO5RENeEAtziw8XaiPIsqcTxbZRjSTco WiFuo2RtHZA5xbuByjZvGb8oKKdqHCoOsdgrJ7DdQG5sgSDt6NQ3QGXSduFYdcaUDmE2B7IUeZB5 XsSkgFp2KIi7QFCQW7bEcoZBu8O1WRgl7CTyOENPOKgkNBBCY021DclALhka86XcrKjILrNNisCQ GR4tseLrIpmGM+r1E90LZmsaLkEi6koaQ/cCykbNN3clImN2nsVGOTDmA3INyUuNgedzwrsGye6r 7nbbKFMuJjQ642VuO5sVGDWwG1kL9laJYJ33JRaBs4H9lbWNvf3RGO2/ZQooENcr1a2loNjdQtuT 2VBgaL33WiMJ0Tm8FW1tmH17q2O5JQG25WSlNcbbqSHUB/3RgXZcKxYt3tsgAFgNufcoDRua7W51 vhOLBseLIiA8bkrVgFhAaRfdFCPMvfcJTo9J2OxRwu0sdbdALkcI3bcJgeJI7N5Qcg32UY4Rk27o Ag0tACF93uA9kcjza4S2yguNx2QFbE8Iha4sr06RqA5SnP0kE7lZHYxrr3bZLe25Fkxkg3JCFjiJ L9uy0SwRcc7I7kuHwqmiMpBbtZUYpbXHZC2MkOmI/KXG+4tsjP8ANiDSbOSmwhmxdcoAiCBtypET Y6lTwWuDRwVbhot3SgFpB3PCo3IGnhW0hwsSgdcekHZCINshIsG3RjdvsUDLtNgi1HsLIUNhsBbd Lkb5n5RMJsbqmEkknZCWRoIG6GRrnD08oz8ISXW+EKLvYWcfUq9JHyj8nU66swiPugspot2umX25 VNB2O26twDRvsgBfqDDZKic5gIITTKGkaSHFTzgTYixQAixPO6EbNPuiaLE7q7jm10ALxrZYpLjp O+wT3PultaCTfcFAKkDhbuCjYy1jblU5oA44TP1Aa0WCEoNztPPHssR5a5/P7JsmqWx7KvJ1C+10 IY8bLSH03BWTHTNjBe42CoENuO6YReMXN1bAuWPzG3abBIdE4AW3sszZp42RPh/la2/ulgxWllrd 02IamEneyxrtL7J8d9+ygAkA3PcLAnhkk9TbghclJpMRIPqWLG+wu4JZKMWKWYuDX7nhZclHrtdv ZMZuS4DdE+vMMZLxZo7q2SjFNA0N9Td+2yqSn8mO7rWWQKoPZqPB4WPUkPZuUUiGBM1jwbcrH8oL kf07Sy1rFV+j9lvcDb7jWWIsQY4aRc9rL4es6fNZK5zGEldm4PWtqtPmm3yVzNTRU7mgtF1/G3kc ej+juKfZ0pTZckwyV2ppLHC9j2XhvrVGKHqTioePS52wWzHFsMa95sO1gLLXP4p8OOHdT6kEadQv svuf4uV5qPBqYpQo64DRobpNh7LJjjs0LHpLOpmF/wByzA9rbAd1+32n5jtnG17Be5C494aeOfZc hicvrAsuMcRqv7rvFHml2X5h12LLD3WHM4arrOkeBH8rClYQbk7Fd0cWLbJ6+LhZA9YWMS0HYm6Z rcBsVoyR4ANu6W+O/uj1gkdymNeCDsrQAaywB9kdgAT7K3NNrhCHX9B2uoAHODt7og8Bt1bomRtu TclAY/TsNlpGkC869xwmNcNAvc2Sjs23CjZSXBreFSHKeaGxNc3lWxxDhcblYjYZLiztk+GmkD95 L+yF6MuoPnUcjNhcWuuMEZhiFyTp7rknxbaeCsOoG5aBsERGRgLxcI5XWjItulwuBABNiE2Q3AWr IJgYNJvuVGk6tAGxVbgm2wVsBAPb5QFup2QuuL3KU6QNdwnGxA7kJc0YO/CAph1kutsra0E3I3Vs LWsIG5IVtJDTcIA7XbfugDbhC0uJPsjBAIb3QF3I3agkqGW0khrymAWCjYm69bmB1vdAY7Ig1hIe HOPZBFFJrJdwuT8mCQ6hHpKW+FovY7KMGK9nkuvyTwo9h1A83TD6jfbZW5xPtsqBQJ9lZYRYjsmN Oph237KWIAKAAn1C4RBodwN1HHSLq2PLmjSOUAL2nbsQkSSygHTu7iyyHm7flJLLODid0IzDjp5I H3e4kON1yzY/LaHc/CEwmWIk7W4urYLRjUeEIh5m0Nvf9lizu1gu90L5C8/CG5JAI9PugBaHBtmt 1XRxSBhs4bo3ARD0EkFA5gJ1IQKZ4IAQts0FDUbRB/ZEw+YwW5QFslbGSeCe6XL/ADD92ykjT3VG L1XGwtygJu0WvayMPFiDz7JdhcEG6cYmuse6AXZr3NbwQsqNrG3F7rEsGSklwBQQylkzt7oDMf8A ygTbZKa41A2QPe57iHH09lcTxCdhugMiKEhvqKp2qEX7JjXOmYXEgALGke6W9j6QqCiTpLjxyqY0 mPUdggM4dZo3sgMxc/TwPZANGlw2VuaCboBFbfUr4NlAUIxz7Insbo1WuVJCGR291eohgFkAthuD cWVGK4uDx2TGtBOo/iyWQWuO90AbIxpuBYqtO/yjvZuyX5gud90BZADt7oJLdroPOJkvfYJjXB7r 2QCJCI4/kqxFdrXclPkhbILHgboNXpt2CAprQ5qp/o43/Cto22TW2ja4gaiRbdABHZ0ZvYFDuARy raDpudio42FrboBRJRMdoF0BBumEaGboAgQ8XBuEBGkqg/Swn7fYITId1qgNh9Um42TpSLWCTTO3 O3KhcXSD1DbslAEtJIBR+UQCQeET/uCJrdr3UAdO/W072I7KtOkude5Rehh9O3whLhp+UoWLJF9+ CmxRXbsdkpxFgmQmzgFAZ8DGg3KOXcg9ljGYNba+4RecXtQqGNiD5hY7BPawtckRuFh2KytXp53X Nm0wowWkkiwQho82/KNt3AXKlg16wzRbz+yuM3G7lHtJN+yoMAcoQc4XOyAOMRsdyiJsNuVRtydy gsjGlzrHhGXNa7Sd0t4kfpEdgVPKdGy8ltXCCynAm5RhqAG/fZGHANuShSnRB4JDrFAXD0svuOUy 4tfsgLA83AQEcALEf2VxsJ3/AMKwA7jlW4Wbdp3V4IEGgciyTUuLCNIRseXWB3RSFn9SEsx2aXu5 F/ZP4NisGKMGpLjfZZ4LXdlBYt9mSC24UcNBBte6qQ+vY7eysbkXN0LZAwB/wUtxJmc0cBZB2F/h YurS4utshGQXHCg3bcmxUDw+4GyF+oBVBjG3tyi4/KU3gbp2m5B7JyEMaSAOxRhok3KSX23UY8kX HKUaMqYsdEG2WJI1rRYXCaXahv2S5piNwOOyhKJ+pDgG2sU1ptEbclYpdLObiMWHNk9j7jTaypQW s0+o7pjXi3Kst1bcKvIF78qANhBN+3ulvcGE/KMNIJ22SmhrXHUN0ALbC5ui3cNuEWnWNuFdrADs hgp1O0tD2m7vZKlbJJztZZLRrAsbInwGRitlMKmuX2dws0sAAskxwysqGnSPK7lPmlDHWCo5EmKz weyYRbZU2QWVk3F0SKLA3UebAqbg37InC4GypRFuEwgNcBySiLNQseyoCxv7IAjbi26jr/j8Iibo HHdAGwWKp7blD5hvYfcjZu06rAoBW4cl3eHHUNkx0mlx2/dD5uo7lAOp5HNGloAv7qTn12VR3Bvy jc0PO/KApxAaNt/dDtuVb97DbZVb0mwugAJabW5UtbsjawXv/hUWagSTZQAX42VEuB3OyLSeAbhC Y9IuSpZA2b7dk1gFvZLFg0d0RbcAq2UkjLAkpGnvZZXpLLONysf7ZSCfSnsz7KbGLXCjn6RZE9os A03CExmxO1ko0CyV7QmBuoau6COwYTYXRsII3O/sqQF17XJVWLt+yt41G11biW2aBcICN4tsFThp F7KDfdFqNrchClB3mNve1kEbruse6YC0m4VkAHYKWBT2gn8KEE2RNALj2UclgjXaUQdqPwg0gcqw WjhRgqSO7gQdkXlkcd1YJ7ogbflQgO4sfZW1pnu0AXVOGofKOFjmtu3lWgGGNLNBIugsIzpCUXkS kOBRN+4JRQ3WtuLpRiD/AIRucCT2VAek9kAl0WlE7i17K9PO91Tm8XUATW6WID6TeybpAA7oXOJH CAW+7xsi06Wi+yogteCOAmyeu3CE7A290Lhtui9LOT+yIeoAgIUXGw3BPCZINttkIeS7TbZXYt53 QAaSeUxp0N1cqBQvGmxCAt0zXt3Cx5Hm+3CaBsbDYIHRN0gu2QAxkprXlA1tiLHZNaCgB1l3I2Cj dz/8oi7UeNvZWW3FxsgBc8MO4VE3KotBFzvZEBsEBYBuVB6bqXshcLgoA9xuFBVSQEaR92xuhZt3 RuF9+UBCxmsPLRq91UpL3je6I7KbF226Ao8IQ42IUkfpZsLpBmPvshBjmk88e6tvYcD3SRLZxubh MBL23HCosN3OylrtueULSGq76nG+yhGDe5REbBVt3VnbZUEHF1YIAseUtsg1aTeyN9rcIWygdezu FRbY37KNPupxuDdKKGHWAsPUoSTyd0IcSQUR9/dVIEsqPHCsEXueEJOrcDZGCageVTuUDhuDyj8w BtiFkELNueUIc5m1tiiaA/Y7KOOnbkICEWcOyhFwTdACSb3umW2B/wAIAW3/AArduOVR9TjbhUW+ xQgTBsUIN7tKoNcDdEed0IC4FzhcekKn2BGkbIwAUYAsUILBJANwEY490s6bG3KZHY8oWiuLCyF9 g7ZMLQQd0AbtcoCjKQbWRl1yCeEu13XRX17IUJ7tTvSNgkmQarIrncD91ZhGnUhSrW7qB3wqJLgF dwQgI9oeOd1GNLGm54UFiRsrmNm2H+EADXX3sj/HKGLZvCpty8kbIBmwbc8oGncm2yhBJ3VEngbB UBG7miw5U0Fjt1QvYD2ROcQd1ACX6DdWHh+9kD7Dcq2N0n4KAsnayAt1HlMIu4Ib2PyUBYbpG6sB pvsq1X5591HAi1kA2NosfZJlHqBHARCQNbbugJJbvsgDLrhCNyoL+6rV7oBmoja9ysapOl1xym6u 6WG3kJO6AW0iUgOF0bG+vT2Tmx7nsg0kOJCAlje3ZFcbKmuJ7qOQgZcGfN1jzON9twmlweLd0sje yFGRvDOd7opD5Y1HuladwjqCagNDRsNkAbBriuOUBeWCybD6IrLHluXX7ICi+6AuJ42VuOke6gDe UAcbdbLk7om8bbINDnWLRZGLltu45QEduNlTN3bqx9yItudkBdy07AKw61roXcbKidZtayAKWRry LdkTSHcbLH+02TmGzDuEBHC5S2g6xfYImuLrqFpd+EAxzYXdgSg0NHBAVBgU0IC7WJRXNvZCOChM hbtYlAS5dsSo5hNgCrDbvF+EwkeyAx3N0tDe6oNDRuN042c/bcqy33CASHtsQ7YpchFuL/KeGB5N 7WQBgY4+yAUxms3vZZAtcfCB9ueLoL+q4QDC0kq9JDd0sOPblE4loF9ygLAsrsFNdxayrWD8IA2t JBt/lRrw4lg5QPJuLbjuhqZW08WoD1IBpGgb7pPmOY424Sv1TnNFr7p7HagEBcbydyFCSSr1gdlR 3N0Bfe6u4QgkXKgcD3QFgqxvdUdhdTci4QF3sVHvJAHZLcTzwqbNtuEAXe9kR4uhEjSbd0RINtwE ICzlU4i6ZosgfcPsAhTHmBa64F1UbSBc8n3TZWuBBOyA3eDtZCBxj3S6gXbb2TASAAFZs7ayGRDD cWtt7qFoFwCnaPSQNljC4JH91pAge1mxbe6MDTxwsaSN7jZov3TgfSG8n4VLQ6wNtlTor8HdSNpH P+UepvZBRjSxCxN90lpcSBvYe6ziGuPp3SQz1k2shBYNj7IAbaiDuqLiZLBMMDn225QEhvIz1bqp mgWCy4YA1gBG90NQ1rOyAxwBtZG15da5VabgEK7i9rIA2MANrqxqvbsgaLu25RG7TygGh4byUBc5 kgvs290PlulaXMN7KnzNkZoNw8LLAyYvE7nxO9JH90yGJ2g3O53WEH2GnVdZtM4tZc7hQCTHYm5V NFiLnZNlLXscQbpFNd7CbXN0NGWwgt5uppAG26SH6BbhHr1fhChEEG9lTmgnflW82AsdlRkb3Nig LabclHqBFkkODQbm5Vsc59hbZANleABY/shim37XWNO83DRsl30uHN/hAck+VoHsVbnXYCe/dY8b Q4FzuRwo6Q1EZY42HugCfM1rrA3TANQuNkiFtNAdGsukPYomv1HbayAstuNxdK8uz78lPLjdKcLn UDwgL06SLmxRWLhyhO5BKsAWQC/LJddWCWndMAA7qiNQQCQ5xeRbZOjabqeYxmx5R3Dd+AgFvlDX Ed0uJoD3OvuU0ua8nZEyMDe2yoKcbgG+6W5xJFtk2YAH0pTRbtdQELybFMuGkGyosFgq5sgI4EG4 CjL6t9gredIvyEGrZAG4ek73Sg3SN0bjZtr7+ysC+1t/dAJH5VtY4n5KTM93mgBZEVQSNLm79igB ZqikAduCsiW5AsdkuPTqJl29kxzxbb7UALdgbKjuCqHqOx2UkJYDZASMBx34CJgaH3tssUudpuCq e98kPpNj7oDIDW+cTfUEw+l/wuNptUbzqJN1nMIdugCe4X2OyjSXC+yF5F7WQtOk24CAK4adyrJB Pwhe5oNyVRsRsUAx3wUIbfdRovYXUNm3bdRgqR3pAvupE3axIUDNfHZQNtyoVBFwIskueC+45Cd5 jSOEEbWuubbpZQ/0jtIe82B3CAXa6ydEJJhaQ2aOEmZul9gb/hWyUG54cOLJb3GOInknhUHWNuUb bF3qUKSOUaLHclE0nSUIaNXCl3A27ILCuQ3YXslOd6r8Ju4uqDAeVbAL3BpFksTnUVkaGpYYGOdc XPZVADzSN7Kmyngi990cUTtZ8wbIZxZwa3Ye6GSzPYgNbpv3CtpdHc3uSgG5t7d0bTY2O5QAhrtR KyIZHcJZO1yliV7dxayFo5ONz27ncIXjVcnZKhqtbN9iEyYgMvquVCmDKwB10DHhrt06Z+r08JIb va37qEM2N4e24FgEmZxvsrj1WsDayhY4v4WiDmM1NBVkDVZUA4Nsrce/dALkFnkBVoOyhPrvZCXE uQBA9rcoXAx7AbKG5H4UB4KAv7GHflDchvp4RAgmxQtHrIHCAONwJ32UdZ3BQEWdZQfy33O6hqyy LbXRNGkEBR1y6/ZWSFSWVa4HuhtZ1zuERN0Lt22Qodw6PYbpRjddu1vlNafTayK2pvO6AU0kmyo2 vuEToXN+0qgNtzcoZJtyAhd72sjAtcpb+LIWg3VIhFzwhNUHtvxdHGxjmWfuEt8Y0EAAIQBryd28 q42OD7k3RMp9LNV/UjjaTI0FAUYv5guVJyGkNCouvO7ew7KPZqddALt6gmE2I2uoAb7jhWSORsgK DSXot+ELH3citsTflDRdy1t1G3cOENzaysSWOlDJWxRWtsEvTpduUTnaW6roWiSlwZdvZSN4kbcn 1eyGWb0DayoN1i7dkJQ9ouL8IXBrjvuqubWVjYcIWxZiDRqGyDmxTHnS74QFjmkE/ahRoA5QvNlQ eAOVTQDe6AGW7SLBMiaR926jg5zC0D1dkMbnCO7+QgCme2wFuULYmO+FbwXNv/ZBCSX78e6AJrHN BHKJhDWkFKkqTE4gt1fKKJ+pvt8IKLdDtf37oWxFo3ddMc82sOEoOuSDcKAMHUCOPZA7W0Wc7Yqt Ytyqdct9wqAnNjjseUTG63XAsEmNlnAlZQIaDc2QCHsAcbG6WWNeCDsj06nnSha2ziH2upQoEMJH pNkrEqc1FPoba/JKdoGr7lRuTpvdUyY7YHNhYLXACqzJn6AN1nlhiiA5usNkTaeQvG5KyAAwtJBG 42Vglossjd7i4iyExNutJijbU2RsLrA2twuaw3HGBojeb/N118/HY5D94I9wUxmLRuGxt+6/jrP6 KdjzljyJibtG9l4W8dGACizPS4lE3adg4Xq6LMr42CMyXaV5h8ZdZ/EhQubu1otdfR0E3HPGjyap J42eZYn2p4S7a6zRO3RuOOFgU586mY87Fm1lm0jrOJeAWW4X9Gh/Gz8i+GcbVyhxN+/usB9wbjdZ uKnU67Rb8LBLrC3BXdHnkWbPFybmyW91whB0/upp9iF0RyYiQXdwisWb3VyjTuTZJc/V3WzIwtIG ruqbMG/P4VsfqY4HlJJtewsVsDZJHbWKjXGRwBG4QRkWueVIz5jyOAssGQ3SXbnj5Rg9hZYzxo73 RNltawuUQLnZpF+SjpYopWn1Brx27oTIXSAEooIGOqL8FLA8NMLgQSVmwyg8bFY7nA7dwkuncx42 2VBnOlIeS43S9bZHH2WJ+r3GxusoWI2A37rYBbpOqyjtiLlQRkKnE+yArTvwo0ni2ysPdyQoXkiw G6Ao8WsQrn0CPfdCH6bA8qOLZDY8ICMga5gczgowzS3fhXENDdI47IJCWusOCgFvda1goyQC5I3C YGWuLjdLe3SCSNkIWZmvOq/Ko1Gi/dLIjcCL2IQ6WW5UoD2VTpGgcBNDgQsdovaya0G+6UUHTZ1g qub2KJ7STsVYYB8lUBEBoFtyUE79H7o9O6Ca0lgbLIKsdF+boonlsZA5+VTAeBwFYZzstAx5C/UQ DYlUzaQNe66b5QLi6+57IW4f5jiSd0A3zNR0B1m/lW4dr7JTKMg3vwrY15cbizRwUAdg1U53psr/ ACqcL8IZYFtrEqxZ5seFC26rQX7XQgEjSPQfsRuaY4Ro5RBo0aTuVC2zbIAG6i0EpzY/Nba6UfSA LItWw7IAHwGK+j1Jb5CCBwU97jfnf3WLqu86t7ICpoC4BxO6KNgczbc/CNtng3Uayw9JstAAHSLJ jSW2BNwhkDRGNG7kXqdZtrIwNidZpFzv2SnN7e6o3jcLo/utYqWAG0vlm43JVtjLZLubsnOeGtt/ UiBAZ7owJLQSo31vNjZMNttkLgG7hQFOYLEOO4S/1AedO4KaWBxDnKGJjxdux90AnzS02dyoO7io +PbVz8lWGEs53QF6iACNwUiVoJv7pzXF3ptYBEx3mPAsCgMamjtPdw9KyyGOcdPCYYzrAtYJbmaZ nNvawQAueGmw3SpW3KEP9Z9lZa4erkFUAsNkXmFvPCq17bWVuAuhCw7UN0PLkw7N2QhwI35Qoske YBZNewuc0ImQB72uvYrJmp9L2uDgfdAYslMHDTeyWIDGd9ws0tGkuPPsl3BO6tgQ2OzfTuhfFFGG uIId3WU+waQwAEpLrEWcLqWCjpPqHChNgHAbJjY2tZ73QvJYQ0DlQFAknVZQnf3V6NPPKskAfKpK IN73t8KmOIvtb5VA3+CisQBdQpQBN77lExxabEIbEnZPDQLX3QD45myD2ITmSB7rLC86MSW4KZSP vM6/CjNI5FrXAK2C177lIFSQ4jkJ7JGtGolc2jQxsgtuEIPr1Kmysfck7KPIawFu4WaKMDyflNEb XC991jsN2/KOOUcd1CUVPG4Fu9t+QmSm8Y1Hj3TCLkX3CVWFz4dDG3N0KLZp/ZNc1pZ7oIoHu0g/ aArZA917cBCg6izYbhGNtvdC5hDr32VgK+gEGiMEjdKc82uETibJbySbBQjGR8XKVUbutdMYCRYl WY2l9+5CGREMZa5ZWoNBAS2sDXEqPNuN0LQLyHn08hMiaABqPqSWmwJ9lcdUDckf3Qhl6RqF+6UY 263NcNlc7j5HmN5HZA6bzYge/dDVAeU0bjlU5u+6gku7TblNMYLLHkdlpEox+FZmuLW2ULSwbhUG gpZSB3rF9wU87DawSiByOVC8vFjwqORoI90DiOeUN9O6EyIUa2RxYdBsnRgNaNrrFDg0iydJKG6b KMDQ6ytjwdikuPcBSKxG50lSgZOkuOyVNDrdvsrkmcyI6dylMm84AOG4SgXcMOkcI2blDpAN90YG 9whmi9mN2Vslc4jsEp7i02PCoTX4CtGhz5NP3H8JZIeUDxdwPZQbOBVAZvceyK59tlThqRafTYmy Al2FoEhsElzCJv5ZJanCFu4duVVxG4W3UsFl1jY7O9lNrb8pjY2PcHn7gqmaDb2UABkHFkDiL7cF XYfCtzbN2F1oA6tBuNyheXE3CYWNjYDe5PZXe1ttz2KjBhuc5o3CNkWohycWFpJcNiiY0XJ9lQOi FyAAhc8ukII47q4Td2yGol0HT/Ue6AH7iQDchE3YJUMDoC573fd2TC63ygINiqB1ONrq+RdVZ3AG yjIwiNDb2SiwyfumXJbZBqINlKFFjbY7WVh19lTWXKs78JROQHNLXXCqceYwEbFVqdqIJsFGkn8K hFMBaERdbYoeCrJuVTRNhsppBOxVgAq9Nu1lGCywbEcqNuASQhaCLAbqnFxdbgICH7VYADN0XYBC 8HTsqCMjLm3CvSW3ugBcBf2RCXWwnkrPsAnvZS21yrjJeOLKy0kbIwARq+FRYb7cItJvchCPygGE jYKA2NydlTBY7oi0EIBjBqbf+ysP8tp33SCS07Gw9kTiCBflWwLdPKX720o4xc/CBzQXX5RjjbYK kJI0h2yEPJBBFkReWc7hCbC59+EAN7OA/uiktcW4QN9yrDdRsDZYKMAIAJVOd7BTcAglS1uUBTSS D7+yW1r37NVuLmm7FJ59wI9igC8jQ15kO44CKCS7A0Df5ShI4izruPyiifE2SxuHIAyC1x7Kid0y QhxuErTqPNigCVgg9kJBYj3uLhAATY27KPj1gK5GgWPBVB9wAeUBbYwCN+FYAJ53VOIP7qmtDbkl AEIrHYoHlzXblG2x4KjhcG+5QCtW3HdNduBvb4QCNxFxso1ug3cboAxc97KWu1U46nghU+42ugLB BRXFtkrUQ4bJ+kNZ7EoAdVyoQW3cDZURYbImFtvUUArVrDvYLFe2wNx+FyGkf0lLey3KAwo4HHe+ xWVEwxs3ToYwd+wTNIdfe3whKMVzmggjdUSCmSxgDa/4ShzvshKIGlwIGx9022pthyEuP13smtbo 3HPdC0LazSD7q3O7HZR9+yEi1r8oSiaRwrtYK3WACLTYDa4VKC1Hpu3lLdvsBZQEtIChSE2HwoDp 4/soGkm/AQkkG3dAMdYcclBpLzwhN3EDuja8nZo3QFBvKF3CjXuDruYSEzUyQENBv8oBbSB2R6xY WVWDdjyqIDUBYdfa23uoBp4Ua0HYFWT7oCW2ueEDW3ud/wB0TRfkqO3dYcICgwnc/wBlTna/TayN 5JbsFRHo25QgoxFgvbdEAfdGB88qh6TbuhQ9FwN7KH5Ctrjqs4bqtDmvu47eyEEPe4SWI2RBpHOw PCdJG1xCqRgcAOLIBTXaCR78Kw4/kK3N0EA7qvtugBebC9tlTRcI4xqvdCBd6AgNjZC59jxsic3f ZC4b/CFKZKHG3CY3gkG9igY1qNht2/dAGRdt0kbo2k6iDwqcA11hwgJwpyo691GhAU4XtdQXHdW6 99kLruQBEnnsh9JKIE2Cmje4QEJs29lNJIBBVlwGx4Ql3qsOEAuSNwlaQfzdMc3UUR443U4/KADc KvhFdCHajwgJseQrbZV+91CCRsgGa7iwKrSC3lIJIN1XmBxF7tshB4aGsJPKq4vcqag5tg5UNm7o CPbqsQLKjGTt3TGjUAb7BSVwaQQLoUWLtOkpjBa6ot1kOuo5xG6AJh80FtrJch8v0Hcqy/1XGyW5 us6id0BYA/qCEsF9kdg4XOyBx/ZAV5xbI2MDY904x2v3WOWkyB3Kc0k7oCCwNkQdsULtj8qN+Ofl AW0tDD3KXZ7uCr8vy/Ud79k1rrtuBsgADfSb7lRjS4EcIiCQoAfdAEwaWK7gDbZAHG1uyvgboSir 2KsG6haCD2QgaSAgCG3KtttyQqadR2Rhv/5EKAAXG6p4O99k5uxtZJkJJKACNzeO6ZsAkhhaLq2y lwvbZAS4D1byC3bcodnOuFTAdRugLafSdQ3KW27Xf/KaAQodzvuUALG2vuo4E/hW0m9gl6j5lnbB AMI/t7oI7ckpwILLDdT0lpHdAIcJZLGEq2tedpAHFZLGhrLNG/wgv6TYWI90AAgDm8WPwrY0xt9y ja+ypz3P4G6AHe+4Vm97WQ2c+QC1kyTVFYH1ICNbdtjsqEbW8bqC1g83ARl7S245QAutbhVewAVu dcbBCN0BLWO6qXS1g2R3DbXSjMJJCwNJaOSgIGam3HKI07XAEndGQ0DY2KoOtzuEBQabeoqFwcLd 1H3cQeypxDW3CAp3q57IBfsh1aromOIFv8oCOvqvbZQfddE9147dwhZs3fdAE4kG6U9rT2RAXvuq LT7bICo2Bt7C4PuluaIAXd00v4AVGMSA3/sqYHQM/VRGS9gAlFjd7FC0uhZp4B7Ir6he2yWaAGln JS5HWu5pufZSQ+i4QGQ6blqChbI7Ayk2aE6Oq811owSPeyTP62ADYX3CyBUAsAYwNsFoyONTY2PK U9peCChjF/U5NHFyVLAkBzG/CprrnbdVUy6GgN/e6uC1rqgNjSNwEMo3uSsjU21r7oHRBwN1LAqm bLG8vbIA09ill5fJctF7pvkAfcf7Ko2CN1zwoCpbW9LbFZeGQmRp1nZYrxqN+AFmxyeXHpGwPdQG PUHyJS1u4KkNmM2FkE7A69nXKWx5a2xFkLZkhlwbm9/8KMj0Ai6HzNLNhdCydxB7BBYxxuLe3dY0 DjL5jjw02RGdxuNNx7q4JGxRubazTuULYReGjT3KPWdgUt5bcHso3+ZIX8NCCwrancXTY2t1cf3S Yneo2TyCW8oLGNYDvdLkI4G34UDiAqJA3IuhRTaYGoEpsCNlkOjBGx2SQfUSe6Y19iEAYZ6blCxl 9V+ysSkX1Wt2TqRoMUl+XIDGB1H4RX7AJcl4H6eQmhh0XQFWshJB4KMn027pTm2KAB08UbwX9ktt Q+oke6x8oHZHPFG8Anc+yZG5oj0NbYIAIpg82WSx+kWN0mGIFyfZoO5sVQBI4AflA0kd7BSYtuBY oQzUfhANJbotdCZBpta/yhNgDcFL5/CgHavMsALBWGbpbHHjsmF4sLHdAU5gcbEq6e3mua51gBsg 1Wd7lKcHSy34SwCQXPcfYq2OLeeUxjgXFpF0DwOyAZYTEB+xQyN8s6W7g+6tota52Q2vJygGsHpP uFRmY3Z/KYwCJw1cWUkga/1G1kBjNAcSb+kqzGWg24RmHVs3YBWxpBsTwpQBMOlur/Cmuw9IuExk w1llkTg2O4tcFKAtji5tiLInlmnc7qiTtYWCryw69+6IFCNr/kIX2YQEYaWRGwuULIddnO2PsqC9 Lw7jb3S2tc6Y7rKe8NbZAI7DUN0ALXeWedk1oDmkjhLIv25S2zOifotcHugDcGgEjdA0lp2Ua4ue QTui0lpuf2UYLEpvY8FS6ogAXKJ0okaLDhQICQtaLqmkEAqPbYcKtg1KK2FfdXuSPZDfSL22VsN+ OVUQYGAEqE32Asqbe1zuqMh3UNBOHl2J3VucLB1tuUkyANuSsnD6SStcWgbe6oESVDpm6WN3Syez uy5yowJ9BE1wHK411OBIbjlUyYjgHNBBTI26huimpdLC4bAdkiKTTc82QGSYzINDdr7JL6c0w0k6 k+KS5v8Auo4a5PVuhbMFwcx53TY5nllj2VTlr5rDayY0aSLDZBwQWPqdt+UVu4VSN4J4TYz5rdhs EIIdM/zGaRZvdZTZQ42B3SQCXkdgm07RG5xPJQBWNilt1vdY7JpPKESC90LRUo0WuUDTbjunlrZN iboDEAbhC0LJMbtyqIN7qOAc43KuMk3HZShRA4E2tuqaXtk3GyJosSe6IOJ2PKpmiOAJ91TiBzdF 9vISTNYm4v7IBmokKDc7pbXaTfkJzSS34QE0gkkFDa/7Kti9R7gAbIC3O08Ki9xFwLIRN/ZEx+p3 xZAQSPKsm1rhUCdJ2uVDrPKgJqIv8pZDnHZG2xNgr8txN78KlsgaCy3dUQWjjZGGOLbcKEEC19lO SgXTIyB+UJbtcWUFwgYvSXvJ/ujDrCw3VbNN1L2HCMiIXkmyoja6q4vwrJFtlSlts1l+5V6gdkLL jlQke1kARP8AZC4i4ICgOn91A0ueARsUJRZ9Zulu9RtZPdEYjtugYx7iTayFFlthYpjL7WVF7SC3 lw7qogQShkaTZCZDdDe7zv8Asr0+rfhAE5zZBp/qSS17tnHYJg0hxJFlTjruL2uhoW2O5+QmtFhx uhA0bEXKLzAR7ISynkkC2yoNJYWndFqtsruLIUpnpFiqjZpY4HjsiFyfhQg342QA3BHqbdLa3VfS CFkCO/8A8KAaZNNv3QGO0F2qx3CVqsLH+6e+EwzEg3DkHkguQFAt08flG0WG26EAX0lOjZe1rICi QATa6Xa6bICDZUIizc8JQFsvEC61lT4hIdZTPObfTa6hvfiwQCH2PCFttO3PumyNuLpI522UslBC QuadRVNaHG5F/wAop7NYLAg/jlXCAW77FUUGYw1u/CS9hLjY7J732AI3AUDmOF+FEGezYMyPpHge cSB7lczQZ1ZqDXyDf5XW9bG58hOog+yVR0ctRVNYA7V8L+YeFM/beSSO8KfFv1ERexxItsui/FM4 kYKxxIc67nA8ELt3KmC1stG1jgWt9/hdU+LekfBVYPP/AO3HHpK76WChmics0m4HneBrXyzW2ANg FkBulgtYLAiMrXucR6XG+y5CEulaOF++j/FI/Ny7OOxAG17bLiHON1zeJHy2+rYrhJLHna67R5PN NclNu47nZG9gbZBG3SNynSRgR6id7LZzaMR7g4lp4WNoAeQ0FMbP5ry21gFTrNIuuiOYQ3HsoQXK AomuG63YKltFC233ErIfTMigDw8OJ5CxyNdhyAiD/TbhRgrTqaSAVYFmjtdEHaW29/ZC52wtuoAH xv1DTYhZcbBGxz/6gEuO+kOJ29k+aqjhAuOUAyma1zdR5KqVhI2bdRlRE6EAD1E9k9sjWM3WkDj3 RSSEDYBZ0Ubo2Ac27qQTRztLbgJ7YwARfb3W7AkuAdY8+yhOkKPZabVyLKnuA3cgJqtbZUdzcKm2 cEQF+EABb6rkWKFjB5hceEZvq5V/nugIL9uFUgPeyPTpFggO7kBbLNHqFyl1TgQAOE5xDBc+yxmO EuojcIBDmt4F7rIip2kgK3MaLGyqGWxcHfshBzo2t2HKD1ajbhRrg8/KPhClAgAqgLbqcK9VkBZ/ G6S6Sz9yERf/AHUlpi6MO7qUAh6XD2Ks+m47p0bg5gBHHdDLYvvtZUCoXgkhyaxrQNpAfhKczf0i 9039IxzG3BDvdAR5DGEg3KUJHPBFkctC5o/kkv8AgpbS5uzhY+yAE2va6hRADf5VOAj3te6EoEb7 K9OxF1d7i/CHcoCrFtlHAne6IjgHlRzLsQgDXajuo42ddX/yzsLlW/SG3P3eyEB1iU7Hf3QeU1hJ O5Up3ank6SAmhum5O9ygFNA0k339lbRdt0WzL7bKMcCCqASwRuDuyhcTIHAcKyA78ItIG4UBU9ng X5VNcA3blERq/KEt0C5QEO/KoD5VB1yNlfdAMv6UIffZVuSPZQgNKAIkEW91A3SNtgh2JU78myAp 4uSBx7Io9jcnZQAbm6p4GgEbhAXMDIRo2CuHS11vZKkmEcYNlccoeLhAOkc9xJB2CRI4m7rbp5aX DZLc8M2IQC46UkFzzYngJ77NY0DgKjMJALGxUfbSLlAKmN7aQhIBU1bWRtju0qgU54jG6NzWOisN iUJg1A6/2CXu023AUBTmPZYtesmJz3NFzulBtzvwoA4SXHCAyC7QDc7pQfe6knBJO6WCQ3ZAG5xv zYqNeWP+ULRfcoQfV6u6Ay2aTY8oni4v3Cx3zNg0kbi6c8l0YJ2+FUSxegu5V6bc7hGy2kG6totz ujLYAaBuNlTnWbfuik2OyU65KgGNe42IGyPUQOLpGt8ewF0xj3ub9vKAXNFeQOWTE8n+3KWWudsj EZ02G3ygHiUA6bXPumtAtueeyw4SXO09/dPDnMNjufdRo1Y51422HdPB0wja59ljtHmXN/2TWPI0 2AI7rLRRgfqHFkxgAKS6pDXizbKNqhJIB3WKBnPDtjyhbNoebfgoZZrNDQd0prtPKybMhjjcnsrc fSQDYlUw7coXgl4tygI1pDS12591LFtgicL291C0u3HZALc6x4S5GWff3TmkHYhIma7zLW291aAT CPyi1Fpvbb5VeUWNuOVbiSBflAQkWPyowNBu47KiQ1vygN3kE8IBgjDpLcNWHiDTCyzB6rrkI6iE kNvuEqubre3S3lQgdKTJStDuTyEp0BiLrcLNgDRELjf2Sal292jlAJhiudfdM8v1XvugjNid012l rbkoQQ+7HOvuUIVuNn3VXJ42QpRA/dRqMxgDm5Q8NvwqOSy4cICyyL5UF7IUpjLonNGoX4TGAEbf uqki/wBq0CjKALW4QxvbK4l2yrQQd1ZYGm+ki/dAPiIJN+FAwNJI2CAHS1E0327FAC1932O4THu0 Cw3QiP8Amta0C5UlHrI7hAMGh3KBjQX2A2QmI90xgDSEBUkT2nbcIDE64vsU1ri5/wAK3aSdjchA KFi7STZM2PfhT9OHjVex9lGNIaQRYDugLLwbkJeoHdN0Atu3cJOxuByoAxe4N9grnfpaLjZC0EDn 9kRGrlUANOq2+ycRdvsgAaLWCY4CwUZGKa2/KN9naRYgjuoRZuwQOcSdwqUc6xZp5Sm2bsLomvBH yqBLTchAWHiI7clSzZJATufZVYSORRR3kJuoCTneyBgCuZ/82wF/lRtmg3vdLBZNhyo2S9ghdZ7T 2+ULPTGe590sDAz1XuhlHcoGSOaUZheWF+oEeyoFl5bYN5KtpJbtypC9rJdTt9tgoHAEkDlADpMn qG35RW2sFbTcEAKr2uhAC23dRnKvbR8qmi5GyzZQ4yDfv+VY1Hups0IfM3sFAE30X7qiDfUeFQJK FxNrHcLSAasNuhZKNQYAo3UHH/yqCGOzfdRjQzna6mzAblQhr279kBch8vgbIttIN0rz3PYWMFyr id5Ys7lTglkLi4kFAfQmaQ8+yFzQFSgxFxJJOyMPBQNZvYKw2/OyyC3ODuEJftturIsNtlTW72Av funALabHdQOvuoWuDrEqwAqBbmF7/u2VgWNkdhffZFpFioAdJPcKgdPCNoHYoSN/hECwQfyivqJC rQCqvcW/yjBGsu4qnNDH7i6H9M9rtbZbj2RMBsS8FQB7E8boWEaj6dwi1bhT9lQDY6jcWKrSQSf8 K3A8ApbXWdpvdygG6dTLnkKRS6tiLoC4tHupqAPsgGOs9w+FbfLJ35Si8DhEGNNiqApWN5GyTpNt 05zg4j4QPd2QEaAwcqjJ7FRrbmyIxAX3soCM1X24VPu/0kWVAlvdTWb2QDARpA7pMhJICIX5VEEu DkA8hrWA7EqnOa5u+1kuQbgk7BAZWvFggGNOomypzi0cII9erZPdZ3IuUApktijDtXKVI1oJI2Vs dewQDA8DYIHtc8+k2KsG2xVPcWA23KoKDZYh6zcKAAb3uFTZXSCzgQjLr/FkIKexzHXYOUxkj3Dc WIUuR3V35QpRcOe6o2/Ku17qH7SBygKedLgUYbqKBrgGHUN1bXmygCI2+VWkXv7KyNViqO+17IAZ CS/Y7Iiy4v3Co+mx5Uv6Sb8oAQWi7u6AytIBaCD3Vsbd177LIDo7EEBUCBI4C4dseyYbNs+25QTa Q27f8Kqd+skym22yAuZvmi7diqi8stPmOII9lAfSfa6mkWugGWj0nS5Af7oWsJvtZWS0D2KAgIva +6stsEOrfcfuicS4DsFUCiSRttZW0gGyrdrhbhQgFyjARt2UDbPuhF2hXqIuVAHI++45Hsha4u3J 3QNvclE52ndAXI4X5TGAEbrGc65umiUtAQBvaHXSXCwRmoFjcb/hCfUzUOEIA02uibZ5PZUHNUFg TZChNA33UsGpevSPyqe46Q7sgG6NjZC0EfhEzdgVuIYDugA7fKoG+6MWO45V/kbIAQ24uqJ9ky+o EDZLDTvcoC4zcG/KoSBpII3QPJaUL2tZ6gbkoBr7FCNgq13siDiQgKt6jfhQu1kgK3HZC7Y7ICwX d+FRB1D2RNFwN91ZKAXpv3V67GxG6jrXvyrc0Eg33QCz6TvsjaSN0MkJfY6rFUxrmE3N0A219yhN gbWBUa9x2VuHHugKa1t+FNI3Cu26pp3N0AJJaCBwri3BupcG4srANvhARxsNghB1f/CItFuT+FNP sgIRccJb2k2sjcS3ayG5ugKDHFWYyiBRXvugFNaeeArIcDtexV3JuqdI4MsBcoCfZ93dTXZwsNlT Wl49SOwLbAboAXgyDbgK2PDToQxtdHe+6EG8h23QD772Ch9LvyrPpAtyoDe10BNKlrO90YsqdwbI AS67kI9RKvTcc2KWWkX3QDI/TfdE06nfhKbJsraSeyAyXSi1r7pLibXtuqezRY6rqtWqxugIG3Iu NlHAA2tsjDtRHwoTqKWBIaGuHYKOFjsU4wCTa6WaaRl7EOAQAk3AFj+UHcfCMOJFj2VltxwgFknl vCv0O/KjwWttZAIgACTugHsjAF+yAAMuflVctNtWyjbyOI5CAa12oenlQXadxcomt8oekbIQbEm/ KEoCUFvKAOLiLGyObZl+xSB6SEKMc+z+d0UcpvZwBS3MOxREgEXCAZq1Attso1mlBrAN+Fd3OPwg LN91GG7rW5RGwalgtZcnlAVKAH2JUleWsHlD8lC1rp3bjZZHl6Ta2yAgjDo2uJu7uEOlERsNKoNB v2SgVY2F+EPNxayM2c2yjPblAYz22KazhE8AiwCjWixQAGIm7lVtI3WQ2wCx6lwubcoAC7SfhQyk c7oizVGD3QGMjvugKbLG6Q2BTAQ8m2yxCJ2OPlhrifdOijkaNbrA/CEGSML1jPjeXAXIA5WUXlo3 5Qg+YebIUWSLBqmkpmlo2tuhFyUIR1M17QQsaw3A2+VmtFzbVssWobodYd1qzJI7htiUbeLX/ugj Nxunxs1X2WQYU4s/1b/CZF6GgEc905kLJnuN7lqCaW5bEG7DutgKWNrGB/coonXB/wDKVUBx0gOs B2VmSzUAbpNLSbXSGu1v3Kkjrt2N1IhpsVKBkMbz7InHT/8ACBztLLhW6QaQ1210opjyXMoN1ZGp 1/dEIPLOtx2RMcHXLUogUZFgChmjcTdosFQcbk2RfqSLjspRbFsJai1t2vwqjfc7hC8HVcWAQBho e09go9pjaLHZHFa1nK5HBzdtgFCkMjWsBaLnui1t1Ak7eyw2k6z/ALU2Fg1lxGyGTKe5psRujY8b agkEnsFcb7NOvnshUZT443WNwuPqHeVJ6d0bi88GwQiPXyfUhoXM5zQHA3BWVE90kfpIFuSkvha0 7m6ZEy0Z3sgJUO2G93LIY7VDbkrHjgAJuboifLbZp2QCpqnyX2Iuj139XuhjDCT5ouVT3WNgNkAT gQ4E2ITS65+2yTGS/b2T7EW2ugKEmk7BSR4JBI/dLdKIZRqFwdlc41u9I2QBagfu39k1obb/ALLH cS0WARCQlosN0BJTvY/2VOgLo7N2QSuGoFZULwdrb/KAWIXBg9PblIIO4vZZr6l2gssLLGI9wgLY 0hty66AXJuET4XeUSCpFH6NygKjNrkcoXNJARtALrDuicTYWQAEemyjbh99iFHOPHCoggbIAnyl1 geAmTuHlNtv+EsN4+eVbg2B2+4QEYXG5vYKW0km9yVGuu2/F1Dbf3UsARNIe5xCyLh7NgCseOQuc W8BNFmHYpYFFxPp7prTpaOLpZjJk1W390biCCfZChgEi6pzbNP8A2QMcNt1JJQD7FUjFNcXO0uKY 06Li+yWGhzhdXazz3QqGAkn4QSsPIKYPUfSic0Ob8oWhNNCNRJNlltiaW3JvZJjjuSmPZ5bSAdvZ DJHsa5qxnt0nSzlZEZu03S5wIWa2hAIkLgd1d26RvdE6TWLEboLWPCoCaQ0E2uj5bcbIbaeVXZQB F1xYnb4Qv2Ctwba/slueS4belANpxGZQx/ddmZXwrDqfLE9XK4fqdVmM+F1VUxFrg9p2XMUOYGUl JHF5xc7/AG3WJptcFVXyfUY1Uaach1uNl8hJUgvuTzwjxLFpK4WuQFxo4GskKQTS5NOmZr3agd1j BtjsEJktY32RCQNF72BXQwNbpaqeHAagia3S3Udx2QxBzw8u4QULLQ43tumtCEDS07IWB/PZBRZB J+E9ukAC9gUpt5GnuUBe5gvbhAMN2yEjgoi8gtACx2yukB7JxOoDsgGulAaSEoNP5uo1pdsshga0 WPIURoXFH/VfhR8tgbp7ma4rA2WJUN0290sAb6tQ7prSgLLNBvsiH277Kgu+/wAKwSqALm3GxQiT kdwhGF5zQ4glC8NPqAUOh4FxuqDwWkAbdkIG9v8AKuFcbbwknlUItLfU7Y9le7CB2KFoFj7c7FM0 XY432+FjTtL7gbInTeTT6Re5CEFNI80X4WX5TpJGtj2CwY7uF7FchTucW+k7/CBDJKbQD6rkJbW+ Y37rEKvIqGteGDUOSSsBlS43bffuhWZzYCDcG6YInN3N1hx1Dy4NWWKlzPu3CBFSatYsDbuo9thv sFTqzX2sraTKw37d1OygadrjhRxuDblR2osG4sPZW23BIDvlUyCy4adSFzrjhXMQwbncoGM12N7I AWO3N+U1o2VMiaJNSNzxqIA2QFCxG+yoNF/cKPILdyiawNZzyhbAB1OItwpJrsLFR1jwd0l73Bwb qNwgsJxkuSiiqC06XnSrY4gWJuUqokGmxHHdCsYWAOuDynNaLXKwoZgQN1lsnY3nfZDKB0C5INwo 51gmuezRcbXSibhDRNQAQFpe4aUwBoZud0Eg0N1A2QyxwYbWJ3SxGTcHZDHOCdzzwnOd6PUgEl4D 9PdE1hF7hC8NA1DcqnzFwBJshoZYjglAZjG/1cJb3nYh247JTpj5gLxcISx0079GpnblMFS2VgcN nd1hfqHedpt6Shkgk1HSbA9kspyEMvmuLTvbumgDVvv+FxMEohdYG/us3zza4G6AyJ2MYb9z2QBw GkWsFhyVcjnj03A5RtqSe1kBlzObG3VyUqSqH6cuskPqPMGlu7gh0Oksw8E7hAMZMNiRYndNjf6S SsWptHO0/wBI2TpJWyR3bsgBE7xL6m+lMdH5zg5lhbssZji4EHf2TYmvt6TZAPnkkcA14aQByAkR xecR2CBzpGusTcKF5aCWlANqGGD0g7FKLPlLfKZgNR3Ce1zdI3QHvLEelFWcTc1rP5QdcOXOYL03 bRzte9nq4uV3TFBFPYuaCe5WV/DqZw3Zuv5Is7S5P3/hPlsMy+ynpQA2xt7Lzz4wcADMrw1Dhs11 h8L1jNTNYwBotZdA+LDBJsS6W1k8bDI+nOshvIC9Gmyf7o2csmNbaPBFHMXRBrdweT7Llwf08bQ1 tie64TDJRFAQeSf8rl43EFuo3b2X9Ghwj8pkX2Zj4mwSxEu5XBObqNrWsudxdpdENPHwuFqGiMt3 3XeHJ5phQsDjvYplREHQ3B3HZY7DpKqSYgbFdaOJgVMOiT07e6oN1tuTcpkpcXb90LQBsFtHNkDr BE3hCXNBt3VtvutUQNhO6uwuhHCvkWuoC7jsNkJcGk7/AIREaRdBJ6rIAqY65bE7LNqmMLWt8vXd YtOy0gLkxzyyTY3CFscyEN4sCOAnAaxd/AQ6mTWsbFNdAY4tzyrZQGQxsf6drp+kRncpLvQ0D+pV rLgL7/Kpka8X+Qge0AAEXCNosxM0Ax78lUCmxgi4ISnRllyO6d+mc3fVsheCtADTYBx2+boi3YOP CksZljAGxHCKOwi0SO9SyBYdqO3CmnVe3KJoDdm8KEWuryAJWhsViblLga1gt2KYWF533Conyx72 VBZj1usdkLoQxxCtzjKLg2KINNtzcqWCg1rRccqXBVhtuVVk5AQsdkLgLcWRRgF1zwikbZ3wUAgc 7JwkLgAdgqt6rcIXgtcDe4VBkMc21gkyC5JJRMdcbCyp7bjdARmwt/lUWzMdfXqHshGoD4RsBss2 BPnzsJNyDfsoXE+txuU0xl7yPZWyAF4Dx6VoC2uu26m3HdHPGGH08IBYAb3d7KWASA3lEXC1mjf3 TJIi0NJGxSXWa/bhLBDclOjZqG/CWGhztijIAOxVBJYgXCySKa013FZDLO/KvW2/qCATOQ0m1kt7 r2t3RE6g7bdLLuEMst19BuOEEZEg9k99y0O7oBcC4FroQoODQWW3V+URYk2VNjHmajyrmeXv0327 ICn+htxugZJ57bcJghcLXGyMMY0nTsgB8vTH8oAbjcJzyQOLjuUoi5+OyAlxpuq/quUTQDyo5twg BHCgFwqju8kdgrDiDayAokNa8newWPGXSwhgBBvysu3c7hRxLWXaN0Bimm0jS43KuOOzrcBZFi9t 3ixQufcgWQDd2MuDeyBzQ4aiFT3EN5TGPBbY2QGKBd+wTHkEWPKLSC7Y6VNDL3J9SAx2gl26yHPD Wge6krbMuLApccRDLndAM1bcAqtALtRt+EtzdI1bomG7QeyAOSNskVm7H3Sw3RHbn5THOFvZC97b ADdALeGkDdTRZosdkRb6R3Vy2GkAoCtGyBw3VFzg624RCMube6oAezzS0Hsbp7H+ZIGWNgEuOncx 1zwmsIY64G6hKFTNIk9JICbG8sNyboXjU/Vf9ks3ad91SDpgPu4ugbzccpfmGc29lkRssgIBve1y jEg+3gpbpDG6xaSqLttVt1DQ0OsVTpnagBx3SBK4kJxeAwuP9kAI1MdcXTGSvcCALodetlxtdAZS BtsUA0TaBzY+ya2oDWggrELARY8o2BrI7E3PsgGmqNzcbJtO5r2tcNiVjOFwCdrpgcWsu0ccBSrN JnJPjYGgmS7vYKoxYbkrCpJA2S7+Ssxh1E7XC5tGzKZIbJrXaiktbZl7XCjHu8wC1gpRRtwXHuUA e5ptZHLZjhZA1xJsRse6gKJN7hE27mkHlWRpOykZLgfZVAjWm1kErNtkYkF+UTb35ujBihp8wA8J 0rAG2aLIX3L0V9Vgo2BMTrOOtgB7FXE6Uv8AV9nZMe25PsOED/VGd7IDLbcC/IS3Fr+/HZSnqGxx i/8AlSergnb/AC2FrhyUIJcfV8I3izRbhJa433TgUHYpxv22VWuTbhE46+Ff2NseStFADbXJKl7f IVuILbX3VttpGyAFzQ3dDe4CaYi5u3KU6KRrt2qUCw/QTfhMbKbgBCWagBZWCGm3dUDABf1EK7i4 7hC6LzCHA7+yImw0oAHG/ayKNhcfhUGWsT/ZMeSyxGwKAGaN7heNwa4e6kLTILn7u6joNdnXt8KP eIpGRg7uQDHEBwCB7xfZSWBzbm97pdtNgUAbXFp+CnwOZ6hy5JG1k5hAF7AfKgAmjcLW7oYw9l2u uU10gJB7hE12pSwYrC6Nxt9vsUR3N7WVvAa4jlVzyVUgX/hU5jncKAG59lbHncKgjIy5u53CMHUN J5CAfcpp3uEAQk0mxV6gW7kbpRiOsuvsoGWHO57ICSDSQQmEPcLjhK3BAsnQvLyW8BABG0l532Sm sqoZdTHBzfYrJcywIH90m9tiTsoyMBxlfJ6hpdfsslx2CXG9odud1Ndr+6yZBLzYt0q4xZtiUYcL C3KWb3uhQtLWiwPKKO4u0nZAWOPqITJzdg07bIDGkaGvs3cJgO1iEre9k5puRdU0CTp4VatRtewR FtySlWJI7KoDC2+11cZ3t3UB2t3UF/ayUApG7XPCSR69lkOd5rLBA4BjALXKoKAAG6gGpwQi5aSR sFI5WyNI3B+UARZZ1+6omztxyqZqaSOVTi7WBa5QBbe26AsDjymEabahYqnMA3BsssCwBGfSEQbb UXb34UY29zdA4Oc8O7BQlCmueyUkg/CyNRduVTpr2sEQd6blCgk2ueFTH+YCOB7onDUbcKjD5I2P KoBIIIF/3Vm4sAVTQJB6ijYzUCPZADYl253R6bISBfflXGeblWgSwde6rVconRE/hAGEGyyCyCAS hDje99kT2HYX2VxR2JvwgDOzb9kDA59/ZE4F4LbbKmSCBtncKgYPS3Yb/CB7nOA7D2UdUt2sgM4c OQVAG6zWX7qoXl6AvuLWRM9DdtroA3sIKxwQx5PdOJ391HWvu1ALbJe+yqR2sAEIiwDcd+yq4ugK t5VjyCmseA3bgpMzCQCDcKj6QBe3wgCMhD7BXdpclN3kATyza9kMEaQdwqeflVGbC/B9kZFxdAUz YK7Kf0oCTbbYoBo2uht2BQR3AJcU1zQ1oI3QtEcfQG2ufdCWiw23KGR7mHhC0ucdR7IQa1pYN9kJ kLHG24RvlEjBYbpRGkoaI65N1NR4turJCgkaNu6ERC24F1bjYDZUSo7cIaJrJHyoza5KrQSrPpbZ UEbud1AdyFV9LVbT6d1AXYhVY6/hWDYWQSPKAkh3sjADWgoW2cL90ViW/CAu90NhfcqXVH1bIC9J Pe4ULe3ZN0mFo1WKHWL3QhXltY02N0sBqIusSOxQ/gbK2UGxZzuCqLLi4IsjfbTe+/sltcCbIBhs 1oCh9QsqcDshvY3CgLcXBwA47qzF6g5E31G/t2UeSON0BT3eYzYKwNLCCd0sE33RXvygCB2seELi GnZE4bDdQEDsgITqVN+VA66sD5QFHZBbzDa6LuqLLHZCAP8AQ63Ktn3+4R6WnnlUbNHCFHtcNxYE FLcS0Fo4QXDdhyra7bfdAUGb7cqu+6M8IvLI3G6AVJH6QFUjf5YamOBH/wAKiCQEALfSAEenW254 QgHlQOJBbfZaQAa4tksB6Ux5sL3t8KNGyjhqBUYADy7cHb2Va3AbhE1gbayt5NthshBTpSRuNlNj ZH6XNsdksNIda4PshS778I23vvwqMbmi52Kog2ueygCsTfsFTyqu57mkGzRyArmN3BAW3hSQuuLc KMF7bqNJfUaP6bICuOyh33UcbA/lWxwsQUAOu597ICSdgneWNNgQCUDoyxwHcoC9WiPcpcRc8kuN wi0AixU0aXbbIAgVYcAON0Okn0jlCQ9hAQBv9PZVrLG7bow3YAqnMFrdkAHmd1ZkF+eVRYAOFYa3 TfugL1GyoC5KkhLGjbdUwE2vsgLt/dASW7oyNyEL2EWQEbe11dj2VhvoUY6wsgBMoaQ08/CfCA91 zZJeQCXFHTSekk7XQEk+8gIWtDXfKp5sTY3VtNyLf3KAbewuUF7/ACoXlx0WUY0ROs7ugCaSLjso dwd0LQdRN9kJu03BuEBbHa9jcIg8POgC7kJJ8xhHB5TBpbJdvN0Apo0uIPNkTSLcoXgmQuvym6Qg K7FUBcbq3WDTZCXFsaAprbAlXuAhi9W90x3KAW7UBsbH2SLyNdfWfwslx1Hj90ry/WSEBQfvfumO cWtu3coSwNZq5VMkvv2QFanOb8ofLc427pzG3fza6MxEHbdSwYbrtNkyNxadlckYD7HYK2s0O52V A1ryRv8A2S3jSbnhFqsoWF7Ld0AqpkD2DSeVRaGkEm5so5mlXpAZdACX3PNvhXcu3VCz2FW0+Wyz hf2QFiAuGrsi7fKpkhO3ARuGx90ALzpZcblKA1i5RAG2yLQSOEBA7azTYoo3ukNnbWS3wOJBad1k F8YaLkB/sgCLR27d0ouLidrJhvp5Sx3UBQsQiGxFioBquoG7FUE2LrlU1t7otQYLc3Ua43PZT2Cn ENOyxSP5pJ4WRI/kpT3NcAQVQEzd3wqe0A2vZSN4ttsreLngIBbQdJLQR2uhZQvD/MEhN+yexpIN t0Q1DbdAY72P1bphaGtvbdOcWx21jlLe3U74QCxZw4uUOkh4uCmzN8i2ng7JnmAO0Ft3e6AAMaDt yseacNfbRqKyy0kXAssc059Tv6kIDIQ5oAZpNlccnlC3KkTXvG/Kt8JZc72VIIaDFK542DuVA12s kjZEA4n4+VRdYkHf5WiFG2r5VOab8INLmm/dF5hJGyyBe5mAtsnEaXbkfhIllPmgAW+U17PLs8m6 0AnyFgsge7WeETJmvcNQ2R+S5z9TB6UKhLpHaQx32lWWaRdpUqnDYDlXCwaQQblC9BB+phb3SHMd usiSOwuOUEhswE7IZENqGs9LidSfrDhssbU1xs5o/KZYNbcIAmyc+6oz7ja6U19mknhXE4HgcoBz Yi7g/unxtsbf5WM2o0kiyIT3PO6wDIO3dQva4hBq2udwFPMaCCeCrRUGLHbhLe1wRySNc5oba6pz xbc391C2J1Hkm5TBUN0Am4tyoy0ji4D0pn6GGf8A94R/CFIyTzW/y97HconR3FybflAwfw5r2scH sdyVGStez3QCpZBrDQmh3oFhe3dJeS08XCtrjpJCANzi1riDupHO4Mtc6z3Qk69r2UYNO3PygMkO 8pmt9nO9ih89z3aiAAfZY0wc8Cx2CLzdg0oB4cL3vcKn7nZKaADYHdGHtFgTuhbBBsTdPik7kb9k LdANubq/SGnTyOyECede/f2QFjjsdlfmAtb2PcIaiRzi3QgCaDweEYaHOBHPskuksAL2cn0DQ+UF xQC5AIni3KrzWNfY8oMRlaypI5Cx32LgTygMouDzYDdXew+UhsgbvflE1zmtNyLFAX5zrkablNIE rATykGfy28X+UJqA+3v8JYMsW8sC34QubpbcqRvBbvshfLr2vwpYCZ62+kAH3Ua0d73HdBFPZxCK SW4AAVARIJ23UDgRsEpr9LyClukduxpueyAlQCHAjYKjJ5haLfupEHPBExsU+J0bdiR+EADxpcDf +ystIH5RSOj1Ej9lWsG1jupQDYQy3uqmlDJQ1xsHIWucHgnhIr52VU0cbR6gVTQ6FxfWPZezWjkL KkaCNjcLApdMTpHnl2xKcZy4tDTZo5QywhOBdnFlUrtcY9SxZZmtlI9+6Y3SRYG6FCALrXPCIm7k Fy1llO3O/sgYxp8xyt9gbX3WGZntcNB3TGuc9wvyhBrG6XXduFVWQGW4Cqd3ltbbf3VPBkAJCnsv oCNjpYy0nZK/SsbuRuOCmv1BuyGUgNBvyqQISXcAUb5G9+FjS3iaHE7FW2TzG+/sgGN9TCTxfZND mGwcLJdZeGmiAPqO6qJ4dGC4bqUDKcbgDVsjBOmxO6wJJLbqhObXuVCpnIPAsBcKTytigDRa5XGS TOG+9ihD3GQXN9kLZnUs5DnKzO0uPdcb+ptKd7XWRE4FpJ5WiezLbUMaL6dlDKHkFuyxXn0+yaxz WxgH+6iFmdC/U25ABCn6iMvsQsZr9EexusR8u+q+6pTkpKkag1psl1Epu0LiBK50ti7dZjpgWDe9 lESzIqCbsc03HsmH1NG9ljNcDHYuQglxFyeeyULMv1adkLWG1+CscVBdM5o2a3uje70bu/sqiMyA LHi6MAFtzsfZY7KhjYhcpVW5z7OidcIDIdINgUMr9+eFhm8gBB9QQyzuaQD+5QGSZy7ht0cUrSLO bcrj2VjWE2Tm1IDw4G90QMj1a9xYBHHMY3jTtfslGUvOq/7IbnzmuJ4QGRNij4yWi4HBWG1w1Ejg 7oauS7eL3KCF1m/+EL2ZGsk37ohO/e5uPZY8jzGCAOUlsjmnY3PshTOY8Snf0kK2VDmEjUsETGxu bFE2R1xvcoRmS2pebn2TWVAk3d2WE86XC5tfsqa4aiAeyEM6R4ewkKqeU6bk7LE80RR2J5TYJ2tj deyAyZJtLTusc1N9t7hKdL3cdkt7rM22HuhaMkTXb6imvuWAh3C4oVNnbm4Wcx94bjYKWKMhnqYC Tv7K3uDyOxWIagNsByjLyNJ7pZaMgP0ygO4WPXu8t4DdwrqHedaxsQlukBab7uVsjMeOQucQNlke bIGA825WJAwxl5cdyVklw8qwO5KgoaypL2gEWT2Skt7WCxC4NAbZU/UIy1hsbJYofNO3V923wlum c+wv6QsBjDA28h1EnhZUZBA7JZDJZJYC44TZZwbAFKcQG+6xZXOJAaUsGX5h3tyOwQTODhuUgF0f zdN9L23IVFlC5Fg7dW9jrWJQXDFUkpcwkb2QqCD7Wb3TmuLRc8rjwZXkOtsnPqCAO+yhSOJDybX3 T4pXMcL7rAfVEP2GyfBOHu35RMjMt7CHavdLY10jjc2QmZr/AFX4STMQSb/sqUc4OjcdPIUiqCQS TZyx/Nc4ajsoGHTq5ujAwzOc8A+oexTfOAFr2+Fi+XazrkK5HMkItypYMkTsjcWXu48JomcG7my4 8QBtQ15JunVjjqaNrW4VJY6Sq9O25S3yaW7nlKbM1pAI2CCVwc8nsgsZHIdPIP4VGqe020nZBEWN O2w9lkaAd1OS2bYoM1UEcnlGUtf8r6DD8RjrGDy5Afm66NGPCp0vIYfkFfYZKxo1E1mEkDsv49KG 3ln9EUrO0pHFwI5Nuy656wkDp1mBr2ixgcBf3svt6evu6xN11113qwOn2KBvDoyDZbxz+yoko2mj Wo6F1PI5pFruJ/yuXp2EsbfcpVdSiarcC6wB5T6ZpY6w3AX9KwS3Qtn5HPHbNpA1bSISR/Yr5qQ3 lJI4PK+nqXuDTfcFcDURDcg2uV7YM8WRWY5Pc3uhc25B4+E1pLR2IVStAdcLvZ56MaRukXQatlct wUkA3K2jmyywag5Ha7kCNt+QtsgQBuiDd9lAVd7FZLRCPdVcE8cK3N4Ua5t90IMDtYNjZJs5t3He yc0NdexshGppLTuChaMilLSA49lmlxmI39KxqSL+kiwKyXRmMXvshAJG+YR2ARiMEb9kHO4RsNxq PC0AWvDiR7J7XCwFkkN0uuEbZNRA9lQMkDiNxpCx3ts7Y7JkkznnT2QvbqbsgA0uBvewS3RXcSSj bqGx3CLy9QJQAaxsAr0kqozvwjJWgCGlp/8AlTSACERHG6AmxSwVZreNlYYXEG/KIgWBKENLrkcL IKczS617ovb5VtHc7lUTcWCtgoD1HfZRxJIt/lCTYiysnuoCWsQSUbwCBxsluaCEBc4mw4QGQ0DS o4gWvwqYNhdR4D3WQF/1Xt6URI2tur2DQDwguDwOEBdze6gdqIvso1wtc3CXLK1h32Ctgc9zR6v6 QqibFK0vB3Cwpahsg0MOorLgAigG2/cKAcC6YWcbNHCxpY9LbnhZkTRtfukyuD3uaRt7pQMNr2tu fZHG3z2677JAaA52rdqOCpIeGNFgtIGQ2zQbHcJbdTi4kCwVvgEbXG+53SC97G6QOdkIxw3JKENL 3bja6KdppomAn1ORn0RtcRyhKLkZ6bBKDrMsRuj1kWKh43CEF7AXKG+og8Jjoy+PUEhsRI2UoDwS Bu7ZVJ6Rf3QiIuvuqLXm19wiBT5XFpb2Vj7QT2RCPV2REEC1tlQLA9lYCpXuSgALS1128IjxsN+6 sclWwXKiBQare30gBWRsqFwQqAA5zjYqWDQe6u9ySrdY9t0AokOBUjIG52+ET2Xbcb+6U87DugHO kaNv8pbjqdsgIIsbXCt23wgHPGoDfZU06QRdKtpsb3Hsja4OcNt0BGtJBv2QxyBr9P7LILbG6BoY 0l5FyEBTmkDcKNsTuEb5fNaCAg0+5QFueAOEsx6jdHbf4VlwZtfdAQM9xuo42HwgL3A77BVu92kb qgJ8w2AF/lV5Zab32V2A5/urJu34UAt9r3vdRkRcSb7K9DRvZGywub3PshllCAtN27o3sLQN90Yd pGwsEqZweQL2+UNIgkPBQm779kAY7XfsmO9LUAAjsdyiGlwseEovdqF+E5osAfdAWCGhBfa9kdt9 yo5oDUJYIeQATx7IXAHe9rq3DYWGyoN1OudgtEAc+zxveyyGyBx2OyQ9gL/gp0VM1gvfZSi2Ohka 5+ixuuQB8loWDJE2maJWm59lmRTCpjaTt8LMkbTMuGYaNwjB2uAsfVptbspHO4PudwuTNmS31A6u UOogKwTIQbWCuQah6FkoD7lu3dE28cW5CjhYC5Q2BsCQqATGdGrsmQjzBt2RshleNLW3CYyimpvU Y3AJY5Mdw09twlNJLk6VpeCL6SsdkbiTZKA4uDuUHl7Hv8KbsHqG6JrrtvYhVEA8sv2OwUEPlcG9 0xx1NPv7JYl9NjsqUmmzr8pm5HsUgyFpHsgM7tW/CAymCyRVyaHDuUHnnf3VGz7Odz7IATJuPdOb I3YHYpHD77WVua073sfZANllLTZtx8qmTSXsTcKmPEzOLEIWOIcWkcIB+okKv+6gls3jZQvbY25Q EGojY2VEuDgf6k1kesX4AQuG5KAoPc7unMmBtqHCxA46uUYvdQDnSFzxbhWBqcHG2ocJZJaLomXG 4KoMm3p3N0p0d9yq814Nj3RFxte26AE2PCPZrQfdVfUOLIHtLhtwFAGdjeyaCLDeyWBwCf7qSkOl YezewSgR9h8/lUBcK3Sb7jZAJQTa1lQG69rkoG/9IKK5sboY5CQQNlAWGm/yidc2bfZUx2m/dQkF 5CnYIQ6wsdgr07Aq9BAPshubHfhaIR59Hyltc61xsqcfNaB39kLXnVp9kFDfNeBuELng2Nk2V4ax o2N0hrvWQf2Qpb4tMge1NbZ25VNedJBAVXttblCUEABwrLQ/k2VNOyhc0DdSgG6UWDewVSd7IGtD kUh9IASiidJcSU1tm2JN0B2HKuyUAi8POwsheA3tuprs4AcKpTc7FToAhxB3RPBtccIDtbuUTbnb srYI1+myNkoubj+6UGjUR2RaRflUBOldE64FweyoTB++gNPwgLnA+6oPA5QDHOB77qvKbfWHEOHZ CGhxVvGkX5JUYLE4lFnchS4dwdkk7H2v2RjjZZBYNj8Kib8dlA6xtyiaQ0m/KAVv3/sjBNudkTmj ST7pLiY+OUA13G3+FVzp9SppLhcco/LJFu6AS5lyLbJrHad0BO2m26MMIbcoAnDU1zrJQHpNrhE6 T+XpBQayBuqA2SO4R87koY27j2KNzmtBCgKBLlQcNXygLiNhwhv+6AafVxslPaS7fcI2k2Ua0u3J sgFabmx2UMQHBTCR3QkWsgCBsbFGZLD4Sm+p26LQDcICCUEoi/V+Eg+l3wiYSHfCECIP7BWCARZF ywlA1twgsbcObb2SnsGq54TLBoUaA7kIUU0WdcJ2scKOs0/Coaee6Eory7uuoGkAq7+yrVq9I3Ps hKKN9Ntiqc0BqKxadxb8oXOugoq1m3vf4Rl7g0ABUGem6uNzmG9rkIaKL9V9QSRISdIRubJJIXHY eytwEZB5QlBNBDAqLdR5TNnNvayUQR+EKU64UIFhbc91evULWVNGk7IQJpJtYbfKjubI27bgIXgF wJQpR2tZTV6jdR7rm6AXO/KAKR+kDZWA4tvZASXNvbdSpd5UDLHcndAHrF7E7qnG4VBjD6tVyrNj 2UBW+of7Uy9gUFrjlRh9VlQWG6d73Udt8XUPtwgedrgJYLlcdLRckItwAgiaZXBrnaB7lWWOY8tc 7UB3QlFk3Vk7IQblX9t+6FB5bxuha7SC+26MevjZC4X43UoBOdqaPlVotb2KIDXYFMYBq3OwRAWB Y7KrerlE6QFx2shuNW6oDAA5QSEA2t+6jieyAN1ncIA9W3yiv/dLI3+FfZAXIL2siuA0X5S3PceR dQsLhe9kBfmg9lNYKAs02sQ4lU1l+eQhAzLZ1kZ/mt9kofKO5Y4W3BVKUdjb/KJouNlZbbhFaxUB AwFtyUMbyA7fjhVJe9+yFsh0nSEAy+rc8qpTYbJT5vRsN1ccnmDjdAVrcBwqI1DY7priXDfayXqV BIwWnfgprgAOULX6huhcQTYFCMIOA53V3BKU7ax4CtsgLrBQIt7ARYIfI0tuDumh7XG1kJO5QoJu W7m5S5X243RHk+yW1g17lAW1xJBGyJ4LjdWQLbIGuN9ygGhpIB7BX+oYwOAB1na6APda39KtjrDs gC0WDATzylmMXeSdhx8punzRuVPJDdzuEBWlzWtKN0ewcfZAZASN7KPkLWk32AQCnyWeq80F1zyg aTL6rWaUwMa5tzsQgDtc6gbFC7WD7q2Ot7K9Z1WQAB8gPCMuJFyoH+og9lLk3sqCagBvuVTXBpVW 1XsUTW6bA7oCy7VYnZEGAgbqg0N5KsmxA7e6gKLSHXAVPN977hWZw0WKEOB3O6oKDlGm7rIxuLgb Jdr7tsoAZhd1lZcWloIs33TdI0hx5Qyu8wADZATSDxuoBoOyAuAaAOQibNYXsLoCpnnYtvf3Q+rY ndX5g790Nw55B5QGQ3c34CtwFlXmjQARayjnCw35QFFoNvZSINiJBOxSxKZHBgFiO6sOadQJ47lA R5Bk24U8y92jlLcQ69jshaHA3PHugMiMhoIc291RYTzwhEhA3F/lN80EcXQAtaG8Iw8HciyBjrkk IXTav2QDQL3IGyrTc2ShM4cGwVeaWm5KgGObt+FUbQT7oGTlwOrhA+Vzjdh2CoHPB8zbhGdcY34S RKXWJtdNkl1NANgowXM0Oj1HlC3duwS3yanc7BCagA+gpYGuJPpAuVTQ/SRvcJQqPKfrO5Vistqc ByrYoJxJZchVe7Ldkvzi4W23VF9tuEstDRp07KHS4bj8JTLA7ndQyAusDdLJRkR2LDcq7+n3+UDP ULN2HspGfLcQ4/sgBABN7poeAw6bXWG9w8w3JAukMqvJmdHfUD3QHJtdZmq9wqfBG60lt1gGd0Q3 vYlZIfqDXA+n2QGTfYIB79koTargeyWyoNyEBlNQl2k/+EkylvfZD55e8bWQD3O1C24VEkM+UBl1 OtwFC9tiQdlABu64vypGGseWuKXJOA4G4sEmWYPcXAqkMwkNkIvsrjkAaQ47rj2ylvqBuUeoPIcb hCWZ8bww3BF0U09wHDt7LB1jWN1UtQNBa0+oqizJnlbVMAJ49kwP1R2A4XGRG59llCcNabKFszma dA1G5UkliG+oXXDyT2Ny4pT5Lua4EoU5ZtZqJaNkIrNLiDusBshJFv7qOmDXEcn3QHKea1oB7+yX LWta3YbrBhlLhc7lLqJSe/CqIzLNU1/OyWKlkhsNvyuNNVpdvuFTJhJLsbKsyclLKGkAJRqbdtkg 3a7m5QPlbblZLZntqI5tgBqCCSQOZa9rLDhLQ0uBskuqSTuhTIdUiJ/uuQoMR8xhZa1+64APa59z uFnR1EbQ3QeEIMmfoqHC/HdOhqmtcBfZYjpo3EuPJWO869wLWWkys5Keuc6UBgs33RVT7wgNPqK4 2Krc4Flhf3CjdYdu+6pkex7uHDdP1XABS3s1tDmm+yX5jh+AssDJZQ3Y7fCES2tZKkk8yx7o2WJu TZQtjC8ki6ZGRe5NkgvseQQiDmOFr2QhkGV247e6uN3mbHYBC9rnMAB291i2MReC/jhUqMgu8uQk OuhEhLzvYEpUofFCJDvdJjlLgHHZQhyIm0jS07FDK3XbfcLEdM1lndgnOmGkEd90KW4uBNjt7JsD 7DY2WKyo1E3CcCCfSll5Mkv334QvItYbJXm6RxdV+oDh7EFCj4xpFyP3Rue1vewSDUWcGkhLfKHE tKWC3SkTXvdqsza3EhYjwbk3umxNsAb3JUsDxOCdxY+6W6cMdzcqpXCMG6Qx2vfseEsGdDVjV6uQ ikqhuQuOdL5ZuRa6GOoPmWsbKgzf1VzbgovPuQdWywXA6ybHhCw+W3S6+6lg5EyCU3G6dDUtiYSX briGyuhB0i91UWt9ySb+yWDLlnfNNqTGPJb6juuP1Pc/ZxaFkPLowH31BLAx7/UAXbqzI4em/wDZ LA12cRsj2vslgt8khbpG6pr9B35VXdqtx8ohHd1yblQDvPs32QCTV337IHWDDcX3RiPSwvtpAF1a BcUwLhvv3WQ6Yam2P7LiaWQuu/sSsiZ5efTtZLBkOnBmN9lGO0OL+6QH7C4Vu1EXBsFEBzJzKTrd bfayJzAXWDlhOjcGg3Ccx4aASd1bBkTSMipyb7gLBo6qSZhcRY32RTOD9r3CGH0uAA2UsGb57msN 90ilIExkI3UeAXEXVBmgWG6qFmS0gtd8m6X5wbdreEBJAAB5QNHqVBHHVv3TYni1ybEJbgOBygAd 3F0BnMOtu52SJ5iHWb2SppDGQN90DiS245QDASw6idkyGYudZu9+6xwCeTcIW+l92oAnyTQ1BD3j R7FZYrgWWHZYc8Iq7Bxs5U2IRkM9kBlCr9RBHPdJe8OG3ZWAJHW17BQxji6AXI8uaNR2CJlQ3y7N FigfCQNylhwLw2yAdqe5t5HXb2UMxa2wKTUlzi1jTZUYnR3LjcIBomduDz2VskdoueUvawIN1e9v hRgZ54LgHmwVSP8A5hc37QOQkiMSn1InPsNI4UoEjc10lzueyy3zNp4i9ws0crjY3uE4Gn91yEg1 xEOsQeyvoJlT1sZhY9g2dwhFTqAJ49isURiNzQ6+kcBN8pshsdrqge+q+22w+EieoLybbKvI0SWL kPlyTPMbCFAVFMDc/wBXCyewWK2lmhBZJbV7hZ8TP5W/I7qgpl7/AAmR1Gkn2CU99gleaQLIWjJ1 AkkC11CToveyTFLv6uUZfqDtkILlmAcBfZOpqlkDvV37LDkIfYW3HdW5hkF7WIQGWZAXu0iwKW67 mb7hIEj9J+EURcWFxPCApzWttcbJkTBqv2QGUOs21yibIA0k7W2Qo9rtO/sp+o81uwsUnWHMJ3VP eABo5QgV3PNnKBropdRPpKrS6SO9/UgZqkaQTwhbHPeJng9kNmkm2yBji1vuo7S2PUe6CwxGwknU D8Im/jZKghbfWN/3Tm8WOygskzPNsT2SvK3uDZGHev4Vu2Bt2VIJnYXsDRckInRlsbfdGAWeojkK Sb/j3QtiHXcdF0b3kR6HfsVTC2R23ZSpbfSBtZSwzFDLEC+3K5KMtFPYcrCDbuAtZZBOlzWhQIW5 rh+U6OQWAJ3Qai9xBCIFrD+ELZeskkBAXAG3dLM+qQ9h7pkXqJIIchLCLQ4gkqMLLm3bhK8wB2/P sjGzgUIWyUmWzhz7qpWuDjv+EUpDgNrFCbkA90AqONz5P5hsOyLzfLkDeR7o5QABvuqDGP55QDRJ ccJL7gjSUenewNgluvrHdAMc1wIJKnnBu53KTK94eLDZN0Bzb/4VsBSSXaLBWHDytkLY7nm3wgeH Ru23CoQ7UWxflIOwse6TNK8DYo45DIG6t0KxjIBpAclvbolFhYLIGwQOIc4EoQTMbekEgFG2O4CC Z4LxtsFkMYDFquhUXI0eXbkJYf5bbA3+FbZWltjyELW6rfKjDG+YC3dLLRzeyvQb27KrXFioVkJI 3vcqwS9/qVW1BUXBh2uUMhabPuftSnOOsgNsPdH5glaWjcq44ybBytgxL/ze9lkgP7O/ymGAEnsl +WBtcq2D2dgVTN5gbrNj2XbuQ9UEosbau6+Cyzleoq6iKRsZDBzfuuzsMwyXDvVoK/lefb0fu8bd 2feUx0guPNl8J1bkE+R8Za8XAiNh+y+mhxbyoAHN3XxfUuuZVZWxONn3vhdsvNjglNUeqTdGvWtq HuqCGmxLze/suRpQGx6g691xWJx+TWSv7teRb91nUEzZxo7hf0nDXjR+OytvI7LrifKsOFwruSCu arn6W27e64aQta4+69cDyTFXs63Cs+o8Kab7oHlzTcLujixUoa6Tc7LFeLO24T5WXNzz7LEdJpfZ dEzkxg3TG8JbSjF91ogYKE31cKjdtjdRz/7lQqf6EHOA3OyYwNIuOVbWXZYnc+6o04cB6t/ZC8ei 3EN4UpW6qi8p0sHdRjbkahwjmIdGRwEDMmeq/mt8k3b7o2zOkdpcfSuPpwdPpN/hZ7YiG6jtf3Qy ERoNm+oI3sOhu5sU2NzGi3dMkc149NlotGMQQAb7KRguftuSruCbIo520k4fa5tYKkFtJDye4TA4 lpN9/ZW6M2LzsCbqgBvdAA5xaNwoJtrIXPufhC4ckIC3+mxaL/hW4ENHuihN90TATIS42CFQsO30 lGWg2sLprxFpvtdKLw1t28oQAuBdpOwVn+WbN3HurDQ+MuPKTHIWDjZCjBJd3ChPpJtYqzu2/CXu bgboQgta/dG1g0nurYwlnyFQda44QFWBBuqLRsb2IRixaSgIEhsOVWCGQgEf5S2vu4XNt+U0taBY 7koBDYepQD+B7hLfIGcI7amaAdIIWM+JsItquSrQGuqmOaAFXlRzCzzse6xGwFhv7rJLCG+rYKgX T0DaKckSB7TuFmOYNVwdlhtdHGTYG6eKkaQLKUDJY+424SpwTEQ3YkqhILADZWHXt3CAxPIIbuSV Z0tI0jdZJs0OcRykvIIFhulkotzy5h+Elz9QaQN021hb3ChDXtDRsR3VspckZqQ17jYtUlkDow2/ CsAWAJuqETDUhrTcWvuhkkbLjnZG7YKOGhpANkIGofIQUHCWsa7XweENRaKEyNOyp1nNt3QuiM0O n2KEJJ/Kha89wo15cAR/ZC/+bC2O9iFcV2kNJARAa15A2AWO6ZxdpcFkiwKQYrzk9ghaJfQdwpq2 22RWLnn2CMNHfhCCmg/3VgeqwQyucH2GyJguLoCFt9gomBmqwad1Yjs7m5QGO4gPA7nso4uDyLph h01DJDwOyqS13P8AcoBLgb7n9kIZdxA4KY5mpoS92nnhACXOgd69wjL/ADQXAbKNhMw3OyOJlrxo Upkepl1A0N3Kt/oOlCSALX9KEGuIazY3KWODfclCZQCAFWohxPYoAtRaNihMhBF1TiLX7KmWcR7I BrmuLbhQtAZr7p8TgWkW2S5nBjS23PCAxmOMx3WUP5bAA31Husdp0t2WZTAAeoXJ3F0AlzQwkm5u q2cPSsiocGtNxZce6UE+k2CAeDcfCW57WOuQo1xtyrMbXuF0FDmSCQXCTM2wuCmxN8sEAbJYAbIT vZAVG82sSjc0loul6g+XYbBN8wgb7oSgSwEbjdELe/CAOLn78Iy0NFu6EsoWJKsnsqDUYG6paBab AqBwPZWdkA9RsOAgoB51G17K2tJFg7ZW5rbH3QQelx91bIZ8DTcat2LO8qNzdMexCxKeVrNIfwnt cGzXjHpPKwzokPZGdQaeVlRwgE3F0hkl3A2BTnT3cLbELkzoEYyw2vZU0+ULXuhdMHnlUWa+9lkF Ou4koCARvtZNcQ0WSHu1NuOEB9DgNe2CWMSRh0fuV9FiGJ4eIy3UwE9ivgYpnMA32R1JgqQHOB1j vdYcbdm4z2mbirWvN4wA34WBGQI3C41Io6lgYWA9u/ZYUYJlN72911XCOTdsy9QPJ2RO06bBYz5g CGt3Ct8m1wqQCXWzdvCEWLbkkFSSYhtvdAwgAEm59kNIdpY4cpcjbDY3V3a4eyom5QoguLboo7nY 8pr9FheyjmtDhpNwgFn0ndVa7y47hGdgTyluceLIA9dvt2CpzyAb8+6AuIFhtfurbYix3KELEm25 sArbKHOCWW3BuluLo7FvCCzNEsgBB2arbJfk2WM+UmMG/PKonSNygHSEavlXG03uTskF5cBYfumt lFtN90KZbJAGWPdWHNH2ndYjXlou4qmv1E24QGWJLuF00PDeFxry+2xWRBIHNs47oDIdJvZvPdFp uB8pchio2a5X2J4CtjvOaJANLFLA0gMPq3S3v9VxZDPI6wIGyUGukPslgfrDxa9io/0tv3+EBiLC O6k4sWhAQOcdvdEwadlV9IHb5TNd7FtksAai07JrCHi3dA73tslglj9wbHugMvltgeFjPcWMPe6g m0yEISSeQqCWDHt+QmMiErrnZKldwQEts0jHAONkBkPptD9iS1C6MjvsnRv1C3+UpsUrZnF+zOyA ICwR8NUDLjZCWltgUAbbW/8AKW4DZE1pN77AKFm6AtjLj2SpHaSB3TiQN0qYNDS4H1ICrern9kZu ASOUMIDhc/crGxKAgGxKB27kd9kUQ1bEbLIFmL03NlG/lOIB2CW5mh3/AMICnbMJAS2kP3OxTGyE us0g/lE1jy4kgXQAaXAH2WO/02usweppFrFCYdLd9wlgXGdI32VuaS6/IRloA33Q8usEsAvaWuuD cKbEbcqyVTRyUBRcGWLuSpGQX7lU9lxc9kOi5vxZQGS4B0ZHssV3NlkMcDtdC5rf6QgBa6w2TO4s boLW2tuqvpIIKFoyJ2NjYD3WM87GydIfMsbbJMjeCgSFg6rKy3UbKmN3sikf5dha5KBjA8NIHsqe 7U73Qhu26u1hyhCnNLjfsisLcbq7m1kQ2SwCARudkDiSeU2R7Sw77pUYBBvujBGn3Cp3HsrA7hU4 3IBWSlA7o3CzdkOpoBCgdce6pCmta6+oo2uDOeeyVcFw5BRvFzvynIDY4uJv3RFltwlA2HumF22x slgFzxx3VNcWgkqizWdV+Ed2k/CtgEyahwi1AAX5QOe1u1uVQJBBdsEsUOaA74Sy/wAuX0pgIIuO FHRtILgd0BUkxJBPdUQBcdyhYCXAdkb7awQgIwFt7lMMoYwPOwSni5uCr0B7NL+3ZAN81kv2goHN b+UEThG4taLAq5fS644KAKxA+EtxNzfhE2Qn7trIXuFigAb/AGVXNyFY9WxCNt3DYIB0VrbpMkgL 7Ig8NBusVzv5qAewar7IhGbJbX6TYEf3VOcWG4N0sDD6Ta9kTQ0kF42SWvuPVyqkBfYX2Clgc0AF /p/CEghmyhlAsFTpPVfslgJrbi5NjZCXaRx+6W4Em4NlbXamgHchQDNYIIQsJDbKF4AtbdUJPZBQ T2OcLjgKmEtID9kBnIBcDa3ZJfVOl+LJZaMvYu2RAWfbkLHjmboOrY/KA1BBsNwlijMsATYIGNdq NtgkGpPa6L9QS3mxVslDwNySbJbnWdcHcpYlJbc8lLc/S7dAZD7lvZSM7+oLGbVNcedlYmLr77K2 DJMgHzZXq4I2WLDUs1EPNkLaovlc3T6Bw5SxRnAb+6m2+yQ2a42O6a1+ptr7pYLLBtuqcwc8j2Sp JdOw3CWJnF1idlbFDgxrSrtc7eyW6UDjcq3yWYLbE+ylMEc8G24up5gPfhYZcGv3KX51yQCgOTa+ +91Z3F7rEgcWizisqRwDAiBZdqSZGva70g6fhE6UsZcbpbMROqzm2VBbGuB34Uc0t9QNrdlH1wew tSRNrG+ylgaKkyHiyvWCEh8zbWbyriddtylgZ6i4WTQ3TuUkyaRdUZuN1bFGQ+zjbhJDAx5N9lTn lzfe6U6RjYyCdwpYocyS5JV63Wv2WK2ZrYnHfV7J9wIG9iUsBOd/+VW57TaxSLav6roTdqhUZAfY 7nZQzROPqKxr3aSCl2ANzylijkA2Mi7HbH3VDbhYDJg0EE2PYJoqXabcFWxQ+SYxDYpQxB42I2Sj q0anb7onFspBtwllCEn8wPcdimVjnNfHbdjubLHeBYXUdK8lpv6QlijkBJG6JrGttbuUuTSBsd0g zjRYLElmcTsbBLMmcwi+pxUMo1ey48vJHKcZtUY91LLRkSO9JLeUUEjtPqNlgxXDi4prqgaw1xsT wrYozmzhpN+EiWv0usxurdYpfIHOHZYxlc1xsEsM5jzb6STueyGpnLDbgW5WDC7XYuNkrEBJI3UD 6UshlSTOkAa0/ujEgY4C6wKfU2GxduhBMUmq9/yjByz6h4bZhsELpC1gPcrEZKJD3Ce4hzQlloZF O5zSDv7KzI5oul2A7WS3PMTjc+kpYoyYHAE3NifdKme/XdrfT7rFlqLEELIZikv6byXRtI/3KMUZ EbtZ37C6VRubI2Z53sbAlY76hwYQOUNLJogcNQvyUFGc+UAAnhKfUBw9Kx2zed6TsPcqzKyleyIk Pc7iytigw92u4NkQke1pBHJQC+/+4ImOPcKWKGA7bqPefK5QuJcBccJLnOcduAlloeyYgW3KYZrN usMSubuUEtRY2tsUBkiquDYkXVsk9Ong+6xhMHlrbcImvcXX4ASxRltIta+6q+u4vcjuEh51Nvex QB7mtu0q2Sh5k9Fr2I5SjP5Q2F7qiy7bg791RbqNubKkDbUObYndPMt49RWIQ52/Nkxu8RB5QFPq QNlUcoPf9ljkkchWx4BWWDNa8yu9QFginIYywCUdoweCkue4mxuflCoNrr79wrkJIuCltuEMmoDb uhRkdR3I3R+YPutZYwbuLm6J5LvwgMqOZocXaiFX6jzCbOWK86Utupp1IRmS6T0eo3I7Iaids0JD GaXgbOWM97CL2IcVCSwgDuqiB09WJYgyQESA8oWVEnnFl7N7KmNsSdrlEObkWd7qgyGzG5aOUrzH k8pYe0ONzuia5oaTyo+APa83AJQufYkA/ultYXeu9rdkQvp43TsFMmOvm4VyTGxsT+EGnQDccqAN ItuoAHSBvJuj8weVwgdEHHm6IR3aArZAad+5PCf5otxdJ0aDZWWGMb7q2KLlnaN+Cksm1OvfZO/T RzNN9ilGmEd7lCUM8wN3vf5VuqbMF0mwYLg/hRoDxYlBRJSHHVfZJ/XtaNBGwKvET5dMHMPeyW6m bG1jjYm10Kh7KnzNwLKn1B3A2SWSFh2ACMFp3OyhRkMhsbGwRueNB1boQ5oaAFUhbpFksGLOwPI0 8KQsDZRc7JheL7iwSy0Hg3Cq5MFieQSmwu1IYXeY7WdijYTq52TCA622y1QEGQxmwOyJkgOx3ujk hbcWHKUYtjp5RgItZdTSQ6wBCOMsDBq+73Koy2BI3SgBJL2tayW6d1rt3v2VuaZLnsqjjuNtyFQE PS1pvZx9kx0uiwdvdA5rri42CI3Nr7IT2FHPpuBcXT43nyyL7rD/AK/hOgAhcbuuD7qNFDaCRvym BzXbE3KxjITUjcaFkMaGuLANz3WQLqSB6QCCsZjJHSAa9APcrIlBY/17lDIHVBGkWAQE11URDfN1 t9wpJMdWm93FXCzS0tJJI91TGtLiSdwgGvkll0sd9o7InRejlCyU3sUwgWuCgAaL2uLgJ5mF9xsN kkyFo27IC8udqP8AZChtkAefTYJsc4v7LCkmc+QAbBB+ocx4bpv8q0Q5R7/RccrFdJrvsQVI6gPH Fj7JkliBcBSi2Ype50gcTeyymSue4WGyxQLkgbJ8VUxlmgWIUoWOdZx4QjU07HhM/WMlt6LJfqe8 gbflSi2Sod5kZvyh84NpQGN+1E2xuCpI9tOw7coDEEnmH1FZY02APIXHSv1WIG3us6nqWyNt3AWi IYXHcW/dUQC25RucC29rqmC5N9gVk0U0NbuTZqQNRl9Ny1ZDmNc0A7q2MDeEAuWJ0g9rJrGXiA5U c42sAgY+xsd0A92zQg5O/KpzrEWQVEhZa+10Aw6r7hGx41eyXH62IneposNwheCSGxsOCiqbuonN HNtlI23Z6tgoPQ06jf2VsUYtBaOm8t+zrp19+EmQ2eH2WUJ2OjFm7lQlCwdZ2CMNLQQVZ9N9IQ31 DflASTUGiykcBcwuJ29kLxcWuqjJZ39KAgLRdvb3S9JEw32TXtDjsoGAEFAMLRcKeYWix3QkAlUX hg4v8oAvNA2t/dR4Nw7slSepuoEWUiqr8jZANlO12jhIEr9YtwsmNwdc9kDyA70hAQyaxZwt8oiw NZflU12rayKR1gB2SwCwCxHuh8jSLXIQh13XG9k6+u19lbAtrbXN90pz7PuTynPBaLIGwhxvufyo aFsLWvuU5puQP8oJKbVYg8K7AAaitGSjd5IBusd0b21QGxAWYQ1o9B2SXNs8k8qWaoqWz3gjsoLE XO6CJwcdKZp3sqZLs3YjhVcEeyF7w11gEsSEnhAMBJcr8trSXO22QRzHVuEbj+r9N9kBilznvOgX T4/MaN7k/KuOHyCQN0wPcDYiyAW4+Zcn7goeAByrD/u2/JVRMLzflAW2/LlUwLmEsOkpwYHmxNlX l7oBFG0kHU8l3uVlvksyze3KBsQY+53v2Vbxg90AQudjwppsCbXUN2+pV5jngBtgULYYZqbxYqgS G2vZR/6iMW2ITC1un5QhiO9D9/7ojIB32VvkY0faUGm5FxsVOQGNrAWN0yR1m6bJI9L9j+FUj3GX cqgkZBfYArJ8ppZuEqGwY8nchWNbhsNj7oCxZo0HgqowxshULS0XKBw/mgj2QWE5j2OuDcH2QkjV YcoNMlzp3HKqN7nOuW2QDQHNHshmJcwNTmkydkl33G/CAqnc6I/9KyJDccWWPDP5h06eE+R4cBZS gQEbITIWguPAVkbbFBL6wG8KgKN/6gXJsApK8BtgUgRlhIDrBU9oJte6AfG0MdcWCuYkOvyltaR3 VvDnAWIIWWCo4vOeTqssiOnDXkk72WGSW8GxWVTyOcwkoVAgHW6wuUNNG4yO80W9rpge5mojYngo HyPqm6Xm34QjDbDFO6RrSC4DhY1K8UBcx27nbbrJpodB9LQ0jb8pMsf6mujBYWBvJQEZAb+Ye6aG C4RPvpIAsL2CU2XSbFANLLmyonSi84XHAQvYD6hv8JRbKNiQqcz/AGqh6xsrB4BCUOAxHYXuhds1 G+zRseQltZdu+xVopQfYEe6FoOnfcInDV+QoNxYjZKMsoM1uFtinBgj9Lxue6S/XcGMd90RPnfcb EJYMSvLWENaeUMMvlv0A6ge6dLSN1aidQ+UmKnIkcRuFbBlyymMWtdKgcZAfhVUuLWhp590FNO3S WjYoBwaHXvwE1szXRlrdyPZJh16iDuCj8rSdtlPYFk3FrWKfC4NaAdyseRh1EuKY1g03DkYGyEg7 d0F7vA7I2gv5N0QAafdKFgkAJVw5yqaRziQ3ZCA1kYF9yVaATWtjfq5KNjnPeTewStXq0tN0uXW4 6Wm3yoDJ8/TIARdvuiL2XKRGQ5lnC5ClyeypDbHhGVhRtEbGWA24X0jMGZoAeP3XNspmR3IAQVBs 34X8gcrP6MopHzGIYACwuY1dWdSKd9JhNWWtO8Zadvhd5CrijYWvFwe6+DznR0uJ0FTEG3DmnhMb e9UWb+prQxholqqprdnNldf+6OliFPG1w+5yzM24ecIzji9O4GzZXAD91gU0wkfbsNt1/SdPzBH4 /UKp2PqbSR2K4apbrDmt591z08IMJPYr5+svDIPle+B4p/oLAWta29yOUT3du6oN9IddC54dt3XZ HBmFKPUdR3So2C73OG/ZNq36XDZTT3sto5sUDvxZM1BouULwT2soxt9itohbBqHKa2BocCTdCBpN giuGuFlGAZ7ueCzayJjnNP4Uc4AHZCDIC0jcd1AM8wl24RCRr5NB2uibI0eo8KxNC93YOHCAB1qW UBm7b7rkGEyn/pssJpYTze5XIRBscYseexQAtj9d+/Cp+pjrBZFhseEEgJOypox2uNzfsinjbJoN 7lMMYItaxKXMwssBsVSUMdUFzRG4+kKR30kA3SowHOs8o5ZRC2zePdUIt8Zt+EDbAE9wgdIbBwNw UUfrbxZT2QJp21IJ6gaLE8oz6AAVjzNu9txtdUBxghvOx91bAQ0i/JTC3024al+UAbl23YIBkhDA L7j2QyPu1oAsFY8p4s479kL7n0jcDuhR7vTFtwlxkcjcK4/VERfcK2M0i3F0IQOBOxVOjsblU5oj crlfYttuUBCLN2CqAXdxui1A21KPlEZBbwhSn2bIO5ROaXH2VF7Jm3GzkLNbXXduEIC5pc4WuCFB Sh7yXG6PW4u24UsXbA2SwY7pNLi211kNtJYWuh8ka/ZW8mJ12b/KWAXwt1bC3wqexun59kT3a9Lu 55QeVck72QCXek+rhMadIs3hVIPi6KMEG5FlbBcmp0YCYQHNHuFTWknfhWedlLANwO11bSPbdCDs e6rVY8K2AtQB2CECzy8IW3kBDeVbRwCdwgL1ax6hYqhq7C4QzvLHCwumRXABcdPwVQELOIBFvdEH DhvCvZ21gkg2vYoShkobHawvfuhdTtkGtxVBp0bm6tuwseEFC3NNrNPCry5Bb1J928cFLeb9+EDK ALb3O6trrbndWQXD5Ua0NZdyEBcCH6yLtVPma5tmFW0vllDHW0ORNhhDnAcA2QUSjbaQ79kxpPmk Hj3VQtDb2THEAXQgib0uPskSPHpaN7rLf6mm6xH2v6d7ICnDRYXQmxPyo67ncKRsLib7IWhtPe7v hML28gepBEC1h33UkOhwsLoaFynm+xKFoBZYhXUnXYDYI2x/ybX3QlAGNoFzwqMvmCzW2A+EyFpb cPOysSsa/wAsDY91GKFGK4B7eyMNa22ybLGNI3SDsRurYoyInB7w1osqrYyLWAuq+xvp+63KFxk0 jWeUJRjmHVa23crM0ta1rgdwkE6UIkcw8XCAbPIJWfKwnUri7W02b7LJLw4bKFupoA47hCCXSRsD Rq9R7LKiLS3cbrGkpY3EPtu1Pik8221rIUbrHCRMzWCLpmi+91HsOnYboQRG0NbZWb9+Cqc0ts4j 9k141AW2BCAXezdhwjDg6x4KoDSOFRH7IShg91NRvf3UsNIsd1HbBC8gGcgkBl/lAJhYi3KPfUAB dE5rL2sqBN9vypE0+aAFGjUSL3ssmKMMcDa5UJQUzdThqOkhZlEwhovultj8x4JbuFnQRBrgubZ1 SGhhZbawQvN3FOdwUpzdwFhs6EaALH/umAC9/dJ8txbZMaxxtvsEMlOt+UIYCfYI9Qc6yW8nUQBs oAyzULDhJkbpNgNlGyOaDZGfUzsCrZKEsjsSQicwlhtsjDmsFu6EykusNwqTgUwMibc7uUEhL+Nl U1onb7kpEspDjfhUcDX7knsoACNQHCxP1PrDSdlH1rY5A0b3QhlG17jupe52STIWEXBsVZl0jYqW aTLLQ69ypF3FzslMkG5J2QyS6PUDypZTMY8Bu53QeYXyXtYLEbUtO/JRR1TNzfcIDMLB3KoM9hYp TZxMNjsFbp1bIMa0jUSlG5bxslCocHb8JYqbX3G6oDDXu24CaIy9tnchKgm13BPCyGuFjvupZklw xoBOyDzm6/TylSPFtPcpd42m9zqClmjKe9pFnOsfZFH/AC2i6wJpRfUBcBN/WfyQT27BWymZqvIB x8qSRuY4Oa65v2WKyshkYSXaPyluq3eU4RnUeylg5Kop464xulfZw7XWVUlgpmwskAtzuuFgc6WD VIdLgjqImRFjmuJc7kIDldN4wA64UY7SLWV4a9r6cg7ntdDISCRe6gHNluPf3QykON7WKxIpPKeT e90c85JAHBVBHvII7prJAQLDZY0j9JHcqw8X2KlgynT6hshJe9otwOUu4cNtiqbUOZ6BuCrYDBsd wmmQEJNiDuluuDa+6tge12rnkcK3kEjU23yscThthw4KPn251FLA0SGN2xTpKg1DACbWXGiUucd/ 2TGk2vYhLByLn+W0C6hcdnOtZYLpTpuUs1juDu1LFHJtrI5jpaE0uaCblcV5wjaDH/ZUal59R/ss 2WjMkkadgeUsMDha91hmYg3ATI5TuTsSrYo5AelgshJGrbdIiqBpNzumCZl9zulii7hvKoyeo9gl yuDnX7IS6+3ss2KHtkDTdXr1klYocS6yNhISyUEbB+2xQyPfGC4EphLQLn/CFzg5oB4KWWhNPWEk h43WR+oOm9tliTRWeNO4WQ03bv2SyUGZrixRNcANV+FjF93FCJS0nVweAlgyDPG421/sr77cLDIj JDiy5CY6bWQ37Us1Q97+QN0L26QHdykNnawuby5WXHT6j+FLJQ9hUcdJ2/ylNl0s90Ny4+o2Ctlo aJrmx3KjiLk9ljNIDjbdWZSRZLBkxTFw09lc0jW291htlIKtsnqLnXPwpdgcwgeo3/dF5oN7rH88 ab/KXqLzZSwZnmgjbdWTssOPZ+x2904SaiRypYGNkLHe6N0127CxWKNTSblLklkLrDj4VsUPMjuO UbXbX7LHdMPLaB9yt0xaN9glijJbOC3iyIOuLlYj6mMQuI3I4CaZLQx6ju7eyWBji23yVA0aUkPA O6JlSxwIvayWA2C53VSSfzAEAluTp3SxIBLY7qWUydgfdR9wL9kg1DQ+wTNYcLA3SxQQ47gIrgN2 NykyOIcAOEt8na9vlWxQyRxG6psxk9JCTqe0H1BzSoHm4/7hLFGazsBwjO7DpO47LDinvJYnhNdU NZuDZaslEilOokttZN1k3PusV04JJcdjwhZISAAbK2KMlpcx1zurDhcknlYwnLHEfcfdQv178FCU PMrWfJ7KwSWl97/CQHBoJduPZCyQuJ0/apZaHhxtdQm59ykuJttsqM2jj+6WSjJY61vdSV2kEg2K xvMOoG6jnE91my0NBcW8/lW8gxkg7rGZK4O02/dZDYtTD6kbBTWktB5UaXNJPJSG1egmMC7vdQvc Td3ClgZI4k3JsmxuDwLLFPr2usiFnkDnY9ksEc4tPwgLwDfe6Gql0mwWOKg32CWDOc/WzYWQRyen 07lJZKXSWvpaeVYc2B5a03BSwPEh1boRJ6j2CUQQ7X7oX+/AUsD3vsL22SC8F1xx3QSSFwACjWXF gbFAE55c4HZX32SRGWP5umuHl73QBAkkqjJ6rE7qQtu1zu6wp5CagN4VQORbJchvCuUgd7rFlk/T OZfumSnU0G9gfdLAFw0GyWZHX9lctgRbcK7C2/CgoBpJKIzaWGxsVYaOUqVgI2QD2VBa0bfumioA aT3WKxp0IC25tdasDnTkHnlHHIGg3O6xnXJDQoWFpHcowZUlS0AAbuKhlAO57cBYckbneq1lW9r7 /KIGQZWyOJcCB2sltcC6/HwlhztN/ZWGb3ve6oMrzXF432Unq3ec1jBe6Q4kN2WFVGYkPh/5jeyC jnQ4t2d93slzw63AhYMckkkTXuPr7p0c0pbdwQUGdnE2+FB7DlAXFw5srJ9O33e6AsuaDY7FE2cN BFrrHc0uddLOpm/spQMvzXE2PdEWtYeb3SHVHnMBDQCPZA5rnWKUDID3sv3ujZC1xOopUZJG6jrl 1goAhGLnT2ROcSd+yAR2Ozt00ta0EHlLAFtPH9kQdqBBG6EjYWO6gaTtfcIAWuDDp3CIsD3A6rgI bNff3CnmMYLHlLBKuOMMYWbkJFQ50ukN2PdMdKNBfa5HZYzJXOcXcbogZbXOljDAbOCgDorhLY62 42Kj3WdcnlaA03NgULQZAW8WSw47G6KMEgm9kCHEBsdilOaL25Qtlc24tce6oSe43KAhja3hWLAH ZUXtA+UIeQLhAG64AA2KB0QJD3EahwrbJrbc8qWu1CIvzTySBdJIcBqte6N0bZQBxZQjyxpCCgQb j8KOc5zdJRlovzuppsboKFNjLTuUw/Kl7/CoEA83QtEdH5guDpsmCRwABKW5jrXASzqvuhkyfMIJ JPKQ9zi9A+4tc3UDi3e2yCwrEPBKYXEb+yTHOXuI02H4RvcTsBshUwy797+yBsTWuJuoLtG4RGxP sgskv2elVEG+ayQi7mjZH2sqFgbqULBic9tQ95PJ4THyF0lxwqJsLhEwi17WulFGmcBosUp8gaCR yqs1xtdBJEDtdKAp+pzgSdvZNbZxsW29ljyB0bgOVkOu18YJ3sqAg3S69rWQSvc94DNgmON9tgFW nSLoA2n02J3Vlh02QteIz6uE0OB4KABosLKz6WkjuqfYncoGO3tfZSyWOY8NZY7FCx19R3VTCIlo e/SD3VsjZE+zZdYstWAJWardglgACxH7onOc55FtlWge+6hS9Zc4NBuAiE4LrEW+VTRoBJ/wgL43 izTcoBhdvyEbiNIuEjS21xcKF+ohoKAJ3p90bWbAk29kjzH6rEbIyQbboC5GXPN0otkIICN7jbZU 1xDbg7oAQCAARf8AKo2LhdHe/KFwF0BNQD7AbIjsdxdDzsEBee+5HZLMguDQ4lxsPZDFKyN5BN2n 3RGHzyQTYrDJLHFhCtgyg94nu114/ZZXmAu2Oy4/S9vBUjY4uNyQqDMc4kndQF5vsEMZPl25ura0 ucRc7LLAxpFrlukqy8BCH6hY7kITudkBbnXJA5RRsMnJtZAwtuT3UEpD7AIVBmIl2xtZW9urZyEy EnZEHF33IGhQYIxa2oHuiELS7V7o3cWCq19ghBdXSiZjWggNab2UmgDwAeQmkbWJuVPNLXAWBurY EfpAwXO6UIrOO91mPlBdY8pbmN1XCgFsj1CxCUPU+w7LIdI1gWPIfLIc3cFVAlW6MR78rGh/mEAH ZPnpv1As46T8JUFI6mFy7UFTLKeCx+m11bnWaB3TC7knusdwJNyqiDhIAQHIHuDL6RsUDLvDr/sr YSGbj8LQAkaXb+/ZW1tm+yppJJvsmhoIbdAVGRpN1Nm3LSrfHa9jyqY0tb7oCy4uYUAu478InOJY RZKYHgG/CAYSwnbkISdbrcq2Qm5PujZFpcTwUAmFumU37LPicHu2OkrDcyxLrqMk0uv2UAc7iZDc 3shAJHpdZU9guSDsUTNhtylAqIOL9ygmB80WTbljTY7oQwvIdfZSgXe1hZU4G+10LgWye7UwBu1j ugDjZqbubINJY/STyjm4aG7G+6B49QI5QC/KdrsVUztFg0XVuc4kpkUOvcrQI2IuaCDunlpDdzdA 94jb6dkp8uje97qMBOaL3HbsluA13HKOB973Chtc9lEB0Vm/08p1jz7rGa6xsCm3JPOygDFh+Uud 3mbWNu6siw3KJ8pbFYgIWxTYo5SG/aPdXDCGyaW7gd0sWkabbJofpZ7H3QIy3N9Nx2WOZWk3tsEp 1SWsIBu4oqUObGXEXUopbJm3uL/ujDw8oCOXFo3RxNaD+UopO+x390TILHV3UG1w0XUBcXWcbBKA w2Db7FY0w/VAAnhGX7kA3ASQfu2RoD2vLbA2t7p7S0gC6xmkED4UMnwlAynBsfB2SpzYA9kvzXEK B3nO0k2UoEDQ9qsHS2wUAET7DcKObfvZAHqJjJKBjiTYoQ5xOm+3upYDk2QWPc2yBrruIIU8wAC5 2Q6mk+nlAEC2x7KNdq5NlTW2Rlga0FALkfZWx19iEM7iWXZa4UhfrZvygGHSW2OyB0LWbDZPbCHt uVjPFn2J2CIDN2tDQVbhpAtuhjDXnSHbq3WadPdWgWw2Cp41bqXIsAjvYfKlAGNoYLnujIsQUtzr jcIgQWixugCLroXag308pZ3OxRuBOwO6AEySREBzee6J7A5hueVBJdmhwuR3VWF+VbApgsAL8JoF xZAGjVzso941bG6hbKY0NkVmxJVNI1fKt/ZaIKedI1clGwB+/wDhVw4IwBzwjAg2DyCij/lm4Frq tIdKSilFtIB2UQG7kX91UgJaO5ROaTGCDayFoNySVQLY1xvfZFF/LY897bJDn/z7C9lU3mF40Cw7 oCQzea83uCnCbynlp3Lht8JWrS0ECyqWeN7AR944QD5Jv07Bq3KbFK1zQXOAv7rAbqqGXebn2Uc8 NIYUBmSAbm9/wqjjds5qjQLg2T4W+oqWCtTwDvyl+uMgE3uk1tWKaTTfclYrJpHzOcXEj2VBnF9i QRcoWPcRuE2FzHxXI9XygqHWYC3sgL02Zfuqc3U24+5L/Um24+ERcWsuEAbLxMBIvdNDnAWHdLa5 xjHdGdy3eyUBdRLoeA/YHhIkkPnANOwUq5tcgBHHBSom3lBPCAyW1DoptrEW3Ty/zT9oUhbGy+oD dU8hr/SgDEgia7bskCZgYXAanKSO8wgk2QwBofc7goChJclwGklHG6wuTuikja5+w2QyMaHAA7oB jpABsFjvJfbTymnbdUxzSRfZACG+Xu88qnNBN/7J1QA8AEXQahfhSgEG3bzspE0Bxtuluc5tgBsj JLGgtHPdQCa9r73aOE2mJfCL7FVK4taL7o43eWwkC5KAN8jWjj4VxkRtv7pWkPtcovuZp3ACFskl MZ3eYyoMZHYJkcxJ0F2pw7rGMMjd28K6XVrJItb3VRBk0zmu0gXPdBYO3OxUuXyEnYIXgu44VApx If6uOyzICSy11iFoe23NllQPbo023CFQwMa1pH9SXfSOEVyfZB5jS7R/UEKTZxCY4XNwluBB9kPm b2vuhmw2G9yrLgOVVgDa6XKdJ97oA9fpISSCHXuqJu4N4umObp2QC/PEbtLrm6yYmgRF3CT5AdYl NYbbdvZAA9128XVRsAdr0gIn3B+EJk0vDTtdT0AwQBc7XQgeZcX2UduN0LfVeyWGVINIvyoSA0Ov ceyZsCLHdJewOJF907AQl2JBFj2Rh58u7QUmOPQ6xFyslr/LJuBb2VBjOqGxscCLuKxaUPL3l+4P HwnVL2uN7WKkbrxjTyhB7Yw1p9/dKA8wkMuCnRkjZwssaoJbJ6Nr+yEsQZ3U73McbuKyGlxaNilT RtAD7anI2F5aDwqQ3C0+dIqi143NPf4XJDEWTxhzXXB7LrWOrMYuV9BhNfdjbnZfx1/0f0tHMYlM Qw79l83W1bAwg2bflc3O9s8ZN9/dfCZjbKx73F+loBtZdMUWpUYmzxV1opGRdUcWe3eMkuAHF18T SR6BxyvuOtEzDm6aVv3HZ3zZfFUr3TQ6rbX2X9B0b/1pM/LatLeZ4HmRWtey4LEI93A9lz7HeQ3f uF83iLniodp3aTyvpw7PnTXBjA6SL8Jlg4XslSm1gLklP0uDRYL0dHks4qruXF1uEUUupu5/ujrX fG/dYDnG+y6JGWZsr9LgPdA2ZgvblIY9xabk7Im0moBxJ3WyD/MaTflE0G9yk+U6PbsE7USAs0Ax YtOyABwPwjuHD5CLctCgAJ2tayFtIJJQ6+/wicRZNjDgBp5QtBR0whlsdwsoWLuCCFjjzGOu4X91 kCYHZBRkMIIuT+EIfY7m3ssSSQuksCmsBAJcbrSFGQ54aBvuseoeXgAHdLcfNda5QPaRyeEsdDI7 nZ5390UrdVgDt7pTXAc8q2+o2JspZbCkgcWDTupVTmmp22aT2unRytYLAJNaTPGxgOmzrlLDCYXP YHO5IQlpde6yHujkDA0i4CEMtcJZkB5c1gtulOG/q3THP52vZABqIF/uSwEA0kOaLonyct+0+6pj fL2BupMBKWhv3BUoyKExAuJvdQ3dwUDnBrRc2KCnkNyXbD5QDiB33QlxB2HCuSUBR0log62wQhbR qsT3Us0utZYwrWONgmRSDST/AFHgKgaGBhvwEV90t7iGWJ3Smv8AmyAY6QeaG3sUQF5LDusR+0oe OU8vuL8FAOcRe3dX/TpssUEhxN7ow8vJIKgGhmhUX7FB5vpIJuUImAcNrkpYHxw3YSTf4Q6CXD29 ksSOYSQ79kkVDwT/AFH2CjBl6LXF0trH+b/0oWSulsXC3usjzGtF/ZEAXhrb7JZI3PZUXiQu3KGQ hrbAfutAIPEbLN590I9ZuSqcQGAjcqg5pF9wgGEtZICRdJIdPM90jrN7AIydTeEtzHc9kAQtb0uK tjhuCl88CyDXyrYM8MLWAFQgCx7LCE5AN3ccIRUlwUBkulAfwrc8ONxwsLziDuNjwmMnIZYt/BVY H6rSAb2Ti8XssP8AUk22/dWai4J9lklGUwa5A6/pCvy2gkWtfclYsVQdOyL9WeC1VMUPMgDxbhV5 vO+yxXVAJG1kD6kB2ytkoy3Pc1hsL3CTHIImkub6ihZWkN3CqSdspG1ksURkxk7WWQxwLuFhkkG4 IsoZuOwSzRnl44skh5D7X/dI/Ui42/dU+oF9gpZGZMgDjc8+6FsgZYDdYskziLDa6MPDGAclLKXP KXvAaSLcogeD3S7i9zz7KEBg1A/slgy5ZmyNBOyQS0pOouI3VGQgj2UsGYZNLQlPl8yQG5sOyx5Z 3FwAAt3QXOr4WrBkyPu4WOysvtwNksbNNh+6tou3cpZBmoNG23ujieN91gTPIuGlMpySy990sUZB mBJBFkcUrGg8LBs8lxJ4QGUg7KWQ5ljA5gIVTHSABysaCp9ABICGepI4NwrZAppA1oLilT1Ajh1g 3AWOHun9TzZqj5Y7aCbhLBlRzCVgI2UlkFgL2WLHKGC3AVOcZnbHYd1mymWJwwcKmzmS7vZYUsro 2gltweFYl0xk3tccJuFGZFOXPJJsFZkbI7lcc15EP5QGRzCNJ3VsUch5zYnXusqOp1M1d+yw42eZ EC8XTHmzGgDYdlbLRnuqHMAJWTBWEEEhca1zpLACw+VmRNuLEcLkzSOUiqGObubEqOkDTe9z7LAY /S4C4umOkJcbj91k3RmNmvuFb3kNAG11hsqLA7WVvqb7X3Qg2Z+m3ZKMhc610uomEtgTYrFrnPpW RzsN2jYhAZU1QIpGsJ9R7K/OJ7rB/Tur3NqS+xHZMFW0gstY+6EY0yPJuAS33QSzSObZnPupBO5l NJG5pLeQ6yxaN/lsJeSd1oyZVOwz3EjvWFjzO8kua46kJltMXtNh2WNJd7iSbqgrz7uIPAVxTtcS Bz7pbQN7hCyzL25QGXJWOIF+AjbI5w34Kx2HUwgo6YlxIvsOyzRUVKS52g8Kpn6Iw0H9ropd5Emq eGuaO6hoawEN1dkDrk+wVl502vsgL999lQH+lqALxvtf3SZHVcIOuxA9lksm0CxNwic9rhfsgONb VyvFr2CeweZ39SqQNNyBYoGB7T6eVUBvnGIkE2TWVhZysRzC6+sXRaNTAL2UMGYJw86jsEfnROuB 9ywNR+3sgZ6CQSVAcgXggt7oKa8biZdx7FDFptqvul+Z5jyHfaFaLY+aoZKb+ULewQNmZGQALH2Q SSNY0kbBIJLrFQtnJRSl12HhNLmF253Cwqd4tcmya5zX77n5QplR1hp2ODeSh/XvI5IvysdjTquE 3QACSEA/zwdLe6d5thdw2WLG1rbXG6brJFifws2DIaQSCRsjOgC42SRNYBpt+Ut7h2K0KHaubFKf PoseSqDvSdr2SwNZ32+Fls0OFeZLE7Ae6E1pdJ6SkCE3Pt7Ko49N7jdZsGYXB5uTykyNcx+zrAq4 3/4THevkW+UsARTCMeoXAWSKyOZo0cd1iNIMpaRsrBDZCGizfhWwPlfqsGoWSNGxG6xqh5Y/091T ZtFr7kpYHl2h3pNz7Imlxdc8IGRhvrP9Sc1m35UsFFp57KNdq5S3y2dosra4X+FbAdwCbIRJYWPK prgbm2yjgHD2VNDPNFreyoyAN1XsgFmn4UsHNsUIxjXkjVqRibgJLWgbDhWCDtbdBQ8TD+rYJb5x vbhJDXD7v7qg3zDp90HA9kwDSprsOVjmIxbE3RlwtZQcDRKC3bdDJJrIt2SNRDjbhE3UTcKgaXEN vbdKklu4W2IREuDSSFjSggh3crJB7W+rVex7pjiXWAWM1zgAe6aJXeWXNG4UAYk0uAJ3TJLO3JIW PSsMhLpLgqPf6ygGF4HAVtO9whcWtAKsOFtlQLeLuuCjdq0k33spYXuFHOt2upyAIzdtjyidHtcO tdCSCbBHpLW2KAVpMVhe91I3Pa42TXi4FwoSL/hAX6jyd0Wqw0lCXaz7KuXW9kNImwafdLax87gH GwTDGC691YNtuflAAaVsb7XuEZdptcarcKWte5SfVc+yCi5XuMgc3hK0Pc+6e1t+6u3ZCFAkEBqR JMWSFp5TtJbc90p0eq+ob+6Akcpsd/ndN8x5YHDYpMbQDayY5zXCzTwhAhI48lWd2+pKaSXbcJrX ADdC2Vba3COOzHA8gLGkDzJf+lOZK0WHKCyo4nR1D5CfQUyQB7gW8KOddlif2VNdpFrbK2UGUcWO yNg9IHdU/wBI2F7oYyQ7dUjCjY4O33Ru9IVtFzdC6zjZASRusc2CBo0t2JRlt+/CotWShMJI3FkJ aeU1gAYATulEOcdI2QEI2v3RNIsCeSlyPa06Sd0LyHADdBwPJ2seULXkbA290UcbWxi5uUDWFl/l Ckc0atVt/dRzdTrq3FQOQyyD1kW2KZfaxSnc7ImEWsbkoQXM0yOFktjQ19rXKyi32CAtDW3tugBM YG6F7QHAo2OLgSRt2VAb3KAsgEboBYkgonWcO4VaQBsLoAC2/CxdUjai99lmPY5o24SGztBc1w39 1UAjMACbbpcVQ+pNiNNlbQHPF9wsiVrSAI0YIHaRZJdCDIH90QZ7orgGyAGRok3PZCXam2PCOT0t QuZ/K1X4RAU1xd6QP3Vlrri52CGKZsgsNinA2dbkKgmvayuwPZXYHfhA9+iwVAxo1bJRZocdrpod pbeyokPbtz3WAIcDqGnlE0//AMyEuLSqDtMhcVoDGOL3WItZU5u5ahL9brjZMa3YlUC3C4t2RNZY eygaSVTwb7ICpDcbJLWFjtrg+6eNgfdCDpNzugBcC0bI2VbhG5rxsiADiodJFrKAoN1RtLVZdo/+ EReWt2GyTqLhuqAhMRYW5RSMIbc90v7bEG6NzzI0BT2C4mNawdkRO1gh9IFr7qxvxsqCmuDXb8o9 TXvAClm33UDWB1xuVAWPTNqG9glta50hc51904O0k2SS4bqdAcfWRb/Cp5DD8qoAPVd1h2ROpTAw yufqB7K2DHafUSgkHe+/yjBa8XaNlRb8KiwGuLW+5Kpw3umAAIL3dZQFh23srLdY3PCLTxcKyy/K oYLHtaCLbcXUABa4X2VabFUGhtwT82QiLDrNsETW2FzuhbcjZMaCLi1whRQ073VggccKnMA7qAaQ gI4+wsFZddth/ZUXXFyFW99kBZBG97IS83HdVI2xB5UsLhCchO3cCrBO6Em70d7nbhCg6dTd1TIy XGyZtsEIcWk2QFOdK24Dhp9kAOo7ndE6Qi/ylMI17jdCUM0XPKJoHlu4JHCjiCNv7IA3UfZCFRkh xuLAo7HV2TJLBoFhsk6rusgGEgqg3myq3dENghoilzf4Vki6hOlu6GSuHbKEEtO6l+42VtG4sUNA a2ixCO1/UFZjaRwruA2wQWLDWl9ypIC5wv8Asr0g2RDe6AGUekEKg67flMNiAq8sAGxQWAwah6t0 5obpSjccKCQgcISySgGwCTG1zJPVwmvkBIVm+obbKFI6HznX7D3SnU+mdpBs32CyS8tNmpQcS/4V Ixr5G2OkbJMPrLijcwAlLjc0PIHCFG6gDa6Esjb6g0BKd9xULC4bHhANOzuNlfpBPuhDXEBUwWfc 7oLDDfMBvsh0gi3smEkjZC8EAFAVtf2Cm26q9woeAgJp9lYbuqYbuRucL7oBJcRwN0LWeW4vdvdH YF3CJzC5v4UBizlznXBsifG3y9QAJTCwEi43QvaQ0gA7qmRYZqseD7KnG7wLKWIA7FDIXB21rqpg MDc2O6a27WgJXlvdZ7RsmBj9O4UAQ9JuFZbbfsUsahwoJLmyAMNtvwlPkOrYprQSDdLdBfcG5Q0M hJcSU2xsSUETfLA0lO8za3dALDbhTdvdAJHNcRbZEblAWDcqpWg2Pso0O3PZW8Xt7IBTyCRtuoTZ R4OrjZRoLedwhllHQLF42QySM4G4TahjZoSGhYvl2aB7IQMvdp42PdIkcftTGNcDvuEuVjg+9trr RKIIyQAo9rQbEbqmygyb9kbuS7koQTGwOcbbJzQLFt90uOMOJcDYp7onRwvkAuSNlbBjhup9rK5i BZoS6R/8oeYbvJTJHNJ49SvIBbx6k1ou3bhBHzY8o/tNkAl7XB1ggMTgeVlHZwVGz3WVAiJ9zYop DsbG9lQjAfe+yu7dKABrg7ZWWC1rqxG0G91HkNBJQAaS02DlNOsjexSQ7zCXE2TCQBcXQCHOljlJ /p9llMcXMB4+FTZNQN23+UYeC32QEtcKRt3NzZECLIdhsoA9bSfdA8Bzrg2HsqsDsFYGlxulAogD clOab/bwsZ9y47XHymxtDW3CAKT1+m3CV5ZaLKPJsbHdFE90rbHayoBadBsdkesX90D7atySVbQL hAGzdw25TS4tva1ksWsf6VPNa0WO6lAYSNAJNkl0xvY+pvugLt9t2phZ5rQBslAY3RdtiLeyOpYG tuD6VixRlshb2T6iRrYNBuSpQFwtaXar7BZLJg3UCLD2XGMcYnm3BWUx5eOUoDrl5uTYeyJrL2cs V85HG9lkUztbNRP7KFsa30EkpM7jK4adrK3TjUQltOl1+yCx0LdMRv3VCzSR291NV4yBfZS3oBKj KRhA35RtA1nbZL1aGnsOytst22A3VKW+4FxwqNi5rhypM4xgbKNaS0O4QDHM2J7oATYkndGd2/8A lKIs697KUQYCdFrb+6CQANA7q9e1lCTp3bcqAW0mxB39lkRsAbd3Kx3SWb9tj7oxI4sBJsFSjHGw JQtm1Czgha/Xe3ZLY8vkuRslAfww2QQkkohuiaLWIG/dKAoio83Ux9meyOQ3jOr7k2YaACdkMeic E82RARSPDiR/Uibr/UHzDYdkyOONj9QF7IZ/VJqaP2VAx4s0EHdTVsELr6QowEWJSwXq1GxV6Wt4 QgguIRMaRdRghA1bKEi57Kg61yVNIIJJ3UBXfbdS97qMGyq/OyoI1gBudwqOnVs1G2xvdWWttcIA DbkcoNy7c3KtxN7AKEXdc9lQQRHlWWbhG03Cpx0kDujArSWv+ENQ03HsshjgHFDo1lwugApzqYW3 KK4BsTdFHAIWk3ufdKabl1wgD2PAULuxUbpIQyiwDhugKLRY34QmGPRcCzuysk6b9lQJc8HgIQBs Lgbq/LDjYj1BMkLiRp/wqiOk3tcoKGxNLRYozIGXAO6G7iboBHqBcf8AKFOGrYpZKnXa4BT2i7hb Zcg6RjIS0AElYsMThLqcNj2WrvggcMhawp+uw33ugdCC64BaER7DkrNAsMHJ3QyEtOyve6s3J4uh S26hFqJt8FW2Qubwhe3ixUadJAI3QAzxEaTe5KKJjWu35Udu65QXtJ8IBsjheyUyUWdc7hEW6ifd Yxa4E+6AyGv1RG4sULAdIPsVbHAM3G6F5c0W4BQGTPV2iGlm/uEqCQvbqcN0TSGM3F1jS1XltuB3 QGSXXvdLF7lMik81oNhuOETmaOEADNV9+ExzLBCHe25REnQCUBdm6NzYIJpAWhrfV8q3nWwgDZY0 L3h5DSNvdZoDbFzLlELWVkOdyh0XvutAI8jgKOcQNIS9wbdlYeBc3ugCOsDc7eyJpdYHuhY0uBPZ UXk8bKgtzvVp7lTZg033VP4B7+6Dy7t1OO91AXu0na6dE0FhcTY+yU97mgBv7qns9OrzLIBj5HMO 59JS9ej1tHqUJa+K5PCS17nv9Iu33QGUdUtnud+wQlulwde6KPS1vNyUpzwwm5uEA179ThbZDI8N eO6WJmuvcG3YqtYLQTuTwgHANcdVwmNe0m99SwwywN7gJjB5cZLdygMoOafhLkcIxe/P91iOkkb6 uydAfPd6huN0JYxzjtdC4hx35CN8Z1oHENNjsShS2uLn24bZFGxsjyGu3PZJDi64HCga6J4fGeFK BJg6F5DuUMIMry29j7pD5JJJXF5N1BI6M3GyqRDOYzyjdztVliVEzzININinmaNlIZNWp/slUlWJ 2Xc2w+VaIVJTjyw8El3siYbNFhZNda32oBIC7SRZQoZddouUkRlwJvsikeBcc2S3Ou0W2HdCcBhu lnF0TdRAtskukcGABUJXgcqkNnLsUZK1oZvc8r6vD4WthY69rgL43LuWquvALWEBtiLhfcCoiw2n ZHKP5g2K/kFUf0eLMl9omF17hde59xpkFPLpdY2tyvoMXzC3yyAdLV011Dx0TXhiJueXLthW+aMZ JcHnTqgf1eLyzAe+6+boWaKRgvve6+pzrCagyW5vyvj6SSeCRokF2Ar99pUljPzGpf3ORcf1N2tN 7Lh62MscbjhcxCC2Rz27By4/FAXNcO/uvfF0zwz5Rwxk0P1AbrJjkLm3PJWLM2wG6dG8eV8+y9J5 TBroi3U6/KwDbtysyu1uY7suOa7Tcnddkc2OD9DTtynRvkcALfgJEbwRxdZBm273C0QcWkH1u3Km gxtNjq+UuBvmAl7v7rJZu2w4CjLQoEgcWuibJsQilbsFTW7rJSmWtbujDCL2KMMa74IU23uUKRsr mtF9yE0ua6zuD7JD5hcCyrVqdvwgGQ+qW/ZZBBIJHCTTsJJKyHtcxnGyAQ9pDRbYoLuJ3Oyt8ovZ VqvshCy8NKHzPNa6ws4JxaCf2SvTC86RclCUC2VzAAeVcuosJ5JR+Tr9XCsSbaShSoXiMNvuU91Q C0m+yxH/AH7pb7mwahTNLw2MkWN0syNcRZJiBaSb7fKu2mxPugGl5a/ZCXuBuNlbHNLieAieW7IQ XdzjuUDpiBayli4nTwlSNdayChrKi4PwgildM4tLiGpQbpAujMTgLtNgeyEoZ5TATp7JsRJAA5WI 1rmbl37JzJ3NYdt/hCDp5LHfdYznnkcKRuNQ432V+YGO02uhaGNJ2N7lFLICB2QEgNvfdAdUwHuF bLRHvIcACd0wSuYCAbX5QCMh2/KqQ6Slig2zl1xayoShoVMZtt3QSRbgBQlBNlLrjVYqmExyEHf5 VCNodc8q3G7v/KEHRVoJLbWI7pxqRI2zPu7rD0Mv8oh6D6UBmte0NsRulyFx2HClORIbnsnSsYSL K2BD9m7coGkFm4sVbwDexSy6wsR+6WVhtJkFr2ARlxO3KxWutdMZJYcbKEJqcTYKnWN1eq3CAtOr UgBHruqYNIcXKa9IPujDTLET3QC3b2J7J97tG4SWg8EJpbsFbBYCAx67g7Aq97cpbybaQoBjG6WK xJqANkLZCBZystBG6AHdwJCqNoeNwjJa1o3sgeLW08eyFQeltkDmAjlFrGke6htYILFhh1FQg2It sm3bZTSD3QCLkWHZGR8XRvAQlpIuN1UQB7Rt7o9Y0gIL6uVXZQDdvuAuVHuuwE/2VNcQ3blU3e+t VAG+kbqn3IBAVyaTuSo0AjY7KASHEO900Da5RlgLAQN0ccZNroBT5PLi1EcqBxc2zfymzQ69gdmp NrX7IBTmudb3RNDmkgFGGj0i6MwanX9kBjh7w+x4UkbustzWgcXJWM+MgE/90sAMNibjhNN3gWP7 JGhxYSjpyL/Ktk9lT3LdA2CSYg1o5JCy5QGm/KAQvLS+yWGYocXGxumh7WROBO6JkYsXd0FmlxFr H5UCMfzppHNbp9Punys3aByjYRZVILkG+6FBkBAA7JIF3DfhZTrCMk8rHiAJJPdAcpFIDGGhNAuL 8LBgdp2CeC5xseEA4ueZNth7rLgeNQDiscWk9IO6OP0uI5UZV2ZDh/MLmjYJokL234SWziMWANym +aC0advdZo3YLyBYDlFyLlAWAm5KYSGgbq0QS/ckpfmF7TG/dva6e+zhcJGkWJVoCxBo+1xDfgov Jbocb7qMaCCCrkYGC990oywIcRmZG6Gw0fhYwktqFrlBE90lToIsDtdPnYKeTTsXFUhi63k+o2AK fqFh3SSbut3TLW7ICibg9vhAdPYbonccKNA07oVAkENNjuhi1MJNyrddp+FGuN/hDQYkuflIka5z tV0Yb6rhUW3J32UogQcLA3SnB0nCsAE2HKcxhA4QlgC7GgHdU+UhtuyuVpIO9kh8bg3lUo+N1wNu UZBvcGyxmSWACaH6oyQUFlu3tdUSAbBUx+ph91CAG6u6GS/tBJH7Kramk2sow3FyoCXu2FmoAWtM Z2N7qFxJBtsjBBcQOVQaQRdCsZZrxYrHMe5AKdqu51kEbdRLuCpRBkR12A7crJYRpLQN0EJawXtu gdKRKbJRbMqMHcE2R6i02cFixzXuXHYKU85mlOrjsozRyOrW3jYIWi779kDHFpLbiyOQgMtexKwV BSFpdsbJenUTumN8sMF+UDnaTxcIUuN2hxFrlMIBb7FLY9o9QCpz9Trd1AG0gA3VvsGXHKBl9Rvu pK4WsdlkFh4A91HSWaOyWy3YFR4vtbhAQfft3TmM1tIB3ssYODWf9QRtksNQ+5UFTbANtuPdKAc5 w2uilcXG5G6pk2iw7qgc86Gj/sidUAgW2QuYZGg/5SgdTi0BSgNZJexO5WSwskFht8rFYwteAQsk izSWiygFOP6eSw3CayUSHjZEGBzQXDdFps0Bo3CF5Bt+yq226XNIW2PdCJyTYblUDSDsmNHHcpUL vNuDa49024aRur0QqVx2HCWGm4LTayTUSulfsbWVxk2sSqBsjDrDuxQv3/CYJACLi4S5XanfCwAW i/bb3S6upFIy7WlxPsnxANvdDL6nWsCFbAFPI6aLU4kX7FMfHqA7qREEkEccBE117giygJ5QsCTu q3Za1lerblVqugKLy557BVJtb3ROaS3ZC0bWdyhbCbHrBvyib6drIGO8s2TBKHX2QFX9WkBKeHNd a9kxrmh1yd0JHmyDsAqiAD0kppedI7lDKzQexVN33UAbifL4u5C0EjcbpjXWb7obiytgoNu66jnW OwuVf9WyrcSX5+EKi2kG9xYoXO3sjceULWhx+VDRbQSLoS03+E1wDOyG4bckICRgMJ357qrgybKp XgR7IYXamfKtGWMfYb9ljPluTp4RTuIaQsYu02Ddr8pRB0ZIF7XujsBvZW0XA90RYSRZQEa4WsOU JB2BRiMRO3V21FAW5h0ADcJflCxTRz8KnbDZAWxpDfwqcQrDtuELWh245QBN3bf2QuFnalA1zTvw pMzU0WO172VsFNcWO3Vl4J2CJ5Dm7DdLY4MuDyoAjdv5VF12/KJpFrlCSDxsEBC/hE4uG43QaQXA EpweI7AbhAK8rUA8jdG1oI4Rh4dtwEew2HCADWANP9lTrt35SXvs6/ZESXAH+koCnu1ORO24U0gE W3QPJ1ewQEcf3umNBj3vf4SwRq2VuNze6AcZyBsLjuoTqG6XG7ZW7YXurQC4bbt7IXkWAQsfc8qn EuNlAW5xsALFDG8Md6lHC1vdVp1bkXsgLnubEbApPliSXhOc8Os07BDdrHmx5VAIa2LjhWJAXekK 3xXF7oGxloNuVQEXG6uxJ35QC4O5TNNt7qMC5CXnjZE2MO2J57Iibt2slSx6mh19x7IgAaZodcbI 3NAtZCxx3BCI7rQCFu6W9l3XvsEWqyXISWqAdrJAA3CKM6m7C6xw6zQEyOQNBHCUAZ22F0toJ2ts re/zR6Xce6ovcxuxBVAwEA7BENzylCQ24VCTfmyAaQb7GyId0sEuNwd0TSQ06kJYpztyo1pJF1QZ 6ieyYxtzc8BCh2ANkD3WfYJjgN/f2SmkAG/HusE9jAwkbnb2VFjfZXG4n8I2uaCQeVUUx3jTwqJA NxumTDVc8XSomEOsqAXkyOuAmQvttuifAdVr2QCN0ZNt1QOkeCBblLj9D9xyrZckoXv1E2FiO6AZ K7TsO6HhlzyqjeC3dFG3U8lx2UANM0vJDthymeeXgxE+kcJ3lBwuNgkv2dxulAUxvlk+yLVv8KO4 ACoHbdKBewIdyllxdMfTYe6JxtwNlWr+xVBDIW7KvNuebqXsVBvfYIGRji53Cp3pcfdG43AsppAb c/d2QFBpDd9kbHEi10Dg54uTsEpr/XYBANLfUj06RdC51lTiTvyhLCIBFyh0gO2RMOs2OyuQBo3N kKVZpHCU51tgLBFqsAQLoXPDvygZG7m6u1j+VTSb7qyf7oPRRicSCDsj/pPwgcXtIsLhGX6mexQi YlztlA7TawG6poJaQWoo2gb2QrCLd73sr0DYqnP34VarG1uUMhvfba1whIROHygaLHfcIAhdp+Ff G6nA90PIQFX1Gw5VNfckE7/KI+nhLMRc/VeyrA/Rq5VO9CsuNhZKkcXOCgGByu1whtYBEgKBsrBs Pyq3uoXG1rIWyje1hyiaLtN0NhcKw6zvgoQqI3uERaLfKoM0vuOEJJL+ELRHtuGho3RuJe1rR27q gNiqaSwXGyAvcA35CjXXsrdGX+q+3sEAQo0G+3JStIgJeRe/ZEHEmyNwBFiECMd13P1AWajY3kIw BpIHARs33sgBtZvO6hFx7Ky0JEmzudkMjHTGPZT7hvwVQPpsLE/KgBJ3NkNIu+nbso7lW5vzsq07 oAogACSELxr1EbBWb22UvZtid/hZoC2tIFgUdio0bK3bBKJZHBoZq5KKOQPaLhCywb6t/hGXgjYK gVOGuNwLWWI4DzDbgrOc5rtrLHkiAItwohRGMfGAAbhE6ch1jwjjeQLEXQyM52WiULfTlztQfb49 0QawM/6lTL2NwgBBegGRvFjdFsNwbpR5srDdIQDPMcDxsiHqdcpbHEtROJAAuhoY942QuFwbKhEb jdG5ugjdAAwuA35RFwKF1i7lXYbXCAskbC6pxHCjhuFWnUb2QDoZGRDTYG/ukTMaXEt7oS3Ud+UQ Z6SboKFiNzRcqObbkKPJUAc4WctGQfKhIJ4PwgZFe4G4RBobt3RtOnb/AChmhc1MCzY2PsibtEA4 7AWTDGLc3KS5lge6EMJkN5SRxdNkjDhsbFMDDGwvOwS5JA6O4V5BGN2uVZcDuhicS3dW4gi3CAge Txup5oaRdLabX3S5PS4d1oD36X7DhJLQ02B2CJptuQhDg4kIAtQI2Nyo46m2IuFAAAqJQAkD/bso W69hsiB2UOwugBiJaCD2REXuPdUCHjhWLIAvsba11NTQNwpbve4U9JQFNbq34CaZGRjcgpRZqcBe wVuha7jsgL84O9Lmj9kYsBYHZY2gtcL8JrfSboCEbcJ0cJfGHWSQ6x9Vkf6h0Ive7fZAVs6TSRb5 VkMY8DlQ1Eb2k2sVjEkuuLlAZkjWACyxpG3PwmTVILWtA390sybgcoCBuk87JsJ0yC/2rGeX6rgb J8brNuUA6QHzdQ4WPIdTjfsqLnueLH9lkPEbW3/qQGM1mo7oi8RsICZ5jH7W0/KSQ1210At4e0bd 05spjYAgcSDbsoXtHIuEoDrHSHHhM8xjmXbuUlkxkj8tzC1vuUTKdsLQ0O3KjBfmufxwo2YgWcFm wUGoAAi5WdUYMyWlFnBrgsGkcO+IuaDe4QPJAAaVlzReQwNvcpcjRpbp3KoKaRIBr5VPms23ASpb 2F+QhI1bFCWZP6kRsa37iUx7RKy7dj7LjPXC6/ZZsMhkbcmyEGNcxjSHc9kAlBdZzrNS6yFrmB4d eywPNkY4XF237oWzlLsn9LTdXJF5bNA3Q0/lsc14PPZZDy0uJJH4QpiQxOLvgJr26eB/hFE4aSBz dOa4Bri4XuEKY7f8JArL1bWs+3uhdObOb/lJp9McpJ5QlmZjkrxURWHotuB3TqQMjgtwXe6pzhOA Tvb3Vt0+yAqR/luu3cIfv43Uma24JdYeyKGIOcNPCjKMZG4DcpchINgsjU2MEX/CxKhzmkEEWUAx jtrEbJglFgEsOuAefdKZINRJ2QDy8OLglMYdXqdsjLLtu3uoGFrN0AVtjY7Kr2HCLybxk3tZDE8O YQPuCADVq52sj1N2CCXZpFrXQCO1iTZVgcQALpUktwLBWXX3bv8ACG7TybJQLbJsDbdFLZwD+/sg +4CyY9wawqgASDVZEz7rJLWElMuR+UAyUni6T2Rv9Tb8JYJugDuAFfI3Szu5TzCLBAE61rdkFrXs jMhtYhIDnGSx4QDWODAb8qog57zvt7q2Mu8dwicBH9m5ugHEEMIvukiUNbY73TL6oisdu4I73QAl 2/CcXElthdJcLDm6fCdLLkfhCBzG7RYJYeA4ahZR5fqvfZATqPq5QoZJJ+FThoO5Vk3sAhe090Ab zpsW7qngmzu6EOIJseVC59rEiyAgeXXuL2CFg1G9lC4sFhuCoHiMWPdCDwLu+CsWWUQPIcNinkW0 kOsPZLdCZ7k7WVAkT2dZMDXOG5SNbWyaSsuBheCP8pQBbqc4tPdKfHpcQTqHsslx9QA5+FKmncGB w2JUKVAGtta9j7rJuDe4WFHMQC0gflXFMXONztZUEcHMLnNShVSONijeHkEtNwlNYW8oDMjqCYiA P7rG02cSBYomO0Ot2RON1CF6iSBfZFb/AKuUlpOq9rhGHGZxaW6RxdUIk5EQGklxRuaGwB+n1FL1 CmD2GxHYrHp5ZHPcwvuw9laBktf5jAAbAIb7Ef5UJDTYdkLtRI9koWFqLBq5AVgmcam7D2UcfRpG 4S2Slg0gbFQljmuaXbb2QzNZIRdJewxOuDcHlLkc5vqbwSlFse+RjAGONkMUhaTp+1Y5cHOBduUw AgGy1RLGlpcb3sOyVLa4F7lEXB4HwqBBde2/upQ4HCSzAwixUEhIDSLW7pBL3OueQiiJcdJPCULM hxvHbV+6E3Y4AbhKlPoIBsQUDJS1u7lKIPc+/A2UbP5cgtsEqOfR6SLg/CFn8x5/2hWgZ8b9Z1ar 3WNVSj+nlDra1pDTp+FjPkANtW57pRbMqKW4Assktc1oB4K46OQg2TTOb2ulECmDvMNghI1jfZWJ HF3/AJVSSmMX7IBLxsW3TKcFlhyEDpGn7uUTJG8AgFUGSJHF9uAqLwJblU2RrG+5SHODyTZSgXLJ rlNlcdQWkxOYTfulkEAHushk92aLC6oI+OxAuq0IHy+W655RCcEb8oDcTlyKGmpyxoAPuQhxfAaT Emlxdpl9+xXMihhji1MH9lwVXjcNJViJ/od7Huv41u4P6TR19mbK1ZC13lxF7RwQums05cxuCodI ylL4jybbhes46+Cr0sBFlK/BaKsjs+FpJ2vZenFLY7RxyQcjXDnhrqWSQPYWO5sdl8HTTtqQb7EF ej/FvkyLKuY6R8UQbFUx6thsvNtFAfOkLPtuv22gm5wTPzWqi4z5OWi/5exXG4q4abA2K5OP0wuv yuHrmF25X1l2eGXCOJfd5TacC5KWG3JTYiGg3NyvWeQTVsa7YlcW+n9RA4XMVBYN3LAqCA8W4XVM 5sXBFo3V+kvsRv2UJN7g7Kg8OcARc+60QyomAgjhFo8s2BS4phGbEbe6uQ3AcOFls2HcnlU4gduF THalHXN9v7oAdRJBumAa3ewSyCE2MjkoBZI80qAG6yNLZNwlPBv+FAZEcjo2AG26t85A0k3WH5hD hq4CO7nnVbZUDA0Odvyo/wBJ42S9ThuNiiJLhb3QGRHIHCyt0Tb37rGEZaLgqMn9VuSgMhzXhu3Z K073/uidMdW3B7IdVysgW9+q9ghAAB3TLAA90sAONwf2SwHbZQbusSoNhuqcwluoLQGWAugabkjn 4VNeXAAchTSb/KAKF1n202urlicXHbb3QkukFibH3RiR1gL8coBIYe6jtbXCw9PymvfZwFkvzCSb i6AC2p10YeLkcK3Fp4FkNha/JQFN9J2CvRZxdyoFfa3YoBYOt1kdr2AuFRaI3DTyUxtwSoBjW253 QOYCd+EUbiTuqk2KoBMgJs3hWXaT7oW7XshcSNggCcA1wJ4KtwAGypo1nfeyJxJ54QgprLG5R6bm 4UtZWzc2QUNY/SOEE8up1wVRGk2vv7JV2h/ygoIepWTYe6jb2JtZE1pI24QlCQA5QG2ya5tn7BYz mkkkHug6GtF3WH+Ue90sEsaCUTHH3QgToe/dYpMsTztYLJMtjtyFDJq5CAEWey59JVg7AcoBd0m3 CM+koC7kfhTUDwLoXO+UIPpJuhbK8wElCZSQQluI590bfSzZt0IVGywDpHWB4WQdLSLbhKczz4mt ILSFbPRsdghRjtNj2S3dt1bg1xVubsEIAA4OsdkxrT/ZRws0E7qX9PNkBTmm1yha634R8hCWgC5Q CzcO+CrHKoG7rWRt3G6AjVYHqIVAepW3uUAt4AJBQtAv8Imxi7id1QHdAOZxtwhkcQdjwq1OaLdk tkhLy0b/ACgI2YvBN0ReC21kAZoO3CligDHItunatI91TGBkdyUvX6jcoC3SavhBa92ndGLO/Huq cBtbsgK8prWEA3VRxBosOVYFnE32KZIAG+ki6AW6Mer44QiWRwt2VAkc7lXqLeyEZHO0ss5Jc0PF xyjLNT7vOyo+h22490CQoNsbK5W2AITBDZxd2VGEuYSChRb3ny9t1UTQbakV9Mem26sNa2MkusfZ aoDI3gk7iwWQ2UONm7riaOFpncfUDdcm1gY7Y7rIH05BcfeydTSfzS0i4WK30d91cbneZ6UByjgL A25VhoZt7rFbM7U0conTuDieUNhPeGu5urJ1i/sgZLHpc5wsUTS1wuDYIRglzhYKeaB6T7oKp9nA NQNiP3FAh7ml3BSY2STSkOF2hRrnXuOUqZ7tGppLT3UFGQIYWPJe5oKxZoWio16tV+6tkEUkZ1kl 3ug0kgNvwqRke0NN+Spd1h3Vk9j/AHU1A90IA4ki1rKAaRY8qw5rRud1jio82oLRvZAZLnsAAKAu Y7ZqW7+Y432sjhgFiQULZY+023SmSta4gprm6GOWHE0yyXG4BQWZcenVqTWSb7cJDrt2Ish1HshQ 53WO/CS5wBFtwmVEkekM5cVTAGxiw2QjFki/GxRsGlhF90N9z7KXDUIWNjZR5JFuyoMubhRzg3nd AU1pYNjcK4Zix+42QNduUT3bjsgK1XmuDZGy7n2LtkBsClkOZKDyEBkNJjeT2QEukfdiKSxG26S2 YwPPsgMqIkcomyNaSSLrHbOHNs3cpjLvBGzSgJHJqk0kbErKnOqRjYxpHwsEPIPHB5WbSAveC7gq MqHOcI3Bovcp7RqaCeyTKG+aOwVRTWeQTssM2h8zA4XarbKBHYjdU1zb82Vua0C5KhQA7SeN0dO3 XIS7ZC5urvsg0O3sUBkygMkHf8Jb/UfdFAQyM693dkBvffYFSgHGNI4Vl4BIQB1h8K2sa/c7pQFN jLXXUcCDcBZIbvYEJboxxq9SUAJZP1AaGstbuhmDI2Akb+yyADTNvZJmHnAPcqBLahzhYbNWREAw X7qixpbsLKmMte6jA8eqxT2XDbWWK02sE11Q3RYHdSgPkO4/7BL8w6gBslxuBBdqS3yuubD91C2S e7nH2Uhs12oqgSHEu3urNiPhVEGOqBe4bYpet0l7nZAHhjtxcI2kAH2PsgEsYQXBvdOjj8v7zdA5 2nZpsFesuFuVQWX+pwRt+2x5Q2BZe9ip7X3WQG1ukG5QF1yoTtsox3sEAQBBuiDiFQkLvhE4ei4Q FPIY26jQNN0BBsNaO/oIQF8DlLdufyiadP7qA7k2QoIbv8pxYGsuhYbuu7ZXIS1u26CjHe4POyOB 1g7V2VBtyi/KqIE8gt1HcJRkA27FELFpHCU9txdKAwSeW07co2EOAtulACwBT4GsZsSLlKBGi5Jt ayHVzZSQubKR/T8KuONkNkA91HbjkKybtseUpwsQPdQzZkuqGmIAjcKrh44WM+UNdblMBFwb/wBl S2DM27bIadxadJTXtHN0Ejg0C1rqmRjnC5aRcLDeLOsi85zZNPurA0G53ugGRhxdzwmtlBNhylRy X42RBuhxN9ylALdzzc7K4iXOIslhpa7UXXHsntexou1Rgsix+VPusLJT5iLlSKo1uNxwEoBuOn8h C2cPeABZI84OcXfPCpx8qQEFQGX9wN+VQN9kFw0X5uowi9+ArQGAhqSbOddW6QMsHclX5Vm6koFX RA7XIsVV9xsiIuFACeUN7C5Vlu6rlp7oBUlUA4DlNE3puFjCJpcTb+6a0G4WqAVw8EHuo2o0M8st P5soWi49wisBve91AW31cbXVOO+km/yrfK1oFuVTiy2oHdWgXH6TblEB6jc7JMctzuE0N1O+SgCI FuVT2k6d1JmGG2rurLgBfugBe1zCHBXpdLZ3FuyUZjqsRsjikPmWvYKWBhYXJMm2w2WS42dsQUgt AduoASAQB390YY3SA7lKdqDvhR4c8tPstIEkku+1iLKwLjlVIQ91xyFbWk7pYE6v51rG3unObYh1 9gqji/mEn/KKSnde99kAIddx9io5nsVGxkHc3VEgmwQFk6bHkFU+2nUNwoAHbdlZYB6eyAC403B3 QF19k0MHugALH3tcKgKEB3Ismny2jcXuhDw5uwsqNr7hAAIW3u07ICwAnv8ACaB7FU+IOcHB1rIK IwWG4uFHMa7sr1jYd0zUBbZAIjbpN/8ACqQ/2RSj1kg2HwhY5pO/KEopsgdZo5TGjSSCqBYH8BHc A3KFBLgdhygJuNKOTZtxyUqNh1erlAZEQDG7/wBwqdpLrjdDqJ4QG91AMfUtZcEXROeLNIFr7pD4 23uUDnl3B2CAzPM1tJNktx+Vj6yBfur1Em6oGhul3PKrTZ2211A7b5VNvq5QC5HWPsmMf6B7/Ckj bhAwFwPYoDNjeQz4KTUci3dXA4+WbndLJ1HdAQN078qrG3CNC42vblAUCO6AXLyOyNsdxcndGGht 7ndCIQ7Yo4rEG6j2f5SZGESNs7jshR72em7UvS42JCJtx3QvvdAVqJuOwRNYNjZAQbbn9kRcQQRw hGERuUQ4CFxJU7IEKm1G+nZWx5cA125R33t3QO/lvtshC7FoS9J59k3zLlBfUboCb2uUxxBZbulO LjYdlYDQTc7ogMLwAAhMl+RsqLUBCMGS0h7eP3QuYQ091I3EtsdkmWbS4gHdC2GASOFGtd3UZKSL WUe644VRCjuebq2ghRoO2yK9uUQKPZRF24Qf07iyoLbc3uqHJ7pkDQL77JYuHnTYLJQghI5NkwAF VpsgoW542HCtpNt1JWawABZW5gFt0FEBsFZ9+UPpJ25V3N+EoUWdkJ2O6Iqr7FCUFcCxChcHHYbJ bH32KgcSCLoAxZospueUsO33CZrDigLAFzuhLdO4Kp7gDcKNN9+yFRASFeshvq5UCFx1bIUPYb3u mXFvTwscmwAsnhwDQ7gFAUTeySG3fc7hOsCN1ThdAKcLO52Vk72VuZsFWkAX7oQm47omnUd9lA8b XS3B2u42CEQ29yWjYqmMte5Q2u6/dERflQ0C8HsbBEy55VKxax7JyKCLNBv7oNVyqEpuFD6he6oD DxcC2/upIw3FzdDHYgk7EKF7nA7cIAXnSRurbIXP34UEept3c+6r7TYIC3NvexsErS0bjkJly0WK EbE2QjKA1G6N7SAqDbC52VgkjlCEbqaDshM1hoLNz3RlxVENfyP3Q0AC9m4Gyhq3AXMZI+FkBw02 22UiaHhzQNihLFNk814IFgnm1vlVGGwxuNuDZCahslgNkFlucG7nlD+oaChduQCrdTtuCDshSnOD 1TfQ7cq9OkXugeRqQnJDcn3VhwaLFRnPwpOBpWiCnbv23CgsHb7hDw0AbImN1FAW9234RRkOCjoi d/8ACFri02shmwJwZWFo2WOIDEz3WaSLW7pTr7qkEuFmhKc43s7ZZjWN0XdykVbWuj25UAhxBGxU MeoBXBGA0Dus1lPpi1EbLYMF1xt2UYBusiZgDLkbdlhsd6igG9kN+x4Vb3Vi7ed1aBLg7BXZC1oB 3KhI1cqAK1jZUrAKprt0BYBvvwrsFV990ov3KEHEAjbkIC94NhsqEllfmAOuRcq0UF0z3Czm2srE lxY8ozIxw4SyLoCWDmnf1IQS3k3TGBvqVFo03UJQsEtJuNkxocWAjhCdxY8IoydJF9loIOUReUAP vVMPpA7+6AjvyUIcRslFHggj5QNaQ7d2yXrJO6Z5gJ42WQPcGtNwblKvaS53CQ55tcI2H0+rlWgV M8PdYGwVAWHN1LAm4RsDQQVaAGq/IVuPCuV+pwDW2V2sN/7oBj53yMEZsGjuEZjBsdV7BIBsfhGx 41WvcLLA6OtMTdZdwdk9uLyPabmw7BYEzIy0Ag+6oN1NJB2ClIo2pr3Sm/BCqOpvpb3KxDqc7YI3 2bYjYpQMx4OqxVO7Edktk5c0axb5U84E8GyUQtzbndRoAHKheQ3dBqG4KoGuNm6b3CW4tY0uLbqm t9fwjLgQRa4UIDq8xoPAS3F2vZxCMu07A2QFtzq9koo6neWHdyy3vbIwAGxHKwmO2uWomA7uB2Sh YDTaQkoPNZ5pLmkK3ggEg7pJLiwBw78pQOQp5Dc9gVkAsaNzusOC5AuVJQA++9ypQDmJe6/ZXDLp ba5uqtZvO6x3agT2UBlySlouSsf9RfULXCsXeyzlAwtaALJRbHUT7Ndc/FkbIRJqLjssXWWHZG6c j8fCULM9rmNi54VCZrgL7lcc+rIiLQLfKU2fRYX3ShZyk04Y0i+yxfNc0ggWQNHmWuSmPiJYLncJ QsYJRO8Byt7gJfLBWK2XQbixKMB3mFx5VogRJaTvsCia9jiARb5QNeHAoHOAGlAZkTG2LgblLeS4 HskRuc0egoHPe8HtblQtmWDZgsoDva6TG/ZoTG2c/TwhbCJLhtayB7Rp53TAQLgdljGTy5SbX+EI w4T5jrEWIU0+txPZX+uiLhcaCsghkgDmuBHwqLFNaXi53UcLu+E5zQ2PY7ELHDtyApQsJw2ABsoq BIO6rXdC2GTYAWQPBCouP7qi8k2VFiw2zr8rNAAbcbj2WHwflO80aOdx2SiASylx0tFlZtGAeUOo ar23UF3O9VrdkKFrEg1N7FW5+sgd1Vg1pDdlRuAoAZHWIsVHOJI354QuGofKoDU4AIZGBr2ONx+6 CQXZcblZV9MZLlhEucHdlUA/1I07jcKoZ3Ofd2zEh7TdRpsAAtAyTTsZUNlPqYU+WZjHAR7LBe8+ WBfhWz7Q4m5QDpnhrg8O3VSVEjx6nXaEuRvpO97pPAI3IQDDJq4Nrp0bGmPblYzWi1gLrJZ6G2JQ DGv0MQag4koSDpsqGwtZAEOFNZYCENiN7oXanKUAy4mx4Rl12bGyUASFewNilFKkLXWHwpEyzLjl A4t1d1YcT+3ZUgZaQLoTqLt72UkffTZQPOqx4QEbViHbTsiZUseeLJZDXE3GyhYwNNuUA9gYJPVv dKqiTIGAbBVFJY+rlG52oailAAxaNy211WvT+FbpnSMAO3sh/wAqgpm13eyUJjJNsNkwiwI90AHl uuAqRjDKAeEMcjXB7ibH4VHf90PlhotZCWMbd7S66krgWAAKNuAWgbKri1rbpRbLufSOD8qRu0uN +Sq3cQpYBxvylFIW7E2sUAj1HnhGSSgDtD91QGBp7XQSPDXhE+VrSUss1DWRwgMhhu26XO8us3lU H6AT7oRu8HkKEsN8IlcwF1vdXVU7YHAteHA+yp2/Auh8vV+FTIcYBaSHXVxkWsefdWAI47DulNfp J1cDuoWzJbKG+kjdKlDqd4cOSjpHtmcXWu0cFYs9UXzm/A7JRbGOm89w1DdZQYwDci640VQDtxZZ Gt7t1SWbuKMxSwjT6rjlfEZ7wF1fJHUxktki7DusXLmb/wBPGxskn919HU4vDWxAgg3X8YUa5P6Z 2de0mJTUko1ahb3X2mEY42pa2NxGrndYNfT0c0bi6NrXf7guEeGwPHly6SO910Rlujr7xrUcNXky mq/LDpYL2f7BeHsIcP0Zc31OLt17S8SuKDEOnlRTX814bYLxXhcbsPgcZtt9gv13+Lf+t8+z4Ou5 dnJR2eTc/suPxuO8V2bDus+nlZOC5g5WFiRa4aSLbL9FHs+JLlHAj0hMgbfc8KSQ9uybBHpbpuvT fB5SpmMeLEbLjZ4rOOnhclJZrT3WBUusDp3K6IyzCJLCb3/COOT2HKay7m+sbqiwAgjYLqYGWuAQ 1Qu1Cw2QsfZ3wETi1x22KyaQBPcXCfEdQBJulMjLX2O909jA0n2QoT2WO5CQT/Mt2CayF1W70mwC a2EXPpuQgAguSTwETrvB2srIDATwg1XG26iBGxjQdQ3Qai34AWQGhwF0uUBvCWCmEvajDLBLZ6zY bIjqAslgIguIAQOia1+3KuN1jYo2sBN3LIA0m5J2CWdQI/7rI8v07m4vwhMBePTyCgBkOkAgIALu 3Fkxx2sRYqNaCbnsgKk0ub6QgLyAG3VyPFjbb8pLHl2xH7rXIG6tPCLVe6Tu42TRZo9RVBd2k2KE SNFwDuqda/pF0uJhJcDsgDMgO55Uadr2UDAOeyscH2QFN3CING5PKlg3hXve3ugAaXX+FHOB+ETQ QSVRO9zwgI0CxO5PZQSkAEogGncFLkadvZAM88O7WUF+TwlhvqCZ3QFgAjblAQQDcom7AoXjXtdA BHqBIHBTQXaDdSIENuoH6za1kAbbW5uoXAHYWSnPDQVRddoIQB2N7ndB5Z1XHKbE1ztyitYlAKJI TGkkWS7AE35RcN9kBTmu1GxQMiLuOSqcXg7DZBFUOheXadW/CGbGyFrHBjj6kppLTtwilcypIeWl pCEWB3QowR6t+PlWI7d7oSS/0jYICTHsL2QnA2++yj+flJBcPX2KY4PEt7ej3QhRvfZU9pLLqF1y jG5QCC24sjjeWbJ5jDgL2S3NDwWt2KAt7SXj1K3sDtgsdjvLuHG5901p9JtygCFgLIS+/A3Q7i6s usAgKkeTa4so46bX4RlhdZ1tk4hkrLDkIBF7bjhR3q52V6C02uia03F+AgFaTfY2VhrkZ9IJIski 7jsdkAxtwTdWNyRwqa4jndTVdvsgKLdPdC4EWsjA1Nuob7IBRuo2zXX90T9nIWi/ayoKA9Rd2Ud6 uFb2m2yjSBsFAWXamhpO6pzQ02sfyo37zfb8q3X1fCAjRpFuymwI3VknYWuEpxAdsgGn07e6C4Ld IU+4XRNFu1kALWDbfdGRc+6oAauVeoN35QFOi1G5N7KOc1zSGtuQo2RryeyU95jfZnCAMF1w13dM sGsICQ8OkAcTZD5jtfwgDeAGk2uUEcbXn1bkq3SEiwGxRRNu4G9kBTIiH6mjYJ1tUod7co7WGyW4 6TsPygHX18CyuC9yG7uVRG5G+xT8NaJaiQDYN7qWCMfaQAjdNkaIzfm6k8g84AC6qQl1z/3VNISG BxJv+yMxOLLtPpSwDI7bayqR0jHWF9KEZka2vjDQPV7lY5c9jtLuEbCGSNud0id73TXAu1Ug7gkj ZqQ+TWbAbK5Ha2/dZCyzR7lZsAlpab32RsuRsqc/91GvuzbYqgCZ5BA4CCU6bWPKt7C42JQODmoA Hj1D3Q3dG+7AL904xgvs7Yo2sjaTqKABt3tPYlCNbHWHCZHsSBwrDwSUAUpvCRbdY1OBTMe5Pv2H CB7TqaPdAVFOJBc8/KI2aPdLfGGEEC6Yxw0bhALeGucHAbqiXAAJjmhoFkDiUARsQL8qNAtuhNzY /wCFZe0NudygI0k3AG6RZ2qx3TWP5ICjmXbrBQC2gB5CtzSHX5V/I3U80iMkixCtgqxtf3VNvY33 CWyt17EcI3PFjvcIgXcOPpOyEs1g78qaQGAtCg3IVBGsFOQSbk+yc6nfO4SNOkAJHp80k7n2RebI Lhrjb2UBk62mIt7+6KCa0ew3GyxIGuDH/G+6yYWubGCR2UKh7ZWy2vsU+NrA25WA2zrnssqN4sFl mh7rHccItnAb7BU25bx6VHHRtystFRJQX2DDsjsWtAHKGPi42Vt1a9ROyhSaC61+yuU3a1pNirvf e9wiIDt+yAB8mpjWNFz7qo36DZ2yn/Ldfsrku7cBAEyYeb6TsgnLhMNJuUPpa7cJge1p1D2QFis1 gtcEGo6rH7VfkWaH+6to9W3CAsbNspbUbcIzb2SdZe7bayAeWtDeUktDGlzdyUAcC5GDubIC2u9N iPlML9IuOEpzxb3KhnaQA3c91KATjd11LarcpTNZefYpwa7i+yIAObYgK2vDSW8kqOFu6puzrgb+ 6AhYQQSjDQDdUfU4+6pxcdr8IA9iSp3BUiBsdt1fA3CUCtVrkBUAQSQVUklgNkOrUPylAWXO3906 KctaAUDRd1k1oFrHlATzNZ32VvJay/CB7ri3sjDmyM0lKBbLvZ7qflUA2CLSCoAdIJSgFa7TdXy0 b7KuyFwOnbZKAdiBsgN3C3dRm+ynB5SgU1rm8qydNlYf35QukHsqBbAXPcSduyhYXm/sic7SLIW3 v8IB9w4AX3QXIdYpYHsbI3EBlz9yFsYBfcIC06lcJuCbK3PFvlCCC0+ZdPgLWglyQ+QC5KKN/mi1 lAMtrB9kvQWbHdOGwsqfYhAL8sPG43QPaeE5rw9oDeVBGHG52RAWGenmxCthNtymhjbE6rBA2xvb dUBNb6bXU0b33UZccq3WBWWABfUQRshc11naRYFMI22V+oMKqAtsLRGP9ypkYOx5TA61geVTjysg F0ekgIgb8JQeTumMdqBI2WwA+PzTcmxT2n0hpKUyfV6CN7phe1rrE2KgBPPsFY44VE3uqa4jup7A MzvKaD3OyyLaIQe53ukTR+aWi9t+yY5xfGY+SO6gBYA+5cAAqIFrBW1vls0qtJurYKeQG7cqmesG 5smCPglC9lpAffsqgI2Mm3ZGWahynhkfI78oLDsVQUxukfKs3dfSbH39lG3cfYfKgFr/ACoA2skD byO1Ad0uS1rhU6qNvKIsra1gFi7dGBDJHPdY7BPa0MN1TmgOsLKzt+yAthsbqSOu8W3QtcGixPKo DQ8k7jsowWZOx5VB4te/7KnO3LjzZIYTckceygMtoae9lUlh8q4WB1yeEMzQLhvCtAHzd+EQe7TY lABtblE7ZqUCi6/dDYA34VtN+VZsB7qgpjSTqBsFYeHFCH2NgrB0nhRgtvJRHT35Q6gqLbuuCqAi 9o/CoSdkJAOx2KoAN57eyoKJOq191be+6hcHm42VbAfKAokax8IxJqFigJACvVYWCAst39lBDZuo lTV2Kp7tIA5CANoBO/7FLlPZU19j7oiWvvtwgMZz3NOxTIZXF/rG3YqSNu7ZR14wNXCAe5zrXA2U dGdAN1bHBzRbhQgk25CAB93Cx5KC2hoFkZJIv3CW55JQFIgbW2urB2/CAvI7IBhbexH9kbG6XXJS 9d23soTqsUJ7De67rHhCdjt/ZU55bY2uqJdJ6gLIRjo3AH1HlSoOhw0jZY5FzynReq9zdDSLaQWb qNsN1Cy23ZTTpBQAuJ5CjgXABG0bbIXt3ugBLHNbyg8q5Did0zUSrAvdAC4XdcHZURyiIBB3VFuw QWBpJBVG4ARG+4QBpBtyhCw4uV7jcqNO9rIX6gbdkBHODzsNwpYGxKoDdXuEDKfubjZUf8qy6/ZR 1iBbuhCg/wBwq0gm6gabbqAED3QBar91Vt1A2+3CnGyAL7d0DowX3IR8gfCh2IVsF2sFHPDtlRl/ dDf2QDG7jlTUGt3N0LXFrSi0awDeyhUEXiw+UBeD6UEnpclu3F0KZAeL6QpIzy9+Qkg7D3T2vbo0 u3ugB1EC99kYcPa6WWAXA4UAuUFkDjrJvsjiIc8kpen5UZeIknhCWE9t33GymqxBKlxz7odgqmLD /qv2VEHV8Kr3RM9TrIyguIa6w5RgXChaHPsdj8qGzSBff2UBXld7bIdG5smF+3sguUAJ4sVY9IUG 6hJ77IOiF9u2yJg1IPv72Vh/lAjuhGxzCL6dtkqdpLSAfwlulsbd/dWHcC93IQCB72O9ew+VkhwI SZWeaLHsrJEcekcoCi6zt9k4BpHKxJXhxaALlZAaNNibXCAJ8Y0XbyqBLG77q4YhHGQHE/lASL22 QqCFgVexCrvxsqJPCFCAFlL/ABshabbnhGXACwQA6W3ReQBwf2SQHPfa23ujIOoc7ICzFpuVXnED 7bBG59wL8IQB+QUAJJdwqsNW5VnY3Gymkatx+6Avyw4XB2CQAfMO/pTpfRHsUuCPWC4lAHtwj0Eb 22Vt06dvuHugu5wsTZAyn7odJIIHKsi1yUUTdTr3sAhkRKTHHudyrZI+GEPHKbNSGR2sOBb7JMxL NLbXQBGZ2mwGx5RxuaO26U3nhG42IsECMlsYcb3t7IXHQbE3WNC5/n2cbtPymu9UtuyGgy4X2CTK LO4WRbS4b7BLl9Q+UDFNKJ5DgLqg2zflQ7cjdWzJRa1zfkIgL8mxVEAlRrbO1KAs7A/CVzvfdNJB BS7W27q2SiRbO3/uiNiTdQbuKF7NR5SwLeSxpNrhY8k7ZWaWg3WW2N9a0wRkMcf6iqgw99L/ACpC 17r7kKoyY0QLQ30klciLmIA7BLBEQLdN7KCUubf2VAipaXHSFhTxvYQA211yNnHc7LHkm13Btsqg Y5Dm2uhcbpzgJAAdikPjLXixWrAxpaGn3CQwEyucTco3D1WCOKJ2vZEBT5i14amtcdrC5RmE67uH 7qNYdfwFbBcjdTRbYrHkaY9yEVTVCLgJZrDV2FrWUQCbZw+UbfSbWSwSx422CcS5pBLCWnutAoNG o+n9lL7XO1lb3C9xssZ7t7D1BZoDtQIO+6sfbuqiiDQCArB1ucOyrBVtkTWi/KE2AV8Mv3UsFgN4 PJQmmfeyH+oHuOFckssbgQ06DyUsAsZcWPKPSNIJRFxt+VV7tsqBbSHEkbIrbcoRHod8IiqSyW+V ALcIb2KMcoSyC+rfdE0hx3KgAJVEhpvbdC2QtCW1pDjco2EEkKcuQoQcODuVTiQBYGx5CvS0j5CW Z7+lQBnS0iw5QhxiffTqBVNN+Ub3nSL9lQQvuL2VAm+6MOBaq2B3WQW+4NubpV73A3ITnuAZ8pYj AOx3KIEi/mAjhygLmXDtypa3Gyu1zyClAoC5urACsNN0LtgbrQKklBFhsEcUwDdN7rCcwlxAO3uq YXRusLke6zRkzH23PdSNhLfVZLDmyWAJ1BPHAvylBBi0bOd0MjxYG+6W91jZCIy8XvuFDQ4kG2k7 +yHSZOTayDggjlMLiVaBA7S0tIViQN7oC4E24S3AA2IKgG6/MdpCp7PLABN1ZFgC0KOYZGb8hADI 4A2PdUImtNyoANg7lXI7VsOUA4nZtjayfpa8FxPIWCTdtnGyGGB7Hh/mEs9koFsbZ7gO3dZIPpJ5 KVKRf0/4RwuaW2JsUAIPqsLFHrjbfWd0t+mN973QyAEB4G6AOM6XHbY8IiHaTbhKie5zbnZOuXNt e1lKBUr/ACi0AdkcbjsTyseS7tj2TY32aPdKA6otxxcLEY3TcA3TppLtueQhiAA1clSgB+lbVPs+ 4Hwo2l/SnTHIS3ndPJA3BsfZA97ifyryBxqCY7WKQ18jX3sLKCRwBB4VG5I9lANDi86nbITJZ9vd Ld9wB4CNxD7WVAesA2VyOaN7/sluAaRslgh7ySCPhAPbZw1AKWs4uslx+kkA7KSzeXba6oGEXN7/ ALKiQRbulNB2ffYog/1XOyAZps3lAb7bqiANyVRte6lAY4gDZSMXddBcEfKpw73spQG1E1nab7Jd tvhKf67e/unNeC0DmytAs6S23f3SyzSLqS+pwsbKEl1lQKNyCCja67LDsgedLlZkFuEA0NNrnhLk BB4RCXW23siJ0s3F0AloT2fnZI+522yIuEbbE8rQGsfqcRwoAQTfhCwANveyvzP7e6lAMG4KEkd+ fhI81xf8JryLAjlQAlxB2UvqN0RO9gqHKAu7eAEBABui4NrcoXmxDSrQKbdHp33S76XAJjyXm49l WAbWF7oGu8xuwTmC7Dtv7p7aFklKXMdZ/sp0DC3cb8Iydhvv8IAxzGm4NwiDja1lQC8kAK2OI3O6 EgkqwCHKgNzuChNiVRNxwp3QjI1w9lZIVWKr/KGSFxvyruAL90LjbdVcnlAG51ggBudRVj8qwR3Q pOAgc7Q4OPCNhJcQeFj1RcXAA7KogZex7zZSRzmgW3CBhay5IVCUOa7ayoGPlBjG26W15DhbuglJ DRbYJbZXN3G5UoHJ2IaCBa6XLL5LfdY5xB+j7bWSH1LpXG45SgZX61psCN1b6hr43C9iQuP5ffiy sC7rrVEszIqkwQaG7pIc0yF3cpIaCTpduEIBIsOUolmXK0yWsBdWytLGhpHGyx2vc0XudkwWcLkb lSi2bWRhrmNuR8iyXU4xNh8RuSGjvdZkuLxUjWRH1HuV8lnDOOHwx+S5wD3d/Zfx2rP6Q5V2Zhzq 2a4MpuDxdYGIZlL2/wAuTf4K6exbMksVc4051MJ7HlctheNPq4xqjdq+F6Y4V2eaWV9I4Pqzm2SV n6XzCWgEuC6OdIyqqHOduzsF3Jn7AG1GHVNWQQbb7LpOVgi+x9/hfo/8fBR6Pk6uTaoy2A/+2NLV x9Y1xcS7dchS3LN0qqYCPdfoIvk+RLo4gMa/siDAwdlUnoJISY5S4m+wXoR5yqmxZb/ssJwt2usy chgvyscu2uAuqZGhMwAFykzDUGAC6a/1G3ZWG+jcWXQyJ8sDhEAD7BWWEBCzTexG6Aew2Fyqmdts bFVbVtdC4B/HZALjmnhJ0cHlZ9NI57TfYlYsX3WPZZMMv8y1rIApIyWW7oRFpAI3Kc5/PCWTcW4U AWm4FuUEosbHlK/mA2HCYR5e7ypQI0APFhYJr2AbjdCxzXNJtdWx4F9+UAhxN72KsSF9gQmPO21k qxJUAXm6NuflMhm2cQUvRflLjJaSAqBrgCdXJUcLi4QkmxAF1bZAWW7q0AXNa8G4QtaOAEzYxkd0 LRYKgrQ4HjZXK0hoI4RO1AKMAcCgFst72KO2kIC3dQP1GyApx+ETbHZDrANihYDqJtYKgJw+VbTY 3uq1i+4UAB7KAtryHnsFV73UfsqLbmxGyAtobrBJRube9ikkabAoiSLO7BAERcj3RNaBe53Qh/BG 5TCPRrvv7IAWu7nZURcm3CF0jpbWFkwgNAF0BQFmoWuIPCMgOaQClNBAIvwgGOaJO35Sg8B+jhR8 hJABVPaGm9t0BktPqA7KyS0+4+FjtfqtyEfmG3sgFzuLRtyhhc+QWd2Rue43J3QsGp43tfshLH+o NLr8JLJrXIFlmSsDIw0b3WG6LQhOC3eooXN+FYuPZTUPygLAsNufZVbb1Ig4N9SF1pDud1UQj947 WsOyFk2gBjj+Fe2mxuULGB7ie4UAT3Bg34Ua27dQJUErHHSf7KOdY6W7hCohcdQ7Ktchd6Ao83+4 WVN3J3LflCFSX84Bzee6t9w4BvCu5NmncDurN7Ad0AR7KiLtIKog254VvaGN1X3QBCQ6QOAFQGo3 B3CqJhew37qM2NhuUBd7D5RMcQ35Qu2NuChJdeyAtz7sJSmANAI3uiLbRuB5KAOtYDgIkBjtyFDw d1WsXTBC5w1DiyAAEEAAqxsDdF5ZNrqpG2tfdACeCq4ChN9lVrFAG3jhAWhp1e3ZFydgVHG54QAS NM41C4soGG1zwjBsCAhJJ27ICE2sQleSRvblMANrEotB2sUAAGhm6Nrg9vKF3O6HexAG6IBuAaRb e6CS+1lTHadid0TZGOF7gflAJeQ2UJosblG/y3svqBI7pMZLmkLQCdfSbELHALDzyslzQG25SGMH merYKgvlvyFI5GtcE4RNHdKbTuLybAhSwPa7U3UOFQa5x45RwxENtyPZMI0jcbhRgp8YYwEHdZFK TANXBPKSXNLd+VUT3XJd9qwB1RKQ/UASVGPLmG/KgeC4bXQEkSk/0oa9BxODb+6U+ZzSb7hXMHfc 29u6W1ocLm6pkJjwPURdHIA6P2uldiOyoB2nnjsqBTLsuDumXs26pzLi/dEIyG+6lgAOud01rRZL a3Udwi1hrrKgCTnZCBcg+ylrvJ7IiLcICOuXBxCCohMsjXg209kTnkNt7pfG3ugGF29iheNrXsCr ZGe5WPKS6TQSbDugMgizQEYJsNt1TdLWC5U8wOdsUAt7tTrWQh5CZpuSbqNABFxcIA2s1s2O6UWO 47qzEybUWSFrvZWGmEAHc+6AU64bY835VNsNzujdY3VcCwCAp8rWjj0oblxBvZh7InRekh3dEAHN DRtZAKlIZayLyy9twCUegA3I2CsSE307BACyCJo+1U+JptbYKa9Bs42KMgCO9r/KtgW7Q1o3/so+ IaQWLHlkbGzVYkX3WVCaeojEkMhLhyxPQMZ0LjJfhFGzXJYFPlPmWLTb3UawNsRz3UARJgIvuqM5 Js7YJc7nOLe9lbiXWJCAbE0vBLeAnRWBs42PsseOo/TbWuHIoXO1kvNr8IDPLuG3UdYOOpK1ai03 4VPdzZSjSHs3bzsFYeHHnZKjvp9QsFYjGm99lmjQ+9tm8I2m4ICRHIGDSTdW03BLSo0ExhF77bhT UQ3YKmhzh6f7qb/uoUg0vHqG6qExzCSNxIePtS3sNx7KpmuDw6MfkoBsE50mN39KJgJuUoOAtsNR 5THSenTZELJ5gLrK2bk7LHDSCU2MkN5VYKkbodZoVRkj7troi8Fw3CGZvmkb2DURGMMraZ1nAOLl jtHkvJH2lE8B5F+QobuACtEsNsoDvj4T7+nc3CTGI9t909+hwFjx7LJoU4s0c7oWc2JQuZvqAvZM a5rwDaxCpLKsQ4eyuU6bEH+yt/q3SnCx2QDGz6NwmNmB3dvdY51EWVgAC1rqULGm1iTwhIsrJbsC d1H/APZBZALWtyjAu71HSlsO9xupNIXGxFiEKG7Te/KB1y06VGAOtblMLS2+2/wgMeNkjTu4FZZd aMDuFiMY/wAy5Nh7Jty0FAOc9rWi+6W+QXtdAQXgXCpsYJ+UA1oINwdlQADtzdUDvzsisLHdAS4B slF3qsjLgDsqIBN+6AF7T77JrI9TLjtyl/d9yOJ5BLRwoCBoDuEqY9hujB0OIuqO+6AuGQtACJ+r Vfb9kDSHcJhtpVAsaQ8F3CaA1riW9+yXpuBcWKs3PHZAW2S77WRlzeClja5Ktw1RE90AiWbyXgsG xKzWjzIQb+orBDdVvysmMlrSgFtYBK5pOyYAGccJY3eSRuVZda91AMLjoV+ZsNkAdYbKwSXbeydg vzN7BWXEOAPCA3JuglJYR3QDHEFxsVPL1boNW1wLpwBDNXAUAq1riyJvoaha699SYHgdksC44yJf MPA7K5XNlkuGklMFyd9kLiY5PSNu6gITtaymkHjZVq9V1ZBP4QFFhEg3R6vKbturabBLe+x2QAuI c5HotbdDGBe6YXX2QFSOOkWQl17e6MgKi0DnZVArVpFlXA4uFbhYIRx7pYKJtf2Vh2oEjdC83VMs 0HflVAp8Wo37/KAU5gOtztSaTcK3bts47KgWH+duy1wr8xzueUDnCJt2oZXkM1jhAHI0loIPCYH3 sXbpNPIHtOpNa4Wss0CFhefYIWxlg3TgQSG9lZILrEbBEBL9WzGO0E9yo68Y0uOo+6Y6JrySf8Kv Kt8hUANaQRc7K3i42VPVRk7oC2gdyiaNXZY87zCb8pkFRrpHSgekGxVARADlR3+ULiXMB91Gm1iU AWgn9ldwNwp9wKHhAW8Bx5shebWVEpkcQkbzugKJbYW5Qnm/ZGKV3ulXLSR2QFki6jSO6tzb2Pwh G10Ig+UB52V20t3KF0haQbWQpfl3PsqN2jYJ39OolCHDc2ugFGWMC9iCpp17u4TJCxpDbblVa3ZK JZY9IFjspr0nY8oSlHd+yEHONxsfyguCiYBex7qGEsKFsLYkHsgeQXbbBVYg8qXu1BZdze3ZQgjZ WoAS5CFG/fcJfm6TYJxG/OyARNc4kdkBYZchM8wNNj/dVG3glVIL3Q0O1tcfhU4XGyxQ4tPOyYXn SCOEA9m7dhYonR7LDdUECwKsVL9ICAfp3IBSwSCQiMlhx+6EWPq7oCi5p2twoSoeUJQyy3Oa4Hfd SM6b3F7oO/Cgku6yALYOuELzcqOFjyhcbbE2QFG4RAnbuqOzUJkBFrboAi4X4VN9W99lTXF7bAKm sI5NggDL97d1Ad9uUOnYuHZFoLAJL8oA7EHdV/VtwqL9W6sGw4QFlA6wFyo52rbhSw2vugF6dQ22 RNLY7gd0YHqtsAj8kB1ygoD1e2ygcdWxVul1bJYHbj5QBS6XXN/UgY1ECHWso74QEJufhXpv+yXv dG3a+6qBbieysuICEm4sqI08lKAdu91TkOolXq23CoIN1Hu2AsquQbDlA6UMcGnkqUBusADblTVY 3CAb2CIjcWSgEfU66O7HNv8A1BI8x1zsmAtc242KhUFq7k7KrX4VGPzm6XbD4UuIAByPdCkBO4UN j3ul+aHk2VjYoRhEW4QvPp25RcoSdCqIKd9u4391VHA5897lGWOebjj2WTSRhjtR2UYFtpZGTOLn G3ZDI2xvyVmSyAAOB1XWO71A2CFRjN2dq5TGPLiSeRwoGWULL2QlFmRzjbsgcdLwmaSrawA3IBug Gg2aHEIS/fgqGQW2QklzbFAXq3V9yUJOylz2QEF78plyAEIsogLuPZQ77AKIdRburRbL45Uc4WG6 jhcAlC7ceylBMBzTKdI4KZGzyWkKgSONlDd3dVBkFid9iiBuOUNwTvshdsR7IyFzB9joFyqa50UZ 1DlR0zoyA0XS5Jxez9vhRAjZSD6CVTxreDe6v0FpIKodlaBYLQ7ZRzlNNjcgqSC5BHHsoVFxvGrY brLNtAO11hMdpKyGP1WB5QpHE2JUa4m22yCU2uDylayHho/KCxxjfqvfZU9wfYg37FU+UviLL8rH YCy7QSboSzI4vsqvdS5DQhL7OshAhshJ2U1bcIXtO1tiUAQse+6jQSeLKNaGD5UbKCbDlAWy8biW jSfdG2U73590ouIcdkovc9wtwFoyw5JSXmxSdbgSLor6nOKE3Qgck17AH+6Vpbque6K1wNku93HU qgQs9ex2QPaddwNk1o0myMOa0ey0DHc24B4KNrnNaSPZG7S7cFA/02F9kAcriImE90mSYtOybUML om77BYkhL7AdkBT2tk+5FHC1huOEIBLh8JjTZaBUjdRuETZpGt06rj5U5BAQEEBUC3glxAvcq4QI z6he6c2QMHG9rIWOGnSefdCDSbNu1KhOlriRuUXmbKKMpT2m97qzYs53UHdUSsgrS48IgS+PQ497 qNJA+Fbed1pgo+3sgJ35sikbfsQhLbWuiDLDrjfsobHvcqiCdgUI7DuqYIR3KLVYe6E3RBp4+EAY O2yjy0j1GxSW3ifyn2B+QoyirC+3PujAQuABve5UBNlSssD/AChc0HsiBsgPKAtp9kbjdu53S+Cm WBF+6EsDtZTX6t1en/8AGhc3dC2XI4Ek9kDHuAuN+yIM1bHYI2aYmuAF7oQpriQFe7ONwqaLKj+U IMvtygeS5ADdw+EwcIbBa302KBjXNd8JllT+bXQDDoI2ADvdTzGstdJ0kbgqOs/lQzY0yMJsp32d skNj0G/KaLfspRbCIDRcf2VGQIXyDVYcIHgh2w2WijrBzr3Uf6gltfc2RXLeFKJZbSWtN1UM5cLl LDyQ8u7qR+kbJQscXtefVsVGkB9+bJbm6jqJ3Vsdp5UooM7tbrBGHEMDQqGnc91PtOyoCZcEt90L Kezjd26hPfuqAOrlKA0xg97n2QtJ47Kmu590VzzZZATgQRZDrOpU8uAJBSwHcq0SzJD2uaBbdLe/ SfTyFTBcX7qCwtblQoT/AFR3J3RUtgDdQ2cCriIawjuhLC1A3AQkW5QRygE32KITNeTtuhSzYcqx xccKaNYveyCIguLSfhAWbEq+NlCAy/dUSDYjZAWQHAHXYjsgdJqOyXJseEeprm+kWcrQLaDq5UlI cUkyFvZW1wI3SgPa4aRfhUd0kNLuOyNr3DZSgMIv3QiQDbSiB2v7IHva8EM+5AM+zcC6E3Nyd0tp NrONiqL7G3b3VoB6d1GODTzv7IASXo3HVxsR3SgU46imudoa3a6VbayvXYW5SgUW3Nyo4AAmymom 5KqTdhCUBLagNO17J4eHjk79kqF3l+ktBRO3fsqA9NvhBpa92547Jlzwlfa4nugLqJAYy0DdMjLf JY08pdmuNyrc2+91SIItaDdUXHV/0qgbhQ7iyFLc435VWcQTfdS1wCppsbXQEZrDbuN/ZA46tzsf dMJI4QW1HcIAgy7d1PKBP3kFW2/7BQN0u1cgIBYqHtm8u92FNbK+FxDSbFC+QSbtaGkd1Q3O53UJ ZDK83B4Vl3ZUW/Ko+kbndCkLiByoDZqF1nN5VtBt7qmWF2CgO6omwUYhA0Fjure7TYjlUJBIOLIC mHU73UPc9lHvZGObEpbjoaLnkoBgIIUsLgXQO2bdUCCN+UAZkDTugdG2V1yf7K3MFgSLoWStMgaA gI5zWWb/AJQHS53OyOZt3G44ST8bWVQBduCCeFUUe1yd0Wm/ZWGlioD24LbqnMAaXAAflUHconuD mgd0IxDWagbKrFiYBpCF1lpEE30uJ91GPFztZE4gu2F0JaGjnlUyEJO3ZMaDpCQGeoIy8g8ILNwW JZAZUtcWPLQeCuqeoXR2pdGZGl8zOSWchekayNsDA0lIhpI6mMhwDgRwV/GFkfZ/TXC0eIJsoS0U wadbg3b1BffZNy02SMFzb+67xzR0ppsWkE0DRE6/qsNil4TkeLC3MjDNTQdzZevyxcTy+JqR1HnH J/6jLeItZED5cLncfC8RTwSMrnFruHltrrZlnLDIosvYvobb+S4A/FlrTq/MOKYmQ30xyut/dfa/ xc3Ld/R8/WwSjZyUVwAEE7wGEbLGwyofV7O207XCyqmmbFG5+u5X6dHw/RwNU/SCLbpULfc7p1Uw kk9kqAXdwvUujzvskjNQISG+m4IWa+IuOyx6gEDSBYraMsxywlLfdoAVue6M2duqLi4bhdUYCbuN yqDBckblBtfZU15a43NlQZDGgnc7qwxrN7bpWkggpliXFAG7QBfa6SzYknnsrcLHlMDQ8cbqABj3 NebnlGGuJ2Sy0g77JzS5rL9gqABDI592nYdkVy8EPFvyrjqXMPG3shlvI8HcH2UAtj3B/lgbJwFu ymkgcbqje4RgvVfbhQsAF1Cd7DlSTYALIKB25VFvcImn4VE2QEsdrclLDNLiTyjD7b23UcLi55Vs A2NymBlgFUTLhE1+xACWCFtj8JLpD5oaOFHSODrW2Vhoe64G6WCSaYXDe47qy9mxCGSMPeAeELor GwufwtAjm3JN1Lm/sj9Vtwh0mxQEBBUBACG1huiY2997oRlghxvdUHEuPsgeCN1OwsEIHsSbhVcv Gm1gEGojcb/CIOub+6FC0gA7qqb+bIG3uUL3ekoqRmh2omx7FBQ2meDJIzkg2QucA43F1iOM0Uzv LaTc3JWYyxiDj9yFBa7a42CG/ItyrYL31KtNzcFAXDEN3K95D+FA1zN7/soHbfKEZDsbcq7b3VBw G6u4cLgoAPkhBcNfdESdwVQYRyLhDI01RvvxZCJNYuUDm237IQ7UR7IUMkK22shO/wCEABNwO6EH uY0Ab3S32t8qNBsLqnjU8DsgLYQRYp8UUH6eV8ZvLbhIa3SeLhCCGy+zUKY9I1zydQsssAMKp5Ad 6ETSDyhCGxvcKmgWVu+B+6tjLt3VALtxcIL2smSN0ADm6rSCFACX6d1Rfr2/7qeWe5V+SR6roBjb gfCp9mn07FHGLjUgk9ZQoGo6r3urG+6q/l9rq9W4VohRF/hRrWkBvdWd3Aq2gF4RFRTWtjfZ2491 zcFOx1MCCLe64Oex25unsmdHS6Gu/ZUMKraGnYj9ljyG7digBN9zf8q+3FgskIPtueVbXcqiNNrb gqi8tCAI2tf2UJQ69bVDuTugI0ngqOB7ILkut3Ka1rm/KAgY7vsi/dC92hpLkIlBaPdAWXAvVP24 Uc3X3QlhaQEAAaNeson07ZG3B5QTMfoc1vJ7qNL2MY07+6AgptLeVcY9Vu10wnW0XS5I9rtO6tgd Logbq5PZY3m+e8ahpCtpv95S5B5mzDwqDJJAcGjce6YWC/3WK4+SUxwMH9TnWvdcuyANDS72UAtp De6AkvcQOVb7Am3CphHa91lgo3DbWuUyAEM9XdSNh1+rhZBpw61zYLJaFDnYqy4AG+6a+FrHA3td Kka0C6FF+a6xHCob73RACQcodBb3QllG17WVPdp2VuFgLcqadTbWuVWQHyzbcoWuewjUbt+E2ziL EIY2Wf8AHylAPW1ovzdJBs+5TXAE7jhA74WgQkFCRbYG6pvNnbBEPg3CAFwsBdTW0HcIS0koSDfh ANa1r9weEmZuojsijJvYcKqhwaAAd0AOq1mkq43NB7hQQljg490YLWtJtugBDmtvc2uoHHzdjcWS wbnU7n2T4xf1EfsgFxAl5N904kuuXi1ggMbtdxsPhDKS8aSgKjlZKSAqfLoBsNwhgj8g/BVloLiT ugBMrpm3tZMpzp+5LDbn2CIutYAXCAqWpN3ADZBGHv8AUDYIZGuL7e6ON7mNLQUBUrTK4WIKOqkc 2DSALpcMRju4uBJTXtuwFxutAw6SV7ZWxvb/AC3fcbLkI6OnpQ90J+7ssaV/msDGC1u6kcbm8vKA aW67AHhGIXaCSeEqK4uD/dHYCMhz9lKALS3QXh4d+FTJWvHyhjjYyMtadudkN3NvpCtAZJYkfCN7 PNYLutZJY67hqO6ZJMAQ3eylAy2XfbSbW2TWBr7tPIWLC0kOs6yZE7QLA7qAyQPTYlCY3BuxuEII h+43v3Rh9jcbt91GbI3bkbog0g24CWakOuRwFKSQ1V3EEAFZBkCRzOArkBDNV9z2ROIuADdSXQef ZRlRjtkJHqPCrznNPpF7qOItwoGkm4GyIMJjrm5CjnEuBHZCTZqJr2lvKpCB3JKoWIN9go8jTtyo Dqb+EABida7Tv7I2gkb7KNk0tKtm43N0BC0hWwXVC4uqL7cd0AbI7ElGBbhLBPdXq2sslst52VNk F+FD8oTYDZBZkeY0tAvyge5rdj/dY79TBfkq4YzKLv4QMa4h32qibKyQ1tgEPJQhZjZI5pN7t3Tn O1DhY+rSU9p2+SrYBF2oZBck8lR7iHWJVNNjyhWNgaRtexTHP0i5SWSG/srL7ix3UKgnN1HZQCzE Ov1AXAKY7i4IKAocWKEssLg8KFyAkm6AvVdRrt9yrDNQCnlgC6AMAX24VW0/hC06xsUL9Q2QBkA7 hQEMI90LQQ25BQl3qQDCANR5SxsNkxpIFiLodJdvwEBGDcXNkwG90obc7hGHhu4G/wAoAxx8pbrq 9d1HNLhcfugKbdyLZm7zYKmek3Bukzg1B0nayAyHNZa4sULXXuULGaLDlMIAGyApjg7tYqzxcoX3 Y3YId3MGo2QBg6uNlLhzttkpsgtYbKfhQBG7XH2ChcXWQhpINyjaDYG9wqBjBpHyikkuwoRxtf8A dU7jcfuoANHBuiLtDQe6Y0DTuhcxruXWASgRrXvbe+yjidvdJE1vtOoe4TRcgHupQL1XNiLKnOtw dld9Y9kOoAnZQBteNBI5S2u1XHdE2zP3ULGsAcNz7KoFhptcK3O4AQh5cb8Ijxe6oLDtxdHs4ja6 xnAuda9gpUVP6SAvA1kcBAOn/mO0oiPSLJDZPOjEhbZxCvWRGT3QAvabqr2CCKV73HU2w9ymGPf3 QAglE++nfgoQCOyeZBoItuqEYT3EENtt7pskfmMa3gJT2kvWRE0gW5KAUyHQLFG1xGwRyNPN1X9O 6AIXNrKBpkJaEtz3Bu3KdSONjdQEI0hoVuOkhYssjjK4X2HCgc4EOLrlAZMoD2+xQsYGC5N0k65N wbD2VB5aCCgCmYH3uLhVTWZG5h+y97ImglpS3EtNlQMLgdhsEJbZCHWI90RdcoCi4kbIWat9RV91 dtXO6ERA25Hwmx+k34QAkcIX6kKZRmDgQNliSnyz73UBN7IvLB3vcqUA2NJG9kDx3TI2l13X2Cx3 PL7tBSwBfXsqlDnADgq2NsflMYCB6hdUBAnyrHskve47DZMc6yEblDITidIPeyqGQuab7KjuVZ4Q 0SQntx7qFoa0EHdVuduEGg6uUMjAfT7IPNla6xbdvujb6hv2Q3s+3ZAU2QvO4sje4MbwiaL7qngc FADckAoidgqsbW7KjZC2XewKhI2DUDgbCxVltt0INAJFirAB9NkkON+U5rxyQhoQ5tn6eVRa7VoB 2WS4tPAF/dY0kfqBuR+EAMkUjbBwsQiIcGg8o7k/cbqmne3KGS4/ULONlTpDbS3lDLZ0gA2I7K7W 3HKtFsuJpA5uid9wtwgBsbqy4XuClEI5wadzsqADyHA3VHdpuNlbQHMswWKgLPPCVVwunDCDbSd0 9pOm1t1HA6CgMd2oAd0IB1XTrFzNzZKe6zLXuUBeqxvwqF3A3N0DXF4JdsUce5+EAbpfKiPBJ2sl Nle6wPCkkA1l1+2ykbrgahwgGersLhVqfqsU4uDmi2yUSARvdATh47D3VyaWi+q49lT47W+Up8V2 kA7q0A4i4uBJACy3SNa2x3XG+VI1oAPq901jnvsx4t8qUWw6iURDU1pIPslNqGOdd12391zWD+QX +VIGk/8AUubxaiooMP8ANfCyw7tQh8gGahdvCIgt3Kr9SyQksZoaOB7pUs51ALRLGWN79lY3QNOv go3N3QpCC03vcKtWo+6p3HypEQ42QBPBYBYqrlxRFt9jvZCTp2CAp4PPdIjDpKgEjhWXP13J2RRm 8vsgH3A4VjfdUXMbsqBBHO6AmsC5NljmZ+slo2TJBtYhAJNwwNIv3QDo5Q4XJsVbngM4v+ULobD5 VRNJuCp7ATNLuBZFpV+V5QvcWKjSCd9kYKBA2urJFvyrbGwAnVe6pzT2CIEaDp2GyXL5obYXsUba gNBB7JjaxkrC3gBUGDG+WI2JNlntN47+6p9REQNhZKklAAt37IVDBGDv2CoyB2wFkLZL7Ky5rdrJ QCJs1KfJo3O6onVvuEp7bkC6yQa1wve/KYXDTslsaxrbXu5XxZAWSUTblDcm/wAKvMN9xZAODdlC DZI/UaXH5TDLawvytAMbhLkfoF+VH1TWXaRuoTcD5QFGQyt1cAImyF4AA/KQ7UduybGLWsgD2UBA OxuEMjgLpDSQDc/sgHixJOoWVgAjm4SGPY0m9kbnCwsbICGfyDci7UmWtjds5l7900gk72seFHxM LSSBdQA6GlmobK4PUOUJaCy19lIwGi11QZYbt8JcsZNiOAgbKA217hWZSWkj7QowRsd3XKN2xBGx SWVLZQbduyYyQeXchQpUxJDb8pYadeoo2vDt+4VPeNJRkIWglVYB10ETze1rD5TCNQQFjdC9rgb2 2UL7C43PsrD3ygi26qBW4spe6XYxuOs7otQRoBDm54VGOx1DlW34F0h4kZKHarNPIUA0uu5URp47 8qy4HjdDuQRflaMsE2BO9kJbdC+JzbXdso0fNkIGy7Tvwie5pbuFVwBuUOpVAB1rWBVOII9gr7lU 5oWgRhG9jeysPaHku3v2QbE2GyBws63KAe8gtA90LqZrALG6DUdgd7JnnbWI2QASMDHC210ogcop HmV3pQG5+FUAuP3VEbcqtVjbuFYtutEBtqF1YsNu6s8Kv6igI303vwrBPtsqvzsrHB3UKXf5UKq2 11SURlnZWx1x8oSbO+FZfbtshC3SXS3Sa7hRp3QSOGr0jZBYTbt3uhAOpRpuVbWlpuCqQa9pDB7p YcW87FWJn9whHqkueUAw2JF1TjcbKH7lQ/G6FBFyeUwHaypqlrILLJVX3VcqDYoC+/CK+yq91EIR Q8cqjwQqvsgDANlVgeVGnlU64Nr7ICg4kkDgK9yN1Wqx4VvcGi54QEAVk2Sy43+EYN+UBRcf6eyq xIBHdUHAE7qaSza6FLud1R7IrWG/KpCFO3/Cu2m2+yva+6XPMxp37IA5BcgtCsOv9xSWzeY307Kp CXW+EAwO0vB5TZg7SCNgUlwJaLIgSGWJugLFiLdkThbhB2VF9rByAZugfe/GysOvwVQsHAk2CFCY y9+yjnhl79lHb7g7JLmiVw3QWOa/UARsFZ+Elg0HTfYJlvlCF+3uiDi4AKt/dASb7coasOQOAsha TcC+ypzib3P4QtJIJQhktG/woQBcgJUcl2+rYo2v1ix5Uo0TuEQ4JVH5QkkWHYpQKA791A3e/BU4 IsoXX4UoBROINibIHtDpDpuEV7jdUQAFaAQBa217pYc/Vf8ApRar8FT/ALoQvXc7hW0X3GwVWVtO kE9lSgGUFxaRurABBSR/zNSYCdBsUMjbAN2U1aWnuSlNfdhHdV5lyG3QWOufL+SsYkwOue6Y54Bt f+yCqsQ3e591C2XPYsa66MWewEf3Sw5rm6TvZMaNLdtgqSy2khVqJNrbFThqHVugsIXHCMD037qi 7YIDLcbIWwwbt+VReSNgga+7iQNkWq5PsgsgIIv3CEG8lwdvZWTawtspcMNxuhkZb9vhLHJVk6jd UgLDbj2UPACh5VF4Lrd0NWFxsAp2UBBKpxA2ugsvVZCXgnmxUubbcKvL/qO9+yCwmvF+bonEEpO1 72sja4O2QWWHeq17BUXuJ0jcJbnWda37pkY2UIWWaSoLKEHe44QjcqkC3LvwglBcEQfY2BVtk1G3 ZCiWi3fZFctJsbhHKNhZLPpCtEC1fF0ImLDuNlYeOP8AKCRlwS47qAMva/e+lGxoAvfZYDwTw79k ym17tde3urQM6YRujFxx3WPIGvsL7BXI43a21wpJp1WGyAF3FhvZQe1lG7m11DffeyoDLtDfdKA0 Sa+6Z5lm7qi9pFwNkBfmeYblA7SHfCom7rgbFA43NiEAT3AbBQWGx3QlgbY3UJ2uEBRFnn2S3P0b phdcXCAtDh+EMsBrnOuVDugffsLIm3sFaBbtrWG5QyNOn5RawT+ELyQVojABLVZdcqWvyiDRbhDJ u/xCGSpYXdvdcRTV7qObQ8bLKw/MMVVRNsbh3BCRVwRVrbsPrX8Ur0f1T0crDiTJBa9gU5nkl+xG 6+OfXGhfoeeEyPHtcm2w91dpDNzlhsc2CYhvZpgd/ey1cYpH5GYMVgA3dUOB/uVtAx6rMmFzNJ2k jcAPfZaxs4D9Ln/F4r2Andb+6+//AIm4uSPk61LbyXTQtomkNbbUEM4DKQktLnE8o3zamsadyl1L nuhLQ3YL9aj852fP1Q3IvZIYHNOxTqwES27pDvQbE7r1xPJLsyWyEM43XH1VUWPuDv7Jz5Hluywa hpv8rskYYJl8zc8o2nZKaLbWVh29l1IPDA5pI5CgYLG4uhB0C97IxKCL8oCmv1G3YIw2xB/wlRku 3IsVlhoDBbdAKc0OdxZXcmwaVHaR3Vtsd+yAJ7bAXN1AR5droSy/JuAqA1EDdAW47Cx3CYx+tm/3 BIe7S/i6YXaQHNGx5QEEl9u6oXP3GyshrvW0qnMLze9kBL2dcbqO1AXtyoHkAhVI4kC5QFtO2/Kv SLboWtAHKJziTa9lKABktsBwrbICd+VA8bgj90TCw7Ab+6UCi4xnYXara4NuUEsgjsOUUbQ8XH7q AGSM3DuxRsNrKSEuAAOwUa4e/wC5QEc25V/adjdRx1WAt+VW7eSrYIVTr2UNyqL7WFksAO5RWsNl WyiAmn1FCWkHZWO5VNdc3KpATFpu4G6KO1vyrLtLrDcFRrRqJQosmz7FR0jnyMjDbAHlA4k1QaEx ziBxYjuhCOxNzZzE2Pja9kwtJeHE2HNglj1C5tqTGtLhbugKmtcHhUL/ALqnC2z9vZQPDOeVfRQw bgd1HDa9lBIOyqQ+nYW+VAA0gm6MBA0W+UReGjdDBCAR/wCUdxpA7e6VquL9kIlJ2OwQDJGW7KtG lu6sOL3C+wCKRwP4QoNgGqiBb2UDmObsd1LbIQonZS1jdBJqI2HCFrJHN24+UA4v9JslC8u3CIu0 DSqB07goAg0MFid0Pl67i9gVANTvdUJQ6S1iLICNjMe2u4+UYnIOn2QEdlHN02NvygGOcdQB57KN BJIPCS9hkeHtJATG6rb7oC2yAgj2ViQtHuEt7iz7G6lbHl17tsr6KNedTbNNkNwxoA3+VTb6lbrt 2PChAHONwSEwnjgJbni6E2cdjutAa59j2Qxu8x57fhYYLvN3OyydJa8OYbN7qksuQF1rm1lTpNA2 QVlSTGXRN1OVlofE0nY23QtlMcSfymSk6LBVG0ab+yE3LDvuVADG6Xj+kd09zfTtusdpOnRe11kR NLGlpNwO6lgW072Vk3BRH9kLpGkWtYqAoAXCJ8v6c3A1BVYHhRrg4kONgrQHNZ58Qftb2SpGk8C1 lHSh8JEDhraqhfK4esAO7pQALHtf8q/V3TLkuNygLmtdbuoCxdRkfmX3tZQggflC3VGL+6AJzgD7 qCUB1ylv1EWHdQEObpK1RAneWbnVYlY7I7OOl2yksbSQWn+yOjgeZSTwFKJZjywkPbqF2jcLLpcU /VMex126O57pga3UdQ2SH0wlu1h0tdyQjLyZEgPllwG3uiY0tDT/ANlhjDZ6fZtQXtP9PssiBssZ s83UKjKbz/8AKcx1yWA7pLSCbXRNvG8uBQ0XUTGOwdz8pIma82IWPUzGaS3smwtvf2URLDcNrg7J Uj7OG6Y8tYwkG4CxyCXBx2ClEMm4a4bqjJocLclAwtL/AHulS08+sOaLNCAyxcuS3Gx2N7pDXvDr 9u6dbvfYrQLHqCpzdA3VBxJsBdEbuNu6AVIQAO6FjgRuLKSNJFwhidZ1zuEAYbqOxVXDSQeUM0pi IIGyj3NLQ7hAHcoJGNeL91esW+PhTYj0oCtRa0B3CuR4twqkjLwLlRsgtpsgAYRfdPiNm8pTiB2T GD0iwQDCgIUNreyoA3sTa6AAAkqhwrJIuOVcYvygFOuCrc8NaFenVLa9x8LHkj/n2vsrQCDi+QW4 VuBY49lIgYyVTxc37qgjLE7lPkGoABY5DQON0THk7N5VAQ9AsFNrcqFpMgHCKRoiNiblABrLRykg m5ueUxzbgdwr0t7BACG+xUfIeFbm7GxS9JsOChC3kEAWsfdOpW2F3b+yU5txuNk1lmtteyjFjuN2 lXqD32B3skSztOlreUenymh3JWS2ZbYmytAc6xQyTiFvlA39lgmV+q/Y9kcYu9ryN0LZkyPbFENr XRwVBMdmCze6B8nmtOpqjJOYg0i45WaLZmGVgYDqu5GxzXNu4gX7rBaz9O31G5VPtJZryWxHkhAZ pkjPoFj8goHSeWCB6lgy09NTyN/TyOf76k7ziW2t6lCmSHDRc90kWBJQMkN7OIBSnSEG1u6pLMtx 1EbK3cfCQJD+AnCQaQDsCoLBJH9KJhJtZFp2+VBZoAQEfe2yGCQPJaRuqf6XXJuFTdLX6gOUKHId PKphNxc/3RgsmaRazh3Sng2t/lAZDnbgcqnOt2VQOvcO3KOQBrdQGynQKFnblDI4s2bwgZISmEgN 3SwACbBGEsODijvZQFk+pW59gEIbcix5TWsHB5Qtg2v6u6q17lQk3I7KgdkBbbE7jhFZtubIWi6j 23aVoIW4MLrG/wCQjja1l7E/ul224RtsD+VKKGGlx9wr8y50gWUabcFLIIJcCoAruhdvwnMc17QQ du6xwxz93u2KdGxsYAbexQBkMj3B5SpPWUcjSSLbqmgONkARcGMAvdLFiVUzvUB7KmjUT2VQD+3v urD+3dD92wQ6QHbndWgGPSCPdU3a991HEhDc2UoWHs0qeYbkDgpZsDud1LX7pRLL1CGT3ujBB/KQ R6t1YcQlEMlk7fttuh1WKTrBG3Puhc9xt7BKFmS5wYLlY80lnXOwKsyucN90EsYkDQdkotlNeOxT XhwtZNp8Nc/dg2CuoZ5bg3n5UKhEbTI/TqTg0xusSklhjOpl7oo3Otqdv+UBkWN9lTrmwPCFs9mF ycHiVosgE6tO3ZY81QPLeALpr9QlLXAhJ0aHXtsUBdHURsiA0EO7rJbJruALJLS0usAnNNt7WQlk JLULjsbotV28pL3WsChUHpvyboWB17dkJfY+4TI5gb9rIBgYQNwiI9KaTeK4Fx8LGdKwCwO/soAJ SQAb7JEx1xjfb2Ka86hbslkbb8BVAfBcxWvwrcbC1kLHghGXHiyADzNW190z+kJYDQ7ZGHDQT3QE Oxuo9wLb90svvZR1tPygFua6RwssiMlgF+Vj6ngbJmh8sW5t3QDZHaiChc8EWG6R+oAs39lbpLAB vCgsJ7ybNaETPQLX3QiQNJNuyW31OvugGvYDv3QhoLgDwjO/HCEbvVARIYbDhCfVcf5VPcNRUuC3 Y7oCAuDgFHgv34QWLuCrIJAvwgAcNLQ7uEwHWA5QkHYjZQfyzpHdAS99lOLKFvcqDciyBhclWX2s LISSAqJuPlCEGzyeysmx2VH25Vna3ugsjJHDZUWjVsOVA25uoL2KCyGMA83upexsUtpe3ZTVvuhA 3kDlLFjv2RG7wbLG3BsgMj23uERsAlsbYcotN0BHO35Q3VFhVgWN0BcbtI3VPfe1hdW61rnsgubb coAw4g3KZ5jXAjusfS5290ZIaLtCAN8oDQLXSzfSXdkPmfzBqGyIOHA4QEjOyZrulEWO17KNNygD Lbm4KsE3VAglUb/0oWxiJwBIFkps7WE6tz7Kv1AcbjZWiDNGn5QAtvzurDgOTsVHBhBPdWgALGW/ cItQHwk05cJXHn4RyuBf+eyAJxt83QoyQGpZIcRbhAFb34KthEewF0LHAuATdAc6w5UoBOdex4QF 11b2Fgu4oCbb9kYLcBbbY+yWWe6libFQ3BUADgeFUdyDfZNFrqNYCP3VoC330oHCzNynvbvYIRHe 4JVoEe6+hrOAN0gPIqA07b8p/khhuDe6W6C13Xu4IB8p0VIad9r3Vckkcq3OErWuPIFkOsN4QFgk G6ogPNyd0H6hpuCLImt1A2KEKMRPDiHe4QSVczG+U+R0jPYlW8lvB3S5I3FwJupQAdUFwsBZQXkb vynMZtwoGjWQTZUMGEaAASna2j7dylFhG4QOd6fSLFCDJZCbJrXNbFfkrHY8u5GyeLWte4QtjRqe 27Qsd5OrT3RsndGSGhJeCX6roUY+zwLchCxtrkoXNLjcbFUA4/cUBkCPU26os0GxSHzvZGbHhUyp L4xq2chLMkgfugDiR9trIWuFr33V6rNsOShQ2vL27uQTB7YSWferBDWgnlGye2xGyAwaLzw1wkcS O11mXdbdBEB5pJPKa5172QANa517HYK2yPDtz/dUHOvbge6Axl4IvZQhJXl7nbC3wkhgaLnhZJhb ELA3JUfECxUli2kSgC2wQvieTcGwCcGBosNkQcCBsgsGI6Ruikla2zrqnaQ35QPLNO+5QWWyS7xt spK5vblLa8tOw2V6QfVexUotk1D9ynAWsEqEBzrn9k10mg/bcFUWQclBqtsTurc6/GyBpH7qFDOk tt/UrA0tBI3QFw5I4UdLrGo7AKkKLdUmskEImEuJAN7dkl0jQQ4H0pkbxKbs2QWNHyrbZrrpTrtN lNR55WWUY52p3wobHjhJaT5tybBOd6ri9vlVAxywueSVbd3AXsAmRs0XBfqQiOxPdUBh4cbWJRvj vHcc+yqHS3YhE7VckcKewYj2u4OwRtjFt3KOJfck8JYf5hAHKpLDI2IBQx6mtIdx7qF9n2KPVYAc 3QWDGG3sGgX5Kc+zeOEsi7bDlXqdsClCww5pFxslOuRuiJDdzsFRlAGwus+wE0gC/wAKOI8rY7/C W6UeWbb/AAqYREwgH7t1aFjYpABbuoXvbqcOeyFj7GxFlHylz7gelBZj1cxfJExx0k8rJa1jSRz7 FJeI3vBcLuCH9RpfbYBUWZN3G44Cx3yEOs4XCy4rlgNt0mexO7VPYKYNieLq7277qg4kAGyHYSEq mS5W+kG6B77kEeya5upqS2wNiUBL3bdW8j3JHuqdYccKh8BAGwXUeBfZSMi9id0Rbc7hUFCL03tu kPcY3WsssO2ssdzGvNyVUwY7Q8uvyiZqc434TWt0XVBxNw4AKgUw+S8k7hQku34ROAcCFCwhqpLF kWdzuVY4VllgPdVoLfkFaIy/ZUOVZNlbN7lCoFzg1XzvwpySqcXAekXv2QMK4cNtkNtTflDrI5bp Vgd0IQbj5Use6g5KvuhAb2NrKrbf/Kt3KJwGkIALWHso5vFjZEACCqdsEBQJCg5uqJsb9lZNkBWv 1IuSl62keyIPHZAEdjyrJ2Q3BG6oWKAMN25QlwB97IA46iL2ChIbxugLa86ztsUd90gPNztyjYdL d90A1u+6FU2doFrXBV6m22QEtcbGyg1XIdwlhxde37K2l1iXG5QDANtkEup34CtpJVk7coCiQ5oH Cm1uUq4D9J3PKPltwgBsdaKRriNtwFA0oS9zRa6AmskAd1bSQbk7IL73Rl1+ytAj3OJsOEiaIvHu mtILz2Cj36Nm7pQBgFmgW4Raw19jwgL3M47orNcw32cqBhcrvcXWMxzhuVkt9TQVGLITpKpwD+Re yBsvmOcC3jumG2lQCTJof8ImtEo3NkMjQSmMaC2/FlfQDsGssCha23CJoBFwhvZygI4hr91NY1De 6VKDIbqg8BwVoDzJvyqvclJGzr9zuiMhulAaNlYKGL1n8KiQXEXsoC3R3dfuow6VAdLt+FA/1bIB mrWL91QfY2ddVYwnzC27SrMrJTd1hdAQm4uDsrAuRugbpaPU6wUMhLvRuChbCMg1aURAA3NwkyMt Yt3eeykbjpu7lBYxtmd7ow0HdIkqGRtFuVI6jWwkJRBwcOOPlA/1HY2S9YLh7Kn2Jv7IAS71kNKZ FqY073ASQQ03AReYQw3HKtAyw4NBJ3ug8sF10ps4mIjbe6cyB7N+b9lKAJsCR/lATf8ACa9hFzbd IcdIuQgCAF03UBYBJLgXe4t2VSSeX6+UoD3DS26WdzwpHWiUG7dI+Ud2vFwbBWgAeASVGbH3BVOD bb8KmuPbZKAwkRsOxKCF5eCUGqRhO2x4uiY+zbOsFQEJNZ0gfurI0/hC2QN27FA6bzHEcWUoDhyp 5jSbA+r2SRVMvZwJcPZNa9rtw3+6UCzIA6xULgXbJTnBzrjkI9BcNiEoBg7lVI3RZxSxI2NoF7lE 6RrnAE7KUA2vFwLWCrUL7lKkcL2b+yFzX2B33SgOuCHC2yjI9G5OyXcn02/dGSRyUBJWODVI5AWb XuFTnlgHq5S2yhhI90QDNTsp5uv7QgETdFybn2TGNbCNu6tAjGG1yTdUX+Xs7ZUyQEk69vZA8tlc HE3sqBpOptx/lAHOGyhqmR2BGyhrInDYWKIDWSNtZ5F1JIxL34SPMjLxrNlZqY45BpNwgBkpHP3G wCMAsaASimeS5pvYHsseWXTIByLIToe6RzRvx2KoWLSeUAe0i9727IC8uALRYFKLYy/+VTnDgjb3 Qulay3f5VukDgD2QCyQ/biyNlxYE7IRa5I5QzSENQyZDg4dtlWrb5SW4i/QWkAhW2pa8b7OVoWM5 QEm9v8Kw6423QEm5NlC2XwNlRQl24Vg8rVEBkNtuyC6J1yhAPdUlkvuVYFwrdE7Re3KX6m3G6EGk AC6DzAmQxPnabNufhEaKS/CA2WZV6i1GDv8AIqQdHbUvrmdX4nv0xQ6SP6vdfP8AUDJ0cXmS0zA0 ciy6mdBWQSvJkMYbxuv4wo7uUf0lzcT0A3HX4t/NLtzubLMo5xGfWV1R0+zX+mnMde+8Q73XaIr6 HEmM/SvDmnur12bjKzmKjEP1ELmX2DCAtcHVymfS9RcT03u+pO37rZBBgT5I2O1jS7ewXgnrVQxM 6iYu9wAMMxNvcr7H+LmoZufw8Gui5QPjZXaJo233DRcFZD5SIyVg1Df1FSycdxwsuoafI9PYL9ij 8zVHz1a+0ziAsJoLpdTjssutjcHX91itBJ3XsieaXYb3WaT/ANljvvJGXdgsksQTNDWWtz2XRMxR hX3BBRxi7r2uFT4hdulZLaXSBuupADC117nnsgawR39llaQBwluYH33QCCdT2+wT9RbsCmQxNAuR dW9rL3CARa/4TInkcjZU5m2yMMAaLboCgCXEhXYNOyltINkPI9lLALm+u90QdqFgr0fuo7SwXCWA mMLGoTcORMO+55VvPJCWBcji0gK3eq11V2ud6lHt32OyoLtY/CFxv7hATfhOa30XQANZYe91LWub bpmxQl4HKATr1bEK2+ng7Kg9rXXO100W0nZSgU03Qlocdzsr7DsfhQiw2UoFmEm1jYBAQ7Ve9wru 4IgbDYWSgR1yAVNnDdU7cAk2VOcLDZAFsNkJQtdcq7fK0AjexQ7AblV5hsll++/CGWG6wHp3KOIk tIKQwG5N9k8NIAN9kCMfyy2cuTHtLvyqdu5TXZ1kDAkeG2Nk+CQP9V+Ekua+7SP3QtJjvbdqEDkI ncbu44VPYX8JchaACBymtGiIEmwVATIi3lEQdNihbLq3DrpbqgNJuoB42shOkC70JmAZqul6xMzc EIBzXAD4VSMaQDwln0gXTeQL7oCgNkDmG9902wU7WQoDGbE900DbfZDwi12agFkOBFjsmGUNFlWo WKry2u3J3QhWljmkoC0BoIRua0NteyrQA3nZUAtBuiI9XFj7qifYob3NyVAMDdJ1HdCLukPt7Imu AdqJ2QyEvsWcIAHyiM6SmxO1N4sElwvINQWSLaQALIC4iWn4RmPU0uA/dJedBaCiqZtLY2NNiTuq UjWE8pc3GxunaOzTqKU52kG7d0IYwcXm1uEOjfVbhNjv6jwhte+6pORTXeY+3A90Wh7uDdg5QyOL GmzVdPUOpwWubfUoyBx6Gm2k7q2uD3kDYBNvqg1EWCx6Xcut/lEQdIdDbA8pbX3aR3CqWQH9klkz QfyVTSGOu/j0kLJDiyMA7lCYw7SRymz/AGjZRopjg2dc91crCW6gNkt7iw2HKt0vljnlAXDJqNgN +6a1oaHEi4WPTse2TVewKyZD5JsdwVSGFCwU0r3A7OPCzG2FjclcVUvcKgNBsCVyBmFOGNIuSqUa 4tdJ/wCEA0gOPLhwlnV5t+xRNNnEdyoyMCOpe5w1BMe7W74Q6bHjcojtYKIgoOe15vwlmVhcSCsl zbkNvysepgFPvzdUWVCwSat7ALOY9zYth25XFtdZ/ss6MvdHYm4T0CyCLb8ooBpeqmIY1oJtfumR BjRYHU73WTQ2SUBwJ7JYqGyPtcf3RP8ASwOcBZY9XDES2SMEFAZPmsY610qSo3LWlY5jDvUTv7Jk cZI35QANif5tzuEYlMVwU+neI9ni/wApdaLm8Y2KAD9Qyx35THuY6IEOBSmQhzfS3U72Vfp3vjc0 WY7sEBbpBNaOEEyt5WTJUyQxBrtzaxSKQGnaSQBIeSFcz9RGrdABHOCwgi10wTsZ6SCbqERjgWKW WjnlAZANiLCwKTNUaZLDnuqE5kIHACU8Wk1EXQDTKXDZvKGQCNrbcofOBNrWUc65QAEukNncKOBP pA2RWMgPuibcNseQgKa3SLImHfTwgsXWBNgmxt/ugALSHC/CqQtBBCa6PWwhx3SomNjJubq8AvWb faiabEXP7JjZWFp4Sw4l/GygGhuppKkYuHF3+VeoNHCTVRvlZdvpCAGMXuTwi/puEoP8qPS4Wb7q jIw0zpWmzWmxQDY7BxPdIdHYknlQOMjWkHtdRzjqF90ABJPdWPUPkcqyNQuFW445WwWdwo27Btsh aXB3r2+FfmXBvwgGNcCN/u91Hx3aSTuseNwbJqJt8JjhJruPsO6AvV5bBtcjlTXqGoBA55aLe6p7 wxgHBWaAbjcJbm6BzuUDH2NjwnBzbBaMsoXIAG6b/Txuk6iCbGyOM+k6jdSjQTHAi5b6ghkkMjg2 5sra67jbuoR5R1IA47DlNvdtljSgztDgbfhLc5zRzdCcGVLMY23aLn2RxySSQhx9Llj0twbndBMy olcS30tupQMwSF+zjqRzOvFYgge5SIT5YFxcd0FbUCrh0xm1lCj4SCz1AXHdR0jWtc64ukUs4mp2 i2kt2t7oqkMcB2QAl9mFxPqKt8kjom6dz7oWAXtyEYvpvew9laFhFx9DnHcc2Tv1LZSNuFjg6uyg aXbcWWaBl/qAdzsrbIJHbFII9ACERuDrkbe6lFsznFpG6Flr83CrUxzAxp3QmqjpniPku7qFMhmi 1gLFKc3S+wKIkdkIN3W5QoTHAGxS5XSEFrdwj8sHnsmAloOyAx4wWjdONzyNvdRoudwrLuyUCtIa jADu6U48W3CKM33/AMIBg+7Y7BU9zdQN+FQcA72QFpc6wUoDXSh+wCG21wLqmxmPuibYD8q0CMPO 9iivdhNwlOtc72KqKnJB9WyAZtbYqxwk6HM5KPV6QEBbnFp2VAmxvyq+59/ZU4m/KAbGwv8Audsm ecyL08rGBsDvureRpB7pQsa6oANlBKGnbkpLwC0C6EAs57qUWxoF7kplw1qFrCe6qXawuqQqN9zb hG5ne9ylRn1hG541ae6AFkrg+x4THO34sEBG6gfc2spYCu1w35Utfsq0jlFcOBKoBCsiwVWNtkRa Ta37pYFgNCYI9tlegC1+VC9sZBdsFGBZvexFgp91vZG5muxHCowuHChoz2VgihIbsbLBL3PvqQuJ IAVNOo27oA230j2VEbcqy7SRsheEIygSLAHlZULwzkceywje4sLoy0s5dZAh1bIZC090kEuHwrL7 uA5ROaGhAwGbOTmO1O3PKSRbYFVGTeyEGyOGsNHCo7vAO6tkfr9/lVps4HlChROaH2IWUxkdyAN+ ViSNDXBzSmiokfGdLRcILKNYYnGMDZIaz1E+6W2UyPO1nLJjA078oUFosPdB3sRsjII4VgXG6AD7 TxsiMhPBVH1BBwLd0AQdd9kY2G/+EtrCTfhXc8EoAom6n7pkjQkyaiBp2QufIxu1yqgM2tZBvfYo GveXerYIid73UBNLS7hC4XKIWuquChGLeXcchXcttvsmWAIvyhkaAd9kFlSyFhBaVcbnFhPBKXJG 54u0bIxswC26CwyQ7vupI0MIF0oOs4FESS7dBZb7tF28/CX5jgf/AJTNW91Tzq4CELDvTfuoHlwI I3VWACIbNQEY86bOuia7bbdB2IUGzdKFQ0m42VAXQAW5Vggn4RBhOFlV7qDfcqhsqSy2usUWw3O6 x3ar8oHOcNlANe0h/Kh0sFxulBxc8+4CvWS2xCAZr4I4QucCgaSW27ImgEb7FAXG3Ud0y1mpYaST vZMI9IQAOuSbC6jufhE3ZLqXBrLA7oC77+4VcnYK3OayFptv3Kh3AIQEIvspszblUXWKsD90BT2h 4+UADgbHhETZC52o24QB3tcKhxeyq9xa26sX06StIFhwHdWXEcJZbsVV9I90BTQDdxFylvedVxsm sjJJ2VPZ5f3boCrukt2smAAjdKDrnZXvp2KAjGkSEN4THOaDvufdBq0MuNygLfNbqJsR2QDrkG5O xSy10bjYbFAbuAF+EwSucQChLCaLbnlU4PDtTDYhWbn8BQkP42U5FlzziWNjHGzgb3TJL6ABwsCU eo/CKnqHvnDNV2qsGUDpG6rZ5VTODXXVa7C4URSiTe1kQNglma3ITAR2VBYOygIsVLH9kJI1aRug LBuFei6G9zYC6ISBt78oCm2aFTiCLqxI229t0qRzTsCgLDW3uQoCG8Ib+kAK9gN0MsnJvZW53sUG sFwaCr21WCELLiAobHe+6vbulvHsUAfmBjTc7rDFQZZXNANlkOjMlhbdLsI3WtuqBjD5Ysmxnf4S WkStIA3RB0jW7iw+VAPc8b7IHjVaykP8wEOO6qNx8wgjb3QEZcA3UJuCpI5rAd/2WK+qAOkBUGQ5 w77pIiMh9gjhb5gTbaLhQAt2I1BE8hrS7srLQdyqJJ9rIWwA7z7FuwTT6BayUwOElm/b7J5Di/SR fuhBY79kQBuo6xvY2UFxzwhqy+Apa1t+ULrWQuuWbchAG+9gGi5KtrnNb627BKiro3Asa13mD3Cc 2u0Rlj28oZIXX+1DrA7IonCRpc0cKoXMkcbH1DlAKnl8tlyqicJmXDTdLrXEM0lptflVRyae9ggM oBwG6W4W5Ce2TXdtt+yNo1AB1gUZUY92sju42CKOojkiLWnf2KCcW2BBskXa4+loB72RDgfKC0AA 8qr6CBdBu6wQyljTpLvUhB4A1fBQzERssN7ooiGDf1E8KSNIBIFz7IDEY0XIP2pzKgMOiJt7eyS5 jtXFrrIgiEY5sVSlnUTvsVeogWQvuX8pbABLqJUoljge/KMO1XVtewsJ90AmbGwtPN+UotltcyJ3 r4KZ6SbtOyTLonjseQeyHzQwgAbWRIWNnlEdhe1+EIe+23CRihb+mie13rLtwnxuaWix4CULIXbi 42KlRpZDZg9XuhmeAwEJIrdeprQLD3VIC52kDe7ismd4YxrRyRysB0gO6OWVkoj9Vnd1aBkB+gC5 3TI9UhuDsuPneWkWNwsuKZzYtQFglAj3euxNwlNvI9wGw+VYlFy63KgI5PpBUoDGgMjIPKRuCS7e 3sjIdxuQhaQOT/dWgObMJADwiMmnfssd0g7WRecCW7bBSgZMUjJwdgEr0CYMfGbngoXudKQIxYfC sveWgcvHdKBnOmEQDALLGlmBF+6T5z2EFw1O4sgc0nc8pQGk6ow8blu6GGojqWl7eRyl3f8Aa0Gy qKERXDRYHcq0DI17fCXpGolENtlAxSgCRbdUTZQXuRYhUbN+UBLF3GxRBx02vuEouAcAEwMuLq0C Nfq2JR2t2QvGm21h7oHva19i7YpQCfxyQhJGkb3KcYm6AdV0h4AO3IVID9pIHKazjc7pJI1XIN0w PuPlWhQEwLHC5S433Nn8A7Jsg8zusZ4IPz7qohl6b/ISiLFRrjsUZIB5VILsia21jdQPY51u6hbc ntZAC4m+6XJMG7AoZi5x9JWIXWJJVoWZ0BDzzumOAG91hwODRcHcqPeWbk7JQMq3pBKMs79lgx1I fK0O3CeKppc7cAdgpQsdwOLhCRfnYLHdW3vbYBNikZI3d4H5SgE5oBBBvdDbUbAoXTtYbXv8qmua Tf3QFOjFyeT7Iw9pFiLFCSGuvfZKc8aggH6hwBdEGADfurYPayEi7tLjYlAU9otzsFTbJMpfE4i1 2ohI0QNeD6z/AEqoDpBpNrK2x3ad7IP1bXAXIDvZA+bU7Z1j7KgMt8objUkuqWtdZoRCrY0aXXJ9 0qR8BILeUoD2HUdkbZWl+m/CxxMzYA7/AAhD2BziTuUoGUJWuO3PsqvsCsKKRkchLjce4T5ZWOju 1xSiWOAD3XCAuFzvsEltaY2gAITUhx3FkKObIb2uhkfpdYpTnF27QSlvc4EFwO6EZlNkBTXPAbcL BbI4bhhI91NcjnWDT/ZWiJmYCN/lUW6eSkulcGaSwj9kl00jtgD/AGQt0ZZk8vc73QH1uBBSWmXT p8sk/hFAJbuGgm3ayEbMhjm6lfmEOO9koMmeP/vZ35AQmGoG5Yd1Ahoma0lvJ90TJdR7FY7oZ37e Ub+6OKkqWu0tjO6GhzCHPt3UkJhe3WdjsqjpJxNYxke5RSYXUTykgG3a6AjqmOmdv6wfZLNRGTbg HhMOA1DzyqOBVdtmh1k4IrBbZwsCqcNJ90TMPqqYnVAfyidSyOFwwglCidYvzur1avZVJh8oNx/h RlJKY7g2I90MjGPLGkg/sq2+47IXUcpNwVGU8moBx2SioIvuLjj3SDMWzfCy/wBG5/ob/dMZlqom GrzGD8pSDEita/0SGzUmqlj9Ol3Hss//AEtKCdcrbe90v+Atbs6YE/lOCWzCZI54D3fYFmR1NOI7 GwPumHAI7f8A3xYexSX4KyP/AN4OV4FsOIx2c7VuPlLhHnl5Egbb37pUmHln/ubIoaJp9Or1HvdQ qdmFM8mQ3N9+yKnnLHe91ysmAx+UHNlGruLrDNG2I2JVJyAyW4d8JjXB7AfdMjoad0bi95DkyClY Wc7BQqMctATIqmJhAkFwsh1LAW3fJYD2KjWYeWf8y9kTspgzVMQmLom2UbibmD591mQy0L5Qxrd+ LnhZUlJRR2Di0OKEZxceKkNeHj1HhIkqxIw+65aaioGRh7yQB7JLhhz7aDYfKqSM2YtLUNbC4HlV JO3SL8eyKZtPG7+Xx+Ugzx3JISi2OdVx6R6dlI65jLjTt7oY6qG1nN2/Ce2opAwDyw75Si2JdLqF xct9goJ+NLT+6fBVwQatDQQeAVX8VaAbxtv8IWxLqiVxsGFKEl32IOr2WfHjELbERC/urOLwSSa3 RNB/CEtGK+ORrWnQbe9ljyvIeDYtXKux5lrBgt7WSzjTHAl0DHH8IWzj26mASBtyUfmzuOzbXWUc XjLdoQCkSYgHHZukIRkjY8vt3KXJFMx5sCbeyv8AW6eEf8UfwQClGbFMLjyCHIv000rthdGK5jh9 gBPdW7EPLb6PuSihDCqwDWWkDsiZBW2sG6kEONTsFnuLmrJjxtgmBIIb3sg4EvNTEPXTm3ulmRzh dzdPwVkYhjXmO0wk6Plca6re913boLMzyHSAOJVSUsmoELG/WPAsCr/Xzf7tkoWZApX3PquVDE+V tr8LHbWPNyTYoTVuH27FWhZl/wAJfpu14UZhsjRqLvT7LCNVKeZCjbXTBti64SiWZApRI8B7tI91 kyYTF5epkoJ9lxz6xz22KWyoczglSi2jLmor233RswxpYPWC9YLp3vsS43VtqXt7lXklnIS0N7Hz OOyxqimMfqJuFjmokJvqKj53yNs4kpQsaxzWtLgd05kjHgb/ALLBDrCygJvsbKks5Emm3DjZQwwS N9EtwP6VxpNzuoCRwpQszTo+1vKYzyhbXv8AC49ry03HKmo3vfdKLZyT46Pltw63BQF0BjILQD2W BqPuquhLM1r4wLAqxNG3Y7rBUShZmukie2/9SAStB/CxVFRZkSTDbShL/WEkGynKEMxs7QUL5m3I NisUqIDNpcQ/TP2aNKy/4sw9guHsopRbNzmbMAZJS2A1G268954wZ+H1FmMOlx4XqiZrX6g8XBC+ CzbkiPFYn+mx5Bsv4tCTR/TZxs844VhcskurSV9rlx8+H1TWXcWne3ZfeYB08Mb2skaDvbhfXnIV PEwHymh1uQFuU1IxGNHGYJj4s0P7NsLrwl4hI3xdQcV03BfJq/N171lyk6ldrDjcbrwt4jIXR9Sa 9rri42uvq/4ynlPNrP8AxnXNC11mgm5A5XIEF+1/2WFRRGMDXuVyOmzdl+3Pyy7OExGnDXELiSzS 8lc5XkAm64Y6Q8knbsu8HwcJrkob8pU5ubHhZDbE8LHqQbHfdd4nIxL6Ze5usqEF5JF7DsuPu5rj cXT6aodICwXF11MmU82PNvhLDnC5KhiMZGo3VlmoXCiBPOcwc7JTpS/vYpjwbj2CSAJH+lUDmuu3 n9kzUGM5QNZfYDdXIBYDugGRuDm3B/ZQgOFuChiNhxZFYXLuVKAI1N2KKwDTfdTXqvsoHAf+UYFN Lnvubi3CZLq7cKnEFxtsFQO++6lAAtfa1kbS3Ta+6J0hNmgWQuY1hHutAltIVB54Vkki6q12n3QB Em6r0u5UvYISdLb90BRa09uExrtrXsEFxbZTnZAEQGn3V2/dABqbtyEUYAPqNkBAVbht7otUbnbH YIC8HgKAF59Ow3VAhrbHlE47X90u21+6pAWSFzrJundAYyGahyo0nYnkIEU8jjhQNDmqnP1uIsiG wt3QAu9Bv27I2yX27WWPVS2bYb/hHTtLmAoSi331KWJ5smuhNgbgJbeSOUILeTGdgmNFwL90bh6b G10DXtG3dCguaOCeOylY21IDwewTRCGjWSlVLXVMekcIKAo2O/T6nCx908BrgCRc/IRvs2jawWul OcXAAC1kFFOZv/0nsjjZtYbqtyN9lbUFFSM9duVG+kWVgHzL8oHuIcfZCBkkBVuFGN1Xvx7ozF5j djuheyi4W2VD7bFW2LTa+5UEdyfZCsnPCIcKNaGjZUBY/CGaKlf6RcbBA6QSNFkYZcnVwhZG1r7o CvubxwpbYp1tIN+ChI2KFYmxaDcbFHE7S0q3kEAJUo0gWKAJpAuXb3Tw9vlavZYzHm9uUw/YWjdC AVj3OLHsFwOVjVEpkmjdZZO4Zb3WIWEuNzaytAyo6l7JAG7oi97jvykU92vLjvtYLLuWAEjlKAqQ kMKClYC03JKOocTYe6qNmgDdAIlkDiWgH8oYQdQafUR3WU+NxB0gfusZrjG/ewQGQXlrbW9KWHgX 07JgkBB2BS9JcfZCUKnYLAe6BsQa64KyDDq5QmIMN7pYGxvAcLlMqReMG/8AdYcZ1PtbZZEwe619 gjFigwOsb7hR4u4HsFBa9jshedQsEoMOWa7Q37R2RgFjAHuuTwVivaZPuPHCdHEQwDVqREEywh8g vv8AKyZW+d5e49KW4ADSTchQOGm42K0BjndkL7W1XsQlC+rc8qPaTdt7oQISmRgI590QJsd90hrC 1tr7Kg8sfY8KUDNbeRl2mxCxaiQFtnXLrrJgeQw7LFmsSSRY9koojSZJA29ge6z4f5PpDrrFY0EX JsijIEl91GDLeGyW1C6IxtiGoX3SzI1vflZUXlyREuOyhbEh5ds7cItQayzRYFKMrHM9N+UQlaWA IUU+M6geAnMswi52SpNRLbC4TCRZu1kAyQtafgoBJd2kHZVfzJiXW0gbKjZwuEBJtcZBabfIS2yO Lhq590wNc4AuOyuQNbZAW+VoaABue6QT5xLN9t04yM0WG5CDRwR6SgKuTt7IwbNKoDRyo6w3vsgB MjS6/CGWRruOEflh2/b2VTMbpFhZAJaAXj2TNQad0Dxp06VZjL1bJYTpByFA3UNV9ljOGhxCa0ks Avsg9lX1vsFlRMA9Rd+yxS3S4Fp7J0DgAboijZR62n+koXtbfbdUZPNl52Ct7wCLcqARpu4m1kwa i2yGR/q4TI3622A3Qlk1GNoLjdV5claCIuypjbuLXblOp5zTO0t2PuhTCxJzYKNkTzrlJ3t2Qyx6 oP07PS0i5KN+GS1tW54lDD21J0sYo3hshBJ5KqBgxv0gRh3qG26CTXG617krNnoWU7/ML7a+GrHn laC0NH5WiMS2oewkEbD/ACsqml84X0kFKLQ4g2RSO8pnpO5QgkzPmqnjgNROcSbH/CCFlnl3cpjh cG3KEIxosdfKY2Rzhpvt2VwUM9UNMTNZ+FktwKvjBLqeQtHNhdZs0jG1Nhc1z26gOyTPaeXzANI7 BZBYBcSGxHYrDE+uVwtsqhYbdxdMa4Ej4Qg7KfbwrRktwJ4Gytvo73CU5znGw4RgaRbkoCzIR6m8 o3M1tBLtygaQ2+yA+u5O1kA17RGA0OKmgaed0AI5ceFA/U49vZANY2w2KszvY3STsg8wgWtuq1+g 357IUt8olte7QlRWik4Jae6ss1AOJ/ZMLgQAgHa4xu3YlJe4vfzsga0AEqRu1HjhShY2Np1c2TyN rXSC4XVaiDcXVA0uI2HCtkZPBusQzOEljwmx1ek2WaNDXFxcADwmCUuabnbusTfUXX+Ux7g2IG/K UA4vRUAtN2p5jbK67hx3WK3+VEHtvZE2TUQ66lAy3Nc22/pVh8kT72u1LkkDg1p/wrExaCAb32Wa NDxN5ovx8I/M1HbZY0TgG24KZGCSSShRpvyCqB1CxKpzTtZBpLQVAG0Bp903tsseMuJ3Cc/doANi gK1X3KKPdyWO6F1Yym3eDv7IDIfLZ1rKnENCAPEg1AWvwqJuSHbIAJAZHXTGudGPgoByrAJvfcdl KAbpSSDpuo28psNkvWWNCG0zJAWuBaUBkg6BbkpT9zdKimdNUPYfSG902+txseFQXew90ephFkpr SCSTdS1yUBcgBtZMBBsEqx45RNapYHA+WOblJcTrBKgvcKOcXC57JYJI61i0Ija+q1iqHF0QKoJ2 Ql1lZIsquDxsgDZLr2so1wuRawSZHlhF+6ONvclGB7TZjrJIqCwG6j2kss02S2svfe6iBksk1NPu glDZGlrh+6EXOw7KOdflRmghKQxrQLWTGvIYbncpTHAA7JYc4uOpWzI9rdrqyA0Xbuktkc7YBFEL OuqLI55ce4KrTbe6qoDi4Fp2CgeLAE7oA2mx9lHxl4up2KT5r+wULY1hLRumB2phWPqNrhGHkNUI XG2xOv8AZWSL7BC15cN1eqxsgsIEtGxKON4adVrpQ/OypkpD9Nrj3VoDHuBfe3KXqcH3bcBHb1Hu r4CgA06CSOSmk+jfYpd7HfdC8ajzayAMPPCol4PCBzjazTYq2zS/1EEeyAJsxY71KwS59+ySZdTx flOa3ndC2ERZLJuijJfc9gqdYu2QgQdpIvwqe8k2A2Qu9X7Ki8W2KAsuQlwNh7KXugH7pQDBCgIu qIQtO9u6tAY+IvNwbWVVDg8saO3JUbqJIugDTq9lGAmExgi91Rk2sqIJcpp5uhAI7gklNvcXQ6mt YSeEAcXAWKFGDf4CsWKGYAQ34IVQkBgJKgGEk9lLm6HUTwiDSdzsqAhbdCTuAEZYWjlKluWnTyqi WNMgAAI391C8AcXKxbvbHdxu5SOQk24JVLZlavShLSAED3BhHcpl9QH/AGQFcqnDuRshLg6QtHZO sC31HhZBjG1z/wB1YIIVytt9hSdbG+kuAJQDG7G4VvIaLpYOlrRz8pr47t+FaJYEcwO43WVq1BYe gNsQbXRid8fqsCEoWOcdPylSMBs47BFDOHkkhLlfqvY7eylAHWG7HceyY1xc27dwkSD0W7qmSuga SNz7FKDDfNofYgpzSHjZKbjbJAGTU4aL212WUIIwA5p2O4SgANhwkOeNRJ2T3E2JGwWNIWkG+xKU ChNZ2yayQDdKiY0n1bn2ThSgAXduTwtE5Kc++47qyHbWSaqP9HKBquDxZB50rB6gSDwUFmWw3Nr2 VPLSCHG64kV8jZy14I+VlRzmTSLXJShY42Zx3UJ5HCKWPSAe/skTa3bBpQWHp0izd1VyEEbJL2N0 0xyC3puFaADnHYd0Jf5cgumPic2zrG6vyBKQSf7qEDbKQ7tYoXSADY7+yKSn9Vr9uyx2RfzHajwr QLvc7q6dumcEC90TI/NaSzcD2U8ioZINLPT7oDIdHd5ubBDJKxrbJUby+cRuNyeVMwAQiMRC7jtZ KAEjmvewAi35Ty71AC1lgUVNIZdUkTyAOQs+C7n303aEKMY0uvfYBY4PmSEN7K6iZzgWsb+fhJuY gLEF3dCmVFy5t/V2QPjkAO2yMiONjZS71n5QOrmlmkG7kJYmUBsQLtjdR8kTdIH3WS60vmZG1rTs dynthieLgbgd0IDr0t2O6PmHWULoxYu5SnVkfkuaXWA7EpQIyWNzrjY+6ymMYTtuVhQCF7RpeN0x 38hwIcC0pQGkjzS0myoMLN76gsZ8kJeSZQ1ykFZTODmud6r8q0Sxs0xbszlDud3DdX5UbIzI2XUf 9qTHWaXH1tcPZWimRoeP+WN0WiV+zzcpIxEuf6NvwpJXm4I5UolhSMeKmFjXbf1FNdU+XO5jhdo4 K412IWlsTb5RHE4g+zt78lWhaMmoqGEk3usVtzIHcj4TJZ6B+4cboP18DDpvdvwrQszIWE3fwE3z xaw3KwmV0Dzp8wtYhGLU9NMQ0a2+6m1sWjkI2nv3Qzwy/dG3UPgLDZjsLJXO0lzTwE2DNggJvFqC bWLQ9raqAtJju0+6zWyAHURY24WFJmyKUAmP9lx9TmATv9Meke6m1i0cjPStdL5zXnfkIy5rgNJv 7r54YtKyQ2OpnsnRYydW7NvZa2OibkfQOLBFsblYrpvLNyFgxYxC0HW1wv3SajFfO2Y0kdlnay2m cs+uj8sBrGgjv3WDJMXuXGfqn2ILSrir3McCRcLSiLOfw97n00oYPXba6TR+dTucZWDV2IXFTV00 h/lB0YP+3ugFTUu9Ie+/NnBVxFnOyvdLq1MIb+EqNsRaPVYg8Ljf4jXNZYsdpH/SrZPVTDUKdxA7 gKbRuObef05Y4ODrpc7pJpWuGwtwuIdUVTR6oH/FwVTDiFTJeKOS9uAE2jcZ0ofrNxpQwMe1xsLg pX6DFHDU9rm/DkDaPEy67Y3H8BVRRLOTaCQCCikpY5CH8utwSuM0YlH6jTvt8BB5GJTOLxE8fspt LZnir8qRzXtO3dPjqGTMvrAXDBlcHuY6J13dyEbMEqwbtJTaLOVkOp226oephsQT8rAbhGKsuWxu I+FP4BizjcRuuflFFBszjG4i4G6xXuMZKBuG4rTy6Ham35umSYVXncAG/Km0WLNSXNDG8omTeg7X ISzhNZE8PIsfhE2iqdDg1u5NzdWi2DDO6HW959J4T466Mt/+UD8FnqgHF4aB2KBuAvFw6QXHCtIl gzTNkddw2CyI6yFsf3C6WcBmkZrLgLdgrZgcDranub7lKQsb+uh0WvqVfq6JnuCeVnsybQSw6jir IXdhIEubIbo2te3EKeWM+zt0pDk4t88Wohm7UtzWyt9Jt+VyU2VixpIkG3cFDS5fvcPkOnuU4Jyc WX+Sd3Xssqnq21Nm6g387Lkf9LUu3/EHf3PCD/R8c1/Jq2Ajs4q8Dk46tqY45Gtjdvff2smz1UTG 21Am11lty/BRm08wc73Ca7CaB7LW37Ouo2hZx9LjEbmWkAurkrKZxG9rlcnDlHDZrB9YYSffdYUu WqWlrRG6r8yL3GxSkORZNLe4l2HslSVdOw7PuPZcpNgGHUzNTJtbe9zulwU2CugeXgucO4KVyQ4o Yq0SsDdmX3KbUYpFDL/KPmD3WVBTYDI4uc+Rtux4Uqf4Y3ZkYsOCrwOTHjxKlmGuTUx47IoquGZ5 Jk0jtfuhZJQ6tWm59jwsln8Pe/8AmwjR7gqULMWpr2059DmyX9kQr2OjDj93sssR4PG/0McPybpL pqOOoI0AMPcqGrMX+KRWJLHXS3YyQLNYucoMToKGS/lRyg/7gsqbMOEm5GHxaz/UArwSjgGYy0sG qFwd7hDJViV14mOItvcLmW4xSVDg0RRsHtZE7EIInWbCz8hT/g0fN+dLfV5bgb8WT2V81i3yz/Zc ycZpBv5Iv8pDswU4JHktv72QhxsmIStaSYzb8LGdPK/1CMkfIXJux2kJ3iuPwp/GqMfZHsexWqM2 cZ+pqmC4jcG/gojiczW2fHY/IX0NHmhlGQWsY4Ds4XWcOpkRBZNg1JO3/cWC6f8ARD439a54ADfU U6J1Wwamxamrnq7NmC1fqbg7YZf9zTsuLfjkRl1xt0t9lSirVE4tHEdXsFYosTA/+9ybdrIqPHX0 rXujI80m7dXZZ8WYaiaPVK5od8KW0DjhDWEWdCWov0lSHNu0m65CXGmOsBIAR7pUuPloDbNI91LB hy4XUNdqjG/KSYcQaCC29+U5+NvDiWv29lUOY3svdodf3VVk4Etwire24O53TG5drHt3tp/KCbF6 iR38t+kH2TGYtWRDSZAQqKKfl6qjFwVTcArJG3FnfuiOZagMdG4D8qqbMNRHEW3HyryTgkeWKmQg XAcVnnI9TC0PknYG+wO64sYzMCS2Ug9ghOPVvHnEj2TkcHIDJ8zg4iUaQiGVg1oDpfX+Vxjseq3D /muSf4pUE+qRx/dKYtHNnKZLbeeAR7oP4A6EW88EDsuHbiM7b/zSb+5To8Vcxw1Eu2WakW0c7RZa pa4PMtZ5JA2B7qNytA06X1IcOzgV8y+ulc9xDyASq/XzgW811vyrTG5H1Dsu0UN3Gs0W25SRg9ET c1rX24N18y6Z7zdzifyUJLvcgJtJuPpX4dSG588X/KVHhVDFK0mrDh7ey+f1OPcqrkLVDcfVfw3A ZXFrq18b/wDcBcLj30tLBUWY8yRtOzz3XDteR2ui84nY8JQtH0DI6JwudJJ+Uw0eGm2poH4K+YLz 2JViR3+4qUxuOekjw2MkNP8AdY5pqWTdr/SuILy4WJupqIFgVUv0jZyscVLG7kOHyieKU7XAC4dS 591aJZzzYsPkaNTvUoYaJhuS0BcDc+6hcSNylFs+mZNRRC7C159kEeOUtPNeWkZP8HsvnFFKG4+v dmajeP5VKyMf7SFjT5ihcAG07AR7BfM3UBsUobjnTmCM8wNv+Ff8bpi0EwNLvgLgvu7KlaJZzjMY ZJIQ2JrT2KWMec2Qnymmy4cEjhRKFn07c5Hyw0U7GlYTswa5LujBHsFwvKiUWz6EY/Hpt5YaiONw uB7H4Xziim0bjkqjFpC4mJ5A+VI8fqoxy135C41RWiWzl2ZkmbywFLGP1IcSDZcYolIWzmP9S1B+ 6xSJ8cnm9guOUU2oWzINdNquHndT9a9ws5yQAoQFaQse2sew7OJVmucRvysZRWhZkCulHBUOITk7 yO/YrHUUpC2ZRxKc/wDuOP5KH9Y+97m6x1LXSkLY01Mp/rNkJnkItqKCys7q0hyOFU8NsTf8pYne HX1G6EtIV+W7/aVByTzn3J1u3+URnee5Sy0jkEKKkGipfa17qv1EgFg4gJdv3Vht+AUKF579NroF ek3tYoxTykXEbrfhALBIItyifK55uXE/urdE9psWEfso2CRxsGE/spwCPmc9gaSTb3QJjqeVgu6N wHyEGg+xTgFKI2wvebBhP7J8eF1UoJbC5wHwqKMa5t8KlmHCK1jA51NI1p4JCF2HVIG8Tv7KWhRi qLK/hdXpv+mkt76VP4XVWv5Lh+yWiGKoslmGVL3WETv3CN+EVTP/AGyfwlotMw1FmRYRUyvDfLIv 7rIdl2sBsGh34KWhTOLUWZ/CKkPLXRkWT48Dlfe4N/hLQpnGKLnKfKs9RJp1BnyUubK9ZG4hrQ8f Cm5F2s4dRcm3LtY6QM0blPlyrVQEF9tPdW0NrOFUXOsy0ZnhsTyXH3HCzJ8h1UDQ4vDgRfZZ3xLt Z8souf8A9I1GoeyzKfJrpn2cCNkc4obJHyii+xfkVlwBM5p+QlDJB3Al1W+FPJH9GyR8moV9fBkN 8slnS6Gp5yLFDJpfI5w+E8kS7GfEqw0ngEr7uPKdJFcBpJP+5BBleKGQ+nY+4UeSI8cj4Yiyi+7l ykx52GytmUIf6or/ACp5Yl8cj4NXoda+kr77/SLQRoj2TRlaLYad08qNLEzrux9lLbLsM5Wic8DQ CCj/ANJUpFnQ7+6eVEeJnXNj7IvKeBexX38uVIWNu2MfhIqcB0MaGx6v/CvkRPGz4fSe4Koiy7Uo MLoI4m2ga6S2+ocpkuC0Mhu6kZ+wU8qRrws6mUsfZdoS5ewvSCKezr9kP+l6IO9EIKnliTxSOtGw vcNmOP4CnkSWvoP9l2U/AdwIWtbbkWVSYCxg3YCe+ynmRfEzriOklkNgw3/Cb/Dak8RErsGDC2Rk +kIjh8bgf6So8yL4jrl1DO3mMqChnIuI3EfhdijC2MYDYOKzaXC2Pi1aAAOVVmQ8TZ1b+jmJ/wCU 7+ydFg1ZN9kDiu1G4dTlv/LaP2QTUUbNmnQe1k8prwnVz8IrWus6neP2TG4FVEAlhb+V2c2neWad Wv8AIQfpNbbPAJGyz5h4TrlmXKmT7bX+Uf8ApWv/ANn+V2JFStaS3SCVkCKwGwU86RfCbVTVDXa3 B5TQ5kmxs4HsqrsPZEHvEoII2sV86zFP0z3NJ4K/j9H9Hs+sjpYIxq2vyjd5UgNnbr5+lxdtUQA8 LkGykDa37IODIfSB4v8AcDstfPjFw6TDepfmaNIe0HZbBRVeUImu2ub3K8U+OQQy5jopQBqLbB3u vqf42W3OuDy6mN42edaSQTwscPwuRDdLBcLi8LIiiax2w+VyUlbC20e5JC/dpcH5T2cPiosdQXBy sL9wVzeKPvsTdcOHAG3denGuDy5HyNhc0MA/qWNUtG5R878LCxeXTTOLSdS7pHnbEwVOmXSRquVl vliijdpBvbssLD6V7qfzD9x91nNeIIySA5x5uugF04Jj3eXX9+U4bbdkph1kutb8I2+q6AMxgsKC CBrHnfcor277K2xguD7oC2N0XB3CEOte+4TCCduyB5LdkAHmKNcTxuFRaSFGXY0oCFzw25Fgia7U hbVNeBGdt0RaLm3AQFjdE1osSgAsOSiY8gEIAeD6uEDnC+26ZI4vFgEDALEFAQaiEfARNbcXCBzr ccoCgdewVEgOIdwh8zSLtNz3V6tXKAJpFkR4KXqv2soXC3NkBbSIwXuOymtrml17gq9JcLchC6LU y3BQCqZgOqxTWu1XFrK6dmgkKeaGHcIAZWOOm3ARNG2+xVCovwjFn7nlAU47fhJa+5Tw0NbYbpTm WNwEBTmbghWCAdR2CtpsN0t41AjshOQ2+TcnY3Rx2Ow4usQxaCCsqAej2QchVB02HZA+xtY7hE9o e8XNyEl/3EoLL1+Y8i+6XNTyktMdnFSNwY4khG31HZxafhCDRIXRkOFigYSB8KNbttuVRJHKGhkl ja3flQM07cFA1wad0wg2uEJZCBb3Qht3AInAgIo4i7fspZQ2t07W/dKLdTr23WQ4+mwS3uHlnTu9 LJQoMvzwnABo2S4g/wAv18og0kBLNJF21HdXsgfccI2m7d1LFEDdAvzdTTq2si07AKmlLFC3x6fd C2K+6yAdj3VOFxsLFLFCrX2Qk6Rbm6bsOe6sNaRsrZKEgttYjdYspLn8WCznMAN+Sllmp11SCAws Iun6QCN7XV6STc9uAo71EFBQGm/fhYs4BkuDZZEh0kgd1jvh80gB1ihkLzdAA7JxcXNBulCnI2PZ EXFgAsrYCJa7b+pBCSZH6zYAbK3REuBad1bm3/KgBpjJLqc77b7IJGC5IFwshrgItISXPMfI2VsF RizLgWCsbbqXu3bZVuAlgZcaTdKfpKYD/LN9vhYTqghrtrqgY17Q/wBkyV0ri3SLj3SYo9Q1PT3v IjsDsp7At9xuee6nLUokk2vcJ2sWA4WgDvaypoMLr35TQ1oNwbpEgOq1+UMBmTW77N/dQNu+97BC I3N3G6ymYfJ5Jkc4WIQGK5rnElvZVrF+bFZDGGMi3dcfOSJ3BQGRYlpN0qXW0tt/lSNzhbdRzS43 J4VBkgFsIN9z2SnEnlU6S7ABvZAJTpse6FFvuXhoPKyyP5RsPUO6w4haS5OwWZBJ6XFx2Qhx9UZp dFtrFZlNM4ENPdHJpcAbWQgBh9JF0KZDnNAdcABAJmNa64vfhJdVWYWvG54RMkbJpAbYqMtjWkxE bnfsVk3a+1xyFjVD3OewC2yHzrPteyyUbo+6x2Qtk0MIO5VRAgEn1EogBa/JQiIajW2w2ATLB7Wh Ka0NBNt00HS0G+/shTAqmOa70u7rJY4v0kngKnNjMlibHsrDdJ+EBbnanaVNGra6FukPWTGGOaXE jZAYcj3RusCjbMJNnHdY1ZK3zNksWeNV7FWjLM2Y2Fwrikc4WAuksBewbqjO6K4aOQrQDdGHuJ7q 9QDQDssakke4OLjcrIO5t3VFgubsbbqmEsuD3VlwuQTwjaxrrd1DQcLC25PdVL9wF7XTXOs2w7LH lGo/hZBYYb7m6dALXPdY7QSVkMJ0G37oC2s1SXKXIS2W43TGOHl78q7gbgIAXG4DiN/gp8ULKoa3 dvdI3PAsFTtTXek8oC8TjbPZwO7BYBcdp0eoi9llyRO1c8rGMTmvPdi0CCS7bhU6zuSmAhgI0rHc eStIwWdR24VsmLDa11TXC3COIDXdGDkKbGpcLaHRx6ivosN6j1cFK8hkekixDhuviZHvbMHX9Kok y3DdgeVhotmXila2tlfKAGlxvYLCj/lgahz3TPLswABG8B8YaRutIhC5rLAm11DZ34TGQxvH8x3A 7qhE0ghrrhasFAiwtwhsQdyhePLNlTXX27oA+TsoLlWRpAVhwO47KWCiwHYqnNAIITAGv3vYqaA1 QAudq+FTR7qHlRAWXXNlR5U7quOyALa6gaAdlPyoEKXw4nuivwgcbWVtJkGyAt7A4G3KTZttuU0H SChs0boAf6VGudcAjZWObK3yCyAaHG1uyjuAG9kgPcW2BTYZgSWO+5Qthul2FhxyoYrMMmqxO9lT yQzSW2KqJxsQeFkoyKYT2A2IWexumO97lYEUYY67SFkse4sdp3KjNWE6YtPP7KU8pc4ghKjjLxd3 3BXS+Y6Qk9lkWZ5IB+EL7XuEuSQt2IVB+43ugLlDmt9PJVCFjIbykEn3THuaGgB13+yx5KYzODnE gjslCy9ViDew7I5SXHVf9ljFpY6xN7JnnBzduVaATJtzcI2u9JPY8JQHpB5Ri7gW8BKKR79grcCA CEktBGkHhMMmlo1HhCAAaJNRPKa14af/AIWNLNYE/wBkUFQH6fzuoZMlrtQNlY9e3CqbV5g8oekq TVkVKy7x6kLY1hDRbkqi43PZDT1sdVFq+z4KvzWOPpIKCwS/+6Ij0Cx3SnStBJG5VNqGuI2ugsde zRfnuqJLfwidpMe5sSp5R02KUUAvHChIGkdyqNo+dijZ6xe26Cyp2amje6U6RzQB2CZI97RYsIHu lRkyvLDsgDEpafhOJYeNisR48p3qVSPe/TosQUFma0G6kntwknUxoJdur8x72ktbqIQAFzvNsBsp KJGAOAv7p1MwzytAZYnlGKqFtW+GRwBbsgsXE4hmrknsnA7WWO/E6Wnn8u+x4Ke2qilPpIKKxYLg Q244ulCMtdqO/wALMEYcwn+lY0EkbpLa+PcoLCbqf2KF/pdul1FeaefS1vPsrFZHKbuNifdQDGgO 2HKN8dhsQsZtSxjz2B+U3zoXNJc4jZUBjYWt+6mlLpyypGpkuw20p0vlxRBzpATfi6AAgj4VvLWA W5TRU0vk3kkDfa6xhVUcpIMoPtZCjGOPJbsUcgDSN9isaSrpKcE+ff4WBNjkDnBwPB4UpslnKlpO 45HZC0OPZY0OJRTesO0j2QzYxTwuF5A4H2VpizMDN1TowTe9ljDHKEgESEHvcIH5homW5f8AhWmL Q5zPLOoklODy5l2jdceMy0wO0ZLf+pM/1LTvLQ2PT8pTJZmwP1BzftKqEl0jmkcd1gS4zTOksw2c eT2WJ/GWxyHQ+4TaWzn2NBJv7JIhD3bbLjYMxxN+8G/wo7FYZASyT1dgptJZyboyDxdFEyR7iPL2 7FcEcffE6xaT82TP9Uz7NjaSfayu1izmJ2kAixB+ViNLgfwsV2YJLh00ZHvshkxX9aLRM0gfCUy2 ciyojMbnE7hQSh7RbdcOasmHSIn6uL22QCuqIm6PJO/eyUZOcksGB190HnBrQTv8LhHV1ROC1sbg 4e6A1lUxoBiI/ZXawc66jqai0jBaHuimpXxlj2DU0chcQ3MtbDCYdPp9rKmZjqI2abEO/CbGTcfR eR58f8xvl/BVMhje02sdK+ZlxXEZX3cHm/Fmq2VeIR+vy3W77cpsZd59CHM1XDtkt1UBIfYL52Wp q3v1CN7R7AJ4FXpaWxuN+U2i7OZfVtc31Ej2S2VDWf1cri6mmr3NB/TSEW5A2WIaatebmN4t8Iok s5t7zI6zXA37XSv1kdPJpefUuMZR4kAXimmeB3a0lUKWuqJLNppS/wCWHZa2k3HNedqAN1lxwOmZ q1WXDyUOKwaA+hlb7HSUM0eKyOADHtFuAptLZzzIGPbpEgDve6TURCAbyh34K+ddTYjGd2ybo48L xSpHpjebJsG45iOqjO2oK5KWhklD3Slp7rh2ZfxF7t4nNt3TjlnEX2LgbH5V2jcZc3kRuD46kFgP F1ktxikkLQ9/HK46PJ1c8humxPATm5CxI86G/lybV+i2Zr54XDzI7OYPlYhxOle4xvJB90mXK9bS NIL7EdgVity9USE+oX+UpA5GNkAaSyqsT2JT2xMDCfOa4/lYtNkmtqC0F7GX9yuQHTLE3/ZUwu/D kcULZhyVMIcGulDflNaIRY+c14Rf+nFdqtJPG035usqPpTiMo1RVlO74LrFKX6LZh4lU0v6UNGkX 4IXFw4uYTYv1N/7Lmq3pniOHm9ZNE1trgtddceMqCTaOoBtsSVVFEbbD/icEzdLpNPyFh1WJCEgR u1LPZk6JsRMlWGPHA90uPKsXL6gEIkkOSqbFaN8JdK9zZfhYb8caZLWJb7rlXZSp320zW/CB2Vaa MEOlJKVEW/RxrMba2TU5msDgHdZ82YYJ42lzA23ICJmUqN5s6sEI93LJmyZhkVMJG4vHK/uwcpUS Wzin4tRybaLfJWO7F2xys8selq5JuWqFwuaghqyYsp0D3t/4olvdGoi2cdLmGMuBYy/vdLOONYbg ar/4X0OIZfyxFT2hqJ2T97m4XCjDcPjZtLr+SlIWzGOOjQbN9akeZJWAgsBHus2LC8Lfd0kpB9gV ktwXCg25fqB+eFeBycWcxmVtnN0j4WLPiz3vuz7Vyz4cGiOnSbg8k3urDsObuyHW3uFKReThY8Xn jeXXuPZMOOPcTqZsVzDZMKBu2ns75RmXDHgtkgbf3V4/DLTOBpMYnpA/yuD2KXJi9VI8u81wXKPq cNic5vlWHuFNWFEDkflVV+E5OIjr52SiUElw4KdV4xPVSB7tnBfQ0+KYTTNDRG123sifjOGzNc39 JGR72S1+F5fs4mDM1fDEWRtuHCxOm6QK3EKq4Y1xPewXNsxylga0sgbYGw2WSMxU7LOAbGTzYKWv w1z+nzDv4jTtcDHIAebtWLapBv6xdfV1WYtQvFI14PYhce/H3Wt5LD+ArZGv7OG1VZ2s8gfCfE2s c4FsTtvhcnHmOJg9dMP2CyWZpo/KdaEsej/4C/tnDH+Ih1/Lf/ZU6GvkOotc0rl4Mxkx2BB37pTs bMd3WDlL/oUcX5dcHafVcrMjypiVULtAcOeVX+ogHhxjDh7J1RmmVgDoCWX7A8K8+icEZkfHXO/l UcjwOC1STKONAESRlrhyxztwpHn3GadpbDWvYO1ljS5txOd5fJUukeeSe6Kw2gf9M4gXEPj027ko 48qV0jrNLP3NkmTMtZILOesV2KVLz6pnj8FXkzwcrLlLFKZupzbN99SQMuVF7lwH7rEbjVY1un9T IW+xKKTFqmw/mlOSmdBl2d7yGzBvyVmRZJrpxqbUR6Rzd1lwjMZnbb1m6yJMfqCweXIW++6nJeDl 3ZEdG0umrGNd7BYNRlR0Lh/xcb2/lce7G6l59UhcFjzVkkrr6jb8rXJODm48swPG1SL/AAVf+nYG mzpSAO91wDKqWP7XkfujfiE8gs6Qn91KkLR9LHljCnC8mI+SflP/ANJ4MGBzcYZL/wBI5XxxlLuT f8qtYFrXulNi0fXvwbDKNpDXib5Kxn0WGk+v0j4K+cdUPda7j/dUZi5tiSf3UqRbR9M3D8BJBMzw 7/bdZ0TctiPQ6EvP+++6+HumMl0C1v3VcX+kTR9c6DAKV5dG1zwezjdMMuCk6hGxp7AL4syuPdVq Km1+y2j7WnxbCqTUwwRyA8Ei6CTF8Ka30QNa7kgBfG6zdW5wO4TaNyPrDjNG8D+S23yE9mI4S63m 0sYPY2XxgkcO6t8pfyrtG4+4/wBcU+EkClooZTx6m7IMQ6gxV0TQcJp4Xd3tbuV8PdXc25P902jc fWvzpZgbHSxafYhL/wBaS3IFNGL9gF8rdWHEG91dpNx9XDn2ogDmtp4nA9nBCM91bTcQxN/AXyty pdNqG9n08mb31W72gOCH/UDtJc1+g/C+auopsG8+lbmmtiZ6ZWuHcOCH/VNQ9lnkA/AXztzZVum0 bjnWZkm1EPAN+Clf6gqon6rgi64dT91dqZNx9BFm+thNwfSeyOfOVW77LBfO6iVNZITai7jmX5pq pfuIJ91Tcx1Ft3HdcNZXYptRNzOWOOz3v5l/ynNzC9zgDzxdcEoptRdzOZnxl0mwdayR/FHk2LiF xqibUNzOROKTNPpldb2Vuxh5aNt/yuNuortJuM2TEXVBHmi4Q/rNJsxzwO3qWIom1DczkI8XmZt5 ji32KZ/Gp2MIa6wK4uyg2TaXczMOJzEkOeSqdXv/AKXFp97rFse4KqxKUiWzKZiEgN3Eu/KYMUkv f24WCoATwrSJbOQOMSl1ybrGkq3ySay43SLW5UslItsa2pe0k6ifglW2p0g2Gm/NkDIXyGzGOP4C ccOqtN/Ifb/7KcDkV5xtbsqdKTwVZpZhzE8f/gqfppf/AKbv7JwTkHzCAAiNQ890TaSZ/ETv7Jv8 Kq+0DnfgJwORP6l/b/Kp0xeSXb3TH4fUxC76eVg9ywhWzDamRupsLyPwnA5MfVvsoHEHlZDcNqnu IEDyR8JrMFrHXtA4paLyYQcQeUTZ5G8PKynYNWNBJp3gD3CqmwmpqnFrInXHNwlonJimRx5JKom6 +jpsk1UwDnuDR7d1kVWR6jyQ6D1hvKzvj+mtsj5Pj5UJXMOyvWxyNa+JwB72U/0vWucQ2Mmyu5Mm 1nEXJUDlzkeTsQkdYMA+SeFnN6e1+m73Nv2AKb1+imfK3+VV1z1RkzEYHW8oke6ZHkut9JlZoaVH OK9lUWz59jHP2aCfwoCW7EkfC+3pMvijaGhnPJWbJkOnrgJWv0E8hc/LEuxnXRcSpv77LsSPp7BA NcjXSBBPkahmZ/KEkb++615Yl8cjr1RfbT9OiWgwVJN/9wXHvyFWxzNaXNc09wtKcX7MuEl6Pmg4 iysvLjclfcQZEbHJaS8iOfJ1I2oDfLc0OWfLFF2SPgjuVLbLswdKYZ4dcc7m37HdNw/pxh8Eh/WP e5o9lnzQ/S+KX4dXcK7E8bruodP8uiPWwF59iUj/AEbh8b/5FO0A+6z54GvFI6ct8FVZdwjJ9M8n VTtt+FQyRQtaXPpw0/CvmiFhZ1C1hc4NANymSUkzDvG63uAu1avJ2HsLNLdL/hHT4BEzawLfwnmR fCzqPy3f7Tf8KxBI7hjj+Au4XYHhw2ewE/hW3BqW38lrR+Qp50Xws6dMT27FjgfwrMMoAvG7+y7a Zh0YfpfCxzveybJhtK62qFth8KvNEnhZ0+Yn/wC0/wBkYpZ9NxE634XbbcFw9/8A7QBPeydDg9K1 5boBaPhTzoLCzpt0T2/cxw/IVaXex/su7xhuGueWyQNt+EibC8JhlF6ZhB24Cz8iJfBI6ZEUh/oJ /ZGyinf9sLnfgLvNuDYOxjT+nYCVb8LooGF0TGgje1lPkr0FgZ0a/DaqNoc+mka08EtKD9HLr06C D8hd1S4gZgIvJYWj/c1cbUUcD5w4wtLvYBFqUy+BnWDMFqJBdoB+O6bHlytkNhGu1m4ZReXdsIa8 8rFmoxEf5YKfIQ8J1nLl2thbvGSsZuFVTnBvlOuV2vG3+Y1skdwe5C5uDpziONQipoYYzG3cknsn yFQWFnUkWRq+WJrxpF+xWPLlHEonW8m49wu0cQw+fB43MkH8wG1kynkMsIDm9lz+S/w14UdXxZMr ZWavS38opMm1TI9RIJ+F2XHQl4kF9LiNlj0mHTwwyMmIeCdiCr52TwnWrcrVUrw2MgkrKOQsTsDp Fvyvv6Wlip36nAcrPqGgsBDi0drFX5DQ8J1W7JmINeGloBTRket1Bt2kn2K7G0F7fUdat9LoZrbs VPkMvhOuZskVsTbhpdbmyWcnVhaHBhH5XZEeMOi2MV7d7LKZiEErQXRkO9k+Qy+A62pMmy6ryggf CyDk6BzrDW33K+6lla8ktFh+Eto807gWTzvs14UfCTZIAt5U5cPchKfkeojZ5nmNLQuxY44mXBaN 1Kemh1uMn2qrOzLwo67GSqioBe0WaBusV+WHtdybdyF22IqZsBbE6wPNwvnI6JzqmYXGi/pCvmJ4 T5WnyLJWkCGU3PuE8dPpIS5sslyPZfbUsLoyC12khMnkcX3J/dZeeXoLEvZ18/IU1zZ+3ZD/AKLd DfzXEj4C+3q6qQEGIXHsmRTOmDTIyyz55F8SOvv9KfzG6S4tJ4Kzo8mtnkGn0Ee6+1FI17ibAJM1 MGAg8DunnZnxI+TOVB53lyBv5CYMnUrb6wT8gr6JtO6a5Zy0K6ZjnMOvYp5mPGj5o5Upmn0C4+VG ZUYx327L6gxgEbcrLaxpaLgAp5maWOj5RmT6eRwLhYLKGTqNwA8vSfdfQupx+yk9K4sBEhA9lnzM 6eNfh81JkeKB1rhwO4Rsy7Hototb4XPwQvY/dxcPlXJG8OJ0DSr5mPEjgXZVjlbs0fuEEOUKWVxZ JEAfdfRh7SwaTYjlU86iN7J5X6HiRxUOVMOoSRoDne5SpcrYdPKA3Sw33suZAF73uflE6Jjt9IDv dTyyHjSMAZZo6dzfLia73JCGehhhszymn8BZ79VtIKoRh7fVyO6eSRdkTjzhlNIBaFur5CtuHQ/Y IGtPvZcl6GbjcoSC437LPkY2ISzB6Z8dnhp9xZKky3Rj7YWEfhZehwB5/ZW2XSLElTyMbEcUcDpo nABg/ICOOGCNjhG31cHZchbzBfhEyBly62yu9sigjGrdZpYo2N1hv9ICqljaXBr4gH24IXJ0zxEC 9rR+Ul7w6bWW7/hTfJG9iESE3tpGlYz42l27Bb8LktOrkLHkp5WyekavYKqbM+NGIJKaJpD6YE35 slMZTvlt5Y3PC5HQ+UjzItBCYKGMEECy15GPGjCfTQRs0iMFx72SYcNa5xc4kFcy2njIBcbW7oKi hcw+bquz4Wd7ZdiOLZhAkk3CyI6CGlB9AJWQKkFh0ixHBSHyOcwk7rO5l2JC3RRE3DQCeyn6eMDc Eg+ykTb7/wCVkR31DuruY2gRYNBE9s7ZCS7+kqVtOxjRqbce6fOXPAPFuAk1odUU4bufkJuZrajE p5Y6ORx8gOB7hcjHiEcsYDmi/wApEUAdAA/YhHFQXs7sUsKKQMhYPVsArY4O3bZG+lMb9LhcW7qh GGcBSxQxjWuHqAVsiZFqJH7JAfcAWIN019gG6u6lsu1AyNFQPQdNlGQ+XGSTcjuUWprdmoH3fwVb ZKA1Nl3IsQnGNhIdaykNPrPq2XInDdbGhoLj8KpijjSWgX7o2gN5NweybNA6IkGMi3uFhRyOe9wc LAIB0lQI9jwqcGyAFqJ0DXtQ+W2Jv3BQFNZY78ogQ02O6TLK1rQQbkIRVtds7Yn3QjM1ga083ukO iALtv7o4RHI1oErWuPuU2eilDxZzXNte7StXQOPZTaZC66Y6X1WHCt9K54NpQLfKTpEB9Tgb91bs o2NwudXCb5nskRyxPOkSDV7I5bg+mywyFiRrTe1igleDwbkpLi4AEg/lUJ422LrW91AA+47KoojI 0g7FOFTC++4RRzMHBCtCg2QWZaydEDGQCNj2STUAbg2WNJjcUbwx5/dAck+xKxJZv5vAuFjz1eoh 7H+lB/EaSRruTKO6W0UzoXm+oFZGgE6j3XE0VbqcSePlNnxmOnaS48KNkMvy9LzZwae10v8AU22J ufdYsVaK0argBA4xAm8tisWDYPVZzqqKEMknLr7XJWNTZlkq3guf6T3BWHnChpGMuJQHD+kFfMYf i9JC8U5efNOwX80ULR+2lOjsDDcwupq3RcvYTyOy7FoMQZUQMcHchdTYLSulm9I1XX21BS1UDAN7 BYfBuP6faTaZYxpN7DleJ/F84VdfTSE38t1vwvVVbj8mFUdQ+QcMIF+y8edeKuTFY3yPdq9d17NA 2syZx1DWxnSNO/UwXHys+nhDhqIXH004fdrRu3a65KA+m1l/Qk7SPyb7OJxJrhIbXsuGkeY5Svos Tc0Rnsvm5pNJLi24916oO0ePJ2Na8lvCTJEx7Tr3TWOuwG3ZIkYXOvfZdkchMTpGN0g2ATAw3JJu rA+EY42VsEa4NZYhFcdtkBF7bKybLQC52QnUNgUQ2Ve1/dACJS11iU3cnfdA9o8ywF1chcADwpQL lCx3zG1gm6tQ+Up1gQNKoGsLCxupo1e6IgnccLCkn8l97Xb3T4cTppGlglAd7IBguDuEV7t25U1a xshMgcPSNwhAnbDblKJIPCYN2lxQX3BUspbX3eeyWHEuO6ssLnEnYKNjt3RApo0m3F1drI3ECwsh cbBUF3AH/ZVsASeyA2J25V78EISwv1Gm3yidfYg8pErSW7BNpIyAfMP90KHpfs5vHdKe4SG3dE6U s1MH2+6GEBt+491AFHZt7hGH7FUSA1U03HwoAmybI7g+lIJs7a9kwPDv2VoAvswe6hLCzZF8He6U Yy0bIgCTewPKyGHS0ApUMWvck6gjL7j2sqCy0HjY+6U4EE23R6mkblQxkbtOyABthzuUZjbyOUpk gD7EfujEup+w2QhRdYgd0XbflCQJNwbFWQQ245UspekEgnn2TBe//hLhu0Ev3KPXfgKMlEeSXD2T miw2KUSUyP1jlQozSCyzSqdE1rQqZJqJaNiO6KxYLFSzQLYrN5upo9kV7KtQPdSwCAGnfcq9nHZW fnhDYHjYrXICuqsbKrkD3VXLhxZAELWQl26uxsli4PCWAibqatrKlZ44QFi9uLpZJBKNj3XsNh3S nPsSFpAO7g0qBxA3Cl7oW7qmQZW+YhbEP3TSNZ/CfFAXg+wQGO1psQSkTHQ/3CznwuaBtssedm5u EJQpkgvYFUJDfYXQiL2FlTWkEgDZDI1oBF/7oXMDrg7qmlzQW9lQuL90BYFmqvMEY3RxnYiyWGlz vUNggFEF8l9XpPZMbC1oOw2ULLvBAsjfcbEq2BDzZt7XHwge8Bg+eyyTYCyx6imDrHuiAAdcDaya wsPPKXY6QAh4IK0Sx0jgAA3+6S46SXOP4VuN3WUcA29/UewQyOgDr67XBRyVM9iLWjWMzEqinYdV OHs902KudVRH06B7IaQ13qa1zT2WC9hdKSnmTS3cpHm+ooRkINkNz7qyTq24UsOUIQPsTsqvdRxQ k22utAlkxjDIAAbBLDruATBKIgQFlgMt9VrodNj7oS82BG6LUCUBCwPNjz2TY23da1rIGi5BBWW0 6bencqMCngudqFtljPj1y3J/ZZVTRPcLi7QVithLTdx47ogZMJJIF+FTn/zCBskxzgO4TRE4nVzd RlC1bW7prGAjcpUnobcjb3QwS+lxbuQFBYL9DZgTfZPGmS/qt7LjPNdJIbrJigv6y7jsrRRkrWwH c3J4KEl29ibFBO86xfdU5xd32RCxTo/Xzf8AKKMDe4VOB7G4VsBstGQruJGnhWQT3VB5DgALBNNg CeEAmC8LiXcJglDnn5WFVTuvpTI7CG/JQGQyO5cSrbJZhB2CxhM+xA5KgeQLOQpmxSX9P+VTm3dY d1UErHCw5HdNdp0atrrPQopoa42vchExwYSAFiuNt2lZNOAWb8oaDb93yiGyGIt1nUbJxiH+4KAF vqBF0maURnfhZHogjcXuFh3usCOSKsL/AFi44CAJxMg5sPlDZ9rXBSpJvLG3IQiqEjNnDUtEY17t Q4ssZxJ47pu5Gxv+CgALnjsAqSihwFcsjY2c2VS/ymOcR+FiRvE7iHGxvsqQy4B541O3A4CaAGk2 bZHC6Omi9SCWUStu33UZS3fbe+6V5hDCG7lG2NwALgbe6Y2ABuobflCGDAXucRKbBPYRw0pdXA+U DSd/ZXHE8NA0m/fZCjHPDDp5KqB4LjflY3niGodrBIsrZUs1u0/5WiGRrJuFWst3aLlLY4kXurbX aXEFlwPhZAxriTfj3U80lLMjpd2tI+FHODG3cLD3VA0PLgi1CyCJnmC7DcfCqQPaLNaSVAG4gnbl U52ndK1vj2fA+54dZEGPfuGkn2RAt0hf/wDCmspULHtc7zGlpumxxOLibKsDHuAG6tkgbx3WNNT1 BN2glqbFC5wAUKE95a643BVFwJ9k6PCqiQ3Y4AexWNLQVTZCH8jgjuhAw7125UDbu34WKaeqY+7Q SU6KGpk+9hHzZUDC7TwhhJFWyQi4G9kzyHNHf5KsUkjnAt3/AAoUKacvJc42ueApHKxzebWRHDZX XBG6RNg9WG3YLj2ULyNbK1z+dlkQyiPYd1xjKKtB/wCS7ZZjIJmgFzCPdGDLLg0gk8oziEcDtIIu qigEzfU6zvlLqcB1EfzRd3ysFMaqxMSSW1b/AAiiq9LhvugfliVm5kH5UGX61oJje1wC1SJZmCtY 6W7tj2Vvrg9xs7hYn8KkdTESyBst0luCzeZpjna51vdKLdmUZQ9xk1Wb3RtrIJGDS657pENG6IOj mIKIYdExhdHsSlAaJWOH3aQEQqWFt2vBtzukswmJ4L3zlvwiOHRRn0m7fdQhDWxMu7UdSGWtY9u4 N1m/wmmq4dOoMI7rHGDQ69Latu3YlVFOPkqHkFrRcJbMQ8qQAjSR7rmH08NIACQ93wrNNQzC8sf7 hOAYX+oZ6e2hjHtS5sahqSHSw7+wXMRYRhoYHC/4JTKijw+SGxgG3cJwDg34jTinPl7PPZSgxDyi 5sjbX7rP/RYVCf6gSmx0+Gx+oO8y/unBLOObVesuA9KyYp2vIIFllSw0Xl6o/u9kkiFsY3DT8LNF AMwcbb37JFRi8lI4NILj7JjpowfkI2SU8dpZYxKB27qpfoMZ2JyVd3CIt+EDqytgZvERfglcjDjd DI+74dBHAPCyJ62KdoIDT7WVIcCMXxAAA7/Fk2KorZ5g8x2t7LM/VxRyEvaLrKGJwyNGkBtvZGDA qamaQkeU4H3suNMlU4lrA4G/svom15LfSQQPcIWY1aUtfAw37hZRTjzhuINp/O16iOWpDq3EHgAR lobzYLlWYy6nmcXbtI+1J/1K2B5Aha4Fa/6BgMxTEInWaw/2QFlW6QTyxE6juCN1zVPmWlBJfAA7 tslRZmNVUmMQtLb8qf8ACBx0mFVGITB0bfLPyqdgmJxPIaC4/wDSVzv8WjY8tcAPwkux79CC+Mhx +VbZODj4cIxpzCPWxtu5QxZexSN5dYi/zdNkzPXVkgcJBG0dgmjNUsd9TrkeyWDj34XijJ92OuOC eFkVmAYg6MStBdtuAuQjztencHsBd22TKDNOqne54AHtdLf4D56OjrZTpILSPdZcVHidwywLT7pt Viwqnl8bw1w7Jf8AHJ4RYuuUv+h0chR5Mq6skiqZATxvshr8h4rTM1ieOdo9nrihjs7dRMxJPyo3 MdWTYzO0flVWDLp8uPdY1UwHbTdZjso0723iqAD7XXB1GLPcNnk/kpUda8kuD3N+AVKfoWc2Mosd fVOPzdC/KrQLNmaXD3K4M4tPYjzDZDFiUwd6pHf3WqZNyOap8OhbOI5pA1nBN0ypy7RxyhzJ9TD7 FcVJU649X3flNoK1jjZ/p+SVKaF2ZzcuUjmbTEH5TxgFBDEC6Qu9x3XHTYpGHOaHccLEkxTfa5CV Ito5ttDgeoCSUs/KzG4LgczAIZw6T8r5CWs87loS2T+Wbt9J+CrTM2j6p+XqOOsbeQaO/smYhh+D QMAa3U8c2XzP8UmcA3USEk1MjpL6ipTK2j6IUeFyPaA0tWQKHDoHENYCR3K+eOJuBbwbd1f6++o6 uflRpsWfTx1FFG2xhjd73CS7E6COoJ/StHyAvl5J9UZdrOq/ASzWO0aRsfdVRbDkfYGfDask6AB8 hIGMYfDMIGxCMcarL5mGtdG3fcptRPFK0BzQH25RRfsm4+xfjtFQtEZYx4duNks5ioz/AOw23uQv h3zvNhe4Cozud3smxjcj7Z+MYa0a7Ae9kibMGHNILIy/4svjSTdQOsVrYN59c3HKOx00zbn3CoZl povuw2J5H9Vt18n5rv8AcVYlc3uU2f2TcfcszfSujH/BtBHayEZlbKCXQNDey+J899uVXmv/ANxU 2NjdR9r/AKniF2iFrfkhLdmaOGM2jaSeNl8cZHnuVQkI7psY3H07s5YjY6HRsj/2kLHObq5/3NYb /C4EyEi1lWs2twqok3H1VB1DxXDP+Q+No7tc265H/wBVa6c2khhjv9zmNAJXwV7qw6x91dqG4+7r Oosr4xc+Yf8AsuGGcKnzi7QC09rL50m5JtZUmxDcz7GPNEcrLvaGn2si/wBUOjiIbb8r42591NZt a+ymwbjmf9R1bJnO88kHgeyezN1fGRZzXge6+eUWto3M+sZnWpkcC7S1wQVOaZap93yuH4K+W391 LlZ2Iu4+klx90rQBIfyky4r6fS/1e4XA3UV2Ib2c1S5iqoA4OlJ37pozfWsd6ZXAfBXAXvyVFdqJ vZz8uaKucf8AOLUgY7VagRUPafhy4cKLOxDcznXY9UOjImqXy37OddYb8ZlD7sJaPZcdbblS6qik Tcck3GJHHU9xJUkxZ8u2ohvwuN/ZTSbK7UVSZzNLjToXAlxI9il4jjstU70fyx7BcWQdtlLF3uSp tQcmxj6qWS+p5P5KESO3sbfur/Tynfy3f2RNpJnD0xOP7LXBLY6LEpImaLkj5U/itQD6XafwkCml uR5br/hWKOc8ROP4ClRFsuWulndqe65QGdx7qOppWcxuH7K20kzhcRu/srSFsEyG9wTdW2okb/WU RpJ2mxifc/Cb/CKywPkPt+E4JyY5mce90Tal7RYG34THYbUtO8Dx+yKPCqqW+mF1/wAKcF5Empee 6HznHk7rkmZarnM1CO3wVbssYg1ocYbg/KWhycWXkjlDdcoMuVpdbyrJoypXA+pgDfe6WkKbOGUD iO6505TqgLtc38JTssVgcAQP2TcmKZxQleO6p0jnm5K5duVK9xt5dr8EopMpVsRsQ0n4KWhTOGbI Wg2NlbZSDflc5Dk2tmI4b+UTsl1cbrPc23wm6JakcD5xN7oL3X0LcnVBsdQWRHlAAWke6/uFN0UN smfLhxbwbK/Mda119QcjukbeKffsHBXFkosFppP7BTfEbJHypJKr919mcjQN9RqrA72sgnyVG1l2 SFw9wnkiXYz4+yi+wZkRsjGuFQR7ghM/9PnW2l1JviTYz4tRfYv6fytsRJssmkyFEQfOkcfwnkiX xs+FKi++PT6nAP8ANd8Epb+n8ZbdkhP4TyRHjl+Hwqll91SZChY680jnezQuXiyLQyC+gMI9+6jy xRqOKTOrrFRdrNyJh7wW3GpY1RkKlbfTZTzRL4ZHWVipb23XY0GU6aCSxY15+VyLMm4c+LX5QEnw FnzxQ8TOq/Jfa9tlXlu/2ldoOyZA8GzQArjyxS04s+K/ynmQ8TOsGU8j/tYSrNPK3mM/2XZrsGp4 XXZEAPlU6ngLbOpgT7gK+VDxM6w0kGxabo2U0sguyNzh8BdjtwWkkdqMIse1lyVLQU8Fg2No/AR5 UTxs6kfBJH90bm/ltlcVPJM8Na0kn4XcBoIpNQ8thv3ISH4NTUsjC2NocfYLPnRfEzq5+EVbHWML v7IThdUP/Zcfwu2XOibbU1u3uFgVMLZKi8dm6vYJ5S+I6xfRVDBd0LwPlpQeTJ/scP2XasED4Xfz ND2fIWS2jopT6oGWPwr5kTxM6njw6eX7WFGzCKuR2lsLyfgLt6PC6NxAjha0fhXUU36Ro8mMbdwF nzI2sJ1RJlvEIwC6nc24uFUWAVkjgCzT+V2lNWPnDSbBzRaxCw2wfqHX0gH4V8w8J8OzJtTIzUHt v7JcuTcQjt6QQeLLtCOgYI2kN0lLkgtLfmy5+c34EdYHKWID/wBtOhybVEXl9AXZEWoHSfV+yZ5L ZXeoWVeciwHWcmTqkH+U7V+yQcqYg0/8u67PdTOjddmwKa0Ax6XD1D4WfOHgOq3ZVrmHdlvysiky XV1Dt3NDe5G6+9nweSokJ87Q1Khw6qw6pDoz5jD7K+cw8VHxz8jTtk0iQfkhLdkatB2cx37rsGYS SOJc2xVQWD977LPyGXxI67OT6uM2fsnRZOkkNvU0+67LjEM7bkXISqmNhsGncJ8hlWFHX0mQpw30 yXKQckVYF9bSF946nn80OBu0dllGjEgvbda85rwo+IwzpvV184Y57Y2H+o9k2Xpu6hqXsqKgPiHD o19rSNlDi1jy0BZc0TBQua71Sk8lc3nl6NeFM69/0XR2IbM78lW3IIe0vjk1NC+1pqeIXD2B1+U5 tLGG3aLBTzyHgPgRlkU1tcIkVHKDJ/VoMY+F946ma42sCgEOkkWsnmY8SPiJMjQOj1Ryvv3um0uQ om+uSTWP9q+zihFiDwUfltYy6vmdDwo+fp8sUTAGuha63uFlf6PoZW3/AE4t8BZ7xqAtsPdMhjn2 8uTSFjyP9N+NHzlVkuja/Sxlmn3RuyZRxWMb2g27hfSNZK6S8zg4dk19DFMzS61vyr5pE8SPmDk+ mdFrJY4nlJZlijBt5IJHwvon4a1psHEW4F0QpTDx3U8rHjT4MLDcNpcOe1/kMd8ELkny0dRJ6YQA OwCgp7gFyJtO3+kWK5vK2aUUlRi1NLC8OLIWH8hY0eHwubZ0Db+9lzAgLYzYJb4X2u0WTyMztTOL kwmJ7SBCBbuAlw4Uxrh69Dh8LmYjI/aw290wReY6z2DbuFrysvjRxslZURubC2KOVnBLm8q4o9Tj 5kLAO1guTEVr6ALK/wBOLlzt/hPLKi+NHHyQN0lscbWg8khY8WDhj73sVybogWW/dEZBotbcLPkk VQRhmgMZtpDr+4QMw2KO7msAcT2WYanUPwlB3q2Wd8mTYr6CFBD5eomzlUNO2InQSWnlp4Qvdt7K hIW2tcrPJqkFHRSSyuc4gtHAWO+i8tzi0C6zopXcWNrKnSGxAbdaTaG1HHta48tss2C5agNNI31e 6WHOEgABHuruYUUZTnktI5VGa8QY9rbD2QsBuSUPlOeHAI2zW1CzHHe4AslF8cJ21W+FlMpza1v3 RsgY13qAJ7qDahAc6oG0hA7Aq4oSw2LrrKniDWBzGi3wsZzw9gLWaLbEI2y0hrS0DjYK7Nc69lht 1te642T4pLgAf5QUjJbGwA25Sv0rZZAXblMY+5tbcJoYTwsOwkF5roGloOyx2vMhIIJupUNfqAWR BT/y7A2csUaMKSnkieC02HsqYakO9Drflcs6ml0AyWd7WSJKcjhu6peDEfUVsY3DT+FUNdIwETXd f/Cyv05IuLt+Cq8ppk0lm57qocCHkVBG1vlGYtIFksAslLbHSstsV2g8rXJngxHtaw3LQUqxjFy2 wWXVQhrblY1nO2O4VbFkOmUbbFWKNxtvdWWthAdwfZNjrAO6WQS5mhtiBcJVy07BNmmb6jdY4eHH ZwUA0O1jgBJdQfqZgS78I/UBexI90+B4a8b7+ygFy4bKbAyEtCIQyBrR2C5ihbDNM2OaRsZJtuU3 FaClpH6GVDXnm7XKdA4CSAg+ptr90o02l+oblcjI1j3ACobce5SvILi4h7dvlaQMZrrG1v2RkNcL 2sVbjDf/AJrQfyqMkDCLzMJ+CoRkmpXztaAbAb3XJYbjlbhxEcU7mtHIB2XFOxOD1fzht8rG/iDA SRI034F1asnRy+NVZrhqf6nFcdTl0Zu8Wb2SRiUMTgZHC/5ROzDhbSW1ElieCAiRTJdKX7gWHurv Zt73usc4zhbmARVIPwksxKAixd+ChOB/8Ok1ea8+jsExzvRbkJLsx01Mzynu1g9ko47QObe+lWgZ 0LBINtlkCk80W3AWCzF6FgD2zX+FnQZmo4hewPyVOUVGPLh7N9BsR2KUIXAEaR8LKOa8KlkLQ9ok 9lh12YqWmIkJ1D2CpQjBva2/slyQyRg7EfCw35phrnNEI0uCKbHHh2ksLj7hAN88DkFUakcA3v2W J/F4gSHssh/iFMXtdbhVA5aKSSWLQ1tyULaIwOJeDcrizmAU8/8AKBsjjzlC6YtmaSFWZOYjY3SS DusZzXSggi264qfNLKeW8MZeDwEk5ufI8h1MWn4UpkOVaBESDYo3SekELhm4/DYucxwd8hPizPSc vbcJQOVY82JR3bKyxXDnNVGHDQwn4QjMolJAgLQeCQlUTg5Yeg6YxzsnGAiIEtXAz4hObGMbpRxi rHoL9LvlQtHNPuw2LCB22Rxv1HTf8LgDjeJWtoEllj1WPYm0DTR3Pu0LSi30Xo+sMEreDe/ZR8by NJXyEeYsTa1oEZa7vcJtTj2JvABjt8hNv6XcfTCYtdpA4VeRKbkPJB/wvm6fF6yGLzPKLn/hUzFM UxBxDQY/kBaJZ9Kym0OuH3PdNbTOcNRtb8r5N8OKw3OpxHwsZ8eKTNv+okYD2VSsh9q6maCNL91Z ieLcH8L5WljxGOnH87W8e5RSVmJhne47rNUyn0r4nNuSNJSy8GE+/uvl/wBTi0rv+YQO4Ky4Za9o 0vALDyUZDlopbEgkbe6fHKHkjUFxIY9wHKA0072kRkhyiBzZcI9zIP3KXdr3G7m7/K4FuD1srv5k pDfykPwyua+zC424srSB9DVTtpW3J2COmxigkLQ95Z7rgm01TG0NqCf3Vtw9xcHEXCFPp5K+ia0+ VMC0e5WBUYnGftIv2XHDCjMLgafhMODu07bGyFsyJMYbC0eYbfhZTMbg9Je6wtyuCly3JJ6jIXH2 KY3BZnQaSQqLOckxmhcbicF3ynU9XHM24ka38lfN02V3CUPf6t02twd0kgGl8du4WXRTl63E6do0 FwPvZJOZab9P5QdcDsuNkwdrWAgl7u6xqHBHx1pdJCWsd7qfX2DKGaqCN5YXEO+QnxY9TPj7ElTE MJpPLDxTNJHeyTDgTJI9WjTf2W7h6M0x5xeNjmhjNRPsswVbHNHpsVxzcLMB2YT8rIFFK8W3Hwpa LyVW4n5JaLXBSH42/TZjbD2TZMJe5wuLlGzA3HgbpaHJjfxYv5Cv+MTu0+W4AN3sVlnL0jr+gj8L CnwieKTQ2J2kn7lnci0x0mOVDnXltZAc0RwODXRF1+65A5ffURtGk2typ/pG+2xK0mmKZxmJZrkp WtfDTB9/hZNFjzcQgD5GaD7LKmwjy4Wskivba9kH8GIZZkWlv4VtAQzEC5x0i/5WLLXSxyFwG3su RZgE7RsETcCmcT6brFo00ziaXNEzi5rY/UOLhC/GcWcSYqgxG99lyrMtzeYLMH5tuuSjy9aM6m79 7qqcV2Z2s+fbjOLOg/myNkaeT3RNrn6Q5wufhc2Mv3B0C49lP9OPAsGrW6JGmcNNjL42Boad1x9T ilS52hjCb9/ZfZwZbLxZ7L27kJdRgLGzBrW2J72U3IlM+QbHX6QQNV+yXJ/EPM0yM0t7Ffb0eByx XuQRf2WfNgLqmMfy9x3WXkSKos6zkpJZiQ5z2n3BRxPrKFptO8gdibrsBuWdQto3CF2WGO2LE8sW VwZ8Dqqpdy92/ssuCSUxhpubc3X3EOTySPQdP4T/APSke4DN08kUFjkfE+SxrmuDCH+6wpziEb3E btPC7AOVdzcWH4RDKmsbC9kWSJrxyOtm1WIabvBIHZZcdLPUxapAWjsF2B/pXQ3/AJe/4UOXPSBp TfEeOR10aSVt7XTo2SBncfK+7my03jSltyyCNxayu9Gdkj4+OGQgXJ3SKjDi8E2uexX3rMr69tBI /CccsuFhp2XN5Y2bWJs66paGdzSx3pF1kOwl0TTbc/C7Bjyve5LL/Nk3/TrGs3ZY/Kz54mvCzrmn oZGtN7qOwk1I0uBK7COXmOHpCZBlkj7AsvMh4mda/wCkq4uvA86fZC7JlbI7UXuBPa67abgUsbAQ CEJwCRxvbn4KizfhPCegc1YHWUNQ4yPc+3cr5+hwiarqY5WtI0lemsxZLp8Xgdawcvk6LIZpZg3T ZoO5X87jkVH65wthdOsKfJBqc3UT3svvIwyKTS5vHKdguHR4fTNZE0Cw3IR1FI98rnNGy5ykdYxP j+oUEUmX55hYb22XjnrBC6KF8Ljba4XrLqY2piwtsYaSzVqXkvq9LNiNfI9zNLWM0gfhe7SP/Yjy alpRZ0lC39PIbclcjTkmxvyuLp2GWaRr3BpB2XIRRShjdLr25K/oEP4qz8tLmVgYqwfp3XO9l8zT OcY3NeL7919RXxOdGBzZfOzMMUhB7r1QPNkKBFrdkDtIOnkpjR2tsiMLSC61iF3OBjmzXfCtSTj5 CW195Bq2+UA4jSzUEJOwPumVjg2DSO6BsXlxssb7KoEsqNwhHrPNlGkxyG5uFQMYbnflBMSTsdlG kg7b3RaO55QAeXp3HKg9Tt+UbnDR/hKaeTzYJYKhMbQ9r23Lz3QyYBS08jZQ4ucd7X4RC4iLtNyE kSuc0uc7f2VBltiDDsdiodMTrgc8rGpi5+4NwmueRqFrlCUTWXPtb0o3SNuGgDZY8Muk77juiDLS ahwUKO5JtsoSGjkXQarcbIRG5zrkoQVU1GgaW7uWKKmZ0zWu2vwEVdGYn6gNR7Jf6SWUNkLtKDkz gXair3c7fsmvmjjZG1h1m25QFwcEICJhqtymOJcQWnbukRR3J23TWei4PCGi6iRunYWSortBJOyq Rwc6xUtaw7IBmoW52V3FjZCGqwz0/KAYGjRdUw89lCbjZU9jngFpAQDQb2UtqNuEDZWjYkXCsOBJ IQFsBaDY2VvDSPdEwtew77oH2DSpYFOaXWsEcjRpaGu9XcJZlIabCyw31AiPmbk34CWQy54xG0+6 FhPliw3KqokE0AdvdXTvsy1t0sljmENADhYp76UuYDwrhnpRbzX2f7JVdi0THBjeFDRQiLnaRysj yiGW2uFjisY8B1wCnxzCXghZYKv6bHlUWWIsTZW9tmnbdKDy7c7WULRkNa1puNkd9RF0tkgcACOU b2hh2OpChE22shETSgdMGc/5U8/W3Y2+VaBbrNNgq0gj2S3Ptc90t1SWMJG5VAUzyBccqmSlw32S X1zNIvse6tkjXG4Nx8IDL1DSDdWHsJ3SLei6Wx2p23ZCWZRI7JMhu4BEWkC/ZY73u1XAQtjXB4Jt sltLg7cA/lY7q0tFk2ObzQLA3VM2ZIO9+3sqdIAULmutsCEAu51ngj9lbNBEP162EW7hNjmkjO26 x3OfHAS0XClNVPcCS0qXZkyjXucbFtlReHm7tyFjvc7QXad/lLFVoG4N/hAZr2gmzUhzQ2/ugdUC UjSbFX6jsWlaI0Ub2O26XzfsVlROL7DyzpHeyROxzprNFghKChOoWPKtzgzayNlFKGag0lyA0FZK 8BsZB+VLKWwsANyCeyCWA6Ad1RwKvc65buPZGaHEiACwgD3CWKMQXvvsU0N8xt0yShqGNu6O6bhe DV1Y8ta3R7auFTJxrnFh3SpG6rWK5qryxXayx7QHf9KwhgVRDPolDgOxVsjMAMJk5RP1O24IXKjL 7nt1sfpsqdgs7t7bhW0KONineWFhuoJGxNLQDdcnHgk0Ump4uCmR4Tre7b+6lijgy4yC3CKOAuds eFzT8sTOHmMtpPsUVPgz4nkONgdkslHz7i/URtZGwX5N1zX+mHskL2uuObIjlWpld5gOgHslijgT G/VfYtVBhcbj+6512WTFzISEiWhaxrmt2K1Yo4qVpjINwgc/3F19DSYDSVULTLI5r1nDKdIxuptQ XD2WdyFM+Pa42/8ACcwC5JNgF9Q7LOGljnSSOA+EcWC4e+PQ123uVNxaPlqYNkls1FVzSU5NnWt7 r6MYTDTus0be6dBh1LKSJYxILKWWj4sY/WMu0uDh8hRmI+e069newX3keX8KmBLmtafYlBJl3C6V 2t+gD3BWtyFM+JhLw4Ai991lNdJ5RI4C+kdHhLRq7j2VRw0kYMkbQ+M+6lij5+Oc1EehzLdrlYhg roSfKiLm+4X10rKJ8Tbx2ueyp4igaPLft7ImGj5OlppakubJC6N3uRZchHQGCL1XJHZcxLVRODQb f2VVFRCCBtuq2DhJqKWRhcza3usEwzX0aTdc7JicMNwWlx42QQ4rTEnU0AqWDjKeimvpc0rJ/hkm 2xXN0eJUko9T2tPysv8AUQO2Dmn90sHzcuE1JjvHCXH3CwHUOIMJL4zYL6ifEJ6N38uQafYrFqcz sHpez1lWyUfNmiqHG/lOd+AsyDDZnMt5Tm/kLlKPF2NfqBGkrKfmFuq7WNNkslHByYHVhgcxlr8F LbgFU7eQ3PwuUmx2dzxK4jQD9g9lyE+ZaTymWaGmyWao+aGFVkUgY2AuJ7hZkeX66VhOzGdwVnVl WYIxVw1Fv+m/Kwhmh0xNtvdTscIXJlyeEEmXZcizCS2Jjbb25WNDjDHwljpLuJvcps+MSNiBY7UQ NlQBPgUshs0kFIdlisI/5hASX5jqC65cGH3TafMlQHu1yhzVAEcpTzCxqCfgoYcoSxyAtk9SKbMk kcRdHuUyjxwzU2tzwH+11eSGUcoujGqZ4Jd2CGTLNK1tt7/BWDUZneG6AS4j3WI3MMuoOudt1KZe Dl25SpNNzVOjf7LHOCNbPoa/UOxSnY62qI1Os4hLqMR0gGN/qCcjg5qly0ZC4TuYI7bbqpMpUMNy 2Zgf2N18s/F6tpcTK4g9rqm4uZG2kuT7gq8h0fRjBoowdTmvA4Q/wmIMLw4AN3suMpalz2XD9vYl Mkqn6TcnSs8+wuTKmewhrLAj3WVT0tO8tD7FfNvrXRjbhC/FXBtgbbdlqgfXR4PRRvLzK23tdLnw 6na4uhfdvfdfGsrC593uf+xWVHWuDdLJyB7XSmTg5/8Ah9LJfzACfdRuF4c0iwBB5XBS4nLG0Au2 91iz18srbNNh8KpMnCPsJMAwqOHzfNA76QULaTC5G2jkAcPdfFtqZmm5c4gdiVZrHXu3Y/CtNC0f XCGniJHpPylSuowPU0OHsvmTiM23qP7qjiDnOBPCUyWjnWywB/8AIj0BZ0FTDT/cwEnuVwBxqMQa WR2f7rDfiMszdLiB8pTY3I+vlr4ZgQ/TYcbIad9K0hxLQSV8WaiQEjWT+6JtU9vDk2su5H3dTT0E rQ4TM1ey4t3k+Y5oP7hfLec7Vq1EfunxVfdziCP8ptZLRzPnvgfYOBaVbJm6vSAuGkrC14IN/wAp Qq36y4Gw9k2sln1NPWtbqvuFTsWp33abXXzbK54a4EXBSo5Q1rgRuU2ls+k/ibGuswBG3E2yyBlm /JXy/nuAsO6EzP8Acj8K7RZ9bJXUcN/MF/gLFbjlLHKPKZYfK+aLyeTc/KsnvZXaTcfTfxQvl1hw A9kx+PCA3Fn27L5ZsjhwTdW0yNvsTdTaa3H1Dc0PqgWCIRgd0uXFiWWI3XAwB8e4uCUEs0hJuCP2 U2hs5R1WS/UHW+EmSuc2UPe87exXG63kd1flyuFzG4j8KqKMuRzIxoyNA1n8FZUON3ZpvpHC+aLX dmuH7KyXltrGyOI3HK1uIue+8ZJHdY/6siRsgu1w+VgtD7+kHdH5M1v+W4j8K0FI5T+Jecb33TBV Na24cuIFNMb2jeP2Kv8ATzjbQ7+ybUW2cpLVg2u6wQNxARHUXXb7LEbhNZI3UIzb2SH0FSz7oX/2 SkS2Zz8TdI4lji26w3y2dfUb390ryZGu06HX9rJ8eFVU27Ynf2SkiWx8eJgAXBJHuly4m93BsPZF /AqstuI9/buqdgdc3f8ATvP4CcC2V/FKgNtqICE4jOSLvKj8Nq2D1wvb+QkmkmB+x39leBbGuxGV wsbEJP6h572CbDh0817Rn91kjAaki+iylxLyzGbXytGkFC+skcbkrIdgdW3iMn5QjBqo8st+VeCW xTKx+rckhPhqWarucfwU3/TtT5YcC38Jb8BrW2/lXv7KcFtiamQTv9JAQ+ZLTAevbsnnA6poHosU cOX62pdpDD+6vBOTBfUvkN3G6kc7ozsSuS/01UgkEgfBTYcp1Mh9Tmtb7qXEnJx/614ZYXSjUvJv exX00WQKmVt2Tt/dLnyFiURt6HN97rNxN02j5szyXuXEoS8uddfRsyRVONnODU05AqRv5gstXElS Pmntuy4dc+yGKZ0TgQbFfTuyFP8A0zsB+VUeQqlzyDI38hN0RtkfOuqnyOuTdLLye6+plyBUM3bK D+yxZ8j18I1elwPClxFSPntbhcAqiT7rnoclYnILmLQ33JRjJNbq9RaAtbomabOADhYi37qa36NP Db3X1Lcj7A+f+RZPbkbz3ACRTdEu2R8c1xab8fIROlJFjz7r7OTpw5gv55PwAmR5HgbZshJ+Rspv iVRkfDX3B7I3PYSNIIX278iwhlw8/CAZCjIBLyB8KeSJdrR8Tcc8oQ4jgr7yPIdM0gmRx+FkMydh 7hpdG4drp5YovjbOulYaTwLrsmPIlCxxsXEfKfHkGmkN2uDWqeWI8TOsLubtuPhE17fLII9XZdoT 5HoNtIJIG5QtyRhwaHFt1PLEvikdW7lQtPsuzpso4a4Wa3T8+yxp8ixQsD4ZPMaTxZXyxM+OR12G OPAKLyX/AO0rsqHKzBGbxAOHuEbcvRAbsAPtZTzIviZ1gAWngq3OuLW2Xajcr0Lm3dEC72Q/6Wop G70zRbgp5Yjxs6sA9wrawngFdr02WaKN3qhafghZhwKgi0gUjCDybKeaJfEzp0xvP9JRCmlLbiNx H4XbX8Iw4PINOAPwsmLBaAi7WNAUedIvhb7OmjG8csI/ZRsb5DYNcT+F3S3B6IcwsIPuEFVhuH0j f5VO0vO+wWfkRHhZ1AzDqiQbROH5TIcDrpwTHTvfbmwuu2G4dTTQhzodH4CujpGUTyGbA/CnyF6N LCzqM4XVhxDoHtI7EWUGE1PeIgLuWTDYqhvmkNBPwsSXCYT/AEix+FVnTI8LR1O7CKgWswkJjcBq 3RF4YSR2C7Obg4e7Rb08bpzcGbS3aN/lXzBYWdV0WCVNZLo0FtvdZ/8Ao2r1W2K7EiwlsBMhtusg QB+4CPMaWH9OrKjK1dA6wjc75CpmVMTkbqFOSF2t5Dm2Frg+6YWtBa15LW/HZZ89FeA6hZlrEZJN H6ZwITzlDErbQkrtl1NG1wMT7/8AlVG28mk8FR6gLAdTDKOIWuYtI+VlwZHq5W3LwCu1RRskNnO9 KxHYcNZLXGw9ln5DNeBHWcuSquLk3VwZPlfcPJH4C7Iijlc9zZWANHCS6IiUta3a6fIY8B1+cjVU rv5BLwOdkbMiVTSfNuP2XYQbJEQYnaPhXFVTSF0TrH/qss+eRPCj4CTIM5A8p5cT2spT5N0XZPqD /gLsLVLDZ0bR+UcTfMlDnt9RV+RJlWFHwUmRI9Pokdci+4WNLkeYHa9vddmueIXAeU1w4uhkDJzY gAeyz55IrwnWUeRpXOs59lycHT6OMNc9xd3X3LKRodxdC+mk30u/ZXztkWGj452WIITp8kOA9wsZ +WaaR1vJsPcL7gQaQA8C6IU7NFg0BTzseJHxEWSqWR3qLh8LM/0DRyQiztLr2+V9c2nZo1AC/sgl gMrbtbZ3wsvMwsR8s/ppRRt1OqHDbi6lHkGibcvDnge5X07IpHW8w3+FlNgsAAbLXmkaWKJ8yzKG GtdtFf4KyW5awxv3U7T8BczLAGk2Nj7LFcSxxuQs+V/prxo43/SOGzO9MVvhMZk6iYLspm3HdZ7J Cy5usuKp1EAm23CjyyNLEjiZcOhYzQYm6RtsEEOG04NmtH9lzTtFjqF7oPKYw3AAKPKx41+HES4R G4H+WP7LHGDMY7gA/hfQar7C10vQZJOFPKzLxxOL/hbWNsQ19+9kMeFwgm7G/wBlzvkNaNxukvib p9PKjysniRx7KCnYWufEHW+Eb8KZMfMb6QeBZZQPljcj8FC6R2mw2CnlkV40cdJQukfpYwOcPcJ4 w5kbb6Rq+FnU9XHANIA1nuikj0fzLhwKeWRnxowBTxCMhzfUsJ1MbelxBvwuacxshBA5SJKR0jvR 2RZH7NbTEipmuAvyU91I0tsRcIS0xGz27hMa88kqvIwooxn0IH2t2RR0Yc3jdZrJBzymEB+4Fvwp 5Gb2owY6KRz+1kE+FO80OaeOQuSDXE7FWP5d9Z5TyMvjRgRU+ghpF1kfpWvaSRumbBxsLjndA2QD gjfspuY2oEYe0Rm4HwEo0rbWLQswOJICXK4MdYndNzFIxxRgWsAEbqNj2nYXRGYM5uETJWHh11nc yUjDjw+I1IbILxdyVyRw6nLA2NwDR2VCJsg2sqbROa/VYj4TcxSBfSRtAAt+UcdNHosePhDM5zHA adlkh7WMGo8pubLtQETIGvDbm591i1cbqKosD6XcLJmIBa5jeO6KZprtBI4U3MtJHHSzTj0MjDwe SmeSWMGptiVyMYbCQNKTK3z382C0mymJYW35SWySz1DGMJaL7rKfQzOkDmWLVkPgfTSRuEdipY4L kwx1K7WDuebrEqHEk78+y5mpa+WmBebOtwuLfSvcPS3VspYOOip9Euu5JPuuRhIG6QKSUekNNymF kkbQHNsUZkZJLYWakSFzxZyc1jnWGmxKcKFzh7oDjHxB5AUfTggWXIOw52q4IUjpHXN1bZDjxSXc PZR0JadLBce6zJGiE7/91UVZGwEG1lbFCWRva5oaVkVVFDPpe6QteBwqhj1v1xvDk2WEvkBNvlLK cRLSNkcWb291KehZS+knVc8+y5V5pY7h7mtI73SpKenkAcyYE/BW7I0KqKRrYWn/AHLEfGGHT3XJ VFi2MDcDkhYsoYQTcbdypYouCTSLJ5qCBxcIad1NcNMzdXfdPLIb2D2kIwYL4Gyuvb+yuKB0ZJts sh8bGWIlDQflBJKWODQdSllHxyh7APbshLL3ICjccoaVobKWsesepxymLtUFnBQ0U7Uz+lWyUn+m w90EGM09Sw6nBjhyEZqYTFq81oHtdKAwm5v2RAF5DmtukHG6GBoEr2iykedsKhuxpBHuArQs5Bse obxl3wrfJFFHZzNJ4F1hjOOHC72SWcRwuWoqzCcXpfNlrImlu+lxAWeRwcRPG6UXYf2Q/p7REcuW NimacNp53Mpn+aRtYcLEZnOmIsYSLd1aZmrOSooJoAWvYS0nlZUlMwHdha5cZ/runs20JNli1HUG lmIbJTuA7FXay8I5sM0yAduE0RlpAA2K4dmc8Phgu/l3GyYc4QuiGiLY8FRxY4ObETWAnYFYzy25 bf1HjdfNPzfKHE+VskS5x1SskkpnWG2ybWxdH1jaUsa73KBsMzAbsNuy+cjzxUtBLIRpPGpCM6Vp lvouFKYs+miY4vAII91Klmk8XXzzc3zOcGOjNz3Vy50ippAJGl3uAtU/Q/5Oee9rGWDTY/4SHu9H p3+Fwjs9xOs2OnLnFMbmJxsXQWce3sjTXZTljG8xbDcrIhieA0W3XzZzFWNl0tZZiYMw1uvUGXt7 KUD6l9OdIDmm522UdhrgARJsflfJy5wxBoc1rA4nYbcLin47jJfcOIF+FdrZmzsF1M5lruF1Zh07 3uF17Ni+NyPYQ86R2XJMxGtDbyPdqdyCo417B9PLIA4i4/unUxY5w9Q/uvlG1c7gS+4J91jymrk/ 5cpas0Rs7KpaL9RsJY2Af7iqqMHq4PWfLkj92uXWhpMRqLNM8l/gqHC8TY7bEJ2f9JcbLSin7B2B JE2IjUQ2/uqbG5zXtBa49rLruZuJaQHVL36eLlLinxVlgJnAe91NtlujstgigY0OewP77q3+Tcfz GEH2K6ylhr5Ddz5JHHvdI8iv+wTSMP5VUV7FnaktFCI7umawni5WI8RRusZWH5BXXsVBiE+8tTI6 3G6F9DVD0+c/+5WtiRbPuzV0FJPaSoaAe10MuIYebkTNAPsV8G7BpaixeXOt3TW4DI5truATajNn 2ra2gcL/AKho/JTWV9DEDeZh+br4X/T79FiXH90o4DVg2aTp+SrtRLOwBjGHPF21LQ/iyt+K0MNi 6Rpvybr4AYHLC8F42+CsquwhpijD3uYHfKUjSZ9q7MeGCMETgn2ulPx3C7ajK3Ud7hfFOyxSxeWY ah0hcPUD2VjCY4Tpa0uPyjivTLZ9VJnTBIBpbKXu/Cw5OoFFrtDHt7lcRLglOxgcYQHHuFbcsQSs uW/4V+o5OYhz1RSu9RsR2WQ7NVBKz0yNDiuEZlWFot5YJPdSXKMFidLmH4Kj2ls5N2bYaRhY3+YF KfNlLNcFmkn3XExYC37bGw90xuBMY+xbYKUiHPNxRsUZm0tdEFjnNtC9wAaGkLiKqCWEeVZwhPOy ScsfqCHRXAUpCz6D/UMbnHSLg8KnZoZACx1m3OxKxKPLMrS2/wDdJxjLwfNGwknfspSKcu3HWPgL ti4LGlzR5I0htye6THgpBEbAdICOXArPAcFjgqtixmeue27Wgs7JUmbq9uwjsfdPODvj9IG3uljD ZdR/lFwHwrwORc2e6gwWdH/MHcBce7NGIznUwFo/C5ZmGjWA6G35Cy4qB7yI2wANvzZW0kQ4Khzd XxzFk8ev5ss2TMldGdborNPC5x+VrgP8u37KzgDpW2sbDsVN0WWmfP0+P1lZKRIbN9lKirqW+Y5j y3SNlzL8uuif6Wm/4VnBXiIgNuT7hTci7XR85TYnWfp3PlJcR7q6fEKmYagueiy9KYnamen8LFiy 5I6XTGXA+1lbizNMwJZqgsN3G6w3vqrWa5zflfaxZNq3U+q2p3tblYUmBzNeWOhcHjtZLQ2s+djr MSpmgmXUz2WLNi1XO+zHFpHcL7BuW5HtGth/CtuWAOGWP4Rziu2TbI+NcyvqTd0r7nuCjfSVkUO8 8hNu5X3MWBCNti3f5TJMumVtrXWfJE1sZ1iw4g6S7ZXah8rKa7FH31SuAPO67AZkh5BlawlLjwBz zoEZDhzsunkTJtZ8NBQ1FTs+Zzf3QvwGrDtLJnOuebr72XKTnAEMIPwqGWp43D0uATekNjZ8Z/CH xlrXtc8e490YwNgGoyvY72X3jcvyuAJaf7LHkwctfpMbifwsqaI4yR8W/DgwW1ucfdKfhokIJbqP yvvWZUklcHFhH7J0mVXMFywopL9Ciz4EYRG3cs0lMbTODRYfuvtH5cJFiCn02UZKggMb/cKuaXZV Fs64rqSR7/S0khVWYa5sUVmkF3K7WdkSohAL4hb4WJPlVz9i029rLHmgyvHI62pMImqbiNpdZHW0 FXSRuj0n1bLtHCcqup9Vm2B7o6/Lhtr0h9uyz54o2sTZ03T4BNJKHAO1E3XOPyxM6Npku5p7LsPD cGc92l8AaB3suXmwNsMPp9RPZaedMeFnUrME8lw0DSVylHRP1jYONu4X3EWTXVDi93fssqLJ5Zvo KjyILHJnwUuGskvqYCVjtwaLVqDLFdly5QDWX0m6xo8quDrtYT+VzWZG/DI+B/grHjVoH9kl+W6d zSfLu/sV2YcsuLLFhH4CV/pRz7bb+9lfOh4G+jqp2A6JAdPHZPbh2ogFlv2XZzspkH1C4/CjcpML rhvPwteZE8EjrcYbE8AOjBP4SZMHgcf+Tb8BdqR5QDXbsCP/AEjA/kAO9lh6iKdWFgkzp8YDEyW+ j9ishmFaXW07Ltv/AELGBqBG6gyQLfZf5R6iCIsDOrafDyyQBousmpwbzCCYb/suyv8ARRbvHHv+ EDsp1bTcQFcpalKqZvwNdnWrMFkLrtZpHsmDDJGEgNv+y7RpMsPLhrhI7HZZE+U2tcNLU+Sv00sF nUTsEfI65Zb9llU2Xi/7mkj5Xa0OTS+5On+yYcuxQktIId8C6vyL6KsB1mzCGRtLSwEfhZmEluHx SwuomOa87PI4X3hyzG5xuLfJRNysJBpDeeLLPnpWyrCrPgZsOc8nRF6XfCxRl1xJOjntZdmQ5cfB 6Xxl37JrcMDXf8k2HuFxWq/Ga+Ozql+XC1w/p+Cl1OBvaAGsBF+y7clwWKoGp0B0n2CGPLLJHjTF sOy6rVGXgOpDg7WtsWboocDdKbBhsu5YspRSEXph+SFcuTi938mHT+yr1SEdPZ1IcrTN3Mdwhdl5 7BswgruqlyjLotJH+6cMkAm2gX/C5LV1yw9OzpOky7UVD9Lmk2XP0eWHU8ZDow79l2DU9P53VDHx TeUAdxblcnFlt0QaCwk23JCfLi0I4KfJ05W5LdUS6i0j4QjJwaANGq3ZdxyZcublp/sqjy1I938u K/7KrU0uzfiVnULMAbEzeOx/CFmBtlNtFj+F25LlKd0l3QEj8Km5PeDfyS39k+SvbI8J1W3L7eNF /wBkmpys0tuGkX9l3GzJ4AuW799kP+kWv4sbfCi1Uf0q0/B1XheURMwBzvLH+4hXXZKmYHM8xsje zrLt2nyqG2BZ6fayCTK5ExJYS3suU9S93B3jhjR0y3JphjBsXH8LIhynNVkN8si3ey7cpsKpvNdF UNMYHey5KLC6NgtGA6/ey55NS/RjxRs6ZlyM0ABzb/sgOWhFt5d7fC7uOXGTtNo1gy5YYx28e3wF yWqf6b8ETqD/AEux4uWWv8J1NlOJzje2oLsmbDqSnm0TRyN9jbZZ9LlyGqjLoYy4e9l0+UzPx43Z 1LU5Qjcbi4PwjocqCPct1W9wu3G5OAN/KN/lMZlFzXWEe3wFflJLknhVnV7cvhwsYrBY0+UgSS1t wu4G5RcTbQn/AOhZwy5Z/hI6mMumaWI6Xgy65vpLLBZ78uRiCzY9TyF2vBkN8kumQaWjuAm1eQ3Q s1wnVbsViep2vsviR0k3K8jpSJIvSPcLkabLBqLMMIAHuF2hHlaondYQEEd7LlKDIcjjqkdpIHAV +Yq4M+Lk6hqcmMiA9P8AZLgyfq4ab/hdzvybLNIWsjvb3WVDkeqiZrdCCB7BYWr28nXYmdMsyVYg 6QPylT5TkjdvAHD4Xdn+kWT6vMaWrClyoY5AG3IHui1Kl2zDxHT7ctMAs2lc0nvZKGXHkn+WR+Qu 8IMpyTbiNSTKDtXqaNvhY+VzRPDaOlf9PyDYR7D4Rx5Ra9+p8Wp34Xc7MpNa77Bc+yc3K0bHAliP VtEWC2dMvymxg2iKuPAWRt+03/C7rOV2OGwCU7JrHf0D+yi1N9s6eFI6Ydl0zk6G6f2S35Rka2+i 5XeFPk2Nm+i/xZVVZUJjJji/wt/IL4kzpanwKYNA8spwy44G+grtumy0SNLog0+9llMyyxvLAf2W /On7CxnUDMuNePUxV/pkj7Yrfsu5G5TjlFxGEyPKjAfU1R56Vsvj5OlzluT/AOmTb4SnZbJcPQb/ AIXfcWTY5ozYBo/Cwp8gSndhYQvMtcXxI6PdlR0gN229tkuPKRJ3adl3nFkgAaXgalUmQKgHVE5p HsVpa1XyR4UdQwZPkcwFkJcB8K3ZWkabOgIt8LuKLK88EZBcAfwiODOLLPs63so9Sm7RpQo6dGVH WtoKE5QLrhzSLrt6PL36p+hjbFOhy0yOUxyDf3U+QhtOlxk3R9rbrJpsqln9H+F3Z/oWmk380t/Z C/JsVPsHalv5HHAcUdRDLRc2xYp/pRv+z/C7YOXWs2Df8Kv4DENizf8AC5rVNE2xO+cKobs/mnkb KV2GtafS3+y49uZYqaNrTuR3WfS5soJgBIdJ+V+Xo/Q0mYHlTU17DYrkKEuew6+EFZilNKLxuBHw uK/iPlSH1bK8j+JeasNhr4xEWB23svLXXfp3JQ0E1dC28bQTcdl6i/iMU7nF7xcDuvgercMFbk6s huCXNIC9mCbhJM8eaG9GtvyTNXylrtPqsVy0DzG3y7bjusWekNNjlfB2jkO6bFLqcbG5X9BxO4I/ L5Y7JUPngc5p37L56ubaUjY2X0XqLSSVwGKs8t5cOV6sb5PLkXBhtO6Nkoe8tLbLAfUOD7t/dVJW vdYRt9XwvWeQlbOylktfcrCkqpGyseWkRk8p8OHPqJS6S5PyjnwqepIY2QNYOyqBkGpbIG7XHypJ MC4WOyXT07oj5Tmm44KyBROfsBsjAnnuhv6jveyGalq6aX7LxnhQseXW0mxF1LA6OQNcCeE4vYdX uUmKBziNlltpRcGyAwpNha/CWJA3grk3UAk+3k9kg4LM197bImBAlNgGi91g1cbopuNiuVNM6lBB HqSpI/O2cN+ytkowKGrFLOWuIDXcXWdVyxwAOeRY+yV/pWWteC9+hnIWVPlmbSxgHmRjl11GKMTz IJP+S0g9yqbI0utfdc1R4QwQva0AFq4/+CyNqXO5aVCiHDcEkflTXZ53uFygwcTNALtKS/LBeHOj kNhyboDjnvbLt3SpWPEJb2PdctDgXlNLtV3BNhopKg6AwOsqD52llETnBx3PAKyotV7kbLnhgENi Hx2epJhzGgC3CWDhATr+3dE93Gy5SSFjSABv7pToGB3yrYOJkFncXKpjnXAIIK5Y08byNO5HZCKd jpQTslgwNdgO26bLE4PZzpdzZclFg8VRUgmUBvNk2rdBC8xA6rDkJYOJdH5Z23BWHJHMH+km3suV dpa25F/ZCCyw1C35SwYEVHI4gH+6yJKZ0TA6+wWZqZGQ5xGlMbVUclxLe3woDhCHvd/LJT42TmP1 rmPMwymLXNdz7o5Kmlmbqjc0/AUBw08DwzVZLjovNZqLVyU1dDG03F7dllUddBUUxtHpcEBwslM4 R2tYdkdLSuew7cdws/y/ODrmw9ldPWRUr/KdZLIYJwgzG7m2Pulf6XlqXktkt7XXMy4o0ekAW90t 2KMY3blCnFS5eroGWNiBxZZFLQyQtDnCx7hZceLawbuN1RrL8uvdAU6IndL8jVwEzzQHfde6NkrG i91KLYtlG6T07rIgw4vuHO02VfrWRjWDeyS/EWzbl2j91BYyfCWTytYHWHuly4E6FhMc2q3urGJA fbv+U44oyNnqIuqWzCNLIBx+UEdNe4dvdPmxeJ43NlIq2F9t9+yoMaXB45xa+k/lPhwhkcYHmWt7 pM9W1rjY7rHbUyOkAcbNQjZy38IkMX8uVjv3S4qEwk35XGsrnRSGznf3TzizpPQXaSUIcm2lDhva yXLh4e4BvC4afFJqN/Or2TYcyyOe1mkbjkJRbOUdQ0tg0t9YToMNphICCuKdiLZXXAs5U7FhT3BO 5Qh9K+mgeA0AX91jPo4rlp0klfKVGYJiCInklD/EpnU7jHI4yAXJSmU+mgw8QyubJuw9k008DGub YADcLgcGxt0kJfUOL9O1lG4o+qqC61o77Jyh2cs11Mx38wXHwuUpm4S6nJc0XHbuvmppQze1z7rC BcZS/UbHsoD6Waqw4uLI4AHdnJkU9PTwl7mNc4dl8rDO9s7jva2yVNiEnmWJ2O1loh9RTY9RyscH xhu9i0K3T4dO4EN0n3XzD4hA0ShpIKY6pPlgjhQHOYhiDKGJj4ze5sAmwYlLUNHqax1l8w2Uyus8 lw7XWQ1scrXB8jmk8EID6CKqkinAM2sk8XWfJjXlnS4A+6+Mo5WYdWi0jpSeL9lg1ldWCqmcCSHG 61VizsCWupoGtmnLRGeAsWszPRht4HgtH+1fCtfU1dK9sj3OHYFBT0MjQ65srtM2fVvx9z2ukExB PAUZi81VF/Nk1NHtyvl3N8toAcSmUc0jZNINx7JQs+hZihbId7AJrsdEPJC+enlcL25HZcbUVL3k cpVkPr/4/wDq7NB3CD+IWftbfm6+PYZY/U0kXWZBV6m6TJZ3e6OLFo55+OyQbeaQL2smnHQYxc3P uvnHtdM8abOHwmmne3ZZoHIVmZnw/wDLN3eyOmzRPPTuD5NL/a64CaJ8MmrTqKWwO8wnQRdb2qjN 8nPnG5v633/dNZiccjbmwK4JkTnE7HZG+mkdcgWWaLZ9FHikej0uGyn8ZDb2df8AdfJiOYEhtwEb aap2s1xVcTV0c/LmRouD6re6Ucwi12C3wsWmwSapAJYQT7hFUYK6EaQ0g/hT6ltknzHUOd3t7IP4 zK4h0czmnu1Yhoapp0iMuH4RUuGTTPN2ODvkLVIzbHyYp5rSHSPDu1isN2ITvOl0ji0cXXOU+VzI 3zHgo5cul+7WcJwhycK3FJI2hgFx8prcdqGs0Ws34XJMy+831MJWVBlouB9FzwpcS0zhmZhc5hY9 uyTLiEkm7HnT+VypyPVma5aQwnsFnjpzM6K+stvwruiRKR8scQmb/UU+DEHS+om7h2K5abp/WxO+ 8FqGmyU6WRzTK5rm8kBLiSmjFZUNc/8AmNttysKrkY1xcOONl9I3Ibw0kVZcR2TX5Upv0LwdRmHc 9lE0WmfHCqa/0lp/KZ/Tqa94d+V9Hg+TxUCTW7dp7rl2ZQj8sXFm9yjlFBRbPgP1tRG6/mOP5N1b K0vk1TDWF9//AKJopJWsc4kHg8LkG5GoaIgeWHntqTyRNeOR1a6ofbYlvsh/USm25Nl2fUZOo5QS 6Jod2skNyvS0ws2IE97i6KcTLxyOujVSP97eyU5znrsaDKsEjnWjA/CyKfKdMHWMQv8AITyRQ2tn WrHzSgRguI9lb6WVjuCCuzanLEDCPLjAPwEk5ZYX7tH5TyRGxnWrGSm+lrj72CyG1M7IHMcw2O17 Ls2lwKlpzfywQsiTDaKZ9mwAEfCnkRpQkdSNpZ3gFsbj+ya2gqDuYnN/ZdotwhjZP+WA38LJiwJk lzpA/ZR5UVY5HVBhm/5bWEn2QnDKuNp/lPuewC7XZgMUcxOgX/CzKfD2OkA0gfkLPmRfE+zpluGV Uh/5Lv3Cd/B6i1vLdddxT4TCXEaWj8JH8IjY4FoB/ZPOi+FnUseBVzt2wu27poy1XOF9Juu2JqZs TmMDRdyjaINfewU86HhZ1K/LmIs/9lxHwnUuT8SqS0CEtv3dsu4I42gAlgKbJBqYNIACnnHhOqaj IGLUYBOkt+HLEdlnEovSbkey7aq2l0OkX1HumUwhigAkjDn/AO5POPCdTRZVxSZhb5QJ7I4sjV7j eVtvgLth0TCQ5uw+Et0JB1Ndss+ejSxWdYuydJwGFp43VQ5CqHn1SiP2uF2n5Nmh5ZqSqiATjSWg fNlPOXwnWUuQa1th5rZB8IG5FrezgV2Y6E0cJLW3+bqqeBxiMxfseQnnJ4jq+XJ1XE6zuO+yuLJV VKbtFwu0TTiobsQ4/CW2ndER2+FfOyeI66Z08rT6jI0N9u6v/wBPaonZ4t7rs7TrFiLLHnieYnNa dI9087HhR1//AKBEIAfJqd8If/T18m7ZbAr7qnhbp9frd7rMiga1txup52PEj4BnTYjeSfZY9fkX 9NEZI367dguw6qn85hvtcLHFEI4tA3Hyr5mTwnXmHZOmr2B0gEUfv3K5QdPqR8d/Nka744X2DKIh rRezQsxsTWt4BCy87NLAvZ1+/p/FGBaUuv7ox0+dGA5ouPkr7sxMvqtwpVMM7Q1pLPws/Ika8KPj xkqFjR50QA+EiTJkFy5jdgvtY6cOYGPkJ+SrZS+WSy92nunnY8SPhm5QiI1adgntyhTkavLBK+wb SaQ5gF7o2wBjLEK+dsniPlY8mUczm6ow38LMdlDCYIrOi391zL49DrhDIC9pvunlZfGj5z/TOGPd 6QA4e6n8DjawtbENN/Zc26gDC2awIPIWcyIy2DGWaOVfMwsR8jNlyIvDtAHwsebLcTm6gyy+2mpm vNrbhYj6QvcdlVlJ4z5CPK1MyMyneW+zVy+H4YGxhoYCPkLm2YUD6j/ZZcVEyNoFrKPKFjOFdg0D hvTsd+Aqbg9CRvStafkL6FsTL2ISauFriNI3HsseWXo340zhmYHhZ/5jGsP4WW3L9HFGHwua4HtZ G+mDhu25WTTQNijve1+yPJJlWNHF1FMGOI8hjmj2CxX09PJ/7AaTzsvoBE15O1yidhkbgHbAqLI0 PGmfPOwxrG+Zps0eyyGspKmKzYmh3HC5m7NJjLRZY/6KJri5gsteVk8ZgMwumMIBiZtybboTQMa4 +Xx7WXIugtEbFYhjewbJ5LJ40YzsFaw6u5Tqek8omw2VslkDw14O/CzHRPDLgWWdz9M1sRiOhMzw wsaW+1kQweCUgmBv9k+m7m1yFmwuAaAVfJJFWOJgfwKivdrAD7BV/AYHN+4MC5GVoJu3YLGMHmHc 7LLm32XZExDg0YBDLOHukS4LG3lgJXLMAiIA3TBdztwnkaJ40fPS4NGGgtZZJGEvDgBfSe5X1jI4 y0hwslvhYRtsU8rJ40cNS5dGq7wHJ7cMjpqgeja/C5WOfybAjdVJM2R4JCm+TGxGFWYJS1hDmxaT ZcfLhjKVwa3cXXPNmF7cLjK/+XLuCb8WCb2XYh8VM0xghuyt9IZDte35QUcsmmzhYLK1ucPZNzKo ox5MPY0Dbc8oHUQjZuVlCS433Khc1wsTurvZdiOOlpASD2Qua3RYbOXJujaRdY74GteLcq+RjacY BK14u64Hayz5Q2oY0BtrLJELX21N390ToPLHpF03javZiR0ziLEm3sswUkT4Pts74QsbJqA0lZEZ LbN5WXNk2o4qSkLL+gW97JLKQMfqbyublZrI22Vx0rb+m26m9jajigHlu/KB0JfYn+y5uWlEQuNw sUxNkNvtPsm9mdqOLbA5wsSbBNNMXAAbBck3DnsF9iEh5DL32Tcy7UYT6X03vuE2KlMoBOxCdE5h v/UsjgW4BUcmXajGFOBexVWMbdk2Y+XHx/ZBTkSOAO1/dSzVCJDM9uwS2hzW2cOfZfUUGWqzEx/w hjd/0udYpOJZTxahdpnoyPlm6zurstHznktAJ5PsnwN0BG6lMZLJWkEKBgZtf8Kp2ZoPzgWm6xi8 PdpLRf8ACdoOlLLBe/daFFstqta5CNl3XFlTQdyAmRQPcNgpbFEEZfuAEZhc0XPssltO+MN2snuo 3mBxJBd2AWbLtOGdGCeEyKmAtssiGkc9wLmnney5D9G0AadylijjfIA7bI/0sbrkNDiuQEDQHahY W7rBw+qa10jHWJvss8GqFvjMUdiLflYNQXxyxnSNDuV9BJTeebucAsSegGkEvBAVTSBgTxuaG2Pp 9lNOposCAssSxNcA9wsPdZcbaVzAfMZb4K0nYs4+jpwA9zt3dlZHmE7XIWfLBEyxa/YrFkjs/wDl vaTffdHYMV0D37FNgpiwWPCc93lgF1rpL8TjY4AmxUtigpIjawHZYroXXsd1mQ4pQuJY6UB/sUx8 tGW285l/yrZKOPigdH6i25+FA067kWWbS12HgujlqmsI4KXUPpw0vZO2UdrFUggNJde9gjaA0bXS HVcbWXJsAsePHaQv0GZt/a6lWWzlvJEzQ4GyhgjYBqHqPdYLMVhufLff5CVPj8EBBlufwrQMuSm0 kkbhAyn1XNtJSHZnodILSR8Jb81ULW7gu/AUoWZmhzW2HCBxO1uViszbRO4a5rflGceoZwAHgEql Hh7ibO3TY4hI4W2XGT4pDERd4t7hC7M1JC5ulxeVKKc7HTEG99k3TsfdcK3N8INg3Y9yE05ijlFw LlKIx1XE58gcDsD2RN1cFcPWZmbRvBDC4nssX/W481h/SOLP6iiVmT6mKlI9Q3+E6GAzkgnQR7rh GZ7pIP8AlxON+yJuZf1TvMDLA9lGU5KSmcHHvb2S4oZny6b2HusOTH3MF2suT2Kxpc0VDWafItfu isKjnJKSQsdZwcR3XGCNxJEjbELjWY/VNPpaf3TJcwVMjLGAAnuqQ5aGm129iUyTCnxv1s9Xwvl2 4xWU8nruWFcjT5qma22kn8qg5r9FI5ouOEEuH1BbqYNXwuKlzPPt6dj7Li6zNWKxS6ImER86rKU2 EfSRRTMeQ+MhOhhL5LOcGj3XyTcz4i8gv3/IV1GN1z4j5TbuspQPvKWkD2EX127hLdB5N7gELrbD cSzBTyOLaksDt9LlmsxDGHvJqJy4ngBdHCvZN19n1OIRiWVpaNICQyF3D3AD8r5aStxMy/cUMs1Z UFpllLXA8ArFCz639CwuBEgv7XTBTaeCbfK+SaKx+8c5Dh2KVM/FpAWumLRxcLW0H2wkjikDXvDb fKBz4pZQWTNaQbHdfEsw+rFNI99Q+RzdxvypTYfM9oe972l2/KlIyfbvnomm8lSwfkpLX077lszH N9wV8jUYWHsAcS63yiosIbu0Oe15HurQPqnPoy/S6pawflPa6G4DKmN/awcvj48DeHv867geCky5 ecL+XI9n4KKK9mrPtZallM6z5WADuCgGM4eQfNlb8G6+KjwOof6TK9/5Kj8Ca1wbIXA+4VpDk+0/ jeFlthOPwsOpxXDLemQE/lfInL7pasMiLvLt9xKzBlF0RIc51j3V2r9FnNRY7Ax5u/0hPlxigeBL JKLjsvmn5Wde4e4D5Rx5Ukdw+4PulIzyc8/OtBraxsWsDa5Rtx/D6h3pAjK4OLKrA4hzgHd0YyoG m4JPe6NRImcpJj1O1h8uTcdlIM3lrLFu3FyuNOBGN2lrdRThghI9TCLfCxwLMibMPmnYJkGaIGNL Z4i63ssf+F6Ts0lZNHSwNNpIvV72Tg0mZcWasPqGfy2vZbnUFVZm6hotLozr9wFH4bFJtHCN/YLi 6rKMs7rCLRcqLbZrkyTnmGoBLI7lDFnGB3/MZp+EyhycygF373+EU2V6c/0235WnROTEqM5NjB8s OCxf9dSEXF3EdisutyfKWj9MGyO+VgjKVYxwL4Q33sqtvsOyxnqrdJqc30o255mY7+XGX6u1k+LL DtO7C78BNGWywgsjII+FfqT7GJU52xSNjXRUu/yFIup1cWaavDmOI7tFlyzmFkQjfFuByQlMwiKp Zq07+1lVKNdCpHCzZ9q55PRT6AONlbM54i4Way/uVycuXCPtZf8AZFDghbceXY/hG4kpnFRZkxOZ xaQW97oJsfxE+nzLH4XNHAJJtmsIHuArhykWO1Xc43vuFi4ipfhwsdbiBhJfKXu7XWM+fEKrnYfC +wjy64j7d/ayyKbLEkh9I77hZ8kUaUX+Hw0EuKUTiY5jb2KGbHMVkdpLiD8LskZYgaNMjTr91jHK rHSG7QGhVZURpo60MVZVm8kzt/lMFJVwgaZ3AfldqQZHpqhhse3CxJckMadJJDVVnj0aUGdcw1OK wyaf1DjH7FZQpKqoJkdK8A9l9q7KsbHWAJssiPLwsAGnbsjypkUWfAT4dLA1rmSOc53yktixaGQs MhLOxXY7suf9F7dkibLjzYlpb73Tyrouxnw0dNXTG7pTcb2us+GapYQ2YknsvqY8Ccx1msJWSMsy SbaOVN8Rtf4fA1WGuqagveHOJ/wnw4eY2gAbL7+LKzo2XkjOlOZl6GRm0Rb82TyRChLs+CiohG0u c25K4qSgkkq9LdQaT7rsqXLz/N0tbcJ9LlIa9RZv+E3x7GxnX1bliSqijABJS48kSRAEg7i9l27F l1sLbgBzj2SH5fm31NP5XN6hLhHSOJ+zqiTKcrjs3+ySzLMQJZIJPM7Fp2XbJwCQcLFdgpfKGmIl 4/qstLOXxM6qgyxUQ1Jc5p8vsuQ/hAD9hsPhdsswBrYLyRgm3skOyg2uA8toj99lzepjfJl4mdTs o2CYte0AcJ5yu1wL9euM72suzJOn0Qbc7u97JBylI0CNh2VWeDHhkdWS4CDIAWah2XJ0+FvEYZp2 A2Fl2RBkWfUNQDrrOdldlK06mAEfCvniPDI6t/hZaN47/sqfgL5I9QZyuxzgD5n+mOwPws6PKjiw As3Ueoii+F3R1H/ApL7iyfDgUrD9tx+F2zDkpsjwHENBWVUZMjpW2Y7WfZcvlRa4NeBo6qjweGRw bM3T8gJNRk+jkeXMeXEe67Q/0trJuwX/AArblUX2iF/wkdTfZXiZ1Q/CIqEX8q9uNlG0Tqkh7WkD 5C7gpcnCoeGvjAHyFm1OSIaNlxCHfhWWqinTCwSOnXYLI9gIbe6OLAajTZjbldoOy+GjancB8BFS ZfPmF1iB7LD1US+F+zq1mXpoJLyMWSzBwXbxk/su2I8qvqJAXsuOwWe3LjI26TTtuPjlc3rIlWA6 aOAPaQ7y9geLJVZhMs8zNLbABdyzZdE49Mej4ssGbJdQWkhgP4CLVp9h4GdXHLss0bWhpJ/CJuUJ mOuXFq7RpsuVUTbCHcd7LJ/03PMB5jbLT1MX0ZWBnVBy1Xs/5Rvbe9kX8Irw71x6iu3GZeeyzRFc e9lyFPluED1RnUfhZ+RR2WntcnR/+namR+8VgfhZEeXJIramWC7xdlNwGv8AT+j8JkeUY5W3MV/y Fn5aRpaU6S/0+dYeBpb7FOly5A9mppaSu55MkwyxECILiR08g/VFzQ4DuDwotVZh6eujqlmCMc2w Zx7JEuWza7Wk/su6mZNgZ6Wx3+Qsd+WPKeR5P+FXqK9hafg6YbgL4z9hP7LLbgrnNA8s3/C7bblU SO3YG/ssmPI0sjb6L2+FHq1+lhp+eTpt2X3m9mqHLEszfUS38LuV2QqzSSylc/8AAWL/AKVlgfaS nczfghFrU+LOr0vJ0+coyMde7ngdirlys6tcxr2Hbhd3syiPJDizf2shZlRpG0e/wtPVGVpjpGoy K6J7Cy4d8LlabI4ha18rST+F3LFkvUGu8uxHuFkPyu6Mi7QT7ELHyaJ4KZ0zNlBlRYNZx8KHJ5Y0 AM2C7rp8oyvOpsI0+5CMZHkLi5zRb2WfmJGvAdNw5LqXsuyLb5RR5NlBPnxk/su56fLdTHMGtYdC 5B+Wbjdmp34XF6y+iLBydAz5UMdyyP8AwsU5Zked4v8AC72r8smI7wkA97LF/wBLtcB/L5+FqOrv tmngOnIssPfGWvhBae5TqXKrIdgy/wAALt0ZX0GxjdpPwrZlqN7rMNn34suy1cerMvTNHWTMqCZt nHywe6RVdPadh1tqtbhvpK7VkyvUtIAiLieLBB/oWrfKHOgNz8Lg9VTuyrC+jqiHKR8ywFwuRGTW BnqZqceF2vT5MkabaN/wsiPJE8DtZZe/F1j5ak+DosG3s6cbk108oH6ctHYlZzsh1VGWufTNEbv6 gbhdvRdP6/FXBuoRR+4CZPkibD2CCSpdMwc33Raqn2dVgR1JUdNwYmT+dE5vdo5RtylTQQght3/h dq02SW+Z6dTge3ZZVRkhxc0Mj3WXql7ZHp0dUx5aErNJjtskTZLL2egFrvwu6oMjOpYi951H/bZO pcrGd9zGGj5C4vWJdBYEdG0eUpWucHx3I72VPyQ90puwj4su/wB+ST9zWD+ya3Lkdg10IJHeynzL L4ToaLIl27j9rIP9JMw/1iDW4G/C72lyq1zw5gAA7WVHKUb/ALmB37KS1VcmfAmdHQEyu0fpCw/j lPfl7zvU6nAHvbdd1MyFBK67YhcfC5SjyfR+W6KVm5FuFyesafDOiwcUzzszLIme4BoFvhVJlIt/ pB/C9AydNqbzC5hDR+Ep3T+OInYOWvlKXLY8KR59dlZpO7bfsuQo8nGW38sj9l3p/wCntOwBxiv7 bKhllkDrCI/sEWqvoiwnRk+XJqVxY1mx7WTIcoSyWd5O34XeDsl/qHB9g38hcizJBhiBJZIDwAr8 1rizXh/o6Hjya51w5mn9ksZdpIb+ex1hzYLviTJhkiI8sNJ4IV4ZkltEHOliZKT/ALm3VWsa+zJ4 l+HSNNlWjrW/8Nqd8FqkmQ2l20dj8hd/w5eoo2Etijid7Nasd2WWVRJa0fsFw/8AqDTL4Ys6OhyT ocLtv+yy58lxGIekavYhdxnJRcDp3KSMpMe8Bw3HutS1rZFhR0bJkeS9xAC33twmQ5QMD9RjO3sF 6Dp8lsLWhzAG+9kypyXTwWLQ1x+AuL10m6ZVhSOj2ZXfUM9TTa1uFh1GRyHC7dl3tJlpsLb+XsqZ l6KQ/wAyLb8LtHV0HiOi/wDR7GADT+dkQyQJhYQn82XoWkyhh8zQ57AD2FkddgdPTx6YYQD+F5/l vdybWJUeeHZHigbcRnUedlkU2RmStN4zb5C79osp0tW0mUBp9lU2VIYzZrAB8Lp8oniR5+qOnVa1 wdSRGQeydT5GxAkCaEt/Zd7jDYqGRrCNN9vys4YZT6fVGXE97KPVyfCMrHR0YcjzmK2gG3uFi/6W dE4t8nf8LvGfBR5l2CzSmjL9M1rXuYHO7iyxHUSR12o6K/0ZVTNJjg/wpH0+qni7orfsvQEGEwlp LIwAiGExAC4AH4WnqpF2o8+v6fSt3e0qQ5GYXgCwPuQu/psGjIsA1wKx2ZSp6t4DmgDvZb+ZKqG1 M6SqOn/lx3MzX39uyXTdPm1B9LHOPvZd/wBNlfCqY28rUR/uOyOrp6aItjhhYx3/AEjlcnqG+TOw 6FPTmeLcM29ioMmviHrj/wALu51G94JMe3yEn9HTvlDZIxbut/ItGfHR1BT5WaLXYBfss0ZRY4Wt v7WXazsBo5mEsj9XuFxrsPjopx5jQW37rnPO2+Asd9nWEmXmxS+U+le4n+oDZcjhuR6aUkvj3PN+ y7gpMOpqqK9mkWXGz4c2lmcIm3HcrLzNo0oUdbS9K3yvL6aVjf8Apdsih6Y1gd6oI5nAf0rsxuHl 0OrffuEhkMlMSRI4JHLKPNmtiOtn9Mv1MpEkXk2WcOmdLTwekHWF9455cbu3Kn6oRDcXXSWeUlRn x1ydeR5NY6YRlm/4WZ/6eQvFnNaPwF9s1rJbvayxHsr/AFTA0NtZ/e686ck+DSij4OfprHsY3hvx ZcdJkX9DKPQTfuAu1GPYQLgfCcY43AatLltTmvZHBM65pMlCRgL22HyE/wD0g2N40tH7BfeHQHAW ARGnDz6C03W/JKuzKionwgyo/jy9vcKxk83uWkL7t0LoG3dsFjS1/lcAH4UlklJVZpJHxJysGG2n cdymNyzGSNYsvsH10bhd8YJKIikeWucQD7LnvklRHH8PiKnLVPC+wCyaTAmRj0sH5svpa9lK+Rmg 3cs2mpY2U1y5pPysyztIKHJ843BGFv8AywT72QvymyUXc5rR7L6F72NuLgAJOiOTcSA/gqRzS9hx icLHlqliBuwP7brDqsqQyOBii0t+F9B5zYiblW3ERGfcLt5G+aFUj5qfKwptNhtyltwWPVYx3/K+ olrmyjccJbCx7riyvlfsVwYFBg1G/wBEtHHIO5I3XJjKmEyMu2jaw/AQPxBlM48AqUde+N5Jkux3 ZRzb9kSSMOpypQ6tiY+1kn/S8FPuPV+Vyv6hk8paSL9gURcfMDSdlzs2cYzBKSRpa+milHuWglKd gsURPlQtY32aLBZj60QSPDP3RwYnBKy2sXHIK1ukiUcX/Co3H7bErIo8qtqj6X7+yyo6+HWQLJ1F iwo5jcANPdXc/RGLflltGLvIc4dkh7HB2kxgAd1yFRi7J5tV7fnhYlZWxh12kEqJyQ6Aiga69mjU eyyKPA3PuZBseyCixGlFpJLNcOQVk1OLsmcP08lgOd1f5CzHno4onFhaBb4WDUs/SuBazVdHPi8X m3ku4jusVmPQGp9ViwKU/RbSM+jgBOp+3fZZ752PgcyN1iuMfilK8XZOwO/2grFfisd9iLrLRbRm upQY3Ha/dLwnDG18jtXZYwxMPa5t739llYZi8GHtdqI1IuCVZyLooqRhbouPhV5ETx9oWJJmSn0u LntBPusL+NRGxbICD7Fdl+maaM6akYLkAD5WI6nBsbITiscrCA8FJ/iTRc32Cy2iqzNZTAkbWTDT NG64t2Nsb3Qfx+MNIDv7rD/S8nNRvjitqAt7rJjqacyhrQ0g+6+Tlx2N50ukFvylfxKC4ImA/dVJ syfZVLo3PIETW27hYM/lhtgN1wseYmBmkvv8krFqsfjJs6QWWqk+gfRxERgXIaflZLZGeUQ4Xuvg 67MrJ6qMMkDWNCczMxZGQXjSVHuXYPuoZo4o9jdYdRVlpu16+Kkzl5DS0m4/KwXZxbIT6tkjjc+U iXR2Ayo8xzSHbrLbU6XWN115hubKbztM04jHY3WfUZ2pINLWTCUnghZ8T6o1Z9lJVROuTYFYkga4 F1r/AIXyE+aYpG6vMAB534XHvzyKZ+hsoeOLp45r0LR94JPKILdiEFRiDZJWutYjuvjW5zZI27ng FY8+a4e0m/5WlCTMto7Dp8QL9iRb3THVTQ3ci/5XW8ebQxtw/hOZnNj27nf8rooyRD7t9Y0tO+6x TXC+5C+Hdmtus2ddQ5ohJ3mAP5W6l+HPg+4gzLDXyh8ExeDyFyX6tk4ALnNJ7hdZZUxKKmqhEbbr tLCKE1Qa9o5Xwn9ez7ibH4fV/pZQ3zXPB7Hlc6WiqjBjvfugZl7y3iTT6kZJw6JzRuDuVTfZxVbS VEBLgTYdl11nnGZG4TVxyON9JAC7VGJRzQuaSCV0v1Rmjb5wj5PZaxcszKkjxnmeR1PjVc7vI8pF IC1jCO/Kys7RWxub/wC1dJpJNUDbixX9B0r3Y0j8pn/kzIebMvfZcHiczG31kAW5K54sIiINjdfO YtFDUFzJdmhfQxfyPFl6OAqJmPl9LgQPYrKwuE1dQ5jHBjQL6j3XG1WEUrQTHM9p9lkYbMyBnlF/ rHBXvZ4UznG/ywGki97XTXvjjLe5PK4xzpI2Oke7V7BOhqDI1hLLfKwaORfLAwNc6wKoYhTtcCxc RJJaa8h9I7JIeHTGws090L6OZqcVLpAI2gt73SpXxvtawd7LBa0XJJN/hLa67jYoQ5KMaRsQjNSx o3sfdYMLnG+6TKSWOAKA5QVTB6vdU/EHuad7D3Xz7qqRl7gkBVDi8ZdpkcWuPYhVIHLTV5azU83V MnDi2W2wWO8MljF97onbQ7cBAcucZgLGkvtYcBYVRjbPND2zEActXCSNFrgWKXFEx5JJUolnPR5j jmBjjeA48qzXujcAXbFcJHh9O2TW3YhZYjJJP9KrKmcq+sc1okDvSAuMGOObI7y5C4HkXSXSula+ LUQ07Cy40038PlB1ar8qpIjZ9BDi5kdu79kU+JujZ/KfoeVwj3FxDmC3vZV6nG5J/wDhShZy7MxS scGy7nuVkSYwHG4Nx8L56VgDtN9V0NMXwuIcLt+UoWc47GIiSC6xSjVCZ+oOsFxD42Pu7f8AZYwb UU7rxklt+CqkLPoXh7X6/NEbD3KAzTiU2kD2nghYImdURhkvHdZALGBrWbWUoWX/ABKSlnIILtX+ EplTUCcuduDwrnAModtYBLlc4jWDcD5VolmbHXnfVymGcTX3C4gyWs4i5KjKl0bjfkpQs5LzA+7X O4WO6a4IZyElge5wceCmaQ255UoWFDVskIbKwWCKUMiYTDtdY3kCQEnZMbDZgbfb5ShYUpvCDe5T aWqc23ZYc7iza91UMhLd1aLZys9U8GzL2tuVxU9WWTB5BJWe2cNpS0j1FYDo9TTqFwoSwf173TFw PptwmunfMLt2sseOFur4WYQ306SGgcrRbBZK8Dj1WsExkjg0F54S5Kxpe1oIcBtcLKp4WzWL3ABA JdUODtYuQmCXU4EO57K3Tsa4xhoLe5SjIzzNjYKMWNL3g/ddq4+QySTc2CyjIGkm9wg1ta4kpRQj qcwBt1JWu9IJKkcg1H2KyA0SAB9rjhRoChSjkm6YHMLwG8gK5Ro47rFZGGucbkEoDLfEHAuLgLLD d6wbOtZDUCSRhaHJcbHtaA7laSMssOfpsRx7IXSuc4aRYrKpw4u3GybCYvMdrFkCMTyX1QJfJwOC scSeSSGjc91mVVRBFIWtdysYuY59iLGyEHwXDATfUr8sTEh2wPdJ1OY3WAS32S5ag24IQtmWzC26 hY3usuKmbBcEXBWBTVTzpsCSuShldrJeLC3dOggMPbStE3mWaBw33QEtDv5Yszmy4wwmqrn6X2AN 9lnl2hoaQbjuFGaGPcXg+r9kUTBp3WKw3fsrdI/cAH9lKBkkRtvY7lY7oo2u1ncpD5i02PKJkoL2 h+xJ2+VolmU464tJIBPCVMAxoZcFIfBIKp73G7SNh7JTWvEl3v2HuUJZmwxtc3ndSZgiG3Puktc9 rvTYg8WTYBJUO0vGkDuVKHoh8lzdVh5je6Q1xmdc8JVSxsEpc19xwUJkLBccLSFmfHGw2sbBGTFG 8mXgrBbUarAHdFM27Rd1ynJAJGtdJ6fsuiw1+rES1rbj3S3O02t+65jL0DZJ/t3VfQqzmIMuCZ+p w5HCqXKsQJ/l2svrMOhDIAZAm1NKZm+g6fleZ5KZ6I4rR8OcrxlwuxZcOT6R5s6H1e6+pjhaBY7l Oc4AaTHb2csvKa8R8zDk+Cm/5YvflZAyzE5ttNwufjAB25WXHGG7kLm8pvxpHyjsn0UjbPBBWOcr 0zX+lvG1yvr5aZrrpBpWtOyLMZ8aPnG5ZiaPSwEn4V/6dY1pvGvpWxaWWsUYg1sF1PKPGj5ykynT zi5Zp39k6fKVLEPRLZw/ptyvrKeNog9DbFcZLTSwVOqRl2E8+ynlZrxo4ijw0sNtG3us84dBr1Og DxZZbmOdILABqIOIBCw5s0oI49tFDI8lkDWt9iFRw+Ek2ia39lysLWgEnhC+NrblTyNE2I4o0UTG cCyEtp4XNYGhxPuuTdRiVtx3WDNQCGoad9lVkbGyh0eHREA6QfdEKFkVywBZtPbSED2EatO6jmzS ghYA8vS5U4HRsVTYnk2I5WVHFdmm25WNzNbUYMpeGi7dSTBSRwF7g27n8rLrBLTN2jL1UDHyAEgg +y3vZNiERUwilN27HumOpIy11gNwsxzL78FIkaW332U3smxGDQYa0PeexXKsMDKcxuaHOQU8Z0HS VRhu75U3s0ooTXUcczGyN+9vYInXn0Pdy0WROGk8XARBwA2CbmaoU9gcd+Es0rXlZNgSdrlDI4Rg bpuZloVDTiJ5sP7pjdLCSG2KU2Yl/CyGsu255KtikUzQ8G4F0mWIk7DZOZCWG/N0TwRslkpGE2M3 +0WKfHShhvZEGm/sma9DrHhLIDpaW2IsPdCXmL0tHKe5urgcoZqctY11+VdzNCAH600xkAOH+ETW bbbqB52F9lGxQo3umsaNO4uo5ncBTULLLKYkzD51zugEmp2kblZojMoNt1Qowx17bomQXEQ0bp4k F7j24SxA90mkBSKFx1HewVKDMNW5CoRteBsmeW6+4RiNrHAXS2BMg2IGyuKL0W7o5LX9Iv8AhHTM c477flQAuldDGGkFwUbK14uBys6eMxt9I/N1jsgdJewaPZUCJGtfGWnhY1LSa3aGvNj2Wa6lksRa 1kEMbQ6xdpQUIu2hl0sBO/Ka46tyBdMfDHqtrBKbDGwGzjdCUYEszmC1rqnFzmi+wKz5KFhfqEzW D2JSZKRxds8OCFo48REXLQshrbNt3WUylcDu3+yuYwU9i86SFolGM5moDZMZE2w2uUP6qF7tTXAh NY/zAS1wsFmylPDWgghB5dxciwThURNBD7XQPqWSCzdgEBhyNAdYFRocXAA3QTTxC+9iFUFZE0gv OygHNpfXc7o3v0PaB/ZOjngkZqa8D8pEwic/V5zdvlEjLG6mtdf+pQnULd0gV0AfZzmk/CH+JU7X 7yN/utIhboHPubbBU2IaTcqMzDSsOgcHZVNWR6rtN2lLND4owQL/AGrJaBfQ0LjWVbQN3beyM43F TO1AX90KcgMPcw6huDymihtyNlw3+udLyI4A5vsUt+dHyH1Qhg91KZbOcMLWjhYtz6gdre64x2a3 R2c5gLTujdmKGQB5j59k5IzKjrAJCwt/dPaAb3Fx7rixi9Oy5LSCeFbsZhc3/mAH2KIHJGNl99ki RnqJB2XHyYqHMu11/wALBdir2Ek3IWyH0tJGXsJaRcfKVLrcTpNyOwXzkWPaJNPqHfZHFmk+ZYMI +T3Sgc1DqfKGubYHuVlfoyDa+xXzTswTzyaGMs33WbNj04iaxrLkd1HYOYlhbFsDcoI4WzCwXAnH 5H2Do3Bw7qhjE8UbnMZqffYIU5yroXRuZdt/lPo4tbSZCAB7rgYsz1MzdMsRa5Mfik1QzQ30lCHI VVM6OfVE4aDyExjXAWcuGbHWm7mPLldJXzxyOZON1QcuZtJLQEkytcbg/suPZXmacgGyksxhJNtv dQpy0bmkje5WbFC2Vt72Xyjqmoe0+QPV2KxJsSxRo0l5a7uhln2r6fQLvOkJDW67kEX9l8VJV4mI w4zuf8I2uxGRocJHNvypRLPs205c25I/uleWdR9bf7r5GOPESTaqfYHhVNDVW1ea/V73VKj6qKdp l0OcAVyIliaADofsvh8Poqp0t3vNv9xR1NLWsk9EptfkFU0fV1D/ACTewsfZVDMx7b6gPglfMxwY iR6nFzUt1BXufcF4ChD6Sou12oEBn5VNMcli14cRzbsvnBhVdps6d9j2T6fD5qMEhxJPullObdIG nnZCZ2uJdewHuuLIlLN3EFLdBPOwNDiB8JZlnNxVbJXlocLpv66OA2dICR2uvnThNWD/AC3kJ0WD SMIL3F7vdB2cwM44NSPMdVOYn9tIugGZ6Gqk1wuBb2+VxNXlyCoGqSBsjvcjcLEjy/5BBY23wFXV EPpGYxG47kWKkmNwwvaNQu5cHFh7wd7oanBn1Tmlp0lvBUQOdnxN8ZaeWlYlXmKjp33L9clvtHZX TYdJPE2GdxG1rhcdWZMdC90kQMl/3U4Bn0mYJ5iS1n8vtdZEmMwNhL6iPSO4WBTQPLI4hG5pbtuF kVuCgsDXXfq3siKU3HcNeNbCWNCuXHaYgGJ5fb3WK/AoWMDWx7eyCLBmROB02HsjoIzoszUrwQYj qHOySzMdPPKWhpbbhZ1LhIbZzY2uaeQQpVYGyS7hAGfIXPcjW1mI7G3tIME8kThwWmyzMN6j4pQT gTTPqoOLP3WFHgu5GgkLJbl60Z5aewKy1Fu7JTE4vm0SzGcRaWnsuNObrPAbSmT5suTdl5zmWcBp HIKxDRBknkxQ+r3suiaXZBTs0sf6jTPj91X+oaZ99LiD8rl4MLsQHxBxI32Q1uWIIo/NMYH7K7ol 2s4o5jaw2a0vFuwVx5iqi7+VGSs+kwMkhzIfR+FlDL0sU2ssLWnlRziFFs4OTM1Y46XNIIVR5nrw NDvSOy5ubAmNnDrXJ9wmHKxrAC0bjuE3RNbWcZDmOqgg0NN3n3QSZgxOZpBsLdwsuLBmwVJjm2I4 JXIHBrvAYLg9wpuiNrPmTi1fIbSSG3slS1VczT5LNyblfUz4CQ2/llxHwl0uGSWu6MtITdEbZHAN xDFC0ay5qbFiFS+wc5xIX04wovb6mX99kk4IGP8ASwm6bok2s+WxAzzObYm3dYsVBUNfdsjx7C6+ +iyyZLEiycMsFnI/sp5IIbWfHBk0kHl/qSJLcXXFuwutY4l1Q/c9iuwXZUaZNem7k+PLp4Ldk8sU XZJnXLKqvhcIiXvaf6imzmoc5o3uuxv9JB9/T+NkqTKhv9t/wFhZ4M34pHXjcOfK7U4EO91bqFzb 3cb+y7Ejy008i3ylOyiDKXNOoLSyxI8ckddR08bnFj76vlZMcRiP8q5/dfeTZPbJYhnq9wE3Dsox xuPmMvfunlh+k8Uj4OobK+Gzri/KwBl2F7vMBdqPsu0azJMFRb1FtuywxlD9M7Y3atxzRrsrxSPh I6I0MX3E2UqaSSWJkjR6Sd7rsOLIb61wJBLfZNq8tMpo/wBO2HbjhHkh+mfHI+BZgkcrWgEOLvZU /AjAdOj+4X3+GZPfE7XpuBuAVmT4UXn1w2A+FzlmjH2VY2zq+fBi4XDQEuDLLHOL3krst+XYZbnQ QFIss6rgsIARZ4v2HBo68bloS3AJP5SxlKOmfd0m55C7NpsDbDLpI57JuIZSZK3zHN023UeZdGli bOtTgbWC7Wah8BVFh0jSbMsPwu0cFwKJ92eWHDjhcnN07/UtMkR027WWHqEmXws6adhMssltILT7 ov4HCWloIDzy1dqS5E8lxuD8rHbkiOOTW1pLlFqYsnhZ1j/pxsG4ZcfIWTRYG4tJANl2e7KRdETp /aybR5W0Qvdp9QWXqUXxP2da/wALdexbwrdhbn/07LsiDKzqlr3BoBBsU12T5oWAOh5WPko14Wzr I4QLfIUGDvPHC7Bny15b7Oid+ybT5aa49wPYrXyUuyeGzrz+BueN47/NkqTAHDhmldsjLJY21rt/ CU/LWrlq2tQmX47OqGYXpOlzd/wsyShbJCGGMbd7L7+TAI45CPJLj7gLMjycamIuEdh7K+dGfCzr OLLXmt1Bij8uOZw03HwuxG4A6mmA1BjVyhwKKWEEWe73UeavZViOpG5cEwN9njsiiy2/v2XY9Rl6 SB/mNhL/AIAR0+XKio9flFvwQp5+LMvEdcOy64jVouPgK2ZXhLw97CPhdmnAJoyA2P0nnZOdld87 Llo/CytQpdHSOBnVlRl6Nh1RbH2SYsHL3kFv7rtuPKRLLCEH5ssebJs7blsNvwFPlK6srw0dax5c EN9rgoXYFqNg0hdj4fleUSu1sJB+FzcOSQ9ty3n4WvkIqw2dLS5ck2s26fTZUqCQ5u3yu3p8jOvs Pws1mSnRxN9BFwuMtWky/GOohlZ2xebn8IJMtlvAJXcwydqFixJmyeY9/K2VWsi/ZXp6Omo8BmY/ Zn+EcmWDM0mTZdv0GT31jngRENHeyZUZLLTbyH/myS1VIeFnV9BlaMU4c1gBHchDLgOt4A3t2Xab MpGGPTpc34ssmnyhCW+YWXK871Mu7NLEdSuywSz7LLEOUql8gaza/Zdzz5bicCGsJI7BLpcpVM84 LI3WHwui1i9k8NnT1RkCamc2V5LvcLNjyy4xgaDb2su7n5NqHD+ZESLcELh35QrY6khsB0X9rLL1 ik6TL8c6pOW20o1lmonssn/TrZWgiM79rLt+DJc0ltUGo/K5WnyFrYAWhh/CzPUpLs2tOdCnKlj9 tvynQ5NbI7dn9gu76np4x7ud0UXTx4YRH6SRs4rl8xtVZHgR0ezAmUktvLII4BWU3Ls0/q0bLtxn S2r8/VM8Sk8aQuapumdQxoMkTvL/AAs/L29sLTs6CrMu1LoSGRk6d+E7DsBOIxFk8HluGwIC9FOy PRx0xYyH+YeSVxrMgw04LtNie9k+cma+PR0MzJk7ZSyM2APKfNlOoZERYvP4Xdv+kIo3ag03HsFy FJlaKfYx7/hYWuZqOFHnehwiWjeY5Ibi/JC5WLAo6kf8sC/wu+ZOlornAxNa38rGq+k5pSC+QNd/ 0912+cmqbDwf0dDVeWI4wTJAdI5NliUeVqaabVA1wZ3JC9BOyUGRhhYHn3ITKXIboiJG0Ilty0DZ Z+YkjPxzpp3T+KppQ+nqIy8csPK4qTJb6Z5LmB34XeeI5YpXg6KF1JMO7VxFHlOqxGsEGkhpNtVu AsrW17K8H9HVbMtsMO2mNx4upS5ZdxJYn3au85OhDKhutuIA7XsRZDH0/wD4YTHMxshbtccFV61N WmaWFL0dKVGX4qaFzgLv7CyxKLLdRVElrHNHwF6LockUNRGXSUmot9gmnLtBGfKipHM+dK861lum dPCvR5trctVFGdTmF37LkaPLDqylD3RuB/C78qsgxVbfSwfGoJ0XTKupY9YELo7bAL0/JVHLwKzo 6gyXJG++n0oq3Kpc4gBd2TZFqHMOh4aR2A5SMPyW6WqbE6FxJ/qI2Xm+Wr7OviVHRQyib20kn8Jw ys+MXMd/2Xf9dkCKkmG2/wCFk0+SAxoe6mPlnhxbso9b6RnwnnqgwFgqB5kXHuFnYllEVI1QgD4s u+W9M4cTluwNh/6rLJpemkFDJ6/51uE+XSseE86xZVkgAa6n3PeyfHlOoAc5sQJ9rcr1JJl6kraQ U78OY23Egbv/AHXzdVkQUk12D0+xXOWvk+EVYUjz1HlrEZnujkpgGcbrlKHIpLCHAN2XfdFlmARu Dm7/ACFgsykJawtZGXAnsFn5jS5Z2eKNHSL8gWl1WP8AZF/ohwcLscB72Xox2QaWSlAe4xye6413 TyVrrsqmvbzYhSOsf6c5af8ADoB+RnUEvms1PDux7LIGWKmUf8oH22XfcuQKqdrdTWOATocpRQEM MTdXyFZaq/ZqGLb2eeJ8lSyHdhB+AqbkaoYy4gcbd7L0fNkipDgWwNc09wFxtZ0+xOSUaHiON3II Vhq1+leJHRNLlJ0gOpoI9k92VhBsIwB8Lv6l6eU9NSlpIc8/1FcbQdM563Emt03pwfU73Cw9S07M PDfJ0bJl0PNmsKdDlWBhBfZrvay9EYj06wygt5TN7bgoaPJ2DyN0z0oe4f1d13WpVFWP9Oh34Ixj QYo9RC4uoypUVk2qSLS078L0hLkzBpniFkXkyH7bLKd0oMOnVAXMIvsb7LPyaI4I860uToyL+XuF dTliVzCyJhvxZoXoH/RuCxu0uLWSN5YSsqLBMOiaWRwsP/VZZlqd3Rlwo6SyvlLB67D6mCthlZXs F2O4F1xNVkhjZCHSFj78kL0HT5epI3l7oru+AsqryxR4xCIhRs1diBuuCzs6eOzzbFkaRzgWkv8A m3K5CnyNMRbyv8LuOq6f1lE8CnADfZy5zL2SmVR019Q2Aji3ddHqKV2RY6Z0bB08fIbuGhJxHJcj GaB6rfuvRdZkejpwQZ/NYe7UhmRMDfGXmpc0j3XnWpd2zo8Z5+oMnHywDHe/Jsnu6XOqniRj9AXb sWGUrMZNO066a9tS+nmyfhgDTFUOjDh7rEtRJu0VY0dGUnTx0Qta5HeyXV9PpL6hcfsu+IcrUlMN TKkSnuFH4FFILNbcnvZZ8rbtmvHE89MyGQ+3e+6e7J0kdmtjcSfhd3HLDYKi749lyJpKcU/l+Swu A5I3XXzOjHjR0VD0xr6hpeHeW3kiyv8A9N5rEtuSOV3NFI1j3NdbTwluiYyQuYRpK5xzSTtsu1I6 bpMlPdUeSAC/i1lny5Elhl0vDSRyLLthjaLD5RM6IOee9kh1NDiM7pW+i63LUS7RUkdeRZcMUWhz bhLOVQ4WYy37LsuDLbZ5L+bx2KkkNJhkrWus4k2WfNJ9lXB1lLkuRrBpNie1lk4fkaGZjmzEi43I XaU9FDPIwNaACL3ssOSkhppCLjf5XRZeDG3k62/9KqSJ921zmX7OCzqbpnDpOuUPHvZdgCGmkaA5 jX24Ka4xxMuxth7LjPNJLhm1BM+EdkLDqaCzIRI/uSgpcmucPTCGt7L7ktjdvsL9lmQz01PF/NcB bsuazyrk6eNLo64kwiWinEbmaf2RVOVI617SYgD+OV2WyHCcYsHSiJw7rCnbR4dUlhqGFo4LjsVY 5OeDLTPg4On0FcDE93k+zrIoel9Nhjy41An9gvrq+eFrtUb2kO7tKClbHPv5mw7X5XWWeXSMxS9n xdblfQDZgA9wE/C8isrWBzm6j2uvtKunjkZsQSEj+NR4VA5hiLnHiwWfNOqbLVnzdZkCrgb6Q3yh 7JNNleMABzhq7rn6PMr53uEtw07AFZlRREgSsHpcLmy57pXZNqPlqrAoWlrIW3eTuuRGXaeOMOMY 1W3uFnGKOCRr3tcPkhQ4rT1DiyOQOtyt+RljFF0uD0M8IbNEzfa9lw+JZMo4ZvMp7Ee1lzzQxwAL rD4Ulmhp26dYN/lVTl6LtRxtBgEboheCN4HIIS6nLVL5mv8AQsieO7QvoMPq4aY65XXi5NlnT1eG YlHenqA0gcHZY3S7NdHz+H5VhqYjaJok7XVVGUZ4QXOgDmj2TarE20T9LZd/dpSKfEqqrl/lVLna ttF1N7rkUhmD4Bh9fW/pnBrKk7hpWVjOVmU7LaBZu17LjH4JX0uJNrhqjnHe6y6/MU36by5z6+5X PfK+BSEQYVTPj0AlnvYrmaDJeAzYZI+oqiasH0sK+ZpcTYH6tdrrJbjkD3FuoB/ut7pFTOUiyhTs BdTaTZYEmDDzdLmgG6y6GvNNG4mT088oIcXhfUHU4WU5fZHTJDl9rQXEX/Kp2CmZpEDQSErEs1xQ fymi4+Fx9Fm6GnqfVIWXXSKZzfBmswieka5052Pb2UgjhLS0NBJPsgxjNET4ToeHEhdfSZ5mw7Ej eJwYDy4bFbqRm7OyaXLTq15LHCMA7go6rBo6J9nHU74XEUPUxk9MAaUMkP8AU07Im5reSXBgkJ4B Kktw4OXpMOdrFmWB7rL/AILG+TkFy+fhz5JEXMmpgwHuClVOZ21ILYp9Lj3B4XKmas+lnwl0VrtA HulDDmOG5AXy9HiT6WYvnxUuYe0juEyfM8DnFjatj/wVFGXodnK1tM6KdrWuBamxsbABI+HUz/db ZfK1WZhTknUHW43VSdSJq2j/AEDWtbFe5PdbjCb6QtI+3ioocSe1ps1hV1uAx4cy8TzI3k73XxZz rHhkDXO3IH2juhh6lOrWENj8tvcHdYeOdnROz6qmldUP8tjbW7lHiD/JhLCLkr5F2cWQhzmPt+Er /XlGQP1Dy8g8reyVGWfQYeWtqAZQCwrm3wwxxl0Wwsuta3qDSXAi+0d05vUenlpQwyAfvuig/wAM bldH28Mgs4tdv7KN8t8o1CxHddbf63po6jWJy0H5XLNz9SvYLPDnW5C08clyTizsJ2JQQQlj+exQ YdPB5wdKdUd7rrt2a8KqT/xVb5R7WXGy5qZTznyKzzYVlY2+y3R3bWGjqvXGGgDsuGqaujY8MfI1 h9yutoM/0rQAZ3NJ7JlRjdFXxl0ktyeCCs+Nl3nYYq4XEFj2lo7rJq6ulngux4LwOF1NPmSOjADJ LN/KtmcYmC/mrfjaV0RTR2RBKNVw+x9lm/xGC7Y3uaDxe66llz5DqsyS3Ym6UM5RTPsZ/wC5UUG+ i2jtzGcNdUNhqPPiMcfYELEfikRaGtcLjsCupq7MrQCBVO/GtcfFmwwu/wCef7rqsEmZ3I7qbiDL bEfuo/GKWkGt7m/hdQMzs4WBm2HsUquzhFNTuDpPxujxNcFs7np6oVR108zC07lt1j1daGP0vcBb 2XRNFnSfDZdUc50c2BRYh1BmrHB4mLQPYqvDOuENyR3k2vYWgh1wFjSYu+J92PsuoYuqcdHT2fZx A5ul0/VBuIOdoLSfbUsvHPqiLIjtqvx90cYdqu4+ywqbMjIqhr5n2+V1gM6ufL/NNm/BWDW5wjc4 2f8AstRxsw8h387NVM6luyRriRwvnJsfLqguAGn2XSxz1NA60bxp9kyPPtTa7nAj4Xo+O6snlR3p TZp8jSHN9JScWxykqGEk2K6Sk6mmmsXRSSD/AKVjSdS4a020SMJ7ELDwNmvIju+izTDSxBjZdX7r KhzbRsefPktfuuiIc4MN9Oyf/rJo+7S63uU8Dou874OcKNrSGTamBYzszUdQ42kAXREmeWB9jsPg p8WbYiQ5sgurHBJLkm9ejuyPGYXyEawVVRWxRggyNN+y6JxHN1S8H9PNof2N1wZzbXxE+fVuc/3u r8eUjLyo9RYfjNEyA+bOyKw+4lcfV5hw2SVxZKH2/qC82uzdNM3S+oc8dwSs6izbJBHYSDT8la8E onPynoSLM9H3cE849SSWLX2tyvM+JZ8ngddjjb4WJT9R6t7read+y18aTV2aWS+D05iGYonub5bx YBYP+pGwbh+/5XQlNn6cg63ElObnmWZ1rgH5KwsUo9mrs71GdjIA1+4Rtx6mlcC42XRYzk5p3eCf goH59li4P908MnyjLlR3rW43SC2mXZcdUZigDheW4+Cumzm2or23a4D3sUt+YfLjPmPJP5SOB+zS mjumLM1G0h3m/wCUNRniNj9LJNvyulKLNEL3OBk2+ShqsfbI77zbtYqfGbZ0c1R3Q/ObHsvqH91x 82dmUpJGzfyum25iMDiNZO/ujlx39ZCWvlt+61HStM5uZ26M8xzEHUB8BZMebWPA/mAfldEfxsUr 7CS/7rIGbvLaRrN/yvT8d1wc9x3c/NTBv5gt+UBzpFFxIPxddFz5qMgvrdf8rjpM0P1buNx8rMdM 32Rzo79nzjHNy8FVHnBzAC03C6JgzRI7bWuQpsxSlwAl29rqPTFWQ7dkzu79QHAkEc2K56jztSVc TS+pbA/3cV59Oaw2rc1zwWpNdi4mFxIdPYXWfisvkO/q7OFFQkuNU2Zx7grhJs6xTuLo3ho+F0gc deyPSbub/dMjx2zfS4j44W1pZVyPKjuN2cTa4kQNz2GH1yEhdPuzC4cPt+6qPGXSX8w7diCu0dE2 rMvIjtmu6lRMDWF77X5CzIM5gxa2S6tXuV0zLi0IYWvNyeDdAzMDomBrHXA+Vt6O0XyI7aq84SOd bzLD8pcGdHtdpbO5dVvxt0kYJfv7XRx40Wxdgfe6i0lGXlO0ps5vaTqluObXXH1OdXmdsYdbV7Fd bVuPljBff5CxBiTJJA8PNwukdP8ApiUztiPMLGuvrOrvusxma3NsGv8A7rpw428O+7YLIZjsgsQ7 /KzLTIypHb4zTVt3ZMGj57rDq85yR2Ms1z8LrOPMch+5xFlj1GLCpdcuuuUdPT5Om6lwdh1WcS8A h5JPyrps2TRtuHmx7ErrlldY83AWQca8uO5K9CwpdIPIzsM50q2m7JdNuyGTP9ZwXC3crrOTMTXb 3shkx1sjLB26z8dd0ZeSkdljO0m+qUX9iUqXOjrE+YuqajFXAbu37JLMVkdfcrEtNa6MrMdlVGdX Md/zLfusN+cnk7SH+6+FNUZW+o3t3WO+qLXbH+6749Kq5L5js6HO8rGgOk/urmzb+qsTIQB8rq6T EX2ABJQGuk0EBx3XVaRdjzHaAzTG3YPv83Quzg4+kPP911bFVPjJcHk++6b/ABR7HbEkJ8T9J5js abMj52+l5BHysdmYXtdZzrlfCNxVzfUCnMxAPOq+6qwbVSQ8tn3LsdDmkuP7oRmJkZadR2XxL8X0 7XuFgVWLOkadJtZbWBP0ZeZI7IlzY1zSA7/KAZogDRqaSey6zgxJxvc/5Tm4i4tuHcditfHMeZM7 AlzXa4AcAuLmzkGPt5ljfuvmxj04j06GuBFroXTU9RF64bP51LPx0jXlPsI80zOaHtOseyNua6iQ 7bAdwV8W6Qxx2Dy0fCwqepmjnd/NJZ7FRYK9DynYZzPI3l5Cr/VRPuV8Q+sc4hpN0YrrCy34l+E3 np3LmVHzVxkuSAey7ky9UR4VSMa8i45ugwHLMWERSNe27jwbJOJ0GsERO0u9l+Ea3cn6dcH1UWZ6 aoBG3ssDE62B8D7DUTxZfFSYXiER/lglJZXVtCbVEbrdyVltso6ulkpGPc29iuos5yzTvne4kg3s V262vhxEGNxABGy+Fzdg5lEkUbCRyTZdMNbuTnkTo8i54DY8XlFwXu7LioQQxotYlfQ9V8Ifg+Zd RB8t24K+ebKJC3Txblfv9I/oqPzOpTUjLJIjsSF8ti8Ln6w08919K8G2y4esZqJBC+pipHz8h8S7 zIi5jiTbumReRK0XP87tYrOrIAyY2tvyuKbTiCoMh39gvX2jxM5yleSzROSbLINmNuHbeyxKef8A VsBtYhMLtN+/wpRSPi/XFzNxbumwsiZGYzy3usL9TKyS42j7pE+JwtmbpP5ShZkvqXNY8NHCVTVF 23cNylz1YdES3grHiqfTYBWgcrrAF2nnskzsliBcBqBSTMWxeaW7NVHHPQLM1W7FSgF5xZoDmjfs smofTyReqFtx/UsCfGIJ4bCP+Z+FhPq3Fm4WqZTlI5xEf+kp5nD2EN2uuIgrI/LBebEHhNNZ51Tr YNMTRylE7MhzL2veyLTpb8JLXmZpIvoSKiV8Qva4U/og/wA1oNyNlnxzt/h7pQQBxuuDhro9xKC0 fhMlqIp4RGwltz+ybaFmS2YuY4jb5WMx5c86zq37pVpqTcjUw+yZTuE52jcCOVSMzY3tBsNgo4hz yLJFRKYW3bGST8KQyPkYC4Wd3U/s1RZNnagL2Sn1Wu+2kIaV0tPM974y5juyGotIXaWlp9leCbWW 2dhHP5RGo02bz7FY1OacAh5cw/3WW2OB7RpDiBwQFpuhTFyT7i3HfdPbWxmNtrk97JNRQPLP5THG /aybhWB1c1R6oXMYBvccrNquxTsJ8/8AWDsUv+Y65bu0osQw+aMlulzWX5ssWN8kfpbKHDixUVVY pjmwTPIJtpCGdzhK0NBPugNLXSvADHk87ArmXYZVOpmuFM5sluSFbSFMwRV3IZa1k0FzhxdJ/Q4j qsadzvnSmNw3Fb+mB/xsl2EmW4OB22+ELnvc707gclPblzHqwkxUsjr+yjsl4/G0k0koB52V4XbG 1/hhSv8AMk0NIKJkD6cAv4K5TCcjYnPUN1U8jN9yWrkqjI2JVc/ltGlrT3WXJI345fh8y6XU6wNw nsjkcy43+F9ZT9LMTbE52nULcgLj5OnmK08t2OcRf7bLO+JfHJej592zgHNLSfdVGRPIWN7ey+nf k/E3lrHwPue+lZEXTKvaNcQcHn4WXkj7Hjk/R8TUxCndoiI1X3uny64KZrnHf4X1E/R7HnAytYCT uN1KTpHj9bIIqgiFo7ndb3wrseOV1R8bFVDdxNk9lW0sLtO3uvvR0LxF7wyKeN573NlmQ9BcamJj d5bW+4Kw8uP9NeGf4dZMqPPB8seocBGWyttdoJPsu38O8OtdDKNVQ0OOw32COu8OtdT1Gk1zATve 9wub1GNeyxwTfo6gY94lbdpaO6uqmLH6mXNl3TD4fKhgD31Pmi3A7rj6nozJBUFjoz5Z7qLU437O nxsi9HTUmJSyOBBAt7rKirZBAXPDXH4XdeHdEMLmLv1Mcrjb+g8J8fhzw2dw01c9PG7gyb2V+Ri/ TLwT9o6KlqzYODTdLixCRmxaDf3Xfc/hrp4HNMeK+ZGeTbdB/wDc54dJb/jpA7vtsr8jGVaeb9HR xxMQRbWEl/ZHHiDKuMtIDZPcLv8Ao/D3gFPGRM+aoedtROwWDV+HXDWzh1NM/RfcEp8nF+mXgyRP PMzHOmJ7X2Ky45nMmB06nWsLL05QdCcGfTCKSDUbfddYWJdC8IjI/Tscx7fdY+XjZtaWb5POVRFU Qfzt9J7eyjI5KyO7W3cOy9HUXQmPFI3ec8RRjYA90UHQyhoXlgcXb89lPlwOnxJHmt0NXTerSQoX 1dT7r1RF0ZwniQFx90E3SXCcLa7RE1xdwSE+ZAy9JI8r0zXUspMhLHdrrPpJqipeRYFi9L4f0zwS onP6mgjldb7iF9Th3RHKc1P5srGxfAPCzLWQSNR0kmeQ5KGoY67QQFU1U+miBY3U/wByvYkfSTKc OqOCDzT73WBWdGMr1QOuiLTf+nZcI6yPs29LJI8oUk4qw3+UTIebC+6x67Dat8gcaeUDtZpXqyn6 cYFhZMUFCwlv9Thcrl6LJkEnqbTRFo4Dmrp8yN2jHxZHi+SGcv8AtlaRyC1QUVVK3U6nlez3DSvb /wDo2ilAM2G023cMF1k02XsEp5BHVUkTYjyAyyfOgja0b9niGnwStdpdHBOQNwNKzZMKxqqaI48N nv8A7gwr2XjGCZZgLf0FO0v77J2E0VLJtpiaB2LQuT/yCXofDZ4tpMmV0kuiaGVryeC0rla7JFVR xAmF7m2vey9iV2AUk7h/Ii/+00BLrcv4TDgtW+eBj3tYSDb4Ra+Mux8No8PmBlNKW6SCOQVh1VQN duF9BjMsdRi2JPsA1ryGgdt18xIzzCXgagDwF9WD3I+bOO1jRMS8NG4PdfYZSgL59Tmr53DcK/iG kaHMI72XYOX8OFDCBa/ypkkki44ts55zWBrWu2Ry7RAArGf6ng22Vzzlth2XzpOz6SpDoooYoy9x Jd2QA+eb32TqUsdTm5BSWFrDsdlztkGCMBw7rI1DSsc1MUR33Cx5MbihH23BQ0Z7nbfCWW77FY7c RhmaC17R8FW/EYY3AOcAfgqEZlCFxCyWM/k27rAp8TjLrB9wpVYi2H1A2arYM+GR0TgLJ0hEzLPu SuGpsyU5uHsLrcELMbmOF0LmtZ6rclQvAb6CZ7CY9iN0uOkqn8t27oqbNUMDC17dTjx8Lj8VzdWx R/8ABU4ffm6dkM90bmRkW4QxAub6wd1wDMx1j2apYCCeVkR41Vy6QIxpCA+gZCWgkcFBLD5gLu64 qbGqwAAU9vkJUmYaiMhjWXeex7K0U5IQzNOwNkylL9RDhv8AK4cYrVuGoGx7hGzFJi4F247lKB9H FE0tubAe6GOqp6Vskj3h9uLbrgp62WoYWMeQDzZJjopIoCG3dfm+6UU+jlxCKSIPFgCFi+c2SRro yC3uV85N5sIIN3N9kLMRljgLGsc0EK0Q+mqC2Mcg39ljFweQFwVHPU+UdTXP73UqcTmEZDGFrh7q A+sgi8u1wNPdNnqaaAfcNS+GZX4hNGAXuaB7Kmvme8a3FWgfVS4jT7gAFY7KpjzpLgB2uuEbSTOe HB23wsiSkY9gbLqAPcFKBzrJYNIu9pI7tKN01DpIc655XzNPgMMXqiqJHA83PCzIcMc0jk9rlGQ5 CSso43Ag8oDOL6ifR2WHU0RY3Q4DfuidTubAGm9glAzm4jTAtD32B73WU6tpCLNe1xXyUmHur5wx ocxizDl6WljDhITb5Shwcoahkkhs7Yc2VTzt5adlhU1LIxh5IKt0Li0tshBjMwQs1MeDqHdOizNS x+iUAg9yuOdQHyyNALkhmCmpN5IyCFQchPjkT5B5H2HlMmrgWNLdz8LCkwZkcJawFt0eFYcWPDCS 7fuhnk5P+KGlpwZG7W9lx0OOxvc9oaT8rkauDzf5TmcD2WAzBi1x9GlSzRRzAKbdjd/ZR+Y5ZXB7 orBW3BXOebsusgYFKQPTcBTci0YDsyTl1mR6VH47OWhgGkHclckzBL7OjP5VjBLg+lW0Sm+jEZjB mboaNTgOUuWuIFzqv+FyNNgwgJIA35XMfqMPpqR1O6nbNK8fcReyllpny/8AFHUxY5rg4nsUuvxP Eaw/yW+W0dwsupw6N0gc2OxCy8Pi81pZpstWiUzgTWYmG2dKSAsaaSseQ4VDmkey+xdg2sWAv8rG fgJsbNv+FndH9LtZ807E8SYwFk2ojss2nlqJYw+UkEjss6HBXxy2LFzAwvRENTdlbRVFs+bmndHG XeYA7sCVx0eJ1005jbx2IX1FRhDJnanR6mhYz8IjjeJIWOaByloUzg548SkdfQ94H+0pkb65g+18 YH+5fY4ZGI4w5nrPOkhJxOinxKVpLDEwdgFHJI0otnzX8UrYN7rjMXqK6rFyTpI7L7STAtTAAN/c qR5dL7NLQrvRnZI+PwPCqr9G50shaCdiU10NfG7+W/UF9w7L7xBoDbBcfPhUsQ023RTTDi0fI1dV WR6RK2wvuQsv9VUSva5npituuWmonSyMifHquuRocqVEm5bpZ+FbTCi30fKviknd6b/KoUFQQebL 6xuBvjkc6Fpdb7rhGaN8X3R89rKOSRdjPi5qCrfG5sby1Y7MEqgLyTuN+1195DhYqL6WlvuCp/p5 7npuRjYz46DBnQ7lxcPco/4Ox4cSvrnZfmjv6bhMgwFztiwqb4jY0fHtwdrBsL/umto5GDYGy+2G V5NN9BSxgE7C4GAkfhTfGzahKj4/9O8D4VmkBB2vdfVuwCYjaI39iFm0GVppnNDoufhHkilyFBs6 8kwgglzRYof4Q9/pIvddl4jlb9M7S5hufcLAOXnDsRb4WI54srxM+HqsHMr4riwaOFmR4RdgK+0j yu/lwP7hchDlb+Xq0k/ACPMjUcTZ11UYRK2HW0NcflMgwEVw/wCXYjkhfdvyoZTYMcAsmny86mbp A552U8yRvws62kwH9K4hoOyWzCnzP0ltl2hJlwWN26liDL/lP1aSLe4U86J4WfBDBRTPBcwfuFJM IaSHGH/C7LpcujEG6xC6QN/2hHNgV3+WYNFuS4KrUovgZ1caEN4Zv+FcVGWP0lu5+F97Jlgy1AEb CR8BchS5fjima2SIOd72WvPFo5+GSZ10cG1eq1z+EBwCW2poOy7gGWKedt42AHlYE+XH69DW+lcV qDTxHVrcKkcd26vwmDCpmA6YzcLsyny6yKYMfHz8LkKrLTaOEyCMOuO62s6ZFikdSQQ1UZuBpA7F NkweTFN2N0u7lffUWVZJxJI1hkF+3ZMocAkhq2gMs2+6rzpFWJnwVJlF9M4+a31IKvAfOaYyCD7r tTFMHMtS10Z0i1rJEmXrx/Z61z86vs6LEjrKgyvO3YP/AAE52W5xcSNBd72XYkeCPa8DRb22WdHg DiSXt5R6hInhT6Oqf9PFrh6dvwsiHL5e7QG7rsary82Mk2BTI8r1TIhNCA4eyj1KoysDujriXLZg JuLfssaowB3l7WK7XiwQ1gtLF6vwmsyQx++kgFYWpXbO3xzqWDBZKaEudEXhHFg8k51aNA9l2rV5 SmhbpjZdqyaPJ5kY0mMD3W46qNcMjwUdWMwUsbzv7JsdA5o0lu34XaFVkyQD0w6lxrcszMqBqiLW g+yi1C9mfCdfS4bdps0/2SWYQSd2X9tl2w7L3nNAZTh/bhYkuVZ4pA3yg34WVqUbeBnWrssSTjZl h+Ev/SdRGb2sF3LRZdeyMa2AD3ssp+WI3x3BB+LLk9VTHx2zpalwh0b9Lwb+y5SLLfmjYftZdmty mx19MY1fhNblRzSLNt+FJarixHBXB1ccqkA/9kj/AEz2Dbrtn/SRe/cEFW7KjY3WtuVlaw34DqT/ AEs4Hdu6YzKhIuG/4Xa5ysbag29uwQMy+GtJJ0n2IW/lWrL8f+jreHKsjhcM4WE7B56eYtDSb9rL urDcvh0JIbcqT4BGwFxhBPvZcHquS+BHTLcGlc8aYb3+FkT5Xne9r3xaWruCHAYZWAxRgP77IRll ziRJ/lT5TQWFHSlTl/y320bJsWV2yi5bb9l27Pk9rLOcwvF/6QuUblKAwNLICHW7hbWsS7CwJnTV PgbaeMh0ZIHcBZP+nGVjG+XqBPuF2oMCaycRfpwB32XIHLbYy0RxAkiy5S1K7s6eGlwdLty86icW EB5/CyI8vmQXLNyu0JciTGUyWuTvZcjT5WMMfqhBH4W1qUzm8R0nX5fc4hoFh3XJ5dybSyP0uYDI f6iu2DkVlW9pLQ0k+y5KDIsVC2+wI7hZnqOODKxI6grMoRYfU3e27b7CydVZYgqoQBGCD2IXZ8uU ZMVqrHgd05+UBSDS4XIXjWokdfEvR1XBlFkcVmQ/2CM5dYLtkj2/C7CpKapbXug/QPfH/vA2XO/6 cp6h0bJWGMuO+3CvyJJ8jYkdJuyI6tlBhZ6b+y5ymyS2hg0vjs8j2XbWIZAkwuNj6SqaS4XAIWH/ AAarMdpmh7geQuj1G5cMqgk7Opz02o6smSaK7uyqLpvIXHytDYh87rtwYLrbdzQD3Ubk+aQGSneR 3IJXKOpkuzo8a9HVseRWx+l1ifwuOqMpxOqhE1oG+9guz5MGqmT6Awk33WZTZNId50jbX911Wq/T DxnVLshRROFpCbjhFLkljG7NJPPC7a/0u0y3AufZZzMvGwb5W/yFJ6xRIsR0lFlwxyFrmWHusxmW Wubu1dwy5OjLQ97BvtwsYZUjEnYN+VPk2PH/AEdRDKcj5LNZ6feyyBlqMu0Wu/2XbrcBawgaRpKz GdPYRGKyORvyzuq86rkysfJ0/HlElwu3fvYLMZk5gb6oyT+F2w3L8TT9ov7rKZg8ETQ6SzWjuV4p 5nHo9CgjpCsydGPtbb9k+kyO11PrtsF3ViWVad8DJow1zHjbSsWjwKKNohe30nspHVSqg4HTBy7H FP5dgQsuDJ4e65jOn8LuKfIOHRkTsDnSd2nhC3Ai2F4aBsNhZb87Jto6h/0XGXavLOyjslCoOkQ/ 4Xb9HgrZmkOaNSyBgbYgbtA9iqtQze1Ps6kpsjVELQGsACCfJwa4h8fq/C7Yip2xTAOFwCsifCI5 2mXTdZlnk3aYcInTP+l3wbhmy5TCslsxAF0sIAHxyuxpsHbKLBgWXg2GMpIpPM4PBKjzSfLEcaR1 DieR2MeAyGwv27LGkyLILOYDf2C7orKKKT7GXv3R0mXnEh2kEfhFqKI8cWdGzZNm81t6d4N+dKfN lZzoxG+En4su+5IWCPypI2kj2CVTU9LTSEzUrZAeNkerdBYkuDpTAshvMlxCY2g33C5urwGSji8u OPf3su36eCmrSWti8r2sEvFMLpo4XAND3WXOWqk2V4kdM0mSKmTU+WVha7sntyAG+oXK7ApsHMby bENPZcrTUkYBda4HN0WobCxqjqn/AEmb6TGAPkLjMTyliVOwiipPPDtiG+y7lq6SKZo8tmk/hZmA YBVVkVTUQNBigH8wnstrOyPGvZ09gvSXGZoRUujEQO5bfdc1UdPXyNETn6HgchdsQ1NTGzS0gRlc bUwESl/JPsucszkRQSOrh0prZb+XIw2/3LFd0rxUOBbA2W3+0ruqih82BxcNJsgpJTT1GgusDtdT ytey7FfB1FFkDEIYruwqeW212tuAipOndZUkh9JJA093tsu5ZMZxTA65jYakOhfvpcLhZ1XmKavh AqBGX2tdoVeokujWxHSo6U+S77muc73CyIelFeDuWeV8Fdiy/wDEEjj2KUyKtgdrEt4x2uj1E+yr GjrGfpaw1jWVVK58ZPLVzB6VUFHE19LCfnVuuwaerMhs+xA/wsikroZ5XQN3PssvUTfJl40dcQZK icC0wtB97Jr+nMEkZNi13wvv5Y4qWUl4GlGzFaQxmMMuT3Cy9RL9NUqqjqxmQ43SEObsNrkLJb08 pHDuD8LsHyYIwX6tQKfT08E4JaNk+RJLhkjBWfAw9MoTFrbPpP8AtR/6DdDdoAceL2X3gpvLedAs 33Ky5gyCBri4OJXn805O2dtkWdWO6bTa3OMQATYclC2kj4XYclcXCw47rEMrbgtAXeOeaRz2JHx8 PTyOV2p0hafZOnyQKbh4eF9lBLHpu8hXJ5TjcG4Ky8kpPkuw+AdgUbCfRYj4T4cuR1kdrNt+F9o4 0kTfWwEpLqePRris0fCy5S/Q4nE4dlakpoiDG2/4RvyxC4l2kaewsuZpxCR6nEOXINpmyQ+l+pPN KqY2o+QlyjTTcsF0UOSKbgxC34XOSN0v3duCsmHMVMxwhewE/wC5V5ZNE2o4ePIdFG64iBJ+E+fI N4waaVkL+Q0iy5efEwS18fA9kqXEBU6XarW53XHdIqSPnpcp1sDmtqXNkvwWLlIsqQGMamtBtuSu cjxKB8TWvI1D/cVxGLYv5bD5e9ttlVJrplSOPkwWGmf6WAj8JkOBsqpAQ3SFkYVWw1zmtl2N+65a sdFTygMcNJ7Ba8kvZGj5mbJ721YeJGmMHhZrsHpo2C9tuVywoHYmHRxzBptflcFiFsMk8mWYOIO5 um5sJDY6SFr9UTQSP8rkJpnzsDHRhjQPZcLDXt85mg7Hv2XPtfWvDPLgZJF733Ubfs0cTHhMbZi9 9iCsj+EU9QCQ0FvsFl4q1sUIswscey4CDMT8OmdG9npd3Kq56I1ZyIwWmjIBiC5ilFLBFo/Rx2I+ 62646nq4Z4vNdKA3nlcfVZojiJELPM0pUhwctNSsdcxm3sB2WNNhbqhlnG5S8PxF+Is8wQGL3KyY MUoXVHk1FQIe17rFsvBiOooYo9DhdwRUNo73sGgrJxQYbSR+ZFiDJb9rriW1FPI2zZPu7q7rIz6X ycMxGAtfSgvt9y4ykwekw+pe4QFoJ5IWAccZglpC7WBva6czqHBjjfJiY1jx/u2WabMnJVcMMsZE TA35C4upZDFFeYBMbjjIRpfpBPyhkxLDapmmaUD4RJl5G4biFI2F2kNa3u7smR1lLPMGgxyDi7bL hsQnoW0j4ad2rULbLi8FZHg5Di64LrnUt/8AIXB9rWYHWz28mluw8EBYv8Mr8PDRUte0O4vwsKu6 gVULf+FqfLsNlwOI53xzHqcUj6hrm3uH8FbW70yezsGGiYIg8hrj8JjayOnGkRtJ7Gy6sp8VrcCf qqcQLr/0XXNUvUehlAZLG7WP6k8cmWz7OnqaeOuE9VTieP8A2lfRYhi9HieGlkUTIWW2aBwuo8Sz 5FA3U3jsFzOE5jpMSox/xLY3kXLSVzkpL0bT4OfppI42OaOb8BZkMzRGXP0gc7r5VmM0NE55M4c/ 2WBiWYW1ILY5gGHmxSrQpH2H+q2+YaYQM0j+sIaySOVocHA37L4AYtFEPS+5PJusiLHm3Gp3+Vdj MdH3uDPgDnOkja9oT8Sx+io2n9PC1ju4AXW9Rm2Ojv8AzQAflYkOboJZQXPFj7lYcGy2rPuf4zLi DxdgZH7lcxT0DHxh7Hb233XXlZmeJ9PpjcBtyFx2EZhqqOqc815fER9hPC14mas7KqpxTNdebcex S8LnZX17GuI0ck3XVmL5xdG9wbLqJPuhwzOE9HeTzd3dkWKVcmNx27jWaajD5PJpY2uhG2oq8Mr5 a+Avlkufb2XVTs7xTSt8+UBt9yFz0+c8FwfDjNBiAmeW30X4V8bXoOR95IY4jd0gA9iVhzY4+kjc 2lfsumoepYrqtzpZNLb7C6y5eokLGubHJcn2XTwyRy3nZkGJOr5A6R4udtyuZj8imYS8t1W5XTFD mkVYJ83RY35WYOpElIPIlAlYNtd91z2SR0tH3j60jFfOc8aG8AFfRjMVTLG4w1BJ02A5sumKnPtE WEh2lx35WJD1IFK1zYXk39yujhPjgcV2dkw5YbiVQ6SeqLZy69i5cv8Awapw+Laz2gbG66ZPULQ8 TPmfqG9wUqfrtBL/ACv4g+NzdiCNl0jik+kcrXs7Y/i9XC9zfL3Hus3DM21kDj5kLRbuF0PVdYpn O/4eobMSeSE8dVKyWmvLZnyFl4pWbjJI76mz9Tzu8udhLjwWpU2JMc3zGyAMPcncLoGlz26peXCS 5WUc5vew3qD/APZuo4SrhFc7O52Z5p6GcRzS+Y0/KVWYxDO4yMktG7fTddAV2YpHyF7X3/dYpz1U RCzpXW/K1HTtjyLo7+psXp45rlwaucOaKf8ATj1B23C80x9QgT6pTf5Kz2dSDC3T93tutvTsm87y Z1BgpJnRiD1dnXWVF1JxCnIkgp4pGHlpXnKqz3LNPrbwewWTDnyeFmzjfsufgfs0pHpP/wBQjiIa ZqcRu72WLUY7DKdQk0led487YpIS8Ahg32KyBnZ7wC+VzHflaWFojyL0d4zYowu++91UOORsOlxI bfldJw51ki385zgPdSfqE0t3fY/laWBy6M7/ANO9JscpZQ31DZFBj9JTk72XQP8ArwhpIk/ykTdR n6bF4WXppojlR6CmzpS0rSY3kv8AZcQ/OFFUygzEtN+SuhZ+oEljocSbLjHZ1lnd/Ne722SOnm0T eeopM6U8cF2vadtjdfK1ebxPUkul9IPYro45ncyO7ah1va6SzNzwT/Nv+63DTtdlc6O/m5paWjTN o/JT2Z1ETbOna78lefXZ2cwbyH+6kWe4Xktc/f8AK6PT2yKZ33NnelfK0y1YYR2CbNm+mqG+mYO2 sDddB/xZk95A8O7gXWPJm10Q0tdp/JUlpU+kaWVo7mdm5tDU3E5Dr8X2KysUzxQ45ReS6JwkH9bS uhZs3ajd8m6XFml5dpbOAT2W4aLarMSzWd0YfmU0zxE6Ylg4uVz8+Z/5TRBKGk97rz9JjlS4tLph t7FKmzVUR+kVBP7rtLTf0c1M9GMztFQxfzqppf8AlC3PlDVOcZKhjbDglea/9USOd63l2/BKVVZi LzYHT7G64/Fk30Fko7zr+oEUMrvLcNPYhBRdV6iFthOXN7By6NgzPJG7cNcFl1WJipp/MieGPPLQ u70ppZeTvCTq5WVF2SOiMfF1x9D1Bp8OxBtRMQ6Mn1MB5XRhxp1E0GR5chmzM1zbkHUeFVprXRfK rPTFf1Yw6sa39DA5u25cVxMvUNslyXAfkrz9BmdzyI4g4HuVbsxSAkF6z8auKOiyI78PU+enaRAY n/Dt0yHPr6m7nOZFIedPC89jMhh9ZeSEk56lLvLjBPzdaWmdHN5jv2pzTVVUwbHKAL7klBFmiow+ sjmNZofGb7HYroj/AFZVOuPNLT23Vf6iqCf5kpN/lRaLcZ8x6of1edidPpMzZHgbAFfKYvnjE56g MMTGxE/cF0CMzyUTh5biX83uuUh6i4i+Hyi1pHZxXN6KUZdFWWzuIY/UFuz9/ZI/1PI1+mQua7sQ um6jOuKamGKdkbgeD3We7qNUyxCKdseobFzQu/xq9G9ya7O35s+y09OGvlv+6xI871oGuNoLD3JX SlRmOWepuZdu2+yyJM2ziAxiTcDsufxNxmOZR7O43Z0lkfuRc8pVRm10e50uPuuj4c01t3EAut3K MZ2qNVnrt8Xacnls7ffnacPuHAflIrOosk7fLmbE4N72XU0uZJKmO7DYj2WDR4rJNUFsrtvldVpt pjfTO1Y8+uhn9M12DssiXqSSfQ9w/BXVtZiUZaGxkNI5IXGS4lIN2m9kjpk+zXlo7cl6izTm2p7v 3RU2e2xvBJe1/e5XUsWY5NNtOgjv7q5cbc9t3O3W/iR9FWZHbtVnRtUDqkLu1rrjJcfdG4ObNsPY rqSXGpXP0skt83TqDFZm38yTUFFpFHmiLNZ2/Dm15O8xP5KxqjPseEkyzPJb3sus5seMI1F1kl+O R4jA4bEjsVtYVfRJZLV2doQ9R4MeH/DyOt/1bKhnKelkLPNFvcrqnDcUbA70gM7bLJqcRbObuc4f IVemsizUjtX/AFi97TeQG47FcZJm2oExaHDSV1t/EDFs15A/Kv8AjTrW1b+5XL41DznZJza4DS+x +Vj/AOqIxJcut+66/OKOnYQTY+6w31zgdz/lbjpr4MPL7Ozps0xutpcscZqnjlaWS6Y/Zda/xN7P 6iU5uJvdE7f1Hi62tIvYeovo7IxfMZlEbonNce90lmZnxgAvt+66vbX1TJheS7fZNqcXdG3dxK38 VVQWe+zsmTN7iDpdv8JMOeKmKTSXkD3XW8WLlo1atvysmmxtjide4V+NGqoeVM7ElzjNO60s23ax ShmSZ7yBMS38r4uKqp6je9j2WPUYi+G4a/v2XN6ZdFU0jsOLMJY2z5LlJOY33JB3HBuuvRjL3EXK MYy4d1haavR0WZI+4kx+Z93OlP4uhjx2V5/5hv8AlfFCuLzfVceycyvIILTZdlipdEeVH2b8fliG 7zdYE2YnvlFpSffdfL1GIP1WvdYxq9MgN7J4E/RzeU+x/wBSOFgD/cq4cyyF1nCzfdfFTVge+4Nv wlOr3NFmn/K7LFwY8h9/XYjFLFfzQWnmxXzQ8uirPOgrZId72BXzba98LzqeXfF039WJDc7391Vi S7RiU/w+tlzRUOvaoLgB/dFDj73R+YXuN18myoazURyqdiM0Ya0geX7p4I90Z8lH1ZxyUnVq2/KY Mzy0zGl3qadrL419fc212CbJXxSMYA65b291vxKqormj7mLOjGs5b+CnR5gpa9tn6WHsQuvpKpkj LadJQifZpY6xCw8CY8ldH1+IY2aVxEcpN+11jsxqUMJdKSSvmZKpkwuXeocpf6twFmm4Wlp0Hmb4 Pqf404m+u6cMe0j0u3+CvjP1zm3AKOOq1Dk6lt4FRjyH10WYpnyWNwFJsTdMCbm6+Xinc4F2uxCn 8RfELPdcLPho2p2fQfr3tF9VkwY2WkAu3/K4B+Nwsh39Tyly4pBJBfSQfhZeIOf4c+/E3P5uQm0t ZGyQPDbPC+WjxRtrgm3yi/jQvdov7rfj4Ipn2LcUFnGywKzF376XWPwuDbjHmNFuUElXr3Kz8dS7 NeVo5SHGahkhBedJ91yLsWLohc3K+cZNqaCmOqtOwW3gS6Oe9vk5puLyxG7Hubf2KfJivmREOebk dyvmHVpGxSXVhINyVj45PJR9HBin6f0h1/3WX/GHFt7r5Rj9QuXXRfqSGkE7KeCnZry2fQvr3O9R fb90t2Lkj7zdfPipc7YHb8qEOaNZP7KrCXyHNx4pqf6n7Iv1t3kB2y+eMusXPpHumQVkLR6Zbn5X ZYuC+Q+iNQG8nlcfWYk2J2k8lBHXQloJeCR8rGq/JrnXDgHhFjrsSmmuB9PigJJDhssxuNvYRpP5 3Xzj6KKMaQ43+CpI8wxWbcn3W3hizjvaOc/WMfIXG4ce6y4a2NzDGZSPkr5A1r42i+6yGYgHuBI3 XLwV0a8h9IcSlprhrmvHylnFDIeQD8Lhf1tz+UkTAudY7raxDec0+pc9v3H+6V/Enh2gOdsuNNSd IsUcNeCSCwH5XaMUjDkzPkxF42J/yl0+JSRvIJ27LEeQ+7iUpsrW8nhdNqG5nMtxF25JssGsxOWR 4DXloHssR1QCdnXCDzmhNkRuZycWLSeUWvOr2WZR4u2MadNyfdcAJLC5GysTtALmndTxxLuZz9TV EO1bb9ktleWi9yuEbWvk5crFWW97rm8KNbznTWmUfcQq/WCnFwey4h1T5jGhrt1Uk4c5297DhcvF zyN5nDG3tlNinHFi8eorgdTnt1WtfhJ89wdYm66LEjLyM511Rc3G4RmQuIseOy4iCpI2KaajS0nV cp4zO+zPfM4kHmyZHJfcri6erMh34THV2hxA3Wtl+i2Zs1aYnbO29lHVTXtBuPwuHlqCXb8KmVQa FVjSJuOZM+w4CRJWgO2WGZw8agf2WLre953t+VpRJuM+oqnRkaXc9kDKt/JN/dce+RwdvugMhjv7 FdFEjkcwao6diQFX8QMbdj+y42CVz9y7b2TCQTdx9KbUSzLFaX33sULJXOdYnZYFROGEOYi/ViRo N7FTavRncckd+CkT1nkuAHPwlh8crf5jy35CCCKMlwLi4DglSiWZrK02BJsCnsqgOTsuLebXs4EB LM1u6y0as5eSoLmn1fhJ883BJ4WA2qGndL/WXd8KKBbORlry1wLd1X6t3uVxJmuXFv5WMama/ddF AzvNv0+GRvBIFx7JIwaia0ufFd/usXA8aNU0eZu47Ln5qEy0xe3YFfyo/eI4OKjpJpdIs23ZBX5f pqgFj2hwPcrhcb/VYVIZIrnuiwbMMlawNmGlyib9EdI4/Eem9GZvNgkexw3s3gr57GMuvh1Nc0kW 5Xa8XqjB5XF4zQ/qGE2HCRXNiXB4F8QGHlmIWLbAE7rp6he10Jc3cNNiF698SvTx8uCOr4mC43Oy 8bYVFLHUTUZIB17lfu/8bkU8X/B+b10alZzoe0x37lcTiD2wG7iFydQz9L6b6gBsQvmMUqTJI7UC QF9zH2fHkv04yvnb5pKwHyD8oqtj6p7RHsjiwmeYb8/AXuXCPK0OoqqGnYXPdY+yXLiV5CY9x+VD lqV776XvJ/2tXM0HTDEcQZ5tnQs+QsuUV2woyfSOFhkfW6owQ0n3WJHhJjqSJj6fcLsPC+k073Al znW5svp8P6Yhjm+ewEfK5Szxirs6xwSl2dQvhipmkkOkb2sEdHQyV5Ip6eT4BavQNN0+oYQ0+XGb dtK5imyzSUjmlsMYuOWhcVqo0d46VnnmLJ2Ky6dTC1h5BCe/I80L2PczUAdwF3/NgzH6rNAb7gLF iy3HO43sGhZWqTZt6bg6Kqun0tbJrpYzHf8Ap91I+lOLmx8vUCu/IMBjppbNAsFzNJRN/wBosFme s29FWlTPP1N0VqzEZKh2j4WR/wClwfGIy9zbew5Xf1TSCVhGngbLiqfD3nU2RoJv7LzPWt82bWko 6foulLi3Q2azVzdN0cD2Au0yNHN12fHhgjPAXIU8AhFr2asS1jOkNKvZ1fB0Ywkwnz4NT/cFcPXd B4quYNppTCz3Xd7fKO5HKxJY5o5CWOAjPZSOtkHpYtHU9B0Wo6BobPO6cj3XMt6Y4ZEwBsYG3svv RTeZv/lA+mIJtcgKPUSbKtLFHwH/AKWYY54c7c3+0KpumGGseHPic1vv2X3jIQ+7j6SN0l2IF7zE 8gjstLUM38eLPnsP6XYP5RAh81vJKz4emmXI5PVQtL/cr6ag0RiwdYlZFRRSBusXIK4yzyvg6RwQ o4H/ANLcr1TbfwuEkb7L57E+m2EUlWGQ0zImk7Cy+rmbN5zXMlLQ3ke6KeE1PqfcnsqtVNdsj08T 56j6d4aLMETCfwnSZEpWzaWxhoHwuSAnpnXYSSPdZ0U75YS533K/JkRaeJxLcg4S5nrpWTE8ghIP TfK0UvmHCYmv7X4uuRmfPK8aXkEcaVc0FSIryhxCz553aZfBH8MaowXCqGD00cAFrXa0LiZMGpal t2QAAfCypnAAh2o/lZ2FNDYiL89lrzSJ4InDfwKBoH8hhA+FkUGCUdRNaSnbpHay5ySJuk7BDTMb Dc8FX5EkVYI3YuPDqGnsGRhnZOkihYwWYCB7hV5P6wm5tb2WQKUtaGjhc56icvZ2WKP4A40gjGqJ oPwFhyQUReJBEDf4WWaK97D+6B9MII76b24C5+aX6bcI/hyMUEH6T0taLjhYEdJEHkmNoPvZcayq qXVbGNBDTyFysbXNcdRTyz/SbEG2nJZby2FvPCyIo4GMA8kavwlmUtZsVbJgGXPKzLLJ+wsa9Ij6 ZwvcgR/AQSNZPHobGAR/UnGqEjNJGyqENsdPKiyyRfGjjZKB0TdQuB7hZVJUuiYC1xLh7o/LlbMd Ugcz/aqc0Rk7AAqvK2h40g5HTTNc8Odf4Q4TJO7zHVTnHT9uruo2odEfTssoOdUjcBu3ZcXNm1FD n4o+Lhu3wEltd+sd6mabpbXFrrHdPiLXHgBYUnZaH0v/AA0oc1oP5CVjOI1VWG3Y0NbwALLOp2Nd tysWqw+oll9IswKOTLVnFwTTOsA2y5mmLYAC8A3WKyIxuLT2RueL25UU5fpNiGVNQ3US1oDSsGST RGQwnU4rKfEHNHsqlw+zPMY4bdk3F2pmNQ1k1LXQMJ1tLhf8LmsxPdV4yGUY0wBoLre64eiiHnmR 4vYrlGVIbJdotfkqqRdtGVSwuY07ahbhcRX4k+lkLdOn8rmmzvis9vC43FvJrxqLbPHZa3Eouzq2 kbIw+v2CwZBM9+mRpB4sVkRV0kcbGRstp7q3SvLDM7d3dTcGkFQUWnW4824SZ6eaQeXG4t991k0u Nx2+yx73VumErtbSAD7KSk2EhNDJJRh0ZPrPdZgxGSNzW31e5SZYgBcG5WP5gHKxZaOSbTlxMrgL HlZEc7Y2kMOy46Br6g6WvOnuFk2bCdF7lLLRkEOcL6j+6w64NkAuTceyyWuJNuywqraQgrJqjCZS s3I3v7pjaUiYWuG+6dBG24LlmSMAguAtGQYXObYXuErNNWynwDEZCdo6dxv82TKOJ0koHZfKdYMS /g2RsWfez3M0D5uu2KLnNROWXiJ5GeDUNqZdX3yG3zun4FhL6iX2ueFhULXOezV9mq67KyRgL8Tq tUdiOwC/XN7Ufmdu+Rm4NgPkRAlgtb2XLwULXkhgX07MDkoT5bwDcJ8OFude7A0jggL5s83Z9CGG j4+egkj2AKxJ6OVzT6f3X3cuDk8hYs2CvbvpuCuCypnV4z4aOiqA02uAjZRTxt0yXBPC+wGDku0k ELJqMBM7AWtu4CwW96MPGz4l2FySaQHgkoZcBc9vq3AX1tLleqmmt5ZbbuVzMeU5wyxbeyy5pDxs 6xfgTSBpDg4eykeXg31Ou4/K7DnyzJCSWtuVjswKoIJERP7KrJEzsZ8OMKbCTp2WRBhbqh9pD6fl fasy5K4Evg0n8IzlpzRq4Cu9GlA+WblaOFvmNPfhDVYEKiwZZpA7L6mmw+WSYxuBIC5Wny+5xs0H f4XJ5aOixWdZnL7mO2G4Tv0DovSW7Fdkuy06F2p7LlBVZfgq2tDW2eOVVmTDxHXbaG4LPLKn6PyX XAsvt3YC2nlEZ+5Iky5+p1NIsFtZEzDxM+TaHlwsLgrKhy4ZneYRquvqKXI0rgACSB7LkYsBrKIA aLtCxPMorgLGz5AYVDSgtkivf4XHT4OXvvG2zfZdhOwwTuBe2xTP9PtaNTWXBXJZyuB1wMDlJ9Lb FNjwyti2Dmlp912F/BQ1w9Nv2RR5eFQTc23WvOVYz4B2EjZzgC7ujZRwucB5QJ/C+4dkp0pu15Cy aTK7aV/8wA/KedHRY0z4CWiDZGhken3ACy5suQ1VM1wh0v77Lsv/AE7SOjLg0AqQYFxpFwFzepS6 K8R1vDlymjYP5d7De6qXLVLM0uMQDfcLsufCmHbywT8BcTNg7615hgAYRyFw+RKieM+DpctRVUpj iJTKrJFRG29iR2Xa2CZIiZA4TP8ALeR93ssd+TqzDKi7qo1NOdxtwnymi+GzqxmXKumZ/wAoO+Fb 8Lqp3hrYtB4Xa82EtbuG8oYMCbI+5GlaWpI8DOsDlyfiYAuHso/Ks5LXvFmey7MrMF0yAAX+VUeC TVbgxoLh7AKrOyrAdd0uBngRi49gs1uW3Ts0kafcrsafIOJUtO2rEQZH/tPJWP8AwWTRcssT8K/I Oywpdo6+blNsYIvcLFq8suYwGJmsjsF2N/CnNduNvwmfw7y2khoWlnL4YnWtLlqWYAuiLT8rKky7 LTxm8FzbbZdiQ0Ik2c3+wWSMH84mzjtxdR6iwsCOnJcJId/MYWn2TIcuEzMey7AF2y3L1PNUBske p442TqzLQhs4Q2b8BZeprsngR8AzAYZ2AhnrHJSJMvjVa1rLsKPCC1loojqHwrpsvTVUh80aP2XN aj2beFHwkGADSPSLrKOXbNvbb8L7yXLDqYNIGoe6J+EPFm6eVxeo5HgVHXf8GaeQP3QHAwXEAA+9 l2XNlGMxtcfuPZYwy42JwAbz7hbWoObw0dcvy75nDDb4SG5a0X/l7rtU4P5LAdACuHL4m308/C6L VIeM6ibl4ukIDd/YhZNJleR0vpZY+1l2w3JgJ1ts0/IQuwCSF12gEj2Vlqk1SHjR1s7AZYRodHv7 q4cF/pc03/C+/lwiaSQAxkuPeyzI8sPa0Fzd15nlpdmlC+D4WnynHK0Oc1NdlZumxb+F2BFgpi3t /hZbcJDmjYbrKzv9OviUTqybKULbAPsT2VQZcjbM1ha14PK7Gr8vaHh4jJCxxgkfmDRGdQ9l0Woa 9mHj/o+FZlGCkqPNY3a/22T5cEiqX2EYH7Ls+LKrqynuI7my45+WJ6WexYb3Vefd2aWLg68flNxF 2x3sgZlScvBERFu1l2U7DnRixFre6ZSNDX2cLrlLO10XxnwUeW5HANMe34SJ8nOcTaK5/C7WZSRu 302WRS4eSHOEQDR3I5XFamXonjR03TZAc6pD3xWA9wuQxDA5YKctggOoewXactMyYaQACO4WTRUU VO7U4B5+Vr5U0WONI6TpctVMdMZHQmMuNzqCy4crMkjEhYCTzsu2cZZHUjQyMAnmw2WJBgjYog0t vdb+Y32dNh1icrsHDA39kcOU4xJe9/hdkS5fjlIDbhxXLYTkhrB505sORdX5XHZh4030dUfwOJt9 bOPhIiwZk8npjs0fC7lmy/RTPLfSf2WJLlWnjbeMC3sAua1TI8KOtmYW2MBojBt7q30gaD/JuTwb bBdiNyxBI+xuFljKlJpsCCflYWodk8Z1VDgDqp2oxgg+wXKxZXcGNIbpt2X3j8EZSN/lgEJD6eYf bGXD4Css7kqLHHXLPh5crPllD5LEexUrsuRiAEQAW72X17aV9S/S5jmFZ+HYK6pm8iUege/dc1ko 1tR1k7CxJEGtYLNToaZhaIjGG/K7klyvg2H05E8RBPdfNPyxTee4w+qIna62sy9lUUjr92EPcTay CPDi2UNewW97LsmTKjC3Y3+AsCbLnlyNDRqI/wALosq/SV+nywy2HxhwaP7LCrMvvYy5iBHtZdj0 uHPkHliMtISZ8NLnOZYkhcfNTNbVR8LgFW/AmkQU7S87eoXWXVwVGNAvkpmNf3LQvqY8qySv1hgb GOTZcjQ0UTXaC0bcrDzV0XadZQ4DJSSG8Zt72WLVxtgm0eUd+9l3b/BKerFiGsWBXZapIXDUxr3X VWoaMuKZ1dhmDVMrw6Jlmu7lZFdl+qZIG6LDuV2cyijp2AMjAFlx80TRUesbLXyGxtR8DNhcNLCA 9t5TwlT4VW4hS+XBCXOI2uF2TUYHSTFk2lriB3VwzRQyBjWhtuLLXyGjO06zy7lvGMPqXxywaGO+ NlzByvKZS7y7ldgySNc65dt7lS7CLtGo+4XKeocjagmdZsytUSVJc6LYHZcr/pYvjAe3SvrjG7zN TSGi9yFyoggnYwyOFwseV0NiOu2ZObGQ7SSPlZBymZ2XbYAL76tkp5ITFGL2HIWHHQu8saVnyTl2 VKjr6HKg/UESbi/Fl9bg2VqG2h9gSLC6+hw7D6CqD2TyiJ/YrjqvAXCrLW1Opg4cFPIy8HBV2S44 MQ0MLQ0n7hwuRdk6np2NDpg+/wDtXIy4eaVjQJDLfkkrHfHI1m23yjySaoHG1WWmO2h9RA4Q4NgN 5ZBNHpAWTTyzMrWlzrNC+gDqZ0RkFQ0k7Fvdc9zBwNRgjHNOjYriqnAWyamteLj3X1j3RUxEhIe3 2CbFiuDzgCelLT3cFpZJEpHzWGZcbGGnY25VVuExPqLOYPgr65lPhtWwuopHMcP6SsCTDi+pax8g aC4b9lXlkinCyYLC2G4Ze/ssemwqncbADb3X3FTJRYRURxXZPtvbdSqwqDEgJKaMR9yAuflkbTo+ XosvebIQ1gsnS4LHC4gxrntMkTGxQs/mXsSrljDWFspAfZXyNjhnzRw2EnjfsE12AQhoMwAd2WQK Vz6oaTtdBixkbOCXekDsrub9ktAOwaCkhDw0FpNrLGflqmqpAXNsOSsiHEgWhjiCwe6e2uY9+xtZ Tcyd9GdT5foBSBjfQ3uRysCqyrTgXikLm/KZ/ERC7c3Cc3HYXgsNgewWG5Fo42gwKMTlrbagsqsw UNaSW3KfTPYyoLgbat7hFLjUIe6N5v7K7n+ikIwmFmHgyPjY8jgOC5T9XTYibuiZGRsdIsuOFXBV s0sIBWPPDNG0mPSR8JdqwcjLhFLK64sQlUeGUsdQ8arge64mKuqKR13MNk6aQ1EfmhxYb8X3VVMt nMup6cXaCHEeywv0jf1jGOIAJ4WI2VsdntPqtvurbO6onEmoXCNfgOQloWec62wHBRvpmuYAd7JL JSyYPef5fcXRVGKU5bePYfKvPszwLYw0jiWN57hZzMPFfBrcFxYxNj+CNll/6hibTiNrgCFkUcjT UjaQWABP4WPPGJajU5o2+FxdZmFkMeoP3WLR48asgF4sTZc3Y4Pon0jsUkaBMGaBsmswsynQXC3c rBc+OGn1xuufe6wRjEpY5uu3ypyU5v8A05C529SG/F1kwUMUALGyC9l8fBUTwuc585kB3tdD/F5Y Zb3I/J5VphH1UOGhlVqe0Fl9ym4hHT8MFmr5CbNUsD/U64PAVw5sjcbSd1KkX2fRQU0TXagbrPY+ N7CfSXDsF8w3G4nDUHbFUMxw079nA37KU/ZpUfRsrGykxujAAUfBRVXoeC38L592ZY3XLWhYU2YG iXSHWuOyJNsy3RzWI08UDdETifZZ2GtElAQXWeAvlocVDnbuufkrPpsWIaS1pJK19iUjl5HMgA1E BcPPVNrpHwzOIhd/tKwa/EZHF1yRf3XFw1hil9bv7rcYblbJdHZbHYZT4RDFSucWMbY6zc3XDsqW mrDxuAvnY8VEkLo43i/tdBSV08Wp0kRc0f1AqPG0Nx95+tY/8LGralsAJbwRuvjf9UCKZu1m/lZN Rmymc0F249gs7Wipn1WChlW82Bus6vhEVw4hoHYr4fDuosOFSF8TGu/6XJWNdWGVrwx1MGF3cHhT nozaOUqMQa6qMbRx3XKUta2NgY+2kr4yixWKSVsrnDfdXi+ZGB4MZsAtULPuvPgab2sLLDrZGyR3 Y6w9l8E/O1TA27ND/wApcWe62teYpoGxtP8AUCtKMn6LuOw8NxKliGl0jC8f0nlZM+KuabsIDfhd TVtVBHiUVSyUgD7wCuaOa4ZobMk2stvG/YTPupK2Osa0xkCQc7plNURTtLHG7wuq25wjpJzrl/ys qlzrT7mGQ6jyCVzeJl3HZzpPJYS14Dh2WE6sEsg1SfldbYhm6t0eawHR7rHgzuXm0hF/yosbK5Hd kT6LyGaJmSutuB2XHVdS0SGOMgXXWtNnGKlaXRjc82Kw6nPEsUwkDha99yr4m3SMudHatRMIImbg O91nQSyUVC+QVGiN49TAeV09N1HNSA09vZKdn6Z7NidPsSo8UkVSR2sMWDjYyDSOFhV+a6HDrCZz tXYgLr6HNjZYw4usULs5UgBbLGyX8hVQFo7FpM3QSRXa/wBB7p4xaKptoIBv3XVE2aIZWkRAMB7A o6fMfkNBMi6+BsWjteqrxJMx7jfSkHFGTz2hBDO911rVZ5/TUxeTrsuGwLqa6KtmFQ4NjcfSp4WZ c0mdyzYsyNwGqyJuKxSxFuux/K6lxLN36qXVDNsfYrjv9WVAfbzdu+6xLBL0aU4nbVdjDaMANfzy uUy/i9JA2ScysMrm8E7rpU5pY4DzZLhY1Rmmn1h0chDvyqsMmqI5KzuOtxh09US99mH52Ry4xTRw DTM0n4XSs+d5ZYfLDrfkri484Ohn9U19+LrS09Lk5uX4d5UWNeZUODpLMPAKzX5qiw8EMcC75K6T m6gMjYNLgDbkLEGfIZCS513fKLTt+iqTPQ2G9QsMkgc3EZ2UzwLg+64fEOoGH1M5ZTvL4xwV0HVZ gbVTNc43YT3Tn442Jtoj6bbotLJsrybTuyTOMT2FrJAD8lOpcwNLReQH9150rc0SxvGiZwN+AVmU OdJWgNlnJb+eF1ena6MLNZ6IkzBBbeRoP5WNLnCmj280H910LX5ka9uqOoeT3GpYH+pZrghx/F1q Olb7NeQ78qM3RyXAeLD5S4M7Rw3aXXH5XRL84SRbOeVk4fjU1eC5r9IHysz0r9G1Pjk7zjz1Sufu 7SslvUKCD0slFvyvN2I5ldBUOjMjgb2uCljH5diZSR8lco6VyRh5KPSZzpTyhx80H91gS5opQ4u1 jUPlefm5rdGbaz/dM/1RYXdNp/JW1pZJjyJo7qxTqU+iZaJlxxcpNJ1ClrmD1hnvYrqp2NR4hS6R MHbchcTBjIoJXR+fvf3Xo+Kq6JuX6d+MzCZbEzOP4KyWZpDG6XHUF0TFnWrpiQ12pva6ac8zSxkE +pcJaV/h0WRHdRzpFSv1NeNQ7XWO/P0s8hcXm110azM0lRqLnkG/uoczubca9wtLR2ZeRHfH+t3g AtnLT7tKGbONDUQvFRU2lPBJ3XRMeaJLhuu6KXFxOy7pNLhxZdVpUjHmR3dSZlgkaWiS/sQVgYpn DEcLdrp6+RjR/TqXTVNm19E8tL9xwgrM4zVLg15uw/Kr06fFGXmS6O54OqtXJC1003nSD3WDiHU5 9W5olaGuOwsunZcymJhEbbX90mmx8SyAzH1A3Cx8T8Ks6O48SxPMFLhrK2zmUr+N+UjDOpU9H6Ki MPIXwc2fcRqaRlFJWGSmbxHfhce/HGkG9tR7rrHT16NPKjt+XqxWSwvbE8QstuByvlRnv9RWESTu Dr73K68GOOjcTqNlh1tZHLeVjiHrUdKm+TLzJco7pGcIwG6ZQ+3uU0Z2ljALHiw+V0fT1tU6EvLy AOyqXMMsLLB5v+VHoR50zux+fHVTtMrguLrcxsiqBJDM5jufSbLqelx18nq1m6yI8VfUyW18KLSU V5U0drRZ1qDbzJifklOfmsubqDyfldTnHBTEiR2oJsOb4iwssQFj47XNE8qR2bDnKUVAc2Ym3a6b VZ8lqpBGZNP4XWMOOMaxxiO57riKjHnxzXJJN+V0hg3cNGZZkjuFmbCxxDnXb+VJ8/Qk+VG7Q73B XT02YpY4rl3K4oYm6oqdYef2K7LSX0ZlmXo7iqsxCSQPlqS/2u5HFnKnDg3Vx3XUTcRlfJbUT8Kq vEJA0ht2kLfxaMLKztbF8ytqgA2a3ysGPNf6V7Q6Rz7d2ldYwYhPOwNMlnfBRsrJoS7XIHNV+PFq mPMzuA9RDHDZhJcRy5cXJ1FqhcBzjc9l1hUYxIIjoNz+UFJjUgADxYrK0UezXmZ2LPnDEKveKVzS VlU2aMToIgZ6ou9wSvgIMxGI2tZvcplZj8bmbya7ha+KkqonlZ2GM6NqGepxc78pL82bgXI/ddc0 GNRteSLEJ0+OMleQB/ZRaRIz5bfB95U57rYYtFKA8nbdDhmb6xri6d9nHkey+AbiYpySHH3Vfxa5 1iXb5T4xrzHZ7s0Ry3JO491x2J54/TtA12H5XwRxlwafVdYE07q5xDj6eeUhpueTLyo+6jziKiIv 1kNHdKZm6N79Oovb3XxNRUNhpfLaQD8LDpK0Nm2Oy9L00H6MPM7Pu6jMoY8uZcbpEmdvLNg46l8l U1ry/UOCggqoqaZs0jPNF92rawRSow8x9S3PVRJKYwZGn3BWQzM+IyuDWMc8X3cSvmqrG6erlD44 hF8IHYzJGB5btJ7hZ+PH8J5f7PrMQzFJSRgOJ1nkXSG5reWWDiHW5uvmP1rZnB07y7unNmp5n2YQ B7p4Y/htZa9n01NmOqcN36h7FOOMQ1BDZoIwOCQvj5cSjpnFjX3t3ulx4l5x2Nwr40uivJZ9DX13 6eRwpnAN5CfhGcnXMFWLC2xXyj67188LBrq+7g5osUWBSOXk2naUePU5aRE4A/lcY/GcQbV+kaoj 3XX9BjTmSWJtdfR0+Z208JY7e/BWXpUjosqPoH5kmjuHekLBdmUySWIuAvma7GW1Ul2ut8LGNbcg hI6VJ2SWVH1LcRbUVNi8MHyuRrMQbT0zXNkbIbctK6+q6pzgLEgn2SKesmomkOLi1x7lHpfwwsjP tXZhe03a7f4KA5yLbebqsPZfHiqe6XUXWuuToagOeS4NePYqLS8chZXfZ9RSdQmOHlRSmx2seVk1 GPsnYHh5aV13X1MTaw6YxG74RCvcQBckJ8Wy+ej7M50fHeG9jf3S58yOaBqLiD/VyvjJWuqXB2rS QmQ1sjWlj3B4HC7w00YmfN+H1LswFzRZxCxzikszt3my4ESGUneyjqh+zWN3HddvBEnlvs+upcWM LCCdSIYtrJFhZfKCqkYADsmRVr/x8rn4F6NeU+lfiVmne2yxm1zwC4u2XAz4hrOkO3+EEddoY4Pu 4jsEWBfg8pzc1fI4GxukfqiWHchx7rihjLB6LWCA1Rdu03CeBDyHO0eNS0kLmiRw/dKdjb5rapCT 7rgpKsvJF0DZdrk8LawJGXkPpv4kLAnf8onYi0i9rHsvnBW6d77JJxAlx32VWEnkPoHYjL5m0jrf lNGJHa0l185FWbbndH+q0OPcJ4Qsh9F/EgNyd0qXFRrFzcL541eu+6A1HO614qK8iPpY64OabGx+ Vl0mJGMgOdsvkmVj4xcEEojVzSndHjTJvZ9Di2M/zv5di32WMzGf1RAewC3suKfIDsRv7pJ1A+k2 VWJGHM+hkxQQG7RYEdkj9fq4cd/dcMJZh95uPlMkqGgAg2Ky8RqOQ5qOVzxsdu6n6uKgk1W1kriY 6xrWEajcrAq6txdYk291jxOyvLwcnW46X1DnMIaEMeNFwbd2/uuEa3znWJRafLuB2XpWKjj5GfSG ua5urVc/KpmK6XbON18+yo8sb3N1P1JLrg2V8Zd7OffiRkeHE3IRwYiGy6iLhfPCoveyttSWcm4W XjTLvZ9NUVzZ2Et2WEMSMbjZywoqm49NyEAOhz3WWfEkRzZyNFjc8krmN+07Iqg+XOHE6rrjaOQR u1A2umTTAn7rq+MqZnPrHRMuzYpMNXITqL/UfZcdUVIjb6TclBE8uaSLo8SG45tlYIgXPOpEK+Kd txsR2XBVUtogNwVjx1pibYXuixEc6PoH1bIwL/2WPVVhc0AEAdguNbWa4yXdkh0xkN/ZbWNoz5EZ 8dUI5CTuflOZWhzvS+w7gLh2z3uSblXDEC8uabLbgY3nNVdcHxgXusenIaSQbX7LF3aDf/KASgb3 WfGi72zmmysjbccpJr7kglcYK4Da6f8AqIZWiwGpZ2cl3D3VTiTZ2yS6s0m190rU1m1/wsJ7yZD3 WljTI5nNRYkXAAmxS5q8G4vdcN+ocCUsSucDvwteOjLmcsKwk87LJbWjRoabkrg47je9wUYmLTty rtIpHMRvc113OSKue+3PwsNlWTbUVb5WvddRI1usJ2p7RYWVtjczcEpbao3sOAikrQGiwuVraS6H sqXt2a6xTGTOcd3XXHl5PqO10xkgBHq3WXFGtzM9zncoWyOuofW0HUqdUCNthY2U2oWwmzOhcSTs iNaSfQdlhSy6wb8FIY7Q0tGwKeNMm9o5kVzCzm6UKjzHbLjI3Fv7p8bD5gdf9k8dF32PlqnR3ulN qw4bpGIT3fpsVitNzuuiiRyOQNQwg/8AdU2axt7LFawnYJrbsG6bUTcZJqS1uwWNLM+2onf2SpZL /CQSRudwqoIlj2zCSRrXDY7fhZzKdkJ2fqcuJv6gjbM9pNj+6rgjO5o5JkuuTSXWVulbTyObq1/h cX+pMbruaSmwzwlxdexPYrLhQ3GUy8ry4E/hNZqZe557LHE7AfSbKPqL2O6UaTMnT8conkRNB1Al Y36toFikyT6rkG6lCzLfVkt0iwWNUVeltiVjum8wgBVK0ahqNx7LSiLCjqhrD7ags2Grjc0k2F+y 48vbfS0bKrhjgL7lHGybmclrDmEcK21UUMZYWcjdYbTYbnYIX1LWC9rlRQFmTFNpvpTxMTcErjBV HY2tfsrdVb2K1sFszn4oaduiyYysdIy5XDue17ieFG1Doh6XbK7Cbmcy9xP9VihIeBfsOVxD6p7j e6gxKUO0nce6myhuOfppmm4FrqTSBhse64umm0etxsnS1EdQAWu45WXEbjJM1nelZHmgxixuuDnq 3RN9PKkVa9jAeVnaWzkpagj09kl72ACzf7LFNRr3OxRNeCRY2WqFji9hItqBTWvLXXBWMdm3CASu eduybS7jMfUOFzq3QCoEguVjGZjSdRWO6UOBLDZVIWZUkzQdkDJQ7g2WGASb3/ZOja5rbmxWqJZl xPedidkxsgjcTf8AIWLDIRe5VPmDSbcpQMgVBc8+yZHK0HblcY6RzACDsrZUWde4TaTcckZ3azc7 IvPje3crBFQH8ixSJmPefS6w+EotnI3ZrFnXTmgFcHI2phkbpYXs91ksrC1m/pPsoFI5GSos3TdY b6jSTo3PdR1nsBBvcJMIMT7nhKG4aydxdc7K/PLnkAkhBM9rzYHdC14YNufdKM2OFUQSAbWVQ4my CoLZATq4KWGM0kl25QmMOINh8Fa2i2cicSY06exWNI8OeSO6wyGuk9WxCdGwkXBurRLsyTVuADQL lC2YB1npLnlltrlKaDMT2VSBnecWD07N9wqMrg24WPHE5o5uB7otdtr3WWjaZPOI37I2zB3CwpH6 H87eysTBrgb2SkLM2OpbrI9lTnajyscSMILgQShbOJTzayUSzNMgtbf8rCnkcCRew7I/1flnRcFJ lkE77Wt+FaJY2CQ6N3bpzZwYyHG6wSdI0Dj3TXabC2wCpLJI8u7Gypt2m/8A3VB5fYAWARuGl93f bZAOp6on0n+yNtWGEnn4WA6qj12BAKoOaCDf91KByEbgC55O57KPc02sbFYj6hgbs4bLGdi8bHWJ BU2izkJZTGAW7pL3lzg61gsc1rZLD3UbJ2cbALSiZsdJNotZCX3N0qWenFv5zdQ7FAJQ7cPbb8q0 SzadhuKmOp8sNIsV2bgtV+qoWtcFFF/IJH9DicfmTDWvidqItyF8bHRfp33B4Kii6R6My7PpcPqH Oia0rlnUrDBc7qKKLs0+z4bqhlinzDk6uhkAbpjdYrWFmGjfgGaa2mY4P0yEav3UUX6b/ESe6Ss+ TrUtg1jjPGNXKxKrCWSg7gXUUX6q3aPzkkDh2UY6mZoDw1fc4LkGnp3sfI4SXtsootzlKuzWOMb6 PssOwajoH/yqeO47kLlXwxvYPQAPYBRRfNnOV9n0FFV0JY5lISGsFimkfqd9goouMmzaSEyU7o9w 5K/m6SNaiixZqhlPrcNJcsuI6LN57KKK+y0VG7VIW2WRcsbYFRRcZGkiqeZzw65uhvocTyVFFhlD FRcXsmsOpuobKKLYFvfa6S+Y7t7KKIiMfSyGT08WHKyJiI4TtdRRVEOFqKothcbWPwuOp4hI7znb vvsoouiYRniR7eHWKjcbrWHR5t2cWKiiyzSMiN5c3WTclclDGHRgqKKIrE1DNJNkq12D3UUUshjf rPKc4Nb9pWdTV5rI9DxdRRaIjHqaCIk2CVFE1h9IsoohRsjS5tlx9ZVOgAA77KKK2VI5DCvWy57r kywWsFFFzY9iQ/8A4gM7LKqY2P0i3OyiilmjGlwTyH+cHg7cJVvSSdyoopYAbH50exsUDm6BZRRL BGSk7WWVCLC6iiGinNFykyEB7W2UUWbBnw0bJC0OFwmvjDSWt2soojKYr4jd26kcexUUUAxlc6m3 Aum/xueRhtYDhRRRgS2oJLnOFyVbJrygW7qKKhnOOpY442ute4vZcTK0xykg+n2UUQvoxaubyA1w G7jYrMYAIgfdRRCBsqHNGx29kkPD3m4UUUBkxQNa0uHdQxi5NhwooowxT6RoaAA0au9lctN+mha0 H9woooVDxTtbBquTsuLfKH1AjAtfa6iiD2c9htP5Eeq97JjaDVJJUvIt/tCiijHs4+ur3NeNA0gJ Ec/6uQA3B91FForMmaP9OACbp7H+ZTnbsooqjJyOX6ZslLJI77gV1N4oJP0mSYmNveWYAn4UUXt0 n/miefP/AAZ5WkkcyKJoNhYLtnpDVSUuIhmrU0tBsVFF+ly/wPhYv5HdM8ArtJ2b3KyXYe18LNJ0 uHJUUXwMnR92KVBjDw+26YaBha4Heyii8ibNNKzBOHtdJtZZFNRhjwCblRRbcnRlJWcnPQOhja8O F1xzquQz6b7XUUXHc/020jmRhjHsa6+7hvsmw4TGHFRRZ3M4ySsqTCo9Djtt8LjqmjaP5YA37qKL W5/pmlYumwaOGUO5J5XK4bTNdXWsA0dlFFmUnR3gchV4TGb+xXGT4YyleNNt1FFhSZWkcfW4W3z2 yC2r3KyWYXELXG9t1FF23Ojk0ZsdOKZgLfbuuVggimoXSPYNXwoouUm7CSPkZ6TVVucLBt+Fn0ED nvDbjT7KKKt8FpH0lfl6nZQwvsNbhuVwzsMEThoIH5UUWNzNNIIMdC7VsfhGaZtQ0kgXUUS2EZmG 5dE0cji8b8A9kdJRinEjNjZRRQ3RjCmBrQdreydHhEbKvzW2BJUURsUrOTZT2b2snvptcdhYBRRc WboZS4RC65e0OP4Qy4TFrJAAUUUi2Cm4PAQHFoLkD3Mwx5fGxtx8KKLVuimX/FKjE4WmZ2x7DhLk w9nNhYqKLCbNGO7CoXHcbJ8GDwFwDm3Cii67mc/ZyLMEpo4ydA/ssKqw6NoDgAPgKKLnudmhVDhr W1HmusR2Fly4fD5zWSQhzXKKKNtvkqClipo2nTFYLi5Gsc8aW2BKiiEOThoopodLhf5TKTLscsoL nA24UUWPYFYlhrKZwPNkiTD2aQ7ZRRWwjFfStfzZVTtbFIAAootpmfZyMkQkYLbXVRYeyncHmzrq KKSRtIGqlhidqEW9lyNPRxT0LXgaXFRRci0cfVUxaQbjZBDG3zWucLi+4UURPkDpqlj5fL8v0/KX LCyBupjQLqKLTIzNoZpGxgh1rdlnwRiqlBfueVFFm2Q4jGgw1JjDQAuL/TNb6h2UUVTKjMpzqFrI hjJa0xaTttdRRbIXA4PJIFrrJaAHaSFFFlhEewOA7KOksA0jhRRZNC46vyZmnTexWXiuLzVcLY2n y2/CiiyDj4Kg0rxy6/uuWhqgWXLSoosoqHMmbq+3lLmfZ1xsooqQwxOTNoduDtso6TyZvRsAootI yKmrvVfTulxVz45RK0m47KKIwcjiOIy4tFGwnSbclJghe1mjXe3BUUWC+g3Vj6CAvJ122VQYgyqp y8Msb91FERTPoZbTAm5BCxKuqYKtwDOSoorfBkE1czRpa6zDsQqfTCNoc02vuVFEBRmlYz7zsrZV OmIL9yFFFlpGgzWanWLeFjylst9Q3HdRRQodGRbTuVykmBw1FKZrkOaoorFujLOD84Nc4PGoD2WZ +vhp4Q1kRuRyVFFtGTj6jEQHWDSLhBHXatrFRRSjTM6OrAjvp3Cxji00jzHGdB+VFFCHH+bUsqnG WQOPPpTHYzIAWb7d7qKLpFGBdPj05cWONxdZL8cfGNBbcFRRVxQAOJgN1aN0o1jJgS2MscO4UUXJ oqYxlaA0Rv1G/cIZtm+gkflRRZNozcIxF1Kx7ranDusGszBJW1YYQWi/ZRRUlmNVVro3XaTqB5JX I0+Zaymp2mKQtNlFFgqGUOdKxj7vAe491dVj0k79bgbn5UUWo/yNIUzF5GuBubqqjFHzHSe/uoou rijSRx9bUOpotV739kiPE3kg77qKLokjn0Zza55537LDqsRMdUQBuoopRLMRmYqqKctLtTSsuDEL Wc5pdqO+6ii5NI0FU4t5El42lt/lYc+Zp6d7S0u37XUUUSRmxzMy1D2guJKp2OyudY3UURxQFOxq W7rEgpkOIyiEvLzf4UURAXPm6SCMBzXOH5XGyZxc53pjcL/Kii9CSaMsbFmdxO7Cgfjr3u2BBUUW XFIJsqrxYsi9Qc4HdXS44wMbpY9pCiim1Et2c9DmNzqJwAdwuHmzBM5+1wPyooucUtxHJpADNElK 25Dn/lYVTnCepfbTYKKLrGKskWx0OdHMjMclM2TbYnssaPH2zzEOjIvxZRRdoxVm2Z0db7FwHcKp 5HTPAY4t/KiikooibGOxM0EbgQXutyuEmzDK6U8hRRSEVZJt0Mbic80d2yvYR8pIzBiuHkuiqyW/ 7XKKKuKMpuips34g5vmSya3fAsljNM8wBdff5UUXTGky2YNRjlTHOXRyOb+6qkz3irJC0zkxj+lR RVxVlsutzBPVgva4tJ5RU2MzRt9Ti/8AJUUTavwluxlRXF0Jl3DkjCcUNTUWlBdvZRRYlFJE9mVm DMNXhj2upSGtt9rlhQZuqKyEec0E/CiiY4pvoMVJmc6hHoO/dBW5inp42FhNz3Kii922NdETZlT1 szKETF99QvZcVSYxO8uIeVFFjaitsTNNI86nvLiDdZcVW+KDzQbEeyiiy4r8JZk4Vm6pmY+CQlzD 2XF43ikkb/R6T7qKLmoq+hbKpswTMjaDckjm6VUYxNNcaiB+VFF1UIqXCDYWG4lI2SxJIXJVFeWD UwW24UUUkkQ4+rzNNFpbvb2CwnZple8DSoosxhFvozJtIRLmOoadiRusqhzLNUN0uvcKKL1OKMxk xldjsxi03IC4eSumeb6uOFFFqEUc5Ntj6fFqloHrKyIcXlL7EkqKJKKFg19bK+MWeW/uuPM8zBrM hdbe11FFhRX4bUmGcXkmuNwAsCesdrubk+6iirijDbsMVLnsuXH+6gqrt2BFlFEUUmTczLjxE6Re 9go3HyCW2dZRRbSJbokNbG6TUWEn5WHiNRrdrbdrfYKKLMVyYt0DTVxEJNyfyqGJSxPBa42UUXpp CMmIxHE3ujB/qJXI4Vjr6ExEtL2X9Q91FFHFHZSZ9zj8uAYngcVRT4fLBVEDU8kWJ/uvgaiQxEhp NhsoouSSNy6MWSdzgXdx3So6pr93Au7FRRbpHmbZmUdUI45fLu0ALiajE5BUbjUT3KiiqSsjk6OS pcXe6PSRv7pNTXOa5tiRflRRGlZYydHIQVjJKe7mm/usKWss8taCFFFaRptmMamVryGu37EopsVn p47uIcQoosSSs52wf4j+rt6NJ90c0rg1guooulI4tuwBWOAHceyx6qrd5zXN2+FFFpJGjIixgxvA LSdkVRiBPqaCL9lFFmkW2LFa7ve6CtxJ8MbdA9RO5Kii2khbKZjkzmmN24t2WJU15vexUUXWKRU2 BDWvHCzYK5zHat91FFlpHVNhSVhlBBBXEwVcpmm9XpbwFFFikRtmXFikoAA2+EArJpZgC4WCiiqS ODbJV1bvLII7p9JKI2D072UUW2lRCqisdCC9nKxnV0tQ27jbZRREipsZSyOadQcRZUa1wcQdwVFF ppC2IdM7UQFGSu9yoopSNJsd+rLRpslzTFzDYWKiiqRW3RiMnLd23B902KvcPck+6ii3SONsf+sc ANr/AAVZxG2zowQeLdlFFKRU2GJiGj5RCdwHpNlFFKVBsx5qgudYoqcAOItsVFFpJULMeqr5CSGe kDbdKlqXaASSVFFlpEsTPJLZrmODUTauVtgTdRREiDY61zn6dwmVtW6kYx7e5sootUgFTw/q5Lk2 vumSTNov5cYO/cqKKUi2UKi+5BN0uSzwFFFYh9GM9oBBGyF9U6MAchRRdKRhMJk4NjpsnteHNNhZ RRSkasGUam8m4QPndKwMdvbuoooRgsf/AE8rJgnMY9KiiUZsXIwTTancoXHS027KKKmuxIneBe6r Vp/cqKLXopmx2sOVkxSlrVFFmwLfL5huVjmoIBHZRRaKzDFU4T27FObG9knmCQ2PZRRKMlumv/SE nzHAndRREA4iS7nlKmdoktvZRRdDIvWb7Krkm/8A2UUWaM2W2oIcAAsgSF9uyii0LK03dyo4G/Oy iigCDtPyjNV5dtlFFijdl+eXJD6l+rlRRVIBNrTMfLcLhE4mO4UUVYMV0zmm91TXOkO5uooiMsOM +v2KyJGANB7lRRGWJjFymv4UUVMlA3O2yNsYeVFEYsyIib6Wm3yjmLmt3N1FFK5NGKZSNwUHnl7x dRRUibDJDiARsiiqvJm0ht224UUQoVRICNVlxzp/UdlFERJMjZC/8Imuvb82UUWzmEWgP24UMhiI LTZRRYBc8rnM1XWK95IFjYKKLQsAyEELKimEbRcXJUUWKNIkkxG6pkgO+9yooqiMVJfWqB0n8qKL ZzDEhaLIHybXF7qKKo0E24cL73TZrsAsVFFh9lsFtyjbyVFERop51JR2ubqKKkYIqJQ0WdZOc9xi 1X3CiinslgMmdM0XKY27nfhRRdAVJLoICgqXNIsVFFlgIyebu7dQ3a0nZRRACKl0ZBtdEaollyOV FFS2C5wcy+6G2qwUUVRGU+Its66DUSPZRRX2Cn3PdIAIcVFEZChK5ribrKgqNbRsoosFF10pjFwl 08znN37qKKoGQToANroiRKQRsooqX0UQGnblBIzzSHcEKKIQA1Dmu0oWv8mYa/UD2CiiAZ5jHzg2 I+FJQDLayiipCpG6CgDwORcKKKkoIASC3ZDtqtZRRZKZDIzJZt9kZiEew2sooj7KKcA82PPugN9F mmyiiAuN2hp1epC+q0AC11FFEDJoapr5Q1zSQVKiZsUhDQRuoolABpZLyEt7BFcjdRRPYBpnid57 WR1M3kg23sooqDC/Wu1JrJnv32sPdRRUCZagvkcBsAFisq3ayOVFFtGTKiqHE2UdWPY427KKLDFj qXFnyh/Ia0InVLZIg/TuVFFCmI2vex9uye6vdp33UUQpx4xR3nOAB/dZMdY62/dRRbMgOxMx7Ftw EbsbaQz+W5RRGiWPZXtkOzSL+6ZDUuuQf8KKLJsCWqdwOQiiqXNd+VFEAE+ImAXIJv7Kv4lu30nd RRaohU1pPVvdYNRVuhIba9zZRRZaKNgf5jrAkBNc0ukOlxAUUVRGYz5nRP5ufcoGYg+NxcRdRROw N/Wul33H4Q/rDu0F37qKLSSDMWDEKhsujXcXXJ/rHRxO1jVt2UURop867EHS1O99N+Fy1NOZW2BN h7qKLUkjmnyMdSOmBs+11xToPKmN3FxCiiygx4xIecwCOxHe6qqxmaGXQQ0tduooukUmYbY2jxCi r7xTUpL+zwU7+H0/YPt+VFEaSZT/2Q== --b1_BNMouk2QAkY04aydMJgqfzTGi14g1bGPKykvokUvA-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 05:13:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 05:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400704.642396 (Exim 4.92) (envelope-from ) id 1oVnNW-0004mu-IY; Wed, 07 Sep 2022 05:13:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400704.642396; Wed, 07 Sep 2022 05:13:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVnNW-0004mn-Df; Wed, 07 Sep 2022 05:13:34 +0000 Received: by outflank-mailman (input) for mailman id 400704; Wed, 07 Sep 2022 01:04:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVjU9-0000wQ-PU for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 01:04:10 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f744562f-2e48-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 03:04:07 +0200 (CEST) Received: from BL1PR12MB5993.namprd12.prod.outlook.com (2603:10b6:208:399::9) by SA1PR12MB5616.namprd12.prod.outlook.com (2603:10b6:806:22a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 01:04:01 +0000 Received: from BL1PR12MB5993.namprd12.prod.outlook.com ([fe80::7927:cab5:fb94:1a50]) by BL1PR12MB5993.namprd12.prod.outlook.com ([fe80::7927:cab5:fb94:1a50%5]) with mapi id 15.20.5588.017; Wed, 7 Sep 2022 01:04:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f744562f-2e48-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfoAXYM/AccBBUZ2kvIQPbesPVs6Pqh5OEmy+ft0xDBTmw31UY9zoPPVRY+7deQuA3SbHzjZeOEzAx1mNdEGEiv2QZYtUD4uuBd/aduFUmciZOuT5VDz58SYkTiBAxy/sZqomQfn4ndcCx54yib/liahZPxUaKZzaLZcK+aZ+7hzcV9cJm8OSw8u/4Q/YsWuuh70JPv7/uAQYhhD0ZV9zgBZPJOp7FjOwdUvB+U48N98hBBGDU8MxrB0+lh8cwJ14khgrs2c2kIDbHxD+x1YgRB1hPp0hCVquKjehCocwn9ar8MrXMLH8fEsIpvkCxc2LYSdpnKQ2M/A0ZWCU1o8VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EfbaVcDF/+HgzY2EZTlGKVJ2eCb7mUtllno1jGHWAS8=; b=ZBA2IC+nWKZZsUNB+tNpDQNI2zuUA7DNY9ohZ6nRYzykkfjZJ5kWW89ZFFWeYI7CobB6pev969okj8G+biMljsba9NABsBSgPhM+yISniNohdCyfRtw950tUGJ+/REjbUeecxRuyZV68W5n3btKlUw+8oL3G2xyNqI9t8p1RtfNOKdcWlwWdun99ZI1GfBXvSMKKW55t4ZeJZmSJcd+XlsfLn4UjVL3bi3zaJX6fpxHvosAxN/1pUE+b6JixuGhDqUaikNDZV5Dhuhj91uh/92KEN1qhIDMhP3LHV6NhzQa3aoBVrNLax3adh31bpoUbL90N3tCp8GTyziX/OdxTaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfbaVcDF/+HgzY2EZTlGKVJ2eCb7mUtllno1jGHWAS8=; b=GOya7h7Ehb4WLZI4Y4iYrVKshgjV4iBhGXc8buGu1oQ28ZnYDilzTPLAIA2NwrZN8wtM1S6zhz/WmiBYrrCtzKhkBwmYKTD6RW8TGjWGV9vsNuhUubKsfkhWiJb1KjB4uv0mR/61/rvFGwW3WVYDnbmlrvRaYVpzKVl882WwB9g= From: "Ji, Ruili" To: Paul Durrant , "qemu-devel@nongnu.org" CC: "Liu, Aaron" , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Topic: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Index: AdjBw9S5XjagBB9xT0W01YXm2Fq4yQAkLQ9g Date: Wed, 7 Sep 2022 01:04:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=149f7e60-4d0f-4975-8ab3-8497009eb09c;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-06T07:36:17Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61751dce-687e-483a-9f93-08da906cd9a0 x-ms-traffictypediagnostic: SA1PR12MB5616:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ke1UyxEBtHyBg9EOnYYHA8ZrLreqPqczERLgez4hAsNj4B2ApcN/ltpQCKDkDZJcpaA8tBisN/jXkN4UhUYtpsTi75f7cIb89HWB4ocWjt7yohqc4qpYFF9a4vxdCqakYT1gAvKc90nOewfDfVmH0rvDjXyKUJAISaRSJNjZnqVYkGgo77IHY9ltvbT8OkAnFtH40NBmliIpEr3TJJuO2p1B/PNfyd7EZgoFhpkHpxtapKauAAHRn0oyJEvuwq1OulfhiDjlvkStuQls/q0s61EBOcHiQOPL1paWUyNmw3dixs80H/w+XB/QID4TYg8UtuklVaVnnoldzXxHP6mbuPh+IILXmzHhiOhti+hG7zcWhalXxN7TRuvtoj2/n2xlB1dqIU/A9VZ8yGAEgr8EeY4RRWLr3zD9DVs5UUuOcmsqBcI6zTpHH48Tbr8eb2sN2IxzMEUMv1ZNTxurHWlDlETgQ3wkjMcrOwBM/CsJEtZpLqS0wZgRQOzabD3wUYP+nQtTK4W2tAPHhBaPXy+kyomJvz3qQei1f1X/AyvkK4Uu9mBbrBbL2D1PQQ2Rhu7WYQGmF4uI9tp9SZUNXVbpF/eEhaLIEmBPKsgQvbQ9/Iae7b9kzVn2h/Y7oJOm6c/qSduX3DyD/JHR+CXkD22HbQXQBFMBZEFPIEptHhk+gpmvmzj32AyYzfozHvHFoyc6Fw8tDbqmkjOKjAeJuJ4iZyFKPx8woXnjDn83BZSi0OOmd7NiPr8rVcZb3DmEbn2HfxOtcByPBoGwad8cdTItLsgq5hEOiM+dkiARAHmTo04= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5993.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(66556008)(122000001)(966005)(38100700002)(38070700005)(55016003)(71200400001)(316002)(110136005)(64756008)(8676002)(4326008)(66446008)(478600001)(66946007)(54906003)(66476007)(76116006)(83380400001)(166002)(41300700001)(8936002)(86362001)(52536014)(186003)(33656002)(5660300002)(6506007)(53546011)(7696005)(26005)(9686003)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?MGdvVWFiaXFXV1NYTVJOYTVuZisrc3RsZmttdldEc3J0NXFEM09yZXkx?= =?iso-2022-jp?B?ODllVjVOYWdYanhLS3U4ZHBrRmwyeWxIdElodzY2d1BxYlJjd2ZFRktQ?= =?iso-2022-jp?B?ek82MjVNRUtBRVMxWk40aTVxdWtGaVBOSEUzSGhVeUxDT0hrcWdmL1ZY?= =?iso-2022-jp?B?ZmpnWlFJYTR0RlZIcVBEOUZUUDJUWW9TM2JmTHRxQ09RSUMwVkZkYWJ2?= =?iso-2022-jp?B?L1J1M1Q1d2szQ3VXQ1JBQVMyYWg5bTRQbEFuY3ZLQkZvRUZZcTJxZ2dZ?= =?iso-2022-jp?B?akUrVUpxVHNVSUtiYSs4ZWZsSzB4VXBVTzBoZUxuUlR5Vm1RNUdxVW5Q?= =?iso-2022-jp?B?NlRyMGRDZTNMZXRrRmRyNTBuOWM4TmZQZmx0TFh5YTZ2aGFzMFI1L3lk?= =?iso-2022-jp?B?LzQxTE9RdmwrblplOUdNa0pTYkhyaTZiUURCUk5GeE9EdlVxelhMeFlp?= =?iso-2022-jp?B?L3hUTjZFYzROODUyNHZnK211YkJiWElzWHNjS2RSRXRyQVRJVU12YzJT?= =?iso-2022-jp?B?WWk0RVZnOEIvZTl3U1FMQklFdHN5d2hoRTdvZkROYTRIczgzK1FtQmhB?= =?iso-2022-jp?B?N3ArUmlZZ1BJMnIwUEtibUo0UlJCMURqSXlFRkhPaTBoYkdvejNjRzJk?= =?iso-2022-jp?B?dzE2VWY2TGQwRDZLK1BnQUxxTnZINC83VmxoS25EYTJoSU5ldFE2ZDNk?= =?iso-2022-jp?B?WFZNcHdiVThyL3JOMGhLVFFSdW1zSUNuMXNaaUczZGFZby9acHpzWkg2?= =?iso-2022-jp?B?MkRjbkpUNXJlS3JFRzJiaktzeE1LV3NHTEZGVmpFNGZ2NVlFUVNNV1Vs?= =?iso-2022-jp?B?SUdnNWtwLzh2aTZYdnMwS1p5QUFJYmZkMmVzelNGblJENjVRVE5BMTd0?= =?iso-2022-jp?B?Ri8zTE5TWnBzNUc5emJxaGluTmNHUXluNUg2VnRyRjZsdEtLZUFxbnk2?= =?iso-2022-jp?B?ZFZVMzJrWkhYZzdmQmdEbUFSU1FxRkU3ajhoNTg3bTM4MHZPWEFldzZF?= =?iso-2022-jp?B?aS9YYUJtWXNkaWoyaHIySWNkMUNuVUFCR2grQm9mMk5zTVlkc0h4M1d2?= =?iso-2022-jp?B?cFo4WXlkQ3BXbWFsMmdiUjFKOXFlcStEMzM2bVN1T1ZKMTYxL1RUUW5n?= =?iso-2022-jp?B?UXZRVzdZVEp5VTk1THNYbm5xd1VKd1J6Vi9hU1pFOEc5M00wM2V1OVBl?= =?iso-2022-jp?B?VVZRUXcxSHhtSW9UTTc3Ym9WeGpDRk5KSWY0SG45UHA3MUtIdy80eUFq?= =?iso-2022-jp?B?WUlPRzR1ZFMwL24wekdGMHhuL3NXTUZialJkdlZhR1dmRXp3Q3Jub2Rk?= =?iso-2022-jp?B?aHhkWHpONldtRGxlUlJnRjR0VTc2WnRVQlFDcWppbEJ3d1ROVm5mSWpU?= =?iso-2022-jp?B?K3R5Q0o0RnFRRmRNdU1mc2c2Q3JHMW04bVlPNnpMV0UzU04wWnJGWTBC?= =?iso-2022-jp?B?S0JtT25SVkhkMVJzWnhaeDVQc3NsTlBZbjk1U0tvRUdHSkRLVGYvekZz?= =?iso-2022-jp?B?WnJBZ0kzV3g4c2RoTHphbzc5MHdMMmczZlZQWmpIOWQyUG1KY1hUZzQy?= =?iso-2022-jp?B?ZTZZMDlsL3JNeXJjNzIvY1NRZmc3d3BzMmtuTU1IVWd3akh2dTNWY1Mx?= =?iso-2022-jp?B?QU1YVFd6RjdHWGRJY3E2VDRZcXh1TEtqQVNPbUFKcmtpUTRzcjE2VGU5?= =?iso-2022-jp?B?WHhwTC9hZ0tDSlN2Yi92OHZWZlNnSTVHbFA5V2E0cGk5Q2xwejFZUm5i?= =?iso-2022-jp?B?WU1NTGxpb1AzbStSWlhmbDBpQjh5UjJ4VDZ4RXBWeHNKVnkxQjM0R1dw?= =?iso-2022-jp?B?QWdSWHlSN09QY20raGFaU1hHcWNGNXVFbVA2dEJsM2NWZmRtQ0s1MENw?= =?iso-2022-jp?B?bGhhSndLQ3MyRHRlTGZmSnBUUFE3cjMwbDBaRDlSMzdTajV1YXJPTUx1?= =?iso-2022-jp?B?a0ZZVTJ6ck91SEhTc3UrcWx2YnJqRC9sQ0FUT0o5eHUwSUZ6anBYbEth?= =?iso-2022-jp?B?WTEvVzVGZWllNEZTTVArSEZwbTE0T1gvYVZVbXlxTU9uYkNnN1N0UVJa?= =?iso-2022-jp?B?a2gvdXVabE1KZm9KQWVJd0ZLOUdnbkE1OWVNejlWN01yd0pnVHRiVmJ0?= =?iso-2022-jp?B?RUppUDQ0QlRsbkMrdDRaUVhDODRyU1V5M1QzQ2xCNEpuK3VNeEswaFdu?= =?iso-2022-jp?B?Q0hkZ2xQSkZEeTI5MzhLZWVpbnF1SXdFai9sTU11YWVuaFV5NzZqb3hp?= =?iso-2022-jp?B?MC8rSTlVYzZEMkkrSUs3Z01BQnc0Y2RQTHZWN0RJWTl6U3V2UGVVSTV6?= =?iso-2022-jp?B?ZlhVRQ==?= Content-Type: multipart/alternative; boundary="_000_BL1PR12MB5993C52DD9A881FACE6FA28D9B419BL1PR12MB5993namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5993.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61751dce-687e-483a-9f93-08da906cd9a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 01:04:00.7928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OqHcRt+3gpquEjOvu2LsYl2bHWcBrwhzkuzrfELO//YqIIb7KHkO+BRNdeGW6QBapzP5J0iOfMBgohFFa3X6Yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5616 --_000_BL1PR12MB5993C52DD9A881FACE6FA28D9B419BL1PR12MB5993namp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] FYI From: Ji, Ruili Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B6=1B$BF|=1B(B 15:40 To: qemu-devel@nongnu.org Cc: Liu, Aaron Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device >From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Sep 17 00:00:00 2001 From: Ruili Ji ruili.ji@amd.com Date: Tue, 6 Sep 2022 14:09:41 +0800 Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Make guest os access pci device control 2 reg for passthrough device as struct XenPTRegInfo described in the file hw/xen/xen_pt.h. /* reg read only field mask (ON:RO/ROS, OFF:other) */ uint32_t ro_mask; /* reg emulate field mask (ON:emu, OFF:passthrough) */ uint32_t emu_mask; Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196 Signed-off-by: Aaron.Liu@amd.com Signed-off-by: ruili.ji@amd.com --- hw/xen/xen_pt_config_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index c5c4e943a8..adc565a00a 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D { .offset =3D 0x28, .size =3D 2, .init_val =3D 0x0000, - .ro_mask =3D 0xFFE0, - .emu_mask =3D 0xFFFF, + .ro_mask =3D 0xFFA0, + .emu_mask =3D 0xFFBF, .init =3D xen_pt_devctrl2_reg_init, .u.w.read =3D xen_pt_word_reg_read, .u.w.write =3D xen_pt_word_reg_write, -- 2.34.1 --_000_BL1PR12MB5993C52DD9A881FACE6FA28D9B419BL1PR12MB5993namp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


FYI

 

From: Ji, Ruili
Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B6=1B$BF|=1B(B 15:40
To: qemu-devel@nongnu.org
Cc: Liu, Aaron <Aaron.Liu@amd.com>
Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough= device

 

From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Se= p 17 00:00:00 2001

From: Ruili Ji r= uili.ji@amd.com

Date: Tue, 6 Sep 2022 14:09:41 +0800

Subject: [PATCH] hw/xen: set pci Atomic Ops requests= for passthrough device

 

Make guest os access pci device control 2 reg for pa= ssthrough device

as struct XenPTRegInfo described in the file hw/xen/= xen_pt.h.

/* reg read only field mask (ON:RO/ROS, OFF:other) *= /

uint32_t ro_mask;

/* reg emulate field mask (ON:emu, OFF:passthrough) = */

uint32_t emu_mask;

 

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196

Signed-off-by: = Aaron.Liu@amd.com

Signed-off-by: r= uili.ji@amd.com

---

hw/xen/xen_pt_config_init.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)=

 

diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xe= n_pt_config_init.c

index c5c4e943a8..adc565a00a 100644

--- a/hw/xen/xen_pt_config_init.c

+++ b/hw/xen/xen_pt_config_init.c

@@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_r= eg_pcie[] =3D {

         .of= fset     =3D 0x28,

         .si= ze       =3D 2,

         .in= it_val   =3D 0x0000,

-        .ro_mask=     =3D 0xFFE0,

-        .emu_mas= k   =3D 0xFFFF,

+        .ro_mask=     =3D 0xFFA0,

+        .emu_mas= k   =3D 0xFFBF,

         .in= it       =3D xen_pt_devctrl2_reg_init,

         .u.= w.read   =3D xen_pt_word_reg_read,

         .u.= w.write  =3D xen_pt_word_reg_write,

--

2.34.1

 

--_000_BL1PR12MB5993C52DD9A881FACE6FA28D9B419BL1PR12MB5993namp_-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 05:26:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 05:26:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400774.642407 (Exim 4.92) (envelope-from ) id 1oVnaB-0006iA-L5; Wed, 07 Sep 2022 05:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400774.642407; Wed, 07 Sep 2022 05:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVnaB-0006i3-Hl; Wed, 07 Sep 2022 05:26:39 +0000 Received: by outflank-mailman (input) for mailman id 400774; Wed, 07 Sep 2022 05:26:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVnaA-0006ht-2E; Wed, 07 Sep 2022 05:26:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVna9-00058X-UL; Wed, 07 Sep 2022 05:26:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVna9-0002sw-7g; Wed, 07 Sep 2022 05:26:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVna9-0001Lh-7A; Wed, 07 Sep 2022 05:26:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CfzwLMFyB0ePJ3vcC4kYHxuuT+mpkeQrJEFt4ebGz/c=; b=0xzsx4pKvrvb8rjMn4WzXRjSMn Fs/AWF8uXj38DEOzY7duBv7T5C56RZY2kBET3hCEYNXzUxrZDjK+Sa0U+UJXYsLAgLdNPPygvGUng kQPEnz+XcsbaiTRAf5BHj3unGRVRrQrboRoMyIdb3xoTUopykChvdkYQlu4D7sSRWfFg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173025: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug linux-5.4:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Wed, 07 Sep 2022 05:26:37 +0000 flight 173025 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173025/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 173016 pass in 173025 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173008 test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 173016 test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail pass in 173016 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173008 like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail in 173008 like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail in 173008 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173008 like 172128 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173008 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173008 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173008 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173008 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173016 like 172108 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail in 173016 like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail in 173016 like 172128 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173016 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173016 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 34 days Failing since 172384 2022-08-11 11:13:58 Z 26 days 57 attempts Testing same since 173008 2022-09-05 15:47:43 Z 1 days 3 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 06:28:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 06:28:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400825.642436 (Exim 4.92) (envelope-from ) id 1oVoXk-0006DE-QT; Wed, 07 Sep 2022 06:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400825.642436; Wed, 07 Sep 2022 06:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVoXk-0006D7-MY; Wed, 07 Sep 2022 06:28:12 +0000 Received: by outflank-mailman (input) for mailman id 400825; Wed, 07 Sep 2022 06:28:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVoXi-0006Cv-RI; Wed, 07 Sep 2022 06:28:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVoXi-0006GI-PW; Wed, 07 Sep 2022 06:28:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVoXi-0005pV-B0; Wed, 07 Sep 2022 06:28:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVoXi-0001fr-7r; Wed, 07 Sep 2022 06:28:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Yy9trQiYcdcAp7gacmHfpnwrFhsWfjaDGT6LyDlSpKA=; b=MpxAWGKM0xhaIyy3KOoxsMgQGY S8GUD46cqXtunkMWY3yl12yE4g1+ApVv3qGY82+EywUN5YVD/elpfPMu/p+xv8X1XfUauGIT2djpe cDb32vgh1rwZZW9SV3R2H8L8x+34ZM7/HseFl6aleqXZ92jWe/65YPTFFad8vpPVLgMk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173036: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=3d35a6c243ffe749a2ae71d5d72ce0361f168f49 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 06:28:10 +0000 flight 173036 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173036/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 3d35a6c243ffe749a2ae71d5d72ce0361f168f49 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 33 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 258 attempts Testing same since 173036 2022-09-07 04:41:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2102 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 06:28:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 06:28:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400829.642447 (Exim 4.92) (envelope-from ) id 1oVoYB-0006ag-3u; Wed, 07 Sep 2022 06:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400829.642447; Wed, 07 Sep 2022 06:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVoYB-0006aZ-0S; Wed, 07 Sep 2022 06:28:39 +0000 Received: by outflank-mailman (input) for mailman id 400829; Wed, 07 Sep 2022 06:28:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVoY8-0006YZ-Tr for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 06:28:37 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bacfaab-2e76-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 08:28:33 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A5FA1339B5; Wed, 7 Sep 2022 06:28:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 635CC13486; Wed, 7 Sep 2022 06:28:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hVqvFhA6GGMFYQAAMHmgww (envelope-from ); Wed, 07 Sep 2022 06:28:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bacfaab-2e76-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662532112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NFmzdvI0rmEVoUPb615cx9V7MsAfiq2XH5klswZgPJU=; b=RqhZmZfvUT5MuzgHcnS+S6A/Ue1YMfXslFlY2ZtCVnlIXGZKvbcpQAYYCM+DWRont6RK5a 3bOimikpQWXf+kIBBB82XunRzUlSD9qdDH79qmfaTkDH4Bed69cdX4N3AS0y3+VXb+/U7Q lbm0dLMEDulQDbeh0oLeg9P7wskHRHM= Message-ID: <48bdfa39-ce5a-6d48-0bb4-8a0270e181c9@suse.com> Date: Wed, 7 Sep 2022 08:28:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-5-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ozyJJnXoOmGSgl5If4mEdoZb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ozyJJnXoOmGSgl5If4mEdoZb Content-Type: multipart/mixed; boundary="------------v0tPRYMUtdoJnlI6Rk4CjXOp"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: <48bdfa39-ce5a-6d48-0bb4-8a0270e181c9@suse.com> Subject: Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-5-jgross@suse.com> In-Reply-To: --------------v0tPRYMUtdoJnlI6Rk4CjXOp Content-Type: multipart/mixed; boundary="------------BCxFElhBzVx27uT6fnJXUWMz" --------------BCxFElhBzVx27uT6fnJXUWMz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDkuMjIgMTk6MjcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA1LzA5LzIwMjIgMTM6NDcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBF eHRlbmQgdGhlIGRlZmluaXRpb24gb2YgdGhlIFhlbnN0b3JlIG1pZ3JhdGlvbiBzdHJlYW0g dG8gY292ZXIgbmV3DQo+PiBmZWF0dXJlczoNCj4+DQo+PiAtIHBlciBkb21haW4gZmVhdHVy ZXMNCj4+IC0gZXh0ZW5kZWQgd2F0Y2hlcyAod2F0Y2ggZGVwdGgpDQo+PiAtIHBlciBkb21h aW4gcXVvdGENCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+DQo+PiAtLS0NCj4+IFYzOg0KPj4gLSBuZXcgcGF0Y2gNCj4+IFY0Og0KPj4g LSBhZGQgbmV3IHJlY29yZCB0eXBlcyBpbnN0ZWFkIG9mIG1vZGlmeWluZyB0aGUgZXhpc3Rp bmcgb25lcw0KPj4gwqDCoCAoSnVsaWVuIEdyYWxsKQ0KPj4gLS0tDQo+PiDCoCBkb2NzL2Rl c2lnbnMveGVuc3RvcmUtbWlncmF0aW9uLm1kIHwgMTYwICsrKysrKysrKysrKysrKysrKysr KysrKysrKystDQo+PiDCoCAxIGZpbGUgY2hhbmdlZCwgMTU1IGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RvY3MvZGVzaWducy94ZW5zdG9y ZS1taWdyYXRpb24ubWQgDQo+PiBiL2RvY3MvZGVzaWducy94ZW5zdG9yZS1taWdyYXRpb24u bWQNCj4+IGluZGV4IGVmYTUyNmY0MjAuLmM3MDUwNWM0M2EgMTAwNjQ0DQo+PiAtLS0gYS9k b2NzL2Rlc2lnbnMveGVuc3RvcmUtbWlncmF0aW9uLm1kDQo+PiArKysgYi9kb2NzL2Rlc2ln bnMveGVuc3RvcmUtbWlncmF0aW9uLm1kDQo+PiBAQCAtNDMsNyArNDMsMTQgQEAgdGhlIHNl dHRpbmcgb2YgdGhlIGVuZGlhbm5lc3MgYml0Lg0KPj4gwqAgfC0tLS0tLS0tLS0tfC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLXwNCj4+IMKg IHwgYGlkZW50YMKgwqAgfCAweDc4NjU2ZTczNzQ2ZjcyNjUgKCd4ZW5zdG9yZScgaW4gQVND SUkpwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+IMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+PiAt fCBgdmVyc2lvbmAgfCAweDAwMDAwMDAxICh0aGUgdmVyc2lvbiBvZiB0aGUgc3BlY2lmaWNh dGlvbinCoMKgwqDCoCB8DQo+PiArfCBgdmVyc2lvbmAgfCBUaGUgdmVyc2lvbiBvZiB0aGUg c3BlY2lmaWNhdGlvbiwgZGVmaW5lZCB2YWx1ZXM6IHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDC oMKgwqAgfCAweDAwMDAwMDAxOiBhbGwgZmllbGRzIGFuZCByZWNvcmRzIHdpdGhvdXQgYW55 wqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBleHBsaWNpdGx5IG1lbnRpb25lZCB2ZXJzaW9uwqDCoMKgwqDCoMKgwqDCoMKg IHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBkZXBlbmRlbmN5IGFyZSB2YWxpZC7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB8DQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgMHgwMDAwMDAwMjogYWxsIGZpZWxk cyBhbmQgcmVjb3JkcyB2YWxpZCBmb3LCoMKgwqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDCoMKg wqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2ZXJzaW9uIDEgcGx1cyBmaWVs ZHMgYW5kIHJlY29yZHPCoMKgwqDCoCB8DQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZXhwbGljaXRseSBzdGF0ZWQgdG8gYmUgc3VwcG9y dGVkIGluwqAgfA0KPj4gK3zCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHZlcnNpb24gMiBhcmUgdmFsaWQuwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB8DQo+IA0KPiBJIHRoaW5rIGl0IHdvdWxkIGJlIHVzZWZ1bCB0byBvdXRs aW5lIGluIHRoZSBjb21taXQgbWVzc2FnZSB3aHkgdGhlIHZlcnNpb24gaGFkIA0KPiB0byBi ZSBidW1wZWQuDQoNCk9rYXkuDQoNCj4gDQo+PiDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqAg fMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4g wqAgfCBgZmxhZ3NgwqDCoCB8IDAgKExTQik6IEVuZGlhbm5lc3M6IDAgPSBsaXR0bGUsIDEg PSBiaWfCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4gwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKg IHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+ IEBAIC03Nyw3ICs4NCwxMCBAQCBOT1RFOiBwYWRkaW5nIG9jdGV0cyBoZXJlIGFuZCBpbiBh bGwgc3Vic2VxdWVudCBmb3JtYXQgDQo+PiBzcGVjaWZpY2F0aW9ucyBtdXN0IGJlDQo+PiDC oCB8wqDCoMKgwqDCoMKgwqAgfCAweDAwMDAwMDAzOiBXQVRDSF9EQVRBwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+ IMKgIHzCoMKgwqDCoMKgwqDCoCB8IDB4MDAwMDAwMDQ6IFRSQU5TQUNUSU9OX0RBVEHCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4gwqAg fMKgwqDCoMKgwqDCoMKgIHwgMHgwMDAwMDAwNTogTk9ERV9EQVRBwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4g LXzCoMKgwqDCoMKgwqDCoCB8IDB4MDAwMDAwMDYgLSAweEZGRkZGRkZGOiByZXNlcnZlZCBm b3IgZnV0dXJlIHVzZcKgwqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDCoMKgwqAgfCAweDAwMDAw MDA2OiBHTE9CQUxfUVVPVEFfREFUQcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgfA0KPj4gK3zCoMKgwqDCoMKgwqDCoCB8IDB4MDAwMDAwMDc6IERP TUFJTl9EQVRBwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB8DQo+PiArfMKgwqDCoMKgwqDCoMKgIHwgMHgwMDAwMDAwODogV0FU Q0hfREFUQV9FWFRFTkRFRCAodmVyc2lvbiAyIGFuZCB1cCnCoMKgIHwNCj4+ICt8wqDCoMKg wqDCoMKgwqAgfCAweDAwMDAwMDA5IC0gMHhGRkZGRkZGRjogcmVzZXJ2ZWQgZm9yIGZ1dHVy ZSB1c2XCoMKgwqDCoCB8DQo+PiDCoCB8wqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4gwqAgfCBgbGVu YMKgIHwgVGhlIGxlbmd0aCAoaW4gb2N0ZXRzKSBvZiBgYm9keWDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+IMKgIHzCoMKgwqDCoMKgwqDCoCB8wqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+ PiBAQCAtMTI5LDYgKzEzOSw3IEBAIHhlbnN0b3JlZCBzdGF0ZSB0aGF0IG5lZWRzIHRvIGJl IHJlc3RvcmVkLg0KPj4gwqAgfCBgZXZ0Y2huLWZkYMKgwqDCoCB8IFRoZSBmaWxlIGRlc2Ny aXB0b3IgdXNlZCB0byBjb21tdW5pY2F0ZSB3aXRoIHwNCj4+IMKgIHzCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgfCB0aGUgZXZlbnQgY2hhbm5lbCBkcml2ZXLCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+ICsNCj4gDQo+IFNwdXJpb3Vz IGNoYW5nZT8NCg0KWWVzLg0KDQo+IA0KPj4gwqAgeGVuc3RvcmVkIHdpbGwgcmVzdW1lIGlu IHRoZSBvcmlnaW5hbCBwcm9jZXNzIGNvbnRleHQuIEhlbmNlIGBydy1zb2NrZXQtZmRgDQo+ PiDCoCBzaW1wbHkgc3BlY2lmaWVzIHRoZSBmaWxlIGRlc2NyaXB0b3Igb2YgdGhlIHNvY2tl dC4gU29ja2V0cyBhcmUgbm90IGFsd2F5cw0KPj4gwqAgdXNlZCwgaG93ZXZlciwgYW5kIHNv IC0xIHdpbGwgYmUgdXNlZCB0byBkZW5vdGUgYW4gdW51c2VkIHNvY2tldC4NCj4+IEBAIC0y NDEsOSArMjUyLDkgQEAgdGhlIGZpbGUgZGVzY3JpcHRvciBvZiB0aGUgc29ja2V0IGNvbm5l Y3Rpb24uDQo+PiDCoCAjIyMgV0FUQ0hfREFUQQ0KPj4gLVRoZSBpbWFnZSBmb3JtYXQgd2ls bCBjb250YWluIGEgYFdBVENIX0RBVEFgIHJlY29yZCBmb3IgZWFjaCB3YXRjaCByZWdpc3Rl cmVkDQo+PiAtYnkgYSBjb25uZWN0aW9uIGZvciB3aGljaCB0aGVyZSBpcyBgQ09OTkVDVElP Tl9EQVRBYCByZWNvcmQgcHJldmlvdXNseSBwcmVzZW50Lg0KPj4gLQ0KPj4gK1RoZSBpbWFn ZSBmb3JtYXQgd2lsbCBjb250YWluIGVpdGhlciBhIGBXQVRDSF9EQVRBYCBvciBhIGBXQVRD SF9EQVRBX0VYVEVOREVEYA0KPj4gK3JlY29yZCBmb3IgZWFjaCB3YXRjaCByZWdpc3RlcmVk IGJ5IGEgY29ubmVjdGlvbiBmb3Igd2hpY2ggdGhlcmUgaXMNCj4+ICtgQ09OTkVDVElPTl9E QVRBYCByZWNvcmQgcHJldmlvdXNseSBwcmVzZW50Lg0KPj4gwqAgYGBgDQo+PiDCoMKgwqDC oMKgIDDCoMKgwqDCoMKgwqAgMcKgwqDCoMKgwqDCoCAywqDCoMKgwqDCoMKgIDPCoMKgwqAg b2N0ZXQNCj4+IEBAIC00MDYsNiArNDE3LDE0NSBAQCBBIG5vZGUgcGVybWlzc2lvbiBzcGVj aWZpZXIgaGFzIHRoZSBmb2xsb3dpbmcgZm9ybWF0Og0KPj4gwqAgTm90ZSB0aGF0IHBlcm0x IGRlZmluZXMgdGhlIGRvbWFpbiBvd25pbmcgdGhlIG5vZGUuIFNlZSBbNF0gZm9yIG1vcmUN Cj4+IMKgIGV4cGxhbmF0aW9uIG9mIG5vZGUgcGVybWlzc2lvbnMuDQo+PiArXHBhZ2VicmVh aw0KPj4gKw0KPj4gKyMjIyBHTE9CQUxfUVVPVEFfREFUQQ0KPj4gKw0KPj4gK1RoaXMgcmVj b3JkIGlzIG9ubHkgcmVsZXZhbnQgZm9yIGxpdmUgdXBkYXRlLiBJdCBjb250YWlucyB0aGUg Z2xvYmFsIHNldHRpbmdzDQo+PiArb2YgeGVuc3RvcmVkIHF1b3RhLg0KPj4gKw0KPj4gK2Bg YA0KPj4gK8KgwqDCoCAwwqDCoMKgwqDCoMKgIDHCoMKgwqDCoMKgwqAgMsKgwqDCoMKgwqDC oCAzwqDCoMKgIG9jdGV0DQo+PiArKy0tLS0tLS0rLS0tLS0tLSstLS0tLS0tKy0tLS0tLS0r DQo+PiArfCBuLWRvbS1xdW90YcKgwqAgfCBuLWdsb2ItcXVvdGHCoCB8DQo+PiArKy0tLS0t LS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0rDQo+PiArfCBxdW90YS12YWwgMcKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+PiArKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0rDQo+PiArLi4uDQo+PiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0rDQo+PiArfCBxdW90YS12YWwgTsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB8DQo+PiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQo+ PiArfCBxdW90YS1uYW1lcw0KPj4gKy4uLg0KPj4gK2BgYA0KPj4gKw0KPj4gKw0KPj4gK3wg RmllbGTCoMKgwqDCoMKgwqDCoMKgwqAgfCBEZXNjcmlwdGlvbsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+ PiArfC0tLS0tLS0tLS0tLS0tLS18LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLXwNCj4+ICt8IGBuLWRvbS1xdW90YWDCoCB8IE51bWJlciBvZiBxdW90 YSB2YWx1ZXMgd2hpY2ggYXBwbHkgcGVywqDCoMKgwqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgZG9tYWluLsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwN Cj4gDQo+IEkgd291bGQgYWRkICJieSBkZWZhdWx0IiBvciBzb21ldGhpbmcgc2ltaWxhciB0 byBtYWtlIGNsZWFyIHRoYXQgdGhlIHZhbHVlIGluIA0KPiBET01BSU5fREFUQSB3aWxsIG92 ZXJyaWRlIGFueSBxdW90YSBzZXQgaGVyZS4gQnV0IHNlZSBiZWxvdyBhYm91dCAnbi1kb20t cXVvdGEnIA0KPiBhbmQgJ24tZ2xvYi1xdW90YScuDQoNCk9rYXkuDQoNCj4gDQo+PiArfMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHwNCj4+ICt8IGBuLWdsb2ItcXVvdGFgIHwgTnVtYmVyIG9mIHF1b3Rh IHZhbHVlcyB3aGljaCBhcHBseSBnbG9iYWxsecKgIHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHwgb25seS7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4g K3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB8DQo+PiArfCBgcXVvdGEtdmFsYMKgwqDCoCB8IFF1b3RhIHZh bHVlcywgZmlyc3QgdGhlIG9uZXMgYXBwbHlpbmcgcGVywqDCoMKgIHwNCj4+ICt8wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgZG9tYWluLCB0aGVuIHRoZSBvbmVzIGFwcGx5 aW5nIGdsb2JhbGx5LiBBwqDCoCB8DQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCB8IHZhbHVlIG9mIDAgaGFzIHRoZSBzZW1hbnRpY3Mgb2YgInVubGltaXRlZCIuIHwN Cj4gDQo+IEl0IGlzIHVuY2xlYXIgdG8gbWUgd2h5IHlvdSBuZWVkIHRvIG1ha2UgdGhlIGRp c3RpbmN0aW9uIGJldHdlZW4gInBlciBkb21haW4iIA0KPiBhbmQgImdsb2JhbGx5Ii4gSU9X IHNob3VsZG4ndCBiZSB0aGUgbmFtZSBvZiB0aGUgcXVvdGEgYWxyZWFkeSBpbmRpY2F0ZXMg dGhhdD8NCg0KSSB0aGluayBpdCBjb3VsZCBoZWxwIGluIHNwZWNpYWwgY2FzZXMuDQoNCklt YWdpbmUgWGVuc3RvcmUgQSBrbm93cyBhYm91dCBnbG9iYWwgcXVvdGEgZyBhbmQgZG9tYWlu IHF1b3RhIGQsIHdoaWxlDQpYZW5zdG9yZSBCIGRvZXNuJ3Qga25vdyBib3RoLiBJbml0aWFs bHkgSSdtIHJ1bm5pbmcgWGVuc3RvcmUgQSBvbiBhDQpob3N0LCB0aGVuIEknbSBsaXZlLXVw ZGF0aW5nIHRvIEIuDQoNCkIgZ2V0cyB0aGUgaW5mb3JtYXRpb24gdGhhdCBnIGlzIGdsb2Jh bCwgYW5kIGQgaXMgcGVyLWRvbWFpbiwgYnV0IGhhcyBubw0Kb3RoZXIgaWRlYSB3aGF0IHRv IGRvIHdpdGggdGhlIHZhbHVlcyBvZiBnIGFuZCBkLiBPVE9IIGl0IGtub3dzIHRoYXQgZWFj aA0KbmV3IGRvbWFpbiBzaG91bGQgZ2V0IGQgd2l0aCB0aGUgcmVsYXRlZCB2YWx1ZSwgc28g aXQgY2FuIHNldCBkIGZvciBlYWNoDQpuZXdseSBjcmVhdGVkIGRvbWFpbi4NCg0KV2hlbiBC IGlzIGVpdGhlciBkb3duZ3JhZGVkIHRvIEEgYWdhaW4sIG9yIGEgZG9tYWluIGlzIG1pZ3Jh dGVkIHRvIGFub3RoZXINCmhvc3QgcnVubmluZyBBLCBCIGNhbiBhZGQgdGhlIHF1b3RhIGlu Zm9ybWF0aW9uIG9mIGQgZm9yIGFsbCBkb21haW5zLg0KDQpXaGlsZSB0aGlzIGlzIG5vdGhp bmcgSSdtIHBsYW5uaW5nIHRvIGRvIGluIHRoZSBuZWFyIGZ1dHVyZSwgaXQgbWlnaHQgaGVs cA0KZS5nLiBpbiBjYXNlcyB3aXRoIG1peGVkIEMteGVuc3RvcmVkIGFuZCBPLXhlbnN0b3Jl ZCBzZXR1cHMuDQoNCkl0IGRvZXNuJ3QgY29zdCByZWFsbHkgbXVjaCwgc28gSSB3YW50ZWQg dG8gc3VwcG9ydCB0aGlzIHBvc3NpYmlsaXR5IGluIHRoZQ0KbWlncmF0aW9uIHN0cmVhbSBm cm9tIHRoZSBiZWdpbm5pbmcuDQoNCj4gDQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+ICt8 IGBxdW90YS1uYW1lc2DCoCB8IDAgZGVsaW1pdGVkIHN0cmluZ3Mgb2YgdGhlIHF1b3RhIG5h bWVzIGluwqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwg dGhlIHNhbWUgc2VxdWVuY2UgYXMgdGhlIGBxdW90YS12YWxgIHZhbHVlcy4gfA0KPj4gKw0K Pj4gKw0KPj4gK0FsbG93ZWQgcXVvdGEgbmFtZXMgYXJlIHRob3NlIGV4cGxpY2l0bHkgbmFt ZWQgaW4gWzJdIGZvciB0aGUgYEdFVF9RVU9UQWANCj4+ICthbmQgYFNFVF9RVU9UQWAgY29t bWFuZHMsIHBsdXMgaW1wbGVtZW50YXRpb24gc3BlY2lmaWMgb25lcy4gUXVvdGEgbmFtZXMg bm90DQo+PiArcmVjb2duaXplZCBieSB0aGUgcmVjZWl2aW5nIHNpZGUgbXVzdCBiZSBpZ25v cmVkLg0KPj4gKw0KPj4gK1xwYWdlYnJlYWsNCj4+ICsNCj4+ICsjIyMgRE9NQUlOX0RBVEEN Cj4+ICsNCj4+ICtUaGlzIHJlY29yZCBpcyBvcHRpb25hbCBhbmQgY2FuIGJlIHByZXNlbnQg b25jZSBmb3IgZWFjaCBkb21haW4uDQo+PiArDQo+PiArDQo+PiArYGBgDQo+PiArwqDCoMKg IDDCoMKgwqDCoMKgwqAgMcKgwqDCoMKgwqDCoCAywqDCoMKgwqDCoMKgIDPCoMKgwqDCoCBv Y3RldA0KPj4gKystLS0tLS0tKy0tLS0tLS0rLS0tLS0tLSstLS0tLS0tKw0KPj4gK3wgZG9t YWluLWlkwqDCoMKgwqAgfCBuLXF1b3RhwqDCoMKgwqDCoMKgIHwNCj4+ICsrLS0tLS0tLS0t LS0tLS0tKy0tLS0tLS0tLS0tLS0tLSsNCj4+ICt8IGZlYXR1cmVzwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+ICsrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLSsNCj4+ICt8IHF1b3RhLXZhbCAxwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHwNCj4+ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LSsNCj4+ICsuLi4NCj4+ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4+ ICt8IHF1b3RhLXZhbCBOwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwN Cj4+ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4+ICt8IHF1b3RhLW5h bWVzDQo+PiArLi4uDQo+PiArYGBgDQo+PiArDQo+PiArDQo+PiArfCBGaWVsZMKgwqDCoMKg wqDCoMKgwqDCoCB8IERlc2NyaXB0aW9uwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+ICt8LS0tLS0tLS0t LS0tLS0tLXwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t fA0KPj4gK3wgYGRvbWFpbi1pZGDCoMKgwqAgfCBUaGUgZG9tYWluLWlkIG9mIHRoZSBkb21h aW4gdGhpcyByZWNvcmTCoMKgwqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHwgYmVsb25ncyB0by7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4gK3zCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCB8DQo+PiArfCBgbi1xdW90YWDCoMKgwqDCoMKgIHwgTnVtYmVyIG9mIHF1b3RhIHZh bHVlcy7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4g K3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB8DQo+PiArfCBgZmVhdHVyZXNgwqDCoMKgwqAgfCBWYWx1ZSBv ZiB0aGUgZmVhdHVyZSBmaWVsZCB2aXNpYmxlIGJ5IHRoZcKgwqDCoCB8DQo+PiArfMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IGd1ZXN0IGF0IG9mZnNldCAyMDY0IG9mIHRo ZSByaW5nIHBhZ2UuwqDCoMKgwqDCoMKgIHwNCj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHwgQWxpZ25lZCB0byB0aGUgbmV4dCA0IG9jdGV0IGJvdW5kYXJ5LsKgwqDC oMKgwqDCoMKgIHwNCj4gDQo+IFN0YWxlIHNlbnRlbmNlPw0KDQpPaCB5ZXMsIGEgc3Vydml2 b3Igb2YgVjMuDQoNCj4gDQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 IE9ubHkgdmFsaWQgZm9yIHZlcnNpb24gMiBhbmQgbGF0ZXIuwqDCoMKgwqDCoMKgwqDCoMKg IHwNCj4gDQo+IENhbiB5b3UgbWVudGlvbiBleHBsaWNpdGx5IHdoZXRoZXIgdGhlIGZpZWxk IHdpbGwgdW5rbm93biBvciAwIGZvciB2ZXJzaW9uIDE/DQoNCldlIGhhdmUgdGhlIGdlbmVy YWwgbm90ZSAicGFkZGluZyBvY3RldHMgaGVyZSBhbmQgaW4gYWxsIHN1YnNlcXVlbnQgZm9y bWF0DQpzcGVjaWZpY2F0aW9ucyBtdXN0IGJlIHdyaXR0ZW4gYXMgemVybyIuIEkgdGhpbmsg dGhpcyBzaG91bGQgc3VmZmljZS4NCg0KPiANCj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4g K3wgYHF1b3RhLXZhbGDCoMKgwqAgfCBRdW90YSB2YWx1ZXMsIGEgdmFsdWUgb2YgMCBoYXMg dGhlIHNlbWFudGljcyB8DQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 ICJ1bmxpbWl0ZWQiLsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4gK3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+PiAr fCBgcXVvdGEtbmFtZXNgwqAgfCAwIGRlbGltaXRlZCBzdHJpbmdzIG9mIHRoZSBxdW90YSBu YW1lcyBpbsKgwqDCoCB8DQo+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 IHRoZSBzYW1lIHNlcXVlbmNlIGFzIHRoZSBgcXVvdGEtdmFsYCB2YWx1ZXMuIHwNCj4+ICsN Cj4+ICtBbGxvd2VkIHF1b3RhIG5hbWVzIGFyZSB0aG9zZSBleHBsaWNpdGx5IG5hbWVkIGlu IFsyXSBmb3IgdGhlIGBHRVRfUVVPVEFgDQo+PiArYW5kIGBTRVRfUVVPVEFgIGNvbW1hbmRz LCBwbHVzIGltcGxlbWVudGF0aW9uIHNwZWNpZmljIG9uZXMuIFF1b3RhIG5hbWVzIG5vdA0K Pj4gK3JlY29nbml6ZWQgYnkgdGhlIHJlY2VpdmluZyBzaWRlIG11c3QgYmUgaWdub3JlZC4N Cj4+ICsNCj4+ICtccGFnZWJyZWFrDQo+PiArDQo+PiArIyMjIFdBVENIX0RBVEFfRVhURU5E RUQNCj4gDQo+IE5JVDogSSB0aGluayBpdCB3b3VsZCBiZSBtb3JlIGxvZ2ljYWwgaWYgdGhp cyBpcyBkZWZpbmVkIHJpZ2h0IG5leHQgYWZ0ZXIgDQo+IFdBVENIX0RBVEEuDQoNCkkgd2Fz IGZvbGxvd2luZyB0aGUgcmVjb3JkIHR5cGUgbnVtYmVyaW5nLCBidXQgSSBjYW4gbW92ZSB0 aGlzIHJlY29yZA0KZGVzY3JpcHRpb24gdXAgaWYgeW91IGxpa2UgdGhhdCBiZXR0ZXIuDQoN Cj4gDQo+PiArDQo+PiArVGhlIGltYWdlIGZvcm1hdCB3aWxsIGNvbnRhaW4gZWl0aGVyIGEg YFdBVENIX0RBVEFgIG9yIGEgYFdBVENIX0RBVEFfRVhURU5ERURgDQo+PiArcmVjb3JkIGZv ciBlYWNoIHdhdGNoIHJlZ2lzdGVyZWQgYnkgYSBjb25uZWN0aW9uIGZvciB3aGljaCB0aGVy ZSBpcw0KPj4gK2BDT05ORUNUSU9OX0RBVEFgIHJlY29yZCBwcmV2aW91c2x5IHByZXNlbnQu IFRoZSBgV0FUQ0hfREFUQV9FWFRFTkRFRGAgcmVjb3JkDQo+PiArdHlwZSBpcyB2YWxpZCBv bmx5IGluIHZlcnNpb24gMiBhbmQgbGF0ZXIuDQo+PiArDQo+PiArYGBgDQo+PiArwqDCoMKg IDDCoMKgwqDCoMKgwqAgMcKgwqDCoMKgwqDCoCAywqDCoMKgwqDCoMKgIDPCoMKgwqAgb2N0 ZXQNCj4+ICsrLS0tLS0tLSstLS0tLS0tKy0tLS0tLS0rLS0tLS0tLSsNCj4+ICt8IGNvbm4t aWTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+PiAr Ky0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0rDQo+PiArfCB3cGF0aC1sZW7CoMKg wqDCoCB8IHRva2VuLWxlbsKgwqDCoMKgIHwNCj4+ICsrLS0tLS0tLS0tLS0tLS0tKy0tLS0t LS0tLS0tLS0tLSsNCj4+ICt8IGRlcHRowqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB8DQo+PiArKy0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0t LS0rDQo+IA0KPiBJdCBpcyBub3QgY2xlYXIgd2hhdCB3b3VsZCBiZSB0aGUgdmFsdWUgb2Yg b2N0ZXQgMi0zLiBJcyBpdCBSRVMwIG9yIFVOS05PV04/DQoNCkkgZG9uJ3QgdW5kZXJzdGFu ZCB0aGUgcXVlc3Rpb24uIGNvbm4taWQgaXMgYSA0LWJ5dGUgaXRlbS4NCg0KDQpKdWVyZ2Vu DQo= --------------BCxFElhBzVx27uT6fnJXUWMz Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BCxFElhBzVx27uT6fnJXUWMz-- --------------v0tPRYMUtdoJnlI6Rk4CjXOp-- --------------ozyJJnXoOmGSgl5If4mEdoZb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMYOhAFAwAAAAAACgkQsN6d1ii/Ey8S 7wf9GqrnjwuzPKXzODp+zAcga5fb3vsb4Not2Q9h0sMdeotZ1kH4ejEtzPlqjYVZZySbMDOhVzYN 9RUPPzyUnWlRrpBeEmj4LfuQzKECsxVxCT/2KX9XyeetT7J1emgK5UqtZF961qnO7O1jTbkqqkHQ O4zZ+3TxTIiNKfqRBF+ELOdeE1LpQ1gYt19h2bUfVgB6nfgdB1/pqgMljsPaioQZW7J7fzBGg0Nl a4ftVojmMWbn37sReCNminQOVnrHAZ4eQs/3A4qq73NuoFQvG60gmMU98t6BJFoiNZyO8D5nzfx4 3vKU9c1X6e83rl4bUytLX0VKor1eWxNVzOMQCMIAJA== =CBrT -----END PGP SIGNATURE----- --------------ozyJJnXoOmGSgl5If4mEdoZb-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 06:50:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 06:50:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400845.642458 (Exim 4.92) (envelope-from ) id 1oVoss-00019T-0Q; Wed, 07 Sep 2022 06:50:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400845.642458; Wed, 07 Sep 2022 06:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVosr-000195-Sa; Wed, 07 Sep 2022 06:50:01 +0000 Received: by outflank-mailman (input) for mailman id 400845; Wed, 07 Sep 2022 06:50:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVosq-00018t-57 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 06:50:00 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2077.outbound.protection.outlook.com [40.107.94.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48ed5780-2e79-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 08:49:58 +0200 (CEST) Received: from MW4P223CA0006.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::11) by BL1PR12MB5240.namprd12.prod.outlook.com (2603:10b6:208:319::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 06:49:54 +0000 Received: from CO1NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::56) by MW4P223CA0006.outlook.office365.com (2603:10b6:303:80::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 06:49:53 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT010.mail.protection.outlook.com (10.13.175.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 06:49:53 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 01:49:51 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 01:49:51 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 01:49:50 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48ed5780-2e79-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=isbW2x6b/IhdO0VHf5PJNYlYzvyW5E7wYJC2FLZ+LDVdjluexUgEYFWlFtVY9NcHNBVpI9xty2maRqgO1uAwRheYBmsu1feRTx9ZTIOwU6Sv9vi9x705Edw9dDqcGm+yEL1OvH6TuqlsVDl51ijSG7Jicnqx6iH5LkRHKXIBeLBdez0L2zETr7we1hgfE6ikcXs/yyObf/r8hxu5KhfuSutrSCMhqc2lMcjlVfTEZUCP+77KYzPAv1oVH4fR++oa+wtluFtmIJC5nNUxHFbyus0rV7bw2ajb30Kr//IWfSCGmkToMfkJIuYgDC8F4WW9QRnSeKBeslQksu3ZfxQ0FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2USVaTAicxjRY+lKuGGdLuCt7Msq7kML8XSHQtYTx70=; b=mfh2EjgfCo/gXJ9+izfYulXET+SqstQA5fUMVZelRg9aO1LOnxG4v20sQ7Awp+xsKaUc+VLu5Y/lhXgdIoeuwFmnpzZXpZYHjWK72FNy2sPBYqD6KIGdgojIGHBlogDW/bIl/MCwCCcJYoEZhhhpRGJ8Ip9rBIuvxRF5nknFWK4Rc8ezCmSv1XgdU52NKafwe/1ejy8Rlcz8U9Ag53YwiDgvx7P+CSg1EG4STU7t4aEu2RHi8isRSxaWBTJX9PRkSQLkfBQ2al763u65usPcK+yE/aYW0/+uqV2rv5OhNvNxbAwAz+MjWrh1oNaPLgcY9EDNPEXBiKCSSkaY6GJ0JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2USVaTAicxjRY+lKuGGdLuCt7Msq7kML8XSHQtYTx70=; b=JnycwLbD5d8CykTBlGYVEYJR7iF4W2LdTaxSPPQQuJktBFwGP2zhogEivSAvTGIUm6geY8ixIqBTAizVlU8LxEkvhJFrm0UtZ26uD0rkZG37RKiP6mTcDpXjFvPe2s3j+FHSyh8S8o3AyvMT/A6cyy+STUA8hmjk4wyr3w9p+E0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <3fe3bd63-e215-a2e4-acf7-273f9936808b@amd.com> Date: Wed, 7 Sep 2022 08:49:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [ImageBuilder] Add support for Xen boot-time cpupools To: Stefano Stabellini CC: References: <20220906111214.26912-1-michal.orzel@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT010:EE_|BL1PR12MB5240:EE_ X-MS-Office365-Filtering-Correlation-Id: dc73a7cc-f4b9-4b18-79c3-08da909d2b6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CJw0HYd+QVm85tmgqP3ZsxPNdEkS4d3sRicvChIg5qgdL9lIonzt3N6LKxKrjM9hbuWHjyuDNAWdOrWBqb/1uyz+VCUzpK/S5Lh1Aw6Nf5W6foP/ozyMSk5P2D/Hw3nLVpiKo5yD0lQICKBQ2OO47D7bZ5Y+KWAhVNtP55qzpBluN/RG04+r6rm6uQ/F++7nsDqFWRMtggp6UESGyh3jiG04yKBnCKyy8W2EljXaDDFps8gP+mtazT/d12d7YdhC39N2xIPumwoU4W1YcCNZ0KOnGLW9c2v5vt2dr47Jhol4uCoo9Ld+djMFhyiFkzV/KcdGBX50G47JJxTc94sA8u1BKJt77Bsz3TcFTJg404wFX4jMJZxOgE9V9/X8z19VSKKuadkrlFhhII00WC4OyhAYnIt9LqJk7azg9dazhu+BA4S7HP6LfhjGjDGoVTWRCEjs4E3uk8BwMb+UZYAFFjpZ/ff8i6f6ueOa1Uq/JFhgeVlR20jg1k0tLvX/GxEtkvJls5n5mnWMERhNGj0iXXxvJ2qBZjBttRLDRa9dxIrA8KNj/f7xdeGfjXJLIpFrkisaZ3hCTWyoeIGQ/q5PqsR+UqOZJDA3W61Sqtxyy8sXmPCGi6XDWx+g5oBocYg9m+JmyoiMWrlZHzZquxI+1NI0KsVbcgXeSvZtZ/sTQEc5stlcJxS1xHPxQzfiU8fa4Nq/hYsm3fnMXsQq3Qi1wcf1dXEGf184nW/8cBP9d9+wyZ2wKsSi7ThAqzl0WVZBzYQrjKa63G9zpq3HigVj7Fbq3nd41hg8UFvgkiIe3fKdbVKYq/ufBEiMp9ZxvRJBRIlipYx4SzVkuyO4x5SWnQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(40470700004)(46966006)(36840700001)(8676002)(426003)(83380400001)(70206006)(47076005)(70586007)(8936002)(36860700001)(5660300002)(4326008)(53546011)(26005)(478600001)(186003)(336012)(2616005)(41300700001)(16576012)(31686004)(316002)(44832011)(6916009)(31696002)(86362001)(82310400005)(36756003)(40460700003)(40480700001)(356005)(81166007)(82740400003)(2906002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 06:49:53.7044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc73a7cc-f4b9-4b18-79c3-08da909d2b6b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5240 Hi Stefano, On 07/09/2022 03:43, Stefano Stabellini wrote: > > On Tue, 6 Sep 2022, Michal Orzel wrote: >> Introduce support for creating boot-time cpupools in the device tree and >> assigning them to dom0less domUs. Add the following options: >> - CPUPOOL[number]="cpu1_path,...,cpuN_path scheduler" to specify the >> list of cpus and the scheduler to be used to create cpupool >> - NUM_CPUPOOLS to specify the number of cpupools to create >> - DOMU_CPUPOOL[number]="" to specify the id of the cpupool to >> assign to domU >> >> Example usage: >> CPUPOOL[0]="/cpus/cpu@1,/cpus/cpu@2 null" >> DOMU_CPUPOOL[0]=0 >> NUM_CPUPOOLS=1 >> >> The above example will create a boot-time cpupool (id=0) with 2 cpus: >> cpu@1, cpu@2 and the null scheduler. It will assign the cpupool with >> id=0 to domU0. >> >> Signed-off-by: Michal Orzel > > Great patch in record time, thanks Michal! > > > On the CPUPOOL string format: do you think we actually need the device > tree path or could we get away with something like: > > CPUPOOL[0]="cpu@1,cpu@2 null" > > All the cpus have to be under the top-level /cpus node per the device > tree spec, so maybe the node name should be enough? > According to specs, passing only the node names should be enough so I will modify it. > > >> --- >> README.md | 10 +++++ >> scripts/uboot-script-gen | 80 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 90 insertions(+) >> >> diff --git a/README.md b/README.md >> index bd9dac924b44..44abb2193142 100644 >> --- a/README.md >> +++ b/README.md >> @@ -181,6 +181,9 @@ Where: >> present. If set to 1, the VM can use PV drivers. Older Linux kernels >> might break. >> >> +- DOMU_CPUPOOL[number] specifies the id of the cpupool (created using >> + CPUPOOL[number] option, where number == id) that will be assigned to domU. >> + >> - LINUX is optional but specifies the Linux kernel for when Xen is NOT >> used. To enable this set any LINUX\_\* variables and do NOT set the >> XEN variable. >> @@ -223,6 +226,13 @@ Where: >> include the public key in. This can only be used with >> FIT_ENC_KEY_DIR. See the -u option below for more information. >> >> +- CPUPOOL[number]="cpu1_path,...,cpuN_path scheduler" >> + specifies the list of cpus (separated by commas) and the scheduler to be >> + used to create boot-time cpupool. If no scheduler is set, the Xen default >> + one will be used. >> + >> +- NUM_CPUPOOLS specifies the number of boot-time cpupools to create. >> + >> Then you can invoke uboot-script-gen as follows: >> >> ``` >> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen >> index 18c0ce10afb4..2e1c80a92ce1 100755 >> --- a/scripts/uboot-script-gen >> +++ b/scripts/uboot-script-gen >> @@ -176,6 +176,81 @@ function add_device_tree_static_mem() >> dt_set "$path" "xen,static-mem" "hex" "${cells[*]}" >> } >> >> +function add_device_tree_cpupools() >> +{ >> + local num=$1 >> + local phandle_next="0xfffffff" > > I think phandle_next is a good idea, and I would make it a global > variable at the top of the uboot-script-gen file or at the top of > scripts/common. > > The highest valid phandle is actually 0xfffffffe. > This was my original idea so I will do following to properly handle phandles: - create a global variable phandle_next in scripts/common set to 0xfffffffe - create a function get_next_phandle in scripts/common to get the next available phandle, formatted properly in hex, which will also decrement the phandle_next I will push this as a prerequisite patch for boot-time cpupools. > > >> + local cpus >> + local scheduler >> + local cpu_list >> + local phandle >> + local cpu_phandles >> + local i >> + local j >> + >> + i=0 >> + while test $i -lt $num > > I don't think there is much value in passing NUM_CPUPOOLS as argument to > this function given that the function is also accessing CPUPOOL[] > directly. I would remove $num and just do: > > while test $i -lt $NUM_CPUPOOLS ok ~Michal From xen-devel-bounces@lists.xenproject.org Wed Sep 07 07:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 07:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400853.642472 (Exim 4.92) (envelope-from ) id 1oVpeS-0006vO-Kg; Wed, 07 Sep 2022 07:39:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400853.642472; Wed, 07 Sep 2022 07:39:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVpeS-0006vH-HK; Wed, 07 Sep 2022 07:39:12 +0000 Received: by outflank-mailman (input) for mailman id 400853; Wed, 07 Sep 2022 07:39:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVpeR-0006tv-4M for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 07:39:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27ceefd0-2e80-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 09:39:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6053.eurprd04.prod.outlook.com (2603:10a6:20b:b9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 07:39:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 07:39:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27ceefd0-2e80-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JEjJXT0Y4VJi2W3di+taPBFZq26hvSy9E3qATAgcJ8J6UAIeeTwZaPdO2E5cuORNJmFJwxf/NFdjf+Y/q1/SuIg7lRLvpZwwFKu2f0awLvMVgd+nDmv25cUvtI7SsCwAvlvwXHOXUefFw0SSU6zzFby2bxa95IC5VSfhtWfqCSTJUYz4hl0y1ka/Lv+7VmN5q+TP513UuzMYi4baGAnCjraEOQm4XbQGfOQxfLvZe6WY2e7QGaEVqztVLBxDgk3mqDWkJvmlwM2uxXWQPylKj7UWthXtFGAXltOxuP2lNFENL4PKnF3E6D7StBHTs8lG613NIel4Kkzh0RKBdNw5ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bjl2zFNl9ZBPJVYlJiyWZzvoQNO/1BnKG+C+CCbZl0g=; b=NpUTa30awwm3SJ0wpgKIPYKN/ILs0eNb/EmiWIYLKUVQupubEF76dCsJMatrH/sAw/15J7Gm3CZr+7j17AYdbtiGRERn0iep3PkGUIkwTCEkhMsQMg3uzrtQF+JrAVWFv5T5Bvs+5M3wzcPDwZ0iDTb+FzC2rkRLr1raVbf4a8VN+uGabEWQzFYyRDEMgMuRGzKdQaZb21RBRy2Il5TruXFkIkOnyp923ggym5G7UuqG1KWRu/bf5fgogK+JYcX4JOAJKA/0+QRu1cI4ySE05NbiuaGPjr6k6sKyfIwc4J0qsn+BFS683LG2rF/1Y201NDmnlc94OPL+1nNKlQVWAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjl2zFNl9ZBPJVYlJiyWZzvoQNO/1BnKG+C+CCbZl0g=; b=ixm/5cKU01x+Ud6kscRYJjtkW7GofDgFpcY2RV/BaFyUPUTJfE6gTlJ742nf82BuxRShaa3loB5bVIvh+03e55FYdpkfTjW/ImjonwqZnOGjBke6HBcUTzCAWDaRM/+TAqINHbwKu2S0cucntMHDaPQGom+LV9n82sU5CjscxMfX+NulV+iCHVMPnqi2ExXJ7wtT7b5vZcc7koa5q717Qcy/cMOo+vFjfjQ5lvtHq/SVfpCRR3bY3ZbKsae6OfjhLSKAKzZedenLUmrmVXo+Q9qlU7J/+gQw7VkI8u7fuN+LguO4327KI9q9V7f9vuDw0xYYJOib5Or0d0wrTh3eJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 7 Sep 2022 09:39:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 1/2] live migration: do not use deffered bitmap when inappropriate Content-Language: en-US To: Andrei Semenov Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: <1e7862a0d83c61b7550747591275c38e87d4fbd2.1662457291.git.andrei.semenov@vates.fr> From: Jan Beulich In-Reply-To: <1e7862a0d83c61b7550747591275c38e87d4fbd2.1662457291.git.andrei.semenov@vates.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM6PR04MB6053:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d6b621e-18e5-4c66-719f-08da90a40a21 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QfugdhAHGakdt7MLIvFuiVkVAog2kARCstjwFfp1eDWctG/e8WZjIKOOkk+gF0LS2NKtioGcrmmh0nQzYNMogtgDwHgEUJcx7Lh2QXywwF11XJUr24LkdXzBHFnUVbexiQikENZTMpEv4aAIjGFDP3MTetOrCniKqISehSzi7NOjuu4EPRIr1ytFwFGQBW2mi+xRoEI+KrAcc0/3mA2GCFNHvN56mF6QerxiqnpxPkFqAGS24QtoPvv3Oxtc2VfhsYZufVpZYVmbD8/1zCBNQan4xItOFsFoSayMX+4XbFemVDI9wq4ezUAWjqsPlwC55iA3UV+EIt6yDoObg2tSsvOcpUMhbxNSmrRXOCn36BUIEO6MFQcbt01UTJAmr33KrwtcbOnR9g3b5d2p3f5N1NZ7kYnIruO0BV1IsbsGj7Z1owyvrCYkEsr9ddhp3R0VWeliVrEfLTvTCzJmUidKJ3RY8trP8PBENrgRhEOq9cz0cn6+LgB4A4mDDp4KiQTLk9e8seNQ7vT2UzsUvLp4PAxPJ+unak+7/BlSe4K1QzN/IemlmcJ/2dY5QrROrPwZtgrDaydwD5qIVgCOb7Z2VSg4yBd/KVJ9K0KZwJKe1+L02jsaVrIKy2sPJAJJuk5ry8rnDcl10QTnRYUtNqSEB+zYu2p6qZnoEOpMwCmMTeP202kfYm4BlIzaxwc5z00g+vc0MRG+LKmUvqAITxMOfgq35nJOSQWiX7SKJQCX+Od7BOdTTnat8Nj8PptwqmGgaRYbzRyIeXMnEiyswKKSpxjNW5+7Fa/ET61dtPvbb1Nyk30zLgG1aGZerdoioW0O604PSWa3n6IC3Yeapzi+fg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(376002)(136003)(366004)(478600001)(66946007)(66476007)(66556008)(8676002)(4326008)(41300700001)(966005)(8936002)(5660300002)(6486002)(6512007)(2906002)(26005)(31696002)(53546011)(6506007)(38100700002)(86362001)(31686004)(2616005)(83380400001)(54906003)(186003)(316002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1g3a2JKaE9nUFhLUVNXYUUwbUtKdmhWYzlFdnhXSHdqM1F3Tk5abW1zcUpV?= =?utf-8?B?MmlXeVZSeFNDM2FoRlY1REcvdHZaQXM0VEM4QTJ6NWNmQ2orTWRaMU9KUXps?= =?utf-8?B?ZEs1VlRrQkdBMEJkY1pQSFB0elV2a2V2cXloZmVMeFdwcXc2OHU0NWE3eXR2?= =?utf-8?B?d3VmY3hGL1hLRGFMajQ0S2pqa0pEZmRRYkh3TFY2d1hYa1Q4VU9IbW9jZ3FJ?= =?utf-8?B?djRjZ0I3UmlJYysyNHlJTzJjRURIZCtQU21EdmZTYWRwN2JZL1pRWFRtVlpx?= =?utf-8?B?ekwxK2ZDMUxLOVVKZjh1blJyZ2k3QVpjOHhuQndOVlljUmp3bWgvbU04L3Vj?= =?utf-8?B?bFZlVVRueXgzNCs1WWdWL0J2cjRIM2UyRzNlemJiRVBuMHUrMlVYN0h5bG5z?= =?utf-8?B?RDZML1BuZjFCN3BndDh4WXdjdWRQTCs3S2RPbXhNajNnSXhPYktkMTllSUVt?= =?utf-8?B?UHgzbGtCK0M4UkxPcGZ1em00Z1Q3N0cxeHNQQWx6T3JJc2sxbEhvNWRPNjNN?= =?utf-8?B?Q2VRRzBYWUZKTE5pT0pwZktsMTVJYnJ0cGwrdTNoUHZlOURyUVE4M2gwbUlj?= =?utf-8?B?VHpmeURxQmYzZHNjUks3b2g1VGpxT3J5WHR5UmhHTHF4YzNsSmxZaTNqNnAr?= =?utf-8?B?MmJBMUNFUEtQdkdCTkwzdHlqZlUzT1JUaDh1blV6aXo1OU1JSHlhb1paM0xH?= =?utf-8?B?K0tmNnVDNG5sTTNCclAzc3FYbmw0a3RhTVpXcDR2U2JtMlNIZXJGNUUzRkFa?= =?utf-8?B?UFY0MnNNYVpXWFIwUUpwUlNGUi9nREMzL2h1a2s1WDBzbEcwMklHV1M3R0dK?= =?utf-8?B?L2Z6WHhCc0tmOXBHTUpoeGJqN3ZPVDBYcVFUWHR5VStTSDNOell2Y1FWQTAy?= =?utf-8?B?RG5GS3o4b1c0NHRkUmhqT1g3dzU5YmVnK3NwSXlQMFY3K3hJRGt6SjdPcGxK?= =?utf-8?B?a3QrWEg3cEV6WDJkQlNNcnZNS2hsdWZuM2FzWVYveHkvRWVTMXUvYzFjMzBY?= =?utf-8?B?OVVpTFAzM3FpN0dvTmhNUUpoRXdvQnhtS1QrRTl5NThJb1UxdWc0UkZFTFJX?= =?utf-8?B?b1ZmSHd4MUlZOWJrSjFROHZLZkk4Uk01T0JPNFhHU3FkSHRkcC9SelM1b2FH?= =?utf-8?B?OTVNRzd2STZlbVVDZDNXVWtDWUxoTVh1ZkZBaCtCbmNmTHgwYTgzSi9vNkth?= =?utf-8?B?YTFtWFZXTWhKbkViQkYvQmdlcWNlV0FKMk5xVWg2bWFwd1NpZnRJNWdLckFT?= =?utf-8?B?c0lac3oyb3d2bjVvNHg0OFZLSDdMeW1RVDhSSWd5RFVNNTJ0MW9tNlFIQWxU?= =?utf-8?B?Q1cyb2hpK1d3bU1ZYS9UeFpzVUYzV2M5SFFMNWJsOEhhaGc4TmE0Zi8wRSs4?= =?utf-8?B?MStzOVQrR1Q3N0c3ejJwSldxRE9CRW91QjdvdDVGRFFDbitsYW1wWnRKb1RL?= =?utf-8?B?YmhLa1h2QnZXZ1pIRFpPS3RXM25jcGg5TnhVam5ERGxvVDM4ZFIxWityaG9o?= =?utf-8?B?cHdXQ2ZsSmx5czltQXFXc0dGTlFEQ0VuZkNFcnZZZkp6WC9EUXlVVS9XdUJK?= =?utf-8?B?M1NQLzJqQlU0ak45YjdnRm5QQkVCeDBJUWE3OEJKQ3dUay9zck9KbUJjSEJE?= =?utf-8?B?bE5mODJEZkpLTzlwNmE4Nkp5TDI0VC9QRWtVdW5yTjhrNTNIekwzQXVkWVJH?= =?utf-8?B?VzBuVXp6WG1BZkYwU3BTWHM5cjg5M2I2SFFQQ3h4d2NRU3cxbi9nNjZtc0k0?= =?utf-8?B?S1VlVGlxVmRuZzkwamVsSlR5SVhNOHBlNndPbmJlYWZHLy9MKzhzNXZjdnNX?= =?utf-8?B?MXlMTHh1RHNSU1cvS3FaaHFkbU5MVm9zWTQ3bzRPYm9pVU9jQXJYVWxNNTU0?= =?utf-8?B?SHZEYzFOWkp3Sm1qazlkVnQrS2V4S1pOMGttcWIvS1Y0MWQ0RkpjVmR2VjNQ?= =?utf-8?B?NWJza1dHUmtoeUV2ZzBzUnM3NzJGM1FWckRaSXpkSEQvQnRPM0c5bTNSL3Jy?= =?utf-8?B?dDdON09GOHk0L3lTZnhsc2FrY293K1NzR2lnbzhheUs2aGRzZE1WSmRTZkow?= =?utf-8?B?YVpNb2pZN0Z5WmlKQ21oUW01NGk4QlhmUVRpamdPeEhmdUhSdUltV0RveG0w?= =?utf-8?Q?SoJF49U+ZZxTWYLk49P8DSDGa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d6b621e-18e5-4c66-719f-08da90a40a21 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 07:39:04.6752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TtVkUqfcdpZdfaE89ysTUI6/IwDmNao9xaPmmT6/FlCOCSFPbmok2JNjhNNTEZc2NtEe/ggSNBaaZ/SzfGJSaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6053 On 06.09.2022 11:54, Andrei Semenov wrote: > Use deffered bitmap only in PV guests context as it not used for HVM guests. > This allow to reduce memory pressure on domain0 while migrating very large > (memory wise) HVM guests. > > Signed-off-by: Andrei Semenov Did you see https://lists.xen.org/archives/html/xen-devel/2022-04/msg02037.html? It would seem to me that doing what you want would be less intrusive on top of that work, by simply suppressing the allocation also for HVM then. Jan > --- > tools/libs/guest/xg_sr_common.h | 26 ++++++++++++++++-- > tools/libs/guest/xg_sr_save.c | 23 +++++++--------- > tools/libs/guest/xg_sr_save_x86_hvm.c | 21 +++++++++++++++ > tools/libs/guest/xg_sr_save_x86_pv.c | 39 +++++++++++++++++++++++++++ > 4 files changed, 93 insertions(+), 16 deletions(-) > > diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h > index 36d45ef56f..941e24d7b7 100644 > --- a/tools/libs/guest/xg_sr_common.h > +++ b/tools/libs/guest/xg_sr_common.h > @@ -96,6 +96,24 @@ struct xc_sr_save_ops > */ > int (*check_vm_state)(struct xc_sr_context *ctx); > > + /** > + * For some reasons the page can't be sent for the moment. Postpone this > + * send to the later stage when domain is suspended. > + */ > + int (*defer_page)(struct xc_sr_context *ctx, xen_pfn_t pfn); > + > + /** > + * Merge all deferred pages with the dirty pages bitmap (in order to be > + * sent). > + */ > + int (*merge_deferred)(const struct xc_sr_context *ctx, > + unsigned long *bitmap, unsigned long *count); > + > + /** > + * Deferred pages was successfully sent. Reset all associated information. > + */ > + int (*reset_deferred)(struct xc_sr_context *ctx); > + > /** > * Clean up the local environment. Will be called exactly once, either > * after a successful save, or upon encountering an error. > @@ -243,8 +261,6 @@ struct xc_sr_context > > xen_pfn_t *batch_pfns; > unsigned int nr_batch_pfns; > - unsigned long *deferred_pages; > - unsigned long nr_deferred_pages; > xc_hypercall_buffer_t dirty_bitmap_hbuf; > } save; > > @@ -349,6 +365,12 @@ struct xc_sr_context > > union > { > + struct > + { > + unsigned long *deferred_pages; > + unsigned long nr_deferred_pages; > + } save; > + > struct > { > /* State machine for the order of received records. */ > diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c > index 9853d8d846..602b18488d 100644 > --- a/tools/libs/guest/xg_sr_save.c > +++ b/tools/libs/guest/xg_sr_save.c > @@ -132,8 +132,7 @@ static int write_batch(struct xc_sr_context *ctx) > /* Likely a ballooned page. */ > if ( mfns[i] == INVALID_MFN ) > { > - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); > - ++ctx->save.nr_deferred_pages; > + ctx->save.ops.defer_page(ctx, ctx->save.batch_pfns[i]); > } > } > > @@ -192,8 +191,7 @@ static int write_batch(struct xc_sr_context *ctx) > { > if ( rc == -1 && errno == EAGAIN ) > { > - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); > - ++ctx->save.nr_deferred_pages; > + ctx->save.ops.defer_page(ctx, ctx->save.batch_pfns[i]); > types[i] = XEN_DOMCTL_PFINFO_XTAB; > --nr_pages; > } > @@ -641,6 +639,7 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx) > xc_interface *xch = ctx->xch; > xc_shadow_op_stats_t stats = { 0, ctx->save.p2m_size }; > char *progress_str = NULL; > + unsigned long merged; > int rc; > DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, > &ctx->save.dirty_bitmap_hbuf); > @@ -669,7 +668,7 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx) > else > xc_set_progress_prefix(xch, "Checkpointed save"); > > - bitmap_or(dirty_bitmap, ctx->save.deferred_pages, ctx->save.p2m_size); > + ctx->save.ops.merge_deferred(ctx, dirty_bitmap, &merged); > > if ( !ctx->save.live && ctx->stream_type == XC_STREAM_COLO ) > { > @@ -681,12 +680,11 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx) > } > } > > - rc = send_dirty_pages(ctx, stats.dirty_count + ctx->save.nr_deferred_pages); > + rc = send_dirty_pages(ctx, stats.dirty_count + merged); > if ( rc ) > goto out; > > - bitmap_clear(ctx->save.deferred_pages, ctx->save.p2m_size); > - ctx->save.nr_deferred_pages = 0; > + ctx->save.ops.reset_deferred(ctx); > > out: > xc_set_progress_prefix(xch, NULL); > @@ -805,18 +803,16 @@ static int setup(struct xc_sr_context *ctx) > xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); > ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE * > sizeof(*ctx->save.batch_pfns)); > - ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); > > - if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages ) > + if ( !ctx->save.batch_pfns || !dirty_bitmap ) > { > - ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and" > - " deferred pages"); > + ERROR("Unable to allocate memory for dirty bitmaps, batch pfns"); > rc = -1; > errno = ENOMEM; > goto err; > } > > - rc = 0; > + rc = ctx->save.ops.reset_deferred(ctx); > > err: > return rc; > @@ -837,7 +833,6 @@ static void cleanup(struct xc_sr_context *ctx) > > xc_hypercall_buffer_free_pages(xch, dirty_bitmap, > NRPAGES(bitmap_size(ctx->save.p2m_size))); > - free(ctx->save.deferred_pages); > free(ctx->save.batch_pfns); > } > > diff --git a/tools/libs/guest/xg_sr_save_x86_hvm.c b/tools/libs/guest/xg_sr_save_x86_hvm.c > index 1634a7bc43..3c762a0af0 100644 > --- a/tools/libs/guest/xg_sr_save_x86_hvm.c > +++ b/tools/libs/guest/xg_sr_save_x86_hvm.c > @@ -211,6 +211,24 @@ static int x86_hvm_end_of_checkpoint(struct xc_sr_context *ctx) > return 0; > } > > +static int x86_hvm_defer_page(struct xc_sr_context *ctx, xen_pfn_t pfn) > +{ > + return 0; > +} > + > +static int x86_hvm_merge_deferred(const struct xc_sr_context *ctx, > + unsigned long *bitmap, unsigned long *count) > +{ > + *count = 0; > + > + return 0; > +} > + > +static int x86_hvm_reset_deferred(struct xc_sr_context *ctx) > +{ > + return 0; > +} > + > static int x86_hvm_cleanup(struct xc_sr_context *ctx) > { > xc_interface *xch = ctx->xch; > @@ -237,6 +255,9 @@ struct xc_sr_save_ops save_ops_x86_hvm = > .start_of_checkpoint = x86_hvm_start_of_checkpoint, > .end_of_checkpoint = x86_hvm_end_of_checkpoint, > .check_vm_state = x86_hvm_check_vm_state, > + .defer_page = x86_hvm_defer_page, > + .merge_deferred = x86_hvm_merge_deferred, > + .reset_deferred = x86_hvm_reset_deferred, > .cleanup = x86_hvm_cleanup, > }; > > diff --git a/tools/libs/guest/xg_sr_save_x86_pv.c b/tools/libs/guest/xg_sr_save_x86_pv.c > index 4964f1f7b8..5fdc7e9590 100644 > --- a/tools/libs/guest/xg_sr_save_x86_pv.c > +++ b/tools/libs/guest/xg_sr_save_x86_pv.c > @@ -1031,6 +1031,7 @@ static int x86_pv_normalise_page(struct xc_sr_context *ctx, xen_pfn_t type, > */ > static int x86_pv_setup(struct xc_sr_context *ctx) > { > + xc_interface *xch = ctx->xch; > int rc; > > rc = x86_pv_domain_info(ctx); > @@ -1049,6 +1050,15 @@ static int x86_pv_setup(struct xc_sr_context *ctx) > if ( rc ) > return rc; > > + ctx->x86.pv.save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); > + > + if (!ctx->x86.pv.save.deferred_pages) > + { > + ERROR("Unable to allocate memory for deferred pages"); > + errno = ENOMEM; > + return -1; > + } > + > return 0; > } > > @@ -1116,9 +1126,35 @@ static int x86_pv_check_vm_state(struct xc_sr_context *ctx) > return x86_pv_check_vm_state_p2m_list(ctx); > } > > +static int x86_pv_defer_page(struct xc_sr_context *ctx, xen_pfn_t pfn) > +{ > + set_bit(pfn, ctx->x86.pv.save.deferred_pages); > + ++ctx->x86.pv.save.nr_deferred_pages; > + > + return 0; > +} > + > +static int x86_pv_merge_deferred(const struct xc_sr_context *ctx, > + unsigned long *bitmap, unsigned long *count) > +{ > + bitmap_or(bitmap, ctx->x86.pv.save.deferred_pages, ctx->save.p2m_size); > + *count = ctx->x86.pv.save.nr_deferred_pages; > + > + return 0; > +} > + > +static int x86_pv_reset_deferred(struct xc_sr_context *ctx) > +{ > + bitmap_clear(ctx->x86.pv.save.deferred_pages, ctx->save.p2m_size); > + ctx->x86.pv.save.nr_deferred_pages = 0; > + > + return 0; > +} > + > static int x86_pv_cleanup(struct xc_sr_context *ctx) > { > free(ctx->x86.pv.p2m_pfns); > + free(ctx->x86.pv.save.deferred_pages); > > if ( ctx->x86.pv.p2m ) > munmap(ctx->x86.pv.p2m, ctx->x86.pv.p2m_frames * PAGE_SIZE); > @@ -1142,6 +1178,9 @@ struct xc_sr_save_ops save_ops_x86_pv = > .start_of_checkpoint = x86_pv_start_of_checkpoint, > .end_of_checkpoint = x86_pv_end_of_checkpoint, > .check_vm_state = x86_pv_check_vm_state, > + .defer_page = x86_pv_defer_page, > + .merge_deferred = x86_pv_merge_deferred, > + .reset_deferred = x86_pv_reset_deferred, > .cleanup = x86_pv_cleanup, > }; > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 07:40:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 07:40:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400862.642483 (Exim 4.92) (envelope-from ) id 1oVpg1-0008JU-3e; Wed, 07 Sep 2022 07:40:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400862.642483; Wed, 07 Sep 2022 07:40:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVpg1-0008JN-0c; Wed, 07 Sep 2022 07:40:49 +0000 Received: by outflank-mailman (input) for mailman id 400862; Wed, 07 Sep 2022 07:40:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVpfy-0008J7-UB for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 07:40:47 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2072.outbound.protection.outlook.com [40.107.104.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 61c24ba8-2e80-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 09:40:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6053.eurprd04.prod.outlook.com (2603:10a6:20b:b9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 07:40:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 07:40:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61c24ba8-2e80-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAsudtBTvSXvkdsH1ymdjxlOxUo/2O416qS8PhTseDdOlh6zlihZMaQ+yc0ToF6mvCOzMFeSF/l8GIY/oPoPkmNb5X+inBbYPv/ul/lS+Vt6cC3escwxQVF+uSvHrhBToSu8mhm2/tsBuZ5aqXyMvRiG6lMEHNL5E+BIzEP+DuEjcyJlnQmqxp9OSi3ftziHGI+0AvoQWdnYDlM4c31MSdW5/oxwhkD0b12sU5ARRHq2y12pj4Qtb3z5zwq3ej+PWeKR/pGhTb9CkqK3AGyTXeghHN9QTfAZHQlCshcfO/VpsPV/4Gxvgl5M8ki/pAvnvWWwqf5xXe5bK1XvWo/sWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6WixJyynWc/r512BygQzcQt+HqqYCwdWSrFx73zK/n4=; b=N5U+szF9m+3UU4jupm7lTRZ8iKaROR9ERo/amq1Gykme6gtICExp9l+U6VGf2hwWtMhPbHNf/Gm3RYIgpoP+bp0pIVMPJKPGRHNWlAdEvvnF2uQ8/m9qjLX5heav+sAMOLSRNdoFzHTfju7QOAUCaBF22cy1feidmhESb80Jm9V7Or6oaQddZHY94njM8prO07hC6KkWmWTrdZmJdj3Wj9eo6G3IhwmmmDUxrvSs/LRZP04VLFdHcc5qyfnlMTqtKbwoMPgmoKdLPojxZTq/at4U7ov/kH9h8ZJ8x6uPzTgcJxhKfJpma568fNUoRhu3xBmsIQoBmzvw2tep3Smi0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6WixJyynWc/r512BygQzcQt+HqqYCwdWSrFx73zK/n4=; b=SpC4mHIcg6W+5WpC2N6rLjrYf/FszLXjp+rXsJn5pSMEosQ6okCnWeDtsQ5pS5oCBMQnC4Mk+MboF0VZGdoKfl/bj5hnDdUbCmlZKMWJroWuT81SKItXZUz7O0t1iZPFikKKeM9UdEhMPiE4IK0zwhDZXKBXZpe5BpIbcqHN/+onXPjiE/aznPcWD6j88sjmj1y/vkgRQi1Fi1cd6nK/POzT9eDn2uN6tB69teivsMU4nciRqfyqVlTaJf6wbWKQvfnGfrXVheSc+uhrahvDu1CFFPcf/OCoJsylCoGWl+tyF0wqDiM8GaayzlDUXqBMiTGtzvgUa24kKjeQpyvr+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 7 Sep 2022 09:40:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible Content-Language: en-US To: Andrei Semenov , Olaf Hering Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: <657d6dad39f4ab87569470c94afb4cc6d005e829.1662457291.git.andrei.semenov@vates.fr> From: Jan Beulich In-Reply-To: <657d6dad39f4ab87569470c94afb4cc6d005e829.1662457291.git.andrei.semenov@vates.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM6PR04MB6053:EE_ X-MS-Office365-Filtering-Correlation-Id: 531d7a45-e1ce-450a-7804-08da90a444e9 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y0E0Ked9kAvkTrnNdvaNm9eH2X4QVngzunmhMHaBKbFH16YHaK/hX06AaUqQ9NMUAU1qDy4vnQHKSNjAWp/277iOBzeuSMpbLSHKfshM6TwcFbcLdzDgoxuDPloeCbdKdA6Pktb2T9r3T4MPNifr8hvb43+YYNa//+xFqr19I1t+hle4BGFY3D4vslDo/1aVIdbZ2Q5zePtAtZQXR3tBPnjaAvzL5VR6Jy+a6XrGwjDWINBv4X6w8jcLsrg3wCt7PzF7elhH8TitStu9AHJMURwxKAI6bLbQnhiFU4xvdjwu3imay9e/Ycqv1OXXprJu1Dr14X8j27ZGjCBDAMr89KWurmXoxeyVJKLZXFy8B6Gr4GKPwOBPL5OAWkNh+2pSdVRwfMWYJC5+PSdq3oRMbFwPqMf101gnd9xZI3ppPm7Pw1zgZYa9ABYEm0tTe5V8svztxfnIcCDxiAZdR/Ew0waGx3VhsbX8aZ8BlarSy/RNgi+jzT3ruC0onHo4PUA4Z/TpHDHC4gEcEAXT+0i3CSresc9cyk+VBDRGmhQZf1kXQO1h4Xf/iai2dDHNLBVCL1uYYGf2cuo9QkIf32xde7lsKOJebxmyurPkE5XyUpa5IWvZXWrWjZ8uQmZZmkikVsSQbNkGEu5vqHmwbaSpoS+mOEoulr2UbQysgEsXx7oMnG8T1fGOfqx7gbkAMdBirgR+1FAgq2U1HliS5S7cdrORh6AcNwMOcUuRqnZFz3STcBKmwEWnh5vx+YMfEC7C7+muzmGoYJWTHGlLYos7IkwU4s3OtZj4e5qY+e1CZgM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(376002)(136003)(366004)(478600001)(66946007)(66476007)(66556008)(8676002)(4326008)(41300700001)(8936002)(5660300002)(30864003)(6486002)(6512007)(2906002)(26005)(31696002)(53546011)(6506007)(38100700002)(86362001)(31686004)(110136005)(2616005)(83380400001)(54906003)(186003)(316002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEcyVmZXTHZvTkdXWUNwTy9Qc3BoVFpla2s1czgrcSsxQzFqQ3dkNGwxVDBS?= =?utf-8?B?UXN6U3hEVHVCdFZyUjJnOXl2VysxaktUOEZTQkgveCt4K0txekhkK1IwM2U1?= =?utf-8?B?cUxqMnNxaklrYk9Rdmo3UlNNR3piU1lLVks1K3c3Q3pES2k2OGdxMDc2TXlw?= =?utf-8?B?KzBCczdQRlVsVnRWMXBWMlJ3N1ZBenFHVlByOE1lUGhneEQ0SUxvbEVJUk04?= =?utf-8?B?TnFGNlNtUVZmOGhEckpoaU8yM1ZTVyt6bGJBd0FuMjBIdUgzWkpZeGJUNmt6?= =?utf-8?B?ZGdqRzczN053d1piRCtDOXNQSVFnR0lJWVI1REE4V1BMWjhuOThSSHFoVFFI?= =?utf-8?B?NlNMU0kvaXY2UUxZRHA2WjY3RjRRSHJpZTlDOVlUTDkwSkZuSVNXOGhwTzV4?= =?utf-8?B?TVo5aVhCd3ZqN0I2WiszT1ZEQUhoQk9KWDVmZlh1bk45OVIxakNhbmIvZVlD?= =?utf-8?B?NVZwcWFsZVpvdGcxR3ExK2ZidWd1aHZhL1ZsMytoM1JBMk13dERPdmNybDRn?= =?utf-8?B?bkpBL0k5ZU45SUNyMlRpZVZGTDNua3ZIMGtob1FXT01TMkl6b0U5NkxUUmhC?= =?utf-8?B?a0NFQ3hBQi9ROUkyYkI0T3huRU9aT1I5M05RaGVzcGhvUHZzd0E4Q3ppcEpv?= =?utf-8?B?SlRyM2ZocU1aNHc0dDlwOG91VkVyTTB6RjlYOFhBQWdoY3hDVC9LL2hNcDly?= =?utf-8?B?UndlcVhOa29QR3BaSnFRL1lWRS9mem9vNXdFOUMxUGh3WnhuY3pxb2ZOTHZ1?= =?utf-8?B?SzM2OE9wdWlHY3VYamVoMW4yS1BqdlRvcW1vb1VNTW05dUJXMFNmU3JKeXlN?= =?utf-8?B?UnNDcDh6eFJqWTJIR1oxREtaZ05FU0pTQnhHL3Z5YXhZd3dxK0pXbGdubUZv?= =?utf-8?B?OXpOajNmVWZ6WE9UZUY3QWc1ZGhCOUQ5RUVyWnRJNHB6Z3lCSkZUUzNuY2hK?= =?utf-8?B?NDJzMzZzT0V4RkRNRGpQMEFBckhmOGF4Y1JaNHJFd09UclEwUHdmRWo3U3pi?= =?utf-8?B?L0xlWFV3NkhPQUhPZ0hLbGtBakNvUm5pRnllQk82TDJMRjlrQzlmMmhDU0R2?= =?utf-8?B?Z01STU43bzdueFdpWDM0cmMvNjcwZ0F4bVptWGI3TFhhWTJIa2FONEdOc1RE?= =?utf-8?B?QWFNUGpmMVNnSU1hR2ZBdS9oak1hb2JaeUQyay9RQUM0eVBUZ1N0Y1NqYThS?= =?utf-8?B?NmxHdkNNejFIZm9xZXlRVVV6Z2N6TVpScmwxS1g5MENzUmJsNGtlQldxUHZm?= =?utf-8?B?OURLMWI3V1dNZ1ZxNG45dFlpMVRHWDVzdHhDYkg4aVNVdEFoMFpMZGIwVHhR?= =?utf-8?B?OHVpQnh3MDUyaVR4RnhacDRSa2ZQQjFEa1pqcFR4MXFKLzRDc0h6aDNRajBZ?= =?utf-8?B?ZEgyMnVjcitvUmFRTU01cTMvRnh2K2hDQ3hybUJ5YTNYZjBXclhUSEFvVGR4?= =?utf-8?B?RE00NUZNdmdGMXJleTVzdU1zcmpnOTlaZmI5YWduZkpnR1NnNjcreUpvQnA3?= =?utf-8?B?TWFFNEZTNDdVbmQyd2ZmZVloVGZVYlZxZXFNcldMZnI1ZVFqbUlTaC9tM2tX?= =?utf-8?B?WjZFTDRoVGxLajM0QUt5WkRoL2E1K2d6R3JoVW05OURvQjR4S0prRFFhQmkv?= =?utf-8?B?dFU3eE91L3NDajBtd2JEVlB1dUQ3eXhPbW5jQXdrdXF0OXduVjlJdk52WXg3?= =?utf-8?B?Q0hycUdTSkMxeFBXeWErOXZGek1DZXR2Wkhkc3RrSFNDa0ozYXdVWXByd01u?= =?utf-8?B?eVFHV24xRjdIT1l5SmVPMUxPemVtYkllN3Q4ZXE4dXI5NHgzL3I5MEJhbTZt?= =?utf-8?B?RVZyVXVBN0NnTmVXbnV6RFFrM3lRVmVSRTRZaEJwQ2NrQjM2WC9ZSCtBendE?= =?utf-8?B?alZmN0Naa0h6OFFmbmZMdE1tMUh6UzB6NWNvNW5zYmVBM2Fkc1Z5dFpSUHJ3?= =?utf-8?B?bldPL2NIeEk1Z3FKd3Izb3ZhZkFyV3VxS0w3aDJrbDlJSEFtWnNFT3RvY3E5?= =?utf-8?B?UnlBOUMvWkJDdFpBZUxvYWZSL29WV20ycmNGUHBKMXozZ0Ztc1ZTU2IySW9i?= =?utf-8?B?ZVlRdm56L20xUzJkcUlraVlpRHlXL29UYTViTE8vRGZQMWF3QThwVThpVUpK?= =?utf-8?Q?Id1PArVgU3OBMZ9prngArk3M4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 531d7a45-e1ce-450a-7804-08da90a444e9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 07:40:43.3096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d0eTkisKvkQJHD1awmpyG4VSlW6y1F3aBpp/I5086CnvSkM4kpPp23AVpp+Le1X8pLZPk39noNuF3YWRXJdtHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6053 On 06.09.2022 11:54, Andrei Semenov wrote: > Implement an heuristic for X86 HVM guests which tries to use superpages while > populating guest physmap on live migration. This should impove memory accesses > performances for these guests. > > Signed-off-by: Andrei Semenov Olaf - I recall you've done some similar work before. Do you have any thoughts here, perhaps going as far as merging your and Andrei's work? Jan > --- > tools/include/xen-tools/libs.h | 4 ++ > tools/libs/guest/xg_private.h | 3 + > tools/libs/guest/xg_sr_common.h | 18 ++++- > tools/libs/guest/xg_sr_restore.c | 60 +++++++--------- > tools/libs/guest/xg_sr_restore_x86_hvm.c | 88 +++++++++++++++++++++++- > tools/libs/guest/xg_sr_restore_x86_pv.c | 22 +++++- > 6 files changed, 154 insertions(+), 41 deletions(-) > > diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/libs.h > index a16e0c3807..bdd903eb7b 100644 > --- a/tools/include/xen-tools/libs.h > +++ b/tools/include/xen-tools/libs.h > @@ -63,4 +63,8 @@ > #define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1)) > #endif > > +#ifndef ROUNDDOWN > +#define ROUNDDOWN(_x,_w) ((unsigned long)(_x) & (-1UL << (_w))) > +#endif > + > #endif /* __XEN_TOOLS_LIBS__ */ > diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h > index 09e24f1227..dcf63b5188 100644 > --- a/tools/libs/guest/xg_private.h > +++ b/tools/libs/guest/xg_private.h > @@ -134,6 +134,9 @@ typedef uint64_t x86_pgentry_t; > #define PAGE_SIZE_X86 (1UL << PAGE_SHIFT_X86) > #define PAGE_MASK_X86 (~(PAGE_SIZE_X86-1)) > > +#define S_PAGE_1GB_ORDER 18 > +#define S_PAGE_2MB_ORDER 9 > + > #define NRPAGES(x) (ROUNDUP(x, PAGE_SHIFT) >> PAGE_SHIFT) > > static inline xen_pfn_t xc_pfn_to_mfn(xen_pfn_t pfn, xen_pfn_t *p2m, > diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h > index 941e24d7b7..96365e05a8 100644 > --- a/tools/libs/guest/xg_sr_common.h > +++ b/tools/libs/guest/xg_sr_common.h > @@ -137,7 +137,8 @@ struct xc_sr_restore_ops > bool (*pfn_is_valid)(const struct xc_sr_context *ctx, xen_pfn_t pfn); > > /* Set the GFN of a PFN. */ > - void (*set_gfn)(struct xc_sr_context *ctx, xen_pfn_t pfn, xen_pfn_t gfn); > + void (*set_gfn)(struct xc_sr_context *ctx, xen_pfn_t pfn, xen_pfn_t gfn, > + unsigned int order); > > /* Set the type of a PFN. */ > void (*set_page_type)(struct xc_sr_context *ctx, xen_pfn_t pfn, > @@ -175,6 +176,17 @@ struct xc_sr_restore_ops > #define BROKEN_CHANNEL 2 > int (*process_record)(struct xc_sr_context *ctx, struct xc_sr_record *rec); > > + /** > + * Guest physmap population order is based on heuristic which is family > + * dependant. X86 HVM heuristic is interested in observing the whole > + * record (the first) in order to guess how the physmap should be populated. > + */ > + void (*guess_physmap)(struct xc_sr_context *ctx, unsigned int count, > + const xen_pfn_t *pfns, const uint32_t *types); > + > + /* Get the physmap population order for given PFN */ > + int (*get_physmap_order)(const struct xc_sr_context *ctx, xen_pfn_t pfn); > + > /** > * Perform any actions required after the static data has arrived. Called > * when the STATIC_DATA_COMPLETE record has been recieved/inferred. > @@ -404,6 +416,10 @@ struct xc_sr_context > { > /* HVM context blob. */ > struct xc_sr_blob context; > + > + /* Set guest type (based on the first record) */ > + bool set_guest_type; > + bool pvh_guest; > } restore; > }; > } hvm; > diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs/guest/xg_sr_restore.c > index 074b56d263..af864bd5ea 100644 > --- a/tools/libs/guest/xg_sr_restore.c > +++ b/tools/libs/guest/xg_sr_restore.c > @@ -86,18 +86,21 @@ static bool pfn_is_populated(const struct xc_sr_context *ctx, xen_pfn_t pfn) > * avoid realloc()ing too excessively, the size increased to the nearest power > * of two large enough to contain the required pfn. > */ > -static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) > +static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn, > + unsigned int order) > { > xc_interface *xch = ctx->xch; > + xen_pfn_t start_pfn = ROUNDDOWN(pfn, order), > + end_pfn = (ROUNDUP(pfn + 1, order) - 1); > > - if ( pfn > ctx->restore.max_populated_pfn ) > + if ( end_pfn > ctx->restore.max_populated_pfn ) > { > xen_pfn_t new_max; > size_t old_sz, new_sz; > unsigned long *p; > > /* Round up to the nearest power of two larger than pfn, less 1. */ > - new_max = pfn; > + new_max = end_pfn; > new_max |= new_max >> 1; > new_max |= new_max >> 2; > new_max |= new_max >> 4; > @@ -123,8 +126,11 @@ static int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t pfn) > ctx->restore.max_populated_pfn = new_max; > } > > - assert(!test_bit(pfn, ctx->restore.populated_pfns)); > - set_bit(pfn, ctx->restore.populated_pfns); > + for ( pfn = start_pfn; pfn <= end_pfn; ++pfn ) > + { > + assert(!test_bit(pfn, ctx->restore.populated_pfns)); > + set_bit(pfn, ctx->restore.populated_pfns); > + } > > return 0; > } > @@ -138,60 +144,40 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned int count, > const xen_pfn_t *original_pfns, const uint32_t *types) > { > xc_interface *xch = ctx->xch; > - xen_pfn_t *mfns = malloc(count * sizeof(*mfns)), > - *pfns = malloc(count * sizeof(*pfns)); > - unsigned int i, nr_pfns = 0; > + xen_pfn_t mfn, pfn; > + unsigned int i, order; > int rc = -1; > > - if ( !mfns || !pfns ) > - { > - ERROR("Failed to allocate %zu bytes for populating the physmap", > - 2 * count * sizeof(*mfns)); > - goto err; > - } > + /* Feed this record for family dependant heuristic to guess the physmap */ > + ctx->restore.ops.guess_physmap(ctx, count, original_pfns, types); > > for ( i = 0; i < count; ++i ) > { > if ( (!types || page_type_to_populate(types[i])) && > !pfn_is_populated(ctx, original_pfns[i]) ) > { > - rc = pfn_set_populated(ctx, original_pfns[i]); > + order = ctx->restore.ops.get_physmap_order(ctx, original_pfns[i]); > + rc = pfn_set_populated(ctx, original_pfns[i], order); > if ( rc ) > goto err; > - pfns[nr_pfns] = mfns[nr_pfns] = original_pfns[i]; > - ++nr_pfns; > - } > - } > - > - if ( nr_pfns ) > - { > - rc = xc_domain_populate_physmap_exact( > - xch, ctx->domid, nr_pfns, 0, 0, mfns); > - if ( rc ) > - { > - PERROR("Failed to populate physmap"); > - goto err; > - } > > - for ( i = 0; i < nr_pfns; ++i ) > - { > - if ( mfns[i] == INVALID_MFN ) > + pfn = mfn = ROUNDDOWN(original_pfns[i], order); > + rc = xc_domain_populate_physmap_exact(xch, ctx->domid, 1, order, 0, > + &mfn); > + if ( rc || (mfn == INVALID_MFN) ) > { > - ERROR("Populate physmap failed for pfn %u", i); > + ERROR("Failed to populate physmap for pfn %lu (%u)", pfn, order); > rc = -1; > goto err; > } > > - ctx->restore.ops.set_gfn(ctx, pfns[i], mfns[i]); > + ctx->restore.ops.set_gfn(ctx, pfn, mfn, order); > } > } > > rc = 0; > > err: > - free(pfns); > - free(mfns); > - > return rc; > } > > diff --git a/tools/libs/guest/xg_sr_restore_x86_hvm.c b/tools/libs/guest/xg_sr_restore_x86_hvm.c > index d6ea6f3012..2e525443ab 100644 > --- a/tools/libs/guest/xg_sr_restore_x86_hvm.c > +++ b/tools/libs/guest/xg_sr_restore_x86_hvm.c > @@ -110,7 +110,7 @@ static xen_pfn_t x86_hvm_pfn_to_gfn(const struct xc_sr_context *ctx, > > /* restore_ops function. */ > static void x86_hvm_set_gfn(struct xc_sr_context *ctx, xen_pfn_t pfn, > - xen_pfn_t gfn) > + xen_pfn_t gfn, unsigned int order) > { > /* no op */ > } > @@ -161,6 +161,8 @@ static int x86_hvm_setup(struct xc_sr_context *ctx) > } > #endif > > + ctx->x86.hvm.restore.set_guest_type = true; > + > return 0; > } > > @@ -192,6 +194,88 @@ static int x86_hvm_process_record(struct xc_sr_context *ctx, > } > } > > +/* > + * We consider that PVH guest physmap starts from 0 and coninugiously cover the > + * pysical memory space for the first GB of memory. HVM guest will have I/0 > + * holes in the first 2MB of memory space (at least for VGA). Therefore we > + * should observe the very first record (wich comes in physmap order) to find > + * out how we should map this first GB. > + * To map the rest of the memory space in both cases (PVH or HVM) we will use > + * the maximum available order (up to 1GB), except for forth GB wich holds the > + * low MMIO hole (at least for LAPIC MMIO window and for potential passthroughed > + * or emulated PCI devices BARs). > + */ > +static void x86_hvm_guess_physmap(struct xc_sr_context *ctx, unsigned int count, > + const xen_pfn_t *pfns, const uint32_t *types) > +{ > + xen_pfn_t prev; > + unsigned int i; > + > + > + if ( !ctx->x86.hvm.restore.set_guest_type ) > + return; > + > + for ( i = 0, prev = INVALID_PFN; i < count; ++i ) > + { > + if ( !types || page_type_to_populate(types[i]) ) > + { > + if ( prev == INVALID_MFN ) > + { > + if (pfns[i] != 0) > + break; > + } > + else > + { > + if ( pfns[i] != (prev + 1) ) > + break; > + } > + prev = pfns[i]; > + } > + } > + > + ctx->x86.hvm.restore.pvh_guest = (i == count) ? true : false; > + ctx->x86.hvm.restore.set_guest_type = false; > +} > + > +/* > + * > + */ > +static int x86_hvm_get_physmap_order(const struct xc_sr_context *ctx, > + xen_pfn_t pfn) > +{ > + int order; > + > + if ( pfn >= ctx->restore.p2m_size ) > + return 0; > + > + switch (pfn >> S_PAGE_1GB_ORDER) > + { > + case 3: > + /* The forth GB of memory is mapped with 2MB superpages */ > + order = S_PAGE_2MB_ORDER; > + break; > + case 0: > + if (!ctx->x86.hvm.restore.pvh_guest) > + { > + /* First 2MB are mapped as 4K for HVM guest */ > + order = (pfn > 0x1ff) ? S_PAGE_2MB_ORDER : 0; > + break; > + } > + default: > + order = S_PAGE_1GB_ORDER; > + } > + > + if ( ((ROUNDUP(pfn + 1, S_PAGE_1GB_ORDER) - 1) >= ctx->restore.p2m_size) && > + order == S_PAGE_1GB_ORDER ) > + order = S_PAGE_2MB_ORDER; > + > + if ( ((ROUNDUP(pfn + 1, S_PAGE_2MB_ORDER) - 1) >= ctx->restore.p2m_size) && > + order == S_PAGE_2MB_ORDER ) > + order = 0; > + > + return order; > +} > + > /* > * restore_ops function. Sets extra hvm parameters and seeds the grant table. > */ > @@ -258,6 +342,8 @@ struct xc_sr_restore_ops restore_ops_x86_hvm = > .localise_page = x86_hvm_localise_page, > .setup = x86_hvm_setup, > .process_record = x86_hvm_process_record, > + .guess_physmap = x86_hvm_guess_physmap, > + .get_physmap_order = x86_hvm_get_physmap_order, > .static_data_complete = x86_static_data_complete, > .stream_complete = x86_hvm_stream_complete, > .cleanup = x86_hvm_cleanup, > diff --git a/tools/libs/guest/xg_sr_restore_x86_pv.c b/tools/libs/guest/xg_sr_restore_x86_pv.c > index dc50b0f5a8..f8545f941a 100644 > --- a/tools/libs/guest/xg_sr_restore_x86_pv.c > +++ b/tools/libs/guest/xg_sr_restore_x86_pv.c > @@ -59,7 +59,7 @@ static int expand_p2m(struct xc_sr_context *ctx, unsigned long max_pfn) > ctx->x86.pv.max_pfn = max_pfn; > for ( i = (old_max ? old_max + 1 : 0); i <= max_pfn; ++i ) > { > - ctx->restore.ops.set_gfn(ctx, i, INVALID_MFN); > + ctx->restore.ops.set_gfn(ctx, i, INVALID_MFN, 0); > ctx->restore.ops.set_page_type(ctx, i, 0); > } > > @@ -947,9 +947,10 @@ static void x86_pv_set_page_type(struct xc_sr_context *ctx, xen_pfn_t pfn, > > /* restore_ops function. */ > static void x86_pv_set_gfn(struct xc_sr_context *ctx, xen_pfn_t pfn, > - xen_pfn_t mfn) > + xen_pfn_t mfn, unsigned int order) > { > assert(pfn <= ctx->x86.pv.max_pfn); > + assert(!order); > > if ( ctx->x86.pv.width == sizeof(uint64_t) ) > /* 64 bit guest. Need to expand INVALID_MFN for 32 bit toolstacks. */ > @@ -1113,6 +1114,21 @@ static int x86_pv_process_record(struct xc_sr_context *ctx, > } > } > > +/* > + * There's no reliable heuristic which can predict the PV guest physmap. > + * Therefore the 0 order always will be used. > + */ > +static void x86_pv_guess_physmap(struct xc_sr_context *ctx, unsigned int count, > + const xen_pfn_t *pfns, const uint32_t *types) > +{ > +} > + > +static int x86_pv_get_physmap_order(const struct xc_sr_context *ctx, > + xen_pfn_t pfn) > +{ > + return 0; > +} > + > /* > * restore_ops function. Update the vcpu context in Xen, pin the pagetables, > * rewrite the p2m and seed the grant table. > @@ -1194,6 +1210,8 @@ struct xc_sr_restore_ops restore_ops_x86_pv = > .localise_page = x86_pv_localise_page, > .setup = x86_pv_setup, > .process_record = x86_pv_process_record, > + .guess_physmap = x86_pv_guess_physmap, > + .get_physmap_order = x86_pv_get_physmap_order, > .static_data_complete = x86_static_data_complete, > .stream_complete = x86_pv_stream_complete, > .cleanup = x86_pv_cleanup, From xen-devel-bounces@lists.xenproject.org Wed Sep 07 07:45:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 07:45:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400869.642494 (Exim 4.92) (envelope-from ) id 1oVpkd-0000cJ-Kl; Wed, 07 Sep 2022 07:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400869.642494; Wed, 07 Sep 2022 07:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVpkd-0000cC-I3; Wed, 07 Sep 2022 07:45:35 +0000 Received: by outflank-mailman (input) for mailman id 400869; Wed, 07 Sep 2022 07:45:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVpkb-0000c6-4v for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 07:45:33 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.161]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c62ca94-2e81-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 09:45:31 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 48.0.2 DYNA|AUTH) with ESMTPSA id kbf492y877jU4iv (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 7 Sep 2022 09:45:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c62ca94-2e81-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1662536730; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=3oYASW2oOvp5ZSqE2wNF0GMpMKlbg6LEKeaYP+T53Yo=; b=RXbXO5/xLgA14GfukLYniz2E+kYAoZ0t0KGvCe3ULol5NhsKKHtSjk3ujt2gebmrXM yfXg6ffkorWe4scsFKtJWnws0uC9p4EFzi3TFHmHck+iGVqXcJK3B4zZik0XlwzN3k+a YLXFv52OWXy7Rgvz0+0PGG4m1Caacr76N59hM9rB3tNU3L8dPY0d2PQQSC7rW6L4vA/+ 6XGrXWr4zPBSl74SA5BUT4on8pYJ5ia61dQUfwPgXLGY1/D0JIFAeG2cZnlEHRiv26SE CSNExadbGt82meCqGwjVISUp8AR6vUrv0CZXiQBSFh4jpbkcpi2zVdpSdU/5KDOeTpgh 4/Bg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX7VVMJ4sZGMpT3WjYz6" X-RZG-CLASS-ID: mo00 Date: Wed, 7 Sep 2022 09:45:17 +0200 From: Olaf Hering To: Jan Beulich Cc: Andrei Semenov , Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible Message-ID: <20220907094517.218e8709.olaf@aepfle.de> In-Reply-To: References: <657d6dad39f4ab87569470c94afb4cc6d005e829.1662457291.git.andrei.semenov@vates.fr> X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_//=JMiy7LvXxzVe32pVdpQkV"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_//=JMiy7LvXxzVe32pVdpQkV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Wed, 7 Sep 2022 09:40:41 +0200 Jan Beulich : > Olaf - I recall you've done some similar work before. Do you have any > thoughts here, perhaps going as far as merging your and Andrei's work? I have no hope that any such work will be merged. My variant is in the archives, for reference. Thanks, Olaf --Sig_//=JMiy7LvXxzVe32pVdpQkV Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmMYTA0ACgkQ86SN7mm1 DoDpuw//TZNxUdK5WZyoxIXTBtHTsIcmx6Xv7EtD5KUz2t0eaUBUGZap8QIGEL5p GLViwIBNRr+hC6pihinT88jPH++gBYHxbzBQgiINMrnRDIdeWLNGrFqnYQOS7Kah 8Qd8r5ORqVlifwgVfqEiB4mkTUKxS4mcMtDWO93yk/w+q4aEbLJ1UGsfB0dK0zU6 Gh4cZOSOLCOhgXlK1ME4WsJsabTcGTOeF/aZT5IhxWW74zuMIcHZxH2RNV7uxuvT nmoahUIGI/LKGeo6u5izNK8578u5ou4Mwsz1c0t0H44mrTYbWIBGfv1lw0BEY0KK 9uUONAjawH3gDbchx2LpZn7ryKhxRZhKiitXUdr++aCEA24ikFp6mi+KgCsbYWmc wGyjLMApurJfHHse6/HOw9vJoXjgVFswEJkvWU0d5jez3ujcOz16bt8uxsKvwOi6 KZAolTowSsPCAbViz8cwPGByHXeRsk+ZQCjLOPuR0df96hSxwEql+fW4n4Xw1pWS 4awdUL9vPikougDvSB0sxfgFn8fmXoddh7IEifvyfM0Me/RWZEOyTauwo+CSvdSy 8rs09nw6y/BPvQ+gzZlcv4ExnnnFDMU9YEh397aSznkxP3GjAJn8tvngtihNAOVN Fmi622GuHxKykea94nyhouL4IYOzzrTHSN/j0wOPit3hN5I8hh8= =WWux -----END PGP SIGNATURE----- --Sig_//=JMiy7LvXxzVe32pVdpQkV-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 07:50:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 07:50:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400878.642505 (Exim 4.92) (envelope-from ) id 1oVppU-00024B-7R; Wed, 07 Sep 2022 07:50:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400878.642505; Wed, 07 Sep 2022 07:50:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVppU-000244-4Y; Wed, 07 Sep 2022 07:50:36 +0000 Received: by outflank-mailman (input) for mailman id 400878; Wed, 07 Sep 2022 07:50:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVppT-00023w-3r for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 07:50:35 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bfe6b840-2e81-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 09:50:32 +0200 (CEST) Received: from AS9P251CA0003.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::7) by DB9PR08MB6572.eurprd08.prod.outlook.com (2603:10a6:10:252::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 07:50:30 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50f:cafe::48) by AS9P251CA0003.outlook.office365.com (2603:10a6:20b:50f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18 via Frontend Transport; Wed, 7 Sep 2022 07:50:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 07:50:29 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Wed, 07 Sep 2022 07:50:29 +0000 Received: from cb8704915c56.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4244D53D-5C48-42CE-B7BB-AC04BED23F62.1; Wed, 07 Sep 2022 07:50:22 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb8704915c56.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 07:50:22 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PA4PR08MB6128.eurprd08.prod.outlook.com (2603:10a6:102:f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 07:50:20 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 07:50:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfe6b840-2e81-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cBm7Yeh332e27Lco9Zk5bQ/hMgxW4NHNwycEw62FadC6TAdK+uicw2zPY6LyIfqluIJzHTovrlLEtvtlJPGBzFEAlOeSLLgRmkuoBUm94WuudQpXX9R74UIQC0pt7Ng432F4FL1WLIR2LOWlih22zGxkTVn7HusGaCvHXI5SJfPrxWCIy7TG6AugO/pVgAuyQoAk7ZfQsLpgFmVyNG7y9Vjedo/gnO1KUL7ZQebG4d/KSipLUjRwtAYqo4smm68lcLglMPVNmiZr5NrIYsqgbd6nN4fOlCAGRP1kJtzhhDiai5WOWy/oqVi+ZufgqG3wOe/WwlcdGZ5/xPN6pUKj/g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oBhxPpkOK05MpnlHBZB/4o/irs1HOP6seUR8RbDz1VM=; b=XqhzWWsBSNYXuYNpW4GTybFrzEGNY6x8Awle7xo1dxxWwVFw45yyabXBjnJyXz9bKtcp/c7pxiJQpZaSHOxQdyTt0ZGwqymFA6YoyeEc+wHovZwfzYm8SeDwEcPe+5o9tsDf+9JUQo88pOi4qWaFzeBpAijR0JQhG9wN9NXhJTv4khlpVR/idJNPvhZBoyYiPEia/0+F8bakARF+NSJ5iMYjWHHfCsiD++xU8kRR48Vl2ZqH0fZNjrcbjEG/f7STQzvTvp5Jg3dHH46jq0/Lf9oUsLenBeVoz44PyLbk7/Ku/94dT1xIoya54pQFco4YEQ/B4foyNMLpfZxrQUWiVg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oBhxPpkOK05MpnlHBZB/4o/irs1HOP6seUR8RbDz1VM=; b=0jSPMKcPVSEi0ixYewP94I0I41P4QXcXR10gtQWjbAwN2VjSog5YzuWa8b+fFZ33W57IdnQTLIFH8J/yAuRb/mH27ApxWH8N9qZlCm12B7O9Iygnm2vh+o+TawlqaTnC4YqYHVEd3SL4BTOTLAidpYg9+AZ2PPZfsiDlScL8yj0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 15d69d99e37a89b8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AvLwNkCl/CGoLKJQTpL56Mp6K/gK2fdGqFbNyGm9uZ7a0+pV0ou+u+mK1pj60DfWQK1EFeie1wPkPyTRgFRNdiK7NUsdmbsSes+17oS4UGKpUgi8NYzMBMEoI6/1MsrBDwPcU19wtY1Du4/AXbYYaGsbgrBoYDzLPCaWV4g58RFOv+cC+Liwsnao9y43vvzKQk+NC7aH7M/vBoQCrR8ASJOY5Nnmt/KmbAO9qgxmE67MNHCukfnGRya1CqGmK+64brfmLMSJbNQt+i2bSB+v/TuCzX+qq5dGQkKpvhzl46ZjUBG5xHW5J87h9yyBxWeNhUJvkN9iKKtsFFZ8JH+xGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oBhxPpkOK05MpnlHBZB/4o/irs1HOP6seUR8RbDz1VM=; b=P5RFMuIfKU9gMk0JYHBmhyUZ/kprdBcJanCb6nhnCqoh54H4i+YwBkcv/Jc+lY8/eFs/aNrLOvuM/ZwrmZPYVzow8fP7ehCxIf6VFsa15YvDMzyuP1GAD0JlJSsTA5UjcZVzNyL4P47NqpDzF8KbdCn65uvtfqXSJVAhrN/e2maBDfqmjc2kWiDiVpRMFSjH+nUpOx2OC2fiX9ZzztGlNHnfeRMsQAAhWpKsEnIh9SgJ/ijYqd5jXUSmez7AanFacAX3spDzAP1EjwefHeonrJceXOKVdmKoWVgaFl/8hhaVgPTazVwWMg76I3qCEF/KMjmJZ5gmNewV3ETYy+UOhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oBhxPpkOK05MpnlHBZB/4o/irs1HOP6seUR8RbDz1VM=; b=0jSPMKcPVSEi0ixYewP94I0I41P4QXcXR10gtQWjbAwN2VjSog5YzuWa8b+fFZ33W57IdnQTLIFH8J/yAuRb/mH27ApxWH8N9qZlCm12B7O9Iygnm2vh+o+TawlqaTnC4YqYHVEd3SL4BTOTLAidpYg9+AZ2PPZfsiDlScL8yj0= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Thread-Topic: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen Thread-Index: AQHYwdce71y3zMqBoEG+YO6j4jrBhq3SnZgAgAD7rYA= Date: Wed, 7 Sep 2022 07:50:20 +0000 Message-ID: <89733B19-C737-4A4C-80D4-42C4169331A5@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5fdcec2a-0eff-4b6b-b129-08da90a5a274 x-ms-traffictypediagnostic: PA4PR08MB6128:EE_|AM7EUR03FT023:EE_|DB9PR08MB6572:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zvLDjKZt04ZJOjYV2QX+YGTcdUMuwZzK6ZbYILkLA2C1PyBMlnHzf50WzEUEiWJYW/VCpH1TaQL90fsD0dRFLWhOiMDp51kuf3wvZXxm78w9Y2mubdSwabopQGPgU2P8/vJMNR48LRKyD6sNuFu+TBu5nIxxeMjH0A3Dy2Kkts1K/Vz4bDmGfS0Fw4Z6ksFfOjoQQ9QZOzlgrMwo8OF78ujDEjfQ00Dfpu3L90pVu11plqdKVf+ZkhB0x2YUFvuPZgKuIvTzW0HmTgsBCRpVZN2XfhbM9DfHVFyqRKBCRhh7BmJEkhq7jnYHgTmibO8g/+nn04BhIPdM0WbmMLfcnkANkvbpnml6JT8Nn5DSE//zLfVhhOdDvnjf6m50Lrfxlh7KL53Rz2W4f1llW5bpMGco/4WVWZKHZe7+3giFOT1DB8QMGd5gQlIAJbE7xEo0uvacef/7ZHonNZH1rZqv6pNYPr5sdhFmKogXrnXYyA1xpPS0vpyiN/D3lPO5V1DAkxp3OFWPV4LyZvHHWyfL9b0ThAXGIk2VAXEbxD6qNE0EOJqd6wHX/vnzJ06M0ueaGHtB+vkpjKpIwbYZ+2FzyNkwoowAD7sGWdQ/fyw/UBvLVo0n38GMHafgzeTfBcHXOOmfCNHvazkWLPxJt741BueePMKHOEzjJn+0FbPP1JWgWTrpTVPVrePvCuXefjMS1lTxOp38zIemBxta3MV/ernmarvMFZXN1O1VH9M9IN4S4dJ0Jj/ld+KUHaIFYyOR7S8HZ7IIADDZfAOBeV3YXoF0qv27zv6wPNfUMwoqe5QOz9cvdLQJ+BkDS9JNoUxW2zW7JDOB6AVmy02iB/JZRA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(38070700005)(122000001)(38100700002)(66946007)(66556008)(66476007)(66446008)(64756008)(8676002)(4326008)(76116006)(91956017)(6916009)(316002)(54906003)(2906002)(5660300002)(8936002)(186003)(2616005)(83380400001)(6486002)(966005)(71200400001)(478600001)(6506007)(6512007)(26005)(53546011)(41300700001)(86362001)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6128 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e681cabf-69bb-43d0-bfe6-08da90a59ce0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r/sUKHneIMXFtTFLEZGHuw3fb5BsFJPf/xeGKGrvzZ13ox1Q69Q1g/ee/843peMwEtKb9gXD9PM4p3H5J1T43QiW+A8VmzrBNHT+Qa5gRb5qaSzaqa4lmorSYbUA5OyjTQiIt66pdWRtpNBzTLpaF8M/oxuJZ7LnxPXe9TUrW1sic/U96T8vvb7IjvDrsE532j8exNqwJzTX4EDTgzO7myz2wnSraHaa687bR/KzPmtlmm9lTamxABDvH2Jyr8AbMWGJh6LbssWSmMtQrwrNwgXViApoKmIQNEfNlSKBV1ntDmLz2KL2vS6Jql8WfcJqclpezEweyUBf+aii3E/Rijwf9iCFV+0r297dLznd2kl9hOIk+vgn1CM5Xjx/woSQw3v54dbTZ0pyTVq6BYdj7wIbV3/CumRLOZCbyXQKunpzBWFBtt6hjU1QL6niOONaSwHTDXbQw6Mgm73Z0g+RM4vtlAAzAzFVtGI0+872a/IVHJMjfdZkOQ9V41qsLRrCiIyBPKlkeRzOdOqE6tLKGL4Sx62NY+jHt+GG0jwB0y2IAVtJFaWJiGtFTloN0K7wz/7suDKzCHpvEvPfFu/zNRJN6CV5CFjakTApLJnkca9nelvCZznxhsfrXxnxc4u0VdDQGtz/Vjv3LOgp9J/NchGaG3Dm5JvIUfs+Q9aS9KV37MRKStkPxPUvtYC6JtT9VW+6QRzFLWu3EU8+zrW4GDm9IVkdENw61pybU+bMdCZpxtPZp49D8ZcdMFoq3FyRRVCFnqFNk7xTRK4bCwfO7J4z2ol1vw8EJU6KQVI5jMg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(36840700001)(46966006)(40470700004)(5660300002)(2616005)(53546011)(6862004)(8936002)(40480700001)(336012)(186003)(82310400005)(2906002)(41300700001)(26005)(6512007)(6506007)(33656002)(36756003)(107886003)(86362001)(47076005)(83380400001)(966005)(6486002)(478600001)(356005)(81166007)(8676002)(70206006)(54906003)(70586007)(4326008)(316002)(36860700001)(82740400003)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 07:50:29.5281 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5fdcec2a-0eff-4b6b-b129-08da90a5a274 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6572 Hi Julien > On 6 Sep 2022, at 17:49, Julien Grall wrote: >=20 > Hi, >=20 > On 06/09/2022 10:55, Rahul Singh wrote: >> This patch series merge the applicable Linux fixes to Xen. >> Bixuan Cui (1): >> xen/arm: smmuv3: Change *array into *const array >> Christophe JAILLET (1): >> xen/arm: smmuv3: Avoid open coded arithmetic in memory allocation >> Gustavo A. R. Silva (1): >> xen/arm: smmuv3: Fix fall-through warning for Clang >> Jean-Philippe Brucker (2): >> xen/arm: smmuv3: Fix endianness annotations >> xen/arm: smmuv3: Move definitions to a header >> Robin Murphy (1): >> xen/arm: smmuv3: Remove the page 1 fixup >> Zenghui Yu (2): >> xen/arm: smmuv3: Fix l1 stream table size in the error message >> xen/arm: smmuv3: Remove the unused fields for PREFETCH_CONFIG command >> Zhen Lei (1): >> xen/arm: smmuv3: Remove unnecessary oom message >> Zhou Wang (1): >> xen/arm: smmuv3: Ensure queue is read after updating prod pointer >=20 > I didn't get the full series in my inbox. So I used the branch Bertrand p= ushed on gitlab [1]. That said, I had to tweak all the commit messages to r= emove the tags Issue-Id and Change-Id. Very sorry for that (should never do things in background during meetings). >=20 > I have also added Bertrand's reviewed-by tag on patch #3. >=20 > It is now fully committed. Thanks a lot Cheers Bertrand >=20 > Cheers, >=20 > [1] https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc/-/tree/tem= p/smmuv3-fixes >=20 >> xen/drivers/passthrough/arm/smmu-v3.c | 741 ++------------------------ >> xen/drivers/passthrough/arm/smmu-v3.h | 672 +++++++++++++++++++++++ >> 2 files changed, 708 insertions(+), 705 deletions(-) >> create mode 100644 xen/drivers/passthrough/arm/smmu-v3.h >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:05:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400893.642516 (Exim 4.92) (envelope-from ) id 1oVq3N-0004Sb-3g; Wed, 07 Sep 2022 08:04:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400893.642516; Wed, 07 Sep 2022 08:04:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVq3N-0004SU-0N; Wed, 07 Sep 2022 08:04:57 +0000 Received: by outflank-mailman (input) for mailman id 400893; Wed, 07 Sep 2022 08:04:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVq3M-0004SK-8c; Wed, 07 Sep 2022 08:04:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVq3M-0008Tw-5b; Wed, 07 Sep 2022 08:04:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVq3L-0003Dc-MU; Wed, 07 Sep 2022 08:04:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVq3L-0003PW-Lt; Wed, 07 Sep 2022 08:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6v4bjfVPKP85Hj3KOH+zlr2Jnm/fwZhG465x5deXsPs=; b=Fip/BKPmybA7BhTSK2paB+2o5X kuH6EZC5DzlZQ/u54LO+rJDoFwEqcFKzyQ0rozWJyjtCiotTh0pnH6b9CT7bkH2xJ22B13N1D9acg O2PeSwMfp1GbVVzuYXDeBeQGwWkj6hNZl9fTMXTXuaVVdTeOIwzXiLv+Zcvt5uXSvpKA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173030: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:xen-install:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=946e9bccf12f2bcc3ca471b820738fb22d14fc80 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Wed, 07 Sep 2022 08:04:55 +0000 flight 173030 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173030/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 946e9bccf12f2bcc3ca471b820738fb22d14fc80 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 34 days Failing since 172148 2022-08-04 21:39:38 Z 33 days 76 attempts Testing same since 173030 2022-09-06 19:09:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6080 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:12:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:12:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400902.642527 (Exim 4.92) (envelope-from ) id 1oVqAZ-000608-Qz; Wed, 07 Sep 2022 08:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400902.642527; Wed, 07 Sep 2022 08:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqAZ-000601-OH; Wed, 07 Sep 2022 08:12:23 +0000 Received: by outflank-mailman (input) for mailman id 400902; Wed, 07 Sep 2022 08:12:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqAY-0005zv-VR for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:12:23 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbea583f-2e84-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 10:12:21 +0200 (CEST) Received: from AS9PR06CA0273.eurprd06.prod.outlook.com (2603:10a6:20b:45a::13) by AM8PR08MB6563.eurprd08.prod.outlook.com (2603:10a6:20b:315::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 08:12:14 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::f) by AS9PR06CA0273.outlook.office365.com (2603:10a6:20b:45a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Wed, 7 Sep 2022 08:12:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 08:12:13 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 08:12:13 +0000 Received: from e4e4ba9b2f29.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3D3A2FFC-3648-4B0A-B9AA-BDD80B8AD204.1; Wed, 07 Sep 2022 08:12:03 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4e4ba9b2f29.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 08:12:03 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AS2PR08MB9200.eurprd08.prod.outlook.com (2603:10a6:20b:59f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 08:12:01 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:12:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbea583f-2e84-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Eby+4Hp1JFq7DxqTCrehLhuQ0huEYv0eHU5qtw5fHNapPbhLxD/j6mwjeZKkwQj+xnKwovvEDBiskYX4eaDel6bcB2idDszm63iVmfXfL2hK82CkMZaANKlm9ZNy/po5psE/Dkwqq0hojSxPpq3hszGQjYBZHQdvI71bs0ztorpckzedtBTY/HM8JXAGrFJ1CzPfoBaTcfhmYSG6pqO+FZf4TvJoonSCFvckh3veQnzUgyPrUh8nvus8tElVgbvRxeBdHHeYl9I2Dz9f3iHlJqkdsLyPIF0TzT072+00bJHd35YxHNnJs3N3O1y+1KQnY52SlT1nGPhnmPG0B4/fNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zN3M3oye3PQVSKA1Cv6n60rXXNpSR1XlSdPnXzHG6Ao=; b=a8gT03YaN8ylc8yarGM2kwg5rBouLH73xU3q8PNtKd3bzXB3JaGfvUIwOx2ibKfEe3+5voSAYlZ+JnwhfYNNJZwpZu3I9GDmokUjErBCxkH+/xzV1o4Y0C0n3AH0vgqSf4o5MQupf2c3Of0vsF9nixau+R4H7c4ZYdduEKfIlJGop/CI0CYZ+S/CgeehHMSrq86brVu8rPRVzDJ7AZB32f1W9B5HL90LpnmzjVZQ1cZ+S7ZphTgzLbqKFOnFGWZn8pTiKFZ5aTM7X4CvPfz3lGQc92NvHvsTlh6otEj+W0vMQ6sRL4rxNdfVcCQitxWPi+PDlomGcbZ46mG4CuVU1g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zN3M3oye3PQVSKA1Cv6n60rXXNpSR1XlSdPnXzHG6Ao=; b=D+DZ9s68nzfjQ1qUdjJVfFC11rjTOKlihqN54zWma0o913ef65GAUeju2AQkAPQF7/Nh6+3ZySDDSK8KI6ZTSCNZdY8YTgzaDN5cFojZcTeZBNFsQW5vPW25FvqoTorJ20B21ZwgeAqkfWPWBpdgYIW2E5FJ0aMPhr5BBC3MrZM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7b92b8caebd4e866 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEIczkK3QYFu0Nl2f3Lk+Kqq3cfvMNyOOHIzOBTz3a8qbFqqj+etgSJYDQzmaP2ZOnh4SNKxWIOQsKvi0waFhhBF+KCI4kOckfUkazcET5UD3BbwnoSAxsfZwIkJqBPxQstgIgW+B5KjIxjMk/9SVBnlnEaFrFmK8C/1nv1jo5ewBtWJeeG7DwI4AUv8TPqLJXi0VY3H8kg49jH+A0LFkLZqrnoao2quuAgjvbL0MV/wYPfBS6Dp0JLmM66yLMdYRbdyp6ynHg+SetP2O5mdYT1McbXAOW7beaYt4sN1KJBhMUOpAT2GhQWge1wARH/jCg8gvAFpb501M+OLFafOJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zN3M3oye3PQVSKA1Cv6n60rXXNpSR1XlSdPnXzHG6Ao=; b=haEGYez9eyZLFyIODD2jgToxXpVQY/ndvdmv2ULRd6qT062sUy7pcZ/AUihQZm1JrfvleM+PrOUd1fbp5XH934aHRPwLXnwUpXK3KhQMkHnP9RcLG5Abnh8Tq9io5YiHUDd4CwC+6VK9JANuVR5lUiPoyekM0wrpE8xMjQHv5e05n1PrfWBMrsIjT4R+3V8ep85goovUNC1ZgjPdd0ziY01OTo5XzKo5gXGTQVaxk+X9M7m+oJbsjAurlUFqTxsqbeEmXAiYxFNjGsTkmhBqLyjGnrYlygegf78jQvxtI0Tfr4Bvukvdkucc3aacEC792YRGQDSb/MkyNjoQAw7MTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zN3M3oye3PQVSKA1Cv6n60rXXNpSR1XlSdPnXzHG6Ao=; b=D+DZ9s68nzfjQ1qUdjJVfFC11rjTOKlihqN54zWma0o913ef65GAUeju2AQkAPQF7/Nh6+3ZySDDSK8KI6ZTSCNZdY8YTgzaDN5cFojZcTeZBNFsQW5vPW25FvqoTorJ20B21ZwgeAqkfWPWBpdgYIW2E5FJ0aMPhr5BBC3MrZM= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 7/7] xen/arm: introduce xen-evtchn dom0less property Thread-Topic: [PATCH v4 7/7] xen/arm: introduce xen-evtchn dom0less property Thread-Index: AQHYwfa20pSXFn7Dg0K43MnT8B+Nhq3S+mGAgACkswA= Date: Wed, 7 Sep 2022 08:12:01 +0000 Message-ID: References: <055660c342c85cd97d6e3a5551c84e62f49dece6.1662462034.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e56b68c1-485a-44b7-48b6-08da90a8abf1 x-ms-traffictypediagnostic: AS2PR08MB9200:EE_|AM7EUR03FT023:EE_|AM8PR08MB6563:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zo4T6JXee9lPkj0HMp74o+3ZS9pzHFigDtmzHB57MprHszBH5b1P8GbmJZyttC+AvzWznjn42lSXS2veHB+F3OIqLrWsW5vklNw85hZj/jGQx7XBX+ToSUpIkHfxz9hc40+WOQVSJif3kl/3OLu83Lvu8I+K+r2a1wx52hRsKFx5jEoFZr/sdMXMsvC67uLHgZxns6DBMHcVCq/+k0bHHJ2JHy3a8EFktAZDcfTTQF2qUh+qyTzUw3uFy8CuTMwSkoAaHEF+LeJ0fk2Bqehy4JDKfbstN/pPlXsbu3EzJMUeRYCCVzVU6vN7WRFwEIZH3cTtFUGbKZ9skv7DVr+ut1HxL7FuG7pRJt9oF4erIuGNX3glohyfmGgcsI2JU9GaG9n0sziHmhmd7ol6N/agJ3Sq4VFSCtY2+lBtjoS8mtaZ5XzJKlQyfsdNtCXI689BQcjeEctWYwwbdw5+pxdBFxW1rlRLp7TKvSp824AI/ncFTFAyACoT0d/yWKtnsKJ3Y4A+eKbRthALqM8ni2OklKQURLwgMvYauYrA+vTUCrYEwqBkwj8Dt1GUNag+h/1C3FRBZkuL1YYSaPkL5lEPJoEWkSh5E9N794WW0zsxOftHabwqUgUVf3mBjEuWEZs93FGldCYQ8O8AnCknQGtIxnQBnabeRR9YUH348PPHyaSjeSurfu1bxO+tlDrgichriVKofGJTjqoRDv7GsnjpRWDHs/cHWqkgOFVJtQDsxhpnlfaDTPkYKVzhLFm10SuDe0kuXnD5dq7FbE48rCrslkWQapjZC3YncejHHiV/0vZ0Pij20pl6Y9w0N7l+XR8S X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(122000001)(8936002)(33656002)(2906002)(5660300002)(66446008)(36756003)(8676002)(91956017)(64756008)(66476007)(66946007)(66556008)(38100700002)(76116006)(83380400001)(4326008)(316002)(6916009)(54906003)(86362001)(186003)(6506007)(2616005)(38070700005)(71200400001)(26005)(41300700001)(53546011)(478600001)(6512007)(6486002)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <0DAD74EF2912BD479F9F9ACC154659F6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9200 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 52a8dbef-18a9-481b-b88d-08da90a8a45b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OvLqKwVauZGQCDY14eWDXlEd5i4Wa4+/fvzjiMNGR264SdH4Cte7eGewNh3ByQ4s6Z6SCWYI2C2bo6uBZtcTQ0XtpfLhDaElMjWmwGXIDQYzxKdjHEcW/uJgin0QF3q2ufVme9ZpNFTM4qMPv21IkS5e4VMbIF0fE34vBldKR91NBBroxVplmfhPYcFHSas9NNrjML2MrLDd1mIcDzecaNVCJXjUf7hWKV3PsTo7pSP9GES1+0xS2l+2pCimzte6sUx9qCF2Y6Zhmc049wmj2YOuKKKbyro5QH14lvepZN2nw1Ka6Rn45dThA/d4sd2S54odAE7UmCjB2+VUHaGsHL0CCzxmsByvzkayM/vw5WwBSEuXZo3RonbtpS4XkuVU5Uf9Rx2akWu+YSk2d6hPUQV+YIXDBYNYJJn0qjSxZp1WrZTl03jwHt6cgvUbLMganToc6AGSpa2GZHRh4y11S+LAC43hxhsS5AlZGcXg52Dxy43KzYkXmV5AEgqlXSUC0krd8WIaJdr25sJ1I6hWeo8deCNMf5jHlqvo+Q+1PShuDFp+MSytSw5vXOdFmurGzPi0FPFkm6SiCgyflelGweoVubHlPuHPbjVWZHhZuQQrng98ukkYupASwNrXqmMY+91NMeQDVqD+HCl/vyGNycngqc35sbJQSmRWm8MYPUAKQBCE7zD6owGKVCJC5BmsqacLfQj6vd7zbJBN1KafXt7s8SkyNZKYnPh/pzxGUfNGW5pB128figXIXygKfQeaaddGPtNDd9MvADnDSZw2IFJURKaESy0IzN6Ro21Sa4g= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966006)(36840700001)(40470700004)(356005)(81166007)(36860700001)(82740400003)(40460700003)(316002)(70206006)(8676002)(70586007)(4326008)(54906003)(82310400005)(2906002)(6862004)(2616005)(8936002)(5660300002)(186003)(336012)(40480700001)(83380400001)(47076005)(478600001)(6486002)(6506007)(6512007)(26005)(53546011)(86362001)(36756003)(41300700001)(107886003)(33656002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 08:12:13.9343 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e56b68c1-485a-44b7-48b6-08da90a8abf1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6563 Hi Stefano, > On 6 Sep 2022, at 11:22 pm, Stefano Stabellini w= rote: >=20 > On Tue, 6 Sep 2022, Rahul Singh wrote: >> Introduce a new sub-node under /chosen node to establish static event >> channel communication between domains on dom0less systems. >>=20 >> An event channel will be created beforehand to allow the domains to >> send notifications to each other. >>=20 >> Signed-off-by: Rahul Singh >> --- >> Changes in v4: >> - move documentation to common place for evtchn node in booting.txt >> - Add comment why we use dt_device_static_evtchn_created() >> - check if dt_get_parent() returns NULL >> - fold process_static_evtchn_node() in alloc_static_evtchn() >> Changes in v3: >> - use device-tree used_by to find the domain id of the evtchn node. >> - add new static_evtchn_create variable in struct dt_device_node to >> hold the information if evtchn is already created. >> - fix minor comments >> Changes in v2: >> - no change >> --- >> docs/misc/arm/device-tree/booting.txt | 98 +++++++++++++++++ >=20 > I have just reviewed the binding, only three minor comments below. > Everything looks good. Thanks for reviewing the code. >=20 >=20 >> xen/arch/arm/domain_build.c | 147 ++++++++++++++++++++++++++ >> xen/arch/arm/include/asm/setup.h | 1 + >> xen/arch/arm/setup.c | 2 + >> xen/include/xen/device_tree.h | 16 +++ >> 5 files changed, 264 insertions(+) >>=20 >> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic= e-tree/booting.txt >> index 1b0dca1454..c8329b73e5 100644 >> --- a/docs/misc/arm/device-tree/booting.txt >> +++ b/docs/misc/arm/device-tree/booting.txt >> @@ -382,3 +382,101 @@ device-tree: >>=20 >> This will reserve a 512MB region starting at the host physical address >> 0x30000000 to be exclusively used by DomU1. >> + >> +Static Event Channel >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> +The event channel communication will be established statically between = two >> +domains (dom0 and domU also). Event channel connection information betw= een >> +domains will be passed to Xen via the device tree node. The event chann= el >> +will be created and established in Xen before the domain started. The d= omain >> +doesn???t need to do any operation to establish a connection. Domain on= ly >=20 > doesn't >=20 > better to use ASCII if possible Ack. >=20 >=20 >> +needs hypercall EVTCHNOP_send(local port) to send notifications to the >> +remote guest. >> + >> +There is no need to describe the static event channel info in the domU = device >> +tree. Static event channels are only useful in fully static configurati= ons, >> +and in those configurations, the domU device tree dynamically generated= by Xen >> +is not needed. >> + >> +To enable the event-channel interface for domU guests include the >> +"xen,enhanced =3D "no-xenstore"" property in the domU Xen device tree n= ode. >=20 > double "" Ack.=20 >=20 >=20 >> + >> +Under the "xen,domain" compatible node for domU, there needs to be sub-= nodes >> +with compatible "xen,evtchn" that describe the event channel connection >> +between two domUs. For dom0, there needs to be sub-nodes with compatibl= e >> +"xen,evtchn" under the chosen node. >> + >> +The static event channel node has the following properties: >> + >> +- compatible >> + >> + "xen,evtchn" >> + >> +- xen,evtchn >> + >> + The property is tuples of two numbers >> + (local-evtchn link-to-foreign-evtchn) where: >> + >> + local-evtchn is an integer value that will be used to allocate loca= l port >> + for a domain to send and receive event notifications to/from the re= mote >> + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2= L ABI. >> + It is recommended to use low event channel IDs. >> + >> + link-to-foreign-evtchn is a single phandle to a remote evtchn to wh= ich >> + local-evtchn will be connected. >> + >> +Example >> +=3D=3D=3D=3D=3D=3D=3D >> + >> +chosen { >> + >> + /* one sub-node per local event channel */ >=20 > It would be good to say that this is for dom0 in the comment, e.g.: >=20 > /* this is for Dom0 */ Ack. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400911.642538 (Exim 4.92) (envelope-from ) id 1oVqBm-0006ey-9o; Wed, 07 Sep 2022 08:13:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400911.642538; Wed, 07 Sep 2022 08:13:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqBm-0006er-6d; Wed, 07 Sep 2022 08:13:38 +0000 Received: by outflank-mailman (input) for mailman id 400911; Wed, 07 Sep 2022 08:13:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqBk-0006bV-Gn for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:13:36 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00072.outbound.protection.outlook.com [40.107.0.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f82e9d9b-2e84-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 10:13:35 +0200 (CEST) Received: from FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22) by PA4PR08MB7570.eurprd08.prod.outlook.com (2603:10a6:102:26f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Wed, 7 Sep 2022 08:13:33 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1e:cafe::7a) by FR0P281CA0086.outlook.office365.com (2603:10a6:d10:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 08:13:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 08:13:32 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 08:13:32 +0000 Received: from e8b3d4db4ae5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DDD0B74A-5750-4F2A-BFE7-AF751F0C9E1F.1; Wed, 07 Sep 2022 08:13:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e8b3d4db4ae5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 08:13:20 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AS8PR08MB9669.eurprd08.prod.outlook.com (2603:10a6:20b:617::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 08:13:17 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:13:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f82e9d9b-2e84-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lBNhkbaquuwgF5H40YbTxlKLa7IO4TAKMPbQk1t3fVFPqC6KF5QO+nvtuZPTWKPMTnC7RqgC26RGLaynyc3KwSSheLFnihCdLnZwvwY14pkNj3ey+YVbLceMO43shMLR7OIq2wCc1z/S16u5Fz/JmJmvoRB+/ZTuCyDP97d5LyMlGn821910fX2fLIbP73mA4zBeNc/vmgljTckuzE4uTBo5DYTujWNTPWdO44rA+weYRthA863ubggjleNy9IIm+wlZxECSDs0tzZOfWTNq+dKIC8LVIk7mJWit2Sqd7RHy1uU+ma9k8QGum2KRdsqH+muqZf6ZHk2OneQKgyaANw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ft6uLKczm3hU5DDIuM7yyjOWYpK/8bv0f33qklLKKmU=; b=A+Q4BPM2rGrrsRnvLncvcVGPJpbgNbtweRk8tf3UTr5+4MtPFBruqDbrQWafo6ET13dr5wZ7aFb1Y+b1rfjSrxp6fUrfQL+48gZgjaFxNCI+YaRDkziwtOuGoASpG61Djr8SzrKd9+fNzG8P4p5IFJ/7c18TOs/siAgTxLSLnDkkumpwvzR4vAktmyu6sPu3FR6OJ+KRRj3COa5qFqz0MhA6XFqGou7DxnS0wWrydnRvkSGVulUuqVQ5SjD0N/krMG2Mi+QZ7ahsJnEvQQsPbNU5XCybytGoNLjHY1/K6p3mMbfOJQdQTBJPup+92FWJ05OIjY9ugSnwtC32xO+90Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ft6uLKczm3hU5DDIuM7yyjOWYpK/8bv0f33qklLKKmU=; b=tD6IrOFOd86MyiVqER8ddSCeMUDhX6qLYyZe5gd15psJyEb1IP1Zr84aZhtDIboTEjjLiVtXl+7cbk/ALSQLV9uGFm2W93qShc7mzYCDMCwZzNTE/ocOsYCdKUpqxSNU2IJMBLcKsc1g53R0DJzIN0lWalFe3qS5TLQqh3m9A98= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 111e2dc249194893 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nOwoyD6PHiJPhQH/1Rfu68VOuVYNgS5+dBzlJUDb+7piciY5wdA8769Ei1xWwiioCEHiSTouJVl0AsWH+1FjgILuoeKEKeJaz86VJL4XwNFO2lz1+5auNSKZX6Z6WFCyB/3FPKRT7fVRVZ3R+jGOZD95gzag+fH3cxeYzE88QZ5HkH9JV3Q8quFTvT0VvLAZwMx+pCqWvU5ArPdmUppdIiU38mlxsk/H8RQ8TIhrwOujboOy8wXRGH/UwpLiMSX/YZ31ILF7ey/g+b1gdvYXBBaZzVgZcm756aeDmiAcx7D+uin1gnl8Xdv06ZRRiNVmbKxaSg3sjFDNWUwZ30m/nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ft6uLKczm3hU5DDIuM7yyjOWYpK/8bv0f33qklLKKmU=; b=OrSAN7ApASwH3zs2zBHpgjJ2S75bFe2VLwowkdyKm5UIYVEMZSo+suifUPqjgIThFJiGpK9KwKH2vCUOc4rkUNNTyi90rrGNb0P+7UV8nUff+w2gA8EzG/pr+TrdQ6UsG0K7w/kK3pOL8Us8dg1apxNft9KR5uLkGvrQ46RZXEowAmRc4AYbA4pCbdWOtm+oxIoCLKVtX1tTlEY0AfjPTK57AYFWv4bUg+1wNVPWaA8PGEeH/lY3/p6xq3OTKflTt2O7DUIhBsVuy7DvyVMkuer1xleuf4oaWGf1ZlzGi/u311nyT9uIwhR0ZiFoEPB/ZKE1ohonhpuq5dQFxqJ2Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ft6uLKczm3hU5DDIuM7yyjOWYpK/8bv0f33qklLKKmU=; b=tD6IrOFOd86MyiVqER8ddSCeMUDhX6qLYyZe5gd15psJyEb1IP1Zr84aZhtDIboTEjjLiVtXl+7cbk/ALSQLV9uGFm2W93qShc7mzYCDMCwZzNTE/ocOsYCdKUpqxSNU2IJMBLcKsc1g53R0DJzIN0lWalFe3qS5TLQqh3m9A98= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYwfap3Ps5bdyrBEC9qTgdrU+ZKq3S960AgACnw4A= Date: Wed, 7 Sep 2022 08:13:17 +0000 Message-ID: <83BE5FFC-EB92-48F8-A76A-2651DD84BB7C@arm.com> References: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4fa1a18d-2922-4881-c9a7-08da90a8dad6 x-ms-traffictypediagnostic: AS8PR08MB9669:EE_|VE1EUR03FT059:EE_|PA4PR08MB7570:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3VQxxmm7hcFb/RGI2AEU5hjha0u6Pnn6dUTVE9/+xsoDuKfaUX+YpLoeGpm+GRgzPiQ0K1toTxwC+pPMZprnAXZac8hDJzQtHpmxJHEUpOzxUsaKr20MKPOjYryqEIS3TXZFbn0Eu3EPyI8KSRTnHguhkPayyQWoOrFS3wReVZcewh5BBdgWHg3FV+h6+5attRYVB7bvdoEQkt7dXFdCVbFuH7w5BbSDomG2hY0liFEdeiRM8kRLDx2jaVa1eDB5FTmGR1Mvtf+gVsqyb6gmPzBVQh5G9e1ZTh6QrF2TU7ou+5zlL2oiAxPllFUfCNDystZO/A6aDxE1wHD+jX4le/REc+f7Oc/CudE12yOVQ6ogYlGBV+X0b6vobHdLEqP0xGeBzR9S4yw5N0kxkgAGvJg351jKORwzHCq4ZjQ/XF6qxqayoJnBw/ItayL+HNCwAxpcD9Ik6N7E41WXJb6QTe+/3pnt3nZJxRAv5zTwrzp/MWRqvy6ODIJi/AJP0Xi8UZ9BcMrBLgtzTN+jNODdaTMm2xETFbUstC0jH+Hmn3/6zBtfUQlfwlRgD0riPyvxy/bd3PI7CLt/veLnPrE1WKFEIh7mrh+Hip2LqpIjnshIpo/o62oDPcgtp/HgSi82wsZvI559pX+JOrikwkyNMFsrVCRVpSolVyH4SWmN20aJCmsJ0kA/+OnhH1rOx1dSTFAskrdRZTtQx0NBM/+TQAXALmbk56GBZpN9JoIGBL9E/I9yqdywYOq0ZJHMBaVpoYoe5MlYQt/rbBontnYzpZi5PgkoTcDgXCPcPSADILM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(6506007)(86362001)(6486002)(4326008)(8676002)(53546011)(64756008)(66946007)(66476007)(66556008)(76116006)(91956017)(478600001)(186003)(66446008)(41300700001)(2616005)(8936002)(33656002)(5660300002)(71200400001)(2906002)(316002)(6916009)(54906003)(36756003)(38070700005)(26005)(6512007)(122000001)(83380400001)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9669 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dca1a666-0ac1-4f1e-c013-08da90a8d200 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OcQqw6Z3cNyvo1SHR+53/IE+C0vSaG+QT4dfNbSoNTFaSdWPhydHpYpJkL1dhNUQl+uhCIhG6Ree0epA8eP9aMUb/IhtP7a/6N91+SvxB5w5jYPY3/8gvJ86AmLV1VhlelFI0HISoiNf7CCZG8ygCdUaz2dNX+TmljcLjAVQI0UjqYx5ohCSJqIiPDst8s626mtjjnV1Pqlv0FsiGymb952VQn7u1EpO8vwJM1F+lx2Lc+XwtJf6t0umrGSX1/YsKHRcnB1Aho1vcR+yRYFqWsCibomeAGTBraZe3KjX6hPaNSPbk2GB0uXDXd/eyZ9D0DbfD4APs0DdYyUjfvy6nPPjmEyjwHon/6QpByPrHw89pMvTrjhov1E4pV2KpPeayV/9vuK7ooqmNIbUM0unylUaPYdgt65w+z0ojh0iINSjOQq5rhRU/Quk4dbNgy+9B75mCwhb3AtgOUJaw/hlPm5KrKfKf5rPtPGMjklrvznlp3bZryZbX2HrSKU8vKwQuW/d3GAkl1As1nFWlVwOBRWfrGGeyakHbxzCAnB2kEGoJhl1OSW/RuEW3Pi66IpuJZMDfZLsB6zlc6V0cFII2NI+0FRTv/gfDpOTArFgEzGsXL5QzawaNoskUkCRMFoRBdhHdRhoHEN8GGHoZ4GKxEvmuYF4Uq44N1dtcchj5T6KmZpt8+g1Wk/mS7A93luKQ0hE1HgCciGiclKWXKYRh9UF+MdGtiXFrdmqRsJympD8YEYSr6he+ZL3limpbeWePeHxNPai4FTsQcxJT5xRgQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(136003)(40470700004)(36840700001)(46966006)(5660300002)(4326008)(36756003)(316002)(40460700003)(8936002)(47076005)(54906003)(70206006)(70586007)(36860700001)(8676002)(6862004)(33656002)(2906002)(6486002)(41300700001)(6506007)(53546011)(478600001)(6512007)(40480700001)(26005)(356005)(2616005)(186003)(336012)(107886003)(86362001)(82310400005)(83380400001)(81166007)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 08:13:32.5698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fa1a18d-2922-4881-c9a7-08da90a8dad6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7570 Hi Stefano, > On 6 Sep 2022, at 11:12 pm, Stefano Stabellini w= rote: >=20 > On Tue, 6 Sep 2022, Rahul Singh wrote: >> Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to >> disable xenstore interface for dom0less guests. >>=20 >> Signed-off-by: Rahul Singh >> --- >> Changes in v4: >> - Implement defines for dom0less features >> Changes in v3: >> - new patch in this version >> --- >> docs/misc/arm/device-tree/booting.txt | 4 ++++ >> xen/arch/arm/domain_build.c | 10 ++++++---- >> xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- >> 3 files changed, 31 insertions(+), 6 deletions(-) >>=20 >> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic= e-tree/booting.txt >> index 98253414b8..1b0dca1454 100644 >> --- a/docs/misc/arm/device-tree/booting.txt >> +++ b/docs/misc/arm/device-tree/booting.txt >> @@ -204,6 +204,10 @@ with the following properties: >> - "disabled" >> Xen PV interfaces are disabled. >>=20 >> + - no-xenstore >> + Xen PV interfaces, including grant-table will be enabled but xensto= re >> + will be disabled for the VM. >=20 > Please use "" for consistency: >=20 > - "no-xenstore" >=20 Ack.=20 >=20 >> If the xen,enhanced property is present with no value, it defaults >> to "enabled". If the xen,enhanced property is not present, PV >> interfaces are disabled. >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 707e247f6a..0b164ef595 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *= d, struct kernel_info *kinfo) >> goto err; >> } >>=20 >> - if ( kinfo->dom0less_enhanced ) >> + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) >> { >> ret =3D make_hypervisor_node(d, kinfo, addrcells, sizecells); >> if ( ret ) >> @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *= d, >> (rc =3D=3D 0 && !strcmp(dom0less_enhanced, "enabled")) ) >> { >> if ( hardware_domain ) >> - kinfo.dom0less_enhanced =3D true; >> + kinfo.dom0less_feature =3D DOM0LESS_ENHANCED; >> else >> - panic("Tried to use xen,enhanced without dom0\n"); >> + panic("At the moment, Xenstore support requires dom0 to be = present\n"); >> } >> + else if ( rc =3D=3D 0 && !strcmp(dom0less_enhanced, "no-xenstore") = ) >> + kinfo.dom0less_feature =3D DOM0LESS_ENHANCED_NO_XS; >>=20 >> if ( vcpu_create(d, 0) =3D=3D NULL ) >> return -ENOMEM; >> @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, >> if ( rc < 0 ) >> return rc; >>=20 >> - if ( kinfo.dom0less_enhanced ) >> + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) >> { >> ASSERT(hardware_domain); >> rc =3D alloc_xenstore_evtchn(d); >> diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/as= m/kernel.h >> index c4dc039b54..ad240494ea 100644 >> --- a/xen/arch/arm/include/asm/kernel.h >> +++ b/xen/arch/arm/include/asm/kernel.h >> @@ -9,6 +9,25 @@ >> #include >> #include >>=20 >> +/* >> + * List of possible features for dom0less domUs >> + * >> + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. = All the >> + * default features (excluding Xenstore) will = be >> + * available. Note that an OS *must* not rely = on the >> + * availability of Xen features if this is not= set. >> + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This f= eature >> + * can't be enabled without the >> + * DOM0LESS_ENHANCED_NO_XS. >> + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. = All the >> + * default features (including Xenstore) will = be >> + * available. Note that an OS *must* not rely = on the >> + * availability of Xen features if this is not= set. >> + */ >> +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) >> +#define DOM0LESS_XENSTORE BIT(1, U) >> +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XE= NSTORE) >> + >> struct kernel_info { >> #ifdef CONFIG_ARM_64 >> enum domain_type type; >> @@ -36,8 +55,8 @@ struct kernel_info { >> /* Enable pl011 emulation */ >> bool vpl011; >>=20 >> - /* Enable PV drivers */ >> - bool dom0less_enhanced; >> + /* Enable/Disable PV drivers interface,grant table, evtchn or xenst= ore */ >=20 > missing a whitespace Ack.=20 >=20 >=20 >> + uint32_t dom0less_feature; >=20 > Given that we only really need 2 bits today, and given that uint8_t and > uint16_t are free but uint32_t increases the size of the struct, could > we just use uint16_t dom0less_feature ? Yes, I will change to uint16_t in next version. Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:15:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400918.642549 (Exim 4.92) (envelope-from ) id 1oVqDX-0007Ge-LL; Wed, 07 Sep 2022 08:15:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400918.642549; Wed, 07 Sep 2022 08:15:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqDX-0007GX-ID; Wed, 07 Sep 2022 08:15:27 +0000 Received: by outflank-mailman (input) for mailman id 400918; Wed, 07 Sep 2022 08:15:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqDW-0007GP-Ii for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:15:26 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39bbd6d3-2e85-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 10:15:25 +0200 (CEST) Received: from DU2P251CA0029.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::31) by DU0PR08MB8640.eurprd08.prod.outlook.com (2603:10a6:10:400::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 08:15:22 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::e0) by DU2P251CA0029.outlook.office365.com (2603:10a6:10:230::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 08:15:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 08:15:22 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Wed, 07 Sep 2022 08:15:22 +0000 Received: from 05b14929be20.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3071A3E9-D217-4F57-908C-C25AC91117F6.1; Wed, 07 Sep 2022 08:15:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 05b14929be20.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 08:15:11 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB7692.eurprd08.prod.outlook.com (2603:10a6:10:3a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 7 Sep 2022 08:15:10 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:15:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39bbd6d3-2e85-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dB4XHX4397zZtXLvPXhqQYBHgoC2vMgL/BCMhLd519iwcVTpvsDPUROPUnRKff8RJ5YBkcQidJgUB/YSKqFvHqiGxIHtzjQhCmvvbhRTCWsqT6pqwVvdIt/n/CX8R6BCNW3ViucyPGAAoyhpUdWjc8XSJGH5ye0y5qk9f/ni/uEsB9+BU62J7IBs1QMzNpu61Sufi0AYw1oxOJa9vqG0DKxzSVFpTONaoyoYcx1I3ATqKMV16N7evgACipOoB3nkDHbyqyqVeiHmL6fDzVqEMgrT5J/r9uVhKtVbLTRe6I0fP8M+Lz2g2Xc8ml2Ql1Q6WXq5RPPiJS7RG80vd7qdPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUz9p4/vrHxW3u4lCgSxrEnvHPOtAxd+lxsACLaA0yQ=; b=ba3p9O6zPo18w01mvot8EyMhJx6g4AyLTcVEn6qHNpOwXvWaqxF2q7Lei8J3nCZkHUbDk4n4DG7l6V+vpx1NR6Lo15cqN/CfzAkhtQ2iN7LEvg9pzqpP3JS7MT4vgLlzAXxI6+tXdF7rqtj0Trmom4w13+xVkbeiHa8JJ9dGGwu5HvLiSIeChOsGkrMqW9FwcB5Hm8z1ezl4Y7BvDN0x0t9nuXFxPhrpNascQmGjOYmBVyjDp8x9MfDtgjolMBs/gMXC48eEsBwCGE6XnwNFgSuXmWaSH0vAiV/kEKE7gyys60+g6uQkUcGlXuiX8/xrC+o+C+vfSTbQ6SQQd86CRg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUz9p4/vrHxW3u4lCgSxrEnvHPOtAxd+lxsACLaA0yQ=; b=dgoEpCZQcyzuPqZJpPSsjAwk6gKEMrstUN7fJ/Q1HgsQ2fMdlVdOyXSgudNh7ZMkguoLu428ebUGJRSzEaKOXj+D8OxibcR5K0AO1ej+9RAk9gBQpqnnOcbMJli0oElG6Yiey1+nRML59+Y9QfULHUeogd+dEetXgKJDyRw0Ie0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bbf8880585506c81 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6MPlt8LiNjerTmKeSMWwrMyxMa4a7cE1BtlGZpnGiQ8rICINZloj1kT+nfOcm1fd0M5nHKhCZx2E9XvkAyihjuxUqou9XjZxEZO2/+imRpLOTqFf/28Fdwo086rGTxrJz/ECbfT6sP/gDlrqQuiUkXN/ME5QaVQS81NdojLQo019aM1AlSmeiINgYXBrixaLmxcUpkSmdrbi7y7hFNfTx0ZtYm8z6VvBxLmttsy/xNA1A0ReedrO9TXqLS8UkQH+LEah2u2plfMUpY1oQHZBbOhQX0Em/8H0hApRgENvuUxyUwgHBsubdDiWBJOK0s1X1Jv+jgu5rnP+DuFBEQRjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUz9p4/vrHxW3u4lCgSxrEnvHPOtAxd+lxsACLaA0yQ=; b=AiveZtwr7yPPEyOE9/zgNsuxUQkMdotgLwzEXk9Me/bETeqfhJzVAiB/D6wc/j1iGgIi+sMJWS/L03479FMZiWiyf5ryj5kPPN7cMZoJsiY7A8C6ERkcVF5mayl1yGmKgC5xrJHoFuV5P2OTfEtUBj/eyF7T8xMGcLn97MH4dr5FXIvvQdBsprcdS4W9t75rjnP5hLV1ZOQdtKymI6/vW8MN9mjq3dPtVbauQmtL/lFMhUpI5sFiw9OrMutUlx7xcP9flU3uWOH9qxSrvyfwxM/TGsOpVQplcKaiqKgSIP5ry7ULGdNboEpoWh8d4iKtoIddz3roGAguwKWPDv1qGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUz9p4/vrHxW3u4lCgSxrEnvHPOtAxd+lxsACLaA0yQ=; b=dgoEpCZQcyzuPqZJpPSsjAwk6gKEMrstUN7fJ/Q1HgsQ2fMdlVdOyXSgudNh7ZMkguoLu428ebUGJRSzEaKOXj+D8OxibcR5K0AO1ej+9RAk9gBQpqnnOcbMJli0oElG6Yiey1+nRML59+Y9QfULHUeogd+dEetXgKJDyRw0Ie0= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Paul Durrant Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYveWaAk0wZPH8TEaypPBHbuXyK63NTxAAgATeK4CAAAQegIABdr+A Date: Wed, 7 Sep 2022 08:15:10 +0000 Message-ID: <7A39A45C-E29D-4D51-9748-D52DA356A552@arm.com> References: <6b230e0a-1075-1ce9-9ceb-9d3dd5410f9c@xen.org> In-Reply-To: <6b230e0a-1075-1ce9-9ceb-9d3dd5410f9c@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7e4efb33-0f3a-4f34-956c-08da90a91c05 x-ms-traffictypediagnostic: DU0PR08MB7692:EE_|DBAEUR03FT053:EE_|DU0PR08MB8640:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PyuRX3+JbFYrB3PoiPNSnP+B/nxBCiqzo88sXs8gBFDDTEBCUATr5MxMvbC3emAoUyOpXJCsXt0TAHHv15jojqheCjIfJoBIZ4HesirbkbcyP5y94ZZ495VLtSeLx8Sls6elabAgF30Lgt29+L/QqNlv1Hk33C2wgO7CoWLWzk+LzPYAgwjVDCrfkxQuecjOHUbJ3nK7Fk5uHUgBTFfnxQxBSYWiGJDRlTf2Ro7mtT2xu+mVhOYBfGmT5q5JhHf6JGcmILfFz0nzCuhHkJ3TDjAH4JA3kBjcpPxLj/Sj1XQWg4OfUOGj+o6dFqyKBlxHIflnM3BoNkvhh5NlZW2o7RUS7uaOj+wblBvOMcV4cOA/uFOzhpH2D8QFY8J6PG9w55ZufnPXAXG4kqWVlDoCPq5JurIeOt0lx7RNS/i9r/rNj/wh3ZXDixfaWnd51qtUjTV4SCkKDrIvcBhxeaDNmS57uxCnWa0nioVfZmru1xNDBUa8BMWVC4EQnTZBWssIwyCjM8X+8QsKagQLaX1AzRUtA9Jb/v/0JcOKKIItd3leP2UNYxniYXWudICWy4Tr8PSQtiOac7EQCyv5VDgFnnahWE4sQ4ekbvsUvLimaoTU7WGKSQjndPa7zZXrebCY1VrTGGIWUjKjVziuxTkxtq0qmKEfqVAU4AMb6RDHqr6ABgTtafaal8efPJBo+bouUwZalhIW3TTpLXgmDJkJV8wDXO5VvSUGF8h+qROk61e1kvZLfBVx3HtnFFn/gttFvIEzZfpTBNIJO4BrSe+iIZYZvxfCT7yZxkjCVwlZ7vI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(83380400001)(316002)(6916009)(6512007)(478600001)(26005)(6506007)(54906003)(38070700005)(8936002)(36756003)(2906002)(33656002)(86362001)(5660300002)(53546011)(66556008)(66476007)(4326008)(66446008)(64756008)(122000001)(76116006)(66946007)(8676002)(186003)(41300700001)(71200400001)(2616005)(91956017)(38100700002)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <6EB75F231BC539478B7C8ED09FE1C315@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7692 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 72beb2d3-c1c1-42ee-94be-08da90a914e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iAYi/h/B/6yMZKvgVS3dtcQRGycsALd3RlBvhXlGA0W/BeYBCzms9anXlfbZxa7360QRyYYQjzKVGaDVxzTU2sLAYROJbtgHS18JIhoVP/7r75NQfJZsdddSr5RDtXVbAeCjZjYQpYC/AAtUpKulH9kagsIG+EFd+SVkGfS5JgBExht6oJRr5RDoUOsWyJSjzoJ52931VgR50rwqtK/34xvI40bjtSFCeqG/8LUEVkjMLfpUEihsGVzGO3vu8RFCd4WDHVFULKYTkcvMhY/tmXv3VB5QJ0uF8acHrSoyFsJeiK9441VtUSMQrZNA+kE78nPz1mBg7BTbFIBVKwALObVx82up7kIg17nsND9oHG/3gFs4+S+AxKXlxdChKRYLz30E6ggyBkOJiHBpxQ2jFttpfjb3oh8HvHPlV/rm1Qp1FGuqVbdZ2Y0k5X/DcMmjiMskNYl/8rxGApDoN7WvunMPDLBaNCKXRT/0oerNkEP5bgGE+CmbZC47gsql92UrJV8Ydk7XwwbkgEVO+TkpS3Pb73lNWC+x0GIWQPCRHF2+7rBxxmrkGoNMva9fTQOsPbKUWRCqpA/kyv8Gt47QZ0yjfblNhR3j6NpAh/q8fgN8Undr/pDbDalqXtuB9PSMAdHykXA3G+84Tm3mX8gxlTpef58CsAiJOnE1gLFXQjegrbRA0qDWcHfrvDSQp2Iwz+fRTyemR4pgRVU2nZZUHQ87w2or50qyGNUkBNEWpN2C/16FYV/ZBua2HSgCxUCYxQN49v65YzO4u5q7Rvv3hg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(40470700004)(36840700001)(46966006)(6512007)(2616005)(40480700001)(47076005)(8676002)(186003)(4326008)(36860700001)(70586007)(70206006)(81166007)(356005)(82740400003)(336012)(6486002)(40460700003)(41300700001)(6506007)(54906003)(26005)(83380400001)(2906002)(316002)(53546011)(82310400005)(5660300002)(36756003)(33656002)(8936002)(478600001)(6862004)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 08:15:22.0347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e4efb33-0f3a-4f34-956c-08da90a91c05 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8640 SGkgSnVsaWVuLA0KDQo+IE9uIDYgU2VwIDIwMjIsIGF0IDEwOjUzIGFtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMDYvMDkvMjAyMiAxMDoz OSwgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+Pj4gT24gMyBTZXAgMjAyMiwg YXQgODoxOCBhbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+ Pj4gSGkgUmFodWwsDQo+Pj4gDQo+Pj4gT24gMDEvMDkvMjAyMiAxMDoyOSwgUmFodWwgU2luZ2gg d3JvdGU6DQo+Pj4+IGlzX21lbW9yeV9ob2xlIHdhcyBpbXBsZW1lbnRlZCBmb3IgeDg2IGFuZCBu b3QgZm9yIEFSTSB3aGVuIGludHJvZHVjZWQuDQo+Pj4+IFJlcGxhY2UgaXNfbWVtb3J5X2hvbGUg Y2FsbCB0byBwY2lfY2hlY2tfYmFyIGFzIGZ1bmN0aW9uIHNob3VsZCBjaGVjaw0KPj4+PiBpZiBk ZXZpY2UgQkFSIGlzIGluIGRlZmluZWQgbWVtb3J5IHJhbmdlLiBBbHNvLCBhZGQgYW4gaW1wbGVt ZW50YXRpb24NCj4+Pj4gZm9yIEFSTSB3aGljaCBpcyByZXF1aXJlZCBmb3IgUENJIHBhc3N0aHJv dWdoLg0KPj4+PiBPbiB4ODYsIHBjaV9jaGVja19iYXIgd2lsbCBjYWxsIGlzX21lbW9yeV9ob2xl IHdoaWNoIHdpbGwgY2hlY2sgaWYgQkFSDQo+Pj4+IGlzIG5vdCBvdmVybGFwcGluZyB3aXRoIGFu eSBtZW1vcnkgcmVnaW9uIGRlZmluZWQgaW4gdGhlIG1lbW9yeSBtYXAuDQo+Pj4+IE9uIEFSTSwg cGNpX2NoZWNrX2JhciB3aWxsIGdvIHRocm91Z2ggdGhlIGhvc3QgYnJpZGdlIHJhbmdlcyBhbmQg Y2hlY2sNCj4+Pj4gaWYgdGhlIEJBUiBpcyBpbiB0aGUgcmFuZ2Ugb2YgZGVmaW5lZCByYW5nZXMu DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0K Pj4+PiAtLS0NCj4+Pj4gQ2hhbmdlcyBpbiB2MzoNCj4+Pj4gIC0gZml4IG1pbm9yIGNvbW1lbnRz DQo+Pj4+IC0tLQ0KPj4+PiAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BjaS5oICAgICB8ICAy ICsrDQo+Pj4+ICB4ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jIHwgNDMgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4+ICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20v cGNpLmggICAgIHwgMTAgKysrKysrKw0KPj4+PiAgeGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNp LmMgICAgICB8ICA4ICsrKy0tLQ0KPj4+PiAgNCBmaWxlcyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQ0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1 ZGUvYXNtL3BjaS5oIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BjaS5oDQo+Pj4+IGluZGV4 IDgwYTI0MzE4MDQuLjhjYjQ2ZjZiNzEgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9p bmNsdWRlL2FzbS9wY2kuaA0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vcGNp LmgNCj4+Pj4gQEAgLTEyNiw2ICsxMjYsOCBAQCBpbnQgcGNpX2hvc3RfaXRlcmF0ZV9icmlkZ2Vz X2FuZF9jb3VudChzdHJ1Y3QgZG9tYWluICpkLA0KPj4+PiAgICBpbnQgcGNpX2hvc3RfYnJpZGdl X21hcHBpbmdzKHN0cnVjdCBkb21haW4gKmQpOw0KPj4+PiAgK2Jvb2wgcGNpX2NoZWNrX2Jhcihj b25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgbWZuX3Qgc3RhcnQsIG1mbl90IGVuZCk7DQo+Pj4+ ICsNCj4+Pj4gICNlbHNlICAgLyohQ09ORklHX0hBU19QQ0kqLw0KPj4+PiAgICBzdHJ1Y3QgYXJj aF9wY2lfZGV2IHsgfTsNCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wY2kvcGNpLWhv c3QtY29tbW9uLmMgYi94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jDQo+Pj4+IGlu ZGV4IDg5ZWYzMDAyOGUuLjBlYjEyMTY2NmQgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2Fy bS9wY2kvcGNpLWhvc3QtY29tbW9uLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3BjaS9wY2kt aG9zdC1jb21tb24uYw0KPj4+PiBAQCAtMjQsNiArMjQsMTYgQEANCj4+Pj4gICAgI2luY2x1ZGUg PGFzbS9zZXR1cC5oPg0KPj4+PiAgKy8qDQo+Pj4+ICsgKiBzdHJ1Y3QgdG8gaG9sZCBwY2kgZGV2 aWNlIGJhci4NCj4+Pj4gKyAqLw0KPj4+IA0KPj4+IEkgZmluZCB0aGlzIGNvbW1lbnQgYSBiaXQg bWlzbGVhZGluZy4gV2hhdCB5b3UgYXJlIHN0b3JpbmcgaXMgYQ0KPj4+IGNhbmRpZGF0ZSByZWdp b24uIElPVywgdGhpcyBtYXkgb3IgbWF5IG5vdCBiZSBhIFBDSSBkZXZpY2UgYmFyLg0KPj4+IA0K Pj4+IEdpdmVuIHRoZSBjdXJyZW50IHVzZSBiZWxvdywgSSB3b3VsZCByZW5hbWUgdGhlIHN0cnVj dHVyZSB0byBzb21ldGhpbmcgbW9yZSBzcGVjaWZpYyBsaWtlOiBwZGV2X2Jhcl9jaGVjay4NCj4+ IEFjay4NCj4+PiANCj4+Pj4gK3N0cnVjdCBwZGV2X2Jhcg0KPj4+PiArew0KPj4+PiArICAgIG1m bl90IHN0YXJ0Ow0KPj4+PiArICAgIG1mbl90IGVuZDsNCj4+Pj4gKyAgICBib29sIGlzX3ZhbGlk Ow0KPj4+PiArfTsNCj4+Pj4gKw0KPj4+PiAgLyoNCj4+Pj4gICAqIExpc3QgZm9yIGFsbCB0aGUg cGNpIGhvc3QgYnJpZGdlcy4NCj4+Pj4gICAqLw0KPj4+PiBAQCAtMzYzLDYgKzM3MywzOSBAQCBp bnQgX19pbml0IHBjaV9ob3N0X2JyaWRnZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkKQ0KPj4+ PiAgICAgIHJldHVybiAwOw0KPj4+PiAgfQ0KPj4+PiAgK3N0YXRpYyBpbnQgaXNfYmFyX3ZhbGlk KGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4+PiArICAgICAgICAgICAgICAg ICAgICAgICAgdWludDY0X3QgYWRkciwgdWludDY0X3QgbGVuLCB2b2lkICpkYXRhKQ0KPj4+PiAr ew0KPj4+PiArICAgIHN0cnVjdCBwZGV2X2JhciAqYmFyX2RhdGEgPSBkYXRhOw0KPj4+PiArICAg IHVuc2lnbmVkIGxvbmcgcyA9IG1mbl94KGJhcl9kYXRhLT5zdGFydCk7DQo+Pj4+ICsgICAgdW5z aWduZWQgbG9uZyBlID0gbWZuX3goYmFyX2RhdGEtPmVuZCk7DQo+Pj4+ICsNCj4+Pj4gKyAgICBp ZiAoIChzIDw9IGUpICYmIChzID49IFBGTl9ET1dOKGFkZHIpKSAmJiAoZSA8PSBQRk5fVVAoYWRk ciArIGxlbiAtIDEpKSApDQo+Pj4gDQo+Pj4gQUZBSUNUICdzJyAgYW5kICdlJyBhcmUgcHJvdmlk ZWQgYnkgcGNpX2NoZWNrX2JhcigpIGFuZCB3aWxsIG5ldmVyIGNoYW5nZS4gU28gY2FuIHdlIG1v dmUgdGhlIGNoZWNrICdzIDw9IGUnIG91dHNpZGUgb2YgdGhlIGNhbGxiYWNrPw0KPj4gWWVzLCBX ZSBjYW4gbW92ZSB0aGUgY2hlY2sgb3V0c2lkZSB0aGUgY2FsbGJhY2sgYnV0IEkgZmVlbCB0aGF0 IGlmIHdlIGNoZWNrIGhlcmUgdGhlbiBpdCBpcyBtb3JlDQo+PiByZWFkYWJsZSB0aGF0IHdlIGFy ZSBjaGVja2luZyBmb3IgYWxsIHBvc3NpYmxlIHZhbHVlcyBpbiBvbmUgc3RhdGVtZW50LiBMZXQg bWUga25vdyB5b3VyIHZpZXcgb24gdGhpcy4NCj4gVGhlIHJlYWRhYmlsaXR5IGlzIHJlYWxseSBh IG1hdHRlciBvZiB0YXN0ZSBoZXJlLiBCdXQgbXkgcG9pbnQgaXMgbW9yZSBvbiB0aGUgbnVtYmVy IG9mIHRpbWUgYSBjaGVjayBpcyBkb25lLg0KPiANCj4gSXQgc2VlbXMgcG9pbnRsZXNzIHRvIGRv IHRoZSBzYW1lIGNoZWNrIE4gdGltZXMgd2hlbiB5b3Uga25vdyB0aGUgdmFsdWVzIGFyZSBub3Qg Z29pbmcgdG8gY2hhbmdlLiBBZG1pdHRlZGx5LCB0aGUgb3BlcmF0aW9uIGlzIGZhc3QgKHRoaXMg aXMgYSBjb21wYXJpc29uKSBhbmQgTiBzaG91bGQgYmUgc21hbGwgKD8pLg0KPiANCj4gSG93ZXZl ciwgSSB0aGluayBpdCByYWlzZXMgdGhlIHF1ZXN0aW9uIG9uIHdoZXJlIGRvIHlvdSBkcmF3IHRo ZSBsaW5lPw0KPiANCj4gUGVyc29uYWxseSwgSSB0aGluayBhbGwgaW52YXJpYW50IHNob3VsZCBi ZSBjaGVja2VkIG91dHNpZGUgb2YgY2FsbGJhY2tzLiBTbyB0aGUgbGluZSBpcyB2ZXJ5IGNsZWFy Lg0KPiANCiANCkkgd2lsbCBtb3ZlIHRoZSBjaGVjayBmb3IgInMgPD1l4oCdIG91dHNpZGUgdGhl IGNhbGxiYWNrIGFuZCB3aWxsIHNlbmQgaXQgZm9yIHJldmlldy4NCg0KUmVnYXJkcywNClJhaHVs From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:26:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:26:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400928.642562 (Exim 4.92) (envelope-from ) id 1oVqNv-0000ZK-QQ; Wed, 07 Sep 2022 08:26:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400928.642562; Wed, 07 Sep 2022 08:26:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqNv-0000ZD-N6; Wed, 07 Sep 2022 08:26:11 +0000 Received: by outflank-mailman (input) for mailman id 400928; Wed, 07 Sep 2022 08:26:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqNu-0000Z5-9y for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:26:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqNs-0000UA-2m; Wed, 07 Sep 2022 08:26:08 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVqNr-0005E4-Sl; Wed, 07 Sep 2022 08:26:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=Xz4v1F92Bq9wTRs1yYIiEnrnwkV/Cp9iyBNrBggrlUc=; b=wWA8cTM0kqI6Pd2AdbA3dwcz3r DdmYqR7oGdYdl6TuyPR71NYMvrc70XYUL9sM2wYx+gynjKsUTTzcbuLczTzbLlDwFvZT3eQ0Fk/HU 60pLfKM/kX34cG8GYxzMEEeW74GDON1YT7D5vxvxaLqf62Ryj/0PRjLgkdQy4C45y0e8=; Message-ID: Date: Wed, 7 Sep 2022 09:26:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Content-Language: en-US To: Leo Yan , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220906113112.106995-1-leo.yan@linaro.org> From: Julien Grall In-Reply-To: <20220906113112.106995-1-leo.yan@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Leo, On 06/09/2022 12:31, Leo Yan wrote: > On Arm64 Linux kernel prints log for Xen version number: > > [ 0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found > > Because the header file "xen/compile.h" is missed, XEN_VERSION and > XEN_SUBVERSION are not defined, thus compiler directly uses the > string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string. > > This patch includes the header "xen/compile.h" which defines macros for > XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via > hypervisor node. > > Signed-off-by: Leo Yan AFAICT, the problem was introduced when we split the ACPI code from arch/domain_build.c. So I would add the following tag: Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") Now, this means we shipped Xen for ~4 years with the wrong compatible. The compatible is meant to indicate the Xen version. However, I don't think this is used for anything other than printing the version on the console. Also, the problem occurs only when using ACPI. This is still in tech preview, so I think we don't need to document the issue in the documentation (we can easily break ABI). > --- > xen/arch/arm/acpi/domain_build.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c > index bbdc90f92c..2649e11fd4 100644 > --- a/xen/arch/arm/acpi/domain_build.c > +++ b/xen/arch/arm/acpi/domain_build.c > @@ -9,6 +9,7 @@ > * GNU General Public License for more details. > */ > > +#include So this is fixing the immediate problem. Given the subtlety of the bug, I think it would be good to also harden the code at the same time. I can see two way to do that: 1) Dropping the use of __stringify 2) Check if XEN_VERSION and XEN_SUBVERSION are defined The latter is probably lightweight. This could be added right next to acpi_make_hypervisor_node() for clarify. Something like: #ifndef XEN_VERSION # error "XEN_VERSION is not defined" #endif #ifndef XEN_SUBVERSION # error "XEN_SUBVERSION is not defined" #endif Could you have a look? > #include > #include > #include Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:30:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400936.642574 (Exim 4.92) (envelope-from ) id 1oVqSK-000238-Bs; Wed, 07 Sep 2022 08:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400936.642574; Wed, 07 Sep 2022 08:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqSK-000231-8Q; Wed, 07 Sep 2022 08:30:44 +0000 Received: by outflank-mailman (input) for mailman id 400936; Wed, 07 Sep 2022 08:30:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqSJ-00022v-03 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:30:43 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20060.outbound.protection.outlook.com [40.107.2.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5bf340e5-2e87-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 10:30:42 +0200 (CEST) Received: from AS8PR05CA0012.eurprd05.prod.outlook.com (2603:10a6:20b:311::17) by PAXPR08MB7367.eurprd08.prod.outlook.com (2603:10a6:102:229::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 08:30:35 +0000 Received: from AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::7c) by AS8PR05CA0012.outlook.office365.com (2603:10a6:20b:311::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 08:30:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT050.mail.protection.outlook.com (100.127.141.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 08:30:35 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Wed, 07 Sep 2022 08:30:35 +0000 Received: from f1124cd3026c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA4FC308-3C8E-4F9A-9E14-8E6BEA09C9DC.1; Wed, 07 Sep 2022 08:30:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f1124cd3026c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 08:30:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 08:30:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bf340e5-2e87-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OplswqilE8h2zyC8B7WTwpLFrtTRbMPEtqQrFf82xBKybvqNad90iYr7+R//v3FS5VAGWFbs+CV8o5xUW1aBKanaxug5nkz+nMAUp07BjKPUyDYVZTgz8dQL9w+Vh7CYXqx/vgUvzkyfAFUjJoAoCJIGEtA0f7rlRJ1OwsEPJd7p2Zl1fgTDHfVLp1ixzrKHLwHBAdsNLLGEykPC7n510v49ufBL1Ydw64bzfv1lfp2yaWhLPyZtTVrYjcX0LPR+aePRzeGKj0x4quMOoperHKkggiWN/JeBz7Gp0uEl1BTsGO2ahOyVYq2UY8dvDcGvNMAcMQshY3QRJf2BOlfOsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YLaeFlk/kicynYXZyl3aqVFLxJM3MTSAbQJJsjYoN5U=; b=IFdvpX2qrIgWMwTPHfeg8h21p8li/8BTyDPh8UGj5ycNiNgxe7aZ+y03f9UtBjlj4IV3L/8yGiQZ+6rHGk0tGOXfLcVJFz7H6xJyeB6X+jwGLpDVz1M+8KEq0ohI9S1UGQGXGsq1wNDOarXJBvaePw0i07JKFiINFZJOpXFinrMfLvqKaHe6OrlaEGEtwrLQ8Vnaq1l2MBpEisSl14oApA053ZG5wOdFLQfuUIXKM4gfo+Ex9JQ/0MiDQkN0gxUTzJN0m2aNrtKvWWjxLWzPXcOKTAT/JbGGaTxFO8D/Qfe79ajRivsksWf9vqbcqc7GnSF9/Zt1cLuVeAV4psCfpA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLaeFlk/kicynYXZyl3aqVFLxJM3MTSAbQJJsjYoN5U=; b=Ehb21sO2krP4e8kLhSvE6i73FK2jOjKl5OVudVwdHfme1GvXI+5RKHJGqitaatMBN0kUrg9HaOTHmoWZ4KtvAEjiz1x75luowj4pMAV7q9DYUZ3qmL/WfxlMLik7xjnFdS16C3jfegj+vVOl9h0v4kIYy/Rl0uG5cReV9FIkkPU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0810f347a890ac39 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bp7FDeWMYf6LupGyVBRa2KxGWDHlnb0jgAGVahA34kX27Fho23ZYMfTBx/PyqB6GoO3XBXMzeHiwoAclAr6hK76UzGYX8b9gy3iZZGzKm9ufVahbR5vvslQHRZURoeP2k8/iViRa20cVJZKBFG91ffMFTvM9x00MmVUZ2TeOWBWabT0+8A0DP6c7H7ioX6oDq5RLX6huv05TCgY3kQGtyzFvG1K2ddRvhM8KdE/IjtSz0gBmWBVr2yqztc9fhGTdtP0o4M+AX8SUb4MSxHoh8Evsf9tTgQ5Sdq8CoER/QsNEP05TihYbwSK+dSHSu9pAa5935RuWp1yjM5xTlYHR8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YLaeFlk/kicynYXZyl3aqVFLxJM3MTSAbQJJsjYoN5U=; b=aXj/++6cPWSVyTUwvknPBJww0SRYHs6CaxqaWX/AfroFdfOc5C6JdNJR6GDpBipE2XD/DLPchvA7LFhJ5s8HhWp0k9KKNBU5EcuY25b9eroCzH98py0gSOAOIrI1DB6rRBxahaLv+eqhGz2tt2KpGAsT4KV2vepScv+rA9HtwfTzAULuGIkEbemot7gZMaCKkalIRYEC1vqyXw0HWAD9PHl6uxfF+bYGtwFF1fR6+Lm8dcUZMTX2yRUk9kkTntAxWwOy0TCk/7qFlN/DtMBAoBLnjdyssfty4ll0M1tPouz8QQfqeK4a7AMsmqjdfWRdVwhPiZ6eyVklZ5yBxbBIDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLaeFlk/kicynYXZyl3aqVFLxJM3MTSAbQJJsjYoN5U=; b=Ehb21sO2krP4e8kLhSvE6i73FK2jOjKl5OVudVwdHfme1GvXI+5RKHJGqitaatMBN0kUrg9HaOTHmoWZ4KtvAEjiz1x75luowj4pMAV7q9DYUZ3qmL/WfxlMLik7xjnFdS16C3jfegj+vVOl9h0v4kIYy/Rl0uG5cReV9FIkkPU= From: Bertrand Marquis To: Julien Grall CC: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Thread-Topic: [PATCH] xen/arm: acpi: Include header file for version number Thread-Index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgA= Date: Wed, 7 Sep 2022 08:30:27 +0000 Message-ID: References: <20220906113112.106995-1-leo.yan@linaro.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4100d5ed-791a-4228-8d1d-08da90ab3c90 x-ms-traffictypediagnostic: AM7PR08MB5366:EE_|AM7EUR03FT050:EE_|PAXPR08MB7367:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hKvQWjrtTbXvtz4w4Osbq+GtuFvKuwzyiJuKMtjgZhGhIVrjQEGv1a/CriS0lfNb6GZ06R5doHhqhTik+prii2cTBYUhOQAivKP2Nq88YLdbki5ijJkXadl5f6VW6qEBlhdzzgCxZckXiZ7hV9rlKSVsW+TP6mdl3OZ80Fgh7N9bW9HvykAVjOnh5j55Vd2Knj1/UmUpN9isycWmr57LYwUPfkYGI5SSWRMInaDNP2fzbYpEy/YDejCPviSNB3lZB4dG8DUaTCi2DaOcSsbyMIOViUUcTPhMoBMPoZh8vWKi+RJCQktOsnNhyiq8Oyey5Lzp/51EidLkQZCfOjfILYeWKbvt32WqAYUlAfeNlMP9s7dufNBuu2LnVHm1T+FytfVmVtp3Nq5TDTCCcHQnt0Wl8csHbmHW3B32P/mtM4oNvtUbHuFKZPYRY+f1GqJtoNQ5Mn/TJiEZrrfw6cIcw+vcLr2iK5orBsxNs16CoXpY3BvZEmOKYFVt2biMNMYeO6ZBUpbqzFwHI0oOdxOGFNLXGs+YYmqnLpynl8WEX0lmgo9fsIkjxx4iCcRaHGfDYI0Rb8bnGwqpmUc+RqalU9R//IvYOV+SamAVunXSDPUcaBQGMv3n5JSfb2g5Bqw6ltVKHp/G8siKkpJ3RqBEGxZjXFFt+A8wsK6nlnqGmSWhJ1YNqeQTjLDxJY1H+1Z8Aw9+CjK+2m7G68+Kj0Uj0s63j3Jd6QiuBuM5t4jWy7v0OIZk3Dx4tRsIcAS4ntVW2c+YWBjo1gvmfG22rmM5esu6xoZw+29+hxbFo/5SSio= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(86362001)(91956017)(76116006)(66946007)(66446008)(66476007)(66556008)(4326008)(8676002)(64756008)(38070700005)(6916009)(54906003)(316002)(6506007)(53546011)(83380400001)(26005)(186003)(2616005)(41300700001)(71200400001)(6486002)(122000001)(6512007)(478600001)(38100700002)(5660300002)(2906002)(36756003)(8936002)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5A8A137514AFC549A776848BBCC3D70D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eedc3d8c-369b-487b-08fe-08da90ab377b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FdVTnWI7yQVWPyuxGj3soZdSja6+9ikCBWVCTSyxWdBU4Shmpdi4MOok2SYFtXBt7qjz+hm+uKzhSHHuEcFwUfC4+DwgVn0VzoOtpEHfmkMVO1e3rswcEIEcLvM/DSOiaiqxHfuJ8371E7UEnxcWuXPBPSUU6YVthjFX7K5EQVMW7PM5WLDFm559K4AOeh9ahklnxbTzgsZ/uBE+ikAGq/U8XJ3p9j7AMrs6vPyBbZXozLovRbNI4aFstmRJ6Zi57YvhnAxiA9sEIQuAkdM9mqB4/FZTy3m2oQ0RSHUFRDocoJNf681s2TDnrhU3gzTV1PP55YB/mfaS740g+QfVkkvPwHy8MXwPEbhHmVMWeM4bwE7eGBnFGB3LS8mEnar9yA6CeaSClqtnzugrSta47mt2Iw2Z8g+P9mMtjdAsypg1fwZB4yGaIEQIfHlgHvxcoeaXb/aA3dpybIIZMKtwoSkLhP7FrS0akOy684r481QHHsE4NUzeaiunKu1qb5cLp3Z4CFG64lXDERjdgDNoQ436hZeOqWHVy47QHKs0fPnMPo/CBPy3yq58VOngYiUmKTbQr1pAft0l6sQhDEVUPbEMi1VHsgsn5egDwqTmd6vxbv6IR0fBZZAAowIYrtfEm4QwtqzXHF4JBnIVzwMHnxeyxCiqzv/MXbMI4c/5GLwslgJR+T9sXh3AbCUSxGkJzJqMTR7lTpEMpGpPc+NHCwOIr9owOYOxQgk8Eh2z07WDYqEv5jcGEaAwp3e4S9F0R8QOoUHU523LBLv/UPLiWg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(46966006)(36840700001)(40470700004)(336012)(83380400001)(70206006)(186003)(40480700001)(4326008)(478600001)(2616005)(47076005)(70586007)(8676002)(82310400005)(6512007)(6506007)(41300700001)(33656002)(36756003)(53546011)(26005)(6486002)(40460700003)(81166007)(356005)(54906003)(86362001)(5660300002)(2906002)(36860700001)(6862004)(8936002)(82740400003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 08:30:35.5635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4100d5ed-791a-4228-8d1d-08da90ab3c90 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7367 Hi Julien, > On 7 Sep 2022, at 09:26, Julien Grall wrote: >=20 > Hi Leo, >=20 > On 06/09/2022 12:31, Leo Yan wrote: >> On Arm64 Linux kernel prints log for Xen version number: >> [ 0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found >> Because the header file "xen/compile.h" is missed, XEN_VERSION and >> XEN_SUBVERSION are not defined, thus compiler directly uses the >> string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string. >> This patch includes the header "xen/compile.h" which defines macros for >> XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via >> hypervisor node. >> Signed-off-by: Leo Yan >=20 > AFAICT, the problem was introduced when we split the ACPI code from arch/= domain_build.c. So I would add the following tag: >=20 > Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") >=20 > Now, this means we shipped Xen for ~4 years with the wrong compatible. Th= e compatible is meant to indicate the Xen version. However, I don't think t= his is used for anything other than printing the version on the console. >=20 > Also, the problem occurs only when using ACPI. This is still in tech prev= iew, so I think we don't need to document the issue in the documentation (w= e can easily break ABI). >=20 >> --- >> xen/arch/arm/acpi/domain_build.c | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain= _build.c >> index bbdc90f92c..2649e11fd4 100644 >> --- a/xen/arch/arm/acpi/domain_build.c >> +++ b/xen/arch/arm/acpi/domain_build.c >> @@ -9,6 +9,7 @@ >> * GNU General Public License for more details. >> */ >> +#include >=20 > So this is fixing the immediate problem. Given the subtlety of the bug, I= think it would be good to also harden the code at the same time. I think we should commit the patch as is and harden the code in a subsequen= t patch. >=20 > I can see two way to do that: > 1) Dropping the use of __stringify > 2) Check if XEN_VERSION and XEN_SUBVERSION are defined >=20 > The latter is probably lightweight. This could be added right next to acp= i_make_hypervisor_node() for clarify. >=20 > Something like: >=20 > #ifndef XEN_VERSION > # error "XEN_VERSION is not defined" > #endif >=20 > #ifndef XEN_SUBVERSION > # error "XEN_SUBVERSION is not defined" > #endif >=20 > Could you have a look? There are actually several places in the code where we use the stringify sy= stem. Would it make sense to actually have a string version provided in compile.h= and use it instead ? Otherwise if we start adding those kinds of checks, we will have to add the= m in at least 3 places in xen code. Cheers Bertrand >=20 >> #include >> #include >> #include >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:37:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:37:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400943.642585 (Exim 4.92) (envelope-from ) id 1oVqYO-0002lS-12; Wed, 07 Sep 2022 08:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400943.642585; Wed, 07 Sep 2022 08:36:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYN-0002lL-UO; Wed, 07 Sep 2022 08:36:59 +0000 Received: by outflank-mailman (input) for mailman id 400943; Wed, 07 Sep 2022 08:36:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYM-0002lD-CO for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:36:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 3b39cd98-2e88-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 10:36:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09E2DD6E; Wed, 7 Sep 2022 01:37:02 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B9FDA3F534; Wed, 7 Sep 2022 01:37:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b39cd98-2e88-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v3 0/4] Introduce static heap Date: Wed, 7 Sep 2022 08:36:39 +0000 Message-Id: <20220907083643.20152-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU systems, where only a finite number of memory protection regions are available. The limited number of protection regions places requirement on planning the use of MPU protection regions and one or more MPU protection regions needs to be reserved only for heap. The first patch enhances the error handling in processing the dts chosen node. The second patch introduces the static heap and the device tree parsing code. The third patch renames xenheap_* to directmap_* for better readablity. The fourth patch adds the implementation of the static heap pages handling in boot and heap allocator for Arm. Changes from v2 to v3: - Adjust the order of patches. - Define `enum membank_type` properly, drop the typedef. - Rename the feature terminology to static heap. - Rename MEMBANK_MEMORY to MEMBANK_DEFAULT and MEMBANK_XEN_DOMAIN to MEMBANK_STATIC_DOMAIN. Add comments to `enum membank_type`. - Correct typo, add the clarification of the static heap region should contain enough memory below 4GB to cater 32-bit DMA for Arm32, and add the 64KB alignment requirement in doc. - Add Stefano's Acked-by for device tree interface. - Adjustment of the terminology change to "static heap". - Change of wording in comments. - int i -> unsigned int i. - Avoid extra indentation by reverting the check of MEMBANK_RSVD_HEAP. - Use MB(32). - Drop unnecessary panic and unused variables. - Avoid the ternary operation in assigning the heap_pages. - Rework populate_boot_allocator() for static heap. Henry Wang (4): xen/arm: bootfdt: Make process_chosen_node() return int docs, xen/arm: Introduce static heap memory xen/arm: mm: Rename xenheap_* variable to directmap_* xen/arm: Handle static heap pages in boot and heap allocator docs/misc/arm/device-tree/booting.txt | 48 +++++++++ xen/arch/arm/bootfdt.c | 55 +++++++--- xen/arch/arm/domain_build.c | 8 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 22 ++-- xen/arch/arm/include/asm/setup.h | 23 +++- xen/arch/arm/mm.c | 24 ++--- xen/arch/arm/setup.c | 147 +++++++++++++++++++++----- 8 files changed, 260 insertions(+), 69 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:37:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400944.642596 (Exim 4.92) (envelope-from ) id 1oVqYU-00033C-8W; Wed, 07 Sep 2022 08:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400944.642596; Wed, 07 Sep 2022 08:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYU-000335-5V; Wed, 07 Sep 2022 08:37:06 +0000 Received: by outflank-mailman (input) for mailman id 400944; Wed, 07 Sep 2022 08:37:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYT-00032F-2t for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:37:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 3efb0b7d-2e88-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 10:37:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A609D6E; Wed, 7 Sep 2022 01:37:08 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 254CF3F534; Wed, 7 Sep 2022 01:37:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3efb0b7d-2e88-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int Date: Wed, 7 Sep 2022 08:36:40 +0000 Message-Id: <20220907083643.20152-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907083643.20152-1-Henry.Wang@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error type. Signed-off-by: Henry Wang --- Changes from v2 to v3: - Adjust the order of this patch, make it the #1. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..1a79b969af 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -293,9 +293,9 @@ static void __init process_multiboot_node(const void *fdt, int node, kind, start, domU); } -static void __init process_chosen_node(const void *fdt, int node, - const char *name, - u32 address_cells, u32 size_cells) +static int __init process_chosen_node(const void *fdt, int node, + const char *name, + u32 address_cells, u32 size_cells) { const struct fdt_property *prop; paddr_t start, end; @@ -306,11 +306,11 @@ static void __init process_chosen_node(const void *fdt, int node, prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); if ( !prop ) /* No initrd present. */ - return; + return 0; if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-start property has invalid length %d\n", len); - return; + return -EINVAL; } start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -318,12 +318,12 @@ static void __init process_chosen_node(const void *fdt, int node, if ( !prop ) { printk("linux,initrd-end not present but -start was\n"); - return; + return -EINVAL; } if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-end property has invalid length %d\n", len); - return; + return -EINVAL; } end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -331,12 +331,14 @@ static void __init process_chosen_node(const void *fdt, int node, { printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n", start, end); - return; + return -EINVAL; } printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end); add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); + + return 0; } static int __init process_domain_node(const void *fdt, int node, @@ -383,7 +385,7 @@ static int __init early_scan_node(const void *fdt, device_tree_node_compatible(fdt, node, "multiboot,module" ))) process_multiboot_node(fdt, node, name, address_cells, size_cells); else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) - process_chosen_node(fdt, node, name, address_cells, size_cells); + rc = process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:37:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400945.642607 (Exim 4.92) (envelope-from ) id 1oVqYW-0003LA-OM; Wed, 07 Sep 2022 08:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400945.642607; Wed, 07 Sep 2022 08:37:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYW-0003L0-KV; Wed, 07 Sep 2022 08:37:08 +0000 Received: by outflank-mailman (input) for mailman id 400945; Wed, 07 Sep 2022 08:37:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYV-0003GF-46 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:37:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYS-0000gH-Ar; Wed, 07 Sep 2022 08:37:04 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVqYS-0005l8-34; Wed, 07 Sep 2022 08:37:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=k9B4coASMmrd0YSag7YYJthd88IeeWe+L/qb7wXUl/8=; b=4m1vNC5JdgBxTtJZBThuKAasiv CdOPOXI2L+ml40itvm0eWr1znNPQI2Hh2abvz0UpL/cqcPxGAtDvHA0ckqqaUdHd55ECeDTFKa/1N G39fH1WSvgJUfqh4/zrVmXlnTLSLr4+USGHOyGyq1pw/Xj38zY3nrgoZc+L3Hy8sghL4=; Message-ID: <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> Date: Wed, 7 Sep 2022 09:37:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Content-Language: en-US To: Bertrand Marquis Cc: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220906113112.106995-1-leo.yan@linaro.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 09:30, Bertrand Marquis wrote: >> On 7 Sep 2022, at 09:26, Julien Grall wrote: >> >> Hi Leo, >> >> On 06/09/2022 12:31, Leo Yan wrote: >>> On Arm64 Linux kernel prints log for Xen version number: >>> [ 0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found >>> Because the header file "xen/compile.h" is missed, XEN_VERSION and >>> XEN_SUBVERSION are not defined, thus compiler directly uses the >>> string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string. >>> This patch includes the header "xen/compile.h" which defines macros for >>> XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via >>> hypervisor node. >>> Signed-off-by: Leo Yan >> >> AFAICT, the problem was introduced when we split the ACPI code from arch/domain_build.c. So I would add the following tag: >> >> Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") >> >> Now, this means we shipped Xen for ~4 years with the wrong compatible. The compatible is meant to indicate the Xen version. However, I don't think this is used for anything other than printing the version on the console. >> >> Also, the problem occurs only when using ACPI. This is still in tech preview, so I think we don't need to document the issue in the documentation (we can easily break ABI). >> >>> --- >>> xen/arch/arm/acpi/domain_build.c | 1 + >>> 1 file changed, 1 insertion(+) >>> diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c >>> index bbdc90f92c..2649e11fd4 100644 >>> --- a/xen/arch/arm/acpi/domain_build.c >>> +++ b/xen/arch/arm/acpi/domain_build.c >>> @@ -9,6 +9,7 @@ >>> * GNU General Public License for more details. >>> */ >>> +#include >> >> So this is fixing the immediate problem. Given the subtlety of the bug, I think it would be good to also harden the code at the same time. > > I think we should commit the patch as is and harden the code in a subsequent patch. I thought about this. However, if we do the hardening in the same patch, then it makes a lot easier to confirm that the patch works when ingested in downstream code or backported. > >> >> I can see two way to do that: >> 1) Dropping the use of __stringify >> 2) Check if XEN_VERSION and XEN_SUBVERSION are defined >> >> The latter is probably lightweight. This could be added right next to acpi_make_hypervisor_node() for clarify. >> >> Something like: >> >> #ifndef XEN_VERSION >> # error "XEN_VERSION is not defined" >> #endif >> >> #ifndef XEN_SUBVERSION >> # error "XEN_SUBVERSION is not defined" >> #endif >> >> Could you have a look? > > There are actually several places in the code where we use the stringify system. > Would it make sense to actually have a string version provided in compile.h and use it instead ? I think so. > > Otherwise if we start adding those kinds of checks, we will have to add them in at least 3 places in xen code. The solution I proposed above is easy to implement right now. My gut feeling is tweaking __stringify (or else) will take a bit more time. If you (or Leo) can come up with a solution quickly then fine. Otherwise, I think we still want some hardening for backporting purpose. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:37:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:37:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400946.642611 (Exim 4.92) (envelope-from ) id 1oVqYX-0003PD-4E; Wed, 07 Sep 2022 08:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400946.642611; Wed, 07 Sep 2022 08:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYW-0003O5-UR; Wed, 07 Sep 2022 08:37:08 +0000 Received: by outflank-mailman (input) for mailman id 400946; Wed, 07 Sep 2022 08:37:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYW-0002lD-13 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:37:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 41612f23-2e88-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 10:37:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75360D6E; Wed, 7 Sep 2022 01:37:12 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E996A3F534; Wed, 7 Sep 2022 01:37:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41612f23-2e88-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Date: Wed, 7 Sep 2022 08:36:41 +0000 Message-Id: <20220907083643.20152-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907083643.20152-1-Henry.Wang@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_tree_get_meminfo(). Changes of code are done accordingly following the introduction of this enum. Also, this commit introduces the logic to parse the static heap configuration in device tree. If the memory bank is reserved as heap through `xen,static-heap` property in device tree `chosen` node, the memory will be marked as static heap type. A documentation section is added, describing the definition of static heap memory and the method of enabling the static heap memory through device tree at boot time. Signed-off-by: Henry Wang Signed-off-by: Penny Zheng Acked-by: Stefano Stabellini # DT interface --- Changes from v2 to v3: - Define `enum membank_type` properly, drop the typedef. - Rename the feature terminology to static heap. - Rename MEMBANK_MEMORY to MEMBANK_DEFAULT and MEMBANK_XEN_DOMAIN to MEMBANK_STATIC_DOMAIN. Add comments to `enum membank_type`. - Correct typo, add the clarification of the static heap region should contain enough memory below 4GB to cater 32-bit DMA for Arm32, and add the 64KB alignment requirement in doc. - Add Stefano's Acked-by for device tree interface. Changes from v1 to v2: - Rename the device tree property to xen,static-heap to avoid confusion. - Change of commit msg and doc wording, correct typo in commit msg. - Do not change the process_chosen_node() return type. - Add an empty line in make_memory_node() memory type check to improve readability. - Use enum membank_type to make the memory type cleaner. Changes from RFC to v1: - Rename the terminology to reserved heap. --- docs/misc/arm/device-tree/booting.txt | 48 +++++++++++++++++++++++++++ xen/arch/arm/bootfdt.c | 33 +++++++++++++++--- xen/arch/arm/domain_build.c | 8 +++-- xen/arch/arm/include/asm/setup.h | 22 +++++++++++- xen/arch/arm/setup.c | 2 +- 5 files changed, 104 insertions(+), 9 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..5ba7d186aa 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,51 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + + +Static Heap Memory +================== + +The static heap memory refers to parts of RAM reserved in the beginning of +boot time for heap. The memory is reserved by configuration in the device +tree using physical address ranges. + +The static heap memory declared in the device tree defines the memory areas +that will be reserved to be used exclusively as heap. + +- For Arm32, since there are separated heaps, the static heap will be used +for both domheap and xenheap. The admin should make sure that the static +heap region should contain enough memory below 4GB to cater 32-bit DMA. + +- For Arm64, since there is a single heap, the defined static heap areas +shall always go to the heap allocator. + +The static heap memory is an optional feature and can be enabled by adding +below device tree properties in the `chosen` node. + +The dtb should have the following properties: + +- xen,static-heap + + Property under the top-level "chosen" node. It specifies the address + and size of Xen static heap memory. Note that at least a 64KB + alignment is required. + +- #xen,static-heap-address-cells and #xen,static-heap-size-cells + + Specify the number of cells used for the address and size of the + "xen,static-heap" property under "chosen". + +Below is an example on how to specify the static heap in device tree: + + / { + chosen { + #xen,static-heap-address-cells = <0x2>; + #xen,static-heap-size-cells = <0x2>; + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; + ... + }; + }; + +RAM starting from the host physical address 0x30000000 of 1GB size will +be reserved as static heap. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 1a79b969af..cb23fad571 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, - void *data, bool xen_domain) + void *data, enum membank_type type) { const struct fdt_property *prop; unsigned int i, banks; @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, continue; mem->bank[mem->nr_banks].start = start; mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].xen_domain = xen_domain; + mem->bank[mem->nr_banks].type = type; mem->nr_banks++; } @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, void *data) { return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, - data, false); + data, MEMBANK_DEFAULT); } static int __init process_reserved_memory_node(const void *fdt, int node, @@ -301,6 +301,30 @@ static int __init process_chosen_node(const void *fdt, int node, paddr_t start, end; int len; + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) + { + int rc; + u32 address_cells = device_tree_get_u32(fdt, node, + "#xen,static-heap-address-cells", 0); + u32 size_cells = device_tree_get_u32(fdt, node, + "#xen,static-heap-size-cells", 0); + + printk("Checking for static heap in /chosen\n"); + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: node `%s': invalid #xen,static-heap-address-cells or #xen,static-heap-size-cells\n", + name); + return -EINVAL; + } + + rc = device_tree_get_meminfo(fdt, node, "xen,static-heap", + address_cells, size_cells, + &bootinfo.reserved_mem, + MEMBANK_STATIC_HEAP); + if ( rc ) + return rc; + } + printk("Checking for initrd in /chosen\n"); prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); @@ -360,7 +384,8 @@ static int __init process_domain_node(const void *fdt, int node, "#xen,static-mem-size-cells", 0); return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, - size_cells, &bootinfo.reserved_mem, true); + size_cells, &bootinfo.reserved_mem, + MEMBANK_STATIC_DOMAIN); } static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..0741645014 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, if ( mem->nr_banks == 0 ) return -ENOENT; - /* find first memory range not bound to a Xen domain */ - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) + /* find first memory range not bound to a Xen domain nor heap */ + for ( i = 0; i < mem->nr_banks && + (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) ; + if ( i == mem->nr_banks ) return 0; @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, u64 start = mem->bank[i].start; u64 size = mem->bank[i].size; - if ( mem->bank[i].xen_domain ) + if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) continue; dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..6bea15acff 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -22,11 +22,31 @@ typedef enum { BOOTMOD_UNKNOWN } bootmodule_kind; +enum membank_type { + /* + * The MEMBANK_DEFAULT type refers to either reserved memory for the + * device (or firmware) or any memory that will be used by the allocator. + * The meaning depends on where the memory bank is actually used. + */ + MEMBANK_DEFAULT, + /* + * The MEMBANK_STATIC_DOMAIN type is used to indicate whether the memory + * bank is bound to a static Xen domain. It is only valid when the bank + * is in reserved_mem. + */ + MEMBANK_STATIC_DOMAIN, + /* + * The MEMBANK_STATIC_HEAP type is used to indicate whether the memory + * bank is reserved as static heap. It is only valid when the bank is + * in reserved_mem. + */ + MEMBANK_STATIC_HEAP, +}; struct membank { paddr_t start; paddr_t size; - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ + enum membank_type type; }; struct meminfo { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 7814fe323d..3c36c050bf 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) { - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) { mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:37:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:37:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400947.642629 (Exim 4.92) (envelope-from ) id 1oVqYb-0003yX-CM; Wed, 07 Sep 2022 08:37:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400947.642629; Wed, 07 Sep 2022 08:37:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYb-0003yM-8p; Wed, 07 Sep 2022 08:37:13 +0000 Received: by outflank-mailman (input) for mailman id 400947; Wed, 07 Sep 2022 08:37:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYZ-0002lD-O9 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:37:11 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 43a27fa8-2e88-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 10:37:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24808106F; Wed, 7 Sep 2022 01:37:16 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D6E3A3F534; Wed, 7 Sep 2022 01:37:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43a27fa8-2e88-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Date: Wed, 7 Sep 2022 08:36:42 +0000 Message-Id: <20220907083643.20152-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907083643.20152-1-Henry.Wang@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> With the static heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily. On Arm32, only the xenheap is direct mapped today. So the renaming to "directmap_*" would be still valid for Arm32. No functional change is intended. Signed-off-by: Henry Wang --- Changes from v2 to v3: - Adjust the order of this patch, make it #3. Changes from v1 to v2: - New commit. --- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 22 +++++++++++----------- xen/arch/arm/mm.c | 24 ++++++++++++------------ xen/arch/arm/setup.c | 27 ++++++++++++++------------- 4 files changed, 38 insertions(+), 37 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 2fafb9f228..0fefed1b8a 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -160,7 +160,7 @@ #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) #define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) -#define XENHEAP_VIRT_START xenheap_virt_start +#define XENHEAP_VIRT_START directmap_virt_start #define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 749fbefa0c..7b4f6ce233 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -154,19 +154,19 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t xenheap_mfn_start, xenheap_mfn_end; -extern vaddr_t xenheap_virt_end; +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -extern vaddr_t xenheap_virt_start; -extern unsigned long xenheap_base_pdx; +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; #endif #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ unsigned long mfn_ = mfn_x(mfn); \ - (mfn_ >= mfn_x(xenheap_mfn_start) && \ - mfn_ < mfn_x(xenheap_mfn_end)); \ + (mfn_ >= mfn_x(directmap_mfn_start) && \ + mfn_ < mfn_x(directmap_mfn_end)); \ }) #else #define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) @@ -267,16 +267,16 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) static inline void *maddr_to_virt(paddr_t ma) { ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); - ma -= mfn_to_maddr(xenheap_mfn_start); + ma -= mfn_to_maddr(directmap_mfn_start); return (void *)(unsigned long) ma + XENHEAP_VIRT_START; } #else static inline void *maddr_to_virt(paddr_t ma) { - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - xenheap_base_pdx) < + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < (DIRECTMAP_SIZE >> PAGE_SHIFT)); return (void *)(XENHEAP_VIRT_START - - (xenheap_base_pdx << PAGE_SHIFT) + + (directmap_base_pdx << PAGE_SHIFT) + ((ma & ma_va_bottom_mask) | ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); } @@ -319,10 +319,10 @@ static inline struct page_info *virt_to_page(const void *v) unsigned long pdx; ASSERT(va >= XENHEAP_VIRT_START); - ASSERT(va < xenheap_virt_end); + ASSERT(va < directmap_virt_end); pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; - pdx += mfn_to_pdx(xenheap_mfn_start); + pdx += mfn_to_pdx(directmap_mfn_start); return frame_table + pdx - frametable_base_pdx; } diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..4a70ed2986 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t xenheap_mfn_end __read_mostly; -vaddr_t xenheap_virt_end __read_mostly; +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; #ifdef CONFIG_ARM_64 -vaddr_t xenheap_virt_start __read_mostly; -unsigned long xenheap_base_pdx __read_mostly; +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; #endif unsigned long frametable_base_pdx __read_mostly; @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, panic("Unable to setup the xenheap mappings.\n"); /* Record where the xenheap is, for translation routines. */ - xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; } #else /* CONFIG_ARM_64 */ void __init setup_xenheap_mappings(unsigned long base_mfn, @@ -618,12 +618,12 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, int rc; /* First call sets the xenheap physical and virtual offset. */ - if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) ) + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) { unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - xenheap_mfn_start = _mfn(base_mfn); - xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); /* * The base address may not be aligned to the first level * size (e.g. 1GB when using 4KB pages). This would prevent @@ -633,13 +633,13 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, * Prevent that by offsetting the start of the xenheap virtual * address. */ - xenheap_virt_start = DIRECTMAP_VIRT_START + + directmap_virt_start = DIRECTMAP_VIRT_START + (base_mfn - mfn_gb) * PAGE_SIZE; } - if ( base_mfn < mfn_x(xenheap_mfn_start) ) + if ( base_mfn < mfn_x(directmap_mfn_start) ) panic("cannot add xenheap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(xenheap_mfn_start)); + base_mfn, mfn_x(directmap_mfn_start)); rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), _mfn(base_mfn), nr_mfns, diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3c36c050bf..4a8334c268 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -697,11 +697,11 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 /* Avoid the xenheap */ - if ( s < mfn_to_maddr(xenheap_mfn_end) && - mfn_to_maddr(xenheap_mfn_start) < e ) + if ( s < mfn_to_maddr(directmap_mfn_end) && + mfn_to_maddr(directmap_mfn_start) < e ) { - e = mfn_to_maddr(xenheap_mfn_start); - n = mfn_to_maddr(xenheap_mfn_end); + e = mfn_to_maddr(directmap_mfn_start); + n = mfn_to_maddr(directmap_mfn_end); } #endif @@ -793,15 +793,16 @@ static void __init setup_mm(void) * We need some memory to allocate the page-tables used for the * xenheap mappings. So populate the boot allocator first. * - * This requires us to set xenheap_mfn_{start, end} first so the Xenheap + * Note that currently xenheap is direct mapped on Arm32. + * This requires us to set directmap_mfn_{start, end} first so the Xenheap * region can be avoided. */ - xenheap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - xenheap_mfn_end = mfn_add(xenheap_mfn_start, xenheap_pages); + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); populate_boot_allocator(); - setup_xenheap_mappings(mfn_x(xenheap_mfn_start), xenheap_pages); + setup_xenheap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); @@ -816,8 +817,8 @@ static void __init setup_mm(void) smp_processor_id()); /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), - mfn_to_maddr(xenheap_mfn_end)); + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); init_staticmem_pages(); } @@ -858,9 +859,9 @@ static void __init setup_mm(void) total_pages += ram_size >> PAGE_SHIFT; - xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - xenheap_mfn_start = maddr_to_mfn(ram_start); - xenheap_mfn_end = maddr_to_mfn(ram_end); + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:37:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:37:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400950.642640 (Exim 4.92) (envelope-from ) id 1oVqYf-0004Ty-NG; Wed, 07 Sep 2022 08:37:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400950.642640; Wed, 07 Sep 2022 08:37:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYf-0004Tq-JC; Wed, 07 Sep 2022 08:37:17 +0000 Received: by outflank-mailman (input) for mailman id 400950; Wed, 07 Sep 2022 08:37:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqYd-00032F-JD for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:37:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 45e53339-2e88-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 10:37:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0300BD6E; Wed, 7 Sep 2022 01:37:20 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B608E3F534; Wed, 7 Sep 2022 01:37:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45e53339-2e88-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v3 4/4] xen/arm: Handle static heap pages in boot and heap allocator Date: Wed, 7 Sep 2022 08:36:43 +0000 Message-Id: <20220907083643.20152-5-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907083643.20152-1-Henry.Wang@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap is enabled, we use the static heap region for both domheap and xenheap allocation. Note that the xenheap on Arm32 should be always contiguous, so also add a helper fit_xenheap_in_static_heap() for Arm32 to find the required xenheap in the static heap regions. For Arm64, In `setup_mm`, if the static heap is enabled and used, we make sure that only these static heap pages are added to the boot allocator. These static heap pages in the boot allocator are added to the heap allocator at `end_boot_allocator()`. If the static heap is disabled, we stick to current page allocation strategy at boot time. Also, take the chance to correct a "double not" print in Arm32 `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. Signed-off-by: Henry Wang --- Changes from v2 to v3: - Adjustment of the terminology change to "static heap". - Change of wording in comments. - int i -> unsigned int i. - Avoid extra indentation by reverting the check of MEMBANK_RSVD_HEAP. - Use MB(32). - Drop unnecessary panic and unused variables. - Avoid the ternary operation in assigning the heap_pages. - Rework populate_boot_allocator() for static heap. Changes from v1 to v2: - Move the global bool `reserved_heap` to bootinfo. - Replace the open open-coding address ~0 by INVALID_PADDR. - Do not use reverted logic in heap_pages calculation. - Remove unused Arm32 reserved_heap_start variable. - Decouple the arm32 reserved heap too small size check with region end check. - Reuse the arm32 original xenheap finding logic with the new helper to make sure xenheap on arm32 is contiguous. Changes from RFC to v1: - Rebase on top of latest `setup_mm()` changes. - Added Arm32 logic in `setup_mm()`. --- xen/arch/arm/bootfdt.c | 2 + xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 118 +++++++++++++++++++++++++++---- 3 files changed, 107 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index cb23fad571..787c7b41be 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -323,6 +323,8 @@ static int __init process_chosen_node(const void *fdt, int node, MEMBANK_STATIC_HEAP); if ( rc ) return rc; + + bootinfo.static_heap = true; } printk("Checking for initrd in /chosen\n"); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 6bea15acff..9374b92441 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -97,6 +97,7 @@ struct bootinfo { #ifdef CONFIG_ACPI struct meminfo acpi; #endif + bool static_heap; }; struct map_range_data diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 4a8334c268..86431eb3ea 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -556,6 +556,44 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, } return e; } + +/* + * Find a contiguous region that fits in the static heap region with + * required size and alignment, and return the end address of the region + * if found otherwise 0. + */ +static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) +{ + unsigned int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Allocate the xenheap as high as possible to keep low-memory + * available (assuming the admin supplied region below 4GB) + * for other use (e.g. domain memory allocation). + */ + end = max(end, aligned_end); + } + + return end; +} #endif /* @@ -661,22 +699,51 @@ static void __init init_staticmem_pages(void) } /* - * Populate the boot allocator. All the RAM but the following regions - * will be added: + * Populate the boot allocator. + * If a static heap was not provided by the admin, all the RAM but the + * following regions will be added: * - Modules (e.g., Xen, Kernel) * - Reserved regions * - Xenheap (arm32 only) + * If a static heap was provided by the admin, populate the boot + * allocator with the corresponding regions only, but with Xenheap excluded + * on arm32. */ static void __init populate_boot_allocator(void) { unsigned int i; const struct meminfo *banks = &bootinfo.mem; + paddr_t s, e; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + s = bootinfo.reserved_mem.bank[i].start; + e = s + bootinfo.reserved_mem.bank[i].size; +#ifdef CONFIG_ARM_32 + /* Avoid the xenheap, note that the xenheap cannot across a bank */ + if ( s <= mfn_to_maddr(directmap_mfn_start) && + e >= mfn_to_maddr(directmap_mfn_end) ) + { + init_boot_pages(s, mfn_to_maddr(directmap_mfn_start)); + init_boot_pages(mfn_to_maddr(directmap_mfn_end), e); + } + else +#endif + init_boot_pages(s, e); + } + + return; + } for ( i = 0; i < banks->nr_banks; i++ ) { const struct membank *bank = &banks->bank[i]; paddr_t bank_end = bank->start + bank->size; - paddr_t s, e; s = bank->start; while ( s < bank_end ) @@ -714,8 +781,8 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 static void __init setup_mm(void) { - paddr_t ram_start, ram_end, ram_size, e; - unsigned long ram_pages; + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t static_heap_end = 0, static_heap_size = 0; unsigned long heap_pages, xenheap_pages, domheap_pages; unsigned int i; const uint32_t ctr = READ_CP32(CTR); @@ -735,30 +802,51 @@ static void __init setup_mm(void) for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) { - paddr_t bank_start = bootinfo.mem.bank[i].start; - paddr_t bank_size = bootinfo.mem.bank[i].size; - paddr_t bank_end = bank_start + bank_size; + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; ram_size = ram_size + bank_size; ram_start = min(ram_start,bank_start); ram_end = max(ram_end,bank_end); } - total_pages = ram_pages = ram_size >> PAGE_SHIFT; + total_pages = ram_size >> PAGE_SHIFT; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + static_heap_size += bank_size; + static_heap_end = max(static_heap_end, bank_end); + } + + heap_pages = static_heap_size >> PAGE_SHIFT; + } + else + heap_pages = total_pages; /* * If the user has not requested otherwise via the command line * then locate the xenheap using these constraints: * + * - must be contiguous * - must be 32 MiB aligned * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system if less + * - must be at most 1GB or 1/32 the total RAM in the system (or static + heap if enabled) if less * - must be at least 32M * * We try to allocate the largest xenheap possible within these * constraints. */ - heap_pages = ram_pages; if ( opt_xenheap_megabytes ) xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); else @@ -770,7 +858,9 @@ static void __init setup_mm(void) do { - e = consider_modules(ram_start, ram_end, + e = bootinfo.static_heap ? + fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : + consider_modules(ram_start, ram_end, pfn_to_paddr(xenheap_pages), 32<<20, 0); if ( e ) @@ -780,7 +870,7 @@ static void __init setup_mm(void) } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); if ( ! e ) - panic("Not not enough space for xenheap\n"); + panic("Not enough space for xenheap\n"); domheap_pages = heap_pages - xenheap_pages; @@ -826,7 +916,7 @@ static void __init setup_mm(void) static void __init setup_mm(void) { const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = ~0; + paddr_t ram_start = INVALID_PADDR; paddr_t ram_end = 0; paddr_t ram_size = 0; unsigned int i; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:45:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:45:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.400997.642650 (Exim 4.92) (envelope-from ) id 1oVqfr-0007OX-Jj; Wed, 07 Sep 2022 08:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 400997.642650; Wed, 07 Sep 2022 08:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqfr-0007OQ-H6; Wed, 07 Sep 2022 08:44:43 +0000 Received: by outflank-mailman (input) for mailman id 400997; Wed, 07 Sep 2022 08:44:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqfq-0007OK-O4 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:44:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqfq-0000oA-3j; Wed, 07 Sep 2022 08:44:42 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVqfp-0006Bc-P1; Wed, 07 Sep 2022 08:44:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PwSD9Z9/gjYJjqG/fUwrwQTyB8NO6mrSOGhquyflNrk=; b=ZqunzL7uy2w/gtic8f+yeQacuj 6lpKMvc5SLLLE3hVV+o8SGOgDHjSnKuUVAG80kuurK5sFaZtlYbWzEYtZZ8nMlmRmMIvglHQDWVDa ibkvK0GXRp2A5Y9CzK3Flzk0a1wpG9K2BrNczdi0VheMBGmKM7PmZgyRDWalkhRR18yk=; Message-ID: <1410d4ef-7b9a-6567-74f1-f900602f5d8f@xen.org> Date: Wed, 7 Sep 2022 09:44:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-5-jgross@suse.com> <48bdfa39-ce5a-6d48-0bb4-8a0270e181c9@suse.com> From: Julien Grall In-Reply-To: <48bdfa39-ce5a-6d48-0bb4-8a0270e181c9@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 07/09/2022 07:28, Juergen Gross wrote: > On 06.09.22 19:27, Julien Grall wrote: >> Hi Juergen, >> >> On 05/09/2022 13:47, Juergen Gross wrote: >>> Extend the definition of the Xenstore migration stream to cover new >>> features: >>> >>> - per domain features >>> - extended watches (watch depth) >>> - per domain quota >>> >>> Signed-off-by: Juergen Gross >>> --- >>> V3: >>> - new patch >>> V4: >>> - add new record types instead of modifying the existing ones >>>    (Julien Grall) >>> --- >>>   docs/designs/xenstore-migration.md | 160 ++++++++++++++++++++++++++++- >>>   1 file changed, 155 insertions(+), 5 deletions(-) >>> >>> diff --git a/docs/designs/xenstore-migration.md >>> b/docs/designs/xenstore-migration.md >>> index efa526f420..c70505c43a 100644 >>> --- a/docs/designs/xenstore-migration.md >>> +++ b/docs/designs/xenstore-migration.md >>> @@ -43,7 +43,14 @@ the setting of the endianness bit. >>>   |-----------|---------------------------------------------------| >>>   | `ident`   | 0x78656e73746f7265 ('xenstore' in ASCII)          | >>>   |           |                                                   | >>> -| `version` | 0x00000001 (the version of the specification)     | >>> +| `version` | The version of the specification, defined values: | >>> +|           | 0x00000001: all fields and records without any    | >>> +|           |             explicitly mentioned version          | >>> +|           |             dependency are valid.                 | >>> +|           | 0x00000002: all fields and records valid for      | >>> +|           |             version 1 plus fields and records     | >>> +|           |             explicitly stated to be supported in  | >>> +|           |             version 2 are valid.                  | >> >> I think it would be useful to outline in the commit message why the >> version had to be bumped. > > Okay. > >> >>>   |           |                                                   | >>>   | `flags`   | 0 (LSB): Endianness: 0 = little, 1 = big          | >>>   |           |                                                   | >>> @@ -77,7 +84,10 @@ NOTE: padding octets here and in all subsequent >>> format specifications must be >>>   |        | 0x00000003: WATCH_DATA                               | >>>   |        | 0x00000004: TRANSACTION_DATA                         | >>>   |        | 0x00000005: NODE_DATA                                | >>> -|        | 0x00000006 - 0xFFFFFFFF: reserved for future use     | >>> +|        | 0x00000006: GLOBAL_QUOTA_DATA                        | >>> +|        | 0x00000007: DOMAIN_DATA                              | >>> +|        | 0x00000008: WATCH_DATA_EXTENDED (version 2 and up)   | >>> +|        | 0x00000009 - 0xFFFFFFFF: reserved for future use     | >>>   |        |                                                      | >>>   | `len`  | The length (in octets) of `body`                     | >>>   |        |                                                      | >>> @@ -129,6 +139,7 @@ xenstored state that needs to be restored. >>>   | `evtchn-fd`    | The file descriptor used to communicate with | >>>   |                | the event channel driver                     | >>> + >> >> Spurious change? > > Yes. > >> >>>   xenstored will resume in the original process context. Hence >>> `rw-socket-fd` >>>   simply specifies the file descriptor of the socket. Sockets are not >>> always >>>   used, however, and so -1 will be used to denote an unused socket. >>> @@ -241,9 +252,9 @@ the file descriptor of the socket connection. >>>   ### WATCH_DATA >>> -The image format will contain a `WATCH_DATA` record for each watch >>> registered >>> -by a connection for which there is `CONNECTION_DATA` record >>> previously present. >>> - >>> +The image format will contain either a `WATCH_DATA` or a >>> `WATCH_DATA_EXTENDED` >>> +record for each watch registered by a connection for which there is >>> +`CONNECTION_DATA` record previously present. >>>   ``` >>>       0       1       2       3    octet >>> @@ -406,6 +417,145 @@ A node permission specifier has the following >>> format: >>>   Note that perm1 defines the domain owning the node. See [4] for more >>>   explanation of node permissions. >>> +\pagebreak >>> + >>> +### GLOBAL_QUOTA_DATA >>> + >>> +This record is only relevant for live update. It contains the global >>> settings >>> +of xenstored quota. >>> + >>> +``` >>> +    0       1       2       3    octet >>> ++-------+-------+-------+-------+ >>> +| n-dom-quota   | n-glob-quota  | >>> ++---------------+---------------+ >>> +| quota-val 1                   | >>> ++-------------------------------+ >>> +... >>> ++-------------------------------+ >>> +| quota-val N                   | >>> ++-------------------------------+ >>> +| quota-names >>> +... >>> +``` >>> + >>> + >>> +| Field          | Description                                  | >>> +|----------------|----------------------------------------------| >>> +| `n-dom-quota`  | Number of quota values which apply per       | >>> +|                | domain.                                      | >> >> I would add "by default" or something similar to make clear that the >> value in DOMAIN_DATA will override any quota set here. But see below >> about 'n-dom-quota' and 'n-glob-quota'. > > Okay. > >> >>> +|                |                                              | >>> +| `n-glob-quota` | Number of quota values which apply globally  | >>> +|                | only.                                        | >>> +|                |                                              | >>> +| `quota-val`    | Quota values, first the ones applying per    | >>> +|                | domain, then the ones applying globally. A   | >>> +|                | value of 0 has the semantics of "unlimited". | >> >> It is unclear to me why you need to make the distinction between "per >> domain" and "globally". IOW shouldn't be the name of the quota already >> indicates that? > > I think it could help in special cases. > > Imagine Xenstore A knows about global quota g and domain quota d, while > Xenstore B doesn't know both. Initially I'm running Xenstore A on a > host, then I'm live-updating to B. > > B gets the information that g is global, and d is per-domain, but has no > other idea what to do with the values of g and d. OTOH it knows that each > new domain should get d with the related value, so it can set d for each > newly created domain. > > When B is either downgraded to A again, or a domain is migrated to another > host running A, B can add the quota information of d for all domains. > > While this is nothing I'm planning to do in the near future, it might help > e.g. in cases with mixed C-xenstored and O-xenstored setups. > > It doesn't cost really much, so I wanted to support this possibility in the > migration stream from the beginning. I can see the use-case. However... > >> >>> +|                |                                              | >>> +| `quota-names`  | 0 delimited strings of the quota names in    | >>> +|                | the same sequence as the `quota-val` values. | >>> + >>> + >>> +Allowed quota names are those explicitly named in [2] for the >>> `GET_QUOTA` >>> +and `SET_QUOTA` commands, plus implementation specific ones. Quota >>> names not >>> +recognized by the receiving side must be ignored. ... this is seem to directly conflict with this sentence as to me "ignore" means drop. What you want is for Xenstore to optionally preserve. Also, I think what you wrote above would be helpful in the commit message. It gives some insights for future reader on how the stream was designed. >>> + >>> +\pagebreak >>> + >>> +### DOMAIN_DATA >>> + >>> +This record is optional and can be present once for each domain. >>> + >>> + >>> +``` >>> +    0       1       2       3     octet >>> ++-------+-------+-------+-------+ >>> +| domain-id     | n-quota       | >>> ++---------------+---------------+ >>> +| features                      | >>> ++-------------------------------+ >>> +| quota-val 1                   | >>> ++-------------------------------+ >>> +... >>> ++-------------------------------+ >>> +| quota-val N                   | >>> ++-------------------------------+ >>> +| quota-names >>> +... >>> +``` >>> + >>> + >>> +| Field          | Description                                  | >>> +|----------------|----------------------------------------------| >>> +| `domain-id`    | The domain-id of the domain this record      | >>> +|                | belongs to.                                  | >>> +|                |                                              | >>> +| `n-quota`      | Number of quota values.                      | >>> +|                |                                              | >>> +| `features`     | Value of the feature field visible by the    | >>> +|                | guest at offset 2064 of the ring page.       | >>> +|                | Aligned to the next 4 octet boundary.        | >> >> Stale sentence? > > Oh yes, a survivor of V3. > >> >>> +|                | Only valid for version 2 and later.          | >> >> Can you mention explicitly whether the field will unknown or 0 for >> version 1? > > We have the general note "padding octets here and in all subsequent format > specifications must be written as zero". I think this should suffice. I don't view this field as padding because it has a meaning. So I argue it is not cover by the sentence. Therefore I would add "Otherwise, the field is unknown/0" (pick the one you prefer between 0 and unknown). > >> >>> +|                |                                              | >>> +| `quota-val`    | Quota values, a value of 0 has the semantics | >>> +|                | "unlimited".                                 | >>> +|                |                                              | >>> +| `quota-names`  | 0 delimited strings of the quota names in    | >>> +|                | the same sequence as the `quota-val` values. | >>> + >>> +Allowed quota names are those explicitly named in [2] for the >>> `GET_QUOTA` >>> +and `SET_QUOTA` commands, plus implementation specific ones. Quota >>> names not >>> +recognized by the receiving side must be ignored. >>> + >>> +\pagebreak >>> + >>> +### WATCH_DATA_EXTENDED >> >> NIT: I think it would be more logical if this is defined right next >> after WATCH_DATA. > > I was following the record type numbering, but I can move this record > description up if you like that better. > >> >>> + >>> +The image format will contain either a `WATCH_DATA` or a >>> `WATCH_DATA_EXTENDED` >>> +record for each watch registered by a connection for which there is >>> +`CONNECTION_DATA` record previously present. The >>> `WATCH_DATA_EXTENDED` record >>> +type is valid only in version 2 and later. >>> + >>> +``` >>> +    0       1       2       3    octet >>> ++-------+-------+-------+-------+ >>> +| conn-id                       | >>> ++---------------+---------------+ >>> +| wpath-len     | token-len     | >>> ++---------------+---------------+ >>> +| depth         |               | >>> ++---------------+---------------+ >> >> It is not clear what would be the value of octet 2-3. Is it RES0 or >> UNKNOWN? > > I don't understand the question. conn-id is a 4-byte item. I was referring to the blank after 'depth'. In other record, we use 'pad'. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:53:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:53:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401006.642666 (Exim 4.92) (envelope-from ) id 1oVqoG-0000bi-FS; Wed, 07 Sep 2022 08:53:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401006.642666; Wed, 07 Sep 2022 08:53:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqoG-0000bb-Cg; Wed, 07 Sep 2022 08:53:24 +0000 Received: by outflank-mailman (input) for mailman id 401006; Wed, 07 Sep 2022 08:53:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqoF-0000bM-DU for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:53:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86685fe8-2e8a-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 10:53:21 +0200 (CEST) Received: from AM6PR04CA0057.eurprd04.prod.outlook.com (2603:10a6:20b:f0::34) by AS8PR08MB6280.eurprd08.prod.outlook.com (2603:10a6:20b:29b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 08:53:19 +0000 Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::b) by AM6PR04CA0057.outlook.office365.com (2603:10a6:20b:f0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 08:53:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 08:53:19 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 07 Sep 2022 08:53:18 +0000 Received: from 9a7d2633eb94.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1B84BD8C-0255-4AEE-9BE0-848FE606AD7B.1; Wed, 07 Sep 2022 08:53:11 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9a7d2633eb94.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 08:53:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB9847.eurprd08.prod.outlook.com (2603:10a6:10:444::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 08:53:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:53:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86685fe8-2e8a-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GQOs5kisnbLVYaUT73RTw1k5TXnPFfLzUqk4cymfqoqUfwJwKX5CCo+aEq2l3AD1x4uTuNxlXm3z/PdE1Ajj2Q9qXNdUHJipObS3rpcAOamsu+/XURiTKy7suH0I9cwW4OsirjGVGbWef1RlLwbZ/e0QXyc4SwESw3lY/VRDdjFZhQxg3K3sRD08yE2g+UQfpqTEQchk8rEVW8mA46gAtEwdOshZ341t/mQDdDouaHoF8O9o9LmwYb7jJZyCLrWWvHqXgaPxFmm0MGreGXQ5ogQWJuI89HOZsolDibOX/7Xc5GjCd6M0ux61S1h1GotAkNUYEsRekZOtBpB9Xf8Uuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aj9lsvqm8Rg65hyLIXtmGhhmT96oPyr4fyxqVrE0XSc=; b=TJOoO+8TcPV4/MreWJqq6kGoYPCvKKUJsSNohUwm1yLUKCvIkCzBYWGsioerRGfQTRl6wocx2iPF/mqa/O+88lOAZNGeab0AF+VkQro0VLhmbE0lEuYijK21E443ycXiouzNxqQ/RBxjhpQJkqel9It23woL4f6JnLISEBrZc3pP6qLdUfmyKC/GTmvzkvYrSZx4XKXRznyM8/4cbNRowJhW9UAwqo7TSqvPuSJBUjdtdebrzMQlsy1GuF0IRmmi5iaNfXIQH2F4OuPyssa3usiv/xKp1MNFED6/7CjacTH21iK/wpw5ax0iLNPBIepJblEXIe7UoWT8qLI3q4SvYw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj9lsvqm8Rg65hyLIXtmGhhmT96oPyr4fyxqVrE0XSc=; b=0AIG95ROZ/b43bkcyPCcxEOZ7bjeBam4zoZiKAhDCHStNeAZvJmim5e0p752x9AB8yL6/t3QMjtYUPvel+CtQpS/ziFG7gcPnEnUAJHnewUsf9unWO7joOxp9BsLc9cN48jIqfl3KlAFx4fFOt1L7DKYERut5gC1d2EZTszt1Xo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8dda49ce62b7b37e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BMirG2HiiqXKU3VvnsKs8P3yLUV/k4Ae4ep56fOOkE3V59VJSFvGXtLEDtViZ9O8rKZoupvINxIJcSBiQJbBvyeuJplkndlXjRFqFpo5ECUY9MRn0qJ/ZRSfH5V7L/HnRCSJTnNg90UHzhnCSVbZHtvz/Atd1ifP1O4GRDP4saPKX/2yYINV+ZeQoFy0QKHvYKhCC7VmLR3o7vx/TSurHc3aq35lLIG73xWt/lfMXpoJywXp6PriSHz13Po83ywkbqdU9QNBAqEsswhIOCrTimjjGdmAx45HJp+3uLEnoaqx3C4rPjE/4dpNKT1qasEx/E8huLvQ6b9yzaOPjkEhRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aj9lsvqm8Rg65hyLIXtmGhhmT96oPyr4fyxqVrE0XSc=; b=FP9saBOQfUUQmJ66JmjRQuQDsofmnxdi8AwvnWHqah/RL0J5llRwBA5pJg2tlcLqiHLMzUHGg9lnYtuXFd5Yht+w5awB0GG1KU99WDfyK8f4RB7RKRt3qCqUqHVZW217kcRV9RDIbDV8iYCV32gh7+9m5nfjBUTEpve9rXEI+Ebd6Vkw9fMyHu2Kr0+osZYD4K3lkQVN6EtyoRris1vJMOZ1TB1lUzQCMLxUDeTRhsJT68vtl+p05cLu2JRt16mhZP7qU+1pfiVeXkQM+Tq0t3d9bLQ+xMKJvftMmu75aq9SvcwFEFG7AD2BuhC0/UZVfGDMoXeS4iloWhRflJaovQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj9lsvqm8Rg65hyLIXtmGhhmT96oPyr4fyxqVrE0XSc=; b=0AIG95ROZ/b43bkcyPCcxEOZ7bjeBam4zoZiKAhDCHStNeAZvJmim5e0p752x9AB8yL6/t3QMjtYUPvel+CtQpS/ziFG7gcPnEnUAJHnewUsf9unWO7joOxp9BsLc9cN48jIqfl3KlAFx4fFOt1L7DKYERut5gC1d2EZTszt1Xo= From: Bertrand Marquis To: Julien Grall CC: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Thread-Topic: [PATCH] xen/arm: acpi: Include header file for version number Thread-Index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8A Date: Wed, 7 Sep 2022 08:53:09 +0000 Message-ID: <5C05BF68-C788-47AF-A967-338875740D49@arm.com> References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> In-Reply-To: <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 316dc10d-c567-4981-9ef3-08da90ae697a x-ms-traffictypediagnostic: DU0PR08MB9847:EE_|VE1EUR03FT033:EE_|AS8PR08MB6280:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xyF83/V3E0gptACQ3tUkeIRO19a9CQ7vF48/tZmvARH2BIrzuusCt54ZYXxCQYtpFefJBf7z7So6cVh8sSo5uDN4OqT73WbiuwWv6xNUEzdm7AhopFjW1dIS/RjimriW/cKA1pzYrjEsyvoMR899bru9yJvgdhTucCH+wrD2gcTI0tuNKi3EM89Q5JQMuquRWtfc0McAL8u+OetE8xrZuBrIYpp6QS/0RzvOt9h28Gz9Q0TkZnWw914HWesldhU+duR2/hGp5HD0FZ2PJp78g5HCndnxlqTS4a+X56GJpyIFkmxwiN4J8yvh57YP4fO+tWwRBBiwaqbaaxlnH6j6snqzRAckgdzrxBuIEwSwOp+uRr2teXaKUjSRDihThSWuo3ZCEH2vQGd/Enf0vYQn7rdRNGGQ46F/mIC/e/jZrOK23C2A9EQLEd0flpR+yyHqJx8CHL+fArkehhDGTHblJi6RzOjnOB7/sofk1P0Y0ZdzcvaWi8D09Q6Nf55hB+ruefahdVKV4EKCNEt6I4zQytGj0Lr1eq6X/nR9eZd8h3IN6MyqirCRRO1Xbb5oo5ZVakT2kv8Xt2S6OPTqBP8sLlLVJMj0SCkozFhYzmnQSSACx+TRngvFwHRMWNZb/wmw3xVXBCer+VeTGMXTa85gQcELwGhT3rL60znG79qOuV7S7gMqOPQO5frBtwWIJ3TdsrtevFFTzy8V0EcgFav7PUADl8TBxvEdQyhJVVlxkh2s8C5L0805Ocj59MvKgQONOCw5tPlPPHZAfs+DCSalLHvZ7UYCtow2Zg0jZA5qvQQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(83380400001)(186003)(6486002)(316002)(86362001)(6916009)(33656002)(71200400001)(38070700005)(41300700001)(38100700002)(54906003)(2616005)(122000001)(8936002)(91956017)(76116006)(66476007)(4326008)(66556008)(64756008)(66446008)(8676002)(66946007)(478600001)(2906002)(26005)(5660300002)(6506007)(36756003)(53546011)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <34AD469D83F4D74CB2D3A2FE61B9B989@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9847 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0b6dff16-679b-46dc-8128-08da90ae635a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hrOCIIyMe7Gp+lhqWCcia3nH9X4tw6bXWGmicfCUMQbx8pZUVl1antDFo9mzftqknqYIpmBP1HoZSeA8lVEpMD27OQNwwPXOwhIqQo0/Wkg54OUCD3cjtIv4ELGUq1Pg9kJYTHO6HXYV5wfpCl31VdnIDnmCmqthfkdWQRGeikEMxV4siYW3t/ipsCaSpb6XcDd6YdNluFmfsIqkevE2vi69O8rw+bfiLdC+4XSyt6UaazX/ipu+PIPDVkjU5KbDJO0+hWOQYETQEPKvsj0k538GjjfemQeFCSTt6p4pSimGQmI7XKyC8821xrwhBh0/4M4sK7CC01u64zO7OXPW9rn7m4DLaGKy/gpCbfsM/Wj+xaP5NHLuPTueqpqTnK5uJMdBlYphxdMVqCCNlAF8b0An3y/OxezUEbkNVgaFBXIYn1E5s2CUtxl9BDDKXpK++AM0uBZTeMvIf2YnOp2lfJ62A302nzuXXjNCF/cf6wKRe2fx4KAuBHOHJ2VywHh3k67OoSGg1CGqT5YnB2XxWlFQz0oGJ8+Yo8scxraoh6bKVUNsBSk5Gu7b3n8XTF9PPoaKgDIQLY90tXAWjn4CnQBUDy+PPcQoqBaUYnphsmd1W0ri+cPCT9Y/A9ReAfCrLEHeNVL06KaHBM63Vhb7Go2gmgp0MAdmcJcTHes4Dijls4LNHupmJa+fGwDvyokBxZKosRqvehIeOQ93W4PbxJ2YO9xUyca4VtcPbYcjkhJ1DsYnZU/ZjC8PbEsKWtoMJLs2lmfsDKKmhjwEOtTsmw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(346002)(46966006)(40470700004)(36840700001)(47076005)(186003)(81166007)(356005)(82310400005)(36860700001)(8676002)(336012)(36756003)(70206006)(70586007)(478600001)(54906003)(4326008)(316002)(6486002)(83380400001)(2906002)(53546011)(6512007)(26005)(40460700003)(8936002)(41300700001)(6862004)(33656002)(2616005)(5660300002)(6506007)(86362001)(40480700001)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 08:53:19.3293 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 316dc10d-c567-4981-9ef3-08da90ae697a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6280 SGkgSnVsaWVuLA0KDQo+IE9uIDcgU2VwIDIwMjIsIGF0IDA5OjM3LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMDcvMDkvMjAyMiAwOTozMCwg QmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+PiBPbiA3IFNlcCAyMDIyLCBhdCAwOToyNiwgSnVs aWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gSGkgTGVvLA0KPj4+ IA0KPj4+IE9uIDA2LzA5LzIwMjIgMTI6MzEsIExlbyBZYW4gd3JvdGU6DQo+Pj4+IE9uIEFybTY0 IExpbnV4IGtlcm5lbCBwcmludHMgbG9nIGZvciBYZW4gdmVyc2lvbiBudW1iZXI6DQo+Pj4+ICAg WyAgICAwLjAwMDAwMF0gWGVuIFhFTl9WRVJTSU9OLlhFTl9TVUJWRVJTSU9OIHN1cHBvcnQgZm91 bmQNCj4+Pj4gQmVjYXVzZSB0aGUgaGVhZGVyIGZpbGUgInhlbi9jb21waWxlLmgiIGlzIG1pc3Nl ZCwgWEVOX1ZFUlNJT04gYW5kDQo+Pj4+IFhFTl9TVUJWRVJTSU9OIGFyZSBub3QgZGVmaW5lZCwg dGh1cyBjb21waWxlciBkaXJlY3RseSB1c2VzIHRoZQ0KPj4+PiBzdHJpbmcgIlhFTl9WRVJTSU9O IiBhbmQgIlhFTl9TVUJWRVJTSU9OIiBpbiB0aGUgY29tcGF0aWJsZSBzdHJpbmcuDQo+Pj4+IFRo aXMgcGF0Y2ggaW5jbHVkZXMgdGhlIGhlYWRlciAieGVuL2NvbXBpbGUuaCIgd2hpY2ggZGVmaW5l cyBtYWNyb3MgZm9yDQo+Pj4+IFhFTl9WRVJTSU9OIGFuZCBYRU5fU1VCVkVSU0lPTiwgdGh1cyBY ZW4gY2FuIHBhc3MgdGhlIHZlcnNpb24gbnVtYmVyIHZpYQ0KPj4+PiBoeXBlcnZpc29yIG5vZGUu DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IExlbyBZYW4gPGxlby55YW5AbGluYXJvLm9yZz4NCj4+PiAN Cj4+PiBBRkFJQ1QsIHRoZSBwcm9ibGVtIHdhcyBpbnRyb2R1Y2VkIHdoZW4gd2Ugc3BsaXQgdGhl IEFDUEkgY29kZSBmcm9tIGFyY2gvZG9tYWluX2J1aWxkLmMuIFNvIEkgd291bGQgYWRkIHRoZSBm b2xsb3dpbmcgdGFnOg0KPj4+IA0KPj4+IEZpeGVzOiA1ZDc5N2VlMTk5YjMgKCJ4ZW4vYXJtOiBz cGxpdCBkb21haW5fYnVpbGQuYyIpDQo+Pj4gDQo+Pj4gTm93LCB0aGlzIG1lYW5zIHdlIHNoaXBw ZWQgWGVuIGZvciB+NCB5ZWFycyB3aXRoIHRoZSB3cm9uZyBjb21wYXRpYmxlLiBUaGUgY29tcGF0 aWJsZSBpcyBtZWFudCB0byBpbmRpY2F0ZSB0aGUgWGVuIHZlcnNpb24uIEhvd2V2ZXIsIEkgZG9u J3QgdGhpbmsgdGhpcyBpcyB1c2VkIGZvciBhbnl0aGluZyBvdGhlciB0aGFuIHByaW50aW5nIHRo ZSB2ZXJzaW9uIG9uIHRoZSBjb25zb2xlLg0KPj4+IA0KPj4+IEFsc28sIHRoZSBwcm9ibGVtIG9j Y3VycyBvbmx5IHdoZW4gdXNpbmcgQUNQSS4gVGhpcyBpcyBzdGlsbCBpbiB0ZWNoIHByZXZpZXcs IHNvIEkgdGhpbmsgd2UgZG9uJ3QgbmVlZCB0byBkb2N1bWVudCB0aGUgaXNzdWUgaW4gdGhlIGRv Y3VtZW50YXRpb24gKHdlIGNhbiBlYXNpbHkgYnJlYWsgQUJJKS4NCj4+PiANCj4+Pj4gLS0tDQo+ Pj4+ICB4ZW4vYXJjaC9hcm0vYWNwaS9kb21haW5fYnVpbGQuYyB8IDEgKw0KPj4+PiAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspDQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v YWNwaS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9hY3BpL2RvbWFpbl9idWlsZC5jDQo+ Pj4+IGluZGV4IGJiZGM5MGY5MmMuLjI2NDllMTFmZDQgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9h cmNoL2FybS9hY3BpL2RvbWFpbl9idWlsZC5jDQo+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9hY3Bp L2RvbWFpbl9idWlsZC5jDQo+Pj4+IEBAIC05LDYgKzksNyBAQA0KPj4+PiAgICogR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4+Pj4gICAqLw0KPj4+PiAgKyNp bmNsdWRlIDx4ZW4vY29tcGlsZS5oPg0KPj4+IA0KPj4+IFNvIHRoaXMgaXMgZml4aW5nIHRoZSBp bW1lZGlhdGUgcHJvYmxlbS4gR2l2ZW4gdGhlIHN1YnRsZXR5IG9mIHRoZSBidWcsIEkgdGhpbmsg aXQgd291bGQgYmUgZ29vZCB0byBhbHNvIGhhcmRlbiB0aGUgY29kZSBhdCB0aGUgc2FtZSB0aW1l Lg0KPj4gSSB0aGluayB3ZSBzaG91bGQgY29tbWl0IHRoZSBwYXRjaCBhcyBpcyBhbmQgaGFyZGVu IHRoZSBjb2RlIGluIGEgc3Vic2VxdWVudCBwYXRjaC4NCj4gDQo+IEkgdGhvdWdodCBhYm91dCB0 aGlzLiBIb3dldmVyLCBpZiB3ZSBkbyB0aGUgaGFyZGVuaW5nIGluIHRoZSBzYW1lIHBhdGNoLCB0 aGVuIGl0IG1ha2VzIGEgbG90IGVhc2llciB0byBjb25maXJtIHRoYXQgdGhlIHBhdGNoIHdvcmtz IHdoZW4gaW5nZXN0ZWQgaW4gZG93bnN0cmVhbSBjb2RlIG9yIGJhY2twb3J0ZWQuDQo+IA0KPj4+ IA0KPj4+IEkgY2FuIHNlZSB0d28gd2F5IHRvIGRvIHRoYXQ6DQo+Pj4gIDEpIERyb3BwaW5nIHRo ZSB1c2Ugb2YgX19zdHJpbmdpZnkNCj4+PiAgMikgQ2hlY2sgaWYgWEVOX1ZFUlNJT04gYW5kIFhF Tl9TVUJWRVJTSU9OIGFyZSBkZWZpbmVkDQo+Pj4gDQo+Pj4gVGhlIGxhdHRlciBpcyBwcm9iYWJs eSBsaWdodHdlaWdodC4gVGhpcyBjb3VsZCBiZSBhZGRlZCByaWdodCBuZXh0IHRvIGFjcGlfbWFr ZV9oeXBlcnZpc29yX25vZGUoKSBmb3IgY2xhcmlmeS4NCj4+PiANCj4+PiBTb21ldGhpbmcgbGlr ZToNCj4+PiANCj4+PiAjaWZuZGVmIFhFTl9WRVJTSU9ODQo+Pj4gIyBlcnJvciAiWEVOX1ZFUlNJ T04gaXMgbm90IGRlZmluZWQiDQo+Pj4gI2VuZGlmDQo+Pj4gDQo+Pj4gI2lmbmRlZiBYRU5fU1VC VkVSU0lPTg0KPj4+ICMgZXJyb3IgIlhFTl9TVUJWRVJTSU9OIGlzIG5vdCBkZWZpbmVkIg0KPj4+ ICNlbmRpZg0KPj4+IA0KPj4+IENvdWxkIHlvdSBoYXZlIGEgbG9vaz8NCj4+IFRoZXJlIGFyZSBh Y3R1YWxseSBzZXZlcmFsIHBsYWNlcyBpbiB0aGUgY29kZSB3aGVyZSB3ZSB1c2UgdGhlIHN0cmlu Z2lmeSBzeXN0ZW0uDQo+PiBXb3VsZCBpdCBtYWtlIHNlbnNlIHRvIGFjdHVhbGx5IGhhdmUgYSBz dHJpbmcgdmVyc2lvbiBwcm92aWRlZCBpbiBjb21waWxlLmggYW5kIHVzZSBpdCBpbnN0ZWFkID8N Cj4gDQo+IEkgdGhpbmsgc28uDQo+IA0KPj4gT3RoZXJ3aXNlIGlmIHdlIHN0YXJ0IGFkZGluZyB0 aG9zZSBraW5kcyBvZiBjaGVja3MsIHdlIHdpbGwgaGF2ZSB0byBhZGQgdGhlbSBpbiBhdCBsZWFz dCAzIHBsYWNlcyBpbiB4ZW4gY29kZS4NCj4gDQo+IFRoZSBzb2x1dGlvbiBJIHByb3Bvc2VkIGFi b3ZlIGlzIGVhc3kgdG8gaW1wbGVtZW50IHJpZ2h0IG5vdy4gTXkgZ3V0IGZlZWxpbmcgaXMgdHdl YWtpbmcgX19zdHJpbmdpZnkgKG9yIGVsc2UpIHdpbGwgdGFrZSBhIGJpdCBtb3JlIHRpbWUuDQo+ IA0KPiBJZiB5b3UgKG9yIExlbykgY2FuIGNvbWUgdXAgd2l0aCBhIHNvbHV0aW9uIHF1aWNrbHkg dGhlbiBmaW5lLiBPdGhlcndpc2UsIEkgdGhpbmsgd2Ugc3RpbGwgd2FudCBzb21lIGhhcmRlbmlu ZyBmb3IgYmFja3BvcnRpbmcgcHVycG9zZS4NCg0KSSB0aGluayBhIGRlZmluZSBpbiBjb21waWxl LmggdXNpbmcgc3RyaW5naWZ5IGlzIHRoZSBlYXNpZXN0IHNvbHV0aW9uOg0KDQojZGVmaW5lIFhF Tl9TVFJfVkVSU0lPTiAiX19zdHJpbmdpZnkoWEVOX1ZFUlNJT04pIi4iX19zdHJpbmdpZnkoWEVO X1NVQlZFUlNJT04p4oCdDQoNCkFuZCB0aGVuIGNoYW5nZSB0aGUgY29kZSBpbiB0aGUgZm9sbG93 aW5nIHNvdXJjZSBjb2RlIHRvIHVzZSBpdDoNCmFyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQphcmNo L2FybS9hY3BpL2RvbWFpbl9idWlsZC5jDQpjb21tb24vZWZpL2Jvb3QuYw0KDQpATGVvOiB0ZWxs IG1lIGlmIHlvdSBuZWVkIGhlbHAgb3Igd2FudCBtZSB0byBkbyBpdA0KDQpDaGVlcnMNCkJlcnRy YW5kDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:56:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401022.642677 (Exim 4.92) (envelope-from ) id 1oVqqr-0001J3-0n; Wed, 07 Sep 2022 08:56:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401022.642677; Wed, 07 Sep 2022 08:56:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqqq-0001Iw-UD; Wed, 07 Sep 2022 08:56:04 +0000 Received: by outflank-mailman (input) for mailman id 401022; Wed, 07 Sep 2022 08:56:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqqp-0001IY-14 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:56:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqql-00010v-QQ; Wed, 07 Sep 2022 08:55:59 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVqql-0006Zo-KB; Wed, 07 Sep 2022 08:55:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=B01d5A5UZeg1R63qNolkraTFRmwchaF2vHwBf30UH0Q=; b=bMf9iEH583uIfInoRLNhQnE/mH /O8o6m1EAthB/zaQ5xOobD9lerwjxvTiD47ZgvFq18Lox2S+UtFJTFehY59t+oqRrhyEcLTIMrZNH M+CVT8Cob3A0oXIFB0s+fElt0RuFcuTvkrbrXBZ2nSTRLBP+k/zMd5gqEdBMrFi7R7ho=; Message-ID: <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> Date: Wed, 7 Sep 2022 09:55:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Content-Language: en-US To: Bertrand Marquis Cc: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> From: Julien Grall In-Reply-To: <5C05BF68-C788-47AF-A967-338875740D49@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/09/2022 09:53, Bertrand Marquis wrote: >>> Otherwise if we start adding those kinds of checks, we will have to add them in at least 3 places in xen code. >> >> The solution I proposed above is easy to implement right now. My gut feeling is tweaking __stringify (or else) will take a bit more time. >> >> If you (or Leo) can come up with a solution quickly then fine. Otherwise, I think we still want some hardening for backporting purpose. > > I think a define in compile.h using stringify is the easiest solution: Ah! I thought you were suggesting to tweak __stringify. This is ... > > #define XEN_STR_VERSION "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)” > > And then change the code in the following source code to use it: > arch/arm/domain_build.c > arch/arm/acpi/domain_build.c > common/efi/boot.c ... much better. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:58:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:58:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401028.642688 (Exim 4.92) (envelope-from ) id 1oVqsu-0001w0-Cw; Wed, 07 Sep 2022 08:58:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401028.642688; Wed, 07 Sep 2022 08:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqsu-0001vt-9Z; Wed, 07 Sep 2022 08:58:12 +0000 Received: by outflank-mailman (input) for mailman id 401028; Wed, 07 Sep 2022 08:58:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqss-0001vj-GE for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:58:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqsq-00012w-CO; Wed, 07 Sep 2022 08:58:08 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVqsq-0006bM-6X; Wed, 07 Sep 2022 08:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VUbqJmt1GBh5wKmVFTn8dV5334U/+OJNk5veKJ13S70=; b=pqS2y52C/ZgW6+NN2bBTFK9xiT UCVc3mMywq151sQwAGs1OSMjcZRyHHR2EXh4aJZFdxmHgCU5buJuHRvCotAn98tcnnUvkvAcg7GLs mOSyBGu3H75pljPI85/NyWnBSG52PKmf/YObpgpwUGdb6m6GWwEAOn52pqK1Nm4kHezo=; Message-ID: <5948f099-7287-2743-aa24-3c7a17033877@xen.org> Date: Wed, 7 Sep 2022 09:58:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Jan Beulich , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Rahul Singh References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan & Stefano, On 06/09/2022 09:53, Jan Beulich wrote: > On 03.09.2022 02:24, Stefano Stabellini wrote: >> On Thu, 1 Sep 2022, Rahul Singh wrote: >>> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >>> return 0; >>> } >>> >>> +static int is_bar_valid(const struct dt_device_node *dev, >>> + uint64_t addr, uint64_t len, void *data) >>> +{ >>> + struct pdev_bar *bar_data = data; >>> + unsigned long s = mfn_x(bar_data->start); >>> + unsigned long e = mfn_x(bar_data->end); >>> + >>> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >>> + bar_data->is_valid = true; >> >> >> This patch looks good and you addressed all Jan's comment well. Before I >> ack it, one question. >> >> I know that you made this change to address Jan's comment but using >> PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= >> PFN_UP(addr + len - 1)) check means that we are relaxing the >> requirements, aren't we? >> >> I know that this discussion is a bit pointless because addr and len should >> always be page aligned, and if they weren't it would be a mistake. Hmmm.... Is that requirement written down somewhere? The reason I am asking is "page-aligned" will vary depending on the software. In the past we had a couple of cases where the region would be 4KB-aligned but not necessarily 64KB-aligned. If the answer is no to my question then... > But >> assuming that they are not page aligned, wouldn't we want this check to >> be a strict as possible? >> >> Wouldn't we want to ensure that the [s,e] range is a strict subset of >> [addr,addr+len-1] ? If so we would need to do the following instead: >> >> if ( (s <= e) && (s >= PFN_UP(addr)) && (e <= PFN_DOWN(addr + len - 1)) ) >> bar_data->is_valid = true; > > But that might mean (in theory at least) a partial overlap, which has > to be avoided. The only alternative that I see to Rahul's original > code is to omit use of PFN_DOWN() and PFN_UP() in this construct > altogether. Assuming that's correct for the passed in (addr,len) > tuple. ... I think we would want to drop PFN_DOWN/PFN_UP here. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 08:58:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 08:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401036.642699 (Exim 4.92) (envelope-from ) id 1oVqtT-0002TR-LC; Wed, 07 Sep 2022 08:58:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401036.642699; Wed, 07 Sep 2022 08:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqtT-0002TK-Hl; Wed, 07 Sep 2022 08:58:47 +0000 Received: by outflank-mailman (input) for mailman id 401036; Wed, 07 Sep 2022 08:58:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVqtS-0002Qn-CX for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 08:58:46 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2080.outbound.protection.outlook.com [40.107.105.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47bf02ab-2e8b-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 10:58:46 +0200 (CEST) Received: from DB8PR06CA0046.eurprd06.prod.outlook.com (2603:10a6:10:120::20) by DU0PR08MB7613.eurprd08.prod.outlook.com (2603:10a6:10:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Wed, 7 Sep 2022 08:58:43 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::3e) by DB8PR06CA0046.outlook.office365.com (2603:10a6:10:120::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 08:58:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 08:58:43 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 07 Sep 2022 08:58:43 +0000 Received: from 4df3b41a86f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 435764A9-F89A-4CFF-BDDA-D835031EE94C.1; Wed, 07 Sep 2022 08:58:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4df3b41a86f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 08:58:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB6612.eurprd08.prod.outlook.com (2603:10a6:20b:368::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 08:58:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 08:58:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47bf02ab-2e8b-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dVe+VuNkzcYEIHg/UgvxOAXT240cQKJEXmZ8nHLhxRpauOkRyiQtl3Hp+4lUgAzSdyOJiFZWTWzT+xgX+BTP1lMvfbZ+1S5wNXEG7qEZoyo3l3oZW5uiMzONDrNSNbWU1KxHU2cKaUwteG9w3GU6zrxj+69viqCxBTzShRkcRR+eJRZOd7z9G2B9Qu/6njqRKjbIAtWSAkgRyCV7wCKMXyboaTFWUmqNI5Q6eKBR5B/WSY24zaXkGcljHNCoX+hDJGkhQ4hdkodYPr8JcrPoUhWlAk8fqfn90jpAjIHhD6DO8C9Z0uOY26q0AUXgID4Dya0kTj8peNgJYicV3S06Rg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTQalHre8kTdyfkbsxNJMXTvI9LYbIR6XJrpzwLJI4o=; b=FP15wW7KJUePFjK9MohGFyJkguvT5J0bHwETpmfRRlD1Y9mRWfTm/m+t/+zmpskTHdc+x1zLtbKAvY6nB2eCVjJZkihdaZgrv2qd4UsTh4OdHgeA5kmG7CExEjOBYuHLA+3KZNDkR7eYUxbg+gVKoL29vtxdynJvp1vmmO7dR4tjt97YtAQvh6IjiKvtBCT4FaB4HswIXXIJ8hbvs3dawsADWrpmeafhRCnPzkFD63V6Ka4NLkcxTGuv9Af9xbuZXN0+XeyhlIPo8AdnfUHUwBDJQDvOf6bbhzoOWTgVgWx2ifAZEvzgXzZ+pGYfXL4FI6BDyh42Si3J/TV7hNiRcA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BTQalHre8kTdyfkbsxNJMXTvI9LYbIR6XJrpzwLJI4o=; b=vKGCv6Lnt7Z5bqq+zSaZ40cmjT0/S7syFIAde39vtmd/xRulwZdRN9iGBedS8A2ZFLjyqC5S7f4dDwS/1dHCyqc9pfmZf+riUHN/sijDb6NyUstg/tfsk9DESDzztPxYCIIWV+V7s97BF8Sht/1OPz/D9wkDrewgEyTboSI5GRE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6afa02e7cd7fb197 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgNlEuP9dRBu99p7fwR9IGcQsS7AbDmvuS5e6Ha57/vCLlsSNNqK3xnMkRQ8SNgeM+/RyXIXRHRHqzjuSnQ1vRI1hOdAKR0QRdaX6ypc/UgUo0A+CjjEHH8+ER+LUaFg5Cq7asgOvmnlVLzrDKadyPb/Ki0l5x5OSMjF4Ygc4YAxygb+6NBE2bljclnboDHrbpuM5ru2G4c4/fJQnzK4aInjVfHDnFPnXNArpRtoL3MkdylDHaCu+NJT+gQvBaW0TtuUHArOxpzQGK3couQm+9j0T62wWnAKDW/0ZIHdZBRxqhWQrgOvTuI6N7Q686IJMRceEPaJSNXDkLDcbVTyZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTQalHre8kTdyfkbsxNJMXTvI9LYbIR6XJrpzwLJI4o=; b=JgjzlPXCcNnqieVtD+bzT8Z9VGmLF+Z39pfZe1Qk2KimROl5gkINjNpB7q9xp8g5KE76rlxjMcTZdji47UzifUwT18VXsnqqNIAWwsITetr7dIYp6DtNiWTeNaSvHJwYr8xIjZRGzdQcE1QBYoSn/HcXykfcC6npNGYoaQRnIO1bjnB+vRWa3FPhjLuzCFGbz8cViO1Ar839rujxLtlBbjFpwaSmvwaXVJWLh+UA3Q7kdBAnw6rBnYLpjqf2F2jIf3t9KwzdMBrYvvLr3fGjhJ2ZWc/TY7tbhwKlhgMVMsS8CIWIu6l0nasPziWQtQlTSA8LcOpFwOeLu8wLrnvtNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BTQalHre8kTdyfkbsxNJMXTvI9LYbIR6XJrpzwLJI4o=; b=vKGCv6Lnt7Z5bqq+zSaZ40cmjT0/S7syFIAde39vtmd/xRulwZdRN9iGBedS8A2ZFLjyqC5S7f4dDwS/1dHCyqc9pfmZf+riUHN/sijDb6NyUstg/tfsk9DESDzztPxYCIIWV+V7s97BF8Sht/1OPz/D9wkDrewgEyTboSI5GRE= From: Bertrand Marquis To: Julien Grall CC: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Thread-Topic: [PATCH] xen/arm: acpi: Include header file for version number Thread-Index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8AgAAAyoCAAAC7AA== Date: Wed, 7 Sep 2022 08:58:35 +0000 Message-ID: <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> In-Reply-To: <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: aee3b737-2795-43cd-f468-08da90af2a9f x-ms-traffictypediagnostic: AM8PR08MB6612:EE_|DBAEUR03FT063:EE_|DU0PR08MB7613:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: J1kNXFrJHpu2EyK0twkRqH+fxTlKY0PtvhQ29M4zK3vxbh9n0HzVIvRf+mPc5+76Emwx88oFW/Y2pKp1How8XO/JCVZTLQA3fTBj72I1ceL+lnl7dvau/rflgGvYZWOvFlHA6q6C6TVuG/sLagnJ55foBXe70H/LmWsLQzQFvWIoZbRagadFh1ZrbqgrWKEgW/aN5vRC7NNperBhJz3L39hrSWalDsc7EJ6gZOJ17aw3C0hOkJheT8f9nG6AI1OfOkuEdL16iQiBO8TIvo15BYeBMc1b9S3rI5wfOU6rnhNuprLcYJxxW3EgeOCu5IBTaNU8FRjQixPZ57fTR2DR7TWzBPTVGse3ASNVXeP4ZVAFbAuQnOg5+LWwYVDFw7J2L1sgLMD3nMhEd8NzW5xglLQPG9t1ROf0Sjue1KO0HGg45eHm/N7mAZ249AKyI7SUoUVjyZidqgrtOELOyTu7WgpSgfDhn7vNjDF2Tme5nDDb2x+wVp2EsAi/mWC3/uThjXz7Zv+7JnhQOq6admJwKi/9z4PyLuV1eDo1V9c9P/0W5UmrfBhxd3WUPJnpPcLBVqhZD9ni7XJ43Za0loO4GdGVISankRqAe4xpU816oGonHkBFewlRxN4hcDA0uw9Zm1JwVlqslUJBPT1cRYkpluBUFCgPBpx/nWcY0vuHMMLX1s0wZ4t+QVAAg229VS0EsHFxHItpgiIqpsw0iqXJXV/Juc9iV4zrIZ4vwAQHLOTygYbzFyG5vQ3xx0oMkfaiu+M+4+KVwpY/SymVtuz5jYHEmGHTarUyKiNPCV+Yw70= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(66446008)(8676002)(91956017)(186003)(64756008)(66556008)(4326008)(76116006)(66946007)(66476007)(316002)(6916009)(54906003)(41300700001)(86362001)(36756003)(6512007)(2616005)(33656002)(26005)(38070700005)(5660300002)(2906002)(6486002)(6506007)(38100700002)(8936002)(71200400001)(478600001)(53546011)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <61CF122D1F00144093BF82066ACCFA7B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6612 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 284b6b6c-c9dc-47f0-f1b0-08da90af25a7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BlLErwh4bIeiPPECl6SJFVtV5OqfHgu+NuljYvhrMB2ux1p/fY5MhLloy0YDB2jIZWqYushUDYiQcS8y9cDoew0c7HEVcJcDeK+x5D0Nkwax5BXfrHYhcMewNpcfLQGTIp7/5eGq+6TMqU38HlrJhngSnPO2kvGPS5uM80u4wM+TjmwjCktxYqY/zGqIfZ8elKOip27NyDxfyrrHzmqU0aSmxtQxEYsSfTJgwNYc7Il952MHh1pj2lXdAQOXwZO8BtCRFg1+9c/quGEkTTxbNNs/XXsWzcURGuFb4UeWOwYL7fnq6phKBHVaRy4cB1XvQnk9OPTkYCEOGIjGqjc9AJAf0o0PmM3Jx6gsUDSXuW+jhBBQ4fJ7FFUBG0yug0yIj0dyhAmhfBJnLS3PCHZ+5hA75LmEBcMGLSc5YaFFqUvj8Wf5GLE0XYQL3jnvrUA7X2VPbrG0TM47SExTz+oVviBLpSr0uua5i4htkpcRi0VVSI0Pc6YtBzPOYeNxNseAo4I6ywh0uZ8IFifR2tf5aXAYHfyduQXibjrOktMf1ePcy3opVPLkjl/Om7VCtInxI5n3+jUSrwbxGhqQTjPvN12CrREmAM1626cX4+OPB3OjHdgtAGKeaWNFP5Ds8q5rQebiNI5ATw9SGvdkXhI0Hr4T/GtMmtnd5a2ZvM3Tjuic6kTtsTGe9PW17LpwGvP8qxO1rFr7VujG03h+3Wl2YcWrlaiTrkmhqqbmDaMHJ8RB42hiOiipprkC1ix140TIy+yXYfCCiV3bq7OhtAdcGQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(346002)(36840700001)(46966006)(40470700004)(8676002)(8936002)(5660300002)(2906002)(6862004)(356005)(4326008)(70206006)(70586007)(86362001)(36860700001)(81166007)(82740400003)(54906003)(336012)(186003)(6486002)(478600001)(316002)(41300700001)(33656002)(53546011)(6512007)(26005)(47076005)(40460700003)(36756003)(6506007)(82310400005)(2616005)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 08:58:43.4992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aee3b737-2795-43cd-f468-08da90af2a9f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7613 DQoNCj4gT24gNyBTZXAgMjAyMiwgYXQgMDk6NTUsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDA5OjUzLCBCZXJ0cmFuZCBN YXJxdWlzIHdyb3RlOg0KPj4+PiBPdGhlcndpc2UgaWYgd2Ugc3RhcnQgYWRkaW5nIHRob3NlIGtp bmRzIG9mIGNoZWNrcywgd2Ugd2lsbCBoYXZlIHRvIGFkZCB0aGVtIGluIGF0IGxlYXN0IDMgcGxh Y2VzIGluIHhlbiBjb2RlLg0KPj4+IA0KPj4+IFRoZSBzb2x1dGlvbiBJIHByb3Bvc2VkIGFib3Zl IGlzIGVhc3kgdG8gaW1wbGVtZW50IHJpZ2h0IG5vdy4gTXkgZ3V0IGZlZWxpbmcgaXMgdHdlYWtp bmcgX19zdHJpbmdpZnkgKG9yIGVsc2UpIHdpbGwgdGFrZSBhIGJpdCBtb3JlIHRpbWUuDQo+Pj4g DQo+Pj4gSWYgeW91IChvciBMZW8pIGNhbiBjb21lIHVwIHdpdGggYSBzb2x1dGlvbiBxdWlja2x5 IHRoZW4gZmluZS4gT3RoZXJ3aXNlLCBJIHRoaW5rIHdlIHN0aWxsIHdhbnQgc29tZSBoYXJkZW5p bmcgZm9yIGJhY2twb3J0aW5nIHB1cnBvc2UuDQo+PiBJIHRoaW5rIGEgZGVmaW5lIGluIGNvbXBp bGUuaCB1c2luZyBzdHJpbmdpZnkgaXMgdGhlIGVhc2llc3Qgc29sdXRpb246DQo+IA0KPiBBaCEg SSB0aG91Z2h0IHlvdSB3ZXJlIHN1Z2dlc3RpbmcgdG8gdHdlYWsgX19zdHJpbmdpZnkuIFRoaXMg aXMgLi4uDQoNCkFsc28gcG9zc2libGUgYnV0IGEgYml0IG1vcmUgdHJpY2t5DQoNCj4+ICNkZWZp bmUgWEVOX1NUUl9WRVJTSU9OICJfX3N0cmluZ2lmeShYRU5fVkVSU0lPTikiLiJfX3N0cmluZ2lm eShYRU5fU1VCVkVSU0lPTinigJ0NCg0KUXVvdGVzIGF0IGJlZ2lubmluZyBhbmQgZW5kIHNob3Vs ZCBub3QgYmUgdGhlcmUuDQoNCj4+IEFuZCB0aGVuIGNoYW5nZSB0aGUgY29kZSBpbiB0aGUgZm9s bG93aW5nIHNvdXJjZSBjb2RlIHRvIHVzZSBpdDoNCj4+IGFyY2gvYXJtL2RvbWFpbl9idWlsZC5j DQo+PiBhcmNoL2FybS9hY3BpL2RvbWFpbl9idWlsZC5jDQo+PiBjb21tb24vZWZpL2Jvb3QuYw0K PiANCj4gLi4uIG11Y2ggYmV0dGVyLg0KDQpUaGFua3MgOi0pDQoNCkJlcnRyYW5kDQoNCj4gDQo+ IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 09:08:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 09:08:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401043.642710 (Exim 4.92) (envelope-from ) id 1oVr2R-00048w-FK; Wed, 07 Sep 2022 09:08:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401043.642710; Wed, 07 Sep 2022 09:08:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVr2R-00048p-C7; Wed, 07 Sep 2022 09:08:03 +0000 Received: by outflank-mailman (input) for mailman id 401043; Wed, 07 Sep 2022 09:08:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVr2Q-00048j-0l for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 09:08:02 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130052.outbound.protection.outlook.com [40.107.13.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9236c47a-2e8c-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 11:08:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0401MB2480.eurprd04.prod.outlook.com (2603:10a6:800:4e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 09:07:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 09:07:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9236c47a-2e8c-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfzJden5q3XhwppaYqFU7PNsJrpVzVY8mIciT7CRTkGajcHfK1nrd13yz0byrIPmIq0znz/koBp7CDp9WwQvM36v8Sd488ToReS4WN8zw726jqFka4xXhPx1vHm1H/TRikKiAg2w8HmfFJm7doCxpUEAX4bJUMYRZVg9R0RTf73DBI1NgNhC3092Xh+DbfsF/zVwcUibygvN3dbwaNzZsfWK8cyWiwkwb5EwbjCE0A3VvTy/7AjBCbtelmLtuYSbdBbapsuJurSAv6OqvM8IYQ47HvKyc3QB6xJcv/CsZEAeNoZeuzZ3KFYb9vhOpXhuHc+ElBRuUEF7dF1dZeMPhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rBa91PnP2x0fp5wjpYDvgS06tRVGYHeIkGXQRkxwGwY=; b=FvSgkkW+WwwygvOo2atpRa/eANFkHtNxrnpdgqnA3YtsHuPU30O3/rew3IgyIzqxsB1KIcLmv1sIU6KF05mxbGXxFjUPmlc6tyBHMWMYBzJQNYMyFeNmVQS1WqdBPFKsKis975iYyoj/RzeR6BEwTJwfl+Y81PDu+bDRHz52VLY8G+RFN8+J55a7SAxi4v7XoPXxZKDjco0zMUzNx/63H+oGcgJwmqTPQrGjW6o2mo3IqhODKrHZkbb6pZJudGg69exqkJxEInjR4f8JC2A6XmAChVy+xzVTX6rLIZDHo2IPDVvz1VrPJ8N7rnP+TxlyjTwd0tztOvoTksh/OEWlvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBa91PnP2x0fp5wjpYDvgS06tRVGYHeIkGXQRkxwGwY=; b=W64jv0RBbEus5enNmfx9M7dT/Xss+RQrS6BJwJPstNFEUjDiam/0/T9VQMfPmWq9g2q9a+8mKktkGEXYs79wVkakG6p3esJyFT0uR5dFlQ5pZK2xIHr9qPD+bcAGexidVyoinhJEJF6FzDllgEnxmhSZLOymzppK/d21zgnv8wrl38Bkcmeb2P2+oHswwT7GdSCtdpZj+YJR3sCGQ7PMrsXXAXTsQruFnbqRTf0LQSMcJYdrcoWZVw7ji0j97ucMNsQCdtm7SMLbtMOiqgq48GpqNNigDCTCZmzoaJ+yob48odWl7uFmnTAcp4Nf19b3UlsnoCpcpFAPbU9qjtusxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4ac67001-9406-6cac-b032-b6cbefb598b5@suse.com> Date: Wed, 7 Sep 2022 11:07:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Julien Grall Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Rahul Singh , Stefano Stabellini References: <5948f099-7287-2743-aa24-3c7a17033877@xen.org> From: Jan Beulich In-Reply-To: <5948f099-7287-2743-aa24-3c7a17033877@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR0401MB2480:EE_ X-MS-Office365-Filtering-Correlation-Id: 843ee25e-2158-4e8d-8c86-08da90b07483 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oVGqcyuM7uVk4LJgiwYWbJv3rhp7dFQg5m6SMDvUI4e0qzGDTKwPngF2JCpivYOhvOghNdCm9vXZ8w0dbnCofkYs4cQ9kVw+f0LNHdkXzd+O/2Jj7p5dezGxrahr9g15iq209KIBg8bih0pNANUOdhDDN07Jw7EiFlkUjXMIpK81cqKOpSrogTp44ZUgo82auDJvF3Vjz0xyQa55ycjqgcLI85lBXy7lfsBqnJsxm5fBfwUb7ahQFiSnLZMAVUQ7WqCYa6cAlKzy3X4LJzYEkd1Pf/50oWyRYaheXk+fVmVPGN8NfNXobFTd9FEQnZ9kUOhCvmKN21WdRzUv6GSEp6tMMRgpthAiq6fio9AZtuRWsSarFlTtNCMAJbU/7IW0crPICWsrEjWaaMFfozCEy6Ko4ox2+1J3vV8OLDv1Zadqbw4IV9Jz+Uw7gdvjY/Haqc51KCd3Z6R86sHd5knZ+bZx7ve7gZH7NNUTbg6090+Do3zSoeIjBo7csmkOCI1O6cdKOgVw4HQHuR1SQen+Ve+aviNHQx1psWsTrPKpSV5NUKoKO+kIn/ZJOiAvPp07MMRqtgXG5UvkebEAA2w4W2SIV1XulSo8lqoB41tPTiCXDLdMxAJOkAMh22j2lHfD7suberAnPpiOpURCruhVTHyYFTAKtHg9fnPYgAYO1RtT+bEIV+YqZSlptppWXWm8/bZHaVhSuBvCndd7W0n8ogRoSTv69ROgijkEZ7dp9ODC+FRK3S9Cd1IKLfgmQlkyJklp8RdKAreQqDQ6mVirORlUZ67MEtgd4O6V6uO6bnQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(136003)(376002)(39860400002)(366004)(6916009)(54906003)(83380400001)(26005)(6512007)(478600001)(53546011)(316002)(6506007)(31686004)(186003)(36756003)(31696002)(86362001)(66946007)(4326008)(2616005)(8676002)(66556008)(66476007)(2906002)(8936002)(5660300002)(7416002)(41300700001)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWFRcXEwdjVEVTJ4MW13WTJZYjlidUNWeU9IZnhjdW5wY1RhTllZVjRDSlc1?= =?utf-8?B?MERKdVlrZXBkeG1Ea3lrSVo2WUttSVlnQXFCYThwNEdUeUJKWnNmZmZ3Vjkr?= =?utf-8?B?dFRiT3V2bUk5ZnRGSERkOWdOdHBJMWdBbk1rVk1MSnAyMGI5N0lJL3hHZE1j?= =?utf-8?B?TUdUejhlVFpPT21mUzVocnRXSDczbXNubCtrODJaM1FwcDVsdjFnY2JrOEZB?= =?utf-8?B?SXdzeDhEZThDSHRNcHBMeEdFM2lkRGFveEZFUXI1R3hHYzR5VnpxUHNPR1Fh?= =?utf-8?B?THVrK0hFWmdzN1RQZWsrV2FaMURVZE82TzYrRE82T1ExRXZQYVQxdHpVNCtM?= =?utf-8?B?eTNPdXRyQmdCQlZTMk4xTzg3bjRSaW5sZlp1bGNTK3V4Q2FvRThLeHgzRFNI?= =?utf-8?B?THl4M3kvbkR0b2gxdnZEcFR2Q3FZcmlabnZReWl4WUdnMEs2M0tQL1BiNldM?= =?utf-8?B?V0RpNW53emo1ZXlZU3VybWd3UzllWE9HR0UwR1c5bVZQckMxbW90N01wMnNj?= =?utf-8?B?VVpmTmlrZDdpTEJGTWYvc2o1eVBNRnY5M3hXZmlHWUhCMzFXVjI2RVBUVnFM?= =?utf-8?B?YnJEYzZCY2lSay9YcW9EUHkwWVU0aEdRemNNOVVlNU9DOFl2L2I0QXo5Rnd1?= =?utf-8?B?bVZ4MTd1N09LNzlzOUZubFJrbU5XN2RZWGRzOUJaU0xpVDRoVW54Q3pCc1Fm?= =?utf-8?B?TVVuUUhIUXJ0b2pUUWFUbXdsWVExbjZTL2JlVS9VTjJrVjZUaXFyOHh5bTNV?= =?utf-8?B?VnRCZ3BQQmpIZDFPNUNaTVZ3SDlCa0hZaFZabk51VkY3RTRiVFE2a2pDN29z?= =?utf-8?B?ZmU4NFY5SldMNTJ5ZVZJZkZtMGhuWEFkcXJCZ1UyVzBkVFFqR0RZWGovR2dq?= =?utf-8?B?eFdSZVZ5YUdRRWtQTm1jYVZ0WUtKSWxES0NiMFQvRSttOTJJSVBkdEFodDdW?= =?utf-8?B?RFZwSTc1VlpEdFlIazcxS0R6S2NHTmF3aGNEY3pWZFVFdFhURUNUWUU5ZCtI?= =?utf-8?B?RmRGdWRpN1c1MlMzR2dlOFBLanpDZVliN2ZFN0R5VG44ckgyYlNoS2FtZEVo?= =?utf-8?B?TlFJRHFYR0t5M1RBdjBCbWRBK0dsMndyRlVReVNVaGUzaFpRWHpZbnYvdkNq?= =?utf-8?B?VnVpWm4wNkJURkF3KzNCeUFMeWhuVCtnbVJ0WDRwMDRNbVlDRDgzQ0RzSGNI?= =?utf-8?B?OU9TdktCTzFkR3pKeUpJaWRMTFBIVkxoZGxjMjBFMDIzQVk4amhRMjhaTkxn?= =?utf-8?B?Z3lEeFhTRFM1RUlFYUk4c2RrK3A4d0lmUytzc1Q2RktMcGtjdW1EdStwWmRC?= =?utf-8?B?ZmNGRzFIdTB6SE1SdDlXekpGcEZxRk9xNk5IM2pvSFUrS2VrL05SQmxLY1lL?= =?utf-8?B?K1V0VHNueXo5THFhMUtZK1NqOENYMHdLVHYxWEZudEVTTU5ibHhlTEhuT1lk?= =?utf-8?B?SXZjbDRzeDZwby9uNWlIV2JPRWdicTM4RnV2MjM0dXFmNmU0UG9HODlENWdK?= =?utf-8?B?ckdiazkwcGVJMDg5MnJ1QlRIV1Y1TkZWeFVtWEJzbXlTOXMzaEJVVW9KN1Nv?= =?utf-8?B?VjMySmthSlJuTGd5LzF6RUxwSmtsZmpYS0hvVEcwMGdMZ1k4M2lQODJmL0Zj?= =?utf-8?B?OUN3aHF2R0VoR0c5UnU3NDg5ZXdEQ2Iya0xDVS9kRHlTNW53bUFaQ0d2Vmx5?= =?utf-8?B?RENjWHhITXJsZW1iTnVWRk41N3l4M2syWmdFVUxrd0F6Z3NVWFVaekNKN1lD?= =?utf-8?B?S28zU2gvaXhHUDJOVExSbEpRTzlDcnJpakZESUZaZ3BSQU9XVWpMUVRKdUZG?= =?utf-8?B?NmsrdTZtUDFlYW4ySjQwV2tJaDR3aU9YYWx2bkp4eEtLczJPVGhvRzlRNXBh?= =?utf-8?B?bWRiWjdVMXV3b093OWo4R2FLbWNSZWtSbjU4VnJRTFI4N1IraFpxYmxkY0hl?= =?utf-8?B?eHhORnpOL2RCY3llVFZjMktpUmp1YTNIenlXbVpzYUVNY0l3cjcxRTNFN0Qy?= =?utf-8?B?Zi9NOW52WUk1aDVEVGtFeTRrTkFvbHBDQk5uNE5MY20ycXduUTN4QXhxU1lj?= =?utf-8?B?bWF3VVR1OFZpS1UzM21va3V0cWlGZ0NwYzlieEUrNk5acEUvZ1I1VmgzMkhL?= =?utf-8?Q?OXbrStdr2wkf/smN/OqMkLM1r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 843ee25e-2158-4e8d-8c86-08da90b07483 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 09:07:57.0706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qTAMrpRcyuoqA5k4BKTOIBQA3x+9Kod7wrdxtC8tvCN6RKGayNq8WKK+bF2j79RfgkQQoxrTza60fc1KZZSp1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2480 On 07.09.2022 10:58, Julien Grall wrote: > Hi Jan & Stefano, > > On 06/09/2022 09:53, Jan Beulich wrote: >> On 03.09.2022 02:24, Stefano Stabellini wrote: >>> On Thu, 1 Sep 2022, Rahul Singh wrote: >>>> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >>>> return 0; >>>> } >>>> >>>> +static int is_bar_valid(const struct dt_device_node *dev, >>>> + uint64_t addr, uint64_t len, void *data) >>>> +{ >>>> + struct pdev_bar *bar_data = data; >>>> + unsigned long s = mfn_x(bar_data->start); >>>> + unsigned long e = mfn_x(bar_data->end); >>>> + >>>> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >>>> + bar_data->is_valid = true; >>> >>> >>> This patch looks good and you addressed all Jan's comment well. Before I >>> ack it, one question. >>> >>> I know that you made this change to address Jan's comment but using >>> PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= >>> PFN_UP(addr + len - 1)) check means that we are relaxing the >>> requirements, aren't we? >>> >>> I know that this discussion is a bit pointless because addr and len should >>> always be page aligned, and if they weren't it would be a mistake. > > Hmmm.... Is that requirement written down somewhere? What do you mean here? Isn't it quite obvious that every byte in the address space may only be used for a single purpose? I.e. if a byte is covered by a BAR, it cannot also be covered by a RAM region or yet something else (e.g. MMIO beyond BARs of PCI devices). What happens if BAR and RAM indeed overlap depends on fabric and chipset, but it'll either result in chaos if two parties respond to a single request on the bus, or it'll be (hopefully) deterministic (for any individual system) which of the two takes "precedence". I think we've had a similar discussion a little while ago already in the context of vPCI with guest address space in mind. The same (imo obvious) "rule" spelled out above applies there and here. Jan > The reason I am > asking is "page-aligned" will vary depending on the software. In the > past we had a couple of cases where the region would be 4KB-aligned but > not necessarily 64KB-aligned. > > If the answer is no to my question then... > >> But >>> assuming that they are not page aligned, wouldn't we want this check to >>> be a strict as possible? >>> >>> Wouldn't we want to ensure that the [s,e] range is a strict subset of >>> [addr,addr+len-1] ? If so we would need to do the following instead: >>> >>> if ( (s <= e) && (s >= PFN_UP(addr)) && (e <= PFN_DOWN(addr + len - 1)) ) >>> bar_data->is_valid = true; >> >> But that might mean (in theory at least) a partial overlap, which has >> to be avoided. The only alternative that I see to Rahul's original >> code is to omit use of PFN_DOWN() and PFN_UP() in this construct >> altogether. Assuming that's correct for the passed in (addr,len) >> tuple. > > ... I think we would want to drop PFN_DOWN/PFN_UP here. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 09:14:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 09:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401052.642720 (Exim 4.92) (envelope-from ) id 1oVr8p-0005n1-B9; Wed, 07 Sep 2022 09:14:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401052.642720; Wed, 07 Sep 2022 09:14:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVr8p-0005mu-8O; Wed, 07 Sep 2022 09:14:39 +0000 Received: by outflank-mailman (input) for mailman id 401052; Wed, 07 Sep 2022 09:14:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVr8n-0005mo-KA for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 09:14:37 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e4671ed-2e8d-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 11:14:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2549.eurprd04.prod.outlook.com (2603:10a6:4:31::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 7 Sep 2022 09:14:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 09:14:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e4671ed-2e8d-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/AwbhLLJ7PzPQmj6uCizvVh09kOHePBDHu8Vp/v2oyxtKjWtJW2uHWOiwWid1VOzoKBC1Owho71Tj6QF6j+IhSgpPj37WuYNUTaKpr5K5RCu7nuTZwSjbafhsm+HztTkPjJTqmxGTmJSLWcGKDCar8H2tsfzZdXf7zpV+PN17smnr6lDOrkquwmrZ+4TPSinlGEX+DPdJMygSlNlTU3oiebwWssa/KiNCUjGmfrgSFxrae92JJXiPB4oJK073/YT/C6hvPj8HN1/3yeDtyH7MB+j40Ym6fWgXjKAOIikH7mc83z7bTlgOox1DICPS5ax5MyKbPqFoxefJv1VblSuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJBDFeUPxgfJcf58l/RfdXZoig3p9P9YSHMNrCL7twU=; b=PMOS9iQriwFVAt4c4ksn7+1Xg+MmxRW+3H5j5ZvpOX3GqaI8+w3uLogLuuucwzrzoSiETNFp6YOzvt3qGMIXf8eUobMHhF1oOk67K3z8DhNnD7gxxEgYynoWfAUv/hQxeTBs8174s3rHtVbPyvGm06hnZt0ouAjK1dqa1sJyZEYg6js6pNCSnflosYq9b8jn1RsmNroyqiw/zYz9PxUZaFKDRETmFTqX0Cgy5V+ISXxUXzxOeQMESSrh804Y7YJGHHOANNt+Rghp9rCyqqpFSGA3WWynbD1o8ARyc60SWKS8SbLd0kBOTOsng1IaNqSmUhR6XhEOEiLc4z+Z1jBdcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJBDFeUPxgfJcf58l/RfdXZoig3p9P9YSHMNrCL7twU=; b=UwFnqoexqODukeMtNXnEeS/KN25qKexa6e/qt8xWijBS2NNH3oBvASQIfKqX/4+qWb2eMsg1D+N0X8d7oTPdzMlNNmM9DaPlkfDS6iTbpVa5KGjR2oFHCDAXjMhEhb1Leo4WLTExkRUZQClMd4T/2XEyn4P4wnqgZa9Mt5d+7otbyqzFff0Rlc62Y4QysN6RyOTDMRGRieatV6TVLaIkmNu1iJjlzWwcDLIJ6cJuHn/hqrrgKAcPrdz7iaJWszPxd7eOddEyc573OCINaLAfU8uV4VgR7T7fHeTNsStkEmYaaFiKIGCXf/natQ22Jwc77z5UFURVQi/y++2cWHW+bA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ce7f63c-5ba5-f2cb-8e3e-f6dd2d9d76f7@suse.com> Date: Wed, 7 Sep 2022 11:14:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Content-Language: en-US To: Bertrand Marquis Cc: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Julien Grall References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> From: Jan Beulich In-Reply-To: <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:206:1::40) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB6PR0401MB2549:EE_ X-MS-Office365-Filtering-Correlation-Id: 85b85bf8-d124-4d78-c59e-08da90b161a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yOlL/dZdOzQgL/xn791NwGNKob97+V3XKFrO+uD1cjfkcGpxmW38Wr83q7xvYKXD35ov4B04aQUqdOBvaJ5PeGy+MrKmziq61TmHPa8G1GjhS8wWvhmj4iFmqx/Pmps3571FLo7N/aSVzIs8q11P2bfoTz82UpnLJUAe5S8f5Tb4IZydaIe6k5n9/i1jsksY+sAtYO6WOi7HMWFGnCZp8oN0pT1KFuL5xUZ2defckB2+XRmGezR9lZjJCIBeRrfhRzep0SFDeztSVQX82mkFTRMObqvyOI3pVmAmWokUNEETAsSKJOuHpTwMQAltsi+eaKjzsoioZ1B9uC5jLZzpPOLbfMqeacFQKb0smG0YSeGJ/U6kpjjuThvKI5hGEBvGsAsx/rUCYQMMyTnWSfKYq7dZN7Mc/9NsmC5z9rK1GZWmThpFhAkjKm0SYamODd69I7AyHwDt0uStjrpvjQ85+KIcleHq69xTU0ERWNDc1WKHoz5uZQuZGQO5gQxuPZulaLM7ISC7xh0UshqfMflyKI51HdF5YXbd75HJBwiq0qxcosVYG75/vDQFgeE5Le19lO3yW1J2iiShivCK4m87Z4n5KZcC7wnaE4DdidJ/VE/s1sC/beFO6hbhZvZMG/6sJBy7FJGfFxWSKouDebN34+Dw+BJ0dU1UhpDhD/KZB4Yk4lf6D2CjjHAIQMBO36LP6zQAMW5vpdKKJji8Ld9LTYTf6cxgY4AN8xJnKhZ1vXaTPspwAZ5ELZf+gh2mOZh6ZnjJ9x1aMUHJ9hPc5d8lC86/eYFmmLKm9SMzXL9vE/U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(396003)(136003)(366004)(376002)(5660300002)(8676002)(478600001)(66556008)(66476007)(66946007)(4326008)(6506007)(8936002)(6486002)(6512007)(26005)(41300700001)(2906002)(53546011)(31696002)(31686004)(86362001)(38100700002)(316002)(36756003)(6916009)(54906003)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0hoZWpPR25RTlg0b3ljcGlhY1NrZEhhSjh2N0ZCY3dFdU5vQ1NwUTQyUC81?= =?utf-8?B?NURpVjhhM1pNNnlQR3FQcklpU0FYOGY5aFdCc01GTGFkU2dMUDQ4TnU5MCtn?= =?utf-8?B?K0t0Y3RieVpleVhOd3drcVVBNTdnREIwMkp0U29jNzAwOFlwallwM0JtVkkx?= =?utf-8?B?NFBKWTVSZmMxREdncHJKdWFSY3JQUENWS1FYaGZXakxGZitpZVZ3dk9WaDha?= =?utf-8?B?d0RKYThaVTdiSkN6Qk5tMkZwSUN1N055cFN1bmlVbkRleXYxVVh6b3h3bmtC?= =?utf-8?B?MFBhRXhWcDJzMUxZNHk3YVp1bXFic3NpUytKOTE4czN0QkhwVFpsdkwwZURS?= =?utf-8?B?dXNBUkpJMWJEZDVCQVJYY1Y3T2hpK3hlQWk1ekFFUzJiVVF5TlNtWTBaaytI?= =?utf-8?B?ZGVnS2xZR1ZDR0ZlL1VQNkxmMWxjeGY1RVFTbGVTYTFsenVvQ1lOcHpmVWlp?= =?utf-8?B?WmJabGpVUkJqY1JmR09iUFp4SXNLa3hDcEo0SXFGU1Y4TEMwNmVTeUZPTk1Y?= =?utf-8?B?Ry9OZmtNTk1ha3Z2cWx6eHpqMGVpclZ5WkE3dDhiSFJhYnh1Skw2YXNJMWR3?= =?utf-8?B?SC96ZUFweGtFelFSYkpkczZXdGhHS3BhTWpLWEg5OHNDVGU2M2R2N2plOXo5?= =?utf-8?B?RDhnTjVOMlRNeE1LYlBhRWlXMEcvaEM1VjhSd0tMRmpWcGlOUVFEeGd2U2Jk?= =?utf-8?B?WVlRVHpDK1Exek9IcklpLzhKSDdyRWtYOVNoM1llZjJaeGxhRlJHREJFZzI5?= =?utf-8?B?cEVmelVrN0NoUnBXdWdHelZMOUxuMjNUUmJmRzNqVVM4M2t1ZjVTL0xGOTFY?= =?utf-8?B?NzJrRHBIMlY5NTNaZjBGb0hGZXM1ZlVSVmY4b3FwOVNYU2dwZy90TTVOc1A4?= =?utf-8?B?a2tudERmZ1AxZ2QwTHB2NXJaRmN2V3UrSis2N0daTEpiMlFpMXFFQWtCeGhs?= =?utf-8?B?dEpWT3kzb0JxTUlPYlk0Tnp2U2NvOE8rZmV1OWdiTmYrKzV6cGlWcWc2cXZM?= =?utf-8?B?b0krQ3VjaVo3TUM1cFZrSHJjRWJrQlNSWlhSUjErYzVQZDRweXM4WjdIcTRC?= =?utf-8?B?UmZwR2E4c1YyK0RCV1VPUmJKV3BPVDY2OU5Ba0t2OTFHQnRPWFBob2xtbVMw?= =?utf-8?B?WkwwL0d2alJtMVhiTmFJK2lkL0J2VEtUSm5iaCthRTAyYndoeno5QnBXMkhB?= =?utf-8?B?QzlKZ3cwSG81bmdIdk5TTmdQWStmMkdNS2E0aEVKNkowWThtUE50T1lkMDk1?= =?utf-8?B?azBMenpHWThLMzFxalFMbStONUZraDBzb2hIeUxhV09XR1JqQXFneklVTHZF?= =?utf-8?B?RnRWQ0EzOFE5ejJyY0tUY2MwZlcyRS9QbUw1UTMwc0IrYWtCL0Z1WGVvY3Rx?= =?utf-8?B?eG9PWUNFbFEyc0pacllHZmxzSityV29WQ1hxVkFWMnNDMWhMcnB1Zm1mZ3Za?= =?utf-8?B?T25vUXRRYk5DR0pnSEdrckZjODNhdWRENVRIU2FVbXJJSDE4QTZEV2VLT1ds?= =?utf-8?B?MFFYakdwZDRFamNiK1NEUStSdEZPTkhqOEZtQjU0UjIvRkl1U0owcTU0N2dt?= =?utf-8?B?YjBySG1RZ0MxUlM1aEZJbmJHeVA1M2llM2ovRU5WNXpFWm5CUGNFdCtweUgz?= =?utf-8?B?WTBUV2I3OW4zbm1pM095TnpiVHIxdEF5VjNBUWxGRkhzRDFoWDNZaDVvZVF6?= =?utf-8?B?UU85aDBwMjB0Ty9UZEFPY3U5bkVINWdjaGtkZVNRSThyTTh5V1prYmpzUndM?= =?utf-8?B?UVZmU1oxVzU5dncrTE1BMDM5dGxqeklBOGt0dlQwZWFhNHBmTmxyUmsyOXBn?= =?utf-8?B?OHFIdjV3c0ppYnBiQk1VZ25sZ2tMVU9KZVAxa0VPaER6RVJUcEpydXdoRWFX?= =?utf-8?B?MUczREhybUVDN0ZGckVxNW50Z3lCNk1Geng0dDA5YmZBRkI1Ui9ULzFsV28y?= =?utf-8?B?WlltVVRpbXpBM1ZjTXFqOFlkTmI5UG5xZGpsT3h0NG83UVVnZnAxd3VXVndV?= =?utf-8?B?bDJpUXVadXRPYXdaZ3FRQ1NDTHdncnVoUi9DUU94QzQ4OXZpRk9zcVE0ZzNv?= =?utf-8?B?YnZXTmduaGxnYU43aU5RS2FlblNyUnpHTFgvam5saTh6WFJjRkR0dnlqNTFF?= =?utf-8?Q?wCPwdvFA2Y/hlsLXoKsOptWK0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85b85bf8-d124-4d78-c59e-08da90b161a1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 09:14:34.9043 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rwWw62z73V+5t6YiWi+2+3iuhiSvASXvqOcKDrUBY8SeUm4djD2BV1EFeMAg6qq3Sg2PIzitUdna+MXfvzkosQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2549 On 07.09.2022 10:58, Bertrand Marquis wrote: >> On 7 Sep 2022, at 09:55, Julien Grall wrote: >> On 07/09/2022 09:53, Bertrand Marquis wrote: >>>>> Otherwise if we start adding those kinds of checks, we will have to add them in at least 3 places in xen code. >>>> >>>> The solution I proposed above is easy to implement right now. My gut feeling is tweaking __stringify (or else) will take a bit more time. >>>> >>>> If you (or Leo) can come up with a solution quickly then fine. Otherwise, I think we still want some hardening for backporting purpose. >>> I think a define in compile.h using stringify is the easiest solution: >> >> Ah! I thought you were suggesting to tweak __stringify. This is ... > > Also possible but a bit more tricky > >>> #define XEN_STR_VERSION "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)” > > Quotes at beginning and end should not be there. I have to admit that I dislike the STR infix. I'd prefer a suffixed variant (e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g. XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here, since one might expect that to include XEN_EXTRAVERSION as well then). Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 09:19:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 09:19:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401059.642732 (Exim 4.92) (envelope-from ) id 1oVrDE-0006Xx-TD; Wed, 07 Sep 2022 09:19:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401059.642732; Wed, 07 Sep 2022 09:19:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrDE-0006Xq-QD; Wed, 07 Sep 2022 09:19:12 +0000 Received: by outflank-mailman (input) for mailman id 401059; Wed, 07 Sep 2022 09:19:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrDD-0006Xk-EU for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 09:19:11 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2086f2b0-2e8e-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 11:19:09 +0200 (CEST) Received: from BN9PR03CA0338.namprd03.prod.outlook.com (2603:10b6:408:f6::13) by PH0PR12MB5606.namprd12.prod.outlook.com (2603:10b6:510:141::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 09:19:05 +0000 Received: from BN8NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::b3) by BN9PR03CA0338.outlook.office365.com (2603:10b6:408:f6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 09:19:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT056.mail.protection.outlook.com (10.13.177.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 09:19:04 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 04:19:02 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 04:19:01 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2086f2b0-2e8e-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTbWXUXMAnsiWmvgABQp40E0J8mC5hTr87JO95eszGApjd8hIeVqUuIDSnT/klkzANf4XUwy7buo02+3k+gezhfPbVigyYTtbRzB0Y/dfjQCYmLaSjK0Uz/svzyBubM9I2nkR1nQfMvNNVhtlFlUGvxWlhL9IOvTnJnx2IeevV77XBaBVEQ+bl4PMOlAmxIRJAgOX1b09cGRmmr8mvjq3X+WESfEfvaK1oXXDlumqyahML1pXYLO5EQzfZQLYslpkK4qsiEl6YyHwN0znMJdflE/b7ViMIIK/AYqrXXwbN20gIYgLuQE7Z6jpqMkx5ljW2mOl8lajtfTJ0uxvAYLtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OMkUD4kdRzoyJFP3dJbCO2HK4yhpZNDxiqLu8+myk/c=; b=RJZE1dhtHhy+MBb+MfTYLOynd1cv5cKVbhiOD0BZRVpSDyWv9/K92jmhXrVqEBsQ8Mke0xEa5dZNfayAzoScd5HKOkOm+j+WNhRRacohi2PeLz9ctoES4nMAi3Qjo0j9Nw6S7LZJ3ctBIY3n/+iR7N/Opg0Jl5ijFc7rLPmKPSgDDuW9yUy3u+9qkbRgHWbmooLyQblEejqH13XZdYG/a0RPEt6KzDH/LlwKrzJ6Q39x7/3PM6zRnarhoBwbXOnB2JRHlxfX0fpy1ttrBcum6xPgkxMN3HhF60fmvArLQ+OS726zeXdvMKIUhsf0VEihiLpr7Wgc2BAU5th5Qqf/FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMkUD4kdRzoyJFP3dJbCO2HK4yhpZNDxiqLu8+myk/c=; b=jJqFWFJT6TNqBmeq0kOlaKkYiOrRBQBUBIJb9xB/+S+epElLbGaL0oDa2F8eKdH7e2up93DN3K0uSVdtxWw7EKylYT7s7BrUwuZyc43JE30z5FND6GKsbmPepq/NcsIpqG1ASsmIRt7f587Yvf81HsphjxyJuR3PbbHx9zgbxbc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 7 Sep 2022 11:19:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int Content-Language: en-US To: Henry Wang , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-2-Henry.Wang@arm.com> From: Michal Orzel In-Reply-To: <20220907083643.20152-2-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT056:EE_|PH0PR12MB5606:EE_ X-MS-Office365-Filtering-Correlation-Id: b14c7c00-ba6b-4dab-d54e-08da90b20285 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nsDG4iuMe4ExgLWUc532ckspYK+zBFmO3OGjWQcS107eZAChzv53sZ1WWqn4wMgAIgFo7XaxSJXBgAj2bX3uGQhjSq27dXnnWAuxR688+3+t87dN1z5U0UH+Ism/dsf1VOWE315bwjsyHIJpcxNzy58jj+weCWvTH1ikJjKwJNNnk3KhH7CwvJaB+xvqo3vqwMnWshm3sG78gSapYn0DXtPvLhZ7ErP8hHgHWDX92y5vb2SGtsGFUshy/Wo99MHUL9FI7UJQZx6yObTeicRoSzAqNfL/obUSZYme6qvGETyNLBmSO1aa5gckyUELLEAQDO6pmb1RnOvOTxvfWRYDKnABcWeoZd6CaS+wpkBAp21bdD3Dha8kd+PIA36JQBo1B19Iy/tvDfNcrqg7BxnPrw+N3tTISC9xrTqlbeGvp4oNAY/ashlT4IdxD+80sXfmhYVzLnOWPjCsRulXLKzjN9j1diojBR/xNOnwd3azFb5XAluRGOI5bXpKXv2D5U4zqIp6VqwW1iIkt72qZUwT/e+QlOhiCeAwDLShXXcM5yVF8ievXJI9jj75eNgp3qFBtDKDMGbVR/WF5h7MWHNXwpWfM+9pJgZ5Di0JOwNZXANfMwTPLc+X+rFsE/PMDEJIQeRgqd0p8HErIH9ePlrr0QuQRI+E3FIwq9LMyzp1Sq2aKtkrZp0qucYAElYGuA/WSLt4dGtW+j4EZ0GaEles7xqKIbqdhbbjihPhV9nQHKbVSxHSiBOVzjxUV1rKYXUH3+z4AnA+sBBUylHZ2JIiuZI7D+ZTJONTxAFDk/qsD97/R1RNEkyG4yizPAs2hD8M+CtaxDPJrnzD//nE4UBnFQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(46966006)(40470700004)(36840700001)(31696002)(36860700001)(70586007)(356005)(82740400003)(110136005)(16576012)(82310400005)(8676002)(70206006)(4326008)(316002)(54906003)(40460700003)(81166007)(2906002)(336012)(4744005)(40480700001)(44832011)(426003)(5660300002)(2616005)(8936002)(53546011)(47076005)(186003)(41300700001)(478600001)(31686004)(86362001)(26005)(36756003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 09:19:04.6625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b14c7c00-ba6b-4dab-d54e-08da90b20285 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5606 Hi Henry, On 07/09/2022 10:36, Henry Wang wrote: > > At the boot time, it is saner to stop booting early if an error occurs > when parsing the device tree chosen node, rather than seeing random > behavior afterwards. Therefore, this commit changes the return type of > the process_chosen_node() from void to int, and return correct errno > based on the error type. > > Signed-off-by: Henry Wang Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Wed Sep 07 09:21:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 09:21:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401066.642743 (Exim 4.92) (envelope-from ) id 1oVrF6-0007u9-8Y; Wed, 07 Sep 2022 09:21:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401066.642743; Wed, 07 Sep 2022 09:21:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrF6-0007u2-4W; Wed, 07 Sep 2022 09:21:08 +0000 Received: by outflank-mailman (input) for mailman id 401066; Wed, 07 Sep 2022 09:21:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrF4-0007to-Hc; Wed, 07 Sep 2022 09:21:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrF4-0001VU-EF; Wed, 07 Sep 2022 09:21:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrF4-0008IG-58; Wed, 07 Sep 2022 09:21:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVrF4-0002wS-4g; Wed, 07 Sep 2022 09:21:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XOjLIwbvV6ah5H1TDRkCS6tIN/YuZ+RG1pvYD+mo474=; b=cFFkILCryvJn2dr2vO4lh8V3WH K9wDMzZgwOKtQ/yxOLYYl8nhLx1mSjHOVKNAKH3onnIfkPFE69PrBP+zyvM85xQZPGsAJGYcqFaVm +yKszY9h5XSUyFoiS11fxhObhXjMhNxtK98Ze6vJ0KJ2lPda+r2GCEkIpzuxJPpeFljo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173038: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=3d35a6c243ffe749a2ae71d5d72ce0361f168f49 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 09:21:06 +0000 flight 173038 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173038/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 3d35a6c243ffe749a2ae71d5d72ce0361f168f49 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 34 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 259 attempts Testing same since 173036 2022-09-07 04:41:49 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2102 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 09:35:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 09:35:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401076.642757 (Exim 4.92) (envelope-from ) id 1oVrTM-0001BF-FG; Wed, 07 Sep 2022 09:35:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401076.642757; Wed, 07 Sep 2022 09:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrTM-0001B8-CG; Wed, 07 Sep 2022 09:35:52 +0000 Received: by outflank-mailman (input) for mailman id 401076; Wed, 07 Sep 2022 09:35:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrTK-0001Az-M5 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 09:35:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 750fb2df-2e90-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 11:35:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD16433C13; Wed, 7 Sep 2022 09:35:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8909313486; Wed, 7 Sep 2022 09:35:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id leEbIPRlGGPRMgAAMHmgww (envelope-from ); Wed, 07 Sep 2022 09:35:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 750fb2df-2e90-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662543348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rF+JRcok4JLZUfPKvKMuN4lbYAZA0bciyAcxX7wvPcA=; b=GtUt7sr3g6bZHyWSvvnxlZqTDuo4pPGUapwxQ9iIwUxbUWJrjoTc0HpikTPCtkziPSBIT9 sA8ABNIa60BW+8wlj0uAKO8z3XIylz+t2Cokj/67BgkOcpU9di5J1+0L9sB135o+SBw9Th LJG0ogWL2wU7TzSF77JO15Ngp2SIBW4= Message-ID: <4830f09f-71f3-6705-1b05-ad7983896b18@suse.com> Date: Wed, 7 Sep 2022 11:35:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-5-jgross@suse.com> <48bdfa39-ce5a-6d48-0bb4-8a0270e181c9@suse.com> <1410d4ef-7b9a-6567-74f1-f900602f5d8f@xen.org> From: Juergen Gross Subject: Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features In-Reply-To: <1410d4ef-7b9a-6567-74f1-f900602f5d8f@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------eHeiiCBhJaOGD6XHzb0eUpQy" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------eHeiiCBhJaOGD6XHzb0eUpQy Content-Type: multipart/mixed; boundary="------------UYLZzqWbJSRKsLNNktEGUerZ"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: <4830f09f-71f3-6705-1b05-ad7983896b18@suse.com> Subject: Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features References: <20220905124746.1975-1-jgross@suse.com> <20220905124746.1975-5-jgross@suse.com> <48bdfa39-ce5a-6d48-0bb4-8a0270e181c9@suse.com> <1410d4ef-7b9a-6567-74f1-f900602f5d8f@xen.org> In-Reply-To: <1410d4ef-7b9a-6567-74f1-f900602f5d8f@xen.org> --------------UYLZzqWbJSRKsLNNktEGUerZ Content-Type: multipart/mixed; boundary="------------aKi3u2ckzrqiwx7qsLDX53dh" --------------aKi3u2ckzrqiwx7qsLDX53dh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMDkuMjIgMTA6NDQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA3LzA5LzIwMjIgMDc6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAwNi4wOS4yMiAxOToyNywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s DQo+Pj4NCj4+PiBPbiAwNS8wOS8yMDIyIDEzOjQ3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+PiBFeHRlbmQgdGhlIGRlZmluaXRpb24gb2YgdGhlIFhlbnN0b3JlIG1pZ3JhdGlvbiBz dHJlYW0gdG8gY292ZXIgbmV3DQo+Pj4+IGZlYXR1cmVzOg0KPj4+Pg0KPj4+PiAtIHBlciBk b21haW4gZmVhdHVyZXMNCj4+Pj4gLSBleHRlbmRlZCB3YXRjaGVzICh3YXRjaCBkZXB0aCkN Cj4+Pj4gLSBwZXIgZG9tYWluIHF1b3RhDQo+Pj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IFYzOg0KPj4+ PiAtIG5ldyBwYXRjaA0KPj4+PiBWNDoNCj4+Pj4gLSBhZGQgbmV3IHJlY29yZCB0eXBlcyBp bnN0ZWFkIG9mIG1vZGlmeWluZyB0aGUgZXhpc3Rpbmcgb25lcw0KPj4+PiDCoMKgIChKdWxp ZW4gR3JhbGwpDQo+Pj4+IC0tLQ0KPj4+PiDCoCBkb2NzL2Rlc2lnbnMveGVuc3RvcmUtbWln cmF0aW9uLm1kIHwgMTYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKystDQo+Pj4+IMKg IDEgZmlsZSBjaGFuZ2VkLCAxNTUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCj4+ Pj4NCj4+Pj4gZGlmZiAtLWdpdCBhL2RvY3MvZGVzaWducy94ZW5zdG9yZS1taWdyYXRpb24u bWQgDQo+Pj4+IGIvZG9jcy9kZXNpZ25zL3hlbnN0b3JlLW1pZ3JhdGlvbi5tZA0KPj4+PiBp bmRleCBlZmE1MjZmNDIwLi5jNzA1MDVjNDNhIDEwMDY0NA0KPj4+PiAtLS0gYS9kb2NzL2Rl c2lnbnMveGVuc3RvcmUtbWlncmF0aW9uLm1kDQo+Pj4+ICsrKyBiL2RvY3MvZGVzaWducy94 ZW5zdG9yZS1taWdyYXRpb24ubWQNCj4+Pj4gK3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+Pj4+ICt8 IGBxdW90YS1uYW1lc2DCoCB8IDAgZGVsaW1pdGVkIHN0cmluZ3Mgb2YgdGhlIHF1b3RhIG5h bWVzIGluwqDCoMKgIHwNCj4+Pj4gK3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg fCB0aGUgc2FtZSBzZXF1ZW5jZSBhcyB0aGUgYHF1b3RhLXZhbGAgdmFsdWVzLiB8DQo+Pj4+ ICsNCj4+Pj4gKw0KPj4+PiArQWxsb3dlZCBxdW90YSBuYW1lcyBhcmUgdGhvc2UgZXhwbGlj aXRseSBuYW1lZCBpbiBbMl0gZm9yIHRoZSBgR0VUX1FVT1RBYA0KPj4+PiArYW5kIGBTRVRf UVVPVEFgIGNvbW1hbmRzLCBwbHVzIGltcGxlbWVudGF0aW9uIHNwZWNpZmljIG9uZXMuIFF1 b3RhIG5hbWVzIG5vdA0KPj4+PiArcmVjb2duaXplZCBieSB0aGUgcmVjZWl2aW5nIHNpZGUg bXVzdCBiZSBpZ25vcmVkLg0KPiANCj4gLi4uIHRoaXMgaXMgc2VlbSB0byBkaXJlY3RseSBj b25mbGljdCB3aXRoIHRoaXMgc2VudGVuY2UgYXMgdG8gbWUgImlnbm9yZSIgbWVhbnMgDQo+ IGRyb3AuIFdoYXQgeW91IHdhbnQgaXMgZm9yIFhlbnN0b3JlIHRvIG9wdGlvbmFsbHkgcHJl c2VydmUuDQoNCkknbGwgcmVwaHJhc2UgdGhhdC4NCg0KPiANCj4gQWxzbywgSSB0aGluayB3 aGF0IHlvdSB3cm90ZSBhYm92ZSB3b3VsZCBiZSBoZWxwZnVsIGluIHRoZSBjb21taXQgbWVz c2FnZS4gSXQgDQo+IGdpdmVzIHNvbWUgaW5zaWdodHMgZm9yIGZ1dHVyZSByZWFkZXIgb24g aG93IHRoZSBzdHJlYW0gd2FzIGRlc2lnbmVkLg0KDQpPa2F5Lg0KDQo+IA0KPj4+PiArDQo+ Pj4+ICtccGFnZWJyZWFrDQo+Pj4+ICsNCj4+Pj4gKyMjIyBET01BSU5fREFUQQ0KPj4+PiAr DQo+Pj4+ICtUaGlzIHJlY29yZCBpcyBvcHRpb25hbCBhbmQgY2FuIGJlIHByZXNlbnQgb25j ZSBmb3IgZWFjaCBkb21haW4uDQo+Pj4+ICsNCj4+Pj4gKw0KPj4+PiArYGBgDQo+Pj4+ICvC oMKgwqAgMMKgwqDCoMKgwqDCoCAxwqDCoMKgwqDCoMKgIDLCoMKgwqDCoMKgwqAgM8KgwqDC oMKgIG9jdGV0DQo+Pj4+ICsrLS0tLS0tLSstLS0tLS0tKy0tLS0tLS0rLS0tLS0tLSsNCj4+ Pj4gK3wgZG9tYWluLWlkwqDCoMKgwqAgfCBuLXF1b3RhwqDCoMKgwqDCoMKgIHwNCj4+Pj4g KystLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tKw0KPj4+PiArfCBmZWF0dXJlc8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+Pj4+ICsrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4+Pj4gK3wgcXVvdGEtdmFsIDHCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4+PiArKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0rDQo+Pj4+ICsuLi4NCj4+Pj4gKystLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tKw0KPj4+PiArfCBxdW90YS12YWwgTsKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+Pj4+ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLSsNCj4+Pj4gK3wgcXVvdGEtbmFtZXMNCj4+Pj4gKy4uLg0KPj4+PiArYGBg DQo+Pj4+ICsNCj4+Pj4gKw0KPj4+PiArfCBGaWVsZMKgwqDCoMKgwqDCoMKgwqDCoCB8IERl c2NyaXB0aW9uwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+Pj4gK3wtLS0tLS0tLS0tLS0tLS0tfC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS18DQo+Pj4+ICt8IGBk b21haW4taWRgwqDCoMKgIHwgVGhlIGRvbWFpbi1pZCBvZiB0aGUgZG9tYWluIHRoaXMgcmVj b3JkwqDCoMKgwqDCoCB8DQo+Pj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHwgYmVsb25ncyB0by7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0KPj4+PiArfMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwN Cj4+Pj4gK3wgYG4tcXVvdGFgwqDCoMKgwqDCoCB8IE51bWJlciBvZiBxdW90YSB2YWx1ZXMu wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+Pj4gK3zC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB8DQo+Pj4+ICt8IGBmZWF0dXJlc2DCoMKgwqDCoCB8IFZhbHVlIG9m IHRoZSBmZWF0dXJlIGZpZWxkIHZpc2libGUgYnkgdGhlwqDCoMKgIHwNCj4+Pj4gK3zCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCBndWVzdCBhdCBvZmZzZXQgMjA2NCBvZiB0 aGUgcmluZyBwYWdlLsKgwqDCoMKgwqDCoCB8DQo+Pj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHwgQWxpZ25lZCB0byB0aGUgbmV4dCA0IG9jdGV0IGJvdW5kYXJ5LsKg wqDCoMKgwqDCoMKgIHwNCj4+Pg0KPj4+IFN0YWxlIHNlbnRlbmNlPw0KPj4NCj4+IE9oIHll cywgYSBzdXJ2aXZvciBvZiBWMy4NCj4+DQo+Pj4NCj4+Pj4gK3zCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgfCBPbmx5IHZhbGlkIGZvciB2ZXJzaW9uIDIgYW5kIGxhdGVyLsKg wqDCoMKgwqDCoMKgwqDCoCB8DQo+Pj4NCj4+PiBDYW4geW91IG1lbnRpb24gZXhwbGljaXRs eSB3aGV0aGVyIHRoZSBmaWVsZCB3aWxsIHVua25vd24gb3IgMCBmb3IgdmVyc2lvbiAxPw0K Pj4NCj4+IFdlIGhhdmUgdGhlIGdlbmVyYWwgbm90ZSAicGFkZGluZyBvY3RldHMgaGVyZSBh bmQgaW4gYWxsIHN1YnNlcXVlbnQgZm9ybWF0DQo+PiBzcGVjaWZpY2F0aW9ucyBtdXN0IGJl IHdyaXR0ZW4gYXMgemVybyIuIEkgdGhpbmsgdGhpcyBzaG91bGQgc3VmZmljZS4NCj4gDQo+ IEkgZG9uJ3QgdmlldyB0aGlzIGZpZWxkIGFzIHBhZGRpbmcgYmVjYXVzZSBpdCBoYXMgYSBt ZWFuaW5nLiBTbyBJIGFyZ3VlIGl0IGlzIA0KPiBub3QgY292ZXIgYnkgdGhlIHNlbnRlbmNl Lg0KDQpJJ2xsIHJlcGhyYXNlIHRoYXQgdG86ICJwYWRkaW5nIG9jdGV0cyBvciBmaWVsZHMg bm90IHZhbGlkIGluIHRoZSB1c2VkIHZlcnNpb24NCmhlcmUgYW5kIGluIGFsbCAuLi4iDQoN Cj4gDQo+IFRoZXJlZm9yZSBJIHdvdWxkIGFkZCAiT3RoZXJ3aXNlLCB0aGUgZmllbGQgaXMg dW5rbm93bi8wIiAocGljayB0aGUgb25lIHlvdSANCj4gcHJlZmVyIGJldHdlZW4gMCBhbmQg dW5rbm93bikuDQo+IA0KPj4NCj4+Pg0KPj4+PiArfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+Pj4g K3wgYHF1b3RhLXZhbGDCoMKgwqAgfCBRdW90YSB2YWx1ZXMsIGEgdmFsdWUgb2YgMCBoYXMg dGhlIHNlbWFudGljcyB8DQo+Pj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHwgInVubGltaXRlZCIuwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8DQo+Pj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfA0K Pj4+PiArfCBgcXVvdGEtbmFtZXNgwqAgfCAwIGRlbGltaXRlZCBzdHJpbmdzIG9mIHRoZSBx dW90YSBuYW1lcyBpbsKgwqDCoCB8DQo+Pj4+ICt8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHwgdGhlIHNhbWUgc2VxdWVuY2UgYXMgdGhlIGBxdW90YS12YWxgIHZhbHVlcy4g fA0KPj4+PiArDQo+Pj4+ICtBbGxvd2VkIHF1b3RhIG5hbWVzIGFyZSB0aG9zZSBleHBsaWNp dGx5IG5hbWVkIGluIFsyXSBmb3IgdGhlIGBHRVRfUVVPVEFgDQo+Pj4+ICthbmQgYFNFVF9R VU9UQWAgY29tbWFuZHMsIHBsdXMgaW1wbGVtZW50YXRpb24gc3BlY2lmaWMgb25lcy4gUXVv dGEgbmFtZXMgbm90DQo+Pj4+ICtyZWNvZ25pemVkIGJ5IHRoZSByZWNlaXZpbmcgc2lkZSBt dXN0IGJlIGlnbm9yZWQuDQo+Pj4+ICsNCj4+Pj4gK1xwYWdlYnJlYWsNCj4+Pj4gKw0KPj4+ PiArIyMjIFdBVENIX0RBVEFfRVhURU5ERUQNCj4+Pg0KPj4+IE5JVDogSSB0aGluayBpdCB3 b3VsZCBiZSBtb3JlIGxvZ2ljYWwgaWYgdGhpcyBpcyBkZWZpbmVkIHJpZ2h0IG5leHQgYWZ0 ZXIgDQo+Pj4gV0FUQ0hfREFUQS4NCj4+DQo+PiBJIHdhcyBmb2xsb3dpbmcgdGhlIHJlY29y ZCB0eXBlIG51bWJlcmluZywgYnV0IEkgY2FuIG1vdmUgdGhpcyByZWNvcmQNCj4+IGRlc2Ny aXB0aW9uIHVwIGlmIHlvdSBsaWtlIHRoYXQgYmV0dGVyLg0KPj4NCj4+Pg0KPj4+PiArDQo+ Pj4+ICtUaGUgaW1hZ2UgZm9ybWF0IHdpbGwgY29udGFpbiBlaXRoZXIgYSBgV0FUQ0hfREFU QWAgb3IgYSBgV0FUQ0hfREFUQV9FWFRFTkRFRGANCj4+Pj4gK3JlY29yZCBmb3IgZWFjaCB3 YXRjaCByZWdpc3RlcmVkIGJ5IGEgY29ubmVjdGlvbiBmb3Igd2hpY2ggdGhlcmUgaXMNCj4+ Pj4gK2BDT05ORUNUSU9OX0RBVEFgIHJlY29yZCBwcmV2aW91c2x5IHByZXNlbnQuIFRoZSBg V0FUQ0hfREFUQV9FWFRFTkRFRGAgcmVjb3JkDQo+Pj4+ICt0eXBlIGlzIHZhbGlkIG9ubHkg aW4gdmVyc2lvbiAyIGFuZCBsYXRlci4NCj4+Pj4gKw0KPj4+PiArYGBgDQo+Pj4+ICvCoMKg wqAgMMKgwqDCoMKgwqDCoCAxwqDCoMKgwqDCoMKgIDLCoMKgwqDCoMKgwqAgM8KgwqDCoCBv Y3RldA0KPj4+PiArKy0tLS0tLS0rLS0tLS0tLSstLS0tLS0tKy0tLS0tLS0rDQo+Pj4+ICt8 IGNvbm4taWTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 DQo+Pj4+ICsrLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLSsNCj4+Pj4gK3wgd3Bh dGgtbGVuwqDCoMKgwqAgfCB0b2tlbi1sZW7CoMKgwqDCoCB8DQo+Pj4+ICsrLS0tLS0tLS0t LS0tLS0tKy0tLS0tLS0tLS0tLS0tLSsNCj4+Pj4gK3wgZGVwdGjCoMKgwqDCoMKgwqDCoMKg IHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwNCj4+Pj4gKystLS0tLS0tLS0tLS0t LS0rLS0tLS0tLS0tLS0tLS0tKw0KPj4+DQo+Pj4gSXQgaXMgbm90IGNsZWFyIHdoYXQgd291 bGQgYmUgdGhlIHZhbHVlIG9mIG9jdGV0IDItMy4gSXMgaXQgUkVTMCBvciBVTktOT1dOPw0K Pj4NCj4+IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGUgcXVlc3Rpb24uIGNvbm4taWQgaXMgYSA0 LWJ5dGUgaXRlbS4NCj4gDQo+IEkgd2FzIHJlZmVycmluZyB0byB0aGUgYmxhbmsgYWZ0ZXIg J2RlcHRoJy4gSW4gb3RoZXIgcmVjb3JkLCB3ZSB1c2UgJ3BhZCcuDQoNCk9rYXksIHdpbGwg YWRkICJwYWQiIHRvIGl0Lg0KDQoNCkp1ZXJnZW4NCg== --------------aKi3u2ckzrqiwx7qsLDX53dh Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------aKi3u2ckzrqiwx7qsLDX53dh-- --------------UYLZzqWbJSRKsLNNktEGUerZ-- --------------eHeiiCBhJaOGD6XHzb0eUpQy Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMYZfQFAwAAAAAACgkQsN6d1ii/Ey8d 8wf/cYNU8tLdxC98ndq8r1yfXUt0UXvmC3o7shlv79XLflEKLdm1WfyfYq8mEacyNOYmpbSFE3uT LOP5eOVj5y6knJDnI4pfWd2QfZ57VmfdlB7VPq/fSQzap/ewOzWzW8n0VJxCpxdmOAjD0yJFOau7 I44xpyRZUfgu3E5pY+WILxLwD99p4049yffpVhPwC4aVR6Wu4EQR0gEeF1EZ7HmyrGy3M2YOPEGZ Nj5/JWdaQr0ffKt5rkB8aak9Q9906IUty4bOqmGb1u6k4uKVJ0rDdE2j+N2XdrZYgK/iDePq10Ev opIpbXRGZSR7tETkc4a/TN7r7nW4sMNo7Xls9RiULA== =5+BD -----END PGP SIGNATURE----- --------------eHeiiCBhJaOGD6XHzb0eUpQy-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:00:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401086.642771 (Exim 4.92) (envelope-from ) id 1oVrr1-0004rG-JV; Wed, 07 Sep 2022 10:00:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401086.642771; Wed, 07 Sep 2022 10:00:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrr1-0004r9-Gb; Wed, 07 Sep 2022 10:00:19 +0000 Received: by outflank-mailman (input) for mailman id 401086; Wed, 07 Sep 2022 10:00:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrr0-0004qx-ES for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:00:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrqz-0002H3-6h; Wed, 07 Sep 2022 10:00:17 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVrqy-00017h-Vy; Wed, 07 Sep 2022 10:00:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=01sTJv9s8cMsrxFQezEUOVb84aDJtuUIj5Co7/XMLUI=; b=2tg4Yhu9alYXItEw63mIlxJPme 3n2wOeAKuQsERTWUOJgInCdxBN7A2yl249kZu441rEWftPEnkqAtTjFnu3KFOgrIX6a0+xp7FyiC2 NsiImVp6FOkOWaAnx5304ZSvU6YR3qx9GuAC2dKgs9UyEZId6j34ybrsQRKkDfRfTfrk=; Message-ID: <4f070d84-a732-3166-ad6c-2c15e6cfc882@xen.org> Date: Wed, 7 Sep 2022 11:00:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Jan Beulich Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Rahul Singh , Stefano Stabellini References: <5948f099-7287-2743-aa24-3c7a17033877@xen.org> <4ac67001-9406-6cac-b032-b6cbefb598b5@suse.com> From: Julien Grall In-Reply-To: <4ac67001-9406-6cac-b032-b6cbefb598b5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 07/09/2022 10:07, Jan Beulich wrote: > On 07.09.2022 10:58, Julien Grall wrote: >> Hi Jan & Stefano, >> >> On 06/09/2022 09:53, Jan Beulich wrote: >>> On 03.09.2022 02:24, Stefano Stabellini wrote: >>>> On Thu, 1 Sep 2022, Rahul Singh wrote: >>>>> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >>>>> return 0; >>>>> } >>>>> >>>>> +static int is_bar_valid(const struct dt_device_node *dev, >>>>> + uint64_t addr, uint64_t len, void *data) >>>>> +{ >>>>> + struct pdev_bar *bar_data = data; >>>>> + unsigned long s = mfn_x(bar_data->start); >>>>> + unsigned long e = mfn_x(bar_data->end); >>>>> + >>>>> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >>>>> + bar_data->is_valid = true; >>>> >>>> >>>> This patch looks good and you addressed all Jan's comment well. Before I >>>> ack it, one question. >>>> >>>> I know that you made this change to address Jan's comment but using >>>> PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= >>>> PFN_UP(addr + len - 1)) check means that we are relaxing the >>>> requirements, aren't we? >>>> >>>> I know that this discussion is a bit pointless because addr and len should >>>> always be page aligned, and if they weren't it would be a mistake. >> >> Hmmm.... Is that requirement written down somewhere? > > What do you mean here? Isn't it quite obvious that every byte in the > address space may only be used for a single purpose? I.e. if a byte > is covered by a BAR, it cannot also be covered by a RAM region or > yet something else (e.g. MMIO beyond BARs of PCI devices). What > happens if BAR and RAM indeed overlap depends on fabric and chipset, > but it'll either result in chaos if two parties respond to a single > request on the bus, or it'll be (hopefully) deterministic (for any > individual system) which of the two takes "precedence". I am well aware about that and I am not sure how you implied this is what I was referring to from what I wrote (in particular if you read the next sentence). Stefano wrote that it would be a mistake if the address/length is not page-aligned. However, I am not aware from such requirement written down. It seems to be more an expected common sense that was IIRC not always respected on HW supporting multiple page-granularity. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:03:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:03:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401094.642782 (Exim 4.92) (envelope-from ) id 1oVrts-0005Sn-2M; Wed, 07 Sep 2022 10:03:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401094.642782; Wed, 07 Sep 2022 10:03:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrtr-0005Sg-VA; Wed, 07 Sep 2022 10:03:15 +0000 Received: by outflank-mailman (input) for mailman id 401094; Wed, 07 Sep 2022 10:03:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrtq-0005Sa-BA for xen-devel@lists.xen.org; Wed, 07 Sep 2022 10:03:14 +0000 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [2607:f8b0:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47a0646b-2e94-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:03:13 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id c198so4241518pfc.13 for ; Wed, 07 Sep 2022 03:03:11 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id e2-20020aa79802000000b0053e468a78a8sm3086093pfl.158.2022.09.07.03.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 03:03:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47a0646b-2e94-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=3xfU7QSmwgcKmCVLKintC697OWHrXLzPEQ6qLjpHYZA=; b=tjoLDV/UZqNlj8O5brq2Hj8H4N8+FsMaiYNrNcx6WYfLG5xDNDUNQR7WhPCOsDIvpV uKHoZNVjHCKOgRx/dZo4oybp5SN5uBwYNsu0ql+d3jjCO5kPGX2I49y0QV727DZnURRu STICCzRNxIYuILK3B1a7haKp6GEL1+FPaAN0+xsa6FSLu/tsiTW71pIc9G9KEI6K/stD as5/aXUROn8vm6un/zM7wVQNDkupC0k42c2SxaoNtxTBF/cBme5KvuLWsFCUIRgTnZRD FPZd31Rab79/GxAX8fE04zsLUbborbD0UBY3CUqNCeXRULnHagE8TOCN2nNNhVSRi1Bx VaRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=3xfU7QSmwgcKmCVLKintC697OWHrXLzPEQ6qLjpHYZA=; b=qWsSU2MwcQP0ZwTnTSUzN6992QRhKrljbzy1D1s889lsZeBgm1PQQthMjxGCcIqpUe qJujko1Lgk2YknXnubxfnzhRzr7f5ZVIShsUQB2APd71KfEVl+ON0TJ0JhKOmSDC5Cy7 hVfvb7kzMaWVPbavWEz9054wXlelk367voeuQAdYgv13V0HTuWrHFTsGw+6FSsLo1GhB 58gTLpRpM624QomGFE86dszDrVFTP77P4ZVJK1Ht1pG0Xp/NSMc/uPw86ulBfrKerSsg ycIkZA52DilTqlFsTEmmAKCNA8xQtbWaO4lmQm/cHTgywyZ8vAXHaV/1Plyj79i8bceo Lw+A== X-Gm-Message-State: ACgBeo0rdvN7NJM5VBoMq06SNRGUeQ+85ycV9p94r9aDb8FOEjjmqtBs DNfrit7HvTgT0cPOB5lF65P2lUlw/ANngw== X-Google-Smtp-Source: AA6agR7K1kj4W9OyjjZMgrIMpyDYOkvyq4cYeq7qtT+hEwza2jaU6sryAO3P43mkQHGm9uLwoQhtNA== X-Received: by 2002:a63:5201:0:b0:434:d865:3335 with SMTP id g1-20020a635201000000b00434d8653335mr2788951pgb.478.1662544990402; Wed, 07 Sep 2022 03:03:10 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar Subject: [PATCH] .gitignore: Add init-dom0less Date: Wed, 7 Sep 2022 15:33:01 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add tools/helpers/init-dom0less to gitignore. Signed-off-by: Viresh Kumar --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 27881c976432..9f9f18c97d5f 100644 --- a/.gitignore +++ b/.gitignore @@ -170,6 +170,7 @@ tools/flask/utils/flask-setenforce tools/flask/utils/flask-set-bool tools/flask/utils/flask-label-pci tools/helpers/init-xenstore-domain +tools/helpers/init-dom0less tools/helpers/xen-init-dom0 tools/hotplug/common/hotplugpath.sh tools/hotplug/FreeBSD/rc.d/xencommons -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:05:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:05:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401101.642793 (Exim 4.92) (envelope-from ) id 1oVrwO-00063s-EZ; Wed, 07 Sep 2022 10:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401101.642793; Wed, 07 Sep 2022 10:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwO-00063l-Bv; Wed, 07 Sep 2022 10:05:52 +0000 Received: by outflank-mailman (input) for mailman id 401101; Wed, 07 Sep 2022 10:05:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwM-00063c-LG for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:05:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwM-0002Mu-CE; Wed, 07 Sep 2022 10:05:50 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVrwM-0001K3-57; Wed, 07 Sep 2022 10:05:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8+p+6F/gV+1wEgBnS1/386cg6eA4og+z2f8gmL4oLgo=; b=oeFoo9gUOSqBlR22nKVvlQawAt TWhumSGXSDpZDET0rBB58G7c1mmoa1i21hRn4vAXctmrU8IoETTh60h0pfLM5MDIAi+yojPnljHC+ mfc25e7t9wpPfBLm3PPuYGBjtYd7Qw7sUWRIu7OtogrljBl7lFE3jdA2kcQ+pLkpAk28=; Message-ID: Date: Wed, 7 Sep 2022 11:05:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int Content-Language: en-US To: Michal Orzel , Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 10:19, Michal Orzel wrote: > Hi Henry, > > On 07/09/2022 10:36, Henry Wang wrote: >> >> At the boot time, it is saner to stop booting early if an error occurs >> when parsing the device tree chosen node, rather than seeing random >> behavior afterwards. Therefore, this commit changes the return type of >> the process_chosen_node() from void to int, and return correct errno >> based on the error type. >> >> Signed-off-by: Henry Wang > > Reviewed-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:05:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:05:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401102.642804 (Exim 4.92) (envelope-from ) id 1oVrwQ-0006Jd-Lu; Wed, 07 Sep 2022 10:05:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401102.642804; Wed, 07 Sep 2022 10:05:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwQ-0006JW-Iy; Wed, 07 Sep 2022 10:05:54 +0000 Received: by outflank-mailman (input) for mailman id 401102; Wed, 07 Sep 2022 10:05:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwP-0006Bz-6D for xen-devel@lists.xen.org; Wed, 07 Sep 2022 10:05:53 +0000 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [2607:f8b0:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a730b840-2e94-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:05:52 +0200 (CEST) Received: by mail-pf1-x42d.google.com with SMTP id y127so14129225pfy.5 for ; Wed, 07 Sep 2022 03:05:52 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id l11-20020a170902f68b00b00176c17e2c7fsm5156874plg.122.2022.09.07.03.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 03:05:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a730b840-2e94-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=scpnAAB49us063h03pju+wAALAqb7YgI3UzMoKktJyA=; b=r5uspQoHGYuE81De9zi0FH0YJRbJKjcWmJvykgECHdpNdytE4krpyWdSm1EYLzmgSi IO7yxKPbn/xAxqkDbgOI+qJ6pSVc6TOJsLkMNryDYvU1Yy/wy8nr2e12KmpdT21hBgL4 S0HCT4DDjIG/5lMCN85NwWpymAYDcUNAXIVJ41XUY/f5jhQdsQq2rwjWhMAibq7g2m0r eFLSEdNvhbF+fWFQA4h74fhaSzJqoBH1QcU0QlaqJ1U4SIm7Mg9y+9A8OmfzKY3ttoko QMcqKANTnXsnJXOF/84/yOW+SJQJqEf0koi/JT4sKPtI6rBzfTbIN7bKZFSvT+qUrnAZ X7eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=scpnAAB49us063h03pju+wAALAqb7YgI3UzMoKktJyA=; b=bL24M846nmbmh0LnWFua4BpEGF6n9Dh9NKLVq8Kg4jYgOzf2LTbj6B9EdxMLBdkVyc bHBT3Jvl+B6KRXtrjoRD0/nBTU2e0C1D1iTN5gApKxDT6MqH0l5RmYvZvdC/r5MbOuZW KvGg8XW8EQBORfj5AZTzAlFr8D6YO2QDaK7jgmBsG+OMhljQ5QQsBxZigPpu3uEtRsik uncdLW/coIHsK248+UVlz86kwTxEOOkEunqdVMiuRV5V6gub4C1rdTIHUCaFyQzXs/jD 6rbfW8Ae66mYXTmdqivHnsRvB8DbMKti2gjwL+i2lRIjt7zeUAt1d9d12EN+v4rd/zDJ 0WtQ== X-Gm-Message-State: ACgBeo0Bdx3PXZopZqNPI4DXbJH9Ntf49TTRP74kuhc2bwqywlv9Alg8 KEWdqPRJMtdNWqdkVSHR6224FTr0BBkgZQ== X-Google-Smtp-Source: AA6agR7Z8qKih6l9q4c66n0sP0C1ahQEMwTaeJBc/yvG+e408sjEP6zslX1znTlH9VK4uJEHB/GL8Q== X-Received: by 2002:a62:1d86:0:b0:52d:9df0:2151 with SMTP id d128-20020a621d86000000b0052d9df02151mr3181756pfd.33.1662545150871; Wed, 07 Sep 2022 03:05:50 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar Subject: [PATCH] .gitignore: Add *.patch Date: Wed, 7 Sep 2022 15:35:47 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add *.patch entry to .gitignore file to stop showing git generated patches in commands like 'git status'. Signed-off-by: Viresh Kumar --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9f9f18c97d5f..d9a4fd038145 100644 --- a/.gitignore +++ b/.gitignore @@ -20,6 +20,7 @@ *.gcno *.gcda *.py[ocd] +*.patch TAGS GTAGS GRTAGS -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:06:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:06:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401106.642815 (Exim 4.92) (envelope-from ) id 1oVrwf-0006oJ-Uf; Wed, 07 Sep 2022 10:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401106.642815; Wed, 07 Sep 2022 10:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwf-0006oC-Rj; Wed, 07 Sep 2022 10:06:09 +0000 Received: by outflank-mailman (input) for mailman id 401106; Wed, 07 Sep 2022 10:06:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrwe-0006fo-VS for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:06:09 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150041.outbound.protection.outlook.com [40.107.15.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0b57135-2e94-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 12:06:07 +0200 (CEST) Received: from DU2PR04CA0038.eurprd04.prod.outlook.com (2603:10a6:10:234::13) by PAXPR08MB7352.eurprd08.prod.outlook.com (2603:10a6:102:22a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Wed, 7 Sep 2022 10:06:04 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::9b) by DU2PR04CA0038.outlook.office365.com (2603:10a6:10:234::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 10:06:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 10:06:04 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 10:06:04 +0000 Received: from 31369a1e4be1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DF2928CC-C29A-48B5-8302-6C5C93348665.1; Wed, 07 Sep 2022 10:05:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31369a1e4be1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 10:05:58 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8305.eurprd08.prod.outlook.com (2603:10a6:150:a2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 10:05:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 10:05:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0b57135-2e94-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iUayeIxVujPz3j7pXrzCURi6Aqt01HdGq1DH5Lpf/C4RIcHQ8oBlMicCwVAqLzkr7cFSOFp0cFiLEVV/s3NuADg32dqrN1KLFc6uz2Z5tKGDNmp4uWBcQYJqJ5fbLbggB5OOCQWcdd23BT8me5ItZHxP9bOwWwEn2rt+QP4TVty3hXCfAB/nWnHcl+5LcoQ8C/AgJ07z9oZ5hfmvxmfmav3/4in0/fy+ErNwISvBY97aqGCw+kqx9qot5iMEJ6ZuIxkos+S6Yi3Ra1LbGilFuIdP/rUNwJ9jLp4cdv7+Fu5eVnecGVz+KvTYpGajgLFkJETQN7NIaO33nMsITjTcNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1c++8snHPM6G4uK3DDdgD6QKn838AAZMIC6ysONemz4=; b=dd1On4l8tPC5Gudu/kP457Qh/gjASAUnjQ4n9y8vZwzXaV8wfMtGoxnEJLy9J2/28RHxRGnUKe5jHygh9JBn/2YHkHdDc9/0fML9sOGNbtm4387Uo0kKk73LTNfOu+QP4zpHXqjIX1qlq/xgmBFc5KWriW/lgL7B8aMlOoolefu58jH4ntq2eoVgQGNWCD8Xrq6g8tMuhFI9moT47GlqdZgB2H04QUKao8fvEKRHuG0Gotymvy4puzMscDtdg2jzu3GGANfeZS2MYJgYzotRU6TRGUHfuBxXPLesWcEmORLimwrNT7EVtsFHb6L+zcdRRlOF3Fjp/FiUxasFzCancQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1c++8snHPM6G4uK3DDdgD6QKn838AAZMIC6ysONemz4=; b=AguDbhipZOz7B/13eEg4r5sjL2Jb0uugHuD+wv77GuqtC4OKiDlKcGR5evqlT3KeptNuw0nWn+SYeOESKEvXN2Xo6+ofCN/2ncl/WAwfaG36d78OJXo6G2jR8eo2Nux7FyYZbT0QVGxQs18smPQ74K8If6IKxhE47e80mduFNq0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dec397dff9af23d0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4NQmpyllcC6pBqkMZhEs0QhEEr4v6GqIyuGQE/kwr6r7+qj0MU9z3PKZ0wPz7wtyGccXSm+t4QylyjMlkQWHGRxEHuRaGoWGmoa1jcEuuDqkLgevYUyHUtD4EmD4A+PVcLCHPiPGfb0rItIMGb8T0XJFJ30/Z0HsWUoPuP9fvnqvFFbEA+ZWkDtiemU1c0KizUkjyuxMfCk/C3m9bVEoAhCbQfVSTpCII57QC1GXCUqwKNqLlVmHRI5LFGxkjEDRuL8RHFt7gZDliacPg7qRQnkRAAhAez321FrUSVG7AQ7gGQ1CC0rzOj5ciBu0XA2Darp3Mg4wQ9JmkRYuQXxVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1c++8snHPM6G4uK3DDdgD6QKn838AAZMIC6ysONemz4=; b=XpRtzRYNMSxbtmp5l9ywpKuWWWybmWh7Hq0DgOc0OKBelijC+8zvS06boy+PR3aeff61x3U5L66J82qVhFqtJM4R4ApJ6tF2lRl5y+ToYCp2SoGlLIZcceLUa+v3E1I+LkQzb44ze8Qsn+K5iaC5+gRkUDj422j6qX2a3zcMo8kTk27Fz5cpIWu6MP8ojm/b1tPePu5Wgxw9LxdRh1JslXjZ0CcL9Y65MH7Jhqyo3NptgDD4NLHJTbq9lmrnBhw4umv86zbZAV0a/N1EvHRyQoF8//Pd+qbYGyzgl3N1ZA8iulTYucicQhb0SgyCKK/BdknVStJzduiPn7Adf/RSpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1c++8snHPM6G4uK3DDdgD6QKn838AAZMIC6ysONemz4=; b=AguDbhipZOz7B/13eEg4r5sjL2Jb0uugHuD+wv77GuqtC4OKiDlKcGR5evqlT3KeptNuw0nWn+SYeOESKEvXN2Xo6+ofCN/2ncl/WAwfaG36d78OJXo6G2jR8eo2Nux7FyYZbT0QVGxQs18smPQ74K8If6IKxhE47e80mduFNq0= From: Bertrand Marquis To: Jan Beulich CC: "leo.yan@linaro.org" , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Thread-Topic: [PATCH] xen/arm: acpi: Include header file for version number Thread-Index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8AgAAAyoCAAAC7AIAABHeAgAAOWQA= Date: Wed, 7 Sep 2022 10:05:54 +0000 Message-ID: <524F3B92-5298-4BE3-864D-A076A8873800@arm.com> References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> <5ce7f63c-5ba5-f2cb-8e3e-f6dd2d9d76f7@suse.com> In-Reply-To: <5ce7f63c-5ba5-f2cb-8e3e-f6dd2d9d76f7@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 85e9acfc-895e-45f4-6b09-08da90b8934d x-ms-traffictypediagnostic: GV1PR08MB8305:EE_|DBAEUR03FT057:EE_|PAXPR08MB7352:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tV0veYUT/pSGWlwIVLaWE5O6LbESm09thljyjAZ2D23D3LJrMtVX95afRrRptDr9QMuJc+LL4+BL9YDr6ujqK9LIE6trjt/okMwn+3lfQ1jT7D9SbaBhzsO9hUVAYpKYK9wFVB6+VoYyNObKK+eQ5sGTrGd9dtIOq8HELdadY1VbqIHBbj0dFD/fd5ux+cpWWIv9IHBZmu1896h0NwStWtl+UQWE37HAnWZps/0XrabXWjDp5crAfBjxOdJfAa5+aeNI94QHSIF2PC+d03VMOg81ya7sHwOZn83mRNybeIwAdNA+HbRd9E4MDo90TovJILmNWaDdRkr0z6EchyWNTqHY8By4T7YhPG/e7TxxFuX1W67guQbLSDPyesa75CFaE4XsgF9ObMHfDkB53ZYBOH/1tjm4InJxKffruUv3tfVWJcRRpi2vbC4obTqx2xs4j4CWI9LVo9rJGqWp+hBF4NtcBamGuAEpBvED5Z04tw/l90vZ/eItSEHnlgxRoeVVsb6Fx5K1i5LCR24Ngpfe8GXfxaJ/4mhDZArVIy1dIlVpNxa/gGl+dIT0+bKiFEKtizJ4FMfMxZGitg8ZJduvH5ek/cyNnV22Qtg+4OIq/DoNI63Xb6lEyydGMsPRHPNTuhIKULHxQgSx71yRLPStwGNJ0fpm75hz3Yb8v64WrPjM0gx8emjG2vlxQ/9PJh/KBdFCM2GHF4W+5GxpkFN7U0hQ9CpyGLChlXi9bfgGGo8ZqC2M6pJIZMHZieg6PTpiF84/rUtdT8kN6hYHVlbWmk+Ft5rLYd2Pj/qe1kQFsm8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(376002)(396003)(136003)(346002)(38070700005)(122000001)(64756008)(4326008)(66446008)(66946007)(66476007)(38100700002)(66556008)(54906003)(76116006)(6916009)(91956017)(8676002)(2906002)(316002)(5660300002)(53546011)(26005)(71200400001)(8936002)(186003)(2616005)(6486002)(6506007)(478600001)(41300700001)(33656002)(6512007)(36756003)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8F5E884284331047AD78C248BE41CEE6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8305 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ee9d2925-7266-4a56-706a-08da90b88d70 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ITGGb7HIdztM/7fe7UTQ93GQWA2vNgWhh5FG2AI8SmAY6aUSNhGM03Y08X1JEIQafHCg5fv95cVjb0sDXKYQg8Dki0rbQ8DclAmSJDP16ja9P+b4WmzES1Gtkc79cKPO7EIzt3kKl9FNWXvnJIGb204kd5yU+g3UzlbL6hHqajKsIzMS/tDTKbQBGPOEsgYd+6f4ALa6RqQ00d0L6Zu5hD5n+JHlE0HtmABJ3npIMBqriZ/28Q2oSecJYkuo3p7PotTVKlCVxUoETXl/FGyif+dS9AlymnM+dWAwV7rjZPpSsnD2dbm8gXw2k4AjajUuPWJyjVA/EMfEdq9EtiJRiHskaqx1K/dovHNbLhvAV9GvK0aRYNuklxDr3YY786rWTS4UxjtV7VbKqkK6jWMmQgaK5P+wfcrLrq+cS+Czfr+cNEzgXJSWFxiqbXzw3ruvtrj9Pf3lfGw/REivTtUc3pP7EIUidmPy6z6MUeecnGhEhxIrt0KRGFw8u0kShm5B5ayTU7K7eGam0ZIHCF/vKy1Nd7T+fvm47tn+K6iA7nnoqrjFIah7dl0+DNzZf7470mB+zIUCVi9PY+QrQtlcNbF6431yQhG+86i92yKzhC8nf9XRByp3Kjnbfc7V+Uw7252kfrmuYSzj0XcPMqz9EYP60oV6ThKsSgTAM0wg+PP41ckQjEcru9tBgwBCQZQSfcTmKP/b0w2zGs0ilvnoyDXaSAbFtDbN0E/avHETps++BA7SVbs7O3iIgQ5sBGS8bsdOuFl1WUG+tzIg2SnAnw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(46966006)(40470700004)(36840700001)(186003)(336012)(478600001)(47076005)(36860700001)(53546011)(6512007)(2616005)(6506007)(26005)(6486002)(2906002)(41300700001)(40460700003)(8936002)(5660300002)(70206006)(70586007)(86362001)(82310400005)(40480700001)(36756003)(8676002)(6862004)(4326008)(81166007)(33656002)(82740400003)(316002)(54906003)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 10:06:04.6053 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85e9acfc-895e-45f4-6b09-08da90b8934d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7352 SGkgSmFuLA0KDQo+IE9uIDcgU2VwIDIwMjIsIGF0IDEwOjE0LCBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMDcuMDkuMjAyMiAxMDo1OCwgQmVydHJhbmQg TWFycXVpcyB3cm90ZToNCj4+PiBPbiA3IFNlcCAyMDIyLCBhdCAwOTo1NSwgSnVsaWVuIEdyYWxs IDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gT24gMDcvMDkvMjAyMiAwOTo1MywgQmVydHJh bmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+PiBPdGhlcndpc2UgaWYgd2Ugc3RhcnQgYWRkaW5nIHRo b3NlIGtpbmRzIG9mIGNoZWNrcywgd2Ugd2lsbCBoYXZlIHRvIGFkZCB0aGVtIGluIGF0IGxlYXN0 IDMgcGxhY2VzIGluIHhlbiBjb2RlLg0KPj4+Pj4gDQo+Pj4+PiBUaGUgc29sdXRpb24gSSBwcm9w b3NlZCBhYm92ZSBpcyBlYXN5IHRvIGltcGxlbWVudCByaWdodCBub3cuIE15IGd1dCBmZWVsaW5n IGlzIHR3ZWFraW5nIF9fc3RyaW5naWZ5IChvciBlbHNlKSB3aWxsIHRha2UgYSBiaXQgbW9yZSB0 aW1lLg0KPj4+Pj4gDQo+Pj4+PiBJZiB5b3UgKG9yIExlbykgY2FuIGNvbWUgdXAgd2l0aCBhIHNv bHV0aW9uIHF1aWNrbHkgdGhlbiBmaW5lLiBPdGhlcndpc2UsIEkgdGhpbmsgd2Ugc3RpbGwgd2Fu dCBzb21lIGhhcmRlbmluZyBmb3IgYmFja3BvcnRpbmcgcHVycG9zZS4NCj4+Pj4gSSB0aGluayBh IGRlZmluZSBpbiBjb21waWxlLmggdXNpbmcgc3RyaW5naWZ5IGlzIHRoZSBlYXNpZXN0IHNvbHV0 aW9uOg0KPj4+IA0KPj4+IEFoISBJIHRob3VnaHQgeW91IHdlcmUgc3VnZ2VzdGluZyB0byB0d2Vh ayBfX3N0cmluZ2lmeS4gVGhpcyBpcyAuLi4NCj4+IA0KPj4gQWxzbyBwb3NzaWJsZSBidXQgYSBi aXQgbW9yZSB0cmlja3kNCj4+IA0KPj4+PiAjZGVmaW5lIFhFTl9TVFJfVkVSU0lPTiAiX19zdHJp bmdpZnkoWEVOX1ZFUlNJT04pIi4iX19zdHJpbmdpZnkoWEVOX1NVQlZFUlNJT04p4oCdDQo+PiAN Cj4+IFF1b3RlcyBhdCBiZWdpbm5pbmcgYW5kIGVuZCBzaG91bGQgbm90IGJlIHRoZXJlLg0KPiAN Cj4gSSBoYXZlIHRvIGFkbWl0IHRoYXQgSSBkaXNsaWtlIHRoZSBTVFIgaW5maXguIEknZCBwcmVm ZXIgYSBzdWZmaXhlZCB2YXJpYW50DQo+IChlLmcuIFhFTl9WRVJTSU9OX1NUUklORykgb3Igb25l IG9taXR0aW5nICJzdHJpbmciIGFsdG9nZXRoZXIsIGUuZy4NCj4gWEVOX0ZVTExfVkVSU0lPTiAo YWxiZWl0IEkgc2VlICJmdWxsIiBhcyBiZWluZyBwb3RlbnRpYWxseSBhbWJpZ3VvdXMgaGVyZSwN Cj4gc2luY2Ugb25lIG1pZ2h0IGV4cGVjdCB0aGF0IHRvIGluY2x1ZGUgWEVOX0VYVFJBVkVSU0lP TiBhcyB3ZWxsIHRoZW4pLg0KDQoNClZlcnNpb24gaXMgYSB2YWx1ZSBzbyBoZXJlIEkgdGhvdWdo IGl0IG1hZGUgc2Vuc2UgdG8gZGlzdGluZ3Vpc2ggdGhhdCBvbmUgYXMgaXQgaXMgYSBzdHJpbmcg cmVwcmVzZW50YXRpb24gb2YgaXQuDQoNClhFTl9WRVJTSU9OX1NUUklORyBpcyBvayBJIHRoaW5r Lg0KDQpJIGdlbmVyYWxseSBkaXNsaWtlIGFueXRoaW5nIG5hbWVkIEZVTEwsIEVYVFJBLCBCQVNF IG9yIG90aGVyIHdoaWNoIGFyZSBqdXN0IHVuY2xlYXIuDQoNCkJlcnRyYW5kDQoNCj4gDQo+IEph bg0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:09:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401123.642826 (Exim 4.92) (envelope-from ) id 1oVs08-0007zN-OE; Wed, 07 Sep 2022 10:09:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401123.642826; Wed, 07 Sep 2022 10:09:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVs08-0007zG-L2; Wed, 07 Sep 2022 10:09:44 +0000 Received: by outflank-mailman (input) for mailman id 401123; Wed, 07 Sep 2022 10:09:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVs07-0007zA-79 for xen-devel@lists.xen.org; Wed, 07 Sep 2022 10:09:43 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3046a165-2e95-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 12:09:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EF665202A9; Wed, 7 Sep 2022 10:09:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D270A13A66; Wed, 7 Sep 2022 10:09:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6ApsMeRtGGOUQQAAMHmgww (envelope-from ); Wed, 07 Sep 2022 10:09:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3046a165-2e95-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662545380; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0KX2vj0xLvusjQPhujZEm13Y2kwtoe4W22C/UmCzjE=; b=ZGiYxerReFYyDGZUqxnzlVcpB8DKrqCUVOZH2kxpvB8AVbD4WX8vm5hyInSpGHJfxlqE94 jFjBU43kVNOXYeGTjDl3UMOMFJp2q89qZCHXxFE9cB1Jifc5BVMFJej2bB+T06P3zZsqyw zkibxI/LDQtX26yKSNcXNxOwimHYWck= Message-ID: Date: Wed, 7 Sep 2022 12:09:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] .gitignore: Add *.patch Content-Language: en-US To: Viresh Kumar , xen-devel@lists.xen.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8vgCbuaJQ38fp0mEOhgX35iN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8vgCbuaJQ38fp0mEOhgX35iN Content-Type: multipart/mixed; boundary="------------4PIsxVnvAUzLJ7bzp86qQzqm"; protected-headers="v1" From: Juergen Gross To: Viresh Kumar , xen-devel@lists.xen.org Message-ID: Subject: Re: [PATCH] .gitignore: Add *.patch References: In-Reply-To: --------------4PIsxVnvAUzLJ7bzp86qQzqm Content-Type: multipart/mixed; boundary="------------2hQLZXB7r8PtfvK7a5HTQz3m" --------------2hQLZXB7r8PtfvK7a5HTQz3m Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMDkuMjIgMTI6MDUsIFZpcmVzaCBLdW1hciB3cm90ZToNCj4gQWRkICoucGF0Y2gg ZW50cnkgdG8gLmdpdGlnbm9yZSBmaWxlIHRvIHN0b3Agc2hvd2luZyBnaXQgZ2VuZXJhdGVk DQo+IHBhdGNoZXMgaW4gY29tbWFuZHMgbGlrZSAnZ2l0IHN0YXR1cycuDQo+IA0KPiBTaWdu ZWQtb2ZmLWJ5OiBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPg0KPiAt LS0NCj4gICAuZ2l0aWdub3JlIHwgMSArDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEvLmdpdGlnbm9yZSBiLy5naXRpZ25vcmUNCj4g aW5kZXggOWY5ZjE4Yzk3ZDVmLi5kOWE0ZmQwMzgxNDUgMTAwNjQ0DQo+IC0tLSBhLy5naXRp Z25vcmUNCj4gKysrIGIvLmdpdGlnbm9yZQ0KPiBAQCAtMjAsNiArMjAsNyBAQA0KPiAgICou Z2Nubw0KPiAgICouZ2NkYQ0KPiAgICoucHlbb2NkXQ0KPiArKi5wYXRjaA0KPiAgIFRBR1MN Cj4gICBHVEFHUw0KPiAgIEdSVEFHUw0KDQpOQUsuDQoNCldlIGhhdmUgc29tZSBmaWxlcyBu YW1lZCAqLnBhdGNoIGluIG91ciB0cmVlIChlLmcuIHN0dWJkb20vcG9sYXJzc2wucGF0Y2gp Lg0KDQoNCkp1ZXJnZW4NCg== --------------2hQLZXB7r8PtfvK7a5HTQz3m Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2hQLZXB7r8PtfvK7a5HTQz3m-- --------------4PIsxVnvAUzLJ7bzp86qQzqm-- --------------8vgCbuaJQ38fp0mEOhgX35iN Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMYbeQFAwAAAAAACgkQsN6d1ii/Ey+M Bgf/QgIU6wIXsDLkDnwBmvcOnN6zuirK30y2cq7qBMMIfgUWMD6cElwpgAZl2tND6CaqnC7TM9j2 7ebpsI+9Sz55WhSI73QZga3JyWwAyIjCC9hJRCgLtyQvslt+4WhBJPyVEtJ4j8sga4aT0ZkGJIwT 30Lr2WXwC1/6cwU9n/gQY3jaqp60mVlEq7ry5IG/9GRMLunKAtoFrepoz63AzQjndQTQiRHa/QVj nOlUOfehaImFgKnERYhL7w52xZCaj2Tvrg/KFNxvTM5iRrXr8m45GupjmteJXXGfqJsJhyPFmnRY 9JYNWcmMsJrGs9Z5uMiujUZ32w1U1tCnpqLs4V8mAw== =74yq -----END PGP SIGNATURE----- --------------8vgCbuaJQ38fp0mEOhgX35iN-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:17:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401131.642837 (Exim 4.92) (envelope-from ) id 1oVs7F-0000zQ-F8; Wed, 07 Sep 2022 10:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401131.642837; Wed, 07 Sep 2022 10:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVs7F-0000zJ-BX; Wed, 07 Sep 2022 10:17:05 +0000 Received: by outflank-mailman (input) for mailman id 401131; Wed, 07 Sep 2022 10:17:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVs7D-0000zD-CT for xen-devel@lists.xen.org; Wed, 07 Sep 2022 10:17:03 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36700707-2e96-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:17:02 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso9340601pjd.4 for ; Wed, 07 Sep 2022 03:17:02 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id a7-20020a1709027d8700b0017691eb7e17sm8661091plm.239.2022.09.07.03.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 03:16:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36700707-2e96-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=nFahYmwJIGMxrSEtxvHxHxu3omH/Gggux9uFqCZjBuU=; b=g/VALj47ZZjLhSmO9cygQAMcOXOW2lS9a6cLsVBUuD05osCmD+iijup4Kk4PEn7ZtJ JE5aXiSddHgAwH7iz1Kc2KdBzhgnq4ZsY2jgEmjuNWMj/2SdOvlKEOgvectfN5Kzb3Dg R1Y1y571nso8PH+jeMkBg53zEw0miq9v62zoJBW8zT3YWej/qecZchc4ZEepo5oVSwiV zeJcU8qFliMTae/pvSTPXUnOXRBCQ54JLL3QQIxowcPHtg0p2GTq/IpmW85LyuCrNlj/ Lp33Ljjt/Z4f8K3+TSdhBCGd7vTzbRdqEuFmZQnRSAAHoP4bh3gBDzjy0CjuLdv4a/hO Np7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=nFahYmwJIGMxrSEtxvHxHxu3omH/Gggux9uFqCZjBuU=; b=D0QBBA4XaQPfHvMMQtwywr9eNX1IroGHuRcYcigVNlH2huX07NhPFRuH9HrHG0H/vT Ho/dRF5Bj6NdP4/RZmL7uJ1Kmuu5qaqROk8FUbpyg7qBJVeXtu5+AhVbFcqc9hUd6j37 tNZozS49lF6+XeffMj3Ep8/OC0WVShfS67bMyvNmQYJj4A36wmb799uwdQ+Tkdp/Sp/A 2oat2QhgcxvKXuFZ9fjBROhv3AkqmItDJ2eCXBgUhFYVdQrHiu1REvbjN8YV53DGeFx0 zWEUuY0JId7swQQJUgpO6VwL5vbZiN2vi1KgGnAokzVsQj0bGmrLXLh1XGwHRoWZwYOB mckw== X-Gm-Message-State: ACgBeo14DOR7fYnlSF5kQFigm2ALXa3j7VoKQThyG7vLSOypGXZZTOZu /L4DsuYlwwKsJYLEYB9JIz4/0HkoLQ+AFw== X-Google-Smtp-Source: AA6agR5S2FV4VZXfE12bP+3GFQUPDI75idJqttoN20ZlegLzevY3gDgYk/L+s7C9CAvb94qFhc+Mkw== X-Received: by 2002:a17:90b:1c0c:b0:1fb:6b2c:ca9f with SMTP id oc12-20020a17090b1c0c00b001fb6b2cca9fmr30416727pjb.90.1662545820627; Wed, 07 Sep 2022 03:17:00 -0700 (PDT) Date: Wed, 7 Sep 2022 15:46:57 +0530 From: Viresh Kumar To: Juergen Gross Cc: xen-devel@lists.xen.org Subject: Re: [PATCH] .gitignore: Add *.patch Message-ID: <20220907101657.3oeknoidtspmgewc@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 07-09-22, 12:09, Juergen Gross wrote: > On 07.09.22 12:05, Viresh Kumar wrote: > > Add *.patch entry to .gitignore file to stop showing git generated > > patches in commands like 'git status'. > > > > Signed-off-by: Viresh Kumar > > --- > > .gitignore | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/.gitignore b/.gitignore > > index 9f9f18c97d5f..d9a4fd038145 100644 > > --- a/.gitignore > > +++ b/.gitignore > > @@ -20,6 +20,7 @@ > > *.gcno > > *.gcda > > *.py[ocd] > > +*.patch > > TAGS > > GTAGS > > GRTAGS > > NAK. > > We have some files named *.patch in our tree (e.g. stubdom/polarssl.patch). Ahh, I missed that :( Will it be acceptable to have something like this then to just ignore the patches ? [0-9]*-*.patch -- viresh From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:24:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401138.642847 (Exim 4.92) (envelope-from ) id 1oVsEV-0002WW-7R; Wed, 07 Sep 2022 10:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401138.642847; Wed, 07 Sep 2022 10:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsEV-0002WP-4h; Wed, 07 Sep 2022 10:24:35 +0000 Received: by outflank-mailman (input) for mailman id 401138; Wed, 07 Sep 2022 10:24:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsEU-0002WJ-GF for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:24:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsEU-0002fr-8E; Wed, 07 Sep 2022 10:24:34 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVsEU-0002U1-1o; Wed, 07 Sep 2022 10:24:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=oKORNgA+Nm5iIvpKCgMtV8LicBlnWdaOYiu0Es2aCGA=; b=Rmqf1w05rxhesjGs0sIeRae0Cb GBBJYhMSSQHXnRvmJA9hxHSN0Kd5v3andKTjXJQs84gH0TzAmOdqSuBbU7DM3orHjrQcUEbBSOuVj XHGKqDZ7cOr6dg7htDrQauxR1I9B06Z8mBTkjqw+6x5oVAxmNGxiy/yahQ8dr2OAQmyo=; Message-ID: <80aa7dad-1507-d132-3652-dc65ef999ff8@xen.org> Date: Wed, 7 Sep 2022 11:24:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220907083643.20152-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: > static int __init early_scan_node(const void *fdt, > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index b76a84e8f5..0741645014 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, > if ( mem->nr_banks == 0 ) > return -ENOENT; > > - /* find first memory range not bound to a Xen domain */ > - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) > + /* find first memory range not bound to a Xen domain nor heap */ This comment could become stale if we are adding a new type. So how about: /* find the first memory range that is reserved for device (or firmware) */ > + for ( i = 0; i < mem->nr_banks && > + (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) > ; > + > if ( i == mem->nr_banks ) > return 0; > > @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, > u64 start = mem->bank[i].start; > u64 size = mem->bank[i].size; > > - if ( mem->bank[i].xen_domain ) > + if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) > continue; > > dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..6bea15acff 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -22,11 +22,31 @@ typedef enum { > BOOTMOD_UNKNOWN > } bootmodule_kind; > > +enum membank_type { > + /* > + * The MEMBANK_DEFAULT type refers to either reserved memory for the > + * device (or firmware) or any memory that will be used by the allocator. I realize the part of the 'or' is what I suggested. However, I wasn't correct here (sorry). In the context of 'mem' this is referring to any RAM. The setup code will then find the list of the regions that doesn't overlap with the 'reserved_mem' and then give the pages to the boot allocator (and subsequently the buddy allocator). Also... > + * The meaning depends on where the memory bank is actually used. ... this doesn't tell the reader which means applies where. So I would suggest the following: The MEMBANK_DEFAULT type refers to either reserved memory for the device/firmware (when the bank is in 'reserved_mem') or any RAM (when the bank is in 'mem' The rest of the code looks good to me. So once we settled on the two comments above: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:26:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401145.642859 (Exim 4.92) (envelope-from ) id 1oVsG8-00035z-Jb; Wed, 07 Sep 2022 10:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401145.642859; Wed, 07 Sep 2022 10:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsG8-00035s-Gg; Wed, 07 Sep 2022 10:26:16 +0000 Received: by outflank-mailman (input) for mailman id 401145; Wed, 07 Sep 2022 10:26:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsG7-00035k-BB for xen-devel@lists.xen.org; Wed, 07 Sep 2022 10:26:15 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7df87fc7-2e97-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:26:13 +0200 (CEST) Received: from mail-mw2nam04lp2174.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Sep 2022 06:26:06 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5143.namprd03.prod.outlook.com (2603:10b6:a03:1f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 10:26:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 10:26:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7df87fc7-2e97-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662546373; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=TiL0jYb8DTdxoqpJP6MT/ctPplOKePX4WB7k4yoTRMM=; b=XGGmYfBW3mQekVX/+n/wD/HCscwYwvANOfe6DwuBPdxSpFaW4FvRcE7o fS5oQaGn2suogW7WwEUF5tFWCiuAA47uqSYs2xnDGvsm5+ZxG6Av7PcF8 lDN969pc5d77tHAMDbeurw+3lO2mF431KEfBfLwrbmVNpQ+bn46ZGkgMb g=; X-IronPort-RemoteIP: 104.47.73.174 X-IronPort-MID: 79638744 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lrWIkqmf9zfV9s5sJfZssVfo5gykJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdXG3Tb/eIZGCjeN0nPYnk/U1QvZ6BztdnQFA6qH82FSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37ayt4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kxBoETpftxI1sUq /4mLmAHT0+61rOplefTpulE3qzPLeHNFaZH5jRF8mucCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWID7gvK+cLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSPy3b+QwX+TtIQ6TZ+6y9xyn2ev2n0vUkMOUXSdoveUoxvrMz5YA wlOksY0loAw+1asVcLVRACjrTiPuRt0c8RRCeAh6EeO16/d+S6dB24NVDkHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+bsLCOoluP1TM9KGYDYWoBUlED6ty7/IUr1EuQEpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPORENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:46edgq9LoFyNt2FO1PJuk+F0db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcUjpAtjLfZquz+8P3WB3B8buYOCGghriEGgG1+ffKlLbaknDH4JmtJ uINpIOceEYbmIKwfoSgjPIdOrIqePvmM/HuQ6d9QYKcegAUdAC0+4NMHf/LqQAfnglOXNWLv qhz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYpoLSIly95FMzQjlPybAt/S zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzRfBky/JlagkEuDzYJriJaIfy+QzdZ9vfrGrCpe O84CvI+f4DrE85MFvF5ycFkDOQqgrGo0WStGNwx0GT7vARDQhKdPaoz+hiA2fkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0AwfeMMo/ghiuLElGchshJ1a+FkQHIYLHSr85oxiGO 5yDNvE7PITdV+BdXjWsmRm3dTpBx0Ib1+7a1lHvtbQ3yldnXh/wUddzMsDnm0Y/JZ4T5Vf/e zLPqlhibkLRM4LaqB2AvsHXKKMeyXwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvY5AMxItaou W1bLqZjx9BR6vDM7z+4HQQyGGyfIyUZ0Wc9uhOo55kp7b7WL3ndSWeVVFGqbrSn8ki X-IronPort-AV: E=Sophos;i="5.93,296,1654574400"; d="scan'208";a="79638744" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QmHDOQl0DoiZRICMGRIYQvuAnbTJOVMF4WTOXr5QCg+PGk0MHpRbNL4v96oa5PGUJz8LUaZKQcguR0Ie8LmJayKvABv24Mik0yAzzLiD6QLnNSlJi22Uk8Lhz8jV6j7Zj6R3dkcpK5ruP/8psQ6BG+G7qJ9JBchU2hb8fOlAYrRfBCoLJaeX7/iTtdLAEPh5KIJSw2GzIzvFs6gTf0tLK5YgevrfTFgksdXgJx9NiV2S0+qYvSOqcnpxMdOsKNugkQZCwrYLmF6Za7DT4hniiVXv0A+JjGR7EWt3LFhLKeXcjDW4/V4Td5SMOz9grsL8b4k1CKx9iqFYhz58TnIQYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TiL0jYb8DTdxoqpJP6MT/ctPplOKePX4WB7k4yoTRMM=; b=NoVM+aDqQDHzJ3148OfcbK+DjOk+7fG4av1YHwCPhr++z3WhyzU5Ml9dKbqsjL47xhg6E7CxHR0zjLveSdCqRYDuhUYKG5rdum8MofjVFJFNH5ClO7MiGLSIO6MfI/CzVAmwWoJyrpIDGcDPFVnCyhkMG2wsdBti/deesnfxr5Bv18ll83TxxANG4fmTz7GVkUM/cEttOU9S/FLfpCS7h3aFpqNOlMbKWZS/ZymHqycaz0uPng95RPLsmyuOhMocouOvU5nTNbzJG2BiwkvpLeZMg7kENyr6QWNwv5o7uxvou5rMEK5WcpVQfWkP1OIVn/v/HTGNBAzPTP98Oz3PJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TiL0jYb8DTdxoqpJP6MT/ctPplOKePX4WB7k4yoTRMM=; b=mxWKDkLDwhxCgaWNLuXq1jAU2VUbLjlilj4rmLETBVsYcQiiwlrdSnyB8nqYUrM+va61JGHmrh2lN0+ccpeg2KekMn5c/1p8u9xFsL01P72rnnjJd4r/37bRPxF0iwM0C0SKUyRHrgD1IesBOiMPGYt7U2tVy3d4wuB7d0613J0= From: Andrew Cooper To: Juergen Gross , Viresh Kumar , "xen-devel@lists.xen.org" Subject: Re: [PATCH] .gitignore: Add *.patch Thread-Topic: [PATCH] .gitignore: Add *.patch Thread-Index: AQHYwqFtDIEPHIBXikmzc+iQP+t5RK3Tvp8AgAAElQA= Date: Wed, 7 Sep 2022 10:26:04 +0000 Message-ID: <760d73b1-8796-37f1-d687-5dd3215bc5e6@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39dc3acf-40b3-4125-6796-08da90bb5e8c x-ms-traffictypediagnostic: BY5PR03MB5143:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xTR7w+FxUMuR2Ujv2IusbDEBRnfV+7pyAZv5wKWeI7v3XgTgam+WeNSvxoJDLNMgZ7YrmiWQrcMOLSN95MFovu96fUHZ7qqrpCBHTVOQxb2iiOhfZ+JxyJ/MwM1mSVBM+cmdxG2K1aY4l0EJO+UEnFD7JiBEWTZAVjqcWh3BqjelIgnJiGaqDfj97DRiG8VDHOXymGUzc9a2xyNrNrJ9oo4snvPp9IU+39ynODUYgf6bQjDSUTHYX4xKIo4ZP43feDyMOVDdDTivSmvdDqxT6eqULOng1N/zhvfv2VTo5lSXSxx5znIbLlevwvnTzHXpbf/wsonmOjrdEoNi3+98jyRePwomKwlE2f7iuY1xKaRbtZB6v5zWdslrdSRTNms4HdQMmY+2Ho2/EbBm8aiw6JImSZGsA0JiHtfPqOsneBv1qTTLShr4ftLNk838jbVKjhfyu+C+0Wzni4xAr55km9L81bOfWwwQMt8hndODGEd0pRsPsUC1cMnnJmkB75mHKXqB38G7qoyNZt6zShOa3oXmGOGgaj9bWzwKYhYHpa/uOyzEwhmFADa+nHR9+c/IsI+QL4TQH2Z0TjnNtXI1FnxxbQsWbj4O7SznzNtDYm7l8BvhQOa6Z1pzOWmaWOtZJhiauGzgQKg+89pLb+BYvhzhPVnFni9P173YRjVohYwi9M/+MBvOkr4ljdYunzFFfz076bTb9OIERzpVMnprZTyA+HO70yyKBP9x4ssBguMKxP+0vibElbIQPWKWYhnbT2WM9KJsd/h1cspAYuNoKkGvgSqemkciGN3zYCwY/DOwDTh05XmJ34IY2HGSkql6qb59ojVq1vNBGrX3r0YuuA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(8676002)(26005)(2906002)(31696002)(86362001)(6506007)(53546011)(71200400001)(66556008)(66446008)(66476007)(64756008)(91956017)(478600001)(66946007)(6486002)(122000001)(110136005)(36756003)(31686004)(316002)(76116006)(82960400001)(38100700002)(5660300002)(8936002)(41300700001)(4744005)(6512007)(186003)(38070700005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WkhLdDlZcW93UjUwNXcyNlJocGJDSnhRR1I0L2liUjRZdmlaMWp5UnBaSUtm?= =?utf-8?B?bkpTd2ZpblYyT29GdCs2S1ZpTVdVYTdtYmdmVnZGZmsvOW95VFNXZUhQcHhv?= =?utf-8?B?UDQ3NkwyZlg4Mk9YcDEwNXlFa1hQSnl1cUoxZUtxeWJ1QWdMNkxmWFZrUXNl?= =?utf-8?B?aWpzUDlnNVVtaThONTFaSXBHb1RoRXN2TDZvbllCVzFYeDJ3M1d6bVRRZUVx?= =?utf-8?B?YStReko5TDBPTTdYM3AxZG1JUDlsSXUwTEx1VVg5bVp4MHJXNjNPNE5wODBO?= =?utf-8?B?VEVUNHRVd2xhNDRyMDE5bDRwa0xQcTRVMWRNa3VsMlpJL0VJcUlKdVBrT1Yv?= =?utf-8?B?RXhaWjMxb21CNnpzVjFtRXRXT2RCbDg1NVB3dU5TRHhOaFE4TDZweGlzMnhs?= =?utf-8?B?WkhmbWRIR2V3Qm1wSEV3ZzBVclA3YUpCbUJQOXBkSVBaa2tJTmZESC9UZFFq?= =?utf-8?B?STFMcnM1MnFkOWNZVUJ5OEplclRIL2d0Z3VRNzNSWUhiTTVidmd6Qmd3emhl?= =?utf-8?B?eFNKdUR4QzZuNXhWcWRZWTlNdWI2RCs0UXd5RjQzeUI5UUxiNE42ekJTWDRD?= =?utf-8?B?ME01bmlJbE0weXVWVVZSSHR4bllPY1hMZXNsb3JZTlF4TnQ2RW9GRDljN0E3?= =?utf-8?B?L01wMHFmTHk4THdLQ1pDcm9FTmdVaWtPcWUvZmF2bnVaK0Y5b1ZIdFRjcmVH?= =?utf-8?B?WlF2TjFzeGtHQ3NJZ2tnTVZFOWJSWXdBYzJXQjZGSU9GVy9JVHpyVEhRWVpv?= =?utf-8?B?WnNGQXU0ZWl5cUZKRit5ODVWZEMwY0Z4bzFHYWhMb1c4emhQK3pPUjZsWWVI?= =?utf-8?B?M3RUQ2VWU1ZEZXFuTHJEMDRENW14enIza1ZYNTdiampKZ1dJQ1F2QXl3dGxr?= =?utf-8?B?TG5uN0M5dVdXSk5iUkFMRENyNWFERFRsc1ZEWkN5QUIzeXJvT2MxT2NvWFpl?= =?utf-8?B?YkVTMGFqUDF0N2NZUGlFblV1ckNoSlVUOGhoZTBZMzhOR0R5WHdraHF5VE5R?= =?utf-8?B?d2ZFa0NUT3N4cExrL0YrVFQySjNXK1dPNUJ5c2lkZDJhbTBiMTNuUTRkaU9K?= =?utf-8?B?blh3L2dManVLdE1yc2NQbTFOYWNlakoxTEl6ZHRvQSsvc0NXV3RsL3ZLWHZC?= =?utf-8?B?MmdzdnZsTFowMjBhTm9TM2pXZnlmblI4djdQekhNTlc0RzRQTGJIbGQveDZS?= =?utf-8?B?NFVnMmpVaThWUGFGWWRKWTJLU2RxTHRmS2kveGJDaXdpajhnWXYwbm1JV0hs?= =?utf-8?B?bEpLTWpIcjhzQUJqa1J6aVlYc1ZvcTZRMzl5Zm4rUmFIWWxScnFHd0JzVzJZ?= =?utf-8?B?K0ovaUFyWVZIZElKZzZ0dk5zSjErYTFPS2hjNk5zWFJMbWE4SnVsRnBaVjBD?= =?utf-8?B?NnpNRnRUeThJQ0hLcUtic0JCZk4rYTBoV1dpbkJ6VmZpaXFCbU1SZklBR01m?= =?utf-8?B?K3dQRXpyNXlDaHZ5T1RqNHd0S0lycFlBN3BSdFArejVTWGFZLzN1U1hsZDdq?= =?utf-8?B?ODlsRzdobnp3WW9YODVZaW1rbHlPNjJZNE51RlVoc2dIbWMyalVyVXY4OXdR?= =?utf-8?B?c3JEelQzVndMMDRkZFhyUkJoOGx3ZHVOWmtKT3QzNnR2b054RzU4Uit1SHZR?= =?utf-8?B?UzFybGhHVDZaMTJWemRnT0VDMlV2WlhvS0VSdDF2cFhLRFF2MFBjZXJsRG5N?= =?utf-8?B?cldJWERJb1hab0tsZmNYWkNzMlNlS3I2Z29hOXVXajlHTDdpWHpUOUhYdHND?= =?utf-8?B?UWR1WUt1aWkva0pubDdYaU81UStFZjFuM2ZhWHE0cnExSmYrK2NyeW9JZ2w4?= =?utf-8?B?RkpQY0hjN0g5UjlSdlR0b0RYOWxhQm1iSm5nRG1KcDhQSFZsQ3JFUGFETTkx?= =?utf-8?B?UHlkS21ZVjJhYmhTL2JmUG1sRGFkZFBCamppczIyU1c1dGNibnB4REc0dEpY?= =?utf-8?B?eEtjN0VVekJZMWlxZGhyaFBsV2tSMllqcFFFQmpKMFczRnhISm1PSlNXTGZs?= =?utf-8?B?QWNoS1U4ZEpXcE55SEFENWdDUU5INTFSWndDa0V4Q0h5TkFiTFFSU0hLektV?= =?utf-8?B?WVlOanBWQmhrWHQxMjM2SGZ3cy8rbEQxaXA2Q0J6L2hjNU90U2JnUzRrYjJP?= =?utf-8?Q?IOIS//W4+BuMx/pu3tHv1kAIa?= Content-Type: text/plain; charset="utf-8" Content-ID: <09AB45EA1D980646BAFEE726AC7F5117@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39dc3acf-40b3-4125-6796-08da90bb5e8c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 10:26:04.5734 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Oet8mESaNonpUIAe9vZLFkX2aaIH0cpa1PpRvC1t2kBERhsIhMqsNVppxpsOTzkCsjoE6uMcCeZSgo+XVe+z7f3ArwzULqKkYtdjPqsesUo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5143 T24gMDcvMDkvMjAyMiAxMTowOSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMDcuMDkuMjIg MTI6MDUsIFZpcmVzaCBLdW1hciB3cm90ZToNCj4+IEFkZCAqLnBhdGNoIGVudHJ5IHRvIC5naXRp Z25vcmUgZmlsZSB0byBzdG9wIHNob3dpbmcgZ2l0IGdlbmVyYXRlZA0KPj4gcGF0Y2hlcyBpbiBj b21tYW5kcyBsaWtlICdnaXQgc3RhdHVzJy4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBWaXJlc2gg S3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPg0KPj4gLS0tDQo+PiDCoCAuZ2l0aWdub3Jl IHwgMSArDQo+PiDCoCAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4+DQo+PiBkaWZm IC0tZ2l0IGEvLmdpdGlnbm9yZSBiLy5naXRpZ25vcmUNCj4+IGluZGV4IDlmOWYxOGM5N2Q1Zi4u ZDlhNGZkMDM4MTQ1IDEwMDY0NA0KPj4gLS0tIGEvLmdpdGlnbm9yZQ0KPj4gKysrIGIvLmdpdGln bm9yZQ0KPj4gQEAgLTIwLDYgKzIwLDcgQEANCj4+IMKgICouZ2Nubw0KPj4gwqAgKi5nY2RhDQo+ PiDCoCAqLnB5W29jZF0NCj4+ICsqLnBhdGNoDQo+PiDCoCBUQUdTDQo+PiDCoCBHVEFHUw0KPj4g wqAgR1JUQUdTDQo+DQo+IE5BSy4NCj4NCj4gV2UgaGF2ZSBzb21lIGZpbGVzIG5hbWVkICoucGF0 Y2ggaW4gb3VyIHRyZWUgKGUuZy4NCj4gc3R1YmRvbS9wb2xhcnNzbC5wYXRjaCkuDQoNCkFncmVl ZCwgYW5kIHNvbWUgZnV0dXJlIHVzZWNhc2VzIHdhbnRpbmcgdG8gYWRkIG5ldyBwYXRjaGVzDQoo bGl2ZXBhdGNoLWJ1aWxkLXRvb2xzIGFuZCBsaXZlcGF0Y2hpbmcgdGVzdGluZykuDQoNClZpcmVz aDogSWYgeW91IHdhbnQgdG8gaGlkZSBwYXRjaGVzLCB5b3UgY2FuIGFkZCBpdCB0byB5b3VyIGxv Y2FsDQouZ2l0L2luZm8vZXhjbHVkZSBmaWxlLCBidXQgaXQgaXMgYmV0dGVyIHRvIGdldCBpbnRv IHRoZSBoYWJpdCBvZg0KbWFpbnRhaW5pbmcgYSBjbGVhbiB3b3JraW5nIHRyZWUuDQoNCn5BbmRy ZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:31:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401155.642869 (Exim 4.92) (envelope-from ) id 1oVsKe-0004gb-8d; Wed, 07 Sep 2022 10:30:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401155.642869; Wed, 07 Sep 2022 10:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsKe-0004gU-61; Wed, 07 Sep 2022 10:30:56 +0000 Received: by outflank-mailman (input) for mailman id 401155; Wed, 07 Sep 2022 10:30:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsKc-0004gO-OZ for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:30:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsKc-0002op-AX; Wed, 07 Sep 2022 10:30:54 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVsKc-0002cs-3x; Wed, 07 Sep 2022 10:30:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=UAp7HeEYfSyYusbbBQzfswaxv4okyGm87qW7bYLU1WE=; b=Ke9stc7cIEd2fA1Vk0XP2R0QY+ jG7pson4PyI1Xp8pIwIv/qsciSVw/h+AV9iWr6hn10J2jMgbplwx4Ch29gobzuKt5aL6dqE6aPv58 RyhqIUi/nwOA8TAHgK/CtN8BIfsZNA2E7dqE8fyxA/XzBlxm8J5EBZqe3mkPItT32BcA=; Message-ID: <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> Date: Wed, 7 Sep 2022 11:30:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220907083643.20152-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7f5b317d3e..4a70ed2986 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -132,12 +132,12 @@ uint64_t init_ttbr; > static paddr_t phys_offset; > > /* Limits of the Xen heap */ > -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; > -mfn_t xenheap_mfn_end __read_mostly; > -vaddr_t xenheap_virt_end __read_mostly; > +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; > +mfn_t directmap_mfn_end __read_mostly; > +vaddr_t directmap_virt_end __read_mostly; > #ifdef CONFIG_ARM_64 > -vaddr_t xenheap_virt_start __read_mostly; > -unsigned long xenheap_base_pdx __read_mostly; > +vaddr_t directmap_virt_start __read_mostly; > +unsigned long directmap_base_pdx __read_mostly; > #endif > > unsigned long frametable_base_pdx __read_mostly; > @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, I think the function also want to be renamed to match the code below. > panic("Unable to setup the xenheap mappings.\n"); Likely, I think this wants to be s/xenheap/directmap/ > > /* Record where the xenheap is, for translation routines. */ Same here because you set directmap_virt_end. > - xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; > + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; I would be OK to keep "XENHEAP_*" for now. > } > #else /* CONFIG_ARM_64 */ > void __init setup_xenheap_mappings(unsigned long base_mfn, > @@ -618,12 +618,12 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, > int rc; > > /* First call sets the xenheap physical and virtual offset. */ s/xenheap/directmap/ I haven't looked if there are other instances in the function. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:34:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401174.642924 (Exim 4.92) (envelope-from ) id 1oVsOK-0005mc-9d; Wed, 07 Sep 2022 10:34:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401174.642924; Wed, 07 Sep 2022 10:34:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsOK-0005mV-6Q; Wed, 07 Sep 2022 10:34:44 +0000 Received: by outflank-mailman (input) for mailman id 401174; Wed, 07 Sep 2022 10:34:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsOJ-0005ku-21; Wed, 07 Sep 2022 10:34:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsOI-0002uN-VY; Wed, 07 Sep 2022 10:34:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsOI-0005na-J7; Wed, 07 Sep 2022 10:34:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVsOI-0002OU-Id; Wed, 07 Sep 2022 10:34:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1IjC3xLlA2+nmLSdikYDIg67e/BtE/BJuzf3xmHCCec=; b=xVo630Yy7iwJDAxbIwvcOte2J+ HwPZhXv2fnu7vZBwHkDm+ZgbygTILM84DultOvl/ye3nMBOtQX/AY/nNwpp+XEc1ZXGNuWkKNn9yd O/dkF7Akj7CkP9dPjpejG4CDhx/HnTgHzkJQ/tuM4c0biNCp+nMbdK3Tpb2+Jsbqrde8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173031: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=172015009a6acc20357a2698800e13058ba1d3db X-Osstest-Versions-That: xen=e997d055929665b12246e89eb092dc79c65de9a4 From: osstest service owner Date: Wed, 07 Sep 2022 10:34:42 +0000 flight 173031 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 172993 build-i386-libvirt 6 libvirt-build fail like 172993 build-arm64-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172993 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172993 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172993 build-armhf-libvirt 6 libvirt-build fail like 172993 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172993 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172993 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 172015009a6acc20357a2698800e13058ba1d3db baseline version: xen e997d055929665b12246e89eb092dc79c65de9a4 Last test of basis 172993 2022-09-05 01:52:22 Z 2 days Failing since 173004 2022-09-05 14:38:21 Z 1 days 4 attempts Testing same since 173031 2022-09-06 23:10:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Bixuan Cui Christophe JAILLET Daniel P. Smith Gustavo A. R. Silva Jan Beulich Jean-Philippe Brucker Juergen Gross Julien Grall Penny Zheng Rahul Singh Robin Murphy Stefano Stabellini Will Deacon Xenia Ragiadakou Zenghui Yu Zhen Lei Zhou Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e997d05592..172015009a 172015009a6acc20357a2698800e13058ba1d3db -> master From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:43:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:43:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401194.642980 (Exim 4.92) (envelope-from ) id 1oVsX9-0007rR-L2; Wed, 07 Sep 2022 10:43:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401194.642980; Wed, 07 Sep 2022 10:43:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsX9-0007rK-HC; Wed, 07 Sep 2022 10:43:51 +0000 Received: by outflank-mailman (input) for mailman id 401194; Wed, 07 Sep 2022 10:43:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsX8-0007rD-In for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:43:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsX8-00035M-9I; Wed, 07 Sep 2022 10:43:50 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVsX8-0003Pn-2o; Wed, 07 Sep 2022 10:43:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bJL974w4VVQGhGc1R8+F9YXO22SnzIe6gszIIs1Urns=; b=Kk+BIZbH1HEq7IkERs8nEvsdbi rm7Q59dq+KL3C8kol16MvThVwcq7aFtHwd1UYu9S9o2VnV0mQ0ONeMKS9RGn/NKCjR1u/FBlSkC7V VBxg9ZZwhLRZ8SVkFrJaBTpfm08Q8N4ha8grGu+fL+l6/0aKmwqioGTpSEopyrIQeWiA=; Message-ID: Date: Wed, 7 Sep 2022 11:43:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 4/4] xen/arm: Handle static heap pages in boot and heap allocator Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-5-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220907083643.20152-5-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: > This commit firstly adds a bool field `static_heap` to bootinfo. > This newly introduced field is set at the device tree parsing time > if the static heap ranges are defined in the device tree chosen > node. > > For Arm32, In `setup_mm`, if the static heap is enabled, we use the > static heap region for both domheap and xenheap allocation. Note > that the xenheap on Arm32 should be always contiguous, so also add > a helper fit_xenheap_in_static_heap() for Arm32 to find the required > xenheap in the static heap regions. > > For Arm64, In `setup_mm`, if the static heap is enabled and used, > we make sure that only these static heap pages are added to the boot > allocator. These static heap pages in the boot allocator are > added to the heap allocator at `end_boot_allocator()`. > > If the static heap is disabled, we stick to current page allocation > strategy at boot time. > > Also, take the chance to correct a "double not" print in Arm32 > `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. > > Signed-off-by: Henry Wang Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:45:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:45:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401203.642991 (Exim 4.92) (envelope-from ) id 1oVsZ3-0008Uq-3C; Wed, 07 Sep 2022 10:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401203.642991; Wed, 07 Sep 2022 10:45:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsZ3-0008Uj-0E; Wed, 07 Sep 2022 10:45:49 +0000 Received: by outflank-mailman (input) for mailman id 401203; Wed, 07 Sep 2022 10:45:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsZ1-0008Ub-GC for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:45:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2045.outbound.protection.outlook.com [40.107.22.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a6ef1a0-2e9a-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:45:46 +0200 (CEST) Received: from DB6PR0801CA0056.eurprd08.prod.outlook.com (2603:10a6:4:2b::24) by AS2PR08MB9427.eurprd08.prod.outlook.com (2603:10a6:20b:5e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 10:45:43 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::e4) by DB6PR0801CA0056.outlook.office365.com (2603:10a6:4:2b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 10:45:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 10:45:42 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 10:45:42 +0000 Received: from 9ca911001989.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B3F5E63-865C-4CF5-A92C-4368EB932A67.1; Wed, 07 Sep 2022 10:45:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ca911001989.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 10:45:36 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB8314.eurprd08.prod.outlook.com (2603:10a6:10:3de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 10:45:35 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 10:45:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a6ef1a0-2e9a-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LyXtsKQJZSQhf6Glz4n4fQf6uTUwODkKg46zip9+jSM7tAGDutJblS9V5hwXZd2dYNHXMDMBSeMJ8tGBdjkGM9MhGe6Td8nul0kKu0sYcrMhblKMrQXVgRJnI0vv7lKSApRzR3lSki5BrNQUPfsE+QiHWscWbxNm6EzxG52756wAKlt2Q5RZZx4vtdGUa6GXxMvswWL2Zy6FJq9AYzBnsEeSZd4RQFhal4G45mFOovI74D4SDpaFPwJaKKD2pQAQ9itHPgrhJa889jDE3z6evwzMyVgAYzCBfT2KWoA944xAkq8tN+js6AzunexHMc5CYSKcYWmoyfYhiEzfrAED8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVS6KWJ3EQcyzPz7EYIqtfvTRq7OQDT6ANZPuue9gFA=; b=ZiMMTZUFGIVSWZSoPsLysOS8OHfS5HRlivLXGnINuPxMJxvKikLMxKQii6LXbb6pgNYk0toJCw5lJQ3XZR9IaMnZA2iueRCtUp2G6Dj9tpod/EzkfmQXfVny8+IiqVvqP3FAh2VHzqyOtBlsm9MoyK9BnFzD0MzhmuLVCd5ozpu8ML6hzNrUSYA6iNTzYZleWxJi7/EFuCmgZnJB5+91JQ3FSKLiTkByUZ2jRtsFe4EjrurRvNzKhOd3sLgGZdE82mohknF4EvSc6k4B8BwL+6+puCdTuWNjsWpSKPCRb+HYx4g7RuNrofU9t755IpK5YtX4nVnK5X4B+q+9G9Zd3Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MVS6KWJ3EQcyzPz7EYIqtfvTRq7OQDT6ANZPuue9gFA=; b=xsCpz7Blk64wDju11MFWo5lc13akMBr3hGBmahgBS73lFIVEEQ/WuPQYBPlUIUc+zEFjQwMOJJxjyAqXMC9wUkcpAeIVFYWcwOgjMZAsZ82aIuGFa4ZC2dnMiRzfaug9w0oJxlgHSpcFguQIsFPKBkgRaCRVcp/zr9IBC4MiJD8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G1IzgoHmrWw27ITnbq37ZECZxFYV8b2fL0ZAwf2EtmYya+lbtHv+V8qgnrXcSoCes326Ak171jmlnpMtLliyunM5sSHsBt5+OUkOGLIeQ5DhcwTcU9jYQQ2arxQnYWNhU1L8CMm39iH4qxLlT9Vik+Jpa53/hAo8PV0qhpqZcSCay8bU122V6EeP8x/UzZJntz5Up9L33HLR3F8nZRcgZCW6pw442dI2cbsfbs2yEoaHAV33y2e0L5/5t8/kcl98epFjxqfiVUl6bQ9imo/a6Xj/f6v4ZJmqsERLuxeirLlVIgJmmd/DpNoqFgXfCGqCH+Df4p0svqoqPvAcDK84Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVS6KWJ3EQcyzPz7EYIqtfvTRq7OQDT6ANZPuue9gFA=; b=RSioXe5rd4nNsmcBLDozeTxw7iI7MLEckWID5Z5hFbEkWBW0x9+kkyzTSS0DGX2gPOmKfTCI6BR48iOPsa5OOYAQtbUeNcVvRyV2UCLZdtgFTGggLXeIOVFhwOzqEyJGEnv+DYrZXAn762XJvCcJLoRAZhlTvTW7U/yvceDugVfOWjZJmaVoG1+BoMHqLGXz17b49ZCkQSYg0pQE8KPoBV+S/o+/XKrkTTGxIgdYQ0feR30b5YhI1qvdtiwZPwx+PaD/M0bXurPGlb7DT0TA0miQsD3HgbX/RZ2hB4s1mTtCBLX4wVrLru9HqDmq905oyi8jjt0yJ6N6Ee4YwR473Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MVS6KWJ3EQcyzPz7EYIqtfvTRq7OQDT6ANZPuue9gFA=; b=xsCpz7Blk64wDju11MFWo5lc13akMBr3hGBmahgBS73lFIVEEQ/WuPQYBPlUIUc+zEFjQwMOJJxjyAqXMC9wUkcpAeIVFYWcwOgjMZAsZ82aIuGFa4ZC2dnMiRzfaug9w0oJxlgHSpcFguQIsFPKBkgRaCRVcp/zr9IBC4MiJD8= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3Twt6AgAAE4DA= Date: Wed, 7 Sep 2022 10:45:34 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <80aa7dad-1507-d132-3652-dc65ef999ff8@xen.org> In-Reply-To: <80aa7dad-1507-d132-3652-dc65ef999ff8@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 29FA3675AE30E14DAE1775F792351A7B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e4fa4c04-1805-4616-7c0e-08da90be1cce x-ms-traffictypediagnostic: DB9PR08MB8314:EE_|DBAEUR03FT062:EE_|AS2PR08MB9427:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: r51jeC/mA6hLCRjEqD9tCD/6HUioPp9msIhXdiEmNrkkGwLWfWpav6nCvoE9Lpifc3XFRmd++457FFe5m+1gbBUTscrW57sdOqmZotAi2FKj9l0d9/vF8Eib7+on1/CuG17iF60F6F5HDX5rSorzzQ8KilgHoc7GjnqAU7QUGgIE+j4Cwtd6LeT0tTAUh+qwNjjA5B+AayliuTYQDDKoI05JWnwcfV+ar2apqdKPfNdgBrvDtNV1cCvwbaO+kqYvsT3Q2dF0DBe08QZCRRWlA/EytbFGI4NQGWg7z3Me6HoPdigeDqZXWfC1fMhZ1cXfGCbhUgdmu/lVWjE6dijKeHEwj52jMT7gf9NRuAS43heLGXeR879BCjp1PRNc3sKJlK8+km27wONWvgsbqjjlAYQC0XjAjgJF/AnQ5bFdkjPz9+78hIWX+O2gf6KhwZGmMx3dTSA03rHx1jNgLfIJINl6PBKzPgj0/1+gAC2jOWb7NOcSekjqRG0OtTDzC1cNBJTWRr6zkWqRxo1xXBJ+Oed8QsZJCXaSDSskdJSDljsEpNrNjh3Hr+tt+P1FbWT1BO+PhJZeWkEwfVXQjJAVA3oq+lBGZPgtfSMe07MTn/wGoSEIE9C7wqeSBSPmqI50zfX0egGCGmf37NoGUVS+1PDGXJepKf+wNUFH7HDRp6J1wPj5gNzZ+4XbkRyKn6OTuI+hCnOB29RTmqwInp6IkjgjjnSdIb+keN5g8P26e8xDXAlL4hqu5ALprUuGrJxaQ3z5GztLD/RtCy55RAFJYg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(38070700005)(5660300002)(26005)(41300700001)(86362001)(7696005)(9686003)(6506007)(38100700002)(122000001)(83380400001)(186003)(71200400001)(52536014)(8936002)(4326008)(55016003)(110136005)(66476007)(66556008)(66446008)(64756008)(8676002)(2906002)(76116006)(66946007)(478600001)(33656002)(54906003)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8314 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d9cc9310-5a71-4907-1163-08da90be17bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j92INaV53KaviKuXilZCtHjj4PmX3EtXdL7QE/SMcurvToIJqiYOsUXDyYdzo65OvuBV+iugoFqg1XWAbzoTRyMl6Nvezou3lCguS1XqdgWkNFXkoh5EKejzBeyquMl6hyp1nBTcl4dzb7zMTXwCeSXq6IdFxlsBPrnyj5soFmuuq6ID4S81h9nOZrm1VynW4EUIvoEW32lflOmAhN1ZuB+owIDs6v5V2E30ngvrhJk0bkZqKySHFFwPM74halUaNf/yG5kN1WfzOIE9N4KPkTbr9YqfHG4OOUdMlYA8f4p4QvO2mz1Hce6KcyImqrTPH8giiRw2NTcLhY3BY8xG28bsejo4IeEw+Ekg/UJyvCF0+Ob6/HJjeGPUuaorjW1xbgrvp9oDNtTEd2OM7265mESGx7S+tzaWxr7npWgDy04Oexd8H3J39Q9mdBC2fuHXS6v1h0wD2HKCOFfYs0zeu2NgEbmKTlg8XADeVdIRBpigulEfDGKO+YlQ7LvZoHjoMhVkc1SQB7vp1CKx4RjiFO6N3/rhzqMPpRQKKpJfB+tzgc/ADGdhTM6R1GHjO5rrEEZAp2JkRhUU6FxMfOU2aeaJFH9ZMh68O9aqEx5Q2rnqIk77SGbxJOU6h8MGSGfWfVqTjs++1JLU0LAcqvC6oHtXgazXbK3EmT5U2NRplJEsEg4C/C/Y7sWssjYyLYa6FmjIgxCzi3EsTxIMPOZEEsMRDvpZvz4NuVoz5ZGgCzKe9Thz6UggTPf3CpOq99vh4ejD1iWi+efOaYGcKYc1dg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(39860400002)(376002)(46966006)(40470700004)(36840700001)(41300700001)(336012)(26005)(6506007)(7696005)(316002)(9686003)(478600001)(83380400001)(47076005)(2906002)(82310400005)(8936002)(52536014)(5660300002)(54906003)(40480700001)(55016003)(110136005)(40460700003)(186003)(4326008)(8676002)(70586007)(70206006)(36860700001)(82740400003)(33656002)(86362001)(356005)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 10:45:42.7670 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4fa4c04-1805-4616-7c0e-08da90be1cce X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9427 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4gLSAgICAvKiBmaW5kIGZpcnN0IG1lbW9yeSBy YW5nZSBub3QgYm91bmQgdG8gYSBYZW4gZG9tYWluICovDQo+ID4gLSAgICBmb3IgKCBpID0gMDsg aSA8IG1lbS0+bnJfYmFua3MgJiYgbWVtLT5iYW5rW2ldLnhlbl9kb21haW47IGkrKyApDQo+ID4g KyAgICAvKiBmaW5kIGZpcnN0IG1lbW9yeSByYW5nZSBub3QgYm91bmQgdG8gYSBYZW4gZG9tYWlu IG5vciBoZWFwICovDQo+IA0KPiBUaGlzIGNvbW1lbnQgY291bGQgYmVjb21lIHN0YWxlIGlmIHdl IGFyZSBhZGRpbmcgYSBuZXcgdHlwZS4gU28gaG93IGFib3V0Og0KPiANCj4gLyogZmluZCB0aGUg Zmlyc3QgbWVtb3J5IHJhbmdlIHRoYXQgaXMgcmVzZXJ2ZWQgZm9yIGRldmljZSAob3IgZmlybXdh cmUpICovDQoNCk9rLCB3aWxsIHVzZSB0aGlzIG9uZS4NCg0KPiANCj4gPiArZW51bSBtZW1iYW5r X3R5cGUgew0KPiA+ICsgICAgLyoNCj4gPiArICAgICAqIFRoZSBNRU1CQU5LX0RFRkFVTFQgdHlw ZSByZWZlcnMgdG8gZWl0aGVyIHJlc2VydmVkIG1lbW9yeSBmb3INCj4gdGhlDQo+ID4gKyAgICAg KiBkZXZpY2UgKG9yIGZpcm13YXJlKSBvciBhbnkgbWVtb3J5IHRoYXQgd2lsbCBiZSB1c2VkIGJ5 IHRoZSBhbGxvY2F0b3IuDQo+IA0KPiBJIHJlYWxpemUgdGhlIHBhcnQgb2YgdGhlICdvcicgaXMg d2hhdCBJIHN1Z2dlc3RlZC4gSG93ZXZlciwgSSB3YXNuJ3QNCj4gY29ycmVjdCBoZXJlIChzb3Jy eSkuDQoNCk5vIHByb2JsZW0sIGFjdHVhbGx5LCBJJ3ZlIGxlYXJuZWQgYSBsb3QgYWJvdXQgaG93 IFhlbiBkb2VzIHRoZSBtZW1vcnkNCm1hbmFnZW1lbnQgZnJvbSB5b3VyIGNvbW1lbnRzLiBTbyBJ IHNob3VsZCBzYXkgdGhhbmsgeW91Lg0KDQo+IA0KPiBJbiB0aGUgY29udGV4dCBvZiAnbWVtJyB0 aGlzIGlzIHJlZmVycmluZyB0byBhbnkgUkFNLiBUaGUgc2V0dXAgY29kZQ0KPiB3aWxsIHRoZW4g ZmluZCB0aGUgbGlzdCBvZiB0aGUgcmVnaW9ucyB0aGF0IGRvZXNuJ3Qgb3ZlcmxhcCB3aXRoIHRo ZQ0KPiAncmVzZXJ2ZWRfbWVtJyBhbmQgdGhlbiBnaXZlIHRoZSBwYWdlcyB0byB0aGUgYm9vdCBh bGxvY2F0b3IgKGFuZA0KPiBzdWJzZXF1ZW50bHkgdGhlIGJ1ZGR5IGFsbG9jYXRvcikuIEFsc28u Li4NCj4gDQo+ID4gKyAgICAgKiBUaGUgbWVhbmluZyBkZXBlbmRzIG9uIHdoZXJlIHRoZSBtZW1v cnkgYmFuayBpcyBhY3R1YWxseSB1c2VkLg0KPiANCj4gLi4uIHRoaXMgZG9lc24ndCB0ZWxsIHRo ZSByZWFkZXIgd2hpY2ggbWVhbnMgYXBwbGllcyB3aGVyZS4gU28gSSB3b3VsZA0KPiBzdWdnZXN0 IHRoZSBmb2xsb3dpbmc6DQo+IA0KPiBUaGUgTUVNQkFOS19ERUZBVUxUIHR5cGUgcmVmZXJzIHRv IGVpdGhlciByZXNlcnZlZCBtZW1vcnkgZm9yIHRoZQ0KPiBkZXZpY2UvZmlybXdhcmUgKHdoZW4g dGhlIGJhbmsgaXMgaW4gJ3Jlc2VydmVkX21lbScpIG9yIGFueSBSQU0gKHdoZW4NCj4gdGhlIGJh bmsgaXMgaW4gJ21lbScNCg0KT2sgd2lsbCBmb2xsb3cgdGhhdC4NCg0KPiANCj4gVGhlIHJlc3Qg b2YgdGhlIGNvZGUgbG9va3MgZ29vZCB0byBtZS4gU28gb25jZSB3ZSBzZXR0bGVkIG9uIHRoZSB0 d28NCj4gY29tbWVudHMgYWJvdmU6DQo+IA0KPiBSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxq Z3JhbGxAYW1hem9uLmNvbT4NCg0KVGhhbmtzIQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+ IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:52:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401210.643002 (Exim 4.92) (envelope-from ) id 1oVsfA-0001bJ-OG; Wed, 07 Sep 2022 10:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401210.643002; Wed, 07 Sep 2022 10:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsfA-0001bC-LN; Wed, 07 Sep 2022 10:52:08 +0000 Received: by outflank-mailman (input) for mailman id 401210; Wed, 07 Sep 2022 10:52:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsf9-0001b6-TX for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:52:07 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140089.outbound.protection.outlook.com [40.107.14.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d82cc87-2e9b-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:52:07 +0200 (CEST) Received: from DB3PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:8::22) by AS8PR08MB6567.eurprd08.prod.outlook.com (2603:10a6:20b:318::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 10:52:04 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::44) by DB3PR08CA0009.outlook.office365.com (2603:10a6:8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 10:52:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 10:52:04 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Wed, 07 Sep 2022 10:52:04 +0000 Received: from 6fb5d9769b64.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C3232612-E860-474D-AEEE-F49DDE403775.1; Wed, 07 Sep 2022 10:51:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6fb5d9769b64.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 10:51:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7842.eurprd08.prod.outlook.com (2603:10a6:10:39d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 10:51:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 10:51:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d82cc87-2e9b-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dFSTpt7Z832onP/39P3o5y0lB6MuxGbngz8YUe8UtgJEiJ9OU4x1odcBtsCz1rsS9GaWn5kPygg8zibpnS1R+SuBlSGmpoYhZDS0V/6KH9WU3ssj0Lc2X8gmMoZmP8+k2DO+zPjcTKMbghjljwm7za3GJvIe4eP7dgq/XSOwaKErcCv51uKzyNGOd21ZomeJiJAKDEkS+1BoT99qxKEE1QFWBuJi/eDmsV6doU2YC4zi8avlH5BpvyUkpPN8e5zq3WvxG7sUKoRIviMSSOjS0wdzNbG/owGuIr9ee3EHlSKqNqiTZvI5fhlnrHYfIwgIOMIBTgxSR7ql3C53+kpghg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PHUaX32//UmlLZr3kDOAUXue1NlS8qQrKgnTLnUUlQ8=; b=FAyTzGAwhR40warT46nG0uoPE99Uyt5JEo3g0FEZPWSOytXGF1lzFvUmnpo4G1UUxN25LlyxnH84uCabYbE+mSQNMiABVwydjk6/YvDHkM2to7jOl5LDQLJkpxClxVUZ7u1G8It1mXZSadU90/2txa8+Av1arzvqxbApYW8HkhPGWQSYgM4z6EAGvG32wf4OylM4Gm4ckvzmpJaGij+hWuaSrPBa8DTCl6N1WQDL7WI1M6Wb/4lEAB15OtkwuOFye/rB1tnbXjbwtWGt0uUI3nugx12HWhv8639ED3w13A77z7nk6mEL8kYVq0ud4xd4VuZ/gJH+AxbdI0cFX36xZQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PHUaX32//UmlLZr3kDOAUXue1NlS8qQrKgnTLnUUlQ8=; b=9JUX8rc3TjSqdL/dCa9RQkfNASuy9h473eqsfrOsjZSeSN8qzRU4v7/jyWDxbuvMSXsOeNOvKZjScyQxC/fF8tafa7kCJEZLac2AWqIl58IJ1X8LfEh0SujH+XM75pAJ9YPReEzHYHLjgFOfTiS8oJk2LxsIl+gPujXlmOK3PKw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 86654578b481cae1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a0Fpr0vgMD6SjkHIMA+/XZ4Td3jKTE+9HtkOS2MVlrV9sw+2TiE0EHyVuHanmPNPKfJ5tp1mfF063n74MTJ5lHR9XvNplUb7Z3iFn5uwUDAuvTGYa/ZzmrkzormXsn/r0I9MTQ6w66VUh1SKabuLJB8zRxtwEye0RUusEQ/wZExPV2uSaO7wOH0/1iAgKwCTCdYT1YHcSL57PnL7xR9VJyJOB4Ql0WuB21Ezpf/EfjcA0WqSLMZRqKz1Oy37iBJn/6nDqqUUDWxc1z5xqok9vlEXsZ7mQbF8shnNHi62DHFwcKgO0WE5gXVuJGztse9S1xAVtlN9bKDulgzxUvHlEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PHUaX32//UmlLZr3kDOAUXue1NlS8qQrKgnTLnUUlQ8=; b=XHwvwt88wb9t6H48Qmx92qturkuKXXQ4WWS9Z2AVlqjflBQm3QcgWGZ57G1kvxPqPcXoyFCnDPf4SnRbkXq9+W/2I0ynfaIag0KXRon1otvvs4CKARWoH3oxuq9VU3VL/7/BgitQQoFFQ5FwLHL2DZBfZaPEc+SZWlNGQ/crENObJ+yUBQUNYD8pzgEkYnIhlmYQCBEzQTWNehKsvBXLwpW10GwGZ5hOs9uX0/dUejDc4Y/zXtXcFI6dqNsuKeYYGcgUSxCSgJO+SJdsj2tWlm8D/DTGl4iUAiLIu9NjeMEmZEgRgVIQTSWzQ89ItGPq+nQcafkhrT1B8gEWzG0xRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PHUaX32//UmlLZr3kDOAUXue1NlS8qQrKgnTLnUUlQ8=; b=9JUX8rc3TjSqdL/dCa9RQkfNASuy9h473eqsfrOsjZSeSN8qzRU4v7/jyWDxbuvMSXsOeNOvKZjScyQxC/fF8tafa7kCJEZLac2AWqIl58IJ1X8LfEh0SujH+XM75pAJ9YPReEzHYHLjgFOfTiS8oJk2LxsIl+gPujXlmOK3PKw= From: Bertrand Marquis To: Demi Marie Obenour CC: Xen developer discussion , =?iso-8859-1?Q?Marek_Marczykowski-G=F3recki?= , Simon Gaiser , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag Thread-Topic: Setting constant-time mode CPU flag Thread-Index: AQHYvnCFtdzK/xNtMUekqKxcT1Pan63T0s+A Date: Wed, 7 Sep 2022 10:51:55 +0000 Message-ID: <594CE8A6-472E-4379-AD8B-A292A92B7737@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 31f21974-7d28-406a-9e9c-08da90bf006c x-ms-traffictypediagnostic: DB9PR08MB7842:EE_|DBAEUR03FT023:EE_|AS8PR08MB6567:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wBWxjJgiemShewp6nrMK2oKFOPmGl4ExR3ZqUoXjjFhIRV3obTZtQ0HiR7+G+LNJVw+0plkJ05+4QBRGBHvGq6wQf+ainJ8cexxaJDofqjJKT1j0rCgfAVH8SXwUk9rEFs+SVS94zYA3vY6eU4K77u/twGa+2xq79Y5Kt7AyOOsiyP7kUrAT2JOy6B2GWJUqwVOdgWVqwUpZe3fWpyMSjV4xjx+LX0Ihua4GHsIOmoIgZ0pFrm05tDv81jeNzShvmUXow2KxD2TqMLc5vtAVBdA4s0oOYTd1l7+ghg23JT84xm8c3856aOsGY6LOP+PVwkYVQfwBNji7lAElyZbQnPsSzHfCAuQ1Wt/dWFC/wlEAbR3X42SCbPC8eGJ2b0iw42Y1cok110BRkNTNkV57bWvO5WgUVhh3PFPyDRC7QwQmosm3rGdZXriaX1BS7lajoqf2XgHUUgRMWX0OZRRTPeauAMnu5m0YFk9WnhvBQCv0f1ubtGMxZBtoWmK1bRYJH0Y8VFSUddLvUySBZ0eP2UgMXA97Gf9kr7kW1LLMKcsYz6AA4xJipAj0yiO7gaeppZjuN6BMG4Lj3SnY7kMDx1CG94+ug8EDSAMX0YV5bn3JxjO9lCo04WOT9XwsWVUVIVnQQp7IPwapVck93nG5zMernRtvV3PxqaqvkVRoqUKPXrJPDXiwi9mQRKnOr1dq7fwVR1Hpt56iosKojXw/plM1f6F6oJJ+zLfQgMqnFqkB1WIJskBJ1idTowajogq0oV+P7Vsfwf5Swzzb9ubhAssys7rYFRQFCOaFWDKjHcHm6djRSczv6TbBNP8THmCNf6SQ+weHiqyvbdSLsVxGMQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(122000001)(38100700002)(2616005)(966005)(6512007)(26005)(186003)(6486002)(71200400001)(36756003)(4744005)(33656002)(478600001)(8936002)(2906002)(5660300002)(76116006)(91956017)(86362001)(38070700005)(6916009)(54906003)(4326008)(66476007)(66556008)(66946007)(8676002)(66446008)(64756008)(41300700001)(316002)(6506007)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0B2103D13EB09B409B1E119A7A5E7B42@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7842 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6279f822-df34-48f1-f729-08da90befaf7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eyud7X7e/bcKsrJfCSeToRmXgxo7GneRRkYprIZjjZF2biBeQxMjEv+Th1qlaKnHpiJ21IMDTRs4F5vqv+ejSv5KrYdFsiqeRlXJTBan4qsREiRq/krFacVGz1TQ7rmCJ4Wdw2vGyZ7GwyQyIcOlOUJixxNMwK0UuSRJH8CmY7RvV80oFuJfmvMEx8M5s6uxzleT/Oxm24g6TPykyUKnHv7duMlnSjU9XeIGas5MQ08o41im2+mHon8uZKTZZTqoCa31jUq7USBiZld9Vn8RWJNaoMfO+ju45rKOlN3TSNI8j/P3CtjhMIDyRNklXcCjJDc0lrG9h7+blHg0l9CTOudFXGLgap8TDcmKnC8UWNKFy258RX5cpnRazGY5kQrabYLj7NbbBLIziK0pWsSXjoj6nA4DcuZzCllq/JCQ/4OIWJBymrVr5M/MvLUbFQLxshrHBuXXjl3vWdrNx0hpVGqgFqMIHEPUgKu29R2YlE4T7lANQFCFmSEob3loSrnivV1tvEePuHQz1n9EGHVD/uMbtGkgvZFMBGXHKcXXzHV8VK8g+ANeBR/808ZKr/VjeJcKFWRrDjhpFfJt2gUN47pKZVVzwV2EYtC1TWBM3C9yWO80DsMQ2RhGI91Ihb4rgTy54ayA+xqe3KoSuZne//cWgVOBAo0Fb50b3DzM9to3fzAHYHemirkojOejMp9XQlv74Z76A9l/nz5bmGQlySpi7qpwc1JsornGO02E9fXwv9aNIGN00IH4soxT3cl+w1xrXBbOR2DZIvFiG2m39pmT4/CH+UIqqoUJW+LV9Sw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(376002)(396003)(36840700001)(46966006)(40470700004)(4326008)(70206006)(8676002)(316002)(82310400005)(107886003)(54906003)(86362001)(36756003)(6512007)(26005)(47076005)(33656002)(70586007)(2616005)(336012)(186003)(4744005)(2906002)(356005)(81166007)(40480700001)(6862004)(8936002)(6486002)(53546011)(478600001)(36860700001)(41300700001)(5660300002)(6506007)(82740400003)(40460700003)(966005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 10:52:04.6618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31f21974-7d28-406a-9e9c-08da90bf006c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6567 Hi Demi, > On 2 Sep 2022, at 03:05, Demi Marie Obenour = wrote: >=20 > On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in This bit would not change anything on Arm currently so nothing is required = for now (and nothing has been done in Linux for ARM64). Thanks a lot for notifying us. Kind regards Bertrand > a CPU register to enforce constant-time execution. Linux plans to set > this bit by default; Xen should do the same. See > https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. > I recommend setting the bit unconditionally and ignoring guest attempts > to change it. > --=20 > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:53:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:53:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401217.643012 (Exim 4.92) (envelope-from ) id 1oVsge-0002BW-2Z; Wed, 07 Sep 2022 10:53:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401217.643012; Wed, 07 Sep 2022 10:53:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsgd-0002BP-W9; Wed, 07 Sep 2022 10:53:39 +0000 Received: by outflank-mailman (input) for mailman id 401217; Wed, 07 Sep 2022 10:53:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsgd-0002BJ-9k for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:53:39 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140073.outbound.protection.outlook.com [40.107.14.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53d72082-2e9b-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 12:53:38 +0200 (CEST) Received: from DB6PR0301CA0025.eurprd03.prod.outlook.com (2603:10a6:4:3e::35) by PAWPR08MB9760.eurprd08.prod.outlook.com (2603:10a6:102:2ea::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 10:53:36 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::5b) by DB6PR0301CA0025.outlook.office365.com (2603:10a6:4:3e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 10:53:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 10:53:35 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 10:53:35 +0000 Received: from 63eed57b8d15.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F43CD61-FAD4-415A-851A-D55D5005E15F.1; Wed, 07 Sep 2022 10:53:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 63eed57b8d15.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 10:53:25 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7670.eurprd08.prod.outlook.com (2603:10a6:102:244::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 10:53:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 10:53:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53d72082-2e9b-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YJeaJG2rjR8p5tITeRE85b36kEdpUQRlcb2urinBsNAQzAceffHP51mGZB5bsuaP7PgDgEKw4PutA1ceoN01vmQwdHPmM2+v4Ii9opVTHDKYGuIc8sJjADRYiJWpbtqZrJVHrW36Un6J3UuCoX7Zf8yZVtUUp3FQ1DBkuUZWtqrrKWiRPvHGziqEg5LjmJHSMjJxVXbUB7deReTbeEodjUl4BaGixcM8LHe+L16qLTt/NxmVX64krx52BOTeCv7edqLAOuuK6vE1BViym0ziO0hIEE7t+D1YXzizAfunM+86vfVAhx5mjltQamtwppcTvp3EBM9BBxW8DQJ4Ws06EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fb/XEvmuxNWXiPnyUv/3Sruj6Sd9xw1voR7XZPSYG0o=; b=D1UhnOa7Gi8GHX7mrZwxPPvJL3JGzjJx85uzgW3GmskNSrgRMNWcAT33w+M1oFcaG5rHFtG4iStx8sxBIdMcof6DXiI/KRY17t4pnLMFqw2/IPbmVbjRyIo4o+8z2xJmUDkrsyntHqnctK3cPkkoc/QJtjyyw7WHYUdhNcOcLMp5MFSzEaNRS0HEyUw4LFjspfZTiF26MGAU134IpZfWrJasLWzPig48cVlaWM5UZBdAC6U+kCtn9pTNwWRYliuY8myEtc3iK1zwgsjT26vr6izhaNKjiZ1zhAtbQIooT/6sni9c2ZZhD4YLeVhLr9U+Jd6bWIVTcDhbChgV9vt5eA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fb/XEvmuxNWXiPnyUv/3Sruj6Sd9xw1voR7XZPSYG0o=; b=dJeCjFZLkJKHRrNF4REkXx4frtX7Zu1Hwk7MuwD5Llf59dOP9/4AJzfHsPy3vKlK39xECBp7po10Zv8IJcygkJMI7UVRrFhQC8M8cp7E6jiIQlqAeUaWn5x7CRAwM14PZCA+78JmsftpsMeCm4SDVY2vAzVG7TBOuTQwanlLm7A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jFi7qdCkqQdCz0DsonLfKLpdK1oNqhmQYfV4H3UTphzu/7i/6XrVI4erNhMYf+pYynpm0cy6IVS5GL1thBDYhDVNqNQMGFkQlYoiaXxhyCtb/a6e3+5wFyVqnW8PA2YNJKGzYwTg9bSYXs3hmgAsh6Z93mE1g5bZd9ggOpYd/MCT0cU7R4r8+YleHGR+o2o5t2ehMMhHAii+xwqC05bwUfYCxSUf0LWasKuXgI6YG8R/Pu4KHX5GNjLEhV1HE79+rDA8SNdpgo9PF37DVfj0FThJi3CeZIEa0oTX4ZNPaqTbey/AOflAx8rMugQ842AQtiea7BSiRvn93A+ZEN0vdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fb/XEvmuxNWXiPnyUv/3Sruj6Sd9xw1voR7XZPSYG0o=; b=WdOSS4EElH0jNtZp23tGlQ075OpG1f2qolez3bmQZT9tfm7wnAO48sZBr7Mqo5hnOOyYCxLq5AMSG0Lv4CDu+B0wJAOq6/coAU2tuX4z1STTicPtsZNi5fZjruTtAD9fqgAOPeMjTM/oJPWSZhDKPaAMRRByUzKJ2q1oLpP+RAqZyVQF8dZNOSqNPeHd/IMwn3hxWdY6uQiOU8bJsC+5YSmfRDU8sMEfu3s05cJ83tmuT1l0G9+6LQbO0sfjoS717Lsvrjhs2QyuuMus1do7uW3AEG6Lgbh22C+SLeQXVPnVOtmasSknkSq4Qx0JMxEXQhOwz70ztGP8pV0KAsKk3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fb/XEvmuxNWXiPnyUv/3Sruj6Sd9xw1voR7XZPSYG0o=; b=dJeCjFZLkJKHRrNF4REkXx4frtX7Zu1Hwk7MuwD5Llf59dOP9/4AJzfHsPy3vKlK39xECBp7po10Zv8IJcygkJMI7UVRrFhQC8M8cp7E6jiIQlqAeUaWn5x7CRAwM14PZCA+78JmsftpsMeCm4SDVY2vAzVG7TBOuTQwanlLm7A= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Topic: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Index: AQHYwpULGFLWtgCBlkSkZYDaahDS7q3TxKQAgAAEM/A= Date: Wed, 7 Sep 2022 10:53:23 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-4-Henry.Wang@arm.com> <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> In-Reply-To: <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D525D76B850BA44084D0882D03840286.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5adc593d-7c45-4aad-7a37-08da90bf36bf x-ms-traffictypediagnostic: PAXPR08MB7670:EE_|DBAEUR03FT049:EE_|PAWPR08MB9760:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jYcpHKyPUgbZ/pbqsRA/+eiEFZdt5nQGzE6FoLngXvoa1gXtyrlOiiYqpTpPVJKsqB5Uo17O4vJAJyW8XjGDqI9ZJp0lm5RJFyfX81QXa6ESe5+wYJRkjhCSbRF2O92gX2oxxR1HVGLOi3xiMc8tn2OGM8+PnPhUb2JVP7CD1MlXlH3d9ZOoF4a4LCpDxd51kP2sZoS478CgJuHGteChDPyNC7tauuhVp+ldJ/9MDTXfFJJTrVD2K/JV08AfigDW/ohEoHfo4tVRRlRllJ4pzyA2OgiqeSsKXuFk2b7FwT8FKMkl9tfxPRhxAJRQLL4gEC/LTUYjZ41ev5JCpSPna9D94e8NUzCPFu9iZKYgnzvVR4bog/tSm4d+MteUZ8C5Kz751CVqquSJQuJ8/C8KdnkUYoNqKEsSlKYN2sA2dw7Bu8UEzR1i33yRYsL2YxUDb5POGaYxHJ5gXRiZ2J8IjTb+q87eFIN7R5UkpidaLI8UsZV0BhtjKufp+FNoYfqDNtQ7l8wgIaI/8VDOYush6vQrE33l0NIOy1ITj1WXR51ftQfTaX4BFIVNajZQiqOOkZHD/uYDKfOBfcBeyhlxAVu1/KP9QfqGATh664bTJzcvS1k0jPACvtZip0H4bSfRF90rQRfMBNz3JL9wiqT0YphflWUN49Ol/JywzF5LHtEvSaKMKI36kPjwu8xgN3HqAixNewMQC5OZE6JUPuM85qYHyQ55B3jWrvbpJbFR0a74c5dGKyu9hqKttv8JrJmEd/lJB5vfGOV4UlSVenXY4g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(38070700005)(83380400001)(33656002)(4326008)(76116006)(66556008)(122000001)(8676002)(66446008)(2906002)(38100700002)(64756008)(66946007)(66476007)(186003)(5660300002)(316002)(52536014)(8936002)(86362001)(55016003)(478600001)(9686003)(6506007)(41300700001)(71200400001)(53546011)(26005)(7696005)(110136005)(54906003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7670 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4285c8f3-fe35-40e0-ed21-08da90bf2fa1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 16JQso7R/8+XVHvYCOIDCOSWTFrS9DNmSVEPYd8vN7IOM7K9k4UV5vfugv9TyqAUhqGwkiumFxQ7X8Ml2u1FQZklp3hbPEyPL/Wq++xDom/4BMrbyrO0TP62fnjVy0pJX3c8Epxwjf9lYgp8XH2bhO+y4iCaeePBACfL8LQxOAmNDWgZdA13FLFmhD/jDnLq8PB0PCrSepVZLblYLPenPRvlBt7QliX/pd7VYQ7N9+jLPrNN+pIIYqT4EUwd+SY084y3+dnPyaaXzRdq5r9g7PFGQcXrtHZ2thMCy6H75BSzpNeZ+z7AxoHRd4VVX+BTjcnTREqshV97gYoK9jQ+TbsMblN2ddnOSx+tKSABQfNsPmWceNfigCXa5romOc0qjv5/d802sfkxxmmPPvqF9hBjeqEC9Vfn/3YeNnkDlCiuq00jz8PRRQYP3ypvi0gvQZ7OmyK5X0LNP865UaDVPxONasBFR06kOG39awIvrNOjhCGP0wZF/S/XbG58lTmI6MIzZSloR+dSqxxacbNgrks3r3BoAuVse3BhbS3YPMYbF3pn7oKHfhdvngBfWAIrVF1+3YO40QcrE3fU1iQnqdIdok+fRqX2lc7kS3PIaIbLtS3C0OsXLneRApg9Db7XIGezkHi1/+GnJCXHAjU44rVb2miu/zeadxfIYBkSzpbd9Zem7gpBIhiVl8WjbfYNu2M8ZJWIxiGgGzg4Qc+duvvTbg11s1wsAvl6amiPkdtztUIr2sSR0Od6WrIIj5tdqn7GaJIGL8fb70rkDDZ2hQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(136003)(346002)(46966006)(36840700001)(40470700004)(33656002)(40460700003)(83380400001)(54906003)(36860700001)(8936002)(478600001)(8676002)(110136005)(4326008)(55016003)(82310400005)(70586007)(82740400003)(40480700001)(52536014)(86362001)(316002)(53546011)(356005)(107886003)(9686003)(2906002)(26005)(7696005)(6506007)(70206006)(41300700001)(47076005)(186003)(81166007)(336012)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 10:53:35.8018 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5adc593d-7c45-4aad-7a37-08da90bf36bf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9760 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMy80XSB4 ZW4vYXJtOiBtbTogUmVuYW1lIHhlbmhlYXBfKiB2YXJpYWJsZSB0bw0KPiBkaXJlY3RtYXBfKg0K PiANCj4gSGkgSGVucnksDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDA5OjM2LCBIZW5yeSBXYW5nIHdy b3RlOg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbW0uYyBiL3hlbi9hcmNoL2FybS9t bS5jDQo+ID4gaW5kZXggN2Y1YjMxN2QzZS4uNGE3MGVkMjk4NiAxMDA2NDQNCj4gPiAtLS0gYS94 ZW4vYXJjaC9hcm0vbW0uYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9tbS5jDQo+ID4gQEAgLTEz MiwxMiArMTMyLDEyIEBAIHVpbnQ2NF90IGluaXRfdHRicjsNCj4gPiAgIHN0YXRpYyBwYWRkcl90 IHBoeXNfb2Zmc2V0Ow0KPiA+DQo+ID4gICAvKiBMaW1pdHMgb2YgdGhlIFhlbiBoZWFwICovDQo+ ID4gLW1mbl90IHhlbmhlYXBfbWZuX3N0YXJ0IF9fcmVhZF9tb3N0bHkgPSBJTlZBTElEX01GTl9J TklUSUFMSVpFUjsNCj4gPiAtbWZuX3QgeGVuaGVhcF9tZm5fZW5kIF9fcmVhZF9tb3N0bHk7DQo+ ID4gLXZhZGRyX3QgeGVuaGVhcF92aXJ0X2VuZCBfX3JlYWRfbW9zdGx5Ow0KPiA+ICttZm5fdCBk aXJlY3RtYXBfbWZuX3N0YXJ0IF9fcmVhZF9tb3N0bHkgPSBJTlZBTElEX01GTl9JTklUSUFMSVpF UjsNCj4gPiArbWZuX3QgZGlyZWN0bWFwX21mbl9lbmQgX19yZWFkX21vc3RseTsNCj4gPiArdmFk ZHJfdCBkaXJlY3RtYXBfdmlydF9lbmQgX19yZWFkX21vc3RseTsNCj4gPiAgICNpZmRlZiBDT05G SUdfQVJNXzY0DQo+ID4gLXZhZGRyX3QgeGVuaGVhcF92aXJ0X3N0YXJ0IF9fcmVhZF9tb3N0bHk7 DQo+ID4gLXVuc2lnbmVkIGxvbmcgeGVuaGVhcF9iYXNlX3BkeCBfX3JlYWRfbW9zdGx5Ow0KPiA+ ICt2YWRkcl90IGRpcmVjdG1hcF92aXJ0X3N0YXJ0IF9fcmVhZF9tb3N0bHk7DQo+ID4gK3Vuc2ln bmVkIGxvbmcgZGlyZWN0bWFwX2Jhc2VfcGR4IF9fcmVhZF9tb3N0bHk7DQo+ID4gICAjZW5kaWYN Cj4gPg0KPiA+ICAgdW5zaWduZWQgbG9uZyBmcmFtZXRhYmxlX2Jhc2VfcGR4IF9fcmVhZF9tb3N0 bHk7DQo+ID4gQEAgLTYwOSw3ICs2MDksNyBAQCB2b2lkIF9faW5pdCBzZXR1cF94ZW5oZWFwX21h cHBpbmdzKHVuc2lnbmVkDQo+IGxvbmcgYmFzZV9tZm4sDQo+IA0KPiBJIHRoaW5rIHRoZSBmdW5j dGlvbiBhbHNvIHdhbnQgdG8gYmUgcmVuYW1lZCB0byBtYXRjaCB0aGUgY29kZSBiZWxvdy4NCg0K SG1tbSwgcmVuYW1pbmcgdGhlIG5hbWUgdG8gInNldHVwX2RpcmVjdG1hcF9tYXBwaW5ncyIgd291 bGQNCnNvbWVob3cgbGVhZCBtZSB0byB0aGluayBvZiB3ZSBhcmUgZ2V0dGluZyByaWQgb2YgdGhl IG5hbWUgInhlbmhlYXAiDQpjb21wbGV0ZWx5IGluIHRoZSBjb2RlLCB3aGljaCBzZWVtcyBhIGxp dHRsZSBiaXQgc2NhcnkgdG8gbWUuLi4NCg0KQnV0IEkganVzdCBjaGVja2VkIHRoZXJlIGlzIGEg Y29tbWVudA0KIi8qIFNldCB1cCB0aGUgeGVuaGVhcDogdXAgdG8gMUdCIG9mIGNvbnRpZ3VvdXMs IGFsd2F5cy1tYXBwZWQgbWVtb3J5LiINCmFib3ZlIHRoZSBmdW5jdGlvbiBhbmQgdGhlIGRlY2xh cmF0aW9uIHNvIEkgZ3Vlc3Mgd2UgYXJlIGZpbmU/DQoNCj4gDQo+ID4gICAgICAgICAgIHBhbmlj KCJVbmFibGUgdG8gc2V0dXAgdGhlIHhlbmhlYXAgbWFwcGluZ3MuXG4iKTsNCj4gDQo+IExpa2Vs eSwgSSB0aGluayB0aGlzIHdhbnRzIHRvIGJlIHMveGVuaGVhcC9kaXJlY3RtYXAvDQoNCk9rLg0K DQo+IA0KPiA+DQo+ID4gICAgICAgLyogUmVjb3JkIHdoZXJlIHRoZSB4ZW5oZWFwIGlzLCBmb3Ig dHJhbnNsYXRpb24gcm91dGluZXMuICovDQo+IA0KPiBTYW1lIGhlcmUgYmVjYXVzZSB5b3Ugc2V0 IGRpcmVjdG1hcF92aXJ0X2VuZC4NCg0KT2suDQoNCj4gDQo+ID4gLSAgICB4ZW5oZWFwX3ZpcnRf ZW5kID0gWEVOSEVBUF9WSVJUX1NUQVJUICsgbnJfbWZucyAqIFBBR0VfU0laRTsNCj4gPiArICAg IGRpcmVjdG1hcF92aXJ0X2VuZCA9IFhFTkhFQVBfVklSVF9TVEFSVCArIG5yX21mbnMgKiBQQUdF X1NJWkU7DQo+IA0KPiBJIHdvdWxkIGJlIE9LIHRvIGtlZXAgIlhFTkhFQVBfKiIgZm9yIG5vdy4N Cg0KVGhhbmtzIGZvciB5b3VyIGNvbmZpcm1hdGlvbi4NCg0KPiANCj4gPiAgIH0NCj4gPiAgICNl bHNlIC8qIENPTkZJR19BUk1fNjQgKi8NCj4gPiAgIHZvaWQgX19pbml0IHNldHVwX3hlbmhlYXBf bWFwcGluZ3ModW5zaWduZWQgbG9uZyBiYXNlX21mbiwNCj4gPiBAQCAtNjE4LDEyICs2MTgsMTIg QEAgdm9pZCBfX2luaXQgc2V0dXBfeGVuaGVhcF9tYXBwaW5ncyh1bnNpZ25lZA0KPiBsb25nIGJh c2VfbWZuLA0KPiA+ICAgICAgIGludCByYzsNCj4gPg0KPiA+ICAgICAgIC8qIEZpcnN0IGNhbGwg c2V0cyB0aGUgeGVuaGVhcCBwaHlzaWNhbCBhbmQgdmlydHVhbCBvZmZzZXQuICovDQo+IA0KPiBz L3hlbmhlYXAvZGlyZWN0bWFwLyBJIGhhdmVuJ3QgbG9va2VkIGlmIHRoZXJlIGFyZSBvdGhlciBp bnN0YW5jZXMgaW4NCj4gdGhlIGZ1bmN0aW9uLg0KDQpEb24ndCBib3RoZXIsIEkgd2lsbCB0YWtl IGNhcmUgb2YgdGhlIHJlc3QuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVy cywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:57:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401226.643024 (Exim 4.92) (envelope-from ) id 1oVskE-0002sH-Lk; Wed, 07 Sep 2022 10:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401226.643024; Wed, 07 Sep 2022 10:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVskE-0002sA-Ig; Wed, 07 Sep 2022 10:57:22 +0000 Received: by outflank-mailman (input) for mailman id 401226; Wed, 07 Sep 2022 10:57:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVskD-0002s0-5z; Wed, 07 Sep 2022 10:57:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVskD-0003Kl-1a; Wed, 07 Sep 2022 10:57:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVskC-0006su-MQ; Wed, 07 Sep 2022 10:57:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVskC-0001tw-Lx; Wed, 07 Sep 2022 10:57:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dv3KBwrijm+gYJRuGT2YWE+6YxxIi3Xuc2WxHaY1vyI=; b=qUlyLP2vaCFcxO8EruAIJUw3SN EyP0X3kRpw2W9uYQvkftAekAQK20do0XcAffsfZSLtErSclUIdY4lT+fnqIJ8xdp6dNNbPvQYm6y1 yLq300RGeRYwewLbS+ED+eegTNdtudUAz77r8Jp8/EoXHozGfpmAp0YKxsl4C+Mav3O4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173035: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2ce45ddea373e18fae27aa1b87cc7db7b2390f4d X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 07 Sep 2022 10:57:20 +0000 flight 173035 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173035/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 2ce45ddea373e18fae27aa1b87cc7db7b2390f4d baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 789 days Failing since 151818 2020-07-11 04:18:52 Z 788 days 770 attempts Testing same since 173035 2022-09-07 04:19:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122037 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 10:59:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 10:59:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401235.643036 (Exim 4.92) (envelope-from ) id 1oVsmc-0003Zy-4g; Wed, 07 Sep 2022 10:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401235.643036; Wed, 07 Sep 2022 10:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsmb-0003Zr-W3; Wed, 07 Sep 2022 10:59:49 +0000 Received: by outflank-mailman (input) for mailman id 401235; Wed, 07 Sep 2022 10:59:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsma-0003Zl-TE for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 10:59:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsma-0003Ns-LY; Wed, 07 Sep 2022 10:59:48 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVsma-0004AC-FG; Wed, 07 Sep 2022 10:59:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DwSWP9bKQIZQ/7Mt9ErlQ/vMBg/HCtrxWlPaHEVJu4Q=; b=EeNl6JFtw9tERJeNv35hqqUdg4 IH2EcJiUgxmw1pEU4fSrPJNp3oalK+zHL56VvQeEF16UmhWCrUd+bOLdiHYhQJTJpESXubpd5GmV3 YMgukggxbCVo7/EKD+KqMTjREocuorVv+83ZMjtjhSQoNCQ3mMyFligpYw8w8Xtr1+sY=; Message-ID: Date: Wed, 7 Sep 2022 11:59:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-4-Henry.Wang@arm.com> <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 11:53, Henry Wang wrote: >> -----Original Message----- >> From: Julien Grall >> Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to >> directmap_* >> >> Hi Henry, >> >> On 07/09/2022 09:36, Henry Wang wrote: >>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c >>> index 7f5b317d3e..4a70ed2986 100644 >>> --- a/xen/arch/arm/mm.c >>> +++ b/xen/arch/arm/mm.c >>> @@ -132,12 +132,12 @@ uint64_t init_ttbr; >>> static paddr_t phys_offset; >>> >>> /* Limits of the Xen heap */ >>> -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; >>> -mfn_t xenheap_mfn_end __read_mostly; >>> -vaddr_t xenheap_virt_end __read_mostly; >>> +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; >>> +mfn_t directmap_mfn_end __read_mostly; >>> +vaddr_t directmap_virt_end __read_mostly; >>> #ifdef CONFIG_ARM_64 >>> -vaddr_t xenheap_virt_start __read_mostly; >>> -unsigned long xenheap_base_pdx __read_mostly; >>> +vaddr_t directmap_virt_start __read_mostly; >>> +unsigned long directmap_base_pdx __read_mostly; >>> #endif >>> >>> unsigned long frametable_base_pdx __read_mostly; >>> @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned >> long base_mfn, >> >> I think the function also want to be renamed to match the code below. > > Hmmm, renaming the name to "setup_directmap_mappings" would > somehow lead me to think of we are getting rid of the name "xenheap" > completely in the code, which seems a little bit scary to me... > > But I just checked there is a comment > "/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory." > above the function and the declaration so I guess we are fine? We are not getting rid of "xenheap". In fact the common code will continue to use the concept. What we make clear is this function is not only here to map the xenheap but other memory (e.g. static domain memory on arm64). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:00:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401236.643046 (Exim 4.92) (envelope-from ) id 1oVsmz-0004q2-AS; Wed, 07 Sep 2022 11:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401236.643046; Wed, 07 Sep 2022 11:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsmz-0004p3-7R; Wed, 07 Sep 2022 11:00:13 +0000 Received: by outflank-mailman (input) for mailman id 401236; Wed, 07 Sep 2022 11:00:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsmx-0004oV-KF for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:00:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3dab2ac5-2e9c-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:00:10 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0A82C2033D; Wed, 7 Sep 2022 11:00:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D477413486; Wed, 7 Sep 2022 11:00:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +m1RM7l5GGMSVwAAMHmgww (envelope-from ); Wed, 07 Sep 2022 11:00:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dab2ac5-2e9c-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662548410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HmaE7iOjn6DeLFkNOLr8ASPOm5MulkrwVeS3GjvYnFQ=; b=XJuKUxE3K2H/o+zbOpLWLhtXEgxHdoiWAQxKGUR4cKIaV8UfyJO/UQK0u1N/Q0GiZv99Cx kg8xGbUHizgdfJURCEVo7e1R7yjc93Oufl/51InNOknj8+BajqsA6lihzRcavskk7trfVf XL6FEF6zeAMocGbRwpJqhrx4BFTASfU= Date: Wed, 7 Sep 2022 13:00:09 +0200 From: Michal Hocko To: Kent Overstreet Cc: Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906182058.iijmpzu4rtxowy37@kmo-framework> On Tue 06-09-22 14:20:58, Kent Overstreet wrote: [...] > Otherwise, saying "code has to be maintained" is a little bit like saying water > is wet, and we're all engineers here, I think we know that :) Hmm, it seems that further discussion doesn't really make much sense here. I know how to use my time better. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:02:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401249.643057 (Exim 4.92) (envelope-from ) id 1oVsot-0005Yq-MM; Wed, 07 Sep 2022 11:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401249.643057; Wed, 07 Sep 2022 11:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsot-0005Yj-JN; Wed, 07 Sep 2022 11:02:11 +0000 Received: by outflank-mailman (input) for mailman id 401249; Wed, 07 Sep 2022 11:02:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsor-0005Yd-Lf for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:02:09 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83b1adb6-2e9c-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:02:07 +0200 (CEST) Received: by mail-ej1-x634.google.com with SMTP id u9so29525240ejy.5 for ; Wed, 07 Sep 2022 04:02:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83b1adb6-2e9c-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=3XynEqfR8DIwjsD7CvLySAYT6uxTQTASBfDS7i4m8IY=; b=AguQvW8bDAXzx9Z9IpjxvHjy5T8rBZ/l7YyfSjKDdOBFWVsn0OiMBjNFjlmU7ZsfQn GTegBcoEX0m/Gu6FDOTSLRoZqHu/W5+ryQbUZdxKJP6v94xTLC4drO0docNeFNAZuUZl NToIMshj/xhJo73WR5m6pk32Jw/aaQ9dh50kl4jH5W8jstztCOdWIpISVO5sy98+tzHC JGz2ewCmhIfSXie4wRPUf92NQ/5fYi4LS/cbcUS2niWJT1ferWnT/sAf3qaYwWvM+2mU INHmP/tWbvlm7TuwW/0H3ld9cScCMzjnwpfK07HL4QVPmlf2vis4vWBh2STFsAWYdW8u 26zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=3XynEqfR8DIwjsD7CvLySAYT6uxTQTASBfDS7i4m8IY=; b=Ap+i04Ri1ZC7vh5yW6SmyFNS9gyzcaYCJq4z6aRkZCVV8AV/b2Afp9nktDKxCQqFXw raYjwqFlTqt+c9y6diCxauWEhQW+hKvYjRmln8r/sxgckGnRRGeX+L8/C4i7sV4usItY vrXPWKJl0wT0wQGG/caZ68XkL2g2uckB8rlZSUXQAYEcJ5/MOsA7rur4y0xbN6CX+ttI qtPsrDYZEmjwjh/7nhhaNy0W1uPXwrRQgYUcc6gSkzvUmOl8mPwkxv7dTlKutZJZikuf UdMwv0pFxhWuiwUnkusPTc2Qiv0IgEKYmNV3dkqVOR/YkxU72m653MwKJ8jyqWB6oyWQ mFqA== X-Gm-Message-State: ACgBeo0i6TznfkpZUbtKPR6TEJzs3xc2UFiU3sGX9u2aPyuGYs6iAD6H Or9Feg6MNsvRpibIwlTxQO2aNQKCt6omEsFMcRoT88qw2Eg= X-Google-Smtp-Source: AA6agR6QB5yv0Gvbc7vfU8VmhFzyKThzy1+3wNXMdPGms7/SFC7pmrOkdqVUQX3QkyX0qqThMtHu3h0LrKu+cEjtXII= X-Received: by 2002:a17:907:6297:b0:72f:9aad:fcb with SMTP id nd23-20020a170907629700b0072f9aad0fcbmr1936186ejc.161.1662548526941; Wed, 07 Sep 2022 04:02:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: A Sudheer Date: Wed, 7 Sep 2022 16:31:54 +0530 Message-ID: Subject: Re: USB-C 250GB SSD Passthrough fails to DomU Ubuntu To: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="0000000000005eca1205e8143e89" --0000000000005eca1205e8143e89 Content-Type: text/plain; charset="UTF-8" Hi All, Is anyone aware if this a general limitation of DomU Or is there a way to convince DomU to expose USB host controllers with streams support ? Thanks Sudheer On Tue, Aug 30, 2022 at 1:34 PM A Sudheer wrote: > Few more logs > > From Dom0, did passthrough of two USB drives (32GB stick and 250GB USB SDD) > In DomU, 32GB driver got mounted but 250GB SSD fails to mount. > In DomU, "lsusb" shows both the drives but "usb-devices" shows only the > 32GB drive. > > *Dom0 log:* > amd@HOST:~$ sudo xl usb-list vm1 > Devid Type BE state usb-ver ports > 0 devicemodel 0 0 3 15 > Port 1: Bus 003 Device 002 > Port 2: Bus 005 Device 002 > Port 3: > Port 4: > Port 5: > Port 6: > Port 7: > Port 8: > Port 9: > Port 10: > Port 11: > Port 12: > Port 13: > Port 14: > Port 15: > HOST:~$ > > *DomU Log:* > amd@VM1:~$ lsusb > Bus 003 Device 003: ID 0781:558c SanDisk Corp. Extreme Portable SSD > Bus 003 Device 002: ID 0781:5581 SanDisk Corp. Ultra > Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > Bus 001 Device 002: ID 0627:0001 Adomax Technology Co., Ltd QEMU USB Tablet > Bus 001 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > amd@VM1:~$ > > *amd@VM1:~$ usb-devices* > > T: Bus=01 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=12 MxCh= 2 > D: Ver= 1.10 Cls=09(hub ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=1d6b ProdID=0001 Rev=05.18 > S: Manufacturer=Linux 5.18.0-4460-amd+ uhci_hcd > S: Product=UHCI Host Controller > S: SerialNumber=0000:00:01.2 > C: #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=00 Driver=hub > E: Ad=81(I) Atr=03(Int.) MxPS= 2 Ivl=255ms > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs= 1 > P: Vendor=0627 ProdID=0001 Rev=00.00 > S: Manufacturer=QEMU > S: Product=QEMU USB Tablet > S: SerialNumber=42 > C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=100mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid > E: Ad=81(I) Atr=03(Int.) MxPS= 8 Ivl=10ms > > T: Bus=02 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=480 MxCh=15 > D: Ver= 2.00 Cls=09(hub ) Sub=00 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=1d6b ProdID=0002 Rev=05.18 > S: Manufacturer=Linux 5.18.0-4460-amd+ xhci-hcd > S: Product=xHCI Host Controller > S: SerialNumber=0000:00:04.0 > C: #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=00 Driver=hub > E: Ad=81(I) Atr=03(Int.) MxPS= 4 Ivl=256ms > > T: Bus=03 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=5000 MxCh=15 > D: Ver= 3.00 Cls=09(hub ) Sub=00 Prot=03 MxPS= 9 #Cfgs= 1 > P: Vendor=1d6b ProdID=0003 Rev=05.18 > S: Manufacturer=Linux 5.18.0-4460-amd+ xhci-hcd > S: Product=xHCI Host Controller > S: SerialNumber=0000:00:04.0 > C: #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=00 Driver=hub > E: Ad=81(I) Atr=03(Int.) MxPS= 4 Ivl=256ms > > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 > D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1 > P: Vendor=0781 ProdID=5581 Rev=01.00 > S: Manufacturer= USB > *S: Product= SanDisk 3.2Gen1* > S: > SerialNumber=040143504c9a3bd4596082500826a11868845df4396ebc5cb2e33dd3071e3fd5505f000000000000000000003ca6a60b000d7c18815581071b2a7c33 > C: #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=896mA > I: If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage > E: Ad=02(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms > E: Ad=81(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms > amd@VM1:~$ > > *amd@VM1:~$ sudo dmesg * > > [ 247.071742] usb 3-2: new SuperSpeed USB device number 3 using xhci_hcd > [ 247.097304] usb 3-2: New USB device found, idVendor=0781, > idProduct=558c, bcdDevice=10.12 > [ 247.097314] usb 3-2: New USB device strings: Mfr=2, Product=3, > SerialNumber=1 > [ 247.097318] usb 3-2: Product: Extreme SSD > [ 247.097321] usb 3-2: Manufacturer: SanDisk > [ 247.097323] usb 3-2: SerialNumber: 31393430475A343030363932 > [ 247.101909] usb 3-2: USB controller 0000:00:04.0 does not support > streams, which are required by the UAS driver. > [ 247.101915] usb 3-2: Please try an other USB controller if you wish to > use UAS. > [ 247.101918] usb-storage 3-2:1.0: USB Mass Storage device detected > [ 247.102710] scsi host3: usb-storage 3-2:1.0 > [ 269.131522] usb 3-2: reset SuperSpeed USB device number 3 using xhci_hcd > > *DomU dmesg log while adding USB controller and USB 32GB disk* > > [ 94.494852] pci 0000:00:04.0: [1033:0194] type 00 class 0x0c0330 > [ 94.496278] pci 0000:00:04.0: reg 0x10: [mem 0x00000000-0x00003fff > 64bit] > [ 94.502161] pci 0000:00:04.0: BAR 0: assigned [mem > 0xf1800000-0xf1803fff 64bit] > [ 94.502981] pci 0000:00:04.0: enabling device (0000 -> 0002) > [ 94.504005] xen: --> pirq=24 -> irq=32 (gsi=32) > [ 94.514634] xhci_hcd 0000:00:04.0: xHCI Host Controller > [ 94.514650] xhci_hcd 0000:00:04.0: new USB bus registered, assigned bus > number 2 > [ 94.517840] xhci_hcd 0000:00:04.0: hcc params 0x00080001 hci version > 0x100 quirks 0x0000000000000014 > [ 94.523559] usb usb2: New USB device found, idVendor=1d6b, > idProduct=0002, bcdDevice= 5.18 > [ 94.523571] usb usb2: New USB device strings: Mfr=3, Product=2, > SerialNumber=1 > [ 94.523575] usb usb2: Product: xHCI Host Controller > [ 94.523579] usb usb2: Manufacturer: Linux 5.18.0-4460-amd+ xhci-hcd > [ 94.523581] usb usb2: SerialNumber: 0000:00:04.0 > [ 94.523974] hub 2-0:1.0: USB hub found > [ 94.524850] hub 2-0:1.0: 15 ports detected > [ 94.529968] xhci_hcd 0000:00:04.0: xHCI Host Controller > [ 94.529981] xhci_hcd 0000:00:04.0: new USB bus registered, assigned bus > number 3 > [ 94.529988] xhci_hcd 0000:00:04.0: Host supports USB 3.0 SuperSpeed > [ 94.530354] usb usb3: We don't know the algorithms for LPM for this > host, disabling LPM. > [ 94.530400] usb usb3: New USB device found, idVendor=1d6b, > idProduct=0003, bcdDevice= 5.18 > [ 94.530404] usb usb3: New USB device strings: Mfr=3, Product=2, > SerialNumber=1 > [ 94.530407] usb usb3: Product: xHCI Host Controller > [ 94.530410] usb usb3: Manufacturer: Linux 5.18.0-4460-amd+ xhci-hcd > [ 94.530412] usb usb3: SerialNumber: 0000:00:04.0 > [ 94.530653] hub 3-0:1.0: USB hub found > [ 94.531482] hub 3-0:1.0: 15 ports detected > [ 157.522609] usb 3-1: new SuperSpeed USB device number 2 using xhci_hcd > [ 157.548225] usb 3-1: New USB device found, idVendor=0781, > idProduct=5581, bcdDevice= 1.00 > [ 157.548236] usb 3-1: New USB device strings: Mfr=1, Product=2, > SerialNumber=3 > [ 157.548239] usb 3-1: Product: SanDisk 3.2Gen1 > [ 157.548242] usb 3-1: Manufacturer: USB > [ 157.548244] usb 3-1: SerialNumber: > 040143504c9a3bd4596082500826a11868845df4396ebc5cb2e33dd3071e3fd5505f000000000000000000003ca6a60b000d7c18815581071b2a7c33 > [ 157.571419] usb-storage 3-1:1.0: USB Mass Storage device detected > [ 157.571981] scsi host2: usb-storage 3-1:1.0 > [ 157.572125] usbcore: registered new interface driver usb-storage > [ 157.577381] usbcore: registered new interface driver uas > [ 158.581138] scsi 2:0:0:0: Direct-Access USB SanDisk 3.2Gen1 > 1.00 PQ: 0 ANSI: 6 > [ 158.581550] sd 2:0:0:0: Attached scsi generic sg0 type 0 > [ 158.584622] sd 2:0:0:0: [sda] 60088320 512-byte logical blocks: (30.8 > GB/28.7 GiB) > [ 158.590171] sd 2:0:0:0: [sda] Write Protect is off > [ 158.590181] sd 2:0:0:0: [sda] Mode Sense: 43 00 00 00 > [ 158.593387] sd 2:0:0:0: [sda] Write cache: disabled, read cache: > enabled, doesn't support DPO or FUA > [ 158.614589] sda: sda1 > [ 158.627564] sd 2:0:0:0: [sda] Attached SCSI removable disk > > > On Tue, Aug 30, 2022 at 11:12 AM A Sudheer wrote: > >> Hi All >> >> On XEN-4.16 with Ubuntu 22.04 Dom0 and HVM-DomU, I tried to do a USB mass >> storage device passthrough to DomU. >> I followed the PVUSB method mentioned in >> https://wiki.xenproject.org/wiki/Xen_USB_Passthrough. >> >> I am able to do passthrough for USB 2.0 and 3.x version 32/64 GB mass >> storage devices to DomU. >> Passthrough failed for "SanDisk 250GB SSD USB-C, USB 3.1" with below >> error. Able to access the SSD in Dom0. >> Can someone help with what could be missing here. >> >> *Commands used:* >> host$ sudo xl usbctrl-attach vm1 version=3 ports=6 >> host$ sudo xl usbdev-attach vm1 hostbus=3 hostaddr=2 >> >> *Error Log in DomU* >> VM1:~$ sudo dmesg >> [ 152.841566] usb 2-1: new SuperSpeed USB device number 2 using xhci_hcd >> [ 152.867164] usb 2-1: New USB device found, idVendor=0781, >> idProduct=558c, bcdDevice=10.12 >> [ 152.867173] usb 2-1: New USB device strings: Mfr=2, Product=3, >> SerialNumber=1 >> [ 152.867177] usb 2-1: Product: Extreme SSD >> [ 152.867179] usb 2-1: Manufacturer: SanDisk >> [ 152.867182] usb 2-1: SerialNumber: 31393430475A343030363932 >> [ 152.899103] *usb 2-1: USB controller 0000:00:04.0 does not support >> streams, which are required by the UAS driver.* >> [ 152.899110] usb 2-1: Please try an other USB controller if you wish to >> use UAS. >> [ 152.899113] usb-storage 2-1:1.0: USB Mass Storage device detected >> [ 152.902033] scsi host2: usb-storage 2-1:1.0 >> [ 152.902174] usbcore: registered new interface driver usb-storage >> [ 152.908928] usbcore: registered new interface driver uas >> [ 174.933399] usb 2-1: reset SuperSpeed USB device number 2 using >> xhci_hcd >> >> Thanks >> Sudheer >> > --0000000000005eca1205e8143e89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All,

Is anyone aware if this a general limitati= on of DomU Or is there a way to convince DomU to expose USB host controller= s with streams support ?

Thanks
Sudheer

On Tue, Aug 30, = 2022 at 1:34 PM A Sudheer <asr7247@= gmail.com> wrote:
Few more logs

From Dom0, did= passthrough of two USB drives (32GB stick and 250GB USB SDD)
In = DomU, 32GB driver got mounted but 250GB SSD fails to mount.
In Do= mU, "lsusb" shows both the drives but "usb-devices"=C2= =A0shows only the 32GB drive.

Dom0 log:
amd@HOST:~$ sudo xl usb-list vm1
Devid =C2=A0Type =C2=A0 =C2=A0 = =C2=A0 =C2=A0 BE =C2=A0state usb-ver ports
0 =C2=A0 =C2=A0 =C2=A0devicem= odel =C2=A00 =C2=A0 0 =C2=A0 =C2=A0 3 =C2=A0 =C2=A0 =C2=A0 15
=C2=A0 Por= t 1: Bus 003 Device 002
=C2=A0 Port 2: Bus 005 Device 002
=C2=A0 Port= 3:
=C2=A0 Port 4:
=C2=A0 Port 5:
=C2=A0 Port 6:
=C2=A0 Port 7:=
=C2=A0 Port 8:
=C2=A0 Port 9:
=C2=A0 Port 10:
=C2=A0 Port 11:<= br>=C2=A0 Port 12:
=C2=A0 Port 13:
=C2=A0 Port 14:
=C2=A0 Port 15:=
HOST:~$

DomU Log:
= amd@VM1:~$ lsusb
Bus 003 Device 003: ID 0781:558c SanDisk Corp. Extreme = Portable SSD
Bus 003 Device 002: ID 0781:5581 SanDisk Corp. Ultra
Bus= 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 002 Devi= ce 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: I= D 0627:0001 Adomax Technology Co., Ltd QEMU USB Tablet
Bus 001 Device 00= 1: ID 1d6b:0001 Linux Foundation 1.1 root hub
amd@VM1:~$
<= br>
amd@VM1:~$ usb-devices

T: =C2=A0Bus=3D01 Lev=3D= 00 Prnt=3D00 Port=3D00 Cnt=3D00 Dev#=3D =C2=A01 Spd=3D12 =C2=A0MxCh=3D 2D: =C2=A0Ver=3D 1.10 Cls=3D09(hub =C2=A0) Sub=3D00 Prot=3D00 MxPS=3D64 #Cf= gs=3D =C2=A01
P: =C2=A0Vendor=3D1d6b ProdID=3D0001 Rev=3D05.18
S: =C2= =A0Manufacturer=3DLinux 5.18.0-4460-amd+ uhci_hcd
S: =C2=A0Product=3DUHC= I Host Controller
S: =C2=A0SerialNumber=3D0000:00:01.2
C: =C2=A0#Ifs= =3D 1 Cfg#=3D 1 Atr=3De0 MxPwr=3D0mA
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D = 1 Cls=3D09(hub =C2=A0) Sub=3D00 Prot=3D00 Driver=3Dhub
E: =C2=A0Ad=3D81(= I) Atr=3D03(Int.) MxPS=3D =C2=A0 2 Ivl=3D255ms

T: =C2=A0Bus=3D01 Lev= =3D01 Prnt=3D01 Port=3D00 Cnt=3D01 Dev#=3D =C2=A02 Spd=3D12 =C2=A0MxCh=3D 0=
D: =C2=A0Ver=3D 2.00 Cls=3D00(>ifc ) Sub=3D00 Prot=3D00 MxPS=3D 8 #C= fgs=3D =C2=A01
P: =C2=A0Vendor=3D0627 ProdID=3D0001 Rev=3D00.00
S: = =C2=A0Manufacturer=3DQEMU
S: =C2=A0Product=3DQEMU USB Tablet
S: =C2= =A0SerialNumber=3D42
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3Da0 MxPwr=3D100mA=
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 1 Cls=3D03(HID =C2=A0) Sub=3D00 Prot= =3D00 Driver=3Dusbhid
E: =C2=A0Ad=3D81(I) Atr=3D03(Int.) MxPS=3D =C2=A0 = 8 Ivl=3D10ms

T: =C2=A0Bus=3D02 Lev=3D00 Prnt=3D00 Port=3D00 Cnt=3D00= Dev#=3D =C2=A01 Spd=3D480 MxCh=3D15
D: =C2=A0Ver=3D 2.00 Cls=3D09(hub = =C2=A0) Sub=3D00 Prot=3D01 MxPS=3D64 #Cfgs=3D =C2=A01
P: =C2=A0Vendor=3D= 1d6b ProdID=3D0002 Rev=3D05.18
S: =C2=A0Manufacturer=3DLinux 5.18.0-4460= -amd+ xhci-hcd
S: =C2=A0Product=3DxHCI Host Controller
S: =C2=A0Seria= lNumber=3D0000:00:04.0
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3De0 MxPwr=3D0mA=
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 1 Cls=3D09(hub =C2=A0) Sub=3D00 Prot= =3D00 Driver=3Dhub
E: =C2=A0Ad=3D81(I) Atr=3D03(Int.) MxPS=3D =C2=A0 4 I= vl=3D256ms

T: =C2=A0Bus=3D03 Lev=3D00 Prnt=3D00 Port=3D00 Cnt=3D00 D= ev#=3D =C2=A01 Spd=3D5000 MxCh=3D15
D: =C2=A0Ver=3D 3.00 Cls=3D09(hub = =C2=A0) Sub=3D00 Prot=3D03 MxPS=3D 9 #Cfgs=3D =C2=A01
P: =C2=A0Vendor=3D= 1d6b ProdID=3D0003 Rev=3D05.18
S: =C2=A0Manufacturer=3DLinux 5.18.0-4460= -amd+ xhci-hcd
S: =C2=A0Product=3DxHCI Host Controller
S: =C2=A0Seria= lNumber=3D0000:00:04.0
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3De0 MxPwr=3D0mA=
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 1 Cls=3D09(hub =C2=A0) Sub=3D00 Prot= =3D00 Driver=3Dhub
E: =C2=A0Ad=3D81(I) Atr=3D03(Int.) MxPS=3D =C2=A0 4 I= vl=3D256ms

T: =C2=A0Bus=3D03 Lev=3D01 Prnt=3D01 Port=3D00 Cnt=3D01 D= ev#=3D =C2=A02 Spd=3D5000 MxCh=3D 0
D: =C2=A0Ver=3D 3.20 Cls=3D00(>if= c ) Sub=3D00 Prot=3D00 MxPS=3D 9 #Cfgs=3D =C2=A01
P: =C2=A0Vendor=3D0781= ProdID=3D5581 Rev=3D01.00
S: =C2=A0Manufacturer=3D USB
S: =C2=A0P= roduct=3D SanDisk 3.2Gen1
S: =C2=A0SerialNumber=3D040143504c9a3bd459= 6082500826a11868845df4396ebc5cb2e33dd3071e3fd5505f000000000000000000003ca6a= 60b000d7c18815581071b2a7c33
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3D80 MxPwr= =3D896mA
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 2 Cls=3D08(stor.) Sub=3D06 P= rot=3D50 Driver=3Dusb-storage
E: =C2=A0Ad=3D02(O) Atr=3D02(Bulk) MxPS=3D= 1024 Ivl=3D0ms
E: =C2=A0Ad=3D81(I) Atr=3D02(Bulk) MxPS=3D1024 Ivl=3D0ms<= br>amd@VM1:~$

amd@VM1:~$ sudo dmesg = <for 250GB USB-C SSD>

[ =C2=A0247.071742] usb 3-2: new Sup= erSpeed USB device number 3 using xhci_hcd
[ =C2=A0247.097304] usb 3-2: = New USB device found, idVendor=3D0781, idProduct=3D558c, bcdDevice=3D10.12<= br>[ =C2=A0247.097314] usb 3-2: New USB device strings: Mfr=3D2, Product=3D= 3, SerialNumber=3D1
[ =C2=A0247.097318] usb 3-2: Product: Extreme SSD[ =C2=A0247.097321] usb 3-2: Manufacturer: SanDisk
[ =C2=A0247.097323] = usb 3-2: SerialNumber: 31393430475A343030363932
[ =C2=A0247.101909] usb = 3-2: USB controller 0000:00:04.0 does not support streams, which are requir= ed by the UAS driver.
[ =C2=A0247.101915] usb 3-2: Please try an other U= SB controller if you wish to use UAS.
[ =C2=A0247.101918] usb-storage 3-= 2:1.0: USB Mass Storage device detected
[ =C2=A0247.102710] scsi host3: = usb-storage 3-2:1.0
[ =C2=A0269.131522] usb 3-2: reset SuperSpeed USB de= vice number 3 using xhci_hcd

DomU dmesg log= while adding USB controller and USB 32GB disk

[ =C2=A0 94.494852] pci 0000:00:04.0: [1033:0194] type 00 class 0x0= c0330
[ =C2=A0 94.496278] pci 0000:00:04.0: reg 0x10: [mem 0x00000000-0x= 00003fff 64bit]
[ =C2=A0 94.502161] pci 0000:00:04.0: BAR 0: assigned [m= em 0xf1800000-0xf1803fff 64bit]
[ =C2=A0 94.502981] pci 0000:00:04.0: en= abling device (0000 -> 0002)
[ =C2=A0 94.504005] xen: --> pirq=3D2= 4 -> irq=3D32 (gsi=3D32)
[ =C2=A0 94.514634] xhci_hcd 0000:00:04.0: x= HCI Host Controller
[ =C2=A0 94.514650] xhci_hcd 0000:00:04.0: new USB b= us registered, assigned bus number 2
[ =C2=A0 94.517840] xhci_hcd 0000:0= 0:04.0: hcc params 0x00080001 hci version 0x100 quirks 0x0000000000000014[ =C2=A0 94.523559] usb usb2: New USB device found, idVendor=3D1d6b, idPr= oduct=3D0002, bcdDevice=3D 5.18
[ =C2=A0 94.523571] usb usb2: New USB de= vice strings: Mfr=3D3, Product=3D2, SerialNumber=3D1
[ =C2=A0 94.523575]= usb usb2: Product: xHCI Host Controller
[ =C2=A0 94.523579] usb usb2: M= anufacturer: Linux 5.18.0-4460-amd+ xhci-hcd
[ =C2=A0 94.523581] usb usb= 2: SerialNumber: 0000:00:04.0
[ =C2=A0 94.523974] hub 2-0:1.0: USB hub f= ound
[ =C2=A0 94.524850] hub 2-0:1.0: 15 ports detected
[ =C2=A0 94.5= 29968] xhci_hcd 0000:00:04.0: xHCI Host Controller
[ =C2=A0 94.529981] x= hci_hcd 0000:00:04.0: new USB bus registered, assigned bus number 3
[ = =C2=A0 94.529988] xhci_hcd 0000:00:04.0: Host supports USB 3.0 SuperSpeed[ =C2=A0 94.530354] usb usb3: We don't know the algorithms for LPM fo= r this host, disabling LPM.
[ =C2=A0 94.530400] usb usb3: New USB device= found, idVendor=3D1d6b, idProduct=3D0003, bcdDevice=3D 5.18
[ =C2=A0 94= .530404] usb usb3: New USB device strings: Mfr=3D3, Product=3D2, SerialNumb= er=3D1
[ =C2=A0 94.530407] usb usb3: Product: xHCI Host Controller
[ = =C2=A0 94.530410] usb usb3: Manufacturer: Linux 5.18.0-4460-amd+ xhci-hcd[ =C2=A0 94.530412] usb usb3: SerialNumber: 0000:00:04.0
[ =C2=A0 94.5= 30653] hub 3-0:1.0: USB hub found
[ =C2=A0 94.531482] hub 3-0:1.0: 15 po= rts detected
[ =C2=A0157.522609] usb 3-1: new SuperSpeed USB device numb= er 2 using xhci_hcd
[ =C2=A0157.548225] usb 3-1: New USB device found, i= dVendor=3D0781, idProduct=3D5581, bcdDevice=3D 1.00
[ =C2=A0157.548236] = usb 3-1: New USB device strings: Mfr=3D1, Product=3D2, SerialNumber=3D3
= [ =C2=A0157.548239] usb 3-1: Product: =C2=A0SanDisk 3.2Gen1
[ =C2=A0157.= 548242] usb 3-1: Manufacturer: =C2=A0USB
[ =C2=A0157.548244] usb 3-1: Se= rialNumber: 040143504c9a3bd4596082500826a11868845df4396ebc5cb2e33dd3071e3fd= 5505f000000000000000000003ca6a60b000d7c18815581071b2a7c33
[ =C2=A0157.57= 1419] usb-storage 3-1:1.0: USB Mass Storage device detected
[ =C2=A0157.= 571981] scsi host2: usb-storage 3-1:1.0
[ =C2=A0157.572125] usbcore: reg= istered new interface driver usb-storage
[ =C2=A0157.577381] usbcore: re= gistered new interface driver uas
[ =C2=A0158.581138] scsi 2:0:0:0: Dire= ct-Access =C2=A0 =C2=A0 =C2=A0USB =C2=A0 =C2=A0 =C2=A0SanDisk 3.2Gen1 1.00 = PQ: 0 ANSI: 6
[ =C2=A0158.581550] sd 2:0:0:0: Attached scsi generic sg0 = type 0
[ =C2=A0158.584622] sd 2:0:0:0: [sda] 60088320 512-byte logical b= locks: (30.8 GB/28.7 GiB)
[ =C2=A0158.590171] sd 2:0:0:0: [sda] Write Pr= otect is off
[ =C2=A0158.590181] sd 2:0:0:0: [sda] Mode Sense: 43 00 00 = 00
[ =C2=A0158.593387] sd 2:0:0:0: [sda] Write cache: disabled, read cac= he: enabled, doesn't support DPO or FUA
[ =C2=A0158.614589] =C2=A0sd= a: sda1
[ =C2=A0158.627564] sd 2:0:0:0: [sda] Attached SCSI removable di= sk


On Tue, Aug 30, 2022 at 11:12 AM A Sudheer <<= a href=3D"mailto:asr7247@gmail.com" target=3D"_blank">asr7247@gmail.com= > wrote:
Hi All

On XEN-4.16 with Ubuntu 22.04 Dom0 and HVM-DomU,= I tried to do a USB mass storage device passthrough to DomU.
I followed= the PVUSB method mentioned in https://wiki.xenproject.org/wiki/Xen= _USB_Passthrough.

I am able to do passthrough for USB 2.0 and 3.= x version 32/64 GB mass storage devices to DomU.=C2=A0
Passthrough faile= d for "SanDisk 250GB SSD USB-C, USB 3.1" with below error. Able t= o access the SSD in Dom0.
Can someone help with what could be missing h= ere.

Commands=C2=A0used:
host$ sudo xl usbctrl-attach v= m1 version=3D3 ports=3D6
host$ sudo xl usbdev-attach vm1 hostb= us=3D3 hostaddr=3D2

<= /span>
Error Log in Do= mU
VM1:~$ sudo dmesg
[ =C2=A0152.841566] usb= 2-1: new SuperSpeed USB device number 2 using xhci_hcd
[ =C2=A0152.8671= 64] usb 2-1: New USB device found, idVendor=3D0781, idProduct=3D558c, bcdDe= vice=3D10.12
[ =C2=A0152.867173] usb 2-1: New USB device strings: Mfr=3D= 2, Product=3D3, SerialNumber=3D1
[ =C2=A0152.867177] usb 2-1: Product: E= xtreme SSD
[ =C2=A0152.867179] usb 2-1: Manufacturer: SanDisk
[ =C2= =A0152.867182] usb 2-1: SerialNumber: 31393430475A343030363932
[ =C2=A01= 52.899103] usb 2-1: USB controller 0000:00:04.0 does not support streams= , which are required by the UAS driver.
[ =C2=A0152.899110] usb 2-1:= Please try an other USB controller if you wish to use UAS.
[ =C2=A0152.= 899113] usb-storage 2-1:1.0: USB Mass Storage device detected
[ =C2=A015= 2.902033] scsi host2: usb-storage 2-1:1.0
[ =C2=A0152.902174] usbcore: r= egistered new interface driver usb-storage
[ =C2=A0152.908928] usbcore:= registered new interface driver uas
[ =C2=A0174.933399] usb = 2-1: reset SuperSpeed USB device number 2 using xhci_hcd

=
Thanks
Sudheer
--0000000000005eca1205e8143e89-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:05:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:05:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401259.643068 (Exim 4.92) (envelope-from ) id 1oVsrY-0006FA-9D; Wed, 07 Sep 2022 11:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401259.643068; Wed, 07 Sep 2022 11:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsrY-0006F3-4p; Wed, 07 Sep 2022 11:04:56 +0000 Received: by outflank-mailman (input) for mailman id 401259; Wed, 07 Sep 2022 11:04:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsrW-0006Et-Fx for xen-devel@lists.xen.org; Wed, 07 Sep 2022 11:04:54 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50048.outbound.protection.outlook.com [40.107.5.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e5d6a807-2e9c-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:04:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3255.eurprd04.prod.outlook.com (2603:10a6:6:c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 11:04:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 11:04:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5d6a807-2e9c-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0fKlS5aWt4lyEJpOnccUkFWUkPv3NtFZgBZS9xX3OXzLE8jiCUJS0U4h699DdqcGC6Z6gmgS8paHUOc+SyLHi+UspKCE3+aImSsBEzah+qc6u154X/vhTTCciqQJGUn6U/P8ShbJeY/InoI9wHn8Gk9nvoM8Xs7sqhz8eT9g4cCv7EaD7rVX3+5Hw1efCdJ1tKDWHlx7EppCpDiz8jUnHiIYUd/d0P5RJCECawokTY8hvnfWGFb+5687MBNWccaRAgadKijT941ZM52YZkK4SXP1QuE2pojFvdy9z3GVyT+GmZL3Sy4PPFSSjHBFZ8+aza3LOoAIVxyhN031AW3mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ik6WWPDhMgvJz79Hw2IXhhmGGpxzvPg3ymGHoWY6YeI=; b=HHrm9Wlqqpik94DoMEeIyhLeMVqHczR2cu/RYz/KzcP/SPOuwK1BKl3h7WguWSU4FWb27VpK0gD8s8MM7NOCsZgrPmtLL8Ucwvz+Ph61bzdQy6hRvs0xmWtr66xwqCFNW93CS6H91dqBnK3lTg4gBXMS9+aHFPH9KcxFak34i0MurH0HGGKepPjZb0x5r0/a4zirV3TrZPv1xtcf9HJMqTcenF3c8uRQuHUmf7SIY3zkFK7drWBcdzVVtBeX4J2mK55DtYkzMBhlkB5bTLS9rKzy02JyfTWXDJ6r5tfnbn9D63JvR4ZY9Tf460/wF54I3Tv3MryoytdY4q2+3gHV9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ik6WWPDhMgvJz79Hw2IXhhmGGpxzvPg3ymGHoWY6YeI=; b=MXlNZoXxE0zQyrir5M1FxJ5gkx3Ts+BTa8cbph68nPoTM3b74yuxHomeX/yDeKtmnm3Cgz5Lr5uzvb6KMdRjRu23E6fscZMGSGF9SGNgsPOpFes7sI0AmdtdtVvqlH1DpfLNcVbSpfvICHkmVot/FEbV1xxqOpBy+C6UYOvh/kAJHg+KlDjhewpsxhm2/u8MEVwIYa9S6k88cyYXErD/WUbioBbljkThXWaaBDx/k8/PnPLdYXfu3+xdDloQjjA6RIOof6QmEaP0DyToVfdSlHqCjkjlvsajBlufhaWaWN7/dMV1HaC1jnQs/aHPLS6VfpSU+ju3UNOeXrIPzzOaHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <568b5180-3ebe-106b-0cae-7089ee4c77ac@suse.com> Date: Wed, 7 Sep 2022 13:04:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] .gitignore: Add init-dom0less Content-Language: en-US To: Viresh Kumar References: Cc: xen-devel@lists.xen.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB6PR04MB3255:EE_ X-MS-Office365-Filtering-Correlation-Id: a6e9e047-67a5-4d83-b2e9-08da90c0c67c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Am9I1u1Yv2k/KOId+eyKY+JHMMH1996auwzF/KkXJvdU6i3qEVF+ZP/nisfLdSPCusTf6SNCXkwpnScrq73HU7xptYGe4lON4SKGvvX+zGPt6/8niqvPtqEKAPr2GUEeeJrDPqnRpyp1qWVCL+QDUiNkn9W8ap6FSN6WR7mV31Giffu8DFnz6q/gXzZ+5Zl5QqaqPmBMghjAWkqTcHfuB1ZUaLOmQ7tDRAEqLWnpVNql0tVr5rg+if2K72YTZP+xD4QOLomWUXvWKjvp6XeiD1NvaNZ3BVdZedOpc/NkYPsOq7jfkTA3jnDq3aN9ja5jojdLU2E0SxQSRoqNrTFJxcQkHK2xISSHXbN9qtW6aLJ3PmlmVtcZXCMzSJoiEvmdtglbcLdvmSPj2br34YfCLnV2G94UNKDEpeRICiTxwziR/Slywiupi8vgXsbWJmJJfB4d3z20f5d5NcA+/YuE5VYHJAIYa1SX6yPHp8ZEVJZLQB4WKyRjDyKAZ57sQzItjvbq9CEj4FOMCgpjS1IJSv4aVPoB5ZP3VRvAzhnK2obRDbLcUKkEc3kuDVsXlfJP8xehugIJqW9yKaFTOLxC6AEHPVcWKpUp9UzKMBcR6geoXtBtVStv4QjVjD8DVyljzVzGhmpLNf6VIDvr7i5KvmMk2K9hZ6aMuScjDKdq3AWY91mXq0O9kHmtjdiqKmzN9IDy5nHC4WIeIEcJE36cHPhTcooL9Ca0W2neFXfCJf+DKoUbbCe16MzPBC/UqfiGuEewsHImFamgk9d0B7SjMn4oFpOpfVieIAZ9jSRkXDs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(366004)(136003)(39860400002)(6486002)(26005)(36756003)(2616005)(31686004)(66476007)(66946007)(8676002)(66556008)(4326008)(2906002)(186003)(6512007)(478600001)(86362001)(6916009)(4744005)(41300700001)(31696002)(8936002)(53546011)(5660300002)(6506007)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enB3ekRwNmtzWFV0cDk4dHJPYmlicXNWS2EwdzV3TzQvZFRKRldCeC9oVzZ0?= =?utf-8?B?UUdoOFNrK2tjbU9UaHRoNHY5cHZTTHpaTjcya2xjRENNRGU0ZjZub1VRRVQ3?= =?utf-8?B?ZDJFN09kU1plMzk4ZnVKYVE4YVJYQXo2SWNqd3J6bHozRkRNT2cxWGhlNFhN?= =?utf-8?B?RWNBL01tSmt4Tzg5MnJhV1RUR1JZQU1ZaDFzUGVXWHN6V3VJd2V1cXlHQTVo?= =?utf-8?B?b29PWi9vQjJsNzlBRHRDNFNKN1NlUG1lQzVSOGhqWUNiSHV3dXI3NXNRdWZv?= =?utf-8?B?bkFDZ1E1QXBhaEN4alg0KzROV1I5M3Nyc01iZVZ2ZGlrVDhWUllkQlZZMGpD?= =?utf-8?B?Y1grQkdEcGptNHYxcWEzd2NFSG1NSEVSZ1oydGNZTnlJTHRLRFFpSlpKQlZh?= =?utf-8?B?b0VNV0ViQWJHVnVFWTlWTXFhMFRFTTgzRVppdUNFR24vOEhaampWL0tOTFRm?= =?utf-8?B?YmlINnljRmFOeDFmb3pOeUNZZ3JrTUF0TWcxeHFmQVpvU0Z3NEw2enR6MDRn?= =?utf-8?B?R1plREpzNGRQTFRweTV3OUZDWi9GQ1QyRUhvTzBQQStna25LYlY0VmhIcDZL?= =?utf-8?B?VTFtOXNDR25RbnN3Z2ZBK2NoeUxBWGdYZTJTeHZDWUZxak02VWJNU1FGMEF2?= =?utf-8?B?YTNTYVIvZ254NkZKMVJvQm1kZlV2aFpiNEVnMXRwdTNhU1BOdHpzTHlYZE9D?= =?utf-8?B?V0YwY3ZrL3AxUkczZ01HUVhMc2VyUTFBd1V6SFpiTGZ4RzFseDdxQitxMldU?= =?utf-8?B?ZUZLQ2ZEMjlJbWJnaERqbnRMeDNHd2NsWlFEOVFiMng1bDZzY0lJZERObGIx?= =?utf-8?B?VHQzWFU0dmFCeTZrbnJQdGpaeFBEamlHMjFXUFlsb1ZuOUdxVFVCc2xpOXlJ?= =?utf-8?B?dlp2eFpPcGlaN1Z0a0kwMTF5VEFtQWkyR0JEelZ5RFRZcnliOEpFZUV3WmI3?= =?utf-8?B?aDhwVDlEeU1jeUhBSS9NSWFsOHdmUDY3aTBXeEczYUk5elExZ3Jxbkk0em1t?= =?utf-8?B?S1dxYzJoMWNZUEZWUkpEVGJoWEczU0M3L0VxTm5IVWFuNWpBS2ZRUmtoMUcz?= =?utf-8?B?WmRPcFE4QXp1RThOU3o0SU01YlpuUDJCQWtERzk1ajBxS2VQZkVVejlta3dr?= =?utf-8?B?b0d0blBJNjdCc2pXUjRITUhpVUJId2c5NGUwMGdzeTVHSnhEd0NiSEx4b0dF?= =?utf-8?B?MVZxUCtyaFNqam1KSktjMGdRVnJwc0s3SG4ybldmczFqK0hWRGYrcHVRZEFJ?= =?utf-8?B?RGdGVVNoYVVzRDl0WjA0ajZ1ZkZLQTdqNEpCNXRsRzMybUp2Q0hJVFQ0bFFt?= =?utf-8?B?NVhsTzV2RmRUOGpKdTQ4aVVvc3YwMm94ZWxLUXlNaUp1ODRkT3RVVVJHS3lB?= =?utf-8?B?WGtwYkl1aFJWQ0ppS2E3bEpESVRObU94MGt4R2hQSkVVT1RUSDdkc3RnaGg4?= =?utf-8?B?UFlJVitxWThsWDgzd1RjTkNCRkNOWllFSm00UjlrSFJOSEpSSXcxV0NZT1Fl?= =?utf-8?B?Q21KSVFOMUhITjBHSmlScExlRkd2OVFjVVZGaUhGeEx6aUxEUHhsZzR4eHZi?= =?utf-8?B?YnZHYzBVRmJqRnh5SWphbUl0M2hkTlpqTG8vMEtkMGZBbWp2cW9iQWpOMmhr?= =?utf-8?B?Sm5pQVdTYmRmZitvYmNGUmV0bEZsYTMwY29JWFpQL25QWU5HRm9LUlJwakVO?= =?utf-8?B?VzRiYVMwNmd3anRRcGZUUmRXR1lVSE5uL0htNC9JTnFxbFpWaWJRcXRqUmRG?= =?utf-8?B?bHhNYTdXWlNCMWZzMUNmZCtlQkt2TG9PeGZNc213RVpJUkdhR3dJWGR5bHhE?= =?utf-8?B?bXk3b3hJRWowM0ZNa3B0QWJoTTcrbkQ5UVQzK1N6dm9PelR1ZEN5OGRuWCt3?= =?utf-8?B?QnFEbGFNRnVUV0x1ZmQrTmVEcUxPU2RVL0ZIUGpRSmM1dkcyVmg1MUk3SlpS?= =?utf-8?B?RFJXVTgyOWZtbWg4TDNWQWM2VFlYNjNSQ0F2Y1E3T0dHdGE1Ui9XWFkrZTlo?= =?utf-8?B?ZUlqb2EwOVJiMU9JRVhiS3FNeUZhMU9YemVYRGNLa2ZrRVNnOEVwTk1nK0ZZ?= =?utf-8?B?Ym9SVHNlNHFIZjhyUGt0aWFBVElWekQzQ1hpK3l6R0ZtdzdQUjM4WndXTEtk?= =?utf-8?Q?EW2N4PGWbGYKoxgFuyfDBZLI5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6e9e047-67a5-4d83-b2e9-08da90c0c67c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:04:46.6090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: czbkwD5LyYz0Q8A8zlGU2whZHqQh1Ottd0s02K2u7yzBzDE2I9t9KQd4FjHrT3NrQRnQv21sexEcGVdlwFcsaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3255 On 07.09.2022 12:03, Viresh Kumar wrote: > Add tools/helpers/init-dom0less to gitignore. > > Signed-off-by: Viresh Kumar > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 27881c976432..9f9f18c97d5f 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -170,6 +170,7 @@ tools/flask/utils/flask-setenforce > tools/flask/utils/flask-set-bool > tools/flask/utils/flask-label-pci > tools/helpers/init-xenstore-domain > +tools/helpers/init-dom0less > tools/helpers/xen-init-dom0 > tools/hotplug/common/hotplugpath.sh > tools/hotplug/FreeBSD/rc.d/xencommons While easily doable when committing, in the future can you please pay attention to pre-existing sorting? With the insertion moved up a line Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:08:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401265.643079 (Exim 4.92) (envelope-from ) id 1oVsvP-0006sf-PL; Wed, 07 Sep 2022 11:08:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401265.643079; Wed, 07 Sep 2022 11:08:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsvP-0006sY-MZ; Wed, 07 Sep 2022 11:08:55 +0000 Received: by outflank-mailman (input) for mailman id 401265; Wed, 07 Sep 2022 11:08:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsvO-0006sS-3x for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:08:54 +0000 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [2607:f8b0:4864:20::1031]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7459ede2-2e9d-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:08:52 +0200 (CEST) Received: by mail-pj1-x1031.google.com with SMTP id fv3so8071209pjb.0 for ; Wed, 07 Sep 2022 04:08:52 -0700 (PDT) Received: from leoy-huanghe.lan (45.78.11.189.16clouds.com. [45.78.11.189]) by smtp.gmail.com with ESMTPSA id w187-20020a627bc4000000b0053e5daf1a25sm2086687pfc.45.2022.09.07.04.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 04:08:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7459ede2-2e9d-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=dMoKtINDOiHP2DbhPagk9i3FrvJ35u3SVzn9sB/eiOI=; b=F6kk3IfPjwNcftonfibLkfK3RpKjkoSB+GETUAAGwDVLHvXzR3SpgGsDljqw3+jI9G YMAhgB5Pbov9Mw9Al0ZdrIBr7HO4NLVeWPW7jgN9+iJb7Z+7OMsg//haQQB40jIppgKH OipbwKADd6swfiAgqYN29uLHLowUCxxqKDB39616JY8js/DXp7iEvOxrOewLpXuSxJll sNto+jyyjnjIJFpqoIcWN28ovQSTzqY/hqvGzGF0neZ0epG9lDNfTLU5PX8MrrCPktyf zoCFiq+MIyNbB5MLvkRtiCJogm4WU5Ps3ZYOhwC0IyGgFN2CQtQVpNHRn+KutY1B5+WG EHvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=dMoKtINDOiHP2DbhPagk9i3FrvJ35u3SVzn9sB/eiOI=; b=Pn01bVX3blR3GhD4ryumGSg9ebfQAoNxqPd7flVzC0uveTd7MSfEikRLfbm5H8gcsI w+wXn7vH/5ratZtb/LwYvx+uy6r/x6u+Hdh3jUnRZNuM2vul8bHfMP4tGqC0mbi+7Rh2 QBdM2VAMPaNdPG5SSSiEc6VUmO5jueW4yJIUo90B+ldoAJhhFiY0VWEJVcbFOTL+WfPJ O/wMjKug2ixGRwxvUSon+glMYxHcg48bY5pxWeyLgGuYLmcNoj/yM7YYTYj0LF7TVuGK vp4fkGRsa6olcszKxvbxBTm91C5r/NXQWB6xuZtUKMXc43E/SrS/MaXxNW7Wgl+gvtey cgVQ== X-Gm-Message-State: ACgBeo1tIQbfrKTeLF5RMip8V5/qQsE0LD1CHhtxcXdGJvoPP7ZaAWSJ d2AgeL72ueEJwxNghpNqVX7gRecGSvmlE70ZKrU= X-Google-Smtp-Source: AA6agR60FyeN72Xi7gx+NWvk9SS2CLeeCzr1AVVjeUoagMqm1MV3wkApTe5ErtrPf5zPMAn8kEgMCQ== X-Received: by 2002:a17:903:1c1:b0:175:4cf0:31e4 with SMTP id e1-20020a17090301c100b001754cf031e4mr3390600plh.95.1662548930501; Wed, 07 Sep 2022 04:08:50 -0700 (PDT) Date: Wed, 7 Sep 2022 19:08:39 +0800 From: Leo Yan To: Bertrand Marquis Cc: Jan Beulich , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Message-ID: References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> <5ce7f63c-5ba5-f2cb-8e3e-f6dd2d9d76f7@suse.com> <524F3B92-5298-4BE3-864D-A076A8873800@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <524F3B92-5298-4BE3-864D-A076A8873800@arm.com> On Wed, Sep 07, 2022 at 10:05:54AM +0000, Bertrand Marquis wrote: [...] > >>>> I think a define in compile.h using stringify is the easiest solution: > >>> > >>> Ah! I thought you were suggesting to tweak __stringify. This is ... > >> > >> Also possible but a bit more tricky > >> > >>>> #define XEN_STR_VERSION "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)” Just remind, We need to define XEN_VERSION_STRING in compile.h.in rather than in compile.h, something like: #define XEN_VERSION_STRING @@version@@.@@subversion@@ > >> Quotes at beginning and end should not be there. > > > > I have to admit that I dislike the STR infix. I'd prefer a suffixed variant > > (e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g. > > XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here, > > since one might expect that to include XEN_EXTRAVERSION as well then). > > > Version is a value so here I though it made sense to distinguish that one as it is a string representation of it. > > XEN_VERSION_STRING is ok I think. > > I generally dislike anything named FULL, EXTRA, BASE or other which are just unclear. XEN_VERSION_STRING is good for me. Hi Bertrand, just let me know if you prefer to cook your own patch for this (essentially this idea is coming from you) or you want me to follow up for a new patch? Either way is fine for me. Thanks, Leo From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:09:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401272.643089 (Exim 4.92) (envelope-from ) id 1oVsw7-0007RT-1l; Wed, 07 Sep 2022 11:09:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401272.643089; Wed, 07 Sep 2022 11:09:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsw6-0007RM-VI; Wed, 07 Sep 2022 11:09:38 +0000 Received: by outflank-mailman (input) for mailman id 401272; Wed, 07 Sep 2022 11:09:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsw5-0007R7-Iy for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:09:37 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e045844-2e9d-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 13:09:36 +0200 (CEST) Received: from BN9PR03CA0719.namprd03.prod.outlook.com (2603:10b6:408:ef::34) by PH7PR12MB6860.namprd12.prod.outlook.com (2603:10b6:510:1b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 11:09:32 +0000 Received: from BN8NAM11FT081.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ef:cafe::b2) by BN9PR03CA0719.outlook.office365.com (2603:10b6:408:ef::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Wed, 7 Sep 2022 11:09:32 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT081.mail.protection.outlook.com (10.13.177.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 11:09:32 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 06:09:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 04:09:08 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 06:09:07 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e045844-2e9d-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIfasoA4HVCg6AlIBfmEbPry2okihsU3V8D7REGDUy6EUKZJDIIEX2m+ba7wtjlOGry6cX+BG1rCnupGSxMKhwDAz8ddNpNP/9Q3Z+b9nOp09O+GC19TlTTvcuCvMh9g0tErGxBginR/KKSyH/iZeXW10rStjTUVZgQ7En2SOOqRPcnwcOGPUhgfi08SakpaBEb8WMvtdM2+eMEymtKDAEhVhbmuFAeLBNO2b3V6yfxgkSlj19Z925y+BvaLANdEWByUmmXW53OBBN/szq1dcD5YHOXaHpzdkQQWWpEz2evXOKQQXx457GkZ5GwIHJmw5lLNDCyRcrmtAEfDQfGUkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhTkd5miWMsVyal32k/nHZOTb3M3/0B2WCe0WVn4U0U=; b=bLm4H3S+7fC1+ZcIQb7gfdxfJzGbk56Mv4V0uAhosM/TCy1lSi6G2Qnh151ETEGDdRNN+6X/VsM4lkthK7kiX8DmUXTAyVWTonG5x0fwJ+LUWlPBm/643cg34hXi4U4Zx9av2jYbX0E+NsDqhjsH26+eMmxbtib0VuhccQBOSfwX6XkAU5vXJPxsWG8SWakl81cDmRCJosVJbTC+2LaLz4eCkdjjvLJhpLqO8jll8riP6mhZO2SVTpYO9gn/vs3Y9iK/F2QFp+W7Hvnmhw9nZfJNRM/AnnhsBoztmAOZg3kASECCDE7BjUyZmdvGscryh1ySDjt3Rbx5SNVS2p/GoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhTkd5miWMsVyal32k/nHZOTb3M3/0B2WCe0WVn4U0U=; b=Vn035xWxAfy1EdIZMf92568mJk2Jcg+HkUta6ajSeB1Mduyc1ou+xHxCS5XvoRP7EsPrDus7brY5yq/abFxGpol2DdDTeLzbfywbJVgW8wGvP0KrL9t4YzBT2GgDXSUdf5Eidf1xf00nnrKdJEswYQpt2TIn+x5lcjm7IdNsW+s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder v2 1/2] scripts/common: Introduce phandle_next and get_next_phandle() Date: Wed, 7 Sep 2022 13:08:51 +0200 Message-ID: <20220907110852.5673-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT081:EE_|PH7PR12MB6860:EE_ X-MS-Office365-Filtering-Correlation-Id: 1afb0e03-e8ef-4cd4-750e-08da90c170ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MABG/xCTZzcwgQWF2hpH8oMfplqEzpNCCwbP1zcD4LiCKhVSQRcqRELG9Tuoc2TYMBYjWoUS/xbAczS/MweHq1qOTGF2KqU8xySkYquPIK/gy4Y3qIea8NnLvoSnZDKkbeYZ3J8827sQ42g9N0uY3SwnL46RvMkwuEsvmrIBKAftnbouGX9soDAflHx2hpzGmI6anMlUybeC+s3RPJtZD6D+o8SAcjmCwzTgTA30fWmE1oBWp7UDBBiK+W4SPYO96RpczqsrdngrXdlZb8LYKE8ReiKpdEeDCrwUKijMy5x8tm2At3oeepYmbg/wt3mAEg2MApKdR3ZciTJwmpma8eBkqwLysi2iH1Ixh2ozI7zEB3Y3y3zdoJalfq8w4dMm02+Ky0pwzPICqj4Zi9liQWjDMfoMw9cTgjSt12JjpZCA/jdCeDQBK1py6qLEC0ffQwjXjbKUW9p6N3MSnKvVWswBICYqGGSMjf3+9EnuOeBYPstYjzdGNB/qI1x8BAZrfaVNClK+qbmDve/Fs5gkTeOYY1/peetAr2Cg2febsYgSPdAHysbZmjUVyXdY5jlo2+JGB/TUEGCndq0XgRqg3vKF+Ms/LQ0udRbehsFd66ymG8pU21/BqxdOiKIlpD/skV7YQtdaccya30nusNgqwzyO/XhMRBz8erVFj3UFnlhYX4Y/7x8Mb5oBIVCDoErf1z1QlPQ0oFwJyzAV+KtCsbd/2evaZpGkYPWrUDaWiMTWFGhrrwKPc/2f3B3gsc7rEDrHFBUVnZ8SpiUe1OXAWidEzhfECM4nzKdTT8+Vbn0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(136003)(39860400002)(40470700004)(36840700001)(46966006)(336012)(81166007)(186003)(47076005)(36756003)(426003)(356005)(2616005)(36860700001)(1076003)(86362001)(83380400001)(2906002)(54906003)(478600001)(26005)(316002)(6666004)(41300700001)(8676002)(40460700003)(82740400003)(5660300002)(40480700001)(44832011)(8936002)(82310400005)(6916009)(70586007)(70206006)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:09:32.1231 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1afb0e03-e8ef-4cd4-750e-08da90c170ce X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT081.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6860 When dealing with device trees, we need to have a solution to add custom phandles to the nodes we create/modify. Add a global variable phandle_next to act as a countdown counter starting with the highest valid phandle value 0xfffffffe. Add a new function get_next_phandle to get a value of the next available phandle and set it to a variable whose name is passed as a first argument. The global counter will be decremented with each call to this function. Signed-off-by: Michal Orzel --- To make the interface to phandle_next as simple as possible, we just need a single function that will get us the next phandle and update the global counter. That is why we cannot use the following: - "phandle=$(get_next_phandle)" as a subshell cannot modify the environment of its parent shell, - making use of return statement as it only works with values up to 255 The current solution with passing a variable name to a function that will modify its value using eval is the simplest one and serves our purpose. Changes in v2: - new patch --- scripts/common | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/scripts/common b/scripts/common index 68938beb8557..25c041270c29 100644 --- a/scripts/common +++ b/scripts/common @@ -13,6 +13,9 @@ tmp_files=() tmp_dirs=() +# Highest valid phandle. Will be decremented with each call to get_next_phandle +phandle_next="0xfffffffe" + function remove_tmp_files() { for i in "${tmp_files[@]}" @@ -26,6 +29,14 @@ function remove_tmp_files() done } +# Get next phandle and set it as a value (in hex) of a variable whose name is +# passed as a first argument. Decrement global counter phandle_next. +function get_next_phandle() +{ + eval "$1=$(printf "0x%x" $phandle_next)" + phandle_next=$(( $phandle_next - 1 )) +} + function sanity_check_partial_dts() { local domU_passthrough_path="$1" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:09:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401273.643101 (Exim 4.92) (envelope-from ) id 1oVsw8-0007hN-8v; Wed, 07 Sep 2022 11:09:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401273.643101; Wed, 07 Sep 2022 11:09:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsw8-0007hG-6C; Wed, 07 Sep 2022 11:09:40 +0000 Received: by outflank-mailman (input) for mailman id 401273; Wed, 07 Sep 2022 11:09:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsw6-0006sS-9A for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:09:38 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2064.outbound.protection.outlook.com [40.107.237.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ebea0e9-2e9d-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:09:36 +0200 (CEST) Received: from BN9PR03CA0696.namprd03.prod.outlook.com (2603:10b6:408:ef::11) by SA1PR12MB7040.namprd12.prod.outlook.com (2603:10b6:806:24f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Wed, 7 Sep 2022 11:09:33 +0000 Received: from BN8NAM11FT081.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ef:cafe::9b) by BN9PR03CA0696.outlook.office365.com (2603:10b6:408:ef::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 11:09:32 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT081.mail.protection.outlook.com (10.13.177.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 11:09:32 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 06:09:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 04:09:10 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 06:09:09 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ebea0e9-2e9d-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dyizDEj4QX0RgRefJMzJqbSM3X0sbqKCSEsHy/VXq6L95MpnAdRog/Nn4bXx+wJMa14GbZf9+m6EmdxgwB6Zd0Eo8Os63XWTngBNvlhfsrnrnXVc0pKnox3YxG7e3fqZM4u0AunbHvcJf6JeOdgFc+ULZL8EKnazJTYyp/zR3DcfYIbzd1+RFE/N0o4BUTrriGyftCR//UmerfL9MhpDRvg/WmzWBc2CK9RDdutcdpqd7EiQ/u3KHP/wrhUIjBZB/Eo7KBeD+vTmCYHpEXBHJHNthIXsA8KXrpe0VKXdErOgPwfO7Pwsi4qw5YvgDpSVXMKQ7mJXTDg035nVwMURKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJW3qR7odDPSqUonwDmetw28GI7gbKhgJQOD46P0QTw=; b=GF8gp7EbyYkNOXRe4ZLweSwco53Y0xjOsDBlF0HN6lIb/3EAOQuosArWOoyGSRX1KL+4QKnWhN6vw4DNyOZOEglOs2hj6aydKALon+pATb04gwGrYxg2VuaBP3Pb2lEeTbm23seMRjNfjSMUkIc3Fj3Za12Uc/QIURfTw2pEt8KUC40H59BPcoTIUddq0gOtYPnc3Q9SFzCMIUTw2lLizMPnOSAi0yJHB5gTRMU/OPU/7GvKD8FJYNSBqFIrGQvJyQDJmqAVgYZ9O5ffNu6Rj5ZQK1JYhhFc6YVfmYhG1dLNmUSXMWoicdHRxn7B3Sjr0rNODIUkIuOwCuIyCLxUgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJW3qR7odDPSqUonwDmetw28GI7gbKhgJQOD46P0QTw=; b=mp3Acd6uIUMMvkxnddZwS2ud2Kl1IfiNHLyveIN/T18zQKQXyVmh6YIGr4WLmGIgxR55O1WTitZpOjMYmgovPrRmfbiaIFHn/nA5NINfIN9G3OrZQgNugUT0bpsw/a9Uyl4yXeac2QCbqYoekFF9PoHcxPIRAMH5+klbcnqpkwM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder v2 2/2] Add support for Xen boot-time cpupools Date: Wed, 7 Sep 2022 13:08:52 +0200 Message-ID: <20220907110852.5673-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220907110852.5673-1-michal.orzel@amd.com> References: <20220907110852.5673-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT081:EE_|SA1PR12MB7040:EE_ X-MS-Office365-Filtering-Correlation-Id: 40d8cd43-63b3-426c-bcc5-08da90c17139 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lCcG+R+O36ApvBBnsntxzwPqfzo3YU2fk+w4gwDV948Rd1hU6HPACkvz97fI1hbWJD8Q8TlUJxcGY4KHvNTQpbDh2V+2RE33vqhGttJ/42eI/4TKW0aGMlBmc57hMwOaLXZH9kvPgpzy5ImQAXYb+oBcVbR2thWJ/e4zT3u1qvzuaoYac1i+vG+WbbM41lKntx8qniXYpLt8FX++VGKZrXV8Js4aPEnvuHyGR2hqmJKVn1qaWp0VpQ4Zbc0PqHFSvnRZWs6ZEhW3bNj7IAMKi62Moy7lre1CVMxpkwAcscoJZcRNlX0hDE3hoXdtZl27p8dyR49z8+ci8aUtixwnLmie3WvR0PzbN8Nos4XvgtUJFt1aW0Krnk0q0F3t5rtMMA6W+u+k0l6MWBi2oaUZ05TGZ5S331VqRBUp7mtQu5tSrU8MVnAXseKQcSvek0tF17rtAJa+aKBWishmTxXTC8uZkJujQ4bIK8fzxzmtN1kJtk4wVOPemhcvhTJpxrSXSSgU1lE2rRkXnGpEy1yggtiHvXZPVW1KAR9tNX48rRfV+PhXeSxSGyT2t1V6VoNE6A30T/7woJHRSysJM094l0Mbfek3h23iQwpLep14SbIzGAbLqs0ud7py7a6vOL5uxuPdAn/SIFnVDHaDuLnpb6JF0O9tAtdnS4aQ/r3EQ0bwlUQEZSj8T8xMCb8kMs8/VKCiImFLNs5Q6LlsTlziykZCweaJF0J50GqnHdUA9ovmmS/jtPHohSi9V0MGgaoK2583rpsyKNpNHB0LJFBCC2Cvjr0FkfCEFBl+Q16WZPs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(376002)(46966006)(40470700004)(36840700001)(70586007)(8936002)(316002)(26005)(40480700001)(2906002)(5660300002)(82310400005)(41300700001)(36860700001)(478600001)(40460700003)(54906003)(426003)(4326008)(336012)(44832011)(6916009)(86362001)(82740400003)(2616005)(186003)(70206006)(36756003)(81166007)(356005)(6666004)(83380400001)(1076003)(8676002)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:09:32.8262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40d8cd43-63b3-426c-bcc5-08da90c17139 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT081.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7040 Introduce support for creating boot-time cpupools in the device tree and assigning them to dom0less domUs. Add the following options: - CPUPOOL[number]="cpu@1,...,cpu@N scheduler" to specify the list of cpus' node names and the scheduler to be used to create cpupool - NUM_CPUPOOLS to specify the number of cpupools to create - DOMU_CPUPOOL[number]="" to specify the id of the cpupool to assign to domU Example usage: CPUPOOL[0]="cpu@1,cpu@2 null" DOMU_CPUPOOL[0]=0 NUM_CPUPOOLS=1 The above example will create a boot-time cpupool (id=0) with 2 cpus: cpu@1, cpu@2 and the null scheduler. It will assign the cpupool with id=0 to domU0. Signed-off-by: Michal Orzel --- Changes in v2: - make use of get_next_phandle - pass cpus' node names instead of paths to CPUPOOL - do not pass NUM_CPUPOOLS as an argument to add_device_tree_cpupools --- README.md | 10 +++++ scripts/uboot-script-gen | 79 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+) diff --git a/README.md b/README.md index bd9dac924b44..041818349954 100644 --- a/README.md +++ b/README.md @@ -181,6 +181,9 @@ Where: present. If set to 1, the VM can use PV drivers. Older Linux kernels might break. +- DOMU_CPUPOOL[number] specifies the id of the cpupool (created using + CPUPOOL[number] option, where number == id) that will be assigned to domU. + - LINUX is optional but specifies the Linux kernel for when Xen is NOT used. To enable this set any LINUX\_\* variables and do NOT set the XEN variable. @@ -223,6 +226,13 @@ Where: include the public key in. This can only be used with FIT_ENC_KEY_DIR. See the -u option below for more information. +- CPUPOOL[number]="cpu@1,...,cpu@N scheduler" + specifies the list of cpus' node names (separated by commas) and the scheduler + to be used to create boot-time cpupool. If no scheduler is set, the Xen + default one will be used. + +- NUM_CPUPOOLS specifies the number of boot-time cpupools to create. + Then you can invoke uboot-script-gen as follows: ``` diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 18c0ce10afb4..1f8ab5ffd193 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -176,6 +176,80 @@ function add_device_tree_static_mem() dt_set "$path" "xen,static-mem" "hex" "${cells[*]}" } +function add_device_tree_cpupools() +{ + local cpu + local cpus + local scheduler + local cpu_list + local phandle + local cpu_phandles + local i + local j + + i=0 + while test $i -lt $NUM_CPUPOOLS + do + cpus=$(echo ${CPUPOOL[$i]} | awk '{print $1}') + scheduler=$(echo ${CPUPOOL[$i]} | awk '{print $NF}') + cpu_phandles= + + for cpu in ${cpus//,/ } + do + cpu="/cpus/$cpu" + + # check if cpu exists + if ! fdtget "${DEVICE_TREE}" "$cpu" "reg" &> /dev/null + then + echo "$cpu does not exist" + cleanup_and_return_err + fi + + # check if cpu is already assigned + if [[ "$cpu_list" == *"$cpu"* ]] + then + echo "$cpu already assigned to another cpupool" + cleanup_and_return_err + fi + + # set phandle for a cpu if there is none + if ! phandle=$(fdtget -t x "${DEVICE_TREE}" "$cpu" "phandle" 2> /dev/null) + then + get_next_phandle phandle + fi + + dt_set "$cpu" "phandle" "hex" "$phandle" + cpu_phandles="$cpu_phandles $phandle" + cpu_list="$cpu_list $cpu" + done + + # create cpupool node + get_next_phandle phandle + dt_mknode "/chosen" "cpupool_$i" + dt_set "/chosen/cpupool_$i" "phandle" "hex" "$phandle" + dt_set "/chosen/cpupool_$i" "compatible" "str" "xen,cpupool" + dt_set "/chosen/cpupool_$i" "cpupool-cpus" "hex" "$cpu_phandles" + + if test "$scheduler" != "$cpus" + then + dt_set "/chosen/cpupool_$i" "cpupool-sched" "str" "$scheduler" + fi + + j=0 + while test $j -lt $NUM_DOMUS + do + # assign cpupool to domU + if test "${DOMU_CPUPOOL[$j]}" -eq "$i" + then + dt_set "/chosen/domU$j" "domain-cpupool" "hex" "$phandle" + fi + j=$(( $j + 1 )) + done + + i=$(( $i + 1 )) + done +} + function xen_device_tree_editing() { dt_set "/chosen" "#address-cells" "hex" "0x2" @@ -252,6 +326,11 @@ function xen_device_tree_editing() fi i=$(( $i + 1 )) done + + if test "$NUM_CPUPOOLS" && test "$NUM_CPUPOOLS" -gt 0 + then + add_device_tree_cpupools + fi } function linux_device_tree_editing() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:10:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401282.643112 (Exim 4.92) (envelope-from ) id 1oVswV-0000Nb-On; Wed, 07 Sep 2022 11:10:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401282.643112; Wed, 07 Sep 2022 11:10:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVswV-0000Mo-JT; Wed, 07 Sep 2022 11:10:03 +0000 Received: by outflank-mailman (input) for mailman id 401282; Wed, 07 Sep 2022 11:10:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVswV-0007R7-0x for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:10:03 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9dc9d397-2e9d-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 13:10:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3A7C1042; Wed, 7 Sep 2022 04:10:06 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 353753F7B4; Wed, 7 Sep 2022 04:09:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dc9d397-2e9d-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v4 0/2] xen/pci: implement is_memory_hole for ARM Date: Wed, 7 Sep 2022 12:09:48 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 ++- xen/arch/arm/pci/pci-host-common.c | 53 ++++++++++++++++++++++++++++-- xen/arch/x86/include/asm/pci.h | 10 ++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 69 insertions(+), 7 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:10:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:10:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401289.643123 (Exim 4.92) (envelope-from ) id 1oVswj-0001J0-Vt; Wed, 07 Sep 2022 11:10:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401289.643123; Wed, 07 Sep 2022 11:10:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVswj-0001It-Sf; Wed, 07 Sep 2022 11:10:17 +0000 Received: by outflank-mailman (input) for mailman id 401289; Wed, 07 Sep 2022 11:10:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVswi-0007R7-H5 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:10:16 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a62e9715-2e9d-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 13:10:15 +0200 (CEST) Received: from DBBPR09CA0048.eurprd09.prod.outlook.com (2603:10a6:10:d4::36) by PAWPR08MB9519.eurprd08.prod.outlook.com (2603:10a6:102:2f1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 11:10:12 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::af) by DBBPR09CA0048.outlook.office365.com (2603:10a6:10:d4::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 11:10:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 11:10:11 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Wed, 07 Sep 2022 11:10:11 +0000 Received: from 58ea49a89c04.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A6545C7F-9985-48A3-8FF7-8BD810CC1F9C.1; Wed, 07 Sep 2022 11:10:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 58ea49a89c04.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 11:10:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB6573.eurprd08.prod.outlook.com (2603:10a6:102:dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 11:09:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 11:09:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a62e9715-2e9d-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y2nBgw2JDrk5kvJ6nSBK54MXzdN6NW6fJ8ShMWEpvsnj1h7n9rr0J3izTu6kyabSg9wmnDVypCaIlLqJdPQtUfV3fw0zVse5sELx0lsrCo+wdYx4ZvpPXC54vMPkC+1LZ1MMr5YpwtcFIwN+k9x21rm5N6gF02FLHDLYTDhMJ1YAJwFvoSfqp5kmHopBRAecJ4cOO5r5pWwpgFatiD88qSipv9mlGLyrKDgorL6k4aoolkV2yKeDnMeWTtVcHNDlKm7fUGnDXgzL0KefB+/7hrIhDmj8mOvA7l+XUphW/Wvdm0UxxLNd0/HXflMR6/j+SYc0kTeOtaDrRm5BuAa8hQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8H5pn8f1VdqPGSdfqwttHldUYLpUMX49Oec+NuKpoKs=; b=a8uBENGsNJRcxSfGalxG7pzlJcFV0hHrIPWl6Mg7LfToYLuGqZlJFr1kcrBw3nFw9oPa5d2Wl5pulZtFYMH7yhChIRY5N8tQW5PwtS3nGtWcD2MShHw86wexp2p5P/yHAbtsoX7j4hw6Y3s6/VMS+mCd+7fhFbcTPMumA8dR/ZZAxUTJ7c/GuI0/FU39ElTc9g6FEzy3n/x43e8M6rUE7GYM0FSXdJ9HNGSvKYUNwPueUmaOKS79YrO6MzzOS+JFT4IgZod3r/sce0Z7fvRz2gBF0/tg6B7CtkrBVlDoM2WcP9NDPPwmiGpIxcZMB7M+YDNk5xuStZfSB7bZvyyA+Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8H5pn8f1VdqPGSdfqwttHldUYLpUMX49Oec+NuKpoKs=; b=5GW01B61wum573qCNZFddzXrwlqyk/CBaqn44owSe6ZSIOwHKz0tPfUf7zZZ2zaLf22zLDZiH3+Y6gqmznoF/t7FMLEb4BtwL2baMu0dOjUhb3yqIVbI0V4E7kpOuW8XhpBrenaoYVmpJvy0N+MLyrFs5gSokrIUfynHtGFVbSY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aXw5vsWrOTOXcF1u/O/mt2tEzFVatxCnMoJ5m8Z6VOIXaJd+cuWICBmYs/rlj2ks+qHUxk/pJlSPQstyOT+GE646xvGeeu51CCsTtc9S+qGD+2HbmlZbiYq1M6oY2CkTFVdCYvOTueYJLk0fuJEK4uiLL6t3CAaKAgwwcOA19TaieitTdHMY+ikx0Phy8UT4OTusbA1BREtbvFjlHotAffzTUjW8u66Tp2z9QmSETQoiJSmF2NwlKKAvA2N/Up6i/27FZVUB8dnmIZCMxLrGyMHCIvOSw3UX3kGx0F5teWKP0N5h1Vax7AtGQUgx0zjfqtosFazMPttNBMdFzrmCNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8H5pn8f1VdqPGSdfqwttHldUYLpUMX49Oec+NuKpoKs=; b=PAGovvV3e/VFFf++Y9S94PJ2JdCmGmxAhiGiJ/zJnVsgUMsnfklLhwxvpuIHP0q6eyDVp9Km5rbZEzBINa5yEg9kyNRA1XNYTyNSw71rU8RwI1LGwx1tsMxG95++yeMgLzwQeIfOQ4tA5sWTBbGcwCHi+GjiD7gyJEW1l9GSpe7ZyZid5YaEursv0WozBXOGukzxo/R4Rotjn7vkLi/yHtihPH9BHZxR+rsK8WOuuM+aMmvYhZO23YO1SDIGHa2dt5zBxg5rT8RJYjN2fZnCq0QW9WjKeVA+TEyDmAHAIcDdCLbidWZi6q1pEUO2zwIx9HNehvr4/PxxfJzPvHVywg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8H5pn8f1VdqPGSdfqwttHldUYLpUMX49Oec+NuKpoKs=; b=5GW01B61wum573qCNZFddzXrwlqyk/CBaqn44owSe6ZSIOwHKz0tPfUf7zZZ2zaLf22zLDZiH3+Y6gqmznoF/t7FMLEb4BtwL2baMu0dOjUhb3yqIVbI0V4E7kpOuW8XhpBrenaoYVmpJvy0N+MLyrFs5gSokrIUfynHtGFVbSY= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Topic: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Index: AQHYwpULGFLWtgCBlkSkZYDaahDS7q3TxKQAgAAEM/CAAAPgAIAAAFfA Date: Wed, 7 Sep 2022 11:09:58 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-4-Henry.Wang@arm.com> <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8B7BBAD4A60A5244AD16A0A9F3955EAD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5112c255-14c4-4f25-8a01-08da90c1887b x-ms-traffictypediagnostic: PAXPR08MB6573:EE_|DBAEUR03FT036:EE_|PAWPR08MB9519:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6NeRYH4mwAzbtJNLpczen7ln4qfMAU8ii2r+4uw67Nqt4P9EIdkz1WeIY2upm8uxkCo6+6ppXSODxbY4dfgrhnCoeNPEccMeNthsl1qNIr0AWHUMZ5gR2g6aCplokLlBN5jAGAuu86QPPsdDve64z/J0ypkrcJsTzTdmTALAyc+uQTam6XFvhRkYJljcluNh13ZW2tH6KjRTo4DtOr4+MrU2Si+VkEomJao7wQCTocsUoUYt09geZ/aKiviFlmELE7GuAGuolFYjVeAEkKV7lBHECo6bQJ7JMlr8gS+Cy5Jrd4TIk41CysumI6twTktGbRYJzEGBtySlec70+TXMIQeBWQzLsJg3PRIzmA0XjSg4Vsc3XKV6vwO6QMKpgoY1zzXzfJqLOYV7M07HaGLZzNwnwAkAG/dBvWEA/FULX3S0qpAbWExL90FnGCEmue79QTIKjd9eHjE/EgVPqB/JbEegf9oizQhM//zqyio775w49BGgHwH3qauCu0NeQDTr2S+fIUD1bW78piBYj6e9z+7OHe4NnYVu0DfdGzbpaaJ/W29IZJ1MZZedVUFhIB4+w6eePXY4HXCf14bLAJd8fqE18PsUbFZyFmySTLcd+gsBBFvzXH52Jk77nTNa6r33Q3w0ojBsc8bArllmTt9xeOEkMui3S3C7ZyjYeq/wLk+wzE5nLsC2cUMJGEqGNGB2BKVIY+t3pMfLg9R2ZXWxp+8LL4LClGMsMsxMeAU1ViIgvMhAXOxNRQMXGC28URfk/io/vY/xhvX6d2VUi/xo5Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(5660300002)(8936002)(52536014)(2906002)(38070700005)(122000001)(38100700002)(41300700001)(71200400001)(478600001)(26005)(9686003)(7696005)(6506007)(110136005)(316002)(54906003)(76116006)(83380400001)(4326008)(66946007)(55016003)(8676002)(64756008)(66446008)(66476007)(66556008)(186003)(33656002)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6573 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5dee4039-36cc-42d0-bb93-08da90c1808a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nhp41hAr0jrkrJq2A8dRpDaX+tjIvJDhtJ/mi7+8e0wYHuJJH8yYVFywe79FU5PFCVeKswxsxAx72BAyi7xFw32s8eepANBdMuw0z/2oukx64aiGMQTgwW/bF750EoRXVf9WvSOodBfXHwxJx1R7F2IqIiAiIH3hSKu+/Ihu5hM6BQ1awBR1BWgRwnU+f5ixsJm3oJzqXjXfJbqeogmvof+rmu/7kIXR7PPYVD9ar1yfRYzLuccj8Jc4vWFEnld6xtdELr41XNh17QJAzji9ziqlj/IXiyn6oc2UOT7TbtYyeDmqX9VEExFT5lmOcqangzS8U7l10Z0ApUT/P0YkDmhFad31fqjAzFlOVkJDQoVhR1xeQF+DG+TsqsbYHxVdmmpi2OKCjA/0gxFhxY3j0sZazwsaizpNhwMMhuNrHWu7S/XVNXFOGYWqPBTe0AZRibVb3EwaFpKTaqsDzY7CtnqANX6FHdg+0WXkCHk7g5JNGySEeMRtdmkVshWrNMy1tImEVeoGOIuyzL9vFg9a3rCdinIlkWIOcbk1/fSZZ5upPLs6spdwQo7asW1N0lJwXwSFk98VqBI7xKSLlwq9mlqWhZkIN6FE0DkhBGsTqM3aEKMYs51GudtMYobZ462A7+yeoYjWbPZ+AtFXuA6o8qGE5pAXlu5PKHoqgKkj3Z0gP5mPgpF1iZ/+HhMVoXth+fc6MDOE6mlla5t+Pxz1emBaQ5kSqn+JFJjz82IB8uCeIPg/nvGJc8gmlfEq9iuvEK0a6dkipJAuDaoFUd2GUg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(376002)(39860400002)(36840700001)(46966006)(40470700004)(356005)(82740400003)(83380400001)(40460700003)(36860700001)(2906002)(81166007)(8676002)(70206006)(110136005)(4326008)(316002)(54906003)(82310400005)(70586007)(8936002)(55016003)(52536014)(40480700001)(5660300002)(26005)(336012)(186003)(107886003)(6506007)(7696005)(41300700001)(47076005)(9686003)(478600001)(86362001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:10:11.9232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5112c255-14c4-4f25-8a01-08da90c1887b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9519 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+PiBAQCAtNjA5LDcgKzYwOSw3IEBAIHZvaWQg X19pbml0IHNldHVwX3hlbmhlYXBfbWFwcGluZ3ModW5zaWduZWQNCj4gPj4gbG9uZyBiYXNlX21m biwNCj4gPj4NCj4gPj4gSSB0aGluayB0aGUgZnVuY3Rpb24gYWxzbyB3YW50IHRvIGJlIHJlbmFt ZWQgdG8gbWF0Y2ggdGhlIGNvZGUgYmVsb3cuDQo+ID4NCj4gPiBIbW1tLCByZW5hbWluZyB0aGUg bmFtZSB0byAic2V0dXBfZGlyZWN0bWFwX21hcHBpbmdzIiB3b3VsZA0KPiA+IHNvbWVob3cgbGVh ZCBtZSB0byB0aGluayBvZiB3ZSBhcmUgZ2V0dGluZyByaWQgb2YgdGhlIG5hbWUgInhlbmhlYXAi DQo+ID4gY29tcGxldGVseSBpbiB0aGUgY29kZSwgd2hpY2ggc2VlbXMgYSBsaXR0bGUgYml0IHNj YXJ5IHRvIG1lLi4uDQo+ID4NCj4gPiBCdXQgSSBqdXN0IGNoZWNrZWQgdGhlcmUgaXMgYSBjb21t ZW50DQo+ID4gIi8qIFNldCB1cCB0aGUgeGVuaGVhcDogdXAgdG8gMUdCIG9mIGNvbnRpZ3VvdXMs IGFsd2F5cy1tYXBwZWQNCj4gbWVtb3J5LiINCj4gPiBhYm92ZSB0aGUgZnVuY3Rpb24gYW5kIHRo ZSBkZWNsYXJhdGlvbiBzbyBJIGd1ZXNzIHdlIGFyZSBmaW5lPw0KPiANCj4gV2UgYXJlIG5vdCBn ZXR0aW5nIHJpZCBvZiAieGVuaGVhcCIuIEluIGZhY3QgdGhlIGNvbW1vbiBjb2RlIHdpbGwNCj4g Y29udGludWUgdG8gdXNlIHRoZSBjb25jZXB0Lg0KDQpBY2suDQoNCj4gDQo+IFdoYXQgd2UgbWFr ZSBjbGVhciBpcyB0aGlzIGZ1bmN0aW9uIGlzIG5vdCBvbmx5IGhlcmUgdG8gbWFwIHRoZSB4ZW5o ZWFwDQo+IGJ1dCBvdGhlciBtZW1vcnkgKGUuZy4gc3RhdGljIGRvbWFpbiBtZW1vcnkgb24gYXJt NjQpLg0KDQpJbiB0aGF0IGNhc2UgSSB0aGluayB0aGUgY29tbWVudCBpbiBmdW5jdGlvbiBkZWNs YXJhdGlvbiAoYXR0YWNoZWQgYmVsb3cpDQpgYGANCi8qIFNldCB1cCB0aGUgeGVuaGVhcDogdXAg dG8gMUdCIG9mIGNvbnRpZ3VvdXMsIGFsd2F5cy1tYXBwZWQgbWVtb3J5Lg0KICogQmFzZSBtdXN0 IGJlIDMyTUIgYWxpZ25lZCBhbmQgc2l6ZSBhIG11bHRpcGxlIG9mIDMyTUIuICovDQpleHRlcm4g dm9pZCBzZXR1cF94ZW5oZWFwX21hcHBpbmdzKHVuc2lnbmVkIGxvbmcgYmFzZV9tZm4sIHVuc2ln bmVkIGxvbmcgbnJfbWZucyk7DQpgYGANCndvdWxkIGFsc28gbmVlZCBjaGFuZ2VzLCBhcyBJIHRo aW5rIGl0IG9ubHkgcmVmZXJzIHRvIHRoZSBBcm0zMi4NCg0KSG93IGFib3V0DQovKg0KICogRm9y IEFybTMyLCBzZXQgdXAgdGhlIHhlbmhlYXA6IHVwIHRvIDFHQiBvZiBjb250aWd1b3VzLA0KICog YWx3YXlzLW1hcHBlZCBtZW1vcnkuIEJhc2UgbXVzdCBiZSAzMk1CIGFsaWduZWQgYW5kIHNpemUN CiAqIGEgbXVsdGlwbGUgb2YgMzJNQi4NCiAqIEZvciBBcm02NCwgc2V0IHVwIHRoZSBkaXJlY3Rt YXAgYXJlYSBvZiBtZW1vcnkuDQogKi8NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4g Q2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:11:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:11:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401300.643134 (Exim 4.92) (envelope-from ) id 1oVsxa-000260-99; Wed, 07 Sep 2022 11:11:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401300.643134; Wed, 07 Sep 2022 11:11:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsxa-00025t-64; Wed, 07 Sep 2022 11:11:10 +0000 Received: by outflank-mailman (input) for mailman id 401300; Wed, 07 Sep 2022 11:11:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsxZ-00025a-7Q for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:11:09 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c58694bd-2e9d-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 13:11:07 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 989CC1042; Wed, 7 Sep 2022 04:11:13 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 030203F7B4; Wed, 7 Sep 2022 04:11:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c58694bd-2e9d-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Date: Wed, 7 Sep 2022 12:09:50 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memory_hole which will check if BAR is not overlapping with any memory region defined in the memory map. On ARM, pci_check_bar will go through the host bridge ranges and check if the BAR is in the range of defined ranges. Signed-off-by: Rahul Singh --- Changes in v4: - check "s <= e" before callback - Add TODO comment for revisiting the function pci_check_bar() when ACPI PCI passthrough support is added. - Not Added the Jan Acked-by as patch is modified. Changes in v3: - fix minor comments --- xen/arch/arm/include/asm/pci.h | 2 ++ xen/arch/arm/pci/pci-host-common.c | 49 ++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/pci.h | 10 ++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 65 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 80a2431804..8cb46f6b71 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, int pci_host_bridge_mappings(struct domain *d); +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); + #else /*!CONFIG_HAS_PCI*/ struct arch_pci_dev { }; diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index 89ef30028e..13d419aa45 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -24,6 +24,16 @@ #include +/* + * struct to hold pci device bar. + */ +struct pdev_bar_check +{ + unsigned long start; + unsigned long end; + bool is_valid; +}; + /* * List for all the pci host bridges. */ @@ -363,6 +373,45 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0; } +static int is_bar_valid(const struct dt_device_node *dev, + uint64_t addr, uint64_t len, void *data) +{ + struct pdev_bar_check *bar_data = data; + unsigned long s = bar_data->start; + unsigned long e = bar_data->end; + + if ( (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) + bar_data->is_valid = true; + + return 0; +} + +/* TODO: Revisit this function when ACPI PCI passthrough support is added. */ +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) +{ + int ret; + const struct dt_device_node *dt_node; + unsigned long s = mfn_x(start); + unsigned long e = mfn_x(end); + struct pdev_bar_check bar_data = { + .start = s, + .end = e, + .is_valid = false + }; + + if ( s >= e ) + return false; + + dt_node = pci_find_host_bridge_node(pdev); + if ( !dt_node ) + return false; + + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); + if ( ret < 0 ) + return false; + + return bar_data.is_valid; +} /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h index c8e1a9ecdb..f4a58c8acf 100644 --- a/xen/arch/x86/include/asm/pci.h +++ b/xen/arch/x86/include/asm/pci.h @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) void arch_pci_init_pdev(struct pci_dev *pdev); +static inline bool pci_check_bar(const struct pci_dev *pdev, + mfn_t start, mfn_t end) +{ + /* + * Check if BAR is not overlapping with any memory region defined + * in the memory map. + */ + return is_memory_hole(start, end); +} + #endif /* __X86_PCI_H__ */ diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index cdaf5c247f..149f68bb6e 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) /* Unable to size, better leave memory decoding disabled. */ return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { /* * Return without enabling memory decoding if BAR position is not @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), PFN_DOWN(addr + size - 1)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:12:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:12:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401308.643145 (Exim 4.92) (envelope-from ) id 1oVsz2-0002lu-KX; Wed, 07 Sep 2022 11:12:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401308.643145; Wed, 07 Sep 2022 11:12:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsz2-0002ln-HU; Wed, 07 Sep 2022 11:12:40 +0000 Received: by outflank-mailman (input) for mailman id 401308; Wed, 07 Sep 2022 11:12:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsz0-0002lc-C3 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:12:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id faefcd50-2e9d-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:12:37 +0200 (CEST) Received: from AM5PR0601CA0074.eurprd06.prod.outlook.com (2603:10a6:206::39) by GV2PR08MB8318.eurprd08.prod.outlook.com (2603:10a6:150:b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 7 Sep 2022 11:12:35 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::f2) by AM5PR0601CA0074.outlook.office365.com (2603:10a6:206::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 11:12:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 11:12:34 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 11:12:34 +0000 Received: from 23270e56d60b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D039955D-99BC-4BDA-9025-AD8400FCE720.1; Wed, 07 Sep 2022 11:12:27 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 23270e56d60b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 11:12:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8155.eurprd08.prod.outlook.com (2603:10a6:150:91::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 11:12:24 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 11:12:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faefcd50-2e9d-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RmdHr0mozKoDr1W74jdEzUJ/QRdBC/ecHDMtOA55YnHDIC7vMarmuHNBWq63DwDfnZ11J6+GkiI263L57SDRUiWg9sArcYLKIgE97lNf6vHnxDjDoVf2hoacPG5JtA/szn09zCHFFmxo1ymjVj0udEhsyc29US7hmngf46YECqjwrbS87PruOP81QzYJ9JX6raDGVmX0Y6t2F5RxXACBmECaa4pCKygTEb8GzCtSm6YnmEPu43eO1+5g2IPbLecDbNs9ld86sKIbY3wSwcuTudROP7O/N2THLh51+vdnfE3wQnjd6O4z2ZIOWSjdXksKgmIEHF758TQzyjRGzl4WIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/ImRGUKclv4L01W4gnUgTQ2PXKpJkMORfZP2Q730zQ=; b=adNfckj6dOoIMaWnAkZOjubdLlBbV1tH/ApHSe27z0vmAZXLkJtiyboj/uZTs5xxIdPHbw0VIYBwuI5+bC2RSSaVcQNc20LMZOl6l1Fv7V19otGHuXpiDmpQqg4YEw1PcvUo3AYUzuIEvDZRLUXwxwMaEVnF9O1Lw/CvP80aDgnkFnjLnQum8hPU4Mn42mXy+AG4IphEv/MpZUKBoar9UstSxnHLAEOpKWdzR9wfB3S2PkkSwkqXsTobmebY2Fkuz7uvdTWDrKC5o7hoxLqCvyJ49UHkRNATANVph40y/siCW1AyYXGaF1Jt3gDXqVOHMmuwVHVCURQQo4GF7xDSmg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e/ImRGUKclv4L01W4gnUgTQ2PXKpJkMORfZP2Q730zQ=; b=W/wig3skAjx7hXuMJKrKpzYwNkp63TZYPshVeebFFSUoPBTXAv/tM0oAdZGEeJ40gXLjjKWS9krSPQNobUDV/5Lcl65Ai41vsqw5fEpkqLS2S14HKQ/NConB1huL7HN+xq0wjmJLAY0OOkTdawS8UGZFrr1ZdHjVfrARC9MN4ss= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7a5b8a48b78c9707 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Co1MfP+smSvjLv49ZvGCblkPWSy54CVM/x5VGeGoDYl0+SpPnePhTeyhvPM20IjVBdgD3KTmM+kcy4a2cVWI03t8pxYPp87XzcuiKrNi9CLcgPnv87GgeGLSQBgsYhllsmeUcFr4WjYke9lXBpOTcBPvE5ByDazdRUKRL+qwUqL8NJNbvnZeGnEVDRiB5OZ43KJ9NjyjYkhuiRZYDOJUwM3wzTiCFbvboztN2OjORd2lBjo4OgqyoSIq6lTpxDwPZ8s04IR63h+n7TXX4ontiIrhrfA40OTz1XVpAuRMRAmBoTe3NYW3MX/mukoUdUreOmvHUj3wDB/lKesrDaDfsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/ImRGUKclv4L01W4gnUgTQ2PXKpJkMORfZP2Q730zQ=; b=M3/RFEObSrr18r8LkR15KV2HvQeC7t20/jtuOBBtvLLxjDaBxV5WCqDc6XeJ0Nrvb1m9VNFzcwe1e1DOqeI4tSoWARG6e4b+U7uqE5Sbs62DNhntq1krfbLG8MA7QGeC1BiGpBlwQ5ZkP7QMGmUDVsV3wvtz5IoNjErxHA9o/FlpN8r5SG/XloAvi89jtfCGkYApLOvOsXvMELcYb7jVT+h/USaOriNabwsOlR6Fx/7vpiicl67dAIP3j5NXUET3Oe885DicN+pXlRjK9DhP72V4owPwzgAHzwJB8/Ie779nEg9kbniMvAsnq6FNjQsWp2hbwUHplzpwu6mltmsbeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e/ImRGUKclv4L01W4gnUgTQ2PXKpJkMORfZP2Q730zQ=; b=W/wig3skAjx7hXuMJKrKpzYwNkp63TZYPshVeebFFSUoPBTXAv/tM0oAdZGEeJ40gXLjjKWS9krSPQNobUDV/5Lcl65Ai41vsqw5fEpkqLS2S14HKQ/NConB1huL7HN+xq0wjmJLAY0OOkTdawS8UGZFrr1ZdHjVfrARC9MN4ss= From: Bertrand Marquis To: "leo.yan@linaro.org" CC: Jan Beulich , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Thread-Topic: [PATCH] xen/arm: acpi: Include header file for version number Thread-Index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8AgAAAyoCAAAC7AIAABHeAgAAOWQCAABGIgIAAAQ0A Date: Wed, 7 Sep 2022 11:12:24 +0000 Message-ID: References: <20220906113112.106995-1-leo.yan@linaro.org> <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> <5ce7f63c-5ba5-f2cb-8e3e-f6dd2d9d76f7@suse.com> <524F3B92-5298-4BE3-864D-A076A8873800@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 66079fd9-7f47-4499-cfb9-08da90c1dd8e x-ms-traffictypediagnostic: GV1PR08MB8155:EE_|VE1EUR03FT026:EE_|GV2PR08MB8318:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6+gWzG4ahjH9fMG9QBa2/rtoxzxkXxaRNS01tTIHyEmhPW9CB+oBJmk1ShSQZoYq6Uzk7qw3Jf0lklYHaY9IYRoscKIO0GhqNOmz9iq1aZX7KWtnVQv4dcuMOH67vOpHL3AZ0n0GCCWynWEmIG+UQmgHvBrHexgmR7DtcZq37PzbJ6XzoR9NmFXifLeYp7ix9Hnzq90mKCJUUlJk19R4nTiRwmfJ2Pke5PP4f8kQh4/nMAsNrsPsAznJjH2MwxhqkYzkE77CBboOzlnIsHDkbOibqiUqx1rou57Ltxon54vT0KPmOLuGbnhP8q9ct6EjN6urT2LqWpekJPesCsA8nHACD/YtwRcmWdKAGnYCt5UEEAMFjkdIMDSeyVfOcSinDeMLvietMFY7OQ4g/RoT6RWGb8LwqhWPEUZ6WakGE02Fqhh8KbgBh/sQ4Hbc43Ywi29uJ2yB5cXH9RbuXoX5DdnS2ZHV4HQUFxk/9xp+rhvVlOHNj6C+he2F6dsqZXZ8y6CGoscea2co/JK45x/1+o66jJ569lNVgOnVglutZunRl29oG4lCiYpwvGvuJHZLacokKDezXaC/P0a0MqB92PpAwa7mc86N2rC8p97hVA9nOJMsnf2vGaT+UCr9IRndQCwvwUOWLj7YrsbaLDk10R87c8W1aJBqbQGQoiWkp7d0xj1KF9uV3U51XbZGWbpPr+iIKEUkdC+ZP0lKRgqo7UyF1UKPLi1PsZDHcrvu/FmbBkVFl0hGtD1tBUXoq74Fa+v95Gofak8/7xB9gkxQhgOndrs32DJL2ptsjLtgvuA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(478600001)(53546011)(71200400001)(38100700002)(26005)(6506007)(6486002)(6512007)(41300700001)(8936002)(2616005)(2906002)(6916009)(36756003)(33656002)(54906003)(86362001)(186003)(8676002)(4326008)(64756008)(5660300002)(66476007)(76116006)(66446008)(66556008)(66946007)(91956017)(38070700005)(122000001)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9AC2FEB69B0682428DF8ABA20453FAF6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8155 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4425b620-9dae-4a28-84c0-08da90c1d794 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QYzRME0eGQPmCIldv2IrYwws3jo02eHgjJ0OU4eY8wvcvEv1NDpGWh6d3r1pIKi1L5j8rp7MQZITUcpPGrKDvjQ6KHnoIbvTprIHchZmAPQ1/9z/xij6YN6VVa7/JFUWyUJPLFBolF398pPpoWE1UPWddg/JNS1039Nfl62wyjxG6wI3n0Hg34BTBaG6yLT+VP9vEXzpVK3bBAe/zheGGWGOUz1DBSnzX+VLHlHBgEW/MtUQ0N/G+oLqhnksDQTCANwZVUv+xARpqSXTYIC/4WO410cheLhaI8zojaEfzBL2hkVAgwq6ctOv5deG+Db3GqkhHlikLJLM788yrxtFb3t3UL9XPvYYEVEleyjTPPZx7jrs0vwTnPWUsE2NXtAtzzTcZvnE2acbLqByf/VLIIpJ6Axfj1weo5kV92PhMV7D4QYMTAfeQNfBjQzB2gpT7ZantoumXaY1F5+lsTWWAcgab8BPTvCY/5+2XkezEkgFj2Cmr7YXFH9+FauumdEWb5f6IYozEUOiVxVIZbDY6uu+i5ukCM3HOEi2NtMPsYtjK2UqrIAnTI+EjK01pSdYwhI9ihPN5m/3nQ5Z02KOXvG/1frM+s5PANRHv7HVtZB3qzDg47j9sO/DWv04tavuKR5R76oeXunm90tmBbtwUBhxJLu/S0LTMHqe5nfWV36w9zbjiws7+MGq4cvAll9VqlsO7KX1dcDwBLQLk0MCt68ivxA4nGj12MvGxZfarbv3kaMQcVvYi4SFZQ7lLODR6CRRZMh5Of8/RQG+bUXxug== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(376002)(36840700001)(40470700004)(46966006)(316002)(36860700001)(8676002)(356005)(70586007)(4326008)(70206006)(82740400003)(6486002)(2616005)(81166007)(186003)(336012)(41300700001)(47076005)(40460700003)(6512007)(6506007)(54906003)(53546011)(26005)(8936002)(478600001)(33656002)(86362001)(2906002)(6862004)(5660300002)(40480700001)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:12:34.5308 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66079fd9-7f47-4499-cfb9-08da90c1dd8e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8318 SGkgTGVvLA0KDQo+IE9uIDcgU2VwIDIwMjIsIGF0IDEyOjA4LCBMZW8gWWFuIDxsZW8ueWFuQGxp bmFyby5vcmc+IHdyb3RlOg0KPiANCj4gT24gV2VkLCBTZXAgMDcsIDIwMjIgYXQgMTA6MDU6NTRB TSArMDAwMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4gDQo+IFsuLi5dDQo+IA0KPj4+Pj4+ IEkgdGhpbmsgYSBkZWZpbmUgaW4gY29tcGlsZS5oIHVzaW5nIHN0cmluZ2lmeSBpcyB0aGUgZWFz aWVzdCBzb2x1dGlvbjoNCj4+Pj4+IA0KPj4+Pj4gQWghIEkgdGhvdWdodCB5b3Ugd2VyZSBzdWdn ZXN0aW5nIHRvIHR3ZWFrIF9fc3RyaW5naWZ5LiBUaGlzIGlzIC4uLg0KPj4+PiANCj4+Pj4gQWxz byBwb3NzaWJsZSBidXQgYSBiaXQgbW9yZSB0cmlja3kNCj4+Pj4gDQo+Pj4+Pj4gI2RlZmluZSBY RU5fU1RSX1ZFUlNJT04gIl9fc3RyaW5naWZ5KFhFTl9WRVJTSU9OKSIuIl9fc3RyaW5naWZ5KFhF Tl9TVUJWRVJTSU9OKeKAnQ0KPiANCj4gSnVzdCByZW1pbmQsIFdlIG5lZWQgdG8gZGVmaW5lIFhF Tl9WRVJTSU9OX1NUUklORyBpbiBjb21waWxlLmguaW4gcmF0aGVyDQo+IHRoYW4gaW4gY29tcGls ZS5oLCBzb21ldGhpbmcgbGlrZToNCj4gDQo+ICAjZGVmaW5lIFhFTl9WRVJTSU9OX1NUUklORyBA QHZlcnNpb25AQC5AQHN1YnZlcnNpb25AQA0KDQpWZXJ5IHRydWUgYnV0IHlvdSB3aWxsIG5lZWQg dGhlIHF1b3RlcyBoZXJlDQoNCj4gDQo+Pj4+IFF1b3RlcyBhdCBiZWdpbm5pbmcgYW5kIGVuZCBz aG91bGQgbm90IGJlIHRoZXJlLg0KPj4+IA0KPj4+IEkgaGF2ZSB0byBhZG1pdCB0aGF0IEkgZGlz bGlrZSB0aGUgU1RSIGluZml4LiBJJ2QgcHJlZmVyIGEgc3VmZml4ZWQgdmFyaWFudA0KPj4+IChl LmcuIFhFTl9WRVJTSU9OX1NUUklORykgb3Igb25lIG9taXR0aW5nICJzdHJpbmciIGFsdG9nZXRo ZXIsIGUuZy4NCj4+PiBYRU5fRlVMTF9WRVJTSU9OIChhbGJlaXQgSSBzZWUgImZ1bGwiIGFzIGJl aW5nIHBvdGVudGlhbGx5IGFtYmlndW91cyBoZXJlLA0KPj4+IHNpbmNlIG9uZSBtaWdodCBleHBl Y3QgdGhhdCB0byBpbmNsdWRlIFhFTl9FWFRSQVZFUlNJT04gYXMgd2VsbCB0aGVuKS4NCj4+IA0K Pj4gDQo+PiBWZXJzaW9uIGlzIGEgdmFsdWUgc28gaGVyZSBJIHRob3VnaCBpdCBtYWRlIHNlbnNl IHRvIGRpc3Rpbmd1aXNoIHRoYXQgb25lIGFzIGl0IGlzIGEgc3RyaW5nIHJlcHJlc2VudGF0aW9u IG9mIGl0Lg0KPj4gDQo+PiBYRU5fVkVSU0lPTl9TVFJJTkcgaXMgb2sgSSB0aGluay4NCj4+IA0K Pj4gSSBnZW5lcmFsbHkgZGlzbGlrZSBhbnl0aGluZyBuYW1lZCBGVUxMLCBFWFRSQSwgQkFTRSBv ciBvdGhlciB3aGljaCBhcmUganVzdCB1bmNsZWFyLg0KPiANCj4gWEVOX1ZFUlNJT05fU1RSSU5H IGlzIGdvb2QgZm9yIG1lLg0KPiANCj4gSGkgQmVydHJhbmQsIGp1c3QgbGV0IG1lIGtub3cgaWYg eW91IHByZWZlciB0byBjb29rIHlvdXIgb3duIHBhdGNoIGZvcg0KPiB0aGlzIChlc3NlbnRpYWxs eSB0aGlzIGlkZWEgaXMgY29taW5nIGZyb20geW91KSBvciB5b3Ugd2FudCBtZSB0bw0KPiBmb2xs b3cgdXAgZm9yIGEgbmV3IHBhdGNoPyAgRWl0aGVyIHdheSBpcyBmaW5lIGZvciBtZS4NCg0KUGxl YXNlIHB1c2ggYSBuZXcgcGF0Y2ggYW5kIGFkZDoNClN1Z2dlc3RlZC1ieTogQmVydHJhbmQgTWFy cXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4g DQo+IFRoYW5rcywNCj4gTGVvDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:15:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401317.643155 (Exim 4.92) (envelope-from ) id 1oVt1Y-0003TO-4V; Wed, 07 Sep 2022 11:15:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401317.643155; Wed, 07 Sep 2022 11:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt1Y-0003TH-1y; Wed, 07 Sep 2022 11:15:16 +0000 Received: by outflank-mailman (input) for mailman id 401317; Wed, 07 Sep 2022 11:15:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt1X-0003T9-2W for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:15:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt1W-0003jL-P4; Wed, 07 Sep 2022 11:15:14 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVt1W-00059P-Hz; Wed, 07 Sep 2022 11:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jZWXRwyI8Dp3QWLaXCzyLmSVwoQGad1to+F9DsgPWNc=; b=eSMGHFMfCEQOhpRekUwfSl+HnA eyRa+PE8vcy/udMdr309p5PiKTCzxAEI4aV09++KIDGkkyhqflu91rPzSXcLrcAZzQ0/DFEHTQ/uP TO6vNKj3lP9nAyWl9aRAfDMN8bVXSEBi3Jrv0mgZcQHnq3ascR+3FuBc7ERhiOFrKdT0=; Message-ID: <28aa7040-af9e-eda7-ee04-60c71019e91c@xen.org> Date: Wed, 7 Sep 2022 12:15:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-4-Henry.Wang@arm.com> <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 12:09, Henry Wang wrote: > Hi Julien, Hi Henry, >> -----Original Message----- >> From: Julien Grall >>>>> @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned >>>> long base_mfn, >>>> >>>> I think the function also want to be renamed to match the code below. >>> >>> Hmmm, renaming the name to "setup_directmap_mappings" would >>> somehow lead me to think of we are getting rid of the name "xenheap" >>> completely in the code, which seems a little bit scary to me... >>> >>> But I just checked there is a comment >>> "/* Set up the xenheap: up to 1GB of contiguous, always-mapped >> memory." >>> above the function and the declaration so I guess we are fine? >> >> We are not getting rid of "xenheap". In fact the common code will >> continue to use the concept. > > Ack. > >> >> What we make clear is this function is not only here to map the xenheap >> but other memory (e.g. static domain memory on arm64). > > In that case I think the comment in function declaration (attached below) > ``` > /* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. > * Base must be 32MB aligned and size a multiple of 32MB. */ > extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns); > ``` > would also need changes, as I think it only refers to the Arm32. > > How about > /* > * For Arm32, set up the xenheap: up to 1GB of contiguous, > * always-mapped memory. Base must be 32MB aligned and size > * a multiple of 32MB. > * For Arm64, set up the directmap area of memory. One remark. I would say: "map the region in the directmap area" Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:16:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401324.643166 (Exim 4.92) (envelope-from ) id 1oVt2e-000469-Dy; Wed, 07 Sep 2022 11:16:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401324.643166; Wed, 07 Sep 2022 11:16:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt2e-000462-BJ; Wed, 07 Sep 2022 11:16:24 +0000 Received: by outflank-mailman (input) for mailman id 401324; Wed, 07 Sep 2022 11:16:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt2d-00045s-EA for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:16:23 +0000 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [2607:f8b0:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8083ae48-2e9e-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:16:22 +0200 (CEST) Received: by mail-pf1-x433.google.com with SMTP id d82so651586pfd.10 for ; Wed, 07 Sep 2022 04:16:22 -0700 (PDT) Received: from leoy-huanghe.lan (45.78.11.189.16clouds.com. [45.78.11.189]) by smtp.gmail.com with ESMTPSA id h12-20020a17090a2ecc00b001fdea53b90csm10788453pjs.16.2022.09.07.04.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 04:16:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8083ae48-2e9e-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=tPO4IhBF7wjvwU+GHqokUrye5m5b4pJOPaUDIfvbkk8=; b=gooRwmWWPtr1nR/ie/0LA3iRAANFIBZUgdOUW7e5UnKl4A4dDHbVeTh8FJM4veTRVu QQZQNHlOCycOO1CR7aCC0CLlaKMcbTNwrTkISulZ04vSjU6rXp2UsuSJLzTRTOp6tMQ7 j+IXAbjZCw9hIPzd2uZ3/jwNSMBGSfiVPMcBwP4A/PKge1KCw7mTe8CKcKyTqcUWsHQZ B5Z07pzHr0tuhpm7sYFwy5c3kXbAN8+OdNLID7xFe5mE7DwEPu32I/5EiFcvRP5a1NRv AIljdnatvz+ArLs8vyHb+EH8xnuYRbgq4wss0Qr9o7wyFAAgbdCbWPck+WElV2zjJqia leQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=tPO4IhBF7wjvwU+GHqokUrye5m5b4pJOPaUDIfvbkk8=; b=gtGv3mQ+gI4TtK74P/q99YKWNTFfKJ3+5SUAOxx1nAmI3JtHT9eYzrfRUQePpwXfDc 4dd9wkrWlQFnaEhG9klRl57Eyoki2co48ZOAgqTipYZzbM1sugB2yeLGTJ3PYNzuBuP8 SdgEh9OnhJNZNGTAWkApySyPWIkAtT9f/bD7NqJojfCJVe9iXWgg1dQZAJdmxB1jLwgO wNKlKDN72frOxj6MkNaFXdiyM/BNtFRgceIr9L0FwN4ykgmZVe9pD0RpP0hg2cMa5v5D zogl9+voBRsUMo+lw72J8YYLJJ8qs4X8ETKqGNIaqYLjCRlJCAzkPCrCho1Z5g0X94C2 gKbw== X-Gm-Message-State: ACgBeo0jtOpZza7hhISYmJAgPxNHmfV9kktw5vtmKw74eB8/dyyTDTFm hxmG6BM2ia4impseBbl62IvQIw== X-Google-Smtp-Source: AA6agR6hZtobP//j/AwM19R3JdlSpWQ3OFFOCZS23/S3mZpboxo+MkyiLoz5pyLtzNtGZDR/zBZqjQ== X-Received: by 2002:a63:1a04:0:b0:42b:d33a:2613 with SMTP id a4-20020a631a04000000b0042bd33a2613mr2835435pga.429.1662549380780; Wed, 07 Sep 2022 04:16:20 -0700 (PDT) Date: Wed, 7 Sep 2022 19:16:16 +0800 From: Leo Yan To: Bertrand Marquis Cc: Jan Beulich , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH] xen/arm: acpi: Include header file for version number Message-ID: References: <79fa1351-18e5-0a54-c50d-c9b09a6b3d9e@xen.org> <5C05BF68-C788-47AF-A967-338875740D49@arm.com> <57d2eb45-bdbe-02b3-4ada-10ff278d699b@xen.org> <10E7EFB2-65A4-4092-9DC5-71825BC9595B@arm.com> <5ce7f63c-5ba5-f2cb-8e3e-f6dd2d9d76f7@suse.com> <524F3B92-5298-4BE3-864D-A076A8873800@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 07, 2022 at 11:12:24AM +0000, Bertrand Marquis wrote: [...] > > Just remind, We need to define XEN_VERSION_STRING in compile.h.in rather > > than in compile.h, something like: > > > > #define XEN_VERSION_STRING @@version@@.@@subversion@@ > > Very true but you will need the quotes here Yeah. > >>>> Quotes at beginning and end should not be there. > >>> > >>> I have to admit that I dislike the STR infix. I'd prefer a suffixed variant > >>> (e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g. > >>> XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here, > >>> since one might expect that to include XEN_EXTRAVERSION as well then). > >> > >> > >> Version is a value so here I though it made sense to distinguish that one as it is a string representation of it. > >> > >> XEN_VERSION_STRING is ok I think. > >> > >> I generally dislike anything named FULL, EXTRA, BASE or other which are just unclear. > > > > XEN_VERSION_STRING is good for me. > > > > Hi Bertrand, just let me know if you prefer to cook your own patch for > > this (essentially this idea is coming from you) or you want me to > > follow up for a new patch? Either way is fine for me. > > Please push a new patch and add: > Suggested-by: Bertrand Marquis Sure, will do. Thanks all for suggestions. Leo From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401331.643178 (Exim 4.92) (envelope-from ) id 1oVt3B-0004ep-NV; Wed, 07 Sep 2022 11:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401331.643178; Wed, 07 Sep 2022 11:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt3B-0004ei-K5; Wed, 07 Sep 2022 11:16:57 +0000 Received: by outflank-mailman (input) for mailman id 401331; Wed, 07 Sep 2022 11:16:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt3A-00045s-9U for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:16:56 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140053.outbound.protection.outlook.com [40.107.14.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9467d3a5-2e9e-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:16:55 +0200 (CEST) Received: from AS9PR06CA0074.eurprd06.prod.outlook.com (2603:10a6:20b:464::20) by AS8PR08MB8039.eurprd08.prod.outlook.com (2603:10a6:20b:549::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Wed, 7 Sep 2022 11:16:52 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::86) by AS9PR06CA0074.outlook.office365.com (2603:10a6:20b:464::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 11:16:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 11:16:52 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 07 Sep 2022 11:16:51 +0000 Received: from e518aeca4fd8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 109358C0-7E21-4C69-B1E3-1921148BDFBA.1; Wed, 07 Sep 2022 11:16:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e518aeca4fd8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 11:16:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR3PR08MB5801.eurprd08.prod.outlook.com (2603:10a6:102:81::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 11:16:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 11:16:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9467d3a5-2e9e-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IOyodKmdkASRjdJ/Sjvx6y5nLeQ92O52ssLGTBZ5mlCoVTdz+vNs6bv7VJ/O9X0SFzorzHGGK5U5hMP4y+Se5yxQ1/8YvTTirZOzBNdIucLtJzfp1k/h7UUT7KiWjaymrfk9YonW7BA2grEpqFtf7hgGXGGEEtJHkpg6bL/Ow7z79GQE6xMClzGw+lTZp+aYTx+LlRSYrqMCJ/IgERIIANyR1lLkWmIlXKEwTkAFt0F3dEKldvjEKoylAKD2pj9Xh1gbauSg6RJKSC+7dHgZbGP2lWImmI+nj46G8HaG3KbpPJWRZlTiv6JEU0f4wlfT3c/RhD4qYbR49+KU5Ovqsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GpDqjkPG/pQ13Bw7NIUu0kQEsJZw+GVWtOrEYQxm8FI=; b=aVejMiFYLLAqV4xAGLBNQAhNrXHyf11Rl7J6yoL6jXptl5qgYzWJOBm1QNBrl5KB0bZGIVK71/8JHDGQ7Youl6i4Wn45axC+g+C+HAPkfXFsCXTYtx69PGEZqMIvvhDlfZM2zmVG60bf2OsitNNW80tJbI+8pxkIPZ5fzLRMpJqQ3pQYgvWtgi1BnyH/JLydMy4E0HonyM9NmPPyOJ1nPG4iwTTeNE5zBt8GYaz8WPQpBbf1ZMtsVU4SHRTV/1DFhdFjDYAfnKnlCc0QjKIWZWAoVZotOEqUezTbMeL1LpzYLvhmb5jyDCOJFEUxLEYEF9/D5qTMnUpkoOwmd6XSNg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GpDqjkPG/pQ13Bw7NIUu0kQEsJZw+GVWtOrEYQxm8FI=; b=VxWaeVLCCWwjSJAcLimlEXYIVMYmnfAUaP83ZVyEO6+yMe78+D3trYiJk4BfDiUlOaE5Md6MnyS94YOSWB8/c9POajSZgX71SKv+ZWy3++zywWwwYO+q/yXJbVcmMLrQYcsQ8aCVogGG/ErzTUzOfCKWutQR+zAMCxh7Eh15bDw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXqP/Lk3JZZv4HE42QpbkOnISoj1EwNhNaaMxF9bEoY6GHCTxFmeRirAuQ6kWKvJozQd0loV0gX9au12Bw4pxZV15tOjOIeQRCjv2l39oXLTxPDZz02i9Px0z6fcoJ+WlAEarvncqJjcBdukMtB/IPU7xIZWdRAcY955ajTWTLxl//64wthBTEd4wF773bv67PRXrP0j4C4yshcN291VyS+ceDGVjpKc6o8o4XOKpLqDDj9wKrjhgPNrZBDoso4pl43GZ+cv34yDhlnBVmXPhTFMWei6W8kLyYpL66F2pUkGp3syzIDs/Uh0QuAkY+dGNMOofEZ75Tb8PxTx9JRWgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GpDqjkPG/pQ13Bw7NIUu0kQEsJZw+GVWtOrEYQxm8FI=; b=BrABFfnLPgP3syTejSOtU9omUBC0FsMkj9D50GzZQ5wN0TC4722ltvQA4U3Mj1w5Y+PUFq+TsHf8Y4xtMb32xZMw9DrNf4iaio8F2ZPDvklrOoV9/di/KSIiYSYJq8jglatAU6ySBOHSAfk41znRE2h5/G8EP5Eq6j7uY4a/Oxh2czFf0CvlqQOtfchurqHbcca1iOyRGuucy+pxmoovSHJ/+OtYBWqgtNb7KirHoVhUpD/6gUVisdCOndvFDH3rTtBf9TZd65lS71iRl1Nj0SUlt3RLOm8S1BedztBRI5rslVJQaEn2/Exemh8ghUfO6xQqlLdXsNEdz3Wjl8YJdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GpDqjkPG/pQ13Bw7NIUu0kQEsJZw+GVWtOrEYQxm8FI=; b=VxWaeVLCCWwjSJAcLimlEXYIVMYmnfAUaP83ZVyEO6+yMe78+D3trYiJk4BfDiUlOaE5Md6MnyS94YOSWB8/c9POajSZgX71SKv+ZWy3++zywWwwYO+q/yXJbVcmMLrQYcsQ8aCVogGG/ErzTUzOfCKWutQR+zAMCxh7Eh15bDw= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Topic: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Index: AQHYwpULGFLWtgCBlkSkZYDaahDS7q3TxKQAgAAEM/CAAAPgAIAAAFfAgAAD+QCAAABFUA== Date: Wed, 7 Sep 2022 11:16:44 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-4-Henry.Wang@arm.com> <9234b0da-01c6-dafc-8e62-c7e497f8f146@xen.org> <28aa7040-af9e-eda7-ee04-60c71019e91c@xen.org> In-Reply-To: <28aa7040-af9e-eda7-ee04-60c71019e91c@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BDE42317FE0DA046B3592E99215BC163.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fc99be44-e846-4f15-f203-08da90c2771c x-ms-traffictypediagnostic: PR3PR08MB5801:EE_|VE1EUR03FT022:EE_|AS8PR08MB8039:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2jmD30Ovqq4bBzZ10pmKK8jR0EdxMFkbOmgRhbY+uKMKoz4AETa0pH7NrmG9zbV4x78ZIqyA8hjMZ4WnIxge1MIKNZ2Xok5RdKm+8/4GqYr1msiWv6nH4zI1y69Kl3BQ0n+3tRVhRnHNyvgo7NWq54jH/h1wo1QJOanUFss+TaeutVeJ6zQGsd5JMjIYKwqpnIvEoLQ3dU1Yy4pze7QfFpC5vcZg2zYBCaCbpAWvsRLUSSWxJRb3twlP9mV1RMMunmm8BKBg7AG7OCt4r3cfvewTnWSgizfxaxqGPmFU2Qn7H3oF/Q4TNxDwa2iKAW1JKUlp8fUxdAbZK1JSx1A1Na9n6yO8EA7ZqnS0xnihCjRfOHnYpObOeWRAxNWlyCI7Kt4BnBT31P/r4Th7cPcU/9O+Gpptbh0SPeYC0p4sUtrPZ22vcGgUdWwivCWHLYb0kdZwMqJphhjEhWUzH1IjrlYKBMEU7FgsWtvNzsAkV/iqT5lM+0xIb+d8JXwJ5IKX9+f29mhZE8OvIhvM3J9vj+C4qLkb3r+qMA9BRWTroesUFkf3Xb3ZPqJ+zNYBjG4aw3N+zq7AyaTJUsYb34Ma7Di4nc1qLku4L3mN2kodUQZZjbJRq4yLwLKAcQVTKCJMyhIHL1gYvdlg1qa+8QLEasehtdFHKQXrKmLH5bVBfYwkygIrWHYprFrrqImuHbkkJJwIsbirwID0EF2zcIhJB/GaRhm1vGdO3PdUg2nb+n3WeGXraBEXJrwwLWPELKahwrzf6hmb7ADpWYYe/IjNPw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(8936002)(52536014)(5660300002)(66556008)(41300700001)(66946007)(38100700002)(66476007)(55016003)(76116006)(64756008)(478600001)(8676002)(66446008)(4326008)(33656002)(83380400001)(38070700005)(186003)(4744005)(2906002)(26005)(9686003)(86362001)(7696005)(6506007)(54906003)(316002)(122000001)(110136005)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5801 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fc321389-1ba0-404e-e9af-08da90c2726b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s3hXxM3gx0VYXJGUt02C7ZY6RqjORFecArHjzCG7Ljnq3rS2JTIsiVMYcjkoMUumhMYBbT2eY4KkSJRTcz3sTEFBjPqvlFQfCTl1EGSaIUFJLznkeNJqIuf6CnF+6VFZmGCnSHnbEHo4p77issh6VMkR26K3Y8Z6I0dyfr7e6NH5ZgaFOXexPEd3sGlkMR26koV2ayh+5SyISEf6SDe9yUmDWO5wToq0axCl9PLv0BcKCC7d2ZE3ArFaLhlVDKXD53RIWhFz3WKGyBayWiLmsE6h8UttGP+6h9aQYjtrllNn5UJVapN9nr+eNhB7tvIhkgnIsniAq5xkSbXMmZGa5EieHcBjgFSegQ6GDsJGhOKhj4EHZTXfgkXNEGcZD2sC8EaAaia3nE2WdOAiP1hPQnWIOjm8UJVzyCc0+mlhwChSfCbFrEJTh+ZKFFRrxhvdWNLhtDoz0vmGSwiUArX0mqUqfH72/wly/Xs9v6d9MLjieeiKMQTxud4kfkX3MLPvBd0qux3I2ZQxXub8ZSlCv8cjLSG19JVkOmAtyPh1AHHnzyZRR1At+yKwSQo9B5nVwRMND6naW7pBbG7V3AnLp0bUk0rQfUOXIvAUTmidVoMgLn8oT05rG4fE+2LjOAHR99JIsEwb4eFeN+3XEywk2ToD15Gc4HWRdOY0kQaIrnXMiA2eUSobty6iSpVrbsQmSE3QpAoRvTPncRbGHm7jtZS+y1jv7rLf28IC+hFssvgWeS7J5uaexQ8wdIQO+d3Zqb9ITux2XSHd21Q6OWW18Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(36840700001)(40470700004)(46966006)(82310400005)(40480700001)(9686003)(41300700001)(4744005)(70586007)(70206006)(86362001)(52536014)(8936002)(40460700003)(55016003)(5660300002)(82740400003)(33656002)(356005)(316002)(54906003)(110136005)(8676002)(4326008)(81166007)(2906002)(36860700001)(47076005)(336012)(186003)(478600001)(26005)(6506007)(7696005)(107886003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:16:52.1537 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc99be44-e846-4f15-f203-08da90c2771c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8039 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gSG93IGFib3V0 DQo+ID4gLyoNCj4gPiAgICogRm9yIEFybTMyLCBzZXQgdXAgdGhlIHhlbmhlYXA6IHVwIHRvIDFH QiBvZiBjb250aWd1b3VzLA0KPiA+ICAgKiBhbHdheXMtbWFwcGVkIG1lbW9yeS4gQmFzZSBtdXN0 IGJlIDMyTUIgYWxpZ25lZCBhbmQgc2l6ZQ0KPiA+ICAgKiBhIG11bHRpcGxlIG9mIDMyTUIuDQo+ ID4gICAqIEZvciBBcm02NCwgc2V0IHVwIHRoZSBkaXJlY3RtYXAgYXJlYSBvZiBtZW1vcnkuDQo+ IA0KPiBPbmUgcmVtYXJrLiBJIHdvdWxkIHNheTogIm1hcCB0aGUgcmVnaW9uIGluIHRoZSBkaXJl Y3RtYXAgYXJlYSINCg0KTm8gcHJvYmxlbSA6KSkgVGhhbmtzIQ0KDQpLaW5kIHJlZ2FyZHMsDQpI ZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:19:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:19:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401342.643189 (Exim 4.92) (envelope-from ) id 1oVt5b-0005RD-4K; Wed, 07 Sep 2022 11:19:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401342.643189; Wed, 07 Sep 2022 11:19:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt5b-0005R6-1e; Wed, 07 Sep 2022 11:19:27 +0000 Received: by outflank-mailman (input) for mailman id 401342; Wed, 07 Sep 2022 11:19:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVsx3-0006sS-Lc for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:10:37 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b2f190e1-2e9d-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:10:36 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88FBD1042; Wed, 7 Sep 2022 04:10:42 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FF073F7B4; Wed, 7 Sep 2022 04:10:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2f190e1-2e9d-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: [PATCH v4 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev Date: Wed, 7 Sep 2022 12:09:49 +0100 Message-Id: <535d4f87b6632edfca76e0be6db371ab817b7f82.1662548825.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Reviewed-by: Oleksandr Tyshchenko Acked-by: Stefano Stabellini --- Changes in v4: - no changes Changes in v3: - no changes --- xen/arch/arm/include/asm/pci.h | 3 ++- xen/arch/arm/pci/pci-host-common.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 7c7449d64f..80a2431804 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -106,7 +106,8 @@ bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d, struct pci_host_bridge *bridge, uint64_t addr); struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus); -struct dt_device_node *pci_find_host_bridge_node(struct device *dev); +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev); int pci_get_host_bridge_segment(const struct dt_device_node *node, uint16_t *segment); diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index fd8c0f837a..89ef30028e 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -243,10 +243,10 @@ err_exit: /* * Get host bridge node given a device attached to it. */ -struct dt_device_node *pci_find_host_bridge_node(struct device *dev) +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev) { struct pci_host_bridge *bridge; - struct pci_dev *pdev = dev_to_pci(dev); bridge = pci_find_host_bridge(pdev->seg, pdev->bus); if ( unlikely(!bridge) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:23:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:23:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401351.643202 (Exim 4.92) (envelope-from ) id 1oVt96-0006rt-M7; Wed, 07 Sep 2022 11:23:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401351.643202; Wed, 07 Sep 2022 11:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt96-0006rl-HT; Wed, 07 Sep 2022 11:23:04 +0000 Received: by outflank-mailman (input) for mailman id 401351; Wed, 07 Sep 2022 11:23:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt95-0006qS-LB for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:23:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVt94-0003rR-E7; Wed, 07 Sep 2022 11:23:02 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVt94-0005Ur-6x; Wed, 07 Sep 2022 11:23:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yMaeCOuQqEnswGVCYMoa6kBWGy/c9kwqMVWaf82VIYg=; b=IpACjnDcUZtXTYCB8kEVq0MaE4 SlY8rDYV6Yzyd06huqwfUoHfZqUjHhY3Dv0sfYyXeXXKVxLF6D/PdXHRAoY0Hyxj6fA6wfDXj7HBb o+8qGLA1at/ywHpF/CURJc4IMhOHJPj76O2zVmXT5XQrs48Jgle72zOh8Sw3cksF2ydU=; Message-ID: <206db3d1-4609-fea6-9cb2-a56cc9d6f7ba@xen.org> Date: Wed, 7 Sep 2022 12:22:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 2/9] xen/arm: assign static shared memory to the default owner dom_io Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-3-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220906085941.944592-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/09/2022 09:59, Penny Zheng wrote: > +static int __init assign_shared_memory(struct domain *d, > + uint32_t addr_cells, uint32_t size_cells, > + paddr_t pbase, paddr_t psize) > +{ > + mfn_t smfn; > + > + dprintk(XENLOG_INFO, > + "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > + d, pbase, pbase + psize); > + > + smfn = acquire_shared_memory_bank(d, pbase, psize); > + if ( mfn_eq(smfn, INVALID_MFN) ) > + return -EINVAL; > + > + /* > + * DOMID_IO is auto-translated (i.e. it seems RAM 1:1). So we do not need Hmmm... I should have re-read my sentence before hitting sending. It should be "is not auto-translated" and s/seeems/sees/. Other than that: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:37:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:37:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401361.643216 (Exim 4.92) (envelope-from ) id 1oVtMX-00009N-1l; Wed, 07 Sep 2022 11:36:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401361.643216; Wed, 07 Sep 2022 11:36:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtMW-00009G-VQ; Wed, 07 Sep 2022 11:36:56 +0000 Received: by outflank-mailman (input) for mailman id 401361; Wed, 07 Sep 2022 11:36:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtMV-00009A-Pe for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:36:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtMV-00048q-JD; Wed, 07 Sep 2022 11:36:55 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVtMV-00060y-DL; Wed, 07 Sep 2022 11:36:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/h03+aiahr0YrQVLDXBr6Y1O8WKWsuYbAIlSGWjBBCs=; b=dCMQ4VkhbAB24Oskm/KVlKYrcC Yo0NkbnkhtShaHETAaktWtI28vKfLxKiiz8PnflIcydW0pPH1zFWsOccCXMqZw4rdTFntawI4Eksx F5IM2GcEdzSHqq8I+HGbUcJrMDBRfEcmT0zxzAxMCl+1gXetNFV87KW4+tp0GXuVpzmk=; Message-ID: <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> Date: Wed, 7 Sep 2022 12:36:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220907083643.20152-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, While reviewing the binding sent by Penny I noticed some inconsistency with the one you introduced. See below. On 07/09/2022 09:36, Henry Wang wrote: > +- xen,static-heap > + > + Property under the top-level "chosen" node. It specifies the address > + and size of Xen static heap memory. Note that at least a 64KB > + alignment is required. > + > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells > + > + Specify the number of cells used for the address and size of the > + "xen,static-heap" property under "chosen". > + > +Below is an example on how to specify the static heap in device tree: > + > + / { > + chosen { > + #xen,static-heap-address-cells = <0x2>; > + #xen,static-heap-size-cells = <0x2>; Your binding, is introduce #xen,static-heap-{address, size}-cells whereas Penny's one is using #{address, size}-cells even if the property is not "reg". I would like some consistency in the way we define bindings. Looking at the tree, we already seem to have introduced #xen-static-mem-address-cells. So maybe we should follow your approach? That said, I am wondering whether we should just use one set of property name. I am open to suggestion here. My only request is we are consistent (i.e. this doesn't depend on who wrote the bindings). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 11:49:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 11:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401368.643228 (Exim 4.92) (envelope-from ) id 1oVtYH-0001tF-53; Wed, 07 Sep 2022 11:49:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401368.643228; Wed, 07 Sep 2022 11:49:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtYH-0001t8-1m; Wed, 07 Sep 2022 11:49:05 +0000 Received: by outflank-mailman (input) for mailman id 401368; Wed, 07 Sep 2022 11:49:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtYF-0001t1-Nx for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 11:49:03 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130080.outbound.protection.outlook.com [40.107.13.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10c999c7-2ea3-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 13:49:01 +0200 (CEST) Received: from DB6PR07CA0174.eurprd07.prod.outlook.com (2603:10a6:6:43::28) by VE1PR08MB5616.eurprd08.prod.outlook.com (2603:10a6:800:1a1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 11:48:57 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::38) by DB6PR07CA0174.outlook.office365.com (2603:10a6:6:43::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 11:48:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 11:48:56 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 11:48:56 +0000 Received: from 023f98a3c79d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F440C40-6AC3-48DE-B9AE-1CA1F2D50C69.1; Wed, 07 Sep 2022 11:48:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 023f98a3c79d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 11:48:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB7993.eurprd08.prod.outlook.com (2603:10a6:10:3e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 11:48:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 11:48:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10c999c7-2ea3-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fR2Rork1E8YxqWg0Wc4rSvY9day9hlOuXckavs7ONyou3rk+8P3ajG+uVjNBAvgpac25rNSpL//uW+kw9OuvKxmoJjFdaU0UGxAy3QMWENRIb66D6m2x2pi72JugY5Fqd938FA9oL0HmK07StPTeXj7dbcUSKd3zKF/V/LLXimsKax+ZyFxKEtQWhPkaFrjfMJKpAQx7UaoR0vQRiMgI7mZ2xhIYgAcZYTOrA9FT94jpbmXzJKV1xoICEjtUAxOwWhROxEoDjDTu3gU3dzoFodTBQokLmKfblzhCH+v2WHUvGkfF603VT8tasY1r+fvtGVQ7lhB5LwCFUWRPpZJYBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KaLCuvJWI858oHkTBc7AFH9+Dd07svSAu0y6/r3rWgw=; b=irnqikn/g/fld/Z1MZpqLjevWXN3J1H1uYPG1JQT/V2B6hAIwWMiRwyCaXZhvWH/hNyxOiOTiA96iZ8tXG71JZJb4x/VSSBBsWIPtaBHHY+YPMJ74V1lmhYjpZKax7KeKWG63P910q01fyOdi0SQbg4KayZgEXdxqtUlfCR5FkjM0e7J1dbykjURtgfauJ32jWdw8sZZzGD+u4A9M6ao0l6Whrj2AKbaSFPYryWzpn1cjcibGOHhUCrYRomEIBJxgQ/N8iktsxaspBTO93qYIEU1jfLoM7oZWrbSJtJwH6gIOi2QyuDYdEQQzYs+nFF4lhiSux9imYEW5kctGc4LRg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KaLCuvJWI858oHkTBc7AFH9+Dd07svSAu0y6/r3rWgw=; b=smVKMrByR2kIH2Jpp/LC059aJr3F4jUCgym/yNlBU+WSsdy5Fqzw1+W/7Z2m5Li+zvtq82tvnL5TJ9Pxua5ZVuMybSRILusPAjmH7R7SV+mS6/wK+UoephU/yAjFSApT6fNcvHnq29XYp6xKvuS0rnwLVfvIjy7RWEfkYWA/UsA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khCvLgw6rc9fL9DeLpJ5C8NxAAB+eZ9m9mz/3HYLgec/wAVROKvkQHR+oXQeyM1ANU/Aq55lxdjK/s1Vjx9hoHTH/tqEZBBLW4l5qPeHAkibY6Edu0nQV+l5GSkxHV5wgvapkfaRPlV0d9uyStRE6lQdO5Sk+czA0NgnIlqnNwD7aeEUHmb2VBqTv9gHMHr6p6OWkk43M2o/1uygMkZnHVBzEqxTra1NPis54zKP5ZgGpzJSqhaXPp049epAjwsVOLH62Oq8N1NX7DR1Gl4y8g+5UWCODKxoDEVQ1Qufl/Aum1G5L+moXNHj7F2Yg0n2ShrSrYlwylHpERyXTTJBEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KaLCuvJWI858oHkTBc7AFH9+Dd07svSAu0y6/r3rWgw=; b=KnwkcqEHnMzVf+eqNL7HlynCrEErSyq3BR36lAnOdILIRXKUexn8yjr2oP/Wk8X47cydyCUx3LTHbHqh0jv73jSz6YSOjhVMkWFkypEjCy4PGlCngwljaS7UjXYkMkGU9zV5IXuEdJfo7xPlICVedYH7jtrxIk822TUMdFW4NPPLgp0j9f0BlV022we3IygYar9ar2X9oGtXYgdSr5ODE4f9FqZILb5MRGjzsmrLvzvXh7pGZDKaRJH+4sL/SKvagRb++WdwsRiIyorOpg4kAwsCeUI40jORqRoyfufop1AbFKmmXE3IAXEPlJ6mBwEtWxthMdTQcEJIeYxYYZGl/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KaLCuvJWI858oHkTBc7AFH9+Dd07svSAu0y6/r3rWgw=; b=smVKMrByR2kIH2Jpp/LC059aJr3F4jUCgym/yNlBU+WSsdy5Fqzw1+W/7Z2m5Li+zvtq82tvnL5TJ9Pxua5ZVuMybSRILusPAjmH7R7SV+mS6/wK+UoephU/yAjFSApT6fNcvHnq29XYp6xKvuS0rnwLVfvIjy7RWEfkYWA/UsA= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Penny Zheng CC: Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAABDrA= Date: Wed, 7 Sep 2022 11:48:44 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> In-Reply-To: <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EF49DF7F6D44F34FB4D7C327C96C1D92.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d6331017-c943-45c9-60dd-08da90c6f235 x-ms-traffictypediagnostic: DU0PR08MB7993:EE_|DBAEUR03FT022:EE_|VE1PR08MB5616:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: m4tlnTyLXtDn/hWKsWCLfL9ENRS2BDvmM2PQGM7SzdEqsXhnhis6ktnq9gPfHgLAlJb+wklcNLIHnENMChsVq20lEe1o0P1kRFwfTlrZNOQW8+6TG9un1mlw/4hSaJRdtVF6LMPCLbeKYK9o1yB8fdpA0bsPmaXvXXpkiaYjonVDEVKXBzJOj315qJNY2i2WyqdD6tLiwu3mKi0j85+dLDkcdMuMlJGrPwhd4Sq0FLI4hnll1DHSbHlZKw7vLjQ9jukBNtvKGj+SxaN8SHugxc7Cy2uiVp1qfSGRKACsRiOKOUPmPbRO4zXsppbLC29gubZBFb8ntnugtJl8+CHiCnRkYhZ2DAuniL2MUZv/gR4vyhqUgpcnSH7J5hYuXTF9YAAdExjMKWbf4WO9OlYQGbBi/N5mqhXGankF8uqND9AiMMpiP6xhpEUNbQl2LBtebgMOA6rWWtcT/ZRcZOpvDPh6E0qMChhKflqY8Sw4FT8HWqxabPmwMuEa5ofaAoxOk1TIxXrvzJXTKGwIDx87NnL4SGTVMre3Qi652nnJJ0Rat6QkpYs5zOX+lL38CuOCvkVq8zN5th7b5G+CWbLsckyG31lXEeuexFZiaVCNsQGb6jhyD1RFfj2V0e7Fie27NHz168D1tIw447/0jwttbOyQSwecYNxnOw8xGdllEThuYs/dSZ2s/iva6gZZ8byA+MuP6o22zrUoMAa8agrPb+WYzTTg+f4z4v6tOG4yxXH8922rkT/UPxHF3EcWp23aKlnT+1RauFUQOoCbuMRwAQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(396003)(366004)(5660300002)(8936002)(41300700001)(33656002)(26005)(9686003)(53546011)(2906002)(52536014)(86362001)(6506007)(7696005)(55016003)(38100700002)(122000001)(38070700005)(186003)(83380400001)(8676002)(4326008)(54906003)(110136005)(66556008)(478600001)(76116006)(66476007)(66946007)(66446008)(71200400001)(316002)(64756008)(6636002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7993 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cbd30227-99fa-4c03-60a0-08da90c6eac1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FB13rK196lEuV1BcvwU/JUcsShxC5DUSy2m9ezMsAvG65ghZEBNrvsyrz0li3ygsja2XUWurdBxhKKQWYBcHbI7uJtk6BHtZe8KNuvl4YKo5N1PWYvt5hupk7OTwJ/zHsF9k5bvCtEUsslW9gfQcX6h78oTIsnuOP/Oln/4i1Q5U4wncsoQr0x9Q89z836hLSw+YOyvfkngYNv2KY54Zu3kEajhChNJMAHKTj16d2oHUT+9go3hUw1OdZAcsXv+FkPWAIO3xpXm+YDM0hqKVBqemKx9TNJ49IDD7MFWpDy5vrVTC11p3jpbBkKg66LvtLzdlHJf9FujJAqK7T3qV1P16nAeKiBAwHRsUoIizWQkCdV8p7WnY97AjxYj/6EmslsQT9j2m9l9Dm1tBL6LkuGlZNGXIZ/xSdTNs6PBnNXUj2qh0alZ5t77KSYPJtvV2WnrkcnnnMPUYDMtd4w248tuD3fyuc8WPgUqHZRdt559TrSZOm1qbezQXu78pW5gmKQBhf9jF67VXi+Q5wZ8v8V8VCAaoK4az4ZSyBaijy+LauDk2pLypxQUMsYQDuwlbXJovHU5z/K8/e3PPGYd25m4wIdX8V2otroQaAoH8aL4asr/NIgjrWrcaVrKOY3vMAQ+HqjSVpjg5R59wj055aHq3wmBCN17H9AxI/imvZA21F4H7KWEYj4SNze88638YRRVchdEX94rQvi/+Vj4FJXassNEoi9LAobKkmsQt3uqmsRchkSBmRQBP5DkOXwIrBHrebi6qrHQJZkkNlYes6Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(316002)(36860700001)(5660300002)(83380400001)(110136005)(4326008)(54906003)(8676002)(52536014)(6636002)(70206006)(8936002)(70586007)(2906002)(33656002)(55016003)(82310400005)(26005)(41300700001)(9686003)(478600001)(40480700001)(86362001)(82740400003)(336012)(186003)(107886003)(81166007)(356005)(53546011)(6506007)(40460700003)(47076005)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:48:56.7699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6331017-c943-45c9-60dd-08da90c6f235 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5616 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMi80XSBk b2NzLCB4ZW4vYXJtOiBJbnRyb2R1Y2Ugc3RhdGljIGhlYXAgbWVtb3J5DQo+IA0KPiBIaSBIZW5y eSwNCj4gDQo+IFdoaWxlIHJldmlld2luZyB0aGUgYmluZGluZyBzZW50IGJ5IFBlbm55IEkgbm90 aWNlZCBzb21lIGluY29uc2lzdGVuY3kNCj4gd2l0aCB0aGUgb25lIHlvdSBpbnRyb2R1Y2VkLiBT ZWUgYmVsb3cuDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDA5OjM2LCBIZW5yeSBXYW5nIHdyb3RlOg0K PiA+ICstIHhlbixzdGF0aWMtaGVhcA0KPiA+ICsNCj4gPiArICAgIFByb3BlcnR5IHVuZGVyIHRo ZSB0b3AtbGV2ZWwgImNob3NlbiIgbm9kZS4gSXQgc3BlY2lmaWVzIHRoZSBhZGRyZXNzDQo+ID4g KyAgICBhbmQgc2l6ZSBvZiBYZW4gc3RhdGljIGhlYXAgbWVtb3J5LiBOb3RlIHRoYXQgYXQgbGVh c3QgYSA2NEtCDQo+ID4gKyAgICBhbGlnbm1lbnQgaXMgcmVxdWlyZWQuDQo+ID4gKw0KPiA+ICst ICN4ZW4sc3RhdGljLWhlYXAtYWRkcmVzcy1jZWxscyBhbmQgI3hlbixzdGF0aWMtaGVhcC1zaXpl LWNlbGxzDQo+ID4gKw0KPiA+ICsgICAgU3BlY2lmeSB0aGUgbnVtYmVyIG9mIGNlbGxzIHVzZWQg Zm9yIHRoZSBhZGRyZXNzIGFuZCBzaXplIG9mIHRoZQ0KPiA+ICsgICAgInhlbixzdGF0aWMtaGVh cCIgcHJvcGVydHkgdW5kZXIgImNob3NlbiIuDQo+ID4gKw0KPiA+ICtCZWxvdyBpcyBhbiBleGFt cGxlIG9uIGhvdyB0byBzcGVjaWZ5IHRoZSBzdGF0aWMgaGVhcCBpbiBkZXZpY2UgdHJlZToNCj4g PiArDQo+ID4gKyAgICAvIHsNCj4gPiArICAgICAgICBjaG9zZW4gew0KPiA+ICsgICAgICAgICAg ICAjeGVuLHN0YXRpYy1oZWFwLWFkZHJlc3MtY2VsbHMgPSA8MHgyPjsNCj4gPiArICAgICAgICAg ICAgI3hlbixzdGF0aWMtaGVhcC1zaXplLWNlbGxzID0gPDB4Mj47DQo+IA0KPiBZb3VyIGJpbmRp bmcsIGlzIGludHJvZHVjZSAjeGVuLHN0YXRpYy1oZWFwLXthZGRyZXNzLCBzaXplfS1jZWxscw0K PiB3aGVyZWFzIFBlbm55J3Mgb25lIGlzIHVzaW5nICN7YWRkcmVzcywgc2l6ZX0tY2VsbHMgZXZl biBpZiB0aGUgcHJvcGVydHkNCj4gaXMgbm90ICJyZWciLg0KPiANCj4gSSB3b3VsZCBsaWtlIHNv bWUgY29uc2lzdGVuY3kgaW4gdGhlIHdheSB3ZSBkZWZpbmUgYmluZGluZ3MuIExvb2tpbmcgYXQN Cj4gdGhlIHRyZWUsIHdlIGFscmVhZHkgc2VlbSB0byBoYXZlIGludHJvZHVjZWQNCj4gI3hlbi1z dGF0aWMtbWVtLWFkZHJlc3MtY2VsbHMuIFNvIG1heWJlIHdlIHNob3VsZCBmb2xsb3cgeW91ciBh cHByb2FjaD8NCj4gDQo+IFRoYXQgc2FpZCwgSSBhbSB3b25kZXJpbmcgd2hldGhlciB3ZSBzaG91 bGQganVzdCB1c2Ugb25lIHNldCBvZiBwcm9wZXJ0eQ0KPiBuYW1lLg0KDQpJTU8gbm93IHdlIGhh dmUgdGhlIHBhaXINCiN4ZW4sc3RhdGljLWhlYXAte2FkZHJlc3MsIHNpemV9LWNlbGxzIGFuZCB4 ZW4sc3RhdGljLWhlYXAgZm9yIHN0YXRpYyBoZWFwLg0KYW5kIHRoZSBwYWlyDQojeGVuLHN0YXRp Yy1tZW0te2FkZHJlc3MsIHNpemV9LWNlbGxzIGFuZCB4ZW4sc3RhdGljLW1lbSBmb3Igc3RhdGlj DQptZW1vcnkgYWxsb2NhdGlvbiBmb3IgZG9tMGxlc3MuDQoNClNvIGF0IGxlYXN0IHRoZXNlIHR3 byBhcmUgY29uc2lzdGVudC4NCg0KSSBndWVzcyB0aGUgY29uY2VybiB5b3UgcmFpc2VkIGlzIHJl bGF0ZWQgdG8gdGhlIHN0YXRpYyBzaGFyZWQgbWVtb3J5IGZvcg0KZG9tMGxlc3MsDQouLi4NCg0K PiANCj4gSSBhbSBvcGVuIHRvIHN1Z2dlc3Rpb24gaGVyZS4gTXkgb25seSByZXF1ZXN0IGlzIHdl IGFyZSBjb25zaXN0ZW50IChpLmUuDQo+IHRoaXMgZG9lc24ndCBkZXBlbmQgb24gd2hvIHdyb3Rl IHRoZSBiaW5kaW5ncykuDQoNCkkgYW0gbm90IHN1cmUgaWYgUGVubnkgYW5kIFN0ZWZhbm8gaGF2 ZSBzb21lIHNwZWNpZmljIHJlcXVpcmVtZW50cw0KcmVnYXJkaW5nIHRoZSBzdGF0aWMgc2hhcmVk IG1lbW9yeSB1c2FnZS4gU28gSSB3aWxsIHdhaXQgZm9yIFN0ZWZhbm8ncyBpbnB1dC4NCkJ1dCB5 ZWFoIHdlIG5lZWQgdG8ga2VlcCB0aGUgY29uc2lzdGVuY3kgc28gaWYgd2UgYXJlIGFncmVlZCB0 aGF0IEkgbmVlZCB0bw0KY2hhbmdlIHRoZSBiaW5kaW5nLCBJIHdpbGwgZG8gdGhlIGNvcnJlc3Bv bmRpbmcgY2hhbmdlLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+ IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:02:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:02:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401418.643257 (Exim 4.92) (envelope-from ) id 1oVtkl-0005WH-2s; Wed, 07 Sep 2022 12:01:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401418.643257; Wed, 07 Sep 2022 12:01:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtkl-0005WA-01; Wed, 07 Sep 2022 12:01:59 +0000 Received: by outflank-mailman (input) for mailman id 401418; Wed, 07 Sep 2022 12:01:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtkj-0005Vt-CO for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:01:57 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00055.outbound.protection.outlook.com [40.107.0.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de7f5e75-2ea4-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:01:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8669.eurprd04.prod.outlook.com (2603:10a6:102:21c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 12:01:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 12:01:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de7f5e75-2ea4-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VMBNuQ89BjWI1BflvYJH+KxZZgJfxB7F+TmT9FTV+yVD5Unnc/HB6nvooyR+oQMbwqNecL9Ts7LI7Mlwcp2YKpbpkz2XWCOaktUZsKe41gmb+VHpxcwrPuJfLfGY9vDlqEFeIsd0VoXgBqNoI6KuWu6ekDXPcgJC+egXSQXJSgAbhuceoa4J/lFMolCMxSzGaLAIIYBbblrJx9uwBi4WLALvg6dWikvaEkplq2lP1xBDCvdetlPne2C6JRJUcHEZd6dJisPerMnxks3mTfM3o5fafqrTct2AcqyazAesRGVmrCjfmsqBXZgcyNSAzHRofC7pKOpCMKxZAdqr7FOf1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tl+fOY4e71cwi/TlwNboldX6wLZzZrpFC6vc8fQGmRk=; b=CIl/oQp0z0XZf8t1xcXLOuYpEP7NK9ffKeWP+iZ/GNdJRST8/YiIeZ1y38Wud2ZptgfrqGlyLDwFa6I/9WZEz7KkxnNzAIM3ziaW8cSo9CZW4O4ViB2nNT+/VVJMjcARKJgDbknpdcVO8P0IIsROOkyfV505O5e2DhFP60gaGbwV4HWq6eehSXsM15dsVgCJ96prdW1+B+ulXOxr9K46ckwxiny2fgjj1DDdLfc3ymQREx92O7VvuqkqRIUqPxL2OW3aamkrhds354kUiUq6hDrroRKuZqU93yGu4GIJjY8Hhua2uHmQbqu3/THLIk7qYCuGDAKa2L9JqbVU3yM0/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tl+fOY4e71cwi/TlwNboldX6wLZzZrpFC6vc8fQGmRk=; b=BXh2zfYJiCe68CwuqxTnXYPmD1laNW/ARkhJnDekZ/VHmDoDlR+soqEkFaxr7VdP6lPyYWkMzGjoI8G3AB7pklOrcFUUWcZ0OEVPYkcE4ON2NSYJ1zQRwVVRt6RgKzqwQwwhEuTEID0b6SgFIMRzYBOzhiBNVmedoJIxhwLNL/GgMzkW3rPFsI/OYEeh16kpNqjmfy9Q7BBa6hI0ucY6IEzgB0JrAdqYOx+rJ1uBAbBSpS4zg1Qak6FPnxJ3GbWfKudEPZY3gDBkRCuVChzMh80bXP+/Oy0R4RZQwsRPL55emHGYS+LWw8Xyc0x/wUv38JqrJrz4xPP4jBP4kXjkyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 7 Sep 2022 14:01:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Julien Grall Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Rahul Singh , Stefano Stabellini References: <5948f099-7287-2743-aa24-3c7a17033877@xen.org> <4ac67001-9406-6cac-b032-b6cbefb598b5@suse.com> <4f070d84-a732-3166-ad6c-2c15e6cfc882@xen.org> From: Jan Beulich In-Reply-To: <4f070d84-a732-3166-ad6c-2c15e6cfc882@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8669:EE_ X-MS-Office365-Filtering-Correlation-Id: f6befce7-15cf-4960-2c47-08da90c8c1b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oGTGugEoO86KMYFdAOxzgHjcO4WYNcgfk+y1uc+Fp1yGFC+e20oa/MlEPedz3K5NkHUBaM5pOj/TIjZUqgf3z39tTFekwOsd3c4LWggVHbPQKzKxcLXfGrUOpFqpjZaLrL5LVdLcSxEARM1xuCp3Ar3bb2RA23KXKRI41/GI5NYD27ZO63UcpTkKuStIWkaZ9C3IZIUj6ZDNgJtv9DMZAORe/HKojSxLB6UpSo3/pt1/+KIgNz2/GiB0vnugrqa6AF9NqtJ/aDZucjKXtfJvaxtvDSuuya8iiZR/8FiIad+pAa5+sR6vN+iYDALn3P4avxzDVo1SpIS5VTGJaWHQSACSO0j21B/gY4kqgCGrJXfjanjB65IIrY1DO4TJBYH2KVXyTeUZM9Xtccj6yjYDrTSDb3IAsgHaplm1YntXX/gvbN/gsVDYNuPEDN/TAPqkYeVzt54JT8rPzuxd9RusLJYpOApP8LJQym+3AKPNxQsPvhDbo1o6rXt2SBfSZkLgeGvuPli/rVCH6Ifc7Q3Y8y4CsuLVs7BdYv0iaD+b44w+f2sVDyRe6n44zXDTGys3mSbv1KeOggpLi1a+xW+gcznUsxzExNIwj6CymjGO5J1uBDLISt9E+bsG/gED9l8Ka13dtirKYqqy2oJo/LL0A7lbyDW0KmgZ7qYm+bdShbFOaAdMYyMDFdmw1nbZLvXrK87h81UhyA9b+J4lgf8kuKzRb69Cd9PWNiDJcMj57RSFWWo8JEM+avgjndsAUHlUmK5sbp9zp3kyWMwVEz0qHXJO50TolnwXSoJo3Od3WpY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(396003)(39860400002)(346002)(4326008)(38100700002)(66556008)(8676002)(316002)(66946007)(66476007)(6916009)(54906003)(2906002)(5660300002)(7416002)(2616005)(8936002)(186003)(83380400001)(6486002)(478600001)(53546011)(6512007)(41300700001)(26005)(6506007)(31686004)(36756003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vy96MkN5SkNkdTczc2hjbm4zL245VFJTVDZvZTdHOWo4NEhzSGcyVWlSSWlO?= =?utf-8?B?aDVYejl5c3I2QTlkdWdTWXdWa3BPUVZsUjlVYTV6Tjk5VUxRS20yVUtCR3hC?= =?utf-8?B?eHhtY2VCMG13b2pTdFJBMFdvb2tJNmhYaUYxdDhTR2xzakZIeEdDbjlMYlFZ?= =?utf-8?B?MnRYN1d0OWE1Y3IyYk43aE5EQ0tKdEtBT0dFTTVDSzZMd0R2RHJQUFpjSFlL?= =?utf-8?B?S1JpRTZ1ZU80NUFINnAvUnVIVk04Uk5ZVEorTmt5cXRLOU1qV01LVDJrK29h?= =?utf-8?B?RVhwdG9uM09sTXUwOFpidmlWSnV4b0FpbWM4eGIzWnFucjE1RXA4b2dVQjU4?= =?utf-8?B?RG5WaG41SzNUbjdjTjk2TzM1SHJtUzJtK3B3ek81Vm9TKzd1RHpJVlQ1Yko5?= =?utf-8?B?U3lYVXltV1lrNUpBcE5aaG9yV2UrVElPSUJXVjdmaTFUcXVqVGIvNUIzN3lJ?= =?utf-8?B?ZzhxMjF2eW9LSjhOQTFXQ3pyYjBTMnk0aWxyVCtFckludlVSSHozcFNaUWpp?= =?utf-8?B?YmxVOGpjUkxKMHZZbXJLeVU2aFZMRFdlczRDTUFVMFNDQkdUTTg3MW1vS0xm?= =?utf-8?B?NTUzOVZLNENpOHJEc1FUS3hXUUVRN3dJNEkydUY0ZU1iNHMyd2toS05JTnBq?= =?utf-8?B?UkhJM2VXalpWcFBvdHl5OXdGZStVRHh2WktVWXQvUG80Si9DMy84RmhWTzhU?= =?utf-8?B?TkpNUE5NMDRjajdKRng2Zkd1a0NNM1c3TW5mdjBwUnp2S2ZwYi9tZ2U5ckUw?= =?utf-8?B?b2FJS28wRWlUeEtydDhLckd6QTNIMDdJM2UyVW9tQ0lWSmNkbjJPMElyR2xB?= =?utf-8?B?cjhuWHQ5N05iaitDc0E0djJTOXhmYVRvT1J6S0V0clhzTXZUN2IvRm9MVHpq?= =?utf-8?B?SWJZcVo5c2xya3ptWnF2ZXRSbTkvWTU2SWVneDNhZy9XWCtLMytNU0MxNmJv?= =?utf-8?B?R25KVk5HT3haTUYwZG1HbnY5RUNXL2o1ZUlDUG1YREd6cmpQZnByckhoZklI?= =?utf-8?B?eUN0ZTVENmRFWStIQ3RQMmxMallNV0k3dW52WGp0OGxYTUgyVEhFaTVEWjRv?= =?utf-8?B?c3Z3TzNiU1JhK1gzOGUwaHZnbnlIMmlsaWNmN0d5bE9WSzVQblFlRGVLd3BF?= =?utf-8?B?VnhRN29BREx2azdKN1pMSjBTWUhpSWloK3pFUUFaalFPRnRJalhLZG5oL1hl?= =?utf-8?B?K0hTaWQxQldCUUJ2UlBodTJ5MVk3aVgyZGhZQkVjNmVCMzc0WkZteEo4MCtn?= =?utf-8?B?bHVjeXdXWEJoSW0ySWpTYmIzYjg2clhWM2YxZDkvdHZRSG8zbkk3dVpmbm5O?= =?utf-8?B?MVp3UjNZdHdUM3puNXNBZ1BTTEVuMmZxWVVKWmdvUkJVMTZxN2VvUnF5SDlL?= =?utf-8?B?cHBnSk5MdCttOTRmSUk0bExOMDBVMFVsalpwcWQxL0NtMjFvNW52RzMxWGtZ?= =?utf-8?B?QXhJSmJzQlNGeXYwdHRaYzB3OVE4bFc3NjVLVjhzaU12TDQ0Q2tPL3ZSaTFW?= =?utf-8?B?M3N3Zk1HZ3dBY0EzTDdwdjVMbHF5YkhYd01KQVFZVGJRSU5vZndlOGZlY011?= =?utf-8?B?OEJVZXZQa3Jld2hLcHRUOGhKeWdQMWVmRzRWaVZId1N2VHQ1ODNzNm4zdWxY?= =?utf-8?B?eG1XZ2pjNk9iajZva1dCeFhaUm9tZUUzVFZoUDl6dXlZckJjODJYdEZUM1Fo?= =?utf-8?B?aTlteTNES01ML0lUTm91YUxWRjEwV3Z1b3hubFpDWnlQaDlQcW5kWC9CeldU?= =?utf-8?B?QnFiK3pjVlQrQUdFU2NvZmZMS295ZHFRa0V6WjVPZjF1Z0wzRnJOR0o5dVli?= =?utf-8?B?cjBqS3BVcW9NbEt4U1VLT2hWQW9VV1FqbW5pMHZpRlBRRlFObnVndVJVWU5S?= =?utf-8?B?ZHFJQndYV3JDNkdnSWh6NDFyZjhLZXd2SXdPMloxSFJWYnBTTnJUTk5ZL3RE?= =?utf-8?B?NXdMRVRkUks5UzBNQnF1dStnN1dIekRuZXFKODFRdmhOMlRrUUlaNGoxZnp3?= =?utf-8?B?bTZYSUVRTGpTZzhYU3VjOXd4cEJFLzJWQU1OdXBxMVhRbmxIcjdUTEFkVUZL?= =?utf-8?B?eHgvbWR4dkFGL25JRlNWUjdya1FqazFkNEZOdXhhZ0NPSTRpdE9DdlcxVzZl?= =?utf-8?Q?9LzKsbWqwMiiOSPlT11sEYc2g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6befce7-15cf-4960-2c47-08da90c8c1b0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:01:54.5159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hCZtqHhQgCYwb9OlxUCBzynfylpCyWJJFStBurRmANNOjdNlsXJAcL5y76FozXl+sRF25LF1YLHWisTW3I0ivw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8669 On 07.09.2022 12:00, Julien Grall wrote: > On 07/09/2022 10:07, Jan Beulich wrote: >> On 07.09.2022 10:58, Julien Grall wrote: >>> On 06/09/2022 09:53, Jan Beulich wrote: >>>> On 03.09.2022 02:24, Stefano Stabellini wrote: >>>>> On Thu, 1 Sep 2022, Rahul Singh wrote: >>>>>> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >>>>>> return 0; >>>>>> } >>>>>> >>>>>> +static int is_bar_valid(const struct dt_device_node *dev, >>>>>> + uint64_t addr, uint64_t len, void *data) >>>>>> +{ >>>>>> + struct pdev_bar *bar_data = data; >>>>>> + unsigned long s = mfn_x(bar_data->start); >>>>>> + unsigned long e = mfn_x(bar_data->end); >>>>>> + >>>>>> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >>>>>> + bar_data->is_valid = true; >>>>> >>>>> >>>>> This patch looks good and you addressed all Jan's comment well. Before I >>>>> ack it, one question. >>>>> >>>>> I know that you made this change to address Jan's comment but using >>>>> PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= >>>>> PFN_UP(addr + len - 1)) check means that we are relaxing the >>>>> requirements, aren't we? >>>>> >>>>> I know that this discussion is a bit pointless because addr and len should >>>>> always be page aligned, and if they weren't it would be a mistake. >>> >>> Hmmm.... Is that requirement written down somewhere? >> >> What do you mean here? Isn't it quite obvious that every byte in the >> address space may only be used for a single purpose? I.e. if a byte >> is covered by a BAR, it cannot also be covered by a RAM region or >> yet something else (e.g. MMIO beyond BARs of PCI devices). What >> happens if BAR and RAM indeed overlap depends on fabric and chipset, >> but it'll either result in chaos if two parties respond to a single >> request on the bus, or it'll be (hopefully) deterministic (for any >> individual system) which of the two takes "precedence". > > I am well aware about that and I am not sure how you implied this is > what I was referring to from what I wrote (in particular if you read the > next sentence). > > Stefano wrote that it would be a mistake if the address/length is not > page-aligned. However, I am not aware from such requirement written > down. It seems to be more an expected common sense that was IIRC not > always respected on HW supporting multiple page-granularity. I guess the question was then solely directed at Stefano? I have no idea, after all, what guarantees there are for addr and len, which presumably originate from DT somewhere. Yet if there aren't any guarantees, then aligning the incoming range may be necessary: BARs can be sub-page size (even more so when considering page sizes above 4k), and so a not-really-overlap (at byte granularity) could still be an issue if there's an overlap at 4k or system page size granularity. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:04:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401431.643267 (Exim 4.92) (envelope-from ) id 1oVtnF-0006CP-GD; Wed, 07 Sep 2022 12:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401431.643267; Wed, 07 Sep 2022 12:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtnF-0006CI-DU; Wed, 07 Sep 2022 12:04:33 +0000 Received: by outflank-mailman (input) for mailman id 401431; Wed, 07 Sep 2022 12:04:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtnD-0006CC-8J for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:04:31 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 389363e0-2ea5-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 14:04:28 +0200 (CEST) Received: by mail-pj1-x102e.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso18039197pjh.5 for ; Wed, 07 Sep 2022 05:04:29 -0700 (PDT) Received: from leoy-yangtze.lan (45.78.11.189.16clouds.com. [45.78.11.189]) by smtp.gmail.com with ESMTPSA id cp14-20020a170902e78e00b0016db6bd77f4sm11941368plb.117.2022.09.07.05.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 05:04:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 389363e0-2ea5-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=CVS4g1G5f5Acs5BUOcyD8RXh3Tkktm3N5arKG4wCzP0=; b=vWxULQZGwptRpSi7xB4xcNa/YRPrBT/3cWlXzL1nHwmU3OLNSgKZQiKqAjcH6FAdEZ mNDbCnvFxnsP49Dv+Y9WlXGhlOFD+vQB0FSJAWVYY0t2eQzL8+C39f8zCwT4qlVmhbkb o7vpRKwTskftWxonh01V0KdHKVcBOGi75i4yzjkNfjm3PEigvHNNV+t0Oe1heDDSRkXL M0xQX/VCa/VeeS6VuUzKurvYH3pO0JBCmkCBtoXkM90UqDnrsZGVsaRZgWM1TB9yu5yr r6X8QZN8rTQ3s/NdOIQbM1coAoWDz2VjYID3rCqFEwdoGvcidsOrHe/h8lN+nmF7Bd7l SKPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=CVS4g1G5f5Acs5BUOcyD8RXh3Tkktm3N5arKG4wCzP0=; b=n7yY6zGzTAeUiEHjoZNoMqSPICSo3EqTDyBAn9DJplPnRjd7S4kqv4Lko9hZyfElzx 9Vz33XixeNlvQa1g7fm3aihLC9orF78BVdp+63hVfBYWw6gHjR8KyLxr0O2upuq9/+Wx TOWzGnekTSLv2lscKWUCEwGRrFjC5uY7y7T9+VMdOw8b72dAhm+oQ0Ys6Hn7XkJAypvv 3tC8oaH3x+p5Kw8RTX/0dFkyD8UeWwxhq6HoT6bFLrVFJJEXU/rrVGFWkztwfaAUg8PC d4tHD4+6LmcTXHGBO67fIoN3WGct6dd9BMTey/UnKfkG2qwKZapGfxxWx+k1fHLgO6e+ fq+g== X-Gm-Message-State: ACgBeo3y8uIdK9pGTMpfiROV6qd17A34YRaRuZSh/ZcOAjsDQxpgOZjE RfFFsN/bOGlZRvQoHJMzHIYxJg== X-Google-Smtp-Source: AA6agR4Gbp+DTfeQFU6CA9blRyoaQKNs4aO0Qk/dQVHQn9ksmxxxX6Ybr2zHuP4rTZ4IrU2C78Bryw== X-Received: by 2002:a17:90b:38d2:b0:1fe:30c1:9384 with SMTP id nn18-20020a17090b38d200b001fe30c19384mr3703765pjb.109.1662552267418; Wed, 07 Sep 2022 05:04:27 -0700 (PDT) From: Leo Yan To: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , xen-devel@lists.xenproject.org Cc: Leo Yan Subject: [PATCH] xen: Add macro for version number string Date: Wed, 7 Sep 2022 20:04:20 +0800 Message-Id: <20220907120420.387771-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Arm64 Linux kernel prints log for Xen version number: Xen XEN_VERSION.XEN_SUBVERSION support found The header file "xen/compile.h" is missed so that XEN_VERSION and XEN_SUBVERSION are not defined, __stringify() wrongly converts them as strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". This patch introduces a string macro XEN_VERSION_STRING, we can directly use it as version number string, as a result it drops to use of __stringify() to make the code more readable. The change has been tested on Ampere AVA Arm64 platform. Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") Suggested-by: Bertrand Marquis Signed-off-by: Leo Yan --- xen/arch/arm/acpi/domain_build.c | 3 ++- xen/arch/arm/domain_build.c | 2 +- xen/common/efi/boot.c | 4 ++-- xen/include/xen/compile.h.in | 1 + 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c index bbdc90f92c..b23c7cad7a 100644 --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -9,6 +9,7 @@ * GNU General Public License for more details. */ +#include #include #include #include @@ -91,7 +92,7 @@ static int __init acpi_make_hypervisor_node(const struct kernel_info *kinfo, struct membank tbl_add[]) { const char compat[] = - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" + "xen,xen-"XEN_VERSION_STRING"\0" "xen,xen"; int res; /* Convenience alias */ diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..62602d2b86 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1367,7 +1367,7 @@ static int __init make_hypervisor_node(struct domain *d, int addrcells, int sizecells) { const char compat[] = - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" + "xen,xen-"XEN_VERSION_STRING"\0" "xen,xen"; __be32 *reg, *cells; gic_interrupt_t intr; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a5b2d6ddb8..db0340c8e2 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1341,8 +1341,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) efi_console_set_mode(); } - PrintStr(L"Xen " __stringify(XEN_VERSION) "." __stringify(XEN_SUBVERSION) - XEN_EXTRAVERSION " (c/s " XEN_CHANGESET ") EFI loader\r\n"); + PrintStr(L"Xen " XEN_VERSION_STRING XEN_EXTRAVERSION + " (c/s " XEN_CHANGESET ") EFI loader\r\n"); efi_arch_relocate_image(0); diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in index 440ecb25c1..3151d1e7d1 100644 --- a/xen/include/xen/compile.h.in +++ b/xen/include/xen/compile.h.in @@ -7,6 +7,7 @@ #define XEN_VERSION @@version@@ #define XEN_SUBVERSION @@subversion@@ +#define XEN_VERSION_STRING "@@version@@.@@subversion@@" #define XEN_EXTRAVERSION "@@extraversion@@" #define XEN_CHANGESET "@@changeset@@" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:06:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401439.643279 (Exim 4.92) (envelope-from ) id 1oVtp5-0006mt-Sc; Wed, 07 Sep 2022 12:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401439.643279; Wed, 07 Sep 2022 12:06:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtp5-0006mm-Pi; Wed, 07 Sep 2022 12:06:27 +0000 Received: by outflank-mailman (input) for mailman id 401439; Wed, 07 Sep 2022 12:06:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtp4-0006md-Ng for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:06:26 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f003472-2ea5-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:06:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6728.eurprd04.prod.outlook.com (2603:10a6:20b:f7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 12:06:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 12:06:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f003472-2ea5-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jz5dgdf855gE6vymuqMeMpA/zE/ZWCR4ib44NK+ukyOPHW2ZATsJADqYh3AO+Q6zSCoCVWaqGezPRPY9tvn5Jo+kqN0T6sD0GgjPJGdzlrC/juAOm9m3YuMcBlN8j822ljtKcuWb5zgu6L6bsOIDnjD3g0H3/1wjraqie7t7pJglkFEKzzvBiHeWL/wXSpoIGJPnaD+FNmOvF0mx6gQYdsiRPmlLWlQeiYJmNSZXgWnwCqNjSFdsCz7JjhwcXWY4SLRhMwjF4dmDfuezD2xhm6A/RGvAC8ynJJHF2lnuzHDOyPp51Zm0wa2VvstOlKq1P9T1InKCvXTlnvXxF3ycXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CiFKFLhAOtg2fQoQXjIEOUXAKLH0r3SrJjrjsvl4+Fs=; b=CYAWzlABxqHXUdjvG3sWAtevStOVOO3G3sBnN+pjHCZyqKVQA2dWOoF5u92x5g0iEE9gxRsPVLuRcQRFRREPiLjiskppwKcJWB4pjtTpAIyCgmXURvgcdINeB3JM8BsXzMSsIaVbvk1L4XUcpb+e0F0cmY+jipAt4K2h2UKS7kikA4NVJJM2k/7BJLQawLrNXeIh6yeJjMW6wSnotv4fJnOzfTc2VRblYdRkeY47Ns2AVPY7+7BnKUt872i+axEbnXEMbQWnOQuRyWYlLdsa+pEFjT36tD55U/PsRCo8PzNRHAUuMQraIhUfr0tk/i/2YObzsU9PTKYErnTlzOSO5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CiFKFLhAOtg2fQoQXjIEOUXAKLH0r3SrJjrjsvl4+Fs=; b=DLMstnc5TFk51+yenFzpDURKTv+WODxNMIOXTE0SM1VLOfoIB37YYrHrM0bw5fsJQVYEN19B2q499ETeYajO3giQJ7aCvS3FIMapoS5C4M3fvTaW9nsjTirgTedqYS/+I19TidO53nnTXQ1dAx3oTLVigl1XfobcL2ETMl2RRLV/1aPOuhIzaPascaVFc/CDrXkgOzqQPI3eSIovhJqqjhrqmQNa6qflT70+Ver1k1VXHFbhaWOZOjl/qH1spZWkefmgceg0ccZUM/QlJ5NIqshd9TbHDZvNIrnjRMOA1F6+GRCr6Vb14Nbsn5L9+J9MWnr60hPyeHwAGcNPjqkKzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 7 Sep 2022 14:06:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Rahul Singh Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM6PR04MB6728:EE_ X-MS-Office365-Filtering-Correlation-Id: 45d19f47-7e74-4e63-c76f-08da90c96216 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IztEum+9Uzl8xXGC/1M2knt1bWqgznYWyqXbRngGn/T0ShDOizpgz0RH+Gs/IP4Dqo1pCsP44Aiv8JmFJn+YfasPVH6kX63SAcKppOaAIE1I4fPHeWzbzNIvzoSEqEgwFhOLxHnLLKfcD0NGAcYtuFuYormmTEQnqM9tgvKizfWlBy+dI6yEKGOmw4ZAEZ6BnLxlE5J71SIt+2vFN3+pknlsEOeBVuvBJty+f/bSlF+WEh098xHX3Wf3SUHGalUwOL7O8w2cXL86QfkdEhTlVRK5+d9rKtZ/qz65ynQhitQyP5nfSlJlhWzQRpFHSa8FL9HIGEb7xZ67UduJ1Q4X083wcSHR7eBD6f8NubHHiIaMcjBa4BuimHiwvUvMG2pUdY9zcKZSVWE4dFIn5kCcBGrZqc9EbkInUTCsxof5cybHGDfwlOsLlyvKZDHzpsB/58wHQXSOR7z7WfgewpJsco5yp3vT0nMIdlhuNIVCp4jluqud0UEdZLq5/oR0dvzma1bI4kGyBl37yuWhaa+5zJNYKDQr2UWlng42FTuQefnN/EEGnnV948hONxy1Q9zjzWv1rKmS7bGxlIEPXgMVUy9u9zE/4h1WrfYF+PJkKGt1E/ccn/wINuCJX7v39WFIsnbg+1N5GTU0NG8kiAzL0+5xFpZO0MQpTonVv4+plje8lGs74IXviz6lj15CgOHbtG0Q4LWEXyNGHk2LqgWMveuFazWkJzz/z+HZ+oiDfATapd7tQIsnim8ENhgVqSQ5bnGcj3PbGlXGwxSLOsQBVkVBIvtodVcEfakToI1us+k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(346002)(39860400002)(136003)(5660300002)(2616005)(53546011)(8936002)(7416002)(186003)(2906002)(41300700001)(26005)(6506007)(31686004)(36756003)(31696002)(86362001)(6486002)(478600001)(6512007)(8676002)(66476007)(66946007)(4326008)(54906003)(66556008)(6916009)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmFyYjF4NnI4L1FmeHR6dEcxL0RMZFpHcDZDR2hJenQzeGdYaVMyc3AyWDBL?= =?utf-8?B?UGtTc3ZnTUMvbHhuWkpVNmJGMnZieEhsbk1STHhuQ2p0cEo3SDBqT0ZTa2xC?= =?utf-8?B?aVN2UWswRFN4VGJwbEwzMy9MQnNXMDJ2YWdiK3VVZUZuYjFpbWZPOVh1eFJz?= =?utf-8?B?NjF5R1lCZkxXRTBqZ09kZlJXWVVHV2ZDT3cycHhOMW12bVU5NjZlcFQ1S1hh?= =?utf-8?B?d0c2b2h2aXVOWThRVnlFUWQ4VTlzVkdyZEN3L3VjRUFQS09jRUhvUzJKTGl5?= =?utf-8?B?T2NsZWJFUnl0dTJLV1NtbkRuSG5VVkZpV2xEWS8vc0xoakJnSkhncElYaGJC?= =?utf-8?B?Z1F4aXNrdEdJODRDNkRuRHc4dTRVeGUwZ2ZoaVpLT21sS2F4ejNObkkxS2F4?= =?utf-8?B?M0pLb2Q3VzNpc29RMndzUktBbldpZW9yVlZ4NVQwbTdQV3pvRTJ2dXhFZkFS?= =?utf-8?B?M2YwQitXWHdDNGZaZm1xSDlGcmhEU2srL2Rra0Z3c0JuT1IrUjU4THRwVjdq?= =?utf-8?B?WktsSGsrOXc5R3BrZ1pIM1VpQzJrTGh6RHRQNnVMc2lFR0E1Yld2Rkg2YXpN?= =?utf-8?B?ZUtyNXNOQ2dERjkvSGhkbnF3VTNJdFZZY0s3WjhkaDYxMGZpQUZ6WURmb0lD?= =?utf-8?B?cFFHdHJQaG5CS2pKZVBwME96TXdjTWlnaTgxNEJhNUFvOVpSZXcrdEEvZnNE?= =?utf-8?B?ZHVQVW8rbVZwbEkvOWpTTnpXSUdpamFKMmlUYjkyaU12VnNPZnlIUHkrWk5Z?= =?utf-8?B?MnRvR1ZHQ3JSMTlnWXg3VVFPNkhLT1dPQ2FUWFdYTko2NnJvd1dRMlV6d29T?= =?utf-8?B?MksvSEZ6a3B6U3lwR0ZJOFo5cUdtVkRxLzhiRHlRdjh0akJaNjRZRFF5bllN?= =?utf-8?B?M0hhSWpBTWhGaW5MZkdIdlBwZmVWY2tGcUl1K3BjVStLcjhmNjNXMklxaTFB?= =?utf-8?B?dVhvSDhaSVRkckNQN29YeTN6NFArdmNzdG16c0h1TFFVUVBoSCtMczN3azdP?= =?utf-8?B?RGpXVHN2MjA1b1hHNGNOWmR4QnlxMWd0UXVxNHBoNis1N29XTTFTMElZeVBu?= =?utf-8?B?ZG1jY2lJand0SithREhJbWh6bHdXRnQ4Uk5zV0p3c3E1cG8rTVVhTkVWZFF3?= =?utf-8?B?SWQ5bnR3Y2VHMTJRWE0yYjBDL21KelpLTDNuNUJORVVjNHdTcWJHR09PRFBQ?= =?utf-8?B?RWF1d3dPdGFIaE5BNEl2Wm5yUFFNUWlVQlR5dGFhM0xTZnJYb3Z3M0lVdXM1?= =?utf-8?B?NUU5Y1lEclIzdjBaL2Y4Umg2SExXTk00MFVIRDNEaHpsenJUU2h3dWQ0V2hH?= =?utf-8?B?QmpwSnY3azd0SnBibmF1UkREU2drMkhuT2RlN0NOUkFHNzlJNXAwYUoxRnNk?= =?utf-8?B?M3hia083bjZXT3lJOE5hYzRNMmt3TWFwYkVwQlFzK3Z3ZE0xNGlEenJQb1Vu?= =?utf-8?B?WkUzVGNGQ2Ewak5XNWNlYlRGMmpoMUhmM3g0a1E4Z2JnQTNvbFdCSEpRS3VX?= =?utf-8?B?cVBjekF0NGErK09BdUZvNzBGUkNPd2tZeHZvaERtOTd5QmZNKytkT0RxMmh3?= =?utf-8?B?ZEx4azRkVTRKL0JiTVZnWVQ5RUI5cHpISDFrVFY3VkZzNjlhYUt1WTRqZHUy?= =?utf-8?B?UU41c0JmQW13ZFg2VWd6bUhZR2orMmtUVFVnVW5oY2t5QXRFblM2VVEvaVcw?= =?utf-8?B?UHhJUExaUUZRRjU1TXZxYUpmVFhYaVBpcnhJQkhoSWlzOHFORlJnWmYwTSta?= =?utf-8?B?QThDU3pCblprOGlLNEh0NGVqS3YzYmkwaXlzVlE0eWF2amNUVU9mdHYvTHJ2?= =?utf-8?B?b1phWUZqNGQxM3k4UzdnTXpmYVJjS0hyTDFTZkNLVFc0WHMvbTJ1d0xxK21p?= =?utf-8?B?QTFCc2M4am1YY0FkMzRraXRrK0JWZXRDbkxhSzBuVlF4bFVDRUp1NVNEWHlG?= =?utf-8?B?WWhCcklUQnRPQXErTHlwOWdZdllYd1pydDVMaW9MVWhOeVdERld3T2lHOVZx?= =?utf-8?B?Z004NVU5elFhUlFTa29pZXVoWkxySm93eTh2MUxjYVkxOWlZNlFqQVBWRU1E?= =?utf-8?B?dWk4bFkybGFES0VpRzlPS3ZmMFlYejlNRFF3dU1LZEVrK0tvZ3lwMncxOEJ1?= =?utf-8?Q?whTs4cPeEdKdExYs5rY5QkoZ1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45d19f47-7e74-4e63-c76f-08da90c96216 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:06:23.6082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EBSvxdutXq1JoFRYDiFcIH3zAN5ngYOGgTbpjG1K9R6pN3+BYpKQteFxnbac5YRVXXLpv9jaNWcH4LDVpXkeqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6728 On 07.09.2022 13:09, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh > --- > Changes in v4: > - check "s <= e" before callback > - Add TODO comment for revisiting the function pci_check_bar() when > ACPI PCI passthrough support is added. > - Not Added the Jan Acked-by as patch is modified. Hmm, I don't see any change to the parts the ack covers (x86 and common), so please re-instate. I'm not in the position to ack Arm changes; things would be different for a Reviewed-by without scope restriction. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:12:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401450.643301 (Exim 4.92) (envelope-from ) id 1oVtuy-0000Bz-T1; Wed, 07 Sep 2022 12:12:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401450.643301; Wed, 07 Sep 2022 12:12:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtuy-0000Bs-QI; Wed, 07 Sep 2022 12:12:32 +0000 Received: by outflank-mailman (input) for mailman id 401450; Wed, 07 Sep 2022 12:12:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtux-0008Nb-9J for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:12:31 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2084.outbound.protection.outlook.com [40.107.104.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57ef0dce-2ea6-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 14:12:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7404.eurprd04.prod.outlook.com (2603:10a6:102:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 12:12:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 12:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57ef0dce-2ea6-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YX1oBx9yjBMwPuiua1Z1GfjR0ktwwZulkkHJpMAV3FgZJhpkW8+cDH1BGw9ZiGeTYSnzKDJQcZ9DWgBX9uPPQNX8WD5/u1EE7FwnTWVVn2NH4qAahi/XDeFO1aIfp8Dm4v/wrFmfjcKsTK+U3zftKzf9yVI8LHKgDUZ82WAtezIAm5Ve6RVgIguNijj9ejlObp9aiUktTBfoBOS1wn8vR0xb2PITC8dxY1NFhygNFU8HfH1tGcdiznNYwCbEBvWd1qQUbPmq63BtWuJuxqgw8axx34ncDfmVqpsGKbR/LncipSLa0AVSntDC/y3+tcFDBocIp02CBATA8yB6gON8GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pIm6Lb9lUpyeG1rj/K/O/GvuUTTYgu++SwSYDBeUgTE=; b=lxH1AwUltci1hU5ujAuZHhmW8kbVyKz1/t/DkJMbdOdlJQX3T8fmyD038m7EA4WG0Sqfxkuic2g9Sbl0JQB+zRoaj1EqNa37Hu86gjUq4mbU4b9qAL3idGOG+NgVGVkjlQp2952LhR328AE/oLVuDiCuzO5RYPrWEmGoBU4Uni/q/ICWOULNCC+N6fUKOunzQ3kpFGKE500qgOXZCbedGfnA5iIHDVpFNK332ihBj2Oq94tYhChRkXRjs61kZASMShIvOzzVH87kYMNKVl3i4KO6egWpbGP9LHNiXLjal+xpCNoelGJS2SPVPJrXybmJhe7cjW3G2WRyuQ3vXUNRuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIm6Lb9lUpyeG1rj/K/O/GvuUTTYgu++SwSYDBeUgTE=; b=B6PgIpM+bENg9eo3kWSVkrggSd5g4qKG/nkav7JhmnkmN0FkvPNJtmHSyl+QfYluCHQYjy/ZVk6rGK5LplnSQa9Im6Bmp7O7ady6lyCMJoiC1s9pM8nHrawM92tRuVl5lL0cIrgb+e2akWVdoXY0p/oX4WBY7YHVXApuh4wiped4dyGY+uesaaOg4gEayOESo9WFAm528iogb+dC4gBUfdb3ARSgTurapVMEUKHrUqQd6/hYyZKZTBzkbeT9GYEd6LuSVmh/RTcjjYSI5NhUGY0rFy41zciU20TzXtJd7bUYa1rw67aSH8A8GUBqWnRgU0UHdqgsDksTe2jwJQBNhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <40400a52-b55a-1c35-5ee8-32ebfb08bc28@suse.com> Date: Wed, 7 Sep 2022 14:12:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen: Add macro for version number string Content-Language: en-US To: Leo Yan References: <20220907120420.387771-1-leo.yan@linaro.org> Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <20220907120420.387771-1-leo.yan@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7404:EE_ X-MS-Office365-Filtering-Correlation-Id: 041e9d63-3838-4e70-2dc0-08da90ca3ad7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kSgl+8rD32Db2Eiq7fmi/tDmt2YDAIyn/WOMw8vrLfOyc0Cybyh5ulGqocZWt65WQC5waUhzvTFsOgRzXo10ux7xoEOnbJe4R0OPur7UTh/ZCagEndp2fqD7Ju3Ty49I5b/27ND5syVrYTIQpAsGdvIKCU3qdwaw2iEyMeWWFVlyQwV3+HLPk7ZtbGFhVSLaeLFj12dQL7kJQGaEzO+eqKC+7C0hQmJcFd5/5h8lIH3MyaEYNMu+S+37RGC2uT/azQa6SCFcC2SCqd2H3eYfEfmolaPrWOHHi/O+/CGDcEGjF2RfYS8V2qBiAG2Fp3RbE65urPoxf47c2Lak0IMK1VpKfFamzj0RWSxJ9VGlPTrkSxnaDTGtJSNiMxVdjjQtLvcpRnENsAS9yBR3o9v528Foz8RieNRLsOJE+ZDbHlcaknEwsNEQPx2bltFuKYZIOR/tyZvqvRP9RBsxY1RHehvwHTtovJQu+QUPn71SnefHqyC5/hx3Mq+vKJp+/4iMUuMfUXuOLTAAFRdGg1mWz8J1qBpi8JYD5QBXjZiaaIdnE/Ep3mP485RbPu+pUj93lIMRXEp3i8RbyL6y/Do0bvjiGZwu5xclULLn2Kavm5WlIMb1R/0xjdU1yZbGEuuYopvPgnY5Sc9Ln7VW34q7iI9e3gg8xaMClW1V+cMIVJZS6ywlzvU9SLJ+/tpqBlUHgIDIahvZ8khjVM/wPj856O5u1C2itTLeMwRkPv/3zCvAmzArdZSDTAwj4GgXS9x6yyHJAYLLvk6h/5Wzgldz30k3rZnetUWDj/3Mh3W6koI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(39860400002)(366004)(346002)(136003)(186003)(8676002)(4326008)(66946007)(66556008)(66476007)(6486002)(54906003)(6916009)(31686004)(36756003)(316002)(478600001)(83380400001)(2906002)(53546011)(6512007)(26005)(8936002)(41300700001)(2616005)(38100700002)(5660300002)(6506007)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW9vclFaWEUvZDRSQTJ5ekFVdHNNM2p6bDh2UkQweTFWY2paWXFST01NU3h5?= =?utf-8?B?YW5xVy9kNVl1ODV6ZWVpTmNyY1d3Y28zeXNrRDdSb0NHZW1PdmI4bzBsRXp1?= =?utf-8?B?Z3E2ak1FdGxYVnd5Rk94cTBtZW1QWVpFNzF5cDJqbnViTFF5ajFqck9RMkFj?= =?utf-8?B?NW9yNkRnc1lmNjlhRGw5b2xpQ25MTUtpV050VEZ6YnlpVzJBNUVQZU45MUhv?= =?utf-8?B?Q0RjKytRM2U0dUhqRVhBUkRFR3ZmaVFxampmQTZneUxxOGZIWnYwMzFvUTh4?= =?utf-8?B?VmcyM3YvWG0wbVNTWTU4QmdjZEMxTE1peVQzZ0xDSXlLa1lHL1A4RXdRNmtS?= =?utf-8?B?a0poWkNwdHVSNnRydmFOciswZDdLWHJ3S2dYcUhobllibUpLZVNBdGVmYVVm?= =?utf-8?B?RFpHV3kxVEMvQkE1Q3oxV2VRQnZPKzhjYzUwSkRUSE9pV0dPM3RqSUdyQlZ3?= =?utf-8?B?a0Mza24vNnpYSUU5N2IwYVRkMzZhbjRyZjF0VVhLbVVYK0d4bThOQmNwZG1u?= =?utf-8?B?M3RHQkhiQllidW1TMUJyVUVpZVZWS3AvQ3poN0YxYVRKQXJaVmZCVitSY0ZY?= =?utf-8?B?NzRnQWRGbUJvMTA1U0hXQzZqQndIanlkclpEOTlkVXFPY0s3eDZkcDhrbngy?= =?utf-8?B?QlB4NkVhajMyUjBrY3dIRmpIblJ5V3pEYkE3amxQRG5rRUd0bitqdzd5QzM3?= =?utf-8?B?ZnQwNW53RE1FNjN4MlF3WVBURGNwelBCUVVxRzA2UGdacGE1c2x6bVIxc2lR?= =?utf-8?B?YmNRUVo5NUhCek9WV3ZFMHg1RWY3YnpQNG4zM2FFNkwvTXVlVnBlbmJ6U2ZD?= =?utf-8?B?TEExc3RQbkRvSm5PeUp3eWRLZXMrcTFubGpuZG1mekJPYkIzOGlrY1YxNHVz?= =?utf-8?B?b0wzeXRSWExHQnhJR2JXV3FMYk5BYTUwTFNyRW5QZWN4MzdyUncxNnhuMlQw?= =?utf-8?B?RDRlRnNETzJDd3BmRlZJNmNBcEpnOGVwd3FSSFhnWmJsbGM3UjNyODRMRW1V?= =?utf-8?B?U1RnWWtMdEd6YUs2MENNSDhtOXdTSWFoOStCbWVpc2FPN2hhM2tGNjloZ0Rp?= =?utf-8?B?S1NpbDBRdmdTV2xQbk1yUDhRdjJCeEZlRnpHV3VyVFhyNkpscTFrc2U2THMz?= =?utf-8?B?UENYcHVsank1aUhTaG9mWkthcmV3eEdudXNELzdxWE5YNWRLbUxqNk5QeUJJ?= =?utf-8?B?MEc4cDNqUlBIVWthcFBicXJMU3ZoTFBhY3g3RTZFVDRHS2hVVVlkbGs4WnR6?= =?utf-8?B?UTlnMUF3QU5CekxTTmNBWHV3Vmx1L1pNRlJLNVRqemlNUHltL3JJbG1uYk9G?= =?utf-8?B?MnNxZE1veHBKcHN1Tkl5VjNwK1ZCRFE5OEpNMmx3cTVLM0k1cnE2K1BWWGdk?= =?utf-8?B?V2ZsQ3p3d2dOVlNvMmRQR2ZsSnpqNzhlNzNOYkVSSGRqM0lodWVGczl6UlQ5?= =?utf-8?B?TTEwdk92QUkwQ1ZDbEpmZkw0amEyRzBnZUd4SmVFMXZJOWpQL1V2MnJQUEtJ?= =?utf-8?B?OStmbHRwL2UxWXowTVRPb29GdnEvTjRxV1hJL2JnejY5RzllZysvT21TT2xO?= =?utf-8?B?aHFiVUlkV2gxSGp6SWtKVVRtd0UxSklMWk5XVmFWL2R6Z0oyeW1aYnU2WXFI?= =?utf-8?B?VTE2K2JHQWhlb3NXQ1hValFpWEJGZEgzNkNlYU1uQ1EvbGp5MHFnVWw3YVFk?= =?utf-8?B?dHhITHg4T2xtMWJQUm9Pa0U3eG91RFZENHRPbUV2TjR0T05XMmdQbU1mcHVS?= =?utf-8?B?TjhtYUZ6YkdRMk5ZMGRlemFkSnBZQXlUU2wzRU1BOFRtVWVmalIrV0p6WDlk?= =?utf-8?B?LzZyMFNzd2ZYUWJlNkVEL2VHVHhwRWk5cFFsamloUjh2OCt0TnJOenJDbDR1?= =?utf-8?B?a0FlUkIxOEZ1NTExTFdMdExsZ3RoNUxweTArRVlrSUxnVFJ1Vy96ajAwRWtk?= =?utf-8?B?YnVyNG4zQXI4bGxPL3Bqb2FGL0hMYTVnZE5TNWRzd1h4My9zc0kvRkdVa0th?= =?utf-8?B?VjdnNjJGMyswclJNS1NDZXEwVXhGS3M5cWZHYWc4UUFTbWVucEZ6ZjJxamtM?= =?utf-8?B?SVQ5enBObzl5NktVbG1IOFBrclArRWZ1Zkk5SWVjV0djWUZFdlJYQnNPbUE4?= =?utf-8?Q?2MXFuggiwobqOi81PkbqMIf1L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 041e9d63-3838-4e70-2dc0-08da90ca3ad7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:12:27.2414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y5zt3rcqRBKcXxsRRpWPyYk9RmlWpAA1JugPHAFBYMvaVAyeDOagDucyDRLkC8orHsL6guWgc26XKPipoBytag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7404 On 07.09.2022 14:04, Leo Yan wrote: > On Arm64 Linux kernel prints log for Xen version number: > > Xen XEN_VERSION.XEN_SUBVERSION support found > > The header file "xen/compile.h" is missed so that XEN_VERSION and > XEN_SUBVERSION are not defined, __stringify() wrongly converts them as > strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". > > This patch introduces a string macro XEN_VERSION_STRING, we can directly > use it as version number string, as a result it drops to use of > __stringify() to make the code more readable. > > The change has been tested on Ampere AVA Arm64 platform. > > Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") > Suggested-by: Bertrand Marquis > Signed-off-by: Leo Yan Reviewed-by: Jan Beulich with perhaps a small adjustment (but it'll be the Arm maintainers to judge): > @@ -91,7 +92,7 @@ static int __init acpi_make_hypervisor_node(const struct kernel_info *kinfo, > struct membank tbl_add[]) > { > const char compat[] = > - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" > + "xen,xen-"XEN_VERSION_STRING"\0" I think readability would benefit here from adding blanks around XEN_VERSION_STRING here and ... > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1367,7 +1367,7 @@ static int __init make_hypervisor_node(struct domain *d, > int addrcells, int sizecells) > { > const char compat[] = > - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" > + "xen,xen-"XEN_VERSION_STRING"\0" ... here (as an aside I wonder why these variables aren't static __initconst), just like ... > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -1341,8 +1341,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > efi_console_set_mode(); > } > > - PrintStr(L"Xen " __stringify(XEN_VERSION) "." __stringify(XEN_SUBVERSION) > - XEN_EXTRAVERSION " (c/s " XEN_CHANGESET ") EFI loader\r\n"); > + PrintStr(L"Xen " XEN_VERSION_STRING XEN_EXTRAVERSION > + " (c/s " XEN_CHANGESET ") EFI loader\r\n"); ... it is here in particular for XEN_CHANGESET. The other general remark I have: Please follow patch submission guidelines and send To: the list with maintainers on Cc:. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401449.643289 (Exim 4.92) (envelope-from ) id 1oVtux-0008Nt-LL; Wed, 07 Sep 2022 12:12:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401449.643289; Wed, 07 Sep 2022 12:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtux-0008Nm-Id; Wed, 07 Sep 2022 12:12:31 +0000 Received: by outflank-mailman (input) for mailman id 401449; Wed, 07 Sep 2022 12:12:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtuw-0008Nb-Go for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:12:30 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140073.outbound.protection.outlook.com [40.107.14.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5754372b-2ea6-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 14:12:28 +0200 (CEST) Received: from AM5PR0101CA0008.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::21) by AM8PR08MB5716.eurprd08.prod.outlook.com (2603:10a6:20b:1d5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 12:12:26 +0000 Received: from AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::f4) by AM5PR0101CA0008.outlook.office365.com (2603:10a6:206:16::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 12:12:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT044.mail.protection.outlook.com (100.127.140.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 12:12:26 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Wed, 07 Sep 2022 12:12:26 +0000 Received: from 1ad077a4a929.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C8098B73-D064-47F1-BE30-39B237C94A98.1; Wed, 07 Sep 2022 12:12:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1ad077a4a929.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 12:12:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB6346.eurprd08.prod.outlook.com (2603:10a6:10:25b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 12:12:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 12:12:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5754372b-2ea6-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wf6V1XzwqJsA+0rbkpXFOORBlNhczf0YjzfqUzWHNpQTPJtkA3CoFekA5dTC72EN0TK/E19nDrjSXIZFXGjbvGj9V/wc5dKNb0uN5RslAevdN+0cGw436hXB/LocjDANCrxagn2imDVv372zKIZ9WFaCaxRKbrjiyBKfp8cwEVNKuyw8M0JnoghqPUP4x1c3CmfBNdWeLydM4VkGElMOajilg3pmq2FsjysSgbWRFVoK8uMX/hUm469JVRRBV3PzwkgutUuJdPSqodQv5ZjnFssohEZK60y67c2jdXIHqHjJJz/wNaRwk3+pc/CpgoDXNPoeW26cM/HsHXiqCZITfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IP+0fqfSVNnvMLpLRDJZwIHB1euGc1DDJGj5BdA6SQo=; b=TUTE3730GXRQnxHStiXMpxzTkFbIbGWiAIRsu2rUakk9G4k3NLgOh4TLQVZyswAa41sRJk0AeFGAWjVKw6LtZEyJEY38ynJtkbJQZ83taB1nE16K8cp6f6smQORH1TwhgaQK2X0gdmJb6Gd6/f0aV8UfbL1uSwxBSM0jLIQ1aq671+UhgAtN5widTIWc9IsRjqRtt587wQiea4gjjbx3+/uMVyTAD8+8UD/2vMQKCRraDOzJiLoG7FriHqSXr3j9xmI8g9fad0w9SvcltB6mATEU0DEQ5gXE8PlRgMM5L/+ILyIhsJ8+FOukTBfQ7b8UlkTrIVj2VjKAjkPLP0OjsQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IP+0fqfSVNnvMLpLRDJZwIHB1euGc1DDJGj5BdA6SQo=; b=pzgZYDjjS4+A6M1HmnrJ1B5TtsyJQ/naZR4xv//EJkcOdUjLez77P2YV88l9Nguj0EvmjiP1nzzjrMpQhqULITDfY89G+Q/1NGqaBaAkQ23fHX5cnsH4KrHdfl6SDqiDmXmnliRbU2XUy05r6XHue1vQUCAy8hEO+pMgYb64Qy0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 876697749c00988a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b82veE1hrMYCqVOWwfEO3wrxIbmMU5qMcIW5/2E+Kl5eFSQl/8/v3AHbaqav+WpKvKMLXd+NVl7Wp4kf4+5/cRko3njVmyCbxGDk22SPHL7vsDTW37K+EJqnGOYejxAr8SYV/cwZcCpgAivhLcG+y6RebhWf0yfhoF5F5GhaJLn/AdleXXlQ8Yks+6HNstiAnR7SYvdTzMN3Jqj8L9CcGqsHL0CvdKa+eqUGQGCemPqVcwoxtwP9oXOSCAzqb9LuHTbQ5PSZjtet/6rN+FJCuMzvvhsJ4oJSuzdUnQHdmGH+JqUkyU+u7txOga4DBLrZJnTs5LClb1HUYt2RclIwFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IP+0fqfSVNnvMLpLRDJZwIHB1euGc1DDJGj5BdA6SQo=; b=iw+05tS51Ts2FQkDmIpZXARerTzrmRnWjQtbuTC1rm2DQ+qxDAruREqyS4xJtkafrI+nlOf9iNXuhgEspZkwoG4K0Ms0s0dtLly2D1/0/ReXiLdghHVdSABaCbHR10pl3yIHeOn0DbbUkGjIZHqk1d/8pw/4su8gWdEajWfiyN1q4oi1El3/uDwMwLRRGb535j7GPL/SweCpERRlVPyg5BLNOvEqYpJdBmrI6rFf+W3C/m8ylTUeDeElFGrEgOOoh5tmkd9kvLpBDwkum/7R9dEbTAmYbdjyRfG7DvYn/ZwPcZq3jgj8w46a15dwGu2fQ8mE55vGL2Yv+KfiPAO/Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IP+0fqfSVNnvMLpLRDJZwIHB1euGc1DDJGj5BdA6SQo=; b=pzgZYDjjS4+A6M1HmnrJ1B5TtsyJQ/naZR4xv//EJkcOdUjLez77P2YV88l9Nguj0EvmjiP1nzzjrMpQhqULITDfY89G+Q/1NGqaBaAkQ23fHX5cnsH4KrHdfl6SDqiDmXmnliRbU2XUy05r6XHue1vQUCAy8hEO+pMgYb64Qy0= From: Bertrand Marquis To: Henry Wang CC: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Penny Zheng , Wei Chen , Volodymyr Babchuk Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAADUACAAAaNgA== Date: Wed, 7 Sep 2022 12:12:11 +0000 Message-ID: <43B994EE-81DE-445A-B31F-477148E5465D@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0a1c6483-a699-4894-f3e2-08da90ca3a7b x-ms-traffictypediagnostic: DB9PR08MB6346:EE_|AM7EUR03FT044:EE_|AM8PR08MB5716:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sSAsofcazvppWG1zteyyVmJgAJVUHKWGzXqbg2vdRQL1wL0o2naYpbHh8tX04MwhMb9hg2A4j0epg8HqITc/lNtPno9HF8tiHNs57jrV4Ud5A0y9kwQuPYZdeXeYBRjJqlKYRYAT12YU0YyMXvgFHxstX9vScgFfDClJsSPasS3Wb66Vgj7QwyfBxvMFihmQRyy32F9kBoN9kjKF2rcl34nTCO3/0q/5rPuGSXY1BE60oW7+VPXOUQxo2j05W5aGMs8WLkRbyoZAg9g5/uEC2bFjJAaHyH9cpySwkBQSxUkHrN0GfJZ9fz9T4fp9uDdslNqLH8LcJo6mGqKC1rGf/MpK8j1vGbmYBb1z71w4dtf2iWIpkNiscRHltDQ4g+5l3SF6LOumw4eD8rFR1v6R27J2Xzq1VUYSOU8h44GiVGtL1ygtFARXizFXPoDGKSGQflzRmBqtPzRCZcMR5FWN7leHkFwDn6YX9AOYxj7C8eY9JaiwWcIU7hafwuw34t4ea2jhUKVBzJHuJsq0gM1ZTk+Rq/gcDsR4kaOqM1Z1nVa4WO/3Xa/h1XoZebqND9o9i5fK/shkL5/VYEDkDnPYV7Ec7SUB0Si7vaf2c44ysAXCK8vRrYCJXiiln12918oLZGDSS946Vua8Rmd3spbNVfJpQiI+mIyccpoTLtepHI2/Db+/TOvURNBX1mmWfae63Naqz5qhLSyChHpQcddI6Zfnv1DX1juzJgel6rjNj61GQHtBXRvunAk1WuMmWcSHiZ8V88nVW/f5Eje8lxjhlF51Ui/huvQfjNY6q0RIQCY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(366004)(346002)(6862004)(5660300002)(41300700001)(8936002)(2616005)(33656002)(26005)(6512007)(53546011)(2906002)(86362001)(6506007)(38100700002)(122000001)(38070700005)(66946007)(186003)(83380400001)(91956017)(37006003)(66476007)(478600001)(66556008)(54906003)(66446008)(76116006)(64756008)(36756003)(6486002)(8676002)(71200400001)(6636002)(316002)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6A13D77CA4D4F34DA6909049DEDDCEF3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6346 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0ee15c19-5d1e-4f62-ede9-08da90ca31c1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vIBnG2iWrAvhDd8ITKmKzRPrz+HYnVxuGMPnkfTOPAQGUDWz6fI4g/s1iEfT7ob4vNkWUfGlO0ooyUXUqQdh6iQU2jxNhRryukzDaJkMt56VsqNtCnDItxz2yB2lkwq++IRx8zZebMQ6S/2927auQybqlUh/30NuR4eQVis2owQtsDhd5PQ3bCOyaki1c/Mh6klIcCJ1xskqbKBO+lhn+2+Zb1YaO8m5h3qlu/iG+ZoHazL1VzXQFXo+LdBPnAMr0i++VeIlVWjx60UtBn5oY5VQf66n9xdeQOf9IxMsVGFJVqA73tf7hwS9AyIMGVMkqhrW/wbNF1Qk8ysJ/CKrMAAMftyiR40j+AcIM0pvfNdjg3dhhjKVNrqOvhmMjb7B84mpUOp120wB32xvb9rS2ZEFDYh85Dfcg5sc3uoj3/nEQubMW+Lz3PxapUsmHvYX9wX+REjsMO32XY2Thoh9hM+UW/h2UOF1JKmb4LQ/CXoP69FsgMUkBl4b3DMmI4yAyh0cMwBUMHwvulyThgu5YQJSg+Tf+BBKA/RE9fZvQ2xPBqbLhr7Mbef/BEkECDTvibOft8z3NKIJFAiPN8lwLuhNWEc1awLf3BjJlEiY392T88oYxK/B7ucb6MpUX5pyQRrgthOnaPY/+4njETnd9AV7bXwN373NSitM98ssfVL17euiCXGIomxpUQejmfoy5DZAdFqf86278KWWpE1sbQ6lk0WhEsjHh0h+wveaeZtxr6KMouY30wOyJUcHZPEpO0GED4lkUKtEY4b1Eh9XCw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(396003)(136003)(36840700001)(46966006)(40470700004)(81166007)(356005)(82740400003)(40460700003)(316002)(54906003)(70586007)(8676002)(4326008)(37006003)(70206006)(6636002)(36860700001)(82310400005)(2906002)(40480700001)(8936002)(6862004)(2616005)(336012)(186003)(5660300002)(47076005)(83380400001)(6486002)(478600001)(6506007)(53546011)(6512007)(26005)(41300700001)(107886003)(86362001)(33656002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:12:26.4716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a1c6483-a699-4894-f3e2-08da90ca3a7b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5716 Hi, > On 7 Sep 2022, at 12:48, Henry Wang wrote: >=20 > Hi Julien, >=20 >> -----Original Message----- >> From: Julien Grall >> Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory >>=20 >> Hi Henry, >>=20 >> While reviewing the binding sent by Penny I noticed some inconsistency >> with the one you introduced. See below. >>=20 >> On 07/09/2022 09:36, Henry Wang wrote: >>> +- xen,static-heap >>> + >>> + Property under the top-level "chosen" node. It specifies the addre= ss >>> + and size of Xen static heap memory. Note that at least a 64KB >>> + alignment is required. >>> + >>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>> + >>> + Specify the number of cells used for the address and size of the >>> + "xen,static-heap" property under "chosen". >>> + >>> +Below is an example on how to specify the static heap in device tree: >>> + >>> + / { >>> + chosen { >>> + #xen,static-heap-address-cells =3D <0x2>; >>> + #xen,static-heap-size-cells =3D <0x2>; >>=20 >> Your binding, is introduce #xen,static-heap-{address, size}-cells >> whereas Penny's one is using #{address, size}-cells even if the property >> is not "reg". >>=20 >> I would like some consistency in the way we define bindings. Looking at >> the tree, we already seem to have introduced >> #xen-static-mem-address-cells. So maybe we should follow your approach? >>=20 >> That said, I am wondering whether we should just use one set of property >> name. The more I dig, the less I find a use case where we could need different va= lues here. Maybe just: #xen,address-cells =3D <2> #xen,size-cells =3D <2> Could be enough. If some parameter needs a different value it could introdu= ce a specific name. Or maybe just memory-address-cells and memory-size-cells if we see a possib= ility to require a different value for an other address or size. This would also make life easier for users as we could just always put thos= e 2 in our examples. Cheers Bertrand >=20 > IMO now we have the pair > #xen,static-heap-{address, size}-cells and xen,static-heap for static hea= p. > and the pair > #xen,static-mem-{address, size}-cells and xen,static-mem for static > memory allocation for dom0less. >=20 > So at least these two are consistent. >=20 > I guess the concern you raised is related to the static shared memory for > dom0less, > ... >=20 >>=20 >> I am open to suggestion here. My only request is we are consistent (i.e. >> this doesn't depend on who wrote the bindings). >=20 > I am not sure if Penny and Stefano have some specific requirements > regarding the static shared memory usage. So I will wait for Stefano's in= put. > But yeah we need to keep the consistency so if we are agreed that I need = to > change the binding, I will do the corresponding change. >=20 > Kind regards, > Henry >=20 >>=20 >> Cheers, >>=20 >> -- >> Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:13:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:13:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401457.643312 (Exim 4.92) (envelope-from ) id 1oVtvb-0000zk-6i; Wed, 07 Sep 2022 12:13:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401457.643312; Wed, 07 Sep 2022 12:13:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtvb-0000zd-2Z; Wed, 07 Sep 2022 12:13:11 +0000 Received: by outflank-mailman (input) for mailman id 401457; Wed, 07 Sep 2022 12:13:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVtvY-0000sR-T9 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:13:09 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2047.outbound.protection.outlook.com [40.107.244.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e07aaa8-2ea6-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 14:13:08 +0200 (CEST) Received: from MW4PR03CA0031.namprd03.prod.outlook.com (2603:10b6:303:8e::6) by CH0PR12MB5153.namprd12.prod.outlook.com (2603:10b6:610:b8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 12:12:58 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8e:cafe::d2) by MW4PR03CA0031.outlook.office365.com (2603:10b6:303:8e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 12:12:58 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 12:12:58 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 07:12:56 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 07:12:56 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 07:12:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e07aaa8-2ea6-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iuDbQg7WVZPBMMSincH31M1bzLYxQBlEnFPh6fhXigJaOOMsuQW+ZU4HCGSqnZ42yh4fjdnVUADpA2rlkgnGnMtmOYPWcz3XBa/3lhyizmauEA1ptkiPVwg/eHel4rfe1yjm2JgSSYP1zsWdLm0WUv7C8Xl6wzvzg7gvYOKk/EsZJ5fGJUZhOyHJf2G9DQ5EnO2BWfZe14oLGjq6jNKlrVEiIYJDE+pgpEljAHqj+o0zZfyti5SpQc7KEjL8/oWGJ1byAxbzHWA4dTqetTiWX2JrTyZu72Yk1GSIHtsjLQRCBg80CNwh+bNW4V8MOSBHVgidha+HSkMTHQbXPQ0hQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=12+37N4Z3aYYq6cSIeYWSWpqZjUlnG2PQcA/ZS9uVWc=; b=Nr48S+hIkhW2TwFgtpm+FxJ2oRJF40dz0Vq/kLi6bA3gZaw1nhcC5Rkn/alRYWEnJaMXPdV9SM0f5cQv5mky06chvO6qOxVLbAdfoBur0bXLYwjHASHxA7CQI+90Nsp0eH2x8OfAlJCWyF19suZwnBzJmWly6mkC7bf4gd+WvupxcIGS4ze9p1iD8aqJFnX3BQKHx1BRTx82BAH+7rs1Tg5G77KIFwIaddBrurEH++QpsRlH/VQVUHYB/+tP7SlLeuXIKExYSJzCa099Mam7TxETl0QDYSTRgG38hKzTTPephxszspQqY66kw6oj25isTNhYjCSmnAQ9r7BUYEoqgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=12+37N4Z3aYYq6cSIeYWSWpqZjUlnG2PQcA/ZS9uVWc=; b=reYPuSTUGbun6TrUP+/z3aTITryuDLlKRiBPW5qY0lOsy25Lu3fFzttmi9VzQIdkFWUIIAOrQUuNUB0MB4luIzpilzmFAJ/OzIj7VhWgqr1EbVbuLEjpCKhc4Q6W/eqrFnfZvZ/G0tV4jdu1wFbN3mwr1TqZ4wQNeNhnUQ1Z3ZA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> Date: Wed, 7 Sep 2022 14:12:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Julien Grall , Henry Wang , CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> From: Michal Orzel In-Reply-To: <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT050:EE_|CH0PR12MB5153:EE_ X-MS-Office365-Filtering-Correlation-Id: 54ff5849-6eaf-4d40-7676-08da90ca4d59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a40rJSzJymNiW+YF9mC/Ed/ztXsEaMbLGb9qAvj/oyXhB+HZUSyEpawYlAn+VSPKw7TWHMNudZntW0xh4esuKCFbNHTuxm2Hk2vM589wvTQkLh9xJh6IuIvjOtNdBtVBQcVtHyKlLfAGJfj0h6ZM1TG9xAYB5HiT0Sq+cLgBf6mAzsrZc/I0swrAQr/Nan6iQpzXaCA8Oy9AOXVaYgGaT9hrpDRTLcw4F1CGc/l5kK8W/qJIyr8Hh4BwPhBSKw+7t3X6UE2iSVHlX98Bi/E0vNvfUbeO7fl+0VUyUJIIEDGc/eDGTnLZMKImxglW/NHF397bc6+Y+cDs/7H2SHycC8UC1lAw/MqncG35sh6Y9HaQc/PwTdHLJXGdJsjHg7M943H0w4D51OfQD4RGHZXbMEYlCWseCwGw4In4uNN84DgFmYCXYBDBKKMmmuS5CwRaoO/Au8cH+bg2IcEZoMr00Gbk12/z4ImeRkrahS5xD2aDtVTAkO6fY0naZAJgSqrXrFnsP+aDXHiZMZsi4Sn3oetD6Z2OMTlL+8kjr6UVuVuN1IMfyCJCv9FyJ9ntjyMOr0j+w7VWkZ+iG8WaoPUz3pEElehKEWI5X1CcpxmxjAf+cdQaA6IEscCM/bTpE69BLO1nwfWhNvOqautrJQhbWWdE18EdS2b1lB41S126OhbcFJzOvaRgCitUKA0ZJ/og2Rh6y4LPxnNOKLJDYbqv2UT6pR4x0PqpsRegheHTxeE3F2SOOsvCw61LnLhhOjYc0OeQjts1+UpQUKCFWXBgEiFzMIFMAGmwIP8QkegbHoVEDtbuiSYd4abGp7sQFxfv3+XNsnRjkOrRqJn9PlgNDQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(40470700004)(36840700001)(46966006)(426003)(53546011)(70206006)(31696002)(47076005)(86362001)(40460700003)(478600001)(8936002)(8676002)(4326008)(70586007)(336012)(26005)(186003)(40480700001)(2906002)(2616005)(82740400003)(16576012)(31686004)(41300700001)(36860700001)(5660300002)(82310400005)(81166007)(54906003)(110136005)(36756003)(316002)(83380400001)(356005)(44832011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:12:58.0130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54ff5849-6eaf-4d40-7676-08da90ca4d59 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5153 Hi Julien, On 07/09/2022 13:36, Julien Grall wrote: > > Hi Henry, > > While reviewing the binding sent by Penny I noticed some inconsistency > with the one you introduced. See below. > > On 07/09/2022 09:36, Henry Wang wrote: >> +- xen,static-heap >> + >> + Property under the top-level "chosen" node. It specifies the address >> + and size of Xen static heap memory. Note that at least a 64KB >> + alignment is required. >> + >> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >> + >> + Specify the number of cells used for the address and size of the >> + "xen,static-heap" property under "chosen". >> + >> +Below is an example on how to specify the static heap in device tree: >> + >> + / { >> + chosen { >> + #xen,static-heap-address-cells = <0x2>; >> + #xen,static-heap-size-cells = <0x2>; > > Your binding, is introduce #xen,static-heap-{address, size}-cells > whereas Penny's one is using #{address, size}-cells even if the property > is not "reg". > > I would like some consistency in the way we define bindings. Looking at > the tree, we already seem to have introduced > #xen-static-mem-address-cells. So maybe we should follow your approach? > > That said, I am wondering whether we should just use one set of property > name. > > I am open to suggestion here. My only request is we are consistent (i.e. > this doesn't depend on who wrote the bindings). > In my opinion we should follow the device tree specification which states that the #address-cells and #size-cells correspond to the reg property. This would mean that for all the custom properties we introduce we need custom address and size properties (just like for static-mem/static-heap). ~Michal From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:20:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:20:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401474.643323 (Exim 4.92) (envelope-from ) id 1oVu2h-0002fh-2B; Wed, 07 Sep 2022 12:20:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401474.643323; Wed, 07 Sep 2022 12:20:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVu2g-0002fa-Vg; Wed, 07 Sep 2022 12:20:30 +0000 Received: by outflank-mailman (input) for mailman id 401474; Wed, 07 Sep 2022 12:20:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVu2f-0002fR-RK for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:20:29 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150074.outbound.protection.outlook.com [40.107.15.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 755f2b2c-2ea7-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:20:28 +0200 (CEST) Received: from DB6PR0201CA0011.eurprd02.prod.outlook.com (2603:10a6:4:3f::21) by AM9PR08MB6292.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 12:20:25 +0000 Received: from DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::f0) by DB6PR0201CA0011.outlook.office365.com (2603:10a6:4:3f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 12:20:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT065.mail.protection.outlook.com (100.127.142.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 12:20:25 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 12:20:25 +0000 Received: from 76e9bb738d14.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70AF4604-A7C6-47DB-84C1-989C7FC1ED43.1; Wed, 07 Sep 2022 12:20:18 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 76e9bb738d14.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 12:20:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8420.eurprd08.prod.outlook.com (2603:10a6:20b:566::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 12:20:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 12:20:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 755f2b2c-2ea7-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DtItO6PxkskM0UIBZ7zAcAqf2amZ9b8T6F2i8C5vPFpuJeWWz76rIF4jNVU8dgvWbYyP91UWaNCgZQ5zaa9K3XqVkD8Fin/P9HL/YnynK0YpM0B44NLsEJfrksmyzrEP5ZJjtV8KmuDXqqLB6b6S5Gi6v8LfAR2MrwA4fg+UaNqFSGYxUG7AIukuXB/Lcj0TmmPNSSF5zfvIq0tf2OhscfEWPn0pAmkiCQ+hGiLkbh3m8UED0K5H8RO1Ms5C4YY3vn2+8GEZeVtI+jO7+vAKIXOiiUlO8LI+ggPw3THnDagJQT6z2IluGzOKdEQq2QRmKUmR1s/g9LWqYKvlLKWRYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vMjq3052Fx6FmowpHIC6oeufP1w0FdLbadls3QqBZ7I=; b=LAtibjyD+XgaTwNh3jFEFTfRnVSvd49BzBn0zvBylK6FgLEF7NHTKue04cZJEAYhAshq403d23WMtBPsYvb+2HyosDUJjZKwjRj1jJl2nzj6UNmMenRUYEoC9i4wHMDzRo0VNeSQ6wVywm3fylh0OXZ1kt7rJQ/rWxvw5pEZ6IOSb4Gr83pRGXdkX/YrurFfSTwETkQIfA8dWdVw/l2eZzrsl/LEWWH+CZu9fbTccyKiKg5cd9JVj7aUaCck2hxmYZuEI3p6qdTf3VAPeoDvlSUI5In2In5h1VzoMRpcypOG5C65yPT85gvgewQjzF8mnbBSysIcIdhRldHaXYiCGA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vMjq3052Fx6FmowpHIC6oeufP1w0FdLbadls3QqBZ7I=; b=tnam/hJnEfWSU1smqIIFkGNHQBVqJ31Dl8HcBmPDoL0qV03pBPvuEKQ3RCMDYOJqYnj5yAgFqEZsl9aAF+cOwD6dOxUbJZix8l8o5qYm1qFoIaKyYiNxt1buXBl04xEXJ7hNR0vAGwFSX4M56+0pPX9SdNqUF7Yap7O63CVMUyA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4102184d72d4de51 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e02A7UHxUlIq9096lsDy5ymKHI9wybMMa1VfAHnVfcm2TNav7yNM4tx2lZoJUODTcLbS4LFC9fTwN9bj6l54i60Aj+NRZ6JAE15XLjIbaJ6e6btS6M04cgoBNTNC4Sen3yuoewn/ZvavdAW+bdv9baTYzRmd0mvQ7n41GLNeXtw9N5wQXK0xQ9fO/P6ZpGmAFR+RT9/FXmD9y2NWjSp2W1CI9yls1Obdpn4YhJdiGY9brkUykdZLtaD8APdu1zG9QuWMSisBAUN1hzii7PcpA7qWR/9Cg0kuvUt3iiPT833k8xRjB6mlFyirfrPJAMfgQ5GPYA+s/MknVh1nig+7Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vMjq3052Fx6FmowpHIC6oeufP1w0FdLbadls3QqBZ7I=; b=kHmqlLUE87Z3kwTLuB7gTs1cMFwPJWLIT7jlNtRiE7UyL45BtWepLTiMthBy/6r4eCzFwWzbRFbvVucMBFmQrZE/BsVn93mS1UD/o8QRwlT9BOX8Hz9utXMygFZKbZ5dBc7boTsHwWz2iqFd+Ci5hrdDybrLRzwgvuCbMjp9lOy6xwTDdEC7Lbr4obAu1tXRhEauBIdLsaSms5Qc2CcJSClPebw87O2ygPI+NNoJ4arUyMvRO3d4eUdktE5PdzKY5VpyTXQ1Xcp2QjktpDKQR9NsPEzo9D9Q7ywOn1l9UxkKkQ/MBjsReM/1RDL9xlEJWFtBxJfTyfXUgNlO+SgoYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vMjq3052Fx6FmowpHIC6oeufP1w0FdLbadls3QqBZ7I=; b=tnam/hJnEfWSU1smqIIFkGNHQBVqJ31Dl8HcBmPDoL0qV03pBPvuEKQ3RCMDYOJqYnj5yAgFqEZsl9aAF+cOwD6dOxUbJZix8l8o5qYm1qFoIaKyYiNxt1buXBl04xEXJ7hNR0vAGwFSX4M56+0pPX9SdNqUF7Yap7O63CVMUyA= From: Bertrand Marquis To: "leo.yan@linaro.org" CC: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen: Add macro for version number string Thread-Topic: [PATCH] xen: Add macro for version number string Thread-Index: AQHYwrIAv1XtejytxUaSGPsSo1mE/K3T4vkA Date: Wed, 7 Sep 2022 12:20:14 +0000 Message-ID: <4A5E6FC5-1716-4D7E-95EB-83CA6451D88A@arm.com> References: <20220907120420.387771-1-leo.yan@linaro.org> In-Reply-To: <20220907120420.387771-1-leo.yan@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 587404be-2eb6-4169-8643-08da90cb57d0 x-ms-traffictypediagnostic: AS8PR08MB8420:EE_|DBAEUR03FT065:EE_|AM9PR08MB6292:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PnYOOwZskiVLSkeldrGwTFDMlwWIisK8s6ctzOBAWr9E9Iu/1OQtp8xU2T+Agivm46O5dxWaKMuSEvKQ2IbSyN/Q0FuqKpp2oDTthbEyRV7U87sVX68d7LbUOkt34j+a0Kw8dzfbuVIaMvdBB/mkZL2o65LmPp2YegQ7VpRstn5J60m5Nlj1OFSJi3qaJsKhMXiScbI1c0bJA1BL3nXAJv20Xi5/tRKFb4wceY8N5SLqOf1y+YIRtWP59jG6CY0uupishHsdLRXS6xnAZFy+IY9sojCnVDlRSLf2nAqNH0quLgQYzdt7YBnVHMtwDP8hNXRiZ58QsVmfduLjF2ZeV5Yu/4x+9Mzb+SMU5pYCLsHvL5QUkHeexsrsKvYA1ui44zg79uNha8ZBTYFIfKv+uhBEUDp6emUBugSiNqUtfb3TVHpihJtVwGjVvYYuqI0W6GIKdaqrkJml9T8KA3wxvazltNW8G8bXVrma5FH02LA0BfKkz8vtlajStUXSFft4jOZD/xS0eo3X9vuI3U2clFKGc9j9E9iyBsU1PK1xw2x7kOcLVTLy3ptzRA8hoQzzKmpk/8Fhc7MioN3JxqYyY9QpjCvoj6E+8rGvpPKLsqPu3FHXu9I4CIa5NZ1WgEfm959NNzDJrienC3Cs1KM2CI3otudcCatdGh8cOZfa5n87tPP6vL9uFUFOamnVE7gTVgmjPp5vtRATC0hxoa6vUNYdiC/JvsFEI/A4iJWt11rHOPraQd04M8+yBnD6lqi5AyD4uy8J5nC5hU8eAGAGjh9ncwX+FUygOmJAndOJiT4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(122000001)(71200400001)(76116006)(66476007)(4326008)(8676002)(91956017)(66556008)(64756008)(66446008)(66946007)(2616005)(6486002)(41300700001)(186003)(38070700005)(86362001)(26005)(6512007)(6506007)(54906003)(83380400001)(316002)(33656002)(38100700002)(8936002)(53546011)(6916009)(478600001)(36756003)(2906002)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <636E6EE1F635274190A4FD35DEDDBA07@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8420 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1bc5e251-f83f-486c-4fd2-08da90cb5181 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fiEJQrX4aJtYOz/RpG6UqQoN5UNdlotnXCWy1jq+1MmlGIT7kNCxLqVad6+NY90ZiD8oUL9OvQv7VBH7ffXj2jvz2P8lcERBbvYqyJEvgXcid+ipiWwksD5Rc6VFCWciS8XhLZxwGVruqRKxefplY52mIEIBkb4kixEmVsvp4f1UKkKjc1rxAmWYul11dW0BDA0VYeKOUwhVixsWUQDJGl/qyqWYKWvfzwMRzmnioyMe8BjPpAAGDlLuJ/Vis9T8zEJVN5F+dYkm0KuDBAo+v18yC6pAoC70FVpMiF9JSUtv2E3LQa+Fg5g5sR5G7bZ7wqvFVWlcHW2SqrO+hiPSRLlz40FwYURgo+MiD5v164MBdKIFVQSTGmT1rQ2lUYohsZWmdBznC+35Qt0W8UZ5pyzjzwJNzmWfw4pNJLlW1mcF7bZzCQtXrOHIwhGVcXED3d6jYS2hZimmMD6FFIBNm/kWwtK5hUfRsaU5qDUouskqj5pv3cMf/E0l0P92R0L4gWx9xwSM+lcKMiEqLkXXHt+FAM7kCgHiaylBlS38nTZhpp8e1ajM71VHrW/4YGoiHM8Ep8Z7RZeEQGzwL92jhKTvIFboIiSjSl30LXHrM/ZecwDguXqRVRFQV0hiYxmeDb/ruuIIIiPBZgrfI2nyg6aFIjr3Fn7C8ymORCffQ+2d0yj6aDFrf4BZwy/Sr8Oy5n2a/eXfFYaPd6U5gjlh6OwPMSDOScy543U5dbbnAOiMjax35gN3imAnc7xIsqEN5ndz1UN/d3bg8aaEwKtKOA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(40470700004)(36840700001)(46966006)(53546011)(70206006)(83380400001)(82310400005)(4326008)(6862004)(70586007)(8676002)(47076005)(336012)(36860700001)(5660300002)(8936002)(33656002)(26005)(6506007)(478600001)(41300700001)(6486002)(6512007)(186003)(2616005)(40480700001)(86362001)(54906003)(316002)(40460700003)(36756003)(356005)(81166007)(82740400003)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:20:25.2234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 587404be-2eb6-4169-8643-08da90cb57d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6292 Hi Leo, Thanks a lot for the quick handling here. > On 7 Sep 2022, at 13:04, Leo Yan wrote: >=20 > On Arm64 Linux kernel prints log for Xen version number: >=20 > Xen XEN_VERSION.XEN_SUBVERSION support found >=20 > The header file "xen/compile.h" is missed so that XEN_VERSION and > XEN_SUBVERSION are not defined, __stringify() wrongly converts them as > strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". >=20 > This patch introduces a string macro XEN_VERSION_STRING, we can directly > use it as version number string, as a result it drops to use of > __stringify() to make the code more readable. >=20 > The change has been tested on Ampere AVA Arm64 platform. >=20 > Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") > Suggested-by: Bertrand Marquis > Signed-off-by: Leo Yan Reviewed-by: Bertrand Marquis Regarding the change suggested by Jan to add spaces, I think it is a good idea so if the commiter agrees to do on it on commit please do, otherwise we can keep this as is. Cheers Bertrand > --- > xen/arch/arm/acpi/domain_build.c | 3 ++- > xen/arch/arm/domain_build.c | 2 +- > xen/common/efi/boot.c | 4 ++-- > xen/include/xen/compile.h.in | 1 + > 4 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_= build.c > index bbdc90f92c..b23c7cad7a 100644 > --- a/xen/arch/arm/acpi/domain_build.c > +++ b/xen/arch/arm/acpi/domain_build.c > @@ -9,6 +9,7 @@ > * GNU General Public License for more details. > */ >=20 > +#include > #include > #include > #include > @@ -91,7 +92,7 @@ static int __init acpi_make_hypervisor_node(const struc= t kernel_info *kinfo, > struct membank tbl_add[]) > { > const char compat[] =3D > - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)= "\0" > + "xen,xen-"XEN_VERSION_STRING"\0" > "xen,xen"; > int res; > /* Convenience alias */ > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..62602d2b86 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1367,7 +1367,7 @@ static int __init make_hypervisor_node(struct domai= n *d, > int addrcells, int sizecells) > { > const char compat[] =3D > - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)= "\0" > + "xen,xen-"XEN_VERSION_STRING"\0" > "xen,xen"; > __be32 *reg, *cells; > gic_interrupt_t intr; > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > index a5b2d6ddb8..db0340c8e2 100644 > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -1341,8 +1341,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE = *SystemTable) > efi_console_set_mode(); > } >=20 > - PrintStr(L"Xen " __stringify(XEN_VERSION) "." __stringify(XEN_SUBVER= SION) > - XEN_EXTRAVERSION " (c/s " XEN_CHANGESET ") EFI loader\r\n")= ; > + PrintStr(L"Xen " XEN_VERSION_STRING XEN_EXTRAVERSION > + " (c/s " XEN_CHANGESET ") EFI loader\r\n"); >=20 > efi_arch_relocate_image(0); >=20 > diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in > index 440ecb25c1..3151d1e7d1 100644 > --- a/xen/include/xen/compile.h.in > +++ b/xen/include/xen/compile.h.in > @@ -7,6 +7,7 @@ >=20 > #define XEN_VERSION @@version@@ > #define XEN_SUBVERSION @@subversion@@ > +#define XEN_VERSION_STRING "@@version@@.@@subversion@@" > #define XEN_EXTRAVERSION "@@extraversion@@" >=20 > #define XEN_CHANGESET "@@changeset@@" > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:21:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:21:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401481.643334 (Exim 4.92) (envelope-from ) id 1oVu3W-0003D7-Bt; Wed, 07 Sep 2022 12:21:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401481.643334; Wed, 07 Sep 2022 12:21:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVu3W-0003D0-8q; Wed, 07 Sep 2022 12:21:22 +0000 Received: by outflank-mailman (input) for mailman id 401481; Wed, 07 Sep 2022 12:21:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVu3V-0002fR-CV for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:21:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9474db0e-2ea7-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:21:20 +0200 (CEST) Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12) by VI1PR04MB6814.eurprd04.prod.outlook.com (2603:10a6:803:138::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 7 Sep 2022 12:21:12 +0000 Received: from PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::641c:ac6a:61d5:3fe7]) by PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::641c:ac6a:61d5:3fe7%9]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 12:21:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9474db0e-2ea7-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F01Gxl0KU/hQa493OLt988GGKrWqEBUWcTEQaQkoSD1SOotHWfNree0robNa3BXQTByIuq5Vb3KayzQthPv6fuY4Emvk1PMEW20j+wutt1KpI1gh7OiOEJTlgwC3bF6+A6PYISieKnDuTK2x8L66q6622FuQ+NxY/0wUD0Aje36Qxq8Xjo7SukTtdeGt38YlY7Lr+5ib0xJSVeoer+zOY2lLYgra1Z/Qcy7EqSZnOCN0c4yTXz2hC3cxHrt8ecU4k/eRby9jf/iG7MeFsfW5j580ZVf+PfYdGs2AcIOUmz2r4Cn6+3s0mSBrhy8Sm9LZ4PVzAvhJTi3DRvx/a82A5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cWddY4Q6qqsq/LH/mjnyD+YLS3YUR2OiGTxkBsj+yPk=; b=lK6MbSMt1ucovaUs2zYAFZfLk0JTarUiRW3EF/gWlm5GvQEso2xu2UPEkvhVe/wB5V3dxqnomL9cQ9JoVZ2rfE6CDBgeveMv33GlPHhGl7+tVb2cIcoqZgRv7c/ng9LHE0dyzGR4PdEreje9Rkrup8UtQlB+yLsvn59Tz55JrPGMQ1pMfjLfyJi9dp+/gmtNTL5ZOfsFt3AKQ/DYgPNdZUuU5L8/JpKx0Bls448UcY5IwqmZmN3rsog1GDe4pWMDSkA7QzL+NI/9GR0SUlfJcLFGsFbw0lpMQ53koMFOCaVoRx488VNN8+CYl2hkWeS/K7WXpxQdEuMoaxR+4g0XcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cWddY4Q6qqsq/LH/mjnyD+YLS3YUR2OiGTxkBsj+yPk=; b=RbluK424aAwuJ5ulBgLa4nWxWLnfDlcV3jRpI5Tp3YMUQC+arYoVLADTWs5OC9p8g48EQ2/2FSVDc5muycDaKzaB7QdSu2ccnYo6SEAVr3T1uUf5oGVn6Q5nQm/FI5iFx1hzaKfLcQeeQgaXFSMZlqDLO3iP9LTj0EZyRAhb3lr5zmvr/ub/xBZOvj4uFe4uWFnE2x1KWECA/MFY7Etko2gmbAZMXn2/sqirO/FOWGzk08iGIKmo54t1b25O4qT91q6BwTqtavhkDL3T6jVoC8blq1zef36e7l6J/uHlpiz678eRDdZKLsxHLiDJDn3bfrCsNdDX8TndJkFeDafotQ== From: Dario Faggioli To: Juergen Gross , "marmarek@invisiblethingslab.com" CC: "jgross@suse.de" , Jan Beulich , "andrew.cooper3@citrix.com" , "xen-devel@lists.xenproject.org" Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Thread-Topic: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Thread-Index: AQHW93b4k3weXeYNNEuLGR1VNLs/K6vMZmaAgfCc0ICAAYdDAIAXU1KAgAANeQCAAY5wAA== Date: Wed, 7 Sep 2022 12:21:12 +0000 Message-ID: References: <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl> <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> <919e328a-000e-0eeb-2253-6a4381b5ccaa@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Evolution 3.44.4 (by Flathub.org) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|VI1PR04MB6814:EE_ x-ms-office365-filtering-correlation-id: 64aeb0de-6795-4d0c-de93-08da90cb7430 x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j2mAGkKARt96g5GF867JznD2xRa8HQ81auclpQKRWMCk81UvMTcJQcvA0oV5Dx5qAy6qaFmNjFDzH10EcTbb3jcckO5KV/EqXVOCj5xUEDgOvd9w5cP0/0/sDtJgys2c1rgPAEZYvD+ofABOJEnKPJulncAgUZi3rSyhTVKsHVJ72ZkpoTRmOgQX8CuiSfIMacO1uK5OkigEhdDWDXFKS+sz45ghpBgrsex+eX0p7LTHjhRXKIb3WcXrgAWHfQ57UGYLyxEHHcDMXluo5uBLby9DxdUGKo4o/yBVcaFg9U3rRpjEElf0emnZbntcJq6AXOtXnyHyMuiSs+w++45oLQQSqdyuMoxQfTbJuqFav2ZyUGhPduHrNFs2agR9GhgPL0POjYsYtz6BHDyz2NtfmqYMVQDkprkKjEfuc6vPMOrpfeiKBUb6nj5HfWf+G6gqNS+78bBGzb5+QQMQYeNa0lOp/A3P6M5tAJS5lq+vLZrfhY3HL4sp66nv4zyn3NtNhr04RaMxudooMr7QbDRwnxFOyQ9TEYdblBhI/CpKREOC5ZRJd4Mj7A3dRuDigUXhL/ERFCTYG5PS7skUtritFZd/RFSVC8SswwtfoflCdwjintVwgV2GMdhGFc1bFpqA7NW40YgKN3HqXBcBUi5U1C23CiRqWo6yjoM90rRByP8IIl/4FXd/RPd9o4jkBLZi9osLDpKqhjwIj4QPIvF/r74fa1dvXYRkziQdkWzn6Ec6i7WzdWLKla+rFvHklIWNJfqvJIGvG2lu9MjlDCSrhc7kLICPh2e0xDylsqK/zyIIPApQlSvHIpQA+rJMdz5w+9lwm6PVAkJfVJ57fzFJDQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(366004)(39860400002)(396003)(376002)(110136005)(2906002)(316002)(186003)(66446008)(5660300002)(54906003)(8936002)(4744005)(4326008)(66476007)(8676002)(76116006)(64756008)(66946007)(91956017)(36756003)(66556008)(86362001)(6486002)(966005)(71200400001)(41300700001)(6506007)(478600001)(6512007)(26005)(2616005)(99936003)(38070700005)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UjhreU5LMU45UlpFSWY3Z3EybFM4bG1Qbkp5M0FZOGZ2TSttbW92RFo0dUF5?= =?utf-8?B?RklBQzdsRmtWNnpId2hPZllIUFMrNWZROWJ3TmM5U0VBMFdqeUlYYXppckg1?= =?utf-8?B?SzdpTm9hZ2l5MS9vaVd2bVBhOUR6NFQwT2NGVlZSSXpkeEc4RGtxekw1ZHpz?= =?utf-8?B?WVZWNXFCZWdoTjJZMC93SDRKUG9HeVhxOWRKMk1xR2VhYmFOVlpiMmQ2MTJs?= =?utf-8?B?WjM1V0hNNW56ZURsUlEwTnNORlZUR2MwMC9xeEtFOHlVd2pMSSsvNmIreXMz?= =?utf-8?B?WjkxNHhORm8xeWxKcThRdkk3c2hoNmdYd0NqR0tHaTQwK3JidUlrSUluVmts?= =?utf-8?B?Wkt5ODYxcGxGRHhlcmxkL1BjdXRZb0RlTkVwN1V4SVBzZUlHY1dNcllXYThG?= =?utf-8?B?NklDV3lFVG1kUmhrdGNnYnpvWERkNGx3UWpuVGVPMjJNYUhoMTA0amVSTHVW?= =?utf-8?B?WDdGMjZOR3MyVW9DVUEzemNMVC8wUTdYZHU0S0FiWi9xZkFSc05SSndEL2Vq?= =?utf-8?B?aUNvamJBOVpQMFo2ZDJKaWEyZDhtSmN5b2ZLTjFSNHdxMXBnU3FrcUNwd1J0?= =?utf-8?B?bm9Sc0I4V3VENkMrR0tiTkp3VWtlWFg3MGd6bXVJTmswVXRmaXVHZ1FTRDJM?= =?utf-8?B?enhZd0d0TWNtNVExMkpxS2Y5WjY3RDdQTHU4aFZHV0paQ1VsWmt0bjFwZXZX?= =?utf-8?B?T1lhMUc3MkZ5VFByWmtKQjJwZkNSUmUzbDlrdHdOc05mUkQvRkp6ZzlCRCtC?= =?utf-8?B?aTBraHdvM2orWkU1dnRBY1VqMWpaWElacXM2UVQrNzVTT0N1cDFURzJZK09v?= =?utf-8?B?WU5vU1dSRHNIYjljRC9YLzdreGRLT3dqUGFIaTJaUzkwMWRHUnVMTThVRmkw?= =?utf-8?B?THQzRjdNUDc2OGc5WHBoZ051OThzYk54UmQ4bDR5TzZBYjVxRnBpT0FXSTdO?= =?utf-8?B?WHVHQzhqSFFUTXh5SmFLZXFmZzF3UkdtclREU240TFI0UG5ibDNuWmNRTldC?= =?utf-8?B?SkV2UFRRZm1vMmxoYk9UaU1BSkovQTc1RjJuZnVscHI2TkR3TWFNRlhjbFUv?= =?utf-8?B?dTM2RUh3bC84ZVlwVFYrZ25POHdMdC9YQmhvbmFGcmFpckgyZDVsSGg1YVBT?= =?utf-8?B?QUlRcnJ4dHNZem16WFdqamJjQ0FkRkhoMFczQjRpOEFSVDNIWUZYOEtBN0xm?= =?utf-8?B?NDg2ZDRYWVlGeVJkYzV6dlF2SlA1MjcxWU1zMmROYkpEU09tTGltbmpCMkQ1?= =?utf-8?B?WjJxMFZyQlRRT1p1MTV2UG5UeXRhZkFHQ1l5WnJNQU1SNE5oNnhjR3d2dVZT?= =?utf-8?B?bHM0WndyczVEd2FPS3JlQUpFUVZpK2tqK0IxZ2FiOWNTRkdpNkVVa0sxTVpD?= =?utf-8?B?cmtnUmhtb1FIc1h0ZmZRTFk5YkszbXc1dGhnNG5uckY4QVNvYS90SWNRUFd6?= =?utf-8?B?a3dQTUFrTWlXbWI5WkVLSXRpR2RBV1ZnU1hzeEtkK09GZW5sblR0d0pwT2F2?= =?utf-8?B?aFlycDQwTm1UV1RJWFBYdjR5Rm1iQTlwWDJLSUJ4YkordG8wUFd1RDlqbVJv?= =?utf-8?B?UnN5dlBFVXYwYTJIeENTNjhhMzhNZXZDeGxQMGpORHJjeXhMWFkxalVZUEsr?= =?utf-8?B?QjdTQTdMNkxYK1h6cStnT1pZVWxGQnRmRlFoVW4yeU9UQ3ZzTzZaVkY1Tkky?= =?utf-8?B?MXMvNXhwSlZScFRPaDBBSUpjWHJlV2xtYW9JWEQybkdBUnFKVzdOODIvRU80?= =?utf-8?B?UkovMncrS2lCM2tWcHNxejMyNm9CYloydkFDV3ltRUw5VUtsbkVIbG56ekJ5?= =?utf-8?B?eWVEcXo2bjUxY3VPejJJem4zd1JGbGsxS3lJSXVaNjBrQ3hheW1ZSjdjalVP?= =?utf-8?B?Skd2Q1duMDA2ZHk2VWJXdnlSa0pCNXdEaUFFMGFpL2doSU44ZFk4TExFVVo4?= =?utf-8?B?SmhLRlgrVHAzTDJHYUVWbCt0YkN4b2NkVnMrdXNlSGVERXFRNmZRUlM1dEZN?= =?utf-8?B?QXdXMVZudW9haGVTTmpBOXcvQ0RjWE01M3pidTBKdFJZaXUrelFiNXc5Rkl6?= =?utf-8?B?SnlOQ2lDOEplYkF0cG4vU1Z2Uy9OMzZQZnN4elZtNCtUZWlQejU2Z0VoOFBi?= =?utf-8?Q?v9GVZ66OzA40YCJWmYjdoAf1k?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-iwByakttiUE7SAqSE2Fp" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64aeb0de-6795-4d0c-de93-08da90cb7430 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 12:21:12.7841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ygr+qBmmbamtwReA/6LtvX4N7Has4MuZTlEx+fbaSVlWpwee4UecP/EppDbdjWn54fAuzvj5BJNzApHVEIZvPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6814 --=-iwByakttiUE7SAqSE2Fp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2022-09-06 at 14:35 +0200, Marek Marczykowski-G=C3=B3recki wrote: > On Tue, Sep 06, 2022 at 01:46:55PM +0200, Juergen Gross wrote: > >=20 > > Could you test the attached patch, please? >=20 > I did a test with only dom0 running, and it works now. It isn't a > comprehensive test, but just dom0 was enough to crash it before, and > it > stays working now. > That's very cool to hear! Thanks for testing and reporting back. Just to be sure, did you check both Credit1 and Credit2 and do they both work, with Juergen's patch? Thanks again and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-iwByakttiUE7SAqSE2Fp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmMYjLgACgkQFkJ4iaW4 c+7Rjg//UP/9DiA+iUvb3QE2QLKtgf8bzYBtlhNfRZY+Gf1DcIFXzeaXNddpdrpy 79Q2FtsD4FWTXZI6XC/fkhnbDTLzOoTobmMDUlcVZwSq+eVcgi6yO/MkwvfwrpAm GhnheIywZtt84Xsr+s8H5jKGbtMln1tyBuH2GHGiu1rryc2KyNQs1DVfpnZg+FoK 3S7CMDCpRlubsYn5V74X+PQVsbaB96ifuDRsS3RUbkBjmCxm7PPnoTrX+6KO5pXS 2Vtfxp4PfySALSUt7VuYohelp//qC1n4lGsLXeKsKiteJGdCNmmUoYTRl0HAvvMS yhGDKqaw1jdS8kbLhSun9odqHyy9+IciF7fCwj4ejpqOW13zD2GBBNyxNrJLZVEy //XtUKltQbGsPIPICAJ9AmKakutj8jpVfPUOyXJdyOmual8BpTXb7pSk+c7wASSN 4NAeYyQNR7SiesYDvWcDBGkkhJmoxcrMqAk+ImewzQUpZK1+0sAcIXv5Sl50f7qe yc6xiqguIrDXHW2aSILmmBjIQIa2EHoeJ4xFXNHXKMLy4xQeSNT/cS7qbIFHpCOx xHJ3BaMyC8YK0s//iEUAKrAQIuJURNklfDrWMqOLJQfl86rNY0ZiJ0WLPbBUe2e2 oMB5miivt4bygLf+7WOwyUihCoAQnbFZajRjeVzON/MEuufaeIY= =hKzN -----END PGP SIGNATURE----- --=-iwByakttiUE7SAqSE2Fp-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:28:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401526.643366 (Exim 4.92) (envelope-from ) id 1oVuAr-00054K-HJ; Wed, 07 Sep 2022 12:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401526.643366; Wed, 07 Sep 2022 12:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuAr-00054D-Ei; Wed, 07 Sep 2022 12:28:57 +0000 Received: by outflank-mailman (input) for mailman id 401526; Wed, 07 Sep 2022 12:28:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuAp-00052W-Lq for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:28:55 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a29f3444-2ea8-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:28:54 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id fv3so8271697pjb.0 for ; Wed, 07 Sep 2022 05:28:54 -0700 (PDT) Received: from leoy-huanghe.lan (45.78.11.189.16clouds.com. [45.78.11.189]) by smtp.gmail.com with ESMTPSA id p66-20020a622945000000b005361f6a0573sm12465605pfp.44.2022.09.07.05.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 05:28:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a29f3444-2ea8-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=+HuSoWX5VQPvHtd0Wmv1YHN7SQPTvjy+G5KMriA4428=; b=iBDXAO+AZG3AfpN/OZkzvVXvs1krk6KaDQAPRXDg42atHYaaXTqPmmuEm/Gkl3728Q TLi3E9UdA1f0zamPUrTcR7btXMXQ7iLlBkKYyB4M9t7ZBAYMxk2EdHUEqocGsp5/10sM e51Qw1EsjWXO0KD30NNrWRZ0RI4MU/C3k/QY28XnMYS3pe9Pvan69IJxFB7m4BbnOZ+C 6xZWv83lEsngsLau+960mL1d5HlSp59i4g39m8YUFXuRHttECXcKs11ZTJAwm3NRy5Jn kpWW21o1LOhjn3ZLeHBWBnRpEIE/mxN0uB+aS0CsgqDPFjfltFMkQ1vBk7KAXU0Kzm+a ntbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=+HuSoWX5VQPvHtd0Wmv1YHN7SQPTvjy+G5KMriA4428=; b=ixWrmJwltLXMIoumhZjEhxD41oTEGLx3f1ekMU/QxcDRllRmG5/CWB89SdJqxEt+6W Efn7gy4xLBfjfb6dT+vx4ePkCrkanAWWfveTb49WoygMnH1gR++YW9d36TPbBvjHKwnN Nw5ZBDwqMFA8CAi5ZmfDKs8B7Pb3hBi6f5Lfpjthv1irah2J8BBrIt4RRASPBvCtFEv2 h+OmhUZAHZZFlhux0oME5XQFfi8w+dita1859CQxtZ2hnyQXYI/Wni8CFNA4/0UOLrfy PcwYA6XWmd00hyUzoJBlRuqSr5p6l4ttVvmEI0MfVD2diUyid/QXrU48oBZJVZJELIEy /b6A== X-Gm-Message-State: ACgBeo1+8H86CzZHk/kOM/dY6n0eYXWC8X4sbu9nRU+YqLdC8rHNkuir DT2zSVeKFKcqxVIZ/Okp1xZtCg== X-Google-Smtp-Source: AA6agR6x9i63zIoe1HooAbbEBPEh8s9TrBDdmMWT5EJG9DZpqDm4L3lCj/pRq3m6v0YF1AkBKMRUOw== X-Received: by 2002:a17:902:f68f:b0:176:c1e3:3ada with SMTP id l15-20020a170902f68f00b00176c1e33adamr3736019plg.74.1662553733032; Wed, 07 Sep 2022 05:28:53 -0700 (PDT) Date: Wed, 7 Sep 2022 20:28:47 +0800 From: Leo Yan To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen: Add macro for version number string Message-ID: References: <20220907120420.387771-1-leo.yan@linaro.org> <40400a52-b55a-1c35-5ee8-32ebfb08bc28@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40400a52-b55a-1c35-5ee8-32ebfb08bc28@suse.com> Hi Jan, On Wed, Sep 07, 2022 at 02:12:25PM +0200, Jan Beulich wrote: > On 07.09.2022 14:04, Leo Yan wrote: > > On Arm64 Linux kernel prints log for Xen version number: > > > > Xen XEN_VERSION.XEN_SUBVERSION support found > > > > The header file "xen/compile.h" is missed so that XEN_VERSION and > > XEN_SUBVERSION are not defined, __stringify() wrongly converts them as > > strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". > > > > This patch introduces a string macro XEN_VERSION_STRING, we can directly > > use it as version number string, as a result it drops to use of > > __stringify() to make the code more readable. > > > > The change has been tested on Ampere AVA Arm64 platform. > > > > Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") > > Suggested-by: Bertrand Marquis > > Signed-off-by: Leo Yan > > Reviewed-by: Jan Beulich > with perhaps a small adjustment (but it'll be the Arm maintainers to judge): > > > @@ -91,7 +92,7 @@ static int __init acpi_make_hypervisor_node(const struct kernel_info *kinfo, > > struct membank tbl_add[]) > > { > > const char compat[] = > > - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" > > + "xen,xen-"XEN_VERSION_STRING"\0" > > I think readability would benefit here from adding blanks around > XEN_VERSION_STRING here and ... Agree that adding blanks is better. Will do. > > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -1367,7 +1367,7 @@ static int __init make_hypervisor_node(struct domain *d, > > int addrcells, int sizecells) > > { > > const char compat[] = > > - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" > > + "xen,xen-"XEN_VERSION_STRING"\0" > > ... here (as an aside I wonder why these variables aren't static > __initconst), just like ... Will add blanks. > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -1341,8 +1341,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > > efi_console_set_mode(); > > } > > > > - PrintStr(L"Xen " __stringify(XEN_VERSION) "." __stringify(XEN_SUBVERSION) > > - XEN_EXTRAVERSION " (c/s " XEN_CHANGESET ") EFI loader\r\n"); > > + PrintStr(L"Xen " XEN_VERSION_STRING XEN_EXTRAVERSION > > + " (c/s " XEN_CHANGESET ") EFI loader\r\n"); > > ... it is here in particular for XEN_CHANGESET. > > The other general remark I have: Please follow patch submission guidelines > and send To: the list with maintainers on Cc:. Ah, just now quickly went through docs/process/sending-patches.pandoc, thanks for reminding. A question, since commit 5d797ee199b3 was merged in 4.11.0-rc6, for fixing it, should I explictly add backport tag as below? Backport: 4.11+ Thanks, Leo From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:31:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:31:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401543.643377 (Exim 4.92) (envelope-from ) id 1oVuDl-0006gB-1h; Wed, 07 Sep 2022 12:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401543.643377; Wed, 07 Sep 2022 12:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuDk-0006g4-VD; Wed, 07 Sep 2022 12:31:56 +0000 Received: by outflank-mailman (input) for mailman id 401543; Wed, 07 Sep 2022 12:31:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuDk-0006fq-77 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:31:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e8e9dc5-2ea9-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:31:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7214.eurprd04.prod.outlook.com (2603:10a6:800:1a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 12:31:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 12:31:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e8e9dc5-2ea9-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NmTNmTSXQHOCrpRRUkV1udu0YPZzYsXfFp2zPKONVyC9mv7Is5vL/izpoK0a64yBV3T6uHFCZfuk9ygMex4dBeJGjvzalKRt2z7+x/oqBI2Q7HiJSLfrANLKcueq8NNOgPvuusiOumn5+9XQYh4itMmcfj7cL2ABL63e/AAPW64OpENmWs2h2lL0q6jB9819InegBXdVxvKSLFgtZ6fOy5WJyyq3lwRfwiK5WriH4/S1qRPmO6jcKhztxoVw2DQg2GdKzca9XBil2sGGDC29I/BHQcqpQk9hYu0r6oxYLGjNTiGnqvYCe9pHOuW4ide/5EJ17pGT/TC23cw16NdUHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UIvXPr+ouhMhmYAKcaRDHzakg7Pki169nWAteGKVUZ4=; b=Ch8ZWkZBJbxsHTsAbrx3HDckAWqevUkmbhp3z6hgLxvrXy0tlpuzyjnXIZd0mgJjNhH0rAvIgyri0b6WKdGtg88LP3qMHsM5xg3lBR9IlA8UxSUWK9QWIyQf7AiZ/iTxNJ8VZctV3EpBUtyoI+1s7uLZ5iVDzpulqAbVSHqzbWC4VQCs4WmWXbkKqWkg+FDIEdIcko5rjwR8iatZNzFfAxa6z+BCCxE49gMWS+78zpt4nD2FHQcEzx7RPPsUFj/jldQackd+xPbwfWH/8C1YFEVkgpIt7UUQ6EfN2B8lWgxSRwyAElzWNh8fBYmyJnDKNK4BRBm4uXAFGhHOdMXqvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UIvXPr+ouhMhmYAKcaRDHzakg7Pki169nWAteGKVUZ4=; b=PvCDBwL8K7nsdokjPLGtwaHDa4fD/1hOlU1ueP5ZguK6DM3qXIj/I6+M0xbNZCqOF0rHQPcO8/rV9ZFU1o4GTqbJQ9Gk2tBGPiyTF+L8a4eiQ0Kf0ziSo/Sbabu7Sp5lNHmA832WiOsiJNulpjbb62Q4n99YgbZTHnIEck/NMnYVQgaUc7NGyEvJd94fxON8PGTRbI5ocV/MnQmw2WlYy2n6jnR5VBVBu8kjQCB4IVyFnPxjKtfPPSp/l4zyKzgpZDJIspJzw73bjivFWEuV3KGPLdNg7lJTxduc9tksAVH6h+GwJV6Edap2yaOBgEfa+QbLKlMOVy0PzSNtd+K+9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 7 Sep 2022 14:31:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen: Add macro for version number string Content-Language: en-US To: Leo Yan Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220907120420.387771-1-leo.yan@linaro.org> <40400a52-b55a-1c35-5ee8-32ebfb08bc28@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7214:EE_ X-MS-Office365-Filtering-Correlation-Id: 901d3266-d637-4369-b1c5-08da90ccf228 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VeOjuDvDgdAo0vaDdBKOXMDScWd8OU9N19guHoJh1ncF5efC84RUQrmpA7VjV09de1XehD4zcGTisKUBWZrqtJE9qWshdeovc5RHDatCVpz7jKGyt/emL20snYhS0OuQUkV925RZBy9ANj12wkN3g8s32M1a41JswxYGaefjOc7t+P3C7tpB62EdzTnsOPOOC2Qo5lyNAj0t8nhSoFICMc0L69o4SmoO1pjckP6F9VPDC6g+7dbkOoh7diSZ2L/WQZasnDNMz8WcFjuVdqNx1ASvJVk78Dtv/Vv2txbySpf50O1p9tcemyMIm71BpIO5ifXyEob4cNUCWMAyMsjHwGiMq0uZ9nZ/vdEHxeslix07YOkf5OIQ/bPkIgHeU964b0g7BvMuobHNBfl0D+VI0Ft1mbhDeh8nZwLU8ug5zC+1nZXklHvy9axvjRLUOMrw087wSNLMNhlVORUoAeQ2hpq2BOZcIY2niAXQaJjAvWJJZSdf1xe39EMHDqlD8oaNI5iOvHDihIlyy4ZS2gymjM9I46028l8KqMmCeOu4o63OJgVihwWd39V4h21lSuhFQbcq0NOKmfNNciKKaNYj3CzltH+nGMu/07sEMTsmcmarutlT8SQz4i/LDFYzqaBPbMFh1IznBQB87sZRzCiHxXB2ErvOqnRWo3Qd/L7GdRNxOoTjYf0xY4OS4+5ZuvQZimvpqpZkzoW65QOF0Kxs0ubKAgyotGw85yizRDAgnTvwvcPVPa38dlnSEBoabrNP3sYMgVc4BVKoFYEFPbN4UrPiXf7inSMWEGBSWGEmh1I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(346002)(39860400002)(136003)(5660300002)(2616005)(53546011)(8936002)(186003)(4744005)(2906002)(41300700001)(26005)(6506007)(31686004)(36756003)(31696002)(86362001)(6486002)(478600001)(6512007)(8676002)(66476007)(66946007)(4326008)(54906003)(66556008)(6916009)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEwyd0pKd0dvelFOaTdidHMrMjJndDV4dktsVUpISXNYdHoxcjAvdmpvYmlu?= =?utf-8?B?TTFWMWpFZm4rajloMElwTnMxc1RLVWd6WU03Z01vUWJEWnhEOWtCVkhYTXVz?= =?utf-8?B?UnkvOWZQOTkvcHlBTTR5M1NMNXROeTk1Qk9lMkozVkg3WWNpbDNFaURyL2g5?= =?utf-8?B?TDZRYTV5bmhMdGZvalFhemJPcGJURHB6S0R3Z242Vis2dWhSOGN4ODZuRG03?= =?utf-8?B?ZEdqYy8wMWtQTzh0L1UxKzd3aFJTVExWcWdVYmV3MzBHWTVqRDdkbDZNLzVS?= =?utf-8?B?Smo2U1kwQXM0YWpFSFJ6bk1Wa1RYSWkwV2hqZytPYmhoTWlxbzhOOFBKNkZw?= =?utf-8?B?M0VjaHRsTGoyWTFObFFMVHM1RzVkd3BFU1IwZnRQYjc5QTErb3VqL3duRTFt?= =?utf-8?B?Q2FiQUJEMEJkeUNzMkFLR0hiZjhDaGJzUEZDKzYrQUp1OFlMSHZZYTVNQ1Zr?= =?utf-8?B?QUhFK2NKY283cXkrb0JwSWthNm1zLzRYbVpVdzJ6bHkwb2dtcWZsK3RmcUxW?= =?utf-8?B?Z0docXJlU3dZM0YvRTkyTDM4bVVIOFVJVkxkWXp3bVowNWpDR045VkJiRytX?= =?utf-8?B?TzM2WGlVSnlZVUVEL3ovM0tDbmFaZy9wV2NaZ0JKenErVVA1TUVaRFQwSnls?= =?utf-8?B?c09oclM2VkdkTlFtZ3V5SW1jd1pnd2YvdnRLci9MWUhZUmUxSkNPdTRkZmh5?= =?utf-8?B?ZUtzSGh2ai9XSFJVbG1zSXAySzduSHNZVzNsNEZHUVhwMG5oeXhBRlFaZ1ZY?= =?utf-8?B?UzRmQVBNTkZUYzRiM3BuRkhRTHlKaGJDd1g3OTh4aEw1Z1RWNG1halVPUCsy?= =?utf-8?B?U1gwelZyWk1WRDZvU0YzK0l6U0FON3gyOVdqNlJjSk5mQUE4ME5oY1pmaC8v?= =?utf-8?B?ZEFKQTdpT2hmcjFkOFo4VkQ0a0hnMW1MOC9VTDlOOUtPd3U4YVYxWjZOWE40?= =?utf-8?B?bVJEeWlhYTJBMkJ4NjE2MU1ZTVhDNGkyQjNaWWNyMUlvZDZQUHFHZzNqdVVt?= =?utf-8?B?LzF5UzlXNHljdXVmS2Z5S2RFL3c0MkptSW9SQUFld2duT2Q2YkJPS1p0MVFZ?= =?utf-8?B?ZUE0ZE5RMTJDcmtRSHdyV3Y5RXhhWXhKdU1PWitRYW8rNlNaaHpNVmJqMi9K?= =?utf-8?B?NGo0dmZ1b1huMy9uRVRqZmpTWXRqbnVuL2RJUDZRenhlVmdOK0pyUWtBTXFK?= =?utf-8?B?MTdFZ1RZakdkRU1DWkZJQk95VXk2RXU4Wm40czl5c3R3WUR5T2N5T0RsTldk?= =?utf-8?B?S0xEdDZwanBVMm9TamowNHRHZlBBU0pJSDlsRzZJaUhadW9nNDhlM043SndE?= =?utf-8?B?K2F2NzZORTlpdHRSR3lmL21Rdm1qQzdic3pKZE9BbEVTQ3dhTjBzR2IyT3pM?= =?utf-8?B?SkZzTExQTHlneWx2Q3pIMUZMWmVhV2lDMXh2b0pjMGxUc2J1TzhKSXJUQ0Rh?= =?utf-8?B?ekN3b2VybzVwNWI1UTVPNkVhNkJGdUx3V3RnN01wUkE4RVUrOUM0OW56Q3hT?= =?utf-8?B?RHNOUlZXRXVySlI2MUZmNDVkRXp0R2xFc0lrdGNkd1E3UER3TE4reVp0NFBO?= =?utf-8?B?blA2OW1xS2tDZ2N1OWh4M0R3amxTUE5GSWVIS0FLSmxMTEN4NUE1dTJ2cldB?= =?utf-8?B?SmM4eDVqWnp5UmhEa2tVOGo3RWlzc3AyZ044UjQyVEtYK1FHd2RJYktxQ3VI?= =?utf-8?B?cElaWld6MUlIVGJPMFhnM3p1M1dDVldsdGMzd2tpa2VGNjRmVjRHdEdmdmR5?= =?utf-8?B?TW1VYVY5bllDWDBsOWVsSUFwbndIS0ZDbkRyYnZKdEROOG5nRFF1L3c3b3V3?= =?utf-8?B?YUNWY2l5OW1ja2tDeXJKNkVucUs2K21JM3JRSlpheFMvTGZ1Y01lWG5VcnFL?= =?utf-8?B?b01nb2V6eG9mVUdYTThLVE1HYmwzeEtMM0dKWTJ0dWlJM3Z3TVUxTEY1aUcy?= =?utf-8?B?Kytzam1FR1ZkTnk0aUg1U2ZlUGF0MFlkNTBVWlJ3TGN2NU4zS053SGQ2Zmhv?= =?utf-8?B?Rk8yNzdMVTNoa0JkVDRJS2QrbFU0MHVXMjM4SWhhNE5WaDBTdHljNG9KRE1n?= =?utf-8?B?M1JpdDlUeHA1YmVjeUlOeHpJS003WW4wdVRCc3U5REhLTlpiTW45QlViYm5s?= =?utf-8?Q?CWzZkOoGJ0+2lRGYJHWES2f4M?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 901d3266-d637-4369-b1c5-08da90ccf228 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:31:53.8390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Enqjt7u87Vrgr1KNwDnKJCYmIRjnJmmfsPyJ56sgeTDtEs4wmOqsLtqW3AYXqvmzO9MCrLxBC2pRY4mwJUeh2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7214 On 07.09.2022 14:28, Leo Yan wrote: > A question, since commit 5d797ee199b3 was merged in 4.11.0-rc6, for > fixing it, should I explictly add backport tag as below? > > Backport: 4.11+ That's up to you, I would say. We don't really use that tag all that much, the Fixes: tag is more relevant at least based on recent observations. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:32:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:32:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401544.643389 (Exim 4.92) (envelope-from ) id 1oVuDx-00070b-9D; Wed, 07 Sep 2022 12:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401544.643389; Wed, 07 Sep 2022 12:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuDx-00070U-6E; Wed, 07 Sep 2022 12:32:09 +0000 Received: by outflank-mailman (input) for mailman id 401544; Wed, 07 Sep 2022 12:32:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuDw-0006zq-1i for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:32:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuDv-0005Aq-KJ; Wed, 07 Sep 2022 12:32:07 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVuDv-0000ID-E6; Wed, 07 Sep 2022 12:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QLUPRD+hrCaiP40mYsr/vDgpVae2cAsYLGRi4dS/GFc=; b=eVv0PAiDBoTh36nwRFmW+162ua jNZAkXBF+hwS7cScYPuC2vOnpzV+GoCumsNxaDcv4CHPSL0EP054os0hYsX/lzNkFXj6Asb0Iwj4R QkxqNzxPyCf13i4XkS9obEivyrcKe9L4xkk5RCtAVTmhj0HCWFenHidqwXvV5rJRYuIE=; Message-ID: Date: Wed, 7 Sep 2022 13:32:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Michal Orzel , Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> From: Julien Grall In-Reply-To: <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 13:12, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 07/09/2022 13:36, Julien Grall wrote: >> >> Hi Henry, >> >> While reviewing the binding sent by Penny I noticed some inconsistency >> with the one you introduced. See below. >> >> On 07/09/2022 09:36, Henry Wang wrote: >>> +- xen,static-heap >>> + >>> + Property under the top-level "chosen" node. It specifies the address >>> + and size of Xen static heap memory. Note that at least a 64KB >>> + alignment is required. >>> + >>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>> + >>> + Specify the number of cells used for the address and size of the >>> + "xen,static-heap" property under "chosen". >>> + >>> +Below is an example on how to specify the static heap in device tree: >>> + >>> + / { >>> + chosen { >>> + #xen,static-heap-address-cells = <0x2>; >>> + #xen,static-heap-size-cells = <0x2>; >> >> Your binding, is introduce #xen,static-heap-{address, size}-cells >> whereas Penny's one is using #{address, size}-cells even if the property >> is not "reg". >> >> I would like some consistency in the way we define bindings. Looking at >> the tree, we already seem to have introduced >> #xen-static-mem-address-cells. So maybe we should follow your approach? >> >> That said, I am wondering whether we should just use one set of property >> name. >> >> I am open to suggestion here. My only request is we are consistent (i.e. >> this doesn't depend on who wrote the bindings). >> > In my opinion we should follow the device tree specification which states > that the #address-cells and #size-cells correspond to the reg property. Hmmm.... Looking at [1], the two properties are not exclusive to 'reg' Furthermore, I am not aware of any restriction for us to re-use them. Do you have a pointer? Cheers, [1] https://elinux.org/Device_Tree_Mysteries#.23xxx-cells_property_name > > ~Michal -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:32:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:32:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401551.643400 (Exim 4.92) (envelope-from ) id 1oVuEK-0007db-Jh; Wed, 07 Sep 2022 12:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401551.643400; Wed, 07 Sep 2022 12:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuEK-0007dU-GB; Wed, 07 Sep 2022 12:32:32 +0000 Received: by outflank-mailman (input) for mailman id 401551; Wed, 07 Sep 2022 12:32:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuEI-0006fq-V0 for xen-devel@lists.xen.org; Wed, 07 Sep 2022 12:32:31 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22aa3ed9-2ea9-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:32:29 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id s14so4789673plr.4 for ; Wed, 07 Sep 2022 05:32:29 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id b6-20020a170903228600b00174a4bcefc7sm12257363plh.217.2022.09.07.05.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 05:32:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22aa3ed9-2ea9-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=gaf2Ai+4pfK/vxUpvtg4CvsU9IMKntoNQgpDE/R9+Ms=; b=UVwK/jr9C3HcbKjVP7f5N8Ro0hYhG8ttPuhaHCkZzfkDpUCnhoEsM18UFQ2lpaABPg gRF+xLe/lZV2CHO9iVoLdNhRxXtuVSxStLt2uTpY1+XueI8LIxLkkfgwHnbx+XeAaIS5 lZrkUqvXSF4prdzJJSO7jMnsj40QMvJTckDGml9e/oNmbgm6gGWMcHQ6ia6F6g/cqOCt ATWUZiTQhHADl8WWyrKprOCfwIvjuAwVF6pdF/YeCeEAcMUabrHHhpFD5p2Yh/ZkiYM1 ks0K8LHqQZjnBKvPtnVKWExIp6lWTPhuFa0zvRo7Zshevc8NwzaQdgRptBJHLdp98m0l /bMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=gaf2Ai+4pfK/vxUpvtg4CvsU9IMKntoNQgpDE/R9+Ms=; b=xEw5t86n2LjJylA8qk/Z2JpL5YvlUVLKbWHcz9t8BrevCBTKsUdFv7bWWlOQpv0evN Y3KCu7slqS85kkl6VyqoZsF3DCE7X5NZ5gJ+jJ/KSJjNrAC9NzyWOmHBj99fO/dqUZ5r 7Sxif9/yyWD3E0OBCHvQ4g40qlerQ61MJAmxwnGJ1cUmuCHHBq4atkyjykf2FaQlV0pf ma8ixBvQJE3pv6xOBGFqhhlYz/fBZXX+9j9rzX3k8i5AMsYONF0uWE1dlFb311SXC5w+ QeNkCoNr4eKCCuKzMwDhTVm4PHrlpzhZVFb0tfes1P/4kO0WOIOES2yju4Y8V/yZLyuO OqdA== X-Gm-Message-State: ACgBeo0Kufi5TIZDiVa5n0IQVVHjwTS/LmNU1cfP2We1T/swycsOwUda lY8587mJYX97lXyFkv5mHDkk7g== X-Google-Smtp-Source: AA6agR5qPemPA+OXGqUYAD+8RFHbcaRSPCHqM0D9kUa+2dgVF+NGLo8rcjrdyek7lAfR38CeKxzHDg== X-Received: by 2002:a17:903:268d:b0:176:a84a:78b1 with SMTP id jf13-20020a170903268d00b00176a84a78b1mr3681196plb.165.1662553947904; Wed, 07 Sep 2022 05:32:27 -0700 (PDT) Date: Wed, 7 Sep 2022 18:02:24 +0530 From: Viresh Kumar To: Anthony PERARD Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device Message-ID: <20220907123224.rz7vvope37l6l6mg@vireshk-i7> References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Anthony, Thanks a lot for the in-depth review, it is really helpful. I don't have much knowledge of the Xen code and wanted this code for I2C and GPIO to be tested on Xen for the work we are doing around hypervisor agnostic backends [1]. I started looking for a simple device's implementation and began by (blindly) copying code from Keyboard device and so much of wasted code in here, which isn't really required. On 06-09-22, 17:15, Anthony PERARD wrote: > On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote: > > An example of domain configuration for Virtio I2c: > > i2c = [ "" ] > > Is this doing something meaningful (with the whole series applied)? If I am not wrong, this is required by parse_i2c_list()'s implementation. Without this I don't get the I2C device populated in the guest. Is there another way to achieve it ? I have removed a lot of code now and what I have left is pasted at the end of this email, does this look better now ? And yes, I will update documentation and look again at any formatting issues before sending it. Thanks. -- viresh [1] https://lore.kernel.org/all/20220414092358.kepxbmnrtycz7mhe@vireshk-i7/ -------------------------8<------------------------- Subject: [PATCH] libxl: Add support for Virtio I2C device This patch adds basic support for configuring and assisting virtio-mmio based virtio-i2c backend (a hypervisor independent emulator) which could run in any domain. An example of domain configuration for Virtio I2C: i2c = [ "" ] Also to make this work on Arm, allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend. Update guest device-tree as wellto create a DT node for the virtio I2C device. Signed-off-by: Viresh Kumar --- tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 39 ++++++++ tools/libs/light/libxl_create.c | 5 + tools/libs/light/libxl_i2c.c | 117 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 22 ++++ tools/libs/light/libxl_types_internal.idl | 1 + tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/xl_parse.c | 63 ++++++++++++ tools/xl/xl_parse.h | 1 + 11 files changed, 252 insertions(+) create mode 100644 tools/libs/light/libxl_i2c.c diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 13545654c2fc..961bdd33297b 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,7 @@ OBJS-y += libxl_vdispl.o OBJS-y += libxl_pvcalls.o OBJS-y += libxl_vsnd.o OBJS-y += libxl_vkb.o +OBJS-y += libxl_i2c.o OBJS-y += libxl_genid.o OBJS-y += _libxl_types.o OBJS-y += libxl_flask.o diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 2637acafa358..c23ecbcd8528 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -113,6 +113,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, } } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl_device_i2c *i2c = &d_config->i2cs[i]; + rc = alloc_virtio_mmio_params(gc, &i2c->base, &i2c->irq, + &virtio_mmio_base, &virtio_mmio_irq); + + if (rc) + return rc; + } + /* * Every virtio-mmio device uses one emulated SPI. If Virtio devices are * present, make sure that we allocate enough SPIs for them. @@ -956,6 +965,26 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, uint64_t base, return fdt_end_node(fdt); } +static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, uint64_t base, + uint32_t irq, uint32_t backend_domid) +{ + int res; + + res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); + if (res) return res; + + res = fdt_begin_node(fdt, "i2c"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device22"); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return fdt_end_node(fdt); +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -1278,6 +1307,16 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, } } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl_device_i2c *i2c = &d_config->i2cs[i]; + + if (i2c->backend_domid != LIBXL_TOOLSTACK_DOMID) + iommu_needed = true; + + FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq, + i2c->backend_domid) ); + } + /* * Note, this should be only called after creating all virtio-mmio * device nodes diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index b9dd2deedf13..f18a7f829703 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -1797,6 +1797,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, &d_config->vkbs[i]); } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl__device_add(gc, domid, &libxl__i2c_devtype, + &d_config->i2cs[i]); + } + if (d_config->b_info.arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART) { init_console_info(gc, &vuart, 0); vuart.backend_domid = state->console_domid; diff --git a/tools/libs/light/libxl_i2c.c b/tools/libs/light/libxl_i2c.c new file mode 100644 index 000000000000..ffbde41cc62b --- /dev/null +++ b/tools/libs/light/libxl_i2c.c @@ -0,0 +1,117 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +static int libxl__device_i2c_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *i2c, bool hotplug) +{ + return libxl__resolve_domid(gc, i2c->backend_domname, &i2c->backend_domid); +} + +static int libxl__set_xenstore_i2c(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *i2c, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + flexarray_append_pair(back, "irq", GCSPRINTF("%u", i2c->irq)); + flexarray_append_pair(back, "base", GCSPRINTF("%lu", i2c->base)); + + flexarray_append_pair(front, "irq", GCSPRINTF("%u", i2c->irq)); + flexarray_append_pair(front, "base", GCSPRINTF("%lu", i2c->base)); + + return 0; +} + +static int libxl__i2c_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_i2c *i2c) +{ + const char *be_path, *fe_path, *tmp; + libxl__device dev; + int rc; + + i2c->devid = devid; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) goto out; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + &fe_path); + if (rc) goto out; + + rc = libxl__backendpath_parse_domid(gc, be_path, &i2c->backend_domid); + if (rc) goto out; + + rc = libxl__parse_backend_path(gc, be_path, &dev); + if (rc) goto out; + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/irq", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + i2c->irq = strtoul(tmp, NULL, 0); + } + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/base", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + i2c->base = strtoul(tmp, NULL, 0); + } + + rc = 0; + +out: + + return rc; +} + +static int libxl__device_from_i2c(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *type, libxl__device *device) +{ + device->backend_devid = type->devid; + device->backend_domid = type->backend_domid; + device->backend_kind = LIBXL__DEVICE_KIND_I2C; + device->devid = type->devid; + device->domid = domid; + device->kind = LIBXL__DEVICE_KIND_I2C; + + return 0; +} + +static LIBXL_DEFINE_UPDATE_DEVID(i2c) + +#define libxl__add_i2cs NULL +#define libxl_device_i2c_compare NULL + +DEFINE_DEVICE_TYPE_STRUCT(i2c, I2C, i2cs, + .skip_attach = 1, + .set_xenstore_config = (device_set_xenstore_config_fn_t) + libxl__set_xenstore_i2c, + .from_xenstore = (device_from_xenstore_fn_t)libxl__i2c_from_xenstore +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index cb9e8b3b8b5a..a8904cfea427 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4003,6 +4003,7 @@ static inline int *libxl__device_type_get_num( extern const libxl__device_type libxl__vfb_devtype; extern const libxl__device_type libxl__vkb_devtype; +extern const libxl__device_type libxl__i2c_devtype; extern const libxl__device_type libxl__disk_devtype; extern const libxl__device_type libxl__nic_devtype; extern const libxl__device_type libxl__vtpm_devtype; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d634f304cda2..45e3b2755352 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -278,6 +278,10 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ (2, "LINUX") ]) +libxl_i2c_backend = Enumeration("i2c_backend", [ + (1, "VIRTIO") + ]) + libxl_passthrough = Enumeration("passthrough", [ (0, "default"), (1, "disabled"), @@ -705,6 +709,14 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_i2c = Struct("device_i2c", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("irq", uint32), + ("base", uint64) + ]) + libxl_device_disk = Struct("device_disk", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -982,6 +994,7 @@ libxl_domain_config = Struct("domain_config", [ ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), ("vfbs", Array(libxl_device_vfb, "num_vfbs")), ("vkbs", Array(libxl_device_vkb, "num_vkbs")), + ("i2cs", Array(libxl_device_i2c, "num_i2cs")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9s", Array(libxl_device_p9, "num_p9s")), ("pvcallsifs", Array(libxl_device_pvcallsif, "num_pvcallsifs")), @@ -1145,6 +1158,15 @@ libxl_vkbinfo = Struct("vkbinfo", [ ("rref", integer) ], dir=DIR_OUT) +libxl_i2cinfo = Struct("i2cinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ], dir=DIR_OUT) + # NUMA node characteristics: size and free are how much memory it has, and how # much of it is free, respectively. dists is an array of distances from this # node to each other node. diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index fb0f4f23d7c2..b1a94a963dfe 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -33,6 +33,7 @@ libxl__device_kind = Enumeration("device_kind", [ (15, "VSND"), (16, "VINPUT"), (17, "VIRTIO_DISK"), + (18, "I2C"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index 7bf26bdcd831..a9db0b97d80f 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -36,6 +36,7 @@ DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), functions = { # ( name , [type1,type2,....] ) "device_vfb": DEVICE_FUNCTIONS, "device_vkb": DEVICE_FUNCTIONS, + "device_i2c": DEVICE_FUNCTIONS, "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), ("of_vdev", ["ctx", "domid", "string", "t"]), diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c74a..cdf473f4ed57 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -707,6 +707,7 @@ DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) DEVICE_ADDREMOVE(vfb) DEVICE_ADDREMOVE(vkb) +DEVICE_ADDREMOVE(i2c) DEVICE_ADDREMOVE(pci) _DEVICE_ADDREMOVE(disk, cdrom, insert) diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1b5381cef033..243c08aa5f36 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1208,6 +1208,66 @@ static void parse_vkb_list(const XLU_Config *config, if (rc) exit(EXIT_FAILURE); } +int parse_i2c_config(libxl_device_i2c *i2c, char *token) +{ + char *oparg; + + if (MATCH_OPTION("backend", token, oparg)) { + i2c->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("irq", token, oparg)) { + i2c->irq = strtoul(oparg, NULL, 0); + } else if (MATCH_OPTION("base", token, oparg)) { + i2c->base = strtoul(oparg, NULL, 0); + } else { + fprintf(stderr, "Unknown string \"%s\" in i2c spec\n", token); + return -1; + } + + return 0; +} + +static void parse_i2c_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *i2cs; + const char *item; + char *buf = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "i2c", &i2cs, 0, 0)) { + int entry = 0; + while ((item = xlu_cfg_get_listitem(i2cs, entry)) != NULL) { + libxl_device_i2c *i2c; + char *p; + + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, + d_config->num_i2cs, + libxl_device_i2c_init); + + buf = strdup(item); + + p = strtok (buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + rc = parse_i2c_config(i2c, p); + if (rc) goto out; + + p = strtok (NULL, ","); + } + + entry++; + } + } + + rc = 0; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + void parse_config_data(const char *config_source, const char *config_data, int config_len, @@ -2309,8 +2369,10 @@ void parse_config_data(const char *config_source, d_config->num_vfbs = 0; d_config->num_vkbs = 0; + d_config->num_i2cs = 0; d_config->vfbs = NULL; d_config->vkbs = NULL; + d_config->i2cs = NULL; if (!xlu_cfg_get_list (config, "vfb", &cvfbs, 0, 0)) { while ((buf = xlu_cfg_get_listitem (cvfbs, d_config->num_vfbs)) != NULL) { @@ -2752,6 +2814,7 @@ void parse_config_data(const char *config_source, } parse_vkb_list(config, d_config); + parse_i2c_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); diff --git a/tools/xl/xl_parse.h b/tools/xl/xl_parse.h index bab2861f8c3e..4b972d525199 100644 --- a/tools/xl/xl_parse.h +++ b/tools/xl/xl_parse.h @@ -36,6 +36,7 @@ int parse_nic_config(libxl_device_nic *nic, XLU_Config **config, char *token); int parse_vdispl_config(libxl_device_vdispl *vdispl, char *token); int parse_vsnd_item(libxl_device_vsnd *vsnd, const char *spec); int parse_vkb_config(libxl_device_vkb *vkb, char *token); +int parse_i2c_config(libxl_device_i2c *i2c, char *token); int match_option_size(const char *prefix, size_t len, char *arg, char **argopt); From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:33:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401566.643410 (Exim 4.92) (envelope-from ) id 1oVuF7-0008QR-0g; Wed, 07 Sep 2022 12:33:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401566.643410; Wed, 07 Sep 2022 12:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuF6-0008QK-U4; Wed, 07 Sep 2022 12:33:20 +0000 Received: by outflank-mailman (input) for mailman id 401566; Wed, 07 Sep 2022 12:33:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuF5-0006fq-IB for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:33:19 +0000 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [2607:f8b0:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4019e2bc-2ea9-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:33:18 +0200 (CEST) Received: by mail-pf1-x430.google.com with SMTP id z187so14464149pfb.12 for ; Wed, 07 Sep 2022 05:33:18 -0700 (PDT) Received: from leoy-huanghe.lan (45.78.11.189.16clouds.com. [45.78.11.189]) by smtp.gmail.com with ESMTPSA id 4-20020a620504000000b00537b1aa9191sm12648211pff.178.2022.09.07.05.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 05:33:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4019e2bc-2ea9-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=UZyeeIW6CDevxhzZZ82aZV1Yflrt63k7g2aNi/UkNrU=; b=HYlGGA9TcnWG+BLBQP4YD1YmU7c0dpCZpYw9/2pFvu/5suTNvhw7Fg7rNeZCvznoT4 N/38/K2mW7tbwutimpMfkn2d/QBVW4GJ1BlPXuaA8uMhfciMlJUXkj8jIBSLZR4u7DDv AkT83BL5z9/nG6ZdMxml5vuuM3O9ieG5GxbgF1y5+DyB7xuktC8SuzhNDHGwSbCW8zdg sZRZqcdsSHBGFh+u5a9rNqk5rcLgNc4KVou5N+Q/pF+T8OqrXdqw50GoMmQr9XJFNOjm pgugaNmRUqfwGCeCARfjdasXLdYJWgPE7iZ5CVmyiQz09GtAFT0jF56PMVeI0ToZTL5X ZkvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=UZyeeIW6CDevxhzZZ82aZV1Yflrt63k7g2aNi/UkNrU=; b=JVkiJkcQnutXz68HXYa9hcOr6+0aNmn46fmbJ9nqzh9oeyP0Jn5fJJTcSxdBPYyCNy iBje/WvV1VHCXnoYMD78KG+inTL2Iya8ZCuDNH8MZCvI0Ff+N1hozCPfPs7zuvixzjn6 9TNYUaq3zNt4NielcBNhsMoT/fRSqmjt+MC3cerbVIuZN/NbHkWWBOOcM2jCzF8iGXAo moaQi4Fl/htiyCy1oqkD7Qrep5W2B1W7J3GV9YErFrRBxQArSzntiIIwnrG2EoTtraKR hmzhi5lCmvoM2ovVSrR8JlbpUu90QD4Et2uTseR0orzi+wsdutkUmzvhm9sr3tEMvcEV WwIg== X-Gm-Message-State: ACgBeo0dgheUXgTLRXqKqzX83H4hr4CKlsPbbS4yw4YRB/Gy5SJjBrn8 KGDPobL0mFm5Xc9sWw+uyMlNUg== X-Google-Smtp-Source: AA6agR7up8kHTnYebU21hfKdW2j3z1FDTPnNstpgk5JCwQDhildibLLCJIbpsTslffJ8YuXDKgf4Ng== X-Received: by 2002:a63:1c47:0:b0:434:cb11:5478 with SMTP id c7-20020a631c47000000b00434cb115478mr3310180pgm.398.1662553997388; Wed, 07 Sep 2022 05:33:17 -0700 (PDT) Date: Wed, 7 Sep 2022 20:33:12 +0800 From: Leo Yan To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen: Add macro for version number string Message-ID: References: <20220907120420.387771-1-leo.yan@linaro.org> <40400a52-b55a-1c35-5ee8-32ebfb08bc28@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 07, 2022 at 02:31:52PM +0200, Jan Beulich wrote: > On 07.09.2022 14:28, Leo Yan wrote: > > A question, since commit 5d797ee199b3 was merged in 4.11.0-rc6, for > > fixing it, should I explictly add backport tag as below? > > > > Backport: 4.11+ > > That's up to you, I would say. We don't really use that tag all that much, > the Fixes: tag is more relevant at least based on recent observations. Thanks a lot for confirmation. If so, I will just use Fixes tag. Leo From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:34:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401572.643422 (Exim 4.92) (envelope-from ) id 1oVuGF-0000ch-Bq; Wed, 07 Sep 2022 12:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401572.643422; Wed, 07 Sep 2022 12:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuGF-0000cZ-8K; Wed, 07 Sep 2022 12:34:31 +0000 Received: by outflank-mailman (input) for mailman id 401572; Wed, 07 Sep 2022 12:34:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuGE-0000Zd-HJ for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:34:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80084.outbound.protection.outlook.com [40.107.8.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a809aa6-2ea9-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:34:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB6329.eurprd04.prod.outlook.com (2603:10a6:10:c2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 7 Sep 2022 12:34:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 12:34:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a809aa6-2ea9-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLCe7habJrb8QdXj8N6HSUU9MLr7uUlRzeXY+Dyx8pNWhw1svqtoMvnogTsXAlpfdvYhThUT3KL8FJLAwQ1GfiUSQA3nyc9v4GYUTAQ0K014kCiZIYx2YznuspnSq3QK6xW2gVzYwxwn0XVdn0Egu1ZsYpWBbWSBqO9a3Cr7Cry5DnHnWsQ42ax5lZdZAKe6xpdaRVcvXtmOKSZYo0U2M+/ULSR3+uCKH+c4A6254LE8rOqVMi/zrO7B2dYXJu7HsRDB1qMj2BLFHtDNRS16aTF9EdQPLOlagztLrfeHqF03Tu2mzWaM7qoFRFVZv5RlW27v5JhijDk6L2grss6x2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fiHQ9mFULkwOLRK7OMpRZAgpherdOO2XDetbhouZLnY=; b=JCeLh83EsCKq5Nb+sGpjSsRo/DSWyHEDmgbxbud3yXWBJDyQvxK/iiGKgPJSUDyVwDYvN6VM1lu2rxpwxs6LG5p8kMJ7KeRbqqSFEg/t233BGlHpLvlVQX+T7pOY2YwSCumFufgaWElHB4nOQkB//En3BwcnaV0oQrpET2onTTvCmEzYsS2rreUfVLIgeF8DrXWsQXIHdV66S++m9isodWVCOby5IvDLS/5bP483QfbQdV1IOlcNeEpoGczH5BHceTFNY9EIDygKdUlinOwE1AunDJemYYOwjlMVkWUZDbBnL67vn/rUWQSa3oQKghijlT7LIrbZjKRPhXBSHFM2RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fiHQ9mFULkwOLRK7OMpRZAgpherdOO2XDetbhouZLnY=; b=yA2X/3jz9VeKkbk7L3anRHDYnbpj21BSrq96lPf+5DeuJ86tthycpPHwBJBxJeYWxQmQL9PVDFlgLvbaYZK4nn8vi/0tCXRua4bh1SkBmLCzRtWsmLhA0FhPsSjR8hyJe7b7UwrBS9QbKvjIHYvQDkhPdxYwsdWahsU250dy5qTPGz7nGAHp65eXhCBboCmwZLxD25gzya3PbHft/Ag/MZWN8MibvhsX//KzFqfJvr0fq7fNtk5tSk6Uzh/b100uXyR/2sGz/Vt/kFTg7ltTJHZFtBmnmDtly1nJ01ZFGN92fvw2LDRz2VTDus636dpwKKT8lv0NODdKsEfjrGdfSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <19658a68-573f-9d27-ead3-fd0c57dcf68a@suse.com> Date: Wed, 7 Sep 2022 14:34:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen: Add macro for version number string Content-Language: en-US To: Bertrand Marquis , "leo.yan@linaro.org" Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220907120420.387771-1-leo.yan@linaro.org> <4A5E6FC5-1716-4D7E-95EB-83CA6451D88A@arm.com> From: Jan Beulich In-Reply-To: <4A5E6FC5-1716-4D7E-95EB-83CA6451D88A@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0032.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB6329:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a8fe7b1-5fae-4fb2-973e-08da90cd4dcb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LSe5G3QX9mXyS3l/uNqnBwtwARTGrAm/z2/CcD5DNzIpUBy52O1EFrJQLY8Qm4Rc66Q6P/px6BemYJlzps8MOJCZu1RV6pnuOY6Ilo+26iFbvgJh65T5dfmLRRHXE/RYpY0qeLC+hC4ktgO+rV9fI3tkM0dzX+gQD+DtAPZxz7uu6k6kiQsQRQ2BD34068rGVwyggXRPmadq8f1v90n/mgMXr9vh9fgKf2oCLXIDzkFC/7Fu4I0UrxmsiZfVSyphsVAsIMByxhxFkiwt6EpDo6uAxRZ6Bz1OISLH47tJkNThuv/saMEXTSNHZnEC5FPPexQFwoO1LGSrZ0yG4qkF5LJUUrQYLEOX5tLje+d5kKUNS30k5xR0OPeHzC7aQKfWJdmT4TP8cz2UE0ZgWXACoINpLdo4tTJoKy/3/D+yWxUgaPxNWcx3glOx+fhrx3h/YAe1FWDE/kZfj27jL3VJ3UJg/r6PeQDRLiORHzKb1dBzTYZHGbQZsC0/I7E/TOY80xLSthSdagHGk+TkvBtpeR/ayvVCPXGxVrYPIQbt7nHEdBF4UlnZZMkspIX4Rfs98HTySpiUcPbleCpE99QhMac1PKpXrptt6JbPzv0Jy5zGAf3NAdVdnkyE9RjViKHYRE8WhVF4YMel3Ybd1VfqEzCPjQBNxwi0kRd+hGOE0HjBuqa3TCfPUpqSkQakz+LcBUyZgA0/Jum0lGXZW1WRQzpQwQtNcyV3IobLwfY8LU3RjqGdDveVNYdU9k9vDlU0Tfc8Lbrr9zbDaA++ExzhRk3EJ0oK60azuqZvz2lX+Ko= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(396003)(39860400002)(376002)(316002)(5660300002)(66556008)(110136005)(4326008)(54906003)(66476007)(8676002)(66946007)(36756003)(8936002)(31686004)(2906002)(31696002)(6486002)(6512007)(26005)(41300700001)(478600001)(86362001)(2616005)(186003)(53546011)(6506007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1cyTkRwNFFwNHR4Zkg5MVE5Y1h4N2pjcXRWU25RSkpmazdBQ0Z0QnVoZW95?= =?utf-8?B?dVhHaXBRaXBiNmVpMUxjaU1POFVLODcvV0JtUFBwRHJra1k3SG5zNVFWUkhP?= =?utf-8?B?R0lDZEJ6c0ZlLzAxRTBXd1BROWxhR0FPWUhzeVpoMERzN0FmK1ZFYU9XbUtC?= =?utf-8?B?aWkrNm9GWEhnNWlCTlAyZkhRYngreWw3RFJ3QU5UdDBVamFFL25xRWJ1YWJT?= =?utf-8?B?MG1wSW5GRmt1cy95cXJXS3ZwNnhzaVNiT0MxVHhiL1g0RWpZcDFwYmlqYkFw?= =?utf-8?B?My9XMlgrbzd2Y3FMcS83bXdVVTNQTkVwU05oeWtIQ3lpV0VObytYaE1mVm00?= =?utf-8?B?QUFrNUNVMzVpV2RuRmdXaDhoWlNVTm5iRjZFanhHU3ZJRk9ndDNWR2FmcDF4?= =?utf-8?B?dDdsKzlaZTdqMDBBL0IycmN0ck5GM2ZKT2k1aVViSkRpdnQ4ZTFoNE10WkdL?= =?utf-8?B?OVd2MWhxNWxtd1ZOQTRMSFRvb1E0YXVLdVg3WGRMMW0vMi9HYnBDTnNMeHlU?= =?utf-8?B?bkZrMkR3ZkU3WUJXUHpOSjhTdFpFM2gvYWZHdzJrd05ROVNVdVdKM0pZYmVZ?= =?utf-8?B?ekUyWGhXamppMWMxNG91ZWpXV2VaYlhsdmd6OEpmOUE4bTN5VUFNaVFqRDQx?= =?utf-8?B?SEt2TmE3cEpSNWVjV3huTmFUamQ5YnBpMTNtbEZ5Zk5BQmxGOUZYTERuQTJz?= =?utf-8?B?NkFQSE5NOEJNV2EyVFZFOHYzSk4rZzN0cFZTTDcyQmlMaTlRbGZkRWJrbitB?= =?utf-8?B?SEo5Yld4SzRSSlNkN0RvSFV1SHpHS29OMFVIUmpvNkFHM0JyNDZFVmlyUDIr?= =?utf-8?B?VVJxUFhieTh4QWFzZmVoNWF6dUJwQjAxYmhpZnRDS0NpTkJXenBOSWRPTGlS?= =?utf-8?B?NUtPc3d1VHBWWndDS0FyejdMWXFCU3p5VnE2dy9wTmdja3ZPTFBpU3B3TEdm?= =?utf-8?B?dlNTUGllRE9Gd0JCT1ZCRWdYbi82b0FxSlNaM2JBWkFtbWtGNm0ycW9LS2J5?= =?utf-8?B?d0lkV1ZxODhYejBvSTFMZTYvbEcyREtsa1ppSmZsbFVWbnFiRVNDckxzemNn?= =?utf-8?B?Q3Faa3lXOTQ4Z203SDN4SU1oYlNBcnpaZ3Q4SkxUYnFTVDhvSmFZcC9LZjh0?= =?utf-8?B?bjVuT0JiSExKK1hpdXlMNkZqMzcrRy95MWhMOEpibnVjR1hWQmx4MmdZVE1B?= =?utf-8?B?OHVmN3hjcTRWNHo1UTIvWjhXN0JUOFQ4bTVGbU1JcjhpNzRwS1NzZWRCZnVJ?= =?utf-8?B?VHEwcnJvbytNYWEzZ1AydzQ1bUtIbzlXQjk4WklubkhtRkFSUncxQStESDRW?= =?utf-8?B?b29RRkRqcGNORGE1TWtlVVMvUDJETUxhMDlKeWwrR3V5TFZOQyszYURHMm9H?= =?utf-8?B?aytydkl3VVQzUCtLb256VUVtVjd6ckdYR2JOYUVHM1JEemQwTXJqRm5BRzR5?= =?utf-8?B?QWhoRnBIMkR6YWZQNXV6bndxMmRJTFVKNTk5SmVsczBCRG1ZSjZlRTAzanA5?= =?utf-8?B?YUViTm02aG0yOS84b0xvOWNpc1ZYaktaVWxNelgwYnJ6cERPZlFDdlNnNE50?= =?utf-8?B?bE9YbTNTWnErZERncDRObnpnOFhoSWg5MytzaE5aMGlsSUJCWUwwM29uaW1K?= =?utf-8?B?cFVlbksvMzBrMkNmc0lnT2J5TlJkQTgxcHJJckRMZ3hEdUJUZk5ITFBSTkZl?= =?utf-8?B?eTh1ZU9WMGNxSk1iUDZmWkl5WGYwSFdITVRacUlnVE5udlZWTUFtSkdFMGxs?= =?utf-8?B?L1hvUVdFNFhCV3FTcWtvTGJKK1UwemxQZFRYaU0ra0hFN3R4bG93MWlvNmRk?= =?utf-8?B?UzQ3bHMxWk1Md0NzL3BHamhONG5GRThCNUFxT1VtaTY2KzNoVTZoWG40cjZD?= =?utf-8?B?VG5pRUlrcjNMK1M0QWhXRDVFczNWcE1URTBaYlRZU3E4MzZab1RVbzI3b0p2?= =?utf-8?B?RmxoVDM3cUc2bFVTSEJzSytMK1gvTytZQXB4QUp5a2Y5ckUzRGpOWGhZUUp0?= =?utf-8?B?bGdQZVdMM3hsSXppVnVPRFg2dVFzays3clZCT2lXMFFzdWp1NmdkUnlJa3BN?= =?utf-8?B?WE9QLzVKZDNiR3RPcW9ISnB2amVDV2xHcmVINCtYSE1oemROK0JNeTFZQWFP?= =?utf-8?Q?C6aJOtbk8mRyHrbIikwKjVMiR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a8fe7b1-5fae-4fb2-973e-08da90cd4dcb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:34:27.5480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9T2jRwPzweoanHseVqXPB7NwicwkiZgsv3Xf95o4Q8ewt5OJBSibo83nsLnhXpw9JcVvT10dpBt1cCEH6Q+ZXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6329 On 07.09.2022 14:20, Bertrand Marquis wrote: > Hi Leo, > > Thanks a lot for the quick handling here. > >> On 7 Sep 2022, at 13:04, Leo Yan wrote: >> >> On Arm64 Linux kernel prints log for Xen version number: >> >> Xen XEN_VERSION.XEN_SUBVERSION support found >> >> The header file "xen/compile.h" is missed so that XEN_VERSION and >> XEN_SUBVERSION are not defined, __stringify() wrongly converts them as >> strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". >> >> This patch introduces a string macro XEN_VERSION_STRING, we can directly >> use it as version number string, as a result it drops to use of >> __stringify() to make the code more readable. >> >> The change has been tested on Ampere AVA Arm64 platform. >> >> Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") >> Suggested-by: Bertrand Marquis >> Signed-off-by: Leo Yan > Reviewed-by: Bertrand Marquis > > Regarding the change suggested by Jan to add spaces, I think it is a > good idea so if the commiter agrees to do on it on commit please do, > otherwise we can keep this as is. If I end up committing this, I'd be happy to add the blanks, and therefore I'm inclined to say no need for a re-send. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:35:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:35:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401579.643433 (Exim 4.92) (envelope-from ) id 1oVuH5-0001cN-Jx; Wed, 07 Sep 2022 12:35:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401579.643433; Wed, 07 Sep 2022 12:35:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuH5-0001cG-H7; Wed, 07 Sep 2022 12:35:23 +0000 Received: by outflank-mailman (input) for mailman id 401579; Wed, 07 Sep 2022 12:35:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuH4-0001c8-J9 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:35:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuH4-0005G0-Cv; Wed, 07 Sep 2022 12:35:22 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVuH4-0000bV-6b; Wed, 07 Sep 2022 12:35:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uJURFiF+ya9SSecU5Nuy/v5o1AGWslNu+Lqq4gT5p2I=; b=pudTC2UyJ9SLG/ykkkQawPpdBn ycJSzEfsoYh+tdnCm4S5/tmOhGmrqRJuhkJKOXuf5jLB5F9s/t3GfQsx6XEI2qILyzd5bL4rRNOa3 pi+AGv7Jg/uJwMENS1yHRn8/7HT9lhJsi81PGRtMC90I65Zw8OeK8f2lFmPfU/iTBi5o=; Message-ID: Date: Wed, 7 Sep 2022 13:35:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Bertrand Marquis , Henry Wang Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Penny Zheng , Wei Chen , Volodymyr Babchuk References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <43B994EE-81DE-445A-B31F-477148E5465D@arm.com> From: Julien Grall In-Reply-To: <43B994EE-81DE-445A-B31F-477148E5465D@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 13:12, Bertrand Marquis wrote: > Hi, Hi Bertrand, >> On 7 Sep 2022, at 12:48, Henry Wang wrote: >> >> Hi Julien, >> >>> -----Original Message----- >>> From: Julien Grall >>> Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory >>> >>> Hi Henry, >>> >>> While reviewing the binding sent by Penny I noticed some inconsistency >>> with the one you introduced. See below. >>> >>> On 07/09/2022 09:36, Henry Wang wrote: >>>> +- xen,static-heap >>>> + >>>> + Property under the top-level "chosen" node. It specifies the address >>>> + and size of Xen static heap memory. Note that at least a 64KB >>>> + alignment is required. >>>> + >>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>>> + >>>> + Specify the number of cells used for the address and size of the >>>> + "xen,static-heap" property under "chosen". >>>> + >>>> +Below is an example on how to specify the static heap in device tree: >>>> + >>>> + / { >>>> + chosen { >>>> + #xen,static-heap-address-cells = <0x2>; >>>> + #xen,static-heap-size-cells = <0x2>; >>> >>> Your binding, is introduce #xen,static-heap-{address, size}-cells >>> whereas Penny's one is using #{address, size}-cells even if the property >>> is not "reg". >>> >>> I would like some consistency in the way we define bindings. Looking at >>> the tree, we already seem to have introduced >>> #xen-static-mem-address-cells. So maybe we should follow your approach? >>> >>> That said, I am wondering whether we should just use one set of property >>> name. > > The more I dig, the less I find a use case where we could need different values here. This is what I thought as well.. > Maybe just: > #xen,address-cells = <2> > #xen,size-cells = <2> > Could be enough. If some parameter needs a different value it could introduce a specific name. I think '#xen,...' is ambiguous because it doesn't tell you whether it applies to the memory range or interrupt range. So I would got with > > Or maybe just memory-address-cells and memory-size-cells if we see a possibility to require a different value for an other address or size. "#xen,memory-*". That said, any reason to not reuse #address-cells and #size-cells here? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:42:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:42:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401586.643444 (Exim 4.92) (envelope-from ) id 1oVuNa-0003Ct-Ad; Wed, 07 Sep 2022 12:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401586.643444; Wed, 07 Sep 2022 12:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuNa-0003Cl-7Z; Wed, 07 Sep 2022 12:42:06 +0000 Received: by outflank-mailman (input) for mailman id 401586; Wed, 07 Sep 2022 12:42:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuNY-0003Cf-Hi for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:42:04 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2052.outbound.protection.outlook.com [40.107.102.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 788fd422-2eaa-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 14:42:03 +0200 (CEST) Received: from DM5PR08CA0057.namprd08.prod.outlook.com (2603:10b6:4:60::46) by LV2PR12MB5752.namprd12.prod.outlook.com (2603:10b6:408:14d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 12:41:57 +0000 Received: from DM6NAM11FT074.eop-nam11.prod.protection.outlook.com (2603:10b6:4:60:cafe::8d) by DM5PR08CA0057.outlook.office365.com (2603:10b6:4:60::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 12:41:57 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT074.mail.protection.outlook.com (10.13.173.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 12:41:56 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 07:41:56 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 05:41:56 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 07:41:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 788fd422-2eaa-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GthO+fsbVKS51MGxY6j/Llv4yTTdXOa0P36N2JXs3uPHKDg2DJr0p9x9kzdPZQr+ZTD6hFW/gvqvw4TDx9a2Fvnt+Or9Ld21uNO1E9o+Q54V2xLSiV3qnljng99rflGf1nEgD1Mu3xFUmMiJeTnBpB1l2Q2p2OY9E466AM53LgjO3iPlBH6FHugHqLre/lwtRCMLl20Nc33kMJ8+JXVfwJ/8UYG0tFZrK987DimlTD9cAGQILez4/IBlWqq93GRcJEhPIxWwOmXWBbKsv9/J4gGvpSuxD7a+VWBnMRMJzeK2ANlAqYBH9cUAYL4p1gg6zKxxkcDKANqUZSh6Cqa21g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=woKPLq+RkGsItn6F4ZxvyD92K+4Tuo/7tb3rJtxA62k=; b=UkXy847eX+bpVOSLFJATu1iwH9AjXtGNiHPrgAHX2Qw43vGAinjg7ZqmGyQV+uBBTBkPFXPADcwcfXwciNBKpFcKt93T8C5PC73aCSDy2uJMnwORGA5mq9chqMj94XzmuuzvBDp3DLvznUgv4uBmF3TXLdqvnXmbrSaquwAcCZdcBOOjoSiPVgSr1FMuVRKW8Gu+3Q8zE0yQD/yGVKp6kzc5m+S3zKGb6ZO+5bAfpL4oWHOhEL+Vli4W5MLMHBvNb6EoYawbqsV/vlrgf4g5N6Dvj7wb9su/TjmyC2GGEUgV6/qe2f4X5oy+HLvRXoZ8A/f/hgqJ2dCL5zsVttdOlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woKPLq+RkGsItn6F4ZxvyD92K+4Tuo/7tb3rJtxA62k=; b=rqEV4tSIQtOucUZLwLD9o8+Hk7tTLXNe0CwTegja1xO6rVX8LAe1/3+L3O5wFLyhGeDfN4KctgaGk0enQj3Io6cktKMJvWPAMrLRoh2Gj3kBHGuOk/DnKhnB5JuqR40SjDnokE4RJWNps8uK+asr4KDV/om5Xf2b6Zi0PsJFfig= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 7 Sep 2022 14:41:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Julien Grall , Henry Wang , CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT074:EE_|LV2PR12MB5752:EE_ X-MS-Office365-Filtering-Correlation-Id: 816d7a6f-172c-45ad-ebb4-08da90ce59d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +E5gzsONyDCZ0XqLk0B/+ZMNfaYV/i5iB2ha+AnyB2ANQ9gZCFrIjZ3JdzRy6O2QbCg/LXOLkyItu+RI5tgqEsmbLvdsmeV2ZeF3boYgk58uBSUXlaR9b4oVN8NaTgt+PfrM6FKclVDvLI+vkgavBhZGdPU2kcNcbB4JJWEi33be5zhJ/zGbqiK8KHNAX8rODs63caKgdMkT+kFtZdVhuek/xrF8ygeZGgIHvGL0NVBfckS7sapd6BgK0RHc+gGEJzFbAe5imTe0UTkqcBlUma1FWrs+c/x4aqdvi1I58WzwnX1sBrZq7tHFl5N13cxwEjuFzAhiRXnbzDIy3mf83O8gffdUIOkbBtjPbOQfecKI1i3aSpy19dQlrecVVHKK/oFCyZZjx2Pva8lksi4e6VL4e9f13/KApmRTqasvMjUhWGzmAiSHNGxVJok7RqAhJEXYbPDrGKhSrL4HFQLAtrekoU4oKocTrZRXQBYqhCETbKtOuN32sg98UzeaB+q3eegJ6bhu9OkIfYLQgS540OayOtF7i+DYOg1StKV9nLfVnEaDVJAG2/E3SDtqkXYzplf+mVLY8n3F1eMmPmBIrTl4XSI3dNNNprQjabxrn4xXkg/OR4Y0i4a19PEoKxdMwUjHbePp0jA2va4RWILc+QxsfM8Qid3bLNMVKkUCm4lQDVxD5J5J24thClDMvRNtUaCl3blUPU9+vpvetkg5HVAfVqaSvedZrxvUVRJUnyeJnvCugEi+sRUwvJGcZC7eVRrta1MEOKffwJDhvmtOn64t8sJTiFzFiWcYh7fFT8+Xw87k4RoM/W/gREl6Nuqu1T/tqql4dcUDCm4OznJVpvgJGZ+9pKm347kTWCDvgvI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(39860400002)(136003)(40470700004)(46966006)(36840700001)(36860700001)(426003)(82740400003)(53546011)(47076005)(83380400001)(26005)(81166007)(186003)(2616005)(40460700003)(356005)(336012)(86362001)(31696002)(31686004)(4326008)(70206006)(966005)(8936002)(110136005)(82310400005)(70586007)(16576012)(316002)(5660300002)(40480700001)(2906002)(54906003)(44832011)(36756003)(41300700001)(8676002)(478600001)(45080400002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 12:41:56.9951 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 816d7a6f-172c-45ad-ebb4-08da90ce59d5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT074.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5752 On 07/09/2022 14:32, Julien Grall wrote: > [CAUTION: External Email] > > On 07/09/2022 13:12, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 07/09/2022 13:36, Julien Grall wrote: >>> >>> Hi Henry, >>> >>> While reviewing the binding sent by Penny I noticed some inconsistency >>> with the one you introduced. See below. >>> >>> On 07/09/2022 09:36, Henry Wang wrote: >>>> +- xen,static-heap >>>> + >>>> + Property under the top-level "chosen" node. It specifies the address >>>> + and size of Xen static heap memory. Note that at least a 64KB >>>> + alignment is required. >>>> + >>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>>> + >>>> + Specify the number of cells used for the address and size of the >>>> + "xen,static-heap" property under "chosen". >>>> + >>>> +Below is an example on how to specify the static heap in device tree: >>>> + >>>> + / { >>>> + chosen { >>>> + #xen,static-heap-address-cells = <0x2>; >>>> + #xen,static-heap-size-cells = <0x2>; >>> >>> Your binding, is introduce #xen,static-heap-{address, size}-cells >>> whereas Penny's one is using #{address, size}-cells even if the property >>> is not "reg". >>> >>> I would like some consistency in the way we define bindings. Looking at >>> the tree, we already seem to have introduced >>> #xen-static-mem-address-cells. So maybe we should follow your approach? >>> >>> That said, I am wondering whether we should just use one set of property >>> name. >>> >>> I am open to suggestion here. My only request is we are consistent (i.e. >>> this doesn't depend on who wrote the bindings). >>> >> In my opinion we should follow the device tree specification which states >> that the #address-cells and #size-cells correspond to the reg property. > > Hmmm.... Looking at [1], the two properties are not exclusive to 'reg' > Furthermore, I am not aware of any restriction for us to re-use them. Do > you have a pointer? As we are discussing re-usage of #address-cells and #size-cells for custom properties that are not "reg", I took this info from the latest device tree specs found under https://www.devicetree.org/specifications/: "The #address-cells property defines the number of cells used to encode the address field in a child node's reg property" and "The #size-cells property defines the number of cells used to encode the size field in a child node’s reg property" > > Cheers, > > [1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felinux.org%2FDevice_Tree_Mysteries%23.23xxx-cells_property_name&data=05%7C01%7Cmichal.orzel%40amd.com%7C40290431f16748808b6308da90ccfc53%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637981507324472512%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=okN60ULg2Dx3cnlA5vPLMR%2F8QAKnbGmBpz7goXb5usw%3D&reserved=0 > >> >> ~Michal > > -- > Julien Grall > ~Michal From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:45:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:45:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401595.643455 (Exim 4.92) (envelope-from ) id 1oVuQX-0003tR-Tn; Wed, 07 Sep 2022 12:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401595.643455; Wed, 07 Sep 2022 12:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuQX-0003tK-QA; Wed, 07 Sep 2022 12:45:09 +0000 Received: by outflank-mailman (input) for mailman id 401595; Wed, 07 Sep 2022 12:45:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuQW-0003tE-N2 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:45:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuQW-0005TI-Aa; Wed, 07 Sep 2022 12:45:08 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVuQW-0001Ii-35; Wed, 07 Sep 2022 12:45:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jCSVVoXzJNRatYYuCyZFpFduunPJBxmvHk/rbbyryxU=; b=g0r9l+NmWrsO/Kdcvd7SnDXMr0 961ZGwXH7HKJsFLN2Ln/HniEPOv7NLMmPGoIFGcQmwMHFvehsFEksrVvVvv/1/jOiyGCSf67BcFJj C9E34CudNLvTH1WEGBlatS+xBlCCjs7DrjBSUSo1eMiicayc0R/TG9h2NsW4yXoWGoLk=; Message-ID: Date: Wed, 7 Sep 2022 13:45:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Michal Orzel , Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/09/2022 13:41, Michal Orzel wrote: > > > On 07/09/2022 14:32, Julien Grall wrote: >> [CAUTION: External Email] >> >> On 07/09/2022 13:12, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> On 07/09/2022 13:36, Julien Grall wrote: >>>> >>>> Hi Henry, >>>> >>>> While reviewing the binding sent by Penny I noticed some inconsistency >>>> with the one you introduced. See below. >>>> >>>> On 07/09/2022 09:36, Henry Wang wrote: >>>>> +- xen,static-heap >>>>> + >>>>> + Property under the top-level "chosen" node. It specifies the address >>>>> + and size of Xen static heap memory. Note that at least a 64KB >>>>> + alignment is required. >>>>> + >>>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>>>> + >>>>> + Specify the number of cells used for the address and size of the >>>>> + "xen,static-heap" property under "chosen". >>>>> + >>>>> +Below is an example on how to specify the static heap in device tree: >>>>> + >>>>> + / { >>>>> + chosen { >>>>> + #xen,static-heap-address-cells = <0x2>; >>>>> + #xen,static-heap-size-cells = <0x2>; >>>> >>>> Your binding, is introduce #xen,static-heap-{address, size}-cells >>>> whereas Penny's one is using #{address, size}-cells even if the property >>>> is not "reg". >>>> >>>> I would like some consistency in the way we define bindings. Looking at >>>> the tree, we already seem to have introduced >>>> #xen-static-mem-address-cells. So maybe we should follow your approach? >>>> >>>> That said, I am wondering whether we should just use one set of property >>>> name. >>>> >>>> I am open to suggestion here. My only request is we are consistent (i.e. >>>> this doesn't depend on who wrote the bindings). >>>> >>> In my opinion we should follow the device tree specification which states >>> that the #address-cells and #size-cells correspond to the reg property. >> >> Hmmm.... Looking at [1], the two properties are not exclusive to 'reg' >> Furthermore, I am not aware of any restriction for us to re-use them. Do >> you have a pointer? > > As we are discussing re-usage of #address-cells and #size-cells for custom properties that are not "reg", > I took this info from the latest device tree specs found under https://www.devicetree.org/specifications/: > "The #address-cells property defines the number of cells used to encode the address field in a child node's reg property" > and > "The #size-cells property defines the number of cells used to encode the size field in a child node’s reg property" Right. But there is nothing in the wording suggesting that #address-cells and #size-cells can't be re-used. From [1], it is clear that the meaning has changed. So why can't we do the same? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:47:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:47:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401602.643465 (Exim 4.92) (envelope-from ) id 1oVuSv-0004U2-9l; Wed, 07 Sep 2022 12:47:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401602.643465; Wed, 07 Sep 2022 12:47:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuSv-0004Tv-6v; Wed, 07 Sep 2022 12:47:37 +0000 Received: by outflank-mailman (input) for mailman id 401602; Wed, 07 Sep 2022 12:47:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuSu-0004Tp-N0 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:47:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuSt-0005WH-ID; Wed, 07 Sep 2022 12:47:35 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVuSt-0001LZ-C2; Wed, 07 Sep 2022 12:47:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=b7uthS8reF8CyMo9QEd2n1PaOzooUpB9Fq0QYgkDbCM=; b=tYOrNJ370+etQGvXJtbecxMhtr uzHwwPVg4/pYd0Q5GzJx5vcy6ugS6adsgeIa0w8828+FX0n1JyDNfX73heWR7HFFQnr7KKUCXESrY /6a8kB8pFsWXWTAZEP6hLUN3RdqnXOYZFn3I/fZ9BEu3EDOfelBS4UjOOgkYoYIbx870=; Message-ID: Date: Wed, 7 Sep 2022 13:47:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Jan Beulich Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Rahul Singh , Stefano Stabellini References: <5948f099-7287-2743-aa24-3c7a17033877@xen.org> <4ac67001-9406-6cac-b032-b6cbefb598b5@suse.com> <4f070d84-a732-3166-ad6c-2c15e6cfc882@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 13:01, Jan Beulich wrote: > On 07.09.2022 12:00, Julien Grall wrote: >> On 07/09/2022 10:07, Jan Beulich wrote: >>> On 07.09.2022 10:58, Julien Grall wrote: >>>> On 06/09/2022 09:53, Jan Beulich wrote: >>>>> On 03.09.2022 02:24, Stefano Stabellini wrote: >>>>>> On Thu, 1 Sep 2022, Rahul Singh wrote: >>>>>>> @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) >>>>>>> return 0; >>>>>>> } >>>>>>> >>>>>>> +static int is_bar_valid(const struct dt_device_node *dev, >>>>>>> + uint64_t addr, uint64_t len, void *data) >>>>>>> +{ >>>>>>> + struct pdev_bar *bar_data = data; >>>>>>> + unsigned long s = mfn_x(bar_data->start); >>>>>>> + unsigned long e = mfn_x(bar_data->end); >>>>>>> + >>>>>>> + if ( (s <= e) && (s >= PFN_DOWN(addr)) && (e <= PFN_UP(addr + len - 1)) ) >>>>>>> + bar_data->is_valid = true; >>>>>> >>>>>> >>>>>> This patch looks good and you addressed all Jan's comment well. Before I >>>>>> ack it, one question. >>>>>> >>>>>> I know that you made this change to address Jan's comment but using >>>>>> PFN_DOWN for the (s >= PFN_DOWN(addr)) check and PFN_UP for the (e <= >>>>>> PFN_UP(addr + len - 1)) check means that we are relaxing the >>>>>> requirements, aren't we? >>>>>> >>>>>> I know that this discussion is a bit pointless because addr and len should >>>>>> always be page aligned, and if they weren't it would be a mistake. >>>> >>>> Hmmm.... Is that requirement written down somewhere? >>> >>> What do you mean here? Isn't it quite obvious that every byte in the >>> address space may only be used for a single purpose? I.e. if a byte >>> is covered by a BAR, it cannot also be covered by a RAM region or >>> yet something else (e.g. MMIO beyond BARs of PCI devices). What >>> happens if BAR and RAM indeed overlap depends on fabric and chipset, >>> but it'll either result in chaos if two parties respond to a single >>> request on the bus, or it'll be (hopefully) deterministic (for any >>> individual system) which of the two takes "precedence". >> >> I am well aware about that and I am not sure how you implied this is >> what I was referring to from what I wrote (in particular if you read the >> next sentence). >> >> Stefano wrote that it would be a mistake if the address/length is not >> page-aligned. However, I am not aware from such requirement written >> down. It seems to be more an expected common sense that was IIRC not >> always respected on HW supporting multiple page-granularity. > > I guess the question was then solely directed at Stefano? This question yes. The rest was a reply to your suggestion. I will wait for Stefano to answer. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:48:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:48:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401609.643477 (Exim 4.92) (envelope-from ) id 1oVuTd-00053r-Ij; Wed, 07 Sep 2022 12:48:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401609.643477; Wed, 07 Sep 2022 12:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuTd-00053k-Fs; Wed, 07 Sep 2022 12:48:21 +0000 Received: by outflank-mailman (input) for mailman id 401609; Wed, 07 Sep 2022 12:48:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuTc-0004ym-5h for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:48:20 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58b856e3-2eab-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 14:48:19 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so18182397pjq.3 for ; Wed, 07 Sep 2022 05:48:19 -0700 (PDT) Received: from leoy-yangtze.lan (n058152048222.netvigator.com. [58.152.48.222]) by smtp.gmail.com with ESMTPSA id a8-20020a170902ecc800b00176b3d7db49sm6575023plh.0.2022.09.07.05.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 05:48:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58b856e3-2eab-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=9G8x9ah2xvnNrCAeq9bbiuzFgx8g7W9WKp+Mj/GfpZU=; b=BtpFVA9+BQt5KYlrT4niUqaQWRZP9BHnx4Ew6NOxTULZE0EjbnplPvidI5lC0QFf8/ E8Wiuk7IJ6W2u+yfXVYDOKW1/q487J0dIp6NBh4r63AVcZ7tPdROaX4d9gYle8RUXPz5 cwe8SCTexvoCbPa5PNDDxEsG5XMgRd4OhvzMvyMwyuLHqjMchNxTcjMu94ijLJ7nFlo3 HOWgYbhPK5NMj2cKrCOUhnpiWgSLjIQZgjBGSxZnt4unc9SH5O1/5g2BQtpVBudPw2oZ DELHvZsH14fuU/4cL1l7XCBrnqyTL8NLDpwZdfP2N88ROvUU1j+y0hzDGPd4fX68m90i 2rgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=9G8x9ah2xvnNrCAeq9bbiuzFgx8g7W9WKp+Mj/GfpZU=; b=WdctRRH227A0xjEXHU5GUap72khcXFti/Ns1HeUqAudNQUsvpDtZuXpoPDx5lASq4t xy268rCpQmX/DdB5hT+DT0pVgGR+ftyNml2Ka5tNniFN7rVl4S64YEIRVVE6CgherWz5 dzFF7LYaUmysQjzoaJFLhgCsr1LPEhmqs9ZN0i9i9YHq35NJY4OLM76NH7aCi0oe+eYU JbhJ812mra+PKI5NH95vdPUCgC5tjYRvWZjyh/9z/kfqcg2bNuhCijLJpCJpuseC7cQA HHPy6U+exVT6Q9Y+A1QhuOa+WAAcvHFdBCxuYTIobYCS5lX1YeXYPfmeINGTaMx7gDpi EMuA== X-Gm-Message-State: ACgBeo0CXlh5OyvezhkQa60XQvgWnBUw+HyLw6K1GZiGyAqg6S7J42IK 5z1W6KPexddaVspKbPk8p3D20d+KB2GYiSg5cXo= X-Google-Smtp-Source: AA6agR7nZafiL6ynYhvZz840gAA9R7ZjYjXovaW9bQtlOMu5u0HOMDDPt9JCcDbXCpPGK+ujvdzulA== X-Received: by 2002:a17:90b:3912:b0:1fe:34a0:e74c with SMTP id ob18-20020a17090b391200b001fe34a0e74cmr31029530pjb.233.1662554897765; Wed, 07 Sep 2022 05:48:17 -0700 (PDT) From: Leo Yan To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Leo Yan Subject: [PATCH v2] xen: Add macro for version number string Date: Wed, 7 Sep 2022 20:48:08 +0800 Message-Id: <20220907124808.403697-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Arm64 Linux kernel prints log for Xen version number: Xen XEN_VERSION.XEN_SUBVERSION support found The header file "xen/compile.h" is missed so that XEN_VERSION and XEN_SUBVERSION are not defined, __stringify() wrongly converts them as strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". This patch introduces a string macro XEN_VERSION_STRING, we can directly use it as version number string, as a result it drops to use of __stringify() to make the code more readable. The change has been tested on Ampere AVA Arm64 platform. Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") Suggested-by: Bertrand Marquis Signed-off-by: Leo Yan Reviewed-by: Bertrand Marquis Reviewed-by: Jan Beulich --- Changes from v1: Added blanks around XEN_VERSION_STRING (Jan); Added Bertrand's and Jan's reviewed tags. xen/arch/arm/acpi/domain_build.c | 3 ++- xen/arch/arm/domain_build.c | 2 +- xen/common/efi/boot.c | 4 ++-- xen/include/xen/compile.h.in | 1 + 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c index bbdc90f92c..ed824c0178 100644 --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -9,6 +9,7 @@ * GNU General Public License for more details. */ +#include #include #include #include @@ -91,7 +92,7 @@ static int __init acpi_make_hypervisor_node(const struct kernel_info *kinfo, struct membank tbl_add[]) { const char compat[] = - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" + "xen,xen-" XEN_VERSION_STRING "\0" "xen,xen"; int res; /* Convenience alias */ diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..d242c542c6 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1367,7 +1367,7 @@ static int __init make_hypervisor_node(struct domain *d, int addrcells, int sizecells) { const char compat[] = - "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" + "xen,xen-" XEN_VERSION_STRING "\0" "xen,xen"; __be32 *reg, *cells; gic_interrupt_t intr; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a5b2d6ddb8..db0340c8e2 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1341,8 +1341,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) efi_console_set_mode(); } - PrintStr(L"Xen " __stringify(XEN_VERSION) "." __stringify(XEN_SUBVERSION) - XEN_EXTRAVERSION " (c/s " XEN_CHANGESET ") EFI loader\r\n"); + PrintStr(L"Xen " XEN_VERSION_STRING XEN_EXTRAVERSION + " (c/s " XEN_CHANGESET ") EFI loader\r\n"); efi_arch_relocate_image(0); diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in index 440ecb25c1..3151d1e7d1 100644 --- a/xen/include/xen/compile.h.in +++ b/xen/include/xen/compile.h.in @@ -7,6 +7,7 @@ #define XEN_VERSION @@version@@ #define XEN_SUBVERSION @@subversion@@ +#define XEN_VERSION_STRING "@@version@@.@@subversion@@" #define XEN_EXTRAVERSION "@@extraversion@@" #define XEN_CHANGESET "@@changeset@@" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:48:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401611.643489 (Exim 4.92) (envelope-from ) id 1oVuTu-0005UQ-SS; Wed, 07 Sep 2022 12:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401611.643489; Wed, 07 Sep 2022 12:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuTu-0005UE-NJ; Wed, 07 Sep 2022 12:48:38 +0000 Received: by outflank-mailman (input) for mailman id 401611; Wed, 07 Sep 2022 12:48:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuTt-0005Tr-Ia for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:48:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuTp-0005XY-KX; Wed, 07 Sep 2022 12:48:33 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVuTp-0001MF-Eb; Wed, 07 Sep 2022 12:48:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JU2kpfk5qmFEZ4Ggvr8ncyUVTtSid99SstJtJyoSe2I=; b=AB1HdpCstB/09s+PRQGJTxFt37 qnUOyABnjq4tokgj2vJ+isbon7qSx+Cr3517mDifGENU4CbzaHwbhR79tImY3XdyzxFvVxDYrlL6k DmDsYDb6Ob3pyqnb2piG4mNzfHoBnz1bVCZrh2B/VDoBtZJK7D+k2B+6y67s9a+Jupc0=; Message-ID: <11fed186-7295-00b0-4fb9-50d08e63f364@xen.org> Date: Wed, 7 Sep 2022 13:48:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Jan Beulich , Rahul Singh Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 07/09/2022 13:06, Jan Beulich wrote: > On 07.09.2022 13:09, Rahul Singh wrote: >> is_memory_hole was implemented for x86 and not for ARM when introduced. >> Replace is_memory_hole call to pci_check_bar as function should check >> if device BAR is in defined memory range. Also, add an implementation >> for ARM which is required for PCI passthrough. >> >> On x86, pci_check_bar will call is_memory_hole which will check if BAR >> is not overlapping with any memory region defined in the memory map. >> >> On ARM, pci_check_bar will go through the host bridge ranges and check >> if the BAR is in the range of defined ranges. >> >> Signed-off-by: Rahul Singh >> --- >> Changes in v4: >> - check "s <= e" before callback >> - Add TODO comment for revisiting the function pci_check_bar() when >> ACPI PCI passthrough support is added. >> - Not Added the Jan Acked-by as patch is modified. > > Hmm, I don't see any change to the parts the ack covers (x86 and common), > so please re-instate. I'm not in the position to ack Arm changes; things > would be different for a Reviewed-by without scope restriction. I would like the question about the BAR alignment to be resolved before giving my Reviewed-by/Acked-by here. Hopefully Stefano can clarify it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:52:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:52:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401624.643499 (Exim 4.92) (envelope-from ) id 1oVuXb-0007Aj-8P; Wed, 07 Sep 2022 12:52:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401624.643499; Wed, 07 Sep 2022 12:52:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuXb-0007Ac-5I; Wed, 07 Sep 2022 12:52:27 +0000 Received: by outflank-mailman (input) for mailman id 401624; Wed, 07 Sep 2022 12:52:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuXZ-0007AV-Oi for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 12:52:25 +0000 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [2607:f8b0:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb0c25c5-2eab-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 14:52:24 +0200 (CEST) Received: by mail-pg1-x534.google.com with SMTP id 202so13461737pgc.8 for ; Wed, 07 Sep 2022 05:52:24 -0700 (PDT) Received: from leoy-huanghe.lan (n058152048222.netvigator.com. [58.152.48.222]) by smtp.gmail.com with ESMTPSA id y15-20020a17090a16cf00b002005fcd2cb4sm6257213pje.2.2022.09.07.05.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 05:52:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb0c25c5-2eab-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=a+WaeHnZk55/Rn0ky4Kfi+q5eGygvNqLVsftUcAdhiA=; b=t5SqmITZkzz2V3WzMcyat6ypljDQVYyJB1Q6D+RxTHolFo7UTYN8ptjbLhn22xHMPn 8Q1dttpdamsiFDmmaEH3zr06KaRezJWaZQm43kiXEo4oPITCp3CYSzDlH2BFJdhu2k+l pcuO4uXzXW8zWX14FIrBTjgC/LkWl0sXMggTaT1nkbPB9eu6nUX3kKJjstXFhrZXDuGy owTGwugCeGRHXCtNRgbxW/pPm0eNC+DO5nu7g4RSxBuh1b7S1ea7pkpHDV7Swm1DfMKx lZk1SDh3Hy6PxIBPOI1wM/jGlfHtitS51xr77xXj8+QvDVuWVKcv1HcVJwuZxXoMFUaP xUoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=a+WaeHnZk55/Rn0ky4Kfi+q5eGygvNqLVsftUcAdhiA=; b=FIBBquqE7rhU4AQmDnmBUYkAEIXgDNoifAwluzfpVHRXFZQ3cuHWUsYZNLLvLYNrEP J4Giyim1+pKq1N3JAdJL9RQY4iBo5iCvZjqC0LWzlE/Q4dWB1+28vhzumlVtgv2mQC5Z uOMTssOtTHNFwbGkrNyhAKdIFtTE1qq25g88oJoxwXo46APbPAjWFis/CJAu99ua5z6c JU5fWoJpfEJY9qVHfdNq45M30ShPMZ5xFieSL+0V5887uuNve7ss1mKjeWUVij/Tbx9/ yHs7h6HR30O2Opb33OabL7qhDF9xGOzHxtqVSnpTc7XYUPbQ0OgPN8yruT5qufQnFoli QyMg== X-Gm-Message-State: ACgBeo1iEfTYHenL+dgRWrMJhR3exLHMysOhMD13R/GVdbxe0rvcLQAt O0gV6kjnNlVKCNoW3l0cMt0eGQ== X-Google-Smtp-Source: AA6agR5xR1q6IL1nd8omUPFYa4NLsVlbrSb6T5V8+PhJmUcVxUQgLdgHRbEetuS8PxAuPA2qbol23Q== X-Received: by 2002:a63:82c1:0:b0:434:ac18:f6e with SMTP id w184-20020a6382c1000000b00434ac180f6emr3291684pgd.120.1662555142910; Wed, 07 Sep 2022 05:52:22 -0700 (PDT) Date: Wed, 7 Sep 2022 20:52:16 +0800 From: Leo Yan To: Jan Beulich Cc: Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen: Add macro for version number string Message-ID: References: <20220907120420.387771-1-leo.yan@linaro.org> <4A5E6FC5-1716-4D7E-95EB-83CA6451D88A@arm.com> <19658a68-573f-9d27-ead3-fd0c57dcf68a@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19658a68-573f-9d27-ead3-fd0c57dcf68a@suse.com> On Wed, Sep 07, 2022 at 02:34:25PM +0200, Jan Beulich wrote: > On 07.09.2022 14:20, Bertrand Marquis wrote: > > Hi Leo, > > > > Thanks a lot for the quick handling here. > > > >> On 7 Sep 2022, at 13:04, Leo Yan wrote: > >> > >> On Arm64 Linux kernel prints log for Xen version number: > >> > >> Xen XEN_VERSION.XEN_SUBVERSION support found > >> > >> The header file "xen/compile.h" is missed so that XEN_VERSION and > >> XEN_SUBVERSION are not defined, __stringify() wrongly converts them as > >> strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION". > >> > >> This patch introduces a string macro XEN_VERSION_STRING, we can directly > >> use it as version number string, as a result it drops to use of > >> __stringify() to make the code more readable. > >> > >> The change has been tested on Ampere AVA Arm64 platform. > >> > >> Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c") > >> Suggested-by: Bertrand Marquis > >> Signed-off-by: Leo Yan > > Reviewed-by: Bertrand Marquis > > > > Regarding the change suggested by Jan to add spaces, I think it is a > > good idea so if the commiter agrees to do on it on commit please do, > > otherwise we can keep this as is. > > If I end up committing this, I'd be happy to add the blanks, and therefore > I'm inclined to say no need for a re-send. For easier for maintainers, have sent patch v2 with adding blank and adding review tags. Thanks! Leo From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:53:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:53:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401631.643510 (Exim 4.92) (envelope-from ) id 1oVuYr-0007lX-Kw; Wed, 07 Sep 2022 12:53:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401631.643510; Wed, 07 Sep 2022 12:53:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuYr-0007lQ-G4; Wed, 07 Sep 2022 12:53:45 +0000 Received: by outflank-mailman (input) for mailman id 401631; Wed, 07 Sep 2022 12:53:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuYp-0007ko-LJ; Wed, 07 Sep 2022 12:53:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuYp-0005fN-Gb; Wed, 07 Sep 2022 12:53:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuYp-0005Ng-2J; Wed, 07 Sep 2022 12:53:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVuYp-0001Ws-1l; Wed, 07 Sep 2022 12:53:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ztmtAHeC2dq6fdLgFNNyBwf4KOZ1brtZPGX/bvssWqE=; b=IqOHiad+cMGvp0/POSuvZY2+NT 9bqzevv6bMcyYwOxbFRO+GhHhEriJAEcwjXY4p85CjHzxVEcnvZIf/uEVmvM5XwheZASFWkujRo0W D0E/yxfJuxCE5AGSTgPisFM0lZujs1I/vDvyX+v1v/WY9Y6Sl0hKOGor3Nn7pph1L9vM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173043: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=512042eba87ff97a4820a55cf3b1a89a8afd1cc7 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 12:53:43 +0000 flight 173043 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173043/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 512042eba87ff97a4820a55cf3b1a89a8afd1cc7 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 34 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 260 attempts Testing same since 173043 2022-09-07 09:48:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2139 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 12:56:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 12:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401642.643521 (Exim 4.92) (envelope-from ) id 1oVubh-0008Rs-94; Wed, 07 Sep 2022 12:56:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401642.643521; Wed, 07 Sep 2022 12:56:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVubh-0008Rl-5H; Wed, 07 Sep 2022 12:56:41 +0000 Received: by outflank-mailman (input) for mailman id 401642; Wed, 07 Sep 2022 12:56:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVubg-0008RW-6p; Wed, 07 Sep 2022 12:56:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVubg-0005lJ-4D; Wed, 07 Sep 2022 12:56:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVubf-0005We-Pi; Wed, 07 Sep 2022 12:56:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVubf-00048U-PF; Wed, 07 Sep 2022 12:56:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3V4mN5eDvk8oTc6DI9KtBqr9uEKKtNAD8Kc0Rg6JV9A=; b=FnFS8GNIAB30zrGpO7+DKoid3G EXAl1AYY8fluYijYWp06mSZ0ZswO0ZgjQMoxmAO9CAGDdhWlnhvWB6OLU7kuBEOICuEV5jRb7jbAs tImAILt0wlJPl42dbRG0C5Li3qQ0Kc+80U5gLQNtSwh/LalVjNGSrMAq//k0YNmJd4a0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173034: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0066f1b0e27556381402db3ff31f85d2a2265858 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Wed, 07 Sep 2022 12:56:39 +0000 flight 173034 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173034/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0066f1b0e27556381402db3ff31f85d2a2265858 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 34 days Failing since 172152 2022-08-05 04:01:26 Z 33 days 76 attempts Testing same since 173034 2022-09-07 03:00:08 Z 0 days 1 attempts ------------------------------------------------------------ 1702 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175131 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:01:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401651.643532 (Exim 4.92) (envelope-from ) id 1oVug5-0001aN-R9; Wed, 07 Sep 2022 13:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401651.643532; Wed, 07 Sep 2022 13:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVug5-0001aG-O5; Wed, 07 Sep 2022 13:01:13 +0000 Received: by outflank-mailman (input) for mailman id 401651; Wed, 07 Sep 2022 13:01:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVug5-0001aA-8g for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:01:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVug4-0005tC-VN; Wed, 07 Sep 2022 13:01:12 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVug4-0002M9-NC; Wed, 07 Sep 2022 13:01:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tFLOGVsaec1S7Yg1ZuhZf6vw0vm8mmJEGOrYUELJloc=; b=n6lXuU7UKCP3SPkDsrZ+AnI3O3 zWdnb0DdK4kW2Mf+Ac83RizDDx8VdDz/bZ0HnxugvVKQaUKQTWh6Ioz/1zr7omCzCMQovsIoGehfz zr/uA61SI7n70BroxFJOn1E4UYJF5N7QjnrcNEKHZmOT3uevF5XR2kGXRpaJxjQronns=; Message-ID: Date: Wed, 7 Sep 2022 14:01:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/09/2022 14:40, Rahul Singh wrote: > Restrict the maximum number of evtchn supported for domUs to avoid > allocating a large amount of memory in Xen. > > Set the default value of max_evtchn_port to 1023. The value of 1023 > should be sufficient for domUs guests because on ARM we don't bind To me, domUs and guests mean the same. So s/guests// > physical interrupts to event channels. The only use of the evtchn port > is inter-domain communications. Another reason why we choose the value > of 1023 to follow the default behavior of libxl. > > Signed-off-by: Rahul Singh > Reviewed-by: Michal Orzel > --- > Changes in v4: > - fix minor comments in commit msg > - Added Michal Reviewed-by > Changes in v3: > - added in commit msg why we set the max_evtchn_port value to 1023. > - added the comment in code also why we set the max_evtchn_port to 1023 > - remove the define and set the value to 1023 in code directly. > Changes in v2: > - new patch in the version > --- > xen/arch/arm/domain_build.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..fde133cd94 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3277,7 +3277,13 @@ void __init create_domUs(void) > struct xen_domctl_createdomain d_cfg = { > .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, > .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, > - .max_evtchn_port = -1, > + /* > + * The default of 1023 should be sufficient for domUs guests To me, domUs and guests mean the same. So s/guests// Same here. With that: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:05:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:05:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401658.643543 (Exim 4.92) (envelope-from ) id 1oVujl-0002CI-AO; Wed, 07 Sep 2022 13:05:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401658.643543; Wed, 07 Sep 2022 13:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVujl-0002CB-7M; Wed, 07 Sep 2022 13:05:01 +0000 Received: by outflank-mailman (input) for mailman id 401658; Wed, 07 Sep 2022 13:05:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVujj-0002C3-IE for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:05:00 +0000 Received: from out2.migadu.com (out2.migadu.com [2001:41d0:2:aacc::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab1dbe95-2ead-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:04:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab1dbe95-2ead-11ed-af93-0125da4c0113 Date: Wed, 7 Sep 2022 09:04:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662555894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3UodEGmtAL0Z2fi75TPwE5UbXZRqdKXtyJj7vm5kpXk=; b=er2MzJbTg47iAo/XMusErAaGYdN6LhjL9qJ7uEt4qEtP6HbsNa3eddpgjMgNqeDLP23aLT Gwip6c5VZ7JEEH0cUPSDYRDY/kPSA/0lPyiKeXik8d/k2hQ2yrItfs4NovpVivoEk4ZzdX atkHw1ns446d4aZFxAc03p1ps6wQ2SU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220907130323.rwycrntnckc6h43n@kmo-framework> References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > Hmm, it seems that further discussion doesn't really make much sense > here. I know how to use my time better. Just a thought, but I generally find it more productive to propose ideas than to just be disparaging. Cheers, Kent From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:09:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:09:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401665.643554 (Exim 4.92) (envelope-from ) id 1oVunr-0002tP-RB; Wed, 07 Sep 2022 13:09:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401665.643554; Wed, 07 Sep 2022 13:09:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVunr-0002tI-OD; Wed, 07 Sep 2022 13:09:15 +0000 Received: by outflank-mailman (input) for mailman id 401665; Wed, 07 Sep 2022 13:09:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVunq-0002tC-1P for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:09:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVunp-00062E-NH; Wed, 07 Sep 2022 13:09:13 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVunp-0002ho-HR; Wed, 07 Sep 2022 13:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nEgytAqoIrDwIJUb1uAV841ZpJnJnGzO+XSBQUOD1X0=; b=qB38DkG7g5caWm6YDOvgdIR9dS JSz2OwUga8h1Kc9y9Io6vdQOlFc6CNC0wwehykp3162eSey1IX00FoJarv9IXKrHz4dqR78N6v910 YAEuUEJUlMSh8zE5kFx7Ri5UFhHJy01Bsq9zs/0BI4f0e/Dyn3ZiGIST1FuKLBst9n7Q=; Message-ID: Date: Wed, 7 Sep 2022 14:09:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul On 06/09/2022 14:40, Rahul Singh wrote: > Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to > disable xenstore interface for dom0less guests. > > Signed-off-by: Rahul Singh > --- > Changes in v4: > - Implement defines for dom0less features > Changes in v3: > - new patch in this version > --- > docs/misc/arm/device-tree/booting.txt | 4 ++++ > xen/arch/arm/domain_build.c | 10 ++++++---- > xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- > 3 files changed, 31 insertions(+), 6 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..1b0dca1454 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -204,6 +204,10 @@ with the following properties: > - "disabled" > Xen PV interfaces are disabled. > > + - no-xenstore > + Xen PV interfaces, including grant-table will be enabled but xenstore Please use "All default" in front. So it is clear that everything is enabled but xenstore. > + will be disabled for the VM. > + > If the xen,enhanced property is present with no value, it defaults > to "enabled". If the xen,enhanced property is not present, PV > interfaces are disabled. > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 707e247f6a..0b164ef595 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > goto err; > } > > - if ( kinfo->dom0less_enhanced ) > + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) > { > ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); > if ( ret ) > @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *d, > (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) > { > if ( hardware_domain ) > - kinfo.dom0less_enhanced = true; > + kinfo.dom0less_feature = DOM0LESS_ENHANCED; > else > - panic("Tried to use xen,enhanced without dom0\n"); > + panic("At the moment, Xenstore support requires dom0 to be present\n"); > } > + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) > + kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; > > if ( vcpu_create(d, 0) == NULL ) > return -ENOMEM; > @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, > if ( rc < 0 ) > return rc; > > - if ( kinfo.dom0less_enhanced ) > + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) > { > ASSERT(hardware_domain); > rc = alloc_xenstore_evtchn(d); > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index c4dc039b54..ad240494ea 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -9,6 +9,25 @@ > #include > #include > > +/* > + * List of possible features for dom0less domUs > + * > + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. All the > + * default features (excluding Xenstore) will be > + * available. Note that an OS *must* not rely on the > + * availability of Xen features if this is not set. > + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > + * can't be enabled without the > + * DOM0LESS_ENHANCED_NO_XS. > + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > + * default features (including Xenstore) will be > + * available. Note that an OS *must* not rely on the > + * availability of Xen features if this is not set. > + */ > +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) > +#define DOM0LESS_XENSTORE BIT(1, U) > +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XENSTORE) > + > struct kernel_info { > #ifdef CONFIG_ARM_64 > enum domain_type type; > @@ -36,8 +55,8 @@ struct kernel_info { > /* Enable pl011 emulation */ > bool vpl011; > > - /* Enable PV drivers */ > - bool dom0less_enhanced; > + /* Enable/Disable PV drivers interface,grant table, evtchn or xenstore */ The part after "," is technically wrong because it also affects other interfaces. But I would drop it to avoid any stale comment (we may add new one in the futures). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:09:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:09:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401666.643565 (Exim 4.92) (envelope-from ) id 1oVuo7-0003M7-9G; Wed, 07 Sep 2022 13:09:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401666.643565; Wed, 07 Sep 2022 13:09:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuo7-0003Ly-5m; Wed, 07 Sep 2022 13:09:31 +0000 Received: by outflank-mailman (input) for mailman id 401666; Wed, 07 Sep 2022 13:09:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuo5-0003Jk-SX for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:09:29 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2055.outbound.protection.outlook.com [40.107.223.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ce2e576-2eae-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:09:28 +0200 (CEST) Received: from MW4P222CA0026.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::31) by PH7PR12MB6857.namprd12.prod.outlook.com (2603:10b6:510:1af::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 13:09:24 +0000 Received: from CO1NAM11FT076.eop-nam11.prod.protection.outlook.com (2603:10b6:303:114:cafe::58) by MW4P222CA0026.outlook.office365.com (2603:10b6:303:114::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 13:09:24 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT076.mail.protection.outlook.com (10.13.174.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:09:23 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 08:09:23 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 08:09:22 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ce2e576-2eae-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PU0o/wLhsOIJj3f7+zwac+tMAkcOScvvKE8ohKCGtYSbZHOrTR7p6OBLqmQrSmexzPXB7TFfpxP/WZGKSW2pZlhUA1PvfdbTv89BOvmxwYSrQi4FBcHYqyPgvM0PnmHq7Ml6m8ve/WtomHyI5H/fjLTqX8UfgzJjTx4699uMG2iAifecpq2yXaCRlQwMON8LvXQFGZxuTqX/+DHkN1ipp6g66/O2Qh65RtoNVkEoXwN87EVAqAqtofAZ5PWH1XQqfXUiOWLO7xYTTZ+VuBL+2e0gz9VjohHDPBHOLJ0rVYfP3rhqiEYT1pKBhV44r1AKEN/gCZjNLH7Rh247mnezgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9vzPyE8xor0r9dzeedEC92Swjehb9AImQgAdIXjz2/c=; b=d6xaCsHiCOxPXrcG226+qbjfTXl4OVkggr7g4lQShEAkCgULF0KEG2FYjYz4pVe2gtsNRgI9D8rHCDbE8DIGt8VQH8Wgn6Cb91sbtt7bPJKRuCcjwv2R1WrER6KjiMLAZvDv1sSB6REMr7xA900U2nQiCHII2wA7IwJ4lnFQZsHkz69IlzUUvQbvCPaRmZJjoKjOx9fG1LYOVOL8U1v0iHLlKGhxnMqz61dwaGh2HsTmk4GNFMRndOSxFqsIm0GUcfZ9zBsN7m9srcV+XhKtN343UTbQHFbCA/wdi8AI7mh2u7rs09MjYp6tNJ1WZNpILjZLdUL1q8PMi2K6uYt4bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9vzPyE8xor0r9dzeedEC92Swjehb9AImQgAdIXjz2/c=; b=qxOhSyojmfJ1RD+G1Wmh19g9FxsH3GQyP3gT5ACXze/EpcNUhhv30fbQK7qYFMeXCbU8ttyxYhO3ddjP/4IZAxB8hdlEiIVfeZwTAcjwUeRpz5cVfM/GBFkpGTcHTR34ZddS17O5cJVs4MTAL4HqX3Nd7GXZLiwpgIXjsJ4ocMU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 7 Sep 2022 15:09:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Julien Grall , Henry Wang , CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT076:EE_|PH7PR12MB6857:EE_ X-MS-Office365-Filtering-Correlation-Id: b1d79cd8-3a66-4dd5-4f24-08da90d22f89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wCWJ4Kzxo7am9GkH3GE8miSInFSk3wd+HNkX6ChL0qQgjh8XpHYnAiYxdxFOPe5Qqvf9e5XCcrtpQ2fqD4qBIL/lTBbo9p5UeUT68sSV9NP5RRbOyNR5rzAwZ4di8duXyzJWvNLCB/+5bsmualdfwGqGZJkkYbw3xEHi0fDO1kfdmy/UzKYhBIwwMdn9sSn+sh6t5wi6TPGnwLy0EQZDXUQ2kcFEEXBiOe9xGls1uGFXNsyu8jc9gC5Rde6ozHXxDSf0aKNoEFSG2pjlKTQTkIBoec9awN3ugn1MS0ahWY0DiJd1MpvMtSgDVJ4y7MUZ62fJb0eaYAdO0L+nuxxP5KhRV2e77LqOeZ7+cKnhI/YGaUU5hgtidM9QOMxUsl6bAjxr1dmVtYQpp1EB3Y+PLptSMHZeC71Z1HEieN0fQcQvwJBQyX9vr5FrwBGnJhIzKglBKN1kja/zyxRJZ8Ddi91uw3yvdomZQRBJRaGVQjoetYuEEirhUOcRyzqJ3v92ceSZBDArdljTzZCi2jOLEJ0kGBxnvmNIACJJUS5fdxjOs60U1ci+zmTjqW8gsQP9NKzKclihYIf+/4C8dvegXQRrKHrJUy27UjSnqZP8IuHJNoqf91D9BN3y2NIU5RSJCtRV21VSNMk3XWNRJqM8kgpNLRcOXzVzsLUM09w/u3CfAAGliDUdsDLyK2vYxU9Krwk2k3gFPJW0HU7dxedIsNXb8SIAyXkL3/KYJc3eCtSthyV6kiJ4allSxFHngBJ/1X1zYep6fxdmgLaqRUQYgV5HV/qp1AP7CrefZZycqsQibES5UTTnVjBMzk7ER4najWlIKbHpG+6MFh7uXOiuTFvwmXu+KVBaBvkWWNxpMUs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(36840700001)(46966006)(40470700004)(2906002)(47076005)(2616005)(31696002)(40480700001)(26005)(966005)(336012)(41300700001)(82310400005)(186003)(86362001)(82740400003)(81166007)(478600001)(53546011)(426003)(356005)(40460700003)(36860700001)(70206006)(83380400001)(8676002)(70586007)(5660300002)(110136005)(4326008)(45080400002)(316002)(16576012)(44832011)(54906003)(36756003)(31686004)(8936002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:09:23.9531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1d79cd8-3a66-4dd5-4f24-08da90d22f89 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT076.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6857 On 07/09/2022 14:45, Julien Grall wrote: > > On 07/09/2022 13:41, Michal Orzel wrote: >> >> >> On 07/09/2022 14:32, Julien Grall wrote: >>> [CAUTION: External Email] >>> >>> On 07/09/2022 13:12, Michal Orzel wrote: >>>> Hi Julien, >>> >>> Hi Michal, >>> >>>> On 07/09/2022 13:36, Julien Grall wrote: >>>>> >>>>> Hi Henry, >>>>> >>>>> While reviewing the binding sent by Penny I noticed some inconsistency >>>>> with the one you introduced. See below. >>>>> >>>>> On 07/09/2022 09:36, Henry Wang wrote: >>>>>> +- xen,static-heap >>>>>> + >>>>>> + Property under the top-level "chosen" node. It specifies the address >>>>>> + and size of Xen static heap memory. Note that at least a 64KB >>>>>> + alignment is required. >>>>>> + >>>>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>>>>> + >>>>>> + Specify the number of cells used for the address and size of the >>>>>> + "xen,static-heap" property under "chosen". >>>>>> + >>>>>> +Below is an example on how to specify the static heap in device tree: >>>>>> + >>>>>> + / { >>>>>> + chosen { >>>>>> + #xen,static-heap-address-cells = <0x2>; >>>>>> + #xen,static-heap-size-cells = <0x2>; >>>>> >>>>> Your binding, is introduce #xen,static-heap-{address, size}-cells >>>>> whereas Penny's one is using #{address, size}-cells even if the property >>>>> is not "reg". >>>>> >>>>> I would like some consistency in the way we define bindings. Looking at >>>>> the tree, we already seem to have introduced >>>>> #xen-static-mem-address-cells. So maybe we should follow your approach? >>>>> >>>>> That said, I am wondering whether we should just use one set of property >>>>> name. >>>>> >>>>> I am open to suggestion here. My only request is we are consistent (i.e. >>>>> this doesn't depend on who wrote the bindings). >>>>> >>>> In my opinion we should follow the device tree specification which states >>>> that the #address-cells and #size-cells correspond to the reg property. >>> >>> Hmmm.... Looking at [1], the two properties are not exclusive to 'reg' >>> Furthermore, I am not aware of any restriction for us to re-use them. Do >>> you have a pointer? >> >> As we are discussing re-usage of #address-cells and #size-cells for custom properties that are not "reg", >> I took this info from the latest device tree specs found under https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.devicetree.org%2Fspecifications%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C4f35e9f93b7443ac73c808da90cecc22%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637981515122993111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TiESYS6RXdiPLX8WFUV0CsztAvK7mHSud%2B0xoJqwAw0%3D&reserved=0: >> "The #address-cells property defines the number of cells used to encode the address field in a child node's reg property" >> and >> "The #size-cells property defines the number of cells used to encode the size field in a child node’s reg property" > > Right. But there is nothing in the wording suggesting that > #address-cells and #size-cells can't be re-used. From [1], it is clear > that the meaning has changed. > > So why can't we do the same? I think this is a matter of how someone reads these sentences. I do not think that such documents need to state: "This property is for the reg. Do not use it for other purposes." The first part of the sentence is enough to inform what is supported. On the other hand, looking at [1] these properties got new purposes so I think we could do the same. Now the question is whether we want that. I think it is doable to just have a single pair of #address/#size properties. For instance xen,shared-mem requiring just 0x1 for address/size and reg requiring 0x2. This would just imply putting additional 0x00. > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:09:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:09:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401667.643571 (Exim 4.92) (envelope-from ) id 1oVuo7-0003Pv-OE; Wed, 07 Sep 2022 13:09:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401667.643571; Wed, 07 Sep 2022 13:09:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuo7-0003PG-Fx; Wed, 07 Sep 2022 13:09:31 +0000 Received: by outflank-mailman (input) for mailman id 401667; Wed, 07 Sep 2022 13:09:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVuo6-0003Jk-Ko for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:09:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e70cfc2-2eae-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:09:29 +0200 (CEST) Received: from FR3P281CA0029.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::22) by GV1PR08MB7732.eurprd08.prod.outlook.com (2603:10a6:150:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Wed, 7 Sep 2022 13:09:21 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1c:cafe::8e) by FR3P281CA0029.outlook.office365.com (2603:10a6:d10:1c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:09:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:09:21 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 13:09:21 +0000 Received: from e411e0bbb69c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9017FDC5-428E-4B2A-9FC8-9D6B1E9983B0.1; Wed, 07 Sep 2022 13:09:09 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e411e0bbb69c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:09:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7422.eurprd08.prod.outlook.com (2603:10a6:10:371::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 7 Sep 2022 13:09:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:09:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e70cfc2-2eae-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PkNk1rMEfdkOyAoG0XNCLu1t54VV1POCYWJrOD2B6092Oq3/PZZ9bAitOUXP29nQugo7MlUyJUSbIjSJNgysjAXBghKF5E/YUaTe/IHgFispDc8jLd9L/qIJQjkaOQX52gmElwJSllAnNyMvyKLqkwldOlyQfXllglce/T62uAqb7nYzjMeOmm8vFfo7tbfFmhIM4NgMf4uKhlGizShbcBoPk5vSL+biaZOicEbaSg8EwgHEYwyFRS8HrQwz1lm52EeB6U2eZtUi9VDf8Xso1uaDlW3ComJofi49ltpdIYd6jG1bZMHPHJij+YCgAs2ZBp+FjnABj99A9XPj9++3tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pu90OKSD6I9CjvlJHqdkQC2NU9v6LeR4717/HITzoyo=; b=Yt6KZT15aCDKIp+I8YYYbPU0K3BQ6Qxag/o3cglq7W5woQDkaAD+vtyNJqco9YxXtuntXKxVc4TmBAheVoPNYAPXlSrMgPrE12HoD0nss6Ct2sqvs3n9jQT7OXefyk5MR9t6ZFM0Dbavez/oBStiTnMiWMkOGcyx850M2+bCTxeBYShERMmUslIdcID53m5Ncz56VYXxh9dQeAjM0qii0ra0Rbv/qEWUqQuofY0qhuaPPV2Wix4w/Lo+q/9JLirdpIvolagMgXvaX4RPjxgQzEnUZrzF+0f/9eehQXY6Mi2cUwmG/685q7QRRrbJuqQ6XWzcpYeD11saoHhyKbWtQg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pu90OKSD6I9CjvlJHqdkQC2NU9v6LeR4717/HITzoyo=; b=cIOj4zNhFY8wqBEmsjmfK6nhqnCAdxdgWrnptNveSgUTjJ49K2Qd74BQ9ig91mkKmaHnkE+I7czFIxbdSoyOz069uLUIu5BfYRLwQibmQ9Mb3muWNt1/ASDFp+bspfk6hRlHE4LvnwxQzyxftByW8yuNr0eYsFOQtSqPo4hcvUs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3c69b11ac487930d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lGF7T1Bwsta672YT6KledCZPIAXNUebUYOTqPlYJUm1XFx7XJPMtmaCJbuV7Se5jc/idmn8VGfFLaZvsZ1DNgnvhxzAANcAUBh4zwSbKEBSVx76Vb57jgJtaTwxUynU+/BZcfdnDIeV62cKpU9qM0wlZC9hkVjiUFXEDwQrjHPagmj5v0kCEwlWVhCy240OkAQNYluqbM4LbKhQFbQf02ACMrFynbYeDC0kOCdwblCQU6UcT6K0Dg452To3IoiywxUCjh+ABW126GqYIHv807yW7SsfBK3ib9fKr3EuSpbIRzHUZ9IuCEv3tBVtHGbvlHNrlZpohe2NLt8x2EbJoLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pu90OKSD6I9CjvlJHqdkQC2NU9v6LeR4717/HITzoyo=; b=RpzvxUomOqNcmdWrdJoUuzHGNSQK+CaOjToelJgO0gKAitn/yUJUzJeZwGOML6NaCRAHrbJ8m4q0ss4yajViEWj9/jVH0x8KRKhJBMrLHZITqZU/J0/UkPCxv8toHHtzWDu8dMtFItg6FHDrtGwqm7xV/g65HdTI6XjU1YSWoaXdQ9iy52E1Pmr5ooZBajGixwhmdap6/ixorrOpmlh15WzWVUa6YbzpNu/oeajok0WK/xsm/dWi/YRllhXwpjzuwR7uYxmVyTnaB5W+Cfk2ZNIN9VG5DXpm8QqeVGrzDom+6A8LrbiTiLLi4NJMNwv8WuslbvCyC+CGeJQDUZUUaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pu90OKSD6I9CjvlJHqdkQC2NU9v6LeR4717/HITzoyo=; b=cIOj4zNhFY8wqBEmsjmfK6nhqnCAdxdgWrnptNveSgUTjJ49K2Qd74BQ9ig91mkKmaHnkE+I7czFIxbdSoyOz069uLUIu5BfYRLwQibmQ9Mb3muWNt1/ASDFp+bspfk6hRlHE4LvnwxQzyxftByW8yuNr0eYsFOQtSqPo4hcvUs= From: Bertrand Marquis To: Julien Grall CC: Michal Orzel , Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAa2AA== Date: Wed, 7 Sep 2022 13:09:07 +0000 Message-ID: <08B04F1C-FA10-4A71-A251-64ECB3C97F48@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7eb8f7f2-c693-4409-3775-08da90d22dd9 x-ms-traffictypediagnostic: DB9PR08MB7422:EE_|VE1EUR03FT006:EE_|GV1PR08MB7732:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3PFSCzvX8jVjnH5DfpEG5EUmQp/dttu432Jg1bpoZ2dx3L2EVKISz14sdYLT15WUFeuGDPeVyelCosoDoYelSwmVfO6xSR1GqHYDE2D0SUfR66Af6VIbAGYqB5Pkp5L6cyZ8+DdQsrI5bOD80OB5Rd23mIM+RXq/hGSvbhrLCbi3gFFFtb0OZ9ItxBwmthxIxXOAVkMOW23MMQKJLyId4Vn+UMe13BcaZzVb8NTRpWbKOu9H5xebq9Q8lMmA9xKduPXy23/51NgWRicRejGd5wbhg2Mk5u8WPXAvWdnSYCwBEh8PTFLiko3CevV0V40f4E/bTKMCW3JsrY8yo3hRI+86COOWXaaxbQKS73EALEqGEPzQFZ6pFlWUD+mJduJVVt4dlG+14wv5j1lffbUrAruKXGwgxWGXLevL7tpLgkJvfLRwUoJ54RT4t4CO1+WjhhLjvk3a5tH5o668ZDyRDEHtCKbZT0rmYjE8nSfeIfmnqDvhAhZSR4Deg/+K9gLLXCoedFB5bG0o4TuYXsgzO2tbx1Wknu3ME0iX2lwk2AblcpK4vMvP9rTnn0qq7j+nfz6/yV255LHgjm36wBdblM7e1qTXJYsKkkrE+FX5tupQjVSKbZ+Qsn3hfRrmuL+tFJ+1p2ofX230viqo4GCluVCY9RxFFyK7bVxr1y40fnV0wn7ord+N9WRF7kHME5szyRYQeAnypvYw7sR9u4nWejo6a7zxhnVbi4iT5405s0CUn7w6E7BELPkKcgOGkAJd0ATJ7+I0ERrwGKNYuiA1LE9Joyl8np3BXJ7avEI61jrsbFTZoYrcBaQhxsSx0+upBzfG0GXFzZaEJtbW2zWNeg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(366004)(136003)(39860400002)(83380400001)(2616005)(186003)(76116006)(122000001)(38100700002)(8936002)(5660300002)(66476007)(64756008)(66446008)(66556008)(66946007)(2906002)(6512007)(478600001)(26005)(6506007)(91956017)(8676002)(71200400001)(6916009)(54906003)(4326008)(6486002)(53546011)(33656002)(966005)(38070700005)(36756003)(41300700001)(316002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7422 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ec52718-f7a1-47d7-66ab-08da90d2256b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4nxB4iqngB4N+JqbjxZPMQoLQWLXNQ4QuuCnD6QdgF0CTO4EtLM7sgVuxMlFoji3NGrxGrqii0CHFmQ9NLp7MpurHyDd+Mcf2K8V8bKCSfR80Bov2QtaVrA6dFIl6RfwIvo0EwGIOy4rI8H+KPR/IRbbF3hhMNNAfHVKlNB/iO9aBgAwbt2YWCvyewN26bdPdOdo9m4JEFwYU+N0asHIahGchyRYzbH1RXshqEK7NDoq7QNOtHjIBGDwR3qrjcUqPVINhljP3CXi13M4wFbna0Yi/yaa/nYJPbC8UjTcnCPm0aVBpMggGD+n7LSYpMPJrLjQebwMn9leALDd2mQ5FGj5IPaEzdfPYuh+g+w/NyzIki1Ebv6zxdJjM/ST26Uf1H8ZsjoF6XxUbb1J28lmQZBlrYFldnxsHM2oA29vlf3a357hRbzrsx40j161VXsT98pd6EEZg0Y4WfFv0hoMFGg6/tk9RVAveBGnWVcd51xbD4Emx+dNJSmAA5jC0b6d1/+fVAWZrY/AzhTA7XW3DvaUQV6x5GzgUAw3NMATJT5nEvVAS+hTWnN4VviNHw7NvD9r2LG1w8r3A4Q6D8HxAsxIGTHD6kSDINV+9h01zA21npH2H9e3eALyTlXJTh161A1gEp+fBxwa9K3vqbIlHDWdcjhkwNGI/82fhkaaBEzABUOsWYU1+ccplJ4vPmA54QEe82xFn9zxyxvabGtBgaMUmngE/Co74hzl6KUNh56cfWqY4YX1kvcRhu/pX5Bv2JYsjnVjUFNSMVmYWl+I1jY5vW0bh3yZKYFi/RLQ9vo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(346002)(376002)(40470700004)(36840700001)(46966006)(81166007)(41300700001)(478600001)(966005)(54906003)(316002)(2616005)(336012)(47076005)(186003)(356005)(40460700003)(36860700001)(83380400001)(6486002)(53546011)(26005)(6512007)(82740400003)(6506007)(86362001)(33656002)(82310400005)(36756003)(8676002)(2906002)(5660300002)(70586007)(6862004)(40480700001)(4326008)(8936002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:09:21.1369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7eb8f7f2-c693-4409-3775-08da90d22dd9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7732 SGksDQoNCj4gT24gNyBTZXAgMjAyMiwgYXQgMTM6NDUsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDEzOjQxLCBNaWNoYWwg T3J6ZWwgd3JvdGU6DQo+PiBPbiAwNy8wOS8yMDIyIDE0OjMyLCBKdWxpZW4gR3JhbGwgd3JvdGU6 DQo+Pj4gW0NBVVRJT046IEV4dGVybmFsIEVtYWlsXQ0KPj4+IA0KPj4+IE9uIDA3LzA5LzIwMjIg MTM6MTIsIE1pY2hhbCBPcnplbCB3cm90ZToNCj4+Pj4gSGkgSnVsaWVuLA0KPj4+IA0KPj4+IEhp IE1pY2hhbCwNCj4+PiANCj4+Pj4gT24gMDcvMDkvMjAyMiAxMzozNiwgSnVsaWVuIEdyYWxsIHdy b3RlOg0KPj4+Pj4gDQo+Pj4+PiBIaSBIZW5yeSwNCj4+Pj4+IA0KPj4+Pj4gV2hpbGUgcmV2aWV3 aW5nIHRoZSBiaW5kaW5nIHNlbnQgYnkgUGVubnkgSSBub3RpY2VkIHNvbWUgaW5jb25zaXN0ZW5j eQ0KPj4+Pj4gd2l0aCB0aGUgb25lIHlvdSBpbnRyb2R1Y2VkLiBTZWUgYmVsb3cuDQo+Pj4+PiAN Cj4+Pj4+IE9uIDA3LzA5LzIwMjIgMDk6MzYsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+Pj4+Pj4gKy0g eGVuLHN0YXRpYy1oZWFwDQo+Pj4+Pj4gKw0KPj4+Pj4+ICsgICAgUHJvcGVydHkgdW5kZXIgdGhl IHRvcC1sZXZlbCAiY2hvc2VuIiBub2RlLiBJdCBzcGVjaWZpZXMgdGhlIGFkZHJlc3MNCj4+Pj4+ PiArICAgIGFuZCBzaXplIG9mIFhlbiBzdGF0aWMgaGVhcCBtZW1vcnkuIE5vdGUgdGhhdCBhdCBs ZWFzdCBhIDY0S0INCj4+Pj4+PiArICAgIGFsaWdubWVudCBpcyByZXF1aXJlZC4NCj4+Pj4+PiAr DQo+Pj4+Pj4gKy0gI3hlbixzdGF0aWMtaGVhcC1hZGRyZXNzLWNlbGxzIGFuZCAjeGVuLHN0YXRp Yy1oZWFwLXNpemUtY2VsbHMNCj4+Pj4+PiArDQo+Pj4+Pj4gKyAgICBTcGVjaWZ5IHRoZSBudW1i ZXIgb2YgY2VsbHMgdXNlZCBmb3IgdGhlIGFkZHJlc3MgYW5kIHNpemUgb2YgdGhlDQo+Pj4+Pj4g KyAgICAieGVuLHN0YXRpYy1oZWFwIiBwcm9wZXJ0eSB1bmRlciAiY2hvc2VuIi4NCj4+Pj4+PiAr DQo+Pj4+Pj4gK0JlbG93IGlzIGFuIGV4YW1wbGUgb24gaG93IHRvIHNwZWNpZnkgdGhlIHN0YXRp YyBoZWFwIGluIGRldmljZSB0cmVlOg0KPj4+Pj4+ICsNCj4+Pj4+PiArICAgIC8gew0KPj4+Pj4+ ICsgICAgICAgIGNob3NlbiB7DQo+Pj4+Pj4gKyAgICAgICAgICAgICN4ZW4sc3RhdGljLWhlYXAt YWRkcmVzcy1jZWxscyA9IDwweDI+Ow0KPj4+Pj4+ICsgICAgICAgICAgICAjeGVuLHN0YXRpYy1o ZWFwLXNpemUtY2VsbHMgPSA8MHgyPjsNCj4+Pj4+IA0KPj4+Pj4gWW91ciBiaW5kaW5nLCBpcyBp bnRyb2R1Y2UgI3hlbixzdGF0aWMtaGVhcC17YWRkcmVzcywgc2l6ZX0tY2VsbHMNCj4+Pj4+IHdo ZXJlYXMgUGVubnkncyBvbmUgaXMgdXNpbmcgI3thZGRyZXNzLCBzaXplfS1jZWxscyBldmVuIGlm IHRoZSBwcm9wZXJ0eQ0KPj4+Pj4gaXMgbm90ICJyZWciLg0KPj4+Pj4gDQo+Pj4+PiBJIHdvdWxk IGxpa2Ugc29tZSBjb25zaXN0ZW5jeSBpbiB0aGUgd2F5IHdlIGRlZmluZSBiaW5kaW5ncy4gTG9v a2luZyBhdA0KPj4+Pj4gdGhlIHRyZWUsIHdlIGFscmVhZHkgc2VlbSB0byBoYXZlIGludHJvZHVj ZWQNCj4+Pj4+ICN4ZW4tc3RhdGljLW1lbS1hZGRyZXNzLWNlbGxzLiBTbyBtYXliZSB3ZSBzaG91 bGQgZm9sbG93IHlvdXIgYXBwcm9hY2g/DQo+Pj4+PiANCj4+Pj4+IFRoYXQgc2FpZCwgSSBhbSB3 b25kZXJpbmcgd2hldGhlciB3ZSBzaG91bGQganVzdCB1c2Ugb25lIHNldCBvZiBwcm9wZXJ0eQ0K Pj4+Pj4gbmFtZS4NCj4+Pj4+IA0KPj4+Pj4gSSBhbSBvcGVuIHRvIHN1Z2dlc3Rpb24gaGVyZS4g TXkgb25seSByZXF1ZXN0IGlzIHdlIGFyZSBjb25zaXN0ZW50IChpLmUuDQo+Pj4+PiB0aGlzIGRv ZXNuJ3QgZGVwZW5kIG9uIHdobyB3cm90ZSB0aGUgYmluZGluZ3MpLg0KPj4+Pj4gDQo+Pj4+IElu IG15IG9waW5pb24gd2Ugc2hvdWxkIGZvbGxvdyB0aGUgZGV2aWNlIHRyZWUgc3BlY2lmaWNhdGlv biB3aGljaCBzdGF0ZXMNCj4+Pj4gdGhhdCB0aGUgI2FkZHJlc3MtY2VsbHMgYW5kICNzaXplLWNl bGxzIGNvcnJlc3BvbmQgdG8gdGhlIHJlZyBwcm9wZXJ0eS4NCj4+PiANCj4+PiBIbW1tLi4uLiBM b29raW5nIGF0IFsxXSwgdGhlIHR3byBwcm9wZXJ0aWVzIGFyZSBub3QgZXhjbHVzaXZlIHRvICdy ZWcnDQo+Pj4gRnVydGhlcm1vcmUsIEkgYW0gbm90IGF3YXJlIG9mIGFueSByZXN0cmljdGlvbiBm b3IgdXMgdG8gcmUtdXNlIHRoZW0uIERvDQo+Pj4geW91IGhhdmUgYSBwb2ludGVyPw0KPj4gQXMg d2UgYXJlIGRpc2N1c3NpbmcgcmUtdXNhZ2Ugb2YgI2FkZHJlc3MtY2VsbHMgYW5kICNzaXplLWNl bGxzIGZvciBjdXN0b20gcHJvcGVydGllcyB0aGF0IGFyZSBub3QgInJlZyIsDQo+PiBJIHRvb2sg dGhpcyBpbmZvIGZyb20gdGhlIGxhdGVzdCBkZXZpY2UgdHJlZSBzcGVjcyBmb3VuZCB1bmRlciBo dHRwczovL3d3dy5kZXZpY2V0cmVlLm9yZy9zcGVjaWZpY2F0aW9ucy86DQo+PiAiVGhlICNhZGRy ZXNzLWNlbGxzIHByb3BlcnR5IGRlZmluZXMgdGhlIG51bWJlciBvZiA8dTMyPiBjZWxscyB1c2Vk IHRvIGVuY29kZSB0aGUgYWRkcmVzcyBmaWVsZCBpbiBhIGNoaWxkIG5vZGUncyByZWcgcHJvcGVy dHkiDQo+PiBhbmQNCj4+ICJUaGUgI3NpemUtY2VsbHMgcHJvcGVydHkgZGVmaW5lcyB0aGUgbnVt YmVyIG9mIDx1MzI+IGNlbGxzIHVzZWQgdG8gZW5jb2RlIHRoZSBzaXplIGZpZWxkIGluIGEgY2hp bGQgbm9kZeKAmXMgcmVnIHByb3BlcnR5Ig0KPiANCj4gUmlnaHQuIEJ1dCB0aGVyZSBpcyBub3Ro aW5nIGluIHRoZSB3b3JkaW5nIHN1Z2dlc3RpbmcgdGhhdCAjYWRkcmVzcy1jZWxscyBhbmQgI3Np emUtY2VsbHMgY2FuJ3QgYmUgcmUtdXNlZC4gRnJvbSBbMV0sIGl0IGlzIGNsZWFyIHRoYXQgdGhl IG1lYW5pbmcgaGFzIGNoYW5nZWQuDQo+IA0KPiBTbyB3aHkgY2FuJ3Qgd2UgZG8gdGhlIHNhbWU/ DQoNCkkgYWdyZWUgaGVyZSwgdGhvc2UgYXJlIHVzZWQgZm9yIGhvdyByZWcgaXMgZW5jb2RlZCBi dXQgbm90aGluZyBzYXlzIHRoYXQgd2UgY2Fubm90IHJldXNlIHRoZW0gZm9yIHRoZSBlbmNvZGlu ZyBvZiBzb21ldGhpbmcgZWxzZS4NCkV2ZW4gaWYgd2UgZG8gbm90IHVzZSDigJxyZWfigJ0gZm9y IHRob3NlIHNldHMsIHRoZXkgYXJlIHN0aWxsIGRlZmluaW5nIG1lbW9yeSBhZGRyZXNzZXMgYW5k IHNpemVzIHdoaWNoIGlzIGNvaGVyZW50Lg0KDQpJbiBzb21lIGNhc2VzIHJlZyBpcyB1c2VkIHRv IGVuY29kZSBzb21ldGhpbmcgZGlmZmVyZW50IHNvIHRob3NlIGNvdWxkIGhhdmUgZGlmZmVyZW50 IHZhbHVlcyB0aGF0IHdlIGNvdWxkIG5vdCB1c2UgYnV0IGZvciB0aGUgY2hvc2VuIG5vZGUsIHRo ZXkgc2hvdWxkIGFsd2F5cyBzZXQgdGhlIGVuY29kaW5nIGZvciBzb21ldGhpbmcgYWRkcmVzc2lu ZyBhIG1lbW9yeSBhcmVhLg0KDQpTbyBpZiB3ZSBoYXZlIGEgZ29vZCByZWFzb24gdGhlbiBJIHdv dWxkIHZvdGUgZm9yIHhlbixtZW1vcnktKiBwcm9wb3NhbCBidXQgc28gZmFyIEkgY291bGQgbm90 IGZpbmQgYSByZWFzb24gbm90IHRvIHVzZSB0aGUgc3RhbmRhcmQgb25lcy4NCg0KQ2hlZXJzDQpC ZXJ0cmFuZA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:13:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:13:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401689.643587 (Exim 4.92) (envelope-from ) id 1oVurz-0005fX-Fl; Wed, 07 Sep 2022 13:13:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401689.643587; Wed, 07 Sep 2022 13:13:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVurz-0005fQ-Ci; Wed, 07 Sep 2022 13:13:31 +0000 Received: by outflank-mailman (input) for mailman id 401689; Wed, 07 Sep 2022 13:13:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVurx-0005fK-QR for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:13:30 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50089.outbound.protection.outlook.com [40.107.5.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc62ec84-2eae-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:13:28 +0200 (CEST) Received: from AS9PR06CA0281.eurprd06.prod.outlook.com (2603:10a6:20b:45a::30) by PAWPR08MB8909.eurprd08.prod.outlook.com (2603:10a6:102:33a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 13:13:24 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::1b) by AS9PR06CA0281.outlook.office365.com (2603:10a6:20b:45a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:13:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:13:24 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Wed, 07 Sep 2022 13:13:24 +0000 Received: from 237868bb3936.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9CD3F0BE-244C-448C-92AB-E530D8692D3D.1; Wed, 07 Sep 2022 13:13:13 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 237868bb3936.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:13:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB9622.eurprd08.prod.outlook.com (2603:10a6:20b:619::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 13:13:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc62ec84-2eae-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VZN66kDjjJk/6KTqqYLkQt4d+qAwvWTvutXwi3r/EIXDDG50Fvd4APHhZFyUrv4DnZh7/0Zh1CqEovYyMcWpDZMt22HCr8w/slkkMsQWC9FdRxIUnBCQVQWACRf6QbQcwxTOzA2YiqaD6JfXHIcA+PsYmJmoVkjFWvrI77sYWZprpFUw+ZKCtMujytjakmCtDAYBfPFmFkrpX2uqBz+vkIKjKreX7CWNkMa31xR4JxyVhuIU7hcsGMt4XurrR2kdjZnpfMz4J/496K05aNHXPg+jownwnqPKNJaTqFdoOjRvRlh5CRdZ4x8zDH+RX/XTafqrUZ808CI7zhUr2k53bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPSZksgSqBgB1l2BBur1o6n8MHhWHapVGYMKO+qCT8w=; b=VorpxneZNDTsHaYBLHBG4bIVe4bUFB5x5R8c0BDoVQHL6mBS8x2ZrQni3J2nnp8EsFAmY/caNUaZsoD6EfCTpecogA5ezMWAd51kN+2AvGvBoyryLJRnYfZCm1lWabMMno3HHclDkYDka5SJaLsc26UfRzxw/n/NRmRQAaYYKYP3IfAeyuHBhY2W1/oGgNPAuV/7z/Y0DZ1cNTaUvhO8GgSs4MsXrULTeFpPvyWsDUKIDjAn3cZzWMk1BGfRbt7mVJXuYP1lStN02sKlTPdFq3xV5Z4hFip6PyXYAr335NWX+KyLHYKl9U1OmB1IZybOlfEfvo39eGWVr2MD0tGdRA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPSZksgSqBgB1l2BBur1o6n8MHhWHapVGYMKO+qCT8w=; b=WMwyLOHeWB8tsqSxD5sX+ckv+VS/3o8u4xwz+iacGKS1R6i4g59MWomIOAxygNUPHTo3A1MmSTqnVisradfMeosOI+xXF4nLJ9CE+VfDWh8um5dRZ1hWng8HtuK2a4RK8n5LZznceN5opRhawNfu+SnZJRxMtV22O9fCJ03r2hg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6ff5976b0da7620d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtnPNcIWGZtOlvem5t8/dOzl3K30U/1wK0ZhXbEzXH8LIulp/1vIbKHjAE1fWDKK1M0gamKw7phiokhdIAHcC8KP3Fk28jm7OHhsh4ZRqW5cWgG6nPiBXU6oS2DTT0C5sp5BVwRJZ1K3tdTTD4CF5UYAFVVr/l86DfsEqygMfetGWbL19pA4nSyFdJRaLPJZGTmUQAItKo9PwOe/HtocP8sKgo7e/n43rZucUkXlLkO0Jkck/7QGKZMj+TaNi7qAWc799k9s52BwS0CrVkfyhYLh50EaBUZYwFIO8ahePNQuXpGx7typ8lhVoyuLFHf6iQxZGD+TvWnQcumSc3baRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPSZksgSqBgB1l2BBur1o6n8MHhWHapVGYMKO+qCT8w=; b=jd6NYncs4Y7VpVp/QZj/fhbR/lkIasD4oB8BVVcBB+y8iYmLyKuV6zO8ZsCSExG5Z0Y/lDIrfAAF4q9hfz/937n8igQdNP32NxfiMHIEZ6VGtTKTU9vVfQqQtwBv0i7CpYVuX2awuKMk446vCc2Amog+oYuLujcvAANRfe/1++qQzn23e1DFFXILqhOyMZQx5P5LN0JHL53cHQN8QiMUSZ1Jjbs7Vy7WmHxDggdVHYzUYbPLjE9nmMSa5hqV6u3AKcRfXPYXyXu0VV4la7hNJ5XMF39S/XCkRW5Ww2Y/73GcpjJvJjAd1sTCQCex8z+FLyQkK6JNUzag6QWpuUVJpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPSZksgSqBgB1l2BBur1o6n8MHhWHapVGYMKO+qCT8w=; b=WMwyLOHeWB8tsqSxD5sX+ckv+VS/3o8u4xwz+iacGKS1R6i4g59MWomIOAxygNUPHTo3A1MmSTqnVisradfMeosOI+xXF4nLJ9CE+VfDWh8um5dRZ1hWng8HtuK2a4RK8n5LZznceN5opRhawNfu+SnZJRxMtV22O9fCJ03r2hg= From: Bertrand Marquis To: Jan Beulich CC: Rahul Singh , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYwqqLAtgrk5Z7CEC9g3vN92mek63T3yeAgAASqwA= Date: Wed, 7 Sep 2022 13:13:11 +0000 Message-ID: <06E1E4AB-5DA1-4AC4-9452-9507C2B75E81@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5916710e-4d75-41db-c01f-08da90d2bec4 x-ms-traffictypediagnostic: AS8PR08MB9622:EE_|AM7EUR03FT032:EE_|PAWPR08MB8909:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bUu7gQn6wo7fs7fxbfo2FOcTBLyLM6oYxR6tX5107pLTECB3GjeO0UecbLnfSPdr7Rfo/gmXeC6UhurGOMVnadQSAh9ozqw8joUcsU0Ol3MgBBTXwpGME/szKxbYHYkDr3vlkSKSknpvohmKQazIKtpDeHACvgZoJMIbQeXoaiBMbFn0cmFtG5c/0GZPrLvlRwn8JQc1BGmNsNAgKVlMkykaAH0/w3dl+ScZMJcsbQMNIYK9QlYz2Nl71OGxHv7Nqqqj5gkh4KW1vxPINuQpgLe1LGel3cXfH1Q23pcVCazvJu2MKfH3YULNt+HhQ1KfIE5TgnJ5UHN8pVtvkPttLr/OkR+E0pO4Bcra5P/ZC9haKLacuW0dvJ37zLMNPdXh5vFfzlZwQOy18EvxbM7qxgT2OZjRPH+jQKFWPnxgZ0+4qeybltXw7eskr3iQkQZz7Idps4ss/cnWLzo2rQSNabnxJNvk6hCvfXQ3fu/LY3Ufh1bIR2rzNdAFF0Y3jGuSwLzKvajv2EOaKhPfHpDd/ZWFokYgzxudBWCMSdOqQdLo5rbhB9BqqetDl2OnWSmTL64uS9kytbHus+WXqdKqkpv6kLzd85C0F5pyi/axJ7eRKPk0/wj+WOrS1HIZxSS8fFtQ3HT0Xg9lyj4M5sWvkQ0oXyjbcNuxF7aQyE3rOeyTE1mwda1TVsBR1pMs7L3/mKyFMBpnlQJWCfA8Uwjo9zLeL1FMzIhu0KCHr53iKRoTR1/xNxXc3n/my5mCHWBaNf+FImJBCM/776IkADYSRvM8FZESpJyLfcnnezFyhDY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(36756003)(6916009)(54906003)(71200400001)(316002)(2906002)(38100700002)(26005)(38070700005)(122000001)(6512007)(66946007)(76116006)(66556008)(66476007)(64756008)(8676002)(4326008)(186003)(66446008)(478600001)(91956017)(53546011)(6506007)(86362001)(6486002)(33656002)(5660300002)(2616005)(8936002)(41300700001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9622 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5be66535-180a-4fca-dc9c-08da90d2b6d6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QAGp+4j72b36KcpsK7Ig/iFIkro1/iuJxa23+Snf1xdGBs4jQx9IqoGjd4bRvT7MnDi2aPCiWt6E1Nxg3awWSASYQn8aUmRm6aGvKSKQ26MWhZBiRnwDpS0XWLgqMKf+ijlmGDQeOubtHD0gajbWev/3k6dB70fo4TyHCc+RltfeRhWamC1QPxc3eIoH4cc/cZYMpf2IvSUBf1zlUPTZpRgNt5VEHIRP3OJN29eup4ZEZ2CaGOKw3wG65nNzFc4FljXPiyXFFKz+7HnTNhvVD/EwDIkIHWOva3rLbeJMO8GiZ8/39jtaG7tWrFd9NcOyzsoeev3kgeWfMKtQHyKK/TomyPtsKO1KdvqijzsXeLrBDb97/TzPKgNkH6Hs2GyC2FPz7AnGOFOsz7r3SunIuoO+8C4WrREHmmuco4bf3CY5cNfQD6S5iVx46kQLvEmyYvMbnG0b7Ai4YVlY+NpvtZooKOpC2pVRbQFuNSSvmG37UEtaJAoCoZz/QLpV/DY6lkLEqv0/koHvvOim9DxCxZMJqwGTsVFS3UwvsmqCyO2sdoe28fFISSNSMQ9hxgJujGVEvicroNM9XI8kvNYsGLbluq88vX7b6bRrgXLqM6BckOr5Aymb1wvgodm/9mtHeDfRS99rYIyiUeMZwCGslt4SeA+UDS1ituRw39zv2mTACaZnP3+bdwq2ZDj2uSrvJwBvowinaa9xeUFTzfDIWL9Iz8+P7BB3kj2TlrbOpdX3QB76ptxlKxAkt7CIzKg8XWN2c8bfb1SHk7ECcqdj7w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(396003)(376002)(46966006)(40470700004)(36840700001)(82310400005)(36860700001)(40460700003)(86362001)(81166007)(6862004)(5660300002)(8936002)(6486002)(2906002)(356005)(82740400003)(70206006)(47076005)(186003)(2616005)(316002)(54906003)(70586007)(4326008)(336012)(478600001)(41300700001)(53546011)(36756003)(8676002)(40480700001)(6506007)(6512007)(26005)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:13:24.3818 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5916710e-4d75-41db-c01f-08da90d2bec4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8909 Hi Jan, > On 7 Sep 2022, at 13:06, Jan Beulich wrote: >=20 > On 07.09.2022 13:09, Rahul Singh wrote: >> is_memory_hole was implemented for x86 and not for ARM when introduced. >> Replace is_memory_hole call to pci_check_bar as function should check >> if device BAR is in defined memory range. Also, add an implementation >> for ARM which is required for PCI passthrough. >>=20 >> On x86, pci_check_bar will call is_memory_hole which will check if BAR >> is not overlapping with any memory region defined in the memory map. >>=20 >> On ARM, pci_check_bar will go through the host bridge ranges and check >> if the BAR is in the range of defined ranges. >>=20 >> Signed-off-by: Rahul Singh >> --- >> Changes in v4: >> - check "s <=3D e" before callback >> - Add TODO comment for revisiting the function pci_check_bar() when >> ACPI PCI passthrough support is added. >> - Not Added the Jan Acked-by as patch is modified. >=20 > Hmm, I don't see any change to the parts the ack covers (x86 and common), > so please re-instate. I'm not in the position to ack Arm changes; things > would be different for a Reviewed-by without scope restriction. This might have been clear for you but your ack was not mentioning anything= . As the newer version is modified anyway, we remove it. But I understand from your answer that your ack is still valid for this ver= sion. Thanks for this. Bertrand >=20 > Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:22:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401697.643597 (Exim 4.92) (envelope-from ) id 1oVv09-0007Dy-A4; Wed, 07 Sep 2022 13:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401697.643597; Wed, 07 Sep 2022 13:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv09-0007Dr-7N; Wed, 07 Sep 2022 13:21:57 +0000 Received: by outflank-mailman (input) for mailman id 401697; Wed, 07 Sep 2022 13:21:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv07-0007Dl-KO for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:21:55 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10046.outbound.protection.outlook.com [40.107.1.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a7450ad-2eb0-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:21:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8625.eurprd04.prod.outlook.com (2603:10a6:20b:428::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 13:21:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 13:21:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a7450ad-2eb0-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQq62dd3Gzn7rrqc8PAUkMU3oKwy+sGgJIqEGgDjgRDNE7X6WuTs46isp3jA+7T3/o3OEvFhNAmKcFfouO+VZQ4h9vflOmAvGbThdXZKokXAVdCJ96CyiHlR15br+4yWPyYjv0ScuJuixh4m8v+ShZIW0PDzQkTzVMWyH2r/M84zfgK8T0QlEg6mmw+eWEQlxMDNPp4Pv7uil4uj+4j71e+mS5h++cmu7NwL6gIUtVSYwAIEbEswcITiptd0kzWhs4QLLZhnI5PtBy1SgTPvPjOi+nyaEuAtEgEFkGHUSxAKpL3jkJbv0jNXay58lor5kZ1m8Tp1BKQOvuc0dJ0qvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9GWfyb5PK+MoEjaitp5FPPBm/23WnA+TC8H9KVOd4w=; b=j6LbXaZ113U5J3iHxa3yZJvmvixtxoheQwJSbvvl44gudhFnPXg4388kiHujpuhCWkuv3hg5XoPYXR8ruyNeDIWEwPWQx+AMU0MHEmtosBhZzWLCkHNuKwgHOLxZP6al5MEKAQecGnwEY3ojHL65KRG4d99JDwbhQusfwxDWTv/HxAXp9xqqPj9qcbsboXOWC652tBmD6INhzJhzIrNZexiBmqe4iqejIg+2RO+Rgx3hzZ0pYBGl1+A7WErik9M+s6XeaqFFnBudGs/utPHBxt6wuiVIhdiBU3C2QdZ3oa6M0Q5mFDpGTDCVfxSGSS3ZysjFph/4IZ6g0hZPivPW5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x9GWfyb5PK+MoEjaitp5FPPBm/23WnA+TC8H9KVOd4w=; b=s7VhL2S1gR1gDKKqGdzsIXdket5CiHO+pRfuNegEcCvqLtyZz0KBW0JBwUlSlfd5KpwYkzxoTKKGMajw3STwhFDXw/zaVNH+7cf9Pfy4hQiTeuWqIqBkVYjcJ84xuTqRvihj4teuu11WSeU1GO1Szt9tqrRyLwznq9F4DfgANo6rKBQ99xs267KWYg4oZhBnb9VT8M+jRbBQhweZg9R3o2egpjxPSfCxWXwOTr8hdioiiBIilGrIU0PGcT0JpFwj8V/MFu4Ie7UrmnOSxOxafVo5F76xG9OB6cCghS/8TZNfVUL8vVwT0CRmpZ58UAQ8G1nr/giG02R/ns4hwRDH0w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 7 Sep 2022 15:21:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Bertrand Marquis Cc: Rahul Singh , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <06E1E4AB-5DA1-4AC4-9452-9507C2B75E81@arm.com> From: Jan Beulich In-Reply-To: <06E1E4AB-5DA1-4AC4-9452-9507C2B75E81@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8625:EE_ X-MS-Office365-Filtering-Correlation-Id: 93080f43-d70a-430d-f13d-08da90d3ed53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DBH01G12QWE0k5N9Kw6lpOYlKeWx1zksmoYYBeHuiFuzYXzyDqxQvDzt5MBJ2DfwrEe+TOJOy5p71DlrP7c49c9by6pubvllc1+4N+17ie9oorosm1UR4AbM0Pvuq4QwALoHclgsS6rH8ry6sTO7eDJ2NA/4Vh7TlbGNHVe2DZYsh5ZUlk2CeAiGXiDhIYe8T+ciQz8e9cx7+4FZVMDNJ4qdFxvCBIYBh+w8pW9sxrQBAAJJmyK/lhs5icBZ+xdb0ftXcRLPmBlxBXDbszQzEiZv1aI0shkYto962dIy03Wp8shQhTh5LZEZD/SG/NAOeJ66nOZuO9IQOHMlF/E9eCCTQRSmGoB3UoT7sjRCVvI3yFMSrVz2wYB80Ix6x0sGgXOf1ia6HKswFfxh2X0HHs4OiXr+PMeGx1ZNiGznsizgylO3/10+i+DiQUXly++DxrOKbyALNs45bQz2P8ABN8BCy8Ob3hdwCLcMfDWy1+pkTMoKkyfxXUF0NM8/t5dLIjDd2Apz6FRXLl7bgROzEImhBYA0K9oEBHwI0HKUQJ6Tk0U2YrheIa1OvyWV7H3+hD5+ra/oK4rSqLtkvKG3anIq6/LJelqgLzHBjjHL73YvN1ohJh5I7lIJ5UrcHEUAzj4w6rSYW8Ryb4eq/b4LpFaq9VRLUANWOGh9mvJVKBJ7QrZ9GJBcq6U9d/nuR9NwRwvZg7qld4HHNx8hWM7/+p2uJZrYY/2u+b5R0y2xB5B/dFWRuTFWA30lYcfP4PaCnA8G0UTBlFg7h3KyEZzNvQQqrgc2VY8wnk5I5aH63MM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(346002)(39860400002)(136003)(396003)(26005)(86362001)(31686004)(6506007)(36756003)(31696002)(54906003)(6916009)(8936002)(38100700002)(8676002)(6512007)(53546011)(4326008)(186003)(66946007)(66476007)(66556008)(478600001)(316002)(6486002)(7416002)(5660300002)(2906002)(41300700001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHFkU21ldHhJR01kRWNRUUZCOWoxOU1OYVJoRmFCUjFTNTRpWHlvT2E1N2hQ?= =?utf-8?B?anRjWUZjaFVUUW85amVGMlZhMERsUFNiMjN3SmMrWmJFSHQrVnRlUi9CbFQz?= =?utf-8?B?a1libTZwRVc1YVYvNDFncno1UjZ2RHZwTk9NNThlMm5LV0U4OWkyQndjNTF3?= =?utf-8?B?NndLT1loRVlFSk5wU2d2b09mQkFxcmJwTFh5MHRWdTJYVE96MG1PVjlDdXJX?= =?utf-8?B?T3ZWTWxBNXZlSDJ3MDA0VEZVQXRwSUtkVGs1eWpYdkxEYStMTXJZZU9sY0ZY?= =?utf-8?B?ZFJHQW4veEJCTk9SbkUyeUJXQmNKNWMyVCtWTWYrYmJBY2J1RWQ4K0NLd1NG?= =?utf-8?B?TGNFTnEvN05JbUVsL3FxbVF1bndUSHN6SXBuaEg5NXdIWW80emFmaEthbWdL?= =?utf-8?B?ajNGa1BESDJLS1B5TEc0ZGFPS3FDbVRNK2lEcjhXOTdGWlREdkZad0RBRUlT?= =?utf-8?B?eHpncGI3elZHVDRESitBK2tkdW10VUxucVRmUE0vd3REOVJqQkJTOVdLdVZX?= =?utf-8?B?NnhvM1BtdFBWeHRBMUsvWCs1OC9pMVU4TmJ3dlF0VFNRdnplSUFKKy9oSmJq?= =?utf-8?B?azFxWjd1Q2VTc3F2Wkl0WG83SWZ2TmF0bExmY1Q3Vml3MEtqR25zWExna2hn?= =?utf-8?B?eG55VDJ2OTAxWHQ3RHc4Tmc2YXIzSWJtNjg0ZmxvL1hCaWFGd0dZcktMb0Rz?= =?utf-8?B?OWZJYWlzamxPQ3g0Z2pOZS9Sc2xNd0d0SW1SR0hMVDBmNDZET2RCeXhIeDRC?= =?utf-8?B?SUpqKzVRc1Z6dzZ2d2hUL0ZHU245TWtTTEJGenRvUXcxNlY4MzlFRmZFZDRs?= =?utf-8?B?RENWRTcxbTdUQ1l3cmtTejJ3TW1mOXlPR0VDVmFVNXlUaTB2RXg1Mmd1d1B6?= =?utf-8?B?bXBzWlFSQTBCcXEwV3IzU3cyd2pXN2RkM1BkakpuNDNoajFZSzZJQm40UWZR?= =?utf-8?B?ZEFHUDFFbElWK1k2Zm9XcTU3Nm44NG81RktieEZaN3dPQTJ2WmUxV2JoVUFq?= =?utf-8?B?T2NINHVZdStCVnJLMkhWUzhrUVBETkFCbUdtKzlMWUE5bGNIc1Jsb0RaQ2pO?= =?utf-8?B?OHlvOTB1NUxhQ1ZRbWx3YXRvbzNpaWdENmpyZW1kdHh6d0J5dGZtY21xUXpt?= =?utf-8?B?UTVRMHc2ZUUxK1o2SG4zWEk1aUwyUS8vSzRuMlMzTW5RTnBNQ1FnV0ZpNmxQ?= =?utf-8?B?RCtqSDNVaStJK1RMRld6dnJZR1dRUVRMWDl0bVB2eUhFeWV3VUlpMEZlQVVS?= =?utf-8?B?Rkg3T0pEL3pDa29jMEFLTmdSRWVrbVFQaGFWL0RNNHB6dDdzMVlGRHQrU0lk?= =?utf-8?B?YzJOYXFJd0Evcm5XMWtFb2s5QkxRcFJGZ280Z1ZUTnB1WE5CaUdpOUVNTGtq?= =?utf-8?B?YWkyU1FBL1lyR1daOTRpNTN3Ylg5OUJKcUx5eGRGbFRGOFdBdzdWOEc1WUs1?= =?utf-8?B?TmRRSVJuQVB6eDlyMzhjaUxZNzd5MHlETElKWUJlYXFXWEVCTFZhcEREcEVr?= =?utf-8?B?K3pDQlRENmo5R2REQ3ZuZFJYUndrVGh2OUVpeGpwdjRwQVZOdzU1RkZGbHp2?= =?utf-8?B?RTRKcGRWN2hLKzBUOFJvemZXVGxXK2wxRGJXSmw0azNiOXdNUHJoeGlCa2hS?= =?utf-8?B?bFZwcWNPbWVJTWxGWXhHRk4rYjdKVUo5ajNPS2pnM2hseXNBbFdDSG5VOEhr?= =?utf-8?B?VCtFRGNwMzl4SFhtbktCYjlsa3JKZFl5Vk4wdUY0c3R3RDlsRFdwUlM0aS9Z?= =?utf-8?B?ZVpxZjZwSWNzbG5EbTNTY0NybTEvRXJsMUp4a1NFbDJsYk43T2NYTmx4WlZR?= =?utf-8?B?U1NYR3BWVUVuUDZRaXQwVGdQa0dFMElRUXRhM3RoRHpDVFJvYUVTZC9VNXVY?= =?utf-8?B?WEQvaFBIdTdnR1ZWd1NMNG1ETjI5Q2pEekhaSjlodSs2VytEL0RrRGxFZzVm?= =?utf-8?B?YW5TWEpnbVF4eWIwS3VOeHlzc1JJY2d1SCtad3pLemptS0NXZEpzNkpVbXRF?= =?utf-8?B?VHh5QStJcVJONW1ua1dxSUZpUlZaZjBiY0VGbjB1clZUNW9oOGtJVm96Q3Bi?= =?utf-8?B?RWRnZExRODFIb1hXVXVTdUNzVWRGRFNKV0h6dllZR0E4eEwzK1VGOVBJZERp?= =?utf-8?Q?8asAZUc4fvvhJpNKS3pUsm77N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93080f43-d70a-430d-f13d-08da90d3ed53 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:21:52.1797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZZ5CsMnZ5dZW/IASAsIcMJGm9psgFwy9Q/dA7b0iuj5w8GiHYred+rsuZogJI+KJd+y26Is/l1+ndyZVRsuCxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8625 On 07.09.2022 15:13, Bertrand Marquis wrote: > Hi Jan, > >> On 7 Sep 2022, at 13:06, Jan Beulich wrote: >> >> On 07.09.2022 13:09, Rahul Singh wrote: >>> is_memory_hole was implemented for x86 and not for ARM when introduced. >>> Replace is_memory_hole call to pci_check_bar as function should check >>> if device BAR is in defined memory range. Also, add an implementation >>> for ARM which is required for PCI passthrough. >>> >>> On x86, pci_check_bar will call is_memory_hole which will check if BAR >>> is not overlapping with any memory region defined in the memory map. >>> >>> On ARM, pci_check_bar will go through the host bridge ranges and check >>> if the BAR is in the range of defined ranges. >>> >>> Signed-off-by: Rahul Singh >>> --- >>> Changes in v4: >>> - check "s <= e" before callback >>> - Add TODO comment for revisiting the function pci_check_bar() when >>> ACPI PCI passthrough support is added. >>> - Not Added the Jan Acked-by as patch is modified. >> >> Hmm, I don't see any change to the parts the ack covers (x86 and common), >> so please re-instate. I'm not in the position to ack Arm changes; things >> would be different for a Reviewed-by without scope restriction. > > This might have been clear for you but your ack was not mentioning anything. > As the newer version is modified anyway, we remove it. An ack can only ever apply to changes to files the person offering the tag is a maintainer of. Hence there's rarely a reason to scope-restrict it. As opposed to Reviewed-by, where someone may indeed have reviewed only part of a patch. > But I understand from your answer that your ack is still valid for this version. That's correct. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:23:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401706.643609 (Exim 4.92) (envelope-from ) id 1oVv1s-0007oi-M8; Wed, 07 Sep 2022 13:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401706.643609; Wed, 07 Sep 2022 13:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv1s-0007ob-JI; Wed, 07 Sep 2022 13:23:44 +0000 Received: by outflank-mailman (input) for mailman id 401706; Wed, 07 Sep 2022 13:23:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv1s-0007oT-4X for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:23:44 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2049.outbound.protection.outlook.com [40.107.105.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b7ac57b-2eb0-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:23:43 +0200 (CEST) Received: from AM5PR1001CA0012.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::25) by DB9PR08MB7867.eurprd08.prod.outlook.com (2603:10a6:10:39e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 13:23:41 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::eb) by AM5PR1001CA0012.outlook.office365.com (2603:10a6:206:2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:23:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:23:41 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Wed, 07 Sep 2022 13:23:40 +0000 Received: from b2b45f542b33.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 305F218E-004C-480C-BD8A-3F8E5FD7FA06.1; Wed, 07 Sep 2022 13:23:30 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2b45f542b33.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:23:30 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB9692.eurprd08.prod.outlook.com (2603:10a6:20b:604::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 13:23:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b7ac57b-2eb0-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fzGcc0t1PrWrGJ0HsbBvFyZ3+YLkxuapu+Iun9/fLl+6eVtY/GYA65dc9Z8NmCiHXysB4+TzZbkzJ/YkSlgZEL1Exhd8cRQE/2Wd15y8QeG6OLMh5AoBjevpRLbw39ubOM1IScSVefMVijXSn5wOnGTfSDqvf1Ee+F47kAhvl3exbNDoNpDIEvCAlozpg3SNCgHuCEZ0t8PoloGgnpSItXNUysvb+sy7N7QnHEgB3dH3dNlK6ey93eG4o6tXLNUaI3ATWLlmOP4IgojnHMOt1cwq/R0AaPQ2lrAWYawGE9trFD1ifHvc9jhNPh6Z4ww2mUgcIGIHDQZES4NucYslCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wC2PthZ9nIyxbUBb8wmSNNGbLyqH4j5Y9GpvsILWGI8=; b=JJWid93T5BUeTB0w78yxwCJYAzucr3Ql7rlda0Vzp8nY55u8xNY9Rw5Tg2J1KCfhSdr8IZo8gYrqjgqnfwMm94GCvoH+DXDRxY6X7GtrPka7CrUN4EbGIUNhJUA0aI++v3VfvDXrk4cKFF9LEjFOYtc9no3Cjkay0LfUiGCXJW5go9U8+/v1Zqd0uClhmfR2RGnJF9m4z4WWrnPLFS+DsTqxKZfhZ1uz04y8V2zyEkD41I54W2oM80kWkpVbtlbgJroVEZd77nl00hyfGBPfVETbInpXUG0e7CND4jspOvvu4LoT4SGMBlJu/lKP4LiAScCfW/hxPweUnZ4A9e1dsQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wC2PthZ9nIyxbUBb8wmSNNGbLyqH4j5Y9GpvsILWGI8=; b=BEF8FND/ZeXdNxmkUO1uQL0u+BAHy3mUYRaeXktU+8Pl+bCOPCYI1HaYLQPnBLXaqX8eoREP/XuMNPpVD7bDGy/jFlgiAl6BXcNxrW5z4cZZEGVDKh8lLDhpYZIzVCqlLC0iD8vg7vmhs/fOSG11jVWldw0qn1FekWBN2YChUEw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c343102b5fef7549 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3wxVYYky6L2NoOiWbBpE8NFpyFq4pTynoCOgQ7vPjE9vZAzUCOQ5p8c7th/Bv0fy1MIDC2ga+F+MA+Whliw57sqlvU5LdbMFxLrpmrB5zXi8Owz5dKFTJps1BESqZaai6VEcLxIaCtR44FiQUSCQe0X8QlxlinVW2dRgqNRFWAoK80PaS+V+ZQiG8t2filuqLsfHfS2Yygylfz0b/P/oliV/lSfHpPCiGsEtPCy4F9LiAHPq811dY3XxDOs1tvx7MgH+++TbN8jTps/vRdyGI/1amwUaP/pY/vZU5PXc9Ych89U6nYZ5awOcV4fpUFkpYLPjD9lUNnza/7b4aglwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wC2PthZ9nIyxbUBb8wmSNNGbLyqH4j5Y9GpvsILWGI8=; b=nz1Mq/Cb6urKiqaBw/X4UeD9Jerd0bv7uES0UOHlIQI6ysi0Nm3TGJJn+h0+sZy6xBJba4Gdk+ZJ6iCycw0brDE9tIAJwoj8BylGFrSG5aVyDWCEEKWlNfKNr5Y+LG1RClNdskrFhspsWUDU+yJCyl6886m6pDP9FuKw/5eNFjSTqFK8OFV5FU3FQ6PGccHf/I9TdEsIvHYVs97eukvk5ytSHlFZdLIN2yIzyLTR/8qJScNfy5dqQfHpSiwV2gETL5wLQ3y67IT3MslTnHZIojvdB0UICWh1jDYqMZxMuRawC54rCI2bB2kHQQ+hTA3hD6bs5T++R4Al6PZ0MsKgEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wC2PthZ9nIyxbUBb8wmSNNGbLyqH4j5Y9GpvsILWGI8=; b=BEF8FND/ZeXdNxmkUO1uQL0u+BAHy3mUYRaeXktU+8Pl+bCOPCYI1HaYLQPnBLXaqX8eoREP/XuMNPpVD7bDGy/jFlgiAl6BXcNxrW5z4cZZEGVDKh8lLDhpYZIzVCqlLC0iD8vg7vmhs/fOSG11jVWldw0qn1FekWBN2YChUEw= From: Bertrand Marquis To: Julien Grall CC: Jan Beulich , Rahul Singh , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYwqqLAtgrk5Z7CEC9g3vN92mek63T3yeAgAALyICAAAnBAA== Date: Wed, 7 Sep 2022 13:23:27 +0000 Message-ID: <22E9182D-2345-4088-A9D6-76E62B110225@arm.com> References: <11fed186-7295-00b0-4fb9-50d08e63f364@xen.org> In-Reply-To: <11fed186-7295-00b0-4fb9-50d08e63f364@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6a5e7cad-5dd7-445f-e495-08da90d42e5f x-ms-traffictypediagnostic: AS2PR08MB9692:EE_|AM7EUR03FT052:EE_|DB9PR08MB7867:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rJxEThC95UJLl0rD61WESSdtVPOf3Eq3y2CGJ6wy0+r2XoPIN/3FYX1NyN7vqlG/W9dsb6rHlkWBgtT8xAUczES50iKergA5/+7W1v2SHVxW2X0YEUv7V/8vdqHxcWGiEP6THIJZoFi7HK9j2aMjsaLXnsvq0iBijFCe7d1hjqQwXhAkusNtTMKmdI60ICDdl434mv3+nmZovQJJaVJ/DnmThtKwZnNnbaWXw6HETwqT3rh/tA0aSCQ2HuNhxYIeXE51sAVvB7k0xtBaxsntvbPQcuQgnS2uppD2X6D6gNGqWyEL0oX5Qz3jW/PXEcI6+RYYQLb5hMuympUChoSum03jXNTyFsCBfNhP7fNuV9i7Jrm5dprNTXjkvZan1hvip4MKvsIF0ZgBdJz3UHfEOY7hFbW2nfxXV8SlSvd2oXqzFRneFKDdyZHwUKgOgrWULFp/alS0LnUFESeUHzNhH6SQzGnivDR8r3RJ1rCBlaZxvVhFm6Z04losIf4LTUMayiBSuXA+K/TyR5tSC6b25/V39HnaalHmK/HBztsmIp0l9b5vCAk+5aKlN9TCjNAQsVm1mKIQjECtHf1MtKKpx3vV9LvY05vdtA0YZo5qwjF+S2URdITbyaUw+T2h/M3wV+PBMcxUWf3NWPt9X+wzMGbM5wbWXjv4YTA9ukijxntu2Muywl3oYmVoSI2CPg+IQa8vk95WdJvcNj8c+9iZEN/haVndQyN/gmeUtVFaiHNQ3p6wj7KRIGy9pAwj9SIWv7DSl6rkWykZKCnmySzKsWsgxAwaX3be65EhdKGL+Fg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(38070700005)(4326008)(122000001)(38100700002)(91956017)(66556008)(316002)(8676002)(66946007)(66446008)(66476007)(64756008)(76116006)(6916009)(54906003)(2906002)(5660300002)(2616005)(8936002)(186003)(83380400001)(6486002)(478600001)(53546011)(6512007)(41300700001)(26005)(6506007)(71200400001)(36756003)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0446FBC473231A47A65DE68EAB491092@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9692 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 37c81691-bbf4-4340-8bda-08da90d42619 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I8MPpKFtFEODVVQqNGolK6xflfuLxpeAKXPN9lemjOt2IVyXjSr4GVLPzWl04kYsliooh5pcYre/dPef6SPLEBPUmfvMo2Pn9cFbJuaKwIS9989eQ2s5BdTSk+5Zf9QqaKewopSqDbmb1xE4J3iUDnuErUMf7T7HWB2E/ZV4UcMzMJ76og0JbINLoMISIhqmw8PZ7jQ7jirdqwTDSV31kDcGes1XXw4Ljbl4YTiCmSBNk3nr8KRBgbSWK2noTrZFAY8sdXYXo7YxMbakyFmVV0Qx/34TV564v33J9BXiskGF9+otsH8H0UAA2FYtI/dK1H5NNQk7Ov/sl/hOC/DfVMc15lQ5PjJQ3gqpyF1KfZGgMIo/uYUQZ5REjPxpUxLKSKrEX6C3KSV8s+1pyk2oRO5XyR/9spfP80Qg3ukN0XSiYxqdwS8leeNS8djlRktmY/BNnbTTyFiciAO7mwgFHmv2KRK7UUMiaprEL7yaNMQj0sWt1K5kIXMkDGlUFjcscfp4IvqYENaX1P9Z+5ZAqMWaL8fm1v2MIgFszQXG136CBzLbDo6co/S0UG/MagGJucpY0rVJEgC/qZOTqHCK9fVciUx2XUMpDBwE1fdtqLTaC+XMdEWjmTCB/2L8Ngj8BN7p0J6R7mqhZiFVORBGDlHaaRox/jIIg6/MCesNPQgHBaYRJjj7NMdK/RhDxDQAqZ3jEZ6SWA79GLDXVkmEszdcN3BvpdT+XFaGhhwvcmxSEukPhPlN0cXmJ3eBSSomF3xH6nIE0E8HziBl4cpQhQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(36840700001)(40470700004)(46966006)(356005)(82740400003)(81166007)(33656002)(36756003)(53546011)(186003)(2616005)(36860700001)(6512007)(26005)(41300700001)(336012)(86362001)(6506007)(47076005)(54906003)(82310400005)(316002)(70206006)(40460700003)(6486002)(83380400001)(8676002)(70586007)(478600001)(4326008)(2906002)(5660300002)(40480700001)(8936002)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:23:41.1224 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a5e7cad-5dd7-445f-e495-08da90d42e5f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7867 Hi, > On 7 Sep 2022, at 13:48, Julien Grall wrote: >=20 > Hi Jan, >=20 > On 07/09/2022 13:06, Jan Beulich wrote: >> On 07.09.2022 13:09, Rahul Singh wrote: >>> is_memory_hole was implemented for x86 and not for ARM when introduced. >>> Replace is_memory_hole call to pci_check_bar as function should check >>> if device BAR is in defined memory range. Also, add an implementation >>> for ARM which is required for PCI passthrough. >>>=20 >>> On x86, pci_check_bar will call is_memory_hole which will check if BAR >>> is not overlapping with any memory region defined in the memory map. >>>=20 >>> On ARM, pci_check_bar will go through the host bridge ranges and check >>> if the BAR is in the range of defined ranges. >>>=20 >>> Signed-off-by: Rahul Singh >>> --- >>> Changes in v4: >>> - check "s <=3D e" before callback >>> - Add TODO comment for revisiting the function pci_check_bar() when >>> ACPI PCI passthrough support is added. >>> - Not Added the Jan Acked-by as patch is modified. >> Hmm, I don't see any change to the parts the ack covers (x86 and common)= , >> so please re-instate. I'm not in the position to ack Arm changes; things >> would be different for a Reviewed-by without scope restriction. >=20 > I would like the question about the BAR alignment to be resolved before g= iving my Reviewed-by/Acked-by here. In here we have a range specified by the host controller and the bar should= be strictly inside that range. Now if the controller range is not properly aligned, there is an error in t= he device tree or ACPI table or in the firmware and we should have detected= that earlier. The itself BAR should fit inside the controller range boundary. If the BAR start and end are not properly aligned we cannot map them so thi= s should be an error (if we have to map them). I am not entirely sure we should try to check this here or maybe would it b= e easier to fail if addr is not aligned or size is not aligned if we want t= o check something. Bertrand >=20 > Hopefully Stefano can clarify it. >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:29:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:29:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401716.643620 (Exim 4.92) (envelope-from ) id 1oVv77-00009i-Du; Wed, 07 Sep 2022 13:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401716.643620; Wed, 07 Sep 2022 13:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv77-00009b-B3; Wed, 07 Sep 2022 13:29:09 +0000 Received: by outflank-mailman (input) for mailman id 401716; Wed, 07 Sep 2022 13:29:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv75-000065-PG for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:29:07 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50075.outbound.protection.outlook.com [40.107.5.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c24528a-2eb1-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:29:07 +0200 (CEST) Received: from AM6PR04CA0023.eurprd04.prod.outlook.com (2603:10a6:20b:92::36) by PAWPR08MB9757.eurprd08.prod.outlook.com (2603:10a6:102:2e6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 13:29:04 +0000 Received: from AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::ad) by AM6PR04CA0023.outlook.office365.com (2603:10a6:20b:92::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:29:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT035.mail.protection.outlook.com (100.127.141.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:29:02 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Wed, 07 Sep 2022 13:29:02 +0000 Received: from 91ba1e1ff523.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C47F0EF7-C091-49C4-B55E-C0FB735384FD.1; Wed, 07 Sep 2022 13:28:52 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91ba1e1ff523.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:28:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB4PR08MB9334.eurprd08.prod.outlook.com (2603:10a6:10:3f5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 13:28:49 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:28:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c24528a-2eb1-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lPBGWYqG2FR61szwVwvJ+0LLu/Z7KDF5fQIfae2Ft8+tFkloSBCNW6TuPYJEnc3orq2fau4pxer2hZzE/tN0aotm6yInr5fge7vCMXqEPBUtGUoTQ0KGg0GY43Dz1SBvMjMj2CkUBIX23/ocSgVa2eaCSwswp3VYRMolwXMbn1doktEsj3GLKHK74RNukdiutVUWGiknNNg7Hf0ntzfE3Pi/VXDbC/velfip5tFa+yjDPRMhpuBlDhlEbd9y0k5CtIsIjZqQ+JIap5ZzEIVxZ9FvY94D3Y0Ty5k7J11baTkPJoqmqMbATE7zi4Pt3dkYCzNvrVsivH7BVc/BpTF6EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k8PyPpVQ92K9xxeK9j9wICl355Hq9zTDxVioWlA9hEg=; b=Zt7n1lo7WaBFRjRrrriJLUEvpsme29IZq5ezMzHV/jlni3U2I0zizhOOduUZlT4zMjYuOPEb8SlrUOUnL8YKh2vTsWBNQdfWYGpdJEmumGbipZQzcpCwg9TQWX6OUV6kd5vmfgh41Itr6n7fVjL05dWNrv4vPnkHeibiYYICbtvqNWowszEBLfw1EZv9/DdGl6i21Dy/TYEa+qnwLvWc457ihYU6bvyB3pdOYqvBYjEJm+FKIbh5TNhQ2hGRMd5JjUugko6Ifv5jA2NwuB7j+/OdBlsp/lBvFVGdL2VAxRSX9/wGRJfh+TnDYbQjdRhWJUnUIPKGqMaLUv3Xf/WXkg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k8PyPpVQ92K9xxeK9j9wICl355Hq9zTDxVioWlA9hEg=; b=gQT0DSO/phkWXLLwf8B6RIcR/98MXD63N9+PKQx0IqULispXDy2REG/ffzuQtekenQOWQLrmeUgcyb27BkjU+EgiR7HNMUeiC/K+IyQThVCgjt+Qrny2ZWVCV13ZmG7TDOxDP0lup7ne/SCV+eUIFEDQQ82xRkO+DHni4V7qGz4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8f8ee5f023d5adc1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JsRXdRysxhU15Npg1uJTfAMsz7H2/hQcgD/6RPN1szdgi59fk2WEc1hTK9LklGy82pBCE4iTqSGpUUW+H569DcnbC0MAhHJSSW2GYEsq/L+Bn0uhN5xsg9qJoG5uvFZ16GFVd2oGhfRO9UxwWTWfBqg7TUtu21e3IXpkpyE7w4KzxaNbl+JkhilLYuWOmktin4nbJAMjYFgNaNMgkiZ2x8mL8oDXpxrp8rbkY4cTCkyKKdNlCrE9DmkbXS3g8v1eOZeOA5Hlot5Ua/Wgm5ruSk+r+zk94oAWdMq7RyLJg8JlY+BCb/lnY4+/BRt7tqibaKpCn+hlwHIM53J6ICrh8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k8PyPpVQ92K9xxeK9j9wICl355Hq9zTDxVioWlA9hEg=; b=maR4b10Z+1BB8VoB4HRFt43t9+sbz5JZAQMQg6dIFSwTHJp8yCJERlsOV6H6bngDH0r4+VlgLgrNJ2aB5CwhAg7h6A9QMsyTourBjbHB0LI6eZlXrMe2lIAY9AHKc1bpiMnPt4V5JSw5EGZV++5wE5CiRx2AVZlGKmsygo6AtlEou0fW9TgbmyMYGdf9Vc7S2pyZlMoS+rzbyGK7oLHPMB1mTaDDKARV9Ug9wtgaZC3OZWvYM+bs16suPJO0Qsab1K8s9iU/HmqKAmkUeSaF72EhW4i5zjkAI+lIbLZz2UUdp9lfCwRKNM3sdJe86HGtZG6FOi4sR+Fzs9s1uvxGLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k8PyPpVQ92K9xxeK9j9wICl355Hq9zTDxVioWlA9hEg=; b=gQT0DSO/phkWXLLwf8B6RIcR/98MXD63N9+PKQx0IqULispXDy2REG/ffzuQtekenQOWQLrmeUgcyb27BkjU+EgiR7HNMUeiC/K+IyQThVCgjt+Qrny2ZWVCV13ZmG7TDOxDP0lup7ne/SCV+eUIFEDQQ82xRkO+DHni4V7qGz4= From: Bertrand Marquis To: Michal Orzel CC: Julien Grall , Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCA Date: Wed, 7 Sep 2022 13:28:49 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a95e9cc6-bd53-4888-af06-08da90d4edfd x-ms-traffictypediagnostic: DB4PR08MB9334:EE_|AM7EUR03FT035:EE_|PAWPR08MB9757:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: glsKhl1sDnMlG6h7Ns4YHz117FKXWWxRPnnA8oEyP0qsKtBotIUHvv6C6F2zW1vjZKIkvUJ6/LKzGeaCNjjsRyZy1gvYV7n4ZZHFPLmOMI4XWNRYrqFGjbcsUTmqX+JmsmbS0S4vTcg2FFHVmmXJX71u8qbDJ+203MQMhNi1wXjRP+OLAz04nKjstfBwmjknSc4t+z1oSSwtogQ5eygHo3ubSbyOToQ/jnZviogpY6z9FGzj/XFrOE3JFxzwW1i41EXUco7VcH4QzfvvLgICLds3r0O64ezCx8sdZ1BOnJZqPtrdZ7e98sJF5xMXC5lC2VOuVabnpL0spgkOdcYE+xLOsj8NclkhNC7lLDaoVZcfntomIQUgEbPfRw7nyDxYd5fIo+V0YO8TGYoEfaFQTKk1tyDos1pxgJk+irKlMutwTao1wQju7Nt28/bVET9FXEXyqOgeNutB+orLnzkxdynotSFaq9l2742gGy2RmMnbv6SeKyCOKcozTU1CG/ayo7pIl73R4wRhjjGixax23tRXf9Y/9sU329sKnb/k6ViZbhpp3CUkyM6934o+ydxrpBil2MVT7l53tuwG7P1H53U5Z2TZaZv0AZu84T7BdbNJvl2i2OB8+RtzJi5t+lBXy43UjGEuAyTyz4cxu4zsHWgM+uCANUjxKTK7M9HkpKtpeh4tKH3dUP+kkCOAivp82TzDVzQhKLTNbU9OQILEvlAQqt/KSEaHJGZ9beO84sclZkidVIABlAV0f6BYfIgIkwF9gt643v1Oq4grxwn3jYQFjHaIdw1YWUKw9rUExZohSE9MIHUYEmZLN8wF2NfI+RuuwX26uhz7H4vF6lmAYA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(38070700005)(64756008)(66556008)(66946007)(38100700002)(122000001)(91956017)(8676002)(66476007)(4326008)(66446008)(6916009)(76116006)(45080400002)(316002)(8936002)(54906003)(5660300002)(186003)(41300700001)(83380400001)(6512007)(2906002)(2616005)(966005)(6486002)(478600001)(71200400001)(53546011)(33656002)(26005)(6506007)(36756003)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9D40B3221283544E9E8A79252CE67DD7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9334 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9207c394-1f8c-4dc0-b75f-08da90d4e642 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8L7B1gtdgh1J5RHZ6KYNDRiv6xjaRI72C7o8EktMdCeEPhyHqYuVklrV/1UQL5dcVwBbFL4wTI9eYiabTpq4n1eqAssa3J79TX9h+/rm0RBp8AQQQ3ebQOOtooAUbTzKABsl4NT0By7ONzWdtI9V8Nn3ITtOvEluQy5MHbswfI54Yi2a97mF8SmnAPZmDrScOgoOyypM+zojT+1rrlQ/7m91vdRiBoRFMPX2lrBG1hOlKSlfLoif6mxDY2A84WTDPqr19c9nfvb1S2xYGUtlWceytbC8gXXalm/2tI7YdnLiRT7WRAKluCMyLx2ENZTVHXTXdhAKH0AJpBVdl2pOD6TmyoRflLYrduMA75gxEJIoPRbzrUmmiD70Msoot8/HEkWJZYj3rdeUI3vUpAm2xsL5BRSdGW01jJIq/IpQav31CVKSfKGTnJZDnaWfyGSrSy68gMSBDoMXkkpubL6BmY4WoablNiMPBM757wWaLqQMYNvglLPBK7ZoqtpeESlztdcr63x5V/R+uTejbZWOsBheFZcQXv/teAIbbIZMEACkn+ZHZu8J+ycwIP3EMMH+PI80meyfRtARVOtd7uUAdJufyMHc/SsBrDVCup4HEYLI3/6jizSqH3B4j6k6GyL0+4BhcYJD5BURVu4gizfKB1Tkd+TwuiaBy/Sm2o1YEbNP8Y+MLJXNtk31TVnI+tXsfziWgYW3uaXfGY6jFEfne0IY68VuLIh17K4zMsWv0qEYcMm22GKD6tj7izIdkEatfZQqyw+oRHLPsYAtj4F7ZudPOo7LIJbgu6Jq6pZtkEY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966006)(40470700004)(36840700001)(82740400003)(26005)(356005)(83380400001)(36860700001)(40460700003)(54906003)(70586007)(81166007)(8676002)(4326008)(82310400005)(316002)(2906002)(45080400002)(70206006)(8936002)(86362001)(40480700001)(5660300002)(6862004)(478600001)(336012)(2616005)(53546011)(6486002)(966005)(6506007)(6512007)(47076005)(41300700001)(186003)(33656002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:29:02.5857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a95e9cc6-bd53-4888-af06-08da90d4edfd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9757 SGkgTWljaGFsLA0KDQo+IE9uIDcgU2VwIDIwMjIsIGF0IDE0OjA5LCBNaWNoYWwgT3J6ZWwgPG1p Y2hhbC5vcnplbEBhbWQuY29tPiB3cm90ZToNCj4gDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDE0OjQ1 LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiANCj4+IE9uIDA3LzA5LzIwMjIgMTM6NDEsIE1pY2hh bCBPcnplbCB3cm90ZToNCj4+PiANCj4+PiANCj4+PiBPbiAwNy8wOS8yMDIyIDE0OjMyLCBKdWxp ZW4gR3JhbGwgd3JvdGU6DQo+Pj4+IFtDQVVUSU9OOiBFeHRlcm5hbCBFbWFpbF0NCj4+Pj4gDQo+ Pj4+IE9uIDA3LzA5LzIwMjIgMTM6MTIsIE1pY2hhbCBPcnplbCB3cm90ZToNCj4+Pj4+IEhpIEp1 bGllbiwNCj4+Pj4gDQo+Pj4+IEhpIE1pY2hhbCwNCj4+Pj4gDQo+Pj4+PiBPbiAwNy8wOS8yMDIy IDEzOjM2LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+Pj4gDQo+Pj4+Pj4gSGkgSGVucnksDQo+ Pj4+Pj4gDQo+Pj4+Pj4gV2hpbGUgcmV2aWV3aW5nIHRoZSBiaW5kaW5nIHNlbnQgYnkgUGVubnkg SSBub3RpY2VkIHNvbWUgaW5jb25zaXN0ZW5jeQ0KPj4+Pj4+IHdpdGggdGhlIG9uZSB5b3UgaW50 cm9kdWNlZC4gU2VlIGJlbG93Lg0KPj4+Pj4+IA0KPj4+Pj4+IE9uIDA3LzA5LzIwMjIgMDk6MzYs IEhlbnJ5IFdhbmcgd3JvdGU6DQo+Pj4+Pj4+ICstIHhlbixzdGF0aWMtaGVhcA0KPj4+Pj4+PiAr DQo+Pj4+Pj4+ICsgICAgUHJvcGVydHkgdW5kZXIgdGhlIHRvcC1sZXZlbCAiY2hvc2VuIiBub2Rl LiBJdCBzcGVjaWZpZXMgdGhlIGFkZHJlc3MNCj4+Pj4+Pj4gKyAgICBhbmQgc2l6ZSBvZiBYZW4g c3RhdGljIGhlYXAgbWVtb3J5LiBOb3RlIHRoYXQgYXQgbGVhc3QgYSA2NEtCDQo+Pj4+Pj4+ICsg ICAgYWxpZ25tZW50IGlzIHJlcXVpcmVkLg0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICstICN4ZW4sc3Rh dGljLWhlYXAtYWRkcmVzcy1jZWxscyBhbmQgI3hlbixzdGF0aWMtaGVhcC1zaXplLWNlbGxzDQo+ Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICBTcGVjaWZ5IHRoZSBudW1iZXIgb2YgY2VsbHMgdXNlZCBm b3IgdGhlIGFkZHJlc3MgYW5kIHNpemUgb2YgdGhlDQo+Pj4+Pj4+ICsgICAgInhlbixzdGF0aWMt aGVhcCIgcHJvcGVydHkgdW5kZXIgImNob3NlbiIuDQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gK0JlbG93 IGlzIGFuIGV4YW1wbGUgb24gaG93IHRvIHNwZWNpZnkgdGhlIHN0YXRpYyBoZWFwIGluIGRldmlj ZSB0cmVlOg0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgLyB7DQo+Pj4+Pj4+ICsgICAgICAgIGNo b3NlbiB7DQo+Pj4+Pj4+ICsgICAgICAgICAgICAjeGVuLHN0YXRpYy1oZWFwLWFkZHJlc3MtY2Vs bHMgPSA8MHgyPjsNCj4+Pj4+Pj4gKyAgICAgICAgICAgICN4ZW4sc3RhdGljLWhlYXAtc2l6ZS1j ZWxscyA9IDwweDI+Ow0KPj4+Pj4+IA0KPj4+Pj4+IFlvdXIgYmluZGluZywgaXMgaW50cm9kdWNl ICN4ZW4sc3RhdGljLWhlYXAte2FkZHJlc3MsIHNpemV9LWNlbGxzDQo+Pj4+Pj4gd2hlcmVhcyBQ ZW5ueSdzIG9uZSBpcyB1c2luZyAje2FkZHJlc3MsIHNpemV9LWNlbGxzIGV2ZW4gaWYgdGhlIHBy b3BlcnR5DQo+Pj4+Pj4gaXMgbm90ICJyZWciLg0KPj4+Pj4+IA0KPj4+Pj4+IEkgd291bGQgbGlr ZSBzb21lIGNvbnNpc3RlbmN5IGluIHRoZSB3YXkgd2UgZGVmaW5lIGJpbmRpbmdzLiBMb29raW5n IGF0DQo+Pj4+Pj4gdGhlIHRyZWUsIHdlIGFscmVhZHkgc2VlbSB0byBoYXZlIGludHJvZHVjZWQN Cj4+Pj4+PiAjeGVuLXN0YXRpYy1tZW0tYWRkcmVzcy1jZWxscy4gU28gbWF5YmUgd2Ugc2hvdWxk IGZvbGxvdyB5b3VyIGFwcHJvYWNoPw0KPj4+Pj4+IA0KPj4+Pj4+IFRoYXQgc2FpZCwgSSBhbSB3 b25kZXJpbmcgd2hldGhlciB3ZSBzaG91bGQganVzdCB1c2Ugb25lIHNldCBvZiBwcm9wZXJ0eQ0K Pj4+Pj4+IG5hbWUuDQo+Pj4+Pj4gDQo+Pj4+Pj4gSSBhbSBvcGVuIHRvIHN1Z2dlc3Rpb24gaGVy ZS4gTXkgb25seSByZXF1ZXN0IGlzIHdlIGFyZSBjb25zaXN0ZW50IChpLmUuDQo+Pj4+Pj4gdGhp cyBkb2Vzbid0IGRlcGVuZCBvbiB3aG8gd3JvdGUgdGhlIGJpbmRpbmdzKS4NCj4+Pj4+PiANCj4+ Pj4+IEluIG15IG9waW5pb24gd2Ugc2hvdWxkIGZvbGxvdyB0aGUgZGV2aWNlIHRyZWUgc3BlY2lm aWNhdGlvbiB3aGljaCBzdGF0ZXMNCj4+Pj4+IHRoYXQgdGhlICNhZGRyZXNzLWNlbGxzIGFuZCAj c2l6ZS1jZWxscyBjb3JyZXNwb25kIHRvIHRoZSByZWcgcHJvcGVydHkuDQo+Pj4+IA0KPj4+PiBI bW1tLi4uLiBMb29raW5nIGF0IFsxXSwgdGhlIHR3byBwcm9wZXJ0aWVzIGFyZSBub3QgZXhjbHVz aXZlIHRvICdyZWcnDQo+Pj4+IEZ1cnRoZXJtb3JlLCBJIGFtIG5vdCBhd2FyZSBvZiBhbnkgcmVz dHJpY3Rpb24gZm9yIHVzIHRvIHJlLXVzZSB0aGVtLiBEbw0KPj4+PiB5b3UgaGF2ZSBhIHBvaW50 ZXI/DQo+Pj4gDQo+Pj4gQXMgd2UgYXJlIGRpc2N1c3NpbmcgcmUtdXNhZ2Ugb2YgI2FkZHJlc3Mt Y2VsbHMgYW5kICNzaXplLWNlbGxzIGZvciBjdXN0b20gcHJvcGVydGllcyB0aGF0IGFyZSBub3Qg InJlZyIsDQo+Pj4gSSB0b29rIHRoaXMgaW5mbyBmcm9tIHRoZSBsYXRlc3QgZGV2aWNlIHRyZWUg c3BlY3MgZm91bmQgdW5kZXIgaHR0cHM6Ly9uYW0xMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRs b29rLmNvbS8/dXJsPWh0dHBzJTNBJTJGJTJGd3d3LmRldmljZXRyZWUub3JnJTJGc3BlY2lmaWNh dGlvbnMlMkYmYW1wO2RhdGE9MDUlN0MwMSU3Q21pY2hhbC5vcnplbCU0MGFtZC5jb20lN0M0ZjM1 ZTlmOTNiNzQ0M2FjNzNjODA4ZGE5MGNlY2MyMiU3QzNkZDg5NjFmZTQ4ODRlNjA4ZTExYTgyZDk5 NGUxODNkJTdDMCU3QzAlN0M2Mzc5ODE1MTUxMjI5OTMxMTElN0NVbmtub3duJTdDVFdGcGJHWnNi M2Q4ZXlKV0lqb2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxD SlhWQ0k2TW4wJTNEJTdDMzAwMCU3QyU3QyU3QyZhbXA7c2RhdGE9VGlFU1lTNlJYZGlQTFg4V0ZV VjBDc3p0QXZLN21IU3VkJTJCMHhvSnF3QXcwJTNEJmFtcDtyZXNlcnZlZD0wOg0KPj4+ICJUaGUg I2FkZHJlc3MtY2VsbHMgcHJvcGVydHkgZGVmaW5lcyB0aGUgbnVtYmVyIG9mIDx1MzI+IGNlbGxz IHVzZWQgdG8gZW5jb2RlIHRoZSBhZGRyZXNzIGZpZWxkIGluIGEgY2hpbGQgbm9kZSdzIHJlZyBw cm9wZXJ0eSINCj4+PiBhbmQNCj4+PiAiVGhlICNzaXplLWNlbGxzIHByb3BlcnR5IGRlZmluZXMg dGhlIG51bWJlciBvZiA8dTMyPiBjZWxscyB1c2VkIHRvIGVuY29kZSB0aGUgc2l6ZSBmaWVsZCBp biBhIGNoaWxkIG5vZGXigJlzIHJlZyBwcm9wZXJ0eSINCj4+IA0KPj4gUmlnaHQuIEJ1dCB0aGVy ZSBpcyBub3RoaW5nIGluIHRoZSB3b3JkaW5nIHN1Z2dlc3RpbmcgdGhhdA0KPj4gI2FkZHJlc3Mt Y2VsbHMgYW5kICNzaXplLWNlbGxzIGNhbid0IGJlIHJlLXVzZWQuIEZyb20gWzFdLCBpdCBpcyBj bGVhcg0KPj4gdGhhdCB0aGUgbWVhbmluZyBoYXMgY2hhbmdlZC4NCj4+IA0KPj4gU28gd2h5IGNh bid0IHdlIGRvIHRoZSBzYW1lPw0KPiBJIHRoaW5rIHRoaXMgaXMgYSBtYXR0ZXIgb2YgaG93IHNv bWVvbmUgcmVhZHMgdGhlc2Ugc2VudGVuY2VzLg0KPiBJIGRvIG5vdCB0aGluayB0aGF0IHN1Y2gg ZG9jdW1lbnRzIG5lZWQgdG8gc3RhdGU6DQo+ICJUaGlzIHByb3BlcnR5IGlzIGZvciB0aGUgcmVn LiBEbyBub3QgdXNlIGl0IGZvciBvdGhlciBwdXJwb3Nlcy4iDQo+IFRoZSBmaXJzdCBwYXJ0IG9m IHRoZSBzZW50ZW5jZSBpcyBlbm91Z2ggdG8gaW5mb3JtIHdoYXQgaXMgc3VwcG9ydGVkLg0KPiAN Cj4gT24gdGhlIG90aGVyIGhhbmQsIGxvb2tpbmcgYXQgWzFdIHRoZXNlIHByb3BlcnRpZXMgZ290 IG5ldyBwdXJwb3Nlcw0KPiBzbyBJIHRoaW5rIHdlIGNvdWxkIGRvIHRoZSBzYW1lLiBOb3cgdGhl IHF1ZXN0aW9uIGlzIHdoZXRoZXIgd2Ugd2FudCB0aGF0Lg0KPiBJIHRoaW5rIGl0IGlzIGRvYWJs ZSB0byBqdXN0IGhhdmUgYSBzaW5nbGUgcGFpciBvZiAjYWRkcmVzcy8jc2l6ZSBwcm9wZXJ0aWVz Lg0KPiBGb3IgaW5zdGFuY2UgeGVuLHNoYXJlZC1tZW0gcmVxdWlyaW5nIGp1c3QgMHgxIGZvciBh ZGRyZXNzL3NpemUNCj4gYW5kIHJlZyByZXF1aXJpbmcgMHgyLiBUaGlzIHdvdWxkIGp1c3QgaW1w bHkgcHV0dGluZyBhZGRpdGlvbmFsIDB4MDAuDQoNCkkgdGhpbmsgd2Ugd2FudCBpbiBnZW5lcmFs IHRvIHJlZHVjZSBjb21wbGV4aXR5IHdoZW4gcG9zc2libGUuDQpIZXJlIHdlIGFyZSBhZGRpbmcg YSBsb3Qgb2YgZW50cmllcyBpbiB0aGUgZGV2aWNlIHRyZWUgd2hlcmUgd2Uga25vdyB0aGF0DQpp biBhbGwgY2FzZXMgaGF2aW5nIG9ubHkgMiB3aWxsIHdvcmsgYWxsIHRoZSB0aW1lLg0KDQpJIGFt IG5vdCBjb252aW5jZWQgYnkgdGhlIGFyZ3VtZW50cyBvbiBub3QgdXNpbmcgI2FkZHJlc3MtY2Vs bHMgYW5kIHdpbGwNCmxlYXZlIHRoYXQgb25lIHRvIFN0ZWZhbm8NCg0KQnV0IGluIGFueSBjYXNl IHdlIHNob3VsZCBvbmx5IGFkZCBvbmUgcGFpciBoZXJlIGZvciBzdXJlLCBhcyB5b3Ugc2F5IHRo ZQ0Kb25seSBpbXBsaWNhdGlvbiBpcyB0byBhZGQgYSBjb3VwbGUgb2YgMCBpbiB0aGUgd29yc3Qg Y2FzZS4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPj4gDQo+PiBDaGVlcnMsDQo+PiANCj4+ IC0tDQo+PiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:31:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:31:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401724.643631 (Exim 4.92) (envelope-from ) id 1oVv9W-0001X9-Rw; Wed, 07 Sep 2022 13:31:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401724.643631; Wed, 07 Sep 2022 13:31:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv9W-0001X2-Oh; Wed, 07 Sep 2022 13:31:38 +0000 Received: by outflank-mailman (input) for mailman id 401724; Wed, 07 Sep 2022 13:31:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv9V-0001Ww-2P for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:31:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64d72397-2eb1-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:31:35 +0200 (CEST) Received: from AM6P192CA0070.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::47) by AM8PR08MB5651.eurprd08.prod.outlook.com (2603:10a6:20b:1c4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 13:31:34 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::2e) by AM6P192CA0070.outlook.office365.com (2603:10a6:209:82::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 13:31:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:31:34 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 07 Sep 2022 13:31:33 +0000 Received: from 74df6654d7e8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83336736-D6E1-48C1-A743-8AACFE48E2CD.1; Wed, 07 Sep 2022 13:31:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74df6654d7e8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:31:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB8645.eurprd08.prod.outlook.com (2603:10a6:20b:55c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 13:31:25 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:31:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64d72397-2eb1-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O5+ILeZm0MiAzA77IlkaFeUJ8r+B3amUhCVkViRVwmSxj8oKDOJb3fNcqA7/Zks7HTnUlVr71BNPNISaOxkZe/jn6do/aexoUsJRLG1uehfaOJs4GgBzVjxBEqnQvfPqN6E25CGFordtDNu/TybOI5JS90Nx9rhhbujJ8y8gNuyyNm4+kimAevS8lu7IrH455UdSE7OUou6X2MWusECWGeSwdhCmaTyO/ASd9Cw1FVOjk8Asaje4RJsNrS3mIHl2PaITKMJumYGSQXf/xypYETb7KQRqgSrumWSklJ8g8ZR4/Vk3ilrjXK57LDwJZETQJgE6bp1t5euZgupIlCKgHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHbEvZg2VmQdh1TU0dT7zEuTcLScvMknWkhUXNuEiuo=; b=NevV0C6fihSC6sDB+0uzwWNeliUNdpUYrPwr41unYYnabMIb1xyMhzu4kklL2cGrJ0v3pfQ/nHg8ABqsY22bkOJPwbWD9t3RnS6sLcXXUSboe27FD1I+tEbHoVYhBYWK4z8+R18CeTp7QCUzgWscqHnySgxQt948SDV8UWWcz0k4WqlJfjRHCGdXrxZkCuk2AKZx82iTIYDXKJFL4VOFfuYZmNk2fXR9aj4LuCB048+1lXOxcm3Oj06byggtlysyvW2kmLZcaGxA3tzWw1srrjf9tezt0B5efAcSE9EqMpIFk2hF/h2Ezz/lMVHdrCRyTVxHnFt/NEy/ZDwgsJATNA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHbEvZg2VmQdh1TU0dT7zEuTcLScvMknWkhUXNuEiuo=; b=eBQSSC1sZglpN9Zx1dM9jqFyGnDfecnXaU0ITvEbTldWqS22OUUBuFqjQs627CkdtizAq5nmhhpZVtzqeUcpUktFqaQHc80tyfaGZhJ9oL8aTSro6OPyUngloVe0+kIQZK210jOpyxXxeU8hdJBxrPw19CHGfvJ7s33M21p2+3o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3405c64fb6bc4c22 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bf9r0MKZwLDtieSCsaGuf8Zdxltb3nUmcXCze5s+yp9HvRS5FhyQV1oqpALFCQNdk9pbf62/tftx8lkxCoN0tc2Z58BqKbjDNqNqn7BsLX5dXWT1iYH4j7oaP6P8ft+kt8lJUWuxTU9vVSvvolgTYpsFThTmsnyJtwvuhJjyzr1bf22HzZNqhXVCodIvbV9b8FVmPIosZNoX5XiejaBjstmANG9BOHMtn/47dNtizauPAxNQmpDxAdceM7S1EYXsg2bUysHHRLE9r/0rET0aOeZ3EGJjz9NGnTX41mIUG44q0Uylq+lnsX1TQHsKIggN+oLFpUtu7bcJMhNu2Mlefw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHbEvZg2VmQdh1TU0dT7zEuTcLScvMknWkhUXNuEiuo=; b=AZnPD06TGcjXTbIONoZA5wYeBKsW29gPFCTALQjSGEJi2vYfgZqtY/0WbjZZDXPW/j9xT/l85maZuS1Uy6lhR2Afab/l2Qv/kWyqncbY/fpc2noqbCD59kF4To5YLtdOrhF46xP7wDMp4iFX1OqE/iNNWRcQ/xFSmk9ogirW/94fkb8yFiLzG+bngkJzRf0hte1fyNIx118KQVfcVrTwGrNySBQB2kDUZAC6IOAEP9HgBl9kWVEFiZWskLkcEgzXqlp75Cfp39Utg4HLb6CKQ9oHZItTioApmUgUHE26LAXmb5ELO67+shI/1pF0QKEMnKxYYc4JVL7ui5x7irVpHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHbEvZg2VmQdh1TU0dT7zEuTcLScvMknWkhUXNuEiuo=; b=eBQSSC1sZglpN9Zx1dM9jqFyGnDfecnXaU0ITvEbTldWqS22OUUBuFqjQs627CkdtizAq5nmhhpZVtzqeUcpUktFqaQHc80tyfaGZhJ9oL8aTSro6OPyUngloVe0+kIQZK210jOpyxXxeU8hdJBxrPw19CHGfvJ7s33M21p2+3o= From: Bertrand Marquis To: Jan Beulich CC: Rahul Singh , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYwqqLAtgrk5Z7CEC9g3vN92mek63T3yeAgAASqwCAAAJsAIAAAq2A Date: Wed, 7 Sep 2022 13:31:25 +0000 Message-ID: <749F6AF5-9BB2-4693-AD97-67BD79D0A6F4@arm.com> References: <06E1E4AB-5DA1-4AC4-9452-9507C2B75E81@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8875982e-51f4-497f-8c86-08da90d54847 x-ms-traffictypediagnostic: AS2PR08MB8645:EE_|AM7EUR03FT031:EE_|AM8PR08MB5651:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ak6hWFjCgCSHHWtrnhrwkhn2M4iBZv6CrDKkd2t4L7NktW57h0CTRjxQRohnkscYWBtXwcBFqvWMATfxdSIU0HCRCOzn5IN1U5Gi9lq4wu1GUHtGEs/oHCgGaZ1YhppgmVwWxqXeWvBN9qik6ppxXyVnzOuRGxaF+YBO8180L/mQAtF0nBwfAvgnLgApbmIrEPh3DsvWWl33r1mtaGhPY3TdyFKbPSXneL+QQeROH+lTt3BeqDFP7M8TDO8Bv19M3vWO64WXL0pS/FfKXk8XMijdM8M/11ojKjmhu6BuCm3gUnaR2qnMd7ao3crcVBrvkWL02aEwJikzUJy4WaTuPGbOa6XFrcUzqV4fDuFzWViEFegejPg9IXGTS2DIa0A6z5ITAMh/L3uxpnDgwFVxckIsjYnKzbhMvYidPwUpq6xmVgz4W4hCO1rKqIHgw8O/R3qdv51KsgZ9Cqrd+455WTdz8XP/1+YyK80J4mEu2r4VSvMH5/CjabLjJXyXzVOo9LJjzsiwKd4ijBwFVMG1ShQ+yWqV53L7ymbIGCec1MWi03OQv6Q4vGqcUbIhXlRldlBzkseWCo0NsGYk+BMM00O2RL4UbBu8Rzd4WYNJcw3B0O6J1kc1J16b439kmYBvMblbNzQtJ5aS4qaYBKR/WVNAdDb99ifg5Ydd23ckTrqcWbAOeZV7RK3Xzhn7PU3FJupjdTPHus7F75eiHeUjguXW6PoFmwca5eyHe0lvCg+dUuUi/gs4N2B7j0jQ1TbTssR1rM/kk71GM+xZePzo5nyLcpo8iCvnZQySU9Z8lf8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(6506007)(6512007)(478600001)(71200400001)(41300700001)(26005)(54906003)(6916009)(316002)(38070700005)(6486002)(38100700002)(186003)(122000001)(2616005)(86362001)(4326008)(33656002)(53546011)(76116006)(91956017)(66946007)(8676002)(66556008)(66476007)(66446008)(64756008)(8936002)(2906002)(36756003)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8645 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4d638226-3aab-4c3f-92cc-08da90d54306 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jFdmo30PzBM5WT4wKpEaCVjgXAG9f9XMFQld2TN/zQf3V4zMVeuCykH38IsrOEUOVUFUSAaJ++Z8OZT5WRBmgPhHYU47pNXPLJx4pAg5c1QRAlw6ldZD0ovzcTUNRb/95uuMOOoZwvy8EW6ffNGMad3Rl5nUrCwx0WmOspcM+LzDUEPSOt3G6ucoPAa/zxsnlUITflb7CQy96BhtUYZVJSEKjTpjGMdXEqulQpFKHmljgUgr028Z83waH7zbwcKV0/bXE3GnIlC09ivJ7B3jYUUNSTKy3RX3c2x/5u/2h92O+Q6U4p+bb9hy3lqK7WUQzGUIdDLQ/1uELcAOFMzuUdBe/IwTc3anpg6kwEmW7t9T/B6LwEnzeMhnWfO0kzV2c53nwCWxX6CxA2VZgtGUHp12dzb98T3zkedGuROQMtNJlXyMgtvAFRcN7dxtekU43G3xpkVswRZAApl6u7mmzdyYV6gO9eK6wMDSzXSevdN3USOaGxOE1YFtN4PTfkMoiYNgLrxqAXjRTDCs5hgc6m/kfMzV3N/DUTJPoa66he/VEGJMeQTYw64Ge4E4IeV8MvwSYnXQ3Iwl2tm3ba5HvANe+A7bknYqf1VGMIeSOCILP3xZhRPIkGoQC7tAk9lfUuJMP2V5UEpY0lOaagbbv8JArwVk4BCf2AJm0460HFK/aZ+43daYUsrMo4bGR9EiuJ4AmPqLvrBTUy3OTGT/W625WKkj88tJMkz64yXuRuwkGFzSpMtv1A7yK+Wg07TVbQt6uj9py6vKwRC9jsQMZw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(40470700004)(46966006)(36840700001)(81166007)(336012)(186003)(4326008)(2616005)(6486002)(316002)(70206006)(36756003)(47076005)(8676002)(54906003)(70586007)(82310400005)(86362001)(53546011)(2906002)(6506007)(41300700001)(26005)(40460700003)(6512007)(478600001)(5660300002)(6862004)(36860700001)(82740400003)(40480700001)(33656002)(8936002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:31:34.0803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8875982e-51f4-497f-8c86-08da90d54847 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5651 Hi, > On 7 Sep 2022, at 14:21, Jan Beulich wrote: >=20 > On 07.09.2022 15:13, Bertrand Marquis wrote: >> Hi Jan, >>=20 >>> On 7 Sep 2022, at 13:06, Jan Beulich wrote: >>>=20 >>> On 07.09.2022 13:09, Rahul Singh wrote: >>>> is_memory_hole was implemented for x86 and not for ARM when introduced= . >>>> Replace is_memory_hole call to pci_check_bar as function should check >>>> if device BAR is in defined memory range. Also, add an implementation >>>> for ARM which is required for PCI passthrough. >>>>=20 >>>> On x86, pci_check_bar will call is_memory_hole which will check if BAR >>>> is not overlapping with any memory region defined in the memory map. >>>>=20 >>>> On ARM, pci_check_bar will go through the host bridge ranges and check >>>> if the BAR is in the range of defined ranges. >>>>=20 >>>> Signed-off-by: Rahul Singh >>>> --- >>>> Changes in v4: >>>> - check "s <=3D e" before callback >>>> - Add TODO comment for revisiting the function pci_check_bar() when >>>> ACPI PCI passthrough support is added. >>>> - Not Added the Jan Acked-by as patch is modified. >>>=20 >>> Hmm, I don't see any change to the parts the ack covers (x86 and common= ), >>> so please re-instate. I'm not in the position to ack Arm changes; thing= s >>> would be different for a Reviewed-by without scope restriction. >>=20 >> This might have been clear for you but your ack was not mentioning anyth= ing. >> As the newer version is modified anyway, we remove it. >=20 > An ack can only ever apply to changes to files the person offering the > tag is a maintainer of. Hence there's rarely a reason to scope-restrict > it. As opposed to Reviewed-by, where someone may indeed have reviewed > only part of a patch. Distinction of scope handling between ack and R-b here would require to che= ck in the MAINTAINERS which parts are in the scope. Maybe explicitly putting t= he scope with the ack could be useful here. >=20 >> But I understand from your answer that your ack is still valid for this = version. >=20 > That's correct. >=20 Thanks Bertrand > Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:32:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:32:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401728.643642 (Exim 4.92) (envelope-from ) id 1oVvA1-000229-7r; Wed, 07 Sep 2022 13:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401728.643642; Wed, 07 Sep 2022 13:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvA1-000222-4r; Wed, 07 Sep 2022 13:32:09 +0000 Received: by outflank-mailman (input) for mailman id 401728; Wed, 07 Sep 2022 13:32:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVv9z-0001Ww-A9 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:32:07 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 761fb0f1-2eb1-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:32:05 +0200 (CEST) Received: from BN9PR03CA0932.namprd03.prod.outlook.com (2603:10b6:408:108::7) by PH7PR12MB5759.namprd12.prod.outlook.com (2603:10b6:510:1d2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 13:32:01 +0000 Received: from BN8NAM11FT102.eop-nam11.prod.protection.outlook.com (2603:10b6:408:108:cafe::fa) by BN9PR03CA0932.outlook.office365.com (2603:10b6:408:108::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Wed, 7 Sep 2022 13:32:01 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT102.mail.protection.outlook.com (10.13.177.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:32:01 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 08:32:01 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 08:31:59 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 761fb0f1-2eb1-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hjRaPRWunX7OAQ322uTrcVj0SZFPqk7+eCTxQZHz3wil2zJF2tqc9fdChcjtzMwWHo3wn/rmcWOomGutpUdC+hcPFjiXeY9Wiw7xvUu610a1HQYrWbelAk3uOlF57d/F9+VfnbwL4rO0LZAOHX/GLcJfzgLtz0hw00grN68UpfHwuL7sMiN1DtLb/eIlpWPUFyBY9jIipZ7lS+Z3vHRUogmy8GlKG0yuMjtoVQlMUbX6FHBB/xkehfgOJXnYRKTURdhQwF+4hdtCLy7lsIvDKtwp/suL5ePNj7QkS2d9KXBsG9j4c8PHupEqb8ExcwaXEAGVZvq/tBu8IA8kr2wLPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=saWxUsOCnIN1GHIPpT2/IpKXb61jM2DLyBuEiVwJIl0=; b=Cz1Y3mjWQOSdErmR3AViUPD0dfznP0okrAQTj3WDeLelYAeBHNDSVmZGsa34FjvRUZwC9y2UyhRqcOWB9WF+AnWW8aJ/xPq36++44zVc/I3yNpqOKOi1gY8IWr3JbVT8l76oCfgPqkd7+LjOCHvUMxf2HMAKw3XaPVR6wHL475MxMQXa2bHGEgTMQtBAOwOnjF+Jui0Ld1+eKUJWAnlQ5ZGCo5tLCdak9Fzyy+nzh8jObLtoW0ihTEqW9/7lr2zibez6GgIMza7wu0VZiwSSwYGgj6l7T6HM5jy5TB8FULh/acl9eaqzFwLQQCVjPpRsUCYS1mpM3Ebueh0Jitlwow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=saWxUsOCnIN1GHIPpT2/IpKXb61jM2DLyBuEiVwJIl0=; b=omkcmt3Iz2HCkvbaTiCPQK60f+p7Do1/XKqT3XMrobta1uyfrJy4yZy40fbueZ4lIZtXBOTsR5ZZx1mq8PWdUDJMoeX6z5fMsGA6+wdPEl2YOf7kCCAxcsy87rVj62mrsUxga9bcRbYRge4aJgfZtUqk+16oQtK0Ek1eTWswBHw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> Date: Wed, 7 Sep 2022 15:31:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Bertrand Marquis CC: Julien Grall , Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT102:EE_|PH7PR12MB5759:EE_ X-MS-Office365-Filtering-Correlation-Id: adf7c9b3-f1e8-4bab-7ac9-08da90d558a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 81o7BCGwHtiJlAf5KF3AHv2MHEqe3npePCDSz50Za16stgRebGVKunZPGGJXUSYWZnHKxoOHd8fWzL7qpioHI/emnydqx0ZUSOPEUfG527RQ1QXREs5yuuKXCrOEtQaZc0aUQehEEYhU3se5imFID4qNl5kW+vOoZ3A7O2as/RRmLJYcgYu5X5LxGhO3lfAgEbdQuQeqK06x9bWj6ylqCcMgOP9RaVVmA+Db08bFwYiJho/kuuDNijt1J+50iH2DCC02kEeIyHfPR9mINpD4yVrow5n6XPLrlhuDhz/6rEi+0/qvXaxgetutt4be+gw7AT2iS1M80k2tp8BJsogOX7ZSO+D1b0swfz4rXGwZdD5Dqln0dvUsmAs77flrHSJY+Oy7ZhnNwwGeDwGtJk9OHGADcX9+yUI7D+PUjcl27HXYmg0M6CBhBXK0tNamy82dERDRncN8BCytMZ2FOQOj6h24YPklr+4uVF7VJNjbAlcHmfkLE0jlvBitpZQGUJ9cOmpsLWa1O//tzcB+Cq24N7uUwZi7myVEDkVDCXOyMoW1c+GHb43a/1i6itFF0394zJK2IsQQ0coJJ8yf/3Il+d/htuZamrxg72xSFvqHMKFKJv+HBU7bChcOvVq7urrVEMYknCndLUqdmK7WOZFfJOH1mNI6idUcpHmkmtALt+ZYREvkplCO4eri9SIS9eEnqh3niEi84djFqYg0jni+tIsli7D4EnnzkYiZHdymAazqvunq0TAH71V2AjBaM0ZrLR/ol/R7zEqXeHtFZHsgmfNcgLmrcvFdwHeQ1YF9Ky7mb8rSMyHRyWI/u4NJQok/uKBfoDPJqVBcN8fp1ZuzVp2Qc8SCydR/e1il5YjqSx8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(40470700004)(36840700001)(46966006)(36756003)(26005)(8936002)(40480700001)(186003)(426003)(2616005)(336012)(47076005)(5660300002)(31696002)(31686004)(44832011)(86362001)(41300700001)(2906002)(478600001)(966005)(53546011)(81166007)(356005)(70586007)(6916009)(316002)(45080400002)(70206006)(82310400005)(82740400003)(54906003)(40460700003)(4326008)(36860700001)(83380400001)(8676002)(16576012)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:32:01.5657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: adf7c9b3-f1e8-4bab-7ac9-08da90d558a9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT102.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5759 On 07/09/2022 15:28, Bertrand Marquis wrote: > > Hi Michal, > >> On 7 Sep 2022, at 14:09, Michal Orzel wrote: >> >> >> On 07/09/2022 14:45, Julien Grall wrote: >>> >>> On 07/09/2022 13:41, Michal Orzel wrote: >>>> >>>> >>>> On 07/09/2022 14:32, Julien Grall wrote: >>>>> [CAUTION: External Email] >>>>> >>>>> On 07/09/2022 13:12, Michal Orzel wrote: >>>>>> Hi Julien, >>>>> >>>>> Hi Michal, >>>>> >>>>>> On 07/09/2022 13:36, Julien Grall wrote: >>>>>>> >>>>>>> Hi Henry, >>>>>>> >>>>>>> While reviewing the binding sent by Penny I noticed some inconsistency >>>>>>> with the one you introduced. See below. >>>>>>> >>>>>>> On 07/09/2022 09:36, Henry Wang wrote: >>>>>>>> +- xen,static-heap >>>>>>>> + >>>>>>>> + Property under the top-level "chosen" node. It specifies the address >>>>>>>> + and size of Xen static heap memory. Note that at least a 64KB >>>>>>>> + alignment is required. >>>>>>>> + >>>>>>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>>>>>>> + >>>>>>>> + Specify the number of cells used for the address and size of the >>>>>>>> + "xen,static-heap" property under "chosen". >>>>>>>> + >>>>>>>> +Below is an example on how to specify the static heap in device tree: >>>>>>>> + >>>>>>>> + / { >>>>>>>> + chosen { >>>>>>>> + #xen,static-heap-address-cells = <0x2>; >>>>>>>> + #xen,static-heap-size-cells = <0x2>; >>>>>>> >>>>>>> Your binding, is introduce #xen,static-heap-{address, size}-cells >>>>>>> whereas Penny's one is using #{address, size}-cells even if the property >>>>>>> is not "reg". >>>>>>> >>>>>>> I would like some consistency in the way we define bindings. Looking at >>>>>>> the tree, we already seem to have introduced >>>>>>> #xen-static-mem-address-cells. So maybe we should follow your approach? >>>>>>> >>>>>>> That said, I am wondering whether we should just use one set of property >>>>>>> name. >>>>>>> >>>>>>> I am open to suggestion here. My only request is we are consistent (i.e. >>>>>>> this doesn't depend on who wrote the bindings). >>>>>>> >>>>>> In my opinion we should follow the device tree specification which states >>>>>> that the #address-cells and #size-cells correspond to the reg property. >>>>> >>>>> Hmmm.... Looking at [1], the two properties are not exclusive to 'reg' >>>>> Furthermore, I am not aware of any restriction for us to re-use them. Do >>>>> you have a pointer? >>>> >>>> As we are discussing re-usage of #address-cells and #size-cells for custom properties that are not "reg", >>>> I took this info from the latest device tree specs found under https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.devicetree.org%2Fspecifications%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C83da1eb9d32441cb9e8108da90d4f2d6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637981541539851438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3M9aT3LjCEOhZUHWSbgSSmKppY1Wion4TT3BeKLnWSo%3D&reserved=0: >>>> "The #address-cells property defines the number of cells used to encode the address field in a child node's reg property" >>>> and >>>> "The #size-cells property defines the number of cells used to encode the size field in a child node’s reg property" >>> >>> Right. But there is nothing in the wording suggesting that >>> #address-cells and #size-cells can't be re-used. From [1], it is clear >>> that the meaning has changed. >>> >>> So why can't we do the same? >> I think this is a matter of how someone reads these sentences. >> I do not think that such documents need to state: >> "This property is for the reg. Do not use it for other purposes." >> The first part of the sentence is enough to inform what is supported. >> >> On the other hand, looking at [1] these properties got new purposes >> so I think we could do the same. Now the question is whether we want that. >> I think it is doable to just have a single pair of #address/#size properties. >> For instance xen,shared-mem requiring just 0x1 for address/size >> and reg requiring 0x2. This would just imply putting additional 0x00. > > I think we want in general to reduce complexity when possible. > Here we are adding a lot of entries in the device tree where we know that > in all cases having only 2 will work all the time. > > I am not convinced by the arguments on not using #address-cells and will > leave that one to Stefano > > But in any case we should only add one pair here for sure, as you say the > only implication is to add a couple of 0 in the worst case. I agree. The only drawback is the need to modify the already introduced properties to be coherent. > > Cheers > Bertrand > >> >>> >>> Cheers, >>> >>> -- >>> Julien Grall > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:34:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:34:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401740.643653 (Exim 4.92) (envelope-from ) id 1oVvBu-0002lw-Lv; Wed, 07 Sep 2022 13:34:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401740.643653; Wed, 07 Sep 2022 13:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvBu-0002lp-II; Wed, 07 Sep 2022 13:34:06 +0000 Received: by outflank-mailman (input) for mailman id 401740; Wed, 07 Sep 2022 13:34:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvBt-0002lh-5j for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:34:05 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00087.outbound.protection.outlook.com [40.107.0.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bd7a2088-2eb1-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:34:04 +0200 (CEST) Received: from DB6PR0801CA0049.eurprd08.prod.outlook.com (2603:10a6:4:2b::17) by VE1PR08MB5872.eurprd08.prod.outlook.com (2603:10a6:800:1aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 13:34:01 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::91) by DB6PR0801CA0049.outlook.office365.com (2603:10a6:4:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:34:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:34:00 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 13:34:00 +0000 Received: from 27396e6e561f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 97AA8E2B-3527-43F7-903E-630C36689147.1; Wed, 07 Sep 2022 13:33:50 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 27396e6e561f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:33:50 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAWPR08MB9448.eurprd08.prod.outlook.com (2603:10a6:102:2e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Wed, 7 Sep 2022 13:33:44 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:33:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd7a2088-2eb1-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VbrYs81XDThBxU7zKwjmR5dRW7NtHi/VC9Guxe3GcKvIjVTR19IYzVsovwiuOIUDmtr+uhst8d7qWnz0LTZZ2CD7nm+EDH+y2oYjnDElregdC6+ZZtaPnbyw2sn+KcC6egJKophVt+GCFqzAEjZvY4eH9OAEfb4lWVxi0QddahNlkdrNVtvz6+/6aNs/mB69tA5hq4TnKkz7c37zq7hqkYkW9+lwyL/LwTc97UzyCiQVy87WpHsi8C8h1urG4TN8PP5WA2FND64uGmb+XUxI2KWC+dtqH9MbXgRK7s18YoeKZgsc8kmdCeeGl/zNQ9yvucOBRQxUAJzy+vwmiVURZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yuZzUcl6bP6YQegikl/YSnNYl1eEsfkj4+jFTbGGkAY=; b=LM8oSe+zjxiTSA5cgDfcpeWMbnDnORE7E5m7lJMEzv213Eyh4YguUK6DaOfcpP7W9JZiJGzyqBRmF7pBpXTl2EyIowjlaq/CGDwAAFH4pDWqF+dB0qDpeVokv6hjHQK/kVbVWe6Py3BPEo5d46e5eBBwWkstG/+SILEwGfhzRdaTvft4DxR2jnqYMlVPwWEdCVPoCuKYsQ7ICgWq8TcseQsrIiirqGuHa7NA2BDFbe/4QXiqze2EUvp14oVqgAYQbVAvHfsBA3ts5rMVT9P2Rj2fkv3D3WVz/jsZXNHne79RjAPQ7WoxnkFFtfsb3F+n2htof8/uwWDw7me06M59fQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yuZzUcl6bP6YQegikl/YSnNYl1eEsfkj4+jFTbGGkAY=; b=FJQ4syXa7V8IRtiLO/ZSkI7kePJJmpId1LEFeP/hjqgS8EO1JVjnEQWYukoF6YVH9xUSlrAM3Glu2k7BCI0iSRdsnCSdpzuPsm7asa/BRAoAL9nzudlTiv2edAEE4CiWADpUNUuQK1AptWPLAtQ5NXIjKE4rMTL2vNt+xol3N9Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2818d83e49491b65 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gxf0UmPBhDBzuf10JlfM2ndCQccpnLnkAX0S4D9vkXH47LdU8gO7NKp2tm3S2jnseFFP4fMY9mcoCK7LiOFuSdUr5Htx3JAyVAgYyZ86s1tKDH6lVJpf0xCu9yV8NpERGjAX8wgrROzF6qImRn1Xk2rvgz3E5wdSouo1XuOGh+CHLgYopTOalj3eVWU92tEQ+ZgCGTo/KpQEWi2AgW34TPfT+jpRCJ3ORg5LCQ6G0I9X9/VgRVIgI1Pf8LLZq0JQ+V91TDglzaevd0SHaL6J1DJenwbW/dFpUpL8Aw7cMqc2xp0uQYBhAhAfl1DXKvrwbMuhQB46DpW1O7jXzdJzhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yuZzUcl6bP6YQegikl/YSnNYl1eEsfkj4+jFTbGGkAY=; b=k968bPOJXbuedz0YlyyvAcMObmlKMf1z4k/9Qc0OIU2azF9Y18uxZOTdqsoSsOscrQYFy5tr4uQG0fIqEivwZblQIEPt516UBM1ixh1l8GSfxN0xMvC2YFOPOagRpaWHeLUBwvcGXnmE88q/3v+t6aPeQioMZrAWDnWEbvx6MgWPNcQHDoX7CqIMduNRWa9Yl9nei6AzG9ECLyOL9J72Zd0MVavexdb99Tog8gVZsmVbNxLrKyOMPOVrA2TNaYfcj88GXPuQ5Wltd+zUWNzG+3o/T5FvosVTrQ47rU2KPu874G/JEcTi3CryzcJVFPgYFOf32fEb/Bc/6tfvTEjNGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yuZzUcl6bP6YQegikl/YSnNYl1eEsfkj4+jFTbGGkAY=; b=FJQ4syXa7V8IRtiLO/ZSkI7kePJJmpId1LEFeP/hjqgS8EO1JVjnEQWYukoF6YVH9xUSlrAM3Glu2k7BCI0iSRdsnCSdpzuPsm7asa/BRAoAL9nzudlTiv2edAEE4CiWADpUNUuQK1AptWPLAtQ5NXIjKE4rMTL2vNt+xol3N9Y= From: Bertrand Marquis To: Michal Orzel CC: Julien Grall , Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gA== Date: Wed, 7 Sep 2022 13:33:43 +0000 Message-ID: <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> In-Reply-To: <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ad1ba62f-d2f7-4664-5f98-08da90d59fa8 x-ms-traffictypediagnostic: PAWPR08MB9448:EE_|DBAEUR03FT058:EE_|VE1PR08MB5872:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pq0VWNlThaGLTTG/P1uY1rgpAWY0axcR2FvFsaHbW6uOHXMpkHe1vcJTPyIyAplTpjsJUFV4gL/OC/Lj1K9wERnHLtT18aQluluydRWoKiRDDX0JW8Dg9OMe7GaVeS7xtuYEzANsZYGyJ00p58fRktyoLfsjcwMqbfrPOWbO/moyOSCeJGjrinOJvtGzafbqd2IOqOKaBFNneUT7mMzTlMM7xDS1N9PTXyk41/wJKeKP5vuoc1tXMtzv99lUge04HUr6fhVrhmMxDCCYKc0O7ybEJ3s2CkxuXmZ0/JYcgP/SdcxPEIkyprIF5wNqH+k51TOw6DZs8gRIHcXkzNi48pOeUDzUOLv57Z+fQ9tkOyYXz0qnAfjrvUNG6wH+tFJBRJZrVFq+sWGUG6GRdxNaltkAIrANJOjMnWcsMB1gTevYuY7YA8mcZTCSj9fhjV/6NiMMuzFci+9BIgUq1IAv42OU53nMAyMeVP8ck/Byg369v7d2870tb4jSF6wijip5ErIRBp2kBBCzhpEBbUJ5bieZPwcR2Hffr0PvHVFAjT6i2NXx+VgrozwzarizSpiRlHnAcz4qV2w+kkKh+miIiiZ0s+nk3jOpIpLUl0oMR0RGQkU6KC9EEx2nmd2kUfq6pYUkD48rNmnuI3qlQwxB3tIKSZCJ8Qkpf3gDLjvh+cAE2VFGbwh2C6I08vsKAPzdbHavAoSSjcW8z5tYRoYOEdwoaME1VHERJRghQQIsyTqR0V+K/LQljelkqvFWkRzujoUQNpHU1K2fg368oL7j1z+AO5SeIgnF+9M9Ew8T0rars68vIqMfKSzGx9bg85O6+P82OiLqy4Dk9tqDQeW48A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(36756003)(2616005)(53546011)(5660300002)(8936002)(26005)(186003)(86362001)(33656002)(6486002)(478600001)(6512007)(41300700001)(71200400001)(6506007)(966005)(38070700005)(66446008)(38100700002)(45080400002)(122000001)(91956017)(66946007)(316002)(76116006)(83380400001)(54906003)(8676002)(2906002)(6916009)(66556008)(66476007)(4326008)(64756008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <911B95FBB040F7439FA7EEC13D3F82EC@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9448 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e6d1011c-b3c8-4830-4f73-08da90d595ad X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wyo7YWY/nYL4lKWa/plGHViuYj87Il75lJ/NjHgoTOEdB4kF638iMU68fHJEoU41pGVhV/YFFtNGIscqj1GUbmlvt9onKKYBC/Q3rOG9RUiKn2AcwCTDSsQq3/MWq5dyux/tEjRJ0j7wKNtvCSPyOdeJT3CdsfhtMleW3BumJszxiFY75923cvdTDY3KAIzy8nwLbSBmGDcUaV0FSTa06jXUmqGWK48TFKAQp4ToE1irwtbiH/fOWHlnbr8QVuGq133I5CEeUAfHWZn3iyyKB95GUiztNJAOJXhf6r8OTFHY76VkZGPdf9gEM2JioWyq7xx3hSB0w3w3O+VmmUkw1msXethrVUlhIMpU2mk6ZD8NSNOeupo3eyItTBUys3MpdfQfes19kFV4pukJbhc+ppkFWLL69QpnztVlOdsCLXgstZdbxXZ0IptJ1h/PbKC5eyXn8g58DRgqevgeS2JYdz3JIgmAXGp0vpfKyG2lhDFGc47yRSthlHq1kVH29M5b+TTWmAvSmzUw9WfDeQ+C/ziqpeeBnF5HO/xTt16vpyoaOB5vIGWjHflcK8o/EJnobkSXD3Sdqmj+kU2HBh207Uxb6aZP7Y7Cg0+Q3vRsS/iJYYcOQ+C4Mu8obdVjDaeuOqN5gPqCvuXbMiEG26YlUfIVprQbcTEh11RFacRL3vR9IMoANb6VUt1U2FQnjFhevx88gp9B4aVGWTxLr9Y59vlDor91FnQEhULLfYUB1HrO68cYhZoP3TzGg7hdHW13bs6NNcMlVufdIxGrOBGOodzMvk/16m91ijAOnn7blaM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(396003)(346002)(376002)(36840700001)(40470700004)(46966006)(54906003)(336012)(47076005)(41300700001)(316002)(2616005)(40480700001)(8676002)(70206006)(70586007)(186003)(4326008)(86362001)(6506007)(36756003)(33656002)(53546011)(478600001)(6486002)(966005)(26005)(6512007)(40460700003)(6862004)(8936002)(2906002)(36860700001)(5660300002)(82310400005)(45080400002)(81166007)(83380400001)(356005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:34:00.7392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad1ba62f-d2f7-4664-5f98-08da90d59fa8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5872 DQoNCj4gT24gNyBTZXAgMjAyMiwgYXQgMTQ6MzEsIE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs QGFtZC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDE1OjI4LCBCZXJ0 cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gDQo+PiBIaSBNaWNoYWwsDQo+PiANCj4+PiBPbiA3IFNl cCAyMDIyLCBhdCAxNDowOSwgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4gd3Jv dGU6DQo+Pj4gDQo+Pj4gDQo+Pj4gT24gMDcvMDkvMjAyMiAxNDo0NSwgSnVsaWVuIEdyYWxsIHdy b3RlOg0KPj4+PiANCj4+Pj4gT24gMDcvMDkvMjAyMiAxMzo0MSwgTWljaGFsIE9yemVsIHdyb3Rl Og0KPj4+Pj4gDQo+Pj4+PiANCj4+Pj4+IE9uIDA3LzA5LzIwMjIgMTQ6MzIsIEp1bGllbiBHcmFs bCB3cm90ZToNCj4+Pj4+PiBbQ0FVVElPTjogRXh0ZXJuYWwgRW1haWxdDQo+Pj4+Pj4gDQo+Pj4+ Pj4gT24gMDcvMDkvMjAyMiAxMzoxMiwgTWljaGFsIE9yemVsIHdyb3RlOg0KPj4+Pj4+PiBIaSBK dWxpZW4sDQo+Pj4+Pj4gDQo+Pj4+Pj4gSGkgTWljaGFsLA0KPj4+Pj4+IA0KPj4+Pj4+PiBPbiAw Ny8wOS8yMDIyIDEzOjM2LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+ IEhpIEhlbnJ5LA0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBXaGlsZSByZXZpZXdpbmcgdGhlIGJpbmRp bmcgc2VudCBieSBQZW5ueSBJIG5vdGljZWQgc29tZSBpbmNvbnNpc3RlbmN5DQo+Pj4+Pj4+PiB3 aXRoIHRoZSBvbmUgeW91IGludHJvZHVjZWQuIFNlZSBiZWxvdy4NCj4+Pj4+Pj4+IA0KPj4+Pj4+ Pj4gT24gMDcvMDkvMjAyMiAwOTozNiwgSGVucnkgV2FuZyB3cm90ZToNCj4+Pj4+Pj4+PiArLSB4 ZW4sc3RhdGljLWhlYXANCj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4gKyAgICBQcm9wZXJ0eSB1bmRl ciB0aGUgdG9wLWxldmVsICJjaG9zZW4iIG5vZGUuIEl0IHNwZWNpZmllcyB0aGUgYWRkcmVzcw0K Pj4+Pj4+Pj4+ICsgICAgYW5kIHNpemUgb2YgWGVuIHN0YXRpYyBoZWFwIG1lbW9yeS4gTm90ZSB0 aGF0IGF0IGxlYXN0IGEgNjRLQg0KPj4+Pj4+Pj4+ICsgICAgYWxpZ25tZW50IGlzIHJlcXVpcmVk Lg0KPj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+PiArLSAjeGVuLHN0YXRpYy1oZWFwLWFkZHJlc3MtY2Vs bHMgYW5kICN4ZW4sc3RhdGljLWhlYXAtc2l6ZS1jZWxscw0KPj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+ PiArICAgIFNwZWNpZnkgdGhlIG51bWJlciBvZiBjZWxscyB1c2VkIGZvciB0aGUgYWRkcmVzcyBh bmQgc2l6ZSBvZiB0aGUNCj4+Pj4+Pj4+PiArICAgICJ4ZW4sc3RhdGljLWhlYXAiIHByb3BlcnR5 IHVuZGVyICJjaG9zZW4iLg0KPj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+PiArQmVsb3cgaXMgYW4gZXhh bXBsZSBvbiBob3cgdG8gc3BlY2lmeSB0aGUgc3RhdGljIGhlYXAgaW4gZGV2aWNlIHRyZWU6DQo+ Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+ICsgICAgLyB7DQo+Pj4+Pj4+Pj4gKyAgICAgICAgY2hvc2Vu IHsNCj4+Pj4+Pj4+PiArICAgICAgICAgICAgI3hlbixzdGF0aWMtaGVhcC1hZGRyZXNzLWNlbGxz ID0gPDB4Mj47DQo+Pj4+Pj4+Pj4gKyAgICAgICAgICAgICN4ZW4sc3RhdGljLWhlYXAtc2l6ZS1j ZWxscyA9IDwweDI+Ow0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBZb3VyIGJpbmRpbmcsIGlzIGludHJv ZHVjZSAjeGVuLHN0YXRpYy1oZWFwLXthZGRyZXNzLCBzaXplfS1jZWxscw0KPj4+Pj4+Pj4gd2hl cmVhcyBQZW5ueSdzIG9uZSBpcyB1c2luZyAje2FkZHJlc3MsIHNpemV9LWNlbGxzIGV2ZW4gaWYg dGhlIHByb3BlcnR5DQo+Pj4+Pj4+PiBpcyBub3QgInJlZyIuDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+ IEkgd291bGQgbGlrZSBzb21lIGNvbnNpc3RlbmN5IGluIHRoZSB3YXkgd2UgZGVmaW5lIGJpbmRp bmdzLiBMb29raW5nIGF0DQo+Pj4+Pj4+PiB0aGUgdHJlZSwgd2UgYWxyZWFkeSBzZWVtIHRvIGhh dmUgaW50cm9kdWNlZA0KPj4+Pj4+Pj4gI3hlbi1zdGF0aWMtbWVtLWFkZHJlc3MtY2VsbHMuIFNv IG1heWJlIHdlIHNob3VsZCBmb2xsb3cgeW91ciBhcHByb2FjaD8NCj4+Pj4+Pj4+IA0KPj4+Pj4+ Pj4gVGhhdCBzYWlkLCBJIGFtIHdvbmRlcmluZyB3aGV0aGVyIHdlIHNob3VsZCBqdXN0IHVzZSBv bmUgc2V0IG9mIHByb3BlcnR5DQo+Pj4+Pj4+PiBuYW1lLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBJ IGFtIG9wZW4gdG8gc3VnZ2VzdGlvbiBoZXJlLiBNeSBvbmx5IHJlcXVlc3QgaXMgd2UgYXJlIGNv bnNpc3RlbnQgKGkuZS4NCj4+Pj4+Pj4+IHRoaXMgZG9lc24ndCBkZXBlbmQgb24gd2hvIHdyb3Rl IHRoZSBiaW5kaW5ncykuDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4gSW4gbXkgb3BpbmlvbiB3ZSBzaG91 bGQgZm9sbG93IHRoZSBkZXZpY2UgdHJlZSBzcGVjaWZpY2F0aW9uIHdoaWNoIHN0YXRlcw0KPj4+ Pj4+PiB0aGF0IHRoZSAjYWRkcmVzcy1jZWxscyBhbmQgI3NpemUtY2VsbHMgY29ycmVzcG9uZCB0 byB0aGUgcmVnIHByb3BlcnR5Lg0KPj4+Pj4+IA0KPj4+Pj4+IEhtbW0uLi4uIExvb2tpbmcgYXQg WzFdLCB0aGUgdHdvIHByb3BlcnRpZXMgYXJlIG5vdCBleGNsdXNpdmUgdG8gJ3JlZycNCj4+Pj4+ PiBGdXJ0aGVybW9yZSwgSSBhbSBub3QgYXdhcmUgb2YgYW55IHJlc3RyaWN0aW9uIGZvciB1cyB0 byByZS11c2UgdGhlbS4gRG8NCj4+Pj4+PiB5b3UgaGF2ZSBhIHBvaW50ZXI/DQo+Pj4+PiANCj4+ Pj4+IEFzIHdlIGFyZSBkaXNjdXNzaW5nIHJlLXVzYWdlIG9mICNhZGRyZXNzLWNlbGxzIGFuZCAj c2l6ZS1jZWxscyBmb3IgY3VzdG9tIHByb3BlcnRpZXMgdGhhdCBhcmUgbm90ICJyZWciLA0KPj4+ Pj4gSSB0b29rIHRoaXMgaW5mbyBmcm9tIHRoZSBsYXRlc3QgZGV2aWNlIHRyZWUgc3BlY3MgZm91 bmQgdW5kZXIgaHR0cHM6Ly9uYW0xMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/ dXJsPWh0dHBzJTNBJTJGJTJGd3d3LmRldmljZXRyZWUub3JnJTJGc3BlY2lmaWNhdGlvbnMlMkYm YW1wO2RhdGE9MDUlN0MwMSU3Q21pY2hhbC5vcnplbCU0MGFtZC5jb20lN0M4M2RhMWViOWQzMjQ0 MWNiOWU4MTA4ZGE5MGQ0ZjJkNiU3QzNkZDg5NjFmZTQ4ODRlNjA4ZTExYTgyZDk5NGUxODNkJTdD MCU3QzAlN0M2Mzc5ODE1NDE1Mzk4NTE0MzglN0NVbmtub3duJTdDVFdGcGJHWnNiM2Q4ZXlKV0lq b2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxDSlhWQ0k2TW4w JTNEJTdDMzAwMCU3QyU3QyU3QyZhbXA7c2RhdGE9M005YVQzTGpDRU9oWlVIV1NiZ1NTbUtwcFkx V2lvbjRUVDNCZUtMbldTbyUzRCZhbXA7cmVzZXJ2ZWQ9MDoNCj4+Pj4+ICJUaGUgI2FkZHJlc3Mt Y2VsbHMgcHJvcGVydHkgZGVmaW5lcyB0aGUgbnVtYmVyIG9mIDx1MzI+IGNlbGxzIHVzZWQgdG8g ZW5jb2RlIHRoZSBhZGRyZXNzIGZpZWxkIGluIGEgY2hpbGQgbm9kZSdzIHJlZyBwcm9wZXJ0eSIN Cj4+Pj4+IGFuZA0KPj4+Pj4gIlRoZSAjc2l6ZS1jZWxscyBwcm9wZXJ0eSBkZWZpbmVzIHRoZSBu dW1iZXIgb2YgPHUzMj4gY2VsbHMgdXNlZCB0byBlbmNvZGUgdGhlIHNpemUgZmllbGQgaW4gYSBj aGlsZCBub2Rl4oCZcyByZWcgcHJvcGVydHkiDQo+Pj4+IA0KPj4+PiBSaWdodC4gQnV0IHRoZXJl IGlzIG5vdGhpbmcgaW4gdGhlIHdvcmRpbmcgc3VnZ2VzdGluZyB0aGF0DQo+Pj4+ICNhZGRyZXNz LWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBjYW4ndCBiZSByZS11c2VkLiBGcm9tIFsxXSwgaXQgaXMg Y2xlYXINCj4+Pj4gdGhhdCB0aGUgbWVhbmluZyBoYXMgY2hhbmdlZC4NCj4+Pj4gDQo+Pj4+IFNv IHdoeSBjYW4ndCB3ZSBkbyB0aGUgc2FtZT8NCj4+PiBJIHRoaW5rIHRoaXMgaXMgYSBtYXR0ZXIg b2YgaG93IHNvbWVvbmUgcmVhZHMgdGhlc2Ugc2VudGVuY2VzLg0KPj4+IEkgZG8gbm90IHRoaW5r IHRoYXQgc3VjaCBkb2N1bWVudHMgbmVlZCB0byBzdGF0ZToNCj4+PiAiVGhpcyBwcm9wZXJ0eSBp cyBmb3IgdGhlIHJlZy4gRG8gbm90IHVzZSBpdCBmb3Igb3RoZXIgcHVycG9zZXMuIg0KPj4+IFRo ZSBmaXJzdCBwYXJ0IG9mIHRoZSBzZW50ZW5jZSBpcyBlbm91Z2ggdG8gaW5mb3JtIHdoYXQgaXMg c3VwcG9ydGVkLg0KPj4+IA0KPj4+IE9uIHRoZSBvdGhlciBoYW5kLCBsb29raW5nIGF0IFsxXSB0 aGVzZSBwcm9wZXJ0aWVzIGdvdCBuZXcgcHVycG9zZXMNCj4+PiBzbyBJIHRoaW5rIHdlIGNvdWxk IGRvIHRoZSBzYW1lLiBOb3cgdGhlIHF1ZXN0aW9uIGlzIHdoZXRoZXIgd2Ugd2FudCB0aGF0Lg0K Pj4+IEkgdGhpbmsgaXQgaXMgZG9hYmxlIHRvIGp1c3QgaGF2ZSBhIHNpbmdsZSBwYWlyIG9mICNh ZGRyZXNzLyNzaXplIHByb3BlcnRpZXMuDQo+Pj4gRm9yIGluc3RhbmNlIHhlbixzaGFyZWQtbWVt IHJlcXVpcmluZyBqdXN0IDB4MSBmb3IgYWRkcmVzcy9zaXplDQo+Pj4gYW5kIHJlZyByZXF1aXJp bmcgMHgyLiBUaGlzIHdvdWxkIGp1c3QgaW1wbHkgcHV0dGluZyBhZGRpdGlvbmFsIDB4MDAuDQo+ PiANCj4+IEkgdGhpbmsgd2Ugd2FudCBpbiBnZW5lcmFsIHRvIHJlZHVjZSBjb21wbGV4aXR5IHdo ZW4gcG9zc2libGUuDQo+PiBIZXJlIHdlIGFyZSBhZGRpbmcgYSBsb3Qgb2YgZW50cmllcyBpbiB0 aGUgZGV2aWNlIHRyZWUgd2hlcmUgd2Uga25vdyB0aGF0DQo+PiBpbiBhbGwgY2FzZXMgaGF2aW5n IG9ubHkgMiB3aWxsIHdvcmsgYWxsIHRoZSB0aW1lLg0KPj4gDQo+PiBJIGFtIG5vdCBjb252aW5j ZWQgYnkgdGhlIGFyZ3VtZW50cyBvbiBub3QgdXNpbmcgI2FkZHJlc3MtY2VsbHMgYW5kIHdpbGwN Cj4+IGxlYXZlIHRoYXQgb25lIHRvIFN0ZWZhbm8NCj4+IA0KPj4gQnV0IGluIGFueSBjYXNlIHdl IHNob3VsZCBvbmx5IGFkZCBvbmUgcGFpciBoZXJlIGZvciBzdXJlLCBhcyB5b3Ugc2F5IHRoZQ0K Pj4gb25seSBpbXBsaWNhdGlvbiBpcyB0byBhZGQgYSBjb3VwbGUgb2YgMCBpbiB0aGUgd29yc3Qg Y2FzZS4NCj4gSSBhZ3JlZS4gVGhlIG9ubHkgZHJhd2JhY2sgaXMgdGhlIG5lZWQgdG8gbW9kaWZ5 IHRoZSBhbHJlYWR5IGludHJvZHVjZWQgcHJvcGVydGllcw0KPiB0byBiZSBjb2hlcmVudC4NCg0K QWdyZWUsIHNvbWVvbmUgd2lsbCBuZWVkIHRvIGRvIGEgcGFzcyBvbiB0aGUgd2hvbGUgZG9jIHdo aWNoIG1pZ2h0IGJlIGVhc2llciB3aXRoIGFsbCB0aGluZ3MgaW4uDQoNCkNoZWVycw0KQmVydHJh bmQNCg0KPiANCj4+IA0KPj4gQ2hlZXJzDQo+PiBCZXJ0cmFuZA0KPj4gDQo+Pj4gDQo+Pj4+IA0K Pj4+PiBDaGVlcnMsDQo+Pj4+IA0KPj4+PiAtLQ0KPj4+PiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:35:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:35:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401748.643664 (Exim 4.92) (envelope-from ) id 1oVvDX-0003UU-5Y; Wed, 07 Sep 2022 13:35:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401748.643664; Wed, 07 Sep 2022 13:35:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvDX-0003UN-2o; Wed, 07 Sep 2022 13:35:47 +0000 Received: by outflank-mailman (input) for mailman id 401748; Wed, 07 Sep 2022 13:35:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvDV-0003UH-Vn for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:35:45 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f947e376-2eb1-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:35:44 +0200 (CEST) Received: from DU2PR04CA0222.eurprd04.prod.outlook.com (2603:10a6:10:2b1::17) by DU0PR08MB8493.eurprd08.prod.outlook.com (2603:10a6:10:406::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 13:35:41 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::2d) by DU2PR04CA0222.outlook.office365.com (2603:10a6:10:2b1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:35:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:35:40 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Wed, 07 Sep 2022 13:35:40 +0000 Received: from 47c1e760eb15.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E522B924-04C6-46A0-A19C-12F2891606FC.1; Wed, 07 Sep 2022 13:35:34 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 47c1e760eb15.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:35:34 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5662.eurprd08.prod.outlook.com (2603:10a6:800:1a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 13:35:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 13:35:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f947e376-2eb1-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O+rGSNpHfh/CsTAiVC3lBGroMoir4gm/Q78fLLnzp3z6YIseeqEDXYAwUORTI2CfzFRkPWevkku1IguWkvVKFGpXXygpX7kx9oRWY9sUtKWxdTB9TlDqVNKtDmHR1c6VKfAjBb4KPMJt1Rjxtne9kNohhdCem1CPEe1w0EGvEvEGo5UgReHubgbiajuJhb1g2/uPrz1tVF9fkQZARwMk1zze7w5RPtoELu2GnrZ7/D2C3Ykcx0tWFN4pHI+Pgkze49+3Lsbp/0VQ3oMC3MXuQ+Rua2r5Xhid3zOhKy+cPgat6gfFnEl4+qlgub1NckraSrKprUB3/aqjmvWQ8Wpa4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h4ZmMQqidJT7Q4k/GhU/0NX3xmBnpCrQfYcd7pdAtq8=; b=AY2jKJa3KJTGPUE1WV8UD2cl96cxxmr0Q23ZIdumdW8Nej+SEI7ipE8QcAEc2QAIDJS/+hofLwytB+Ftu+CbYEmRcazM3UIQ8Q9LsC9WFrjErXSILP1ILaSBLmeuNG5/5mcaL8kE8wDovQpGdzNz07+rcDnIGrrFv8JBpO6t4I3Ed5wYUb5V2tpT3AvImW2IiNegzm4zNVzyAD1KJnjkYrdGwGO/HhibDAfnBURNudiLJRLScU3tysUIR89ttLvj/h8euZTBInz3CVuKVSOMo4ZnWD8IVkEE23QRjZrlQGyAtWJdngabnsmP2/bbSIDNtmPNGZhyDlBoK8rusO7caQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h4ZmMQqidJT7Q4k/GhU/0NX3xmBnpCrQfYcd7pdAtq8=; b=w5UJmidw/l2geUtMDWHe2Vrui8ksWgMk7mPOU5VIEsXhsEdBV2b1WGyx5Dj5F3MUuz+c58jCTXzoa8+SwAloxs8GE72a6NC8BcJOdXKmWGsEDZ/FeqESlbfeQyFGvB+5qYmQ4f7usFoWlpndOwWUmdfJUX/CWeOXCSuUUYBXkp4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTDj9iT3YFu8CqwieZUnBixvJKA25NFm5IKCns35UMieWONYLMluNHRiWDBmf9ot5vIqlY5nrzLEIqC5mtge2ZIzO/AIdQSHpK4DIJYsoE4aChDD2UKzayjVQsSvJQ7Af6eOZQ2OufTtT6LlbyZGMZyUo79uMDV6sKA2M+5N6wnCYFLrx3ajPd6DBC2OHSufQ9yfvTKP2drgie/Cd9TJLT9/G8UL4tI+ea9JDNpb+YtWDyZg5bs3yvvkH6GWrEK6k/XxPwQhd7+HJ8GJwCITkaSpAy5ILplFDlRFHfsiroucgTXvIlCDS+Y7D8p0g77ozuZFT7SVqlE32u5vNYsyww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h4ZmMQqidJT7Q4k/GhU/0NX3xmBnpCrQfYcd7pdAtq8=; b=Yna1g87Kf1EHNeBqHcQSJRFiswhTwCyIFnbxyA7E0nAdvX+bJIOz/uU9nPBZA2lcAog+mfzgVR0Fw5gmf88JPdp9yy/Zzkm2dvB1R3ImeeM4k4QKv/m3aUJ0lvJQy0Sfi7+a4x6dGe5Gu2acdzBomFNDCEVA1ybwy42ky6dWZCKuWIQvY2RKItgu0Mydit8MXW/1vNUCvMtLuyUXG4vH0BMix9pM2Clxmjv4qSZ4xlSEHjHIZXBx3aw1l0UV5OgnNgX1Iu1Ck+OpF0oY+bGu+b1tSEYgbZi17R/ctSUE9KEQfhSPnQdnmCJ5FzBkihjPpfvQhhLD/hbuNXmuzNXo/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h4ZmMQqidJT7Q4k/GhU/0NX3xmBnpCrQfYcd7pdAtq8=; b=w5UJmidw/l2geUtMDWHe2Vrui8ksWgMk7mPOU5VIEsXhsEdBV2b1WGyx5Dj5F3MUuz+c58jCTXzoa8+SwAloxs8GE72a6NC8BcJOdXKmWGsEDZ/FeqESlbfeQyFGvB+5qYmQ4f7usFoWlpndOwWUmdfJUX/CWeOXCSuUUYBXkp4= From: Henry Wang To: Michal Orzel , Bertrand Marquis , Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAABTEA== Date: Wed, 7 Sep 2022 13:35:31 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> In-Reply-To: <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6FAEA4B1AA7C5740B344C9FA492ED290.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b692af66-0174-4bb2-96ea-08da90d5db4c x-ms-traffictypediagnostic: VE1PR08MB5662:EE_|DBAEUR03FT063:EE_|DU0PR08MB8493:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mcmeB5t9q1tRs8x2AijSlTSd2SDd0Nq2CZfTw6MQg1j7R/OBR5Hu4FmkpD4VB1xrYK/hW4dFndme6MnrNtMjeeh7kFQqNPjM+/y06sWrW0yPSDJo7Smycod7vjX9eFZgQwjO0+DraLI7b8sz5Xxao9tphLw4jCaiMnEU314DW1l6iJ9uJD4KsI3gg2wk/lfdUEZhZQZOt379Ag1qd/UVjIs8SruVaagQq+aO6+in28sCETaqUA3MIM8kbrLah2f3TXt8mgy2rDsDruDQO8wsAK0gYt5lRq5nKoenKmtobQGGMrkU2fKeM2UnLzWKOyCIzKyGNbaCfeMCx/CoZVX82OJDnfz2nRH1CBMf4v6Nockd1c1Fw8hsexd3mp4y5NnooKMBeWwvcmb1gjsl97Sk6aazC18oGZP4/+YAe7OSPUpYES2TjKGYu5dO+JLI19A3v9pEnpM+DZBW80vaD1NyQAcgV+aIxsXUWnA6t3/zYvpfz6kepOdk17x02lDw7N11TKiSLpBPz0nZaD+H7lIRbL9G3sHeyXP09C7CrzKi4Gh/5Ef5x7b4aTcoKZTWiejaG7SFfXtzajcZ0N7saUpKmRGWFrGgaHNZ6HBjiQDhqw9sFL/4vg6NABKwP1HiluHBj8PsMj+sUhvSu7iMcCS/WYaF5tM3x0e/zxWCtlrhoJENmQzB+tyr2EkniHw5dGld7TkQsQO4kQM/gFRxjpSI5K8lFSbniE55fjNfJ4PIiUXadDVdAHdToqbWPT4iUh82wXRjGZMRTPX7Q1cMGCYCvg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(39860400002)(346002)(396003)(136003)(33656002)(5660300002)(4744005)(76116006)(52536014)(54906003)(4326008)(66946007)(316002)(2906002)(110136005)(8676002)(8936002)(66556008)(66476007)(66446008)(64756008)(478600001)(86362001)(7696005)(6506007)(55016003)(26005)(71200400001)(38100700002)(38070700005)(83380400001)(186003)(9686003)(41300700001)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5662 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a742e86a-c9d6-4f99-8cdc-08da90d5d5fa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fMg0Lp319fjrpotfjZQsoryHIQo/eDFTiwaG83dyhtbu5myzYU2OwEUJCdUgzAIY9SCUSpMwelsehkDwGb5mKkVCoKso5AmrrQ8AHrnEVLKzG6hSHusnyBYYxNx5nQz8L12BLlXmgsRFVmfDeXP2MbLTVQBzDK0RIteSBQtAhDUooQWJFl47sZbPnDifvoOSvp0GPdUWWuoIJK1Hj3FGQ/6J74aC2bQ7UDfvhliOcKO+kR4m7RPr/rcaDg58Da2wTcliLstVlouiG9qpwpQK4qPpd13n6iT0PEyaCZzaMiIUr0LhU4srAe1oainbNSla3ckUvifyjdNzdpBjDdeNuRQKS+b2lxvtjx4ZzbEie8BL/B0u0LgO7MsYR7P3taV04ui1pRbtELXBjwxxMQqvDeqqhPIOtzJU2HYXm5HJ3oYXKyOZCrgfkL5gRPii0ht6EmNW/DUSO8uO8RYgylv7Ri5GY9pTkm16OUsjTxtKvMpsq7iXTmEr7GNK5eLn7CMrVpsdhg1osjOJs2ghpo4rtVe+fzV3Z6EZHCcEyKXzA+IUlYREnhTTNKmfhExGG/P2db4T7bazG/B0492dAQwRoc6BS0AWrtEVGPU8DXYI/q+EvXLtXXYETFYZOpwxHjIyh2XhGE0+pqlie4NhCIogf6GAK4dFb5fGyKURpEtF05sgWJWM5BV0YplbepD0Vdum9iATmJj1G6S0jvrtZmdK9G5HryJG594K/FRGRLnxsXlReXu+VDa6N2Z60DKbd5e1yje3jXZKeGlrGpNJE5dK4Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(396003)(376002)(40470700004)(46966006)(36840700001)(6506007)(356005)(47076005)(52536014)(4744005)(5660300002)(33656002)(186003)(41300700001)(40460700003)(81166007)(8936002)(2906002)(7696005)(86362001)(9686003)(26005)(36860700001)(55016003)(82740400003)(40480700001)(336012)(316002)(82310400005)(54906003)(70206006)(70586007)(478600001)(83380400001)(4326008)(110136005)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:35:40.7853 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b692af66-0174-4bb2-96ea-08da90d5db4c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8493 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4gSSBhbSBub3QgY29udmluY2VkIGJ5 IHRoZSBhcmd1bWVudHMgb24gbm90IHVzaW5nICNhZGRyZXNzLWNlbGxzIGFuZCB3aWxsDQo+ID4g bGVhdmUgdGhhdCBvbmUgdG8gU3RlZmFubw0KPiA+DQo+ID4gQnV0IGluIGFueSBjYXNlIHdlIHNo b3VsZCBvbmx5IGFkZCBvbmUgcGFpciBoZXJlIGZvciBzdXJlLCBhcyB5b3Ugc2F5IHRoZQ0KPiA+ IG9ubHkgaW1wbGljYXRpb24gaXMgdG8gYWRkIGEgY291cGxlIG9mIDAgaW4gdGhlIHdvcnN0IGNh c2UuDQo+IEkgYWdyZWUuIFRoZSBvbmx5IGRyYXdiYWNrIGlzIHRoZSBuZWVkIHRvIG1vZGlmeSB0 aGUgYWxyZWFkeSBpbnRyb2R1Y2VkDQo+IHByb3BlcnRpZXMNCj4gdG8gYmUgY29oZXJlbnQuDQoN CllvdSBtZWFuIHRoZSAjeGVuLHN0YXRpYy1tZW0tYWRkcmVzcy9zaXplLWNlbGxzPyBJIHRoaW5r IHRoaXMgaXMgdGhlIG9ubHkgb25lDQpleGlzdGluZy4gSSBjYW4gYWRkIGFub3RoZXIgcHJlcmVx dWlzaXRlIHBhdGNoIGluIG15IHNlcmllcyBhZnRlciB3ZSByZWFjaCBhbg0KYWdyZWVtZW50Lg0K DQpLaW5kIHJlZ2FyZHMsDQpIZW5yeSANCg0KPiANCj4gPg0KPiA+IENoZWVycw0KPiA+IEJlcnRy YW5kDQo+ID4NCj4gPj4NCj4gPj4+DQo+ID4+PiBDaGVlcnMsDQo+ID4+Pg0KPiA+Pj4gLS0NCj4g Pj4+IEp1bGllbiBHcmFsbA0KPiA+DQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:37:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:37:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401758.643678 (Exim 4.92) (envelope-from ) id 1oVvFW-00046U-Jc; Wed, 07 Sep 2022 13:37:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401758.643678; Wed, 07 Sep 2022 13:37:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvFW-00046N-Gi; Wed, 07 Sep 2022 13:37:50 +0000 Received: by outflank-mailman (input) for mailman id 401758; Wed, 07 Sep 2022 13:37:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvFV-00046H-EO for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:37:49 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2064.outbound.protection.outlook.com [40.107.101.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42105a0a-2eb2-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:37:47 +0200 (CEST) Received: from DS7PR05CA0059.namprd05.prod.outlook.com (2603:10b6:8:2f::32) by MW6PR12MB7069.namprd12.prod.outlook.com (2603:10b6:303:238::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Wed, 7 Sep 2022 13:37:44 +0000 Received: from DM6NAM11FT109.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::cf) by DS7PR05CA0059.outlook.office365.com (2603:10b6:8:2f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Wed, 7 Sep 2022 13:37:43 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT109.mail.protection.outlook.com (10.13.173.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:37:43 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 08:37:42 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 7 Sep 2022 08:37:42 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 7 Sep 2022 08:37:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42105a0a-2eb2-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iNjED6kMNdRzubJc9Nkh5+bGxkgyvMK+ITT2gbS0YoXdroYd46Tx++lrZscpG4c+6OrUHCwRAFmUFu9wPMch9IUs611sR0r4lpl3odZfi15px0TU+xqrN+iGKmyZsul67F6eCBGnmYhv9mDgumVReqeU4GQdgAFqIXJNpBLXvijvY29tgcNWbI/Q54jl6d5KnpXb0hMx1495quA/iBAPdSYpD+C1wcWFJ/znwnSM5IBAtSe7zyzhwSD5XxMEXsnlyQ1Th+JtAPNh8Yv84TjfwP+iY5//d2M+7xgKi8Mosxi4VKkt4aAkQ2q8Fj2Evj6sqeDI8mwzWljldPrwmj/BiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wKt/ro4LQduWIlKU7u3xuKX22MO5PIyhIGQkhWOQHOc=; b=fcbk5+INVwSE8lLtsM3m0vCr2FTQflxONuHY335CLhnHH3BmmS6b5bNq8UuwZUEmz45vuv5BcdhMMCcIdoICsYQWouEGv95be0UEQ4QOTtaEkh9CMJyLOaiLola5CEZ18yjbEjo4/NmT67PrRhPnHmRCeXeSWCBQr0QMK4ooigha5bCmcyEFrSSCbBb2YABELw5Cap58osMadFYI/rQhIePPe+RkGXKqXUsa84WKxfdXunXPuq8usCOPCqbaoOPDX1dp78ZtLiEQPC/hMMBkEO5gxF+VBcTgN/fp8nxWlm9bKVsEQlgd6vwuoxTD+JQhqKSUqWyWhhIsquaooxOZNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKt/ro4LQduWIlKU7u3xuKX22MO5PIyhIGQkhWOQHOc=; b=cPlpHbb1IFGheZFva490L90g43MTTK5JAdzvbwjM07IDzlIsY+dEMdbk0IWQlUJ1m+0/fodvXmrsCK2ZpPRwFtIqSuVRjN5UH6xg4wFSHWWy2PBZMMEC1oDqJTPe3wUDeVs1hkXLbv/IpPcuZkqUZUux7AURNeFfjExmb2Pv4vc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Wed, 7 Sep 2022 15:37:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Bertrand Marquis CC: Julien Grall , Henry Wang , "xen-devel@lists.xenproject.org" , "Stefano Stabellini" , Wei Chen , "Volodymyr Babchuk" , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> From: Michal Orzel In-Reply-To: <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT109:EE_|MW6PR12MB7069:EE_ X-MS-Office365-Filtering-Correlation-Id: da3a4d8c-5a1d-481e-fdf7-08da90d624a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tTu4yXSy52cZ/N6BmbjayezJuEga9Iqm+EXTmIgm4YQbUHJBKLBr+tZyUYaRnKEABgd+6CbssSnzd+7EwJikrwXHNU5HEYTxsjr6oflvyoB7OPJPNkLVi80M7NdQTm/qBB57XZOdgS0Z3jU6ajD/XqRChA/hIYpM8pIcTEwHjgK5tTT3uh6nR3/VOHS7zKEnPvGyybSsNmbX4rvMHbTd3FeyGgjMhqEsCs94QaYI2CapX+QOrp6y8jrdG1n+XfSk/TBgdElGFnoRMc6tD2Gru+1p+kUPIr57eBMu8a8zsTPzPPRf0lOhkAZR4ztGG9+PgoZkx5kXb+U3wOPtmc6Dn3St9Hii85LH8rf7ko2sSHJkAdimGRqrL0EzPKp4iP1ZoNzfooFY9dh/jTNS8E09ilPTniQ0CXCqPHmH47MWf6uqVeSjS/OEOvOo/cAIkwYdgkayXrfHuhjq5ujRbDW3TJDpNG/vwLnVY/RvqeC89/e4LZ4LrT39ts+dD4FWqdEdtDttHFnitRQ/PbdsHUZtFHO+0QT4XC6e9iB7UkfG0x6XHydAxzm6OzPXhyhaAKo53jnVhMLh3zlmYBTirQga5kGIcwoM4ikmeL2OzWkmCRBc74GS4nhR1JWcyZOg+B6vvx70jTSots75v7UEDQvM7Zuw3nxAr+dkpTWfQNTx20mYYY7RN/mTN2rVwkCkqMhESnSL7Bmk4MMxzKYi0NQ61r1ucg0GqAn9HF9czLnpKaXPcFMZNt1Uc702umfQ3SsBDDmRGYYL/pCA5ggbHlYs1jXtaqgpARYIf13zYjQ1AOlgajBnjZaGXED6g0Ri00K7ky5VEUFph8aqtmTDvrddmBgafOUS0NHjxfQqXe0J92w= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(346002)(376002)(40470700004)(46966006)(36840700001)(41300700001)(5660300002)(53546011)(26005)(478600001)(31696002)(40460700003)(44832011)(2906002)(86362001)(8936002)(356005)(40480700001)(82740400003)(36860700001)(47076005)(186003)(2616005)(426003)(336012)(83380400001)(6916009)(81166007)(4326008)(8676002)(31686004)(45080400002)(54906003)(70206006)(82310400005)(16576012)(966005)(70586007)(36756003)(316002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:37:43.5349 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: da3a4d8c-5a1d-481e-fdf7-08da90d624a3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT109.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7069 On 07/09/2022 15:33, Bertrand Marquis wrote: > >> On 7 Sep 2022, at 14:31, Michal Orzel wrote: >> >> >> >> On 07/09/2022 15:28, Bertrand Marquis wrote: >>> >>> Hi Michal, >>> >>>> On 7 Sep 2022, at 14:09, Michal Orzel wrote: >>>> >>>> >>>> On 07/09/2022 14:45, Julien Grall wrote: >>>>> >>>>> On 07/09/2022 13:41, Michal Orzel wrote: >>>>>> >>>>>> >>>>>> On 07/09/2022 14:32, Julien Grall wrote: >>>>>>> [CAUTION: External Email] >>>>>>> >>>>>>> On 07/09/2022 13:12, Michal Orzel wrote: >>>>>>>> Hi Julien, >>>>>>> >>>>>>> Hi Michal, >>>>>>> >>>>>>>> On 07/09/2022 13:36, Julien Grall wrote: >>>>>>>>> >>>>>>>>> Hi Henry, >>>>>>>>> >>>>>>>>> While reviewing the binding sent by Penny I noticed some inconsistency >>>>>>>>> with the one you introduced. See below. >>>>>>>>> >>>>>>>>> On 07/09/2022 09:36, Henry Wang wrote: >>>>>>>>>> +- xen,static-heap >>>>>>>>>> + >>>>>>>>>> + Property under the top-level "chosen" node. It specifies the address >>>>>>>>>> + and size of Xen static heap memory. Note that at least a 64KB >>>>>>>>>> + alignment is required. >>>>>>>>>> + >>>>>>>>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells >>>>>>>>>> + >>>>>>>>>> + Specify the number of cells used for the address and size of the >>>>>>>>>> + "xen,static-heap" property under "chosen". >>>>>>>>>> + >>>>>>>>>> +Below is an example on how to specify the static heap in device tree: >>>>>>>>>> + >>>>>>>>>> + / { >>>>>>>>>> + chosen { >>>>>>>>>> + #xen,static-heap-address-cells = <0x2>; >>>>>>>>>> + #xen,static-heap-size-cells = <0x2>; >>>>>>>>> >>>>>>>>> Your binding, is introduce #xen,static-heap-{address, size}-cells >>>>>>>>> whereas Penny's one is using #{address, size}-cells even if the property >>>>>>>>> is not "reg". >>>>>>>>> >>>>>>>>> I would like some consistency in the way we define bindings. Looking at >>>>>>>>> the tree, we already seem to have introduced >>>>>>>>> #xen-static-mem-address-cells. So maybe we should follow your approach? >>>>>>>>> >>>>>>>>> That said, I am wondering whether we should just use one set of property >>>>>>>>> name. >>>>>>>>> >>>>>>>>> I am open to suggestion here. My only request is we are consistent (i.e. >>>>>>>>> this doesn't depend on who wrote the bindings). >>>>>>>>> >>>>>>>> In my opinion we should follow the device tree specification which states >>>>>>>> that the #address-cells and #size-cells correspond to the reg property. >>>>>>> >>>>>>> Hmmm.... Looking at [1], the two properties are not exclusive to 'reg' >>>>>>> Furthermore, I am not aware of any restriction for us to re-use them. Do >>>>>>> you have a pointer? >>>>>> >>>>>> As we are discussing re-usage of #address-cells and #size-cells for custom properties that are not "reg", >>>>>> I took this info from the latest device tree specs found under https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.devicetree.org%2Fspecifications%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cc677a7983cd94e48620708da90d5a15f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637981544487489692%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1uwtf%2F6shf2PiKu0XZPFNQ%2B6iyhLrMsYb1XEru3IGlg%3D&reserved=0: >>>>>> "The #address-cells property defines the number of cells used to encode the address field in a child node's reg property" >>>>>> and >>>>>> "The #size-cells property defines the number of cells used to encode the size field in a child node’s reg property" >>>>> >>>>> Right. But there is nothing in the wording suggesting that >>>>> #address-cells and #size-cells can't be re-used. From [1], it is clear >>>>> that the meaning has changed. >>>>> >>>>> So why can't we do the same? >>>> I think this is a matter of how someone reads these sentences. >>>> I do not think that such documents need to state: >>>> "This property is for the reg. Do not use it for other purposes." >>>> The first part of the sentence is enough to inform what is supported. >>>> >>>> On the other hand, looking at [1] these properties got new purposes >>>> so I think we could do the same. Now the question is whether we want that. >>>> I think it is doable to just have a single pair of #address/#size properties. >>>> For instance xen,shared-mem requiring just 0x1 for address/size >>>> and reg requiring 0x2. This would just imply putting additional 0x00. >>> >>> I think we want in general to reduce complexity when possible. >>> Here we are adding a lot of entries in the device tree where we know that >>> in all cases having only 2 will work all the time. >>> >>> I am not convinced by the arguments on not using #address-cells and will >>> leave that one to Stefano >>> >>> But in any case we should only add one pair here for sure, as you say the >>> only implication is to add a couple of 0 in the worst case. >> I agree. The only drawback is the need to modify the already introduced properties >> to be coherent. > > Agree, someone will need to do a pass on the whole doc which might be easier with all things in. > Well, not only docs. If we decide to use a single pair of #address-cells and #size-cells, then we need to modify the code that expects different properties e.g. xen,static-mem-{address/size}-cells. > Cheers > Bertrand > >> >>> >>> Cheers >>> Bertrand >>> >>>> >>>>> >>>>> Cheers, >>>>> >>>>> -- >>>>> Julien Grall > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:41:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:41:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401765.643688 (Exim 4.92) (envelope-from ) id 1oVvIl-0005Xz-3c; Wed, 07 Sep 2022 13:41:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401765.643688; Wed, 07 Sep 2022 13:41:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvIl-0005Xs-0z; Wed, 07 Sep 2022 13:41:11 +0000 Received: by outflank-mailman (input) for mailman id 401765; Wed, 07 Sep 2022 13:41:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvIk-0005Xm-KC for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:41:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvIk-0006eH-AF; Wed, 07 Sep 2022 13:41:10 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVvIk-0004A4-4I; Wed, 07 Sep 2022 13:41:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6gbPZH0blVXoKVhcqmYuhV+vGAr46JMlx52ns7im1jI=; b=QeHA9NBta26QyHQegCBW3+rIf0 qgjs/A55D0C3T388iEX4Ns5JcVQt9CfwOVK/HrJ3DIY8zRbhUnH9Hj82P59cIeQ9kZjewsPWJiGLQ 5VJdYgXchKe+SvSVLxy389iOgeuBCr+TB2W70Y6fjtlC67TY03/+kSUCXqC0Nsyv21Gs=; Message-ID: Date: Wed, 7 Sep 2022 14:41:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-8-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220906085941.944592-8-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/09/2022 09:59, Penny Zheng wrote: > We expose the shared memory to the domU using the "xen,shared-memory-v1" > reserved-memory binding. See > Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt > in Linux for the corresponding device tree binding. > > To save the cost of re-parsing shared memory device tree configuration when > creating shared memory nodes in guest device tree, this commit adds new field > "shm_mem" to store shm-info per domain. > > For each shared memory region, a range is exposed under > the /reserved-memory node as a child node. Each range sub-node is > named xen-shmem@
and has the following properties: > - compatible: > compatible = "xen,shared-memory-v1" > - reg: > the base guest physical address and size of the shared memory region > - xen,id: > a string that identifies the shared memory region. So technically, there is a property "xen,offset" that should be specified for the borrowers. TBH, I don't quite understand what this property is used for. So it is not quite clear why this is skipped. The Stefano is the author of the binding. So maybe he can explain the purpose of the property and help to document it in the commit message why this is ignored. > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index d0ff487cc6..3b7436030e 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -914,7 +914,22 @@ static int __init assign_shared_memory(struct domain *d, > return ret; > } > > -static int __init process_shm(struct domain *d, > +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > + paddr_t start, paddr_t size, > + const char *shm_id) > +{ > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) NIT: The +1 could be avoided if you use >=. This would also avoid to think about the overflow case for nr_banks :). > + return -ENOMEM; > + > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); > + kinfo->shm_mem.nr_banks++; > + > + return 0; > +} > + > +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > const struct dt_device_node *node) > { > struct dt_device_node *shm_node; > @@ -928,6 +943,7 @@ static int __init process_shm(struct domain *d, > int ret = 0; > unsigned int i; > const char *role_str; > + const char *shm_id; > bool owner_dom_io = true; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > @@ -972,6 +988,9 @@ static int __init process_shm(struct domain *d, > if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) > owner_dom_io = false; > > + dt_property_read_string(shm_node, "xen,shm-id", &shm_id); shm_id will only be set if dt_property_read_string() returns 0. Otherwise it will be unknown. Given... > + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); ... this BUG_ON(), I assuming you want to double check that the property is correct. So you want to also check the return value. Otherwise, I suspect a static analyzer will complain that you may use unitialized value. [...] > +static int __init make_resv_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) AFAICT 'mem' could be const. > +{ > + int res = 0; > + /* Placeholder for reserved-memory\0 */ > + char resvbuf[16] = "reserved-memory"; Same here. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:44:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:44:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401774.643700 (Exim 4.92) (envelope-from ) id 1oVvMG-0006Lo-OA; Wed, 07 Sep 2022 13:44:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401774.643700; Wed, 07 Sep 2022 13:44:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvMG-0006Lh-Jl; Wed, 07 Sep 2022 13:44:48 +0000 Received: by outflank-mailman (input) for mailman id 401774; Wed, 07 Sep 2022 13:44:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvMF-0006Lb-Cc for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:44:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b20ce16-2eb3-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:44:45 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4F50618F6; Wed, 7 Sep 2022 13:44:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E8F1C433C1; Wed, 7 Sep 2022 13:44:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b20ce16-2eb3-11ed-a016-b9edf5238543 Date: Wed, 7 Sep 2022 09:45:18 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Michal Hocko , Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220907094306.3383dac2@gandalf.local.home> In-Reply-To: <20220907130323.rwycrntnckc6h43n@kmo-framework> References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 7 Sep 2022 09:04:28 -0400 Kent Overstreet wrote: > On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > > Hmm, it seems that further discussion doesn't really make much sense > > here. I know how to use my time better. > > Just a thought, but I generally find it more productive to propose ideas than to > just be disparaging. > But it's not Michal's job to do so. He's just telling you that the given feature is not worth the burden. He's telling you the issues that he has with the patch set. It's the submitter's job to address those concerns and not the maintainer's to tell you how to make it better. When Linus tells us that a submission is crap, we don't ask him how to make it less crap, we listen to why he called it crap, and then rewrite to be not so crappy. If we cannot figure it out, it doesn't get in. -- Steve From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:45:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401775.643710 (Exim 4.92) (envelope-from ) id 1oVvMV-0006hV-Um; Wed, 07 Sep 2022 13:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401775.643710; Wed, 07 Sep 2022 13:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvMV-0006hO-RR; Wed, 07 Sep 2022 13:45:03 +0000 Received: by outflank-mailman (input) for mailman id 401775; Wed, 07 Sep 2022 13:45:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvMU-0006gr-PE for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:45:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4534bfd5-2eb3-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 15:45:01 +0200 (CEST) Received: from DUZPR01CA0034.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::10) by DB9PR08MB6569.eurprd08.prod.outlook.com (2603:10a6:10:261::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 13:44:59 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:468:cafe::27) by DUZPR01CA0034.outlook.office365.com (2603:10a6:10:468::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 13:44:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:44:59 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 07 Sep 2022 13:44:59 +0000 Received: from 06637736a112.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A338F6EB-4549-4AB7-8BDA-83692F364561.1; Wed, 07 Sep 2022 13:44:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 06637736a112.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:44:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM9PR08MB6226.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 13:44:45 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:44:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4534bfd5-2eb3-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NGZiZQqbzkPrNT/ey0eOJkZyQ5ZNK+Z2kyAzbZzAQ2EsnmbgW9IQo8TkffV0VrW2POUGHXX6Bc+HPKlOznItH0Fx6nHe50g/Ggc5xucdNV0A5zP+/CoXpZG48TkwfQHOu7CbIMtmTBgR47PLEhX5MdkAy02L/DBcYnCqK28bCUrOetiOAMNKZwAmO8KIhi6OWVVUjHX5dh9/dHMf9LJrCsFKCC2NTkIb9Xt9Yb3amNNLg5QZ/nFINwwoRKtdIjm2k3Yh64Obb4CpSw622sswksk7pdCW+xKyl5kXm/g5OXnZuLkguyj3LeOOT7f/Jecska5c2O7IlKXHeFTpnYwd4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7j25tiPsdsXNHomxeLxXo9OlsoEPikY86vTAHnwE+4E=; b=bfUi/xdyPn1RoJk3i0/Hb/WqdXtbNIeGpNs5F30d0VlMfPyfYnWqXngt3b9BTOSUAXIJ5X7yWjic+3GDZF3M9i9JDwVlY46loXs6h2aCKTimgW5JJqdJ4lKJCfU7I1zy+9J5SNIxrbigwA52JwLReBElHnil3oYNh2TZRfuTe8Ek5LG0dBF9kEggoyF/gnjH3cfOJVvoqdRO5NCvjrmM6K92XUGqfKHd1jGscLDCdLmVgxOjB05Nkdp2BS6SfwQjHVHY7X1VoyyGWKW3OMKC8XPBBw+u5tdWpHD4Jc3aricwGY7RCKgwlFgxJosD/nYs0Eruz2v0JeolggXeeltBeA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7j25tiPsdsXNHomxeLxXo9OlsoEPikY86vTAHnwE+4E=; b=Sv/zHRwEYFEE/wUef1TX7QyQNKnS9obiTHjhDME4MDBWqYDZuQN2X36ZMOJ/yOpR9PfcqdvwW9VVO5WoE3m0n1qAWv7anXkmUGTELiSsEF1fDx4+qxu31v6PJJxviii57fw6z+BsfyYz7FI1oWDv4Qu4tDuiMMgUEQphBdjS1RU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7ab872eb452a960b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4Xfjq6PqzNudr6Jid9cGs6/Yqv+IZN7EMUXjEbpOUhpvl7i+rfKHjSKsNgqFQ0K/0MjDiejEfdLd/z23WKM8520vm1XumfSBBUt7HOj/7RBYu+AgbwhDXviL9VMU6SLz4fv67W3QZnL3MS63L0kQLjKQRvswKmNFgbYiAVl2Wa6kxd7h6Gcn7TpO8xeF4b26oGKVPukyC0mIwQx2VQwF0+9r+C3t4WhAlxZGPq6nur0r6n6Byc8cDUYZq/Elq1yTNEWG0wi4gJUTkRysNrKZYqn+PV08RHz6z5ilMfvKiAwm6NkpQ6lYYwq+zxQkmEHO3acbv+fTYCPlAZKtr9IiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7j25tiPsdsXNHomxeLxXo9OlsoEPikY86vTAHnwE+4E=; b=X+24RWPu2T4PBiDbYPFvyIP5Ocbd1nVE4CoSEYPoBIAfjOq3o2RLv23yjn6voDJ1NsTSGJ+dzWxUXZ8XTSC9JhQSKwrnOn3CDkt3p7XGEeam6driyuuC+4F66lhRCHYJLq60Iiv6fn7NffTnj+LEmx7CICwBD1BNcXWmbexB5B/wbcNLRueUMOMEtXPG0a+vQOTyHuEuAd9VFaooBJdZl1o90t3IyiEUj00DJM2gdrLhRAk02lsBShKuZq7OHB/WDkiYAD7PH3h5n3Q/i143Yw0rp/KuUA8wkP9PqDUEEcEb5SdrH2VLGfqb59DfsOwVdzL9EfkffVOdikBJ0is8ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7j25tiPsdsXNHomxeLxXo9OlsoEPikY86vTAHnwE+4E=; b=Sv/zHRwEYFEE/wUef1TX7QyQNKnS9obiTHjhDME4MDBWqYDZuQN2X36ZMOJ/yOpR9PfcqdvwW9VVO5WoE3m0n1qAWv7anXkmUGTELiSsEF1fDx4+qxu31v6PJJxviii57fw6z+BsfyYz7FI1oWDv4Qu4tDuiMMgUEQphBdjS1RU= From: Bertrand Marquis To: Henry Wang CC: Michal Orzel , Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAD+gIAAApQA Date: Wed, 7 Sep 2022 13:44:45 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 96bb898b-07ef-4f6e-c2bf-08da90d7282f x-ms-traffictypediagnostic: AM9PR08MB6226:EE_|DBAEUR03FT023:EE_|DB9PR08MB6569:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tAd14XOzCswLaoGcCFVEsSd7KNGszTCmrdgRY2NZZx6lOlKl28uVRn5q1l6p1bCZgc+JaE0IyK7st+GZOL5WCUHtbjpJ2ACN1uyN1Qy2upGI/70hB5KpfKHKwOkfcI3L3zj5HHTs+VfzMwjY5JqxKr8Oss6fx5yGmlqepXpRiVxuCldrSmDmUc1utgXNQQB13hyA0DVJ/jNhA65B1SlxECxEBfSsAz/InbN6a5gby6/Oa21I3YPn53ZtKorfpZfOfD2teXw8hfelS3wSn0uQ+DFMdN595bRxlzMcO9e5kCSOqQjm2P1XRwyroNK0en3jC5IxBCdcPVH0TTaxeuS80bZw6MaQe3RmB+cYc8jm7DycLHMTMvKK5hXR0RWOhBH0XIi4K15fYeuc4Y4vAhzLwl8/zz29cUrUuxm6JVT3JKFPKjfk9mrpoXsEBxEcH9je3w5LLrdlG5RSWoVo3YqVg2Us2UyQrBtP8KRvICaagVa8GhR80BxN8EnvfyGsu5H2FOsgHe0M0iAL2SNn3EISw/1qa43io+xXNrcBWzjI32bzyZgCuiIc8JSG175Q3VcJn5ZE3l9l/OyNrlEVgwb9oyBM407YuhXmIM1omJTwsAhxqYue8BeCDMzsII/KUk+2Bv5P+SVELYayN3qoM4uoWjhE3N4qoOJX7IIJMRJrMjwTqsnB2NhxQpmwuLL2hCkvjfsMITKOZ5D6xI/SAMb55knypIvNutAdUvf+u3DH5RPbPtovMGtJMJwdt1CeixdBbPkkxUQX+EoCKpHOa3xiFraclEMz1ASVETlnBTgJvt0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(39860400002)(366004)(136003)(36756003)(6512007)(37006003)(316002)(54906003)(6636002)(38100700002)(4744005)(122000001)(38070700005)(2906002)(33656002)(66556008)(5660300002)(6862004)(83380400001)(86362001)(66446008)(8676002)(76116006)(91956017)(8936002)(66946007)(64756008)(71200400001)(6486002)(41300700001)(4326008)(2616005)(66476007)(186003)(6506007)(53546011)(26005)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <06B458A772DB284DA8DA3E6949088D37@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6226 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1680d3e0-5916-49f7-4d5f-08da90d71fc9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bpeCA/dsrmqUWc0dYvmQwVzhPPBCVWoFqOuInK7/8VcTV+ERsVoINwP9IWjq4cQpAd6IcfPJv4QtdNXpHaHW4iSw2aaDAlMcFYCo3i7s8EVIyxvcYelE6w161C0C7tHLnWpgULZS5GGIHHdmFKc6rA7aj72/oyLsFMh876H270X04nDfGuvBqodLpEgvnskOzjTtNUG21GpQcrZp/w+h8wgHZe214+Zn2H9vqcTTQg0VxkOTUc/aYBxkiO1ktOsrRIu/EI4s4tl4toDBs5xg/P+Bu23M63GK2fs2XLgvZV4/nR/VwULV9T9u4TUpU44wlAMKB4McsGVFr7Z8fdQmLTRIA7TDkghL3qEe9Msr0XaXUO1gekHEEdkyVWv3/Ij4MBjZ96Oi3us65JIwS/+0zvQLwfdbU9kDBpVvgxS1KLsZll7hVTIEM6140xMzHGTBZbYXNTgp9lXGtVjaPRXlvJC0KZx8bIvFOP3tC404kkFQqaaJOnF78migwmD9S+PKL+qiAPvAOng9XUPpcBM+EquOpKXroAfI0t80l+b5YYjKN1gnwiYW5Xxirflola/7CNge1fLQOqA0IEPxLY0OGiJ0bQOurZkIcSP9lRpjs5o6eot1gzyG6qoLljnpuB3yO+8Pbc+8hCTtV7II9iBKP2q5CY9MYV337jq47e32lbACfOQLYSCA9zapTUV7OyqWhL88Ay8WfkHp3K3vZ8NgRCuKHOpb8r7cf51GJaKxId1ceE0oM0lEUL2bFkyo62fH5HRYJk0coh73X/dqS/RBUg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(39860400002)(396003)(36840700001)(40470700004)(46966006)(47076005)(186003)(6486002)(356005)(81166007)(82310400005)(36860700001)(336012)(54906003)(37006003)(6636002)(36756003)(478600001)(83380400001)(4326008)(316002)(8676002)(70586007)(70206006)(2906002)(53546011)(6512007)(26005)(40460700003)(6862004)(8936002)(5660300002)(41300700001)(33656002)(2616005)(4744005)(6506007)(86362001)(40480700001)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:44:59.2777 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 96bb898b-07ef-4f6e-c2bf-08da90d7282f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6569 Hi Henry, > On 7 Sep 2022, at 14:35, Henry Wang wrote: >=20 > Hi Michal, >=20 >> -----Original Message----- >> From: Michal Orzel >>> I am not convinced by the arguments on not using #address-cells and wil= l >>> leave that one to Stefano >>>=20 >>> But in any case we should only add one pair here for sure, as you say t= he >>> only implication is to add a couple of 0 in the worst case. >> I agree. The only drawback is the need to modify the already introduced >> properties >> to be coherent. >=20 > You mean the #xen,static-mem-address/size-cells? I think this is the only= one > existing. I can add another prerequisite patch in my series after we reac= h an > agreement. No the standard device tree ones: #address-cells #size-cells Those have a default value if unspecified. Bertrand >=20 > Kind regards, > Henry >=20 >>=20 >>>=20 >>> Cheers >>> Bertrand >>>=20 >>>>=20 >>>>>=20 >>>>> Cheers, >>>>>=20 >>>>> -- >>>>> Julien Grall >>>=20 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:45:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:45:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401788.643722 (Exim 4.92) (envelope-from ) id 1oVvNI-0007R7-8t; Wed, 07 Sep 2022 13:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401788.643722; Wed, 07 Sep 2022 13:45:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvNI-0007R0-4U; Wed, 07 Sep 2022 13:45:52 +0000 Received: by outflank-mailman (input) for mailman id 401788; Wed, 07 Sep 2022 13:45:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvNG-0007Qd-Et for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:45:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61c772fa-2eb3-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:45:49 +0200 (CEST) Received: from DB8PR09CA0033.eurprd09.prod.outlook.com (2603:10a6:10:a0::46) by DU0PR08MB9510.eurprd08.prod.outlook.com (2603:10a6:10:44e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 13:45:45 +0000 Received: from DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::b2) by DB8PR09CA0033.outlook.office365.com (2603:10a6:10:a0::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 13:45:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT065.mail.protection.outlook.com (100.127.142.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:45:45 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 07 Sep 2022 13:45:45 +0000 Received: from 8907261c5424.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A530EC52-B7A8-4573-BDEA-0E477679BC96.1; Wed, 07 Sep 2022 13:45:34 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8907261c5424.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:45:34 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAVPR08MB9529.eurprd08.prod.outlook.com (2603:10a6:102:315::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Wed, 7 Sep 2022 13:45:32 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:45:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61c772fa-2eb3-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OZjV2yfvtU45OoNNjd2lnSL7KdWiLM6GEJ86macBmDJpsElzsGcV/17iRX7mFDjuFQb1/VNh7e7ZW1B+qA6IrwGw5u1JRQ7bEzxv8bzxi7Rxp7Ey11cDEzrTrdlXTo7THKHOFadPePQuhIzK45mE4CtXGiZIKBGda0yuzUuCQ0UzkyBY1gSemS+NPPqitWeFCqoboL7zxQiMfpPYjDS07+G4a5WkryQvbUMGrqDEmDmAlS5ntvYZxleEMJ3QnlaV0cmQkYLHzw/mmJ0jSt+z9T4BByFeQYmzWC5GiQ6atIjhy0XOV3W/fJ1NE7Wfb1ZeovALDuUwVlHB9Vchcx/eyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kW8kksXgCohTQpA5fJT/sgCrHtu4S8LSud7hm/Mh7Eg=; b=XDS3DqJp8qHdBtpFH60jerYJ7Q2xU08ntHv/+TyH5ZfDKXzpi+OpJM8l1WyenRbVJjbB9RHY8sdc+S/hqajepaJJZHyR6g9/tuA+U4fka/tY56pLRk0xJlAE4m+pPzGBzMzu7H+W4RYUPJ+lpm+fizg5QQtZg+AlyUHkcwmhYFo+R9yUygd3jSSmg3Ij/87nqXXkXvjJrDs9wDKlrcGOhY/6kCCUlbMU5ZpIZGdRu4FUTe+Bjr3ZC6zA/g8osluW9GunUzewQJv0r0jOVFho/y4484/BEXr9PIC3JObUTY41lCe5snuvz8UfYgj/9X3dyk01CXIBc0ntF/ahO+pnTg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kW8kksXgCohTQpA5fJT/sgCrHtu4S8LSud7hm/Mh7Eg=; b=yll9oagnJd+Ifyr9NsKcBL8qo7qViwnuHX4xRX/BWH2BzW1MBgQiFeKx825EDrMwcxWRC3k/FsiQAnlILzuuvPL3u428Mk4wlSynr8Q/xCdtJGCjURqG8rvXu/dO3PfMjzGz89xxnHWt7auMdeoiAZD3+iZrjm0XTOD21rr5o2Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 27a45b3b1b1de54e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oA0m7JKOEmSxIRQLEQBAj5J1/8WGic28ZQC+2ixPMoZJtz714zr+emxChoGjMA1MqS7YB0EGW6uYmrQh1cirzuneNJQGaRHMYIjYjM7nDoEMr3patRkpv9OKsQ3WP2OPdO8HcdL+C2217p6B7hAle1S9ZpS4JzD4zja3eVkJsaN+pmdc7YaVFnho+gl3vn/UZvvjunqreQKCXB6hE6IYOWnVv5t9fWzUDL7Tuy/QG7jnGUSMhIpfPYR9+g0emyBcLpSvKcDxorZzC9XgKiBc7MxlbXHPWyaKg2gtNrR7ajdDTLP4ubkbkn3M8LSrQwwFYZxRehPV5nM4SPYLB0G3Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kW8kksXgCohTQpA5fJT/sgCrHtu4S8LSud7hm/Mh7Eg=; b=ApiTo+iEFZB3DAlh2y3rW4ME52vIfyAO8YU4IxjWIcLUQvKNombIN89uIQlwkbxvTB6gENyxm2HShv/wtmf8e0OYyffrMtoe6axNw1K3j1DLGZMt1akXGg5qxa3bQ4jpe+JcjkRFJpVv86Xbe7gvWtYQPc1FCaTOJ2/GxjhR5v8nzHiuzgMZiyrc/GQvm1HCKoPbkEQyK7APzODlhKAORCpIdOXmcgHsEuXhE4r29UJe4l6E9VEQzRso8IpG/5ndRhbSF1ttS+MWGZcxJm/q1usZ44fIe5YSgkXZ8BM8CqhJ6M9Yl6ANrHCwKgSYoA4TA7H8iW5xl9dwQPN7RP1h4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kW8kksXgCohTQpA5fJT/sgCrHtu4S8LSud7hm/Mh7Eg=; b=yll9oagnJd+Ifyr9NsKcBL8qo7qViwnuHX4xRX/BWH2BzW1MBgQiFeKx825EDrMwcxWRC3k/FsiQAnlILzuuvPL3u428Mk4wlSynr8Q/xCdtJGCjURqG8rvXu/dO3PfMjzGz89xxnHWt7auMdeoiAZD3+iZrjm0XTOD21rr5o2Y= From: Bertrand Marquis To: Michal Orzel CC: Julien Grall , Henry Wang , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gIAAARoAgAACMwA= Date: Wed, 7 Sep 2022 13:45:32 +0000 Message-ID: <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8de9f440-68e0-4aba-9209-08da90d743a4 x-ms-traffictypediagnostic: PAVPR08MB9529:EE_|DBAEUR03FT065:EE_|DU0PR08MB9510:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QzaRw/GdFgm7seDWdTTt1MBzq+DyrlCTvUudle/HYI6UWtO3or5eW7XPIgKVKT3tJWwNbHDrX4i4HionSXmD7/PpGUXsfi8SsEdC+CL9ojgsAPUoA6BzWm84gaG/bhNmQGWOURJeUfN+2gb8HB6R+vf30gIy3hBf7jrFjCjOPj2HEatmWtPkTOzmTRFSf9lF3WrRJT8VjG2vJ3Lzdo5xSdk7rzwD4BAE7+OfKZrnyldxyqE8ekvoosJbo8lhEbt3XWC+ATaJWFONsGo65g9SmlWSqqtoFFtqvqWaaSdpigih2JMXX5LtxYhtGXN7tMyIutUbfrzJpGQJxcdE72OFEIqoe3ipRPwL7ZC4U8FOI59gaFySHCV0WQGKX/8fJcPEMzch1hTyO9YChadDwMl6SMk3WaRf7Tl0Lv3HRafb5ox76iiIQlLjCVv4piAtsycW40JgPOu1gP9cyarBeuJPeLa50AMrueu/qk8Xp6xYKEOni3DVHiM8qjBP6jV9sZVt4IqFuBhxyeeHZL9vkJxHxDmWE8xKoTdcFuwl/Z80pBU/WJ0cm+tQYg7M2Oz+74ORXXJpASGZLK/XnZk9A2147gjK6VNKeGCak+SsO6uhJN+SzFlXVqOHyCdGSOTbwjwRjMIPSn4Jbq1EmkyKiqO8Bxe7u5kfV6KfiJhaZ+zkNtg01j733P0xzddpcLoUbJczb3am8LEmt2/PVn65K9Gbo+2mQMrZ5Ttm4hc5+3QSeJi8i/L/YovzEXPJIikGMXAw19R43vX+zfi5kIAEAl2c1RwHp6RorHwDW1ZgURh3ufs/k64l7/Zs/GHwETBT/Bsiy24D29noTIIKSVpz6I3gNA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(186003)(2616005)(6506007)(478600001)(26005)(8936002)(86362001)(6512007)(5660300002)(966005)(33656002)(36756003)(53546011)(6486002)(41300700001)(6916009)(71200400001)(38070700005)(38100700002)(66446008)(83380400001)(2906002)(66946007)(45080400002)(8676002)(64756008)(66476007)(66556008)(76116006)(122000001)(91956017)(316002)(54906003)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <56932856A2C77946AEF0B70B6EE5B77B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9529 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 00d259e9-5c9c-4d91-50a9-08da90d73bdd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yKwnlFOmVpLxj67eQMmk5luQgflMDiM1acgXhd39E55/I/7qJcbQ4SVxV8jq6HnX4ovbJKJsOP+0/NkmKsqugrVbUTiddCDZnQOHX4NzJVA5kInJU++HySpn1xROjmFVgvVEvt3tKLToJD3Ne1Sy0193ICZD4Vtgz1YO49TjL8kCAp+Em1f3kgrBDF62Qmv/oFiKZpV4Yo6nknG7Rq2f7YSpbhHdCzxFWnA05vpaUq1+7GsrhVBuY8GqnRaSk0gcepiD1nJjIT7RWGyof7S6mQ/fumugF7oWiqWzBXR4eJtSNFD2GvrwBehmnlAk7u23iCM00a5fJOle5p5oVgD/LxfOA3V4z6n0Fvj/g9vfwNunKAU0hOAfG3jKnOT8LZ6TasjVU1Yfj/eo/FYESszcfFH3rAytZNylEVtc70k+MTZIk3c3qv8GDwXjH2/udAM4DyYJzBotOAZF1IWnGwxdHqSXrxFK/k89XUH28ejO2Psb1cHf6Mf8dJs/RysDkpec7aO8zWYSG0lSNyMiqH4MYwv565mtXLuULgeEPSogf5rJM9L71scP2EQODYnnADgA6sNX74ui3qHlScIXcZDWtesUvB5ibjP0Xp87LDih+AzNOH1Pf2EjMPIVRspWf+BzoH+Uul5N+GUZc7dtFTMyF/hIBXdmayKKAKopQGWH384kH1vvJDe1vdxbjpwVUUBM2mXGhONmBTdjdTo3ftpNJvlK9vUDBx6CPB2hz0i/7oWXSsrAiSdKdCl7SUZwfcQukVgN3igyUTrY6183EURQvjZmaIRFRfgzK9Tt5yPxsFY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(346002)(136003)(46966006)(36840700001)(40470700004)(2616005)(26005)(45080400002)(70206006)(6506007)(356005)(53546011)(2906002)(6512007)(81166007)(41300700001)(5660300002)(336012)(47076005)(36756003)(186003)(478600001)(6862004)(8676002)(8936002)(4326008)(6486002)(83380400001)(40460700003)(33656002)(966005)(36860700001)(54906003)(40480700001)(82740400003)(316002)(86362001)(70586007)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:45:45.3417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8de9f440-68e0-4aba-9209-08da90d743a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9510 SGksDQoNCj4gT24gNyBTZXAgMjAyMiwgYXQgMTQ6MzcsIE1pY2hhbCBPcnplbCA8bWljaGFsLm9y emVsQGFtZC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDE1OjMzLCBC ZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gDQo+Pj4gT24gNyBTZXAgMjAyMiwgYXQgMTQ6MzEs IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IA0K Pj4+IA0KPj4+IE9uIDA3LzA5LzIwMjIgMTU6MjgsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+ Pj4+IA0KPj4+PiBIaSBNaWNoYWwsDQo+Pj4+IA0KPj4+Pj4gT24gNyBTZXAgMjAyMiwgYXQgMTQ6 MDksIE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+IHdyb3RlOg0KPj4+Pj4gDQo+ Pj4+PiANCj4+Pj4+IE9uIDA3LzA5LzIwMjIgMTQ6NDUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+ Pj4+PiANCj4+Pj4+PiBPbiAwNy8wOS8yMDIyIDEzOjQxLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+ Pj4+Pj4+IA0KPj4+Pj4+PiANCj4+Pj4+Pj4gT24gMDcvMDkvMjAyMiAxNDozMiwgSnVsaWVuIEdy YWxsIHdyb3RlOg0KPj4+Pj4+Pj4gW0NBVVRJT046IEV4dGVybmFsIEVtYWlsXQ0KPj4+Pj4+Pj4g DQo+Pj4+Pj4+PiBPbiAwNy8wOS8yMDIyIDEzOjEyLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+Pj4+ Pj4+Pj4gSGkgSnVsaWVuLA0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBIaSBNaWNoYWwsDQo+Pj4+Pj4+ PiANCj4+Pj4+Pj4+PiBPbiAwNy8wOS8yMDIyIDEzOjM2LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+ Pj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+PiBIaSBIZW5yeSwNCj4+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4+ IFdoaWxlIHJldmlld2luZyB0aGUgYmluZGluZyBzZW50IGJ5IFBlbm55IEkgbm90aWNlZCBzb21l IGluY29uc2lzdGVuY3kNCj4+Pj4+Pj4+Pj4gd2l0aCB0aGUgb25lIHlvdSBpbnRyb2R1Y2VkLiBT ZWUgYmVsb3cuDQo+Pj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+PiBPbiAwNy8wOS8yMDIyIDA5OjM2LCBI ZW5yeSBXYW5nIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4gKy0geGVuLHN0YXRpYy1oZWFwDQo+Pj4+Pj4+ Pj4+PiArDQo+Pj4+Pj4+Pj4+PiArICAgIFByb3BlcnR5IHVuZGVyIHRoZSB0b3AtbGV2ZWwgImNo b3NlbiIgbm9kZS4gSXQgc3BlY2lmaWVzIHRoZSBhZGRyZXNzDQo+Pj4+Pj4+Pj4+PiArICAgIGFu ZCBzaXplIG9mIFhlbiBzdGF0aWMgaGVhcCBtZW1vcnkuIE5vdGUgdGhhdCBhdCBsZWFzdCBhIDY0 S0INCj4+Pj4+Pj4+Pj4+ICsgICAgYWxpZ25tZW50IGlzIHJlcXVpcmVkLg0KPj4+Pj4+Pj4+Pj4g Kw0KPj4+Pj4+Pj4+Pj4gKy0gI3hlbixzdGF0aWMtaGVhcC1hZGRyZXNzLWNlbGxzIGFuZCAjeGVu LHN0YXRpYy1oZWFwLXNpemUtY2VsbHMNCj4+Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4+ICsgICAg U3BlY2lmeSB0aGUgbnVtYmVyIG9mIGNlbGxzIHVzZWQgZm9yIHRoZSBhZGRyZXNzIGFuZCBzaXpl IG9mIHRoZQ0KPj4+Pj4+Pj4+Pj4gKyAgICAieGVuLHN0YXRpYy1oZWFwIiBwcm9wZXJ0eSB1bmRl ciAiY2hvc2VuIi4NCj4+Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4+ICtCZWxvdyBpcyBhbiBleGFt cGxlIG9uIGhvdyB0byBzcGVjaWZ5IHRoZSBzdGF0aWMgaGVhcCBpbiBkZXZpY2UgdHJlZToNCj4+ Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4+ICsgICAgLyB7DQo+Pj4+Pj4+Pj4+PiArICAgICAgICBj aG9zZW4gew0KPj4+Pj4+Pj4+Pj4gKyAgICAgICAgICAgICN4ZW4sc3RhdGljLWhlYXAtYWRkcmVz cy1jZWxscyA9IDwweDI+Ow0KPj4+Pj4+Pj4+Pj4gKyAgICAgICAgICAgICN4ZW4sc3RhdGljLWhl YXAtc2l6ZS1jZWxscyA9IDwweDI+Ow0KPj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+Pj4gWW91ciBiaW5k aW5nLCBpcyBpbnRyb2R1Y2UgI3hlbixzdGF0aWMtaGVhcC17YWRkcmVzcywgc2l6ZX0tY2VsbHMN Cj4+Pj4+Pj4+Pj4gd2hlcmVhcyBQZW5ueSdzIG9uZSBpcyB1c2luZyAje2FkZHJlc3MsIHNpemV9 LWNlbGxzIGV2ZW4gaWYgdGhlIHByb3BlcnR5DQo+Pj4+Pj4+Pj4+IGlzIG5vdCAicmVnIi4NCj4+ Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4+IEkgd291bGQgbGlrZSBzb21lIGNvbnNpc3RlbmN5IGluIHRo ZSB3YXkgd2UgZGVmaW5lIGJpbmRpbmdzLiBMb29raW5nIGF0DQo+Pj4+Pj4+Pj4+IHRoZSB0cmVl LCB3ZSBhbHJlYWR5IHNlZW0gdG8gaGF2ZSBpbnRyb2R1Y2VkDQo+Pj4+Pj4+Pj4+ICN4ZW4tc3Rh dGljLW1lbS1hZGRyZXNzLWNlbGxzLiBTbyBtYXliZSB3ZSBzaG91bGQgZm9sbG93IHlvdXIgYXBw cm9hY2g/DQo+Pj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+PiBUaGF0IHNhaWQsIEkgYW0gd29uZGVyaW5n IHdoZXRoZXIgd2Ugc2hvdWxkIGp1c3QgdXNlIG9uZSBzZXQgb2YgcHJvcGVydHkNCj4+Pj4+Pj4+ Pj4gbmFtZS4NCj4+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4+IEkgYW0gb3BlbiB0byBzdWdnZXN0aW9u IGhlcmUuIE15IG9ubHkgcmVxdWVzdCBpcyB3ZSBhcmUgY29uc2lzdGVudCAoaS5lLg0KPj4+Pj4+ Pj4+PiB0aGlzIGRvZXNuJ3QgZGVwZW5kIG9uIHdobyB3cm90ZSB0aGUgYmluZGluZ3MpLg0KPj4+ Pj4+Pj4+PiANCj4+Pj4+Pj4+PiBJbiBteSBvcGluaW9uIHdlIHNob3VsZCBmb2xsb3cgdGhlIGRl dmljZSB0cmVlIHNwZWNpZmljYXRpb24gd2hpY2ggc3RhdGVzDQo+Pj4+Pj4+Pj4gdGhhdCB0aGUg I2FkZHJlc3MtY2VsbHMgYW5kICNzaXplLWNlbGxzIGNvcnJlc3BvbmQgdG8gdGhlIHJlZyBwcm9w ZXJ0eS4NCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gSG1tbS4uLi4gTG9va2luZyBhdCBbMV0sIHRoZSB0 d28gcHJvcGVydGllcyBhcmUgbm90IGV4Y2x1c2l2ZSB0byAncmVnJw0KPj4+Pj4+Pj4gRnVydGhl cm1vcmUsIEkgYW0gbm90IGF3YXJlIG9mIGFueSByZXN0cmljdGlvbiBmb3IgdXMgdG8gcmUtdXNl IHRoZW0uIERvDQo+Pj4+Pj4+PiB5b3UgaGF2ZSBhIHBvaW50ZXI/DQo+Pj4+Pj4+IA0KPj4+Pj4+ PiBBcyB3ZSBhcmUgZGlzY3Vzc2luZyByZS11c2FnZSBvZiAjYWRkcmVzcy1jZWxscyBhbmQgI3Np emUtY2VsbHMgZm9yIGN1c3RvbSBwcm9wZXJ0aWVzIHRoYXQgYXJlIG5vdCAicmVnIiwNCj4+Pj4+ Pj4gSSB0b29rIHRoaXMgaW5mbyBmcm9tIHRoZSBsYXRlc3QgZGV2aWNlIHRyZWUgc3BlY3MgZm91 bmQgdW5kZXIgaHR0cHM6Ly9uYW0xMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/ dXJsPWh0dHBzJTNBJTJGJTJGd3d3LmRldmljZXRyZWUub3JnJTJGc3BlY2lmaWNhdGlvbnMlMkYm YW1wO2RhdGE9MDUlN0MwMSU3Q21pY2hhbC5vcnplbCU0MGFtZC5jb20lN0NjNjc3YTc5ODNjZDk0 ZTQ4NjIwNzA4ZGE5MGQ1YTE1ZiU3QzNkZDg5NjFmZTQ4ODRlNjA4ZTExYTgyZDk5NGUxODNkJTdD MCU3QzAlN0M2Mzc5ODE1NDQ0ODc0ODk2OTIlN0NVbmtub3duJTdDVFdGcGJHWnNiM2Q4ZXlKV0lq b2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxDSlhWQ0k2TW4w JTNEJTdDMzAwMCU3QyU3QyU3QyZhbXA7c2RhdGE9MXV3dGYlMkY2c2hmMlBpS3UwWFpQRk5RJTJC Nml5aExyTXNZYjFYRXJ1M0lHbGclM0QmYW1wO3Jlc2VydmVkPTA6DQo+Pj4+Pj4+ICJUaGUgI2Fk ZHJlc3MtY2VsbHMgcHJvcGVydHkgZGVmaW5lcyB0aGUgbnVtYmVyIG9mIDx1MzI+IGNlbGxzIHVz ZWQgdG8gZW5jb2RlIHRoZSBhZGRyZXNzIGZpZWxkIGluIGEgY2hpbGQgbm9kZSdzIHJlZyBwcm9w ZXJ0eSINCj4+Pj4+Pj4gYW5kDQo+Pj4+Pj4+ICJUaGUgI3NpemUtY2VsbHMgcHJvcGVydHkgZGVm aW5lcyB0aGUgbnVtYmVyIG9mIDx1MzI+IGNlbGxzIHVzZWQgdG8gZW5jb2RlIHRoZSBzaXplIGZp ZWxkIGluIGEgY2hpbGQgbm9kZeKAmXMgcmVnIHByb3BlcnR5Ig0KPj4+Pj4+IA0KPj4+Pj4+IFJp Z2h0LiBCdXQgdGhlcmUgaXMgbm90aGluZyBpbiB0aGUgd29yZGluZyBzdWdnZXN0aW5nIHRoYXQN Cj4+Pj4+PiAjYWRkcmVzcy1jZWxscyBhbmQgI3NpemUtY2VsbHMgY2FuJ3QgYmUgcmUtdXNlZC4g RnJvbSBbMV0sIGl0IGlzIGNsZWFyDQo+Pj4+Pj4gdGhhdCB0aGUgbWVhbmluZyBoYXMgY2hhbmdl ZC4NCj4+Pj4+PiANCj4+Pj4+PiBTbyB3aHkgY2FuJ3Qgd2UgZG8gdGhlIHNhbWU/DQo+Pj4+PiBJ IHRoaW5rIHRoaXMgaXMgYSBtYXR0ZXIgb2YgaG93IHNvbWVvbmUgcmVhZHMgdGhlc2Ugc2VudGVu Y2VzLg0KPj4+Pj4gSSBkbyBub3QgdGhpbmsgdGhhdCBzdWNoIGRvY3VtZW50cyBuZWVkIHRvIHN0 YXRlOg0KPj4+Pj4gIlRoaXMgcHJvcGVydHkgaXMgZm9yIHRoZSByZWcuIERvIG5vdCB1c2UgaXQg Zm9yIG90aGVyIHB1cnBvc2VzLiINCj4+Pj4+IFRoZSBmaXJzdCBwYXJ0IG9mIHRoZSBzZW50ZW5j ZSBpcyBlbm91Z2ggdG8gaW5mb3JtIHdoYXQgaXMgc3VwcG9ydGVkLg0KPj4+Pj4gDQo+Pj4+PiBP biB0aGUgb3RoZXIgaGFuZCwgbG9va2luZyBhdCBbMV0gdGhlc2UgcHJvcGVydGllcyBnb3QgbmV3 IHB1cnBvc2VzDQo+Pj4+PiBzbyBJIHRoaW5rIHdlIGNvdWxkIGRvIHRoZSBzYW1lLiBOb3cgdGhl IHF1ZXN0aW9uIGlzIHdoZXRoZXIgd2Ugd2FudCB0aGF0Lg0KPj4+Pj4gSSB0aGluayBpdCBpcyBk b2FibGUgdG8ganVzdCBoYXZlIGEgc2luZ2xlIHBhaXIgb2YgI2FkZHJlc3MvI3NpemUgcHJvcGVy dGllcy4NCj4+Pj4+IEZvciBpbnN0YW5jZSB4ZW4sc2hhcmVkLW1lbSByZXF1aXJpbmcganVzdCAw eDEgZm9yIGFkZHJlc3Mvc2l6ZQ0KPj4+Pj4gYW5kIHJlZyByZXF1aXJpbmcgMHgyLiBUaGlzIHdv dWxkIGp1c3QgaW1wbHkgcHV0dGluZyBhZGRpdGlvbmFsIDB4MDAuDQo+Pj4+IA0KPj4+PiBJIHRo aW5rIHdlIHdhbnQgaW4gZ2VuZXJhbCB0byByZWR1Y2UgY29tcGxleGl0eSB3aGVuIHBvc3NpYmxl Lg0KPj4+PiBIZXJlIHdlIGFyZSBhZGRpbmcgYSBsb3Qgb2YgZW50cmllcyBpbiB0aGUgZGV2aWNl IHRyZWUgd2hlcmUgd2Uga25vdyB0aGF0DQo+Pj4+IGluIGFsbCBjYXNlcyBoYXZpbmcgb25seSAy IHdpbGwgd29yayBhbGwgdGhlIHRpbWUuDQo+Pj4+IA0KPj4+PiBJIGFtIG5vdCBjb252aW5jZWQg YnkgdGhlIGFyZ3VtZW50cyBvbiBub3QgdXNpbmcgI2FkZHJlc3MtY2VsbHMgYW5kIHdpbGwNCj4+ Pj4gbGVhdmUgdGhhdCBvbmUgdG8gU3RlZmFubw0KPj4+PiANCj4+Pj4gQnV0IGluIGFueSBjYXNl IHdlIHNob3VsZCBvbmx5IGFkZCBvbmUgcGFpciBoZXJlIGZvciBzdXJlLCBhcyB5b3Ugc2F5IHRo ZQ0KPj4+PiBvbmx5IGltcGxpY2F0aW9uIGlzIHRvIGFkZCBhIGNvdXBsZSBvZiAwIGluIHRoZSB3 b3JzdCBjYXNlLg0KPj4+IEkgYWdyZWUuIFRoZSBvbmx5IGRyYXdiYWNrIGlzIHRoZSBuZWVkIHRv IG1vZGlmeSB0aGUgYWxyZWFkeSBpbnRyb2R1Y2VkIHByb3BlcnRpZXMNCj4+PiB0byBiZSBjb2hl cmVudC4NCj4+IA0KPj4gQWdyZWUsIHNvbWVvbmUgd2lsbCBuZWVkIHRvIGRvIGEgcGFzcyBvbiB0 aGUgd2hvbGUgZG9jIHdoaWNoIG1pZ2h0IGJlIGVhc2llciB3aXRoIGFsbCB0aGluZ3MgaW4uDQo+ PiANCj4gV2VsbCwgbm90IG9ubHkgZG9jcy4gSWYgd2UgZGVjaWRlIHRvIHVzZSBhIHNpbmdsZSBw YWlyIG9mICNhZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscywgdGhlbg0KPiB3ZSBuZWVkIHRv IG1vZGlmeSB0aGUgY29kZSB0aGF0IGV4cGVjdHMgZGlmZmVyZW50IHByb3BlcnRpZXMgZS5nLiB4 ZW4sc3RhdGljLW1lbS17YWRkcmVzcy9zaXplfS1jZWxscy4NCg0KUmlnaHQgSSBmb3Jnb3QgdGhh dCBzb21lIHBhcnRzIGFyZSBhbHJlYWR5IGluLg0KU28gd2Ugd2lsbCBuZWVkIGFuIGV4dHJhIHBh dGNoIHRvIGhhbmRsZSB0aG9zZS4NCg0KQmVydHJhbmQNCg0KPiANCj4+IENoZWVycw0KPj4gQmVy dHJhbmQNCj4+IA0KPj4+IA0KPj4+PiANCj4+Pj4gQ2hlZXJzDQo+Pj4+IEJlcnRyYW5kDQo+Pj4+ IA0KPj4+Pj4gDQo+Pj4+Pj4gDQo+Pj4+Pj4gQ2hlZXJzLA0KPj4+Pj4+IA0KPj4+Pj4+IC0tDQo+ Pj4+Pj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:46:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:46:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401796.643733 (Exim 4.92) (envelope-from ) id 1oVvOA-000852-Mp; Wed, 07 Sep 2022 13:46:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401796.643733; Wed, 07 Sep 2022 13:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvOA-00084v-K1; Wed, 07 Sep 2022 13:46:46 +0000 Received: by outflank-mailman (input) for mailman id 401796; Wed, 07 Sep 2022 13:46:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvOA-00084m-8y for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:46:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvO9-0006kl-5Q; Wed, 07 Sep 2022 13:46:45 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVvO8-0004Sd-Uv; Wed, 07 Sep 2022 13:46:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7DPAg9FSzc/NagJ0J89yzzeBSRqn1A2dUyGNtxgtRQ0=; b=ObD6ve7zSKfu5uGr5Igk9nRi2r 7qPwXI5o6YQDkt2nPvlE5KVv+HD/8OMsXWfKs3sKWCGWAyOZ26RkMUFFapFeFljrxadk+k/xnxve8 T7f9toPK6FSuF83zqDp7iMhiOhs3hpCNuz8b9xn/uGQ4hdTbEiqy5ptHOZzhrhK6IHsU=; Message-ID: Date: Wed, 7 Sep 2022 14:46:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 9/9] xen: Add static memory sharing in SUPPORT.md Content-Language: en-US To: Michal Orzel , Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-10-Penny.Zheng@arm.com> <55154517-40ac-691c-74ed-7ce2504f6c07@amd.com> From: Julien Grall In-Reply-To: <55154517-40ac-691c-74ed-7ce2504f6c07@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/09/2022 12:59, Michal Orzel wrote: > On 06/09/2022 10:59, Penny Zheng wrote: >> >> on ARM, static memory sharing is tech preview, which shall be documented >> in SUPPORT.md >> >> Signed-off-by: Penny Zheng > > Reviewed-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:49:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401803.643744 (Exim 4.92) (envelope-from ) id 1oVvR0-0000V1-53; Wed, 07 Sep 2022 13:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401803.643744; Wed, 07 Sep 2022 13:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvR0-0000Uu-1G; Wed, 07 Sep 2022 13:49:42 +0000 Received: by outflank-mailman (input) for mailman id 401803; Wed, 07 Sep 2022 13:49:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvQy-0000Uk-Gt for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:49:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea7b6855-2eb3-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:49:39 +0200 (CEST) Received: from AS8PR04CA0147.eurprd04.prod.outlook.com (2603:10a6:20b:127::32) by AS4PR08MB7854.eurprd08.prod.outlook.com (2603:10a6:20b:51d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 13:49:37 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::51) by AS8PR04CA0147.outlook.office365.com (2603:10a6:20b:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:49:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:49:36 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 07 Sep 2022 13:49:36 +0000 Received: from 2909ebecc0ec.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ED4DAFD5-5255-4C1E-AB8A-4641AC5F9325.1; Wed, 07 Sep 2022 13:49:31 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2909ebecc0ec.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:49:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB7346.eurprd08.prod.outlook.com (2603:10a6:150:21::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Wed, 7 Sep 2022 13:49:29 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 13:49:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea7b6855-2eb3-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iqgIhA0/TNEao6IBGPWdKBiAEDBz1hspTwB/wD7Dy4xjTfqZcoWUE+GMBcbDZVeWc+7N1shIe61cuZf5VpEMpl4KWiqx88OeD1XpHFW24lyncSu9I/FErpCmCch8bims223zsMh6i3/lzuha66W59PE7ncI5DBblyjI8JheWtwk0e3rv20BX9UXjac6f7lIxvxlbsioGHVCbuu+rVwlFf3uNrQSpIdV0pPfEDPbrKe6k4exet6d0Ti2XFpw4AcSnUcXW7ta+5kN11xUx8mzJI680uICJanbfpjXCWM0L5tWv2VcVBegsY3sbGNjfGdFq3+eIycXDl/tjQogY3CzeZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dCLOjIdtjuWE/LHmRffdfEN0QuE/zrOgtgmC/4qgZ0U=; b=ANyB5agPgqy/Vd3xMHxnuntymWVtpwsOz3oM1xEo6mbyFiI8qWyH4wPxokfsjvEK2rO0N1ligyBvIkbjnFkHWdfiOReUWORK+MrdjZASPCtdG1VRHPvIhYJlnS4QHgoQttD0vjanbYz0j05iF1F1KcXiBLuYLyR46SOw4yq5jL1mIlpSgi7G/0R+5OeQ9jWSlaT68H82Zn288k6MmUXk/nqB/Us7N+P6yYObppNubdhzhJMRqNOmaxcW8feEqkV5mFxffFHSVroMaFsITFHXFEfNs+f2ZIR2AMED6ANlE7yLSuCQj2NFu2r02FeN/Dh5azyULA1y7dX7wKANUQZ2HQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dCLOjIdtjuWE/LHmRffdfEN0QuE/zrOgtgmC/4qgZ0U=; b=2c/6Mm/fLeD1XWt+W0sztHW3La0Iz+PwkyMQ+vczurJziSy1VG8yKCOE3egUB8fFundGv7KCiWd2AVxkxs6xT5qBuwRZr+Uv0Q+YvypicL7OJhkh2hbjUrUP4dX6K8cYYGchKNsPf0mlGak3noJXhtk6rmddjbieHFJCSpHJCy0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CG8qGhoi4WQGF9cEIaqulXoW+9hgo1lxzCxHB+vPyw7LAAkAjmJi3FF94B8RFuUUg7dXOwgfTyVGYLoISKw0MRTiINohujBGp2c4VZ0EZQz7iOAh2UthehVGbOFJ0waplMgSfBGjj9Av4cgSehs88nMzoFZXo8cU/1HXCSDi9m3wXsHjqS0aVRRHGElLqZXxcwZM4oUD6OCJ4pCkMzp0C8mA8V3X1bCTQoOVE5kCe46I8TZT9YUozyGUozATTsyquqwKOfbXhBOMwHXZM51LwPb16/icDZBOdeoDyXo0nQEEaGIUSKH5a61Jcvaq2uJc6vm7oK+HbgeDzVnoKKeHhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dCLOjIdtjuWE/LHmRffdfEN0QuE/zrOgtgmC/4qgZ0U=; b=cFK7EmPUfizibVA6PjGKK56dtsBURUYjOQ5XFt82u7ALvRAYctRoi96+Y2vP8p8J65PrCykG9AG5hl7DcyuiWaleVUYG7KDHflPrGZ7a9mSqt/Fz4pr3N6CjJt3+FrJmtJdfuKisNXaNcbHMtFuRNNK9hFxABh6rGRg+R1KDiHMhvcrg090cwH35VSRHAe/nYjY5Vm8MAbbiLsvoA2YAIXrSna8q1JOnbkWfrgAmuRsjv8E2qF+C/+qW7nyEe8xM8EPXRd7Q7W6R6f4pVF15tSNOe2OrXyCwPu1301Hsk0ZB93jwn+t7IeRLOMqnM5jCxa3+TSsEaYjLpp+sJ6hExA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dCLOjIdtjuWE/LHmRffdfEN0QuE/zrOgtgmC/4qgZ0U=; b=2c/6Mm/fLeD1XWt+W0sztHW3La0Iz+PwkyMQ+vczurJziSy1VG8yKCOE3egUB8fFundGv7KCiWd2AVxkxs6xT5qBuwRZr+Uv0Q+YvypicL7OJhkh2hbjUrUP4dX6K8cYYGchKNsPf0mlGak3noJXhtk6rmddjbieHFJCSpHJCy0= From: Henry Wang To: Bertrand Marquis , Michal Orzel CC: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gIAAARoAgAACMwCAAABysA== Date: Wed, 7 Sep 2022 13:49:29 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> In-Reply-To: <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1E1A788B65783F47BC5B6C6D997E00E1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 14c09412-1c6c-4dc2-22f0-08da90d7cda9 x-ms-traffictypediagnostic: GV1PR08MB7346:EE_|AM7EUR03FT026:EE_|AS4PR08MB7854:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XrG1kTHAbXFxfLT0KYKmIGQonbiGlzVaEza2WxxQrYv7uZsmCduqJ9a+hZx2aN71n7BaradAljPv2H/jB2uAe99Q2oOHRryf6ndJRjkeEp1GKyjj4hLHhK6/qN8N+VRniKscxL+obg0B5coCaRp2pkZD920uF1IonpZHjiqjhy56TMbPGUDVfKy8EVkqTRHhDrPLRv+CIRdy3kY6ujKGEE6v0t8JyxOIwb74PF4YPUdx1yYUvACBWczk1rc/UEWFWU+TJjxdU5riYfSurKlc6nGn+ts4Wm0ICYl/Vd/pfRF9Fl6TgVQn4IwOMnHvFEQi5G8nlM46KXkIoUEqnPzBwjxByMxB6Eo81oTfmXStwjm6V4KHrppeTGalxGT1lbutAr5DYxoaZvGlCaMcSufeT3KdBTXes7kKNMzCJOwPk06A1GSwo1vlKAF9uMZZNj6BIgnsNwiICTUaty7vqbH8E5x9B6xnSRwhPoPu9y3Hlyq9gsy1tODAnm7Qj2ZEl6O87GS2ggWyOjH+qeDH/h3bvR83plQoAqLpiPkvCOR4rEEsIbt/vA0mPlmG9KKG+plQ+MiyP+Gi6+MQ/4rPnudknj6Ru5UDHZ+F+g8CQmxrfaMrtjfCzIJPirLtZasqo/RJEZotjfCeY+avR30dv9UPGqcdYDW6zZt3fQnxEr+ABtJCPSMnHKayo0m30UBxmRlBJLJpTYPA+Sg3r2jfRrA0pMC5s55F05btnBU1xjuzZdrQ259p8TPQ/6q0nqG0hf/YqYi552848A0IjPFTb53g5Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(316002)(71200400001)(33656002)(86362001)(9686003)(478600001)(83380400001)(55016003)(7696005)(26005)(186003)(41300700001)(6506007)(2906002)(38070700005)(66476007)(4326008)(52536014)(122000001)(110136005)(5660300002)(66446008)(8936002)(38100700002)(64756008)(76116006)(66556008)(66946007)(54906003)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7346 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 68e4ba0f-2f85-4afe-d554-08da90d7c908 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AtV62Y0qLGw9XbWFIaEsXfOQxGPNzR3hTqIH5CnYLA7cWpbHgbnd1BfR11CLFbZJTWSZy9LxdVaXX4d6RdSdXtH/thEXYnEBC4pSUJh2DzVEsUIKeSCt4djlnCJCh0gLIY7P+DHW/QWT7WAL/Wh4v9CDFzKkAOqmKl6eE9IYBB0g9FHSOOQz0aIcXvhUHLMPpG+zuT9CaEOQ2kOfk8OCjBONG/KqeVXIi7svpC/6NJv/jsAafQwHmZ+QdzrtgzH7SJUbewYoPVcEz6IA7RfyeHCko0UFtQcJjMR4L+UnWriQyRtbmYt9K7ru7lfmvu1GO4gYvZoLdx4Hn1xw3RPrjoupppzobIAUSlQwHnrx7jWHR4TW1fK02MgEe5UfgXJGobbvZOp/hI0IkgFrmOoCnv83NNsvYglnmyu3zVohy+zmo6nJX0cb7PxvQ4hqL28kB7K5KbgQsgo/7rDzt21CW1doI73YhvkV17KF7DbAulv3kJVT1w6VcBS6tScYOg6g1xhgVT646WIM+1QxgZe71T6lrh3XYauBZKMj5PqC/0dG/JzvMlEDKRSg0DMzxRYXrrDUwtFS22ApfThX7TDILkubbwu2rp2wqmXU7zOQB0hpmAnPRKKKRKRNSNkSZ2fEBRUZd7J419zNDYzSqcci1aym0Irr/Ypb5EDJ2jjjV1pOWZZscj3apIMAEd8cXgXsUd2kPq4UHUEVsqpFceEoHLW7nAA9QeOuW0FvZx4UysBIFTCqsk0eyJasvFvNzx5O1z1gRqfSIzwyuR2SEB3p1A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(36840700001)(46966006)(40470700004)(9686003)(7696005)(54906003)(8676002)(82740400003)(5660300002)(6506007)(356005)(26005)(110136005)(55016003)(70586007)(4326008)(82310400005)(70206006)(2906002)(316002)(33656002)(478600001)(86362001)(41300700001)(36860700001)(336012)(81166007)(8936002)(40480700001)(186003)(83380400001)(52536014)(40460700003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:49:36.8503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14c09412-1c6c-4dc2-22f0-08da90d7cda9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7854 SGkgQmVydHJhbmQgYW5kIE1pY2hhbCwNCg0KSSBkb24ndCB3YW50IHRvIHNwYW0gdGhlIGVtYWls IHNvIEkganVzdCByZXBseSBoZXJlLi4uDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N Cj4gRnJvbTogQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPg0KPiA+ Pj4+IEJ1dCBpbiBhbnkgY2FzZSB3ZSBzaG91bGQgb25seSBhZGQgb25lIHBhaXIgaGVyZSBmb3Ig c3VyZSwgYXMgeW91IHNheQ0KPiB0aGUNCj4gPj4+PiBvbmx5IGltcGxpY2F0aW9uIGlzIHRvIGFk ZCBhIGNvdXBsZSBvZiAwIGluIHRoZSB3b3JzdCBjYXNlLg0KPiA+Pj4gSSBhZ3JlZS4gVGhlIG9u bHkgZHJhd2JhY2sgaXMgdGhlIG5lZWQgdG8gbW9kaWZ5IHRoZSBhbHJlYWR5IGludHJvZHVjZWQN Cj4gcHJvcGVydGllcw0KPiA+Pj4gdG8gYmUgY29oZXJlbnQuDQo+ID4+DQo+ID4+IEFncmVlLCBz b21lb25lIHdpbGwgbmVlZCB0byBkbyBhIHBhc3Mgb24gdGhlIHdob2xlIGRvYyB3aGljaCBtaWdo dCBiZQ0KPiBlYXNpZXIgd2l0aCBhbGwgdGhpbmdzIGluLg0KPiA+Pg0KPiA+IFdlbGwsIG5vdCBv bmx5IGRvY3MuIElmIHdlIGRlY2lkZSB0byB1c2UgYSBzaW5nbGUgcGFpciBvZiAjYWRkcmVzcy1j ZWxscyBhbmQNCj4gI3NpemUtY2VsbHMsIHRoZW4NCj4gPiB3ZSBuZWVkIHRvIG1vZGlmeSB0aGUg Y29kZSB0aGF0IGV4cGVjdHMgZGlmZmVyZW50IHByb3BlcnRpZXMgZS5nLg0KPiB4ZW4sc3RhdGlj LW1lbS17YWRkcmVzcy9zaXplfS1jZWxscy4NCj4gDQo+IFJpZ2h0IEkgZm9yZ290IHRoYXQgc29t ZSBwYXJ0cyBhcmUgYWxyZWFkeSBpbi4NCj4gU28gd2Ugd2lsbCBuZWVkIGFuIGV4dHJhIHBhdGNo IHRvIGhhbmRsZSB0aG9zZS4NCg0KSSB0aGluayBJJ3ZlIGFkZHJlc3NlZCBhbGwgY29tbWVudHMg ZnJvbSBKdWxpZW4gcmVnYXJkaW5nIG15IHNlcmllcywNCnNvIEkgdGhpbmsgSSd2ZSBnb3Qgc29t ZSBiYW5kd2lkdGggdG8gZG8gdGhlIGNsZWFuLXVwIHBhdGNoIHRvbW9ycm93DQphZnRlciB0aGUg YWdyZWVtZW50LCB1bmxlc3Mgc29tZW9uZSB3b3VsZCBsaWtlIHRvIGRvIGl0IGhpbXNlbGY/DQoN CktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEJlcnRyYW5kDQo+IA0KPiA+DQo+ID4+IENo ZWVycw0KPiA+PiBCZXJ0cmFuZA0KPiA+Pg0KPiA+Pj4NCj4gPj4+Pg0KPiA+Pj4+IENoZWVycw0K PiA+Pj4+IEJlcnRyYW5kDQo+ID4+Pj4NCj4gPj4+Pj4NCj4gPj4+Pj4+DQo+ID4+Pj4+PiBDaGVl cnMsDQo+ID4+Pj4+Pg0KPiA+Pj4+Pj4gLS0NCj4gPj4+Pj4+IEp1bGllbiBHcmFsbA0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:49:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401804.643754 (Exim 4.92) (envelope-from ) id 1oVvR5-0000mW-As; Wed, 07 Sep 2022 13:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401804.643754; Wed, 07 Sep 2022 13:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvR5-0000mP-8C; Wed, 07 Sep 2022 13:49:47 +0000 Received: by outflank-mailman (input) for mailman id 401804; Wed, 07 Sep 2022 13:49:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvR3-0000lq-Vk for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:49:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvR3-0006na-KL; Wed, 07 Sep 2022 13:49:45 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVvR3-0004XI-Df; Wed, 07 Sep 2022 13:49:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cwNoQj0xylDOSaQGXKe+ygRgi0ISHqSy3MvPUUhpiqY=; b=lS89zq4laNGYNPkLPVYP3xDwZF CankswLrLHIS0rgw/YFMCoETz/HZKbnxpCOoDFkJH3we8wPvGQ22BZSB5Cld2iFfrJpHfgjtSbEZm EMlkVXDm/J71dOX41LFR56uDunGW7qELHm2yZJPjFhFcLRjPUtiG5JVpujfWbUUH7dzg=; Message-ID: Date: Wed, 7 Sep 2022 14:49:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 1/9] xen/arm: introduce static shared memory Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 02:51, Penny Zheng wrote: > Hi Julien Hi Penny, > >> -----Original Message----- >> From: Julien Grall >> Sent: Wednesday, September 7, 2022 2:01 AM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk ; Henry Wang >> >> Subject: Re: [PATCH v7 1/9] xen/arm: introduce static shared memory >> >> Hi Penny, >> >> On 06/09/2022 09:59, Penny Zheng wrote: >>> static int __init early_scan_node(const void *fdt, >>> int node, const char *name, int depth, >>> u32 address_cells, u32 size_cells, >>> @@ -386,6 +549,8 @@ static int __init early_scan_node(const void *fdt, >>> process_chosen_node(fdt, node, name, address_cells, size_cells); >>> else if ( depth == 2 && device_tree_node_compatible(fdt, node, >> "xen,domain") ) >>> rc = process_domain_node(fdt, node, name, address_cells, >>> size_cells); >>> + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, >> "xen,domain-shared-memory-v1") ) >>> + rc = process_shm_node(fdt, node, address_cells, size_cells); >>> >>> if ( rc < 0 ) >>> printk("fdt: node `%s': parsing failed\n", name); diff --git >>> a/xen/arch/arm/include/asm/setup.h >> b/xen/arch/arm/include/asm/setup.h >>> index 5815ccf8c5..995eee1d09 100644 >>> --- a/xen/arch/arm/include/asm/setup.h >>> +++ b/xen/arch/arm/include/asm/setup.h >>> @@ -23,10 +23,17 @@ typedef enum { >>> } bootmodule_kind; >>> >>> >>> +/* Indicates the maximum number of characters(\0 included) for shm_id >>> +*/ #define MAX_SHM_ID_LENGTH 16 >>> + >>> struct membank { >>> paddr_t start; >>> paddr_t size; >>> bool xen_domain; /* whether the memory bank is bound to a Xen >>> domain. */ >>> +#ifdef CONFIG_STATIC_SHM >>> + char shm_id[MAX_SHM_ID_LENGTH]; >>> + unsigned int nr_shm_borrowers; >>> +#endif >> >> I forgot to mention that this will clash with Henry's series [1]. As both series >> are meant for 4.17, please coordinate to decide which series should be >> merged first (this is to avoid last minute clash on Friday). >> > > I'll push v8 ASAP when henry's commits get committed~~~~ I would suggest to rebase on top of Henry's series now and resend it (you can mention in the cover letter). This will enable the committers to merge your series right after and reduce the risk that your series miss the deadline (we may only commit Henry's series on Friday morning UK time). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 13:51:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 13:51:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401817.643765 (Exim 4.92) (envelope-from ) id 1oVvSV-0002Ou-N5; Wed, 07 Sep 2022 13:51:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401817.643765; Wed, 07 Sep 2022 13:51:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvSV-0002On-KA; Wed, 07 Sep 2022 13:51:15 +0000 Received: by outflank-mailman (input) for mailman id 401817; Wed, 07 Sep 2022 13:51:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvSU-0002LN-Al for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 13:51:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22f1de71-2eb4-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 15:51:13 +0200 (CEST) Received: from DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) by DBAPR08MB5717.eurprd08.prod.outlook.com (2603:10a6:10:1ae::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 13:51:11 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::7d) by DB6PR0301CA0088.outlook.office365.com (2603:10a6:6:30::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 13:51:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 13:51:10 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 07 Sep 2022 13:51:10 +0000 Received: from 39a450b41e0a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 13BF524A-1A07-42C7-8D07-1F709F2F5146.1; Wed, 07 Sep 2022 13:51:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 39a450b41e0a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 13:51:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB6249.eurprd08.prod.outlook.com (2603:10a6:10:203::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 13:51:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:51:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22f1de71-2eb4-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ghPgPktXz1x87sYSt0/dVL+e84m7RNrVAUcFenUC7QiOPOi2iFQ9VgCUi92zE17xpcsULsGKwCjfxWKXTlT3872H7ZzwngeRgKwKg8xTxtHpqdeCvhYd5GN+jeEatMo4il0+VasVQuPBIeLHzG/YsAkzypKijQ0MADniLPWMLfClcs68mrrms5jV/Bl4z+O9zs+qXMqLZ731OIU4cVVSp3s86AmAkpeTsHV7qJ++UY1E7PsJL8P201U8hyIOS5CXUkhXI9S9IWaLdDgKODP2rNDOOni7ohZ6pNw4GAjJ48WkrKVfouogYasOwDSe+qRinxa9KGWvjzE02qUbRVcueA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sO8nRLsNDjEbo/d5LmyjqEEzabWFl8xVanJD1nqwjX8=; b=l9HSuer/SCj0nKT4cRxgLgI6729bfYK1pN8iOE+GPuyUUCSKWSEvohWeNiBRUwU343N4eaClUOr48Zdk4ZIs9g/yyUQ9G8j81s7uiH6VeTlAVMr7M43etQrJ4wddEYss8wc7fDTOPH7E0XFB5wTm2wGHZtDBf3fmYPStHmI/y7IKeWLrBUr4wzHg45YgPtdWjel5POW6qM0xvhE/8yZUCfkYYcK6TL4VFYeku5UfRLEomySf5Dni7YT8WMzZs86nfXlh+rT2oOA/f5Tnpg81NQ9i5lDracpDeK6fdb+R5MLzuPfRYPmDumFxxblIv6BlsBW9iBIsRVHLRxX2YRNbkw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sO8nRLsNDjEbo/d5LmyjqEEzabWFl8xVanJD1nqwjX8=; b=efv6XjcFEPWgrwtfYny6rU+Pkm5l3gWBCgHwzunkcQ7Z/6gott9LYLk9FO+jNCdvGksJcMplV3+kFIvU9XqWcy3DclcvEYU56+9ceqX9GWHjoOUwy7Wouq6PKYOCgZIEQ+DwLWDwUbKTKoihAs4b+cWZv3uBllaJnU1BkzIOWIg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dfc09e8ce122878b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L1LfcjrOm0LdMl3ZubyPEbvVjh2CJFixI36uN4hNtvJ6RA8sKGBBM+tRFqN0rUrHs25w61+i168PDVqrHEVkmuZxcItl117U9Y3loUZQYsXXzCAgiIYKY9B26tBl9GfMqd1bjoX49EjHy9L4H0lN03QLSgYrQ8J+ZmByTqgBU3vf8uVamwPQzcej0y8dWlRaoNUC9EyMyGsCcWbVwG37w1ldlQQ1itntihWxjXM/I6RDu54EV35NRc7onhTkOuSHDz2HfRQEJglpfHcRrAKmA+ttdAkQ4r9GJaaMLr4Fth7GqU8InALMXt0Vkq7zhfl4n23wxlLzunV1EZSUnzzcpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sO8nRLsNDjEbo/d5LmyjqEEzabWFl8xVanJD1nqwjX8=; b=FORppwTnDoH6+X93H9Pt3V/R3jbbaPVVUR2MAdd+s/nQOygQCVgKthYmZkGt0JQCgXNnOICKisuw6swf97hLiF334NDEg93+3IqaxL133Ecoru/431kaRHS7unEshpKxzh0VCWvpchgCj3j+W93q5LFazCfc9fb43wxpZtjjxIepVqgYVaMLR2dDl6BBjj6CjbJU/BmqkaI/naLhdlgasVcHlGi1RR/6e8/29jOwVUviGQCLK08fFif4dhsNDj/Br4vJN94sDrSbTKe9DoIVYI2WdIxt9E+VnkBXlPY2JpFMuqLgmzfxJIeWp2QCsieImDZCHM937s5oJYLwPa3GYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sO8nRLsNDjEbo/d5LmyjqEEzabWFl8xVanJD1nqwjX8=; b=efv6XjcFEPWgrwtfYny6rU+Pkm5l3gWBCgHwzunkcQ7Z/6gott9LYLk9FO+jNCdvGksJcMplV3+kFIvU9XqWcy3DclcvEYU56+9ceqX9GWHjoOUwy7Wouq6PKYOCgZIEQ+DwLWDwUbKTKoihAs4b+cWZv3uBllaJnU1BkzIOWIg= From: Bertrand Marquis To: Henry Wang CC: Michal Orzel , Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ4p6pfICa8EGhkwL2mg6iHK3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gIAAARoAgAACMwCAAAEagIAAAG6A Date: Wed, 7 Sep 2022 13:51:01 +0000 Message-ID: <64B45AE5-1D8B-44BB-831B-73B5C2B785CA@arm.com> References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 87bcf517-a87d-4feb-40a7-08da90d805a2 x-ms-traffictypediagnostic: DBBPR08MB6249:EE_|DBAEUR03FT026:EE_|DBAPR08MB5717:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: edkQMO5x5n4IDBVF4uwAxg0/vNhtOVJBYQpJIT4VU3z6PYeI3fel25lD5pnG8s69jBwsyyLzUcdAfvbRo6pQJcXXOVr9F2rbil4aDBboMur4k/mDjHZnIDZnWBe39rt8nDndGjfNzLOI4o/PClfSXIm/xOP+PiFyr9XWY/vj9eZm/s7N3aaAq8kkRFwaukefea/5D7ElZyOVEDqnaJDETVu87arSz4qNygUaIIpnu/HPsjgdVCL5mAarZoWD4bNpARPxi+swOSC0TdRwT20+bEO4vmUNXsWk2Hz0zncpjht6ni0zio2BvTi2Gre85Q+9BQXeAbuhCCj/Ic6QbY8sq0/5yKMtVUVetqcLOJF4ra1sMb1LEEgXiot3JKdnWg5pbB4qXsJ3TgJNDJ7vvH7nf7VcPbwdxWDQYdXnlcIlukSM+Aagy/y9YBStWY49WyCuf31NhBOWb9DaguJCZoa2i8EuZg1s9IdA7uUi0qxbapxlLQD0DL9FURXJe7WdJSz4ln6bDKSklQ7brdjHeHwPpfYh2jtI0yPdVZcrEtqyRUoBAKY6uIICf5nBqBTAQXF250VjJx5F5d0RnxdELa/2gUUte9ZW7FFzBrqOQ2nRwJ2tLLK2wJm51XUkN/JdjD7nBnt6kk2BydPJ/PmjQAY/KAmQJW3SLaExRBtG6xtuQ/3sNtKLj7CBFn9ZcY3paMTW9JWlzD0l3GWL0ULfPm09DK6945gg8641STUQgAlEqKWnooU/WzyKm6ztjCx8+r8nqcwsI5EEXsDeoXNrzq1IwAA5jXXwf/o0A7uYmHybE8s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(5660300002)(37006003)(316002)(6636002)(54906003)(33656002)(66476007)(76116006)(36756003)(64756008)(2906002)(91956017)(4326008)(8676002)(66556008)(8936002)(6862004)(66446008)(66946007)(478600001)(6486002)(2616005)(41300700001)(6506007)(186003)(83380400001)(71200400001)(26005)(38070700005)(6512007)(86362001)(53546011)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <247D7BCFB7474F409EE277922550C5FA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6249 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e482851a-d9fe-4115-3e7e-08da90d80043 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XsJQM86vCiqbN3Y1NkNQ1KeUmhJOX6hq/lE8K2QHNuPCJI0IMIuBcvldSL4zJY633t+4v9LB7FDK4fiZyz6XEQ7uwBfl9TWrEgJubB2Ovbf//Ku+lroNWrqwHo2C3EADILproP8W01i72ABOUUZUCGaM7xGq5ATHT+n8nH0CnhQlV6WnbsrQRisvrbSJAvozz9rdVw2BY2fEY+1JtnlNedj3fJXQUsR4L2q6XMPTurj/ju52XpvsVHO4tBhL5z9Go6ajevAauCuPGrmxluvcts5kvIPAtwvbiy1FgdTgwzi6SPqyPbp5kvNgT239xcwR27EsiupULTVku4K5uWOzAoxNusxCJ6fcRDglVos9BCIKzS2H6iU3PiMgy/3QxmslZulsFCz9L+Y1G4R96IWhVBZDuZ3jpY9tLPxyiBlc8dJLKK4Qn/KuDgFKf5XKUC+dXtXmkKjIivUSB3GnAqM64D4rT0H83vDbqoDhiyWoiwIaEoKZ4XF9Wk5OY+INdHl18RxZ43MXERi8krJGx/nenJZ3ZKAcs2Ldr0oe2hLtUMGAIG40x4PtyN6dVAGM3hq4VfU5rkE/oTlfIjqimGoIKisJsjjVITsRTj4M6td/XehKJDJC1KDxGbrX5SKRGF7HJPOTSnHfbasvCf3Hsa6ax6RuXbCjTM4YzkCpuYLACwbA3AWcWsB4jLnyYaqwD4hEuPwSoS28Zdwr02wLumOIdrXYJdPocrhgocIBW2LFhAnXnM2ul/PcMa3qlWPPGDx6wxJo6uarCBjbNJIytBiy+Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(39860400002)(346002)(376002)(46966006)(40470700004)(36840700001)(82740400003)(82310400005)(86362001)(36756003)(6636002)(2616005)(37006003)(54906003)(186003)(40480700001)(316002)(336012)(6862004)(6486002)(8936002)(47076005)(70206006)(70586007)(478600001)(5660300002)(8676002)(4326008)(6506007)(36860700001)(81166007)(53546011)(356005)(33656002)(6512007)(83380400001)(2906002)(40460700003)(26005)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:51:10.8045 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87bcf517-a87d-4feb-40a7-08da90d805a2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5717 SGkgSGVucnksDQoNCj4gT24gNyBTZXAgMjAyMiwgYXQgMTQ6NDksIEhlbnJ5IFdhbmcgPEhlbnJ5 LldhbmdAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBCZXJ0cmFuZCBhbmQgTWljaGFsLA0KPiAN Cj4gSSBkb24ndCB3YW50IHRvIHNwYW0gdGhlIGVtYWlsIHNvIEkganVzdCByZXBseSBoZXJlLi4u DQo+IA0KPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+IEZyb206IEJlcnRyYW5kIE1h cnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT4NCj4+Pj4+PiBCdXQgaW4gYW55IGNhc2Ug d2Ugc2hvdWxkIG9ubHkgYWRkIG9uZSBwYWlyIGhlcmUgZm9yIHN1cmUsIGFzIHlvdSBzYXkNCj4+ IHRoZQ0KPj4+Pj4+IG9ubHkgaW1wbGljYXRpb24gaXMgdG8gYWRkIGEgY291cGxlIG9mIDAgaW4g dGhlIHdvcnN0IGNhc2UuDQo+Pj4+PiBJIGFncmVlLiBUaGUgb25seSBkcmF3YmFjayBpcyB0aGUg bmVlZCB0byBtb2RpZnkgdGhlIGFscmVhZHkgaW50cm9kdWNlZA0KPj4gcHJvcGVydGllcw0KPj4+ Pj4gdG8gYmUgY29oZXJlbnQuDQo+Pj4+IA0KPj4+PiBBZ3JlZSwgc29tZW9uZSB3aWxsIG5lZWQg dG8gZG8gYSBwYXNzIG9uIHRoZSB3aG9sZSBkb2Mgd2hpY2ggbWlnaHQgYmUNCj4+IGVhc2llciB3 aXRoIGFsbCB0aGluZ3MgaW4uDQo+Pj4+IA0KPj4+IFdlbGwsIG5vdCBvbmx5IGRvY3MuIElmIHdl IGRlY2lkZSB0byB1c2UgYSBzaW5nbGUgcGFpciBvZiAjYWRkcmVzcy1jZWxscyBhbmQNCj4+ICNz aXplLWNlbGxzLCB0aGVuDQo+Pj4gd2UgbmVlZCB0byBtb2RpZnkgdGhlIGNvZGUgdGhhdCBleHBl Y3RzIGRpZmZlcmVudCBwcm9wZXJ0aWVzIGUuZy4NCj4+IHhlbixzdGF0aWMtbWVtLXthZGRyZXNz L3NpemV9LWNlbGxzLg0KPj4gDQo+PiBSaWdodCBJIGZvcmdvdCB0aGF0IHNvbWUgcGFydHMgYXJl IGFscmVhZHkgaW4uDQo+PiBTbyB3ZSB3aWxsIG5lZWQgYW4gZXh0cmEgcGF0Y2ggdG8gaGFuZGxl IHRob3NlLg0KPiANCj4gSSB0aGluayBJJ3ZlIGFkZHJlc3NlZCBhbGwgY29tbWVudHMgZnJvbSBK dWxpZW4gcmVnYXJkaW5nIG15IHNlcmllcywNCj4gc28gSSB0aGluayBJJ3ZlIGdvdCBzb21lIGJh bmR3aWR0aCB0byBkbyB0aGUgY2xlYW4tdXAgcGF0Y2ggdG9tb3Jyb3cNCj4gYWZ0ZXIgdGhlIGFn cmVlbWVudCwgdW5sZXNzIHNvbWVvbmUgd291bGQgbGlrZSB0byBkbyBpdCBoaW1zZWxmPw0KDQpU aGlzIGlzIHZlcnkgbmljZSBvZiB5b3UuDQpXZSBuZWVkIHRvIGNvbmZpcm0gZmlyc3QgaWYgc29t ZXRoaW5nIGlzIGFjdHVhbGx5IG5lZWRlZCBvciBub3Qgc28gd2UgbmVlZCBTdGVmYW5v4oCZcyB2 aWV3IGhlcmUuDQpJZiBzbyB0aGVuIHBsZWFzZSBkbyBpdCA6LSkNCg0KQ2hlZXJzDQpCZXJ0cmFu ZA0KDQo+IA0KPiBLaW5kIHJlZ2FyZHMsDQo+IEhlbnJ5DQo+IA0KPj4gDQo+PiBCZXJ0cmFuZA0K Pj4gDQo+Pj4gDQo+Pj4+IENoZWVycw0KPj4+PiBCZXJ0cmFuZA0KPj4+PiANCj4+Pj4+IA0KPj4+ Pj4+IA0KPj4+Pj4+IENoZWVycw0KPj4+Pj4+IEJlcnRyYW5kDQo+Pj4+Pj4gDQo+Pj4+Pj4+IA0K Pj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBDaGVlcnMsDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IC0tDQo+Pj4+ Pj4+PiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:04:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:04:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401837.643781 (Exim 4.92) (envelope-from ) id 1oVvfF-0004Tz-2l; Wed, 07 Sep 2022 14:04:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401837.643781; Wed, 07 Sep 2022 14:04:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvfE-0004Ts-W7; Wed, 07 Sep 2022 14:04:24 +0000 Received: by outflank-mailman (input) for mailman id 401837; Wed, 07 Sep 2022 14:04:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvfD-0004Tm-Ll for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:04:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvfD-00079n-9B; Wed, 07 Sep 2022 14:04:23 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVvfD-0005J5-0Q; Wed, 07 Sep 2022 14:04:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nxkRo1vel5WQZoR9U0o5JU1tt69PxQWaxWXCFuA+Kzc=; b=g3sZBOc4J5MLBep7tZ7IIodsxv cjOpQmT3OjuUn5+jzKemAK6N7YgZCGBpX1ykvXAJUpN/DOc68S4ZFNxsrAk5h2FrLWw+qerImaicx 1wOHjzIV5iT4/UDAoV+aqEABh1pJbElGiLKI3UXygh5eSoZd4abxq2NSdRVXDGcGdEoo=; Message-ID: <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> Date: Wed, 7 Sep 2022 15:04:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Henry Wang , Bertrand Marquis , Michal Orzel Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/09/2022 14:49, Henry Wang wrote: >> -----Original Message----- >> From: Bertrand Marquis >>>>>> But in any case we should only add one pair here for sure, as you say >> the >>>>>> only implication is to add a couple of 0 in the worst case. >>>>> I agree. The only drawback is the need to modify the already introduced >> properties >>>>> to be coherent. >>>> >>>> Agree, someone will need to do a pass on the whole doc which might be >> easier with all things in. >>>> >>> Well, not only docs. If we decide to use a single pair of #address-cells and >> #size-cells, then >>> we need to modify the code that expects different properties e.g. >> xen,static-mem-{address/size}-cells. >> >> Right I forgot that some parts are already in. >> So we will need an extra patch to handle those. > > I think I've addressed all comments from Julien regarding my series, If it is not too late for you would you be able to resend your series without the 'address-cells'/'size-cells' change? This will give me the opportunity to have an other review today. > so I think I've got some bandwidth to do the clean-up patch tomorrow > after the agreement, unless someone would like to do it himself? Renaming "xen,static-mem-..." is a bit tricky because they have been defined in Xen 4.16. I couldn't find any support statement specific to the static memory feature. So it would technically fall under the "dom0less" section which is security supported. That said, I don't think we can consider that the static memory feature is even supported because, until yesterday, the code wasn't properly handling request to balloon in/out. So I would view this is a tech preview (Could someone send a patch to clarify SUPPORT.MD)? This would mean that would be that we could consider the binding unstable and we could do a straight renaming. That said, I can understand this may be undesirable. If that's the case then we would need to keep the current binding as-is. So we would have two options: 1) Provide a new compatible so #address-cells #size-cells can be used. The current binding can be deprecated 2) Leave as-is and accept the difference I don't have a strong opinion on which way to go. Whichever, it would be good to write down the rationale in the commit message of the "future" patch. I would not block this series on the renaming for existing property (what matter is the new ones are consistent with the discussion). The renaming could be done afterwards. I would even say post the feature freeze on Friday because this could be considered as a bug fix (assuming you agree as the release manager :)). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:10:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:10:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401844.643793 (Exim 4.92) (envelope-from ) id 1oVvlE-000630-Ob; Wed, 07 Sep 2022 14:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401844.643793; Wed, 07 Sep 2022 14:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvlE-00062t-LF; Wed, 07 Sep 2022 14:10:36 +0000 Received: by outflank-mailman (input) for mailman id 401844; Wed, 07 Sep 2022 14:10:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvlD-00062n-LK for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:10:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvlD-0007HR-4u; Wed, 07 Sep 2022 14:10:35 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVvlC-0005Z9-Ut; Wed, 07 Sep 2022 14:10:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=+Z2DMwkFJM9om9r+RdWsRVQfrxklIv4IIiveJ7fJ/yw=; b=J9oXjK/AeFI5K/xxyurJysmvGo 8ihdKsaU/l3EQ0UN+bZuvJJqb92pU4kI8YGp0nYI8U1kekDFewoPXnfJzPBB7WT3L25Q6CuF602Ds MBwBZjQmL3LgAsKJ23W+TO+rnZVfPlC2yPQylTu7LxIUHKoKMqd9NUAQl9fc7BwY2jXs=; Message-ID: <885dd861-0596-adbf-0bd6-8634f207009b@xen.org> Date: Wed, 7 Sep 2022 15:10:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US From: Julien Grall To: Henry Wang , Bertrand Marquis , Michal Orzel Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> In-Reply-To: <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/09/2022 15:04, Julien Grall wrote: > Hi Henry, > > On 07/09/2022 14:49, Henry Wang wrote: >>> -----Original Message----- >>> From: Bertrand Marquis >>>>>>> But in any case we should only add one pair here for sure, as you >>>>>>> say >>> the >>>>>>> only implication is to add a couple of 0 in the worst case. >>>>>> I agree. The only drawback is the need to modify the already >>>>>> introduced >>> properties >>>>>> to be coherent. >>>>> >>>>> Agree, someone will need to do a pass on the whole doc which might be >>> easier with all things in. >>>>> >>>> Well, not only docs. If we decide to use a single pair of >>>> #address-cells and >>> #size-cells, then >>>> we need to modify the code that expects different properties e.g. >>> xen,static-mem-{address/size}-cells. >>> >>> Right I forgot that some parts are already in. >>> So we will need an extra patch to handle those. >> >> I think I've addressed all comments from Julien regarding my series, > > If it is not too late for you would you be able to resend your series > without the 'address-cells'/'size-cells' change? This will give me the > opportunity to have an other review today. > >> so I think I've got some bandwidth to do the clean-up patch tomorrow >> after the agreement, unless someone would like to do it himself? > > Renaming "xen,static-mem-..." is a bit tricky because they have been > defined in Xen 4.16. > > I couldn't find any support statement specific to the static memory > feature. So it would technically fall under the "dom0less" section which > is security supported. > > That said, I don't think we can consider that the static memory feature > is even supported because, until yesterday, the code wasn't properly > handling request to balloon in/out. So I would view this is a tech > preview (Could someone send a patch to clarify SUPPORT.MD)? Ah. I was using the 4.16 branch. There is a patch for 4.17 to confirm this is tech preview. I think we should consider to backport it. Stefano can you add it in your backport list? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:15:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:15:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401851.643803 (Exim 4.92) (envelope-from ) id 1oVvpX-0006ft-Aa; Wed, 07 Sep 2022 14:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401851.643803; Wed, 07 Sep 2022 14:15:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvpX-0006fm-7H; Wed, 07 Sep 2022 14:15:03 +0000 Received: by outflank-mailman (input) for mailman id 401851; Wed, 07 Sep 2022 14:15:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvpW-0006fg-27 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:15:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 74d3def5-2eb7-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 16:14:59 +0200 (CEST) Received: from DB6PR07CA0181.eurprd07.prod.outlook.com (2603:10a6:6:42::11) by DB9PR08MB6540.eurprd08.prod.outlook.com (2603:10a6:10:260::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 14:14:51 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::f) by DB6PR07CA0181.outlook.office365.com (2603:10a6:6:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 7 Sep 2022 14:14:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 14:14:50 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 07 Sep 2022 14:14:50 +0000 Received: from 4c41b67a78e3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E65BE13-518F-406C-8E36-A46A8B803B1D.1; Wed, 07 Sep 2022 14:14:40 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4c41b67a78e3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 14:14:40 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB5585.eurprd08.prod.outlook.com (2603:10a6:20b:1c5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 14:14:38 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 14:14:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74d3def5-2eb7-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ppo5U8i4vs9UYA2NvdxyMwskAnWm1MKb6zzGCXfAwP3dtqEXkaq6z5X0QfMK/lpXAzn0Li3fru6tLKjmt0STkhPtzSxX8bY4PbeRoCtVN96+RHGDaTmHRv/lUrH/IChb1yqR1rzud2kvF+VsNQgRITAWOAbjsrK4y3YWySt7RSHPJxDHcmM2z3rUpYfjpoxh2NHTM4IwbJpcG2xVCKHQ/ovU7GPMKigJq0xrcN9+dcHr2ihz+Yer3YEttik7uPS9+DyOVTJS3i3qB3FU1Vvm6+NKhZ1A6fLOeYTnRWvg9gHO1CuL/184KNfa56cwP+DFB1UUI7plVpLRGnQZaIQBxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+rW06Bc/e8+mEo4JxNKnPJ8HhgaDxkvBL1xipYJkYhk=; b=NElo8s1zSyArBUAkidHYF1doQ/3SPPm4FscBDSmiDudD8LcSFru/xPywwVfHTkFkhf1w7mVflU1/S4ljrWZfc673ipyAdvQn7nXQsdOqDStkG9ayn/p8uiOICoteo2JRIAG95zu0bv5z6SF5//5KUUC65UvatsFMuiFTPGDH6VzkW0IqDkCd2iWo4Q1Tm5acHsVS+/lPGO0RSX85OFkFDylAwpC8MF26HZ8246U/4YTgRkbsajcPWc81aJdWEo4AbYDzZATuhtnTwxvA0Hk0Owhc60LoGz7USI7kMEMa+B+AMPeTgrOohZ3HYB8QZ0c7E2EDckGWb+vB/iM3SorwCA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rW06Bc/e8+mEo4JxNKnPJ8HhgaDxkvBL1xipYJkYhk=; b=17fJ02mfrrusMFxvslzSclxHiEOLMQt7H03P+hXnr1jUisCM7OAGND9at6P0g2Lf4xWVLXOrs2LdLnQbxMEjRLvACMjeIj4nIyiZiPptLEUVj3mxSGjeK+ZRK2nUkALYdvhyJDOxtaoeN5PEA3UT/GSBOrFWljXhW8dmhMVJdYI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NLUdIr/caR52ts9PcjP1m00OTRIoeJr7B5m5sClwGADh95lYzsfVrjPwlcRKMXWHHpxOwE8RsRa7g3jwrH8LgAKqJIbspmd2rdwZ4m3qY2KlDhPCUzw/j9WXQXgACzHQnovyJnIFRKRE8AZ8DkBYzN0al7Zl1Y3biwTj4VP14gaB0FQNEO2RTQRDhqZePewcJi4isNfsEv7Ca1ckJdlBwhpw3+d8UFe2yc52VU0l/Fl0zm297Bzv5IN0oxe7zHp8h0CKHmHMImWmXJi1dtE7PNNlde19hbIvRrFAhiHo30XkjmgXxkloyOm3tlaA68yHa8rpdthZA6JHoX3uw2egCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+rW06Bc/e8+mEo4JxNKnPJ8HhgaDxkvBL1xipYJkYhk=; b=OxVJCzKSJjys4CNuft7neg7otj4bw+steiE2iBXJMMtMHA7KIwGQeSHtz2s5qT1FCxsTXQA1ujFm7bowPypCX0gxe03X3APa7EGkEY3TXMfFnJv8WCBZAR3F3WNagQhiH0km/JWeCoTtweW8aHO9RVN4M8QRtM+XTC9tUQy6qb3tl8rhf2VaPFZC9ENmtbcNv6fupTZKwkt8GrWnHOxL0EJn8RMkt6CoRY6cklZLO6Vd4W+Z6zKQtE0wIiMxNhkfLoSiLYUJnxgCcYNaR/R6IzyjZe5FgP+YYDWz1IELwSwRkV1dN4QwrOVQjgX4/DxDOI3J5EIUTkJM6xPAy7toVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rW06Bc/e8+mEo4JxNKnPJ8HhgaDxkvBL1xipYJkYhk=; b=17fJ02mfrrusMFxvslzSclxHiEOLMQt7H03P+hXnr1jUisCM7OAGND9at6P0g2Lf4xWVLXOrs2LdLnQbxMEjRLvACMjeIj4nIyiZiPptLEUVj3mxSGjeK+ZRK2nUkALYdvhyJDOxtaoeN5PEA3UT/GSBOrFWljXhW8dmhMVJdYI= From: Henry Wang To: Julien Grall , Bertrand Marquis , Michal Orzel CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gIAAARoAgAACMwCAAABysIAABM8AgAABvTA= Date: Wed, 7 Sep 2022 14:14:38 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> In-Reply-To: <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F0EEEC8FBFE0DC47A65A7FF73396C921.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d27804c6-cbd4-4c03-c08e-08da90db541c x-ms-traffictypediagnostic: AM8PR08MB5585:EE_|DBAEUR03FT036:EE_|DB9PR08MB6540:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PH3Mxo/1Ur0Iqz4phAdKStaYAPfok+FmhGKcEkUwlPN/Ryl97GAV3nhyDpRr5FWTsH5RbIVq1UPk5ydkk5qn4IMT0Vwi1TNIrjdwzNfZ6tiX9j+M/G+ehERo246ysp4R7iBzf0UpUObqDt1YTVupJTX9LKZUSsm6fPeZyFtQYB8RNvm+EMctsNuftjvhaol17vGIO0ENJp49vIetSN3xs+K/dmBLXzW5ngush1Rel0mRKZKCZWYkhUT07pQECbGRJwu6V2v8ghYkxfIpr2YAnXwwstXxun1RS74VQAxjhVtMZ/7nCeBxMMd4hj9gMsfxNfhmpnPZxyqEzb7q8NmT+wO5/7jFjsJkpp0ffzPiU63o71ltYnHpnVnP+JYbIwwyGisbqFAG/bB4pJBLYZZKk0TREVZM1snJzC/0znTQK8cASTUsRGSo6DEyQqRe66hRkb9vawIPQ6ytRU0IaOThQXHRAkvIMdXgDnVcVtNuTcIGBRjlJHeeZ1mmxs/abqVxH/9Xzu2NMTF+1djtFpolr2jLvOJ1DoX1KOXIjG0uQRp9T0y9zkZu5gmfzcO8YO6Ef/2FpDz6st9rELOA2dqlbX1po6L+G9VTIsdqa1c2Sg4w7E+0W3xOObEb7vg4XOIWkpevAmZr0jTTvOm9FBN1s+wHDU7rivKnOwGsQ3WCK/89QS/Rq23bl1qRQcjtzr1oqaeK2YCi7kCKOjYkHL8ypoJgtkRXDX+mSZNSY1ivBm1K7GSAqDnuC8uGFXVp7p67Gy4iZLHDJ9ArHwuRNsSjeQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(54906003)(5660300002)(71200400001)(8676002)(41300700001)(66476007)(4326008)(110136005)(64756008)(478600001)(66446008)(52536014)(8936002)(316002)(66556008)(76116006)(66946007)(86362001)(33656002)(186003)(6506007)(7696005)(2906002)(9686003)(26005)(38070700005)(122000001)(83380400001)(55016003)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5585 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2944c3c0-f436-4cea-5669-08da90db4c70 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: upAmw/YlZR9vhjJ2yTou2EfnISvoUkBbArw/TbM3gcCqYyxI/N0cyl+FU3Fe3xc5dhg4PnLy8EsNW8vtNkR92GyKTaHAsQhtw7VwQ4c1pif8ImD1dxX9zhWF1+QUM+p6t3db3SNgT+aRjTLC1fqdr5+p7NsrZrwMY3+1Efol8zb8eatGSY7iuRnx6Apc/V9ENjRolvopuE7WIurK6QTjyK9yOlzr2MCUFcO2ivfju5gjwsC5z5ZjT94GtbzHxDH11WFPdgNiYTSN5EvLvGtkjUi+hNMpZqqGIcqyfDzeq7SfPmbHxPXcLeMeVdygUiWvF0ltN3jcMigLYOzYKubwWFAmgitnLcQL7d2JPnafrwe3ssaPeABACHWw3NAFeaBpesisT5ntOwLMCUlFaBIDzew/00LgS4Fh1AUrzIRjrJ54MXwQRN8uoWgp/o9nJGdqSju35g8yjxM2JrvdSApgy7QNlAGqXOHDpxs193Jmq58Vf9PJg+9wpMLYcG2sMDWW4VrdbWiOw5DrSJG6bm3aJH/rnVcjqimRgo2nw2ZLtihrFCQHYhabJ+eaLLWef/825dvnRb/YSi43uwkaEhv0zLXS7YmxDgc4CYco8CdsYjEgykxTPqqrBZw+QQBF8TxzexXIn3PR7fScCdlfyz2A09adIq58BeP8WQuk0kEEWd97/IK0JEcWx3yuOZVO5bcLpLlVpdqHFhOHialL+vTUYPfvYv+ri6RBDdc9GL1+8TF0drQFwINYvSLFFoS9S+y7FEm9j6K8Wy0V8HQTScpNtA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966006)(36840700001)(40470700004)(5660300002)(336012)(186003)(2906002)(40460700003)(55016003)(40480700001)(83380400001)(9686003)(26005)(4326008)(70586007)(33656002)(82310400005)(86362001)(70206006)(7696005)(6506007)(36860700001)(8676002)(110136005)(41300700001)(54906003)(81166007)(356005)(82740400003)(316002)(8936002)(478600001)(52536014)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 14:14:50.9754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d27804c6-cbd4-4c03-c08e-08da90db541c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6540 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4gSSB0aGluayBJJ3ZlIGFkZHJlc3NlZCBhbGwg Y29tbWVudHMgZnJvbSBKdWxpZW4gcmVnYXJkaW5nIG15IHNlcmllcywNCj4gDQo+IElmIGl0IGlz IG5vdCB0b28gbGF0ZSBmb3IgeW91IHdvdWxkIHlvdSBiZSBhYmxlIHRvIHJlc2VuZCB5b3VyIHNl cmllcw0KPiB3aXRob3V0IHRoZSAnYWRkcmVzcy1jZWxscycvJ3NpemUtY2VsbHMnIGNoYW5nZT8g VGhpcyB3aWxsIGdpdmUgbWUgdGhlDQo+IG9wcG9ydHVuaXR5IHRvIGhhdmUgYW4gb3RoZXIgcmV2 aWV3IHRvZGF5Lg0KDQpJIHdpbGwgYmUgb2ZmIGFmdGVyIHJlc2VuZGluZyB0aGlzIHNvIHlvdSBj YW4gaGF2ZSBhbm90aGVyIGxvb2sgdG9kYXkuDQoNCj4gDQo+ID4gc28gSSB0aGluayBJJ3ZlIGdv dCBzb21lIGJhbmR3aWR0aCB0byBkbyB0aGUgY2xlYW4tdXAgcGF0Y2ggdG9tb3Jyb3cNCj4gPiBh ZnRlciB0aGUgYWdyZWVtZW50LCB1bmxlc3Mgc29tZW9uZSB3b3VsZCBsaWtlIHRvIGRvIGl0IGhp bXNlbGY/DQo+IA0KPiBSZW5hbWluZyAieGVuLHN0YXRpYy1tZW0tLi4uIiBpcyBhIGJpdCB0cmlj a3kgYmVjYXVzZSB0aGV5IGhhdmUgYmVlbg0KPiBkZWZpbmVkIGluIFhlbiA0LjE2Lg0KPiANCj4g SSBjb3VsZG4ndCBmaW5kIGFueSBzdXBwb3J0IHN0YXRlbWVudCBzcGVjaWZpYyB0byB0aGUgc3Rh dGljIG1lbW9yeQ0KPiBmZWF0dXJlLiBTbyBpdCB3b3VsZCB0ZWNobmljYWxseSBmYWxsIHVuZGVy IHRoZSAiZG9tMGxlc3MiIHNlY3Rpb24gd2hpY2gNCj4gaXMgc2VjdXJpdHkgc3VwcG9ydGVkLg0K PiANCj4gVGhhdCBzYWlkLCBJIGRvbid0IHRoaW5rIHdlIGNhbiBjb25zaWRlciB0aGF0IHRoZSBz dGF0aWMgbWVtb3J5IGZlYXR1cmUNCj4gaXMgZXZlbiBzdXBwb3J0ZWQgYmVjYXVzZSwgdW50aWwg eWVzdGVyZGF5LCB0aGUgY29kZSB3YXNuJ3QgcHJvcGVybHkNCj4gaGFuZGxpbmcgcmVxdWVzdCB0 byBiYWxsb29uIGluL291dC4gU28gSSB3b3VsZCB2aWV3IHRoaXMgaXMgYSB0ZWNoDQo+IHByZXZp ZXcgKENvdWxkIHNvbWVvbmUgc2VuZCBhIHBhdGNoIHRvIGNsYXJpZnkgU1VQUE9SVC5NRCk/DQoN CkluIGN1cnJlbnQgY29kZSwgdGhlIHN0YXRpYyBhbGxvY2F0aW9uIGlzIGluIFNVUFBPUlQubWQg YXMgdGVjaCBwcmV2aWV3Lg0KDQo+IA0KPiBUaGlzIHdvdWxkIG1lYW4gdGhhdCB3b3VsZCBiZSB0 aGF0IHdlIGNvdWxkIGNvbnNpZGVyIHRoZSBiaW5kaW5nDQo+IHVuc3RhYmxlIGFuZCB3ZSBjb3Vs ZCBkbyBhIHN0cmFpZ2h0IHJlbmFtaW5nLiBUaGF0IHNhaWQsIEkgY2FuDQo+IHVuZGVyc3RhbmQg dGhpcyBtYXkgYmUgdW5kZXNpcmFibGUuDQo+IA0KPiBJZiB0aGF0J3MgdGhlIGNhc2UgdGhlbiB3 ZSB3b3VsZCBuZWVkIHRvIGtlZXAgdGhlIGN1cnJlbnQgYmluZGluZyBhcy1pcy4NCj4gU28gd2Ug d291bGQgaGF2ZSB0d28gb3B0aW9uczoNCj4gICAgMSkgUHJvdmlkZSBhIG5ldyBjb21wYXRpYmxl IHNvICNhZGRyZXNzLWNlbGxzICNzaXplLWNlbGxzIGNhbiBiZQ0KPiB1c2VkLiBUaGUgY3VycmVu dCBiaW5kaW5nIGNhbiBiZSBkZXByZWNhdGVkDQo+ICAgIDIpIExlYXZlIGFzLWlzIGFuZCBhY2Nl cHQgdGhlIGRpZmZlcmVuY2UNCj4gDQo+IEkgZG9uJ3QgaGF2ZSBhIHN0cm9uZyBvcGluaW9uIG9u IHdoaWNoIHdheSB0byBnby4gV2hpY2hldmVyLCBpdCB3b3VsZCBiZQ0KPiBnb29kIHRvIHdyaXRl IGRvd24gdGhlIHJhdGlvbmFsZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2Ugb2YgdGhlICJmdXR1cmUi DQo+IHBhdGNoLg0KPiANCj4gSSB3b3VsZCBub3QgYmxvY2sgdGhpcyBzZXJpZXMgb24gdGhlIHJl bmFtaW5nIGZvciBleGlzdGluZyBwcm9wZXJ0eQ0KPiAod2hhdCBtYXR0ZXIgaXMgdGhlIG5ldyBv bmVzIGFyZSBjb25zaXN0ZW50IHdpdGggdGhlIGRpc2N1c3Npb24pLiBUaGUNCj4gcmVuYW1pbmcg Y291bGQgYmUgZG9uZSBhZnRlcndhcmRzLiBJIHdvdWxkIGV2ZW4gc2F5IHBvc3QgdGhlIGZlYXR1 cmUNCj4gZnJlZXplIG9uIEZyaWRheSBiZWNhdXNlIHRoaXMgY291bGQgYmUgY29uc2lkZXJlZCBh cyBhIGJ1ZyBmaXggKGFzc3VtaW5nDQo+IHlvdSBhZ3JlZSBhcyB0aGUgcmVsZWFzZSBtYW5hZ2Vy IDopKS4NCg0KQWN0dWFsbHkgdGhpcyBpcyB0aGUgb25lIEkgd2FudCB0byBkaXNjdXNzIHdpdGgg eW91LCBJIGFtIGdvb2Qgd2l0aCBjb25zaWRlcmluZw0KdGhpcyBjbGVhbi11cCBwYXRjaCBhcyBh IGJ1ZyBmaXguDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4gDQo+ IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:19:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:19:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401858.643815 (Exim 4.92) (envelope-from ) id 1oVvtg-0007Qv-Sp; Wed, 07 Sep 2022 14:19:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401858.643815; Wed, 07 Sep 2022 14:19:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvtg-0007Qo-Ov; Wed, 07 Sep 2022 14:19:20 +0000 Received: by outflank-mailman (input) for mailman id 401858; Wed, 07 Sep 2022 14:19:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvte-0007Pk-UH for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:19:19 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60059.outbound.protection.outlook.com [40.107.6.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e812a58-2eb8-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 16:19:17 +0200 (CEST) Received: from FR3P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::11) by PAWPR08MB9519.eurprd08.prod.outlook.com (2603:10a6:102:2f1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 14:19:14 +0000 Received: from VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::94) by FR3P281CA0081.outlook.office365.com (2603:10a6:d10:1f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 14:19:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT015.mail.protection.outlook.com (10.152.18.176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 14:19:14 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 14:19:13 +0000 Received: from d61f644ddd47.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9602F732-3A45-4045-A65D-B75FEE293D9F.1; Wed, 07 Sep 2022 14:19:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d61f644ddd47.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 14:19:07 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB9677.eurprd08.prod.outlook.com (2603:10a6:10:447::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 14:19:03 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 14:19:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e812a58-2eb8-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kK3CDf/NuXXDKK2hdtT6iQoXnQ30PCvNOIa9hxr6cWpYALSYv+VfZ64bvktX5ePHbvkj0lZ12Ks8N+kf11Jynsw+54KNsLKdKmaeKpLACvABgPaxy9CTCBIRCq3j/I1nHakWTvug26CGw2bHRi2td3dED1bgr0uLgvuTzQPGNr3AKYeuANUThnixjC5S4pE0dvgQdiitot5mWosLrKX2QTkQzF698wKf8eiktq4I/zyD4E16AlFR22VlxkfOINiugsRx9ptPlqe2f4nL5QgFHVZvtchOuoSN8VjpVfE/R8oXSERncS676aBSB/7J53RJkL5p00Oiovhz64K3Zq/j7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/cBNynxtWFQG6rFHdjzUL5ny1LFAiYA1K+GrixRua6E=; b=UPoq0n+vJPNUkiKo2oBe9UYt5LLQ3T8XezEC4N6932LRO8rPs+nLw4wexyFXQq3h/LfNUNzf9slIZ8qEbplr5pqWWXdRE4rn6OK9S3GtFyMky/OEHhCg8HoiG0aaI887qyQOcSW5/d+7jnaviJIQS66T8adWPX0NUyv60flYuEg+vw9TGBZ/EhtZDWEljVOi0ZMDg+ZhNUCF9VUf71deREQbEnmgbf1xMcxTajABCgwGdtl3g4U+ObcHu+EIwt77OjXn/3NCEHa6gpBazXIKSL7xStlQmp3ohBBnkz346yDUZMcmB4YriNy/10dZWwJVn0trdzV/Vtd/rvS6MlqvWg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cBNynxtWFQG6rFHdjzUL5ny1LFAiYA1K+GrixRua6E=; b=C2Yd357FgEMrHHJNez5CrmlIpGSJSc+AZ9SkQ0GEcIFPxGwwrFzOOoSmaZ98AuRPR0xxLSDk+6ZALVJoBcMfcpLpqCYrCY6FzON471xviOT2vWWU1hfXpM0FUF4cATaOgdBIQZkw4WOb34nA3Bupre4RLqWvVYV8bS18Q9vEfjA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 36f3934581f1dad3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ytg8y4OOZrPJ6aqlefv+2Xznf9MdKvaVciekEr1a/5+DMjLpweB+ynwwpSzbIPKsVrOeyMl1DL+k/7HIr6nLtTre1VShbvjRMTc8m0dCC0tQH0+EAbHDnPNtKeHIUe5wfLWUFv/BO8/VsDwl04mgtKBH14Cdj7xvY8gPYoMplgp75eq+UWQqM0Zi/zoOnsxSU3GapuMsRxlshhfP1I6A3D7DwYVrGHsMd/ffnjRFM2VdyMQ6yeJ/xDHzdkf19HzktjfoKOxmwqL2k5LsS1YErDy+W4/PpCP9f3xUD246NnAxjwFHxODLlAsPP6xvwWMDbrou+VBeI+QTdd0dX3HKHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/cBNynxtWFQG6rFHdjzUL5ny1LFAiYA1K+GrixRua6E=; b=eBoKjsv/TVlRKNE7F+us/Iut62llupTSld8rRdISQR/mICFk37Oo18TDwQ0LKrN+ONSQY4sw2Nw/PIIlT/f4vlmS8fEYZ3Yc+Y98YnUsMxNot+PUALgCiM3tlyr7PvYmEwdsF8nE7KWBqLRTsqW+4ibPBHvSnLwjSEiLAh0/z2YJOfJqBd3N09B60P9C6S/tVsMzDGJIUxE6Fij2AgdHFbzMLlhuJcw09yrLGWqIdZ+CpquzGgXhg0ZwDofS9v4Ny4jL80FNRkyi6jIigGs2c/FymVjKIzkRE4ACFEkBY0S6Q6u36g58j1j0KDrW+bRaP7fNyF8M08JKPdTiXAnqXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cBNynxtWFQG6rFHdjzUL5ny1LFAiYA1K+GrixRua6E=; b=C2Yd357FgEMrHHJNez5CrmlIpGSJSc+AZ9SkQ0GEcIFPxGwwrFzOOoSmaZ98AuRPR0xxLSDk+6ZALVJoBcMfcpLpqCYrCY6FzON471xviOT2vWWU1hfXpM0FUF4cATaOgdBIQZkw4WOb34nA3Bupre4RLqWvVYV8bS18Q9vEfjA= From: Rahul Singh To: Julien Grall CC: xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value Thread-Topic: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value Thread-Index: AQHYwfap3Ps5bdyrBEC9qTgdrU+ZKq3T8h2AgAAThAA= Date: Wed, 7 Sep 2022 14:19:03 +0000 Message-ID: References: <667059a3bc6ed9a8b993f64f2b1176a2a131f41e.1662462034.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9a37136d-b53e-4acc-5c0c-08da90dbf102 x-ms-traffictypediagnostic: DU0PR08MB9677:EE_|VE1EUR03FT015:EE_|PAWPR08MB9519:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ExgSsYAGS777+6SuPh58Xlajyi0TwR72T4HatD5YjScBopRGr/zzacFyN+yF+7EALquye71z9SbHXUcvzdccAH5sYiGvALnCuOYrJjyMgpC+nCnjKEvG88GZimVcIe2YamowlkdoOirxJGCKS7OZHl8NMpTeh5/g1BYxS1FLr4RI6R4+sr+L3SpV8a3Qi3HOJby3WWk1Jo3Arf5mqvxDxJbKmNBaJdQS7+UuCVNVTPM0suUBuC0sqUbR91XXCIfRf9kZgr4W2RMD1lT9fVoA8K1S6b0AO1xb8yWUPobisyGx1m50MLTkk2UQYhDkix9VMfBS7SrQ8dkOxqGBmrbTebpbHF/ubUk89s1DfExA4sljRr0Fq4S5Hdtf4EMGXywUheaw7hTaUAnWkzHG6NPg3BszkW+IhdI6t8pIbqlP8T7yti5ZjBYlyUTTeBB1mBUNgZ02FrckkhWc6bhfP/FiF7X2omyxrzLLvLvYYNerRaEAQpdkTbsCzQbZIy75xBmM5mw3lOaDt5AlXCF/Q5kUEP6H809CGULb3KJH5a8JJUFpwx3fvNWVTd3O2ajdfsNf72Pxp633ZbYb6Nq5+claiLsQSAy56xBo5/DJp2K/2MtieaIkxfsM+Hh/pfXn2LncVyRK5K1eHDa6p/hDoM0/gBf4ZO5Ekg7tva+sTCwyrHGFNRLoScaaOYwO/1Tz+CNCWyRrkEiL2KBytIdCDBObTeatOCoUV8DNlRbr16Z1o9Sx0ik6P8TOJmjZFE28Tx8+xQqv7TFZ1yuS+TQQMDiX5ULYZBMHGtxb7E/uvgP8XD0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(38100700002)(478600001)(2616005)(6506007)(2906002)(122000001)(71200400001)(186003)(36756003)(5660300002)(33656002)(6486002)(8936002)(8676002)(6512007)(76116006)(54906003)(86362001)(66446008)(316002)(66476007)(38070700005)(66946007)(91956017)(64756008)(66556008)(4326008)(83380400001)(26005)(6916009)(41300700001)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9677 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ee4508c-202f-48e2-a7a4-08da90dbea71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Agr/ApXsDoa/iCWEsrePXb4W/BpRImWlXo3Rg0lIaNpTI9zsw9aOhRzL6OC2uKHUpmc1EMTJdwN11U4sEjy151rlcNfZ6jmU2Th9zCDz4Wv06xPWfFclwrbtb+F7cvTiftdUe68cf7SEQ0GuKGYgso6jPukVWMhYvsR0fMwQol5BScIl0tCZuL64ntRKT6eDs3SnF8aabkCWillAtUisClFPi5x8Rf0UFvKho0CbuXZg49VXcnSATb09fJe90F6nqV21lVmWpj/Np4kjdZdY+RI7wWQW60uJ5Mhy4EvEUxEkqgLyEpANt4WTNOihvvmVaenb5DUGP6Kkzdr83DZAaYy61q2vuO/OytrJwO8hrUWbvQ82RddMHy3kT4d1QzwA5Np2l5RS1bLXRoSqpWmO3tpQgS9313S4zOX6BrI5CT1kZgDTyeOKVGoEflilcvUYlLVqbSAOFZRYahCe1t6intiCNaj3vy23Pv3KUa3yQwKF5IIoZHNL+CKkPSKfXJV5Jgp9WJCXfsXmLneFVuzsr+H3PFBSaftBFZSHFr+x68+P+kZomQP2L68M8r7/538EwrpTfYN6GfXqfi4odnz1WTaPO9Wg562jx0U/QN2A/cNXnOwrDCXNLwvJ2/2a0G/SRQyuDq5L4L7ZxrBjrEbfdEZFaPhe6MzUYYlQ0vq0EvlHlZQA0RLvyefFJORDztxuHH/DdFZzHPuoeC0oDrz78BmgnbkMDufBYpg+rTVE2OM6dtUhysrR/XytP3zaUpCs82EYiwTAEEvfcFUsTXuPpw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(46966006)(40470700004)(36840700001)(356005)(82740400003)(83380400001)(40460700003)(36860700001)(2906002)(81166007)(8676002)(70206006)(4326008)(316002)(54906003)(82310400005)(70586007)(8936002)(40480700001)(6862004)(5660300002)(6512007)(26005)(336012)(2616005)(186003)(53546011)(107886003)(6506007)(6486002)(47076005)(41300700001)(478600001)(86362001)(36756003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 14:19:14.0954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a37136d-b53e-4acc-5c0c-08da90dbf102 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9519 Hi Julien, > On 7 Sep 2022, at 2:09 pm, Julien Grall wrote: >=20 > Hi Rahul >=20 > On 06/09/2022 14:40, Rahul Singh wrote: >> Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to >> disable xenstore interface for dom0less guests. >> Signed-off-by: Rahul Singh >> --- >> Changes in v4: >> - Implement defines for dom0less features >> Changes in v3: >> - new patch in this version >> --- >> docs/misc/arm/device-tree/booting.txt | 4 ++++ >> xen/arch/arm/domain_build.c | 10 ++++++---- >> xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- >> 3 files changed, 31 insertions(+), 6 deletions(-) >> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic= e-tree/booting.txt >> index 98253414b8..1b0dca1454 100644 >> --- a/docs/misc/arm/device-tree/booting.txt >> +++ b/docs/misc/arm/device-tree/booting.txt >> @@ -204,6 +204,10 @@ with the following properties: >> - "disabled" >> Xen PV interfaces are disabled. >> + - no-xenstore >> + Xen PV interfaces, including grant-table will be enabled but xensto= re >=20 > Please use "All default" in front. So it is clear that everything is enab= led but xenstore. Ack.=20 >=20 >> + will be disabled for the VM. >> + >> If the xen,enhanced property is present with no value, it defaults >> to "enabled". If the xen,enhanced property is not present, PV >> interfaces are disabled. >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 707e247f6a..0b164ef595 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *= d, struct kernel_info *kinfo) >> goto err; >> } >> - if ( kinfo->dom0less_enhanced ) >> + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) >> { >> ret =3D make_hypervisor_node(d, kinfo, addrcells, sizecells); >> if ( ret ) >> @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *= d, >> (rc =3D=3D 0 && !strcmp(dom0less_enhanced, "enabled")) ) >> { >> if ( hardware_domain ) >> - kinfo.dom0less_enhanced =3D true; >> + kinfo.dom0less_feature =3D DOM0LESS_ENHANCED; >> else >> - panic("Tried to use xen,enhanced without dom0\n"); >> + panic("At the moment, Xenstore support requires dom0 to be = present\n"); >> } >> + else if ( rc =3D=3D 0 && !strcmp(dom0less_enhanced, "no-xenstore") = ) >> + kinfo.dom0less_feature =3D DOM0LESS_ENHANCED_NO_XS; >> if ( vcpu_create(d, 0) =3D=3D NULL ) >> return -ENOMEM; >> @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, >> if ( rc < 0 ) >> return rc; >> - if ( kinfo.dom0less_enhanced ) >> + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) >> { >> ASSERT(hardware_domain); >> rc =3D alloc_xenstore_evtchn(d); >> diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/as= m/kernel.h >> index c4dc039b54..ad240494ea 100644 >> --- a/xen/arch/arm/include/asm/kernel.h >> +++ b/xen/arch/arm/include/asm/kernel.h >> @@ -9,6 +9,25 @@ >> #include >> #include >> +/* >> + * List of possible features for dom0less domUs >> + * >> + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. = All the >> + * default features (excluding Xenstore) will = be >> + * available. Note that an OS *must* not rely = on the >> + * availability of Xen features if this is not= set. >> + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This f= eature >> + * can't be enabled without the >> + * DOM0LESS_ENHANCED_NO_XS. >> + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. = All the >> + * default features (including Xenstore) will = be >> + * available. Note that an OS *must* not rely = on the >> + * availability of Xen features if this is not= set. >> + */ >> +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) >> +#define DOM0LESS_XENSTORE BIT(1, U) >> +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XE= NSTORE) >> + >> struct kernel_info { >> #ifdef CONFIG_ARM_64 >> enum domain_type type; >> @@ -36,8 +55,8 @@ struct kernel_info { >> /* Enable pl011 emulation */ >> bool vpl011; >> - /* Enable PV drivers */ >> - bool dom0less_enhanced; >> + /* Enable/Disable PV drivers interface,grant table, evtchn or xenst= ore */ >=20 > The part after "," is technically wrong because it also affects other int= erfaces. But I would drop it to avoid any stale comment (we may add new one= in the futures). Ok . I will remove and will comment like this: /* Enable/Disable PV drivers interfaces */ =20 Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:20:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:20:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401866.643826 (Exim 4.92) (envelope-from ) id 1oVvuV-0000Oo-8Z; Wed, 07 Sep 2022 14:20:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401866.643826; Wed, 07 Sep 2022 14:20:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvuV-0000Oh-5b; Wed, 07 Sep 2022 14:20:11 +0000 Received: by outflank-mailman (input) for mailman id 401866; Wed, 07 Sep 2022 14:20:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVvuT-0007uj-Pi for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:20:10 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2071.outbound.protection.outlook.com [40.107.105.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d2405b5-2eb8-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 16:20:08 +0200 (CEST) Received: from AS9PR06CA0638.eurprd06.prod.outlook.com (2603:10a6:20b:46f::32) by GVXPR08MB7845.eurprd08.prod.outlook.com (2603:10a6:150:1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 14:20:02 +0000 Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46f:cafe::c7) by AS9PR06CA0638.outlook.office365.com (2603:10a6:20b:46f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 14:20:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 14:20:01 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Wed, 07 Sep 2022 14:20:01 +0000 Received: from 1881cc794703.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7322573F-9E3D-4831-83C6-E4EB0F506368.1; Wed, 07 Sep 2022 14:19:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1881cc794703.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 14:19:55 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB9677.eurprd08.prod.outlook.com (2603:10a6:10:447::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 14:19:53 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 14:19:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d2405b5-2eb8-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=M8DSte33ztEPXLgGDNS7YUyHTdwFex1Zx0maPW/TqweIjPVP6r874+wnBTXtfpDBdDk+3sMV9BNoa9b41HegGDtpew6iqsLA0Nk6dt3XPMRubYvDIeqocV9xN5yX5/FhFJGO5hDBGkqxszHF+fz3GU9UB8pgvjshdEXyVA9DSsDtb7FP8s6afscNSJEePJazpuyFbMkCIfSNf5EJJxiS+7fefVkuRsD67Hg2T8Tdyin0D5Ray00WiuwvyOcO4Kk9fR4+BFQn0LJZqTs7Rf6vbVwl4PtyS9MiXKa+kMCrdSJMEcapIMIypzNZxGs71wO3SW65ttvf/y6MjBHvqnvPUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F/xmVarc3mVjKi/yTFB1/8kMWsZEvWKR3MJPbRbJ9pM=; b=UC1N41EUudk3+U46JIL7No6KKnBaCYpQgyLqzmjf7osbKxpqicvQKWsjoGR7BcpYPDwrcgFk9oFHVqzSHOfEd0zr2+scn3S5hieCo8+9QJ0sI+iO7sBCQLuLqWYXrASqee2DfzixChC/41mducfGxRtCyzphUuUVFeqZlcTA1RY1k2Jpe6pwZaXO+dVo1wdFrXpVgXw0yEs2bSctyPbTley1LqO3ej9UG/2aDQCJ/xUXJxM0WVWrOC+EZgnbMI9a+9Zji72cYAEUq/W64UDK/ci4rlrfQOyKzzEfCwpAHdJHesi2wUiYCNXKsxd/NEZmttqF3wB000l/d9vYawz6Qg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F/xmVarc3mVjKi/yTFB1/8kMWsZEvWKR3MJPbRbJ9pM=; b=fxnrUs7lIvrMsUINBqU/Y6iz+Dsyt0bhJ4ehPuty35jq19rViLxIrV4tT1rEdBjAT/+cVp4EfTWhFVZ9EbBXbBeuI0MRf/lQul8ZfHwFns63Riyzs3Q8wJ7C8AliIAkn6/APxgJ48m71a79+jka+wbfM8VAKEQ1IrNC5ynTKXFg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6da7f19e400647cd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kUoxaTRT1LFmW4OlYWLqqpbMD66Mld69Lu5u6AMXOZzRcRcIE3DWVHkbH9uuvk9MpAOTkZ5mqX9jxnlISlyo6nsUCAdimottRq5hG8+OctZqHBlTH+unvMUxuG+mCp5GK9wxGK6v+FgfGPnoORGgIlbAZ9oc4LpHOSmnKPm9sB6M5TAbky6Ze26Miyd6F2agw0oHjG7J7Flwe/+wKZ5fp+8TeR91NIPtM8YSAPPoi8z6V4pfBpyInsbsDYzSYajKTvKgNJJbTqReAmIbWFjVpk1SwE7VsuSu2CmlUUC/jAQ6rb2Uzh4vmEpQmWddJwveUsxbDLtTBHPzdsILEXnvJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F/xmVarc3mVjKi/yTFB1/8kMWsZEvWKR3MJPbRbJ9pM=; b=XZH2cDqqtrM4phXohfDVXUO4Hc5QF9AkkDQS6PtICNvz2ZHOFJlSCq5I/ZvkygQMq7Xa4AIr2v+sAwzlKtObfEOZ1+1IcBV6htsdlb2ZhJMYlpAqpYlHH1LNmOw+NWtMzQNrFv9QV4oixf4PeeT5CC+W2ROm+TmU013goYSPaxlz7fFX1iGVnzj29Ec8BgeCTXS2El1Gay+wa2QRnqbMeucAPz25puWZIU71Q1OxnnUCjm27eqy+QgHxxR1B043PtEg79/+0z3SUYU/PlI4dwSQbvCIK9tFZUDbbesNDvFQnnWWTdXMI+mT0pA176B0l2p7Ia35Y+uQ4R2QcahsZhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F/xmVarc3mVjKi/yTFB1/8kMWsZEvWKR3MJPbRbJ9pM=; b=fxnrUs7lIvrMsUINBqU/Y6iz+Dsyt0bhJ4ehPuty35jq19rViLxIrV4tT1rEdBjAT/+cVp4EfTWhFVZ9EbBXbBeuI0MRf/lQul8ZfHwFns63Riyzs3Q8wJ7C8AliIAkn6/APxgJ48m71a79+jka+wbfM8VAKEQ1IrNC5ynTKXFg= From: Rahul Singh To: Julien Grall CC: xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel Subject: Re: [PATCH v4 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Thread-Topic: [PATCH v4 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Thread-Index: AQHYwfZ0FAeUK0FPYE2nPRBk38a8ya3T7+AAgAAV/QA= Date: Wed, 7 Sep 2022 14:19:53 +0000 Message-ID: <0C5BAC50-B288-47CC-93FB-31B03BEBBFFC@arm.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 80ee0eb5-e6fc-4a87-f2fa-08da90dc0d2f x-ms-traffictypediagnostic: DU0PR08MB9677:EE_|AM7EUR03FT033:EE_|GVXPR08MB7845:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QmkJbSaFr0btTA2ZYUtsFbJDTRbYqRTtBJPcbMreJcFxkZodP6tMYvinvtHzpsXaiOKTGmWJhVUEUsTT51F9Bh2okEtO1SygycKXYSviJVr+kjz+T+KMOjyL0Bq24Vz8zvu53O27wAvGhc0ci+gBcBSMv1w0ax7HjPl+pyLVU3EPYELjm2HJ9CT+KXpH78VXhEi91SJgY/KbZEzOcyeuph886pugXVlv6uLNmo/gjjyxyG8Qb104T4x0q6SKoU/SMrsNzEo6K2mDMQ3TaCXcoGnMk6sd8AgxQDVNlkdrPTwgSQiz0wcnDt+nV7d4s3MdH0jb8b1X74OulkFXJB+8UPDCAYo+c17KTrVrUdI7s9kGWla1R43y1K1EPS2w13nm/0tztZvBG71OnmHUQ15Aila14a+OH36NTdnUyoEYmsTA1YBsriqXEqW1orUy942y40ASIP8rz2ogUXfJqBcBWX6iLMuvoXaSLnxsgoz45sE2RSUiYUadw3zd6I0l6WYMoJkDI+c2x+Vva21rYaSGJSkoqI3MZNJ+EXsGrplAUwXyxgyI5eumaagf8JZ55TaeFqHRcOohuktDIXs/c+/53XljQvZLHGEEJAbilRH24Xc4WJcPc9WbBr7sGrL+c2lV5rzlLqUJOHGE3qJRJr9DA4LhUykD4c15q5u1znyLDlfeRa80BiwV1mnngDZlZCwMQ+7hCiydbp8JTzzmt5nVhaBhK8Yz2OlXRUc9I8APADk5OteBXPjLKpjc8bD5BFurfYrQr3sfncFEpjTSAUO0u8RNHE9c/crJr7Q9oEHRiH4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(38100700002)(478600001)(2616005)(6506007)(2906002)(122000001)(71200400001)(186003)(36756003)(5660300002)(33656002)(6486002)(8936002)(8676002)(6512007)(76116006)(54906003)(86362001)(66446008)(316002)(66476007)(38070700005)(66946007)(91956017)(64756008)(66556008)(4326008)(83380400001)(26005)(6916009)(41300700001)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6D66ACF5B0592246ABCB5218CC544DDF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9677 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6533db66-2aaf-4a8b-ccbe-08da90dc0847 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kW2CLgr5TVg41TYcmyeO3NJeqRy6nvvcTOQndCMeLNvwguGbPbc+ZlLMYqKFZI4eB7Mo+nO5npXQn33Hc6l49RIXs8wz4dG732YdI/uQ7b2J1MRZ7a+e5hb/VjnfTqHWNAWAPwHSogV8ME6mAZTgt574fogM6t14Jvuaa6N5q1GlaIWKg+Mgy2XzCgOlJIkJdiX12p1118cKCDMiTpmFdAAPeg3yNCq2Z7DAWm/wVPtf5z0T3ND+xESWdTKgNQZCU7IsfjX76Nk7jlQrCpHKffVMXa+7rKBZN3h3nBOJz2eDn5QDHzqfpapK0ZRPBnOWpsWH/tqF3VAtwnpjZal+lq1kCu1wVlc7DtNkiK6Elmbd4zNZ1aRiSQQmbOAT1LgAj4lst8laV5KEU1VnkCOrMRD+IRXsjIw74umt4+c351r4wGJVVae3aSeGtO0c183Cm3+g+rFywf+EqBeph5NleO8TJriw3cYMbOF9Ey4SxgEDkfU7iuNH4tx1YbcaeDobSxfIk9IDzARKMOrh6C61rK8eyK+c032XaS7hAr4bKOQrba7LuWXztR5/2nK+QGbYpqgIsKv9xBkllbScn07bZ5Ur1ltMxPGD2LeyaLOqh0uCiUD+oLZbO+KYHkaF0SOSB06kC+t4tXxbr8oi5bBABzssfZl/k3Ddul60yuxjv5wbatbPxZ2IJ+8TaC+Jf3UuBWnCYlsCnMhS+HBSBpz+bSIgEYum/jWIHtTG/99Q28R+9m6/odi3rOT0CRMR8+YvsE2WatcFNmfgWszwNoWmWQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(376002)(396003)(36840700001)(40470700004)(46966006)(6862004)(70586007)(2906002)(4326008)(8676002)(5660300002)(8936002)(33656002)(40480700001)(54906003)(316002)(82310400005)(6486002)(70206006)(36756003)(478600001)(356005)(336012)(26005)(6512007)(6506007)(83380400001)(47076005)(2616005)(81166007)(40460700003)(86362001)(53546011)(186003)(82740400003)(36860700001)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 14:20:01.4172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80ee0eb5-e6fc-4a87-f2fa-08da90dc0d2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7845 Hi Julien, > On 7 Sep 2022, at 2:01 pm, Julien Grall wrote: >=20 >=20 >=20 > On 06/09/2022 14:40, Rahul Singh wrote: >> Restrict the maximum number of evtchn supported for domUs to avoid >> allocating a large amount of memory in Xen. >> Set the default value of max_evtchn_port to 1023. The value of 1023 >> should be sufficient for domUs guests because on ARM we don't bind >=20 > To me, domUs and guests mean the same. So s/guests// Ack.=20 >=20 >> physical interrupts to event channels. The only use of the evtchn port >> is inter-domain communications. Another reason why we choose the value >> of 1023 to follow the default behavior of libxl. >> Signed-off-by: Rahul Singh >> Reviewed-by: Michal Orzel >> --- >> Changes in v4: >> - fix minor comments in commit msg >> - Added Michal Reviewed-by >> Changes in v3: >> - added in commit msg why we set the max_evtchn_port value to 1023. >> - added the comment in code also why we set the max_evtchn_port to 1023 >> - remove the define and set the value to 1023 in code directly. >> Changes in v2: >> - new patch in the version >> --- >> xen/arch/arm/domain_build.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 3fd1186b53..fde133cd94 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3277,7 +3277,13 @@ void __init create_domUs(void) >> struct xen_domctl_createdomain d_cfg =3D { >> .arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE, >> .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, >> - .max_evtchn_port =3D -1, >> + /* >> + * The default of 1023 should be sufficient for domUs guest= s >=20 > To me, domUs and guests mean the same. So s/guests// >=20 > Same here. With that: >=20 > Acked-by: Julien Grall >=20 > Cheers, Ack.=20 Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:33:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401882.643842 (Exim 4.92) (envelope-from ) id 1oVw7I-0002JR-Ed; Wed, 07 Sep 2022 14:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401882.643842; Wed, 07 Sep 2022 14:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVw7I-0002JK-BX; Wed, 07 Sep 2022 14:33:24 +0000 Received: by outflank-mailman (input) for mailman id 401882; Wed, 07 Sep 2022 14:33:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVw7H-0002JE-Fp for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:33:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVw7G-0007fr-Hc; Wed, 07 Sep 2022 14:33:22 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVw7G-0006Zf-9S; Wed, 07 Sep 2022 14:33:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GzRsaXTSpwLy/Adbvnszg+L9jECCkvffHW40vZ9b+VM=; b=AsNNSX3kQyxMDPk2wdssDr1j8h WYyR5GAjDNII4j8BhX1GYcwf3n/vDZoy8YGBf3IoPmyCIhRq5TidHbZ4dnKNSSNj6Ito4ow8BmIXi rdVu/C91h4KcJl3yJolwzfUmICHY/BYoiaciPtPMpMPVMIkghUlzn7ZEtj8px749nCLg=; Message-ID: Date: Wed, 7 Sep 2022 15:33:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard , Bertrand Marquis References: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> From: Julien Grall In-Reply-To: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 25/08/2022 08:17, Jan Beulich wrote: > I haven't been able to find evidence of "-nopie" ever having been a > supported compiler option. The correct spelling is "-no-pie". > Furthermore like "-pie" this is an option which is solely passed to the > linker. The compiler only recognizes "-fpie" / "-fPIE" / "-fno-pie", and > it doesn't infer these options from "-pie" / "-no-pie". OOI, how did you find out this issue? > > Add the compiler recognized form, but for the possible case of the > variable also being used somewhere for linking keep the linker option as > well (with corrected spelling). > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:36:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:36:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401889.643853 (Exim 4.92) (envelope-from ) id 1oVw9w-0002tm-SX; Wed, 07 Sep 2022 14:36:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401889.643853; Wed, 07 Sep 2022 14:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVw9w-0002tf-PI; Wed, 07 Sep 2022 14:36:08 +0000 Received: by outflank-mailman (input) for mailman id 401889; Wed, 07 Sep 2022 14:36:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVw9v-0002tH-WE for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:36:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 677078d5-2eba-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 16:36:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B2A81042; Wed, 7 Sep 2022 07:36:11 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9FB6B3F71A; Wed, 7 Sep 2022 07:36:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 677078d5-2eba-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v4 0/4] Introduce static heap Date: Wed, 7 Sep 2022 14:35:28 +0000 Message-Id: <20220907143532.15397-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU systems, where only a finite number of memory protection regions are available. The limited number of protection regions places requirement on planning the use of MPU protection regions and one or more MPU protection regions needs to be reserved only for heap. The first patch enhances the error handling in processing the dts chosen node. The second patch introduces the static heap and the device tree parsing code. The third patch renames xenheap_* to directmap_* for better readablity. The fourth patch adds the implementation of the static heap pages handling in boot and heap allocator for Arm. Changes from v3 to v4: - Change and update of wording in comments. - Add the static heap feature in SUPPORT.md as tech preview. - Also rename the setup_xenheap_mappings() function name and printed messages inside the function. - Add Acked-by and reviewed-by. Henry Wang (4): xen/arm: bootfdt: Make process_chosen_node() return int docs, xen/arm: Introduce static heap memory xen/arm: mm: Rename xenheap_* variable to directmap_* xen/arm: Handle static heap pages in boot and heap allocator SUPPORT.md | 7 ++ docs/misc/arm/device-tree/booting.txt | 48 ++++++++ xen/arch/arm/bootfdt.c | 57 +++++++--- xen/arch/arm/domain_build.c | 8 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 31 ++--- xen/arch/arm/include/asm/setup.h | 23 +++- xen/arch/arm/mm.c | 50 +++++---- xen/arch/arm/setup.c | 156 ++++++++++++++++++++------ 9 files changed, 293 insertions(+), 89 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:36:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401890.643863 (Exim 4.92) (envelope-from ) id 1oVwA0-0003AQ-3Y; Wed, 07 Sep 2022 14:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401890.643863; Wed, 07 Sep 2022 14:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwA0-0003AF-0r; Wed, 07 Sep 2022 14:36:12 +0000 Received: by outflank-mailman (input) for mailman id 401890; Wed, 07 Sep 2022 14:36:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVw9y-0002tH-3L for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:36:10 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 69880791-2eba-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 16:36:09 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95A35106F; Wed, 7 Sep 2022 07:36:14 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3F8B53F71A; Wed, 7 Sep 2022 07:36:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69880791-2eba-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 1/4] xen/arm: bootfdt: Make process_chosen_node() return int Date: Wed, 7 Sep 2022 14:35:29 +0000 Message-Id: <20220907143532.15397-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907143532.15397-1-Henry.Wang@arm.com> References: <20220907143532.15397-1-Henry.Wang@arm.com> At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error type. Signed-off-by: Henry Wang Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from v3 to v4: - Add Reviewed-by from Michal and Acked-by from Julien. Changes from v2 to v3: - Adjust the order of this patch, make it the #1. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..1a79b969af 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -293,9 +293,9 @@ static void __init process_multiboot_node(const void *fdt, int node, kind, start, domU); } -static void __init process_chosen_node(const void *fdt, int node, - const char *name, - u32 address_cells, u32 size_cells) +static int __init process_chosen_node(const void *fdt, int node, + const char *name, + u32 address_cells, u32 size_cells) { const struct fdt_property *prop; paddr_t start, end; @@ -306,11 +306,11 @@ static void __init process_chosen_node(const void *fdt, int node, prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); if ( !prop ) /* No initrd present. */ - return; + return 0; if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-start property has invalid length %d\n", len); - return; + return -EINVAL; } start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -318,12 +318,12 @@ static void __init process_chosen_node(const void *fdt, int node, if ( !prop ) { printk("linux,initrd-end not present but -start was\n"); - return; + return -EINVAL; } if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-end property has invalid length %d\n", len); - return; + return -EINVAL; } end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -331,12 +331,14 @@ static void __init process_chosen_node(const void *fdt, int node, { printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n", start, end); - return; + return -EINVAL; } printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end); add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); + + return 0; } static int __init process_domain_node(const void *fdt, int node, @@ -383,7 +385,7 @@ static int __init early_scan_node(const void *fdt, device_tree_node_compatible(fdt, node, "multiboot,module" ))) process_multiboot_node(fdt, node, name, address_cells, size_cells); else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) - process_chosen_node(fdt, node, name, address_cells, size_cells); + rc = process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:36:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401891.643875 (Exim 4.92) (envelope-from ) id 1oVwA5-0003Uh-DV; Wed, 07 Sep 2022 14:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401891.643875; Wed, 07 Sep 2022 14:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwA5-0003UT-9h; Wed, 07 Sep 2022 14:36:17 +0000 Received: by outflank-mailman (input) for mailman id 401891; Wed, 07 Sep 2022 14:36:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwA2-0002tH-VX for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:36:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6c3ce390-2eba-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 16:36:13 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 222E8106F; Wed, 7 Sep 2022 07:36:19 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7A2FE3F71A; Wed, 7 Sep 2022 07:36:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c3ce390-2eba-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v4 2/4] docs, xen/arm: Introduce static heap memory Date: Wed, 7 Sep 2022 14:35:30 +0000 Message-Id: <20220907143532.15397-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907143532.15397-1-Henry.Wang@arm.com> References: <20220907143532.15397-1-Henry.Wang@arm.com> This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_tree_get_meminfo(). Changes of code are done accordingly following the introduction of this enum. Also, this commit introduces the logic to parse the static heap configuration in device tree. If the memory bank is reserved as heap through `xen,static-heap` property in device tree `chosen` node, the memory will be marked as static heap type. A documentation section is added, describing the definition of static heap memory and the method of enabling the static heap memory through device tree at boot time. Signed-off-by: Henry Wang Signed-off-by: Penny Zheng Acked-by: Stefano Stabellini # DT interface --- Changes from v3 to v4: - Change of wording in comments. - Add the static heap feature in SUPPORT.md as tech preview. Changes from v2 to v3: - Define `enum membank_type` properly, drop the typedef. - Rename the feature terminology to static heap. - Rename MEMBANK_MEMORY to MEMBANK_DEFAULT and MEMBANK_XEN_DOMAIN to MEMBANK_STATIC_DOMAIN. Add comments to `enum membank_type`. - Correct typo, add the clarification of the static heap region should contain enough memory below 4GB to cater 32-bit DMA for Arm32, and add the 64KB alignment requirement in doc. - Add Stefano's Acked-by for device tree interface. Changes from v1 to v2: - Rename the device tree property to xen,static-heap to avoid confusion. - Change of commit msg and doc wording, correct typo in commit msg. - Do not change the process_chosen_node() return type. - Add an empty line in make_memory_node() memory type check to improve readability. - Use enum membank_type to make the memory type cleaner. Changes from RFC to v1: - Rename the terminology to reserved heap. --- SUPPORT.md | 7 ++++ docs/misc/arm/device-tree/booting.txt | 48 +++++++++++++++++++++++++++ xen/arch/arm/bootfdt.c | 33 +++++++++++++++--- xen/arch/arm/domain_build.c | 8 +++-- xen/arch/arm/include/asm/setup.h | 22 +++++++++++- xen/arch/arm/setup.c | 2 +- 6 files changed, 111 insertions(+), 9 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index 8e040d1c1e..b02a5d25ca 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -293,6 +293,13 @@ pre-defined by configuration using physical address ranges. Status, ARM: Tech Preview +### Static Heap + +Allow reserving parts of RAM through the device tree using physical +address ranges as heap. + + Status, ARM: Tech Preview + ### Memory Sharing Allow sharing of identical pages between guests diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..5ba7d186aa 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,51 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + + +Static Heap Memory +================== + +The static heap memory refers to parts of RAM reserved in the beginning of +boot time for heap. The memory is reserved by configuration in the device +tree using physical address ranges. + +The static heap memory declared in the device tree defines the memory areas +that will be reserved to be used exclusively as heap. + +- For Arm32, since there are separated heaps, the static heap will be used +for both domheap and xenheap. The admin should make sure that the static +heap region should contain enough memory below 4GB to cater 32-bit DMA. + +- For Arm64, since there is a single heap, the defined static heap areas +shall always go to the heap allocator. + +The static heap memory is an optional feature and can be enabled by adding +below device tree properties in the `chosen` node. + +The dtb should have the following properties: + +- xen,static-heap + + Property under the top-level "chosen" node. It specifies the address + and size of Xen static heap memory. Note that at least a 64KB + alignment is required. + +- #xen,static-heap-address-cells and #xen,static-heap-size-cells + + Specify the number of cells used for the address and size of the + "xen,static-heap" property under "chosen". + +Below is an example on how to specify the static heap in device tree: + + / { + chosen { + #xen,static-heap-address-cells = <0x2>; + #xen,static-heap-size-cells = <0x2>; + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; + ... + }; + }; + +RAM starting from the host physical address 0x30000000 of 1GB size will +be reserved as static heap. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 1a79b969af..cb23fad571 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, - void *data, bool xen_domain) + void *data, enum membank_type type) { const struct fdt_property *prop; unsigned int i, banks; @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, continue; mem->bank[mem->nr_banks].start = start; mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].xen_domain = xen_domain; + mem->bank[mem->nr_banks].type = type; mem->nr_banks++; } @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, void *data) { return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, - data, false); + data, MEMBANK_DEFAULT); } static int __init process_reserved_memory_node(const void *fdt, int node, @@ -301,6 +301,30 @@ static int __init process_chosen_node(const void *fdt, int node, paddr_t start, end; int len; + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) + { + int rc; + u32 address_cells = device_tree_get_u32(fdt, node, + "#xen,static-heap-address-cells", 0); + u32 size_cells = device_tree_get_u32(fdt, node, + "#xen,static-heap-size-cells", 0); + + printk("Checking for static heap in /chosen\n"); + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: node `%s': invalid #xen,static-heap-address-cells or #xen,static-heap-size-cells\n", + name); + return -EINVAL; + } + + rc = device_tree_get_meminfo(fdt, node, "xen,static-heap", + address_cells, size_cells, + &bootinfo.reserved_mem, + MEMBANK_STATIC_HEAP); + if ( rc ) + return rc; + } + printk("Checking for initrd in /chosen\n"); prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); @@ -360,7 +384,8 @@ static int __init process_domain_node(const void *fdt, int node, "#xen,static-mem-size-cells", 0); return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, - size_cells, &bootinfo.reserved_mem, true); + size_cells, &bootinfo.reserved_mem, + MEMBANK_STATIC_DOMAIN); } static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..cea82374f7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, if ( mem->nr_banks == 0 ) return -ENOENT; - /* find first memory range not bound to a Xen domain */ - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) + /* find the first memory range that is reserved for device (or firmware) */ + for ( i = 0; i < mem->nr_banks && + (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) ; + if ( i == mem->nr_banks ) return 0; @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, u64 start = mem->bank[i].start; u64 size = mem->bank[i].size; - if ( mem->bank[i].xen_domain ) + if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) continue; dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..31610ccd65 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -22,11 +22,31 @@ typedef enum { BOOTMOD_UNKNOWN } bootmodule_kind; +enum membank_type { + /* + * The MEMBANK_DEFAULT type refers to either reserved memory for the + * device/firmware (when the bank is in 'reserved_mem') or any RAM (when + * the bank is in 'mem'. + */ + MEMBANK_DEFAULT, + /* + * The MEMBANK_STATIC_DOMAIN type is used to indicate whether the memory + * bank is bound to a static Xen domain. It is only valid when the bank + * is in reserved_mem. + */ + MEMBANK_STATIC_DOMAIN, + /* + * The MEMBANK_STATIC_HEAP type is used to indicate whether the memory + * bank is reserved as static heap. It is only valid when the bank is + * in reserved_mem. + */ + MEMBANK_STATIC_HEAP, +}; struct membank { paddr_t start; paddr_t size; - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ + enum membank_type type; }; struct meminfo { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 7814fe323d..3c36c050bf 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) { - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) { mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:36:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:36:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401893.643886 (Exim 4.92) (envelope-from ) id 1oVwA8-0003oV-R7; Wed, 07 Sep 2022 14:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401893.643886; Wed, 07 Sep 2022 14:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwA8-0003oO-Ns; Wed, 07 Sep 2022 14:36:20 +0000 Received: by outflank-mailman (input) for mailman id 401893; Wed, 07 Sep 2022 14:36:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwA7-0003gq-Af for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:36:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6eb0769b-2eba-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 16:36:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7135A1042; Wed, 7 Sep 2022 07:36:23 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1B2453F71A; Wed, 7 Sep 2022 07:36:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eb0769b-2eba-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Date: Wed, 7 Sep 2022 14:35:31 +0000 Message-Id: <20220907143532.15397-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907143532.15397-1-Henry.Wang@arm.com> References: <20220907143532.15397-1-Henry.Wang@arm.com> With the static heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily. On Arm32, only the xenheap is direct mapped today. So the renaming to "directmap_*" would be still valid for Arm32. No functional change is intended. Signed-off-by: Henry Wang --- Changes from v3 to v4: - Also rename the setup_xenheap_mappings() function name and printed messages inside the function. - Update more comments. Changes from v2 to v3: - Adjust the order of this patch, make it #3. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 2 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 31 ++++++++++--------- xen/arch/arm/mm.c | 50 +++++++++++++++++-------------- xen/arch/arm/setup.c | 36 +++++++++++----------- 5 files changed, 64 insertions(+), 57 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index cb23fad571..a69f84aeb5 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -504,7 +504,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t paddr) device_tree_for_each_node((void *)fdt, 0, early_scan_node, NULL); /* - * On Arm64 setup_xenheap_mappings() expects to be called with the lowest + * On Arm64 setup_directmap_mappings() expects to be called with the lowest * bank in memory first. There is no requirement that the DT will provide * the banks sorted in ascending order. So sort them through. */ diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 2fafb9f228..0fefed1b8a 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -160,7 +160,7 @@ #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) #define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) -#define XENHEAP_VIRT_START xenheap_virt_start +#define XENHEAP_VIRT_START directmap_virt_start #define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 749fbefa0c..7d21120f98 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -154,19 +154,19 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t xenheap_mfn_start, xenheap_mfn_end; -extern vaddr_t xenheap_virt_end; +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -extern vaddr_t xenheap_virt_start; -extern unsigned long xenheap_base_pdx; +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; #endif #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ unsigned long mfn_ = mfn_x(mfn); \ - (mfn_ >= mfn_x(xenheap_mfn_start) && \ - mfn_ < mfn_x(xenheap_mfn_end)); \ + (mfn_ >= mfn_x(directmap_mfn_start) && \ + mfn_ < mfn_x(directmap_mfn_end)); \ }) #else #define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) @@ -203,9 +203,12 @@ extern void remove_early_mappings(void); extern int init_secondary_pagetables(int cpu); /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ extern void mmu_init_secondary_cpu(void); -/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. - * Base must be 32MB aligned and size a multiple of 32MB. */ -extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns); +/* + * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, + * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. + * For Arm64, map the region in the directmap area. + */ +extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ @@ -267,16 +270,16 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) static inline void *maddr_to_virt(paddr_t ma) { ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); - ma -= mfn_to_maddr(xenheap_mfn_start); + ma -= mfn_to_maddr(directmap_mfn_start); return (void *)(unsigned long) ma + XENHEAP_VIRT_START; } #else static inline void *maddr_to_virt(paddr_t ma) { - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - xenheap_base_pdx) < + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < (DIRECTMAP_SIZE >> PAGE_SHIFT)); return (void *)(XENHEAP_VIRT_START - - (xenheap_base_pdx << PAGE_SHIFT) + + (directmap_base_pdx << PAGE_SHIFT) + ((ma & ma_va_bottom_mask) | ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); } @@ -319,10 +322,10 @@ static inline struct page_info *virt_to_page(const void *v) unsigned long pdx; ASSERT(va >= XENHEAP_VIRT_START); - ASSERT(va < xenheap_virt_end); + ASSERT(va < directmap_virt_end); pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; - pdx += mfn_to_pdx(xenheap_mfn_start); + pdx += mfn_to_pdx(directmap_mfn_start); return frame_table + pdx - frametable_base_pdx; } diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..11ee49598b 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t xenheap_mfn_end __read_mostly; -vaddr_t xenheap_virt_end __read_mostly; +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; #ifdef CONFIG_ARM_64 -vaddr_t xenheap_virt_start __read_mostly; -unsigned long xenheap_base_pdx __read_mostly; +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; #endif unsigned long frametable_base_pdx __read_mostly; @@ -597,55 +597,59 @@ void mmu_init_secondary_cpu(void) } #ifdef CONFIG_ARM_32 -/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. */ -void __init setup_xenheap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) +/* + * Set up the direct-mapped xenheap: + * up to 1GB of contiguous, always-mapped memory. + */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) { int rc; rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, PAGE_HYPERVISOR_RW | _PAGE_BLOCK); if ( rc ) - panic("Unable to setup the xenheap mappings.\n"); + panic("Unable to setup the directmap mappings.\n"); - /* Record where the xenheap is, for translation routines. */ - xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; + /* Record where the directmap is, for translation routines. */ + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; } #else /* CONFIG_ARM_64 */ -void __init setup_xenheap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) +/* Map the region in the directmap area. */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) { int rc; - /* First call sets the xenheap physical and virtual offset. */ - if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) ) + /* First call sets the directmap physical and virtual offset. */ + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) { unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - xenheap_mfn_start = _mfn(base_mfn); - xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); /* * The base address may not be aligned to the first level * size (e.g. 1GB when using 4KB pages). This would prevent * superpage mappings for all the regions because the virtual * address and machine address should both be suitably aligned. * - * Prevent that by offsetting the start of the xenheap virtual + * Prevent that by offsetting the start of the directmap virtual * address. */ - xenheap_virt_start = DIRECTMAP_VIRT_START + + directmap_virt_start = DIRECTMAP_VIRT_START + (base_mfn - mfn_gb) * PAGE_SIZE; } - if ( base_mfn < mfn_x(xenheap_mfn_start) ) - panic("cannot add xenheap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(xenheap_mfn_start)); + if ( base_mfn < mfn_x(directmap_mfn_start) ) + panic("cannot add directmap mapping at %lx below heap start %lx\n", + base_mfn, mfn_x(directmap_mfn_start)); rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), _mfn(base_mfn), nr_mfns, PAGE_HYPERVISOR_RW | _PAGE_BLOCK); if ( rc ) - panic("Unable to setup the xenheap mappings.\n"); + panic("Unable to setup the directmap mappings.\n"); } #endif diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3c36c050bf..9f3838d004 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -697,11 +697,11 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 /* Avoid the xenheap */ - if ( s < mfn_to_maddr(xenheap_mfn_end) && - mfn_to_maddr(xenheap_mfn_start) < e ) + if ( s < mfn_to_maddr(directmap_mfn_end) && + mfn_to_maddr(directmap_mfn_start) < e ) { - e = mfn_to_maddr(xenheap_mfn_start); - n = mfn_to_maddr(xenheap_mfn_end); + e = mfn_to_maddr(directmap_mfn_start); + n = mfn_to_maddr(directmap_mfn_end); } #endif @@ -791,17 +791,17 @@ static void __init setup_mm(void) /* * We need some memory to allocate the page-tables used for the - * xenheap mappings. So populate the boot allocator first. + * directmap mappings. So populate the boot allocator first. * - * This requires us to set xenheap_mfn_{start, end} first so the Xenheap - * region can be avoided. + * This requires us to set directmap_mfn_{start, end} first so the + * direct-mapped Xenheap region can be avoided. */ - xenheap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - xenheap_mfn_end = mfn_add(xenheap_mfn_start, xenheap_pages); + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); populate_boot_allocator(); - setup_xenheap_mappings(mfn_x(xenheap_mfn_start), xenheap_pages); + setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); @@ -816,8 +816,8 @@ static void __init setup_mm(void) smp_processor_id()); /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), - mfn_to_maddr(xenheap_mfn_end)); + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); init_staticmem_pages(); } @@ -833,7 +833,7 @@ static void __init setup_mm(void) init_pdx(); /* - * We need some memory to allocate the page-tables used for the xenheap + * We need some memory to allocate the page-tables used for the directmap * mappings. But some regions may contain memory already allocated * for other uses (e.g. modules, reserved-memory...). * @@ -852,15 +852,15 @@ static void __init setup_mm(void) ram_start = min(ram_start, bank->start); ram_end = max(ram_end, bank_end); - setup_xenheap_mappings(PFN_DOWN(bank->start), - PFN_DOWN(bank->size)); + setup_directmap_mappings(PFN_DOWN(bank->start), + PFN_DOWN(bank->size)); } total_pages += ram_size >> PAGE_SHIFT; - xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - xenheap_mfn_start = maddr_to_mfn(ram_start); - xenheap_mfn_end = maddr_to_mfn(ram_end); + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 14:36:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 14:36:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401894.643897 (Exim 4.92) (envelope-from ) id 1oVwAC-0004Bx-3A; Wed, 07 Sep 2022 14:36:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401894.643897; Wed, 07 Sep 2022 14:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwAC-0004Bp-0A; Wed, 07 Sep 2022 14:36:24 +0000 Received: by outflank-mailman (input) for mailman id 401894; Wed, 07 Sep 2022 14:36:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwAA-0002tH-Oy for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 14:36:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 70f3f3ea-2eba-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 16:36:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C4B71042; Wed, 7 Sep 2022 07:36:27 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AA7003F71A; Wed, 7 Sep 2022 07:36:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70f3f3ea-2eba-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 4/4] xen/arm: Handle static heap pages in boot and heap allocator Date: Wed, 7 Sep 2022 14:35:32 +0000 Message-Id: <20220907143532.15397-5-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220907143532.15397-1-Henry.Wang@arm.com> References: <20220907143532.15397-1-Henry.Wang@arm.com> This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap is enabled, we use the static heap region for both domheap and xenheap allocation. Note that the xenheap on Arm32 should be always contiguous, so also add a helper fit_xenheap_in_static_heap() for Arm32 to find the required xenheap in the static heap regions. For Arm64, In `setup_mm`, if the static heap is enabled and used, we make sure that only these static heap pages are added to the boot allocator. These static heap pages in the boot allocator are added to the heap allocator at `end_boot_allocator()`. If the static heap is disabled, we stick to current page allocation strategy at boot time. Also, take the chance to correct a "double not" print in Arm32 `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- Changes from v3 to v4: - Add Julien's Reviewed-by. Changes from v2 to v3: - Adjustment of the terminology change to "static heap". - Change of wording in comments. - int i -> unsigned int i. - Avoid extra indentation by reverting the check of MEMBANK_RSVD_HEAP. - Use MB(32). - Drop unnecessary panic and unused variables. - Avoid the ternary operation in assigning the heap_pages. - Rework populate_boot_allocator() for static heap. Changes from v1 to v2: - Move the global bool `reserved_heap` to bootinfo. - Replace the open open-coding address ~0 by INVALID_PADDR. - Do not use reverted logic in heap_pages calculation. - Remove unused Arm32 reserved_heap_start variable. - Decouple the arm32 reserved heap too small size check with region end check. - Reuse the arm32 original xenheap finding logic with the new helper to make sure xenheap on arm32 is contiguous. Changes from RFC to v1: - Rebase on top of latest `setup_mm()` changes. - Added Arm32 logic in `setup_mm()`. --- xen/arch/arm/bootfdt.c | 2 + xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 118 +++++++++++++++++++++++++++---- 3 files changed, 107 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index a69f84aeb5..86f1e3c3eb 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -323,6 +323,8 @@ static int __init process_chosen_node(const void *fdt, int node, MEMBANK_STATIC_HEAP); if ( rc ) return rc; + + bootinfo.static_heap = true; } printk("Checking for initrd in /chosen\n"); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 31610ccd65..492779aa91 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -97,6 +97,7 @@ struct bootinfo { #ifdef CONFIG_ACPI struct meminfo acpi; #endif + bool static_heap; }; struct map_range_data diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 9f3838d004..e0f9809d7e 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -556,6 +556,44 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, } return e; } + +/* + * Find a contiguous region that fits in the static heap region with + * required size and alignment, and return the end address of the region + * if found otherwise 0. + */ +static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) +{ + unsigned int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Allocate the xenheap as high as possible to keep low-memory + * available (assuming the admin supplied region below 4GB) + * for other use (e.g. domain memory allocation). + */ + end = max(end, aligned_end); + } + + return end; +} #endif /* @@ -661,22 +699,51 @@ static void __init init_staticmem_pages(void) } /* - * Populate the boot allocator. All the RAM but the following regions - * will be added: + * Populate the boot allocator. + * If a static heap was not provided by the admin, all the RAM but the + * following regions will be added: * - Modules (e.g., Xen, Kernel) * - Reserved regions * - Xenheap (arm32 only) + * If a static heap was provided by the admin, populate the boot + * allocator with the corresponding regions only, but with Xenheap excluded + * on arm32. */ static void __init populate_boot_allocator(void) { unsigned int i; const struct meminfo *banks = &bootinfo.mem; + paddr_t s, e; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + s = bootinfo.reserved_mem.bank[i].start; + e = s + bootinfo.reserved_mem.bank[i].size; +#ifdef CONFIG_ARM_32 + /* Avoid the xenheap, note that the xenheap cannot across a bank */ + if ( s <= mfn_to_maddr(directmap_mfn_start) && + e >= mfn_to_maddr(directmap_mfn_end) ) + { + init_boot_pages(s, mfn_to_maddr(directmap_mfn_start)); + init_boot_pages(mfn_to_maddr(directmap_mfn_end), e); + } + else +#endif + init_boot_pages(s, e); + } + + return; + } for ( i = 0; i < banks->nr_banks; i++ ) { const struct membank *bank = &banks->bank[i]; paddr_t bank_end = bank->start + bank->size; - paddr_t s, e; s = bank->start; while ( s < bank_end ) @@ -714,8 +781,8 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 static void __init setup_mm(void) { - paddr_t ram_start, ram_end, ram_size, e; - unsigned long ram_pages; + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t static_heap_end = 0, static_heap_size = 0; unsigned long heap_pages, xenheap_pages, domheap_pages; unsigned int i; const uint32_t ctr = READ_CP32(CTR); @@ -735,30 +802,51 @@ static void __init setup_mm(void) for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) { - paddr_t bank_start = bootinfo.mem.bank[i].start; - paddr_t bank_size = bootinfo.mem.bank[i].size; - paddr_t bank_end = bank_start + bank_size; + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; ram_size = ram_size + bank_size; ram_start = min(ram_start,bank_start); ram_end = max(ram_end,bank_end); } - total_pages = ram_pages = ram_size >> PAGE_SHIFT; + total_pages = ram_size >> PAGE_SHIFT; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + static_heap_size += bank_size; + static_heap_end = max(static_heap_end, bank_end); + } + + heap_pages = static_heap_size >> PAGE_SHIFT; + } + else + heap_pages = total_pages; /* * If the user has not requested otherwise via the command line * then locate the xenheap using these constraints: * + * - must be contiguous * - must be 32 MiB aligned * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system if less + * - must be at most 1GB or 1/32 the total RAM in the system (or static + heap if enabled) if less * - must be at least 32M * * We try to allocate the largest xenheap possible within these * constraints. */ - heap_pages = ram_pages; if ( opt_xenheap_megabytes ) xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); else @@ -770,7 +858,9 @@ static void __init setup_mm(void) do { - e = consider_modules(ram_start, ram_end, + e = bootinfo.static_heap ? + fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : + consider_modules(ram_start, ram_end, pfn_to_paddr(xenheap_pages), 32<<20, 0); if ( e ) @@ -780,7 +870,7 @@ static void __init setup_mm(void) } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); if ( ! e ) - panic("Not not enough space for xenheap\n"); + panic("Not enough space for xenheap\n"); domheap_pages = heap_pages - xenheap_pages; @@ -825,7 +915,7 @@ static void __init setup_mm(void) static void __init setup_mm(void) { const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = ~0; + paddr_t ram_start = INVALID_PADDR; paddr_t ram_end = 0; paddr_t ram_size = 0; unsigned int i; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:07:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401935.643910 (Exim 4.92) (envelope-from ) id 1oVweF-0000fu-Kn; Wed, 07 Sep 2022 15:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401935.643910; Wed, 07 Sep 2022 15:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVweF-0000fn-Hw; Wed, 07 Sep 2022 15:07:27 +0000 Received: by outflank-mailman (input) for mailman id 401935; Wed, 07 Sep 2022 15:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVweD-0000fg-Ic for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 15:07:26 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6236b32-2ebe-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 17:07:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BA7295C0189; Wed, 7 Sep 2022 11:07:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 07 Sep 2022 11:07:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Sep 2022 11:07:20 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6236b32-2ebe-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1662563241; x= 1662649641; bh=v/s3MB60xE1vO2w5soDZvjjv4HBjjIg9iW3ayRKeD50=; b=N MOhShj+LUR+CksqAGwsGesU1DEE6tox3BdlMb4cHnRRvi5X/Y1+ZzWzyY+Rp8PUO ND0jXtCQ9RpDxZV/FaeUGfBza4whYfkKYTRcZJPCMsViuWGuAQHMNrI6BYiZ1I36 Zziv2p03Wp59mZTD0+TTqlcwt5QSdKJwb9MN5CogbRdreMAvYb1p3Frev1a6Faey 0d6mcdAhI+xUhEfhE8WsQX9CfD8wa1fE8J9AC9EVDRobEw45XvZskvdP2Cx1wB29 09CX2/SWs94zEtxv3f6WoA2zMQJlXuabL6Os0okZhWhFxgvLxMg0Ph3EFaq3dtqx whJUgM9YhJrDb8zY2+Jfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662563241; x=1662649641; bh=v/s3MB60xE1vO2w5soDZvjjv4HBj jIg9iW3ayRKeD50=; b=ByLurM+xMGG7XZwlllM7/fUr33HwWEKwNQ6V8m13mXij qXVlLFuB4O+RYDNCkL3GAvUQMn2V5g43qKq1Tm+tGspfnd2sTtv17NMtfrUTuMG3 HueRIFPscOQUbP/sRWjhMu4SfvV2Vtni2fyIt+y8bRREfAjJVnf7odsVc7Z8WJ1o JjadjWpj7y53Ry5z1iQGmV+wUZZ7fERj13brvyMCF/SGyKYyFESUevXSmsRvUfUy 4+mVS9fyeGXlFfYtcpvljKKkuay/JUDnenbz+piliKOXE3tfH0gwOyPrh2yI0fmH 1Kw2wZGE20RGLVs3qSsMi5IPBE8oMOO5jmnGEFivPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedttddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepfdhmrghr mhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmfdcuoehmrghrmh grrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrght thgvrhhnpeekkeevieevkefhieetveehueekhedufeelgfevudejkefhffehuddtjeegte ehtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 7 Sep 2022 17:07:11 +0200 From: "marmarek@invisiblethingslab.com" To: Dario Faggioli Cc: Juergen Gross , "jgross@suse.de" , Jan Beulich , "andrew.cooper3@citrix.com" , "xen-devel@lists.xenproject.org" Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Message-ID: References: <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> <31f99f6b-0781-795b-731b-d5a9f1105887@suse.com> <919e328a-000e-0eeb-2253-6a4381b5ccaa@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pu1WEvI8Qnh+B2zy" Content-Disposition: inline In-Reply-To: --pu1WEvI8Qnh+B2zy Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 7 Sep 2022 17:07:11 +0200 From: "marmarek@invisiblethingslab.com" To: Dario Faggioli Cc: Juergen Gross , "jgross@suse.de" , Jan Beulich , "andrew.cooper3@citrix.com" , "xen-devel@lists.xenproject.org" Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer On Wed, Sep 07, 2022 at 12:21:12PM +0000, Dario Faggioli wrote: > On Tue, 2022-09-06 at 14:35 +0200, Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Sep 06, 2022 at 01:46:55PM +0200, Juergen Gross wrote: > > >=20 > > > Could you test the attached patch, please? > >=20 > > I did a test with only dom0 running, and it works now. It isn't a > > comprehensive test, but just dom0 was enough to crash it before, and > > it > > stays working now. > > > That's very cool to hear! Thanks for testing and reporting back. >=20 > Just to be sure, did you check both Credit1 and Credit2 and do they > both work, with Juergen's patch? The test above was with credit1. I did checked credit2 later, and it still crashes, unfortunately (Juergen knows already from our IRC chat). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --pu1WEvI8Qnh+B2zy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMYs6AACgkQ24/THMrX 1yysjQf/cZhhYUO1wcQwjq8gBa+SFJmfz1rx8NkAd6Z7pc4Vli5cwFswLVcSj11g cPR2OJAwmZd20seCiV+eH9TRo1UTVPn+4Vtu8+XrkOpbyfpQz4HJmbMJnW8CyuoN WzdjE37N6zp1AsTl2m9mbS96wJKNyyKsEwURzDRDS5JCZcQ+BehDw1nMEc9857jP xF4YKRurYdB7joFL6mCSW9Q4AXN7gwYzqDNqqteFWjHtPi6yN+XHxskhZrhdwFDI BWVDcpoqHL+G6t8po8adYGRzPhWDRsQZizCGTSTgjbtc3Mry07ddRwzs7YlEwK7Y dFmj/5ZA1OGWsoP0xCl6yxIcsRjO4A== =l1pb -----END PGP SIGNATURE----- --pu1WEvI8Qnh+B2zy-- From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:13:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:13:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401945.643922 (Exim 4.92) (envelope-from ) id 1oVwk7-0002LX-Fv; Wed, 07 Sep 2022 15:13:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401945.643922; Wed, 07 Sep 2022 15:13:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwk7-0002LQ-Bf; Wed, 07 Sep 2022 15:13:31 +0000 Received: by outflank-mailman (input) for mailman id 401945; Wed, 07 Sep 2022 15:13:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwk6-0002LG-A8; Wed, 07 Sep 2022 15:13:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwk6-0008Pd-5F; Wed, 07 Sep 2022 15:13:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwk5-0005cb-Or; Wed, 07 Sep 2022 15:13:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVwk5-0006Cg-OJ; Wed, 07 Sep 2022 15:13:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xeiL19Ks4FBd87PRO+wTLCAx0CDkPeA/+KHV/Ayz/NE=; b=Q5yqQsDcYqKo8eSWECFG1sG+9h bZ6yHNf8SZE8eFOG0I9okS/7p3RW+k5TiWea03+2WaFBlq7NvZqtnHZMBqr/WUY2dQLiwbQyYnVq2 g3H0ly5qTeKzRBVR77Ke47MxBinp9QpncnWsC2XILbg2q/FWU75LScpWu/v7RINMI6t4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173037: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Wed, 07 Sep 2022 15:13:29 +0000 flight 173037 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173037/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-pvops 6 kernel-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 34 days Failing since 172384 2022-08-11 11:13:58 Z 27 days 58 attempts Testing same since 173008 2022-09-05 15:47:43 Z 1 days 4 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:20:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:20:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401960.643937 (Exim 4.92) (envelope-from ) id 1oVwqZ-00047s-7W; Wed, 07 Sep 2022 15:20:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401960.643937; Wed, 07 Sep 2022 15:20:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwqZ-00047l-4u; Wed, 07 Sep 2022 15:20:11 +0000 Received: by outflank-mailman (input) for mailman id 401960; Wed, 07 Sep 2022 15:20:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVwqY-00047d-4s for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 15:20:10 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e37ecdc-2ec0-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 17:20:08 +0200 (CEST) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-199-ND5nlDMpNH6gLpW8M_h5zA-1; Wed, 07 Sep 2022 11:20:05 -0400 Received: by mail-wr1-f71.google.com with SMTP id h2-20020adfa4c2000000b00228db7822cbso1877153wrb.19 for ; Wed, 07 Sep 2022 08:20:05 -0700 (PDT) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id f25-20020a1c6a19000000b003a840690609sm29360122wmc.36.2022.09.07.08.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:20:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e37ecdc-2ec0-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662564007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xYRHulRFq0HQCbPn97D2YEnCLSwRHPaOy9i5aW24Q8=; b=X27kb0uM7uwv25DflX7tIdV6krH0gRvREbnmuuTn/1MTERVdmQH3/3vxJZU+ZI1yc5Rp9t YM/KUMTu2D7ULjxw5NRTFpNm22NgYsdVdxJvVlclA+5N+P96VUJE4EkZmEz44gMoJ7F2ri JWTlTOgqC5b+7Ax1AiZswqWEKcN/e6Y= X-MC-Unique: ND5nlDMpNH6gLpW8M_h5zA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=CHNdLB0NEs0hPJCPuKfDS5PXO0uKkxor3QlPHHKcdWM=; b=8Hd3AN8SkPlLcVnTfGtIbxt/10w+Qd2Z5AHujOOl6AKPyDtfUHc8R0kC9y3EetMsfL h4eCL3r7gHLa7o2az9Qd6JQyQ1hLD7CAl9ieNCnpMivLAv03JTXGEbOutg9jRYdaACiI uz5Zo7JdOEu+byt8c8yxTwj2GouM9cnRwrQy7w5FWG7wlnvHmG5mk6/S1afZC/Ol2vr5 ssjNmw2MzjoDcY9hTDliYXlhmVhQKeX1rjg7swk9V1VmLGHlFDSKeJhfAfS3QJpbq8X2 QpmNnxLw8464eBY/FWDYsWEKaQJfvhpbNsJ23SJmJ1dx6f4C3ilj9ElkvxmC6EzhNydx 07uA== X-Gm-Message-State: ACgBeo1k2NuUumfc0b4p6XCvoxlUGqMw2h1ub8eaCDLYKCPOfMeeimAx MP58AwzvcnRVX4/PXgvrP7QjHX+dahKHRXsNZ8IErMH0aOYTI4fVGYt1KEQEf+M5/UwE1rY4YfU J8cluygKzt3wQucCP+2ixXFeGsfI= X-Received: by 2002:a5d:59ab:0:b0:228:28df:9193 with SMTP id p11-20020a5d59ab000000b0022828df9193mr2471676wrr.323.1662564003266; Wed, 07 Sep 2022 08:20:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR756qiCLKEbLM1iNnFKS+9y7GWIyNG66GDmPAE9ydBmmICwjU+sxM3SEVFU1scSKoLlwTZJ6g== X-Received: by 2002:a5d:59ab:0:b0:228:28df:9193 with SMTP id p11-20020a5d59ab000000b0022828df9193mr2471659wrr.323.1662564002953; Wed, 07 Sep 2022 08:20:02 -0700 (PDT) From: Vitaly Kuznetsov To: Ajay Kaher Cc: x86@kernel.org, hpa@zytor.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, srivatsab@vmware.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, vsirnapalli@vmware.com, er.ajay.kaher@gmail.com, willy@infradead.org, namit@vmware.com, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, jailhouse-dev@googlegroups.com, xen-devel@lists.xenproject.org, acrn-dev@lists.projectacrn.org, helgaas@kernel.org, bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on VMware hypervisor In-Reply-To: <1662448117-10807-1-git-send-email-akaher@vmware.com> References: <1662448117-10807-1-git-send-email-akaher@vmware.com> Date: Wed, 07 Sep 2022 17:20:00 +0200 Message-ID: <8735d3rz33.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ajay Kaher writes: > During boot-time there are many PCI config reads, these could be performe= d > either using Port IO instructions (PIO) or memory mapped I/O (MMIO). > > PIO are less efficient than MMIO, they require twice as many PCI accesses > and PIO instructions are serializing. As a result, MMIO should be preferr= ed > when possible over PIO. > > Virtual Machine test result using VMware hypervisor > 1 hundred thousand reads using raw_pci_read() took: > PIO: 12.809 seconds > MMIO: 8.517 seconds (~33.5% faster then PIO) > > Currently, when these reads are performed by a virtual machine, they all > cause a VM-exit, and therefore each one of them induces a considerable > overhead. > > This overhead can be further improved, by mapping MMIO region of virtual > machine to memory area that holds the values that the =E2=80=9Cemulated h= ardware=E2=80=9D > is supposed to return. The memory region is mapped as "read-only=E2=80=9D= in the > NPT/EPT, so reads from these regions would be treated as regular memory > reads. Writes would still be trapped and emulated by the hypervisor. > > Virtual Machine test result with above changes in VMware hypervisor > 1 hundred thousand read using raw_pci_read() took: > PIO: 12.809 seconds > MMIO: 0.010 seconds > > This helps to reduce virtual machine PCI scan and initialization time by > ~65%. In our case it reduced to ~18 mSec from ~55 mSec. > > MMIO is also faster than PIO on bare-metal systems, but due to some bugs > with legacy hardware and the smaller gains on bare-metal, it seems pruden= t > not to change bare-metal behavior. Out of curiosity, are we sure MMIO *always* works for other hypervisors besides Vmware? Various Hyper-V version can probably be tested (were they?) but with KVM it's much harder as PCI is emulated in VMM and there's certainly more than 1 in existence... > > Signed-off-by: Ajay Kaher > --- > v1 -> v2: > Limit changes to apply only to VMs [Matthew W.] > --- > arch/x86/pci/common.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c > index ddb7986..1e5a8f7 100644 > --- a/arch/x86/pci/common.c > +++ b/arch/x86/pci/common.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > =20 > unsigned int pci_probe =3D PCI_PROBE_BIOS | PCI_PROBE_CONF1 | PCI_PROBE_= CONF2 | > =09=09=09=09PCI_PROBE_MMCONF; > @@ -57,14 +58,58 @@ int raw_pci_write(unsigned int domain, unsigned int b= us, unsigned int devfn, > =09return -EINVAL; > } > =20 > +#ifdef CONFIG_HYPERVISOR_GUEST > +static int vm_raw_pci_read(unsigned int domain, unsigned int bus, unsign= ed int devfn, > +=09=09=09=09=09=09int reg, int len, u32 *val) > +{ > +=09if (raw_pci_ext_ops) > +=09=09return raw_pci_ext_ops->read(domain, bus, devfn, reg, len, val); > +=09if (domain =3D=3D 0 && reg < 256 && raw_pci_ops) > +=09=09return raw_pci_ops->read(domain, bus, devfn, reg, len, val); > +=09return -EINVAL; > +} > + > +static int vm_raw_pci_write(unsigned int domain, unsigned int bus, unsig= ned int devfn, > +=09=09=09=09=09=09int reg, int len, u32 val) > +{ > +=09if (raw_pci_ext_ops) > +=09=09return raw_pci_ext_ops->write(domain, bus, devfn, reg, len, val); > +=09if (domain =3D=3D 0 && reg < 256 && raw_pci_ops) > +=09=09return raw_pci_ops->write(domain, bus, devfn, reg, len, val); > +=09return -EINVAL; > +} These look exactly like raw_pci_read()/raw_pci_write() but with inverted priority. We could've added a parameter but to be more flexible, I'd suggest we add a 'priority' field to 'struct pci_raw_ops' and make raw_pci_read()/raw_pci_write() check it before deciding what to use first. To be on the safe side, you can leave raw_pci_ops's priority higher than raw_pci_ext_ops's by default and only tweak it in arch/x86/kernel/cpu/vmware.c=20 > +#endif /* CONFIG_HYPERVISOR_GUEST */ > + > static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, = int size, u32 *value) > { > +#ifdef CONFIG_HYPERVISOR_GUEST > +=09/* > +=09 * MMIO is faster than PIO, but due to some bugs with legacy > +=09 * hardware, it seems prudent to prefer MMIO for VMs and PIO > +=09 * for bare-metal. > +=09 */ > +=09if (!hypervisor_is_type(X86_HYPER_NATIVE)) > +=09=09return vm_raw_pci_read(pci_domain_nr(bus), bus->number, > +=09=09=09=09=09 devfn, where, size, value); > +#endif /* CONFIG_HYPERVISOR_GUEST */ > + > =09return raw_pci_read(pci_domain_nr(bus), bus->number, > =09=09=09=09 devfn, where, size, value); > } > =20 > static int pci_write(struct pci_bus *bus, unsigned int devfn, int where,= int size, u32 value) > { > +#ifdef CONFIG_HYPERVISOR_GUEST > +=09/* > +=09 * MMIO is faster than PIO, but due to some bugs with legacy > +=09 * hardware, it seems prudent to prefer MMIO for VMs and PIO > +=09 * for bare-metal. > +=09 */ > +=09if (!hypervisor_is_type(X86_HYPER_NATIVE)) > +=09=09return vm_raw_pci_write(pci_domain_nr(bus), bus->number, > +=09=09=09=09=09 devfn, where, size, value); > +#endif /* CONFIG_HYPERVISOR_GUEST */ > + > =09return raw_pci_write(pci_domain_nr(bus), bus->number, > =09=09=09=09 devfn, where, size, value); > } --=20 Vitaly From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:31:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:31:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401970.643948 (Exim 4.92) (envelope-from ) id 1oVx13-0005mZ-8h; Wed, 07 Sep 2022 15:31:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401970.643948; Wed, 07 Sep 2022 15:31:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx13-0005mS-5I; Wed, 07 Sep 2022 15:31:01 +0000 Received: by outflank-mailman (input) for mailman id 401970; Wed, 07 Sep 2022 15:31:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx12-0005mM-5D for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 15:31:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx10-0000Iz-Gz; Wed, 07 Sep 2022 15:30:58 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVx10-0000iZ-BD; Wed, 07 Sep 2022 15:30:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To: MIME-Version:Date:Message-ID; bh=MMcDI8GgeHxlaAISEiJxO5zOBBxU1wk0Bp3mURHINJU= ; b=VFW6mf3N8z21kNz8CkLqN6B5uDArGmxy4ar42rRrDYHbIvjjk1abkf5Sl1YtGHJ0dFbIHKw5W mlHR2ca2kqL2jM2HJvLDcFW8VERzL09oA0x6kr0rtK2+Fmhf0czZM0MA1rkTzJGyuD8dxtMb6qotJ C5cApNJ0rHj+gDOingjgk=; Message-ID: Date: Wed, 7 Sep 2022 16:30:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: Bertrand Marquis , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" From: Julien Grall Subject: Unaligned access on arm32 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi all, I think mentioned it privately a while a go, but never sent an e-mail about it. While testing arm32 with IOREQ, I noticed Xen is crashing because an alignment fault: (XEN) Data Abort Trap. Syndrome=0x1800061 (XEN) Walking Hypervisor VA 0x40027ebb on CPU0 via TTBR 0x000000004012f000 (XEN) 1ST[0x001] = 0x00400000bbffff7f (XEN) 2ND[0x000] = 0x00500000bc000f7d (XEN) CPU0: Unexpected Trap: Data Abort (XEN) ----[ Xen-4.17-unstable arm32 debug=n Tainted: C ]---- (XEN) CPU: 0 (XEN) PC: 002613b8 try_fwd_ioserv+0x44/0x1bc (XEN) CPSR: 6000005a MODE:Hypervisor (XEN) R0: 00000000 R1: 00000001 R2: 0022a748 R3: 00000006 (XEN) R4: 40027f20 R5: 40027f58 R6: 40028000 R7: 00000000 (XEN) R8: 40027f20 R9: 4003a438 R10:002f0044 R11:40027edc R12:00000002 (XEN) HYP: SP: 40027e94 LR: 00260edc (XEN) (XEN) VTCR_EL2: 80003558 (XEN) VTTBR_EL2: 00010000bbff8000 (XEN) (XEN) SCTLR_EL2: 30cd187f (XEN) HCR_EL2: 007c663f (XEN) TTBR0_EL2: 000000004012f000 (XEN) (XEN) ESR_EL2: 97800061 (XEN) HPFAR_EL2: 0067faf0 (XEN) HDFAR: 40027ebb (XEN) HIFAR: 67600000 (XEN) (XEN) Xen stack trace from sp=40027e94: (XEN) 97800061 0022a748 00000001 00000000 8000005a 00800000 4003a000 00000001 (XEN) 4003a180 00000000 bbff47ff 00000000 67faf200 00000000 4003a000 40027f20 (XEN) 4003a438 40027f1c 00260edc 002f0110 40027f58 40028000 4003a000 0000013b (XEN) 40028000 002f0280 00000090 40027f58 67faf200 93820006 67faf200 00000000 (XEN) 00000000 40027f54 0026b6ac 93820006 0022a748 00000001 00000004 67faf200 (XEN) 00000000 00000000 00000000 00000000 ffffffff 68000000 400001d3 40027f58 (XEN) 00201870 60000000 67601324 67faf200 00000000 00000013 00000000 00000000 (XEN) ffffffff 68000000 400001d3 00000000 00000000 00000000 ffffffff 00000000 (XEN) 67601074 000001d3 93820006 00000000 00000000 00000000 00000000 67601008 (XEN) 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (XEN) 00000000 00000000 00000000 400001d3 00000000 00000000 00000000 00000000 (XEN) 00000000 00000000 00000001 (XEN) Xen call trace: (XEN) [<002613b8>] try_fwd_ioserv+0x44/0x1bc (PC) (XEN) [<00260edc>] try_handle_mmio+0x2b0/0x2f4 (LR) (XEN) [<00260edc>] try_handle_mmio+0x2b0/0x2f4 (XEN) [<0026b6ac>] arch/arm/traps.c#do_trap_stage2_abort_guest+0x18c/0x34c (XEN) [<00201870>] entry.o#return_from_trap+0/0x4 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) CPU0: Unexpected Trap: Data Abort (XEN) **************************************** The disassembled code is: 00261374 : 261374: e16d42f0 strd r4, [sp, #-32]! ; 0xffffffe0 261378: e1a04002 mov r4, r2 26137c: e1a05000 mov r5, r0 261380: e1cd60f8 strd r6, [sp, #8] 261384: e3a00000 mov r0, #0 261388: e1a06001 mov r6, r1 26138c: e1cd81f0 strd r8, [sp, #16] 261390: e3a01001 mov r1, #1 261394: e58db018 str fp, [sp, #24] 261398: e28db01c add fp, sp, #28 26139c: e58de01c str lr, [sp, #28] 2613a0: e24dd028 sub sp, sp, #40 ; 0x28 2613a4: e1c220d4 ldrd r2, [r2, #4] 2613a8: e50b0024 str r0, [fp, #-36] ; 0xffffffdc 2613ac: e5d67a26 ldrb r7, [r6, #2598] ; 0xa26 2613b0: e14b24f4 strd r2, [fp, #-68] ; 0xffffffbc 2613b4: e5d43000 ldrb r3, [r4] * 2613b8: e50b0021 str r0, [fp, #-33] ; 0xffffffdf The problem is GCC [1] decided to use 'str' for accessing an address that is not 32-bit aligned (fp - 33 = 0x40027e73). On arm32, we are forbidding aligned access, hence why it crashed. Looking online, it looks like GCC has an option to turned on/off the use of unaligned access [2] and it is enabled by default on ARMv7 (I am not sure why we didn't notice this before...). I have rebuilt Xen with the option turn off and dom0 is now booting fine. However, I am a bit puzzled because the C code didn't contain unaligned access. It was all introduced by the compiler itself. This is breaking our assumption that the compiler will not break down correctly naturally aligned access. When using the new option, Xen size is increasing by 0.40% (about ~3KB) in my setup. Nothing too concerning, but I would like to have some opinion first. The alternative would be to allow unaligned access. That said, I think this is much saner to have a strict enforcement as we can catch GCC trying to do unaligned access when it is not expected. There is also the argument that unaligned access can be slower on some platform. So it is better to avoid them. Any thoughts? Cheers, [1] gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-15) [2] https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/ARM-Options.html -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:37:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:37:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401979.643959 (Exim 4.92) (envelope-from ) id 1oVx6z-0006VK-2N; Wed, 07 Sep 2022 15:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401979.643959; Wed, 07 Sep 2022 15:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx6y-0006VD-Vb; Wed, 07 Sep 2022 15:37:08 +0000 Received: by outflank-mailman (input) for mailman id 401979; Wed, 07 Sep 2022 15:37:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx6x-0006V7-Oa for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 15:37:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx6x-0000Qa-1m; Wed, 07 Sep 2022 15:37:07 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVx6w-00016a-N9; Wed, 07 Sep 2022 15:37:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vT/JAnTVTovb4nyCPBr2/JItdrtQKlyTOQeHpuWB90Y=; b=VtyCb0n6P+hxLkDaaVWuJ0OgSr TXV5hvplCzQO45gOfk6AgTLM5JTt9t/MqkhI9J6exIdP5w0FthjdFEKex9f4qsXVQKO65/+G2gTvQ X6XSTMgh0o3W3UUcjoKQ2aFuGplRdo86o481ohVnPvcs06b2FBDvDxn/h2merQ5OXDow=; Message-ID: Date: Wed, 7 Sep 2022 16:37:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20220907143532.15397-1-Henry.Wang@arm.com> <20220907143532.15397-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220907143532.15397-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/09/2022 15:35, Henry Wang wrote: > +Static Heap Memory > +================== > + > +The static heap memory refers to parts of RAM reserved in the beginning of > +boot time for heap. The memory is reserved by configuration in the device > +tree using physical address ranges. > + > +The static heap memory declared in the device tree defines the memory areas > +that will be reserved to be used exclusively as heap. > + > +- For Arm32, since there are separated heaps, the static heap will be used > +for both domheap and xenheap. The admin should make sure that the static > +heap region should contain enough memory below 4GB to cater 32-bit DMA. > + > +- For Arm64, since there is a single heap, the defined static heap areas > +shall always go to the heap allocator. > + > +The static heap memory is an optional feature and can be enabled by adding > +below device tree properties in the `chosen` node. > + > +The dtb should have the following properties: > + > +- xen,static-heap > + > + Property under the top-level "chosen" node. It specifies the address > + and size of Xen static heap memory. Note that at least a 64KB > + alignment is required. > + > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells > + > + Specify the number of cells used for the address and size of the > + "xen,static-heap" property under "chosen". Logging here just because it is easier to keep track of open questions :). For the future, I would suggest to list them after --- so they don't get lost. We need to agree on the naming scheme before this gets committed. > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..31610ccd65 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -22,11 +22,31 @@ typedef enum { > BOOTMOD_UNKNOWN > } bootmodule_kind; > > +enum membank_type { > + /* > + * The MEMBANK_DEFAULT type refers to either reserved memory for the > + * device/firmware (when the bank is in 'reserved_mem') or any RAM (when > + * the bank is in 'mem'. Typo: Missing ')' This can be updated on commit if we decide to keep the current naming scheme. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:38:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.401995.643976 (Exim 4.92) (envelope-from ) id 1oVx8c-0007Iv-Hs; Wed, 07 Sep 2022 15:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 401995.643976; Wed, 07 Sep 2022 15:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx8c-0007Io-Et; Wed, 07 Sep 2022 15:38:50 +0000 Received: by outflank-mailman (input) for mailman id 401995; Wed, 07 Sep 2022 15:38:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx8b-0007Ii-Gh for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 15:38:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVx8b-0000S6-79; Wed, 07 Sep 2022 15:38:49 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVx8b-0001Al-0i; Wed, 07 Sep 2022 15:38:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+GdVeUssNDRjPN9+jzsslXuRsyMUUCNoW9uJObPFNc0=; b=1ZDZOnEjIhziQux4vc97BumUKr eN5I5o8IEJsk6j9rxYC+fGaR74oJWHsAQxK0ht6UbMdjrhd5T7Jlwm1qCergoZO7JaWUxwhIB5xkd LNwN/rkYhLcg5MgP6k0eBqPDz9N7LTN0k+zHnF5lvSk2n7fla48ZQvoCgkyZnSbdMfjg=; Message-ID: <230cdac8-e09d-8581-1e87-012a69601091@xen.org> Date: Wed, 7 Sep 2022 16:38:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220907143532.15397-1-Henry.Wang@arm.com> <20220907143532.15397-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220907143532.15397-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/09/2022 15:35, Henry Wang wrote: > With the static heap setup, keep using xenheap_* in the function > setup_xenheap_mappings() will make the code confusing to read, > because we always need to map the full RAM on Arm64. Therefore, > renaming all "xenheap_*" variables to "directmap_*" to make clear > the area is used to access the RAM easily. You are also renaming a function. So I think it should be clarified in the commit message. With that: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 15:45:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 15:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402006.643987 (Exim 4.92) (envelope-from ) id 1oVxEw-0000Ua-8p; Wed, 07 Sep 2022 15:45:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402006.643987; Wed, 07 Sep 2022 15:45:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxEw-0000UT-60; Wed, 07 Sep 2022 15:45:22 +0000 Received: by outflank-mailman (input) for mailman id 402006; Wed, 07 Sep 2022 15:45:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxEv-0000UN-3f for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 15:45:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 133e26ad-2ec4-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 17:45:19 +0200 (CEST) Received: from AM6P192CA0079.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::20) by PAWPR08MB9099.eurprd08.prod.outlook.com (2603:10a6:102:343::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 15:45:17 +0000 Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::b2) by AM6P192CA0079.outlook.office365.com (2603:10a6:209:8d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 15:45:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 15:45:16 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 07 Sep 2022 15:45:16 +0000 Received: from 94905ddf24df.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6C38BD67-FB8F-4D5B-8F9E-ACFD08828DF9.1; Wed, 07 Sep 2022 15:45:09 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 94905ddf24df.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 15:45:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PA4PR08MB5949.eurprd08.prod.outlook.com (2603:10a6:102:eb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 15:45:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 15:45:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 133e26ad-2ec4-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Pt4DLXBpg7Nn1rK4H72L3Ky1/as1W9Yglzu83dLuzwFeo/noEkd0flp8sG0xyKhWVbRp40amZ5xFNl07d5gyEnxY8M8fHgVpmpcS31akkaeg2H1fabg/PC9eh8eCfuPIJHuo/WZc0NhVGl1TAH2KXluTxqqh3THTI5u3tmrdRPC6cx54o9w0iU7TLtAMHG0DAPci8CVETi3nfp7AHdDHFjLHvpu/O40DLRt6N7Z06q8ZfJR8boPRhXDMDSVrRCvP3EaWdV4KOS61OlDxr97cnGSk8ZKycYINQmCSD3ZPbPlWrQM29ouWAuNjB0zDBKvRFn6HxyioOQ8tb1LpxUuk0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mm7RCssHSVB72mF5TsSZZ6r3qwhKtdWpn7Zx+wr+95w=; b=ffxGbqh35azrGam5viKfUhEhBLVCUWHR6grtR+soOo/Ebh5RgtLeyxVhWvytNjUIYfKhFnvykzseER1rf5DHms/kxb5hH7YCJNu/WjnQr1BwHzkB6rhVMomAhkizpf+NIiNSNHli/kM7/2J4jBIxaz8/KeiIe0pK7Apq43Ejey4z1WjDHBgzCLi3C4YETAPuBcvzdYVnD3tOmPkYZauzkjECYa2knwHSnyJis6ZKD8joauVTtBCnCZ3qfglPght8VEymIqELgyFbbh/iXF8kw5154Xa73KPgo/TEHDhxQZloh8pN5bUljyyhOSzEtPGeaFSjupUJgycLvWQu/+nnQg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mm7RCssHSVB72mF5TsSZZ6r3qwhKtdWpn7Zx+wr+95w=; b=GqORUFPwVNz7xesQTa4tlD/x1jgDT4G3403XEe12DYlzhCepREfQnv2gVfFBOVHsPjDbDWFnw7msWff3N6H0P6iRuEtFCq+NHtUjhzPmUgAE5EJiB/o136oSiNipGCN9oS5ReZbx4Yk1iDShImM+ExfR0s/6qANRGeGXoRpUFUY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a6af11f5e0b8d906 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YctznOlrxOFex2awQCatqxZGK3LPkXZhJTKJ8AUAJmJNOLHdZmf2YenTun7+BIV8xZZqxPXLir3daad4VPlbokg332fB23+ks0WgUHYVcJJRp1MJp18ZT+bguNGuMO4iYieWIyEW22V8qaZstWwlhWzRVh16zrMJ237ahsPmVdUeM4R8wmGSfL8OqlNAOCku2L+IHyuf1XhomBT6L906E3QFAXhUsOOdWrU3U3vw3mFTxPvCkES48sO5CTNrTQ/plj70la1ZmfNGIVuxuWuaFs12AKe6aceiSxUi5GG72F/aPgi/CzZWTCvT3IgeeMNcR+EqJeF3MISbNj3tYNCdKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mm7RCssHSVB72mF5TsSZZ6r3qwhKtdWpn7Zx+wr+95w=; b=LO5mLZdTnj2hGkV7MvxJArBjkeOseRznbE8X3PUcTYGn6uvjdoR0Zd/8/+uCD3vmsFkNQza/TtJzYx1jOJ9Ug0/rYctheCsuezgCU+W5OCzMLJk40ZKkI6kTHf5wr0ul6ZU+MlUm9wrm8sWH258Jnqnjyl/5RALwbxcB8jFcbVaY/HrznVgUww9KPgudnXcwBiIOP9fCenbTmKaGjG6dTxWvwz6ailix0wVP7dLTozKPS+W07BNpQVgTJnL3lt0dxBXqIqjZNn4W50p1Gg2brvehMD8cF+r4vilhoXQH8KQoCVOYjDapOaWPv7f9/7ks4J0ZhUc4jSGoW1At2SlahA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mm7RCssHSVB72mF5TsSZZ6r3qwhKtdWpn7Zx+wr+95w=; b=GqORUFPwVNz7xesQTa4tlD/x1jgDT4G3403XEe12DYlzhCepREfQnv2gVfFBOVHsPjDbDWFnw7msWff3N6H0P6iRuEtFCq+NHtUjhzPmUgAE5EJiB/o136oSiNipGCN9oS5ReZbx4Yk1iDShImM+ExfR0s/6qANRGeGXoRpUFUY= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: Re: Unaligned access on arm32 Thread-Topic: Unaligned access on arm32 Thread-Index: AQHYws7Zew4zoBRJmEmNmoI/aV0uva3UG/wA Date: Wed, 7 Sep 2022 15:45:07 +0000 Message-ID: <0615D7B4-EB2F-4084-83C2-4C156BABFED0@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 640acb7e-344c-4e8e-603e-08da90e7f642 x-ms-traffictypediagnostic: PA4PR08MB5949:EE_|AM7EUR03FT051:EE_|PAWPR08MB9099:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nB7wl/ZZcWAE5E1jZl3kiXrSyuxrdfnJ0CjpvYBzOioRpzNObXD2AtX0iUjb44CkfhiBx/VdST8dJulbVSHiXpY/tqzJnqA4TPRJvX8uZeINUZ37B7VyQZRJhwZDFuZzpj9ralNEt6u6bNx6hNxMNcBrMsBsKeCr4q5a6tq6DklT2k09KC4vim7u9wEE9kVRaIMUzvPliE9/rFSkEaR9iFGeb1BAHjXvBn/kqLd3nP3FdzP/X4BQwrOh2CZ+0wkQBzKsWHTtqWY9vyfaFwRDIbtXKCv3gotmbtWNMPgbBMwtGj6whplv31u4HnDAwGGx5PyrQCAw44etrG81opb3WeObVVY7GyoIPUVuDYGPEE1ZMxXvWxnMs1P+XUIHvSOELUzrI/gHzNO87bMOAFYmAW90bT3euKEIMJUj/x78DlgBFVDv3NEEP/8pmHE8jvT3cazk0D+y8PwYI2WNYdEdEOQo9U1NXVkne+yIEhc5Kgcv79SNY7Q2FQSxOkmCPg7B9T5pFIXvxlB7TFSp4zab7szRgX1x4ymuZGShBJvk2L4zBCPemA5kBKXfyJHHdB2HgE3Fd24TZ7P4iirZrLt/QX3wQmZJP2+2lNidUAj5ki2ZVjXLCDHYL2b6PGFxJxMUAQKlftIry8go2e82aLUKQBzMB1boJt+MXXLZ7Qvo++RcqHF7NKdfhxn0VrmL688m8RkB89nBMNfYboYyC4sXEpi6S5ejZbSxP2RSzJ75bqdYHtvReziLDnwUwRgjlj0e4rxaMfbMx+B8ZxAWKaVrLFx7SpSD49pZ1hgzvfTxe7xl0pE6L1Mnp63B1mQ6DKXrNur9Vhzc9fc6FCi0S1cAjQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(38070700005)(8936002)(966005)(86362001)(33656002)(54906003)(6916009)(6486002)(316002)(478600001)(91956017)(41300700001)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(53546011)(8676002)(83380400001)(4326008)(6506007)(26005)(6512007)(2906002)(2616005)(186003)(122000001)(5660300002)(38100700002)(36756003)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5C8AADBBEB9FC34C859D5D4A3AB2772F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5949 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f81e0c1d-3acf-4e57-e800-08da90e7f071 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WFDYcm7pA46FsOUCWr0OZ/RTNeYvQBhVOu5ljxYqini6t/bwbLSfk1WQka29BZy+xX00aMjSxbYx+Tjx3OJ2cm0KgaHUVD/4cC48jHw4GSYw8t5/4ny149bI8GKCcGKVOLCU/ppxyIj9t13t6PS6C+veGNXEBj0WdX59yYcgK5sLV2X12g6WagW/jubShliBKoNEGKJPpUpq4zd+TaMdRfQCFLjwZOZCgEInIHpsEUB2Rjn6z030D42+p17MUjalX/z0RFTVyhFu31uobU1oOllG5qglFDdHjq4zZg+94TK6PhBgLc40pff8oEP2hYKRIQ5PjnGzeJx/mLIg+Maft8Qe4T01dKHfZON5AIvmix5k8CzIiNQkBIGTLdLSWbgJlC8fLLQslfDcexPvZgWNykE1z99X7jhhTems4GPoaFUe6qsnznohTiwxQZoY4S9z7+upCsxBPkIFvQoAk+rX5/ZhQh9Ta6+IANhx5XfrVRTbK6ofpf0SX36bD4xXB5SHcsztFMHx4dWyHFN6MXPd83dcQsP6jFYCH2tP2KiRR/a7JDoqT6QbfCW+kW3OCyALhDxntzr9KoMosd7l0IHkgcyCwzCoTvw/Q2Vn4bUkv2OSw7AkcFm3trWBi+RJakhfVC8MSnDla8XcIoM1l6gKln+fBTWL0s6dEpU5lMI6SEptpbYILcTm50eFUi5JNx93RePSi0OhSgtqFHejPtOQj11w5pUKh+AGfGUUWlpxA2GkQPnAkc9K+B+pDgWan/oMXN9Uiaj610tb8kvJwVSy0Se27yZzmNbQtQPR33Ap984= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(39860400002)(346002)(46966006)(40470700004)(36840700001)(336012)(41300700001)(47076005)(8676002)(70586007)(2906002)(2616005)(316002)(4326008)(186003)(54906003)(70206006)(478600001)(53546011)(36756003)(40480700001)(26005)(33656002)(6506007)(83380400001)(36860700001)(356005)(86362001)(82310400005)(82740400003)(6512007)(966005)(5660300002)(81166007)(6862004)(8936002)(6486002)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 15:45:16.9111 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 640acb7e-344c-4e8e-603e-08da90e7f642 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9099 Hi Julien, > On 7 Sep 2022, at 16:30, Julien Grall wrote: >=20 > Hi all, >=20 > I think mentioned it privately a while a go, but never sent an e-mail abo= ut it. >=20 > While testing arm32 with IOREQ, I noticed Xen is crashing because an alig= nment fault: >=20 > (XEN) Data Abort Trap. Syndrome=3D0x1800061 > (XEN) Walking Hypervisor VA 0x40027ebb on CPU0 via TTBR 0x000000004012f00= 0 > (XEN) 1ST[0x001] =3D 0x00400000bbffff7f > (XEN) 2ND[0x000] =3D 0x00500000bc000f7d > (XEN) CPU0: Unexpected Trap: Data Abort > (XEN) ----[ Xen-4.17-unstable arm32 debug=3Dn Tainted: C ]---- > (XEN) CPU: 0 > (XEN) PC: 002613b8 try_fwd_ioserv+0x44/0x1bc > (XEN) CPSR: 6000005a MODE:Hypervisor > (XEN) R0: 00000000 R1: 00000001 R2: 0022a748 R3: 00000006 > (XEN) R4: 40027f20 R5: 40027f58 R6: 40028000 R7: 00000000 > (XEN) R8: 40027f20 R9: 4003a438 R10:002f0044 R11:40027edc R12:000000= 02 > (XEN) HYP: SP: 40027e94 LR: 00260edc > (XEN) > (XEN) VTCR_EL2: 80003558 > (XEN) VTTBR_EL2: 00010000bbff8000 > (XEN) > (XEN) SCTLR_EL2: 30cd187f > (XEN) HCR_EL2: 007c663f > (XEN) TTBR0_EL2: 000000004012f000 > (XEN) > (XEN) ESR_EL2: 97800061 > (XEN) HPFAR_EL2: 0067faf0 > (XEN) HDFAR: 40027ebb > (XEN) HIFAR: 67600000 > (XEN) > (XEN) Xen stack trace from sp=3D40027e94: > (XEN) 97800061 0022a748 00000001 00000000 8000005a 00800000 4003a000 0= 0000001 > (XEN) 4003a180 00000000 bbff47ff 00000000 67faf200 00000000 4003a000 4= 0027f20 > (XEN) 4003a438 40027f1c 00260edc 002f0110 40027f58 40028000 4003a000 0= 000013b > (XEN) 40028000 002f0280 00000090 40027f58 67faf200 93820006 67faf200 0= 0000000 > (XEN) 00000000 40027f54 0026b6ac 93820006 0022a748 00000001 00000004 6= 7faf200 > (XEN) 00000000 00000000 00000000 00000000 ffffffff 68000000 400001d3 4= 0027f58 > (XEN) 00201870 60000000 67601324 67faf200 00000000 00000013 00000000 0= 0000000 > (XEN) ffffffff 68000000 400001d3 00000000 00000000 00000000 ffffffff 0= 0000000 > (XEN) 67601074 000001d3 93820006 00000000 00000000 00000000 00000000 6= 7601008 > (XEN) 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0= 0000000 > (XEN) 00000000 00000000 00000000 400001d3 00000000 00000000 00000000 0= 0000000 > (XEN) 00000000 00000000 00000001 > (XEN) Xen call trace: > (XEN) [<002613b8>] try_fwd_ioserv+0x44/0x1bc (PC) > (XEN) [<00260edc>] try_handle_mmio+0x2b0/0x2f4 (LR) > (XEN) [<00260edc>] try_handle_mmio+0x2b0/0x2f4 > (XEN) [<0026b6ac>] arch/arm/traps.c#do_trap_stage2_abort_guest+0x18c/0= x34c > (XEN) [<00201870>] entry.o#return_from_trap+0/0x4 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) CPU0: Unexpected Trap: Data Abort > (XEN) **************************************** >=20 > The disassembled code is: >=20 > 00261374 : > 261374: e16d42f0 strd r4, [sp, #-32]! ; 0xffffffe0 > 261378: e1a04002 mov r4, r2 > 26137c: e1a05000 mov r5, r0 > 261380: e1cd60f8 strd r6, [sp, #8] > 261384: e3a00000 mov r0, #0 > 261388: e1a06001 mov r6, r1 > 26138c: e1cd81f0 strd r8, [sp, #16] > 261390: e3a01001 mov r1, #1 > 261394: e58db018 str fp, [sp, #24] > 261398: e28db01c add fp, sp, #28 > 26139c: e58de01c str lr, [sp, #28] > 2613a0: e24dd028 sub sp, sp, #40 ; 0x28 > 2613a4: e1c220d4 ldrd r2, [r2, #4] > 2613a8: e50b0024 str r0, [fp, #-36] ; 0xffffffdc > 2613ac: e5d67a26 ldrb r7, [r6, #2598] ; 0xa26 > 2613b0: e14b24f4 strd r2, [fp, #-68] ; 0xffffffbc > 2613b4: e5d43000 ldrb r3, [r4] > * 2613b8: e50b0021 str r0, [fp, #-33] ; 0xffffffdf >=20 > The problem is GCC [1] decided to use 'str' for accessing an address that= is not 32-bit aligned (fp - 33 =3D 0x40027e73). On arm32, we are forbiddin= g aligned access, hence why it crashed. >=20 > Looking online, it looks like GCC has an option to turned on/off the use = of unaligned access [2] and it is enabled by default on ARMv7 (I am not sur= e why we didn't notice this before...). >=20 > I have rebuilt Xen with the option turn off and dom0 is now booting fine. >=20 > However, I am a bit puzzled because the C code didn't contain unaligned a= ccess. It was all introduced by the compiler itself. This is breaking our a= ssumption that the compiler will not break down correctly naturally aligned= access. Strictly speaking without the option the compiler does not say that it will= not generate unaligned access so nothing forbids it to generate some. So I doubt we could argue that the compiler did something wrong here (there= might be a debate on why it did so as the C code is not doing one). >=20 > When using the new option, Xen size is increasing by 0.40% (about ~3KB) i= n my setup. Nothing too concerning, but I would like to have some opinion f= irst. >=20 > The alternative would be to allow unaligned access. That said, I think th= is is much saner to have a strict enforcement as we can catch GCC trying to= do unaligned access when it is not expected. >=20 > There is also the argument that unaligned access can be slower on some pl= atform. So it is better to avoid them. >=20 > Any thoughts? I think we need to be coherent: if we are not allowing unaligned access the= n we should explicitly ask the compiler not generate some, so here one way = or the other we need to add the compiler option. Now on arm32, unaligned access might be slower and seeing the size increase= I would vote to stay as is to detect them and pass the compiler option to = not do any. Cheers Bertrand >=20 > Cheers, >=20 > [1] gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-15) > [2] https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/ARM-Options.html >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:28:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:28:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402024.644005 (Exim 4.92) (envelope-from ) id 1oVxu4-00068F-Kt; Wed, 07 Sep 2022 16:27:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402024.644005; Wed, 07 Sep 2022 16:27:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxu4-000688-IG; Wed, 07 Sep 2022 16:27:52 +0000 Received: by outflank-mailman (input) for mailman id 402024; Wed, 07 Sep 2022 16:27:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxu2-000682-UU for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:27:50 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 03332409-2eca-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 18:27:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF393106F; Wed, 7 Sep 2022 09:27:54 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63CFB3F71A; Wed, 7 Sep 2022 09:27:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03332409-2eca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v5 0/7] xen/evtchn: implement static event channel signaling Date: Wed, 7 Sep 2022 17:27:31 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The purpose of this patch series is to add the static event channel signaling support to Xen on Arm based on design doc [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg01160.html Julien Grall (1): xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Rahul Singh (5): xen/evtchn: restrict the maximum number of evtchn supported for domUs xen/evtchn: modify evtchn_alloc_unbound to allocate specified port xen/evtchn: modify evtchn_bind_interdomain to support static evtchn xen/arm: introduce new xen,enhanced property value xen/arm: introduce xen-evtchn dom0less property Stanislav Kinsburskii (1): xen/evtchn: Add an helper to reserve/allocate a port docs/misc/arm/device-tree/booting.txt | 102 ++++++++++++++++ xen/arch/arm/domain_build.c | 167 +++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 23 +++- xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 2 + xen/common/event_channel.c | 121 ++++++++++++------- xen/include/xen/device_tree.h | 16 +++ xen/include/xen/event.h | 8 +- 8 files changed, 387 insertions(+), 53 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402033.644017 (Exim 4.92) (envelope-from ) id 1oVxuk-0006jl-1T; Wed, 07 Sep 2022 16:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402033.644017; Wed, 07 Sep 2022 16:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxuj-0006je-U7; Wed, 07 Sep 2022 16:28:33 +0000 Received: by outflank-mailman (input) for mailman id 402033; Wed, 07 Sep 2022 16:28:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxuj-000682-03 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:28:33 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1c8e195e-2eca-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 18:28:31 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 904EF106F; Wed, 7 Sep 2022 09:28:37 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 169793F71A; Wed, 7 Sep 2022 09:28:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c8e195e-2eca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Michal Orzel Subject: [PATCH v5 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Date: Wed, 7 Sep 2022 17:27:32 +0100 Message-Id: <096c629d137faacdc15f866aaff52bd4663ca058.1662563170.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event channels code assumes that all the buckets below d->valid_evtchns are always allocated. This assumption hold in most of the situation because a guest is not allowed to chose the port. Instead, it will be the first free from port 0. When static event channel support will be added for dom0less domains user can request to allocate the evtchn port numbers that are scattered in nature. The existing implementation of evtchn_allocate_port() is not able to deal with such situation and will end up to override bucket or/and leave some bucket unallocated. The latter will result to a droplet crash if the event channel belongs to an unallocated bucket. This can be solved by making sure that all the buckets below d->valid_evtchns are allocated. There should be no impact for most of the situation but LM/LU as only one bucket would be allocated. For LM/LU, we may end up to allocate multiple buckets if ports in use are sparse. A potential alternative is to check that the bucket is valid in is_port_valid(). This should still possible to do it without taking per-domain lock but will result a couple more of memory access. Signed-off-by: Julien Grall Signed-off-by: Rahul Singh Reviewed-by: Michal Orzel Reviewed-by: Jan Beulich --- Changes in v5: - Added Jan Reviewed-by Changes in v4: - fix comment to remove the reference to Guest Transparent Migration and Live Update - Added Michal Reviewed-by Changes in v3: - fix comments in commit msg. - modify code related to d->valid_evtchns and {read,write}_atomic() Changes in v2: - new patch in this version to avoid the security issue --- xen/common/event_channel.c | 55 ++++++++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 20 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index c2c6f8c151..f81c229358 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -193,6 +193,15 @@ static struct evtchn *alloc_evtchn_bucket(struct domain *d, unsigned int port) return NULL; } +/* + * Allocate a given port and ensure all the buckets up to that ports + * have been allocated. + * + * The last part is important because the rest of the event channel code + * relies on all the buckets up to d->valid_evtchns to be valid. However, + * event channels may be sparsed when allocating the static evtchn port + * numbers that are scattered in nature. + */ int evtchn_allocate_port(struct domain *d, evtchn_port_t port) { if ( port > d->max_evtchn_port || port >= max_evtchns(d) ) @@ -207,30 +216,36 @@ int evtchn_allocate_port(struct domain *d, evtchn_port_t port) } else { - struct evtchn *chn; - struct evtchn **grp; + unsigned int alloc_port = read_atomic(&d->valid_evtchns); - if ( !group_from_port(d, port) ) + do { - grp = xzalloc_array(struct evtchn *, BUCKETS_PER_GROUP); - if ( !grp ) - return -ENOMEM; - group_from_port(d, port) = grp; - } + struct evtchn *chn; + struct evtchn **grp; - chn = alloc_evtchn_bucket(d, port); - if ( !chn ) - return -ENOMEM; - bucket_from_port(d, port) = chn; + if ( !group_from_port(d, alloc_port) ) + { + grp = xzalloc_array(struct evtchn *, BUCKETS_PER_GROUP); + if ( !grp ) + return -ENOMEM; + group_from_port(d, alloc_port) = grp; + } - /* - * d->valid_evtchns is used to check whether the bucket can be - * accessed without the per-domain lock. Therefore, - * d->valid_evtchns should be seen *after* the new bucket has - * been setup. - */ - smp_wmb(); - write_atomic(&d->valid_evtchns, d->valid_evtchns + EVTCHNS_PER_BUCKET); + chn = alloc_evtchn_bucket(d, alloc_port); + if ( !chn ) + return -ENOMEM; + bucket_from_port(d, alloc_port) = chn; + + /* + * d->valid_evtchns is used to check whether the bucket can be + * accessed without the per-domain lock. Therefore, + * d->valid_evtchns should be seen *after* the new bucket has + * been setup. + */ + smp_wmb(); + alloc_port += EVTCHNS_PER_BUCKET; + write_atomic(&d->valid_evtchns, alloc_port); + } while ( port >= alloc_port ); } write_atomic(&d->active_evtchns, d->active_evtchns + 1); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:29:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:29:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402041.644028 (Exim 4.92) (envelope-from ) id 1oVxvX-0007UV-BL; Wed, 07 Sep 2022 16:29:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402041.644028; Wed, 07 Sep 2022 16:29:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxvX-0007UO-7E; Wed, 07 Sep 2022 16:29:23 +0000 Received: by outflank-mailman (input) for mailman id 402041; Wed, 07 Sep 2022 16:29:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxvV-000682-QW for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:29:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 39d1e955-2eca-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 18:29:20 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99B98106F; Wed, 7 Sep 2022 09:29:26 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FDA63F71A; Wed, 7 Sep 2022 09:29:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39d1e955-2eca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stanislav Kinsburskii , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v5 2/7] xen/evtchn: Add an helper to reserve/allocate a port Date: Wed, 7 Sep 2022 17:27:33 +0100 Message-Id: <11ffc2554cc30c0764b8645905983772417e5d70.1662563170.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stanislav Kinsburskii In a follow-up patch we will want to either reserve or allocate a port for various event channel helpers. A new wrapper is introduced to either reserve a given port or allocate a fresh one if zero. Take the opportunity to replace the open-coded version in evtchn_bind_virq(). Signed-off-by: Stanislav Kinsburskii Signed-off-by: Julien Grall Signed-off-by: Rahul Singh Acked-by: Jan Beulich --- Changes in v5: - no changes Changes in v4: - Change the Author to Stanislav Kinsburskii Changes in v3: - minor comments in commit msg Changes in v2: - new patch in this version --- xen/common/event_channel.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index f81c229358..565ab71881 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -305,6 +305,18 @@ void evtchn_free(struct domain *d, struct evtchn *chn) xsm_evtchn_close_post(chn); } +static int evtchn_get_port(struct domain *d, evtchn_port_t port) +{ + int rc; + + if ( port != 0 ) + rc = evtchn_allocate_port(d, port); + else + rc = get_free_port(d); + + return rc ?: port; +} + int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) { struct evtchn *chn; @@ -462,19 +474,10 @@ int evtchn_bind_virq(evtchn_bind_virq_t *bind, evtchn_port_t port) if ( read_atomic(&v->virq_to_evtchn[virq]) ) ERROR_EXIT(-EEXIST); - if ( port != 0 ) - { - if ( (rc = evtchn_allocate_port(d, port)) != 0 ) - ERROR_EXIT(rc); - } - else - { - int alloc_port = get_free_port(d); - - if ( alloc_port < 0 ) - ERROR_EXIT(alloc_port); - port = alloc_port; - } + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; chn = evtchn_from_port(d, port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:29:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:29:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402049.644038 (Exim 4.92) (envelope-from ) id 1oVxw7-00083Q-IR; Wed, 07 Sep 2022 16:29:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402049.644038; Wed, 07 Sep 2022 16:29:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxw7-00083J-Fr; Wed, 07 Sep 2022 16:29:59 +0000 Received: by outflank-mailman (input) for mailman id 402049; Wed, 07 Sep 2022 16:29:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxw5-000836-VC for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:29:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4f3d63e8-2eca-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 18:29:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A10E7106F; Wed, 7 Sep 2022 09:30:02 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CAD13F71A; Wed, 7 Sep 2022 09:29:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f3d63e8-2eca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel , Julien Grall Subject: [PATCH v5 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs Date: Wed, 7 Sep 2022 17:27:34 +0100 Message-Id: <7506434543e6abb86b11f198970a6d07cd06e428.1662563170.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Set the default value of max_evtchn_port to 1023. The value of 1023 should be sufficient for guests because on ARM we don't bind physical interrupts to event channels. The only use of the evtchn port is inter-domain communications. Another reason why we choose the value of 1023 is to follow the default behavior of libxl. Signed-off-by: Rahul Singh Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes in v5: - fix minor comments - Added Julien Acked-by Changes in v4: - fix minor comments in commit msg - Added Michal Reviewed-by Changes in v3: - added in commit msg why we set the max_evtchn_port value to 1023. - added the comment in code also why we set the max_evtchn_port to 1023 - remove the define and set the value to 1023 in code directly. Changes in v2: - new patch in the version --- xen/arch/arm/domain_build.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..e1f46308d9 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3277,7 +3277,13 @@ void __init create_domUs(void) struct xen_domctl_createdomain d_cfg = { .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - .max_evtchn_port = -1, + /* + * The default of 1023 should be sufficient for guests because + * on ARM we don't bind physical interrupts to event channels. + * The only use of the evtchn port is inter-domain communications. + * 1023 is also the default value used in libxl. + */ + .max_evtchn_port = 1023, .max_grant_frames = -1, .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:30:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:30:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402057.644050 (Exim 4.92) (envelope-from ) id 1oVxwm-0000yu-S1; Wed, 07 Sep 2022 16:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402057.644050; Wed, 07 Sep 2022 16:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxwm-0000yn-P2; Wed, 07 Sep 2022 16:30:40 +0000 Received: by outflank-mailman (input) for mailman id 402057; Wed, 07 Sep 2022 16:30:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxwk-0007z7-TO for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:30:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 67b204a3-2eca-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 18:30:37 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57F9B106F; Wed, 7 Sep 2022 09:30:43 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B75F93F71A; Wed, 7 Sep 2022 09:30:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67b204a3-2eca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Julien Grall Subject: [PATCH v5 4/7] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Date: Wed, 7 Sep 2022 17:27:35 +0100 Message-Id: <3201593401c899d7b698ad744cb9cc42fa9a6436.1662563170.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently evtchn_alloc_unbound() always allocates the next available port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_alloc_unbound() to accept the port number as an argument and allocate the specified port if available. If the port number argument is zero, the next available port will be allocated. Signed-off-by: Rahul Singh Acked-by: Jan Beulich Reviewed-by: Julien Grall --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix minor comments in commit msg Changes in v2: - fix minor comments --- xen/arch/arm/domain_build.c | 2 +- xen/common/event_channel.c | 17 ++++++++++++----- xen/include/xen/event.h | 3 ++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index e1f46308d9..4664a8f961 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3171,7 +3171,7 @@ static int __init alloc_xenstore_evtchn(struct domain *d) alloc.dom = d->domain_id; alloc.remote_dom = hardware_domain->domain_id; - rc = evtchn_alloc_unbound(&alloc); + rc = evtchn_alloc_unbound(&alloc, 0); if ( rc ) { printk("Failed allocating event channel for domain\n"); diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 565ab71881..f546e81758 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -317,11 +317,15 @@ static int evtchn_get_port(struct domain *d, evtchn_port_t port) return rc ?: port; } -int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) +/* + * If port is zero get the next free port and allocate. If port is non-zero + * allocate the specified port. + */ +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, evtchn_port_t port) { struct evtchn *chn; struct domain *d; - int port, rc; + int rc; domid_t dom = alloc->dom; d = rcu_lock_domain_by_any_id(dom); @@ -330,8 +334,11 @@ int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) write_lock(&d->event_lock); - if ( (port = get_free_port(d)) < 0 ) - ERROR_EXIT_DOM(port, d); + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; + chn = evtchn_from_port(d, port); rc = xsm_evtchn_unbound(XSM_TARGET, d, chn, alloc->remote_dom); @@ -1222,7 +1229,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) struct evtchn_alloc_unbound alloc_unbound; if ( copy_from_guest(&alloc_unbound, arg, 1) != 0 ) return -EFAULT; - rc = evtchn_alloc_unbound(&alloc_unbound); + rc = evtchn_alloc_unbound(&alloc_unbound, 0); if ( !rc && __copy_to_guest(arg, &alloc_unbound, 1) ) rc = -EFAULT; /* Cleaning up here would be a mess! */ break; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index f3021fe304..f31963703f 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -72,7 +72,8 @@ void evtchn_free(struct domain *d, struct evtchn *chn); int evtchn_allocate_port(struct domain *d, unsigned int port); /* Allocate a new event channel */ -int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc); +int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, + evtchn_port_t port); /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:32:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:32:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402065.644061 (Exim 4.92) (envelope-from ) id 1oVxyV-0001dk-6t; Wed, 07 Sep 2022 16:32:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402065.644061; Wed, 07 Sep 2022 16:32:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxyV-0001dd-3s; Wed, 07 Sep 2022 16:32:27 +0000 Received: by outflank-mailman (input) for mailman id 402065; Wed, 07 Sep 2022 16:32:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxyT-0001dU-28 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:32:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a695c816-2eca-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 18:32:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 262AC13D5; Wed, 7 Sep 2022 09:32:29 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16CBD3F71A; Wed, 7 Sep 2022 09:32:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a695c816-2eca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v5 6/7] xen/arm: introduce new xen,enhanced property value Date: Wed, 7 Sep 2022 17:27:37 +0100 Message-Id: <97b7eb518101b403c6e90052aaeeaa50e5ac2c79.1662563170.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to disable xenstore interface for dom0less guests. Signed-off-by: Rahul Singh --- Changes in v5: - fix minor comments - change unit64_t to uint16_t for dom0less_feature Changes in v4: - Implement defines for dom0less features Changes in v3: - new patch in this version --- docs/misc/arm/device-tree/booting.txt | 4 ++++ xen/arch/arm/domain_build.c | 10 ++++++---- xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- 3 files changed, 31 insertions(+), 6 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..47567b3906 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -204,6 +204,10 @@ with the following properties: - "disabled" Xen PV interfaces are disabled. + - "no-xenstore" + All default Xen PV interfaces, including grant-table will be enabled but + xenstore will be disabled for the VM. + If the xen,enhanced property is present with no value, it defaults to "enabled". If the xen,enhanced property is not present, PV interfaces are disabled. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4664a8f961..580ed70b9c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) goto err; } - if ( kinfo->dom0less_enhanced ) + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) { ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); if ( ret ) @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *d, (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) { if ( hardware_domain ) - kinfo.dom0less_enhanced = true; + kinfo.dom0less_feature = DOM0LESS_ENHANCED; else - panic("Tried to use xen,enhanced without dom0\n"); + panic("At the moment, Xenstore support requires dom0 to be present\n"); } + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) + kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; if ( vcpu_create(d, 0) == NULL ) return -ENOMEM; @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, if ( rc < 0 ) return rc; - if ( kinfo.dom0less_enhanced ) + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) { ASSERT(hardware_domain); rc = alloc_xenstore_evtchn(d); diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index c4dc039b54..f8bb85767b 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -9,6 +9,25 @@ #include #include +/* + * List of possible features for dom0less domUs + * + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. All the + * default features (excluding Xenstore) will be + * available. Note that an OS *must* not rely on the + * availability of Xen features if this is not set. + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature + * can't be enabled without the + * DOM0LESS_ENHANCED_NO_XS. + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the + * default features (including Xenstore) will be + * available. Note that an OS *must* not rely on the + * availability of Xen features if this is not set. + */ +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) +#define DOM0LESS_XENSTORE BIT(1, U) +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XENSTORE) + struct kernel_info { #ifdef CONFIG_ARM_64 enum domain_type type; @@ -36,8 +55,8 @@ struct kernel_info { /* Enable pl011 emulation */ bool vpl011; - /* Enable PV drivers */ - bool dom0less_enhanced; + /* Enable/Disable PV drivers interfaces */ + uint16_t dom0less_feature; /* GIC phandle */ uint32_t phandle_gic; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:32:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402068.644072 (Exim 4.92) (envelope-from ) id 1oVxyi-0001zV-Gg; Wed, 07 Sep 2022 16:32:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402068.644072; Wed, 07 Sep 2022 16:32:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxyi-0001ys-Ck; Wed, 07 Sep 2022 16:32:40 +0000 Received: by outflank-mailman (input) for mailman id 402068; Wed, 07 Sep 2022 16:32:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxyh-0001dU-Mn for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:32:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id af70ebc6-2eca-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 18:32:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E840D13D5; Wed, 7 Sep 2022 09:32:43 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BDB6E3F71A; Wed, 7 Sep 2022 09:32:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af70ebc6-2eca-11ed-a016-b9edf5238543 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v5 7/7] xen/arm: introduce xen-evtchn dom0less property Date: Wed, 7 Sep 2022 17:27:38 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send notifications to each other. Signed-off-by: Rahul Singh --- Changes in v5: - fix minor comments Changes in v4: - move documentation to common place for evtchn node in booting.txt - Add comment why we use dt_device_static_evtchn_created() - check if dt_get_parent() returns NULL - fold process_static_evtchn_node() in alloc_static_evtchn() Changes in v3: - use device-tree used_by to find the domain id of the evtchn node. - add new static_evtchn_create variable in struct dt_device_node to hold the information if evtchn is already created. - fix minor comments Changes in v2: - no change --- --- docs/misc/arm/device-tree/booting.txt | 98 +++++++++++++++++ xen/arch/arm/domain_build.c | 147 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 2 + xen/include/xen/device_tree.h | 16 +++ 5 files changed, 264 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 47567b3906..e03e5e9e4c 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -382,3 +382,101 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Event Channel +==================== +The event channel communication will be established statically between two +domains (dom0 and domU also). Event channel connection information between +domains will be passed to Xen via the device tree node. The event channel +will be created and established in Xen before the domain started. The domain +does not need to do any operation to establish a connection. Domain only +needs hypercall EVTCHNOP_send(local port) to send notifications to the +remote guest. + +There is no need to describe the static event channel info in the domU device +tree. Static event channels are only useful in fully static configurations, +and in those configurations, the domU device tree dynamically generated by Xen +is not needed. + +To enable the event-channel interface for domU guests include the +xen,enhanced = "no-xenstore" property in the domU Xen device tree node. + +Under the "xen,domain" compatible node for domU, there needs to be sub-nodes +with compatible "xen,evtchn" that describe the event channel connection +between two domUs. For dom0, there needs to be sub-nodes with compatible +"xen,evtchn" under the chosen node. + +The static event channel node has the following properties: + +- compatible + + "xen,evtchn" + +- xen,evtchn + + The property is tuples of two numbers + (local-evtchn link-to-foreign-evtchn) where: + + local-evtchn is an integer value that will be used to allocate local port + for a domain to send and receive event notifications to/from the remote + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. + It is recommended to use low event channel IDs. + + link-to-foreign-evtchn is a single phandle to a remote evtchn to which + local-evtchn will be connected. + +Example +======= + +chosen { + + /* One sub-node per local event channel. This sub-node is for Dom0. */ + ec1: evtchn@1 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec2>; + }; + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x2>; + #size-cells = <0x1>; + xen,enhanced = "no-xenstore"; + + /* One sub-node per local event channel */ + ec2: evtchn@2 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec1>; + }; + + ec3: evtchn@3 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xb &ec5>; + }; + + ec4: evtchn@4 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xc &ec6>; + }; + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x2>; + #size-cells = <0x1>; + xen,enhanced = "no-xenstore"; + + /* One sub-node per local event channel */ + ec5: evtchn@5 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xb &ec3>; + }; + + ec6: evtchn@6 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xd &ec4>; + }; + }; +}; diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 580ed70b9c..1a59bd7e29 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -33,6 +33,8 @@ #include #include +#define STATIC_EVTCHN_NODE_SIZE_CELLS 2 + static unsigned int __initdata opt_dom0_max_vcpus; integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); @@ -3052,6 +3054,150 @@ void __init evtchn_allocate(struct domain *d) d->arch.hvm.params[HVM_PARAM_CALLBACK_IRQ] = val; } +static int __init get_evtchn_dt_property(const struct dt_device_node *np, + uint32_t *port, uint32_t *phandle) +{ + const __be32 *prop = NULL; + uint32_t len; + + prop = dt_get_property(np, "xen,evtchn", &len); + if ( !prop ) + { + printk(XENLOG_ERR "xen,evtchn property should not be empty.\n"); + return -EINVAL; + } + + if ( !len || len < dt_cells_to_size(STATIC_EVTCHN_NODE_SIZE_CELLS) ) + { + printk(XENLOG_ERR "xen,evtchn property value is not valid.\n"); + return -EINVAL; + } + + *port = dt_next_cell(1, &prop); + *phandle = dt_next_cell(1, &prop); + + return 0; +} + +static int __init alloc_domain_evtchn(struct dt_device_node *node) +{ + int rc; + uint32_t domU1_port, domU2_port, remote_phandle; + struct dt_device_node *remote_node; + const struct dt_device_node *p1_node, *p2_node; + struct evtchn_alloc_unbound alloc_unbound; + struct evtchn_bind_interdomain bind_interdomain; + struct domain *d1 = NULL, *d2 = NULL; + + if ( !dt_device_is_compatible(node, "xen,evtchn-v1") ) + return 0; + + /* + * Event channel is already created while parsing the other side of + * evtchn node. + */ + if ( dt_device_static_evtchn_created(node) ) + return 0; + + rc = get_evtchn_dt_property(node, &domU1_port, &remote_phandle); + if ( rc ) + return rc; + + remote_node = dt_find_node_by_phandle(remote_phandle); + if ( !remote_node ) + { + printk(XENLOG_ERR + "evtchn: could not find remote evtchn phandle\n"); + return -EINVAL; + } + + rc = get_evtchn_dt_property(remote_node, &domU2_port, &remote_phandle); + if ( rc ) + return rc; + + if ( node->phandle != remote_phandle ) + { + printk(XENLOG_ERR "xen,evtchn property is not setup correctly.\n"); + return -EINVAL; + } + + p1_node = dt_get_parent(node); + if ( !p1_node ) + { + printk(XENLOG_ERR "evtchn: evtchn parent node is NULL\n" ); + return -EINVAL; + } + + p2_node = dt_get_parent(remote_node); + if ( !p2_node ) + { + printk(XENLOG_ERR "evtchn: remote parent node is NULL\n" ); + return -EINVAL; + } + + d1 = get_domain_by_id(p1_node->used_by); + d2 = get_domain_by_id(p2_node->used_by); + + if ( !d1 || !d2 ) + { + printk(XENLOG_ERR "evtchn: could not find domains\n" ); + return -EINVAL; + } + + alloc_unbound.dom = d1->domain_id; + alloc_unbound.remote_dom = d2->domain_id; + + rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); + if ( rc < 0 ) + { + printk(XENLOG_ERR + "evtchn_alloc_unbound() failure (Error %d) \n", rc); + return rc; + } + + bind_interdomain.remote_dom = d1->domain_id; + bind_interdomain.remote_port = domU1_port; + + rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port); + if ( rc < 0 ) + { + printk(XENLOG_ERR + "evtchn_bind_interdomain() failure (Error %d) \n", rc); + return rc; + } + + dt_device_set_static_evtchn_created(node); + dt_device_set_static_evtchn_created(remote_node); + + return 0; +} + +void __init alloc_static_evtchn(void) +{ + struct dt_device_node *node, *evtchn_node; + struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); + + BUG_ON(chosen == NULL); + + if ( hardware_domain ) + dt_device_set_used_by(chosen, hardware_domain->domain_id); + + dt_for_each_child_node(chosen, node) + { + if ( hardware_domain ) + { + if ( alloc_domain_evtchn(node) != 0 ) + panic("Could not set up domains evtchn\n"); + } + + dt_for_each_child_node(node, evtchn_node) + { + if ( alloc_domain_evtchn(evtchn_node) != 0 ) + panic("Could not set up domains evtchn\n"); + } + } +} + static void __init find_gnttab_region(struct domain *d, struct kernel_info *kinfo) { @@ -3369,6 +3515,7 @@ void __init create_domUs(void) panic("Error creating domain %s\n", dt_node_name(node)); d->is_console = true; + dt_device_set_used_by(node, d->domain_id); if ( construct_domU(d, node) != 0 ) panic("Could not set up domain %s\n", dt_node_name(node)); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..5ee28b270f 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -106,6 +106,7 @@ int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); void create_domUs(void); void create_dom0(void); +void alloc_static_evtchn(void); void discard_initial_modules(void); void fw_unreserved_regions(paddr_t s, paddr_t e, diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 7814fe323d..909013992e 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1078,6 +1078,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); + alloc_static_evtchn(); + /* * This needs to be called **before** heap_init_late() so modules * will be scrubbed (unless suppressed). diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 430a1ef445..a28937d12a 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -92,6 +92,10 @@ struct dt_device_node { /* IOMMU specific fields */ bool is_protected; + + /* HACK: Remove this if there is a need of space */ + bool_t static_evtchn_created; + /* * The main purpose of this list is to link the structure in the list * of devices assigned to domain. @@ -317,6 +321,18 @@ static inline bool_t dt_property_name_is_equal(const struct dt_property *pp, return !dt_prop_cmp(pp->name, name); } +static inline void +dt_device_set_static_evtchn_created(struct dt_device_node *device) +{ + device->static_evtchn_created = true; +} + +static inline bool_t +dt_device_static_evtchn_created(const struct dt_device_node *device) +{ + return device->static_evtchn_created; +} + /** * dt_find_compatible_node - Find a node based on type and one of the * tokens in its "compatible" property -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 16:39:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 16:39:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402085.644083 (Exim 4.92) (envelope-from ) id 1oVy4x-000339-9P; Wed, 07 Sep 2022 16:39:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402085.644083; Wed, 07 Sep 2022 16:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVy4x-000332-5k; Wed, 07 Sep 2022 16:39:07 +0000 Received: by outflank-mailman (input) for mailman id 402085; Wed, 07 Sep 2022 16:39:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVxxG-0007z7-5L for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 16:31:10 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7a5220fd-2eca-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 18:31:09 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3EAD13D5; Wed, 7 Sep 2022 09:31:14 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5515B3F71A; Wed, 7 Sep 2022 09:31:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a5220fd-2eca-11ed-af93-0125da4c0113 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v5 5/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn Date: Wed, 7 Sep 2022 17:27:36 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Static event channel support will be added for dom0less domains. Modify evtchn_bind_interdomain to support static evtchn. It is necessary to have access to the evtchn_bind_interdomain function to do that, so make evtchn_bind_interdomain global and also make it __must_check. Currently evtchn_bind_interdomain() always allocates the next available local port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_bind_interdomain to accept the port number as an argument and allocate the specified port if available. If the port number argument is zero, the next available port will be allocated. Currently evtchn_bind_interdomain() finds the local domain from "current->domain" pointer. evtchn_bind_interdomain() will be called from the XEN to create static event channel during domain creation. "current" pointer is not valid at that time, therefore modify the evtchn_bind_interdomain() to pass domain as an argument. Signed-off-by: Rahul Singh Acked-by: Jan Beulich Reviewed-by: Julien Grall --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix minor comments in commit msg Changes in v2: - Merged patches related to evtchn_bind_interdomain in one patch --- xen/common/event_channel.c | 20 ++++++++++++++------ xen/include/xen/event.h | 5 +++++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index f546e81758..f5e0b12d15 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -381,11 +381,16 @@ static void double_evtchn_unlock(struct evtchn *lchn, struct evtchn *rchn) evtchn_write_unlock(rchn); } -static int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) +/* + * If lport is zero get the next free port and allocate. If port is non-zero + * allocate the specified lport. + */ +int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, struct domain *ld, + evtchn_port_t lport) { struct evtchn *lchn, *rchn; - struct domain *ld = current->domain, *rd; - int lport, rc; + struct domain *rd; + int rc; evtchn_port_t rport = bind->remote_port; domid_t rdom = bind->remote_dom; @@ -405,8 +410,11 @@ static int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) write_lock(&ld->event_lock); } - if ( (lport = get_free_port(ld)) < 0 ) - ERROR_EXIT(lport); + lport = rc = evtchn_get_port(ld, lport); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; + lchn = evtchn_from_port(ld, lport); rchn = _evtchn_from_port(rd, rport); @@ -1239,7 +1247,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) struct evtchn_bind_interdomain bind_interdomain; if ( copy_from_guest(&bind_interdomain, arg, 1) != 0 ) return -EFAULT; - rc = evtchn_bind_interdomain(&bind_interdomain); + rc = evtchn_bind_interdomain(&bind_interdomain, current->domain, 0); if ( !rc && __copy_to_guest(arg, &bind_interdomain, 1) ) rc = -EFAULT; /* Cleaning up here would be a mess! */ break; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index f31963703f..8eae9984a9 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -75,6 +75,11 @@ int evtchn_allocate_port(struct domain *d, unsigned int port); int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, evtchn_port_t port); +/* Bind an event channel port to interdomain */ +int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, + struct domain *ld, + evtchn_port_t port); + /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 07 17:21:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 17:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402104.644102 (Exim 4.92) (envelope-from ) id 1oVyjl-0000eY-LI; Wed, 07 Sep 2022 17:21:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402104.644102; Wed, 07 Sep 2022 17:21:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVyjl-0000eR-I8; Wed, 07 Sep 2022 17:21:17 +0000 Received: by outflank-mailman (input) for mailman id 402104; Wed, 07 Sep 2022 17:21:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVyjk-0000eL-8A for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 17:21:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7902de10-2ed1-11ed-a016-b9edf5238543; Wed, 07 Sep 2022 19:21:14 +0200 (CEST) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Sep 2022 13:21:03 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5532.namprd03.prod.outlook.com (2603:10b6:806:bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 17:21:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 17:21:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7902de10-2ed1-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662571274; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wiBhW//cs0Lo4jLUltZZGK1vAZd29B37ZjPcJR9qch4=; b=GPj/BsFggkrT3q5L3N63JcJXRyB7v1a42cRvDxPzi6BU28/rJVwzc8sG G5LYBDoZ6sSUVGyN4qGGbGSWYzyk+mG8Tcp7sIR4EI3Amw3aC16NKYxVh 2zYRJU1ATDWHXvafMyctFsGUg76pRbd41uBtQsAnpL/wpKKud19H+67PW Y=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 82514786 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bEg9o6yn1ZfypM8VX4p6t+cNxyrEfRIJ4+MujC+fZmUNrF6WrkUHn GcfDT3UaamJYDCgedFybovlpx5VvZWBnINhHQNkqCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Usw5KiaVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1XDh4OJZAW+NpZPlxl5 +JINAICMyu60rfeLLKTEoGAh+wFBeyyZsY1nCElyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCSiNWQG+Dp5poJui4TX5CV33KLgL5z+fduSSN8Otk2Zu njH7yLyBRRy2Nm3mWDYqy7z1rGncSXTU6QgTeKI2vVTrGaflkwSUzo2dnXqiKzs4qK5c5cFQ 6AOwQIssKwz+UqDXtT7GRqirxastBMGR8BZFeF87QiX07fV+C6QHG1CRTlEAPQ9r9M/TzEu0 l6PnvvqCCZpvbnTTmiSnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPpi5ugbwW1JQPz//iowCBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHflrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:uKRF7aoYqgJf+BlJKlnls4waV5uIL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pWVFZ9l/1pwKpuKuZ3IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnieffFmHKc7hywlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDSq5rPw== X-IronPort-AV: E=Sophos;i="5.93,297,1654574400"; d="scan'208";a="82514786" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQQW3xm4LyBVNC9RvO62oDEVbut5ZaRMFWHS85wJIaQac+xhQq3OEXmpvuH+xlj7syxB6nTXBr9IejX/AXwjNwjrrpWtvG2By6Lje19MlVPPaZPqVGYk+Lm9Yn6AHchCIa9gorf2Xim01JRzHkBuqva2ojwtWa25r/lI5XgAlDA44WvOJR1wkzBjgYbX6DICWyR41scQ/G3yGPcJG++D4x2RMUdPs9gmTxNy4QJzY04YJCGrJWBmT2RPeT4Au0jFXU7rj+OzxrznAzP4Ayh/KclE9S8+Qdo4yLut0Fn4HWWbJLio8sBEXO32V4XsN7q4U0or4bTBFbx9E8UGxA7QrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wiBhW//cs0Lo4jLUltZZGK1vAZd29B37ZjPcJR9qch4=; b=iLyxZzozujAiyNV1U+ETbpcS7urDC/4Tgdy9OlEBV8yN4u0INuML2U93Wi8VigldEXQkF5bV5hS+OfD8Aw5047LnVrh46njSlYSaXM7zod434vnGfrv7iTON8qsSVx1oVen89RTO8jDcN1J4bmeAGgfEFOWzbguby1faiV5q2LGjnz3kLdxsfh+CABB1eZ5g7QefX00gj588ejJfp6w+QGd8VQFxeztJ1ifRatmH2K/v7lJgCuwbRVx6hTzIUlvLO6MawjPnQzCRw8MG2RTfHhuFRza+k8bU9MvXHVCVaGhgrgQ77uyFw9heaDnmnjFxLOT75H5sExI7wqektpJh3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wiBhW//cs0Lo4jLUltZZGK1vAZd29B37ZjPcJR9qch4=; b=kMuYNpVPWLeMpLMa+c44pklaA/URODBu4O+m/r5OP4C61hfhTgwTVdzcdrofJEIRexZhD6jatSRzZRUmkiVBzb9J/qA3yAHNYgUg73zNZEzx8lZ7D6j8ZE0jwTNE5Mf6xqE+bZuVSoqC5/orL1YI9IsA4OPcr/92n7zzB9+zSEc= From: Andrew Cooper To: Julien Grall , Bertrand Marquis , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" Subject: Re: Unaligned access on arm32 Thread-Topic: Unaligned access on arm32 Thread-Index: AQHYws7YWEe9/blR2Uu4FtKoO/uDz63UNsgA Date: Wed, 7 Sep 2022 17:21:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cfeb0187-8b6a-43bb-4a4c-08da90f555f2 x-ms-traffictypediagnostic: SA0PR03MB5532:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6ZZsCA4qwtX59zCwshI9qtzhh9xEpBfkf3jqAN5NZyIszBV+VId8pa/AGmBZ/rVyaWelMdt01Mij8Qecw8Qe//N3CEtB/tJ6e/p/XdZ7ulYUu5Oj4Ag9d7GbBS7jLWC3boGrWlq++b1sIhtjgKsncViN3yPW1roCJrvd+Kj4AHFXnCDd4RsYRqQrUWNwuKaiJr+T1ttZUFAxsl36wKUVJ1NBOEJ3S+gtJfZOm92uRXy8H9IpbkBPno1k2hC6IlDuxs8Mvee1PUEVB7nzuEMAxkh2SMaq0yE7x+OKAljfP3XV2w9HL8yRYIDZO9MomY95QjhVLTIUpq6cjuiXgz1BPtm5ISsSLhKlj2oxSZ5Fk8mhQd29G1OU0/C8MLWqp6mwth5WRrNlClTwNYbirN1txn7LXECeT36YMUCKrnqeuzt8TCw5PRlaELHqNJgDj6YyFjN47ukDmhjoq3hD41p3ZFWTjbrRiiUkZZFsIyH+5lGIHftZ08Mw1QKPDgoHER1MDsQdP+NWSetc7SHd4RCQusDaZv/59XJSo4xm+vMK8l1D7TH4p6Yj1oFh00a7ouUpB6cuVdiC6pZBGXvxftP1UMVPTvTVTcKHMgxBmLuCOSa8Q0F2kMqQyi8/GJPALA7fyT4JsLirM5F/4NviMoNvCUI0GVjS3Jiv9pBcAV5OdFTGf2vOn0Z1oJX4TAsRD/ipF+gQSg8LXqvaoaixqpsX4jY61dKQzu6ueVwuSiyUJ7CRFqDlF/mzdoPXy/oY4WAjUw8py8N5mCYkfQaq6el8OWGD6Kb+iWH3b0MoUZfe2vPTwAwqfAqlGMoQc+qURtbQkjnP2XbNmxEyL/TxAfU0jw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(316002)(5660300002)(66556008)(83380400001)(110136005)(4326008)(91956017)(66476007)(76116006)(8676002)(66946007)(36756003)(64756008)(8936002)(31686004)(66446008)(2906002)(31696002)(6486002)(6512007)(71200400001)(26005)(41300700001)(478600001)(38070700005)(86362001)(2616005)(186003)(53546011)(122000001)(82960400001)(6506007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cTlCbThXN1BaYmovelBlemhQQUVUTWZ1YUsrTGxHd2VTOVFVdUFiVVRCdjFT?= =?utf-8?B?d1dDaXpkay9LM0Z4c1Jsc3k1aGhNOU5xdnZ2Q0haV0FvaERpeE1iRFhBaTll?= =?utf-8?B?Z3cxVFh3aVJiVXk1eTF6YlBDWWI4Z2EvNUhDZmZpb1NIQUcvRWxHN3VSOUtp?= =?utf-8?B?Vi96eEJOcHFWbFZoRlRITkhVenZic3pLM29tVGlodVd2MXJBRjVJakJ1WG9Z?= =?utf-8?B?bUt1SmxWdTkzaHZBQllhMnFaWVFvdTQzeVBoTERrOG9MSWpITEdnOU9wemQ4?= =?utf-8?B?UFZVQUdmaEFNeTBjSkpFRStkbWI5eERaOHVJanJsN2FHbytkUkZtd0ZtRHcv?= =?utf-8?B?OEthdEx4YnFIdFFrc0VQdzZYSVQ0YjdNR0ViV3ZiMGI5ZlVuY2VFckt5S0Np?= =?utf-8?B?dHN5RmU1eW82cytGaVl0d09NTjNZQWRwVzI2a0gzYUJKUWQwUGlId215bzk0?= =?utf-8?B?eFQ4YUxndjVHUG5VUEhlSDNZUEpBTmRwVjUzKzVEdHZIdGJzWFRTY3NsMDBK?= =?utf-8?B?NzlGenEyeVBPMzdvM2szNXZFQVlJMWhuekF4U3FuZ2Zjd0hVazVUWTV6ekVD?= =?utf-8?B?U2ZWV0RTczN4bERFZGg0c1VnanEyUkFmUGR3Rjg1N0I4Z0dxOUphVDFzcXcz?= =?utf-8?B?dUtyTXVGcEdrRGpIemdFR05wWGFQNHRVcmdKM09WY09zNzJvU0dvbGlCMHZU?= =?utf-8?B?NHBYMW81WXh1c2lQUWd1RldJbDNhcDBSbXR2YTVGVVNVcnZ5QW8xVm52dDFT?= =?utf-8?B?OVZyYWIwWmJSREtUR0tENlR2cGJDemZRbXF2T0NMbTk1UGk3N09zRXppdXpQ?= =?utf-8?B?OFdEeGtQTVpCSDl3cldOdFdEWkVrdE85SUVDYkNHVWw2YkZtcTdhM0JRekY0?= =?utf-8?B?UjFCdWtJa2Nsa3Z1ZFF6QnloZHFZbWk3KzBpUnY1d29TaUNsZHN2L3JlWjVH?= =?utf-8?B?Zk5XT3I2MVdrdVNJbTRZYmQ2a1BSU0VVazQzU1R5TWVaeGt5U0t6VE1jZFRZ?= =?utf-8?B?YmxzRThvSzZUYWR5UVJqQzJ4cnZPOWpUWVJDUzQwMWwvUmJoTG8yajhNK0Jk?= =?utf-8?B?eFQ1SlM3aDRvR3JFZWNWVlRySmI2ZFhPbHJxWUJwaSs2OFNmOUhuVy8zMGdQ?= =?utf-8?B?MlpPd2xwNVdUa0hUamF3cFNPRVVtNSt4clQxTWhERitBUFprcUdOL1VXZnpN?= =?utf-8?B?M3p4UkxHMjRoeGx3eVl5NlVId0RPU3cwQmMwV05Fa0MvR3NvS2QzVDlzaXdO?= =?utf-8?B?SHA5cUV5d0s3V25VdnlUT2dERXd0bWJNSUhBbUpPSW5hdU5iZjltSndyWmZ2?= =?utf-8?B?bzhXV0N0bVkrSURiZUwzbndBbFpuTWhYT3J0bHNBYjgzQmpzWVVXZVYxZjdI?= =?utf-8?B?S3hZMENwb0pzSWQ3OFY1WWg5ZnFUVTZSZ21Ld3IybVdwUUc5dXVKN05RLy9p?= =?utf-8?B?UkN6NG8rcURua2lCUExIbEk5NmdHQVdnd0VGczRLSTNrZFIyNHlOVGxKbEp5?= =?utf-8?B?MU1BVUpubldBRmdxZGxOQjRCbnJsMmloVmdmY3hydUFDR3ZpcHlMaTUxZFRl?= =?utf-8?B?SERFMGpuLzBRZldNcDd3ZFRJeWtrMFJ1bm9ZTkpBRUk0ZHlDa3RkVDMzb1E1?= =?utf-8?B?Z240czN2cUFQZGp4RC9XOC9LQ1VFY3dEQjV6S2FGSTBCQmIzWkNpV3V3OVpH?= =?utf-8?B?NHRYTGxwd2oveTU0MFduNFJlUTRoVkxLamY5VWtEOHZJVFM0Z2E0azBmbmJ0?= =?utf-8?B?SFF1c2hOTzN6dkhrY1RJRVA1T1NKYVBtdUNhRkZjQmJVdDYvMU10K1Y1bGhx?= =?utf-8?B?VXZSdGRpU3VFYmJNdndqcG53L2FpRmo5aXBhMjNxV3BkTi9oU0ViRFMrUCta?= =?utf-8?B?RVFENnAxM2tIbFlLY3ViWnJneENPRWpHbXhwM0F1dzdpVzRlRUNBQS9NK1R4?= =?utf-8?B?NFErK3p0RGswTFhUZFVTSkd2QmxvbnpTaGhxNXl1YmRQeVNSbVdGWEl0K3li?= =?utf-8?B?U3lMdjcxVkFqa2JyOFlMRCtKRmdXVUlKK3h5WlRFdzhmVmFWSENWbG05WDFk?= =?utf-8?B?SkZON1BoTXV1STY1YUxQOUdiS1owRXFwSVJ5cEhJKzhEalZmYVBhelBMZlVo?= =?utf-8?Q?Az6R1/achlvkmG7ZJlAeoF7h3?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfeb0187-8b6a-43bb-4a4c-08da90f555f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 17:21:00.9363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 63F3Ri8rpVz8KSD4w9DZavnDstS1XzAwFygFIhI00yWLdvwIT+284WxjoJx0DNpwzpC9dFA7oSXr9s3CPtSgxO7Bo4qg/Tg8ynuSX10BWdw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5532 T24gMDcvMDkvMjAyMiAxNjozMCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBhbGwsDQo+DQo+ IEkgdGhpbmsgbWVudGlvbmVkIGl0IHByaXZhdGVseSBhIHdoaWxlIGEgZ28sIGJ1dCBuZXZlciBz ZW50IGFuIGUtbWFpbA0KPiBhYm91dCBpdC4NCj4NCj4gV2hpbGUgdGVzdGluZyBhcm0zMiB3aXRo IElPUkVRLCBJIG5vdGljZWQgWGVuIGlzIGNyYXNoaW5nIGJlY2F1c2UgYW4NCj4gYWxpZ25tZW50 IGZhdWx0Og0KPg0KPiAoWEVOKSBEYXRhIEFib3J0IFRyYXAuIFN5bmRyb21lPTB4MTgwMDA2MQ0K PiAoWEVOKSBXYWxraW5nIEh5cGVydmlzb3IgVkEgMHg0MDAyN2ViYiBvbiBDUFUwIHZpYSBUVEJS DQo+IDB4MDAwMDAwMDA0MDEyZjAwMA0KPiAoWEVOKSAxU1RbMHgwMDFdID0gMHgwMDQwMDAwMGJi ZmZmZjdmDQo+IChYRU4pIDJORFsweDAwMF0gPSAweDAwNTAwMDAwYmMwMDBmN2QNCj4gKFhFTikg Q1BVMDogVW5leHBlY3RlZCBUcmFwOiBEYXRhIEFib3J0DQo+IChYRU4pIC0tLS1bIFhlbi00LjE3 LXVuc3RhYmxlwqAgYXJtMzLCoCBkZWJ1Zz1uwqAgVGFpbnRlZDrCoMKgIEPCoMKgwqAgXS0tLS0N Cj4gKFhFTikgQ1BVOsKgwqDCoCAwDQo+IChYRU4pIFBDOsKgwqDCoMKgIDAwMjYxM2I4IHRyeV9m d2RfaW9zZXJ2KzB4NDQvMHgxYmMNCj4gKFhFTikgQ1BTUjrCoMKgIDYwMDAwMDVhIE1PREU6SHlw ZXJ2aXNvcg0KPiAoWEVOKcKgwqDCoMKgwqAgUjA6IDAwMDAwMDAwIFIxOiAwMDAwMDAwMSBSMjog MDAyMmE3NDggUjM6IDAwMDAwMDA2DQo+IChYRU4pwqDCoMKgwqDCoCBSNDogNDAwMjdmMjAgUjU6 IDQwMDI3ZjU4IFI2OiA0MDAyODAwMCBSNzogMDAwMDAwMDANCj4gKFhFTinCoMKgwqDCoMKgIFI4 OiA0MDAyN2YyMCBSOTogNDAwM2E0MzggUjEwOjAwMmYwMDQ0IFIxMTo0MDAyN2VkYw0KPiBSMTI6 MDAwMDAwMDINCj4gKFhFTikgSFlQOiBTUDogNDAwMjdlOTQgTFI6IDAwMjYwZWRjDQo+IChYRU4p DQo+IChYRU4pwqDCoCBWVENSX0VMMjogODAwMDM1NTgNCj4gKFhFTinCoCBWVFRCUl9FTDI6IDAw MDEwMDAwYmJmZjgwMDANCj4gKFhFTikNCj4gKFhFTinCoCBTQ1RMUl9FTDI6IDMwY2QxODdmDQo+ IChYRU4pwqDCoMKgIEhDUl9FTDI6IDAwN2M2NjNmDQo+IChYRU4pwqAgVFRCUjBfRUwyOiAwMDAw MDAwMDQwMTJmMDAwDQo+IChYRU4pDQo+IChYRU4pwqDCoMKgIEVTUl9FTDI6IDk3ODAwMDYxDQo+ IChYRU4pwqAgSFBGQVJfRUwyOiAwMDY3ZmFmMA0KPiAoWEVOKcKgwqDCoMKgwqAgSERGQVI6IDQw MDI3ZWJiDQo+IChYRU4pwqDCoMKgwqDCoCBISUZBUjogNjc2MDAwMDANCj4gKFhFTikNCj4gKFhF TikgWGVuIHN0YWNrIHRyYWNlIGZyb20gc3A9NDAwMjdlOTQ6DQo+IChYRU4pwqDCoMKgIDk3ODAw MDYxIDAwMjJhNzQ4IDAwMDAwMDAxIDAwMDAwMDAwIDgwMDAwMDVhIDAwODAwMDAwDQo+IDQwMDNh MDAwIDAwMDAwMDAxDQo+IChYRU4pwqDCoMKgIDQwMDNhMTgwIDAwMDAwMDAwIGJiZmY0N2ZmIDAw MDAwMDAwIDY3ZmFmMjAwIDAwMDAwMDAwDQo+IDQwMDNhMDAwIDQwMDI3ZjIwDQo+IChYRU4pwqDC oMKgIDQwMDNhNDM4IDQwMDI3ZjFjIDAwMjYwZWRjIDAwMmYwMTEwIDQwMDI3ZjU4IDQwMDI4MDAw DQo+IDQwMDNhMDAwIDAwMDAwMTNiDQo+IChYRU4pwqDCoMKgIDQwMDI4MDAwIDAwMmYwMjgwIDAw MDAwMDkwIDQwMDI3ZjU4IDY3ZmFmMjAwIDkzODIwMDA2DQo+IDY3ZmFmMjAwIDAwMDAwMDAwDQo+ IChYRU4pwqDCoMKgIDAwMDAwMDAwIDQwMDI3ZjU0IDAwMjZiNmFjIDkzODIwMDA2IDAwMjJhNzQ4 IDAwMDAwMDAxDQo+IDAwMDAwMDA0IDY3ZmFmMjAwDQo+IChYRU4pwqDCoMKgIDAwMDAwMDAwIDAw MDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIGZmZmZmZmZmIDY4MDAwMDAwDQo+IDQwMDAwMWQzIDQw MDI3ZjU4DQo+IChYRU4pwqDCoMKgIDAwMjAxODcwIDYwMDAwMDAwIDY3NjAxMzI0IDY3ZmFmMjAw IDAwMDAwMDAwIDAwMDAwMDEzDQo+IDAwMDAwMDAwIDAwMDAwMDAwDQo+IChYRU4pwqDCoMKgIGZm ZmZmZmZmIDY4MDAwMDAwIDQwMDAwMWQzIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwDQo+IGZm ZmZmZmZmIDAwMDAwMDAwDQo+IChYRU4pwqDCoMKgIDY3NjAxMDc0IDAwMDAwMWQzIDkzODIwMDA2 IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwDQo+IDAwMDAwMDAwIDY3NjAxMDA4DQo+IChYRU4p wqDCoMKgIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAw MDAwDQo+IDAwMDAwMDAwIDAwMDAwMDAwDQo+IChYRU4pwqDCoMKgIDAwMDAwMDAwIDAwMDAwMDAw IDAwMDAwMDAwIDQwMDAwMWQzIDAwMDAwMDAwIDAwMDAwMDAwDQo+IDAwMDAwMDAwIDAwMDAwMDAw DQo+IChYRU4pwqDCoMKgIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAxDQo+IChYRU4pIFhlbiBj YWxsIHRyYWNlOg0KPiAoWEVOKcKgwqDCoCBbPDAwMjYxM2I4Pl0gdHJ5X2Z3ZF9pb3NlcnYrMHg0 NC8weDFiYyAoUEMpDQo+IChYRU4pwqDCoMKgIFs8MDAyNjBlZGM+XSB0cnlfaGFuZGxlX21taW8r MHgyYjAvMHgyZjQgKExSKQ0KPiAoWEVOKcKgwqDCoCBbPDAwMjYwZWRjPl0gdHJ5X2hhbmRsZV9t bWlvKzB4MmIwLzB4MmY0DQo+IChYRU4pwqDCoMKgIFs8MDAyNmI2YWM+XQ0KPiBhcmNoL2FybS90 cmFwcy5jI2RvX3RyYXBfc3RhZ2UyX2Fib3J0X2d1ZXN0KzB4MThjLzB4MzRjDQo+IChYRU4pwqDC oMKgIFs8MDAyMDE4NzA+XSBlbnRyeS5vI3JldHVybl9mcm9tX3RyYXArMC8weDQNCj4gKFhFTikN Cj4gKFhFTikNCj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq Kg0KPiAoWEVOKSBQYW5pYyBvbiBDUFUgMDoNCj4gKFhFTikgQ1BVMDogVW5leHBlY3RlZCBUcmFw OiBEYXRhIEFib3J0DQo+IChYRU4pICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioNCj4NCj4gVGhlIGRpc2Fzc2VtYmxlZCBjb2RlIGlzOg0KPg0KPiAwMDI2MTM3NCA8dHJ5 X2Z3ZF9pb3NlcnY+Og0KPiDCoCAyNjEzNzQ6wqDCoMKgwqDCoMKgIGUxNmQ0MmYwwqDCoMKgwqDC oMKgwqAgc3RyZMKgwqDCoCByNCwgW3NwLCAjLTMyXSEgOyAweGZmZmZmZmUwDQo+IMKgIDI2MTM3 ODrCoMKgwqDCoMKgwqAgZTFhMDQwMDLCoMKgwqDCoMKgwqDCoCBtb3bCoMKgwqDCoCByNCwgcjIN Cj4gwqAgMjYxMzdjOsKgwqDCoMKgwqDCoCBlMWEwNTAwMMKgwqDCoMKgwqDCoMKgIG1vdsKgwqDC oMKgIHI1LCByMA0KPiDCoCAyNjEzODA6wqDCoMKgwqDCoMKgIGUxY2Q2MGY4wqDCoMKgwqDCoMKg wqAgc3RyZMKgwqDCoCByNiwgW3NwLCAjOF0NCj4gwqAgMjYxMzg0OsKgwqDCoMKgwqDCoCBlM2Ew MDAwMMKgwqDCoMKgwqDCoMKgIG1vdsKgwqDCoMKgIHIwLCAjMA0KPiDCoCAyNjEzODg6wqDCoMKg wqDCoMKgIGUxYTA2MDAxwqDCoMKgwqDCoMKgwqAgbW92wqDCoMKgwqAgcjYsIHIxDQo+IMKgIDI2 MTM4YzrCoMKgwqDCoMKgwqAgZTFjZDgxZjDCoMKgwqDCoMKgwqDCoCBzdHJkwqDCoMKgIHI4LCBb c3AsICMxNl0NCj4gwqAgMjYxMzkwOsKgwqDCoMKgwqDCoCBlM2EwMTAwMcKgwqDCoMKgwqDCoMKg IG1vdsKgwqDCoMKgIHIxLCAjMQ0KPiDCoCAyNjEzOTQ6wqDCoMKgwqDCoMKgIGU1OGRiMDE4wqDC oMKgwqDCoMKgwqAgc3RywqDCoMKgwqAgZnAsIFtzcCwgIzI0XQ0KPiDCoCAyNjEzOTg6wqDCoMKg wqDCoMKgIGUyOGRiMDFjwqDCoMKgwqDCoMKgwqAgYWRkwqDCoMKgwqAgZnAsIHNwLCAjMjgNCj4g wqAgMjYxMzljOsKgwqDCoMKgwqDCoCBlNThkZTAxY8KgwqDCoMKgwqDCoMKgIHN0csKgwqDCoMKg IGxyLCBbc3AsICMyOF0NCj4gwqAgMjYxM2EwOsKgwqDCoMKgwqDCoCBlMjRkZDAyOMKgwqDCoMKg wqDCoMKgIHN1YsKgwqDCoMKgIHNwLCBzcCwgIzQwwqDCoMKgwqAgOyAweDI4DQo+IMKgIDI2MTNh NDrCoMKgwqDCoMKgwqAgZTFjMjIwZDTCoMKgwqDCoMKgwqDCoCBsZHJkwqDCoMKgIHIyLCBbcjIs ICM0XQ0KPiDCoCAyNjEzYTg6wqDCoMKgwqDCoMKgIGU1MGIwMDI0wqDCoMKgwqDCoMKgwqAgc3Ry wqDCoMKgwqAgcjAsIFtmcCwgIy0zNl3CoCA7IDB4ZmZmZmZmZGMNCj4gwqAgMjYxM2FjOsKgwqDC oMKgwqDCoCBlNWQ2N2EyNsKgwqDCoMKgwqDCoMKgIGxkcmLCoMKgwqAgcjcsIFtyNiwgIzI1OThd IDsgMHhhMjYNCj4gwqAgMjYxM2IwOsKgwqDCoMKgwqDCoCBlMTRiMjRmNMKgwqDCoMKgwqDCoMKg IHN0cmTCoMKgwqAgcjIsIFtmcCwgIy02OF3CoCA7IDB4ZmZmZmZmYmMNCj4gwqAgMjYxM2I0OsKg wqDCoMKgwqDCoCBlNWQ0MzAwMMKgwqDCoMKgwqDCoMKgIGxkcmLCoMKgwqAgcjMsIFtyNF0NCj4g KiAyNjEzYjg6wqDCoMKgwqDCoMKgIGU1MGIwMDIxwqDCoMKgwqDCoMKgwqAgc3RywqDCoMKgwqAg cjAsIFtmcCwgIy0zM13CoCA7IDB4ZmZmZmZmZGYNCj4NCj4gVGhlIHByb2JsZW0gaXMgR0NDIFsx XSBkZWNpZGVkIHRvIHVzZSAnc3RyJyBmb3IgYWNjZXNzaW5nIGFuIGFkZHJlc3MNCj4gdGhhdCBp cyBub3QgMzItYml0IGFsaWduZWQgKGZwIC0gMzMgPSAweDQwMDI3ZTczKS4gT24gYXJtMzIsIHdl IGFyZQ0KPiBmb3JiaWRkaW5nIGFsaWduZWQgYWNjZXNzLCBoZW5jZSB3aHkgaXQgY3Jhc2hlZC4N Cj4NCj4gTG9va2luZyBvbmxpbmUsIGl0IGxvb2tzIGxpa2UgR0NDIGhhcyBhbiBvcHRpb24gdG8g dHVybmVkIG9uL29mZiB0aGUNCj4gdXNlIG9mIHVuYWxpZ25lZCBhY2Nlc3MgWzJdIGFuZCBpdCBp cyBlbmFibGVkIGJ5IGRlZmF1bHQgb24gQVJNdjcgKEkNCj4gYW0gbm90IHN1cmUgd2h5IHdlIGRp ZG4ndCBub3RpY2UgdGhpcyBiZWZvcmUuLi4pLg0KPg0KPiBJIGhhdmUgcmVidWlsdCBYZW4gd2l0 aCB0aGUgb3B0aW9uIHR1cm4gb2ZmIGFuZCBkb20wIGlzIG5vdyBib290aW5nIGZpbmUuDQoNCkFu eSBpZGVhIHdoaWNoIGxpbmUgb2YgY29kZSB0aGF0IGNvcnJlc3BvbmRzIHRvPw0KDQpJdCdzIHN0 b3JpbmcgemVybyBpbnRvIHRoZSBzdGFjayBxdWl0ZSBlYXJseSBvbiwgc28gSSBzdXNwZWN0IGl0 J3MgdGhlDQppbml0aWFsaXNhdGlvbiBvZiBwIG9uIHRoZSBzdGFjay4NCg0KVGhlcmUgYXJlIHBs ZW50eSBvZiBpbXBsaWNpdCB6ZXJvcyBuZWVkaW5nIHNldHRpbmcsIHNvIGhhcyB0aGUgY29tcGls ZXINCnRyaWVkIHRvIG1lcmdlIGFkamFjZW50IHN0b3JlcyBhbmQgZW5kZWQgdXAgd2l0aCBzb21l dGhpbmcgdGhhdCdzIHVuYWxpZ25lZD8NCg0KPiBIb3dldmVyLCBJIGFtIGEgYml0IHB1enpsZWQg YmVjYXVzZSB0aGUgQyBjb2RlIGRpZG4ndCBjb250YWluDQo+IHVuYWxpZ25lZCBhY2Nlc3MuIEl0 IHdhcyBhbGwgaW50cm9kdWNlZCBieSB0aGUgY29tcGlsZXIgaXRzZWxmLiBUaGlzDQo+IGlzIGJy ZWFraW5nIG91ciBhc3N1bXB0aW9uIHRoYXQgdGhlIGNvbXBpbGVyIHdpbGwgbm90IGJyZWFrIGRv d24NCj4gY29ycmVjdGx5IG5hdHVyYWxseSBhbGlnbmVkIGFjY2Vzcy4NCg0KVGhpcyBhc3N1bXB0 aW9uIGhhcyBuZXZlciBiZWVuIHRydWUsIGFuZCBpcyBkaXNjdXNzZWQgaW4gZGVwdGggaW4gdGhl DQpMaW51eCBtZW1vcnkgYmFycmllcnMgZG9jLsKgIEEgbG90IG9mIGVmZm9ydCBpcyBnb2luZyBp bnRvIHRyeWluZyB0bw0KZmlndXJlIG91dCB3aGVuIGl0IGlzIHNhZmUgdG8gbWVyZ2UgYWRqYWNl bnQgYWNjZXNzZXMuwqAgKEJ1dCBpbiB0aGlzDQpjYXNlLCBJIHdvdWxkIHNheSBpdCdzIGEgY29t cGlsZXIgYnVnLCBpZiB0aGUgZ3Vlc3MgYWJvdmUgaXMgY29ycmVjdC4pDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 07 17:42:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 17:42:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402112.644113 (Exim 4.92) (envelope-from ) id 1oVz4E-0003L3-AH; Wed, 07 Sep 2022 17:42:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402112.644113; Wed, 07 Sep 2022 17:42:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVz4E-0003Kw-6z; Wed, 07 Sep 2022 17:42:26 +0000 Received: by outflank-mailman (input) for mailman id 402112; Wed, 07 Sep 2022 17:42:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVz4C-0003Km-E3; Wed, 07 Sep 2022 17:42:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVz4C-000396-Ba; Wed, 07 Sep 2022 17:42:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVz4B-0008De-Rt; Wed, 07 Sep 2022 17:42:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVz4B-0004Hu-RL; Wed, 07 Sep 2022 17:42:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KZmxcblI5jnTX7wXATq1ZTPLhOiXTst8W6YbicBwqhA=; b=nH0Q+RiCUyOe5d62ON4Ugw9Pa1 ek2JmYlGHr90IKhXOLWiaS5oOyxwUyoiw4qPq/kzCjcV1d58D8A2FrhiKDBWtBnb6lXCMu9U8YEDM oLIYouPR4dmZz8wqEHGNEPYDwjFWE4tjnyarRI0mDpwGaQzAd3Cu741zDq/BfU7ZCNO4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173047: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=512042eba87ff97a4820a55cf3b1a89a8afd1cc7 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 17:42:23 +0000 flight 173047 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173047/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 512042eba87ff97a4820a55cf3b1a89a8afd1cc7 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 34 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 261 attempts Testing same since 173043 2022-09-07 09:48:36 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2139 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 17:49:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 17:49:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402123.644123 (Exim 4.92) (envelope-from ) id 1oVzAm-0004FS-3X; Wed, 07 Sep 2022 17:49:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402123.644123; Wed, 07 Sep 2022 17:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzAm-0004FL-0w; Wed, 07 Sep 2022 17:49:12 +0000 Received: by outflank-mailman (input) for mailman id 402123; Wed, 07 Sep 2022 17:49:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzAl-0004FF-IG for xen-devel@lists.xen.org; Wed, 07 Sep 2022 17:49:11 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5fd8d22e-2ed5-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 19:49:10 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzAh-0003Fg-LE; Wed, 07 Sep 2022 17:49:07 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVzAh-0004LN-D5; Wed, 07 Sep 2022 17:49:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fd8d22e-2ed5-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wtSm/UAPQbJv1pnpeWpxJbmKYxz2eNu5lK1OFxZBJ88=; b=Jkd5q01fFbUzLz6RoRVayg9B8m Tyy55FwWveLl3/OaB/dV1CdFzaTBnrK1m60rmi6vXKnE/OuF8ZusZDjIEZAEOdIfRN+Grwkg/j56G P1lt/IhpXPzNjIMUQMpLbxVJIRPEAYxZ2uCKOYRiYRR8f0ydof6+LLgiX0A1u2mSUysQ=; Message-ID: <402d1abf-85f6-b13a-8a6e-80cb1792c2ee@xen.org> Date: Wed, 7 Sep 2022 18:49:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device Content-Language: en-US To: Viresh Kumar , Anthony PERARD Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> <20220907123224.rz7vvope37l6l6mg@vireshk-i7> From: Julien Grall In-Reply-To: <20220907123224.rz7vvope37l6l6mg@vireshk-i7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Viresh, Jumping in the conversation. On 07/09/2022 13:32, Viresh Kumar wrote: > I don't have much knowledge of the Xen code and wanted this code for I2C and > GPIO to be tested on Xen for the work we are doing around hypervisor agnostic > backends [1]. > > I started looking for a simple device's implementation and began by (blindly) > copying code from Keyboard device and so much of wasted code in here, which > isn't really required. > > On 06-09-22, 17:15, Anthony PERARD wrote: >> On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote: >>> An example of domain configuration for Virtio I2c: >>> i2c = [ "" ] >> >> Is this doing something meaningful (with the whole series applied)? > > If I am not wrong, this is required by parse_i2c_list()'s implementation. > Without this I don't get the I2C device populated in the guest. > > Is there another way to achieve it ? Looking at this series, you will add ~250 lines (assuming your new patch) for the i2c and then likely the same amount for GPIO. I am assuming that for every new virtio device (e.g. gps, sound, display...), we would also need to 250 lines of code. I am worry that we will end up to bloat libxl with duplicated code and or for device that are barely used. I think it would be better to find a generic way to add new virtio device without adding code (very limited) in libxl. The advantage is someone will be able to create a new virtio device with less effort. The approach I can think of is something along the lines: virtio = ["type=,transport=,..."] where the compatible is the one that should be written in the DT and transport is mmio or pci. the [...] refers to specific parameters that would need to be passed to the backend (it is not clear how you provide them today?). AFAICT, the GPIO one may need some tweaking because it requires specific properties. I think it would be more acceptable as this will be only a few lines (compare to 250 lines today). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 18:02:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 18:02:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402130.644134 (Exim 4.92) (envelope-from ) id 1oVzNf-0006lE-8G; Wed, 07 Sep 2022 18:02:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402130.644134; Wed, 07 Sep 2022 18:02:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzNf-0006l7-5h; Wed, 07 Sep 2022 18:02:31 +0000 Received: by outflank-mailman (input) for mailman id 402130; Wed, 07 Sep 2022 18:02:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzNd-0006l1-LZ for xen-devel@lists.xen.org; Wed, 07 Sep 2022 18:02:29 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c11ba3a-2ed7-11ed-af93-0125da4c0113; Wed, 07 Sep 2022 20:02:28 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzNa-0003au-H7; Wed, 07 Sep 2022 18:02:26 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVzNa-00056U-9q; Wed, 07 Sep 2022 18:02:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c11ba3a-2ed7-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0zIZK5RsJMZZGiNX1CvKYFkNjVf7mYTEFPgVazl8pWI=; b=m9cKiAIEUSa49C223w52rm9waS jWWaX1VeBEdwZssm9ZnpXp+Re5Uu1JhqzlaXVE8IrDqEvOCfMq+EvRnG+CJWVbFjacSoAqLiMrLm9 1oVNhX1kvr9lBjvJSgLBgl3VRSQ4AwgSFcjElguE7ypRFOH5YVMQbPQBA3JXOG0HEROc=; Message-ID: <855f6a63-5315-d9ff-780c-9512b5a89bd6@xen.org> Date: Wed, 7 Sep 2022 19:02:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH V5 6/6] libxl: Allocate MMIO params for GPIO device and update DT Content-Language: en-US To: Viresh Kumar , xen-devel@lists.xen.org Cc: Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , anthony.perard@citrix.com, Oleksandr Tyshchenko , Bertrand Marquis References: <4a238937ceb803f494e5633a3a779866383bd463.1661159474.git.viresh.kumar@linaro.org> From: Julien Grall In-Reply-To: <4a238937ceb803f494e5633a3a779866383bd463.1661159474.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (+ Bertrand) Hi Viresh, On 22/08/2022 10:15, Viresh Kumar wrote: > This patch allocates Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree based on Virtio GPIO > DT bindings [1]. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml > > Reviewed-by: Oleksandr Tyshchenko > Signed-off-by: Viresh Kumar > --- > tools/libs/light/libxl_arm.c | 51 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 4c1012e56893..86c1e560900f 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -121,6 +121,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return rc; > } > > + for (i = 0; i < d_config->num_gpios; i++) { > + libxl_device_gpio *gpio = &d_config->gpios[i]; > + int rc = alloc_virtio_mmio_params(gc, &gpio->base, &gpio->irq, > + &virtio_mmio_base, &virtio_mmio_irq); > + > + if (rc) > + return rc; > + } > + > /* > * Every virtio-mmio device uses one emulated SPI. If Virtio devices are > * present, make sure that we allocate enough SPIs for them. > @@ -984,6 +993,38 @@ static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, uint64_t base, > return fdt_end_node(fdt); > } > > +static int make_virtio_mmio_node_gpio(libxl__gc *gc, void *fdt, uint64_t base, > + uint32_t irq, uint32_t backend_domid) > +{ > + int res; > + > + res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); > + if (res) return res; > + > + res = fdt_begin_node(fdt, "gpio"); > + if (res) return res; > + > + res = fdt_property_compat(gc, fdt, 1, "virtio,device29"); It is a very descriptive compatible :). And yes I realize this is the compatible chosen by upstream. > + if (res) return res; > + > + res = fdt_property(fdt, "gpio-controller", NULL, 0); > + if (res) return res; > + > + res = fdt_property_cell(fdt, "#gpio-cells", 2); > + if (res) return res; > + > + res = fdt_property(fdt, "interrupt-controller", NULL, 0); > + if (res) return res; > + > + res = fdt_property_cell(fdt, "#interrupt-cells", 2); > + if (res) return res; > + > + res = fdt_end_node(fdt); > + if (res) return res; > + > + return fdt_end_node(fdt); > +} > + > static const struct arch_info *get_arch_info(libxl__gc *gc, > const struct xc_dom_image *dom) > { > @@ -1317,6 +1358,16 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > i2c->backend_domid) ); > } > > + for (i = 0; i < d_config->num_gpios; i++) { > + libxl_device_gpio *gpio = &d_config->gpios[i]; > + > + if (gpio->backend_domid != LIBXL_TOOLSTACK_DOMID) > + iommu_needed = true; > + > + FDT( make_virtio_mmio_node_gpio(gc, fdt, gpio->base, gpio->irq, > + gpio->backend_domid) ); So this is exposing a GPIO interrupt controller but IIUC we will also need to describe the devices in the device-tree. Can you outline how you would expect it to work? To put some context, this is related to what I wrote in patch #1. How much code will be necessary in libxl to add new device? I am not the maintainer of this code, but I would expect some example how this can be used once this merged. This would help us to understand whether the interface is correct. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 07 18:20:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 18:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402137.644146 (Exim 4.92) (envelope-from ) id 1oVzfF-00010y-Q7; Wed, 07 Sep 2022 18:20:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402137.644146; Wed, 07 Sep 2022 18:20:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzfF-00010r-Ma; Wed, 07 Sep 2022 18:20:41 +0000 Received: by outflank-mailman (input) for mailman id 402137; Wed, 07 Sep 2022 18:20:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzfE-00010h-8s; Wed, 07 Sep 2022 18:20:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzfD-0003tT-P3; Wed, 07 Sep 2022 18:20:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oVzfD-0002dc-9w; Wed, 07 Sep 2022 18:20:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oVzfD-0003pk-9R; Wed, 07 Sep 2022 18:20:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4gb99K+7pT3XxPruAwKcJUX+sNTzKJT8tDP+q1mAItY=; b=qratk5BOtVTLgdMO/k66msW+uL /GChIArhZ3KBYS8Yev9Oi0cTYeCEm06lQ7iynQP+QIPy8D7iYK6fNRvfPihvcdb3+JCPoGSpz3Dda qtuMP9BatoAZ//g2IYxB66eomIw6irJ1EakeknNaTXRQb0rXX1+Zd4QqzJXW1rhK6pWc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173040: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=946e9bccf12f2bcc3ca471b820738fb22d14fc80 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Wed, 07 Sep 2022 18:20:39 +0000 flight 173040 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173040/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 7 xen-install fail in 173030 pass in 173040 test-amd64-i386-pair 10 xen-install/src_host fail in 173030 pass in 173040 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 173030 pass in 173040 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 173030 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 946e9bccf12f2bcc3ca471b820738fb22d14fc80 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 35 days Failing since 172148 2022-08-04 21:39:38 Z 33 days 77 attempts Testing same since 173030 2022-09-06 19:09:51 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov BALATON Zoltan Bin Meng Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Eugenio Pérez Gerd Hoffmann Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Xiaojuan Yang Xuzhou Cheng Yonggang Luo Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6080 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 21:25:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 21:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402338.644247 (Exim 4.92) (envelope-from ) id 1oW2Xq-0001gJ-88; Wed, 07 Sep 2022 21:25:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402338.644247; Wed, 07 Sep 2022 21:25:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW2Xq-0001gC-5X; Wed, 07 Sep 2022 21:25:14 +0000 Received: by outflank-mailman (input) for mailman id 402338; Wed, 07 Sep 2022 21:25:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW2Xo-0001fj-CK; Wed, 07 Sep 2022 21:25:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW2Xo-0007BK-BE; Wed, 07 Sep 2022 21:25:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW2Xn-0005qQ-Od; Wed, 07 Sep 2022 21:25:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oW2Xn-0004Zv-OB; Wed, 07 Sep 2022 21:25:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mM9hTZwOuAFhVq8Tt1kZH9Z+ljBlETR8iobbnDeC0ZY=; b=YWcFC5qD/8bR1opo6xnGdW/0Ck PCMwJSyPBmuiPSPLOGGfRpc7ZruaGkVWYZ6A9UsLnBJWmSOEeNbmEx4y0Cfzw2eKKSIiM85yl4FWo unLoWu6kHieNDZFCCdSoOyAr2adIueqQByAAMX54cx5zljde9a4+fidpW+yH09QRgLKI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173050: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=54c8d5e432319c632dab5d4466f50876872ce6b3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 07 Sep 2022 21:25:11 +0000 flight 173050 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173050/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 54c8d5e432319c632dab5d4466f50876872ce6b3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 34 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 262 attempts Testing same since 173050 2022-09-07 18:12:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2173 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 07 22:56:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 22:56:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402349.644258 (Exim 4.92) (envelope-from ) id 1oW3xR-0003jP-Q1; Wed, 07 Sep 2022 22:55:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402349.644258; Wed, 07 Sep 2022 22:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW3xR-0003jI-ND; Wed, 07 Sep 2022 22:55:45 +0000 Received: by outflank-mailman (input) for mailman id 402349; Wed, 07 Sep 2022 22:55:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW3xP-0003jC-MO for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 22:55:43 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31fc8cd9-2f00-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 00:55:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B3A661AFA; Wed, 7 Sep 2022 22:55:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF266C433C1; Wed, 7 Sep 2022 22:55:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31fc8cd9-2f00-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662591339; bh=xJI7MKALxBULf8g608wz6nLt8ppaK80oF0WwRJgfDOQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ECP3cEmsb7KEMTsus9+2dXe6niSouifTXLEb4dBwH7nUiR0bqP9LtS+UeypOlMzK6 I9bdkm9sHG0CI4Y+KZbEst944nL+eZwfqFqDyIko0LK9ZLfgC8Ek80cugHMQ8j+b5+ CqwOXoC+gCqnW/nCE83u2IGnMGCidj845CD7D8o1cABprLIF4z1y/v3gW36rPqdac0 BMZJT/Q7/msunVIZE07VxoQhsvWnXVmMeWOw9x+XKco86GmCV7ve8AbT9SYp401zbL rqI2dokrpf1L2JI+pJdGoye3i5o0+j06uYP/Z0a8NmCrwwM2xaftR6xGbE/rhJguJk CrqSLLAnQp7Ng== Date: Wed, 7 Sep 2022 15:55:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Jan Beulich , Rahul Singh , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar In-Reply-To: <11fed186-7295-00b0-4fb9-50d08e63f364@xen.org> Message-ID: References: <11fed186-7295-00b0-4fb9-50d08e63f364@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Julien Grall wrote: > Hi Jan, > > On 07/09/2022 13:06, Jan Beulich wrote: > > On 07.09.2022 13:09, Rahul Singh wrote: > > > is_memory_hole was implemented for x86 and not for ARM when introduced. > > > Replace is_memory_hole call to pci_check_bar as function should check > > > if device BAR is in defined memory range. Also, add an implementation > > > for ARM which is required for PCI passthrough. > > > > > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > > > is not overlapping with any memory region defined in the memory map. > > > > > > On ARM, pci_check_bar will go through the host bridge ranges and check > > > if the BAR is in the range of defined ranges. > > > > > > Signed-off-by: Rahul Singh > > > --- > > > Changes in v4: > > > - check "s <= e" before callback > > > - Add TODO comment for revisiting the function pci_check_bar() when > > > ACPI PCI passthrough support is added. > > > - Not Added the Jan Acked-by as patch is modified. > > > > Hmm, I don't see any change to the parts the ack covers (x86 and common), > > so please re-instate. I'm not in the position to ack Arm changes; things > > would be different for a Reviewed-by without scope restriction. > > I would like the question about the BAR alignment to be resolved before giving > my Reviewed-by/Acked-by here. > > Hopefully Stefano can clarify it. We had a discussion this morning and this is the summary. BAR addresses and Root Complex window addresses are not guaranteed to be page aligned. If they are not guaranteed to be page aligned we should check for alignment, however, this is not the right location for the alignment check. It is a good idea to add a TODO comment in the code. So that we don't relax the check in case the addresses are not aligned, we should drop the use of PFN_UP and PFN_DOWN in this check. From xen-devel-bounces@lists.xenproject.org Wed Sep 07 23:39:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 23:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402356.644268 (Exim 4.92) (envelope-from ) id 1oW4dW-0000Tz-3W; Wed, 07 Sep 2022 23:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402356.644268; Wed, 07 Sep 2022 23:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4dW-0000Ts-0c; Wed, 07 Sep 2022 23:39:14 +0000 Received: by outflank-mailman (input) for mailman id 402356; Wed, 07 Sep 2022 23:39:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4dU-0000Tm-W9 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 23:39:12 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45e180d8-2f06-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 01:39:11 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73690B81F28; Wed, 7 Sep 2022 23:39:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C341FC433C1; Wed, 7 Sep 2022 23:39:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45e180d8-2f06-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662593949; bh=y6LPQxLnS+ZXbuHF2hCPfhKS2qafpqxlaGKdYoLS7CM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OvGF93/0PMcpenC9/eFJb/eH4MGnRysTW4yindHgibdH17BpTmjt2Rzs92cayTuIz JzxShrQJhHaWmbAKW9uYzbJEKpTzowV8OKgvrqHhUMGjHnAyVKH6Q9MAic8A4yzhfe Vkj3NOPjyh0A/6rTTS3ASZ7YXYj/z0A/YOlsROr3Hm9Nu+6CHow03GYw2Sm9e9ov9d JyT/x4/109rOvH9QesFsQtYWT58X3C8C+BTxSxeNGA92W8gOCrAvZnxW6861f8GxAI dzH5h+cAtpce05GEj+qIC5nL0lAKICKCDF5bC9ojMOfqvy+4IyahO1SVGuWcabpz6g 8HTTmIxBlNISg== Date: Wed, 7 Sep 2022 16:39:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder v2 1/2] scripts/common: Introduce phandle_next and get_next_phandle() In-Reply-To: <20220907110852.5673-1-michal.orzel@amd.com> Message-ID: References: <20220907110852.5673-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Michal Orzel wrote: > When dealing with device trees, we need to have a solution to add > custom phandles to the nodes we create/modify. Add a global variable > phandle_next to act as a countdown counter starting with the highest > valid phandle value 0xfffffffe. Add a new function get_next_phandle > to get a value of the next available phandle and set it to a variable > whose name is passed as a first argument. The global counter will be > decremented with each call to this function. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > To make the interface to phandle_next as simple as possible, we just > need a single function that will get us the next phandle and update the > global counter. That is why we cannot use the following: > - "phandle=$(get_next_phandle)" as a subshell cannot modify the environment > of its parent shell, > - making use of return statement as it only works with values up to 255 > > The current solution with passing a variable name to a function that > will modify its value using eval is the simplest one and serves our purpose. I love the trick > Changes in v2: > - new patch > --- > scripts/common | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/scripts/common b/scripts/common > index 68938beb8557..25c041270c29 100644 > --- a/scripts/common > +++ b/scripts/common > @@ -13,6 +13,9 @@ > tmp_files=() > tmp_dirs=() > > +# Highest valid phandle. Will be decremented with each call to get_next_phandle > +phandle_next="0xfffffffe" > + > function remove_tmp_files() > { > for i in "${tmp_files[@]}" > @@ -26,6 +29,14 @@ function remove_tmp_files() > done > } > > +# Get next phandle and set it as a value (in hex) of a variable whose name is > +# passed as a first argument. Decrement global counter phandle_next. > +function get_next_phandle() > +{ > + eval "$1=$(printf "0x%x" $phandle_next)" > + phandle_next=$(( $phandle_next - 1 )) > +} > + > function sanity_check_partial_dts() > { > local domU_passthrough_path="$1" > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 23:39:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 23:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402357.644279 (Exim 4.92) (envelope-from ) id 1oW4dj-0000ur-C9; Wed, 07 Sep 2022 23:39:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402357.644279; Wed, 07 Sep 2022 23:39:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4dj-0000uk-9S; Wed, 07 Sep 2022 23:39:27 +0000 Received: by outflank-mailman (input) for mailman id 402357; Wed, 07 Sep 2022 23:39:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4di-0000Tm-CK for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 23:39:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dfe98a9-2f06-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 01:39:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D473961ACC; Wed, 7 Sep 2022 23:39:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAE24C433C1; Wed, 7 Sep 2022 23:39:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dfe98a9-2f06-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662593963; bh=aHcQig6B78HlsIc3k8URzCL5jbuYs/hzZzYbGc/m1qs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HhIZqeAoRhioa5y3V4xU+hkAMwDhAQemZahRE3t7HDALDUPiaQOMAdZhkuDSWL/e1 ZBpuKVZ9C8tdFkWCPFOioj9Yje9tYKVFhgSAMDt4jd2OU+MB5bS7i645IgrerlWMjC wLoiqiL4HIRWNlrHbun1bKngiti+dLcg1mBG7ErNzJ1feh2fYtNgvAcJT6EomTp3nX Fa0aZYBd1wzj5bogjlMHi/1ekHZJ8Y6okZq0lgO/JAtHlHx+koGL9GvbfvqS+366WB VUCXzvgE84SZjyXhFgrxya0hovla7YMLKVpGkVPuWYzT73reUWc5IbvpLY7upkT3tX KEj4MePatYrhg== Date: Wed, 7 Sep 2022 16:39:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder v2 2/2] Add support for Xen boot-time cpupools In-Reply-To: <20220907110852.5673-2-michal.orzel@amd.com> Message-ID: References: <20220907110852.5673-1-michal.orzel@amd.com> <20220907110852.5673-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Michal Orzel wrote: > Introduce support for creating boot-time cpupools in the device tree and > assigning them to dom0less domUs. Add the following options: > - CPUPOOL[number]="cpu@1,...,cpu@N scheduler" to specify the > list of cpus' node names and the scheduler to be used to create cpupool > - NUM_CPUPOOLS to specify the number of cpupools to create > - DOMU_CPUPOOL[number]="" to specify the id of the cpupool to > assign to domU > > Example usage: > CPUPOOL[0]="cpu@1,cpu@2 null" > DOMU_CPUPOOL[0]=0 > NUM_CPUPOOLS=1 > > The above example will create a boot-time cpupool (id=0) with 2 cpus: > cpu@1, cpu@2 and the null scheduler. It will assign the cpupool with > id=0 to domU0. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - make use of get_next_phandle > - pass cpus' node names instead of paths to CPUPOOL > - do not pass NUM_CPUPOOLS as an argument to add_device_tree_cpupools > --- > README.md | 10 +++++ > scripts/uboot-script-gen | 79 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 89 insertions(+) > > diff --git a/README.md b/README.md > index bd9dac924b44..041818349954 100644 > --- a/README.md > +++ b/README.md > @@ -181,6 +181,9 @@ Where: > present. If set to 1, the VM can use PV drivers. Older Linux kernels > might break. > > +- DOMU_CPUPOOL[number] specifies the id of the cpupool (created using > + CPUPOOL[number] option, where number == id) that will be assigned to domU. > + > - LINUX is optional but specifies the Linux kernel for when Xen is NOT > used. To enable this set any LINUX\_\* variables and do NOT set the > XEN variable. > @@ -223,6 +226,13 @@ Where: > include the public key in. This can only be used with > FIT_ENC_KEY_DIR. See the -u option below for more information. > > +- CPUPOOL[number]="cpu@1,...,cpu@N scheduler" > + specifies the list of cpus' node names (separated by commas) and the scheduler > + to be used to create boot-time cpupool. If no scheduler is set, the Xen > + default one will be used. > + > +- NUM_CPUPOOLS specifies the number of boot-time cpupools to create. > + > Then you can invoke uboot-script-gen as follows: > > ``` > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 18c0ce10afb4..1f8ab5ffd193 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -176,6 +176,80 @@ function add_device_tree_static_mem() > dt_set "$path" "xen,static-mem" "hex" "${cells[*]}" > } > > +function add_device_tree_cpupools() > +{ > + local cpu > + local cpus > + local scheduler > + local cpu_list > + local phandle > + local cpu_phandles > + local i > + local j > + > + i=0 > + while test $i -lt $NUM_CPUPOOLS > + do > + cpus=$(echo ${CPUPOOL[$i]} | awk '{print $1}') > + scheduler=$(echo ${CPUPOOL[$i]} | awk '{print $NF}') > + cpu_phandles= > + > + for cpu in ${cpus//,/ } > + do > + cpu="/cpus/$cpu" > + > + # check if cpu exists > + if ! fdtget "${DEVICE_TREE}" "$cpu" "reg" &> /dev/null > + then > + echo "$cpu does not exist" > + cleanup_and_return_err > + fi > + > + # check if cpu is already assigned > + if [[ "$cpu_list" == *"$cpu"* ]] > + then > + echo "$cpu already assigned to another cpupool" > + cleanup_and_return_err > + fi > + > + # set phandle for a cpu if there is none > + if ! phandle=$(fdtget -t x "${DEVICE_TREE}" "$cpu" "phandle" 2> /dev/null) > + then > + get_next_phandle phandle > + fi > + > + dt_set "$cpu" "phandle" "hex" "$phandle" > + cpu_phandles="$cpu_phandles $phandle" > + cpu_list="$cpu_list $cpu" > + done > + > + # create cpupool node > + get_next_phandle phandle > + dt_mknode "/chosen" "cpupool_$i" > + dt_set "/chosen/cpupool_$i" "phandle" "hex" "$phandle" > + dt_set "/chosen/cpupool_$i" "compatible" "str" "xen,cpupool" > + dt_set "/chosen/cpupool_$i" "cpupool-cpus" "hex" "$cpu_phandles" > + > + if test "$scheduler" != "$cpus" > + then > + dt_set "/chosen/cpupool_$i" "cpupool-sched" "str" "$scheduler" > + fi > + > + j=0 > + while test $j -lt $NUM_DOMUS > + do > + # assign cpupool to domU > + if test "${DOMU_CPUPOOL[$j]}" -eq "$i" > + then > + dt_set "/chosen/domU$j" "domain-cpupool" "hex" "$phandle" > + fi > + j=$(( $j + 1 )) > + done > + > + i=$(( $i + 1 )) > + done > +} > + > function xen_device_tree_editing() > { > dt_set "/chosen" "#address-cells" "hex" "0x2" > @@ -252,6 +326,11 @@ function xen_device_tree_editing() > fi > i=$(( $i + 1 )) > done > + > + if test "$NUM_CPUPOOLS" && test "$NUM_CPUPOOLS" -gt 0 > + then > + add_device_tree_cpupools > + fi > } > > function linux_device_tree_editing() > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 07 23:57:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 23:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402370.644291 (Exim 4.92) (envelope-from ) id 1oW4uY-0003lk-QQ; Wed, 07 Sep 2022 23:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402370.644291; Wed, 07 Sep 2022 23:56:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4uY-0003ld-Nc; Wed, 07 Sep 2022 23:56:50 +0000 Received: by outflank-mailman (input) for mailman id 402370; Wed, 07 Sep 2022 23:56:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4uX-0003lX-25 for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 23:56:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id badbe239-2f08-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 01:56:47 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 856CA61AF9; Wed, 7 Sep 2022 23:56:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1104C433C1; Wed, 7 Sep 2022 23:56:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: badbe239-2f08-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662595004; bh=36fenpx6NiCJovDMTugfUZeR5Kmo3TDy9zjC/oYAs8Y=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lmerQM9dy+FwTTcvvrGo2KPy5K3H1K1PLfy/zZqhxl6rcECx1QbvbHMklIk31tlY9 niAsTu/VClEqLTE8Zq/V/69V1Kk6gdM0CdXory61k5+Ht2f/NRrJWxjvXa3BTRZgZ3 f5ySggWfVEbAsQubcAGyEpbvjwYPw+rOT6HQ0DB9apYZDbnFOokwirP73mTHSP2KkP QNCzItGu7/RbXzzdpDttjXqF+ZHAmBtRRLbz3uULzwMsYpfbpXD999U9d/RrdX4Fgw 7fycPSf1MWQtpp3znvH/14oJSD2y3//c2UH83r15sRHC2L9y/cQaBNBkJo9AE6HX9e 6rIVrhvCRyLiw== Date: Wed, 7 Sep 2022 16:56:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Henry Wang , Bertrand Marquis , Michal Orzel , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory In-Reply-To: <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Julien Grall wrote: > On 07/09/2022 14:49, Henry Wang wrote: > > > -----Original Message----- > > > From: Bertrand Marquis > > > > > > > But in any case we should only add one pair here for sure, as you > > > > > > > say > > > the > > > > > > > only implication is to add a couple of 0 in the worst case. > > > > > > I agree. The only drawback is the need to modify the already > > > > > > introduced > > > properties > > > > > > to be coherent. > > > > > > > > > > Agree, someone will need to do a pass on the whole doc which might be > > > easier with all things in. > > > > > > > > > Well, not only docs. If we decide to use a single pair of #address-cells > > > > and > > > #size-cells, then > > > > we need to modify the code that expects different properties e.g. > > > xen,static-mem-{address/size}-cells. > > > > > > Right I forgot that some parts are already in. > > > So we will need an extra patch to handle those. > > > > I think I've addressed all comments from Julien regarding my series, > > If it is not too late for you would you be able to resend your series without > the 'address-cells'/'size-cells' change? This will give me the opportunity to > have an other review today. > > > so I think I've got some bandwidth to do the clean-up patch tomorrow > > after the agreement, unless someone would like to do it himself? > > Renaming "xen,static-mem-..." is a bit tricky because they have been defined > in Xen 4.16. > > I couldn't find any support statement specific to the static memory feature. > So it would technically fall under the "dom0less" section which is security > supported. > > That said, I don't think we can consider that the static memory feature is > even supported because, until yesterday, the code wasn't properly handling > request to balloon in/out. So I would view this is a tech preview (Could > someone send a patch to clarify SUPPORT.MD)? > > This would mean that would be that we could consider the binding unstable and > we could do a straight renaming. That said, I can understand this may be > undesirable. > > If that's the case then we would need to keep the current binding as-is. So we > would have two options: > 1) Provide a new compatible so #address-cells #size-cells can be used. The > current binding can be deprecated > 2) Leave as-is and accept the difference > > I don't have a strong opinion on which way to go. Whichever, it would be good > to write down the rationale in the commit message of the "future" patch. > > I would not block this series on the renaming for existing property (what > matter is the new ones are consistent with the discussion). The renaming could > be done afterwards. I would even say post the feature freeze on Friday because > this could be considered as a bug fix (assuming you agree as the release > manager :)). I very much agree that we should be consistent. Consistency aside, I would prefer *not* to introduce #xen,static-heap-address-cells and #xen,static-heap-size-cells and instead reuse the regular #address-cells and #size-cells. I think there is no reason why we shouldn't. I was about to write something about it a couple of days ago but then I noticed that we had already introduced #xen,static-mem-address-cells and #xen,static-mem-size-cells. In order to be consistent I didn't say anything and gave my ack. But actually I think it is better to get rid of them all. I think we should: 1) do not introduce #xen,static-heap-address-cells and #xen,static-heap-size-cells in this series, instead rely on #address-cells and #size-cells. Please write in the binding that the number of address cells and size cells of xen,static-heap is determined by the parent #address-cells and #size-cells. (It has to be the parent because that is how #address-cells and #size-cells are defined.) 2) Also remove "#xen,static-mem-address-cells" and "#xen,static-mem-size-cells", and also use #address-cells and #size-cells for xen,static-mem as well. I think we should do that in this release for consistency. Any volunteers? :-) It is not going to break anything because, not only static-mem is tech preview, but also it is very likely that if someone was using #xen,static-heap-address-cells it would be setting it to the same value as #address-cells. So in the vast majority of cases it would continue to work as expected (not that we couldn't change it anyway, given that it is a tech preview.) So I am aligned with Julien on this. From xen-devel-bounces@lists.xenproject.org Wed Sep 07 23:59:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 07 Sep 2022 23:59:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402379.644302 (Exim 4.92) (envelope-from ) id 1oW4xC-0004fJ-BC; Wed, 07 Sep 2022 23:59:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402379.644302; Wed, 07 Sep 2022 23:59:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4xC-0004fC-8S; Wed, 07 Sep 2022 23:59:34 +0000 Received: by outflank-mailman (input) for mailman id 402379; Wed, 07 Sep 2022 23:59:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW4xA-0004f4-Fh for xen-devel@lists.xenproject.org; Wed, 07 Sep 2022 23:59:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ce4c1c7-2f09-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 01:59:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1047061A9D; Wed, 7 Sep 2022 23:59:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3336C433C1; Wed, 7 Sep 2022 23:59:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ce4c1c7-2f09-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662595169; bh=D77fCw82BGFk6gaLnYQNwo3rAsJjJxpqDF2PpaGuHnY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sPeKQM/XG23hUAyM2pKzqsZGUIwbAyJEIBue5F374HP38z/ctGBUePgo9S6V20JJX dybp/w10HO5F0dRa2n767uWcnShR4E269OFxm6dF+ai2dHmi6ppDKquSQcMcMvyfvd u4WP1CLP7X385Iz4Az+X0kxsKiG2WqiNNv9jVyuuVaPJ2W4qJMZ/pBHL+dfGHDVEhs JoSBBdxFn6Qbe+tz88LkUmbzxHgsycNFiuwKWJWj+8v25iTEeBNAmvagCFEgy08ZXX dFv3ZgvSz0mgmgcWoNPtgRkDzgf5wLZ3HmRSvNJLWzLMV1PVcseB6w02xPnawXhGN3 7FpRFtjPdb+Fg== Date: Wed, 7 Sep 2022 16:59:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v5 6/7] xen/arm: introduce new xen,enhanced property value In-Reply-To: <97b7eb518101b403c6e90052aaeeaa50e5ac2c79.1662563170.git.rahul.singh@arm.com> Message-ID: References: <97b7eb518101b403c6e90052aaeeaa50e5ac2c79.1662563170.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Rahul Singh wrote: > Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to > disable xenstore interface for dom0less guests. > > Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini > --- > Changes in v5: > - fix minor comments > - change unit64_t to uint16_t for dom0less_feature > Changes in v4: > - Implement defines for dom0less features > Changes in v3: > - new patch in this version > --- > docs/misc/arm/device-tree/booting.txt | 4 ++++ > xen/arch/arm/domain_build.c | 10 ++++++---- > xen/arch/arm/include/asm/kernel.h | 23 +++++++++++++++++++++-- > 3 files changed, 31 insertions(+), 6 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..47567b3906 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -204,6 +204,10 @@ with the following properties: > - "disabled" > Xen PV interfaces are disabled. > > + - "no-xenstore" > + All default Xen PV interfaces, including grant-table will be enabled but > + xenstore will be disabled for the VM. > + > If the xen,enhanced property is present with no value, it defaults > to "enabled". If the xen,enhanced property is not present, PV > interfaces are disabled. > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4664a8f961..580ed70b9c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2891,7 +2891,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > goto err; > } > > - if ( kinfo->dom0less_enhanced ) > + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) > { > ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); > if ( ret ) > @@ -3209,10 +3209,12 @@ static int __init construct_domU(struct domain *d, > (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) > { > if ( hardware_domain ) > - kinfo.dom0less_enhanced = true; > + kinfo.dom0less_feature = DOM0LESS_ENHANCED; > else > - panic("Tried to use xen,enhanced without dom0\n"); > + panic("At the moment, Xenstore support requires dom0 to be present\n"); > } > + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) > + kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; > > if ( vcpu_create(d, 0) == NULL ) > return -ENOMEM; > @@ -3252,7 +3254,7 @@ static int __init construct_domU(struct domain *d, > if ( rc < 0 ) > return rc; > > - if ( kinfo.dom0less_enhanced ) > + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) > { > ASSERT(hardware_domain); > rc = alloc_xenstore_evtchn(d); > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index c4dc039b54..f8bb85767b 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -9,6 +9,25 @@ > #include > #include > > +/* > + * List of possible features for dom0less domUs > + * > + * DOM0LESS_ENHANCED_NO_XS: Notify the OS it is running on top of Xen. All the > + * default features (excluding Xenstore) will be > + * available. Note that an OS *must* not rely on the > + * availability of Xen features if this is not set. > + * DOM0LESS_XENSTORE: Xenstore will be enabled for the VM. This feature > + * can't be enabled without the > + * DOM0LESS_ENHANCED_NO_XS. > + * DOM0LESS_ENHANCED: Notify the OS it is running on top of Xen. All the > + * default features (including Xenstore) will be > + * available. Note that an OS *must* not rely on the > + * availability of Xen features if this is not set. > + */ > +#define DOM0LESS_ENHANCED_NO_XS BIT(0, U) > +#define DOM0LESS_XENSTORE BIT(1, U) > +#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_NO_XS | DOM0LESS_XENSTORE) > + > struct kernel_info { > #ifdef CONFIG_ARM_64 > enum domain_type type; > @@ -36,8 +55,8 @@ struct kernel_info { > /* Enable pl011 emulation */ > bool vpl011; > > - /* Enable PV drivers */ > - bool dom0less_enhanced; > + /* Enable/Disable PV drivers interfaces */ > + uint16_t dom0less_feature; > > /* GIC phandle */ > uint32_t phandle_gic; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 00:04:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 00:04:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402386.644312 (Exim 4.92) (envelope-from ) id 1oW527-0006hU-Ig; Thu, 08 Sep 2022 00:04:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402386.644312; Thu, 08 Sep 2022 00:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW527-0006hN-G2; Thu, 08 Sep 2022 00:04:39 +0000 Received: by outflank-mailman (input) for mailman id 402386; Thu, 08 Sep 2022 00:04:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW525-0006hH-Or for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 00:04:37 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1f803e3-2f09-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 02:04:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B5EA161AF6; Thu, 8 Sep 2022 00:04:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57E32C433D6; Thu, 8 Sep 2022 00:04:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1f803e3-2f09-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662595473; bh=WuJ/YmjFPn5a9bGusS+aVpZiKksiledTSxHUyfiofpQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=t421Rf5FMOE9vt7oWiDO68Uu+6L3UFyY/irmAzBmTm6HlLBgYRu6QtHZKLRrFOYda 6YSEqFlN2fJKy0RWlYr3hWsLN9QPpzucGCgR+DcwSy5zjJMuuamnf5gbhyP4hJCHse oxlg+aQxMRJld94JCRi/4ZD7m/+6UzipT6ncYEJ+tzv6gn2G7LL4D9CLDIjvzWJAVQ OibdHFZHvupLWn9Py6TLbMng2yL/LeiSRSBXjkHdW6pHPeRpG2aHPXVu9Ws1DyZFr8 QSQITWxpJcz+SQ/b3wxa9pLgJGNXYAtjfpeInJ7HSpUpLenj9gMi/27elLjHvdNNdx c4WVj9nEU4x5Q== Date: Wed, 7 Sep 2022 17:04:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v5 7/7] xen/arm: introduce xen-evtchn dom0less property In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Rahul Singh wrote: > Introduce a new sub-node under /chosen node to establish static event > channel communication between domains on dom0less systems. > > An event channel will be created beforehand to allow the domains to > send notifications to each other. > > Signed-off-by: Rahul Singh For the DT binding: Reviewed-by: Stefano Stabellini > --- > Changes in v5: > - fix minor comments > Changes in v4: > - move documentation to common place for evtchn node in booting.txt > - Add comment why we use dt_device_static_evtchn_created() > - check if dt_get_parent() returns NULL > - fold process_static_evtchn_node() in alloc_static_evtchn() > Changes in v3: > - use device-tree used_by to find the domain id of the evtchn node. > - add new static_evtchn_create variable in struct dt_device_node to > hold the information if evtchn is already created. > - fix minor comments > Changes in v2: > - no change > --- > --- > docs/misc/arm/device-tree/booting.txt | 98 +++++++++++++++++ > xen/arch/arm/domain_build.c | 147 ++++++++++++++++++++++++++ > xen/arch/arm/include/asm/setup.h | 1 + > xen/arch/arm/setup.c | 2 + > xen/include/xen/device_tree.h | 16 +++ > 5 files changed, 264 insertions(+) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 47567b3906..e03e5e9e4c 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -382,3 +382,101 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > +Static Event Channel > +==================== > +The event channel communication will be established statically between two > +domains (dom0 and domU also). Event channel connection information between > +domains will be passed to Xen via the device tree node. The event channel > +will be created and established in Xen before the domain started. The domain > +does not need to do any operation to establish a connection. Domain only > +needs hypercall EVTCHNOP_send(local port) to send notifications to the > +remote guest. > + > +There is no need to describe the static event channel info in the domU device > +tree. Static event channels are only useful in fully static configurations, > +and in those configurations, the domU device tree dynamically generated by Xen > +is not needed. > + > +To enable the event-channel interface for domU guests include the > +xen,enhanced = "no-xenstore" property in the domU Xen device tree node. > + > +Under the "xen,domain" compatible node for domU, there needs to be sub-nodes > +with compatible "xen,evtchn" that describe the event channel connection > +between two domUs. For dom0, there needs to be sub-nodes with compatible > +"xen,evtchn" under the chosen node. > + > +The static event channel node has the following properties: > + > +- compatible > + > + "xen,evtchn" > + > +- xen,evtchn > + > + The property is tuples of two numbers > + (local-evtchn link-to-foreign-evtchn) where: > + > + local-evtchn is an integer value that will be used to allocate local port > + for a domain to send and receive event notifications to/from the remote > + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. > + It is recommended to use low event channel IDs. > + > + link-to-foreign-evtchn is a single phandle to a remote evtchn to which > + local-evtchn will be connected. > + > +Example > +======= > + > +chosen { > + > + /* One sub-node per local event channel. This sub-node is for Dom0. */ > + ec1: evtchn@1 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec2>; > + }; > + > + domU1 { > + compatible = "xen,domain"; > + #address-cells = <0x2>; > + #size-cells = <0x1>; > + xen,enhanced = "no-xenstore"; > + > + /* One sub-node per local event channel */ > + ec2: evtchn@2 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec1>; > + }; > + > + ec3: evtchn@3 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xb &ec5>; > + }; > + > + ec4: evtchn@4 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xc &ec6>; > + }; > + }; > + > + domU2 { > + compatible = "xen,domain"; > + #address-cells = <0x2>; > + #size-cells = <0x1>; > + xen,enhanced = "no-xenstore"; > + > + /* One sub-node per local event channel */ > + ec5: evtchn@5 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xb &ec3>; > + }; > + > + ec6: evtchn@6 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xd &ec4>; > + }; > + }; > +}; > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 580ed70b9c..1a59bd7e29 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -33,6 +33,8 @@ > #include > #include > > +#define STATIC_EVTCHN_NODE_SIZE_CELLS 2 > + > static unsigned int __initdata opt_dom0_max_vcpus; > integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); > > @@ -3052,6 +3054,150 @@ void __init evtchn_allocate(struct domain *d) > d->arch.hvm.params[HVM_PARAM_CALLBACK_IRQ] = val; > } > > +static int __init get_evtchn_dt_property(const struct dt_device_node *np, > + uint32_t *port, uint32_t *phandle) > +{ > + const __be32 *prop = NULL; > + uint32_t len; > + > + prop = dt_get_property(np, "xen,evtchn", &len); > + if ( !prop ) > + { > + printk(XENLOG_ERR "xen,evtchn property should not be empty.\n"); > + return -EINVAL; > + } > + > + if ( !len || len < dt_cells_to_size(STATIC_EVTCHN_NODE_SIZE_CELLS) ) > + { > + printk(XENLOG_ERR "xen,evtchn property value is not valid.\n"); > + return -EINVAL; > + } > + > + *port = dt_next_cell(1, &prop); > + *phandle = dt_next_cell(1, &prop); > + > + return 0; > +} > + > +static int __init alloc_domain_evtchn(struct dt_device_node *node) > +{ > + int rc; > + uint32_t domU1_port, domU2_port, remote_phandle; > + struct dt_device_node *remote_node; > + const struct dt_device_node *p1_node, *p2_node; > + struct evtchn_alloc_unbound alloc_unbound; > + struct evtchn_bind_interdomain bind_interdomain; > + struct domain *d1 = NULL, *d2 = NULL; > + > + if ( !dt_device_is_compatible(node, "xen,evtchn-v1") ) > + return 0; > + > + /* > + * Event channel is already created while parsing the other side of > + * evtchn node. > + */ > + if ( dt_device_static_evtchn_created(node) ) > + return 0; > + > + rc = get_evtchn_dt_property(node, &domU1_port, &remote_phandle); > + if ( rc ) > + return rc; > + > + remote_node = dt_find_node_by_phandle(remote_phandle); > + if ( !remote_node ) > + { > + printk(XENLOG_ERR > + "evtchn: could not find remote evtchn phandle\n"); > + return -EINVAL; > + } > + > + rc = get_evtchn_dt_property(remote_node, &domU2_port, &remote_phandle); > + if ( rc ) > + return rc; > + > + if ( node->phandle != remote_phandle ) > + { > + printk(XENLOG_ERR "xen,evtchn property is not setup correctly.\n"); > + return -EINVAL; > + } > + > + p1_node = dt_get_parent(node); > + if ( !p1_node ) > + { > + printk(XENLOG_ERR "evtchn: evtchn parent node is NULL\n" ); > + return -EINVAL; > + } > + > + p2_node = dt_get_parent(remote_node); > + if ( !p2_node ) > + { > + printk(XENLOG_ERR "evtchn: remote parent node is NULL\n" ); > + return -EINVAL; > + } > + > + d1 = get_domain_by_id(p1_node->used_by); > + d2 = get_domain_by_id(p2_node->used_by); > + > + if ( !d1 || !d2 ) > + { > + printk(XENLOG_ERR "evtchn: could not find domains\n" ); > + return -EINVAL; > + } > + > + alloc_unbound.dom = d1->domain_id; > + alloc_unbound.remote_dom = d2->domain_id; > + > + rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); > + if ( rc < 0 ) > + { > + printk(XENLOG_ERR > + "evtchn_alloc_unbound() failure (Error %d) \n", rc); > + return rc; > + } > + > + bind_interdomain.remote_dom = d1->domain_id; > + bind_interdomain.remote_port = domU1_port; > + > + rc = evtchn_bind_interdomain(&bind_interdomain, d2, domU2_port); > + if ( rc < 0 ) > + { > + printk(XENLOG_ERR > + "evtchn_bind_interdomain() failure (Error %d) \n", rc); > + return rc; > + } > + > + dt_device_set_static_evtchn_created(node); > + dt_device_set_static_evtchn_created(remote_node); > + > + return 0; > +} > + > +void __init alloc_static_evtchn(void) > +{ > + struct dt_device_node *node, *evtchn_node; > + struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); > + > + BUG_ON(chosen == NULL); > + > + if ( hardware_domain ) > + dt_device_set_used_by(chosen, hardware_domain->domain_id); > + > + dt_for_each_child_node(chosen, node) > + { > + if ( hardware_domain ) > + { > + if ( alloc_domain_evtchn(node) != 0 ) > + panic("Could not set up domains evtchn\n"); > + } > + > + dt_for_each_child_node(node, evtchn_node) > + { > + if ( alloc_domain_evtchn(evtchn_node) != 0 ) > + panic("Could not set up domains evtchn\n"); > + } > + } > +} > + > static void __init find_gnttab_region(struct domain *d, > struct kernel_info *kinfo) > { > @@ -3369,6 +3515,7 @@ void __init create_domUs(void) > panic("Error creating domain %s\n", dt_node_name(node)); > > d->is_console = true; > + dt_device_set_used_by(node, d->domain_id); > > if ( construct_domU(d, node) != 0 ) > panic("Could not set up domain %s\n", dt_node_name(node)); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 5815ccf8c5..5ee28b270f 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -106,6 +106,7 @@ int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); > > void create_domUs(void); > void create_dom0(void); > +void alloc_static_evtchn(void); > > void discard_initial_modules(void); > void fw_unreserved_regions(paddr_t s, paddr_t e, > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 7814fe323d..909013992e 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1078,6 +1078,8 @@ void __init start_xen(unsigned long boot_phys_offset, > if ( acpi_disabled ) > create_domUs(); > > + alloc_static_evtchn(); > + > /* > * This needs to be called **before** heap_init_late() so modules > * will be scrubbed (unless suppressed). > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index 430a1ef445..a28937d12a 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -92,6 +92,10 @@ struct dt_device_node { > > /* IOMMU specific fields */ > bool is_protected; > + > + /* HACK: Remove this if there is a need of space */ > + bool_t static_evtchn_created; > + > /* > * The main purpose of this list is to link the structure in the list > * of devices assigned to domain. > @@ -317,6 +321,18 @@ static inline bool_t dt_property_name_is_equal(const struct dt_property *pp, > return !dt_prop_cmp(pp->name, name); > } > > +static inline void > +dt_device_set_static_evtchn_created(struct dt_device_node *device) > +{ > + device->static_evtchn_created = true; > +} > + > +static inline bool_t > +dt_device_static_evtchn_created(const struct dt_device_node *device) > +{ > + return device->static_evtchn_created; > +} > + > /** > * dt_find_compatible_node - Find a node based on type and one of the > * tokens in its "compatible" property > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 00:16:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 00:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402393.644323 (Exim 4.92) (envelope-from ) id 1oW5De-0008Og-KH; Thu, 08 Sep 2022 00:16:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402393.644323; Thu, 08 Sep 2022 00:16:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5De-0008OZ-HM; Thu, 08 Sep 2022 00:16:34 +0000 Received: by outflank-mailman (input) for mailman id 402393; Thu, 08 Sep 2022 00:16:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5Dd-0008OT-Hi for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 00:16:33 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d52aabe-2f0b-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 02:16:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AEE7AB81110; Thu, 8 Sep 2022 00:16:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E519C433C1; Thu, 8 Sep 2022 00:16:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d52aabe-2f0b-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662596189; bh=oYKg/saTj3ss1K5fYPVkjbSJ1tvBQgbzWpCBEPUmWkM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XMjOTW54rayu7IJn0vGAczu7fvV2REK/4nknD3jN24yPAUDm9jhdcpfGoExU3Jlec m9UOwkp7NuQVPWsY3H/scIp7Mrfm3XuUtNz04nVS5iFuT4pwztJQvkDdfg3fSO1Ecq 6L0mCSDSDarhKfFuxcR/xnx2wUs+fhRD9z0GIxsxJJ6/HhFjPYMo2WwRr6rPDyXV4M 3vVZMVo1sRbnJuGpsyFJQVHKIhPLyR77msD+g71fBve3OJWc2PZPauBw5iwm9XeSUP AQgTlVIScJ1sNqO//iHFM5DxudeDPqlrM/iTGvdD2fSFiC0sXVYekaaSwHtABQTzP9 LX1d+OYfSpSWQ== Date: Wed, 7 Sep 2022 17:16:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Penny Zheng , xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree In-Reply-To: Message-ID: References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-8-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Julien Grall wrote: > On 06/09/2022 09:59, Penny Zheng wrote: > > We expose the shared memory to the domU using the "xen,shared-memory-v1" > > reserved-memory binding. See > > Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt > > in Linux for the corresponding device tree binding. > > > > To save the cost of re-parsing shared memory device tree configuration when > > creating shared memory nodes in guest device tree, this commit adds new > > field > > "shm_mem" to store shm-info per domain. > > > > For each shared memory region, a range is exposed under > > the /reserved-memory node as a child node. Each range sub-node is > > named xen-shmem@
and has the following properties: > > - compatible: > > compatible = "xen,shared-memory-v1" > > - reg: > > the base guest physical address and size of the shared memory > > region > > - xen,id: > > a string that identifies the shared memory region. > > So technically, there is a property "xen,offset" that should be specified for > the borrowers. > > TBH, I don't quite understand what this property is used for. So it is not > quite clear why this is skipped. > > The Stefano is the author of the binding. So maybe he can explain the purpose > of the property and help to document it in the commit message why this is > ignored. It looks like it is something we introduced to handle the case where memory from the owner is shared with multiple borrowers. Each borrower would have its own offset within the region shared by the owner: https://marc.info/?l=xen-devel&m=154110446604365&w=2 The use-case is a bit of a corner case but it looks valid. If I had to do it now, I would at least mark "xen,offset" as "optional". I think we have two options here and I am happy with either one: 1) we add xen,offset = <0x0>; 2) we do *not* add xen,offset and instead send a patch to the LKML to fix Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt so that it clearly states that xen,offset is optional. I don't know if Rob would accept such a patch without changing the version in the compatible string. Given the release deadline, I would go with 1). We can always remove it once it becomes clearly optional. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 00:19:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 00:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402400.644335 (Exim 4.92) (envelope-from ) id 1oW5Ga-0000ll-2r; Thu, 08 Sep 2022 00:19:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402400.644335; Thu, 08 Sep 2022 00:19:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5GZ-0000le-Um; Thu, 08 Sep 2022 00:19:35 +0000 Received: by outflank-mailman (input) for mailman id 402400; Thu, 08 Sep 2022 00:19:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5GY-0000lW-Iq for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 00:19:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e917b786-2f0b-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 02:19:33 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8CE1761AED; Thu, 8 Sep 2022 00:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAEA7C433D7; Thu, 8 Sep 2022 00:19:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e917b786-2f0b-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662596371; bh=rewzhmo8/7EdqGR2d794R+fp5CZdHg9gpB17Qg6uW24=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=S6voAZqN8hZ7bDIZ69MmR1vk/1L/7oDoz28RHVe7afa+SOKKSmqgNpoxuhhnhj1sp gM/GDm2udntawDzu4gcQFCKuUR4PBYvKmzOAvi5xyNCTzRkCT431DllbBMQn5ulm4g HZDL68qCs1LQA7UTG00BSfpbPiSrUyqoc15IQaGypviaMss5g9rpVfvSMdO7xjUGxU 2+Fn6aRBsKhq4CVWVtAGLzsJRjSvMMHmyAKABsthMDbUVX6fjG+VCWH+jBKcRddXYV pmv8/F5po5bLpUdYn8AO0qpo53xXKbxwNHdOnD1iMS9sZPgln1+3MaGIT0/6Ik0Kzv 00UhRS8YNs1BQ== Date: Wed, 7 Sep 2022 17:19:29 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: Julien Grall , Henry Wang , Bertrand Marquis , Michal Orzel , "xen-devel@lists.xenproject.org" , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory In-Reply-To: Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 7 Sep 2022, Stefano Stabellini wrote: > On Wed, 7 Sep 2022, Julien Grall wrote: > > On 07/09/2022 14:49, Henry Wang wrote: > > > > -----Original Message----- > > > > From: Bertrand Marquis > > > > > > > > But in any case we should only add one pair here for sure, as you > > > > > > > > say > > > > the > > > > > > > > only implication is to add a couple of 0 in the worst case. > > > > > > > I agree. The only drawback is the need to modify the already > > > > > > > introduced > > > > properties > > > > > > > to be coherent. > > > > > > > > > > > > Agree, someone will need to do a pass on the whole doc which might be > > > > easier with all things in. > > > > > > > > > > > Well, not only docs. If we decide to use a single pair of #address-cells > > > > > and > > > > #size-cells, then > > > > > we need to modify the code that expects different properties e.g. > > > > xen,static-mem-{address/size}-cells. > > > > > > > > Right I forgot that some parts are already in. > > > > So we will need an extra patch to handle those. > > > > > > I think I've addressed all comments from Julien regarding my series, > > > > If it is not too late for you would you be able to resend your series without > > the 'address-cells'/'size-cells' change? This will give me the opportunity to > > have an other review today. > > > > > so I think I've got some bandwidth to do the clean-up patch tomorrow > > > after the agreement, unless someone would like to do it himself? > > > > Renaming "xen,static-mem-..." is a bit tricky because they have been defined > > in Xen 4.16. > > > > I couldn't find any support statement specific to the static memory feature. > > So it would technically fall under the "dom0less" section which is security > > supported. > > > > That said, I don't think we can consider that the static memory feature is > > even supported because, until yesterday, the code wasn't properly handling > > request to balloon in/out. So I would view this is a tech preview (Could > > someone send a patch to clarify SUPPORT.MD)? > > > > This would mean that would be that we could consider the binding unstable and > > we could do a straight renaming. That said, I can understand this may be > > undesirable. > > > > If that's the case then we would need to keep the current binding as-is. So we > > would have two options: > > 1) Provide a new compatible so #address-cells #size-cells can be used. The > > current binding can be deprecated > > 2) Leave as-is and accept the difference > > > > I don't have a strong opinion on which way to go. Whichever, it would be good > > to write down the rationale in the commit message of the "future" patch. > > > > I would not block this series on the renaming for existing property (what > > matter is the new ones are consistent with the discussion). The renaming could > > be done afterwards. I would even say post the feature freeze on Friday because > > this could be considered as a bug fix (assuming you agree as the release > > manager :)). > > I very much agree that we should be consistent. Consistency aside, I > would prefer *not* to introduce #xen,static-heap-address-cells and > #xen,static-heap-size-cells and instead reuse the regular #address-cells > and #size-cells. I think there is no reason why we shouldn't. > > I was about to write something about it a couple of days ago but then I > noticed that we had already introduced #xen,static-mem-address-cells and > #xen,static-mem-size-cells. In order to be consistent I didn't say > anything and gave my ack. > > But actually I think it is better to get rid of them all. I think we > should: > > 1) do not introduce #xen,static-heap-address-cells and > #xen,static-heap-size-cells in this series, instead rely on > #address-cells and #size-cells. Please write in the binding that the > number of address cells and size cells of xen,static-heap is determined > by the parent #address-cells and #size-cells. (It has to be the parent > because that is how #address-cells and #size-cells are defined.) > > 2) Also remove "#xen,static-mem-address-cells" and > "#xen,static-mem-size-cells", and also use #address-cells and > #size-cells for xen,static-mem as well. I think we should do that in > this release for consistency. Any volunteers? :-) I should also add that I don't think we should change the compatible string for xen,static-mem. If the feature is tech preview, maybe we can consider the device tree bindings tech preview as well? I think that would be OK. If you don't think is OK, then I suggest to: - first check "#xen,static-mem-address-cells" and "#xen,static-mem-size-cells" for compatibility - if missing, use the regular #address-cells and #size-cells This way we retain compatibility. Either way, I wouldn't change the compatible string for xen,static-mem. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 00:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 00:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402409.644346 (Exim 4.92) (envelope-from ) id 1oW5c3-0004QT-0U; Thu, 08 Sep 2022 00:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402409.644346; Thu, 08 Sep 2022 00:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5c2-0004QM-Sd; Thu, 08 Sep 2022 00:41:46 +0000 Received: by outflank-mailman (input) for mailman id 402409; Thu, 08 Sep 2022 00:41:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5c1-0004QC-BP; Thu, 08 Sep 2022 00:41:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5c1-0002nm-96; Thu, 08 Sep 2022 00:41:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5c0-0000XI-RK; Thu, 08 Sep 2022 00:41:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oW5c0-00021s-Ql; Thu, 08 Sep 2022 00:41:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u38Jc9EE0JRTEd3+4z6S4GMdP0ty37WSBa7a/TmRfTM=; b=ANvoJA6fc/aFXxDMXNBb9m2Ymp nIx/hBFHpzTCIrjsvaqw1bo2Uy9nhQ/DV64AAWzYDOhcQrD826mYya2yfiVnaxRd0vAdPHGtt6azy O8ANrHFPl+J16HmxepjWwHb+XZIqnTl4qL3NhSJMKbU4/nx2PlRiCXHlRrv8AFneNnZg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173052: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=54c8d5e432319c632dab5d4466f50876872ce6b3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 00:41:44 +0000 flight 173052 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173052/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 54c8d5e432319c632dab5d4466f50876872ce6b3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 34 days Failing since 172151 2022-08-05 02:40:28 Z 33 days 263 attempts Testing same since 173050 2022-09-07 18:12:01 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2173 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 00:53:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 00:53:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402418.644357 (Exim 4.92) (envelope-from ) id 1oW5nX-0006AF-29; Thu, 08 Sep 2022 00:53:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402418.644357; Thu, 08 Sep 2022 00:53:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5nW-0006A8-Vp; Thu, 08 Sep 2022 00:53:38 +0000 Received: by outflank-mailman (input) for mailman id 402418; Thu, 08 Sep 2022 00:53:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5nV-00069y-H1; Thu, 08 Sep 2022 00:53:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5nV-0002yr-97; Thu, 08 Sep 2022 00:53:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW5nU-0000rZ-Qs; Thu, 08 Sep 2022 00:53:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oW5nU-0005u0-QK; Thu, 08 Sep 2022 00:53:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DUgkKLwa1VZC7HcbzKDtedtLMdQvwIsPVzQRECuivUE=; b=wSwM1vCbfXTxAsMCKbmaeUbrHu h5LZDxbQohJvIxJBmI8ASEvwqXUdHdUPMrUhzzqGx9YxNGdjuhwumBDoLBwRreFAgDhY3yvteklu/ AAoSRpyamNk2NcXPl1ShD+eV3bznAYCuFxHHK1LhkRe4xbns4DEqNSwo2hbxNX3fyrkU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173044: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=172015009a6acc20357a2698800e13058ba1d3db X-Osstest-Versions-That: xen=172015009a6acc20357a2698800e13058ba1d3db From: osstest service owner Date: Thu, 08 Sep 2022 00:53:36 +0000 flight 173044 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173044/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173031 build-i386-libvirt 6 libvirt-build fail like 173031 build-arm64-libvirt 6 libvirt-build fail like 173031 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173031 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173031 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173031 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173031 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173031 build-armhf-libvirt 6 libvirt-build fail like 173031 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173031 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173031 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173031 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173031 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 172015009a6acc20357a2698800e13058ba1d3db baseline version: xen 172015009a6acc20357a2698800e13058ba1d3db Last test of basis 173044 2022-09-07 10:37:51 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 01:17:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 01:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402427.644368 (Exim 4.92) (envelope-from ) id 1oW6Aq-0007Ft-0l; Thu, 08 Sep 2022 01:17:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402427.644368; Thu, 08 Sep 2022 01:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW6Ap-0007Fm-Tp; Thu, 08 Sep 2022 01:17:43 +0000 Received: by outflank-mailman (input) for mailman id 402427; Thu, 08 Sep 2022 01:17:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW6Ao-0007Fg-5C for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 01:17:42 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00069.outbound.protection.outlook.com [40.107.0.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 077488eb-2f14-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 03:17:39 +0200 (CEST) Received: from AS9PR06CA0262.eurprd06.prod.outlook.com (2603:10a6:20b:45f::16) by DBBPR08MB5978.eurprd08.prod.outlook.com (2603:10a6:10:1f5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 01:17:31 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::9f) by AS9PR06CA0262.outlook.office365.com (2603:10a6:20b:45f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 01:17:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 01:17:30 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Thu, 08 Sep 2022 01:17:30 +0000 Received: from 82e50276bc56.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3411AA1A-3D30-41F9-AD2B-FCC8BAD0B797.1; Thu, 08 Sep 2022 01:17:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 82e50276bc56.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 01:17:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7550.eurprd08.prod.outlook.com (2603:10a6:102:24d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 01:17:22 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 01:17:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 077488eb-2f14-11ed-a016-b9edf5238543 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NcjkWpANM7i0VASWKotOKI1JZ6FfufpzD52TUbRucFsFehyZEa0k5jAFA5FWHORModfJtCBFvsec3hjD+zvzS1/l/hWcgriP7su0v7aJLGFRabDt/5mIaB9VBcdW4oJluM4hdOppGgpIFPxtZvyOTsz5FT3a88ve2v9wBa0g88NhZCduKMs5ict7w3whI5VQM28/kg0p/w94eOTg/yBUOS7nbQJB2Sjy6DpDrRINkiXpvWjC3npG3Jeqv23pObvbC5C5yKd9i0QLijjdtNGldRUtiSuYVlnE2Dzkitq/7vbqmbWZ5zzaglufoOSBaX5Z208q4eW8XfiSpRIsiuM6eg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7yDCSamfKK/lBbBhwu0TAL+0KunvxQ11SF8NZsaBHc=; b=KfveL7WtcqtqWSkkYFTeH/KtwP/tKkFsdwofcVimpwdoq98y4FHwKcbodYyFglLPjtnb7o9ImisAz+VVVa1Ltp7xbZU3UBB29K/P31sKpavwZMVLSHoOpS1wr3SbiiCZ1FXKGD1SDlx0hHyUUwWQUoDEJ/Y8gP9l1Qc7o7bzxrZv+cZ5IoJYVedRVrl9uQ7Yccm/HSIZ+TuPHQra0BObM/YFQHz2UfhcAWGS9mGchPN33Ipq68CKUGpW7k6hmIwCFMYJ5aflC92+R7zk7XqcrKvODLO+bo3Ihxj0Xlo/56se71sNpsNFwKYZ2OqWvO1iHAOoy8Cjfrb28LJWZTbfcw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X7yDCSamfKK/lBbBhwu0TAL+0KunvxQ11SF8NZsaBHc=; b=nM5YYexOcC+9TvU+xMVhFBAsN86p13OrlBgF6SARG45TW5a6MUoagSl+j62bpFyQe3s9jpLodVwYd5qgLXJxZh9mMaJz3RFc8VvVvDRYiuN1Nqpm+iIVgV/srIfnQYy65GhgWdRYbtCC4KZ9j+JJgUuR+SxPnvhoYHruuCkXNB8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWYpF1WW9Ah0s1IRDplyrScZGNmcwlwpGUZNmQts8hWV4PcEp/9a7KPpehQcbJwzw4iTSPLvRzkWjh4kw39IGTtZKeOFxsqG4lPyCuuzB2qB995Q6pT6ttsmX5p5vWWPXyqbINJkgCYw7MiVY995Ft+pk/InlfmQ2DuLoSM0pe2YzYNHSivHlecaPO46d3kdDQ6T7A/QttNT/8oUxJKjdgwRQqo8YKEToirkV5Ttnqe5J7svBZ2OazBOl2UsVQ9J/VTusiDQk75eVkSZhEhqLiq32OYgK9KEwGVWekSFmO1rzaU6zgHKy5VVV95SbKTFkCL4W4mi6pVgZzQyrcVdZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7yDCSamfKK/lBbBhwu0TAL+0KunvxQ11SF8NZsaBHc=; b=L8DwpyAQ0Cy5xbJTvrwT21xSrgvO921D+DoMtKuYHTjBCfBP/WQ/88cUEb6CXSsjKN1eAB5zNFGvS08EfndlUc2TPeqSecIMz3BwKQ8u2te46Hx6Z7eQAaiE6nvy4dKB4dEV0rM8rdZY2g02YRaO+P9FlOz14+GjGLiyz2QfkLwiqzrc/mBUIVUQXGLyMtey7uVD+3V4jlm4+KmdsCsrFxRPBG5BOeHuLvw2t8iykhfc8Lr+S3xJEfNVknATjgyUbHE2MSeMVQndXZhrruSrkvrC14RWbYnsU8zr9HA6HDmXsSQkJOoN+QbPeYRtrl1DUnvbHEcCL8p5S9hPd1YKbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X7yDCSamfKK/lBbBhwu0TAL+0KunvxQ11SF8NZsaBHc=; b=nM5YYexOcC+9TvU+xMVhFBAsN86p13OrlBgF6SARG45TW5a6MUoagSl+j62bpFyQe3s9jpLodVwYd5qgLXJxZh9mMaJz3RFc8VvVvDRYiuN1Nqpm+iIVgV/srIfnQYy65GhgWdRYbtCC4KZ9j+JJgUuR+SxPnvhoYHruuCkXNB8= From: Henry Wang To: Stefano Stabellini , Julien Grall CC: Bertrand Marquis , Michal Orzel , "xen-devel@lists.xenproject.org" , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gIAAARoAgAACMwCAAABysIAABM8AgAClgQCAABX8MA== Date: Thu, 8 Sep 2022 01:17:22 +0000 Message-ID: References: <20220907083643.20152-1-Henry.Wang@arm.com> <20220907083643.20152-3-Henry.Wang@arm.com> <968529ba-3a9d-0812-1a5f-430d467e827f@xen.org> <9a66b6df-bc37-d836-8175-3b98be07c696@amd.com> <7997786c-78ff-47df-12de-d1fe38e5624d@amd.com> <4B69D9F9-04AC-4042-AF74-F51630816208@arm.com> <759E29A4-AADA-4678-A88B-E96C5C15A462@arm.com> <39862a75-ed08-1289-0a0d-a2580f27fdf1@xen.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DBAA8B47C99EF1419D7F0355DD4EFD9F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 170f7df9-8dc7-4b90-ff0e-08da9137e6b8 x-ms-traffictypediagnostic: PAXPR08MB7550:EE_|AM7EUR03FT045:EE_|DBBPR08MB5978:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ybLqx4LfC47UmOWvhMz+b/yU4rVPIqgmGBGvHWS2xwBZjVuFfY6JKNKKGBnONIvGh92xxXKxVYU4vt3L49aJnVz2e4bKnWSBgwNcprxm7tBccPSlG0wRUOoXcCLLSq1UQkJcl0lXYGbGoHfeQEgXw0GyUH/fKxUj+APTVJsCopsWfrbrmRTJCQBetNIi1FimgZaZBij+bq/wf7qkBHWiHRZQAGvqr2MlfEToYQPaT3EeQtSHEYkU4XR5jEB5xPU7d21vTInB8JFBZU9t2OBEuLAKLom3s1qgbXIdnrygGQ8cB5WMSLJYehQY5oM+9BKgd2TwyJ/R1kprGa5L/lxAunkonDCy1NeDsp9S5s66ziGX+rCUnjV+VsWxXQlf5Yb/bPzcOKPGs4gJaUtwdTtnwG75VB0Cn87ZaOZgtGiMAydg5fiWDPID66z0PQFUaV+B314VNNaWwkizZ/Ee77Sq48DBldTJjQlx+qOJWTI12okUXLBSboCphcA0T4dhVWlPOM2JjxQWH531VEDOIhnEGFtHYmYp08KEUgLKxGc4YKyc0KOeQ2E50mjtEeop2qS2tX22XuyeVUYuAG4Pw3VhDdVhPc9ERWC4TyoI4XyfqDKyFXEWocMWRAAEBKFAGxSG0JOBzFOJEtlp+zZNdr3eDKUtqKtyxMdlHEvB9hNviL0zB3+qljl648Rkh56YDhQQnwS+i1nsxU7E4dDG0m/I0yMEX+532JpbLQTPFNl5NR6MMuPN00ZFnGfpWmqYnnP0HhNnPmffwkGSYrpL4JoPkg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(110136005)(122000001)(86362001)(5660300002)(38070700005)(316002)(54906003)(66476007)(76116006)(38100700002)(66946007)(66556008)(2906002)(4326008)(66446008)(64756008)(52536014)(8676002)(186003)(71200400001)(55016003)(478600001)(8936002)(83380400001)(41300700001)(33656002)(7696005)(6506007)(9686003)(26005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7550 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3eafa90f-0d6c-4681-a8cd-08da9137e1c9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5IIuiLBTsLW7YWTYStd8lKyP99Jb0mU3JTnMMxowwtqrrZnXfDjLuOOCZLxmcH8oZl1FxIqxukGsgxPh/etZKaAnP614XiVtdg5n/N9SSWOnNdzscenuwzCB6F1nHGNQu/IF5grenmGekWpBrS7egEl7kQNk5x+ZrVqXV021/nIJ6Eyxkq2EoWZDCwBqU1y/SJcyZr17LUiy5Y/71P8BHsLz3Hw9mxI15kaR6HaPziENyIm1NaupKj/IOzs82uUnUqx4grb7jg/PrDRP1ljzHVfbQZ18ZrTh2/OPSOdRPH2iKx4YcEIUGQMi+2bOzUCK1xOucGTeGL805lnT9MRB9AlgKdX1h9UbFgJvb2dSTSeiT2YaNmeQ/mWX1rppbbItj19na9ivgGNzH59QZqOROg+JYdENOKbt5dSdcdA1RQIDBqo24WGkRvAP6va4PWZiJ8aIN35ZvM+BTkXuM/Al3P8E1N5+cvsIA8ijlNSaPWWekCX65BRklcLnC1Z2yM0sNP7TwwfT6MhSkmx7hsdgaMF/ufc8aZVRmybfsuCDF2fza80tb+8zh2Mu25KIfnZ1EiZrVGmSoSO0+p/I3rQiqepUu1LtTSX9sbCmvGB+CuFRFRC01b2E8+vpIkwOPf53Hgjc3eUTJOPUx6qdI7c1aDeIHVfDzX5jNXTDoV6+cYvH4Qq8FkV7ludf/lnm7CPaM2jVB2cyTmD7HRuML6jRoFupMCpOP+r91OjRIlj21BSm5t/FGyyuE0PI+hxl0ZMFMau/wMeO3Q/T6RETmEtcsA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(40470700004)(46966006)(36840700001)(5660300002)(40460700003)(7696005)(6506007)(478600001)(8676002)(4326008)(70206006)(86362001)(70586007)(8936002)(41300700001)(52536014)(33656002)(40480700001)(36860700001)(55016003)(83380400001)(47076005)(186003)(336012)(81166007)(356005)(2906002)(26005)(9686003)(82310400005)(82740400003)(316002)(110136005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 01:17:30.5990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 170f7df9-8dc7-4b90-ff0e-08da9137e6b8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5978 Hi Stefano, > -----Original Message----- > From: Stefano Stabellini > > I would not block this series on the renaming for existing property (wh= at > > matter is the new ones are consistent with the discussion). The renamin= g > could > > be done afterwards. I would even say post the feature freeze on Friday > because > > this could be considered as a bug fix (assuming you agree as the releas= e > > manager :)). >=20 > I very much agree that we should be consistent. Consistency aside, I > would prefer *not* to introduce #xen,static-heap-address-cells and > #xen,static-heap-size-cells and instead reuse the regular #address-cells > and #size-cells. I think there is no reason why we shouldn't. >=20 > I was about to write something about it a couple of days ago but then I > noticed that we had already introduced #xen,static-mem-address-cells and > #xen,static-mem-size-cells. In order to be consistent I didn't say > anything and gave my ack. >=20 > But actually I think it is better to get rid of them all. I think we > should: >=20 > 1) do not introduce #xen,static-heap-address-cells and > #xen,static-heap-size-cells in this series, instead rely on > #address-cells and #size-cells. Please write in the binding that the > number of address cells and size cells of xen,static-heap is determined > by the parent #address-cells and #size-cells. (It has to be the parent > because that is how #address-cells and #size-cells are defined.) Ack, I will do in v5, also drop your previous ack so you can take a look again.=20 >=20 > 2) Also remove "#xen,static-mem-address-cells" and > "#xen,static-mem-size-cells", and also use #address-cells and > #size-cells for xen,static-mem as well. I think we should do that in > this release for consistency. Any volunteers? :-) I will add a new patch in the end of this series for static-mem cleanup. This can be merged later as a bug fix according to the discussion with Julien. Kind regards, Henry >=20 > It is not going to break anything because, not only static-mem is tech > preview, but also it is very likely that if someone was using > #xen,static-heap-address-cells it would be setting it to the same value > as #address-cells. So in the vast majority of cases it would continue to > work as expected (not that we couldn't change it anyway, given that it > is a tech preview.) >=20 > So I am aligned with Julien on this. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 01:32:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 01:32:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402436.644379 (Exim 4.92) (envelope-from ) id 1oW6Oz-0001d3-Fh; Thu, 08 Sep 2022 01:32:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402436.644379; Thu, 08 Sep 2022 01:32:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW6Oz-0001cw-As; Thu, 08 Sep 2022 01:32:21 +0000 Received: by outflank-mailman (input) for mailman id 402436; Thu, 08 Sep 2022 01:32:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW6Oy-0001cq-9h for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 01:32:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1365eb92-2f16-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 03:32:18 +0200 (CEST) Received: from AS9PR06CA0276.eurprd06.prod.outlook.com (2603:10a6:20b:45a::34) by AS4PR08MB7529.eurprd08.prod.outlook.com (2603:10a6:20b:4f8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Thu, 8 Sep 2022 01:32:16 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::73) by AS9PR06CA0276.outlook.office365.com (2603:10a6:20b:45a::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 01:32:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 01:32:15 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Thu, 08 Sep 2022 01:32:15 +0000 Received: from a18f730bb587.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 87CF164D-44D5-4728-9187-AC7461EFC26F.1; Thu, 08 Sep 2022 01:32:10 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a18f730bb587.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 01:32:10 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS4PR08MB8243.eurprd08.prod.outlook.com (2603:10a6:20b:51f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 8 Sep 2022 01:32:08 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 01:32:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1365eb92-2f16-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XFljItzxVPzk7ssOLz90rBRSB6J9aPEcsMnaKecA+s4XRYkChj55bIGL4WSLMZvPvuWVxXOJ4qRQq7ZnhTOGGNc0WRdphrhLrnTMe5ZZny3MAli3hQIKmhSJevNwehto53LzEXOE3yp/Z2DC4WKZAKlWNHroJPHchrJo8EHJ4VWxyG8y7iCume0stcP4Ra4YEmpRZw0nk3AXOToaHO5oHQDTn8DMROvQiGWApuG9AV7zV1fSrPymhO7aXScEgT9WnpSMdyKAoJmt963+ImNc5MgobQPfKd3bNmbugQ7i8CTQgWwuVBU22xke5DAq3BYC7qxWq7EjYz99Btzb391Uqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IheUAavtjkvnKbrBSesn47mZoT1v2VxfZ9V90jdMYiw=; b=NFP08MeljbyRiHQ/mxlcT0nCHt7vkGjE8I/KjCOSJ0xeWTbWFjIJPMgL3fF871t6hvcN8KNPhHAUKx0Xso/0uUaHfF6/CJvJi9Z86OmVYYzGjnfAFLknbr5udlz9pQ+eBICW/rsJYWKbXGQtAoABe30lBPq9pg6wNP4eJn8VmK2a5hfyNZdbWw3riyAtJKMJsjs1XZhVC5WgWvlo3ue5yW8frY7+3kN9EH7JLOvDg1lT3KsGcO+fSIw7SggZXf2u0XBUaj8oDlEA071/fQ/on2BaXM1ezsBaNkeE0gEN9/1cLjNkYV67OMtkWUkIVVMbGWY3JwofgdRMdnIWsT3h0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IheUAavtjkvnKbrBSesn47mZoT1v2VxfZ9V90jdMYiw=; b=EBINekjyqKPcP8FGb5nJxmxM0zx+bKYHZz0soBkP8Lb2UqhWyCCHV+kZxBzF4lQ2jmLuVv31aZk1ZNU+XUzPkFuLWz+v3YaYJ+MFWWkCG18ZccOIKbDl7nTJioav/k2aeDLh3CpB9IOiarf7Ssm+whp1fph0SuK0Ps+vPbP5bJA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IK8cxVeZ5a5Q8veCDJpZyj+zKv/7YnbSt8M6hBMROCQyNrcRshhVe8/D1wnECTonhhHiK+J18BW84qUXT4zAkACD6bfArKkr/miKskhTobya3Da3DZ/2wloFILmMNzWjXumzUJ+7SpXXfWrIA+WTrnifC5X2+FoSng1s+E//blw7YSxPc+uB/p5K2Uh5WVdRn70MPNupuUI32l4hICxJwyoqrh/R8nceD/962xmjVn0I3EOpluA/jG/wHkiMKzcW9zUBQs4ZKVJqZwclhySfIDwj2/ZAvrA/SvCeyva3YzOICWrP+aMxpuqg3XQZgee5ZNbHZzdgj7lGZnDznF9qqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IheUAavtjkvnKbrBSesn47mZoT1v2VxfZ9V90jdMYiw=; b=Z5f338WzuML0PnYwSToG9fvviY24FT0xHiin3Z2lXm7KBB7TwuIgrNsSy5fk/YDLOuYOKA3ikt0pRBX8Vioy8nScZY8lzkBfv0IvJ8lcqcRag+D03vXPkNRLCD/LOJ9i8MgJM3yb35wC6B2e+SXi331Kprj8Ab8M/g/5lBa4ahJ/suwDIqbB1rlt3ddl0Fj5gIB5C/D34sUdKN8ajLlK8nxvqsW/y8vOJ11n5b0a1Eayq5Bj+qCVdUzpD2sn6iXW+qt9pMmbRJw1DJhswZVfW45ufGNCmlJ+9vKr2R/MeVoo0fTVPC6KV/pX7G/+lCzhvtYHfuGnuhQ3TME+WzsyJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IheUAavtjkvnKbrBSesn47mZoT1v2VxfZ9V90jdMYiw=; b=EBINekjyqKPcP8FGb5nJxmxM0zx+bKYHZz0soBkP8Lb2UqhWyCCHV+kZxBzF4lQ2jmLuVv31aZk1ZNU+XUzPkFuLWz+v3YaYJ+MFWWkCG18ZccOIKbDl7nTJioav/k2aeDLh3CpB9IOiarf7Ssm+whp1fph0SuK0Ps+vPbP5bJA= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v4 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v4 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwsc8IB/BGoiaOECLtnnc9tK+sa3UGc0AgACl6FA= Date: Thu, 8 Sep 2022 01:32:08 +0000 Message-ID: References: <20220907143532.15397-1-Henry.Wang@arm.com> <20220907143532.15397-3-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6FCF1E38E8D46E4BBCD7189E9DFF92AE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 444d7759-8744-40d3-c68a-08da9139f639 x-ms-traffictypediagnostic: AS4PR08MB8243:EE_|AM7EUR03FT045:EE_|AS4PR08MB7529:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QWYwEHIb+bjJbmyIaELXr2wa0k4LFu1HM0PeebFTZK1JaxgvK9GShatuLEX1+pc3mMOWnbDSUOdc4ypBmR6k1RPelGKJtZ9dh/szCbNY/VDKCBVPibo6Sseh/2D7a/mJiKhSFRYFSI8DyY4jvOnV7CTWaWazb6xPVZiqB42n6HtORnryiajionA0s3XgwJmQXFAtlFgJhr1DttPoed+X4Ku2PsE5xQz2x1NanRgPY0heKOH5DYk1d03NA5udM4zUegz8LXhWdIl5Bp9luWxj156Ajw2gCOTRvydZRXJU64HqBgdNav/u3BDvqFJOL5PrhlJ1gCx7ov2jPKQ6/o9LTl9Qj6Oakoq3M54o+wri88JenkFEdsnbokNfQmPxx0jaUPUXivXsSLbSeFtFe5BBJM5pW4Y4RDhTIKx0Aiu3r3PcRWqLdRQnx7DNjTNa5F4YaJrxVLw0Ph4Sy5iWIzdI7swQSnIeRYeG+XUPoy3a3eaJttQyLM6+D1DjFRs0xAAxpFLgV9bsZiVT3JzFLWRAQqZ7oV6HsoN7fotbw0APXfwaExoiYt8B06e1LyaPq5CWFQNHxMeAcWoEYYz+YEaB9CXipfFjrv8gjOFHyTxDOO4KHLcOTcPcBaVj88HryDHzflcmjrOB4x0mZlz7m0JO5UeWyK9BiFTLgl/qL/IIT/1ApT+X4wKuff2/SreIdR/8epTewhQGlNynIbr9yxWyNJr/nwymecPB1SAzyKhpnHlS4bUNgMEltcP1V8kmWG6ZRj3wyD8v2KLjSDzSFefYlg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(136003)(396003)(376002)(122000001)(86362001)(33656002)(7696005)(6506007)(9686003)(38100700002)(83380400001)(2906002)(5660300002)(26005)(41300700001)(52536014)(8936002)(64756008)(38070700005)(8676002)(55016003)(66556008)(66946007)(76116006)(4326008)(71200400001)(66476007)(478600001)(66446008)(186003)(316002)(54906003)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8243 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 74df44f3-6bc1-4694-3755-08da9139f1bc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XaUKJ8FSUrZ4QrS6TXxgUX7MIW3yQiIwCq8xLPrdbMAXfFkrYtlJEGxY6n5yK9fe+jymwn0hSUZ9kaz7j9+sHao+4vm8SyKR+b8O7HBrLzDCR6AX4qt5IG5+gBR8KcJ0nYR+qrry6f6lNHRURgSGvHij/4F9hiKxK/5TC358T+OvQi+H9Du6wvHJf9UNykY63iF13ktyLHMd1Vec9foBLQcN9p4oEz0WxdUs/0RVeEmlLADHsZoVmpDpyb8rjmIPN/2GCJr38H4RenZPopkXCfYywpw/RtG5k/1SxJtNAmlE+da55G/A4xq2X3ScxJRULtJbnEBp5fkdzpRhrhTa5ybDD8e4fDHKEcSxj90s/aZcFzVY85IZSyWj2LAozViOFJmdi3/G6w2LgRMHmp6otLNzTB51Qse16Vt/9gsljviHRJSUOlf2jj0gggGsu9fY1cXVc/kA9T1piyvqzhC7VD1cgMskw1cD3XXb3FHkNdYTXrxCvAZcGSrgt5rrlrGfJiLWE24/17lJeq4zqwpD2Ku85PF89a7AtpiyP/TsAKmYIiwwcK4MP/m6RB3/rfMPLpJPJaJJ4Niaag+TXf3VpyUGNVagkRTh5Xzbg5G3X7xxNE2s7CGzcvI3ODb2Qw+3upWNI3xuPKw6l+kBsZnF5CtYka+N76noTKp0s5A5QCpsSK1s7H3jc31VoEN+2z9mKF/7dZFt2n9IQdCxtJ50k2Ni/HDDHtqAHQd7R4pWoOiVmtY+NfxkSrJWiT4pdswIhrrilsPhXhdAxS6Df3scEw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39860400002)(46966006)(36840700001)(40470700004)(82740400003)(40480700001)(55016003)(82310400005)(41300700001)(81166007)(316002)(356005)(54906003)(110136005)(36860700001)(6506007)(4326008)(7696005)(478600001)(83380400001)(70206006)(52536014)(33656002)(8676002)(26005)(70586007)(47076005)(8936002)(86362001)(186003)(40460700003)(2906002)(336012)(9686003)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 01:32:15.6022 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 444d7759-8744-40d3-c68a-08da9139f639 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7529 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4gKy0gI3hlbixzdGF0aWMtaGVhcC1hZGRyZXNz LWNlbGxzIGFuZCAjeGVuLHN0YXRpYy1oZWFwLXNpemUtY2VsbHMNCj4gPiArDQo+ID4gKyAgICBT cGVjaWZ5IHRoZSBudW1iZXIgb2YgY2VsbHMgdXNlZCBmb3IgdGhlIGFkZHJlc3MgYW5kIHNpemUg b2YgdGhlDQo+ID4gKyAgICAieGVuLHN0YXRpYy1oZWFwIiBwcm9wZXJ0eSB1bmRlciAiY2hvc2Vu Ii4NCj4gDQo+IExvZ2dpbmcgaGVyZSBqdXN0IGJlY2F1c2UgaXQgaXMgZWFzaWVyIHRvIGtlZXAg dHJhY2sgb2Ygb3BlbiBxdWVzdGlvbnMNCj4gOikuIEZvciB0aGUgZnV0dXJlLCBJIHdvdWxkIHN1 Z2dlc3QgdG8gbGlzdCB0aGVtIGFmdGVyIC0tLSBzbyB0aGV5IGRvbid0DQo+IGdldCBsb3N0Lg0K PiANCj4gV2UgbmVlZCB0byBhZ3JlZSBvbiB0aGUgbmFtaW5nIHNjaGVtZSBiZWZvcmUgdGhpcyBn ZXRzIGNvbW1pdHRlZC4NCg0KSSB0aGluayB3ZSBhcmUgYWdyZWVkIG9uICNhZGRyZXNzLWNlbGxz IGFuZCAjc2l6ZS1jZWxscy4gU28gSSB3aWxsIHNlbmQNCmEgdjUgd2l0aCB0aGVzZSBjaGFuZ2Vk Lg0KDQo+IA0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAu aA0KPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gaW5kZXggNTgxNWNj ZjhjNS4uMzE2MTBjY2Q2NSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9h c20vc2V0dXAuaA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ ID4gQEAgLTIyLDExICsyMiwzMSBAQCB0eXBlZGVmIGVudW0gew0KPiA+ICAgICAgIEJPT1RNT0Rf VU5LTk9XTg0KPiA+ICAgfSAgYm9vdG1vZHVsZV9raW5kOw0KPiA+DQo+ID4gK2VudW0gbWVtYmFu a190eXBlIHsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBUaGUgTUVNQkFOS19ERUZBVUxUIHR5 cGUgcmVmZXJzIHRvIGVpdGhlciByZXNlcnZlZCBtZW1vcnkgZm9yDQo+IHRoZQ0KPiA+ICsgICAg ICogZGV2aWNlL2Zpcm13YXJlICh3aGVuIHRoZSBiYW5rIGlzIGluICdyZXNlcnZlZF9tZW0nKSBv ciBhbnkgUkFNDQo+ICh3aGVuDQo+ID4gKyAgICAgKiB0aGUgYmFuayBpcyBpbiAnbWVtJy4NCj4g DQo+IFR5cG86IE1pc3NpbmcgJyknDQo+IA0KPiBUaGlzIGNhbiBiZSB1cGRhdGVkIG9uIGNvbW1p dCBpZiB3ZSBkZWNpZGUgdG8ga2VlcCB0aGUgY3VycmVudCBuYW1pbmcNCj4gc2NoZW1lLg0KDQpE b24ndCBib3RoZXIsIEkgd2lsbCBkbyBpdCBhcyB0aGlzIHBhdGNoIG5lZWQgYSByZXNwaW4gYW55 d2F5Li4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0N Cj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 08 01:34:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 01:34:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402444.644390 (Exim 4.92) (envelope-from ) id 1oW6Qj-0002D7-Tp; Thu, 08 Sep 2022 01:34:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402444.644390; Thu, 08 Sep 2022 01:34:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW6Qj-0002D0-Oa; Thu, 08 Sep 2022 01:34:09 +0000 Received: by outflank-mailman (input) for mailman id 402444; Thu, 08 Sep 2022 01:34:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW6Qi-0002Cu-Cw for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 01:34:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 545aa926-2f16-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 03:34:07 +0200 (CEST) Received: from AS9PR06CA0051.eurprd06.prod.outlook.com (2603:10a6:20b:463::22) by PAXPR08MB6477.eurprd08.prod.outlook.com (2603:10a6:102:12d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 8 Sep 2022 01:34:05 +0000 Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:463:cafe::fb) by AS9PR06CA0051.outlook.office365.com (2603:10a6:20b:463::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 01:34:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 01:34:04 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 08 Sep 2022 01:34:04 +0000 Received: from 5bca3e14fa44.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6CDFACFD-AED6-4F81-AC0B-B1BBEA8278A7.1; Thu, 08 Sep 2022 01:33:58 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5bca3e14fa44.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 01:33:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS4PR08MB8243.eurprd08.prod.outlook.com (2603:10a6:20b:51f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 8 Sep 2022 01:33:57 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 01:33:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 545aa926-2f16-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZZVzNj/o06ueKTI2pW7ZfZJGmHpqrIBH/LxRM9ktAlndkRgOAOho9/RbPC6ndOh4Mt3Mh5jfmQ8SEo3jIvEP96i0iX9Y3q0dA+9AvdG0aEZzUK6vj/X/u+eD+A0lz8mYwDxfKZnRlZ+3uCkM26JZo+8RS5uRfqXilSVZt+y2xMhW3gGAmXj3lAah3nsCotXI/Q+GBUrPd/0clI2dDandYle+lmHxIhzECNA7tZW4fp/WcJPZwhajFggUUKfvgHX0pNBqI5EfGHfEBREBY02ffPfOI7XJkNJO7CtovYK8TaMg1a7Bal/KiHAnaKbHJgLt7wEK4nyvlacocQcq+mmUMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GenzEgHIZOjwRhfyWebMvQmUv1NVzHQDyNaUWymoNVc=; b=dhczJZneTjkF7HUMNN+q238AIOT7FESoFZnuOSl0Tom1pI5HRV6dFJKN/p6kljHtd7MVkpsovEwfylVS+IK+HzmMaAofpYhvF0SLPGcXodrtjV/JByw48+WcHnx3+Tg1EEHb0RqU4tdabijUpNEpF0dLf4eimW5x79jh2pTf94yPA3TKXHXeZ031S4ya4/t4EnhbVTXze/6W6LhiF5BfYdhXq9+Eba9D1Rn7Qe7XsqY6YFEI+sFUE4rTkDkp3R+QtUSPWnswD+B0WZTlvwALA3/DdSBJMftLJV3Royy6y6HGOsxFh67L81GvoOl6xsqq03Xkk+fVBBp/o6pJgUZsNQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GenzEgHIZOjwRhfyWebMvQmUv1NVzHQDyNaUWymoNVc=; b=DFlsJAzEZQMCZtOAxoXyET1RItfAV1isKVofPRApz9X35+oxj9M+Xe+0i8EhbNBpYmPRCIe54BfJctbxfq+2aKDDMvCf8Z7NVlMExOaD62ug5gknvrgyx5zc5UXF4qPx7MzLPwa55vgh3rtI5YnQv9KxZrzn2OkhYwVsjb+IIwk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G7X1PMuOWLBtqDYEF3ZU68Pv2U0f9/Buo7QLCX0qOAd/xueo4xTISJCXXd/ahE5sKDq1UqyllVOmjlvFkv776Lp58MErcf72OgxGme/pUevTUp4bf2y44HjduKGU0hvu8GlC9Gc3InxOTsPyc3grrgrvWoPE6KpohrqOxtARfGUMqFIR2u2dPdEG4zgQZcxCMl44CIZe4c0Ztbzik42LfC/wmPiq5zcmqOGuJgJIUiz/wI3X6L7hTFHRm4zJwDNzEKm8DPrkvGZgISaTlMGZeKyB4FpQHaQthu7ze6s86ctSQML+Mm4i85MdFSFRjsl2KYkuX1S15e6q7dBUdOUD6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GenzEgHIZOjwRhfyWebMvQmUv1NVzHQDyNaUWymoNVc=; b=FPxcWNIIiu5jrjYRONG09wYkjn8sl+SHV5/YrjbkH7zkStRRTm4X3xsT6gCH1rmPPwqqyrB5po2lBBRjV6SePTsJh4lzkPKJ30yXFV7WIxr25mVUJ+iK0vqmYeO7KAkl6YBThWrHvT4j74+h/HtSvkU7ooN9Mv7ZBcDUl8gPa2cud6Rhg98TsleSa9nV3YRaeK3N6jZGCqUKOL+lS1RDhvpz+5LxXgHeAkXgu4YKeMoqGGBQz3AyYz49NXa2fpwbPPFEaH5ooe1enJtalTsQYByMZniN0gBs6Bjcf4U0KuGKyyiQT6xBqy1kJ2F+cmzaA/elGUzy8vv/Ym/ArlswGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GenzEgHIZOjwRhfyWebMvQmUv1NVzHQDyNaUWymoNVc=; b=DFlsJAzEZQMCZtOAxoXyET1RItfAV1isKVofPRApz9X35+oxj9M+Xe+0i8EhbNBpYmPRCIe54BfJctbxfq+2aKDDMvCf8Z7NVlMExOaD62ug5gknvrgyx5zc5UXF4qPx7MzLPwa55vgh3rtI5YnQv9KxZrzn2OkhYwVsjb+IIwk= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Topic: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Thread-Index: AQHYwsc6S8K4gfOKFEuFG4G9iA/zZq3UGkiAgACmHJA= Date: Thu, 8 Sep 2022 01:33:56 +0000 Message-ID: References: <20220907143532.15397-1-Henry.Wang@arm.com> <20220907143532.15397-4-Henry.Wang@arm.com> <230cdac8-e09d-8581-1e87-012a69601091@xen.org> In-Reply-To: <230cdac8-e09d-8581-1e87-012a69601091@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CAB72FCC162B934B9FD65B305050D7D4.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 95c97ec4-0a54-4dfd-304b-08da913a3757 x-ms-traffictypediagnostic: AS4PR08MB8243:EE_|AM7EUR03FT059:EE_|PAXPR08MB6477:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qbdeaU9CBtSPVE93+bnqGoImvzddWIY9r7rZYMnkBZFTtU0IRgDnvurTihHyKQyniLqI4BU2uWKN4YTrb54RjmcqODlAmwWnLZFRgZeeMxpjF9Ac8oKnE+B64POXWQbDanU9RvPfMRYfJoChH+9jXzOl5/WF2UxHZ1X2zY4sOEsJWh2Q/nS4/TsSOZ0n0KaF7eiP/qyD12XxHpMWjPU4054eFRRZlIlbQSIjKoVDRtAYEsRGzBq8uDSttMeVyiH1nPFKsUUaD5+BrG9CvwIIHzg3Co6mfQIOl0acya064yg26prBPu4wyfUF1t3UJbM9bYhAMSedUVW1/XQjEHIymPp7vg5mLPhn6vi/k5RJ/gSLr95YGL6RBNXVvP2xeH5RGh/eO3cyDQEAnVqQQyw4CsiV/VWLjM2N358gIDCDBE1Gquj1vkvBK4mwjQuHQWW7MpbaewSSl7NQ5XuykjGf9+dRW5lBPSzAY1bkRb+MsMmF20yLSCZDd/mbRKIrv37pHOgDsNBhFfc9LY5hYsEBjsfxHQ23sx43p74O/KFMNZPe77Kl2c+99bBHkUQcESz4tZPa5mgqH+KUwjaHuoWgLxpLJ6JD82qVfpncBI0dvJgKoC2SPGnq3GyF72A3rVrqvJq47iU/fYxIWciAKCxFrr47hByPEVckBqqhT4gPu5y4qUr04d3t2K+BB65zzMMlnu0yNPhazhTNHtaVxI7rJFMbEQGp2jh1swDOgB9jv+ej3Yzz03n3UScTgLHAmV5mDIYsD0j1BaucOUVEkTommA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(71200400001)(4326008)(66476007)(38070700005)(64756008)(66946007)(76116006)(55016003)(8676002)(66556008)(54906003)(110136005)(66446008)(478600001)(186003)(316002)(7696005)(38100700002)(83380400001)(9686003)(6506007)(4744005)(122000001)(33656002)(86362001)(26005)(8936002)(41300700001)(52536014)(2906002)(53546011)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8243 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 88413a67-59fa-44c9-5a35-08da913a32a4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bWjuQouGsX9TECGbL8MV6T4R2eHSkJ4neZH0PgtH9xj8ImKqnhWyX/E/cU1Mie9ycgWgRx/v7TndECu7A4eF2XFFLBVbunT9r4yRAeyW12JdLuWGQHV7teinTdwLuh6cpyyj7BRYDaia24yTiQcXkl2djLeaYVl3YDl0q/OwR19y0qR7yAQMPhKngH117v4nRLbPxQik5n/zelGU2cjOc3UvwouHrZOjqtdNGmmIR8HQWubGHmFThTY6Odhu7mdX+8zTqiQ2muzMo2+OHLdRwmJ6opwEKfnqxtNWI8Bw5K9xKMJFuEXk1wuc65DSZFVUQqiXdefND+6RYrfszA6ud2PqhxX4jFYWoKwOC2LwE1YrqOmdCqTozmlsQeE4OljPrQZkO2NVXW04kRTvXZkTykpBMMQgbOWa+INjwsD3Hpr3YjsO3/XJ3HqqyXRVKg2UBXG2wANsBBKkctm8nSq8axIUMYr27DBoMC14UquJVYM+QFchz5ktvK/c045dz1PuDvnt0K/DdfUEUbD4Ds+pO5fDqm6PxnRXz7nR2ytcmLwoOIMg/5y4NzLrWiGKJrcBHiWD9Pq99Hzy+V6K4SlRP+9tkvaUocngAr6N8aNXrLbJpj1YiMCRKv6G8ZfVcGwbj86v7RlKmE0OLYYCBh5OpVmo6dq6tiiW4xPvOL3TWLvJ1cCNptKP8CfZxkG2Y8mu8DAsEXbzxAtVhMj7rjmFB313Yw9u+8DoEvU7wH72b1y2/p+4X7LVDCH+QYeueOz3VWTyupvs4E0xjVnHXyG0AA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(346002)(136003)(36840700001)(40470700004)(46966006)(70586007)(8676002)(4326008)(83380400001)(33656002)(70206006)(107886003)(41300700001)(82310400005)(110136005)(316002)(54906003)(186003)(9686003)(86362001)(47076005)(26005)(336012)(40480700001)(5660300002)(356005)(36860700001)(55016003)(4744005)(2906002)(81166007)(53546011)(40460700003)(6506007)(8936002)(7696005)(82740400003)(478600001)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 01:34:04.8469 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95c97ec4-0a54-4dfd-304b-08da913a3757 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6477 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjQgMy80XSB4 ZW4vYXJtOiBtbTogUmVuYW1lIHhlbmhlYXBfKiB2YXJpYWJsZSB0bw0KPiBkaXJlY3RtYXBfKg0K PiANCj4gSGkgSGVucnksDQo+IA0KPiBPbiAwNy8wOS8yMDIyIDE1OjM1LCBIZW5yeSBXYW5nIHdy b3RlOg0KPiA+IFdpdGggdGhlIHN0YXRpYyBoZWFwIHNldHVwLCBrZWVwIHVzaW5nIHhlbmhlYXBf KiBpbiB0aGUgZnVuY3Rpb24NCj4gPiBzZXR1cF94ZW5oZWFwX21hcHBpbmdzKCkgd2lsbCBtYWtl IHRoZSBjb2RlIGNvbmZ1c2luZyB0byByZWFkLA0KPiA+IGJlY2F1c2Ugd2UgYWx3YXlzIG5lZWQg dG8gbWFwIHRoZSBmdWxsIFJBTSBvbiBBcm02NC4gVGhlcmVmb3JlLA0KPiA+IHJlbmFtaW5nIGFs bCAieGVuaGVhcF8qIiB2YXJpYWJsZXMgdG8gImRpcmVjdG1hcF8qIiB0byBtYWtlIGNsZWFyDQo+ ID4gdGhlIGFyZWEgaXMgdXNlZCB0byBhY2Nlc3MgdGhlIFJBTSBlYXNpbHkuDQo+IA0KPiBZb3Ug YXJlIGFsc28gcmVuYW1pbmcgYSBmdW5jdGlvbi4gU28gSSB0aGluayBpdCBzaG91bGQgYmUgY2xh cmlmaWVkIGluDQo+IHRoZSBjb21taXQgbWVzc2FnZS4NCg0KT29wcywgdGhhbmtzIGZvciB0aGUg Y2FyZWZ1bCByZXZpZXcuDQoNCj4gDQo+IFdpdGggdGhhdDoNCj4gDQo+IEFja2VkLWJ5OiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KDQpUaGFua3MsIEkgd2lsbCB0YWtlIHRoaXMg dGFnIHdpdGggYWJvdmUgZml4ZWQgaW4gdjUuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4g DQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Thu Sep 08 03:07:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 03:07:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402451.644401 (Exim 4.92) (envelope-from ) id 1oW7st-0004if-Ik; Thu, 08 Sep 2022 03:07:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402451.644401; Thu, 08 Sep 2022 03:07:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7st-0004iY-FU; Thu, 08 Sep 2022 03:07:19 +0000 Received: by outflank-mailman (input) for mailman id 402451; Thu, 08 Sep 2022 03:07:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7ss-0004iO-Cd; Thu, 08 Sep 2022 03:07:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7ss-00046B-7X; Thu, 08 Sep 2022 03:07:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7sr-0005oC-LV; Thu, 08 Sep 2022 03:07:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oW7sr-0006PS-Kg; Thu, 08 Sep 2022 03:07:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rh/cQMX6dwCrFpFi6v/26vVg6ivYiiFw5WRfnAgdkig=; b=KpfzHoIT8E/Oyv0gZWwzgBGahG 2BMR1QT+29kO72snGPSczEp6mpSrwLWrACdFDGrfr7m27i7tZ7dnJcVM94Y7pctzCESHlUZ/BH8Lh 6/qw+zS8edvWmsrYpe9ILdpqsvXVu1KGpOuoh9YaOIXgM2ECy0FNXddf6k9OZWaNydlA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173046: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-xl-arndale:debian-install:fail:heisenbug linux-linus:test-armhf-armhf-xl:debian-install:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0066f1b0e27556381402db3ff31f85d2a2265858 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 08 Sep 2022 03:07:17 +0000 flight 173046 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173046/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 12 debian-install fail pass in 173034 test-armhf-armhf-xl 12 debian-install fail pass in 173034 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173034 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173034 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 173034 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 173034 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0066f1b0e27556381402db3ff31f85d2a2265858 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 34 days Failing since 172152 2022-08-05 04:01:26 Z 33 days 77 attempts Testing same since 173034 2022-09-07 03:00:08 Z 1 days 2 attempts ------------------------------------------------------------ 1702 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175131 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 03:11:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 03:11:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402462.644412 (Exim 4.92) (envelope-from ) id 1oW7x5-0006Ou-8e; Thu, 08 Sep 2022 03:11:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402462.644412; Thu, 08 Sep 2022 03:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7x5-0006On-5y; Thu, 08 Sep 2022 03:11:39 +0000 Received: by outflank-mailman (input) for mailman id 402462; Thu, 08 Sep 2022 03:11:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7x3-0006OZ-CA; Thu, 08 Sep 2022 03:11:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7x3-0004Ae-9M; Thu, 08 Sep 2022 03:11:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW7x2-00062w-Og; Thu, 08 Sep 2022 03:11:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oW7x2-0005Hf-OG; Thu, 08 Sep 2022 03:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MeLCI8O457bTnQdJYO+hUAXzJX9L4YKgKhdGMVMJvCs=; b=Zqs+qPT5VeBsktg4SrKwE02OJn yF2hIOAfqildup9QuQF7Mws0bLNpk8Z2veqsqloXhsSbBrqyKkIuET2xyA1fRVQh6ILflksII27rH jZDJfWIZsePE3C8Jslj6T2lWPyFin6JlkDHzPs7VXA8lFuA2IC+vYZ3f+tLftEpYRjA8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173048: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-vhd::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Thu, 08 Sep 2022 03:11:36 +0000 flight 173048 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173048/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd broken build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-pvops 6 kernel-build fail in 173037 REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken pass in 173037 test-amd64-i386-qemuu-rhel6hvm-intel 8 xen-boot fail pass in 173037 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 173037 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173037 like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail in 173037 like 172128 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173037 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173037 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173037 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173037 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 35 days Failing since 172384 2022-08-11 11:13:58 Z 27 days 59 attempts Testing same since 173008 2022-09-05 15:47:43 Z 2 days 5 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd broken test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-vhd broken broken-step test-armhf-armhf-xl-vhd host-install(5) Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 03:16:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 03:16:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402471.644423 (Exim 4.92) (envelope-from ) id 1oW81i-00072o-TF; Thu, 08 Sep 2022 03:16:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402471.644423; Thu, 08 Sep 2022 03:16:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW81i-00072h-Ov; Thu, 08 Sep 2022 03:16:26 +0000 Received: by outflank-mailman (input) for mailman id 402471; Thu, 08 Sep 2022 03:16:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW81g-00072W-MU; Thu, 08 Sep 2022 03:16:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW81g-0004Fy-K2; Thu, 08 Sep 2022 03:16:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW81f-0006En-Am; Thu, 08 Sep 2022 03:16:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oW81f-0008RV-AL; Thu, 08 Sep 2022 03:16:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dAUJkDtgjFDwLxP8mcyk1C3dkTqaS/HMhLdsKYmDePo=; b=YislasW2Gnz2Cxkh0sUcyP4UCF Ah3bZLSLN5tMhpcVqise+J1vREFPg2O2bs9zJcr6tltsNUdVuhbq0Bp/ZLQ4A1IWGiJj/06QqH2Cy zRhVvunH3ICfilDcVf3guPj25R+RPt5cZ2JhjCxNJB2utkFANbLSLz1TnxxZCO8hue/8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173053: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=8465fd59d3a607ed29efce037ba607a71556ca4e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 03:16:23 +0000 flight 173053 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173053/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 8465fd59d3a607ed29efce037ba607a71556ca4e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 34 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 264 attempts Testing same since 173053 2022-09-08 01:13:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2187 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 03:21:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 03:21:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402480.644434 (Exim 4.92) (envelope-from ) id 1oW86Z-0000FO-Ft; Thu, 08 Sep 2022 03:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402480.644434; Thu, 08 Sep 2022 03:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW86Z-0000FH-Co; Thu, 08 Sep 2022 03:21:27 +0000 Received: by outflank-mailman (input) for mailman id 402480; Thu, 08 Sep 2022 03:21:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW86X-0000FA-Kn for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 03:21:25 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150043.outbound.protection.outlook.com [40.107.15.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5032df7d-2f25-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 05:21:23 +0200 (CEST) Received: from DU2PR04CA0044.eurprd04.prod.outlook.com (2603:10a6:10:234::19) by GV1PR08MB8213.eurprd08.prod.outlook.com (2603:10a6:150:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Thu, 8 Sep 2022 03:21:20 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::18) by DU2PR04CA0044.outlook.office365.com (2603:10a6:10:234::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15 via Frontend Transport; Thu, 8 Sep 2022 03:21:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 03:21:19 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 08 Sep 2022 03:21:19 +0000 Received: from 020fb09ef794.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E7DF9D7D-BFF0-41FF-8535-315F93B7A91B.1; Thu, 08 Sep 2022 03:21:09 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 020fb09ef794.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 03:21:09 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by VI1PR08MB5440.eurprd08.prod.outlook.com (2603:10a6:803:134::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Thu, 8 Sep 2022 03:21:06 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::b46b:79f8:a3a1:4447]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::b46b:79f8:a3a1:4447%4]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 03:21:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5032df7d-2f25-11ed-af93-0125da4c0113 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MCbkN2ky87FE8tHkikPT+Zn2PSSIaIGWoeEwkd+36zT4O8rBRJWUtGbsh/vqfPI1VG4L46qLgqTpxS5zCdAErunx1IyKHRXcv4/eKksvmjDR3w1Yr81ff62pohhXNdxFfqgPtPDllHBFcbwhtIthInjZ+5Azsx7mbUMdjIdFHdh5Da8mq/HVWEhQScLHG8b6kud9aN88PawEJ+brybSvabuoIGW+ZGEx9/1AE0K9KC1bLl6CMKaY7XHq2XH7cZJNnBc2eiVIvW+GpEXlaIi6mQp5wZQxQngMRhFmBum6n54D4ntGPGTd6LXsVvHboiNmvmUEnKGbR/fOSWzSk2FHJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/U9476IZa6u7fPevpiXhRXPuEl/tX5jEKvw3hV00AQ=; b=hK+A0plFKOtCsdGL8pwMriyscXdWD8Cue6Ag6Z4lt2IG+vlAMGs4sWTrhAjsNiefb/pmqofzVO0T8wx7NNYAueEx2gEILlP2liw8hgrmbLl+6JxAttBApkrR2VkwScLJ8Zl5GzLPGvKCMMfeIHK6GAjLyPvoCbDMi3X8z/iFyZtK+A47NnbjPsoxF+HEXp0e/d4X/wLKIqklBucY/SCmndvW05IDVFc8LvgPdTVjqUH09ok8oob8YF1MFFLGGgetevE5QSEnvoH9wxLVAa+jOHPi+804PVPZXA9WMl60VaAwBvwHQqJYBtmONy1P0E/abXkXyeIZuFYFQNzzautjqA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/U9476IZa6u7fPevpiXhRXPuEl/tX5jEKvw3hV00AQ=; b=FTJALm0LzMOhdOMKQ4OVnnISnFCq3H3F5MLyB7LE+Omljm2XEGYJPF/vDDqbndUxpu6eo4OOsM+obZQNQdSrfZ+gpeVnpgAKDrbw19jb8MpD7m3rFVGGh5kmvTgK2aPneMh9q6HTBA+TJ+GGL7pK9xwPuLnatODbRc2cY47d298= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSNe3tONmhn8yNT1LgakwOIRp8VkyPh96xTRMrKOB0I6AbGMNZhlLd9Da/7vpqbx2W4kpYpZtIe0gjbj/fZjk/inJdZ4aBFiEUQpQnQATOcKASmT6+R05PqH4Q554+2cQqrQQuY3DztQPt8s/bQpjniFmZdH0fD5PN8i2ga5zWvwlR9y22O/bQuUAaWu0UySvNDRp3RE07V7DmiKrH3MNNbdjPrljWGuf22xvvfpH9AZ5jEBfYZNPeXhLi6toAf16o7UVivwb96SmToR0vGVtcDytNIwhSYNZbVmAJZ/8hnEwwbsr7vJLQyRUWC2IeyX+BfTCnB+HhmXVsDMozWviQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/U9476IZa6u7fPevpiXhRXPuEl/tX5jEKvw3hV00AQ=; b=lHnz9j15+MY45IZNgI8S0lYclQKKywv5w6a630s0t8bBY7mftAh5jtfoVLn4OU8L0Da5sN/iJ2aV4Oi5/o7+7xEQT2ZWxkOJ0qUGP9gNpKT+S+cEgGbG1WkyldKn7IfsI78TtLMbqFzvxSWQWOB6eoL4+ox5iVBqma8847Lc/pVPa4Nv5b+bcqSNj121HsaDaSIpSIAm7c21wfMqbK74gdQmJ60zpzgTJGnwz4d6dSiczhTTVo/ESQU0tpLgFSuwH03sgO9xMTZlt++IRXaTsHPIVj0YviVvErTQGwLyvi/wNbA+vgP3A7xMy9w0CKUfJjEG2RKWh+57A84nCMjAKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/U9476IZa6u7fPevpiXhRXPuEl/tX5jEKvw3hV00AQ=; b=FTJALm0LzMOhdOMKQ4OVnnISnFCq3H3F5MLyB7LE+Omljm2XEGYJPF/vDDqbndUxpu6eo4OOsM+obZQNQdSrfZ+gpeVnpgAKDrbw19jb8MpD7m3rFVGGh5kmvTgK2aPneMh9q6HTBA+TJ+GGL7pK9xwPuLnatODbRc2cY47d298= From: Penny Zheng To: Stefano Stabellini , Julien Grall CC: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYwc8kvpCr5kBYNkK7uFgrNrDZ3a3T+1kAgACxgYCAACtxoA== Date: Thu, 8 Sep 2022 03:21:06 +0000 Message-ID: References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-8-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DA9C9E622DE3B048AA34485FA936D7E6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|VI1PR08MB5440:EE_|DBAEUR03FT051:EE_|GV1PR08MB8213:EE_ X-MS-Office365-Filtering-Correlation-Id: f77bf9fc-279d-48f2-afe9-08da914932df x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: X2DwjzBZt8qqwf+DYDo2kddIzxMASX5xF/xt5BhI7iOhwMMeunxg6/w/4YBy5Atsgub6tNnnSJ2fQlpzguXRNx3ZhI/Jx/JicN7eXsADY3HdTasX0Zksq5aYUpkWOso0jqwg1n3sXoy+fYBl6jrUw1G50EWufmOMz+xig4yxGD2Irj35qAhKtK/NXECRYMDRF3HqgT3NRPi0RMdsv3FWqomem+HetPNbmUXCdy7tvfiKINCV9cWRVeMjB1CfM9qhOWY+JJlZpXlYrAx+xfydGH36CyfGKfOVV8+gATAZXJSOvlHb6PDu6mCOaM8AWT0B0pHd8Exg4+dqOcSfgpfZWOl6UAthT0X00ZaZ0AXRxYP+Sl8JA/aW2M9WNEafhSX5QWjKE00XkmlIFb/TitkEEem3zlcZURU9B6Uj4BGOfDTYyTABB6H62wMeSdiDogGiTWDzIJLKqjsTaQQpTUpEz2Mbc/ejS/TiooKENdmn0YKldVhJ2yANRTWR8FHYOHkdBWpqxygrzKEfVr4pfrQtywL98+kQ8ndgxcp1tBe28gJiDVfYPEmFpu8DXuKUwyu+duvZXjmd60Xt2t3b+ZnsFknQy0yUQEOxvx5KfIIiuXIz9VTMzokk7oDpuHrzV3h0u1FLN9DU9J+iB+MQ0PTbGQYRLZmWXVYyJYNDc2xkI1sPoLDVsIzkXfhk8VdR4oMEPxYeq6vDCEfHcDTkRjf5BRYVDe9Mv0pOq9bAwiARS/yeBgF0WNIpOcD51nLUyCZoZ4PHc64Hw4e6iCa5FkNsxfU79OcG9MYV9TE08IZ7kiI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(66946007)(186003)(66446008)(33656002)(66476007)(54906003)(5660300002)(64756008)(83380400001)(8936002)(66556008)(8676002)(76116006)(52536014)(966005)(26005)(6506007)(4326008)(53546011)(7696005)(478600001)(71200400001)(41300700001)(316002)(86362001)(38100700002)(9686003)(2906002)(55016003)(110136005)(122000001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5440 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 81617ae3-8665-4f86-3c16-08da91492ace X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n5bDpa1/D15yizsJHBOSzfGM6N1udpTdckmrpB4imHuR9h6PdJZQ1/zSY6Um4drlagU5Na2khiKPeQXZi8xJbqQ+bXFqxbCvVYc8KB0Bq4Ub8YX3WueQev3hbKCeg5fgbP/hLa2JBPQGBROAsk1sho7S4AtBWKyqbbJQnSIxBAejcKQRtffO8x8MaET2bfa6EXDb5m7G1yqjHlyV11WxlqWh5rSAemBHwm1Bzvpa1q4tZuQY1eN/DaEMVNUKHEhdT1CT+l12WWzwdyQ9oOZAP+uelugeW+d9PrWADJEyXdHxhJV/toMrBt0DwNlEC0PVmtv1RyRz4gQJZlEarR9ph6+1WFvz18IDOIEtraD/fQRULEfSIjXlF6p3enCSMoYQ1fECJ5qallC/zxgtlNlowTl0o18B8sxOSwshLJ7CqHynpSf66PaEORjMubStDev8lw4da/QfM8iO7DNWdd3yoZ2PuMU7sI0winnI9ZJx/sl9DoGgi8vRkKbvIQtGyw9FKPJOKbs8e8AWv1XtOrax9iiCCgUgKpzYkso2295p/zWP2Dq0aYefQeg8fjsGRnV4z3mKrRvo206YmSLO0PhbQVT8HY2N6QnjbYqEkHcp+5MKnNjnZbpbGZUfFzET5Sel3ldIh60XuKBGbeXiVDbezzL3efHLKJMyhFWYig4I3xPuNKvxwSiT/99wur9t/ZmrGC3ymr7l/p8ihpRfExWktQ0MYnP4ZfZN5tEzBWFr+e4c696hPBaOFdFdNjGKNRgnxwpMlDWMYWdUaKLhFC2eDHYTxkyGPd5Ow01PORzGyOU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(136003)(376002)(36840700001)(40470700004)(46966006)(47076005)(107886003)(53546011)(336012)(6506007)(26005)(36860700001)(9686003)(8676002)(40460700003)(83380400001)(5660300002)(8936002)(52536014)(7696005)(41300700001)(4326008)(82310400005)(55016003)(40480700001)(186003)(54906003)(2906002)(966005)(81166007)(70586007)(478600001)(110136005)(316002)(82740400003)(356005)(70206006)(86362001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 03:21:19.8506 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f77bf9fc-279d-48f2-afe9-08da914932df X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8213 Hi stefano > -----Original Message----- > From: Stefano Stabellini > Sent: Thursday, September 8, 2022 8:16 AM > To: Julien Grall > Cc: Penny Zheng ; xen-devel@lists.xenproject.org; > Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest > device tree >=20 > On Wed, 7 Sep 2022, Julien Grall wrote: > > On 06/09/2022 09:59, Penny Zheng wrote: > > > We expose the shared memory to the domU using the "xen,shared- > memory-v1" > > > reserved-memory binding. See > > > Documentation/devicetree/bindings/reserved-memory/xen,shared- > memory. > > > txt in Linux for the corresponding device tree binding. > > > > > > To save the cost of re-parsing shared memory device tree > > > configuration when creating shared memory nodes in guest device > > > tree, this commit adds new field "shm_mem" to store shm-info per > > > domain. > > > > > > For each shared memory region, a range is exposed under the > > > /reserved-memory node as a child node. Each range sub-node is named > > > xen-shmem@
and has the following properties: > > > - compatible: > > > compatible =3D "xen,shared-memory-v1" > > > - reg: > > > the base guest physical address and size of the shared > > > memory region > > > - xen,id: > > > a string that identifies the shared memory region. > > > > So technically, there is a property "xen,offset" that should be > > specified for the borrowers. > > > > TBH, I don't quite understand what this property is used for. So it is > > not quite clear why this is skipped. > > > > The Stefano is the author of the binding. So maybe he can explain the > > purpose of the property and help to document it in the commit message > > why this is ignored. >=20 > It looks like it is something we introduced to handle the case where memo= ry > from the owner is shared with multiple borrowers. Each borrower would > have its own offset within the region shared by the owner: >=20 > https://marc.info/?l=3Dxen-devel&m=3D154110446604365&w=3D2 >=20 IMHO, "xen,offset" more fits in the xen dts? We configure it in borrower me= mory node, then later we shall only set up foreign memory map starting at the offset? ''' domU1-shared-mem@10000000 { compatible =3D "xen,domain-shared-memory-v1"; role =3D "borrower"; xen,shm-id =3D "my-shared-mem-0"; xen,shared-mem =3D <0x10000000 0x50000000 0x10000000>; xen,offset =3D <0x0 0x01000000>; } ''' For borrower domain, only [0x11000000, 0x20000000) need to get mapped... Of course, we could limit the memory map in related Linux driver, but for s= afety, it should be at Xen? =20 >=20 > The use-case is a bit of a corner case but it looks valid. If I had to do= it now, I > would at least mark "xen,offset" as "optional". >=20 > I think we have two options here and I am happy with either one: >=20 > 1) we add xen,offset =3D <0x0>; >=20 I will let v8 stay with this configuration, and a TODO for actual implement= ation. > 2) we do *not* add xen,offset and instead send a patch to the LKML to fix > Documentation/devicetree/bindings/reserved-memory/xen,shared- > memory.txt > so that it clearly states that xen,offset is optional. I don't know if Ro= b would > accept such a patch without changing the version in the compatible string= . >=20 > Given the release deadline, I would go with 1). We can always remove it o= nce > it becomes clearly optional. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 04:25:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 04:25:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402623.644445 (Exim 4.92) (envelope-from ) id 1oW95w-00087C-9X; Thu, 08 Sep 2022 04:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402623.644445; Thu, 08 Sep 2022 04:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW95w-000875-5t; Thu, 08 Sep 2022 04:24:52 +0000 Received: by outflank-mailman (input) for mailman id 402623; Thu, 08 Sep 2022 04:24:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW95u-00086z-Ol for xen-devel@lists.xen.org; Thu, 08 Sep 2022 04:24:50 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c12726b-2f2e-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 06:24:48 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id s14so7036942plr.4 for ; Wed, 07 Sep 2022 21:24:48 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id f21-20020a623815000000b0053e99f2bf16sm1415633pfa.78.2022.09.07.21.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 21:24:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c12726b-2f2e-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=2dYDB2qplmHcNTsNK7OMk+fttLBR+5cDoNS68j8PPJY=; b=zr+8eWuqyv5saeH7jeEHJlhWlWAnsz1VoxbFCvzme4nLUwD8qS+IyzGm51xmVlKEtO MSOJxdvYsoPXP1ZravsWWsiy0WBtzUQa+hI3kzIo/g4lnfQ8w+lraH//cJ+4W+nbvVdP qx9XbCJq9On+/gPQh5KPX7AAGS5eMiZf9/UOc62RO66UhBZSabUvqRsgBFo9Pmb+6X6K edNc6HgxR6jn44m5dBAn9RhYq1qEsu9al9wW9h3ef6xiz8FAoTsE9y1JxUDx86kCDH+l 9ohPJ2Lbnt1p6SGqLHZ3qNc37CJyrl1rP0nM7JoWHVxDxFjJxfSTV+uM6+gCxSiGiVja x4Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=2dYDB2qplmHcNTsNK7OMk+fttLBR+5cDoNS68j8PPJY=; b=G0K3vhSGimB/gublrvX7WZqNMQ19GCQIMWNOpa0tJkAuKJYAv7ZhpTsMKVGZqbc2lM 9bxlUAKGaDIAxvBZXCBveuK9CtDHMNNm09yAY21hemcmyO8e8m82RmjQHX/vOfduULwn Sc4cKHKnUQGHyhW85SalmEx+eYw4yXnKFA/ymt33b9AtBa6nO1zewknwrcR2xoMlFne/ T1DFQe6knexG2mzxPqg0ZZbtdHQ4T4cy5X3xRllOfqvb10rQ3JcqO59ynj9jZhTK/5Ou lXsj8FMIA5dzBsLXUFUU7RPg+c+LHtjI5bJYhm+a/fgUOELkX1hUWyzfQPmou2+v9yBO coyg== X-Gm-Message-State: ACgBeo12E75ua2zXfw1b98rEUkLquW5cUdJJ1iILvAk6DKb4sJhDOuNl 4l1TF0R5jdPdJ8aASQIhgJAjjw== X-Google-Smtp-Source: AA6agR68YqpJq/h1Rafd2QqDKIBcsCdIKV0f5e63Qw2Wd3WtA+g+HLqAuZWIx7m7fcdbOpUrZ2G57A== X-Received: by 2002:a17:902:6ac8:b0:175:44b5:5264 with SMTP id i8-20020a1709026ac800b0017544b55264mr7204163plt.19.1662611086639; Wed, 07 Sep 2022 21:24:46 -0700 (PDT) Date: Thu, 8 Sep 2022 09:54:42 +0530 From: Viresh Kumar To: Julien Grall Cc: Anthony PERARD , xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device Message-ID: <20220908042442.7sa6p23qqhuik6ai@vireshk-i7> References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> <20220907123224.rz7vvope37l6l6mg@vireshk-i7> <402d1abf-85f6-b13a-8a6e-80cb1792c2ee@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <402d1abf-85f6-b13a-8a6e-80cb1792c2ee@xen.org> On 07-09-22, 18:49, Julien Grall wrote: > Looking at this series, you will add ~250 lines (assuming your new patch) > for the i2c and then likely the same amount for GPIO. > > I am assuming that for every new virtio device (e.g. gps, sound, > display...), we would also need to 250 lines of code. I am worry that we > will end up to bloat libxl with duplicated code and or for device that are > barely used. I agree. > I think it would be better to find a generic way to add new virtio device > without adding code (very limited) in libxl. The advantage is someone will > be able to create a new virtio device with less effort. > > The approach I can think of is something along the lines: > > virtio = ["type=,transport=,..."] It sounds good and yeah it will save a lot of trouble. > where the compatible is the one that should be written in the DT and > transport is mmio or pci. the [...] refers to specific parameters that would > need to be passed to the backend (it is not clear how you provide them > today?). The backend doesn't need lot of parameters to be passed right now, the host specific ones (like which devices on a bus to share to the guests) are passed by its command line. The backends in our case are hypervisor agnostic and are run independently as daemons, they just need to know base/irq, which we get from xen libraries. > AFAICT, the GPIO one may need some tweaking because it requires specific > properties. I think it would be more acceptable as this will be only a few > lines (compare to 250 lines today). Right. If everyone agrees, I will be happy to work towards this. -- viresh From xen-devel-bounces@lists.xenproject.org Thu Sep 08 04:25:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 04:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402628.644455 (Exim 4.92) (envelope-from ) id 1oW971-0000BY-I3; Thu, 08 Sep 2022 04:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402628.644455; Thu, 08 Sep 2022 04:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW971-0000BR-FU; Thu, 08 Sep 2022 04:25:59 +0000 Received: by outflank-mailman (input) for mailman id 402628; Thu, 08 Sep 2022 04:25:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW96z-000054-N4 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 04:25:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 549c7b81-2f2e-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 06:25:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B9DBD6E; Wed, 7 Sep 2022 21:26:01 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7DFC03F7B4; Wed, 7 Sep 2022 21:25:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 549c7b81-2f2e-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v5 0/4] Introduce static heap Date: Thu, 8 Sep 2022 04:25:34 +0000 Message-Id: <20220908042538.27076-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU systems, where only a finite number of memory protection regions are available. The limited number of protection regions places requirement on planning the use of MPU protection regions and one or more MPU protection regions needs to be reserved only for heap. The first patch enhances the error handling in processing the dts chosen node. The second patch introduces the static heap and the device tree parsing code. The third patch renames xenheap_* to directmap_* for better readablity. The fourth patch adds the implementation of the static heap pages handling in boot and heap allocator for Arm. Changes from v4 to v5: - Use #address-cells and #size-cells for static heap, do not introduce new address/size cells. Update the dt-binding accordingly. - Correct a typo in code comments. - Drop Stefano's acked-by in patch #2 as it is not valid. - Mention the function and code comment rename in commit mesg in patch #3. Henry Wang (4): xen/arm: bootfdt: Make process_chosen_node() return int docs, xen/arm: Introduce static heap memory xen/arm: mm: Rename xenheap_* variable to directmap_* xen/arm: Handle static heap pages in boot and heap allocator SUPPORT.md | 7 ++ docs/misc/arm/device-tree/booting.txt | 52 +++++++++ xen/arch/arm/bootfdt.c | 53 ++++++--- xen/arch/arm/domain_build.c | 8 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 31 ++--- xen/arch/arm/include/asm/setup.h | 23 +++- xen/arch/arm/mm.c | 50 +++++---- xen/arch/arm/setup.c | 156 ++++++++++++++++++++------ 9 files changed, 293 insertions(+), 89 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 04:26:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 04:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402629.644467 (Exim 4.92) (envelope-from ) id 1oW975-0000Tk-QI; Thu, 08 Sep 2022 04:26:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402629.644467; Thu, 08 Sep 2022 04:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW975-0000Td-Ms; Thu, 08 Sep 2022 04:26:03 +0000 Received: by outflank-mailman (input) for mailman id 402629; Thu, 08 Sep 2022 04:26:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW974-00005q-Fr for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 04:26:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 58191be2-2f2e-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 06:26:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04989D6E; Wed, 7 Sep 2022 21:26:07 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 602763F7B4; Wed, 7 Sep 2022 21:25:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58191be2-2f2e-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v5 1/4] xen/arm: bootfdt: Make process_chosen_node() return int Date: Thu, 8 Sep 2022 04:25:35 +0000 Message-Id: <20220908042538.27076-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908042538.27076-1-Henry.Wang@arm.com> References: <20220908042538.27076-1-Henry.Wang@arm.com> At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error type. Signed-off-by: Henry Wang Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from v4 to v5: - No changes. Changes from v3 to v4: - Add Reviewed-by from Michal and Acked-by from Julien. Changes from v2 to v3: - Adjust the order of this patch, make it the #1. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..1a79b969af 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -293,9 +293,9 @@ static void __init process_multiboot_node(const void *fdt, int node, kind, start, domU); } -static void __init process_chosen_node(const void *fdt, int node, - const char *name, - u32 address_cells, u32 size_cells) +static int __init process_chosen_node(const void *fdt, int node, + const char *name, + u32 address_cells, u32 size_cells) { const struct fdt_property *prop; paddr_t start, end; @@ -306,11 +306,11 @@ static void __init process_chosen_node(const void *fdt, int node, prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); if ( !prop ) /* No initrd present. */ - return; + return 0; if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-start property has invalid length %d\n", len); - return; + return -EINVAL; } start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -318,12 +318,12 @@ static void __init process_chosen_node(const void *fdt, int node, if ( !prop ) { printk("linux,initrd-end not present but -start was\n"); - return; + return -EINVAL; } if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-end property has invalid length %d\n", len); - return; + return -EINVAL; } end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -331,12 +331,14 @@ static void __init process_chosen_node(const void *fdt, int node, { printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n", start, end); - return; + return -EINVAL; } printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end); add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); + + return 0; } static int __init process_domain_node(const void *fdt, int node, @@ -383,7 +385,7 @@ static int __init early_scan_node(const void *fdt, device_tree_node_compatible(fdt, node, "multiboot,module" ))) process_multiboot_node(fdt, node, name, address_cells, size_cells); else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) - process_chosen_node(fdt, node, name, address_cells, size_cells); + rc = process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 04:26:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 04:26:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402631.644478 (Exim 4.92) (envelope-from ) id 1oW97B-0000o4-2o; Thu, 08 Sep 2022 04:26:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402631.644478; Thu, 08 Sep 2022 04:26:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW97A-0000nu-Vs; Thu, 08 Sep 2022 04:26:08 +0000 Received: by outflank-mailman (input) for mailman id 402631; Thu, 08 Sep 2022 04:26:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW97A-000054-3T for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 04:26:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5b57a888-2f2e-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 06:26:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C5D2D6E; Wed, 7 Sep 2022 21:26:12 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 93D633F7B4; Wed, 7 Sep 2022 21:26:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b57a888-2f2e-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory Date: Thu, 8 Sep 2022 04:25:36 +0000 Message-Id: <20220908042538.27076-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908042538.27076-1-Henry.Wang@arm.com> References: <20220908042538.27076-1-Henry.Wang@arm.com> This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_tree_get_meminfo(). Changes of code are done accordingly following the introduction of this enum. Also, this commit introduces the logic to parse the static heap configuration in device tree. If the memory bank is reserved as heap through `xen,static-heap` property in device tree `chosen` node, the memory will be marked as static heap type. A documentation section is added, describing the definition of static heap memory and the method of enabling the static heap memory through device tree at boot time. Signed-off-by: Henry Wang Signed-off-by: Penny Zheng --- Changes from v4 to v5: - Use #address-cells and #size-cells for static heap, do not introduce new address/size cells. Update the dt-binding accordingly. - Correct a typo in code comments. - Drop Stefano's acked-by as it is not valid. Changes from v3 to v4: - Change of wording in comments. - Add the static heap feature in SUPPORT.md as tech preview. Changes from v2 to v3: - Define `enum membank_type` properly, drop the typedef. - Rename the feature terminology to static heap. - Rename MEMBANK_MEMORY to MEMBANK_DEFAULT and MEMBANK_XEN_DOMAIN to MEMBANK_STATIC_DOMAIN. Add comments to `enum membank_type`. - Correct typo, add the clarification of the static heap region should contain enough memory below 4GB to cater 32-bit DMA for Arm32, and add the 64KB alignment requirement in doc. - Add Stefano's Acked-by for device tree interface. Changes from v1 to v2: - Rename the device tree property to xen,static-heap to avoid confusion. - Change of commit msg and doc wording, correct typo in commit msg. - Do not change the process_chosen_node() return type. - Add an empty line in make_memory_node() memory type check to improve readability. - Use enum membank_type to make the memory type cleaner. Changes from RFC to v1: - Rename the terminology to reserved heap. --- SUPPORT.md | 7 ++++ docs/misc/arm/device-tree/booting.txt | 52 +++++++++++++++++++++++++++ xen/arch/arm/bootfdt.c | 29 ++++++++++++--- xen/arch/arm/domain_build.c | 8 +++-- xen/arch/arm/include/asm/setup.h | 22 +++++++++++- xen/arch/arm/setup.c | 2 +- 6 files changed, 111 insertions(+), 9 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index 8e040d1c1e..b02a5d25ca 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -293,6 +293,13 @@ pre-defined by configuration using physical address ranges. Status, ARM: Tech Preview +### Static Heap + +Allow reserving parts of RAM through the device tree using physical +address ranges as heap. + + Status, ARM: Tech Preview + ### Memory Sharing Allow sharing of identical pages between guests diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..a5062db217 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,55 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + + +Static Heap Memory +================== + +The static heap memory refers to parts of RAM reserved in the beginning of +boot time for heap. The memory is reserved by configuration in the device +tree using physical address ranges. + +The static heap memory declared in the device tree defines the memory areas +that will be reserved to be used exclusively as heap. + +- For Arm32, since there are separated heaps, the static heap will be used +for both domheap and xenheap. The admin should make sure that the static +heap region should contain enough memory below 4GB to cater 32-bit DMA. + +- For Arm64, since there is a single heap, the defined static heap areas +shall always go to the heap allocator. + +The static heap memory is an optional feature and can be enabled by adding +below device tree properties. + +The dtb should have the following properties: + +- xen,static-heap + + Property under the top-level "chosen" node. It specifies the address + and size of Xen static heap memory. Note that at least a 64KB + alignment is required. + +- #address-cells and #size-cells + + Specify the number of cells used for the address and size of the + "xen,static-heap" property. Note that according to the device tree + specification, the number of address cells and size cells of + "xen,static-heap" is determined by the parent #address-cells and + #size-cells of the top-level "chosen" node. + +Below is an example on how to specify the static heap in device tree: + + / { + #address-cells = <0x2>; + #size-cells = <0x2>; + ... + chosen { + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; + ... + }; + }; + +RAM starting from the host physical address 0x30000000 of 1GB size will +be reserved as static heap. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 1a79b969af..3c98c00981 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, - void *data, bool xen_domain) + void *data, enum membank_type type) { const struct fdt_property *prop; unsigned int i, banks; @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, continue; mem->bank[mem->nr_banks].start = start; mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].xen_domain = xen_domain; + mem->bank[mem->nr_banks].type = type; mem->nr_banks++; } @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, void *data) { return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, - data, false); + data, MEMBANK_DEFAULT); } static int __init process_reserved_memory_node(const void *fdt, int node, @@ -301,6 +301,26 @@ static int __init process_chosen_node(const void *fdt, int node, paddr_t start, end; int len; + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) + { + int rc; + + printk("Checking for static heap in /chosen\n"); + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: node `%s': invalid #address-cells or #size-cells\n", + name); + return -EINVAL; + } + + rc = device_tree_get_meminfo(fdt, node, "xen,static-heap", + address_cells, size_cells, + &bootinfo.reserved_mem, + MEMBANK_STATIC_HEAP); + if ( rc ) + return rc; + } + printk("Checking for initrd in /chosen\n"); prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); @@ -360,7 +380,8 @@ static int __init process_domain_node(const void *fdt, int node, "#xen,static-mem-size-cells", 0); return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, - size_cells, &bootinfo.reserved_mem, true); + size_cells, &bootinfo.reserved_mem, + MEMBANK_STATIC_DOMAIN); } static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..cea82374f7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, if ( mem->nr_banks == 0 ) return -ENOENT; - /* find first memory range not bound to a Xen domain */ - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) + /* find the first memory range that is reserved for device (or firmware) */ + for ( i = 0; i < mem->nr_banks && + (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) ; + if ( i == mem->nr_banks ) return 0; @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, u64 start = mem->bank[i].start; u64 size = mem->bank[i].size; - if ( mem->bank[i].xen_domain ) + if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) continue; dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..09188acae8 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -22,11 +22,31 @@ typedef enum { BOOTMOD_UNKNOWN } bootmodule_kind; +enum membank_type { + /* + * The MEMBANK_DEFAULT type refers to either reserved memory for the + * device/firmware (when the bank is in 'reserved_mem') or any RAM (when + * the bank is in 'mem'). + */ + MEMBANK_DEFAULT, + /* + * The MEMBANK_STATIC_DOMAIN type is used to indicate whether the memory + * bank is bound to a static Xen domain. It is only valid when the bank + * is in reserved_mem. + */ + MEMBANK_STATIC_DOMAIN, + /* + * The MEMBANK_STATIC_HEAP type is used to indicate whether the memory + * bank is reserved as static heap. It is only valid when the bank is + * in reserved_mem. + */ + MEMBANK_STATIC_HEAP, +}; struct membank { paddr_t start; paddr_t size; - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ + enum membank_type type; }; struct meminfo { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 7814fe323d..3c36c050bf 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) { - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) { mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 04:26:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 04:26:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402632.644489 (Exim 4.92) (envelope-from ) id 1oW97F-0001AV-Af; Thu, 08 Sep 2022 04:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402632.644489; Thu, 08 Sep 2022 04:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW97F-0001AO-7Z; Thu, 08 Sep 2022 04:26:13 +0000 Received: by outflank-mailman (input) for mailman id 402632; Thu, 08 Sep 2022 04:26:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW97D-00005q-Rn for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 04:26:12 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5d7ab239-2f2e-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 06:26:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1E102106F; Wed, 7 Sep 2022 21:26:16 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7B7A03F7B4; Wed, 7 Sep 2022 21:26:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d7ab239-2f2e-11ed-af93-0125da4c0113 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v5 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Date: Thu, 8 Sep 2022 04:25:37 +0000 Message-Id: <20220908042538.27076-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908042538.27076-1-Henry.Wang@arm.com> References: <20220908042538.27076-1-Henry.Wang@arm.com> With the static heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily. On Arm32, only the xenheap is direct mapped today. So the renaming to "directmap_*" would be still valid for Arm32. As the xenheap_* is renamed to directmap_*, rename the function setup_xenheap_mappings() to setup_directmap_mappings() to reflect the variable renaming, also change the code comment and printed error message in the function accordingly. No functional change is intended. Signed-off-by: Henry Wang Acked-by: Julien Grall --- Changes from v4 to v5: - Mention the function and code comment rename in commit mesg. - Add Julien's Acked-by. Changes from v3 to v4: - Also rename the setup_xenheap_mappings() function name and printed messages inside the function. - Update more comments. Changes from v2 to v3: - Adjust the order of this patch, make it #3. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 2 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 31 ++++++++++--------- xen/arch/arm/mm.c | 50 +++++++++++++++++-------------- xen/arch/arm/setup.c | 36 +++++++++++----------- 5 files changed, 64 insertions(+), 57 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 3c98c00981..b4536aed68 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -500,7 +500,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t paddr) device_tree_for_each_node((void *)fdt, 0, early_scan_node, NULL); /* - * On Arm64 setup_xenheap_mappings() expects to be called with the lowest + * On Arm64 setup_directmap_mappings() expects to be called with the lowest * bank in memory first. There is no requirement that the DT will provide * the banks sorted in ascending order. So sort them through. */ diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 2fafb9f228..0fefed1b8a 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -160,7 +160,7 @@ #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) #define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) -#define XENHEAP_VIRT_START xenheap_virt_start +#define XENHEAP_VIRT_START directmap_virt_start #define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 749fbefa0c..7d21120f98 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -154,19 +154,19 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t xenheap_mfn_start, xenheap_mfn_end; -extern vaddr_t xenheap_virt_end; +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -extern vaddr_t xenheap_virt_start; -extern unsigned long xenheap_base_pdx; +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; #endif #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ unsigned long mfn_ = mfn_x(mfn); \ - (mfn_ >= mfn_x(xenheap_mfn_start) && \ - mfn_ < mfn_x(xenheap_mfn_end)); \ + (mfn_ >= mfn_x(directmap_mfn_start) && \ + mfn_ < mfn_x(directmap_mfn_end)); \ }) #else #define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) @@ -203,9 +203,12 @@ extern void remove_early_mappings(void); extern int init_secondary_pagetables(int cpu); /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ extern void mmu_init_secondary_cpu(void); -/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. - * Base must be 32MB aligned and size a multiple of 32MB. */ -extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns); +/* + * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, + * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. + * For Arm64, map the region in the directmap area. + */ +extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ @@ -267,16 +270,16 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) static inline void *maddr_to_virt(paddr_t ma) { ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); - ma -= mfn_to_maddr(xenheap_mfn_start); + ma -= mfn_to_maddr(directmap_mfn_start); return (void *)(unsigned long) ma + XENHEAP_VIRT_START; } #else static inline void *maddr_to_virt(paddr_t ma) { - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - xenheap_base_pdx) < + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < (DIRECTMAP_SIZE >> PAGE_SHIFT)); return (void *)(XENHEAP_VIRT_START - - (xenheap_base_pdx << PAGE_SHIFT) + + (directmap_base_pdx << PAGE_SHIFT) + ((ma & ma_va_bottom_mask) | ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); } @@ -319,10 +322,10 @@ static inline struct page_info *virt_to_page(const void *v) unsigned long pdx; ASSERT(va >= XENHEAP_VIRT_START); - ASSERT(va < xenheap_virt_end); + ASSERT(va < directmap_virt_end); pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; - pdx += mfn_to_pdx(xenheap_mfn_start); + pdx += mfn_to_pdx(directmap_mfn_start); return frame_table + pdx - frametable_base_pdx; } diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..11ee49598b 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t xenheap_mfn_end __read_mostly; -vaddr_t xenheap_virt_end __read_mostly; +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; #ifdef CONFIG_ARM_64 -vaddr_t xenheap_virt_start __read_mostly; -unsigned long xenheap_base_pdx __read_mostly; +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; #endif unsigned long frametable_base_pdx __read_mostly; @@ -597,55 +597,59 @@ void mmu_init_secondary_cpu(void) } #ifdef CONFIG_ARM_32 -/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. */ -void __init setup_xenheap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) +/* + * Set up the direct-mapped xenheap: + * up to 1GB of contiguous, always-mapped memory. + */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) { int rc; rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, PAGE_HYPERVISOR_RW | _PAGE_BLOCK); if ( rc ) - panic("Unable to setup the xenheap mappings.\n"); + panic("Unable to setup the directmap mappings.\n"); - /* Record where the xenheap is, for translation routines. */ - xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; + /* Record where the directmap is, for translation routines. */ + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; } #else /* CONFIG_ARM_64 */ -void __init setup_xenheap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) +/* Map the region in the directmap area. */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) { int rc; - /* First call sets the xenheap physical and virtual offset. */ - if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) ) + /* First call sets the directmap physical and virtual offset. */ + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) { unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - xenheap_mfn_start = _mfn(base_mfn); - xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); /* * The base address may not be aligned to the first level * size (e.g. 1GB when using 4KB pages). This would prevent * superpage mappings for all the regions because the virtual * address and machine address should both be suitably aligned. * - * Prevent that by offsetting the start of the xenheap virtual + * Prevent that by offsetting the start of the directmap virtual * address. */ - xenheap_virt_start = DIRECTMAP_VIRT_START + + directmap_virt_start = DIRECTMAP_VIRT_START + (base_mfn - mfn_gb) * PAGE_SIZE; } - if ( base_mfn < mfn_x(xenheap_mfn_start) ) - panic("cannot add xenheap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(xenheap_mfn_start)); + if ( base_mfn < mfn_x(directmap_mfn_start) ) + panic("cannot add directmap mapping at %lx below heap start %lx\n", + base_mfn, mfn_x(directmap_mfn_start)); rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), _mfn(base_mfn), nr_mfns, PAGE_HYPERVISOR_RW | _PAGE_BLOCK); if ( rc ) - panic("Unable to setup the xenheap mappings.\n"); + panic("Unable to setup the directmap mappings.\n"); } #endif diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3c36c050bf..9f3838d004 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -697,11 +697,11 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 /* Avoid the xenheap */ - if ( s < mfn_to_maddr(xenheap_mfn_end) && - mfn_to_maddr(xenheap_mfn_start) < e ) + if ( s < mfn_to_maddr(directmap_mfn_end) && + mfn_to_maddr(directmap_mfn_start) < e ) { - e = mfn_to_maddr(xenheap_mfn_start); - n = mfn_to_maddr(xenheap_mfn_end); + e = mfn_to_maddr(directmap_mfn_start); + n = mfn_to_maddr(directmap_mfn_end); } #endif @@ -791,17 +791,17 @@ static void __init setup_mm(void) /* * We need some memory to allocate the page-tables used for the - * xenheap mappings. So populate the boot allocator first. + * directmap mappings. So populate the boot allocator first. * - * This requires us to set xenheap_mfn_{start, end} first so the Xenheap - * region can be avoided. + * This requires us to set directmap_mfn_{start, end} first so the + * direct-mapped Xenheap region can be avoided. */ - xenheap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - xenheap_mfn_end = mfn_add(xenheap_mfn_start, xenheap_pages); + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); populate_boot_allocator(); - setup_xenheap_mappings(mfn_x(xenheap_mfn_start), xenheap_pages); + setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); @@ -816,8 +816,8 @@ static void __init setup_mm(void) smp_processor_id()); /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), - mfn_to_maddr(xenheap_mfn_end)); + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); init_staticmem_pages(); } @@ -833,7 +833,7 @@ static void __init setup_mm(void) init_pdx(); /* - * We need some memory to allocate the page-tables used for the xenheap + * We need some memory to allocate the page-tables used for the directmap * mappings. But some regions may contain memory already allocated * for other uses (e.g. modules, reserved-memory...). * @@ -852,15 +852,15 @@ static void __init setup_mm(void) ram_start = min(ram_start, bank->start); ram_end = max(ram_end, bank_end); - setup_xenheap_mappings(PFN_DOWN(bank->start), - PFN_DOWN(bank->size)); + setup_directmap_mappings(PFN_DOWN(bank->start), + PFN_DOWN(bank->size)); } total_pages += ram_size >> PAGE_SHIFT; - xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - xenheap_mfn_start = maddr_to_mfn(ram_start); - xenheap_mfn_end = maddr_to_mfn(ram_end); + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 04:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 04:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402635.644500 (Exim 4.92) (envelope-from ) id 1oW97I-0001Z9-NA; Thu, 08 Sep 2022 04:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402635.644500; Thu, 08 Sep 2022 04:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW97I-0001Yz-K4; Thu, 08 Sep 2022 04:26:16 +0000 Received: by outflank-mailman (input) for mailman id 402635; Thu, 08 Sep 2022 04:26:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oW97H-000054-D2 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 04:26:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5fb00d8a-2f2e-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 06:26:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D16D5D6E; Wed, 7 Sep 2022 21:26:19 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3A4003F7B4; Wed, 7 Sep 2022 21:26:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fb00d8a-2f2e-11ed-a016-b9edf5238543 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v5 4/4] xen/arm: Handle static heap pages in boot and heap allocator Date: Thu, 8 Sep 2022 04:25:38 +0000 Message-Id: <20220908042538.27076-5-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908042538.27076-1-Henry.Wang@arm.com> References: <20220908042538.27076-1-Henry.Wang@arm.com> This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap is enabled, we use the static heap region for both domheap and xenheap allocation. Note that the xenheap on Arm32 should be always contiguous, so also add a helper fit_xenheap_in_static_heap() for Arm32 to find the required xenheap in the static heap regions. For Arm64, In `setup_mm`, if the static heap is enabled and used, we make sure that only these static heap pages are added to the boot allocator. These static heap pages in the boot allocator are added to the heap allocator at `end_boot_allocator()`. If the static heap is disabled, we stick to current page allocation strategy at boot time. Also, take the chance to correct a "double not" print in Arm32 `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- Changes from v4 to v5: - No changes. Changes from v3 to v4: - Add Julien's Reviewed-by. Changes from v2 to v3: - Adjustment of the terminology change to "static heap". - Change of wording in comments. - int i -> unsigned int i. - Avoid extra indentation by reverting the check of MEMBANK_RSVD_HEAP. - Use MB(32). - Drop unnecessary panic and unused variables. - Avoid the ternary operation in assigning the heap_pages. - Rework populate_boot_allocator() for static heap. Changes from v1 to v2: - Move the global bool `reserved_heap` to bootinfo. - Replace the open open-coding address ~0 by INVALID_PADDR. - Do not use reverted logic in heap_pages calculation. - Remove unused Arm32 reserved_heap_start variable. - Decouple the arm32 reserved heap too small size check with region end check. - Reuse the arm32 original xenheap finding logic with the new helper to make sure xenheap on arm32 is contiguous. Changes from RFC to v1: - Rebase on top of latest `setup_mm()` changes. - Added Arm32 logic in `setup_mm()`. --- xen/arch/arm/bootfdt.c | 2 + xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 118 +++++++++++++++++++++++++++---- 3 files changed, 107 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index b4536aed68..b092dbc21b 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -319,6 +319,8 @@ static int __init process_chosen_node(const void *fdt, int node, MEMBANK_STATIC_HEAP); if ( rc ) return rc; + + bootinfo.static_heap = true; } printk("Checking for initrd in /chosen\n"); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 09188acae8..5b86cf0245 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -97,6 +97,7 @@ struct bootinfo { #ifdef CONFIG_ACPI struct meminfo acpi; #endif + bool static_heap; }; struct map_range_data diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 9f3838d004..e0f9809d7e 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -556,6 +556,44 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, } return e; } + +/* + * Find a contiguous region that fits in the static heap region with + * required size and alignment, and return the end address of the region + * if found otherwise 0. + */ +static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) +{ + unsigned int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Allocate the xenheap as high as possible to keep low-memory + * available (assuming the admin supplied region below 4GB) + * for other use (e.g. domain memory allocation). + */ + end = max(end, aligned_end); + } + + return end; +} #endif /* @@ -661,22 +699,51 @@ static void __init init_staticmem_pages(void) } /* - * Populate the boot allocator. All the RAM but the following regions - * will be added: + * Populate the boot allocator. + * If a static heap was not provided by the admin, all the RAM but the + * following regions will be added: * - Modules (e.g., Xen, Kernel) * - Reserved regions * - Xenheap (arm32 only) + * If a static heap was provided by the admin, populate the boot + * allocator with the corresponding regions only, but with Xenheap excluded + * on arm32. */ static void __init populate_boot_allocator(void) { unsigned int i; const struct meminfo *banks = &bootinfo.mem; + paddr_t s, e; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + s = bootinfo.reserved_mem.bank[i].start; + e = s + bootinfo.reserved_mem.bank[i].size; +#ifdef CONFIG_ARM_32 + /* Avoid the xenheap, note that the xenheap cannot across a bank */ + if ( s <= mfn_to_maddr(directmap_mfn_start) && + e >= mfn_to_maddr(directmap_mfn_end) ) + { + init_boot_pages(s, mfn_to_maddr(directmap_mfn_start)); + init_boot_pages(mfn_to_maddr(directmap_mfn_end), e); + } + else +#endif + init_boot_pages(s, e); + } + + return; + } for ( i = 0; i < banks->nr_banks; i++ ) { const struct membank *bank = &banks->bank[i]; paddr_t bank_end = bank->start + bank->size; - paddr_t s, e; s = bank->start; while ( s < bank_end ) @@ -714,8 +781,8 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 static void __init setup_mm(void) { - paddr_t ram_start, ram_end, ram_size, e; - unsigned long ram_pages; + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t static_heap_end = 0, static_heap_size = 0; unsigned long heap_pages, xenheap_pages, domheap_pages; unsigned int i; const uint32_t ctr = READ_CP32(CTR); @@ -735,30 +802,51 @@ static void __init setup_mm(void) for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) { - paddr_t bank_start = bootinfo.mem.bank[i].start; - paddr_t bank_size = bootinfo.mem.bank[i].size; - paddr_t bank_end = bank_start + bank_size; + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; ram_size = ram_size + bank_size; ram_start = min(ram_start,bank_start); ram_end = max(ram_end,bank_end); } - total_pages = ram_pages = ram_size >> PAGE_SHIFT; + total_pages = ram_size >> PAGE_SHIFT; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + static_heap_size += bank_size; + static_heap_end = max(static_heap_end, bank_end); + } + + heap_pages = static_heap_size >> PAGE_SHIFT; + } + else + heap_pages = total_pages; /* * If the user has not requested otherwise via the command line * then locate the xenheap using these constraints: * + * - must be contiguous * - must be 32 MiB aligned * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system if less + * - must be at most 1GB or 1/32 the total RAM in the system (or static + heap if enabled) if less * - must be at least 32M * * We try to allocate the largest xenheap possible within these * constraints. */ - heap_pages = ram_pages; if ( opt_xenheap_megabytes ) xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); else @@ -770,7 +858,9 @@ static void __init setup_mm(void) do { - e = consider_modules(ram_start, ram_end, + e = bootinfo.static_heap ? + fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : + consider_modules(ram_start, ram_end, pfn_to_paddr(xenheap_pages), 32<<20, 0); if ( e ) @@ -780,7 +870,7 @@ static void __init setup_mm(void) } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); if ( ! e ) - panic("Not not enough space for xenheap\n"); + panic("Not enough space for xenheap\n"); domheap_pages = heap_pages - xenheap_pages; @@ -825,7 +915,7 @@ static void __init setup_mm(void) static void __init setup_mm(void) { const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = ~0; + paddr_t ram_start = INVALID_PADDR; paddr_t ram_end = 0; paddr_t ram_size = 0; unsigned int i; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 05:44:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 05:44:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402673.644510 (Exim 4.92) (envelope-from ) id 1oWAKk-0003Bh-Dl; Thu, 08 Sep 2022 05:44:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402673.644510; Thu, 08 Sep 2022 05:44:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWAKk-0003Ba-B9; Thu, 08 Sep 2022 05:44:14 +0000 Received: by outflank-mailman (input) for mailman id 402673; Thu, 08 Sep 2022 05:44:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWAKj-0003BU-BM for xen-devel@lists.xen.org; Thu, 08 Sep 2022 05:44:13 +0000 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [2607:f8b0:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42e8628a-2f39-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 07:44:11 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id y127so16845040pfy.5 for ; Wed, 07 Sep 2022 22:44:10 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id q24-20020a63f958000000b004348bd693a8sm5424839pgk.31.2022.09.07.22.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 22:44:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42e8628a-2f39-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=YqB7dPoU/NVxudY2LKy8japqoOfaZKw4HmSWhiEvGAc=; b=ssmBp2OHAvr6iMCNFYOoTcxuRhP8l1ZpoyJUxfqyN/bk9NiLknpTXNaA22ZlQaAxwR berkBNROy7WQyI4qdSFihL5XAovJRweZMygx4oA18OY+rib9TGw/Sp9ThFAQjP8GZ2hm cWqQMY+8JI7mb8wRgyKxOll4FAzVV1AJiXB2VLPHQbI1FslT+OtHx43S/QYk6sZw+Lpz YAeirAON49n2SkhUxoZiWetXFOjL7DeSCDRlLfo3La3L/bWFhhWlklk9pY2jND/7kiYF YoWDn+XL8yjkrb9PU9XX7Mpyw0bv8s4QHo4ogTQmItVukzXAlpIVbpcFSgc2Cy08KUvc YqVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=YqB7dPoU/NVxudY2LKy8japqoOfaZKw4HmSWhiEvGAc=; b=IxwIyHcJxigReZFmCjfl9ttQsq03VaJpOOLyuj98PliukJ+H8kvHRHIokUsG294a4J sw0KNx4/hZZImLo5ha+NGfO+5u3A/fFlePw7X7l2jmTmAz7sPZqtNjb2OzHzF04ZmSTt i49UmVGEuU1syyVz7qn37sEhcyuWqRXsETZYy3mMD4c9HUVv10AzukK3rKCDfTdW07sz FLw4FUAmzlTH9pZfGeSJD3BEjleiK6RXdnm0dC97/h3FKuLBwVcGQahsQsEyJ5325eZa do/m2hC7FTV2YqYjvP1Du4Og35KNGJ0Jx2f8FKQw98IF3URCVdO1gOYJe4X4A0DUDkNK Zvgg== X-Gm-Message-State: ACgBeo2FR0K97UdaFXAvLj6Yr+sk3cY/ABnC+ROBR8P+CPcawGXrJXQE 8Be0N6CgMVbmAPt+7HRsz4ZZDg== X-Google-Smtp-Source: AA6agR6BUcWrlYapkAqC6MjZPNxPhMl+pysDxYJyDRSOfyrWN/lLGNHy6pZakBiGGGZr7dTP6nPBGg== X-Received: by 2002:a05:6a00:1a14:b0:52d:5fee:d46b with SMTP id g20-20020a056a001a1400b0052d5feed46bmr7615988pfv.82.1662615849419; Wed, 07 Sep 2022 22:44:09 -0700 (PDT) Date: Thu, 8 Sep 2022 11:14:06 +0530 From: Viresh Kumar To: Julien Grall Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , anthony.perard@citrix.com, Oleksandr Tyshchenko , Bertrand Marquis Subject: Re: [PATCH V5 6/6] libxl: Allocate MMIO params for GPIO device and update DT Message-ID: <20220908054406.2tn3sqp6gqsto7vz@vireshk-i7> References: <4a238937ceb803f494e5633a3a779866383bd463.1661159474.git.viresh.kumar@linaro.org> <855f6a63-5315-d9ff-780c-9512b5a89bd6@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <855f6a63-5315-d9ff-780c-9512b5a89bd6@xen.org> On 07-09-22, 19:02, Julien Grall wrote: > It is a very descriptive compatible :). And yes I realize this is the > compatible chosen by upstream. :) > So this is exposing a GPIO interrupt controller but IIUC we will also need > to describe the devices in the device-tree. Can you outline how you would > expect it to work? The same is true for busses like I2C and SPI, which may have client devices in the DT as well. Though I don't use them currently in my setup where I need to test the backends. I am able to test both I2C and GPIO dynamically from the guest, without any client devices in the DT. > To put some context, this is related to what I wrote in patch #1. How much > code will be necessary in libxl to add new device? > > I am not the maintainer of this code, but I would expect some example how > this can be used once this merged. This would help us to understand whether > the interface is correct. I understand what you are looking for and that we may be required to pass the relation of a client device with the GPIO controller via the "virtio" entry you suggested for a common device. I don't have an answer for that at the moment. -- viresh From xen-devel-bounces@lists.xenproject.org Thu Sep 08 06:10:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 06:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402681.644522 (Exim 4.92) (envelope-from ) id 1oWAkK-0006id-Iq; Thu, 08 Sep 2022 06:10:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402681.644522; Thu, 08 Sep 2022 06:10:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWAkK-0006iW-E7; Thu, 08 Sep 2022 06:10:40 +0000 Received: by outflank-mailman (input) for mailman id 402681; Thu, 08 Sep 2022 06:10:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWAkJ-0006iQ-55 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 06:10:39 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130040.outbound.protection.outlook.com [40.107.13.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f51e9062-2f3c-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 08:10:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4498.eurprd04.prod.outlook.com (2603:10a6:208:73::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 8 Sep 2022 06:10:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 06:10:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f51e9062-2f3c-11ed-a016-b9edf5238543 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JC5TB9uodexcVn19jl0aIqpuCF5L+ccaLnCIJVsW8/YUSCYd1lBAnqj/mMlXHtI4320TsyFANsOYzI1a5CA04BVXaIOdmtSiv432wrBHQkm+AirPKXC2GcgyTdVPCTRsnWbTZCjwClYwDyeCql0HY+EiA1jch4SVwahGbawliCEIXJhrM9aDQYL4A6P7JOFD09vMyZm04wnrfNlM8FzCnu42EKEI6pAzJj77ofWEJe94b3COxC4R+tpvsAUv647TwzCuFCgEOgWgnAB6BBFOzJ9pFoAJ6AJb/MylFPRuQa2oz6+Dwi1xzDzw5R1g34qc2spSNKihYuTsbhha1DDcsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XEIQJaQYbMvzCnrPv2PapYeeNIVdjAbWOsuFpT9auG4=; b=CCZnhpWOac3SpLIksTSACDQtXFfzx5eDeY0atBwAQ58KJVBt0vYcQmgB24OgV6SWzHKdcMPFjOPSzAiyGsSgsqmgPSrxIupLwzN4Y4tfnEPZHZnZA47Punmmyq3AczkLnpnmOMEvOX2v7Rd7au04HUR+XfcmWfzSbfdyXn1KS1glkk5hJ1bew09g4USaCVphrUAmeaNHbLMyK+EJyb642mtL85AbuAEcw0LIkx7LpNGyp2/+BlRa4wGLwtdvEvg7EmYnjI7XOy+q9ytUXLdlsdhc5LiRppWPrFEwsUgmf0N6A+crXOoL00GwRZyrJ+6aOspdd26rO29WFwlDSmfALQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XEIQJaQYbMvzCnrPv2PapYeeNIVdjAbWOsuFpT9auG4=; b=AvxstKcDa62KN9OgiUZwTTj9Y0PgvCxbI3kK7BuH8Ious27px4TzrR6khi/J+r1vdpbRgPxWItTi45cpPWvq/prgPrd0G0DKw8bULjoILL9Y0J+GWsS9MRntcc07otxcwa4ZwWwpRb7dSZEOxzf0/9WcHsHOmmIxyh5FPculhs8SPfEZHduUjgDMO54TOiyZsZHLTY4+VNEVTYstlNYUqBHVdMU1OM789jKU+7gvFkW2fc/73RCSrDM1nXP63zlGDcS2qyTQnvFczFbmX9t5SEAVeGAaLb68/AJhKvgRz4CZ6WseZB2ouCGCkzfd90gIu7dzSGrAlUh3VyPyk64KMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <08f233cb-0586-1845-fd67-030eb8c4373e@suse.com> Date: Thu, 8 Sep 2022 08:10:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard , Bertrand Marquis , "xen-devel@lists.xenproject.org" References: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB4498:EE_ X-MS-Office365-Filtering-Correlation-Id: e63d5c2c-955a-431d-a1cf-08da9160d76d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lmvVqJepZhl9f6b6EXEDMJSh28CR6IL9wQwdWc7Kji5E5s7AFZOsG3CsAe1vIO0ctVoMe9A88RWMn5UPFgIgmplrRsmLUcm2F+Cjvdq1TIxQ9LH1o0+uutcUqqaAvHQoBDoyOKyLE95GeqdiEJcJ4q0V0LM1wRWVgW0oDBqDeCPemFMI2XaJcfA3fr30MBuAUD+5Cuxa4iwAntkeGZ79GGbwkcDNNS9OgWbih3BMpGwqAeWyCHz2jm1b1yRN+s+gw+5i0pXSy7krtuXVCv7pXgDsQieSM/kuXPikIrN4TveDpptqjHrSoh/srKKuFTex39uhNYujNz6XqbMZMUUT/lm7whC3aTHxkr7C0CmRdmwRJRlAOcJhcQ1686e6O2GgoqzOomdheSRGAB1XoH21RUeHlwUmYuzwc+OhePaTO0j2RSCORCLH7TmUzDgSx168g2BgFK2o3D0nlBBgq4Uec5XLUoZa3hoLIgg3KVopKnY2SF7coESMOEXj6Gftlm4NImNP9L0Q2Qol2/hHGwhQTBpHgibFqgQxfEfLNW7qKZfx1AAFy84f2Fk2L8KojPzTYhGrHRDJzf/ESNj2plYgFVU4+9zShSj1Gm80LSUYxKl8qzfIk2uobAwThFIN8oj+jY6aoVd+9vxOdU79O5j5kB6djbuWOn20hDJJuAACHK4/+74bjUnSOXdQUsK7GuvxKsCGuw7CPsJ6vgCLxUO8/7l/bMudeBbx2oLUVG022OIg3gMWRoXrR5odra6AreBXHvN2knsJBD1gYDODggFNzxmIbWr+vTY6WvVy/6Vhdng= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(396003)(366004)(376002)(136003)(6506007)(186003)(53546011)(2616005)(478600001)(6512007)(41300700001)(6486002)(31696002)(26005)(38100700002)(86362001)(316002)(6916009)(54906003)(8936002)(2906002)(4326008)(36756003)(66946007)(31686004)(66476007)(66556008)(5660300002)(8676002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGt1Y1lDNW9aSmFLMWtDeHpaME5oUWRxS2FYU3RVZ3VDODhlbG12eWVOOFNo?= =?utf-8?B?emwvaWhFZExFNXVhWUIxT0xXVDk0SHVyRElVOEdoVTNWdkthK1gzdU5IVTRk?= =?utf-8?B?QmpGUDdpTlZHSi9kOThvMHdRa1NzeGl6dGxwN3liQmlCbUhOUDZaVldTWS8v?= =?utf-8?B?UUhScURJNDgyZXJYUnJnZFNiSEhObnZWdFFzUThrWCtpVzFJcTVlZktGUGZU?= =?utf-8?B?SWkyZENCRkFsZmVwQkNPNXZzS1V3MVdYbExJbHhIYi9lVk8zMTRsU3lIVWxS?= =?utf-8?B?L09ibE1NTzBGbXpnaUF6bERPWEFnQTR1RnRCY3ljRDNWUVdZaU1KNGl4eWpZ?= =?utf-8?B?a1MrVkhJY0N1M1VIUDN3M3FoNWpydDZ3YU90aGJXYnFkN1laSmRJKzBsRTlx?= =?utf-8?B?YXJUVEVNNlA5UlQ4YWdWcDBHczhkUWY1eTVVUDJQNzVRbG8zZ2pHUDJjOUVR?= =?utf-8?B?WHUwbkc2ZG5vT0h2bmJCS2llMHNyUHozc242UHI1U2FtaXU3SklTOXg3bk1T?= =?utf-8?B?M3pmQnluV1NxWDRaZFNHSmtmamVwY2dZSlUyQ0VQd0VEWEs2aDZCek52eWFw?= =?utf-8?B?dnNZUHpDT3NQd0x5eXZpRlhOWXZua1RlK3ArNkhOU0xJUUNqVDRoN3ppM1Ny?= =?utf-8?B?QUo5bEJnZDJJYTFoRDJaSzZtUk5wcjB3Mzc3bHFsM1hxSTIyS090Syt6MFor?= =?utf-8?B?cDliSG5FMW1rTW93R0I5dkFFdndCS3hxbUh2VTY1c0lyWFpTVy9vS1JNV0dj?= =?utf-8?B?UEVSWHNmSXpxdVovYmsyb1lBWHF5NW0wRXRxWlNPMG5sT3dlckhuVXZlT3VI?= =?utf-8?B?d21VVkMwRkQvVVMwdXRYcURoZzlCSktvVGRvL1V3RU1ZeVhETUgrVzJ3OWlM?= =?utf-8?B?RjdQZTdUTVJ5Q1AvM3BjWXE5ZXRPV1lhVEFxbEljbjg3NGk5RGtndmdQK1V2?= =?utf-8?B?aDR6eE9qVTFSTU5IZWZaelhoWWVRYnlUTGtQVUxxU0RYRlhkdWpuN1RBLytJ?= =?utf-8?B?QWtyRVdoSlppYjVpaHVrbVdlYVFKNkZsdDJDT2NZOVYvRlFXMnk2L0EvejN0?= =?utf-8?B?WnVxb2x0R1czMTQ3VWt3VU56MUg1TCtTWHArZHR6U0haYlczbTEvSlgyQTBO?= =?utf-8?B?aVhEaGhBcTFQaTdCL0NrSFIwZnFRdVJjSldVcnRDOW1zZVNzNFZkakhSYmdQ?= =?utf-8?B?bVIvTllFRHo5bHVxekdBTE9EblVzS3Q5RmVMcFpETkphellRcWhDUUUwYUJR?= =?utf-8?B?K0kxU09heG92ZTFwaEE0SHZFMk5DRTZGaHRQdGhQc1VRRzVyZUlpQnNUYnlx?= =?utf-8?B?bWJjWHZzZng3VDNyS3pVNm5qNmV4bFZLSTZYQ0ZROWJpSnZwQWxsb2dDcnMv?= =?utf-8?B?b0gvelJ3eHlxL2VDNlZrbGZoTkFCdFJNZldzQmFxSzVKMzBWVEdvQ3RPZU5X?= =?utf-8?B?WFNHaTVHTS9xRUhYS1FGdlE1RGkyL1BpdVFtOU9HNE4xMzRMWWNwSHp1TVlx?= =?utf-8?B?SzVZR1ZUNVVLRFRrRWpUNzVJYk1rdGhCYjhxUUt1Q0JUSU9ibDN4Q1htdzdO?= =?utf-8?B?OFBWOWxLV2FXOEprWnBzUzhrcFplR3NtSzhiWSs5YnNOM2ZlclprbStkb2h3?= =?utf-8?B?ZFNwNllFZGxIU01VWWNqNE83RndVZVVmWUtDYklPVHpmOHBBY3NucU9KTVJL?= =?utf-8?B?ZlIrb0txWEVFU2k4UmFMU2NkK2VHUkRycXdSNUZGR1NEaGxGS0tkVDh5Z0tT?= =?utf-8?B?RHVpZnFWTlpWbDN6RU4yQ1o1VzZVTDdueForLzM0QkxxVDRsc2lGcUNuaG04?= =?utf-8?B?eWxUR0VsRmdGckNTTkIwSWhCQmc3dG9XYnhOM3IzUHduN1BmRnhiMmQ4SXlL?= =?utf-8?B?cnZmbUR6YmU5czE5Z1BHT0tVM2tqT3JnNkQ0a0ZaZS9ldFFMVjRhTDNaY2Zm?= =?utf-8?B?dDIxRHQyVFlJQ2QxWCtXdzc3clJIM3RCYXFrMmlFSGthbFZDeGwxd3o1dGxW?= =?utf-8?B?NlZNZXFVY3NOMEIzcXNEa2dGK2U1cndrek9UZWhWaG11UXpDeUJ1U3ZNK0Ny?= =?utf-8?B?Wm9NSjZSOFNRVGtLR3lHNHlydjVRNVRyY09SQUpVUy9kc0pCTGpOR2NEeFk3?= =?utf-8?Q?wp6AzUyoJze8yQlsGKFL6wlVp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e63d5c2c-955a-431d-a1cf-08da9160d76d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 06:10:34.5864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SBysQurA0RtYutz6ligWoUKCwwl5ATjxzbuF3bfWyaZTa3vKLm09P67C+7ibB4ajD1iEpwqECi2YY+759DmyKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4498 On 07.09.2022 16:33, Julien Grall wrote: > On 25/08/2022 08:17, Jan Beulich wrote: >> I haven't been able to find evidence of "-nopie" ever having been a >> supported compiler option. The correct spelling is "-no-pie". >> Furthermore like "-pie" this is an option which is solely passed to the >> linker. The compiler only recognizes "-fpie" / "-fPIE" / "-fno-pie", and >> it doesn't infer these options from "-pie" / "-no-pie". > > OOI, how did you find out this issue? By reviewing Andrew's "x86/hvmloader: Don't build as PIC/PIE". >> Add the compiler recognized form, but for the possible case of the >> variable also being used somewhere for linking keep the linker option as >> well (with corrected spelling). >> >> Signed-off-by: Jan Beulich > Acked-by: Julien Grall Thanks. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 06:36:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 06:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402689.644532 (Exim 4.92) (envelope-from ) id 1oWB8r-00011L-F8; Thu, 08 Sep 2022 06:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402689.644532; Thu, 08 Sep 2022 06:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWB8r-00011E-CY; Thu, 08 Sep 2022 06:36:01 +0000 Received: by outflank-mailman (input) for mailman id 402689; Thu, 08 Sep 2022 06:36:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWB8p-000118-JT for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 06:36:00 +0000 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f2f21a0-2f40-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 08:35:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f2f21a0-2f40-11ed-af93-0125da4c0113 Date: Thu, 8 Sep 2022 02:35:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662618957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jE7lXd8zCts/b8YEvdDXlJ5bev/XqPVvJNSIvscjpW4=; b=MwAw2Fh829Y+/YeGPA6cd+g09bbtapNU9zRq06d/HsaMRntRRP6MbOYfQljjG1XjFWCvOk g5bFgnPsu1HhGw2GHv2epjG5rpfLXTCK/UCnYQNU2I1noPA+19zOHe58qz47ue59dsiSE2 9ELesyPyEojCr6xzzvxPIlQ1Kgt58y4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Michal Hocko , Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220908063548.u4lqkhquuvkwzvda@kmo-framework> References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> <20220907094306.3383dac2@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220907094306.3383dac2@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Wed, Sep 07, 2022 at 09:45:18AM -0400, Steven Rostedt wrote: > On Wed, 7 Sep 2022 09:04:28 -0400 > Kent Overstreet wrote: > > > On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > > > Hmm, it seems that further discussion doesn't really make much sense > > > here. I know how to use my time better. > > > > Just a thought, but I generally find it more productive to propose ideas than to > > just be disparaging. > > > > But it's not Michal's job to do so. He's just telling you that the given > feature is not worth the burden. He's telling you the issues that he has > with the patch set. It's the submitter's job to address those concerns and > not the maintainer's to tell you how to make it better. > > When Linus tells us that a submission is crap, we don't ask him how to make > it less crap, we listen to why he called it crap, and then rewrite to be > not so crappy. If we cannot figure it out, it doesn't get in. When Linus tells someone a submission is crap, he _always_ has a sound, and _specific_ technical justification for doing so. "This code is going to be a considerable maintenance burden" is vapid, and lazy. It's the kind of feedback made by someone who has looked at the number of lines of code a patch touches and not much more. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 06:50:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 06:50:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402701.644546 (Exim 4.92) (envelope-from ) id 1oWBMH-0002lM-Og; Thu, 08 Sep 2022 06:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402701.644546; Thu, 08 Sep 2022 06:49:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBMH-0002lF-Lp; Thu, 08 Sep 2022 06:49:53 +0000 Received: by outflank-mailman (input) for mailman id 402701; Thu, 08 Sep 2022 06:49:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBMG-0002l9-An for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 06:49:52 +0000 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [2607:f8b0:4864:20::b31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f12c63e-2f42-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 08:49:50 +0200 (CEST) Received: by mail-yb1-xb31.google.com with SMTP id g5so24930622ybg.11 for ; Wed, 07 Sep 2022 23:49:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f12c63e-2f42-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=6UU7RPsFxQr+5ujpTkN8WcG542NNzl57+boNHvVA5zY=; b=JG/SHVRfqPRHCrjuBmlApXDX/0abpJphKrT6tyZKJBPfjdSoDudABKV77zHlEN88Fn gauZaKg028mQXz4IhYxWZ6Al32CCP7yJWGueoM6BfqmIyFGbhNHc42e0XX3fkUwzZeB7 iahq4zbGmhiQP33NCZ4T4eKaA3vZuTmEr9lnFAypcBd+txISnaxXaWXjTNPPmjg9GajS 6tRoG+4jxmfz1oriGaY/Kn1wnCqhPvgpDkXyvbhPKfNgBFNHlvzvS89+D7eIK/a1Yl6T kxR18XZMyg4CCoy23A8LpUnI5xLUkeiu/ZUM9+hqU3uz7MWOC86ALqrtypYUZ97mcz9b OvFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=6UU7RPsFxQr+5ujpTkN8WcG542NNzl57+boNHvVA5zY=; b=CNIobWWDgFe0j4OZS/YD3JywJbf5ZOQHr4PwdWG4dRtbhQxZCuDJrWFS/vxsmsh8u5 CaeRKdD3sDlp3dN6M/HAsEr9jy/5L1jEy9S3eYQMenLs0NDXw5HShPh/JTD00qNsKnbu W9dkoRYPjd9EPko6/MpebpVHfVsmSAmQFfyIjynZ4pbAo2qpBoRzMLk6xImejyQnCSkj 04D/4FmLq6FhwJKAoxXjsmy+LBaHV89zFp+04bPbr0w2wS71jPBa+/iTJyzUUm59Oz7g WLy8MsafpVQd/copKl04wl5yLMMFqMR49lwxSZWp5mi8RxKWGPmG0LTxLS/bK0k7PvTP Ln4w== X-Gm-Message-State: ACgBeo15GP+1nk713iEnc6iKdktLvTFb/xLDsUDpUYbzigTq7Lo929RX NOLV4ogVXSQly8yZuJFME412VLhm/xWPuZ+4s2aj+g== X-Google-Smtp-Source: AA6agR5jgN0SarKose7cXaAc78GK8TgcCf+kCWZDJ6j/hZNw94xbAsDdKa9I2VH+YZqtbSZxUJOMS41d9AU0E7sKk2c= X-Received: by 2002:a5b:cc4:0:b0:6ae:2a6c:59e6 with SMTP id e4-20020a5b0cc4000000b006ae2a6c59e6mr1980963ybr.59.1662619789134; Wed, 07 Sep 2022 23:49:49 -0700 (PDT) MIME-Version: 1.0 References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> <20220907094306.3383dac2@gandalf.local.home> <20220908063548.u4lqkhquuvkwzvda@kmo-framework> In-Reply-To: <20220908063548.u4lqkhquuvkwzvda@kmo-framework> From: Suren Baghdasaryan Date: Wed, 7 Sep 2022 23:49:37 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Kent Overstreet Cc: Steven Rostedt , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" On Wed, Sep 7, 2022 at 11:35 PM Kent Overstreet wrote: > > On Wed, Sep 07, 2022 at 09:45:18AM -0400, Steven Rostedt wrote: > > On Wed, 7 Sep 2022 09:04:28 -0400 > > Kent Overstreet wrote: > > > > > On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > > > > Hmm, it seems that further discussion doesn't really make much sense > > > > here. I know how to use my time better. > > > > > > Just a thought, but I generally find it more productive to propose ideas than to > > > just be disparaging. > > > > > > > But it's not Michal's job to do so. He's just telling you that the given > > feature is not worth the burden. He's telling you the issues that he has > > with the patch set. It's the submitter's job to address those concerns and > > not the maintainer's to tell you how to make it better. > > > > When Linus tells us that a submission is crap, we don't ask him how to make > > it less crap, we listen to why he called it crap, and then rewrite to be > > not so crappy. If we cannot figure it out, it doesn't get in. > > When Linus tells someone a submission is crap, he _always_ has a sound, and > _specific_ technical justification for doing so. > > "This code is going to be a considerable maintenance burden" is vapid, and lazy. > It's the kind of feedback made by someone who has looked at the number of lines > of code a patch touches and not much more. I would really appreciate if everyone could please stick to the technical side of the conversation. That way we can get some constructive feedback. Everything else is not helpful and at best is a distraction. Maintenance burden is a price we pay and I think it's the prerogative of the maintainers to take that into account. Our job is to prove that the price is worth paying. > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 06:51:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 06:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402709.644558 (Exim 4.92) (envelope-from ) id 1oWBNN-00044S-2J; Thu, 08 Sep 2022 06:51:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402709.644558; Thu, 08 Sep 2022 06:51:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBNM-00044L-VR; Thu, 08 Sep 2022 06:51:00 +0000 Received: by outflank-mailman (input) for mailman id 402709; Thu, 08 Sep 2022 06:50:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBNL-00044D-Np for xen-devel@lists.xen.org; Thu, 08 Sep 2022 06:50:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97f7edc0-2f42-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 08:50:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0373A33BAA; Thu, 8 Sep 2022 06:50:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A3031322C; Thu, 8 Sep 2022 06:50:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eB+iI9GQGWNzPwAAMHmgww (envelope-from ); Thu, 08 Sep 2022 06:50:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97f7edc0-2f42-11ed-af93-0125da4c0113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662619858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IkMYpdLUCGb3LGZVwqULNpnr6j9qQEifgmyhvZkI4DY=; b=bKWKXfXrBl4yF/lXygjGTtJO/idkH/Eu3oVIz+5CK8K4sIsoFaSLxltjaIYMkt/5WeVJ8I wFyWzpKD0FrSbCFBddpEFycLJWWf8QhWHH28ifGvcSo/seI/NSDI/eIKD+taebD28asxcq kv3a3J9F92Bfml9YheMRVIGsjRr9yVg= Message-ID: <824eddb0-540d-657a-e41b-66c002caf645@suse.com> Date: Thu, 8 Sep 2022 08:50:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Viresh Kumar , Julien Grall Cc: Anthony PERARD , xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> <20220907123224.rz7vvope37l6l6mg@vireshk-i7> <402d1abf-85f6-b13a-8a6e-80cb1792c2ee@xen.org> <20220908042442.7sa6p23qqhuik6ai@vireshk-i7> From: Juergen Gross Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device In-Reply-To: <20220908042442.7sa6p23qqhuik6ai@vireshk-i7> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------lL7Nb6AjsMAvJ0MCMUVos114" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------lL7Nb6AjsMAvJ0MCMUVos114 Content-Type: multipart/mixed; boundary="------------U8xMmEegv7Tm1ebQ5nsUrU9v"; protected-headers="v1" From: Juergen Gross To: Viresh Kumar , Julien Grall Cc: Anthony PERARD , xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu Message-ID: <824eddb0-540d-657a-e41b-66c002caf645@suse.com> Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> <20220907123224.rz7vvope37l6l6mg@vireshk-i7> <402d1abf-85f6-b13a-8a6e-80cb1792c2ee@xen.org> <20220908042442.7sa6p23qqhuik6ai@vireshk-i7> In-Reply-To: <20220908042442.7sa6p23qqhuik6ai@vireshk-i7> --------------U8xMmEegv7Tm1ebQ5nsUrU9v Content-Type: multipart/mixed; boundary="------------rSR3oCAEpBy8RHYEnyDDnkbK" --------------rSR3oCAEpBy8RHYEnyDDnkbK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDkuMjIgMDY6MjQsIFZpcmVzaCBLdW1hciB3cm90ZToNCj4gT24gMDctMDktMjIs IDE4OjQ5LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBMb29raW5nIGF0IHRoaXMgc2VyaWVz LCB5b3Ugd2lsbCBhZGQgfjI1MCBsaW5lcyAoYXNzdW1pbmcgeW91ciBuZXcgcGF0Y2gpDQo+ PiBmb3IgdGhlIGkyYyBhbmQgdGhlbiBsaWtlbHkgdGhlIHNhbWUgYW1vdW50IGZvciBHUElP Lg0KPj4NCj4+IEkgYW0gYXNzdW1pbmcgdGhhdCBmb3IgZXZlcnkgbmV3IHZpcnRpbyBkZXZp Y2UgKGUuZy4gZ3BzLCBzb3VuZCwNCj4+IGRpc3BsYXkuLi4pLCB3ZSB3b3VsZCBhbHNvIG5l ZWQgdG8gMjUwIGxpbmVzIG9mIGNvZGUuIEkgYW0gd29ycnkgdGhhdCB3ZQ0KPj4gd2lsbCBl bmQgdXAgdG8gYmxvYXQgbGlieGwgd2l0aCBkdXBsaWNhdGVkIGNvZGUgYW5kIG9yIGZvciBk ZXZpY2UgdGhhdCBhcmUNCj4+IGJhcmVseSB1c2VkLg0KPiANCj4gSSBhZ3JlZS4NCj4gDQo+ PiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBmaW5kIGEgZ2VuZXJpYyB3YXkgdG8g YWRkIG5ldyB2aXJ0aW8gZGV2aWNlDQo+PiB3aXRob3V0IGFkZGluZyBjb2RlICh2ZXJ5IGxp bWl0ZWQpIGluIGxpYnhsLiBUaGUgYWR2YW50YWdlIGlzIHNvbWVvbmUgd2lsbA0KPj4gYmUg YWJsZSB0byBjcmVhdGUgYSBuZXcgdmlydGlvIGRldmljZSB3aXRoIGxlc3MgZWZmb3J0Lg0K Pj4NCj4+IFRoZSBhcHByb2FjaCBJIGNhbiB0aGluayBvZiBpcyBzb21ldGhpbmcgYWxvbmcg dGhlIGxpbmVzOg0KPj4NCj4+IHZpcnRpbyA9IFsidHlwZT08Y29tcGF0aWJsZT4sdHJhbnNw b3J0PTx0cmFuc3BvcnQ+LC4uLiJdDQo+IA0KPiBJdCBzb3VuZHMgZ29vZCBhbmQgeWVhaCBp dCB3aWxsIHNhdmUgYSBsb3Qgb2YgdHJvdWJsZS4NCg0KWWVzLCBJJ2QgbGlrZSB0aGF0LCB0 b28uDQoNCj4gDQo+PiB3aGVyZSB0aGUgY29tcGF0aWJsZSBpcyB0aGUgb25lIHRoYXQgc2hv dWxkIGJlIHdyaXR0ZW4gaW4gdGhlIERUIGFuZA0KPj4gdHJhbnNwb3J0IGlzIG1taW8gb3Ig cGNpLiB0aGUgWy4uLl0gcmVmZXJzIHRvIHNwZWNpZmljIHBhcmFtZXRlcnMgdGhhdCB3b3Vs ZA0KPj4gbmVlZCB0byBiZSBwYXNzZWQgdG8gdGhlIGJhY2tlbmQgKGl0IGlzIG5vdCBjbGVh ciBob3cgeW91IHByb3ZpZGUgdGhlbQ0KPj4gdG9kYXk/KS4NCj4gDQo+IFRoZSBiYWNrZW5k IGRvZXNuJ3QgbmVlZCBsb3Qgb2YgcGFyYW1ldGVycyB0byBiZSBwYXNzZWQgcmlnaHQgbm93 LCB0aGUgaG9zdA0KPiBzcGVjaWZpYyBvbmVzIChsaWtlIHdoaWNoIGRldmljZXMgb24gYSBi dXMgdG8gc2hhcmUgdG8gdGhlIGd1ZXN0cykgYXJlIHBhc3NlZCBieQ0KPiBpdHMgY29tbWFu ZCBsaW5lLiBUaGUgYmFja2VuZHMgaW4gb3VyIGNhc2UgYXJlIGh5cGVydmlzb3IgYWdub3N0 aWMgYW5kIGFyZSBydW4NCj4gaW5kZXBlbmRlbnRseSBhcyBkYWVtb25zLCB0aGV5IGp1c3Qg bmVlZCB0byBrbm93IGJhc2UvaXJxLCB3aGljaCB3ZSBnZXQgZnJvbSB4ZW4NCj4gbGlicmFy aWVzLg0KDQpXaGVuIHVzaW5nIHFlbXUgYXMgYSBiYWNrZW5kIHRoaXMgd2lsbCBiZSBxdWl0 ZSBkaWZmZXJlbnQuDQoNCkZvciBteSBwcm90b3R5cGUgInZpcnRpbyB1c2luZyBncmFudHMi IEkgbmVlZGVkIHRvIGFkZCB0aGUgZm9sbG93aW5nIHBhcmFtZXRlcnMNCndoZW4gc3RhcnRp bmcgcWVtdSBqdXN0IGZvciBvbmUgdmlydGlvIGRpc2s6DQoNCi1kcml2ZSBmaWxlPS9ob21l L3ZtL3NsZTE1c3AxL2ltYWdlLGlmPW5vbmUsaWQ9ZHJpdmUtdmlydGlvLWRpc2swLGZvcm1h dD1yYXcnIA0KLWRldmljZSANCnZpcnRpby1ibGstcGNpLHNjc2k9b2ZmLGRyaXZlPWRyaXZl LXZpcnRpby1kaXNrMCxpZD12aXJ0aW8tZGlzazAsYm9vdGluZGV4PTAsZGlzYWJsZS1sZWdh Y3k9b24NCg0KQXMgaW4gY29tbWl0IDY2ZGQxYzYyYjJhM2M3MCBJJ2Qgc3VnZ2VzdCB0byBh ZGQgImJhY2tlbmR0eXBlPSIgaW4gb3JkZXIgdG8NCnN1cHBvcnQgZnVydGhlciBzcGVjaWFs IGhhbmRsaW5nIGZvciBlLmcuIHFlbXUuIEkgZ3Vlc3MgeW91ciBiYWNrZW5kdHlwZSB3b3Vs ZA0KcHJvYmFibHkgYmUgInN0YW5kYWxvbmUiLCBidXQgaW4gY2FzZSB5b3UgbmVlZCBmdXJ0 aGVyIHBhcmFtZXRlcnMgZnJvbSB4bC9saWJ4bA0KeW91IGNvdWxkIGFkZCBhbm90aGVyIHR5 cGUgc3VpdGluZyB5b3VyIG5lZWRzLg0KDQoNCkp1ZXJnZW4NCg== --------------rSR3oCAEpBy8RHYEnyDDnkbK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------rSR3oCAEpBy8RHYEnyDDnkbK-- --------------U8xMmEegv7Tm1ebQ5nsUrU9v-- --------------lL7Nb6AjsMAvJ0MCMUVos114 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMZkNEFAwAAAAAACgkQsN6d1ii/Ey+Z cQf9GSSatEHbqlHp7o+ef/vf75c5NWKANWoWmWOPf92V98oNQRF23tJzhPpiiVU3qWywW73zjtEb 02SLerZ42yfXI+HDkEDcRFSfQ9mXtcGiasy/2gdBc49UPR9XKY4+sXX2rMCGGT6cjy5olfQFojKd O7gw6UjtdHKIPT4C16JjynGcmDxgSLropq/PZZqTUJYMJJrO72J4lcGyZiqs0NwKGFWMXw6A8yVj YFiltdjg8KskcozoBolb0xZRwMBu47IZXVSX7w1w0cvmWOu6oC1ez1fmrC271Cv0+21MFyX3A6GC UCn/R+JHP90ekSotO5aqC1FQGtSa1WZlrvhYcR+OyA== =gU0K -----END PGP SIGNATURE----- --------------lL7Nb6AjsMAvJ0MCMUVos114-- From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:07:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:07:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402716.644568 (Exim 4.92) (envelope-from ) id 1oWBdP-0005yh-Gd; Thu, 08 Sep 2022 07:07:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402716.644568; Thu, 08 Sep 2022 07:07:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBdP-0005ya-Dx; Thu, 08 Sep 2022 07:07:35 +0000 Received: by outflank-mailman (input) for mailman id 402716; Thu, 08 Sep 2022 07:07:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBdO-0005yU-FI for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:07:34 +0000 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e881dd68-2f44-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 09:07:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e881dd68-2f44-11ed-af93-0125da4c0113 Date: Thu, 8 Sep 2022 03:07:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662620851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wTEYgGZ5tSon77wS7vl2ROsEnkkCO0gsMgQptW+CPqI=; b=iJA14xapCDtkxxFZ191Tkejngxj1CUcv4kW7CKzkjsz7ATcaQDWEu0NFSqx3I6BQdf18/S WTbuPmJUiio1UduO89kjDWGE8I/TqqMPK7/HJWAK+mBPhtt24ufrZC9OZJmb5VRtm8xK61 6ZzGjTRW6DZ8SglZivSmm0qDFb8PFdY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Suren Baghdasaryan Cc: Steven Rostedt , Michal Hocko , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220908070719.ootyzzbd47dd5rkv@kmo-framework> References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> <20220907094306.3383dac2@gandalf.local.home> <20220908063548.u4lqkhquuvkwzvda@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Wed, Sep 07, 2022 at 11:49:37PM -0700, Suren Baghdasaryan wrote: > I would really appreciate if everyone could please stick to the > technical side of the conversation. That way we can get some > constructive feedback. Everything else is not helpful and at best is a > distraction. > Maintenance burden is a price we pay and I think it's the prerogative > of the maintainers to take that into account. Our job is to prove that > the price is worth paying. Well said. I'd also like to add - slab.h does look pretty overgrown and messy. We've grown a _lot_ of special purpose memory allocation interfaces, and I think it probably is time to try and wrangle that back. The API complexity isn't just an issue for this patch - it's an issue for anything that has to wrap and plumb through memory allocation interfaces. It's a pain point for the Rust people, and also comes in e.g. the mempool API. I think we should keep going with the memalloc_no*_save()/restore() approach, and extend it to other things: - memalloc_nowait_save() - memalloc_highpri_save() (these two get you GFP_ATOMIC). Also, I don't think these all need to be separate functions, we could have memalloc_gfp_apply() memalloc_gfp_restore() which simply takes a gfp flags argument and applies it to the current PF_MEMALLOC flags. We've had long standing bugs where vmalloc() can't correctly take gfp flags because some of the allocations it does for page tables don't have it correctly plumbed through; switching to the memalloc_*_(save|restore) is something people have been wanting in order to fix this - for years. Actually following through and completing this would let us kill the gfp flags arguments to our various memory allocators entirely. I think we can do the same thing with the numa node parameter - kill kmalloc_node() et. all, move it to task_struct with a set of save/restore functions. There's probably other things we can do to simplify slab.h if we look more. I've been hoping to start pushing patches for some of this stuff - it's going to be some time before I can get to it though, can only handle so many projects in flight at a time :) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:12:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:12:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402725.644580 (Exim 4.92) (envelope-from ) id 1oWBiT-0007Wr-4E; Thu, 08 Sep 2022 07:12:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402725.644580; Thu, 08 Sep 2022 07:12:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBiT-0007Wk-0X; Thu, 08 Sep 2022 07:12:49 +0000 Received: by outflank-mailman (input) for mailman id 402725; Thu, 08 Sep 2022 07:12:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBiR-0007We-HQ for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:12:47 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a3786ecf-2f45-11ed-a016-b9edf5238543; Thu, 08 Sep 2022 09:12:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A735433D05; Thu, 8 Sep 2022 07:12:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7F64713A6D; Thu, 8 Sep 2022 07:12:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Rg4TH+2VGWOnDAAAMHmgww (envelope-from ); Thu, 08 Sep 2022 07:12:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3786ecf-2f45-11ed-a016-b9edf5238543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662621165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wQxYLHyDLglTrc96Dwo9w9RPNpsCq3XWN1HyAjbRYNs=; b=tzO1hqg8Cf+V3DOldPoJ0tAbfrcHQ/buUKHG+8XEIMml22acom6ipoa6KJxfv7pXLWnzPb dvicd90Pr+rF+mf7X8aPjxI/j/QR3x9TEVgZ2XHIm66QAHuxOs5AWnjVv3I99n9b6GSa8l ClarGp9lNgYGmVJgqD7angv+UmF6LpU= Date: Thu, 8 Sep 2022 09:12:45 +0200 From: Michal Hocko To: Kent Overstreet Cc: Steven Rostedt , Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> <20220907094306.3383dac2@gandalf.local.home> <20220908063548.u4lqkhquuvkwzvda@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908063548.u4lqkhquuvkwzvda@kmo-framework> On Thu 08-09-22 02:35:48, Kent Overstreet wrote: > On Wed, Sep 07, 2022 at 09:45:18AM -0400, Steven Rostedt wrote: > > On Wed, 7 Sep 2022 09:04:28 -0400 > > Kent Overstreet wrote: > > > > > On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > > > > Hmm, it seems that further discussion doesn't really make much sense > > > > here. I know how to use my time better. > > > > > > Just a thought, but I generally find it more productive to propose ideas than to > > > just be disparaging. > > > > > > > But it's not Michal's job to do so. He's just telling you that the given > > feature is not worth the burden. He's telling you the issues that he has > > with the patch set. It's the submitter's job to address those concerns and > > not the maintainer's to tell you how to make it better. > > > > When Linus tells us that a submission is crap, we don't ask him how to make > > it less crap, we listen to why he called it crap, and then rewrite to be > > not so crappy. If we cannot figure it out, it doesn't get in. > > When Linus tells someone a submission is crap, he _always_ has a sound, and > _specific_ technical justification for doing so. > > "This code is going to be a considerable maintenance burden" is vapid, and lazy. > It's the kind of feedback made by someone who has looked at the number of lines > of code a patch touches and not much more. Then you have probably missed a huge part of my emails. Please re-read. If those arguments are not clear, feel free to ask for clarification. Reducing the whole my reasoning and objections to the sentence above and calling that vapid and lazy is not only unfair but also disrespectful. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402726.644591 (Exim 4.92) (envelope-from ) id 1oWBig-0007t1-FM; Thu, 08 Sep 2022 07:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402726.644591; Thu, 08 Sep 2022 07:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBig-0007ss-BG; Thu, 08 Sep 2022 07:13:02 +0000 Received: by outflank-mailman (input) for mailman id 402726; Thu, 08 Sep 2022 07:13:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBie-0007qi-ST for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:13:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130071.outbound.protection.outlook.com [40.107.13.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab3854f9-2f45-11ed-af93-0125da4c0113; Thu, 08 Sep 2022 09:12:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB6298.eurprd04.prod.outlook.com (2603:10a6:10:cf::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 07:12:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 07:12:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab3854f9-2f45-11ed-af93-0125da4c0113 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mOJIdK+QcVI6rloXySipc5ihlCqspkVXt0RO9FSCdZjElpBsA/y9ZPFtWGgEHPqaM4vNEu2NyrKb53T5HXcrM6nEGzOLUxL4dHj6m+EBoczrXrh636+17o2vDUuSfik2OedRrH/EXqtn0DEzkr9xOpK5Tgzt9Wn0MN6MkAP0SX/M0NMHWygp0FOKmxPd3X6fAOJvycy3XWnX1JCex8ULslDFXP+uEi/h8E+DNCxFze0FR4rNyZ3k9/dR0EHIkGnfRp5KAVTxiX9JQs7DkxARX3u5rClb0Z6lKGAO62lGG3cd2dYiKn8cdOBllUrqemjyY1Ahn0ak2UzjUGBAf/Y6LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UCr6gW1UrogdeE6AF9LMxtQ38waCBSCVQ1ZMgKlQ9Fc=; b=ZZtin7h84k+C0O2mvB54qKOJDYlOCsPi8mjF8NJ8uPHGnx8PiXufDFS3X2bRvgdMSjQBl+Mhb3i7EB9XbGU/LJ75DnlADUP6dzqCzq1IDoDiR5IcHASutgmfK51RvdnnTO+OLDd/PfxcM4CXWkD164Y59pDJ4Tk+mfG+6gV1De6m+Yin1/xSaI6w1CGeK5xh+4TSBVp0DsOPDHlvFU3Gl9nUUyo8D04ESdo1SXP0Rr41z+mxR8JTtSRz5VyYNTi2amJIXA22KTmee2UuVN/HzSceakvrjWsyxe6sVFjs+2Odrc5Xb3N75YxLzKddCS8HnEj6D1C6CnYtfdHtbzEuig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UCr6gW1UrogdeE6AF9LMxtQ38waCBSCVQ1ZMgKlQ9Fc=; b=hPRFSXaHzrEXnZ0sIARJuT2NnVEnI0L67HuWSAW0AsM3Y31/2m1oj9lDxwb+0MZiAmE2KSfLjukMdUSLDCht2Xw6rvPDG64hJgwqx6a6ewlEEnvKDtaDPiy5r1NQ+Eqib0HLPvb3mUXzLJxrd9r258WPsclj8dSYiDsm9fl3fZB1omc74TXPOPPPdVS7u/HOEvqrqNOsobWW+rO34GuHQafzigooet3kPVwNUxzVEu8SVidA0AQS9ORGzOpyPtydPgwyxxlh+6cM9XVpoRRkee/jHsaiAP8ZBeAnHAr+wPYH/6X6Hg3KDwAZg+dPSAtHfkz7F81SjDoXy6L4zky8xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <917cc8da-5b63-6878-ac95-3db464fae26e@suse.com> Date: Thu, 8 Sep 2022 09:12:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Unaligned access on arm32 Content-Language: en-US To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Bertrand Marquis , Stefano Stabellini References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0522.eurprd06.prod.outlook.com (2603:10a6:20b:49d::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB6298:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a918285-6431-4cc0-1981-08da91698e24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xJ2dv+y7OTJgWFQ+cuO3x73IStR1XyBQj87QBzy+Ps4t2jffnV1InN2cRsvqXvriHn3XJRcfvfhJw29+uTWvgd757Xi2qZYJcspQNGpvFLVm4BXamAcfov7JgxisdhaHFzd5vyKWufEj5zyBglboNOzoTpG/mNd4C/X5wK3rdY41s3nWHqeDIwqKmjbOqRCtUNMM31Es6/m40HwqmbeNZkCZX1NBfsmE7+KH8cS/Bwr2ly189COfOn9Y7fI1f/1ozqOscSLhqxstuv9anwjhqRhGm4RCQyvGLeHyqG8iAGHxJ+bi5HtnMqXgx5mo7XH4AkFLDYa/Nf0jSTsqBcmv3yC93DFhrL0GviY/LLkx8N//VcnRykfUHjWTb0rZdWIwnyC+K4XPZrzcdkyyad1R6lV87MGxAH7kNafEU3t6Y7qwm0lANyQ0JGkRhL2Jr9892+qBJX7+qyjdRrM08kYcDouj8U4scoQMz1LcwLONIbtT5jUbuvZF9btD/dMSUIrOkEhysX055CsboyzsJCGFwS7uTUjL4n59oQ8obZiK3NcYZHF6PIIEzCx9KGaFJWLOYuXVre07Mtv5wocivaAcYOA4T6TNBSamev79j2SXxOp+i6iSZ0wLYZn2IBPz7+f4S0SlL5MKEWu/OR1DgTFeleWJ9SKdLuSs/btZ+bPHK9KQdTZKWPn8rPiNj5/fDrK4Q0ugter66o5DK+AKGZR6fy5QpK1ieiMdm4aV8pTGqt5NCzNMnXx4Rgy8eY0ooUBiqqt7De56EgOucpHtSqeo4KLLK/3Mc3vYVy00v4fn3lg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(39860400002)(136003)(396003)(186003)(2616005)(5660300002)(4326008)(8676002)(2906002)(66476007)(66556008)(66946007)(8936002)(53546011)(6506007)(36756003)(26005)(86362001)(31686004)(6512007)(83380400001)(41300700001)(478600001)(6666004)(6486002)(31696002)(316002)(6916009)(54906003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXFaRzd5WXVQWXF3c1NuOVhwc1M2WHpEN0I2ZDAySEpZNlAreWNGZDZ2VzBp?= =?utf-8?B?aTYvWjFzbGV1cmYrMTAzL0RnNVVDbFpmTDJPQXc2TXpYTVMwenpORkNibVZx?= =?utf-8?B?NktpWTYxOW1yNWdmQTlzQ3lqNGlzRzRRUjNqYU1iRmlOTkJqQjluKy91enA3?= =?utf-8?B?OFkrWldZaHVueWNJY3FQVnMyL1BEa2FNR29GT3F1V1htSkpqS0hPNEJHWU5H?= =?utf-8?B?cUE4Y0Jib29ySDNUUEYyaXQ2QVdnNlk1U1BkMXFtVkpuWWNHNkhZMStSVitL?= =?utf-8?B?MVk0R1AwT2oxN0pFUnNqSjBYczZ1RndVSFpFYnNWMldCZlNFU3Z0MThrWmRY?= =?utf-8?B?U3pRVHRBYVU4QnkxVDVUczhLZEtWdkJVQmlMc3FzZldLci8zNGtaUVBjMWZn?= =?utf-8?B?NFdWdm5tQWx2eXowM2xYVFFuczZ2L2RhN0YzVkY4MjQzNnVidjFPcU1CalRO?= =?utf-8?B?T1V2WCs2Vy9uYW85LzZNT2lXSEZjaXU0WXY2emRvVlZZcFRXcHJGZDdPTk5Q?= =?utf-8?B?UDhGMEhPVlNvQ3g3bVN6dHdzR2l4c3E3Y0NrcVJWQWxwK090WlFFT0dOY0Ni?= =?utf-8?B?Nm9QKzBxN2llZ2d3TW1SNUd5bkM0Z0NoR3BGUEd4Qmw1d0ZWTHhwVWZXUFpu?= =?utf-8?B?d2kwVTFiK1E3UUoxZXR0b1NPZWliSVFOS3J4a3AyZ3VDM3dld1BhZDV5UjRK?= =?utf-8?B?cW9iRStPQUtrb0JMZlltcWxNUyt4bVBSamh2NXYxSDFZWlVvUmJGTHlxQzZ5?= =?utf-8?B?VWRZR1Y0RUhCbFBjdzBya3Z6Wll2RDhrSDBvOUdndFNZRE1FMlhhUWZEaFB0?= =?utf-8?B?OUY2b2gwYkhjZVdadWNJSlhyanNQU3k0cFNpQnNRTUpNVW1zWjhRMHpmNGsw?= =?utf-8?B?YkdHZlNCQ0x1USt2cUxSdnM5ZTc0a2h1OTNndHpYYWNkYUlsYkdSV09rcmNW?= =?utf-8?B?RmJqOGVCVzRCcG5IcE4zcmMydjM4STI1SWE0YlhrWmdZNWlPMG5WNDhQNVNW?= =?utf-8?B?TFRaY0tObDZkKzgwVk1UdU1ITFV0SEFDU1d5R2plRzRDb0pxay9uL3lPM0pL?= =?utf-8?B?Wm85VEEzUmZLbzRPQ0NwcTUzWHUydnpxMTd4eWJKSXFZOWJPY3FmekdNMmh6?= =?utf-8?B?aHhYcmQ2eEI1NkxtemVaMGxZUEpuU1k4N1VYUW5UYkFLMkFWYkxHaHMvOFFR?= =?utf-8?B?SlUvQ25mN2pJcU92MzVkS3BlKytBdU1TcXBHRGhPcm4xRTN6a2R1OTRNdlB3?= =?utf-8?B?Y21YVVBObU9UTWlURVZUM3pHdkxlR2xQWER3d3EyOHRBUkRBUHRHcVRrajlZ?= =?utf-8?B?UThvK1kwamhTRHpUSFMwYmUxL1NrUk1PUDc0R2tRMEgzcEtOYzk5emJCWnFp?= =?utf-8?B?Z28yVU9BNENhTnFtQUxwejYzWGM5V3hXVndqdWJpUHJzUEtqaVdGNDRacWNT?= =?utf-8?B?OU1GOHlxdkFPa1U4cld2MDN1OC95SlY0RzZPQS9IT2x3MXJPK1YrYys2U0lh?= =?utf-8?B?VytoaG1Ld3EwL0FBcFplcWxPSGtJcFN0b0lOVDhHTENSMURnbUNHTHlWMUpw?= =?utf-8?B?UlJsYXZZeHhhYmttUGd4NkN0OEptU0R3TFU5bDQyNkZMRWgyQmZwOHQxQkJN?= =?utf-8?B?UE43RHM4b0xBaHdaUWd2OW1nWEd1ckpMOGpwb042UDNiUnRYandOSVZtVlNE?= =?utf-8?B?ZS96QzhPUXZHcjBHU0VpdVFRSzdaSExRL2FSVnZxWXVybHFVcFNRT01Gd2l1?= =?utf-8?B?d2YwdGZFZE00QjFpU1dlNGIwUEZZamQwSUwxM1l1NGpMdjJOcVhzUDR4Mjls?= =?utf-8?B?UFZNakxMcXIxMllSUUNOVGJyZEhkdkFXTUpVcGxEbTlHU3VjLzJOdkwybnE0?= =?utf-8?B?RFNZWUVDR09OLzFQTFhZYzEwcjBIS3Fodnd3ZTZZS1ZHOUNDU1hSREQrZk1I?= =?utf-8?B?WDVFUm54ZXhXOHp6SmRxM3BEMjVFbWVQSEhKYjFMT3BJRlZGZlllemFMMlFa?= =?utf-8?B?andhNGJsdnc2OVVyOUdPN1AzWkhMU3E2VFNvY2NNaGJqdS9SdW9FS3RrZTBv?= =?utf-8?B?SHlzVWEvajdLbU5tbWl6Y2JpQllXVTJhQ0krbHEyUWRBUi9YelhvRXFEcHZP?= =?utf-8?Q?TJhttERRFuhauVUPIXKRrrRIC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a918285-6431-4cc0-1981-08da91698e24 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 07:12:57.0545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LBnV9MpbuU+GVZJ71BA2lgKYDzRjrsrCuCGd6WFUZjgqMWXFLK+7aCyyKPPuAAxJXfZi3o8SltKfiGjWnoe4jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6298 On 07.09.2022 19:21, Andrew Cooper wrote: > On 07/09/2022 16:30, Julien Grall wrote: >> Hi all, >> >> I think mentioned it privately a while a go, but never sent an e-mail >> about it. >> >> While testing arm32 with IOREQ, I noticed Xen is crashing because an >> alignment fault: >> >> (XEN) Data Abort Trap. Syndrome=0x1800061 >> (XEN) Walking Hypervisor VA 0x40027ebb on CPU0 via TTBR >> 0x000000004012f000 >> (XEN) 1ST[0x001] = 0x00400000bbffff7f >> (XEN) 2ND[0x000] = 0x00500000bc000f7d >> (XEN) CPU0: Unexpected Trap: Data Abort >> (XEN) ----[ Xen-4.17-unstable  arm32  debug=n  Tainted:   C    ]---- >> (XEN) CPU:    0 >> (XEN) PC:     002613b8 try_fwd_ioserv+0x44/0x1bc >> (XEN) CPSR:   6000005a MODE:Hypervisor >> (XEN)      R0: 00000000 R1: 00000001 R2: 0022a748 R3: 00000006 >> (XEN)      R4: 40027f20 R5: 40027f58 R6: 40028000 R7: 00000000 >> (XEN)      R8: 40027f20 R9: 4003a438 R10:002f0044 R11:40027edc >> R12:00000002 >> (XEN) HYP: SP: 40027e94 LR: 00260edc >> (XEN) >> (XEN)   VTCR_EL2: 80003558 >> (XEN)  VTTBR_EL2: 00010000bbff8000 >> (XEN) >> (XEN)  SCTLR_EL2: 30cd187f >> (XEN)    HCR_EL2: 007c663f >> (XEN)  TTBR0_EL2: 000000004012f000 >> (XEN) >> (XEN)    ESR_EL2: 97800061 >> (XEN)  HPFAR_EL2: 0067faf0 >> (XEN)      HDFAR: 40027ebb >> (XEN)      HIFAR: 67600000 >> (XEN) >> (XEN) Xen stack trace from sp=40027e94: >> (XEN)    97800061 0022a748 00000001 00000000 8000005a 00800000 >> 4003a000 00000001 >> (XEN)    4003a180 00000000 bbff47ff 00000000 67faf200 00000000 >> 4003a000 40027f20 >> (XEN)    4003a438 40027f1c 00260edc 002f0110 40027f58 40028000 >> 4003a000 0000013b >> (XEN)    40028000 002f0280 00000090 40027f58 67faf200 93820006 >> 67faf200 00000000 >> (XEN)    00000000 40027f54 0026b6ac 93820006 0022a748 00000001 >> 00000004 67faf200 >> (XEN)    00000000 00000000 00000000 00000000 ffffffff 68000000 >> 400001d3 40027f58 >> (XEN)    00201870 60000000 67601324 67faf200 00000000 00000013 >> 00000000 00000000 >> (XEN)    ffffffff 68000000 400001d3 00000000 00000000 00000000 >> ffffffff 00000000 >> (XEN)    67601074 000001d3 93820006 00000000 00000000 00000000 >> 00000000 67601008 >> (XEN)    00000000 00000000 00000000 00000000 00000000 00000000 >> 00000000 00000000 >> (XEN)    00000000 00000000 00000000 400001d3 00000000 00000000 >> 00000000 00000000 >> (XEN)    00000000 00000000 00000001 >> (XEN) Xen call trace: >> (XEN)    [<002613b8>] try_fwd_ioserv+0x44/0x1bc (PC) >> (XEN)    [<00260edc>] try_handle_mmio+0x2b0/0x2f4 (LR) >> (XEN)    [<00260edc>] try_handle_mmio+0x2b0/0x2f4 >> (XEN)    [<0026b6ac>] >> arch/arm/traps.c#do_trap_stage2_abort_guest+0x18c/0x34c >> (XEN)    [<00201870>] entry.o#return_from_trap+0/0x4 >> (XEN) >> (XEN) >> (XEN) **************************************** >> (XEN) Panic on CPU 0: >> (XEN) CPU0: Unexpected Trap: Data Abort >> (XEN) **************************************** >> >> The disassembled code is: >> >> 00261374 : >>   261374:       e16d42f0        strd    r4, [sp, #-32]! ; 0xffffffe0 >>   261378:       e1a04002        mov     r4, r2 >>   26137c:       e1a05000        mov     r5, r0 >>   261380:       e1cd60f8        strd    r6, [sp, #8] >>   261384:       e3a00000        mov     r0, #0 >>   261388:       e1a06001        mov     r6, r1 >>   26138c:       e1cd81f0        strd    r8, [sp, #16] >>   261390:       e3a01001        mov     r1, #1 >>   261394:       e58db018        str     fp, [sp, #24] >>   261398:       e28db01c        add     fp, sp, #28 >>   26139c:       e58de01c        str     lr, [sp, #28] >>   2613a0:       e24dd028        sub     sp, sp, #40     ; 0x28 >>   2613a4:       e1c220d4        ldrd    r2, [r2, #4] >>   2613a8:       e50b0024        str     r0, [fp, #-36]  ; 0xffffffdc >>   2613ac:       e5d67a26        ldrb    r7, [r6, #2598] ; 0xa26 >>   2613b0:       e14b24f4        strd    r2, [fp, #-68]  ; 0xffffffbc >>   2613b4:       e5d43000        ldrb    r3, [r4] >> * 2613b8:       e50b0021        str     r0, [fp, #-33]  ; 0xffffffdf >> >> The problem is GCC [1] decided to use 'str' for accessing an address >> that is not 32-bit aligned (fp - 33 = 0x40027e73). On arm32, we are >> forbidding aligned access, hence why it crashed. >> >> Looking online, it looks like GCC has an option to turned on/off the >> use of unaligned access [2] and it is enabled by default on ARMv7 (I >> am not sure why we didn't notice this before...). >> >> I have rebuilt Xen with the option turn off and dom0 is now booting fine. > > Any idea which line of code that corresponds to? > > It's storing zero into the stack quite early on, so I suspect it's the > initialisation of p on the stack. The pattern reminds me of how I've seen certain gcc versions carry out (perhaps implicit as in the case here) memset() of 7 bytes (here starting at p.vp_eport) on x86 - two partly overlapping 32-bit stores. > There are plenty of implicit zeros needing setting, so has the compiler > tried to merge adjacent stores and ended up with something that's unaligned? > >> However, I am a bit puzzled because the C code didn't contain >> unaligned access. It was all introduced by the compiler itself. This >> is breaking our assumption that the compiler will not break down >> correctly naturally aligned access. > > This assumption has never been true, and is discussed in depth in the > Linux memory barriers doc.  A lot of effort is going into trying to > figure out when it is safe to merge adjacent accesses.  (But in this > case, I would say it's a compiler bug, if the guess above is correct.) I don't think that's a compiler bug, but I do observe that gcc12, while not really generating good code, doesn't generate unaligned stores (neither for a debug nor for a release build). Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:30:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402751.644602 (Exim 4.92) (envelope-from ) id 1oWBzk-0002Jo-Uw; Thu, 08 Sep 2022 07:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402751.644602; Thu, 08 Sep 2022 07:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBzk-0002Jh-S2; Thu, 08 Sep 2022 07:30:40 +0000 Received: by outflank-mailman (input) for mailman id 402751; Thu, 08 Sep 2022 07:30:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBzk-0002Jb-Di for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:30:40 +0000 Received: from out0.migadu.com (out0.migadu.com [2001:41d0:2:267::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21e20eaa-2f48-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 09:30:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21e20eaa-2f48-11ed-9760-273f2230c3a0 Date: Thu, 8 Sep 2022 03:29:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662622236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DqfWXb2eEuuOxMq6abU6PffruFzdNn4Aud1F5cFJAhI=; b=Fw8tAVGZj5GyiSqYxRkRmSk4x1RT2ZwVJU0JDfghWsKBfIGHKaRr04lhoKOVAsK9mBuLF+ 9iI0Zcp5Zlk1fasn3UZcG2E28IiTTnVsfmeKdAq1LMPY/5nchmAf+pI4zvkYYgOYnJoj7B 58GfzCiu+o2KhFlYF9EH5IZegrVCLG0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Steven Rostedt , Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: <20220908072950.yapakb5scocxezhy@kmo-framework> References: <20220901201502.sn6223bayzwferxv@moria.home.lan> <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> <20220907094306.3383dac2@gandalf.local.home> <20220908063548.u4lqkhquuvkwzvda@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev On Thu, Sep 08, 2022 at 09:12:45AM +0200, Michal Hocko wrote: > Then you have probably missed a huge part of my emails. Please > re-read. If those arguments are not clear, feel free to ask for > clarification. Reducing the whole my reasoning and objections to the > sentence above and calling that vapid and lazy is not only unfair but > also disrespectful. What, where you complained about slab's page allocations showing up in the profile instead of slab, and I pointed out to you that actually each and every slab call is instrumented, and you're just seeing some double counting (that we will no doubt fix?) Or when you complained about allocation sites where it should actually be the caller that should be instrumented, and I pointed out that it'd be quite easy to simply change that code to use _kmalloc() and slab_tag_add() directly, if it becomes an issue. Of course, if we got that far, we'd have this code to thank for telling us where to look! Did I miss anything? From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:32:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402758.644613 (Exim 4.92) (envelope-from ) id 1oWC1m-0002tN-Cg; Thu, 08 Sep 2022 07:32:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402758.644613; Thu, 08 Sep 2022 07:32:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWC1m-0002tG-8E; Thu, 08 Sep 2022 07:32:46 +0000 Received: by outflank-mailman (input) for mailman id 402758; Thu, 08 Sep 2022 07:32:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWC1l-0002t6-6W; Thu, 08 Sep 2022 07:32:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWC1l-0000sw-25; Thu, 08 Sep 2022 07:32:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWC1k-0007Fd-9i; Thu, 08 Sep 2022 07:32:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWC1k-0007sN-9F; Thu, 08 Sep 2022 07:32:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CzUnTLhaqdJVB57IuHctEqF566QY+EMHcmbQtXmEnJk=; b=bPpB9jD482SdreiKJlHR9YsAna vl8Vdb2QAJE7+vzjSY5wkXMtzP/dR5rse0lfs/1GI/+Eru7TXYeu+p4qo5lWvn0QSqvcV7sImLSgK t3X1Nb2XQ2+3h1oas8UMVTOBHEP1Z8/jLzs+KKNOcNt8cxEe7EIwbobMf9nf4I6V1SBo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173051: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e46e2628e9fcce39e7ae28ac8c24bcc643ac48eb X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Thu, 08 Sep 2022 07:32:44 +0000 flight 173051 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173051/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu e46e2628e9fcce39e7ae28ac8c24bcc643ac48eb baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 35 days Failing since 172148 2022-08-04 21:39:38 Z 34 days 78 attempts Testing same since 173051 2022-09-07 18:40:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7066 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:46:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:46:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402777.644650 (Exim 4.92) (envelope-from ) id 1oWCEy-0004tV-W2; Thu, 08 Sep 2022 07:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402777.644650; Thu, 08 Sep 2022 07:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCEy-0004tO-Sp; Thu, 08 Sep 2022 07:46:24 +0000 Received: by outflank-mailman (input) for mailman id 402777; Thu, 08 Sep 2022 07:46:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCEx-0004tG-10 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:46:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54bae50d-2f4a-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 09:46:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D26133BAA; Thu, 8 Sep 2022 07:46:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E409D13A6D; Thu, 8 Sep 2022 07:46:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B6dXNsydGWMjGgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 07:46:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54bae50d-2f4a-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662623181; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8stUmslfXwqQ4rY4yqV0K4807cpifhdTUVRx/PmR6RU=; b=KiDgB6yhXX6BM0cM8WgB8fRfFB4c64hPj1AeCmzqf38RY6LayY7Vfv7IBcLs7T+tPrE9mQ NzZ01+IsA0lJ9GUB7KQi/D4YpyHLGJgRZjjddAUvV8Sf/3HgNwMem7iE9fa+ycWKaOkK5V MmBFuYT8UirtW6yHiThkok9/IETdO1A= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] xen/locks: add dynamic lock recursion checks Date: Thu, 8 Sep 2022 09:46:19 +0200 Message-Id: <20220908074619.18221-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add checking of lock recursion to the hypervisor. This is done by using a percpu data array for storing the address of each taken lock. Any attempt to take a lock twice (with the exception of recursive spinlocks) will result in a crash. This is especially meant for detecting attempts to take a rwlock multiple times as a reader, which will only result in a deadlock in case of another cpu trying to get the lock as a writer in between. The additional checks are not performance neutral, so they are enabled only in debug builds per default, as the checks are active only with CONFIG_DEBUG_LOCKS enabled. The size of the percpu data array can be selected via a boot parameter. Signed-off-by: Juergen Gross --- Further possible enhancements: - record address or file/line of locker, too - add sanity check when exiting hypervisor or going to idle that all locks have been released Signed-off-by: Juergen Gross --- docs/misc/xen-command-line.pandoc | 12 +++ xen/common/rwlock.c | 6 ++ xen/common/spinlock.c | 145 ++++++++++++++++++++++++++++++ xen/include/xen/rwlock.h | 20 +++++ xen/include/xen/spinlock.h | 4 + 5 files changed, 187 insertions(+) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 9a79385a37..7d228ad5a1 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1631,6 +1631,18 @@ This option is intended for debugging purposes only. Enable MSR_DEBUGCTL.LBR in hypervisor context to be able to dump the Last Interrupt/Exception To/From record with other registers. +### lock-depth-size +> `= ` + +> Default: `lock-depth-size=64` + +Specifies the maximum number of nested locks tested for illegal recursions. +Higher nesting levels still work, but recursion testing is omitted for those +levels. In case an illegal recursion is detected the system will crash +immediately. Specifying `0` will disable all testing of illegal lock nesting. + +This option is available for hypervisors built with CONFIG_DEBUG_LOCKS only. + ### loglvl > `= [/]` where level is `none | error | warning | info | debug | all` diff --git a/xen/common/rwlock.c b/xen/common/rwlock.c index aa15529bbe..18224a4bb5 100644 --- a/xen/common/rwlock.c +++ b/xen/common/rwlock.c @@ -54,6 +54,8 @@ void queue_read_lock_slowpath(rwlock_t *lock) * Signal the next one in queue to become queue head. */ spin_unlock(&lock->lock); + + lock_enter(&lock->lock.debug); } /* @@ -100,6 +102,8 @@ void queue_write_lock_slowpath(rwlock_t *lock) } unlock: spin_unlock(&lock->lock); + + lock_enter(&lock->lock.debug); } @@ -146,4 +150,6 @@ void _percpu_write_lock(percpu_rwlock_t **per_cpudata, /* Give the coherency fabric a break. */ cpu_relax(); }; + + lock_enter(&percpu_rwlock->rwlock.lock.debug); } diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c index 62c83aaa6a..84996c3fbc 100644 --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -1,5 +1,8 @@ +#include #include #include +#include +#include #include #include #include @@ -11,11 +14,77 @@ #ifdef CONFIG_DEBUG_LOCKS +/* Max. number of entries in locks_taken array. */ +static unsigned int __ro_after_init lock_depth_size = 64; +integer_param("lock-depth-size", lock_depth_size); + +/* + * Array of addresses of taken locks. + * nr_locks_taken is the index after the last entry. As locks tend to be + * nested cleanly, when freeing a lock it will probably be the one before + * nr_locks_taken, and new entries can be entered at that index. It is fine + * for a lock to be released out of order, though. + */ +static DEFINE_PER_CPU(const union lock_debug **, locks_taken); +static DEFINE_PER_CPU(unsigned int, nr_locks_taken); +static bool __read_mostly max_depth_reached; + static atomic_t spin_debug __read_mostly = ATOMIC_INIT(0); +static int cf_check cpu_lockdebug_callback(struct notifier_block *nfb, + unsigned long action, + void *hcpu) +{ + unsigned int cpu = (unsigned long)hcpu; + + switch ( action ) + { + case CPU_UP_PREPARE: + if ( !per_cpu(locks_taken, cpu) ) + per_cpu(locks_taken, cpu) = xzalloc_array(const union lock_debug *, + lock_depth_size); + if ( !per_cpu(locks_taken, cpu) ) + printk(XENLOG_WARNING + "cpu %u: failed to allocate lock recursion check area\n", + cpu); + break; + + case CPU_UP_CANCELED: + case CPU_DEAD: + XFREE(per_cpu(locks_taken, cpu)); + break; + + default: + break; + } + + return 0; +} + +static struct notifier_block cpu_lockdebug_nfb = { + .notifier_call = cpu_lockdebug_callback, +}; + +static int __init cf_check lockdebug_init(void) +{ + if ( lock_depth_size ) + { + register_cpu_notifier(&cpu_lockdebug_nfb); + cpu_lockdebug_callback(&cpu_lockdebug_nfb, CPU_UP_PREPARE, + (void *)(unsigned long)smp_processor_id()); + } + + return 0; +} +presmp_initcall(lockdebug_init); + void check_lock(union lock_debug *debug, bool try) { bool irq_safe = !local_irq_is_enabled(); + unsigned int cpu = smp_processor_id(); + const union lock_debug *const *taken = per_cpu(locks_taken, cpu); + unsigned int nr_taken = per_cpu(nr_locks_taken, cpu); + unsigned int i; BUILD_BUG_ON(LOCK_DEBUG_PAD_BITS <= 0); @@ -63,6 +132,16 @@ void check_lock(union lock_debug *debug, bool try) BUG(); } } + + if ( try ) + return; + + for ( i = 0; i < nr_taken; i++ ) + if ( taken[i] == debug ) + { + printk("CHECKLOCK FAILURE: lock at %p taken recursively\n", debug); + BUG(); + } } static void check_barrier(union lock_debug *debug) @@ -84,15 +163,81 @@ static void check_barrier(union lock_debug *debug) BUG_ON(!local_irq_is_enabled() && !debug->irq_safe); } +void lock_enter(const union lock_debug *debug) +{ + unsigned int cpu = smp_processor_id(); + const union lock_debug **taken = per_cpu(locks_taken, cpu); + unsigned int *nr_taken = &per_cpu(nr_locks_taken, cpu); + unsigned long flags; + + if ( !taken ) + return; + + local_irq_save(flags); + + if ( *nr_taken < lock_depth_size ) + taken[(*nr_taken)++] = debug; + else if ( !max_depth_reached ) + { + max_depth_reached = true; + printk("CHECKLOCK max lock depth %u reached!\n", lock_depth_size); + WARN(); + } + + local_irq_restore(flags); +} + +void lock_exit(const union lock_debug *debug) +{ + unsigned int cpu = smp_processor_id(); + const union lock_debug **taken = per_cpu(locks_taken, cpu); + unsigned int *nr_taken = &per_cpu(nr_locks_taken, cpu); + unsigned int i; + unsigned long flags; + + if ( !taken ) + return; + + local_irq_save(flags); + + for ( i = *nr_taken; i > 0; i-- ) + { + if ( taken[i - 1] == debug ) + { + memmove(taken + i - 1, taken + i, + (*nr_taken - i) * sizeof(*taken)); + (*nr_taken)--; + taken[*nr_taken] = NULL; + + local_irq_restore(flags); + + return; + } + } + + if ( !max_depth_reached ) + { + printk("CHECKLOCK released lock at %p not recorded!\n", debug); + WARN(); + } + + local_irq_restore(flags); +} + static void got_lock(union lock_debug *debug) { debug->cpu = smp_processor_id(); + + lock_enter(debug); } static void rel_lock(union lock_debug *debug) { if ( atomic_read(&spin_debug) > 0 ) BUG_ON(debug->cpu != smp_processor_id()); + + lock_exit(debug); + debug->cpu = SPINLOCK_NO_CPU; } diff --git a/xen/include/xen/rwlock.h b/xen/include/xen/rwlock.h index 0cc9167715..b8d52a5aa9 100644 --- a/xen/include/xen/rwlock.h +++ b/xen/include/xen/rwlock.h @@ -66,7 +66,10 @@ static inline int _read_trylock(rwlock_t *lock) * arch_lock_acquire_barrier(). */ if ( likely(_can_read_lock(cnts)) ) + { + lock_enter(&lock->lock.debug); return 1; + } atomic_sub(_QR_BIAS, &lock->cnts); } preempt_enable(); @@ -91,6 +94,7 @@ static inline void _read_lock(rwlock_t *lock) { /* The slow path calls check_lock() via spin_lock(). */ check_lock(&lock->lock.debug, false); + lock_enter(&lock->lock.debug); return; } @@ -123,6 +127,8 @@ static inline unsigned long _read_lock_irqsave(rwlock_t *lock) */ static inline void _read_unlock(rwlock_t *lock) { + lock_exit(&lock->lock.debug); + arch_lock_release_barrier(); /* * Atomically decrement the reader count @@ -170,6 +176,7 @@ static inline void _write_lock(rwlock_t *lock) { /* The slow path calls check_lock() via spin_lock(). */ check_lock(&lock->lock.debug, false); + lock_enter(&lock->lock.debug); return; } @@ -215,6 +222,8 @@ static inline int _write_trylock(rwlock_t *lock) return 0; } + lock_enter(&lock->lock.debug); + /* * atomic_cmpxchg() is a full barrier so no need for an * arch_lock_acquire_barrier(). @@ -225,6 +234,9 @@ static inline int _write_trylock(rwlock_t *lock) static inline void _write_unlock(rwlock_t *lock) { ASSERT(_is_write_locked_by_me(atomic_read(&lock->cnts))); + + lock_exit(&lock->lock.debug); + arch_lock_release_barrier(); atomic_and(~(_QW_CPUMASK | _QW_WMASK), &lock->cnts); preempt_enable(); @@ -343,6 +355,8 @@ static inline void _percpu_read_lock(percpu_rwlock_t **per_cpudata, /* All other paths have implicit check_lock() calls via read_lock(). */ check_lock(&percpu_rwlock->rwlock.lock.debug, false); } + + lock_enter(&percpu_rwlock->rwlock.lock.debug); } static inline void _percpu_read_unlock(percpu_rwlock_t **per_cpudata, @@ -353,6 +367,9 @@ static inline void _percpu_read_unlock(percpu_rwlock_t **per_cpudata, /* Verify the read lock was taken for this lock */ ASSERT(this_cpu_ptr(per_cpudata) != NULL); + + lock_exit(&percpu_rwlock->rwlock.lock.debug); + /* * Detect using a second percpu_rwlock_t simulatenously and fallback * to standard read_unlock. @@ -379,6 +396,9 @@ static inline void _percpu_write_unlock(percpu_rwlock_t **per_cpudata, ASSERT(percpu_rwlock->writer_activating); percpu_rwlock->writer_activating = 0; + + lock_exit(&percpu_rwlock->rwlock.lock.debug); + write_unlock(&percpu_rwlock->rwlock); } diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 961891bea4..2fa6ba3654 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -22,12 +22,16 @@ union lock_debug { }; #define _LOCK_DEBUG { LOCK_DEBUG_INITVAL } void check_lock(union lock_debug *debug, bool try); +void lock_enter(const union lock_debug *debug); +void lock_exit(const union lock_debug *debug); void spin_debug_enable(void); void spin_debug_disable(void); #else union lock_debug { }; #define _LOCK_DEBUG { } #define check_lock(l, t) ((void)0) +#define lock_enter(l) ((void)0) +#define lock_exit(l) ((void)0) #define spin_debug_enable() ((void)0) #define spin_debug_disable() ((void)0) #endif -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:46:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:46:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402778.644662 (Exim 4.92) (envelope-from ) id 1oWCFF-0005DQ-7h; Thu, 08 Sep 2022 07:46:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402778.644662; Thu, 08 Sep 2022 07:46:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCFF-0005DC-4V; Thu, 08 Sep 2022 07:46:41 +0000 Received: by outflank-mailman (input) for mailman id 402778; Thu, 08 Sep 2022 07:46:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCFD-0005CJ-96; Thu, 08 Sep 2022 07:46:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCFD-000196-6r; Thu, 08 Sep 2022 07:46:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCFC-0008Gd-TT; Thu, 08 Sep 2022 07:46:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWCFC-0000W1-Sx; Thu, 08 Sep 2022 07:46:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z2uj+HrRDzkk9igbFOyotZ1eqHks4T9YTa97nojroS8=; b=0XUhyeNzNKPTDIT7FkcjEaikMN LX2500L02cNzJutJo4HYISkSqN4IVrc70UtDlGHyybi/LmiO+8P1Ko0lEc0EaBXsJKDzKXGU1K3v6 V2GAQp9BQCJQAhkq14qx/CBu7WjYa9zWI7il8SQxAlVZ9BNpKGVEQJLR3P8xLzdYLErc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173057: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=d82ec90f51f61c914396271d86e64a74121dde24 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 07:46:38 +0000 flight 173057 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173057/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf d82ec90f51f61c914396271d86e64a74121dde24 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 265 attempts Testing same since 173057 2022-09-08 03:17:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2203 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:48:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402793.644673 (Exim 4.92) (envelope-from ) id 1oWCGV-00061R-JD; Thu, 08 Sep 2022 07:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402793.644673; Thu, 08 Sep 2022 07:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCGV-00061K-G5; Thu, 08 Sep 2022 07:47:59 +0000 Received: by outflank-mailman (input) for mailman id 402793; Thu, 08 Sep 2022 07:47:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCGT-00061A-VJ for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:47:57 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8cff3bcc-2f4a-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 09:47:56 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 116B433BAA; Thu, 8 Sep 2022 07:47:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DFAA713A6D; Thu, 8 Sep 2022 07:47:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id v6YhNiueGWPJGgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 07:47:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cff3bcc-2f4a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662623276; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4+jY/L5+xe35wjNUaKjbU+iCet/hLbz6TyCvxP2dmm0=; b=q2uaKkC1rcu77DvPauruHEVNp78d3UcgHYo6roqYS04TbzQga+wo3gUgYM7xc8RTAbag0b Siee5YfUMtfmfxPxqkOhtZP8FU1vyGEbeWhPo02Tz2AY0PEdGFeJwOjRT85XiTIOJmldhN n8cvx7UnpYatYAeIOdBLBa+REawwQmI= Date: Thu, 8 Sep 2022 09:47:55 +0200 From: Michal Hocko To: Kent Overstreet Cc: Steven Rostedt , Suren Baghdasaryan , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications Message-ID: References: <20220905234649.525vorzx27ybypsn@kmo-framework> <20220906182058.iijmpzu4rtxowy37@kmo-framework> <20220907130323.rwycrntnckc6h43n@kmo-framework> <20220907094306.3383dac2@gandalf.local.home> <20220908063548.u4lqkhquuvkwzvda@kmo-framework> <20220908072950.yapakb5scocxezhy@kmo-framework> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908072950.yapakb5scocxezhy@kmo-framework> On Thu 08-09-22 03:29:50, Kent Overstreet wrote: > On Thu, Sep 08, 2022 at 09:12:45AM +0200, Michal Hocko wrote: > > Then you have probably missed a huge part of my emails. Please > > re-read. If those arguments are not clear, feel free to ask for > > clarification. Reducing the whole my reasoning and objections to the > > sentence above and calling that vapid and lazy is not only unfair but > > also disrespectful. > > What, where you complained about slab's page allocations showing up in the > profile instead of slab, and I pointed out to you that actually each and every > slab call is instrumented, and you're just seeing some double counting (that we > will no doubt fix?) > > Or when you complained about allocation sites where it should actually be the > caller that should be instrumented, and I pointed out that it'd be quite easy to > simply change that code to use _kmalloc() and slab_tag_add() directly, if it > becomes an issue. > > Of course, if we got that far, we'd have this code to thank for telling us where > to look! > > Did I miss anything? Feel free to reponse to specific arguments as I wrote them. I won't repeat them again. Sure we can discuss how important/relevant those are. And that _can_ be a productive discussion. -- Michal Hocko SUSE Labs From xen-devel-bounces@lists.xenproject.org Thu Sep 08 07:55:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 07:55:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402800.644683 (Exim 4.92) (envelope-from ) id 1oWCNK-0007eH-Ay; Thu, 08 Sep 2022 07:55:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402800.644683; Thu, 08 Sep 2022 07:55:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCNK-0007eA-7b; Thu, 08 Sep 2022 07:55:02 +0000 Received: by outflank-mailman (input) for mailman id 402800; Thu, 08 Sep 2022 07:55:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCNJ-0007e4-6o for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 07:55:01 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 880359ce-2f4b-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 09:54:58 +0200 (CEST) Received: from BN1PR12CA0024.namprd12.prod.outlook.com (2603:10b6:408:e1::29) by SA1PR12MB6728.namprd12.prod.outlook.com (2603:10b6:806:257::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 8 Sep 2022 07:54:54 +0000 Received: from BN8NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::3) by BN1PR12CA0024.outlook.office365.com (2603:10b6:408:e1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Thu, 8 Sep 2022 07:54:54 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT023.mail.protection.outlook.com (10.13.177.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 07:54:53 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 02:54:49 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 02:54:07 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 02:54:05 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 880359ce-2f4b-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0EjfMcsCFLEeQOPqwB6CsMEia5NtN2knlB7HD5mvfp3ljDfhkDstzPMvrI2RRoDn5JbOIpQn8pv020c+zhiJ3U9VnJVHiqNTp9dlJiFSd4e/ZxjGPV2NpsODfOX55nvJa2wCNtI+k7ik7rDE7Zt/C1JxqRjhrAeqYFsBPOq+zlxIjPZQZv+jjAuhElgMWtzDYy03RU8Ftq6HOGaDm/w6mTuJeRT40PX9vccfmKwzWHIlPi+UeLS9mKvkx7ltx4ThQMN1x2QBnymbH1Z9GnUP4fpMIRay5DxOZcsYTDkChhFA+lBbluw9pqTXV6klaKz9XcYvHo+Sn4D3Sh0ykDc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8CCD+19MUQz8wzTNorP4jxNXc69xm5UP1Sl53heiAiI=; b=R3EtaZh5lOoRn7pT995ImZGQNEbYVOQ3fiOjnWBHsrUoJjVQRLa1dzYfTr/jgKFJyZctzB7s+jNJxhTInwQsqv41+9X+R6H9dFVt7lWHEYjcDY6DtgqYyoW2uGL/Hht9SPvDlqvjQB1r1TgESmOAGns4i16BedhIcWNOcCmK0OlPNzzot0jYJm5VkT38WQ1+cTJmTOMKVgTF8fHkr1KnxxWBHTvc3Tgc/laJlYsJJdYA6nEncebcNgMfcj7Mh3ky0WXMf+sCaGI7uU/MR/hFp8G+SYxZ39XaUQ+TXlFs7aCdd3EUbvUhamWGkcj3rXFs3afP4tuAGnFoMA1H9oUtsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CCD+19MUQz8wzTNorP4jxNXc69xm5UP1Sl53heiAiI=; b=VJHVxFnG6SUWX1Gti+R+SksKdvr16Pqgt6zSWsI7C5GITL3y44Ku6xrZzOTuESEg2ivurN1yvEqNiPO9D3dXcQPqXmQ0o66IZDUK84zRBqQxnqGUHn5vVCN3YshcCyWFS6SI+OgTLUgPkcOf2Qd6YdQO8BLp0BX4hshBcC5qwFM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <44cd9359-db40-c6e3-7398-220d27d72bdc@amd.com> Date: Thu, 8 Sep 2022 09:54:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory To: Henry Wang , CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , "Penny Zheng" References: <20220908042538.27076-1-Henry.Wang@arm.com> <20220908042538.27076-3-Henry.Wang@arm.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20220908042538.27076-3-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT023:EE_|SA1PR12MB6728:EE_ X-MS-Office365-Filtering-Correlation-Id: 599e6988-2538-4834-0194-08da916f6a60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nAg13Dj7QONfL1TaupAHC5DfXQ7uc5wl3b94HJlPPwDO7Ut0en3CYR81S59iKjuz+2oo4vTAO2Xhwno3ZHn+51QFOuEqGbv66mMTROJ4AxFEDrTPKv46eAXsvqD1qSZt/P+zkmirxb49NvytKI4CaMgbLxz57v4Dj2rz2DzwHBRf1WYZO/WvmrKq+1H3HXESjnCnhayytcIQqM5vRNlIjcMCSRXXgtV/q8lesS8a1HGreYpCiNZOknGuaQQal/sZun1dr1hfXyU/s51bWfbWb6ipn4bvyBavmGhSir3k4DbMkmEtFITECULkyvayiNCDXjEeEVYOtjXjIqoezyvfdMwT2labqeHfuQyJI6kKBfiafzbwwcJwUI3iI0sYKVvqYeiYFhmgRxrLD3xq7mZC3Ha6ZojAhbQPjeJH2Tk+gaBAUv6E2VICV77+VT07vw8yKGCQpRwN5bIDqx30RC2FkP9+pxKH91BxdXzlBduKrFYEUDs3fDBk7DOVGnbK5Cbl6axHSFZ4rhnUP9oMKK66AkeB479+CQqdf4Izx6zSlOSY/REQmH8whmSfPfzgXvKilsQnkuXgiofw/kaEkkGky0ghvkgAwtKOfYjMNUkjSNC81Zsxz11PPXGCLgQpry/+gv4ERlPZBYVnGC0eFEcLwuFyhK8sJ5MAwuoPMk/kdMVb4vL57XLZ/SWni/CfnjT+IE5zENBihE2UwkW32AAI9VFuB4rV+8EQTb70vIsdCUavQBPv1QAv0GhZoEbrirMf+MO4X3D3RyeRri4gfbyLN1N17cgLXdbcf848qWFRZTU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(40470700004)(46966006)(36840700001)(2616005)(47076005)(81166007)(26005)(86362001)(426003)(336012)(40460700003)(83380400001)(53546011)(186003)(356005)(41300700001)(36860700001)(31696002)(82740400003)(36756003)(54906003)(5660300002)(316002)(16576012)(70586007)(110136005)(40480700001)(966005)(8676002)(4326008)(70206006)(8936002)(31686004)(7416002)(478600001)(2906002)(44832011)(82310400005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 07:54:53.7170 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 599e6988-2538-4834-0194-08da916f6a60 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6728 Hi Henry, On 08/09/2022 06:25, Henry Wang wrote: > > This commit introduces the static heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > Firstly, since a new type of memory bank is needed for marking the > memory bank solely as the heap, this commit defines `enum membank_type` > and use this enum in function device_tree_get_meminfo(). Changes of > code are done accordingly following the introduction of this enum. > > Also, this commit introduces the logic to parse the static heap > configuration in device tree. If the memory bank is reserved as heap > through `xen,static-heap` property in device tree `chosen` node, the > memory will be marked as static heap type. > > A documentation section is added, describing the definition of static > heap memory and the method of enabling the static heap memory through > device tree at boot time. > > Signed-off-by: Henry Wang > Signed-off-by: Penny Zheng > --- > Changes from v4 to v5: > - Use #address-cells and #size-cells for static heap, do not introduce > new address/size cells. Update the dt-binding accordingly. > - Correct a typo in code comments. > - Drop Stefano's acked-by as it is not valid. > Changes from v3 to v4: > - Change of wording in comments. > - Add the static heap feature in SUPPORT.md as tech preview. > Changes from v2 to v3: > - Define `enum membank_type` properly, drop the typedef. > - Rename the feature terminology to static heap. > - Rename MEMBANK_MEMORY to MEMBANK_DEFAULT and MEMBANK_XEN_DOMAIN to > MEMBANK_STATIC_DOMAIN. Add comments to `enum membank_type`. > - Correct typo, add the clarification of the static heap region > should contain enough memory below 4GB to cater 32-bit DMA for Arm32, > and add the 64KB alignment requirement in doc. > - Add Stefano's Acked-by for device tree interface. > Changes from v1 to v2: > - Rename the device tree property to xen,static-heap to avoid confusion. > - Change of commit msg and doc wording, correct typo in commit msg. > - Do not change the process_chosen_node() return type. > - Add an empty line in make_memory_node() memory type check to improve > readability. > - Use enum membank_type to make the memory type cleaner. > Changes from RFC to v1: > - Rename the terminology to reserved heap. > --- > SUPPORT.md | 7 ++++ > docs/misc/arm/device-tree/booting.txt | 52 +++++++++++++++++++++++++++ > xen/arch/arm/bootfdt.c | 29 ++++++++++++--- > xen/arch/arm/domain_build.c | 8 +++-- > xen/arch/arm/include/asm/setup.h | 22 +++++++++++- > xen/arch/arm/setup.c | 2 +- > 6 files changed, 111 insertions(+), 9 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index 8e040d1c1e..b02a5d25ca 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -293,6 +293,13 @@ pre-defined by configuration using physical address ranges. > > Status, ARM: Tech Preview > > +### Static Heap > + > +Allow reserving parts of RAM through the device tree using physical > +address ranges as heap. > + > + Status, ARM: Tech Preview > + > ### Memory Sharing > > Allow sharing of identical pages between guests > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..a5062db217 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -378,3 +378,55 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > + > +Static Heap Memory > +================== > + > +The static heap memory refers to parts of RAM reserved in the beginning of > +boot time for heap. The memory is reserved by configuration in the device > +tree using physical address ranges. > + > +The static heap memory declared in the device tree defines the memory areas > +that will be reserved to be used exclusively as heap. > + > +- For Arm32, since there are separated heaps, the static heap will be used > +for both domheap and xenheap. The admin should make sure that the static > +heap region should contain enough memory below 4GB to cater 32-bit DMA. > + > +- For Arm64, since there is a single heap, the defined static heap areas > +shall always go to the heap allocator. > + > +The static heap memory is an optional feature and can be enabled by adding > +below device tree properties. > + > +The dtb should have the following properties: > + > +- xen,static-heap > + > + Property under the top-level "chosen" node. It specifies the address > + and size of Xen static heap memory. Note that at least a 64KB > + alignment is required. > + > +- #address-cells and #size-cells > + > + Specify the number of cells used for the address and size of the > + "xen,static-heap" property. Note that according to the device tree > + specification, the number of address cells and size cells of > + "xen,static-heap" is determined by the parent #address-cells and > + #size-cells of the top-level "chosen" node. I am not sure we should put the information about #address-cells and #size-cells in that form. Firstly because /chosen node is always a child of / node and according to specs [1] the #address-cells and #size-cells are required properties for the root node. If we want to still mention it I would just write under xen,static-heap: "Number of address and size cells for the xen,static-heap property is determined by the root node #address-cells/#size-cells". > + > +Below is an example on how to specify the static heap in device tree: > + > + / { > + #address-cells = <0x2>; > + #size-cells = <0x2>; > + ... > + chosen { > + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; > + ... > + }; > + }; > + > +RAM starting from the host physical address 0x30000000 of 1GB size will > +be reserved as static heap. > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 1a79b969af..3c98c00981 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > static int __init device_tree_get_meminfo(const void *fdt, int node, > const char *prop_name, > u32 address_cells, u32 size_cells, > - void *data, bool xen_domain) > + void *data, enum membank_type type) > { > const struct fdt_property *prop; > unsigned int i, banks; > @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, > continue; > mem->bank[mem->nr_banks].start = start; > mem->bank[mem->nr_banks].size = size; > - mem->bank[mem->nr_banks].xen_domain = xen_domain; > + mem->bank[mem->nr_banks].type = type; > mem->nr_banks++; > } > > @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, > void *data) > { > return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, > - data, false); > + data, MEMBANK_DEFAULT); > } > > static int __init process_reserved_memory_node(const void *fdt, int node, > @@ -301,6 +301,26 @@ static int __init process_chosen_node(const void *fdt, int node, > paddr_t start, end; > int len; > > + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) > + { > + int rc; > + > + printk("Checking for static heap in /chosen\n"); > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: node `%s': invalid #address-cells or #size-cells\n", > + name); > + return -EINVAL; > + } This check is now the direct copy of the one in device_tree_get_meminfo so please remove it to avoid code duplication. ~Michal [1] https://devicetree-specification.readthedocs.io/en/v0.3/devicenodes.html From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:16:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:16:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402816.644695 (Exim 4.92) (envelope-from ) id 1oWChd-0002Ug-Ij; Thu, 08 Sep 2022 08:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402816.644695; Thu, 08 Sep 2022 08:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWChd-0002UZ-FH; Thu, 08 Sep 2022 08:16:01 +0000 Received: by outflank-mailman (input) for mailman id 402816; Thu, 08 Sep 2022 08:16:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWChc-0002UT-6R for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:16:00 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 776fceab-2f4e-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:15:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4ED69209E6; Thu, 8 Sep 2022 08:15:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 117F21322C; Thu, 8 Sep 2022 08:15:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JhsAA72kGWMFJgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:15:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 776fceab-2f4e-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662624957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=VutynQ6XmRpsSDcF0eovDd0AQCocI4CKzQ/c4tYO0nc=; b=qnPTcSEFgIYj9/edz6qzXIFvh7Y7yFGg7DDOaQmhhaQPD8h2Rjr/hMgoWBJMJQi3PG8zwP Vo3xZWV7VOG4+d8ZI82GH0IZQeDdWrbWr7rzJJcWj463GORxohnnYHjMCPguMk9Pk3KAoj vCQ23hd+QVGJEJ99k0QRy5GMQCJJJx8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v5] tools/xenstore: add migration stream extensions for new features Date: Thu, 8 Sep 2022 10:15:52 +0200 Message-Id: <20220908081552.19889-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain quota Some of those additions (per domain features and extended watches) require bumping the migration stream version to "2", as usage of those features will require to transport mandatory new information in the migration stream. One note regarding the GLOBAL_QUOTA_DATA record: the split of quota between global and per-domain ones is meant to support the possibility to pass on unknown quota settings for newly created domains to other Xenstore instances: Imagine Xenstore A knows about global quota g and domain quota d, while Xenstore B doesn't know both. Initially I'm running Xenstore A on a host, then I'm live-updating to B. B gets the information that g is global, and d is per-domain, but has no other idea what to do with the values of g and d. OTOH it knows that each new domain should get d with the related value, so it can set d for each newly created domain. When B is either downgraded to A again, or a domain is migrated to another host running A, B can add the quota information of d for all domains. Signed-off-by: Juergen Gross --- V3: - new patch V4: - add new record types instead of modifying the existing ones (Julien Grall) V5: - addressed comments of Julien Grall --- docs/designs/xenstore-migration.md | 165 +++++++++++++++++++++++++++-- 1 file changed, 159 insertions(+), 6 deletions(-) diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md index efa526f420..5022268386 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@ -43,7 +43,14 @@ the setting of the endianness bit. |-----------|---------------------------------------------------| | `ident` | 0x78656e73746f7265 ('xenstore' in ASCII) | | | | -| `version` | 0x00000001 (the version of the specification) | +| `version` | The version of the specification, defined values: | +| | 0x00000001: all fields and records without any | +| | explicitly mentioned version | +| | dependency are valid. | +| | 0x00000002: all fields and records valid for | +| | version 1 plus fields and records | +| | explicitly stated to be supported in | +| | version 2 are valid. | | | | | `flags` | 0 (LSB): Endianness: 0 = little, 1 = big | | | | @@ -65,8 +72,9 @@ Records immediately follow the header and have the following format: +-------+-------------------------------------------------------+ ``` -NOTE: padding octets here and in all subsequent format specifications must be - written as zero and should be ignored when the stream is read. +NOTE: padding octets or fields not valid in the used version here and in all + subsequent format specifications must be written as zero and should be + ignored when the stream is read. | Field | Description | @@ -77,7 +85,10 @@ NOTE: padding octets here and in all subsequent format specifications must be | | 0x00000003: WATCH_DATA | | | 0x00000004: TRANSACTION_DATA | | | 0x00000005: NODE_DATA | -| | 0x00000006 - 0xFFFFFFFF: reserved for future use | +| | 0x00000006: GLOBAL_QUOTA_DATA | +| | 0x00000007: DOMAIN_DATA | +| | 0x00000008: WATCH_DATA_EXTENDED (version 2 and up) | +| | 0x00000009 - 0xFFFFFFFF: reserved for future use | | | | | `len` | The length (in octets) of `body` | | | | @@ -241,9 +252,49 @@ the file descriptor of the socket connection. ### WATCH_DATA -The image format will contain a `WATCH_DATA` record for each watch registered -by a connection for which there is `CONNECTION_DATA` record previously present. +The image format will contain either a `WATCH_DATA` or a `WATCH_DATA_EXTENDED` +record for each watch registered by a connection for which there is +`CONNECTION_DATA` record previously present. +``` + 0 1 2 3 octet ++-------+-------+-------+-------+ +| conn-id | ++---------------+---------------+ +| wpath-len | token-len | ++---------------+---------------+ +| wpath +... +| token +... +``` + + +| Field | Description | +|-------------|-------------------------------------------------| +| `conn-id` | The connection that issued the `WATCH` | +| | operation [2] | +| | | +| `wpath-len` | The length (in octets) of `wpath` including the | +| | NUL terminator | +| | | +| `token-len` | The length (in octets) of `token` including the | +| | NUL terminator | +| | | +| `wpath` | The watch path, as specified in the `WATCH` | +| | operation | +| | | +| `token` | The watch identifier token, as specified in the | +| | `WATCH` operation | + +\pagebreak + +### WATCH_DATA_EXTENDED + +The image format will contain either a `WATCH_DATA` or a `WATCH_DATA_EXTENDED` +record for each watch registered by a connection for which there is +`CONNECTION_DATA` record previously present. The `WATCH_DATA_EXTENDED` record +type is valid only in version 2 and later. ``` 0 1 2 3 octet @@ -252,6 +303,8 @@ by a connection for which there is `CONNECTION_DATA` record previously present. +---------------+---------------+ | wpath-len | token-len | +---------------+---------------+ +| depth | pad | ++---------------+---------------+ | wpath ... | token @@ -270,6 +323,10 @@ by a connection for which there is `CONNECTION_DATA` record previously present. | `token-len` | The length (in octets) of `token` including the | | | NUL terminator | | | | +| `depth` | The number of directory levels below the | +| | watched path to consider for a match. | +| | A value of 0xffff is used for unlimited depth. | +| | | | `wpath` | The watch path, as specified in the `WATCH` | | | operation | | | | @@ -406,6 +463,102 @@ A node permission specifier has the following format: Note that perm1 defines the domain owning the node. See [4] for more explanation of node permissions. +\pagebreak + +### GLOBAL_QUOTA_DATA + +This record is only relevant for live update. It contains the global settings +of xenstored quota. + +``` + 0 1 2 3 octet ++-------+-------+-------+-------+ +| n-dom-quota | n-glob-quota | ++---------------+---------------+ +| quota-val 1 | ++-------------------------------+ +... ++-------------------------------+ +| quota-val N | ++-------------------------------+ +| quota-names +... +``` + + +| Field | Description | +|----------------|----------------------------------------------| +| `n-dom-quota` | Number of quota values which apply per | +| | domain by default. | +| | | +| `n-glob-quota` | Number of quota values which apply globally | +| | only. | +| | | +| `quota-val` | Quota values, first the ones applying per | +| | domain, then the ones applying globally. A | +| | value of 0 has the semantics of "unlimited". | +| | | +| `quota-names` | 0 delimited strings of the quota names in | +| | the same sequence as the `quota-val` values. | + + +Allowed quota names are those explicitly named in [2] for the `GET_QUOTA` +and `SET_QUOTA` commands, plus implementation specific ones. Quota names not +recognized by the receiving side should not have any effect on behavior for +the receiving side (they can be ignored or preserved for inclusion in +future live migration/update streams). + +\pagebreak + +### DOMAIN_DATA + +This record is optional and can be present once for each domain. + + +``` + 0 1 2 3 octet ++-------+-------+-------+-------+ +| domain-id | n-quota | ++---------------+---------------+ +| features | ++-------------------------------+ +| quota-val 1 | ++-------------------------------+ +... ++-------------------------------+ +| quota-val N | ++-------------------------------+ +| quota-names +... +``` + + +| Field | Description | +|----------------|----------------------------------------------| +| `domain-id` | The domain-id of the domain this record | +| | belongs to. | +| | | +| `n-quota` | Number of quota values. | +| | | +| `features` | Value of the feature field visible by the | +| | guest at offset 2064 of the ring page. | +| | Only valid for version 2 and later. | +| | | +| `quota-val` | Quota values, a value of 0 has the semantics | +| | "unlimited". | +| | | +| `quota-names` | 0 delimited strings of the quota names in | +| | the same sequence as the `quota-val` values. | + +Allowed quota names are those explicitly named in [2] for the `GET_QUOTA` +and `SET_QUOTA` commands, plus implementation specific ones. Quota names not +recognized by the receiving side should not have any effect on behavior for +the receiving side (they can be ignored or preserved for inclusion in +future live migration/update streams). + +\pagebreak + + * * * [1] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/designs/non-cooperative-migration.md -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:22:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:22:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402823.644706 (Exim 4.92) (envelope-from ) id 1oWCo1-00043L-8X; Thu, 08 Sep 2022 08:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402823.644706; Thu, 08 Sep 2022 08:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCo1-00043E-5u; Thu, 08 Sep 2022 08:22:37 +0000 Received: by outflank-mailman (input) for mailman id 402823; Thu, 08 Sep 2022 08:22:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWCo0-000438-7s for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:22:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 646fefdf-2f4f-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:22:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8794.eurprd04.prod.outlook.com (2603:10a6:20b:409::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15; Thu, 8 Sep 2022 08:22:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 08:22:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 646fefdf-2f4f-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XoMVlMx2VsAlGRlxMThUroN+gjeK1wjSWv0v39I4JzzrGXqUu5bG4ChZ3gdARBpPGN09uGIPiqbc0JOCLmQI0O2R/C2fdH77xDAofpTAT+E5LOHwDJOX5ca/WBYn9KPvTJtECWPbjS0o/D9M3FhG6gSIfm07TFPMn4zrvTmRfrbhKBs9WRx9P6exX3zR0Xjbys9hctQmG7Sitq3+XMCXZrNuOzixe9qRhiALiZWPrZCI/BDqtSl6NAP9KTlyIGDhtp6OweWQNqq/FbUbMsWWo4Fm5XJeBihLbmf1WolxQ9V/Uh3w/iuaCH15Sk8MuC7nPxSrD3T/GNOkwGj8YLIpng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzFCySBau2bZmE8334JJ6H6sO2BpIfwAdZZj1ByL3VM=; b=lVHxqqYwrj6la17S9gd2ccgHfBrTen05r0dq+7boGfWwBvR3sT0rTKcOD08dk+v3q2P/AZd3lL3jSv5R4OL261IgAx6itnr9idb2dcdVrTh9hr8Jrl3n9DyBAaVXzSyVSvaFgWswaLh6xAxYwCLWOpQfy1OuUp3fbxb7GGY9LnAbX/Wic38xoWrhOkdeJcyfugRhQ0Vs/RwXVLV94ivsiDm04J5BKXeeLIwDr519hQW8L4MxPda76mwvXx52xfsC4C8qEiuC0OCpw4OJR3YgFhZc6EBMYAQWKd/WTCzcja3yqqpr3Gi4uQGs1yD7FtOSdYzJDJ7zpNMZHsSjvE4Ybg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzFCySBau2bZmE8334JJ6H6sO2BpIfwAdZZj1ByL3VM=; b=4EfoLVLBpuEh508hxIETGhVRe932ihmpGPqiZwQExM0HnsHRByHwNiXFtuF54A8TujRimjb5kSeUExxqOxCdgFwH3tSxmBPFwxVAcR42j41rgnCsg6hOw1r+w7B6O9nE5/T8l51I03V34kiCEQzS0DtVf8ZYHTrgA+zBOELJlLgcDAHFqfUsTt2G+h22StZKQwO99TeUeMtbcNcZOI/TgqAssPMyLhjaVxbOiVhWo0RMTq3IQhQhXDz3/NGEYZznr8MKqF9sPJhU42dFlH0KYKzuIgZyI3uqOFbAZu05DTLRdMYHAL9Jzd4fzChUpmdJy74BLVYANUQ4Dcc2uP7wXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6bba8b70-c4a8-92e9-58f2-1a8c3288ae85@suse.com> Date: Thu, 8 Sep 2022 10:22:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 1/6] xen/x86: Provide helpers for common code to access acpi_numa Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-2-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220902033121.540328-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8794:EE_ X-MS-Office365-Filtering-Correlation-Id: de0d97a3-40e9-422c-7028-08da91734662 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kq5Btx84FefCyN07JRUrCkN6PuVH9TKxRqGDIBCVbXM6Rh4RNq7pBuZMub6I1Mb5CC7qE2uQLDuqRud4CD84HyYsH15GSwta9UiAuZMd0jKc/Cn6Tl41wLEm+KiWZ95NRKr9TldtrdM67Af8PP2TXpSref7oTjI4aKSgBmzdmsmpEWBYPOPSRDSTuhCZpyOcMD7+oM2nmS5hjNentgdpmzeiSm0q5HEGud50riFppJ0xMAsuR/JxDCC8NbzVeMOPK5cTY2ukS0Fu3ebilcdcTmkb/gfzrAxamhgzwv1WgUE4tetQbRf60MRR6fDnmYJghL3nCtdhABt/2kA5O//CPuj00uTfvortDxGC3q2QSeQB4/P85yfcaKwXL/ex20ga9er7feisE+AyAXvFT/1iGrJmrrda/U5UaeJ3xEoMkBNXuON2x6TRMrGw8PwnvJCvIlbtqk6ouQ4ebZe+kmd29gqYtQTEkAsuyJcIKPy64XCr8z5xcQ4vBma2TQRqnxbcNX3g/mDqQuUy5yew2Lplydx0ergI6lbJyWC31IOsU0PxuIEACMNVBD+GXF5YrnirP1aQ9lPCfWybg+yZaprmigCMDmqvphJb3YAYTrD8KizQGxcUTaTucliWAtkOFtk8kZXrsYSUUjwI1ahKW2zYHUn5D6+kzF1qHS3L5AbhIdi/xQ0OKT7QGMfanMBQs9r+mvyKlrgvpNGa5Hag89OmLsIItM7HWkyaSUjA63IDL1H6K7oe9eMbcx8LpJWSaC7oL6KDNgOWxmASEq6rzTEZtk3n94h/wXXGknDQGJQpmFA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(376002)(136003)(396003)(346002)(83380400001)(186003)(2616005)(41300700001)(6486002)(478600001)(86362001)(6666004)(6512007)(31696002)(26005)(53546011)(38100700002)(6506007)(316002)(54906003)(6916009)(8936002)(2906002)(31686004)(4326008)(8676002)(66556008)(66476007)(36756003)(66946007)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHN2cHFlSTRxMW53Mzd4V2d6SnRhQ2VxNXFYc21nWHVhTmNMdzNnUzBpTzl4?= =?utf-8?B?V1ZZbFMwOWRWNlRhckhlbE5pYk5zdC9xSG4yN1pRcnJJSTFpQndjdDhiR0Jt?= =?utf-8?B?SGN0VndINUQ2UjRsa2V6MU4zK3JzUXhvUjdmcUR0QmhEbmZXZDVWV0QzcHlJ?= =?utf-8?B?bGgrYnBiOE5oVFMxQnNCNFNEUzZUUFpwRW1yZEMwZHpoRUxWenh1Zm1yZGQv?= =?utf-8?B?bUNEbDVoaWQ2akZmeGR0UVB1L2VyYi9HRVhZbVdyTEJRT0JpdnFUZHFsN2xZ?= =?utf-8?B?MVRDd1NtbkU4ZzdCYW9uQ0k2M2NsNGxVdDBiL2FUUTFzdkpQUkY5djkzMkxE?= =?utf-8?B?NVdUZG5OYlQyTFpJbGFITEkxQkZqWHE3a3k2N09aQkEyNzNydXRnOStHWlkz?= =?utf-8?B?VC9TTGZyNVNDejd6SjAyOWRmOGVPNldkUXVkVTFqcS9TbzdxanhnMjdudmta?= =?utf-8?B?TGMwNzk2Tm4wQmJ2cEYwZzlmTW5kTHRiNXVtdHNkMzkrWlVHa3JHTjhWTFpT?= =?utf-8?B?bWNBY0JHM00rZjJBQ1NzbDNSYjhWS1pSczQ2WVhKODBaWTdUUklaLzlSSEh1?= =?utf-8?B?QnRENXVWV3FTWVI2K1Y1WEZEajJqRWtnNFcvUkszTUdMNnJpVkZEK1poeXRE?= =?utf-8?B?M2pjd2daSkV5L3oyV1BzMnVtc21MWGtRandabU0xWlRhK2d3Rzk5bTJsTDM4?= =?utf-8?B?dU5PRWFIb3VZZEJKN3R3MjlHZUdxRVA2OWl5TWl5NkdqK1IrRWpWMDRwaU1i?= =?utf-8?B?QmJoYWxWU2R1V0p0UGF1dTFsTmhWOHBTRWl2OVhEU3ZPUG1TUkdZZ3RVZ2RS?= =?utf-8?B?K2JmSURzOVpmWXJFUFI1ZjJDOFRHeWdTeVZKQk9zWFhzNW5POVNQRi9GeTBD?= =?utf-8?B?MWYxOFhGd2pzYmlrOXhMc29SaUJpT0w0TXYrQlJwRVFtM2hRNUVTenY2UlBj?= =?utf-8?B?Z3VQVDd1bEc0UXErcmFXSEFnZHA1Q3ZBOThDakpIY0NCMC9xR1gzek9DdVdU?= =?utf-8?B?NkExUVlFYU1uWUZ5dWI2ZFREU1NNamx5ZEtlTVFRM3dCL2RvbUhBTzFQL1E2?= =?utf-8?B?NEhFSUNvV3QrRW54cVhrQzhmVjV6aVpGVmtKR0FTazZ2Q3J2NGNNdnJCUnZV?= =?utf-8?B?YkdXT2hLSnhVa2ZBYjhWZ3V5OG1jWHZQSjBsRExSUFl1Wjk4UUNJVWhEaXEy?= =?utf-8?B?VEg3VE9DcGxienpUWksrYnI3SGdTcFdYdzRUZWNhS3NuQXFUWHNtWG9nYlJT?= =?utf-8?B?czRFME5OVldWT0NremNWZXZZamVacEttanRrTlBoQ3F0VjdsVEFSckVmTVNI?= =?utf-8?B?VVM2bXYvOU5nVktZMXFSWmEzNmxFdy9VbGtJUGRucXVkMFczejZOWlhabkdl?= =?utf-8?B?U3VHRllISVRuZkZaY1R4clBMRm9EeFhnL2h5UlM4MWdVWHVkM1d1eSs3b25h?= =?utf-8?B?clduS2c0aGxKakJ4a1N3SzRySmxmaE12OStyVGlVZ3NORWt2NWFGYXlxeWVw?= =?utf-8?B?Unp2UG9sZC8vK2RYVHJxdjZRMk54dk94aWtWUDRFNG9lc2YrTldFK1BPeGk0?= =?utf-8?B?ZnBOL3A1c3VoOUM5aVFZNHJwaFhWZ0dBS0Fub0hRTTRTVjljNThDc3hIVW1V?= =?utf-8?B?VFNGemIzeTFoR0lhSDZlYjdUUTAxOWVJbGtSaUhCTDhhbkVXSUJLK2lzSzlK?= =?utf-8?B?TFVLMXgweGROdFNadW4xZ1hFc1AwU0N0RFlhZXJVZXFINjdwOFV0cWlxc2Z1?= =?utf-8?B?YUlpdDdmSlkxWExVR2txbkFnd0xNa2laeEw4VVZyakh4T3hwcytiU3A1a0JF?= =?utf-8?B?UEQ4WjMxQXIxQmRGaHV5NE9MY0xTVGszRkg4Z3oyWFhwc1VQeXRYcEc1MU1v?= =?utf-8?B?dnNEQlpKNFJTbkJ2dG1KeDdSK1BjOGVDaFpJeTJJM0J6Y3FNMDBjalVKNWhJ?= =?utf-8?B?UFN3ZVJCVnNOZGVCUzdWclBZTFNzQURmV2tuVWUrWlJzL21PanRmditYd1I2?= =?utf-8?B?M1JDUXZQTkkrdS9HL0dIS09DcWJyMGxkcnV0ZklvTGVoc0VNelN1UnZkNERu?= =?utf-8?B?RkJlR0xzL0ZVOTc0Z2ZLNmhFU3FDeFRYdnN4djI0aU5MV2pQVXJPUlpJazdU?= =?utf-8?Q?bmMs5gFvDzAaNb/SH2oKDmcBr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: de0d97a3-40e9-422c-7028-08da91734662 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 08:22:32.6812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hx2y5kGjHgqAe4Q9Pw2vdN8XLk6+y3ECJwEQxIccZgnbdRXnmhUEMCmVc82XvU1BoxCvzzBVBUp0FGneoYoASg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8794 On 02.09.2022 05:31, Wei Chen wrote: > acpi_numa is a specific NUMA switch for ACPI NUMA implementation. > Other NUMA implementation may not need this switch. But this switch is > not only used by ACPI code, it is also used directly in some general > NUMA logic code. So far this hasn't caused any problem because Xen only > has x86 implementing ACPI NUMA, but now Arm is implementing device tree > based NUMA. Accesssing acpi_numa directly in some functions will be a > block of reusing NUMA common code. It is also difficult for us to replace > it with a new generic switch, because it is hard to prove that the new > switch states can guarantee the original code will work correctly. > > So in this patch, we provide two helpers for common code to update and > get states of acpi_numa. And other new NUMA implementations just need > to provide the same helpers for common code. In this case, the generic > NUMA logic code can be reused by all NUMA implementations. > > Signed-off-by: Wei Chen Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402831.644720 (Exim 4.92) (envelope-from ) id 1oWDDr-0006xC-Dh; Thu, 08 Sep 2022 08:49:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402831.644720; Thu, 08 Sep 2022 08:49:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDDr-0006x5-Ag; Thu, 08 Sep 2022 08:49:19 +0000 Received: by outflank-mailman (input) for mailman id 402831; Thu, 08 Sep 2022 08:49:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDDq-0006wz-E3 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f3e9fd3-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:49:17 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EBF5D33D05; Thu, 8 Sep 2022 08:49:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 941161322C; Thu, 8 Sep 2022 08:49:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id C9HhIoysGWM1NgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f3e9fd3-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kuOhhuYM01X1WNCSJC9RpxAFxvtKfmpSxPcD/Q8jFK4=; b=YW9FOLRweC9p/pRp1PBv2+vTs9HdNmit7aXJKl9v4S/U9PWYWyRCGPpfjzECveNyNbo99i brf7ewuLri/vyabba3j548/G1hE0WUOkgA/4ViIkZFJRbi4OtwJKRqiDEpZ5f8EcgOaYrG A4uk+5AkoDk8LM/c+G5zDCgleAJOaYU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra Subject: [PATCH v3 00/10] x86: make pat and mtrr independent from each other Date: Thu, 8 Sep 2022 10:49:04 +0200 Message-Id: <20220908084914.21703-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today PAT can't be used without MTRR being available, unless MTRR is at least configured via CONFIG_MTRR and the system is running as Xen PV guest. In this case PAT is automatically available via the hypervisor, but the PAT MSR can't be modified by the kernel and MTRR is disabled. The same applies to a kernel built with no MTRR support: it won't allow to use the PAT MSR, even if there is no technical reason for that, other than setting up PAT on all cpus the same way (which is a requirement of the processor's cache management) is relying on some MTRR specific code. Fix all of that by: - moving the function needed by PAT from MTRR specific code one level up - reworking the init sequences of MTRR and PAT to be more similar to each other without calling PAT from MTRR code - removing the dependency of PAT on MTRR While working on that I discovered two minor bugs in MTRR code, which are fixed, too. Changes in V3: - replace patch 1 by just adding a comment Changes in V2: - complete rework of the patches based on comments by Boris Petkov - added several patches to the series Juergen Gross (10): x86/mtrr: add comment for set_mtrr_state() serialization x86/mtrr: remove unused cyrix_set_all() function x86/mtrr: replace use_intel() with a local flag x86: move some code out of arch/x86/kernel/cpu/mtrr x86/mtrr: split generic_set_all() x86/mtrr: remove set_all callback from struct mtrr_ops x86/mtrr: simplify mtrr_bp_init() x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init x86/mtrr: add a stop_machine() handler calling only cache_cpu_init() x86: decouple pat and mtrr handling arch/x86/include/asm/cacheinfo.h | 14 +++ arch/x86/include/asm/memtype.h | 5 +- arch/x86/include/asm/mtrr.h | 12 +-- arch/x86/kernel/cpu/cacheinfo.c | 159 +++++++++++++++++++++++++++++ arch/x86/kernel/cpu/common.c | 3 +- arch/x86/kernel/cpu/mtrr/cyrix.c | 34 ------ arch/x86/kernel/cpu/mtrr/generic.c | 107 ++----------------- arch/x86/kernel/cpu/mtrr/mtrr.c | 158 +++++----------------------- arch/x86/kernel/cpu/mtrr/mtrr.h | 5 - arch/x86/kernel/setup.c | 14 +-- arch/x86/kernel/smpboot.c | 9 +- arch/x86/mm/pat/memtype.c | 127 +++++++---------------- arch/x86/power/cpu.c | 3 +- 13 files changed, 265 insertions(+), 385 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402832.644730 (Exim 4.92) (envelope-from ) id 1oWDDy-0007Ft-RV; Thu, 08 Sep 2022 08:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402832.644730; Thu, 08 Sep 2022 08:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDDy-0007Fm-Ol; Thu, 08 Sep 2022 08:49:26 +0000 Received: by outflank-mailman (input) for mailman id 402832; Thu, 08 Sep 2022 08:49:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDDx-0006wz-31 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:25 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23749ad3-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:49:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 235EF1F8A3; Thu, 8 Sep 2022 08:49:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D98F31322C; Thu, 8 Sep 2022 08:49:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FLzdM5OsGWNFNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23749ad3-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FRQlMbR3LekauN/VGAqwz3/4iPTsfJTb9AkfSRaurK0=; b=Hd9Ngqvs9Q7HjcnnFHdEJnluFdjs2Wj0yx7QF7U6WlXYjs7VkdqwdTeiOTJdFoIUG+LQfF 4GbxxQll8c0/5O+q2qlKl7gbNHHZP05WdF57KoK55JwvRKci1L2aeMv9LnUQ4xXNTmGKW3 77gVzi15lfi7uuJQtkiQDGwKbuzddZg= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 01/10] x86/mtrr: add comment for set_mtrr_state() serialization Date: Thu, 8 Sep 2022 10:49:05 +0200 Message-Id: <20220908084914.21703-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a comment how set_mtrr_state() is needing serialization. Suggested-by: Borislav Petkov Signed-off-by: Juergen Gross --- V3: - new patch instead of old patch 1 --- arch/x86/kernel/cpu/mtrr/generic.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 558108296f3c..cd64eab02393 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -684,7 +684,10 @@ static u32 deftype_lo, deftype_hi; /** * set_mtrr_state - Set the MTRR state for this CPU. * - * NOTE: The CPU must already be in a safe state for MTRR changes. + * NOTE: The CPU must already be in a safe state for MTRR changes, including + * measures that only a single CPU can be active in set_mtrr_state() in + * order to not be subject to races for usage of deftype_lo (this is + * accomplished by taking set_atomicity_lock). * RETURNS: 0 if no changes made, else a mask indicating what was changed. */ static unsigned long set_mtrr_state(void) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402833.644742 (Exim 4.92) (envelope-from ) id 1oWDE5-0007aB-40; Thu, 08 Sep 2022 08:49:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402833.644742; Thu, 08 Sep 2022 08:49:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDE5-0007a2-0H; Thu, 08 Sep 2022 08:49:33 +0000 Received: by outflank-mailman (input) for mailman id 402833; Thu, 08 Sep 2022 08:49:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDE3-0007YH-9q for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26d5744a-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:49:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C76C833E62; Thu, 8 Sep 2022 08:49:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 864981322C; Thu, 8 Sep 2022 08:49:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6G+gH5msGWNPNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26d5744a-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LiedMldWeIT3ErqqDfk2VgDsQE5AXBsEeh4EFbNTzw=; b=dA6h0eHWrYiF0CMYreT51+qb9NCmwueVUasUugtAXmGu3ThRWTlmzRxqD8SzKJWgarWEdS i3ezXdBYyLHR8CSDLkAItUepoaL52W8PmI8lBGkqhMgvfxJv2mJ6uUa886ZKjiL+UGgc97 A4gp6eSI1LtslKs0j540ka2u6xHaGpQ= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 02/10] x86/mtrr: remove unused cyrix_set_all() function Date: Thu, 8 Sep 2022 10:49:06 +0200 Message-Id: <20220908084914.21703-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Cyrix CPU specific MTRR function cyrix_set_all() will never be called, as the struct mtrr_ops set_all() callback will only be called in the use_intel() case, which would require the use_intel_if member of struct mtrr_ops to be set, which isn't the case for Cyrix. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/kernel/cpu/mtrr/cyrix.c | 34 -------------------------------- 1 file changed, 34 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/cyrix.c b/arch/x86/kernel/cpu/mtrr/cyrix.c index ca670919b561..c77d3b0a5bf2 100644 --- a/arch/x86/kernel/cpu/mtrr/cyrix.c +++ b/arch/x86/kernel/cpu/mtrr/cyrix.c @@ -234,42 +234,8 @@ static void cyrix_set_arr(unsigned int reg, unsigned long base, post_set(); } -typedef struct { - unsigned long base; - unsigned long size; - mtrr_type type; -} arr_state_t; - -static arr_state_t arr_state[8] = { - {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, - {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL} -}; - -static unsigned char ccr_state[7] = { 0, 0, 0, 0, 0, 0, 0 }; - -static void cyrix_set_all(void) -{ - int i; - - prepare_set(); - - /* the CCRs are not contiguous */ - for (i = 0; i < 4; i++) - setCx86(CX86_CCR0 + i, ccr_state[i]); - for (; i < 7; i++) - setCx86(CX86_CCR4 + i, ccr_state[i]); - - for (i = 0; i < 8; i++) { - cyrix_set_arr(i, arr_state[i].base, - arr_state[i].size, arr_state[i].type); - } - - post_set(); -} - static const struct mtrr_ops cyrix_mtrr_ops = { .vendor = X86_VENDOR_CYRIX, - .set_all = cyrix_set_all, .set = cyrix_set_arr, .get = cyrix_get_arr, .get_free_region = cyrix_get_free_region, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402835.644753 (Exim 4.92) (envelope-from ) id 1oWDE9-0007uq-Bu; Thu, 08 Sep 2022 08:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402835.644753; Thu, 08 Sep 2022 08:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDE9-0007uj-8Q; Thu, 08 Sep 2022 08:49:37 +0000 Received: by outflank-mailman (input) for mailman id 402835; Thu, 08 Sep 2022 08:49:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDE8-0007YH-K8 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a36a548-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:49:35 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 775A433D05; Thu, 8 Sep 2022 08:49:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 366601322C; Thu, 8 Sep 2022 08:49:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 55n+C5+sGWNnNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a36a548-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VO1KJ/u/ib2qUpol38xHlsTfJwgbgZU3CITv1ZXGXRM=; b=edyPxqB/PM+o5arDhm1zEr/7Nmqhgqu4puhUMR8kT0yyu/ppXHK2ygugnxfwiDBwEhN0h6 bZDTdxrW6HUOWxOT5hnD2cOiRa7a3US7XDgtEqeRzYSqgh9ru6SrXfqIIuuuSA0TWZoBlf p7WIfvVqeGBD+fAtya0y9nZyHfzQ8UM= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag Date: Thu, 8 Sep 2022 10:49:07 +0200 Message-Id: <20220908084914.21703-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MTRR code use_intel() is only used in one source file, and the relevant use_intel_if member of struct mtrr_ops is set only in generic_mtrr_ops. Replace use_intel() with a single flag in cacheinfo.c, which can be set when assigning generic_mtrr_ops to mtrr_if. This allows to drop use_intel_if from mtrr_ops, while preparing to support PAT without MTRR. As another preparation for the PAT/MTRR decoupling use a bit for MTRR control and one for PAT control. For now set both bits together, this can be changed later. As the new flag will be set only if mtrr_enabled is set, the test for mtrr_enabled can be dropped at some places. At the same time drop the local mtrr_enabled() function and rename the __mtrr_enabled flag to mtrr_enabled. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/include/asm/cacheinfo.h | 5 +++ arch/x86/kernel/cpu/cacheinfo.c | 3 ++ arch/x86/kernel/cpu/mtrr/generic.c | 1 - arch/x86/kernel/cpu/mtrr/mtrr.c | 58 ++++++++++++++---------------- arch/x86/kernel/cpu/mtrr/mtrr.h | 2 -- 5 files changed, 35 insertions(+), 34 deletions(-) diff --git a/arch/x86/include/asm/cacheinfo.h b/arch/x86/include/asm/cacheinfo.h index 86b2e0dcc4bf..1aeafa9888f7 100644 --- a/arch/x86/include/asm/cacheinfo.h +++ b/arch/x86/include/asm/cacheinfo.h @@ -2,6 +2,11 @@ #ifndef _ASM_X86_CACHEINFO_H #define _ASM_X86_CACHEINFO_H +/* Kernel controls MTRR and/or PAT MSRs. */ +extern unsigned int cache_generic; +#define CACHE_GENERIC_MTRR 0x01 +#define CACHE_GENERIC_PAT 0x02 + void cacheinfo_amd_init_llc_id(struct cpuinfo_x86 *c, int cpu); void cacheinfo_hygon_init_llc_id(struct cpuinfo_x86 *c, int cpu); diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index 66556833d7af..3b05d3ade7a6 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -35,6 +35,9 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_llc_shared_map); /* Shared L2 cache maps */ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_l2c_shared_map); +/* Kernel controls MTRR and/or PAT MSRs. */ +unsigned int cache_generic; + struct _cache_table { unsigned char descriptor; char cache_type; diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index cd64eab02393..81742870ecc5 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -917,7 +917,6 @@ int positive_have_wrcomb(void) * Generic structure... */ const struct mtrr_ops generic_mtrr_ops = { - .use_intel_if = 1, .set_all = generic_set_all, .get = generic_get_mtrr, .get_free_region = generic_get_free_region, diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 2746cac9d8a9..7d7d5bd30219 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -46,6 +46,7 @@ #include #include +#include #include #include #include @@ -58,12 +59,7 @@ #define MTRR_TO_PHYS_WC_OFFSET 1000 u32 num_var_ranges; -static bool __mtrr_enabled; - -static bool mtrr_enabled(void) -{ - return __mtrr_enabled; -} +static bool mtrr_enabled; unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; static DEFINE_MUTEX(mtrr_mutex); @@ -119,11 +115,11 @@ static int have_wrcomb(void) } /* This function returns the number of variable MTRRs */ -static void __init set_num_var_ranges(void) +static void __init set_num_var_ranges(bool use_generic) { unsigned long config = 0, dummy; - if (use_intel()) + if (use_generic) rdmsr(MSR_MTRRcap, config, dummy); else if (is_cpu(AMD) || is_cpu(HYGON)) config = 2; @@ -303,7 +299,7 @@ int mtrr_add_page(unsigned long base, unsigned long size, int i, replace, error; mtrr_type ltype; - if (!mtrr_enabled()) + if (!mtrr_enabled) return -ENXIO; error = mtrr_if->validate_add_page(base, size, type); @@ -451,7 +447,7 @@ static int mtrr_check(unsigned long base, unsigned long size) int mtrr_add(unsigned long base, unsigned long size, unsigned int type, bool increment) { - if (!mtrr_enabled()) + if (!mtrr_enabled) return -ENODEV; if (mtrr_check(base, size)) return -EINVAL; @@ -480,7 +476,7 @@ int mtrr_del_page(int reg, unsigned long base, unsigned long size) unsigned long lbase, lsize; int error = -EINVAL; - if (!mtrr_enabled()) + if (!mtrr_enabled) return -ENODEV; max = num_var_ranges; @@ -540,7 +536,7 @@ int mtrr_del_page(int reg, unsigned long base, unsigned long size) */ int mtrr_del(int reg, unsigned long base, unsigned long size) { - if (!mtrr_enabled()) + if (!mtrr_enabled) return -ENODEV; if (mtrr_check(base, size)) return -EINVAL; @@ -566,7 +562,7 @@ int arch_phys_wc_add(unsigned long base, unsigned long size) { int ret; - if (pat_enabled() || !mtrr_enabled()) + if (pat_enabled() || !mtrr_enabled) return 0; /* Success! (We don't need to do anything.) */ ret = mtrr_add(base, size, MTRR_TYPE_WRCOMB, true); @@ -686,6 +682,7 @@ int __initdata changed_by_mtrr_cleanup; */ void __init mtrr_bp_init(void) { + bool use_generic = false; u32 phys_addr; init_ifs(); @@ -694,6 +691,7 @@ void __init mtrr_bp_init(void) if (boot_cpu_has(X86_FEATURE_MTRR)) { mtrr_if = &generic_mtrr_ops; + use_generic = true; size_or_mask = SIZE_OR_MASK_BITS(36); size_and_mask = 0x00f00000; phys_addr = 36; @@ -755,15 +753,18 @@ void __init mtrr_bp_init(void) } if (mtrr_if) { - __mtrr_enabled = true; - set_num_var_ranges(); + mtrr_enabled = true; + set_num_var_ranges(use_generic); init_table(); - if (use_intel()) { + if (use_generic) { /* BIOS may override */ - __mtrr_enabled = get_mtrr_state(); + mtrr_enabled = get_mtrr_state(); - if (mtrr_enabled()) + if (mtrr_enabled) { mtrr_bp_pat_init(); + cache_generic |= CACHE_GENERIC_MTRR | + CACHE_GENERIC_PAT; + } if (mtrr_cleanup(phys_addr)) { changed_by_mtrr_cleanup = 1; @@ -772,7 +773,7 @@ void __init mtrr_bp_init(void) } } - if (!mtrr_enabled()) { + if (!mtrr_enabled) { pr_info("Disabled\n"); /* @@ -786,10 +787,7 @@ void __init mtrr_bp_init(void) void mtrr_ap_init(void) { - if (!mtrr_enabled()) - return; - - if (!use_intel() || mtrr_aps_delayed_init) + if (!cache_generic || mtrr_aps_delayed_init) return; /* @@ -816,7 +814,7 @@ void mtrr_save_state(void) { int first_cpu; - if (!mtrr_enabled()) + if (!mtrr_enabled) return; first_cpu = cpumask_first(cpu_online_mask); @@ -825,9 +823,7 @@ void mtrr_save_state(void) void set_mtrr_aps_delayed_init(void) { - if (!mtrr_enabled()) - return; - if (!use_intel()) + if (!cache_generic) return; mtrr_aps_delayed_init = true; @@ -838,7 +834,7 @@ void set_mtrr_aps_delayed_init(void) */ void mtrr_aps_init(void) { - if (!use_intel() || !mtrr_enabled()) + if (!cache_generic) return; /* @@ -855,7 +851,7 @@ void mtrr_aps_init(void) void mtrr_bp_restore(void) { - if (!use_intel() || !mtrr_enabled()) + if (!cache_generic) return; mtrr_if->set_all(); @@ -863,10 +859,10 @@ void mtrr_bp_restore(void) static int __init mtrr_init_finialize(void) { - if (!mtrr_enabled()) + if (!mtrr_enabled) return 0; - if (use_intel()) { + if (cache_generic & CACHE_GENERIC_MTRR) { if (!changed_by_mtrr_cleanup) mtrr_state_warn(); return 0; diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.h b/arch/x86/kernel/cpu/mtrr/mtrr.h index 2ac99e561181..88b1c4b6174a 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.h +++ b/arch/x86/kernel/cpu/mtrr/mtrr.h @@ -14,7 +14,6 @@ extern unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; struct mtrr_ops { u32 vendor; - u32 use_intel_if; void (*set)(unsigned int reg, unsigned long base, unsigned long size, mtrr_type type); void (*set_all)(void); @@ -61,7 +60,6 @@ extern u64 size_or_mask, size_and_mask; extern const struct mtrr_ops *mtrr_if; #define is_cpu(vnd) (mtrr_if && mtrr_if->vendor == X86_VENDOR_##vnd) -#define use_intel() (mtrr_if && mtrr_if->use_intel_if == 1) extern unsigned int num_var_ranges; extern u64 mtrr_tom2; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402842.644764 (Exim 4.92) (envelope-from ) id 1oWDEG-0008Uy-MZ; Thu, 08 Sep 2022 08:49:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402842.644764; Thu, 08 Sep 2022 08:49:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEG-0008Up-He; Thu, 08 Sep 2022 08:49:44 +0000 Received: by outflank-mailman (input) for mailman id 402842; Thu, 08 Sep 2022 08:49:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEF-0006wz-Hi for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2da77711-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:49:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3D26733FD7; Thu, 8 Sep 2022 08:49:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E6A411322C; Thu, 8 Sep 2022 08:49:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GrDRNqSsGWOENgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2da77711-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DRcRkPu/cuQ4+jb3CjHl7anl34sikWirFCSMb9iqjCw=; b=R9uWOsAcsHJO4ivmS1UTQAs2/ZkaDvtx2ZVDtw9cjBuHBZnAdWuQR8DkZDqn1+VPQuIJb9 h5h+sqWJTurueXXqK75KSqnJjpUtM7er/fChqqs+53kWKhrP5yAAMVQCkrv3ypQy4k/2xA BR28K+3/v67yaL6xxiix+HOnbX1PqsU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 04/10] x86: move some code out of arch/x86/kernel/cpu/mtrr Date: Thu, 8 Sep 2022 10:49:08 +0200 Message-Id: <20220908084914.21703-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Prepare making PAT and MTRR support independent from each other by moving some code needed by both out of the MTRR specific sources. Signed-off-by: Juergen Gross --- V2: - move code from cpu/common.c to cpu/cacheinfo.c (Boris Petkov) --- arch/x86/include/asm/cacheinfo.h | 3 ++ arch/x86/include/asm/mtrr.h | 4 ++ arch/x86/kernel/cpu/cacheinfo.c | 77 ++++++++++++++++++++++++++++ arch/x86/kernel/cpu/mtrr/generic.c | 81 ++++-------------------------- 4 files changed, 93 insertions(+), 72 deletions(-) diff --git a/arch/x86/include/asm/cacheinfo.h b/arch/x86/include/asm/cacheinfo.h index 1aeafa9888f7..313a6920d0f9 100644 --- a/arch/x86/include/asm/cacheinfo.h +++ b/arch/x86/include/asm/cacheinfo.h @@ -10,4 +10,7 @@ extern unsigned int cache_generic; void cacheinfo_amd_init_llc_id(struct cpuinfo_x86 *c, int cpu); void cacheinfo_hygon_init_llc_id(struct cpuinfo_x86 *c, int cpu); +void cache_disable(void); +void cache_enable(void); + #endif /* _ASM_X86_CACHEINFO_H */ diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 76d726074c16..12a16caed395 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -48,6 +48,8 @@ extern void mtrr_aps_init(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); extern int amd_special_default_mtrr(void); +void mtrr_disable(void); +void mtrr_enable(void); # else static inline u8 mtrr_type_lookup(u64 addr, u64 end, u8 *uniform) { @@ -87,6 +89,8 @@ static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) #define set_mtrr_aps_delayed_init() do {} while (0) #define mtrr_aps_init() do {} while (0) #define mtrr_bp_restore() do {} while (0) +#define mtrr_disable() do {} while (0) +#define mtrr_enable() do {} while (0) # endif #ifdef CONFIG_COMPAT diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index 3b05d3ade7a6..47e2c72fa8a4 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -20,6 +20,8 @@ #include #include #include +#include +#include #include "cpu.h" @@ -1043,3 +1045,78 @@ int populate_cache_leaves(unsigned int cpu) return 0; } + +/* + * Disable and enable caches. Needed for changing MTRRs and the PAT MSR. + * + * Since we are disabling the cache don't allow any interrupts, + * they would run extremely slow and would only increase the pain. + * + * The caller must ensure that local interrupts are disabled and + * are reenabled after cache_enable() has been called. + */ +static unsigned long saved_cr4; +static DEFINE_RAW_SPINLOCK(cache_disable_lock); + +void cache_disable(void) __acquires(cache_disable_lock) +{ + unsigned long cr0; + + /* + * Note that this is not ideal + * since the cache is only flushed/disabled for this CPU while the + * MTRRs are changed, but changing this requires more invasive + * changes to the way the kernel boots + */ + + raw_spin_lock(&cache_disable_lock); + + /* Enter the no-fill (CD=1, NW=0) cache mode and flush caches. */ + cr0 = read_cr0() | X86_CR0_CD; + write_cr0(cr0); + + /* + * Cache flushing is the most time-consuming step when programming + * the MTRRs. Fortunately, as per the Intel Software Development + * Manual, we can skip it if the processor supports cache self- + * snooping. + */ + if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) + wbinvd(); + + /* Save value of CR4 and clear Page Global Enable (bit 7) */ + if (boot_cpu_has(X86_FEATURE_PGE)) { + saved_cr4 = __read_cr4(); + __write_cr4(saved_cr4 & ~X86_CR4_PGE); + } + + /* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */ + count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); + flush_tlb_local(); + + if (boot_cpu_has(X86_FEATURE_MTRR)) + mtrr_disable(); + + /* Again, only flush caches if we have to. */ + if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) + wbinvd(); +} + +void cache_enable(void) __releases(cache_disable_lock) +{ + /* Flush TLBs (no need to flush caches - they are disabled) */ + count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); + flush_tlb_local(); + + if (boot_cpu_has(X86_FEATURE_MTRR)) + mtrr_enable(); + + /* Enable caches */ + write_cr0(read_cr0() & ~X86_CR0_CD); + + /* Restore value of CR4 */ + if (boot_cpu_has(X86_FEATURE_PGE)) + __write_cr4(saved_cr4); + + raw_spin_unlock(&cache_disable_lock); +} diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 81742870ecc5..5ed397f03a87 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -10,6 +10,7 @@ #include #include +#include #include #include #include @@ -396,9 +397,6 @@ print_fixed(unsigned base, unsigned step, const mtrr_type *types) } } -static void prepare_set(void); -static void post_set(void); - static void __init print_mtrr_state(void) { unsigned int i; @@ -450,11 +448,11 @@ void __init mtrr_bp_pat_init(void) unsigned long flags; local_irq_save(flags); - prepare_set(); + cache_disable(); pat_init(); - post_set(); + cache_enable(); local_irq_restore(flags); } @@ -718,80 +716,19 @@ static unsigned long set_mtrr_state(void) return change_mask; } - -static unsigned long cr4; -static DEFINE_RAW_SPINLOCK(set_atomicity_lock); - -/* - * Since we are disabling the cache don't allow any interrupts, - * they would run extremely slow and would only increase the pain. - * - * The caller must ensure that local interrupts are disabled and - * are reenabled after post_set() has been called. - */ -static void prepare_set(void) __acquires(set_atomicity_lock) +void mtrr_disable(void) { - unsigned long cr0; - - /* - * Note that this is not ideal - * since the cache is only flushed/disabled for this CPU while the - * MTRRs are changed, but changing this requires more invasive - * changes to the way the kernel boots - */ - - raw_spin_lock(&set_atomicity_lock); - - /* Enter the no-fill (CD=1, NW=0) cache mode and flush caches. */ - cr0 = read_cr0() | X86_CR0_CD; - write_cr0(cr0); - - /* - * Cache flushing is the most time-consuming step when programming - * the MTRRs. Fortunately, as per the Intel Software Development - * Manual, we can skip it if the processor supports cache self- - * snooping. - */ - if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) - wbinvd(); - - /* Save value of CR4 and clear Page Global Enable (bit 7) */ - if (boot_cpu_has(X86_FEATURE_PGE)) { - cr4 = __read_cr4(); - __write_cr4(cr4 & ~X86_CR4_PGE); - } - - /* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */ - count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); - flush_tlb_local(); - /* Save MTRR state */ rdmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); /* Disable MTRRs, and set the default type to uncached */ mtrr_wrmsr(MSR_MTRRdefType, deftype_lo & ~0xcff, deftype_hi); - - /* Again, only flush caches if we have to. */ - if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) - wbinvd(); } -static void post_set(void) __releases(set_atomicity_lock) +void mtrr_enable(void) { - /* Flush TLBs (no need to flush caches - they are disabled) */ - count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); - flush_tlb_local(); - /* Intel (P6) standard MTRRs */ mtrr_wrmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); - - /* Enable caches */ - write_cr0(read_cr0() & ~X86_CR0_CD); - - /* Restore value of CR4 */ - if (boot_cpu_has(X86_FEATURE_PGE)) - __write_cr4(cr4); - raw_spin_unlock(&set_atomicity_lock); } static void generic_set_all(void) @@ -800,7 +737,7 @@ static void generic_set_all(void) unsigned long flags; local_irq_save(flags); - prepare_set(); + cache_disable(); /* Actually set the state */ mask = set_mtrr_state(); @@ -808,7 +745,7 @@ static void generic_set_all(void) /* also set PAT */ pat_init(); - post_set(); + cache_enable(); local_irq_restore(flags); /* Use the atomic bitops to update the global mask */ @@ -839,7 +776,7 @@ static void generic_set_mtrr(unsigned int reg, unsigned long base, vr = &mtrr_state.var_ranges[reg]; local_irq_save(flags); - prepare_set(); + cache_disable(); if (size == 0) { /* @@ -858,7 +795,7 @@ static void generic_set_mtrr(unsigned int reg, unsigned long base, mtrr_wrmsr(MTRRphysMask_MSR(reg), vr->mask_lo, vr->mask_hi); } - post_set(); + cache_enable(); local_irq_restore(flags); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402843.644775 (Exim 4.92) (envelope-from ) id 1oWDEL-0000Zf-30; Thu, 08 Sep 2022 08:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402843.644775; Thu, 08 Sep 2022 08:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEK-0000ZT-W2; Thu, 08 Sep 2022 08:49:48 +0000 Received: by outflank-mailman (input) for mailman id 402843; Thu, 08 Sep 2022 08:49:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEJ-0007YH-Sg for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31023e2e-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:49:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D9BA91F8A3; Thu, 8 Sep 2022 08:49:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 998871322C; Thu, 8 Sep 2022 08:49:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3SRPJKqsGWOONgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31023e2e-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wDKuCN3FDCh/jRyZekgDw7nh9c+GGbOWD1BvZKsc508=; b=h2PK0NZ1OCS5TyVIZcYsjtBHsRLWOMkBd9if1BTrvC/vkd3VVi1cvLtQKNwXctgQ5sCK3K TGiCjxDD+wy/9lXUqGhaVCaDIa5jrJ8TFEjecbmdq7bB0MAIMCeYLcqJpLL+4VD8HLtkIR lLzMA4YQSDiAuBR5sZ3IyyHqAiv/Tqk= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 05/10] x86/mtrr: split generic_set_all() Date: Thu, 8 Sep 2022 10:49:09 +0200 Message-Id: <20220908084914.21703-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Split generic_set_all() into multiple parts, while moving the main function body into cacheinfo.c. This prepares the support of PAT without needing MTRR support by moving the main function body of generic_set_all() into cacheinfo.c while renaming it to cache_cpu_init(). The MTRR specific parts are moved into a dedicated small function called by cache_cpu_init(). The PAT and MTRR specific functions are called conditionally based on the cache_generic bit settings. The setting of smp_changes_mask is merged into the (new) function mtrr_generic_set_state() used to call set_mtrr_state(). It was probably split in ancient times, as atomic operations while running uncached might be quite expensive, but OTOH only systems with a broken BIOS should ever require to set any bit in smp_changes_mask, so just hurting those devices with a penalty of a few microseconds during boot shouldn't be a real issue. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/include/asm/cacheinfo.h | 1 + arch/x86/include/asm/mtrr.h | 2 ++ arch/x86/kernel/cpu/cacheinfo.c | 19 +++++++++++++++++++ arch/x86/kernel/cpu/mtrr/generic.c | 15 ++------------- 4 files changed, 24 insertions(+), 13 deletions(-) diff --git a/arch/x86/include/asm/cacheinfo.h b/arch/x86/include/asm/cacheinfo.h index 313a6920d0f9..563d9cb5fcf5 100644 --- a/arch/x86/include/asm/cacheinfo.h +++ b/arch/x86/include/asm/cacheinfo.h @@ -12,5 +12,6 @@ void cacheinfo_hygon_init_llc_id(struct cpuinfo_x86 *c, int cpu); void cache_disable(void); void cache_enable(void); +void cache_cpu_init(void); #endif /* _ASM_X86_CACHEINFO_H */ diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 12a16caed395..986249a2b9b6 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -50,6 +50,7 @@ extern int mtrr_trim_uncached_memory(unsigned long end_pfn); extern int amd_special_default_mtrr(void); void mtrr_disable(void); void mtrr_enable(void); +void mtrr_generic_set_state(void); # else static inline u8 mtrr_type_lookup(u64 addr, u64 end, u8 *uniform) { @@ -91,6 +92,7 @@ static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) #define mtrr_bp_restore() do {} while (0) #define mtrr_disable() do {} while (0) #define mtrr_enable() do {} while (0) +#define mtrr_generic_set_state() do {} while (0) # endif #ifdef CONFIG_COMPAT diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index 47e2c72fa8a4..36378604ec61 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -1120,3 +1120,22 @@ void cache_enable(void) __releases(cache_disable_lock) raw_spin_unlock(&cache_disable_lock); } + +void cache_cpu_init(void) +{ + unsigned long flags; + + local_irq_save(flags); + cache_disable(); + + /* Set MTRR state. */ + if (cache_generic & CACHE_GENERIC_MTRR) + mtrr_generic_set_state(); + + /* Set PAT. */ + if (cache_generic & CACHE_GENERIC_PAT) + pat_init(); + + cache_enable(); + local_irq_restore(flags); +} diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 5ed397f03a87..fc7b2d952737 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -731,30 +731,19 @@ void mtrr_enable(void) mtrr_wrmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); } -static void generic_set_all(void) +void mtrr_generic_set_state(void) { unsigned long mask, count; - unsigned long flags; - - local_irq_save(flags); - cache_disable(); /* Actually set the state */ mask = set_mtrr_state(); - /* also set PAT */ - pat_init(); - - cache_enable(); - local_irq_restore(flags); - /* Use the atomic bitops to update the global mask */ for (count = 0; count < sizeof(mask) * 8; ++count) { if (mask & 0x01) set_bit(count, &smp_changes_mask); mask >>= 1; } - } /** @@ -854,7 +843,7 @@ int positive_have_wrcomb(void) * Generic structure... */ const struct mtrr_ops generic_mtrr_ops = { - .set_all = generic_set_all, + .set_all = cache_cpu_init, .get = generic_get_mtrr, .get_free_region = generic_get_free_region, .set = generic_set_mtrr, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:49:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:49:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402849.644786 (Exim 4.92) (envelope-from ) id 1oWDER-00014B-D4; Thu, 08 Sep 2022 08:49:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402849.644786; Thu, 08 Sep 2022 08:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDER-00013z-96; Thu, 08 Sep 2022 08:49:55 +0000 Received: by outflank-mailman (input) for mailman id 402849; Thu, 08 Sep 2022 08:49:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEP-0006wz-Tf for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:53 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 346543ef-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:49:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 89A5B33F94; Thu, 8 Sep 2022 08:49:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4CCAE1322C; Thu, 8 Sep 2022 08:49:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ruKREbCsGWOhNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 346543ef-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626992; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AK0xnhmONoj6SWZdOLxCXFAFolXEMYRwZt1AE6WG6+c=; b=N7SWxEY1Nxinf5oY8ozKdSycmxxl6tGAzlljcCZo75TjrJ9L2p7SsXIGDqaIpihBzDBBSs 8fPZMq37zym4S4TD1VvogFt7MuxJSIubiiSR/dxMUy0onD/5zeq9MCRObKg2coYuJAUx1b wtKDvCdDdoU3onHN7crEvL4RiCjlRCQ= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 06/10] x86/mtrr: remove set_all callback from struct mtrr_ops Date: Thu, 8 Sep 2022 10:49:10 +0200 Message-Id: <20220908084914.21703-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using an indirect call to mtrr_if->set_all just call the only possible target cache_cpu_init() directly. This enables to remove the set_all callback from struct mtrr_ops. Signed-off-by: Juergen Gross --- arch/x86/kernel/cpu/mtrr/generic.c | 1 - arch/x86/kernel/cpu/mtrr/mtrr.c | 10 +++++----- arch/x86/kernel/cpu/mtrr/mtrr.h | 2 -- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index fc7b2d952737..5f83ee865def 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -843,7 +843,6 @@ int positive_have_wrcomb(void) * Generic structure... */ const struct mtrr_ops generic_mtrr_ops = { - .set_all = cache_cpu_init, .get = generic_get_mtrr, .get_free_region = generic_get_free_region, .set = generic_set_mtrr, diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 7d7d5bd30219..9609a0d235f8 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -165,15 +165,15 @@ static int mtrr_rendezvous_handler(void *info) * saved, and we want to replicate that across all the cpus that come * online (either at the end of boot or resume or during a runtime cpu * online). If we're doing that, @reg is set to something special and on - * all the cpu's we do mtrr_if->set_all() (On the logical cpu that + * all the cpu's we do cache_cpu_init() (On the logical cpu that * started the boot/resume sequence, this might be a duplicate - * set_all()). + * cache_cpu_init()). */ if (data->smp_reg != ~0U) { mtrr_if->set(data->smp_reg, data->smp_base, data->smp_size, data->smp_type); } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { - mtrr_if->set_all(); + cache_cpu_init(); } return 0; } @@ -768,7 +768,7 @@ void __init mtrr_bp_init(void) if (mtrr_cleanup(phys_addr)) { changed_by_mtrr_cleanup = 1; - mtrr_if->set_all(); + cache_cpu_init(); } } } @@ -854,7 +854,7 @@ void mtrr_bp_restore(void) if (!cache_generic) return; - mtrr_if->set_all(); + cache_cpu_init(); } static int __init mtrr_init_finialize(void) diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.h b/arch/x86/kernel/cpu/mtrr/mtrr.h index 88b1c4b6174a..3b1883185185 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.h +++ b/arch/x86/kernel/cpu/mtrr/mtrr.h @@ -16,8 +16,6 @@ struct mtrr_ops { u32 vendor; void (*set)(unsigned int reg, unsigned long base, unsigned long size, mtrr_type type); - void (*set_all)(void); - void (*get)(unsigned int reg, unsigned long *base, unsigned long *size, mtrr_type *type); int (*get_free_region)(unsigned long base, unsigned long size, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:50:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:50:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402857.644797 (Exim 4.92) (envelope-from ) id 1oWDEW-0001cA-Lc; Thu, 08 Sep 2022 08:50:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402857.644797; Thu, 08 Sep 2022 08:50:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEW-0001c1-IE; Thu, 08 Sep 2022 08:50:00 +0000 Received: by outflank-mailman (input) for mailman id 402857; Thu, 08 Sep 2022 08:49:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEV-0007YH-2W for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:49:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37bca8ba-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:49:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2B74D1F6E6; Thu, 8 Sep 2022 08:49:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E54EB1322C; Thu, 8 Sep 2022 08:49:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LLrONrWsGWOsNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:49:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37bca8ba-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662626998; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vyv3zMH0pPEDEqZnbB8cB4qvjHdxz6bU2S4iMof2iU=; b=SEYuyVYAiGYA9+UltCd0MYfXzFBYTsvw9Bi5LUrNSO2FubjQW9gviWFEZqUpGUzGRpU4+R 7WD268pd50zpFeZdEAHIjbwHnPHawqapCJpOg1++jiCAIVqSt2qpJsGlb1W+zDDpzxeKr9 pHOjHz1csrLZhBP7zwgR6hjoyQmA6cA= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init() Date: Thu, 8 Sep 2022 10:49:11 +0200 Message-Id: <20220908084914.21703-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In case of the generic cache interface being used (Intel CPUs or a 64-bit system), the initialization sequence of the boot CPU is more complicated as necessary: - check if MTRR enabled, if yes, call mtrr_bp_pat_init() which will disable caching, set the PAT MSR, and reenable caching - call mtrr_cleanup(), in case that changed anything, call cache_cpu_init() doing the same caching disable/enable dance as above, but this time with setting the (modified) MTRR state (even if MTRR was disabled) AND setting the PAT MSR (again even with disabled MTRR) The sequence can be simplified a lot while removing potential inconsistencies: - check if MTRR enabled, if yes, call mtrr_cleanup() and then cache_cpu_init() This ensures to: - no longer disable/enable caching more than once - avoid to set MTRRs and/or the PAT MSR on the boot processor in case of MTRR cleanups even if MTRRs meant to be disabled With that mtrr_bp_pat_init() can be removed. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/kernel/cpu/mtrr/generic.c | 14 -------------- arch/x86/kernel/cpu/mtrr/mtrr.c | 7 ++----- arch/x86/kernel/cpu/mtrr/mtrr.h | 1 - 3 files changed, 2 insertions(+), 20 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 5f83ee865def..b15634e5ad44 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -442,20 +442,6 @@ static void __init print_mtrr_state(void) pr_debug("TOM2: %016llx aka %lldM\n", mtrr_tom2, mtrr_tom2>>20); } -/* PAT setup for BP. We need to go through sync steps here */ -void __init mtrr_bp_pat_init(void) -{ - unsigned long flags; - - local_irq_save(flags); - cache_disable(); - - pat_init(); - - cache_enable(); - local_irq_restore(flags); -} - /* Grab all of the MTRR state for this CPU into *state */ bool __init get_mtrr_state(void) { diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 9609a0d235f8..956838bb4481 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -761,13 +761,10 @@ void __init mtrr_bp_init(void) mtrr_enabled = get_mtrr_state(); if (mtrr_enabled) { - mtrr_bp_pat_init(); cache_generic |= CACHE_GENERIC_MTRR | CACHE_GENERIC_PAT; - } - - if (mtrr_cleanup(phys_addr)) { - changed_by_mtrr_cleanup = 1; + changed_by_mtrr_cleanup = + mtrr_cleanup(phys_addr); cache_cpu_init(); } } diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.h b/arch/x86/kernel/cpu/mtrr/mtrr.h index 3b1883185185..c98928ceee6a 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.h +++ b/arch/x86/kernel/cpu/mtrr/mtrr.h @@ -50,7 +50,6 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt); void fill_mtrr_var_range(unsigned int index, u32 base_lo, u32 base_hi, u32 mask_lo, u32 mask_hi); bool get_mtrr_state(void); -void mtrr_bp_pat_init(void); extern void __init set_mtrr_ops(const struct mtrr_ops *ops); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:53:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:53:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402879.644807 (Exim 4.92) (envelope-from ) id 1oWDHl-000428-4r; Thu, 08 Sep 2022 08:53:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402879.644807; Thu, 08 Sep 2022 08:53:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHl-000421-2K; Thu, 08 Sep 2022 08:53:21 +0000 Received: by outflank-mailman (input) for mailman id 402879; Thu, 08 Sep 2022 08:53:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHj-00041V-Ml for xen-devel@lists.xen.org; Thu, 08 Sep 2022 08:53:19 +0000 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [2607:f8b0:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae351f2c-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:53:18 +0200 (CEST) Received: by mail-pf1-x433.google.com with SMTP id j12so4797663pfi.11 for ; Thu, 08 Sep 2022 01:53:17 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id a5-20020a631a05000000b0042aca53b4cesm12224826pga.70.2022.09.08.01.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:53:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae351f2c-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=xGa3uC0LWpY1eD3WQacLY+7N8nGdt9PnSFaO37iASVk=; b=di6Svf21bJV7RRzsBtgxOODwz0k1O2WyKc68rnXcm8Nb9b8cGhWRtslEXDWeYXQ6NI hmMpg4Fx8ZpBuAXRbqvLbga6fiJt02ZYVCwUAaJJCY1xCFFYv7MJVtzXp3+n8swMJ0kO GzunWT9GahLv8EGaUY++PaG/SdGiJEslezuTGnHhdy48t+id8W5DhCYc1T3Hwir9LHbQ ztCxPg/84ZBcoXqCTG5HTlwLZDpymohQEU/BHX8vTpDiLL/b5RaDtEu/x67TcLeFZiyS 6zP2yDOBy71cNSjGpGaUfvxpCBA7TdMYrGCWwVxg1YlEjOAxrNIltGe7mE9pvSkXavQG suiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=xGa3uC0LWpY1eD3WQacLY+7N8nGdt9PnSFaO37iASVk=; b=bvjmKfYkm/uFi5aS0FYvyIve3Zgu5NaSif192GarWYXosFRp2UEX5fx0C+zrTzRp1A MyV2+kdWwucnNl93ReegM1sV2rEefL0ycPTIrNcR3FznybBMwgP9qR/gJuhU88Nl2bjQ +jkWvvWj8PEg7q7R66+2siB/pNI8xlqS42QotWe1HKlSOEoDYFOGJexoyW8rhBDCXZmS eoBWJAQehDISHghIv+EdEAd1GWB2qvMcbzT3mbq5Pe9YD+sLvXJuCVl40U8Ok5WAsbJb HvoKhxN0oRaOORgTs5O4074QlJRZ7a0mD69HHp7cwfZLPSnrfDeEO6R4/wBeLD7ZYBzs 1fHQ== X-Gm-Message-State: ACgBeo2rwC+nOt7TugpGL3CfDsOqfEVl4PlGggCxSVNGJMgX6UemkIkU 4xAeCbUyUAeSUF8LY0sLx5GQEs1QXFhedQ== X-Google-Smtp-Source: AA6agR5piNhUBkvnWaDtBb4tOPKnULctTEjTnRVrpWN2aJsq/irxqJlaWnyfsPMA0ONiQFCQWeFlFw== X-Received: by 2002:a63:6cc1:0:b0:42b:d2c5:74a2 with SMTP id h184-20020a636cc1000000b0042bd2c574a2mr6831569pgc.420.1662627196423; Thu, 08 Sep 2022 01:53:16 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH V6 0/3] libxl: arm: Make generic code independent of disk device Date: Thu, 8 Sep 2022 14:22:58 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, This was earlier sent as part of a patch series [1] adding support for GPIO/I2C virtio devices. The device specific patches would require some rework and possibly several versions, and so this series separates out the generic independent patches into a series of their own. This series makes some of the generic code independent of the disk device, since it can be used for other device types later on. Rebased over staging branch from today. V5->V6: - Separated into a patch series of their own. - Updated commit log of 1st patch to cover all changes. - Rename make_virtio_mmio_node_simple() as make_virtio_mmio_node(). - New patch 3/3, separated code from device specific patch. -- Viresh Viresh Kumar (3): libxl: arm: Create alloc_virtio_mmio_params() libxl: arm: Split make_virtio_mmio_node() libxl: arm: make creation of iommu node independent of disk device tools/libs/light/libxl_arm.c | 83 +++++++++++++++++++++++++----------- 1 file changed, 57 insertions(+), 26 deletions(-) -- 2.31.1.272.g89b43f80a514 -- Viresh [1] https://lore.kernel.org/all/cover.1661159474.git.viresh.kumar@linaro.org/ From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:53:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:53:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402880.644819 (Exim 4.92) (envelope-from ) id 1oWDHo-0004Iu-DN; Thu, 08 Sep 2022 08:53:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402880.644819; Thu, 08 Sep 2022 08:53:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHo-0004Ic-9v; Thu, 08 Sep 2022 08:53:24 +0000 Received: by outflank-mailman (input) for mailman id 402880; Thu, 08 Sep 2022 08:53:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHn-0004Hp-5v for xen-devel@lists.xen.org; Thu, 08 Sep 2022 08:53:23 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [2607:f8b0:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0356a2b-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:53:22 +0200 (CEST) Received: by mail-pl1-x62f.google.com with SMTP id b21so4255078plz.7 for ; Thu, 08 Sep 2022 01:53:21 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id h186-20020a62dec3000000b00536b67c6a80sm14202330pfg.109.2022.09.08.01.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:53:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0356a2b-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=g8uTdefvk9Re34ta3Hpj2EM7Z0M3BKhJL7lQL/PEL2M=; b=mBtM7uvNiEiMQLI2MLWBZ6JSOiFTqkssUfJyR7Lxq52+GS4fT+MsWyp1FiV4D9xh7r rtUo196+JZzmyWgL9K/iXKZWKEwh3mW0D+ScWCax7w2DL9kPOUYANXRiaGa1y0+UkvS9 l2OUxIcSpjj4lAUegWK5xEbr01sr4ytlgnTKin8q1FLQDu3YpYbbs00fylMajKkB+FbA KzhXbrrK06bJmmxx7fWmv8y9SNGakoUIvwYs6XaHiLV2pUXsIhL6Dra+0zF0sbP+WLHm bSuiGkRZ2caIfvwA8yGlpzXAWjwF1oRClkh15Oh6MFFlOIsfCSHUMAdM3qY31yn9hdvT mhLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=g8uTdefvk9Re34ta3Hpj2EM7Z0M3BKhJL7lQL/PEL2M=; b=ZhsyVVtnU1tjZXeTO4QpBxDhj1aN+WnzMvm/bc5JO4AWtyRVKmViyCHuCzyZHcT6ta aDQ9ilEgcxymkUCkTVceOgU+0d9x0M8Mx0kiK61BdO0G7V7zm7mkRv9eldQ9Ac7HjbyG VXFfL2eJgzimG9IClZRBsfedQ8Jb2pXY09M/lK2VhLeVBrlABayxWljCzNEQSxczoTo2 zkauHsGnMDamqixHuj5g1I26eBTko33PXgVESpJmwXMNqKvEk8R/accs5TosmBVg0H+5 EhL4zxgyAkNj2iBFCe6ffH/XZQl6MbF5pjiKQmZMQ2+aj0SX0ma2u97j/FHFoLDYZt45 4RGw== X-Gm-Message-State: ACgBeo2Z4U82SEu2F56Ebsx+qWXqcg5WcVW5Cmtm83OP2q05hxtkUac8 LbXACpopS+dH/6p5RxD/FaBPid2sk2HcPw== X-Google-Smtp-Source: AA6agR7ySj8B3HLO3ogrPbMnT+iVySyqolRFoWBUwcMlzqYCix0W79Ex8+UATRIvXkt438fUFUgeFA== X-Received: by 2002:a17:90a:13c8:b0:200:17ca:f183 with SMTP id s8-20020a17090a13c800b0020017caf183mr3010705pjf.104.1662627199819; Thu, 08 Sep 2022 01:53:19 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD , Oleksandr Tyshchenko Subject: [PATCH V6 1/3] libxl: arm: Create alloc_virtio_mmio_params() Date: Thu, 8 Sep 2022 14:22:59 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare for adding support for more device types, create a separate routine to allocate base and irq for a device as the same code will be required for other device types too. Also move updates to virtio_irq and virtio_enabled out of the disk device specific block, as they will depend on other device types too. Suggested-by: Oleksandr Tyshchenko Reviewed-by: Oleksandr Tyshchenko Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 47 +++++++++++++++++++++++++----------- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 1a3ac1646e94..cc30ba124918 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -48,6 +48,24 @@ static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc, uint32_t *virtio_mmio_irq) return irq; } +static int alloc_virtio_mmio_params(libxl__gc *gc, uint64_t *base, + uint32_t *irq, uint64_t *virtio_mmio_base, + uint32_t *virtio_mmio_irq) +{ + *base = alloc_virtio_mmio_base(gc, virtio_mmio_base); + if (!*base) + return ERROR_FAIL; + + *irq = alloc_virtio_mmio_irq(gc, virtio_mmio_irq); + if (!*irq) + return ERROR_FAIL; + + LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE 0x%"PRIx64, *irq, + *base); + + return 0; +} + static const char *gicv_to_string(libxl_gic_version gic_version) { switch (gic_version) { @@ -70,6 +88,7 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, bool vuart_enabled = false, virtio_enabled = false; uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE; uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST; + int rc; /* * If pl011 vuart is enabled then increment the nr_spis to allow allocation @@ -85,20 +104,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, libxl_device_disk *disk = &d_config->disks[i]; if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { - disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); - if (!disk->base) - return ERROR_FAIL; - - disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); - if (!disk->irq) - return ERROR_FAIL; - - if (virtio_irq < disk->irq) - virtio_irq = disk->irq; - virtio_enabled = true; + rc = alloc_virtio_mmio_params(gc, &disk->base, &disk->irq, + &virtio_mmio_base, + &virtio_mmio_irq); - LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, - disk->vdev, disk->irq, disk->base); + if (rc) + return rc; } } @@ -107,8 +118,16 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, * present, make sure that we allocate enough SPIs for them. * The resulting "nr_spis" needs to cover the highest possible SPI. */ - if (virtio_enabled) + if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) { + virtio_enabled = true; + + /* + * Assumes that "virtio_mmio_irq" is the highest allocated irq, which is + * updated from alloc_virtio_mmio_irq() currently. + */ + virtio_irq = virtio_mmio_irq - 1; nr_spis = max(nr_spis, virtio_irq - 32 + 1); + } for (i = 0; i < d_config->b_info.num_irqs; i++) { uint32_t irq = d_config->b_info.irqs[i]; -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:53:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:53:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402881.644830 (Exim 4.92) (envelope-from ) id 1oWDHp-0004a0-Qh; Thu, 08 Sep 2022 08:53:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402881.644830; Thu, 08 Sep 2022 08:53:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHp-0004Zp-Nn; Thu, 08 Sep 2022 08:53:25 +0000 Received: by outflank-mailman (input) for mailman id 402881; Thu, 08 Sep 2022 08:53:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHp-0004Hp-0g for xen-devel@lists.xen.org; Thu, 08 Sep 2022 08:53:25 +0000 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [2607:f8b0:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1dc067c-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:53:24 +0200 (CEST) Received: by mail-pl1-x62e.google.com with SMTP id iw17so10521616plb.0 for ; Thu, 08 Sep 2022 01:53:23 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id m14-20020a170902bb8e00b0017519b86996sm13793459pls.218.2022.09.08.01.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:53:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1dc067c-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=/UEiFJKtm7/4NuvrzhnPo0LaLbvuX390efC9WrRSDDA=; b=wWgUabhPbeJq2hBFiCzFdXfq110UIC+HRSYH4k4bh1bV8dxugymD82lrIUOn94NmRv s0FW+wjGfMw2GIm2DXIuYb2V9zrhWmiO6VhHl++hzYejWaFGRnR+KS36dw2PFqKjWf0E 8WRYpRnyZZR2vHWeLXdhw8uKDCcSBpqswRXY7p2i4U7LWNMOcfW2L9viOsLvz88kzdcT wpCphxw+pJyYzwI3gXt2Y4GEqI3O0OO2W0+67/dUnShjm/IE3+J5rPG00TVoeR2lJHSx 8psrXFdHGoYrlBllLO5rNUsj9eGcvV9y9hCeZOy9asX3DfwwMOI9Lc+EC7DMaoDauxdY z0Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=/UEiFJKtm7/4NuvrzhnPo0LaLbvuX390efC9WrRSDDA=; b=LMVkFl21/V+64rIN2BAvKt36iDR4xAouXqKn0nkMSqgY1Z+5k+wXme6yDGy91hM8C6 tW7wBIjHVAatQcrBF5yqmxscKHVkiIpag+Uy74ID9c00t5vfYA/REco3F2ppM+CfBRbx aLc8fx+JpPgnLkax4KTg3QrjkZ9zW8s+pY0a4UbR7krmeFLh5K90eLYEMsStnxUHr2/N qiQRzKMYHLP6RT8ms5BpXijeWTJAKQUylYkANs2LKdA5v7Faqa5l0xFnc9oSyxpK6rCy 2w6b1WRbOpTDb6QfkJAfmH7Mqs9zNJ22NRYpdioGTX7zU6xF4B6PLEoHniuxh9fGbx76 x25Q== X-Gm-Message-State: ACgBeo2uHul7ZyKyYBJod+rKFmWUKWuum/OVmq2Z5mCqIExYeTfx2Wao H4b2Jefh8ykL116EildX06hGxkMXTlzYsg== X-Google-Smtp-Source: AA6agR44zhvleFny9uTwjI62GkT4G1FygHSVLhOOBlnLa/zEmKAqCg6xfNxPUp/bNyLw2IyO1iNKhQ== X-Received: by 2002:a17:903:40d2:b0:174:e086:c748 with SMTP id t18-20020a17090340d200b00174e086c748mr8259497pld.108.1662627202662; Thu, 08 Sep 2022 01:53:22 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD , Oleksandr Tyshchenko Subject: [PATCH V6 2/3] libxl: arm: Split make_virtio_mmio_node() Date: Thu, 8 Sep 2022 14:23:00 +0530 Message-Id: <0edb5dc1ea3308cf9202e6476ff2797aad953966.1662626550.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit make_virtio_mmio_node() creates the DT node for simple MMIO devices currently, i.e. the ones that don't require any additional properties. In order to allow using it for other complex device types, split the functionality into two, one where the fdt node isn't closed and the other one to create a simple DT node. Reviewed-by: Oleksandr Tyshchenko Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index cc30ba124918..55aee15c10b4 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -907,9 +907,9 @@ static int make_xen_iommu_node(libxl__gc *gc, void *fdt) return 0; } -static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, - uint64_t base, uint32_t irq, - uint32_t backend_domid) +/* The caller is responsible to complete / close the fdt node */ +static int make_virtio_mmio_node_common(libxl__gc *gc, void *fdt, uint64_t base, + uint32_t irq, uint32_t backend_domid) { int res; gic_interrupt intr; @@ -942,10 +942,18 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, if (res) return res; } - res = fdt_end_node(fdt); + return res; +} + +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, uint64_t base, + uint32_t irq, uint32_t backend_domid) +{ + int res; + + res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); if (res) return res; - return 0; + return fdt_end_node(fdt); } static const struct arch_info *get_arch_info(libxl__gc *gc, -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:53:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:53:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402882.644841 (Exim 4.92) (envelope-from ) id 1oWDHt-0004uE-2D; Thu, 08 Sep 2022 08:53:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402882.644841; Thu, 08 Sep 2022 08:53:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHs-0004u3-VO; Thu, 08 Sep 2022 08:53:28 +0000 Received: by outflank-mailman (input) for mailman id 402882; Thu, 08 Sep 2022 08:53:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDHs-00041V-0U for xen-devel@lists.xen.org; Thu, 08 Sep 2022 08:53:28 +0000 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [2607:f8b0:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3829a88-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:53:26 +0200 (CEST) Received: by mail-pg1-x52d.google.com with SMTP id 78so16054808pgb.13 for ; Thu, 08 Sep 2022 01:53:26 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id k15-20020aa7998f000000b0053e9c04757dsm2067450pfh.169.2022.09.08.01.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:53:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3829a88-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=KvygtE56N8zYKSJxBlMmn0X+tKsUv5sphCjxV3H2TI4=; b=WohkmT1BeCvS0E8Wetu+Zk37tJlFt2oJSQpKV+b3jFHbACkodyw/hJgyGjsoSZlxXq rHcd2Roec+M4LP+J/u6QvlYY4x3kECdQHjPklUMGK+3Q9Iz91AR8NtYD2JeMvplDNfJa zC4lBxO7izl7baxR2DE52F2OonJlXP4oKQDr1bTFAb7Zcb4iChJEf7MuUqYU7XKS1sKY 46+/i1+6VS8YfaWjE2YN2Zc/0t6tuqcElgIBVISus5FIC2E5CO3E3cDuhgVs47cCWGLI p8clqR40EALUIXkcklT2O4Qw5vB/I6ymUus+26KLIOip7ydmb6sWVsArmkjh0V2VSIi5 YSMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=KvygtE56N8zYKSJxBlMmn0X+tKsUv5sphCjxV3H2TI4=; b=N+/zuVXR7rOH/Yp8lE3wCfgXBOE+zzBNi2ouAxrJH54+tnpSsnlIDvUKDtVSkrv3tl 1OflqWe/mziM2nrAeBy3l034IURryV5i3oP8RVFR08HgLc/l28zUtoi2dEO2NfVnXXqc F2TtiipVuhl71X+u3vXsvxfsLXBaSgs3X8gwVPr5amx9t4o3iQ1Xb1tSeOknwzhfQn+w mqImg9YwXFeOO40upSRnUdLFZ0++bwCK46yB2ylH4TNsiNcdM/RmQBXix8yYnANz5t74 FBuVdKp2lquu3sb2pGen/0N2JPwx37jDyqmrQQcVeDfUkSJ1Hgxml7d+db7vlKsK90e7 4c8Q== X-Gm-Message-State: ACgBeo1rYXXHjwgoG6AeuBpjjmAV72hzo26GrHWjXoIEveJ/HhGiqrb/ KlqRC0XpTT3p6kwDUuyXJXQsn04OqVTPKg== X-Google-Smtp-Source: AA6agR7rTh0qzn+h0YaGzImMjv1sCcTEZWC+LMNk7f8DZa4Jdj1plGLmSf7Cz36sRy94uaxwxeYcug== X-Received: by 2002:a63:d114:0:b0:429:f039:ccfc with SMTP id k20-20020a63d114000000b00429f039ccfcmr7090714pgg.95.1662627205408; Thu, 08 Sep 2022 01:53:25 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH V6 3/3] libxl: arm: make creation of iommu node independent of disk device Date: Thu, 8 Sep 2022 14:23:01 +0530 Message-Id: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The iommu node will be required for other virtio device types too, not just disk device. Move the call to make_xen_iommu_node(), out of the disk device specific block and rename "iommu_created" variable to "iommu_needed", and set it to true for virtio disk device. Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 55aee15c10b4..2637acafa358 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1157,7 +1157,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, size_t fdt_size = 0; int pfdt_size = 0; libxl_domain_build_info *const info = &d_config->b_info; - bool iommu_created; + bool iommu_needed; unsigned int i; const libxl_version_info *vers; @@ -1265,22 +1265,26 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, if (d_config->num_pcidevs) FDT( make_vpci_node(gc, fdt, ainfo, dom) ); - iommu_created = false; + iommu_needed = false; for (i = 0; i < d_config->num_disks; i++) { libxl_device_disk *disk = &d_config->disks[i]; if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { - if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID && - !iommu_created) { - FDT( make_xen_iommu_node(gc, fdt) ); - iommu_created = true; - } + if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID) + iommu_needed = true; FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, disk->backend_domid) ); } } + /* + * Note, this should be only called after creating all virtio-mmio + * device nodes + */ + if (iommu_needed) + FDT( make_xen_iommu_node(gc, fdt) ); + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:59:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:59:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402916.644852 (Exim 4.92) (envelope-from ) id 1oWDNG-0006X1-Ox; Thu, 08 Sep 2022 08:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402916.644852; Thu, 08 Sep 2022 08:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDNG-0006Wu-M2; Thu, 08 Sep 2022 08:59:02 +0000 Received: by outflank-mailman (input) for mailman id 402916; Thu, 08 Sep 2022 08:59:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEg-0006wz-Pc for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:50:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e7a08e7-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:50:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 76EAC1F6E6; Thu, 8 Sep 2022 08:50:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2E0CC1322C; Thu, 8 Sep 2022 08:50:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AMwXCsGsGWPbNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:50:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e7a08e7-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662627009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Aec2IFIciy0SMtMy1CqJkYQlSUiM7z4pNHB9RfHgYs=; b=b3mxoISWSaevLeo3XWmtDO6Q3t4KaAeiiEywNs+82a4iKlxfAOSCH+erXsYW0is5zp99i+ ayfDMzqfhbeZQ639ZodmyVemdlO9NaFpGiiyx1PISJgjGGDlnFvOClgK1ZYMS1WS48qzgP yA/IxzX9AEs535XHN4G9qeMCWGQ8rtU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Pavel Machek Subject: [PATCH v3 09/10] x86/mtrr: add a stop_machine() handler calling only cache_cpu_init() Date: Thu, 8 Sep 2022 10:49:13 +0200 Message-Id: <20220908084914.21703-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having a stop_machine() handler for either a specific MTRR register or all state at once, add a handler just for calling cache_cpu_init() if appropriate. Add functions for calling stop_machine() with this handler as well. Add a generic replacements for mtrr_bp_restore() and a wrapper for mtrr_bp_init(). Signed-off-by: Juergen Gross --- V2: - completely new replacement of former patch 2 --- arch/x86/include/asm/cacheinfo.h | 5 +- arch/x86/include/asm/mtrr.h | 4 -- arch/x86/kernel/cpu/cacheinfo.c | 59 +++++++++++++++++++++- arch/x86/kernel/cpu/common.c | 3 +- arch/x86/kernel/cpu/mtrr/mtrr.c | 87 +------------------------------- arch/x86/kernel/setup.c | 3 +- arch/x86/kernel/smpboot.c | 4 +- arch/x86/power/cpu.c | 3 +- 8 files changed, 72 insertions(+), 96 deletions(-) diff --git a/arch/x86/include/asm/cacheinfo.h b/arch/x86/include/asm/cacheinfo.h index e80ed3c523c8..a122a1aad936 100644 --- a/arch/x86/include/asm/cacheinfo.h +++ b/arch/x86/include/asm/cacheinfo.h @@ -14,6 +14,9 @@ void cacheinfo_hygon_init_llc_id(struct cpuinfo_x86 *c, int cpu); void cache_disable(void); void cache_enable(void); -void cache_cpu_init(void); +void cache_bp_init(void); +void cache_bp_restore(void); +void cache_ap_init(void); +void cache_aps_init(void); #endif /* _ASM_X86_CACHEINFO_H */ diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 5d31219c8529..ec73d1e5bafb 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -42,8 +42,6 @@ extern int mtrr_add_page(unsigned long base, unsigned long size, extern int mtrr_del(int reg, unsigned long base, unsigned long size); extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); -extern void mtrr_ap_init(void); -extern void mtrr_aps_init(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); extern int amd_special_default_mtrr(void); @@ -85,8 +83,6 @@ static inline int mtrr_trim_uncached_memory(unsigned long end_pfn) static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) { } -#define mtrr_ap_init() do {} while (0) -#define mtrr_aps_init() do {} while (0) #define mtrr_bp_restore() do {} while (0) #define mtrr_disable() do {} while (0) #define mtrr_enable() do {} while (0) diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index c6e7c93e45e8..4946f93eb16f 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -1121,7 +1122,7 @@ void cache_enable(void) __releases(cache_disable_lock) raw_spin_unlock(&cache_disable_lock); } -void cache_cpu_init(void) +static void cache_cpu_init(void) { unsigned long flags; @@ -1141,3 +1142,59 @@ void cache_cpu_init(void) } bool cache_aps_delayed_init; + +static int cache_rendezvous_handler(void *unused) +{ + if (cache_aps_delayed_init || !cpu_online(smp_processor_id())) + cache_cpu_init(); + + return 0; +} + +void __init cache_bp_init(void) +{ + mtrr_bp_init(); + + if (cache_generic) + cache_cpu_init(); +} + +void cache_bp_restore(void) +{ + if (cache_generic) + cache_cpu_init(); +} + +void cache_ap_init(void) +{ + if (!cache_generic || cache_aps_delayed_init) + return; + + /* + * Ideally we should hold mtrr_mutex here to avoid mtrr entries + * changed, but this routine will be called in cpu boot time, + * holding the lock breaks it. + * + * This routine is called in two cases: + * + * 1. very early time of software resume, when there absolutely + * isn't mtrr entry changes; + * + * 2. cpu hotadd time. We let mtrr_add/del_page hold cpuhotplug + * lock to prevent mtrr entry changes + */ + stop_machine_from_inactive_cpu(cache_rendezvous_handler, NULL, + cpu_callout_mask); +} + +/* + * Delayed cache initialization for all AP's + */ +void cache_aps_init(void) +{ + if (!cache_generic || !cache_aps_delayed_init) + return; + + stop_machine(cache_rendezvous_handler, NULL, cpu_online_mask); + cache_aps_delayed_init = false; +} diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 3e508f239098..fd058b547f8d 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include @@ -1948,7 +1949,7 @@ void identify_secondary_cpu(struct cpuinfo_x86 *c) #ifdef CONFIG_X86_32 enable_sep_cpu(); #endif - mtrr_ap_init(); + cache_ap_init(); validate_apic_and_package_id(c); x86_spec_ctrl_setup_ap(); update_srbds_msr(); diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index a47d46035240..5e8be11d1873 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -70,9 +70,6 @@ static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; const struct mtrr_ops *mtrr_if; -static void set_mtrr(unsigned int reg, unsigned long base, - unsigned long size, mtrr_type type); - void __init set_mtrr_ops(const struct mtrr_ops *ops) { if (ops->vendor && ops->vendor < X86_VENDOR_NUM) @@ -155,25 +152,8 @@ static int mtrr_rendezvous_handler(void *info) { struct set_mtrr_data *data = info; - /* - * We use this same function to initialize the mtrrs during boot, - * resume, runtime cpu online and on an explicit request to set a - * specific MTRR. - * - * During boot or suspend, the state of the boot cpu's mtrrs has been - * saved, and we want to replicate that across all the cpus that come - * online (either at the end of boot or resume or during a runtime cpu - * online). If we're doing that, @reg is set to something special and on - * all the cpu's we do cache_cpu_init() (On the logical cpu that - * started the boot/resume sequence, this might be a duplicate - * cache_cpu_init()). - */ - if (data->smp_reg != ~0U) { - mtrr_if->set(data->smp_reg, data->smp_base, - data->smp_size, data->smp_type); - } else if (cache_aps_delayed_init || !cpu_online(smp_processor_id())) { - cache_cpu_init(); - } + mtrr_if->set(data->smp_reg, data->smp_base, + data->smp_size, data->smp_type); return 0; } @@ -243,19 +223,6 @@ static void set_mtrr_cpuslocked(unsigned int reg, unsigned long base, stop_machine_cpuslocked(mtrr_rendezvous_handler, &data, cpu_online_mask); } -static void set_mtrr_from_inactive_cpu(unsigned int reg, unsigned long base, - unsigned long size, mtrr_type type) -{ - struct set_mtrr_data data = { .smp_reg = reg, - .smp_base = base, - .smp_size = size, - .smp_type = type - }; - - stop_machine_from_inactive_cpu(mtrr_rendezvous_handler, &data, - cpu_callout_mask); -} - /** * mtrr_add_page - Add a memory type region * @base: Physical base address of region in pages (in units of 4 kB!) @@ -764,7 +731,6 @@ void __init mtrr_bp_init(void) CACHE_GENERIC_PAT; changed_by_mtrr_cleanup = mtrr_cleanup(phys_addr); - cache_cpu_init(); } } } @@ -781,27 +747,6 @@ void __init mtrr_bp_init(void) } } -void mtrr_ap_init(void) -{ - if (!cache_generic || cache_aps_delayed_init) - return; - - /* - * Ideally we should hold mtrr_mutex here to avoid mtrr entries - * changed, but this routine will be called in cpu boot time, - * holding the lock breaks it. - * - * This routine is called in two cases: - * - * 1. very early time of software resume, when there absolutely - * isn't mtrr entry changes; - * - * 2. cpu hotadd time. We let mtrr_add/del_page hold cpuhotplug - * lock to prevent mtrr entry changes - */ - set_mtrr_from_inactive_cpu(~0U, 0, 0, 0); -} - /** * mtrr_save_state - Save current fixed-range MTRR state of the first * cpu in cpu_online_mask. @@ -817,34 +762,6 @@ void mtrr_save_state(void) smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); } -/* - * Delayed MTRR initialization for all AP's - */ -void mtrr_aps_init(void) -{ - if (!cache_generic) - return; - - /* - * Check if someone has requested the delay of AP MTRR initialization, - * by doing set_mtrr_aps_delayed_init(), prior to this point. If not, - * then we are done. - */ - if (!cache_aps_delayed_init) - return; - - set_mtrr(~0U, 0, 0, 0); - cache_aps_delayed_init = false; -} - -void mtrr_bp_restore(void) -{ - if (!cache_generic) - return; - - cache_cpu_init(); -} - static int __init mtrr_init_finialize(void) { if (!mtrr_enabled) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 216fee7144ee..e0e185ee0229 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include @@ -1075,7 +1076,7 @@ void __init setup_arch(char **cmdline_p) /* update e820 for memory not covered by WB MTRRs */ if (IS_ENABLED(CONFIG_MTRR)) - mtrr_bp_init(); + cache_bp_init(); else pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index ef7bce21cbe8..ff793f436904 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1445,7 +1445,7 @@ void arch_thaw_secondary_cpus_begin(void) void arch_thaw_secondary_cpus_end(void) { - mtrr_aps_init(); + cache_aps_init(); } /* @@ -1488,7 +1488,7 @@ void __init native_smp_cpus_done(unsigned int max_cpus) nmi_selftest(); impress_friends(); - mtrr_aps_init(); + cache_aps_init(); } static int __initdata setup_possible_cpus = -1; diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c index bb176c72891c..754221c9a1c3 100644 --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -261,7 +262,7 @@ static void notrace __restore_processor_state(struct saved_context *ctxt) do_fpu_end(); tsc_verify_tsc_adjust(true); x86_platform.restore_sched_clock_state(); - mtrr_bp_restore(); + cache_bp_restore(); perf_restore_debug_store(); c = &cpu_data(smp_processor_id()); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:59:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:59:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402922.644863 (Exim 4.92) (envelope-from ) id 1oWDNR-0006tW-1S; Thu, 08 Sep 2022 08:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402922.644863; Thu, 08 Sep 2022 08:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDNQ-0006tM-Ug; Thu, 08 Sep 2022 08:59:12 +0000 Received: by outflank-mailman (input) for mailman id 402922; Thu, 08 Sep 2022 08:59:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEm-0007YH-Eo for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:50:16 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41e5a0d7-2f53-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 10:50:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 353F41F8A3; Thu, 8 Sep 2022 08:50:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D9E4D1322C; Thu, 8 Sep 2022 08:50:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id E07rM8asGWPhNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:50:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41e5a0d7-2f53-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662627015; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OOtMBsGKsiODO1IZdVdZQy6U6TpDMNmPLdot2OAbD6M=; b=P/AdcYFG8Q+ca28IGPz11ED5v9Ycrj6+tV0FRqp+h7EqocIy+ohGzTrBHRUhV7eQ5OXmoo MMkCayjIy3hC3DdVxZcAw2aMpvk6iAXozwGW5xdB+tyEoQ+slVAOpHH+oi2Y2cCIuMbfDH 2fnD/fOy5T32axn6/iULM2Pww+H7zG0= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra Subject: [PATCH v3 10/10] x86: decouple pat and mtrr handling Date: Thu, 8 Sep 2022 10:49:14 +0200 Message-Id: <20220908084914.21703-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today PAT is usable only with MTRR being active, with some nasty tweaks to make PAT usable when running as Xen PV guest, which doesn't support MTRR. The reason for this coupling is, that both, PAT MSR changes and MTRR changes, require a similar sequence and so full PAT support was added using the already available MTRR handling. Xen PV PAT handling can work without MTRR, as it just needs to consume the PAT MSR setting done by the hypervisor without the ability and need to change it. This in turn has resulted in a convoluted initialization sequence and wrong decisions regarding cache mode availability due to misguiding PAT availability flags. Fix all of that by allowing to use PAT without MTRR and by reworking the current PAT initialization sequence to match better with the newly introduced generic cache initialization. This removes the need of the recently added pat_force_disabled flag, so remove the remnants of the patch adding it. Signed-off-by: Juergen Gross --- V2: - former patch 3 completely reworked --- arch/x86/include/asm/memtype.h | 5 +- arch/x86/kernel/cpu/cacheinfo.c | 3 +- arch/x86/kernel/cpu/mtrr/mtrr.c | 13 +--- arch/x86/kernel/setup.c | 13 +--- arch/x86/mm/pat/memtype.c | 127 ++++++++++---------------------- 5 files changed, 45 insertions(+), 116 deletions(-) diff --git a/arch/x86/include/asm/memtype.h b/arch/x86/include/asm/memtype.h index 9ca760e430b9..113b2fa51849 100644 --- a/arch/x86/include/asm/memtype.h +++ b/arch/x86/include/asm/memtype.h @@ -6,9 +6,8 @@ #include extern bool pat_enabled(void); -extern void pat_disable(const char *reason); -extern void pat_init(void); -extern void init_cache_modes(void); +extern void pat_bp_init(void); +extern void pat_cpu_init(void); extern int memtype_reserve(u64 start, u64 end, enum page_cache_mode req_pcm, enum page_cache_mode *ret_pcm); diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index 4946f93eb16f..08130919d55d 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -1135,7 +1135,7 @@ static void cache_cpu_init(void) /* Set PAT. */ if (cache_generic & CACHE_GENERIC_PAT) - pat_init(); + pat_cpu_init(); cache_enable(); local_irq_restore(flags); @@ -1154,6 +1154,7 @@ static int cache_rendezvous_handler(void *unused) void __init cache_bp_init(void) { mtrr_bp_init(); + pat_bp_init(); if (cache_generic) cache_cpu_init(); diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 5e8be11d1873..921f425fe7b3 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -727,24 +727,15 @@ void __init mtrr_bp_init(void) mtrr_enabled = get_mtrr_state(); if (mtrr_enabled) { - cache_generic |= CACHE_GENERIC_MTRR | - CACHE_GENERIC_PAT; + cache_generic |= CACHE_GENERIC_MTRR; changed_by_mtrr_cleanup = mtrr_cleanup(phys_addr); } } } - if (!mtrr_enabled) { + if (!mtrr_enabled) pr_info("Disabled\n"); - - /* - * PAT initialization relies on MTRR's rendezvous handler. - * Skip PAT init until the handler can initialize both - * features independently. - */ - pat_disable("MTRRs disabled, skipping PAT initialization too."); - } } /** diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index e0e185ee0229..aacaa96f0195 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -1075,23 +1075,12 @@ void __init setup_arch(char **cmdline_p) max_pfn = e820__end_of_ram_pfn(); /* update e820 for memory not covered by WB MTRRs */ - if (IS_ENABLED(CONFIG_MTRR)) - cache_bp_init(); - else - pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); - + cache_bp_init(); if (mtrr_trim_uncached_memory(max_pfn)) max_pfn = e820__end_of_ram_pfn(); max_possible_pfn = max_pfn; - /* - * This call is required when the CPU does not support PAT. If - * mtrr_bp_init() invoked it already via pat_init() the call has no - * effect. - */ - init_cache_modes(); - /* * Define random base addresses for memory sections after max_pfn is * defined and before each memory section base is used. diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index 66a209f7eb86..1f62fc40e6df 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -43,6 +43,7 @@ #include #include +#include #include #include #include @@ -60,41 +61,34 @@ #undef pr_fmt #define pr_fmt(fmt) "" fmt -static bool __read_mostly pat_bp_initialized; static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); -static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); -static bool __read_mostly pat_bp_enabled; -static bool __read_mostly pat_cm_initialized; +static u64 __read_mostly pat_msr_val; /* * PAT support is enabled by default, but can be disabled for * various user-requested or hardware-forced reasons: */ -void pat_disable(const char *msg_reason) +static void __init pat_disable(const char *msg_reason) { if (pat_disabled) return; - if (pat_bp_initialized) { - WARN_ONCE(1, "x86/PAT: PAT cannot be disabled after initialization\n"); - return; - } - pat_disabled = true; pr_info("x86/PAT: %s\n", msg_reason); + + cache_generic &= ~CACHE_GENERIC_PAT; } static int __init nopat(char *str) { pat_disable("PAT support disabled via boot option."); - pat_force_disabled = true; return 0; } early_param("nopat", nopat); bool pat_enabled(void) { - return pat_bp_enabled; + return !pat_disabled; } EXPORT_SYMBOL_GPL(pat_enabled); @@ -192,7 +186,8 @@ enum { #define CM(c) (_PAGE_CACHE_MODE_ ## c) -static enum page_cache_mode pat_get_cache_mode(unsigned pat_val, char *msg) +static enum page_cache_mode __init pat_get_cache_mode(unsigned int pat_val, + char *msg) { enum page_cache_mode cache; char *cache_mode; @@ -219,14 +214,12 @@ static enum page_cache_mode pat_get_cache_mode(unsigned pat_val, char *msg) * configuration. * Using lower indices is preferred, so we start with highest index. */ -static void __init_cache_modes(u64 pat) +static void __init init_cache_modes(u64 pat) { enum page_cache_mode cache; char pat_msg[33]; int i; - WARN_ON_ONCE(pat_cm_initialized); - pat_msg[32] = 0; for (i = 7; i >= 0; i--) { cache = pat_get_cache_mode((pat >> (i * 8)) & 7, @@ -234,34 +227,11 @@ static void __init_cache_modes(u64 pat) update_cache_mode_entry(i, cache); } pr_info("x86/PAT: Configuration [0-7]: %s\n", pat_msg); - - pat_cm_initialized = true; } #define PAT(x, y) ((u64)PAT_ ## y << ((x)*8)) -static void pat_bp_init(u64 pat) -{ - u64 tmp_pat; - - if (!boot_cpu_has(X86_FEATURE_PAT)) { - pat_disable("PAT not supported by the CPU."); - return; - } - - rdmsrl(MSR_IA32_CR_PAT, tmp_pat); - if (!tmp_pat) { - pat_disable("PAT support disabled by the firmware."); - return; - } - - wrmsrl(MSR_IA32_CR_PAT, pat); - pat_bp_enabled = true; - - __init_cache_modes(pat); -} - -static void pat_ap_init(u64 pat) +void pat_cpu_init(void) { if (!boot_cpu_has(X86_FEATURE_PAT)) { /* @@ -271,30 +241,35 @@ static void pat_ap_init(u64 pat) panic("x86/PAT: PAT enabled, but not supported by secondary CPU\n"); } - wrmsrl(MSR_IA32_CR_PAT, pat); + wrmsrl(MSR_IA32_CR_PAT, pat_msr_val); } -void __init init_cache_modes(void) +/** + * pat_bp_init - Initialize the PAT MSR value and PAT table + * + * This function initializes PAT MSR value and PAT table with an OS-defined + * value to enable additional cache attributes, WC, WT and WP. + * + * This function prepares the calls of pat_cpu_init() via cache_cpu_init() + * on all cpus. + */ +void __init pat_bp_init(void) { + struct cpuinfo_x86 *c = &boot_cpu_data; u64 pat = 0; - if (pat_cm_initialized) - return; +#ifndef CONFIG_X86_PAT + pr_info_once("x86/PAT: PAT support disabled because CONFIG_X86_PAT is disabled in the kernel.\n"); +#endif - if (boot_cpu_has(X86_FEATURE_PAT)) { - /* - * CPU supports PAT. Set PAT table to be consistent with - * PAT MSR. This case supports "nopat" boot option, and - * virtual machine environments which support PAT without - * MTRRs. In specific, Xen has unique setup to PAT MSR. - * - * If PAT MSR returns 0, it is considered invalid and emulates - * as No PAT. - */ + if (!boot_cpu_has(X86_FEATURE_PAT)) + pat_disable("PAT not supported by the CPU."); + else rdmsrl(MSR_IA32_CR_PAT, pat); - } if (!pat) { + pat_disable("PAT support disabled by the firmware."); + /* * No PAT. Emulate the PAT table that corresponds to the two * cache bits, PWT (Write Through) and PCD (Cache Disable). @@ -315,38 +290,14 @@ void __init init_cache_modes(void) */ pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); - } else if (!pat_force_disabled && cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) { - /* - * Clearly PAT is enabled underneath. Allow pat_enabled() to - * reflect this. - */ - pat_bp_enabled = true; } - __init_cache_modes(pat); -} - -/** - * pat_init - Initialize the PAT MSR and PAT table on the current CPU - * - * This function initializes PAT MSR and PAT table with an OS-defined value - * to enable additional cache attributes, WC, WT and WP. - * - * This function must be called on all CPUs using the specific sequence of - * operations defined in Intel SDM. mtrr_rendezvous_handler() provides this - * procedure for PAT. - */ -void pat_init(void) -{ - u64 pat; - struct cpuinfo_x86 *c = &boot_cpu_data; - -#ifndef CONFIG_X86_PAT - pr_info_once("x86/PAT: PAT support disabled because CONFIG_X86_PAT is disabled in the kernel.\n"); -#endif + /* Xen PV doesn't allow to set PAT MSR, but all cache modes are fine. */ + if (pat_disabled || cpu_feature_enabled(X86_FEATURE_XENPV)) { + init_cache_modes(pat); - if (pat_disabled) return; + } if ((c->x86_vendor == X86_VENDOR_INTEL) && (((c->x86 == 0x6) && (c->x86_model <= 0xd)) || @@ -404,12 +355,10 @@ void pat_init(void) PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT); } - if (!pat_bp_initialized) { - pat_bp_init(pat); - pat_bp_initialized = true; - } else { - pat_ap_init(pat); - } + pat_msr_val = pat; + cache_generic |= CACHE_GENERIC_PAT; + + init_cache_modes(pat); } #undef PAT -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 08:59:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 08:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402939.644873 (Exim 4.92) (envelope-from ) id 1oWDNz-0007nO-FP; Thu, 08 Sep 2022 08:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402939.644873; Thu, 08 Sep 2022 08:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDNz-0007nH-CT; Thu, 08 Sep 2022 08:59:47 +0000 Received: by outflank-mailman (input) for mailman id 402939; Thu, 08 Sep 2022 08:59:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDEb-0006wz-0G for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 08:50:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b14764f-2f53-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 10:50:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C11C21F8A3; Thu, 8 Sep 2022 08:50:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 859771322C; Thu, 8 Sep 2022 08:50:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MIhjH7usGWPDNgAAMHmgww (envelope-from ); Thu, 08 Sep 2022 08:50:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b14764f-2f53-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662627003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3x/3mvtUgMk6arimR7zM4AOZuvsh6hiHAFQZy5JP30o=; b=XSrXbJzHIKdeE0LpAyVmKgSg5WxKGlPjq4GG28gKFV4o5a3dWFHOKWvug0jRv8BKXPGN9U cMSjZJLeSWzcsPwQlP8wtCL8/QdAUVSilPAWNgGJ4kSufisKLhhDCcOdwhKLw2SLtAx1ZB 9TGK0fqh/ZsjffOkRYLNv51PxfRCGLQ= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Date: Thu, 8 Sep 2022 10:49:12 +0200 Message-Id: <20220908084914.21703-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220908084914.21703-1-jgross@suse.com> References: <20220908084914.21703-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare decoupling MTRR and PAT replace the MTRR specific mtrr_aps_delayed_init flag with a more generic cache_aps_delayed_init one. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/include/asm/cacheinfo.h | 2 ++ arch/x86/include/asm/mtrr.h | 2 -- arch/x86/kernel/cpu/cacheinfo.c | 2 ++ arch/x86/kernel/cpu/mtrr/mtrr.c | 17 ++++------------- arch/x86/kernel/smpboot.c | 5 +++-- 5 files changed, 11 insertions(+), 17 deletions(-) diff --git a/arch/x86/include/asm/cacheinfo.h b/arch/x86/include/asm/cacheinfo.h index 563d9cb5fcf5..e80ed3c523c8 100644 --- a/arch/x86/include/asm/cacheinfo.h +++ b/arch/x86/include/asm/cacheinfo.h @@ -7,6 +7,8 @@ extern unsigned int cache_generic; #define CACHE_GENERIC_MTRR 0x01 #define CACHE_GENERIC_PAT 0x02 +extern bool cache_aps_delayed_init; + void cacheinfo_amd_init_llc_id(struct cpuinfo_x86 *c, int cpu); void cacheinfo_hygon_init_llc_id(struct cpuinfo_x86 *c, int cpu); diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 986249a2b9b6..5d31219c8529 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -43,7 +43,6 @@ extern int mtrr_del(int reg, unsigned long base, unsigned long size); extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); extern void mtrr_ap_init(void); -extern void set_mtrr_aps_delayed_init(void); extern void mtrr_aps_init(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); @@ -87,7 +86,6 @@ static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) { } #define mtrr_ap_init() do {} while (0) -#define set_mtrr_aps_delayed_init() do {} while (0) #define mtrr_aps_init() do {} while (0) #define mtrr_bp_restore() do {} while (0) #define mtrr_disable() do {} while (0) diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index 36378604ec61..c6e7c93e45e8 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c @@ -1139,3 +1139,5 @@ void cache_cpu_init(void) cache_enable(); local_irq_restore(flags); } + +bool cache_aps_delayed_init; diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 956838bb4481..a47d46035240 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -65,7 +65,6 @@ unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; static DEFINE_MUTEX(mtrr_mutex); u64 size_or_mask, size_and_mask; -static bool mtrr_aps_delayed_init; static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; @@ -172,7 +171,7 @@ static int mtrr_rendezvous_handler(void *info) if (data->smp_reg != ~0U) { mtrr_if->set(data->smp_reg, data->smp_base, data->smp_size, data->smp_type); - } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { + } else if (cache_aps_delayed_init || !cpu_online(smp_processor_id())) { cache_cpu_init(); } return 0; @@ -784,7 +783,7 @@ void __init mtrr_bp_init(void) void mtrr_ap_init(void) { - if (!cache_generic || mtrr_aps_delayed_init) + if (!cache_generic || cache_aps_delayed_init) return; /* @@ -818,14 +817,6 @@ void mtrr_save_state(void) smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); } -void set_mtrr_aps_delayed_init(void) -{ - if (!cache_generic) - return; - - mtrr_aps_delayed_init = true; -} - /* * Delayed MTRR initialization for all AP's */ @@ -839,11 +830,11 @@ void mtrr_aps_init(void) * by doing set_mtrr_aps_delayed_init(), prior to this point. If not, * then we are done. */ - if (!mtrr_aps_delayed_init) + if (!cache_aps_delayed_init) return; set_mtrr(~0U, 0, 0, 0); - mtrr_aps_delayed_init = false; + cache_aps_delayed_init = false; } void mtrr_bp_restore(void) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index f24227bc3220..ef7bce21cbe8 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -58,6 +58,7 @@ #include #include +#include #include #include #include @@ -1428,7 +1429,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) uv_system_init(); - set_mtrr_aps_delayed_init(); + cache_aps_delayed_init = true; smp_quirk_init_udelay(); @@ -1439,7 +1440,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) void arch_thaw_secondary_cpus_begin(void) { - set_mtrr_aps_delayed_init(); + cache_aps_delayed_init = true; } void arch_thaw_secondary_cpus_end(void) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:08:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:08:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402951.644885 (Exim 4.92) (envelope-from ) id 1oWDVw-0000xB-9M; Thu, 08 Sep 2022 09:08:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402951.644885; Thu, 08 Sep 2022 09:08:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDVw-0000x4-5Y; Thu, 08 Sep 2022 09:08:00 +0000 Received: by outflank-mailman (input) for mailman id 402951; Thu, 08 Sep 2022 09:07:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDVu-0000wy-S0 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:07:59 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba2e00cb-2f55-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 11:07:56 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BN9PR12MB5066.namprd12.prod.outlook.com (2603:10b6:408:133::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 09:07:54 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5588.016; Thu, 8 Sep 2022 09:07:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba2e00cb-2f55-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9L/twBAhQib0rt0g2AGtI0/7jKFoFGdJa0dYr6v5LBBA3JqccQbMo0LrEAzsoh6aG3wVA9WMgqzVwlVrK4aN3qrEsQiwyPfZOi9pTS+tG4UXzu30wP1eCpz5B7BRp3XojIBnlWHJsetRftC4QRemiFMAS1yvh8RKG4hrq378CdPSmpUtop9PoEZhSmjzXKKAJT5p+0eWiC8CW7SqxRdCjfx2Ujja1eASfla4rGKn/xrHse80uSsKNIRVpSQJ4BDwgjDv9kUYpR/xCxgaWWaSSK02okjh3FdHg27M2HyOyQ/6x+WIPDV0zHoNwsAch9W3uGUW8SEpfst+1TcwCvcMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SRD00AqW6YDpMwaZNLvVdoIbkLaK+kJro2mFBEsr2+U=; b=bUYeWdhFA/L3OLyoOA01Dxx3LzbJNl9FMENdvdzaw+kAK/68n1CBzmLCe2/D3qzuaj7DqeuRZWR9rnRVFA/H1NxpRhHR+pD9REP8OKYgMLt/0ZuJx44Uoom4L1jroYb9VjVPk4iEWF0aEm0DloxSAxD4WqecGwytpZxMzshqb8il57fdZFHiJ9l/9aIwIqwQySih1sal37gMufM+VjzeRMI8KFrxAuEEeYJZBBj5xAFIWOoQVDEHT8zWNJDGKzBmCvALpf8gLipPuvO8XjF7klRq9X7DKlOGWAdbqShpdXkDy9DU1aT2y5r6QDDQktgMw9BBMpL90ju+6NERrcfaDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRD00AqW6YDpMwaZNLvVdoIbkLaK+kJro2mFBEsr2+U=; b=CC6e7XZf+GWVIs5dkufKEyVki2Hr2byURuCcog53/t8EgNTIkOT7Ps+craXkKQhsBD9XgD2mkY/GA3uLJdY34DDBl5a7EALS5u5gvBh4DH7/WV3+Ko+UUlg+IaRZ4xDz91YYMRYNrjRqnwEPTPmetA7uYc2mSPHqkl1Q6/OLzxI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <2c2c0315-8694-d9ef-5f08-01c7bce3329a@amd.com> Date: Thu, 8 Sep 2022 10:07:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-2-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220902070905.1262-2-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0047.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::35) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d7dd8fc-edaa-4b33-f3b2-08da91799cf8 X-MS-TrafficTypeDiagnostic: BN9PR12MB5066:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VHCOaLwV+57q0oxXjzms0cXvML/xDdD94qmjfuZyFPTz8c6zJreIbAcEdIZDLnW9qdMtSXzH7C01hTTMy/MqDC6W0/WsKvBFCiFC2AB806lnmQpFE6xt1Oa2YrOO7NPl/NBes3kd2afgbyAeVKVumt1StwhjLvBFHTitVYqkEoGcMazndie9Y4urvPUBCkrZNf9p2QdHsWtqmcvt67Bdw5oG6A98Tk48otj86wq/s89Fiq65FTo1zE4BIHyUJinSV9wyoPUSERMn/F5wLe5EZVi+DjGTSy6Qc+JdWs6X+6iD0EO5otYlEC+Y9HPQm4YwziKT3lfQ2hoFYGHiZKG5029sbwOW0AqlKT/druG7rwXXCpKj9xeBP28RZVIXgkP9X2ZprOioqiwcHWqRfC4UZ7ZLsJ+K7nNSBbVEnOpESESg8NTfskqVSLfOoy+UPPopUs+jbSyeYGS9IJJJUWqjZIBBUpksnJh0S4AGGe5/eLD8f03wF92zc0iBfh3DhpRsUAPbJCpe1rbVTRzPwOUMzruzyPP0XvJ6NmvnGyGPfWpQ7tohtgz4Z0XHeRQiK37OlWF7eUgq2JhJUlN8XC0ajvODdzM/OKYmyFOGKWw5jVSLXvp+KNLU+ASOikGgSWX6nxPRQGrd+AVYTtqGm5eSJZiMCW/LGp7Llvsm610B3zY3vC/6O6d01fW601ceK2SGMUYyqEUlJDzRDQFW6LH0Js/HtXvlDDXHnYE6rDgxbSnEGvWyE8ws71Mw4ZFIXdHCfSzcloYDIwDp/ZJGIJy81TbOgG7XLThBPxpPXCH1x6f+PBMUMTb3fyr6tRo9iEKJxXbSMPy0UxFA/uRacUmXOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(186003)(4326008)(966005)(478600001)(66946007)(66556008)(66476007)(31686004)(54906003)(36756003)(316002)(6486002)(83380400001)(84970400001)(8676002)(2906002)(53546011)(6512007)(26005)(6666004)(8936002)(41300700001)(2616005)(31696002)(5660300002)(38100700002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUFwNDNKelV2WmdMS2oycVoxRW5rY0RyMnFySDNkNkk5SWkyLzRpTGFlcnRU?= =?utf-8?B?V2xzUWdTRHlocXFRRE5yU1hmdHBxWmVrL2U5NmFtQ3JSNkl1VStlRGFQZmQ5?= =?utf-8?B?ODZRSEhMY0J3TmFWNmYrZVZQYVBLZzQ5TVUrOWlkSTRyRThPNzZPMU9QYmla?= =?utf-8?B?SGxVWDJhZFRKZ1ZMeVd5ak96cGdsdUdPSGxjUTdpendZYU1GZkQ3Z0FUQW9P?= =?utf-8?B?V09sY3dYL0hQWktONkpSeWVOMEhmN1hMQ3kyK1BpL0s2ZTBWbFlPR2s0ZWJC?= =?utf-8?B?TlBqZGVvbzZOWW1EWXlkUlJxZmNnTC9uZkVYTnhJWTB1NHdKZ1dtcHVYY05R?= =?utf-8?B?VU1EUjViL0h0ckllMGpyMzh3azFoN3FJRTNSdytRb0dxcnlJOUxDMVhXK09a?= =?utf-8?B?akhDNk1yN1YvOEJnQ0R6MHJlUVd3ZWRva1ZWOVk2TG5QQWdZY0lzcktQYUxn?= =?utf-8?B?cUoveEhPMDVpZmthUDRnVDRIS25zWVQ3bHBsKzkyeUVaOGpKbklPTXNYS1N5?= =?utf-8?B?RzZrRWp1SklUY3dMb0czWFUrcHRUTEZsU1RXek1zRWovOUVIanYvM2x3UWVX?= =?utf-8?B?VGpQczhYbmN0em1rMEJFUFVwVGR3MmpYNGM4dVhJVHJDSjBhVHkzZEhGTHcx?= =?utf-8?B?U0ROcWV1KzlCbjA1TUhlVG1VWGg3YlMyNjZHaXBzalZobzFTT3VjV3NISnFS?= =?utf-8?B?RG4rbmpDUXVPYk9tWjN1YkZEblM2K1RGNHlESXhuMDlVWFRvU05RMFdHYllh?= =?utf-8?B?TnZqdWxSMjRQZVpjRG9BZytTdkNZNGZRZ3ZCUmtrbHNWeitEQ2hWR2hPWTZG?= =?utf-8?B?MVdHVkhLSHRMekFBeEdQQS91RDlDeGxtb05mQ3pRQ05CYkJNMGU1R21kczR3?= =?utf-8?B?eEVPS2thdXBIT3hQS3JOYml6ekU0SS93RVYxdkJWeE9ILzliWldKNzZmbU14?= =?utf-8?B?M1o1Y2p2QVh6UCtqVGRWcU1hakpwQUYyUGZEN3paVk5OSUZmZ3J0VXJlQm8y?= =?utf-8?B?cDg3TzYvMVFrQWs4SDExYWxUYW1mcmFHS0xUTHFTTWRWYTJadGtlOFJIeGh5?= =?utf-8?B?aC9JZlJZVHk4Y1h2TjJUaFF0ZDlvQzd1VDZlQWJvZWprUnM5L2tTKzgyR0xr?= =?utf-8?B?WFJma2d3NnVNZUdtVzFDRmJQeGxhZlhCV0N0MlFQTkprdksweFNXb0E1MXJM?= =?utf-8?B?YWRNdGZadk0vVTl6VXFldTdoMGU4SDlSSXliZUZkOWNPUkdtbFJCaHMvQjd5?= =?utf-8?B?S0pXaUs0bWw2cHE0b2ZZVlQrZldaL2JzYktCK255c21ZWmxwL2kvcnlpMnFr?= =?utf-8?B?NlhDQ2VjV04zYkdVd1hHeTR2aURDaGVaVUFBLzdmT2NMVXVsSk5wTndCOWxo?= =?utf-8?B?aTVRQXNhUmtMaVNzR0ZRR3FLc3BsZHpXODZ6ZXRUS1Bqb2ZkMDVJVjlHaGNG?= =?utf-8?B?VE4xUEJEcDZSR2dDamVNcG5FY09iYVAwbEIvUUltMENhekorak1mc2lMSzIx?= =?utf-8?B?aFJJVCsxTWl0YThIVFBmaGpQbk1BTkZCUWFYbTk5T3NSQm9TQUdtTDBETU5G?= =?utf-8?B?SjdsV3lDNlJuZ0t0TjVZamFnVFNSSnI3RmRYNnZRdEgwOHVkaHpZK1JSL0ty?= =?utf-8?B?ZG1jWVlqL3djWElsRlhNWUtjMTQwV1BjejFwTDJRL21lbk9uaEtha01keHJs?= =?utf-8?B?UlRadGYxTEExRTYyKzZxMjFUSnZXblFiVjh3ejh3M2tkdTVJSCsxSlJIdTFJ?= =?utf-8?B?Z1IyRUZJVUZLN0E2WFpnYmpGU2RwUmkyY3Q2SEVrRXRhOTFabUEzVS9lT2Zx?= =?utf-8?B?YzBZcTc3SUNja0JYMUlXVGJmNmRMdlhuSE5PNW5pckNkR2htUDZwRlc4T3Za?= =?utf-8?B?VVFSWFJzTkdRcjFieTg0cXROTkU3a3hZazVmSkdBL013ZlhraGZYOHV5UGl1?= =?utf-8?B?ZWVBQVJXYUM0Y3hXVEZCWXYrNEFuVEtvMlR1cURrWWV6b2RFV0dYdlplOUwz?= =?utf-8?B?K2tkTVc2aTNObXpLdGtzUGluRVFLVGVieUErRFExWHl5dkdHU0ZuOXFGYjk1?= =?utf-8?B?S0h5aFlrOGtudXpnSGpLUUdGSUpMS0s5Tyt4WjZyWm4yaVJjQ0pleVF6UWZG?= =?utf-8?Q?DQLnJyhNmCl/QYRz8Y9O+kStr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d7dd8fc-edaa-4b33-f3b2-08da91799cf8 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:07:53.9321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9YT4O2rBUc2KjL8cYB6W5OR9sIuZqdl/MQS5KovfKYc7KvVOP43rbblWfK5JOn5/vDo+WK7S7wJ9wyme4bBaOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5066 Hi Michal, On 02/09/2022 08:09, Michal Orzel wrote: > After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having > two kernel configurations. This is something not needed and maintaining > a single kernel version is always easier. Modify qemu-alpine-arm64-gcc > to use kernel 5.19 and remove kernel 5.9 from tests-artifacts. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder Question unrelated to the patch. When do we decide that we need to upgrade the kernel version ? > --- > automation/gitlab-ci/build.yaml | 11 ------ > automation/gitlab-ci/test.yaml | 2 +- > .../kernel/5.9.9-arm64v8.dockerfile | 34 ------------------- > 3 files changed, 1 insertion(+), 46 deletions(-) > delete mode 100644 automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index d2f75a090c0f..720ce6e07ba0 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -586,17 +586,6 @@ alpine-3.12-arm64-rootfs-export: > tags: > - arm64 > > -kernel-5.9.9-arm64-export: > - extends: .test-jobs-artifact-common > - image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.9.9-arm64v8 > - script: > - - mkdir binaries && cp /Image binaries/Image > - artifacts: > - paths: > - - binaries/Image > - tags: > - - arm64 > - > kernel-5.19-arm64-export: > extends: .test-jobs-artifact-common > image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.19-arm64v8 > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 2eb6c3866e2c..07209820b474 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -34,7 +34,7 @@ qemu-alpine-arm64-gcc: > needs: > - alpine-3.12-gcc-arm64 > - alpine-3.12-arm64-rootfs-export > - - kernel-5.9.9-arm64-export > + - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > artifacts: > paths: > diff --git a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile b/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile > deleted file mode 100644 > index 053d65a3454e..000000000000 > --- a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile > +++ /dev/null > @@ -1,34 +0,0 @@ > -FROM arm64v8/debian:unstable > -LABEL maintainer.name="The Xen Project" \ > - maintainer.email="xen-devel@lists.xenproject.org" > - > -ENV DEBIAN_FRONTEND=noninteractive > -ENV LINUX_VERSION=5.9.9 > -ENV USER root > - > -RUN mkdir /build > -WORKDIR /build > - > -# build depends > -RUN apt-get update && \ > - apt-get --quiet --yes install \ > - build-essential \ > - libssl-dev \ > - bc \ > - curl \ > - flex \ > - bison \ > - && \ > - \ > - # Build the kernel > - curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \ > - tar xvJf linux-"$LINUX_VERSION".tar.xz && \ > - cd linux-"$LINUX_VERSION" && \ > - make defconfig && \ > - make -j$(nproc) Image.gz && \ > - cp arch/arm64/boot/Image / && \ > - cd /build && \ > - rm -rf linux-"$LINUX_VERSION"* && \ > - apt-get autoremove -y && \ > - apt-get clean && \ > - rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:09:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402957.644896 (Exim 4.92) (envelope-from ) id 1oWDX5-0001c0-JG; Thu, 08 Sep 2022 09:09:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402957.644896; Thu, 08 Sep 2022 09:09:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDX5-0001br-Fd; Thu, 08 Sep 2022 09:09:11 +0000 Received: by outflank-mailman (input) for mailman id 402957; Thu, 08 Sep 2022 09:09:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDX4-0001bl-Lg for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:09:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e54e2c2c-2f55-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 11:09:08 +0200 (CEST) Received: from AM6PR01CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::30) by AM0PR08MB5379.eurprd08.prod.outlook.com (2603:10a6:208:182::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 8 Sep 2022 09:09:06 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::36) by AM6PR01CA0053.outlook.office365.com (2603:10a6:20b:e0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 09:09:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 09:09:05 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Thu, 08 Sep 2022 09:09:05 +0000 Received: from 0cb3b0350997.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43D30377-9493-4E70-9851-0BE38D80175D.1; Thu, 08 Sep 2022 09:08:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0cb3b0350997.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 09:08:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV2PR08MB8170.eurprd08.prod.outlook.com (2603:10a6:150:74::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Thu, 8 Sep 2022 09:08:51 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 09:08:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e54e2c2c-2f55-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BVuZ1TltJuj8hBIOM4lcpMbuY1pGkngG/R7AMHQWrMTQGk34KG78uGCdkChqgDQxYvzWSRubh3JZH8vMdbjalwJEbFvuKXKfVUpUYycEhLfRcJ2OJQEMADFhxZuu50jd2GeDryaVOXpOYJSzHRu1QQESDSS3+zZ53a1OubpOBOXd+22WRg/Ssic66Cdg9l9T2PXR+XpFAHZr1rgNNlkOq0X1TmUG8o6rMGyJWFArR0PpUQPfisDGMBUp1TgltCpNoZ36pA/WS4hLMatG5UiL1+DW75AiZ7EsOf6KAM1yZA8RFApwCuHJF2CnWLgb7j4ViTAtJNe6jo/pcV9kTV598Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QpxCyf5FBpi9+RpfheVgyK+l5RWHvJJNpiS6bJ1GPoY=; b=Rp+iXUX/p0ybCSj8fZZcBMnxGZXID6Wt2kxwmYYDrWt7XJAwLfaswXdQ1zDC1w2pkWk/zm/QZKp3NTJypfNXuj6VenCNcXT5RRhRozFIqkhU51kSQ+HITafyUv2l1dwd80x7654F5H8sVbf26u9GFwevf+uR6Rm7qnrTfaI9s0p4H5NjkJODsDy2wJS1N3eXTBpwIx1pLbKQLWg95IzkcILl1USOC2+y+rDviB3AqzNnL87OEekAJ3By70C7YlOgUS34ib/orPBViMzUEoeQtEhwLHnqs3Qe+EKo8uR7qPWuPP1us6EUCJ6JoU6FuBSc8n8C0j9Dortpfvj3zlXqjQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpxCyf5FBpi9+RpfheVgyK+l5RWHvJJNpiS6bJ1GPoY=; b=dVoY/Y215pmz6lEbmYZa32Ds3WGapRwUL2PDf62EIaHBNSc+7zkDip7AGWl6IBED6905JpTE6cEidbWLd72FSX8qoE9/kyJxelbaCtVixKoUNhCzmHJfwaWwRGk+ZaOLn+0ACoEq3zMiArZaROKik4MxA90DRqL22ayWQIbumH0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7XyJe5XX5FGsxxLY2mIb7PZWNvq+V84LgwRMYIu689qaznGu8nCDw/IuQn5+4Pn4ZUkLd2Q+9icKkq2c/gNqv7yHPeLZFXAZYeGKUyXnhqvnJ4OtB0USo7kvqfM+0RJ2nJBT9MtUYMw577mylgajXMscvtyfDlc8G9NvNJ78f7bt/P9oc6NnueajLzIz7tIxnpwqUAnf/Jo0MnnDRrhBYcMLEAWii4T4VWUX+CG3uHELNMln9uup6hx1ZFCQrfefXfj3OWLxd3lRIP8ILU1kxgKfnRD+47CIP8EtbpRFRkM3t1kvifZOG0FFYEjyOzKohuO0u+LP0LSqI94SvqkNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QpxCyf5FBpi9+RpfheVgyK+l5RWHvJJNpiS6bJ1GPoY=; b=O+c34Nh1TCHGI2yEUR48Z/gysfyP1rQzfNYw/QpxDurE6GkbJo7ZkyOp7ahhWfx4uUNCrfD/gvtejxmdBpfmtUO0GkDREyqnYt9+clNhWAGu6Dl53zUzvMrFENAmJn9jzI1F37tG++s66Fx4ESx95Nnv49Uk6mWGS7Thx49NH1WrMOdaepayND0Z2dLpA2RISaASEI62X/CN6W4+Ke9IRioJhJi9e9RUsoIH35Soh8sMrGNPdhQcMELpOqMQF2XDtOvgivSUkYeD9h4q0tI0/hJ/JytVcOxWhgAVQc/0ZjkewgnuGSWopqwfXPm1/fQg4YE2WpYqUghcIU1jJAxymQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpxCyf5FBpi9+RpfheVgyK+l5RWHvJJNpiS6bJ1GPoY=; b=dVoY/Y215pmz6lEbmYZa32Ds3WGapRwUL2PDf62EIaHBNSc+7zkDip7AGWl6IBED6905JpTE6cEidbWLd72FSX8qoE9/kyJxelbaCtVixKoUNhCzmHJfwaWwRGk+ZaOLn+0ACoEq3zMiArZaROKik4MxA90DRqL22ayWQIbumH0= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory Thread-Topic: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory Thread-Index: AQHYwzso2GWwzsCDE0CcU7YanIzu9q3VKd4AgAAUeAA= Date: Thu, 8 Sep 2022 09:08:51 +0000 Message-ID: References: <20220908042538.27076-1-Henry.Wang@arm.com> <20220908042538.27076-3-Henry.Wang@arm.com> <44cd9359-db40-c6e3-7398-220d27d72bdc@amd.com> In-Reply-To: <44cd9359-db40-c6e3-7398-220d27d72bdc@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BE0F7883D03C2444A83C4AA1B332330E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e555d92b-882b-429b-43f3-08da9179c7f4 x-ms-traffictypediagnostic: GV2PR08MB8170:EE_|VE1EUR03FT006:EE_|AM0PR08MB5379:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mGCF1mZf9rsa7CIXps5CNP+I7voYhX4ziLfcPEiIdXfXtcxhNwLxHbUmoYf+HO8Uq3HqQeQenJ0UGjeHYrHvtcfOZriC0fPssTkKhaz+ntPKznQcN57jI5AhJC+8SaSL3APBul8WXjALn+msfhB6tJ7HeQ8usGmqk53t8/9QDo4DJPxXpZozr/lXCpvHGb7XE3FhGq1DfrDh+9sOuGQqRcJXQWMBc+yFQZ9Ko/F4r4TUfEsMDEedgTbN5T9DFGzqG6CzI1b5v9eCveK73QaYQLAdsRzXQsV+CgYQwFljxTSGxrc05duBT4Ud7y6i6n88HvIw1sVyT0I1l9ft3Z1sXoKGlmrLhEiuw6B6VVOFSSZcTE95fVY8nQe3tozkm9vSpQ8fn/X/KuEqasLZwLgWuivPaBwdtUI7ku9YEpPNOEDGIioO2WtAP2ZH/75mxiPMVG6xdoBmYY68+YT1UiBoPQwue24AnMRDNzG3VLNNl2iGbyaHnEVXhTEUdT3bIxXIYU/oknlQ8yYl5Kf5acTi/MnhKCpUEn7MXlbhIQDhEGeoGDh++lo+h6+XMe7TbTHJIi7Ilc+GOtOX8rlsniFiMaSlCa4qnjEQ5Xt04DsWwsGk6NUfXOYUu6PWpDfAlmq03ne6jbDtjpxwtAvUHiBOfLueolD97YmgvZT5cCETJ6DE8j1+gO63CmAZTSVIUoDLYhw4Xj0Mvk2ABVaiwcVdWw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(41300700001)(9686003)(8936002)(7696005)(26005)(186003)(71200400001)(5660300002)(6506007)(52536014)(33656002)(478600001)(84970400001)(86362001)(966005)(83380400001)(66446008)(38070700005)(55016003)(110136005)(8676002)(2906002)(38100700002)(54906003)(66476007)(64756008)(316002)(4326008)(122000001)(66946007)(76116006)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8170 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1a6b7b14-41fe-4699-37a0-08da9179bf9b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +N7eYnqvHnhw0VJ1VSAz/d4sUxFX2k8b2F+22FjqOJWqdgYPIraiboDvDwuBf/BFaGYRrfpa14Z43zLNtLM+feMIGicOrr7o80YMzF1dHECPhelswgo6N5IuJWE91pAu1siEiiPhQWabM6MXeHxEp6yXLncpm41DN4IuVW+9gtZmaZB6C7TNw8m3RG22dLfxnaFNB9Y0L1CaKLqOWrnG/wVg8mVSYMiBn1KZpblCiQRf3AeasgGnsiFoadlHRWhsJ5gVA7UNLFMlOE8f1AhxTC39j3bRyqNiAQPfLcx/BpVo3CdmiOg8hmFQHDFEiZ38Mny6blZGe+tgUoTfW+v196a4w5U+0Z2YULa0kXbABwzkJcOzHIrTwOnmJLAeY1595iTTJ9vvVe3So4nLK7sp+3ENb8lFs7KVygPoOVf53p9qqpOKztkyCLQn7nul2y2dEdqUGRcbXRXOyeSGYQAtEfUx0EsEW1P2OhzS7rAueqCaqk//iAJ4OfD0t4Vk+WaWmUj0CUMpLdXu+YkwNTf0VEVpbPMNULFgr+8LAKFJOuFuHBdfHwMQwKusobXjxurHlzSkcQI4Gw4U7TEF6QK5o9s0PDg4X+VrHDuTzo82Tt/sKCLw2ug4kxqxLz7Bz8qhzEn5tzPNZ2Jb0/jkA8g1+rZFyVE6fzpoQdQSfzW85clHnwsdkEF71xvfoFTG9rVUYwcPUPYAg4QqT8RWN9ClfuL4fOisvs65+eU/SzJ5cv8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966006)(40470700004)(36840700001)(33656002)(41300700001)(52536014)(9686003)(40460700003)(966005)(8936002)(2906002)(26005)(86362001)(70206006)(70586007)(8676002)(478600001)(5660300002)(81166007)(6506007)(4326008)(7696005)(84970400001)(110136005)(36860700001)(356005)(40480700001)(82740400003)(54906003)(336012)(82310400005)(186003)(47076005)(55016003)(316002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:09:05.6841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e555d92b-882b-429b-43f3-08da9179c7f4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5379 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4gKy0gI2FkZHJlc3MtY2VsbHMgYW5k ICNzaXplLWNlbGxzDQo+ID4gKw0KPiA+ICsgICAgU3BlY2lmeSB0aGUgbnVtYmVyIG9mIGNlbGxz IHVzZWQgZm9yIHRoZSBhZGRyZXNzIGFuZCBzaXplIG9mIHRoZQ0KPiA+ICsgICAgInhlbixzdGF0 aWMtaGVhcCIgcHJvcGVydHkuIE5vdGUgdGhhdCBhY2NvcmRpbmcgdG8gdGhlIGRldmljZSB0cmVl DQo+ID4gKyAgICBzcGVjaWZpY2F0aW9uLCB0aGUgbnVtYmVyIG9mIGFkZHJlc3MgY2VsbHMgYW5k IHNpemUgY2VsbHMgb2YNCj4gPiArICAgICJ4ZW4sc3RhdGljLWhlYXAiIGlzIGRldGVybWluZWQg YnkgdGhlIHBhcmVudCAjYWRkcmVzcy1jZWxscyBhbmQNCj4gPiArICAgICNzaXplLWNlbGxzIG9m IHRoZSB0b3AtbGV2ZWwgImNob3NlbiIgbm9kZS4NCj4gSSBhbSBub3Qgc3VyZSB3ZSBzaG91bGQg cHV0IHRoZSBpbmZvcm1hdGlvbiBhYm91dCAjYWRkcmVzcy1jZWxscyBhbmQgI3NpemUtDQo+IGNl bGxzIGluIHRoYXQgZm9ybS4NCj4gRmlyc3RseSBiZWNhdXNlIC9jaG9zZW4gbm9kZSBpcyBhbHdh eXMgYSBjaGlsZCBvZiAvIG5vZGUgYW5kIGFjY29yZGluZyB0bw0KPiBzcGVjcyBbMV0NCj4gdGhl ICNhZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBhcmUgcmVxdWlyZWQgcHJvcGVydGllcyBm b3IgdGhlIHJvb3Qgbm9kZS4NCj4gDQo+IElmIHdlIHdhbnQgdG8gc3RpbGwgbWVudGlvbiBpdCBJ IHdvdWxkIGp1c3Qgd3JpdGUgdW5kZXIgeGVuLHN0YXRpYy1oZWFwOg0KPiAiTnVtYmVyIG9mIGFk ZHJlc3MgYW5kIHNpemUgY2VsbHMgZm9yIHRoZSB4ZW4sc3RhdGljLWhlYXAgcHJvcGVydHkgaXMN Cj4gZGV0ZXJtaW5lZA0KPiBieSB0aGUgcm9vdCBub2RlICNhZGRyZXNzLWNlbGxzLyNzaXplLWNl bGxzIi4NCg0KVGhhbmtzLCBJIHdpbGwgYWRkcmVzcyB0aGlzIGNvbW1lbnRzIGFuZCAuLi4NCg0K PiANCj4gPiArICAgICAgICBwcmludGsoIkNoZWNraW5nIGZvciBzdGF0aWMgaGVhcCBpbiAvY2hv c2VuXG4iKTsNCj4gPiArICAgICAgICBpZiAoIGFkZHJlc3NfY2VsbHMgPCAxIHx8IHNpemVfY2Vs bHMgPCAxICkNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIHByaW50aygiZmR0OiBu b2RlIGAlcyc6IGludmFsaWQgI2FkZHJlc3MtY2VsbHMgb3IgI3NpemUtY2VsbHNcbiIsDQo+ID4g KyAgICAgICAgICAgICAgICAgICBuYW1lKTsNCj4gPiArICAgICAgICAgICAgcmV0dXJuIC1FSU5W QUw7DQo+ID4gKyAgICAgICAgfQ0KPiBUaGlzIGNoZWNrIGlzIG5vdyB0aGUgZGlyZWN0IGNvcHkg b2YgdGhlIG9uZSBpbiBkZXZpY2VfdHJlZV9nZXRfbWVtaW5mbyBzbw0KPiBwbGVhc2UgcmVtb3Zl IGl0DQo+IHRvIGF2b2lkIGNvZGUgZHVwbGljYXRpb24uDQoNCi4uLnRoaXMgaW4gdjYsIGJ1dCBJ IHdhbnQgdG8gc2VlIGlmIHRoZXJlIHdvdWxkIGJlIG1vcmUgY29tbWVudHMgYmVmb3JlIHNlbmRp bmcNCml0Lg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiB+TWljaGFsDQo+IA0KPiBb MV0gaHR0cHM6Ly9kZXZpY2V0cmVlLQ0KPiBzcGVjaWZpY2F0aW9uLnJlYWR0aGVkb2NzLmlvL2Vu L3YwLjMvZGV2aWNlbm9kZXMuaHRtbA0K From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:09:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:09:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402960.644907 (Exim 4.92) (envelope-from ) id 1oWDXL-00028Z-VT; Thu, 08 Sep 2022 09:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402960.644907; Thu, 08 Sep 2022 09:09:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDXL-00028S-SS; Thu, 08 Sep 2022 09:09:27 +0000 Received: by outflank-mailman (input) for mailman id 402960; Thu, 08 Sep 2022 09:09:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDXK-0001bl-GS for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:09:26 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2056.outbound.protection.outlook.com [40.107.104.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef259de9-2f55-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 11:09:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3918.eurprd04.prod.outlook.com (2603:10a6:803:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 09:09:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 09:09:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef259de9-2f55-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUofFq3W9phdDxwelhsMnLFEb/AtXkjWn65MlyZh9eCszJwJdywsu1wwx/DHVaMJEavPa2lN+02AdyRMRq3W8cwPNY5IAn3OvsGTn0+n1WpxiBTWmZPrC84u1r9t+KVVRVCmlJNAMyP48z5eGyXnStUIQrp5r29OylyLC7zKLOuO7Yxn1YPiHpe4fO2BJlniJQ4n87hghphH/zQ6wsd4O78iPCCj9oW+boidNk8VH+UL6GCVSq2wAUT6TQWv1ng3bTweI773WVAH9tP5PpR2dJpGeFhoxiz2eKULrq1n+T3/hK9JR306NJXxE82701NjQ5IIipejfY5jkZIEzFDtOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hQ14SFblbuhivGAN+XrIB1HI710P+uFIOTxAbhFEkLU=; b=JvYVYd0rr9UPIDjutnrlP6FUaUqZ9wPEQ+ADXmQMvbKVAO1RZJFzceptMgCovau68WrCSbdKOHK+Vd/B9qaDwYa2/8YxX3TAyMcK9TJVJgGbcQ5PFbVSM6TaKyREgJLtsnRM7IQM+TTDaxloWU2cAjuprwKrHvbDyTsj3cIi6tfytZUB7w/Q2amTyiwrzdov8DLJVhy8ZjKv3AG6lC2+SwgQTXMQ2tvngbYWVeUIto0J3cUpuhWesH4UT3IP9neG0Yyc+n/O9pfMnqYiTvLg9KX+QdTIqw3u9tURbYvqHctIo4HvwvVvYY91NrjO3yEusTQfI4oV9fykINbmP/gIGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hQ14SFblbuhivGAN+XrIB1HI710P+uFIOTxAbhFEkLU=; b=u3LAZxS81fwbSUjsDwP0+ORO0gqkkSAVcSHI+jEGf5rpZ0fIO2sifi0OKyMdR3IgL1TvwvFGlIjLre3cpkIGk5eB2MpA7NBKxsp2c5fpxLYyYtb7dWr0Wy4fGzQnvoQkVYq20R6Q5J3lv+0i162kkGtKfVPKhgHbXCj2OcODGXA6EkBkHlIXah+h6bR5yiehihuFsHmunX8h3O8yTAUiJSe2keQHW9kWWXeikEP05+5CeZHzUi7CcdMNpbPa+S0Fpw29ECtLGPBQpYnQIZCzzdYvNrPhTz1dxGG/N0md2eD1Olj409IpMPUDKYZ9259QnGCqSBcWIsbcq2yoJ2dO9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 8 Sep 2022 11:09:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220902033121.540328-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0602CA0010.eurprd06.prod.outlook.com (2603:10a6:203:a3::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR0402MB3918:EE_ X-MS-Office365-Filtering-Correlation-Id: abcf4497-08c8-4d6d-c729-08da9179d22e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6O/2X+kbOzX+RUY4jEuLCE0FuIBA3nFCZHhClSp9VybddiAFqbdwcJ/YZySbmxVGK8XZjfTtA0r4NQoNvLLwXbT2tSubqem5HdYsCd1NUWrfPzy1iy3uG2UCO6zWe60Fgd1o4PYmUUmxW7dnEyPXPv310NcJN9HUXrwdn5lO7jBgQF06UnLsT8mZGVvnqQOFiVVDDb+wPRNjAQqSmS9cd2e7BAut385VGliiwwm+FNqXQS3FsnNK5MSX7AvHEa7d3/1Z2qt9TSX5zgFW/BBIqQQ63aSB26ZJNs83Aue85PMahZ2egTU8Cg5zc3EZ9k5Xnv2WV1C7W6RZu9PauWJnxGiQUo2+Zdp3QjDCcgM5j0xoNDiWeUVwr81u5H0I2T4Tw556gLYB04uv9tnKSF+bpq5jV1iHwvTjjdgLgX05u0fSG1TnXQX2FdsCPBFieUQsIPM4jrY2D5Q0ju5dHZRLLIC3QrFvO+Y2b8kCor8Nd8OPJZ91VlXOMTwFqIjYOrgqItwzqGXExysiJTXvNi8EwkK2Hs2WxVTu4ZdL4VaddLc87C1wqSGDIbGYw3qvTr+ULV5Lup+mvFkmWm1w7IXAQkR/uakPHsoA54BRZYliZvmYgeKntHDj4rD1dlVx9IPbnlEYumxJtHlOpZ1g+MxHzyKsgVWsh4IAWLDoOBnlFYDi3Ser1hurr+uRSxT6HRgGJSOcNer0UG2dksclt80fDUFDyAXfVFWMr8fLQXGf75rgWiECk7saHIIpP5YSAZkMz73G6akerWi9/IWACfnkn0DXZdsC5dtbEU+B8YtDtTM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(366004)(376002)(346002)(31696002)(38100700002)(54906003)(316002)(6916009)(5660300002)(8936002)(66946007)(2906002)(66476007)(4326008)(66556008)(8676002)(186003)(2616005)(83380400001)(41300700001)(6486002)(478600001)(6666004)(6506007)(53546011)(26005)(6512007)(36756003)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWkwbm5uc0RpQjZ0TFl4UU9LeWFLMm8zY0IrV05rbmxBazgwMnJ6N25BVHB5?= =?utf-8?B?UnpqRlJocmV0MFJaTXN2QXJldkQ4ZXFsUHVUeGVjaGNoM21oSWNTUk9YNWVV?= =?utf-8?B?YWhjeHFGS2VoVlVxRTlxSUpXZVdMYlR1bXhLbDVoY0IzWlY4MTU2anZrbkVH?= =?utf-8?B?cE5OY2RwRWFFSHIrOU5HOUlWSUtqcWlSQ2pSbDVaR2syZVZ5TStUWUdNaC9t?= =?utf-8?B?UXQ3NStEV3Zma0JhdDRxN3NXcnp1WXlUbkNIQzZlZUwrVlJFT25wc1h6SzNZ?= =?utf-8?B?SDFGTldnNCtUMG5DTGlpNHBuNGtMZG1XZTdqSjJOT1R5MUd5TGRab2N4MTRV?= =?utf-8?B?aHlFcVBQTUxJS05DQ25zTXVzVU0ycUw5WG9RUExMeE5MSDFYS0VlQlVYVEpx?= =?utf-8?B?Qk9Lb0UrUTkxdnNvUmgxNlNqRVdsL3N0dk55eVIreWxoaHlYYWZ2S1ljRnRq?= =?utf-8?B?dVp1K3Y2NTdOc2ZaWFFsbE5QSDgwdUdvc2Z3dElvZURweFhZcUcwU0QxRDhT?= =?utf-8?B?WUt3VU16LzNtQklZVHowb2p3Si9SSkxRRjNKejFqWDdYUTRaM3A5alEyL3Bw?= =?utf-8?B?UytGUHpHNEloWlh5Uk9TM2pKQjJTOU1DRjMxc2dRTWtvQzBSMVhQTXpkUlZs?= =?utf-8?B?YllYSFVzVW5rejd1NVhkZ3ZOV0xqZjdJd2dveSswTXFhNHdkL1dBK2JDamZ5?= =?utf-8?B?WXhKL28ybUdZdXdYQUV4bTRSVW4vSGZVdTQzSUFqck03QmhiWEJsdlQ1eDc0?= =?utf-8?B?NEh4RkVhd3F1WkwyOWtyRkYyazV0S3FUOFdyYlVuK0V0cVBURm02Y0Z6Rlls?= =?utf-8?B?dEs2Y1ZsUWpla284VlF1NllUSnFvZDVwSFpDT3B0Z3REWWV2Rm80MSttdXhs?= =?utf-8?B?cVdhVzd6aHU1VDRFZWEzUk9zMTlGR1NwaU8vTXZDd3kvN3JUbTduSURhUkVW?= =?utf-8?B?NnJCV1RsT2JpeGhrWndTNzh2U3ZZZGc2cW9LbFhUanB0Tkc2a1VFdmNMUmRl?= =?utf-8?B?aHpZSm1MOWJzVmMraWR2b3Jxb2t3a1lNNGJTNDU3R2xRWnNaS1NlS1JmYUN5?= =?utf-8?B?RXV0NXlOSlI3YUFzaDA1L0t2QTJncjluN2dmR1dIWjlxSS8yeHVVdkdPbWlY?= =?utf-8?B?UU1VZStjRzZrUDNzMDZnSDJuKyt2VGkyQWc0TnJkeDV6ZXRhcEwzMnlONkty?= =?utf-8?B?Q2xGQmVGeUJRZ2Q3OUtQU082SlhUeHhhcHdGc3FEMFFrV3FiZitGMlNzVkZI?= =?utf-8?B?Y2VVaGMxZ2JRLy9VdldzL0VMN3I5TGpUNVE4SEZRTFRzZHBCRkZzdW41amgx?= =?utf-8?B?ZjJjNlR2ak01bVQya25xREowMi84UFBkM1RPenpSVTJqOUxCSWJFa3JmeWpB?= =?utf-8?B?bzFLN0dNVWw4RzB4VFRxRWUwZS9jQnlSK09vYmFNVzNjaWtRSFc3WTNhR1VK?= =?utf-8?B?K1l2UjkwZ09taForcmN2SzJRQkpmdDVZRzJMbVZDcVdwejlZNnZGclBZNlRV?= =?utf-8?B?dzRNV2ZuUkE0SjVDR0FJVmVFVkFzcCtXSnIzM0xHZmVUMk9Nd0trUDUzTlBx?= =?utf-8?B?MlJMSTMzY0Jxamw3MExPQXZNQ2FRNmVydnVaLzZGa2ZLOVh1aFc1bGN2ck5V?= =?utf-8?B?UzEzL0ROR0dZRCtVZGU0dU5KdGo3UXBpZ096SXNtdURrbloySHFvc1hVNUZF?= =?utf-8?B?Z1Z0VFNNNUduWUFBTVNtaHk5VkdRY2VxN2pJZGxHSnVJend5MmlETWtiR3ln?= =?utf-8?B?aUYybHI3bVpTZWdEMTZDZ3FSVVllUVROZEU5NEFPSGhCUEZBYWVhY3hUN2JN?= =?utf-8?B?aFdEWWVXdUZFc1JsSFZWYWlwWEkrdDdFM3dya0YzTmRhTE1PMENJWDROeXZZ?= =?utf-8?B?dWlCb05jalNXVmthaUxNYThtQ3ZvdFByRWYwUmI3eHZjK3Bjb2ZZM1VkSzVu?= =?utf-8?B?UWcrYTJYS1p5b2pBOXpWN0FSVmQwWkk3S3BMWmF4TU85RURtSDlYckhrNXVQ?= =?utf-8?B?R2JueVhCZlVHaGNGck1paVo4di92SlNMa1NJMHh4Y05RU0tLZVpmWDZ3aE1m?= =?utf-8?B?bDZXbWZLNWVsMkNBZG9jVldlRGU5T0FzVzRqZ2hkVEZ6WGkzRUVpS1pSWDlD?= =?utf-8?Q?N2BCcqqLSSK+pnPCnBFmM4ZDw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abcf4497-08c8-4d6d-c729-08da9179d22e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:09:23.1103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Qw2ziyt7Jj3pAsEuoahAgdhP07hVEfaJEhNrjW0W5GHW/Ne+gbeTSJDvIDWH1Zda4HZilvUPqIYOGBSc2s0/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3918 On 02.09.2022 05:31, Wei Chen wrote: > --- /dev/null > +++ b/xen/common/numa.c > @@ -0,0 +1,442 @@ > +/* > + * Generic VM initialization for NUMA setups. > + * Copyright 2002,2003 Andi Kleen, SuSE Labs. > + * Adapted for Xen: Ryan Harper > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct node_data __ro_after_init node_data[MAX_NUMNODES]; > + > +/* Mapping from pdx to node id */ > +unsigned int __ro_after_init memnode_shift; > +unsigned long __ro_after_init memnodemapsize; > +uint8_t *__ro_after_init memnodemap; > +static uint8_t __ro_after_init _memnodemap[64]; These last two want to use nodeid_t instead of uint8_t. Originally the latter used typeof(*memnodemap) for (I think - iirc it was me who made it that way) this reason: That way correcting memnodemap's type would have propagated without the need for further adjustments. > +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { > + [0 ... NR_CPUS-1] = NUMA_NO_NODE > +}; > + > +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; > + > +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; > + > +bool __read_mostly numa_off; The v3 review discussing this possibly becoming __ro_after_init didn't really finish (you didn't reply to my latest request there), but you also didn't change the attribute. Please clarify. > +static int __init populate_memnodemap(const struct node *nodes, > + unsigned int numnodes, unsigned int shift, > + nodeid_t *nodeids) Can't this be pointer-to-const, and then also in the caller? > +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, > + nodeid_t numnodes) > +{ > + unsigned int i; > + nodeid_t nodes_used = 0; This once again is a variable which doesn't really hold a node ID (but instead is a counter), and hence would better be unsigned int (see ./CODING_STYLE). > + unsigned long spdx, epdx; > + unsigned long bitfield = 0, memtop = 0; > + > + for ( i = 0; i < numnodes; i++ ) > + { > + spdx = paddr_to_pdx(nodes[i].start); > + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; > + if ( spdx >= epdx ) > + continue; > + bitfield |= spdx; > + nodes_used++; > + if ( epdx > memtop ) > + memtop = epdx; > + } > + if ( nodes_used <= 1 ) > + i = BITS_PER_LONG - 1; > + else > + i = find_first_bit(&bitfield, sizeof(unsigned long)*8); Please add the missing blanks around * . > + memnodemapsize = (memtop >> i) + 1; > + return i; Please add the missing blank line before the (main) return statement of the function. > +int __init compute_hash_shift(const struct node *nodes, > + nodeid_t numnodes, nodeid_t *nodeids) While I agree that nodeid_t can hold all necessary values, I still don't think a cound should be expressed by nodeid_t. As above - see ./CODING_STYLE. > +{ > + unsigned int shift; > + > + shift = extract_lsb_from_nodes(nodes, numnodes); > + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) > + memnodemap = _memnodemap; > + else if ( allocate_cachealigned_memnodemap() ) > + return -1; > + printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); This wants to be %u now. I'd also like to ask to drop the full stop at this occasion. > + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) > + { > + printk(KERN_INFO "Your memory is not aligned you need to " > + "rebuild your hypervisor with a bigger NODEMAPSIZE " > + "shift=%d\n", shift); Again %u please. > +/* initialize NODE_DATA given nodeid and start/end */ > +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) Please capitalize the first letter of the comment (see ./CODING_STYLE). > +void __init numa_init_array(void) > +{ > + unsigned int i; > + nodeid_t rr; > + > + /* > + * There are unfortunately some poorly designed mainboards around > + * that only connect memory to a single CPU. This breaks the 1:1 cpu->node > + * mapping. To avoid this fill in the mapping for all possible > + * CPUs, as the number of CPUs is not known yet. > + * We round robin the existing nodes. > + */ Along with the style correction re-flowing of the text would have been nice, such the lines aren't wrapped seemingly randomly without utilizing permitted line length. > +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) > +{ > + unsigned int i; > + paddr_t start = pfn_to_paddr(start_pfn); > + paddr_t end = pfn_to_paddr(end_pfn); > + > +#ifdef CONFIG_NUMA_EMU > + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) > + return; > +#endif > + > +#ifdef CONFIG_NUMA > + if ( !numa_off && !numa_scan_nodes(start, end) ) > + return; > +#endif > + > + printk(KERN_INFO "%s\n", > + numa_off ? "NUMA turned off" : "No NUMA configuration found"); > + > + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", > + start, end); > + /* setup dummy node covering all memory */ Please again capitalize the first character of the comment. > +static void cf_check dump_numa(unsigned char key) > +{ > + s_time_t now = NOW(); > + unsigned int i, j, n; > + struct domain *d; > + struct page_info *page; Along with the various other style corrections perhaps add const here? > + unsigned int page_num_node[MAX_NUMNODES]; > + const struct vnuma_info *vnuma; > + > + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, > + now); > + > + for_each_online_node ( i ) > + { > + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); > + > + printk("NODE%u start->%lu size->%lu free->%lu\n", > + i, node_start_pfn(i), node_spanned_pages(i), > + avail_node_heap_pages(i)); > + /* sanity check phys_to_nid() */ First char of comment again. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:09:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:09:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402963.644918 (Exim 4.92) (envelope-from ) id 1oWDXV-0002XU-6k; Thu, 08 Sep 2022 09:09:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402963.644918; Thu, 08 Sep 2022 09:09:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDXV-0002XL-3u; Thu, 08 Sep 2022 09:09:37 +0000 Received: by outflank-mailman (input) for mailman id 402963; Thu, 08 Sep 2022 09:09:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDXT-0002WC-QO for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:09:35 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3efa4c8-2f55-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 11:09:34 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BY5PR12MB4902.namprd12.prod.outlook.com (2603:10b6:a03:1dd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 8 Sep 2022 09:09:31 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5588.016; Thu, 8 Sep 2022 09:09:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3efa4c8-2f55-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwnCI2teHWcYpXtscT/aaWFg5elCwpWdHOtDueDd+H8FILaO5qT9pOx0mHzW4JNr2a/iwgwNjtv9iRnD2n7Qa4jzTlDkRdzm1N2VTsIDOtQrj2OhRQe2zHwT7FTT0DSPBNGH75nnzNtb5nvnMC7jgauQp0yffgJwN/3cnudL8yRnmCXzWal0KLt1m/N4bzSSQeTn9VAuATVi75HWu0qQ67Yh00h/OJ0TlluaP7PM8sN2D3oqeEl5PxF8Q18r7G3BlcaC6Zt9y9l6iETrStJAOZ8zOOXlcN10+Qk2/xRRAPLjjem0TnGzskvIKDKDy4HjD949Y7Mv35A2Nr/Wu3Rd0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BikOgYtUVL77xF+jLHmle+BEGw+kNHXT+lHOznmxu3o=; b=Ce6Jrt6/omn3gRHnMNlNFYnP8usz9kqNl8n8c38x32TRU0RSu5BJWh516MenwNKtxcvWb3dxEYZK/cm0AEe9Zaw4WstNE5ufmzrHnviF9Nd2lVvZACTXMJZVDN3KWElpjgke6AHZLL1UoKvwFTwHcEQwNRvePOetqoYH+hBW7bKovqaOS8eN7E7vRXLcqIR8it9HP5GVBXJFfQNPCt0n+WmcjTrz+GVOaZ/FQ47r2+Ws1fA9K2EUphbQlTFiE2XSmUPT53p0Aj54Y4ObNJM9PDo8SWrL+xliYAvOhz663WRSEPXzBUechPIs78KdNq9ySmyEJj0jFfPLwcR2WvXKow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BikOgYtUVL77xF+jLHmle+BEGw+kNHXT+lHOznmxu3o=; b=HTWyeVC5FfCXa0GsIvimrqJaMuOcvpE6ysUGyxIc5sDmDZKjqF48SK8RZNdByVP1w5X61x96DWGjGDoQ6ertePjO5e9xE6jWF4NSRFIPQ8k9a3oftyK4isR/B7WfFEOgQP87V7YUL/yapmuk/ErHvzLm5dDKO4MNNVoAFSW1tuY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Thu, 8 Sep 2022 10:09:25 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [for-4.17 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-3-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220902070905.1262-3-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::14) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64719357-8525-4de0-b1dc-08da9179d6cd X-MS-TrafficTypeDiagnostic: BY5PR12MB4902:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rwS6HFmAPVh48vRIMi7p+Dmhp0qm19KGXlRIpo4WHs7d1b2J8n/6ZwYKldFeBn0OnmZ4u67DeHaNbPJ00CO1Hy/BPNnlHjRFY2qPurx6Hb9iEN1wPVEDHyqYUSXfNMlaO10Do2gT/079K3gQQWDAPwylUytOygXg3xptk5V1NaAoxIfS79i9JEH3Cg0Lb1kby0utUsxPrlYcOjFrfsx0lHCvH9adNLIRCWx8rk7faDbrH6KfL1gzSL79epTpML7/3hFvw4DBgdV/LcoCJJ3fop0mLG8HoPJKL3+n27O9vS1rnk3LAWLEBngDjRw5hJZ7/vXt5uovisaFQcjPNpz6nd/wygutqg+HG60hqdP740zt6mMNySYrgQV0ubvBZFalVc7oeaaxP10aiGYagWkXsK0bYoU5rLVVbsWC27zUPsekQhWz4El2zNoblOZixNK1/JRx17RxjnFfwRhD5jNV3JHJUyuY40g3H2EoXI+gQkRQyiSGJ9oCLFJvgfRjn35nIgm4UQVlNb57Y2yz6+CYhwu740arhAsuGmhL9XHrLpe6OHoriPh+ORVRjmOwgff0e2IuViD0+/6PmGbC5BIxrqzla2wQ/inEbK8tNev6GcZGB9LVVm+NA6U7M1m4m0qJ/YLzy9JMkljMW4Wo/MlgOPHFCU1kIKiMhyhMTNaCBpNfFG19IHQbfrpzE6/VcpPLYXBqGpuDrJIHodEEcspzk69nVYjazDgfSKLtkkB4vmtJlvAqQwp3y3Te14LpDkszedikXxZC7MvNvT1DkVKHzLuIF/Or5BJwtmrJagS23mU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(5660300002)(54906003)(316002)(38100700002)(31686004)(41300700001)(6506007)(36756003)(2616005)(186003)(66476007)(478600001)(15650500001)(53546011)(8936002)(31696002)(66946007)(2906002)(26005)(6512007)(6666004)(6486002)(8676002)(66556008)(4326008)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUFuYlpFS2JjVmdtcE44TmRuYlNGQTRjTEZVYTNWeEphTmNTaU1LVzZGRENH?= =?utf-8?B?cjdNV2lpT2xQU0x3V0Y1QUg2TzNySWtoMDc5eU4yNUtMMzdIVHUrV0svbE5x?= =?utf-8?B?UWc0SEszS2hlc1M4Tzl4aDdpcnA3MVZxVGxRREp0V2FZc2VLODFlYU8vU1FS?= =?utf-8?B?RXQrcmFHSC9uTENxT1RvTjN2UFIzSHk1RENRSzE0QzQrV242SU4zTEs2ZThP?= =?utf-8?B?akN4YjdqQzY5WS9wdEpub05SOWo5T3FUMFdRNWJnTU5YRGlwVEFwSG5TcHQ2?= =?utf-8?B?L1J3Tk9Sd0s0a3o0cDhZMGRwdlljMFc1azNKZ05WOEZjbDc0cVYxSGRuYXNP?= =?utf-8?B?Z2R0NTNYMVBHNE5kM2hFODVmZlFBVVNlOHlCc21FQksxTks4OXNVMkNoeHhm?= =?utf-8?B?U3ZjaGFoRHpBZEVncUROblQ5VzJ4MkE5MU1mRDZSb3hWY24rSlMwaWxTZURO?= =?utf-8?B?ZjdSWUpHVW1zZHRXdGgyUHl5WCtpdTBqZjdkZXBDd2RvZ1hXQmxOeDBScDBa?= =?utf-8?B?aHRiTElyRlNRdElvWEhnVEFPcXVaN0FzaURFVDlOaENNcmVOZnY0UUdrbTlQ?= =?utf-8?B?anlBbjRyc1hON3R0UHJKWmxJRXp1OEpZc2lzN2xkMFdLZFZQcEROSGVsQjlu?= =?utf-8?B?R1Fiai9iTFFkSmZVeVpSelgvY0xJWFVJSG9WUHJtZGNBSXdlOTJyaWFZRHJW?= =?utf-8?B?RFdyY000bzBZOXUwM2xJNzNOdlVoZ25OSlBiWDZianU0amRkT0gyczN1bXBK?= =?utf-8?B?cEU0REdsYXd4MkI4YTlFU2wxMGRTSDNCK0ovTGFmYmFPcDB0VjNMeVI1Skhv?= =?utf-8?B?OTZZekdIRVpKUVBkTGZoclBRNGxYdEZVWnkvczlyblBzcURWa1ExUE5uSXFZ?= =?utf-8?B?bUZnazZ2ZHh0eGlsNSsyaWFra0g4dGRqTHMxK29idzhFdkRMaG91N21SdlBj?= =?utf-8?B?UlIxeHVtL1pDZ2xSK1VKZW9FOTZOdEcvY05IQzU4OGRISDRYZWoxa1pBOUd6?= =?utf-8?B?QStLd1Azb2JBbEhhYnY2NTA5WmExMnkzMno5cjVWV1NXa2ZEMVM0bk51Ni83?= =?utf-8?B?ajEwOEhWellaa2JzRHNOYndKRXlrSGo0SDhOL08vVDdYZ0pTY3gxUE9hR1lN?= =?utf-8?B?S0l1N3ZubkNFSC9QT0hvWVRiK1g3MHhCakdCMGpxdDlMUXpTVWIvSWFYY0Fi?= =?utf-8?B?RHg5MWlzYmRwVFdhZUtKcDlxSjVDeGR6V1JhZTlQU3cyWVdiUW9ibVFpUHJT?= =?utf-8?B?SnpENWV5b0h6OW5ENnlONm1wZkVoZityVTFYTEFwZW0xMUlxMHF0SXowQjdM?= =?utf-8?B?TVZ4UzhqZWNaTjdza0Y1N1pGakw4c0RpSGlYYmxNUmw0SFI0ckkxdHl1TEdj?= =?utf-8?B?QUlDN3BBdzhaT2NDMGZRYi9CVzRaQndZbnloZ1c0VnJhSXdGdXo0NCtqbWRJ?= =?utf-8?B?NkxFRVVuNy9uYVJZZ3FIdnk3azA0SldJSkVFRlBXR0VNUzFLK2pDNWxucUt5?= =?utf-8?B?QVAweEJaMW8vUW1QTXlvWTZqTlNWTGZVc3ZBcFp6VFhDeHdPRFp6aEZraEVI?= =?utf-8?B?dXNoaE01aFZaaEpSNTdRaU5GYWpXMnJad3JkMm85Y2k0ZEl1Yk11a3hnWVhQ?= =?utf-8?B?OGl3Z2xHaDNQY3IzN3VnWTg2VTZLL2NmL2lYS3NRWWE4THFWU0RVU0RsYWhn?= =?utf-8?B?TDBnZGVweTExTUpNbU5la00yNTVvN2VaVFM4WEQwL05DS0h6OUFaa2RETzhm?= =?utf-8?B?UjVpVlRzYVl0SWZnZmpIcHZlNm0rQ3c0WU9laHpTald0Q1ErZjdGUTFrQ05D?= =?utf-8?B?dWNySVR4OU9Na2F2M25ReERoaS9UdEZYTWdxdUxLTHAybzRhZVFiMURxNGdQ?= =?utf-8?B?Ny8rRXZWb3h1WFVmWFhnTVpRTFhGVXg4OExMKzYxVkRtSGpFZWFXTE5zVUVW?= =?utf-8?B?UGZrUHpIT2ZJMThNbm5OUFgxQzdDKzl4cWlKenYwYWF2MHpiOTJJR3FMVHRZ?= =?utf-8?B?Z1Qrdng1QXo2d1lKSkhHaWtzSUc1TUM2Mkg5YWlBcS9pbk4vMWJxcVhTZlF3?= =?utf-8?B?enhEbkQra25RNVQ4VGVxVWJIL0ZWTmtNSUlxVktMTFl4WjVHMklnNElJVkE5?= =?utf-8?Q?gfQE1evuH4R0sRgcI4GAZldX7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64719357-8525-4de0-b1dc-08da9179d6cd X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:09:30.9252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8dhkNBSZsKlhJHgrP0BIwFNK6DZNb/59teUasBSlkXTpz+gZcyq6GSlupPTg4YN8bLP1bq+0OqNcgTFu3xL3tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4902 On 02/09/2022 08:09, Michal Orzel wrote: > During the ping test, dom1 tries to assign an ip to eth0 in a loop. > Before setting up the network interface by dom0, this results in > printing the following error message several times: > (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device > > Silence this by redirecting stderr/stdout to /dev/null as we do not > care about the output and we should not pollute the log file. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder > --- > automation/scripts/qemu-smoke-arm64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index c80d9b2aee00..7ac96027760d 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -6,7 +6,7 @@ test_variant=$1 > > passed="passed" > check=" > -until ifconfig eth0 192.168.0.2 && ping -c 10 192.168.0.1; do > +until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do > sleep 30 > done > echo \"${passed}\" From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:18:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:18:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402983.644929 (Exim 4.92) (envelope-from ) id 1oWDg2-0004Pe-4N; Thu, 08 Sep 2022 09:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402983.644929; Thu, 08 Sep 2022 09:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDg2-0004PX-1M; Thu, 08 Sep 2022 09:18:26 +0000 Received: by outflank-mailman (input) for mailman id 402983; Thu, 08 Sep 2022 09:18:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDg0-0004PR-Nj for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:18:24 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2070.outbound.protection.outlook.com [40.107.212.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2fc889a7-2f57-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 11:18:23 +0200 (CEST) Received: from MW4PR04CA0300.namprd04.prod.outlook.com (2603:10b6:303:89::35) by DM6PR12MB4299.namprd12.prod.outlook.com (2603:10b6:5:223::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 09:18:20 +0000 Received: from CO1NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::89) by MW4PR04CA0300.outlook.office365.com (2603:10b6:303:89::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Thu, 8 Sep 2022 09:18:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT079.mail.protection.outlook.com (10.13.175.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 09:18:19 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 04:18:19 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 02:18:19 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 04:18:18 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fc889a7-2f57-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H5SA2IuLQEQWvoSgmsyET3iRlJXTPYhrug+P3KZk7SUwBO1t9GIGA7PN9kFJxPqbuXdCBqw4H+kFjWOctmu4uBlBoXLxAcx8mKNNvHU703Cbx0mE8/g4j22xYSY/pcAfzfUFFKxR6szSqeaHm0Z/phc2P6sG/RY1rdu10EQp2+LCMWvTz+JnEaSV1bGzbc21kAucufpEN4jKcOcY6V6XnMgIni5iOpkRFoRn+gV44g6Ksz6Yq6gSZ9sYL2/5GsdCKdInzfDj6LGLSKh9IbqYfwZavoqX63QiGcH9grOKzgvwyML3eUM6C299icqWdCBbE5SgPMm1bm7ZGff06VV9uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/JRfagLwxe8Mn4cKVjlgfmqszDxiPFDPL4PefAQpVJE=; b=fHKZq2lGhcbFNUL67VVd0C2oWQ0kImVYoeKStPZIb6oYRljlUSqA8LB9rndDvMnRHqCuq9EHozBCNQL27coNRJ51U5nTSrdlbbNB460vVmnU43XyQU3wflfC2tVi4WbVFIOeY42vTZGLiYLvgpVnNYfEgDhBwlNYUOhrLJXsf6KJjGPjoVphLJKQHCndJ3jGnCVxscikKUKZg3WiezShaO/cy3ew2jw4Vtqq8L4mlDB3bLQ3KS084y+xsQhtRxskQpxYzelL48nR5YGq/YXAlUo/XXzb9zLR57GWChRgm5hOb1e+0IVf1y6neDsLDK5GCce1X7o85l5DVTqdSWykSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/JRfagLwxe8Mn4cKVjlgfmqszDxiPFDPL4PefAQpVJE=; b=c0yGIuCkPUk1MG84RKcQ2zSsdTft+jrRJXZxPrajzih/m/zfh150HHN5zAcSPaBc6f1LO9f5rh+DJKAEpb1Np9yVv3HQzPhuf/6r0Rj/ot6i0mT9rtSvChmeVz9918dj6bDlQXN1CdSVqh/f7tHf/KjUv3QBSdIrBzu8BE8qzus= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <86bf3f23-80ba-54a1-ff87-2fe45cd1c181@amd.com> Date: Thu, 8 Sep 2022 11:18:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 Content-Language: en-US To: Ayan Kumar Halder , CC: Doug Goldstein , Stefano Stabellini References: <20220902070905.1262-1-michal.orzel@amd.com> <20220902070905.1262-2-michal.orzel@amd.com> <2c2c0315-8694-d9ef-5f08-01c7bce3329a@amd.com> From: Michal Orzel In-Reply-To: <2c2c0315-8694-d9ef-5f08-01c7bce3329a@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT079:EE_|DM6PR12MB4299:EE_ X-MS-Office365-Filtering-Correlation-Id: 5453b115-aa9b-43d7-b35e-08da917b1235 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lNpiz0hP/LFPQMpf6KZaxU/rQXTlxcW6nAJ2QVh9kQXplJcHandxvnsgN7MTZOZvgPyVrjEZazewe4knZ1CNyfULLBpXq1OFtfkG0puja26cydstQuSx2JCX0diCj4wZD85R+siVs1A0qD+JpYgk21kAoRbxl9D6pT5pmShXfVpWznV9qmLKyr8ACezyua+zaxaPuWoJhof7KkK+Rsi0nDiUonY9HvxZ7qNaiOMT4rDNzYL6pNgQYN5i/7Zcri0k1sr3tXoqog7OWwuHe7BTsvDlIL0C/Kvuw/4TaV0jqPRzGmjRhWXdagcCmBrVYwnde6rY09trKdI/h5a0oTJZHYrHSIFmvD/o/qyNsepAeL4+QbxRr/MI0v1+M0hSG7YEjyRfAcmyf+OmIGXS8zJh/6KOefsy3KpMbRA5xbx1TWytZWJwqNN1u5Ys31AvJJNIAZCjDa/1/WKJECpxRXClhCmBq7UJNpqhIKPV14+38cLNSR9hpyKFpj3Rx3Uea3nYcw8C7/MDsVdemw5VmwDlCT36y1As2rzvtdpXGWay0IypZKHxngBsAYlb+KW9V7JLUjM3grIhVVgFimYHviSNNn2D1C5e0Dt/x2nK91n15TZx4DPWlAvEthAe7sYCyc8mjwziwiOCSBR6/v2VYY+tl5BhVxHc+rrfRGbJGQMYd9f1K52v14zqoFLvILlYcrD1qa14k5ukBuYpfunBZjuHEoAAeA+0tDhIrvtJIbahTUmaas+BQHULUd5YwXkQZxqkMLAaICXP5cUnPKXfrj3NaUUadQQUPtCR7TooUJJcEgZ9tmcsZ4ME0tn0dggfq0Bm9UarTikrOfRSkh9YiYb3qA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(39860400002)(136003)(46966006)(40470700004)(36840700001)(70206006)(31696002)(2616005)(8676002)(44832011)(336012)(4326008)(86362001)(426003)(53546011)(47076005)(186003)(5660300002)(36756003)(31686004)(4744005)(40480700001)(70586007)(82310400005)(2906002)(8936002)(16576012)(110136005)(54906003)(316002)(478600001)(26005)(356005)(82740400003)(41300700001)(83380400001)(40460700003)(36860700001)(81166007)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:18:19.6985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5453b115-aa9b-43d7-b35e-08da917b1235 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4299 Hi Ayan, On 08/09/2022 11:07, Ayan Kumar Halder wrote: > Hi Michal, > > On 02/09/2022 08:09, Michal Orzel wrote: >> After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having >> two kernel configurations. This is something not needed and maintaining >> a single kernel version is always easier. Modify qemu-alpine-arm64-gcc >> to use kernel 5.19 and remove kernel 5.9 from tests-artifacts. >> >> Signed-off-by: Michal Orzel > Reviewed-by: Ayan Kumar Halder > > Question unrelated to the patch. > > When do we decide that we need to upgrade the kernel version ? Usually when we need a feature from the newer kernel version. Upgrade to 5.19 was done so that we can test dom0less enhanced as this kernel introduced late xenstore initialization. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:22:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402994.644946 (Exim 4.92) (envelope-from ) id 1oWDkB-00066R-3z; Thu, 08 Sep 2022 09:22:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402994.644946; Thu, 08 Sep 2022 09:22:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkA-00065X-Tp; Thu, 08 Sep 2022 09:22:42 +0000 Received: by outflank-mailman (input) for mailman id 402994; Thu, 08 Sep 2022 09:22:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDk9-00062t-PT for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:22:41 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2059.outbound.protection.outlook.com [40.107.243.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c8bb93aa-2f57-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 11:22:40 +0200 (CEST) Received: from MW4PR02CA0004.namprd02.prod.outlook.com (2603:10b6:303:16d::19) by MW4PR12MB6949.namprd12.prod.outlook.com (2603:10b6:303:208::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Thu, 8 Sep 2022 09:22:37 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::84) by MW4PR02CA0004.outlook.office365.com (2603:10b6:303:16d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15 via Frontend Transport; Thu, 8 Sep 2022 09:22:37 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 09:22:36 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 04:22:35 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 04:22:34 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8bb93aa-2f57-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAmnqea1r1TWORAioI2l0a5veDLrZo7PSHHsPU1eC0UE/Y//wMOSzDZRSvJVPYwkStXwiMcSkvmgPFDxcFoFK2mUJlJmT1Qql5ji7XfAEn+5ozx8k703imXdbB2+++ECFbQr/KJG+dz81guh5161TrLkUltEcKTrHoOoyi0L4BGH8br0DMILezil+vzLLNrcQEA1jzoQ0g6X8nM/nXXruL5fmmo//ZQ6oeFpDwI7LQxxt+iSArwJufHloqub4AYOip4FX7rF2GG7sXBiZY/JN+j3ri8ibhj3GTGnc3oTeOZQ0GhTHXaqOOd/r2h0JRzWBjitCap8iCyjKo4UpUMJaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tyfchKA7NgWWrIrLugjPaY2e//gdOL9mWhpHot2OCqg=; b=ICkS6HZq2fe3AOjC/blGL7qfRHcYQhBDAPiHPHeTkqB4iL7EIbo5/J64I2Zx1pJPZLJw4EcoMZguyJIfpVQKlncbR05bc0ZkwSHCsX6clTqHMWU0eKk9cPilys0japDGxJOdEe1kiflcv+61zfM05TWHss4vfPSw09icc0kZRUtelz+NMnKD0ymkGEZzpLF0vIh9nPjHkQthuJN4gsvIXypdyX0EgUV7blSQt7QYyKehP0cKAeNhV+lxaLkJ3176esR+2o14haf2RBnouHOUDwJKEdZY+Ny2QJhTxjOYN2OrDASsS6KXhQI3RwL7F6ArYq3SsMah5qGDauoGy7++NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyfchKA7NgWWrIrLugjPaY2e//gdOL9mWhpHot2OCqg=; b=dOAyNW3Ak/S6wqPwAiqXp38at/fXYNPoX5lQx5MhBty+3pdw46lsXpXl6IC77py4gnLeNkjyu/QX7NLZk1ywOTrQiy0quioFvkhXYEpW++d4/WvQDTfDaHJzFzbacxHXLGYAe5WrQho00fyLJjA30MCsn4qP/uzqyBF5FQNjRyE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Luca Fancellu , Ayan Kumar Halder Subject: [for-4.17 v2 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 Date: Thu, 8 Sep 2022 11:22:28 +0200 Message-ID: <20220908092230.21421-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908092230.21421-1-michal.orzel@amd.com> References: <20220908092230.21421-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT056:EE_|MW4PR12MB6949:EE_ X-MS-Office365-Filtering-Correlation-Id: d54294cb-a9f9-4f26-5d7e-08da917bab92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SjIiWqALMBxzrnh8u0JllRhyAJnUvrutBn2hSL2dk5NeHmrm+M+oS01Jvwh2+6XXozmNGBzInNnDdWLY1emjZi8pfqKK8f59m56P/WrHbYp7m9KpOA6RzBX3Pfwe/3eLM7HgGHlYfRBe0ooVVZLiCyin7vjw39Zppk9ThxikMFeco0AFPn+eXtaN0vj8vj3JLuyqutX6eK/sRlJg9Ib8PITrglzwtIBWe6BJvUMJsg7yqXJaI5OIR8w6nQGcqvQEYJT0SScUGz+Ty7mY80FMsBbg0ZPRzUoF2fBAzJXfIOeKBnYVqa/Qq8n7cM7i7RBnSVYHMpBbeAPcZ6RK388yKaUzCsBjcjlBV3ZK6HtSu/HakOpuz/+vPa7kz3u42twmkgDcFrw4ygO80VArMmEKZAQ481+CPHuaQEzMd0QFvsmiMKY4RVLE97Y3j+soKTpn6wd8n8R14M1f4chcuRUytV7SIyil0uK3+YREyaeLF8SkaN4+56ewACmiM6nfjdSM4/yBB9ID6zgimAbOYgq5F7vy3Xy3tsKu/FRXLFUAsnJ1RA1VnJrttu0c3lYulCr8gKZoi4ce3Y9ljA4TbgYVsARG1en0bVM7KdvnqJPH7Ngc/cdFywRoJTze/SGUAqJcM8n9pbit/qphmvNhJT/pO6iLFvUtLfemWxxvn1kNhFaHYMohxawVZ7sRx81R9LJnKLiDOL7s2uPXODOzVpqjWJzdEJJXzY7+YxKX4ocLQTy0DBUhA2OFuZa0nI2/fRocu8hYPX86AoYtA0w/6/5GvP5AATmciGf1ikB3LO3whIQ8bW5qtgPT479l0Wmk7r2aP6YuhPRuv1xP/qO/v885Pw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966006)(36840700001)(40470700004)(40480700001)(316002)(36756003)(41300700001)(82310400005)(81166007)(356005)(82740400003)(6916009)(54906003)(36860700001)(4326008)(966005)(44832011)(478600001)(70206006)(47076005)(5660300002)(70586007)(8676002)(84970400001)(83380400001)(336012)(8936002)(426003)(86362001)(186003)(2616005)(2906002)(6666004)(26005)(40460700003)(1076003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:22:36.9816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d54294cb-a9f9-4f26-5d7e-08da917bab92 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6949 After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having two kernel configurations. This is something not needed and maintaining a single kernel version is always easier. Modify qemu-alpine-arm64-gcc to use kernel 5.19 and remove kernel 5.9 from tests-artifacts. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Ayan Kumar Halder --- Changes in v2: - none --- automation/gitlab-ci/build.yaml | 11 ------ automation/gitlab-ci/test.yaml | 2 +- .../kernel/5.9.9-arm64v8.dockerfile | 34 ------------------- 3 files changed, 1 insertion(+), 46 deletions(-) delete mode 100644 automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index d2f75a090c0f..720ce6e07ba0 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -586,17 +586,6 @@ alpine-3.12-arm64-rootfs-export: tags: - arm64 -kernel-5.9.9-arm64-export: - extends: .test-jobs-artifact-common - image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.9.9-arm64v8 - script: - - mkdir binaries && cp /Image binaries/Image - artifacts: - paths: - - binaries/Image - tags: - - arm64 - kernel-5.19-arm64-export: extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.19-arm64v8 diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 2eb6c3866e2c..07209820b474 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -34,7 +34,7 @@ qemu-alpine-arm64-gcc: needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export - - kernel-5.9.9-arm64-export + - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export artifacts: paths: diff --git a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile b/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile deleted file mode 100644 index 053d65a3454e..000000000000 --- a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile +++ /dev/null @@ -1,34 +0,0 @@ -FROM arm64v8/debian:unstable -LABEL maintainer.name="The Xen Project" \ - maintainer.email="xen-devel@lists.xenproject.org" - -ENV DEBIAN_FRONTEND=noninteractive -ENV LINUX_VERSION=5.9.9 -ENV USER root - -RUN mkdir /build -WORKDIR /build - -# build depends -RUN apt-get update && \ - apt-get --quiet --yes install \ - build-essential \ - libssl-dev \ - bc \ - curl \ - flex \ - bison \ - && \ - \ - # Build the kernel - curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \ - tar xvJf linux-"$LINUX_VERSION".tar.xz && \ - cd linux-"$LINUX_VERSION" && \ - make defconfig && \ - make -j$(nproc) Image.gz && \ - cp arch/arm64/boot/Image / && \ - cd /build && \ - rm -rf linux-"$LINUX_VERSION"* && \ - apt-get autoremove -y && \ - apt-get clean && \ - rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:22:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402993.644940 (Exim 4.92) (envelope-from ) id 1oWDkA-00063B-Pi; Thu, 08 Sep 2022 09:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402993.644940; Thu, 08 Sep 2022 09:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkA-000634-MN; Thu, 08 Sep 2022 09:22:42 +0000 Received: by outflank-mailman (input) for mailman id 402993; Thu, 08 Sep 2022 09:22:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDk9-00062s-GL for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:22:41 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c85641d1-2f57-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 11:22:40 +0200 (CEST) Received: from MW4PR03CA0359.namprd03.prod.outlook.com (2603:10b6:303:dc::34) by DM6PR12MB4154.namprd12.prod.outlook.com (2603:10b6:5:21d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Thu, 8 Sep 2022 09:22:35 +0000 Received: from CO1NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::18) by MW4PR03CA0359.outlook.office365.com (2603:10b6:303:dc::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 09:22:35 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT028.mail.protection.outlook.com (10.13.175.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 09:22:34 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 04:22:33 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 04:22:32 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c85641d1-2f57-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TStrnrH/6K159MtoqzHrAFPgpk3OdA5BOebRW8diHyQXrpaY6jOFPC2MJDrTbryp/ixVl5DTZBuXFwwpLn9T1Vvo2Ir2akC9UCyJd7YfZYAr1p+2ASwVMfGq7NqN703Kt3DFMVmsc1O1MsfCJzrnrxfe6iV7WJo+AtwuC7TvoaSzlc3rRK1jBkskC96lCXG2cKUNz8QaANlKujmSitJtXvZlVoUPKauaKmvVZ597Lh6dvM2RK2rxL/wa7i2cl4Bmwf+O8rXpN2jkYO8ZWSVv860E7t4Sk05qU/WrtZmaWXg/Mqyep2zWaEbj6AmbGvlxpl29/0FCOPS5oh19vVqUtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGowwKByJkESWe8YZ9ffA5s4KxBegBee6qfPCvv+E9A=; b=Lpk6BjNS/AVSej1MXxO12LFjBAA45X209i3sLjnEPDN3HSjRBIc2rdW4wezDiBkNiPbvsMYb+CfodquxuSRhB4mTiUD8eo5ZEK246jvCrrOgNLYb5xtmE4qP3yFOc1dA6Riv6bMTief63n9u5wnLO+JO3NmGRNnzoiRft8u84Fg3BqDIVw+V1YxSWj2M7v+MbxNRLVD9AjZoRnCW2Z8DowAX3kme+L1pH88x8Ezwxz+uG4Pv/kYTAN68h1RiU3GzIRz/L19n6CTsP55f6gSST6GmXCWQDHklDdqmjhtmPcSjxgRc7e5EtoztbwNpRhqDz5TNRiOZj3Iu+cU03hzaqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGowwKByJkESWe8YZ9ffA5s4KxBegBee6qfPCvv+E9A=; b=DKuSAc34xG/xs/gVNJKqt3alVesE45ss+dkbqw6iUJplWyCzhcAjAhggoAaOVy6rmITofcQRkab7bkxuLtNxiFTvHYkmGsdx9R8IYripiRr0LOeGQRncKBRpoWXQgcJrII8TRgUrUfNkYIrOpB9Ro36pPbDsid4mxfslCjzKIvg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [for-4.17 v2 0/3] GitLab CI cleanup and boot time cpupools test Date: Thu, 8 Sep 2022 11:22:27 +0200 Message-ID: <20220908092230.21421-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT028:EE_|DM6PR12MB4154:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b116774-f8a7-42c7-967a-08da917baa25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CoGr8mqAxUQOWJzM8xOHDgNolweEE6FTO+WUTBcy8RRQo/Tbn6gLVK6VoVa9fHhX/BykKE1MMTw0L7FQrq+NYAfuFmLHHfE9Ekv6IIsRnqAAkiyI3GrtK2rf9xTR0PpFSeT1xnCJnx0m/Ar4QK0i0bTCyxf0ItAv5tT1VF46moP8qqsTG4f1I+qjss89AioXAWBO86iPaTqX/BgBeTo796YJYBzXR5Vzd0uAMIrrf9O7E1Zi2SA+nENM9tzRC8mWBbjAyyiQ1EF4kdoKp257T7jNtsCXFFrXXbiujKpzF1CsbDlHAd16azt3872Mmq+k3QFZgdMDpiAdFt9osJe3iu7rrHaTaeZ8JDFD0fbd1O0pNDESgT9RT5+QYHwBpvu6JI7FUHnvQcZUs4EHj9nZW5+iBgUxSVnUdvuCs+cDN7X8jnOcoped8wzdYZTzmS3CC2sb5jdEXF78fBbf5nQOr+15ZaHHY7ymMVUSDt/F1h1WLIVX+bMYXvH9rb5+zbh6OIU/T4w5Fvn1sZGfo6uLRsWvtEZFg+NMOiUzmP+s3+4WYmetn6EcjFhYqxRJEcEOJ0dbG6WbWBJT2mc4NjW9DscNWm/+vRel6HUrooMzly+z1qcGxt1HWV/inWkH1H9ItnFxVf3f8je4CFwnGdBQEcz/KLyHAFqoqvBIznyWKBdz6S04KoOAiWIz4PPGlBlXM+I72P/r1feJBcRY1AU7FXdsXkWJsboLl0bTjmU0fNLCeOK+ZKOgY7w0aQe9WSNxssYFsVxJ0Fr09/urGiI42Xs9EqBCH4oQ2g7bRHQqiZ3HQ4333rA/ShMwiw7TJudv X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(396003)(39860400002)(36840700001)(40470700004)(46966006)(478600001)(336012)(426003)(47076005)(186003)(83380400001)(4326008)(6666004)(1076003)(8676002)(2616005)(36756003)(41300700001)(26005)(86362001)(2906002)(82310400005)(70206006)(6916009)(316002)(40460700003)(36860700001)(54906003)(4744005)(5660300002)(44832011)(70586007)(8936002)(356005)(82740400003)(40480700001)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:22:34.6066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b116774-f8a7-42c7-967a-08da917baa25 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4154 This patch series performs a small cleanup before the release and adds a test for validating boot time cpupools feature introduced in 4.17. Notes for the release manager: Benefits: - improved dom0less test coverage - tested feature that is introduced in 4.17 Risks: - CI pipeline failure Michal Orzel (3): automation: qemu-alpine-arm64-gcc: Use kernel 5.19 automation: qemu-smoke-arm64: Silence ifconfig error messages automation: Add a new job for testing boot time cpupools on arm64 automation/gitlab-ci/build.yaml | 11 ------ automation/gitlab-ci/test.yaml | 21 +++++++++- automation/scripts/build | 3 +- automation/scripts/qemu-smoke-arm64.sh | 38 ++++++++++++++----- .../kernel/5.9.9-arm64v8.dockerfile | 34 ----------------- 5 files changed, 50 insertions(+), 57 deletions(-) delete mode 100644 automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:22:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402995.644962 (Exim 4.92) (envelope-from ) id 1oWDkC-0006Z8-CH; Thu, 08 Sep 2022 09:22:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402995.644962; Thu, 08 Sep 2022 09:22:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkC-0006Yv-7p; Thu, 08 Sep 2022 09:22:44 +0000 Received: by outflank-mailman (input) for mailman id 402995; Thu, 08 Sep 2022 09:22:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkB-00062s-Hl for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:22:43 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2064.outbound.protection.outlook.com [40.107.223.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca847a7b-2f57-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 11:22:42 +0200 (CEST) Received: from MW4PR03CA0346.namprd03.prod.outlook.com (2603:10b6:303:dc::21) by DM4PR12MB5184.namprd12.prod.outlook.com (2603:10b6:5:397::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Thu, 8 Sep 2022 09:22:39 +0000 Received: from CO1NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::b4) by MW4PR03CA0346.outlook.office365.com (2603:10b6:303:dc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Thu, 8 Sep 2022 09:22:39 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT064.mail.protection.outlook.com (10.13.175.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 09:22:39 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 04:22:37 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 04:22:36 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca847a7b-2f57-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JxN2pbZRREUTXnEVTnw+wReYdUTCGtUKqkFh3lS2t9pAYa6HIlTNXlofngLiIwSoq9do5Glzu06XxxJRqXwnM9d4Qzprg0yWnZr0oM2Wjqm3ojwrAQfgLfGpBIG7z8zFyDUVcrnxfnBB7rUuWwvCJrAM9oeTvwPQbQnmFgFqRiiZxtqGeANU3bXcPGtMoTY+53/saAz5BMhQNkmLpRhtMz0aeDHhADzmVNUrvzWK/hFDrflgJJbWhsaE3p7BUeUlgG0HWifrlme1U74l1dymtqyUx9XdbFx5lnOIfAJbtPKYjtXhDb4R+eJGxwGy7IVxGx4DvL5sfEnYtNb2DpJtkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jvUwy5NfFiVoeWjuPBA52OtQW6Tn5x/aILqdyOhSfG8=; b=djBgLSL1x9hA58gRko08qu811zYuagxl+4fuQWUA2OlQRsr1tSscg35JpFKxATVNMloEX97OExlkaHP5fKAkE7PZcDS93RMyIFcQLZQSie/PAl63a13Wt7wKPPiqIVBf1oxdKbCLK+iFqSHxR1KMSl1K2rZ+2fH6aHJ3JbHuZfttCu2AlA2EP0vDtYCPirTVCf7WzUGdM5U35pTwav9AUFue7w6rIr98XYYaUatoErzBJOtv24DehV7WksGsk/tN8+uI7WuGssX1F6ScmMjttecNSREWbj9VOMOXUReL2lHRyaNmLC0aS//M2dEgwpuvl4P2Z0OW+1jsAH/mSuksXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jvUwy5NfFiVoeWjuPBA52OtQW6Tn5x/aILqdyOhSfG8=; b=rf0FY1gxBXhgoCo1QUc01zHERgeZ1G34lIjxARi4UtfqWnA68h8R1FeAdIVjM0FtNAuHLTFYb6B0y0BDpeUq5kkLhr+o/SmJEvmBLTElWi4H8/+DzeZ5rWxbrCiZuzq2V96vtZpsAyoKsWC5yx8M733sNoQ3SA0Lwi7aI5ZcsSc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Luca Fancellu , Ayan Kumar Halder Subject: [for-4.17 v2 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages Date: Thu, 8 Sep 2022 11:22:29 +0200 Message-ID: <20220908092230.21421-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908092230.21421-1-michal.orzel@amd.com> References: <20220908092230.21421-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT064:EE_|DM4PR12MB5184:EE_ X-MS-Office365-Filtering-Correlation-Id: 25cdd7fe-2187-4e0d-e258-08da917bacdd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZGbRchYuTW71s6rPUZJj/3OkLRT5VOFprifrKEliSAW1ZAWtkFKL2KbvhiEORu5fu85sAonA0z6cITyPLGc4C/CDuMU5YEeMWJvMnykVjjx5610Af815IqUpGJse20f9hyGu0m3+vpcTQaBZ8WLQ+wmhvxf7vg4KcGP3NGnK+FC7vF+kcaLqk/bmipY+zW6cLj5p496KN/y2Op9ZIrwMt0WmAd/xKzHQNvsOIGtP7rSP0LGnHmsgZvk9Eb2+ggjrAOcBpI5HG6Uj0xNDFhPtkhYXHNpKBavuVdjaca6fzAvycK43mNUpZYwurbiY1jctPx+JAC7eqjk96LfR7YYPPvMnxFlR99ieadcP6Iwy56s43dluVW3KN5AH+0erSgzE3kZn4lGY1P+H6zyFJHhBW25e2aPML84u1Dr6yG1n64nMH4EaRlyW7nRhqf8FZ6X6QzGDg9Z46HeXAdF3WbMfK1glz17lfNHc7SBPMcSod3ZGryxtEMTXwbbnNR7gxcHdRYDQVZge2X7M4N4GUfvL/9sUCUw6RmhfDOt9lee+g0zyWnkjcMFtn7gvNX9dIB6BfkbJEP1gO1wCwWp4zckkSI+xyPvR1UYFm5tDVwI8LCDLguruSuCoSK3OOGO5/fYok/a7NW9Tl+4e4Q+E02rzfjg8p2Q9eApRNi0eXxv7wZ4Zy30iAtnqkUCWSrpiyLLA6KDjmxOzjHQLEc6KsHudcQxg3yhpl09rvPVlfAfnwie4Rb3MoNMWm/28RpCthYFjWfJ/S+lzCuVXDtsNnjQvt5d6GajpC5uMkW+VhmADClh8nXMgY3VnRJMaIlZyVAMC X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(40470700004)(46966006)(36840700001)(5660300002)(6916009)(54906003)(316002)(36860700001)(36756003)(70586007)(44832011)(8676002)(2906002)(8936002)(4326008)(15650500001)(70206006)(82310400005)(478600001)(86362001)(2616005)(41300700001)(426003)(40480700001)(1076003)(82740400003)(186003)(47076005)(81166007)(83380400001)(26005)(336012)(40460700003)(356005)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:22:39.0761 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25cdd7fe-2187-4e0d-e258-08da917bacdd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5184 During the ping test, dom1 tries to assign an ip to eth0 in a loop. Before setting up the network interface by dom0, this results in printing the following error message several times: (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device Silence this by redirecting stderr/stdout to /dev/null as we do not care about the output and we should not pollute the log file. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Ayan Kumar Halder --- Changes in v2: - none --- automation/scripts/qemu-smoke-arm64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index c80d9b2aee00..7ac96027760d 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -6,7 +6,7 @@ test_variant=$1 passed="passed" check=" -until ifconfig eth0 192.168.0.2 && ping -c 10 192.168.0.1; do +until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do sleep 30 done echo \"${passed}\" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:22:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:22:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.402996.644973 (Exim 4.92) (envelope-from ) id 1oWDkD-0006qN-LY; Thu, 08 Sep 2022 09:22:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 402996.644973; Thu, 08 Sep 2022 09:22:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkD-0006qG-I7; Thu, 08 Sep 2022 09:22:45 +0000 Received: by outflank-mailman (input) for mailman id 402996; Thu, 08 Sep 2022 09:22:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkC-00062t-MS for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:22:44 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cac4280c-2f57-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 11:22:43 +0200 (CEST) Received: from MW4PR03CA0343.namprd03.prod.outlook.com (2603:10b6:303:dc::18) by DS0PR12MB7679.namprd12.prod.outlook.com (2603:10b6:8:134::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 8 Sep 2022 09:22:40 +0000 Received: from CO1NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::eb) by MW4PR03CA0343.outlook.office365.com (2603:10b6:303:dc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17 via Frontend Transport; Thu, 8 Sep 2022 09:22:40 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT064.mail.protection.outlook.com (10.13.175.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 09:22:40 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 04:22:39 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 04:22:38 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cac4280c-2f57-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlxrDuuxlsysefRUm10G1uLEigfCDRc7H0kWIm3gC5c790A5mhnUCpET7UwSqdhdmenscxPeZSSTuj7bELnxTS552YQSsLEn2CNizm7Fn0HfEzncPrxBNXKM4OcmFqklHM1xTIS0XVQUDnEALr++o3TPJ0vHdrEN6BVy7TVd7rOUDr+JuIGuJC65uTvO6gkzwkGwcQivut8faVTGwqwttNwaas+hcCDu6IqS+2X23BX5oceR3Ugt3Brt/CqG0cvC7Fa/yiw3JC6SCQIaAz5k3fzsTuwC/9bJnoN7zRMS+Or7/7IM6GRCjxwnFcTPJW2hyvO+2HaAbN4qPKiwpwcTZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/RWuT6WWjwt9nx2ahhlPfQEA0lD6Hh30SG14hqOTvI=; b=UNjxZe2DoC6G2ImPYoFSJF8QfkODX6+3vVNbc2rCaqZT23PKzTadRhQ88T1iaE41q7S6S+yOzFBdOD359MTQl0/OwOTwyXTTW9E6CuJ63dAcyXYCyBjgTiOu9j78sLWwyQNxHA4HNch8yAcSa7z4LpHuIMMc9VTrjpwh61LGNF/G5I6T1jsl5cVfWoANttbDXr1vfFdZ876x2d//DBICai6qIFchRhZHffR9wwwN7aaLPpmAYm5SYTxbt/dG/oJimiztYYTMNv/mVQsQT0mA5952V04z87KtKnOM7vo1059ZYALv+NZmc0woFX3sDChTbNqUJE41bIVYQKA8y+QM4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/RWuT6WWjwt9nx2ahhlPfQEA0lD6Hh30SG14hqOTvI=; b=s2+Nm3rpAWGRAvGLa1msdTPDOSjGQJp4EququafMLpONtePkArdsdPg1W7D4bpplTO5llMNJ925QEw0HizCwNiNNr7fUpBabgPCjGCVyEBrHO6XMSVgCTTbS20GXxdZyXaYuXP4vwewOCeHXsNxdbHq3w+CoVD3CXYs+rK63wEU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [for-4.17 v2 3/3] automation: Add a new job for testing boot time cpupools on arm64 Date: Thu, 8 Sep 2022 11:22:30 +0200 Message-ID: <20220908092230.21421-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908092230.21421-1-michal.orzel@amd.com> References: <20220908092230.21421-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT064:EE_|DS0PR12MB7679:EE_ X-MS-Office365-Filtering-Correlation-Id: 35cb52e7-1e79-48fe-7450-08da917bad95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xbJBGhi4WGsBxoxWU1sGB77/b7fURX5gCEqpN58THn8zSjcV4dIgBwyPnNVzzMBdEjZCBD9IVQw4elUXsramhbioyaqKQNH+4uHOhULDx2LiaAtILU7GkqsjKW/GTLEv9xs7GSxL1MPafHQZbqqTjmvjClfxDX69MMULY4eLdCU3wBJEpajNRdwHGdPj+8dIftl0NiXlZNm3m2yU4tmSAtxQJp3Kw2/FgoNyKkkem0MDsebSNejil3jfp3J++Y9kUg20cxDdSBHBJ+/Bcg0EuRm6Xzd8/zACokOafkA2Sx2snzHXAcsn6ObFZynZYwLymNdpgw7JREjBLQ88Ir8bphrmo+xw9BA6Y2xbx/3AXncRrraf1U4rLsll6dNMON3iOl+omM2VT/twdAX1sewGiUvajJAMeZC1Mhr4LQHZItOqNLnx+Ztmw4p2YT4ccfiuNj4OKICzKEx9cHLW4QaY5XYohc9xHYI7ugBBGLc4Ew7gn2d3EnRWf5wFsPMJIEWK4F5YHynQfTf286WTow6JSLp7BGXfleSQw/l66LnAfLbOVEeosNXvsX8bMOc/i1xqYSCkhksCHXHiCEQBpZok0KhZ+G+J+lmAjm9YeiRQrMTmPFb5blqKSanEKbt2HuOsIGTc8s1ykDPetOf+WyLKoeppMqw3/7tOi9venutwYmiHOu1Ja9BRhVrvjqqdlKj3ZgZuj/zayVpd8XrfH057YJbnGxrw94HslOU7J+cEsZm37/A285NHsYYjFLj/5aGuPfJVyKrFd1xeF9ISlSagjPJ+gZjjyb1jKhQ+C/ISjpjb2FzC+rAwx7DPg3hYL9uyUY0gdGEuu+oauEGjjkE5jnALRcLkJuezSTdidVVurKABpgXj9o4RW0ERmMKLrg7HsEZgFJYPsuKkHR5fvXT7GUjULqrazHb+vn8clOFSpck= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(346002)(136003)(46966006)(40470700004)(36840700001)(316002)(83380400001)(8676002)(70206006)(4326008)(41300700001)(6666004)(6916009)(54906003)(82310400005)(2616005)(86362001)(36756003)(1076003)(336012)(426003)(186003)(26005)(70586007)(47076005)(8936002)(81166007)(44832011)(5660300002)(356005)(2906002)(36860700001)(40480700001)(478600001)(966005)(82740400003)(40460700003)(157313001)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 09:22:40.3104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35cb52e7-1e79-48fe-7450-08da917bad95 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7679 Add a new test job qemu-smoke-arm64-gcc-boot-cpupools that will execute script qemu-smoke-arm64.sh to test boot time cpupools feature. Enable CONFIG_BOOT_TIME_CPUPOOLS for the arm64 build and add a new test case in qemu-smoke-arm64.sh that if selected will make use of the ImageBuilder feature to create cpupool with cpu@1, null scheduler and assign it to domU. Add a check in dom0 xen.start to see if domU is assigned a Pool-1 with null scheduler. Take the opportunity to refactor the qemu-smoke-arm64.sh script as follows: - use domU_check to store the test's commands to be run from domU - use dom0_check to store the test's commands to be run from dom0 - use fdtput instead of sed to perform dtb modifications - use more meaningful messages for "passed" variable. This way we can grep for messages reported either by domU or dom0 and get rid of assumption that tests can only be run from domU Signed-off-by: Michal Orzel --- Changes in v2: - use ImageBuilder feature to create boot-time cpupools - also check if the scheduler is set up properly --- automation/gitlab-ci/test.yaml | 19 ++++++++++++++ automation/scripts/build | 3 ++- automation/scripts/qemu-smoke-arm64.sh | 36 +++++++++++++++++++------- 3 files changed, 48 insertions(+), 10 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 07209820b474..d899b3bdbf7a 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -100,6 +100,25 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 +qemu-smoke-arm64-gcc-boot-cpupools: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: diff --git a/automation/scripts/build b/automation/scripts/build index 2b9f2d2b541a..2f15ab3198e6 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -19,7 +19,8 @@ else echo " CONFIG_EXPERT=y CONFIG_UNSUPPORTED=y -CONFIG_STATIC_MEMORY=y" > xen/.config +CONFIG_STATIC_MEMORY=y +CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config make -j$(nproc) -C xen olddefconfig else make -j$(nproc) -C xen defconfig diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 7ac96027760d..f803835779f4 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -4,20 +4,22 @@ set -ex test_variant=$1 -passed="passed" -check=" +if [ -z "${test_variant}" ]; then + passed="ping test passed" + domU_check=" until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do sleep 30 done echo \"${passed}\" " +fi if [[ "${test_variant}" == "static-mem" ]]; then # Memory range that is statically allocated to DOM1 domu_base="50000000" domu_size="10000000" passed="${test_variant} test passed" - check=" + domU_check=" current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) if [[ \"\${expected}\" == \"\${current}\" ]]; then @@ -26,6 +28,16 @@ fi " fi +if [[ "${test_variant}" == "boot-cpupools" ]]; then + # Check if domU0 (id=1) is assigned to Pool-1 with null scheduler + passed="${test_variant} test passed" + dom0_check=" +if xl list -c 1 | grep -q Pool-1 && xl cpupool-list Pool-1 | grep -q Pool-1; then + echo ${passed} +fi +" +fi + export DEBIAN_FRONTENT=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ @@ -42,11 +54,9 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -cpu cortex-a57 -machine type=virt \ -m 1024 -smp 2 -display none \ -machine dumpdtb=binaries/virt-gicv2.dtb -# XXX disable pl061 to avoid Linux crash -dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv2.dts > binaries/virt-gicv2-edited.dts -dtc -I dts -O dtb binaries/virt-gicv2-edited.dts > binaries/virt-gicv2.dtb +# XXX disable pl061 to avoid Linux crash +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled # Busybox mkdir -p initrd @@ -66,7 +76,7 @@ echo "#!/bin/sh mount -t proc proc /proc mount -t sysfs sysfs /sys mount -t devtmpfs devtmpfs /dev -${check} +${domU_check} /bin/sh" > initrd/init chmod +x initrd/init cd initrd @@ -98,6 +108,7 @@ ifconfig xenbr0 up ifconfig xenbr0 192.168.0.1 xl network-attach 1 type=vif +${dom0_check} " > etc/local.d/xen.start chmod +x etc/local.d/xen.start echo "rc_verbose=yes" >> etc/rc.conf @@ -127,6 +138,13 @@ if [[ "${test_variant}" == "static-mem" ]]; then echo -e "\nDOMU_STATIC_MEM[0]=\"0x${domu_base} 0x${domu_size}\"" >> binaries/config fi +if [[ "${test_variant}" == "boot-cpupools" ]]; then + echo ' +CPUPOOL[0]="cpu@1 null" +DOMU_CPUPOOL[0]=0 +NUM_CPUPOOLS=1' >> binaries/config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config @@ -148,5 +166,5 @@ timeout -k 1 240 \ -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial set -e -(grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "DOM1: ${passed}" smoke.serial) || exit 1 +(grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "${passed}" smoke.serial) || exit 1 exit 0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:23:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:23:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403000.644984 (Exim 4.92) (envelope-from ) id 1oWDkT-0007e9-3R; Thu, 08 Sep 2022 09:23:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403000.644984; Thu, 08 Sep 2022 09:23:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkT-0007dT-0K; Thu, 08 Sep 2022 09:23:01 +0000 Received: by outflank-mailman (input) for mailman id 403000; Thu, 08 Sep 2022 09:22:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkR-0007am-8V for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:22:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDkM-0003VG-Rf; Thu, 08 Sep 2022 09:22:54 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWDkM-0007SO-Ky; Thu, 08 Sep 2022 09:22:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DkZM9ZotacWR4WekOPMrFlZGSL+Yo1bxNgSekD9OXBw=; b=OFEymdo0DAa5PuCxMMjrDI7ekS cabB4g25PTDshTBZ7UVJbt5UWsGOI4SzgW4aM7UldJIkWH3Hk7P5hvVSpWEqeCAuoO6ZaWSi4AQWl 0l33TZfGwVGL5ciU3OxIJRxDLlYKqa7E+xxBHluI+fnGuJTEB3QrD158ogCjOPJomdIs=; Message-ID: Date: Thu, 8 Sep 2022 10:22:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible Content-Language: en-US To: Olaf Hering , Jan Beulich Cc: Andrei Semenov , Wei Liu , Anthony PERARD , Juergen Gross , "xen-devel@lists.xenproject.org" References: <657d6dad39f4ab87569470c94afb4cc6d005e829.1662457291.git.andrei.semenov@vates.fr> <20220907094517.218e8709.olaf@aepfle.de> From: Julien Grall In-Reply-To: <20220907094517.218e8709.olaf@aepfle.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Olaf, On 07/09/2022 08:45, Olaf Hering wrote: > Wed, 7 Sep 2022 09:40:41 +0200 Jan Beulich : > >> Olaf - I recall you've done some similar work before. Do you have any >> thoughts here, perhaps going as far as merging your and Andrei's work? > > > My variant is in the archives, for reference. You are referring to [1], is that correct? > I have no hope that any such work will be merged. Is this because it was lack of review or are there any technical difficulties/disagreements? If the former, this is not unsolvable. Depending on which approach we go, one of you could review the series of the other. With my AWS hat on, I would also be interested with the optimization in the LM code. So I would be willing to help reviewing it. That said, I can't promise any in-depth review before 4.17 is out. Cheers, [1] https://lore.kernel.org/xen-devel/20210713180605.12096-1-olaf@aepfle.de -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:31:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:31:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403034.644995 (Exim 4.92) (envelope-from ) id 1oWDss-0001e4-V3; Thu, 08 Sep 2022 09:31:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403034.644995; Thu, 08 Sep 2022 09:31:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDss-0001dx-S7; Thu, 08 Sep 2022 09:31:42 +0000 Received: by outflank-mailman (input) for mailman id 403034; Thu, 08 Sep 2022 09:31:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWDsq-0001dr-OC for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 09:31:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 0a1f2033-2f59-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 11:31:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CEB514BF; Thu, 8 Sep 2022 02:31:44 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 32B2A3F73D; Thu, 8 Sep 2022 02:31:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a1f2033-2f59-11ed-a31c-8f8a9ae3403f From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Date: Thu, 8 Sep 2022 09:31:29 +0000 Message-Id: <20220908093129.30124-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In order to keep consistency in the device tree binding, there is no need for static memory allocation feature to define a specific set of address and size cells for "xen,static-mem" property. Therefore, this commit reuses the regular #{address,size}-cells for parsing the device tree "xen,static-mem" property. Update the documentation accordingly. Signed-off-by: Henry Wang --- docs/misc/arm/device-tree/booting.txt | 13 ++++++------- docs/misc/arm/passthrough-noiommu.txt | 7 +++---- xen/arch/arm/bootfdt.c | 5 ----- xen/arch/arm/domain_build.c | 16 ++-------------- 4 files changed, 11 insertions(+), 30 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..12d77e3b26 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -339,15 +339,15 @@ kernel will be able to discover the device. Static Allocation -============= +================= Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Memory can be statically allocated to a domain using the property "xen,static- mem" defined in the domain configuration. The number of cells for the address -and the size must be defined using respectively the properties -"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". +and the size must be defined respectively by the parent node properties +"#address-cells" and "#size-cells". The property 'memory' is still needed and should match the amount of memory given to the guest. Currently, it either comes from static memory or lets Xen @@ -362,14 +362,13 @@ device-tree: / { chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + ... domU1 { compatible = "xen,domain"; - #address-cells = <0x2>; - #size-cells = <0x2>; cpus = <2>; memory = <0x0 0x80000>; - #xen,static-mem-address-cells = <0x1>; - #xen,static-mem-size-cells = <0x1>; xen,static-mem = <0x30000000 0x20000000>; ... }; diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt index 3e2ef21ad7..69b8de1975 100644 --- a/docs/misc/arm/passthrough-noiommu.txt +++ b/docs/misc/arm/passthrough-noiommu.txt @@ -33,14 +33,13 @@ on static allocation in the device-tree: / { chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + ... domU1 { compatible = "xen,domain"; - #address-cells = <0x2>; - #size-cells = <0x2>; cpus = <2>; memory = <0x0 0x80000>; - #xen,static-mem-address-cells = <0x1>; - #xen,static-mem-size-cells = <0x1>; xen,static-mem = <0x30000000 0x20000000>; direct-map; ... diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..cd264793d5 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -352,11 +352,6 @@ static int __init process_domain_node(const void *fdt, int node, /* No "xen,static-mem" present. */ return 0; - address_cells = device_tree_get_u32(fdt, node, - "#xen,static-mem-address-cells", 0); - size_cells = device_tree_get_u32(fdt, node, - "#xen,static-mem-size-cells", 0); - return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, size_cells, &bootinfo.reserved_mem, true); } diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..258d74699d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -563,21 +563,9 @@ static int __init parse_static_mem_prop(const struct dt_device_node *node, const struct dt_property *prop; prop = dt_find_property(node, "xen,static-mem", NULL); - if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", - addr_cells) ) - { - printk(XENLOG_ERR - "failed to read \"#xen,static-mem-address-cells\".\n"); - return -EINVAL; - } - if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", - size_cells) ) - { - printk(XENLOG_ERR - "failed to read \"#xen,static-mem-size-cells\".\n"); - return -EINVAL; - } + *addr_cells = dt_n_addr_cells(node); + *size_cells = dt_n_size_cells(node); *cell = (const __be32 *)prop->value; *length = prop->length; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 09:39:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 09:39:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403042.645006 (Exim 4.92) (envelope-from ) id 1oWE0b-0002V7-OG; Thu, 08 Sep 2022 09:39:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403042.645006; Thu, 08 Sep 2022 09:39:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWE0b-0002V0-KX; Thu, 08 Sep 2022 09:39:41 +0000 Received: by outflank-mailman (input) for mailman id 403042; Thu, 08 Sep 2022 09:39:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWE0a-0002Uq-Kh; Thu, 08 Sep 2022 09:39:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWE0a-0003ot-DG; Thu, 08 Sep 2022 09:39:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWE0Z-0007KA-Vt; Thu, 08 Sep 2022 09:39:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWE0Z-0006cK-VD; Thu, 08 Sep 2022 09:39:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z3aUwJlgOctjMAyh6lKzUKvQIkTTDqPr4/6vhhY59YE=; b=AO+lefZ1z4W1cKo+KA9AaHjXhQ bYnHoZyBLIVGpUz1I45o+DuQQ+JFFNV5scADCKAv4jOava16qqB3lA5UjwFku8hxgbNTPd3gFabWo vE3uqKoYxTtaGtdpeY549cn/tvjT6nJ+7+L4aKI+MTMxBER3jQTI1ecOUwiiUNqJU8Is=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173054: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=172015009a6acc20357a2698800e13058ba1d3db X-Osstest-Versions-That: xen=172015009a6acc20357a2698800e13058ba1d3db From: osstest service owner Date: Thu, 08 Sep 2022 09:39:39 +0000 flight 173054 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173054/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 173044 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173044 build-i386-libvirt 6 libvirt-build fail like 173044 build-arm64-libvirt 6 libvirt-build fail like 173044 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173044 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173044 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173044 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173044 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173044 build-armhf-libvirt 6 libvirt-build fail like 173044 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173044 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173044 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173044 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173044 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 172015009a6acc20357a2698800e13058ba1d3db baseline version: xen 172015009a6acc20357a2698800e13058ba1d3db Last test of basis 173054 2022-09-08 01:53:16 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403055.645016 (Exim 4.92) (envelope-from ) id 1oWEWD-0007Cv-D8; Thu, 08 Sep 2022 10:12:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403055.645016; Thu, 08 Sep 2022 10:12:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEWD-0007Co-AY; Thu, 08 Sep 2022 10:12:21 +0000 Received: by outflank-mailman (input) for mailman id 403055; Thu, 08 Sep 2022 10:12:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEWC-0007CS-Lw for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:12:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEWC-0004T7-7u; Thu, 08 Sep 2022 10:12:20 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWEWC-0001Qj-12; Thu, 08 Sep 2022 10:12:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jfY3c+BScsYCDnTHX+QvmSNT2wm5sthPxky+CvivK1A=; b=oVXrll4dEpkOWWZIz2sWdptxVn p5TyHzPyQv56fqcK/hyuESuuxlbAgu/qGtOQEZ4bu1B2M/iySpHhNxuzYg3UZ7CN5C/vAQ1yH9VAC CKz8MBd6lk8lyq7IrgJkSG/v5TcDRoacihhUuHLfrl7/sBfZsKYaznQs7f2RekKnB/tE=; Message-ID: <168bd423-aa3a-ead6-4a00-0f540ae3c15f@xen.org> Date: Thu, 8 Sep 2022 11:12:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5] tools/xenstore: add migration stream extensions for new features Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220908081552.19889-1-jgross@suse.com> From: Julien Grall In-Reply-To: <20220908081552.19889-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 08/09/2022 09:15, Juergen Gross wrote: > Extend the definition of the Xenstore migration stream to cover new > features: > > - per domain features > - extended watches (watch depth) > - per domain quota > > Some of those additions (per domain features and extended watches) > require bumping the migration stream version to "2", as usage of those > features will require to transport mandatory new information in the > migration stream. > > One note regarding the GLOBAL_QUOTA_DATA record: the split of quota > between global and per-domain ones is meant to support the possibility > to pass on unknown quota settings for newly created domains to other > Xenstore instances: > > Imagine Xenstore A knows about global quota g and domain quota d, while > Xenstore B doesn't know both. Initially I'm running Xenstore A on a > host, then I'm live-updating to B. > > B gets the information that g is global, and d is per-domain, but has > no other idea what to do with the values of g and d. OTOH it knows that > each new domain should get d with the related value, so it can set d > for each newly created domain. > > When B is either downgraded to A again, or a domain is migrated to > another host running A, B can add the quota information of d for all > domains. > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403062.645028 (Exim 4.92) (envelope-from ) id 1oWEby-0007rr-2X; Thu, 08 Sep 2022 10:18:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403062.645028; Thu, 08 Sep 2022 10:18:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEbx-0007rk-VI; Thu, 08 Sep 2022 10:18:17 +0000 Received: by outflank-mailman (input) for mailman id 403062; Thu, 08 Sep 2022 10:18:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEbw-0007re-WE for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:18:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEbw-0004Z7-JM; Thu, 08 Sep 2022 10:18:16 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWEbw-0001ZQ-CG; Thu, 08 Sep 2022 10:18:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nH9t/iXYZt7N17b6QYfrk5GCuSi131Omz97+6UBSeSw=; b=ShNryuk+UnNr+9LI9AcLvPEqaI FpERzB04mfpLtaoaVwfrfqGqS17ksk8hraxYWQYlTPgTBqJdlBWpCd4Q0kbnt0eidoBbLbvwZ04E8 BRZQogl0KMqSThODSdFWwYUz6eZtu9MfR9FgK6spbG4MgwpZtrukRRFEZb8AMMzAL0Y0=; Message-ID: <3c34c287-62f7-1f5d-0b4f-011303fd5a5c@xen.org> Date: Thu, 8 Sep 2022 11:18:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Penny Zheng References: <20220908042538.27076-1-Henry.Wang@arm.com> <20220908042538.27076-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220908042538.27076-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 08/09/2022 05:25, Henry Wang wrote: > This commit introduces the static heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > Firstly, since a new type of memory bank is needed for marking the > memory bank solely as the heap, this commit defines `enum membank_type` > and use this enum in function device_tree_get_meminfo(). Changes of > code are done accordingly following the introduction of this enum. > > Also, this commit introduces the logic to parse the static heap > configuration in device tree. If the memory bank is reserved as heap > through `xen,static-heap` property in device tree `chosen` node, the > memory will be marked as static heap type. > > A documentation section is added, describing the definition of static > heap memory and the method of enabling the static heap memory through > device tree at boot time. > > Signed-off-by: Henry Wang > Signed-off-by: Penny Zheng With Michal's comments addressed: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:33:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:33:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403070.645042 (Exim 4.92) (envelope-from ) id 1oWEqC-00025G-CM; Thu, 08 Sep 2022 10:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403070.645042; Thu, 08 Sep 2022 10:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEqC-000259-8t; Thu, 08 Sep 2022 10:33:00 +0000 Received: by outflank-mailman (input) for mailman id 403070; Thu, 08 Sep 2022 10:32:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEqA-000253-C5 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:32:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2044.outbound.protection.outlook.com [40.107.22.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99c9c0a4-2f61-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 12:32:55 +0200 (CEST) Received: from AM6PR0502CA0059.eurprd05.prod.outlook.com (2603:10a6:20b:56::36) by PR3PR08MB5787.eurprd08.prod.outlook.com (2603:10a6:102:90::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Thu, 8 Sep 2022 10:32:54 +0000 Received: from AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:56:cafe::dc) by AM6PR0502CA0059.outlook.office365.com (2603:10a6:20b:56::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15 via Frontend Transport; Thu, 8 Sep 2022 10:32:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT014.mail.protection.outlook.com (100.127.140.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 10:32:53 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 08 Sep 2022 10:32:53 +0000 Received: from 0760df3306f7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5066997B-6B8D-434C-8894-736714CDBEDD.1; Thu, 08 Sep 2022 10:32:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0760df3306f7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 10:32:46 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DBAPR08MB5575.eurprd08.prod.outlook.com (2603:10a6:10:1a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Thu, 8 Sep 2022 10:32:43 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113%6]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 10:32:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99c9c0a4-2f61-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fx4ZgF4/Vw5mvI9/o4IsfpIYUJbzRjNtqBKS16agBH/lI/qhOz7we/Zx7TnvrNci3vRegtcQsNRFzWSMHL4VUxgFbh5Fn3ctfHvGplo+GYGJTzcF9JjvIR0Z1xEXlPJf0qEdHyRz7otQ6pwiuGYm205fGUFMpi2OoKLIrklm7Eldo0acDq9Ve1lagphYx2rJm2XiK1yL9iFzZ7tRNG3oDB6rvp3YbBV6ovbqpt52AHKW6bMesiJyW82PWBRejjmuqwQBjK2bq3aDcq1Uy0i1mWU+3jH+xau6ytWRWx7l1AcOQMsRRF3pwjqeGSnzTNg8HHhs/DX6cLkuHWxYwGjpUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=86mQ3s5PdSfQK/enWDVhI/uQV2rqmWgUz/s8WjUqcGs=; b=HPT068Q7Gk1FF45HX/Qz0FB7vuv9Eo6cAOS/It4IXQ9Pl0yVlJViw78UlWVMsxJfkIpNeQYfQXL+aowMerKtuSnB1N/cYSSmW9y+FGGmEeTBsNrO4NXVJKx4znhSB9dsCxpXuE2ONJcSDdVww/TgiQUYgvhNQVJ+d4ziquZCOF8YfavA4bkqEXby4JOARJtZ+uUmuD1TNiE5lPHk8m1pIW2AyI++fhTXw3cbyjmxaTRhvvWFr/quorlufiNrrC5K77FCpVhXeEqJBIcOvimlvDb6b9QbA1oooIkwbFAMXsrTRxWZsug70yRs9mzj/l5T3Jx4avLPE69H6YHdzlWHpg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86mQ3s5PdSfQK/enWDVhI/uQV2rqmWgUz/s8WjUqcGs=; b=BpiFDzNyXA0Z9sPdNDfu9E8zZbih6mgHk7tG50t9TEOVoUIWi0PLEu+0tefv2kA9mWIKloMHiMQYBjKKS0O71R8dqcHmSuSCaXPsz0wC0/nHx83rlV5F4eLFn6lx33wi/x03Q9zQ8Xe65Vu8iylYmDtpIWx1yfK7M/TUqalx49A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c1f1fded5b0d48c6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFUwsdOR+U+NH3omwrZM82SmNQunm5/B7t9BPGScikNHCVG3QptCRRqnm+AUAMFd0LAo5720rxKOslSpkj/rlNE6bXRtQwWapyxlQlQynN2coJ/GjmVE0z//AcpFuJGWTpHHrLrXEMS/oakgoTdM1SraJtGfeKTLs3JF4yPF80w+TPwqDjesq/FwksUMY+aeV5G6bMm26Dkc2mTtxC8djkRNSiyI+xKBd0lQjCvi/WS6oVvK85PLNF2xTMcwadLIekJKCRdKlO83riZGvrjLzOoWWHQFgLE4CkXgCBT9VDexFSDvBBe0C1kpwGryzDvvuXV0mK//AoXQBPFDKkPziw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=86mQ3s5PdSfQK/enWDVhI/uQV2rqmWgUz/s8WjUqcGs=; b=YsSUaqhU/OTi2l5HrWmAQfAy392Q6dv8cnXAi7g+xN0hgHJaGFnLHCdKOPC4HUOrnF10jaduFkbUkmzgPuhoBMFR6Dfqcf3UmSRnuigpdd6ArVVznjvEX3r332jXBaChZDIzmLcLaHTxzUOED7bwYTPKCZc9I6h/6o9CDg/MioXkDh0XYyu7bQgiO0I/DapYjUAmUTBo7ek0nwm5bFTgFQGG7XcLjFDCb2m5qJ+uqBSFf+XziznCv6KSGQGZ5ycYhnBdpw+iMOLKdJjlNa87rn/CVQwaqghjkm5ohJH5W/qRLn49LntEHfoAmGXj1D89ZtwjEEjN22qzPhJKjAK+8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86mQ3s5PdSfQK/enWDVhI/uQV2rqmWgUz/s8WjUqcGs=; b=BpiFDzNyXA0Z9sPdNDfu9E8zZbih6mgHk7tG50t9TEOVoUIWi0PLEu+0tefv2kA9mWIKloMHiMQYBjKKS0O71R8dqcHmSuSCaXPsz0wC0/nHx83rlV5F4eLFn6lx33wi/x03Q9zQ8Xe65Vu8iylYmDtpIWx1yfK7M/TUqalx49A= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Thu, 8 Sep 2022 18:32:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Jan Beulich Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-3-wei.chen@arm.com> From: Wei Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR04CA0210.apcprd04.prod.outlook.com (2603:1096:4:187::7) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|DBAPR08MB5575:EE_|AM7EUR03FT014:EE_|PR3PR08MB5787:EE_ X-MS-Office365-Filtering-Correlation-Id: 28f03fdb-0cfb-40a3-d3c1-08da91857ce3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G+GnSIDffmOHFlsPwlLE47EGKl5fuPvC8Jlc20xYVyiWW7zPQRz/mQI4GoyV+X4mDQEhgE6OeJqX4rrq/dnRd4ZgqMFu1cotkwZoL6kLYhys1zwKogcbVwnPAj5UwvibjGWB8hJkjWkDHSYiUd4Y+8govIuQ0rM99QLIcVX00q6TSEyAxNk1nzrNejZmuyBsmnrNL0O8AQ4ayqgV2j6CyXWyUoaFS5OzFomqf3WZ1OoT7zqUrYqWnvrZCJNaOJKpPe0E0tY3upJIeP84jzaA5vNKCFI9z2k18pyTi5hyrJQMOrqf2e+W1aw9g413ueXusxZb1gZHh91qdg4YYxSy+YxvAXGe/7w2xaqxaR9UUBY2Qiz/pBU4NLdx93fjAwtKxw3+IrDnTMstE+gtxGQiSNWotEtFPnN4EyJT2TfXk9+TT2EP2QK0JN3B1eRmU9D9z+RPDW3+g9Q+3F+pH+NqkVeMZwdBeioBhSsbjBXq9QinF33PxS7lCgQyDdoyV3zxZ6sGFB5Z/Cw2n7MgKBhKDZsFxAc3ala0GTwAul/l1AY8z/A42DGY9jV2EtkGopZQ/1SZms9tSa2tX0SlohGR14j7N/S2TjaYGEBBvY8cLf+FDHougamJStgRQnf2JmupF7FLT50vHGAJ8sx3x7jjXp2HKdbwjEua2QdR/QeoKCePmmhQtVHpIvFKWBUf5X4hnRFILAy5qP/zFjFYgyaQUC1Y4OIADom5p+ft/Ql9+uW28PEj/9Bn4p+mUNze74Ln1lEhBg1DUUVjIikLpwkHoJAZXKLgtqnQN04c7HQAJnU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(39860400002)(396003)(346002)(376002)(83380400001)(186003)(2616005)(41300700001)(6486002)(478600001)(6666004)(86362001)(6512007)(31696002)(26005)(53546011)(6506007)(38100700002)(54906003)(6916009)(316002)(8936002)(2906002)(4326008)(31686004)(8676002)(66556008)(66476007)(36756003)(66946007)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5575 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c6aa6c48-197f-49b1-4b32-08da918575f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X3n9tnDH5SbIHrk+4G35cNmTu41/N8xBjybG00zjNdCXFeFiRtJxuSDYu13NFUZYXR5nfH6Wee/Fko7UOfFnlhT+4B0IuFz4LkvnyDmDOGM4o4VC4qsGcRrR7FlkSts0nX5Stw9qDMRquaCTD2mZjm/+EoSw2h+1sZcl9AVWEfSFZB7YdImwiKinn3fNK43budBZ6P2q0ic6NPxxoXdZ21eOIMBcHuUUT8iAh+VS53E3zJscRPyd8driXARkl3YSdUzTJctmc5X/pfBql1lUgitukb75mk0yMNkiPhC1nt+JNdJv7X1Vtbd67s1xIH9QURAXPOfFauAWzbTURUQ2GffixE4Hi9OP4mBvsTBh1PKXMDjG5NrXGry1OjyviwCd93yKm9i+/X0tNm7dmEZm7RlXg5OK8b0dJD7SCBdf261LQj1aton8cikTgncWxpmj2vclhRnrqLZEV/We7qTXlXxaOJltbctXGetEn57yDnxt/JekKKxSE//tTkcOemSVa/ic8b4Z50Nt4pMsNBD9PrNxLkTI/f/DvUv2Xmfzmr1gbJ0t6CSomK05U+q+usnFFjaPKMOqli7RKVMKiezToTEREmaV4RpgCKxwhQpYEeEtv6ufBxjItbZLZWp63H1ds1NkJMw1zm7hguh3yz1Ue/gme3UAreZU36JWxGcyHDkuNQWJJgHxC0l6CcMdxmtwzJ8SaKEwKh3WGX8zl1rHlW6SHJJehou9vtPN+VgyALbydfv3CiJSyJPXmATvXDaGUWjKr9gzIJv1ctuMcPnJOaPutEcSFqjTghyTTQCLKpA8RBLTQ8b49sI7QBIEBJu4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(376002)(396003)(46966006)(36840700001)(40470700004)(316002)(2616005)(54906003)(82310400005)(31696002)(186003)(86362001)(356005)(81166007)(47076005)(336012)(6506007)(41300700001)(478600001)(6666004)(6512007)(26005)(6486002)(6862004)(8936002)(5660300002)(40460700003)(36756003)(2906002)(31686004)(40480700001)(36860700001)(53546011)(70586007)(70206006)(83380400001)(8676002)(82740400003)(4326008)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 10:32:53.7548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28f03fdb-0cfb-40a3-d3c1-08da91857ce3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5787 Hi Jan, On 2022/9/8 17:09, Jan Beulich wrote: > On 02.09.2022 05:31, Wei Chen wrote: >> --- /dev/null >> +++ b/xen/common/numa.c >> @@ -0,0 +1,442 @@ >> +/* >> + * Generic VM initialization for NUMA setups. >> + * Copyright 2002,2003 Andi Kleen, SuSE Labs. >> + * Adapted for Xen: Ryan Harper >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct node_data __ro_after_init node_data[MAX_NUMNODES]; >> + >> +/* Mapping from pdx to node id */ >> +unsigned int __ro_after_init memnode_shift; >> +unsigned long __ro_after_init memnodemapsize; >> +uint8_t *__ro_after_init memnodemap; >> +static uint8_t __ro_after_init _memnodemap[64]; > > These last two want to use nodeid_t instead of uint8_t. Originally > the latter used typeof(*memnodemap) for (I think - iirc it was me who > made it that way) this reason: That way correcting memnodemap's type > would have propagated without the need for further adjustments. > Thanks for this info, should I need to restore it to use "typeof(*memnodemap)" in next version ? >> +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { >> + [0 ... NR_CPUS-1] = NUMA_NO_NODE >> +}; >> + >> +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; >> + >> +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; >> + >> +bool __read_mostly numa_off; > > The v3 review discussing this possibly becoming __ro_after_init didn't > really finish (you didn't reply to my latest request there), but you > also didn't change the attribute. Please clarify. > I think I had answered your question by: >> I think yes, it will be used in numa_disabled and numa_disabled will >> be called in cpu_add." And you replied me with: > In the original code I cannot spot such a path - can you please point > out how exactly you see numa_disabled() reachable from cpu_add()? I'm > clearly overlooking something ..." But there is a time difference here, your reply was sent after I sent v3, maybe you didn't notice it About the new question: cpu_add will call srat_disabled, srat_disabled will access numa_off. srat_disabled is a function without __init. >> +static int __init populate_memnodemap(const struct node *nodes, >> + unsigned int numnodes, unsigned int shift, >> + nodeid_t *nodeids) > > Can't this be pointer-to-const, and then also in the caller? > Yes, it's possible, I will fix it. >> +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, >> + nodeid_t numnodes) >> +{ >> + unsigned int i; >> + nodeid_t nodes_used = 0; > > This once again is a variable which doesn't really hold a node ID (but > instead is a counter), and hence would better be unsigned int (see > ./CODING_STYLE). > Ok. >> + unsigned long spdx, epdx; >> + unsigned long bitfield = 0, memtop = 0; >> + >> + for ( i = 0; i < numnodes; i++ ) >> + { >> + spdx = paddr_to_pdx(nodes[i].start); >> + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; >> + if ( spdx >= epdx ) >> + continue; >> + bitfield |= spdx; >> + nodes_used++; >> + if ( epdx > memtop ) >> + memtop = epdx; >> + } >> + if ( nodes_used <= 1 ) >> + i = BITS_PER_LONG - 1; >> + else >> + i = find_first_bit(&bitfield, sizeof(unsigned long)*8); > > Please add the missing blanks around * . > Ok. >> + memnodemapsize = (memtop >> i) + 1; >> + return i; > > Please add the missing blank line before the (main) return statement > of the function. > I'll fix him and other places, if there are any. >> +int __init compute_hash_shift(const struct node *nodes, >> + nodeid_t numnodes, nodeid_t *nodeids) > > While I agree that nodeid_t can hold all necessary values, I still > don't think a cound should be expressed by nodeid_t. As above - see > ./CODING_STYLE. > Ok. >> +{ >> + unsigned int shift; >> + >> + shift = extract_lsb_from_nodes(nodes, numnodes); >> + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) >> + memnodemap = _memnodemap; >> + else if ( allocate_cachealigned_memnodemap() ) >> + return -1; >> + printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); > > This wants to be %u now. I'd also like to ask to drop the full stop > at this occasion. Ok, that makes sense. > >> + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) >> + { >> + printk(KERN_INFO "Your memory is not aligned you need to " >> + "rebuild your hypervisor with a bigger NODEMAPSIZE " >> + "shift=%d\n", shift); > > Again %u please. > Ack. >> +/* initialize NODE_DATA given nodeid and start/end */ >> +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) > > Please capitalize the first letter of the comment (see ./CODING_STYLE). > Ok. >> +void __init numa_init_array(void) >> +{ >> + unsigned int i; >> + nodeid_t rr; >> + >> + /* >> + * There are unfortunately some poorly designed mainboards around >> + * that only connect memory to a single CPU. This breaks the 1:1 cpu->node >> + * mapping. To avoid this fill in the mapping for all possible >> + * CPUs, as the number of CPUs is not known yet. >> + * We round robin the existing nodes. >> + */ > > Along with the style correction re-flowing of the text would have been > nice, such the lines aren't wrapped seemingly randomly without utilizing > permitted line length. > I will adjust it. >> +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) >> +{ >> + unsigned int i; >> + paddr_t start = pfn_to_paddr(start_pfn); >> + paddr_t end = pfn_to_paddr(end_pfn); >> + >> +#ifdef CONFIG_NUMA_EMU >> + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) >> + return; >> +#endif >> + >> +#ifdef CONFIG_NUMA >> + if ( !numa_off && !numa_scan_nodes(start, end) ) >> + return; >> +#endif >> + >> + printk(KERN_INFO "%s\n", >> + numa_off ? "NUMA turned off" : "No NUMA configuration found"); >> + >> + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", >> + start, end); >> + /* setup dummy node covering all memory */ > > Please again capitalize the first character of the comment. > Ok. >> +static void cf_check dump_numa(unsigned char key) >> +{ >> + s_time_t now = NOW(); >> + unsigned int i, j, n; >> + struct domain *d; >> + struct page_info *page; > > Along with the various other style corrections perhaps add const here? > I will add it. >> + unsigned int page_num_node[MAX_NUMNODES]; >> + const struct vnuma_info *vnuma; >> + >> + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, >> + now); >> + >> + for_each_online_node ( i ) >> + { >> + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); >> + >> + printk("NODE%u start->%lu size->%lu free->%lu\n", >> + i, node_start_pfn(i), node_spanned_pages(i), >> + avail_node_heap_pages(i)); >> + /* sanity check phys_to_nid() */ > > First char of comment again. > Ok. Thanks. Wei Chen > Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:37:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:37:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403077.645053 (Exim 4.92) (envelope-from ) id 1oWEuE-0002iF-UI; Thu, 08 Sep 2022 10:37:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403077.645053; Thu, 08 Sep 2022 10:37:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEuE-0002i8-Qq; Thu, 08 Sep 2022 10:37:10 +0000 Received: by outflank-mailman (input) for mailman id 403077; Thu, 08 Sep 2022 10:37:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEuD-0002i2-Hm for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:37:09 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f45f08c-2f62-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 12:37:08 +0200 (CEST) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Sep 2022 06:37:05 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5333.namprd03.prod.outlook.com (2603:10b6:610:a2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Thu, 8 Sep 2022 10:37:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Thu, 8 Sep 2022 10:37:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f45f08c-2f62-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662633428; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Z2Hfaqj4lRLqkKucv15USXRiZN+PUMQ48swob/UWc3Y=; b=VqMMJ0ZGXFB1NLQTEdWaplxaUqIgZvZ9c5ra/o+BGiljnwOZfRX7IKSV 7TEIQ58tZFguwtVVaDpMhun91r8bSFdClSsItcNTk+phmwfwfMU1tU1mC Sh5cbADR9KHdNITf29HHbZAucVP9B0nRXoMlkMbSuxcgmgQs07DBAxisr U=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 80048305 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3ATNjO6K2i6xokmx1WUPbDix16xa8BPHBdZdB5h?= =?us-ascii?q?dg8DyJ0ofsy17SWlPg9Dm+OpEbNEGCloGxUELxf12oI5UW6QaFr5uuB5u7b/?= =?us-ascii?q?R11eHcAu1UiAY0htHyPgKxaff2+K33U7uuNKlXwDMjRABC4dKNYs8K9gqpuH?= =?us-ascii?q?WUJGWxhvuGCSAPKRqGFqql8ZfQfDDiUskzsGe8CdQ15AD8CWdTKagDRyr5lq?= =?us-ascii?q?Fm9Xv4jAuh0HjX1mxp3lwUx+e0gGvNvBKGpwXFvN5v/Vl5NU/tx9Sq9aeyPT?= =?us-ascii?q?KUBSk5vz0M9veEiNqSwXhgo1gi8u4eJDVmEBvnPN/4NJ/rjePDSf/JrX5JbE?= =?us-ascii?q?yVwCTu88q6usuZX7Z561C4RkmNsaUqt+C+M+mY5gkKLyuuG0MeX367+vva9I?= =?us-ascii?q?FsN22j6PjdabbjaK/JKiVL0693IZ/lvQ3BGv70MB63BOfjor11hi37I3CdqM?= =?us-ascii?q?MfPrcrgcWvJqMaEkWPn7Qb0af1Pa0zS/RZS0cIHmDtNA8riRFT/K7favzabD?= =?us-ascii?q?lb1HAWpIqpSxDiz9GiotQL4dkXgl5SNGYN9f883Vug6PtKFsVO1Y3+tbZQIJ?= =?us-ascii?q?knsKDHhFjQlw9n90m2sgaj1eP5l6FiAgAmkFZ8Q8OOv2RP7j0drfRLOgSHdI?= =?us-ascii?q?G+PMkzHzY80bSLIV71T5efd+obP9OxR2b834+3kZhEInKW/08ECQy3cVDjqe?= =?us-ascii?q?OIFlbjD6uz+GosnHhjVbH1fDPwacs4+7KSLkViZI6NTxoUYnl1FPUSF+sFiZ?= =?us-ascii?q?UD+U746dJIvvXMVrXpRpkNGoCA5TcyJRSYo8lpy150yg2UrL7zK2BB2EVqr8?= =?us-ascii?q?VLQoH/LQHQBR92y2CZl1wedxIv6KFPHljuqswY7sbVPGPmklGa648XVwYBHU?= =?us-ascii?q?iJwUP1joDnaVrk9yWTyopgLlZITBZXM9XtQfsib+dajbgECcA7G7aSsetmh1?= =?us-ascii?q?JUkGUcV6M5ttCc8i+2XfOz7HnJowGDq8NKdWs4AkfR0iDPBHT8hv7gJaOGbc?= =?us-ascii?q?rEGcsLm1C2iURIvdgi1U7vhVveeV5bNBVGxTis56fy9lLWEA6ZZXmK8QVFbW?= =?us-ascii?q?Tf48gcRhNFfaMmlzChbVbXcBOBlpOfIuekvEgR5c4yW04H1ufCZoYffwtpUa?= =?us-ascii?q?xE9QkEDG6l1lp+uQpcjDh8ZGm7OXTix7ni9RIINnp42AktUHTHuIObFv1yIX?= =?us-ascii?q?rJJl2TCoyv8pcIBYkvZDclo31yelzUjuwSlEYozRUK49rrZLl2YdA/GGmIux?= =?us-ascii?q?47Fn319EChVuJTD5wZgt6g8+OIoO7D8AjRrPoak8gHKQFG4o3gGR6UIsxRaX?= =?us-ascii?q?3UUgoMdq5NKfcmPrVnVB6EEdGwgQXIYP8w+fE5Ls8IUIo/6bcI4I34Gv3z9n?= =?us-ascii?q?P614R9IFewTqCQkUKLrwdqW+YA16FTlZyJGn15rEI0f8IcXffOLh4Ik3oqXq?= =?us-ascii?q?08HYP2I4CX22eJvKh31A0292UX2/cURsipm3IviJjdvytBA8kC+04ygHZAhX?= =?us-ascii?q?WnL3Dh5L6jmJdATRqIUH3x175GcidksVko9aZ7H3DkC0tyf+jY//iJc9xytX?= =?us-ascii?q?ufPVHF3WkHoNpx4goudw0sdBz/9kd1l9hZFa0EtAnMVMxI6TlenDFhHeY99w?= =?us-ascii?q?X59K/cbNE+vwqKgu4Yn91+4nvb78L0aBFWFuOqHVKi7EGrl7nPyk6JkWBCli?= =?us-ascii?q?klJ9L3F6h1vrpAl2fVXjyIZk2kOsFdYk9PH9TW10UD+kY16h7rhpuAMGJi/E?= =?us-ascii?q?26xJKAAEnCkJ3S+bpXuPQpXDeQeXaDQA8t719LBJTEEuuA/rgUqtJSHOE8K6?= =?us-ascii?q?0fJ1OYP+xEcv8BJBXZrxFzynNgOzGYexXPhE9uldpeZ2d1KX3CPCz3k3sQ7k?= =?us-ascii?q?Q9/GjaAEnd2v3o4yCpoWDlEmThFlSko0HtfvTsasrN/WrLhs/mVwH6xUTZXi?= =?us-ascii?q?Wx/wMWlgSqlvcKrLf1CnFuWqdAFk0/QvjXYffOpJoFa27GBkv/7FCWTiNceC?= =?us-ascii?q?i2nGCGijn7RVk2VBbX7tCQrL18NU+TA/F3VEU0hO/QQ9hWBkE0/GnZRPTwWN?= =?us-ascii?q?dx4tL9StKkq8f1nc/QtAXOBQ4AFK6GcYoagC6wmEFcMoDdgekYDxb85YQfFG?= =?us-ascii?q?ypUNwopDDrrF2LQTuIlKtJNH0gT+XNEARtJorQUVlhYgW8sPWz0VFFxMrLAC?= =?us-ascii?q?RhwmU2PRAFWRjx250RGK3fsGF6CsBdDSl3nVRnDKGQx2SwPW+4HFvO7VZ2mb?= =?us-ascii?q?BVoF8t/VaiLvf6i9KRUUzt5PdWbqMW2TRauYwvG1t00NC9/OHrVOL+Fs9qUu?= =?us-ascii?q?ejeHqSStDwKhBpFhvphYTzJIeXBIotfpGMkK2LbLbeTI5SrDuLwt+gsphdxc?= =?us-ascii?q?nn1xTBDP/A+worL7psbaBXNW2RHb3cWz4ichYg5uIE+t8/dWdO+hhXBrK3X2?= =?us-ascii?q?GkVOttIx9fIoOFSfljhQgADqN0QSC6Bsy5c3M9grt57D2/wVl4y5UMjLUH5h?= =?us-ascii?q?+4C2EFH7YVdP8CP6x+Gfm4omwn6aeRw/cfMaddjj1vCIq/EDfVj1y1QAGRxz?= =?us-ascii?q?B6DUvKjJIykqBafmzoySwA/WPJfC03DDOed22iBzUltStipnx+oAex6mQu0n?= =?us-ascii?q?FMUp8VtN3R9KFrA2ixC/qFEkOVpN19dxq6m7hLgx3Vx1A=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,299,1654574400"; d="scan'208";a="80048305" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hEjABSNWzksLrP4szpDJzagfanM5LF2u3uXZo35murC4rc/PHeFs6nMQagUrxOb/HmqrzmI6aQ4n52sg9EGJHeXE7vgz3SuQSadBTxDsQs5mRHT6JQatsK+Y7MtEY+zTgM26DB/MPl7IJfrP0uRxxGqd3M/w3YOO42KHJeYHXBroukQZPuOnihROIjBt/Q+aXZdg51ET5LHv4cIXJWwUVtkQT2KjPsqSaZqMs0e5K8s60ZqDbWVbrzKpigU1SlgEZDLSaQM0/1l4DdvevGoLcan6l4FvbB13gU5UFU0L8doiGP96g7ytMA+OQcw4sRlEtj0ZrwdubXrrR/URGptKQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2Hfaqj4lRLqkKucv15USXRiZN+PUMQ48swob/UWc3Y=; b=Bab21K304+6mBGBgwj1M4tjSjoJmzfTdaZu0JDhog93M1rYrfanhNS3aaNs44qSmN7DuPPcDjzF7V4wcyN6a+4o1MnK8PLfDq0Tj0OIZ/N1DHe6UJM5S3ENdmJfYqlNdngc84f05RFZ08waf9xU+V/SmQvNEvi0OIwruTqC2j3nDB1bsKqRwvuawDWMXh8FhTMPq6g+DUFi1inq9gMqpOi6AgW2kN72i2rNzlFJfdDxCr7Wi5GaaXfL0Lqtvpu44fwDuT21VwGejiQgy7iG2EbZ90oIxxCFqfM0VPYPOWk/vlPDob3XNwnOIWyJpxgwisvAHJ2OlQgM0f6mBxocbCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z2Hfaqj4lRLqkKucv15USXRiZN+PUMQ48swob/UWc3Y=; b=sbgn6QgWeBLOJfHU8LYfQ6jPdA+jUq4o48DCucEM5cgsAtTMAPAMpVEwIQa3qcYEg9C5rWiQXh4SNmFaLQ287z7OLAj+bLHDDTkahTseqQviRoBDGQ8XuOKC/fU31N4dpsmxOvPMIXL/tzcCicgYKIiU5pgTOPkFVcLLjnvTbkA= From: Andrew Cooper To: Jan Beulich , Julien Grall CC: George Dunlap , Stefano Stabellini , Wei Liu , Roger Pau Monne , Anthony Perard , Bertrand Marquis , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS Thread-Topic: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS Thread-Index: AQHYuFK+wB8KiYBTukKYWomgtSrgPa3UHOaAgAEF3ICAAEp1AA== Date: Thu, 8 Sep 2022 10:37:03 +0000 Message-ID: References: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> <08f233cb-0586-1845-fd67-030eb8c4373e@suse.com> In-Reply-To: <08f233cb-0586-1845-fd67-030eb8c4373e@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c31245d1-f8f8-45d5-bf4d-08da91861190 x-ms-traffictypediagnostic: CH2PR03MB5333:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dgOh2oYzGLS7BoXHCegnSQ0l6gJoNHYj0Bna0iutQ6Z5CVrCZIAQEzGoiPuvRwkA3Wk5CL7zC7IWmlAaL8JMsdHXyG7i2ObRSS3CqElFMZqXfS/OK4o2nNqAE1bbUMJaHtr7zvxrQDtjCdYDYz2DxGesKctsr70cMXjfw4TiRZp4xMJnxrnd1g583nDpwBJJ+V+ZN0rCgrtXbSKuMi41zfGL0iZwnSjM0AK5TgLbrwwTNOmxUcpqc/8R6/0sYJ5UtGb8yBvSUT0CCztKju969dwoi4qwE3mjWUyMSNCAjHtlGnV5fU+mBXFkyoDXtfPtmhihlJJavvPo3/6f6NoTWP+phA4gtD7Dy4I8gmZTnjR9Ujt+9ONA4Y+bUNGpBiYcTzOO3q6nTZrssSZO51OZD4qTVcGtPWrh+xwpxvB9E9MIPBBET7dNMONmHZk8//wQaU7spAfkdhlHO0Cs7i1kwNNrRZ6JEABScjBbeeM+mCCvrOMa4RrTdVOKu8bbInC2DDxgihmWAtJXGPlilng1+g4V6Bmu48UcBtHazLxVaFlK4Rs4mmvApjZntEaS5a/VT6OnnTca72U5GNNd2sVVsF04BayS932Qi5pcpxr7jWcaF6stUu/8gD58bvl8DnhEJtDGhCgRhUr3qxHpY1Jm8nQKUx28f7BV/u38XdF4N6wrkIhzaRfPW8Trs4AQdMsuaZGmU2RmUj51suwn7la5OjuaUiCboybqXe9AKt5fgavA1H5RnyzAuR+xM4f850wDGeMq1nAni/sQuZIRQub5g6Zjkt1C5oyTQ3euPhtUBWyWo9F0IBvoso5y7RMDQetpRX2yeL7nisFHCXGNxwl5BL42wYDD2xBfxNMvNtlQsfw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(54906003)(316002)(110136005)(31696002)(2906002)(86362001)(66476007)(66556008)(64756008)(66446008)(8936002)(82960400001)(38070700005)(5660300002)(66946007)(38100700002)(8676002)(122000001)(4326008)(91956017)(76116006)(36756003)(2616005)(71200400001)(478600001)(6486002)(83380400001)(966005)(186003)(41300700001)(6512007)(26005)(6506007)(31686004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NHgwTUpOdStyNU5taEVPenB3SWpCOGNXTjlLNzc5dzlySGQxM1RtcklnZ0g1?= =?utf-8?B?SkNyaGpEdkZCTjVtSWpweXFjVHhwSkMzeTJMamlNU1N0L2E4NDJIR1FOblZo?= =?utf-8?B?Z21JcjUvWGZhTUtmSlhnaEEvVXZkemQ4Q1kzYklIcy9Va0VBL1Frcmg1WlpG?= =?utf-8?B?cmxuWFVqOTQ5T1JtdnZ4S3BOYVlmNHdGNjdJZ01lRktMSGN3QmVDZjNHdTdz?= =?utf-8?B?OVZubXZJak1BVmsyY2lLMGlzVVA5S1NCT1ppYnoxS3hNaUxhV3J0cS95UDhK?= =?utf-8?B?NXQyVU54bTBUOGxOZWowdkZkdHpJZHpZOUxYUU5TdTQ3NmlSRFNURlo2dTB4?= =?utf-8?B?MisyTVlvM3lGai9KemN1UUhxUGFZelpZNUh2QUNPL045RThrV3VzRWtZVklu?= =?utf-8?B?aUgrOXN3Vk5rVzZNcVJrTGFleGZFa0VOdzdxeGtYdE9tREovY3RWbGE5Skha?= =?utf-8?B?ZGJZOEhUMDR2eHNkVUs0cnUxZ1RIbHpka0RwZFlQZjVrOXJMMGNHb3pTNzk5?= =?utf-8?B?UnQ4MmVleml0OEF4RGNwd3E3VlVYMlFJN3I1MFNnM2gza1dWd0tmL2dKcHVJ?= =?utf-8?B?a0RSM0o1L05VVjNHRUhGdUlWR2hSZ2dEWDZ6WmZWRVNubkxWZkRsNHM5OEZC?= =?utf-8?B?RVhNbUZ6ZU96N1V0cEF0dGtFWk5QQ3lNazdhUXB0OXlUT1BTSjNZN1NOeFNG?= =?utf-8?B?RVVTL2pOZ2w5RVBDVHZXNkgrbVE2TUhqdEdRb0FmWVoyWU94bFVFVVhTKzNu?= =?utf-8?B?NnVVNllSOEI1dWVMTCtMalZWa25sSUZxenZFVlFlY3dxZnE0czV6NUo0MmZG?= =?utf-8?B?bWdUVnFTaE9mZ29LSTM4T0NNalc1aCtTR0U4cEJUNlNTQnZvY1k1d1d3YjZD?= =?utf-8?B?NlFicmpHYVBHR29wSHB0SmEzK25nV1BOY1IrUE1qWnhncjhuSUxTQWZnQWF6?= =?utf-8?B?VXpXelBQbi9OSjJvbFJqUTM2a1hrT0oycGFrNTh5VlVYaUdLZHhIT3hyTlZS?= =?utf-8?B?YTBIa3FURmg5U2xoOGtPNnRlTnZhUllPL3BuS2hMTktJUnNXb3JIaVdyRndT?= =?utf-8?B?RjI4bUlnTDdFV1hWNENMek9pelVPR1ZlUDZiVk5mUkt3akNMVVlLZTBDejZ1?= =?utf-8?B?S3ovODUweTdFTExtM2NOWFpJS3drYlhSemZ5YVVtRmkzdW5QS2liQ3hVUGNV?= =?utf-8?B?NGVzczFGYnNnK0J0N2E2UWsyZzd5NlRMdC9qanFBUjdNY0d2MDJZdEtyMkR5?= =?utf-8?B?bEZqMWJub2Z2Y0pmbDJHRTNKai9oWkVvdmRlQmUwZGFteUIrS3UxNVpYSEU2?= =?utf-8?B?VjR2M0lXYTZNbDlWOVV5RGU5TjNkRmtPT3VBN1Q2YWFyVWZPL3pSNTI1UGRs?= =?utf-8?B?a0NqVnkyUHRMaGEzcFBrRnJXTzFHejIyWkdLcFhtRHFUdXNobDNhU0d6cWcv?= =?utf-8?B?dy9tM0F5Z1dqbWp1S3Y5WDJpVW9LTDRNaXdSRk9RRk93a210WUNRNUxqRGtB?= =?utf-8?B?d3VlMyt0NC9LKzFqQVlnL24rTVIwRnJyOXZTc0NUWHgxa1BkWldhSzZKcTRN?= =?utf-8?B?a3BXdlQ0TE1mUVhFWiswb1hoTXhETGtUY0Yxb3Vad21CY0RMS2xacHZmNGt1?= =?utf-8?B?QjJHTW11K2JIQmZmalE4REpNdmduOHJlQTZMa3FUcDlqVEF5Rzc2eW0yaDFD?= =?utf-8?B?S2huU3hxT0dQdkR6N09PRC9YYzMxRWl3Q2VydFpXQkw3bUFVNzlqK1drZ3lv?= =?utf-8?B?QkpHeGE0dnRwOU5SVVVjQ3ArTlN6M05lTEk5cmxuVmIzNGNBek5JUysxUFcv?= =?utf-8?B?Q1NIMGlzd2x4NVgvQU9rby9GdmdGTTFqWEhhekJjR0haWm1VSUM4TlI2Q1hP?= =?utf-8?B?WjlTanRNa2hFQnlFV0p0THF3dlRIUldmNk9rQnRDVWZqSHpKUzBMYkF3K0Q2?= =?utf-8?B?cXFXTGNVUThYS0JacGg0ODVJZDJpZzg3YVRlRVRscktqeXN4Y2liZk9kaDNE?= =?utf-8?B?cS9TczZta0s2TEtkMnRSaVZqa245SW5LNi9TWWhGM3E4bjhkWFdMK1VYOWcv?= =?utf-8?B?VWNPM3Nwejkyc0RGdXNjUWtpb25jbjcxUWZ6V1o5QytkdjhMYWw1dGtjTWp3?= =?utf-8?Q?3r5airc4b+sk9Qwf5lDG8yXz4?= Content-Type: text/plain; charset="utf-8" Content-ID: <8A8318E7392C604EAB2D7168CCE47142@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c31245d1-f8f8-45d5-bf4d-08da91861190 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 10:37:03.2065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nIOYGWPTbaNvi/CdXLr1nTK/X+H8jHTTzQddZzYWboGJOdWgkPa/HqAXjeRgMEE4bwaKXVvYhry3vT4nQEi8h7V1xm/BzSuY0CcbL8yNcCw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5333 T24gMDgvMDkvMjAyMiAwNzoxMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjIg MTY6MzMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+IE9uIDI1LzA4LzIwMjIgMDg6MTcsIEphbiBC ZXVsaWNoIHdyb3RlOg0KPj4+IEkgaGF2ZW4ndCBiZWVuIGFibGUgdG8gZmluZCBldmlkZW5jZSBv ZiAiLW5vcGllIiBldmVyIGhhdmluZyBiZWVuIGENCj4+PiBzdXBwb3J0ZWQgY29tcGlsZXIgb3B0 aW9uLiBUaGUgY29ycmVjdCBzcGVsbGluZyBpcyAiLW5vLXBpZSIuDQo+Pj4gRnVydGhlcm1vcmUg bGlrZSAiLXBpZSIgdGhpcyBpcyBhbiBvcHRpb24gd2hpY2ggaXMgc29sZWx5IHBhc3NlZCB0byB0 aGUNCj4+PiBsaW5rZXIuIFRoZSBjb21waWxlciBvbmx5IHJlY29nbml6ZXMgIi1mcGllIiAvICIt ZlBJRSIgLyAiLWZuby1waWUiLCBhbmQNCj4+PiBpdCBkb2Vzbid0IGluZmVyIHRoZXNlIG9wdGlv bnMgZnJvbSAiLXBpZSIgLyAiLW5vLXBpZSIuDQo+PiBPT0ksIGhvdyBkaWQgeW91IGZpbmQgb3V0 IHRoaXMgaXNzdWU/DQo+IEJ5IHJldmlld2luZyBBbmRyZXcncyAieDg2L2h2bWxvYWRlcjogRG9u J3QgYnVpbGQgYXMgUElDL1BJRSIuDQoNCkl0IHdhcyBhY3R1YWxseSBmaXJzdCBkaXNjdXNzZWQg aGVyZToNCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC83YjEyOWEwMS0wN2M3LWU4 NTYtZmI1Yi0wYzdiNDRhOGRhYzVAY2l0cml4LmNvbS8NCg0KVGhlIHJlYXNvbiB3aHkgSSBoYWRu J3QgZ290IGJhY2sgYXJvdW5kIHRvIHRoaXMgcGF0Y2ggeWV0IGlzIGJlY2F1c2UgdGhlDQpjb21t aXQgbWVzc2FnZSBpcyB3cm9uZyAobm90IGhlbHBlZCB0byBzb21lIGFwcGFsbGluZyBHQ0MvQmlu dXRpbHMNCmRvY3VtZW50YXRpb24pLg0KDQpUaGUgLWYgZm9ybXMgYXJlIHRvIGRvIHdpdGggR0ND IGNvZGUgZ2VuZXJhdGlvbi7CoCBUaGVzZSBhcmUgQ0ZMQUdTLCBidXQNCnRoZXkgd2FudCB3YW50 IHNwZWNpZnlpbmcgKG9yIG5vdCkgdG9nZXRoZXIsIGFuZCBub3Qgc3BsaXQgYWNyb3NzDQpFTUJF RERFRF9FWFRSQV9DRkxBR1MgYW5kIHNvbWV0aGluZyBlbHNlIGxpa2UgdGhpcy4NCg0KVGhlIG5v bi1mIGZvcm1zIGFyZSBMREZMQUdTIGJ1dCBkbyBiZWhhdmUgYXMgZGVzY3JpYmVkLsKgIFBhc3Np bmcgLW5vLXBpZQ0KY2F1c2VzIEdDQyB0byBjYW5jZWwgcGFzc2luZyAtcGllIHRvIExEOyBpdCBk b2VzIG5vdCBwYXNzIC1uby1waWUuwqAgQnV0DQppdCBkb2VzIG90aGVyIHRoaW5ncyB0b28sIGJl Y2F1c2UgZGlmZmVyZW50IGNyMCBvYmplY3RzIGdldCBwYXNzZWQuwqANClRoaXMgbWF0dGVycyBm b3IgaG9zdGVkIGJpbmFyaWVzLCBidXQgbm90IGZvciBmcmVlc3RhbmRpbmcuDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:38:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:38:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403087.645064 (Exim 4.92) (envelope-from ) id 1oWEve-0003Mr-CT; Thu, 08 Sep 2022 10:38:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403087.645064; Thu, 08 Sep 2022 10:38:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEve-0003Mk-9I; Thu, 08 Sep 2022 10:38:38 +0000 Received: by outflank-mailman (input) for mailman id 403087; Thu, 08 Sep 2022 10:38:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWEvd-0003Me-Jj for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:38:37 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63e3b917-2f62-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 12:38:35 +0200 (CEST) Received: from MW4P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::9) by IA1PR12MB6410.namprd12.prod.outlook.com (2603:10b6:208:38a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Thu, 8 Sep 2022 10:38:30 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8b:cafe::85) by MW4P221CA0004.outlook.office365.com (2603:10b6:303:8b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 10:38:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 10:38:29 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 05:38:27 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 05:38:26 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63e3b917-2f62-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+ijwsWoAot9edRjMgiGrioy2uBzD3Yeb6DOls9CliTXLbs8Iq8WIWmqRUWIZH2UHj4DtXe0KA7OEKlbRZh62pt6SD/YUSm4zDzHTfM4CqM80bRuUtRZfbbszBcQIHWvKfwkWDD3PsimZ9rhnT5TQcWv0WLf9XCOsO8Th+T2l3tK44wjixIqE5laq1Jv9/d+5H1QgfcR+N1WCUVXZLbCSb9OOz995ZPXJ0IpJps6dP3P7q8V3P1MVih61gMKpZF30f5NmA/6HzzEyg4/ejduKJPsK5gASbHUwFbrzYxYuUW7aZeKMdooHFzjnwmEuQHO+2SmqdilHcXnqXRaz+vl5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bSPQwkZwO6weRR9TEn5yme3ZUfJgCSm+hREkI4rQk1c=; b=T/weolQFVrT4pi/TxHqksSD8fHP30tiIeHADW22IRHrzmGdJIXzrqONYFSPxkYqxRmAuEWGPhs/DCIEpihrEiGxtWVYZpr7sNSdP6eWFAs/kyT0zYwEZrTKj75qvoN4CmVZxWGTk5qyShpikTu2IRzB9lXufwYMFXZ/kCtudb9+iFO/lwZu4HZYXBTWYm3LK5/iVk4wKhh61d1CRuhB5cn8Y1ty1RYsMYu2znm0RBIzTZXVEA4+n7D9+v6JX7i2xgIqiIpSMfkLdh0tpazwmRavZ79bo1webhmjZ0FvGWM6eoCbaf92GFmBGqP/y8GbB+Ftb4AnsySSWkVLysp7j/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSPQwkZwO6weRR9TEn5yme3ZUfJgCSm+hREkI4rQk1c=; b=STcJWMsE9BraKMpl+VgREj4eu6+7IULd8K7qVj8IM2a8qR6cdJryu6W2/WXbQGM1ZhlH1RHskCYlYK4yyJuZAxI/0xg1wPIRfDP7uRa3ZOz/guq1LBUyhGk8L0NlgaEPbh9ls1gpA3HQRKu/ThJlzYPUDMPFsPaT2smkXWUJ+4s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 8 Sep 2022 12:38:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Content-Language: en-US To: Henry Wang , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20220908093129.30124-1-Henry.Wang@arm.com> From: Michal Orzel In-Reply-To: <20220908093129.30124-1-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT056:EE_|IA1PR12MB6410:EE_ X-MS-Office365-Filtering-Correlation-Id: 71d0fdf0-62d7-47d3-8b84-08da91864534 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z5t5Xw/gWMqzDfrKOtoIkcs7r6uhGo9S3Nr4J5vP+/FMtwmDvwpAaW2MQYwNir457D2mIYtQ/wjIEa2+rRsFvFWpSLyNceEKCXJUBia7MMcwhfw1Wgy9mKiqMbNnoboFjkXX5jxqj7llIXICd02P1h55v4iWuyRZ4cTHQjS4VDCaH7gtmHGoWIpLWXfuvbLMXHjpsT+LnQGh5QqLo+TT8g9bsCN7Ak3v2vofcI5jqxLOlDU0dwMSn+owZQvcdsfCdbK37Q667X/zXwDaIDE0MyLJLfnKBeCPF3r6s5n9j1SfoKLAQBeAh8g2xeenyu1+I+hf0Jf+mmCfvCoCO/pibGdniqKpcBglFZpenoBm7n7kTJseRnvI74zD3hlOxWMV0IKzNfw3pivXi0jk5wcn5gvQhO/+0CZjGrxCDiIoamhRp9jWSU48OFC8ZRdRxzJiF+/ZqvGOiPlO6+qR6FGe+te54HK5pF12u36pU8Uo0aYRLKxXPqgTWnNOdmshvO0WxeFLfE/quny//pG7wOIq+Vxj2/EU+MOxRkGfbY+4bAatH/qj2kysvzE2/lEpr8g5wIDe5wU9e3GBz2aYdmpif6yZLETTrOV29FysVlfBfyj1tRwHUXG93be4YjiPKdDtI3/kJ19dJrMwf6mSpoMsERY/1kRX1F45fofijMAneX8ZhlZePk/2yE13PjHW8Ez7z5N4veO4m6T8/UHgJmElBOm2bGOCrnbVdrKhovfWn+u/ofoxSy0JmRjPayT0gUnzWQ9eh7imFMShLJr7tqo5UgXt+qBWIlSC+W4FOv8zdNYu3556TS3MFkYac6Atui5XzzRJtUJdo+XAZjTIBYISPQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(40470700004)(36840700001)(46966006)(40460700003)(4326008)(86362001)(31696002)(2616005)(426003)(83380400001)(186003)(81166007)(47076005)(82740400003)(356005)(36860700001)(336012)(8676002)(26005)(70586007)(70206006)(2906002)(316002)(110136005)(478600001)(8936002)(5660300002)(82310400005)(40480700001)(54906003)(16576012)(44832011)(31686004)(36756003)(41300700001)(53546011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 10:38:29.7188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71d0fdf0-62d7-47d3-8b84-08da91864534 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6410 Hi Henry, On 08/09/2022 11:31, Henry Wang wrote: > > In order to keep consistency in the device tree binding, there is > no need for static memory allocation feature to define a specific > set of address and size cells for "xen,static-mem" property. > > Therefore, this commit reuses the regular #{address,size}-cells > for parsing the device tree "xen,static-mem" property. Update > the documentation accordingly. > > Signed-off-by: Henry Wang > --- > docs/misc/arm/device-tree/booting.txt | 13 ++++++------- > docs/misc/arm/passthrough-noiommu.txt | 7 +++---- > xen/arch/arm/bootfdt.c | 5 ----- > xen/arch/arm/domain_build.c | 16 ++-------------- > 4 files changed, 11 insertions(+), 30 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..12d77e3b26 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -339,15 +339,15 @@ kernel will be able to discover the device. > > > Static Allocation > -============= > +================= > > Static Allocation refers to system or sub-system(domains) for which memory > areas are pre-defined by configuration using physical address ranges. > > Memory can be statically allocated to a domain using the property "xen,static- > mem" defined in the domain configuration. The number of cells for the address > -and the size must be defined using respectively the properties > -"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". > +and the size must be defined respectively by the parent node properties > +"#address-cells" and "#size-cells". > > The property 'memory' is still needed and should match the amount of memory > given to the guest. Currently, it either comes from static memory or lets Xen > @@ -362,14 +362,13 @@ device-tree: > > / { > chosen { > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + ... > domU1 { > compatible = "xen,domain"; > - #address-cells = <0x2>; > - #size-cells = <0x2>; Why did you remove this set if it relates to the childs of domU1 (e.g. kernel, ramdisk) and not to domU1 itself? > cpus = <2>; > memory = <0x0 0x80000>; > - #xen,static-mem-address-cells = <0x1>; > - #xen,static-mem-size-cells = <0x1>; > xen,static-mem = <0x30000000 0x20000000>; > ... > }; > diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt > index 3e2ef21ad7..69b8de1975 100644 > --- a/docs/misc/arm/passthrough-noiommu.txt > +++ b/docs/misc/arm/passthrough-noiommu.txt > @@ -33,14 +33,13 @@ on static allocation in the device-tree: > > / { > chosen { > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + ... > domU1 { > compatible = "xen,domain"; > - #address-cells = <0x2>; > - #size-cells = <0x2>; The same here. > cpus = <2>; > memory = <0x0 0x80000>; > - #xen,static-mem-address-cells = <0x1>; > - #xen,static-mem-size-cells = <0x1>; > xen,static-mem = <0x30000000 0x20000000>; > direct-map; > ... > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index ec81a45de9..cd264793d5 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -352,11 +352,6 @@ static int __init process_domain_node(const void *fdt, int node, > /* No "xen,static-mem" present. */ > return 0; > > - address_cells = device_tree_get_u32(fdt, node, > - "#xen,static-mem-address-cells", 0); > - size_cells = device_tree_get_u32(fdt, node, > - "#xen,static-mem-size-cells", 0); > - > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > size_cells, &bootinfo.reserved_mem, true); > } > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index b76a84e8f5..258d74699d 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -563,21 +563,9 @@ static int __init parse_static_mem_prop(const struct dt_device_node *node, > const struct dt_property *prop; > > prop = dt_find_property(node, "xen,static-mem", NULL); > - if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", > - addr_cells) ) > - { > - printk(XENLOG_ERR > - "failed to read \"#xen,static-mem-address-cells\".\n"); > - return -EINVAL; > - } > > - if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", > - size_cells) ) > - { > - printk(XENLOG_ERR > - "failed to read \"#xen,static-mem-size-cells\".\n"); > - return -EINVAL; > - } > + *addr_cells = dt_n_addr_cells(node); > + *size_cells = dt_n_size_cells(node); There is a type mismatch here as e.g. addr_cells is u32 and dt_n_addr_cells return type is int. But I don't think this can be harmful and also it's strange for me that dt_n_addr_cells is defined to return int given that it either returns 2 or be32_to_cpup, which means it should return u32. > > *cell = (const __be32 *)prop->value; > *length = prop->length; > -- > 2.17.1 > > Apart from that: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:40:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:40:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403095.645075 (Exim 4.92) (envelope-from ) id 1oWExp-0004kX-OH; Thu, 08 Sep 2022 10:40:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403095.645075; Thu, 08 Sep 2022 10:40:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWExp-0004kQ-LV; Thu, 08 Sep 2022 10:40:53 +0000 Received: by outflank-mailman (input) for mailman id 403095; Thu, 08 Sep 2022 10:40:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWExo-0004kE-HB; Thu, 08 Sep 2022 10:40:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWExo-0004ze-Dp; Thu, 08 Sep 2022 10:40:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWExo-000398-2r; Thu, 08 Sep 2022 10:40:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWExo-0003XL-2R; Thu, 08 Sep 2022 10:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ig28QfmGDiblS17IkosKUm2241Z2Tn0HiqgjMcnTaG8=; b=Isu1Krpif5qB3+XBxCRxqHroxj Q5RNvZ1ziFAzNATK2wpF+icmCpaXnAttSDfaD9my2zQjuLSfwTbC4T8Ldn9AOR8ZXkURD6li8or/6 //CvtEO2EaWjimXMy2fM1XV9LZuRUfxKfbGhhkV63BH6zzwjxckCq6Y5ZGPxd3ksl1bU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173061: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=64e302157a87b246473a31fa104377a6d48eb046 X-Osstest-Versions-That: xen=172015009a6acc20357a2698800e13058ba1d3db From: osstest service owner Date: Thu, 08 Sep 2022 10:40:52 +0000 flight 173061 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173061/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173029 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 64e302157a87b246473a31fa104377a6d48eb046 baseline version: xen 172015009a6acc20357a2698800e13058ba1d3db Last test of basis 173029 2022-09-06 19:01:53 Z 1 days Testing same since 173061 2022-09-08 08:01:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Juergen Gross Julien Grall Leo Yan Viresh Kumar jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 172015009a..64e302157a 64e302157a87b246473a31fa104377a6d48eb046 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:47:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:47:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403105.645086 (Exim 4.92) (envelope-from ) id 1oWF4C-0005ac-E2; Thu, 08 Sep 2022 10:47:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403105.645086; Thu, 08 Sep 2022 10:47:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWF4C-0005aV-BQ; Thu, 08 Sep 2022 10:47:28 +0000 Received: by outflank-mailman (input) for mailman id 403105; Thu, 08 Sep 2022 10:47:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWF4B-0005aP-9w for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:47:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWF4A-00055i-Uo; Thu, 08 Sep 2022 10:47:26 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWF4A-0003DN-O1; Thu, 08 Sep 2022 10:47:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RiJWc34ZiZkVyhJlfbItavLbR9Y0PlPQsZkTzrilhP0=; b=ED7ZExRzii35L3ef3lv4dP+lh6 AmyAeFloPVQNtTuxIqZre6g6BPr+DSl6guFTXrmmsT87Oa787MU1xRwNVWuVBFxAfe7I3R3VDs6ck 4PD/lWy0c7Al9/hUbJ194YfFoX0hx2QbEYjAbk1Ht3XQTBv4LRWCn4LuBHzIquz7Fyk0=; Message-ID: Date: Thu, 8 Sep 2022 11:47:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree Content-Language: en-US To: Penny Zheng , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk References: <20220906085941.944592-1-Penny.Zheng@arm.com> <20220906085941.944592-8-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Replying to Penny and Stefano answer in the same e-mail. On 08/09/2022 04:21, Penny Zheng wrote: > >> -----Original Message----- >> From: Stefano Stabellini >> Sent: Thursday, September 8, 2022 8:16 AM >> To: Julien Grall >> Cc: Penny Zheng ; xen-devel@lists.xenproject.org; >> Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest >> device tree >> >> On Wed, 7 Sep 2022, Julien Grall wrote: >>> On 06/09/2022 09:59, Penny Zheng wrote: >>>> We expose the shared memory to the domU using the "xen,shared- >> memory-v1" >>>> reserved-memory binding. See >>>> Documentation/devicetree/bindings/reserved-memory/xen,shared- >> memory. >>>> txt in Linux for the corresponding device tree binding. >>>> >>>> To save the cost of re-parsing shared memory device tree >>>> configuration when creating shared memory nodes in guest device >>>> tree, this commit adds new field "shm_mem" to store shm-info per >>>> domain. >>>> >>>> For each shared memory region, a range is exposed under the >>>> /reserved-memory node as a child node. Each range sub-node is named >>>> xen-shmem@
and has the following properties: >>>> - compatible: >>>> compatible = "xen,shared-memory-v1" >>>> - reg: >>>> the base guest physical address and size of the shared >>>> memory region >>>> - xen,id: >>>> a string that identifies the shared memory region. >>> >>> So technically, there is a property "xen,offset" that should be >>> specified for the borrowers. >>> >>> TBH, I don't quite understand what this property is used for. So it is >>> not quite clear why this is skipped. >>> >>> The Stefano is the author of the binding. So maybe he can explain the >>> purpose of the property and help to document it in the commit message >>> why this is ignored. >> >> It looks like it is something we introduced to handle the case where memory >> from the owner is shared with multiple borrowers. Each borrower would >> have its own offset within the region shared by the owner: >> >> https://marc.info/?l=xen-devel&m=154110446604365&w=2 Thanks for the pointer :). Now, I remember what this was meant for. >> > > IMHO, "xen,offset" more fits in the xen dts? We configure it in borrower memory node, > then later we shall only set up foreign memory map starting at the offset? Yes and Yes. > ''' > domU1-shared-mem@10000000 { > compatible = "xen,domain-shared-memory-v1"; > role = "borrower"; > xen,shm-id = "my-shared-mem-0"; > xen,shared-mem = <0x10000000 0x50000000 0x10000000>; > xen,offset = <0x0 0x01000000>; > } > ''' > For borrower domain, only [0x11000000, 0x20000000) need to get mapped... > Of course, we could limit the memory map in related Linux driver, but for safety, > it should be at Xen? Correct. > >> >> The use-case is a bit of a corner case but it looks valid. If I had to do it now, I >> would at least mark "xen,offset" as "optional". >> >> I think we have two options here and I am happy with either one: >> >> 1) we add xen,offset = <0x0>; >> > > I will let v8 stay with this configuration, and a TODO for actual implementation. Agree. It sounds the best approach for now. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 10:54:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 10:54:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403112.645097 (Exim 4.92) (envelope-from ) id 1oWFBD-0007EY-6a; Thu, 08 Sep 2022 10:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403112.645097; Thu, 08 Sep 2022 10:54:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFBD-0007ER-2A; Thu, 08 Sep 2022 10:54:43 +0000 Received: by outflank-mailman (input) for mailman id 403112; Thu, 08 Sep 2022 10:54:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFBC-0007EL-1v for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 10:54:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80042.outbound.protection.outlook.com [40.107.8.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a329ba1d-2f64-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 12:54:40 +0200 (CEST) Received: from AM6P195CA0075.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::16) by DB9PR08MB9489.eurprd08.prod.outlook.com (2603:10a6:10:458::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Thu, 8 Sep 2022 10:54:30 +0000 Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::71) by AM6P195CA0075.outlook.office365.com (2603:10a6:209:86::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 10:54:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 10:54:29 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 08 Sep 2022 10:54:28 +0000 Received: from 0bd0f3220f62.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 754F1DF7-C4DA-48DC-860E-1828D5D97C10.1; Thu, 08 Sep 2022 10:54:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0bd0f3220f62.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 10:54:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS1PR08MB7497.eurprd08.prod.outlook.com (2603:10a6:20b:4de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 10:54:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 10:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a329ba1d-2f64-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Fc6rO9REIzcrfrGAlO4OFUBuy+lGy3Pd63fNz0+w9ndN2dz9PYhNYApEMx8JJpk7ujfnEzaUYCxqeWSN9+Zr3hyeu25bWdLJBuHYTL4K1nh+zV77l8cDIwjNfAPtDkP/X47ovvP2Moie0tdyjNweNGA8b5kSukZ9/JECZsKm0bHebgSxtYMAGOFmAVU9IOTpVDrgQFcShC8DRA5N7c9nASuT25IurN+98Y0rPJCpKqUT6i3GoY7N4yetEwmSJ6OduJl0y/jpJJImQosVNA5L2+pfm9AxPg22OOFgY1wiPrgYR4lK4LFwMyzj1lToaGGX6F4Nt7zDjzTRLWmwWmQPQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zd0IC8Y2iehB1yUyrT6crDSgwo/gPRk5TFCVmLD/Ee0=; b=BzSIHiHv3y5KD/g6CRGdLon8xHMdSIm+6bfrZ0ns8F5qItJI9YUrEKnGWNadmmpAAvupqVfEF40MeIJMqBHHClCASKhmcIrkD6OCd4roXKAhx+WuT9naWaP2lmRKBQbH5HnZ1X5OEwmT9z5tgHUn2rtHN9MrR2Jqy1Zlqcw2ZnI1No3SwNpJDcz4Lylyg1FbiHhNX5booO0uKrfc7LoXlBlnAcQwHSzLsTeMWWYJUMB71MbpWAOZoNLMA6za6Tl6WNw+cmrotG+LT4IYvvfy5PrLCk1W0TLt7FdXQjvHmMi4cWJVQlz5fLKRkC5k4Rtiv/1orGXpVlJYAsCq1uAveA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zd0IC8Y2iehB1yUyrT6crDSgwo/gPRk5TFCVmLD/Ee0=; b=9piqutcJHT8m8AVlGE1z+dPX0Rxz9F24HtGJFikAIrWFj1Y6cZEWCm1uBWcTbYrgnhHbYf1zjMoGwsAx4mInBksfImW2AsXpSvIvcLgCKh72DKoRt6QA1b9U7/8p7ChTekLYJ/1DD2geuFi5rbXmhzQrcDVXj7MCUPlomBVQW6w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MnGQjZ075hxPEAAdebVsMEbDUP6wsS752hCTo6m0mMf3MPsNtt7C+tn5i33EtR1Tk8i+eK8o55veroNBpQkX/PlQVgWUxNSdCpcnmDGplk11Vj1X8gfwcoHtqR+2WM5Zuug53ee9Q4WdIZO6qur1xDdPju7ZVdkdaPL+e+fIgwYOo+ia52iDbNT48pfOy15A3v5GTbpA0kHi6B+wEJjNI41hWi3jIXYak/oS5sPCtbHdEv8dzLB31zCI/jBjOqFNzabThwzczrMkP69WyrDg2i3L9X/Jf9FH6xxyKdJbwPWdTxFyWIcv6fnspqzh3AVG+CPp0KtlwzS1kdpnu0S9BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zd0IC8Y2iehB1yUyrT6crDSgwo/gPRk5TFCVmLD/Ee0=; b=Xa8a5gmqr3LrRxt1dCvX/Sw4Oql4omSF+6RmGY7oLxylkI+Qvrx5LXVopn6wcQsGkU+ukvHsl08r/M6x67kVboPz5wWN8qJfmm8cojcY26mhHuopLH4pDwkYzQujFvdbvdfFOEE0OrN8TGzk/3Q9yVa615cyD+qwT69+K1Bsqdrxkhfyvw3UjzZkE6MJiegvY9TjLbWSbBheHBfZGFhpXJHNCpMHn6UT4R+iVvswd2WdY9NL6zZ+z0BL7jHCdo4YPk9hOz7WrTeQ3Q5vwa9/Pg/ncoOn2naqf7VxUUSCzcMK+UW9tQQfvsrf20by0FgM30pRjKXLdJ9NEL2f6YV7uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zd0IC8Y2iehB1yUyrT6crDSgwo/gPRk5TFCVmLD/Ee0=; b=9piqutcJHT8m8AVlGE1z+dPX0Rxz9F24HtGJFikAIrWFj1Y6cZEWCm1uBWcTbYrgnhHbYf1zjMoGwsAx4mInBksfImW2AsXpSvIvcLgCKh72DKoRt6QA1b9U7/8p7ChTekLYJ/1DD2geuFi5rbXmhzQrcDVXj7MCUPlomBVQW6w= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" , Julien Grall CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Thread-Topic: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Thread-Index: AQHYw2XP4kTWxhuEi0Wfg39PE1aR463VV3SAgAAAWqA= Date: Thu, 8 Sep 2022 10:54:15 +0000 Message-ID: References: <20220908093129.30124-1-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6F5F84FD08CAC64595488D125C5F0A1F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 10627ba2-78eb-4721-0726-08da9188811c x-ms-traffictypediagnostic: AS1PR08MB7497:EE_|VE1EUR03FT010:EE_|DB9PR08MB9489:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eQosKji2r5S01C5Bb7a5RLMJstZOws/v/4nr0F1lMdVQ+qtWsu8PBEVfqURqjvA0ESSh0svZcTvnAwCv2rB7jfc9DeBa6xrcGKOUVzQ2NQ/7SaMmNHMieoi4N4RtTwPo41DQ+1giryxQUsbeNZAQRqgvHGhQwn2XAENgGjn91pe9h/iHwK5HTD7ltQ6e3lBa/wRuoPLyoS9sb1Qkzhr8b96s+gj4bJvn2WnW6KtOsgDYzK0gcbPGM6fAnZFrSTMLXAfs98JL1pLVSYmEOTS8DowcrZvB87RZksO12a/RC+rm9rdviIS/hH9YVryKgIyPuAt9wP1uHBLhxuD28HRqNFj3wNr6aaMFAJrTTFEogqa2E+8Idx/97Usl6hoRFs2qLy6RPRNqPBBxp0N28veglSdgERASPSXtt0CEbZyOVSTWuAorJcB4qepWoQPs1ukW8ooigBa3/ignKkV36EYbdS6TzC0vaofr3TnGZs3Peqh2U61idIDHAb+csHez1e5/n9arbVJ5QsbnMeQnNkkloAu7kW7pIikijjtNSZlok04M1AG6u9fuQ56cbHUfZOfTVMQbii8Y1eYxTVrCVxi1A9eaLde2MgXTPWJK5m5FVQGr4gIEmJPMvRXEnXB17UVZFoPALQswVP4W1nCKNPJF9D02Egxvp1gNX3Lc1Ozmi44yVSNPIgSfId/yaeoAp9FI1DBQkICNuczFIeDBRqfc47oifto+zyxZXnzh5C8ot0d0P14oP8JTMyaja/9DJBrMUfoPHOZY/d2rOLX7zcBKqw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(83380400001)(38070700005)(71200400001)(54906003)(186003)(122000001)(86362001)(110136005)(316002)(52536014)(8936002)(5660300002)(478600001)(66446008)(76116006)(66946007)(66476007)(4326008)(41300700001)(8676002)(64756008)(9686003)(55016003)(38100700002)(26005)(66556008)(2906002)(33656002)(6506007)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7497 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 186d1531-f3cc-4d7c-ed44-08da918878b7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aDmqfiYB7bP1nOW7d4JbNyJ76akV70d1UvP3ww2lZ7KWZuOMEs9epvgpgYwuCUS1bxkcOaU1ty5kkVrHO/aMqO4cz1W0jKi3P88C+JxBtxlacOTdRtRFdPVCYOy+IXkNx8aBqo+YefLAs+/4do17GFbxVJsMy9bE8DNdDoW8/ExsAIspSbQHZ5Rz5Hd4hb9piUnppofofnAG1Hr6NyEWgxtjwX7j7TddaYjFzWDfPLhwsvECrdxQ6eVDORxQrl1hAHaaUPuOiHPjjMsgw1lKoZiNkYrveqq/TqQM4jt53gN8it7GdJ0agYoFO8mqpHAm7eDNfFaqkdfmP/s+Em7n59ve0ncqU6DMgI0IIny1f+gW/KP0SeXgW/EgKqxQ899qOOhr1kTfVKpS7cV3fkRfFg1LR3ZI65BrG4uJLJhiBObZ16qTAVC/Q8N1mlG3W0t79BmBq/tR4pbYKBs2ouCW8H8GRKz+AKDfNWKgKlPED4B2T5wXYFmZaK/7a417eq4d6MHeJPxyYT/mtOVkk1AcqERQuZBi3pBAN6w9fyYTiCLj5SkkWBxxHDx89qUIX98WhAmm62neiHsCZ6h5Jd8g88EMD20tu8wQLG36lJiN1Krgt+T6MffmMaXcMZdJrbbs8VqzeCLc9KtiDzKRwMpgq/uonnJKY8aU+BRZJJ7bRDP1k6w/jWT1C73gUAFglCWlabCHGUqZ6MEMKQ1IDYylgCmWZuvHbUBy0D8lgjTTplT4rNVYWtblFCPumOv8rfaj7bG7fgSsZMgy+a+33Txhdg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(396003)(36840700001)(40470700004)(46966006)(26005)(7696005)(478600001)(9686003)(186003)(107886003)(41300700001)(6506007)(83380400001)(47076005)(2906002)(336012)(54906003)(52536014)(5660300002)(40480700001)(8936002)(55016003)(110136005)(40460700003)(70206006)(4326008)(8676002)(70586007)(82740400003)(316002)(81166007)(36860700001)(82310400005)(356005)(86362001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 10:54:29.2461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10627ba2-78eb-4721-0726-08da9188811c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9489 SGkgTWljaGFsLA0KDQpUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB5b3VyIHJldmlldywgYXMgYWx3 YXlzIDopKQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hhbCBP cnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4gQEAgLTM2MiwxNCArMzYyLDEzIEBAIGRl dmljZS10cmVlOg0KPiA+DQo+ID4gICAgICAvIHsNCj4gPiAgICAgICAgICBjaG9zZW4gew0KPiA+ ICsgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwweDE+Ow0KPiA+ICsgICAgICAgICAgICAj c2l6ZS1jZWxscyA9IDwweDE+Ow0KPiA+ICsgICAgICAgICAgICAuLi4NCj4gPiAgICAgICAgICAg ICAgZG9tVTEgew0KPiA+ICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZG9tYWlu IjsNCj4gPiAtICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDB4Mj47DQo+ID4gLSAg ICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwweDI+Ow0KPiBXaHkgZGlkIHlvdSByZW1vdmUg dGhpcyBzZXQgaWYgaXQgcmVsYXRlcyB0byB0aGUgY2hpbGRzIG9mIGRvbVUxIChlLmcuIGtlcm5l bCwNCj4gcmFtZGlzaykgYW5kIG5vdCB0byBkb21VMSBpdHNlbGY/DQoNCldlbGwsIEkgdGhpbmsg aGVyZSB0aGUgZXhhbXBsZSBpcyBqdXN0IGhvdyB3ZSBzZXR1cCB0aGUgc3RhdGljIG1lbW9yeSwg c28gd2UganVzdA0Kd2FudCB0byBlbXBoYXNpemUgdGhlIHJlbGF0ZWQgcGFydC4gSSBhZ3JlZSB1 c2VycyBjYW4gYWRkIGFub3RoZXIgI2FkZHJlc3MtY2VsbHMNCmFuZCAjc2l6ZS1jZWxscyBmb3Ig ZG9tVTEgbm9kZSBmb3IgdGhlIHBhcnRzIHRoYXQgeW91IG1lbnRpb25lZCwgYnV0IHRoYXQgaXMN Cm5vdCByZWZsZWN0ZWQgYnkgdGhlIGN1cnJlbnQgZXhhbXBsZSAoSSBjYW4ndCBmaW5kIGFueXRo aW5nIHJlbGF0ZWQgdG8ga2VybmVsLA0KcmFtZGlzaywgZXRjLiBpbiBjdXJyZW50IGV4YW1wbGUp LiBJIG1pZ2h0IGdldCBpdCB3cm9uZyBidXQgaGF2aW5nIHR3byAjYWRkcmVzcy1jZWxscw0KYW5k ICNzaXplLWNlbGxzIGluIHRoYXQgY2FzZSB3b3VsZCBiZSBxdWl0ZSBtaXNsZWFkaW5nIGZyb20g bXkgdW5kZXJzdGFuZGluZy4NClNvIEkgZGVjaWRlZCB0byByZW1vdmUgaXQuDQoNCkJ1dCBJIGFt IG9wZW4gdG8gb3RoZXIgb3BpbmlvbnMuIFNvIHNoYWxsIHdlIGxldCB0aGUgZGlzY3Vzc2lvbiBn byBvbiBmb3IgYSBiaXQgbG9uZ2VyPw0KSSB3aWxsIHJldmVydCB0aGlzIGNoYW5nZSBpZiBtb3N0 IHBlb3BsZSB0aGluayB0aGlzIHJlbW92aW5nIGlzIHVubmVjZXNzYXJ5Lg0KDQo+IA0KPiA+ICAg ICAgICAgICAgICAgICAgY3B1cyA9IDwyPjsNCj4gPiAgICAgICAgICAgICAgICAgIG1lbW9yeSA9 IDwweDAgMHg4MDAwMD47DQo+ID4gLSAgICAgICAgICAgICAgICAjeGVuLHN0YXRpYy1tZW0tYWRk cmVzcy1jZWxscyA9IDwweDE+Ow0KPiA+IC0gICAgICAgICAgICAgICAgI3hlbixzdGF0aWMtbWVt LXNpemUtY2VsbHMgPSA8MHgxPjsNCj4gPiAgICAgICAgICAgICAgICAgIHhlbixzdGF0aWMtbWVt ID0gPDB4MzAwMDAwMDAgMHgyMDAwMDAwMD47DQo+ID4gICAgICAgICAgICAgICAgICAuLi4NCj4g PiAgICAgICAgICAgICAgfTsNCj4gPiBkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9wYXNzdGhy b3VnaC1ub2lvbW11LnR4dA0KPiBiL2RvY3MvbWlzYy9hcm0vcGFzc3Rocm91Z2gtbm9pb21tdS50 eHQNCj4gPiBpbmRleCAzZTJlZjIxYWQ3Li42OWI4ZGUxOTc1IDEwMDY0NA0KPiA+IC0tLSBhL2Rv Y3MvbWlzYy9hcm0vcGFzc3Rocm91Z2gtbm9pb21tdS50eHQNCj4gPiArKysgYi9kb2NzL21pc2Mv YXJtL3Bhc3N0aHJvdWdoLW5vaW9tbXUudHh0DQo+ID4gQEAgLTMzLDE0ICszMywxMyBAQCBvbiBz dGF0aWMgYWxsb2NhdGlvbiBpbiB0aGUgZGV2aWNlLXRyZWU6DQo+ID4NCj4gPiAgLyB7DQo+ID4g ICAgICAgICBjaG9zZW4gew0KPiA+ICsgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDww eDE+Ow0KPiA+ICsgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwweDE+Ow0KPiA+ICsgICAg ICAgICAgICAgICAuLi4NCj4gPiAgICAgICAgICAgICAgICAgZG9tVTEgew0KPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAieGVuLGRvbWFpbiI7DQo+ID4gLSAgICAgICAg ICAgICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MHgyPjsNCj4gPiAtICAgICAgICAgICAg ICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwweDI+Ow0KPiBUaGUgc2FtZSBoZXJlLg0KDQpTYW1l IGFzIGFib3ZlLg0KDQo+IA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGNwdXMgPSA8Mj47 DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgbWVtb3J5ID0gPDB4MCAweDgwMDAwPjsNCj4g PiAtICAgICAgICAgICAgICAgICAgICAgICAjeGVuLHN0YXRpYy1tZW0tYWRkcmVzcy1jZWxscyA9 IDwweDE+Ow0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICN4ZW4sc3RhdGljLW1lbS1zaXpl LWNlbGxzID0gPDB4MT47DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgeGVuLHN0YXRpYy1t ZW0gPSA8MHgzMDAwMDAwMCAweDIwMDAwMDAwPjsNCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBkaXJlY3QtbWFwOw0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIC4uLg0KPiA+IGRpZmYg LS1naXQgYS94ZW4vYXJjaC9hcm0vYm9vdGZkdC5jIGIveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYw0K PiA+IGluZGV4IGVjODFhNDVkZTkuLmNkMjY0NzkzZDUgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2Fy Y2gvYXJtL2Jvb3RmZHQuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9ib290ZmR0LmMNCj4gPiBA QCAtMzUyLDExICszNTIsNiBAQCBzdGF0aWMgaW50IF9faW5pdCBwcm9jZXNzX2RvbWFpbl9ub2Rl KGNvbnN0IHZvaWQNCj4gKmZkdCwgaW50IG5vZGUsDQo+ID4gICAgICAgICAgLyogTm8gInhlbixz dGF0aWMtbWVtIiBwcmVzZW50LiAqLw0KPiA+ICAgICAgICAgIHJldHVybiAwOw0KPiA+DQo+ID4g LSAgICBhZGRyZXNzX2NlbGxzID0gZGV2aWNlX3RyZWVfZ2V0X3UzMihmZHQsIG5vZGUsDQo+ID4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiI3hlbixzdGF0aWMtbWVt LWFkZHJlc3MtY2VsbHMiLCAwKTsNCj4gPiAtICAgIHNpemVfY2VsbHMgPSBkZXZpY2VfdHJlZV9n ZXRfdTMyKGZkdCwgbm9kZSwNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICIjeGVuLHN0YXRpYy1tZW0tc2l6ZS1jZWxscyIsIDApOw0KPiA+IC0NCj4gPiAgICAgIHJl dHVybiBkZXZpY2VfdHJlZV9nZXRfbWVtaW5mbyhmZHQsIG5vZGUsICJ4ZW4sc3RhdGljLW1lbSIs DQo+IGFkZHJlc3NfY2VsbHMsDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc2l6ZV9jZWxscywgJmJvb3RpbmZvLnJlc2VydmVkX21lbSwgdHJ1ZSk7DQo+ID4gIH0NCj4g PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJt L2RvbWFpbl9idWlsZC5jDQo+ID4gaW5kZXggYjc2YTg0ZThmNS4uMjU4ZDc0Njk5ZCAxMDA2NDQN Cj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiArKysgYi94ZW4vYXJj aC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBAQCAtNTYzLDIxICs1NjMsOSBAQCBzdGF0aWMgaW50 IF9faW5pdCBwYXJzZV9zdGF0aWNfbWVtX3Byb3AoY29uc3QNCj4gc3RydWN0IGR0X2RldmljZV9u b2RlICpub2RlLA0KPiA+ICAgICAgY29uc3Qgc3RydWN0IGR0X3Byb3BlcnR5ICpwcm9wOw0KPiA+ DQo+ID4gICAgICBwcm9wID0gZHRfZmluZF9wcm9wZXJ0eShub2RlLCAieGVuLHN0YXRpYy1tZW0i LCBOVUxMKTsNCj4gPiAtICAgIGlmICggIWR0X3Byb3BlcnR5X3JlYWRfdTMyKG5vZGUsICIjeGVu LHN0YXRpYy1tZW0tYWRkcmVzcy1jZWxscyIsDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBhZGRyX2NlbGxzKSApDQo+ID4gLSAgICB7DQo+ID4gLSAgICAgICAgcHJpbnRrKFhF TkxPR19FUlINCj4gPiAtICAgICAgICAgICAgICAgImZhaWxlZCB0byByZWFkIFwiI3hlbixzdGF0 aWMtbWVtLWFkZHJlc3MtY2VsbHNcIi5cbiIpOw0KPiA+IC0gICAgICAgIHJldHVybiAtRUlOVkFM Ow0KPiA+IC0gICAgfQ0KPiA+DQo+ID4gLSAgICBpZiAoICFkdF9wcm9wZXJ0eV9yZWFkX3UzMihu b2RlLCAiI3hlbixzdGF0aWMtbWVtLXNpemUtY2VsbHMiLA0KPiA+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc2l6ZV9jZWxscykgKQ0KPiA+IC0gICAgew0KPiA+IC0gICAgICAgIHBy aW50ayhYRU5MT0dfRVJSDQo+ID4gLSAgICAgICAgICAgICAgICJmYWlsZWQgdG8gcmVhZCBcIiN4 ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzXCIuXG4iKTsNCj4gPiAtICAgICAgICByZXR1cm4gLUVJ TlZBTDsNCj4gPiAtICAgIH0NCj4gPiArICAgICphZGRyX2NlbGxzID0gZHRfbl9hZGRyX2NlbGxz KG5vZGUpOw0KPiA+ICsgICAgKnNpemVfY2VsbHMgPSBkdF9uX3NpemVfY2VsbHMobm9kZSk7DQo+ IFRoZXJlIGlzIGEgdHlwZSBtaXNtYXRjaCBoZXJlIGFzIGUuZy4gYWRkcl9jZWxscyBpcyB1MzIg YW5kIGR0X25fYWRkcl9jZWxscw0KPiByZXR1cm4gdHlwZSBpcyBpbnQuDQo+IEJ1dCBJIGRvbid0 IHRoaW5rIHRoaXMgY2FuIGJlIGhhcm1mdWwgYW5kIGFsc28gaXQncyBzdHJhbmdlIGZvciBtZSB0 aGF0DQo+IGR0X25fYWRkcl9jZWxscw0KPiBpcyBkZWZpbmVkIHRvIHJldHVybiBpbnQgZ2l2ZW4g dGhhdCBpdCBlaXRoZXIgcmV0dXJucyAyIG9yIGJlMzJfdG9fY3B1cCwgd2hpY2gNCj4gbWVhbnMg aXQgc2hvdWxkIHJldHVybiB1MzIuDQoNClllYWguIEkgYWdyZWUuIEkgZGlkIGEgZ2l0IGJsYW1l IGhlcmUgYW5kIGZvdW5kIHRoaXMgZnVuY3Rpb24gaXMgaW50cm9kdWNlZCA5DQp5ZWFycyBhZ28g aW4gImRiZDEyNDMgeGVuL2FybTogQWRkIGhlbHBlcnMgdG8gdXNlIHRoZSBkZXZpY2UgdHJlZSIu IFNvIEkgdGhpbmsNCnByb2JhYmx5IGl0IHdvdWxkIGJlIGVhc2llciB0byBhc2sgdGhlIGF1dGhv ciBmb3IgdGhlIGZvbGxvd2luZyBhY3Rpb24gZGlyZWN0bHkgOikpDQoNCkBKdWxpZW4sIHdoYXQg ZG8geW91IHRoaW5rPyBTaGFsbCB3ZSBtb2RpZnkgdGhlIHJldHVybiB0eXBlIG9mIHRoZXNlIHR3 bw0KZnVuY3Rpb25zPw0KDQo+IA0KPiA+DQo+ID4gICAgICAqY2VsbCA9IChjb25zdCBfX2JlMzIg Kilwcm9wLT52YWx1ZTsNCj4gPiAgICAgICpsZW5ndGggPSBwcm9wLT5sZW5ndGg7DQo+ID4gLS0N Cj4gPiAyLjE3LjENCj4gPg0KPiA+DQo+IEFwYXJ0IGZyb20gdGhhdDoNCj4gUmV2aWV3ZWQtYnk6 IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQoNClRoYW5rcyENCg0KS2luZCBy ZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gfk1pY2hhbA0K From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:09:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:09:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403123.645122 (Exim 4.92) (envelope-from ) id 1oWFPS-00018E-Q4; Thu, 08 Sep 2022 11:09:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403123.645122; Thu, 08 Sep 2022 11:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFPS-000187-NY; Thu, 08 Sep 2022 11:09:26 +0000 Received: by outflank-mailman (input) for mailman id 403123; Thu, 08 Sep 2022 11:09:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFPS-00017c-5B for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:09:26 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b284f159-2f66-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 13:09:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 639481516; Thu, 8 Sep 2022 04:09:30 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0A3AD3F71A; Thu, 8 Sep 2022 04:09:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b284f159-2f66-11ed-a31c-8f8a9ae3403f From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 1/4] xen/arm: bootfdt: Make process_chosen_node() return int Date: Thu, 8 Sep 2022 11:09:07 +0000 Message-Id: <20220908110910.17108-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908110910.17108-1-Henry.Wang@arm.com> References: <20220908110910.17108-1-Henry.Wang@arm.com> At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error type. Signed-off-by: Henry Wang Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from v5 to v6: - No changes. Changes from v4 to v5: - No changes. Changes from v3 to v4: - Add Reviewed-by from Michal and Acked-by from Julien. Changes from v2 to v3: - Adjust the order of this patch, make it the #1. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..1a79b969af 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -293,9 +293,9 @@ static void __init process_multiboot_node(const void *fdt, int node, kind, start, domU); } -static void __init process_chosen_node(const void *fdt, int node, - const char *name, - u32 address_cells, u32 size_cells) +static int __init process_chosen_node(const void *fdt, int node, + const char *name, + u32 address_cells, u32 size_cells) { const struct fdt_property *prop; paddr_t start, end; @@ -306,11 +306,11 @@ static void __init process_chosen_node(const void *fdt, int node, prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); if ( !prop ) /* No initrd present. */ - return; + return 0; if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-start property has invalid length %d\n", len); - return; + return -EINVAL; } start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -318,12 +318,12 @@ static void __init process_chosen_node(const void *fdt, int node, if ( !prop ) { printk("linux,initrd-end not present but -start was\n"); - return; + return -EINVAL; } if ( len != sizeof(u32) && len != sizeof(u64) ) { printk("linux,initrd-end property has invalid length %d\n", len); - return; + return -EINVAL; } end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); @@ -331,12 +331,14 @@ static void __init process_chosen_node(const void *fdt, int node, { printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n", start, end); - return; + return -EINVAL; } printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end); add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); + + return 0; } static int __init process_domain_node(const void *fdt, int node, @@ -383,7 +385,7 @@ static int __init early_scan_node(const void *fdt, device_tree_node_compatible(fdt, node, "multiboot,module" ))) process_multiboot_node(fdt, node, name, address_cells, size_cells); else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) - process_chosen_node(fdt, node, name, address_cells, size_cells); + rc = process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:09:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:09:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403122.645110 (Exim 4.92) (envelope-from ) id 1oWFPO-0000rh-J3; Thu, 08 Sep 2022 11:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403122.645110; Thu, 08 Sep 2022 11:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFPO-0000ra-GY; Thu, 08 Sep 2022 11:09:22 +0000 Received: by outflank-mailman (input) for mailman id 403122; Thu, 08 Sep 2022 11:09:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFPO-0000rR-6g for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:09:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id afec6c41-2f66-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:09:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A6D314BF; Thu, 8 Sep 2022 04:09:26 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AC9753F71A; Thu, 8 Sep 2022 04:09:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afec6c41-2f66-11ed-9760-273f2230c3a0 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v6 0/4] Introduce static heap Date: Thu, 8 Sep 2022 11:09:06 +0000 Message-Id: <20220908110910.17108-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU systems, where only a finite number of memory protection regions are available. The limited number of protection regions places requirement on planning the use of MPU protection regions and one or more MPU protection regions needs to be reserved only for heap. The first patch enhances the error handling in processing the dts chosen node. The second patch introduces the static heap and the device tree parsing code. The third patch renames xenheap_* to directmap_* for better readablity. The fourth patch adds the implementation of the static heap pages handling in boot and heap allocator for Arm. Changes from v5 to v6: - Refine doc. - Drop duplicated code. - Add Julien's Reviewed-by. Henry Wang (4): xen/arm: bootfdt: Make process_chosen_node() return int docs, xen/arm: Introduce static heap memory xen/arm: mm: Rename xenheap_* variable to directmap_* xen/arm: Handle static heap pages in boot and heap allocator SUPPORT.md | 7 ++ docs/misc/arm/device-tree/booting.txt | 44 ++++++++ xen/arch/arm/bootfdt.c | 47 +++++--- xen/arch/arm/domain_build.c | 8 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 31 ++--- xen/arch/arm/include/asm/setup.h | 23 +++- xen/arch/arm/mm.c | 50 +++++---- xen/arch/arm/setup.c | 156 ++++++++++++++++++++------ 9 files changed, 279 insertions(+), 89 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:10:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:10:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403133.645144 (Exim 4.92) (envelope-from ) id 1oWFQ4-0002X8-DF; Thu, 08 Sep 2022 11:10:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403133.645144; Thu, 08 Sep 2022 11:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFQ4-0002Wi-9c; Thu, 08 Sep 2022 11:10:04 +0000 Received: by outflank-mailman (input) for mailman id 403133; Thu, 08 Sep 2022 11:10:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFQ2-0001tk-AU for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:10:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b7161b23-2f66-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:09:32 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3DE271516; Thu, 8 Sep 2022 04:09:38 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D88063F71A; Thu, 8 Sep 2022 04:09:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7161b23-2f66-11ed-9760-273f2230c3a0 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Date: Thu, 8 Sep 2022 11:09:09 +0000 Message-Id: <20220908110910.17108-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908110910.17108-1-Henry.Wang@arm.com> References: <20220908110910.17108-1-Henry.Wang@arm.com> With the static heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily. On Arm32, only the xenheap is direct mapped today. So the renaming to "directmap_*" would be still valid for Arm32. As the xenheap_* is renamed to directmap_*, rename the function setup_xenheap_mappings() to setup_directmap_mappings() to reflect the variable renaming, also change the code comment and printed error message in the function accordingly. No functional change is intended. Signed-off-by: Henry Wang Acked-by: Julien Grall --- Changes from v5 to v6: - No changes. Changes from v4 to v5: - Mention the function and code comment rename in commit mesg. - Add Julien's Acked-by. Changes from v3 to v4: - Also rename the setup_xenheap_mappings() function name and printed messages inside the function. - Update more comments. Changes from v2 to v3: - Adjust the order of this patch, make it #3. Changes from v1 to v2: - New commit. --- xen/arch/arm/bootfdt.c | 2 +- xen/arch/arm/include/asm/config.h | 2 +- xen/arch/arm/include/asm/mm.h | 31 ++++++++++--------- xen/arch/arm/mm.c | 50 +++++++++++++++++-------------- xen/arch/arm/setup.c | 36 +++++++++++----------- 5 files changed, 64 insertions(+), 57 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0ca7b44446..c39aacbd60 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -494,7 +494,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t paddr) device_tree_for_each_node((void *)fdt, 0, early_scan_node, NULL); /* - * On Arm64 setup_xenheap_mappings() expects to be called with the lowest + * On Arm64 setup_directmap_mappings() expects to be called with the lowest * bank in memory first. There is no requirement that the DT will provide * the banks sorted in ascending order. So sort them through. */ diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 2fafb9f228..0fefed1b8a 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -160,7 +160,7 @@ #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) #define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) -#define XENHEAP_VIRT_START xenheap_virt_start +#define XENHEAP_VIRT_START directmap_virt_start #define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 749fbefa0c..7d21120f98 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -154,19 +154,19 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t xenheap_mfn_start, xenheap_mfn_end; -extern vaddr_t xenheap_virt_end; +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -extern vaddr_t xenheap_virt_start; -extern unsigned long xenheap_base_pdx; +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; #endif #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ unsigned long mfn_ = mfn_x(mfn); \ - (mfn_ >= mfn_x(xenheap_mfn_start) && \ - mfn_ < mfn_x(xenheap_mfn_end)); \ + (mfn_ >= mfn_x(directmap_mfn_start) && \ + mfn_ < mfn_x(directmap_mfn_end)); \ }) #else #define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) @@ -203,9 +203,12 @@ extern void remove_early_mappings(void); extern int init_secondary_pagetables(int cpu); /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ extern void mmu_init_secondary_cpu(void); -/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. - * Base must be 32MB aligned and size a multiple of 32MB. */ -extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns); +/* + * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, + * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. + * For Arm64, map the region in the directmap area. + */ +extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ @@ -267,16 +270,16 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) static inline void *maddr_to_virt(paddr_t ma) { ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); - ma -= mfn_to_maddr(xenheap_mfn_start); + ma -= mfn_to_maddr(directmap_mfn_start); return (void *)(unsigned long) ma + XENHEAP_VIRT_START; } #else static inline void *maddr_to_virt(paddr_t ma) { - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - xenheap_base_pdx) < + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < (DIRECTMAP_SIZE >> PAGE_SHIFT)); return (void *)(XENHEAP_VIRT_START - - (xenheap_base_pdx << PAGE_SHIFT) + + (directmap_base_pdx << PAGE_SHIFT) + ((ma & ma_va_bottom_mask) | ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); } @@ -319,10 +322,10 @@ static inline struct page_info *virt_to_page(const void *v) unsigned long pdx; ASSERT(va >= XENHEAP_VIRT_START); - ASSERT(va < xenheap_virt_end); + ASSERT(va < directmap_virt_end); pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; - pdx += mfn_to_pdx(xenheap_mfn_start); + pdx += mfn_to_pdx(directmap_mfn_start); return frame_table + pdx - frametable_base_pdx; } diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..11ee49598b 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t xenheap_mfn_end __read_mostly; -vaddr_t xenheap_virt_end __read_mostly; +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; #ifdef CONFIG_ARM_64 -vaddr_t xenheap_virt_start __read_mostly; -unsigned long xenheap_base_pdx __read_mostly; +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; #endif unsigned long frametable_base_pdx __read_mostly; @@ -597,55 +597,59 @@ void mmu_init_secondary_cpu(void) } #ifdef CONFIG_ARM_32 -/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory. */ -void __init setup_xenheap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) +/* + * Set up the direct-mapped xenheap: + * up to 1GB of contiguous, always-mapped memory. + */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) { int rc; rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, PAGE_HYPERVISOR_RW | _PAGE_BLOCK); if ( rc ) - panic("Unable to setup the xenheap mappings.\n"); + panic("Unable to setup the directmap mappings.\n"); - /* Record where the xenheap is, for translation routines. */ - xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; + /* Record where the directmap is, for translation routines. */ + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; } #else /* CONFIG_ARM_64 */ -void __init setup_xenheap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) +/* Map the region in the directmap area. */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) { int rc; - /* First call sets the xenheap physical and virtual offset. */ - if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) ) + /* First call sets the directmap physical and virtual offset. */ + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) { unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - xenheap_mfn_start = _mfn(base_mfn); - xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); /* * The base address may not be aligned to the first level * size (e.g. 1GB when using 4KB pages). This would prevent * superpage mappings for all the regions because the virtual * address and machine address should both be suitably aligned. * - * Prevent that by offsetting the start of the xenheap virtual + * Prevent that by offsetting the start of the directmap virtual * address. */ - xenheap_virt_start = DIRECTMAP_VIRT_START + + directmap_virt_start = DIRECTMAP_VIRT_START + (base_mfn - mfn_gb) * PAGE_SIZE; } - if ( base_mfn < mfn_x(xenheap_mfn_start) ) - panic("cannot add xenheap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(xenheap_mfn_start)); + if ( base_mfn < mfn_x(directmap_mfn_start) ) + panic("cannot add directmap mapping at %lx below heap start %lx\n", + base_mfn, mfn_x(directmap_mfn_start)); rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), _mfn(base_mfn), nr_mfns, PAGE_HYPERVISOR_RW | _PAGE_BLOCK); if ( rc ) - panic("Unable to setup the xenheap mappings.\n"); + panic("Unable to setup the directmap mappings.\n"); } #endif diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3c36c050bf..9f3838d004 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -697,11 +697,11 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 /* Avoid the xenheap */ - if ( s < mfn_to_maddr(xenheap_mfn_end) && - mfn_to_maddr(xenheap_mfn_start) < e ) + if ( s < mfn_to_maddr(directmap_mfn_end) && + mfn_to_maddr(directmap_mfn_start) < e ) { - e = mfn_to_maddr(xenheap_mfn_start); - n = mfn_to_maddr(xenheap_mfn_end); + e = mfn_to_maddr(directmap_mfn_start); + n = mfn_to_maddr(directmap_mfn_end); } #endif @@ -791,17 +791,17 @@ static void __init setup_mm(void) /* * We need some memory to allocate the page-tables used for the - * xenheap mappings. So populate the boot allocator first. + * directmap mappings. So populate the boot allocator first. * - * This requires us to set xenheap_mfn_{start, end} first so the Xenheap - * region can be avoided. + * This requires us to set directmap_mfn_{start, end} first so the + * direct-mapped Xenheap region can be avoided. */ - xenheap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - xenheap_mfn_end = mfn_add(xenheap_mfn_start, xenheap_pages); + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); populate_boot_allocator(); - setup_xenheap_mappings(mfn_x(xenheap_mfn_start), xenheap_pages); + setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); @@ -816,8 +816,8 @@ static void __init setup_mm(void) smp_processor_id()); /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), - mfn_to_maddr(xenheap_mfn_end)); + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); init_staticmem_pages(); } @@ -833,7 +833,7 @@ static void __init setup_mm(void) init_pdx(); /* - * We need some memory to allocate the page-tables used for the xenheap + * We need some memory to allocate the page-tables used for the directmap * mappings. But some regions may contain memory already allocated * for other uses (e.g. modules, reserved-memory...). * @@ -852,15 +852,15 @@ static void __init setup_mm(void) ram_start = min(ram_start, bank->start); ram_end = max(ram_end, bank_end); - setup_xenheap_mappings(PFN_DOWN(bank->start), - PFN_DOWN(bank->size)); + setup_directmap_mappings(PFN_DOWN(bank->start), + PFN_DOWN(bank->size)); } total_pages += ram_size >> PAGE_SHIFT; - xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - xenheap_mfn_start = maddr_to_mfn(ram_start); - xenheap_mfn_end = maddr_to_mfn(ram_end); + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:10:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:10:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403132.645133 (Exim 4.92) (envelope-from ) id 1oWFQ3-000285-60; Thu, 08 Sep 2022 11:10:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403132.645133; Thu, 08 Sep 2022 11:10:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFQ3-00027j-1A; Thu, 08 Sep 2022 11:10:03 +0000 Received: by outflank-mailman (input) for mailman id 403132; Thu, 08 Sep 2022 11:10:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFQ1-0001tk-H3 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:10:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b52a440a-2f66-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:09:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFD7714BF; Thu, 8 Sep 2022 04:09:34 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 50A7E3F71A; Thu, 8 Sep 2022 04:09:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b52a440a-2f66-11ed-9760-273f2230c3a0 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v6 2/4] docs, xen/arm: Introduce static heap memory Date: Thu, 8 Sep 2022 11:09:08 +0000 Message-Id: <20220908110910.17108-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908110910.17108-1-Henry.Wang@arm.com> References: <20220908110910.17108-1-Henry.Wang@arm.com> This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_tree_get_meminfo(). Changes of code are done accordingly following the introduction of this enum. Also, this commit introduces the logic to parse the static heap configuration in device tree. If the memory bank is reserved as heap through `xen,static-heap` property in device tree `chosen` node, the memory will be marked as static heap type. A documentation section is added, describing the definition of static heap memory and the method of enabling the static heap memory through device tree at boot time. Signed-off-by: Henry Wang Signed-off-by: Penny Zheng Reviewed-by: Julien Grall --- Changes from v5 to v6: - Refine doc. - Drop duplicated code. - Add Julien's Reviewed-by. Changes from v4 to v5: - Use #address-cells and #size-cells for static heap, do not introduce new address/size cells. Update the dt-binding accordingly. - Correct a typo in code comments. - Drop Stefano's acked-by as it is not valid. Changes from v3 to v4: - Change of wording in comments. - Add the static heap feature in SUPPORT.md as tech preview. Changes from v2 to v3: - Define `enum membank_type` properly, drop the typedef. - Rename the feature terminology to static heap. - Rename MEMBANK_MEMORY to MEMBANK_DEFAULT and MEMBANK_XEN_DOMAIN to MEMBANK_STATIC_DOMAIN. Add comments to `enum membank_type`. - Correct typo, add the clarification of the static heap region should contain enough memory below 4GB to cater 32-bit DMA for Arm32, and add the 64KB alignment requirement in doc. - Add Stefano's Acked-by for device tree interface. Changes from v1 to v2: - Rename the device tree property to xen,static-heap to avoid confusion. - Change of commit msg and doc wording, correct typo in commit msg. - Do not change the process_chosen_node() return type. - Add an empty line in make_memory_node() memory type check to improve readability. - Use enum membank_type to make the memory type cleaner. Changes from RFC to v1: - Rename the terminology to reserved heap. --- SUPPORT.md | 7 +++++ docs/misc/arm/device-tree/booting.txt | 44 +++++++++++++++++++++++++++ xen/arch/arm/bootfdt.c | 23 +++++++++++--- xen/arch/arm/domain_build.c | 8 +++-- xen/arch/arm/include/asm/setup.h | 22 +++++++++++++- xen/arch/arm/setup.c | 2 +- 6 files changed, 97 insertions(+), 9 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index 8e040d1c1e..b02a5d25ca 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -293,6 +293,13 @@ pre-defined by configuration using physical address ranges. Status, ARM: Tech Preview +### Static Heap + +Allow reserving parts of RAM through the device tree using physical +address ranges as heap. + + Status, ARM: Tech Preview + ### Memory Sharing Allow sharing of identical pages between guests diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..d71f59b63c 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,47 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + + +Static Heap Memory +================== + +The static heap memory refers to parts of RAM reserved in the beginning of +boot time for heap. The memory is reserved by configuration in the device +tree using physical address ranges. + +The static heap memory declared in the device tree defines the memory areas +that will be reserved to be used exclusively as heap. + +- For Arm32, since there are separated heaps, the static heap will be used +for both domheap and xenheap. The admin should make sure that the static +heap region should contain enough memory below 4GB to cater 32-bit DMA. + +- For Arm64, since there is a single heap, the defined static heap areas +shall always go to the heap allocator. + +The static heap memory is an optional feature and can be enabled by adding +below device tree property. + +- xen,static-heap + + Property under the top-level "chosen" node. It specifies the address + and size of Xen static heap memory. Number of address and size cells + for the "xen,static-heap" property is determined by the root node + "#address-cells" and "#size-cells". Note that at least a 64KB alignment + is required. + +Below is an example on how to specify the static heap in device tree: + + / { + #address-cells = <0x2>; + #size-cells = <0x2>; + ... + chosen { + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; + ... + }; + }; + +RAM starting from the host physical address 0x30000000 of 1GB size will +be reserved as static heap. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 1a79b969af..0ca7b44446 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -64,7 +64,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, - void *data, bool xen_domain) + void *data, enum membank_type type) { const struct fdt_property *prop; unsigned int i, banks; @@ -95,7 +95,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, continue; mem->bank[mem->nr_banks].start = start; mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].xen_domain = xen_domain; + mem->bank[mem->nr_banks].type = type; mem->nr_banks++; } @@ -185,7 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, void *data) { return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, - data, false); + data, MEMBANK_DEFAULT); } static int __init process_reserved_memory_node(const void *fdt, int node, @@ -301,6 +301,20 @@ static int __init process_chosen_node(const void *fdt, int node, paddr_t start, end; int len; + if ( fdt_get_property(fdt, node, "xen,static-heap", NULL) ) + { + int rc; + + printk("Checking for static heap in /chosen\n"); + + rc = device_tree_get_meminfo(fdt, node, "xen,static-heap", + address_cells, size_cells, + &bootinfo.reserved_mem, + MEMBANK_STATIC_HEAP); + if ( rc ) + return rc; + } + printk("Checking for initrd in /chosen\n"); prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); @@ -360,7 +374,8 @@ static int __init process_domain_node(const void *fdt, int node, "#xen,static-mem-size-cells", 0); return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, - size_cells, &bootinfo.reserved_mem, true); + size_cells, &bootinfo.reserved_mem, + MEMBANK_STATIC_DOMAIN); } static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..cea82374f7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11 @@ static int __init make_memory_node(const struct domain *d, if ( mem->nr_banks == 0 ) return -ENOENT; - /* find first memory range not bound to a Xen domain */ - for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) + /* find the first memory range that is reserved for device (or firmware) */ + for ( i = 0; i < mem->nr_banks && + (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) ; + if ( i == mem->nr_banks ) return 0; @@ -1062,7 +1064,7 @@ static int __init make_memory_node(const struct domain *d, u64 start = mem->bank[i].start; u64 size = mem->bank[i].size; - if ( mem->bank[i].xen_domain ) + if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) continue; dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 5815ccf8c5..09188acae8 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -22,11 +22,31 @@ typedef enum { BOOTMOD_UNKNOWN } bootmodule_kind; +enum membank_type { + /* + * The MEMBANK_DEFAULT type refers to either reserved memory for the + * device/firmware (when the bank is in 'reserved_mem') or any RAM (when + * the bank is in 'mem'). + */ + MEMBANK_DEFAULT, + /* + * The MEMBANK_STATIC_DOMAIN type is used to indicate whether the memory + * bank is bound to a static Xen domain. It is only valid when the bank + * is in reserved_mem. + */ + MEMBANK_STATIC_DOMAIN, + /* + * The MEMBANK_STATIC_HEAP type is used to indicate whether the memory + * bank is reserved as static heap. It is only valid when the bank is + * in reserved_mem. + */ + MEMBANK_STATIC_HEAP, +}; struct membank { paddr_t start; paddr_t size; - bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ + enum membank_type type; }; struct meminfo { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 7814fe323d..3c36c050bf 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -644,7 +644,7 @@ static void __init init_staticmem_pages(void) for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) { - if ( bootinfo.reserved_mem.bank[bank].xen_domain ) + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) { mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:10:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403137.645155 (Exim 4.92) (envelope-from ) id 1oWFQ6-0002yW-0g; Thu, 08 Sep 2022 11:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403137.645155; Thu, 08 Sep 2022 11:10:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFQ5-0002xw-Su; Thu, 08 Sep 2022 11:10:05 +0000 Received: by outflank-mailman (input) for mailman id 403137; Thu, 08 Sep 2022 11:10:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFQ5-0001tk-A4 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:10:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b90e09f1-2f66-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:09:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82E7F153B; Thu, 8 Sep 2022 04:09:41 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 29B833F71A; Thu, 8 Sep 2022 04:09:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b90e09f1-2f66-11ed-9760-273f2230c3a0 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 4/4] xen/arm: Handle static heap pages in boot and heap allocator Date: Thu, 8 Sep 2022 11:09:10 +0000 Message-Id: <20220908110910.17108-5-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908110910.17108-1-Henry.Wang@arm.com> References: <20220908110910.17108-1-Henry.Wang@arm.com> This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap is enabled, we use the static heap region for both domheap and xenheap allocation. Note that the xenheap on Arm32 should be always contiguous, so also add a helper fit_xenheap_in_static_heap() for Arm32 to find the required xenheap in the static heap regions. For Arm64, In `setup_mm`, if the static heap is enabled and used, we make sure that only these static heap pages are added to the boot allocator. These static heap pages in the boot allocator are added to the heap allocator at `end_boot_allocator()`. If the static heap is disabled, we stick to current page allocation strategy at boot time. Also, take the chance to correct a "double not" print in Arm32 `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR. Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- Changes from v5 to v6: - No changes. Changes from v4 to v5: - No changes. Changes from v3 to v4: - Add Julien's Reviewed-by. Changes from v2 to v3: - Adjustment of the terminology change to "static heap". - Change of wording in comments. - int i -> unsigned int i. - Avoid extra indentation by reverting the check of MEMBANK_RSVD_HEAP. - Use MB(32). - Drop unnecessary panic and unused variables. - Avoid the ternary operation in assigning the heap_pages. - Rework populate_boot_allocator() for static heap. Changes from v1 to v2: - Move the global bool `reserved_heap` to bootinfo. - Replace the open open-coding address ~0 by INVALID_PADDR. - Do not use reverted logic in heap_pages calculation. - Remove unused Arm32 reserved_heap_start variable. - Decouple the arm32 reserved heap too small size check with region end check. - Reuse the arm32 original xenheap finding logic with the new helper to make sure xenheap on arm32 is contiguous. Changes from RFC to v1: - Rebase on top of latest `setup_mm()` changes. - Added Arm32 logic in `setup_mm()`. --- xen/arch/arm/bootfdt.c | 2 + xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/setup.c | 118 +++++++++++++++++++++++++++---- 3 files changed, 107 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index c39aacbd60..9e1ea60094 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -313,6 +313,8 @@ static int __init process_chosen_node(const void *fdt, int node, MEMBANK_STATIC_HEAP); if ( rc ) return rc; + + bootinfo.static_heap = true; } printk("Checking for initrd in /chosen\n"); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 09188acae8..5b86cf0245 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -97,6 +97,7 @@ struct bootinfo { #ifdef CONFIG_ACPI struct meminfo acpi; #endif + bool static_heap; }; struct map_range_data diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 9f3838d004..e0f9809d7e 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -556,6 +556,44 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, } return e; } + +/* + * Find a contiguous region that fits in the static heap region with + * required size and alignment, and return the end address of the region + * if found otherwise 0. + */ +static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) +{ + unsigned int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Allocate the xenheap as high as possible to keep low-memory + * available (assuming the admin supplied region below 4GB) + * for other use (e.g. domain memory allocation). + */ + end = max(end, aligned_end); + } + + return end; +} #endif /* @@ -661,22 +699,51 @@ static void __init init_staticmem_pages(void) } /* - * Populate the boot allocator. All the RAM but the following regions - * will be added: + * Populate the boot allocator. + * If a static heap was not provided by the admin, all the RAM but the + * following regions will be added: * - Modules (e.g., Xen, Kernel) * - Reserved regions * - Xenheap (arm32 only) + * If a static heap was provided by the admin, populate the boot + * allocator with the corresponding regions only, but with Xenheap excluded + * on arm32. */ static void __init populate_boot_allocator(void) { unsigned int i; const struct meminfo *banks = &bootinfo.mem; + paddr_t s, e; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + s = bootinfo.reserved_mem.bank[i].start; + e = s + bootinfo.reserved_mem.bank[i].size; +#ifdef CONFIG_ARM_32 + /* Avoid the xenheap, note that the xenheap cannot across a bank */ + if ( s <= mfn_to_maddr(directmap_mfn_start) && + e >= mfn_to_maddr(directmap_mfn_end) ) + { + init_boot_pages(s, mfn_to_maddr(directmap_mfn_start)); + init_boot_pages(mfn_to_maddr(directmap_mfn_end), e); + } + else +#endif + init_boot_pages(s, e); + } + + return; + } for ( i = 0; i < banks->nr_banks; i++ ) { const struct membank *bank = &banks->bank[i]; paddr_t bank_end = bank->start + bank->size; - paddr_t s, e; s = bank->start; while ( s < bank_end ) @@ -714,8 +781,8 @@ static void __init populate_boot_allocator(void) #ifdef CONFIG_ARM_32 static void __init setup_mm(void) { - paddr_t ram_start, ram_end, ram_size, e; - unsigned long ram_pages; + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t static_heap_end = 0, static_heap_size = 0; unsigned long heap_pages, xenheap_pages, domheap_pages; unsigned int i; const uint32_t ctr = READ_CP32(CTR); @@ -735,30 +802,51 @@ static void __init setup_mm(void) for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) { - paddr_t bank_start = bootinfo.mem.bank[i].start; - paddr_t bank_size = bootinfo.mem.bank[i].size; - paddr_t bank_end = bank_start + bank_size; + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; ram_size = ram_size + bank_size; ram_start = min(ram_start,bank_start); ram_end = max(ram_end,bank_end); } - total_pages = ram_pages = ram_size >> PAGE_SHIFT; + total_pages = ram_size >> PAGE_SHIFT; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + static_heap_size += bank_size; + static_heap_end = max(static_heap_end, bank_end); + } + + heap_pages = static_heap_size >> PAGE_SHIFT; + } + else + heap_pages = total_pages; /* * If the user has not requested otherwise via the command line * then locate the xenheap using these constraints: * + * - must be contiguous * - must be 32 MiB aligned * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system if less + * - must be at most 1GB or 1/32 the total RAM in the system (or static + heap if enabled) if less * - must be at least 32M * * We try to allocate the largest xenheap possible within these * constraints. */ - heap_pages = ram_pages; if ( opt_xenheap_megabytes ) xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); else @@ -770,7 +858,9 @@ static void __init setup_mm(void) do { - e = consider_modules(ram_start, ram_end, + e = bootinfo.static_heap ? + fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : + consider_modules(ram_start, ram_end, pfn_to_paddr(xenheap_pages), 32<<20, 0); if ( e ) @@ -780,7 +870,7 @@ static void __init setup_mm(void) } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); if ( ! e ) - panic("Not not enough space for xenheap\n"); + panic("Not enough space for xenheap\n"); domheap_pages = heap_pages - xenheap_pages; @@ -825,7 +915,7 @@ static void __init setup_mm(void) static void __init setup_mm(void) { const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = ~0; + paddr_t ram_start = INVALID_PADDR; paddr_t ram_end = 0; paddr_t ram_size = 0; unsigned int i; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:29:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403165.645166 (Exim 4.92) (envelope-from ) id 1oWFil-0005ux-Lu; Thu, 08 Sep 2022 11:29:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403165.645166; Thu, 08 Sep 2022 11:29:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFil-0005uq-Ip; Thu, 08 Sep 2022 11:29:23 +0000 Received: by outflank-mailman (input) for mailman id 403165; Thu, 08 Sep 2022 11:29:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFik-0005uk-51 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:29:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFij-00066Q-RC; Thu, 08 Sep 2022 11:29:21 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWFij-0005BX-L0; Thu, 08 Sep 2022 11:29:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=Uuj8qJ9EuJsMdUdLBNxhKzue23Br6mdT4hxrOmqVGKo=; b=m5jfV67wJm5i3sGCGM/gpQ6max kif/FoVnqlojctazb3tyUaDilUj9cj66rDFhNk6LlKnr0AWOpeV8iJVfzSO7czuRpSbP0yHUWLdr5 aYYjV7BHvF/2Gc84vrUqoLakD6fMtDlfs+LgwE0oDFH8ydcGbKb5OfxLlo5fXxItqjJ4=; Message-ID: <57153092-942e-2382-b863-911c7460c43e@xen.org> Date: Thu, 8 Sep 2022 12:29:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5] tools/xenstore: add migration stream extensions for new features Content-Language: en-US From: Julien Grall To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220908081552.19889-1-jgross@suse.com> <168bd423-aa3a-ead6-4a00-0f540ae3c15f@xen.org> In-Reply-To: <168bd423-aa3a-ead6-4a00-0f540ae3c15f@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/09/2022 11:12, Julien Grall wrote: > Hi Juergen, > > On 08/09/2022 09:15, Juergen Gross wrote: >> Extend the definition of the Xenstore migration stream to cover new >> features: >> >> - per domain features >> - extended watches (watch depth) >> - per domain quota >> >> Some of those additions (per domain features and extended watches) >> require bumping the migration stream version to "2", as usage of those >> features will require to transport mandatory new information in the >> migration stream. >> >> One note regarding the GLOBAL_QUOTA_DATA record: the split of quota >> between global and per-domain ones is meant to support the possibility >> to pass on unknown quota settings for newly created domains to other >> Xenstore instances: >> >> Imagine Xenstore A knows about global quota g and domain quota d, while >> Xenstore B doesn't know both. Initially I'm running Xenstore A on a >> host, then I'm live-updating to B. >> >> B gets the information that g is global, and d is per-domain, but has >> no other idea what to do with the values of g and d. OTOH it knows that >> each new domain should get d with the related value, so it can set d >> for each newly created domain. >> >> When B is either downgraded to A again, or a domain is migrated to >> another host running A, B can add the quota information of d for all >> domains. >> >> Signed-off-by: Juergen Gross > > Reviewed-by: Julien Grall I have committed it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:32:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:32:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403172.645176 (Exim 4.92) (envelope-from ) id 1oWFlU-0007H9-3L; Thu, 08 Sep 2022 11:32:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403172.645176; Thu, 08 Sep 2022 11:32:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFlU-0007H2-05; Thu, 08 Sep 2022 11:32:12 +0000 Received: by outflank-mailman (input) for mailman id 403172; Thu, 08 Sep 2022 11:32:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFlS-0007Gu-L9 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:32:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFlS-0006Ar-EI; Thu, 08 Sep 2022 11:32:10 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWFlS-0005EE-8k; Thu, 08 Sep 2022 11:32:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZYtUtvSlAkEvpZ45leWGUpubBqy2mShuW4fu7d9MF8c=; b=iwrmA7NLJMR0NqMrQ/r1XxLaTg r9JdhuDmDll42RW9gC5fXFd4Fr4x3w+Fzetwu+HAAipArBUU8uoP33bFBavm2l6RRvsWxYlaMbe+v KcUS9ZOhWCJxWYuPh5mepJz6pGVJfM9V1JD8d9I3XAj/LnO5qTq8QyGLQF09WSCKrvFM=; Message-ID: <4e561e37-d911-4be9-f50d-3799c71ee3cf@xen.org> Date: Thu, 8 Sep 2022 12:32:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 7/7] xen/arm: introduce xen-evtchn dom0less property Content-Language: en-US To: Stefano Stabellini , Rahul Singh Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/09/2022 01:04, Stefano Stabellini wrote: > On Wed, 7 Sep 2022, Rahul Singh wrote: >> Introduce a new sub-node under /chosen node to establish static event >> channel communication between domains on dom0less systems. >> >> An event channel will be created beforehand to allow the domains to >> send notifications to each other. >> >> Signed-off-by: Rahul Singh > > For the DT binding: > > Reviewed-by: Stefano Stabellini This is now committed but I didn't notice the "For the DT binding" above. So I mistakenly interpreted this as you reviewed everything. Let me know if that's a problem with you. For the future may I ask to use suffix with "# DT binding" as this is easier to spot when using automatic tools (e.g. b4)? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:33:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:33:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403179.645191 (Exim 4.92) (envelope-from ) id 1oWFmQ-0007t0-FB; Thu, 08 Sep 2022 11:33:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403179.645191; Thu, 08 Sep 2022 11:33:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFmQ-0007st-CX; Thu, 08 Sep 2022 11:33:10 +0000 Received: by outflank-mailman (input) for mailman id 403179; Thu, 08 Sep 2022 11:33:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFmP-0007sf-CM for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:33:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFmP-0006Bh-33; Thu, 08 Sep 2022 11:33:09 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWFmO-0005Q5-TW; Thu, 08 Sep 2022 11:33:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5yTKlD7qAkOEUZeNCZJ/+rQk35l+cF0IpTEEdZXbpKA=; b=j2v0uYGhCfgHcgxVW3UtwhJfyt 9TSsZvzV/w4ieyNKgAd9e4G89AcSY/+z9TaEx4UIJDI+/J+vKHEX3BQIO5FOT0omUc8g8nCyKPQ8e sjv/7Pc3fm5u9zTUCF75mqNE+vsnW7f1zeCl96iO5yqfCa0L6RF4lfoMPrDNHztx7Uxs=; Message-ID: <38ab7898-57ce-43be-7d41-13b75fc17f8e@xen.org> Date: Thu, 8 Sep 2022 12:33:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v6 0/4] Introduce static heap Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220908110910.17108-1-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220908110910.17108-1-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 08/09/2022 12:09, Henry Wang wrote: > The static heap, or statically configured heap, refers to parts > of RAM reserved in the beginning for heap. Like the static memory > allocation, such static heap regions are reserved by configuration > in the device tree using physical address ranges. > > This feature is useful to run Xen on Arm MPU systems, where only a > finite number of memory protection regions are available. The limited > number of protection regions places requirement on planning the use > of MPU protection regions and one or more MPU protection regions needs > to be reserved only for heap. > > The first patch enhances the error handling in processing the dts > chosen node. The second patch introduces the static heap and the > device tree parsing code. The third patch renames xenheap_* to > directmap_* for better readablity. The fourth patch adds the > implementation of the static heap pages handling in boot and heap > allocator for Arm. > > Changes from v5 to v6: > - Refine doc. > - Drop duplicated code. > - Add Julien's Reviewed-by. > > Henry Wang (4): > xen/arm: bootfdt: Make process_chosen_node() return int > docs, xen/arm: Introduce static heap memory > xen/arm: mm: Rename xenheap_* variable to directmap_* > xen/arm: Handle static heap pages in boot and heap allocator I have now committed the series. This required a small tweak in booting.txt because I merged it after Rahul event channel's series which also modifies booting.txt. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:42:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:42:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403198.645246 (Exim 4.92) (envelope-from ) id 1oWFv8-0001bI-SE; Thu, 08 Sep 2022 11:42:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403198.645246; Thu, 08 Sep 2022 11:42:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFv8-0001bB-Pa; Thu, 08 Sep 2022 11:42:10 +0000 Received: by outflank-mailman (input) for mailman id 403198; Thu, 08 Sep 2022 11:42:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFv7-0001b5-BF for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:42:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44875d75-2f6b-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 13:42:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7370.eurprd04.prod.outlook.com (2603:10a6:102:92::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 8 Sep 2022 11:42:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 11:42:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44875d75-2f6b-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIz6BIfxxwjEoqKuhXlaKg5IwXfvr/qznCyxWZhIqRncEcjYWNakkd3yW8pFi0EemaSiO4CgHr/PKpJcoHGp08Dto7E+daX5kMyLdHEDg9YOq1/4MI1yLUF6vvLNOrXJdeB2ZcSz3f6aiXHIjgaZyHQYhQ7ZfXxHk+fWN2Z+xcAZ09g8h09oHcTN4OLrDoTOJKr9HDxAj2HuuFkjDHGbtMUU4nFZqfLTZggabzsjKjRBpl+KvrgkeNuOJCBVS2LrehAYsezw7Om+6SnDv5S8WcXcB1cDOolChqjewyky51XlPlWBdF7ouWkDu2SmXGbUwlx1wM3OKEhN39rFelFyKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CM3Y+8Zt92qFax4IxSIdScPezGFPceBw1YOrNuc3kbs=; b=OH+WptGQJGiPhlO7/DapM+j7UXvWS5MGTI+WAFM6Q9BrrWeVKZneto/tnri13GFXOblxyyDYF40qoyUSLMdnakJuAc3ZkbVwA2F/WKL/1j9dA7dtgWU3V9fbwDIJWvyUz1WcZqP9uVPUqRdLup7Q6ovSwBrbin5CMfDyK0k1Y5YdFl3bDAC6kvXxNKHPdHcEE1nKV2eMStwolCH2b8HEk3DnbmeX5vcr4SPT5ipLVzPfOs4s4y3mTv1pi8HzAB2MfzuhCaWxpie3zV4MqgbO9Cr+6DTJJRZvhbTdXWUaMfTIu6h18hI3HiR+3HQQ6AwT+tHJyAT76nWSdIpyurNQGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CM3Y+8Zt92qFax4IxSIdScPezGFPceBw1YOrNuc3kbs=; b=ItaeFWNT+1dRh8yDueLsp1My/wLQ3XVGEEOr5uevhW68A8qmO/bfLPZDNy/8n6icyjLo4Rt5IVpn93FKddG6bK1BtBYTmo+ASj0xgBUuV/wFzhG4vKi6A9r+g0C4qXhBz376mugHwsFvhVzq3AORxVqKXRG4QHfHvyHKGnVBN6YO9sPhg+8aa/MzeHmBWM0sYmzbtKHx69rdoo5PJ4lbWpAinwER089Xlt7ShTI1GO5icQYxHnzs4j5+QI8H09mRsT17Y6k0ctesOblWk3Z71imK6BzFsvaFZA8qs25o39YYGmZbbO1B/VjHZO7lqMALp0tatDYmM2Su8lJM5TYcBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <085c4903-dab9-2d0e-2e25-d7e0d9479aa6@suse.com> Date: Thu, 8 Sep 2022 13:42:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0174.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7370:EE_ X-MS-Office365-Filtering-Correlation-Id: f86e9651-cf7f-40a0-cd64-08da918f2725 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C7r3CMarJLbCsVsnV28tnYXZCrO6GwoxpWEfN4sBNlTiBLqP34DOq4zHRw5s5NH9HG5iAPBKsyOmBBgSBUTckmJ6e52O7AMXpS+gUw9Ikfnv9gfKH44wRhevmUs1sIvZRHdIhRZBCzy+rH4fhEsYzHwReBgN/TCUX2bcrUkRXjzCG5Z9HOqt2WNAyV7utQrbRk50U47p8M4t2hUo7BhDbCifVOv5bA7Tr05g6/PHvz3zMFzZp/bvOozknnzNpyhsLMmtOsnL92Jbhvjw4yi+IHJXVmK9XjGHHHLSmNBlpl2aMo+bVHvhigO4LQnBnVLVBC4NJm77DBkvuFYu8OIe/Ir6KejzYWY0+ela4dhTq3cPv0GtHjUrPOSA9BzPXJvAqMl5/YGwhuyQBMbgSHthpo6bjKTAUAYCVn9tq1if9G754JrgBfAiJvj4aqdtzVRiVK7QfhTh3AmjxrGAr7wdske8zaU+3RZszdRkRx8OF2nIFO2cN02wrbP5CLNHtAhAj28Nqb2djF8aOQfOVjtVOjNbjbXFXmURenQQCQ9zBat1U8yzCbC7spQKLrNBlfMSEgQb/vwuc40BVrEserLShhypTBKWw9p+Xx5vMg0/oV/UDkPFTC96rhXWfLUxLGpYQDLUbkXl+0lKQUyRUqyGjZjq3PZrm5fGiTvFp6bXVdH4tH5twtFNm+elHWywexofFPBxNjRVSIC79IwO2cJob1jE4vVZbdwSWkS66Om44Ea5VXG8Yvl9ngK22VJktsODFWIfhu8F1yC4jxfRufOl3nuaE0CtRy7rRNAx8k8cDNE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(396003)(39860400002)(376002)(5660300002)(31686004)(186003)(38100700002)(6506007)(36756003)(26005)(6512007)(53546011)(41300700001)(86362001)(66946007)(2616005)(31696002)(6486002)(8936002)(316002)(4326008)(66556008)(83380400001)(2906002)(6916009)(54906003)(8676002)(66476007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWtGT3R3d3R3MGRVbVFoTWpla0NQa2R0V0lGTSsxWXZkNHIxclp4TXNhMlVm?= =?utf-8?B?ZUp3eFNENkhDOUhBSkltcTZ0c2NJSXdKNXNabkRHaTduNFVwN2NrV3lGM0cr?= =?utf-8?B?LzBjV3loWldSLyt5UE14bnJqOHZyTzFWdW82QlNHQlFVb2U4SEtGWS9WRmdU?= =?utf-8?B?U2Z4ajZoM2hQR2x1Z05URUtORGk1RVBCbzJzUThXNGE1c0dlWC9DZGtpNTY5?= =?utf-8?B?NHpqbkdvMVIydmtuQ3RjRVhaNlJYQ2xPb3JOREs4SDlkRDgxWnlxWkl6d2VK?= =?utf-8?B?SmVsNnEvclBpaDd3N2JrM1Rsck1QdTRBSC9LdkJXR1YvbWxmcUxYUHNMYTFn?= =?utf-8?B?OXJYNTBUbG9yQWw4NlFtVXlUSDY3NFB0aXA0Nk9SL0VJb0tIbWJwQmtyV25P?= =?utf-8?B?Y0ZhMDNlYWgzdEZIekZDa2VTUkNJaTlQSVQ2Tkt4ZDBORXhwc0dYd3p2UUNm?= =?utf-8?B?MS9Da2ZZdHRvVFRRZzRxN2gwTWc2YllwNGRWMS84NkdkU00rZi8rZTI4TG1w?= =?utf-8?B?cTdMalIrQVBGUkxzSjMzWWw2RGM1MjFTc09zQ3RWbjYyUTcvall4TWxJd3FK?= =?utf-8?B?NmJlNnBPQmtPZjM5S0ZMU1BtcCtUSEMvaEFXQTdaeXROOC9RUjV3dTQwQTVl?= =?utf-8?B?Y1ZoOUNxV2Q3Z1AwbnduNlI4SFh4RDF2bFljaG1xWkNzZFUyMGlmOFZlWldk?= =?utf-8?B?MTVjN3p4SEU1bVNQMDRrT0lDN3pCeVd2Wks5VzBPc3pxODhwVVJwK0hGaFlT?= =?utf-8?B?Z3lnZklyM2djNmNsN2VjWWpBc3JJZmxkcWpUc0pNekptWFJYcW04UlY5WHRt?= =?utf-8?B?eHJVdTRnMzJqcFZiWEc0c0RwU0hwdXV5V3JDY216QnFyYnIwV2hMTGo0S25G?= =?utf-8?B?K0FMY1l1a3FpY3hkVGkxOTA2U3BGc2dnWGx5bzZnKzd1UU10bjhuZFhmSlEx?= =?utf-8?B?bUxGNW9CRmFsZDhFRGUzYmNuMXNZODNJSWRHc3VldEw4ODMxYkVJNzdwdmZS?= =?utf-8?B?Mjl5LzVrZGZTNERhWU5YWlptY1ZwRHY0ZWNUa0VnUFZlK3VTaUVRdThhTU1s?= =?utf-8?B?ZDVFVks5TVJ3VXZqTVkwc1VVNllsRWdmRk0yQ29yU0prcXZzNzZNbElYRkt3?= =?utf-8?B?ZndlZE9zMVRUYktDdy95VkJaQi92allFN2cxdGFCdXJvUzRIdnRIZnJvQ1Zr?= =?utf-8?B?czFoQWdoQWxKenV0SDZjK21TRThhNVhDQjVkN003SG52RTJiT3dOTmFVUGYz?= =?utf-8?B?VGFLKzBQVG4wb3JkUjNXUmMzRjQ4QXA0cHFZWUVBZ3VaN25TNXRTM1VXTEVy?= =?utf-8?B?WDZlWEpsMlVNcGdUR2lCeUhZTG1WLzJET2tFOWdyZUtrZzhnYlBjMkZWVFF3?= =?utf-8?B?azA5RE9JdmRZNzhjU3dpeFRKV1RRbEtXb0hyenpLUEl6bk93bXRZK2ZvOExZ?= =?utf-8?B?ZmViczJhbzljTEpXQlNDSFV1Mk5pQ0FncmxZNHpFcjJGckN2alQ5UnJvVCtU?= =?utf-8?B?Q3F5dlZJbVFaWmZGTHNNejZvbCthYzFPaWpSbXB6a2xGb3huQ3hwbmxxVDhO?= =?utf-8?B?c1MrNlUyUmNiSWtDbTE3ZWUxMnpMOWRGN1FsdnlUeW0rbThpckJTa3FMdGFZ?= =?utf-8?B?dERoazVvM3BMdEM0aUthbEdPcmw5MzVta1g2eW1ibEg4dysrS2Fmd3NZUGVJ?= =?utf-8?B?amVCdWtndm40aVE1ZWJhNVYvdHFMMHEyaXU5MmJYRVRPSUJEQmc4NjRTM0Yr?= =?utf-8?B?OW41clZGQzdVN3dhSVFEckJ1dUIvaTBtM20xY0xHYk9vQnBNdG04S0RiSFdz?= =?utf-8?B?NS95eXRyWjlPYnI2RlMwU25TakdIQkpHQURlODcrcllGYUR6ZS8yZTNtbHJF?= =?utf-8?B?aVJTaGt3Tlg5Tm8yTWMybzhqV2h5Y0djcTgrTG5xVSt3UXBwSEU2L1ZYMVpC?= =?utf-8?B?ZDVlbkt1YnFJcVlHeC9lY2xOSkt0VVhJZkZ0R1lyWHFsNUFrODEyU1NjeUcz?= =?utf-8?B?MUEvT3NrbC9IZVF0WmI3T0dyaVNqMmRHbEFCMXkvb3haN05BWFduR1lieUEy?= =?utf-8?B?M0xVcU9JV0tyWFEzeGpGYnYvZUg0bFU4K29odXMrUU1RSk8yTTAwNDVrRi81?= =?utf-8?Q?3vdONKVUyWriB1DJZokY68ZBV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f86e9651-cf7f-40a0-cd64-08da918f2725 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 11:42:05.1048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0SrW9CLQ46pE/mbsQGLdMDcOcRJa8dyuF3OvLamCFOI9AIKg9SYYwTB3mM27nOARH0+eH3FWc4Trg+kxxMp4iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7370 On 08.09.2022 12:32, Wei Chen wrote: > On 2022/9/8 17:09, Jan Beulich wrote: >> On 02.09.2022 05:31, Wei Chen wrote: >>> --- /dev/null >>> +++ b/xen/common/numa.c >>> @@ -0,0 +1,442 @@ >>> +/* >>> + * Generic VM initialization for NUMA setups. >>> + * Copyright 2002,2003 Andi Kleen, SuSE Labs. >>> + * Adapted for Xen: Ryan Harper >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +struct node_data __ro_after_init node_data[MAX_NUMNODES]; >>> + >>> +/* Mapping from pdx to node id */ >>> +unsigned int __ro_after_init memnode_shift; >>> +unsigned long __ro_after_init memnodemapsize; >>> +uint8_t *__ro_after_init memnodemap; >>> +static uint8_t __ro_after_init _memnodemap[64]; >> >> These last two want to use nodeid_t instead of uint8_t. Originally >> the latter used typeof(*memnodemap) for (I think - iirc it was me who >> made it that way) this reason: That way correcting memnodemap's type >> would have propagated without the need for further adjustments. >> > > Thanks for this info, should I need to restore it to use > "typeof(*memnodemap)" in next version ? That would be more in line with the original code, but it's not strictly necessary once nodeid_t if properly used for these variables. I'd leave it up to you as long as you switch to nodeid_t. >>> +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { >>> + [0 ... NR_CPUS-1] = NUMA_NO_NODE >>> +}; >>> + >>> +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; >>> + >>> +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; >>> + >>> +bool __read_mostly numa_off; >> >> The v3 review discussing this possibly becoming __ro_after_init didn't >> really finish (you didn't reply to my latest request there), but you >> also didn't change the attribute. Please clarify. >> > > I think I had answered your question by: > >> I think yes, it will be used in numa_disabled and numa_disabled will > >> be called in cpu_add." > > And you replied me with: > > In the original code I cannot spot such a path - can you please point > > out how exactly you see numa_disabled() reachable from cpu_add()? I'm > > clearly overlooking something ..." > > But there is a time difference here, your reply was sent after I sent > v3, maybe you didn't notice it Which suggests you might better have waited with sending v3 until the discussion had settled. > About the new question: > cpu_add will call srat_disabled, srat_disabled will access numa_off. > srat_disabled is a function without __init. But the request wasn't to make the variable __initdata. That would be wrong of course. Since srat_disabled() only reads numa_off, __ro_after_init does look usable to me. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:43:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:43:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403207.645258 (Exim 4.92) (envelope-from ) id 1oWFwE-0002Ed-CT; Thu, 08 Sep 2022 11:43:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403207.645258; Thu, 08 Sep 2022 11:43:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFwE-0002EW-7J; Thu, 08 Sep 2022 11:43:18 +0000 Received: by outflank-mailman (input) for mailman id 403207; Thu, 08 Sep 2022 11:43:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFwD-0002EM-Q3; Thu, 08 Sep 2022 11:43:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFwD-0006OB-O1; Thu, 08 Sep 2022 11:43:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWFwD-0006ox-3j; Thu, 08 Sep 2022 11:43:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWFwD-0006uS-3G; Thu, 08 Sep 2022 11:43:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mFYI00RRCjTmxsyH+ypJVMM4/Gvhpi25Gl/67k89+54=; b=WTqS/QXi7/PGHwKocLhFgTnify oajXOW8gET8R7CjKxUYfp0loPr/MRSPf5MbWPmEJKL8LtERUtqcXcKNLXiDGJtb7NrkCdvJ3tfCUz z0OXdv1bhlCpcy+bFH+4xs6KkfhFh3VsqsxD9IfUwynfwF22dl+AU+5GS/eZ/I+33uc0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173055: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-xl-arndale:debian-install:fail:heisenbug linux-linus:test-armhf-armhf-xl:debian-install:fail:heisenbug linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0066f1b0e27556381402db3ff31f85d2a2265858 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 08 Sep 2022 11:43:17 +0000 flight 173055 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173055/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 12 debian-install fail in 173046 pass in 173034 test-armhf-armhf-xl 12 debian-install fail in 173046 pass in 173055 test-armhf-armhf-xl-arndale 8 xen-boot fail pass in 173046 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173034 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173034 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0066f1b0e27556381402db3ff31f85d2a2265858 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 35 days Failing since 172152 2022-08-05 04:01:26 Z 34 days 78 attempts Testing same since 173034 2022-09-07 03:00:08 Z 1 days 3 attempts ------------------------------------------------------------ 1702 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175131 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:49:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:49:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403216.645269 (Exim 4.92) (envelope-from ) id 1oWG1y-00037G-Vo; Thu, 08 Sep 2022 11:49:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403216.645269; Thu, 08 Sep 2022 11:49:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG1y-000379-T6; Thu, 08 Sep 2022 11:49:14 +0000 Received: by outflank-mailman (input) for mailman id 403216; Thu, 08 Sep 2022 11:49:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG1x-000373-VY for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:49:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 419deead-2f6c-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:49:12 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A9DE14BF; Thu, 8 Sep 2022 04:49:18 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C0223F71A; Thu, 8 Sep 2022 04:49:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 419deead-2f6c-11ed-9760-273f2230c3a0 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v5 0/2] xen/pci: implement is_memory_hole for ARM Date: Thu, 8 Sep 2022 12:49:00 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 ++- xen/arch/arm/pci/pci-host-common.c | 58 ++++++++++++++++++++++++++++-- xen/arch/x86/include/asm/pci.h | 10 ++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 74 insertions(+), 7 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:49:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403222.645280 (Exim 4.92) (envelope-from ) id 1oWG2V-0003dc-7O; Thu, 08 Sep 2022 11:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403222.645280; Thu, 08 Sep 2022 11:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG2V-0003dV-4j; Thu, 08 Sep 2022 11:49:47 +0000 Received: by outflank-mailman (input) for mailman id 403222; Thu, 08 Sep 2022 11:49:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG2U-0003XP-5z for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:49:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54748d2a-2f6c-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 13:49:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57B4561CB8; Thu, 8 Sep 2022 11:49:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EF07C433C1; Thu, 8 Sep 2022 11:49:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54748d2a-2f6c-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662637782; bh=g4qAFqq0hkSEXU7h41NwOrSRebV9g97WbblautAhiGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CvlluBFgH6xIjm3hHG8D1G1s3TD1tETbo6RehWyIp5CurslvAK3zSZSQj2VMFgsb+ cZ+kO+ytLc0o6rN57jAmkto7PHUoxc4p3YCxH8sw4SBnPqzwtABiRu4Qa47mr4c7AZ SGNgc85z35csPsyuu3zfWjSsddZHWGnJWCqmdMDk= Date: Thu, 8 Sep 2022 13:50:04 +0200 From: Greg KH To: SeongJae Park Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Juergen Gross Subject: Re: [PATCH for-stable-5.10.y] xen-blkfront: Cache feature_persistent value before advertisement Message-ID: References: <20220906162414.105452-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220906162414.105452-1-sj@kernel.org> On Tue, Sep 06, 2022 at 04:24:14PM +0000, SeongJae Park wrote: > commit fe8f65b018effbf473f53af3538d0c1878b8b329 upstream. > > Xen blkfront advertises its support of the persistent grants feature > when it first setting up and when resuming in 'talk_to_blkback()'. > Then, blkback reads the advertised value when it connects with blkfront > and decides if it will use the persistent grants feature or not, and > advertises its decision to blkfront. Blkfront reads the blkback's > decision and it also makes the decision for the use of the feature. > > Commit 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter > when connect"), however, made the blkfront's read of the parameter for > disabling the advertisement, namely 'feature_persistent', to be done > when it negotiate, not when advertise. Therefore blkfront advertises > without reading the parameter. As the field for caching the parameter > value is zero-initialized, it always advertises as the feature is > disabled, so that the persistent grants feature becomes always disabled. > > This commit fixes the issue by making the blkfront does parmeter caching > just before the advertisement. > > Fixes: 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when connect") > Cc: # 5.10.x > Reported-by: Marek Marczykowski-Grecki > Signed-off-by: SeongJae Park > Tested-by: Marek Marczykowski-Grecki > Reviewed-by: Juergen Gross > Link: https://lore.kernel.org/r/20220831165824.94815-4-sj@kernel.org > Signed-off-by: Juergen Gross > --- > > This patch is a manual backport of the upstream commit on the 5.10.y > kernel. Please note that this patch can be applied on the latest 5.10.y > only after the preceding patch[1] is applied. > > [1] https://lore.kernel.org/stable/20220906132819.016040100@linuxfoundation.org/ Now queued up, thanks. greg k-h From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:49:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:49:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403224.645291 (Exim 4.92) (envelope-from ) id 1oWG2X-0003uG-EU; Thu, 08 Sep 2022 11:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403224.645291; Thu, 08 Sep 2022 11:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG2X-0003u5-BM; Thu, 08 Sep 2022 11:49:49 +0000 Received: by outflank-mailman (input) for mailman id 403224; Thu, 08 Sep 2022 11:49:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG2W-000373-3q for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:49:48 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 566b27ae-2f6c-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:49:47 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0336B14BF; Thu, 8 Sep 2022 04:49:53 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA3C53F71A; Thu, 8 Sep 2022 04:49:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 566b27ae-2f6c-11ed-9760-273f2230c3a0 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: [PATCH v5 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev Date: Thu, 8 Sep 2022 12:49:01 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Oleksandr Tyshchenko --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - no changes --- xen/arch/arm/include/asm/pci.h | 3 ++- xen/arch/arm/pci/pci-host-common.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 7c7449d64f..80a2431804 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -106,7 +106,8 @@ bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d, struct pci_host_bridge *bridge, uint64_t addr); struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus); -struct dt_device_node *pci_find_host_bridge_node(struct device *dev); +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev); int pci_get_host_bridge_segment(const struct dt_device_node *node, uint16_t *segment); diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index fd8c0f837a..89ef30028e 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -243,10 +243,10 @@ err_exit: /* * Get host bridge node given a device attached to it. */ -struct dt_device_node *pci_find_host_bridge_node(struct device *dev) +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev) { struct pci_host_bridge *bridge; - struct pci_dev *pdev = dev_to_pci(dev); bridge = pci_find_host_bridge(pdev->seg, pdev->bus); if ( unlikely(!bridge) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:58:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403241.645302 (Exim 4.92) (envelope-from ) id 1oWGAj-0005j4-Bq; Thu, 08 Sep 2022 11:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403241.645302; Thu, 08 Sep 2022 11:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGAj-0005ix-8f; Thu, 08 Sep 2022 11:58:17 +0000 Received: by outflank-mailman (input) for mailman id 403241; Thu, 08 Sep 2022 11:58:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGAi-0005ir-7W for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:58:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGAh-0006hE-Qk; Thu, 08 Sep 2022 11:58:15 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWGAh-0006hf-I9; Thu, 08 Sep 2022 11:58:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bIWR4MGEGU3W7iMF6SN72UneegUQ8SeV6assMQr+5Vo=; b=OsAVx1waasuvl3EKPwzZKOvud0 umRZOaWHGiTq95Bai89O6oa2KgZz9oeUviipPrykbgP3fJwOCLHJuyjMtO2CRkZB9c+9Lo6VCLme6 rBi5csC/zJ7tkXWlUsRK/oGYAQI+QJZSufzJy5cgBXluMX5/t4lzeP2MMSpSDCGOfnhM=; Message-ID: Date: Thu, 8 Sep 2022 12:58:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Content-Language: en-US To: Henry Wang , Michal Orzel , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220908093129.30124-1-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/09/2022 11:54, Henry Wang wrote: >> -----Original Message----- >> From: Michal Orzel >>> @@ -362,14 +362,13 @@ device-tree: >>> >>> / { >>> chosen { >>> + #address-cells = <0x1>; >>> + #size-cells = <0x1>; >>> + ... >>> domU1 { >>> compatible = "xen,domain"; >>> - #address-cells = <0x2>; >>> - #size-cells = <0x2>; >> Why did you remove this set if it relates to the childs of domU1 (e.g. kernel, >> ramdisk) and not to domU1 itself? > > Well, I think here the example is just how we setup the static memory, so we just > want to emphasize the related part. I agree users can add another #address-cells > and #size-cells for domU1 node for the parts that you mentioned, but that is > not reflected by the current example (I can't find anything related to kernel, > ramdisk, etc. in current example). I might get it wrong but having two #address-cells > and #size-cells in that case would be quite misleading from my understanding. I agree with that. As this is only a small part of the DT we want to focus on what is necessary for the current section. > So I decided to remove it. I would mention it in the commit message because the change seems unrelated otherwise. The same apply for replacing adding extra "====". But TBH, this change feels completely unrelated to this patch. So I think it is better to have a separate patch. [...] >>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c >>> index ec81a45de9..cd264793d5 100644 >>> --- a/xen/arch/arm/bootfdt.c >>> +++ b/xen/arch/arm/bootfdt.c >>> @@ -352,11 +352,6 @@ static int __init process_domain_node(const void >> *fdt, int node, >>> /* No "xen,static-mem" present. */ >>> return 0; >>> >>> - address_cells = device_tree_get_u32(fdt, node, >>> - "#xen,static-mem-address-cells", 0); >>> - size_cells = device_tree_get_u32(fdt, node, >>> - "#xen,static-mem-size-cells", 0); >>> - >>> return device_tree_get_meminfo(fdt, node, "xen,static-mem", >> address_cells, >>> size_cells, &bootinfo.reserved_mem, true); >>> } >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index b76a84e8f5..258d74699d 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -563,21 +563,9 @@ static int __init parse_static_mem_prop(const >> struct dt_device_node *node, >>> const struct dt_property *prop; >>> >>> prop = dt_find_property(node, "xen,static-mem", NULL); >>> - if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", >>> - addr_cells) ) >>> - { >>> - printk(XENLOG_ERR >>> - "failed to read \"#xen,static-mem-address-cells\".\n"); >>> - return -EINVAL; >>> - } >>> >>> - if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", >>> - size_cells) ) >>> - { >>> - printk(XENLOG_ERR >>> - "failed to read \"#xen,static-mem-size-cells\".\n"); >>> - return -EINVAL; >>> - } >>> + *addr_cells = dt_n_addr_cells(node); >>> + *size_cells = dt_n_size_cells(node); >> There is a type mismatch here as e.g. addr_cells is u32 and dt_n_addr_cells >> return type is int. >> But I don't think this can be harmful and also it's strange for me that >> dt_n_addr_cells >> is defined to return int given that it either returns 2 or be32_to_cpup, which >> means it should return u32. > > Yeah. I agree. I did a git blame here and found this function is introduced 9 > years ago in "dbd1243 xen/arm: Add helpers to use the device tree". So I think > probably it would be easier to ask the author for the following action directly :)) The code was imported from Linux where it seems to be more common to use "int" rather than "unsigned". > > @Julien, what do you think? Shall we modify the return type of these two > functions? I think it would be good to be consistent. However, there are other users of d_n_addr_cells() (some are expecting 'int'). So if you switch to a different type then this use will be consistent but not the others. I would only suggest to look at it if you have if you have copious time and fancy going down the rabbit hole :). As to which type to chose, we are phasing out use of uXX in new code. So this should be 'uint32_t'. I would also be fine to use 'unsigned int' for the outside interface. I don't have a strong opinion either way. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 11:59:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 11:59:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403250.645312 (Exim 4.92) (envelope-from ) id 1oWGBU-0006Y1-PN; Thu, 08 Sep 2022 11:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403250.645312; Thu, 08 Sep 2022 11:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGBU-0006Xu-Mf; Thu, 08 Sep 2022 11:59:04 +0000 Received: by outflank-mailman (input) for mailman id 403250; Thu, 08 Sep 2022 11:59:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWG3V-000373-JO for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 11:50:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7adaee4b-2f6c-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 13:50:48 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 301A114BF; Thu, 8 Sep 2022 04:50:54 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A3783F71A; Thu, 8 Sep 2022 04:50:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7adaee4b-2f6c-11ed-9760-273f2230c3a0 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Date: Thu, 8 Sep 2022 12:49:02 +0100 Message-Id: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memory_hole which will check if BAR is not overlapping with any memory region defined in the memory map. On ARM, pci_check_bar will go through the host bridge ranges and check if the BAR is in the range of defined ranges. Signed-off-by: Rahul Singh Acked-by: Jan Beulich # x86, common --- Changes in v5: - drop use of PFN_UP and PF_DOWN in case addresses are not aligned. - As we drop the PFN_UP and PFN_DOWN we need to use the mfn_to_maddr() to get the BAR address without page shift. - Add TODO comment for address alignment check for ranges. - Added Jan Acked-by for x86 and common code. Changes in v4: - check "s <= e" before callback - Add TODO comment for revisiting the function pci_check_bar() when ACPI PCI passthrough support is added. - Not Added the Jan Acked-by as patch is modified. Changes in v3: - fix minor comments --- xen/arch/arm/include/asm/pci.h | 2 ++ xen/arch/arm/pci/pci-host-common.c | 54 ++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/pci.h | 10 ++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 70 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 80a2431804..8cb46f6b71 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, int pci_host_bridge_mappings(struct domain *d); +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); + #else /*!CONFIG_HAS_PCI*/ struct arch_pci_dev { }; diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index 89ef30028e..d51cfdf352 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -24,6 +24,16 @@ #include +/* + * struct to hold pci device bar. + */ +struct pdev_bar_check +{ + unsigned long start; + unsigned long end; + bool is_valid; +}; + /* * List for all the pci host bridges. */ @@ -363,6 +373,50 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0; } +/* + * TODO: BAR addresses and Root Complex window addresses are not guaranteed + * to be page aligned. We should check for alignment but this is not the + * right place for alignment check. + */ +static int is_bar_valid(const struct dt_device_node *dev, + uint64_t addr, uint64_t len, void *data) +{ + struct pdev_bar_check *bar_data = data; + unsigned long s = bar_data->start; + unsigned long e = bar_data->end; + + if ( (s >= addr) && (e <= (addr + len - 1)) ) + bar_data->is_valid = true; + + return 0; +} + +/* TODO: Revisit this function when ACPI PCI passthrough support is added. */ +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) +{ + int ret; + const struct dt_device_node *dt_node; + unsigned long s = mfn_to_maddr(start); + unsigned long e = mfn_to_maddr(end); + struct pdev_bar_check bar_data = { + .start = s, + .end = e, + .is_valid = false + }; + + if ( s >= e ) + return false; + + dt_node = pci_find_host_bridge_node(pdev); + if ( !dt_node ) + return false; + + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); + if ( ret < 0 ) + return false; + + return bar_data.is_valid; +} /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h index c8e1a9ecdb..f4a58c8acf 100644 --- a/xen/arch/x86/include/asm/pci.h +++ b/xen/arch/x86/include/asm/pci.h @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) void arch_pci_init_pdev(struct pci_dev *pdev); +static inline bool pci_check_bar(const struct pci_dev *pdev, + mfn_t start, mfn_t end) +{ + /* + * Check if BAR is not overlapping with any memory region defined + * in the memory map. + */ + return is_memory_hole(start, end); +} + #endif /* __X86_PCI_H__ */ diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index cdaf5c247f..149f68bb6e 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) /* Unable to size, better leave memory decoding disabled. */ return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { /* * Return without enabling memory decoding if BAR position is not @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), PFN_DOWN(addr + size - 1)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:03:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:03:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403272.645324 (Exim 4.92) (envelope-from ) id 1oWGFk-0008Ir-PP; Thu, 08 Sep 2022 12:03:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403272.645324; Thu, 08 Sep 2022 12:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGFk-0008Ik-MU; Thu, 08 Sep 2022 12:03:28 +0000 Received: by outflank-mailman (input) for mailman id 403272; Thu, 08 Sep 2022 12:03:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGFj-0008Ie-3n for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 12:03:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e522c1f-2f6e-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 14:03:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3079.eurprd04.prod.outlook.com (2603:10a6:6:a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 8 Sep 2022 12:03:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 12:03:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e522c1f-2f6e-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IET+Yr8IXtBSmpo9TzcsnvHtcKdPcGkZ4PHKR1zwB8ZvbJf5Xx8gp1y99i0mgzJIDoZZv5cafBINH58AYKWXOVTxFu9ElZ/JZEAIrpcgg8hYC0suKd2A9+nLpYLyoPYnZ1m5HZA3UYQE6SUaM0EtdGbPyvZA132v2FUW6gJAwiHW+d6NRPYREgL6Eq/R5bI/9t2Twwacv96PbOqdrORbv3qOkmCBKccqWJkMfvm96Fp7JGmZgHgHS/8WNL516jcImHAo6bvItOBDf2zS1EmIpAUZ7Fl1AVcBlVxaeZCKSOJkWlzcmYIeIRneO9lFeHu8eXTYdCc4lz8B3t7hTXiJ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ls0tyWDGIiSaXCFVTZ2tvhL+UWOC5u+M/W4tE96CDQk=; b=irv1/f3RKQ8mJOCtdNHuarbWDfzqf2UaBrS6W58xAPSOcbVyOoB55/2932Yw2FOv81/swoFj4/25805XKIYUkUFTLQK7XyMkb9UZczVxeobgky+hs9b7zFSyfCf33VR3SzV8iyQEZJj75qghnLWwMc2pFnv4YFbXqDS4Ad6kHqi6BhF0xqXg+tDYSbLRk4EvNDnlWtBTNAM6xvm2Zv6JeoYDMBaPX6hQKZJICJyFd/VJSlHKWP1hcI8wMgZWiIq91N5BpLTtDD9au20U/3CJk5hlpNO1ycSwwUaHcfm+Vvpj6V7SXCxluw9g+NgV6g8VY7OMQ4sU2GNezYBRaUdA1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ls0tyWDGIiSaXCFVTZ2tvhL+UWOC5u+M/W4tE96CDQk=; b=01M5y8WxIDHU6WT7R9f/iRY1jaO5pBFnqO/YqpE6RapzrcqnWeKs4Sbj0uP9A6/12vG1Psan379k34m94E9Orw4R4Y8XsjBzcli/ApD7e/L/J+iDaAoolPQqQ9Lj2/HsJuUtJrWtHT6++5UFbRm7hFYYtmD5X8e/c9MepyhTYlzxE5otYfKKLntvTOj6CN7nhmu/XXGrO2bnQW/+lgvYva/Ni0+K5jqE2yNUTtoMEud1/INW4w7yeiomHDHiEGBycE3+hlKrVH1bEHi9OdnOb2T6xgdzC9YFnIGBYNw5X5hl0TnVUBJg0Q+uaeOrCwLaSsXW4EcxTPOco5KPsY5q4g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5db80611-c968-34c7-7181-41071636efca@suse.com> Date: Thu, 8 Sep 2022 14:03:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Rahul Singh , Bertrand Marquis Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB6PR04MB3079:EE_ X-MS-Office365-Filtering-Correlation-Id: f8c87f24-aa81-4f52-7fac-08da91921dee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OY19xLXoU/ex4hHzYCkDwXGlz21yvpHaGDumodrAi/8yKoWnJVhoKuhjd02XXmmxqcg5MBDTDNwkTfTMw8fNaXNrJLvbVLFODiQ32MBmYFXRVC5uxIGKEZEhSgAiPGRgsL0k5y4fldFNK+9yZK9MTyzRoScH1n4GFDRLeLg6BljKpbvYergjzYBbTSf/7p1kFStpOaTxLgF19t9OBTpw13Se2OBoZK3sbcuirXOaRTyMSGR+elUO/V5FP+gIUoWvIF2wOitrcQoaFiXAK70/fHUlhloC45ZUblfJOJGbFI9mgWDekBifFo93CKczdFga736Il+nr0Lbdb1P40ljmGHDqKLycuLy4lWO5hB3s9bp10ZHqjVdC3aVGbFxBkicPzpQUj1mVBUdeSRfRAt8Ffj+Cn7m1lgDr9Es19A5QL41B/gd5+ySJ/yUg2vlBh4vkNiIDGXHH/isdRsEleamg9K0yvj/hQw4iBfnTBmcmseFKUL9s7j5fCFLCMDAD1KyCM5m8Ahq3X9hVJMnDUkp635CflIe4NNk6UR+qBFZQnFNCv0/sWDvu7gIvduYk9WtBoUeXjkHXdWu3O4YFzDow4oHMutI5Hjv0WVrIvESwgVmP3JR7CKw3FpllJPobmtObYpfOxwAJh6M+ydNuQOXm3UhuccFSLmjok5V+eu8wDNLMNZm3iicqQPQQIgKr5+Ha3QIijfgk0UNe551SjxFFx5dvaGyq85GnSVJUWlImZM2M6OtJlBF1VqAKzvbcplBfu5ornHdKslqj8oMOogXX6p12esF+oKAvOQZ9e4ztB1s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(366004)(396003)(136003)(346002)(8676002)(66556008)(4326008)(83380400001)(66946007)(66476007)(41300700001)(54906003)(110136005)(316002)(31696002)(2616005)(186003)(86362001)(36756003)(31686004)(6512007)(26005)(7416002)(5660300002)(2906002)(53546011)(38100700002)(6486002)(6506007)(478600001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0ZYU05yMXZaNU1CN2o4VWVqeHdCVGd1aEdNdmMxNW13VFBlSEtJblAwVHpt?= =?utf-8?B?cXNndlV3L0RBbmRPYjFJcWZyQ0ZreVMwQjE1MXluVHVhL0N6bDFMTDJycWcy?= =?utf-8?B?WlZ6UDNNNm43aFNIT3dOMFY3NEoxeWhyRlJCaUErdnJMeHpIa2xBZUhSai9O?= =?utf-8?B?OXNlTVdTYlhBK1JRWXVHaFc3QVZSUmhsV215ZEROOWtnSlZUQWlvQXIyR1hX?= =?utf-8?B?SnFadjdCcnVKOFppVWhiell3aGhKWklzMitUaXJVY1ZWbk9CQ0NTVHBtNVNZ?= =?utf-8?B?SlVmRDRUT1Joa2JrMlRPOHRScVpiQ2xuWDU0aW15L1ZTdTJ4T3FHQWVkaEtq?= =?utf-8?B?cENUaTlFZEFSYTFwZlNoWDRxVUxkOEszeUU4ZjhGQlJZVkhSUGtJV1ZIbm50?= =?utf-8?B?MDM0d3RUazFZcmRIY1pmeDhWTW5qZGJlemYvdHZjZTdRemxRdm9aNmxIcHBM?= =?utf-8?B?T1VmNjJNT2pSNmFhMDZGS1dDOUdoc3hwUVJOTEFsQVl5bnAzd0dkTUJSTlNK?= =?utf-8?B?LzBBZGNrMnNwSzNjUE1rSmwra3d2UU1EWlh1R0ZzcTNHQWFOZlY1QWpYdTdr?= =?utf-8?B?M2tFemt2RmFjbFhXNlY4dnIrT0dlSWdpTXFZUFZ6anlXRGROQ3NjQmJINHVl?= =?utf-8?B?L0s5ZklmdTYxTktzZ2Fxek0zSTNyTGRubFQxMkVPcnRTNUpsYWtIY0x4Q2xI?= =?utf-8?B?dUF1eU9HTCtQTEhmK0FTSk9iWWc5SVQ2TG40N2srbVBJTVNROU1kYU90dUky?= =?utf-8?B?UWYzTzY2cm40VUJienY2MDkrZWlRdDBPWU45NWxNdzNYVnVrcytaOUxGWW1i?= =?utf-8?B?dFkrSkFjYm8rM1NZQWFEYUF0ZmFza2lDc2JpaVlRZzR6RGhGdVZhWmM0RFVI?= =?utf-8?B?bXg0dUxtMDlUTGkveWFpVXQ0aUU3MGw1UHFMMm1VZzA4U3M0Q1pCQVp6ZkpD?= =?utf-8?B?YmE2V2JYVG1HMVhwRVIzL21LRHhVbVRhQmFwaW0zNCttZVNIaDluOVBsY2dB?= =?utf-8?B?d0tBRW96S050WHFNWElLMkVFM1BJbnphblE3cGRvN3NISDhCYll5THlqczRW?= =?utf-8?B?Rk9SVk5jR1EyQjlRcGZTcFhXOFNxbWNOL1hGWnJmRHlmYlZZYWFIZG9CT05W?= =?utf-8?B?bjhCUG14ZHV4cGJ4cXMyYkZPVW5XbUhMQ3NMSWFlZnlvUEJiODJKdCt3cUo2?= =?utf-8?B?dkovR3hzMWpNN0JzL2cvQU5xQktSMVlyd1V3bXVtenlMVDJpMmQxd0prZ1ph?= =?utf-8?B?dGlCcUlNWitBNkNQbFNsOGM1Q1BUUENEZCtyblZ3RUtiQnJGYmdKVTBodXhF?= =?utf-8?B?VFJsaysvRmNhUFVjcS9pR2xPSEsrMGlxTUVVcWZaWHI4QURlUDhYa0YwWExX?= =?utf-8?B?bWhmQzNXc2tVaXZiUHlwTjQyWi9XMGVuTUtlc0hYNFp1bnVMYnY5YUYxTlls?= =?utf-8?B?OFR5ZzVjS2JERHpyZTJ0ZEs0VkZnbmVBaHdjYlNiZzBLbjFISitrODhpeWkx?= =?utf-8?B?SzI1MkVXaWk2b1BsbVBjTmZCTFJmbWd6ZWF0VHlPN2E3bTFpRndhZXlaYXU4?= =?utf-8?B?Rm1waUdxZysyZEpreXhmN2dGaEdWM0JSeVo5ZEZ1QXRBNEZ1SnBzcHVQYmNJ?= =?utf-8?B?dy8vdTBMVnY5d0p2cHhpa292SGRHNy8rY3RrS3AvK240cTdXVjB4aDhyNXhq?= =?utf-8?B?dTdoZWxvNDhtcURuVk8wR09FMWx0cklrNkw0N0xNeFVFWE81dkFoa21OaTAw?= =?utf-8?B?QmtmR0hScnpHVTN4UXJnK1gxZEJVaW5kek03cURzNHdBaUF2MEFWTm54SXpE?= =?utf-8?B?Ny9PcFVNelhJekx5aW9BK2VJV2VXWFVZaGRCcTk3QUFCUGExR041V1d5aGVa?= =?utf-8?B?WTFSRVk4WFRSOGVDczczekwvNWwvUjRFZ1RLWEEyMXpKdnNWVWVvQXZHLzlk?= =?utf-8?B?WVIzWm5HQStaaHN4b0FjZUhaUFMxbnVvRE92NldJQ1ZzbldSa1dKaXArNFN3?= =?utf-8?B?N2g3TDV2WkdabmswbVVkN3VyNlFwRnBBTDVnM3ZjUXVZdzF0emZHUEF0cVRa?= =?utf-8?B?dGx3S2pEWHVOam5GSnQvYUJnbU5ZK2FwUWVUZXhJTmx2eVNIQWZCQVZLd2Rm?= =?utf-8?Q?gi1W7bsPgf6HvMmimY6Xk5ADI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8c87f24-aa81-4f52-7fac-08da91921dee X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 12:03:18.1799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZVDljnHgyfWtPPqnQjqw0vt/O32o8q+vOEisHb9auJDWRTjoAiz+5w0tTvbDZ0IafisJcrQV+QglqQ5Hqp6MDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3079 On 08.09.2022 13:49, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh > Acked-by: Jan Beulich # x86, common FTAOD: I object to this tagging, and I did not provide the ack with such tags. Quoting docs/process/sending-patches.pandoc: "The `Acked-by:` tag can only be given by a **maintainer** of the modified code, and it only covers the code the maintainer is responsible for." The doc provides for tagging here, yes, but such should only be used for the unusual case of an ack restricted to less than what a person's maintainership covers. Otherwise we'd end up seeing overly many tagged acks. (Recall that tagged R-b is also expected to be the exception, not the common case.) Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:07:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:07:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403281.645338 (Exim 4.92) (envelope-from ) id 1oWGJp-0000Ux-AQ; Thu, 08 Sep 2022 12:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403281.645338; Thu, 08 Sep 2022 12:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGJp-0000Uq-7j; Thu, 08 Sep 2022 12:07:41 +0000 Received: by outflank-mailman (input) for mailman id 403281; Thu, 08 Sep 2022 12:07:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGJn-0000Uk-CT for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 12:07:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d4a13726-2f6e-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 14:07:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE54214BF; Thu, 8 Sep 2022 05:07:43 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 53A653F71A; Thu, 8 Sep 2022 05:07:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4a13726-2f6e-11ed-a31c-8f8a9ae3403f From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] docs/device-tree: Place the static-heap dt-binding in proper place Date: Thu, 8 Sep 2022 12:07:28 +0000 Message-Id: <20220908120728.8290-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 The static-heap dt-binding should be placed after the last feature, namely static-evtchn. Fixes: 4596329291f5 ("docs, xen/arm: Introduce static heap memory") Signed-off-by: Henry Wang --- docs/misc/arm/device-tree/booting.txt | 86 +++++++++++++-------------- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 5395a1077c..93bf6fe577 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -425,49 +425,6 @@ The static event channel node has the following properties: link-to-foreign-evtchn is a single phandle to a remote evtchn to which local-evtchn will be connected. -Static Heap Memory -================== - -The static heap memory refers to parts of RAM reserved in the beginning of -boot time for heap. The memory is reserved by configuration in the device -tree using physical address ranges. - -The static heap memory declared in the device tree defines the memory areas -that will be reserved to be used exclusively as heap. - -- For Arm32, since there are separated heaps, the static heap will be used -for both domheap and xenheap. The admin should make sure that the static -heap region should contain enough memory below 4GB to cater 32-bit DMA. - -- For Arm64, since there is a single heap, the defined static heap areas -shall always go to the heap allocator. - -The static heap memory is an optional feature and can be enabled by adding -below device tree property. - -- xen,static-heap - - Property under the top-level "chosen" node. It specifies the address - and size of Xen static heap memory. Number of address and size cells - for the "xen,static-heap" property is determined by the root node - "#address-cells" and "#size-cells". Note that at least a 64KB alignment - is required. - -Below is an example on how to specify the static heap in device tree: - - / { - #address-cells = <0x2>; - #size-cells = <0x2>; - ... - chosen { - xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; - ... - }; - }; - -RAM starting from the host physical address 0x30000000 of 1GB size will -be reserved as static heap. - Example ======= @@ -523,3 +480,46 @@ chosen { }; }; }; + +Static Heap Memory +================== + +The static heap memory refers to parts of RAM reserved in the beginning of +boot time for heap. The memory is reserved by configuration in the device +tree using physical address ranges. + +The static heap memory declared in the device tree defines the memory areas +that will be reserved to be used exclusively as heap. + +- For Arm32, since there are separated heaps, the static heap will be used +for both domheap and xenheap. The admin should make sure that the static +heap region should contain enough memory below 4GB to cater 32-bit DMA. + +- For Arm64, since there is a single heap, the defined static heap areas +shall always go to the heap allocator. + +The static heap memory is an optional feature and can be enabled by adding +below device tree property. + +- xen,static-heap + + Property under the top-level "chosen" node. It specifies the address + and size of Xen static heap memory. Number of address and size cells + for the "xen,static-heap" property is determined by the root node + "#address-cells" and "#size-cells". Note that at least a 64KB alignment + is required. + +Below is an example on how to specify the static heap in device tree: + + / { + #address-cells = <0x2>; + #size-cells = <0x2>; + ... + chosen { + xen,static-heap = <0x0 0x30000000 0x0 0x40000000>; + ... + }; + }; + +RAM starting from the host physical address 0x30000000 of 1GB size will +be reserved as static heap. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:14:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403289.645349 (Exim 4.92) (envelope-from ) id 1oWGQZ-00029k-18; Thu, 08 Sep 2022 12:14:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403289.645349; Thu, 08 Sep 2022 12:14:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGQY-00029d-Ud; Thu, 08 Sep 2022 12:14:38 +0000 Received: by outflank-mailman (input) for mailman id 403289; Thu, 08 Sep 2022 12:14:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGQX-00029X-NT for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 12:14:37 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140079.outbound.protection.outlook.com [40.107.14.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cdba628a-2f6f-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 14:14:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8005.eurprd04.prod.outlook.com (2603:10a6:20b:2ac::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Thu, 8 Sep 2022 12:14:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 12:14:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdba628a-2f6f-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nfBLSAvQ1E3cJqAIwS9w0vd0OD5vvMQZoXqHAHd7Lmf9KP0VVRZFO6oaVHMgTXMS4SQ340nHQb0+kk37wDnLedNu6EbKJBTWdWV5abIo0yv8K18TP6YzGSBxTxWBzq/QfTlwiSaNnBU1VI+mfLktypbHQ2r7BpBkH7b5AubZ907DZlN8UFe+NnIEstzO95GEsiIkv2GgsZ6BnDIV86bCkFAFX/QPRH7Hsd1nQHTzLAHwRt8d4cHLRfI35saaXxCgLc9dKdHWcTqY50lUZUtfLiq9H8p9IEBXhrBHv5RjfSKdvBqAVrwtgGEULTqCXXd82sLxB2Dpx5cndopWaCxnkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cm/G9Hs8NmUWA9WJ5vqk4aPFJh6yZoF9Af7brcooRcM=; b=Eq6Upoogm9iTR2/mgvsPnuRc16eBFhflJA8YGPxBc9HtXRwfQMpVgPIFqCD7nEba3daYJdlFZa+YEuoyR1rQvt30R4acD/o3FsH8BGsUJfZ0TVxHYC8gWPzKHNyTJRU6dwJuhkTVjCrSxJaK9S1gp1JEvISJ5KBtLl1wR0KPy3YQNp6IDOOabr9a3T8IAI53tyhPmKEMe85x+DLgu5L082jnsl0XOFKZpgZStmUihN/8SB1qtuRkodVreFnauE6KLmbkaARUsEQqw6cctVdXaNhHOuFAgPCSI7fSZpVwZ0LxlbSXnhO8p3Pqgj9cMYoQKAeWdPxhE6bQ8AybYDX+tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cm/G9Hs8NmUWA9WJ5vqk4aPFJh6yZoF9Af7brcooRcM=; b=T51robzxZ7twrhMfsUCwn8q5Yy2uCyD21guUQxmecxKI6ncGgNYOzf6kvnPOtduV3sxmdUmOAt5OkwmDyfQolMGEfS2YoqihU8nIWwNVX2g1YNpIVBC64wGWi1x8E8dJ9uVVsJIIHVyrfx1TjvyVQz2tRUbYqk75smgfMlUyZbwAIxL/Mdws9xBdqJc+qFrFKUGVIlf1m++ETpODv1euDis3uH69+XMaT5l10lanH3+KZKZaKd+wvsMWFI6JmdKt/sdkdV9f0WZ3JUPR+ORBvLPgdLAZ9bs2fCEplU0fDmYQHuc8cuL9i9h5suBM/b2/H40B7qWQ4HpjHRcu3J9U6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 8 Sep 2022 14:14:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-5-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220902033121.540328-5-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0065.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8005:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ec04983-db4f-4720-9d08-08da9193b092 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UVRC8mUVm4fQVmAW9UOx1EkNkiKfo2dEVdW8hPMKPjlKpzFH8sLzAkDJuCQurLU57rfpeyHgfT7o79darntkKccBPM1bMcUQbOHFBUfDDyUw+osk5CK2UsX9KTw2wtAXPK1nMX/1yMl8IBwYs0mXn5TmYJyBZNs7oKVI1QjuEfx88EJJdG9R1HBz3GgYKxA7pBFhifo6fidO39RzXJQ0G1SLQJoPsC5Rb9Yxr2cyaEyay735lznQJ+FlltATbBtdSptVYjSXzL9puszCdSchVlio2L0VylJdVqTb/BFD+dwpTelukk0sIjNv2kpLGpTIBj+C+l9DXwCzrfMuTHRfIrU1yX7UFAmhIWhWLxUcNjQHk97A61vnRuCizjjoSFJl8HXirpGOPhqER15YK6frBa7Ls+i3KyGzRp62yeANGLc+cHDK/nbVAxDQ7UOEcCbUBOkJLDA4xnrtftCfW5iRInae+dDKrdd3eIiZjZ/xLKMHy+afq6cNa7g97A2a5DG8gPPfLy1QCgm7HAIpgKGMdHULLir1lF6g8ZE4IrxPG0SG6tDvcdbn+wZjbGMunpr8IsaBsbZ/QGTWbLGN1cp6WE1ifuAnW1TyPFjfU+iQo0rotqDOVKA3T2X6VJpC4GwVKvfieS0O6yP75GBvNfSXNWMM6BGyTmQX0p5+jhjYcENLsjNlzsRZFrFcdgJYwVNJq+oui0HDKIrLVemfm8rocxTDKDmWE3r1muXJnRRxD0a03OQuEMSiQbTYEkIn1wtakUcrOWPbarxTBNr5IUVatyt7OkpYRrWmcB/lO1OTVJ8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(376002)(136003)(396003)(346002)(83380400001)(6506007)(478600001)(6486002)(31696002)(31686004)(4326008)(186003)(36756003)(86362001)(66946007)(66476007)(66556008)(2616005)(2906002)(5660300002)(8676002)(316002)(54906003)(6916009)(6666004)(41300700001)(26005)(53546011)(6512007)(8936002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUlJOXBEV2JZY3A3YVkvTC8xNXVuSGhJK2s2c0NFY1huYXRPZlE1K2VEZkdi?= =?utf-8?B?bUpxeHBZL2JqSHFUMWNkK2Q0K20vV0tiRm51VXNHaXpkREJVQnRCWkc0RGY4?= =?utf-8?B?K0lTQTZGWWlCK0c0bjdoQXYzUkRFKy9xZWh2eEQrbEJtYThnMStLVTBGNVQv?= =?utf-8?B?ZFIvby9KbUhZWjQ5Q3pRakZJazRmN2VBb3hVQ3BOTGVrSlRwajFYWE5MZTdr?= =?utf-8?B?UW9aWTFua3BpWDN6STNoM3hZRHkxaWZvbUQ5eVhZNXdLbzUxZGd4T3dRWU1G?= =?utf-8?B?U0RjSlg2Wnhzd1dFd2E1MWo4RGRneEV5Ynp2MithbkNyZ1QvcWhBeUVOd3Nx?= =?utf-8?B?VEhDeHR5eEJoYWNBZ0pSbFRiRVFVTjA0MVhSSEV1VnA4bDI0c1JXVnk5VkxB?= =?utf-8?B?VlJVU0FqNEhXTXVlbHF1eERGQVJDbFFsSU9jVWQrY09udmgydlFETnFJbmxx?= =?utf-8?B?SGxxK0k5RHVsMnJYajkvbENFVEpVOHhseXJTRFliQWJwM3dQTHdNMWhPUDJx?= =?utf-8?B?dzJvangvSmdLYlh5S2UzOGRpam5qRElZalJVOHhYNlZ1aTJZL0wyMFdqWG5Y?= =?utf-8?B?MWtMcUord1pTRTlTQVdsdW5UbmpvSUJBWXdHUzBPaDdwMktDYm1PcXFuWGlH?= =?utf-8?B?dlFOaDEvbWhZMlZwNnFkTkxjc1Z6SGIxbldCUndycUltbVE3bVFqU1J5bm9w?= =?utf-8?B?eGlQZ0MzVjZxbHRrT1FIWHlveFhkaE4xaytaOHNISlhqa1RSSXZ1Qzd5U0ZQ?= =?utf-8?B?RHBpNjBscDRHYTFBcmhDWFBuU3pOdkcwWnp0WThRYWFPRTZSK2pHOG1ZRjcw?= =?utf-8?B?akdmZVJLck5WSnUvN1FISTg3TTdxTXRESnBVb3AxT0NvMGorWEMwTHFtOE9z?= =?utf-8?B?NUNtcTlLRDM0UndkVkVQUVFzSUcwZSt1TTVLRFVtUEJJM0xYbDJNYWZ3dGJO?= =?utf-8?B?YkxiTEpZNk8wUFJvQ0hRTkozamdoOU82ak5nZ1AvSTFxWnJncWVJdWRZV2pW?= =?utf-8?B?L2srWHBXTDdSWkk3N1hIaXVpN0VXVkx4eXp1TGVwMnJPYkNoNlRHRUNTcXhR?= =?utf-8?B?Sm9ZNWNteDJhSWJaWkYzSW42OXJoYkxTMHNXZmtPNlI5Y3djdkVrWTUvV2NR?= =?utf-8?B?ZDUvZEJqTjFEcUp2UGVNVkZNTU9BN3VHeFhXZmNYQUs1SEtqTEZHRDc0amlY?= =?utf-8?B?dEJOZ1RxVUozMkwwS1lpT3NydjlFc0JpK2NsaWF6Zk03R2Z4REx4UXNOTncx?= =?utf-8?B?Y2RNZDF5dUFTRFRxYVlndGU2ODlvWDNJcktYeCtsZ3oxc0hlN0g3RnhzT1Fr?= =?utf-8?B?c0RLY2lNOGhycEhDd29uQUxaV204VDd1OTV4MUNJQVBFZXBiYnVnUDBpM3Bl?= =?utf-8?B?UzlwVTQzb2ZpeE5oREU1SnM4azhCbnVwR2xXeVJTUG8vYXlkK0ZzamNmQm9R?= =?utf-8?B?NUlDcWw5Qy9BbHRNanE2cks1NGt3NTVHd0lRUVlNVnVLMHovQUlKUGYxa1RY?= =?utf-8?B?SnBYUjNQM284NTRLYlhRR3V3RmZ5cXdYVm9IMGdwVUJjeEIvWHVmN0tVWjEw?= =?utf-8?B?RUdvUm9EZEl0a1N0WkZWaVo2K0Z3ZGk5Nnc4RUEva240a1l6ZmVFeW5JLzRr?= =?utf-8?B?NC84ME1zazdUbFBSd3JoZ1JQb0k1L2V5bmZMNHV2a2hZN29uc21tSDA0bEUz?= =?utf-8?B?V2FDY1NMMnlQRlR0aSsrcUcxMFE3aGJlcjgyK3lJL1EzMVZ4RFFrcHorcHor?= =?utf-8?B?L3U3eDdjUXhzclNTdGQ2MjMwNitBakpvUWZWSzM0UzYzT0hvMHhLdmM3OXp3?= =?utf-8?B?MHRFS1poS3U2QWo1SFhiaWlKVXFsbXFuQkJZbGY1UzhFQk9IeDhpbCtVQU4v?= =?utf-8?B?T2dxd1Z5MTRNaHpNdXBFYlFCQy9tZjJvT2pkT2NIQWc4SEhWVlljcTB2MmF4?= =?utf-8?B?UmxxNTZGenRGTkpHUmwweFE0QUR6SW8zTm5OblBHNUpkbVltQjU1VGdNYUFv?= =?utf-8?B?RjhPVm1YcGN5SGlIMHlpRWtYTTI2dUxlaW9VbnlIbVlISDMxN3YyV21ZTlFW?= =?utf-8?B?LzRJdWRUMzlmVVh4aW80WjNieFRsbnhSSVc5NmptS1B2RWxSQzJjTVJhdGsx?= =?utf-8?Q?GWpoA+Nn0hB4SKI6cbyxg92Ew?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ec04983-db4f-4720-9d08-08da9193b092 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 12:14:33.7152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7C/LuC/XrpUEkOe0iWz+EkxdV+BL/nDzh13C76ruWgV8ST5sFSoRWVgiStnoawcJEFKR0RgBAJzmOgqzZNk2BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8005 On 02.09.2022 05:31, Wei Chen wrote: > The sanity check of nodes_cover_memory is also a requirement of > other architectures that support NUMA. But now, the code of > nodes_cover_memory is tied to the x86 E820. In this case, we > introduce arch_get_ram_range to decouple architecture specific > memory map from this function. This means, other architectures > like Arm can also use it to check its node and memory coverage > from bootmem info. > > Depends arch_get_ram_range, we make nodes_cover_memory become > architecture independent. We also use neutral words to replace > SRAT and E820 in the print message of this function. This will > to make the massage seems more common. > > As arch_get_ram_range use unsigned int for index, we also adjust > the index in nodes_cover_memory from int to unsigned int. > > Signed-off-by: Wei Chen Reviewed-by: Jan Beulich albeit still with a couple of suggestions: > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -428,37 +428,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) > Make sure the PXMs cover all memory. */ > static int __init nodes_cover_memory(void) > { > - int i; > + unsigned int i; > > - for (i = 0; i < e820.nr_map; i++) { > - int j, found; > + for (i = 0; ; i++) { > + int err; > + unsigned int j; > + bool found; > paddr_t start, end; > > - if (e820.map[i].type != E820_RAM) { > - continue; > - } > + /* Try to loop memory map from index 0 to end to get RAM ranges. */ > + err = arch_get_ram_range(i, &start, &end); > > - start = e820.map[i].addr; > - end = e820.map[i].addr + e820.map[i].size; > + /* Reach the end of arch's memory map */ > + if (err == -ENOENT) > + break; Such a comment ahead of an if() is often better put as a question, e.g. "Reached the end of the memory map?" here or, if you dislike using a question, "Exit the loop at the end of the memory map". > + /* Index relate entry is not RAM, skip it. */ > + if (err) > + continue; And then perhaps "Skip non-RAM entries" here. > --- a/xen/include/xen/numa.h > +++ b/xen/include/xen/numa.h > @@ -81,6 +81,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) > #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ > NODE_DATA(nid)->node_spanned_pages) > > +/* > + * This function provides the ability for caller to get one RAM entry > + * from architectural memory map by index. > + * > + * This function will return zero if it can return a proper RAM entry. > + * otherwise it will return -ENOENT for out of scope index, or return > + * -ENODATA for non-RAM type memory entry. The way you've implemented things, -ENODATA isn't special anymore, so better wouldn't be called out as special here. May I suggest to at least insert "e.g." in front of it? (An alternative would be to check for -ENODATA in nodes_cover_memory() again, followed by ASSERT(!err).) > + * Note: the range is exclusive at the end, e.g. [start, end). Perhaps better [*start, *end) to match ... > + */ > +extern int arch_get_ram_range(unsigned int idx, > + paddr_t *start, paddr_t *end); ... this? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:20:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403296.645360 (Exim 4.92) (envelope-from ) id 1oWGWS-0003cA-Mn; Thu, 08 Sep 2022 12:20:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403296.645360; Thu, 08 Sep 2022 12:20:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGWS-0003c3-K1; Thu, 08 Sep 2022 12:20:44 +0000 Received: by outflank-mailman (input) for mailman id 403296; Thu, 08 Sep 2022 12:20:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGWR-0003bx-5x for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 12:20:43 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50066.outbound.protection.outlook.com [40.107.5.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a73c62f4-2f70-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 14:20:41 +0200 (CEST) Received: from AM6PR08CA0043.eurprd08.prod.outlook.com (2603:10a6:20b:c0::31) by GV1PR08MB8452.eurprd08.prod.outlook.com (2603:10a6:150:84::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 12:20:38 +0000 Received: from AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::49) by AM6PR08CA0043.outlook.office365.com (2603:10a6:20b:c0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Thu, 8 Sep 2022 12:20:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT014.mail.protection.outlook.com (100.127.140.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 12:20:37 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Thu, 08 Sep 2022 12:20:37 +0000 Received: from 145b6464d17b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A3A6A688-82DD-4032-B9E1-60FDE89D407A.1; Thu, 08 Sep 2022 12:20:28 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 145b6464d17b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 12:20:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBBPR08MB6009.eurprd08.prod.outlook.com (2603:10a6:10:1f5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 12:20:25 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 12:20:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a73c62f4-2f70-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UzltbDZB8d0WoEiBOKmR1YBgi13QCoVnXupJptqXgY/nFhHRDmQm52hSMOGQVoHWDbDDsOusGubaGVm4gJ2AAvObcMppIv8HpWtP9Jk9BYdoxhYv2Y688mFMniPyj4ZXuBxgw3ri0FJRBNxNuGZJ7C9gkjd5PG6901SgXpc7kdpSuYKJf+UoRx8jb0/kKw2treCowMYhF+cQGz+D4EtrU6+CvmQ0wSI8qyWQutcFROBCk3zCPZ4aNhwxmcSXYtmS+jXgn+HVNOGi0oOgwN7CSNy9LmCjO2Nt69Wb18pfoIlf9zP7ek0uY8+SGyfFs+O3N0IUH9eEI71Bs79mz8s8Fg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z82F4EPGqp02NKo0C0gyevuhSIkEumDNmZjeE1poCp4=; b=b5JVJtiM3zBUUudHLdW7zKX1p0ME8rrTeWaQ2ycQ0tukg6LMSqTOrkY+C04i8FQxWTUA83+0050qRPVV5l/R4cX86tJvhacgqPti5LbGl9JAwByHqc61Ppicgc4jNn28fl53hrfcjftu7YiII3sumqiLAM4asQDEX5WPLkJw+jD4xKVM5KqT0NfAsu/ahn8u79/q6S8o/wR84qVnWKozMo6rCkVCx0wWraooBPq65w0cBCoRT3tgiqXYVdr+C9IasOwJL3HusQFpw573ny0kVLvwLc82AbfFG4tKE6NtV1S4QWiD9TiufwKhzE3B/xY8qQdVjkJvokx0AF2estrJbQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z82F4EPGqp02NKo0C0gyevuhSIkEumDNmZjeE1poCp4=; b=fEjgOV8p6SYHn0rEht7JomtROlthdbHNIt5k9jilmGnApKXm6NIocvFf/c5R80ueBFQnXv2yVtRSItwJow1vPM76c3YP7viedWgIIipGwWwV0uJyi1lFD5zb/x/IUD9MTn7JTRWZpXt3UO9JD+9IUzjOrf+Um7QDGbkKgUVtZ/Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+IGR14JQzitljevu1t3SuTrksX/nORcoSInlSs6SZKgqG8pjhYZ60KmNtal99CEE9L7HpeVAUvqbLu3Vekkl8yzF85Blk1j5lHhYIRd/XcfLnrM/Xtilr8xsdmQlH5FxM7FQuL5uA3HJWjPVWPzfS7tzG3vgzz+2YSXodd61s1xQ1A/nw+kWF/4/Z8OzdGUGKdXf1SrA+o6qwKm+5Xts3yAE1k2jbxaNZN4ZqNKMlrfDRkMn2C4RwzvQGUyELlck/fg6TZ4JI89o9vfvU7WC7lii0MbaPI2UhJRmUVre20JQnwACRR4n/ty4Nvr3xhVn4wZtEwcTlHrwvKw0pQZCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z82F4EPGqp02NKo0C0gyevuhSIkEumDNmZjeE1poCp4=; b=abjpj2J911mcZjohJUXPl8wO/erVmgyJdtg1fLG1qdp7MbT31Jxk6fUpm9ZcVfJx2GlY+LzVmHOX4m7jPAfoYaP/HdXXVRM2RGaFlxAjgLCp1Jdo1XASqawrddn6gkxYModE2S3UqumE7yk1gbKZGJea9h6Dn3iz01uYY+ond5GCtxFJy87EADiWuP/zccAaGhWqguuos8A1dPpDe+giSoKKqeB5G3iYQqXL77fjvux/bcClVUFXQ6Au8XDReoKJ3l7oxz/x555iqjFoB2f/HEVuRfScTctEUHfz468NongRjgZ7h0uuNz9ZDLdGD78IRrO/IJ7IFzhNM3/iR+Oi2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z82F4EPGqp02NKo0C0gyevuhSIkEumDNmZjeE1poCp4=; b=fEjgOV8p6SYHn0rEht7JomtROlthdbHNIt5k9jilmGnApKXm6NIocvFf/c5R80ueBFQnXv2yVtRSItwJow1vPM76c3YP7viedWgIIipGwWwV0uJyi1lFD5zb/x/IUD9MTn7JTRWZpXt3UO9JD+9IUzjOrf+Um7QDGbkKgUVtZ/Y= From: Henry Wang To: Julien Grall , Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Thread-Topic: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells Thread-Index: AQHYw2XP4kTWxhuEi0Wfg39PE1aR463VV3SAgAAAWqCAABXxgIAABIfA Date: Thu, 8 Sep 2022 12:20:25 +0000 Message-ID: References: <20220908093129.30124-1-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 34903B92A021544883C03196C5978A3D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7641f162-af26-4e28-8bac-08da919489c4 x-ms-traffictypediagnostic: DBBPR08MB6009:EE_|AM7EUR03FT014:EE_|GV1PR08MB8452:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xUxkDh6SJ2RSry0nU/1LROgbwMt6L929kWnCmVvAO9WI2GhlbRn7JCn9Z28Tmz+iJSMiBxrdgRi/AbZMkdBItUlz6dciou0lKaqXLvqkbc5+AHZkd8a9Xq9+lbqjHSaXBqK4rP0OarH7eEuBhfoXHyNHzWQAT2z40aTF0H2HPicWBMr87ReXBsJgX5p9yKZJNDy/B/FIK1o6G/F1fRj4vFsr4oAvjtNkW6pBq33ly5TmCAkihL5WbgkQ78ONe3L5/Hh/jtCaHCiTEPrlOt+3ZV/WPGvleZ/FnDHNv4qu/tq+SbP4Ql8NbN2K7sMFptaAklSl9fzY/NIVYLYYqYh2cXVHuTExHpBznVPbo2ua/W3fnOLVb/kneS6MBPDH0Do0SkC+pkt2xcBXMIqqXWdQkthvHnpszxnkfuFEIf5apMl7PytHoUZfzFUOqy6836BUksSAOZNIvqCLwIMSxper3tnDpyrV43EzeVee7+pl3aBrCC2uYBe97xcWPoqCHeTa89mDMu+Hizlf9cWB3UkqeQuNaGnpFwq+HcjAK+ajqoRu/gwZl6LsNTLXTYJZoR361R23g6ccGYyq4hWOY0Tul4siikq205FvPYnn3wy/+ESTJyYj61TafgOkXCVbpSShk+OhKMrAUQlzY/4O2JF07mA3XMDVCmhfu5WPkno/4KtTfnqKA7tbWySjXiWIBZ3QHKKCiakGAiR02owwV9iBf+byN/hi581GJW7zf6ZKphKKDewhd12eHhbxErAjasy8friwkG/jX+3d7KfOvzOKUw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(8936002)(52536014)(5660300002)(186003)(2906002)(55016003)(86362001)(6506007)(26005)(7696005)(9686003)(33656002)(83380400001)(71200400001)(478600001)(41300700001)(38070700005)(4326008)(8676002)(66476007)(66556008)(66946007)(110136005)(66446008)(64756008)(54906003)(76116006)(316002)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6009 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bb51ddfe-5d8e-47d5-caf6-08da91948220 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MckpzKSjSTn+0gw3aHCOKQGKHfp9cmFKnVzTS7dTSOrftish1uwr3Hwr94uTRhvskMqkgy0pPwv2Mqs9hwECZ2fp1kGLLsehhbH+17fNSUYm6y5IX/ybIpy9/X2dJZ8IDdAH4G0JIWq+A9HBpv+7Jd12Kg1q/p3uGtA0ghfd8ps0MunSdCNJAboOfqGvVCA1OTJuS8yZg+ewieCi0Qe9Te4Y8AgBAV1CwP03nTtKMyPkUXmxqlDlXvzYN0vPnIA4lCJJ7AXNJIdBTjhXQWFdD5IcdaAgfXWwEkokO+iCDz08tmZ7DyoL1QPVkxIpFNMBl7XQzWvMIWrM0coxmx/Uopxtgx3qeeSQMR3TGzs+kTD9ki8gMa6aaCL17biV/Ayw7+hM6yFawZPhcmHSXExhDwM64ZL8sc4WrF0iH/6qHF81Hgi6QdF/wimwPe5B2OMeE3b20ckJIaAyIIWdmSRbTtP8DS6KklvZffx6z9iDix91eekukPJtWidtj7mJdRh6ckZh83bEsnDg7ymvxL9przgRixX2AM8fHf81v2b/wMIEWwFAyvRvCI7BtMtgMi6a93BS1YEDbg/PiC0TLz2gbM6uN1e0aJtwtMb5xOL6vdh6lMah/NRmVT/liFTUuze/6QtNVSKRbwvIy/ncfy4BQkJpOlYr+NQGtZVnTlCwYEUlh6jEvVPbafuHn2WAbimSPVLjnT7BUlFG4cjW5AhJT4GDUF2/AscHPQsMZUZYPlp2c2e5/jtsBSQHy/TTqoL8HRTVJzcuxHhwguIf2qq7xA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(376002)(346002)(36840700001)(40470700004)(46966006)(52536014)(5660300002)(356005)(2906002)(6506007)(82310400005)(9686003)(26005)(8676002)(41300700001)(81166007)(8936002)(54906003)(86362001)(110136005)(186003)(82740400003)(7696005)(70586007)(336012)(4326008)(478600001)(316002)(33656002)(107886003)(83380400001)(40460700003)(36860700001)(40480700001)(70206006)(55016003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 12:20:37.8112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7641f162-af26-4e28-8bac-08da919489c4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8452 SGkgSnVsaWVuIGFuZCBNaWNoYWwsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g RnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gPj4+ICAgICAgIC8gew0KPiA+ Pj4gICAgICAgICAgIGNob3NlbiB7DQo+ID4+PiArICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMg PSA8MHgxPjsNCj4gPj4+ICsgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwweDE+Ow0KPiA+Pj4g KyAgICAgICAgICAgIC4uLg0KPiA+Pj4gICAgICAgICAgICAgICBkb21VMSB7DQo+ID4+PiAgICAg ICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInhlbixkb21haW4iOw0KPiA+Pj4gLSAgICAgICAg ICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwweDI+Ow0KPiA+Pj4gLSAgICAgICAgICAgICAgICAj c2l6ZS1jZWxscyA9IDwweDI+Ow0KPiA+PiBXaHkgZGlkIHlvdSByZW1vdmUgdGhpcyBzZXQgaWYg aXQgcmVsYXRlcyB0byB0aGUgY2hpbGRzIG9mIGRvbVUxIChlLmcuDQo+IGtlcm5lbCwNCj4gPj4g cmFtZGlzaykgYW5kIG5vdCB0byBkb21VMSBpdHNlbGY/DQo+ID4NCj4gPiBXZWxsLCBJIHRoaW5r IGhlcmUgdGhlIGV4YW1wbGUgaXMganVzdCBob3cgd2Ugc2V0dXAgdGhlIHN0YXRpYyBtZW1vcnks IHNvDQo+IHdlIGp1c3QNCj4gPiB3YW50IHRvIGVtcGhhc2l6ZSB0aGUgcmVsYXRlZCBwYXJ0LiBJ IGFncmVlIHVzZXJzIGNhbiBhZGQgYW5vdGhlcg0KPiAjYWRkcmVzcy1jZWxscw0KPiA+IGFuZCAj c2l6ZS1jZWxscyBmb3IgZG9tVTEgbm9kZSBmb3IgdGhlIHBhcnRzIHRoYXQgeW91IG1lbnRpb25l ZCwgYnV0IHRoYXQNCj4gaXMNCj4gPiBub3QgcmVmbGVjdGVkIGJ5IHRoZSBjdXJyZW50IGV4YW1w bGUgKEkgY2FuJ3QgZmluZCBhbnl0aGluZyByZWxhdGVkIHRvIGtlcm5lbCwNCj4gPiByYW1kaXNr LCBldGMuIGluIGN1cnJlbnQgZXhhbXBsZSkuIEkgbWlnaHQgZ2V0IGl0IHdyb25nIGJ1dCBoYXZp bmcgdHdvDQo+ICNhZGRyZXNzLWNlbGxzDQo+ID4gYW5kICNzaXplLWNlbGxzIGluIHRoYXQgY2Fz ZSB3b3VsZCBiZSBxdWl0ZSBtaXNsZWFkaW5nIGZyb20gbXkNCj4gdW5kZXJzdGFuZGluZy4NCj4g DQo+IEkgYWdyZWUgd2l0aCB0aGF0LiBBcyB0aGlzIGlzIG9ubHkgYSBzbWFsbCBwYXJ0IG9mIHRo ZSBEVCB3ZSB3YW50IHRvDQo+IGZvY3VzIG9uIHdoYXQgaXMgbmVjZXNzYXJ5IGZvciB0aGUgY3Vy cmVudCBzZWN0aW9uLg0KPiANCj4gPiBTbyBJIGRlY2lkZWQgdG8gcmVtb3ZlIGl0Lg0KPiANCj4g SSB3b3VsZCBtZW50aW9uIGl0IGluIHRoZSBjb21taXQgbWVzc2FnZSBiZWNhdXNlIHRoZSBjaGFu Z2Ugc2VlbXMNCj4gdW5yZWxhdGVkIG90aGVyd2lzZS4NCg0KU3VyZS4NCg0KPiANCj4gVGhlIHNh bWUgYXBwbHkgZm9yIHJlcGxhY2luZyBhZGRpbmcgZXh0cmEgIj09PT0iLiBCdXQgVEJILCB0aGlz IGNoYW5nZQ0KPiBmZWVscyBjb21wbGV0ZWx5IHVucmVsYXRlZCB0byB0aGlzIHBhdGNoLiBTbyBJ IHRoaW5rIGl0IGlzIGJldHRlciB0bw0KPiBoYXZlIGEgc2VwYXJhdGUgcGF0Y2guDQoNCkkgd291 bGQgcmV2ZXJ0IHRoaXMgY2hhbmdlIGZvciAiPT09PSIsIGFzIHNlbmRpbmcgYSBwYXRjaCBhZGRp bmcNCiI9PT09IiBzZWVtcyB0byBub3QgbWFrZSB0b28gbXVjaCBzZW5zZS4uLi4uDQoNCj4gDQo+ IFsuLi5dDQo+IA0KPiA+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9ib290ZmR0LmMgYi94 ZW4vYXJjaC9hcm0vYm9vdGZkdC5jDQo+ID4+PiBpbmRleCBlYzgxYTQ1ZGU5Li5jZDI2NDc5M2Q1 IDEwMDY0NA0KPiA+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYw0KPiA+Pj4gKysrIGIv eGVuL2FyY2gvYXJtL2Jvb3RmZHQuYw0KPiA+Pj4gQEAgLTM1MiwxMSArMzUyLDYgQEAgc3RhdGlj IGludCBfX2luaXQgcHJvY2Vzc19kb21haW5fbm9kZShjb25zdA0KPiB2b2lkDQo+ID4+ICpmZHQs IGludCBub2RlLA0KPiA+Pj4gICAgICAgICAgIC8qIE5vICJ4ZW4sc3RhdGljLW1lbSIgcHJlc2Vu dC4gKi8NCj4gPj4+ICAgICAgICAgICByZXR1cm4gMDsNCj4gPj4+DQo+ID4+PiAtICAgIGFkZHJl c3NfY2VsbHMgPSBkZXZpY2VfdHJlZV9nZXRfdTMyKGZkdCwgbm9kZSwNCj4gPj4+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiN4ZW4sc3RhdGljLW1lbS1hZGRyZXNz LWNlbGxzIiwgMCk7DQo+ID4+PiAtICAgIHNpemVfY2VsbHMgPSBkZXZpY2VfdHJlZV9nZXRfdTMy KGZkdCwgbm9kZSwNCj4gPj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IiN4ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzIiwgMCk7DQo+ID4+PiAtDQo+ID4+PiAgICAgICBy ZXR1cm4gZGV2aWNlX3RyZWVfZ2V0X21lbWluZm8oZmR0LCBub2RlLCAieGVuLHN0YXRpYy1tZW0i LA0KPiA+PiBhZGRyZXNzX2NlbGxzLA0KPiA+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHNpemVfY2VsbHMsICZib290aW5mby5yZXNlcnZlZF9tZW0sIHRydWUpOw0KPiA+ Pj4gICB9DQo+ID4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ IGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+PiBpbmRleCBiNzZhODRlOGY1Li4y NThkNzQ2OTlkIDEwMDY0NA0KPiA+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5j DQo+ID4+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPj4+IEBAIC01NjMs MjEgKzU2Myw5IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX3N0YXRpY19tZW1fcHJvcChjb25z dA0KPiA+PiBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5vZGUsDQo+ID4+PiAgICAgICBjb25zdCBz dHJ1Y3QgZHRfcHJvcGVydHkgKnByb3A7DQo+ID4+Pg0KPiA+Pj4gICAgICAgcHJvcCA9IGR0X2Zp bmRfcHJvcGVydHkobm9kZSwgInhlbixzdGF0aWMtbWVtIiwgTlVMTCk7DQo+ID4+PiAtICAgIGlm ICggIWR0X3Byb3BlcnR5X3JlYWRfdTMyKG5vZGUsICIjeGVuLHN0YXRpYy1tZW0tYWRkcmVzcy1j ZWxscyIsDQo+ID4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFkZHJfY2VsbHMp ICkNCj4gPj4+IC0gICAgew0KPiA+Pj4gLSAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gPj4+ IC0gICAgICAgICAgICAgICAiZmFpbGVkIHRvIHJlYWQgXCIjeGVuLHN0YXRpYy1tZW0tYWRkcmVz cy1jZWxsc1wiLlxuIik7DQo+ID4+PiAtICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPj4+IC0g ICAgfQ0KPiA+Pj4NCj4gPj4+IC0gICAgaWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIobm9kZSwg IiN4ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzIiwNCj4gPj4+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc2l6ZV9jZWxscykgKQ0KPiA+Pj4gLSAgICB7DQo+ID4+PiAtICAgICAgICBw cmludGsoWEVOTE9HX0VSUg0KPiA+Pj4gLSAgICAgICAgICAgICAgICJmYWlsZWQgdG8gcmVhZCBc IiN4ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzXCIuXG4iKTsNCj4gPj4+IC0gICAgICAgIHJldHVy biAtRUlOVkFMOw0KPiA+Pj4gLSAgICB9DQo+ID4+PiArICAgICphZGRyX2NlbGxzID0gZHRfbl9h ZGRyX2NlbGxzKG5vZGUpOw0KPiA+Pj4gKyAgICAqc2l6ZV9jZWxscyA9IGR0X25fc2l6ZV9jZWxs cyhub2RlKTsNCj4gPj4gVGhlcmUgaXMgYSB0eXBlIG1pc21hdGNoIGhlcmUgYXMgZS5nLiBhZGRy X2NlbGxzIGlzIHUzMiBhbmQNCj4gZHRfbl9hZGRyX2NlbGxzDQo+ID4+IHJldHVybiB0eXBlIGlz IGludC4NCj4gPj4gQnV0IEkgZG9uJ3QgdGhpbmsgdGhpcyBjYW4gYmUgaGFybWZ1bCBhbmQgYWxz byBpdCdzIHN0cmFuZ2UgZm9yIG1lIHRoYXQNCj4gPj4gZHRfbl9hZGRyX2NlbGxzDQo+ID4+IGlz IGRlZmluZWQgdG8gcmV0dXJuIGludCBnaXZlbiB0aGF0IGl0IGVpdGhlciByZXR1cm5zIDIgb3Ig YmUzMl90b19jcHVwLA0KPiB3aGljaA0KPiA+PiBtZWFucyBpdCBzaG91bGQgcmV0dXJuIHUzMi4N Cj4gPg0KPiA+IFllYWguIEkgYWdyZWUuIEkgZGlkIGEgZ2l0IGJsYW1lIGhlcmUgYW5kIGZvdW5k IHRoaXMgZnVuY3Rpb24gaXMgaW50cm9kdWNlZCA5DQo+ID4geWVhcnMgYWdvIGluICJkYmQxMjQz IHhlbi9hcm06IEFkZCBoZWxwZXJzIHRvIHVzZSB0aGUgZGV2aWNlIHRyZWUiLiBTbyBJDQo+IHRo aW5rDQo+ID4gcHJvYmFibHkgaXQgd291bGQgYmUgZWFzaWVyIHRvIGFzayB0aGUgYXV0aG9yIGZv ciB0aGUgZm9sbG93aW5nIGFjdGlvbg0KPiBkaXJlY3RseSA6KSkNCj4gDQo+IFRoZSBjb2RlIHdh cyBpbXBvcnRlZCBmcm9tIExpbnV4IHdoZXJlIGl0IHNlZW1zIHRvIGJlIG1vcmUgY29tbW9uIHRv DQo+IHVzZQ0KPiAiaW50IiByYXRoZXIgdGhhbiAidW5zaWduZWQiLg0KPiANCj4gPg0KPiA+IEBK dWxpZW4sIHdoYXQgZG8geW91IHRoaW5rPyBTaGFsbCB3ZSBtb2RpZnkgdGhlIHJldHVybiB0eXBl IG9mIHRoZXNlIHR3bw0KPiA+IGZ1bmN0aW9ucz8NCj4gDQo+IEkgdGhpbmsgaXQgd291bGQgYmUg Z29vZCB0byBiZSBjb25zaXN0ZW50LiBIb3dldmVyLCB0aGVyZSBhcmUgb3RoZXINCj4gdXNlcnMg b2YgZF9uX2FkZHJfY2VsbHMoKSAoc29tZSBhcmUgZXhwZWN0aW5nICdpbnQnKS4gU28gaWYgeW91 IHN3aXRjaA0KPiB0byBhIGRpZmZlcmVudCB0eXBlIHRoZW4gdGhpcyB1c2Ugd2lsbCBiZSBjb25z aXN0ZW50IGJ1dCBub3QgdGhlIG90aGVycy4NCj4gDQo+IEkgd291bGQgb25seSBzdWdnZXN0IHRv IGxvb2sgYXQgaXQgaWYgeW91IGhhdmUgaWYgeW91IGhhdmUgY29waW91cyB0aW1lDQo+IGFuZCBm YW5jeSBnb2luZyBkb3duIHRoZSByYWJiaXQgaG9sZSA6KS4NCj4gDQo+IEFzIHRvIHdoaWNoIHR5 cGUgdG8gY2hvc2UsIHdlIGFyZSBwaGFzaW5nIG91dCB1c2Ugb2YgdVhYIGluIG5ldyBjb2RlLiBT bw0KPiB0aGlzIHNob3VsZCBiZSAndWludDMyX3QnLiBJIHdvdWxkIGFsc28gYmUgZmluZSB0byB1 c2UgJ3Vuc2lnbmVkIGludCcNCj4gZm9yIHRoZSBvdXRzaWRlIGludGVyZmFjZS4NCj4gDQo+IEkg ZG9uJ3QgaGF2ZSBhIHN0cm9uZyBvcGluaW9uIGVpdGhlciB3YXkuDQoNCkkgcGVyc29uYWxseSB3 b3VsZCBsaWtlIHRvIGtlZXAgdGhlIGN1cnJlbnQgd2F5LCBjaGFuZ2luZyB0aGUgdHlwZSB0byBt ZQ0Kc291bmRzIGxpa2Ugb3V0IG9mIHNjb3BlIHdpdGggdGhpcyBwYXRjaCBhbmQgd2lsbCBicmlu ZyB1cyB0aGUgcmlzayBvZiBicmVha2luZw0Kb3RoZXIgcGxhY2VzLg0KDQpTbyBJIHdpbGwgYWRk cmVzcyB0aGUgY29tbWl0IG1lc3NhZ2UgYW5kICI9PT09IiBjaGFuZ2VzIGFuZCBzZW5kIGEgdjIu DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4g SnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:31:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:31:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403306.645371 (Exim 4.92) (envelope-from ) id 1oWGgp-0005X6-Pq; Thu, 08 Sep 2022 12:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403306.645371; Thu, 08 Sep 2022 12:31:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGgp-0005Wz-N8; Thu, 08 Sep 2022 12:31:27 +0000 Received: by outflank-mailman (input) for mailman id 403306; Thu, 08 Sep 2022 12:31:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGgo-0005Ws-E0 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 12:31:26 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26e89eee-2f72-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 14:31:25 +0200 (CEST) Received: from AM6PR01CA0038.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::15) by DU0PR08MB7993.eurprd08.prod.outlook.com (2603:10a6:10:3e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 12:31:15 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::5d) by AM6PR01CA0038.outlook.office365.com (2603:10a6:20b:e0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Thu, 8 Sep 2022 12:31:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 12:31:14 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 08 Sep 2022 12:31:14 +0000 Received: from eb930b282432.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F0FE29E-AC6F-43C3-8147-353CBFC3EE16.1; Thu, 08 Sep 2022 12:31:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb930b282432.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 12:31:02 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DU0PR08MB8277.eurprd08.prod.outlook.com (2603:10a6:10:40f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Thu, 8 Sep 2022 12:31:00 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::89c6:c8ca:3340:ca53]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::89c6:c8ca:3340:ca53%5]) with mapi id 15.20.5612.016; Thu, 8 Sep 2022 12:31:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26e89eee-2f72-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=N093/A0HRDQ5tFpDHB/y8u/1zPyGom06yea45BteORrt0tO1FwVxi/nycoEgyUJ8+G62rT1wwlQDvllwyXI9FV006RTkHKucC8VqaK1I+8KaJqsrhjPEuEU8ZQFK303C3yas/IZi0qN8Ji/6AMZRYKnPqM4wbRqiOHTiGK4zd53TYLNJ4UOeZzYlL/VPKJQzNwGO9e9+SY6ylU85FDvRBVu0WZAlDisaBsrekfc1hCA4pnBDjNKsIWX5TfQfbNCjnmhMqd/TFfIZYoATsN5rOr/kmiR4ZesGBSafWw462V3QH28tI2KBoLalgANb/exooJ0CpwJqeiVuD5rUTFuiEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Owx4enNlxYj4A+G5gejC0zzYLiB7DggolNr7gKWjFk=; b=jYZrTGRblzYl0jHfpE//dFko6zkmAb6O5ZTpy+G/ke0EhXRAmH8F8ETmNxGPDH2oUg8OtxG4tfU/NRk1EuO46UqQtlDzrx3zkLYkrtyOeFuySPuNhmevrfoRnAi6BNxCI3woR9LGD/b9Ni/4smoE4XXz1RwBXjIgIf9wIwqPcTZ0i+QjoLaRkOhLI5tzQ0VwTiT9tieIdQVaMXxsJmwouJtUhpdf1To2Wz7dCKeji5AuqkgwVYicTjzgNW93vp0ofx0nTARBUUq+OovxYqNr1RkLb14rfFs3ANcSIix5L1j63qI4Ckm3y5xOqDetPTpNs+Rn8/k1XobPHFZeWy8LJA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Owx4enNlxYj4A+G5gejC0zzYLiB7DggolNr7gKWjFk=; b=FBgyYzoSN+pNSudTw2SbmD8j2b/2s3kd9gjZ24GHgUEJ7MU1DUEn5fGOVgL211eFA/zvl5XuRE44yORviSSqgUZSXRyB7NAhS4jf80xViLIBwHYBLzFzH2EravJhdNaBbVDwlIepSb9xpsbM1ONR2AL/qxlsY8UFaaFc/aR/bm8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 088c1e1a15196bcf X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IfAoX59IHOhN6AO+RmQvb/EthpGOugoiPnHrciot7hA/86xYI3LHDhgG7AAo7dee2SRGQKnudaJZrrWDx9mHLKDdepkfk74TEFecAK3bj1ITrIG8d2YiDNmTJAQhz7fxjs05zK/HC3COHKn4+djmDeQtdIUgTnr+uWEu76nmQU51+75Kv2fDs4gT5anRoNdIC9T1AR+NfOjSka+i5RvMgdNpO5eQYfMRli8B/zZIk9Vdxa4ilyrcMj9yADKxm9gWSU9vWALyYg8ZIiXb6fWoDXX+eH0kAhrNyXERkXBcB/WJSYgyP5EjRzC4CX7oVs+xwhd6SV4A3IOx0uEKEMIWSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Owx4enNlxYj4A+G5gejC0zzYLiB7DggolNr7gKWjFk=; b=JD77nypOy4m+/GZ1YUa30l+f44fdk24NuNmD7WT3JKwak7zu88T9s8f0y9uyIhhP0mnwzvKcl8e3Hl/82cx9XiKXJa9+7bW5ORY7Jn3EMDa+BAeuaLKf4ez14fBMmFzODt6ytb5xPDYDMl/5fWVc5eMTRhQZJmvLxantCAcGbgrOwcmvFNHtlnSByHWnolrjELX6yskFFtFOD2o8G76blBWYIwH0InSuda8dVCyDLGIc+eu30UJNiM/6dm3EPtejg81SaK2Kx/sunCg/6KKUQ4zrB2vTUBEAPQjxZ3urlvvQYryD/LGAjxx04/cQvqPxUKoW6NVhfp0O9VMW9s5Dbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Owx4enNlxYj4A+G5gejC0zzYLiB7DggolNr7gKWjFk=; b=FBgyYzoSN+pNSudTw2SbmD8j2b/2s3kd9gjZ24GHgUEJ7MU1DUEn5fGOVgL211eFA/zvl5XuRE44yORviSSqgUZSXRyB7NAhS4jf80xViLIBwHYBLzFzH2EravJhdNaBbVDwlIepSb9xpsbM1ONR2AL/qxlsY8UFaaFc/aR/bm8= From: Rahul Singh To: Jan Beulich CC: Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYw3p7gwIvcD2fwEqa0fZdexa62K3Vbv8AgAAHwAA= Date: Thu, 8 Sep 2022 12:31:00 +0000 Message-ID: <03EABD2D-9FB5-4E91-BB65-7E5B5384F232@arm.com> References: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> <5db80611-c968-34c7-7181-41071636efca@suse.com> In-Reply-To: <5db80611-c968-34c7-7181-41071636efca@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|DU0PR08MB8277:EE_|VE1EUR03FT039:EE_|DU0PR08MB7993:EE_ X-MS-Office365-Filtering-Correlation-Id: d9e95a1c-daab-4411-9300-08da9196054d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Klz0dPa09EzgY/rx+dbp1qScx+QfOt/T4D/YgjmsgzQOm/dTjNc97Bbgw0Bc/bldseruRP4MEAycBcmnFfME8bm4ehQ+akuYxBPLUEV+t6HsLrR4ctzjwVD31cTYQzuN5oNWv6mRCMInX3zMDpDXezYm552BHQ/H6mn9jjb8bhTfBDn3HKMy/3TRA4tJHjcBhXnuMkGQ53pPBAh7dZZLstMOucYfaVtjifHcOZjzk/tKi3c0Nq5hb9q9oyONhW+31aLfmhqCQ1WNa4sC8LbOLuWlGlnJwLZec4O71o6LdD1bXhnitBpnqIOTmJqCStrYLJEfrCJh+5wc0DrkPF9+Ptr9nTEHB5I+BI7Tj1Z7IaOQoa/Qnr3s28jT/hiQkiMUG+p0bXhstC4hKkBQUEc+9xRtsaHKAUDK1ASd/HAZNWqC6QQcubzXlGq35uY7bcDvprWXdTX6lImpHpqcoP6Q6Db7U55Yfdz35OKb9VG9Ov+qokNZmqffhMMkwSs3PSx9r6huSImVH3D0Kxu1kjgUBShNdRlths8bkXSqeltzXO1VtqwmB3OXfAEQM67IFvuqeOMibgM91sC0Yy+AtOkAk+ZDilA1j7CKn0tewXwtcuLKM3ltrNA/19N5plx+24JETVDjzWJq8piGW6/efP+t048+6ypWN1TqNNRAGL94ls7/bLgsIKPtmDrjXLiH2B4zhNGbxLoG/NJzP3VlexBSYhWVdI7jVWuRwQ2gYjmc8EEq2ik8WXocdgRWoQrh9FiF+xp2LcdiWC9g5+XKg3FXn03xBvPkGvWLKXDU3bXhq48= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(36756003)(86362001)(6916009)(38100700002)(54906003)(71200400001)(26005)(316002)(2906002)(122000001)(91956017)(76116006)(64756008)(4326008)(66476007)(66556008)(83380400001)(8676002)(478600001)(66446008)(66946007)(41300700001)(38070700005)(53546011)(6506007)(8936002)(2616005)(186003)(6486002)(5660300002)(33656002)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8277 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3712c64b-3aa6-4791-d600-08da9195fd0a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IdU7RpL6gF2XOmqIjGst4hUGDEF+73UZg+ohsK6mYs5x12MPr0oGHvtJY1ngW2g4xwqNcIEB4MLhjGQJg8wPniE928hnbryQFwmQlkncYTJBQvm0P77ka0XDr4obTxAZkpso6KIwrMaW7RuJLqCmr/TLkKXiXU79K95wzhir9/Fh3G7/fVwHnpavQkF+ilknviJ0fm9zOfmkyzVEp7d2sSSqBoN6dqikFqwedE5LjEQij+H4MJICTvyZRDNKsHzLgCDeJK3mMMrTUKUH4h6P5URBcL+nvRbBoTFAe2cdcSUhZVTNLxOnkySfzgnwLcWQhEkxf4ojUejFQvgvLa30MmB07Fo0Wmk6zem2kL7ALCVM54FQPwJbxTjF6gEMaXrFpxR7RAd9EtoPZ6/VfL65r/XlsoUUnluiHY6j5gryhFYrKn75TrtlV42Y1ItBxwfgtmMMI+U7VhflZF6hrFQc99oZJ+LskYCK2JKHCO4KwfKYYw74VakZNjWik4XdMmFyjyQhwn1QOpQcmcGrbHJ0Tnp4S0SqqzJZRONvUHBeRosvH29Qvdi24VVKmxZERAYc0h5sOkgpHSuCtJzrA5d46D9OQ+Pii2qYlzCz7vB6xCu5uImsaBLBXmC+GGzM/7RtvmdqPMWM4y/5fE0HsCjUMccwP/VdMHRnLN6k8fBBxHZEP9BHNuAzOwRgfmROIIjaNKuW8iHPiIelgfa3c1hJZly4iIFbhww+cLfAn4Yc9AyW8Ic4IJ0+spQMoFLQZnsquaW7QeRCfpujQhimcxyrzQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(36840700001)(46966006)(40470700004)(70206006)(6862004)(5660300002)(8936002)(41300700001)(2616005)(33656002)(26005)(6512007)(53546011)(2906002)(40460700003)(82740400003)(40480700001)(86362001)(6506007)(36860700001)(82310400005)(186003)(70586007)(336012)(47076005)(81166007)(356005)(83380400001)(478600001)(6486002)(8676002)(54906003)(4326008)(316002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 12:31:14.5344 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9e95a1c-daab-4411-9300-08da9196054d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7993 SGkgSmFuLA0KDQo+IE9uIDggU2VwIDIwMjIsIGF0IDE6MDMgcG0sIEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4wOS4yMDIyIDEzOjQ5LCBSYWh1bCBT aW5naCB3cm90ZToNCj4+IGlzX21lbW9yeV9ob2xlIHdhcyBpbXBsZW1lbnRlZCBmb3IgeDg2IGFu ZCBub3QgZm9yIEFSTSB3aGVuIGludHJvZHVjZWQuDQo+PiBSZXBsYWNlIGlzX21lbW9yeV9ob2xl IGNhbGwgdG8gcGNpX2NoZWNrX2JhciBhcyBmdW5jdGlvbiBzaG91bGQgY2hlY2sNCj4+IGlmIGRl dmljZSBCQVIgaXMgaW4gZGVmaW5lZCBtZW1vcnkgcmFuZ2UuIEFsc28sIGFkZCBhbiBpbXBsZW1l bnRhdGlvbg0KPj4gZm9yIEFSTSB3aGljaCBpcyByZXF1aXJlZCBmb3IgUENJIHBhc3N0aHJvdWdo Lg0KPj4gDQo+PiBPbiB4ODYsIHBjaV9jaGVja19iYXIgd2lsbCBjYWxsIGlzX21lbW9yeV9ob2xl IHdoaWNoIHdpbGwgY2hlY2sgaWYgQkFSDQo+PiBpcyBub3Qgb3ZlcmxhcHBpbmcgd2l0aCBhbnkg bWVtb3J5IHJlZ2lvbiBkZWZpbmVkIGluIHRoZSBtZW1vcnkgbWFwLg0KPj4gDQo+PiBPbiBBUk0s IHBjaV9jaGVja19iYXIgd2lsbCBnbyB0aHJvdWdoIHRoZSBob3N0IGJyaWRnZSByYW5nZXMgYW5k IGNoZWNrDQo+PiBpZiB0aGUgQkFSIGlzIGluIHRoZSByYW5nZSBvZiBkZWZpbmVkIHJhbmdlcy4N Cj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+ DQo+PiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiAjIHg4NiwgY29t bW9uDQo+IA0KPiBGVEFPRDogSSBvYmplY3QgdG8gdGhpcyB0YWdnaW5nLCBhbmQgSSBkaWQgbm90 IHByb3ZpZGUgdGhlIGFjayB3aXRoDQo+IHN1Y2ggdGFncy4gUXVvdGluZyBkb2NzL3Byb2Nlc3Mv c2VuZGluZy1wYXRjaGVzLnBhbmRvYzogIlRoZQ0KPiBgQWNrZWQtYnk6YCB0YWcgY2FuIG9ubHkg YmUgZ2l2ZW4gYnkgYSAqKm1haW50YWluZXIqKiBvZiB0aGUgbW9kaWZpZWQNCj4gY29kZSwgYW5k IGl0IG9ubHkgY292ZXJzIHRoZSBjb2RlIHRoZSBtYWludGFpbmVyIGlzIHJlc3BvbnNpYmxlIGZv ci4iDQo+IFRoZSBkb2MgcHJvdmlkZXMgZm9yIHRhZ2dpbmcgaGVyZSwgeWVzLCBidXQgc3VjaCBz aG91bGQgb25seSBiZSB1c2VkDQo+IGZvciB0aGUgdW51c3VhbCBjYXNlIG9mIGFuIGFjayByZXN0 cmljdGVkIHRvIGxlc3MgdGhhbiB3aGF0IGENCj4gcGVyc29uJ3MgbWFpbnRhaW5lcnNoaXAgY292 ZXJzLiBPdGhlcndpc2Ugd2UnZCBlbmQgdXAgc2VlaW5nIG92ZXJseQ0KPiBtYW55IHRhZ2dlZCBh Y2tzLiAoUmVjYWxsIHRoYXQgdGFnZ2VkIFItYiBpcyBhbHNvIGV4cGVjdGVkIHRvIGJlIHRoZQ0K PiBleGNlcHRpb24sIG5vdCB0aGUgY29tbW9uIGNhc2UuKQ0KPiANCg0KT2suIEkgd2lsbCByZW1v dmUg4oCcIyB4ODYsIGNvbW1vbuKAnSAgaWYgSSBnZXQgY29tbWVudHMgb24gdGhpcyBwYXRjaA0K YW5kIHRoZXJlIGlzIGEgbmVlZCBmb3IgdGhlIHRoZSBuZXh0IHZlcnNpb24sIG90aGVyd2lzZSwg SSBzdWdnZXN0DQp0aGF0IHRoZSBjb21taXR0ZXIgY2FuIHJlbW92ZSB0aGlzIHdoaWxlIGNvbW1p dHRpbmcgdGhlIHBhdGNoLiANCg0KUmVnYXJkcywNClJhaHVsDQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:40:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:40:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403313.645381 (Exim 4.92) (envelope-from ) id 1oWGpr-0007Dc-M7; Thu, 08 Sep 2022 12:40:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403313.645381; Thu, 08 Sep 2022 12:40:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGpr-0007DV-J5; Thu, 08 Sep 2022 12:40:47 +0000 Received: by outflank-mailman (input) for mailman id 403313; Thu, 08 Sep 2022 12:40:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGpq-0007DP-CW for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 12:40:46 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 732b018e-2f73-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 14:40:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 732b018e-2f73-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662640844; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UHirX8ZPWwvVlfHgN7hlU5UlJmwUZ9tZfxRV1Ldodlo=; b=XZK7YDFT/5QKpDYfvPD+rksul6C0jfN74oKuiO5BF+n1A7tvzM9aDWmj YRZ+OXNLhCXbw/GJ6ua4qQXZnys6wijNEC4RY7AgZ/bH93VLVFo+Oytbq 7zrFs5suwUxm6AXa0hFNBBj2/H542qe31Y1iN/TzsKlWaqR5UWxSnkAva E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80056515 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AkUJ2NanOrW9Qf0QNoBP76pjo5mJPLROUhFxM2?= =?us-ascii?q?KjiYuv7R7IEGpDEwMcbYTqtoJ1vIw21LNOo3Mk2BvF9wazN9m8VGLUgYDXkQ?= =?us-ascii?q?8hXp2zUHSnUq+RCPCajnZkjn7x+WCIf3eL+ceqrcJ7NAvO7zvUWAk2Cfz9Td?= =?us-ascii?q?+6fiOT9ni94OVfOOMABpWVIPf7g4n5HD2FdEJfU2v+O34E/NXwgLaSf7qxnd?= =?us-ascii?q?Fy6fcz1kdRFS3azE2hG8vzxBNDL3L3YwcJuXeaDvzKBq/6HxfGO1C/40gZbe?= =?us-ascii?q?MbvBS/VEgnn9sFsY8sZtJbTGCkR5cNnWjT2HBfNKpjRWKgD4ebEJUNZkob4y?= =?us-ascii?q?QhnX/U+dDKdDUN8NQdmK34bFEUd76nEInWD+fzM+Eed9Hr5aMdeJxl4W3BSN?= =?us-ascii?q?fKxcJKVgtr7RDQE4bvGbTWTqmpHeQsuKwlpF9fyHIwvQIln4IxwCRPeningC?= =?us-ascii?q?eWNA/w/R6LLXp25YMHQDLaewdVVylxDR6t8YTCVv455ZP1z3Q4VozD7BlUsv?= =?us-ascii?q?P3o14rBVYUXSPenoEwTY95kBgU6zHTKt7saVpATCSdrpF8SQa/YfMpmDAqhQ?= =?us-ascii?q?X9rvotWU45spBlPOrZo4opdlclo4SOlFH0g6ht/jo9ofulKt0ngrkdb6XOP6?= =?us-ascii?q?T+EcY+N9k+AnYLWK2Mb6+RLQCOuijS6UP9IrmK55o3+cT6Ya63IjZXo+EuRg?= =?us-ascii?q?DV3GgtrlWH8OosmHhgtbwNWp7MikqCowdyxp1qHElDta7Ac0EbUgSSuO7dqy?= =?us-ascii?q?3sOACFPCRD719gYI/QKzITlV8+xHQjsGve0J9dLGGOoxh6mbpW6avGvydbCY?= =?us-ascii?q?YzaDIyHtGN0BCmHGhpaKhU2KD+IWH7Ef7459YEOosZb+08Hbv/cgGWxkTzEz?= =?us-ascii?q?iTXIgHH6S01JI26T8gF8Q8OOA5ZywDKB9cdINjMX4UCNak2Tp+BcEXO2VtKi?= =?us-ascii?q?Zit3i4eHnOzCVfURGtVKvnbE0oud9k5bZTsI/ld1Dnb5o+rnxeitoVL59Kdu?= =?us-ascii?q?3ilvKH5JJ27VjDLgzPOHLEZ/tXBxx8+EMhWAxj8sefi1TnkbXkAOeUoX7eBQ?= =?us-ascii?q?0lPYtlkARy+vQK7ExiFNLOSTrocCoEsDF554s0L6qaTyS90bYuW46WvqiRzf?= =?us-ascii?q?oxXxfrSmdhimcI+0kfb7aWU+G2i4lSZpyDXFLw5wLjvx3JvnCWKYjnXvrIka?= =?us-ascii?q?OzSLEcJB3u+Vs2PsauuR864xfWsEPOwIa/UJzQ37RtTAjL0IniZmYMUUTIyb?= =?us-ascii?q?d/g6WMSZiwRpdGmPktpr1fjTzGeJopTKwAwydwF3L64txQ0lirNhRz/UgOx+?= =?us-ascii?q?wviD55wVT+CA6z1x/5BiZbAFdGrpElorXzHQTCl0J6bi5yWuoi4DhtUN4xpm?= =?us-ascii?q?v50nwrUF+1Syc/TBzglhYDfeI7T0dEa9GAm3ULnpb+JVN7KyZ8cfub2sUpGc?= =?us-ascii?q?rEYjuNEnGjbBmYC00A+tVXCFzw4mUh5kNgEU9HEiFL43/cqlEkdMTPhhAh3S?= =?us-ascii?q?fyKmRF6XXqzb5pWyCINOUjcmyyEosZbSuIyBcy/a4QXRHGMwSy/++G541dGh?= =?us-ascii?q?/t/+2WVeJMkK2gSVxrcVajNq/K1C0aXKXWTMB16Re+uR8CGe2/gBPQ/636YO?= =?us-ascii?q?aN3H8CKpQ3/SeqoZTC1z47J57lSaG4yr1SldR6kgyyAdiYVBq+RUXm14w0GA?= =?us-ascii?q?deSX4PKNPeeIySd5ViSZHFWOiXtwXVcW7/QemVxh4tmmy6QGPUub/F+/wujk?= =?us-ascii?q?23577D0cFpcOjZHp/TeQMzz7Q119D3uV1IAgxRTE/h8bZv3ugPaYUeycMMKn?= =?us-ascii?q?0DcfuEFZ3SIRw3tpuYrgETlyCgVdQgrE0T4ZhKfDwNy1j+TliWtoYF9h7g0Q?= =?us-ascii?q?vzBTJDA65Qu07g5U1KpnNjS5AdqnfCRb/qpqEzfU/+WC4ywI6LRrmdgRRBP6?= =?us-ascii?q?vor6Pvgxicq2NIIxyC5t6kYtnksXLtw1ekGaNd09QlXDeIc8lkbdrtfhDY9Z?= =?us-ascii?q?h8eox5slaGecvMp2W29xATm6vvjNkHAk+bbX3eAqFUHMjV41QePF/hGs8pGx?= =?us-ascii?q?9vWZNtk2Qd5Y5u7AjTSSgdGiCuev/UjAvWVQTsnGDI6s6iEnDgeH8oE0xR5D?= =?us-ascii?q?/+Rb75lxgxcEtOowIeGx1162XaFaxoCtCLshFXxsXLUp0ssTUvlHThB5t52d?= =?us-ascii?q?s9AA0Ud0gzJjZKCX/ishaWGnn+S576LxlF0YWraq9HMAykph3+ZEiu/XRHjV?= =?us-ascii?q?9QCWK9VYPPBSVM7l/rW73+LlMuGIqy7NGOB++gIRXUI7SuZiSubGPfOQGY5Z?= =?us-ascii?q?R9AN6sXfLM6zF5a3nqfL/ZdshDjPLT49qrYK8XrsxPSBC2os1LYVhAMr9gkR?= =?us-ascii?q?zGxAFjgARw8Tx8FTwt1XjoyGFqFTC5UT7ZRgCdrQAy15dSpg++jMM4TIcIdz?= =?us-ascii?q?nz10VsJ/FwopocrCWXa00vUgyQpieKisk8Vt3gWqSJyyq28kHXdztTLzPqX/?= =?us-ascii?q?XlxPpwybaIZrAI0bU37zc6QMavu6aJ+DgNVBkJGSZBCVspFAITAhIkwMyXxV?= =?us-ascii?q?Sp0qHV3QRIerf3h+rdcUaOBLX05hnXeDtmU140yfA7+yZ2UbunxYA1XCaEtR?= =?us-ascii?q?2O15+Co4IuBOqIG1hGzPdcWcja2Rt2G9aOVU4i0/wlg+s1Ga8IPlgVOD3yOU?= =?us-ascii?q?9v1Fw8yYRRjjumOfK8Duhn9/At/yN2yrXzvSVdiRKvDt3va5wzZ9dAyjh7Z6?= =?us-ascii?q?h5vSe5Y0+NMGdYUtvB3l7tX6Naf4rwYqTg0zA5B7fzKi4lSH1/aeAJn1UzTY?= =?us-ascii?q?wQlrHeL5UeXRlS5lNCKLwp9z09cWILrF7uiGmLQdqRnJTD9OaZ5ZQGxYtEjm?= =?us-ascii?q?60CYItJCnVw74mdsTmNeQ4YpuxJQg+o4+NXv7jhI8w9iM9RHoY2C7c5mA=3D?= =?us-ascii?q?=3D?= X-IronPort-AV: E=Sophos;i="5.93,300,1654574400"; d="scan'208";a="80056515" Date: Thu, 8 Sep 2022 13:40:37 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" Subject: Re: [PATCH 2/3] xl/libxl: Add ability to specify SMBIOS strings Message-ID: References: <20220810194827.103428-1-jandryuk@gmail.com> <20220810194827.103428-3-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220810194827.103428-3-jandryuk@gmail.com> On Wed, Aug 10, 2022 at 03:48:26PM -0400, Jason Andryuk wrote: > hvm_xs_strings.h specifies xenstore entries which can be used to set or > override smbios strings. hvmloader has support for reading them, but > xl/libxl support is not wired up. > > Allow specifying the strings with the new xl.cfg option: > smbios=["bios_vendor=Xen Project","system_version=1.0"] > > In terms of strings, the SMBIOS specification 3.5 says: > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.5.0.pdf > """ > Strings must be encoded as UTF-8 with no byte order mark (BOM). For > compatibility with older SMBIOS parsers, US-ASCII characters should be > used. NOTE There is no limit on the length of each individual text > string. However, the length of the entire structure table (including all > strings) must be reported in the Structure Table Length field of the > 32-bit Structure Table Entry Point (see 5.2.1) and/or the Structure > Table Maximum Size field of the 64-bit Structure Table Entry Point (see > 5.2.2). > """ > > The strings aren't checked for utf-8 or length. hvmloader has a sanity > check on the overall length. > > The libxl_smbios_type enum starts at 1 since otherwise the 0th key is > not printed in the json output. > > Signed-off-by: Jason Andryuk > --- > The rendered man page and html don't have a newline at then end of the > new section. > """ > battery_device_name=STRING > ms_vm_genid="OPTION" > """ > > however the txt format is correct: > """ > battery_device_name=STRING > > ms_vm_genid="OPTION" > """ > > I'm at a loss as to why this is happening. Maybe it's because =back just cancel =over, and pod2man just keeps going as if it's the same list. Adding some text for the =item or after =back would help, but that's done in the next patch, so I guess we can live with that for one commit. > --- > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 2abaab439c..9034933ea8 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -771,6 +771,26 @@ static int hvm_build_set_xs_values(libxl__gc *gc, > goto err; > } > > + for (int i = 0; i < info->u.hvm.num_smbios; i++) { > + char *p; > + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, > + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); > + > + /* libxl defines are all "_", but the HVM_XS_ strings are "-". */ "libxl defines are all "_"" seems a bit weird to me as a comment in the source code, maybe a better comment would the conversion we need to do, something like: Convert libxl_smbios_type string to xenstore path that hvmloader will use, as defined by HVM_XS_*. That is convert the '_' to '-'. > + p = strrchr(path, '/'); > + for ( ; *p; p++) { > + if (*p == '_') > + *p = '-'; > + } > + > + LOGD(DEBUG, domid, "Writing %d %s %s\n", i, path, I don't think printing the value of i would be useful here. Also adding a '=' before the value and putting the value between double-quote would be a bit better. > + info->u.hvm.smbios[i].value); > + ret = libxl__xs_printf(gc, XBT_NULL, path, "%s", > + info->u.hvm.smbios[i].value); > + if (ret) > + goto err; > + } > + > /* Only one module can be passed. PVHv2 guests do not support this. */ > if (dom->acpi_modules[0].guest_addr_out && > info->type == LIBXL_DOMAIN_TYPE_HVM) { > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 1b5381cef0..4f3f962773 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1220,8 +1220,9 @@ void parse_config_data(const char *config_source, > XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms, > *usbctrls, *usbdevs, *p9devs, *vdispls, *pvcallsifs_devs; > XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs, > - *mca_caps; > + *mca_caps, *smbios; > int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps; > + int num_smbios; > int pci_power_mgmt = 0; > int pci_msitranslate = 0; > int pci_permissive = 0; > @@ -1783,6 +1784,47 @@ void parse_config_data(const char *config_source, > xlu_cfg_replace_string(config, "acpi_firmware", > &b_info->u.hvm.acpi_firmware, 0); > > + switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) > + { > + case 0: /* Success */ > + b_info->u.hvm.num_smbios = num_smbios; > + b_info->u.hvm.smbios = xcalloc(num_smbios, sizeof(libxl_smbios)); > + for (i = 0; i < num_smbios; i++) { > + char *option_untrimmed, *value_untrimmed; > + char *option, *value; > + libxl_smbios_type v; > + > + buf = xlu_cfg_get_listitem(smbios, i); > + if (!buf) continue; Isn't this an error? It seems that xlu_cfg_get_listitem would return 0 if 'i' is outside of the array or if the value isn't a string. I think it would also mean that "smbios[i].key" and ".value" would have uninitialized value and potentially garbage. > + > + if (split_string_into_pair(buf, "=", > + &option_untrimmed, > + &value_untrimmed)) { > + fprintf(stderr, "xl: failed to split \"%s\" into pair\n", > + buf); > + exit(EXIT_FAILURE); > + } > + trim(isspace, option_untrimmed, &option); > + trim(isspace, value_untrimmed, &value); I think you could free "option_untrimmed" and "value_untrimmed", as "option" and "value" are newly allocated strings. Also, "option" won't be needed after it's been converted to an enum value. > + > + e = libxl_smbios_type_from_string(option, &v); > + if (e) { > + fprintf(stderr, > + "xl: unknown smbios type '%s'\n", > + buf); > + exit(-ERROR_FAIL); > + } > + > + b_info->u.hvm.smbios[i].key = v; > + b_info->u.hvm.smbios[i].value = value; > + } > + break; > + case ESRCH: break; /* Option not present */ Could you move the "break" to a new line? It will make it easier to read that ESRCH is just ignore instead of throwing an error. > + default: > + fprintf(stderr,"xl: Unable to parse smbios options.\n"); > + exit(-ERROR_FAIL); > + } > + > if (!xlu_cfg_get_string(config, "ms_vm_genid", &buf, 0)) { > if (!strcmp(buf, "generate")) { > e = libxl_ms_vm_genid_generate(ctx, &b_info->u.hvm.ms_vm_genid); Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 08 12:51:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 12:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403321.645393 (Exim 4.92) (envelope-from ) id 1oWH01-0000Qx-N8; Thu, 08 Sep 2022 12:51:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403321.645393; Thu, 08 Sep 2022 12:51:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWH01-0000Qq-I2; Thu, 08 Sep 2022 12:51:17 +0000 Received: by outflank-mailman (input) for mailman id 403321; Thu, 08 Sep 2022 12:51:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGzz-0000Qg-JP; Thu, 08 Sep 2022 12:51:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGzz-0007fm-Ga; Thu, 08 Sep 2022 12:51:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWGzz-0003wE-1K; Thu, 08 Sep 2022 12:51:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWGzz-0001Sr-0r; Thu, 08 Sep 2022 12:51:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oSH6l9Zqlwj+IPGdo7FsjfwU9fpqNGVblbLphIskZYg=; b=Tes26F23xB9v7Oh4gxAToiKQye gepdbc1wQmqWpajdka+8HFvulCnYuijjnXS2WYI0sJo7dzmIUxuWH9kjNVm9zex4SvLw8PkGNUHie rHFA0gTX0wSsCZRZmcfAfxxCLXDwt3WFpoTK7ZA2BM1COHyEsMZUv/kOCREhQv4gqmVc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173062: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=d82ec90f51f61c914396271d86e64a74121dde24 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 12:51:15 +0000 flight 173062 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173062/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf d82ec90f51f61c914396271d86e64a74121dde24 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 266 attempts Testing same since 173057 2022-09-08 03:17:03 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2203 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:03:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:03:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403333.645404 (Exim 4.92) (envelope-from ) id 1oWHBO-0002BB-OV; Thu, 08 Sep 2022 13:03:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403333.645404; Thu, 08 Sep 2022 13:03:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHBO-0002B4-LM; Thu, 08 Sep 2022 13:03:02 +0000 Received: by outflank-mailman (input) for mailman id 403333; Thu, 08 Sep 2022 13:03:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHBN-0002Ay-2v for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:03:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60067.outbound.protection.outlook.com [40.107.6.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 901cb174-2f76-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:02:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3892.eurprd04.prod.outlook.com (2603:10a6:208:11::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18; Thu, 8 Sep 2022 13:02:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 13:02:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 901cb174-2f76-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEVSfDU1c4Q7q4oSmY7IlV3KVK32ynungNzQ6WM1Kwxu1FOaHoyWjAhFXhQElIElZ3z4ky2BAUGmmMgEJ+SwsC3xyJI+dTLCZBDedLiN85GZyFIKgjysADh4p2VIywli7430iM00AtsgZWBUR9a7oNRFLxPcP2yn9qk76i+qUkrFkzD+waHz/jUoadENWMJ+giM/s78vd9fRBMYdCygYytHVzrnrR7X16Af/yAKoIsdoc3MVNUSeM514+Y9E0maR7Nhi7N7c7W6BVj6OmrUNhbisAm2Q/sCE3NtMcC9fWoPItf+BUoTQPSGo4cPj9q0axocAwHj7OsFX48djKmW2Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ZezF46r6xIcbGdDNQ19SoK7mLvv0hwZ/KPQ5tp41J0=; b=hDISNb/QaWtLKgGRbd5sAobn/l98Tma0LwTm6KjrDc4mju76OpvOCBD5mgofjInQ190ETDX0T7lVvU9C8rC7N2vIlP4fH1kHYmanz93J08Pp0jJijTWlcAAh1+kKVW+FIfGKa9o9k+8VolZt09HUk7BOefNJeA0RAQ5HufsOFZvwXBQrxWkD20/QDhOcqt73uf0KXhxrv+iwSl9hHoJl07GyHLv+BWPSd6qtGH/IwBfJJHP0/do8MbetnLnC/uVHO6wDUCh9rFYeMeZc2f2FNpl/XnWkpDGKpRZxNbDO5innnR/X+WYVtaxquijJz5Ht4hec8l4eAWDyBLgsqi9Enw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ZezF46r6xIcbGdDNQ19SoK7mLvv0hwZ/KPQ5tp41J0=; b=ziBoWvK9DJ32I4dvL6Zl7Yq1hBANZk/vTNPTcUcpY5nDl3vjXwRRWLBtPuIkb5ANGe+4hvf4rutUiY0REO1jM65rrVxyJy8A7FLwU51M2oB1DMUhEYq2qm6uDt/ZiUPYDiuZUda57LRPcMi7sXn4Dji4FKlytxg+hVOyvwxUoD2XIcwbXZmCOTSSJuriprtEU6PSw0GNg+En+FaJ5YpcekY8zyb9H4rD6Gyi8+7hqarv7H2Sl+o3E1tVrH0WBr5K0U1NLlkfe7pg02lrZ6nxa+thSYpRiLHhV8H4taocfyU4Bqx9XXCGbFGXi+jFOVKi0nlCcXkM4lqH4/HFvr7EBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <837f7b6d-0d73-a352-17e6-5c12e06dab95@suse.com> Date: Thu, 8 Sep 2022 15:02:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220902033121.540328-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR0402MB3892:EE_ X-MS-Office365-Filtering-Correlation-Id: 20fcf218-761a-4dff-9d2a-08da919a7218 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UssARKcXZR+JUqrw2UvUkMeHz8F63GxOOwbVdICYA5D451B8N+B8iC8ZxFz4VNPFXZP1lIZHkZtrY7iYdR2n32SESN95dyk56i2UV2EooaMcNAtQEfoODs1yPnw9Am71TBfOIOdH8P9EbEp+YSYpBPU/+lfZHkDDXqqE6OCgK7N6ElmxJ0X1UghBc7SMvU9SdQm6IZ+PRc98U5seI/FP3vTSaGny24axqQLS+RuPjudn9w+ypHT2DTmUYzxo+uyAt1Q6xIWywVVapRSdz2WGFV2iMExDAYiARBkKktcV7knxndWEX47ktScwlF/oJYb4wuCraoCPZWrVjU5mDlGDTQ1OSPIH461WEQGNRYS+0K5OG4ebn8tea+Egph3GAucexfAsp23BjqSG6DcfDTjfTbFgsdqHb5pdtHPB4Wv/KzP+CUe4XsfxfVcnUWdwUcOQYlCoj+M6RYMBgIhibW+QevmPWFK4KL0TqrwUCiLi5OD04vrY9gaFzP3QRqWsbcqFnPvaDI5chuLUuhJB1oLfBenT4CBPjW4hrfgbkun2B2484iEys2Ugb2MoNYehH3Vl7cagC1rnXT+EAq/QiWtjvHKULNS5FSP3z3Anzk44blYIqHZmkShPIuUrY5XzlaBuYpr0dcKsn4TQQdT2PHFIxnwjQpclBPWbWz22p2I4nXb1kOhXmuvvV+6e0jszSyz9CgqVrVf/8JiBQIg5jjV2IJ5gwLLjq2wFhk9aFVf1QPndMQ1rkmi2gt8ZAeOSa04PNgRyYQzsa5iGG1T5OIftpKdIrrazjIYwUBbL2+/cqS0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(376002)(366004)(136003)(346002)(54906003)(316002)(31696002)(6916009)(2906002)(86362001)(66476007)(66556008)(8936002)(66946007)(5660300002)(38100700002)(8676002)(4326008)(2616005)(36756003)(31686004)(478600001)(83380400001)(6486002)(186003)(41300700001)(6512007)(26005)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cS82Yk1NRGZvaGhkcENjbEFuS3d0MDY0VjNwVXlLcFdYSEtWaUVydWpqQmJN?= =?utf-8?B?aUNJS0FJVmZIMTcrRHpEc0pYQzhFcENNTk1nZ296WEZEL3NnUTNxTHNGUVVt?= =?utf-8?B?eW1BajRud3dxczlhanVOMGdDaG9kbENYQXQwd0ZDM3MxbjdZR2o0VThNMnF2?= =?utf-8?B?K1NqZFdzZVN1RXQyU0NnOHR3N010MEgzcWRONEZyZ2E1dzIrYlNqclNDVko2?= =?utf-8?B?TjZySzJGckZtUlBaZEJhRTBGbnVGY2p3NmpjN1g5czZvNitwWXZKSTMzUlI2?= =?utf-8?B?b0xrU21TOEUvbWhxRXh0ZXBhRitUbmNLTkpjWlZxWlFIejc0QXQ0QlNYaEZW?= =?utf-8?B?ejlMd0taRzlsWCtHQ0d3Uk8vTWFGOUxCMW9wR2FLMTFidDdFLy9YMWY4ZHRC?= =?utf-8?B?L1ZZa0NLVU56VXFsU3hkZ2FMVzlDQ2lQUWhNZHRZcmxVVndVZTR6WFBZVmxt?= =?utf-8?B?MWFUTXUyQi96VUZqSGk4WW9DemszamkzbkN4OWRIeWxrQ3U2T3lNS3BCWjRp?= =?utf-8?B?endSeHpmckNTa2xValIzcE96cy90YW84VFpPNUJvbW9zM2pXRWtwSTFCNW9F?= =?utf-8?B?d09jTWo2OER4NTA2RDdyTE5QTzFqYllYNUM0TmloQVV2WkdleGJWckxlK204?= =?utf-8?B?bmpGVExkUThHbEg5RXpxMGtabWdkWVU1Yk9TWTJTaDgxdnJBcmtEdGQ5TXRD?= =?utf-8?B?MXE2UHE4VzE3cXBUSU0rUWpRc1k5dWl5OG9ON2VteWpmb05xUnZGQ01ydGZW?= =?utf-8?B?dEx3UmwvZkZFUDZ1aFlVZmk4enFpMDM0Yng3NHlsbnk4YkxiOGhCSW9YKy9s?= =?utf-8?B?UzJ4by9ibzU4ckN2TWgxYUs2QmZQSFIxZTZGczBEM1FJN1FmSE9mbFgyVHhL?= =?utf-8?B?V1hJcXNqMWNZdmZldXVaN0hocjcwMm9IQXE2bmVBTUxsTHBBcHN0NmI4S1Ur?= =?utf-8?B?RWZmNG5taGt0VVBNS2pvVHQrUWUrS0UwR1V1MWxiN3A4NHlZaEdoU0xaUXV1?= =?utf-8?B?ZzJVeTJaa0ZsbTFFQ1lMU3JEM0dWTnBwbWhMRlFJZWR3NSszNEYvZW15cEI5?= =?utf-8?B?b2V5M3BISktMSnQ1NTVwa3BmWkNYaG9xOFQwS0NidjBUaWJPV3dzRHBXaXhW?= =?utf-8?B?K2ZpYklPSXZNTittZzJHL2dEVmN5SEJiT1JtZ3NRbDBTV2hNV2M2enhWTyth?= =?utf-8?B?QTY1RWRpdGRZZUowczV6SkdZczhNVmRWckJ6QXJ4ZUhmVFp4djk0SklQdDIz?= =?utf-8?B?NEp2aEhBM0hiRXQ0QlhPQ1RScUsrQ0xKNXRvTGowb214VUtLMHAzQ1VnZVE3?= =?utf-8?B?cVdsaDZZdHBOdWJKODZTcFM4c0xOL3F2TkVVMzNKeWlISFRueXlseW5nbU8z?= =?utf-8?B?S1JxY3U2ZjNza2syRUpFd1ArdThrME1WMEU5SU5RbDc2YStlUlluTnM4VlR2?= =?utf-8?B?cDhhRnpaSVYyR1FOYTdOenptVWZiYWNmRThPMmRVcFVsN3ZsMDZCRTJoVncz?= =?utf-8?B?WURENWFxN3BiK0Z5V3hSQ1hzeVFrNHFzYmNCNUpxVVpwMk1HQVMwU2NTaUho?= =?utf-8?B?bjV6Sm1YWGlDYVpud3h6TUQraE1uOEVxek9NeVhEdXQ4Rm5kWm9kaUcva1RG?= =?utf-8?B?VnpmTFNSdGZWUXlqMlA4VGNRL1NTa2pZdmt1TUpxdWdZenhyZWttUDBXak5H?= =?utf-8?B?N0xKdUREMnFhQVJTb0ZMcHFKa1pnQWRoNTNiMW12YXlCSmxvTXhGMW54M2Fr?= =?utf-8?B?Zm50OC8xSDlMTGMreGJVdHh3RXRHd0pKY2luOWJ0a09uOXlVSGlPLzF0cWhV?= =?utf-8?B?ZjJBSkpKdXRMZk5TVUNDZlNvVnQ2OHFQclBINzd5WGFSU0R2YlJEckVWR1FJ?= =?utf-8?B?WUxvN2pDcGpGOEdld1h3dW9USFFob29VbDBTYXFBM2FoS0ZLc0t4WTlBaTRV?= =?utf-8?B?WDlCYjNMTUtYTG5NazgweDh4a21nK0czNkJDaUIzYVMrUUUyTkYwSVUrZzcr?= =?utf-8?B?aTk3eVBWaWNoRTQrTlhrRUJrdjM2R0tmVlRTVitFSjdJa3NudFZLekthdi9E?= =?utf-8?B?aWIrV0tRNWhkY1ZkWU9Jazl3Uitwek1VMW1zb0luRXpuT2xaOU04bWFnUmdw?= =?utf-8?Q?1lmWwlEuQBc60sz/PYkPCyMNm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20fcf218-761a-4dff-9d2a-08da919a7218 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 13:02:55.2803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RGJ05sS3910BoXFUwtzN4ThN0+Lc9MHoXQOsXfqKI8Tluo4947/lpIBpmkAGneg9qay/FRTNALEfCpvl7qV+Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3892 On 02.09.2022 05:31, Wei Chen wrote: > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -41,9 +41,12 @@ int __init arch_numa_setup(const char *opt) > return -EINVAL; > } > > -bool arch_numa_disabled(void) > +bool arch_numa_disabled(bool init_as_disable) I'm afraid my question as to the meaning of the name of the parameter has remained unanswered. > @@ -306,32 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) > void __init > acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) > { > - struct node *nd; > - paddr_t nd_start, nd_end; > - paddr_t start, end; > unsigned pxm; > nodeid_t node; > - unsigned int i; > > if (numa_disabled()) > return; > if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { > - bad_srat(); > + numa_fw_bad(); > return; > } > if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) > return; > > - start = ma->base_address; > - end = start + ma->length; > /* Supplement the heuristics in l1tf_calculations(). */ > - l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE)); > + l1tf_safe_maddr = max(l1tf_safe_maddr, > + ROUNDUP(ma->base_address + ma->length, > + PAGE_SIZE)); Indentation: l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(ma->base_address + ma->length, PAGE_SIZE)); > @@ -33,7 +48,309 @@ bool __read_mostly numa_off; > > bool numa_disabled(void) > { > - return numa_off || arch_numa_disabled(); > + return numa_off || arch_numa_disabled(false); > +} > + > +void __init numa_set_processor_nodes_parsed(nodeid_t node) > +{ > + node_set(node, processor_nodes_parsed); > +} > + > +bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) > +{ > + unsigned int i; > + > + for ( i = 0; i < num_node_memblks; i++ ) > + { > + struct node *nd = &node_memblk_range[i]; const? (This is particularly relevant with __ro_after_init.) > +bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, > + paddr_t start, paddr_t size, > + const char *prefix, > + bool hotplug) > +{ > + unsigned int i; > + paddr_t end = start + size; > + paddr_t nd_start = start; > + paddr_t nd_end = end; > + struct node *nd = &nodes[node]; > + > + /* > + * For the node that already has some memory blocks, we will > + * expand the node memory range temporarily to check memory > + * interleaves with other nodes. We will not use this node > + * temp memory range to check overlaps, because it will mask > + * the overlaps in same node. > + * > + * Node with 0 bytes memory doesn't need this expandsion. Mind taking the opportunity and drop the 'd' from "expansion"? > + */ > + if ( nd->start != nd->end ) > + { > + if ( nd_start > nd->start ) > + nd_start = nd->start; > + > + if ( nd_end < nd->end ) > + nd_end = nd->end; > + } > + > + /* It is fine to add this area to the nodes data it will be used later */ > + switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) ) > + { > + case OVERLAP: > + if ( memblk_nodeid[i] == node ) > + { > + bool mismatch = !(hotplug) != !test_bit(i, memblk_hotplug); No need to parenthesize "hotplug" here. > + printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", > + mismatch ? KERN_ERR : KERN_WARNING, prefix, > + arch_nid, start, end - 1, > + node_memblk_range[i].start, node_memblk_range[i].end - 1); > + if ( mismatch ) > + return false; > + break; > + } > + > + printk(KERN_ERR > + "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n", > + prefix, arch_nid, start, end - 1, prefix, > + numa_node_to_arch_nid(memblk_nodeid[i]), > + node_memblk_range[i].start, node_memblk_range[i].end - 1); > + return false; > + > + > + case INTERLEAVE: Please don't add double blank lines anywhere (original code didn't have these); there's at least one more instance below. > +static int __init nodes_cover_memory(void) > +{ > + unsigned int i; > + > + for ( i = 0; ; i++ ) > + { > + int err; > + bool found; > + unsigned int j; > + paddr_t start, end; > + > + /* Try to loop memory map from index 0 to end to get RAM ranges. */ > + err = arch_get_ram_range(i, &start, &end); > + > + /* Reach the end of arch's memory map */ > + if ( err == -ENOENT ) > + break; > + > + /* Index relate entry is not RAM, skip it. */ > + if ( err ) > + continue; > + > + do { > + found = false; > + for_each_node_mask( j, memory_nodes_parsed ) Please be consistent with style for constructs like this one: Either you consider for_each_node_mask a pseudo-keyword (along the lines of for(;;)), then there's a blank missing ahead of the opening parenthesis. Or you consider this an ordinary identifier (i.e. the function-like macro that it is), then there shouldn't be blanks immediately inside the parentheses. (Same issue elsewhere.) > + if ( start < nodes[j].end > + && end > nodes[j].start ) > + { > + if ( start >= nodes[j].start ) > + { > + start = nodes[j].end; > + found = true; > + } > + > + if ( end <= nodes[j].end ) > + { > + end = nodes[j].start; > + found = true; > + } > + } > + } while ( found && start < end ); > + > + if ( start < end ) > + { > + printk(KERN_ERR "NUMA: No node for RAM range: " > + "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); > + return 0; > + } > + } > + return 1; > +} Seeing the two returns (and no further ones in the function) - did you not mean to also switch to bool/true/false here? > +/* Use the information discovered above to actually set up the nodes. */ > +static bool __init numa_scan_nodes(paddr_t start, paddr_t end) Is "above" in the comment actually still accurate? Aiui the discovery is now in a different CU. Then perhaps "Use discovered information to actually set up the nodes." > +{ > + unsigned int i; > + nodemask_t all_nodes_parsed; > + > + /* First clean up the node list */ > + for ( i = 0; i < MAX_NUMNODES; i++ ) > + cutoff_node(i, start, end); > + > + /* When numa is on with good firmware, we can do numa scan nodes. */ > + if ( arch_numa_disabled(true) ) > + return false; Btw - the comment here doesn't help me figure your choice of "init_as_disabled". The wording towards the end is also a little odd, considering we're already in numa_scan_nodes(). Which further points out that really there's no scanning here, just processing, so maybe the earlier patch wants to rename the function to numa_process_nodes()? > + if ( !nodes_cover_memory() ) > + { > + numa_fw_bad(); > + return false; > + } > + > + memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, > + memblk_nodeid); > + > + if ( memnode_shift < 0 ) As previously pointed out: As of patch 2 memnode_shift is unsigned, so this comparison is always false (and the latest Coverity will point this out). You can't get away here without using an intermediate (signed, i.e. plain int) variable. > + { > + printk(KERN_ERR > + "NUMA: No NUMA node hash function found. Contact maintainer\n"); > + numa_fw_bad(); > + return false; > + } > + > + nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); > + > + /* Finally register nodes */ > + for_each_node_mask( i, all_nodes_parsed ) > + { > + if ( nodes[i].end - nodes[i].start == 0 ) nodes[i].end == nodes[i].start ? > + printk(KERN_INFO "NUMA: node %u has no memory\n", i); > + > + setup_node_bootmem(i, nodes[i].start, nodes[i].end); > + } > + > + for ( i = 0; i < nr_cpu_ids; i++ ) > + { > + if ( cpu_to_node[i] == NUMA_NO_NODE ) > + continue; > + if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) ) > + numa_set_node(i, NUMA_NO_NODE); > + } > + numa_init_array(); > + return true; > } While you said you'd check elsewhere as well, just to be sure: Please add a blank line before the function's main "return". And perhaps another one between loop and function call. > --- a/xen/drivers/acpi/Kconfig > +++ b/xen/drivers/acpi/Kconfig > @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP > > config ACPI_NUMA > bool > + select HAS_NUMA_NODE_FWID Are you selecting an option here which doesn't exist anywhere? Or am I overlooking where this new option is being added? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:05:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403340.645415 (Exim 4.92) (envelope-from ) id 1oWHDU-0002m6-5i; Thu, 08 Sep 2022 13:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403340.645415; Thu, 08 Sep 2022 13:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHDU-0002lz-2E; Thu, 08 Sep 2022 13:05:12 +0000 Received: by outflank-mailman (input) for mailman id 403340; Thu, 08 Sep 2022 13:05:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHDT-0002lt-CS for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:05:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHDT-0007yY-1M; Thu, 08 Sep 2022 13:05:11 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWHDS-0001eW-Qp; Thu, 08 Sep 2022 13:05:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Fw8v5mgnt+uiUQd92P1rz9Q7nfubChtbVYoUo+pWhQw=; b=tupAL+dQn+7/MujVxkncL1X8ND BpiHaZ47DwSWY/lEcCBZjVV/UBKLttiQDZpic2wi2ZqTDW4qmS1FM9WHbGXuBsKaE0RJ+SYdFi7be 3sutSffsGDYFVMn7JVeawvTSEKdagXgLfnJevIZaR/8b2sGuYSbYMYUzdGy3AKCRLYic=; Message-ID: Date: Thu, 8 Sep 2022 14:05:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] docs/device-tree: Place the static-heap dt-binding in proper place Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220908120728.8290-1-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220908120728.8290-1-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 08/09/2022 13:07, Henry Wang wrote: > The static-heap dt-binding should be placed after the last feature, > namely static-evtchn. > > Fixes: 4596329291f5 ("docs, xen/arm: Introduce static heap memory") > Signed-off-by: Henry Wang Thanks for fixing the mistake I did while committing the patch :). Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:08:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:08:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403348.645426 (Exim 4.92) (envelope-from ) id 1oWHGl-0003Q6-KC; Thu, 08 Sep 2022 13:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403348.645426; Thu, 08 Sep 2022 13:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHGl-0003Pz-Gy; Thu, 08 Sep 2022 13:08:35 +0000 Received: by outflank-mailman (input) for mailman id 403348; Thu, 08 Sep 2022 13:08:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHGk-0003Pt-OI for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:08:34 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00056.outbound.protection.outlook.com [40.107.0.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57a5a675-2f77-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:08:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6408.eurprd04.prod.outlook.com (2603:10a6:20b:fe::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 8 Sep 2022 13:08:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 13:08:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57a5a675-2f77-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+HOvvABwF7y48ieTVDjz11JGunpV1poH85wxSAGW6lEXoixaAsNA5X1A5JXxSDBDlgs3t1kQhPtZigWPDkATXA4VZG2/1dkO+L9CmdTaqd3O5DhDnmryTt27lj8n3LktGrExdbUC/x/WykvcqztMonYxE4zZB6w3sc0GlcR7DYpH/G+6OQMcxbmoSMjJS3Kzh4z0UAJ+hPalFnXGfaf3/aLX3YRr7BWZVUESbfqpZE9a4HlQ+1w3jp3QLlvc+nnHMkfTXLpyytzTjbkU4I1POKFZp0fGlOR8khXKjvJaKgDK2uEgak7mckxn1ENlrVI4qo7F+NfDI1E3k4og9iIEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nd080d/W96RLhwf4IfX72LwUsiztqY2/mwC0sYSn8ys=; b=A4bDBy8s+UqHd6f9CQ+NmlL9LIBSvRZmhzawItme/2KICEPb8Yk0G0KUyKFsqPud2TEvulyHPUXsZe7HM2Ku0hHFPqzPhLgUVdxAfLTXXgV+cZndWpWbqQ4Eu4DSwgHZQVzXZn1Di+P9MfHDJqoBpGfF7jxi6Tqy3HNKCR96LbsABDc2ceEUJEC2OogH1z9frUsUXZbFBdLN3oax9VifO87TYswp13Pnx6cE5ceh2I91TJH4SA1to6K4KSjFJqeO9Dd722nWJerReIe5w1rD8ThuoNPPecjW/d35ja4LFGwPspn7GN3Bf6DVXMR2aXzrR/BDBl0U8og7Yrbq8Sq5/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nd080d/W96RLhwf4IfX72LwUsiztqY2/mwC0sYSn8ys=; b=VjQvSLnT5sPQS4VG+UHDzqujV+2i8T0u3nku3mYfKDdeFVNtwWvK5/DkNUhc/3krQxBnbXmwnTRA7oziIl2CqCIqZZeMXqbaYiUfpLcncyndrbXkKFYS55ZWxVlrlwIrPOd5BeYLsXHDGSd/KDA22nSNxyEitx1unnPo7d3+d7kMqbBJS5JLly72DvjRDrkl94HGeoNNiLSfTP/5mTqDwJBrwj3wkVwWP7jRGSqGr1Yy9QIJzsBNUSWgawxpobabAsuq9MFW8mWYcKPI4qUWgCUoLGs64VlDEA8iphCTXryB1v7kLtNa20lSGa7rgp18eJWkKt/7fd8kKZCdFGU83w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 8 Sep 2022 15:08:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/locks: add dynamic lock recursion checks Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220908074619.18221-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220908074619.18221-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0046.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM6PR04MB6408:EE_ X-MS-Office365-Filtering-Correlation-Id: 58c48967-847f-43f8-7a4c-08da919b3a1a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBbGre+IkcQMjCAKpyQ+RkeOTYN4VAXbxx8FslYQ53J019EmbjkWNFJdy4iZEYhfy3tjSUsbijezXPB+DMltrwvtdNnql45hbTkUxk8ExIFJ7XRZQ9ELIhXCpJeEQRDT58N95KNPTyny/iAQfZsgWEhrcbkqSDtXfMSZLc2uSI1roUlV07+2bhKkS6IOj2RO+9PCvQWi/4ORd+tC9srE7WOgp5IqnpeG8v+6lFyp5h9XcPv4c+CVHnsY9v8jgd3PO5IXziGRJoUOumhSKPr/NdBw9JD+VlXUqDbE3pq2m1kPG9C5l+6gfYXikWxGqMfIdTdAxHNmHiRRLLceT86aBbLuZ6Mz4jP7Li1sNqVl9lrglEuCiCDFuCxhEumFvbR54FUkIgmnOoL72h5m/svC/EVvxKHGjSHmPWMsXZo5pnDC7b1gXn6WCqrRxJqFFAqt8zL6FKN2Zjo4O+JJFGA+DvwPC+eUFw/3AM1Vv+kcFzedWgO1DCxWHQErf3FgwJGQJny0O1iIy8W2tc2hnhdZO58JW8L0gB4oYxcO09x4Dw2wKRlvrb5rsTf07irL/j3+c46EbdSIBuXsgOgoQ2UBN0sFxH7WWocvLegr3pr6joub7m667XnRj47oGJGBGtCdtj1Vv6wuCaAKkFRZwl5xiz8WCi06EthaWSzcRo6IMkaiHbO9buJy+EJJ6R40UFH0Tlq9fiuQfqa4iosLBpe//g7petU+oVep/9yq2MhD/329ek0ChcHmZca+g4EFykycDo2RK/sk35IheTlKG+Y4t21Ccm+RvQDaNTXXwGj8dEo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(346002)(396003)(376002)(136003)(8676002)(83380400001)(66946007)(8936002)(5660300002)(66556008)(6862004)(66476007)(6666004)(26005)(6506007)(478600001)(41300700001)(186003)(6486002)(2616005)(4326008)(53546011)(86362001)(37006003)(6636002)(54906003)(316002)(31696002)(31686004)(6512007)(36756003)(2906002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlY0SWtOMzNIRmMwZmJYK0N0V0k2RlE2cElFY1RFK2h0WVhlVjlkZXUxWUlS?= =?utf-8?B?U2w1aGoxSWd6Y2RVZW5RR0MyUHlvOGxEZXVZK1h4N3BZcjMxUjlkSFVKRW56?= =?utf-8?B?dUhTQUtTRlJ3YWMvOXo5c0pwQ1F1OWt2Z1VQVm1rQVdsNTZnSHBYand4eTky?= =?utf-8?B?OTJqbjd1aHM4MldENmdkOW1pUVROeEUyV0RzUXNseWFFQm9PQ0lWWG9WSTFZ?= =?utf-8?B?cWlEdHJad3YxQWc4YWU3L3c0TmV1UFl2V3dsVGxyZ3Q0bzlaSy9BVjhqRnMz?= =?utf-8?B?NDNqNjVyNjUyclJvTkZGWW1sMFR0V0xBRm8wVWYrZVNZNjY1ZGQ0ZDRLZElv?= =?utf-8?B?Y3JRaHJwRjZiVW9peVNoRnc2Vm9Wa2pVanVQamZZS2poWlE0bTlBSTQwL0h4?= =?utf-8?B?ZTJDOWZYdDNQV2pwYjRUNTJIb2IyN0RzQ1JBQUs0MlREZS8vdk85bUtFTndJ?= =?utf-8?B?RURsZ2NBYVdiKzlhVXZhZDZONFQvbnBUMnhvKzFqd2NXdTg2Sk80eGNzekIx?= =?utf-8?B?NEhnUWgxM2lyWlVubkZRS2Z5VFpvMjFoSzBqVkcvV3NjVm9kK3F6VWFDUnhZ?= =?utf-8?B?NWxpYzZSTkxnQ25jWVNpUml3L0NHTTVudjZCdFEyV1ZjaG5uMGZPbzhWOFd2?= =?utf-8?B?a3N4RWJacUFBY0lIYVN3RlRoOXk0NWM2ak5jWEFud2ZnOVc2enVNazU5ZE1M?= =?utf-8?B?bXFnK0ptalJQQ3RYcTUvaGJqWGdmalFaZnkyWi9mK1VZSU03TlpTZVhSd1l6?= =?utf-8?B?Q2h1RTVrMElZdDdZRTdtUGx1bS9oc290L1BDZEVvRnp1T3VvTm1xR29zMVM3?= =?utf-8?B?OExiUVVlUXhObGhJT1RFQUtzczByWXlkUndNVGhrVTVCbWpIRi92SzFQbDRl?= =?utf-8?B?VjNJS1A3aEJZckZNSW5sTnkrbTliZUZoRDJvZmdGZTAxRXYxQ0xyS3h2cTNq?= =?utf-8?B?TGpPUmF5ZE4rVjBReU5PYTU5cUJTOEZHTjhxSkYveEEyRWJOb1lwVFFmLzZ6?= =?utf-8?B?VEt3QlkwVHlVeWFFL3lWS2x4ZXNnOExuRDJJb2lEWTFqaGY2cGp2UVJuSldC?= =?utf-8?B?cUpad2V6ZWR6UWhQL1M5VE11Nkd5VFl6U2g4czdTWENkaERnYzFteGpCbUVT?= =?utf-8?B?Vy9ITC8wM0pQekRXTmRjdW9xNHVXQXN6dWVxWVhTRktwdGFINkRHd0RIWWJi?= =?utf-8?B?VVdKT1dOSHdwb0NFb1lCeWt6WmNZc1dFZGx2ZXRXY0JwUmp2Y1ByRGU2TUVk?= =?utf-8?B?blpnTG9pRXUyT1ZOMDRLaFlVNDZzWkoxODNPNHNuTjIwNVJXdkxHNjZlQnhy?= =?utf-8?B?UVBRbllqZmdvWkZmUFl5c2VmbitmdUNjVmthc2szZmJNcDcycE5SaGlFSDBj?= =?utf-8?B?RHBmaUxEeDRMNXN1WHpoMGZZeXRiTk1CdFhEZGtWRUhWbFZ3NGNiN3k0citU?= =?utf-8?B?azJpb2EzSnhOTTdQLzEvS3ZnNGxQQlhpSHlaZDhZL1ZvekFxUmJWQk5PZk9j?= =?utf-8?B?eWtxK0tuZ25YWXZHMW9lR01CYjYwcDZvNTFVTDBWaExMSkdsNEhIMTRnNmJF?= =?utf-8?B?RlV5MjFBdWhIendydDlScHUraGVFSyt1WTExM2kxR0g2c3VKWGU3UWwwNGZD?= =?utf-8?B?NXV4ZlkzMUFzUWxCL0ZjSkMwQStsdXJ6L2QxQUhmemtqZForVW00QmpSU1l1?= =?utf-8?B?L0RSdEV4eVZLQi9qNlIyYWhIbGNLbWkyRDgycUNwaTRSVWpBeVN1cmVENW1P?= =?utf-8?B?YmxnWmpZZFc2UDlCekFkR29FS09QczJFMytvWDBzbE4rZ1c5VmQyb3Fuak9v?= =?utf-8?B?NXZZbXFmeUxuWU1XOE5xZ1RCMmFEdFo3TmdKTHVQMjNVNnM4VWFub2NRM08y?= =?utf-8?B?bU9jZUd6TnluL25YS3FTSWllM1NrS005V3UyNTI4WGc4aWUwNUp2Qllvcm5L?= =?utf-8?B?L0VwZDZLTTNrTlNIeEgrODF0NlhyS3dGc1dHbzcyY3RXVnQ0TXEwaU1iRUV2?= =?utf-8?B?ZnNTRFVNQkNPY3ZpZEwzK2NSandUc3NvclA2M3ZzWk43MnpOL29GMFFNbktj?= =?utf-8?B?djFJQXg1U1FYMGlmNEpmQm8rdUZYQ0RUZkkySGtjK3R5OTFKNXJnN2Rlb2lw?= =?utf-8?Q?WuxBe7ga2cIsuIoso769qmuVw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58c48967-847f-43f8-7a4c-08da919b3a1a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 13:08:30.8681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jfuiu0FzU4GU84Eh1KwIC3JnmbqtuhbKEFtPstuaApJq+sF7YWwouhvl3h26QYtVmXl/PVVQwncoX4F0NeB/OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6408 On 08.09.2022 09:46, Juergen Gross wrote: > Add checking of lock recursion to the hypervisor. This is done by using > a percpu data array for storing the address of each taken lock. Any > attempt to take a lock twice (with the exception of recursive > spinlocks) will result in a crash. This is especially meant for > detecting attempts to take a rwlock multiple times as a reader, which > will only result in a deadlock in case of another cpu trying to get the > lock as a writer in between. > > The additional checks are not performance neutral, so they are enabled > only in debug builds per default, as the checks are active only with > CONFIG_DEBUG_LOCKS enabled. The size of the percpu data array can be > selected via a boot parameter. > > Signed-off-by: Juergen Gross > --- > Further possible enhancements: > - record address or file/line of locker, too > - add sanity check when exiting hypervisor or going to idle that all locks > have been released > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich But left in the queue for 4.18, ftaod. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:14:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:14:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403358.645437 (Exim 4.92) (envelope-from ) id 1oWHMZ-00054p-DK; Thu, 08 Sep 2022 13:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403358.645437; Thu, 08 Sep 2022 13:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHMZ-00054i-AY; Thu, 08 Sep 2022 13:14:35 +0000 Received: by outflank-mailman (input) for mailman id 403358; Thu, 08 Sep 2022 13:14:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHMY-00054c-0r for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:14:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHMT-00086k-SG; Thu, 08 Sep 2022 13:14:29 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.18.179]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWHMT-0002C8-JR; Thu, 08 Sep 2022 13:14:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yF6/yeeIE81nNRAhGJCD0a0Uor+iQU65ICW6+rpB1VA=; b=VFIeL9YGaFbOmvVxGnGgx0ksdG uqbfuOsyIFzU5ZSmL8sNOtpMnOysFpUfuEdn3eLxEisFgPxTcJPJ+wLFcX57JccEmuR9KhGZlWYkr GyPv/me5CyHkRsoSWHFm9kabAfozdiMeDUqaleZlqQqWtTeIr3DGw8ZHIkhB0VBiNRNI=; Message-ID: <44571dff-bb8a-b0f5-8913-c35b9aa4544a@xen.org> Date: Thu, 8 Sep 2022 14:14:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Content-Language: en-US To: Jan Beulich , Rahul Singh , Bertrand Marquis Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> <5db80611-c968-34c7-7181-41071636efca@suse.com> From: Julien Grall In-Reply-To: <5db80611-c968-34c7-7181-41071636efca@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 08/09/2022 13:03, Jan Beulich wrote: > On 08.09.2022 13:49, Rahul Singh wrote: >> is_memory_hole was implemented for x86 and not for ARM when introduced. >> Replace is_memory_hole call to pci_check_bar as function should check >> if device BAR is in defined memory range. Also, add an implementation >> for ARM which is required for PCI passthrough. >> >> On x86, pci_check_bar will call is_memory_hole which will check if BAR >> is not overlapping with any memory region defined in the memory map. >> >> On ARM, pci_check_bar will go through the host bridge ranges and check >> if the BAR is in the range of defined ranges. >> >> Signed-off-by: Rahul Singh >> Acked-by: Jan Beulich # x86, common > > FTAOD: I object to this tagging, and I did not provide the ack with > such tags. Quoting docs/process/sending-patches.pandoc: "The > `Acked-by:` tag can only be given by a **maintainer** of the modified > code, and it only covers the code the maintainer is responsible for." You are part of the REST. So technically, one could assume that your acked-by would also cover the Arm. I agree this would be uncommon but this has been used before when the more specialized maintainer was unresponsive. At least with # x86, common it is clear what you are happy with. > The doc provides for tagging here, yes, but such should only be used > for the unusual case of an ack restricted to less than what a > person's maintainership covers. Otherwise we'd end up seeing overly > many tagged acks. I appreciate you may not like them but it helps while committing because you can cross-check easily whether all the files have been covered with the tags. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:15:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403361.645448 (Exim 4.92) (envelope-from ) id 1oWHMz-0005W8-O8; Thu, 08 Sep 2022 13:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403361.645448; Thu, 08 Sep 2022 13:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHMz-0005W1-Kz; Thu, 08 Sep 2022 13:15:01 +0000 Received: by outflank-mailman (input) for mailman id 403361; Thu, 08 Sep 2022 13:15:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHMz-0005NL-4r for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:15:01 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3cc3f604-2f78-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:14:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cc3f604-2f78-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662642899; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QHACZeHQLuGgufpcNAkKJ8fvLFdqoUPLAp2O4ex5vAM=; b=X1jL6ZIdoJ6IC/DHEgoPSvzU9BVOBWhcP4lleD/HCy7bR1LKC/XZxI2j p6BcMyCiIj/fbwk8dsmmricM4EBb7m5x024NgQkA4YSW0AQ1qZaNTsGZK bMe/EfT9w/4AI/eO8AyG3HzKX7wddxDGDsBhJYsIbzxkD2V6/6BmiyEhU Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79752218 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:oSu5DK5VsFIkfZ1i6+E8bgxRtDDHchMFZxGqfqrLsTDasY5as4F+v mccUDzQbvmLNGryL4x2Pdng8UlQvpSHn4RmGQprqXw8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ks+5KSq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJB41JKA8oepYOzlHz NgnJBdVUhmapcvjldpXSsE07igiBMziPYdZsXB81zDJS/0hRPgvQY2Tu4Uehm1pwJkTQ7COP KL1ahI2BPjESxRJJlcQDoN4hOqyj2PzWzZZtEiUtew85G27IAlZj+mybYCPI4ziqcN9nAGi/ mmd3kfDLDIDaN6fxjjZ33yNmbqa9c/8cN1LT+DpnhJwu3WJwXcZEhoRVl2Trvywi0r4UNVaQ 2QW9TAptrMa71GwQ5/2WBjQiGGAlg4RXZxXCeJSwAOEzKbO8huaLmcBRz9FLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxmvw CmniHMyqI9LhPcv6KmcpWzOmhCF882hohEO2unHYo60xlonOtT7PNXztQezAeVod9jAEATY1 JQQs43Htb1VU8nQ/MCYaL9VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX aMyhe+yzMUJVJdSRfUrC79d8uxzpUQaKfzrV+rPcv1FaYVreQmM8UlGPBDOhT2yzRd8yv1mZ /93lPpA6l5DUMxaIMeeHb9BgdfHOAhlrY8seXwL50v+iufPDJJkYbwELEGPfogE0U9wmy2Mq o43Cid/408AOAEISnWIrNV7wJFjBSRTOK0aXOQGKbXTeVQ5RTxJ5j246epJRrGJVp99zo/gl kxRkGcBoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:YtNMIKBCUcuNNVzlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.93,300,1654574400"; d="scan'208";a="79752218" Date: Thu, 8 Sep 2022 14:14:43 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" Subject: Re: [PATCH 3/3] xl/libxl: Add OEM string support to smbios Message-ID: References: <20220810194827.103428-1-jandryuk@gmail.com> <20220810194827.103428-4-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220810194827.103428-4-jandryuk@gmail.com> On Wed, Aug 10, 2022 at 03:48:27PM -0400, Jason Andryuk wrote: > Add support for OEM strings in the SMBIOS type 11. > > hvmloader checks them sequentially, so hide the implementation detail. > Allow multiple plain oem= items and assign the numeric values > internally. > > Signed-off-by: Jason Andryuk > --- > docs/man/xl.cfg.5.pod.in | 4 ++ > tools/golang/xenlight/types.gen.go | 99 ++++++++++++++++++++++++++++++ > tools/libs/light/libxl_types.idl | 99 ++++++++++++++++++++++++++++++ > tools/xl/xl_parse.c | 15 +++++ > 4 files changed, 217 insertions(+) > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index 7edf5d23f3..7947bf07ea 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -2104,8 +2104,12 @@ Each B is a C string from the following list: > > =item B > > +=item B > + > =back > > +oem= strings can be specified mutiple times up to a limit of 99. This could be move to just before =back I think. > + > =item B > > Provide a VM generation ID to the guest. > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index d04207748e..58f404af37 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -436,6 +436,105 @@ libxl_smbios_type = Enumeration("smbios_type", [ > (15, "enclosure_asset_tag"), > (16, "battery_manufacturer"), > (17, "battery_device_name"), > + (18, "oem_1"), > + (19, "oem_2"), > + (20, "oem_3"), [...] > + (115, "oem_98"), > + (116, "oem_99"), Instead of this long lists of enum value, could we just have one "oem" type, and allow it to be used more than once? I know that would mean having a special case in libxl, but that also mean that libxl will be the only one to deal with the implementation detail on how to write oem string for hvmloader (as opposed to deal with this in every application using libxl). > ]) > > libxl_smbios = Struct("smbios", [ > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 4f3f962773..fb7f1f6867 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1787,12 +1787,16 @@ void parse_config_data(const char *config_source, > switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) > { > case 0: /* Success */ > + { > + unsigned int num_oem = 1; > + > b_info->u.hvm.num_smbios = num_smbios; > b_info->u.hvm.smbios = xcalloc(num_smbios, sizeof(libxl_smbios)); > for (i = 0; i < num_smbios; i++) { > char *option_untrimmed, *value_untrimmed; > char *option, *value; > libxl_smbios_type v; > + char oem_buf[] = "oem_99"; > > buf = xlu_cfg_get_listitem(smbios, i); > if (!buf) continue; > @@ -1807,6 +1811,16 @@ void parse_config_data(const char *config_source, > trim(isspace, option_untrimmed, &option); > trim(isspace, value_untrimmed, &value); > > + if (strcmp(option, "oem") == 0) { > + if (num_oem > 99) { > + fprintf(stderr, "xl: sbmios oem strings limited to 99\n"); > + exit(-ERROR_FAIL); > + } > + sprintf(oem_buf, "oem_%d", num_oem); > + num_oem++; > + option = oem_buf; This mean that my proposal to free option in the previous patch isn't going to work well. But you could free option before assigning a new value. An alternative to generate a string to be converted to an enum value would be to simply do "LIBXL_SMBIOS_TYPE_OEM_1+num_oem-1". Or just deal with oem string in libxl as proposed above. > + } > + > e = libxl_smbios_type_from_string(option, &v); > if (e) { > fprintf(stderr, > @@ -1819,6 +1833,7 @@ void parse_config_data(const char *config_source, > b_info->u.hvm.smbios[i].value = value; > } > break; > + } > case ESRCH: break; /* Option not present */ > default: > fprintf(stderr,"xl: Unable to parse smbios options.\n"); Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:50:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:50:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403373.645459 (Exim 4.92) (envelope-from ) id 1oWHur-0001Rn-GI; Thu, 08 Sep 2022 13:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403373.645459; Thu, 08 Sep 2022 13:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHur-0001Rg-CP; Thu, 08 Sep 2022 13:50:01 +0000 Received: by outflank-mailman (input) for mailman id 403373; Thu, 08 Sep 2022 13:50:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWHup-0001Ra-TJ for xen-devel@lists.xen.org; Thu, 08 Sep 2022 13:50:00 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c786709-2f7d-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:49:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c786709-2f7d-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662644985; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WTWJeHaJMMC/+qrhcERcfsYiSD2yI/KRfMGHIF3psOM=; b=FCkfesZhjbDxGmDk2JldPztZzWrEGLUDnhKQpooC+vBartpjsei+cfI2 WvsZijCRt5kl4nWSBcYoWy7Q7dVGMNhtzxw0NdanfHjExyNGuIGZH3xFY LhUhrvhllMy651lhTPCI1SMirmc9qn6iA1t34Po9NvR57mzGEu5BcS3J2 c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79228995 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/iCwv6CqPVwwWhVW/2jkw5YqxClBgxIJ4kV8jS/XYbTApDJ03zVRz mBJWG7TPPzYYmfxedB1OY2y9UIFvMeBx9A2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFs/Lb8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW0fl3dplNQYSB6kJ1tl6C1N27 aA7BS9YO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDmJllwggeWF3Nz9RP2ABphvpn+ku 2/+wE6gBDcjMeOY8G/Qmp6rrrCWxn6qMG4IL5W/8vNpm0GC3Ww7BxgfVF/9qv684ma7WtFSb UwT/i8jtoA29UqiVN67WAe3yFaBtwIcWtdNVfU96RuMx7D85wefD3IDCDVGbbQOttIyRDEs/ k+EmZXuHzMHmL+aU3WG7Z+PsCi/fyMSKAcqeissXQYDpd75r+kbkBPJRdtlDOi6k9zpBTbs6 zSLqiEkgPMUl8Fj/7W2+xXLjiyhorDNTxUp/UPHU2Tj6Rl2DKa7Zpal8lid7utFJZyxSliHt WID3c+E44gmFo2AmiWLR6MWALij6vKBMTvdqU5uG5gn53Km/HvLVYlU7SE4LkpvNMsJUTvoZ kbJvkVW/pA7FGC2d6ZrZJn0B8k05a/4UNDkTezPKN5PZJFrc0mA5i4GWKKL9zmzyg52y/h5Y MrFN5b3ZZoHNUh55Aa/WcgW6PgP/AQv6VzeT6LD10iE/KXLMRZ5Vow53EuygvERtf3a+luOq o0DaKNm2D0EDrSgP3C/HZo7aAlTcCNlXc2eR9l/LLbrH+ZwJI025xY9K5sFcpctoalan/ygE pqVCh4BkwqXaZEqxGy3hpFfhFDHB8wXQYoTZ3BEALpR8yFLjXyTxKkebYArWrIs6fZuy/V5J 9FcJZvaX6sSFWScp21DBXUYkGCFXE3y7T9iwgL/OGRvF3Keb1ehFiDYkvvHq3BVU3vfWToWq Ly8zALLKac+q/BZJJ+PMJqSI6aZ5yd1dBRaAxSVebG+uSzErOBXFsAGpqVsepxdck+emGPyO sT/KU5wmNQharQdqLHh7Z1oZa/yeweiNiK2x1Xm0Is= IronPort-HdrOrdr: A9a23:Yuzwb6wn3KrZfJ62Hz3pKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU= X-IronPort-AV: E=Sophos;i="5.93,300,1654574400"; d="scan'208";a="79228995" Date: Thu, 8 Sep 2022 14:49:16 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device Message-ID: References: <8b47d98cec83ca33a2b409c9371356820dd91b7a.1661159474.git.viresh.kumar@linaro.org> <20220907123224.rz7vvope37l6l6mg@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220907123224.rz7vvope37l6l6mg@vireshk-i7> On Wed, Sep 07, 2022 at 06:02:24PM +0530, Viresh Kumar wrote: > Hi Anthony, > > Thanks a lot for the in-depth review, it is really helpful. > > I don't have much knowledge of the Xen code and wanted this code for I2C and > GPIO to be tested on Xen for the work we are doing around hypervisor agnostic > backends [1]. > > I started looking for a simple device's implementation and began by (blindly) > copying code from Keyboard device and so much of wasted code in here, which > isn't really required. > > On 06-09-22, 17:15, Anthony PERARD wrote: > > On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote: > > > An example of domain configuration for Virtio I2c: > > > i2c = [ "" ] > > > > Is this doing something meaningful (with the whole series applied)? > > If I am not wrong, this is required by parse_i2c_list()'s implementation. > Without this I don't get the I2C device populated in the guest. Sorry, I should have added more context to may question. In my mind, I2C is just a communication protocol between a device and a CPU, like USB or PCI. So to me there is missing information about which device or kind of device to present to a guest in this example. For example, for PCI we give a path to the device (via bdf=), and for USB it can be a kind of device to emulate or select a device based on the path to it (bus, addr). Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:55:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403380.645470 (Exim 4.92) (envelope-from ) id 1oWI08-0002rV-3q; Thu, 08 Sep 2022 13:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403380.645470; Thu, 08 Sep 2022 13:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI08-0002rO-11; Thu, 08 Sep 2022 13:55:28 +0000 Received: by outflank-mailman (input) for mailman id 403380; Thu, 08 Sep 2022 13:55:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI07-0002rI-3S for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:55:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id e3467852-2f7d-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:55:25 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3E4A106F; Thu, 8 Sep 2022 06:55:30 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1056D3F7B4; Thu, 8 Sep 2022 06:55:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3467852-2f7d-11ed-a31c-8f8a9ae3403f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v8 0/9] static shared memory on dom0less system Date: Thu, 8 Sep 2022 21:55:04 +0800 Message-Id: <20220908135513.1800511-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit **This series is based on the "Introduce static heap" series[1]** In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. [1] https://lore.kernel.org/xen-devel/20220908042538.27076-1-Henry.Wang@arm.com/ Penny Zheng (9): xen/arm: introduce static shared memory xen/arm: assign static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 xen: Add static memory sharing in SUPPORT.md SUPPORT.md | 7 + docs/misc/arm/device-tree/booting.txt | 132 ++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 167 ++++++++++ xen/arch/arm/domain_build.c | 421 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/setup.h | 7 + xen/arch/arm/mm.c | 42 ++- xen/common/domain.c | 3 + 10 files changed, 781 insertions(+), 9 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:55:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:55:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403382.645480 (Exim 4.92) (envelope-from ) id 1oWI0L-0003B3-Am; Thu, 08 Sep 2022 13:55:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403382.645480; Thu, 08 Sep 2022 13:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0L-0003Aw-8D; Thu, 08 Sep 2022 13:55:41 +0000 Received: by outflank-mailman (input) for mailman id 403382; Thu, 08 Sep 2022 13:55:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0K-0002rI-1k for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:55:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id eb913d8e-2f7d-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:55:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B063C153B; Thu, 8 Sep 2022 06:55:44 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8D1173F7B4; Thu, 8 Sep 2022 06:55:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb913d8e-2f7d-11ed-a31c-8f8a9ae3403f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Julien Grall Subject: [PATCH v8 4/9] xen/arm: introduce put_page_nr and get_page_nr Date: Thu, 8 Sep 2022 21:55:08 +0800 Message-Id: <20220908135513.1800511-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit introduces a set of new helpers put_page_nr() and get_page_nr() to increment/drop the page reference by nr. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall --- v8 change - no change --- v7 change: - no change --- v6 change: - no change --- v5 change: - no change --- v4 changes: - fix the assert about checking overflow to make sure that the right equation return is at least equal to nr - simplify the assert about checking the underflow --- v3 changes: - check overflow with "n" - remove spurious change - bring back the check that we enter the loop only when count_info is greater than 0 --- v2 change: - new commit --- xen/arch/arm/include/asm/mm.h | 4 ++++ xen/arch/arm/mm.c | 42 +++++++++++++++++++++++++++-------- 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 7b4f6ce233..d8553ad207 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -360,6 +360,10 @@ void free_init_memory(void); int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order); +extern bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr); +extern void put_page_nr(struct page_info *page, unsigned long nr); + extern void put_page_type(struct page_info *page); static inline void put_page_and_type(struct page_info *page) { diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 4a70ed2986..535c465672 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1461,21 +1461,29 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } -struct domain *page_get_owner_and_reference(struct page_info *page) +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, + unsigned long nr) { unsigned long x, y = page->count_info; struct domain *owner; + /* Restrict nr to avoid "double" overflow */ + if ( nr >= PGC_count_mask ) + { + ASSERT_UNREACHABLE(); + return NULL; + } + do { x = y; /* * Count == 0: Page is not allocated, so we cannot take a reference. * Count == -1: Reference count would wrap, which is invalid. */ - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) + if ( unlikely(((x + nr) & PGC_count_mask) <= nr) ) return NULL; } - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); owner = page_get_owner(page); ASSERT(owner); @@ -1483,14 +1491,19 @@ struct domain *page_get_owner_and_reference(struct page_info *page) return owner; } -void put_page(struct page_info *page) +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + return page_get_owner_and_nr_reference(page, 1); +} + +void put_page_nr(struct page_info *page, unsigned long nr) { unsigned long nx, x, y = page->count_info; do { - ASSERT((y & PGC_count_mask) != 0); + ASSERT((y & PGC_count_mask) >= nr); x = y; - nx = x - 1; + nx = x - nr; } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); @@ -1503,19 +1516,30 @@ void put_page(struct page_info *page) } } -bool get_page(struct page_info *page, const struct domain *domain) +void put_page(struct page_info *page) +{ + put_page_nr(page, 1); +} + +bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr) { - const struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); if ( likely(owner == domain) ) return true; if ( owner != NULL ) - put_page(page); + put_page_nr(page, nr); return false; } +bool get_page(struct page_info *page, const struct domain *domain) +{ + return get_page_nr(page, domain, 1); +} + /* Common code requires get_page_type and put_page_type. * We don't care about typecounts so we just do the minimum to make it * happy. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:55:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:55:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403383.645491 (Exim 4.92) (envelope-from ) id 1oWI0O-0003Tv-NV; Thu, 08 Sep 2022 13:55:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403383.645491; Thu, 08 Sep 2022 13:55:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0O-0003Tm-Ji; Thu, 08 Sep 2022 13:55:44 +0000 Received: by outflank-mailman (input) for mailman id 403383; Thu, 08 Sep 2022 13:55:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0N-0002rI-KC for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:55:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id eda87057-2f7d-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:55:42 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13AE8153B; Thu, 8 Sep 2022 06:55:48 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E45EF3F7B4; Thu, 8 Sep 2022 06:55:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eda87057-2f7d-11ed-a31c-8f8a9ae3403f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Julien Grall Subject: [PATCH v8 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated Date: Thu, 8 Sep 2022 21:55:09 +0800 Message-Id: <20220908135513.1800511-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini Acked-by: Julien Grall --- v8 changes: - no change --- v7 changes: - change "unsigned long bank" to "unsigned int bank" --- v6 change: - adapt to the change of "nr_shm_borrowers" - add in-code comment to explain if the borrower is created first, we intend to add pages in the P2M without reference. --- v5 change: - no change --- v4 changes: - no change --- v3 change: - printk rather than dprintk since it is a serious error --- v2 change: - new commit --- xen/arch/arm/domain_build.c | 60 +++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fe0a96764d..4aab9b0865 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -761,6 +761,30 @@ static void __init assign_static_memory_11(struct domain *d, } #ifdef CONFIG_STATIC_SHM +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned int bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( (pbase == bank_start) && (psize == bank_size) ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + + return 0; +} + /* * This function checks whether the static shared memory region is * already allocated to dom_io. @@ -827,6 +851,8 @@ static int __init assign_shared_memory(struct domain *d, { mfn_t smfn; int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; dprintk(XENLOG_INFO, "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -840,6 +866,7 @@ static int __init assign_shared_memory(struct domain *d, * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need * to create mapping in the P2M. */ + nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, @@ -851,6 +878,39 @@ static int __init assign_shared_memory(struct domain *d, } } + /* + * Get the right amount of references per page, which is the number of + * borrower domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of letting borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + * So if the borrower is created first, it will cause adding pages + * in the P2M without reference. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:55:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403384.645503 (Exim 4.92) (envelope-from ) id 1oWI0R-0003os-2Z; Thu, 08 Sep 2022 13:55:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403384.645503; Thu, 08 Sep 2022 13:55:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0Q-0003oj-TH; Thu, 08 Sep 2022 13:55:46 +0000 Received: by outflank-mailman (input) for mailman id 403384; Thu, 08 Sep 2022 13:55:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0Q-0002rI-4B for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:55:46 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ef5b5895-2f7d-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:55:45 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C10B106F; Thu, 8 Sep 2022 06:55:51 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 475E03F7B4; Thu, 8 Sep 2022 06:55:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef5b5895-2f7d-11ed-a31c-8f8a9ae3403f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v8 6/9] xen/arm: set up shared memory foreign mapping for borrower domain Date: Thu, 8 Sep 2022 21:55:10 +0800 Message-Id: <20220908135513.1800511-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - no change --- v7 change: - no changes --- v6 change: - no change --- v5 change: - no change --- v4 changes: - no change --- v3 change: - use map_regions_p2mt instead --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mapping now. --- xen/arch/arm/domain_build.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4aab9b0865..a10d07266b 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -990,6 +990,15 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } } return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 13:55:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 13:55:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403387.645514 (Exim 4.92) (envelope-from ) id 1oWI0X-0004Fw-Az; Thu, 08 Sep 2022 13:55:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403387.645514; Thu, 08 Sep 2022 13:55:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0X-0004Fi-71; Thu, 08 Sep 2022 13:55:53 +0000 Received: by outflank-mailman (input) for mailman id 403387; Thu, 08 Sep 2022 13:55:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWI0W-0002rI-6n for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 13:55:52 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id f2f5e8ca-2f7d-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 15:55:51 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21105106F; Thu, 8 Sep 2022 06:55:57 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 787F03F7B4; Thu, 8 Sep 2022 06:55:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2f5e8ca-2f7d-11ed-a31c-8f8a9ae3403f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v8 8/9] xen/arm: enable statically shared memory on Dom0 Date: Thu, 8 Sep 2022 21:55:12 +0800 Message-Id: <20220908135513.1800511-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - no change --- v7 changes: - no change --- v6 change: - no change --- v5 change: - no change --- v4 change: - no change --- v3 change: - no change --- v2 change: - no change --- xen/arch/arm/domain_build.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index cd03370b38..8c77c764bc 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2705,6 +2705,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( res ) + return res; } res = fdt_end_node(kinfo->fdt); @@ -3780,6 +3785,9 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; +#ifdef CONFIG_STATIC_SHM + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); +#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -3814,6 +3822,12 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, &kinfo, chosen); + if ( rc < 0 ) + return rc; +#endif + /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); if ( rc < 0 ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 14:55:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 14:55:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403415.645524 (Exim 4.92) (envelope-from ) id 1oWIwC-00045D-PR; Thu, 08 Sep 2022 14:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403415.645524; Thu, 08 Sep 2022 14:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWIwC-000456-Md; Thu, 08 Sep 2022 14:55:28 +0000 Received: by outflank-mailman (input) for mailman id 403415; Thu, 08 Sep 2022 14:55:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWIwA-000450-PM for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 14:55:27 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140077.outbound.protection.outlook.com [40.107.14.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44dcbb50-2f86-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 16:55:25 +0200 (CEST) Received: from FR3P281CA0176.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::11) by DB9PR08MB7422.eurprd08.prod.outlook.com (2603:10a6:10:371::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 8 Sep 2022 14:55:21 +0000 Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a0:cafe::75) by FR3P281CA0176.outlook.office365.com (2603:10a6:d10:a0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.6 via Frontend Transport; Thu, 8 Sep 2022 14:55:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 14:55:20 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 08 Sep 2022 14:55:19 +0000 Received: from f271bd90c72d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91D5EAD7-2968-4A3C-9953-DE3B1C21B17D.1; Thu, 08 Sep 2022 14:55:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f271bd90c72d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 14:55:13 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Thu, 8 Sep 2022 14:55:11 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113%6]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 14:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44dcbb50-2f86-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FFxhnZtCojwywSacuYDWJRHNlRIoLgCxNn3TCZxmCiE5Hox2dnrb9e0rtb6ePbiak1I92M6g0JZOz2jnpSquGMcAZnA2YERDazc2wG/yQF+ZkJOyJkm9a/4oXt/hlTE75cJl+2OuvUPNAdlch9187Szplg0y8LGYKb/0UWEkoM3ryY9/m+fILSbii0yqBnScttLJrC2XFuQX2H2QfepQczXULW89/ftKgbMaQ0FJ0D/yBo3We1XDHG3u6tYjNtzNkByHEYiQMSJHUAO8wtQLibwbIB2Ry4itvRLLeMnM5IzfPPSFAPBJddpmcfzT4dW+VQhSOuIj2lAamAK/ftV5oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O+prVyg5c9zu9gczVOEkC80Uht3impG6KJztFkLvX9E=; b=jqtdpuZuAujDkfYTcbcttDWploKRc6RagZ3usccV05HVA0qmdmsgbYI/Fn9Yyf/7k0Dbzv7WLTgoVDx0lLQEtc08+7682jqtg+5k/kALFcaQvbjelenIoXFUxvi12HLEhpu6OESGvniCAqEQdkXLZdCmeUkpydJOwbWei8tsJjD/Y/ZS1wx0ETrRLWF9yYs1mVMj7X4qOEc+548T4cso7B7kIFvhlwrEMLOEYmEpHSMV9dq31tN31uE4RZmExy855xicDIMX/26XuoTi94DW/q7y5p/TfjO3lMV3kiYPAtAYRcQKDxMwzCPxRgjP3dHCD2F99YovhSOnUVC2iAMdwg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+prVyg5c9zu9gczVOEkC80Uht3impG6KJztFkLvX9E=; b=sDFpb2lYCbfP4cDlVLIEnsnbMVwtKC/k4FHDC6kmDP1qEiTE1X+/sB/ohc6o2UTRkTWK92g1FAon9YXlGTlqzloDysNouGFH56q4WYl9x3nrN4uqOO4IMxmMhWOf8R3e0v6gioU37AiSLHItsMBe9g4GfAlLLdsBVb5fc9y8xU8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayCO2PqHJSKrEZ54y237D9B9A1gyE649kpDRmvoa+0+GDgDG95MBLq+0lQwvkyBLEoQ0eFw18KSEbu+dM8+evPNSbz0dWDVw0y6wGcmwIS+3f/Xs/S32stRp5trl14CaYQDj4Ubv4ePwHELHSsUEzUp63EhVuqphmM4moap2N5KV/2Q0JUlR1v9Ac1GMn9N9/40agiehrIcE+Gm0X6WXcNkadn5E5YKheUCIh+qk4xXoKu10Vk7JcxoDZ2PHqr6HQ54QSqfQqQk6YNE+XrQuhH5AwX7OCVuZ8pDhaIeg2U/R/B2orWCw+f42BPPXsOoooXLECmDbQQAk+R4G01Kf9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O+prVyg5c9zu9gczVOEkC80Uht3impG6KJztFkLvX9E=; b=dm/l/I47tQaJNZrshhtiCGysqH38YPk7gaREQfNFQ+eyLcNMOFs38riRAVe/x+SZJLY8pn8bnnGC/ebY68QUIZeK1zdu9gC8i5HAp8lTCCAT38fPUcIWE3iyKWxiVvIIeRTMFA+e2n+JHYbKfIgFzMrtYmscUWECzLmELtJVLCCKirNQsK+uCRdT1o1rJTr0YDeOIntQP+yoYecrbtUfkOmLdTqUy0oaxxTTf+BEjy2oPlQu8bu8gttYOSDWsqGIGM/lgo11IYc/40jCLFaFvYPQWyijyezW6rbWsRIujDg0Av64WU/O5fsrVCaakgHTFODEZRjK4W8Qp0Bs8ijARA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+prVyg5c9zu9gczVOEkC80Uht3impG6KJztFkLvX9E=; b=sDFpb2lYCbfP4cDlVLIEnsnbMVwtKC/k4FHDC6kmDP1qEiTE1X+/sB/ohc6o2UTRkTWK92g1FAon9YXlGTlqzloDysNouGFH56q4WYl9x3nrN4uqOO4IMxmMhWOf8R3e0v6gioU37AiSLHItsMBe9g4GfAlLLdsBVb5fc9y8xU8= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Thread-Topic: [PATCH v4 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Thread-Index: AQHYvnyUkd8Ta8Mw/E68HKFtTdhKYK3VfB2AgAAsdNA= Date: Thu, 8 Sep 2022 14:55:11 +0000 Message-ID: References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-5-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 90A5B9302B464449A6D6348C16CF7F18.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DBBPR08MB6313:EE_|VE1EUR03FT032:EE_|DB9PR08MB7422:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e7338c4-4202-45a3-5313-08da91aa26f0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mApIoRiSN1dTYPmUm0T2fbSOFiSCFWwxrosyLBpJapmxatqJgV4RkJ3X7MdB0sjWiIhZt/QUur+ZR6A0xErJ9VFiXXy2jdic+YdYxwSlVIvljgXn2dKUxb4Vk+pomeggkpj4HcFLqzM0nf7IZ0SSjjnDN/LKnM/Pma8q23Mqyi78lA9Cx5diii3Fmh4fLCnJC30NjW65QspqOcMnESx2BPgjqDBZ4C0FbSJx6hmHPl5Mqu2su8kX6+XVWdl266PS4N4DreLxmlpkoPrOxXT/8K2PhAJW+5FRcz7D7WMHv9QyvPPqhPytT1d83vqvuva6t8jDKVxEl2htO1v4hg7zPL6qPPLYodFDiSWNZIeMTgewqU267ZTzMTeQvWup00hOmB75gMx3hJFKsFeQVapbKBwR9fyffYK2Xr9WnsU91ol64p7jT6o/xCz3K7jWiNTfZykIWePeucnsBf01uTxtD4wcaxasnyv/bLNQSbQZM/YqnescGl7nVOENEbga5A+4usTkmEaW3zm4OX77UJGOD6abTGU8pdn4b3yy+QXwvhC1q0bU+68nbwK6xE6Ue66kJBSXBQee1aJTPFo5SLldE/tPq9WzqOmmbkkw1gCTu2/EmQztB08V49pibu/bMt1dcYF6tjSL9DnhHvj3/NhB2u3uDIJ+kqHEErYPP/y1EmUox2J5TxTisJgsEcNr1IiB9QoxLANvv06ffKIZGWNSVR9aCoP25eYeMRRhmk9Oa16k2t0MV8mQrKGQkxcZjFiYliiR3p3BJrmRwSPBz/J93Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(186003)(52536014)(83380400001)(2906002)(53546011)(55016003)(5660300002)(6506007)(7696005)(86362001)(33656002)(9686003)(8936002)(71200400001)(41300700001)(478600001)(38070700005)(66476007)(76116006)(64756008)(4326008)(66446008)(54906003)(6916009)(66556008)(38100700002)(316002)(66946007)(8676002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6313 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dd331042-3b89-4f3a-0ea8-08da91aa2138 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xwyOEQoX841LoAh/inmgOdE5+ske7wEzll+x3E8r2aFZI99bSnfX9Jsd87gWamhLvEMAfv9v0OkahwEqyMJBZrWdHwGRNRLQdZandsXWv3eE8BHRuuLVXgfG/5p5pgrEIRsd6g7pszIJ/eK6pJxez5GXWo6HVadqgBFHgn9fu5Ahq5Me9VEJ0oeUB4PncGZyCFoA3oXKEQSv+SQUuzhNpul5z+YltoyhwByUdAZWDt4Pbx78qmybDrZMRXOMkOXZw8lIROhfcSypbEntE8df5ZhmedCE4a9ff4npsMIeUPZAEHjxM77xUo0KUrAtLh5kcImsaK6s9g9IXT1lHbXwD0qeGzUWlSfaE8oxkwq5/SZcL4wP9fvF9+ff1cBqAVJL/Hpb5Jg2wxpmV0wUsz8MWo66Lvr5IKBjfUhw7OpQQ9ee4k83uJQydbMBhP7XTm7FuVHw9vu4s2vfwfSvs2pxbDtmXzXN+ZPJIzSk5569axWUUblhQ3fAPK7BRPJ5Tx3K16x/Jl9NIQLB56osE0cRs5W03miFeZ0IO1hu7rwfpqn4DeeAJmlkbZQ7xA5P/JvyKLAodmLTaMe1qrXNhFbiNaGy/Kuiv9r7IXKTpeiSGYEkyW9keZB9vNTC36sfbBYKJPSdkNu3wT3htKDQBcLY0tdL4RyCyzpbs/avqjm/lH7TY2YYuJUR9DBS1mABfmBJdSbG06Qngaptz1BMAOtq0wK5GwmPPnxwy1EH9t4MVi0zVTg+H1MPmgv3j7pboQN0ZqXujip0aSw4w+SSc2c/Yg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(136003)(39860400002)(36840700001)(40470700004)(46966006)(26005)(478600001)(6506007)(9686003)(70206006)(70586007)(40480700001)(7696005)(55016003)(82310400005)(6862004)(2906002)(33656002)(40460700003)(86362001)(54906003)(81166007)(316002)(8676002)(41300700001)(53546011)(4326008)(356005)(82740400003)(186003)(47076005)(83380400001)(52536014)(5660300002)(8936002)(336012)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 14:55:20.8571 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e7338c4-4202-45a3-5313-08da91aa26f0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7422 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIg45pelIDIwOjE0DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IFJvZ2VyIFBhdQ0KPiBN b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEdlb3Jn ZSBEdW5sYXANCj4gPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD SCB2NCA0LzZdIHhlbi94ODY6IHVzZSBhcmNoX2dldF9yYW1fcmFuZ2UgdG8gZ2V0DQo+IGluZm9y bWF0aW9uIGZyb20gRTgyMCBtYXANCj4gDQo+IE9uIDAyLjA5LjIwMjIgMDU6MzEsIFdlaSBDaGVu IHdyb3RlOg0KPiA+IFRoZSBzYW5pdHkgY2hlY2sgb2Ygbm9kZXNfY292ZXJfbWVtb3J5IGlzIGFs c28gYSByZXF1aXJlbWVudCBvZg0KPiA+IG90aGVyIGFyY2hpdGVjdHVyZXMgdGhhdCBzdXBwb3J0 IE5VTUEuIEJ1dCBub3csIHRoZSBjb2RlIG9mDQo+ID4gbm9kZXNfY292ZXJfbWVtb3J5IGlzIHRp ZWQgdG8gdGhlIHg4NiBFODIwLiBJbiB0aGlzIGNhc2UsIHdlDQo+ID4gaW50cm9kdWNlIGFyY2hf Z2V0X3JhbV9yYW5nZSB0byBkZWNvdXBsZSBhcmNoaXRlY3R1cmUgc3BlY2lmaWMNCj4gPiBtZW1v cnkgbWFwIGZyb20gdGhpcyBmdW5jdGlvbi4gVGhpcyBtZWFucywgb3RoZXIgYXJjaGl0ZWN0dXJl cw0KPiA+IGxpa2UgQXJtIGNhbiBhbHNvIHVzZSBpdCB0byBjaGVjayBpdHMgbm9kZSBhbmQgbWVt b3J5IGNvdmVyYWdlDQo+ID4gZnJvbSBib290bWVtIGluZm8uDQo+ID4NCj4gPiBEZXBlbmRzIGFy Y2hfZ2V0X3JhbV9yYW5nZSwgd2UgbWFrZSBub2Rlc19jb3Zlcl9tZW1vcnkgYmVjb21lDQo+ID4g YXJjaGl0ZWN0dXJlIGluZGVwZW5kZW50LiBXZSBhbHNvIHVzZSBuZXV0cmFsIHdvcmRzIHRvIHJl cGxhY2UNCj4gPiBTUkFUIGFuZCBFODIwIGluIHRoZSBwcmludCBtZXNzYWdlIG9mIHRoaXMgZnVu Y3Rpb24uIFRoaXMgd2lsbA0KPiA+IHRvIG1ha2UgdGhlIG1hc3NhZ2Ugc2VlbXMgbW9yZSBjb21t b24uDQo+ID4NCj4gPiBBcyBhcmNoX2dldF9yYW1fcmFuZ2UgdXNlIHVuc2lnbmVkIGludCBmb3Ig aW5kZXgsIHdlIGFsc28gYWRqdXN0DQo+ID4gdGhlIGluZGV4IGluIG5vZGVzX2NvdmVyX21lbW9y eSBmcm9tIGludCB0byB1bnNpZ25lZCBpbnQuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkg Q2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gDQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8 amJldWxpY2hAc3VzZS5jb20+DQo+IGFsYmVpdCBzdGlsbCB3aXRoIGEgY291cGxlIG9mIHN1Z2dl c3Rpb25zOg0KPiANCg0KVGhhbmtzLCBJIHdpbGwgYWRqdXN0IHRoZSBjb2RlIGNvbW1lbnRzIHRv IGFkZHJlc3MgeW91ciBzdWdnZXN0aW9ucy4NCg0KPiA+IC0tLSBhL3hlbi9hcmNoL3g4Ni9zcmF0 LmMNCj4gPiArKysgYi94ZW4vYXJjaC94ODYvc3JhdC5jDQo+ID4gQEAgLTQyOCwzNyArNDI4LDQz IEBAIGFjcGlfbnVtYV9tZW1vcnlfYWZmaW5pdHlfaW5pdChjb25zdCBzdHJ1Y3QNCj4gYWNwaV9z cmF0X21lbV9hZmZpbml0eSAqbWEpDQo+ID4gICAgIE1ha2Ugc3VyZSB0aGUgUFhNcyBjb3ZlciBh bGwgbWVtb3J5LiAqLw0KPiA+ICBzdGF0aWMgaW50IF9faW5pdCBub2Rlc19jb3Zlcl9tZW1vcnko dm9pZCkNCj4gPiAgew0KPiA+IC0JaW50IGk7DQo+ID4gKwl1bnNpZ25lZCBpbnQgaTsNCj4gPg0K PiA+IC0JZm9yIChpID0gMDsgaSA8IGU4MjAubnJfbWFwOyBpKyspIHsNCj4gPiAtCQlpbnQgaiwg Zm91bmQ7DQo+ID4gKwlmb3IgKGkgPSAwOyA7IGkrKykgew0KPiA+ICsJCWludCBlcnI7DQo+ID4g KwkJdW5zaWduZWQgaW50IGo7DQo+ID4gKwkJYm9vbCBmb3VuZDsNCj4gPiAgCQlwYWRkcl90IHN0 YXJ0LCBlbmQ7DQo+ID4NCj4gPiAtCQlpZiAoZTgyMC5tYXBbaV0udHlwZSAhPSBFODIwX1JBTSkg ew0KPiA+IC0JCQljb250aW51ZTsNCj4gPiAtCQl9DQo+ID4gKwkJLyogVHJ5IHRvIGxvb3AgbWVt b3J5IG1hcCBmcm9tIGluZGV4IDAgdG8gZW5kIHRvIGdldCBSQU0NCj4gcmFuZ2VzLiAqLw0KPiA+ ICsJCWVyciA9IGFyY2hfZ2V0X3JhbV9yYW5nZShpLCAmc3RhcnQsICZlbmQpOw0KPiA+DQo+ID4g LQkJc3RhcnQgPSBlODIwLm1hcFtpXS5hZGRyOw0KPiA+IC0JCWVuZCA9IGU4MjAubWFwW2ldLmFk ZHIgKyBlODIwLm1hcFtpXS5zaXplOw0KPiA+ICsJCS8qIFJlYWNoIHRoZSBlbmQgb2YgYXJjaCdz IG1lbW9yeSBtYXAgKi8NCj4gPiArCQlpZiAoZXJyID09IC1FTk9FTlQpDQo+ID4gKwkJCWJyZWFr Ow0KPiANCj4gU3VjaCBhIGNvbW1lbnQgYWhlYWQgb2YgYW4gaWYoKSBpcyBvZnRlbiBiZXR0ZXIg cHV0IGFzIGEgcXVlc3Rpb24sIGUuZy4NCj4gIlJlYWNoZWQgdGhlIGVuZCBvZiB0aGUgbWVtb3J5 IG1hcD8iIGhlcmUgb3IsIGlmIHlvdSBkaXNsaWtlIHVzaW5nIGENCj4gcXVlc3Rpb24sICJFeGl0 IHRoZSBsb29wIGF0IHRoZSBlbmQgb2YgdGhlIG1lbW9yeSBtYXAiLg0KPiANCj4gPiArCQkvKiBJ bmRleCByZWxhdGUgZW50cnkgaXMgbm90IFJBTSwgc2tpcCBpdC4gKi8NCj4gPiArCQlpZiAoZXJy KQ0KPiA+ICsJCQljb250aW51ZTsNCj4gDQo+IEFuZCB0aGVuIHBlcmhhcHMgIlNraXAgbm9uLVJB TSBlbnRyaWVzIiBoZXJlLg0KPiANCj4gPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vbnVtYS5oDQo+ ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL251bWEuaA0KPiA+IEBAIC04MSw2ICs4MSwxOSBAQCBz dGF0aWMgaW5saW5lIG5vZGVpZF90IF9fYXR0cmlidXRlX3B1cmVfXw0KPiBwaHlzX3RvX25pZChw YWRkcl90IGFkZHIpDQo+ID4gICNkZWZpbmUgbm9kZV9lbmRfcGZuKG5pZCkgICAgICAgKE5PREVf REFUQShuaWQpLT5ub2RlX3N0YXJ0X3BmbiArIFwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTk9ERV9EQVRBKG5pZCktPm5vZGVfc3Bhbm5lZF9wYWdlcykNCj4gPg0KPiA+ ICsvKg0KPiA+ICsgKiBUaGlzIGZ1bmN0aW9uIHByb3ZpZGVzIHRoZSBhYmlsaXR5IGZvciBjYWxs ZXIgdG8gZ2V0IG9uZSBSQU0gZW50cnkNCj4gPiArICogZnJvbSBhcmNoaXRlY3R1cmFsIG1lbW9y eSBtYXAgYnkgaW5kZXguDQo+ID4gKyAqDQo+ID4gKyAqIFRoaXMgZnVuY3Rpb24gd2lsbCByZXR1 cm4gemVybyBpZiBpdCBjYW4gcmV0dXJuIGEgcHJvcGVyIFJBTSBlbnRyeS4NCj4gPiArICogb3Ro ZXJ3aXNlIGl0IHdpbGwgcmV0dXJuIC1FTk9FTlQgZm9yIG91dCBvZiBzY29wZSBpbmRleCwgb3Ig cmV0dXJuDQo+ID4gKyAqIC1FTk9EQVRBIGZvciBub24tUkFNIHR5cGUgbWVtb3J5IGVudHJ5Lg0K PiANCj4gVGhlIHdheSB5b3UndmUgaW1wbGVtZW50ZWQgdGhpbmdzLCAtRU5PREFUQSBpc24ndCBz cGVjaWFsIGFueW1vcmUsIHNvDQo+IGJldHRlciB3b3VsZG4ndCBiZSBjYWxsZWQgb3V0IGFzIHNw ZWNpYWwgaGVyZS4gTWF5IEkgc3VnZ2VzdCB0byBhdA0KPiBsZWFzdCBpbnNlcnQgImUuZy4iIGlu IGZyb250IG9mIGl0PyAoQW4gYWx0ZXJuYXRpdmUgd291bGQgYmUgdG8gY2hlY2sNCj4gZm9yIC1F Tk9EQVRBIGluIG5vZGVzX2NvdmVyX21lbW9yeSgpIGFnYWluLCBmb2xsb3dlZCBieSBBU1NFUlQo IWVycikuKQ0KPiANCj4gPiArICogTm90ZTogdGhlIHJhbmdlIGlzIGV4Y2x1c2l2ZSBhdCB0aGUg ZW5kLCBlLmcuIFtzdGFydCwgZW5kKS4NCj4gDQo+IFBlcmhhcHMgYmV0dGVyIFsqc3RhcnQsICpl bmQpIHRvIG1hdGNoIC4uLg0KPiANCj4gPiArICovDQo+ID4gK2V4dGVybiBpbnQgYXJjaF9nZXRf cmFtX3JhbmdlKHVuc2lnbmVkIGludCBpZHgsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHBhZGRyX3QgKnN0YXJ0LCBwYWRkcl90ICplbmQpOw0KPiANCj4gLi4uIHRoaXM/DQo+ IA0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 08 14:56:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 14:56:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403421.645536 (Exim 4.92) (envelope-from ) id 1oWIwu-0004aZ-6w; Thu, 08 Sep 2022 14:56:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403421.645536; Thu, 08 Sep 2022 14:56:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWIwu-0004aS-4C; Thu, 08 Sep 2022 14:56:12 +0000 Received: by outflank-mailman (input) for mailman id 403421; Thu, 08 Sep 2022 14:56:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWIwt-0004aD-9G; Thu, 08 Sep 2022 14:56:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWIwt-0001Xw-6J; Thu, 08 Sep 2022 14:56:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWIws-0004UK-Me; Thu, 08 Sep 2022 14:56:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWIws-0008K7-Li; Thu, 08 Sep 2022 14:56:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QjNv23D56mkaBLZuHf1iji+DrNJxqHF9jX/5bukoN8I=; b=0k9qyN/+dFnrj+WQ61ec0akQyO hhTIUdMvrTuRfqJ9W0bPVE2PCojqloMBZhDAYlKp5jAHywZAcb1bOfTlfE/5B4xuL0UMPeM7b9x6T XHshsqUH6T/MHwrUrtmbq+TyYC5ttNGB+JG+BygsrMtzAifblGeiV8nOYTj8zqf9gaDU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173056: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-vhd::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:heisenbug linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-5.4:test-amd64-amd64-examine:examine-iommu:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Thu, 08 Sep 2022 14:56:10 +0000 flight 173056 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173056/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd broken in 173048 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken in 173048 pass in 173056 test-amd64-i386-qemuu-rhel6hvm-intel 8 xen-boot fail in 173048 pass in 173056 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 173048 test-amd64-amd64-examine 13 examine-iommu fail pass in 173048 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173048 blocked in 172128 test-armhf-armhf-xl-credit2 14 guest-start fail in 173048 like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 173048 like 172128 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173048 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173048 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 35 days Failing since 172384 2022-08-11 11:13:58 Z 28 days 60 attempts Testing same since 173008 2022-09-05 15:47:43 Z 2 days 6 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-vhd broken Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 15:21:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 15:21:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403431.645547 (Exim 4.92) (envelope-from ) id 1oWJKv-0000BC-8U; Thu, 08 Sep 2022 15:21:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403431.645547; Thu, 08 Sep 2022 15:21:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJKv-0000B5-5V; Thu, 08 Sep 2022 15:21:01 +0000 Received: by outflank-mailman (input) for mailman id 403431; Thu, 08 Sep 2022 15:21:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJKu-0000Av-3Y; Thu, 08 Sep 2022 15:21:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJKu-0001zW-1g; Thu, 08 Sep 2022 15:21:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJKt-0005km-K3; Thu, 08 Sep 2022 15:20:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWJKt-0005wL-JX; Thu, 08 Sep 2022 15:20:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JPPjh0QBGkWMdSyP5Xp9wAG6UUcaE+lea5/rsdjhEFc=; b=xV7ss2C/7iTtkhnjCNMzFBPgua 3XEaR7bv+PJiWyx/mpKZVav2T2xbQn1XPxQ3cv6wMdy5MD6PHGq1L9jmZHfdLzBqhPrFTgDYuB8KI ztzPKe4W3ngaDPk1LcJtahRAAEIN5wW59sDgLu40AIXX8Fv93+imekht5f4+Eaguxzx4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173064: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc X-Osstest-Versions-That: xen=64e302157a87b246473a31fa104377a6d48eb046 From: osstest service owner Date: Thu, 08 Sep 2022 15:20:59 +0000 flight 173064 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173064/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173061 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc baseline version: xen 64e302157a87b246473a31fa104377a6d48eb046 Last test of basis 173061 2022-09-08 08:01:53 Z 0 days Testing same since 173064 2022-09-08 12:01:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Jan Beulich Juergen Gross Julien Grall Penny Zheng Rahul Singh Stanislav Kinsburskii jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 64e302157a..6bc1c1aba0 6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc -> smoke From xen-devel-bounces@lists.xenproject.org Thu Sep 08 15:26:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 15:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403440.645558 (Exim 4.92) (envelope-from ) id 1oWJQ4-0000pL-Tg; Thu, 08 Sep 2022 15:26:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403440.645558; Thu, 08 Sep 2022 15:26:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJQ4-0000pE-QH; Thu, 08 Sep 2022 15:26:20 +0000 Received: by outflank-mailman (input) for mailman id 403440; Thu, 08 Sep 2022 15:26:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJQ3-0000p8-2r for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 15:26:19 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9490635f-2f8a-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 17:26:16 +0200 (CEST) Received: from AS9PR05CA0026.eurprd05.prod.outlook.com (2603:10a6:20b:488::31) by DU0PR08MB8812.eurprd08.prod.outlook.com (2603:10a6:10:47b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 8 Sep 2022 15:26:13 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::6e) by AS9PR05CA0026.outlook.office365.com (2603:10a6:20b:488::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19 via Frontend Transport; Thu, 8 Sep 2022 15:26:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 15:26:13 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 08 Sep 2022 15:26:12 +0000 Received: from eb21a23fc552.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F75AF3EA-59E0-4E21-864C-656B5D8876DD.1; Thu, 08 Sep 2022 15:26:07 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb21a23fc552.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 15:26:07 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB7720.eurprd08.prod.outlook.com (2603:10a6:20b:508::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15; Thu, 8 Sep 2022 15:26:05 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113%6]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 15:26:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9490635f-2f8a-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QGpA4DKqlxbrgnOiPNCH+I41udJX8GFXIriwgUHEvVMihKzo66UejPi+0lvqp//X7Z7CjG8vVqGj9ngVIbOs8F7icb22fB0P38C+tWuK+kRtVzXczcV47zWrDwFn2qzgRRExWgqvaBZa+S81hi+kaJ70KwqdMB+eKC3uyh0ZL1qAK0mEY7UupTuklSxzC5K2814d2n4O1+mLYpq51gfHpxkPlZ+JpSfbmRpN50l81CGPyUnxlDtmEe4aeZeSvlvDGz7ZL6toN5+/EDqi1kFJWHRvqHGEKkR6ar/0E5Nld6ruJpgKJy1AMR1JnX/sJBuLVrCXfmvebRdMRGihS55/gA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvA5kp2kch5f63jZZZBawwBuesGVvUKtFJe/qq146ac=; b=Oj0fTEaY1KT0cnZPEqYxk2+BuxriFYT8QOiiQp41pGW4KrYx8FqkzZUAcUAMIgcrrNX/l1bAEQ9KbfeCpGgZxTercKZTJATu1pdNkWG6ZGdDlGQdh83Op+UzDlvXe1qHyMgjLvr8Jasw8icu8j4SBBxAbQe85fFOoyFiElXCoTZq6fO7to+MkohuretmPHAeOyZFlVUwxM+Zpe5Sb8Njrq4ZGSfrSb4BhOjDKT3cuvDaGMOaNPY++xkmRoPQFECWAtXunQmFjFTcdBHP9vo/ALKEyx5W9UUZ1DdFvSklCPcESHkBcje3TkH4O3OVuII4PINwp0fgXkS4nvB5t3rQfQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XvA5kp2kch5f63jZZZBawwBuesGVvUKtFJe/qq146ac=; b=1tS4vT6MV18HHeeiI7P/DtKlMJueCX3/lN2XCtpJCxfpEvvm8ywtXq02NTtSVumtgjmfG0SjtFY96jJoQsSna46BX+DB+RbYdIkXPow4j0yUA5sij3yllr8k2OEB6EAo04/NnkQHXB4zKE0iFBSKzFH9qJc6JDxBExhzOv2J2ew= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEI6HSosJRjAc4uKg6qfGQNcBAa3zcOaM1hqtLLXH1s0owxmouxK52RkcLAaxtC7gZo1MeZ9vmHKO6N/haDvdbz/5qdgqKWe9PSBpJm8reMBKDbzSLCWg5733oFEKW+OdcpDILLMCiYKLd1JdaiSUUPlNhOgcl03zUB9klKX8xdOLtKMM6l6VSHi/R7UsyH8eF3bz4yyLxNyUJeHXBexq843Wm6MSASLPk3Px35rhCEj1cAq82AVwmoGvlXRMzXU6fY+MdlJp5bSLduQUUtDyNvSK2DQkLpuakedDeawIeYt/Xx9zt0BdNcI8mRUw1H1gPc0DDzc2cm7Ek0xMruFiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvA5kp2kch5f63jZZZBawwBuesGVvUKtFJe/qq146ac=; b=IEbMmjN6LQPhGPljlI/lca86oM3ASyg1NxdZoXF4nVNHsp58NGwsVbi++vTuC3cvurd+KZMXuCLPZDI/KP9I4rA5TjOa1ZdG8Rp+ayCcwsA6OLty/kWB9lo7aXuVMKsjAGCSJvNTGzshLz8FB/a+X4KooJ4oSpmnVRauqIm/JeCsxucpXRIjMR2jfOgbNYR+CNRHOSK8Msiu/8PQOryl/Vk5+ey4Hbr70mc3AcsifJQm1jcyDo3PiSwz6rskljWjea9iIPzwdrmFUIwybXpjjV9VEWCJqzVYwbkiqqlLD8fZUmH9qLY8TO2x2ScuOjINPM0neMjTbOpIOkA9ksJ6OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XvA5kp2kch5f63jZZZBawwBuesGVvUKtFJe/qq146ac=; b=1tS4vT6MV18HHeeiI7P/DtKlMJueCX3/lN2XCtpJCxfpEvvm8ywtXq02NTtSVumtgjmfG0SjtFY96jJoQsSna46BX+DB+RbYdIkXPow4j0yUA5sij3yllr8k2OEB6EAo04/NnkQHXB4zKE0iFBSKzFH9qJc6JDxBExhzOv2J2ew= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Topic: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Index: AQHYvnyUZh7WY/u61UisC2n0bZDyXq3ViaOAgAAfcVA= Date: Thu, 8 Sep 2022 15:26:04 +0000 Message-ID: References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-6-wei.chen@arm.com> <837f7b6d-0d73-a352-17e6-5c12e06dab95@suse.com> In-Reply-To: <837f7b6d-0d73-a352-17e6-5c12e06dab95@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7D251810A2D61C41BCCCAB5E8D32E0B5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS8PR08MB7720:EE_|AM7EUR03FT022:EE_|DU0PR08MB8812:EE_ X-MS-Office365-Filtering-Correlation-Id: 19271e1c-05a8-4394-c590-08da91ae76ea x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9o4RsNfnhSZwifUm4t5GIXzKMEqQeV5qWD9ZirVT++6JRsvhY/MHejyLOwyiCcH2TWx5UxseWMUo9CniXzx/X0Fq3P63k40HGzERNZjJwBb8gRiA8eUYz7SXRa1P4q1PBbKzCHhZq5gOd0NSCtyze/wclISN+n0L+asjljvustOlFy8tF/UuV64V7qCPNi6k2p+ISqxDIWkGHmHfQ2osb+fr17DEyz3T6PAe5wcITn75/L2RfmjY8GFeY+NZOM2GLTe9OTBxW/FbMB7FXxJzUpDtyZLT2UnzgeVpWUFkKMAnXlyh5f2L/YcGMYYp1ij1BPYgV+IukQQ9ffZ0gx5z6snFF+NS7NMZCA7ZAsAuCDVd5Fzoezh9CZCI5N/g28/9I/SiZc0Vx/QMpmnjt7rEn5LKWyl4TBc8UgTZCwBevlnA5feHZpeC/wBZiASkn7jqHQPLjcAxKL3m4ByemmgOzTsi6MuTWGjZ6vo8J1cm35x9avICMNeF152i7vhGlj0Yvk5NvlQviMpc+eTtji06EO8UFFQpyP3mzSXWdAYKXDP+itwMyP27mbSWUe8PW5CZnZ4PKW4HblCA6Cqz7+T4KxGbbZAiJwLUg00gkSDol4if0ctRiG1d1hglqeV+Cv3fgSMEQk9ISsXt5q6x+eNPq65JVL0uklij8Ibs6Ucq0LZRJBkhrz7dOIIPJ0QHhhqs+/7CwqKjq59BdHJ6PK79sy8d76tSViXaQJFVJG9NLeB6cGxG+UKqFntGxN1nVNYxkTx2ncVpGvPjYlnLqvsfvg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(66446008)(316002)(41300700001)(66556008)(7696005)(8676002)(64756008)(66476007)(54906003)(66946007)(55016003)(6916009)(86362001)(478600001)(30864003)(9686003)(6506007)(53546011)(8936002)(5660300002)(38070700005)(4326008)(76116006)(71200400001)(52536014)(38100700002)(2906002)(186003)(122000001)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7720 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 36d6dc8b-894d-49c4-f587-08da91ae7180 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dvTIlw2+4kyMTEY1B1PcnrMayn419JzQHY80EAzKYppcoYJHMKNuOyDXmja8bmBqil/nJrHhoi/QgltB46SPNV8F58xVFihEbR88JkBikIbMBzRTJ93kLEvkgLXJOQiGSNFSB6fkDWOU216SFE29ZnZI7qw1fcifuhZc+TgWyNCmTIEFEqnn55MD8CP+cbXKvAglf8ibyLhsKQhMBBqktU5GBGQCiljVagzW5/8smy8ewvLUYeEv9jMkV1HipQ1ZSZ7JDz6xUAb11OMOm8urAkdfi3saKKHe/vrQfbTB39SC8KH/wj3lPm2FzYC7I/KW6eeo6Qyydq2eJ3+PB3CyfGkVVYfjtdzGDtXDU0CbhsiVQjOfDU/MeKqpJY2ID6LnI4ENr2fIDE+NHmsrY9Kev+8CIRPntFsugtudGmOEc7Piig3WMlBa5zJIuspWO06KDcmcLI5kOkCAV3wMFi+Fd8inr08A1rs1dOSNsNjBmDFt9fKnWM/6e95AqM/FzfId0eDYjM8Ng+N2wvnlxr6QnhIk2TMWukO47wrETIZkET1bNM6nACr4Bmi0PQcsAWbcblwML/i3AIRdZVJ7Inqsn2S9BLFEP5kD7TOl4DI99Khhl448/jgrs/67B/eDzo3lKiFQYGNVphbb8EqkFmK7xSs8gcmTsgqr2uqsWC2rdZ+RpWMVjEKSlKaLZePUbTD1slU0KUc0dGIevZ7mUXdC/yDjAf8TNCC/j0s8GsSONSSmCLFbEEIxRHrzsfR5i+PLOkj9FMYNABK4oCGyL5AbSg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(40470700004)(46966006)(36840700001)(53546011)(52536014)(40460700003)(81166007)(186003)(6506007)(5660300002)(6862004)(47076005)(41300700001)(8936002)(33656002)(30864003)(86362001)(336012)(7696005)(2906002)(26005)(9686003)(36860700001)(356005)(55016003)(82740400003)(40480700001)(70586007)(54906003)(478600001)(83380400001)(8676002)(82310400005)(316002)(70206006)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 15:26:13.0999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19271e1c-05a8-4394-c590-08da91ae76ea X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8812 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIg45pelIDIxOjAzDQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IFJvZ2VyIFBhdQ0KPiBN b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEdlb3Jn ZSBEdW5sYXANCj4gPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD SCB2NCA1LzZdIHhlbi94ODY6IG1vdmUgTlVNQSBzY2FuIG5vZGVzIGNvZGVzIGZyb20geDg2DQo+ IHRvIGNvbW1vbg0KPiANCj4gT24gMDIuMDkuMjAyMiAwNTozMSwgV2VpIENoZW4gd3JvdGU6DQo+ ID4gLS0tIGEveGVuL2FyY2gveDg2L251bWEuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL3g4Ni9udW1h LmMNCj4gPiBAQCAtNDEsOSArNDEsMTIgQEAgaW50IF9faW5pdCBhcmNoX251bWFfc2V0dXAoY29u c3QgY2hhciAqb3B0KQ0KPiA+ICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gIH0NCj4gPg0KPiA+ IC1ib29sIGFyY2hfbnVtYV9kaXNhYmxlZCh2b2lkKQ0KPiA+ICtib29sIGFyY2hfbnVtYV9kaXNh YmxlZChib29sIGluaXRfYXNfZGlzYWJsZSkNCj4gDQo+IEknbSBhZnJhaWQgbXkgcXVlc3Rpb24g YXMgdG8gdGhlIG1lYW5pbmcgb2YgdGhlIG5hbWUgb2YgdGhlIHBhcmFtZXRlciBoYXMNCj4gcmVt YWluZWQgdW5hbnN3ZXJlZC4NCj4gDQoNClNvcnJ5LCBJIG1pZ2h0IG1pc3NlZCBzb21lIGNvbnRl bnRzIG9mIHlvdXIgcmVwbHkgaW4gdjMuIFRoZSBuYW1lIG9mIHRoaXMNCnBhcmFtZXRlciBoYXMg YmVlbiBib3RoZXJpbmcgbWUgZm9yIGEgbG9uZyB0aW1lLCBhbmQgbm93IHRoaXMgaXMgYWN0dWFs bHkNCnF1aXRlIGF3a3dhcmQuIFRoZSBvcmlnaW4gb2YgdGhpcyBwYXJhbWV0ZXIgaXMgYmVjYXVz ZSB0aGUgY3VycmVudCBOVU1BDQppbXBsZW1lbnRhdGlvbiB3aWxsIG1ha2UgZGlmZmVyZW50IGp1 ZGdtZW50cyB1bmRlciBkaWZmZXJlbnQgdXNhZ2UNCmNvbmRpdGlvbnMgd2hlbiB1c2luZyBhY3Bp X251bWEuIEluIGFjcGlfc2Nhbl9ub2RlcywgaXQgdXNlcyBhY3BpX251bWEgPD0gMA0KYXMgdGhl IGNvbmRpdGlvbiBmb3IganVkZ2luZyB0aGF0IEFDUEkgTlVNQSBpcyB0dXJuZWQgb2ZmLiBCdXQg b25seSB1c2UNCmFjcGlfbnVtYSA8IDAgYXMgY29uZGl0aW9uIGluIHNyYXRfZGlzYWJsZWQgYW5k IGVsc2V3aGVyZS4gSSB1c2UgdGhpcw0KcGFyYW1ldGVyIGluIHRoZSBob3BlIHRoYXQgd2UgY2Fu IGtlZXAgdGhlIHNhbWUgc2VtYW50aWNzIGFzIHRoZSBvcmlnaW5hbA0KY29kZSB3aXRob3V0IGNo YW5naW5nIHRoZSBjb2RlIG9mIHRoZSBjYWxsZXIuDQoNCj4gPiBAQCAtMzA2LDMyICsyMTgsMjcg QEAgYWNwaV9udW1hX3Byb2Nlc3Nvcl9hZmZpbml0eV9pbml0KGNvbnN0IHN0cnVjdA0KPiBhY3Bp X3NyYXRfY3B1X2FmZmluaXR5ICpwYSkNCj4gPiAgdm9pZCBfX2luaXQNCj4gPiAgYWNwaV9udW1h X21lbW9yeV9hZmZpbml0eV9pbml0KGNvbnN0IHN0cnVjdCBhY3BpX3NyYXRfbWVtX2FmZmluaXR5 ICptYSkNCj4gPiAgew0KPiA+IC0Jc3RydWN0IG5vZGUgKm5kOw0KPiA+IC0JcGFkZHJfdCBuZF9z dGFydCwgbmRfZW5kOw0KPiA+IC0JcGFkZHJfdCBzdGFydCwgZW5kOw0KPiA+ICAJdW5zaWduZWQg cHhtOw0KPiA+ICAJbm9kZWlkX3Qgbm9kZTsNCj4gPiAtCXVuc2lnbmVkIGludCBpOw0KPiA+DQo+ ID4gIAlpZiAobnVtYV9kaXNhYmxlZCgpKQ0KPiA+ICAJCXJldHVybjsNCj4gPiAgCWlmIChtYS0+ aGVhZGVyLmxlbmd0aCAhPSBzaXplb2Yoc3RydWN0IGFjcGlfc3JhdF9tZW1fYWZmaW5pdHkpKSB7 DQo+ID4gLQkJYmFkX3NyYXQoKTsNCj4gPiArCQludW1hX2Z3X2JhZCgpOw0KPiA+ICAJCXJldHVy bjsNCj4gPiAgCX0NCj4gPiAgCWlmICghKG1hLT5mbGFncyAmIEFDUElfU1JBVF9NRU1fRU5BQkxF RCkpDQo+ID4gIAkJcmV0dXJuOw0KPiA+DQo+ID4gLQlzdGFydCA9IG1hLT5iYXNlX2FkZHJlc3M7 DQo+ID4gLQllbmQgPSBzdGFydCArIG1hLT5sZW5ndGg7DQo+ID4gIAkvKiBTdXBwbGVtZW50IHRo ZSBoZXVyaXN0aWNzIGluIGwxdGZfY2FsY3VsYXRpb25zKCkuICovDQo+ID4gLQlsMXRmX3NhZmVf bWFkZHIgPSBtYXgobDF0Zl9zYWZlX21hZGRyLCBST1VORFVQKGVuZCwgUEFHRV9TSVpFKSk7DQo+ ID4gKwlsMXRmX3NhZmVfbWFkZHIgPSBtYXgobDF0Zl9zYWZlX21hZGRyLA0KPiA+ICsJCQkgICAg ICBST1VORFVQKG1hLT5iYXNlX2FkZHJlc3MgKyBtYS0+bGVuZ3RoLA0KPiA+ICsJCQkgICAgICBQ QUdFX1NJWkUpKTsNCj4gDQo+IEluZGVudGF0aW9uOg0KPiANCj4gCWwxdGZfc2FmZV9tYWRkciA9 IG1heChsMXRmX3NhZmVfbWFkZHIsDQo+IAkJCSAgICAgIFJPVU5EVVAobWEtPmJhc2VfYWRkcmVz cyArIG1hLT5sZW5ndGgsDQo+IAkJCSAgICAgICAgICAgICAgUEFHRV9TSVpFKSk7DQo+IA0KDQpP ay4NCg0KPiA+IEBAIC0zMyw3ICs0OCwzMDkgQEAgYm9vbCBfX3JlYWRfbW9zdGx5IG51bWFfb2Zm Ow0KPiA+DQo+ID4gIGJvb2wgbnVtYV9kaXNhYmxlZCh2b2lkKQ0KPiA+ICB7DQo+ID4gLSAgICBy ZXR1cm4gbnVtYV9vZmYgfHwgYXJjaF9udW1hX2Rpc2FibGVkKCk7DQo+ID4gKyAgICByZXR1cm4g bnVtYV9vZmYgfHwgYXJjaF9udW1hX2Rpc2FibGVkKGZhbHNlKTsNCj4gPiArfQ0KPiA+ICsNCj4g PiArdm9pZCBfX2luaXQgbnVtYV9zZXRfcHJvY2Vzc29yX25vZGVzX3BhcnNlZChub2RlaWRfdCBu b2RlKQ0KPiA+ICt7DQo+ID4gKyAgICBub2RlX3NldChub2RlLCBwcm9jZXNzb3Jfbm9kZXNfcGFy c2VkKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArYm9vbCB2YWxpZF9udW1hX3JhbmdlKHBhZGRyX3Qg c3RhcnQsIHBhZGRyX3QgZW5kLCBub2RlaWRfdCBub2RlKQ0KPiA+ICt7DQo+ID4gKyAgICB1bnNp Z25lZCBpbnQgaTsNCj4gPiArDQo+ID4gKyAgICBmb3IgKCBpID0gMDsgaSA8IG51bV9ub2RlX21l bWJsa3M7IGkrKyApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgc3RydWN0IG5vZGUgKm5kID0g Jm5vZGVfbWVtYmxrX3JhbmdlW2ldOw0KPiANCj4gY29uc3Q/IChUaGlzIGlzIHBhcnRpY3VsYXJs eSByZWxldmFudCB3aXRoIF9fcm9fYWZ0ZXJfaW5pdC4pDQo+IA0KDQpZZXMsIEkgd2lsbCBmaXgg aXQuDQoNCj4gPiArYm9vbCBfX2luaXQgbnVtYV91cGRhdGVfbm9kZV9tZW1ibGtzKG5vZGVpZF90 IG5vZGUsIHVuc2lnbmVkIGludA0KPiBhcmNoX25pZCwNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHBhZGRyX3Qgc3RhcnQsIHBhZGRyX3Qgc2l6ZSwNCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgKnByZWZpeCwNCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgaG90cGx1ZykNCj4g PiArew0KPiA+ICsgICAgdW5zaWduZWQgaW50IGk7DQo+ID4gKyAgICBwYWRkcl90IGVuZCA9IHN0 YXJ0ICsgc2l6ZTsNCj4gPiArICAgIHBhZGRyX3QgbmRfc3RhcnQgPSBzdGFydDsNCj4gPiArICAg IHBhZGRyX3QgbmRfZW5kID0gZW5kOw0KPiA+ICsgICAgc3RydWN0IG5vZGUgKm5kID0gJm5vZGVz W25vZGVdOw0KPiA+ICsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBGb3IgdGhlIG5vZGUgdGhh dCBhbHJlYWR5IGhhcyBzb21lIG1lbW9yeSBibG9ja3MsIHdlIHdpbGwNCj4gPiArICAgICAqIGV4 cGFuZCB0aGUgbm9kZSBtZW1vcnkgcmFuZ2UgdGVtcG9yYXJpbHkgdG8gY2hlY2sgbWVtb3J5DQo+ ID4gKyAgICAgKiBpbnRlcmxlYXZlcyB3aXRoIG90aGVyIG5vZGVzLiBXZSB3aWxsIG5vdCB1c2Ug dGhpcyBub2RlDQo+ID4gKyAgICAgKiB0ZW1wIG1lbW9yeSByYW5nZSB0byBjaGVjayBvdmVybGFw cywgYmVjYXVzZSBpdCB3aWxsIG1hc2sNCj4gPiArICAgICAqIHRoZSBvdmVybGFwcyBpbiBzYW1l IG5vZGUuDQo+ID4gKyAgICAgKg0KPiA+ICsgICAgICogTm9kZSB3aXRoIDAgYnl0ZXMgbWVtb3J5 IGRvZXNuJ3QgbmVlZCB0aGlzIGV4cGFuZHNpb24uDQo+IA0KPiBNaW5kIHRha2luZyB0aGUgb3Bw b3J0dW5pdHkgYW5kIGRyb3AgdGhlICdkJyBmcm9tICJleHBhbnNpb24iPw0KPiANCg0KT2suDQoN Cj4gPiArICAgICAqLw0KPiA+ICsgICAgaWYgKCBuZC0+c3RhcnQgIT0gbmQtPmVuZCApDQo+ID4g KyAgICB7DQo+ID4gKyAgICAgICAgaWYgKCBuZF9zdGFydCA+IG5kLT5zdGFydCApDQo+ID4gKyAg ICAgICAgICAgIG5kX3N0YXJ0ID0gbmQtPnN0YXJ0Ow0KPiA+ICsNCj4gPiArICAgICAgICBpZiAo IG5kX2VuZCA8IG5kLT5lbmQgKQ0KPiA+ICsgICAgICAgICAgICBuZF9lbmQgPSBuZC0+ZW5kOw0K PiA+ICsgICAgfQ0KPiA+ICsNCj4gPiArICAgIC8qIEl0IGlzIGZpbmUgdG8gYWRkIHRoaXMgYXJl YSB0byB0aGUgbm9kZXMgZGF0YSBpdCB3aWxsIGJlIHVzZWQNCj4gbGF0ZXIgKi8NCj4gPiArICAg IHN3aXRjaCAoIGNvbmZsaWN0aW5nX21lbWJsa3Mobm9kZSwgc3RhcnQsIGVuZCwgbmRfc3RhcnQs IG5kX2VuZCwNCj4gJmkpICkNCj4gPiArICAgIHsNCj4gPiArICAgIGNhc2UgT1ZFUkxBUDoNCj4g PiArICAgICAgICBpZiAoIG1lbWJsa19ub2RlaWRbaV0gPT0gbm9kZSApDQo+ID4gKyAgICAgICAg ew0KPiA+ICsgICAgICAgICAgICBib29sIG1pc21hdGNoID0gIShob3RwbHVnKSAhPSAhdGVzdF9i aXQoaSwgbWVtYmxrX2hvdHBsdWcpOw0KPiANCj4gTm8gbmVlZCB0byBwYXJlbnRoZXNpemUgImhv dHBsdWciIGhlcmUuDQo+IA0KDQpPaw0KDQo+ID4gKyAgICAgICAgICAgIHByaW50aygiJXNOVU1B OiAlcyAldSBbJSJQUklwYWRkciIsICUiUFJJcGFkZHIiXSBvdmVybGFwcw0KPiB3aXRoIGl0c2Vs ZiBbJSJQUklwYWRkciIsICUiUFJJcGFkZHIiXVxuIiwNCj4gPiArICAgICAgICAgICAgICAgICAg IG1pc21hdGNoID8gS0VSTl9FUlIgOiBLRVJOX1dBUk5JTkcsIHByZWZpeCwNCj4gPiArICAgICAg ICAgICAgICAgICAgIGFyY2hfbmlkLCBzdGFydCwgZW5kIC0gMSwNCj4gPiArICAgICAgICAgICAg ICAgICAgIG5vZGVfbWVtYmxrX3JhbmdlW2ldLnN0YXJ0LCBub2RlX21lbWJsa19yYW5nZVtpXS5l bmQNCj4gLSAxKTsNCj4gPiArICAgICAgICAgICAgaWYgKCBtaXNtYXRjaCApDQo+ID4gKyAgICAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7DQo+ID4gKyAgICAgICAgICAgIGJyZWFrOw0KPiA+ICsg ICAgICAgIH0NCj4gPiArDQo+ID4gKyAgICAgICAgcHJpbnRrKEtFUk5fRVJSDQo+ID4gKyAgICAg ICAgICAgICAgICJOVU1BOiAlcyAldSBbJSJQUklwYWRkciIsICUiUFJJcGFkZHIiXSBvdmVybGFw cw0KPiB3aXRoICVzICV1IFslIlBSSXBhZGRyIiwgJSJQUklwYWRkciJdXG4iLA0KPiA+ICsgICAg ICAgICAgICAgICBwcmVmaXgsIGFyY2hfbmlkLCBzdGFydCwgZW5kIC0gMSwgcHJlZml4LA0KPiA+ ICsgICAgICAgICAgICAgICBudW1hX25vZGVfdG9fYXJjaF9uaWQobWVtYmxrX25vZGVpZFtpXSks DQo+ID4gKyAgICAgICAgICAgICAgIG5vZGVfbWVtYmxrX3JhbmdlW2ldLnN0YXJ0LCBub2RlX21l bWJsa19yYW5nZVtpXS5lbmQgLQ0KPiAxKTsNCj4gPiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+ ID4gKw0KPiA+ICsNCj4gPiArICAgIGNhc2UgSU5URVJMRUFWRToNCj4gDQo+IFBsZWFzZSBkb24n dCBhZGQgZG91YmxlIGJsYW5rIGxpbmVzIGFueXdoZXJlIChvcmlnaW5hbCBjb2RlIGRpZG4ndCBo YXZlDQo+IHRoZXNlKTsgdGhlcmUncyBhdCBsZWFzdCBvbmUgbW9yZSBpbnN0YW5jZSBiZWxvdy4N Cj4gDQoNCkkgd2lsbCBjaGVjayB0aGUgY29kZSBhbmQgZml4IHRoZW0uDQoNCj4gPiArc3RhdGlj IGludCBfX2luaXQgbm9kZXNfY292ZXJfbWVtb3J5KHZvaWQpDQo+ID4gK3sNCj4gPiArICAgIHVu c2lnbmVkIGludCBpOw0KPiA+ICsNCj4gPiArICAgIGZvciAoIGkgPSAwOyA7IGkrKyApDQo+ID4g KyAgICB7DQo+ID4gKyAgICAgICAgaW50IGVycjsNCj4gPiArICAgICAgICBib29sIGZvdW5kOw0K PiA+ICsgICAgICAgIHVuc2lnbmVkIGludCBqOw0KPiA+ICsgICAgICAgIHBhZGRyX3Qgc3RhcnQs IGVuZDsNCj4gPiArDQo+ID4gKyAgICAgICAgLyogVHJ5IHRvIGxvb3AgbWVtb3J5IG1hcCBmcm9t IGluZGV4IDAgdG8gZW5kIHRvIGdldCBSQU0gcmFuZ2VzLg0KPiAqLw0KPiA+ICsgICAgICAgIGVy ciA9IGFyY2hfZ2V0X3JhbV9yYW5nZShpLCAmc3RhcnQsICZlbmQpOw0KPiA+ICsNCj4gPiArICAg ICAgICAvKiBSZWFjaCB0aGUgZW5kIG9mIGFyY2gncyBtZW1vcnkgbWFwICovDQo+ID4gKyAgICAg ICAgaWYgKCBlcnIgPT0gLUVOT0VOVCApDQo+ID4gKyAgICAgICAgICAgIGJyZWFrOw0KPiA+ICsN Cj4gPiArICAgICAgICAvKiBJbmRleCByZWxhdGUgZW50cnkgaXMgbm90IFJBTSwgc2tpcCBpdC4g Ki8NCj4gPiArICAgICAgICBpZiAoIGVyciApDQo+ID4gKyAgICAgICAgICAgIGNvbnRpbnVlOw0K PiA+ICsNCj4gPiArICAgICAgICBkbyB7DQo+ID4gKyAgICAgICAgICAgIGZvdW5kID0gZmFsc2U7 DQo+ID4gKyAgICAgICAgICAgIGZvcl9lYWNoX25vZGVfbWFzayggaiwgbWVtb3J5X25vZGVzX3Bh cnNlZCApDQo+IA0KPiBQbGVhc2UgYmUgY29uc2lzdGVudCB3aXRoIHN0eWxlIGZvciBjb25zdHJ1 Y3RzIGxpa2UgdGhpcyBvbmU6IEVpdGhlcg0KPiB5b3UgY29uc2lkZXIgZm9yX2VhY2hfbm9kZV9t YXNrIGEgcHNldWRvLWtleXdvcmQgKGFsb25nIHRoZSBsaW5lcyBvZg0KPiBmb3IoOzspKSwgdGhl biB0aGVyZSdzIGEgYmxhbmsgbWlzc2luZyBhaGVhZCBvZiB0aGUgb3BlbmluZw0KPiBwYXJlbnRo ZXNpcy4gT3IgeW91IGNvbnNpZGVyIHRoaXMgYW4gb3JkaW5hcnkgaWRlbnRpZmllciAoaS5lLiB0 aGUNCj4gZnVuY3Rpb24tbGlrZSBtYWNybyB0aGF0IGl0IGlzKSwgdGhlbiB0aGVyZSBzaG91bGRu J3QgYmUgYmxhbmtzDQo+IGltbWVkaWF0ZWx5IGluc2lkZSB0aGUgcGFyZW50aGVzZXMuIChTYW1l IGlzc3VlIGVsc2V3aGVyZS4pDQo+IA0KDQpJIHdpbGwgY2hlY2sgdGhlIGNvZGUgYW5kIGZpeCB0 aGVtLg0KDQo+ID4gKyAgICAgICAgICAgICAgICBpZiAoIHN0YXJ0IDwgbm9kZXNbal0uZW5kDQo+ ID4gKyAgICAgICAgICAgICAgICAgICAgJiYgZW5kID4gbm9kZXNbal0uc3RhcnQgKQ0KPiA+ICsg ICAgICAgICAgICAgICAgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgIGlmICggc3RhcnQgPj0g bm9kZXNbal0uc3RhcnQgKQ0KPiA+ICsgICAgICAgICAgICAgICAgICAgIHsNCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgc3RhcnQgPSBub2Rlc1tqXS5lbmQ7DQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgIGZvdW5kID0gdHJ1ZTsNCj4gPiArICAgICAgICAgICAgICAgICAgICB9DQo+ ID4gKw0KPiA+ICsgICAgICAgICAgICAgICAgICAgIGlmICggZW5kIDw9IG5vZGVzW2pdLmVuZCAp DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICBlbmQgPSBub2Rlc1tqXS5zdGFydDsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgZm91 bmQgPSB0cnVlOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgIH0NCj4gPiArICAgICAgICAgICAg ICAgIH0NCj4gPiArICAgICAgICB9IHdoaWxlICggZm91bmQgJiYgc3RhcnQgPCBlbmQgKTsNCj4g PiArDQo+ID4gKyAgICAgICAgaWYgKCBzdGFydCA8IGVuZCApDQo+ID4gKyAgICAgICAgew0KPiA+ ICsgICAgICAgICAgICBwcmludGsoS0VSTl9FUlIgIk5VTUE6IE5vIG5vZGUgZm9yIFJBTSByYW5n ZTogIg0KPiA+ICsgICAgICAgICAgICAgICAgICAgIlslIlBSSXBhZGRyIiwgJSJQUklwYWRkciJd XG4iLCBzdGFydCwgZW5kIC0gMSk7DQo+ID4gKyAgICAgICAgICAgIHJldHVybiAwOw0KPiA+ICsg ICAgICAgIH0NCj4gPiArICAgIH0NCj4gPiArICAgIHJldHVybiAxOw0KPiA+ICt9DQo+IA0KPiBT ZWVpbmcgdGhlIHR3byByZXR1cm5zIChhbmQgbm8gZnVydGhlciBvbmVzIGluIHRoZSBmdW5jdGlv bikgLSBkaWQNCj4geW91IG5vdCBtZWFuIHRvIGFsc28gc3dpdGNoIHRvIGJvb2wvdHJ1ZS9mYWxz ZSBoZXJlPw0KPiANCg0KT2ssIEkgd2lsbCBzd2l0Y2ggdGhlIHJldHVybiB2YWx1ZSB0byBib29s IGFuZCBmaW5kIGlmIHRoZXJlIHN0aWxsIGFyZQ0Kc29tZSBvdGhlciBmdW5jdGlvbnMgdGhhdCBj YW4gc3dpdGNoIHRvIGJvb2wuDQoNCj4gPiArLyogVXNlIHRoZSBpbmZvcm1hdGlvbiBkaXNjb3Zl cmVkIGFib3ZlIHRvIGFjdHVhbGx5IHNldCB1cCB0aGUgbm9kZXMuDQo+ICovDQo+ID4gK3N0YXRp YyBib29sIF9faW5pdCBudW1hX3NjYW5fbm9kZXMocGFkZHJfdCBzdGFydCwgcGFkZHJfdCBlbmQp DQo+IA0KPiBJcyAiYWJvdmUiIGluIHRoZSBjb21tZW50IGFjdHVhbGx5IHN0aWxsIGFjY3VyYXRl PyBBaXVpIHRoZSBkaXNjb3ZlcnkNCj4gaXMgbm93IGluIGEgZGlmZmVyZW50IENVLiBUaGVuIHBl cmhhcHMgIlVzZSBkaXNjb3ZlcmVkIGluZm9ybWF0aW9uIHRvDQo+IGFjdHVhbGx5IHNldCB1cCB0 aGUgbm9kZXMuIg0KPiANCg0KT2suDQoNCj4gPiArew0KPiA+ICsgICAgdW5zaWduZWQgaW50IGk7 DQo+ID4gKyAgICBub2RlbWFza190IGFsbF9ub2Rlc19wYXJzZWQ7DQo+ID4gKw0KPiA+ICsgICAg LyogRmlyc3QgY2xlYW4gdXAgdGhlIG5vZGUgbGlzdCAqLw0KPiA+ICsgICAgZm9yICggaSA9IDA7 IGkgPCBNQVhfTlVNTk9ERVM7IGkrKyApDQo+ID4gKyAgICAgICAgY3V0b2ZmX25vZGUoaSwgc3Rh cnQsIGVuZCk7DQo+ID4gKw0KPiA+ICsgICAgLyogV2hlbiBudW1hIGlzIG9uIHdpdGggZ29vZCBm aXJtd2FyZSwgd2UgY2FuIGRvIG51bWEgc2NhbiBub2Rlcy4NCj4gKi8NCj4gPiArICAgIGlmICgg YXJjaF9udW1hX2Rpc2FibGVkKHRydWUpICkNCj4gPiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+ IA0KPiBCdHcgLSB0aGUgY29tbWVudCBoZXJlIGRvZXNuJ3QgaGVscCBtZSBmaWd1cmUgeW91ciBj aG9pY2Ugb2YNCj4gImluaXRfYXNfZGlzYWJsZWQiLiBUaGUgd29yZGluZyB0b3dhcmRzIHRoZSBl bmQgaXMgYWxzbyBhIGxpdHRsZQ0KPiBvZGQsIGNvbnNpZGVyaW5nIHdlJ3JlIGFscmVhZHkgaW4g bnVtYV9zY2FuX25vZGVzKCkuIFdoaWNoIGZ1cnRoZXINCj4gcG9pbnRzIG91dCB0aGF0IHJlYWxs eSB0aGVyZSdzIG5vIHNjYW5uaW5nIGhlcmUsIGp1c3QgcHJvY2Vzc2luZywNCj4gc28gbWF5YmUg dGhlIGVhcmxpZXIgcGF0Y2ggd2FudHMgdG8gcmVuYW1lIHRoZSBmdW5jdGlvbiB0bw0KPiBudW1h X3Byb2Nlc3Nfbm9kZXMoKT8NCj4gDQoNClllcywgc2NhbiB3aWxsIG1ha2Ugc29tZSBjb25mdXNp b24sIHlvdXIgc3VnZ2VzdGlvbiBtYWtlIHNlbnNlLCBJIHdpbGwNCmZpeCBpdCBpbiBuZXh0IHZl cnNpb24uDQoNCj4gPiArICAgIGlmICggIW5vZGVzX2NvdmVyX21lbW9yeSgpICkNCj4gPiArICAg IHsNCj4gPiArICAgICAgICBudW1hX2Z3X2JhZCgpOw0KPiA+ICsgICAgICAgIHJldHVybiBmYWxz ZTsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4gKyAgICBtZW1ub2RlX3NoaWZ0ID0gY29tcHV0ZV9o YXNoX3NoaWZ0KG5vZGVfbWVtYmxrX3JhbmdlLA0KPiBudW1fbm9kZV9tZW1ibGtzLA0KPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZW1ibGtfbm9kZWlkKTsNCj4g PiArDQo+ID4gKyAgICBpZiAoIG1lbW5vZGVfc2hpZnQgPCAwICkNCj4gDQo+IEFzIHByZXZpb3Vz bHkgcG9pbnRlZCBvdXQ6IEFzIG9mIHBhdGNoIDIgbWVtbm9kZV9zaGlmdCBpcyB1bnNpZ25lZCwN Cj4gc28gdGhpcyBjb21wYXJpc29uIGlzIGFsd2F5cyBmYWxzZSAoYW5kIHRoZSBsYXRlc3QgQ292 ZXJpdHkgd2lsbA0KPiBwb2ludCB0aGlzIG91dCkuIFlvdSBjYW4ndCBnZXQgYXdheSBoZXJlIHdp dGhvdXQgdXNpbmcgYW4gaW50ZXJtZWRpYXRlDQo+IChzaWduZWQsIGkuZS4gcGxhaW4gaW50KSB2 YXJpYWJsZS4NCj4gDQoNClllcywgeW91J3JlIHJpZ2h0LCBJIHdpbGwgaW50cm9kdWNlIGEgbmV3 IGludCB2YXJpYWJsZSBmb3IgcmV0dXJuIHZhbHVlDQpjaGVja2luZy4NCg0KPiA+ICsgICAgew0K PiA+ICsgICAgICAgIHByaW50ayhLRVJOX0VSUg0KPiA+ICsgICAgICAgICAgICAgICAiTlVNQTog Tm8gTlVNQSBub2RlIGhhc2ggZnVuY3Rpb24gZm91bmQuIENvbnRhY3QNCj4gbWFpbnRhaW5lclxu Iik7DQo+ID4gKyAgICAgICAgbnVtYV9md19iYWQoKTsNCj4gPiArICAgICAgICByZXR1cm4gZmFs c2U7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgbm9kZXNfb3IoYWxsX25vZGVzX3BhcnNl ZCwgbWVtb3J5X25vZGVzX3BhcnNlZCwNCj4gcHJvY2Vzc29yX25vZGVzX3BhcnNlZCk7DQo+ID4g Kw0KPiA+ICsgICAgLyogRmluYWxseSByZWdpc3RlciBub2RlcyAqLw0KPiA+ICsgICAgZm9yX2Vh Y2hfbm9kZV9tYXNrKCBpLCBhbGxfbm9kZXNfcGFyc2VkICkNCj4gPiArICAgIHsNCj4gPiArICAg ICAgICBpZiAoIG5vZGVzW2ldLmVuZCAtIG5vZGVzW2ldLnN0YXJ0ID09IDAgKQ0KPiANCj4gbm9k ZXNbaV0uZW5kID09IG5vZGVzW2ldLnN0YXJ0ID8NCj4gDQoNClllcy4NCg0KPiA+ICsgICAgICAg ICAgICBwcmludGsoS0VSTl9JTkZPICJOVU1BOiBub2RlICV1IGhhcyBubyBtZW1vcnlcbiIsIGkp Ow0KPiA+ICsNCj4gPiArICAgICAgICBzZXR1cF9ub2RlX2Jvb3RtZW0oaSwgbm9kZXNbaV0uc3Rh cnQsIG5vZGVzW2ldLmVuZCk7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgZm9yICggaSA9 IDA7IGkgPCBucl9jcHVfaWRzOyBpKysgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGlmICgg Y3B1X3RvX25vZGVbaV0gPT0gTlVNQV9OT19OT0RFICkNCj4gPiArICAgICAgICAgICAgY29udGlu dWU7DQo+ID4gKyAgICAgICAgaWYgKCAhbm9kZW1hc2tfdGVzdChjcHVfdG9fbm9kZVtpXSwgJnBy b2Nlc3Nvcl9ub2Rlc19wYXJzZWQpICkNCj4gPiArICAgICAgICAgICAgbnVtYV9zZXRfbm9kZShp LCBOVU1BX05PX05PREUpOw0KPiA+ICsgICAgfQ0KPiA+ICsgICAgbnVtYV9pbml0X2FycmF5KCk7 DQo+ID4gKyAgICByZXR1cm4gdHJ1ZTsNCj4gPiAgfQ0KPiANCj4gV2hpbGUgeW91IHNhaWQgeW91 J2QgY2hlY2sgZWxzZXdoZXJlIGFzIHdlbGwsIGp1c3QgdG8gYmUgc3VyZTogUGxlYXNlDQo+IGFk ZCBhIGJsYW5rIGxpbmUgYmVmb3JlIHRoZSBmdW5jdGlvbidzIG1haW4gInJldHVybiIuIEFuZCBw ZXJoYXBzDQo+IGFub3RoZXIgb25lIGJldHdlZW4gbG9vcCBhbmQgZnVuY3Rpb24gY2FsbC4NCj4g DQoNCk9rLg0KDQo+ID4gLS0tIGEveGVuL2RyaXZlcnMvYWNwaS9LY29uZmlnDQo+ID4gKysrIGIv eGVuL2RyaXZlcnMvYWNwaS9LY29uZmlnDQo+ID4gQEAgLTcsNCArNyw1IEBAIGNvbmZpZyBBQ1BJ X0xFR0FDWV9UQUJMRVNfTE9PS1VQDQo+ID4NCj4gPiAgY29uZmlnIEFDUElfTlVNQQ0KPiA+ICAJ Ym9vbA0KPiA+ICsJc2VsZWN0IEhBU19OVU1BX05PREVfRldJRA0KPiANCj4gQXJlIHlvdSBzZWxl Y3RpbmcgYW4gb3B0aW9uIGhlcmUgd2hpY2ggZG9lc24ndCBleGlzdCBhbnl3aGVyZT8gT3INCj4g YW0gSSBvdmVybG9va2luZyB3aGVyZSB0aGlzIG5ldyBvcHRpb24gaXMgYmVpbmcgYWRkZWQ/DQo+ IA0KDQpZZXMsIHRoaXMgaXMgYSBuZXcgS2NvbmZpZyBvcHRpb24uIFNob3VsZCBJIG5lZWQgdG8g aW50cm9kdWNlIGluIGENCnNlcGFyYXRlIHBhdGNoPw0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+ IEphbg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:02:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:02:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403449.645569 (Exim 4.92) (envelope-from ) id 1oWJyS-0006Td-NX; Thu, 08 Sep 2022 16:01:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403449.645569; Thu, 08 Sep 2022 16:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJyS-0006TW-KW; Thu, 08 Sep 2022 16:01:52 +0000 Received: by outflank-mailman (input) for mailman id 403449; Thu, 08 Sep 2022 16:01:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWJyR-0006TQ-3v for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:01:51 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80045.outbound.protection.outlook.com [40.107.8.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b7ba6e7-2f8f-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 18:01:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8277.eurprd04.prod.outlook.com (2603:10a6:20b:3fc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Thu, 8 Sep 2022 16:01:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 16:01:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b7ba6e7-2f8f-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLIsWOhGnDhgfTqQKYR/wxEy0MmFraMGrWkelxMNTwXmqBHjW4dENDOU2z7Q6IG+wdz80NQ/vD4SiAHcBjFySwzrk2/W0F0NT7n2ng3dFQaQG+WrYrbDEKsR1GzUfin8QxW0bH4RFq2ojx1G8zqCY/6Gto2YrsPeAfDj4KNimw94Zh+uXJa0xGRmgI8BP5VQslV475Z9D5RjQNqtgG21Wke3X2HOqWUyhF98neb8jA/+aCv92gTN8GRUou4U9o/JPPphkmXU6t+bl3iY7o2wWtZ86E1uSKf6kmtITdwZsaZHvInUJwNDwCRCUgIXOBv9HS+pFBbfz5GYQ5QhTclKDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6R8v5F9BSinZzVuDSIJ8utL4egZv2vn5xb4qQq6px5s=; b=bmpxeM3LNyqi4ZW57XJD/y5Rj+f+Xrg6jp8/wbP+uKPYqFYY2yKzbVsEsr+VXvc1DyDk3ovJYhv2Jqby/jEM19m1NTqOo+882uTEq6xAfQIhT6Pc+Kx3PY0b3SO6ncUFKOPKH6uX6Fx2MlrFcq1AdQeSHdjTGxWL9C92zcs6iE4yiODmLig2Uv7+pv/JpkeChOoA8RPtQl3caXGdFD8d4OIjOfpE0OcYIulun5b4V8cSBJtNsQ6akzDFV2NkbpQ3jTJ+DjfcPo29WjsuVCJP3PNm3g1f5nGcW+yGKNa2nv6z7rwZRlZk4aisShcrJXrCtSM0kFAMhAe9Yv7EgugsaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6R8v5F9BSinZzVuDSIJ8utL4egZv2vn5xb4qQq6px5s=; b=zLM8kgGZM4HeF/Yj8GdPLyLqHRbKfCSwISkYwozjsf6zTHb9zdIRnnxbiVheDTMFYgzrviRsgHmGwo0Jnl7s3hHHjQQ5dGUNieOB52eDFcyJpiKjPeKPM+kJvNEDYByZJypm+sPVeD7HokVOfzr5p/e3SJ+Uf4R6+IxGgmHjfFIboDxRkEUwX6y+HQgKYJdNnEek14VsY8/X7P9zZGNQhVItZTbsP3YeJmhX4CizJB+i5BrIcHeV3z5R8qIm0/pZ04sQYptWYLHL0Si4wrHsKgQAuknP5DF68OStWZSFz7+m8Yi5ltckSCCP65bgmDB9C5C3IMVlqyPHURBP3tmi4g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 8 Sep 2022 18:01:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-6-wei.chen@arm.com> <837f7b6d-0d73-a352-17e6-5c12e06dab95@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8277:EE_ X-MS-Office365-Filtering-Correlation-Id: 53808bd1-7f61-43c4-9b50-08da91b36eae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1GiQGb2CAxB6CzuOwiV6QbhGzv7LoQE3vFOln4krS/CMjS9fCJagMUNOTO8VcXLycBSHEEujXoUXVIgBuBCcKA2H745VbWCCpkXqha7zDps2GPsCbFRWOI+fN6WZ5xgkEhh3ILW2QCTZvQAofU4oJxVe/xG95twdZhFsUNF++TxkSmqasbSESDvARir3+ZoqsuJGOpa6vPn02bMc3Y+4gDKmduOjTVK/CS17IzO4dYF7XTngmzsiKudV70Z7BIoF4LLOA+qbwUjrz9vYyMFIU55F+1lut0nB3HzLQB95u0FOljnJzeP8nfuOpwodW4FQoJT5IPz6GH8ic9AaBr6ebaPyNdAL5ogBNtDOPt35z7srehqxCRbtnh6deIRtyjE+lv8ssHqOpszpHo8kBKloD432WrJskM6e3aBp8L0WBCp+H/KHD3LEHK8xN33PY70KijY31AjHKuJymY00xpAh/CAAJ8NHUOMad6cZazRkfaVKg+9JI/2i5X7BElTuIXj9TpPQGPj2S559M55jhUAP3+kw2+3kbTrBL258FX+t3jUVb2sfTwB4/3IHnaJNP4UueiHm8kJxXRYKKG7xu+kIbpRJGP0OmQZllhuSuWp7tCbNKTHI4vr9CyIvtycjp1cWBgwe70VfbADdft5kc42E2bynGrK/PLj6X2ZZf/nxzVvMJpk0D4Dqr/lB9o4F8S8htyUfN2kNfYVFCHhIz1qnZJGbuOgG4S/MdBmSz8TW94oXXQO4MivURk/o+VqNS80T8KbAwoLNtPeiCmWVkTuHlJrhXSph2oAiQoQublVJPtY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(39860400002)(396003)(346002)(478600001)(53546011)(6506007)(26005)(41300700001)(6512007)(83380400001)(186003)(38100700002)(8936002)(8676002)(2616005)(5660300002)(31686004)(4326008)(86362001)(66556008)(31696002)(66946007)(66476007)(36756003)(2906002)(54906003)(6916009)(316002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkExdy9nSmZHazBMVDFZamJZeXdFM1EwNE1qRlp3dFZ4VElCZVZYdURQNTJ3?= =?utf-8?B?T1hUR25BWUtZZ0c4M3NNOTJvUGFncnB2YnptQkNqaVhaUVh3N21teU95YVlJ?= =?utf-8?B?eVVEd0xYM2dDamNmNmxuMmVsTHFMRUo5ODFYZ1NmcEdLNDQvOXpDUjBRRERk?= =?utf-8?B?YnNNRjNGclhTVVI0YWVZMFV6eUt3Z0lNNjgyQ2pNN3RReWlPRVJWMzRLaDVK?= =?utf-8?B?WDlKZldXWTJqZzZra24xQ1hFUndLQmdBRDJZdHdQakVOU2ZTM3dFVlBPRStR?= =?utf-8?B?aStWRmJJNmxKSnJjVHRlK3FwVm9yUk9WWWwyQkFpVDZTWEJTVXFtbU9ZU0Ns?= =?utf-8?B?Nk93cHFDZmZDbkxUSk84YXB6Qzk0b1pkTHdiNGVCbmFrTHRJQzlGVDRXeUlY?= =?utf-8?B?MWhoOW9Dd0lqZU0xQk1DNkJORzZLSklaSFkzT3hxYWxZcTVzVENuL1JZZUhn?= =?utf-8?B?VythVXRMemhNd3Q3SmhacWp4S00raXdMWXduSDlzYXNBZ3E2ckVMek9Bekd6?= =?utf-8?B?djVpT1VmUUJwTXJoVExKbDIvTkVjN2VCZ3gvWE9ud0JQL2lMSVlZQVY2dU5Z?= =?utf-8?B?bkNodlN6amtSc0FoMHgwRTRDQ1E0aGp5emFpbkpXTWYzZUhoVTl1RThQZXpk?= =?utf-8?B?c3IwYlJ3Z0k3Vk90bmV1Qk1EMTB1eTJiQllDYmpBZURneWVrTEo3ZEo0K3pq?= =?utf-8?B?c2lOOWR5VU1SN1dDbldNVE5EeTk4SkprK3h1YVdsK1ViS0lJVDNKVWJyN2Rp?= =?utf-8?B?eDZ4WjZxeEFOWW9IMFM1aFdHalIwL01oYUR1RytCWVhuLzF0UTJzMkh6NVpF?= =?utf-8?B?YUVjMUl3VTVjZmhydlVCRWtlcjJTRlZPNEttZGFJeElKTWpSSURoSTFNOW80?= =?utf-8?B?bVkrcFVXOVlBeENuSmNnYVZsQjJMVjlrYUwzNnVUMEtnS0lMZkRWbUQwOFZP?= =?utf-8?B?dG1JdUs1Z0lOcFNsendBbGo1cmpJRkQrNGM0eFhwL29FN3FHeWZBRE5KdWhr?= =?utf-8?B?dmdZdDAvblFxRGs2S2ZWdElVM0tzQlMzOUg5dHA0K0N6a1ZhMWRXMEIxWC85?= =?utf-8?B?R0FmT0paeEQ3NGpHZ2t5cHMzOHcxTXBWc3NrNHZ4bUVwVmo5c2pqV1JuU1U5?= =?utf-8?B?YTN1NFp1NEN2ekFnQnhSVTd0VGcweWlELzNRUGQ0d25Ob0w1YzV5dUFHV25D?= =?utf-8?B?eVl1d2cwdWtkczBPRUViTVZiRzg0VDdxbklOWmxhU1ZiRUVmeW83WWUwd3Z1?= =?utf-8?B?alBWRlZBVXRMOXBhNG0rZWhpMmZEWk85Nll5MEQ3dlE4VkZyendYV3lyUSt6?= =?utf-8?B?UjRSd1RIN282Qk95UzdhejI1cVc0TVlLdTdmQnNyTzZuY0Y1MGZzSEVacS9l?= =?utf-8?B?VE8vQjZ0dFQ5ZE1aQ3JFclBicWFWK2M1SS9xUEdPbVNMcmZFR3k0R1Uzb0kv?= =?utf-8?B?bXRBbU0xcjEwTmlsZUR1dkFGTlVaTnFyVDVaQURGSkxEOXBMRW1vRnRHZlBN?= =?utf-8?B?ekhPL3p5NDRxVnhDWHRzWUVNT3F6aEhjOHVFZk0rR1JKWXlmcDcwTWFzU0Vq?= =?utf-8?B?UEY3NFYrQlVkTWg0NkFzN2xQa3ZhNmVQdGVDa2ZqOWJYM2FpMk5DYWZQVG50?= =?utf-8?B?YkhWVlIzQmo4aGpaRlNPZVlwWElLb3crRE9BVTRWZXlwZTVSVXZzOEJnM3I3?= =?utf-8?B?aEQ4QjZpSWE4MDNvdE11QlhLMnVSVlVXMWVtdGdKdlJPRG5UcFdSUEtiQXpy?= =?utf-8?B?U2paTTlUN2I1OFN5eVFZMkVXeFU2SkxsUUhMZnErd0RmUnZuMUl6dVZ4alZC?= =?utf-8?B?OVd5b0ZHSWxjYjB5MndTL3hZTWZ3d2ZrRjhIdndaYkZUbjU5WFhvUTlwT0Rs?= =?utf-8?B?VjdvVHM2eG1XU2o3b0hsY3Brd3RlbmpPbHdKWG50a2ZsV0NZelQwRUE2TFdr?= =?utf-8?B?eHZEcnZTOG1iZ0JLM2phMzJrVkZJcGtobTZKOHhzYjBwUFJUSWtHMENVTm1J?= =?utf-8?B?ZEFXRGNIeVJZc25jNmRBRHo2a01SL2ZEK3FGb2V4MDNPajVhODZNUWM3djJV?= =?utf-8?B?cDM3SWt4R05pQVRLbGg3aHBlcXRES2pWdXlva3RUS3ljdTNTVWlVaUFZSnM2?= =?utf-8?Q?T4IcIOq0CsQssJ+xrTSqY/KoW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53808bd1-7f61-43c4-9b50-08da91b36eae X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 16:01:46.9550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J0GlpKxokYedC86+YX67PgBh3mF2Kx2Nj7d8X14EvCG86VtPv4uBVYS5RVAfmfEQ3GIIy/vqSKK5BXlO2llqog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8277 On 08.09.2022 17:26, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年9月8日 21:03 >> >> On 02.09.2022 05:31, Wei Chen wrote: >>> --- a/xen/arch/x86/numa.c >>> +++ b/xen/arch/x86/numa.c >>> @@ -41,9 +41,12 @@ int __init arch_numa_setup(const char *opt) >>> return -EINVAL; >>> } >>> >>> -bool arch_numa_disabled(void) >>> +bool arch_numa_disabled(bool init_as_disable) >> >> I'm afraid my question as to the meaning of the name of the parameter has >> remained unanswered. >> > > Sorry, I might missed some contents of your reply in v3. The name of this > parameter has been bothering me for a long time, and now this is actually > quite awkward. The origin of this parameter is because the current NUMA > implementation will make different judgments under different usage > conditions when using acpi_numa. In acpi_scan_nodes, it uses acpi_numa <= 0 > as the condition for judging that ACPI NUMA is turned off. But only use > acpi_numa < 0 as condition in srat_disabled and elsewhere. I use this > parameter in the hope that we can keep the same semantics as the original > code without changing the code of the caller. The difference is "bad only" vs "bad or no data". Maybe that's easier to express via two functions - arch_numa_disabled() (checking <= 0) and arch_numa_broken() (checking < 0)? With a single function I guess the name of the parameter would always be clumsy at best. Unless someone has a good idea for a suitable name ... >>> --- a/xen/drivers/acpi/Kconfig >>> +++ b/xen/drivers/acpi/Kconfig >>> @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP >>> >>> config ACPI_NUMA >>> bool >>> + select HAS_NUMA_NODE_FWID >> >> Are you selecting an option here which doesn't exist anywhere? Or >> am I overlooking where this new option is being added? >> > > Yes, this is a new Kconfig option. Should I need to introduce in a > separate patch? I don't think that'll need to be in a separate patch; it can simply be another hunk in the one here, adding the needed 2 lines (plus a blank one) to, presumably, common/Kconfig. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:08:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403455.645579 (Exim 4.92) (envelope-from ) id 1oWK5H-00079A-E9; Thu, 08 Sep 2022 16:08:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403455.645579; Thu, 08 Sep 2022 16:08:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWK5H-000793-BT; Thu, 08 Sep 2022 16:08:55 +0000 Received: by outflank-mailman (input) for mailman id 403455; Thu, 08 Sep 2022 16:08:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWK5G-00078t-0u; Thu, 08 Sep 2022 16:08:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWK5F-0003MV-Un; Thu, 08 Sep 2022 16:08:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWK5F-0000Ds-H0; Thu, 08 Sep 2022 16:08:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWK5F-0003Je-GU; Thu, 08 Sep 2022 16:08:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q6SA/LROpbx+DkYCq/JduaT26gYNdqvptjtYW3iKxSc=; b=TZgo9EYrDZ4fdcsa8/8CjXQwaf 96+EnIG0yFGSfM/HzEdGjd9KJnAdqTwhUfaccEi3oAK4dsOR7w8r81gSZj/k9ynv0ghwXTSL6z29s TH7iJPs74q/UsLYPMD8Z0EcP0HXJSvx6SKVlHaa9w/5/QbjJ94SBiXYmMx4mU69S1Gcs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173066: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=d82ec90f51f61c914396271d86e64a74121dde24 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 16:08:53 +0000 flight 173066 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173066/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf d82ec90f51f61c914396271d86e64a74121dde24 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 267 attempts Testing same since 173057 2022-09-08 03:17:03 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2203 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:33:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:33:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403474.645602 (Exim 4.92) (envelope-from ) id 1oWKSe-0002nP-NJ; Thu, 08 Sep 2022 16:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403474.645602; Thu, 08 Sep 2022 16:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSe-0002n6-JI; Thu, 08 Sep 2022 16:33:04 +0000 Received: by outflank-mailman (input) for mailman id 403474; Thu, 08 Sep 2022 16:33:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSd-0002V6-NJ for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:33:03 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d0f4d5c1-2f7d-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:54:54 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F804106F; Thu, 8 Sep 2022 06:55:34 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E6AFF3F7B4; Thu, 8 Sep 2022 06:55:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0f4d5c1-2f7d-11ed-9760-273f2230c3a0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v8 1/9] xen/arm: introduce static shared memory Date: Thu, 8 Sep 2022 21:55:05 +0800 Message-Id: <20220908135513.1800511-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - return errno immediately when overflow checks meet - remove pointless WARN() --- v7 changes: - add docs about checking for region overlap, etc - update docs to reflect that the host physical address is optional - end/bank_end may end up to be lower than paddr/mem->bank[i].start, So check that they don't overflow. - replace strcmp with strncmp since the string has already be validated - provide a dummy helper for process_shm_node() when !CONFIG_STATIC_SHM - remove useless #ifdef CONFIG_STATIC_SHM - change the order of property xen,shared-mem to xen,shared-mem = < [host physical address] [guest address] [size] > --- v6 change: - when host physical address is ommited, output the error message since xen doesn't support it at the moment - add the following check: 1) The shm ID matches and the region exactly match 2) The shm ID doesn't match and the region doesn't overlap - change it to "unsigned int" to be aligned with nr_banks - check the len of the property to confirm is it big enough to contain "paddr", "size", and "gaddr" - shm_id defined before nr_shm_domain, so we could re-use the existing hole and avoid increasing the size of the structure. - change "nr_shm_domain" to "nr_shm_borrowers", to not increment if the role is owner in parsing code - make "xen,shm_id" property as arbitrary string, with a strict limit on the number of characters, MAX_SHM_ID_LENGTH --- v5 change: - no change --- v4 change: - nit fix on doc --- v3 change: - make nr_shm_domain unsigned int --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 132 ++++++++++++++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 167 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 7 ++ 4 files changed, 312 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 5ba7d186aa..0acd42f1a8 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -426,3 +426,135 @@ Below is an example on how to specify the static heap in device tree: RAM starting from the host physical address 0x30000000 of 1GB size will be reserved as static heap. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An arbitrary string that represents the unique identifier of the shared + memory region, with a strict limit on the number of characters(\0 included), + `MAX_SHM_ID_LENGTH(16)`. e.g. "xen,shm-id = "my-shared-mem-1"". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. + e.g. xen,shared-mem = < [host physical address] [guest address] [size] > + + It shall also meet the following criteria: + 1) If the SHM ID matches with an existing region, the address range of the + region shall also exactly match. + 2) If the SHM ID does not match with any other existing region, it should + also not overlap with any other regions. + + The number of cells for the host address (and size) is the same as the + guest pseudo-physical address and they are inherited from the parent node. + + Host physical address is optional, when missing Xen decides the location + (currently unimplemented). + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + DOMID_IO, a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x50000000 0x10000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x60000000 0x20000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x70000000 0x20000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as "my-shared-mem-0", host +physical address starting at 0x10000000 of 256MB will be reserved to be +shared between Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest +physical address space, and at 0x50000000 in DomU1 guest physical address space. +Dom0 is explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as "my-shared-mem-1", host +physical address starting at 0x50000000 of 512MB will be reserved to be +shared between DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest +physical address space, and at 0x70000000 in DomU2 guest physical address space. +DomU1 and DomU2 are both the borrower domain, the owner domain is the default +owner domain DOMID_IO. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 33e004d702..1fe5faf847 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -140,6 +140,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 787c7b41be..882a99f22e 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -390,6 +391,170 @@ static int __init process_domain_node(const void *fdt, int node, MEMBANK_STATIC_DOMAIN); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + const struct fdt_property *prop, *prop_id, *prop_role; + const __be32 *cell; + paddr_t paddr, gaddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned int i; + int len; + bool owner = false; + const char *shm_id; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + /* + * "xen,shm-id" property holds an arbitrary string with a strict limit + * on the number of characters, MAX_SHM_ID_LENGTH + */ + prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); + if ( !prop_id ) + return -ENOENT; + shm_id = (const char *)prop_id->data; + if ( strnlen(shm_id, MAX_SHM_ID_LENGTH) == MAX_SHM_ID_LENGTH ) + { + printk("fdt: invalid xen,shm-id %s, it must be limited to %u characters\n", + shm_id, MAX_SHM_ID_LENGTH); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * it must be either `owner` or `borrower`. + */ + prop_role = fdt_get_property(fdt, node, "role", NULL); + if ( prop_role ) + { + if ( !strcmp(prop_role->data, "owner") ) + owner = true; + else if ( strcmp(prop_role->data, "borrower") ) + { + printk("fdt: invalid `role` property for static shared memory node.\n"); + return -EINVAL; + } + } + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + prop = fdt_get_property(fdt, node, "xen,shared-mem", &len); + if ( !prop ) + return -ENOENT; + + if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) + { + if ( len == dt_cells_to_size(size_cells + address_cells) ) + printk("fdt: host physical address must be chosen by users at the moment.\n"); + + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } + + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); + size = dt_next_cell(size_cells, &cell); + + if ( !size ) + { + printk("fdt: the size for static shared memory region can not be zero\n"); + return -EINVAL; + } + + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * Meet the following check: + * 1) The shm ID matches and the region exactly match + * 2) The shm ID doesn't match and the region doesn't overlap + * with an existing one + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + { + if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + break; + else + { + printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", + shm_id); + return -EINVAL; + } + } + else + { + paddr_t end = paddr + size; + paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + + if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) + { + printk("fdt: static shared memory region %s overflow\n", shm_id); + return -EINVAL; + } + + if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + { + if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) + continue; + else + { + printk("fdt: different shared memory region could not share the same shm ID %s\n", + shm_id); + return -EINVAL; + } + } + else + { + printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", + mem->bank[i].start, bank_end); + return -EINVAL; + } + } + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].type = MEMBANK_STATIC_DOMAIN; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of borrowers, which later may be used + * to calculate the reference count. + */ + if ( !owner ) + mem->bank[i].nr_shm_borrowers++; + + return 0; +} +#else +static int __init process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + printk("CONFIG_STATIC_SHM must be enabled for parsing static shared memory nodes\n"); + return -EINVAL; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -415,6 +580,8 @@ static int __init early_scan_node(const void *fdt, rc = process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 9374b92441..74a052fe76 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -43,10 +43,17 @@ enum membank_type { MEMBANK_STATIC_HEAP, }; +/* Indicates the maximum number of characters(\0 included) for shm_id */ +#define MAX_SHM_ID_LENGTH 16 + struct membank { paddr_t start; paddr_t size; enum membank_type type; +#ifdef CONFIG_STATIC_SHM + char shm_id[MAX_SHM_ID_LENGTH]; + unsigned int nr_shm_borrowers; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:33:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:33:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403470.645591 (Exim 4.92) (envelope-from ) id 1oWKSa-0002Vd-Dm; Thu, 08 Sep 2022 16:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403470.645591; Thu, 08 Sep 2022 16:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSa-0002VW-Aa; Thu, 08 Sep 2022 16:33:00 +0000 Received: by outflank-mailman (input) for mailman id 403470; Thu, 08 Sep 2022 16:32:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSZ-0002V6-MI for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:32:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id e124b17f-2f7d-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:55:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47A40106F; Thu, 8 Sep 2022 06:56:01 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 529DC3F7B4; Thu, 8 Sep 2022 06:55:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e124b17f-2f7d-11ed-9760-273f2230c3a0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng , Michal Orzel , Julien Grall Subject: [PATCH v8 9/9] xen: Add static memory sharing in SUPPORT.md Date: Thu, 8 Sep 2022 21:55:13 +0800 Message-Id: <20220908135513.1800511-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit on ARM, static memory sharing is tech preview, which shall be documented in SUPPORT.md Signed-off-by: Penny Zheng Reviewed-by: Michal Orzel Acked-by: Julien Grall --- v8 changes: - no change --- v7 changes: - doc refinement --- v6 change: - new commit --- SUPPORT.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 8e040d1c1e..1979824ce5 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -299,6 +299,13 @@ Allow sharing of identical pages between guests Status, x86 HVM: Experimental +### Static Memory Sharing + +Allow to statically set up shared memory on dom0less system, +enabling domains to do shm-based communication + + Status, ARM: Tech Preview + ### Memory Paging Allow pages belonging to guests to be paged to disk -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:33:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:33:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403475.645613 (Exim 4.92) (envelope-from ) id 1oWKSg-00033y-4q; Thu, 08 Sep 2022 16:33:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403475.645613; Thu, 08 Sep 2022 16:33:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSg-00033r-1k; Thu, 08 Sep 2022 16:33:06 +0000 Received: by outflank-mailman (input) for mailman id 403475; Thu, 08 Sep 2022 16:33:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSe-0002V6-NN for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:33:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d551a3ef-2f7d-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:55:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5905A153B; Thu, 8 Sep 2022 06:55:41 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 74C733F7B4; Thu, 8 Sep 2022 06:55:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d551a3ef-2f7d-11ed-9760-273f2230c3a0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v8 3/9] xen/arm: allocate static shared memory to a specific owner domain Date: Thu, 8 Sep 2022 21:55:07 +0800 Message-Id: <20220908135513.1800511-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be introduced later in the following commits. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - no change --- v7 chhanges: - adapt to the previous commits' changes --- v6 change: - fix coding-style - role_str and owner_dom_io shall be defined within the loop --- v5 change: - no change --- v4 change: - no changes --- v3 change: - simplify the code since o_gbase is not used if the domain is dom_io --- v2 change: - P2M mapping is restricted to normal domain - in-code comment fix --- xen/arch/arm/domain_build.c | 36 +++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index e30ee65621..fe0a96764d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -822,9 +822,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, static int __init assign_shared_memory(struct domain *d, uint32_t addr_cells, uint32_t size_cells, - paddr_t pbase, paddr_t psize) + paddr_t pbase, paddr_t psize, + paddr_t gbase) { mfn_t smfn; + int ret = 0; dprintk(XENLOG_INFO, "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -838,8 +840,18 @@ static int __init assign_shared_memory(struct domain *d, * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need * to create mapping in the P2M. */ - ASSERT(d == dom_io); - return 0; + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, + PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + return ret; } static int __init process_shm(struct domain *d, @@ -855,6 +867,8 @@ static int __init process_shm(struct domain *d, paddr_t gbase, pbase, psize; int ret = 0; unsigned int i; + const char *role_str; + bool owner_dom_io = true; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; @@ -891,20 +905,28 @@ static int __init process_shm(struct domain *d, return -EINVAL; } - /* TODO: Consider owner domain is not the default dom_io. */ + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will * only find the borrowers. */ - if ( !is_shm_allocated_to_domio(pbase) ) + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { /* * We found the first borrower of the region, the owner was not * specified, so they should be assigned to dom_io. */ - ret = assign_shared_memory(dom_io, addr_cells, size_cells, - pbase, psize); + ret = assign_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403495.645624 (Exim 4.92) (envelope-from ) id 1oWKVH-0004K2-Jz; Thu, 08 Sep 2022 16:35:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403495.645624; Thu, 08 Sep 2022 16:35:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKVH-0004Jv-HH; Thu, 08 Sep 2022 16:35:47 +0000 Received: by outflank-mailman (input) for mailman id 403495; Thu, 08 Sep 2022 16:35:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKVG-0004Jp-Us for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:35:46 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4970dcf3-2f94-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 18:35:46 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id q21so17605043edc.9 for ; Thu, 08 Sep 2022 09:35:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4970dcf3-2f94-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=VW4KfvfzyVHPd8uiTuoi1ws0SBlUslXncR/03SR1FNE=; b=Gj4Njw0OFwJFGyy/CpBsWrtaBlodwVsytOVMo0at++gVmVcKEHXv5IQZFRIQwT/d+N fhtp/sGmbhcxk802b1qtoS2CFjSCb5IB4RXY+j1IUxlac4iD9wgSqvayqv9zSzL2n2te QLcpJ22aUMWyxS7AJ3tRskbVVFVLOlIreLWxxHR79eGs6p4Wm6y6ouJHj5/y2hroCJlC GIBT8RbNzpIhPwTLRxM3eKJV/eO7k82LKj4xAtC+Irw3bO/1lkpEzwk6ZZgN+9SU/FoE dYp2nlq6kQgDNjeGTXsHZvG7rTa7CLNqoypOWNlltFodkAqGjGs5ALlV6T9QyI6cqbLz RfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=VW4KfvfzyVHPd8uiTuoi1ws0SBlUslXncR/03SR1FNE=; b=IKAhwp1WptFNVVl6y1ka3x/8OnbqzfnFFkny7nelJI9wEoVO4hRb7q3zfZc4nkgJGh d7zXQgh+FkVb4k9FHjuAXaNyMaiqyibiWSWuSGCKms9m2ZsV5ZZkXzqvOrhQqjjeb68i zbNTYEbFPn6pOAE8Mmknzs49p6Swd2RZKQ7VkgAKWjgj1NUiixHjhrJFx3PJO2x6+v6j Rqx4+ooG27mK7BoZTxTgw99FaVgmz5VQtDLuKcTfYGTFX0Pch7sM++wcM5lB7w5pB//9 jKeIe+uO9VoMLb666CUe5Vnix1eF3ACetYq2MjV76oL5brFNN0YucRa4LFGpUjAelnC3 FIwQ== X-Gm-Message-State: ACgBeo3g5H9w+ynd/LMQuFn6IMNJvgOId6Qk7cKJydm9bs0G6cqti06J MfGiM949mSp2TkO5YAZtXNhTcpf3JHceSl8XnTA= X-Google-Smtp-Source: AA6agR60EsHy+umEW+DkcyJqAPtFQEJqGtmjo3l8FZl0Yg8CwYgu7ksl7zLlC55BFTK6IgOpyhuXXPeH7d4z5KExZ5s= X-Received: by 2002:aa7:c956:0:b0:43b:206d:c283 with SMTP id h22-20020aa7c956000000b0043b206dc283mr7892981edt.381.1662654944865; Thu, 08 Sep 2022 09:35:44 -0700 (PDT) MIME-Version: 1.0 References: <20220810194827.103428-1-jandryuk@gmail.com> <20220810194827.103428-3-jandryuk@gmail.com> In-Reply-To: From: Jason Andryuk Date: Thu, 8 Sep 2022 12:35:33 -0400 Message-ID: Subject: Re: [PATCH 2/3] xl/libxl: Add ability to specify SMBIOS strings To: Anthony PERARD Cc: xen-devel , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross Content-Type: text/plain; charset="UTF-8" On Thu, Sep 8, 2022 at 8:40 AM Anthony PERARD wrote: > > --- > > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > > index 2abaab439c..9034933ea8 100644 > > --- a/tools/libs/light/libxl_dom.c > > +++ b/tools/libs/light/libxl_dom.c > > @@ -771,6 +771,26 @@ static int hvm_build_set_xs_values(libxl__gc *gc, > > goto err; > > } > > > > + for (int i = 0; i < info->u.hvm.num_smbios; i++) { > > + char *p; > > + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, > > + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); > > + > > + /* libxl defines are all "_", but the HVM_XS_ strings are "-". */ > > "libxl defines are all "_"" seems a bit weird to me as a comment in > the source code, maybe a better comment would the conversion we need to > do, something like: > > Convert libxl_smbios_type string to xenstore path that hvmloader > will use, as defined by HVM_XS_*. That is convert the '_' to '-'. I'll use this. All your other comments sound good, and I'll change accordingly. Thanks for taking a look. -Jason From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:39:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403504.645635 (Exim 4.92) (envelope-from ) id 1oWKYS-0004yz-2o; Thu, 08 Sep 2022 16:39:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403504.645635; Thu, 08 Sep 2022 16:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKYR-0004yr-VP; Thu, 08 Sep 2022 16:39:03 +0000 Received: by outflank-mailman (input) for mailman id 403504; Thu, 08 Sep 2022 16:39:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSh-0002V6-Nw for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:33:07 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d3622308-2f7d-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:54:58 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40DA2106F; Thu, 8 Sep 2022 06:55:38 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 53A803F7B4; Thu, 8 Sep 2022 06:55:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3622308-2f7d-11ed-9760-273f2230c3a0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Julien Grall Subject: [PATCH v8 2/9] xen/arm: assign static shared memory to the default owner dom_io Date: Thu, 8 Sep 2022 21:55:06 +0800 Message-Id: <20220908135513.1800511-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. And DOMID_IO is a fake domain and is not described in the Device-Tree. Therefore When the owner of the shared region is DOMID_IO, we will only find the borrowers when parsing the Device-Tree. When we found the first borrower of the region, we need to assign the region to DOMID_IO This commit only considers allocating static shared memory to dom_io when owner domain is not explicitly defined in device tree, all the left, including the "borrower" code path, the "explicit owner" code path, shall be introduced later in the following patches. Signed-off-by: Penny Zheng Reviewed-by: Julien Grall --- v8 changes: - in-code comment tweak --- v7 changes: - page_get_owner() can only be called for pages that are marked inuse, so use page_get_owner_and_reference() instead - reference shall be dropped using put_page() - adjust "d->max_pages" when acquire_domstatic_pages() fails - switch from assert to BUG_ON() because this is init code - refine commit message and in-code comments - rename allocate_shared_memory() to assign_shared_memory() --- v6 change: - use if-array to check psize, pbase and gbase are suitably aligned and valid - use mfn_valid to check (pbase, pbase + psize) - check d->max_pages will not overflow - refine acquire_shared_memory_bank to not reuse acquire_static_memory_bank, then input pbase and psize do not need to be used as a pointer. - use if-array to check if page owner is dom_io - in-code comment refinement --- v5 change: - refine in-code comment --- v4 change: - no changes --- v3 change: - refine in-code comment --- v2 change: - instead of introducing a new system domain, reuse the existing dom_io - make dom_io a non-auto-translated domain, then no need to create P2M for it - change dom_io definition and make it wider to support static shm here too - introduce is_shm_allocated_to_domio to check whether static shm is allocated yet, instead of using shm_mask bitmap - add in-code comment --- xen/arch/arm/domain_build.c | 160 ++++++++++++++++++++++++++++++++++++ xen/common/domain.c | 3 + 2 files changed, 163 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 0741645014..e30ee65621 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -759,6 +759,160 @@ static void __init assign_static_memory_11(struct domain *d, panic("Failed to assign requested static memory for direct-map domain %pd.", d); } + +#ifdef CONFIG_STATIC_SHM +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + struct domain *d; + + page = maddr_to_page(pbase); + d = page_get_owner_and_reference(page); + if ( d == NULL ) + return false; + put_page(page); + + if ( d != dom_io ) + { + printk(XENLOG_ERR + "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", + d); + return false; + } + + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + unsigned long nr_pfns; + int res; + + /* + * Pages of statically shared memory shall be included + * into domain_tot_pages(). + */ + nr_pfns = PFN_DOWN(psize); + if ( (UINT_MAX - d->max_pages) < nr_pfns ) + { + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", + d, nr_pfns); + return INVALID_MFN; + } + d->max_pages += nr_pfns; + + smfn = maddr_to_mfn(pbase); + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + d->max_pages -= nr_pfns; + return INVALID_MFN; + } + + return smfn; +} + +static int __init assign_shared_memory(struct domain *d, + uint32_t addr_cells, uint32_t size_cells, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + + dprintk(XENLOG_INFO, + "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, pbase, psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need + * to create mapping in the P2M. + */ + ASSERT(d == dom_io); + return 0; +} + +static int __init process_shm(struct domain *d, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + + dt_for_each_child_node(node, shm_node) + { + const struct dt_property *prop; + const __be32 *cells; + uint32_t addr_cells, size_cells; + paddr_t gbase, pbase, psize; + int ret = 0; + unsigned int i; + + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + /* + * xen,shared-mem = ; + * TODO: pbase is optional. + */ + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + BUG_ON(!prop); + cells = (const __be32 *)prop->value; + device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); + psize = dt_read_number(cells, size_cells); + if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, pbase, gbase); + return -EINVAL; + } + if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, psize); + return -EINVAL; + } + + for ( i = 0; i < PFN_DOWN(psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) + { + printk("%pd: invalid physical address 0x%"PRI_mfn"\n", + d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); + return -EINVAL; + } + + /* TODO: Consider owner domain is not the default dom_io. */ + /* + * DOMID_IO is a fake domain and is not described in the Device-Tree. + * Therefore when the owner of the shared region is DOMID_IO, we will + * only find the borrowers. + */ + if ( !is_shm_allocated_to_domio(pbase) ) + { + /* + * We found the first borrower of the region, the owner was not + * specified, so they should be assigned to dom_io. + */ + ret = assign_shared_memory(dom_io, addr_cells, size_cells, + pbase, psize); + if ( ret ) + return ret; + } + } + + return 0; +} +#endif /* CONFIG_STATIC_SHM */ #else static void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, @@ -3238,6 +3392,12 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, node); + if ( rc < 0 ) + return rc; +#endif + /* * Base address and irq number are needed when creating vpl011 device * tree node in prepare_dtb_domU, so initialization on related variables diff --git a/xen/common/domain.c b/xen/common/domain.c index c23f449451..8dd6cd5a8f 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -787,6 +787,9 @@ void __init setup_system_domains(void) * This domain owns I/O pages that are within the range of the page_info * array. Mappings occur at the priv of the caller. * Quarantined PCI devices will be associated with this domain. + * + * DOMID_IO is also the default owner of memory pre-shared among multiple + * domains at boot time. */ dom_io = domain_create(DOMID_IO, NULL, 0); if ( IS_ERR(dom_io) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:39:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403505.645646 (Exim 4.92) (envelope-from ) id 1oWKYU-0005GE-9l; Thu, 08 Sep 2022 16:39:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403505.645646; Thu, 08 Sep 2022 16:39:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKYU-0005G7-6S; Thu, 08 Sep 2022 16:39:06 +0000 Received: by outflank-mailman (input) for mailman id 403505; Thu, 08 Sep 2022 16:39:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSo-0002V6-Ow for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:33:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eef12ba0-2f85-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 16:53:00 +0200 (CEST) Received: from AS8P250CA0027.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::32) by PAXPR08MB6511.eurprd08.prod.outlook.com (2603:10a6:102:12d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Thu, 8 Sep 2022 14:52:58 +0000 Received: from AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:330:cafe::cf) by AS8P250CA0027.outlook.office365.com (2603:10a6:20b:330::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18 via Frontend Transport; Thu, 8 Sep 2022 14:52:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT065.mail.protection.outlook.com (100.127.140.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 14:52:58 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 08 Sep 2022 14:52:58 +0000 Received: from 7aa89cf395bb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EB36405E-FF62-4DDF-9DC1-B49315BCFF3C.1; Thu, 08 Sep 2022 14:52:51 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7aa89cf395bb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Sep 2022 14:52:51 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Thu, 8 Sep 2022 14:52:49 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113%6]) with mapi id 15.20.5612.014; Thu, 8 Sep 2022 14:52:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eef12ba0-2f85-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K7IDXYl2M1Cruu98GmZi1ZhJ0Qy68u8VZmcpIDoppdtvEk+/mJ7Xf92MI6oehWd9lp4BTFM4BGpdnYjnQbhGK7bN6IS/ur6xrvIdE12qabloGNMy+t/FesTIBZXryqYrG/0lvAq5kB/PwPzwv1yhhQbuRgogiq7DOzSJW6eqUU6p2k8jSSUkQ0vb7v3PRGVYeBYP/g/XdRFxFQ03C8P4k9AI/Ebblky3qLyMvOnlNiwDTEnmgBnw0kRBVwWOP1N26A+/oEwFYjTgEli1PwV1KUogSmvNAO6o2QClUd+cltULKGh0/r7c1l/ZmMhZo8xVccJeGWOkXrDpnaY/4Q8+7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eYwq38ij0WcLT7MnjaCpNaXYlUNRMMsOg1q+J7cC/Xk=; b=P0URd0EmomavJzOYyDOVS1sTbgkOjNTt4Q+GAa66CWG0qTcwARqKGN7k6O5bKPB8AMOUSvmv8a622n2hvE/GS8n8ahJ0DdktiFf/dui9JNUQwIzflro26LxFCnJnwLFdFsolqQsnBqLa7fJ9fzaAM2uc+fnh+4o0z7zor1gebkrQGSNAC8rzv3yHnYQooGVxo44r2BYxLK1znk7oatgNGDpGS5eGSeFDENrLeago2l2RS8yu6D66inc4CXoCXVCR4F5FbVGCLUdhAHM1E8IMoWGuQPF8ONFDrHkjT0lqT0YL7t9VC4fDqk1qFQU2B8q+3XtT4pjRXhLtBCKJCWilkA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eYwq38ij0WcLT7MnjaCpNaXYlUNRMMsOg1q+J7cC/Xk=; b=RkvWLHM018rp8epqvW/uP4ReZMbu4S1NpskTGScjik0wS8vGevgkM1zvXemcb1OQqOiyewHLPNVAjWfPCsuepAhiLEF5MZwOAdch7GE8jtzyAESGQm9dBHxnoijI6kWrPLCQDFWUnyjSZJEPcoPl0gvCjvLWMw1VixODhFc5IqU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gbh6TVkjthrRpGfHNoZOc48QQauRyGBiKpRyEY+Ql+qt72TBLks7eKWspU3BFk0irmPqOvxWFx+r+K0qUaVkX+3VxhV7dExsaEG/CtE9JA/rq3VkMXnMN8xNVsnvwOi2Ng4jSYQCX9PwT6w9N7zPeCM8/aRD/qznkptl2ui7WTZJYUo7iTp2/dQKzma4OovCBQNGAVkgwDBZKUxH3lF3pPXXpIWM43Z0/6Kdf5nbVh9tTzOtOZIAUD5goP1jaAMsWQ/28tHckoiiqCMeGouHiR4rgMET3fZzu3NgC0PZp+hZOzcF8rd2Nnxt9lu3LG5F5x9ObTeEImXc9PwNWHcygg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eYwq38ij0WcLT7MnjaCpNaXYlUNRMMsOg1q+J7cC/Xk=; b=Rdeg89KEQIFCyHUVy601H8UtwcTJi7i+yO6zeLBxycpBVmf8SkM/wSYQ6wynED1Bf+HitC/VLAZolev7rDOZl0jfuFFT2Y7RbQcPTneD8u5/VMR33UjUCftFt9xdxde2GH/WvEy4khKnAnftmiXmex7A5g4ojHkmJGz/9mqKN+rNpfTL1Mp+WYnRhSNhxXme5xG90193Jj+Sduda9gMlqzLwBEfQiJTXzasFu7fsEkRXKUaZhMzCrz84CrxTbRX74RmK+oTykGuAoVjyJ31JeetU6nkzuk8bGBFJcOII+7164OKz+JZQilbu4VAY+qACV4uXu5cap7k/eveM0r6aZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eYwq38ij0WcLT7MnjaCpNaXYlUNRMMsOg1q+J7cC/Xk=; b=RkvWLHM018rp8epqvW/uP4ReZMbu4S1NpskTGScjik0wS8vGevgkM1zvXemcb1OQqOiyewHLPNVAjWfPCsuepAhiLEF5MZwOAdch7GE8jtzyAESGQm9dBHxnoijI6kWrPLCQDFWUnyjSZJEPcoPl0gvCjvLWMw1VixODhFc5IqU= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common Thread-Topic: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common Thread-Index: AQHYvnyKHl6xJ/9ji0S8MAXJnXBUfq3VSGGAgACdXwD//41NgIAANFtg Date: Thu, 8 Sep 2022 14:52:47 +0000 Message-ID: References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-3-wei.chen@arm.com> <085c4903-dab9-2d0e-2e25-d7e0d9479aa6@suse.com> In-Reply-To: <085c4903-dab9-2d0e-2e25-d7e0d9479aa6@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E83659737D3F424B8B5E2EE19F91359F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DBBPR08MB6313:EE_|AM7EUR03FT065:EE_|PAXPR08MB6511:EE_ X-MS-Office365-Filtering-Correlation-Id: 75361c28-74d9-4e75-8965-08da91a9d1dc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sUuNy6gnyVxY02z3ZSHlJUqSMNJkfgijzK8ivnZUy5fkrnB6RvOjgLggIDQTjVTBgrvV5ULdP9V+/XoPSpTQmeKz8eK4Y3n3Cl7AIg8mBt1q7uEL1mOzpAbJ/pxJMUaMw16hpOyWCMEEu6FZX98Nh8bUd2LZrUElXb9zb3VFU83xEXpC3GcLQGB+AoXOQ32DJ3ktJrnfJ4cC5W+qVRCruqDT3hJoN7dtX+uix+YNeyW8NRoejkh9v/12UjGkwubMqtIE1PgcHxArdmPmRfSCXmqrJV0WADyR+mEPCKe3u9vqb7V0k4WCDmlWAZUcfyuY47YpFTxqnQ6bCVjQJM7DxTXr88hBq9F5a3I2AV2P9sa/YwEU8Unn2L75TiVJNnLQo2ETB5XcZy7MEJzfFyc3R5miyKHYyhg98nY8eCv1A9fPn+A4X1tjdlabHwZGgaIe7cl3fx0+qJ3BY4Yrdv5ojVH5ZVpOA67KZEGnR5pnkjkXc+j+smlCF5ah5keYPcUT1C77ku0D06Yg1StLhAQYT/KLMxIKvcQV7xdvQ9t7di63JRlsoIHWxxkRlMZUEdQTsLKsSkKd/o65BtaJXkTU5vCrY579BEy35FmT5gTmI8OgUcbXP+hHmXetqO1VW/ZeYA2cjz71V6bcfJs9CM5RVUnEjE3zT6zCyNxKMKqnpKPDWdpdrZExG4goI8YzA6UJ+5OMV6nUkCwK2Jqeeu0zdpmKXO9XbYpYD9mi8gv02bJ2Umkq2/ZPLQQ5VT7H4o4U+8vjVZbGNwSZ81TL9eQ7UA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(186003)(52536014)(83380400001)(2906002)(53546011)(55016003)(5660300002)(6506007)(7696005)(86362001)(33656002)(9686003)(8936002)(71200400001)(41300700001)(478600001)(38070700005)(66476007)(76116006)(64756008)(4326008)(66446008)(54906003)(6916009)(66556008)(38100700002)(316002)(66946007)(8676002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6313 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cbd2d985-5d98-4fd3-eb42-08da91a9cbc5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ku/W2zgx8mMqRsUOeJkWdqwcahCRVl1QXCLnwyXvwJDo+Kliz0JHw6tAw0E7jii56EE0mpNnKXaVpjqRgZUR9Kc3QmwBgHWRbXjKQ+PEI0UOKg9qVci1p5/m3LGcmpK6fVUQVLu1WUNZSkted2dhHoqZX34mHVwmYpGcZlnfEKPg2qn6BM2TREA5EWSwJphCgzk3CrAkKbF7HJriciMHTsK+QVJnakLc5i0eLNlVkm/GWE8p23ib0c5wtQRoSxRn6m+3YLfh1YkDkX/QOav8Lbmbj7LWo2EuqTy4RtXKwOMbE8vZ8+uve9AXU+bxtpudM7qde5FL0AmIRABMYjgx3DiaRfJUcINZT/MynH7zJxPEwDhshogXvjVE/4R8JWQPoGH315Y9236upw4naOjpcsAmnmwUPi4MnYsLxzZB7B//TuFjrL3NgbwlwgrqwMrcbKc8KzSyv9pFRTkM4LyO22U5JGMsXuohH/lI7mSS0CZ74bk1uxcyGVBHZxMpCVb9fB27hfczykRsNm+/dTsU8f+3stA7qFsUVRgKDW6yuc0VcwISK6/AKgMSO2ohfDDGALpr5f955wpjxcPBA5+vjq7/J5JEK9E41Qhnpe3cIoa+/37/28L0cF+uK7dwqrFxmNBlTm4TtnHiLdAFQzV+QQevLbwwl1gvHkH1YZBXO7ZuwKeATkSChLaHMzlU5lp4kkwvsh/Ch1otebzecPCGrcCzckV/3GFXfQ54xVp0E+FHQu61sUWZKk8/TJCzoaLEWQGGpjhdw5m5ui2KRu9Uhg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(40470700004)(46966006)(36840700001)(356005)(81166007)(86362001)(70206006)(82740400003)(8676002)(4326008)(70586007)(33656002)(36860700001)(53546011)(186003)(9686003)(47076005)(336012)(6506007)(7696005)(478600001)(26005)(83380400001)(41300700001)(40480700001)(316002)(55016003)(82310400005)(54906003)(2906002)(40460700003)(6862004)(5660300002)(8936002)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 14:52:58.1957 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75361c28-74d9-4e75-8965-08da91a9d1dc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6511 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIg45pelIDE5OjQyDQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IFJvZ2VyIFBhdQ0KPiBN b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEdlb3Jn ZSBEdW5sYXANCj4gPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD SCB2NCAyLzZdIHhlbi94ODY6IG1vdmUgZ2VuZXJpY2FsbHkgdXNhYmxlIE5VTUEgY29kZQ0KPiBm cm9tIHg4NiB0byBjb21tb24NCj4gDQo+IE9uIDA4LjA5LjIwMjIgMTI6MzIsIFdlaSBDaGVuIHdy b3RlOg0KPiA+IE9uIDIwMjIvOS84IDE3OjA5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPj4gT24g MDIuMDkuMjAyMiAwNTozMSwgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiAtLS0gL2Rldi9udWxsDQo+ ID4+PiArKysgYi94ZW4vY29tbW9uL251bWEuYw0KPiA+Pj4gQEAgLTAsMCArMSw0NDIgQEANCj4g Pj4+ICsvKg0KPiA+Pj4gKyAqIEdlbmVyaWMgVk0gaW5pdGlhbGl6YXRpb24gZm9yIE5VTUEgc2V0 dXBzLg0KPiA+Pj4gKyAqIENvcHlyaWdodCAyMDAyLDIwMDMgQW5kaSBLbGVlbiwgU3VTRSBMYWJz Lg0KPiA+Pj4gKyAqIEFkYXB0ZWQgZm9yIFhlbjogUnlhbiBIYXJwZXIgPHJ5YW5oQHVzLmlibS5j b20+DQo+ID4+PiArICovDQo+ID4+PiArDQo+ID4+PiArI2luY2x1ZGUgPHhlbi9pbml0Lmg+DQo+ ID4+PiArI2luY2x1ZGUgPHhlbi9rZXloYW5kbGVyLmg+DQo+ID4+PiArI2luY2x1ZGUgPHhlbi9t bS5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vbm9kZW1hc2suaD4NCj4gPj4+ICsjaW5jbHVkZSA8 eGVuL251bWEuaD4NCj4gPj4+ICsjaW5jbHVkZSA8eGVuL3BhcmFtLmg+DQo+ID4+PiArI2luY2x1 ZGUgPHhlbi9zY2hlZC5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vc29mdGlycS5oPg0KPiA+Pj4g Kw0KPiA+Pj4gK3N0cnVjdCBub2RlX2RhdGEgX19yb19hZnRlcl9pbml0IG5vZGVfZGF0YVtNQVhf TlVNTk9ERVNdOw0KPiA+Pj4gKw0KPiA+Pj4gKy8qIE1hcHBpbmcgZnJvbSBwZHggdG8gbm9kZSBp ZCAqLw0KPiA+Pj4gK3Vuc2lnbmVkIGludCBfX3JvX2FmdGVyX2luaXQgbWVtbm9kZV9zaGlmdDsN Cj4gPj4+ICt1bnNpZ25lZCBsb25nIF9fcm9fYWZ0ZXJfaW5pdCBtZW1ub2RlbWFwc2l6ZTsNCj4g Pj4+ICt1aW50OF90ICpfX3JvX2FmdGVyX2luaXQgbWVtbm9kZW1hcDsNCj4gPj4+ICtzdGF0aWMg dWludDhfdCBfX3JvX2FmdGVyX2luaXQgX21lbW5vZGVtYXBbNjRdOw0KPiA+Pg0KPiA+PiBUaGVz ZSBsYXN0IHR3byB3YW50IHRvIHVzZSBub2RlaWRfdCBpbnN0ZWFkIG9mIHVpbnQ4X3QuIE9yaWdp bmFsbHkNCj4gPj4gdGhlIGxhdHRlciB1c2VkIHR5cGVvZigqbWVtbm9kZW1hcCkgZm9yIChJIHRo aW5rIC0gaWlyYyBpdCB3YXMgbWUgd2hvDQo+ID4+IG1hZGUgaXQgdGhhdCB3YXkpIHRoaXMgcmVh c29uOiBUaGF0IHdheSBjb3JyZWN0aW5nIG1lbW5vZGVtYXAncyB0eXBlDQo+ID4+IHdvdWxkIGhh dmUgcHJvcGFnYXRlZCB3aXRob3V0IHRoZSBuZWVkIGZvciBmdXJ0aGVyIGFkanVzdG1lbnRzLg0K PiA+Pg0KPiA+DQo+ID4gVGhhbmtzIGZvciB0aGlzIGluZm8sIHNob3VsZCBJIG5lZWQgdG8gcmVz dG9yZSBpdCB0byB1c2UNCj4gPiAidHlwZW9mKCptZW1ub2RlbWFwKSIgaW4gbmV4dCB2ZXJzaW9u ID8NCj4gDQo+IFRoYXQgd291bGQgYmUgbW9yZSBpbiBsaW5lIHdpdGggdGhlIG9yaWdpbmFsIGNv ZGUsIGJ1dCBpdCdzIG5vdA0KPiBzdHJpY3RseSBuZWNlc3Nhcnkgb25jZSBub2RlaWRfdCBpZiBw cm9wZXJseSB1c2VkIGZvciB0aGVzZSB2YXJpYWJsZXMuDQo+IEknZCBsZWF2ZSBpdCB1cCB0byB5 b3UgYXMgbG9uZyBhcyB5b3Ugc3dpdGNoIHRvIG5vZGVpZF90Lg0KPiANCg0KT2ssIEkgd2lsbCB0 aGluayBtb3JlIGFib3V0IGl0IGluIG5leHQgdmVyc2lvbi4NCg0KPiA+Pj4gK25vZGVpZF90IF9f cmVhZF9tb3N0bHkgY3B1X3RvX25vZGVbTlJfQ1BVU10gPSB7DQo+ID4+PiArICAgIFswIC4uLiBO Ul9DUFVTLTFdID0gTlVNQV9OT19OT0RFDQo+ID4+PiArfTsNCj4gPj4+ICsNCj4gPj4+ICtjcHVt YXNrX3QgX19yZWFkX21vc3RseSBub2RlX3RvX2NwdW1hc2tbTUFYX05VTU5PREVTXTsNCj4gPj4+ ICsNCj4gPj4+ICtub2RlbWFza190IF9fcmVhZF9tb3N0bHkgbm9kZV9vbmxpbmVfbWFwID0geyB7 IFswXSA9IDFVTCB9IH07DQo+ID4+PiArDQo+ID4+PiArYm9vbCBfX3JlYWRfbW9zdGx5IG51bWFf b2ZmOw0KPiA+Pg0KPiA+PiBUaGUgdjMgcmV2aWV3IGRpc2N1c3NpbmcgdGhpcyBwb3NzaWJseSBi ZWNvbWluZyBfX3JvX2FmdGVyX2luaXQgZGlkbid0DQo+ID4+IHJlYWxseSBmaW5pc2ggKHlvdSBk aWRuJ3QgcmVwbHkgdG8gbXkgbGF0ZXN0IHJlcXVlc3QgdGhlcmUpLCBidXQgeW91DQo+ID4+IGFs c28gZGlkbid0IGNoYW5nZSB0aGUgYXR0cmlidXRlLiBQbGVhc2UgY2xhcmlmeS4NCj4gPj4NCj4g Pg0KPiA+IEkgdGhpbmsgSSBoYWQgYW5zd2VyZWQgeW91ciBxdWVzdGlvbiBieToNCj4gPiAgPj4g SSB0aGluayB5ZXMsIGl0IHdpbGwgYmUgdXNlZCBpbiBudW1hX2Rpc2FibGVkIGFuZCBudW1hX2Rp c2FibGVkIHdpbGwNCj4gPiAgPj4gYmUgY2FsbGVkIGluIGNwdV9hZGQuIg0KPiA+DQo+ID4gQW5k IHlvdSByZXBsaWVkIG1lIHdpdGg6DQo+ID4gID4gSW4gdGhlIG9yaWdpbmFsIGNvZGUgSSBjYW5u b3Qgc3BvdCBzdWNoIGEgcGF0aCAtIGNhbiB5b3UgcGxlYXNlIHBvaW50DQo+ID4gID4gb3V0IGhv dyBleGFjdGx5IHlvdSBzZWUgbnVtYV9kaXNhYmxlZCgpIHJlYWNoYWJsZSBmcm9tIGNwdV9hZGQo KT8gSSdtDQo+ID4gID4gY2xlYXJseSBvdmVybG9va2luZyBzb21ldGhpbmcgLi4uIg0KPiA+DQo+ ID4gQnV0IHRoZXJlIGlzIGEgdGltZSBkaWZmZXJlbmNlIGhlcmUsIHlvdXIgcmVwbHkgd2FzIHNl bnQgYWZ0ZXIgSSBzZW50DQo+ID4gdjMsIG1heWJlIHlvdSBkaWRuJ3Qgbm90aWNlIGl0DQo+IA0K PiBXaGljaCBzdWdnZXN0cyB5b3UgbWlnaHQgYmV0dGVyIGhhdmUgd2FpdGVkIHdpdGggc2VuZGlu ZyB2MyB1bnRpbCB0aGUNCj4gZGlzY3Vzc2lvbiBoYWQgc2V0dGxlZC4NCj4gDQo+ID4gQWJvdXQg dGhlIG5ldyBxdWVzdGlvbjoNCj4gPiBjcHVfYWRkIHdpbGwgY2FsbCBzcmF0X2Rpc2FibGVkLCBz cmF0X2Rpc2FibGVkIHdpbGwgYWNjZXNzIG51bWFfb2ZmLg0KPiA+IHNyYXRfZGlzYWJsZWQgaXMg YSBmdW5jdGlvbiB3aXRob3V0IF9faW5pdC4NCj4gDQo+IEJ1dCB0aGUgcmVxdWVzdCB3YXNuJ3Qg dG8gbWFrZSB0aGUgdmFyaWFibGUgX19pbml0ZGF0YS4gVGhhdCB3b3VsZCBiZQ0KPiB3cm9uZyBv ZiBjb3Vyc2UuIFNpbmNlIHNyYXRfZGlzYWJsZWQoKSBvbmx5IHJlYWRzIG51bWFfb2ZmLA0KPiBf X3JvX2FmdGVyX2luaXQgZG9lcyBsb29rIHVzYWJsZSB0byBtZS4NCj4gDQoNCk9oLCB5ZXMsIHlv dSdyZSByaWdodC4gSSBoYWQgdGhvdWdodCB3cm9uZy4gSSB3aWxsIGNvcnJlY3QgdGhpcy4NCg0K Q2hlZXJzLA0KV2VpIENoZW4uDQoNCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:39:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:39:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403511.645657 (Exim 4.92) (envelope-from ) id 1oWKYX-0005bt-L0; Thu, 08 Sep 2022 16:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403511.645657; Thu, 08 Sep 2022 16:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKYX-0005bm-HQ; Thu, 08 Sep 2022 16:39:09 +0000 Received: by outflank-mailman (input) for mailman id 403511; Thu, 08 Sep 2022 16:39:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKSp-0002V6-PH for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:33:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id dcef5faa-2f7d-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 15:55:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44DA2106F; Thu, 8 Sep 2022 06:55:54 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5FE743F7B4; Thu, 8 Sep 2022 06:55:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcef5faa-2f7d-11ed-9760-273f2230c3a0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Date: Thu, 8 Sep 2022 21:55:11 +0800 Message-Id: <20220908135513.1800511-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908135513.1800511-1-Penny.Zheng@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration when creating shared memory nodes in guest device tree, this commit adds new field "shm_mem" to store shm-info per domain. For each shared memory region, a range is exposed under the /reserved-memory node as a child node. Each range sub-node is named xen-shmem@
and has the following properties: - compatible: compatible = "xen,shared-memory-v1" - reg: the base guest physical address and size of the shared memory region - xen,id: a string that identifies the shared memory region. - xen,offset: (borrower VMs only) 64 bit integer offset within the owner virtual machine's shared memory region used for the mapping in the borrower VM. Currently, we provide "xen,offset=<0x0>" as a temprary placeholder. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - Fix missing property "xen,offset" for borrower VMs by temporarily adding "xen,offset=<0x0>" - use >= to avoid thinking about the overflow case for nr_banks - check the return value of dt_property_read_string() for parsing shm_id - struct meminfo *mem and char resvbuf[16] = "reserved-memory" could be const - change "__be32 reg[4]" to "__be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]" --- v7 changes: - allocate reg for worst case addrcells + sizecells - replace assert() with BUG_ON() since it is init code --- v6 change: - change "struct meminfo *mem" to "const struct meminfo *mem" - change "unsigned long i" to "unsigned int i" to match the type of nr_banks. - accroding to the Linux binding, "xen,id" is meant to be a string, not an integer --- v5 change: - no change --- v4 change: - no change --- v3 change: - move field "shm_mem" to kernel_info --- v2 change: - using xzalloc - shm_id should be uint8_t - make reg a local variable - add #address-cells and #size-cells properties - fix alignment --- xen/arch/arm/domain_build.c | 160 +++++++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + 2 files changed, 159 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index a10d07266b..cd03370b38 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -914,7 +914,22 @@ static int __init assign_shared_memory(struct domain *d, return ret; } -static int __init process_shm(struct domain *d, +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + const char *shm_id) +{ + if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); + kinfo->shm_mem.nr_banks++; + + return 0; +} + +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { struct dt_device_node *shm_node; @@ -928,6 +943,7 @@ static int __init process_shm(struct domain *d, int ret = 0; unsigned int i; const char *role_str; + const char *shm_id; bool owner_dom_io = true; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) @@ -972,6 +988,13 @@ static int __init process_shm(struct domain *d, if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) owner_dom_io = false; + if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) + { + printk("%pd: invalid \"xen,shm-id\" property", d); + return -EINVAL; + } + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will @@ -999,6 +1022,14 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; } return 0; @@ -1331,6 +1362,126 @@ static int __init make_memory_node(const struct domain *d, return res; } +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + unsigned int i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ + char buf[27]; + const char compat[] = "xen,shared-memory-v1"; + /* Worst case addrcells + sizecells */ + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); + if ( res ) + return res; + + /* TODO: + * - xen,offset: (borrower VMs only) + * 64 bit integer offset within the owner virtual machine's shared + * memory region used for the mapping in the borrower VM + */ + res = fdt_property_u64(fdt, "xen,offset", 0); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); +} +#endif + +static int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + int res = 0; + /* Placeholder for reserved-memory\0 */ + const char resvbuf[16] = "reserved-memory"; + + if ( mem->nr_banks == 0 ) + /* No shared memory provided. */ + return 0; + + dt_dprintk("Create reserved-memory node\n"); + + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; + + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", sizecells); + if ( res ) + return res; + + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) { struct meminfo *ext_regions = data; @@ -3108,6 +3259,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( ret ) + goto err; + /* * domain_handle_dtb_bootmodule has to be called before the rest of * the device tree is generated because it depends on the value of @@ -3484,7 +3640,7 @@ static int __init construct_domU(struct domain *d, assign_static_memory_11(d, &kinfo, node); #ifdef CONFIG_STATIC_SHM - rc = process_shm(d, node); + rc = process_shm(d, &kinfo, node); if ( rc < 0 ) return rc; #endif diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index c4dc039b54..2cc506b100 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -19,6 +19,7 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; + struct meminfo shm_mem; /* kernel entry point */ paddr_t entry; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:39:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:39:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403535.645668 (Exim 4.92) (envelope-from ) id 1oWKYw-0006j4-UB; Thu, 08 Sep 2022 16:39:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403535.645668; Thu, 08 Sep 2022 16:39:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKYw-0006it-QZ; Thu, 08 Sep 2022 16:39:34 +0000 Received: by outflank-mailman (input) for mailman id 403535; Thu, 08 Sep 2022 16:39:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKYv-00068U-0t for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 16:39:33 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d08f2dec-2f94-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 18:39:32 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id u9so39423705ejy.5 for ; Thu, 08 Sep 2022 09:39:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d08f2dec-2f94-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ikluf8e3QSda96uKF/vkS8E/GZVzqkjV8CfGxf9WSz8=; b=GTinL6w1wbQ310pf/hiYqfYyDA6zAJ7ir8t6QpyFPW3CDLhvYP1UO1HwWzF2d7fV/H RMtEciAXBqxRgOIp0OHgCsULyDl41mwpNgVVgx88cpZ4K0QHd6vNU6IeVo/W7u6NCOvJ Dc2rfhm0JsRELFkcBLkn90muv8TGQvMBjN6w1JNUBXdmA7xwU8oU9kuq0osmidd1cxoL DxydOQRO1+lcwNFaO2oqsrNIsM0+AMk32riNKowIjdxavFZ6tBdSLPp5W7r4zaGbr4nK zwwlcXJ7EFpPpgsIfSG9z1ws2wZqGBsZNkEPW+8vdoOp7b1SP3C9t6C6/g+Z9QdREsO+ pLFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ikluf8e3QSda96uKF/vkS8E/GZVzqkjV8CfGxf9WSz8=; b=NVOVXUsvqKsHK+KdPiG/CLz84uETgrR4oiPn/Un41uK3y8z5Q8myJLD9nIpgfLdjhd pVlPNEd2T+XQg6wcxMeFZ4XW5TRPLCOeC2NsYjTOvvG/JOxCXtQUkAroC1J3ld7HUeNm E3+iHDgiMKQFgDyftvk8+YtRsbQcG5GaTr+RCor31YprovMq6n8Drl9HMTlni1zH+dZV ejlQ+Y3BBeVbDeWCdeHG81B4uZ4rFR6oeTGmsaAJ2QtBo5iVPCqRhjXt0q8PCybF5n6r w75UpaYejyarNwK74oy95ncA3Gi6c9NvEu/rSdRvHKtNCR8KRVkP5/CHXtteVFomlCSe AFzw== X-Gm-Message-State: ACgBeo16R7m4ou1H4uPKX6DgkDM+w+P7UjxZswOo+gcCBoD6pWHR5ihT E4pTihozWEAAsR31BmfGD5xAovw5hnq3JgDLWkU= X-Google-Smtp-Source: AA6agR4+APZPNPzujT2m/y6WXbqxzmpuXoJyZPk4mt6C98gne2owIogNl7xkQ8c4e7mkb6UqJiHRQgSKR/Y0x0mmn+4= X-Received: by 2002:a17:907:2ce7:b0:741:6e62:4558 with SMTP id hz7-20020a1709072ce700b007416e624558mr6820741ejc.273.1662655171767; Thu, 08 Sep 2022 09:39:31 -0700 (PDT) MIME-Version: 1.0 References: <20220810194827.103428-1-jandryuk@gmail.com> <20220810194827.103428-4-jandryuk@gmail.com> In-Reply-To: From: Jason Andryuk Date: Thu, 8 Sep 2022 12:39:20 -0400 Message-ID: Subject: Re: [PATCH 3/3] xl/libxl: Add OEM string support to smbios To: Anthony PERARD Cc: xen-devel , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross Content-Type: text/plain; charset="UTF-8" On Thu, Sep 8, 2022 at 9:14 AM Anthony PERARD wrote: > > On Wed, Aug 10, 2022 at 03:48:27PM -0400, Jason Andryuk wrote: > > Add support for OEM strings in the SMBIOS type 11. > > > > hvmloader checks them sequentially, so hide the implementation detail. > > Allow multiple plain oem= items and assign the numeric values > > internally. > > > > Signed-off-by: Jason Andryuk > > --- > > docs/man/xl.cfg.5.pod.in | 4 ++ > > tools/golang/xenlight/types.gen.go | 99 ++++++++++++++++++++++++++++++ > > tools/libs/light/libxl_types.idl | 99 ++++++++++++++++++++++++++++++ > > tools/xl/xl_parse.c | 15 +++++ > > 4 files changed, 217 insertions(+) > > > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > > index 7edf5d23f3..7947bf07ea 100644 > > --- a/docs/man/xl.cfg.5.pod.in > > +++ b/docs/man/xl.cfg.5.pod.in > > @@ -2104,8 +2104,12 @@ Each B is a C string from the following list: > > > > =item B > > > > +=item B > > + > > =back > > > > +oem= strings can be specified mutiple times up to a limit of 99. > > This could be move to just before =back I think. Moved like you suggest, the man page output is: """ oem=STRING oem= strings can be specified mutiple times up to a limit of 99. ms_vm_genid="OPTION" """ I'll also re-word to "oem= can be specified up to 99 times." > > + > > =item B > > > > Provide a VM generation ID to the guest. > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > > index d04207748e..58f404af37 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -436,6 +436,105 @@ libxl_smbios_type = Enumeration("smbios_type", [ > > (15, "enclosure_asset_tag"), > > (16, "battery_manufacturer"), > > (17, "battery_device_name"), > > + (18, "oem_1"), > > + (19, "oem_2"), > > + (20, "oem_3"), > [...] > > + (115, "oem_98"), > > + (116, "oem_99"), > > Instead of this long lists of enum value, could we just have one "oem" > type, and allow it to be used more than once? I know that would mean > having a special case in libxl, but that also mean that libxl will be > the only one to deal with the implementation detail on how to write oem > string for hvmloader (as opposed to deal with this in every application > using libxl). I'll pursue a single "oem" type. Also, I'll check the count in both libxl and xl. While only the libxl check is needed, it seems better to detect issues while parsing the config instead of only later during the domain build. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Thu Sep 08 16:51:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 16:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403550.645679 (Exim 4.92) (envelope-from ) id 1oWKkD-0000yY-Vp; Thu, 08 Sep 2022 16:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403550.645679; Thu, 08 Sep 2022 16:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKkD-0000yR-SG; Thu, 08 Sep 2022 16:51:13 +0000 Received: by outflank-mailman (input) for mailman id 403550; Thu, 08 Sep 2022 16:51:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKkC-0000yG-K5; Thu, 08 Sep 2022 16:51:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKkC-00047z-FW; Thu, 08 Sep 2022 16:51:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWKkB-0003kM-8K; Thu, 08 Sep 2022 16:51:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWKkB-0005eI-7s; Thu, 08 Sep 2022 16:51:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CtcbTXJb+L5u91Ieh0ejiK/AsG9F3Pc2s4us0TbuAbY=; b=Si+O+g0MLJjMyYVi+nZ8LEbDUa 3JELJeuWy/Sx08ucnqRSUlNz1ljw2r3Haskob00Zv3B7IHROdEn2HNqxxoc2piY0ql2vyBLBMjm2m 7vowseymo0k27zLX1PENf5gA196pjj7h5Pepq0LAoE1CIkZUgKJygi8DcdUu4qdoxFA4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173058: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=72cf345bc2de97a5f60f97a09926b9673ea46704 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 08 Sep 2022 16:51:11 +0000 flight 173058 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173058/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 72cf345bc2de97a5f60f97a09926b9673ea46704 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 790 days Failing since 151818 2020-07-11 04:18:52 Z 789 days 771 attempts Testing same since 173058 2022-09-08 04:19:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122479 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 19:32:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 19:32:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403564.645696 (Exim 4.92) (envelope-from ) id 1oWNFd-0002xL-Mz; Thu, 08 Sep 2022 19:31:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403564.645696; Thu, 08 Sep 2022 19:31:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNFd-0002xE-Jn; Thu, 08 Sep 2022 19:31:49 +0000 Received: by outflank-mailman (input) for mailman id 403564; Thu, 08 Sep 2022 19:31:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNFc-0002x4-3C; Thu, 08 Sep 2022 19:31:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNFb-00076m-TQ; Thu, 08 Sep 2022 19:31:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNFb-0005LP-FC; Thu, 08 Sep 2022 19:31:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWNFb-0004Pg-Ei; Thu, 08 Sep 2022 19:31:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c2mfb6H3hM2bDDwOVZd1AysfJfCRbysmFcjZYaP8ObM=; b=vmqS4sfZ2GUiUrS9vmLgW5h2tH xPw0J4kTM1LZiyQT5SB48MBLAmR8ISTxd3TF1Mty7Es0JVpwffLM0lQhaSW1OfZT/mOM7QjUoykus o6aIedXVWDjkJzoPnWj63+G8DazdFbGUxtPt4XTznVj8CEUPwPXVuCSJv2Bnbp5Sv+YY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173068: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=d82ec90f51f61c914396271d86e64a74121dde24 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 19:31:47 +0000 flight 173068 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf d82ec90f51f61c914396271d86e64a74121dde24 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 268 attempts Testing same since 173057 2022-09-08 03:17:03 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2203 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 19:51:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 19:51:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403574.645717 (Exim 4.92) (envelope-from ) id 1oWNYx-0005yh-Ih; Thu, 08 Sep 2022 19:51:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403574.645717; Thu, 08 Sep 2022 19:51:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNYx-0005ya-G0; Thu, 08 Sep 2022 19:51:47 +0000 Received: by outflank-mailman (input) for mailman id 403574; Thu, 08 Sep 2022 19:51:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNYw-0005iM-QY for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 19:51:46 +0000 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [2607:f8b0:4864:20::731]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aafc992a-2faf-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 21:51:46 +0200 (CEST) Received: by mail-qk1-x731.google.com with SMTP id b2so13748179qkh.12 for ; Thu, 08 Sep 2022 12:51:45 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27]) by smtp.gmail.com with ESMTPSA id bp33-20020a05620a45a100b006b8e049cf08sm17095814qkb.2.2022.09.08.12.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 12:51:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aafc992a-2faf-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=0c9AKXalp2sKJ7cfJ+vPBAUxcJIApFm3DGF7p3Liepw=; b=NmcUFcM+lVkVNUbqSzGu6sFBj8Aqd7hR7bofQeP9Ij67wwU6oR8m8t6MAAh2Wi146y bJPfHVAH3QxkK9XKl3NERqQCa3GjxsAl+lijaROmdO4H7+Ei+1iBM6vsROt0BL0WRtXQ AIRfsHPinOB5EsQroBIPJ01/Bf6Oi3hWEXqimrJgXx6ymF0s0+Bdgym2+wAzRsxZ98B2 HoyQhP9B2OkmKGh/PP+LGoBukh95uTo6OjyVAvwPP4x9VAs5beROKOZKdYsdt4sDM8An LbFLzARycUrsV/YWStpeZbIwFBlDg7cpBRY5eE3rvzE1HfxCmAHyN6tRywhCEzmxEtLJ Rwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=0c9AKXalp2sKJ7cfJ+vPBAUxcJIApFm3DGF7p3Liepw=; b=TLYGJ96p1CrMlmaR1Kd28UasElX+Bzjoa3pK+l5EGbLH8SgguxvxgfG8O3Isa6b+ZK OAkkVjNkgWpdVN1tGx+PTWjJU54/mj2a8HLUFE1PEuNLGKKJ8H9myXemApyCeRDasgSW RRkv23uoHywpfUTiVOYmrtOcZO06mh8X4JFu+CUDNPu17muRTa8rebqCvkdIl0LpvSa9 t5bWlBp4FCOnuullgC+hXe0vnVXsjVEFTb4moqIcSIfvJf4Pb3ogtWo4RhyS9Xcl6KoI DcuVD5B73XoXVQ1SNA8gQv/BXh8AJzM37m1s23rHG383gaYsur5/caWsFuwFqNWuF63W Jk8A== X-Gm-Message-State: ACgBeo16u+cY+nNkzqZqVLArF2a9WsLCpFEbjgBKqsCIn/W4aMPJOnnB oTfQygU32MJRgs7a32+tpUEb4Gulmhk= X-Google-Smtp-Source: AA6agR6SpiKWtaXs0OLwuOa+Jy7q2Kcg3zyzl/nufIOhOBz8EMcZ4AM/eL8t77DDPGMHDGgtBe6sPA== X-Received: by 2002:a37:91c3:0:b0:6bc:5322:d49e with SMTP id t186-20020a3791c3000000b006bc5322d49emr7781474qkd.583.1662666704527; Thu, 08 Sep 2022 12:51:44 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD Subject: [PATCH v2 1/3] golang/xenlight: Extend KeyedUnion to support Arrays Date: Thu, 8 Sep 2022 15:51:11 -0400 Message-Id: <20220908195113.218201-2-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220908195113.218201-1-jandryuk@gmail.com> References: <20220908195113.218201-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Generation for KeyedUnion types doesn't support Arrays. The smbios support will place an smbios array inside the hvm KeyedUnion, and gentotypes doesn't generate buildable Go code. Have KeyedUnion add an idl.Array check and issue the approriate xenlight_golang_array_to_C and xenlight_golang_array_from_C calls when needed. This matches how it is done in xenlight_golang_define_to_C & xenlight_golang_define_from_C xenlight_golang_array_to_C and xenlight_golang_array_from_C need to be extended to set the cvarname and govarname as approriate for the KeyedUnion cases to match the surrounding code. Signed-off-by: Jason Andryuk --- tools/golang/xenlight/gengotypes.py | 41 ++++++++++++++++++----------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.py index ac1cf060dd..745a3cb466 100644 --- a/tools/golang/xenlight/gengotypes.py +++ b/tools/golang/xenlight/gengotypes.py @@ -374,6 +374,10 @@ def xenlight_golang_union_from_C(ty = None, union_name = '', struct_name = ''): s += 'tmp := (*C.{0})(unsafe.Pointer(&xc.{1}[0]))\n'.format(typename,union_name) for nf in f.type.fields: + if isinstance(nf.type, idl.Array): + s += xenlight_golang_array_from_C(nf,cvarname='tmp') + continue + s += xenlight_golang_convert_from_C(nf,cvarname='tmp') s += 'return nil\n' @@ -414,7 +418,7 @@ def xenlight_golang_union_from_C(ty = None, union_name = '', struct_name = ''): return (s,extras) -def xenlight_golang_array_from_C(ty = None): +def xenlight_golang_array_from_C(ty = None, cvarname = 'xc'): """ Convert C array to Go slice using the method described here: @@ -431,9 +435,9 @@ def xenlight_golang_array_from_C(ty = None): clenvar = ty.type.lenvar.name s += 'x.{0} = nil\n'.format(goname) - s += 'if n := int(xc.{0}); n > 0 {{\n'.format(clenvar) + s += 'if n := int({0}.{1}); n > 0 {{\n'.format(cvarname,clenvar) s += '{0} := '.format(cslice) - s +='(*[1<<28]C.{0})(unsafe.Pointer(xc.{1}))[:n:n]\n'.format(ctypename, cname) + s +='(*[1<<28]C.{0})(unsafe.Pointer({1}.{2}))[:n:n]\n'.format(ctypename, cvarname, cname) s += 'x.{0} = make([]{1}, n)\n'.format(goname, gotypename) s += 'for i, v := range {0} {{\n'.format(cslice) @@ -577,6 +581,11 @@ def xenlight_golang_union_to_C(ty = None, union_name = '', s += 'var {0} C.{1}\n'.format(f.name,cgotype) for uf in f.type.fields: + if isinstance(uf.type, idl.Array): + s += xenlight_golang_array_to_C(uf, cvarname=f.name, + govarname="tmp") + continue + s += xenlight_golang_convert_to_C(uf,cvarname=f.name, govarname='tmp') @@ -594,7 +603,7 @@ def xenlight_golang_union_to_C(ty = None, union_name = '', return s -def xenlight_golang_array_to_C(ty = None): +def xenlight_golang_array_to_C(ty = None, cvarname="xc", govarname="x"): s = '' gotypename = xenlight_golang_fmt_name(ty.type.elem_type.typename) @@ -606,27 +615,27 @@ def xenlight_golang_array_to_C(ty = None): is_enum = isinstance(ty.type.elem_type,idl.Enumeration) if gotypename in go_builtin_types or is_enum: - s += 'if {0} := len(x.{1}); {2} > 0 {{\n'.format(golenvar,goname,golenvar) - s += 'xc.{0} = (*C.{1})(C.malloc(C.size_t({2}*{3})))\n'.format(cname,ctypename, + s += 'if {0} := len({1}.{2}); {3} > 0 {{\n'.format(golenvar,govarname,goname,golenvar) + s += '{0}.{1} = (*C.{2})(C.malloc(C.size_t({3}*{4})))\n'.format(cvarname,cname,ctypename, golenvar,golenvar) - s += 'xc.{0} = C.int({1})\n'.format(clenvar,golenvar) - s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer(xc.{2}))[:{3}:{4}]\n'.format(goname, - ctypename,cname, + s += '{0}.{1} = C.int({2})\n'.format(cvarname,clenvar,golenvar) + s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer({2}.{3}))[:{4}:{5}]\n'.format(goname, + ctypename,cvarname,cname, golenvar,golenvar) - s += 'for i,v := range x.{0} {{\n'.format(goname) + s += 'for i,v := range {0}.{1} {{\n'.format(govarname,goname) s += 'c{0}[i] = C.{1}(v)\n'.format(goname,ctypename) s += '}\n}\n' return s - s += 'if {0} := len(x.{1}); {2} > 0 {{\n'.format(golenvar,goname,golenvar) - s += 'xc.{0} = (*C.{1})(C.malloc(C.ulong({2})*C.sizeof_{3}))\n'.format(cname,ctypename, + s += 'if {0} := len({1}.{2}); {3} > 0 {{\n'.format(golenvar,govarname,goname,golenvar) + s += '{0}.{1} = (*C.{2})(C.malloc(C.ulong({3})*C.sizeof_{4}))\n'.format(cvarname,cname,ctypename, golenvar,ctypename) - s += 'xc.{0} = C.int({1})\n'.format(clenvar,golenvar) - s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer(xc.{2}))[:{3}:{4}]\n'.format(goname, - ctypename,cname, + s += '{0}.{1} = C.int({2})\n'.format(cvarname,clenvar,golenvar) + s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer({2}.{3}))[:{4}:{5}]\n'.format(goname, + ctypename,cvarname,cname, golenvar,golenvar) - s += 'for i,v := range x.{0} {{\n'.format(goname) + s += 'for i,v := range {0}.{1} {{\n'.format(govarname,goname) s += 'if err := v.toC(&c{0}[i]); err != nil {{\n'.format(goname) s += 'return fmt.Errorf("converting field {0}: %v", err)\n'.format(goname) s += '}\n}\n}\n' -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 19:51:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 19:51:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403573.645706 (Exim 4.92) (envelope-from ) id 1oWNYv-0005iZ-AQ; Thu, 08 Sep 2022 19:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403573.645706; Thu, 08 Sep 2022 19:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNYv-0005iS-7s; Thu, 08 Sep 2022 19:51:45 +0000 Received: by outflank-mailman (input) for mailman id 403573; Thu, 08 Sep 2022 19:51:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNYt-0005iM-5r for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 19:51:43 +0000 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [2607:f8b0:4864:20::836]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8a798ee-2faf-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 21:51:42 +0200 (CEST) Received: by mail-qt1-x836.google.com with SMTP id cr9so13730964qtb.13 for ; Thu, 08 Sep 2022 12:51:42 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27]) by smtp.gmail.com with ESMTPSA id bp33-20020a05620a45a100b006b8e049cf08sm17095814qkb.2.2022.09.08.12.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 12:51:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8a798ee-2faf-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=YsI3iFijxvi+NCMqRHPiIXyCiqm6MIXQN1SaSCN3Ld8=; b=q4CLeRsZ14bwrNwYKCFtJ98mzcbQ3IwHSCI8261GXNGcuHGepaEq+vM2V33ap23fuj m2L0TMg+txeYwVsCx8AoQsaqYfWbGadXIHnEcnLxdfJ1bnrv7Xb0TER3JCPmmSVRojyC a2UJTn49BWqkUG0a62swOepxO1kjsj54JmhVA0iYVcCcwIHRdJoGIS7RIhRNLBgkmNVA HiBJzSb5lkmLQKiTcznhwHikjYnNw2Nl1ePTLpfMTkIyInzklNEH3La8HPt6P0F+RIHE f+q57hK5PooX2A1Ec735RvwA7KoEXATGw2cWpjPsbmgh6Iwi9U9xIWRLwd7jtK9OWmKz xvcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=YsI3iFijxvi+NCMqRHPiIXyCiqm6MIXQN1SaSCN3Ld8=; b=CIMHUJ19Wk8mFFkHh04Nl0drsKvLbH31mo1tiQuWlpkpQqK2zHb5Qe3mW7F6Ng/GHo g3GQ7OqfSYDBSw1Bs/oxNzH5XvwRwbXwcshPRE2t3SUl0jMhdGV/kWovzTEitrfu1lO9 7zpRUpUj84x8sfImlbCZXcOJuDtBqoLEr62M5owAkdHAIeiZytMI6so9axn8zZ747la4 1bPDAHkvUkTCFQFfoz33hY3/KPHvkHbba+mQW1lAuoXGK5kU2dh6jWMxQSPkjPaSyN8z miN/SiyLnCEV4w4Hl4AzG9iFserBa4+wP6kcgsk9kS9u4FM0vlcMA60RB30wN06vGg8n GPfA== X-Gm-Message-State: ACgBeo2pUsnz1BfgT/5zi5Tfi2QGXpAlCZL4NngF9wsMBklCBqRGUVTp z4gOkAsYbCaT0fMLM+1J96TjMfGzHTI= X-Google-Smtp-Source: AA6agR51dlMBzoWWBmSInIMh/au/9Ceh79DSjHse7XlrOpEWGvYzbxEPwR5MZcxbajxgZAEQK/0fUQ== X-Received: by 2002:a05:622a:1111:b0:35a:6ffd:9a6c with SMTP id e17-20020a05622a111100b0035a6ffd9a6cmr2722977qty.583.1662666700510; Thu, 08 Sep 2022 12:51:40 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v2 0/3] libxl smbios support Date: Thu, 8 Sep 2022 15:51:10 -0400 Message-Id: <20220908195113.218201-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. This patches adds a new xl.cfg option and libxl support to write the xenstore strings. The xl syntax looks like: smbios=["bios_vendor=Xen Project","system_version=1.0"] The Go binding generation needed extending to support Arrays inside a KeyedUnion, which is what the first patch does. The generated go code builds, but it is otherwise untested. There are also oem strings, oem-1..oem-99, that HVM loader supports. xl parse multiple oem strings like smbios=["oem=A,oem=B"], libxl then iterates over them and assigned to the oem-%d entries. Both xl and libxl check that the 99 string limit isn't exceeded. The rendered man page and html don't have a newline at then end of the new section after patch 2. """ battery_device_name=STRING ms_vm_genid="OPTION" """ however the txt format is correct: """ battery_device_name=STRING ms_vm_genid="OPTION" """ It goes away after patch 3 is applied since it adds text about the "oem" option in between the two lines above. I'm at a loss as to why this is happening. Jason Andryuk (3): golang/xenlight: Extend KeyedUnion to support Arrays xl/libxl: Add ability to specify SMBIOS strings xl/libxl: Add OEM string support to smbios docs/man/xl.cfg.5.pod.in | 49 +++++++++++++++++++++ tools/golang/xenlight/gengotypes.py | 41 ++++++++++------- tools/golang/xenlight/helpers.gen.go | 51 +++++++++++++++++++++ tools/golang/xenlight/types.gen.go | 28 ++++++++++++ tools/include/libxl.h | 5 +++ tools/libs/light/libxl_dom.c | 32 ++++++++++++++ tools/libs/light/libxl_types.idl | 27 ++++++++++++ tools/xl/xl_parse.c | 66 +++++++++++++++++++++++++++- 8 files changed, 282 insertions(+), 17 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 19:51:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 19:51:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403575.645729 (Exim 4.92) (envelope-from ) id 1oWNZ1-0006I8-SI; Thu, 08 Sep 2022 19:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403575.645729; Thu, 08 Sep 2022 19:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNZ1-0006Hz-P4; Thu, 08 Sep 2022 19:51:51 +0000 Received: by outflank-mailman (input) for mailman id 403575; Thu, 08 Sep 2022 19:51:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNZ0-0006Gh-Py for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 19:51:50 +0000 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [2607:f8b0:4864:20::832]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ace3f828-2faf-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 21:51:49 +0200 (CEST) Received: by mail-qt1-x832.google.com with SMTP id y2so1290353qtv.5 for ; Thu, 08 Sep 2022 12:51:49 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27]) by smtp.gmail.com with ESMTPSA id bp33-20020a05620a45a100b006b8e049cf08sm17095814qkb.2.2022.09.08.12.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 12:51:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ace3f828-2faf-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=mKuFsE1xzCbKzqImSGYcqjpVdk6xlc77nWyDREQe5FQ=; b=lavE+qxgI6cCGzvDUdNOApGNlGh5gKVD1nr62GKch6/+W9Erlp0HZHOUjY6VECcGul nocZakuLJzqmODZkg0o2U9UaJZ71/qXthI1HPdh7YnRESe0Wzps/SKWStIFUl3GfbJBP icP7iwdRTL21pDp4f0HZ/Ho2kUtplVyHo4b7OmxMWi2hpprNpQkr8GcQGyMGu1jrKuV8 O257UqzL+DailnlNnx60q8tuBJjNvMOxGB1v0CuVi7Na1zUA6dGrY3NX2FR+y5JRjwm0 dtFSaels8itU6dS2A+dki8EOxQF0JUUY+KxpvU9Q8ymHuEsHlnBDknWN8hTzay0Awros BoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=mKuFsE1xzCbKzqImSGYcqjpVdk6xlc77nWyDREQe5FQ=; b=rJ4qqIHyCZWkM9ffq3zzJjE+X05EonO3ESIbcGFGW9z/M3vXMvZDBUCtKBabPkf1f3 P5AfhE/KYT33XDUVSI0nvC10ocSbYPzL7TPD1h0fAm98wg0i1k4G0nQCBOe2HpJCSGfK N6tnJvxImAJmyf/Hg0KU+RYo7ZqNCFikH8DUr6n2/yATiQFeyzZ8GYnjnr2Hn3aPPku0 hwTC1iPulEysJWixyyPlUxSHuhpiUc73HAiPfuvOD9u0KiYE1MP8zsaOFMAbnGXfe/3x ANkjuXIPU2+cTHbMSNbYfyPJe/wjlH0Z1yuU1DuQvUPSDWW6abZyZwnPPEyGq+EmBUVg bU9g== X-Gm-Message-State: ACgBeo3njOQvUzhLP6vFmq5+Buk/csgCVrkImYeH5hz+acEixPsEi4iz fYGNjs7zOmQCFjU7p9LzrxNyHWn6EvE= X-Google-Smtp-Source: AA6agR6xMmRlQjJWgz96g8rDs/wxViPN8ayeEKMltfsqX3WacsA84so0i9u9/vZncWmLQao7KDnJIw== X-Received: by 2002:ac8:5b05:0:b0:342:fd04:a25c with SMTP id m5-20020ac85b05000000b00342fd04a25cmr9563738qtw.303.1662666707603; Thu, 08 Sep 2022 12:51:47 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings Date: Thu, 8 Sep 2022 15:51:12 -0400 Message-Id: <20220908195113.218201-3-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220908195113.218201-1-jandryuk@gmail.com> References: <20220908195113.218201-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. Allow specifying the strings with the new xl.cfg option: smbios=["bios_vendor=Xen Project","system_version=1.0"] In terms of strings, the SMBIOS specification 3.5 says: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.5.0.pdf """ Strings must be encoded as UTF-8 with no byte order mark (BOM). For compatibility with older SMBIOS parsers, US-ASCII characters should be used. NOTE There is no limit on the length of each individual text string. However, the length of the entire structure table (including all strings) must be reported in the Structure Table Length field of the 32-bit Structure Table Entry Point (see 5.2.1) and/or the Structure Table Maximum Size field of the 64-bit Structure Table Entry Point (see 5.2.2). """ The strings aren't checked for utf-8 or length. hvmloader has a sanity check on the overall length. The libxl_smbios_type enum starts at 1 since otherwise the 0th key is not printed in the json output. Signed-off-by: Jason Andryuk --- v2: Update s/_/-/ comment Update debug print to xs_path = "value" Error on xlu_cfg_get_listitem failure Use EXIT_FAILURE consistently free parsed strings Move break to new line The rendered man page and html don't have a newline at the end of the new section. """ battery_device_name=STRING ms_vm_genid="OPTION" """ however the txt format is correct: """ battery_device_name=STRING ms_vm_genid="OPTION" """ I'm at a loss as to why this is happening. --- docs/man/xl.cfg.5.pod.in | 45 +++++++++++++++++++++++ tools/golang/xenlight/helpers.gen.go | 51 ++++++++++++++++++++++++++ tools/golang/xenlight/types.gen.go | 27 ++++++++++++++ tools/include/libxl.h | 5 +++ tools/libs/light/libxl_dom.c | 21 +++++++++++ tools/libs/light/libxl_types.idl | 26 ++++++++++++++ tools/xl/xl_parse.c | 54 +++++++++++++++++++++++++++- 7 files changed, 228 insertions(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index b2901e04cf..fa78fba361 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2061,6 +2061,51 @@ number of vendor defined SMBIOS structures (type 128 - 255). Since SMBIOS structures do not present their overall size, each entry in the file must be preceded by a 32b integer indicating the size of the following structure. +=item B + +Specifies the SMBIOS values to be provided to the guest. These set or +override specific entries in the tables provided to the guest. + +Each B is a C string from the following list: + +=over 4 + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=back + =item B Provide a VM generation ID to the guest. diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index fa3cf2ab76..cae14ec6f5 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -589,6 +589,38 @@ xc.build_id = C.CString(x.BuildId)} return nil } +// NewSmbios returns an instance of Smbios initialized with defaults. +func NewSmbios() (*Smbios, error) { +var ( +x Smbios +xc C.libxl_smbios) + +C.libxl_smbios_init(&xc) +defer C.libxl_smbios_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *Smbios) fromC(xc *C.libxl_smbios) error { + x.Key = SmbiosType(xc.key) +x.Value = C.GoString(xc.value) + + return nil} + +func (x *Smbios) toC(xc *C.libxl_smbios) (err error){defer func(){ +if err != nil{ +C.libxl_smbios_dispose(xc)} +}() + +xc.key = C.libxl_smbios_type(x.Key) +if x.Value != "" { +xc.value = C.CString(x.Value)} + + return nil + } + // NewDomainCreateInfo returns an instance of DomainCreateInfo initialized with defaults. func NewDomainCreateInfo() (*DomainCreateInfo, error) { var ( @@ -1189,6 +1221,15 @@ return fmt.Errorf("converting field Altp2M: %v", err) } x.SystemFirmware = C.GoString(tmp.system_firmware) x.SmbiosFirmware = C.GoString(tmp.smbios_firmware) +x.Smbios = nil +if n := int(tmp.num_smbios); n > 0 { +cSmbios := (*[1<<28]C.libxl_smbios)(unsafe.Pointer(tmp.smbios))[:n:n] +x.Smbios = make([]Smbios, n) +for i, v := range cSmbios { +if err := x.Smbios[i].fromC(&v); err != nil { +return fmt.Errorf("converting field Smbios: %v", err) } +} +} x.AcpiFirmware = C.GoString(tmp.acpi_firmware) x.Hdtype = Hdtype(tmp.hdtype) if err := x.Nographic.fromC(&tmp.nographic);err != nil { @@ -1501,6 +1542,16 @@ if tmp.SystemFirmware != "" { hvm.system_firmware = C.CString(tmp.SystemFirmware)} if tmp.SmbiosFirmware != "" { hvm.smbios_firmware = C.CString(tmp.SmbiosFirmware)} +if numSmbios := len(tmp.Smbios); numSmbios > 0 { +hvm.smbios = (*C.libxl_smbios)(C.malloc(C.ulong(numSmbios)*C.sizeof_libxl_smbios)) +hvm.num_smbios = C.int(numSmbios) +cSmbios := (*[1<<28]C.libxl_smbios)(unsafe.Pointer(hvm.smbios))[:numSmbios:numSmbios] +for i,v := range tmp.Smbios { +if err := v.toC(&cSmbios[i]); err != nil { +return fmt.Errorf("converting field Smbios: %v", err) +} +} +} if tmp.AcpiFirmware != "" { hvm.acpi_firmware = C.CString(tmp.AcpiFirmware)} hvm.hdtype = C.libxl_hdtype(tmp.Hdtype) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index a0be7ada8c..e084c3540b 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -386,6 +386,32 @@ Commandline string BuildId string } +type SmbiosType int +const( +SmbiosTypeBiosVendor SmbiosType = 1 +SmbiosTypeBiosVersion SmbiosType = 2 +SmbiosTypeSystemManufacturer SmbiosType = 3 +SmbiosTypeSystemProductName SmbiosType = 4 +SmbiosTypeSystemVersion SmbiosType = 5 +SmbiosTypeSystemSerialNumber SmbiosType = 6 +SmbiosTypeBaseboardManufacturer SmbiosType = 7 +SmbiosTypeBaseboardProductName SmbiosType = 8 +SmbiosTypeBaseboardVersion SmbiosType = 9 +SmbiosTypeBaseboardSerialNumber SmbiosType = 10 +SmbiosTypeBaseboardAssetTag SmbiosType = 11 +SmbiosTypeBaseboardLocationInChassis SmbiosType = 12 +SmbiosTypeEnclosureManufacturer SmbiosType = 13 +SmbiosTypeEnclosureSerialNumber SmbiosType = 14 +SmbiosTypeEnclosureAssetTag SmbiosType = 15 +SmbiosTypeBatteryManufacturer SmbiosType = 16 +SmbiosTypeBatteryDeviceName SmbiosType = 17 +) + +type Smbios struct { +Key SmbiosType +Value string +} + type DomainCreateInfo struct { Type DomainType Hap Defbool @@ -568,6 +594,7 @@ NestedHvm Defbool Altp2M Defbool SystemFirmware string SmbiosFirmware string +Smbios []Smbios AcpiFirmware string Hdtype Hdtype Nographic Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 2321a648a5..023613d35b 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -174,6 +174,11 @@ */ #define LIBXL_HAVE_BUILDINFO_HVM_MS_VM_GENID 1 +/* + * libxl_domain_build_info has the u.hvm.smbios field. + */ +#define LIBXL_HAVE_BUILDINFO_HVM_SMBIOS 1 + /* * LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY indicates that a 'cpumap_soft' * field (of libxl_bitmap type) is present in libxl_vcpuinfo, diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 2abaab439c..c3125ed310 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -771,6 +771,27 @@ static int hvm_build_set_xs_values(libxl__gc *gc, goto err; } + for (int i = 0; i < info->u.hvm.num_smbios; i++) { + char *p; + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); + + /* Convert libxl_smbios_type string to xenstore path that hvmloader + will use, as defined by HVM_XS_*. That is convert the '_' to '-'. */ + p = strrchr(path, '/'); + for ( ; *p; p++) { + if (*p == '_') + *p = '-'; + } + + LOGD(DEBUG, domid, "Writing %s = \"%s\"\n", path, + info->u.hvm.smbios[i].value); + ret = libxl__xs_printf(gc, XBT_NULL, path, "%s", + info->u.hvm.smbios[i].value); + if (ret) + goto err; + } + /* Only one module can be passed. PVHv2 guests do not support this. */ if (dom->acpi_modules[0].guest_addr_out && info->type == LIBXL_DOMAIN_TYPE_HVM) { diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d634f304cd..d04207748e 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -418,6 +418,31 @@ libxl_version_info = Struct("version_info", [ ("build_id", string), ], dir=DIR_OUT) +libxl_smbios_type = Enumeration("smbios_type", [ + (1, "bios_vendor"), + (2, "bios_version"), + (3, "system_manufacturer"), + (4, "system_product_name"), + (5, "system_version"), + (6, "system_serial_number"), + (7, "baseboard_manufacturer"), + (8, "baseboard_product_name"), + (9, "baseboard_version"), + (10, "baseboard_serial_number"), + (11, "baseboard_asset_tag"), + (12, "baseboard_location_in_chassis"), + (13, "enclosure_manufacturer"), + (14, "enclosure_serial_number"), + (15, "enclosure_asset_tag"), + (16, "battery_manufacturer"), + (17, "battery_device_name"), + ]) + +libxl_smbios = Struct("smbios", [ + ("key", libxl_smbios_type), + ("value", string), + ], dir=DIR_IN) + libxl_domain_create_info = Struct("domain_create_info",[ ("type", libxl_domain_type), ("hap", libxl_defbool), @@ -604,6 +629,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("altp2m", libxl_defbool), ("system_firmware", string), ("smbios_firmware", string), + ("smbios", Array(libxl_smbios, "num_smbios")), ("acpi_firmware", string), ("hdtype", libxl_hdtype), ("nographic", libxl_defbool), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1b5381cef0..5413c36645 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1220,8 +1220,9 @@ void parse_config_data(const char *config_source, XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms, *usbctrls, *usbdevs, *p9devs, *vdispls, *pvcallsifs_devs; XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs, - *mca_caps; + *mca_caps, *smbios; int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps; + int num_smbios; int pci_power_mgmt = 0; int pci_msitranslate = 0; int pci_permissive = 0; @@ -1783,6 +1784,57 @@ void parse_config_data(const char *config_source, xlu_cfg_replace_string(config, "acpi_firmware", &b_info->u.hvm.acpi_firmware, 0); + switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) + { + case 0: /* Success */ + b_info->u.hvm.num_smbios = num_smbios; + b_info->u.hvm.smbios = xcalloc(num_smbios, sizeof(libxl_smbios)); + for (i = 0; i < num_smbios; i++) { + char *option_untrimmed, *value_untrimmed; + char *option, *value; + libxl_smbios_type v; + + buf = xlu_cfg_get_listitem(smbios, i); + if (!buf) { + fprintf(stderr, + "xl: Unable to get element #%d in smbios list\n", + i); + exit(EXIT_FAILURE); + } + + if (split_string_into_pair(buf, "=", + &option_untrimmed, + &value_untrimmed)) { + fprintf(stderr, "xl: failed to split \"%s\" into pair\n", + buf); + exit(EXIT_FAILURE); + } + trim(isspace, option_untrimmed, &option); + trim(isspace, value_untrimmed, &value); + free(option_untrimmed); + free(value_untrimmed); + + e = libxl_smbios_type_from_string(option, &v); + if (e) { + fprintf(stderr, + "xl: unknown smbios type '%s'\n", + buf); + exit(EXIT_FAILURE); + } + free(option); + + b_info->u.hvm.smbios[i].key = v; + b_info->u.hvm.smbios[i].value = value; + } + break; + } + case ESRCH: /* Option not present */ + break; + default: + fprintf(stderr,"xl: Unable to parse smbios options.\n"); + exit(EXIT_FAILURE); + } + if (!xlu_cfg_get_string(config, "ms_vm_genid", &buf, 0)) { if (!strcmp(buf, "generate")) { e = libxl_ms_vm_genid_generate(ctx, &b_info->u.hvm.ms_vm_genid); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 19:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 19:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403576.645740 (Exim 4.92) (envelope-from ) id 1oWNZ4-0006aU-9K; Thu, 08 Sep 2022 19:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403576.645740; Thu, 08 Sep 2022 19:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNZ4-0006aJ-62; Thu, 08 Sep 2022 19:51:54 +0000 Received: by outflank-mailman (input) for mailman id 403576; Thu, 08 Sep 2022 19:51:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWNZ2-0006Gh-9q for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 19:51:52 +0000 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [2607:f8b0:4864:20::730]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae4d52bb-2faf-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 21:51:51 +0200 (CEST) Received: by mail-qk1-x730.google.com with SMTP id d15so1315375qka.9 for ; Thu, 08 Sep 2022 12:51:51 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27]) by smtp.gmail.com with ESMTPSA id bp33-20020a05620a45a100b006b8e049cf08sm17095814qkb.2.2022.09.08.12.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 12:51:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae4d52bb-2faf-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BfIK73LhsgvoonHDGwM8ni7GnGln9k+nUNcjXEorNtg=; b=gI/EPdKEfu4OL3Ad95ueCyGYqP0gnXMZU8zy29VWl4kvsy6kmPLM2mOpOdk0GKkW6c uDzTYp2KBUVJUreOgiu28sVUEFbAcsd79c+W6kwIc52cel3ecQO3v6schFBn4C5sy7S1 XNrPsXjAkv2+j/scMaaV8MjoS02oToXzVEyjIRPdblgTCZbmMwrnEkvFWMvtjibqt271 /cOpugvA2e8EUI5os6iNGTxjD60YiR7aJGDf2EOMA9biJAL0oAG71EaV8Snm7TVVPgzn HmGsdzdogTvlYDEghGME1HkuO/J/fIC9/296QF2d65ekCUjKe3jjtzTXcGvDXQ3i6qkH 7ZNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BfIK73LhsgvoonHDGwM8ni7GnGln9k+nUNcjXEorNtg=; b=yEuSQ1AhePCHq/j82IUNpgmXTEMQWF5fVFXsxFVEzbt4ZPSfDBx5w7MngDxmZuCtHM q2Qx3Ge8wFXZEQbJ8om1unareYHVB6D5Z/qTzJHjhPHU+liXx91m8hN1ev79+Rf5Ltoi 8fw1Lbh+7z9N892CaSRNRf5VrG9FbZQPBg0cjURBlkBiD74UMSuqYzNVL770xApkkEyB szDKCamlIO6qFx03UyzKi0k7CmA+zo6JNmPLEbf0l2qupMgPRLZiRXBTPpTsdwJzQiRB /xl2fB6mq+9lw+1pq94ibMxuO/E2jLUSicL3ppyuL9Ylr7z6nnTjmgfOsRsMpVigSLKY iVaQ== X-Gm-Message-State: ACgBeo20YtEwqd1BH83sTQ3Pqm+k5YZb8qGSrCojHXHzTgcgaUq9SAqm FNTbK0QQCJxMJQ2NHKHoQx8oeLl6yco= X-Google-Smtp-Source: AA6agR6+hC/F719d9liH745eJACRB2wYFcMVHq5BW4bw9QgoMTO+/SixWy1Hx/neKt9PnEqpKWfHeQ== X-Received: by 2002:a05:620a:2b98:b0:6bb:11fc:40b7 with SMTP id dz24-20020a05620a2b9800b006bb11fc40b7mr7978841qkb.467.1662666710145; Thu, 08 Sep 2022 12:51:50 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [PATCH v2 3/3] xl/libxl: Add OEM string support to smbios Date: Thu, 8 Sep 2022 15:51:13 -0400 Message-Id: <20220908195113.218201-4-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220908195113.218201-1-jandryuk@gmail.com> References: <20220908195113.218201-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for OEM strings in the SMBIOS type 11. hvmloader checks them sequentially, so hide the implementation detail. Allow multiple plain oem= items and assign the numeric values internally. Signed-off-by: Jason Andryuk --- v2: Move oem= description to be indented in docs Re-work oem= description Re-word oem string limit xl error message Replace OEM_{1,99) with just OEM and handle in libxl This change re-introduces the newline before ms_vm_genid. --- docs/man/xl.cfg.5.pod.in | 4 ++++ tools/golang/xenlight/types.gen.go | 1 + tools/libs/light/libxl_dom.c | 15 +++++++++++++-- tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 12 ++++++++++++ 5 files changed, 31 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index fa78fba361..ddba1c3a05 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2104,6 +2104,10 @@ Each B is a C string from the following list: =item B +=item B + +oem= can be specified up to 99 times. + =back =item B diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index e084c3540b..51076249b4 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -405,6 +405,7 @@ SmbiosTypeEnclosureSerialNumber SmbiosType = 14 SmbiosTypeEnclosureAssetTag SmbiosType = 15 SmbiosTypeBatteryManufacturer SmbiosType = 16 SmbiosTypeBatteryDeviceName SmbiosType = 17 +SmbiosTypeOem SmbiosType = 18 ) type Smbios struct { diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index c3125ed310..0b01e09632 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -753,6 +753,7 @@ static int hvm_build_set_xs_values(libxl__gc *gc, const libxl_domain_build_info *info) { char *path = NULL; + int num_oem = 1; int ret = 0; if (dom->smbios_module.guest_addr_out) { @@ -773,8 +774,18 @@ static int hvm_build_set_xs_values(libxl__gc *gc, for (int i = 0; i < info->u.hvm.num_smbios; i++) { char *p; - path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, - libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); + if (info->u.hvm.smbios[i].key == LIBXL_SMBIOS_TYPE_OEM) { + if (num_oem > 99) { + ret = ERROR_INVAL; + goto err; + } + path = GCSPRINTF("/local/domain/%d/"HVM_XS_OEM_STRINGS, domid, + num_oem); + num_oem++; + } else { + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); + } /* Convert libxl_smbios_type string to xenstore path that hvmloader will use, as defined by HVM_XS_*. That is convert the '_' to '-'. */ diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d04207748e..76651eea43 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -436,6 +436,7 @@ libxl_smbios_type = Enumeration("smbios_type", [ (15, "enclosure_asset_tag"), (16, "battery_manufacturer"), (17, "battery_device_name"), + (18, "oem"), ]) libxl_smbios = Struct("smbios", [ diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 5413c36645..d0f8a14827 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1787,6 +1787,9 @@ void parse_config_data(const char *config_source, switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) { case 0: /* Success */ + { + unsigned int num_oem = 1; + b_info->u.hvm.num_smbios = num_smbios; b_info->u.hvm.smbios = xcalloc(num_smbios, sizeof(libxl_smbios)); for (i = 0; i < num_smbios; i++) { @@ -1823,6 +1826,15 @@ void parse_config_data(const char *config_source, } free(option); + if (v == LIBXL_SMBIOS_TYPE_OEM) { + if (num_oem > 99) { + fprintf(stderr, + "xl: smbios limited to 99 oem strings\n"); + exit(-ERROR_FAIL); + } + num_oem++; + } + b_info->u.hvm.smbios[i].key = v; b_info->u.hvm.smbios[i].value = value; } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 08 20:40:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 20:40:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403605.645750 (Exim 4.92) (envelope-from ) id 1oWOJt-0005O4-S4; Thu, 08 Sep 2022 20:40:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403605.645750; Thu, 08 Sep 2022 20:40:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWOJt-0005Nx-PQ; Thu, 08 Sep 2022 20:40:17 +0000 Received: by outflank-mailman (input) for mailman id 403605; Thu, 08 Sep 2022 20:40:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWOJt-0005Nr-17 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 20:40:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70eecd5d-2fb6-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 22:40:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF65061E14; Thu, 8 Sep 2022 20:40:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EC18C433D6; Thu, 8 Sep 2022 20:40:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70eecd5d-2fb6-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662669613; bh=08NehVnCTlBWwkrfZz9F40ObsujsF1ultqYkmk3lmoI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=th+x/B1v0j4Erko+4qzhOh1aqSGrcpIDGk3cjZthg55ifqSTdMeD83/u2KoJ1Udxy 4fvDQ2ocUuvbcot3UhYOSCgK9BZvPFnbW0kj1uYrtwmfQR2g2PHo8o2HtxAQ33vTWL siJ+T1JFPn0euNy4MNJ8GnQYDOB2gM1/aqYxNF+KzdSE7rSYZnWsM62U2rtkZurCs9 xDnEO2Ef5KrrzhxxRbx6hRr8xFRDouxf7mpnbkrRo4LzuzyG9d4elid0AQ/TXtDePY 6TqRpfNCbhtRqmO9zBDxKjvKdlStdmVFYeCS7NuvmCuBcO/RUCm+pu4dqDliRJRU/z V6twpA7/cAR6w== Date: Thu, 8 Sep 2022 13:40:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Rahul Singh , xen-devel@lists.xenproject.org, Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v5 7/7] xen/arm: introduce xen-evtchn dom0less property In-Reply-To: <4e561e37-d911-4be9-f50d-3799c71ee3cf@xen.org> Message-ID: References: <4e561e37-d911-4be9-f50d-3799c71ee3cf@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Sep 2022, Julien Grall wrote: > On 08/09/2022 01:04, Stefano Stabellini wrote: > > On Wed, 7 Sep 2022, Rahul Singh wrote: > > > Introduce a new sub-node under /chosen node to establish static event > > > channel communication between domains on dom0less systems. > > > > > > An event channel will be created beforehand to allow the domains to > > > send notifications to each other. > > > > > > Signed-off-by: Rahul Singh > > > > For the DT binding: > > > > Reviewed-by: Stefano Stabellini > > This is now committed but I didn't notice the "For the DT binding" above. So I > mistakenly interpreted this as you reviewed everything. Let me know if that's > a problem with you. No problems, I looked at the commit now and everything looks good anyway. > For the future may I ask to use suffix with "# DT binding" as this is easier > to spot when using automatic tools (e.g. b4)? I think that's a good idea. From xen-devel-bounces@lists.xenproject.org Thu Sep 08 21:00:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 21:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403613.645762 (Exim 4.92) (envelope-from ) id 1oWOcu-0007SP-Fp; Thu, 08 Sep 2022 20:59:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403613.645762; Thu, 08 Sep 2022 20:59:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWOcu-0007SI-Ce; Thu, 08 Sep 2022 20:59:56 +0000 Received: by outflank-mailman (input) for mailman id 403613; Thu, 08 Sep 2022 20:59:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWOct-0007SC-8i for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 20:59:55 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f3f94e4-2fb9-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 22:59:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 93475CE20ED; Thu, 8 Sep 2022 20:59:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28140C433C1; Thu, 8 Sep 2022 20:59:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f3f94e4-2fb9-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662670789; bh=8T1i6CCzLZ9hUYkUdbtg+UbOOOEJxHWjzRDsHjyf2mA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=oK9Zd1FjG5S65yNpFBfc47cDrJ8t6EZw+HdQPkBHniC/RuIkMikESG9GJpebOdPLC grrJ4VO49ugJs3K2669uK4aHuwYcs30ZYYfhKp69X6t39/gobinTBl/dMAjxChvn8P Aqsh7EoiwwIzFxYN7MKlBW8bA/GY+lnbiMJR59Jfj7I/y0KGacsXhntWcNNQmLV1hR 0mDBMp8Lf+y74F+raoknnoa4mDbmu6+sfWTJ7tZOnMDz+GVeCNEQTtDaAkCz+6lwt3 N97eQgHyy42AbovMDYUPYOo5tekwHE/Fbims6A01C4kvIqzqMINJSTDX5LeADv/wVJ 0HEZB3c2lfekw== Date: Thu, 8 Sep 2022 13:59:47 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar In-Reply-To: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> Message-ID: References: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Sep 2022, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh > Acked-by: Jan Beulich # x86, common > --- > Changes in v5: > - drop use of PFN_UP and PF_DOWN in case addresses are not aligned. > - As we drop the PFN_UP and PFN_DOWN we need to use the mfn_to_maddr() > to get the BAR address without page shift. > - Add TODO comment for address alignment check for ranges. > - Added Jan Acked-by for x86 and common code. > Changes in v4: > - check "s <= e" before callback > - Add TODO comment for revisiting the function pci_check_bar() when > ACPI PCI passthrough support is added. > - Not Added the Jan Acked-by as patch is modified. > Changes in v3: > - fix minor comments > --- > xen/arch/arm/include/asm/pci.h | 2 ++ > xen/arch/arm/pci/pci-host-common.c | 54 ++++++++++++++++++++++++++++++ > xen/arch/x86/include/asm/pci.h | 10 ++++++ > xen/drivers/passthrough/pci.c | 8 ++--- > 4 files changed, 70 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h > index 80a2431804..8cb46f6b71 100644 > --- a/xen/arch/arm/include/asm/pci.h > +++ b/xen/arch/arm/include/asm/pci.h > @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, > > int pci_host_bridge_mappings(struct domain *d); > > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); > + > #else /*!CONFIG_HAS_PCI*/ > > struct arch_pci_dev { }; > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index 89ef30028e..d51cfdf352 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -24,6 +24,16 @@ > > #include > > +/* > + * struct to hold pci device bar. > + */ > +struct pdev_bar_check > +{ > + unsigned long start; > + unsigned long end; > + bool is_valid; > +}; > + > /* > * List for all the pci host bridges. > */ > @@ -363,6 +373,50 @@ int __init pci_host_bridge_mappings(struct domain *d) > return 0; > } > > +/* > + * TODO: BAR addresses and Root Complex window addresses are not guaranteed > + * to be page aligned. We should check for alignment but this is not the > + * right place for alignment check. > + */ > +static int is_bar_valid(const struct dt_device_node *dev, > + uint64_t addr, uint64_t len, void *data) > +{ > + struct pdev_bar_check *bar_data = data; > + unsigned long s = bar_data->start; > + unsigned long e = bar_data->end; > + > + if ( (s >= addr) && (e <= (addr + len - 1)) ) > + bar_data->is_valid = true; "s" and "e" are "unsigned long" while "addr" and "len" are uint64_t. Is that OK? Specifically, considering a potential arm32 case, shouldn't "s" and "e" be uint64_t as well? Which means pdev_bar_check.start and end should be uint64_t? > + return 0; > +} > + > +/* TODO: Revisit this function when ACPI PCI passthrough support is added. */ > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) > +{ > + int ret; > + const struct dt_device_node *dt_node; > + unsigned long s = mfn_to_maddr(start); > + unsigned long e = mfn_to_maddr(end); > + struct pdev_bar_check bar_data = { > + .start = s, > + .end = e, > + .is_valid = false > + }; > + > + if ( s >= e ) > + return false; > + > + dt_node = pci_find_host_bridge_node(pdev); > + if ( !dt_node ) > + return false; > + > + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); > + if ( ret < 0 ) > + return false; > + > + return bar_data.is_valid; > +} > /* > * Local variables: > * mode: C > diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h > index c8e1a9ecdb..f4a58c8acf 100644 > --- a/xen/arch/x86/include/asm/pci.h > +++ b/xen/arch/x86/include/asm/pci.h > @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) > > void arch_pci_init_pdev(struct pci_dev *pdev); > > +static inline bool pci_check_bar(const struct pci_dev *pdev, > + mfn_t start, mfn_t end) > +{ > + /* > + * Check if BAR is not overlapping with any memory region defined > + * in the memory map. > + */ > + return is_memory_hole(start, end); > +} > + > #endif /* __X86_PCI_H__ */ > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index cdaf5c247f..149f68bb6e 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) > if ( rc < 0 ) > /* Unable to size, better leave memory decoding disabled. */ > return; > - if ( size && !is_memory_hole(maddr_to_mfn(addr), > - maddr_to_mfn(addr + size - 1)) ) > + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), > + maddr_to_mfn(addr + size - 1)) ) > { > /* > * Return without enabling memory decoding if BAR position is not > @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) > > if ( rc < 0 ) > return; > - if ( size && !is_memory_hole(maddr_to_mfn(addr), > - maddr_to_mfn(addr + size - 1)) ) > + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), > + maddr_to_mfn(addr + size - 1)) ) > { > printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), > PFN_DOWN(addr + size - 1)); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 21:05:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 21:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403621.645773 (Exim 4.92) (envelope-from ) id 1oWOiU-0000TJ-4N; Thu, 08 Sep 2022 21:05:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403621.645773; Thu, 08 Sep 2022 21:05:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWOiU-0000TC-0N; Thu, 08 Sep 2022 21:05:42 +0000 Received: by outflank-mailman (input) for mailman id 403621; Thu, 08 Sep 2022 21:05:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWOiS-0000T6-CS for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 21:05:40 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcf9ec9a-2fb9-11ed-9760-273f2230c3a0; Thu, 08 Sep 2022 23:05:38 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 693DA61E28; Thu, 8 Sep 2022 21:05:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6AFEC433C1; Thu, 8 Sep 2022 21:05:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcf9ec9a-2fb9-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662671136; bh=zYV4niBGo2C6EYFdrPfUPDo7pOJunhfSjauGD0K7kPw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g03SwsyOIJV54DTD4Vvf1armktQivaZvHNaT0uIydH4q+Jmv0oY9dJptS8AUOCD7D 0722hDulp7lRypTFYYpowmFLcEAxMwtwVWw/goJFgtV2SGkib/VGNTnnG3Z+Y2cC2C o/dTREmtYxth5SLj5x9mOKbEaHNgtHN491VYQC3Jqh2wQ5uiIlmE+8iw4+oQ9nxIQK yhMYfiFMPEU59wen3/yXVBZTlFnojez5w/Bjej6equGLUkV0L3CCmjKruWvSzwOrIY SzJ7WTknwxyOTWc3r4FiI6B3yQG1L6sIlHYHCEJgEO02iQMZcSxAXv3Sai3He6oq9Z 5alkuBqhKTXmQ== Date: Thu, 8 Sep 2022 14:05:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree In-Reply-To: <20220908135513.1800511-8-Penny.Zheng@arm.com> Message-ID: References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Sep 2022, Penny Zheng wrote: > We expose the shared memory to the domU using the "xen,shared-memory-v1" > reserved-memory binding. See > Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt > in Linux for the corresponding device tree binding. > > To save the cost of re-parsing shared memory device tree configuration when > creating shared memory nodes in guest device tree, this commit adds new field > "shm_mem" to store shm-info per domain. > > For each shared memory region, a range is exposed under > the /reserved-memory node as a child node. Each range sub-node is > named xen-shmem@
and has the following properties: > - compatible: > compatible = "xen,shared-memory-v1" > - reg: > the base guest physical address and size of the shared memory region > - xen,id: > a string that identifies the shared memory region. > - xen,offset: (borrower VMs only) > 64 bit integer offset within the owner virtual machine's shared > memory region used for the mapping in the borrower VM. > Currently, we provide "xen,offset=<0x0>" as a temprary placeholder. ^ temporary Another minor style issue below > Signed-off-by: Penny Zheng > Reviewed-by: Stefano Stabellini > --- > v8 changes: > - Fix missing property "xen,offset" for borrower VMs by temporarily > adding "xen,offset=<0x0>" > - use >= to avoid thinking about the overflow case for nr_banks > - check the return value of dt_property_read_string() for parsing > shm_id > - struct meminfo *mem and char resvbuf[16] = "reserved-memory" could be > const > - change "__be32 reg[4]" to "__be32 reg[GUEST_ROOT_ADDRESS_CELLS + > GUEST_ROOT_SIZE_CELLS]" > --- > v7 changes: > - allocate reg for worst case addrcells + sizecells > - replace assert() with BUG_ON() since it is init code > --- > v6 change: > - change "struct meminfo *mem" to "const struct meminfo *mem" > - change "unsigned long i" to "unsigned int i" to match the type of nr_banks. > - accroding to the Linux binding, "xen,id" is meant to be a string, not > an integer > --- > v5 change: > - no change > --- > v4 change: > - no change > --- > v3 change: > - move field "shm_mem" to kernel_info > --- > v2 change: > - using xzalloc > - shm_id should be uint8_t > - make reg a local variable > - add #address-cells and #size-cells properties > - fix alignment > --- > xen/arch/arm/domain_build.c | 160 +++++++++++++++++++++++++++++- > xen/arch/arm/include/asm/kernel.h | 1 + > 2 files changed, 159 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index a10d07266b..cd03370b38 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -914,7 +914,22 @@ static int __init assign_shared_memory(struct domain *d, > return ret; > } > > -static int __init process_shm(struct domain *d, > +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > + paddr_t start, paddr_t size, > + const char *shm_id) > +{ > + if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) > + return -ENOMEM; > + > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); > + kinfo->shm_mem.nr_banks++; > + > + return 0; > +} > + > +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > const struct dt_device_node *node) > { > struct dt_device_node *shm_node; > @@ -928,6 +943,7 @@ static int __init process_shm(struct domain *d, > int ret = 0; > unsigned int i; > const char *role_str; > + const char *shm_id; > bool owner_dom_io = true; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > @@ -972,6 +988,13 @@ static int __init process_shm(struct domain *d, > if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) > owner_dom_io = false; > > + if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) > + { > + printk("%pd: invalid \"xen,shm-id\" property", d); > + return -EINVAL; > + } > + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > @@ -999,6 +1022,14 @@ static int __init process_shm(struct domain *d, > if ( ret ) > return ret; > } > + > + /* > + * Record static shared memory region info for later setting > + * up shm-node in guest device tree. > + */ > + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); > + if ( ret ) > + return ret; > } > > return 0; > @@ -1331,6 +1362,126 @@ static int __init make_memory_node(const struct domain *d, > return res; > } > > +#ifdef CONFIG_STATIC_SHM > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + const struct meminfo *mem) > +{ > + unsigned int i = 0; > + int res = 0; > + > + if ( mem->nr_banks == 0 ) > + return -ENOENT; > + > + /* > + * For each shared memory region, a range is exposed under > + * the /reserved-memory node as a child node. Each range sub-node is > + * named xen-shmem@
. > + */ > + dt_dprintk("Create xen-shmem node\n"); > + > + for ( ; i < mem->nr_banks; i++ ) > + { > + uint64_t start = mem->bank[i].start; > + uint64_t size = mem->bank[i].size; > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > + char buf[27]; > + const char compat[] = "xen,shared-memory-v1"; > + /* Worst case addrcells + sizecells */ > + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; > + __be32 *cells; > + unsigned int len = (addrcells + sizecells) * sizeof(__be32); > + > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); > + res = fdt_begin_node(fdt, buf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); > + if ( res ) > + return res; > + > + cells = reg; > + dt_child_set_range(&cells, addrcells, sizecells, start, size); > + > + res = fdt_property(fdt, "reg", reg, len); > + if ( res ) > + return res; > + > + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", > + i, start, start + size); > + > + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); > + if ( res ) > + return res; > + > + /* TODO: It should be: /* * TODO: * I think this is good to go. The two minor style issues could be fixed on commit. I haven't committed to give Julien & Bertrand another chance to have a look. > + * - xen,offset: (borrower VMs only) > + * 64 bit integer offset within the owner virtual machine's shared > + * memory region used for the mapping in the borrower VM > + */ > + res = fdt_property_u64(fdt, "xen,offset", 0); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + if ( res ) > + return res; > + } > + > + return res; > +} > +#else > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + const struct meminfo *mem) > +{ > + ASSERT_UNREACHABLE(); > +} > +#endif > + > +static int __init make_resv_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + const struct meminfo *mem) > +{ > + int res = 0; > + /* Placeholder for reserved-memory\0 */ > + const char resvbuf[16] = "reserved-memory"; > + > + if ( mem->nr_banks == 0 ) > + /* No shared memory provided. */ > + return 0; > + > + dt_dprintk("Create reserved-memory node\n"); > + > + res = fdt_begin_node(fdt, resvbuf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "ranges", NULL, 0); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#address-cells", addrcells); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#size-cells", sizecells); > + if ( res ) > + return res; > + > + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + > + return res; > +} > + > static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) > { > struct meminfo *ext_regions = data; > @@ -3108,6 +3259,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > if ( ret ) > goto err; > > + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, > + &kinfo->shm_mem); > + if ( ret ) > + goto err; > + > /* > * domain_handle_dtb_bootmodule has to be called before the rest of > * the device tree is generated because it depends on the value of > @@ -3484,7 +3640,7 @@ static int __init construct_domU(struct domain *d, > assign_static_memory_11(d, &kinfo, node); > > #ifdef CONFIG_STATIC_SHM > - rc = process_shm(d, node); > + rc = process_shm(d, &kinfo, node); > if ( rc < 0 ) > return rc; > #endif > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index c4dc039b54..2cc506b100 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -19,6 +19,7 @@ struct kernel_info { > void *fdt; /* flat device tree */ > paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ > struct meminfo mem; > + struct meminfo shm_mem; > > /* kernel entry point */ > paddr_t entry; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 21:37:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 21:37:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403633.645784 (Exim 4.92) (envelope-from ) id 1oWPD4-0004Um-QM; Thu, 08 Sep 2022 21:37:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403633.645784; Thu, 08 Sep 2022 21:37:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPD4-0004Uf-Mj; Thu, 08 Sep 2022 21:37:18 +0000 Received: by outflank-mailman (input) for mailman id 403633; Thu, 08 Sep 2022 21:37:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPD3-0004UV-0j; Thu, 08 Sep 2022 21:37:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPD2-0000z7-RZ; Thu, 08 Sep 2022 21:37:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPD2-0005Zu-As; Thu, 08 Sep 2022 21:37:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWPD2-0006ds-AM; Thu, 08 Sep 2022 21:37:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oNLpGBmm/WH4vl1lcrumL9B5JN3gwdPG2KaWzscEukk=; b=0/+hg3sV/IHsXUDvQNkROFywr5 nuuvbO+Dbh2XjdNamkNV70vV7GMh6uhqcF3HYxxl1nYawKgZub4USDF6XpIU1vzTWBY+m6+uGUsPZ uAKvk3OcESNbT0E6nP6fe0vwvVMliOhyjRuoRm5tEoRpc4efFX1JCHHO0phZmTSwQ0EA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173060: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Thu, 08 Sep 2022 21:37:16 +0000 flight 173060 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173060/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 36 days Failing since 172148 2022-08-04 21:39:38 Z 34 days 79 attempts Testing same since 173060 2022-09-08 07:34:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 21:39:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 21:39:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403642.645795 (Exim 4.92) (envelope-from ) id 1oWPF2-0005Ls-9Q; Thu, 08 Sep 2022 21:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403642.645795; Thu, 08 Sep 2022 21:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPF2-0005Ll-5B; Thu, 08 Sep 2022 21:39:20 +0000 Received: by outflank-mailman (input) for mailman id 403642; Thu, 08 Sep 2022 21:39:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPF1-0005Lb-8K; Thu, 08 Sep 2022 21:39:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPF1-00010f-7U; Thu, 08 Sep 2022 21:39:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPF0-0005gN-G5; Thu, 08 Sep 2022 21:39:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWPF0-0001gk-FY; Thu, 08 Sep 2022 21:39:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NiO04IzxjIfHPyWqNrjzGH8kCKIAT7Z5zKQDrc1SRhc=; b=VwBCcqrnIH11e4MC0VLUF02wHB oZlfPdBATmX6aqRlpfEHR+YYeObGGqvHRnuuYQeIITgT00+MwpVLl8HwD0mHnSx6TGedeG92Sdgrd y2I8FaUnIzXEn1XwIFh+oEFYMA4dNsV6+35L/15xCswqwIO9cuCaeH0elmLw99S2jPws=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173070: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=7b8f69d7e10628d473dd225224d8c2122d25a38d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 21:39:18 +0000 flight 173070 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173070/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 7b8f69d7e10628d473dd225224d8c2122d25a38d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 269 attempts Testing same since 173070 2022-09-08 19:43:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2261 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 21:41:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 21:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403648.645806 (Exim 4.92) (envelope-from ) id 1oWPGq-0006k0-MN; Thu, 08 Sep 2022 21:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403648.645806; Thu, 08 Sep 2022 21:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPGq-0006jt-I4; Thu, 08 Sep 2022 21:41:12 +0000 Received: by outflank-mailman (input) for mailman id 403648; Thu, 08 Sep 2022 21:41:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPGp-0006ji-3h for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 21:41:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPGo-00013l-5a; Thu, 08 Sep 2022 21:41:10 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWPGn-0006JN-Uo; Thu, 08 Sep 2022 21:41:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=pFmerkRVZFcdzCBqZoAQjDtRhdotPXWqaexG/PxU94c=; b=Q1gex/ZmFkL9KQvkWUy+lJTWqs L4K6JGYuuywWQwIupU8JJYxkRIXOQer44/8Bc98/Kk0VGbIKDHG+RpBke/s4Ix01d/3TBOyQHheCz dif5T7/q4vnNkYw7RZ/qk2xQ6tW+4+x+g0G0aKKWn4EDtZBNP6oLJJOIyaDXpzbnkmS4=; Message-ID: Date: Thu, 8 Sep 2022 22:41:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Stefano Stabellini , Rahul Singh Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant References: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> From: Julien Grall Subject: Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 08/09/2022 21:59, Stefano Stabellini wrote: >> +/* >> + * TODO: BAR addresses and Root Complex window addresses are not guaranteed >> + * to be page aligned. We should check for alignment but this is not the >> + * right place for alignment check. >> + */ >> +static int is_bar_valid(const struct dt_device_node *dev, >> + uint64_t addr, uint64_t len, void *data) >> +{ >> + struct pdev_bar_check *bar_data = data; >> + unsigned long s = bar_data->start; >> + unsigned long e = bar_data->end; >> + >> + if ( (s >= addr) && (e <= (addr + len - 1)) ) >> + bar_data->is_valid = true; > > "s" and "e" are "unsigned long" while "addr" and "len" are uint64_t. Is > that OK? Good catch. No, physical address on Arm32 can be up to 40 bits. > > Specifically, considering a potential arm32 case, shouldn't "s" and "e" > be uint64_t as well? Which means pdev_bar_check.start and end should be > uint64_t? They should be paddr_t which will be 64-bit on both arm32 and arm64. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 08 21:42:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 21:42:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403657.645820 (Exim 4.92) (envelope-from ) id 1oWPHw-0007N1-5M; Thu, 08 Sep 2022 21:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403657.645820; Thu, 08 Sep 2022 21:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPHw-0007Mu-27; Thu, 08 Sep 2022 21:42:20 +0000 Received: by outflank-mailman (input) for mailman id 403657; Thu, 08 Sep 2022 21:42:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPHv-0007Me-5M for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 21:42:19 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c6cde20-2fbf-11ed-a31c-8f8a9ae3403f; Thu, 08 Sep 2022 23:42:18 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id m1so26345503edb.7 for ; Thu, 08 Sep 2022 14:42:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c6cde20-2fbf-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=43LjiARxRil0ORnjLMo8kfDU6oXaHD6Zps3OhjmUekk=; b=AP8uMklTFs8KnCcezXkSTWLw/AAV0qazAwxILW5cMjvDFIW7tBEHp4W7Xh5AToclbm xV9xwQ8xcLFGUaBSzM8IHrvJCmvo5eeN28ILoiupMVCPpWawI84GXeXha8lAM2WEGQIP 83HbY/XHQRm8B4MvqNmH2h1CG9aCpWCzDRjWi4rKoj2RDsFDezRd3QxYH9rqzt0kKHUI swGQ3pijsZNCSm1ZQOtYSivansCguHp3h2vOkkqG9UdCHu7b6ACs6yOV8WIRcBOMZYBG TKG77P1gDgQ6dESNhSavPJLI7qY5b5Jbi7FRTo28d0BkyjP8NG4msGGMbDwHibd8yFQz Kp7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=43LjiARxRil0ORnjLMo8kfDU6oXaHD6Zps3OhjmUekk=; b=YtKAYy6D7O+GT+wLcpbKwEApvltSa84RktjyQ5QvA5ZOseGHbKIYTQ3FMxJJAXLtHG eLiuB9m4zTJvheIJR0oIdVGoGUAIMiL07PwBJ4WqsrqxDjY/vPCoJrADfktvEE3CeEWO 5xhSfKYB9pljdlJJ3MNN6Ek3xr+Fl6rHpDBp13xE5D3GQ4qiQnneoVslMsCo7aO7unXk gA3Ev3VQuLToe3bpMlXIzgcliBD864B+M6zitaYU/fbSxlr6pg5wgP5FcZ1i7b9hoE2X Jzm7TTJIJEraoCQ1lBGjo/6t4zUuqY6Br1f0xw0WoDoK94Uwo8i2NB1adDvS6c6pBKke SlaA== X-Gm-Message-State: ACgBeo3SYBqRWrNq2bjpIeGj+h5rHw85AfAaf5aUoZNY5zz3/wpBmDoU +jNjL0th7P5/RyHvIo9rBv1w33BfNW5/k818DUOdp6T1 X-Google-Smtp-Source: AA6agR6KCZvJabkxJ1gmHWKRAaPFdDL6ePGXqg8Nqc0PTtUUgyGOIh/SywXaz80QGsU23QhbWqEossy0SF85oG69TXQ= X-Received: by 2002:a05:6402:2712:b0:448:e383:1f37 with SMTP id y18-20020a056402271200b00448e3831f37mr8966169edd.375.1662673337264; Thu, 08 Sep 2022 14:42:17 -0700 (PDT) MIME-Version: 1.0 References: <20220908195113.218201-1-jandryuk@gmail.com> <20220908195113.218201-3-jandryuk@gmail.com> In-Reply-To: <20220908195113.218201-3-jandryuk@gmail.com> From: Jason Andryuk Date: Thu, 8 Sep 2022 17:42:06 -0400 Message-ID: Subject: Re: [PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings To: xen-devel Cc: Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Andrew Cooper Content-Type: text/plain; charset="UTF-8" On Thu, Sep 8, 2022 at 3:51 PM Jason Andryuk wrote: > @@ -1783,6 +1784,57 @@ void parse_config_data(const char *config_source, > xlu_cfg_replace_string(config, "acpi_firmware", > &b_info->u.hvm.acpi_firmware, 0); > > + switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) > + { > + case 0: /* Success */ > + b_info->u.hvm.num_smbios = num_smbios; ... > + } > + break; > + } Andrew pointed out this stray curly brace breaks bisection - its match at the beginning of the 'case 0' is introduced in patch 3. Sorry about that. I'm AFK, but will send out an updated patch tomorrow. -Jason > + case ESRCH: /* Option not present */ > + break; > + default: > + fprintf(stderr,"xl: Unable to parse smbios options.\n"); > + exit(EXIT_FAILURE); > + } > + > if (!xlu_cfg_get_string(config, "ms_vm_genid", &buf, 0)) { > if (!strcmp(buf, "generate")) { > e = libxl_ms_vm_genid_generate(ctx, &b_info->u.hvm.ms_vm_genid); > -- > 2.37.3 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 22:02:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 22:02:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403680.645854 (Exim 4.92) (envelope-from ) id 1oWPbK-0002FC-Ur; Thu, 08 Sep 2022 22:02:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403680.645854; Thu, 08 Sep 2022 22:02:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPbK-0002F5-S5; Thu, 08 Sep 2022 22:02:22 +0000 Received: by outflank-mailman (input) for mailman id 403680; Thu, 08 Sep 2022 22:02:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPbJ-0002Et-2q; Thu, 08 Sep 2022 22:02:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPbJ-0001Tp-0B; Thu, 08 Sep 2022 22:02:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPbI-0006QM-E2; Thu, 08 Sep 2022 22:02:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWPbI-0005Nw-Dc; Thu, 08 Sep 2022 22:02:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q+QxhahozgjXxgwrEHH+rmLVe6yCVoCoHSmD72YxChU=; b=Cf7ieiSBuxIjAiHbEpEtWk020J fCVCPPxA7FkE4GJg6j/BISgfGkfUPVLkUBEyAgDjbOFPbrZaTOCm75AduQ4OXe62hmCSCgELq07Gb EH4ikipm/eHwO3kOk9N9fTzWp1FsjZD6qhiJa9OJTibSefpAyTJ/MVIg1oIg3phWKUzQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173063: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=64e302157a87b246473a31fa104377a6d48eb046 X-Osstest-Versions-That: xen=172015009a6acc20357a2698800e13058ba1d3db From: osstest service owner Date: Thu, 08 Sep 2022 22:02:20 +0000 flight 173063 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173063/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173054 build-i386-libvirt 6 libvirt-build fail like 173054 build-arm64-libvirt 6 libvirt-build fail like 173054 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173054 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173054 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173054 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173054 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173054 build-armhf-libvirt 6 libvirt-build fail like 173054 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173054 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173054 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173054 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173054 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 64e302157a87b246473a31fa104377a6d48eb046 baseline version: xen 172015009a6acc20357a2698800e13058ba1d3db Last test of basis 173054 2022-09-08 01:53:16 Z 0 days Testing same since 173063 2022-09-08 11:10:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Juergen Gross Julien Grall Leo Yan Viresh Kumar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 172015009a..64e302157a 64e302157a87b246473a31fa104377a6d48eb046 -> master From xen-devel-bounces@lists.xenproject.org Thu Sep 08 22:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 22:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403689.645865 (Exim 4.92) (envelope-from ) id 1oWPy9-00056q-S8; Thu, 08 Sep 2022 22:25:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403689.645865; Thu, 08 Sep 2022 22:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPy9-00056j-PI; Thu, 08 Sep 2022 22:25:57 +0000 Received: by outflank-mailman (input) for mailman id 403689; Thu, 08 Sep 2022 22:25:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPy7-00056Z-P3; Thu, 08 Sep 2022 22:25:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPy7-0001rd-EY; Thu, 08 Sep 2022 22:25:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWPy6-0007YW-Vd; Thu, 08 Sep 2022 22:25:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWPy6-00070f-V8; Thu, 08 Sep 2022 22:25:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Fe+KBcGjh406C0Ce1ZMGQfDYmsI6aABWGHiWWzAjAko=; b=JMytQnvnUSxfjmJxvH6W0KZekH NUqRcnj8tvQ0g659NB/MD2bPW2Lgo49ExZWrpc4RL9lWZQx9hYH2aesEAN+MMk9ahP7ajQ+a2EpIp o2Qc6bH2TsheEXO9ZX2L0ZtKt/8O7/ZOevh37Ifzho5/OgRt8S60nUWYcft6kt1T0OuE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173065: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0066f1b0e27556381402db3ff31f85d2a2265858 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 08 Sep 2022 22:25:54 +0000 flight 173065 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173065/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-pvops 6 kernel-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0066f1b0e27556381402db3ff31f85d2a2265858 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 35 days Failing since 172152 2022-08-05 04:01:26 Z 34 days 79 attempts Testing same since 173034 2022-09-07 03:00:08 Z 1 days 4 attempts ------------------------------------------------------------ 1702 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175131 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 08 23:29:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 23:29:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403702.645888 (Exim 4.92) (envelope-from ) id 1oWQy0-0004ZW-4M; Thu, 08 Sep 2022 23:29:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403702.645888; Thu, 08 Sep 2022 23:29:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWQy0-0004ZP-1E; Thu, 08 Sep 2022 23:29:52 +0000 Received: by outflank-mailman (input) for mailman id 403702; Thu, 08 Sep 2022 23:29:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWQxy-0004GN-TY for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 23:29:50 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2202033e-2fce-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 01:29:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A9943B8211F; Thu, 8 Sep 2022 23:29:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0A5DC433C1; Thu, 8 Sep 2022 23:29:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2202033e-2fce-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662679788; bh=0iqsbOsCrBEMw5bOAeu+wgLezyZaPXPzY0+1ThDuT84=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=G3wJfr9XT+63WpU21fXcRLH+m2ruMZvMzk5O016BRtWYycx4+uo5hauVZVjAE6M+i 1rJDslgRACbXx2/i7BDbIPNhKc4flGDkJTcT6FQeTKEsQc8eUELlsUigoxsY6Eh25c ApT+Sajpb85X7gzb9D31G/0El6MggbFfOWc2gZTurlxKXVIjeM90ezin38mKuosxhi xSz68RMdH/dXCi0TrJ8lNBBhA1qEDc7vKDFXAw/1bHJYVanhaaYfQ5r6X694BiksXx 3NQQpPZogcTZhnNtdzR0Y43Z5dExq1GoHo2KF6sj2V5aC2F5x2keiXAjminVVzs86U FtpTLVrDB6oOw== Date: Thu, 8 Sep 2022 16:29:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Luca Fancellu , Ayan Kumar Halder Subject: Re: [for-4.17 v2 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages In-Reply-To: <20220908092230.21421-3-michal.orzel@amd.com> Message-ID: References: <20220908092230.21421-1-michal.orzel@amd.com> <20220908092230.21421-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Sep 2022, Michal Orzel wrote: > During the ping test, dom1 tries to assign an ip to eth0 in a loop. > Before setting up the network interface by dom0, this results in > printing the following error message several times: > (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device > > Silence this by redirecting stderr/stdout to /dev/null as we do not > care about the output and we should not pollute the log file. > > Signed-off-by: Michal Orzel > Reviewed-by: Luca Fancellu > Reviewed-by: Ayan Kumar Halder Acked-by: Stefano Stabellini > --- > Changes in v2: > - none > --- > automation/scripts/qemu-smoke-arm64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index c80d9b2aee00..7ac96027760d 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -6,7 +6,7 @@ test_variant=$1 > > passed="passed" > check=" > -until ifconfig eth0 192.168.0.2 && ping -c 10 192.168.0.1; do > +until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do > sleep 30 > done > echo \"${passed}\" > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 23:29:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 23:29:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403701.645877 (Exim 4.92) (envelope-from ) id 1oWQxk-0004Ga-SA; Thu, 08 Sep 2022 23:29:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403701.645877; Thu, 08 Sep 2022 23:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWQxk-0004GT-Ot; Thu, 08 Sep 2022 23:29:36 +0000 Received: by outflank-mailman (input) for mailman id 403701; Thu, 08 Sep 2022 23:29:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWQxj-0004GN-4L for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 23:29:35 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 177d127d-2fce-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 01:29:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8DD37B8211F; Thu, 8 Sep 2022 23:29:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E5B8C433D6; Thu, 8 Sep 2022 23:29:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 177d127d-2fce-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662679770; bh=witO6HDC7GbgouQbK3fwu6qb5Ywe27S1G4e5v2wInhc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hA520OKqdvQuZaPTSKF0kimbKU3n0wOESKnWbx916gc7kdKmWolmPcABz/L5NiAjt upfpCkKs3nsv3hcIget8lOgzQxIGHtXBpp/ZBfst6s2013o2Ja9/OnG0G2kRwkWy+8 Fi8/zT48mRoTOez8HGYpO4Jdk/1uHhxWEjiqtBG6YKp0t6q425ATfJiF9Skqt5qRwQ 6laXqvUWjT2OIdqhLLvYa5quS507xOjyIcJWIfq+K1kxEmz5gUQ0aI/oQ3h3SkZEQ0 RtRdYgiK7MEBfnku1rY5mgsPjeMdAcHxNBu6xwwHTAd03zwV8G/AIMOglsbbZT8pUj 4NiEHGgMkZjTA== Date: Thu, 8 Sep 2022 16:29:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Luca Fancellu , Ayan Kumar Halder Subject: Re: [for-4.17 v2 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19 In-Reply-To: <20220908092230.21421-2-michal.orzel@amd.com> Message-ID: References: <20220908092230.21421-1-michal.orzel@amd.com> <20220908092230.21421-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Sep 2022, Michal Orzel wrote: > After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having > two kernel configurations. This is something not needed and maintaining > a single kernel version is always easier. Modify qemu-alpine-arm64-gcc > to use kernel 5.19 and remove kernel 5.9 from tests-artifacts. > > Signed-off-by: Michal Orzel > Reviewed-by: Luca Fancellu > Reviewed-by: Ayan Kumar Halder Acked-by: Stefano Stabellini > --- > Changes in v2: > - none > --- > automation/gitlab-ci/build.yaml | 11 ------ > automation/gitlab-ci/test.yaml | 2 +- > .../kernel/5.9.9-arm64v8.dockerfile | 34 ------------------- > 3 files changed, 1 insertion(+), 46 deletions(-) > delete mode 100644 automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index d2f75a090c0f..720ce6e07ba0 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -586,17 +586,6 @@ alpine-3.12-arm64-rootfs-export: > tags: > - arm64 > > -kernel-5.9.9-arm64-export: > - extends: .test-jobs-artifact-common > - image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.9.9-arm64v8 > - script: > - - mkdir binaries && cp /Image binaries/Image > - artifacts: > - paths: > - - binaries/Image > - tags: > - - arm64 > - > kernel-5.19-arm64-export: > extends: .test-jobs-artifact-common > image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.19-arm64v8 > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 2eb6c3866e2c..07209820b474 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -34,7 +34,7 @@ qemu-alpine-arm64-gcc: > needs: > - alpine-3.12-gcc-arm64 > - alpine-3.12-arm64-rootfs-export > - - kernel-5.9.9-arm64-export > + - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > artifacts: > paths: > diff --git a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile b/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile > deleted file mode 100644 > index 053d65a3454e..000000000000 > --- a/automation/tests-artifacts/kernel/5.9.9-arm64v8.dockerfile > +++ /dev/null > @@ -1,34 +0,0 @@ > -FROM arm64v8/debian:unstable > -LABEL maintainer.name="The Xen Project" \ > - maintainer.email="xen-devel@lists.xenproject.org" > - > -ENV DEBIAN_FRONTEND=noninteractive > -ENV LINUX_VERSION=5.9.9 > -ENV USER root > - > -RUN mkdir /build > -WORKDIR /build > - > -# build depends > -RUN apt-get update && \ > - apt-get --quiet --yes install \ > - build-essential \ > - libssl-dev \ > - bc \ > - curl \ > - flex \ > - bison \ > - && \ > - \ > - # Build the kernel > - curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \ > - tar xvJf linux-"$LINUX_VERSION".tar.xz && \ > - cd linux-"$LINUX_VERSION" && \ > - make defconfig && \ > - make -j$(nproc) Image.gz && \ > - cp arch/arm64/boot/Image / && \ > - cd /build && \ > - rm -rf linux-"$LINUX_VERSION"* && \ > - apt-get autoremove -y && \ > - apt-get clean && \ > - rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 23:30:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 23:30:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403706.645899 (Exim 4.92) (envelope-from ) id 1oWQyF-0005rr-E9; Thu, 08 Sep 2022 23:30:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403706.645899; Thu, 08 Sep 2022 23:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWQyF-0005rI-9T; Thu, 08 Sep 2022 23:30:07 +0000 Received: by outflank-mailman (input) for mailman id 403706; Thu, 08 Sep 2022 23:30:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWQyD-0004Yv-4d for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 23:30:05 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29e82542-2fce-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 01:30:04 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 959F661E2C; Thu, 8 Sep 2022 23:30:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FC85C433D6; Thu, 8 Sep 2022 23:30:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29e82542-2fce-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662679802; bh=L1YSSix3xXj61NlJxyWdGWcNtiMESTR/GuUUP6tSWU8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pwj1E2sUmHs82nLkK9hZLtj/y/vHsNlzID01d0MH/DAKxCXu9hn+W8rhRK2TAfi+o bsFGOGSsTU7IvhSKGRRudoglpVG/NxkB6qGFqQLLU/7QMgbxOBU0B9x+fvyCGhFx5t OM3BJyAttic3MtNo3AWSSL0ieGU1ThE8igczokoXM9Ot0nbUmYvN0ChYSA0icXZoYn zXD6JLvFVRB2k0mrof2enQHL+5rsL6obOXOJu9oCQD3xBRmaQE/CZBRcAFBWftZk5g mAzYEkk78howHo0UOFvWwsJe3dsPl87XR4fcQfGZWGMEZ4MCVKj6q2AThX63m8jNIq Ai59AgGoGhyUA== Date: Thu, 8 Sep 2022 16:30:00 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [for-4.17 v2 3/3] automation: Add a new job for testing boot time cpupools on arm64 In-Reply-To: <20220908092230.21421-4-michal.orzel@amd.com> Message-ID: References: <20220908092230.21421-1-michal.orzel@amd.com> <20220908092230.21421-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Sep 2022, Michal Orzel wrote: > Add a new test job qemu-smoke-arm64-gcc-boot-cpupools that will execute > script qemu-smoke-arm64.sh to test boot time cpupools feature. > Enable CONFIG_BOOT_TIME_CPUPOOLS for the arm64 build and add a new test > case in qemu-smoke-arm64.sh that if selected will make use of the > ImageBuilder feature to create cpupool with cpu@1, null scheduler and > assign it to domU. Add a check in dom0 xen.start to see if domU is > assigned a Pool-1 with null scheduler. > > Take the opportunity to refactor the qemu-smoke-arm64.sh script as > follows: > - use domU_check to store the test's commands to be run from domU > - use dom0_check to store the test's commands to be run from dom0 > - use fdtput instead of sed to perform dtb modifications > - use more meaningful messages for "passed" variable. This way we can > grep for messages reported either by domU or dom0 and get rid of > assumption that tests can only be run from domU > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - use ImageBuilder feature to create boot-time cpupools > - also check if the scheduler is set up properly > --- > automation/gitlab-ci/test.yaml | 19 ++++++++++++++ > automation/scripts/build | 3 ++- > automation/scripts/qemu-smoke-arm64.sh | 36 +++++++++++++++++++------- > 3 files changed, 48 insertions(+), 10 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 07209820b474..d899b3bdbf7a 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -100,6 +100,25 @@ qemu-smoke-arm64-gcc-staticmem: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-boot-cpupools: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-arm64 > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm32-gcc: > extends: .test-jobs-common > variables: > diff --git a/automation/scripts/build b/automation/scripts/build > index 2b9f2d2b541a..2f15ab3198e6 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -19,7 +19,8 @@ else > echo " > CONFIG_EXPERT=y > CONFIG_UNSUPPORTED=y > -CONFIG_STATIC_MEMORY=y" > xen/.config > +CONFIG_STATIC_MEMORY=y > +CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config > make -j$(nproc) -C xen olddefconfig > else > make -j$(nproc) -C xen defconfig > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index 7ac96027760d..f803835779f4 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -4,20 +4,22 @@ set -ex > > test_variant=$1 > > -passed="passed" > -check=" > +if [ -z "${test_variant}" ]; then > + passed="ping test passed" > + domU_check=" > until ifconfig eth0 192.168.0.2 &> /dev/null && ping -c 10 192.168.0.1; do > sleep 30 > done > echo \"${passed}\" > " > +fi > > if [[ "${test_variant}" == "static-mem" ]]; then > # Memory range that is statically allocated to DOM1 > domu_base="50000000" > domu_size="10000000" > passed="${test_variant} test passed" > - check=" > + domU_check=" > current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) > expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) > if [[ \"\${expected}\" == \"\${current}\" ]]; then > @@ -26,6 +28,16 @@ fi > " > fi > > +if [[ "${test_variant}" == "boot-cpupools" ]]; then > + # Check if domU0 (id=1) is assigned to Pool-1 with null scheduler > + passed="${test_variant} test passed" > + dom0_check=" > +if xl list -c 1 | grep -q Pool-1 && xl cpupool-list Pool-1 | grep -q Pool-1; then > + echo ${passed} > +fi > +" > +fi > + > export DEBIAN_FRONTENT=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends u-boot-qemu \ > @@ -42,11 +54,9 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > -cpu cortex-a57 -machine type=virt \ > -m 1024 -smp 2 -display none \ > -machine dumpdtb=binaries/virt-gicv2.dtb > -# XXX disable pl061 to avoid Linux crash > -dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv2.dts > binaries/virt-gicv2-edited.dts > -dtc -I dts -O dtb binaries/virt-gicv2-edited.dts > binaries/virt-gicv2.dtb > > +# XXX disable pl061 to avoid Linux crash > +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled > > # Busybox > mkdir -p initrd > @@ -66,7 +76,7 @@ echo "#!/bin/sh > mount -t proc proc /proc > mount -t sysfs sysfs /sys > mount -t devtmpfs devtmpfs /dev > -${check} > +${domU_check} > /bin/sh" > initrd/init > chmod +x initrd/init > cd initrd > @@ -98,6 +108,7 @@ ifconfig xenbr0 up > ifconfig xenbr0 192.168.0.1 > > xl network-attach 1 type=vif > +${dom0_check} > " > etc/local.d/xen.start > chmod +x etc/local.d/xen.start > echo "rc_verbose=yes" >> etc/rc.conf > @@ -127,6 +138,13 @@ if [[ "${test_variant}" == "static-mem" ]]; then > echo -e "\nDOMU_STATIC_MEM[0]=\"0x${domu_base} 0x${domu_size}\"" >> binaries/config > fi > > +if [[ "${test_variant}" == "boot-cpupools" ]]; then > + echo ' > +CPUPOOL[0]="cpu@1 null" > +DOMU_CPUPOOL[0]=0 > +NUM_CPUPOOLS=1' >> binaries/config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config > @@ -148,5 +166,5 @@ timeout -k 1 240 \ > -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial > > set -e > -(grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "DOM1: ${passed}" smoke.serial) || exit 1 > +(grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "${passed}" smoke.serial) || exit 1 > exit 0 > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 23:35:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 23:35:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403723.645921 (Exim 4.92) (envelope-from ) id 1oWR34-0006yc-4F; Thu, 08 Sep 2022 23:35:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403723.645921; Thu, 08 Sep 2022 23:35:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWR34-0006yV-1Z; Thu, 08 Sep 2022 23:35:06 +0000 Received: by outflank-mailman (input) for mailman id 403723; Thu, 08 Sep 2022 23:35:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWR32-0006yP-S4 for xen-devel@lists.xenproject.org; Thu, 08 Sep 2022 23:35:04 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd10429a-2fce-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 01:35:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0C30EB822C8; Thu, 8 Sep 2022 23:35:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62FEFC433C1; Thu, 8 Sep 2022 23:35:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd10429a-2fce-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662680101; bh=e+eQtgHjxpTmdLL7dpEky523hZqj2sLSlk9F73e5Agg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lupDRy8cERSlE1kgRyi0pRV+FCafk2TI9st7Gv6CGCpIgA91sbk+sJJ6YZFR5nLW5 Fa7a8TJqCaoQu5SzD8cekvqOqmqZO3dVN9yAP315wndbWwNVYWiukvJj/wpoDjsieb QwXh8MI/AmZ0fS07H5VhD/+Fr4TzKBLMTiJSEKIqC0+PL2c0a2Uhixg41A9hjCDhL2 JXZlrFZfBnUI2ItHj675o3vmeJCbNXPAeDGa/lSY/rIk7icqBlt9/9eYLEGPWb4F3Z 8PZhtYSK8G4ZjVKhr21l1r5yFJzpI6lXIXXVu0tP469XKnZJbKRFCzLzze3OBngeRk /1V7zeTdEGsHg== Date: Thu, 8 Sep 2022 16:34:59 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony Perard , Bertrand Marquis , Henry.Wang@arm.com Subject: Gitlab breakage: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS In-Reply-To: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> Message-ID: References: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Jan, This patch breaks the gitlab-ci pipeline, specifically it breaks the hvmloader build with clang: https://gitlab.com/xen-project/xen/-/pipelines/634274727 https://gitlab.com/xen-project/xen/-/jobs/2996114313 make[7]: Entering directory '/builds/xen-project/xen/tools/firmware/hvmloader' clang -m32 -march=i686 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-local-typedefs -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .hvmloader.o.d -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -DNDEBUG -Werror -fno-pie -no-pie -fno-stack-protector -fno-exceptions -fno-asynchronous-unwind-tables -fcf-protection=none -ffreestanding -msoft-float -nostdinc -I/builds/xen-project/xen/tools/firmware/hvmloader/../../../tools/firmware/include -I/builds/xen-project/xen/tools/firmware/hvmloader/../../../tools/include -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -I../../libacpi -c -o hvmloader.o hvmloader.c clang: error: argument unused during compilation: '-nopie' [-Werror,-Wunused-command-line-argument] Cheers, Stefano On Thu, 25 Aug 2022, Jan Beulich wrote: > I haven't been able to find evidence of "-nopie" ever having been a > supported compiler option. The correct spelling is "-no-pie". > Furthermore like "-pie" this is an option which is solely passed to the > linker. The compiler only recognizes "-fpie" / "-fPIE" / "-fno-pie", and > it doesn't infer these options from "-pie" / "-no-pie". > > Add the compiler recognized form, but for the possible case of the > variable also being used somewhere for linking keep the linker option as > well (with corrected spelling). > > Signed-off-by: Jan Beulich > > --- unstable.orig/Config.mk 2022-04-07 12:23:27.000000000 +0200 > +++ unstable/Config.mk 2022-08-25 08:58:00.044287451 +0200 > @@ -188,7 +188,7 @@ endif > APPEND_LDFLAGS += $(foreach i, $(APPEND_LIB), -L$(i)) > APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) > > -EMBEDDED_EXTRA_CFLAGS := -nopie -fno-stack-protector -fno-stack-protector-all > +EMBEDDED_EXTRA_CFLAGS := -fno-pie -no-pie -fno-stack-protector -fno-stack-protector-all > EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables > > XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles > From xen-devel-bounces@lists.xenproject.org Thu Sep 08 23:39:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 08 Sep 2022 23:39:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403731.645933 (Exim 4.92) (envelope-from ) id 1oWR7e-0007tf-N0; Thu, 08 Sep 2022 23:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403731.645933; Thu, 08 Sep 2022 23:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWR7e-0007tY-K4; Thu, 08 Sep 2022 23:39:50 +0000 Received: by outflank-mailman (input) for mailman id 403731; Thu, 08 Sep 2022 23:39:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWR7d-0007tO-6K; Thu, 08 Sep 2022 23:39:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWR7d-0003Bt-35; Thu, 08 Sep 2022 23:39:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWR7c-0001op-Jy; Thu, 08 Sep 2022 23:39:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWR7c-0008Nx-JO; Thu, 08 Sep 2022 23:39:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j0Vnqj6D4WtHWHPBzU67NvPETrDAIIg78IAfBd/V0Pc=; b=HX7co7ctaEl7VNH0FkN2pg0LOD Po7+XM7KCXciH0Mzv5yJOuQis4homlxSIhqYckDAcMDLUXM2mKpNB76cM/IluzjuYpSm3PDLZTTXG Xo5PLYl/RdS7JhefZxsBq9l5n82Lb/Ro+UB+pbgwcwS5iN9mSDS6nTmFS8FvBYxoZKjE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173072: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=7b8f69d7e10628d473dd225224d8c2122d25a38d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 08 Sep 2022 23:39:48 +0000 flight 173072 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173072/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 7b8f69d7e10628d473dd225224d8c2122d25a38d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 34 days 270 attempts Testing same since 173070 2022-09-08 19:43:32 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2261 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 01:26:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 01:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403747.645949 (Exim 4.92) (envelope-from ) id 1oWSmS-0002rp-0I; Fri, 09 Sep 2022 01:26:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403747.645949; Fri, 09 Sep 2022 01:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWSmR-0002ri-Ta; Fri, 09 Sep 2022 01:26:03 +0000 Received: by outflank-mailman (input) for mailman id 403747; Fri, 09 Sep 2022 01:26:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWSmP-0002rZ-K9 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 01:26:01 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5aac2932-2fde-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 03:25:58 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1662686754262221.97457724687013; Thu, 8 Sep 2022 18:25:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5aac2932-2fde-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; t=1662686755; cv=none; d=zohomail.com; s=zohoarc; b=E8eHhFSNqKSkFwLgj80p2okNpmTz9D62iTuT8eHcO+VyUZsutcjQn5EZnuctb6+RsoJdiQPI7iNnk49Z52uNSBaEiYGYEfUWMwgwp0IG2th9P0dRPGP7zCrM7CSmD0itI/HEBLBN2KH9Aw59rckQe2mv7PjNvKC7WMW0RWB7icU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662686755; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=06Il6Fk/dR1OUrL4o7viMHeSHJE1pbT7SdkOPcjyxO4=; b=AI4N05lGgMDK0hVAtQLCI4X4qQIp/Go/N/E5aBCudVfWOBPh7itKKP3IOS6GeywSWd9F9bi5SkWMYQYwb/F5gmrYbvKBKrqgj7Yi4YQpsDJFbS+/I7fuvTWTQ98cH2pyaigBiZIXqZbCh1Bc/x8T5TNPXZ3OgALHDm1KMyPOHPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662686755; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=06Il6Fk/dR1OUrL4o7viMHeSHJE1pbT7SdkOPcjyxO4=; b=lyFvQ1FNIekCi0Y704J11aYcBcO0BXTs+y7VyJi7cx31ZVuXcfYiEPI9yLa7aDpI y6Xt5mbZXe16ZVEefE37qeKHJmv8UqCbHeeri3oJhgSOzgWy4YDj6UovcpdONUeSAXP i12ShOpDYcy/7UdyHD4RFlf78feRiYNRd8fW3afU= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , jandryuk@gmail.com, Wei Liu , Anthony PERARD Subject: [PATCH v13] xsm/flask: correcting initial sid assignment on context allocation Date: Thu, 8 Sep 2022 21:25:46 -0400 Message-Id: <20220909012546.21807-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The current flow for initial SID assignment is that the function flask_domain_alloc_security() allocates the security context and assigns an initial SID based on the limited state information it can access. Specifically the initial SID is determined by the domid of the domain, where it would assign the label for one of the domains the hypervisor constructed with the exception of initial domain (dom0). In the case of the initial domain and all other domains it would use the unlabeled_t SID. When it came to the SID for the initial domain, its assignment was managed by flask_domain_create() where it would be switched from unlabeled_t to dom0_t. This logic worked under the assumption that the first call to flask_domain_create() would be the hypervisor constructing the initial domain. After which it would be the toolstack constructing the domain, for which it is expected to provide an appropriate SID or else unlabeled_t would be used. The issue is that the assumptions upon which the current flow is built were weak and are invalid for PV shim and dom0less. Under the current flow even though the initial domain for PV shim is not set as privileged, flask would label the domain as dom0_t. For dom0less, the situation is two-fold. First is that every domain after the first domain creation will fail as they will be labeled as unlabeled_t. The second is that if the dom0less configuration does not include a "dom0", the first domain created would be labeled as dom0_t. This commit only seeks to address the situation for PV shim, by including a check for xenboot_t context in flask_domain_alloc_security() to determine if the domain is being constructed at system boot. Then a check for is_privilged and pv_shim is added to differentiate between a "dom0" initial domain and a PV shim initial domain. The logic for flask_domain_create() was altered to allow the incoming SID to override the initial label. This allows a domain builder, whether it is a toolstack, dom0less, or hyperlaunch, to provide the correct label for the domain at construction. The base policy was adjusted to allow the idle domain under the xenboot_t context the ability to construct domains of both types, dom0_t and domu_t. This will enable a hypervisor resident domain builder to construct domains beyond the initial domain, Signed-off-by: Daniel P. Smith --- Split out from series "Adds starting the idle domain privileged", earlier patches from series have been committed. Changes in v13: After considering the points raised by Jason, a valid point that really stuck is that changes to FLASK should not be made to address that dom0less did not include support to work under FLASK. The reality is that both dom0less and hyperlaunch are solutions that by design provide domain definitions to the hypervisor for construction. Therefore, they should handle doing domain construction under FLASK. Thus, the patch was adjusted to address correctly labeling the initial domain under PV shim. Changes in v12: - actually send the changes from v11 Changes in v11: - put back dom0_created variable in flask_domain_create() to ensure the enforcement that dom0_t is a singleton label Changes in v10: - rewrote commit message - fixed typos - reworked logic in flask_domain_create() to be simpler and not result in changing the domain security struct before the access check fails tools/flask/policy/modules/dom0.te | 3 ++ tools/flask/policy/modules/domU.te | 3 ++ xen/xsm/flask/hooks.c | 55 +++++++++++++++++++++++------- 3 files changed, 49 insertions(+), 12 deletions(-) diff --git a/tools/flask/policy/modules/dom0.te b/tools/flask/policy/modules/dom0.te index 0a63ce15b6..f710ff9941 100644 --- a/tools/flask/policy/modules/dom0.te +++ b/tools/flask/policy/modules/dom0.te @@ -75,3 +75,6 @@ admin_device(dom0_t, ioport_t) admin_device(dom0_t, iomem_t) domain_comms(dom0_t, dom0_t) + +# Allow the hypervisor to build domains of type dom0_t +xen_build_domain(dom0_t) diff --git a/tools/flask/policy/modules/domU.te b/tools/flask/policy/modules/domU.te index b77df29d56..3f269018f9 100644 --- a/tools/flask/policy/modules/domU.te +++ b/tools/flask/policy/modules/domU.te @@ -13,6 +13,9 @@ domain_comms(domU_t, domU_t) migrate_domain_out(dom0_t, domU_t) domain_self_comms(domU_t) +# Allow the hypervisor to build domains of type domU_t +xen_build_domain(domU_t) + # Device model for domU_t. You can define distinct types for device models for # domains of other types, or add more make_device_model lines for this type. declare_domain(dm_dom_t) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 8bd56644ef..e7db7fe07a 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -38,6 +38,12 @@ #include #include "private.h" +#ifdef CONFIG_X86 +#include +#else +#define pv_shim false +#endif + static uint32_t domain_sid(const struct domain *dom) { struct domain_security_struct *dsec = dom->ssid; @@ -170,6 +176,9 @@ static int cf_check flask_domain_alloc_security(struct domain *d) if ( !dsec ) return -ENOMEM; + /* Set as unlabeled then change as appropriate. */ + dsec->sid = SECINITSID_UNLABELED; + switch ( d->domain_id ) { case DOMID_IDLE: @@ -182,7 +191,13 @@ static int cf_check flask_domain_alloc_security(struct domain *d) dsec->sid = SECINITSID_DOMIO; break; default: - dsec->sid = SECINITSID_UNLABELED; + if ( domain_sid(current->domain) == SECINITSID_XENBOOT ) + { + if ( d->is_privileged ) + dsec->sid = SECINITSID_DOM0; + else if ( pv_shim ) + dsec->sid = SECINITSID_DOMU; + } } dsec->self_sid = dsec->sid; @@ -550,20 +565,36 @@ static int cf_check flask_domain_create(struct domain *d, uint32_t ssidref) struct domain_security_struct *dsec = d->ssid; static int dom0_created = 0; - if ( is_idle_domain(current->domain) && !dom0_created ) + /* + * If the null label is passed, then use the label from security context + * allocation. NB: if the label from the allocated security context is also + * null, the security server will use unlabeled_t for the domain. + */ + if ( ssidref == 0 ) + ssidref = dsec->sid; + + /* + * First check if the current domain is allowed to create the target domain + * type before making changes to the current state. + */ + rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, DOMAIN__CREATE, NULL); + if ( rc ) + return rc; + + /* + * The dom0_t label is expressed as a singleton label in the base policy. + * This cannot be enforced by the security server, therefore it will be + * enforced here. + */ + if ( ssidref == SECINITSID_DOM0 ) { - dsec->sid = SECINITSID_DOM0; - dom0_created = 1; + if ( !dom0_created ) + dom0_created = 1; + else + return -EINVAL; } - else - { - rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, - DOMAIN__CREATE, NULL); - if ( rc ) - return rc; - dsec->sid = ssidref; - } + dsec->sid = ssidref; dsec->self_sid = dsec->sid; rc = security_transition_sid(dsec->sid, dsec->sid, SECCLASS_DOMAIN, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 02:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 02:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403756.645967 (Exim 4.92) (envelope-from ) id 1oWTTG-0000ui-Hj; Fri, 09 Sep 2022 02:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403756.645967; Fri, 09 Sep 2022 02:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWTTG-0000ua-CX; Fri, 09 Sep 2022 02:10:18 +0000 Received: by outflank-mailman (input) for mailman id 403756; Fri, 09 Sep 2022 02:10:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWTTE-0000uU-Pr for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 02:10:16 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062.outbound.protection.outlook.com [40.107.223.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a0d1198-2fe4-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 04:10:14 +0200 (CEST) Received: from BN8PR04CA0053.namprd04.prod.outlook.com (2603:10b6:408:d4::27) by DM4PR12MB5746.namprd12.prod.outlook.com (2603:10b6:8:5d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Fri, 9 Sep 2022 02:10:11 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:d4:cafe::4f) by BN8PR04CA0053.outlook.office365.com (2603:10b6:408:d4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18 via Frontend Transport; Fri, 9 Sep 2022 02:10:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 02:10:11 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 21:10:10 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 19:10:10 -0700 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 21:10:10 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a0d1198-2fe4-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzlhSPmwp5B/enJjd1aWAXtZF6E5LSOhvAQSMZeCgbxoR4LftdWZb3TkpFknSVVIVseebkgLsA7Pv6I6OdTzz3QMgdIdXs4eCpS6gVU50nbEzUf1rh6A17urN1cgULFPg/F2W09P/qzm0C2+YWJ/YJSXurs1qA0t0JHB+11vEh91fElGOgyOhU3+SPF26YPK6oTBc0ni7m01HWZ0NczznTBltkPVlCyeSu1rnVXbcJO/PB61MFhu7wY+32F5NI3ZXr2L9BTT6p3IAFAe4q37uBPr+tOf6wB85C/H4UMKaTyuUj/SqXu7h+ju2c+6kkfWNq8IVdg+Ds/8l0jW0VKeLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0RUWAM2TQ4oErXw3rVjXjU7ECP332ZKAJjKbAk3f5Q0=; b=FssLPhgzbuMWKspIAw5HDjMHLG+r/hUkXIbxs0k7A0oPIU+haOADL1+pdTYH2whUhpYtwh+zNEukcuofNMIRr2KfX3ADQPUdEeeVv0pIE1y17mVuXZQYSrPuEYV08ilDzdWZ2SV3LK63iY5I6yJNyPOlAtJWqJ+QuOI7x7aiPaqYXdTcwFgGFdsW/yBjoHqnuCBlWJ39cEHsw2bPe2AvRKLlWjf3FJldYkg3oL6LTXRCvrIl8cQwYAlluk0eJPxx+yxfBowRmFg8C/NfyURHPO5QyY1GJmLwOZrE8/f+FmvEx8pynDaBKiMDmads5ONnJVTEoRnNKRQutclNjdRZDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0RUWAM2TQ4oErXw3rVjXjU7ECP332ZKAJjKbAk3f5Q0=; b=K5vUwuEGFXlO1ZFmALNv0pWnm8yyYM3SS/EmK4e/K9agBi1tkoa3VNadcX66VhHiZ5zmr7uyt6HuVP1c268NnajMbOosxOXhAc6N45KnGDqsPGgwkLAUh1Ew1w6gMMnYxEFqlE68cZJ02sJP3qeWuBOMLtNrcKwKAF4Bjip4xLo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Date: Thu, 8 Sep 2022 19:10:10 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: , CC: , Subject: Linux pin_user_pages_fast fails on Xen Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|DM4PR12MB5746:EE_ X-MS-Office365-Filtering-Correlation-Id: 11ffe648-e1b0-4e9f-f7a1-08da92086d15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T2AP0AQPoV/zvufuNvINQyYxnUltT2Dc7Pq+AT54OOHmMf8prlhQW//2vYB13YT+8SMckqPSbn9gTvmYzvRjcv8A0vmqQVe6Fubtcjt3jpQUTmbSRe51rmPzKFRVrz2aNLPXSgP1Kxqw85PjBo798+6WPBILDlpdlR4Rff8O1wu9Pb5NP/RbyY97FZM8NjmC0IrJpEjPSIGffam4FICqNTmsWm8NljXFpzV/h/VXM4ebIslX9J8fLNJ3zEKg2ABNxWPcbfPi6Eav5gcfEFEzaykLWQm5Vl6FX4eGFr0dr9nQvEhfStHJIT0A2RG/t2phLKcVKla8s8T2lPylLvCPgUGEWGVQ5CfBVbH8bZldq5zAWcVR6/J5rEHC/pb5jLVGgZcsSPECoNbpMx4GnU9R/dHm/X4PFG6ZQZpJkrjU7uOQxKqtD8MwbVaU5TLDkajW3VmPXPWntpoF5GwzcbYMu9vk+c1agk1LjL7Ti6CZH2PO9SiN2uBWlKrGPkmPOKIT2EQHIU2hCOMLrkrYwGLXlXpUyaa0GvPJ4I2MZHiyuVMu6ezTtb3ei0ANBqiLJaOWYi/QC6rkGAAk/GCJCH/c7XVVsjXy3MprrS2sHhAVffzQf0E6SRTQkuKwasuH7RSz3xDJTQF2sGvAOVFsfdeVfUt4+4A++3D4h33N/m2CBOTtjxZxHvNtQfSLL9HLydHbq5zJARaCtbWxJnq5428QVlA2hnRxU/bXkt9k/8tHtoHYHf/ybuZFg0EvFtvA0oTtIpi+oHXAh55nd5cYsl0D9m1FkPXfVruWjXmfUT8bM3DSaaCWyiQR9PXDLQZBXGeh X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(7916004)(4636009)(376002)(39860400002)(136003)(396003)(346002)(40470700004)(36840700001)(46966006)(82310400005)(9686003)(41300700001)(26005)(186003)(47076005)(8676002)(40480700001)(5660300002)(83380400001)(4744005)(40460700003)(8936002)(44832011)(336012)(4326008)(36860700001)(33716001)(110136005)(70586007)(478600001)(2906002)(426003)(70206006)(82740400003)(54906003)(86362001)(316002)(356005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 02:10:11.3271 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11ffe648-e1b0-4e9f-f7a1-08da92086d15 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5746 Hi Juergen, A colleague is seeing a failure on x86 in Linux Dom0. The failure is pin_user_pages_fast with addresses that correspond to foreign memory pages: - QEMU maps a domU address using dma_memory_map (xen_map_cache) - QEMU calls an IOCTL to the TEE subsystem with the Virtual Address returned by dma_memory_map - Linux tee_shm_register->pin_user_pages_fast Returns -14 - drivers/tee/tee_shm.c Once upon a time it used to be the case that get_user_pages_fast would fail on Xen because we didn't have a struct page corresponding to foreign memory mappings. But that hasn't been the case for years now. Any other ideas why it would fail? Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Fri Sep 09 02:11:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 02:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403763.645977 (Exim 4.92) (envelope-from ) id 1oWTUA-0001RR-PH; Fri, 09 Sep 2022 02:11:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403763.645977; Fri, 09 Sep 2022 02:11:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWTUA-0001RK-Ma; Fri, 09 Sep 2022 02:11:14 +0000 Received: by outflank-mailman (input) for mailman id 403763; Fri, 09 Sep 2022 02:11:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWTU9-0001Jj-Mr for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 02:11:13 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac8acaf9-2fe4-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 04:11:12 +0200 (CEST) Received: from BN0PR04CA0043.namprd04.prod.outlook.com (2603:10b6:408:e8::18) by PH8PR12MB7373.namprd12.prod.outlook.com (2603:10b6:510:217::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Fri, 9 Sep 2022 02:11:08 +0000 Received: from BN8NAM11FT074.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::ad) by BN0PR04CA0043.outlook.office365.com (2603:10b6:408:e8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Fri, 9 Sep 2022 02:11:08 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT074.mail.protection.outlook.com (10.13.176.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 02:11:08 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 21:11:06 -0500 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 8 Sep 2022 21:11:05 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac8acaf9-2fe4-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHISOrPh2xSOWja/+UnueSoTr09/tOvznd3UX2PkoEJQ/xRgmhE1HX8hNXkpmgE7p6NgCGdMEWm8nlsI74CMfIslx5nWRQT9+JkjPD+6NPHERx8Y6QWLSSvQSr+ujrAyQETvwaWbPIfcFsNHmlIILn1BzUfqRPx7bYdMEL6LLEMwEBJ63hmGvSfr0Ecg1kfNPIvCClfhNx0T29PtlGoySzm7c9AHXHZxk38YVqrxnlPX6kTwGGRkxpP0w69Jn1yqjs74pLyYdiR9v5QVhbcBKHAv3DWhw1qqu3GGk/sTUCC+Gi5Vtzv88/OKTNRzhA3cwusnFqDMq7Exmwv6IyD7WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g6RoDuXfh3zKQAT52pkvRBxPVV82P0YYMDY+d6ouWTY=; b=cr0V4pRmj8Y9as9mBNJRcs1NiHDYEE8GFhzf1PUg6xI3HUvmAukRL12hacifc0nKCnjdxCHS4rZGmQ0Fl1qk+7KvS49wxL4+/lzcFA/c3tvq2BVJ+nb4aW2uZPpjE25A3co351b0p87oqxpB2uhNRAf6ULALaHcKs1ovMx+uMo/Fi225QsG8EVX99vnv4P9XzsM1RBTL9uK56QuCqIE7HBAi2sAUHJrqU1W+w+GnFdm68y/HokA9fg4eId4q1tOKqAqAZpgnP77jEBFjiNGg6+bD6/vhxa2NG/hXfgV5QHGYFEUvDMnG4OBMnJQUv9YXqAUPVCjplXpFUmGmN3immg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g6RoDuXfh3zKQAT52pkvRBxPVV82P0YYMDY+d6ouWTY=; b=KC1g9a1dnQ2we2KznWFmflubajrhDmMx6Yq4viBcuv2lotkRSF9hoXZeoqSx1VbjpYsvfQWNAi/kupkg6TYKcufAXsSUU4U6d0yeZ5RkRmkQc/0AkLwzZP1I3JXBCCSP/zvjL2hOzbzPR6bSFp0nYeBNBs5BsgLk/74ToQ2oHL0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Date: Thu, 8 Sep 2022 19:11:05 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini CC: , , , , , , , Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT074:EE_|PH8PR12MB7373:EE_ X-MS-Office365-Filtering-Correlation-Id: 952dfa46-45c8-42cd-7612-08da92088eed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yo0u0UcINC90Lp5yRF2YBhZEhGxDkrK6RpYSb96v8X3wSmXiN9J88Ilr9iMQigVWJ8j6i2vpkUSyStdRHzsL9To3B36R+/Cb/xWp6feYMtWyAO7Dp+LRiGFHa5g7U1yF1EWZ8mFjTDZH2tNj8ROTNjrpayK+aMILWamo1nNM1bxCHq/fq7+jpcNbOGcAZHhilPDZ7htKXGWpp0uwpVFHUIGC/kKop0CYxzKlgsBr76C65Ypm3+YG2ZnjHC7fpSS3ykKCfBoVO1tdjhombG3VyU90Md5Z8k7p3P5KuPOsaUe8c4jDd7ew4vOPpvztZ7UxzBIjiwWNocb0ATqt/7qr/4u8cuEnNyzuw1KygW7NMDhcOREtyaCJxJGFPlLhPUvwQY+YbsUqIDl9lcpI2WJYuAdnHLXFyM4HOUfKDRMm2v9Uf7+FysTSMitVJvnqjeet6+pV/4z0/D2f+1n1086+CbBRD7srbtqEVdA0lgeM1+SpcFCDWSku+574lARnZHbA+FVotBBwtY4By+/3wAwswdn7RfgWoYE99hxSMRoY6uhlia2cUkY8B1i2NBA0jnnwPg4S1QV4WjSaaOoVj35M24eFPYiR8nNK9bAWVrpOe9BmvygY2z1tUUIZ+fQAspkmP1bI3N8zUYjYhc9lag8vP8+Wzh7+znYsgFohFbawuKR41GTLK2khTQEO1Qr0MP1f9RAmTAInprzTrWclsbN9/66U9x6/pRcqa3ZXkMEd3JG5eiBXHfZWffyOtIsvrGc8Yis/A5z5t9jI2cq9WR5gaigLI8dIYS1z5K3MwQEoVomIuenLOoJy+2Bm9/SZuotN X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(7916004)(4636009)(396003)(39860400002)(376002)(346002)(136003)(40470700004)(46966006)(36840700001)(6200100001)(9686003)(82310400005)(33716001)(26005)(5660300002)(186003)(44832011)(336012)(426003)(81166007)(478600001)(356005)(41300700001)(36860700001)(40460700003)(6862004)(83380400001)(82740400003)(8936002)(316002)(47076005)(54906003)(40480700001)(2906002)(4744005)(70586007)(86362001)(8676002)(4326008)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 02:11:08.1042 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 952dfa46-45c8-42cd-7612-08da92088eed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT074.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7373 Adding more people in CC On Thu, 8 Sep 2022, Stefano Stabellini wrote: > Hi Juergen, > > A colleague is seeing a failure on x86 in Linux Dom0. The failure is > pin_user_pages_fast with addresses that correspond to foreign memory > pages: > > - QEMU maps a domU address using dma_memory_map (xen_map_cache) > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Address > returned by dma_memory_map > - Linux tee_shm_register->pin_user_pages_fast Returns -14 - drivers/tee/tee_shm.c > > Once upon a time it used to be the case that get_user_pages_fast would > fail on Xen because we didn't have a struct page corresponding to > foreign memory mappings. But that hasn't been the case for years now. > > Any other ideas why it would fail? > > Cheers, > > Stefano > From xen-devel-bounces@lists.xenproject.org Fri Sep 09 03:01:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 03:01:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403770.645988 (Exim 4.92) (envelope-from ) id 1oWUGk-0007hH-De; Fri, 09 Sep 2022 03:01:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403770.645988; Fri, 09 Sep 2022 03:01:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUGk-0007h9-Ai; Fri, 09 Sep 2022 03:01:26 +0000 Received: by outflank-mailman (input) for mailman id 403770; Fri, 09 Sep 2022 03:01:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUGi-0007gz-Gk; Fri, 09 Sep 2022 03:01:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUGi-0006LY-DW; Fri, 09 Sep 2022 03:01:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUGh-0005vR-51; Fri, 09 Sep 2022 03:01:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWUGh-0006yv-4W; Fri, 09 Sep 2022 03:01:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KvEybXfJ9+qg4QwfFdoKYDYeYSoQAM82+hq2Pvte/Ao=; b=i3oWndqz2lu7uhTceA0D22Ji1O 0ibYE2G0zveDrBJ18bwP3KMjARXpkyhGOF+ribn+BfRJA+1xZzDKgUDCnUctR+7m+72PGpvsRuxB0 219ydc++Y24R2A0jy76jldQIrH24WYI/FZ06efDjvbOILb86wemT0YaYaZZkkW9p8L9s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173067: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-vhd::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-armhf-armhf-xl-vhd:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:xen-boot:fail:heisenbug linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-5.4:test-amd64-amd64-examine:examine-iommu:fail:heisenbug linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 09 Sep 2022 03:01:23 +0000 flight 173067 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173067/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd broken in 173048 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-pvops 6 kernel-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 5 host-install(5) broken in 173048 pass in 173067 test-amd64-i386-qemuu-rhel6hvm-intel 8 xen-boot fail in 173048 pass in 173067 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173056 pass in 173048 test-amd64-amd64-examine 13 examine-iommu fail in 173056 pass in 173067 test-amd64-amd64-xl-rtds 18 guest-localmigrate fail pass in 173056 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173056 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173056 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 173048 like 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173056 like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail in 173056 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173056 like 172128 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 173056 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 173056 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173056 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173056 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 173056 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173056 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173056 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173056 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173056 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173056 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173056 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173056 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 173056 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173056 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 36 days Failing since 172384 2022-08-11 11:13:58 Z 28 days 61 attempts Testing same since 173008 2022-09-05 15:47:43 Z 3 days 7 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-vhd broken Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 03:17:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 03:17:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403782.646000 (Exim 4.92) (envelope-from ) id 1oWUWM-00016Z-V8; Fri, 09 Sep 2022 03:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403782.646000; Fri, 09 Sep 2022 03:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUWM-00016S-Rw; Fri, 09 Sep 2022 03:17:34 +0000 Received: by outflank-mailman (input) for mailman id 403782; Fri, 09 Sep 2022 03:17:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUWM-00016I-18; Fri, 09 Sep 2022 03:17:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUWL-0006d3-VF; Fri, 09 Sep 2022 03:17:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUWL-000777-JU; Fri, 09 Sep 2022 03:17:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWUWL-0006RG-Il; Fri, 09 Sep 2022 03:17:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g1hPqeBq+Pv9Lp8JehzzsKumQAlrKWg6Ekp34lQzuA8=; b=zCqSqZX3WyRMfXBjjPSy0PnPHj hJTJf9EfbTfxzInmu3Yd4tFiiJP11+IxtI9Mx+ZAh38tUtp+p1twDho5Ix9PKwB8pdvqLw2mpwcAQ UfbHjMtOIBSUMq5+1owwa4m6EMR96uL9VQ6fbzEkUhDuxlwRcLMNiz+n5uXtCAndTsHY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173076: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=7b8f69d7e10628d473dd225224d8c2122d25a38d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 03:17:33 +0000 flight 173076 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173076/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 7b8f69d7e10628d473dd225224d8c2122d25a38d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 35 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 271 attempts Testing same since 173070 2022-09-08 19:43:32 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2261 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 03:26:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 03:26:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403791.646011 (Exim 4.92) (envelope-from ) id 1oWUfN-0002n8-SO; Fri, 09 Sep 2022 03:26:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403791.646011; Fri, 09 Sep 2022 03:26:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUfN-0002n1-Ol; Fri, 09 Sep 2022 03:26:53 +0000 Received: by outflank-mailman (input) for mailman id 403791; Fri, 09 Sep 2022 03:26:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUfN-0002mr-Cp; Fri, 09 Sep 2022 03:26:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUfN-0006p1-8k; Fri, 09 Sep 2022 03:26:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWUfN-0007Xd-12; Fri, 09 Sep 2022 03:26:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWUfM-0006JY-Tt; Fri, 09 Sep 2022 03:26:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aefmOsLBZuYfJdvg5769FMC/FPFtbMi8l7aaBjdRatM=; b=Za7NK1TvXM7cFaZsbpa13m3t7u 8rNHtm+TKj9g0Av42LEPz4K7KJ1qNOxMgszCmK5AKFucSbZxFhndA0DY5RSqkqM/Aw1/vkOyuO3lY fRSFKaGp8RbkqC4NZ+k7edBjNN6vXU2baD9FR81HDDdwiAd7ViwImeR7oe40QXz7atNY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173078: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=36e3f41587788c60813b088b373960b7fb88c021 X-Osstest-Versions-That: xen=6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc From: osstest service owner Date: Fri, 09 Sep 2022 03:26:52 +0000 flight 173078 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173078/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173064 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 36e3f41587788c60813b088b373960b7fb88c021 baseline version: xen 6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc Last test of basis 173064 2022-09-08 12:01:50 Z 0 days Testing same since 173078 2022-09-09 00:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6bc1c1aba0..36e3f41587 36e3f41587788c60813b088b373960b7fb88c021 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Sep 09 05:24:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 05:24:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403803.646031 (Exim 4.92) (envelope-from ) id 1oWWUv-0000qM-8S; Fri, 09 Sep 2022 05:24:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403803.646031; Fri, 09 Sep 2022 05:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWWUv-0000qF-5W; Fri, 09 Sep 2022 05:24:13 +0000 Received: by outflank-mailman (input) for mailman id 403803; Fri, 09 Sep 2022 05:24:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWWUt-0000q9-BN for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 05:24:11 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a086d9fb-2fff-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 07:24:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B0F2153B; Thu, 8 Sep 2022 22:24:13 -0700 (PDT) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CE9673F73D; Thu, 8 Sep 2022 22:24:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a086d9fb-2fff-11ed-a31c-8f8a9ae3403f From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: [PATCH v2] xen/arm, device-tree: Make static-mem use #{address,size}-cells Date: Fri, 9 Sep 2022 05:23:57 +0000 Message-Id: <20220909052357.49349-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In order to keep consistency in the device tree binding, there is no need for static memory allocation feature to define a specific set of address and size cells for "xen,static-mem" property. Therefore, this commit reuses the regular #{address,size}-cells for parsing the device tree "xen,static-mem" property. Update the documentation accordingly. Also, take the chance to remove the unnecessary "#address-cells" and "#size-cells" in the domU1 node of the device tree to only emphasize the related part that the example is showing. Signed-off-by: Henry Wang --- Changes from v1 to v2: - Remove the "----" addition, as it is unnecessary to this patch. - Mention the removal of #address-cells and #size-cells in domU1 node in the commit message. --- docs/misc/arm/device-tree/booting.txt | 11 +++++------ docs/misc/arm/passthrough-noiommu.txt | 7 +++---- xen/arch/arm/bootfdt.c | 5 ----- xen/arch/arm/domain_build.c | 16 ++-------------- 4 files changed, 10 insertions(+), 29 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 5395a1077c..10caf4f1af 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -350,8 +350,8 @@ areas are pre-defined by configuration using physical address ranges. Memory can be statically allocated to a domain using the property "xen,static- mem" defined in the domain configuration. The number of cells for the address -and the size must be defined using respectively the properties -"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". +and the size must be defined respectively by the parent node properties +"#address-cells" and "#size-cells". The property 'memory' is still needed and should match the amount of memory given to the guest. Currently, it either comes from static memory or lets Xen @@ -366,14 +366,13 @@ device-tree: / { chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + ... domU1 { compatible = "xen,domain"; - #address-cells = <0x2>; - #size-cells = <0x2>; cpus = <2>; memory = <0x0 0x80000>; - #xen,static-mem-address-cells = <0x1>; - #xen,static-mem-size-cells = <0x1>; xen,static-mem = <0x30000000 0x20000000>; ... }; diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt index 3e2ef21ad7..69b8de1975 100644 --- a/docs/misc/arm/passthrough-noiommu.txt +++ b/docs/misc/arm/passthrough-noiommu.txt @@ -33,14 +33,13 @@ on static allocation in the device-tree: / { chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + ... domU1 { compatible = "xen,domain"; - #address-cells = <0x2>; - #size-cells = <0x2>; cpus = <2>; memory = <0x0 0x80000>; - #xen,static-mem-address-cells = <0x1>; - #xen,static-mem-size-cells = <0x1>; xen,static-mem = <0x30000000 0x20000000>; direct-map; ... diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 9e1ea60094..59675f086b 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -370,11 +370,6 @@ static int __init process_domain_node(const void *fdt, int node, /* No "xen,static-mem" present. */ return 0; - address_cells = device_tree_get_u32(fdt, node, - "#xen,static-mem-address-cells", 0); - size_cells = device_tree_get_u32(fdt, node, - "#xen,static-mem-size-cells", 0); - return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, size_cells, &bootinfo.reserved_mem, MEMBANK_STATIC_DOMAIN); diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 7412303d20..9040a8c6cb 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -565,21 +565,9 @@ static int __init parse_static_mem_prop(const struct dt_device_node *node, const struct dt_property *prop; prop = dt_find_property(node, "xen,static-mem", NULL); - if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", - addr_cells) ) - { - printk(XENLOG_ERR - "failed to read \"#xen,static-mem-address-cells\".\n"); - return -EINVAL; - } - if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", - size_cells) ) - { - printk(XENLOG_ERR - "failed to read \"#xen,static-mem-size-cells\".\n"); - return -EINVAL; - } + *addr_cells = dt_n_addr_cells(node); + *size_cells = dt_n_size_cells(node); *cell = (const __be32 *)prop->value; *length = prop->length; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 06:10:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 06:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403811.646042 (Exim 4.92) (envelope-from ) id 1oWXD2-0006KH-Nu; Fri, 09 Sep 2022 06:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403811.646042; Fri, 09 Sep 2022 06:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXD2-0006KA-L7; Fri, 09 Sep 2022 06:09:48 +0000 Received: by outflank-mailman (input) for mailman id 403811; Fri, 09 Sep 2022 06:09:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXD1-0006K4-FN for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 06:09:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 006f46a2-3006-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 08:09:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8503.eurprd04.prod.outlook.com (2603:10a6:10:2d2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 06:09:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 06:09:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 006f46a2-3006-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYk63XjdJeDIIS0U49O5pcVWgyiWmnymXF8ARB7cYjvY0TIO+dOWmlki3nHZuXBTLtPRJPUYtoTB2QLBWjXNla3nnFAblWrlw3/aHRGu4BBs3Uklwsqebl7EiiHvJEnt+1sW8dP13YefN97Ut/pwhOPO/PyjskNOiaKB+iaX+KytpqlCf0GPe18uy+LGA+v1ZFKe8TjLuwptyqyF8IL30WNskffb1FZyLlRpKb/WlbBa1Ia43MIwRfOkjZG9/40gqE6MJ2pwjuN0fRiUOmg5kVCgts1MkmGlFDS/VJHJNeQtHgncdE0OkX5MTXsUS7dQwnEz7u8JEQpZ5uizE9J9gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xa/K3lhAZ+NfsogNr4mv4BnStV31r5aF7g5QOPXV0nA=; b=IhJd5hzDo8CFBXY9lI7h0cXchbMjHHiVTudYdqtwZN22jhbo4XsNXAMVyJav9lv0EwzCJjZcchmXno8qGEy8rFwxRjdpt0pGIgg/B9t5O1+4H2cvoX3pkODnczcz/KqZJ2xoLvVrPnHTkOyUoPR/6tiLIp1Spja6aJryOmfLwpP3wWaipex7SEuITKYCa6ozltExFzLFzzp65VDevAPdldf+0PRLVEuR8Dg5TV1CJeGf3OWRdSxdCDsrZz2fpXg43esdHAfBnEU9XxYU/sjNm5VmNe3LgSqBj8w8e4DhwlZoyaTcXfC6V7uWeAJ/h476XFKEo8w1/YbnsC16U8l+Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xa/K3lhAZ+NfsogNr4mv4BnStV31r5aF7g5QOPXV0nA=; b=mINwviyMP8em2f33jGrEo1CuHWf5A7leMyX7r/EEMNlLIz7e/T5GVwgQsnMXsOnB2rlOg5ptl+G5dTGfF71PhaGrqKlPHkdbmJN3WbmM5tRz3sWBCcNApeuRdmLH9m5chIUHvWt6AF1+386dYhq9HGuK89kw4d236J+HIJfe47U7cU0ANWcE1LIli+A2oX/0uThn72zebzjXkhqaTp6OKr8LzvJ/HpoLkG8NyuhsdJts7CXppyj0VgGK++NreNdH1gwxvMQtUbioOgs/ab9KE8pMaCKuw/9nJu9gYdKeCnEE9aEtnOwHtCAjAbnhWDnM3JsH/bEKD9Pwa/2DCq1XPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a768a11-e792-0e8c-f6f6-48494bf51cdc@suse.com> Date: Fri, 9 Sep 2022 08:09:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v13] xsm/flask: correcting initial sid assignment on context allocation Content-Language: en-US To: "Daniel P. Smith" Cc: jandryuk@gmail.com, Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20220909012546.21807-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220909012546.21807-1-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8503:EE_ X-MS-Office365-Filtering-Correlation-Id: 38441a0d-2df2-4b18-5da1-08da9229e365 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3sVFAhNO94jDs4GvdyTYLvhJPAPIr2IUeEhhzNSp8RrUNvI4W/nY76ATdyYgDMpvIHatcRUS25GhaDzpglW9FSR4W66gcZS4sU/wXWjAOBrV/OFeXnZMRBIpL00Iqkb/AWDCdFAGnRLrZwskMXK3PvMVp1+oM99mjkfEjDbUzghugZuf+UBrOhI8x/otrr6lR0OSs5fmrglCo06P5Rppq8H9n9SvMtGOFqu2vSkfbg5+S85G/Xu5zTMvUujl8uWvfxfmdRRwHMnRdTUd54iz+pYPPUumVebW1UR8jE3E6oht5EPNgWSn/X7Yp8vs6hb4Jeaas1YcanDQBkwFj8wmZiSUfRmhZ52EbKqB/uEzYkBn5cbKZGiiKTrSf2vqVfiqwq48f1BsV89TjkumcHIKtyQmsWCa9FE/IVxjewlaL66RWbNpYyfFcmS14lo8GWQWL/faWH3SvnmxsOZp0PCxOxwIhVCdho1VPmGnfFaOFjBF+CE6f3SgjDUa0YfA/Ui5ikSJZ70eqDr8AdOOPiFYAL40bU3hKEQuEWse/ApYJkEdvpL++7nQ7k99/j7cVqOitbGnyl18tswSUp+PowimAxVl2t4gVfhzyN1vrO/nFsreq5HY8OYvQY/C9OQqptezSIr75gjxhvvDWdpkO29uuqJfcQq5dhHiXEUdgHOfmJPh0fD/4EdFKA8qY7wzvYrMh99jEHlUfcbWpoZrZ2R+sbxzyDG4VUlSTEjmesYLH1tEqcqVgXE6VQhKoFodOH/bJcdNRDZ0ulX9d23BfWGsodH3K3bAu0dZBiWI3oDHG24= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(366004)(376002)(396003)(346002)(36756003)(38100700002)(8676002)(4326008)(66946007)(66476007)(66556008)(31696002)(31686004)(86362001)(186003)(2616005)(6512007)(26005)(41300700001)(6506007)(6486002)(53546011)(478600001)(316002)(54906003)(6916009)(4744005)(2906002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekI1Mm9KM2NJdW04ZENOUTBIa0xCTmxSeGphZzVPem9rRGtMT0V1WnlaWEJr?= =?utf-8?B?N2pmWDIrYVRJR2NIeFlIZVdMa0UxMXBtcmw2aS96SHJ3T1VkZC91NW9YTURB?= =?utf-8?B?N0k2SlFRTm01MWZNZXA2MzIvam1SVFM2QWlKZEgzMWtpQnBhUHlkQnI5SkFV?= =?utf-8?B?U3daQzMwM3QyT0RQZGFvUTdxcUU5QnRveUtBVGY3VkVxYjhtTGZ0QlJLU05D?= =?utf-8?B?bVVGMWl0aUkzZXFMbFdGQjBlcVF4VEJ5eTVhRWhoK2RiZ1BXK2k2RW9CdmdG?= =?utf-8?B?bExPRnVGSDJMeWFJL0hQNk1zekNkeTNud1dBOStSQVdwMVY5WWl5aGRlZXNl?= =?utf-8?B?NFFmZlREYXJtTk43Y0VFcno4bDRrUklQVVk3MmNDSXpzZ0dqUEMwSTMxUkx0?= =?utf-8?B?cE5oc3YyOERBN1pSOGdVRUd2TGJHU3FRM1pyTGlvcjUxSDB5SmVGRkRoZ0ZQ?= =?utf-8?B?azdqSGFJUHVMK2JLZ1dmcDNUcm95dW9uV29rK1ZhSE1mQldxeEhOdFB0b2da?= =?utf-8?B?TDNMVTljUXJpeTZWSnpTMVFSSVZwNWR4eGlHdkpEemdqRFRpVXNpekVIVXFW?= =?utf-8?B?U3RMNUpMNkJqSmxRMmVSVHR0cnNzSFJ2N202RTVlT1hBOHZpTkV0eUl6TjMz?= =?utf-8?B?cTE1ai9kMG50Q0Z0RHQ0MCtlVVIrQnNwSFBJM0pvY2V0ejVZYkNDWkVMVHE0?= =?utf-8?B?YzBnNXNQN2ZHbDFWb3pBMTJRNHRHSlUxK2ZSbXV1SGV5Tk9Eck1QbGZBVnU5?= =?utf-8?B?NzdlUUhWb1NUUFd1RVlVZWJuT2ljQkdwWkgybVJCSW9mQ1FBVEZJMlAycjlE?= =?utf-8?B?UzJMOUtHUVNNbktEVTh4eStabUlISVg2NUszS3hrVW5lcEh2bzdNRUFBaXpa?= =?utf-8?B?bklJcE9nTFZ3S2VwV3hRRWlUQ2ZKK3N1Y0dRcUtnV3FxZG9Ic24vOWpaYUcv?= =?utf-8?B?a090ODlCclN3dzZJb3pKOW5QNjB0WVdPdnljZzNEd3M0VGdoSGZDTWdZUWhE?= =?utf-8?B?WVJ4cUVXc0prdnhnNXRHM2wxcjZvdUFBekhRM0xGT0N5R0hqWlA5Q3VQcXUv?= =?utf-8?B?ZHlRcHVoWGN5Szg0SjlLK082cXJVeERHeW9BZFl4SkJzZlgvNmVlRUt4a2d2?= =?utf-8?B?NzlnRENKempEYXhZQkt4dEZkZTdRTjRmVzdDSnRTcThlYXZnY0g4VUVCY2NF?= =?utf-8?B?aW5Oc2VzWjI4eTM0L3cwMU05TjVUdjRQZS9QZkhNUWtiWDVsTWgrbGJpNHl6?= =?utf-8?B?NVQwMTVvcUhwZTV1dW9YTjdkZTNDQU5pV0wrWGt6T052STFycGdOMTVTRENS?= =?utf-8?B?ZkhTazg4WVFOcWVxbkZMODEzbmluTmZpcmUrYVFQQUlzV2lqREJvMEp5NDc0?= =?utf-8?B?ZUl1Tks4UWpiMk5iQmFEQnRrR0ZqOGhIdHN6WmdBSVJ0MW96QVJPOERMbVQv?= =?utf-8?B?bC9kMnk4bEk5d1FFTXZCZDdVZUp4eFVrNXJNZmFxaG85dVpIU2h2VTE1S0ZJ?= =?utf-8?B?dkx3SjcwWU8xTDNtTHpSZW12YUp5R1E4NFFUTW9YdHJkLzNtNlpld0UyL04r?= =?utf-8?B?ak9md28zK21yL0ZEWHFRSHdsb2s4MEVpdFBUYlFJWm9SQkNOdWhiTlh2bzVp?= =?utf-8?B?UDRmNTBKaHplYnZCWHpQZmYvbWNzOG9RdUJ3T1lZUkEvU0JBT1NaaU1RNUk5?= =?utf-8?B?ZVliTTh0WFFOa1BRTXh1TnhPeFovV3hHUjVJVURXZFRkOGFUbWV1WTZ1eVZS?= =?utf-8?B?a25yc25vZTFFL3ZGeWlWRkZlWjRWYlVtd2hxbitUekVlUm9CWisrU0Z6cVgz?= =?utf-8?B?a3JzUktFZlpPL0g1a0dObjlrb3VKSU5FRzRyTDIyem1FeE1Oc0x0QU9kcXgy?= =?utf-8?B?VVAxZlpEdW1RSzB0eFlpdk9CWEthang0UkszUURZYjhpSUhqWjZIajJZV1px?= =?utf-8?B?UytTQTBKK1NaKy9ZazZ6NGFFSUtyd2FEL2NMWm5MMzkyRGJBQzhjNzlBM3M0?= =?utf-8?B?SVVCMURVRStNalFxKzViZFVKQVVHazBUTGMvcUhrNTgrL242NkczYjZXMHR2?= =?utf-8?B?QTJWTWVEMUpQTzNUL0ZTcFBjcW1wOUFIQmpmRVNGdzdNc0xzREhCWk1QV1hP?= =?utf-8?Q?SYsBPvhkXWglteSOv1/fnmfh9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38441a0d-2df2-4b18-5da1-08da9229e365 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 06:09:43.5856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wt+L576B4J/mUu61G4GbcHAn6lZkvTjATCT2tlPxjjWybbV8cjwGdKXH5F21ppsesE1bMKkdMHFEOYRVf/Ggsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8503 On 09.09.2022 03:25, Daniel P. Smith wrote: > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -38,6 +38,12 @@ > #include > #include "private.h" > > +#ifdef CONFIG_X86 > +#include > +#else > +#define pv_shim false > +#endif Hmm, yet another instance of such. We have already several (and dissimilar) instances scattered around, so I guess we really want to centralize this (e.g. by moving things from x86'es pv/shim.h to a non-asm header). Not something you need to do right here, but something for 4.18. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 06:38:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 06:38:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403820.646059 (Exim 4.92) (envelope-from ) id 1oWXeK-0001bk-12; Fri, 09 Sep 2022 06:38:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403820.646059; Fri, 09 Sep 2022 06:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXeJ-0001bd-UD; Fri, 09 Sep 2022 06:37:59 +0000 Received: by outflank-mailman (input) for mailman id 403820; Fri, 09 Sep 2022 06:37:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXeI-0001bX-4B for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 06:37:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efafe3ad-3009-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 08:37:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4290.eurprd04.prod.outlook.com (2603:10a6:208:59::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Fri, 9 Sep 2022 06:37:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 06:37:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efafe3ad-3009-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfex6C6CiA5kCuhi0VGYZzF/yiwYuIIxPzmv1UDnp43ytGVAwHWTb6pSe13lYVwzWTQdUqTTCtjoAZdOm2aWWsb8Ay9Eb59+aAAhLXxMgAwFhYV6EPcx9ata9KMLLJElAiUIM+7QvLriCWu4zZt80ELoqo6hGOoEhKFKJgz52TD8hiKxpU9wTfyWKaOHzWF+WWpOFyH1/bxiKH9k7dJh1M2Dzp57jth9UEQ5DNUG8FKWZtPtH8E/aPFKmbV4nkaicBbYBv/b2+jn+fYWk9t0dCLZK49YtSoNgxOI0OXcTT4HOum8kzj7Mk2FCRtMd1kEksy3CJTP9yCeju6fxMupzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=25JcyLpzCBNQsdPGwv+P11c8g8K4FbBjsdktf1Zfi0o=; b=cFZWMsOIIvqiCZxgNAllMn3dvMr3uAz9DP+Qch0m8WV+H5cxqtxf/uVSCa4/dJYzRFM+/k+FX1Uugvt40k5FQRS6hkIv4LvAIeiAH3+3cBz4RdNys9RU+vNKdvOyb9mGCBTyPQqfyb13NjU6G1LOmasFLk60Tmh9Q+yVfFUz6yAnhh4QBnikKTF+z6VuzIi1RpI9rP8fgAZbVhaXMuSmiFB+Yb4mAA3pLu0inzZ5MW/MRwMmcTC/Iv1MFa07wHWfRbBFc4zi+jvUk1TksNR+cmcjtjJZZxTtNCtjaEt313LWcrA1fPDSRKRXrjvgRCohswD4lZyZnLO6k1Mo0bNg6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=25JcyLpzCBNQsdPGwv+P11c8g8K4FbBjsdktf1Zfi0o=; b=V6cgH0skBuWw1ueUH1sNuUhq5qZXyTQuFoQWyE1Qqk9hO6QUWPmbkI6rPFjsIrFUo7hkw8zrMusxJRgRCzVq5kKD4E9U0Jwywx+XxP80/xnM6LJzfNs2KQgDEnbRykdQdztbXzu0Y+BB6BjzW7O3pn/MdAytH6Zgh10fzQEDYwOHw7Oin5mYFUv1qSzxuis0TeSjFBNeB7WncmiUY7x/g6qpCtLfXUdrOuumcxfKJlS7AIpArfDiO1mesKleY7dbq0wunkMPgyWC4DNys4oQIpW5EtmjP7O7alYIBU49d5sBPS18BzKQwmMU5p9aLengRNssm3NmhckrBvz7Y9iwXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 08:37:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Gitlab breakage: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard , Bertrand Marquis , Henry.Wang@arm.com References: <68173fe3-b3dc-224b-c30f-719efa48fcdf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0174.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB4290:EE_ X-MS-Office365-Filtering-Correlation-Id: 63a9a79b-e879-454f-595c-08da922dcac3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WzQR00LkrhyieUbLyt3aMijsYwCIMqYLfA2v9zPtMpECtD8sCBJtROaHjwJyNwlFSrP6SN8BoOLqt3Bcv8/HHVnMzKBWBMizCHU5PRvUTdha+ze6P14UdU6gBhPTNZc2tUkZTseHgFhb9muP4aAm+OCJyZFV8l3F/XAxfJzWtdfnNxUe5lMrscEDzVrQT5mdF+H+PmXZ8iVjt/xzdY4Y6nOQCo/CP6FZ9XoOciA/464RvAD/fMQPmch+geIP85iT97GsKy+vxKUpVNIHxX3K4dGwlhFzI2Htz4DWrJUR+jV6H9NA1lu00g3WkWgHX1407rJtnRqqLGLFdj38DnfbSmYErV4rvVT6stU7dRVCdWej7jpgLm6SX95leHKJhyTDEfoJeXAj4FDjUUlPu7GTC7bNDzidQrJXiQKtdX/yk/TBXfbzvrnF/auOIDSOd7+x1m/flNom6w86CxEV/TRztnfvayQuXLNPfTZkKpAF9Rk3Ikn75EdiefV/5/0zEZoxReUzzJuQ0dgzjOHtiWxqIpPBfRj8XeSgnpp6/I+9rNvG6JbozMbQw99aYbgXMCSWDgLKDM3JeEqbB30EIzO1CRPUp+IpvDkpNwyUZGWAikPMC5P5MInZHfTYhLiomh9j3LmxH/zoAOYyJvw94A4eOEx2yka0M0oI3Ydh02Px93gIsXxkGTI/Flwzw72XEhDltwcCyMjoq4HuC8lYPmO8zZQqv0cAtS6xW6uSGCwzcgtHPlau4uU005k1Yi/CwrO5+bXxorZ/7ocdnA10mZNXKW8/YOkK616w+7nDp99s3PggQyX/VnrFO5T1r/NBiAGl9q4/qRNDehIy2bTlB0ixIPvVjWU1sJLPNb3wOLFzz1E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(136003)(39860400002)(396003)(2906002)(316002)(6916009)(66946007)(4326008)(54906003)(66556008)(66476007)(8676002)(38100700002)(2616005)(5660300002)(8936002)(7416002)(36756003)(83380400001)(6512007)(41300700001)(26005)(53546011)(6506007)(186003)(966005)(478600001)(6486002)(31696002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmFLT1NQRm01Z04ranJ1U3ZwdVdxYzVPTjFQek44a3c3YUxkV3ZLSHJYV1Fv?= =?utf-8?B?UDgxbExITUxKZkVGVi9JSDNwQ1NVVmxDWW1ZQlJaZFlla0doTUVyWG1lVDE4?= =?utf-8?B?UHdZakNFSnlzMGRNV0VlT3JsMnNWTHJndSttUkdldjNrQnN3VHJna0Z1NGtY?= =?utf-8?B?VjIrSk1jOFpzNUdwZE8rQ2FyZ1A5YnBCZTRuMDJmU0VEenRCYXlsNjB1UlJW?= =?utf-8?B?NTR4blRJclBJcDRWZ2Z4Tm0xNVN3SDNFTyt5WGxoWU90aitjY09SUGt4L3JJ?= =?utf-8?B?Z2VMY3hhbUI2eDh5VWsvT09hSUJFVU1LUmJlSjkrc3VQbGxmWkF3MzlKcGtx?= =?utf-8?B?NW9RTGp6N0V1T2d1djJJOGd2cmFsc0JGRUlMVTRBTUc1SjI1VjRtUlFhRlVS?= =?utf-8?B?MEtLc0ZIVTdzVk1pUTh5N0xsRkJjL1hUTWs3b2Z5d0FTby9aeG14d3BhOW9q?= =?utf-8?B?UWk0UmRWT2Z0c1ozTVByNmZvRWVpM0kxUjIycW1zUGhkcDNoVXFXSGREL21z?= =?utf-8?B?Y3YxMVZVbXdoazI4eGJQRmh4bVNIU1ExK1dXWnlrWHpGRXhXd0U5MlNaVmtJ?= =?utf-8?B?MkdRUmRUZE96eVdXVi93TEJyOUx0ajVPcFNYSFllRDZ0eFRtZ1kwamFNaXpp?= =?utf-8?B?ZFlwcE5BR0p5SmNXSlJKNitpNm9wcCs0eHJLcytvVlc4SVJxdUVoeHNramVS?= =?utf-8?B?RG41MXNia044YnVGVnAzMVBCRjF6SHA0ejlKdkp3Y20ycmtCZVlsVGkyTUVm?= =?utf-8?B?RWl1cnhwcU5JYkpSUktOcENjU2xtY2hsR2dvRHZDYUZOM2NQZEZYbkFMc052?= =?utf-8?B?SmN6dWpiMlU1U0gyQjRhanVLVVd0Z2p0cDFYZlFlZHR0Ulc5bSsrRXduN3NG?= =?utf-8?B?M3MvYjVIN2FiNlowZlF4NTk2K0N4Qm9IUHg0TTlGTlUzRVMrRFllWVI1cTVt?= =?utf-8?B?ZWF1dXUyRnNBVGN2VzMzQUYraWFWL2ZBTWdYQlNqUHpna0hKdm1tbmRYVzNq?= =?utf-8?B?SWptblpCdHU5dnBodkNrcmlDVGhydUV3bXM5b3UzMlhwMzlSSXBNQjJoQjBG?= =?utf-8?B?eTZQc0EyeVJieVZRRmlOSGRUbTROVm5wRUJVc2p5VTNvd1FkNGxkRk9RYVkw?= =?utf-8?B?QVhtK1RLK1VTRlp4U0pITFFqc2Q5dHVhRjZ2QmU4N3ViejFhdVdrOWwySVd1?= =?utf-8?B?bDF6Ry9tcFdDL3ViWC8vSjRwRzhZUHVmZU9obTFWcGYvaVNUMGd5QldQbmdm?= =?utf-8?B?MjFCSEZ1VHZDTks2UmNYR3N2MGpqemZpZ0ZIV2lVUzdVN2RnNWRPbUwzVFVF?= =?utf-8?B?NHkyTnZTbDRUaGZkQnBOT2FQdVNoMVpla2pIb012U1RWOGJmdzAxb0Z0VWZu?= =?utf-8?B?WHVJcE5FZDJ4cWZrN2ZlODBXYjZDVkhrNXdrS0E5TmZXSWRsQW5ORGNKbmYz?= =?utf-8?B?UnUzYzFzSTFMNDNlSHZUNW82bDJQREVpNHd0bnZ2WGxjRmc3cW44STFMU2hZ?= =?utf-8?B?RXBqYzIwM1hTM3k2NW9aZmRENUMvMm9MOGF5NUROYm5kcXFIbzg2MFpaWURz?= =?utf-8?B?QjY4R1JTcUtJaTdZWmFHdzV0aXR5YXFMMzVEUUxtTzdML1JKZXorZUZKQzVv?= =?utf-8?B?NEFvMTZzSGNMLzd6UmYwRHMrOENnNTRuQkJFU0RnNGY3dkRCaXlFZmYzd2k2?= =?utf-8?B?M3RoTWxYRVF4R0p0eFFTeUlGS3JzQXRTWmUyckZwQ2ZIWVZRV01EdU1YRk1W?= =?utf-8?B?Si9SalQ2RXRRZWptREVzNlprZDYzd3JsUEZ2QjZ6bjJlb3ZRNDcyU2Zia0pG?= =?utf-8?B?V3V5T0h3a0pkWWUvY0QzZzNmY0FmSS9MZEd5VVBOdGMzK1RLbGxEY0JOZmVQ?= =?utf-8?B?SXgySWtQZmFCZDFuWEx2cWZHOVk1d3RFVHZvZWlLVlRScFpuZ1dUd0JKRklF?= =?utf-8?B?dlNZcVpOUTBqUHYrZkgxSmhDZU1Sblltb3ZYWUpvNE5rMTdIU0J4ZU9ERjEr?= =?utf-8?B?THVTdUZ3OEhCMmlMeWs5RDIybnpzWW1yaWVtMnRyR1FvL2dqc0lGUmRHdGhv?= =?utf-8?B?d2tjRzVlZjRocHpHOVkxUWppMjBYZUVYMDRNd3RhaWozeUxmVGhEOE5UMS8r?= =?utf-8?Q?bRF8yHk9Ka9pc4lXfbFK308AQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63a9a79b-e879-454f-595c-08da922dcac3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 06:37:40.4329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EfLZHxkIshczw95JjoqAQVOWrby89j4xftzPYxOEWN5v4Qfc6E6GHNpwRovIuIHCq34Qhlf8j9KWi1c/KfCn9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4290 On 09.09.2022 01:34, Stefano Stabellini wrote: > This patch breaks the gitlab-ci pipeline, specifically it breaks the > hvmloader build with clang: > > > https://gitlab.com/xen-project/xen/-/pipelines/634274727 > https://gitlab.com/xen-project/xen/-/jobs/2996114313 > > make[7]: Entering directory '/builds/xen-project/xen/tools/firmware/hvmloader' > clang -m32 -march=i686 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-local-typedefs -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .hvmloader.o.d -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -DNDEBUG -Werror -fno-pie -no-pie -fno-stack-protector -fno-exceptions -fno-asynchronous-unwind-tables -fcf-protection=none -ffreestanding -msoft-float -nostdinc -I/builds/xen-project/xen/tools/firmware/hvmloader/../../../tools/firmware/include -I/builds/xen-project/xen/tools/firmware/hvmloader/../../../tools/include -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -I../../libacpi -c -o hvmloader.o hvmloader.c > clang: error: argument unused during compilation: '-nopie' [-Werror,-Wunused-command-line-argument] First of all I'm puzzled by the error message: Now that we don't (try to) use -nopie anymore, it complains about this option? We're clearly passing -no-pie now as the command line shows. But then - yes, I was actually expecting a similar diagnostic from gcc, and I was surprised that there was none. Yet I have to admit I should have tried a clang build of the hypervisor, where the issue also surfaces. What's important though here - it's not really clear to me what the best course of action is: We could filter out -no-pie everywhere that CFLAGS has EMBEDDED_EXTRA_CFLAGS folded in, but isn't used for linking, but that's odd to have in multiple places. We could also simply drop -no-pie on the assumption that it's LDFLAGS which is supposed to be used for linking, not CFLAGS. But that would be wrong for cases where compilation and linking is done all in one go. Looks like we do such only with HOSTCC / HOSTCFLAGS right now, but relying on this appears fragile. I'll see if using the former approach promises to address the issue, but I'll be happy to take suggestions towards better ways of dealing with this. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 06:41:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 06:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403830.646070 (Exim 4.92) (envelope-from ) id 1oWXi5-0003KM-Lh; Fri, 09 Sep 2022 06:41:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403830.646070; Fri, 09 Sep 2022 06:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXi5-0003KF-J5; Fri, 09 Sep 2022 06:41:53 +0000 Received: by outflank-mailman (input) for mailman id 403830; Fri, 09 Sep 2022 06:41:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXi4-0003K7-E7 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 06:41:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7bd36dab-300a-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 08:41:51 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 480FF1F8C6; Fri, 9 Sep 2022 06:41:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 031A313AE9; Fri, 9 Sep 2022 06:41:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2noYOS3gGmOaHwAAMHmgww (envelope-from ); Fri, 09 Sep 2022 06:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7bd36dab-300a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662705710; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CH0N6o+0UbE3T1NFfhiqsKP6AKDsT9Yxig6MrvuJxdU=; b=G+sAoFJ0khUWyGTqdvK/hiOG+jINDcTjMchzo+kh40ttXTD/omm9DlHGW7M+OSmbjogYqj X63AR/impT6x7Xv/UjwCkBz5OJYvPC9y3brn4LbCzpQJY/HmzJQJsjOjzPq65dDrggTIaA JZ12EMQ1Un9nZ7AwSCa1AOeaxa3LOTw= Message-ID: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> Date: Fri, 9 Sep 2022 08:41:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Stefano Stabellini Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, JESHWANTHKUMAR.NK@amd.com, Devaraj.Rangasamy@amd.com, Mythri.Pandeshwarakrishna@amd.com, SivaSangeetha.SK@amd.com, Rijo-john.Thomas@amd.com References: From: Juergen Gross Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JvzOd2CWJooH4rmPI8hB1ugt" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JvzOd2CWJooH4rmPI8hB1ugt Content-Type: multipart/mixed; boundary="------------i5e5YIf7XsUp8Ihz4lDxNcwJ"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, JESHWANTHKUMAR.NK@amd.com, Devaraj.Rangasamy@amd.com, Mythri.Pandeshwarakrishna@amd.com, SivaSangeetha.SK@amd.com, Rijo-john.Thomas@amd.com Message-ID: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> Subject: Re: Linux pin_user_pages_fast fails on Xen References: In-Reply-To: --------------i5e5YIf7XsUp8Ihz4lDxNcwJ Content-Type: multipart/mixed; boundary="------------nlFP6Bm2rRPYGqvkD3i4GNpH" --------------nlFP6Bm2rRPYGqvkD3i4GNpH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDkuMjIgMDQ6MTEsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gQWRkaW5n IG1vcmUgcGVvcGxlIGluIENDDQo+IA0KPiBPbiBUaHUsIDggU2VwIDIwMjIsIFN0ZWZhbm8g U3RhYmVsbGluaSB3cm90ZToNCj4+IEhpIEp1ZXJnZW4sDQo+Pg0KPj4gQSBjb2xsZWFndWUg aXMgc2VlaW5nIGEgZmFpbHVyZSBvbiB4ODYgaW4gTGludXggRG9tMC4gVGhlIGZhaWx1cmUg aXMNCj4+IHBpbl91c2VyX3BhZ2VzX2Zhc3Qgd2l0aCBhZGRyZXNzZXMgdGhhdCBjb3JyZXNw b25kIHRvIGZvcmVpZ24gbWVtb3J5DQo+PiBwYWdlczoNCj4+DQo+PiAtIFFFTVUgbWFwcyBh IGRvbVUgYWRkcmVzcyB1c2luZyBkbWFfbWVtb3J5X21hcCAoeGVuX21hcF9jYWNoZSkNCj4+ IC0gUUVNVSBjYWxscyBhbiBJT0NUTCB0byB0aGUgVEVFIHN1YnN5c3RlbSB3aXRoIHRoZSBW aXJ0dWFsIEFkZHJlc3MNCj4+ICAgIHJldHVybmVkIGJ5IGRtYV9tZW1vcnlfbWFwDQo+PiAt IExpbnV4IHRlZV9zaG1fcmVnaXN0ZXItPnBpbl91c2VyX3BhZ2VzX2Zhc3QgUmV0dXJucyAt MTQgLSBkcml2ZXJzL3RlZS90ZWVfc2htLmMNCj4+DQo+PiBPbmNlIHVwb24gYSB0aW1lIGl0 IHVzZWQgdG8gYmUgdGhlIGNhc2UgdGhhdCBnZXRfdXNlcl9wYWdlc19mYXN0IHdvdWxkDQo+ PiBmYWlsIG9uIFhlbiBiZWNhdXNlIHdlIGRpZG4ndCBoYXZlIGEgc3RydWN0IHBhZ2UgY29y cmVzcG9uZGluZyB0bw0KPj4gZm9yZWlnbiBtZW1vcnkgbWFwcGluZ3MuIEJ1dCB0aGF0IGhh c24ndCBiZWVuIHRoZSBjYXNlIGZvciB5ZWFycyBub3cuDQo+Pg0KPj4gQW55IG90aGVyIGlk ZWFzIHdoeSBpdCB3b3VsZCBmYWlsPw0KDQpJIHRoaW5rIHdlIGNhbiBleHBlY3QgdGhhdCBh Y2Nlc3Nfb2soKSBpc24ndCBmYWlsaW5nLg0KDQpJIGFzc3VtZSB0aGUgbWFwcGluZyB3YXMg ZG9uZSBhbGxvd2luZyB3cml0ZXMgKHNvcnJ5IGZvciBwYXJhbm9pYSBtb2RlKT8NCg0KT3Ro ZXIgdGhhbiB0aGF0IEknbSBub3QgaGF2aW5nIGVub3VnaCBtZW1vcnkgbWFuYWdlbWVudCBz a2lsbHMuIEl0IG1pZ2h0IGJlDQpyZWxhdGVkIHRvIG1tYXAoKS1lZCBmb3JlaWduIHBhZ2Vz IGhhdmluZyBfUEFHRV9TUEVDSUFMIHNldCwgdGhvdWdoLg0KDQoNCkp1ZXJnZW4NCg== --------------nlFP6Bm2rRPYGqvkD3i4GNpH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------nlFP6Bm2rRPYGqvkD3i4GNpH-- --------------i5e5YIf7XsUp8Ihz4lDxNcwJ-- --------------JvzOd2CWJooH4rmPI8hB1ugt Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMa4C0FAwAAAAAACgkQsN6d1ii/Ey/s 3QgAgGa/NWgwIcUFlBfPI7LkIhR4G88bobIulAj6r5wlsDH92Q6xnViYGI4FpOMu+0KdApivsVZT 0K+Hp8xyKzhB7p99dHe6yq+lMFCAIxXTc2+SYPscMpkOJ/ZQ0UZuRIG848Q2kJXNmyV+5yu+qJUT QFF11BJMffl78WQxh/miFiCiAxl7MMQ7FEezE2AXoHfyteiN20p2pQTJU6o2F1Kz2/9XS9WWh7pM wjIPjYRtelfCiO+LY/0yagMaDislfc9J21/IPniIdVoOspQsTYYKKIloM55cm7SehH1RcKM6SEmz o/xG2cK/VnU2srZgHuNMIECOO1X0ohzLlP9pLUMk5Q== =1yZn -----END PGP SIGNATURE----- --------------JvzOd2CWJooH4rmPI8hB1ugt-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 06:43:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 06:43:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403838.646081 (Exim 4.92) (envelope-from ) id 1oWXjd-0003v0-12; Fri, 09 Sep 2022 06:43:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403838.646081; Fri, 09 Sep 2022 06:43:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXjc-0003ut-UV; Fri, 09 Sep 2022 06:43:28 +0000 Received: by outflank-mailman (input) for mailman id 403838; Fri, 09 Sep 2022 06:43:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXjb-0003tE-5t for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 06:43:27 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2084.outbound.protection.outlook.com [40.107.100.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b39cc808-300a-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 08:43:25 +0200 (CEST) Received: from MW4PR03CA0323.namprd03.prod.outlook.com (2603:10b6:303:dd::28) by CH0PR12MB5314.namprd12.prod.outlook.com (2603:10b6:610:d5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 06:43:22 +0000 Received: from CO1NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dd:cafe::52) by MW4PR03CA0323.outlook.office365.com (2603:10b6:303:dd::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Fri, 9 Sep 2022 06:43:22 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT096.mail.protection.outlook.com (10.13.175.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 06:43:21 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 9 Sep 2022 01:43:21 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 23:43:21 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 9 Sep 2022 01:43:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b39cc808-300a-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fkl3QqANYS6rCL2mNUQaJOfxd3eA5fIwhnqkuT8Irpf3fQL4YEyziN17xFIn7rCW+fRYQ1LoL8HpORwgAAX2S7mKOg7BqwY68s8izhpxQ1VWAxmkDx4pN80jTiHfIFaGTe2aEHWSFJQSBEgKoL3xGPR1Uy07CUdcJYv/14nwHyr1LL/4DcxDyNKIQ3IT6Sru19ZWXFEKvHSJNWSWfxyut5wa6WPHiqkDR+GGp2kahRLlEF8shFjelKEK9YahACUHma4JGedXZqA3RLcK3DHlQWezDoDw7PBqGITBr22iPLaWfqVMcUVnTjlFXH1TVXxD9qgnS1r2F0wVGk3KIjC1bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TWvUx4KNJtyTqVW7e902eyuKfgRjT8Neb8MeLZDpSvY=; b=MbYXsRXjboOV60rUzrlCci/Ul+UQp2NImoMRJgRUZnkpQo94fDIWJRppIL6ifWV6DK5oC8uBNKqRlS0CcF4IHpxjfX/qzDqOf4Ixb+JAPEaH8nrMt8N1KsHXpNV8AEHFnnTxmmCsdrrQ8cXYzfTVdVacYNtSCc8LYRVAECS1mSBnFGc37P9xSzUjnkU/ZCSTVDXT0SHmD9jJtz7Pi0f4GDO8JqxLqXSNaaTsUu8iKAsc3BsIlH6NQ3TQ0lnL5AnAwNKpm4f2oL6OTRh2Ad4zwXMUg9kB4M4U+fVKuTDT+2EMm7ztfisE5AlHzcB0N54z5jhIWozX7VSqVWD+B/QopA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TWvUx4KNJtyTqVW7e902eyuKfgRjT8Neb8MeLZDpSvY=; b=npO/JS9l9pynZEm6zQvBSF+l+vdcZ9eD+IjgXex5YmFB1bOGipiXZa2+TfR6b8kQ8uWMZCZbA6UQbUISQtRRtoIn6in0H3bM+Id6dFGNVQjU4t8xHFwYjPhuEhuOcgGjpbVJeJFXcMCG9aSw1L0Es8Y3wYtnu0swW07YbFhEvKo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <133c3dc6-03a7-e6bb-83e3-d73ee798aa68@amd.com> Date: Fri, 9 Sep 2022 08:43:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2] xen/arm, device-tree: Make static-mem use #{address,size}-cells To: Henry Wang , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk References: <20220909052357.49349-1-Henry.Wang@arm.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20220909052357.49349-1-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT096:EE_|CH0PR12MB5314:EE_ X-MS-Office365-Filtering-Correlation-Id: 363e6aa8-e4b0-4bb2-5a16-08da922e969e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Diiz0FNUjoXRPSxnb8POakL3/GfIjgzADznFQ3LFX7Oi/rMJ/6TXu3S9O8XP7NGZQTqsg7gPtKdhouIMZ3lRPUvK1+ZsIqDIQ9Ma5ZghgoyIPnULPFOexknNz7CHA5akt1EjFPyknVRa2GA5RwW7ZAYLqOnDOgFD2wYx7gvuSXt7UeXLcHjocP/6cLS14enuJXBcPDa//GzQ1OHz4zXr8t1+vSnlLScQnzLX7/LdV4tCezsypw+3BJYYChN38fDnxuGTTudB113Iqsrn8Iid98fcU9MX42soJfFMKRSWfLx0Ag0e4cKcQK55XmslXU70R6tXfqVejiCifWvRQdFH8yAiZoU90eUKjxmvm4Lnku7XMbs64TKzOMs/a0WWv8jnuvMNBrFT0fI0DECoDun9x8dvYLZWyNa5BZLTLFWlHFwwM8j31OJQHesfOBT3L5QC/48/1rNwV7xt/sRtI5iAHGuUGkVP6lu16DDsBQH8fR5bGhbtf1kGDPi+dQoC7PRjqgmJ9V4YHT1AqzVfrtlJnyTskDL4bqBes/cK2cbod/G+yHCngjVrwGF5WGX45dh50osjwFCTL00TorWZTCr2noNmJ+OLPZk8YB+I+Y3UvSUI5uc1z3tsHappKqoMVMgRuxdDkv5i3Kfv5ZtizCGHfto/DH5Ekv8tuj8yyisePSKzRClQMd2GFhNJK7xlR7hnSH9hKaurRFyVxEwotrp605QJdVD4/bGl7wVxKQV2Yjfxk4jJmG3R9/Sna2ruhUuEDsgHpBZ7gmnB52Ygu7GiRsNDhRLClNfakzA3oxPOGuaRKY3ziSiuDk8k+49SfIhs2lRyfL9X+LciTshyQTIZOg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(346002)(396003)(40470700004)(36840700001)(46966006)(36860700001)(4326008)(47076005)(426003)(4744005)(86362001)(8676002)(53546011)(31696002)(70586007)(70206006)(82310400005)(478600001)(186003)(8936002)(2616005)(44832011)(336012)(5660300002)(31686004)(356005)(16576012)(2906002)(82740400003)(41300700001)(40460700003)(110136005)(36756003)(316002)(83380400001)(26005)(54906003)(40480700001)(81166007)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 06:43:21.7582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 363e6aa8-e4b0-4bb2-5a16-08da922e969e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5314 On 09/09/2022 07:23, Henry Wang wrote: > > In order to keep consistency in the device tree binding, there is > no need for static memory allocation feature to define a specific > set of address and size cells for "xen,static-mem" property. > > Therefore, this commit reuses the regular #{address,size}-cells > for parsing the device tree "xen,static-mem" property. Update > the documentation accordingly. > > Also, take the chance to remove the unnecessary "#address-cells" > and "#size-cells" in the domU1 node of the device tree to only > emphasize the related part that the example is showing. > > Signed-off-by: Henry Wang Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 09 06:56:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 06:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403844.646092 (Exim 4.92) (envelope-from ) id 1oWXvk-0005em-4r; Fri, 09 Sep 2022 06:56:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403844.646092; Fri, 09 Sep 2022 06:56:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXvk-0005ef-1A; Fri, 09 Sep 2022 06:56:00 +0000 Received: by outflank-mailman (input) for mailman id 403844; Fri, 09 Sep 2022 06:55:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXvi-0005eV-VB; Fri, 09 Sep 2022 06:55:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXvi-0002bc-NM; Fri, 09 Sep 2022 06:55:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWXvi-0006SB-4l; Fri, 09 Sep 2022 06:55:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWXvi-00020P-4J; Fri, 09 Sep 2022 06:55:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2A+k2LQ8t+41U5RA1jwsE66czva2Ciu7r2i21/kNv9w=; b=ig48TTe/bRmF65c/F5/+BeCQWT JnfIUPJYIr4izE8I8IcWs4G6DKDKJLBPdV4qAL5NiyqpK/Zs/rR+gYXYt87UsCEpQ+lLRXAEhQBG/ xopzAFWFsGwsPpM98xWGGP3bfF1ovbnlEriucAAh3BlE7CFZJFs/WobI8VLdexxSt4eQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173081: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 06:55:58 +0000 flight 173081 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173081/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 272 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 07:08:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 07:08:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403853.646103 (Exim 4.92) (envelope-from ) id 1oWY7W-0007W5-7p; Fri, 09 Sep 2022 07:08:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403853.646103; Fri, 09 Sep 2022 07:08:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWY7W-0007Vy-4f; Fri, 09 Sep 2022 07:08:10 +0000 Received: by outflank-mailman (input) for mailman id 403853; Fri, 09 Sep 2022 07:08:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWY7U-0007Vn-GD for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:08:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2073.outbound.protection.outlook.com [40.107.20.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26002259-300e-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 09:08:04 +0200 (CEST) Received: from AS9PR06CA0620.eurprd06.prod.outlook.com (2603:10a6:20b:46e::18) by AM9PR08MB5876.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 07:08:03 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::33) by AS9PR06CA0620.outlook.office365.com (2603:10a6:20b:46e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 07:08:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 07:08:03 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Fri, 09 Sep 2022 07:08:03 +0000 Received: from a83b8054adf7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8F2CD8B4-226B-4371-A3B0-89DB15FB8C0F.1; Fri, 09 Sep 2022 07:07:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a83b8054adf7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 07:07:57 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS2PR08MB8719.eurprd08.prod.outlook.com (2603:10a6:20b:55f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 07:07:53 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::85e5:3479:7350:9113%6]) with mapi id 15.20.5612.014; Fri, 9 Sep 2022 07:07:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26002259-300e-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Dkus3QtP95I8rjUi30GcnQnaQ8y2/H+Nhe3aE/t6ORKTbopfdJstgiTYcE4+zu6dz4Ecz+cjZkU0W9gJElz4L2ucVbMn1DOHFbdu1jqxjuLcVgScX7NdWP1MFEHHVAmwWh8MA83JdRE9cW21Owxix0iOLjCoX4ghAUQnPVPwfRdRhfytHCYH1eXtmGnsYRCeGqSZ+zmUksPa+91Wsds3pwtUaeO5uVuQ7zcQfOE+v5F9Ns0NUZmT0PGZw/IklxErcSz3JdEcBpp2eUW9Xtd4t3fGf0uArsr1sS/MxYk0HJf43PqdYv2GGhNW1uxK/UYf+BqvvEzgg2WTuimXkeVHJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZvWkcognY6wSHcm/z9A0QIbFtyhFhg/zGkjoyp/W7gM=; b=b6zWkKmpR/7/Dq7PFkf4QSDytFZ8A6HfK53e2cDEFAHo+NjC9glJ5JEkgh/3kOz4b+Z95N8GDySE6yNYw9FKA7tEc18bdLCwFHbgbdKhA42aKRVfnQ0/S2zwISOncI3QEaOjZ7ayowEF6/rdkKF4lymbd0MVBiVigQKnsxQaVN0nxhHI+CFgynjql5J380gaYOp42skbhW2ZvBDuMEGBNHR5QVJvauQNAQhX6fJjRJmUn67N7ehPIX/bIDjd6nGLFGxaS0sgESncfbSfoLD6WKQSnWl+1st8z/lIDBuYlav6G+cOm8QaXa4xLAPKfMdzSSIMWp+4RgMOnrBfv3zOGA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZvWkcognY6wSHcm/z9A0QIbFtyhFhg/zGkjoyp/W7gM=; b=eK2PWITKgpNsTu0k0kCUer5CKo/WNRkuqi87N8S76qgNEykaVZSWRnQ9np+Cz2BMogIWKn8DbbIMmDiaXAnMKl8nnIZSTNutvR5NXVPJMAAwFA6bdoxTfHVDpU2y9+E9O90EO4w7jJiYKvzD098ewEPl9Uhp9nW6fD7oK/py08Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QonGTrs6H7OHcFh/a7uqD40DS0RwViVUUU65C/u6XWe5wNHUN4zXPsgYJrARhezO93HMmMIM86fdg82dHyhkJhL9Fqy9TVvQIBFhA0PxW22UYyXJobsnRrbFmXiHV51n97T54fhzvQPTezOVq1xIC4x73E3npQbdrfGqZ5NLeYzdSSiFewSwkt9BeCwXMju9UZBxZ7hvHlJw2r2DkRyIDML0ZFXGEWMBgVSAgBQYW6AiCBnFO4j8MNQPIhNRME7afV3p6B3vZ4ccfSfOWn3Ek5luEHtZZZOobNv7999vnseOI+D3xbIy42JficgD1z4OMMXYLJMea6b3eaBAvxSzsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZvWkcognY6wSHcm/z9A0QIbFtyhFhg/zGkjoyp/W7gM=; b=RDeiA6qVLQwXy8NiWoFFe3xQssLiQqxgrQO4Pp20YQBv8IzQOPvs10op/tFpXIHJlJroy6lrLabhshxtovm+Gy+Q2HQcjVGwYtwIcx//fKqWCbkb09EjofpdhB3NUwaEEau1xfHS8omJFEFyF326LcORJPbIGQduXe0amm/E987gdrMLWKE92I3CuAxXVNbdpNOhyt0ylEjt3U47CqUpIxlf13NUa6yN5W2mSXwwWJcj8/F+H6jretA1CEeykzWNca23JxnoZKlCnutBxe/uxz4qgYxaKEBR19ik9V+dmRgclEmT/vZHg4vRk5uIQ42qqSmhArkHLk3TdtjOvIF2fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZvWkcognY6wSHcm/z9A0QIbFtyhFhg/zGkjoyp/W7gM=; b=eK2PWITKgpNsTu0k0kCUer5CKo/WNRkuqi87N8S76qgNEykaVZSWRnQ9np+Cz2BMogIWKn8DbbIMmDiaXAnMKl8nnIZSTNutvR5NXVPJMAAwFA6bdoxTfHVDpU2y9+E9O90EO4w7jJiYKvzD098ewEPl9Uhp9nW6fD7oK/py08Y= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Topic: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Index: AQHYvnyUZh7WY/u61UisC2n0bZDyXq3ViaOAgAAfcVCAABKJgIAA/F0w Date: Fri, 9 Sep 2022 07:07:53 +0000 Message-ID: References: <20220902033121.540328-1-wei.chen@arm.com> <20220902033121.540328-6-wei.chen@arm.com> <837f7b6d-0d73-a352-17e6-5c12e06dab95@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 62D8218B7F169F4DA69344CA9EF3109A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS2PR08MB8719:EE_|AM7EUR03FT027:EE_|AM9PR08MB5876:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ee92b6d-8292-4875-2ba7-08da923209a0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gEr/WohLPQsjGpJNPAqzFaeAY9XwC1TGjt8sidMXyb8tiKs7tmPFVJi9ZDl33l6TO9U2wr5yNYJDCfXICVWFrLGAeHgc1R0qO2x/hHXCJ04iXF29oIUAhQxsa6Sc8enwUjkcZBLq6l/SRbdtz0FTdDYha1DdSY8HntsOulTyMFkCjHHBnrQIYXNGf817nWpPzmCjtDS+Ml2jAshU6ZllNohAAl60z61nC6iRnqINcFZ2aUoydbgkTI6hFT/OiHVHj/bUKlooTUjVgHTb4uzyvnhVo7fIPsnLifWaJShj8IRlZ4R5NPwWid/gFbcathry4m6bzIA+9++19F42REgk0MAJOfod+HvVdAtcFxaXcKBDjvEpaHyv9FGJoi6ZW9tmZAB4ODgEsE8NQXhRNl7Poym3qb9EmBgvdfmeH6umZl0IOzfpE1Qg4HSsM7unqLxwPNpH4/1S7uloImPleO7HmvtewmdADAo8CCnlIVs9qz/jkvBi0ioe4lhtb+iiKIFvfBL5nTMdf0diXvKNz/5r5oxZvChQGBWVLXmY0JBGTpL7rI5oc0bvIn2WbMY9ZTyo8RoSESTdZJ96c22gV4Kb3cWDGN6ISuNSmEJBSFYSnb8H36q9KuiFbyc8Ok/sSMxDzZBUJO67NoJTQMtKZjyuJrx4dpEotwgSIjjovfDEGuBD5w+T1pd6cYOTCWWoj5MDMz7mhR4YEr/QyIjBF4J0ZNZm3U1YpxS51fBTiGJjfNZxTBqHd+mjQ1Db+1iBM3lopzqWa2/e+7jEpOoGmgYaKg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(376002)(136003)(39860400002)(396003)(66946007)(41300700001)(7696005)(38070700005)(122000001)(38100700002)(4326008)(8676002)(64756008)(76116006)(54906003)(66476007)(316002)(66446008)(6916009)(66556008)(2906002)(55016003)(9686003)(8936002)(52536014)(83380400001)(86362001)(478600001)(186003)(26005)(6506007)(53546011)(71200400001)(5660300002)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8719 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4a2cc4a6-4f02-45c9-0609-08da923203b5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RD1QlffMi+QBHuKUTvz20AyJCO8AQK01wfQrXuA794KdKHwMvVH6RgMBAvbSVx1K3S1uqBwo8UTdq8hGyujxgsml52zfIs30dMbXDkZKVFyosmn6PHJW+i2/KWb8kmlBNR3qi9mOUSMJjy/bBhfEwLMQS5L7heUFZ+DEof8BF9C7XBR6dGINv45hHqeNzI2nnKhYEkLZtyi1UnxttvhzRTUsBD/D46f3idEv/KO5jrPPZ+NihV70CHzidHTF3CHSvWYIVoUxgg7XqAVEoqT81CGVqoWEKC1sET6/PefFSHIGkBJ2n+ojnY+9tgb2nWSFwxlaqbrWXhd5IeAoweFlazMXq4KPR/JVegX2EnLSxJvCCZyq0TPB3CNCa2SRq3c4O8hko9+s0tdLed5p+IOnBcwG9UK/rJWTTBnsylTdFywm9c8kqT1FCtuCAph6vdlPv3nK9z5nNuiFoX9QPoA6MuI87yq7ZDtVYKXG/o+FwT+JoS9tQMeQq9RnUDpzcGDhiOgA7mQcFBAmnPQ/WpTfBzpLIRh0I7LqVd6daeJJRPmKeM3j/RDhc8CWUB9Q9OokoowmNbBYPeP6J5hhU6vLV8my0NVskqvnzsbWsYbqHEiJM9gefVNZ3EzGdbuENG/QnEsf9aLN3HHn3lL88KDVuhrANvPrAQKHZYv0K1hAG0ugdQjRW4o1YbzmIZzxOZOsphGSTQPSqJpGIqzOZg6Ror6diyLC/6wyWrZlGDhDHYbf/2UsNlhNerKbkv//tiebICFAAhWJCo9FlmLs5CvJ4Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(36840700001)(46966006)(40470700004)(47076005)(186003)(336012)(5660300002)(8936002)(52536014)(2906002)(6862004)(70586007)(70206006)(4326008)(8676002)(26005)(6506007)(9686003)(53546011)(33656002)(7696005)(40480700001)(55016003)(41300700001)(83380400001)(82310400005)(478600001)(356005)(81166007)(36860700001)(86362001)(40460700003)(316002)(82740400003)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:08:03.3233 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee92b6d-8292-4875-2ba7-08da923209a0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5876 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIg55pelIDA6MDINCj4g VG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+OyBB bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+IE1v bm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vvcmdl IER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxp ZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y Zz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENI IHY0IDUvNl0geGVuL3g4NjogbW92ZSBOVU1BIHNjYW4gbm9kZXMgY29kZXMgZnJvbSB4ODYNCj4g dG8gY29tbW9uDQo+IA0KPiBPbiAwOC4wOS4yMDIyIDE3OjI2LCBXZWkgQ2hlbiB3cm90ZToNCj4g Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPg0KPiA+PiBTZW50OiAyMDIy5bm0OeaciDjml6UgMjE6MDMNCj4gPj4N Cj4gPj4gT24gMDIuMDkuMjAyMiAwNTozMSwgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiAtLS0gYS94 ZW4vYXJjaC94ODYvbnVtYS5jDQo+ID4+PiArKysgYi94ZW4vYXJjaC94ODYvbnVtYS5jDQo+ID4+ PiBAQCAtNDEsOSArNDEsMTIgQEAgaW50IF9faW5pdCBhcmNoX251bWFfc2V0dXAoY29uc3QgY2hh ciAqb3B0KQ0KPiA+Pj4gICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPj4+ICB9DQo+ID4+Pg0KPiA+ Pj4gLWJvb2wgYXJjaF9udW1hX2Rpc2FibGVkKHZvaWQpDQo+ID4+PiArYm9vbCBhcmNoX251bWFf ZGlzYWJsZWQoYm9vbCBpbml0X2FzX2Rpc2FibGUpDQo+ID4+DQo+ID4+IEknbSBhZnJhaWQgbXkg cXVlc3Rpb24gYXMgdG8gdGhlIG1lYW5pbmcgb2YgdGhlIG5hbWUgb2YgdGhlIHBhcmFtZXRlcg0K PiBoYXMNCj4gPj4gcmVtYWluZWQgdW5hbnN3ZXJlZC4NCj4gPj4NCj4gPg0KPiA+IFNvcnJ5LCBJ IG1pZ2h0IG1pc3NlZCBzb21lIGNvbnRlbnRzIG9mIHlvdXIgcmVwbHkgaW4gdjMuIFRoZSBuYW1l IG9mDQo+IHRoaXMNCj4gPiBwYXJhbWV0ZXIgaGFzIGJlZW4gYm90aGVyaW5nIG1lIGZvciBhIGxv bmcgdGltZSwgYW5kIG5vdyB0aGlzIGlzDQo+IGFjdHVhbGx5DQo+ID4gcXVpdGUgYXdrd2FyZC4g VGhlIG9yaWdpbiBvZiB0aGlzIHBhcmFtZXRlciBpcyBiZWNhdXNlIHRoZSBjdXJyZW50IE5VTUEN Cj4gPiBpbXBsZW1lbnRhdGlvbiB3aWxsIG1ha2UgZGlmZmVyZW50IGp1ZGdtZW50cyB1bmRlciBk aWZmZXJlbnQgdXNhZ2UNCj4gPiBjb25kaXRpb25zIHdoZW4gdXNpbmcgYWNwaV9udW1hLiBJbiBh Y3BpX3NjYW5fbm9kZXMsIGl0IHVzZXMgYWNwaV9udW1hDQo+IDw9IDANCj4gPiBhcyB0aGUgY29u ZGl0aW9uIGZvciBqdWRnaW5nIHRoYXQgQUNQSSBOVU1BIGlzIHR1cm5lZCBvZmYuIEJ1dCBvbmx5 IHVzZQ0KPiA+IGFjcGlfbnVtYSA8IDAgYXMgY29uZGl0aW9uIGluIHNyYXRfZGlzYWJsZWQgYW5k IGVsc2V3aGVyZS4gSSB1c2UgdGhpcw0KPiA+IHBhcmFtZXRlciBpbiB0aGUgaG9wZSB0aGF0IHdl IGNhbiBrZWVwIHRoZSBzYW1lIHNlbWFudGljcyBhcyB0aGUNCj4gb3JpZ2luYWwNCj4gPiBjb2Rl IHdpdGhvdXQgY2hhbmdpbmcgdGhlIGNvZGUgb2YgdGhlIGNhbGxlci4NCj4gDQo+IFRoZSBkaWZm ZXJlbmNlIGlzICJiYWQgb25seSIgdnMgImJhZCBvciBubyBkYXRhIi4gTWF5YmUgdGhhdCdzIGVh c2llcg0KPiB0byBleHByZXNzIHZpYSB0d28gZnVuY3Rpb25zIC0gYXJjaF9udW1hX2Rpc2FibGVk KCkgKGNoZWNraW5nIDw9IDApDQo+IGFuZCBhcmNoX251bWFfYnJva2VuKCkgKGNoZWNraW5nIDwg MCk/IFdpdGggYSBzaW5nbGUgZnVuY3Rpb24gSSBndWVzcw0KPiB0aGUgbmFtZSBvZiB0aGUgcGFy YW1ldGVyIHdvdWxkIGFsd2F5cyBiZSBjbHVtc3kgYXQgYmVzdC4gVW5sZXNzDQo+IHNvbWVvbmUg aGFzIGEgZ29vZCBpZGVhIGZvciBhIHN1aXRhYmxlIG5hbWUgLi4uDQo+IA0KDQpZZXMsIEkgY2Fu J3QgZmluZCBhIGdvb2QgbmFtZSBmb3IgdGhlIHBhcmFtZXRlciwgc28gYnJlYWsgaW50byB0d28g ZnVuY3Rpb25zDQp3b3VsZCBiZSBiZXR0ZXIsIEkgd2lsbCBkbyBpdCBpbiBuZXh0IHZlcnNpb24u DQoNCj4gPj4+IC0tLSBhL3hlbi9kcml2ZXJzL2FjcGkvS2NvbmZpZw0KPiA+Pj4gKysrIGIveGVu L2RyaXZlcnMvYWNwaS9LY29uZmlnDQo+ID4+PiBAQCAtNyw0ICs3LDUgQEAgY29uZmlnIEFDUElf TEVHQUNZX1RBQkxFU19MT09LVVANCj4gPj4+DQo+ID4+PiAgY29uZmlnIEFDUElfTlVNQQ0KPiA+ Pj4gIAlib29sDQo+ID4+PiArCXNlbGVjdCBIQVNfTlVNQV9OT0RFX0ZXSUQNCj4gPj4NCj4gPj4g QXJlIHlvdSBzZWxlY3RpbmcgYW4gb3B0aW9uIGhlcmUgd2hpY2ggZG9lc24ndCBleGlzdCBhbnl3 aGVyZT8gT3INCj4gPj4gYW0gSSBvdmVybG9va2luZyB3aGVyZSB0aGlzIG5ldyBvcHRpb24gaXMg YmVpbmcgYWRkZWQ/DQo+ID4+DQo+ID4NCj4gPiBZZXMsIHRoaXMgaXMgYSBuZXcgS2NvbmZpZyBv cHRpb24uIFNob3VsZCBJIG5lZWQgdG8gaW50cm9kdWNlIGluIGENCj4gPiBzZXBhcmF0ZSBwYXRj aD8NCj4gDQo+IEkgZG9uJ3QgdGhpbmsgdGhhdCdsbCBuZWVkIHRvIGJlIGluIGEgc2VwYXJhdGUg cGF0Y2g7IGl0IGNhbiBzaW1wbHkNCj4gYmUgYW5vdGhlciBodW5rIGluIHRoZSBvbmUgaGVyZSwg YWRkaW5nIHRoZSBuZWVkZWQgMiBsaW5lcyAocGx1cyBhDQo+IGJsYW5rIG9uZSkgdG8sIHByZXN1 bWFibHksIGNvbW1vbi9LY29uZmlnLg0KDQpPay4NCg0KVGhhbmtzLA0KV2VpIENoZW4NCg0KPiAN Cj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 09 07:23:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 07:23:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403863.646114 (Exim 4.92) (envelope-from ) id 1oWYLr-00022N-M3; Fri, 09 Sep 2022 07:22:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403863.646114; Fri, 09 Sep 2022 07:22:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYLr-00022G-Hq; Fri, 09 Sep 2022 07:22:59 +0000 Received: by outflank-mailman (input) for mailman id 403863; Fri, 09 Sep 2022 07:22:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYLp-00022A-En for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:22:57 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 393b55f1-3010-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 09:22:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB9013.eurprd04.prod.outlook.com (2603:10a6:20b:409::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 07:22:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 07:22:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 393b55f1-3010-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJQo4EkoYn85e1604VR5I8Gm3gV6slaHToBFyp0rBlo+8HggCCpoZnkvbuOovaTmlgCWs3SrsDJWIDTLeDheIgOTWq1uQJ4EswEbFEBu8XjAfnYUZGd+xKU+fQ0b8S1vqfTEdlPT+acTiV1aVFzA23BQlwcCPJKf68pFJDHp9YBd0OG7LN10tzWa+zQQlYxhIuxFjq91gFT4tYEgOxXTGqQiw0sWF6ocX98Z9wFjb0RfF18k3jhkURQAvtXCsCEhh8VY7X9RlNsMxgyOtQwmmq/tul5ue1vk0DVzQi2qOmvYy3lGTPqVlPE4ROBl0iUW9rf21eh4Y4d/JMn1LkqEtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w64Ecx1+8EL+wrspYIaDYT1Izwreh0mSF8hsvv4Kvz0=; b=UzQ1dvHbvqBiWQepYGmtPtlurjiVtQ9yj+GNChj7O9mOyZepTdDlZOoDzkYaGymIMJOPmIagbQlRcA72aO5qQi2L+xgRMEZs3dLvTgO0gZYSH+bDRTCWeW8wcDwds3OOhNYgVuOo8mU6ntIys6TUUHSjbTtkhcH5Dp/tY3T4Uw+sUUNt1ytdarzRQwNiMhx9w0waK7DULTWjZjoIlZRGnyFcQ0RKGDAWVCiVDWcPzAmdoLJlUtYDHJVPSyJlevMJFW06lzTTn/L1+E8IKcZ1sZC+k9KKmR65/+lIt1PBKxZJronwhaacm8EqXi3lwUCPg28301ZpZzweLU3hqmqAkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w64Ecx1+8EL+wrspYIaDYT1Izwreh0mSF8hsvv4Kvz0=; b=EgEw314XzgmtbkgNb9clilLM3mKxRl0rblvLMwplDtZKj3kpiWTaysX2Qs9wvmCJiNuav0mAqYbbCZ1NsKqmhlBcI70B41b3FenAkwUGB0zCiBxwDfsf6kdUDr6+I8HgxpYUytMzGderTB6loqgZMtUhBQ8GWg+zkbDssoBO68hOjeEYOWcTU7jCJhAtGoO8SjIbh26C5YYVTvspfzxaFBtqX94Lb+5P7O38/UWtyC83f6CQpnmMmD7hn91hi/rO+GNN8ZCE8mT0U6LacJmaws6ch//Seed8zV6/Xux9qZpL0SdlQEnXUYplbKOZK9PBmK6m4h86IOY3pd+z3sti3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 09:22:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard From: Jan Beulich Subject: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB9013:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cd4a91c-138c-4ca0-d199-08da92341c99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XJxaXwHsd0BC7GHH7oulhzduW4grWkUQQiuPiqhRu1I9t80TUiVeQIgVpVqlwtf76unAW1CupUAKyxczRTBUNAau4PoJfd0FzeqCk96IQaVBohfQJQS6tHO30//LZ7rZjYwoaCOAexi50xORsnhPRxfnrwHqsrL2Wpt16mw/G/4UaigcTT715wulED5IfX576HZSDkPPsdkKhopbzVDQylzGwoHBSAD0DEm+PP3KeoYwU+kKPJyf+Lj3C02IAC6fzICPtT8cR5ZB9MJUDKPYIL8sNDKCPZvF292UwDEEuU9Z3gUJ8fCevzKxcWGNwfLfwUdR7Wb76cqW2SOyxLH/CdtdiiAExWyl9oy8fXwwPnVIt73MPb0Jvq/K4TwEzDEBxTBnriKmiKynLR9BmgDhyEzzonl0I85IZGFHd+8XkVGrwTm6QC3bB5uTLHnAFQzKjUDWGMONzsK3demq+R8zU0tWWVunkbo0vNBc4EGQ9R5Pj3vGudWkZI9yISHb6aEZuNhJRaohMmHGpd7p6AdOyETR5CJDMSpJtNlKC5/jYwPFXtGYwUv9y96WNRqy5kwWFhXXlyfOz6r0bFm1yof/6n2AyOn7cOMbOfXQ9JTmcwN3GBLkV6ydkVGV88cD6hD2ZVceNrMTe05kzG8vuwps0kI+lUtyUUJ1dyq+rl8CVj6/fmoPQ91gmvlFez29YZ4OGWqR2f3BT7/bfXC7UIEwy4o2lRlqwrefhI2aNmOb3f6VmdXSfg6SMad6wiUQXWR9s9ewarBjY5yYmCKM2CiSiw5UYwTlXMESlgpUAJjzSzg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(39860400002)(366004)(396003)(346002)(31696002)(86362001)(54906003)(6916009)(316002)(6486002)(31686004)(8936002)(478600001)(6506007)(186003)(6512007)(26005)(2906002)(36756003)(5660300002)(41300700001)(2616005)(83380400001)(38100700002)(8676002)(4326008)(66946007)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZktQWUxmY0lESmdyRmVHczhRMXZIb3FrYWs1UFVUb0JQUWVBekZraXIyU1Vu?= =?utf-8?B?SWlBVlB5aGo0KzN6NTdqRytYUmRjK1lpbU50dnNldVIyeG5LVitVbWpZMElN?= =?utf-8?B?ZnVuQ0N4Tm50Ymx3eUE4bFFRL29oRlBnWWV2UUc2RVNQcUxaak1tL0k3QjFF?= =?utf-8?B?ODdWclk0V2VBZ0FNNWhmQ0Z3SjFpSi94dmV3aStIWUpOVXdvQmJWdGdVWFB3?= =?utf-8?B?bGkrWUZ6aDgraWRJZHBXN0JXVC9BaXNNNHROSk1MVlpZdUxmNlVqcGhiN2VZ?= =?utf-8?B?K0NObDhJK2dIbUVPNExIWXJJZy93L2NUNm9JWmJDeFRCS3VlbDNLanN4U2p2?= =?utf-8?B?U3Jud2hUNEROeG9NLzlFYTBVd3VTVTZ3LzVqZFJURG1JcUgrVndWWmhpZmhJ?= =?utf-8?B?aGxJalgxTlBET3FLRHRySElFVTRsNk1BYzhHWDE1cHRUNzIzQ1R6eGhOVEdQ?= =?utf-8?B?K0RwVHRZWWhJMW5FK2M5cXZnd1V0NDZMcUlZSURERHk3VUtOUVpoMmRJY3Er?= =?utf-8?B?cm8zR21WWDNpa1prREd5bzZETEdoVXFiQ0YwTnV6RlZPN1Q2ZnZkOS90b05p?= =?utf-8?B?a0hWOGVwSStORFA3RzFtd3daUWRYOC9FRFNaUXc5bDNjb2NRNTFqT0JRM2tM?= =?utf-8?B?c0w5WVZwUXQrM1pXcXZJa0V4UWtWclJWVDl0Z3JVTlEyQ0JDSzQ4TDRFZjQ2?= =?utf-8?B?S0QxWTQrSnRwU2srcE9NT2I3ekVubEF2emZmaVM0L1cxZEV6eDdOVnExaVp4?= =?utf-8?B?bFl5d0tOZVlEb2xLd3RJUThrbis4cDByM2hzWmYzUkVNUjFveHA0b2J3dlBl?= =?utf-8?B?WFlLUjgrbEcycFlSbzN6WGhjdFdET1EzdkZ3TDhWL0h5TmwydmtGQjFmQjJQ?= =?utf-8?B?dE5lOVJsVElLYjh2M0dKYlJsK3dkV05HbVVoc3R6SXo3VVdaN2VJeW1BSEFz?= =?utf-8?B?bnNVMlBmcDBDd3kyWEtvRmM1Y2JJZG5GNmgzNkF6Q21NdUpCSzhySG9mR1FY?= =?utf-8?B?OWZGd1ZDNUJ1QWtmSkJzZWpwZ0VQVERFd0FtcmdLd1NzRTM2UjNWNEFqMmpa?= =?utf-8?B?ZWo5aVhmYmV2NDJZWVRFMFdwcDJRdWE2eVJkZG1sN2JWbExSUnVkYUhvYUk0?= =?utf-8?B?UFRtYXZPeU1HalV3ZnljZ1FkcUxHSGlwVHZnenNzYXA4cWNQdjM4Ynk0ZklU?= =?utf-8?B?OVRJUUlJbTZwdVlrY1hUakRpZmRqak9WMDk1bzN2QUdma0ZvekduMHg0djlT?= =?utf-8?B?YTRZem5GNnpzWjhmS3h5c3BUTEJFUysyYVFOUHpHeWQxUUdGU2tYWXJQYUtq?= =?utf-8?B?NDAySG1aT0VIVjNIUHdZbHZmdGJXcUt1MDNWOFBJKzFDRHZ6THZPdERyaHl0?= =?utf-8?B?UmtodjZhRVI0OCtTOWR5U05WSXdMZnRSbUZEZ2JaekpEbjQraWYyQ0w4NUVa?= =?utf-8?B?cWRQQitDRnJXazZramU5U0V0RGMrcXdZSlpTcG5ONmdST0duN3Q2eUtJVDZP?= =?utf-8?B?QjdQYjI4TTZlbUkwM1UzUGpvWjdUcnRwR3lYWHNWNWVMY05UYTZUYlhzcnlo?= =?utf-8?B?RGFaN1VuYlAxbHRzek9sOWhiQ0lqUS81ak50bFFWcnFmMVhXa1FXNFZyWVFn?= =?utf-8?B?VFFwRHhwVVRlU1BPK05QRDQrOEpxZHIrMmVndDBKMkloYVp1bWxkUzRvNGo2?= =?utf-8?B?cS9rMEorWG1EVTRBVFVVWmJRYjVVTHU3Vm5QTHVydkJZV0o4UFVRVituNEtw?= =?utf-8?B?S0o0dFowQjVjOTQ4MHM1Vk1IVE9INnc1bnplVTVyTU92UnVuZXBPSytuNDhi?= =?utf-8?B?a0dQbVM0ZXZ5NWcwZXRNRTdZeUZuZWhiN2JYMS90eW1ndndiTk5YWmxwbUhM?= =?utf-8?B?VzMwUnUrUUlza1VTdUk4LzgwRFgzVHBaUXRaYVcwOFVzOHR5aTBOMDVkT1cr?= =?utf-8?B?RDJNTWJncExDZ28rMWVnckJZUlNNUW05NlhlYmRDNGh1ZWxGbVlWdXhxOER0?= =?utf-8?B?TTRHQVNMdmVWczJkRElEd0VPWVozSjhaQlhlOUJ3cS9obTYzZ09pSWRtSUhn?= =?utf-8?B?cjBDM2VtTlA5Qkl1b1R5WlVBWUZ1UU41RFhvN095bHJhajVLQlF5aDVETWp4?= =?utf-8?Q?qm3D7mkcON9WWZ3VW/vvENqdW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd4a91c-138c-4ca0-d199-08da92341c99 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:22:54.3237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MB7MzE48THrPkP/Z4JLM/80rBXSqloqQ65a/7T5YTiq7xOD6bUh+veFp+gboixnrZflutQsC+bWaEk5tL6fD1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB9013 While I was suspicious of the compiler issuing a diagnostic about an unused linking-only option when not doing any linking, I did check this with a couple of gcc versions only, but not with Clang. (Oddly enough at least older Clang versions complain about the use of '-nopie' now that we actually use '-no-pie'.) Filter out the problematic option in all cases where the variable is consumed for compilation only (which right now is everywhere). Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") Reported-by: Stefano Stabellini Signed-off-by: Jan Beulich --- Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for compiling, the option could be omitted from that variable right away. But if any compile-and-link-in-one-go use appeared, there would be an issue. --- a/tools/firmware/Rules.mk +++ b/tools/firmware/Rules.mk @@ -13,7 +13,7 @@ endif CFLAGS += -Werror -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) $(call cc-option-add,CFLAGS,CC,-fcf-protection=none) --- a/tools/tests/x86_emulator/testcase.mk +++ b/tools/tests/x86_emulator/testcase.mk @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. CFLAGS := include $(XEN_ROOT)/tools/Rules.mk -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) CFLAGS += -fno-builtin -g0 $($(TESTCASE)-cflags) --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -1,7 +1,7 @@ ######################################## # arm-specific definitions -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) # Prevent floating-point variables from creeping into Xen. --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -10,7 +10,7 @@ CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFF # Prevent floating-point variables from creeping into Xen. CFLAGS += -msoft-float -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) $(call as-option-add,CFLAGS,CC,"vmcall",-DHAVE_AS_VMX) $(call as-option-add,CFLAGS,CC,"crc32 %eax$$(comma)%eax",-DHAVE_AS_SSE4_2) --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -12,7 +12,7 @@ endif $(obj)/head.o: $(head-bin-objs:.o=.bin) CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS)) -$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS_x86_32,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float ifdef building_out_of_srctree CFLAGS_x86_32 += -I$(objtree)/include From xen-devel-bounces@lists.xenproject.org Fri Sep 09 07:23:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 07:23:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403866.646125 (Exim 4.92) (envelope-from ) id 1oWYMS-0002VY-0A; Fri, 09 Sep 2022 07:23:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403866.646125; Fri, 09 Sep 2022 07:23:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYMR-0002VR-ST; Fri, 09 Sep 2022 07:23:35 +0000 Received: by outflank-mailman (input) for mailman id 403866; Fri, 09 Sep 2022 07:23:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYMR-0002MU-AT for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:23:35 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f4bee16-3010-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 09:23:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB9013.eurprd04.prod.outlook.com (2603:10a6:20b:409::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 07:23:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 07:23:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f4bee16-3010-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SwQuvMRaZjQoJeHigZFpAk2s/OTwkP7dyOu1rRmpqwGx4Abzn+RHntdXY0uIelZOl2cEbJzuV0CtzSn8sslQMsVDHbrhmHatjGg3QBYsTQ0ZKk3At52qt1I+SeECzvQM6AZcA1UVDS9edv1AxvW1CEe6JOuZI8xqCrfh2sW1OnRaGsecqDZE2WB0oOzZmeFO71CHRZma4+IMn2cF9x90L3AS9K2SBwnRDnVsSFHn2QyFk0EW72n8vtPPT+qBShv+LqFavg838FyggdEa0tN70+2BhAWTxh1XxY9IGxvK7R07GUgMUBWKd0PBlhoJO/toZwt7UUEqkwMayHdw4ooDJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G6h3D37U1hyV3ZOoYMiLCX0lzV1VnQzToPpFi7OtJOk=; b=L7qnRNvUI/EoyVMjCesYYrtfDe7kMjVJu5+BZOtHGGdbo5vWWSl4Q0GKBXzTJ09AKx5oTw9cAm7CBO8VJH+qwSKoq4QOmDkpdh8RuBoUIhSCFwNJuMYxdvkYBR64QNWeSHyZJhAZiCsibRB2yXcapuOKZ00nj4nDuY0vO4gSigQoMFxV7701hgV3WbSQEn/BHl+FMKvtxUA6ifTpZN0c6IUXgSbexSZMM6jhsLEaD4vX4PnQp40zi8f27NWCVKhckH8Wj/ydBZp+2+xRxghvnXoei3GJ89tfYoRhUVp0CiSNbQ91Qr5Vqzv5nYpbHmOs5kNzQIGt2rywf4I2HIqQBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G6h3D37U1hyV3ZOoYMiLCX0lzV1VnQzToPpFi7OtJOk=; b=rzEB/t4sMa0h23/y5Vh0+bE+UX4bizjJ26uFTBxWyRHe28PtCfW5O4cqQQdO16KFXx1Wz0YvW/z/P9GWiYO0FahJJpdC5UNr4hxZ5PGkLLQySUfsPCjLc5ZLIQQO/evAf2Qqg08HtcJmh5u9x5Nh0laKeveQUxUpRuTR66izugnsq3BdfYYJrKQmgXe0XzdQXC+xFZnZx1e5tJiY62rC731exxnIzquTL59bw6AtyhC0ttyfojikkLeiqdr3NodEkizhczB73swTjV7oYtr6nCA8pSFdhM1/nMzThJdSyZv3TZFtWAqkSYdNte7XFt0srwU38B757t35KM0+ohGtbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <26c58539-8f58-4727-e327-442f02cc3aac@suse.com> Date: Fri, 9 Sep 2022 09:23:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86emul/test: suppress GNU ld 2.39 warning about RWX load segments Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB9013:EE_ X-MS-Office365-Filtering-Correlation-Id: 10749452-7eec-4eb5-c13d-08da9234339c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aSI9eg/hLWwLF2aDpLMeNniXKSdZ9UghQCPzPklKBpf29W/kVrmOrmKkfknnVCbN049ceymmHIf8+g8ng/flWVp/nlhZTUc9nrTySKI0YFBrT1NqAs6dqWr1q3WnNOsLSj2KDqJZQw/kQsCpQp5hCpLsCIYz93kW244W+DyJ0CqUOEsaLTHp9e/M7gR5vtvKjyCuUAwqH/BFd/ts2DF2PdC//TmuhU1ySgv5CXwIgYhO+/4z1ioD1+yTKRuanWuKtqrxUQ3OoWchThAy4iggCnT8CVb7Mefnmf2YQpog7fE1ZvgfJFN3Xjy/xLKbFfV4A2qvApGeTFdpCMPJ+BlN6Uyk8ytak+jF4RVLXEpWzXpSj0SnGXsnl7lYW6Zy54Qvo2EPbZGiRyusyupcyhkl3QUocNRt2sJ78zFt/5dGSC/silQmmTt/3Cqi6psOhkIQPtkgEDQizv5v7AJfg453g1ms3quOPEYBpQpUhDL0rzmEfDGK66mshvhDuC9G4V+nqEmPftjvZz92b0ZLmWNrrLLIL8BmAf02McA7gsBn3x5VrEI3Q/V9sZ78oor2otfD2XiAWa1uafv8Ytxd6B7nSmTRbJNBYfARZLschHJHuSos1IgAkblEWORXuCSmR2fwkcq6LY4w4zrZUoFNTK7s9RQAf9eRrAIqpgsnbq5fDLsR0f7Bh17wl9cn3r4w8AlqwOc7SQ1GChaNvd9FjSCYqA6vS/vIkfPlw2J+cqe84Ixv4hgxwvd8aphUj/ooZRUhUlZU0DTH+JbT8dCfJTlIhsoohSBq7dMq5WdthAAWybs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(39860400002)(366004)(396003)(346002)(31696002)(86362001)(54906003)(6916009)(316002)(6486002)(31686004)(8936002)(478600001)(6506007)(4744005)(186003)(6512007)(26005)(2906002)(36756003)(5660300002)(41300700001)(2616005)(83380400001)(38100700002)(8676002)(4326008)(66946007)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TERjQTBDR3F2MkZldGU4dHoyZmYrN2UvYlQxcE03R2UvQ012R2JqQmpkcnpz?= =?utf-8?B?ZmRydXFBNTNuZ3BLbzQ0YmRnaWk4T1R4UlRZK0VHY2dpUGQ5dldyd0tiZ3lB?= =?utf-8?B?WkdhblRIRlRYYTZIQXpXOUtZRkRheHZYelVDMk1FWERhczVGcnZNK2pGc05n?= =?utf-8?B?aXlxNnRRcjIrcytnMmg3S2JnZzYrMmNFNTZqZ3l6Ui9qczJvYWhwZVpmZEZw?= =?utf-8?B?anE0OGFsczF1MTNWTXRjTjF2dzVmSmNqMU9mTVJrbCtzY1krZjJVenc5dmF3?= =?utf-8?B?ZEk5WEtpRThYT1IvVWw5K3AvdWlndDdpR2J0dFVNTjZRQ1pFV21XWHI1ZWxH?= =?utf-8?B?aXRMajYyaXZQczVEdnJBelI2bTg2ZWswRGdoKzhsVnFtQTB2M3l3YmNydmtD?= =?utf-8?B?VUs3bWtlc2d3V1N0dlBRclBGR3BKbzMvcDc1aHdTdWRwSW8yOEVzZ01DeHVr?= =?utf-8?B?WFV6WkE1bVVUUTVEZW9wZFRsMUNJREM2VTFhY2ZyMnpIRjdxQ3I4c3lQQnRi?= =?utf-8?B?TytBSWMyT2hwRllQWHNtNTFSVDQ4L1BvbmxKQnppWGc0cEUzL3A4K1ZBTnZT?= =?utf-8?B?R0hnOEpvaTdmUnlQQ1FabUM1cnFMZW1yRjdlQk51bVdTSXZhU0RuTUtpLy9r?= =?utf-8?B?c2RiRFJEVHJvOGM2U25tTnZ2bXFRK1FuLzZ6ZTljREhCS2xieG1PQ2t2Wmhk?= =?utf-8?B?OGRWMjhSQmxhcjBTSVB1OFlvTkdwenVKelI5c3NFelRCMFloV0lqTlAxOTBG?= =?utf-8?B?dTZkajc1dkNDVkxzUHBuQTJLdEZjRGJ4Tkx0MHJMVlNTUVVwdkhOTXVwRzVL?= =?utf-8?B?NkNMa2JhbWhpRVZNN3pIRDVkUDgvd1RyZElQUW1ZdUFOSkQ2YzFwOTNkQXlG?= =?utf-8?B?TGN6NllNdGI5MGNIblFjY3A2QUhFTGZPQlZHK1hWbzM0b0FNS3huS2J0U2Zu?= =?utf-8?B?V2dicmtMRUh6UlB2eVBDRUFtSm9ZWTFJemJOV1JGd1dMV0M1NjdhY1hyQmRq?= =?utf-8?B?V2lwM2NjUm1QZHRpYWRETW9waSs1b2IxOTJxZ3U1S2hHK0JsZllnQzJuY1By?= =?utf-8?B?eU83KzVPSjNXYStieS9hZ1FmaVlOUXpDS1pZbHFmZG92dEZudFZoREM0Mnlx?= =?utf-8?B?RFFaMzhIYjNMVHFZVk1wQytMZlVMOVlPZSs3VXI0QVNvUzlXTlRnZjRYY2ow?= =?utf-8?B?U3pCMFJDUXF5RkhUMnQ5RnpqTUR3WVcyR0FkWVdWOHNPd1UxMnVUSTFIc2xB?= =?utf-8?B?VEFRMURBTUlWWjVBNTNXYi8wc2E5Wk1ZSlFyV1BqL254OS9RQnVCallCQVRC?= =?utf-8?B?enRrZUU4UmZTaXpNbXZCSitBbzBzemlPcElCZi9OdUdXd3dJMnNDWDVNUzlU?= =?utf-8?B?UWRXZThHUmF1T2NpNDN2L29KbGJVNFVybUJFazE3d2g4b0tnMVI3dCtURUNS?= =?utf-8?B?UVhKeVNWVFFuWHlOSGdpaDhsd3VsaFBJbTZ6WFpnT214WjdnMEtGbG94dmxq?= =?utf-8?B?MWNpQTRvNFBBQTlCRUp1dy9peTNYN0d0QTNrSGtDd2FaeXNVeWlCM1pLdG5t?= =?utf-8?B?U1F5aHpwaytFUlFWNkthR0pSOGFVd2EzZnRaampLVDd4TEl6Y2dDdzA1bkFr?= =?utf-8?B?eXZvZFdKakpoUHNjNEM0eW84VUZvOGRTQm50enRnYThYUXZsMmd6WmE3U1lK?= =?utf-8?B?RjFFQ2tmZVpIRGpsamh6aWc4S0lhRWRsdnd3NzM2N3drQXlRU3RycU04L2Jm?= =?utf-8?B?NUJ3a2ZJamJpMFFBa3dSdC91Z2tWVkhqTnBxdnBJMmF0MVRDRGN6VUdIWi9D?= =?utf-8?B?d0sxOU12YWRXU2Z6SFlmOHZYdm5sa05WY0VTOVJac2ltYkhJd0Y1UjdBdGg4?= =?utf-8?B?L2RsMVQ2KzhiaXQ3b21vMGJFMXVGMUhqeUF2aXZhYUJlQzRxK2NTN2dHZFl4?= =?utf-8?B?WXJzbTVkWExjUzArR081ekFOUDFhSWpXQWRYQ2NhMEtQTXN1d3BPVGFScisv?= =?utf-8?B?Qk5PdUhjTVl3U0tHeS9jdnFsWHpFWmNqcDl3L0FjekR2SUpsQ3hjUVZWcnZH?= =?utf-8?B?OFozVVFUSGhQZjlJY29jNVZSWnJUNE9uc1JNUXhKYWZJNVkrcUl4LzBRWE51?= =?utf-8?Q?Xn0gwhECSCFF8NG492oNTuygF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10749452-7eec-4eb5-c13d-08da9234339c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:23:32.9774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fxB7Z8gTfA1Jd9NJ+JxDBjD3uWTIfHRyVSgtjWU6MJlu2J7clLXkwediOgj11tlsdoVCBH66V7PebMJB8wwanw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB9013 Commit 68f5aac012b9 ("build: suppress future GNU ld warning about RWX load segments") didn't quite cover all the cases: I missed ones in the building of the test code blobs. Clone the workaround to the helper Makefile in question, kind of open-coding the hypervisor build system's ld-option macro. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/testcase.mk +++ b/tools/tests/x86_emulator/testcase.mk @@ -6,6 +6,8 @@ $(call cc-options-add,CFLAGS,CC,$(filter CFLAGS += -fno-builtin -g0 $($(TESTCASE)-cflags) +LDFLAGS_DIRECT += $(shell { $(LD) -v --warn-rwx-segments; } >/dev/null 2>&1 && echo --no-warn-rwx-segments) + .PHONY: all all: $(TESTCASE).bin From xen-devel-bounces@lists.xenproject.org Fri Sep 09 07:46:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 07:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403877.646136 (Exim 4.92) (envelope-from ) id 1oWYi7-0005fq-PD; Fri, 09 Sep 2022 07:45:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403877.646136; Fri, 09 Sep 2022 07:45:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYi7-0005fj-MA; Fri, 09 Sep 2022 07:45:59 +0000 Received: by outflank-mailman (input) for mailman id 403877; Fri, 09 Sep 2022 07:45:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYi6-0005fd-Bu for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:45:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70575b33-3013-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 09:45:56 +0200 (CEST) Received: from AS4P189CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::9) by VE1PR08MB5805.eurprd08.prod.outlook.com (2603:10a6:800:1aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 07:45:54 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d7:cafe::89) by AS4P189CA0008.outlook.office365.com (2603:10a6:20b:5d7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Fri, 9 Sep 2022 07:45:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 07:45:53 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 09 Sep 2022 07:45:52 +0000 Received: from 131b74ff6a5c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6FDC9709-7DA5-4F34-939F-092243842D3D.1; Fri, 09 Sep 2022 07:45:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 131b74ff6a5c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 07:45:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VE1PR08MB5855.eurprd08.prod.outlook.com (2603:10a6:800:1a2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 07:45:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5612.018; Fri, 9 Sep 2022 07:45:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70575b33-3013-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Rfmr+fOP1aA2E0tALu+R9/3FNrgkwMFw3fUoCV0WJ7XCGoBrHA5VhKttjpu0EUBNNgSD9qbLjnBEHMquRXRFcmZva9BRJYu/NZhEzKKZwQBXhfeomA0xM+PEW2Dt+OYN2nChUteeubktcHvjv2t6Tl0vFC2dshxGFQK+RCNZLI97DtCGfnGR3f9DVMB041NgKVSrJbT8Rqu18ABmth8XCfTqEquax7Ghq7zhfBQ1k+HbZXl9/eeuLVusa2eFYHVDinPwOG4LqTCM+pj5SH5o5fWTEqQkDe7LqrB+WLTxU8HbVeGrvgyXo846Mqfc977SCzkT2C+aoLSZMUpE3ntqVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXt4kVSuEpfxHb14MhuNQJPImZ00n0rGtImUxG5RhRQ=; b=NMn719LV4FkLhrU7zEr5BuauwSKqEoCSxMPWGM4A0hQ8qCoJ2lYs5qzus3RVriiGgdkYfub/2/UsFvu1PguOqU7+8h+R277Ws/d8wHYXOPlwEgX1MqX3wWGF6iolQ8EeohXrxkOb5wAdRIzEQvF0OCYrBsma6PhFoeiQg5pCLtsa7lZe2mZsy0uyk2NROw1GsGaoqeUqO7rKjWe+tm409PXgPtNWBDjKtRi4X0G9BcNlhYjqQ9KCCsb9toDCzY78SZfLPsn39jP+VxgIqRv/QQUJmKm8RRL/FzJN0z/vsJTA1zeUxga8X7Y+N6570hv5OgAkWO/w2LOGMpjvbxl4mQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXt4kVSuEpfxHb14MhuNQJPImZ00n0rGtImUxG5RhRQ=; b=2FB8OOeUAuGXbxg1L1FgAc4gzIVdi7ARhcsDQhMyLCPo9Tvq2M0ms+IZ8bfqa7pAr03oPS+IsOvL+gAEnXqoEaAmubqlp5Tr5b264We7lu5Uzv/Srjyp36l99RxARiMJA/3bOWATZTtD+lTHrBcbSlly9AJYbIr5lb3hrd7QSFw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 32ead1e3471c7cef X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RCFdMJo9KAPTnhhZbOwQRa7Y2jgGaBowBTE7XLI81q04TzdZdCCVhXDNRRK+V865z+Z6W0MN7qiAFPGa5FxXIacQ85EU9EKhJ8a+c1V/AYphz36SGDbLEtYKSf5ttjpI+Mlywz5L2eRkz4zxBqk0PvSWPNRt0KvSWf4ZbAMCuA9YtQHhE1DWArjyVerRzDWBvnFMQH0LX+a1UQK1zjpu0dvSeFtKTB8Tufu7gjEdewrGIC7o6r4FkzlIVhAOxTp4pvFqkpmm6zG0Fb/Fbunlf+jxQRRbWIoeAaet38uocGcpAnmefKmEOJ+9cTa8mCdSU0wjWHu1NSl88IIj0BSC6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXt4kVSuEpfxHb14MhuNQJPImZ00n0rGtImUxG5RhRQ=; b=MKfg5d9cgPGzP7pnefEnmNsPph65P8kqjFzhyDF70VL/pimBEGByUQB1ML3piR2PWXCz33uBRkjinDCOexPuDDWyPBlbOxwL5/DhAqlzFvhXUYZZZlx7sq+mAKGeC/Ik33eaiJ1oba4sAFGgsu3RxKwk17bXU3XDlxvbhQNS3+Cb0GJ+8uSwiQwCwjlpcKOleut8kya2Rq9ml4lam258YgRO9aiwneAMpuEO4MC4qi7pPpL5Xxv2JooPGqyc1Duv6y0GlFMH6JV0qC5ImTHNjrOBDPA/lAxh0KR1mZ/+ACLeBVd20+mkQBHz1omfjQkn/9hE8oKyV5ZCsxQ57FNpxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXt4kVSuEpfxHb14MhuNQJPImZ00n0rGtImUxG5RhRQ=; b=2FB8OOeUAuGXbxg1L1FgAc4gzIVdi7ARhcsDQhMyLCPo9Tvq2M0ms+IZ8bfqa7pAr03oPS+IsOvL+gAEnXqoEaAmubqlp5Tr5b264We7lu5Uzv/Srjyp36l99RxARiMJA/3bOWATZTtD+lTHrBcbSlly9AJYbIr5lb3hrd7QSFw= From: Bertrand Marquis To: Stefano Stabellini CC: Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYw4q6erckyWfXI0qMZ5bjaFqTVq3WBmMAgACy1QA= Date: Fri, 9 Sep 2022 07:45:38 +0000 Message-ID: <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|VE1PR08MB5855:EE_|VE1EUR03FT059:EE_|VE1PR08MB5805:EE_ X-MS-Office365-Filtering-Correlation-Id: 929ee10a-2ef9-4834-019a-08da923752b7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UvBCOSwWoGXBIcpC/FnfM7Pb/roEsynOFs+HgDwmFoCuOT/z3SUBlg0eE6TR7zpW0yRL5/zAcLuRQAo+1PP3kOOpuAPh9eHYpszv+sOPKF3tVfMAbMDPljQnsAUSuhpEUznPsSiNcUjtu5Yx2M6oup0+7XRzt5p/AYCZiszMBCEXV0IzEdXg3Yaoa9ElhKyh6ekdVrVnv/SCmJ2MCA+//JthJQv9/rkU8Y1OergCOagGswKiqqagzqQYrcQtS/pHwuBYj9l+4G35/OYtGSLvOTlfRfY3WOJteIiD2w9NAtv1MISOowOFfr844Vup7sxpN7YmVkDuRaE3YsVJe2wtqEEk5ZT0vbgtcKfLlIBjcqPT0VdKO+tB+vfdiG6ByQojm2BQkkMBh/qneE1lqB1/6eVYNzj13VEQndq90St2CeWJ2Qu8Nxu2uWRGR5jLBYR5fhMQgVOSt03nx7mPgIsGgVvRYBz+S8t/4otCMBJIB7QXaM0Q47QUEuwH+BUdUnSlfFY+A+daBtyIvganIiOBfGC2c6NXI7DcqFBaHnbOR8alfrsjPJNZN+0eqZKmH62VS/gI7MLlDmJo+KhdIgSgKZc76Ze8A1EpHPrZi1eKTqABkxjtaNb+UpvPsaZB/dTUus0t9F3RlLGwMdrEmlGOxYgRmrda28uFeIckd4RzArvN5iRaz3m1umD/LM5G0JG/a//fu3glEsHKGu4pe0tgMXdFGjRo96WRq4NJxeoPZEh/geix/4X73EEwox31FL4E3VcSCEId4O9ogjotol+K0KgDFJNhBJbeohFLzZ9pDhM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(38100700002)(86362001)(36756003)(122000001)(4326008)(66446008)(64756008)(76116006)(8676002)(91956017)(66946007)(66476007)(66556008)(38070700005)(33656002)(41300700001)(83380400001)(6512007)(6506007)(26005)(53546011)(478600001)(71200400001)(6486002)(54906003)(6916009)(316002)(186003)(2906002)(2616005)(5660300002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5855 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dbb3c942-86a2-43fe-8d25-08da923749e6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e+vI/e7R2QTz/pgrqgumzNO3fKsqMqPZMr+IOEjU+j/Gaiu7DEaVZRZTEGFJojIOhOW0GpIIZeOHiI837/H2WkgMEeOAWZjA5I5BMXVBUuL4OA/aoFIKo4NWKdquCFfr/Sd7A9jm1qspYMQAtcbJ/13PjsNxO/Ft4YVJfntmjzil3KkysV8556DVlUDtmrNwQwv8Io+qEptiVUT+RYjJ6g50Kw+u3uNkhy+DfD1t5gmxrcm8D3DvYlUvG49RWvVRPmB2amkuzCuaLBaep/0mOUGAtMXjGj/75VN/Z7GjnY1UVBlcyIHfpz2yhjYd0fzoboCRcxMxKgUGobY3UH8jcnpAL9ABSq95F3eoVUaprxRi+t01+WskDGcNIid1e3kKvHU6CYg2HnJBwN24GdZScsYLnNnXXZKYKGBqFojjLn9uL/zz5vNcR92pXSz8N1NwIJdhs+6mpzPurbNbfd5d/vMlC9/fj1FwS4y2g8bZcNsYmPy9Zc8xGhJhamIPR2HCu/UiaLKSyq4EZMzjLelVUjcW+V87WWK+nZE/C5XR6aVBbim83uUxu2F7H9jNdiwWSSLEzy7NpyGVohuH2cgsjrXo1UpRNbVjDpFGLgdTzl9XFtuqkzgSY5M/lpQaXCzSjh887WMFGpbc6GWJkYCyuH9JT9OZ1VBCEoY2yPvNfh2NgaNUIA3C1apQYA+HCHaxR0Lh6PcJ9ThYKbHKqaqoZZArjZC6rfDqm0Y1eG/l5neZix0jPDY9526lmUCfJg8Qo1B52xrpiUzOhZdLxf+BRw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(396003)(39860400002)(36840700001)(40470700004)(46966006)(54906003)(82310400005)(83380400001)(86362001)(186003)(316002)(2616005)(336012)(36756003)(36860700001)(47076005)(70586007)(6486002)(107886003)(5660300002)(8936002)(70206006)(356005)(6862004)(478600001)(8676002)(41300700001)(4326008)(40460700003)(40480700001)(82740400003)(81166007)(6512007)(2906002)(26005)(33656002)(6506007)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:45:53.3276 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 929ee10a-2ef9-4834-019a-08da923752b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5805 Hi, > On 8 Sep 2022, at 22:05, Stefano Stabellini wrot= e: >=20 > On Thu, 8 Sep 2022, Penny Zheng wrote: >> We expose the shared memory to the domU using the "xen,shared-memory-v1" >> reserved-memory binding. See >> Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt >> in Linux for the corresponding device tree binding. >>=20 >> To save the cost of re-parsing shared memory device tree configuration w= hen >> creating shared memory nodes in guest device tree, this commit adds new = field >> "shm_mem" to store shm-info per domain. >>=20 >> For each shared memory region, a range is exposed under >> the /reserved-memory node as a child node. Each range sub-node is >> named xen-shmem@
and has the following properties: >> - compatible: >> compatible =3D "xen,shared-memory-v1" >> - reg: >> the base guest physical address and size of the shared memory reg= ion >> - xen,id: >> a string that identifies the shared memory region. >> - xen,offset: (borrower VMs only) >> 64 bit integer offset within the owner virtual machine's shared >> memory region used for the mapping in the borrower VM. >> Currently, we provide "xen,offset=3D<0x0>" as a temprary placeholder. > ^ temporary >=20 > Another minor style issue below >=20 >=20 >> Signed-off-by: Penny Zheng >> Reviewed-by: Stefano Stabellini >> --- >> v8 changes: >> - Fix missing property "xen,offset" for borrower VMs by temporarily >> adding "xen,offset=3D<0x0>" >> - use >=3D to avoid thinking about the overflow case for nr_banks >> - check the return value of dt_property_read_string() for parsing >> shm_id >> - struct meminfo *mem and char resvbuf[16] =3D "reserved-memory" could b= e >> const >> - change "__be32 reg[4]" to "__be32 reg[GUEST_ROOT_ADDRESS_CELLS + >> GUEST_ROOT_SIZE_CELLS]" >> --- >> v7 changes: >> - allocate reg for worst case addrcells + sizecells >> - replace assert() with BUG_ON() since it is init code >> --- >> v6 change: >> - change "struct meminfo *mem" to "const struct meminfo *mem" >> - change "unsigned long i" to "unsigned int i" to match the type of nr_b= anks. >> - accroding to the Linux binding, "xen,id" is meant to be a string, not >> an integer >> --- >> v5 change: >> - no change >> --- >> v4 change: >> - no change >> --- >> v3 change: >> - move field "shm_mem" to kernel_info >> --- >> v2 change: >> - using xzalloc >> - shm_id should be uint8_t >> - make reg a local variable >> - add #address-cells and #size-cells properties >> - fix alignment >> --- >> xen/arch/arm/domain_build.c | 160 +++++++++++++++++++++++++++++- >> xen/arch/arm/include/asm/kernel.h | 1 + >> 2 files changed, 159 insertions(+), 2 deletions(-) >>=20 >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index a10d07266b..cd03370b38 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -914,7 +914,22 @@ static int __init assign_shared_memory(struct domai= n *d, >> return ret; >> } >>=20 >> -static int __init process_shm(struct domain *d, >> +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, >> + paddr_t start, paddr_t size= , >> + const char *shm_id) >> +{ >> + if ( kinfo->shm_mem.nr_banks >=3D NR_MEM_BANKS ) >> + return -ENOMEM; >> + >> + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start =3D start; >> + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size =3D size; >> + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, sh= m_id); >> + kinfo->shm_mem.nr_banks++; >> + >> + return 0; >> +} >> + >> +static int __init process_shm(struct domain *d, struct kernel_info *kin= fo, >> const struct dt_device_node *node) >> { >> struct dt_device_node *shm_node; >> @@ -928,6 +943,7 @@ static int __init process_shm(struct domain *d, >> int ret =3D 0; >> unsigned int i; >> const char *role_str; >> + const char *shm_id; >> bool owner_dom_io =3D true; >>=20 >> if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memor= y-v1") ) >> @@ -972,6 +988,13 @@ static int __init process_shm(struct domain *d, >> if ( dt_property_read_string(shm_node, "role", &role_str) =3D=3D= 0 ) >> owner_dom_io =3D false; >>=20 >> + if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) >> + { >> + printk("%pd: invalid \"xen,shm-id\" property", d); >> + return -EINVAL; >> + } >> + BUG_ON((strlen(shm_id) <=3D 0) || (strlen(shm_id) >=3D MAX_SHM_= ID_LENGTH)); >> + >> /* >> * DOMID_IO is a fake domain and is not described in the Device-= Tree. >> * Therefore when the owner of the shared region is DOMID_IO, we= will >> @@ -999,6 +1022,14 @@ static int __init process_shm(struct domain *d, >> if ( ret ) >> return ret; >> } >> + >> + /* >> + * Record static shared memory region info for later setting >> + * up shm-node in guest device tree. >> + */ >> + ret =3D append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); >> + if ( ret ) >> + return ret; >> } >>=20 >> return 0; >> @@ -1331,6 +1362,126 @@ static int __init make_memory_node(const struct = domain *d, >> return res; >> } >>=20 >> +#ifdef CONFIG_STATIC_SHM >> +static int __init make_shm_memory_node(const struct domain *d, >> + void *fdt, >> + int addrcells, int sizecells, >> + const struct meminfo *mem) >> +{ >> + unsigned int i =3D 0; >> + int res =3D 0; >> + >> + if ( mem->nr_banks =3D=3D 0 ) >> + return -ENOENT; >> + >> + /* >> + * For each shared memory region, a range is exposed under >> + * the /reserved-memory node as a child node. Each range sub-node i= s >> + * named xen-shmem@
. >> + */ >> + dt_dprintk("Create xen-shmem node\n"); >> + >> + for ( ; i < mem->nr_banks; i++ ) >> + { >> + uint64_t start =3D mem->bank[i].start; >> + uint64_t size =3D mem->bank[i].size; >> + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ >> + char buf[27]; >> + const char compat[] =3D "xen,shared-memory-v1"; >> + /* Worst case addrcells + sizecells */ >> + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; >> + __be32 *cells; >> + unsigned int len =3D (addrcells + sizecells) * sizeof(__be32); >> + >> + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].st= art); >> + res =3D fdt_begin_node(fdt, buf); >> + if ( res ) >> + return res; >> + >> + res =3D fdt_property(fdt, "compatible", compat, sizeof(compat))= ; >> + if ( res ) >> + return res; >> + >> + cells =3D reg; >> + dt_child_set_range(&cells, addrcells, sizecells, start, size); >> + >> + res =3D fdt_property(fdt, "reg", reg, len); >> + if ( res ) >> + return res; >> + >> + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", >> + i, start, start + size); >> + >> + res =3D fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id)= ; >> + if ( res ) >> + return res; >> + >> + /* TODO: >=20 > It should be: >=20 > /* > * TODO: > * >=20 > I think this is good to go. The two minor style issues could be fixed on > commit. I haven't committed to give Julien & Bertrand another chance to > have a look. I think that it is ok to fix those on commit and I am ok with the rest so: Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 >=20 >=20 >> + * - xen,offset: (borrower VMs only) >> + * 64 bit integer offset within the owner virtual machine's s= hared >> + * memory region used for the mapping in the borrower VM >> + */ >> + res =3D fdt_property_u64(fdt, "xen,offset", 0); >> + if ( res ) >> + return res; >> + >> + res =3D fdt_end_node(fdt); >> + if ( res ) >> + return res; >> + } >> + >> + return res; >> +} >> +#else >> +static int __init make_shm_memory_node(const struct domain *d, >> + void *fdt, >> + int addrcells, int sizecells, >> + const struct meminfo *mem) >> +{ >> + ASSERT_UNREACHABLE(); >> +} >> +#endif >> + >> +static int __init make_resv_memory_node(const struct domain *d, >> + void *fdt, >> + int addrcells, int sizecells, >> + const struct meminfo *mem) >> +{ >> + int res =3D 0; >> + /* Placeholder for reserved-memory\0 */ >> + const char resvbuf[16] =3D "reserved-memory"; >> + >> + if ( mem->nr_banks =3D=3D 0 ) >> + /* No shared memory provided. */ >> + return 0; >> + >> + dt_dprintk("Create reserved-memory node\n"); >> + >> + res =3D fdt_begin_node(fdt, resvbuf); >> + if ( res ) >> + return res; >> + >> + res =3D fdt_property(fdt, "ranges", NULL, 0); >> + if ( res ) >> + return res; >> + >> + res =3D fdt_property_cell(fdt, "#address-cells", addrcells); >> + if ( res ) >> + return res; >> + >> + res =3D fdt_property_cell(fdt, "#size-cells", sizecells); >> + if ( res ) >> + return res; >> + >> + res =3D make_shm_memory_node(d, fdt, addrcells, sizecells, mem); >> + if ( res ) >> + return res; >> + >> + res =3D fdt_end_node(fdt); >> + >> + return res; >> +} >> + >> static int __init add_ext_regions(unsigned long s, unsigned long e, void= *data) >> { >> struct meminfo *ext_regions =3D data; >> @@ -3108,6 +3259,11 @@ static int __init prepare_dtb_domU(struct domain = *d, struct kernel_info *kinfo) >> if ( ret ) >> goto err; >>=20 >> + ret =3D make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, >> + &kinfo->shm_mem); >> + if ( ret ) >> + goto err; >> + >> /* >> * domain_handle_dtb_bootmodule has to be called before the rest of >> * the device tree is generated because it depends on the value of >> @@ -3484,7 +3640,7 @@ static int __init construct_domU(struct domain *d, >> assign_static_memory_11(d, &kinfo, node); >>=20 >> #ifdef CONFIG_STATIC_SHM >> - rc =3D process_shm(d, node); >> + rc =3D process_shm(d, &kinfo, node); >> if ( rc < 0 ) >> return rc; >> #endif >> diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/as= m/kernel.h >> index c4dc039b54..2cc506b100 100644 >> --- a/xen/arch/arm/include/asm/kernel.h >> +++ b/xen/arch/arm/include/asm/kernel.h >> @@ -19,6 +19,7 @@ struct kernel_info { >> void *fdt; /* flat device tree */ >> paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ >> struct meminfo mem; >> + struct meminfo shm_mem; >>=20 >> /* kernel entry point */ >> paddr_t entry; >> --=20 >> 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 07:47:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 07:47:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403886.646146 (Exim 4.92) (envelope-from ) id 1oWYjM-0006GZ-9N; Fri, 09 Sep 2022 07:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403886.646146; Fri, 09 Sep 2022 07:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYjM-0006GS-6b; Fri, 09 Sep 2022 07:47:16 +0000 Received: by outflank-mailman (input) for mailman id 403886; Fri, 09 Sep 2022 07:47:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYjK-0006GE-A9 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:47:14 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00089.outbound.protection.outlook.com [40.107.0.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d578bc7-3013-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 09:47:12 +0200 (CEST) Received: from FR3P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::7) by AM8PR08MB6548.eurprd08.prod.outlook.com (2603:10a6:20b:314::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 07:47:10 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:94:cafe::e3) by FR3P281CA0125.outlook.office365.com (2603:10a6:d10:94::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16 via Frontend Transport; Fri, 9 Sep 2022 07:47:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 07:47:08 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 09 Sep 2022 07:47:08 +0000 Received: from 99da037e6697.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CAD35C6D-5FB2-4B40-9707-CEEAA290E7EC.1; Fri, 09 Sep 2022 07:46:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 99da037e6697.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 07:46:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VE1PR08MB5855.eurprd08.prod.outlook.com (2603:10a6:800:1a2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 07:46:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5612.018; Fri, 9 Sep 2022 07:46:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d578bc7-3013-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iLG5HEQ80JmgE+TpYjCgNMMnDSYaQ4wNLGAIBzMI4Yq09WmD+sdStExeikl9oT5pn3FcprKWLYPYBkDIeoY5Pqg5ukrXJixeC8C9YQ5mC8/wBnvaMXJX175UJ7DMQkGvjnOB6LjQlwMOD1cNdszmLl8vvBAIA7w0WPkbzYmEwsiDLz/KVmP/HTzbUicBydAq4UotUZMxvaxXGbHD/B2YXsmF2S7XlhM2F4KaYf+4cRmJmrM3q5gFww2/bKsOd2E2sZAztxGEky7e0QXmVHBqBp4xAZTIyRexW2w9W3cfC98HnqJ30yT9qMizoxAh2EAXizoHZWekRM9EhGjJkShJ2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X9t0EgJPcUHOqOm+x5NpCj8PWNZFagWdWrTdQF3n7BM=; b=Zk8z0MWPKzAIb7tFI0KIWWqihWd5Q+OluxfqBmyRE1McE6lUTLaGkZMPNai0UsMrLaUFIttcHe+Pdq8+fpofHeLCJTki5NUSRG0AiQEze67wlrL9384OQSDe2W4/jAAUz0KfCUSSH2tOrLuUpnJQlteKNB0E42r0PTW8Mk/6gjX2b7RfBDTjsz+ILC2SWYIMDy6panEk1q8ZCUHr5I59NfumNLAZ4diZk0uY1fELzqN0bdrNi0p4rzbEKsFiQhhahtLNjkZggtqfgkHBqgATb2MQNSo3oXW9A+gnhP68awtL46X1cbRb3FUqnvOxxgFW0o4ezZedLly94oIPepk98w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X9t0EgJPcUHOqOm+x5NpCj8PWNZFagWdWrTdQF3n7BM=; b=rWHzvBqOknWVGm1UMp/p4HjWbZTxIxrw1tk/H7eva1cdYovX4OJrBbEgtIkXlV0Epdmnz0d5S1xxG4wqlUxIVXyrjheKM/MPu4/ym2jBkj1gwmep1jMb9QVp2pIJRGJMPNP5dDarZI81AZ6dddWmoYGwSBheDa+M1fUYTFdNSbc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d775fba767d3d04d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwZg7jfojU5O352pQDdihVP/Rw14DIUEqtdF9AP1F/zyaLulgK+Osut6tU/ONGcFAJvO4PMmGyK7/WmE5n5F63KsHVtvZi1gC1FZj+U5NK6y7m+e/bhljMne4R5bBAKU3+HB2Annl7nGlsZJdvB3yM5v/LXIDgp3Zp1Rdqpp3Jn8IO6cCMGn5uZfQpkjdiROg0AUIkTezgCqrOAbcO/pTreF2mljfOlkL/mT9hAGicAsdFSRtpadyYQI7ssYV2f9H24fIzlHU6SMt7raPvmfAEfrt0P7Gd6z1F4nOjpDC762RtZC0IfGLrCBZq/EnOQtGzyH/cKa/g7KLlvCBHCwWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X9t0EgJPcUHOqOm+x5NpCj8PWNZFagWdWrTdQF3n7BM=; b=YWfsXTwPfPm5fUTg21tnidC/A1kWjyzsHuUAfiDzkNitJrJk443QRwXrOAHNr+ys8COAHRF2CmdVjajUv69TevrIhCXGEUb2otOfY3Nyl3VubWnoaJsL43z6WyLvyNbFLYAVP4a3J7vwU+cME48KobCQFar4YwGiFOwKJfc+bSNm/jv+Ixup7SpFPxVTXH0TD0MaAbkvhwFaKYvfiBm4Ej41DjObyhRiKHQpDV2ZueH6kTA+2ouOq3Hjb/fNdk3e0PNfOVGlGVgqg4Q5+HqtzYSXrsbiFxms4uPrTXasl42Ebt/2DS6MpJ2b6CwYjeCq1SqrEtRw531pH0nvos4VVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X9t0EgJPcUHOqOm+x5NpCj8PWNZFagWdWrTdQF3n7BM=; b=rWHzvBqOknWVGm1UMp/p4HjWbZTxIxrw1tk/H7eva1cdYovX4OJrBbEgtIkXlV0Epdmnz0d5S1xxG4wqlUxIVXyrjheKM/MPu4/ym2jBkj1gwmep1jMb9QVp2pIJRGJMPNP5dDarZI81AZ6dddWmoYGwSBheDa+M1fUYTFdNSbc= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , Rahul Singh , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Topic: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Thread-Index: AQHYw3lB6B8WhlC/sEygMdr51CFDi63WBOiAgAALjYCAAKlBAA== Date: Fri, 9 Sep 2022 07:46:54 +0000 Message-ID: <0185BE14-D3F6-4C9A-83BD-75FC1B454917@arm.com> References: <63a0010c1e0f6ffb86fce35e188d66bf4c0d57e7.1662637415.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|VE1PR08MB5855:EE_|VE1EUR03FT029:EE_|AM8PR08MB6548:EE_ X-MS-Office365-Filtering-Correlation-Id: 14552290-aa04-4d58-1c57-08da92377fba x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ILGjiRQAr5v8+drV2p6a7AlWpQrYPRI0GUnEgcspElZ8i8/0Sno2sWuaLdO3Ben+ubuMvo2elwv8JglrOZyueCHMsbIrVpQDlKbI3ScZrFLmdFwvgyuyEWJ2RvairY8pWbWWzxILFDiVcCq1F8j6GnrGoG7IdZN+JsN4u9epaFCCBFPSRFzBpAqldZKNw5JG1n3/sfyu1BCvFbOoJg90Q65+5JG+b3GPJ+mIun0CFZe3qWPEEfzqHzNa1mVV7xjYS+T10kYVj+/3J6AF3k46QfJwkO4q2RKk6Gk941TjPQY8lD2y0PY7Oon9w8PrSuguE5xo3qi+/L36vP6dfyVmhpnYvzFvIh9hv7P/jECpmEt3hGWJBQgB2KhmbnsY7ATS1jgR0guhc6IqLeTCOte1WNdeloI3yuX+VdZYPANQVK4JFIZ3UNgTnSYTUIwBy52l1Bh+cWEhxPnl8pzRaZ0yI2c+H/K6KLCwzTL6Io9auPYUcsb4YOe74KOzhDsf6DGwrhjgOeh3GOKFcTlYp3kTymaaTVjEQturLQhAiLmzDgPEgwCkvPYYEpx1oyvZhYmqPzReppIXwjgNLBOQYGQd7BicRU+m7NNXy16kI8zDfPZNN7oSHiejbPRaipRY4I90KSvcDK6kjtanK1DbyldfGLFRcxtVD3lvmuOMfqylL25Nwz1n7d5PU0sUNUg2xGHnUIEIWkt6YGKklXJ8Rey/bPYXUwtSzdvhCvG5Vbjj9xxf7zl/TzdEOrR9SK0ejE04dXSTnYnGvtNeVI8Oqsuo9eUQ2OMzTxr/Zl7L9mnC20s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(38100700002)(86362001)(36756003)(122000001)(4326008)(66446008)(64756008)(76116006)(8676002)(91956017)(66946007)(66476007)(66556008)(38070700005)(33656002)(41300700001)(6512007)(6506007)(26005)(53546011)(478600001)(71200400001)(6486002)(54906003)(6916009)(316002)(186003)(2906002)(2616005)(5660300002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <2CE305C14E5DE645A1EDB914D00DB878@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5855 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d1798764-2c74-4d5f-ac57-08da92377751 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iOEuQXURelnlMBwaBtTzCviidInudkvgw0alGLWhkPy3DrMPpNtH8aOX8yws1IDU8rm1G18s1Ghuwlw10JsX9Qc73WhRoO9RpKh4j5gccA9aCQbxWzZ6J639/VB7gO3j7Py/69xb6P7DPPJM8xbvt56QQ1ApJr7diXjTZF078QuSmgJySkoR6j/NRUuLvosK7Bct9RvSOxzhwSIu2g2atxJ9IJZcnmetLcpJyWfGeR8eax9bm9PBZTrSE/9u7CF8GxMzU3u+FOh2efEeFWaSXSohWSyNNk2CV5sbEdWa50mmLNfakazz4GIxkldwyrbyXfYNRQZbdPEwiIa0QZ0qiGkTC+rcCIFG1GhS38zXO6eX7g8TMSQyGF8QAvCN3DdPRw5OQmhtK/YNvbrNHn00N2PFdWg7gyVuYq9vJy4eG/1EZwbtEbDLq6I+PcD/UW7TsHbMgmAhsnp6154DuaHdbPjI1VYzABqIeqSGPd7zhq3LZMz2iXr8LuXjafigZISG7opYZ2WlXDtREYz+YAu521lVdnkNv21f+xcVYciW2BDKGcPzn8Z4prd+ZKRnERZI4mBS3kfxKJMsGM/pgeHOdcLQAqNZ0l84XcMn+/0mrxuXgF28A5k7r43hTtFMJaR9Te0xNmoMcWZ5xt6T25BKaFfrynnJXHspekU7j/tBRDPwOgXrvuYXkECYXZ+ijkUF2OqfzIhE5Vv+Qp2S/2ZJfbtJAG7gs5QHKd21Zfsjly7mhvQq/F3JuoDwM1QL/s2Dk7m8mOznk/IH4v57UAaTlQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(40470700004)(36840700001)(46966006)(82310400005)(356005)(26005)(2616005)(53546011)(41300700001)(6486002)(6506007)(40460700003)(6512007)(478600001)(36860700001)(186003)(81166007)(6862004)(47076005)(82740400003)(8936002)(86362001)(40480700001)(2906002)(336012)(33656002)(70586007)(316002)(70206006)(36756003)(4326008)(54906003)(5660300002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:47:08.9012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14552290-aa04-4d58-1c57-08da92377fba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6548 Hi, > On 8 Sep 2022, at 22:41, Julien Grall wrote: >=20 > Hi Stefano, >=20 > On 08/09/2022 21:59, Stefano Stabellini wrote: >>> +/* >>> + * TODO: BAR addresses and Root Complex window addresses are not guara= nteed >>> + * to be page aligned. We should check for alignment but this is not t= he >>> + * right place for alignment check. >>> + */ >>> +static int is_bar_valid(const struct dt_device_node *dev, >>> + uint64_t addr, uint64_t len, void *data) >>> +{ >>> + struct pdev_bar_check *bar_data =3D data; >>> + unsigned long s =3D bar_data->start; >>> + unsigned long e =3D bar_data->end; >>> + >>> + if ( (s >=3D addr) && (e <=3D (addr + len - 1)) ) >>> + bar_data->is_valid =3D true; >> "s" and "e" are "unsigned long" while "addr" and "len" are uint64_t. Is >> that OK? >=20 > Good catch. No, physical address on Arm32 can be up to 40 bits. >=20 >> Specifically, considering a potential arm32 case, shouldn't "s" and "e" >> be uint64_t as well? Which means pdev_bar_check.start and end should be >> uint64_t? >=20 > They should be paddr_t which will be 64-bit on both arm32 and arm64. paddr_t sounds a lot better here. @Rahul: Can you send a v6 fixing this ? Thanks Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 07:48:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 07:48:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403890.646158 (Exim 4.92) (envelope-from ) id 1oWYkk-0006sd-K2; Fri, 09 Sep 2022 07:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403890.646158; Fri, 09 Sep 2022 07:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYkk-0006sW-Gz; Fri, 09 Sep 2022 07:48:42 +0000 Received: by outflank-mailman (input) for mailman id 403890; Fri, 09 Sep 2022 07:48:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYki-0006sQ-GJ for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:48:40 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50055.outbound.protection.outlook.com [40.107.5.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d16c5048-3013-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 09:48:39 +0200 (CEST) Received: from FR3P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::11) by GV2PR08MB8293.eurprd08.prod.outlook.com (2603:10a6:150:bf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15; Fri, 9 Sep 2022 07:48:37 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4a:cafe::6c) by FR3P281CA0039.outlook.office365.com (2603:10a6:d10:4a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20 via Frontend Transport; Fri, 9 Sep 2022 07:48:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 07:48:36 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Fri, 09 Sep 2022 07:48:35 +0000 Received: from 39c56538f581.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FEE2F74E-0174-4C0D-AF74-0D551C815022.1; Fri, 09 Sep 2022 07:48:29 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 39c56538f581.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 07:48:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB8627.eurprd08.prod.outlook.com (2603:10a6:10:3d1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 07:48:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5612.018; Fri, 9 Sep 2022 07:48:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d16c5048-3013-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jVusraUOH3iZ/tISpSklAAjMIK9pasPeLUb9SqUPCj+ZbMZpG4eVrBQmoBEVYF+YEBGXdfoxTon17Lfwc3hVxEnHTV7UARR0WwdompA48+AVajooqM86x+kEBI3wm6Ai2VDrTUJjYbVpXSwR+4loCw3zo1imCJwDPlesU0iOlMYldVRBkfkYMWDUGCu997UCSyqplhwRkopTl1VDCRKGJcxAQkTs7v0YLr+1wTf7twwnIInbB/5V0GlNl3AEJPd39X6iPX67AWKj3Q2h6vYw8YvcPVVTwQJH92i04eJ1NNcMs8uqFkZSguwAfpKSzk9FTjFibyism6TJrSD+r4y86w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BXpdL0fXIP6gm/iZrwbFgwzgWBFsNARNpmZG2tI9bzQ=; b=F2k6con5ZIKgzFwMZjv4pb7k0CjCXmkL2z0xOc3InE7/BbB6rTp/apQh7RMcQypNH+g3/bSIoYM3goCO/R6FHjNw3Va1Ind2GcUF3XZ8FAYB19pwW8HKniZSTwv93RbzpI27sSKVxk3ZyWQCMAOkH1w+pTr0Lk6JimstYRTb6+D12qz9SF+mYOqMPeF1kb5xk9wmNRMxauk5g38ipTWopLRQ1lUmL5K6gcLBhKPutFwstu8o4tad/OBpbK/cAt5u4pNR/lscC1ZkoY3QlP1GHk1KZpYxILAMBptIQnxSXiNNjTYqEcTlxfeli6z2F2Met4dXE7quIzjDfY8URrmVLQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BXpdL0fXIP6gm/iZrwbFgwzgWBFsNARNpmZG2tI9bzQ=; b=0BPzusWPTATYuwSPVAb+o9gme6tT5yKpwl/0poe4tzRScXPQfTbhH044fJZv/HRw/qcEco1f7F1yoOqYOXSL13cWwxD35JNsL1mjwDNxEq+Y2no2fnIV0+sZ8thxijuTH3OxWPNOR6J6PIBfDRYrSQlpNyWvwTFzaJUWRg9acWc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3bd6fdbb3868bad4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAIzsIBe5xE186A4wRfvi2gWgaxKCzE2H2Mwh4kRNwz7DXxswKP/WZ47pBFe8T2wOx7c3AmkWtKyCoVP7qKrz8BCYYtJEEoMFxuUaTzNnWKRLE0/xzC0mDb85xBej2b+RsHIz5cVmt+MJzOt8/TDC9s/+dH5/Fd+s935voFuWz1WQfHfeoo5E7lCYjFfNtvSEvSXTeywweL79o0a5NEMNGA0hs1klWjeyrpJV2rviNNAGfbHyk2crOy+vtbEOmbdz4l+gt6gPxEr6LxzZgZWVr72WWQDlugjfXrpU0RW4gIa0/brM/Q3bI9KdAC/qzTAkVkl6tXF6A8Iw/84NfVKPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BXpdL0fXIP6gm/iZrwbFgwzgWBFsNARNpmZG2tI9bzQ=; b=Hsn5jxhEcoO22Ri/0fe+M3bDxH0WGptZPd96F+z5i3BpXreKmxrxdhOXXKeal2SAwceVSn/UerLsHOByd3Ht2OmgSHyT7S2ZjFsHtHpUTqTAJ8x/xJuktcb3YIEB5Ed8IEhap6xuE9aaBLpYOOSXYWNL/AZ84NZIIKW6bxNsWdpjAT49woL8QMxzEQ4nyLHBBKIBHHuyn6Vi3e1FAIf/x/1krSueKo081vGO4d7qd5Py+3e00ZRW9d6q5y7z7R9N1sPGs8gpYEKfo4gch/Yd8Rdjuf/cn4/EZ0e/QQCo1/g2NMY8353kejZfKJAiF4+sZltZy58JMiUUozUP4Xhokg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BXpdL0fXIP6gm/iZrwbFgwzgWBFsNARNpmZG2tI9bzQ=; b=0BPzusWPTATYuwSPVAb+o9gme6tT5yKpwl/0poe4tzRScXPQfTbhH044fJZv/HRw/qcEco1f7F1yoOqYOXSL13cWwxD35JNsL1mjwDNxEq+Y2no2fnIV0+sZ8thxijuTH3OxWPNOR6J6PIBfDRYrSQlpNyWvwTFzaJUWRg9acWc= From: Bertrand Marquis To: Henry Wang CC: Xen developer discussion , Stefano Stabellini , Julien Grall , Wei Chen , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm, device-tree: Make static-mem use #{address,size}-cells Thread-Topic: [PATCH v2] xen/arm, device-tree: Make static-mem use #{address,size}-cells Thread-Index: AQHYxAxmzg40DV+m0E2yYMsfRrvCOK3WuP8A Date: Fri, 9 Sep 2022 07:48:28 +0000 Message-ID: References: <20220909052357.49349-1-Henry.Wang@arm.com> In-Reply-To: <20220909052357.49349-1-Henry.Wang@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB8627:EE_|VE1EUR03FT024:EE_|GV2PR08MB8293:EE_ X-MS-Office365-Filtering-Correlation-Id: d10c43d8-f546-48e1-b0b6-08da9237b3d8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jxvm+AIcNouPz2a7Dad8sFL4xkE+FY6wSBFkx/u7qgb5TfeCFF1Pati9HArKSxuIAkYJyuD0RojN/ltWvRqJyh/ORd+AbB3DGUu9ZYWrmbHuUiBn7uXWc8PSCIruDDpzIjwnoPaEFu91uZGUf4fNDH28AMX+VvtwME/3XjLIX/ZMchDs1HTTgwzJIpyPLQFHYMV9A37Sk6jqExWXtjN2Wr8MVWf7WdQV1+CNB35N8Wgh8bWycXFe/ou3W+Qq+PP6SLlCByWm52Ahqmia9+fLf+6ikKNPzD8tE6Lr21UpFdnrGKvbfmW+BBOXnojJncd1S0pgCDMfXNggQgp7qNoOYLo+EAHf59vpgALw5Qo88Fh9LkEcAl1+602xVqb7gtloX4PNpT/wvU/1oAOVFajJglvDEZC8kQQnJ8S6NgI6D0IKKURpxpz/m3HNz35sddbylXc9+o2IYnB+HebvJAK32o6pIdXYGNB0RaYe0tUdgzNAkMEyAcMeZ85Iii4vl2iBVeiqAEiqSIzBbi608bvCCR6W7NT/V3ksagi4k7zjoeC77h1BAFQBB9Ud/jDdO3cOcv9NUNrzNBM3cnpATuTdyy9W38RbsDutiO7k6XgQ6+EHdkB9ItcaRArm5OANFqOo3j/edLXTrurSrN42sqSn/BxK9fOkBub1tzaa7ZF3iEb2QYr1C17XX8ltINs0t9NTcMhKQ+DmY43mINBD7vg07pVXQSqzSeS+nb2RUnkNG/1qRin1S0ZAnYJO/iHw+2tKI3IUV+AHn9FrVndj8aQo4BVNY0FFm9vD+jZtoMXhra4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(316002)(86362001)(186003)(6636002)(64756008)(66446008)(76116006)(6486002)(8676002)(38070700005)(66946007)(66476007)(66556008)(91956017)(478600001)(4326008)(8936002)(5660300002)(2616005)(6506007)(26005)(41300700001)(6512007)(54906003)(53546011)(36756003)(71200400001)(2906002)(38100700002)(6862004)(37006003)(83380400001)(33656002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8627 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6d06ce10-ecf7-4445-699f-08da9237af21 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6T1j+lYhS4yLAUrEZVDKyXyLqOQBszLrw2NgPsC60nhhUq77A2Hdz3RgeNq/M/XOhExfOml19qLpC+EcJoTHFdojdzERUpSdiszXHUBz0m2XCtxIPr1174BMm06djKpZ4BXRxn9XOEH0ZksVoHzctDrssjKVN5fK302k+XCZ2a0ysC/8c7u2X92uLqzg3ZmBB7lTTr6HaHHdFre2WGER5OrtPZiCUsgfvfrzi/RG8OwfT2fqQzhvIo6wPCEevJUkVnsPMRRcG9YFQdBCUCvpoD7H+dMKySDKTLj5mMtFhvjNkZf2Lx8gCuzCq28o45RXILBO8KA/hWofkSGMbmXOIAhu0Je1WQqQ00f2NAO+oordrcqxoKd+iFtFk1ptbG2psoi8VrgmEykNKj/XxzykTMNkoxhU3dxEyi8CDyRQektIZlq0DU3R1hBRvFVwMTiL2Vpp3SMEI2L/f2VNAspLuADBXHGGumjfoT5EOKXaHHqLT17JNOWwTameoQaUzOF2vUCr25+ENs/bOZQjG/BKH08H1VbZOWYlN893uMtw/jGUqBxEcETC6fDy6YhVS7uk7t+wdB162GMZ8B1a/SIERU6xSWjCgsYUDswsLJdf9QuxmHDsXxHZ9gSFRoLAXKcCYSYIhWC+En9l7uMgo6C6dFEDJy9p6Lraf5iW8FwKDdEpxtYXDn2WTcp7Z2oFKTekm4KsMw9PmYW57YeStYJAa6+2ZwoXBaSNwpcYP1kQQsnDiPYEYPTS7//48s+kmDfxP1PkwATbTQXi583SjP6jww== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(396003)(39860400002)(40470700004)(36840700001)(46966006)(478600001)(4326008)(6636002)(33656002)(70206006)(316002)(70586007)(86362001)(37006003)(54906003)(186003)(82740400003)(83380400001)(336012)(47076005)(40480700001)(107886003)(36860700001)(40460700003)(6512007)(36756003)(26005)(6506007)(5660300002)(82310400005)(356005)(2906002)(53546011)(81166007)(8936002)(2616005)(6862004)(8676002)(41300700001)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:48:36.3275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d10c43d8-f546-48e1-b0b6-08da9237b3d8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8293 Hi Henry, > On 9 Sep 2022, at 06:23, Henry Wang wrote: >=20 > In order to keep consistency in the device tree binding, there is > no need for static memory allocation feature to define a specific > set of address and size cells for "xen,static-mem" property. >=20 > Therefore, this commit reuses the regular #{address,size}-cells > for parsing the device tree "xen,static-mem" property. Update > the documentation accordingly. >=20 > Also, take the chance to remove the unnecessary "#address-cells" > and "#size-cells" in the domU1 node of the device tree to only > emphasize the related part that the example is showing. >=20 > Signed-off-by: Henry Wang Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes from v1 to v2: > - Remove the "----" addition, as it is unnecessary to this patch. > - Mention the removal of #address-cells and #size-cells in domU1 > node in the commit message. > --- > docs/misc/arm/device-tree/booting.txt | 11 +++++------ > docs/misc/arm/passthrough-noiommu.txt | 7 +++---- > xen/arch/arm/bootfdt.c | 5 ----- > xen/arch/arm/domain_build.c | 16 ++-------------- > 4 files changed, 10 insertions(+), 29 deletions(-) >=20 > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device= -tree/booting.txt > index 5395a1077c..10caf4f1af 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -350,8 +350,8 @@ areas are pre-defined by configuration using physical= address ranges. >=20 > Memory can be statically allocated to a domain using the property "xen,st= atic- > mem" defined in the domain configuration. The number of cells for the add= ress > -and the size must be defined using respectively the properties > -"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". > +and the size must be defined respectively by the parent node properties > +"#address-cells" and "#size-cells". >=20 > The property 'memory' is still needed and should match the amount of memo= ry > given to the guest. Currently, it either comes from static memory or lets= Xen > @@ -366,14 +366,13 @@ device-tree: >=20 > / { > chosen { > + #address-cells =3D <0x1>; > + #size-cells =3D <0x1>; > + ... > domU1 { > compatible =3D "xen,domain"; > - #address-cells =3D <0x2>; > - #size-cells =3D <0x2>; > cpus =3D <2>; > memory =3D <0x0 0x80000>; > - #xen,static-mem-address-cells =3D <0x1>; > - #xen,static-mem-size-cells =3D <0x1>; > xen,static-mem =3D <0x30000000 0x20000000>; > ... > }; > diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passth= rough-noiommu.txt > index 3e2ef21ad7..69b8de1975 100644 > --- a/docs/misc/arm/passthrough-noiommu.txt > +++ b/docs/misc/arm/passthrough-noiommu.txt > @@ -33,14 +33,13 @@ on static allocation in the device-tree: >=20 > / { > chosen { > + #address-cells =3D <0x1>; > + #size-cells =3D <0x1>; > + ... > domU1 { > compatible =3D "xen,domain"; > - #address-cells =3D <0x2>; > - #size-cells =3D <0x2>; > cpus =3D <2>; > memory =3D <0x0 0x80000>; > - #xen,static-mem-address-cells =3D <0x1>; > - #xen,static-mem-size-cells =3D <0x1>; > xen,static-mem =3D <0x30000000 0x20000000>; > direct-map; > ... > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 9e1ea60094..59675f086b 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -370,11 +370,6 @@ static int __init process_domain_node(const void *fd= t, int node, > /* No "xen,static-mem" present. */ > return 0; >=20 > - address_cells =3D device_tree_get_u32(fdt, node, > - "#xen,static-mem-address-cells",= 0); > - size_cells =3D device_tree_get_u32(fdt, node, > - "#xen,static-mem-size-cells", 0); > - > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_c= ells, > size_cells, &bootinfo.reserved_mem, > MEMBANK_STATIC_DOMAIN); > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7412303d20..9040a8c6cb 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -565,21 +565,9 @@ static int __init parse_static_mem_prop(const struct= dt_device_node *node, > const struct dt_property *prop; >=20 > prop =3D dt_find_property(node, "xen,static-mem", NULL); > - if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", > - addr_cells) ) > - { > - printk(XENLOG_ERR > - "failed to read \"#xen,static-mem-address-cells\".\n"); > - return -EINVAL; > - } >=20 > - if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", > - size_cells) ) > - { > - printk(XENLOG_ERR > - "failed to read \"#xen,static-mem-size-cells\".\n"); > - return -EINVAL; > - } > + *addr_cells =3D dt_n_addr_cells(node); > + *size_cells =3D dt_n_size_cells(node); >=20 > *cell =3D (const __be32 *)prop->value; > *length =3D prop->length; > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 08:10:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 08:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403911.646169 (Exim 4.92) (envelope-from ) id 1oWZ5B-0002Jg-Vi; Fri, 09 Sep 2022 08:09:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403911.646169; Fri, 09 Sep 2022 08:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZ5B-0002JZ-Sv; Fri, 09 Sep 2022 08:09:49 +0000 Received: by outflank-mailman (input) for mailman id 403911; Fri, 09 Sep 2022 08:09:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZ5A-0002JT-1O for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 08:09:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c482408d-3016-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 10:09:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF9331F8ED; Fri, 9 Sep 2022 08:09:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99222139D5; Fri, 9 Sep 2022 08:09:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zytxI8n0GmNwQAAAMHmgww (envelope-from ); Fri, 09 Sep 2022 08:09:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c482408d-3016-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662710985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=C77PM0r5Nmstj5eEefW3kaBEN4SowKo/1tOewXmIhn0=; b=jdqbuTeZtPzEj3soICIcf1IvFtjNcsc4rbmzS2uF9ozUjVsURcKJmN5+fX4Z646U4xrxQg sTftlFpKYaYYI0kn9OmjyrGfRxGoBuGXomsGkLkVRGY9KUSPDUcM4d180DL9Vyx3wcM1P1 7LPUVeH8Be7e7n7cC5QgfOxQ2RJjuHg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Date: Fri, 9 Sep 2022 10:09:44 +0200 Message-Id: <20220909080944.28559-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") was wrong, as vaddr can legitimately be NULL in case XENMEM_resource_grant_table_id_status was specified for a grant table v1. This would result in crashes in debug builds due to ASSERT_UNREACHABLE() triggering. Basically revert said commit, but keep returning -ENODATA in that case. Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") Signed-off-by: Juergen Gross --- Might be considered for 4.17 and for backporting --- xen/common/grant_table.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index ad773a6996..68e7f1df38 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4125,7 +4125,10 @@ int gnttab_acquire_resource( case XENMEM_resource_grant_table_id_status: if ( gt->gt_version != 2 ) + { + rc = -ENODATA; break; + } /* Check that void ** is a suitable representation for gt->status. */ BUILD_BUG_ON(!__builtin_types_compatible_p( @@ -4135,17 +4138,6 @@ int gnttab_acquire_resource( break; } - /* - * Some older toolchains can't spot that vaddrs won't remain uninitialized - * on non-error paths, and hence it needs setting to NULL at the top of the - * function. Leave some runtime safety. - */ - if ( !vaddrs ) - { - ASSERT_UNREACHABLE(); - rc = -ENODATA; - } - /* Any errors? Bad id, or from growing the table? */ if ( rc ) goto out; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 08:48:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 08:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403920.646186 (Exim 4.92) (envelope-from ) id 1oWZgP-0007QD-2C; Fri, 09 Sep 2022 08:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403920.646186; Fri, 09 Sep 2022 08:48:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZgO-0007Q6-TT; Fri, 09 Sep 2022 08:48:16 +0000 Received: by outflank-mailman (input) for mailman id 403920; Fri, 09 Sep 2022 08:48:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZgM-0007Q0-GV for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 08:48:14 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 191eee47-301c-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 10:47:56 +0200 (CEST) Received: from DB6PR0802CA0044.eurprd08.prod.outlook.com (2603:10a6:4:a3::30) by AS1PR08MB7561.eurprd08.prod.outlook.com (2603:10a6:20b:470::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 08:48:05 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::ae) by DB6PR0802CA0044.outlook.office365.com (2603:10a6:4:a3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Fri, 9 Sep 2022 08:48:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 08:48:05 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 09 Sep 2022 08:48:05 +0000 Received: from 9f49eb945789.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 533C5D48-966B-425A-B70D-FEB36666D608.1; Fri, 09 Sep 2022 08:47:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f49eb945789.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 08:47:59 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5725.eurprd08.prod.outlook.com (2603:10a6:800:1b0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 08:47:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 9 Sep 2022 08:47:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 191eee47-301c-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=I8a9UnKVbTR85PvoEVhbLae/AVHvVbyFw7rXgoYUGNBXYoDySuI9fX0UklJnDNtPIs8EvIvQRSp+NNV9Z6Loyx4k8R7DY8ZwgwZCpTS0IxXjGVz18GSAVeEFP76iyyr8Xi6WDyZOjJbe+HNSx6i8wv6ZAWd7b6X7aaGasLZBhgHfUYgPi5U3n6WR+H/ENILi3aXsRJptOyhKw47R1UzEvTYKGjUQbNNiZpqQSTYpM12ujrFVDRtdctVQQz9EEpEp36xjzRgtDzStiqtFKY6cU5DDAtoNY8eIDDzg72CXpGzaWV/fOL2431RcL9bAr71q0xNeZRGTv5ngJNxLjW4gWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dUFCoM03gkskNqqdPwVSdN/jE1pWbq6byaxesKdkOQ=; b=ehklOCvQZ1jUXiu40ON46JxVRRf3t/gGRbF49/BoBvy2tE37KvJzF3+W9ONk7j8jS+/ewp0njOj+iRo7ST/Ef8buTupIKU6VpLkpWs1VYPDRG5HIu+E5H8pPgGfiXDELOfPN4ny9+FiG+vkiCNpGhxH0ascssHxOaNyyXWKE8lrx0ZebXe2pe2vYZPeZzKzasZ+fakmDU+yT66jBRQXPziYOn4w5w+3+rbWN+O9gBsI3qx/8W9K0ChkyaMPVynXHS7Buta2wUjmQ9g/uQtTo45JGq2d6xHaB3rO+8n9BCpZsU6UozotH2In/YgwqwSaTYfm/nRzKWIyQXSr1gaY7DA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dUFCoM03gkskNqqdPwVSdN/jE1pWbq6byaxesKdkOQ=; b=tFRZOqOIno+/RjN+sv8KLuwj0NZdagIaz/+zEHtOxxpNp4FXeDHRsnNQbr5lzBjJbQUnq4pQTlnqdFAh4W9A1fqvBsi0pI+ktMYD7HEn2hY+lOvr7ZXuu41G5dCSf4Bwrm0nTmm0dgJIDXVLRzp1r0H6HXWxUBnlWuGfnpK2u2I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2mEUgGFw9e0diKB0OK6ux5fRjV1NkRtwy/nZaZ8Me9xnR6eWptGZ7BnXjlqqaphmm3UsC0V5uBDbw9HK/VWN/W+7uaDEBkokCgH6PQb05/dOxIbztEIOk4b6s4ZBnaG8TP6f7ELrXQl1D9wFtL8jauKfOYOxjaWIBZtWXN4z4pybSPaQxQjrHDXEkgnw+YQrEG8TLLdqzI43CEBIOLqXXaKQeDFFeO4yhohkzqaZhzQweBylCx6MFAKdOHSTeskEE5dbzCQsP8xOS+fey6k0b5H0zHm091tmkCTd9mr4SCiUD/n7HT/uQnd6peQgFVs35hfzcYbPqOx3wfrHmVYCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dUFCoM03gkskNqqdPwVSdN/jE1pWbq6byaxesKdkOQ=; b=UZc/eoRaFPEyP6s0VgwQd9+QbQjFJY7kCjXsYLh0L44agmxPo7jziTRQF3XE7RRZVHo/LKloBbcUfl48PIUACZ1Vs8l5O8q4FNBsu6wGSn4enti9YzdIm1PMGVuI/lV3cQXmer6Ab2+XC2cQd2l/KvCcZJnZYqZDgl56Zg7M5Yhg1t+0c1wzisPxbSQ2vR7cvjE5f5RBQ936WR1GH6vrB0dTinIAeB/nimLlwTuSY0ppTDDHbb+kMdnc5D6wQyz1HCypDf6o2w6jsRotlbHYaY6LuOl54jlMiJs7oEYAOEOwO+cbaki7i2KYIWEmk1pLbIV8aO86JK9aTqeO6aVDeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dUFCoM03gkskNqqdPwVSdN/jE1pWbq6byaxesKdkOQ=; b=tFRZOqOIno+/RjN+sv8KLuwj0NZdagIaz/+zEHtOxxpNp4FXeDHRsnNQbr5lzBjJbQUnq4pQTlnqdFAh4W9A1fqvBsi0pI+ktMYD7HEn2hY+lOvr7ZXuu41G5dCSf4Bwrm0nTmm0dgJIDXVLRzp1r0H6HXWxUBnlWuGfnpK2u2I= From: Henry Wang To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Topic: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Index: AQHYxCOLeMow4nnAdEmRQz42iuSBI63Wx2cg Date: Fri, 9 Sep 2022 08:47:56 +0000 Message-ID: References: <20220909080944.28559-1-jgross@suse.com> In-Reply-To: <20220909080944.28559-1-jgross@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 095221FFA4D56443AA0EEAE590DBF937.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a5027476-f259-4e4c-9339-08da92400305 x-ms-traffictypediagnostic: VE1PR08MB5725:EE_|DBAEUR03FT037:EE_|AS1PR08MB7561:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZSi9sNTO3SJ6EjXI+oS8Z6qjRTy5KuMuGVSVIqymbBn9anWT5i8zo+nq4LhGKN9yonYYRTAZ6JeILeisrFdvJWJ/L9XYAWyAGwW6EK0czsKIb4Q2DEL0fjEpwUA6gHwyNE0aI7+nXPS4emq7oXclZT7qB7PD6VppiUqP3B/s1kdVJR7vD/2ScOTXCtW3wwhSHpbkyjnma3onval4XqSelyeD5aHXre3Ba4oWOXWdBQxSqIIa9FxsCuqR/De0BmQO28CGC3HN0q2FzzGM5LzQwTeyvMZAczAE8kSgYPWC9w+MJmAqGfa3L6BYxIrqSgt/SEqQe+XLNI7obhFc16ifts2i/Ioc2Jdzyn9c8Ja+7kVOTjErk2V+0N0RJz+TkLOELyMyD0vW0yxLeMEU1eMkAKOZNlsLS10HmZ+BPC7wBSqjFy5T8m23dTZt0ISSsbPmkmyG9MH39MeJuJEDYeXQzV7c7HOfXZ4spzqPOsaCtyepZBhffXQN/8x0+OvW4yV6126ejYQLNMw6CgO/IQxyUcW/BRspwqql4wKyUGuW60oVkOiXa79+DZ/vdm6ckIRn9xp8GqJVHDxgwJZWXV8Jlwb+B01WCQTpqpkrD+OO1oE3Me9gOHu7PRCw6X++lQh9URV4mKOSgbpOZBllx4aKP4QIVhUChB9ploDnqpDXEMNhwoxNutd8M3hvynnoK0eE7BO+BRazMUspNgAQlzDHylR8YOEKrhNyQapPheG3rqFq+1tySZLacUfrAlF9HrO76c8lDOv1bPrbXEb6PTovgA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(6506007)(4744005)(4326008)(86362001)(8676002)(64756008)(66556008)(66946007)(76116006)(478600001)(66446008)(186003)(8936002)(7696005)(52536014)(33656002)(5660300002)(66476007)(55016003)(71200400001)(2906002)(41300700001)(110136005)(316002)(9686003)(26005)(54906003)(83380400001)(38070700005)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5725 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dcddcc6e-4c40-4f8e-378c-08da923ffd8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pb0xorxDF5VxfuroW8PatXmjimuoac+6zysF5UhzRe1BfuWchc3hqtNQsYdRqDfStTAUSMTKgFS54jRhcA+gcUJq3VyjdF8CArQNZNMDkMdwkNJqO6f6Gn+3gK9AUjYKEp+sevc0rcN4YHtBPbx18EA3gtsANjgEIYavsD9O9ABtzv/qiIND+C8HPc/dQUnjAdbNRvGwa9nyh0Q11xlvaCcJH73SXO4yatBQ6DWPLdyABA4A+pPyKO3xPvzzG7nX0jPg+f6IBdUmiixUvleR+MV0bwBnEqv0CPk/ExNJwCm8S792w/sWij7MZ+0gOmjp8b/oAJmNXNlw9NVy/VLJ6PHYZ0FzKtHyTI5ja9+fAD0aCNoq+/PFGv87feoqf+i91PEtGcnvZieNN3Ysbu4J+tNAE7ySD9bD95zynhgM8u5eUTXzIymtfbzOT91F3eQd3E0qAJmQxA5NwqfDZ8NrqdG3b8vgYbgaWLL01Mxa4oay0qm6/Voba8rnlm1bWjRN5WBvK630QEjWVigB9FlHQyv/0tH69Wg9J0FPN0qiTsw87ScEj7cLJ/vlSp/EECD42+V1koZnyBPkIB40OLevQH62HE5OR8Jo1xFnmVoKrXyagn8rB7VGb93r7zl7qt4CH9h5UH21e77Pdb3TH4LiL0BWBguvOeaU8KdkpdBFEXSgLhZVkb0iOPtFx+LrPFoPRHBHYjEQIo/4qA6C4BWLSplW0vuNFPK/aQG5invigLffKiXuzGy/ZJsHYbfTWEenBZ2zFDYlDWTAr8GTyFN1cQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(39860400002)(136003)(46966006)(40470700004)(36840700001)(4326008)(47076005)(70586007)(336012)(4744005)(8936002)(5660300002)(52536014)(8676002)(2906002)(70206006)(33656002)(26005)(86362001)(9686003)(7696005)(82310400005)(478600001)(186003)(40480700001)(41300700001)(55016003)(6506007)(83380400001)(40460700003)(81166007)(356005)(36860700001)(316002)(110136005)(82740400003)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 08:48:05.2449 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5027476-f259-4e4c-9339-08da92400305 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7561 Hi Juergen, > -----Original Message----- > From: Juergen Gross > Subject: [PATCH] xen/gnttab: fix gnttab_acquire_resource() >=20 > Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" > warning") was wrong, as vaddr can legitimately be NULL in case > XENMEM_resource_grant_table_id_status was specified for a grant table > v1. This would result in crashes in debug builds due to > ASSERT_UNREACHABLE() triggering. >=20 > Basically revert said commit, but keep returning -ENODATA in that case. >=20 > Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" > warning") > Signed-off-by: Juergen Gross > --- > Might be considered for 4.17 and for backporting Of course, feel free to add: Release-acked-by: Henry Wang If the maintainer give an ack about this patch. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Sep 09 08:51:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 08:51:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403927.646197 (Exim 4.92) (envelope-from ) id 1oWZjg-0000fT-Ex; Fri, 09 Sep 2022 08:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403927.646197; Fri, 09 Sep 2022 08:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZjg-0000fM-CI; Fri, 09 Sep 2022 08:51:40 +0000 Received: by outflank-mailman (input) for mailman id 403927; Fri, 09 Sep 2022 08:51:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZjf-0000fC-N2; Fri, 09 Sep 2022 08:51:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZjf-0005Dm-Ia; Fri, 09 Sep 2022 08:51:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZjf-0005nt-66; Fri, 09 Sep 2022 08:51:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWZjf-0001zt-5d; Fri, 09 Sep 2022 08:51:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MOEnCpm9gt8dGMK3YsLQuAW5KUJ84SujQPMnvB4rIHY=; b=k5qVdzi6+F4lpyGF6ngCf96k6o 8/vjkiS3cG50SHkn4h0cEaOJKzbRmcsP4ACu7zgQAqGLQbaFEBYcVzV7rFkTlqD62Gq8OxdujFVMK gy2PR490y9pERNGKI4sIjxIbk7RylAM+YnuNkkBGeVrNmk/ns1OlUCOwzT6+p+eV/uYA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173074: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 09 Sep 2022 08:51:39 +0000 flight 173074 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173074/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 173060 pass in 173074 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 173060 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 36 days Failing since 172148 2022-08-04 21:39:38 Z 35 days 80 attempts Testing same since 173060 2022-09-08 07:34:59 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 08:57:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 08:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403939.646208 (Exim 4.92) (envelope-from ) id 1oWZor-0001Nn-6c; Fri, 09 Sep 2022 08:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403939.646208; Fri, 09 Sep 2022 08:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZor-0001Ng-30; Fri, 09 Sep 2022 08:57:01 +0000 Received: by outflank-mailman (input) for mailman id 403939; Fri, 09 Sep 2022 08:56:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZop-0001Na-S5 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 08:56:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZop-0005KC-DN; Fri, 09 Sep 2022 08:56:59 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWZop-0006yR-6I; Fri, 09 Sep 2022 08:56:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=X8IeEzZiX4kZhRhfnqCdLGEjuWqQLlCu96zT2ODmSq4=; b=zX8swPbHbpZ+cqXu9iYgskodw2 dNNjvMKl3paUV1TMBT0M663Ns/BMzWBAbcyyzCrnXB76bi4viceqEk936hbPOOLFNAWuk3jUvIiAs saYlVVERtVb/bxdH09j+41RbkqdzxRZyeHyoiuCFRfBH9BqjhQhw1iSVQZdXIJ6dv48Y=; Message-ID: <689f7d26-b691-56de-7adb-dfb6480e7469@xen.org> Date: Fri, 9 Sep 2022 09:56:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220909080944.28559-1-jgross@suse.com> From: Julien Grall In-Reply-To: <20220909080944.28559-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 09/09/2022 09:09, Juergen Gross wrote: > Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" > warning") was wrong, as vaddr can legitimately be NULL in case > XENMEM_resource_grant_table_id_status was specified for a grant table > v1. This would result in crashes in debug builds due to > ASSERT_UNREACHABLE() triggering. > > Basically revert said commit, but keep returning -ENODATA in that case. This commit was introduced to silence a compiler warning (treated as error in Xen build system). As you revert it, did you check the said compiler (IIRC GCC 4.3) was still happy? > Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") > Signed-off-by: Juergen Gross > --- > Might be considered for 4.17 and for backporting > --- > xen/common/grant_table.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c > index ad773a6996..68e7f1df38 100644 > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -4125,7 +4125,10 @@ int gnttab_acquire_resource( > > case XENMEM_resource_grant_table_id_status: > if ( gt->gt_version != 2 ) > + { > + rc = -ENODATA; > break; > + } > > /* Check that void ** is a suitable representation for gt->status. */ > BUILD_BUG_ON(!__builtin_types_compatible_p( > @@ -4135,17 +4138,6 @@ int gnttab_acquire_resource( > break; > } > > - /* > - * Some older toolchains can't spot that vaddrs won't remain uninitialized > - * on non-error paths, and hence it needs setting to NULL at the top of the > - * function. Leave some runtime safety. > - */ > - if ( !vaddrs ) > - { > - ASSERT_UNREACHABLE(); > - rc = -ENODATA; > - } > - > /* Any errors? Bad id, or from growing the table? */ > if ( rc ) > goto out; Looking at the code just below the loop is: for ( i = 0; i < nr_frames; ++i ) mfn_list[i] = virt_to_mfn(vaddrs[frame + 1]); Given that 'nr_frames' is provided by the caller it is a bit unclear how we guarantee that 'vaddrs' will not be NULL when nr_frames > 0. Can you explain how you came to the conclusion that this is not possible? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:05:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:05:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403946.646219 (Exim 4.92) (envelope-from ) id 1oWZwL-0003CQ-VG; Fri, 09 Sep 2022 09:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403946.646219; Fri, 09 Sep 2022 09:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZwL-0003CJ-Rj; Fri, 09 Sep 2022 09:04:45 +0000 Received: by outflank-mailman (input) for mailman id 403946; Fri, 09 Sep 2022 09:04:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZwL-0003CD-02 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:04:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWZwK-0005UQ-1c; Fri, 09 Sep 2022 09:04:44 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWZwJ-0007RK-Rc; Fri, 09 Sep 2022 09:04:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dxdz9bYcxibHtpA4dSaMTjGhqAloKbcBGjdm6eAbM4k=; b=s7DvgpLK2mBYKww1vLRikMAUsf WiJROxtJatjIt0LRFqpRS+DVLDY+/bZ6zFTqarsq90/BzVGAFNpeJG9E6WPAGhHSYC8T5eJsd8IhW wsLVIlv6qmwSJMLfrLFVGVJaCL3ydS/N69IZ0TfAfglhCiqTUfBV7bhdekLwcUaveuRs=; Message-ID: <29e45aa2-910e-33ae-cdaa-be2f9e9d2942@xen.org> Date: Fri, 9 Sep 2022 10:04:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Henry Wang , Juergen Gross , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220909080944.28559-1-jgross@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 09/09/2022 09:47, Henry Wang wrote: >> -----Original Message----- >> From: Juergen Gross >> Subject: [PATCH] xen/gnttab: fix gnttab_acquire_resource() >> >> Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" >> warning") was wrong, as vaddr can legitimately be NULL in case >> XENMEM_resource_grant_table_id_status was specified for a grant table >> v1. This would result in crashes in debug builds due to >> ASSERT_UNREACHABLE() triggering. >> >> Basically revert said commit, but keep returning -ENODATA in that case. >> >> Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" >> warning") >> Signed-off-by: Juergen Gross >> --- >> Might be considered for 4.17 and for backporting > > Of course, feel free to add: > > Release-acked-by: Henry Wang Unrelated to this patch, but as this is your first Released-acked-by tag, I wanted to check the policy going forward. From now, will any new patch need your approval before been merged? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:08:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403953.646230 (Exim 4.92) (envelope-from ) id 1oWa0G-0003pi-FR; Fri, 09 Sep 2022 09:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403953.646230; Fri, 09 Sep 2022 09:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa0G-0003pb-CO; Fri, 09 Sep 2022 09:08:48 +0000 Received: by outflank-mailman (input) for mailman id 403953; Fri, 09 Sep 2022 09:08:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa0E-0003pS-K8 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:08:46 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8f6b35b-301e-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:08:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CCEF9225EC; Fri, 9 Sep 2022 09:08:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8336F139D5; Fri, 9 Sep 2022 09:08:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KCGBHpwCG2N5WAAAMHmgww (envelope-from ); Fri, 09 Sep 2022 09:08:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8f6b35b-301e-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662714524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mc68v7mdvAfeGm7Rus62jf7uy6bSn4spc43rQoZUiWo=; b=F92mVjJE/eUIEMtLEsFm/YdT8UgY4P3uRtbOBmFuLBSkukFD+/hNyBDlgK70JoMjEFA4xt Ki0a/fZgrT9NFB/UyubrHD8y9/kOVNTacwhAH6jeTi5QzXLdLwsxQrv7sf4cyO8KTevuv+ v3laN6RT/CGM/qQovLS/Ajfm72IvH4M= Message-ID: <2a32d8ed-14bc-192b-a2ce-6457490b182e@suse.com> Date: Fri, 9 Sep 2022 11:08:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220909080944.28559-1-jgross@suse.com> <689f7d26-b691-56de-7adb-dfb6480e7469@xen.org> From: Juergen Gross Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() In-Reply-To: <689f7d26-b691-56de-7adb-dfb6480e7469@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9744SflxtvLQiALZy1FW5lhD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9744SflxtvLQiALZy1FW5lhD Content-Type: multipart/mixed; boundary="------------Wbn0X0z07URzJDpBs1bxoVDJ"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: <2a32d8ed-14bc-192b-a2ce-6457490b182e@suse.com> Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() References: <20220909080944.28559-1-jgross@suse.com> <689f7d26-b691-56de-7adb-dfb6480e7469@xen.org> In-Reply-To: <689f7d26-b691-56de-7adb-dfb6480e7469@xen.org> --------------Wbn0X0z07URzJDpBs1bxoVDJ Content-Type: multipart/mixed; boundary="------------SJkSGzaxDmtoARz0l0M8cuK9" --------------SJkSGzaxDmtoARz0l0M8cuK9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDkuMjIgMTA6NTYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA5LzA5LzIwMjIgMDk6MDksIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBD b21taXQgOWRjNDYzODZkODlkICgiZ250dGFiOiB3b3JrIGFyb3VuZCAibWF5IGJlIHVzZWQg dW5pbml0aWFsaXplZCINCj4+IHdhcm5pbmciKSB3YXMgd3JvbmcsIGFzIHZhZGRyIGNhbiBs ZWdpdGltYXRlbHkgYmUgTlVMTCBpbiBjYXNlDQo+PiBYRU5NRU1fcmVzb3VyY2VfZ3JhbnRf dGFibGVfaWRfc3RhdHVzIHdhcyBzcGVjaWZpZWQgZm9yIGEgZ3JhbnQgdGFibGUNCj4+IHYx LiBUaGlzIHdvdWxkIHJlc3VsdCBpbiBjcmFzaGVzIGluIGRlYnVnIGJ1aWxkcyBkdWUgdG8N Cj4+IEFTU0VSVF9VTlJFQUNIQUJMRSgpIHRyaWdnZXJpbmcuDQo+Pg0KPj4gQmFzaWNhbGx5 IHJldmVydCBzYWlkIGNvbW1pdCwgYnV0IGtlZXAgcmV0dXJuaW5nIC1FTk9EQVRBIGluIHRo YXQgY2FzZS4NCj4gDQo+IFRoaXMgY29tbWl0IHdhcyBpbnRyb2R1Y2VkIHRvIHNpbGVuY2Ug YSBjb21waWxlciB3YXJuaW5nICh0cmVhdGVkIGFzIGVycm9yIGluIA0KPiBYZW4gYnVpbGQg c3lzdGVtKS4gQXMgeW91IHJldmVydCBpdCwgZGlkIHlvdSBjaGVjayB0aGUgc2FpZCBjb21w aWxlciAoSUlSQyBHQ0MgDQo+IDQuMykgd2FzIHN0aWxsIGhhcHB5Pw0KDQpJIGRpZG4ndCBy ZW1vdmUgdGhlIHZhZGRyIGluaXRpYWxpemVyLg0KDQo+IA0KPj4gRml4ZXM6IDlkYzQ2Mzg2 ZDg5ZCAoImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQi IHdhcm5pbmciKQ0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuY29tPg0KPj4gLS0tDQo+PiBNaWdodCBiZSBjb25zaWRlcmVkIGZvciA0LjE3IGFuZCBm b3IgYmFja3BvcnRpbmcNCj4+IC0tLQ0KPj4gwqAgeGVuL2NvbW1vbi9ncmFudF90YWJsZS5j IHwgMTQgKysrLS0tLS0tLS0tLS0NCj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDExIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9u L2dyYW50X3RhYmxlLmMgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMNCj4+IGluZGV4IGFk NzczYTY5OTYuLjY4ZTdmMWRmMzggMTAwNjQ0DQo+PiAtLS0gYS94ZW4vY29tbW9uL2dyYW50 X3RhYmxlLmMNCj4+ICsrKyBiL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYw0KPj4gQEAgLTQx MjUsNyArNDEyNSwxMCBAQCBpbnQgZ250dGFiX2FjcXVpcmVfcmVzb3VyY2UoDQo+PiDCoMKg wqDCoMKgIGNhc2UgWEVOTUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lkX3N0YXR1czoNCj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIGd0LT5ndF92ZXJzaW9uICE9IDIgKQ0KPj4gK8Kg wqDCoMKgwqDCoMKgIHsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJjID0gLUVOT0RB VEE7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBicmVhazsNCj4+ICvCoMKgwqDC oMKgwqDCoCB9DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLyogQ2hlY2sgdGhhdCB2b2lkICoq IGlzIGEgc3VpdGFibGUgcmVwcmVzZW50YXRpb24gZm9yIGd0LT5zdGF0dXMuICovDQo+PiDC oMKgwqDCoMKgwqDCoMKgwqAgQlVJTERfQlVHX09OKCFfX2J1aWx0aW5fdHlwZXNfY29tcGF0 aWJsZV9wKA0KPj4gQEAgLTQxMzUsMTcgKzQxMzgsNiBAQCBpbnQgZ250dGFiX2FjcXVpcmVf cmVzb3VyY2UoDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgYnJlYWs7DQo+PiDCoMKgwqDCoMKg IH0NCj4+IC3CoMKgwqAgLyoNCj4+IC3CoMKgwqDCoCAqIFNvbWUgb2xkZXIgdG9vbGNoYWlu cyBjYW4ndCBzcG90IHRoYXQgdmFkZHJzIHdvbid0IHJlbWFpbiB1bmluaXRpYWxpemVkDQo+ PiAtwqDCoMKgwqAgKiBvbiBub24tZXJyb3IgcGF0aHMsIGFuZCBoZW5jZSBpdCBuZWVkcyBz ZXR0aW5nIHRvIE5VTEwgYXQgdGhlIHRvcCBvZiB0aGUNCj4+IC3CoMKgwqDCoCAqIGZ1bmN0 aW9uLsKgIExlYXZlIHNvbWUgcnVudGltZSBzYWZldHkuDQo+PiAtwqDCoMKgwqAgKi8NCj4+ IC3CoMKgwqAgaWYgKCAhdmFkZHJzICkNCj4+IC3CoMKgwqAgew0KPj4gLcKgwqDCoMKgwqDC oMKgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPj4gLcKgwqDCoMKgwqDCoMKgIHJjID0gLUVO T0RBVEE7DQo+PiAtwqDCoMKgIH0NCj4+IC0NCj4+IMKgwqDCoMKgwqAgLyogQW55IGVycm9y cz/CoCBCYWQgaWQsIG9yIGZyb20gZ3Jvd2luZyB0aGUgdGFibGU/ICovDQo+PiDCoMKgwqDC oMKgIGlmICggcmMgKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gb3V0Ow0KPiANCj4g TG9va2luZyBhdCB0aGUgY29kZSBqdXN0IGJlbG93IHRoZSBsb29wIGlzOg0KPiANCj4gZm9y ICggaSA9IDA7IGkgPCBucl9mcmFtZXM7ICsraSApDQo+ICDCoMKgIG1mbl9saXN0W2ldID0g dmlydF90b19tZm4odmFkZHJzW2ZyYW1lICsgMV0pOw0KPiANCj4gR2l2ZW4gdGhhdCAnbnJf ZnJhbWVzJyBpcyBwcm92aWRlZCBieSB0aGUgY2FsbGVyIGl0IGlzIGEgYml0IHVuY2xlYXIg aG93IHdlIA0KPiBndWFyYW50ZWUgdGhhdCAndmFkZHJzJyB3aWxsIG5vdCBiZSBOVUxMIHdo ZW4gbnJfZnJhbWVzID4gMC4NCj4gDQo+IENhbiB5b3UgZXhwbGFpbiBob3cgeW91IGNhbWUg dG8gdGhlIGNvbmNsdXNpb24gdGhhdCB0aGlzIGlzIG5vdCBwb3NzaWJsZT8NCg0KV2UgY2Fu IHJlYWNoIHRoaXMgcG9pbnQgb25seSBpbiBjYXNlIHJjIGlzIDAuDQoNCnJjIGNhbiBiZSAw IG9ubHkgaW4gY2FzZSBnbnR0YWJfZ2V0X3NoYXJlZF9mcmFtZV9tZm4oKSBvcg0KZ250dGFi X2dldF9zdGF0dXNfZnJhbWVfbWZuKCkgcmV0dXJuZWQgMCwgd2hpY2ggd2lsbCBiZSB0aGUg Y2FzZSBvbmx5LCBpZg0KdGhlIHZhbHVlIHZhZGRycyB3YXMgc2V0IHRvIGJlZm9yZSBjYWxs aW5nIHRob3NlIGZ1bmN0aW9ucyB3YXMgdmFsaWQuDQoNCg0KSnVlcmdlbg0K --------------SJkSGzaxDmtoARz0l0M8cuK9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------SJkSGzaxDmtoARz0l0M8cuK9-- --------------Wbn0X0z07URzJDpBs1bxoVDJ-- --------------9744SflxtvLQiALZy1FW5lhD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMbApwFAwAAAAAACgkQsN6d1ii/Ey/6 dQf/Rmv3P3JCzMU9N5sIHt0ltQP1L1h2yFsKfQP3Kck9k9X10mb77ZVUnEtwC2VLbTA/lKoQjsvf LFN5+hGzXOrfzg6e3Pxz4E+yiZLKgJ17FdOZkqhfuQk3xTa3ovqxnlCxgK3jmLLMeVCRFJ79G1Y7 jIJXBH+zE3FI+A9wrH/q8+388LskDcRBZXtK2PS4tfrPtk1wvmeuHg3EmbgbCIvDjyaaoqrmtt7f H/kq6VNieohtGI+r3Jg9CIYqLcwZ+aQK9GBTyEPiMwmWmRqg91srFMrFkAEwCAuMrfhzx1F/uT/K 6jDpC0DmlMPf1P91H2gnKT7taBWE2gRUSoZ6WQHrZQ== =VadY -----END PGP SIGNATURE----- --------------9744SflxtvLQiALZy1FW5lhD-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:10:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:10:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403960.646240 (Exim 4.92) (envelope-from ) id 1oWa24-0005Se-RI; Fri, 09 Sep 2022 09:10:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403960.646240; Fri, 09 Sep 2022 09:10:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa24-0005SX-OT; Fri, 09 Sep 2022 09:10:40 +0000 Received: by outflank-mailman (input) for mailman id 403960; Fri, 09 Sep 2022 09:10:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa22-0005SP-S5 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:10:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3bf8e6ad-301f-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:10:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4291.eurprd04.prod.outlook.com (2603:10a6:208:66::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Fri, 9 Sep 2022 09:10:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 09:10:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3bf8e6ad-301f-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AxHQdpehqm6C4YZMtgILwYDnU055d5/hSFAZgeED9dAtLNitaykvUDCEuwRIstqZjc3rWWaw2Tp1lAnSvjNbENmCgnVfvUATI0UUum+s2E4znfSAEJcN27FftcNyUSjI9wTUDWK3eFbaqHf0xugUlpXRP/z7wCizffHc+1a/NgAH7QsOxugo/lYXHt18ObYZvFbpfZymMq4V5nOvkVdS/imdrf9fkpoctLJLbHY9mBsFKJn+UsBKvglWTC/lJTx3+usyUmdt9GBF/OSXIAozadQv8BYEoBWpBBPlilYXDZSU9HYvGPO30izra7aPeHZCEige3UjrprUKrpB+VogJsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H4leNG+VrJdYg+MIQVhXu3KNlCCkFR1QCWJeZuhOCIg=; b=PypL360EVfz7yj5GZ6MkLGpPZa/wW4ccezciKUV8q9inrQAgQJPpLeaOEpa7gz2tAU88fevaBPC+MAUODjZVgkt41gYY2OobhhPzY+v6iooCPKiSMEcJ4JO1Wy4qwnxHvHD53No5BK0X9bqYZDaObBdSS6YRS04yBiUokcRJuNY+FFNwUioEwBqa2eftRQMxj0VX/mPkwgjhwubwzQDmnT/1jE6/qHxZpFZsYDu5XXEZSjCirbS515NA74VPVzS8i2/EY5qaDZdUYd16mKF6/YKqPVmEtuaXVuznzYA1fM3o59p+xi6KwMJSBGKVo1P0afy+Gh3yM8x4vGPRnIH6KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4leNG+VrJdYg+MIQVhXu3KNlCCkFR1QCWJeZuhOCIg=; b=Bozl1M8wS+TjYyRPnW48HI1B8dSEG7GiMIjhTJbEv2SbyGH/0MXLg0T4IknxkZXOj8PIcl18RmZKQ+Un36jajHbXE7ZF6GuY5faVMh02PixTjZ2TLnAR7tstH+KFPbIoK/zUkG5gcobVcVC/zJHlhAiweU0POrSE5aOFqYQ2sxFiCvMzQl1cU4LE/dcGBmPd8g5x1LT6Yt95cY/A3rfT0/2RfTUXF4CGrPesIT5wmBOV2PWam2CX+mMS3VxbNegFSeWAxFIaIVmAXj+i9d9iItr+c2Edn9PLItOH3UBogZvLM2+UeXVfb1kzhYcmhYAAuftDFUJTmcVvxFl6lm1grQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 11:10:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Julien Grall , Henry Wang Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Juergen Gross , "xen-devel@lists.xenproject.org" References: <20220909080944.28559-1-jgross@suse.com> <29e45aa2-910e-33ae-cdaa-be2f9e9d2942@xen.org> From: Jan Beulich In-Reply-To: <29e45aa2-910e-33ae-cdaa-be2f9e9d2942@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB4291:EE_ X-MS-Office365-Filtering-Correlation-Id: 59f1a11d-d24f-4a6b-3bd6-08da924327b6 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: affKYvygPDuEO9h0gjWEn2eQlIU+5gy5cuP128U0bA/wDW3pz1lqExeo09LS8RCVoNwvvKYzVLodurQCB0myxyJGJHlUabrbPMvlEt+6PJljAjbISY1tTeVcoFksK4p0pCjfiILgN315yJmkpzAR3X7gHq/++mUQ+V1a0LuW+ZxW35PeRFmkBPXXoX2a7sl1gZyv/RkuRFqaMAfHtVUMlUj3KMY+wSng1hA994HSW1UOVl3OJbw4fTUkHlA81+rJsiNEFh/sH02ePpxXAuPaAdUqAz4tB3AmxfGNBQy2yX5mfOLBndpQnomPQyDP9bS8YkL7H1ekn9F6QCSSzb7XEvlHYbSzVv228UxACG1d6AjYYuVyYS2ck5+r7wg7gI+QnPli0/rtxbkmoZiYN/z1PZ+x4/JHwBN6i039MueVbcoH7EF6S5eaI+X7B2ofFTr4/mgNXJWhbZJ2ILPbQmwQdjyS5CiNLq3r0ADYAP68uqXgMssJ0dZ7tlZtzk+U2SxKIINeyHM3beyd4X3rjx6MguGxwWKSqGfju9a0mnJOmjX7hoJYbc37c3NerXMvatfqS2xw9m/SyPcQeHtn1qKDnpQFK62ZWutLDQqS7SRahn8xQYRNtYgB7jnZGbNYIMkLN+0TVZ4hrYyW9Lb5vuUHOz4Z8SRgdzMur96NifGG+f3bC0sslm/S+INJjsSNuZj35QmK9d7gzUSDqgIvbTXPZ6W/xTzuWC10HBEANoh1D3Lt7r4sM4dPRFb3zpyBq/MinGlkpZ+e88SLV4j7LiwGWZRV4uqrNXd1xSGmRoEQ7Fk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(136003)(39860400002)(376002)(396003)(186003)(2616005)(5660300002)(41300700001)(54906003)(8936002)(316002)(6506007)(26005)(6512007)(31686004)(66946007)(2906002)(478600001)(86362001)(53546011)(66556008)(6486002)(8676002)(110136005)(36756003)(66476007)(4744005)(38100700002)(31696002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UExxZmFtblhuamZVT2x6ajdwODREbHhIUExpUlozWUxVYjQ3Y2JUREtIWTdq?= =?utf-8?B?K21jYjZ5U1F3RXJNenZ6czE5MWExZk0vSHN1SUVpTWtrTVFSemlIRjdBYU94?= =?utf-8?B?TTRHQ2pJMDZBMmdhZklMQ2YzK3JBajJuZkwwV1dVZnZuZFlBREtiSm9CMW4y?= =?utf-8?B?RzRXZWV1UDc4Y2FGN0RYUC9Ra0ZVbEhDTnltQUNXNlA1NXd0WmlIWHdoejhD?= =?utf-8?B?c05FeXVGLytzUjFXSGxJOVhCVlhkTG4ySFQrQkF6WmZsNzZjZy9xaktxRkNy?= =?utf-8?B?VHpBSy9WZyt2bm9VVzlUOG1WaEFUcU5LNjBRYjhSVkN3c1RMNGM1cVZuWWxR?= =?utf-8?B?UGZNUEpQcWI5UTNvOFVjRlJRMU5CUHpyWENabUNhUHMrdFd3bWZaS1JXZFB1?= =?utf-8?B?WXkwYXZSZ0FBeTZIc3VRZEpIcjdrbnZoZ25uTXhXWG42UysrVXppMjBqMVNa?= =?utf-8?B?WE9tQi9za21sbUE3YlhTN3lxcVlRM3ZJcklBL0Y3bVQ3M1FRMXZhTzRjRFlQ?= =?utf-8?B?cG9CT2lpNnFKbUVOMC9FWG1CRUc1a1g3U0hMbFV4UUVzWTRFWTMwR01CNkVN?= =?utf-8?B?MDhPczdEZ3BnZElhbXEwV2xnellsRWRhK2piZDhHbHNLU3ZrS1BIbUZFVEN0?= =?utf-8?B?dzIzZE80dXhGdjA0T2h6T2kzSlRPdkhUaTNwVndJZmRQZEMrbW5nalRSVUhj?= =?utf-8?B?bFdBdkVpeU1Wd2J6bi9Gd2RCR1dxQXRzSHllN3ZQZXM0WVRoTmtaR2lBbmdo?= =?utf-8?B?MVRIWUdYYmZtVXVZMWpGdTVWejZEU1NXL2RkQzROT0padEZlYUlER2IzTjZt?= =?utf-8?B?VG4rcVpXR3JTbHRma3VJV2tYS0Zqdi91azJNL253R01NZUxXT2pLV1FlQlFs?= =?utf-8?B?Tk9QOTFrcUEyb2FxdjJmSnlYL0ZwaFd0YnVVSVFLTjdUMG0wYkI5OHFYR2o2?= =?utf-8?B?dlRyaXZNTThDcUZ1RFBMQjY4QUl6QzhOS01xb2lEaXFRL2QzY21vQkt5enMz?= =?utf-8?B?Q3lzOVVrbkxPckloYlNnRG5ITWZ6QWlPUUd3MFoxYlFka3BaemZEbXBSWWpL?= =?utf-8?B?K3hsNUdyTnMyWGRyeWszQjRKaXlpd0ptbDZHSzZwZHpnaXZmN0wwbjJKQTB0?= =?utf-8?B?VTZydWJOUzMyVEF6SFp0UUgwNTZTdXl4U3lRWkNRWUd6WXpPZ0NiYzd4SVFH?= =?utf-8?B?MHZGeHE1bVJEOXZzVUYyN0Z6WGRkT0t2Q3BTODBDdytFVitXd3RHLzloZThC?= =?utf-8?B?VGZWN1h5bjU2VXBYWW1zemZ4NVkxeWxJOUFiWktSTEtxQStSWElNQ0dmU0xt?= =?utf-8?B?TmV3VGhIblFmcWM4MDUyOU9qZ3VyNnFCRmV0TVB1SXJoTnE0SzdPNXJRaUdM?= =?utf-8?B?bVBkdzdnOWprUUxVSkZ3Vk0yWWZyd1c5ZnBMZkNmak9EQTNHMEhwTjlKdEhm?= =?utf-8?B?M3VUOFQ2cFNaR3dPa3F0dWpDdk4vRkhIdXMvZTI1NXFtd2RTd25zN1EwMGVG?= =?utf-8?B?VmhxNXd1WlUzMmZMaUo5R0YveVlodlVHSXJSQkVXbi9tT3ppVXdFekJVYWJB?= =?utf-8?B?ZWF5bDd5a3FueEJPS1YvZ0VaOUt5RG5OalhmZUY3M3lwb0lhVEtZSERxeGZ5?= =?utf-8?B?YnZqTXdNMVpFdHA2dmRuYi9KT0g3OWZNZkMrajVSVTM4aVVBOVVzeFQxODFB?= =?utf-8?B?TjY4MUV4a2plMHU4dHZqNlR2TGIrUW1LR3BoY2tEMFdQYjNrUG1NM1dQa21m?= =?utf-8?B?bmdBSHUzTENlUGxqWlAvU3JPRCt0M3FucGZvSndHVDBqR2JhczdPdHE5WG9O?= =?utf-8?B?dzlhZjhkRTNzSndpYTZFeEtDd2w4MVhSK3B4R2hDWHlTaUoraUM0SzdKajBa?= =?utf-8?B?amtSVFA5cGFBZTFuc2ZITlRraGoyRGdZejUvZ1Y2K1RCVUJkb1Y3aDV4bnQv?= =?utf-8?B?amhmTXFkOVp3d1BmZWdwcnphbk96akw4U2hHS3F1Zk1vWURnU0hPdnFnV0Z2?= =?utf-8?B?ZVNjNWF0UW5UL0NaNFRWZFk4ZlNCRWlPMlhTdHZYZmNUa29oZTJuakNRQWw1?= =?utf-8?B?biszQWUyZlBNNlRZTWpHdTVBZ0NjS1ducXZWdzJsT3cwNXFmY0wzWEZ4anFP?= =?utf-8?Q?rkCHVsfyNteHiF4j5WZxQUSPL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59f1a11d-d24f-4a6b-3bd6-08da924327b6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:10:35.4783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PEomDeTPfTreAkItoQYa+6OdcjUh7tWar+obn4OZCyojEtAJhF+C30H6eooF3yty3wwV2d1VQImjbb6WosO8mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4291 On 09.09.2022 11:04, Julien Grall wrote: > Unrelated to this patch, but as this is your first Released-acked-by > tag, I wanted to check the policy going forward. > > From now, will any new patch need your approval before been merged? It was my understanding (from past releases) that bug fixes would be fine to go in without until code freeze (in 3 weeks as per the current schedule). Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:12:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:12:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403971.646252 (Exim 4.92) (envelope-from ) id 1oWa3o-00066g-Bl; Fri, 09 Sep 2022 09:12:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403971.646252; Fri, 09 Sep 2022 09:12:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa3o-00066Z-7e; Fri, 09 Sep 2022 09:12:28 +0000 Received: by outflank-mailman (input) for mailman id 403971; Fri, 09 Sep 2022 09:12:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa3n-00066R-B8 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:12:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa3h-0005eB-7y; Fri, 09 Sep 2022 09:12:21 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWa3h-0007vN-1M; Fri, 09 Sep 2022 09:12:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=sV+BSW1mGd8DPZbM7pXw76q/NvxaaMCD6kRuWPkJOCU=; b=BmdLE8m+gPpx5Sy7pMQYRnW7DE PFDk+N3btCDQ/5ZOGMhnt9cnG56RjoseF7sSo/aNCTAaT3RJ+iWQ+hvgJ9iYLGG0O2h5FyJ+hYgqO QEcNyTNYQD44YOjzhisLXw8aQBF8o01T9aCMQVvHObHJcavuH08nK6bgQzRu1Z3v3qyA=; Message-ID: Date: Fri, 9 Sep 2022 10:12:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Jan Beulich , Henry Wang Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Juergen Gross , "xen-devel@lists.xenproject.org" References: <20220909080944.28559-1-jgross@suse.com> <29e45aa2-910e-33ae-cdaa-be2f9e9d2942@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 09/09/2022 10:10, Jan Beulich wrote: > On 09.09.2022 11:04, Julien Grall wrote: >> Unrelated to this patch, but as this is your first Released-acked-by >> tag, I wanted to check the policy going forward. >> >> From now, will any new patch need your approval before been merged? > > It was my understanding (from past releases) that bug fixes would be > fine to go in without until code freeze (in 3 weeks as per the current > schedule). This is my understanding as well. But I wanted to check with Henry just in case he decided something different. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:13:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:13:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403978.646263 (Exim 4.92) (envelope-from ) id 1oWa52-0006hv-MP; Fri, 09 Sep 2022 09:13:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403978.646263; Fri, 09 Sep 2022 09:13:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa52-0006ho-Jg; Fri, 09 Sep 2022 09:13:44 +0000 Received: by outflank-mailman (input) for mailman id 403978; Fri, 09 Sep 2022 09:13:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa51-0006hi-Ra for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:13:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa1cc64a-301f-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:13:27 +0200 (CEST) Received: from DU2PR04CA0196.eurprd04.prod.outlook.com (2603:10a6:10:28d::21) by PAWPR08MB9688.eurprd08.prod.outlook.com (2603:10a6:102:2ea::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 09:13:39 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::d7) by DU2PR04CA0196.outlook.office365.com (2603:10a6:10:28d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20 via Frontend Transport; Fri, 9 Sep 2022 09:13:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 09:13:39 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 09 Sep 2022 09:13:39 +0000 Received: from b3760cb04c0d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C22A9C4E-874C-4AD7-9A35-629D20928932.1; Fri, 09 Sep 2022 09:13:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3760cb04c0d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 09:13:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV2PR08MB8100.eurprd08.prod.outlook.com (2603:10a6:150:7a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 09:13:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 9 Sep 2022 09:13:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa1cc64a-301f-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TRdFxuKhjHOLppBoNGnBZSMwraauAzBEmtSchmHJQfAURwEz7qhdLZcx0Om3hp8QNqv9d9KLHHWFLP+kaP7IuoQsncytAPVuorUk2es/4NaiKima6KV+2mO9++3tu+nTsbr1nM6IGP61nNMV3asqOQ9ZP+gYOPSkRe3DqYlrSurffdl3ZD8IOtkaAlYDm4Hird8kvkFg44Kg2cO9lQWS6VZzTs0drTKwb5sbBWkmETAosGxOZ+f6KvnoQMbA4bPhwFtTT4OqENewaMb4MTJ2lNm8r2GBQ3JyyX4V5jao10RDlRb+GQgaETza2dkBU8uaM5LhA3K4gtv5wvH8uLMyrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsW6TVLehl8VTt+ux5yytFTBdA829iehgwRc/kKAIhc=; b=aHrIZF31GilfYc9ahg8QmyoobrHQGjIavJi047zo73wPo3ER8qULM6tRbjuup+hee9X6rtUTf443QkZxd1/+ZT4M1zw1ZYG9k38X1WArlH2aiQO9UlmaEm6nYif7Gw1p65GQFyU9VK4Ddb22hvVI+BJ0rmvKG2l91VkeNhME3TQ7wh4lWYfkxthWwBuv8+YJ5K7rntj2Nvuc+C2DSXBzJNLz+KI0DCC539oaGxM9MrQBqf6GNMRBBclrjmiW/SNQKsIxSgTjroebcM9FDZYFMSJmaQTbqMRd97EgItdNRHR8EoCyeAo9VUK59KNl3DEUfxH3iN/Ybo1y5v4x1qDIDA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YsW6TVLehl8VTt+ux5yytFTBdA829iehgwRc/kKAIhc=; b=QU2QGUz8j2Q0pIMQ+lxmBZkJOSlKDCviAhFtjHosYKFAUSjwY2MhPX68Jcp7xakxuba9+ipvsbx8gvlIDIbWpHkJ3ZnBj8Vi+5KsNjeJubtQRaexPwSKte99o/CkQL8IjC1BBw1Ke5ukFqWyuBPkWaPPSf+z1xHTFl/6343Yp4c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsoOCIC/MQIc4YdXjQRJBRQx62iaaW99f9I9Nb0ozqoTajJ5NPPl81Sy2wcHATqLEZ4Z7zzMWjG9CCW7jU79jFcDqvrFOAIKOH8c7RKrhbZaOiyrhLx4/VOv98uq+3hyfDO+/cTvlbANqququGwa6dZFAa2PiKSfKadZiGNM34VQe2tpvBnJezXc171Dl6JWoUXlgoNAqe7ivisQnqIzxl6T+eEMo8gUWgKSdtzb4MLiHUMV/ej7b7E2NVW0SCPW/1K+2y4qm6HKW5bhOioJo0r+9jn8tnYGl94df9lXQM/0myfSaLkFVNPxMmY4+A1UCIarb1usqQXg7b6iej7VSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsW6TVLehl8VTt+ux5yytFTBdA829iehgwRc/kKAIhc=; b=kValUNtVidSSpGqYJFglpmifusKtb/N58lQHHnAIqe5ZkVDXmzIdp6TypF+Vrl6s4srCt2FWkElGaBR56RjS6GiiF/l52YafF9duEXCXEIDDRPYHR9EBWC1wc0Md6HasisKAyLkymwBkgyGd4zJct4zMW4AYbHsyHmiYIhO5MugLKJwwOgQnWmgOwXH4QlWuHa9bLuAJF6/sIhMx+WN+LiTLqUo5pq9aHDV/8hXRdDAtzAwisCVgr66r1OMnVzXA3986kXeEr9Dncc1UuAyKcLyba8Tw5ibGh6WEhtuCWIrXeAce/Kuy5QUkMaa6YMuOoKgFs99a0LOb+fKjUYTKnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YsW6TVLehl8VTt+ux5yytFTBdA829iehgwRc/kKAIhc=; b=QU2QGUz8j2Q0pIMQ+lxmBZkJOSlKDCviAhFtjHosYKFAUSjwY2MhPX68Jcp7xakxuba9+ipvsbx8gvlIDIbWpHkJ3ZnBj8Vi+5KsNjeJubtQRaexPwSKte99o/CkQL8IjC1BBw1Ke5ukFqWyuBPkWaPPSf+z1xHTFl/6343Yp4c= From: Henry Wang To: Julien Grall , Juergen Gross , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: RE: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Topic: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Index: AQHYxCOLeMow4nnAdEmRQz42iuSBI63Wx2cggAAGtoCAAABn8A== Date: Fri, 9 Sep 2022 09:13:30 +0000 Message-ID: References: <20220909080944.28559-1-jgross@suse.com> <29e45aa2-910e-33ae-cdaa-be2f9e9d2942@xen.org> In-Reply-To: <29e45aa2-910e-33ae-cdaa-be2f9e9d2942@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0B13B627CA1AFC45A02496D190AE67F5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ee430faa-4cb2-47e3-4260-08da92439588 x-ms-traffictypediagnostic: GV2PR08MB8100:EE_|DBAEUR03FT063:EE_|PAWPR08MB9688:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: P3cBYIjd8aYWD30/L7ST3rv7Fvy2z8P0sVN0Xtg6yj+anEFJQwTGDjlYoJ5Rk739bOq47EgkUb3SpIbEPX+L0b92HtyhB9rmx77jMSxN1/jpQblqpWUIH7wQWdjHY9i31Nf42aAHjCKNjzOfB6/Ujmnmbif1XrPcEOf4O1Venmd4Ek4lr+LHkfGxiuqP6u/FgIN9snCLkGXsu08JYe/C7ValpDBrvuxJOW74H9hvtFoLmY3BMriVkNHSrVcyJdiAJhxyoeheSxRM+WQZ293w7bSy1axM5QJpG6vdfH6bj6OAVwF5Wbo1xqBRDuA3J9wNZ553wv4pjzAkAb4/gukDmww1BQQWKxcgw18Om0ph+r7Nk4VfKT3oyUiWHFSOGbo+N7bFSCjNraRB7XWdyT5Yk88chJ+xywhrZ0X4tgy/m9uPkMOqggMj2FbH0Foar6YmyDacEZU9Iog/ZjTDdxjRfg1LDuOex6LkuZ9E2LibeMoRODSShbBUaCFwtAgeh13oOy1wnJSK6GXrNriu56IJsa9asAXge8C36RHgDz7BkZJ+lSKCFM8KbL6H1pjjlZQlsKfgTVkTmGnykKqt0vPb83IY1rTaRLdLcBz73Im77sRIZ1BJxOb49+2xt7zgg+ABm+FVCFgbSEgiYJJMr+Qz/iHl+aOXkhyHnkyusULNzKi/mpQ019w7EoAGNe5oUc0qN62sY1mg1HOkYUJWYiO0PjEgymugTAQtbkqFv+BgMJ+UuuZ/E02tAPGSsQkxI35IaIqH55i6k6Pl355FBKDaKw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(396003)(366004)(110136005)(41300700001)(316002)(55016003)(71200400001)(2906002)(122000001)(38100700002)(38070700005)(9686003)(54906003)(83380400001)(26005)(66476007)(66556008)(8676002)(64756008)(76116006)(66446008)(478600001)(66946007)(53546011)(6506007)(86362001)(4326008)(33656002)(5660300002)(7696005)(186003)(8936002)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8100 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ca17c0c-a3fa-471e-321e-08da92439046 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /a/BNhsFnc8qzlxKStoHAb4h0COQcgXPguXVAb6LIrFwDfOPtNN+MdDzvsrfewmo1Dj5sZF9bFYnFDHzvuB7XOGEqy871Fuyx5m7pzYZE5ia/N2FcSJx1KYNl9WK/9h1zjWUruxrEd7Jd4HIopcSM/r/spLq4DrWUL4nhf8HYr2ZaGRLSOB4y4eBpv/huiYyK2RCpKGeqtoGQUcUPXJlGm9o7GeK6AehneWootHQb9hOcWsT4NZe2rkpcxce/R6nKpHlvCAAWOwJyLnZiCFuq+p0PpMS9D84rF/SlpP3KQa/2rkTcgbLJbQ5tnFrBWEf9zbdrIM5ALY0JI5sFAdFebuM+MxDzOFGmVPTcMn29PC8OjM9yM3hh6A9LpvsRWD0PxdlSY29hpQ0jtfofwF6uMuiOGzCxK6N4A0ukq9Cr895dJPFBcTMik6ilspNvgoT337f/NGLtgtzlA29nfrXrDI7r0NJl/VOFsEVgtw0uphzUmHiC1C01BSFtTLoyHazEy8X23rTkVhGNxwgK/E7qwKfBxmicZCTWhL5Z32tOCFkuz57K3XP52vQ7VAw9KG0it9wFyRQfoxrfW+XHZxrUrj8hyoxuXVXRTYGoW4g0B/Rz4Fu1iqesc+pvz3gaaUPZLOQGIe37Jt5NhfRiz2tBu4lzfbZMKJnA/gC9sO/4OzKfDsBBs4M08RkObUhXUrcSJvB6azVuL1MofEtEBYZObHXYUCEo+TpOMDPaFY5ESY8kIEFfkv7TBeH6lIAxiQvgDbYg68LTWLIng4KhwxZrA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(136003)(39860400002)(36840700001)(46966006)(40470700004)(52536014)(5660300002)(2906002)(82740400003)(8676002)(316002)(110136005)(8936002)(4326008)(70586007)(40480700001)(55016003)(82310400005)(356005)(33656002)(70206006)(81166007)(40460700003)(86362001)(54906003)(83380400001)(36860700001)(336012)(26005)(7696005)(6506007)(53546011)(186003)(478600001)(41300700001)(9686003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:13:39.5389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee430faa-4cb2-47e3-4260-08da92439588 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9688 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHhlbi9nbnR0 YWI6IGZpeCBnbnR0YWJfYWNxdWlyZV9yZXNvdXJjZSgpDQo+IA0KPiBIaSBIZW5yeSwNCj4gDQo+ IE9uIDA5LzA5LzIwMjIgMDk6NDcsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv bT4NCj4gPj4gU3ViamVjdDogW1BBVENIXSB4ZW4vZ250dGFiOiBmaXggZ250dGFiX2FjcXVpcmVf cmVzb3VyY2UoKQ0KPiA+Pg0KPiA+PiBDb21taXQgOWRjNDYzODZkODlkICgiZ250dGFiOiB3b3Jr IGFyb3VuZCAibWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCINCj4gPj4gd2FybmluZyIpIHdhcyB3 cm9uZywgYXMgdmFkZHIgY2FuIGxlZ2l0aW1hdGVseSBiZSBOVUxMIGluIGNhc2UNCj4gPj4gWEVO TUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lkX3N0YXR1cyB3YXMgc3BlY2lmaWVkIGZvciBhIGdy YW50IHRhYmxlDQo+ID4+IHYxLiBUaGlzIHdvdWxkIHJlc3VsdCBpbiBjcmFzaGVzIGluIGRlYnVn IGJ1aWxkcyBkdWUgdG8NCj4gPj4gQVNTRVJUX1VOUkVBQ0hBQkxFKCkgdHJpZ2dlcmluZy4NCj4g Pj4NCj4gPj4gQmFzaWNhbGx5IHJldmVydCBzYWlkIGNvbW1pdCwgYnV0IGtlZXAgcmV0dXJuaW5n IC1FTk9EQVRBIGluIHRoYXQgY2FzZS4NCj4gPj4NCj4gPj4gRml4ZXM6IDlkYzQ2Mzg2ZDg5ZCAo ImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQiDQo+ID4+IHdh cm5pbmciKQ0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+DQo+ID4+IC0tLQ0KPiA+PiBNaWdodCBiZSBjb25zaWRlcmVkIGZvciA0LjE3IGFuZCBmb3Ig YmFja3BvcnRpbmcNCj4gPg0KPiA+IE9mIGNvdXJzZSwgZmVlbCBmcmVlIHRvIGFkZDoNCj4gPg0K PiA+IFJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCj4g DQo+IFVucmVsYXRlZCB0byB0aGlzIHBhdGNoLCBidXQgYXMgdGhpcyBpcyB5b3VyIGZpcnN0IFJl bGVhc2VkLWFja2VkLWJ5DQo+IHRhZywgSSB3YW50ZWQgdG8gY2hlY2sgdGhlIHBvbGljeSBnb2lu ZyBmb3J3YXJkLg0KPiANCj4gIEZyb20gbm93LCB3aWxsIGFueSBuZXcgcGF0Y2ggbmVlZCB5b3Vy IGFwcHJvdmFsIGJlZm9yZSBiZWVuIG1lcmdlZD8NCg0KSSB3b3VsZCBzYXkgZnJvbSBub3cgaXMg YSBsaXR0bGUgYml0IHRvbyBlYXJseS4gSSB0aGluayBtYWludGFpbmVycyBjYW4NCnN0aWxsIGNv bW1pdCBwYXRjaGVzIChmaXhlcyBhbmQgbm90IG5ldyBmZWF0dXJlIHJlbGF0ZWQpIHVudGlsIHRo ZSBjb2RlDQpmcmVlemUgKGVuZCBvZiB0aGlzIG1vbnRoKS4NCg0KSSBhbSBwcm92aWRpbmcgdGhp cyB0YWcganVzdCB0byBzaG93IEkgYW0gaGFwcHkgdG8gYWRkIHRoaXMgdG8gNC4xNyBzaW5jZQ0K SnVlcmdlbiBtZW50aW9uZWQgdGhpcyBpbiBzY2lzc29ycyBsaW5lIGNvbW1lbnQuDQoNCktpbmQg cmVnYXJkcywNCkhlbnJ5IA0KDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBH cmFsbA0K From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:15:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:15:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403984.646274 (Exim 4.92) (envelope-from ) id 1oWa6a-0007IM-1h; Fri, 09 Sep 2022 09:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403984.646274; Fri, 09 Sep 2022 09:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa6Z-0007IF-U7; Fri, 09 Sep 2022 09:15:19 +0000 Received: by outflank-mailman (input) for mailman id 403984; Fri, 09 Sep 2022 09:15:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWa6Y-0007Hz-Uc for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:15:18 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140070.outbound.protection.outlook.com [40.107.14.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eab91472-301f-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 11:15:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8753.eurprd04.prod.outlook.com (2603:10a6:20b:42c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 09:15:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 09:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eab91472-301f-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfOeb+rCDuOxAU76nqzl9PtiYkJsIQz3ia16+n0OyGtcppP7xSBeF2meU86F9BKYJmK7nOnEB+fJAnT2PWlMYOAK7p59571pTMxg1yjvPZkvT9nQTBFDd/Elux3XP3a2GRb6FDJ+o+Ppkrd7U9ExcFIc7TqltUe17VdzwcTI2zptia/tOK6AsmG8hKAHAI+cX4BdWb0iLsmBTtje5uOTp6n5ldneome3Pq31DMU5Hgj5/BB84/M7r0o8wuQiZ9onnBTWQd+qnzh6+Gcxm/udOPmZLYUcV+0v4u6vtnFFF+ZC6gA8yfZv9H69sWeWvPVb6XbDWeVfz3xfZMVgXIJQKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6mawu4IQVyG0TwWaH5hY3MU3pQjCiPLg99tVXVJ98VI=; b=jqtoE8M0oWzLyqVU3pFjnqW7AhEYKOIc21CF4UdjS6uSSyvmV2JlKm9QPILoqMIWuLSuD5njQ1sOXbpinYB7TpA4gZV3W3jo78Kgmyie8v7ENA53AItsKFvJYO59fS3df+YLujMfOnL1RUVJXSt8LIkPwno7ZaIIL4Zc5H/m81leKCN1mMcUgTHkOdfh1a9jpTUpg/exgjGEMNpMknMiBNR5n5k7+wxgOESIz/m3ASdhHF6tqAIX7Q87ivXwY95jieam3bdCS87qxSW2TN0R/GPfhMmp7owf6aiLvbqiHk7Ma/fkaffYS/7Tn0a8OkRSekNf1cj/zBy1X0uaJwCRxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6mawu4IQVyG0TwWaH5hY3MU3pQjCiPLg99tVXVJ98VI=; b=puNAHjR/hW70IjlHdeRuID/KpjDw8P4bwNGswBYXCusBP17TOHCJTytBJ2e0WseXnXo9kFAkz33m6l5gV3iwaVlXuOqg99QY0T8nbzZUxNFQK5XE/nANrkiXlPGInWijd1ckN+ZS+dE4UIzZXjDtBf0n6JBa0bwey7SwkOE5n3FrCw23FLosdq9l4j/czvIcj9+2S6HYv3UVtKQEIYMt6iWsSR2NZr+B65yGa9bwY7TBMaLPdJRPXj0znbhIqoRYGlTzH9f7BNEjgNK/9yKUVJRJPU99EyPhXhrOHIvf04T+GPgFPBoXWPOU8hK2tOkaGoXiug3cKW4GDYU/QoBmOw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> Date: Fri, 9 Sep 2022 11:15:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Juergen Gross Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220909080944.28559-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220909080944.28559-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0047.eurprd08.prod.outlook.com (2603:10a6:20b:c0::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8753:EE_ X-MS-Office365-Filtering-Correlation-Id: 47466285-89ff-4abe-f239-08da9243cdcf X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ++oeZGF1UabA7Zy6rZU1IQLEqCxzJjKqC8Pfc1yIsR872nOPEpJ8YHegwK8KL96EnenaD9uiK+cDDBfqZk+UAn2QTK7IoMMccqHlFlwcXhrqI4LER3VYp+/x0Id3BiOULvJnLuNvYsCn9Qy5RT5hzeHnceoK29dlPbZK6ZoP3lc8fd1r8mZIteLKPpiWm1mxhE6aZBxz3hw/fytKdAUU18COcdhvFy9+Cj+LniqHzpv/fWzutMU9uyRs9kcQh+meViVKyEeSrzeiesedLdhHeLa4qpjDYnaNY2NCRmkRQuWFGoValAklrGc57/7xcPbfKPPirbUc2l7GgsYYKjdGetixhjMGyRUW+EOFAjH7LvvYouzDHJnYQSfs1Y5pFFRNEr9f/1dVS1TzlxK/KE1pCeIzhCymKzN5XrvMwC5XPRZ6FLfl/D1Y04I9G6zpeYjGtIFFTjeYUIITrvxIgEw5L6RJChp5TMAuetnKqdjhRiHa2xBzVKk756l0QG3u8FrPyE6xRquoQCfX9l8dgERXP6Hm/14rBkxb4HNcWhs0qJjMIdMzmzQBQuV5si5QXS6+N8lFAOxNFpNqtbXNWyp/B3mleqo9P30/VlVjm4i2E1e7xlATVWfIqamUPtv6Z4t13aDKyl1E8/EqSRcBv1s6Jf3fbvhxi67t85jhZlHSEsF3bINfg/cxLTjQBYJ3viF3OPEk4yW/nUmNymm1aFD5IlMxzTMpl97IAFJ/r15VrMYvYNrm6LNAoczVCmgd8k73DvCas2chgaPINpDFOX/wCupHFOM4vdbKQIIONPXfZfw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(366004)(396003)(39860400002)(346002)(4326008)(8936002)(38100700002)(8676002)(31686004)(37006003)(54906003)(316002)(6636002)(66946007)(2906002)(6862004)(36756003)(66556008)(66476007)(5660300002)(6486002)(186003)(478600001)(83380400001)(6506007)(26005)(6512007)(31696002)(86362001)(53546011)(6666004)(41300700001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3B6WG9FNGM5MW5XNFlXaCt2VE9KTTkwK2FldXdMNkVTdHByUmNSVnplTEY2?= =?utf-8?B?Y3ZlL3lJbmN5c082QW16dWFTUm8vTHRKR2RRbFRva3BVOERUT0FmTUc5RUZ3?= =?utf-8?B?eERTVnVKVDRQTFRCbG9zc053cFdVTVVkYjErUlR4b2hPRFpRM1BJWGduRDN0?= =?utf-8?B?aSsrNWhIeDU3UnJvK2o3Rm5DUGRraFhvYzdtLzU4d2xBbGN3WGNjRURxWEkx?= =?utf-8?B?K3ZiaTFJb3J0TEhWWlAyNGdhb3Z4NlNPKzZtSzF6MmZNQk9kYU1DcmxHZlRU?= =?utf-8?B?bGlJVThiQVlNeExwR0FLQzVTYm1BRG5rcXYydzdocWIrK1JWYzBGVVdPL1FC?= =?utf-8?B?c1hmQ2p4UTlXN2FRb0l4VkFhZkpaa21HMkZtOHF4SlRUN2ptLzdSOExmN0tq?= =?utf-8?B?dkRlOThHcStPUEV2QUwrbGwwMEx5MHkzcWp0Q043K1RSd2lxbkVxR29naEpI?= =?utf-8?B?b3d0TWNaMy9UaytNYnR4ckdJT1ZDUmF2Z2Z2NlhMem5GWkdyK1M1dW5zZ0dY?= =?utf-8?B?SENhelU4ZUMyeVdHekJoMXRUOGtYTithUFp2eGRUaFgwQ3ZiUmQwVzJnb2VR?= =?utf-8?B?WnlUajRpT3F3dFRwbGdveGRvcU52c3Z1aW13OFdGWVM4WkphZnRMcGM3S2px?= =?utf-8?B?NVYrOUdVbDJLcm81dlEyWVFxbXNSclhqSk1BREczTTNRUDlHbXdyaGJnK1BW?= =?utf-8?B?QXgrUldpSDJxejE4S2k2ajNGN1QwUlJ6Z1Jrb2ExdHpZMXp4ejN1U1FSWFFL?= =?utf-8?B?YmpMcEFnM084OVhUbEgyR0xFOVliTDlhenozOWZpSCtOay8vRWlnNDdTZGE2?= =?utf-8?B?anYwYXNXYUV4cnRHTzBCSGNEcTdqM0ZHbW1BamltY0FxTzdpWkV1OXpzWWY0?= =?utf-8?B?Q09ZRW53MTdOZm1obk5OdnJ3YklWN0VuUlJEcHU3Ny9ZMUh3aFRoODFJeGNB?= =?utf-8?B?bk5tQ0l2ZWFJeUd4TkxhbCtpNTg4aHZ3cTNiUGVVcmJmSzA0Qm80cE9QZy9X?= =?utf-8?B?aVY4ckFiMEV1U0U5NGw1NDNWVXdnTDZKbE9TL3JYWTM1TUdjM2xiRmpBRllk?= =?utf-8?B?bzFvZXBscGxzMHgyMHgxb2QzeFdaVm9qUFh1QmZuTWV2RjhkTVl2eEZnMldZ?= =?utf-8?B?c0ZhYlczQ1g5SHhiOENtWDdLTHdjN3Jzdm1YdWJYYXczK2FFRHNBZk5kWWJI?= =?utf-8?B?bXNwUmIxTWVXaElSMlNjd2wwaUVBZE9ZZ2MzM1IwTFF6Vkx0ZUNDYzAvbW8y?= =?utf-8?B?T2tzSFlTSFdFTlJHRkhlczJ5TXNZTWlYS1pyb2hjRGFuYmhLUVIwQzBteGQ2?= =?utf-8?B?cVQ4WG1vTkZoT2l2OXVIa01TUnZuemRnYW5KbEJOUDA2L280TUZpVmc3bFdL?= =?utf-8?B?bTlQaXhQQ3lkQnBNVnRJZkJrV2lPalZXeEVwdklNR3ppVXhxSlRJNmEvc0lz?= =?utf-8?B?NjAzbVNWZis5a2RrRENBc1J1WHZtM2dlZ1pncXdRVmNkZmVxTU9OTVJkZUlE?= =?utf-8?B?TmpwR1BUSWhjR21HSnZUeHJ5eXM4aGgvVG5FV1R5QzNRNm5GK3hlZng4VTJU?= =?utf-8?B?VE9GUjBTWGxYcXV4eTZNdy82UUVhQm8wdkdPSkdjdDJTdTFWbjdQTDRQRE1H?= =?utf-8?B?aEtQSWlObzJQSy9wK3ZzU1d0aHFRQm1SRDZ5SFhSMlkzSUpmVFRENWlvR2Fl?= =?utf-8?B?cUdQREFyazBBNnhLdkt0Q09UdUlocU51dzgxZjl5RCsrU0ROYmRwYmR4OW9W?= =?utf-8?B?TkgyQWhRWWU1QndOOVBpNDlNdGxKc0d5ZDFUTGg5Z0Z5dFRxL0Z3dFZsTkJF?= =?utf-8?B?c0R5WUk0Y2Q1ZnhIazlkYUg1NHh5NHlqRXppdnpDcTB0bllxbTR4eUpyQmhC?= =?utf-8?B?THBZdzlFWjNwdHRPTkd2RDdpZWk3KzBEelk3djRnSThaSjFjM3V0aU5rTzB2?= =?utf-8?B?MUNaVGFaQThUSnJJMGRSZmRWaWJvR0JCSDBFeWI5bmZjVlRZTCtsT2dmNXl0?= =?utf-8?B?ODlrY3A4VlJzZ2RMS3p5Ym5majhKb0w1VXJsLzJWYk45L1EvRmJIdDl5N2JP?= =?utf-8?B?dzQ4V29UNlRQaGJIblM3QlQ0ZlFSbVlOSHJvNldTVXV0Z3RucEllMHJuTUlj?= =?utf-8?Q?/GOgn/Hr2kYHKdLKhe4AIWl03?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47466285-89ff-4abe-f239-08da9243cdcf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:15:14.1017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wEGIkytNAclWx67cs7fRkWhhSjsZm4ofzSGcEny1BH5g2trE/Sb6jmz5MMQrZ7U91SjBOx9W0T0Nv0PO+STIvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8753 On 09.09.2022 10:09, Juergen Gross wrote: > Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" > warning") was wrong, as vaddr can legitimately be NULL in case > XENMEM_resource_grant_table_id_status was specified for a grant table > v1. This would result in crashes in debug builds due to > ASSERT_UNREACHABLE() triggering. > > Basically revert said commit, but keep returning -ENODATA in that case. > > Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") > Signed-off-by: Juergen Gross > --- > Might be considered for 4.17 and for backporting > --- > xen/common/grant_table.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c > index ad773a6996..68e7f1df38 100644 > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -4125,7 +4125,10 @@ int gnttab_acquire_resource( > > case XENMEM_resource_grant_table_id_status: > if ( gt->gt_version != 2 ) > + { > + rc = -ENODATA; > break; > + } This path is supposed to produce -EINVAL. > @@ -4135,17 +4138,6 @@ int gnttab_acquire_resource( > break; > } > > - /* > - * Some older toolchains can't spot that vaddrs won't remain uninitialized > - * on non-error paths, and hence it needs setting to NULL at the top of the > - * function. Leave some runtime safety. > - */ > - if ( !vaddrs ) I guess this wants amending by "&& !rc"? Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.403992.646284 (Exim 4.92) (envelope-from ) id 1oWaGt-0000gs-Vl; Fri, 09 Sep 2022 09:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403992.646284; Fri, 09 Sep 2022 09:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaGt-0000gl-T5; Fri, 09 Sep 2022 09:25:59 +0000 Received: by outflank-mailman (input) for mailman id 403992; Fri, 09 Sep 2022 09:25:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaGs-0000gf-GE for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:25:58 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ff6e4a2-3021-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:25:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 95D4D1F8B6; Fri, 9 Sep 2022 09:25:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5769A13A93; Fri, 9 Sep 2022 09:25:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j0DZE6QGG2NrXwAAMHmgww (envelope-from ); Fri, 09 Sep 2022 09:25:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ff6e4a2-3021-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662715556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ND/rz4TrKNww8aOrf72+1OECzuYRaJL1t0AUd/GZv94=; b=kBErtH7dai9O3VFWGV+8wVqY8smpP+cZukzjCTCQfx7iMZ3G8F+trck7BmZjxRp4xeDk9M 32mSF3VlHmCIN7krS9SCjG6zDumiIV1esDIqbD/TeKUYx44CQtXBhKPMakd7cUBiADwoGt zN4zCiJJ8xfG25lwDIwYGMwWG+pqjzY= Message-ID: <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> Date: Fri, 9 Sep 2022 11:25:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220909080944.28559-1-jgross@suse.com> <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> From: Juergen Gross In-Reply-To: <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------sKEWVXj645OmzupvKhjAA2ss" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------sKEWVXj645OmzupvKhjAA2ss Content-Type: multipart/mixed; boundary="------------Hwig5wVfU0dMwqGVZR3TVSxA"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() References: <20220909080944.28559-1-jgross@suse.com> <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> In-Reply-To: <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> --------------Hwig5wVfU0dMwqGVZR3TVSxA Content-Type: multipart/mixed; boundary="------------aaYZ0EBWowl0Pf0ZVZVEXwvO" --------------aaYZ0EBWowl0Pf0ZVZVEXwvO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDkuMjIgMTE6MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwOS4wOS4yMDIy IDEwOjA5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gQ29tbWl0IDlkYzQ2Mzg2ZDg5ZCAo ImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQiDQo+PiB3 YXJuaW5nIikgd2FzIHdyb25nLCBhcyB2YWRkciBjYW4gbGVnaXRpbWF0ZWx5IGJlIE5VTEwg aW4gY2FzZQ0KPj4gWEVOTUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lkX3N0YXR1cyB3YXMg c3BlY2lmaWVkIGZvciBhIGdyYW50IHRhYmxlDQo+PiB2MS4gVGhpcyB3b3VsZCByZXN1bHQg aW4gY3Jhc2hlcyBpbiBkZWJ1ZyBidWlsZHMgZHVlIHRvDQo+PiBBU1NFUlRfVU5SRUFDSEFC TEUoKSB0cmlnZ2VyaW5nLg0KPj4NCj4+IEJhc2ljYWxseSByZXZlcnQgc2FpZCBjb21taXQs IGJ1dCBrZWVwIHJldHVybmluZyAtRU5PREFUQSBpbiB0aGF0IGNhc2UuDQo+Pg0KPj4gRml4 ZXM6IDlkYzQ2Mzg2ZDg5ZCAoImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVu aW5pdGlhbGl6ZWQiIHdhcm5pbmciKQ0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9z cyA8amdyb3NzQHN1c2UuY29tPg0KPj4gLS0tDQo+PiBNaWdodCBiZSBjb25zaWRlcmVkIGZv ciA0LjE3IGFuZCBmb3IgYmFja3BvcnRpbmcNCj4+IC0tLQ0KPj4gICB4ZW4vY29tbW9uL2dy YW50X3RhYmxlLmMgfCAxNCArKystLS0tLS0tLS0tLQ0KPj4gICAxIGZpbGUgY2hhbmdlZCwg MyBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEv eGVuL2NvbW1vbi9ncmFudF90YWJsZS5jIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jDQo+ PiBpbmRleCBhZDc3M2E2OTk2Li42OGU3ZjFkZjM4IDEwMDY0NA0KPj4gLS0tIGEveGVuL2Nv bW1vbi9ncmFudF90YWJsZS5jDQo+PiArKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMN Cj4+IEBAIC00MTI1LDcgKzQxMjUsMTAgQEAgaW50IGdudHRhYl9hY3F1aXJlX3Jlc291cmNl KA0KPj4gICANCj4+ICAgICAgIGNhc2UgWEVOTUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lk X3N0YXR1czoNCj4+ICAgICAgICAgICBpZiAoIGd0LT5ndF92ZXJzaW9uICE9IDIgKQ0KPj4g KyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHJjID0gLUVOT0RBVEE7DQo+PiAgICAgICAg ICAgICAgIGJyZWFrOw0KPj4gKyAgICAgICAgfQ0KPiANCj4gVGhpcyBwYXRoIGlzIHN1cHBv c2VkIHRvIHByb2R1Y2UgLUVJTlZBTC4NCg0KT2theS4NCg0KPiANCj4+IEBAIC00MTM1LDE3 ICs0MTM4LDYgQEAgaW50IGdudHRhYl9hY3F1aXJlX3Jlc291cmNlKA0KPj4gICAgICAgICAg IGJyZWFrOw0KPj4gICAgICAgfQ0KPj4gICANCj4+IC0gICAgLyoNCj4+IC0gICAgICogU29t ZSBvbGRlciB0b29sY2hhaW5zIGNhbid0IHNwb3QgdGhhdCB2YWRkcnMgd29uJ3QgcmVtYWlu IHVuaW5pdGlhbGl6ZWQNCj4+IC0gICAgICogb24gbm9uLWVycm9yIHBhdGhzLCBhbmQgaGVu Y2UgaXQgbmVlZHMgc2V0dGluZyB0byBOVUxMIGF0IHRoZSB0b3Agb2YgdGhlDQo+PiAtICAg ICAqIGZ1bmN0aW9uLiAgTGVhdmUgc29tZSBydW50aW1lIHNhZmV0eS4NCj4+IC0gICAgICov DQo+PiAtICAgIGlmICggIXZhZGRycyApDQo+IA0KPiBJIGd1ZXNzIHRoaXMgd2FudHMgYW1l bmRpbmcgYnkgIiYmICFyYyI/DQoNCkkgY2FuIGRvIHRoYXQsIGlmIHlvdSBsaWtlIHRoYXQg YmV0dGVyLg0KDQoNCkp1ZXJnZW4NCg== --------------aaYZ0EBWowl0Pf0ZVZVEXwvO Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------aaYZ0EBWowl0Pf0ZVZVEXwvO-- --------------Hwig5wVfU0dMwqGVZR3TVSxA-- --------------sKEWVXj645OmzupvKhjAA2ss Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMbBqMFAwAAAAAACgkQsN6d1ii/Ey+w kQf/YFcJa5HFjDkLU+kbkQEVVCD10J4zONOXy6LNaNal/tCGADZ0EBF1W0KbpZTjH26Osv0ANZeP KOldAdym/H/SSdP1pwZK5XgG1yXiDEieU05lwAYqiZLDPukaK7iah18yEoXSNpvHd/Fg0XZrSvdT QX18HnkFP5WcUJ9ypbnrIkO4s9dK8Euadd22YfMM6VqpXl8As7lIAP3vOjTTACFhEDEHHov52ffa S+jXuXiiXsXIj50pKg0ahryHA1ob2WMaAK0R++5EUYl0PkMgdFxaoUokgHQCkaxAQs2behdHTEz3 wKwzRW3fIy3NDCDns7O3GrvauVakNHIOLPFx2AyqGA== =TwWj -----END PGP SIGNATURE----- --------------sKEWVXj645OmzupvKhjAA2ss-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:27:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:27:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404001.646295 (Exim 4.92) (envelope-from ) id 1oWaIJ-0001JJ-F2; Fri, 09 Sep 2022 09:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404001.646295; Fri, 09 Sep 2022 09:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaIJ-0001JC-CE; Fri, 09 Sep 2022 09:27:27 +0000 Received: by outflank-mailman (input) for mailman id 404001; Fri, 09 Sep 2022 09:27:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaII-0001J6-Tn for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:27:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaII-0005vC-FR; Fri, 09 Sep 2022 09:27:26 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWaII-0008Pg-9C; Fri, 09 Sep 2022 09:27:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+MshMKp5wy0LTvlN+g4l+lhQ7Yy6sESqRFmzSc/zp3c=; b=sFYWp3FIC50ZGjjtgWA7pLNiRQ j8WoYTRTdNPuPHfvh648/cdn/IkuQzXFW8e2+78YLmOhfSXV+p7WHSSqPwrbW8sFmzyvY8QT3xgGT Lr7T7SBto4Nfh2Ki9lTB5kXzXOnzgUG6WmVZG/ZSXNdfx8XgvVI8y4TeNgtStH9dqOjw=; Message-ID: <34ae5402-799e-1c43-7ab2-6e8935471cc2@xen.org> Date: Fri, 9 Sep 2022 10:27:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Content-Language: en-US To: Bertrand Marquis , Stefano Stabellini Cc: Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Volodymyr Babchuk References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> From: Julien Grall In-Reply-To: <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 09/09/2022 08:45, Bertrand Marquis wrote: >> >> It should be: >> >> /* >> * TODO: >> * >> >> I think this is good to go. The two minor style issues could be fixed on >> commit. I haven't committed to give Julien & Bertrand another chance to >> have a look. > > I think that it is ok to fix those on commit and I am ok with the rest so: > Reviewed-by: Bertrand Marquis This series doesn't build without !CONFIG_STATIC_SHM: UPD include/xen/compile.h Xen 4.17-unstable make[1]: Nothing to be done for `include'. make[1]: `arch/arm/include/asm/asm-offsets.h' is up to date. CC common/version.o LD common/built_in.o CC arch/arm/domain_build.o arch/arm/domain_build.c: In function ‘make_shm_memory_node’: arch/arm/domain_build.c:1445:1: error: no return statement in function returning non-void [-Werror=return-type] } ^ cc1: all warnings being treated as errors make[2]: *** [arch/arm/domain_build.o] Error 1 make[1]: *** [arch/arm] Error 2 make: *** [xen] Error 2 This is because... >>> + * - xen,offset: (borrower VMs only) >>> + * 64 bit integer offset within the owner virtual machine's shared >>> + * memory region used for the mapping in the borrower VM >>> + */ >>> + res = fdt_property_u64(fdt, "xen,offset", 0); >>> + if ( res ) >>> + return res; >>> + >>> + res = fdt_end_node(fdt); >>> + if ( res ) >>> + return res; >>> + } >>> + >>> + return res; >>> +} >>> +#else >>> +static int __init make_shm_memory_node(const struct domain *d, >>> + void *fdt, >>> + int addrcells, int sizecells, >>> + const struct meminfo *mem) >>> +{ >>> + ASSERT_UNREACHABLE(); ... there is a missing 'return -ENOTSUPP' here. While this is simple enough to fix, this indicates to me that this version was not tested with !CONFIG_STATIC_SHM. As this is the default option, I will not commit until I get confirmation that some smoke was done. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:28:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:28:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404009.646307 (Exim 4.92) (envelope-from ) id 1oWaJI-0001uB-Ph; Fri, 09 Sep 2022 09:28:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404009.646307; Fri, 09 Sep 2022 09:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaJI-0001u4-MU; Fri, 09 Sep 2022 09:28:28 +0000 Received: by outflank-mailman (input) for mailman id 404009; Fri, 09 Sep 2022 09:28:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaJH-0001ts-Rv for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:28:27 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140083.outbound.protection.outlook.com [40.107.14.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b8fb0caa-3021-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:28:11 +0200 (CEST) Received: from DU2PR04CA0155.eurprd04.prod.outlook.com (2603:10a6:10:2b0::10) by DB4PR08MB8005.eurprd08.prod.outlook.com (2603:10a6:10:38f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 09:28:09 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::6c) by DU2PR04CA0155.outlook.office365.com (2603:10a6:10:2b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19 via Frontend Transport; Fri, 9 Sep 2022 09:28:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 09:28:09 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 09 Sep 2022 09:28:09 +0000 Received: from 0dfc23488b41.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9F22DE25-0FD1-4207-9B84-0357D602DE02.1; Fri, 09 Sep 2022 09:28:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0dfc23488b41.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 09:28:02 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7526.eurprd08.prod.outlook.com (2603:10a6:102:24c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 09:28:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 9 Sep 2022 09:28:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8fb0caa-3021-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CVfytnJrAEioKb5EnuSIeY2NnLZZErXf7cqMlEFGXVDTzp8hAIja/JOvt2vTgbTGV+jWp6Ousc7pZoviu42427oConD6vQOnTd72tKOpE60JnnFIuLceXi2zz6fkZSY6MVeKgHTWnxI8L464egECTz1UhVJwN39f2NmELMg5kJMQokI3U6vIL0CxveXCqj6qDFv0XgPC7XGqmZCgxDtaFk0C96Oz1v1rSUl3QtKwrZMR0SKch+4Tp0Ll3b8EETBVdZgmvVhcGeV1MRzWEO+gIV0pLnZ+IflHx10ZWzQ4NdQANV1Msm9VAKnXl/DWVQG5OoTMPopHsGGZyxMfnKd8RA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kgJSWlLo9EZdbb+rCibH02vHb+lE9i8BFvajnfVAn/Q=; b=cRk11qnxFoM5sV461PAXPFhHzJao4tZwYuoamizV1fPkdz3WLDvhdLoB1n/5z0yIHSiyI2jeRbUO644lQMpOOWwhLrJl5jSLjKMGUhhxYy0UEgOJa6Dmf/EhnUynU5AsgwPx/GLvlAjQ267525Wht2jraUHIIUyj68KO5iMOoh+TS5fRtNCbxxa+OmT+ufgvHBASZJZCdgR6Me6lzVxAm+MqYSs08Si/mPD4uUNanK50qG2yLjW6ThtJrAZRSxEGCHe68LONjgPcd9qBJg38KbeXB4rEA03hDi21EzeX35+JpsaLCiwnUULNy3fAe1wSTDDl7YjXLhj3NcTfFhGOAQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgJSWlLo9EZdbb+rCibH02vHb+lE9i8BFvajnfVAn/Q=; b=Mf76/a/kpsbbguFposPWc1eTRhQ9mLYYQFz6jvDe3LO23RdyQyEcNXPG/FqNkKfjBE8bVdjeWGcPMW4qTvDgfPhPSDHb6NUx/DFk3emBZ5qO26B5AVaMQI/ad2aPXVZvp2IZSjL9KsC3g//zS7tHIzYyLDdt0LRtKhoHPuOQQyg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ba46xi9opBDiaHLG1aDN6Q7TbudErrucuIHmFRDq7n4G16sOsDcKeZywVZJZxHX+NywCleK8TTc2QLe/fHe9IP9tUu+ArhRZL91/EPE6Eau+yPztplXUFzOBsHqCS8mNboiTaST9XNyNOonqB/qVSmYaSLDPBDySQdljj8t4y6QNegOcPSMQKxqzLumK8f1oxGempXIl6wEaMrpsmq4198pFpUbmoflvOaKWln143isI62F7ljXyq+wPb7BblfL/EIvtjTYQ2onIoGJ7ZPNVy4UHIjhPY52nTCbzcXHegn7Xynd32neEl6J6ga12mzpSuYK5aUIyo4vhR4hAwaTUdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kgJSWlLo9EZdbb+rCibH02vHb+lE9i8BFvajnfVAn/Q=; b=oD5um1sSyBnTpZKv08UXMxFpImjFRVAo/aSWU9xGSiROnmN3dEb2fH3WD0361EcfHTI/E85+RMfpt+jkMEUmR2iWFGO7tHmOU2b429RkG0tqWIJoCYj05U15BdfZvVMZ0og84ckT3yqJbl3q3oQxkt6EOyqZ79uJCm6HZmMKO8V6DBGioxuzNxE5Ngyuqy1c/iaJee7dudreU/r0js9oXDT0PNxJkKvYxFoHu4pTkLhJlLoePw0EiAIcFVnE1Q56xFlCYHh1jjhqD9R9tzVi+ZF7tQr4v/MYRrmVxTcOR9528V8L1jiO6Grlr/YY8Nnb6iN1AbcvzRPdn/OB1W1xew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgJSWlLo9EZdbb+rCibH02vHb+lE9i8BFvajnfVAn/Q=; b=Mf76/a/kpsbbguFposPWc1eTRhQ9mLYYQFz6jvDe3LO23RdyQyEcNXPG/FqNkKfjBE8bVdjeWGcPMW4qTvDgfPhPSDHb6NUx/DFk3emBZ5qO26B5AVaMQI/ad2aPXVZvp2IZSjL9KsC3g//zS7tHIzYyLDdt0LRtKhoHPuOQQyg= From: Henry Wang To: Juergen Gross , Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Topic: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Index: AQHYxCOLeMow4nnAdEmRQz42iuSBI63W0QoAgAADAYCAAABeMA== Date: Fri, 9 Sep 2022 09:28:00 +0000 Message-ID: References: <20220909080944.28559-1-jgross@suse.com> <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> In-Reply-To: <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E4BF98529A7ACA4897C74FAFEF9750FD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 89323922-c477-4ea9-1612-08da92459bc9 x-ms-traffictypediagnostic: PAXPR08MB7526:EE_|DBAEUR03FT037:EE_|DB4PR08MB8005:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: h9+GMzz03EGnn3eibphGt1HiTdnFeW1SuAHobXseN013UqFtkP0hZHOLinCSBZyAfWsKqwUo/zlaARMBmWwtQD4Q6Q4OszkMVxqpNEdN1aN4Ax4CId6SfDK7CQGo/NaINfoMzphwvc3UY6N9rVd7YleR/t+7UYP1IaE6rruxoLJ3IRUijROFno/dA6Z2xdiMtuYGw74PLOjaUDHrADV4xK5iVD1L48GfDG7qmuoyBdEJy5NfDzCnrzXGRDIn5Kaj3H2CrR2GCdday5b/f+woU9pIYa0tfIiKC0NPtGfd2RVGcju5BxREsYp685tShYM2dXGhDMsUk51rCuvxK5xJTdlFoi4vVWVAbHhuLq4sTVd/aW0kiXICEXNDDmUxkoRcR3KJWQsjfTLDvnUWgroRkwU/Mq17XqTfdqbFl5EeRpFc5DKB5GdKel3jG/55nVQL0HmcaB/EK6miBwVwPYQA9SrR5nOaWWdKVeVP5M4HBwK9Winnm7sINabi4F/gMKDscp3i72+KV6r1BAa3uz4tLBskpPh+NvwCOa3P3xw1o2CAghy93fH7ZbwzvTpw8kFVW9UPiJXFzXAWxEcffu8p9QA+P5wWuS0ArwwdmDdG8+vzSNUkGrIs9fTDpN2V/siNedAzMxnbU0SM/Qom8MshPf0YhU6BIV+UfJZQq+EPlIKwkl3IA9eKElb49MuVoB+L0cfxSEIJSlgfjtJFxorect5S0GodtWtSd70vNDABkIB8sPO3hAUomkvNpjLnAp/mIdm4nHSp1Agu4sstDScKlg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(38070700005)(26005)(41300700001)(66556008)(64756008)(66946007)(122000001)(38100700002)(8676002)(54906003)(4326008)(66446008)(66476007)(316002)(55016003)(2906002)(110136005)(186003)(52536014)(83380400001)(71200400001)(76116006)(53546011)(478600001)(7696005)(8936002)(6506007)(33656002)(9686003)(5660300002)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7526 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 856551c3-5351-410a-31f9-08da924596d8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FpW30zERNe1dmy58PT//DJD+QEz8EiCX6dLx1l0WCpNNZdXJ0TtpNXzIfjEduRUTIBzFh6Qo2+m/wVam7d357seCruJBIWH+4laAZY1qWyjtRapOg4c8womH+Vc2LZaPSkyFpO3hLdRm5qqb9nKHch8kkwHNSkgleiKb9qP6PVgjCtjJCfklCuuAtd4/WAiSNstLQ1+HlK6WjVItsBtpIwiUbjyWT2DVOrtKav5CLxOiv0VXz9eUkQKwr/SnxOXIdfvpW3BYucS0IKMg7xR5bxN1jEntzOboSxEdmH1PwmBcc3bTDItEma5rg/2gmpoPyObJzmetfSeP1JtgpLGqxjFDJVaIF0CS0qZX/2kVBhuDgD3uXun72nssfya9c24HM1wuHaL/o5qAe69ZfsewQ4b92x/fIo7xktykMCqB5ldlhI1A3JqFtSrUOq7whwCmU4HZuDXen6llxULsrDEEIokzFuXfYwwpuPLxAQIWoSsucod9Je8KAZw/Mua6z43r3npq+JhDzHK0lKK+JdedNY+BbSinY9AOgWb8yS+5JGUcGMuPr3J0qh+FF+xdidhRIDn6SV9o9vprn5Bc3fkcy8Nbofu0ISn9sstRuLBk1FJeUYxs1LqKjSohWPgXfbwOTypqJ251ytK06nrYJhKv/3a4Z63c5RnOYkt5l+R+DrdYYDdTz6zDb6EK1zLrlQOpykEypTzzM/Mz0BCJeNlpFVOGOx5qdQnThBhS37AG9JSc1J/ZhJhJ1Q2kLnyWyPjprbPVSmYITOb6ll9ag4Whaw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(136003)(39860400002)(46966006)(40470700004)(36840700001)(70206006)(54906003)(70586007)(110136005)(83380400001)(53546011)(9686003)(26005)(7696005)(478600001)(316002)(82310400005)(40480700001)(86362001)(33656002)(47076005)(55016003)(8676002)(186003)(336012)(4326008)(6506007)(356005)(5660300002)(2906002)(52536014)(81166007)(8936002)(82740400003)(41300700001)(36860700001)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:28:09.0392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89323922-c477-4ea9-1612-08da92459bc9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8005 DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+IEZyb206IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gU2VudDogRnJp ZGF5LCBTZXB0ZW1iZXIgOSwgMjAyMiA1OjI2IFBNDQo+IFRvOiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+DQo+IENjOiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+OyBBbmRy ZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcCA8 Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsNCj4gSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9y Zz47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47DQo+IFdlaSBM aXUgPHdsQHhlbi5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVj dDogUmU6IFtQQVRDSF0geGVuL2dudHRhYjogZml4IGdudHRhYl9hY3F1aXJlX3Jlc291cmNlKCkN Cj4gDQo+IE9uIDA5LjA5LjIyIDExOjE1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPiBPbiAwOS4w OS4yMDIyIDEwOjA5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPiA+PiBDb21taXQgOWRjNDYzODZk ODlkICgiZ250dGFiOiB3b3JrIGFyb3VuZCAibWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCINCj4g Pj4gd2FybmluZyIpIHdhcyB3cm9uZywgYXMgdmFkZHIgY2FuIGxlZ2l0aW1hdGVseSBiZSBOVUxM IGluIGNhc2UNCj4gPj4gWEVOTUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lkX3N0YXR1cyB3YXMg c3BlY2lmaWVkIGZvciBhIGdyYW50IHRhYmxlDQo+ID4+IHYxLiBUaGlzIHdvdWxkIHJlc3VsdCBp biBjcmFzaGVzIGluIGRlYnVnIGJ1aWxkcyBkdWUgdG8NCj4gPj4gQVNTRVJUX1VOUkVBQ0hBQkxF KCkgdHJpZ2dlcmluZy4NCj4gPj4NCj4gPj4gQmFzaWNhbGx5IHJldmVydCBzYWlkIGNvbW1pdCwg YnV0IGtlZXAgcmV0dXJuaW5nIC1FTk9EQVRBIGluIHRoYXQgY2FzZS4NCj4gPj4NCj4gPj4gRml4 ZXM6IDlkYzQ2Mzg2ZDg5ZCAoImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5p dGlhbGl6ZWQiDQo+IHdhcm5pbmciKQ0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+DQo+ID4+IC0tLQ0KPiA+PiBNaWdodCBiZSBjb25zaWRlcmVkIGZv ciA0LjE3IGFuZCBmb3IgYmFja3BvcnRpbmcNCj4gPj4gLS0tDQo+ID4+ICAgeGVuL2NvbW1vbi9n cmFudF90YWJsZS5jIHwgMTQgKysrLS0tLS0tLS0tLS0NCj4gPj4gICAxIGZpbGUgY2hhbmdlZCwg MyBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkNCj4gPj4NCj4gPj4gZGlmZiAtLWdpdCBh L3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYyBiL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYw0KPiA+ PiBpbmRleCBhZDc3M2E2OTk2Li42OGU3ZjFkZjM4IDEwMDY0NA0KPiA+PiAtLS0gYS94ZW4vY29t bW9uL2dyYW50X3RhYmxlLmMNCj4gPj4gKysrIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jDQo+ ID4+IEBAIC00MTI1LDcgKzQxMjUsMTAgQEAgaW50IGdudHRhYl9hY3F1aXJlX3Jlc291cmNlKA0K PiA+Pg0KPiA+PiAgICAgICBjYXNlIFhFTk1FTV9yZXNvdXJjZV9ncmFudF90YWJsZV9pZF9zdGF0 dXM6DQo+ID4+ICAgICAgICAgICBpZiAoIGd0LT5ndF92ZXJzaW9uICE9IDIgKQ0KPiA+PiArICAg ICAgICB7DQo+ID4+ICsgICAgICAgICAgICByYyA9IC1FTk9EQVRBOw0KPiA+PiAgICAgICAgICAg ICAgIGJyZWFrOw0KPiA+PiArICAgICAgICB9DQo+ID4NCj4gPiBUaGlzIHBhdGggaXMgc3VwcG9z ZWQgdG8gcHJvZHVjZSAtRUlOVkFMLg0KPiANCj4gT2theS4NCj4gDQo+ID4NCj4gPj4gQEAgLTQx MzUsMTcgKzQxMzgsNiBAQCBpbnQgZ250dGFiX2FjcXVpcmVfcmVzb3VyY2UoDQo+ID4+ICAgICAg ICAgICBicmVhazsNCj4gPj4gICAgICAgfQ0KPiA+Pg0KPiA+PiAtICAgIC8qDQo+ID4+IC0gICAg ICogU29tZSBvbGRlciB0b29sY2hhaW5zIGNhbid0IHNwb3QgdGhhdCB2YWRkcnMgd29uJ3QgcmVt YWluDQo+IHVuaW5pdGlhbGl6ZWQNCj4gPj4gLSAgICAgKiBvbiBub24tZXJyb3IgcGF0aHMsIGFu ZCBoZW5jZSBpdCBuZWVkcyBzZXR0aW5nIHRvIE5VTEwgYXQgdGhlIHRvcCBvZg0KPiB0aGUNCj4g Pj4gLSAgICAgKiBmdW5jdGlvbi4gIExlYXZlIHNvbWUgcnVudGltZSBzYWZldHkuDQo+ID4+IC0g ICAgICovDQo+ID4+IC0gICAgaWYgKCAhdmFkZHJzICkNCj4gPg0KPiA+IEkgZ3Vlc3MgdGhpcyB3 YW50cyBhbWVuZGluZyBieSAiJiYgIXJjIj8NCj4gDQo+IEkgY2FuIGRvIHRoYXQsIGlmIHlvdSBs aWtlIHRoYXQgYmV0dGVyLg0KPiANCj4gDQo+IEp1ZXJnZW4NCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:29:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:29:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404016.646318 (Exim 4.92) (envelope-from ) id 1oWaJz-0002nq-3R; Fri, 09 Sep 2022 09:29:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404016.646318; Fri, 09 Sep 2022 09:29:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaJy-0002nj-WC; Fri, 09 Sep 2022 09:29:11 +0000 Received: by outflank-mailman (input) for mailman id 404016; Fri, 09 Sep 2022 09:29:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaJx-0002nU-7L for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:29:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaJu-0005xY-4x; Fri, 09 Sep 2022 09:29:06 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWaJt-0008SB-TZ; Fri, 09 Sep 2022 09:29:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=OYWEndsuigTxfVwCTpaAjzjJElinrnZLsB7dLsfGigc=; b=MJrEzB++yAsqsapxKupAvQD/nw NsJT7WaTUQVi3CWwW97gYgoKVtm8WbyR4/CnLe4kQ6V3BsRnS8RkspRSLR3kG83sMgh7TDDIBuTC5 v/BTmkUkHlZh9oB+IfbUnWk9/+vT6fpN8ecADfj70g2TB3yBTychCRx6mq+1Wel+mJo8=; Message-ID: <79382cfc-9567-a3a3-e91f-6d242dc7c0ca@xen.org> Date: Fri, 9 Sep 2022 10:29:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Juergen Gross , Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220909080944.28559-1-jgross@suse.com> <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> From: Julien Grall In-Reply-To: <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/09/2022 10:25, Juergen Gross wrote: > On 09.09.22 11:15, Jan Beulich wrote: >> On 09.09.2022 10:09, Juergen Gross wrote: >>> Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" >>> warning") was wrong, as vaddr can legitimately be NULL in case >>> XENMEM_resource_grant_table_id_status was specified for a grant table >>> v1. This would result in crashes in debug builds due to >>> ASSERT_UNREACHABLE() triggering. >>> >>> Basically revert said commit, but keep returning -ENODATA in that case. >>> >>> Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" >>> warning") >>> Signed-off-by: Juergen Gross >>> --- >>> Might be considered for 4.17 and for backporting >>> --- >>>   xen/common/grant_table.c | 14 +++----------- >>>   1 file changed, 3 insertions(+), 11 deletions(-) >>> >>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c >>> index ad773a6996..68e7f1df38 100644 >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -4125,7 +4125,10 @@ int gnttab_acquire_resource( >>>       case XENMEM_resource_grant_table_id_status: >>>           if ( gt->gt_version != 2 ) >>> +        { >>> +            rc = -ENODATA; >>>               break; >>> +        } >> >> This path is supposed to produce -EINVAL. > > Okay. > >> >>> @@ -4135,17 +4138,6 @@ int gnttab_acquire_resource( >>>           break; >>>       } >>> -    /* >>> -     * Some older toolchains can't spot that vaddrs won't remain >>> uninitialized >>> -     * on non-error paths, and hence it needs setting to NULL at the >>> top of the >>> -     * function.  Leave some runtime safety. >>> -     */ >>> -    if ( !vaddrs ) >> >> I guess this wants amending by "&& !rc"? > > I can do that, if you like that better. I would prefer that as well. Although I think it would be clear if we write " if ( rc ) return rc else if ( !vaddrs ) " Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:33:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:33:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404024.646332 (Exim 4.92) (envelope-from ) id 1oWaNu-0004Ja-Ln; Fri, 09 Sep 2022 09:33:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404024.646332; Fri, 09 Sep 2022 09:33:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaNu-0004JT-IS; Fri, 09 Sep 2022 09:33:14 +0000 Received: by outflank-mailman (input) for mailman id 404024; Fri, 09 Sep 2022 09:33:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaNt-0004JI-4i for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:33:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaNs-00063M-SK; Fri, 09 Sep 2022 09:33:12 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWaNs-0000Go-Kv; Fri, 09 Sep 2022 09:33:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=i8D8d5q/5gBssAo4Jm9hIilkoUju3HSkErG1YCEYVpc=; b=N2WmzCKQJFjLW+WoRf4ndrpvkR OpiWU8PdVqnPS4M19Qc4DjgDlkS89Bmhly+Uk4AmtGO4XC9HObCoWFyD1eofQj00M6oICuibaJ+Hv qMXoUmmZicpJHU5tQ7BO6Nh2JE3gEhbiyHFlFpPH+AuOMSBnLperzV15yRWD+VxhK7YQ=; Message-ID: <807c0fad-cf2b-7fcd-97b2-b49d026926c0@xen.org> Date: Fri, 9 Sep 2022 10:33:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] docs/device-tree: Place the static-heap dt-binding in proper place Content-Language: en-US From: Julien Grall To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220908120728.8290-1-Henry.Wang@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/09/2022 14:05, Julien Grall wrote: > Hi Henry, > > On 08/09/2022 13:07, Henry Wang wrote: >> The static-heap dt-binding should be placed after the last feature, >> namely static-evtchn. >> >> Fixes: 4596329291f5 ("docs, xen/arm: Introduce static heap memory") >> Signed-off-by: Henry Wang > > Thanks for fixing the mistake I did while committing the patch :). > > Acked-by: Julien Grall And committed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:34:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:34:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404031.646343 (Exim 4.92) (envelope-from ) id 1oWaPW-0004u1-VX; Fri, 09 Sep 2022 09:34:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404031.646343; Fri, 09 Sep 2022 09:34:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaPW-0004tu-Si; Fri, 09 Sep 2022 09:34:54 +0000 Received: by outflank-mailman (input) for mailman id 404031; Fri, 09 Sep 2022 09:34:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaPV-0004tm-Pr for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:34:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9f2983fd-3022-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:34:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F57715DB; Fri, 9 Sep 2022 02:34:58 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D4CD3F73D; Fri, 9 Sep 2022 02:34:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f2983fd-3022-11ed-9760-273f2230c3a0 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v6 0/2] xen/pci: implement is_memory_hole for ARM Date: Fri, 9 Sep 2022 10:34:38 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 ++- xen/arch/arm/pci/pci-host-common.c | 58 ++++++++++++++++++++++++++++-- xen/arch/x86/include/asm/pci.h | 10 ++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 74 insertions(+), 7 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:35:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:35:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404042.646355 (Exim 4.92) (envelope-from ) id 1oWaQJ-0005W6-E4; Fri, 09 Sep 2022 09:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404042.646355; Fri, 09 Sep 2022 09:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaQJ-0005Vz-BL; Fri, 09 Sep 2022 09:35:43 +0000 Received: by outflank-mailman (input) for mailman id 404042; Fri, 09 Sep 2022 09:35:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaQH-0005FS-PL for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:35:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id c4a4c3ca-3022-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 11:35:40 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AB7615DB; Fri, 9 Sep 2022 02:35:46 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A3CB3F73D; Fri, 9 Sep 2022 02:35:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4a4c3ca-3022-11ed-a31c-8f8a9ae3403f From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: [PATCH v6 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev Date: Fri, 9 Sep 2022 10:34:39 +0100 Message-Id: <6f321bfd09a4e95d8280b9178dc8645e2cb6b2d2.1662715131.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Oleksandr Tyshchenko --- Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - no changes --- --- xen/arch/arm/include/asm/pci.h | 3 ++- xen/arch/arm/pci/pci-host-common.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 7c7449d64f..80a2431804 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -106,7 +106,8 @@ bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d, struct pci_host_bridge *bridge, uint64_t addr); struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus); -struct dt_device_node *pci_find_host_bridge_node(struct device *dev); +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev); int pci_get_host_bridge_segment(const struct dt_device_node *node, uint16_t *segment); diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index fd8c0f837a..89ef30028e 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -243,10 +243,10 @@ err_exit: /* * Get host bridge node given a device attached to it. */ -struct dt_device_node *pci_find_host_bridge_node(struct device *dev) +const struct dt_device_node * +pci_find_host_bridge_node(const struct pci_dev *pdev) { struct pci_host_bridge *bridge; - struct pci_dev *pdev = dev_to_pci(dev); bridge = pci_find_host_bridge(pdev->seg, pdev->bus); if ( unlikely(!bridge) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:35:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:35:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404043.646366 (Exim 4.92) (envelope-from ) id 1oWaQW-0005wG-Lk; Fri, 09 Sep 2022 09:35:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404043.646366; Fri, 09 Sep 2022 09:35:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaQW-0005w7-IQ; Fri, 09 Sep 2022 09:35:56 +0000 Received: by outflank-mailman (input) for mailman id 404043; Fri, 09 Sep 2022 09:35:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaQU-0005FS-UC for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:35:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cc73ce15-3022-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 11:35:53 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7961815DB; Fri, 9 Sep 2022 02:35:59 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D30403F73D; Fri, 9 Sep 2022 02:35:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc73ce15-3022-11ed-a31c-8f8a9ae3403f From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v6 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar Date: Fri, 9 Sep 2022 10:34:40 +0100 Message-Id: <851cdf28f007326e9f7e1aaeab3688498aaecc9e.1662715131.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memory_hole which will check if BAR is not overlapping with any memory region defined in the memory map. On ARM, pci_check_bar will go through the host bridge ranges and check if the BAR is in the range of defined ranges. Signed-off-by: Rahul Singh Acked-by: Jan Beulich --- Changes in v6: - change from unsigned long to paddr_t Changes in v5: - drop use of PFN_UP and PF_DOWN in case addresses are not aligned. - As we drop the PFN_UP and PFN_DOWN we need to use the mfn_to_maddr() to get the BAR address without page shift. - Add TODO comment for address alignment check for ranges. - Added Jan Acked-by for x86 and common code. Changes in v4: - check "s <= e" before callback - Add TODO comment for revisiting the function pci_check_bar() when ACPI PCI passthrough support is added. - Not Added the Jan Acked-by as patch is modified. Changes in v3: - fix minor comments --- --- xen/arch/arm/include/asm/pci.h | 2 ++ xen/arch/arm/pci/pci-host-common.c | 54 ++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/pci.h | 10 ++++++ xen/drivers/passthrough/pci.c | 8 ++--- 4 files changed, 70 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 80a2431804..8cb46f6b71 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, int pci_host_bridge_mappings(struct domain *d); +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); + #else /*!CONFIG_HAS_PCI*/ struct arch_pci_dev { }; diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index 89ef30028e..a8ece94303 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -24,6 +24,16 @@ #include +/* + * struct to hold pci device bar. + */ +struct pdev_bar_check +{ + paddr_t start; + paddr_t end; + bool is_valid; +}; + /* * List for all the pci host bridges. */ @@ -363,6 +373,50 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0; } +/* + * TODO: BAR addresses and Root Complex window addresses are not guaranteed + * to be page aligned. We should check for alignment but this is not the + * right place for alignment check. + */ +static int is_bar_valid(const struct dt_device_node *dev, + paddr_t addr, paddr_t len, void *data) +{ + struct pdev_bar_check *bar_data = data; + paddr_t s = bar_data->start; + paddr_t e = bar_data->end; + + if ( (s >= addr) && (e <= (addr + len - 1)) ) + bar_data->is_valid = true; + + return 0; +} + +/* TODO: Revisit this function when ACPI PCI passthrough support is added. */ +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) +{ + int ret; + const struct dt_device_node *dt_node; + paddr_t s = mfn_to_maddr(start); + paddr_t e = mfn_to_maddr(end); + struct pdev_bar_check bar_data = { + .start = s, + .end = e, + .is_valid = false + }; + + if ( s >= e ) + return false; + + dt_node = pci_find_host_bridge_node(pdev); + if ( !dt_node ) + return false; + + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); + if ( ret < 0 ) + return false; + + return bar_data.is_valid; +} /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h index c8e1a9ecdb..f4a58c8acf 100644 --- a/xen/arch/x86/include/asm/pci.h +++ b/xen/arch/x86/include/asm/pci.h @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) void arch_pci_init_pdev(struct pci_dev *pdev); +static inline bool pci_check_bar(const struct pci_dev *pdev, + mfn_t start, mfn_t end) +{ + /* + * Check if BAR is not overlapping with any memory region defined + * in the memory map. + */ + return is_memory_hole(start, end); +} + #endif /* __X86_PCI_H__ */ diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index cdaf5c247f..149f68bb6e 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) /* Unable to size, better leave memory decoding disabled. */ return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { /* * Return without enabling memory decoding if BAR position is not @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) if ( rc < 0 ) return; - if ( size && !is_memory_hole(maddr_to_mfn(addr), - maddr_to_mfn(addr + size - 1)) ) + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), + maddr_to_mfn(addr + size - 1)) ) { printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), PFN_DOWN(addr + size - 1)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:39:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404058.646376 (Exim 4.92) (envelope-from ) id 1oWaUB-00076a-5k; Fri, 09 Sep 2022 09:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404058.646376; Fri, 09 Sep 2022 09:39:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaUB-00076T-35; Fri, 09 Sep 2022 09:39:43 +0000 Received: by outflank-mailman (input) for mailman id 404058; Fri, 09 Sep 2022 09:39:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaU9-00076J-Qq; Fri, 09 Sep 2022 09:39:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaU9-0006Aq-P5; Fri, 09 Sep 2022 09:39:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaU9-0000eP-8w; Fri, 09 Sep 2022 09:39:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWaU9-0000jt-8S; Fri, 09 Sep 2022 09:39:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KGaIFMDvK0a/4OMS4FGCFnlZilYMZIjsXlUHPgTweTI=; b=alVQu0J7Z3Tt2QsrN0N5U0+akY aoAzNngg/Tlb0pj2eGxT5TaBlW3tzj62ADc6GjdRFBlwiayeS89IurxDGedY97xwvbC+ixnbMSpXV 6RhHOB/WzELWZXUtCRNY5nK/ALYQB3WKSQEmiACA37blnsJDr3byByyGyT5GSYR2c7DY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173086: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 09:39:41 +0000 flight 173086 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173086/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 273 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:40:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:40:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404066.646388 (Exim 4.92) (envelope-from ) id 1oWaUp-0008P5-Fs; Fri, 09 Sep 2022 09:40:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404066.646388; Fri, 09 Sep 2022 09:40:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaUp-0008Oy-CS; Fri, 09 Sep 2022 09:40:23 +0000 Received: by outflank-mailman (input) for mailman id 404066; Fri, 09 Sep 2022 09:40:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaUn-0008Mp-VT for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:40:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63260d58-3023-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:40:06 +0200 (CEST) Received: from DB7PR03CA0093.eurprd03.prod.outlook.com (2603:10a6:10:72::34) by DB9PR08MB9634.eurprd08.prod.outlook.com (2603:10a6:10:461::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 09:40:19 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::d2) by DB7PR03CA0093.outlook.office365.com (2603:10a6:10:72::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19 via Frontend Transport; Fri, 9 Sep 2022 09:40:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 09:40:19 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 09 Sep 2022 09:40:19 +0000 Received: from 135d6e078c0a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1AD8D72B-A131-4FF2-A794-7C83BE4B5B36.1; Fri, 09 Sep 2022 09:40:08 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 135d6e078c0a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 09:40:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB6672.eurprd08.prod.outlook.com (2603:10a6:102:137::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 09:40:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5612.018; Fri, 9 Sep 2022 09:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63260d58-3023-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iPxL6SOvSm2/gU6IU6jNFvS9uBZypQ3sEpL/mZQBhFO7CXNrCVWcWpiQCl1dbSI1X6KnjUi7eIxIu1TdN/nN+g7mgxhEGUxAlm4Hb6eq4huEhRMK2p7stFB+Qf53jqFpU4PLDDAnUN8oWoL5m5WbL967ItiK9jd0hPGbbIELn7DAFpVhrhK/OLC+S4BnHMz3XDv/7m8f50Gn7v1y5pG6VWp5a5xv6Z+oJ3C9JFXBUeArGf2LbwNKs5x83zDop83Jg4Fj0cR5JNNWprV8kts0KkigdmUQU+IF0W8AUbS5lRUHBOUkrLPYxoe1hkaAraYckCQXAW74HboUDWtUL2D1aQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+GUpoA+0IYWwf1mxytoEU/YggCxr4iM9t5BXeRjwvs=; b=SZTPg9WAgIlC2VXU1HrAfwovmTwfRzr4L3r6nV7zseOFyMoR40RQzOtTkWDlX+HztyX9cPJE2UK7fuNLE9/IWKw9ulzHsQppZ7OAd8tFTMNk4R0Dbf6AA9H2jIfVF3sDMi7MNW1yHsTzpEFDUFDiTUqccanKEpQBZn3UHEjRze5O4bxdyfDUPDODmxggYdfROYmP6FGzhWTmHsoL7sl776UX+BWst+uyynKGDdMEuaxcFRrSl+m4YY11gAW2FRqbaN1S5U0HqgSpQqr2fs54z/1J3TIaqgFyRL8efBIj++vAqEm4/2mZqU3V6qPyw+bgS5QACP204jDvJWFR8T2Q7w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+GUpoA+0IYWwf1mxytoEU/YggCxr4iM9t5BXeRjwvs=; b=7mp1J+thizoeeahT8VqL8qlqrFHNEEYa7dm3LeN7198b6O4jTmFnz4eybP6CC+HvwRJClL/YStqszlO43zqVi4Vb/BYB2tN3WLxXXjmSxQuzmVAkaPSuL6CLZJstC7gHtv+AMiDrszj9a/gnRN2FcyZGyCqZ8BXtQHcKi9lZrvo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 913eb5b7f542c10f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NYigJ89/ELgbP54cu5LVq3V0kOVUNMs2fQMgbvC3O4S8ZGdzixo2k+e+kMq1U7x/EhNMIAW5hiyVmFgtRN6wOiN/sng8F5XCypUNKVnLaYRvI533ERNVPjAxD9ThXrP/smr0XdxOeaUj+4XlGA/46gyjsF+9X5sdudYwiAgapBJVaLOcSNFYlm4PV9wD12B0pYukLhq3htbvAPmOFb/IvulGxFqwmKmBQVFofqjLcoxCPJnI1kiWIbAzStqzd4hC/fbiN13nrwujajL13CnS0CbIbJujK01cOIeYhkfMPR0z7Vcz9TEWr2KKXhPFOhlAqG6mMIeeMuhiriiQTSb/3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+GUpoA+0IYWwf1mxytoEU/YggCxr4iM9t5BXeRjwvs=; b=jFV0qN42ZH6Xg7/vZgeOvoBidhEj1w79UmqhzbT73r7evwsxDVqWBRQ+Lmf+BrH0OGcukGlYWy8+9hwbmi/jSu89jwFMpLbl5gsoxfShwu6egh0QGl4tK7YA2xXbEMXWvHgQ2OtSJ/xNhU1Ey7SFj7FpdlRo/aOFmAOz1ZIcTAiPphjjKhUR5ggs7IyBT72e+g++aJzV2pYw1EbSE6eZ3Psydm1kpMppKrbjTlJsR27AgiUNvmOy1vIuVzmPfc+jKVME6Y4hNqkjArXQlNq78e1j4gndMTX7bXsMOUOE0ndgsbF/g5g+t4suCwKxaos/1535w1wiv/gw/L1f/f3VBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+GUpoA+0IYWwf1mxytoEU/YggCxr4iM9t5BXeRjwvs=; b=7mp1J+thizoeeahT8VqL8qlqrFHNEEYa7dm3LeN7198b6O4jTmFnz4eybP6CC+HvwRJClL/YStqszlO43zqVi4Vb/BYB2tN3WLxXXjmSxQuzmVAkaPSuL6CLZJstC7gHtv+AMiDrszj9a/gnRN2FcyZGyCqZ8BXtQHcKi9lZrvo= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Volodymyr Babchuk Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYw4q6erckyWfXI0qMZ5bjaFqTVq3WBmMAgACy1QCAABxvAIAAA4uA Date: Fri, 9 Sep 2022 09:40:06 +0000 Message-ID: References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> <34ae5402-799e-1c43-7ab2-6e8935471cc2@xen.org> In-Reply-To: <34ae5402-799e-1c43-7ab2-6e8935471cc2@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAXPR08MB6672:EE_|DBAEUR03FT062:EE_|DB9PR08MB9634:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a924c0e-3db4-42c3-501d-08da92474eff x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SYcrYfBZ/IbXrCNSeXijloBmevlrPGGOLl9l2fXmfu90y71F2RGHBG3s5Vy9nZvNomjsmrYb649qgPlIdYOmGCZHbMS2FNAshYI4KXc1q2KP8V7n1UsQJXpafkVk8wOyqnQEjq0KsM4Q8YmhGUROZkQg7xmBIjVpMJ9w3LMVxZ++jo2394TTnnUwms03FBhDfzUPs5h9OIOnJaeuc8ECWLCyt1JsZ8y8pz5T6/y7/2OBqK0taLvKPjPUe6CewboVX/DXXzXkkxAIQOfNPzIcZ+38bsExsibsXZSPvTix3orIPORJp5sVKPRAkzAbR0FOlEqiwBw0agZj8WYwrqV5ag9VGpyiwyEcaiBJWqrTvaSHgOW4X+8SoChhGRfV8qVjQL4HMBLdSe5CaHRrLPnjhgU1qoZGk5o2++sRHpoUMm1sATtOckjeVVKq+1ZN2wi1s8LbBLxj84B83SM0F74m4kqrZ8FPqBoPnhPA2b5+TiGxmkDZRhrfY4FEWQTDB7YlElkd25x6WDxIMdopgd4tPZjDNMm2eCMozCNn/00FQjjYR6P0jlHnDlP9ddEc8oxjt1VlPLQx5/AJgWEuIUGI97TGlL8qI6kNK0pxzWk/XtkbJzKI5lPqKegn7V6g19RlrMWUfTo8zaMnHnJVZkwBVTqEJEQNDE+/u0d3RBspgc4FSpRP80H8+9S+bLqmHCwrld6PHKz/kPIQptnjUNzWYypPFeD3QlQJp+oPpuCyR3JqcuNezpxvjsp1vgxpvCCZz2Mk50omdvlkMNC70ejtbfEo347WObZfgU1ZovTkVe8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(6512007)(53546011)(41300700001)(478600001)(71200400001)(26005)(6506007)(6486002)(83380400001)(186003)(2616005)(2906002)(8936002)(5660300002)(316002)(54906003)(6916009)(8676002)(91956017)(66446008)(64756008)(66946007)(76116006)(66476007)(4326008)(66556008)(38100700002)(122000001)(38070700005)(36756003)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <6B2D8A365DBC394CA63541C984A3A6B9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6672 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f74936ae-ca96-4d7a-1b9a-08da92474742 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nUi2pAmn7RqooayOckNzIXhr3PeZAzOOlbio3q5/rNQgSb6qMNZGrFQ1Shx4NIqBB1uiHprbqiguP8lC4wN5aE3Oae/gxPnHSSc4TKa7N9EpprIUnqe9qQYfnEMQGi0BDJC1FmK68KkomqD19MaeDpOEww8MI1z0MNrpaZ5VspEuaIdHEvUmQ7mwpaSKt8B49ta26dnTksXRysGhlx0+p2V8iUzSluGsS6ULMVF8WUbTsd8KStS6AWiaqIrzKosD8yBCA/jxcUFx8k/JeAzGyzpVXuV3K83RUtzQgSU/LCEYpxrBdIcgKX/YD/3cGMI3MbDSDLG/ZXVfDGgsxhkNzH+57Ntk1CFs2lt5yMVwAX0C1s+tjomDzPnsYhuLDTl9Kz5hbUFFz4ZmIBBq7a0OL4+54dXDW6Q4a5i6oHREZHTGlS9hcR/SCNoX4jUanWBgYl5NkGffT8EmjaoXsv+Mu5Ca4gO1d9aYR4r4807RrKATzOwHREu+ZE7pvxR/vyjxeO5ON3yGOO2KcID+YV43dSCc91UZJ1SjQ6uWlxqR9UYn0T13KeXg9haG5dVKlY8PNkHGPBHitJNKz51zCWYy/wk5R92CZ+elgch1M50vzBzHrFCsgNVOnwVqWuYipVPwokvwIenE/5D3DKAx5uSoYChsHZDmZoizJiY1XrwghVEVMkpZAUxCqrWHCBHDKULGqxe3DCoNUrvC3Duy51X62FMGSPx7NNm4lbJgspEVJK2ptm2pvU1mG7Tz/82P1v5sJhEGc75q67IWEDMHK6h1Rg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(136003)(40470700004)(36840700001)(46966006)(82740400003)(40480700001)(8676002)(356005)(36860700001)(316002)(54906003)(4326008)(107886003)(6486002)(41300700001)(70586007)(36756003)(70206006)(478600001)(40460700003)(6512007)(33656002)(6862004)(26005)(83380400001)(5660300002)(6506007)(47076005)(336012)(86362001)(81166007)(53546011)(2906002)(8936002)(186003)(2616005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:40:19.1878 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a924c0e-3db4-42c3-501d-08da92474eff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9634 SGkgSnVsaWVuLA0KDQo+IE9uIDkgU2VwIDIwMjIsIGF0IDEwOjI3LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpLA0KPiANCj4gT24gMDkvMDkvMjAyMiAwODo0 NSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+PiANCj4+PiBJdCBzaG91bGQgYmU6DQo+Pj4g DQo+Pj4gLyoNCj4+PiAqIFRPRE86DQo+Pj4gKg0KPj4+IA0KPj4+IEkgdGhpbmsgdGhpcyBpcyBn b29kIHRvIGdvLiBUaGUgdHdvIG1pbm9yIHN0eWxlIGlzc3VlcyBjb3VsZCBiZSBmaXhlZCBvbg0K Pj4+IGNvbW1pdC4gSSBoYXZlbid0IGNvbW1pdHRlZCB0byBnaXZlIEp1bGllbiAmIEJlcnRyYW5k IGFub3RoZXIgY2hhbmNlIHRvDQo+Pj4gaGF2ZSBhIGxvb2suDQo+PiBJIHRoaW5rIHRoYXQgaXQg aXMgb2sgdG8gZml4IHRob3NlIG9uIGNvbW1pdCBhbmQgSSBhbSBvayB3aXRoIHRoZSByZXN0IHNv Og0KPj4gUmV2aWV3ZWQtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJt LmNvbT4NCj4gDQo+IFRoaXMgc2VyaWVzIGRvZXNuJ3QgYnVpbGQgd2l0aG91dCAhQ09ORklHX1NU QVRJQ19TSE06DQo+IA0KPiAgVVBEICAgICBpbmNsdWRlL3hlbi9jb21waWxlLmgNCj4gWGVuIDQu MTctdW5zdGFibGUNCj4gbWFrZVsxXTogTm90aGluZyB0byBiZSBkb25lIGZvciBgaW5jbHVkZScu DQo+IG1ha2VbMV06IGBhcmNoL2FybS9pbmNsdWRlL2FzbS9hc20tb2Zmc2V0cy5oJyBpcyB1cCB0 byBkYXRlLg0KPiAgQ0MgICAgICBjb21tb24vdmVyc2lvbi5vDQo+ICBMRCAgICAgIGNvbW1vbi9i dWlsdF9pbi5vDQo+ICBDQyAgICAgIGFyY2gvYXJtL2RvbWFpbl9idWlsZC5vDQo+IGFyY2gvYXJt L2RvbWFpbl9idWlsZC5jOiBJbiBmdW5jdGlvbiDigJhtYWtlX3NobV9tZW1vcnlfbm9kZeKAmToN Cj4gYXJjaC9hcm0vZG9tYWluX2J1aWxkLmM6MTQ0NToxOiBlcnJvcjogbm8gcmV0dXJuIHN0YXRl bWVudCBpbiBmdW5jdGlvbiByZXR1cm5pbmcgbm9uLXZvaWQgWy1XZXJyb3I9cmV0dXJuLXR5cGVd DQo+IH0NCj4gXg0KPiBjYzE6IGFsbCB3YXJuaW5ncyBiZWluZyB0cmVhdGVkIGFzIGVycm9ycw0K PiBtYWtlWzJdOiAqKiogW2FyY2gvYXJtL2RvbWFpbl9idWlsZC5vXSBFcnJvciAxDQo+IG1ha2Vb MV06ICoqKiBbYXJjaC9hcm1dIEVycm9yIDINCj4gbWFrZTogKioqIFt4ZW5dIEVycm9yIDINCj4g DQo+IFRoaXMgaXMgYmVjYXVzZS4uLg0KPiANCj4+Pj4gKyAgICAgICAgICogLSB4ZW4sb2Zmc2V0 OiAoYm9ycm93ZXIgVk1zIG9ubHkpDQo+Pj4+ICsgICAgICAgICAqICAgNjQgYml0IGludGVnZXIg b2Zmc2V0IHdpdGhpbiB0aGUgb3duZXIgdmlydHVhbCBtYWNoaW5lJ3Mgc2hhcmVkDQo+Pj4+ICsg ICAgICAgICAqICAgbWVtb3J5IHJlZ2lvbiB1c2VkIGZvciB0aGUgbWFwcGluZyBpbiB0aGUgYm9y cm93ZXIgVk0NCj4+Pj4gKyAgICAgICAgICovDQo+Pj4+ICsgICAgICAgIHJlcyA9IGZkdF9wcm9w ZXJ0eV91NjQoZmR0LCAieGVuLG9mZnNldCIsIDApOw0KPj4+PiArICAgICAgICBpZiAoIHJlcyAp DQo+Pj4+ICsgICAgICAgICAgICByZXR1cm4gcmVzOw0KPj4+PiArDQo+Pj4+ICsgICAgICAgIHJl cyA9IGZkdF9lbmRfbm9kZShmZHQpOw0KPj4+PiArICAgICAgICBpZiAoIHJlcyApDQo+Pj4+ICsg ICAgICAgICAgICByZXR1cm4gcmVzOw0KPj4+PiArICAgIH0NCj4+Pj4gKw0KPj4+PiArICAgIHJl dHVybiByZXM7DQo+Pj4+ICt9DQo+Pj4+ICsjZWxzZQ0KPj4+PiArc3RhdGljIGludCBfX2luaXQg bWFrZV9zaG1fbWVtb3J5X25vZGUoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKmZkdCwNCj4+Pj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBhZGRyY2VsbHMsIGludCBzaXpl Y2VsbHMsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBzdHJ1Y3QgbWVtaW5mbyAqbWVtKQ0KPj4+PiArew0KPj4+PiArICAgIEFTU0VSVF9VTlJFQUNI QUJMRSgpOw0KPiANCj4gLi4uIHRoZXJlIGlzIGEgbWlzc2luZyAncmV0dXJuIC1FTk9UU1VQUCcg aGVyZS4gV2hpbGUgdGhpcyBpcyBzaW1wbGUgZW5vdWdoIHRvIGZpeCwgdGhpcyBpbmRpY2F0ZXMg dG8gbWUgdGhhdCB0aGlzIHZlcnNpb24gd2FzIG5vdCB0ZXN0ZWQgd2l0aCAhQ09ORklHX1NUQVRJ Q19TSE0uDQo+IA0KPiBBcyB0aGlzIGlzIHRoZSBkZWZhdWx0IG9wdGlvbiwgSSB3aWxsIG5vdCBj b21taXQgdW50aWwgSSBnZXQgY29uZmlybWF0aW9uIHRoYXQgc29tZSBzbW9rZSB3YXMgZG9uZS4N Cg0KVGhpcyBpcyBhIGNhc2Ugb3VyIGludGVybmFsIENJIHNob3VsZCBoYXZlIGdvbmUgdGhyb3Vn aC4NCkxldCBtZSBjaGVjayBhbmQgY29tZSBiYWNrIHRvIHlvdS4NCg0KUmVnYXJkcw0KQmVydHJh bmQNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:45:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404077.646399 (Exim 4.92) (envelope-from ) id 1oWaZZ-0000iy-5a; Fri, 09 Sep 2022 09:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404077.646399; Fri, 09 Sep 2022 09:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaZZ-0000ir-2x; Fri, 09 Sep 2022 09:45:17 +0000 Received: by outflank-mailman (input) for mailman id 404077; Fri, 09 Sep 2022 09:45:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaZX-0000il-Sx for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:45:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaZX-0006Ia-72; Fri, 09 Sep 2022 09:45:15 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWaZX-000121-0A; Fri, 09 Sep 2022 09:45:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0KLcYl2dN9slHzm/v2B+bq/46KRd9q3KpUbEhOvb8yI=; b=yyfGY8Z3DWRQf5CHRsxN2mv+hB bLXfEHMvwmHv7chCjWi84wfAWdP+KFiZ4DzlRcD6OqnYxS6byVBc/IhDmIbBtgoj/6j/vwvauemO6 aWpNyHaxt97waxJJ4y6RjX9zPT2pxqCALqHS9ThIOduCtjflQJeSTWaumTTqjszio+AY=; Message-ID: <40b6f53f-332b-1983-a516-4d29203f0ca9@xen.org> Date: Fri, 9 Sep 2022 10:45:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220909080944.28559-1-jgross@suse.com> <689f7d26-b691-56de-7adb-dfb6480e7469@xen.org> <2a32d8ed-14bc-192b-a2ce-6457490b182e@suse.com> From: Julien Grall In-Reply-To: <2a32d8ed-14bc-192b-a2ce-6457490b182e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jan, On 09/09/2022 10:08, Juergen Gross wrote: > On 09.09.22 10:56, Julien Grall wrote: >> Hi Juergen, >> >> On 09/09/2022 09:09, Juergen Gross wrote: >>> Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" >>> warning") was wrong, as vaddr can legitimately be NULL in case >>> XENMEM_resource_grant_table_id_status was specified for a grant table >>> v1. This would result in crashes in debug builds due to >>> ASSERT_UNREACHABLE() triggering. >>> >>> Basically revert said commit, but keep returning -ENODATA in that case. >> >> This commit was introduced to silence a compiler warning (treated as >> error in Xen build system). As you revert it, did you check the said >> compiler (IIRC GCC 4.3) was still happy? > > I didn't remove the vaddr initializer. Ok so it is not a full revert as you implied above. I think it would be good to write "partially". > >> >>> Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" >>> warning") >>> Signed-off-by: Juergen Gross >>> --- >>> Might be considered for 4.17 and for backporting >>> --- >>>   xen/common/grant_table.c | 14 +++----------- >>>   1 file changed, 3 insertions(+), 11 deletions(-) >>> >>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c >>> index ad773a6996..68e7f1df38 100644 >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -4125,7 +4125,10 @@ int gnttab_acquire_resource( >>>       case XENMEM_resource_grant_table_id_status: >>>           if ( gt->gt_version != 2 ) >>> +        { >>> +            rc = -ENODATA; >>>               break; >>> +        } >>>           /* Check that void ** is a suitable representation for >>> gt->status. */ >>>           BUILD_BUG_ON(!__builtin_types_compatible_p( >>> @@ -4135,17 +4138,6 @@ int gnttab_acquire_resource( >>>           break; >>>       } >>> -    /* >>> -     * Some older toolchains can't spot that vaddrs won't remain >>> uninitialized >>> -     * on non-error paths, and hence it needs setting to NULL at the >>> top of the >>> -     * function.  Leave some runtime safety. >>> -     */ >>> -    if ( !vaddrs ) >>> -    { >>> -        ASSERT_UNREACHABLE(); >>> -        rc = -ENODATA; >>> -    } >>> - >>>       /* Any errors?  Bad id, or from growing the table? */ >>>       if ( rc ) >>>           goto out; >> >> Looking at the code just below the loop is: >> >> for ( i = 0; i < nr_frames; ++i ) >>     mfn_list[i] = virt_to_mfn(vaddrs[frame + 1]); >> >> Given that 'nr_frames' is provided by the caller it is a bit unclear >> how we guarantee that 'vaddrs' will not be NULL when nr_frames > 0. >> >> Can you explain how you came to the conclusion that this is not possible? > > We can reach this point only in case rc is 0. > > rc can be 0 only in case gnttab_get_shared_frame_mfn() or > gnttab_get_status_frame_mfn() returned 0, which will be the case only, if > the value vaddrs was set to before calling those functions was valid. This is somewhat fragile. As we had to silence the compiler, the check was added to avoid any addition of code that may not properly set 'vaddrs' (The compiler can't help us anymore). So I think I would prefer what Jan suggested. We should check 'rc' *and* then 'vaddrs'. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:50:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:50:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404084.646410 (Exim 4.92) (envelope-from ) id 1oWaea-0002Td-Q2; Fri, 09 Sep 2022 09:50:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404084.646410; Fri, 09 Sep 2022 09:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaea-0002TW-Mg; Fri, 09 Sep 2022 09:50:28 +0000 Received: by outflank-mailman (input) for mailman id 404084; Fri, 09 Sep 2022 09:50:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWaea-0002TQ-05 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:50:28 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca8ce286-3024-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:50:11 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1662717021047525.9884923263767; Fri, 9 Sep 2022 02:50:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca8ce286-3024-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; t=1662717023; cv=none; d=zohomail.com; s=zohoarc; b=T2pjoDop4PScgy0bhPYHoRNazQyBfgBYg10Rp1CLOyyQ2hJkVtscy6Il7y/p8AxZUhLbJogiF2pzQjD7GDwRJmQZimxHnjUGeI6u9d0StTcYNHizzrQfqciT+f8pqq29kp7Mow5dQ5wOuVqXxFjX8GIx0ZkBUbgSqOne6gAkvRw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662717023; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Buqqd0mdEOPtGi9ODN4NezM77ChBZhiRDygmgFSnS3M=; b=K1FZMUjK2zPV50956dCMlVb3X0c9JY76SH5ocqRiK13nS13CQq9unNm5imOIuecIbdy52oywjSqZ+rSEp3axiSDlZr+UDMYxsm8oHDpVfwT6qcJYuriWazASlx7JJ7LSYTyGEaN7Mlh6pUtc1kIAuXaCaiy55dXA6x+ILHt/xAQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662717022; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=Buqqd0mdEOPtGi9ODN4NezM77ChBZhiRDygmgFSnS3M=; b=S7cevCpTAEdoYNTgJliMh7BqwHPa0hA9aXSClVv08Ex9aHiQInar+X8t5y0+Rxv6 FnhDJpdfax3AksAWnyGmccNL6Z7uM0AdTh+3MdAah8bXS8zQJv6b28neYsOXPpBw2bf I5g0eH8O1HcBs+bxunY4tRSzD+pL0OPh6hM6IvmE= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , jandryuk@gmail.com Subject: [PATCH] xsm/flask: adjust print messages to use %pd Date: Fri, 9 Sep 2022 05:50:12 -0400 Message-Id: <20220909095012.4251-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Print messages from flask use an inconsistent format when printing the domain id. The %pd conversion specifier provides a consistent way to format for the domain id and aligns with the rest of the hypervisor code. Signed-off-by: Daniel P. Smith --- xen/xsm/flask/avc.c | 8 ++++---- xen/xsm/flask/hooks.c | 3 +-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c index 4a75ec97e2..4a86681c81 100644 --- a/xen/xsm/flask/avc.c +++ b/xen/xsm/flask/avc.c @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, if ( a && (a->sdom || a->tdom) ) { if ( a->sdom && a->tdom && a->sdom != a->tdom ) - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); else if ( a->sdom ) - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); + avc_printk(&buf, "source=%pd ", a->sdom); else - avc_printk(&buf, "target=%d ", a->tdom->domain_id); + avc_printk(&buf, "target=%pd ", a->tdom); } else if ( cdom ) - avc_printk(&buf, "domid=%d ", cdom->domain_id); + avc_printk(&buf, "current=%pd ", cdom); switch ( a ? a->type : 0 ) { case AVC_AUDIT_DATA_DEV: avc_printk(&buf, "device=%#lx ", a->device); diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 8bd56644ef..a79281bdb0 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -281,8 +281,7 @@ static int cf_check flask_evtchn_interdomain( rc = security_transition_sid(sid1, sid2, SECCLASS_EVENT, &newsid); if ( rc ) { - printk("security_transition_sid failed, rc=%d, Dom%d\n", - -rc, d2->domain_id); + printk("security_transition_sid failed, rc=%d, %pd\n", -rc, d2); return rc; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:56:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404092.646421 (Exim 4.92) (envelope-from ) id 1oWakY-00038e-Ef; Fri, 09 Sep 2022 09:56:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404092.646421; Fri, 09 Sep 2022 09:56:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWakY-00038X-Bl; Fri, 09 Sep 2022 09:56:38 +0000 Received: by outflank-mailman (input) for mailman id 404092; Fri, 09 Sep 2022 09:56:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWakW-00038B-6t for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:56:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a68780b3-3025-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:56:18 +0200 (CEST) Received: from FR0P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::14) by AM8PR08MB6561.eurprd08.prod.outlook.com (2603:10a6:20b:368::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 09:56:29 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::b4) by FR0P281CA0045.outlook.office365.com (2603:10a6:d10:48::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.6 via Frontend Transport; Fri, 9 Sep 2022 09:56:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 09:56:29 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 09 Sep 2022 09:56:28 +0000 Received: from 55a50f561b9e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 383F1661-B06E-4A90-B7A0-85C11EB37C9E.1; Fri, 09 Sep 2022 09:56:23 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 55a50f561b9e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 09:56:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6184.eurprd08.prod.outlook.com (2603:10a6:20b:29c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.15; Fri, 9 Sep 2022 09:56:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 9 Sep 2022 09:56:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a68780b3-3025-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K149ofrXjXDqMEHawZDsbixjhZNd4X8ZvQHQ5Wf8cCwKwTWOSnDcZhOzx8mCtGpj4AA97ik9uPy6ompXxi/lN2UOSAkgK2bqEzEnr/F2K4cvybwCoM8KExtDAgbXTzUnwZSX2C0klXLSpteQgBmPNdzzRzmNWLekQwLV3SzWIczPxVFwIO/jG/itE3n14vFODR6Rv088WNJ2mgqm4FRpQsRvgbuLWjuXZ74nrWQNwGoSpi36SAn9wyNv6uQ34PLBdm5m/kKbymgt5E9xRnG7yMMyO+707fwdXkk34Xf/Mz5w90WzKUrhAH5hL3Yuf+SsNtwURe/a55s657sViNIMBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XMVI0uwjXlNqgN//YaBP0fYehbV3VaJJVKqOggi+tNE=; b=d1NXrlhsNnn3IauyKZp42sb2t8J4sMvZGl+xTa9Zb/I/LnZ02z+UpDNclFFO0IJVT1KtRkB95O3t8GhSotqDNromWfigKv67at1Y3bcqYr1EXJ+VfVoLnYnK6/nv63s2EHqg4vZVDgPlFFpKMBSbeaTLQjbxstTgiookyryLzgZd8F6ccYbJ5bQc2bKckbr5mUOXsibeq8hJ2nALEPwnX0LCma8wzCWhyIJhB/gmXkcemJN8KxJn4aISt44mIeVxEeJfqlu65+P+EI+MmRHWcat5IqJfa2Wd/pmMrHY0Lggj24++K5Rjz/y2VLXJ4QmChPL4Y//FC9OujC3NyMFqbQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XMVI0uwjXlNqgN//YaBP0fYehbV3VaJJVKqOggi+tNE=; b=M3U6g1lMCbdvxUnWG25DsHaigFWDtMFl6+DcFVH2535O5YtBgvur5AfezwDzOrYnily/5YdstN0bBQVESXPDm7jCEpw/DyyrlvJgqf3WKhLZnYkttw2ZmHbL25NsNt0GlZHCQaqZSBZWe8koF9HLY864gUtHTnk2JXsKExesC14= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y5X5gXDb6OidzYtLnfEC5x1rDjUdghG/MDemU0imvGFSeauy0nMiYycP7AZiDHGjvC1Z5JWpYDlGNl70R5UyA2mX4uw5pY9Fw4NhrYJawMbSM1vqkrXwu0xm6WGZN9c8Y/NSZH7IA3aCXsv338fkiKKulnwJWt6BrZWGVPmzv4KdWV52PuPG9lb1BY8AR7xYOY0mGCeuunVHjR2iLpwgdT0YRCWU5nF2YRrUHOQsbqmMHPBt2V0sNK9LiuRiXEeOYrhNvBSD4IXtN9s8wDk5KRrwKZP0QVWx1v0FzR3QHtaDpznIXV3luA390tLMqSZck1tzPp8U7myO/2Wg+aob0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XMVI0uwjXlNqgN//YaBP0fYehbV3VaJJVKqOggi+tNE=; b=WW7XbDSGwRdlOX4AUKKB1MZyrG+4wSbWzVVfi+4Ui+7ZrDtq6jK8UBpwTBF/GtQAfuho8lz2C3xvC9YGxjVTghjPZK6XKokyUmVeQ1XS8WQqaemhxLc2UlxlSsYUMj6++4Uf2h3iXX17DM9yrVFZedhwJQuDLyjlFaPmaYfPC9LO5IVXBgyVvgXM1w7EghuD5Mp6eU22iVW4wOh2mkG2XJmEtkOQr5/VvZIJVw45DXtlk6xX+Yy1ui7pgmH5T5+LwEFYitGfTk9NiipLeGZ4COL1HdSgYWA3Bs6kw9i00zw2o0s8UhlTGA3ccJmt41ElucTnpjenbD4Y8sMqfUr2RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XMVI0uwjXlNqgN//YaBP0fYehbV3VaJJVKqOggi+tNE=; b=M3U6g1lMCbdvxUnWG25DsHaigFWDtMFl6+DcFVH2535O5YtBgvur5AfezwDzOrYnily/5YdstN0bBQVESXPDm7jCEpw/DyyrlvJgqf3WKhLZnYkttw2ZmHbL25NsNt0GlZHCQaqZSBZWe8koF9HLY864gUtHTnk2JXsKExesC14= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "jandryuk@gmail.com" Subject: RE: [PATCH] xsm/flask: adjust print messages to use %pd Thread-Topic: [PATCH] xsm/flask: adjust print messages to use %pd Thread-Index: AQHYxDGm1l2kl9jZnEi0PeM8zmcB0K3W20Yg Date: Fri, 9 Sep 2022 09:56:21 +0000 Message-ID: References: <20220909095012.4251-1-dpsmith@apertussolutions.com> In-Reply-To: <20220909095012.4251-1-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 424ECAEE4083B542A4F7005EBBF175C0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0573a62c-4c71-4296-e500-08da92499133 x-ms-traffictypediagnostic: AS8PR08MB6184:EE_|VE1EUR03FT024:EE_|AM8PR08MB6561:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UAG7RPJ5xGsLCOU2cbRrSPIL7lFggeP7I5+93/kSewG0N1Kq26CxX1XNV/ThjHttYe7TxlyXVEoqZ7J/yiRHeo56YbrLYisouk90aE1zchBrb+0CU1ziBkjtiRsSYR1l9ESnLU3KhlJ4VM2Sy9WFqXt5n+8ou82p8H0F/gaPunbCGRbu6X9HBoksowJM9Js4i4h73XS78JlLvCtceVro16hgLe50FWZF9MSOnxtVhXex4LR0KjtDJFiIKJw2baUXOxnK1CJzvPA8EAHRkGAhhEvlN5hDLKdG4QLeGAKoRKKnJl/EYgDSMBvj5w0hTY4fLEz0DOM6MSgrzjnu7vf2qZofRYoxxYZBhnvlUuVGdQX27rJdT6S4XZNsAKue1LjCwcK9S/uIZgvOFZVOrJtBwBE34gZBwdNsnIsLYtPISgy/pYTmar3S3d78h0PwGYbUV0/rGw6Mor3NFY0B4nCQCQxb2VqI6BeH+y6I5qcCOdUTWl8spqnLrPwtG3C82+0WbnE1XlpBJhwL3r+c6k3jQrcLHYNEaPsWXoxPY+4COELNojXpBJI623Xao4c7540ZGUZk9BUSeeAIZ2hnZCXgJtgRXyEnjUCnobV3ZkRUA9g8VGcVjIvtepZdY4u3DTziRw+GA3VZ3CP4cK6a8jmHUMRX9H6FlGZsOpwmY6P/m4K+Zfc28zDltvc0PiX2ywt+XnK6mTY+hY8qX6g/yHSHqErujeNQD9+GUpEwYpFnIR8Kgivls2GDmH7qbgd6t/Va4ZA9EKRQwkgYK5tOKe5m6Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(396003)(376002)(136003)(38100700002)(33656002)(5660300002)(15650500001)(122000001)(83380400001)(186003)(110136005)(316002)(8936002)(52536014)(2906002)(8676002)(55016003)(76116006)(66946007)(4326008)(66446008)(64756008)(66556008)(66476007)(86362001)(7696005)(38070700005)(6506007)(26005)(9686003)(41300700001)(478600001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6184 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 743bd34d-b167-474b-e68a-08da92498cc7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 11C9TEuP6kdW9NXFTlusvmBls/sToLjZbQ3Gm8eARtg99Ptzbe8gqrewNKx1ylFQaho5nB0eU8n7DPV2zuXuTQO3jKFgk4OdENaPF7SV9RJpQJryfy1RnsOV7k8MVlMMhRsGW6lQTWSUq7klU5EWmzKoQa2RQBy5M809tnA2tidmzFCh2P7JAYDN9ey0rCOzdI05fB4lzOiI/3dlJ6YNBjEvBlAGoxmYQ/V6btdJoIFjOYRXRkTl/lhD4Ew1t9/X7D+f1uVOFw2rjZuB1cy1VH4iZ4oxSiNTycw+hMXJz/UU62bH879tvZ88min2QDquZaKX4+8C1zmLeADVHDwry4GJhQURAqMMV4xmNKea58d3SMnTBySFsoRfvLDCNspjODLdKnaVzHYqmDslxJXy5Ow5qoQlOQOmvwy50LSuArIpr6Sfs+zq7rfinUdI9lr3AhaX5Q7yysGM+1aY3/pZJwAayvIR4+ZGqm4iafOnVFfTzX8c6rQeVcfwXH2qLy1SANK1WEbpu7EF7xxBD+m8KEO78wR3p9JPEXmrYBSa2fIF+vFvR8mzWhMEwTeAPt8KzEZIa+0KYvVBzdRr013fihM0E54rnU4FCOdnXyW8xcu0O5P4DSRyKEikwXcBPinJAhedYfhUgUGSvHEOOfpWziXoNN8axczWjMZGtSnWZ100Mrm7IPL4Eu354/MZwZ0gWcQL7nwuqq+/77fvBsPrva+495N4vrGuD2DLmZN3FFfnWoBO0rzSra6fDnwAK4vpX26viRFuPaKNhGX4KM99hw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(40470700004)(46966006)(36840700001)(82310400005)(83380400001)(86362001)(186003)(316002)(110136005)(336012)(36860700001)(47076005)(70586007)(52536014)(107886003)(5660300002)(8936002)(70206006)(356005)(478600001)(8676002)(41300700001)(4326008)(9686003)(55016003)(40460700003)(82740400003)(40480700001)(81166007)(2906002)(26005)(15650500001)(33656002)(7696005)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:56:29.1618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0573a62c-4c71-4296-e500-08da92499133 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6561 Hi Daniel, > -----Original Message----- > Subject: [PATCH] xsm/flask: adjust print messages to use %pd >=20 > Print messages from flask use an inconsistent format when printing the > domain > id. The %pd conversion specifier provides a consistent way to format for = the > domain id and aligns with the rest of the hypervisor code. >=20 > Signed-off-by: Daniel P. Smith > --- > xen/xsm/flask/avc.c | 8 ++++---- > xen/xsm/flask/hooks.c | 3 +-- > 2 files changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c > index 4a75ec97e2..4a86681c81 100644 > --- a/xen/xsm/flask/avc.c > +++ b/xen/xsm/flask/avc.c > @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 > requested, > if ( a && (a->sdom || a->tdom) ) > { > if ( a->sdom && a->tdom && a->sdom !=3D a->tdom ) > - avc_printk(&buf, "domid=3D%d target=3D%d ", a->sdom->domain_= id, a- > >tdom->domain_id); > + avc_printk(&buf, "source=3D%pd target=3D%dp ", a->sdom, a->t= dom); I guess this should be target=3D%pd? With this fixed: Reviewed-by: Henry Wang This should also be fine to merge in 4.17, but following the discussion wit= h Julien and Jan I think providing a Release ack would lead to confusion... Kind regards, Henry > else if ( a->sdom ) > - avc_printk(&buf, "domid=3D%d ", a->sdom->domain_id); > + avc_printk(&buf, "source=3D%pd ", a->sdom); > else > - avc_printk(&buf, "target=3D%d ", a->tdom->domain_id); > + avc_printk(&buf, "target=3D%pd ", a->tdom); > } > else if ( cdom ) > - avc_printk(&buf, "domid=3D%d ", cdom->domain_id); > + avc_printk(&buf, "current=3D%pd ", cdom); > switch ( a ? a->type : 0 ) { > case AVC_AUDIT_DATA_DEV: > avc_printk(&buf, "device=3D%#lx ", a->device); > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 8bd56644ef..a79281bdb0 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -281,8 +281,7 @@ static int cf_check flask_evtchn_interdomain( > rc =3D security_transition_sid(sid1, sid2, SECCLASS_EVENT, &newsid); > if ( rc ) > { > - printk("security_transition_sid failed, rc=3D%d, Dom%d\n", > - -rc, d2->domain_id); > + printk("security_transition_sid failed, rc=3D%d, %pd\n", -rc, d2= ); > return rc; > } >=20 > -- > 2.20.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 09:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 09:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404098.646432 (Exim 4.92) (envelope-from ) id 1oWalH-0003fU-NT; Fri, 09 Sep 2022 09:57:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404098.646432; Fri, 09 Sep 2022 09:57:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWalH-0003fN-Kn; Fri, 09 Sep 2022 09:57:23 +0000 Received: by outflank-mailman (input) for mailman id 404098; Fri, 09 Sep 2022 09:57:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWalG-00038B-Bk for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 09:57:22 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50076.outbound.protection.outlook.com [40.107.5.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c304fce2-3025-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 11:57:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18; Fri, 9 Sep 2022 09:57:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 09:57:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c304fce2-3025-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iq8kBr4gzShhlrGsMl8c8Lerp1DxGg+a+Cn/9trEnpMQ3ifjpDamvGx0KvQW6J6RYR14C0jK16uk3G+PF2Ra+HSz8KjY76uYaK/ZOzk4FsRFrDI2UCCJZld8fXZHQsr5weM8WKUcqQznzC1L5Kr7PHTnot5cqZo++oyDaiDVHBWiwbGyg1vk2j3Ks3/zCgrhBZkdWEFkcIQplodtxrCxjUemC9KH2+MPIA5ZrgGWbFWiqgHQ1aWcARIwbwGY6dJtg1OM2V5Bum2j2H2Ptj1TW66NBXWUo7K8A/OpvSgnjgcehS86fVuGrLHVLzm9i1nQZqjQ96eBFO+s4V6WY2RF6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=So4PRzAXFLsJNR+TgexVXhf5/h019GxN0tQJ6nu9+XI=; b=OJeYrslCCmhwKYuB3cFMEjHpPbFlG3fvDvbBmiMmi7wYHL93a9tAEAvhrvb5vB1daMUEjrYiiq3sAyxJ4uyEkGQ9pkmSdLYYFZAqfVex8g4kYHftsOS8wxuLH1Rm5k/zu4KZrfHVIloc+z0LSXrWUdWcZvWunrQmwQV2WFouZY9GmvOGwZFnrHgvbOUzZuSR9KHUdaDrkdinu8cBxBnpChiLohwjPKYafap54B6IfbA4r22uHjFAdsERnifW5EH9/J96OjM2IzhGRiBK+tJHDKsIK0jlX9OUWX0JKYGfC+HHztpKdPKGX+ZTHs5emcRCsZ2MneN1AQblTn78w98wEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=So4PRzAXFLsJNR+TgexVXhf5/h019GxN0tQJ6nu9+XI=; b=i8JgdxWvvgiHzABx3m+8qTvCMk/8tm09w6X7FoAYh6FvhdFqEgp5H4LgS7cmavWH++xx9r/sbo3X3bk5Tvy4o+0WXk+lWoFachKVVSKa+UNqz+blc6k9FItGXYlQMxYKhqp6wluo6daAD+fx50DIV3y5jycMaloI88A9w6VT6C4qqNZdvz6f2d5kvYzn/koYxaEFtE3A9s720Zi6KMAw+L+7NgZ1BcGcm7k0PvR54oAkGrCosWw8ZwDQ00Tpfc7J8nArQezBVC4HEOitTBc7F4btmi3PRhy3kwWT1zLiYdSERsnnyhix0St3LunNHA/E9YJBLTI7PUdNyMl0C1tP/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 11:57:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Henry Wang Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Juergen Gross References: <20220909080944.28559-1-jgross@suse.com> <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR0401MB2607:EE_ X-MS-Office365-Filtering-Correlation-Id: 50f839e1-b97c-4331-b45b-08da9249ade7 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oOcBoayFn6Y94brtCjbdhY0X48i3ltBBsspfNUS/5Z0Bxt5gjsmgrOwCr0LuHcBlTl+I67+gVvpoN3fIDT1mYe674Oqh8LpxMQ6aWPYgW7sxRcWEJ5HX386ns7xff3s+2Zu9jDFe/niSyNwQTYiMdYjkoh7fAP3ZWZIVad2gLdt3Oxn2hoQ5cR/r312ldcIjlv9lATSoN7Zpr1FP8cn7fvY6q5o3PcnGOeF6jcLPKgS5CzxV3pjPautOhjKJ+yJJH3NoTEQcVoozk/JUP0F2vD1QZL1gAGimNUYJHYDBgVlOc9y/qqu/+Xcs1JfBbZ1NkQI3IX4cE7yrhzRPAxzFWEInwzEkmgqKuIBkhmU/VdBfg90YuvToIRo8iVndAvGi59ROjj22gSxwlZMHefUmstbHjbMO+OXgncw2dxHhmySWZYRJbmCsxrnhe3b0TltGrEfMLGn1ZbSkOi7hGAKbQvkRJbwxYdYBnE7wWtHx3BHQtf3LmkuCum6BCt0Bpb1gWgy4I70JBZl/h6bsQDb53OOBqyE17oDVLiBKsi1m3D2AP3FaKnBpk+qsSQx3fLrDUmy7hNOC9YzQwKeDLLjKXqBthWF3gD/jZu82dEqq/lMdfrWsJc8JpRJIzPB33/PTHy20C5iCFQM4FgzXvy6ytNcof/xdNoZyQO9PmyTBcKbrc3b99B4wQlOInZrCglkBTR+tnqf7ZdaBYcD3rOXDikRWr931CxGIFFW6hz/RbGqKDCMP4jdL0aYKJSLVBMcbjuOaUcsYYS20ndQW/IzTt4AH+KkS0+QL7MjLNvu+F50= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(136003)(39860400002)(346002)(376002)(8936002)(54906003)(2616005)(6916009)(6486002)(186003)(4326008)(66476007)(31686004)(5660300002)(8676002)(66556008)(6506007)(41300700001)(107886003)(2906002)(26005)(36756003)(6512007)(316002)(478600001)(66946007)(83380400001)(53546011)(38100700002)(86362001)(558084003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGUvTm5uT1cxQlM1MVhqT0QrZVd3KzZVREJsSWJuV3NUeHVLd3pPa0pqT2Jn?= =?utf-8?B?dks5REpobkl6Y2ZrVTU0K3poQ0draVM3dVRGbFFDRHFSVVk2a0JUR05vQkZK?= =?utf-8?B?dHlnUkg0NVpHVFpaWEV0MllXVDVpdGtIcDZzVTlOWVJ4YUk1cEl4STROMWRO?= =?utf-8?B?YXA0bGdQdGRDRUJteGtKUWRCVWg2Z0FGV2hFNzROMDNScEJVYTE3aVhmS3BI?= =?utf-8?B?WkVISVUzOUtEVmd2c1VvUzQ2enoxWElsQy9veGFnRWxCditSZnFTcnh4ZkN2?= =?utf-8?B?QTJkUUFTQ243QjNnengzb1F0NG5LWnZLV1A4ckdNZ3Y3VGcrelF0YUU2MEJE?= =?utf-8?B?ZUZxWmRzT0U5MlRaZ3ZOemk1YU9oSDFrQnNBSndkelEwTW42RlhndURueGJl?= =?utf-8?B?M3NxY2pUbXlrK01jQmw1ekg3QjhwLzNubllSaHczTE8rWnJWRHQ1VkxNWTJM?= =?utf-8?B?bUtlNytyS0J5ZHhFSHRxbzNLUDUxM0R2SVdTT2U1SDk5R1g4TEpFKzFrc0JW?= =?utf-8?B?cndOQzBLekVicFlSMm9tVzdWbWZFbjQ2SHMxR2E3alZvQ1E1cUJ2Nm9LV29v?= =?utf-8?B?M25VQWpUcWgvU1JzQTA2dktnSDFmVFBJL1R0UEErb3czZ2F5Z09WZlY5TU11?= =?utf-8?B?WnZoWlBHZC9VOEtDVUZHQmlqMDFBbVl5dkwydVFiM1lLTE42bjRHNnptVVB5?= =?utf-8?B?RjNDNmZEaFhXL0hJRC9UWVRNNEN3cXdxYVFiVXljbDR0MDF2VEFjSGFYR09J?= =?utf-8?B?WmR1a1hhTEZkcEpEUitjSDdHT0RSdFlJR1djeHRXQVBsR1A5bzJkMkswUVBD?= =?utf-8?B?NjBVa3cwM1ozd1JDdDlqQnZtUmt2d2UyZnNVUlkxVHpOcjErVnFERUJ0Q05a?= =?utf-8?B?dTRqRUE3emcrN29sQVd1Skp4NUtLeWdzWS9SOXFIUGFsQlFSUkV1WHZVS1F5?= =?utf-8?B?T09YWktORFBLYm1VTndQQjhseEpxaEozYnRhMTk5d0hBTm1PVmNDcWxQSU1j?= =?utf-8?B?MjJ1V2tweXdObWl5VUhBbkcrY3IveWxpVXJrc0sxRWVQNWRxZ2xXcnNWQ3RW?= =?utf-8?B?emVCL2NDSmpRYXM4cVBwREx6aUpUWmJ1MENibDhSOU5kL2srNVV0VTA5OHFQ?= =?utf-8?B?R2Y3L3VrSXovV25HcWw1UnZ3YmdCbFVQYVAxbWwzS3JzTHJoSXJ5ejV2NENG?= =?utf-8?B?L3RtcHMrN1JlR1RvTUVrZk5rMVZLNURyZGJmU3ZKNnJwMjlKQTNVbGtLV0g0?= =?utf-8?B?K3p3MlBDS3pBKys0SkFUWGFvMy81QzlRVStoYU1xTkJXanVnYTI1THFraXQ5?= =?utf-8?B?alo1MTRzL1JudDFYeUFRelZSSUp4M1lja285Q3lJUG5Nd2RvckZQd2MvQlhX?= =?utf-8?B?ZW5WczM2TEV2QjRJK2lUS0Z6MEp5T25vRWJTS0NkSjhOWmtrRXhjTERPUEF3?= =?utf-8?B?OFZIb3o5QUtEaG1SeHl0QUgwN29wQXZwSzJTZmRQYnBsSStEdElFbWZJTVFF?= =?utf-8?B?djhWd3Y5dVRJSjg1Sk1IaVRoRzNFN0JKOUhCbXYyV3E0eWw4Y2l1M1NsaERw?= =?utf-8?B?bThKa0kxRWtRUUI2aWRCbVVwRVFVc1pyWmpCZDVWNzZyZHQxdG1GRlg2SElI?= =?utf-8?B?b2h0QzQ4UjgxSUhXdDhrUkxvcWhBMExyamd3Y1VKbHk3cXFWTlNOcXI1anB0?= =?utf-8?B?Y1BNcUtxV0xRZTY5VEJCKzdNcWRJUTVuZFcvL2VCYzQrUWx2NGpacThHZ25Q?= =?utf-8?B?YjRhNm5pZ0tVUGc2V1FZMjNWc2MrT3ArcFgwTk9XdWVnQWx2RDcreXpzaTNi?= =?utf-8?B?Vk9kdEJsd1QwbXVaZ1lrbm5WUE41SlR1bzdEMFN6cWg3UzMvWjMvcUMwaVR2?= =?utf-8?B?YkJ4U2xwUHlnTVNKbjlUZmtZNEhzWC90K0hzdnQ1VlZ3azFUMS8vSHF1cWZ3?= =?utf-8?B?aXdkVngzclBMRXpVdHV3MDlCbkk2MVc0YTRxZ0xFKy81TW9Nb1BIMFZwUXhO?= =?utf-8?B?dnB6VXFkb2hJeG9Bc3JvS3dVTHlNSDk2ajRCdUpTaEwvQW9wcWJKNW9iZE9H?= =?utf-8?B?a0ovNURYeXpBWnZ3WFdtZ3hJUkNwK3ZoMDkwazZjb3BJMGJFeHRlYm9kNXda?= =?utf-8?Q?rvC83vwc584D1RTi1iekngnCa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50f839e1-b97c-4331-b45b-08da9249ade7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 09:57:17.5976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gQ6j60PBh2eZDnJ4hhPCM8c+mBvWJ0aJsKUDgEktawqmq95YdOpB881hiQuelYJOs4TusVWPlZB+kErSCz11ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607 On 09.09.2022 11:28, Henry Wang wrote: > > > Kind regards, > Henry Hmm, did you mean to actually add some text in your message? Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:00:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:00:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404109.646443 (Exim 4.92) (envelope-from ) id 1oWany-0005Yn-An; Fri, 09 Sep 2022 10:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404109.646443; Fri, 09 Sep 2022 10:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWany-0005Yg-7e; Fri, 09 Sep 2022 10:00:10 +0000 Received: by outflank-mailman (input) for mailman id 404109; Fri, 09 Sep 2022 10:00:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWanx-0005YY-7H for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:00:09 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f442cee-3026-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 12:00:08 +0200 (CEST) Received: from AM5PR0202CA0012.eurprd02.prod.outlook.com (2603:10a6:203:69::22) by GV1PR08MB7914.eurprd08.prod.outlook.com (2603:10a6:150:8e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 10:00:05 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:69:cafe::c8) by AM5PR0202CA0012.outlook.office365.com (2603:10a6:203:69::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19 via Frontend Transport; Fri, 9 Sep 2022 10:00:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 10:00:05 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Fri, 09 Sep 2022 10:00:04 +0000 Received: from cdbf9fef72a2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D5AD421A-3083-468D-9C66-E258589EEDCA.1; Fri, 09 Sep 2022 09:59:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cdbf9fef72a2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 09:59:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB9449.eurprd08.prod.outlook.com (2603:10a6:20b:5eb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 09:59:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 9 Sep 2022 09:59:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f442cee-3026-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aO8VPYdogem1hXob61gmQIXyJYLtrc1qy3T7yhALq84yMpIk1Xs5L/WaCYxZouPOvn9hidZweL0UWeSAXwWm65okeVpAjZP45u8v3ziz67gYLY33J+IXsYkADw0eppj1ZptG7nkZdQeqKAa/xnc26Li5Eyeyd3l0OVYHwUL7meUYPuus+gSJg6HzqBL/InYX6OOqsQgbU1eqecWj4DkTugEWnovTDKT3EQMm95DS7jrN3bOKCiYKrQBJHCkISSJBlb7rtPIOUpyOKZT7fOH82ib1X+4n7YF1Ot1JbJWI5zxi7MqmFVde2Q570JlQeB6aEBsVR+cfQBfgwm8F82qJyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3bw6YUkUYBAQIziCSp+7mB4Ve7T4KL+lB6q7LdPGfaY=; b=ADjpc332bwQTSTYMhebyBsJZX3UFUHjrr0RoPSmtSXjfaxUwUQ07DsbtSfRvZw8kxwSdtwvjs+oNFbiYklniV60wsNnE+9EAeHBeOGIXr0ZI5Uwi5B5A8jmmrpLx6eklcuUcFrE/uqF2GI+Mo5+famDkoZvh9rRDEmrRZZBPwZ+f9QOmi1ZY01GwUM7AxFFcTEL92ryQbwWMHlcxQ4ovbdYh+pIn7qS8f19Od58jcj+Sj67YcCfU31Rhvf577CtipfNbrecd5URFX0XUrRWb5MitOlx9EZVWdLy8od/LD/z4RP7WOTE7kGlqHoXc/wAMbUZ5zXI0FWgFSqDqJ5IRHQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3bw6YUkUYBAQIziCSp+7mB4Ve7T4KL+lB6q7LdPGfaY=; b=uZRxghMtMJCrY1kPY04Yka47sFXYrM8g0nJCglfsYZg4wK3CUEZgeYT4tM5P0FYwzruRILf8mC/uHRQ42mnm0WPU8K7nzy8dSH6+fgYnceOrZPLbgCyk/QM/QNOSk9a/1BNMdHaaMRc2Sk7sMIAZIlj9fX7q2cFR35B3VSvSu70= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O7cCrw0UV3gt0rc0jzUp3GnVwcuHR+quMUMSa+DJRPfZJMl9fWVJojdtj9Hse5uQOzkm+ezf9uepj9oq3/J+MsuX7tya8hTGGuQzYshprUnzedY29zey2+0+p4FN2Nw+3Ce972n+Cr7ZgayvkYQgZjB8iiTTr6UVBXbLvpr2wEvzwq3KMQifQaZdfbXLBUkzlGllzPjqszoHVRIllUC+ptsGmD/4S2K5yTygQfshdvupcCwpIhNC6OT71JJDo+d8bbfiYnf7EQLsEQpuat2XLKWZBgjZX5WZej83JUXjgwIKj9MSZ0Ln9XWFu+XS5lCq8mXRaETITwQfL4mQvDZONw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3bw6YUkUYBAQIziCSp+7mB4Ve7T4KL+lB6q7LdPGfaY=; b=PKAV7ywXDk3c9Aw+ClK0b6a9T658f/Bsb8Vl4dLZql0j9AoOAmrEP3Nq4EWTPlGXvQCqfpTx+0pRpFNnGfbPs/LaABGTCgHW6u1+6DjM/1kS5M3Y8n3rdUYMYp2dhUWZVvto1/8kjS4UysaBCODJyatJbG6kjG9xHDfP0v2P9NViJTZol0M6nQ//wgRzPTDqR4jjoFaSqixgGyrZgXJiM2jOaeHnhLhDnh4TdoYmvZ4V+o+Z9yQWm5M90O9hs4qiEZUsZrkbwrJlRM0B0kX8/AwE6SyFyUrSeq8clZakWbP+76DZETQgkM9esbgimk4ncgZ9SflYObGiVeOjknXdrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3bw6YUkUYBAQIziCSp+7mB4Ve7T4KL+lB6q7LdPGfaY=; b=uZRxghMtMJCrY1kPY04Yka47sFXYrM8g0nJCglfsYZg4wK3CUEZgeYT4tM5P0FYwzruRILf8mC/uHRQ42mnm0WPU8K7nzy8dSH6+fgYnceOrZPLbgCyk/QM/QNOSk9a/1BNMdHaaMRc2Sk7sMIAZIlj9fX7q2cFR35B3VSvSu70= From: Henry Wang To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Juergen Gross Subject: RE: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Topic: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Thread-Index: AQHYxCOLeMow4nnAdEmRQz42iuSBI63W0QoAgAADAYCAAABeMIAACGOAgAAAOWA= Date: Fri, 9 Sep 2022 09:59:56 +0000 Message-ID: References: <20220909080944.28559-1-jgross@suse.com> <52ff1228-3092-c455-479d-315a16cfaaa6@suse.com> <77d2c3fa-7cee-6f86-215a-a95ce242a990@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C463E96D54EC5848AEE062A4617425AB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5298ad59-8c75-4379-028f-08da924a11ed x-ms-traffictypediagnostic: AS2PR08MB9449:EE_|AM7EUR03FT015:EE_|GV1PR08MB7914:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qKW3o7IpVdhRC+a2NEqBcT0iz21qzzB1SFWNblLnIYvJHQvY4o5wEKvXmvoJv/7AQBZ7jTDXNyPxFTBC+HEqu7T7cyekBiTHf5/NlwL3BxBDToABhNDP0trKrNMJXk8F0tPwB1Df56C+CCjGberIqBNBA1Gob1DljFPvhmT7LBoG+DLIK00iKDi3Pht8++iSK9FRghfA6KY8PnScIcxGeIQzJ6JdigyHMr1WaX31m25dRnYDyvOkoAgnfZNOxr5ITmyhvYegUbGRkXMK/inkJZHZJ4i8DKE37PGTEZDLhwRzmbBarEL6MPJOTFqUMKnIubMw+Vytv8YNWyL9V07giTsgBhbtma8XITMO1sbN4jmVvdiRhJygVmBSnLVNJeFbA58/CKVic/TEUwuJCVHbShnKS99CY2FMYMa1M++P99A/nGi+VZgkU9Rzw0k0ydsTIdc5XBeWqzjFTHh8XkbAUHcrERNADeWepGKSZIUSUfSm/dTHIwgNec/yaNcmcMGkxR4ULuvYz5f6HS6uyNQsXGrt6jD3HrGRNWp72S1rxB7OKmPpMX3wNR5p7C8bZguQGgDRRNljmQ9rzF1iR92tK0y0y+k+v3ZOQ1JgLt/Xqf6VAS2tgsIT6dHKoMsFZxCQ15jzExkHbPePrV35TGSCfh8nDU4TQ40QmuHS7O2JmsngKkoUOuJioy0U3zE/xlm/uYEE+2buByMLefe63HJXxkwpusJpN0hehx30nskg2GsLPUj2Vwf1SsQVvd122p8riVpWwCzSGQVPd/MOXNJKkQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(38100700002)(76116006)(316002)(4326008)(33656002)(64756008)(8676002)(45080400002)(66946007)(66556008)(66446008)(122000001)(66476007)(86362001)(38070700005)(53546011)(83380400001)(478600001)(7696005)(71200400001)(41300700001)(6506007)(26005)(186003)(54906003)(6916009)(55016003)(8936002)(2906002)(9686003)(4744005)(5660300002)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9449 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 06daff31-74f1-45eb-c7a8-08da924a0ce3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jj6bPYamXhWrHqRSqdu3xpDE/sxL4dY0VPgU5J5FpoFw7lHF6/0B0m1dJud580gn3CoLC98wJMemlBd2a+s81f9RIWKwJQTMbRIKe/BXPKgOOJ+/zGdIYwhh+fdfRR4J/vVuM79KR0G6ZiucGjUD1QdqlPfMY687K5AlZZBw0Xvvsmvctr577vVJZ7LgF7WGACFkoCGD6J432fYeN20Of43SrgscYORExn65aGcix6zlWtVnmzcbw0iu0aVpSB1HmJPrjuCnVjQndLHIAW944R/QfuAlu49cFsQtslw4LSyvoaW8jo4xevzPuXqVrI44B3BfsXDlPuiiY2ZqZZhHGeMQ9epPK+W8e1YJRBcGHszfdkPHEmjFHp6DRT2e7IHW1v4aDy6I4f7HAiDdDYrz8rnYLbrCBiRNmJekAJIlWkG5k1VQGiW0jiziK8656YKEa2N1tSCAiKgup54DcMBPmq/shncOFzcrTkHc9l1xaRx3/N66XbNRuR5TBUaHCK5bPx4KBv/dRyTnam5oYxBk1ga/FujWMGUoqM0MYyQG8t2K1EofI/6jDptbuLukzyWllDsoU5wARNq2SF94+bR3Xf8N+dzN2mKeSuly5rfFfn959VvutmC1agRcgD20l2hm943w4AI5TZPzAwCQdOxaNUnYURSyOOTfWjKQSqZfcy0HCJkNH+dFBBABHWrhFM6NPgCItVHnT3R7D6rmOnuwjun38AvYPnfX0W/5vbn4WR9iw5a//nVyikak3ACEGusm68ammZvBAnm1HuOAfsZ8JQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(40470700004)(46966006)(36840700001)(478600001)(83380400001)(186003)(9686003)(53546011)(55016003)(26005)(336012)(47076005)(6506007)(41300700001)(86362001)(36860700001)(82310400005)(7696005)(107886003)(40480700001)(52536014)(356005)(8676002)(33656002)(4326008)(8936002)(40460700003)(81166007)(6862004)(2906002)(70206006)(82740400003)(5660300002)(45080400002)(70586007)(4744005)(316002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 10:00:05.1702 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5298ad59-8c75-4379-028f-08da924a11ed X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7914 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IE9uIDA5LjA5LjIwMjIg MTE6MjgsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4NCj4gPg0KPiA+IEtpbmQgcmVnYXJkcywNCj4g PiBIZW5yeQ0KPiANCj4gSG1tLCBkaWQgeW91IG1lYW4gdG8gYWN0dWFsbHkgYWRkIHNvbWUgdGV4 dCBpbiB5b3VyIG1lc3NhZ2U/DQoNCkkgYW0gcmVhbGx5IHNvcnJ5LCBteSBvdXRsb29rIGp1c3Qg Z290IGZyb3plbiBhbmQgSSBtdXN0IG1pcy1zZW5kIGFuDQplbXB0eSBlbWFpbCBzb21laG93LiBO byBub3RoaW5nIGZyb20gbXkgc2lkZS4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4g SmFuDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:05:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:05:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404116.646454 (Exim 4.92) (envelope-from ) id 1oWasR-0006Eh-Te; Fri, 09 Sep 2022 10:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404116.646454; Fri, 09 Sep 2022 10:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWasR-0006Ea-Qk; Fri, 09 Sep 2022 10:04:47 +0000 Received: by outflank-mailman (input) for mailman id 404116; Fri, 09 Sep 2022 10:04:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWasQ-0006EU-Pd for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:04:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80083.outbound.protection.outlook.com [40.107.8.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbe4f2ca-3026-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 12:04:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5570.eurprd04.prod.outlook.com (2603:10a6:208:116::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Fri, 9 Sep 2022 10:04:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 10:04:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbe4f2ca-3026-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAl7DgmYUUx6AeR7TifPQsb5s//6d39y6lcKuxCRYHO2JRfROZNGVuETYWTibOC6BPVE9kaawgPtLtyIepOvvXIjNUiXwH0uqDs+EXdUVan76k3t6vzqw2LC3W1MD7VWHACbVv9nWxZk4W4EoxrjgOmUIsqjh2xtMidOI3tAQ2b09qm/TzqyT2D1jdW69+YUUSVzYoI2VAj/GTAYOcqaCxznFIzTbVdDW8oe7PwBDR8luV/oTRYfnuRl6Jfo622O3n3mcKzkmO9i0s2EQr7KDsdCYhUSUMjlzMXfaDFlRyBaIIUFJrtkq+oYyG3ElthrT/KqAY9HIyappzuTiioXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xs4vdQmDQTe9kAwvVnupcLLjjgW3PAzWEIfeQrL0Ga8=; b=TsgKSYOGMwTBsAXHdSRZiUiCKI3ZKoxECSSZiN0Zz/ru1jCFVAyf1n/nx5cLP7huiLmX8Hto53fOhTYxnJqy2EhDEAUeBct/pI2IeTEUrwe+373aD84PReUXJRdkKZYIFeAOcth/uonNC+u5387o09gSFMD9918OHLq4ARgIFRJCfUcsSv9LVLqr4r96k5StzBZIHL2gzJ55eSPgVpaWxDfnSzCWbwhw5EYW4hOr5Z8ZcfyTMTYWgQGuEvKE7EkYARfnzc8eofoIoW+uvXvvD6QZF0Df/6F1Lv+Wv3rul5uM+cf2sLxSwFXM2RhQoMLhq0u58N5ofuOqm+mtn85x6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xs4vdQmDQTe9kAwvVnupcLLjjgW3PAzWEIfeQrL0Ga8=; b=jIirmfZtL1CKVlRqv5fDzMVfaBlkQtIpAeupK8R7y/kpWkXp5TUAzpLTCJ9spfy15mz7d677Wob7IdNrW2u6Wt4YA6z4KGDuc/J8YWSKyXRnBLsz/n/I2GKlu5TjPh/WaRmbYVo5P9jfSqy6R4qu1Y5dMNTlY3toj3wILo5k682zWmLil48c13yzBOf6E2ZfDDq8DEIpASa7j/g2Jx1vgO9scolHSwodHS07mP9vWGV5pNylpEqFKLMJYbGMYmUwtZajIvKJcc461HNzp8xChfhGPSHWHsRY/HFKUvRH71jAdWAm+5nmYN2yPly6lWFwinXho/BnKRAjJaRUpeb0Dg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3da17c12-1cbe-165e-94f4-44face9a181f@suse.com> Date: Fri, 9 Sep 2022 12:04:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xsm/flask: adjust print messages to use %pd Content-Language: en-US To: "Daniel P. Smith" Cc: jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220909095012.4251-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220909095012.4251-1-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB5570:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f9246a0-75db-4b4d-6311-08da924ab7ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x38vSf2MJRdeFKuhTYQaLDF1rbJ9cfYSRSbi8S9tvV1XpYkkVxqDRhUKC2EkHJSKMZ8nl4/944yhD5fwg516EWsjhtUH+alrKGKVmecobRN4hpNCp/ORNNj1L45SzBDHBRnwbs7a87ycAEruGE9nqwSEvDuKgkxcUYYuYc9ZVJMxgYvgTHC+qMUrlXxUl2sSd3JzV3G4eHfojmO/oRbypRUM7gi1A1re3shGFET8zvgzXDl2A4hZaM1y9mKZLQbD3RVDBRbGHBjMZWU6XNP/SNM0oQp6m+fKpYxEeNlxlJ3WA6a2soVNXs2q3bzyHEoJgbib4e8eWvbNpcvEIyRqqp3Y/bhvQByX+jCWxqB2Xpv1l9nKcVa1O0tPJpwL7Oc1hEqT2KqgnT11wN057uCduf/J/ccw2E5YAIJ7rO+LvKxgeWM7XprpR+gq+BuEwSSG/VKjQJRGFtR8jAhtOs38E/WvJV2fIo0IxUt2yPDcqUcmDjzNvs5CAgsGxYm4JV0X+eb0k6UvjaAjTHM/NQ9wc/t8FODIsGnvBVclbnBOQjhzus0q0PwWRN6hzmLJGNUsR7R+7yxXodeb1Bon5lCo5xq/eCZ2Lo/wJ2w7vJmRAU5Ld+Q87Stn717IY3Z8VOa1meS89yEMA+Gm4jXbhIsJUb7w3tPEU+N6480VGDRbsp5UN8GaTRn/Ze0sYWKkG9UWMna8Fxv0MyyuZSyR5eOFvcMEWzx8nzWn9Zp33GaUUic51QU9ECPq2c92VpKBFXLmiu5A4F48CYa75nb6YkCMhT6eNvDqI/GvAc+SOlAIHwY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(366004)(136003)(346002)(39860400002)(66556008)(5660300002)(2616005)(8936002)(316002)(36756003)(8676002)(66946007)(4326008)(66476007)(83380400001)(38100700002)(186003)(6916009)(478600001)(6486002)(41300700001)(31686004)(31696002)(2906002)(86362001)(26005)(6512007)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzlEci9kU1JPbXA2UGcrcHpUN2ZHT3Vqb1M1SEg4cXd3Y0pNOGF3blZ2SGtp?= =?utf-8?B?OTlqRERLOGVKa2lKMGprb2FXOHhXWk4rVlhHbmVCd2xWZEVBZGNvNHI4WTA3?= =?utf-8?B?SzhHSFFWU1dpaW1yVUxPU1YxY0RRc3VzSEdtUDJXSWJpbEFmL2gwQm1ELzlD?= =?utf-8?B?MzY4amd2cS9jSkc5dEdmZVcrMTJQTkJEWHNaczM1cjNkTkt0VjU5ZkV4OHBS?= =?utf-8?B?OVF6Nzlkam5HcnNzdi9kMXFXZWE4bzJPeXVCNVFTOUQyUU1qc1V3M002TWps?= =?utf-8?B?K3oyVHZtTTRUZXQ4YWVseFJvdjM3dmx2ejFUenZ5NC9XeUxSSXJYU0tKYU10?= =?utf-8?B?T3gyQm5zbHNkY21PMFNqRmt4Tit6bjJIcmNJSWI0UFlwOGVqQmNPb0lUOGVV?= =?utf-8?B?Yk93L2JYemxNSzFVU1RKalFCaU5FalFtakdYZlptSWc2emZrbWNHb2NTeVlH?= =?utf-8?B?RkpUSkZDd0tKYm1xQ2tEUE9sTEI1eHg4TDlhdzNpWXhUSHNNTENXdi82YWdv?= =?utf-8?B?RnZZZldjMmMwRUIvdThzQnZKSzIwbTdPRUlSdHBreGtjanAyelkrNm9mc3oy?= =?utf-8?B?NmdXMUh0anRXVmsvM0JOMkhoa09OdmR2Njh3ZEtLQmlVTEJ2QjRKdEo1M2lD?= =?utf-8?B?SEhibTlpNDhMMVNiMk9OSVo0cE51UmgrbkErdlhBMmJmTThVaHBUQVhwVTlZ?= =?utf-8?B?ZzJKdmhMKzVldldNZVNoY2VsdVRVaDNvckxmcmZqeVp0N0hwejRXQXpPSVpX?= =?utf-8?B?RGUwVnk4ZE1YaDZCTzI5OGhHZ0lETDhrci9YMHZlNFZCK25veGp5cFZzRE8w?= =?utf-8?B?U1liZFJHaktyUUxNN242b2dodzhkUnZjWnZQZVQvUkJqWDZMdGtHT1l3TUpX?= =?utf-8?B?eE8zVFp1RHFmTDdGY0NpeVBuNzRYcXlhdExzb0h4K2Z4REdtblEzTlNXc1NV?= =?utf-8?B?VkdjL3ZiZ3pFSkdJNUtmVnAzMm5pS0V2L2dNdmZYc2FWNjF5ZmxuR0FVMnl3?= =?utf-8?B?VU1LazV2d0wvdU1yM0JWUzJHV3RIcGNkNEd0aHB6a09TY3RUcEZUeU0vQzUv?= =?utf-8?B?bUFpa1JDRkxYUk9MSXY1SnhCZ1dYdndjNy9LM2NaeE1rZHRiSHlFdUF6Zm1S?= =?utf-8?B?V2VKT1ZRZm1PUFFGK2laYnNaeHI0VnA5RjlMUjkyak5ud3RBeFRVMUhKZmxQ?= =?utf-8?B?d25jQ3BYbEJnaE5rNllYMjNJUnRGQ0JRVUlyWHpZZ0RYcE9VM2IzSmUvdlpw?= =?utf-8?B?ZTNFREF0VjE5RDQ0WFU5UUFTeXlQQXZPcDdGdFZZS0cvU1gvR2YwQmp2NkZj?= =?utf-8?B?ZGNrODk3R09TVnhVQkg2T2N3SjAyMjVQQ0oreGRiNVE3SFlYb1hOeTV5aE8r?= =?utf-8?B?aE03S2tXaGlzV1BhVUdtc1ZpMDFHSGZnMzUxcXkzUFV5bFN6d2htVzl3alRC?= =?utf-8?B?TWw2eFIzSVYvN3p6WmxidUhoaXFheHREQWcrTUlvMVFrREpRc1lvSnpyU1ZQ?= =?utf-8?B?NVNTWGpURENsVmRJd3FNUnF0QmFBNHhUaU9qam8xRUpvT0ZiMUVmWXFYMWhN?= =?utf-8?B?WVkvODY0SXhEQ1ZKTEpjRW9UOVFacnpXaGFzMVZIcjZrKzN0N2l5MWZKSnlC?= =?utf-8?B?VEFUajdadmVzNVlZdVNQVHkxbDlMTFprbkpiM1lMR0NjMkVkM0NLeStuYmNn?= =?utf-8?B?a1h4R0dHeXkxVlRmMFFjQlZrTTNRVms3alByamF1ajNWZ0R5S3ZRdEtwODB3?= =?utf-8?B?VzFzWWZ6dUMycGNRTzljclVwRmlGckZvZ2tpVGdONEVTZHJyeDEzYzc3RGpG?= =?utf-8?B?cGZBTUx0aGV0ZG40SWM3b3ZIN0hEUDVHazlqcWN5Vk0zRGNPS2J5STVER2Fw?= =?utf-8?B?SVZmWFd6cHBlU1RoV0dmTFRFWXZ6OVpVdUtNTjNFYmtpOU42MHFvNTYvYkZj?= =?utf-8?B?NVQwUnBydDRXUnZQMmEra2E5UkNmUkRONjRhQU9pSGpnWTVvRUtHdFI5Zmd3?= =?utf-8?B?UktmVlFHVFlSamhsblQ1cGQ5elRiUEdZL29Dbm11aHk0bXBmcWtsamowRUho?= =?utf-8?B?R25RdmlJbkM3L3lDOWN0SnNoWW15VzNTSVY2b0Q3ZENqTk9JY2wrUmEvTXZv?= =?utf-8?Q?H/ZZJlNVT/AOrK8ky2TZ7azZT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f9246a0-75db-4b4d-6311-08da924ab7ab X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 10:04:43.4294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7YsTD+e8vAilvWLSTS1zDTPJwwqjAZlKcmWar3fVbSH5n9OMx59uIrHY5P1kPqBYebH+I/DLZViqrAAFzcei3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5570 On 09.09.2022 11:50, Daniel P. Smith wrote: > --- a/xen/xsm/flask/avc.c > +++ b/xen/xsm/flask/avc.c > @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, > if ( a && (a->sdom || a->tdom) ) > { > if ( a->sdom && a->tdom && a->sdom != a->tdom ) > - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); > + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); > else if ( a->sdom ) > - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); > + avc_printk(&buf, "source=%pd ", a->sdom); > else > - avc_printk(&buf, "target=%d ", a->tdom->domain_id); > + avc_printk(&buf, "target=%pd ", a->tdom); Apart from switching to %pd to also replace "domid" by "source". That's fine in the first case (where both domain IDs are logged), but in the second case it's a little questionable. Wouldn't it be better to be able to distinguish the tdom == NULL case from the tdom == sdom one, perhaps by using "source" in the former case but "domid" in the latter one? Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:18:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404124.646467 (Exim 4.92) (envelope-from ) id 1oWb5b-000878-47; Fri, 09 Sep 2022 10:18:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404124.646467; Fri, 09 Sep 2022 10:18:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWb5b-000871-1K; Fri, 09 Sep 2022 10:18:23 +0000 Received: by outflank-mailman (input) for mailman id 404124; Fri, 09 Sep 2022 10:18:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWb5Z-00086v-Re for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:18:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba3e5fe5-3028-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 12:18:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8710.eurprd04.prod.outlook.com (2603:10a6:10:2dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 10:18:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 10:18:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba3e5fe5-3028-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IV8R+MtZVnSCi3DfnGDyxrd0AItnLgzQqm+iHqz0Dg0GnZJvL4rrCVGtcZVQJ3Dr9a4367iCSL3DLyEqBKPdRj6JbXcdjnrtb5ADHROuoZ+SQMO+9BXKp8aJau0e58vE/1zv2PcM4HPA2APRNujHMflZ0bLaKwypwAqgG6jfw6bEFUL8X/6djeFoiro8PBDjMy0vrxwPxC1+ggJ3KDrSdATxZYb8OpgA515iF2Momet/QRTR+vn2y6ibweER38WX50G48QqkmiRgqzrwRyBbALeX1L084rNHdYbNYjEFCcCgB2sHsor61wV9V1R2JMHv/Mpcll4+9dNwWeF0RDlkYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HnVpo75K2ajU9Prf0GLOajBAWXGHI4F8hbqIMVVqlcg=; b=aolgVJsC4QZaiQkLt5dbaZIpcXuhfvfXMGWEg9uLEeJVyf2lz1qPaWeyeshA8RBDMtiJQKylw0LPaBZQGJyD2k+HllKCB3UaaLblH1rewtAZ832I+vdh9ujoF5gOnx8P68hA1peo7isQhMPqf6Z9u6dSAxfaDmf4+EMmA/w/HyGwyVyMUYjHUeJEy+uSVtlfdXedXrNGxzXJU14BniGXNDneRmYc/dzFkXfQjqk68P09rBksDuSbwKwr+K7uYIjXdHA9FSTl7mOFKS2XP+xWltv24qXH3XwWg4rXlVXkN/AwRWUY5uDekwYy32nKciwOt7rFlp31d8YA6VqarTtBqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HnVpo75K2ajU9Prf0GLOajBAWXGHI4F8hbqIMVVqlcg=; b=Ud+Kixo4XyeBInAVzu94K67ZobT8AxeuK94s3puOhwGteJGG6fyYl8auzdOw3xpuw7bNquwzl8zVkJCE6ptE5ds9D1M18+B2cBMYXsaQxTtTvl1mlhBT1syRcBwnMa2T3S9ZYp+GbyWKjT7ccvEwPvjzPXFoMoLSKFzoVoX080lsKpA09jz1T0Wcsog/JQyKqbJBN/sbjPCfOqlBMhbDiWTGglf4DhHCqA9o7BmvrgqN7zboxW/d5iNMPPgHR0sLtxt2jfNVzxPxnG6wuyRexb4C7YnZONGqc/CFufSB32jwSsLdcEB+33WVaNZRx9szAMVEv67oxsg900Z8OB67TA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1c23930f-e809-d623-18ec-599a0e983b7a@suse.com> Date: Fri, 9 Sep 2022 12:18:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8710:EE_ X-MS-Office365-Filtering-Correlation-Id: 3be7ab50-29e9-487e-26ef-08da924c9da6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Doo2UjbmzJhD6nU+9yNephSbvoti1SyL+gmyC4m2og96FSAANmEjD74Djo9PxtdjBiz+5gPTdvQ1CtSFCRYOPy7HQBrFRovTA3qMTRYUjWK22GjQ9HUHfN1nlMI78zjDumn2wX90xIucHgXbB3iDnKS0D/3PMy5ic6xcSus4wS1V3bL7NZ7+OuAArpDr++2n2m/4aF6N/4OiDIcHq3TKwXamocaX+weuljmWwsgmzgsiKi7WGvyTpBhC9lVYK/n9CtcHAH/9YUUTFkVdJFyYwZXgylePpmBDmTSCTBFdjCksSx478kP2mySsjNAEZ8GK4gvAsb++uaZMf4OKpMEf8xuQkJWR6SfcmWQsDMRlzg4qCA5SJg/NB2C4z0/rRm4FRAkfBGzjVBHZf7x93GsdqiOJHnRc2e9hajzQpaLGHOL6PGVWCKsxa7UpWLP4DIXzLFhaZRBShdAsexfknrY4lyPxUHlZIPeAsrMBniyvShwP6SCGQYtdbzvtnKOn6ZYvuCIYColN9VE/gwPVZvxNvwxyfbNAzZTXoNDtl8vs9x51/LkIMmF1sF0Dk7flHrVgVGZPv7KT/lyHvhptDelEf6M4QO5QiQfhPiOe1m2GeDel6jlaL+3kgME8r04quR7jBTAhGIQR4kRW5wcLtlr9X9pP4OwkJ9gSJX0NszxeoOfYT52l++VXw8Ujd3oDIMeZy3pRnPmEX6a8u2cvZqeiZAE+a5R04HM+x3v0dTOfq7ouqMFTE9VBcRyHG4ZFzKosaLjZMgGCOXPseXa7axJMJcJAaQK2PsgFIk5cQD0DYaw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(366004)(39860400002)(376002)(31686004)(31696002)(86362001)(36756003)(8676002)(4326008)(38100700002)(66476007)(66556008)(66946007)(41300700001)(83380400001)(26005)(6512007)(6506007)(478600001)(6486002)(316002)(6916009)(186003)(54906003)(2906002)(2616005)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1h1SVNpOHhVL3VxZUxiM21zbWtoeUp6blRHV1pBMHVCZTBIR1p0SWhWKytl?= =?utf-8?B?RGdVMjVMeWJOTlplYTlIL2UvNjVPakxHcFVTeVZGM29HeHZYamdGMmNGQmpp?= =?utf-8?B?enVLczN4N1ZRd1BZMlVhRkJ2VURVNlRyZ0VRUnRBdnllREpaZW9FUFZSbkxq?= =?utf-8?B?aEd0RlQwK1YzRmxDeDdhNlR0S0tKemZJQ0Zrc0pzNC9GYTdmd2k4MFZtLzNL?= =?utf-8?B?U1R4U3hiVGJXdnkzQ0ZqK2RoTlArU2wvNXdsaTNjZ09YbzhCSGZuZUNSaFUv?= =?utf-8?B?bVE4ZUpvS1p3a0c4Q2xXRGNTL0kvUW1JN1o2bi9EZW82MENkVk9BbUpjdTJQ?= =?utf-8?B?SS9KTmwra3RHNGdqQ1FwL2ZLNmJvU0w0di9adENTbjRsSFNjM1JFby9lY242?= =?utf-8?B?dEp1V2ZPRjJBMkZ3c3gwMUZoS3RwNkhsamYwcUdTYms5b2VxQ1BjUktpOE9I?= =?utf-8?B?TXZ6SitCM01SbXNhYlA2U0c3a1g2THNtU0huTVJFSUpjMCtjODZnRzFtdXFU?= =?utf-8?B?M3IvWXliV204dHJ4VzBDNXFzWkpDbkc4RjhRcFh4UDVtMWlUQXNzSU9FNHVh?= =?utf-8?B?WEowUHF6ZXMzL3N4bnRqNzVFZjZlM2tvbGZkQXBkQjJrbi9PVUtVZzM5QzNy?= =?utf-8?B?VHI3eExHWGRremdIdWFFU2o4MHJ5VkF2a3pWVTBaQ1MzWDJ0Sml5K0FGQ2ZE?= =?utf-8?B?T3l5UDJpVStKUmVDZGthcmJwZG5DQlJvR2VBMFRGTVhoMWZ5dEN0aEY1M2U3?= =?utf-8?B?cHFsSEMxOG1YbmN3MGpUU1piem9pUWpreG9yaXhVS1lvdDNGVmhYdExwcCtX?= =?utf-8?B?TDBIcE1sTzl6WjlCUlNaaDQxdkhWcDgwSnltZmVxUGxXYktSbFVCQVpsczJJ?= =?utf-8?B?UkpXdzM2WWMwK1JoMkhaeHpYRE1Mak5SZ0VLc1pVSWxrVDhHTFZTb1l3ek43?= =?utf-8?B?WDNCRHA3aHcvaHkxNWx2OWNTZGJRVk1KS0w4M0hhNHpHZG5GZ1pLSCtIc0VL?= =?utf-8?B?NC9iZkFtOStZdjFia0FHUE1kQzV6OVdQTzUwVUZlNmpRanExdHc2eTd6NTZM?= =?utf-8?B?R2ZXdEJaV1o1Uk4zVGcrQXdlL3ZHS2UvOUdaUHBRZ1ViL3N1OStDN0tYNC9E?= =?utf-8?B?bmpEaG0rU1BLdmxtU043UVF6S3dQTDBRNFR0bGZhTXVnbm9xeHo3ak1GRVNr?= =?utf-8?B?U1B2UzJMRlVwdytVT1Z5OVB6WSs4TytyY0xVVVZkYjZma3lLMm5qa3JhMFpt?= =?utf-8?B?dEVsaVhoZ2F1c2kxcmhDUU85SmxBallYS2tuRlFONHhnamNPcVdid3dSZ0t6?= =?utf-8?B?WTc1TVJUQXFmckFWR09QcjgrMWxBK3ZwVm1VME5JODBpcU9PUlZGMHBISWha?= =?utf-8?B?cE5GZGVQMEdmd09jSzlubURMZU9ZbkQzbmVqT2t1S3pZM0VJa3R3N3FZR3dG?= =?utf-8?B?Y0RWWERXVHRiRG1ybVNyWHpHOFBWaEMvVGhmTjRuZjk3UERTSzZSZC8yN1VP?= =?utf-8?B?aVdJZ3R3S3YySkFpbDkzUlNTVVp5bWVMa3hvaVJEL0tvN3VKYW5GVUUxYkZV?= =?utf-8?B?Y0tGTkFaWE5oV1dRc2VlZVE3eTNBWENHcTRpQTZITEU3Uzd4aHViL2xsTnRB?= =?utf-8?B?M0s2d2JDWGNwN3o5d01kNjdJcVhVbG9aNHRQU3hvQ2pCMWZwek1vcVlQdXp5?= =?utf-8?B?N3hkcjlPTldZV3lQT2dNV3hrTnFiWDU5V2VPbVpuaGJiV3I0cEJ4eXhjdmZv?= =?utf-8?B?aVVBejZISi9wWWpjVTM2K1JnZUI3M1NiTkFnQWJ6VkVHM2p1TjlTUHRYL3JC?= =?utf-8?B?UEdueHU0REtJSnd4NkdNakhzckxwOS8rM0tvM05Lbk5GWmxrOEUxeFlaMXNE?= =?utf-8?B?WU44UWJoUUdyNkZac0xjUmhORC9wRXIvQTZXVktZVi9TL2VreWNwdVgyM3Nu?= =?utf-8?B?UDNVaWVKcStoVUg3SEt0anRvNE9KUzdrUU9BN3l3ZXhhN05tMXdyNGdJRU54?= =?utf-8?B?eDU3QnFSRWExUnd3dFVnalFlTFh4YzcraFNsTGkvdzUzdHBoVGFqYkxRWkM0?= =?utf-8?B?NGo2bFZMcUo1WWZEdHhlajlibmIySzVtM2xHdE0wSC84eDE5M2EvSmswUGND?= =?utf-8?Q?Ytt9ARYCQBXZ8+lvAE/FJNV2w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3be7ab50-29e9-487e-26ef-08da924c9da6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 10:18:18.7834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpnThxLGF5A/7EqK57ZbdLAvF/lMhylvuvwT4QhtvBv84meEGgjCGmwoDiqh/eGmvawRqDkjEG/MlXuVlbKigQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8710 Gcc12 takes issue with core_parking_remove()'s for ( ; i < cur_idle_nums; ++i ) core_parking_cpunum[i] = core_parking_cpunum[i + 1]; complaining that the right hand side array access is past the bounds of 1. Clearly the compiler can't know that cur_idle_nums can only ever be zero in this case (as the sole CPU cannot be parked). Beyond addressing the immediate issue also adjust core_parking_init(): There's no point registering any policy when there's no CPU to park. Since this still doesn't result in the compiler spotting that core_parking_policy is never written (and hence is continuously NULL), also amend core_parking_helper() to avoid eventual similar issues there (minimizing generated code at the same time). Signed-off-by: Jan Beulich --- a/xen/common/core_parking.c +++ b/xen/common/core_parking.c @@ -175,7 +175,7 @@ long cf_check core_parking_helper(void * unsigned int cpu; int ret = 0; - if ( !core_parking_policy ) + if ( !core_parking_policy || CONFIG_NR_CPUS == 1 ) return -EINVAL; while ( cur_idle_nums < idle_nums ) @@ -213,8 +213,9 @@ long cf_check core_parking_helper(void * bool core_parking_remove(unsigned int cpu) { - unsigned int i; bool found = false; +#if CONFIG_NR_CPUS > 1 + unsigned int i; spin_lock(&accounting_lock); @@ -230,6 +231,7 @@ bool core_parking_remove(unsigned int cp core_parking_cpunum[i] = core_parking_cpunum[i + 1]; spin_unlock(&accounting_lock); +#endif /* CONFIG_NR_CPUS > 1 */ return found; } @@ -260,9 +262,11 @@ static int __init register_core_parking_ static int __init cf_check core_parking_init(void) { - int ret = 0; + int ret; - if ( core_parking_controller == PERFORMANCE_FIRST ) + if ( CONFIG_NR_CPUS == 1 ) + ret = 0; + else if ( core_parking_controller == PERFORMANCE_FIRST ) ret = register_core_parking_policy(&performance_first); else ret = register_core_parking_policy(&power_first); From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:20:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:20:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404134.646478 (Exim 4.92) (envelope-from ) id 1oWb75-0000SL-Hi; Fri, 09 Sep 2022 10:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404134.646478; Fri, 09 Sep 2022 10:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWb75-0000SE-F8; Fri, 09 Sep 2022 10:19:55 +0000 Received: by outflank-mailman (input) for mailman id 404134; Fri, 09 Sep 2022 10:19:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWb74-0000S6-WC for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:19:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0c49d28-3028-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 12:19:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0c49d28-3028-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662718793; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5QzqMoYYexDvmV4qRCgPFEnGFIR2jMBBPwRamOYQ/s4=; b=e4e9H55iLWxqM2CnbvsCmNaAf4mz/REz/lS3k34V60/tu/9TwqsO8Vz8 dReaDYSR6BwhVaMk6bWKIiauIg0iPYd7ILT9ye+9rEYFGsMr+ur45h+tJ 4sfyPAxDFxUInAAVLwPxWfYL+l9lwoKQdum3f9NtuIi+uoAQ/0IVQaqsJ Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79831939 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:yOF/tq+VlObAcl4/8ZZ0DrUDi36TJUtcMsCJ2f8bNWPcYEJGY0x3z DMfWmqFbK6IamWgfNl3b4/g8hkO7ZPXzoRmHVFr/Co8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gFaYDkpOs/jZ8EI37ayr0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGS24SAaM/wu1MUFpA+ OQfDW1KVxyyiLfjqF67YrEEasULKcDqOMUUu216zCGfBvEjKXzBa/yUv5kChm52350QW6aFD yYaQWMHgBDoahtTOlARGdQmkf2hnHXXeDxEslOF46Ew5gA/ySQugei2aYuOK7RmQ+1llFyH5 V6X3FjeB0pFN9CRkxOK9Cqz07qncSTTB9tJSezQGuRRqEeU3WYJDxoVU3O0pPC4jgi1XNc3A 04b4C01toAp6VemCNL6WnWQv3qsrhMaHd1KHIUS6giLxrDF/gWxCW0NTzoHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZVJbuZ+5+th110+RCIY4eEKosjHrMXbf5 wykixA1vOQog8MT0IDmumnLsj358/AlUTUJChXrsnONt10nPtD+Ptf0tjA3/t4bct/HEwDpU Gws3pHHsbtQVczleDmlGr1lIV2/2xqS3NQwa3ZLFoJpyTmi8mXLkWt4sGAnfxcB3irplFbUj K7vVeB5vsU70IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxDKgT63yRd2yPxgU Xt+TSpLJS9CYZmLMRLsH7tNuVPV7ntWKZzvqWDTkE38jOv2iI+9QrYZKlqeBt0EAFe/iFyMq 75i2z6ikUo3vBvWPnaKqub+7DkicRAGOHwBg5AJKbXbf1E5RgnMyZb5mNscRmCspIwN/s+gw 513chYGoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:J7US+qGTfx7+cF3HpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo= X-IronPort-AV: E=Sophos;i="5.93,302,1654574400"; d="scan'208";a="79831939" Date: Fri, 9 Sep 2022 11:19:39 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" Subject: Re: [PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings Message-ID: References: <20220908195113.218201-1-jandryuk@gmail.com> <20220908195113.218201-3-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220908195113.218201-3-jandryuk@gmail.com> On Thu, Sep 08, 2022 at 03:51:12PM -0400, Jason Andryuk wrote: > hvm_xs_strings.h specifies xenstore entries which can be used to set or > override smbios strings. hvmloader has support for reading them, but > xl/libxl support is not wired up. > > Allow specifying the strings with the new xl.cfg option: > smbios=["bios_vendor=Xen Project","system_version=1.0"] I've tried something like: smbios=['oem=foo=bar'] And only "foo" is added to the smbios string. Shouldn't we allow users to have '=' in their smbios strings? > --- > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 2abaab439c..c3125ed310 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -771,6 +771,27 @@ static int hvm_build_set_xs_values(libxl__gc *gc, > goto err; > } > > + for (int i = 0; i < info->u.hvm.num_smbios; i++) { > + char *p; > + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, > + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); > + > + /* Convert libxl_smbios_type string to xenstore path that hvmloader > + will use, as defined by HVM_XS_*. That is convert the '_' to '-'. */ Could you add a '*' on the second line of that multi-line comment ? /* Multi-line * comments */ > + p = strrchr(path, '/'); > + for ( ; *p; p++) { > + if (*p == '_') > + *p = '-'; > + } > + > + LOGD(DEBUG, domid, "Writing %s = \"%s\"\n", path, Could you remove the \n ? LOGD() macro already adds a new line. > + info->u.hvm.smbios[i].value); > + ret = libxl__xs_printf(gc, XBT_NULL, path, "%s", > + info->u.hvm.smbios[i].value); > + if (ret) > + goto err; > + } > + > /* Only one module can be passed. PVHv2 guests do not support this. */ > if (dom->acpi_modules[0].guest_addr_out && > info->type == LIBXL_DOMAIN_TYPE_HVM) { The rest of the patch looks fine, even if I can't say much about the generated golang code. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:24:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:24:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404144.646490 (Exim 4.92) (envelope-from ) id 1oWbBK-00026N-52; Fri, 09 Sep 2022 10:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404144.646490; Fri, 09 Sep 2022 10:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbBK-00026G-2B; Fri, 09 Sep 2022 10:24:18 +0000 Received: by outflank-mailman (input) for mailman id 404144; Fri, 09 Sep 2022 10:24:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbBI-00026A-O7 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:24:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8de7793d-3029-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 12:24:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E4D8A336C8; Fri, 9 Sep 2022 10:24:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A197A13A93; Fri, 9 Sep 2022 10:24:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZjAhJk4UG2MudwAAMHmgww (envelope-from ); Fri, 09 Sep 2022 10:24:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8de7793d-3029-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662719054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sSUlAVYH6Gf8aAog2W5wHnm7zoNDnmFGQUM7teLNNsA=; b=kK8ne8O9mGwA4z53kWxhZoS9PSUcQ45HpFs2FwaeGfjDHuD3beA7KjPuNrWvkgnyiNyZWw ciW2A4z62DDvYWvuaR7p9LNaGvQmF/DYPAuJwjs8DUjUN1/YP+K0iZvxF8fspKbdOyMCx4 X4QYZdYyk5DOLmC3pI1jWkLdDjTuwxY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2] xen/gnttab: fix gnttab_acquire_resource() Date: Fri, 9 Sep 2022 12:24:13 +0200 Message-Id: <20220909102413.2899-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") was wrong, as vaddrs can legitimately be NULL in case XENMEM_resource_grant_table_id_status was specified for a grant table v1. This would result in crashes in debug builds due to ASSERT_UNREACHABLE() triggering. Check vaddrs only to be NULL in the rc == 0 case. Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") Signed-off-by: Juergen Gross Release-acked-by: Henry Wang --- Might be considered for backporting --- xen/common/grant_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index ad773a6996..fba329dcc2 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4140,7 +4140,7 @@ int gnttab_acquire_resource( * on non-error paths, and hence it needs setting to NULL at the top of the * function. Leave some runtime safety. */ - if ( !vaddrs ) + if ( !rc && !vaddrs ) { ASSERT_UNREACHABLE(); rc = -ENODATA; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:25:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:25:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404152.646501 (Exim 4.92) (envelope-from ) id 1oWbC8-0002dp-FI; Fri, 09 Sep 2022 10:25:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404152.646501; Fri, 09 Sep 2022 10:25:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbC8-0002di-CC; Fri, 09 Sep 2022 10:25:08 +0000 Received: by outflank-mailman (input) for mailman id 404152; Fri, 09 Sep 2022 10:25:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbC7-0002dH-7v for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:25:07 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9e427cf-3029-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 12:25:04 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM4PR12MB7525.namprd12.prod.outlook.com (2603:10b6:8:113::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Fri, 9 Sep 2022 10:24:59 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::badf:4ed4:db1d:e5d4]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::badf:4ed4:db1d:e5d4%3]) with mapi id 15.20.5612.014; Fri, 9 Sep 2022 10:24:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e427cf-3029-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqC06oa6aKSiDnk53lVAP2aZVhhOXZ2C3hVSbcEdMkttQyZwp42qApZGuzDagGu5/PfMhOdHvr6g4V3UFDgP+3faAJVFJBT3OeVq2Al+XaC1DSdcdEE6U5A0aH7rYFIemVHh4rtjoTrjNoNbMqlBl6VXWYQbUxkwDoiaKk6Q/fVi/VHZGcb8pYvpwIV7YJnYVWMK+2OA8HOMZomDbDFQiQwRZ8Cs2aTA+23rUUHoWlM85SfteP0CDibl61QZLa5fjQZKc5lzLmV8FQTNG1xUDPzmc4Ajob9VdWhPG3fgLcUiFgiVJlqJY3oUNeBlFGthKEwWqB5ztRWUstDSzqLmkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mqRh3mz3r+v5TshHp2O3w0mHKEl5yzWZWHn/l/aTA1M=; b=SAdVH9Kv2ps8g4AlqqOuwSesvKAmy90inbTV93vcOMclzTWmwZv3//ltvwVLAZPSgvlXFW0bX4rZjkfs9Hsrlfmvb8kQxDSyAOUS+qo+h0OAiw1xfPACWQ91PtEd/48P8kCAj5cAaSnwSU5WFBvkG1uLjOt/XI7jWjzTbReq/wszNn6yHuKhjf1MnLuu5T6ZfA0gZtjMl/zloo4HpEZF0zQYTx/iFlQtpWSdJ6f3t6P1yhTbLm4Xep7QYswbn8viysnoi1iSyxCRVWmHSk9NJyc351VLE3xrM/DLv3A8hs+sT4FjhSQe3g0x30JSUhnXhQACe/A67ZqZW/qaaW+/yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mqRh3mz3r+v5TshHp2O3w0mHKEl5yzWZWHn/l/aTA1M=; b=G6TcwVxsf87NNKVB8irHKEtMzeL8RjbruZlduLJ6f+Eg+EQPs5e3SUjMX949UJEYRIr2i76byIpe1Wvv1J6z96OgBOqEivBBWoiXZN3tRmMs63ovqQlweY/0StdBJjS4Os5M0wWbC/WWws/V7RceONjDoqRSpWVDAs9gLmXTLpg= From: "SHARMA, JYOTIRMOY" To: "xen-users@lists.xenproject.org" , "xen-devel@lists.xenproject.org" Subject: RE: libxl source code Thread-Topic: libxl source code Thread-Index: AdjENV78escYILheRq+LqRiZYu2hAQAAP/9A Date: Fri, 9 Sep 2022 10:24:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-09T10:24:57Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=33c19e88-ba85-4ae7-b306-256e35b401c5; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4297:EE_|DM4PR12MB7525:EE_ x-ms-office365-filtering-correlation-id: 7456814c-1401-4e5d-e70c-08da924d8cbc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /X5jSuOl66tObs9J9T6ljsR+Sco9of2kRCR54ynhvRBKLJjAqveBZNrVeJg7fKNsJhB+u5vS2KPHKwAEDUX8n54bX0idtQQM3fENz2zR+iPIXXortjlSAAltELV+Ujmi81CkotGFTRxjo0xjg8w8HIUF+AqL5y8dSCuyHkQDED+5TkwmNLa87xVuUax8K3cUeYxYzJVttt0A0OJBaA8j2N0GLN621SOVFvfKnuXKBDXacSj+Kf+FNL3WGAjAsWDXAjVtFwyd1KoYe8Tn++uSPsn0PVbICBpMbA/+198wAsy22FbMYuR6GDkMDHt+DVuIxL62plvbdPnEFRgXPXDxLGdLlxFZ5j4TibHuXRuhB6Rzu+Wc4W2EVvh8HW5QEWAOa1uAHsqcmWzkJA1FJzSW75EbO3GyImU3VMeKGiTnhbCMQxluCgzpVWDglQ5Wr+qK6twHa3nR+yG5sRoz9Y5RqPHvmKrgN28I1DxX0MwxZp0NECP01HqM9gQVMDvvT5zxgJZfCiRa2rdm7D0oUoIk6a0M9EkRSbZwOhTSS6xmjZIa7FKANWEugnBn3qkolvMM7cEnOonyOF6gnt70dRH5Edzw2wf2NtRRDFMILBfFv1eYJqQTnNLIXOIeVCMCWULjyU7dlGX5vdlmT8tdGSgrqfQKYpaSQCMmr/17cmJbgNTBsiXb0sQqanoRNTmCLW7xTwsWX35bzKsiAYli4mU7ZM+nbJ1M9cyBl/N3ssN3+FGstF2ApjPEgjmfjERHCJysmry1QXGnmgJ8XwDJj2wlcA+kjBvSUjOy+b8QIJryw0rTyp7y7GLWae8p0UQMWxZuOK/OHV4mIkCgktksjzA1uw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(66946007)(6506007)(478600001)(76116006)(316002)(33656002)(38100700002)(3480700007)(450100002)(122000001)(110136005)(86362001)(7696005)(186003)(7116003)(55016003)(66446008)(966005)(64756008)(66556008)(2906002)(26005)(9686003)(8676002)(66476007)(5660300002)(52536014)(53546011)(38070700005)(8936002)(166002)(2940100002)(71200400001)(4744005)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8gf1pY/slrIsQCkz6FLZBJFmT5/DsxbTmUIhMJMBn9yA6urjWgSF1djnuROT?= =?us-ascii?Q?WMZSIUcG2FS9WzUy+cqhzkuWwoQRxznBZ2h1jThkO9+AmjEXCBI3zqWyiL8t?= =?us-ascii?Q?CWHcCTrenmRKq2+ElQT6c22Y4uUqbezsImH5PYI2vHwjmAbna9OUxCD7gVQ3?= =?us-ascii?Q?rJnSwtQdUHzeywZNN7caYNxwkECJqny+RPIGLRUNtIjnW/aNQVMvG4qNmnsd?= =?us-ascii?Q?FCaLy1WuptbUcmArRo3CVdy3dWsiKyJgnU86FTMu9SzLnJ2O381VhibYdn8U?= =?us-ascii?Q?ZFcAnq+a2Rb+odzrLp6nX2DcUKZQNAFvdKN6lPO6dntihpsK6SwBdc/5ZWvC?= =?us-ascii?Q?5MonvAM9mBNpoaD1XIVpM4W2urf1TTRglMkf4h9SadBOMhaXfnQWdSDQ0l3d?= =?us-ascii?Q?vUr200osV4NlX/6LZzwXQt2ZvPw9w+iwHR8dC4u81NMSa1DJlmfZGBfN3alU?= =?us-ascii?Q?hN7QVdagjmKbx8JHGbq4V8WF2ZT8tIWxI362bmIGqd21Af+CrEDbrCAEyLYL?= =?us-ascii?Q?Aewulst5jOitltlKjYaNNaUyjJifq8eQi5V8g03i6HIgARn7a+UCiOogEMdm?= =?us-ascii?Q?09P4QCYQiy+R+FzAWukwPBxMSQSA7Vvq3THmyC7hu4gWCvM127NFlIoo20/f?= =?us-ascii?Q?X5yqmNgqEtZcI87KV8Zhoo1zpHo60Acra2CF0hcMF5k+0nZHBMLr+si25EAl?= =?us-ascii?Q?WEH8UrD2iuCP9uNYuDWQrtcPsFmEZZzwfI62ycKKsdCrWQj6l8ge4MoAgqyy?= =?us-ascii?Q?OzSUxezLYqVyH/tqdqQY3qcjQPXBXvKf01asTqLA+rVIqe9uSDPMULqeBG/l?= =?us-ascii?Q?iSesWUGfC8SGBIuYNp1stX44QzaBW83TFxWBpEDeli6PdOx0FaL+TeBCYMZv?= =?us-ascii?Q?oixxUSWCwQn7R+aEEIcykVoFiJyDJlklAdalMGrWb3r4c8WwqbeIkCPkLHSM?= =?us-ascii?Q?Mhvk+cRwp1dIyR7QQQCvSDfGUAnYC9xmfS7F0+tIT+YFs0BWxdpa0xLxtcWS?= =?us-ascii?Q?gmYjfXdKx3iBh3/o+dz6dQ2Fn/6dEz3TRrxWEFmxhrR70tE59bXR7knZJC+i?= =?us-ascii?Q?BlDtljgRkw2yYSuv+tsFnHMacMNm5Sqclb/JMMrq7ecibZC4qJPxR7yo/MuK?= =?us-ascii?Q?HpCvDr5NvqRCbiQQWUqOJmVardKhTVk5migAffGXNSHIKNmSiedd4IK2TwvN?= =?us-ascii?Q?IVTEbhBfuOeG2Ap8tKB4Tp0xecfVQY9O2sFNHyuCLGBuDCo6ePp3thytwpIR?= =?us-ascii?Q?hCgDpCM9QGLHlmjQpS53TnV0wiBHfIkthEqInSgJCTKgVW+w4S+lXdQV7kAo?= =?us-ascii?Q?cGcqy4m/z0+tv5uCkJTwZRRbPjWByqP25rqjAXeqpSX+KN2wSh3J+rjuVe0W?= =?us-ascii?Q?YAcLV1YQScJXNnSy5YWMfIZh+GSHkSZ4gL6zP6TBdpt0lHSSF7HQsM5m8Yyn?= =?us-ascii?Q?s520BAu7151BwjAmYIY3o2mWHO7SwIXtORy4+CuDzAbpQQaa8vI1yr0FY3py?= =?us-ascii?Q?3fXWUvObb2hXJUzsavXfmhBYpin7tQo+05tUkb4U90ePbFZKyFxR7y9WJcLJ?= =?us-ascii?Q?1CcUbDM6hkT/t7CiGbuU7ghDRKohJcpGJsKtqjqI?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB4297F8894C8867A67C07C4789F439DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7456814c-1401-4e5d-e70c-08da924d8cbc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 10:24:59.7361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oobhJltki3PUmWP2Ezf2iJnvQ5Uy+eX5fmnBZwdnNRG89TQPGNPcGE9fzhsd1xDF/2Mfz3yAPLB3MHiqpwJexQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7525 --_000_DM6PR12MB4297F8894C8867A67C07C4789F439DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Adding xen devel Regards, Jyotirmoy From: SHARMA, JYOTIRMOY Sent: Friday, September 9, 2022 3:52 PM To: 'xen-users@lists.xenproject.org' Subject: libxl source code [AMD Official Use Only - General] Hello, I am looking for the libxl source code to understand how vsnd (PV audio dri= ver) has been implemented. However, if I look into the xen source tree (https://xenbits.xen.org/gitweb= /?p=3Dxen.git;a=3Dtree;f=3Dtools;h=3D9b2efe082223bbf60b41e947ceb4821e98708c= 02;hb=3Drefs/heads/stable-4.16), I do not see libxl folder. Specifically I am looking for the code which is present in the following pa= tch set: https://lore.kernel.org/all/1509548687-6071-3-git-send-email-al1img@gmail.c= om/ Can you please help me locate the source files in this patch set? Regards, Jyotirmoy --_000_DM6PR12MB4297F8894C8867A67C07C4789F439DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

Adding xen devel

 

Regards,

Jyotirmoy

 

From: SHARMA, JYOTIRMOY
Sent: Friday, September 9, 2022 3:52 PM
To: 'xen-users@lists.xenproject.org' <xen-users@lists.xenproject.= org>
Subject: libxl source code

 

[AMD Officia= l Use Only - General]

 

Hello,

 

I am looking for the libxl source code to understand= how vsnd (PV audio driver) has been implemented.

However, if I look into the xen source tree (https://x= enbits.xen.org/gitweb/?p=3Dxen.git;a=3Dtree;f=3Dtools;h=3D9b2efe082223bbf60= b41e947ceb4821e98708c02;hb=3Drefs/heads/stable-4.16),

I do not see libxl folder.

 

Specifically I am looking for the code which is pres= ent in the following patch set:

 

https://lore.kernel.org/all/15095486= 87-6071-3-git-send-email-al1img@gmail.com/

 

Can you please help me locate the source files in th= is patch set?

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB4297F8894C8867A67C07C4789F439DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:30:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:30:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404160.646512 (Exim 4.92) (envelope-from ) id 1oWbGm-0003da-2K; Fri, 09 Sep 2022 10:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404160.646512; Fri, 09 Sep 2022 10:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbGl-0003dT-Vv; Fri, 09 Sep 2022 10:29:55 +0000 Received: by outflank-mailman (input) for mailman id 404160; Fri, 09 Sep 2022 10:29:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbGk-0003dN-OO for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:29:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 577ced62-302a-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 12:29:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F04F122967; Fri, 9 Sep 2022 10:29:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D66BD139D5; Fri, 9 Sep 2022 10:29:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xy/uMqAVG2OSeQAAMHmgww (envelope-from ); Fri, 09 Sep 2022 10:29:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 577ced62-302a-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662719392; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OriNo0rDdgE6KAilLetTsYPyFFSdMzdzk+Nfn3qHTiE=; b=kVcrU6YpHLoOUyyUYFPswOQaDLv+DUb510yH+oqeQJ8nPvuKsDVtUlEE2YU28HOi7JMTSt aqvMCDuYoUWKtSj8Zp8epx27JHCTPSZgokP5FLd38bx6f19T2E/Wb8yIDE69BXuFNoMfw0 oUEqO2cxkujkZ7/8PCnZBxpycD0+3xE= Message-ID: <0c6e0ed1-9c88-4041-b3a2-50f22a1f0844@suse.com> Date: Fri, 9 Sep 2022 12:29:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: libxl source code Content-Language: en-US To: "SHARMA, JYOTIRMOY" , "xen-devel@lists.xenproject.org" References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------SrQ0loUW4XEVAnDKBE5HaHN3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------SrQ0loUW4XEVAnDKBE5HaHN3 Content-Type: multipart/mixed; boundary="------------j0Ko3iSi32pB6cL71yCucoEM"; protected-headers="v1" From: Juergen Gross To: "SHARMA, JYOTIRMOY" , "xen-devel@lists.xenproject.org" Message-ID: <0c6e0ed1-9c88-4041-b3a2-50f22a1f0844@suse.com> Subject: Re: libxl source code References: In-Reply-To: --------------j0Ko3iSi32pB6cL71yCucoEM Content-Type: multipart/mixed; boundary="------------ZXyL7ffLc2GEZ6xFfWMy3PPV" --------------ZXyL7ffLc2GEZ6xFfWMy3PPV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 SGksDQoNCk9uIDA5LjA5LjIyIDEyOjI0LCBTSEFSTUEsIEpZT1RJUk1PWSB3cm90ZToNCj4g W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEdlbmVyYWxdDQo+IA0KPiBBZGRpbmcgeGVuIGRl dmVsDQoNClJlbW92aW5nIHhlbi11c2Vycy4NCg0KPiANCj4gUmVnYXJkcywNCj4gDQo+IEp5 b3Rpcm1veQ0KPiANCj4gKkZyb206KiBTSEFSTUEsIEpZT1RJUk1PWQ0KPiAqU2VudDoqIEZy aWRheSwgU2VwdGVtYmVyIDksIDIwMjIgMzo1MiBQTQ0KPiAqVG86KiAneGVuLXVzZXJzQGxp c3RzLnhlbnByb2plY3Qub3JnJyA8eGVuLXVzZXJzQGxpc3RzLnhlbnByb2plY3Qub3JnPg0K PiAqU3ViamVjdDoqIGxpYnhsIHNvdXJjZSBjb2RlDQo+IA0KPiBbQU1EIE9mZmljaWFsIFVz ZSBPbmx5IC0gR2VuZXJhbF0NCj4gDQo+IEhlbGxvLA0KPiANCj4gSSBhbSBsb29raW5nIGZv ciB0aGUgbGlieGwgc291cmNlIGNvZGUgdG8gdW5kZXJzdGFuZCBob3cgdnNuZCAoUFYgYXVk aW8gZHJpdmVyKSANCj4gaGFzIGJlZW4gaW1wbGVtZW50ZWQuDQo+IA0KPiBIb3dldmVyLCBp ZiBJIGxvb2sgaW50byB0aGUgeGVuIHNvdXJjZSB0cmVlIA0KPiAoaHR0cHM6Ly94ZW5iaXRz Lnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT10cmVlO2Y9dG9vbHM7aD05YjJlZmUwODIy MjNiYmY2MGI0MWU5NDdjZWI0ODIxZTk4NzA4YzAyO2hiPXJlZnMvaGVhZHMvc3RhYmxlLTQu MTYgDQo+IDxodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXRy ZWU7Zj10b29scztoPTliMmVmZTA4MjIyM2JiZjYwYjQxZTk0N2NlYjQ4MjFlOTg3MDhjMDI7 aGI9cmVmcy9oZWFkcy9zdGFibGUtNC4xNj4pLA0KPiANCj4gSSBkbyBub3Qgc2VlIGxpYnhs IGZvbGRlci4NCj4gDQo+IFNwZWNpZmljYWxseSBJIGFtIGxvb2tpbmcgZm9yIHRoZSBjb2Rl IHdoaWNoIGlzIHByZXNlbnQgaW4gdGhlIGZvbGxvd2luZyBwYXRjaCBzZXQ6DQo+IA0KPiBo dHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMTUwOTU0ODY4Ny02MDcxLTMtZ2l0LXNlbmQt ZW1haWwtYWwxaW1nQGdtYWlsLmNvbS8gDQo+IDxodHRwczovL2xvcmUua2VybmVsLm9yZy9h bGwvMTUwOTU0ODY4Ny02MDcxLTMtZ2l0LXNlbmQtZW1haWwtYWwxaW1nQGdtYWlsLmNvbS8+ DQo+IA0KPiBDYW4geW91IHBsZWFzZSBoZWxwIG1lIGxvY2F0ZSB0aGUgc291cmNlIGZpbGVz IGluIHRoaXMgcGF0Y2ggc2V0Pw0KDQpUaGUgY29kZSBoYXMgYmVlbiBtb3ZlZCB0byB0aGUg dG9vbHMvbGlicy9saWdodCBwYXRoIGluIHRoZSByZXBvc2l0b3J5Lg0KDQoNCkp1ZXJnZW4N Cg== --------------ZXyL7ffLc2GEZ6xFfWMy3PPV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ZXyL7ffLc2GEZ6xFfWMy3PPV-- --------------j0Ko3iSi32pB6cL71yCucoEM-- --------------SrQ0loUW4XEVAnDKBE5HaHN3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMbFaAFAwAAAAAACgkQsN6d1ii/Ey/P vQf/ToDzFiwUzX9HNm+AE8koO9uw8GA071wFHzRZtu+H2xNG3EZIEVC6lY0l1njCt7b5OAse+mWZ Md7Kmty7YKKNtZfIY6+SKnrO0PnIbtkF47zY5Wcd8ASAsilOF55TJpdM3foTxqsLDUwA6dgo7IDc pAXJ1QVdw1QZ8yV/UqnlPQeIKGljoqRmaPmZSBlHiXt10rAlbWEPBO1LrJp37VTA5KW+dfwoaK/b 2MXJ13JwTetOs4HCvWwXiHlfIhbiY12tJCQOjtCcTFWN4UcY/X73z0NtelvvfrWegGTzo8d8AFTV N5HN6pHKWIIZssxIAQC4Pbq4Wc6JXpbT/60UX2ZQ5Q== =s0y1 -----END PGP SIGNATURE----- --------------SrQ0loUW4XEVAnDKBE5HaHN3-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:33:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404170.646522 (Exim 4.92) (envelope-from ) id 1oWbK5-00055w-Lu; Fri, 09 Sep 2022 10:33:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404170.646522; Fri, 09 Sep 2022 10:33:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbK5-00055m-J6; Fri, 09 Sep 2022 10:33:21 +0000 Received: by outflank-mailman (input) for mailman id 404170; Fri, 09 Sep 2022 10:33:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbK3-00055e-H8 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:33:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d184da91-302a-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 12:33:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7734.eurprd04.prod.outlook.com (2603:10a6:20b:2a6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 10:33:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 10:33:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d184da91-302a-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2IFAEToincuQEUtTiLMqLNNxcHzE+V83V0IBMXf6ni0hXC4VXWArcvcXeD6wSQeADqvG90ncXeFnJw6rIJSLpmCoJCHKz4OoaJIDp3i3j8VghuTFMiykYgKWgoipIoJiPw+5vmBhjTVpUqkC3W45h66GAT1UWor5ITV9Qy8alWcVjZmzjsVvfSjJJMn6YyzKdCMtRup1/HAYmDEkBqIa6df2mdc9fNiZdXjB9L07ROMhmbZiKtPv6aYLoJPy27s48dJImDruLiuaMQ/E/xHeHH2vvfFZncgtZsYPDGd8ixJZwgt+n6qptgfYmbwDZHhx8U37UdUQZ8UkTduoZsZxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OahClhzLlKj9h06YDZhAqQ53tGmERBosoEPBQJdhwkM=; b=Vg4LtjlD9xJ9CaUBXZtlLzSDXOa8vJpGXx5chDFRs51KVk6i6LxMCdtTNC2cDTYkv0cYeiaIXviKGLkOsNbQGgc3qscTg5haUw9c+HsrPLw8YIR3EGnFKGkNYr4Cg9BU7mZXNTbhPs1AiUhbuMCcL+zD7SgPtX/G9+KN6XKeo9JsUe5iwmg9XzVn/3eFLNqyWySGthIRvjyecMli7inmydiWiK6AAhDdRuyss2OdmIG6zUghBNTul4NyvfZUGEECoPmfdUKVyz97cDYFaGcydr0G3dbieK9jgnymlyMzj7IZThODCtK+It2RU/R2Ew2zVjXSyDRPctoFUIBDmDGCNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OahClhzLlKj9h06YDZhAqQ53tGmERBosoEPBQJdhwkM=; b=QAPMOYHTCPrlLK36ku5HfaFvH0nO231xNqNZ+Gvp11rcbnSOlq9+htFtvg7zZtW/qoIGC2/H4X6m/cRbjDFAvptLKsRvtba2pG+6NPEC9uxR246DrAGTnGDqnx0WeikdGLzxIU/bO2ZvKdy3f/gR8HjA47x7vHsc5G6KscDsG5jUBpKeW6ms5+484Er1zezaRcKBzo9pNcFpcnBbi+0FjruHGXnbvs4LP9BBeByV7dTm1QpMExjj1+s1Km6eAtf/m36Q+WqX2M0wS1iIC97lOkhlrvgOWYmQlZFWMYelEihebj1/f2l2I8qTbfyQj4fkgt1GAzaWuYT1KZ+a81xkHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1a7486b8-0f16-0335-de6d-3b77ed2a15f2@suse.com> Date: Fri, 9 Sep 2022 12:33:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: libxl source code Content-Language: en-US To: "SHARMA, JYOTIRMOY" References: Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0506.eurprd06.prod.outlook.com (2603:10a6:20b:49b::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7734:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ceb578f-555c-4032-b863-08da924eb4a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Izc5pG8JcMqIXm+c7SFRALjffKPnZ0oMSrPowJraJSFZbKPiNBqHtjKC40GJpSpe+VK2qyYL0SBj1pHnW3aeSfOStPwk7L3X01Hqb93YymhWt0Nq5ZAMRMeicnrtUfuDl4pVGQU7MXDCk2z4hyiZ2F7Tcgu9tXNLWTIL/5WMdUcDuuhS1RU1SSwMbUS1HWXM3O0PqAzdq241AkLQDSHYnp0iZ/z+9Z6LOesQMNR3ex7XD1RiXtzIChUMEOg+PwaOLT/4u7ElO23JtdJXlE5jFz3oYVyx1lZUZDIephE6OS4BOdHys238T8GisHfFHklKFl7IQARC7Ega1gK+3fghu8Rccao0l76dY5RLwFAYM7l8NP1hjYWwmrn5ACOcqvDoxnf5xpLkxJQ8ueZfNgqo1Dp53S2W0T20Z5TjkTUPt+Dhg3NyygJ3TyVCF9IFX5E4BhasCT41DxeT7HvmGw9ZhqGeN/68CjJ80/Ju170GbsrldzRQL+ign+tEP/zJzH9uU1QksgsaNoJGg1iT1SG7qFKzg1v/HsR/YkShs7ITVQgjPJ0WtwsXpZzzUOafLoEjmJ54wQH6ivP8y5tedBeHHiIsNV/pv/C1Lg0H+R1bJ4o6wz7MmDxpzfAVnMbyPnGMfINvtRoItKGb44sun/fqkA4cAlyc/10RIqXpN/q9RH8LLDA34HYh89GKNDZ2+g+80LYYpDlZ3lVpDmbTcI4QOZPXcKMmd2otzfYH0AF/t/rXxlR2VssTsnacjU7svO194MZycnudS8bLXK/C1esacaIMRP17XfbUfGWrOeOW6lcb7onfdRMhafjDjeCWVsNTN3soLvCLu7px/YdUX4Nc7+NA4ELb6oz4LcTMVo1C2YvZNvb2wZaHFl5EybF01v9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(346002)(136003)(366004)(39860400002)(41300700001)(6512007)(26005)(2616005)(53546011)(6506007)(8676002)(8936002)(5660300002)(66556008)(4326008)(66476007)(7116003)(66946007)(2906002)(4744005)(186003)(478600001)(6486002)(6916009)(31686004)(86362001)(36756003)(38100700002)(316002)(966005)(3480700007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkEzcXpwN0RhaEtrTWttaWlyWDdEbkYzbTB4RFUzNytpVGYzTnptSzJtZEZX?= =?utf-8?B?VGhaTkJOcy9rSU5iWjFVKzFIZXlJdU1ZUm80UHZNWEhucjVHb3BXdkFzSkJ0?= =?utf-8?B?NHJ6ekhMUkJvcENlMGtWbEF0NlRTd3kwVlpMaEhPalJxWGJoQ1BSejBTL0V0?= =?utf-8?B?T2l3OC9hTEFmWTlVNkl4dzNMRGdXdWZQMlUvNTdpcVNNSGhWWFhUMDFIMVZV?= =?utf-8?B?NEROU0tPd0w1aHI4UDdEdEhGNnVoTkdSZEtua3g5ekdyWlpaOXNPL3ZuN1BE?= =?utf-8?B?SE1ZN0VVWWxYcnVoKy90RWcvM1JJSUhBWGkzTGNuQVM5VlFCRUlGdFlBMWYw?= =?utf-8?B?R0xPcFpkbmFzK24wS0t6aFhUM1Nhdm5wQURKbmcwWU9QS0trc2hEYnJVb1hW?= =?utf-8?B?SXJ1MkRTS2FXMHRYWHFDOWoxNEh0OGVSTmNhUU5lbU1WQkZUWGFqYTU3RlJW?= =?utf-8?B?bnN3aEwxcDQ5R2E3UTlwbnF0YWh0VjJaNFU5aXpORE81bHBZTml5a2pGTU5o?= =?utf-8?B?REtlQVZrRWEvNEJXUktEeWE1SnZCMm5yb2JlSW1Ba3Y3aHNuOGt3Q1BUZ2I5?= =?utf-8?B?ZS9lMTZuS29nM0VJbHg5RS9iUlljYWZVb2FObEtSUk9XVE5Ua0Y2UHdDdkp2?= =?utf-8?B?NjNDTEtkYnY2Q1V4WGNHMEhsdnd4b0o2Ym9rd3NMaVBtM3MzNm1aWGlnR2FH?= =?utf-8?B?WmhHRVZqc2RWb29ieVFLcGs3MXpoZXZXN3pNL2QvdGNxeG9PNkFrckMvNmd6?= =?utf-8?B?UWNmOHZxMlgyMDd6UVlFcnd2alZQeDRwM0xQYjg3Rk43MDdIOXhWYXRPUVVp?= =?utf-8?B?aUtCejc3VTVkRGJmQ2JoWTZWZDJiRmlxVno5UWZWam4yaFlHNWtEck1wamh0?= =?utf-8?B?NG1rV1ZXcEdBOVp4eWcyY0VhREY5M29UMXVaUk12TVhxeDNiak5zeVVVSlRi?= =?utf-8?B?dE1NWld1RFN4cEdpeUNxcTdMa0F3a25KZVlxallGcmpwTzlHTGJ5VjRZTEQ4?= =?utf-8?B?eXNPQkpRajRRZnNaN3p2eXdOVnNDZlBLcFZ4enBOWkxIaXFFeWZNZE56U2Ew?= =?utf-8?B?MU8yVFl1THY5bGNEbDhCcS9icCtOYVF4bDRtMkswV1NWQ1d6YXdnc0RnNVk0?= =?utf-8?B?VGhjVEMvaElJVXhGVVVYSkNsSVF6NWtocmMwdUpmc1k0bE1CMHJLU3FWazFw?= =?utf-8?B?YjRpMGhmNjNkQ3MzcjM3VUYwczdiaWdwdW85TVg5cHhJNzZYVTdHZW5rSldC?= =?utf-8?B?NHViUm9YUWo3R2tNbEpJUVRaaGdmZmZMbHB1M1JLVm1oTjBpc3BySlU2R0ky?= =?utf-8?B?b2xLWVVwRjlHZ1NjZEJ4Vi9BL0ZWQiszZjBYdmh4RjdkUDd2bk52ek4xcGhY?= =?utf-8?B?ODVreHQ0ZGZocmRYUGVJUVgzREswNkVHWVdDd3Y4VjRlTjROYThYT3F0UC9W?= =?utf-8?B?WkxwM1pHNWFUMUFvVlJKenlwNmVFMGg3MGU2NTNKT1NaNWxWOWtIZC8yd1Ev?= =?utf-8?B?QUpXMVByQkx1WndlaGg1bHd1Sml0alVLSVBwZU56c1NpWk42d05KNGJ1eUtn?= =?utf-8?B?djhsTjMvYVAyazZaM3VVVEhycTVzRWs2UDF0T051alFpR3RFZm1ZTmxYUGpT?= =?utf-8?B?dnZkRDg2bitLUkRLUldmQ0JBOHFRbFBUWW44QzBiWHV3U1hDZUgyN2pqMVVK?= =?utf-8?B?TlJHSzBod0JLSVplczFxZkVkOVJUTUM0TkMzQ3hHeXI2UlUrQXh6QVZRZjhN?= =?utf-8?B?ZkpBbk5tNmNROGJwU1BZVW94N21XY3BSZHNCQzUxbzN1RXYrR2ljWXlkdHlW?= =?utf-8?B?YlhjTERwa2VIY2hpSW9NTkpLSFhYcWJUbWZuZG5pOC8zQld0NkZPc2dNU0pu?= =?utf-8?B?WnNaSS83Qm5taGZzUUp2dDczb2JidDBmZXA0WEc5Mk9UdWxaN3J6UFpoZmpR?= =?utf-8?B?MmtKeHR6Y2RiUmNLZXZyczd2cXFxM2hvaXk5ajFseFh6TGp0S2dVUHNZaUVY?= =?utf-8?B?Z0NzTXkyR20rM0NHTUgrUkZ5bnV2dFZPb0UrU1U0cEtIaWwrRGdFWXd2R1Rl?= =?utf-8?B?eXplRURsU3RnRUtVbDdsa0ZXbGtkeWdGa09paEl5R0pOSXU3dTVDSUR1MWxZ?= =?utf-8?Q?rH4tgHJFkszW+lXP7iJ/kZ1Mx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ceb578f-555c-4032-b863-08da924eb4a1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 10:33:16.3354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z7mfuPjrqD4H6sSL4kJcvN1Kon4pq/TsGWF6CGEoYho8f3k7M1NMymwbLdSgDcczgEn4B26nJ4TjEQY/S2z2gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7734 On 09.09.2022 12:24, SHARMA, JYOTIRMOY wrote: > [AMD Official Use Only - General] > > Adding xen devel Please don't cross-post. > Regards, > Jyotirmoy > > From: SHARMA, JYOTIRMOY > Sent: Friday, September 9, 2022 3:52 PM > To: 'xen-users@lists.xenproject.org' > Subject: libxl source code > > > [AMD Official Use Only - General] > > Hello, > > I am looking for the libxl source code to understand how vsnd (PV audio driver) has been implemented. > However, if I look into the xen source tree (https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=tools;h=9b2efe082223bbf60b41e947ceb4821e98708c02;hb=refs/heads/stable-4.16), > I do not see libxl folder. > > Specifically I am looking for the code which is present in the following patch set: > > https://lore.kernel.org/all/1509548687-6071-3-git-send-email-al1img@gmail.com/ > > Can you please help me locate the source files in this patch set? The tree has since been re-organized - see tools/libs/light/. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:35:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:35:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404177.646534 (Exim 4.92) (envelope-from ) id 1oWbLg-0005fI-2J; Fri, 09 Sep 2022 10:35:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404177.646534; Fri, 09 Sep 2022 10:35:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbLf-0005fB-UZ; Fri, 09 Sep 2022 10:34:59 +0000 Received: by outflank-mailman (input) for mailman id 404177; Fri, 09 Sep 2022 10:34:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbLe-0005ex-V5 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:34:59 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cca6016-302b-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 12:34:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7734.eurprd04.prod.outlook.com (2603:10a6:20b:2a6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 10:34:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 10:34:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cca6016-302b-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eIGUGHXKfKxT12bzTdxcNL7AfO23OcwG3qWqbAKPw20lktgKM11Ac4gzJu5IvqD5uIwdB7jDVihkP/ksdbCGiKiYf69GOw+yyutfZiFxXRMj046aUZ/THpMXVSHUNwIjpBbyQrNDYYzbn3zv3EF844/k1EdlwtcFT3OrDUVPO8YVKzYcvNBqOzX9//n2j7NjnPV7Vc/y/SqbVJHzK/XxpACxTZbGZDf5RVdo2EvtsWyJzya+W4XMg2kv+FObj1eLIEJd7MxBJ2kWslU5yZoRcCHq6b7Y5TEUcmm/x5SiTGi/yiHwUzhdvS28dgHZUdhTLngV6WJMf9YCVoeRnyf+iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W522B65Ql8ge1yXQa0g03EnCK5GQLmyF2y9BK1asyac=; b=YVLe5YNATbbgE5tzvkH4sJINiS7bkmbzrR5Or13iCyDYI2VhdahqTxTPCkmWkOVWgYNbuWZKHE4h1HnwMJDFlrF1JDDVtuvo+y0NIlKzACCCmVqnUakMCVpSJFvgsEhLK++94Bw0vfXkbINxLfn+1dtGeHp1GhYViY+xvsigg1/qDJJRxq62yiX8fNS9zMyr5gqYaLmrqDIMR0/+bmgyjxGITjICuEnTok/LoA448ug5i1+uGko5vil/cLFM+I5DA7y1v9QAtlV2GkDBA6piof6sgAhHjXnr8sP/NHlQUl7dHtqyVFIBj7Zx5u5CngZJQd0m/orl+PycD0d2JZcpUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W522B65Ql8ge1yXQa0g03EnCK5GQLmyF2y9BK1asyac=; b=0lRlWbQ24BmGJEKmDw68nZUHKMXsdZCqYJ9PgHA7L4NreUOeqQKc+de6KlIcrHP7R0NIuR7iOg72o8BglR7KnYwe545ePHkQ/StqovwuOiiCyC85K0lCzMSHyWZXFM2c7kAYc/98dGff12hZdJOXryMwKKAUVw0uVS4eQy5WFWeTPPaA6vtYi1De9IrfcBNptLWXOtTavdl5aGw7edTIoWcg3bZEmgbs6Nzx2b/Cuc4qraC4kG7PzN106wYlkxh+OTIuy6QYZPHy5YE743JIUBhIliejUBlvEEaIh6ukI3+TPGeYcez1aQeorfimUXLyKZc/FinLxy+a/eg8oqvAMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4f35cbcf-15b1-19d7-5cf9-22c71392a40d@suse.com> Date: Fri, 9 Sep 2022 12:34:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Juergen Gross Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220909102413.2899-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220909102413.2899-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0602CA0007.eurprd06.prod.outlook.com (2603:10a6:203:a3::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7734:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cae6dda-1a22-4e0b-3332-08da924ef01a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Se1MC+xTUmGNl2TdyCBSOhMTK7zsxj3dup6+GtPiR5kmaZbu5CZDhLn/ZNu8lVQ3GrMLjqrKN9p6lBQtq9uM/iYUy7WVg5tTyEfQDsOOwX9hPnCUjW2LIabnAxokxkRmEwiZwkMvleEY8L4qm0zcqoja+3n36uvvTDZeyJw5LmA/tl/Ujv/ZS+bGAwmhrPpGHOf4bX42aYzuHS/71vLXywXDlq2hVoP2ZGTp+JNeQUvYPofW+wL51JkHeCoLo4SO6ATqEwbtS2CYBgPmphd4mCls5qKt2ky6QiPfNCtCWu7iPC7oA6EwlpQEwYcDkvbMch37ZkD9m3iqvvJ5GDTSiZgvDKL6IvBiapPiIXYJDMCxBmIhuThgIvAZ2Pxd2ch7AT2LhzZjxG/fLd4IfEYNK1b+5gnZfcQt0HflEA4iFdsySXcGGZd6gOnDC6av46EHYvKWMzFW23I/PqCbrwzfNDcBAjA0CLnKyjJdkGvQPMAMpMYkK7wpCerKp+1c33NtCPBqLMQL8z9n4t5XKu3aF8AF0BmkhbZJuCHoB48hI2VWQ8WxTsZ5kYj1F2U39s1LncLrBSSnnZ6pkp0Dx+jDcKRzy2KamwNoPpEk2SRurp3Vid5qMNrEuTuwfpuVQvWhurfXoyJgdOVVTCDdizoL7M7KJk2QrUWF4RvAD+QwQFs5IfNBCb1Sb/GfhcwraRM+LW3pxlJJDf13Bn5oVDMLqreLYrMPm257n6DpXFeGNRViSI5qukwBLQPy//XG6sZyyaRMl95B3W26h+k3Bal5zV8Hz3NPsSjHWeeMRWM7TxI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(346002)(136003)(366004)(39860400002)(41300700001)(6512007)(26005)(2616005)(53546011)(6506007)(83380400001)(8676002)(8936002)(5660300002)(6862004)(66556008)(4326008)(66476007)(66946007)(2906002)(4744005)(186003)(478600001)(6486002)(6636002)(54906003)(37006003)(31686004)(86362001)(36756003)(38100700002)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1dlYTJ5QnNYak9QNmhRV3lvS25pV1dnTEdlQ1NRUEhGZ1dOa2JKM21oOUJY?= =?utf-8?B?YzNCQVZSTnVoRHBNTG1aOG12aU9NbHdZbEgwa2ltQ0o5YzdESWhhazJsY1hW?= =?utf-8?B?M0tINFo3K3F4cFh6bWdVVDdVWk4xWk9mY29acVRmK0FTbnFFZElIL3dCSDM3?= =?utf-8?B?VWZiaFhmTTNPZlJ3UWdWbnA0VkpYWU1qT0VlaHdycnp1ckJmMTBXeHZyYktt?= =?utf-8?B?Y2J6ODcwVVFHVFRIT1BheVZJMUdtYnZuUnNNdWV4UWQxV2oyTFdLQmV0Ymtp?= =?utf-8?B?UUk3RWYzd0lMWWhxMm5iKzBaL3M2TFFFWEtsc0ozUE5uSmxBZUJkOFdmeVJy?= =?utf-8?B?RXhZVXhjOVJudGZ0dUw4WlM0ZXl3Vms5R1M4SW9JR01HWUdZcTNndG9BWmNQ?= =?utf-8?B?QWlpdDlydThJdmdtY1VYMGFHbmFLVFdZSnQ3MGFKZmNCLzZtWGtKNzV0S1lQ?= =?utf-8?B?WlJVYTBEbWxQUUNaRkNkSFBTMTB3T21ocTQ4UTBDamROZUppMkRyRCtwRWU4?= =?utf-8?B?VkhnNFd5OXZueURydHI5ZkljZDBFNnNTVWpYMUJFdTcrQjdvMFhhOUhqUmZR?= =?utf-8?B?enNWd1BzaThGK3k2U3Z2NHB4Z0p1VjJVWk0zY042M3B5a2FEZlM2S0Y5TFNN?= =?utf-8?B?a1dVUU9DODlsYlU4alNJbHBENERZVDFxOXVvcm9tZnZXMEN6eU55bXN3VDNy?= =?utf-8?B?Ung4a3dkOGRLSE05RmgwcW1uSitOOGwyNzVzZnpNMEpTK2JrNHNmRHZ2VjNs?= =?utf-8?B?SlRHMCtaYzgyQkFRamx6MWt6SWpEcnQ1NW0xRFd1UDF3QXBTTExHREg4Szds?= =?utf-8?B?TWd6dmRJYisyT2U0Z21tRWduSDdqSm5zK2lMbkIwRzNPaDhseHQ1blVSYlFr?= =?utf-8?B?NFRkd1VlbExucHhJN2Nha2RyTE1DRWdlbWdQbkJPckF0bUpLV0dpOVU4bWZj?= =?utf-8?B?Tm9mbjhDUUE1RFh2Y0hOUEk0WnJEeGRqRysxUDZmcEhOWlE3TEwyTmpqNGdn?= =?utf-8?B?aXFOdjcxSFIwQVRUOXIxQXZ6Uy9veUpmRVNqNTJEbnFuUlhmK205TGVyY0RM?= =?utf-8?B?dWFsaXFoK3VmTnMrQUdOakFTSU5LaXdIU3R6SThqaXVRSDl0TFhIclNtZ2ZO?= =?utf-8?B?Ry9aMUNXUUp6TUdkUzdqOEt5ekxFVEVUcFNtWGM1SVpSdnlQN1lWajJnQzU0?= =?utf-8?B?SnJNR1RmdGl1WlJQdXRVbGJyTE1Ga2pWeDlKVkNqZUtTdGM3RzEzQWFJQU1G?= =?utf-8?B?ZnlPRzNLR05SajVyRkhQcStiVjJYRnh2NW1PMWpMRXo5Qk1aUkVYaVU5akp3?= =?utf-8?B?cEd4S0VGMytleGtVVkszazA1MXp3UDFSbUc4Vmo2bERKajBHUXZXYzZFenVQ?= =?utf-8?B?a3JxNEY3MnZBOHRqd2dJSVEvRGZtdTZxMG1TbFRLb1phS21tNmlLUXNhY2M2?= =?utf-8?B?RkE2WExmZkh2TXVSekI3L2tFT1Y0eTc3ZEFSZ2VEVmtYZWd0YTl6c2o2SHIw?= =?utf-8?B?cUNDQmsvZjRWUENHcjZZTllza1RjTmpMdXE3Q3B1b3ZIY3FTRENlOVN2OWlB?= =?utf-8?B?ZEVUSWdtcG9kb0h0QlJzenkwR0E0NnlLMDRmRFRUcU9uQTBIeW9WRm9KVWVn?= =?utf-8?B?OUU0K1E5d25LYmNGRSswVjA1aVA1ZzBTalRzUmc3c1RsZEF6bzJzQWhYNVpT?= =?utf-8?B?c2x6S0RLNG0yb3BvalovVlBGbk9GRFR0UUhCM2sxcUZNMnA5VzVYbXAzd2tD?= =?utf-8?B?QmJLaXlCOFl4RHRZK1JYV1JHQmZjS09pYk9jWU5LRjB4azJuVzZZV2NpbGhM?= =?utf-8?B?Zjd1NFgrajFTWXJrUDVGMVQ4TThGQzM1S2VORzhRKzRHSk9sMkFiS3laVm0w?= =?utf-8?B?ZXVKQy9UOXVIOGUwSFQyT3BBMUxVbzhObFdueS92Szh1SWJSRllsQ0NqeHRQ?= =?utf-8?B?SEExSkRxMytUdUwzakF1ckR3UU94Z3hVcWRaOGV1Y0F3d25zSkh4K0tkRUxx?= =?utf-8?B?bEEydU5oMTdGcGsvOXlZcjV0Y0xhRWVFT0tGUzNOSW1yeVdCL3FVUURFZjdD?= =?utf-8?B?c1BCZklnZGg1RDVVWm5CZVFwVVBENExwL3pFc1FYQUtSK1pvS3FKUUZMa1J6?= =?utf-8?Q?3KJP8GPGMl1FYIHfGZUBL+5Ik?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cae6dda-1a22-4e0b-3332-08da924ef01a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 10:34:56.0793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lH3JXyh+rUzrozpmIu/RxvZhA+BPgf7Tn709kYWJ+6wE76j2ZKb1/qcyDUGaD5ScCC6IYHAODQdk4zMhJnWw5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7734 On 09.09.2022 12:24, Juergen Gross wrote: > Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" > warning") was wrong, as vaddrs can legitimately be NULL in case > XENMEM_resource_grant_table_id_status was specified for a grant table > v1. This would result in crashes in debug builds due to > ASSERT_UNREACHABLE() triggering. > > Check vaddrs only to be NULL in the rc == 0 case. > > Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") > Signed-off-by: Juergen Gross > Release-acked-by: Henry Wang Reviewed-by: Jan Beulich > --- > Might be considered for backporting Sure. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:41:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404184.646545 (Exim 4.92) (envelope-from ) id 1oWbRi-0007St-Oa; Fri, 09 Sep 2022 10:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404184.646545; Fri, 09 Sep 2022 10:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbRi-0007Sm-Jn; Fri, 09 Sep 2022 10:41:14 +0000 Received: by outflank-mailman (input) for mailman id 404184; Fri, 09 Sep 2022 10:41:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbRh-0007Sg-8a for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:41:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea56f99b-302b-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 12:41:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea56f99b-302b-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662720070; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Q99TtwwivTeANDgHsIWDOW/0lDXgSaGmCYl/tUxMWFc=; b=UC1Ve2uH17Iw54hJfF+YGmOBW0EJNENVGz7EeYwQgkcQMqI6YpTe3Xza 7CgIDY5wu5Ql3jhblEQQdecGAlULT/tGfu+eSxKIRaP5AdaTKdkRtufvc 7TXMkVchNhJulWTkPu0EF+0mwt6WzKF+NiPwsgZb+Xn3A2jCNc1gZTxld w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80135663 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:RwWnCq2Rt4k6xAvxt/bD5dhxkn2cJEfYwER7XKvMYLTBsI5bpzwEz 2QbWm3UafuIZmKmfo8jaYu290hX6sTcmoBqTFNrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8EI35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/dLJ0gMGY4ywc1MDm4Q6 fAbLncrQTnW0opawJrjIgVtrsEqLc2tN4IDoHBwizreCJ7KQ7iaHf+Mv4UBmm5t2IYeRp4yZ OJAAdZrRB3Gfx1IPEZREJ8klf2krnL+bydZuBSeoq9fD237nFQoi+WzboG9ltqiGIJLhEmem Hv89EvTGC4zM4STxD2b7Sf57gPItXyiA99DfFGizdZwh0aZ3GsUCxs+Wl6yoP3/gUm7M/pdJ FYT4TEGtrUp+QqgSdyVdwK8iG6JuFgbQdU4O+8z7g2X27fXywmcD2kACDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRVLufgddE1FDuYO65thu0FSfFb6PDZJZkPX3PBr5+ RSJhhMVvLoc09IH1KP823/u1mfESofycuIl2unGdjv7sFknP9f+O9PABUvztqgZctvAJrWVl D1dwpXFsrhTZX2YvHbVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX KMwkVkLjHOrFCH2BZKbmqroYyjQ8YDuFM7+StffZcdUb556eWevpX8wPxDOhTmyyhFxzsnT3 Kt3lu71VR4n5VlPlmLqF4/xL5dwrszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzUwzN14vd+V29z jqqH5HVo/mpeLGhP3K/HE96BQxiEEXX8rit85ULKrbaeFM8cIzjYteIqY4cl0Vet/w9vo/1E ruVAye0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:iAJr+KnWtTv3yEls1i9waBsga2HpDfIs3DAbv31ZSRFFG/Fxl6 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyXMbEQt6fHCWeDfOod/A== X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="80135663" Date: Fri, 9 Sep 2022 11:40:59 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" Subject: Re: [PATCH v2 3/3] xl/libxl: Add OEM string support to smbios Message-ID: References: <20220908195113.218201-1-jandryuk@gmail.com> <20220908195113.218201-4-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220908195113.218201-4-jandryuk@gmail.com> On Thu, Sep 08, 2022 at 03:51:13PM -0400, Jason Andryuk wrote: > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index c3125ed310..0b01e09632 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -773,8 +774,18 @@ static int hvm_build_set_xs_values(libxl__gc *gc, > > for (int i = 0; i < info->u.hvm.num_smbios; i++) { > char *p; > - path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, > - libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); > + if (info->u.hvm.smbios[i].key == LIBXL_SMBIOS_TYPE_OEM) { > + if (num_oem > 99) { > + ret = ERROR_INVAL; We probably want to log an error message here, to explain why libxl returns an error. > + goto err; > + } > + path = GCSPRINTF("/local/domain/%d/"HVM_XS_OEM_STRINGS, domid, > + num_oem); > + num_oem++; > + } else { > + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, > + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); > + } > > /* Convert libxl_smbios_type string to xenstore path that hvmloader > will use, as defined by HVM_XS_*. That is convert the '_' to '-'. */ > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 5413c36645..d0f8a14827 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1823,6 +1826,15 @@ void parse_config_data(const char *config_source, > } > free(option); > > + if (v == LIBXL_SMBIOS_TYPE_OEM) { > + if (num_oem > 99) { > + fprintf(stderr, > + "xl: smbios limited to 99 oem strings\n"); > + exit(-ERROR_FAIL); Could you change the exit value to be EXIT_FAILURE instead, like in the other patch? (ERROR_FAIL is meant to be an libxl return value and it somehow spread to xl.) Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:46:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:46:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404192.646555 (Exim 4.92) (envelope-from ) id 1oWbWa-00086O-95; Fri, 09 Sep 2022 10:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404192.646555; Fri, 09 Sep 2022 10:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbWa-00086H-60; Fri, 09 Sep 2022 10:46:16 +0000 Received: by outflank-mailman (input) for mailman id 404192; Fri, 09 Sep 2022 10:46:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbWY-000869-Fp for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 10:46:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9adde0c6-302c-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 12:46:07 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Sep 2022 06:46:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5600.namprd03.prod.outlook.com (2603:10b6:a03:286::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Fri, 9 Sep 2022 10:46:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::b9c9:c866:817c:60dd%4]) with mapi id 15.20.5588.018; Fri, 9 Sep 2022 10:46:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9adde0c6-302c-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662720372; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=DYrE1nb6fk5jHVLSg2xhtonnA9yBZYcqfJ8yFKNw9Ek=; b=aVyXOBXg8BM/LPQE9kFGGNLicyMGO4bjIdNGJ1w+q0G7XyUEWuHwjcTB iwbq3BUBuuFyMDLWE/quEBOWxXLWdLhkv0Q7BBjjW0cXfW8uxtAjAX1fR SizW+2IaRaAtOD7dOz4lQDsDzDd22lf0zdMRVt611Cdw9/cPtmaicBLlR g=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 80144265 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AtdSCgq2NPASeR9hTW/bDix16xQzdPnBdZeh5C?= =?us-ascii?q?dk8DyJ0RKdqp4UqVsiFrcC7hKRYaaMhCUtREvUMlFY3nif4BQ2kcNDFGsSon?= =?us-ascii?q?BV56PUIyOpaiRZF/w5qMoi8mrW/OcrKMANG6T6voiBBVaVMI/Jdi8sqsVoZd?= =?us-ascii?q?RYXi3TWQ/lyPxTTL0Zgwis53Ai24S/iucgzRmCBzS++g/F8PPYJ8o+6YR/qM?= =?us-ascii?q?HBbKleSOxlNATleXwvvFW5yzF6bJNi05YKGj0ZRS+9Uxxzy3Z7oQgX90s6u0?= =?us-ascii?q?yn4Na7uDn8kJSnu1bbiTKAWbagoSLSgFL7yyUMFgIj6wSuBDmJ9kplUJ50aF?= =?us-ascii?q?TUABfKuma6u5MqEP+4eslrZ7yMYpOx7znNEvAHZ44ZAGcXpasdulD0/MUS4N?= =?us-ascii?q?OufdKX0raxiRrgLrpHfZIfORoIqiz1T/WfpapQn+57mnWA1xhxZayG52JqaY?= =?us-ascii?q?crymTQfcSzIwnF5O+MymSWxjUm/77XLaKREX4hiwxPPxyBGnJT1Z+IBbskA6?= =?us-ascii?q?2kEr6q72cBb4wZkqoUnL1c72eGBCOdAk076b9xzJcsvIjbZpNPn18WOdjltu?= =?us-ascii?q?8SsEtCeyigLdkLNrzLJ4azRIb71b6N2AEiQbOQgGdjpHXroRRCg4OiWRSgZs?= =?us-ascii?q?FKvA425sYWrYAqXOlX7P0xNpa/yydBTNAmIUCd3HLBFMS5gV/vJPwdDA+SUj?= =?us-ascii?q?niFa+gLTDdQdOFUfnz4XWSuW7GsR98T82r6WuyG834It15Q9353I263EJHw1?= =?us-ascii?q?pCfUJIQ/bacYAAruGrsVwq8yVHpKEvA8GPN5kp6fyjCNzrHjqNRG7TwAbL4o?= =?us-ascii?q?ZsdHe53CFFC76o2DkdUeuXSDpyFpSlbechuVk09Yg7NRengMBG4QdSbqyYM8?= =?us-ascii?q?rpgbj0SU7dA6rFEsSRE1XmJM1KOKvZV3dZLjoHnW+CUXt30+UnArmZcMRoRj?= =?us-ascii?q?k13JckZjsdZIekfNyw/gDwJXc9I2jA0iz5R1PCnz2kXYdt5BHCrGKBFvlywH?= =?us-ascii?q?mKOeLaAe6QdzDiuZIS1dnUzAvNmwwbPCnMb0Zlpl8tuhkDy5Fh97/0HUtATf?= =?us-ascii?q?bMB6B0iIhVZhA7orux6gS5ydxcHPsSB8bx6fN8PSP7rx71G/eacuurvCV25X?= =?us-ascii?q?7GiwJB2VejmdXvjRcwPscq53JFSxyabzFBosT3SwoUc4t4slEnOHxZxnZmhW?= =?us-ascii?q?hepbBMv67U09H+Pia+/6N/Yxf00hpImuB4gwQYguVrEtIRYIjlSgP77YLj8X?= =?us-ascii?q?HYf8zMOXsmQxd8WXbmCLTZqDfwUcByy7lWP0lrh93jSSCnYv7S1OxO5S/leE?= =?us-ascii?q?n2aWV5nALW2m9AFyQQ+LDeWuOaLZjQyAdXm7fkDd0Nck0FzjOw/Nog+9hFFO?= =?us-ascii?q?7Ro6BhIJpL+KacEDP29L4DuGlq/jHI5eFLmY4vSH/HfUdFWcbzNx1DDOlCM4?= =?us-ascii?q?HhNsutU29kqH/QfKm5vhNQ3Zd8/eTtfodutc+bsbZHpihPbMmOm7FQSsyhTg?= =?us-ascii?q?QrwpV/OWECMi41f/8M2K035jQohM2oiL5DgYj2R35IV5MKaAl6qqvNg7zJZL?= =?us-ascii?q?bg1F7Q2/RqitYT+GetOrKIxq1oTGcDGENkINTz6Qw2uWTHpW+mhTO8HpugRc?= =?us-ascii?q?Uxw6CnxKGgM8H4gvcD1aqso4zhRRbyIcstcHx+zD5YzuF3kYI1bwY6lmW+vf?= =?us-ascii?q?P5WqN1WUFgXFyidhiL5cZeEeU9sHxyjQCE2wJFS0kiQDZI+RO5M4pfDKIwix?= =?us-ascii?q?7Egb2LqCV+LKPy0ji3J4wgBc85+jK/O23mq+5b5BTp0WwhaAQl2aymNsbRG6?= =?us-ascii?q?j+8Ggbhz75ZsbF4Y0lgAFV1EoHDdXyEwRtEItS1cAfKAALSqwjjVktn/zb6y?= =?us-ascii?q?pXT+kMzv+DeI1ZS6ddZU6nspLqqIWOMzOpdrAmpX9vEB6+jhAtWRYg2krQK0?= =?us-ascii?q?l6JxpoQdP/ooycuf/eY924SEXTrb5x5OFBWPacD0/4bIiOu4TcyAKDCBTE4V?= =?us-ascii?q?giQojX4fOPdIl4oqpMGKrF9b1VJz6B8XESpT/2oe5fa4vYlkmmqY+beTVC0L?= =?us-ascii?q?oIX4euubv6Q8SioQyX2z3KIAUQTYFYaZ9XTVR8XzeDottXObbp/E7Yku0JwV?= =?us-ascii?q?h1xal98LgtrHL4D8C4nMQyV3VtDtpl2JwRjW9wWI7PCRWahF65O4IIQb6O65?= =?us-ascii?q?n+ociMwL6ngzD8Xri8NJakGQREI4HkuuG4P2Xdat1FhN/xPhrigBHmFlg2NJ?= =?us-ascii?q?siLsNjzgzQL9U8SVx318aon6jmyhPh3vhl8ltstQw26jdl5FcMDG4yuj09aT?= =?us-ascii?q?++IuGkFW1VlQ559nwLOjgFnIkKq4VPghwAc4ff9yohybASWAQfsuTMTNdl8V?= =?us-ascii?q?L0xZYjmQx4fuURq5d4RF31+1kyu3RylBufTiuMZDlI4WaGt3FK+RL0cYcG/a?= =?us-ascii?q?gdnAUCpun5ffWJL+A9qIQgMEXgn6VDY8r+tweGwU8DwChD5RKFZtmJodlWlD?= =?us-ascii?q?xXy6XVTiMED+mwBYdDVj7UZTWOFOtdBeQ8Us/m5yT/wUwbEwDm9X3xWPWphL?= =?us-ascii?q?173mnNsPWpJoC09JWrGuLfpFI1MARl3z2/FjZf7JBk27w7vOOnmB6l3x3GD/?= =?us-ascii?q?R2oZI3kpyUtBenBwyqjN+wMj9gHLM+hTVqrcUi/ES8HlqpZhdO8EocFE0NR3?= =?us-ascii?q?+3z?= X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="80144265" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJCM/kIYBQkQDbgyUalGDwANuElqaQvPOq00RXUeS0VlkDcgLuCfL1Y9y0ll1uBQJb9B83aWL6csXP4ACx3aEp61hwAXwhFNXYAQxe5AIevBgqzTxpudo11c5fv8iT2td/yaXCD/1Y2WgcIAbYSIinHf5+ZSPJe0NOz/Rgl/GRCmQQBdxOkrldzMRhHzeb1c/UysjNo3zCx//3X/pr6XnacRfxxBekbMWIc+Da2veEYZYZaYIKRZEQJvRMgDHPjZZe6lwBXb6tchMMzutVFwUAk40nsdvQntX54VAneS6c6rIuf2TDPH+N7IU/qliQWK0/psjIpT9mLLjETseTopwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DYrE1nb6fk5jHVLSg2xhtonnA9yBZYcqfJ8yFKNw9Ek=; b=Vxp7+Wsp2PsnkbTSt4YFcVQ93zqcoZKRSCtDQbJEx/XEn2KPx4mVF0kgV/wWLxnyZXT6RqfJCCnBU4cwKa6FsRZldcdGBe5B3Yl5Xt/cGEoaiIVvNVbrzWnVuyyOw+5lKUGiX6YiRNXGVbES9zQoqsVvGG2ai2vMef97yUFtWGfgcfKyy7/4DocQGTrwXFVN972zpSyqov0PqUgZE3RZzrjEWw5ad+1/eBL+o0cp+EmVBwtY9B2OQKJdIhcpI8ijIP0HiETs/ODOCD3SZsemZgP0wtnttHP3PG9mkPJ+HsoJI42yFOETshut2e5F0jUEQvoL0F9Z8uinVJyrlWXQ8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DYrE1nb6fk5jHVLSg2xhtonnA9yBZYcqfJ8yFKNw9Ek=; b=LC1zXC/vH8ehTR0n4wieJ1VEv4JShGCXX/DllCmgnDvywufC2mW3RkSG1uoBamuOr4vkoAPf4xiifdt8nO4JIMJXCdkKuivosn5RMy7FHgxv+cTM0Rl1FujbmJ0T9cjHFewwQ2Uo7KExY9wgdM7L7BJK+ZR23bkLzSonL7IGcoo= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] xen/gnttab: fix gnttab_acquire_resource() Thread-Topic: [PATCH v2] xen/gnttab: fix gnttab_acquire_resource() Thread-Index: AQHYxDZS8Zh+WxIH60KiKJYdabVOnK3W6k6A Date: Fri, 9 Sep 2022 10:46:07 +0000 Message-ID: <18808fb3-a3dd-59d1-0fd0-66215c039e68@citrix.com> References: <20220909102413.2899-1-jgross@suse.com> In-Reply-To: <20220909102413.2899-1-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9bc0d9ac-a79f-444d-766d-08da92508055 x-ms-traffictypediagnostic: SJ0PR03MB5600:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l3ushNNWfB3kPDspM0h7YC/JqI/79+nvwToycjxMZLmQunjV2IRuT0ELZcA2vlt7qePWZWkon8w7tGaoiSX1C/BFpMqR6icmNUV/fZlHtAGtiWOqtndvHN/yG0UMJZNBM0tOEtajY0C+EUGSzM8byXPGuuzoIpViUl/9yd7ZDHihciYcGYVowqu7MobIEGK0Uj9SC/BteHYZhdiW+3100kzrpgbOj0+ZLZpow/CLRvbHwa81A1VHMx/HQPSd5wSG6VZiXrKUBzYxjHHt30ngb9yAlSqFvplsCGxsArS5AMS10Lu++2L1qQKYhTAAlF1dr0KznNFUiu4o5Mo95EgBmuEq6sMGe1KQX+sWymlyeFtDRa7d4oT8ic84FUbQEYHrB6aZPFXmDhxiQEl/HvCX0qCVRciIkXXrX6uzg9eI9J+kUlQZf9i8xD5aS90JSYHs8krNszp/blJlmZM6sfEwKieEDFDs6xJGZAK6YAoLhlXqDIUI0jKzMF4xS32f4EpIxgZIpFeottdqV3ibGDBikx5yuQivfcMK69czeiX9Yjxl/2EuW8I268nnupkRoRF+iv+7TbWJaPRsxgvWufEnrcz60wa5oRC3wzMCvqlkJvz6tJKLGEwd5B2BOdZv2MYe/ru3m77XUtSTPqexg7jkgcIIDe/BTSp2rmC3Qoj3FWfyrqSjUh314z0S761q6mG0/PYxcXvCXQ1KOUXaZW9teCSHofo02RHAISg8abNdvPmKofXnUjEn+vR8C+26k/56YlgnPS3wEaYp9FNN2ZADANGMZ/OzcIX7I1KXmiRLjsuBLhCwGOO0OpiuxIIBW0pM56eHwhQM5euGZ/ddEfetHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(376002)(396003)(136003)(346002)(38100700002)(36756003)(5660300002)(122000001)(2616005)(83380400001)(186003)(110136005)(316002)(8936002)(54906003)(2906002)(8676002)(31686004)(76116006)(66946007)(4326008)(91956017)(66446008)(64756008)(66556008)(66476007)(31696002)(86362001)(38070700005)(6506007)(53546011)(6512007)(26005)(71200400001)(82960400001)(41300700001)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dmV2QTZkaU96SUp4Sm4vTEZ0MzhjRG16M0J6bzdBUGdQcE5oUGFjQmU2NHJ3?= =?utf-8?B?ekFMeFZQRVN3TUhhWVRKb2tVMzRCZUJGRXRxNElaaEZaV0J3b3dhS09Yc2VG?= =?utf-8?B?R2J4bXlBQ2ZXZ1VZdzlKdnp3WDU3akZVNHhPYitMd25hRTlnVDRERW9ORkNF?= =?utf-8?B?c3p6N25Iei90YVdITkk2R1R3bm5KNzZjS0RtbmkvN0hxZ0EvbDllUTFGN1B5?= =?utf-8?B?WUhvRDRWdWRLMHFOQllGRGV3OTM3S0wyckJzRmxRMnMvTDMzWGlMaXVkYXBM?= =?utf-8?B?MVdndVhUbTlFVktQMUErdHA1bXF1UDIrcm44V3FpTWFGOFhDdHZKSDYxa2xR?= =?utf-8?B?ZE00ZzRUZHRSWkVTbHNQbitWODdVRytUbE1zNVRoUHhjalIyOUhaaUZXVms1?= =?utf-8?B?RSsvRmdOdjcybFBzRWg0S2tsdEIrVmdlZEVqdndhYUZERDk3ZUtOczJTTCtZ?= =?utf-8?B?ZmlPdlZwb0grd3c3ZElhYjkzLzBiR2VJZUZydW1zc2xWejVDYllIMGx2ZnZV?= =?utf-8?B?cGxlazBmd3h1eS9SdEljbmhYZnViUjFXTEFUR0hxT2dTT3RjVUFqYTJweklS?= =?utf-8?B?NWhXMDVWOVNvekpiNS9lalF1TGl0cnR1ZGhYUEI4MnNMcWxnZnFXMkFtRWtR?= =?utf-8?B?TkdoQVlNcXYwQTluMW1oVUJ0emsvbTFDL0lqazE1UWxEeTR3N0lNQ3JINXJz?= =?utf-8?B?YjlxODdvUzN5cWd2Z0MwQk02bFMwVUpsQW1nZXV5ZytucTdPaUFiNTByVHF0?= =?utf-8?B?MHdub3FqVjdtbWIzM2pEVTVRT3dPT0VkbVJIQ2JpZ3NWOVRRQWxWcFk4dVJV?= =?utf-8?B?UGZkZkhNT3g5VWptdFpieUR3VmdNd3VsYjFCbXF1VWtVZFNKSGRhMUpEVGFW?= =?utf-8?B?djZMNnZWSE9ZYWN6cEhoUFR4aFlzc0c1MVZCMkN0NFV4K2l6elJNZjkweFZz?= =?utf-8?B?VjJnTXFSZEhsWUJULzM5Tkc4U1NteFdxTGo0TXZsSTkyOEpxaTZlZnNYa1VK?= =?utf-8?B?MTZOaG9MZUUzQzVDL2ExWE83SDZOaUE3RXRBa1RFUmZHdzlzMURlK1Vac2VU?= =?utf-8?B?cEFSWEErSWdGQ2lURmpmQjJKamFEeWd1NjZDUW1FMitWS2VlcFZWWVVIN0lr?= =?utf-8?B?cFBaemJOUnpHTk5QMDFJaTZHVDc2dTF2N29pSkhYMlNNbmZ3NldIRGZ0TUdO?= =?utf-8?B?ZUdEbHB5Vm5vU0pSeGQ2cXVEQXFnUjNUb21GZEJQRVFYTjJkaXVrdVd6TVVv?= =?utf-8?B?dzB0VGVwYmF3azBzZk5oV21YLzRZaEZrVEdjcE42bnRPaWdnLzdEVVJrdnlK?= =?utf-8?B?c2hQeFI5YmtJaktzdmtxZjNpMks1MElIZlE1QzlCckY2SjBOZGdWZlNHS3o5?= =?utf-8?B?cUNlcXlqeVZqa0FKNUE0UGI0RnlTbWh4SmtzTXFaOFZmNGd4WGxCc3JoT2hn?= =?utf-8?B?WkcyTGZyM3phSTE3Uzh6TElQdTJmQXZkSVBkQ2p6MU9uZ0EzUEtrSW5BWExG?= =?utf-8?B?OHR2ZHVpbWlhb2lYWEtHS21MWmd1bG9tMTFZSDVUT3hhZDNxcTJmNnZ3ZlJF?= =?utf-8?B?NVY3T2VSWDFITGNFVm1GWDZrL1NBcUZtUFhDdzhJS1FxUFhRWWJzRlpEMHhG?= =?utf-8?B?WVhCYXY2NTZCK2dUVmZxUy9hQU1tbHpTZVViUmRUNThLZTBmeDdLTGVZVnZ3?= =?utf-8?B?dHBsdFhEV3lMMW1pbmlERlU3aFZKQ1gwZzU2eFpyVksvaXVQeWY2QUI0MUlM?= =?utf-8?B?cGZwdHNob3dUWDdTdFlWWUd2UlhRK3dheGhCNUlyajRRYW5OODdtTHJ4Qi9Y?= =?utf-8?B?dU91ZUJVaGdVQUFzZVdhSjRyZHNQamU4UDJiZnk2OEhQWWF3RnF5alQxeStl?= =?utf-8?B?SXlZeDRPWGtzNnVUTjA1OFN4TE1yTjBVMi9LU0ZYdVc2MERlY253N2ljUlp6?= =?utf-8?B?MlZUeEQ4QUxmcGMxMVllNjBBQk8wYlpnQWpCbHVWQkkzM2cvYjhUcUtyd0tC?= =?utf-8?B?Tnp4RjR0bEFaemY4S3hwSmhjeXV3UWg4OHVzT1RqTThMdEhXQlhuRUI3a0FM?= =?utf-8?B?OWk1S1UvWEVtZitVL1daS2hlZzg3akEwUVV2bGZHYmtzbHY3N01aTlVuellv?= =?utf-8?Q?MWe1xekt3Hk1u2MM0iOfppoUu?= Content-Type: text/plain; charset="utf-8" Content-ID: <87D94DD7C766064697EF973E0F175A8A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bc0d9ac-a79f-444d-766d-08da92508055 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 10:46:07.4001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OeREiDa9ClUhcnsTaaTfYtsCvtbvgWnQP2HYGlad15bdSeyT5+Z5+LjTvXRPkMZAT1JUlziBaV6GfjwzNdLFkCgM/DNKcyJE/WPU/5ufRqc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5600 T24gMDkvMDkvMjAyMiAxMToyNCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gQ29tbWl0IDlkYzQ2 Mzg2ZDg5ZCAoImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQi DQo+IHdhcm5pbmciKSB3YXMgd3JvbmcsIGFzIHZhZGRycyBjYW4gbGVnaXRpbWF0ZWx5IGJlIE5V TEwgaW4gY2FzZQ0KPiBYRU5NRU1fcmVzb3VyY2VfZ3JhbnRfdGFibGVfaWRfc3RhdHVzIHdhcyBz cGVjaWZpZWQgZm9yIGEgZ3JhbnQgdGFibGUNCj4gdjEuIFRoaXMgd291bGQgcmVzdWx0IGluIGNy YXNoZXMgaW4gZGVidWcgYnVpbGRzIGR1ZSB0bw0KPiBBU1NFUlRfVU5SRUFDSEFCTEUoKSB0cmln Z2VyaW5nLg0KPg0KPiBDaGVjayB2YWRkcnMgb25seSB0byBiZSBOVUxMIGluIHRoZSByYyA9PSAw IGNhc2UuDQo+DQo+IEZpeGVzOiA5ZGM0NjM4NmQ4OWQgKCJnbnR0YWI6IHdvcmsgYXJvdW5kICJt YXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIiB3YXJuaW5nIikNCj4gU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiBSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBX YW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IC0tLQ0KPiBNaWdodCBiZSBjb25zaWRlcmVkIGZv ciBiYWNrcG9ydGluZw0KDQpEZWZpbml0ZWx5IGZvciBiYWNrcG9ydC4NCg0KR2l2ZW4gdGhhdCB3 ZSBkbyBhY3R1YWxseSBoYXZlIGEgdW5pdChpc2gpIHRlc3QgY2FwYWJsZSBvZiB0cmlnZ2VyaW5n DQp0aGlzLCBJIHdvdWxkIHJlcXVlc3QgdGhhdCB0b29scy90ZXN0cy9yZXNvdXJjZS90ZXN0LXJl c291cmNlLmMgZ2V0cw0KZXh0ZW5kZWQgaW4gdGhlIHNhbWUgY29tbWl0LCBzbyB3ZSBrZWVwIG91 ciB0ZXN0aW5nIGluIHN5bmMgd2l0aCBvdXINCmJ1Z2ZpeGVzLg0KDQpJJ3ZlIGp1c3QgZ290IGFs bCB0aGUgdGVzdHMgd29ya2luZyBpbiBYZW5SVCwgYW5kIG15IGNvbW1lbnQgYWJvdXQNCk9TU1Rl c3QgZml4ZXMgZm9yIDQuMTcgb24gdGhlIGNvbW11bml0eSBjYWxsIHdhcyBmaXJzdCBhbmQgZm9y ZW1vc3QNCmFib3V0IHdpcmluZyB1cCB0aGVzZSB0ZXN0cyB0b28uwqAgVGhleSdyZSB0cml2aWFs IHJ1biAoZXZlbiBiZWZvcmUgdGhlDQp3b3JrIHRvIGdpdmUgdGhlbSBhIGNvbnNpc3RlbnQgaW50 ZXJmYWNlIC0gcHJvYmFibHkgNC4xOCBub3cpLCBzbw0KdGhlcmUncyBubyBleGN1c2UgZm9yIHRo ZW0gbm90IHRvIHJ1bi4NCg0KSW4gdGhpcyBjYXNlLCB3ZSBjcmVhdGUgdGhlIFZNcyBzdHJpY3Rs eSB3aXRoIGdudHRhYiB2MSwgc28gdGhlIHNpemUoKQ0KYW5kIG1hcCgpIGNhbGxzIHNob3VsZCBm YWlsIHdpdGggLUVOT0RFViAob3IgcG9zc2libHkgMCBmb3Igc2l6ZSkuIGFuZA0Kbm90IHRyaWdn ZXIgYW55IGFzc2VydGlvbnMgaW4gWGVuLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 09 10:57:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 10:57:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404204.646567 (Exim 4.92) (envelope-from ) id 1oWbhW-0001au-Dm; Fri, 09 Sep 2022 10:57:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404204.646567; Fri, 09 Sep 2022 10:57:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbhW-0001am-B9; Fri, 09 Sep 2022 10:57:34 +0000 Received: by outflank-mailman (input) for mailman id 404204; Fri, 09 Sep 2022 10:57:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbhU-0001ab-JF; Fri, 09 Sep 2022 10:57:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbhU-0007mj-FY; Fri, 09 Sep 2022 10:57:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbhU-00050F-3c; Fri, 09 Sep 2022 10:57:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWbhU-0003kj-36; Fri, 09 Sep 2022 10:57:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2xxfa6JDu7c8Ck05FD50aQvIbyfexIW9ghDKWIFmrNc=; b=6f3FZ4o2nkBmDk/P/r0KQ8CQU3 79y+p2yIWxAi7Qd/K4SLIosM/qbTY+deoBPpYVDkxld8EGn1z90uZPxT1F4J3trTWgAQjd6q3AHFt SUpqnjDpVJhBAixPfLtAv2lSh1IIpKJl/ke4yqQ/5HVGlus3NTFPudR4qy2fHcjps6MU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173075: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=506357871c18e06565840d71c2ef9f818e19f460 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Fri, 09 Sep 2022 10:57:32 +0000 flight 173075 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173075/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 506357871c18e06565840d71c2ef9f818e19f460 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 36 days Failing since 172152 2022-08-05 04:01:26 Z 35 days 80 attempts Testing same since 173075 2022-09-08 22:41:25 Z 0 days 1 attempts ------------------------------------------------------------ 1726 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 177251 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 11:00:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 11:00:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404213.646577 (Exim 4.92) (envelope-from ) id 1oWbjz-0003PD-R1; Fri, 09 Sep 2022 11:00:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404213.646577; Fri, 09 Sep 2022 11:00:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbjz-0003P6-OI; Fri, 09 Sep 2022 11:00:07 +0000 Received: by outflank-mailman (input) for mailman id 404213; Fri, 09 Sep 2022 11:00:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbjy-0003KY-Jg for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 11:00:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWbjy-00081J-1l; Fri, 09 Sep 2022 11:00:06 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWbjx-0005BL-Rb; Fri, 09 Sep 2022 11:00:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vONcpvCt8FH8pTM386Fsz6zmUszxoK6BEBQCMfwSZGc=; b=hBU4gBKV/vw3VVK9DVaAtJpY9E SCbG9Gh3K5JntP9SOrYdMKpPUuYYlI9PpJ4Id/5dG4RJZW8QrSzXKJAom4vGy2RkpB6O5RD0MQgDu ypdmst2LPcv/2S9oOorA/9Bf8YwskQIKciR+uDEh3hWLzVWAeQ78KGm63XxPz5NB0afc=; Message-ID: Date: Fri, 9 Sep 2022 12:00:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <1c23930f-e809-d623-18ec-599a0e983b7a@suse.com> From: Julien Grall In-Reply-To: <1c23930f-e809-d623-18ec-599a0e983b7a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 09/09/2022 11:18, Jan Beulich wrote: > Gcc12 takes issue with core_parking_remove()'s > > for ( ; i < cur_idle_nums; ++i ) > core_parking_cpunum[i] = core_parking_cpunum[i + 1]; > > complaining that the right hand side array access is past the bounds of > 1. Clearly the compiler can't know that cur_idle_nums can only ever be > zero in this case (as the sole CPU cannot be parked). > > Beyond addressing the immediate issue also adjust core_parking_init(): > There's no point registering any policy when there's no CPU to park. > Since this still doesn't result in the compiler spotting that > core_parking_policy is never written (and hence is continuously NULL), > also amend core_parking_helper() to avoid eventual similar issues there > (minimizing generated code at the same time). Given that CONFIG_NR_CPUS is a build time option. Wouldn't it be better to set CONFIG_CORE_PARKING=n and provide dummy helper for any function that may be called unconditionally? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 11:35:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 11:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404220.646588 (Exim 4.92) (envelope-from ) id 1oWcHn-0007tA-HE; Fri, 09 Sep 2022 11:35:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404220.646588; Fri, 09 Sep 2022 11:35:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcHn-0007t3-EX; Fri, 09 Sep 2022 11:35:03 +0000 Received: by outflank-mailman (input) for mailman id 404220; Fri, 09 Sep 2022 11:35:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcHm-0007sx-BS for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 11:35:02 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c5246cc-3033-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 13:34:55 +0200 (CEST) Received: from [10.10.1.154] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 166272329547024.854489984245333; Fri, 9 Sep 2022 04:34:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c5246cc-3033-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; t=1662723297; cv=none; d=zohomail.com; s=zohoarc; b=ExxboEDXqRHhC0ZTFXzFQJIhdCcPBTepPGKp4qPRKJOd/ebfFzScjdpPkAlTvXEZ707hVr7BXNhPOrxADv+gvLsKvmN9N8euo1Ny8rSWmshCowM3YbZeGI635rlRw11T6NeHpFZqYvx5qRBrgS1xeWJFpOvr42srA5Ra6N68Jt4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662723297; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=smoq3UFsJfa3jrjKUR5TUdYfFsv2j3mxZx/xfiWbjhM=; b=NuLsAhvsYSslj/ARxtnOTBsBb7j0OefkLjx9A1N6g8PlF2afn+u4OhIk1jA5BV3SiSGXkL/WyyFrFFWPyEXDBtwuCdA70qILiGeTBfgf08cgeKg8qH6vryaiaElJDzbIQ8UtBew+iHUfXY9EwbCgc3SnaFzPdLEfl065DI42DJ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662723297; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=smoq3UFsJfa3jrjKUR5TUdYfFsv2j3mxZx/xfiWbjhM=; b=AmVcR6Fhle97F3ZsEYTRhjIQPXtv4cAaPyALfYuCKOSlOgWsgfFuoRV3VRbbsBMd r+uludpA6l8lz74lyVChhLyfU8ugl2IYQ3ZNnEBEFYHlZnveBJK6Mos9rVOed7ap9zh A1rZItnkUpGbbtw/ew4+WX5OO6asHfPwmxxZWniI= Message-ID: Date: Fri, 9 Sep 2022 07:34:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] xsm/flask: adjust print messages to use %pd Content-Language: en-US To: Jan Beulich Cc: jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220909095012.4251-1-dpsmith@apertussolutions.com> <3da17c12-1cbe-165e-94f4-44face9a181f@suse.com> From: "Daniel P. Smith" In-Reply-To: <3da17c12-1cbe-165e-94f4-44face9a181f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 9/9/22 06:04, Jan Beulich wrote: > On 09.09.2022 11:50, Daniel P. Smith wrote: >> --- a/xen/xsm/flask/avc.c >> +++ b/xen/xsm/flask/avc.c >> @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, >> if ( a && (a->sdom || a->tdom) ) >> { >> if ( a->sdom && a->tdom && a->sdom != a->tdom ) >> - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); >> + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); >> else if ( a->sdom ) >> - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); >> + avc_printk(&buf, "source=%pd ", a->sdom); >> else >> - avc_printk(&buf, "target=%d ", a->tdom->domain_id); >> + avc_printk(&buf, "target=%pd ", a->tdom); > > Apart from switching to %pd to also replace "domid" by "source". That's > fine in the first case (where both domain IDs are logged), but in the > second case it's a little questionable. Wouldn't it be better to be > able to distinguish the tdom == NULL case from the tdom == sdom one, > perhaps by using "source" in the former case but "domid" in the latter > one? Apologies as I am not quite following your question. Let me provide my reasoning and if it doesn't address your question, then please help me understand your concern. The function avc_printk() allows for the incremental build up of an AVC message. In this section, it is attempting to include the applicable source and target that was used to render the AVC. With the switch to %pd, the first and second lines would become "domid=d{id}". I personally find that a bit redundant. Adding to that, in the context of this function there is "sdom" which is source domain, "cdom" which is current domain, and tdom which is target domain. The print statements using cdom or tdom already denoted them with "current=" and "target=" respectively. Whereas, sdom was prefixed with "domid=" in the print statements. To me, it makes more sense to change the prefixes of sdom with "source=" to accurately reflect the context of that domid. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Sep 09 11:52:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 11:52:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404227.646600 (Exim 4.92) (envelope-from ) id 1oWcYS-0002Pe-VB; Fri, 09 Sep 2022 11:52:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404227.646600; Fri, 09 Sep 2022 11:52:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcYS-0002PX-SR; Fri, 09 Sep 2022 11:52:16 +0000 Received: by outflank-mailman (input) for mailman id 404227; Fri, 09 Sep 2022 11:52:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcYR-0002PR-Hj for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 11:52:15 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6fec956-3035-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 13:52:13 +0200 (CEST) Received: from [10.10.1.154] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1662724328862890.7330068186138; Fri, 9 Sep 2022 04:52:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6fec956-3035-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; t=1662724330; cv=none; d=zohomail.com; s=zohoarc; b=bp1dIBHfogg1T9u9356xHqbdkX40bDLb9MrbL63UV6KFxy7zCQXR/bpNuDWOxwqjN4PPuX1tBUGShhCYuKBm/04flA4JRHSuUrVgM+EXaQ5JZ7dp4Czpu590ckveKipsvtMcq1Rraf7vJsPnaBWxSckZQDCg/6/Oe5IN6cBG2e4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662724330; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Y0Juv2PmzMT0x2kgaZXavJwFRL8oT0cephI3evXdK5Y=; b=AP032NFyeEURXtsfhwwPHnrr2p/iqbbhgz9s7cqBOHBdoJm/vRDXBtUsfSdb5pR2Y8erEXqMxS5hI6b2w+LdROgWcVB99bCSBdeP5XBqJ37Wjnup9D79UDAKOe9mfcNQxZZ0pDmCXTPGS/ClCemeKGTwCUpV2EmcS7RSXmYVRhI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662724330; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Y0Juv2PmzMT0x2kgaZXavJwFRL8oT0cephI3evXdK5Y=; b=lotFuzsVGMU9ZS2Be3HraRpobS1Mefn7gF8zT0Ky+6REMpzcYP9IlsB1sQ0ecWBY gYUl+To2uNJ/PB+G7+wCUx81yb6/xyl3zMIJiT89efi1VceqoqD2TzJ8G6zyNMAdpeA /830elvgUihyFtLyVo826wV2ezx4Ydz2CKxu4QWk= Message-ID: Date: Fri, 9 Sep 2022 07:52:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] xsm/flask: adjust print messages to use %pd Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: "jandryuk@gmail.com" References: <20220909095012.4251-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 9/9/22 05:56, Henry Wang wrote: > Hi Daniel, > >> -----Original Message----- >> Subject: [PATCH] xsm/flask: adjust print messages to use %pd >> >> Print messages from flask use an inconsistent format when printing the >> domain >> id. The %pd conversion specifier provides a consistent way to format for the >> domain id and aligns with the rest of the hypervisor code. >> >> Signed-off-by: Daniel P. Smith >> --- >> xen/xsm/flask/avc.c | 8 ++++---- >> xen/xsm/flask/hooks.c | 3 +-- >> 2 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c >> index 4a75ec97e2..4a86681c81 100644 >> --- a/xen/xsm/flask/avc.c >> +++ b/xen/xsm/flask/avc.c >> @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 >> requested, >> if ( a && (a->sdom || a->tdom) ) >> { >> if ( a->sdom && a->tdom && a->sdom != a->tdom ) >> - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a- >>> tdom->domain_id); >> + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); > > I guess this should be target=%pd? Erg! Turns out there is no conversion specifier validation occurring for avc_printk(), thus the typo slipped through and not caught by the compiler. I will fix and also add the printf annotation to avc_printk() to help ensure conversion specifier and parameter types match. > With this fixed: > Reviewed-by: Henry Wang Thanks! > This should also be fine to merge in 4.17, but following the discussion with > Julien and Jan I think providing a Release ack would lead to confusion... I was hoping it would go in, but understand if it is kept out. I have a list of clean-ups of varying sizes for XSM, with this one actually being requested by someone else. I figured it was a simple one that could be done quickly and might be worth trying to get it into the release. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:06:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:06:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404237.646610 (Exim 4.92) (envelope-from ) id 1oWclh-0004MX-B7; Fri, 09 Sep 2022 12:05:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404237.646610; Fri, 09 Sep 2022 12:05:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWclh-0004MQ-7s; Fri, 09 Sep 2022 12:05:57 +0000 Received: by outflank-mailman (input) for mailman id 404237; Fri, 09 Sep 2022 12:05:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWclg-0004MG-2I; Fri, 09 Sep 2022 12:05:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWclf-0000tc-Vx; Fri, 09 Sep 2022 12:05:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWclf-0000Zg-GS; Fri, 09 Sep 2022 12:05:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWclf-0005jG-Fv; Fri, 09 Sep 2022 12:05:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TMhMxkJJASmlrhBeYNUCz1TYnpXoFtIWxWSPR7cjwFc=; b=F/e9ylXcbb+k9xeVtEWZMKL1jK j1CG2gAOTtqBb2yBGQjO4kX1KBXVEFfCnbA8yVCgzDnVsrsHaGE5iNk3x9d6Y722VKc7Ow6b4ABM2 orWoB8PgMIa7/NnL2BuLxS1XF2BdS8ldZUyPqOn6FbsUYGg8su1m2tQJMRzDU4j9HoWE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173089: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 12:05:55 +0000 flight 173089 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173089/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 274 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:10:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404245.646622 (Exim 4.92) (envelope-from ) id 1oWcq7-00065s-U7; Fri, 09 Sep 2022 12:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404245.646622; Fri, 09 Sep 2022 12:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcq7-00065l-Pi; Fri, 09 Sep 2022 12:10:31 +0000 Received: by outflank-mailman (input) for mailman id 404245; Fri, 09 Sep 2022 12:10:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcq6-00065b-Gb; Fri, 09 Sep 2022 12:10:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcq6-0000yn-Dk; Fri, 09 Sep 2022 12:10:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcq6-0000r5-32; Fri, 09 Sep 2022 12:10:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWcq6-0005Ck-2Y; Fri, 09 Sep 2022 12:10:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xtjLMzn44a96wT8YBt7OGyQ2xhHNeplLddt2A1iTVYA=; b=5VwhMF8IPLgYrDmrXBsxUbxfCD Q2hiiKHrrTmiaFJ/tchd1gTV1Gg2xQ06DQ/eVAzrOhs2FxYjwY6W3jklVvBta+gV/+HNOOtwrH4lk hZRUjTUqGibpq2L8abJfMfGgRQBs3oJTXWwchJwf8eyo2JIk2bmpXbq6whYpQcDLkC30=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173073: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc X-Osstest-Versions-That: xen=64e302157a87b246473a31fa104377a6d48eb046 From: osstest service owner Date: Fri, 09 Sep 2022 12:10:30 +0000 flight 173073 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173073/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173063 build-i386-libvirt 6 libvirt-build fail like 173063 build-arm64-libvirt 6 libvirt-build fail like 173063 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173063 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173063 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173063 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173063 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173063 build-armhf-libvirt 6 libvirt-build fail like 173063 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173063 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173063 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173063 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173063 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc baseline version: xen 64e302157a87b246473a31fa104377a6d48eb046 Last test of basis 173063 2022-09-08 11:10:14 Z 1 days Testing same since 173073 2022-09-08 22:08:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Jan Beulich Juergen Gross Julien Grall Penny Zheng Rahul Singh Stanislav Kinsburskii jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 64e302157a..6bc1c1aba0 6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc -> master From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:11:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404249.646633 (Exim 4.92) (envelope-from ) id 1oWcqS-0006Wt-5s; Fri, 09 Sep 2022 12:10:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404249.646633; Fri, 09 Sep 2022 12:10:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcqS-0006Wl-2Z; Fri, 09 Sep 2022 12:10:52 +0000 Received: by outflank-mailman (input) for mailman id 404249; Fri, 09 Sep 2022 12:10:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWcqQ-0006W8-41 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:10:50 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2050.outbound.protection.outlook.com [40.107.104.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70c55f40-3038-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 14:10:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7274.eurprd04.prod.outlook.com (2603:10a6:102:91::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 12:10:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 12:10:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70c55f40-3038-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNxz4y3jHBPpVx+ALMuj73bpEemMK/aODnUuc14RdkY3U0QtAkwqDxceibyb9hxmrrALoAOJrokz21+wRxUxYDkeRzPQlen3JZxZm3yfPcYp2BUdAicq1rpPhFMBCuIQAGcY7m/mfo1XcMGozqUfYF43PWu4MR8YbfA1aS7FR14/hNwkDriw+nHl+PpKoKE0b/TypU0Qpcpm/2Il/+a/1PwVPn/dPgdsULNYUnzzycfZKfYPJg5/whJn81XWVvr3c2dIk/ARwSk1VnOeHncltOXGV4OTRf5xJY5E4z8rGCil9/weI5EPFxvi6u/C50vtgYZ2bPJKVSt13BICIkGiuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KZ+pzLOSX6IqrMvfzGW5iPAa5yZL+aE8Ip8QkvxBh6I=; b=Y2NIK7gb3AHKSA47zExgyrUV8GfZ+nCmCWqsvulaUUTJPi/+X2cwBGcS6lSuSuJGcp+UuFwLcVuO2QxN7pdskV82DL1pfYLqITr7Tnv7POXMKteY1iqQc3tT+VepiUTHY1+jWGYsdvOo8JHLfDfNo7Q3mxQFRLKOe2Ia4WbkbYVu0AWkBPfbyrdPfW+I7/HPrT6Dq7LcfTVwaWM8OexvA8PCbNNkHaAN1IeT78VLXr1fZ6YZHN+idVubObH401l7HM1YOBeHHIPdQ51U+0kE5kC1jU1igwQRQgDgwXWOPcOqbqwK4FT01huH4zkBLriZyZcJEngHyFoJPzJIt0pibQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZ+pzLOSX6IqrMvfzGW5iPAa5yZL+aE8Ip8QkvxBh6I=; b=vEqPB5kadrtn34uS/QBCIGqpT6osBxhuZoo/blGxgS08ceZyc9LZzzih1E57751qsEhpMAJiKnU+DPmSytQ84BaXA9h5mNXGtlUlXzhcmhee3c0Nsa26/Ykx3XfDxULfMh6SkWaPrKm0igY6GLb6ziGd+T4EvVlVDuCNnO7W2XIFWEVVEk/WknljRiKUzKZwV8sIg+5oZvSy7GfKzW1LahSSfCEb8G44Ff3IBiX8CeEb9DdbLrk1aLIign7yVKXwz+xj3itUsBJE4aQG+b93nJ3JLL2Zsw5ISR0fAObz/QhEqWtjabO+NsQ8Q4jmXjg9xE7htusgLxODurafvczpTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 14:10:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] xsm/flask: adjust print messages to use %pd Content-Language: en-US To: "Daniel P. Smith" Cc: jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220909095012.4251-1-dpsmith@apertussolutions.com> <3da17c12-1cbe-165e-94f4-44face9a181f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR02CA0011.eurprd02.prod.outlook.com (2603:10a6:20b:6e::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7274:EE_ X-MS-Office365-Filtering-Correlation-Id: 6def7f3d-d83d-413d-0de4-08da925c53bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EPQPA6s2bR/zxT0tcGqwLKEzolKBa7smOKvwSZ2Rh8FJIJb7LYcb0QWCDE+AD0oNJksYibDnm56tRtTZA7XNJo3LXdNiUlI2a6e0OAvGOdJhgKkW9MBxPY8z3qpKhCvxge9t1U1nzIpi6PO84VzeOxCblE8xPJkMdRIfQpbR+uRALWRQmXifVte7YlZAHaCD47cvMPCSFpPQUqaf19ohXsesTLnT2y7Ke0cseMlTSaOJcr8HgRLL7/nFVqVV03Uqb7CA9CP1eVQekqQsB5sqighMxqznFjgcze3mBgxcVwZQmMtAa/BGeIl9YbarRAQ0vBO/g4X3yt2LPjZpZFg0YwobJi84Uj9IoUvT5TzfbEgHuuLovOMkswiO0w8xJo2CWqqMf8nD+IpH7Qtl4oQijgi+cdzO6kFPyQ5eggrHKUy9Cs3e26sAUUOk5r1OucpoE5HwN9Jle/tY3nkvmzOKKkg1zoNXrAKZgbSnXNorQ5V+eBlZgbtweDcNBzri83KVFkmOVzBLFsQ/wrG11qB9gpcTVKtwKvCOLtWSS/8MpPjczFnNK3oKNLe6SE7gX6lIglXNLKpdgXrWxn7Dzv/EbfPs/kpZU0bfBcXF/vPbb118dF2KT0kzbQTxxHWgMYyZvRwP6VyoB5YJ18QOqr16Jz2mtCg9q369rJgdPU6fOX91WB0IrrFoYqbmLf6r0hsqcwzaiZpIcLSmdPT9/bTYOWSvHDKwH7inHgkCKqNrCoaVVsLYY1TWX/dULq4PCwRe30k98FPqj7uhNs5vjC8A4QhsuDzhrXlTOS9d0KbXmlc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(39860400002)(376002)(366004)(53546011)(6506007)(38100700002)(8936002)(316002)(31686004)(2906002)(86362001)(6486002)(2616005)(8676002)(186003)(31696002)(66476007)(5660300002)(66556008)(4326008)(478600001)(6916009)(66946007)(26005)(15650500001)(6512007)(83380400001)(36756003)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkNxZlV4MHptUjI0YnhOQVNMREthdGRVMU53ZzF3emRsWE42U1JxZE5ET1Mz?= =?utf-8?B?aVIzM2phRDJWeVNWOUE3Z3VmUEZhTUZvTGtxZWZFekNRSmsrTnViUW1reHlm?= =?utf-8?B?ZnIrSlZlWG5jdWNmY1U4Z1ZtcGhzbHNKUFB0bXdtSmNYY0gyZUJQd2kyR1JD?= =?utf-8?B?UDlheG80dmJsVVU1TnBBSXduWm8wTXJUOHFhdnc1Qk53Nm5ncDhBWGFmTlNP?= =?utf-8?B?SmNtZlJpVUtuQXF1TUVtZnE4Z0F5TWRkK0dqS1FhVnhhUmV0a2lVNU1KUEFu?= =?utf-8?B?ZGNnNVJGcGY1S1J2TVQ0cE1SZFZuVmQrdCtYeGIyTVZmbTVuT2VpYWhZZVRp?= =?utf-8?B?bDQ5VVZqUTRCS2lFNDBBZk0vSzZRZ2g4eksyWW5VOEM5RFBRVEVwbDg2N0Vy?= =?utf-8?B?dDVJM1MyTjNsOXV1eXIzZU1XV1o5WXlEcE16SEgyZDFuUnU2WFFnVVhaWFNu?= =?utf-8?B?T1VqLzdlSzJVQ0VZSjVYeEp5RlZua1QyQVNveTlBbkttSERVNUtwMjlXbk1w?= =?utf-8?B?aWRyRWJONGNINW5PTkYzOFlHcUlYcjZxZ0NnUFM0V1ZGemtaMlJ4RTR4bkZR?= =?utf-8?B?UENQaFZ1L1E4bFJLV0xZeFhRSmc4emo4d0xSU21sQ1JuSkszTys5U1hZVm9q?= =?utf-8?B?S2lSNG5vMTBRMHpyVnFZTEkzVHU1NEQzOG83cTZqM3praXBtZitLem1yNDdy?= =?utf-8?B?M3dFdFIxREZ6ZE5tMDdxMS8xckI0MmFwVFNkelh3aTdFYUE4T1ZmSU5lZktQ?= =?utf-8?B?SlVCb2hLc3hPMFdGTFVNMGpuMGZJVEVqcENGOXVuVENyRU12L0VQQkNWZHRr?= =?utf-8?B?ZndKVW1BdjNwMmVYZFpkK2ptbStueURDZ1gzaVRDNHRYbjkvL1J5U2RxVHlV?= =?utf-8?B?Q3lUTmVEQm4ySVdUQStoTlFodFhkQi82cWRpWmRmbUlFYXI4cyt1anVwTkFE?= =?utf-8?B?dTJnY3ZZeEdndHpRZjN0QjdDaVhIUFgzV1RzdmJ4K0JMaVhQV0hqS0hkNmJr?= =?utf-8?B?UzdiRjV0dWJFKzFVSjE2WWcwaENha3lURTc0SjJnemJDM0lzeEtOUlh3cGMy?= =?utf-8?B?VWMvZUhIYzdmVENTci9zWldmaGhGNTk2Y2NrUDhMdDd2MUhUOXpscDlqQStn?= =?utf-8?B?UzRHQWJPblRISlJRdHRwK2dKSmVDdExob1JFR0J0VGh6RTkyY0tIL0NtdkpT?= =?utf-8?B?UGRQaXBPMmJITXJudG9vRVpzcStRNHFlcytsZ3lPSHhyejUyVEVIVTRiVnBP?= =?utf-8?B?dGR1L1QrQVhmRXlnQ1Uzdkhpa0NYNXhrZFQ5bC9WY0JaZTV0ZzdYWXdBVHIz?= =?utf-8?B?TjFvL2pES3FBa21BcmNiVEhBR0xWVFBRWW9wNk1abmw4NkYxT244NzB0eFF4?= =?utf-8?B?UTRKamVGd1Nnd21ha2xuZ1VpT2t4Q3NFdzllLzd2YkNiSllkaC9BV3BOQ25G?= =?utf-8?B?M3FrZGtHTzdqYkJUUTJZNTZmbHd1NWZmZWVtclFSaHgrNURFd0lDNzFBU2JO?= =?utf-8?B?SnQxVTBPb1BFenZkNUxBNnoxcTFISmpqZXBGcEU2SW9ja3JVNFNzNUppbm10?= =?utf-8?B?MkxtTEswUStROHFCMmRkYklQS1pFU21GbjNzUWFWLzBibXl6WGFFOUZET3VB?= =?utf-8?B?b0kzdm00R1doTlhVY0ZKWlkyekYzWUlrNU4wajM1cGxxZjJpVEFXL3lqREtV?= =?utf-8?B?aVE2aUJBSnQxb0cyN1dLektSdDVyRHJsQndQMERKV0d0Uk0xOUxFS3c1dEI3?= =?utf-8?B?aDdNMlZlWWhGSmVySVdlRitOQnlvZWQ4aklSU3Fud3I0ajNiUTVhZzh2aVU3?= =?utf-8?B?YXJ5Kyt5aTJ4OXg1dWFRblA3eWtENEIxdVR2aHJrd1VTOFNUR0p0c1NJMWJH?= =?utf-8?B?VVpTWDJrZHBtNzRCMWZiVE9LcXhRTWpMaW44OVF1WHBWUTUwSkxhUVU4OWha?= =?utf-8?B?Nzh1VG9TWXlaRzFJNWh3eWFxb3hNQ0lDUThpcTM2eTVuQWF4anVjVm9LYVp0?= =?utf-8?B?b2FYOEo1bVliTnFmZU9selJ6bDR1Rjh4bWdMNW0yZ241N3lRcXYvb1hRUnN4?= =?utf-8?B?WS83VzRWU0luTGRaSWczYjFWdzZyN2NZaFlncHJpKzFoay9BU3ZYTWY1OVdC?= =?utf-8?Q?tw62v/GkxmhSf62EDcKPMO5uX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6def7f3d-d83d-413d-0de4-08da925c53bd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 12:10:46.7454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8VugTPPi39rCNY2NIR7wuSnBM4qSeVBSOc3MwLcKMCOyB45z/ox4zWDwNhRFEz+qd0tu8LY7zkm/76jg5wPs2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7274 On 09.09.2022 13:34, Daniel P. Smith wrote: > On 9/9/22 06:04, Jan Beulich wrote: >> On 09.09.2022 11:50, Daniel P. Smith wrote: >>> --- a/xen/xsm/flask/avc.c >>> +++ b/xen/xsm/flask/avc.c >>> @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, >>> if ( a && (a->sdom || a->tdom) ) >>> { >>> if ( a->sdom && a->tdom && a->sdom != a->tdom ) >>> - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); >>> + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); >>> else if ( a->sdom ) >>> - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); >>> + avc_printk(&buf, "source=%pd ", a->sdom); >>> else >>> - avc_printk(&buf, "target=%d ", a->tdom->domain_id); >>> + avc_printk(&buf, "target=%pd ", a->tdom); >> >> Apart from switching to %pd to also replace "domid" by "source". That's >> fine in the first case (where both domain IDs are logged), but in the >> second case it's a little questionable. Wouldn't it be better to be >> able to distinguish the tdom == NULL case from the tdom == sdom one, >> perhaps by using "source" in the former case but "domid" in the latter >> one? > > Apologies as I am not quite following your question. Let me provide my > reasoning and if it doesn't address your question, then please help me > understand your concern. > > The function avc_printk() allows for the incremental build up of an AVC > message. In this section, it is attempting to include the applicable > source and target that was used to render the AVC. With the switch to > %pd, the first and second lines would become "domid=d{id}". I personally > find that a bit redundant. Adding to that, in the context of this > function there is "sdom" which is source domain, "cdom" which is current > domain, and tdom which is target domain. The print statements using cdom > or tdom already denoted them with "current=" and "target=" respectively. > Whereas, sdom was prefixed with "domid=" in the print statements. To me, > it makes more sense to change the prefixes of sdom with "source=" to > accurately reflect the context of that domid. Well, yes, perhaps "domain" would be better than "domid" with the change to %pd. But I still think the middle of the three printk()s would better distinguish tdom == NULL from tdom == sdom: else if ( a->sdom ) avc_printk(&buf, "%s=%pd ", a->tdom ? "domain" : "source", a->sdom); Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:14:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:14:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404277.646692 (Exim 4.92) (envelope-from ) id 1oWctf-0007tf-E0; Fri, 09 Sep 2022 12:14:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404277.646692; Fri, 09 Sep 2022 12:14:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWctf-0007tY-9F; Fri, 09 Sep 2022 12:14:11 +0000 Received: by outflank-mailman (input) for mailman id 404277; Fri, 09 Sep 2022 12:14:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWctd-0007tR-Ms for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:14:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2044.outbound.protection.outlook.com [40.107.20.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7d4be44-3038-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 14:14:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0401MB2382.eurprd04.prod.outlook.com (2603:10a6:800:23::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 12:14:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 12:14:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7d4be44-3038-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RteA2+wYAKaVHXHF6l7Xyc2YGEusYuUn6JoCsjDLu/XjghhS0mY5dpk+05baooZe1NW314ncmHmfogUGvyVr5zPCZnqrTYe/w0nEN0+oCX2OfSu88Cd7Lzg2huSGsV0wX10CI7tEumVKyv6b3JRhZ27ZUA5CS2/RGmb45xHX0rlbG2mdtFRJvEfyPlr0Dv5sBso/fHQ+x67VEDubVydwrIFB1DqQ8XAzjf5XgmWlM4Qc+JojI4wOTNa1HRY3rV5JT3n9kAAwiHRP5yijFiLNfHgBBr2pzWCcVvanTQgKYDsifCB+CL8VOHUCz8X/Loz2XSAspfktk5iIPnrubocCtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AeDyfZx8AvLEIZUYNderXlon8dG0bY8Eyiwiv/Ay7lg=; b=I0Jz8ShgVZuy0IJ9qQj5bZme+ACQr4OAjlLVFdEkKOPQz8L1y3qTc+jU21W0Y85u3pkL+Urf6H7dwMwqDb4cLsWvdy1+NYr05YwmFZkgpkjaXwaubCDiyRyCEPY/uRX2vYtCF1y+f8hHgCMMPQMYweopyDxWwOoZO5pdL/pBgE3RcvQR3YhSJXwcInAU15UKr8HRUrYzgS0OhngqrugY8KgKPvkV/u8MhdMTj5wRyPFDu7eBThonHWYmEezGYAVS5VWNwpmQt51S3bAvgA3a3o6OlIZ50/GhkcTvh9Z2sb7TPv6y1m+9ETHlthmomE+EEhiMzNkYAbMcGq8Lnp7wSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AeDyfZx8AvLEIZUYNderXlon8dG0bY8Eyiwiv/Ay7lg=; b=YgWYcPjZ/pDGAx/t8TxW04Sp2C6lCOpOUIPIh4XRmstzsjsit9IWVeq/alJ0kStxNq9sE0NPSUKhtHo9d8dbtqabwGpoOuNSQzPPjprW1bbVa4+OPdQsp+F4/SVUA/IM5YXrlmwKgywtLEQKUikxX9UHdLHph/PDrfRU+1sdt/I07HsDa4D/mMUs/HqeVAiX85CkfbpjxZGvJUTC/oPVZN6gD7TO97iZYHyhRZXj5UipNn/jqVi2FPwjBUx35jGfEYQ2L8dK+588mFfR6TQ7qwQRuvK/J6f5J7gbMudATU/ah3jULys+igKRZ+Xjb3Y7aklge/6A63HqhwDlHKEv2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6da822fb-e900-156b-334d-8bc573b74aee@suse.com> Date: Fri, 9 Sep 2022 14:14:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1c23930f-e809-d623-18ec-599a0e983b7a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0021.eurprd05.prod.outlook.com (2603:10a6:20b:488::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR0401MB2382:EE_ X-MS-Office365-Filtering-Correlation-Id: 6794fcb5-eaa5-447f-bb12-08da925ccac5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RfINwLZB6ZQ+lEj8OK8dm968JeU+whSVq2YlKpA6LAIvrlHFG8PE0/wFQqsPs9CnsZIfLSKHkykCLwEmi4D3FN0aWGpvOkcKaFqPpAuhqrJFEVKmZyRmjbkxnTBxpHtM8lNeGoAO5kWDaJncAt2TUHvEDhzbbfbfalQpT5iFcW7epuEVDnrDBbj4UoO2aIfgMdY83Y0Lif9uCmevg2qHVh2dp5x35UWhdlEE5t45i4Ydc+bSdJMvgoYCU6q3J8yNX1CHSrDkeFH5pnnCBoOG90H3zfTJwmAfgK6u2kGRhs4q3zbd8sNYjvUh/ewsmRggF/3Foe7A1FnTgQpzJAavsnFEqRJvFNtI8ErW65cF9jVntOcQiAQMGGiKxN1EMZ5XIWnHeUzhFU1zcCkvbAlsaLD9k8P8QdUKGVk4nZl/mH1Qg+pn7f3Y0dtWZqwNESTd69KpIEA/4KPgxEVjaKBZIapPSaSdL24CUBJO1giig1UccDc1Ta1X2X+g3PKWrkzuvNc9g3hoPyAgGCNWTpB6Y/XFka518s/p2be/gaQBhboLGLkvnnqcyV8HnhKW86eUjTxAIdQEtabLyBxGAdcNYRE43IaHiJYDt3mQeO+f7jVx9yTB4N0QshmFoyRmJ/Pn2rp9GmMzVDSqz+ZhEINlAuD+Pk0UcUz1S0CYbw1QSd4F29YcFZyIzr1xqEhVji89DXdAs8pbkSYkhEF4kltaUv3rDRm1sCRFiRBPPlaZC8UU5Cl4tFmHzV7IMqWUsGt2++MX6yQjqBsGZDCRXsV+1iRIVbRam7x6RggFTCQe8dQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(136003)(376002)(366004)(396003)(83380400001)(54906003)(6916009)(478600001)(316002)(6486002)(53546011)(186003)(2616005)(36756003)(31686004)(26005)(6506007)(2906002)(6512007)(31696002)(86362001)(66556008)(66946007)(4326008)(8676002)(41300700001)(8936002)(66476007)(5660300002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFpoMUVuUm5SanU0RWl4alFIeHppM2VwcnRKZENnUEJqNWN6ZTRXUWhTTDNI?= =?utf-8?B?ZG9jeEpjM3NhZDdObkdYNmFEMWZwMkh4RFppVmV4RU91SSswOWt0UGl3Tnlt?= =?utf-8?B?TkNEWjNYQzdQMmxuNGx0aGgrTUhmR1p5VHRlRVhZWHZMK0d6d0x5SUZRNEU0?= =?utf-8?B?NHRBTXhTNi9uaHg2YzRaM28xdUlCTnJiMHR0ZEZ4cjBmSVFIOW41RCs5dmpw?= =?utf-8?B?RjZ4SzZMZ2ZMMEwzWEhaaC9obm0wTzh0Q1lXUy9LbkpnNzVNbE1ZZzhZaWNv?= =?utf-8?B?anZqaVJIODRUUlNNa1RINGlpbGxWbjRUWUh1ZDAvU2dWZGhIZzhjRXZXUldS?= =?utf-8?B?eDFlQnVrdUVqT0VlcGg3NlV6L1IwTzRyM1R6bGZjdzRsbUwrNzRXOXI2OGFC?= =?utf-8?B?VCs4RGdKUFNtd1pNVms4a3JYV25vWDlBR25SVi9SdEJaU2g1c3ZDK3E5Zmw4?= =?utf-8?B?NzNjVWpDZlFtK1NXdEM3cmRaaFA0Zmoza00wdlQ4VjBNenQyZGQyQlpBQnVp?= =?utf-8?B?aEovTFIxMkZCdXk5dEFkVklrVVJvU1Mrd3VrNm9DTHl6VGEvQ3Q0VDFuODZB?= =?utf-8?B?ai81NEx2NlFFNVQwbndjUjJzdTlwK25GUGtPUzRqbnd0Y0kyS29KNUlSZjA2?= =?utf-8?B?cnFtUDNaeWkwaVFBak1maUVFV01ZU1pLWFFMRG5xam5HZ01XSEk3MnQ5WUhT?= =?utf-8?B?MzRhOWVsY2NkT0NINUwyR3VHT3NJK0hRNnJ6Q3RwUkxRZXozNXBITDZHZktW?= =?utf-8?B?Q1ZhM013NGZvMDFBaFF5c28vdXRnZ2NIdmZVQkU3cnpSN3A4VWJUL25ObGZx?= =?utf-8?B?NU9meHEycE5nY3hPK0tpVWFkR3JxUmZncFp6SXhZdjd1YU1VWXZyTXJLSGJq?= =?utf-8?B?Ry8xVmdtVldhSTVkR21yaTJ2YVhTTGlERkF1NmNxOGRRTksvam9uTTJBUlVh?= =?utf-8?B?RXpIR2RqSFYwVHN1U2crYjI2TXVOMmhxREU3a3RtVHlVeU1xNTFnVUY4SWFG?= =?utf-8?B?bDNOdW91WkJZRGUzMlp2UVRCMnorR21jcGdhTStNVzgwd0MyZk02SkNrcmJU?= =?utf-8?B?ck9rbEVTdTdYZHhiWTgzTncxMjVZRDBKenJYWlpZZzc1QUVRemE1QUthYnRk?= =?utf-8?B?RFBXNys1aWh4bW4yL0RhL0RBVzNDOTFOYWZlNVhkWFMvOVJKNEVDTzBiWDAw?= =?utf-8?B?dC82SG55dWpJWWs4L1FhSjFYUzF1MCt2dlBnMGkzTkM2bjAyQXZLcjRobjdT?= =?utf-8?B?WnpFcXlOekVYdkQ1dnovdFFsWW4vMDJOV0Q2ZDFZeWc1MG1IZ1FnRCtac3JN?= =?utf-8?B?b2JoVVFMN1J2c0QyYXN6aVZLUU9ybkxxZ21hMS9LdVlJU0U4K1BVQWFJTUVU?= =?utf-8?B?RE5HdzNsdjJtTThJMkdtT2VENS90bUpha1NwVWtsK0NEaW5vQVo5bm9QRzJj?= =?utf-8?B?ZFlDLzBlUis5czFJZ0VMeElWcG9NS1FhdCtuOEM1Tjh2MGJ3VCtoM0lMek54?= =?utf-8?B?WUYxT0ZoOWMvUlJYN3pzVE1PSEVZRG9tUEhNS3BheEc1Wjh1MEZVb0JseWts?= =?utf-8?B?dFZXZkQySjE0bEF4MllmYUxVZklCYWVxaTlMZ09MamhiTFczSUhsLzlCYkkz?= =?utf-8?B?TTlyY1BpYVVoK08wbzV3RjhMT2dZbFUwZXREZ2JCUCtIMXV1NVVhdEtIdEZD?= =?utf-8?B?aDhnaXhFNXV3aGFzbGwvREJkRnVlWEE3SkVycE0xQkZFU2p0YVpZWjJ4S1J4?= =?utf-8?B?QlhhK2dZMUgrM1hDVXFjVVVodUF0UFhqYkNKaEVtSDRxTTIyTWlDT0t3blRF?= =?utf-8?B?aGEwbnFiK1JXSGdnWmVvOE5ydExiVWNyTzN1RklldkJjZVM3Zzl3blAvNXk5?= =?utf-8?B?Qi9kM3ZwQ0w5b0RNZklONFFNZ0h2L01wQ25pai9RQzIweTFSV3gzRkd1WFlx?= =?utf-8?B?ODRFNmtDQTdFUUp3aWxJMkNqcmcyT0NoQzJ2dDZaUVJsN3NEMXRVdWlqYm1y?= =?utf-8?B?cEF4K0tFaTJVQWhZV1c4ejhxdk1nSjJiZ3JXTzE2Ylk5VHNRQ2JnbDZoME5J?= =?utf-8?B?RHlxY1QwaGRlazh4M1VVOG1TRFlxSzdKUkR3d3hQb1R6djFzRmhiOEswR25R?= =?utf-8?Q?UApQbCXMd1ebSlVdyHsEHlP9Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6794fcb5-eaa5-447f-bb12-08da925ccac5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 12:14:06.3886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BDoZJl2Xj7LVhJOUIPYq1O9bX09mmTr1DD0CR7xOzejCBIP7S9iPRs7Rb00RKJIGwdUa1Pv70nXvTH+Q3qBidg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2382 On 09.09.2022 13:00, Julien Grall wrote: > On 09/09/2022 11:18, Jan Beulich wrote: >> Gcc12 takes issue with core_parking_remove()'s >> >> for ( ; i < cur_idle_nums; ++i ) >> core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >> >> complaining that the right hand side array access is past the bounds of >> 1. Clearly the compiler can't know that cur_idle_nums can only ever be >> zero in this case (as the sole CPU cannot be parked). >> >> Beyond addressing the immediate issue also adjust core_parking_init(): >> There's no point registering any policy when there's no CPU to park. >> Since this still doesn't result in the compiler spotting that >> core_parking_policy is never written (and hence is continuously NULL), >> also amend core_parking_helper() to avoid eventual similar issues there >> (minimizing generated code at the same time). > > Given that CONFIG_NR_CPUS is a build time option. Wouldn't it be better > to set CONFIG_CORE_PARKING=n and provide dummy helper for any function > that may be called unconditionally? That might be an option, yes; not sure whether that's really better. It's likely a more intrusive change ... Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:27:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404284.646703 (Exim 4.92) (envelope-from ) id 1oWd6J-0001I1-Gx; Fri, 09 Sep 2022 12:27:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404284.646703; Fri, 09 Sep 2022 12:27:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWd6J-0001Hu-EJ; Fri, 09 Sep 2022 12:27:15 +0000 Received: by outflank-mailman (input) for mailman id 404284; Fri, 09 Sep 2022 12:27:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWd6I-0001Ho-RO for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:27:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWd6G-0001Is-5c; Fri, 09 Sep 2022 12:27:12 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.11.73]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oWd6F-00015c-V0; Fri, 09 Sep 2022 12:27:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=m95o/NH+IqGlXihnxCEIEF7pnCRsl1OPHbUnmGLS/9U=; b=Rgnx9X/K/o7nS4dXVgRUa704q5 pL0W9r78MenWuRta99OWXS/CFyXPuhjpPW198C2Qfjwux1H4SrzA7HGwkTGdgciqALgd3dDEF9gmL HIX2ShIv2O8tBlY0+iCOUla4d8ORhnsYIuLHmBYLscUhipH0X0AacCKuLom4aW7KIIas=; Message-ID: <7eebd88b-f7a5-5dd3-7482-5086cd745940@xen.org> Date: Fri, 9 Sep 2022 13:27:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1c23930f-e809-d623-18ec-599a0e983b7a@suse.com> <6da822fb-e900-156b-334d-8bc573b74aee@suse.com> From: Julien Grall In-Reply-To: <6da822fb-e900-156b-334d-8bc573b74aee@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/09/2022 13:14, Jan Beulich wrote: > On 09.09.2022 13:00, Julien Grall wrote: >> On 09/09/2022 11:18, Jan Beulich wrote: >>> Gcc12 takes issue with core_parking_remove()'s >>> >>> for ( ; i < cur_idle_nums; ++i ) >>> core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >>> >>> complaining that the right hand side array access is past the bounds of >>> 1. Clearly the compiler can't know that cur_idle_nums can only ever be >>> zero in this case (as the sole CPU cannot be parked). >>> >>> Beyond addressing the immediate issue also adjust core_parking_init(): >>> There's no point registering any policy when there's no CPU to park. >>> Since this still doesn't result in the compiler spotting that >>> core_parking_policy is never written (and hence is continuously NULL), >>> also amend core_parking_helper() to avoid eventual similar issues there >>> (minimizing generated code at the same time). >> >> Given that CONFIG_NR_CPUS is a build time option. Wouldn't it be better >> to set CONFIG_CORE_PARKING=n and provide dummy helper for any function >> that may be called unconditionally? > > That might be an option, yes; not sure whether that's really better. It's > likely a more intrusive change ... I quickly try to implement it (see below) and the result is IHMO a lot nicer and make clear the code is not necessary on uni-processor. This is only compile tested. diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba3c..f9a3daccdc92 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -10,7 +10,7 @@ config X86 select ALTERNATIVE_CALL select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 - select CORE_PARKING + select CORE_PARKING if NR_CPUS > 1 select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ diff --git a/xen/arch/x86/include/asm/smp.h b/xen/arch/x86/include/asm/smp.h index 41a3b6a0dadf..7baca00be182 100644 --- a/xen/arch/x86/include/asm/smp.h +++ b/xen/arch/x86/include/asm/smp.h @@ -61,7 +61,15 @@ long cf_check cpu_up_helper(void *data); long cf_check cpu_down_helper(void *data); long cf_check core_parking_helper(void *data); + +#ifdef CONFIG_CORE_PARKING bool core_parking_remove(unsigned int cpu); +#else +static inline bool core_parking_remove(unsigned int cpu) +{ + return false; +} +#endif uint32_t get_cur_idle_nums(void); /* diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c index a7341dc3d7d3..5d13fac41bd4 100644 --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -718,6 +718,7 @@ ret_t do_platform_op( op->u.mem_add.pxm); break; +#ifdef CONFIG_CORE_PARKING case XENPF_core_parking: { uint32_t idle_nums; @@ -743,6 +744,7 @@ ret_t do_platform_op( } } break; +#endif case XENPF_resource_op: { Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:36:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404291.646714 (Exim 4.92) (envelope-from ) id 1oWdF0-00039B-Dj; Fri, 09 Sep 2022 12:36:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404291.646714; Fri, 09 Sep 2022 12:36:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdF0-000394-9x; Fri, 09 Sep 2022 12:36:14 +0000 Received: by outflank-mailman (input) for mailman id 404291; Fri, 09 Sep 2022 12:36:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdEy-00038y-SW for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:36:13 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20050.outbound.protection.outlook.com [40.107.2.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fac15ec1-303b-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 14:36:09 +0200 (CEST) Received: from FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) by DBAPR08MB5832.eurprd08.prod.outlook.com (2603:10a6:10:1a5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 12:36:04 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:49:cafe::d5) by FR0P281CA0059.outlook.office365.com (2603:10a6:d10:49::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.7 via Frontend Transport; Fri, 9 Sep 2022 12:36:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 12:36:03 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Fri, 09 Sep 2022 12:36:03 +0000 Received: from 93dd2d3e8483.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 139E0A66-68DB-423B-9300-F17BFF34992F.1; Fri, 09 Sep 2022 12:35:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 93dd2d3e8483.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 12:35:56 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DU0PR08MB8017.eurprd08.prod.outlook.com (2603:10a6:10:3e4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 12:35:54 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::cdd:acf1:e6c0:4687]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::cdd:acf1:e6c0:4687%4]) with mapi id 15.20.5612.014; Fri, 9 Sep 2022 12:35:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fac15ec1-303b-11ed-9760-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jyvFhDnXKvNwkiSVW0TFm4cdvdIgRxXCj+8mXg1QbRiXHlkpR1ov89ceOf389FYT4g4XGwfJSb3YgFgsz99VGdBYBxnHXw1y9q7ITT5uxnerkJDjXjVTRlt51rpEDoymqGU5vLZ6nN987uNtCSQEjlAZvgqsS1tezlvecO360tnO0Y2nVsOq3aaSUuAHdT2Ar5lC1RGKvIWTONd96EYnbvc3mFMCGYNe+nf9idwMcPHoQxtbBLXIMxYqCb6tufysGsNbWNpguavUM64f6SYptD7Wp7gJm2cBn1q4lNyL6sHpbBx/oecswACWiYENRNqBbphS/ctwFJuVq+N4yjbi+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DB4irmaGsLrNw968AkoqxufXa1FXjHqMsMSgbafPtVk=; b=U6yF+2nN1ivRe8wFyXWzjWmkXcLcJF0d5IbUbI3gZdt2cYCiexiRB3IYnBTbLbG5WcPm6yH1BSBI4RiHUam7mQBgCSkCtVWlRrLZXL1mnqbEIX2Fq2EbShN0UhnI4e7WQ386Gb0nOPINS3ZKQnSy9fw1RfC+0a/JDg8QYGXnPnC7WHupA3IXB9WxWzRhXiSik8nMKo6g/zLk/Fu7u6owKVCb+DmD8yDGVuNXXhYEU3uIvit5AFxqysl1OfKdDbiO7HxYdOw7m7mUQ9pXxA+7Fa6jIZZkSeQzb7ZwljUElAOeefSnLLl1ntGHwR0iwAL6R4HeAUd/aN+bnSbJT3M6GA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DB4irmaGsLrNw968AkoqxufXa1FXjHqMsMSgbafPtVk=; b=uuGWEpL9T+xNAN6gdThLfJFm7GoXiVnvbNfpik2bFFe+gD/Yip6dMjrTsTmRLuoe4PwgxepNMeRFK/4eBjpPFxeaph3lCnxafqWlMzK1Tq6o81dYQ90EZ6jbIIXBGJIjJG0wD6AJq3tCr72C7Rycb9q0T7qQs3hTFXJ8YTjojSg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e753bcc4f752911b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klfzJL9WcoNSKIz+fLb+buPmGK9LJn5NiftrJdVDt6JSbyvn8Tr5COfOXjkHF34YYtcyblrC7ybvYmoKCkS0gHk8kBnGueN423lZG+xvGpoKo0pi3t2McFHfZE+EtJke/C8y4qw/2LX8zyYVbcf6E0TkiLCnUbINK0vAp45YbohepNKvWzJLkjLCMJUgjJntK7hY3CV/PLRyuqESovFnmwpb7qEEzF4eZPCtTjRfiAFulHM/rZqe4IuGZKylI8tUfR1SR/k9T27Zia2RTSIT7b1+mrFEAiReUxlBC+myYOic1pN5UKDpatLDFtxc3eaDEj3yG5OE+7blZA7QznqkbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DB4irmaGsLrNw968AkoqxufXa1FXjHqMsMSgbafPtVk=; b=Uo+PXX+PeZZNABMkQFtlhYJXerYcPJN3WNRHlEyg7/9INRmg8L0p4X//ELdFHgDqdpQxBWlyMpiaBBLNZ9XhM2tX+QWKv+kwmUIyM9BF6q0D2anORbTjBlCbeqBsKXKRDJrpKIxQ+9UKz3hUMu+qT6SXkWcSErmnyhuRnW/5oDfnyrI2/jdTYNXBHPcyWL/KN09kws2tIFr+EdsYYxTs9CdVjW86vP3zFVFZb4E9IpuYJaEOvexgFEvU1G5m/1l8Wkb6YZzbJTrVw5hHnRcFdwBoAHK7cppifoOzpwZQ2E/X0laPvuyj9hWCHFjEVmabAhD/R2kjeSujtbmiEA4Mrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DB4irmaGsLrNw968AkoqxufXa1FXjHqMsMSgbafPtVk=; b=uuGWEpL9T+xNAN6gdThLfJFm7GoXiVnvbNfpik2bFFe+gD/Yip6dMjrTsTmRLuoe4PwgxepNMeRFK/4eBjpPFxeaph3lCnxafqWlMzK1Tq6o81dYQ90EZ6jbIIXBGJIjJG0wD6AJq3tCr72C7Rycb9q0T7qQs3hTFXJ8YTjojSg= From: Luca Fancellu To: Julien Grall CC: Stefano Stabellini , Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYxC5uizhN+hjMF0m2RbBlUt+pVq3W1+wAgAAxHYA= Date: Fri, 9 Sep 2022 12:35:54 +0000 Message-ID: References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> <34ae5402-799e-1c43-7ab2-6e8935471cc2@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|DU0PR08MB8017:EE_|VE1EUR03FT043:EE_|DBAPR08MB5832:EE_ X-MS-Office365-Filtering-Correlation-Id: c2cad784-751d-4e8a-57b1-08da925fdc39 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ar7ci7u0pSpS4FyP2TDY2qydeEtLrOUF1QoSLWcS/mB3m55VVac99Zr2cBWUoPIdjudmhlwq5uuPhU6pUPu9lfHoJw20K+xtPs+6bwZjMXo9vlzeQAUJXXuGtmWuVhSOzBkFvn5WZ/j8cxPAt6Zr4v6L4aotFNb2JzX47VhR1wJhLAeLJ+GyxBOGogbU4B4TzpRDyv4vPNTMgpJZ7Evo3tW0iqQ7yu2oQrvH81NGTLWR6XyIl4VVrLm2L3FIWRS72eO5E7vcpP6ZJ21vTtCieGjr4+N9IB4eWT6kaUn9sehFZBk4LEO65kOERfoq29CdXShW/B5sCGPcNUe9ZD8KlQn8oLuH43fn3m/X9iI04yi5y9RoVdm7rGGlYPYxLfyQNO3mNVS86m4s9Y+Ii2Vz86aYh/gXvyHrCuuvQEu5zw+rmvIagU3BdXFdUoq6WfYwycIi/d9Jt9Vz2Sx1IfUDSclRMm6m+ZOcLEKFnfsS9fxFl4DKKsnjIVf6igiapfEvW0dsqMBfnNOP5t6yMh9bW8/qvSYKczptjsroeS0zqc6fveso2n8iDHOfsSgLcJjE9U6JHkRIyVUE/FqBerYN+oyN6TXICODA1AsGoebi1lqd/RK4mTpzeQZaVCcX+f8o4M+Uu3ysEqKJRM/LzLGDeEhM+MTtBLZhN2EWCD5y/SW78cz3bcqTJpDSk9oWmA7FUSrD1Or2mI7sDwBXT6rAE0OOMalNPhze64XImSy2wYWp3Iq1e3+7Dmog8miLQtc3uSiSi9Vm1rGfzug0b/vK+Pph36MRx5tDndeHTltpNyk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(2616005)(53546011)(5660300002)(186003)(66476007)(66556008)(91956017)(66446008)(66946007)(8936002)(8676002)(64756008)(4326008)(2906002)(76116006)(6506007)(83380400001)(26005)(6512007)(33656002)(36756003)(86362001)(41300700001)(478600001)(6486002)(38070700005)(38100700002)(54906003)(316002)(6916009)(71200400001)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <4B2069437F348C4CBCD60DB5F2FD7E6A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8017 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 198c6c72-bb0f-4dc6-4749-08da925fd6bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RhpBNdR/odj9m+FPRgFAfHjHDhpSp9iIBn7JiQJtSTG34OmzYPk9YmGWypgD0u9t25nlDUpl6DqQ2wdpl56uR1sokvmYeRxV9LSnMA2PqJ+F7771Nbjql+nI1aIM5TfDDSUfKfurSJgQ8DZKb7YhS5KqFkQbAZLR1wXcuNvwwgTDCTiMUmLnakY2KMOHb+gDy55mms1Ot8+qLQ6NB8qeSzz/hP3wKEcgoUjU5zJIb06Gx+ghO2weXuPkld8plzZHpjB08s/0ABTDzViFsjEKRTWkC+DZ+b2IqI9KciBoe6zFq5DoyczeSZKcd3VHjd1w3a/pjnZ5zc22jyUkF9FVSS2tWvGtczZ0PnnzxtjSIHiqpqa8Z2G6mmLkWilqMURuWy6h+G0wMmz6BGPrF5GdNvjRj/bO1f7ULd4oObj1W0ce7rkwVcHEfQ9HYISyR1ykJtGbZlbub4mkcGLmgagfs45kziI6vK43eBjLOg0SU7+U6YVjoPDqE+QOTO78d3f+K1TtZoyKX8t7ofiqOMmNFkWiD9tl3RilA1/2neBCSD0BkWmQW6/cQ3zKPPWT4EXILEqwFaBe/ywbNzLOaGPsPPmbA9TMX6IUuwoD18v4lf5YWMJseZGKmT6Fw2A6BtU95inwN5ywvb6P9Ko4muVFd4/YmdJhrBlsDU8dh+1JFimDH8nfpD3ZYS0ww+xpS4MRqqh1to6LuryBYV5aR78L2Zk7lWxakp01AHuJQCPMS2+LzOZkM7jz6c+JS8VAPu0iee5iow/czGGliUTDZKGL6w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(82740400003)(70206006)(70586007)(36860700001)(478600001)(86362001)(6486002)(40460700003)(356005)(54906003)(316002)(81166007)(8676002)(4326008)(40480700001)(53546011)(8936002)(6506007)(41300700001)(2616005)(47076005)(82310400005)(6862004)(186003)(36756003)(26005)(5660300002)(6512007)(33656002)(2906002)(336012)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 12:36:03.8921 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c2cad784-751d-4e8a-57b1-08da925fdc39 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5832 DQoNCj4gT24gOSBTZXAgMjAyMiwgYXQgMTA6NDAsIEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5k Lk1hcnF1aXNAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBKdWxpZW4sDQo+IA0KPj4gT24gOSBT ZXAgMjAyMiwgYXQgMTA6MjcsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0K Pj4gDQo+PiBIaSwNCj4+IA0KPj4gT24gMDkvMDkvMjAyMiAwODo0NSwgQmVydHJhbmQgTWFycXVp cyB3cm90ZToNCj4+Pj4gDQo+Pj4+IEl0IHNob3VsZCBiZToNCj4+Pj4gDQo+Pj4+IC8qDQo+Pj4+ ICogVE9ETzoNCj4+Pj4gKg0KPj4+PiANCj4+Pj4gSSB0aGluayB0aGlzIGlzIGdvb2QgdG8gZ28u IFRoZSB0d28gbWlub3Igc3R5bGUgaXNzdWVzIGNvdWxkIGJlIGZpeGVkIG9uDQo+Pj4+IGNvbW1p dC4gSSBoYXZlbid0IGNvbW1pdHRlZCB0byBnaXZlIEp1bGllbiAmIEJlcnRyYW5kIGFub3RoZXIg Y2hhbmNlIHRvDQo+Pj4+IGhhdmUgYSBsb29rLg0KPj4+IEkgdGhpbmsgdGhhdCBpdCBpcyBvayB0 byBmaXggdGhvc2Ugb24gY29tbWl0IGFuZCBJIGFtIG9rIHdpdGggdGhlIHJlc3Qgc286DQo+Pj4g UmV2aWV3ZWQtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4N Cj4+IA0KPj4gVGhpcyBzZXJpZXMgZG9lc24ndCBidWlsZCB3aXRob3V0ICFDT05GSUdfU1RBVElD X1NITToNCj4+IA0KPj4gVVBEICAgICBpbmNsdWRlL3hlbi9jb21waWxlLmgNCj4+IFhlbiA0LjE3 LXVuc3RhYmxlDQo+PiBtYWtlWzFdOiBOb3RoaW5nIHRvIGJlIGRvbmUgZm9yIGBpbmNsdWRlJy4N Cj4+IG1ha2VbMV06IGBhcmNoL2FybS9pbmNsdWRlL2FzbS9hc20tb2Zmc2V0cy5oJyBpcyB1cCB0 byBkYXRlLg0KPj4gQ0MgICAgICBjb21tb24vdmVyc2lvbi5vDQo+PiBMRCAgICAgIGNvbW1vbi9i dWlsdF9pbi5vDQo+PiBDQyAgICAgIGFyY2gvYXJtL2RvbWFpbl9idWlsZC5vDQo+PiBhcmNoL2Fy bS9kb21haW5fYnVpbGQuYzogSW4gZnVuY3Rpb24g4oCYbWFrZV9zaG1fbWVtb3J5X25vZGXigJk6 DQo+PiBhcmNoL2FybS9kb21haW5fYnVpbGQuYzoxNDQ1OjE6IGVycm9yOiBubyByZXR1cm4gc3Rh dGVtZW50IGluIGZ1bmN0aW9uIHJldHVybmluZyBub24tdm9pZCBbLVdlcnJvcj1yZXR1cm4tdHlw ZV0NCj4+IH0NCj4+IF4NCj4+IGNjMTogYWxsIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJy b3JzDQo+PiBtYWtlWzJdOiAqKiogW2FyY2gvYXJtL2RvbWFpbl9idWlsZC5vXSBFcnJvciAxDQo+ PiBtYWtlWzFdOiAqKiogW2FyY2gvYXJtXSBFcnJvciAyDQo+PiBtYWtlOiAqKiogW3hlbl0gRXJy b3IgMg0KPj4gDQo+PiBUaGlzIGlzIGJlY2F1c2UuLi4NCj4+IA0KPj4+Pj4gKyAgICAgICAgICog LSB4ZW4sb2Zmc2V0OiAoYm9ycm93ZXIgVk1zIG9ubHkpDQo+Pj4+PiArICAgICAgICAgKiAgIDY0 IGJpdCBpbnRlZ2VyIG9mZnNldCB3aXRoaW4gdGhlIG93bmVyIHZpcnR1YWwgbWFjaGluZSdzIHNo YXJlZA0KPj4+Pj4gKyAgICAgICAgICogICBtZW1vcnkgcmVnaW9uIHVzZWQgZm9yIHRoZSBtYXBw aW5nIGluIHRoZSBib3Jyb3dlciBWTQ0KPj4+Pj4gKyAgICAgICAgICovDQo+Pj4+PiArICAgICAg ICByZXMgPSBmZHRfcHJvcGVydHlfdTY0KGZkdCwgInhlbixvZmZzZXQiLCAwKTsNCj4+Pj4+ICsg ICAgICAgIGlmICggcmVzICkNCj4+Pj4+ICsgICAgICAgICAgICByZXR1cm4gcmVzOw0KPj4+Pj4g Kw0KPj4+Pj4gKyAgICAgICAgcmVzID0gZmR0X2VuZF9ub2RlKGZkdCk7DQo+Pj4+PiArICAgICAg ICBpZiAoIHJlcyApDQo+Pj4+PiArICAgICAgICAgICAgcmV0dXJuIHJlczsNCj4+Pj4+ICsgICAg fQ0KPj4+Pj4gKw0KPj4+Pj4gKyAgICByZXR1cm4gcmVzOw0KPj4+Pj4gK30NCj4+Pj4+ICsjZWxz ZQ0KPj4+Pj4gK3N0YXRpYyBpbnQgX19pbml0IG1ha2Vfc2htX21lbW9yeV9ub2RlKGNvbnN0IHN0 cnVjdCBkb21haW4gKmQsDQo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdm9pZCAqZmR0LA0KPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCBhZGRyY2VsbHMsIGludCBzaXplY2VsbHMsDQo+Pj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IG1lbWluZm8gKm1lbSkNCj4+ Pj4+ICt7DQo+Pj4+PiArICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPj4gDQo+PiAuLi4gdGhl cmUgaXMgYSBtaXNzaW5nICdyZXR1cm4gLUVOT1RTVVBQJyBoZXJlLiBXaGlsZSB0aGlzIGlzIHNp bXBsZSBlbm91Z2ggdG8gZml4LCB0aGlzIGluZGljYXRlcyB0byBtZSB0aGF0IHRoaXMgdmVyc2lv biB3YXMgbm90IHRlc3RlZCB3aXRoICFDT05GSUdfU1RBVElDX1NITS4NCj4+IA0KPj4gQXMgdGhp cyBpcyB0aGUgZGVmYXVsdCBvcHRpb24sIEkgd2lsbCBub3QgY29tbWl0IHVudGlsIEkgZ2V0IGNv bmZpcm1hdGlvbiB0aGF0IHNvbWUgc21va2Ugd2FzIGRvbmUuDQo+IA0KPiBUaGlzIGlzIGEgY2Fz ZSBvdXIgaW50ZXJuYWwgQ0kgc2hvdWxkIGhhdmUgZ29uZSB0aHJvdWdoLg0KPiBMZXQgbWUgY2hl Y2sgYW5kIGNvbWUgYmFjayB0byB5b3UuDQo+IA0KDQpIaSBKdWxpZW4sDQoNClRoYW5rcyBmb3Ig Y2F0Y2hpbmcgaXQsIGluIHRoaXMgY2FzZSBJIGNhbiBjb25maXJtIHRoYXQgdGhlIHByb2JsZW0g d2FzIHRoYXQgd2UgYXJlIGJ1aWxkaW5nIHdpdGggQ09ORklHX0RFQlVHIGVuYWJsZWQsIEkgZG9u 4oCZdCBrbm93IHdoeSBHQ0MgZG9lc27igJl0IGNvbXBsYWluIHdoZW4NCnlvdSBoYXZlIF9fYnVp bHRpbl91bnJlYWNoYWJsZSgpIGluIHRoYXQgZnVuY3Rpb24gd2l0aG91dCBhbnkgcmV0dXJuIHZh bHVlLCBpdCBkb2VzbuKAmXQgZXZlbiB0aHJvdyBhIHdhcm5pbmcuIENvdWxkIGl0IGJlIGNvbnNp ZGVyZWQgYSBidWcgaW4gR0NDPw0KDQpCdWlsZGluZyBYZW4gd2l0aG91dCBDT05GSUdfREVCVUcg aW5zdGVhZCBzaG93cyB1cCB0aGUgZXJyb3IgeW91IGZvdW5kLg0KDQpJbiB0aGlzIGNhc2UgdGhp cyBjaGFuZ2Ugd2lsbCBmaXggdGhlIHByb2JsZW0sIGRvIHlvdSBhZ3JlZSBvbiBpdD8NCg0KZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21h aW5fYnVpbGQuYw0KaW5kZXggOGM3N2M3NjRiY2YyLi5jNWQ2NmYxOGJkNDkgMTAwNjQ0DQotLS0g YS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCisrKyBiL3hlbi9hcmNoL2FybS9kb21haW5f YnVpbGQuYw0KQEAgLTE0MzksNiArMTQzOSw4IEBAIHN0YXRpYyBpbnQgX19pbml0IG1ha2Vfc2ht X21lbW9yeV9ub2RlKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsDQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IG1lbWluZm8gKm1lbSkNCiB7DQogICAg IEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KKw0KKyAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQogfQ0K ICNlbmRpZg0KDQpJcyBpdCBzb21ldGhpbmcgdGhhdCBjYW4gYmUgYWRkcmVzc2VkIG9uIGNvbW1p dD8NCg0KQ2hlZXJzLA0KTHVjYQ0KDQoNCj4gUmVnYXJkcw0KPiBCZXJ0cmFuZA0KPiANCj4+IA0K Pj4gQ2hlZXJzLA0KPj4gDQo+PiAtLSANCj4+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:46:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:46:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404301.646725 (Exim 4.92) (envelope-from ) id 1oWdOb-00054Z-Fo; Fri, 09 Sep 2022 12:46:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404301.646725; Fri, 09 Sep 2022 12:46:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdOb-00054S-BA; Fri, 09 Sep 2022 12:46:09 +0000 Received: by outflank-mailman (input) for mailman id 404301; Fri, 09 Sep 2022 12:46:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdOa-00054M-Cz for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:46:08 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2081.outbound.protection.outlook.com [40.107.105.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e8ced8b-303d-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 14:46:05 +0200 (CEST) Received: from DB6PR07CA0060.eurprd07.prod.outlook.com (2603:10a6:6:2a::22) by AS4PR08MB8244.eurprd08.prod.outlook.com (2603:10a6:20b:51d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 9 Sep 2022 12:46:03 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::79) by DB6PR07CA0060.outlook.office365.com (2603:10a6:6:2a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.7 via Frontend Transport; Fri, 9 Sep 2022 12:46:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 12:46:03 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Fri, 09 Sep 2022 12:46:02 +0000 Received: from ba5f86f15cb1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8807125D-B82F-43D7-9A2B-45C568A52E59.1; Fri, 09 Sep 2022 12:45:56 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ba5f86f15cb1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 12:45:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5693.eurprd08.prod.outlook.com (2603:10a6:800:1a5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 12:45:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1415:7141:512f:e787%3]) with mapi id 15.20.5588.011; Fri, 9 Sep 2022 12:45:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e8ced8b-303d-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NWhvXc6uxzwULV8bsvMUH4F9GV+XYTX0zGKPzEUPEVqXZf7EBYyjIeyiYA6aIHTerLv0vd+H93/CnbFUryvndGePLssUJ+5IQJ2vE2RzDaioyEMrYDK8f0q+waMzbjkRmVp53j57xGKczstH0xuIhaqxS2nH4nBZZpDfypFMs/o/827EVZ7QMlAXLJIPq+M+fiz0H4ukqFM8vaHbjxHEgnhldPZLiUKvRC/ppT8KTQAtvxPZ2BijJdxVqqw3agqMNTfjd2J5Hk3V2PysmelQucDy57HgmQcpIc4vrEDq08RuaVfxOYbY4IY9y6P5mD+SFzJJpBQ3QfO8Gzu5KbT8mA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K/1kBPCV7YnVAfRM5Yr2pA6ovbc5i62EGWqanErDBdI=; b=Bn0MrMc2x5uW4aq4ShGqr6KAnoo1q1cBF9yzfVEDT818/OZoYw/Lth36oRKdeoZM47Qb4orY9knryvzzF5rege3ghpdeJwsX/SwoAf5C4pCAeHwK8rf1NnyzphEl92o2PLzMGaD7oOJ3pkpNgnvRVSeC9huVgeqhhFBMXme68pQapu2+GqJb6NOow+9A/63jgSpyo2tfHiH9zwtgM+oyI9L4diOULyGNxukoWvgt5GycxqLXB4Ciw3+UQVcKWLpl7XA75AyE1EBsJM6MaRzrUYqL2cmropRT8mwCLPAWa593TQqIwS3Wp74sjstpzjyHj/CWi3QDaGziMKaHQByyZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K/1kBPCV7YnVAfRM5Yr2pA6ovbc5i62EGWqanErDBdI=; b=BYW3kehakvYU8vpMFKHFht7FiCsD7LffaQbyTZDV2xpC2CJum3EF3UtPFGma5YETf5czDvPBUzSrDvRVAmFELobi5ogaQLFkCKevc84/dpNe5X60LLXDrVnqF6Q4TgLU71GnvTgOKkXOmWazKr+87W0mblzs36velIERRtQCq6Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haQvBckKCc2wahboUWH9GWVeEwkVT68e2/R1dZWp+vkjImUMJpqsis/jpNTobgvN4fWeVpPB4hqh8RGpj8YCgW4bpLXZ0FISbp+ITbSLhsc6JxOV5FMa+joye5hIXWYRycRd4q+U1LuvceGpdfGr2hqIiysoMvKIrqS44D0K2umhmx+xe/9N2VemTNOxRVkY6A2pQpttfrwSoAkBkpucc7lzOfLsDwGx0VVYi+CW0cjB+WgsdJ75c6AdX2Mlmv3URxG3shhE3eAjKsQVZobhG1YjMgUAAuq9mmh9gz+NoXFMVdpImKn3IP9VUIc649lX/LdXPjClF1niABY69VMgRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K/1kBPCV7YnVAfRM5Yr2pA6ovbc5i62EGWqanErDBdI=; b=CV8UMEPeYGP1vJiZmEWU8ln6BVY7jk8qAOJK+v0GAJgNe0szYrX39uKwhwBxAknash77I8UEI/bUoTVTr7XxvvxZhJl8cMwVrneC2Imue/BVpqIaPkROf/jP5stAowQfoqyiloICke6yD/sgJfV07/pQL+/Oo6QYHMV2UuPWJQwtUea17o7WKOZWe9T59Ix5+6B8AMsbWYc3xi4HMxsGXAauV5gd5gzfDHBXZHfl/Q9aLLMbkMyFR2SILJI/B7bDjRTtONwzIMxxYMV2UBYweSJlLzsU0eDAPxOPCxXW0pqIIkV3kH91HEtVOwQJBf26L0KfEnGZTIIlY/MqAyJuNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K/1kBPCV7YnVAfRM5Yr2pA6ovbc5i62EGWqanErDBdI=; b=BYW3kehakvYU8vpMFKHFht7FiCsD7LffaQbyTZDV2xpC2CJum3EF3UtPFGma5YETf5czDvPBUzSrDvRVAmFELobi5ogaQLFkCKevc84/dpNe5X60LLXDrVnqF6Q4TgLU71GnvTgOKkXOmWazKr+87W0mblzs36velIERRtQCq6Q= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "jandryuk@gmail.com" Subject: RE: [PATCH] xsm/flask: adjust print messages to use %pd Thread-Topic: [PATCH] xsm/flask: adjust print messages to use %pd Thread-Index: AQHYxDGm1l2kl9jZnEi0PeM8zmcB0K3W20YggAAhgoCAAAz+wA== Date: Fri, 9 Sep 2022 12:45:54 +0000 Message-ID: References: <20220909095012.4251-1-dpsmith@apertussolutions.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E5B11A8D3677D046A1DCA7536C7AF56E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 684083c7-180c-4797-0c13-08da92614140 x-ms-traffictypediagnostic: VE1PR08MB5693:EE_|DBAEUR03FT014:EE_|AS4PR08MB8244:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jIt4FdN4Bvnm8SJ1peHu9qEC2yPFg15g+sU26bJ2tijlq4QXRTtN8kgqB1+4rJhX8JOGemUnMGMg2FYNBuZjRle7vQ2fp0t/9OppETg05vuQU+6EAOq6NlzomlqZgEmYXNIEKz53rXaYj18cTGmiUHoLQ83Yi5QiwluMKLCLAzOYVJTGW/031CLRWlMZ2gnhxqGrYjJHU315XfBJ4cCtj9a3AF3i4htFsLeew3ctx8ToQb1szlSNXlxl7+GGuhkz7RU8UEnPnP/zNOZfGsJQ5cI+gzfU8F6iH2Wot6EJDJS9xWedyIRtExA14ptqessvyGWfLPhFHzJsUp63VG6RAlT55BywCZPfh4NJGvR0ieV5DZlWuOQJykxjlazuJzlM7wiyz0pX23JtqjjEo+X7QlPCaaT6lYntiMXzrptypeLza0bmucFNQyfV2RFKpY+Wgq/92OkmCMm2Cfd4q3C5C5UIqeEAX7jFvj0fJx1T4C1W5WxE1B5gQ5X69JLfX6UJnCngB6CRRVYFhRCz0jDg310SL6nSlq2Wk4ArBwWdZ12cEno3Lk9SVbJqWg1gYE04fQlJkhaBqMITIH5i2OWsAeECQP3VdMojVLb0I8I0W66jmHihH1KT/1KkFB26St9Tnzhp/XtG50gHPf+NusOHCum9r12q2qZQk2om8OO5qnI8ZjcnryNUiflPOx1xlZoCbPqYeN0HfIYsEu75eiu/K7VfztN2JzZEmcEoHk5xyk/sqtW+J9UWOmdgTWGPj8IXf6FTZLD6O9N2SQq8LP0NUg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(9686003)(186003)(7696005)(26005)(71200400001)(6506007)(478600001)(41300700001)(83380400001)(4744005)(15650500001)(2906002)(52536014)(8936002)(5660300002)(110136005)(55016003)(316002)(8676002)(66946007)(64756008)(4326008)(76116006)(66476007)(66446008)(66556008)(38070700005)(122000001)(38100700002)(86362001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5693 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 08984172-654d-4f2e-ffcd-08da92613c4c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JD2eM2PHRwHl+sM6+i7427o7BrPnCNveuNH6eoEbeqD0JNF3c5hpdhL6PN29CQo4AZgo6V7elOTDRFRcctrKOHmqDsIGImncVd6LPz55vgIEZo4QQlcOHLuFul9d6TJ06jfdZMrPHyyBfcshx1HBgPCVHCGBeGEATiY3NQ1aF64izcv7LHF20B5Kjwp1ts4Ats//GbfYSiQxM8Age9O7+7y1LRrtSqCbB+cM3KBIGAE2uSeAxCZgehneYeo/Eqx0Se0jm79VpI749R7bqKeWnRKje0KyhmJfXRNv+ompIknBYtoEqcf/DHS4UOPbf943oRl/4TRP+jWLscD6jwVxM6fvA9ThJ4GV49tDXFCRhMEqNMJTeULvVTrJ+vRLCkhXpC2+oVlDbSYFjWzMk1P7G3Awt0f34Rqe08xQJnsJzlF0+tvA54JxQ+tuCbX/y/qdbTfOGyLVyxR6nCd07o5/y1ywgPAbaYgfCi/CnVbC+KZIoxqAoMspm6GW320Uk/p8zkkA1jJhLM13mHDtVoM9y8qh3tRrv7XK111Yc+OHdvm/Cr+3VGq/+BfWuQ6HDHZe2aozSDzLPi1ZDRyd72V+ej9zh/gXKNWh6fT5OKEo+BHNzAE9c24YNapru4GKcffX56yW7UDeRwdqjNzXlEsqDNMh8/vvUQe8udDLGNqWyGlI+lUpVnYiumCaBCSm4b0ZtIfadJGeMu9P7WRInUZJzjsrBsGdzkreJ3pPgBff5SraiTY3IdKzrxedrjPGyiUOPLT6OZ+5ec+LZBaIytwvXg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(376002)(39860400002)(40470700004)(36840700001)(46966006)(83380400001)(47076005)(40480700001)(8936002)(5660300002)(52536014)(4744005)(9686003)(41300700001)(15650500001)(55016003)(2906002)(7696005)(33656002)(86362001)(336012)(478600001)(107886003)(26005)(6506007)(356005)(81166007)(82740400003)(36860700001)(186003)(70206006)(4326008)(110136005)(82310400005)(40460700003)(8676002)(70586007)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 12:46:03.0389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 684083c7-180c-4797-0c13-08da92614140 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8244 SGkgRGFuaWVsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IERhbmll bCBQLiBTbWl0aCA8ZHBzbWl0aEBhcGVydHVzc29sdXRpb25zLmNvbT4NCj4gPiBUaGlzIHNob3Vs ZCBhbHNvIGJlIGZpbmUgdG8gbWVyZ2UgaW4gNC4xNywgYnV0IGZvbGxvd2luZyB0aGUgZGlzY3Vz c2lvbiB3aXRoDQo+ID4gSnVsaWVuIGFuZCBKYW4gSSB0aGluayBwcm92aWRpbmcgYSBSZWxlYXNl IGFjayB3b3VsZCBsZWFkIHRvIGNvbmZ1c2lvbi4uLg0KPiANCj4gSSB3YXMgaG9waW5nIGl0IHdv dWxkIGdvIGluLCBidXQgdW5kZXJzdGFuZCBpZiBpdCBpcyBrZXB0IG91dC4gSSBoYXZlIGENCj4g bGlzdCBvZiBjbGVhbi11cHMgb2YgdmFyeWluZyBzaXplcyBmb3IgWFNNLCB3aXRoIHRoaXMgb25l IGFjdHVhbGx5IGJlaW5nDQo+IHJlcXVlc3RlZCBieSBzb21lb25lIGVsc2UuIEkgZmlndXJlZCBp dCB3YXMgYSBzaW1wbGUgb25lIHRoYXQgY291bGQgYmUNCj4gZG9uZSBxdWlja2x5IGFuZCBtaWdo dCBiZSB3b3J0aCB0cnlpbmcgdG8gZ2V0IGl0IGludG8gdGhlIHJlbGVhc2UuDQoNClNvcnJ5IEkg c2hvdWxkIGhhdmUgYmVlbiBtb3JlIGNsZWFyLiBJIGFtIG5vdCBwcm92aWRpbmcgdGhpcyByZWxl YXNlIGFjaw0KdGFnIGlzIG5vdCBiZWNhdXNlIEkgYW0gYmxvY2tpbmcgdGhpcyBwYXRjaCwgYnV0 IGZvbGxvd2luZyB0aGUgZGlzY3Vzc2lvbg0KdGhlIHJlbGVhc2UgdGFnIGlzIHN1cHBvc2VkIHRv IHRha2UgZWZmZWN0IGFmdGVyIHRoZSBjb2RlIGZyZWV6ZSAoU2VwLiAzMCkuDQoNCkFzIEkgYmVs aWV2ZSB5b3UgYXJlIHRoZSBYU00gbWFpbnRhaW5lciBzbyBpZiB0aGlzIHBhdGNoIGFuZCB0aGUg cmVzdCBvZg0KdGhlIGNsZWFudXAvYnVnZml4IHBhdGNoZXMgY2FuIGJlIHByb3Blcmx5IHJldmll d2VkLCB0aGVzZSBzaG91bGQgZ28NCmludG8gdGhlIHJlbGVhc2Ugb2YgY291cnNlLg0KDQpLaW5k IHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiB2L3IsDQo+IGRwcw0K From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:53:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:53:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404308.646736 (Exim 4.92) (envelope-from ) id 1oWdW4-0006ve-7M; Fri, 09 Sep 2022 12:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404308.646736; Fri, 09 Sep 2022 12:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdW4-0006vX-4W; Fri, 09 Sep 2022 12:53:52 +0000 Received: by outflank-mailman (input) for mailman id 404308; Fri, 09 Sep 2022 12:53:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdW2-0006vQ-HY for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:53:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72c9561b-303e-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 14:53:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE5EA1F8DA; Fri, 9 Sep 2022 12:53:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 670FA139D5; Fri, 9 Sep 2022 12:53:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D6rjF1w3G2PVNQAAMHmgww (envelope-from ); Fri, 09 Sep 2022 12:53:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72c9561b-303e-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662728028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ywj87vOwTKhT5iZ677cNQ2Fr/sHl0+j5C9vmNgewlYk=; b=VUeiWhP8lEn+qG5qfDVDxma3RCTLiKgJ46VzrYNT1RczaXbLHtPRwlcsvPFML7xYKeUUWd T/fGb42kZC5pMy9LRB3x6+q8J0CbWwvmEHaTMqLYdS1lU+96UEeIntlXfd94lm70UIiPux DEhPe+23x6CMjXxu4W6xp0WFUKNXSQ4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH v3] xen/gnttab: fix gnttab_acquire_resource() Date: Fri, 9 Sep 2022 14:53:47 +0200 Message-Id: <20220909125347.25734-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") was wrong, as vaddrs can legitimately be NULL in case XENMEM_resource_grant_table_id_status was specified for a grant table v1. This would result in crashes in debug builds due to ASSERT_UNREACHABLE() triggering. Check vaddrs only to be NULL in the rc == 0 case. Expand the tests in tools/tests/resource to verify that using XENMEM_resource_grant_table_id_status on a V1 grant table will result in EINVAL. Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich # xen Release-acked-by: Henry Wang --- V2: - rework (Jan Beulich, Julien Grall) V3: - added test support (Andrew Cooper) --- tools/tests/resource/test-resource.c | 11 +++++++++++ xen/common/grant_table.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c index 189353ebcb..71a81f207e 100644 --- a/tools/tests/resource/test-resource.c +++ b/tools/tests/resource/test-resource.c @@ -106,6 +106,17 @@ static void test_gnttab(uint32_t domid, unsigned int nr_frames, if ( rc ) return fail(" Fail: Unmap grant table %d - %s\n", errno, strerror(errno)); + + /* Verify that the attempt to map the status frames is failing for V1. */ + res = xenforeignmemory_map_resource( + fh, domid, XENMEM_resource_grant_table, + XENMEM_resource_grant_table_id_status, 0, 1, + (void **)&gnttab, PROT_READ | PROT_WRITE, 0); + if ( res || errno != EINVAL ) + fail(" Fail: Map status not failing with EINVAL %d - %s\n", + res ? 0 : errno, res ? "no error" : strerror(errno)); + if ( res ) + xenforeignmemory_unmap_resource(fh, res); } static void test_domain_configurations(void) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index ad773a6996..fba329dcc2 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4140,7 +4140,7 @@ int gnttab_acquire_resource( * on non-error paths, and hence it needs setting to NULL at the top of the * function. Leave some runtime safety. */ - if ( !vaddrs ) + if ( !rc && !vaddrs ) { ASSERT_UNREACHABLE(); rc = -ENODATA; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 12:59:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 12:59:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404315.646747 (Exim 4.92) (envelope-from ) id 1oWdbP-0007eu-Qk; Fri, 09 Sep 2022 12:59:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404315.646747; Fri, 09 Sep 2022 12:59:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdbP-0007en-O0; Fri, 09 Sep 2022 12:59:23 +0000 Received: by outflank-mailman (input) for mailman id 404315; Fri, 09 Sep 2022 12:59:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdbO-0007eh-H1 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 12:59:22 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38e5d4fc-303f-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 14:59:21 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id lc7so3890794ejb.0 for ; Fri, 09 Sep 2022 05:59:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38e5d4fc-303f-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=674w3U9avgHzrGoN6WaCQAkSakf0Zj1lCT/Xa1vsZf4=; b=EZCakn1YMqJg/cfQqOayqzhyVZTGhNZoBLNmMlrnnOZEcoUgiW/IYOYQfJEkeIp9kp ls8XPXi9wgFSbzQZKCDnN1cm5+H7CIdFSZT9xhlZ3IgIxh9NPd0lL8zQ6gXcRMJrSi/i OnieJtD+q33packMXUvLGdkiBUQ3azLndoG6CbIUwKbT4AOjczCWHGzS/N1KyVRJgrH8 919LNOvYMD+w1uuJ/SFV9A8bZoEtYhskkHhl9X/g+GpzpC3tp7CPlvxcKbDwFutvExfG /2crkECt8L+efOL16aA3aXJbrxSiEXwb8d7L8Nqdw7JbZZuO3Zd1xcPBvThks+tvtRDr GTCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=674w3U9avgHzrGoN6WaCQAkSakf0Zj1lCT/Xa1vsZf4=; b=zgSGQZ/L0MqbJ8g10oaSafVhkXWSrlyVvaJOAiqy2Mun1JQbOIM19hCjXdNl/lSPCS Q5ahOCYmkfcgty3Kt1rQAm058igvGWk/dglwv91ngBguaXfZ2WTwToOslvXkzJgrr779 TQ2uAw72ZIGGI9I82Lj8sjipU1oZqyNwGrH/K4DBhWB9AH5p1b3LCzyVfa9kRUDZE9RA nyVBbueS13s7W+t0kL0KDKXp5/Jg12k4jcgEN4J0iyssMb1PZbGQiaT6jcBydpW21sPy qgqOLVwtUBK6hvm+dm3ybH+1E4sPrzJmNoWlnYD4Ul3cuH4uzmhA8kM30uTzVQkyul8w PlQQ== X-Gm-Message-State: ACgBeo3GvglcC+JVjo6XWfvmPywPtsV5bjhByfT3D2E7HNx5/Y6kmNCo Za3VmpM+8WySqWV5PS4C9J2NZj0PUCukacCl2hA= X-Google-Smtp-Source: AA6agR4MArzVlTIhaEQx7+xFjEElXgWNtKOj+MRYiXkG//atBEjTJBQP7+yM/7DQoNzm0NdawoNOvBdl8LB+m3sQvQc= X-Received: by 2002:a17:907:94c2:b0:73d:c534:1ac0 with SMTP id dn2-20020a17090794c200b0073dc5341ac0mr9778011ejc.461.1662728360989; Fri, 09 Sep 2022 05:59:20 -0700 (PDT) MIME-Version: 1.0 References: <20220908195113.218201-1-jandryuk@gmail.com> <20220908195113.218201-3-jandryuk@gmail.com> In-Reply-To: From: Jason Andryuk Date: Fri, 9 Sep 2022 08:59:09 -0400 Message-ID: Subject: Re: [PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross Content-Type: text/plain; charset="UTF-8" On Fri, Sep 9, 2022 at 6:19 AM Anthony PERARD wrote: > > On Thu, Sep 08, 2022 at 03:51:12PM -0400, Jason Andryuk wrote: > > hvm_xs_strings.h specifies xenstore entries which can be used to set or > > override smbios strings. hvmloader has support for reading them, but > > xl/libxl support is not wired up. > > > > Allow specifying the strings with the new xl.cfg option: > > smbios=["bios_vendor=Xen Project","system_version=1.0"] > > I've tried something like: > smbios=['oem=foo=bar'] > And only "foo" is added to the smbios string. Shouldn't we allow users > to have '=' in their smbios strings? Yes, you are correct. split_string_into_pair() isn't suitable since it terminates at the second '='. Also, we probably don't want to trim the strings to keep them unchanged, especially for any values. If a space-padded option name is provided, it'll show up in "xl: unknown smbios type '%s'" and the whitespace would be evident. hvmloader iterates through HVM_XS_OEM_STRINGS entries and stops processing when an entry is not found, or it is zero-length. So I think we should disallow zero-length values like "oem=" to avoid surprises. For example, smbios=["oem=A","oem=","oem=B"] would result in only oem-1 "A" making its way through to the guest. Your other comments sound good. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404323.646757 (Exim 4.92) (envelope-from ) id 1oWdnx-00029a-VC; Fri, 09 Sep 2022 13:12:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404323.646757; Fri, 09 Sep 2022 13:12:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdnx-00029T-Sb; Fri, 09 Sep 2022 13:12:21 +0000 Received: by outflank-mailman (input) for mailman id 404323; Fri, 09 Sep 2022 13:12:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdnw-00029N-Eg for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 13:12:20 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06218686-3041-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 15:12:17 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Sep 2022 09:12:07 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by PH0PR03MB6621.namprd03.prod.outlook.com (2603:10b6:510:b7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 13:12:03 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::10e9:90f9:f545:ab95]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::10e9:90f9:f545:ab95%4]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 13:12:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06218686-3041-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662729137; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9pojS8yM7yUoBtHmyd/FsjiEW8m7TUr4KatlgIq2TBA=; b=QkAfX9TCvAlyC9oTj5wZnKhuuwHKCZ7B4KhL8oqDsW4zbYvfzd9cE1m1 XXqhLCAL4yfGLj7bQp8Vz1mV7ILUIOqXBDZ9H24T8OWbteJEeUG6lSSv6 bGVxrEornM5M3Ej/C7MGvPIajiJtSz7LFixZJ3U1GJ58QZcv9bCeHgw35 o=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 79841761 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:n27Ie6JnfXNrPXAPFE+RPZQlxSXFcZb7ZxGr2PjKsXjdYENS0zUHx mUXXj2HMq2LazPzKNB2Ydiy80oB6MfQmIVmSQNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/Pb+Us11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE7OdTIHAPJdYkyNlcLXBi7 fEoDwEKcUXW7w626OrTpuhEoO0GdZOuEKZB/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H11z+mLGcwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPOmWbcrSz17gPJtS+8B94dSvqKzNhnmUGKlnQaOQAMU1Tu9JFVjWb7AbqzM Xc8+CU0qrMp3Fe2VdS7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebRwn0 EWY2ezgAzNHuaeQD3ma89+8sjeaKSUTa2gYakcsTwEI/t3iq4EblQ/UQ5BoF6vdpt/oHTD9x RiaoS54gK8c5eYQzLmy913DhzOqp7DKQxQz6wGRWXiqhj6Vf6agbo2srFTes/BJKd/DSkHb5 Sde3c+D8OoJEJeB0jSXR/kAF62o4PDDNyDAhVloHN8q8DHFF2OfQL28KQpWfC9BWvvosxezC KMPkWu9PKNuAUY= IronPort-HdrOrdr: A9a23:Wpq7i6jWGc1bubUUyMqz0gkC6nBQXioji2hC6mlwRA09TyX5ra 2TdZUgpHjJYVMqMk3I9uruBEDtex3hHNtOkOos1NSZLW3bUQmTTL2KhLGKq1Hd8m/Fh4xgPM 9bGJSWY+eAaGSS4/ya3OG5eexQvOVu8sqT9JjjJ6EGd3AVV0lihT0JezpyCidNNW977QJSLu vn2iJAzQDQAEg/X4CAKVQuefPMnNHPnIKOW296O/Z2gDP+9Q9B8dTBYmOl4is= X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="79841761" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncDpSqe8kViO1ZtpHeCXDqRZoogrvWMiXYXhXxJeVNEetGe1dJXR+JWOh6qHfZUJCpw+NlIodUg2tT4UymI0eixr/f9Tl7d5M5lBfGIjBMsJjz0gYfBTO7b+pd00KmjB6tW7ZrcYhxXy7QudpHZpLTqBSUpOqRfgxifPWPIXFDMU+K5M/aqu+fPapui6BozZYzSV7xZxsFQEHWYPxI5pWucinVB02hXlqi2u4RekNczPhTF0eI3LS+AwnN874vjwKKd14rORlTnYmBG1/S/vPEqHptj5kfjvygTZt7HP3CanRtMbhOc3PPuOfWZ/ElTeyXLSz8+MZ6rvZdXdxuxdtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9pojS8yM7yUoBtHmyd/FsjiEW8m7TUr4KatlgIq2TBA=; b=a3HazMSgOGIcm5RBK9x/Qkpbn81aZ6VRzkenInmDIAdIhUMntcAf6yf3u/T9fwROOiCZj98ihxFEWLCC6w2oal/N07G4qg4+9CwRoCM/jJPrNYmIXise0d+fSLK3TO7bN/SvsqIFWBf5ZwG+1qYvLiFCq5u20aa6ybg9IiUlwaV4ui85uey28UGuY4c8CuRFgfXTA84//t2c73otIUXuiKAQCbKGF2CI0ewKHbzzxYt5uYKGYgMQUdQr6SQy0xS/S+kVklkBDGmJiEyvrpHrJj6mI592ww7nR8MzWLJak4SGZ176TqUWvmg1+yNhlBVHzpR+Bdt9dQcHQKVoPxEGzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pojS8yM7yUoBtHmyd/FsjiEW8m7TUr4KatlgIq2TBA=; b=JNIxSheVh3k4lwrYXLPJhWC7NdDJCQXfG75DoynXOIM3szO+pssRmjHwp097H14qbeQYbttx3ea9zKZKoI652XL1rFYwiDWa3aIiDl8RD4M9i8rDcDcaFR8btWE912+w3CUp0W1vaMJhnQkiDvetxteHrQrFc7ZxuPyGGOE2zlQ= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , Wei Liu , Anthony Perard , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: Re: [PATCH v3] xen/gnttab: fix gnttab_acquire_resource() Thread-Topic: [PATCH v3] xen/gnttab: fix gnttab_acquire_resource() Thread-Index: AQHYxEs6aZ5V4BIu+E2gLbKrqRKb7K3XEukA Date: Fri, 9 Sep 2022 13:12:03 +0000 Message-ID: <903fe035-73ae-72cd-f721-1b418295a7c4@citrix.com> References: <20220909125347.25734-1-jgross@suse.com> In-Reply-To: <20220909125347.25734-1-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|PH0PR03MB6621:EE_ x-ms-office365-filtering-correlation-id: cbecc604-bda4-4736-aa9d-08da9264e311 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aoo2RfGVgAUEGCbKZL3Ks7ZUqU54K0JxnEe8nBk2vVKnVyiLGEJKqjlm08UgnccMNXWX/+pxzbOST/O1St6pXa7ToupWvgWrbcpI3idZp3eDgh5AeRwUZaAJe6UpyNOcfXVOg8uUGcumz+Jyjmy08AR/Lc/hupbNEgN4sdpadzAXffRwch39w3d5E/aM7ghNjbmffzpaAE//r/HtrSstVRBJrxGcVNKiswCjx/d70NcFY4Rt+HGMzEvQo7gg0kOh+rCt4lnyBCTIDiEHLV9Us83R9XnR9KpbkMpshkRNdd2vnrpwjQQDsL4FuupjgkxeQPMg9rLpuX5qR97ijAN1/lZB8DGvegvscCIQ/HyO+3wrB88U2TMF6v+b2/tS025asDLmjOResipgElUXCDalZ/8EqiT7OB0E+pqEhys3PAbE1GTLyRIfOXIZE66Wuh4eCSgVr7nqwI9RO4OCUb4Sw5YrJM7qGIF+LHupTtXaO8GQyMW70/GsWkYxmK2NaPN7rsqNiz+AeKa8m+wDj1tm6xuPHojYDFOdlknPQF43OYpTCAEVxHdfXHWPFLajQrDuhLmJpcS5dWR7VdaCATCwala4ugQIUo0+hks529CsLRB4ny1GKSryZ6oXFXCrRhfJQTgiUev2ELqZYq41HwXOmWc7Do0kjN6FAiO2cxlLqM3zQIknZ4wy6t9HBdaPDR2319XMS/HrKF5qq/ZBlBZEWfW+r/7JBdojRCwOQSUxDRbeecWH4Z0YF4yyyHa8/hBwGT7V9EPpeFAzL6HTtLlqXClrAnR6KlRA+BlJwyRXLCIIwyGhCdHZO+hG+8103oy7bDCkX3uih0sZwiOULrQaPQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(8936002)(478600001)(41300700001)(2616005)(2906002)(26005)(6512007)(31696002)(38100700002)(5660300002)(82960400001)(53546011)(122000001)(38070700005)(8676002)(6506007)(186003)(54906003)(86362001)(66556008)(76116006)(66446008)(4326008)(83380400001)(66476007)(64756008)(71200400001)(110136005)(66946007)(91956017)(316002)(6486002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K2VyVFMrWVlib2tXWjBZTG1UMXltS1NqY0VWaWlNVlM5TkJLb0Jma1FFTTRD?= =?utf-8?B?c1VSWFdjT0pNSEV3RzgwdHBUUW5YdVZmSmdJTU42WStmaTBqZC9uVW03YTd4?= =?utf-8?B?Z05tUXRFbHFSSEVKcmpadmdMWTRaS1puM2VtS0pCSVJWb1NBRUlDR2F1ZzRy?= =?utf-8?B?T2o3eldwZVRuWEVXa3NxcWdBcWROSHZoN1puWmFaK2xnN1ZmMDV2R2x1VHp5?= =?utf-8?B?ZWovNUMraVlFUE5BQ3poSjFiUEZZM3FOQmdGQkdXWGp5NnVUNDRZWWplRVBm?= =?utf-8?B?UUhGWW1qd3BEWnlqZ29EQWRva2puMGovR1YzWnJJRzA1SHpqblhhWHgxNS91?= =?utf-8?B?eEtjSWt1MXMrQ1daSklpSENXdVJGeU80WkxwVXRBTkpNc0J6VmtLZDc5eHNQ?= =?utf-8?B?Vk9IL3Y4QmFjWjRUUWtmTUl3OTYwd0FXM2MrQTVtTGJmWkZZbUd3N1hBOERS?= =?utf-8?B?Tk1YWHA0Ky9PMnN6RGYxRWZnbFVmQmtnMG1pbFRBTG0yN1pmZEdLZTg3YkRO?= =?utf-8?B?Yi8vdmoyQmsralhIdVpjcTk5aDdUUC9nTkd6dzVnSkgvTXd3d0JMVTRTOEgx?= =?utf-8?B?cnZzVkQvaHVNczk1TWNNaW9LY3Z3dnVuVEJiSlpzaDFmb2xFbUEzTUdJenVZ?= =?utf-8?B?NGFmNjVEVEwyK2ZQY0o3NCtHL0xxZm5rcTZVTlRNZlF3QlIrZC82cHc5eGtW?= =?utf-8?B?UEhXZTFrd3lkU05aQ3FrWTEwNi9YdTBjS2Nob0tJeGhCTjc2c084cXhaZGFN?= =?utf-8?B?UTRFNWxPOExiNjkxZGJXNllmYnQ4SFVtL20yb1hRdnYrSkhaenB1SFozL3N4?= =?utf-8?B?UFc1cGVFbHQraVB3R29OQXlJL3BrMXIxdHMvelFVZUJudWdTSFZuaGNtbzZO?= =?utf-8?B?Zy84M1l6VzVMNHRhOWsxcERCSzFTZWJ4WEhtRkN6WlIvWGU1OGxad3pjQVJl?= =?utf-8?B?MTBPZ1pUVFdONjJpdnJzZ2l3bUZ2UHcxRDlGZTNzcFhKbnFMMDhXdXhYK3hi?= =?utf-8?B?cGtsUDhSWkJtRnNVbjlCK0Y4eGxNTkFKMG5BNjV2OENUSlJUc0lGOVJHU29h?= =?utf-8?B?SlBvVk1OZnJHOUFPQldTS2FIMjhsYmQwRjR0RFFOTmpCUHVaNzFSYjZiYTBI?= =?utf-8?B?L0sxSGxFVVo0VFVmeGZ2clZnMGVOamFUWEY4d0RVdHVuZ2J1eERFUlNWcXRT?= =?utf-8?B?U0RJK1ZOdDV1WERKNTJMMk9FdHdzRFU0dEIvVDRtNXA0TTdhY0pxV0FEOFhB?= =?utf-8?B?QUVTMzNOeE5VTXRTdlpDTEh5dWVmc1pzcEtKaXFaSmFDUXJNWElSKzliUTNq?= =?utf-8?B?UURDMlRiZXpGOHlzYk1zd0dZajgvZTREcVkrbGQ4Q2p2elZEYW9KdzFRUFhL?= =?utf-8?B?SlU0Q2ZneFNDb1hrZ0w2R3hrdU9NM3lCczArczY3NDh2MDVQN1FUZmNFVkFN?= =?utf-8?B?ZXpTZ29DY3BwUkI5dm5JbmZwdDhRcHNhNkhUT0JDTlhCdThkN01Gc0hMS3po?= =?utf-8?B?YkhtNmVETEhtZWlaOSthQ1ExbUVWK1NuVG5nTmNYLzdFRUpNZU9Ld29zR1VS?= =?utf-8?B?aEFHM1NzaWFEcW9nNXNtbHNadk1xVkdxcTlmakNJdmRhUTVWTk5ud01tSEVW?= =?utf-8?B?c3huMTFBc2htTGwzNUpTN1gzUEt3Y09nV1lzYmJFUTg0UFdVVHJvdUUzL0hU?= =?utf-8?B?N01IZzdXV0J5b0dOalBpWHpNU2x1MzVGQkFoMlVSTFdWYzhiK2dTRHJCRGJE?= =?utf-8?B?VGx2Vi91dzdoRWNmWXlGV25tOUJ2a3I5a3RzenEvV3BJcTBTaGlDY2JMK0Zu?= =?utf-8?B?bHhsRkZucEZ2Ymc3V0lpVEN4V0JtMFZqSEVvNnNPbndkSHBoaDZobEtSaTVp?= =?utf-8?B?S3I4c1NqbGJzNUpiQ1g0TVRoUWJhQTVrbjJCQUx4RUdLcUMrdHFuQ1BISFFm?= =?utf-8?B?WGhBV1hsdk05NVU1eTlSSU9LZ25yUUdMbjBLYUovaHY0SWFvVWVmU3pVdUxq?= =?utf-8?B?dWFmdFp3SldzQXFidndwd2grOEhCQWdQeGJMVzQzZjBpRG1NVzB3bko2c1JE?= =?utf-8?B?Vko3RHphRDEvTDFCTTc0bHBLcGVhZFJuQlM5RTFkT3FjZjVOa0h3L3hzQXVW?= =?utf-8?Q?GsSMMu8WMmwNCNvY0vP/3XH1j?= Content-Type: text/plain; charset="utf-8" Content-ID: <9765946058C7C042BBC97CC8961DB58A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbecc604-bda4-4736-aa9d-08da9264e311 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 13:12:03.0160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KApBQ6/EvApmlh+yULIaC4sVdrARP+78F5Pa5E4otuA8xwOHxUV16wpTLSdKwnmTfLJwLkhIpMeaJMeOcDEbD5wTC0yC+qV7H+OYIiaE9sE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6621 T24gMDkvMDkvMjAyMiAxMzo1MywgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gQ29tbWl0IDlkYzQ2 Mzg2ZDg5ZCAoImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQi DQo+IHdhcm5pbmciKSB3YXMgd3JvbmcsIGFzIHZhZGRycyBjYW4gbGVnaXRpbWF0ZWx5IGJlIE5V TEwgaW4gY2FzZQ0KPiBYRU5NRU1fcmVzb3VyY2VfZ3JhbnRfdGFibGVfaWRfc3RhdHVzIHdhcyBz cGVjaWZpZWQgZm9yIGEgZ3JhbnQgdGFibGUNCj4gdjEuIFRoaXMgd291bGQgcmVzdWx0IGluIGNy YXNoZXMgaW4gZGVidWcgYnVpbGRzIGR1ZSB0bw0KPiBBU1NFUlRfVU5SRUFDSEFCTEUoKSB0cmln Z2VyaW5nLg0KPg0KPiBDaGVjayB2YWRkcnMgb25seSB0byBiZSBOVUxMIGluIHRoZSByYyA9PSAw IGNhc2UuDQo+DQo+IEV4cGFuZCB0aGUgdGVzdHMgaW4gdG9vbHMvdGVzdHMvcmVzb3VyY2UgdG8g dmVyaWZ5IHRoYXQgdXNpbmcNCj4gWEVOTUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lkX3N0YXR1 cyBvbiBhIFYxIGdyYW50IHRhYmxlIHdpbGwgcmVzdWx0DQo+IGluIEVJTlZBTC4NCj4NCj4gRml4 ZXM6IDlkYzQ2Mzg2ZDg5ZCAoImdudHRhYjogd29yayBhcm91bmQgIm1heSBiZSB1c2VkIHVuaW5p dGlhbGl6ZWQiIHdhcm5pbmciKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv c3NAc3VzZS5jb20+DQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j b20+ICMgeGVuDQo+IFJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt LmNvbT4NCj4gLS0tDQo+IFYyOg0KPiAtIHJld29yayAoSmFuIEJldWxpY2gsIEp1bGllbiBHcmFs bCkNCj4gVjM6DQo+IC0gYWRkZWQgdGVzdCBzdXBwb3J0IChBbmRyZXcgQ29vcGVyKQ0KPiAtLS0N Cj4gIHRvb2xzL3Rlc3RzL3Jlc291cmNlL3Rlc3QtcmVzb3VyY2UuYyB8IDExICsrKysrKysrKysr DQo+ICB4ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMgICAgICAgICAgICAgfCAgMiArLQ0KPiAgMiBm aWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+DQo+IGRpZmYg LS1naXQgYS90b29scy90ZXN0cy9yZXNvdXJjZS90ZXN0LXJlc291cmNlLmMgYi90b29scy90ZXN0 cy9yZXNvdXJjZS90ZXN0LXJlc291cmNlLmMNCj4gaW5kZXggMTg5MzUzZWJjYi4uNzFhODFmMjA3 ZSAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvdGVzdHMvcmVzb3VyY2UvdGVzdC1yZXNvdXJjZS5jDQo+ ICsrKyBiL3Rvb2xzL3Rlc3RzL3Jlc291cmNlL3Rlc3QtcmVzb3VyY2UuYw0KPiBAQCAtMTA2LDYg KzEwNiwxNyBAQCBzdGF0aWMgdm9pZCB0ZXN0X2dudHRhYih1aW50MzJfdCBkb21pZCwgdW5zaWdu ZWQgaW50IG5yX2ZyYW1lcywNCj4gICAgICBpZiAoIHJjICkNCj4gICAgICAgICAgcmV0dXJuIGZh aWwoIiAgICBGYWlsOiBVbm1hcCBncmFudCB0YWJsZSAlZCAtICVzXG4iLA0KPiAgICAgICAgICAg ICAgICAgICAgICBlcnJubywgc3RyZXJyb3IoZXJybm8pKTsNCj4gKw0KPiArICAgIC8qIFZlcmlm eSB0aGF0IHRoZSBhdHRlbXB0IHRvIG1hcCB0aGUgc3RhdHVzIGZyYW1lcyBpcyBmYWlsaW5nIGZv ciBWMS4gKi8NCj4gKyAgICByZXMgPSB4ZW5mb3JlaWdubWVtb3J5X21hcF9yZXNvdXJjZSgNCj4g KyAgICAgICAgZmgsIGRvbWlkLCBYRU5NRU1fcmVzb3VyY2VfZ3JhbnRfdGFibGUsDQo+ICsgICAg ICAgIFhFTk1FTV9yZXNvdXJjZV9ncmFudF90YWJsZV9pZF9zdGF0dXMsIDAsIDEsDQo+ICsgICAg ICAgICh2b2lkICoqKSZnbnR0YWIsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsIDApOw0KPiArICAg IGlmICggcmVzIHx8IGVycm5vICE9IEVJTlZBTCApDQo+ICsgICAgICAgIGZhaWwoIiAgICBGYWls OiBNYXAgc3RhdHVzIG5vdCBmYWlsaW5nIHdpdGggRUlOVkFMICVkIC0gJXNcbiIsDQo+ICsgICAg ICAgICAgICAgcmVzID8gMCA6IGVycm5vLCByZXMgPyAibm8gZXJyb3IiIDogc3RyZXJyb3IoZXJy bm8pKTsNCg0KSSdkIHJlY29tbWVuZCBub3QgY2hlY2tpbmcgZm9yIEVJTlZBTCBzcGVjaWZpY2Fs bHkuwqAgVGhpcyBoYXMgYml0dGVuIFhURg0KaW4gdGhlIHBhc3Qgd2hlbiBYU0FzIGhhdmUgY2F1 c2VkIG9uZSBlcnJvciB0byB0dXJuIGludG8gYW5vdGhlciwgYW5kDQpwbGVudHkgb2YgaHlwZXJj YWxscyBoYXZlIGV4YWN0IGVycm5vcyB3aGljaCBjaGFuZ2UgZGVwZW5kaW5nIG9uIGhvdyBYZW4N CmlzIGNvbXBpbGVkLg0KDQpJJ2QgZ28gd2l0aCB0aGUgbW9yZSBzaW1wbGU6DQoNCmlmICggcmVz ICkNCnsNCsKgwqDCoCBmYWlsKCLCoMKgwqAgRmFpbDogTWFuYWdlZCB0byBtYXAgZ250dGFiIHYy IHN0YXR1cyBmcmFtZXMgaW4gdjEgbW9kZVxuIik7DQrCoMKgwqAgeGVuZm9yZWlnbm1lbW9yeV91 bm1hcF9yZXNvdXJjZShmaCwgcmVzKTsNCn0NCg0KRXZlcnl0aGluZyBlbHNlIGxvb2tzIGZpbmUs IHNvIEknbSBoYXBweSB0byBmaXggdGhpcyB1cCBvbiBjb21taXQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:14:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:14:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404333.646769 (Exim 4.92) (envelope-from ) id 1oWdqR-0002or-Hc; Fri, 09 Sep 2022 13:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404333.646769; Fri, 09 Sep 2022 13:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdqR-0002ok-DU; Fri, 09 Sep 2022 13:14:55 +0000 Received: by outflank-mailman (input) for mailman id 404333; Fri, 09 Sep 2022 13:14:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdqP-0002oc-Pl for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 13:14:53 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63cf106f-3041-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 15:14:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 38E632234C; Fri, 9 Sep 2022 13:14:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DFAC1139D5; Fri, 9 Sep 2022 13:14:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fo9INUs8G2OQPgAAMHmgww (envelope-from ); Fri, 09 Sep 2022 13:14:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63cf106f-3041-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662729292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=scRnJP/JuV2jZCnjGe22eIFb49vl3mT1NhXdMvi1pWo=; b=LQKOdNl4ocaI4OLwhEoHRAb2uhKJg6P2MldBDhq9nimpaGWeNVOv/L1dMWCNNNC0zl3/GA /cYQ/RI0s8akh08r1l2xUHm7EYiblMHeB/j4wZAnM9M8eYGXRQpdatZxmfVtV4IqQBuWZl dewLI17br9vtBr49NQvTgMjPLq2OJvo= Message-ID: Date: Fri, 9 Sep 2022 15:14:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3] xen/gnttab: fix gnttab_acquire_resource() Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: "Henry.Wang@arm.com" , Wei Liu , Anthony Perard , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini References: <20220909125347.25734-1-jgross@suse.com> <903fe035-73ae-72cd-f721-1b418295a7c4@citrix.com> From: Juergen Gross In-Reply-To: <903fe035-73ae-72cd-f721-1b418295a7c4@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------v4yN6R9YHbRWeJ1F4y0KuElI" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------v4yN6R9YHbRWeJ1F4y0KuElI Content-Type: multipart/mixed; boundary="------------BYzJJGhgAed6S6vxevYZmy4c"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: "Henry.Wang@arm.com" , Wei Liu , Anthony Perard , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Message-ID: Subject: Re: [PATCH v3] xen/gnttab: fix gnttab_acquire_resource() References: <20220909125347.25734-1-jgross@suse.com> <903fe035-73ae-72cd-f721-1b418295a7c4@citrix.com> In-Reply-To: <903fe035-73ae-72cd-f721-1b418295a7c4@citrix.com> --------------BYzJJGhgAed6S6vxevYZmy4c Content-Type: multipart/mixed; boundary="------------yk0i6c1rtOQ1Cwx44R4waejR" --------------yk0i6c1rtOQ1Cwx44R4waejR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDkuMjIgMTU6MTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA5LzA5LzIw MjIgMTM6NTMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBDb21taXQgOWRjNDYzODZkODlk ICgiZ250dGFiOiB3b3JrIGFyb3VuZCAibWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCINCj4+ IHdhcm5pbmciKSB3YXMgd3JvbmcsIGFzIHZhZGRycyBjYW4gbGVnaXRpbWF0ZWx5IGJlIE5V TEwgaW4gY2FzZQ0KPj4gWEVOTUVNX3Jlc291cmNlX2dyYW50X3RhYmxlX2lkX3N0YXR1cyB3 YXMgc3BlY2lmaWVkIGZvciBhIGdyYW50IHRhYmxlDQo+PiB2MS4gVGhpcyB3b3VsZCByZXN1 bHQgaW4gY3Jhc2hlcyBpbiBkZWJ1ZyBidWlsZHMgZHVlIHRvDQo+PiBBU1NFUlRfVU5SRUFD SEFCTEUoKSB0cmlnZ2VyaW5nLg0KPj4NCj4+IENoZWNrIHZhZGRycyBvbmx5IHRvIGJlIE5V TEwgaW4gdGhlIHJjID09IDAgY2FzZS4NCj4+DQo+PiBFeHBhbmQgdGhlIHRlc3RzIGluIHRv b2xzL3Rlc3RzL3Jlc291cmNlIHRvIHZlcmlmeSB0aGF0IHVzaW5nDQo+PiBYRU5NRU1fcmVz b3VyY2VfZ3JhbnRfdGFibGVfaWRfc3RhdHVzIG9uIGEgVjEgZ3JhbnQgdGFibGUgd2lsbCBy ZXN1bHQNCj4+IGluIEVJTlZBTC4NCj4+DQo+PiBGaXhlczogOWRjNDYzODZkODlkICgiZ250 dGFiOiB3b3JrIGFyb3VuZCAibWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCIgd2FybmluZyIp DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+ PiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiAjIHhlbg0K Pj4gUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0K Pj4gLS0tDQo+PiBWMjoNCj4+IC0gcmV3b3JrIChKYW4gQmV1bGljaCwgSnVsaWVuIEdyYWxs KQ0KPj4gVjM6DQo+PiAtIGFkZGVkIHRlc3Qgc3VwcG9ydCAoQW5kcmV3IENvb3BlcikNCj4+ IC0tLQ0KPj4gICB0b29scy90ZXN0cy9yZXNvdXJjZS90ZXN0LXJlc291cmNlLmMgfCAxMSAr KysrKysrKysrKw0KPj4gICB4ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMgICAgICAgICAgICAg fCAgMiArLQ0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvdGVzdHMvcmVzb3VyY2UvdGVz dC1yZXNvdXJjZS5jIGIvdG9vbHMvdGVzdHMvcmVzb3VyY2UvdGVzdC1yZXNvdXJjZS5jDQo+ PiBpbmRleCAxODkzNTNlYmNiLi43MWE4MWYyMDdlIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMv dGVzdHMvcmVzb3VyY2UvdGVzdC1yZXNvdXJjZS5jDQo+PiArKysgYi90b29scy90ZXN0cy9y ZXNvdXJjZS90ZXN0LXJlc291cmNlLmMNCj4+IEBAIC0xMDYsNiArMTA2LDE3IEBAIHN0YXRp YyB2b2lkIHRlc3RfZ250dGFiKHVpbnQzMl90IGRvbWlkLCB1bnNpZ25lZCBpbnQgbnJfZnJh bWVzLA0KPj4gICAgICAgaWYgKCByYyApDQo+PiAgICAgICAgICAgcmV0dXJuIGZhaWwoIiAg ICBGYWlsOiBVbm1hcCBncmFudCB0YWJsZSAlZCAtICVzXG4iLA0KPj4gICAgICAgICAgICAg ICAgICAgICAgIGVycm5vLCBzdHJlcnJvcihlcnJubykpOw0KPj4gKw0KPj4gKyAgICAvKiBW ZXJpZnkgdGhhdCB0aGUgYXR0ZW1wdCB0byBtYXAgdGhlIHN0YXR1cyBmcmFtZXMgaXMgZmFp bGluZyBmb3IgVjEuICovDQo+PiArICAgIHJlcyA9IHhlbmZvcmVpZ25tZW1vcnlfbWFwX3Jl c291cmNlKA0KPj4gKyAgICAgICAgZmgsIGRvbWlkLCBYRU5NRU1fcmVzb3VyY2VfZ3JhbnRf dGFibGUsDQo+PiArICAgICAgICBYRU5NRU1fcmVzb3VyY2VfZ3JhbnRfdGFibGVfaWRfc3Rh dHVzLCAwLCAxLA0KPj4gKyAgICAgICAgKHZvaWQgKiopJmdudHRhYiwgUFJPVF9SRUFEIHwg UFJPVF9XUklURSwgMCk7DQo+PiArICAgIGlmICggcmVzIHx8IGVycm5vICE9IEVJTlZBTCAp DQo+PiArICAgICAgICBmYWlsKCIgICAgRmFpbDogTWFwIHN0YXR1cyBub3QgZmFpbGluZyB3 aXRoIEVJTlZBTCAlZCAtICVzXG4iLA0KPj4gKyAgICAgICAgICAgICByZXMgPyAwIDogZXJy bm8sIHJlcyA/ICJubyBlcnJvciIgOiBzdHJlcnJvcihlcnJubykpOw0KPiANCj4gSSdkIHJl Y29tbWVuZCBub3QgY2hlY2tpbmcgZm9yIEVJTlZBTCBzcGVjaWZpY2FsbHkuwqAgVGhpcyBo YXMgYml0dGVuIFhURg0KPiBpbiB0aGUgcGFzdCB3aGVuIFhTQXMgaGF2ZSBjYXVzZWQgb25l IGVycm9yIHRvIHR1cm4gaW50byBhbm90aGVyLCBhbmQNCj4gcGxlbnR5IG9mIGh5cGVyY2Fs bHMgaGF2ZSBleGFjdCBlcnJub3Mgd2hpY2ggY2hhbmdlIGRlcGVuZGluZyBvbiBob3cgWGVu DQo+IGlzIGNvbXBpbGVkLg0KPiANCj4gSSdkIGdvIHdpdGggdGhlIG1vcmUgc2ltcGxlOg0K PiANCj4gaWYgKCByZXMgKQ0KPiB7DQo+ICDCoMKgwqAgZmFpbCgiwqDCoMKgIEZhaWw6IE1h bmFnZWQgdG8gbWFwIGdudHRhYiB2MiBzdGF0dXMgZnJhbWVzIGluIHYxIG1vZGVcbiIpOw0K PiAgwqDCoMKgIHhlbmZvcmVpZ25tZW1vcnlfdW5tYXBfcmVzb3VyY2UoZmgsIHJlcyk7DQo+ IH0NCj4gDQo+IEV2ZXJ5dGhpbmcgZWxzZSBsb29rcyBmaW5lLCBzbyBJJ20gaGFwcHkgdG8g Zml4IHRoaXMgdXAgb24gY29tbWl0Lg0KDQpUaGFua3MuIFBsZWFzZSBhZGFwdCB0aGUgY29t bWl0IG1lc3NhZ2UgYWNjb3JkaW5nbHkuDQoNCkJUVywgSSd2ZSB2ZXJpZmllZCB0aGF0IHRo ZSBzeXN0ZW0gY3Jhc2hlcyB3aXRob3V0IHRoZSBoeXBlcnZpc29yIGNoYW5nZS4NCg0KDQpK dWVyZ2VuDQo= --------------yk0i6c1rtOQ1Cwx44R4waejR Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------yk0i6c1rtOQ1Cwx44R4waejR-- --------------BYzJJGhgAed6S6vxevYZmy4c-- --------------v4yN6R9YHbRWeJ1F4y0KuElI Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMbPEsFAwAAAAAACgkQsN6d1ii/Ey/g MAf+MCbYG+Qqu3kPPFLrrezIkKdi/gzscwu9YJU4BYUEtlurRWTejLuFRBN6uDhac1ehX7YZGiwn imiSRjRm3VMth+s7YsDX5m5Al598miwyQPZiNiR+d/riCQPGH4phLca3aiUdZr6iqJd5UR2xTYCI Ve9n2b1IJUugJBuNwyY07V/7Uo/ax4ZWcnQeuamm5OndB0MLp39dAWdUKqTJImS1u9t4wDl+UFpn iShZySOcDN0SPCufGiUX+gRgN1GacCeQnjaqX+tnkZMdjS+C8Re6kQAv1oGdrGqjg8Gdyb6xGZzG GHcVEib6i05J0je5joOPRHaboBYyYlpzW6Komff6kg== =EuHx -----END PGP SIGNATURE----- --------------v4yN6R9YHbRWeJ1F4y0KuElI-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:19:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:19:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404341.646780 (Exim 4.92) (envelope-from ) id 1oWduq-0003qj-2H; Fri, 09 Sep 2022 13:19:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404341.646780; Fri, 09 Sep 2022 13:19:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdup-0003qc-VP; Fri, 09 Sep 2022 13:19:27 +0000 Received: by outflank-mailman (input) for mailman id 404341; Fri, 09 Sep 2022 13:19:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWduo-0003qW-D4 for xen-devel@lists.xen.org; Fri, 09 Sep 2022 13:19:26 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04fda185-3042-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 15:19:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04fda185-3042-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662729565; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BXETze1Aig/wA4PnDydwt5TswadsZLtvoXpQrK9I1Uc=; b=M6zcIx9ZG9anOuTL21QwIWaMPM3yXeoZID3atSTWo25f8KLE4RQmNuEj dO0iyCfdZ5Md7QVt+hrR62ISbBN8REiisBS3mLTHJ1ZIbhFQnE+VRDMwW LBNPzySL2bQJJSkLJJACvT7ZFwyq29zts5X45DhquJL3YZeRlHJDy5+Df Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79842249 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:3RYdV64fvPIVKkaoL/BGEQxRtHbAchMFZxGqfqrLsTDasY5as4F+v mJNUWnQP6zYMWH9L95+a9m18kpSu5LQxoNnHAplpHoyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ks+5KWq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJHwXMZICq8hXOl9D9 M4nNzlcZUqcmtvjldpXSsE07igiBMziPYdZsXB81zDJS/0hRPgvQY2Tu4Uehm1pwJkTQ7COP KL1ahI2BPjESxRJJlcQDoN4hOqyj2PzWzZZtEiUtew85G27IAlZj+m9bICPJo3iqcN9sluZm U/fpCfFRT4FH9ee+QLG1Xyvibqa9c/8cN1LT+DpnhJwu3WMwkQDBRtQUkG0ydG+jkO9QM5OM Ew89S8nrKx0/0uuJvH4VgG4oXOZ+AYbWsBRHvcS7ACLw7DTpQ2eAwAsSTpMa8cvssMsciA7z V+Cn97vBjtHvaWcTDSW8bL8hTGvPSkYK0cSaClCShEKi/Hhr5s0lQnnVct4Hei+ididMS/xx TuHqjR4iKgSkdIMy42//FbOmTXqoYLGJiYl6wOSUm+74wdRYI++e5fu+VXdq/FaI+6xUFibs WME3cuD6ekUJZWMkiWXR6MKBr7Bz+2ZPTPVh1kpBIUo/Tmp/3+lfKhA4TV/IlcvOcEBERfgZ ELD/wlc4pleMVOubKl+eYX3DN4lpYD7Cc7sSvfPK9ZDfLB2bEqD/TpyfgiU3mbkik9qlrswU ap3au71UyxcU/4+imPrGaFNitfH2xzS20vuZJzk1UWJ8YGgaX+ndqgMYVDUcf0AufbsTBruz zpPCyeb40wBDregOXCMrdF7wUMidiZiW82vwyBDXqvae1c9Rjl8YxPE6el5E7GJiZi5gQshE puVfkZDgGTyinTcQelhQiAyMei/NXqTQJ9SAMDNAbpL8yJ5CWpXxP1DH6bbhJF+nACZ8dZ6T uMeZ+KLCelVRzLM9lw1NMej9tI8Lk3031vTYEJJhQTTmLY5H2T0FiLMJFOzpEHi8ALs3SfBn 1FQ/lyCGsdSL+iTJM3XdOiu3zuMgJTpo8orBhOgHzWmUB+zmGScA3Cu06RfzgBlAUmr+wZ2I C7NWU5E+bGU+dZvmDQL7Ijdx7qU/yJFNhIyNwHmAXyeb0E2IkLLLVd8bdu1 IronPort-HdrOrdr: A9a23:risCf673RSyXFAIp+APXwMrXdLJyesId70hD6qhwISY1TiW9rb HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ 0QCpSWY+eRMbEVt6jH3DU= X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="79842249" Date: Fri, 9 Sep 2022 14:19:08 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V6 1/3] libxl: arm: Create alloc_virtio_mmio_params() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Thu, Sep 08, 2022 at 02:22:59PM +0530, Viresh Kumar wrote: > In order to prepare for adding support for more device types, create a > separate routine to allocate base and irq for a device as the same code > will be required for other device types too. > > Also move updates to virtio_irq and virtio_enabled out of the disk > device specific block, as they will depend on other device types too. > > Suggested-by: Oleksandr Tyshchenko > Reviewed-by: Oleksandr Tyshchenko > Signed-off-by: Viresh Kumar Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:21:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:21:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404349.646790 (Exim 4.92) (envelope-from ) id 1oWdxE-0005D3-Ex; Fri, 09 Sep 2022 13:21:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404349.646790; Fri, 09 Sep 2022 13:21:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdxE-0005Cw-C9; Fri, 09 Sep 2022 13:21:56 +0000 Received: by outflank-mailman (input) for mailman id 404349; Fri, 09 Sep 2022 13:21:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWdxC-0005Cq-Iq for xen-devel@lists.xen.org; Fri, 09 Sep 2022 13:21:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d83cb59-3042-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 15:21:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d83cb59-3042-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662729712; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ao+kd5oka2knhf2iFLv7l73WLdS4oW6a+Szmj9ib9Y8=; b=TvJeJmj3d46+eNi7/270StSIKKg1XWu9AJ342GMhsM4va9BkEJXxwBVb KGK4TuOM9f/nEEXNEwQAS46eVagiP1XkpIUz6zkYUWgSw438bcG5OpBIF knfWxT/+mFwKzjdrpl//4QSyEPLREYItuOzOa80oZVJJoP+wGa4cUVvWR E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80153804 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3Api6E7asYN9BahYckD7vaLTb87+fnOphVZqsSw?= =?us-ascii?q?8ifNqXej3nw3RfK1alSQtWbac0UGAeHrecKLn+i4Uvy1o48rIpWocDp8Ue6W?= =?us-ascii?q?VUpWcbailInEKWSxbGL/OrgUKEv7Uc6+s9snz47Yz4fGBX80uLaeLhIsetBX?= =?us-ascii?q?LtPHrm2D86YuuJAEFFHeW2NMkYqGVUBkqvftDn0X0FY2MrGcHCMedRUj9bSO?= =?us-ascii?q?xLDq+H6HvomigIFRv6h91vTphcvgAVUnZQiB6KgaZyS5vphjKdBrpF6fd5/w?= =?us-ascii?q?9zZLNUgES2a1kq/bnfLOy1FaZfbrTCKASdhZxyG/JF6SDVuimEyUPbWtUzN8?= =?us-ascii?q?iFn9Ipjqa1jW4zkhD5vuNYLqjg7FmKMwGlWOnL/d9Fhf4p3YnsAMWqydxLEu?= =?us-ascii?q?gGulhbZdDhCQEjHrdD0f34YKcrewN2HiWlmKCUb8nv+9QvWT0IxUtuG3u8C0?= =?us-ascii?q?FIUK88hR6YQj7FlAu3kQh2kHtE4rbTJKyDkQYKYSY0MP/PFy6373ioptPQQD?= =?us-ascii?q?2ot9IijvIazwEjVaH+xqfsEXNqzy7IEY3ZgnQ7EvIGNx5NjKTLLl8CwYAjw3?= =?us-ascii?q?h2RJcwQaPyJ8dq1UStCUAWPOj0OGDuSmDLje62qwd+65vAUvKA5uWCdcvb7q?= =?us-ascii?q?JRxgekp8d/OA+dn774yz7AdxHGqpKIZQwF+lOp30WsR7Ne9sXl22gawrmkOi?= =?us-ascii?q?0GmxeGFnOs4+P3cJbViMfmTyhtwbF++bxbW+VTo+OSBsYZUwHIsZnInnwTpY?= =?us-ascii?q?F+lhFCCu5RyM9ANAWqxRgAOOaF0IVvLLxcrwf/lHGgR+Jp2pWqecy1tygsmt?= =?us-ascii?q?43m8JYdFOKg0ummLdNlE+e2MphECgpEd7FcJbiz236uPF+U1exJ/JPkW04em?= =?us-ascii?q?zVcHKeApRcuX5M0fskMOrbF/CI9Cu59oN0wroteVHq287jdpNlOvRQjzZoNI?= =?us-ascii?q?NG4TaaLoGrW/hJo+4sW89DYeosI05o+9FHD6JGNRTz7sra3hHPoiCHM7BM/y?= =?us-ascii?q?vWcnydCWkoBGACEkul0V4Oiw5gv995cgQM7TSFVO6JMn1S+MtVZUDumKB/Gs?= =?us-ascii?q?dtE+EeaEYTB/AECwXh3bLrMpkhpY84AZDoCqBfX9sM2NTpHZi4UEDTUmF7dF?= =?us-ascii?q?5QRr/KeaoKbiZF2CEEZhr/2xQCOlBzbElsl+LZ3DTn6Z+jsUQ9VLUjbuV7v3?= =?us-ascii?q?Y030HiOkXwTjh/t3G0FHv2SFTL/tHNNBeh9b6+kn2F55pr1ov2gKB26o5vID?= =?us-ascii?q?fNqW90LFs9L+vfjNZwb9oZ/JXU4F0uQ5IbcI5nN31PnLeH8ax0DUNpEw2ab9?= =?us-ascii?q?JO4HaMyQfJYm5XozE8iEns56D+7sXMEnE2G2GbAi9Z00h8mVkMNQ3aBEKlfx?= =?us-ascii?q?W6DlvNnA39UJFdNPzxz0wzvPggDPpGsZfXNotR3Da7fj0rOvvoRVFZBBqBaG?= =?us-ascii?q?PJLMDx6WbIlHBmuSPibOGE7PzPxaoSomZ24S6I5Wge9pN00671MYwRSZv7G6?= =?us-ascii?q?zILPP8m8BkjTE+cymURdo6Zv03+LzCh8iABrW2cKUvsRfJtXZjEYOfjjTNqV?= =?us-ascii?q?EbwXBt8B3LWm3irDaC8K6OIFG+qS9DHBy51Mm1RkZZlBJnlK+Cig7Lurf110?= =?us-ascii?q?ebJgEW8ovF7cA9xW4nlLj0TnpnLd2e469LtZMRJu3eDHcNfDY2JLg1C8Jh0n?= =?us-ascii?q?X8nybEqlTvyj/fIp0v2re2EuEq1HIwPibtkZE7Z8YZKVL3MSVs5bTPjjgOec?= =?us-ascii?q?XNl6I4Skw51kMC7Q05XtxmDFVhWiA1873t7qO/m/hd5/X11HnkqiMsw1ia67?= =?us-ascii?q?2zl16W4PULFy3Cd9Lqssz2a7g1nU3ZALWuNYqDxZzfmotOWV837onVHJT/VU?= =?us-ascii?q?+L51wdQUuWr7fD0f/TwH+z18YvV1aEWIC8iWcfvciVf7vj7u7+M1Vr3a1heq?= =?us-ascii?q?SCOt6NArHjYgaujZVpb5YtnFtJlxl6kNvu4s6LRq4ESuueaEASdCSjeE3zM3?= =?us-ascii?q?U/S6ACckrVVDzB/NAX8RnXnZjdRGzdiF0tRBy9atOT+YMA0XeZzFTbD+fLsK?= =?us-ascii?q?7bdtRMOPakHMih8SioDHUZYm+HHJf11s/6/dk0/digcE3+wkgsJb5OkwflSg?= =?us-ascii?q?mr0J/fGFBEDgVwvXI8P31CezW/eSHV7LC/45kv4t2xJJmqCbI9SLB/+utCIu?= =?us-ascii?q?EsVEp91GOj+KRZfOzyhpHSuLwoJmxxctclRjflQyrUtw2twSPoRnvr4A3SEU?= =?us-ascii?q?lcjxiuMb0/VoVk9IV83+fDIqhm23EY2Xoio8sHp/fMtm4kpGMzjlS8wdx+al?= =?us-ascii?q?4Cr9zTYqXgEKllRvlue7dBfsVJRmokTPMGxiwX57efnc6I0CHy5FgXXsKpoh?= =?us-ascii?q?lRh7FsMnL4tOH8/3Mi0RaB3DQ4LXobCNS7QAZVur6WcOK3icT23gg8JKwCpk?= =?us-ascii?q?G/EDvt5daY7B9QwSCWCFG//RcVvgxsxy92SHibmCzSllFuMXd+9U6vaSH/Hv?= =?us-ascii?q?om3VHNVQ/MoZ2/Sq9+nSTONTorIromdaAMrINOrpQg9/d+quOQ5+7+zyLlgO?= =?us-ascii?q?SW1KYCmYg+1gcYEcRs7Evg+ZvrVAfvV7FIc+QG1ufHJWKt85g/xTsg8HU0uS?= =?us-ascii?q?dam6J7zMJ2CiKN9qL3+8+a7pxmp7j36lJsSfm+PzzgekraYXf/2MKI+lnqGH?= =?us-ascii?q?K0C5k2ldE0h/mQGtjQPp3yiWmsTeul5nA0QZvpz5bIcil0LXpk0VJTkFnYML?= =?us-ascii?q?mRnmDLZpGsoiZscYm+U0RysZ4EMd/ZWrRh/w3L3qDkG3WWNkIKk9Lwx5YYFi?= =?us-ascii?q?x2fQl9XxGH3XdG7I9iBbn85H6LJ4eiwVRhc3cOWLhyrJcWPg/v6N1OiJN56N?= =?us-ascii?q?RDLW0lZHidU8K0Gt6rlb1dZufm8fJIgegLuiJ4/FDyzlIXi/U/YmbC1kYdqu?= =?us-ascii?q?xXAfUCMk5NUK0EVUIRFIM+tONstoaYwTaEZidszBQujmeKeJB23sc0++nbex?= =?us-ascii?q?DrCHcOGMEUq9w1TMsPJwDGQmv/SbsdgSfvT34d1t5zyPn6ZLeOVrig9hqjvo?= =?us-ascii?q?WyiFt92QcQjBPwFNLbTHDgtcl6ELYDWIy8+tlK0UzC6xdw0ckGZZhxi5Gx/e?= =?us-ascii?q?yKe7nmWqNGFMNyPv5zkhFnvTRJhAb5hTKlry4Pq9A1H1htwPnH94Av+jr/DE?= =?us-ascii?q?AGsOQQgwIpDW3paVaJ6ZHwQcKLLO8C2EVZHWi1zFeTsDPtUbD6+T2969YwKR?= =?us-ascii?q?gH+MaOJI2OMpTQlTe8hxiyoqwGrUHtO6ev8ArIT1y8nybbdp06zl6l1P53ld?= =?us-ascii?q?k5Ipkt/0B7eFVCJxEgAXXfcvkWa3GaVxlm1bTh6mEpQsQy0Z12BZPE=3D?= X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="80153804" Date: Fri, 9 Sep 2022 14:21:41 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V6 2/3] libxl: arm: Split make_virtio_mmio_node() Message-ID: References: <0edb5dc1ea3308cf9202e6476ff2797aad953966.1662626550.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0edb5dc1ea3308cf9202e6476ff2797aad953966.1662626550.git.viresh.kumar@linaro.org> On Thu, Sep 08, 2022 at 02:23:00PM +0530, Viresh Kumar wrote: > make_virtio_mmio_node() creates the DT node for simple MMIO devices > currently, i.e. the ones that don't require any additional properties. > > In order to allow using it for other complex device types, split the > functionality into two, one where the fdt node isn't closed and the > other one to create a simple DT node. > > Reviewed-by: Oleksandr Tyshchenko > Signed-off-by: Viresh Kumar Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:35:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:35:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404358.646802 (Exim 4.92) (envelope-from ) id 1oWeAg-00071u-MI; Fri, 09 Sep 2022 13:35:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404358.646802; Fri, 09 Sep 2022 13:35:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWeAg-00071n-Ib; Fri, 09 Sep 2022 13:35:50 +0000 Received: by outflank-mailman (input) for mailman id 404358; Fri, 09 Sep 2022 13:35:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWeAf-00071h-4e for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 13:35:49 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2079.outbound.protection.outlook.com [40.107.244.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f7f5049-3044-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 15:35:47 +0200 (CEST) Received: from BN9PR03CA0631.namprd03.prod.outlook.com (2603:10b6:408:13b::6) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 9 Sep 2022 13:35:43 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13b:cafe::3c) by BN9PR03CA0631.outlook.office365.com (2603:10b6:408:13b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Fri, 9 Sep 2022 13:35:43 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 13:35:43 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 9 Sep 2022 08:35:42 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 9 Sep 2022 06:35:42 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 9 Sep 2022 08:35:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f7f5049-3044-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=czGeS8hw/H+Wd8xCk5YTZuL+TnSO2edWGhs+C5NlqzEQGhMiyhTWnpHoH7sW6qCjZYVUI+TESxrqluchFTYq5vN+MtUf8IIrGA4InsHBuSaR1+EKrvJIPg8h2pdd+T37GaDa3HiTpeli7jgPga9KXosv700uF/vi6Jh3khxtKGhEnFcp1LtH22DASVgVaTL06EFKkUYpc5UjNA3UnaI0tRGThbooFV1650PmkfHdnUKBE4peF7640raxV8HjqKocyP4KohzVik/rS/CklIRNmqyLhQNCXyNK1B9QjzAWa6WIpYZaC3SPrQmkw0EtBHlAM9zPmiXYrcoRsd3DYjhovA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bTXaZa66l9Tvpto+JOENxDB9ttjjVJlV81dOMp4Hv1s=; b=Dc4p+2rTee2VTTnruc0HPpw3IVRScrfxkb546YMMwgBCeAKYYKbeiJbM4ojzt5oxe/hBNMV1aPdZC+nGyqL7fgbLTzOHiEC1Ieg9k8M23JHrPDbi8XxIFG3tWUWI9ioLMCk4/ZdUTsfmK6k8BdMTCSTuLvjxbt7eyrzGTEVbv/qK87MIIRU2v4lZWpdonR2pWg+fll9QGpDNrO28Z+kMH8iRhojctrioxwpoWLqU0pb+gtzrND8NxQrq0HVvTI0iSmma9QpxELp532v+550ehc80qqBuJ9KeMb2wDEhnrhy/qibjR4mdV0VTjRhRUl5ln2yji5blt8SJnImaz+TPqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bTXaZa66l9Tvpto+JOENxDB9ttjjVJlV81dOMp4Hv1s=; b=N/Rt1h0IBlMiwyZjZ3DNIW5jGl6vvGX0yiDv3oLklAFoEUPP328mNNeTgm2LynuK1sQPvfX9ma5xwZirqhHJBNRXgjapaZ5u/EirHoMkOaTUhQMiMZ53HRZ/KAHW/1N1po0aF09Z5vhTFgpsEC05Ze7Dv27ykpaw1xCMoITOzAk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 9 Sep 2022 15:35:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree Content-Language: en-US To: Luca Fancellu , Julien Grall CC: Stefano Stabellini , Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , "Volodymyr Babchuk" , Bertrand Marquis References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> <34ae5402-799e-1c43-7ab2-6e8935471cc2@xen.org> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT017:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: ae069fad-813f-4038-8a54-08da9268318e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dm1dpBEJwP0Nthp5xrBrGtfinwNOZY2RHS/+tekZ/8tUJvCnQk26BWvm74fxliX3/1sFZi68S1dV6kgfQTXTEKhBRhFn0k+OUpU4s3rF8y/B8R0Zj7hmkWWjR7uPCYAtXD3EuSvQcEyohp/q1x56kz4XJExUHynAGC+vOX3ScfO5+NRDj4FiLzOW4FqN2UQfTqFYjhd6pfJ/pdJqFuA6tQTFjbzldH5EAeb2T+Wf15IO7fHXCMwqfRqikbJwshhaD9fT75zq8qGXKYPeLcKlSvind2U3ATpZ+YK0v6gEn8xNgclYp1ggB2/tzqJnpc31XvJM23sag/UZTn3LQK+MaIfOtX/4a1vATRgiblCukSd4QegULqx6w0vxTZb4dpt8XqggQ2g7FRwsumZ20Zc2JWaELUVX1z78b1RvcCQkdLrP1h7RKzUrwMTiPQoP5+ivurMYmamCPdr593RRK7GkhHvMavHW7FzsMoQOwtMuBGWCLYqftLcl3C7ZwHTSDWeoexEbGUaBO2/gXlSj5mBxKVyfsdlokcww0HZuXXA+jEZuPCoErL65c/zNRuOpMcwVlkxVCesvx25DYLAcKrLChFzHcCYD6jymyzuORH+JGnS6h9wjsQ3g7MteMW+K6iP29+DidqsNtvbi1xaCXnx7XdZSpVfwPLwDGfETMhzyruAm2e+i3wuevjiYrog93lxQav8KyOttU2izekd8AXMdwS/nqEswH2S/rtGU0rbbrsFwqAN1zhA23CWAuzjSNJMkoPT1NZCCD2PQuon9WyQABdyImva4feYHDDmQ6i8CKmNkPM1S7XDfEVZ0AcPUeTsepMVUp/hBlWYA7hfYAmqyB+UP55E+8KxJodJqwiMZ4O0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(136003)(39860400002)(36840700001)(40470700004)(46966006)(356005)(2616005)(336012)(70206006)(54906003)(26005)(40460700003)(86362001)(186003)(426003)(36756003)(70586007)(31686004)(966005)(316002)(16576012)(47076005)(478600001)(110136005)(31696002)(44832011)(2906002)(81166007)(8676002)(41300700001)(8936002)(4326008)(82740400003)(36860700001)(83380400001)(40480700001)(53546011)(5660300002)(82310400005)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 13:35:43.1400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae069fad-813f-4038-8a54-08da9268318e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Hi Luca, On 09/09/2022 14:35, Luca Fancellu wrote: > >> On 9 Sep 2022, at 10:40, Bertrand Marquis wrote: >> >> Hi Julien, >> >>> On 9 Sep 2022, at 10:27, Julien Grall wrote: >>> >>> Hi, >>> >>> On 09/09/2022 08:45, Bertrand Marquis wrote: >>>>> >>>>> It should be: >>>>> >>>>> /* >>>>> * TODO: >>>>> * >>>>> >>>>> I think this is good to go. The two minor style issues could be fixed on >>>>> commit. I haven't committed to give Julien & Bertrand another chance to >>>>> have a look. >>>> I think that it is ok to fix those on commit and I am ok with the rest so: >>>> Reviewed-by: Bertrand Marquis >>> >>> This series doesn't build without !CONFIG_STATIC_SHM: >>> >>> UPD include/xen/compile.h >>> Xen 4.17-unstable >>> make[1]: Nothing to be done for `include'. >>> make[1]: `arch/arm/include/asm/asm-offsets.h' is up to date. >>> CC common/version.o >>> LD common/built_in.o >>> CC arch/arm/domain_build.o >>> arch/arm/domain_build.c: In function ‘make_shm_memory_node’: >>> arch/arm/domain_build.c:1445:1: error: no return statement in function returning non-void [-Werror=return-type] >>> } >>> ^ >>> cc1: all warnings being treated as errors >>> make[2]: *** [arch/arm/domain_build.o] Error 1 >>> make[1]: *** [arch/arm] Error 2 >>> make: *** [xen] Error 2 >>> >>> This is because... >>> >>>>>> + * - xen,offset: (borrower VMs only) >>>>>> + * 64 bit integer offset within the owner virtual machine's shared >>>>>> + * memory region used for the mapping in the borrower VM >>>>>> + */ >>>>>> + res = fdt_property_u64(fdt, "xen,offset", 0); >>>>>> + if ( res ) >>>>>> + return res; >>>>>> + >>>>>> + res = fdt_end_node(fdt); >>>>>> + if ( res ) >>>>>> + return res; >>>>>> + } >>>>>> + >>>>>> + return res; >>>>>> +} >>>>>> +#else >>>>>> +static int __init make_shm_memory_node(const struct domain *d, >>>>>> + void *fdt, >>>>>> + int addrcells, int sizecells, >>>>>> + const struct meminfo *mem) >>>>>> +{ >>>>>> + ASSERT_UNREACHABLE(); >>> >>> ... there is a missing 'return -ENOTSUPP' here. While this is simple enough to fix, this indicates to me that this version was not tested with !CONFIG_STATIC_SHM. >>> >>> As this is the default option, I will not commit until I get confirmation that some smoke was done. >> >> This is a case our internal CI should have gone through. >> Let me check and come back to you. >> > > Hi Julien, > > Thanks for catching it, in this case I can confirm that the problem was that we are building with CONFIG_DEBUG enabled, I don’t know why GCC doesn’t complain when > you have __builtin_unreachable() in that function without any return value, it doesn’t even throw a warning. Could it be considered a bug in GCC? This is not a bug. The documentation states what is the purpose of it even in case of functions returning type. https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html To sump up __builtin_unreachable generates code itself to return. > > Building Xen without CONFIG_DEBUG instead shows up the error you found. > > In this case this change will fix the problem, do you agree on it? > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 8c77c764bcf2..c5d66f18bd49 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1439,6 +1439,8 @@ static int __init make_shm_memory_node(const struct domain *d, > const struct meminfo *mem) > { > ASSERT_UNREACHABLE(); > + > + return -EOPNOTSUPP; > } > #endif > > Is it something that can be addressed on commit? > > Cheers, > Luca > > >> Regards >> Bertrand >> >>> >>> Cheers, >>> >>> -- >>> Julien Grall > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:41:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404368.646813 (Exim 4.92) (envelope-from ) id 1oWeFz-0000Mu-Ca; Fri, 09 Sep 2022 13:41:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404368.646813; Fri, 09 Sep 2022 13:41:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWeFz-0000Mn-9o; Fri, 09 Sep 2022 13:41:19 +0000 Received: by outflank-mailman (input) for mailman id 404368; Fri, 09 Sep 2022 13:41:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWeFy-0000Mh-5H for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 13:41:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 140d103c-3045-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 15:41:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5716.eurprd04.prod.outlook.com (2603:10a6:208:128::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Fri, 9 Sep 2022 13:41:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 13:41:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 140d103c-3045-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOS/JwIw6TCcU4PQ6qn1oq+VpjFCGjLlScw6LqiQ+4CAuqqFcuV5t6IRdygZUmsWbaRvBkzr5WbtSiYmheoEmXgew52Il9EaNh4gJpOKer9Y8VBSG6usppNwjf7XGkSz4kkeGWcfurMysNe6OnkepdXBI/5T02rpSRcQVERpwv84SuIuVfPmrwhAKPCy+6Lch+FLs8UBxbC4adUDpwQc0QURmDjAbaoyDhv0asZsT0rEtuvOHCWXnzTQ1t2jjfOGOEqdVAVX5MJwwH0DpYze+EQFK/kOT9P2FTUX9l5hgkxZgFuDJwXVDXXSdoSg+hz8K/hmJ4iKfQWeBr3U1v9mUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ggjmk5fUGkioYbiuHrpgmwF5jPPRaUl0+tSSXX+oN4A=; b=fpYrhEGNFb8FVF1UsoFossv9KQ0aTwM9IZm4JdoaFT52QPRGhPWUtH96So/UlKPDYl2rAW7LH1JbRHGUZ7inxlVL8giPW5oi24LS2WTEYsTzdoeqIl4y+nwHmvpZcfAqACQcjhICrpJPG/RrfW0KnjUFPmvg7UGinrVitzNXyvc4HbYwpiKby1d85iZG9cNDT0ejYBaF8onNOLW76kbDqhXx4HX4657hyxCurJ+YMAV7E7FqwnF7CVgA+FThZChA160oBvv+3UjabXcy7jFRHrEUHQ6Op27AYHZs3Wnv/ZYSRSUjjgwh7BpI2Qvn0Go4PJzCAW6RnXrzJFBnKOL2kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ggjmk5fUGkioYbiuHrpgmwF5jPPRaUl0+tSSXX+oN4A=; b=hRdjBqm95/N1jQGN0SVE5pEmDSPCaPnP8vvzcCbhonslj5aHSrZHRv66kOjymGymHbqLnuJl+pRkkdfYLM84QUVoAoOY9mbfVaUZoW4EkW5wDSXyYvtXVCCAO9WuUM+1nRY6K8iJJmJ7++Nf/kuOttcddN9av5D9JWyGgCrCwS4cCl2lfSpdlGgGUJzKUvwyIEJKdmsL69p8Gv8jrJYppMPO0w73XkSgh7GnJJ2NAlEuzSI/YroWkVn7YQ3+sofbq3eB/0pIZ0Y++Ecm4ffHeDC4SoJ8NFofLBKXf6/MLCyc69CBLbCjonTnMQyp9ix7/U/sor2pZnnunInJr0Igpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0dbef17c-be73-1d88-cd20-83f3123361bf@suse.com> Date: Fri, 9 Sep 2022 15:41:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Anthony Perard From: Jan Beulich Subject: [PATCH] build: correct cppcheck-misra make rule Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB5716:EE_ X-MS-Office365-Filtering-Correlation-Id: b3eade7a-9646-4acf-ae91-08da9268f6a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ht6TmMMzNIYI6ufhwTggpjsqWO+0WLOWTRHmuCKzuE4487ATTFp+SBHOwW8bUm9HMI4X8mL/Dz3lXv86TOe1K8OeOWOFR4rIVRzBhEh/csyxawyPxqp9LIJA1DPDFcGY40Ul4C3JPWk4SwJLdXGHkv2xH3z3HGwfypBwSG866NUQ+BON1+kwYuNiCdJuQqEqM/F0aRPcGxtjErv7inpzR5foDjZ/i9wcToA/ZmoEDiZ/J6VDpVjIgU2EegwtigBJuc9cilCxdfW07LIK7G2QepM4Kfkqrae84gLHGLtWuhYL//RSk46VfWxMKno9mTl73DsSUnSPY7YE7E6z3OcVAMQTHS+U1JcpefjVsWzmFB+QzjZiMeBcXN+hBOLOH7QdPyYpu0y63tULFZBaBmRrXuEmvfq1aKRDhKDU3c17KlglI2DMk1EZ+K01L7BFclNPBjZxuKZ8lNszvsXkl0DP+MMOKKi36/y2STr2IsvCuX+B5Vea10hVU0MtyziP2R/ABcmP8zsPE4fqG1KQfXEBxjLZEmjFjfH5fYNkLK1AJ9HJpwBq4AvoDz3LGZFeeChmWDCizkYIECGopngL31OhsWCmCQmHxXG8lhkt81ZXqvxXR0wcAjfWrA4sZgV3LvvVPL10jIJ+oFHx+QEluN23sQzglsmyceuBtxh/Ig2VSNvWpMOrhPOeDGiJltRryHEhAwHuwWBqtQLrScU0TeB+AiVMxP0PXBhzlsD0cn39MamiQlcNKsHJr2Ccw7URbyFTMWn6SclOMbFT1LMksT0NMIv9GzM1vWNAL0lfsaR+5s0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(39860400002)(136003)(396003)(346002)(4326008)(31686004)(6916009)(86362001)(54906003)(36756003)(31696002)(316002)(2906002)(38100700002)(8676002)(8936002)(5660300002)(66946007)(66556008)(83380400001)(66476007)(41300700001)(2616005)(186003)(6666004)(6512007)(6506007)(6486002)(478600001)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dStaYlZ2SGs2aENjUnVsUHdJaXFld2FLUTRkY2lZQzFVTXM1em1PaVd6USsy?= =?utf-8?B?OUZEWGZhNGNGOWNkbHY4RmRrbmtTclIwd3lIejVHaHRHMlhMNUltK1NkS3Bw?= =?utf-8?B?cVI4a1NvVVI1YzJRV0VvWm9TNHpPUnQ3Mlh2ZUhZTEpQV3RKWjRCK3FLNnJv?= =?utf-8?B?V0hPTHNlYmZ4dUl0ejlHdVBoVmJmMExZc1Qya1FGRGl5b005cmsyN2ZYb1Fx?= =?utf-8?B?RTFRK3ZWbmR6cmNEWWtCVUF6cFBKTUhVNXZuekI3N3F6dmNRVmNFUFU0WTlH?= =?utf-8?B?aHpMSG1ONkFCY3QwbFdRdlRRdnNqeFI5emFtWU8xM1FaUkdrcXVOdnl5Qmtp?= =?utf-8?B?Z2VCV2FsQWkvcHJMbHFNRkV0cFlKdno3UzNSNDR3dWFiZ0RFaklBaEl6WXNo?= =?utf-8?B?bWZoMXpFR1ZWZmhmMC8zL3ZJeHNHRWZNdE13NE9PRnhHWjBpV3ljUXlhd1Vu?= =?utf-8?B?aFJseDVRZ2o4K0VYVndVczQveXgxYUlhM3lzZnlzRDhpa0N2cWJITXFLNjgx?= =?utf-8?B?aGlrMDFyZVFsQm1ERjA1VzdkWWtZbkhkZzlIdHpua3VjbmZZKzFtWTFMS0gx?= =?utf-8?B?akp0RlBTN3ZsODRHMVhmMXY0UlFGQzM3bFRLTU1DQVVkaVo1RkFEYm52cDY3?= =?utf-8?B?UHRRTGdLUHc5czBMWlB1Rkx1eVorTkVUN1N2NDJ5SFovUkNzYzJmM2FKWTB4?= =?utf-8?B?aDd6MWF4OUxNN00xS0IwSnNLRmp2ZWE1L0Z5M01aZzl5c1pScHpvTXR2Ukww?= =?utf-8?B?Y2srUVhJNWRETi9DVFlhdTZDQ0FIL2ZJcEkrMVIxckRLc3RjcXArUlRUVHlz?= =?utf-8?B?M2wvdFljOW1GSGVOK1VvdGMxMTFsS0NEcFBudVhwd1BqYVpSdWNSUkFqY3F4?= =?utf-8?B?Uy9RL0FkUEc3ckFmK0N6c1E4UkxpTGZZMnp1TkgxQlpZUkEwLzRtdmFJTFRT?= =?utf-8?B?RjM3amUvelo3R3RHRkdYWDd2YjZ3aDNoVkhWTWIxVG1QTitLQlVSVjhQeE9H?= =?utf-8?B?YmV0UWNGcjNWYzNjSnFrc2RJRVVMbTJRUkNxSkd1MDE3Z0NrdkJVbzVWaXZr?= =?utf-8?B?ODhDM2FnWVcvUnMzTnAxdEg0WWJDcXVtNkc1eTVMWFZmQ25XMnNsb1pmSjBZ?= =?utf-8?B?aVVLMTBSVUVqc3BiS2pYZ1lkaUdTQlRnNzUrNGFQZjE3ZGsvTFNMTmgyWTlB?= =?utf-8?B?aEVteDRkUlVJREhzd0xBVjFiOURmdFRxY0Q1d3g0UnU2MUhHcWRuajBuQ29t?= =?utf-8?B?dkRlb2xGbWxwRVlMK0xkSSt3U0JMTmxVYURkdkloeURTaFNtc015MWpGMW04?= =?utf-8?B?enI4anFMYkhxQ1h0SHduSEs4RHdIMDBtRGhPcU55bTBPV3o1Um5MR2dMZndm?= =?utf-8?B?WWZmb2d0TElxNGR3Qmh0M0NBYUwxWWd0Vlp0UVJBTHB6U0lQNW5UN0dKNWlz?= =?utf-8?B?QVFvNUVMZDF6RVhOVHY1aWZNUWtqSTZqa2dUSnh5NG0zQ0s5VUdtMlJiNGVw?= =?utf-8?B?K1BOUERzdyt5eVZaZ2J5NldjWDBQY01WZzhoU015L3VmUzZDdUpicTVQeGRB?= =?utf-8?B?UEpWRXphdVhMMGREMVFEL2JtYk9LZnhOMituV3h1TmhYL0FrQ0hjQTJobVVG?= =?utf-8?B?YS9nYnBPcVFYY2d3NXZIdGtobjFjdFF6S0xqNmo3NE53aS8wYVNKYkVCY1VM?= =?utf-8?B?cDVJY1lYU2dYdkJQMm1TSkgzbXFMK3BiTVF0cGFFSndYZVAxK3lWWUkzTWZ1?= =?utf-8?B?WHBKV3VKcjB2UlNrMDRmcjVSL0VwZ3BOSnNYTEFsbU9CM0sybHBPRHJWSzd4?= =?utf-8?B?aUF1SFg1cHR4VE9ISnM5S2JEeTR4VFEvcEYzd21WVUtXdXZGRDZLNmVtcllq?= =?utf-8?B?azY2QWFkblB4RURwUVZ4eUNRQTZ4YjVKVTlsK3MxcllxSXpGS05JaDJjZWQr?= =?utf-8?B?MkxiSVJZdVBTdCsvZzgrMDBjR0t5RnJURm9ScXNOb2NBa1ZEbmtkVzVDN0J5?= =?utf-8?B?c2c1bS9teFVNRWhReWU3YytoRlN2OTNaWGVIbWZKeElEcmZrdkFUSzBlSXdu?= =?utf-8?B?UFNMa2xrV1hTZmJEVUppMWozdFFxQzlqOFQybnh2Zmd6cFBXVDRJeW5mcmpE?= =?utf-8?Q?ATIQ54F2x56LAtdjAXkhjotBI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3eade7a-9646-4acf-ae91-08da9268f6a3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 13:41:14.0241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 25ln3iXyfFwaz4A1EIT9S4uIZKo8B36sDENtxQgj2IJO0swDCHT9/pLUfUr6ApjrfUKmgLRTIFdMuB8wVooFpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5716 It has been bothering me for a while that I made a bad suggestion during review: Having cppcheck-misra.json depend on cppcheck-misra.txt does not properly address the multiple targets problem. If cppcheck-misra.json is deleted from the build tree but cppcheck-misra.txt is still there, nothing will re-generate cppcheck-misra.json. With GNU make 4.3 or newer we could use the &: grouped target separator, but since we support older make as well we need to use some other mechanism. Convert the rule to a pattern one (with "cppcheck" arbitrarily chosen as the stem), thus making known to make that both files are created by a single command invocation. Since, as a result, the JSON file is now "intermediate" from make's perspective, prevent it being deleted again by making it a prereq of .PRECIOUS. Signed-off-by: Jan Beulich --- I've not been able to spot where / how cppcheck-misra.txt is used. If it's indeed unused, a perhaps better alternative would be to convert the original rule to specify cppcheck-misra.json as (the only) target. One might then even consider using "-o /dev/null" instead of producing an unused *.txt file. --- a/xen/Makefile +++ b/xen/Makefile @@ -746,11 +746,9 @@ cppcheck-version: # documentation file. Also generate a json file with the right arguments for # cppcheck in json format including the list of rules to ignore. # -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j $(@:.txt=.json) - -# convert_misra_doc is generating both files. -cppcheck-misra.json: cppcheck-misra.txt +.PRECIOUS: %-misra.json +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.txt -j $*-misra.json # Put this in generated headers this way it is cleaned by include/Makefile $(objtree)/include/generated/compiler-def.h: From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:48:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404375.646824 (Exim 4.92) (envelope-from ) id 1oWeMx-00012Y-5u; Fri, 09 Sep 2022 13:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404375.646824; Fri, 09 Sep 2022 13:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWeMx-00012R-1h; Fri, 09 Sep 2022 13:48:31 +0000 Received: by outflank-mailman (input) for mailman id 404375; Fri, 09 Sep 2022 13:48:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWeMv-00012L-G2 for xen-devel@lists.xen.org; Fri, 09 Sep 2022 13:48:29 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13c72b43-3046-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 15:48:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13c72b43-3046-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662731307; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RurGK9/j9Y+TRgZ1tZr7Hq8m+s7DzmDqjgoWSZZDWcE=; b=Bh37VtVjTKOM4Qr0yZlaCbw1sCYYdN54YhZ8cC8utOWlAgkCb/8ddpjn 8svwm2QbnvVh6PBhfUtfPzLL6+RjEK+CIky/R0iEWPxgL5XqHAo4p+tXR Vi8kziZYWX3OJkxm8VJ9MTS/JDJbOhApLI7Z6FQO040rbDstN4Mm0GScr c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80591647 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ERVuUqMLO14r5KfvrR0Nl8FynXyQoLVcMsEvi/4bfWQNrUog1zMDy TcfC22AMv6INmT0f9gkbdzl9xkAsJ7VmIIwQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMuvrS8EkHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFO9mK9cA0FmIrEgxdhlB0Rg0 Ls1GSkCO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJmagjAZBtefE8aEpskkM+jh2Xlci0eo1WQzUYyyziLkV0ojuSyWDbTUtWaT/hag0epn yGF8WvwBgxKPvaN8gPQpxpAgceQxHimCer+DoaQ8fpng0aP13cTIBITXFq/5/K+jyaWXttDK 00Z52w2qqko9UGxZt38WRSipziPuRt0c8VUO/037keK0KW8ywSEAmkJSBZRZdpgs9U5LRQo2 UWOhMjBHiF0vfueTnf13qyIoD27Py9TNnMLbyIASQoD4vHzoYUyiAKJRdFmeIalg9uwFTzuz jSiqCklm65VncMNkaKh8jjvnTO2q4PJCA0o4wzNdmak6ApjY8iifYPAwUba6/1NKprfQUSAo GQDh+Ca7eYHF5bLkzaCKM0EGLy5ofyINjvRjHZrHp8o7TPr/GSsFahL/Ct3OEByd8oJZxfue ArXuBhN/9lXPX2jd6gxZJi+Y/nG1oC5S46jDKqNKIMTPN4hL2dr4R2Ce2bBhDrfn0h8jp0HB qmJd+OCKDE3OL1omW/eq/gm7VM7+swv7TqNG8qllE38jeX2iG29EulcbgbXBgwtxObd+ViOr Y4CXyef408HONASdBU75mL6wboiCXEgTa77pMVMHgJoClo3QTpxYxM9LF5IRmCEo0i2vr2Sl p1FchUEoGcTfFWeQelwVlhtaan0QbF0pm8hMConMD6AgiZ9O9jxtv5ALcJqItHLEdCPKtYtF 5E4lzioWKwTGlwrBRxGBXUCkGCSXEvy3l/fV8ZUSDM+Y4RhV2T0xzMQRSO2rXFmM8ZCnZFhy 1FW/l+EHMFrqsULJJq+Vc9DOHvq5SFBxLorBRKSSjSREW21mLVXx+XKpqdfC6kxxd/rn2LyO 9q+afvAmdTwng== IronPort-HdrOrdr: A9a23:jnCxcagcjw3XRwr6yEOAesmkJ3BQXtgji2hC6mlwRA09TySZ// rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU= X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="80591647" Date: Fri, 9 Sep 2022 14:47:57 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V6 3/3] libxl: arm: make creation of iommu node independent of disk device Message-ID: References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> On Thu, Sep 08, 2022 at 02:23:01PM +0530, Viresh Kumar wrote: > The iommu node will be required for other virtio device types too, not > just disk device. > > Move the call to make_xen_iommu_node(), out of the disk device specific > block and rename "iommu_created" variable to "iommu_needed", and set it > to true for virtio disk device. > > Signed-off-by: Viresh Kumar > --- > tools/libs/light/libxl_arm.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 55aee15c10b4..2637acafa358 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -1157,7 +1157,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > size_t fdt_size = 0; > int pfdt_size = 0; > libxl_domain_build_info *const info = &d_config->b_info; > - bool iommu_created; > + bool iommu_needed; > unsigned int i; > > const libxl_version_info *vers; > @@ -1265,22 +1265,26 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > if (d_config->num_pcidevs) > FDT( make_vpci_node(gc, fdt, ainfo, dom) ); > > - iommu_created = false; > + iommu_needed = false; That variable could now be initialised at declaration rather than in the middle of the code, as it could be used for more than just virtio-disk. > for (i = 0; i < d_config->num_disks; i++) { > libxl_device_disk *disk = &d_config->disks[i]; > > if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > - if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID && > - !iommu_created) { > - FDT( make_xen_iommu_node(gc, fdt) ); > - iommu_created = true; > - } > + if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID) > + iommu_needed = true; > > FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, > disk->backend_domid) ); > } > } > > + /* > + * Note, this should be only called after creating all virtio-mmio > + * device nodes I think this comment is confusing. Before this patch, it didn't seems to matter that the node was created only after the first device. But the comment seems to say that the node should only be created last. But it seems that all that matter is that the node is only created once. So maybe the comment is superfluous? Or we could comment that we will create a single iommu node for all virtio-mmio node/device... > + */ > + if (iommu_needed) > + FDT( make_xen_iommu_node(gc, fdt) ); > + > if (pfdt) > FDT( copy_partial_fdt(gc, fdt, pfdt) ); > Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 13:51:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 13:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404382.646835 (Exim 4.92) (envelope-from ) id 1oWePM-0002lr-IF; Fri, 09 Sep 2022 13:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404382.646835; Fri, 09 Sep 2022 13:51:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWePM-0002lk-F2; Fri, 09 Sep 2022 13:51:00 +0000 Received: by outflank-mailman (input) for mailman id 404382; Fri, 09 Sep 2022 13:50:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWePL-0002le-4x for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 13:50:59 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e35cd91-3046-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 15:50:57 +0200 (CEST) Received: from DB6P195CA0012.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::22) by DB9PR08MB9827.eurprd08.prod.outlook.com (2603:10a6:10:460::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 13:50:49 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::a) by DB6P195CA0012.outlook.office365.com (2603:10a6:4:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Fri, 9 Sep 2022 13:50:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 13:50:48 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 09 Sep 2022 13:50:48 +0000 Received: from afc243a3d778.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F71F7AC2-687F-4C3D-9D0E-E00A852FF23A.1; Fri, 09 Sep 2022 13:50:41 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id afc243a3d778.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 13:50:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB9443.eurprd08.prod.outlook.com (2603:10a6:10:45b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 13:50:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5612.018; Fri, 9 Sep 2022 13:50:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e35cd91-3046-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fc9vGAu4eWGiVcBZlvqzzT2QlVvsl0PpG97aNesJrlt/2iTbDuBPYjMMfi7gB+LwVpaSjD/UleHTbQSa8GblOv+6iu2pyZkNmTowV407wPt80Khb1IDRKSezzftQBhRWGkpyzYIYuVirmfXmQJiNwvA+coRHHiZb028CM008n7q+TEc0x2644L9/CisZIpYGvK0E8ZtQwiP1JdebjvgWv64qMGjWzqksIadUt2n7MJw4sUJ/OpZALK4WirLu23zlCX1OtudLtT8S8MIySpu5jU2mCqsyhbKcfmQj7+c2tlxMnK6tUD8dqWjlRLtMR0n/GLILX6HylGjOqO9SAkoGyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3jDsreU1vBZNuhY/69MbfGIQEY+gr1f4wWOpZ5owf3g=; b=f4Qf9uFn5tSx/FAdtoqB3qWOTGdr44ypcZDh9nU2Wh2S+ST6Dnf3cdrrCklfeZFSeAGBY/TXMs/8yH24ZxLMfWWK+QQcqVATNz2MSkZXbqpMfA7bQp7V9yPM1ymHabBcHO5A9/V7qdFcHEsqV1zRobOUXk08OCXNpw4EvZr7XMCQfMg43MCMgFaKrj/+s+V7J7QvY1luErt3/aTxjK4ju7JbKzuefQHTXo3q2x8Sod/c+j4I553+gQ39UYcejOYjZNV69KcXBjTUP17APoLE01fMBre9oFJ1ZZai8SlzQTZmW0XJV8iFMkYBzC54MOUjjrUIKGoQqmThydBFf5PoEg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3jDsreU1vBZNuhY/69MbfGIQEY+gr1f4wWOpZ5owf3g=; b=a2BLVa19E3SiibisBkw3Y3rMXXvPl9bTqFNXiBaP6lsjfvnAOYw1EPOgC+6bSd/tkDtdrsiEQkXLS/K4ydbaen4Ym9nmah8p+1STsZD0tqYL9hcehjizImTnnCvtpmkTkPGo+4UpI4dhJh9xxw5sxWWChUWCm4QY6pIqOjxc0Ew= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8cb0ae331638fa43 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdsPMPmuvlIURfcaH/tOL4KJMUdCbvrf/tunSf8CnhWTLD2LzG2TNQALbUTcSjU7hlyeWsf/LXYujVnLHAqDuad+jWhEnHeh5Pt1j98QjMb2x6EHtwOcY4F8829E4wAPpoVGSFmCR70rXbS6IFvuU3HchpeGGupJwDMoW2JWflkI44wrTT+vO7HyGT+X67Uw5LsXlUnPg5GZZLAI33RcesbTTiD5FMeTYRLPgphPNzqSmu9+RBNsZojvMAGIxZgt4zU89hwfnxcu6nG+wmVR+GQsZ+ivw6Sa1oON7Uxud8ZvD7KsiRbAAtKmKU2dlH7nhKpeGFgV2CL6YI3WYE4Kjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3jDsreU1vBZNuhY/69MbfGIQEY+gr1f4wWOpZ5owf3g=; b=enWRkQU3FQ79xeQMFVG84/OvyXKcZ+vrLp/rXpTSWLZLpK5IXhGWHNsLWYifN0G/29V/QRNQaGwhWqgzoL6+/zMRcBslkrH1OzndOqOX3lrgrr4UPtayt1q+uRyJV9d9onHaZCEeMxO9WWOm8hsjp3v8f9nMoizCjuI0vUi4WXZzMN3tTpemxTT+es24r74KVL2+QWunbqFispuqbyaaKSczQV5tR5GlkyRZjgtn+EDWFDtf8xbkyVGy/hXJuBeAC0Exp2ebK9ru/M1RxMD+TdT7MKeyjRNM/OloePxo5G8/WsYMgtcHJOAAofDsjnsmSORTlT0h9HROUK6G9LgTDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3jDsreU1vBZNuhY/69MbfGIQEY+gr1f4wWOpZ5owf3g=; b=a2BLVa19E3SiibisBkw3Y3rMXXvPl9bTqFNXiBaP6lsjfvnAOYw1EPOgC+6bSd/tkDtdrsiEQkXLS/K4ydbaen4Ym9nmah8p+1STsZD0tqYL9hcehjizImTnnCvtpmkTkPGo+4UpI4dhJh9xxw5sxWWChUWCm4QY6pIqOjxc0Ew= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard Subject: Re: [PATCH] build: correct cppcheck-misra make rule Thread-Topic: [PATCH] build: correct cppcheck-misra make rule Thread-Index: AQHYxFHaJwlnNsxgQECM5kPu4Ki3xq3XHaOA Date: Fri, 9 Sep 2022 13:50:38 +0000 Message-ID: <8FB0B363-FE6D-4BFA-B5D7-E0C00737D3FF@arm.com> References: <0dbef17c-be73-1d88-cd20-83f3123361bf@suse.com> In-Reply-To: <0dbef17c-be73-1d88-cd20-83f3123361bf@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB9443:EE_|DBAEUR03FT014:EE_|DB9PR08MB9827:EE_ X-MS-Office365-Filtering-Correlation-Id: 13a7e213-4729-4b85-f1a9-08da926a4d59 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D27H464Ly1OoRT4BdIF+EQIa3qvqSBpxG+rHEOLdHc75vU1hf4lMMkBDSU8BA3Gjk80QbgZnvQV5WiQIRgTw39aXftHSGV8p4wl8oi0GOy6hst4mEmwWwW8x2GDcqgVtAreFbYdZYVd10n9n9q+5psmB6OMkh6Hs2Bp1BggEhSaxcbxctmo9oP7nAIB9mGp/IbdVNGOzDkfCvzNUA4LLsb+nh6A3+c3YMYVevPReDHlxC9ocrx8C9HjrphhRpdsuXZDDMIUtGCJu1SkygWL87TysFqfXtXBcPVEu6npXxPqI+FPM0umPBcxppFwzqXATT4Y/cz6+LvZFxl0qxWsLRg6wK/YHFqUyUG07Gf9HMOx2HZAKPgU6OH+meFf6D+q12q04HKu5nujMJEos4aUK3awbIedr1gIvnXirJ7M70eIwVCMyYGQMqSafmobZPKxHe4YUQfh8iWbWdZlImCkF8ohi4waNdMc2nfVuSmyD35kpYnT24SR+k9nfXYDDptctoq0APhhOSHW8NcVnT91NIuyxCykkyxc4jY9Aw2OJDiIktffqb2o3GEtnpohSPC/GZ4E6S/ShZJgQDR2849Sr8G7uie7sEABnSC8EovWA/MJ3xJE1sbgYpGrwkjx/oFxmiI85n3N3t8WyhHVpriBZS/qKd4/cc+sjxJEOF3AYo2nA9ZNoswo3rEUPfevDuKFFEzyj0aCIrotZXvOFHzx60twijqZGXSKwbJn+DOXDwPbOBdeMKsp3BzvLwA3OjYBaVH0d1wg3VQWVYrXtJg2SlF/9C3LlUqQLkWc6ABZBR/M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(316002)(64756008)(54906003)(6916009)(2906002)(86362001)(66556008)(38070700005)(8936002)(66476007)(66446008)(66946007)(5660300002)(122000001)(4326008)(91956017)(76116006)(8676002)(36756003)(2616005)(71200400001)(478600001)(33656002)(83380400001)(186003)(6486002)(41300700001)(6506007)(6512007)(26005)(38100700002)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <2257647299309C41AE751F4CE067AC49@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9443 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ab2213b3-8273-4cc6-4595-08da926a475d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gop4N0n7Oe5DzFiOsWbWUzmVR5Pf4BZe9QJJwOsS9lRvAEfOtRjHsVTN1fV8yERxEQpjiitYF9uFvP2iHwoXWXgjBbyAwkzG49WGgfZChHKm4CJ/kjbDc6+rgyd1aG2xW9HkNwLGhTMQeElU04I9Cp5OeyRvq7a23tZNJdj7RqYj6BRdkXN9gGJYfrS/sDvewF2wdT0VAYD+KqgUOuMYXg66Aqi6eKSokXJHZ3IdUUnZ7qyh6zzM8jb6X8OgM9czDyop1odQnzwVgiURP+a5doUBqbrflE/liteuXb97DBS9Jy6BpqSOF5qOVLWFHYQ97e8/G0cZ9HhBhzLcrqlBYMQLUPrIznEIMgKmhYRZp4kbyK+HleglNSCLcPPAm6G6Ji0ULQTVx6mYv/bZ3nam7QZozozgANLXPEuF0USN9KvvqIRcya5Z0xYg6QvbvdeHaa0ur79fkg7/cwdxZEww9p6iqroBBl5abTlUvcG6ny9fWDFMurSe2Qvk7F9GxxcOXMAUcQrS72MMtw0RyPeyWpjrWAWzGExJ/VTQVgBnh0F8ANRxyNd+yljOKtpiX95n8BshSu4HSTciHV329EbyFoKaWPJ3imFPG8JwaXxDeL2HV4SaPYHC7mnK/Sv0G/xG7+OqxBATXNy1nbVROIuoMGpUnWhe0Hp6AurEeRz2iV6fDKBJe76fSTqnC6vaDOf6QenrjXV/rmUBKmyBizfbARUChbIJGeTbecFokcHAhEcSRURwvLmlaHIunAH7iVIGPnK0DuCy28Kht/i/tRJrig== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(36840700001)(46966006)(40470700004)(6862004)(53546011)(6512007)(356005)(6506007)(26005)(36756003)(5660300002)(82310400005)(8676002)(2906002)(2616005)(41300700001)(6486002)(8936002)(81166007)(54906003)(186003)(82740400003)(86362001)(478600001)(4326008)(316002)(70206006)(33656002)(70586007)(40460700003)(107886003)(83380400001)(36860700001)(336012)(40480700001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 13:50:48.8119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13a7e213-4729-4b85-f1a9-08da926a4d59 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9827 Hi Jan, > On 9 Sep 2022, at 14:41, Jan Beulich wrote: >=20 > It has been bothering me for a while that I made a bad suggestion during This is not a sentence for a commit message. > review: Having cppcheck-misra.json depend on cppcheck-misra.txt does not > properly address the multiple targets problem. If cppcheck-misra.json > is deleted from the build tree but cppcheck-misra.txt is still there, > nothing will re-generate cppcheck-misra.json. >=20 > With GNU make 4.3 or newer we could use the &: grouped target separator, > but since we support older make as well we need to use some other > mechanism. Convert the rule to a pattern one (with "cppcheck" > arbitrarily chosen as the stem), thus making known to make that both > files are created by a single command invocation. Since, as a result, > the JSON file is now "intermediate" from make's perspective, prevent it > being deleted again by making it a prereq of .PRECIOUS. >=20 > Signed-off-by: Jan Beulich > --- > I've not been able to spot where / how cppcheck-misra.txt is used. If > it's indeed unused, a perhaps better alternative would be to convert the > original rule to specify cppcheck-misra.json as (the only) target. One > might then even consider using "-o /dev/null" instead of producing an > unused *.txt file. Txt file is used by cppcheck to give a text description of the rule. If you look inside the json content you will see it mentioned. >=20 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -746,11 +746,9 @@ cppcheck-version: > # documentation file. Also generate a json file with the right arguments = for > # cppcheck in json format including the list of rules to ignore. > # > -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/co= nvert_misra_doc.py > - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j $(@:= .txt=3D.json) > - > -# convert_misra_doc is generating both files. > -cppcheck-misra.json: cppcheck-misra.txt > +.PRECIOUS: %-misra.json > +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/to= ols/convert_misra_doc.py > + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.t= xt -j $*-misra.json As far as I know, this is not saying to make that both files are generated = by this rule, but that this rule can generate both files so nothing is telling make here = that calling it once is enough I think. Anyway this should work but the commit message needs some rephrasing and I cannot test this right now. Bertrand >=20 > # Put this in generated headers this way it is cleaned by include/Makefil= e > $(objtree)/include/generated/compiler-def.h: From xen-devel-bounces@lists.xenproject.org Fri Sep 09 14:09:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 14:09:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404394.646849 (Exim 4.92) (envelope-from ) id 1oWehY-0005IQ-9C; Fri, 09 Sep 2022 14:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404394.646849; Fri, 09 Sep 2022 14:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWehY-0005IJ-5b; Fri, 09 Sep 2022 14:09:48 +0000 Received: by outflank-mailman (input) for mailman id 404394; Fri, 09 Sep 2022 14:09:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWehX-0005I9-9s; Fri, 09 Sep 2022 14:09:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWehX-0003HN-3e; Fri, 09 Sep 2022 14:09:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWehW-0007kY-O7; Fri, 09 Sep 2022 14:09:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWehW-0002qE-NY; Fri, 09 Sep 2022 14:09:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pVHuAqQlt9p9SrhoDCgzdTDd6hBPxa+22ve+gGGTg8o=; b=gJOcO3vsufyLe+KCt/L7z5fwmv niqlg64DGiX5jpTGv/5O4l1WVq84/J4QjgLzTej6PffyEBExpMYKDFOYvk7bHXAnHEWcz5UqLWZ1L JwCiHBUI6BYgjudMrolYOGHB54x5tne9naXjN+WKD5I7VHNG0JPvMq6X5KSgJS+gU4JI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173092: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 14:09:46 +0000 flight 173092 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173092/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 275 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 14:16:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 14:16:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404403.646859 (Exim 4.92) (envelope-from ) id 1oWenn-0006iI-Vc; Fri, 09 Sep 2022 14:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404403.646859; Fri, 09 Sep 2022 14:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWenn-0006iB-Sz; Fri, 09 Sep 2022 14:16:15 +0000 Received: by outflank-mailman (input) for mailman id 404403; Fri, 09 Sep 2022 14:16:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWenm-0006i3-By for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 14:16:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f46b0cfe-3049-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 16:16:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f46b0cfe-3049-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662732972; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UF8rHxyZOmT2fyi/Ch6uiR98I18jNBc5mz41L/t6Il8=; b=NhV9CqFTxAAR7XCChcOEUkXTX7uQTNQRgHw0ughpr4fQbDCOsrVK0AtL KNMSvj2i/G1ahOs1wAOW6f7Wt0U2BQdzU9lAXJ9UGwomKkjMMB9KutOc6 kmDo6QxJ5EddMMOE8Wkv871DYF6I9bNDLVmugx1XfD8ECnATkEZIRVs3k 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80158400 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A4DHLuqCO8nFb4hVWkefolDw43h7EJoYKCyr0Z?= =?us-ascii?q?L5iHsvXIB87LLMz+jq9RysF0KIuFCQ9jkkCHt/CeD6iZW5agGHhqyaHLhRGR?= =?us-ascii?q?9peelVxHpIyJc6eOtjwBKd1URbCzPQDRHrx1H6Jld1w4m/vyXYSixIqJvIz1?= =?us-ascii?q?65qrO+WzwHGuhvt6CgDh2Qqx5Ovvt7i0MZ0hE0x3O9ZBis87QW4iLpQkKHh0?= =?us-ascii?q?o1CSEharG8DdL/Ec9A5tso5FwTPJVFgG7RLZ5TLn6afdlqCo+AF53jWG3tPM?= =?us-ascii?q?tUJvNaAklQmPq+3UA5RlA1xg8hceBdaCWHZLX/gkDOQeJyLb5/utzlCObB/j?= =?us-ascii?q?hHtkLKBPONxFVcsEn435cPBL/too+94px9OvoQ6NR/r1BhySDdBZkb3eHCS1?= =?us-ascii?q?MwOAWFPuAcM8Y+xJqDnKfk5T6Q4VyNTQg6NCJ5UBsWFsAcSPYy2K5jhT232J?= =?us-ascii?q?QugJdewhl14HMngtQg9PZAnLJqecAWau7qcWdviUoK6cKHSv9TiRlaxul2zb?= =?us-ascii?q?bvbp3Leu8Bb444GiaaEHysrnpTCDihiP2ay6+RHmv0Yz69MitFoZatQEhxOg?= =?us-ascii?q?vBIbXiPEnLVaeGPQEkfDkWbvosQTpq8SNk9I4ZLhDxVUdUiku+qX0EqLSX9e?= =?us-ascii?q?VXmp2e2+NAJUEryWb9hYn56ejmOFxFZrRH23jxAMkVqoe9ggwxI/3CataZ3I?= =?us-ascii?q?mZb2Qg1QDPwXn6slIj0zePtc22izGHX86fqiCSH98DLmzoYtHg8WF6sse0wx?= =?us-ascii?q?uMjyZWIvCKNYcittNia3qQEOBmNVHTw67h+76PP5J85zpnFYEHJHGROUJlIj?= =?us-ascii?q?V6E1acXqwrrsDrWCnO2H/IBJEWqikev9zd2M2qtIsnS1NG1Iwod/8rOKlczW?= =?us-ascii?q?TrKlZxZuxqjyKusyIwczkentzQglcrkdga3HZok7uNOLZqrlC6wrjFVWWf0P?= =?us-ascii?q?g4DPZDi/u8q4ouaT5wyEfN61Ob1/Z1u+eonFIj2HI8sS9oeDWL4BiaOpcQrh?= =?us-ascii?q?jkOz37IQY9AulXF5qI1QaAJWsV56QK96db6wHggI39UNCQI6sgUsMETG0NDv?= =?us-ascii?q?duHxaNJU3T3AB8nI9QfID/ezKJiiKXWifuXqICH0rJ5HSWaa6A5vZ8+bVE3c?= =?us-ascii?q?Xf8SyIo/LG6H+PitZU6+AAHvmoO4hxiKo1Le+CNeKqw29GsV09iMF+yw7iRd?= =?us-ascii?q?szjbXoyuAP4fWAIvGrhrbNreTIIX9siMLOplh1Iontb+OL5GO8LJuVhHQD+N?= =?us-ascii?q?savHaHaWXHJ3OroQLaRPU4aQ19zABKaE9PzHIaYkCkBmLk6hEUHJ5oFDSbky?= =?us-ascii?q?oY/v1r8vuGoEkk9SSZe6bnIEtglZghWPL3n2CAnvGBClpSZfLSOCsPBQIyWC?= =?us-ascii?q?YYOjy+dl0E0YfQ9v3BX2c283pRVhgC0P5Z1NpV9hk3HSVg6Y1oIU1VjezZk1?= =?us-ascii?q?vnp8nmhyKpmOyRxdIEywO9oF949r7bTV21etbyEL/cYDCTGnVH/hryLh464w?= =?us-ascii?q?kGgwh0DQVcmKDMjxNBv7qzY/A4+LOyKtHf2e4K4wXEdgUbAJzaGSCSCoiA/1?= =?us-ascii?q?G+DJSwCTKyAB+pEuEMKNRIrwjEzs34cyImRUzvmLLcHAMguIUYQY4QrBeJvh?= =?us-ascii?q?LqaYQv5m+CYPZDG2Pl1dbALWvHBKO4p6DdLyg5GlcP8A3dPOG3Jrx908GtOH?= =?us-ascii?q?m/Mfr3Fz/qzZodO2WF1u0NPYm1bSXKdBYAfd+m57ZnMAvJvRFBlKTO1IDa2W?= =?us-ascii?q?jkF9jjvPzC/EPY6FNUkX4q+7JIUZMtCA6YvOdvZwS+NX/y1mtWXLmeRVM/O5?= =?us-ascii?q?P7Qdd7v79vSym9cq4MvQfTr2vrnRG8CW4yHZut6I0DAg2O+7n6jWynz88apc?= =?us-ascii?q?fqgvHizuVTkEsh1UXAiS1TOBriX6DrdaJutiEitOQl33Zu3sS/WtuNFGi/nG?= =?us-ascii?q?OZ05TQV3/4xDPNiJV/Zvk91Lhg23nv1uUvKr0Cuk0eT+KUDdf4VtyyRGYn+G?= =?us-ascii?q?7295Yr/Ovs2B7TIBYlfAOQTFF5hhMe6yYNazmaKinBK5vkjZNnQ+vKfTP0vK?= =?us-ascii?q?9Whaf44dk6Z+6aee5l4Wdi+mgwSlDB5pgd40zNVWyL2CBCxxSQBoDe22AAVy?= =?us-ascii?q?XmYVJB/ehgVj4L/gD2HgBJ1QuJc5TrlvUMujF6dPluXlCGiO4fTYOBEzw5tK?= =?us-ascii?q?gTSjINjN9N+14bKI0nJ6QNrR3A4u1rTX3btw0mk9oznKpH4bc3NYmRgI1zu/?= =?us-ascii?q?yN5rPY/JjjLM8rVc6hma9r9O52jjUn/0PRQal8MSXErcUUHbzGN0wFbSAP3g?= =?us-ascii?q?pDwKR8G+9OqpyRAHYfcG2jX3sKsUT59gkXz00NnS0KNjHU5DHSOqw3X4yh1x?= =?us-ascii?q?oQxCQG6dgsIJycrcYGEV8I6iaRXv28hFeP7hLnYp+HoSEOsb/XhTRJn8vqkd?= =?us-ascii?q?fNo3WKUXNSIsCJ19zkBnk3pJJLXRZhVNrAN2Fv7y0sy9/LR5hIXkIZOl70ob?= =?us-ascii?q?5Xo4OkvFGOLnrQYRMJNr4vYIUwmFjKdFy2E0sE19/EmHTIa6S4b6bmNLYkUy?= =?us-ascii?q?TRIOnj5EaBEJbG0VrN3qjRWMMEc3KVDO/OR8EMH3+8WhoZOFXrCi3syyD4Ix?= =?us-ascii?q?siGgM2/aV/AnRBlTuJGZuOfQmQkAmtiL4zHmpkkVQo7aKJv0+8qKRPnwOd0O?= =?us-ascii?q?AXyuEXO6w46uUL0d9jN3/Y595CXZlg9MMUcNFNlRiQRvSN9NIyuYR0H3id46?= =?us-ascii?q?tGsiYxwJg1OuN/oxoM1ehRjWIr/7xwZ7VHlETplr2EvUNEHHrqIet9/O6pMA?= =?us-ascii?q?7IMYNsUIqofPJ36FUCpMC8u4sGvM+Dzvk09R65oR9vf+oUqHfCJiz9nme7fS?= =?us-ascii?q?6DNbMY3Gg/gvuL3TFoS6UF9jeceL2JF6/Nutc2IcSnAcdgJ?= X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="80158400" Date: Fri, 9 Sep 2022 15:16:06 +0100 From: Anthony PERARD To: Bertrand Marquis CC: Jan Beulich , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] build: correct cppcheck-misra make rule Message-ID: References: <0dbef17c-be73-1d88-cd20-83f3123361bf@suse.com> <8FB0B363-FE6D-4BFA-B5D7-E0C00737D3FF@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8FB0B363-FE6D-4BFA-B5D7-E0C00737D3FF@arm.com> On Fri, Sep 09, 2022 at 01:50:38PM +0000, Bertrand Marquis wrote: > > On 9 Sep 2022, at 14:41, Jan Beulich wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -746,11 +746,9 @@ cppcheck-version: > > # documentation file. Also generate a json file with the right arguments for > > # cppcheck in json format including the list of rules to ignore. > > # > > -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py > > - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j $(@:.txt=.json) > > - > > -# convert_misra_doc is generating both files. > > -cppcheck-misra.json: cppcheck-misra.txt > > +.PRECIOUS: %-misra.json > > +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py > > + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.txt -j $*-misra.json > > As far as I know, this is not saying to make that both files are generated by this rule, > but that this rule can generate both files so nothing is telling make here that calling > it once is enough I think. A comment could be added, the same one as the one used for syncconfig: # This exploits the 'multi-target pattern rule' trick. # convert_misra_doc.py should be executed only once to make all the targets. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 14:21:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 14:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404411.646871 (Exim 4.92) (envelope-from ) id 1oWetF-0008Uu-KY; Fri, 09 Sep 2022 14:21:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404411.646871; Fri, 09 Sep 2022 14:21:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWetF-0008Un-Hm; Fri, 09 Sep 2022 14:21:53 +0000 Received: by outflank-mailman (input) for mailman id 404411; Fri, 09 Sep 2022 14:21:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWetE-0008Uh-Ld for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 14:21:52 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2042.outbound.protection.outlook.com [40.107.104.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id becf62cb-304a-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 16:21:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8312.eurprd04.prod.outlook.com (2603:10a6:20b:3f1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 14:21:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 14:21:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: becf62cb-304a-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0kbDQ4bb2W7oEF3aXRmd/GGSAEnNyYnlvS11vGvZ8CPFU9oj9Bu8mUM2OV08TgVv8GEQnLgO9YtNiHrwwdwxEkP6vGsJOMy4MICuRbuWgbfsm6v3tBrL2Q/IFZlYwktf7IsEpgpBpPFrP6xhzYbw7vsdx+HsQALFuL4Y7jr02EU/P825hn6sKLMSWEE8aiGZpC/ntNoE6lqxIi5Wi5+3iTzI6mxN+7nlOjHU4/eohQEpCcKEYig7tRzXQ6b0YGAITgPWUbPVjYbNkYhn+vkMfzbcs6EIwm/tyrqTINaPxO5QH8jizH1WjjRaWz5lFCf1cWhd1bs+piE+WHa7VC6FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRke+5frwSExLZEbhuphMT4E8VuOaqwzkQoVriMaJQU=; b=mF630snR9VqlVg+/KOsCMj+LE6I1QoFKB/VaNyQhm5WqPnB2Y3rsJIesfF+PD8IT4p+NOQHAtPRMSzhK3qLNkLGErv/3U8FZs7j3v9gvPmMY9fai/ubPhGgu0Ix8w+eakT8umJqAC+ig3RoCjZayWjXkmeZ4+wfDChf++0MGtwcKpDhm5/ySCYlVZwsxAcJ4voKSk9MddVbMXV/WbF4R/VdQ5eVQAbKiCBMZeOFo/yblcuB4rXnxqQrHLOHnlx8L52It/wOQTPSAftW0WJ3CvPu6z3gXokJKbXt1ywAk2WVRRvDmcMUyoV01PMt1fWAbihymEeiddB5KmHKyxUkadg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FRke+5frwSExLZEbhuphMT4E8VuOaqwzkQoVriMaJQU=; b=PB1tlHi3zI3MePwtGkaVnDA3NgTezSiOyLfIw9AB7dWK7f7KELEmIw+lgNCmLcGpIa4QM9UzO+8C18YFVjo7AtBYFIlBU+AQ0P2wHpVG77PU5/rNXvMNnDcT2M8bd8dIidurWriOom2iNEKN2ryKOLw2eUreFsib9+a7voqbB0X3824LgDVwjOrSx7e3yYKjbNdYlqUmhbVqPMPSZ7mO+3kLOmzfMEqEVluwDr04N+AVZP2DGvXA2rM5nU6LpYd+0qJIEcLW/w4raM/G5rkMHPtorzJGgJaQfSyZQr0b+QRgtTYFzTlKviWNI/Eg7lt7lKvUmX2k5xACW5cb5Mvhpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5fb1d3c0-e06d-ad57-0ce5-cb9f906ace99@suse.com> Date: Fri, 9 Sep 2022 16:21:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1c23930f-e809-d623-18ec-599a0e983b7a@suse.com> <6da822fb-e900-156b-334d-8bc573b74aee@suse.com> <7eebd88b-f7a5-5dd3-7482-5086cd745940@xen.org> From: Jan Beulich In-Reply-To: <7eebd88b-f7a5-5dd3-7482-5086cd745940@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:20b:48b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8312:EE_ X-MS-Office365-Filtering-Correlation-Id: 374efc52-bd34-46fb-4257-08da926ea1e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CecVGnkMZreS2XuM9ZvBywC3+6EZ8TBQcwjm3JPGahsQzF5bVePybzyt/n1HV8TDfFXy9uG4+aC6WZgHCdejHC0h9pAU4SQGNJ3f0kT+gaPjV9xlQwac/9jTvPGrc4bLbJcxXFE5vAaJrI2558AcGDPq7TWAdmXIVaYfBlc7fijNsvm4D9iNk0LkT1DWNprdC2ylKeKXE6smbEcFyunqkaLidQ+LPcqmGYnmuBxhSUJAC1MqvFxsHE59nJDy2o3EM8x9e7Nv9Z07S95/ixx/VclMJbKOyvBo5rjPmdDAvrQ8n5JlojO25gbHTpGS6+Z737VyXrwKh1i4hAuSK402i4NiVPkj287+CoGidEYEmUNJAY952VZV01Q0dFkCji8G12+ZeLAJ0pGIVM1olpbW1zOlj7cIpx+8AaGnPhjh/SASdvENMZNE0y3l8OSUb4DQvQ15FvLHKmPMK/Z6pqAuDn8+6HN6DrXzNgGg2TwzzeDfuZcnlhnaWAF6UvByP1Q1kLXrGT/z4iEGo13mEiS1DK/QduOhNcoFVpHBu6Zpg3eoUJAW4xBiBZqcjs//VLORdH4oIIpoq6fHU5dj58HQpXqO66/x6PL1iAXn1km64y6j6U3TVfqyN8scNiWtiG7wDrc64NAGGiZr/yhoKge5kixxYNwoqgeTDru/XwlCLOtn/KP8SLeHURq1R/n5nYtPEwpdw2hkOAb5IEMUGoymp3wrO6AqUCGuemNUyJJ4PsOcaiHUiCs5L9UJh32ErXXARqgC4WHpn2Ed3P6qjEBFbVQeeX+1B0G4aFm/dZfim4s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(396003)(366004)(136003)(376002)(26005)(186003)(5660300002)(2616005)(6512007)(41300700001)(2906002)(6506007)(8936002)(86362001)(31696002)(31686004)(53546011)(83380400001)(6486002)(478600001)(36756003)(316002)(66556008)(66476007)(8676002)(66946007)(6916009)(54906003)(38100700002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXQ3dDM5RU1veitwRk5QVU85QWdZUHZaZlV6eTNuMkgvaGwyVFUyTTAyeFBS?= =?utf-8?B?VmlXc0EwemEwY0hVK3FsRXlRM09QTW5IUlNVWGFDT0pMT1BCZVYwY3JTZHpk?= =?utf-8?B?VEE5bXNJRDluMDE5M3J5dlliRDI3ZEJhcEJqbEk5TDB1Y0hkRkVaMUhXTmRM?= =?utf-8?B?U25qUkxxOFdZczBWeCttb2pZWkNDVHZhb0d1Z3dvdU9ZR0lOZ1NCcXg0S3V0?= =?utf-8?B?eUl5S2lNL08xcjRVOFE1WVY3Ulp1amRIVkJzTDU3dldpbUNXMTBCQlQ3SDc0?= =?utf-8?B?SndWbWhqSWdQYW13VU81eWQ5Nnd2K3h0NkUwVURZNW9oN05TWFZSMkNQTTlQ?= =?utf-8?B?bWl0NE9DcERSTFNpRG02M3VaNmRDODljQ0kwbldNYjNlNFZXRi9hSmpBY1Bn?= =?utf-8?B?b2l6TDBSU3htcFBQdWxyL2cvWUIwWHpud0JFQWRpSWxZYmpuN01oZGRrZnV2?= =?utf-8?B?bWFZcnJjZGZqZVJObGhnVjZ4NFEvd002bzdIMGtScUI0SkRrWDlyQ0Mza2lQ?= =?utf-8?B?dFNpMWFleVgwMU9hdGtQb3NsWTFtNzBlYUllSUNsUDFteUFaQnNGRTFja3A3?= =?utf-8?B?U0lKbUg5anpSNDZhbVhBZEdNMGFXV2NONmwxeVp2bXB1NHlnYjVZUHdjS2RQ?= =?utf-8?B?SktpdjBGSDlmM1M2aWlRbU0vOU1sUGVOYUZQdGNSV3dZK2I2SjNRckR2dlA5?= =?utf-8?B?VTZ1aWpxMXFadUQ3TVZRbGxLVkZOVFAwWHlUSXR5RjBIY0lXakh4cWgrcGl4?= =?utf-8?B?K2E1bml3SXhCVlRlMnF0cEIyTkJIWlkrSjhZQmd2Zi9oakhWMW9WRWVRYU5m?= =?utf-8?B?eUhsUHJwZ3dJRXNFZ1kwR3VHMkVoQS9vZjlTaXg5UkJyRzNGcHQwOW5JVVJV?= =?utf-8?B?UTFMamVDdE9mNXllMWZ0SUJONUowdWNjeGxZQlJYTDBWYk5XdS9MamlQR3FF?= =?utf-8?B?YXl4Z1dIc1VUSjhFaDdzN3dyS3owcjFaa3l2QktwZFlMUjA0TFVpNHR1b3E0?= =?utf-8?B?UmI2b2dNM2NYQm5EVUtEVzhnRjYzTkJjRXcyQXlSQkxPeXhldERPUUJqR0tq?= =?utf-8?B?U2JvRzU5Ni9ySzZoL0J6UTJSSUJIOWp0ZkdTcVJ3T216cC9sWDRRbGhNYjlh?= =?utf-8?B?aWRkUHFvaFZ2emVuZ2tYL2M0TnRQcGlGV3IyalVtbmtsZndZOVpsN0dFbFdv?= =?utf-8?B?N0k5cExERjgrdXlNYWtPcTE2cGgwMjJIMXp1a1VhSU1IQWhNblFWY0tiajNT?= =?utf-8?B?MWxic3R0YjNMS2Jjc1oxczJPRWg4dDZtVjdlT3FMSzBNV2VDLzE4OENNdXpB?= =?utf-8?B?ZFpicG8rNzR4VVozTXB2OUhWMzJiSmMzRDVTWCtJQ1o3TnZKNDc4OXc5eVpP?= =?utf-8?B?SWZaRGovRUtPNUxtcmx2UTlIbzBacW05MVkzRTg0Vkp0WUtHK0dLdUs5aUVW?= =?utf-8?B?Zk5CVGt1RFAyamR6U2ZFeU9mUHh4TFZKRnRNQmVraFU5NzJIbW94Zm9zYzJl?= =?utf-8?B?dE1FVExvNnAveHFkd2NVb01DNEptbVRvSUdScTVPRkVheVQ1bldlZnJpRWpP?= =?utf-8?B?SkhTUFA1ME9GSmF2cUVNS2VRTDZ2ckhjd25uR1h3WVh1cnREdzVTVkljeW5E?= =?utf-8?B?MUdKVnFidEoxbXRKNzd1a1Iyc0ZBT01xWnFicEhmRytSTXpOaG5OUUVkQi9F?= =?utf-8?B?dlJKSlZsQ0IweE9la1VmMTBIM0QySk9DOTdUU3EvczN3bjArZ2o2QWpDQmFF?= =?utf-8?B?NXk3NDdqcXl6czUwbXNKdVRUakc3VkdMWFd2SUN5Z3JTakVTQ3JGNVUyNm1N?= =?utf-8?B?Vkg1Q2d5aXhSSUZRT0xKNzJWVzRIWUZ6ZnhBOXNkNjRjTWluRTZWdkx1bktG?= =?utf-8?B?WUVSWnlrd1hsWFJKekhJVEZSaUU4NzFWbEtDL2JNak1HZGlkOFZMR2FNYzNz?= =?utf-8?B?WG5PZW41N2dkc3lpeTg3MjRBRk9XUlB3VXhiNHFoVWxlU3RGTk1XMHA5bTMy?= =?utf-8?B?VXlScWxKSFZhaUpXelRveHJhdmsreE9pdi9YUVRtdzBKSHlQYitFclN2anVU?= =?utf-8?B?b3hPTG5RMzNZc2xLMi9qQnNzSkhabm1kbEJLZWxoNkprS254dXdlVU9Ycmt6?= =?utf-8?Q?PQ2bN1o0wWx3v6E4O8BF1v0v9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 374efc52-bd34-46fb-4257-08da926ea1e9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 14:21:48.8541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QUR+rv8XMa2VJG6137APHOPAMTvwQupJsHZWcL2kzugVXFnSYi+21egOaQI8sFdhZCn8JpBRztP5Xn5zwgZ72w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8312 On 09.09.2022 14:27, Julien Grall wrote: > Hi, > > On 09/09/2022 13:14, Jan Beulich wrote: >> On 09.09.2022 13:00, Julien Grall wrote: >>> On 09/09/2022 11:18, Jan Beulich wrote: >>>> Gcc12 takes issue with core_parking_remove()'s >>>> >>>> for ( ; i < cur_idle_nums; ++i ) >>>> core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >>>> >>>> complaining that the right hand side array access is past the bounds of >>>> 1. Clearly the compiler can't know that cur_idle_nums can only ever be >>>> zero in this case (as the sole CPU cannot be parked). >>>> >>>> Beyond addressing the immediate issue also adjust core_parking_init(): >>>> There's no point registering any policy when there's no CPU to park. >>>> Since this still doesn't result in the compiler spotting that >>>> core_parking_policy is never written (and hence is continuously NULL), >>>> also amend core_parking_helper() to avoid eventual similar issues there >>>> (minimizing generated code at the same time). >>> >>> Given that CONFIG_NR_CPUS is a build time option. Wouldn't it be better >>> to set CONFIG_CORE_PARKING=n and provide dummy helper for any function >>> that may be called unconditionally? >> >> That might be an option, yes; not sure whether that's really better. It's >> likely a more intrusive change ... > > I quickly try to implement it (see below) and the result is IHMO a lot > nicer and make clear the code is not necessary on uni-processor. Hmm, we can do something like this, but ... > This is only compile tested. > > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 6a7825f4ba3c..f9a3daccdc92 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -10,7 +10,7 @@ config X86 > select ALTERNATIVE_CALL > select ARCH_MAP_DOMAIN_PAGE > select ARCH_SUPPORTS_INT128 > - select CORE_PARKING > + select CORE_PARKING if NR_CPUS > 1 > select HAS_ALTERNATIVE > select HAS_COMPAT > select HAS_CPUFREQ > diff --git a/xen/arch/x86/include/asm/smp.h b/xen/arch/x86/include/asm/smp.h > index 41a3b6a0dadf..7baca00be182 100644 > --- a/xen/arch/x86/include/asm/smp.h > +++ b/xen/arch/x86/include/asm/smp.h > @@ -61,7 +61,15 @@ long cf_check cpu_up_helper(void *data); > long cf_check cpu_down_helper(void *data); > > long cf_check core_parking_helper(void *data); > + > +#ifdef CONFIG_CORE_PARKING > bool core_parking_remove(unsigned int cpu); > +#else > +static inline bool core_parking_remove(unsigned int cpu) > +{ > + return false; > +} > +#endif > uint32_t get_cur_idle_nums(void); > > /* > diff --git a/xen/arch/x86/platform_hypercall.c > b/xen/arch/x86/platform_hypercall.c > index a7341dc3d7d3..5d13fac41bd4 100644 > --- a/xen/arch/x86/platform_hypercall.c > +++ b/xen/arch/x86/platform_hypercall.c > @@ -718,6 +718,7 @@ ret_t do_platform_op( > op->u.mem_add.pxm); > break; > > +#ifdef CONFIG_CORE_PARKING > case XENPF_core_parking: > { > uint32_t idle_nums; > @@ -743,6 +744,7 @@ ret_t do_platform_op( > } > } > break; > +#endif ... this needs doing differently to prevent the hypercall changing behavior. Will send a v2 in a minute. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 14:26:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 14:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404418.646882 (Exim 4.92) (envelope-from ) id 1oWexU-0000h4-7J; Fri, 09 Sep 2022 14:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404418.646882; Fri, 09 Sep 2022 14:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWexU-0000gx-2l; Fri, 09 Sep 2022 14:26:16 +0000 Received: by outflank-mailman (input) for mailman id 404418; Fri, 09 Sep 2022 14:26:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWexS-0000gp-Vj for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 14:26:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5b142d98-304b-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 16:26:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9010.eurprd04.prod.outlook.com (2603:10a6:20b:341::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Fri, 9 Sep 2022 14:26:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 14:26:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b142d98-304b-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=STPZleN/Xh1fYruCPhIYxappdC4DM1iu4fgl/+ylP2IyycoLUsQNu0r5a0wGN8rwcf/2pDbMYEnYzkXpXaX6UWeJF0rYpweVxOj+PII2qKlYz5ydyr/j5OlxPYS7oWGvDs1PEHdSL7f9CzFrr9hVbRr6FeXLF+DW1m4TMQAgB6nzK5CkQF3Fs6qcbIsYyXfYSY1PMsbCnV3Sx3QtugKDNmekg8XqYL1uuy/18ZOK5SvNWABykBZDlRQx0pcaChNTvYI+iuI4xw5cqajnA60DKVrnGwKn0nckKsk8R96ezXpx7IGJthTBYjFCuSHJGpef80PBiKl0cX3hlLuT+ylFxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/PNFK4QrGosaJFaEnRBcEOUvt/MRsw6suUnT2k/Hc7c=; b=ERFUGghBFZqa3gV/y4r8m0bcKp9FMfMe9gpTZh0YtdKFexiRifoKICttOjbvRnaDamwL5ciPyOf3UjymRLWbx3J6MvUGvzx5SfV3rRtrFdsPGZQU5f63HFeTE2n6XWeTRBQrZ+6crm5lGDY8S6+P54rZzWDZolS8pbpGf2RsEjLR3do4a9hacfJUCkNLTPqA3QZ4doJsC567weDqcBUF8DHW4a7o66qOkTyddtCrU1nF/nXWkGYdnGvqoWO5sbV8H89y3uRm2F1KMa+ZNYwUc8hw0hck7ryKPdF/MYQkp9jeEMb9hOu1TsTjSDt1C5GuVROojSxGNHp1S5dwS3kGbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/PNFK4QrGosaJFaEnRBcEOUvt/MRsw6suUnT2k/Hc7c=; b=5oliie+yqFeGn49THtW2AT0FD3B5LJCEouFhkuNj03zb0Om6FTxENFqGG90gsiSVsnzhP9TuPZKjl/2Rua2CtQds0P3P/V9f3F5GRKaoqbo2FYDIryL87Rh/pqVq4k5ImTcvHZOZrz5szUxpw5+kY93vDAH11FxLN4e0aNa01K7MlngLEXXjM6kopNR6IIVgm2SKV7M/ass+ytFjo80vCWXHsKlSULuzNnpMHTXrgnjbvi0cI5IiNGIX40UyCdQ/fG0ifEmIq1Rj2eU+z2PhFMQqv22Vzw5qRkFK8RztKljNpRIFtSsnq/vEWR2chH9F2CBvGWUJkCvCYxgOIW3NLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 16:26:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] build: correct cppcheck-misra make rule Content-Language: en-US To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard References: <0dbef17c-be73-1d88-cd20-83f3123361bf@suse.com> <8FB0B363-FE6D-4BFA-B5D7-E0C00737D3FF@arm.com> From: Jan Beulich In-Reply-To: <8FB0B363-FE6D-4BFA-B5D7-E0C00737D3FF@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9010:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ad8af74-c9d5-4864-6c85-08da926f3de3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hmHbvElBFKvc58ZhkCunhcgQsmdKDiHx84tWGQChAMaAHsUx2PwVW+Jl/NpGLCDxmr3V0VToCYeRG5ZASi5jaZfntjWBDnjN7l/WBI3bbSoQtCTJPQYA5CqooaA0Z2RcybuRxRUZh9rDeYfih1OgYjlghodIo0Tphmt9ysVfHuQ+QuXv21Do0qKya2QGEQlaUc/JBMqS9OQvepFVRs+HqFVmQpyU+qTov+D6L3pxQxG9bEOSHhp6NLQLuw2WmA+UahaVDKnuHWsEVhb5y9xDKo1UD7b8vngo3KqQB9rtXGqvB7d3ulfQaSwHpLWuVOvaon70pnJibvrTjpOD6nySjBf8sgmXIvhp4auQCOiDTiHg5S+TyOQVTXdkx2dHx7OYHx+cii0mm3y9SrboXPMeg5VT9u4cGVQq3c5Aumr249/Kk3pFXWz5UxGaxmuqLxV0aBKYpWEuzi3W7KLw7I1EbGD6o+3c59or43tnOHVQCArMdsc+TQSpNCw6MoGPh1Pb2gEe1pLhzHe3c1eWldITCLigtChBTZtFYTBEATz2sPXUqtb22ZeiKnCFGZv8rWtV7ZZAvCr3kWmPW8lZQ+Vi2yewogRU6OULFfLWZVf7EeCCWIUoeWIboxLaf/7NFuOBOWkDz558WXboCbT1vMn0X1neL5xIX3ZQmJeNVzdhYY/+SF/D9HwTCqaqgXs7T47OQD0jB3lHZVE0XCe6q6I7V9HGUIGgQVfWLldvp14gr8ovu7ldkkUcITahq1SiooE9Uk4ZNHui1U+KYYH5GZKc/9NB9FtWFLgsK+/enOXjXpc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(366004)(136003)(346002)(396003)(83380400001)(41300700001)(478600001)(316002)(6506007)(54906003)(36756003)(31686004)(6916009)(6486002)(186003)(2616005)(38100700002)(4326008)(66946007)(66476007)(8676002)(66556008)(6512007)(8936002)(53546011)(26005)(86362001)(5660300002)(31696002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OCtuYjYzZjlMSWZUZHEwTHh5M1NwbElIc1V5VzN2SjIycFh1STZHNVArbk9o?= =?utf-8?B?OUcyQUxqQnMvOTdKUzlUN1VEeUxWQytUeVBCemFOcmNCMDZ6dUl5OWFkOWF6?= =?utf-8?B?T29Cbml5MkJVM3M3R2hRYXBsbU8yQU5rRW4rT2w0bm03bW82djV6ekZiOVN4?= =?utf-8?B?SnlZTlZuRHYxL1RxczlmSDVCeUpFZS9zVHBueGVwTXpqbEhSRzlId291VXVH?= =?utf-8?B?dUJnUktOWGc1ZjlUMm55TXJzdEM1Nys4QVVObE9sMGhvZElsOVhTalM1VnZD?= =?utf-8?B?OUNRYmNBa2VLa3dyVnFYa3NQSWljS3dRdnBqOXFsZkxIelhkSnFldFNCV3A2?= =?utf-8?B?S1dGSE5uSmg5N1FsQWxGQTJYMGVzbEZOd3YwQnNrTDRGUWdDVEpnRzhjK0dM?= =?utf-8?B?WVR4bGdndVk1ODNxZWlUeWxERkx2bk5IWWl1ZkpJUWRLMnp6TnNvakM3V00v?= =?utf-8?B?VXBvM3VydURaK053L1ZNSDRydjB4K0hKZjRtQnRoSWRkZHMvVmdGb2kxdHYy?= =?utf-8?B?T3FuSEtEeUVhbEFsSldmZzgzcWU1Y0IvaWh1K3lVR2xXZ0Z5ZWRxa09FKzZp?= =?utf-8?B?NWpkd1dMUWNLemYvbXc0STV5cWZiSmt3dEZpVzRhUDNibkhJbzJsZVFzbW4z?= =?utf-8?B?eWozd1lQNitmUVM5U0lFOExuMWJqbFlwblE1ek5vUmREMy95TXFQZFR4Wmxh?= =?utf-8?B?WXpIeURrRENxNSt4NUFzWDVxU0tnUFVFR1A5MDJmM1NsWmpBSGpqRmxITlFu?= =?utf-8?B?ZHIvZ3B1Rlp5MkV5ck96dHk2b1V1TUhVYmJkelhkcXlLcmNHMDF4aFZZT2hY?= =?utf-8?B?RG4rSGxudi9GMEpZZmRSZ1dDZXVLSGQ4cEpvK05jcnJzMHozazNwM3JxRzZZ?= =?utf-8?B?MmFxeldiSmRsM1Zyanp4TDFIeUUwUGgzb0k5Mjh2S3l6aDM3TWhIbG04RWdr?= =?utf-8?B?MkcrSUovblZOSzA4SVlTblBFV1lWYURZUzVnS09uWitEY0pPTUJNcVpzaGlv?= =?utf-8?B?elJzMWF1SUo5ODBJNGFGQ0tPWVZqTmJZMDZwZGUvOFdEcjNyQng3WStML3pj?= =?utf-8?B?a0kvMkhSRkRaSkxERXovenZXMXJ6cmd1LzJ1VUdGUEdUTy9zQng5VVV6QzJ0?= =?utf-8?B?ejRwaUFXQXVkY1NRRHNTVlk1L3NQWndST3EwSkRubktVVHdpWE10Z0FhQXZ5?= =?utf-8?B?WStRcFZsUnozN0FnNTRxN3pDbW04WnFkNXZ1NldCUUErNUc4d2xkc21EM3Qx?= =?utf-8?B?cDhySnlJODdWK09aQmxvZDFURGw5Y2lkY2NFbW5ZTzhlNEZDekFMS0toQU5h?= =?utf-8?B?aUJwSXZGN0wrblFGYXBJVzFiRGxpcUdWa1U2OE5JNS9KNjF6a3BGalVydGN1?= =?utf-8?B?Q0VaVHZEcXpjMnhLMTJteDdnTUwwRVhGeCtSNHFOK1FQTGx4WUI4b2JadzdN?= =?utf-8?B?SUdlMWszcmZsaHBUaS8vdXAxZDNaTFFGZzNhRm9zc0F5Z1dweGV1aXBWeTZH?= =?utf-8?B?Q0VkVzFOOXVyVTFmRUtKUFo1M01pcFVwN0twUGxOclJUUVQ2VGlHRm93N3pz?= =?utf-8?B?YnVRbVJzSnJsL05ETC81WmNVbjJhaFRwVE5YZWlza0JVbU1iWUIxY1BCNVcw?= =?utf-8?B?bkZ1V2phaDZOaVllVGpYUHBkUXRPeVVxQVBrT1J2UU1sNWFNUkxRb2F4b1Rh?= =?utf-8?B?aU9QV2ZUM1VqNjU5TDg0dFZIZHAvdm9nTE1kZVNVUCtCUzNzTEpnM2pIbDM1?= =?utf-8?B?Y3NyY05uZkl3bjZrZHQrNG5GaGlpRENzV0tyWTNmZnNKenkxd25DWHFrdDVE?= =?utf-8?B?dUtXZ0IrZlJYbG9mSU94c3J3TklnSjRobXJibnRsQVFVL0hHQk1vWjRON3Jl?= =?utf-8?B?aWtMR0FVekp5S2NRem8yVjBXaCtiWUNRV2JYWW9QYTZnZ3ZqeWx4UXNacitL?= =?utf-8?B?WTVxdE1tR3ppU3VIRUlpaVl0S053cmNwaEdLSktIazJzVHJ6ejd5NGhQZXpX?= =?utf-8?B?bDZpTDhuRktQcHhnbDJZaFF4TVRBMXd3aDdzVlIzeVo0bTRwaHRJZWpoNzU1?= =?utf-8?B?OTBZYURWVVpONkd4SW9ndnpIMjhJNmVkU2tGcFNHeGtaRUVMeStKMFhPNG1V?= =?utf-8?Q?ECI5WBkZgoc15FVW2jZJy1IKs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad8af74-c9d5-4864-6c85-08da926f3de3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 14:26:10.4936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rzqUA+m8FsaXd7+XvB0tEtfOkNrVMbS+pFYdhAGnD1IBpkPBmdycGyktJp0n/DGV58zYquQ6d0/extzLhIfKBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9010 On 09.09.2022 15:50, Bertrand Marquis wrote: >> On 9 Sep 2022, at 14:41, Jan Beulich wrote: >> >> It has been bothering me for a while that I made a bad suggestion during > > This is not a sentence for a commit message. How else should I express the motivation for the change? >> review: Having cppcheck-misra.json depend on cppcheck-misra.txt does not >> properly address the multiple targets problem. If cppcheck-misra.json >> is deleted from the build tree but cppcheck-misra.txt is still there, >> nothing will re-generate cppcheck-misra.json. >> >> With GNU make 4.3 or newer we could use the &: grouped target separator, >> but since we support older make as well we need to use some other >> mechanism. Convert the rule to a pattern one (with "cppcheck" >> arbitrarily chosen as the stem), thus making known to make that both >> files are created by a single command invocation. Since, as a result, >> the JSON file is now "intermediate" from make's perspective, prevent it >> being deleted again by making it a prereq of .PRECIOUS. >> >> Signed-off-by: Jan Beulich >> --- >> I've not been able to spot where / how cppcheck-misra.txt is used. If >> it's indeed unused, a perhaps better alternative would be to convert the >> original rule to specify cppcheck-misra.json as (the only) target. One >> might then even consider using "-o /dev/null" instead of producing an >> unused *.txt file. > > Txt file is used by cppcheck to give a text description of the rule. > If you look inside the json content you will see it mentioned. Oh, that's properly hidden then. >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -746,11 +746,9 @@ cppcheck-version: >> # documentation file. Also generate a json file with the right arguments for >> # cppcheck in json format including the list of rules to ignore. >> # >> -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py >> - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j $(@:.txt=.json) >> - >> -# convert_misra_doc is generating both files. >> -cppcheck-misra.json: cppcheck-misra.txt >> +.PRECIOUS: %-misra.json >> +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py >> + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.txt -j $*-misra.json > > As far as I know, this is not saying to make that both files are generated by this rule, > but that this rule can generate both files so nothing is telling make here that calling > it once is enough I think. As said in the description - it specifically has this effect. We're using this elsewhere already, see e.g. tools/libs/light/Makefile generating three headers and a C file all in one go. Iirc this is also explicitly described in make documentation (and contrasted to the different behavior for non-pattern rules). Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 09 14:30:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 14:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404428.646892 (Exim 4.92) (envelope-from ) id 1oWf1M-0002Wv-QC; Fri, 09 Sep 2022 14:30:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404428.646892; Fri, 09 Sep 2022 14:30:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWf1M-0002Wo-NZ; Fri, 09 Sep 2022 14:30:16 +0000 Received: by outflank-mailman (input) for mailman id 404428; Fri, 09 Sep 2022 14:30:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWf1L-0002Wi-KT for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 14:30:15 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00040.outbound.protection.outlook.com [40.107.0.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb1762c4-304b-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 16:30:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9478.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Fri, 9 Sep 2022 14:30:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 14:30:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb1762c4-304b-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LTDB6wC5upZX8sr4LyxMqoN8COcSJdyUi3SvPKQtuYG59gZL1vYQKwpBvY2FRljLtTeqqHH5GpBx26fMOrCckptxU60t1X0zOERnBw/ko21zJorDK7pCZwdljB0NLRJnRO937BfTneoXNUXnf6NW6L94Z7LO4v5yLLdpBpVSi06nTHu8zWrWOgLfGIB+/290yCT3GoCOKUloRAt9KX+Gv7PeVJiSgF/VRH2fYOl3b/w3PY+Mea22kPv1iT04tCK1oSjehYiYFETNY+cqr3zQZs7yKuZeCSox97Mydh9gLa8j52UzIHiXOHqGEOyrTQiRfBDD7pPA7YZE70zg4DD3eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pYInDRVqF3/giNMsCtExKTIiVPwObn6L8MAQq6YWhG8=; b=DNtp+P9iu0lk11MhkA3iYBoHP6hrjgjr6ZTuJWxmbHG5254HojL+KIIYfQ/izZxTvSyQJlGbYfPNAOmVNb/gGq8/e7Ngjz/sVDdErJbo94QXeOfiA/WZvG0zcUBTqG2rueZyFIiXKekO+THJkTKVFkU9tAmzWGWQtIWHnVr72SJN6f+mqR+F9+3KBz/3MnDuz6skjyRv1M+UjoFMY5SVsw9zaKRJqAU0DlvzzSkc6UpPDKhqJoPq4IsVKj1kTkzmJh7I5+bPAtX3BMGi75nlQlWYfLzx8TNWzLvnw7eCux1cexkuWrGw9SL6fthBZuwf3Omh+NlwUVMCl0rNCcSuNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pYInDRVqF3/giNMsCtExKTIiVPwObn6L8MAQq6YWhG8=; b=I0S4WNpwQ6TXPn/EDZToEhq92aQH48ZnLfscU4T0i+hosoPiKuvH1j9V1AvI+g2J2UTfp+oXbS5NKEoVmwRYm7//AN7DlkGnJ5IQqZ/eecfqYZ1O+QRvt/IJwwW96dGukLHaDOE7zGHYgIPzBHo/R90EyIQC8efgEKaafeX+2vnkW/YLT4qgt02IOGQbnSfktF8CueMct2+qlof3e3qyUfA+ibJNQbVR7FKrmBmxeGXVP+mHm9PdFhZcJb/K6DgUHeTVqGshcfpZPXiEg7kQzpNGzKaUk4QgBw0amqxwuBTKq7lJWLdjeC/fOAw2Sq9DVxnle/dQ8MZpG9IhND50Yw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com> Date: Fri, 9 Sep 2022 16:30:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 From: Jan Beulich Subject: [PATCH v2] core-parking: fix build with gcc12 and NR_CPUS=1 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9478:EE_ X-MS-Office365-Filtering-Correlation-Id: d9fb6e72-30a0-4f5b-e5fb-08da926fce5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1fLN69NFdD6ZI6Uy7VW5GLChWfn5yNvOirORw5lA2PIuBRpCVVAJLVHCW8fQWvbqRGUsOPNnqr/SO/OJb6q/ixkhMRo9xcHN6vGOPs/S7w52I5R4Ep7YogGq+U92/Srdmdc8PqRE3zOHFg5+tg6MiEsgfoX5HSWcZoaLLHDkduAo7KwXbyeu7n0t8pm1wtz0Bxv0jGP9Ud4V7Sg41KQr9tzBw7MWdG7TPV+2AzKUzqrjNseg+OMClbHV7kn7lz7rhEX3C+4A10Y6GmmmT8dzayk0iDubEEUG/hOaHxaAyFlIeIboCmkjlgNniTMjWgl6c6NuaTRITpZhCCZO4GWRrxm2rW6IEe5OaTM7KoM9o7Auu04WYDhH5jZL9biYgvF77ofjxEqlvvmP7oneCQrC38zAv3fZKtbcVDGrX77l3UuzRIWkO/M1p75OKpug2PAccZvuBWnfAjmIXoPcAcIUCPOPRPvgwpg0tN3/H7Jm4J1aHWjFwUpWBlozgBX5yqdQxFTX1scMT4YnvYHJ22o9CegGBdw3aaFQCLsa6Goyu2gf2k7MuzqhjE9VCOkd/H8h1ZZBFlQmb/i9xQKxu2Wfo3I0FhkGJxnTZ+CXtl1oRLnLim6iZfhit1+Thvpx15YsTbbVNJFDFwqzGMDxzyG8Wu690tUYSF69Om7iDXoTsGQW6k5gUQTAELehyL/Ck9jr3jTwlAlstgH7MjvbtRVZ5kQlPqKsCyoVk/5OlMOhf2IlImTpLFhwLnaqWYc9LlUKpuBzDujl5MIThOJ4X1PJHj43zN0p1eXMehSsjU0R+9E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(39860400002)(396003)(376002)(136003)(38100700002)(8676002)(31696002)(86362001)(66946007)(66556008)(36756003)(66476007)(4326008)(31686004)(26005)(41300700001)(6486002)(186003)(8936002)(316002)(478600001)(83380400001)(2616005)(6916009)(6506007)(6512007)(54906003)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2xaNWtJMTFGVGxEWERKcUJzdkFiaTN3NVoxUHFOcjRzOUZlSnNKN1NLUWd2?= =?utf-8?B?bE1vaWFULzM5TVJuOUMzankrVW1zUFhsdHh1TC9MeUxTcEtwd0NYTkZMSlY4?= =?utf-8?B?ZFJ6MUJPVFphZ1RBWmlVa050amJqVmRyRTYrTmpoSWZ4RCs5VXc4L0QxR3dC?= =?utf-8?B?YWNzSEM2aG1CYkkwN1dBZmZ5dmh4NHNQNnByZUZkZzFRa0wrOCsvSHJuSDgv?= =?utf-8?B?QW9UaXZxdFVLQVVPQ0g5WE5BZXBxMERLWG9Tb0I3V21XWVk3cW1sUHBocG1w?= =?utf-8?B?NWdLMVVEVWhiSFFrdGdYWk56K0pJTmtXblpZZ0VUZmF0RnRteDBSTWsvSG9r?= =?utf-8?B?R1llWkhjcVoxRkRXQWR6ZFkvRFU3eS9sRU9vcU9mdlVEd2lBNDBRcnRzSVY0?= =?utf-8?B?bTY0MHlySnhyd2dXbVNMaFdzUVhSWGhHK3FMa3hxa3F5QUtMWldzWFRyaUxa?= =?utf-8?B?WkpuSTVKVVg4NlBwU2U1VnA3SlhQeFpHeWVJR0lIUllnUHN1eU42b1hOZ1FG?= =?utf-8?B?UHh5aHd1ZXVGVWVzRkRBMXk3UVlpWHBUL21KbGxOcCtDUklUdG5ENDEzUFpB?= =?utf-8?B?MkxRRkhSZDNrWkJOb2VOZEVFZXFpRy9MMzREOHd5TnNzT3VUT1hGSGtuR1Ju?= =?utf-8?B?ciswZlV1Nkw4cEY2bmJHaVFjMjQzd0NmdkRxeURiei9JZERZSEV2NTg4enZh?= =?utf-8?B?eHNoWTdhNGk1dGh4NytmaVlVSW5saTk0K0Z3dUo3b2xYcFJTelhzR1JVRjBY?= =?utf-8?B?V2xrRXZQUzk4YUovVDRwanJ5UFl1RTNiTGxhZGtSZWljUWErOGpSSkpobmlw?= =?utf-8?B?UStmR0xsZVBVaEI4aUxadDM5K2tWblVTQzQ1UUZjbTZNUTRHZW5OdUlqRlhh?= =?utf-8?B?azc2V1pUejZDVUFLT2xCT08xY05PUytCb20rSWVQS1FiT1VsUUNVVktiV2Fk?= =?utf-8?B?enVxd1JrV2RyRXlNTWViZVJzTzBFTjlBbC9lWUZGa3NJZnpQUThMNE51SE5F?= =?utf-8?B?NWExM2xScnMxMW1waGhIaU04QkQzSzF0WUE2UDZjZlVRQ1ZDN3Q5aDViK2kw?= =?utf-8?B?RS8yNFBSaUloTENEMHhJOUhNYnM2NExpM2VPaFpVRHdYaDNvWjRXM3ArWk1p?= =?utf-8?B?MjBJRUpLUWtiNVhlcUlSdGVaRk4vbm90RlZJdVBRUUZhVnlvRkZzdDM1VnhP?= =?utf-8?B?Y1V1NzdpS1FYcnF1amIxUEQveDc0UklPdS9iUmphcFpmUjh3Uk1qb1piL1Iv?= =?utf-8?B?TkdFUHlhT1Z6WGgyby94UjZqejFYOUhOQWtlVlZTM2dUZ0E5bWRVZk52cjV6?= =?utf-8?B?UFVCS04xZDZUTWdadHhMOTdWOUxjZURvcEN0d2ZrUVlUU3B0dU12dWFXazBM?= =?utf-8?B?cnErUEpGZGpyOHQ0YVUrSzd3OHZNWGhkZFJBR2NMbGhyMGg5eGMvZ1V6UlRs?= =?utf-8?B?ejkxb01RU2o4UnROaVJ0L0s3cnVIZjJScGRqUk1WY25RdWp4UWFZb0dGMWE2?= =?utf-8?B?SmxEUDhzc3d3M3p2M2pGOUFqTVZ0TDZmWTlTQ3p0SGY4NGZxMVBLaHNKN2p2?= =?utf-8?B?YjExdGdKdlBlN2hzLzd0ZXRaaDJ6V1dpZlAxcTJ6T0o0Ti9YR3FLeHpCOSs3?= =?utf-8?B?WmNnWkdkZTFSNmh0L1Zza2pKMWVWOGhXRjF5QjFvajlGOE1jcVBkZllBMER2?= =?utf-8?B?MTF2WlM1c2g2djk4RE1SMWI2d1hudW03WnI0eFFBcHhyVlBJa3h4Z2IxbnZP?= =?utf-8?B?MnpmbTE5STBSRlZ5Uzc4TW82Q2g5d3VxZzNKLzZURmlqOG1uUTBaWmp3Skkx?= =?utf-8?B?bWJDRng4ZnlTbURBUlFkcjM3MjRmNEZYVkNxb0F2ZEI1dnJCT2VKMlpBVlhS?= =?utf-8?B?cks5ZXhsUWdreXdZVW5pUTYvakg5RCs3dkltRlFpL1p3SGZkU3JCWTlqMDRt?= =?utf-8?B?VmZ3dzZCR1lzZkhQdmRLQWF2YVdzMEJlVitmbXlSdEovS3ZpUU43UnBISVY4?= =?utf-8?B?aEZyaGhmYStXeGdvbFlPL01yczNNZ2JIaFo0OERKRUZ5M01jekpTa251Uzhz?= =?utf-8?B?Uk9DSHBBbElRYmJidWpPSHFqRGIrTWcvVFpMYlNFQ0VTK0tLMGw3dEV2T3Z3?= =?utf-8?Q?6ParUZM45PXsUbUzxJXzOxvL1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9fb6e72-30a0-4f5b-e5fb-08da926fce5a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 14:30:12.8060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v7misG8T4qsT0CDc1ToKdycSjMhheShdMSg9nGyh+VEk7YssUfKzBns0o1yU4JN4oljPpU+A5NrDpl5HZyy3EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9478 Gcc12 takes issue with core_parking_remove()'s for ( ; i < cur_idle_nums; ++i ) core_parking_cpunum[i] = core_parking_cpunum[i + 1]; complaining that the right hand side array access is past the bounds of 1. Clearly the compiler can't know that cur_idle_nums can only ever be zero in this case (as the sole CPU cannot be parked). Arrange for core_parking.c's contents to not be needed altogether, and then disable its building when NR_CPUS == 1. Signed-off-by: Jan Beulich --- v2: Disable building of core_parking.c altogether. --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -10,7 +10,7 @@ config X86 select ALTERNATIVE_CALL select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 - select CORE_PARKING + select CORE_PARKING if NR_CPUS > 1 select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -727,12 +727,17 @@ ret_t do_platform_op( case XEN_CORE_PARKING_SET: idle_nums = min_t(uint32_t, op->u.core_parking.idle_nums, num_present_cpus() - 1); - ret = continue_hypercall_on_cpu( - 0, core_parking_helper, (void *)(unsigned long)idle_nums); + if ( CONFIG_NR_CPUS > 1 ) + ret = continue_hypercall_on_cpu( + 0, core_parking_helper, + (void *)(unsigned long)idle_nums); + else if ( idle_nums ) + ret = -EINVAL; break; case XEN_CORE_PARKING_GET: - op->u.core_parking.idle_nums = get_cur_idle_nums(); + op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1 + ? get_cur_idle_nums() : 0; ret = __copy_field_to_guest(u_xenpf_op, op, u.core_parking) ? -EFAULT : 0; break; --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -157,7 +157,7 @@ long arch_do_sysctl( long (*fn)(void *); void *hcpu; - switch ( op ) + switch ( op | -(CONFIG_NR_CPUS == 1) ) { case XEN_SYSCTL_CPU_HOTPLUG_ONLINE: plug = true; From xen-devel-bounces@lists.xenproject.org Fri Sep 09 14:43:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 14:43:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404436.646904 (Exim 4.92) (envelope-from ) id 1oWfEP-0004Rf-07; Fri, 09 Sep 2022 14:43:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404436.646904; Fri, 09 Sep 2022 14:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfEO-0004RY-TE; Fri, 09 Sep 2022 14:43:44 +0000 Received: by outflank-mailman (input) for mailman id 404436; Fri, 09 Sep 2022 14:43:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfEO-0004RS-4g for xen-devel@lists.xen.org; Fri, 09 Sep 2022 14:43:44 +0000 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [2607:f8b0:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbf431e9-304d-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 16:43:42 +0200 (CEST) Received: by mail-pg1-x530.google.com with SMTP id h188so1750995pgc.12 for ; Fri, 09 Sep 2022 07:43:42 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id o10-20020a62cd0a000000b00537d0207b30sm591513pfg.184.2022.09.09.07.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 07:43:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbf431e9-304d-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=rV9bJbSRstvz5C/uRqZUoEp5fFMKfqTYvAeMvxSY2Co=; b=ceCTl8TH3rhiYlYD66k/hyC7l0cWG9Nm6NxDqDX94bTgZLXREcmk7+MMi+avzK8X86 aIQXEVdLczjoc1WKHo6ZacVDF+Jnj0VP/GdyATCbMMkOh0QKJ3cgNvGWfVnmSJMhtuL5 BrMMym1J7rfutqsE3sGbcWfU8jLLYfnEoMSvAa1qqvAa+MFEj9OaGAqrIwZpxBQg3Th3 78vXhxA9BBdaxAxDxjkem8hdhfQLR0QY+KCkx96iOXBilzbSAjkWKKkShnOMhzjNM+7T Q0Lv2Qn5CJlCLhLvLBnNfAhCz6pkkTHOmlBBYHcOLLMpX5+mTEFX9cU/nsV0B1SLkV+g 6tkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=rV9bJbSRstvz5C/uRqZUoEp5fFMKfqTYvAeMvxSY2Co=; b=8Py0Lx9gDGwbpqBwjK31x/bUu6EUtAeI5CB4A7eXbP6W9yA70Cx9vy3cWklCSobrUa S1c/34qItnuEFPd+/VE3eLCkUZ6HW4q/wlIs4FdE1F5QCt4GL4BjUJrw3TB5jaZA/vcr onAappIIlGTj9bouU1td4qJmVyZBncOnIJUeJicFlg/fv9uSq70ms1BzMoIkNIsxUfKn n/CNB8zoO2rc7dP3h1eGlSqyPHHBBGCOoP6/7L6Y7PLBADuHK9zwuPVyG73lkjsvKhDI hq6BDHOCsOMDA2yYpIAG6sJkxQ/ljvS+j+jvNMMtQeXgH/mTaOYY0Dw1etYcNz3zMO6q tvRw== X-Gm-Message-State: ACgBeo1bQ1C+MlhP53f070rlufwfo1lWcu0hBmLMozW+JOPuWP25i8Ck 8a6OF1LZaLGAiNLeqeaQQez2p39mvDFVhA== X-Google-Smtp-Source: AA6agR6eVv5VHUdVBA5nfEBT7WPmj5iAr2z5jyqst7LgPtgNJ0ouvRrR6LJCM11ln6OY8EyisUKXBA== X-Received: by 2002:a63:d84e:0:b0:42b:5834:fd73 with SMTP id k14-20020a63d84e000000b0042b5834fd73mr12167334pgj.506.1662734620486; Fri, 09 Sep 2022 07:43:40 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Date: Fri, 9 Sep 2022 20:13:28 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The iommu node will be required for other virtio device types too, not just disk device. Move the call to make_xen_iommu_node(), out of the disk device specific block and rename "iommu_created" variable to "iommu_needed", and set it to true for virtio disk device. Signed-off-by: Viresh Kumar --- V6->V6.1: - Initialize iommu_needed at declaration time only. - Update comment. tools/libs/light/libxl_arm.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 55aee15c10b4..fe1c92383dd6 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1157,7 +1157,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, size_t fdt_size = 0; int pfdt_size = 0; libxl_domain_build_info *const info = &d_config->b_info; - bool iommu_created; + bool iommu_needed = false; unsigned int i; const libxl_version_info *vers; @@ -1265,22 +1265,25 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, if (d_config->num_pcidevs) FDT( make_vpci_node(gc, fdt, ainfo, dom) ); - iommu_created = false; for (i = 0; i < d_config->num_disks; i++) { libxl_device_disk *disk = &d_config->disks[i]; if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { - if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID && - !iommu_created) { - FDT( make_xen_iommu_node(gc, fdt) ); - iommu_created = true; - } + if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID) + iommu_needed = true; FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, disk->backend_domid) ); } } + /* + * The iommu node should be created only once for all virtio-mmio + * devices. + */ + if (iommu_needed) + FDT( make_xen_iommu_node(gc, fdt) ); + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 09 15:02:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 15:02:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404443.646915 (Exim 4.92) (envelope-from ) id 1oWfWr-0007Ok-JH; Fri, 09 Sep 2022 15:02:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404443.646915; Fri, 09 Sep 2022 15:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfWr-0007Od-GH; Fri, 09 Sep 2022 15:02:49 +0000 Received: by outflank-mailman (input) for mailman id 404443; Fri, 09 Sep 2022 15:02:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfWq-0007OX-0h for xen-devel@lists.xen.org; Fri, 09 Sep 2022 15:02:48 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75a13f0f-3050-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 17:02:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75a13f0f-3050-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662735766; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wC6lIJM4fDkL2TNAkHxCnZOgC9YLapXEbaLWhneaQ1E=; b=Z7WY0mfM6p/io7Ay8bAH89tgNhyC5HQ5NsdWcW1LG9gY3/h48FbT8qx3 N06xXiIoZRym3rfZ7+a/SIRnZthhbAZb1a4booZYn7wPjovrQ/zWB/4Sj Ywc0JcljH7X2BH6XkhIKFn2RHOW8KJx5b4NgRehPNTgDPoG46EKF6Op2h E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80155415 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Kk4guqlp2vLJ28nSmn/VXlXo5gzAIURdPkR7XQ2eYbSJt1+Wr1Gzt xJMWGiBbPvYamLwc9lwbtm+8R4GuseByIVgHAQ+rXozQiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37ayj4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2l1NKsh3v9SMVhqz tJfJg8HfCCb3L2plefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oi1aYeIJoXXLSlTtl+n+ Fndr3TYOBUfacSekAqs8y2+38aayEsXX6pNTeblp5aGmma7wWgeCwYKREC7ifa8g0+6HdlYL iQ8/ystoO4y80iuQ8LVWxy+qWSD+BkGVLJ4FuQm6ACA1+zM5AeDB2UeZjpAbtU8s4k9QjlC/ l2Um9LkAxR/vbvTTmiSnp+Woim1IjM9NnIZaGkPSg5ty8bniJE+iFTIVNkLOLC0iNb4Hy22z C2LsDQ5m50XjMgCzaL9+krI6xq8q56MQgMr6wH/WmO+8hg/dIOjIYuy5jDz8/daIZ2ZCFqcu XEes8yf6ukUCteKjiPlaP4REb+g4fHDKyHVi1NrG5gn9hy9+nqie5AW6zZ7TG9gNssUPzXkZ knetCtV5ZlaJnzsarV4C6qqF94j0a/7UNjoSNjTdp9KY4Ntb0mD/Sdnf0nW2Hri+HXAiolmZ 83dK5z1Sy9HV+I3l1JaWtvxz5dozwYH4Xr2danf9Drg34WUdk6NEugaZQ7mgv8C0E+UnOnE2 48BaZHUkEwEDLKWjjr/qtBKcw1TRZQvLdWv8pEMKLbeSuZzMDt5Y8I914/NbGCMc059su7Tt k+wVUZDoLYUrS2WcF7aApyPhV6GYHqekZ7YFXZ2VbpQ8yJ/CbtDFY9GH3fNQZEp9fZ40dl/R OQfdsOLD5xnE2qZoWpDN8Ci9tU/K3xHYD5i2AL8OFACk2NIHVSVqrcIgCO0nMXxMsZHnZRn+ ODxvu8qaZECWx5jHK7rVR5b9Hvo5CB1pQ6HdxGXSjWlUBmzrdMCxu2YpqNfHvzg3j2YnmLGi 17PW05CzQQPyqdsmOT0aWm/h9/BO4ND8oByRQE3MZ7e2fHmw1ee IronPort-HdrOrdr: A9a23:pK0i5KkNXWbNV5R8kfxjqYizzdHpDfIu3DAbv31ZSRFFG/Fxl6 iV/cjz8SWE7wr5OUtQ/exoV5PtfZqxz/FICMwqTNGftWrdyQ6VxeNZnOjfKlTbckWUnINgPO VbAspD4bXLfCFHZK3BgDVQfexP/OW6 X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="80155415" Date: Fri, 9 Sep 2022 16:02:38 +0100 From: Anthony PERARD To: Viresh Kumar CC: , Vincent Guittot , , Alex =?iso-8859-1?Q?Benn=E9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Message-ID: References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Fri, Sep 09, 2022 at 08:13:28PM +0530, Viresh Kumar wrote: > The iommu node will be required for other virtio device types too, not > just disk device. > > Move the call to make_xen_iommu_node(), out of the disk device specific > block and rename "iommu_created" variable to "iommu_needed", and set it > to true for virtio disk device. > > Signed-off-by: Viresh Kumar Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 15:05:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 15:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404450.646926 (Exim 4.92) (envelope-from ) id 1oWfZP-000800-05; Fri, 09 Sep 2022 15:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404450.646926; Fri, 09 Sep 2022 15:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfZO-0007zt-TW; Fri, 09 Sep 2022 15:05:26 +0000 Received: by outflank-mailman (input) for mailman id 404450; Fri, 09 Sep 2022 15:05:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfZN-0007zn-64 for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 15:05:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d3ad3a17-3050-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 17:05:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3ad3a17-3050-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1662735923; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lhfBdqORxj/x2MSS1JBm7eiGHx08sX5kzAbfRsv99gM=; b=KbbqY2aScl0aizkMSfEJeL9jNCTNzGjuidWZHN0aZECNJ2oqlXGS9Z54 Ewyu/KiKhqVWB08xDM94qvQkgt013bwGhxOkj1nRI46F1eJ5tjdbGfWDV dB8Bd2UqDP2vadUofQfGhdVpYnFncuFTHGWcA4FP2QGWg/m1G0f2XTyv+ s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79851336 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:rS5LsKvWHZeLVI903OSymfEu6+fnVF1eMUV32f8akzHdYApBsoF/q tZmKWjQOf2IMzbxf9Anad62pxhT7MWBxtAyGQtp+S9kRH8V+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4GJA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYpA4N5uMWQQz 90ROhwrMhSIguyc+JvuH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3Fb4uFJ4XRHps9ckCwj zrvwUbAJAAjaue54iap/iuCvNaVgnauMG4VPOLhraM76LGJ/UQJDwYcT1y8ov+RhUu3WtYZI EsRkgIsorI171eDVcTmUluzp3vslgEYc8pdFas98g7l4qjd5QqDF3UHZjFEYd0i8sQxQFQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3 RiN9DIGnoUW0/Qq3reX2wzDiDeijKDgG1tdChrsYo610u9oTNf7Odb2sgGAsakowJWxFQfY4 iVd8ySKxKVXVMzWynTQKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj aK6hO+w2HOwFCHwBUOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6zyhZyy/hgY 87GLq5A6Er27ow+lFKLqxo1i+d3lkjSO0uILXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5nekhy P4GbpPi9vmqeLehCsUh2dJMcAtiwLlSLcyelvG7gcbYelM6RDl4UaaLqV7jEqQ895loei7z1 inVcidlJJDX2BUr9S3ihqhfVY7S IronPort-HdrOrdr: A9a23:d8IPOKDluQRM19jlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.93,303,1654574400"; d="scan'208";a="79851336" Date: Fri, 9 Sep 2022 16:05:13 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" Subject: Re: [PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings Message-ID: References: <20220908195113.218201-1-jandryuk@gmail.com> <20220908195113.218201-3-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Fri, Sep 09, 2022 at 08:59:09AM -0400, Jason Andryuk wrote: > On Fri, Sep 9, 2022 at 6:19 AM Anthony PERARD wrote: > > > > On Thu, Sep 08, 2022 at 03:51:12PM -0400, Jason Andryuk wrote: > > > hvm_xs_strings.h specifies xenstore entries which can be used to set or > > > override smbios strings. hvmloader has support for reading them, but > > > xl/libxl support is not wired up. > > > > > > Allow specifying the strings with the new xl.cfg option: > > > smbios=["bios_vendor=Xen Project","system_version=1.0"] > > > > I've tried something like: > > smbios=['oem=foo=bar'] > > And only "foo" is added to the smbios string. Shouldn't we allow users > > to have '=' in their smbios strings? > > Yes, you are correct. split_string_into_pair() isn't suitable since > it terminates at the second '='. Also, we probably don't want to trim > the strings to keep them unchanged, especially for any values. If a > space-padded option name is provided, it'll show up in "xl: unknown > smbios type '%s'" and the whitespace would be evident. > > hvmloader iterates through HVM_XS_OEM_STRINGS entries and stops > processing when an entry is not found, or it is zero-length. So I > think we should disallow zero-length values like "oem=" to avoid > surprises. For example, smbios=["oem=A","oem=","oem=B"] would result > in only oem-1 "A" making its way through to the guest. Both suggestion sounds good. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 09 15:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 15:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404459.646938 (Exim 4.92) (envelope-from ) id 1oWfko-0001N0-4B; Fri, 09 Sep 2022 15:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404459.646938; Fri, 09 Sep 2022 15:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfkn-0001Mt-Vf; Fri, 09 Sep 2022 15:17:13 +0000 Received: by outflank-mailman (input) for mailman id 404459; Fri, 09 Sep 2022 15:17:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWfkl-0001Mn-Vd for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 15:17:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 797492bc-3052-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 17:17:10 +0200 (CEST) Received: from FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) by GVXPR08MB7799.eurprd08.prod.outlook.com (2603:10a6:150:3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 9 Sep 2022 15:16:59 +0000 Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::4e) by FR0P281CA0149.outlook.office365.com (2603:10a6:d10:96::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.6 via Frontend Transport; Fri, 9 Sep 2022 15:16:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 15:16:58 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 09 Sep 2022 15:16:58 +0000 Received: from 4a130cf63d38.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B50A033-6570-4C3A-B902-F14449C367B7.1; Fri, 09 Sep 2022 15:16:51 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4a130cf63d38.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Sep 2022 15:16:51 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7842.eurprd08.prod.outlook.com (2603:10a6:10:39d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Fri, 9 Sep 2022 15:16:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5612.018; Fri, 9 Sep 2022 15:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 797492bc-3052-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=a/+8TaFMSgaYX8+PkJ4+sSxRa0ZzcpZCCvJpX99jZ4D8YAJdd42yREHHEGJFEJ9QfIzo/JgKFmSzQNnmZAWwOYBgA0eONpXxWXhNyHZatGv8hdrw9qXd6wtrdjM3O1urqoLoBoZPsu0U0SpGTiHWsi9ftV3PwP2+e9ohrpMlrburawydfBc3JdWFrXfMOxOqdKLlPm8dm0dA3eoumPZJRGcDZndSstMMBQW7IdcZO5k024axE1q4/l8oOK/BNIX7XcrtIc97gtwCsnjEwYCNsDKUk7POL3eC6hi8ey4pOvombGIIhgLrF5wWt5C294NzS/KW/+DF0hIPgmo3CRjLUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NAl+f5st5eun8xlveCvD5yisKbUcWG5fVqAhKmjBIxo=; b=RNtFdD7cpkww8jCrzFC67GkyOyv8imhMZIZnhgGCe7CnYjAMg9farq1CTp+TxSuq0/VLeTb+eO6MP5KGUhd2AcIyG5qQ4MW3OeLcNKy5v5APKVym7cTUFE9UQN2pmieT/s77s/MAb5pZTlBC1ipKpE5JsCSjPxIsHlElu6noPZZYwdRUItaJXK6CoUodXpQSwSHITDmnqNAAViuwroj82FwkQ6f6JVL8FVRyuWMm3G/pg1rAcF6zKc3Ptg+WT7c+wXMizoDEd8VrHXbMfJ1k7Zik+vlZD0w5ZTRCXLqxdKoNC2gVN7S1qg2T8ql5SlbJoEFPW65ZiCQKSvxpJYCo2w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAl+f5st5eun8xlveCvD5yisKbUcWG5fVqAhKmjBIxo=; b=A/ldZvzo7SCbGtvw93LXzM0aijXXRxix6WKLGeKZ824FrO+1mwx03Bde7VfbeQce7yUyULA4swOXnZ8MklWxh35LSRf5jAiO1VfFxjFw+KIJyobrNRXk2hTbhtni0V3pYAxGXqew14MKrFhDu2DH4apb9vOxqa1oT9t/Ke8xiuY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 845688f6fef5917d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4/HG59mo3c7gM011IIWn9nEC2G2r3qLY53q8fi6MjcXWzPSBHLAfkMfFiY0Niuw//qInbmZCsGF5KcsBwdHrfC6WRK2dX9GdA/PjfkmDr8iUSu5GRB7hNd2JTGQj3er6WbB+FbIbd6pR4MWLEXDHJORL0SUTZa+Qo/HzLH8psT9eQYa2QKOKNK/l3VI82/URVoLNSkb0k8+sNQSwHjxZ4IizQSDSfw8Q6GREj1Tjap35pu3lfkW23PH2jkwmMB+1Ei53Rc1rfbMuGleyr+wFpXNwN/eLKoTvdN6EBGaYWLxWFYwoxkVQ8LxPx5AYvjsgZ9QJwDRvPX2UC8OcxCMWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NAl+f5st5eun8xlveCvD5yisKbUcWG5fVqAhKmjBIxo=; b=df74GvBV1a2BBPUNo/kWtQVc2IXpKWZcIUNpffORde+xXKo0WVifLsvUEIXk9hycgrfhYK5yOi5DubNKVM9jduYO6hG6IllcWfY889iIUYlngIJoJh5hKjT8UOPpwTjEjBGaOHY4Y5sjVoclc7HO0AxaCG0QRB8BWyn3XS1+hSjfnDuQtUvCwfMMPrQvavIloOD3Q+2S9xSbbgIzhOgYjFt6n2N8wN1l2RNU7nmNBugUkpMs4ZmHO9Gbzg41VZB9/+tpIR8J1rGO/kbpEmzY+c9lmmP4CASxbjXjHSEAH8fzLjQ82St/5dFk5jiD8X/byN8GNfDeEWZIp5lm7wt7og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAl+f5st5eun8xlveCvD5yisKbUcWG5fVqAhKmjBIxo=; b=A/ldZvzo7SCbGtvw93LXzM0aijXXRxix6WKLGeKZ824FrO+1mwx03Bde7VfbeQce7yUyULA4swOXnZ8MklWxh35LSRf5jAiO1VfFxjFw+KIJyobrNRXk2hTbhtni0V3pYAxGXqew14MKrFhDu2DH4apb9vOxqa1oT9t/Ke8xiuY= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard Subject: Re: [PATCH] build: correct cppcheck-misra make rule Thread-Topic: [PATCH] build: correct cppcheck-misra make rule Thread-Index: AQHYxFHaJwlnNsxgQECM5kPu4Ki3xq3XHaOAgAAJ7oCAAA4kAA== Date: Fri, 9 Sep 2022 15:16:47 +0000 Message-ID: <0EA88427-788A-4B67-88F9-B96FB8BBFEF6@arm.com> References: <0dbef17c-be73-1d88-cd20-83f3123361bf@suse.com> <8FB0B363-FE6D-4BFA-B5D7-E0C00737D3FF@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB7842:EE_|VE1EUR03FT008:EE_|GVXPR08MB7799:EE_ X-MS-Office365-Filtering-Correlation-Id: 99c122c1-3aad-4724-614a-08da927656c0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: T/JpkbbJhlcWDwgvl3yxnwZG34Ls3PXCJ3DBRUzdwQDJbCaIZ4cCP+QtyVU7wQDBJmZmjcX0MjCjVPiiI1Y7ZD6bqkirDZUYmMrxfZRFA/e+jp2mKvNRdNDpMwU+RW5DFOe7OQsxiShbopX4MKsNvzjImYSVHj9qrMrAYhutREwW9PyN2DWSx/wscb0ktio418GB18yZj/YdWc342MGXjYYrGkwBeBdvvzJwmk3Oyti+c2ykxYKD2TjiFrDpUvf68jG+o4KOL10CQ51Afo0iZZcujq37H9aBwlmJgV4/6qvAOK0BbjaQ47LroXO8QulPHN5zcvhQeX6E9W1DpwSdfIR5IJfh5ZrQFCgrVkbHrU3oVzlKq60ttEA0mv3W5kMYDqrVw0W3WehFptvvhdU4kgiYFFTkWDFJcay56QbswUKtc96Cp31DnZmW8Cbh6pEW6f9Lzfe/Khzn9AdiIFCMWJ4rk+lfLcj/I1dXiLS3igU6a4FjpVbhWv3jgvbi/jHvG3cu6nat0KXZpoRKLDLnxCDpay2vy0aFjYyOmQBGua3nX1tND9aYMoi/IfyAa8xbbzvhjw2XXpDe5cFhfzEJny6oZZA1FySIFNnCZVBlsvi4E2jmgL5bqeQcX6gAVbhk4bswEd0Ag5WSEXp6ghoTqsyIMevOuEDHlqUuFfNDFnIOv6B9VZ3jQy2dNpAkcw/yG1ey+p2n61O2gnUev0knDJRmxLbPd7Wv9bIg+k0aPf9xG5teFy9Xt3+hb7vv08n5PZ9h8G3OUuglzB7ft2WgWyuJrY/V1G7yazaW5s4+Vfc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(64756008)(4326008)(66556008)(66476007)(66446008)(8676002)(86362001)(54906003)(76116006)(91956017)(38070700005)(6916009)(66946007)(53546011)(83380400001)(6506007)(316002)(41300700001)(26005)(6512007)(2616005)(186003)(71200400001)(6486002)(122000001)(38100700002)(5660300002)(8936002)(2906002)(33656002)(36756003)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <88EF1E857FEEFB4AA2763924F3C123D3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7842 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c0de1796-e674-4ef1-4488-08da92764fea X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jMYIR4qAWw1WE5uMxX6Nzjr2NwyRj9cm5hc/7mXa+kAEJysh4Gilk0h3YMhyJ9uRxIHjYGSJjr3d0HA2L2ZPH9MoRtm0+0iTOH6cF3hHH+wxpoBlVX4sVBSWzfNbohH4xsCd+1lQQrgLQfSsxZInICsxKWXU7DAIWHW4pEzY/bgxSiOSPeGZTqCyXMGB2/WN3esSvuB/p5VqczlTkxrimzGlEE/6woq/c2RsMwyy+VduZkn+QYuOC6Sf4OKdZqSpCy+WF90ekSrC/eDJ319d+yrtUUjr7z/AJG0eJKRIa2u0X4VWrfGJNDus5JJY9lTD9NvxQaHVtqC5w3d/xusS3heSdv3FrvCaM/nZ3BZy01IxhbIDxcIwDCYpd4t6SsWtLsOt1fvoCC2S2ivyX+0sx8WDUfPgcj9QXIojlcWMBNXdqMJPdsWQDAlKb5fj8+Rjf4rtwk/LewkmWDexGLsPU58lB40eqMT8JyRilEhOh67GzihViIkBRPdkH7QUjpM84wo4Wrj36ObdjLDGMoZ3+4boJYFqPRs53/AFrWNDk999WoUm7irCBPcoyh7tsW7SygOHweNKxa7n51mywmDGJJIZSS718f/fRL7gbMznjoxQq+PDgskzbJEZDogYriOuc/5OK8RrQ9ZMPLI1GSbszkQBzd+kYrVfWvVMP0/8CQzchRNWntJ5Or9ep95xxPQG7/GwCErZhRNFmN8X1sjyB3KBvboHQvMTdZmilcXJwH0xjTSEQgd5wrNCX985wMyQbdFLpyht61BktsbToPIIAQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966006)(40470700004)(36840700001)(26005)(6506007)(83380400001)(107886003)(6512007)(2616005)(186003)(336012)(86362001)(81166007)(47076005)(356005)(41300700001)(53546011)(82740400003)(36860700001)(36756003)(8676002)(40480700001)(40460700003)(70586007)(70206006)(2906002)(4326008)(478600001)(8936002)(5660300002)(6862004)(33656002)(316002)(54906003)(82310400005)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 15:16:58.4497 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99c122c1-3aad-4724-614a-08da927656c0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7799 SGkgSmFuLA0KDQo+IE9uIDkgU2VwIDIwMjIsIGF0IDE1OjI2LCBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMDkuMDkuMjAyMiAxNTo1MCwgQmVydHJhbmQg TWFycXVpcyB3cm90ZToNCj4+PiBPbiA5IFNlcCAyMDIyLCBhdCAxNDo0MSwgSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+PiANCj4+PiBJdCBoYXMgYmVlbiBib3RoZXJp bmcgbWUgZm9yIGEgd2hpbGUgdGhhdCBJIG1hZGUgYSBiYWQgc3VnZ2VzdGlvbiBkdXJpbmcNCj4+ IA0KPj4gVGhpcyBpcyBub3QgYSBzZW50ZW5jZSBmb3IgYSBjb21taXQgbWVzc2FnZS4NCj4gDQo+ IEhvdyBlbHNlIHNob3VsZCBJIGV4cHJlc3MgdGhlIG1vdGl2YXRpb24gZm9yIHRoZSBjaGFuZ2U/ DQoNCkkgd291bGQgc2F5LCBzdGFydCB3aXRoIOKAnGNwcGNoZWNrLW1pc3JhLmpzb24gZGVwZW5k IG9uIOKApuKAnSBhbmQgcmVtb3ZlIGV2ZXJ5dGhpbmcgYmVmb3JlLg0KDQpCZWluZyBib3RoZXJl ZCBpcyBub3QgcmVhbGx5IHNvbWV0aGluZyBpbnRlcmVzdGluZyB0byByZWFkIGluIHRoZSBnaXQg bG9nLg0KDQo+IA0KPj4+IHJldmlldzogSGF2aW5nIGNwcGNoZWNrLW1pc3JhLmpzb24gZGVwZW5k IG9uIGNwcGNoZWNrLW1pc3JhLnR4dCBkb2VzIG5vdA0KPj4+IHByb3Blcmx5IGFkZHJlc3MgdGhl IG11bHRpcGxlIHRhcmdldHMgcHJvYmxlbS4gSWYgY3BwY2hlY2stbWlzcmEuanNvbg0KPj4+IGlz IGRlbGV0ZWQgZnJvbSB0aGUgYnVpbGQgdHJlZSBidXQgY3BwY2hlY2stbWlzcmEudHh0IGlzIHN0 aWxsIHRoZXJlLA0KPj4+IG5vdGhpbmcgd2lsbCByZS1nZW5lcmF0ZSBjcHBjaGVjay1taXNyYS5q c29uLg0KPj4+IA0KPj4+IFdpdGggR05VIG1ha2UgNC4zIG9yIG5ld2VyIHdlIGNvdWxkIHVzZSB0 aGUgJjogZ3JvdXBlZCB0YXJnZXQgc2VwYXJhdG9yLA0KPj4+IGJ1dCBzaW5jZSB3ZSBzdXBwb3J0 IG9sZGVyIG1ha2UgYXMgd2VsbCB3ZSBuZWVkIHRvIHVzZSBzb21lIG90aGVyDQo+Pj4gbWVjaGFu aXNtLiBDb252ZXJ0IHRoZSBydWxlIHRvIGEgcGF0dGVybiBvbmUgKHdpdGggImNwcGNoZWNrIg0K Pj4+IGFyYml0cmFyaWx5IGNob3NlbiBhcyB0aGUgc3RlbSksIHRodXMgbWFraW5nIGtub3duIHRv IG1ha2UgdGhhdCBib3RoDQo+Pj4gZmlsZXMgYXJlIGNyZWF0ZWQgYnkgYSBzaW5nbGUgY29tbWFu ZCBpbnZvY2F0aW9uLiBTaW5jZSwgYXMgYSByZXN1bHQsDQo+Pj4gdGhlIEpTT04gZmlsZSBpcyBu b3cgImludGVybWVkaWF0ZSIgZnJvbSBtYWtlJ3MgcGVyc3BlY3RpdmUsIHByZXZlbnQgaXQNCj4+ PiBiZWluZyBkZWxldGVkIGFnYWluIGJ5IG1ha2luZyBpdCBhIHByZXJlcSBvZiAuUFJFQ0lPVVMu DQo+Pj4gDQo+Pj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t Pg0KPj4+IC0tLQ0KPj4+IEkndmUgbm90IGJlZW4gYWJsZSB0byBzcG90IHdoZXJlIC8gaG93IGNw cGNoZWNrLW1pc3JhLnR4dCBpcyB1c2VkLiBJZg0KPj4+IGl0J3MgaW5kZWVkIHVudXNlZCwgYSBw ZXJoYXBzIGJldHRlciBhbHRlcm5hdGl2ZSB3b3VsZCBiZSB0byBjb252ZXJ0IHRoZQ0KPj4+IG9y aWdpbmFsIHJ1bGUgdG8gc3BlY2lmeSBjcHBjaGVjay1taXNyYS5qc29uIGFzICh0aGUgb25seSkg dGFyZ2V0LiBPbmUNCj4+PiBtaWdodCB0aGVuIGV2ZW4gY29uc2lkZXIgdXNpbmcgIi1vIC9kZXYv bnVsbCIgaW5zdGVhZCBvZiBwcm9kdWNpbmcgYW4NCj4+PiB1bnVzZWQgKi50eHQgZmlsZS4NCj4+ IA0KPj4gVHh0IGZpbGUgaXMgdXNlZCBieSBjcHBjaGVjayB0byBnaXZlIGEgdGV4dCBkZXNjcmlw dGlvbiBvZiB0aGUgcnVsZS4NCj4+IElmIHlvdSBsb29rIGluc2lkZSB0aGUganNvbiBjb250ZW50 IHlvdSB3aWxsIHNlZSBpdCBtZW50aW9uZWQuDQo+IA0KPiBPaCwgdGhhdCdzIHByb3Blcmx5IGhp ZGRlbiB0aGVuLg0KDQpUaGlzIGlzIGhvdyBjcHBjaGVjayBuZWVkcyBpdCBhbmQgd2h5IEkgYWRk ZWQgYSBjb21tZW50IGJ1dCBpdCBtaWdodCBuZWVkcyBpbXByb3ZpbmcuDQoNCj4gDQo+Pj4gLS0t IGEveGVuL01ha2VmaWxlDQo+Pj4gKysrIGIveGVuL01ha2VmaWxlDQo+Pj4gQEAgLTc0NiwxMSAr NzQ2LDkgQEAgY3BwY2hlY2stdmVyc2lvbjoNCj4+PiAjIGRvY3VtZW50YXRpb24gZmlsZS4gQWxz byBnZW5lcmF0ZSBhIGpzb24gZmlsZSB3aXRoIHRoZSByaWdodCBhcmd1bWVudHMgZm9yDQo+Pj4g IyBjcHBjaGVjayBpbiBqc29uIGZvcm1hdCBpbmNsdWRpbmcgdGhlIGxpc3Qgb2YgcnVsZXMgdG8g aWdub3JlLg0KPj4+ICMNCj4+PiAtY3BwY2hlY2stbWlzcmEudHh0OiAkKFhFTl9ST09UKS9kb2Nz L21pc3JhL3J1bGVzLnJzdCAkKHNyY3RyZWUpL3Rvb2xzL2NvbnZlcnRfbWlzcmFfZG9jLnB5DQo+ Pj4gLQkkKFEpJChQWVRIT04pICQoc3JjdHJlZSkvdG9vbHMvY29udmVydF9taXNyYV9kb2MucHkg LWkgJDwgLW8gJEAgLWogJChAOi50eHQ9Lmpzb24pDQo+Pj4gLQ0KPj4+IC0jIGNvbnZlcnRfbWlz cmFfZG9jIGlzIGdlbmVyYXRpbmcgYm90aCBmaWxlcy4NCj4+PiAtY3BwY2hlY2stbWlzcmEuanNv bjogY3BwY2hlY2stbWlzcmEudHh0DQo+Pj4gKy5QUkVDSU9VUzogJS1taXNyYS5qc29uDQo+Pj4g KyUtbWlzcmEudHh0ICUtbWlzcmEuanNvbjogJChYRU5fUk9PVCkvZG9jcy9taXNyYS9ydWxlcy5y c3QgJChzcmN0cmVlKS90b29scy9jb252ZXJ0X21pc3JhX2RvYy5weQ0KPj4+ICsJJChRKSQoUFlU SE9OKSAkKHNyY3RyZWUpL3Rvb2xzL2NvbnZlcnRfbWlzcmFfZG9jLnB5IC1pICQ8IC1vICQqLW1p c3JhLnR4dCAtaiAkKi1taXNyYS5qc29uDQo+PiANCj4+IEFzIGZhciBhcyBJIGtub3csIHRoaXMg aXMgbm90IHNheWluZyB0byBtYWtlIHRoYXQgYm90aCBmaWxlcyBhcmUgZ2VuZXJhdGVkIGJ5IHRo aXMgcnVsZSwNCj4+IGJ1dCB0aGF0IHRoaXMgcnVsZSBjYW4gZ2VuZXJhdGUgYm90aCBmaWxlcyBz byBub3RoaW5nIGlzIHRlbGxpbmcgbWFrZSBoZXJlIHRoYXQgY2FsbGluZw0KPj4gaXQgb25jZSBp cyBlbm91Z2ggSSB0aGluay4NCj4gDQo+IEFzIHNhaWQgaW4gdGhlIGRlc2NyaXB0aW9uIC0gaXQg c3BlY2lmaWNhbGx5IGhhcyB0aGlzIGVmZmVjdC4gV2UncmUNCj4gdXNpbmcgdGhpcyBlbHNld2hl cmUgYWxyZWFkeSwgc2VlIGUuZy4gdG9vbHMvbGlicy9saWdodC9NYWtlZmlsZQ0KPiBnZW5lcmF0 aW5nIHRocmVlIGhlYWRlcnMgYW5kIGEgQyBmaWxlIGFsbCBpbiBvbmUgZ28uIElpcmMgdGhpcyBp cw0KPiBhbHNvIGV4cGxpY2l0bHkgZGVzY3JpYmVkIGluIG1ha2UgZG9jdW1lbnRhdGlvbiAoYW5k IGNvbnRyYXN0ZWQgdG8NCj4gdGhlIGRpZmZlcmVudCBiZWhhdmlvciBmb3Igbm9uLXBhdHRlcm4g cnVsZXMpLg0KDQpUaGVuIEkgdGhpbmsgdGhlIGNvbW1lbnQgc3VnZ2VzdGVkIGJ5IEFudGhvbnkg bWFrZXMgc2Vuc2UgdG8gYWRkLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 09 15:41:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 15:41:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404471.646952 (Exim 4.92) (envelope-from ) id 1oWg8C-0005p7-4A; Fri, 09 Sep 2022 15:41:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404471.646952; Fri, 09 Sep 2022 15:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWg8C-0005p0-1O; Fri, 09 Sep 2022 15:41:24 +0000 Received: by outflank-mailman (input) for mailman id 404471; Fri, 09 Sep 2022 15:41:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWg8B-0005or-6o for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 15:41:23 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8c14709-3055-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 17:41:20 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1662738076566571.0787444842507; Fri, 9 Sep 2022 08:41:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8c14709-3055-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; t=1662738077; cv=none; d=zohomail.com; s=zohoarc; b=brWj5PxNFb9ejA4cGHcjn/2YeY+OG4NOKAC+Z8UCuJa6HEiWv8OOhP+JqBK24JLzBgxyd7QanquysDgGOKPlehmVRYNLDJHjH+0g6OH5Db38pj0IGqmB+/nRw9CwOZy2vTo0ml2KUPHEoQOWt3bSxGjJ21rI9jt2NIP5FRZf/S8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662738077; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3pPQ8rWPnj6YmEPuBn7YnrybGjisZ/aKYZ9q4cPs7/o=; b=I0VWb8QaPyB74zXIqIYgDcaebdSXh/wNVG+kHBgYoINxoNAOlOvqD3cE6PLE7cZ2hquSKLAkSAawuBK+OOHoAD67HywNFqNWxVtLf0v8rjh+WLAz2Nf87Jc5qO2as86c/5Qr3VqvipqKNiNKpHjxVGw6zw98r7mEDQ00ZJ2uxI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662738077; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3pPQ8rWPnj6YmEPuBn7YnrybGjisZ/aKYZ9q4cPs7/o=; b=bIIldCrh22hUF5F70ZlFRBxO7wAF/DUvJhEeGefuQAjIvYmPKWEymt0LzAT9zhmZ ArgEeN6uY+GDmxuADNJpZf3F/JPy/SZ1y8uDbPO/afspPyjtsgEpQ9gSGm2/uVZW4Xd w/e1RGWIKqvd3QVPXZxcotUdpTBJbSjPRtlE3dgc= Message-ID: Date: Fri, 9 Sep 2022 11:41:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Jan Beulich Cc: jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220909095012.4251-1-dpsmith@apertussolutions.com> <3da17c12-1cbe-165e-94f4-44face9a181f@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xsm/flask: adjust print messages to use %pd In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 9/9/22 08:10, Jan Beulich wrote: > On 09.09.2022 13:34, Daniel P. Smith wrote: >> On 9/9/22 06:04, Jan Beulich wrote: >>> On 09.09.2022 11:50, Daniel P. Smith wrote: >>>> --- a/xen/xsm/flask/avc.c >>>> +++ b/xen/xsm/flask/avc.c >>>> @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, >>>> if ( a && (a->sdom || a->tdom) ) >>>> { >>>> if ( a->sdom && a->tdom && a->sdom != a->tdom ) >>>> - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); >>>> + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); >>>> else if ( a->sdom ) >>>> - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); >>>> + avc_printk(&buf, "source=%pd ", a->sdom); >>>> else >>>> - avc_printk(&buf, "target=%d ", a->tdom->domain_id); >>>> + avc_printk(&buf, "target=%pd ", a->tdom); >>> >>> Apart from switching to %pd to also replace "domid" by "source". That's >>> fine in the first case (where both domain IDs are logged), but in the >>> second case it's a little questionable. Wouldn't it be better to be >>> able to distinguish the tdom == NULL case from the tdom == sdom one, >>> perhaps by using "source" in the former case but "domid" in the latter >>> one? >> >> Apologies as I am not quite following your question. Let me provide my >> reasoning and if it doesn't address your question, then please help me >> understand your concern. >> >> The function avc_printk() allows for the incremental build up of an AVC >> message. In this section, it is attempting to include the applicable >> source and target that was used to render the AVC. With the switch to >> %pd, the first and second lines would become "domid=d{id}". I personally >> find that a bit redundant. Adding to that, in the context of this >> function there is "sdom" which is source domain, "cdom" which is current >> domain, and tdom which is target domain. The print statements using cdom >> or tdom already denoted them with "current=" and "target=" respectively. >> Whereas, sdom was prefixed with "domid=" in the print statements. To me, >> it makes more sense to change the prefixes of sdom with "source=" to >> accurately reflect the context of that domid. > > Well, yes, perhaps "domain" would be better than "domid" with the change > to %pd. But I still think the middle of the three printk()s would better > distinguish tdom == NULL from tdom == sdom: > > else if ( a->sdom ) > avc_printk(&buf, "%s=%pd ", a->tdom ? "domain" : "source", a->sdom); Okay, I see you are trying to reduce away the last "else", but I have several concerns about doing this suggestion. - The biggest concern is the fact that in the past, a domain referred to strictly as "domain" or "domid" in an AVC has always implied it was the source. At the same time, the target domain has always been referenced as "target". This suggestion would completely flip that implied understanding around. In part, this change was to move source from being implied to being explicitly reported. The end result is it then makes source explicit as it is for current and target. - AFAICT the suggestion is not logically equivalent. The current form checks first if sdom is defined, then prints it. If sdom is not defined, then it is presumed that tdom will be defined, and will then print it. AIUI, the suggestion will lose the case where sdom is not defined. - I haven't went to confirm this, but I believe the logic here is based on an understanding of when sdom and tdom are defined. Specifically, the expected situations are, 1. sdom and tdom are defined and not equal, report both 2. if sdom and tdom are defined and equal, report only sdom as tdom is implied to be the same 3. if sdom is not defined, then tdom must be defined, report only tdom and sdom is implied to be cdom Finally, as I was typing this up, I had a realization that I may not be able to relabel the reference. It is believed at some point you could feed Xen AVCs to audit2allow to generate an allow rule for the AVC. Though recent versions do not appear to work, so I am going to try to find a day or two to dig in and determine what influence this might have on the change. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Sep 09 16:12:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 16:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404478.646963 (Exim 4.92) (envelope-from ) id 1oWgc3-0002Kh-Hk; Fri, 09 Sep 2022 16:12:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404478.646963; Fri, 09 Sep 2022 16:12:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWgc3-0002Ka-E1; Fri, 09 Sep 2022 16:12:15 +0000 Received: by outflank-mailman (input) for mailman id 404478; Fri, 09 Sep 2022 16:12:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWgc1-0002KU-KP for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 16:12:13 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2964e486-305a-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 18:12:12 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id lz22so5140782ejb.3 for ; Fri, 09 Sep 2022 09:12:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2964e486-305a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=inLoVTMssB90QGkHyUI1/5M5trM6CuJ62qAp4R+UoAE=; b=gkVdNEgU9IvgnIaAbBukptVTVEpbQWYKTCon4II4JtO8TPfLLBVMYXlW5y2Jem76ts 7KY8YoQwTt1Y2wawuTmyvlTxz8+6+07tx7br89VXHKylxkJRSMWhFic7gxnEMderjCpa 8CQfHEqfODRNQReIZAT0plDHXOxWgO86ixeq/jXJd/xzOfCl/fJPsQsDAa0yKEcNWGNy 0bDRZYyH8+iDiqEIgQr0ezQXTInTYTq6FGMglhqtq3hDzFsxfeYwv3xdAr07t1NKtHBM 5Y1y5VD8ADbEHK+U1n/51PvFX445VfjDzQ6zI9KCWKZiycN9aT0a4lCCk84TD+HtUFgd gz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=inLoVTMssB90QGkHyUI1/5M5trM6CuJ62qAp4R+UoAE=; b=PHPOLd4UEW63h+Z4kQWgPLJj6RB1CF8Qs77I8Ehf7dRHReHNQIX0yh+lQbzF6l7b0i lqY0PwvJ2gCYwh5Q7BNAkPOBJpiAdJN+N86bFT982q2QnKwt6+pG1WTeBaV1O/R52QL0 OiUw/vTy8GkYX42vdbiOThiNFfNttX1MaFInz6O7QW3EzlU08UZ3X+LugyoD2lAYs4oM NRM8HgIMF19W78OzEMjQfKCnSLl5L5IEVIkJMduJ+2OxJftQxebypP8yB++2UqCZi2yt HVDJU9TM0OcgS3eFGFgafLJFd/XumpvS4xAr2joSFzdcQffxIHWcSmuMlyk+nZtYXGX2 Rkow== X-Gm-Message-State: ACgBeo1TGCKNqmdhQ0I5Jlu/SCYp07AP3zV3baCriFQrxBMGLhm2Rh7k VmE90zmTaLwPneLY8UB94D9XNn5qmMaXBak5ZJ8jOO1b X-Google-Smtp-Source: AA6agR7XG2Qi9H6tVfnbOSGsaPIrxoxKLOxrcmTLAQBzoVC0APjazAzaOkXYRpnFUKVHnGO01mZBnOqwYojLP5gRUWI= X-Received: by 2002:a17:907:94c2:b0:73d:c534:1ac0 with SMTP id dn2-20020a17090794c200b0073dc5341ac0mr10421418ejc.461.1662739931362; Fri, 09 Sep 2022 09:12:11 -0700 (PDT) MIME-Version: 1.0 References: <20220909012546.21807-1-dpsmith@apertussolutions.com> In-Reply-To: <20220909012546.21807-1-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Fri, 9 Sep 2022 12:11:59 -0400 Message-ID: Subject: Re: [PATCH v13] xsm/flask: correcting initial sid assignment on context allocation To: "Daniel P. Smith" Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD Content-Type: text/plain; charset="UTF-8" On Thu, Sep 8, 2022 at 9:26 PM Daniel P. Smith wrote: > > The current flow for initial SID assignment is that the function > flask_domain_alloc_security() allocates the security context and assigns an > initial SID based on the limited state information it can access. Specifically > the initial SID is determined by the domid of the domain, where it would assign > the label for one of the domains the hypervisor constructed with the exception > of initial domain (dom0). In the case of the initial domain and all other > domains it would use the unlabeled_t SID. > > When it came to the SID for the initial domain, its assignment was managed by > flask_domain_create() where it would be switched from unlabeled_t to dom0_t. > This logic worked under the assumption that the first call to > flask_domain_create() would be the hypervisor constructing the initial domain. > After which it would be the toolstack constructing the domain, for which it is > expected to provide an appropriate SID or else unlabeled_t would be used. > > The issue is that the assumptions upon which the current flow is built were > weak and are invalid for PV shim and dom0less. Under the current flow even > though the initial domain for PV shim is not set as privileged, flask would > label the domain as dom0_t. For dom0less, the situation is two-fold. First is > that every domain after the first domain creation will fail as they will be > labeled as unlabeled_t. The second is that if the dom0less configuration does > not include a "dom0", the first domain created would be labeled as dom0_t. > > This commit only seeks to address the situation for PV shim, by including a > check for xenboot_t context in flask_domain_alloc_security() to determine if > the domain is being constructed at system boot. Then a check for is_privilged > and pv_shim is added to differentiate between a "dom0" initial domain and a PV > shim initial domain. > > The logic for flask_domain_create() was altered to allow the incoming SID to > override the initial label. This allows a domain builder, whether it is a > toolstack, dom0less, or hyperlaunch, to provide the correct label for the > domain at construction. > > The base policy was adjusted to allow the idle domain under the xenboot_t > context the ability to construct domains of both types, dom0_t and domu_t. > This will enable a hypervisor resident domain builder to construct domains > beyond the initial domain, > > Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Fri Sep 09 16:28:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 16:28:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404485.646974 (Exim 4.92) (envelope-from ) id 1oWgrO-0004DA-SU; Fri, 09 Sep 2022 16:28:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404485.646974; Fri, 09 Sep 2022 16:28:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWgrO-0004D3-PH; Fri, 09 Sep 2022 16:28:06 +0000 Received: by outflank-mailman (input) for mailman id 404485; Fri, 09 Sep 2022 16:28:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWgrN-0004Ct-Co; Fri, 09 Sep 2022 16:28:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWgrN-0006NN-9F; Fri, 09 Sep 2022 16:28:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWgrM-0007ZV-Tf; Fri, 09 Sep 2022 16:28:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWgrM-00035B-T9; Fri, 09 Sep 2022 16:28:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZiHiNbsZeh++81rTLPM3acZ0jJ64w5d/rmmoUrZAM5s=; b=mlnHjVyaUhVhCu959BBeOgvLYF WHbWvq7rJfm2O/8ylI+hqbqZ5BOkiPXncu/RgPSHrosswOAkJWKBWlsUCWgTQiw6vTrta+/2OhZKf L5/C4xV+By0CmL/yM3WOAMXTt25X/2SltWrxqb67bY7PPontyivsbNFW61RRT0+7GW+w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173090: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9066d877bf57a47b0f09741dac996ee1055d6407 X-Osstest-Versions-That: xen=36e3f41587788c60813b088b373960b7fb88c021 From: osstest service owner Date: Fri, 09 Sep 2022 16:28:04 +0000 flight 173090 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173090/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173078 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9066d877bf57a47b0f09741dac996ee1055d6407 baseline version: xen 36e3f41587788c60813b088b373960b7fb88c021 Last test of basis 173078 2022-09-09 00:00:26 Z 0 days Testing same since 173090 2022-09-09 10:01:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 36e3f41587..9066d877bf 9066d877bf57a47b0f09741dac996ee1055d6407 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Sep 09 16:45:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 16:45:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404494.646984 (Exim 4.92) (envelope-from ) id 1oWh82-00079f-9o; Fri, 09 Sep 2022 16:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404494.646984; Fri, 09 Sep 2022 16:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWh82-00079Y-7B; Fri, 09 Sep 2022 16:45:18 +0000 Received: by outflank-mailman (input) for mailman id 404494; Fri, 09 Sep 2022 16:45:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWh80-00079O-JX; Fri, 09 Sep 2022 16:45:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWh80-0006gB-Dp; Fri, 09 Sep 2022 16:45:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWh7z-0008O0-Vh; Fri, 09 Sep 2022 16:45:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWh7z-0004EL-VF; Fri, 09 Sep 2022 16:45:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q7+DGW2dHIHFAf3kN7fhG9HtkSBSHhIzKVoV8ESSBgs=; b=Um5egOuSn06SiwQPDH1/adgNXk Y9Tg2dR+lEcoJfi+LJ8q6cBQXYFiSOejMPayxhszapOy7AFbSwP5Hi7jiKFKqAhblIEx33iRJlro1 VM8/obXkhKi8Uj/Jr0fRaztgxPiqHFYpsW4GG0/XWybu5yL21bV3Ot8ngNC2USoM98cw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173080: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 09 Sep 2022 16:45:15 +0000 flight 173080 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173080/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-pvops 6 kernel-build fail in 173067 REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 173067 test-amd64-amd64-xl-rtds 18 guest-localmigrate fail in 173067 pass in 173080 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173067 pass in 173080 test-armhf-armhf-xl-rtds 14 guest-start fail in 173067 pass in 173080 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 173067 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 173067 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173067 blocked in 172128 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173067 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173067 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 36 days Failing since 172384 2022-08-11 11:13:58 Z 29 days 62 attempts Testing same since 173008 2022-09-05 15:47:43 Z 4 days 8 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-step test-armhf-armhf-xl-credit1 host-install(5) Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 19:04:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 19:04:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404506.646996 (Exim 4.92) (envelope-from ) id 1oWjIC-0007zb-19; Fri, 09 Sep 2022 19:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404506.646996; Fri, 09 Sep 2022 19:03:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjIB-0007zU-Uq; Fri, 09 Sep 2022 19:03:55 +0000 Received: by outflank-mailman (input) for mailman id 404506; Fri, 09 Sep 2022 19:03:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjIA-0007zK-EI; Fri, 09 Sep 2022 19:03:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjIA-0000l6-Bk; Fri, 09 Sep 2022 19:03:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjI9-00018F-Vw; Fri, 09 Sep 2022 19:03:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWjI9-0003JL-VU; Fri, 09 Sep 2022 19:03:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bS+3MuAtJmctykSo12VxtZvJoIzTRagNJHMTgsPZ4b0=; b=1xrh9HyUdgjL1Zz0SA+VXqNgcj g+jUuTXB56VA/ZeTk4jzvio/Ui4H0LVdr8L/Q6RFkbbA6tJD0qcTyj3piC3iH4cziG9uYofPfGAn5 F8vQ3SN8QU9vwC4RMpN+tNawQsHbCTOgQZWNGkN7G6wHUMV3hXofeILMv9X1UVYbP/6A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173095: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 19:03:53 +0000 flight 173095 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173095/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 276 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 19:41:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 19:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404515.647007 (Exim 4.92) (envelope-from ) id 1oWjs7-0004xa-TQ; Fri, 09 Sep 2022 19:41:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404515.647007; Fri, 09 Sep 2022 19:41:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjs7-0004xT-Qa; Fri, 09 Sep 2022 19:41:03 +0000 Received: by outflank-mailman (input) for mailman id 404515; Fri, 09 Sep 2022 19:41:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjs6-0004xG-Ay; Fri, 09 Sep 2022 19:41:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjs6-0001P3-6q; Fri, 09 Sep 2022 19:41:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWjs5-0003iw-P2; Fri, 09 Sep 2022 19:41:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWjs5-0008Cr-OS; Fri, 09 Sep 2022 19:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ngK+Z8spX0XiS22/w5x5KMKfcg8H3BmFqMnyIZclei4=; b=Y4O7Qw1t58TMi/CsFTHozT/1cm 0GNpdu/y2G7V5MJcV9af6xp+C7McXX3/YYL5FtfTuopERA80OHXevoXeXkfQH5Uu/DxuPbsCaT8r2 CK5xE0VX7vfHZmZnMtwhjwN45YYsVj4GueK+Ztw4EBp9SDxauXy013GiEbLZVFkeUylM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173083: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f3ca66acc0818992da63027baca8547b21a8fdcf X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 09 Sep 2022 19:41:01 +0000 flight 173083 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173083/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt f3ca66acc0818992da63027baca8547b21a8fdcf baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 791 days Failing since 151818 2020-07-11 04:18:52 Z 790 days 772 attempts Testing same since 173083 2022-09-09 04:20:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122493 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 20:26:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 20:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404524.647018 (Exim 4.92) (envelope-from ) id 1oWkZQ-00024h-Aa; Fri, 09 Sep 2022 20:25:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404524.647018; Fri, 09 Sep 2022 20:25:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkZQ-00024a-7m; Fri, 09 Sep 2022 20:25:48 +0000 Received: by outflank-mailman (input) for mailman id 404524; Fri, 09 Sep 2022 20:25:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkZO-000248-0R for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 20:25:46 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 940740d4-307d-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 22:25:43 +0200 (CEST) Received: from MWH0EPF00056D03.namprd21.prod.outlook.com (2603:10b6:30f:fff2:0:1:0:d) by MN0PR12MB5905.namprd12.prod.outlook.com (2603:10b6:208:379::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 9 Sep 2022 20:25:39 +0000 Received: from CO1NAM11FT095.eop-nam11.prod.protection.outlook.com (2a01:111:f400:7eab::206) by MWH0EPF00056D03.outlook.office365.com (2603:1036:d20::b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.6 via Frontend Transport; Fri, 9 Sep 2022 20:25:38 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT095.mail.protection.outlook.com (10.13.174.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 20:25:38 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 9 Sep 2022 15:25:37 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 9 Sep 2022 13:25:37 -0700 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 9 Sep 2022 15:25:36 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 940740d4-307d-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z0Wqqmo/JP5u1RHPk8GU+0kL140C0xicjygWj8LsQ2lhZcwWpAsP30lz385au+nbhkgWpVmu6x7SjhGrDUMIYgB5KEixN+2dRfkqJUgQjYIbJyOnfDSHPXBOIulJtalFFKZg2VLn2vcZJfHJQpHR0nqsIzJEHVN1vIQAR9jfS+thCvCTzpz+yvvSL9clsweZ/F75J/pwV6a/L7oFkCVGPkG5zp+dIoSJLSZnp9seIKw1q8JaqagijVSlSnoHAmJsOFPR8R0Y8FSTgTZm8BfAh7KVuU96OQh32C6nGi5Z7ieh+DLrYnytNni5CKt2cHG4XDAloxfgnANfdpMUXhmXCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mroN2LYISOz1p+YklRyyQtahsx+nKrF2HvLfBkIooS0=; b=LtZMlBA9FI3MmfJG6Oet78npGnhjYX5sV7M2FqAwVdRnYyEW2vpqM01NTaR8VAlut1BDao96bgbvrOMT4cvqww3xcv6HrEak66mb9lXTW/aHZlNl0+PHk0bnPUpN9w8qsrT9uqaMfJVQ1W7KPR9AqDtgr2l94tSOSKBZITD8HkTDUcmbMDELQ1dAkFLJP2iQhUMwyIwpO6f2SldgmdK2RU+YkJsXJR3Ap3DnAc1YdBaKmnAY5RLf1BMg+oQLVW2BiCdLpHktC0mG5poGp7a+dirgqqH2NsCl7n/HIKYthRHtdd5TFLI6ZiTFfv1yvcrbA46AIcxjY82pGouqSg2Plg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mroN2LYISOz1p+YklRyyQtahsx+nKrF2HvLfBkIooS0=; b=htHGj4JUZo2d7onnkZBhQ92oeSkZpgoz0QtazFBOp63GsSqSf15JD54YBg/pV0pecaxiqaymAJhwr0Q+1DRnmtlksXfbteLhU7ZbBhWPeiaQ0Yu2RjGy/yQopZ+9Oi7MQzVnmCHlin0rKdfow9koE0uyNRvDw0NGGdcPscpYDYo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Date: Fri, 9 Sep 2022 13:25:35 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross CC: Stefano Stabellini , , , , , , , Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT095:EE_|MN0PR12MB5905:EE_ X-MS-Office365-Filtering-Correlation-Id: a8a6c574-f754-44b0-7a74-08da92a175aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xc270pNgzrfJGhWPV4w2xYamiqMcEi81jueRl3z2YzF6hb/UTdwdwlOAeGTPEjPcBFvYL84HJ+4TcY3shCgzTVOpT8DvB4jwOUP5pKnOi0Jgn8EwKjpi74h31N9/wwVtihuheGKi88bvXs/gBpdM1BqaymLY6PSw4O5FR8pAV+u6+KRq3QI4uCyerd5T99zIQDbRLNjOtuzcv7l0eziyFeHGjspykp94dNKNG4EOtAtPeib3sa8bj8GMoqo1nBPa00uM8etGy1Lu7rcx6WIMBaREPKf9WPdVkcRf/g9zbtfI6cqkaXRnIoRCuGENZL2jiapXw/MEge8G0yFmSh78mb6aWSAk8EcCD0/Hu9hZRIVcXkwSvr3x1RbYt13yP/UVJpy5iLd1e2nESzP2IXmMnw7+OOuMiwtR3HdKWrNprGuRoaYVZEnAxPelB4fOB6R7bWYbhgZZ/rPSqXCeV7lfbgtqaC2P9FDJrSTxXECZGx3EFAqmGtU1s37X7p0+AHtY2sjsOsMVKFka17m4SG5m85c6c//mESWvFCscKR/Tj0EdAsLKjOg5KsLWX+ChOBlAeZqhGcUEd/svzABPueZNy4YTpuIDiqPm/4LNPwU2pDnTWaDFLys3azDdu2lEkiH/5KlHbxhG1WvDfbTzgnhrMCMuINZIF+/X6yen+do1RRqVca1Zt86dXb3REon6eKZB1fSM6ehT00W2gYE1zFPilaVvspMuGWoBCq2NHp5Q9o6ih8YvO+wZwYnFB5EEv8W3vZqi8mlg9zrUA0r9zYjyGePf+cMtk6K8u8A8NGl3srM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(7916004)(4636009)(39860400002)(346002)(136003)(376002)(396003)(46966006)(36840700001)(40470700004)(8936002)(9686003)(336012)(40460700003)(5660300002)(41300700001)(478600001)(4326008)(86362001)(53546011)(82310400005)(316002)(8676002)(36860700001)(44832011)(33716001)(2906002)(26005)(81166007)(40480700001)(356005)(426003)(82740400003)(70206006)(47076005)(83380400001)(70586007)(186003)(54906003)(6916009)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 20:25:38.5968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8a6c574-f754-44b0-7a74-08da92a175aa X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5905 On Fri, 9 Sep 2022, Juergen Gross wrote: > On 09.09.22 04:11, Stefano Stabellini wrote: > > Adding more people in CC > > > > On Thu, 8 Sep 2022, Stefano Stabellini wrote: > > > Hi Juergen, > > > > > > A colleague is seeing a failure on x86 in Linux Dom0. The failure is > > > pin_user_pages_fast with addresses that correspond to foreign memory > > > pages: > > > > > > - QEMU maps a domU address using dma_memory_map (xen_map_cache) > > > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Address > > > returned by dma_memory_map > > > - Linux tee_shm_register->pin_user_pages_fast Returns -14 - > > > drivers/tee/tee_shm.c > > > > > > Once upon a time it used to be the case that get_user_pages_fast would > > > fail on Xen because we didn't have a struct page corresponding to > > > foreign memory mappings. But that hasn't been the case for years now. > > > > > > Any other ideas why it would fail? > > I think we can expect that access_ok() isn't failing. > > I assume the mapping was done allowing writes (sorry for paranoia mode)? I was told it was verified: QEMU could read and write to the VA returned by dma_memory_map. From /proc//maps, the VA assigned after the mapping is pointing to /dev/xen/privcmd. > Other than that I'm not having enough memory management skills. It might be > related to mmap()-ed foreign pages having _PAGE_SPECIAL set, though. Do we still set PAGE_SPECIAL for foreign mapped pages? It looks like it is not there anymore? If PAGE_SPECIAL is not there, then they really should look like regular pages? From xen-devel-bounces@lists.xenproject.org Fri Sep 09 20:40:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 20:40:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404534.647029 (Exim 4.92) (envelope-from ) id 1oWkny-00055i-OO; Fri, 09 Sep 2022 20:40:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404534.647029; Fri, 09 Sep 2022 20:40:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkny-00055b-Lh; Fri, 09 Sep 2022 20:40:50 +0000 Received: by outflank-mailman (input) for mailman id 404534; Fri, 09 Sep 2022 20:40:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkny-00055V-0S for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 20:40:50 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aeae9b9f-307f-11ed-9760-273f2230c3a0; Fri, 09 Sep 2022 22:40:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A76062031; Fri, 9 Sep 2022 20:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 238ACC433C1; Fri, 9 Sep 2022 20:40:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aeae9b9f-307f-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662756045; bh=IbCvMncCEhI5v/tmp3HrX/u4Kga/tO3p8c2TtFrP+50=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cgSqwzYIDbxuLjgZ2gGObZThLRn0QniotyHYBDwQnR+OHSNRH5f2cOlDM4UaDI9iW PcPZ94+fV+vPXjIkzqI1QaU1eFPOpDUctasWEQO8/QJ066gGEtLIet5xhtUFJyTbbc AklBaYfXBByBXQnjmZFXLCkmImaZtA9yLp9X2RRZbA/hHN6CukEfmKlVXL3dGHC31Y W+dMPwSwnLdL6HklJ9VPUGvGiFVdjK8HH1Kg9Ik4Ssu55wIPDQwo6Hckt/jIHEmm09 Yzt31Maux/qQF8aQIr7L0uIIVtGaNBbl918/krQksM6L8kyJAdbZJKmx7AIfnnQB2s VvKozbq8J9gMg== Date: Fri, 9 Sep 2022 13:40:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH v6 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar In-Reply-To: <851cdf28f007326e9f7e1aaeab3688498aaecc9e.1662715131.git.rahul.singh@arm.com> Message-ID: References: <851cdf28f007326e9f7e1aaeab3688498aaecc9e.1662715131.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 9 Sep 2022, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passthrough. > > On x86, pci_check_bar will call is_memory_hole which will check if BAR > is not overlapping with any memory region defined in the memory map. > > On ARM, pci_check_bar will go through the host bridge ranges and check > if the BAR is in the range of defined ranges. > > Signed-off-by: Rahul Singh > Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini > --- > Changes in v6: > - change from unsigned long to paddr_t > Changes in v5: > - drop use of PFN_UP and PF_DOWN in case addresses are not aligned. > - As we drop the PFN_UP and PFN_DOWN we need to use the mfn_to_maddr() > to get the BAR address without page shift. > - Add TODO comment for address alignment check for ranges. > - Added Jan Acked-by for x86 and common code. > Changes in v4: > - check "s <= e" before callback > - Add TODO comment for revisiting the function pci_check_bar() when > ACPI PCI passthrough support is added. > - Not Added the Jan Acked-by as patch is modified. > Changes in v3: > - fix minor comments > --- > --- > xen/arch/arm/include/asm/pci.h | 2 ++ > xen/arch/arm/pci/pci-host-common.c | 54 ++++++++++++++++++++++++++++++ > xen/arch/x86/include/asm/pci.h | 10 ++++++ > xen/drivers/passthrough/pci.c | 8 ++--- > 4 files changed, 70 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h > index 80a2431804..8cb46f6b71 100644 > --- a/xen/arch/arm/include/asm/pci.h > +++ b/xen/arch/arm/include/asm/pci.h > @@ -126,6 +126,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d, > > int pci_host_bridge_mappings(struct domain *d); > > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end); > + > #else /*!CONFIG_HAS_PCI*/ > > struct arch_pci_dev { }; > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index 89ef30028e..a8ece94303 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -24,6 +24,16 @@ > > #include > > +/* > + * struct to hold pci device bar. > + */ > +struct pdev_bar_check > +{ > + paddr_t start; > + paddr_t end; > + bool is_valid; > +}; > + > /* > * List for all the pci host bridges. > */ > @@ -363,6 +373,50 @@ int __init pci_host_bridge_mappings(struct domain *d) > return 0; > } > > +/* > + * TODO: BAR addresses and Root Complex window addresses are not guaranteed > + * to be page aligned. We should check for alignment but this is not the > + * right place for alignment check. > + */ > +static int is_bar_valid(const struct dt_device_node *dev, > + paddr_t addr, paddr_t len, void *data) > +{ > + struct pdev_bar_check *bar_data = data; > + paddr_t s = bar_data->start; > + paddr_t e = bar_data->end; > + > + if ( (s >= addr) && (e <= (addr + len - 1)) ) > + bar_data->is_valid = true; > + > + return 0; > +} > + > +/* TODO: Revisit this function when ACPI PCI passthrough support is added. */ > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end) > +{ > + int ret; > + const struct dt_device_node *dt_node; > + paddr_t s = mfn_to_maddr(start); > + paddr_t e = mfn_to_maddr(end); > + struct pdev_bar_check bar_data = { > + .start = s, > + .end = e, > + .is_valid = false > + }; > + > + if ( s >= e ) > + return false; > + > + dt_node = pci_find_host_bridge_node(pdev); > + if ( !dt_node ) > + return false; > + > + ret = dt_for_each_range(dt_node, &is_bar_valid, &bar_data); > + if ( ret < 0 ) > + return false; > + > + return bar_data.is_valid; > +} > /* > * Local variables: > * mode: C > diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h > index c8e1a9ecdb..f4a58c8acf 100644 > --- a/xen/arch/x86/include/asm/pci.h > +++ b/xen/arch/x86/include/asm/pci.h > @@ -57,4 +57,14 @@ static always_inline bool is_pci_passthrough_enabled(void) > > void arch_pci_init_pdev(struct pci_dev *pdev); > > +static inline bool pci_check_bar(const struct pci_dev *pdev, > + mfn_t start, mfn_t end) > +{ > + /* > + * Check if BAR is not overlapping with any memory region defined > + * in the memory map. > + */ > + return is_memory_hole(start, end); > +} > + > #endif /* __X86_PCI_H__ */ > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index cdaf5c247f..149f68bb6e 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -304,8 +304,8 @@ static void check_pdev(const struct pci_dev *pdev) > if ( rc < 0 ) > /* Unable to size, better leave memory decoding disabled. */ > return; > - if ( size && !is_memory_hole(maddr_to_mfn(addr), > - maddr_to_mfn(addr + size - 1)) ) > + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), > + maddr_to_mfn(addr + size - 1)) ) > { > /* > * Return without enabling memory decoding if BAR position is not > @@ -331,8 +331,8 @@ static void check_pdev(const struct pci_dev *pdev) > > if ( rc < 0 ) > return; > - if ( size && !is_memory_hole(maddr_to_mfn(addr), > - maddr_to_mfn(addr + size - 1)) ) > + if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr), > + maddr_to_mfn(addr + size - 1)) ) > { > printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr), > PFN_DOWN(addr + size - 1)); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 09 20:41:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 20:41:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404536.647041 (Exim 4.92) (envelope-from ) id 1oWkoL-0005WP-1t; Fri, 09 Sep 2022 20:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404536.647041; Fri, 09 Sep 2022 20:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkoK-0005WD-TK; Fri, 09 Sep 2022 20:41:12 +0000 Received: by outflank-mailman (input) for mailman id 404536; Fri, 09 Sep 2022 20:41:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkoJ-0005Td-Kx for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 20:41:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9c6250a-307f-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 22:41:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0754A62031; Fri, 9 Sep 2022 20:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F6EFC433C1; Fri, 9 Sep 2022 20:41:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9c6250a-307f-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662756064; bh=hkxcvj/8MrM7eaEYMmpHk8S/3LUdyXPLgYfV8uQOfVo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tNbDiNcazIwMQFmld4a2/Hcd0sAPfYYsTyeznx+FEXYPRqYshVHG5vWHdbNraBiGu azDZzkTgmYlD9zLHRnaiEgYeKeigZEjVaY/WWdAzHhpE3l9sDGNnqqA81xv/oSKwGT 97CqLal175qV+ynoVmYgb7xeflUV1LbRZK/QuYq4FzctKlTpZ7UmFXJ0pmyIr3OtJH l/SeDMHfvEBqX1sgFpNytYaJzBG7EqehF6oaudQyD2+q2lQoCffX0JOOtSLG/RrxMe 16TzmyPSH0GKXCDrl9VwOPCJkd9UN/mM2PER8a1kiGraxPQ45KYqY8WdKqhENlHoDJ qSfcwHXRS750g== Date: Fri, 9 Sep 2022 13:41:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Henry Wang cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm, device-tree: Make static-mem use #{address,size}-cells In-Reply-To: <20220909052357.49349-1-Henry.Wang@arm.com> Message-ID: References: <20220909052357.49349-1-Henry.Wang@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 9 Sep 2022, Henry Wang wrote: > In order to keep consistency in the device tree binding, there is > no need for static memory allocation feature to define a specific > set of address and size cells for "xen,static-mem" property. > > Therefore, this commit reuses the regular #{address,size}-cells > for parsing the device tree "xen,static-mem" property. Update > the documentation accordingly. > > Also, take the chance to remove the unnecessary "#address-cells" > and "#size-cells" in the domU1 node of the device tree to only > emphasize the related part that the example is showing. > > Signed-off-by: Henry Wang Acked-by: Stefano Stabellini > --- > Changes from v1 to v2: > - Remove the "----" addition, as it is unnecessary to this patch. > - Mention the removal of #address-cells and #size-cells in domU1 > node in the commit message. > --- > docs/misc/arm/device-tree/booting.txt | 11 +++++------ > docs/misc/arm/passthrough-noiommu.txt | 7 +++---- > xen/arch/arm/bootfdt.c | 5 ----- > xen/arch/arm/domain_build.c | 16 ++-------------- > 4 files changed, 10 insertions(+), 29 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 5395a1077c..10caf4f1af 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -350,8 +350,8 @@ areas are pre-defined by configuration using physical address ranges. > > Memory can be statically allocated to a domain using the property "xen,static- > mem" defined in the domain configuration. The number of cells for the address > -and the size must be defined using respectively the properties > -"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". > +and the size must be defined respectively by the parent node properties > +"#address-cells" and "#size-cells". > > The property 'memory' is still needed and should match the amount of memory > given to the guest. Currently, it either comes from static memory or lets Xen > @@ -366,14 +366,13 @@ device-tree: > > / { > chosen { > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + ... > domU1 { > compatible = "xen,domain"; > - #address-cells = <0x2>; > - #size-cells = <0x2>; > cpus = <2>; > memory = <0x0 0x80000>; > - #xen,static-mem-address-cells = <0x1>; > - #xen,static-mem-size-cells = <0x1>; > xen,static-mem = <0x30000000 0x20000000>; > ... > }; > diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt > index 3e2ef21ad7..69b8de1975 100644 > --- a/docs/misc/arm/passthrough-noiommu.txt > +++ b/docs/misc/arm/passthrough-noiommu.txt > @@ -33,14 +33,13 @@ on static allocation in the device-tree: > > / { > chosen { > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + ... > domU1 { > compatible = "xen,domain"; > - #address-cells = <0x2>; > - #size-cells = <0x2>; > cpus = <2>; > memory = <0x0 0x80000>; > - #xen,static-mem-address-cells = <0x1>; > - #xen,static-mem-size-cells = <0x1>; > xen,static-mem = <0x30000000 0x20000000>; > direct-map; > ... > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 9e1ea60094..59675f086b 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -370,11 +370,6 @@ static int __init process_domain_node(const void *fdt, int node, > /* No "xen,static-mem" present. */ > return 0; > > - address_cells = device_tree_get_u32(fdt, node, > - "#xen,static-mem-address-cells", 0); > - size_cells = device_tree_get_u32(fdt, node, > - "#xen,static-mem-size-cells", 0); > - > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > size_cells, &bootinfo.reserved_mem, > MEMBANK_STATIC_DOMAIN); > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7412303d20..9040a8c6cb 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -565,21 +565,9 @@ static int __init parse_static_mem_prop(const struct dt_device_node *node, > const struct dt_property *prop; > > prop = dt_find_property(node, "xen,static-mem", NULL); > - if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", > - addr_cells) ) > - { > - printk(XENLOG_ERR > - "failed to read \"#xen,static-mem-address-cells\".\n"); > - return -EINVAL; > - } > > - if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", > - size_cells) ) > - { > - printk(XENLOG_ERR > - "failed to read \"#xen,static-mem-size-cells\".\n"); > - return -EINVAL; > - } > + *addr_cells = dt_n_addr_cells(node); > + *size_cells = dt_n_size_cells(node); > > *cell = (const __be32 *)prop->value; > *length = prop->length; > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 09 20:48:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 20:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404548.647050 (Exim 4.92) (envelope-from ) id 1oWkur-0006KC-MS; Fri, 09 Sep 2022 20:47:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404548.647050; Fri, 09 Sep 2022 20:47:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkur-0006K5-Jn; Fri, 09 Sep 2022 20:47:57 +0000 Received: by outflank-mailman (input) for mailman id 404548; Fri, 09 Sep 2022 20:47:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWkuq-0006Jz-1n for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 20:47:56 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ada8afcf-3080-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 22:47:55 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EBB4CB8261C; Fri, 9 Sep 2022 20:47:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5080CC433D6; Fri, 9 Sep 2022 20:47:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ada8afcf-3080-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662756472; bh=vp2KzoOCvU+55JopWQgzp+tvVVsQiuE4Lfpd22UIkCg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ClcWdw79DYmxi1gq+xb1NyHYnPxq/1rDzK9eVpkexuCDzH4Qjxjl+XuXWTnGZKxrg yHRHwNpDzBnDJnzhZxRkG+ZcZBzW3l5p2wV3wHfoKS5oBDw/ltbeuwkTwSQsPcHEiL lWUWVZq2lMn4UrqmfG93gJbsGYs8fPdy0b+xV91eT7Fi12xhkpBVwnbozi68WrO5il IjhzgwXnFEbhA6j1Btf1iYMqe38tSUaqWsXM7Wzt7vdOTf5pI08L2EWXK8eLQzDTyC K2Ig3dRdbcXrnQqYS/4NNryJ0MGCeFePh97H90eYA44C8DsDChYyC2THLOvn85jhDE lt4OTeMtpfIFA== Date: Fri, 9 Sep 2022 13:47:51 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Julien Grall , Stefano Stabellini , Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree In-Reply-To: Message-ID: References: <20220908135513.1800511-1-Penny.Zheng@arm.com> <20220908135513.1800511-8-Penny.Zheng@arm.com> <0DD9A3DA-4677-46F4-A454-3EAC335443AB@arm.com> <34ae5402-799e-1c43-7ab2-6e8935471cc2@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1169836828-1662754275=:157835" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1169836828-1662754275=:157835 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 9 Sep 2022, Luca Fancellu wrote: > > On 9 Sep 2022, at 10:40, Bertrand Marquis wrote: > > > > Hi Julien, > > > >> On 9 Sep 2022, at 10:27, Julien Grall wrote: > >> > >> Hi, > >> > >> On 09/09/2022 08:45, Bertrand Marquis wrote: > >>>> > >>>> It should be: > >>>> > >>>> /* > >>>> * TODO: > >>>> * > >>>> > >>>> I think this is good to go. The two minor style issues could be fixed on > >>>> commit. I haven't committed to give Julien & Bertrand another chance to > >>>> have a look. > >>> I think that it is ok to fix those on commit and I am ok with the rest so: > >>> Reviewed-by: Bertrand Marquis > >> > >> This series doesn't build without !CONFIG_STATIC_SHM: > >> > >> UPD include/xen/compile.h > >> Xen 4.17-unstable > >> make[1]: Nothing to be done for `include'. > >> make[1]: `arch/arm/include/asm/asm-offsets.h' is up to date. > >> CC common/version.o > >> LD common/built_in.o > >> CC arch/arm/domain_build.o > >> arch/arm/domain_build.c: In function ‘make_shm_memory_node’: > >> arch/arm/domain_build.c:1445:1: error: no return statement in function returning non-void [-Werror=return-type] > >> } > >> ^ > >> cc1: all warnings being treated as errors > >> make[2]: *** [arch/arm/domain_build.o] Error 1 > >> make[1]: *** [arch/arm] Error 2 > >> make: *** [xen] Error 2 > >> > >> This is because... > >> > >>>>> + * - xen,offset: (borrower VMs only) > >>>>> + * 64 bit integer offset within the owner virtual machine's shared > >>>>> + * memory region used for the mapping in the borrower VM > >>>>> + */ > >>>>> + res = fdt_property_u64(fdt, "xen,offset", 0); > >>>>> + if ( res ) > >>>>> + return res; > >>>>> + > >>>>> + res = fdt_end_node(fdt); > >>>>> + if ( res ) > >>>>> + return res; > >>>>> + } > >>>>> + > >>>>> + return res; > >>>>> +} > >>>>> +#else > >>>>> +static int __init make_shm_memory_node(const struct domain *d, > >>>>> + void *fdt, > >>>>> + int addrcells, int sizecells, > >>>>> + const struct meminfo *mem) > >>>>> +{ > >>>>> + ASSERT_UNREACHABLE(); > >> > >> ... there is a missing 'return -ENOTSUPP' here. While this is simple enough to fix, this indicates to me that this version was not tested with !CONFIG_STATIC_SHM. > >> > >> As this is the default option, I will not commit until I get confirmation that some smoke was done. > > > > This is a case our internal CI should have gone through. > > Let me check and come back to you. > > > > Hi Julien, > > Thanks for catching it, in this case I can confirm that the problem was that we are building with CONFIG_DEBUG enabled, I don’t know why GCC doesn’t complain when > you have __builtin_unreachable() in that function without any return value, it doesn’t even throw a warning. Could it be considered a bug in GCC? > > Building Xen without CONFIG_DEBUG instead shows up the error you found. > > In this case this change will fix the problem, do you agree on it? > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 8c77c764bcf2..c5d66f18bd49 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1439,6 +1439,8 @@ static int __init make_shm_memory_node(const struct domain *d, > const struct meminfo *mem) > { > ASSERT_UNREACHABLE(); > + > + return -EOPNOTSUPP; > } > #endif > > Is it something that can be addressed on commit? The suggestion makes sense. I raw a few tests myself and also a pipeline through gitlab-ci to be sure. Everything passed, so (also mindful of the deadlines) I committed the series with this change. --8323329-1169836828-1662754275=:157835-- From xen-devel-bounces@lists.xenproject.org Fri Sep 09 21:39:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 21:39:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404567.647110 (Exim 4.92) (envelope-from ) id 1oWlil-0005rg-3h; Fri, 09 Sep 2022 21:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404567.647110; Fri, 09 Sep 2022 21:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWlik-0005rZ-Vs; Fri, 09 Sep 2022 21:39:30 +0000 Received: by outflank-mailman (input) for mailman id 404567; Fri, 09 Sep 2022 21:39:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWlij-0005rT-9I for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 21:39:29 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e02810e6-3087-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 23:39:27 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C7EB6CE2462; Fri, 9 Sep 2022 21:39:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E625C433C1; Fri, 9 Sep 2022 21:39:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e02810e6-3087-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662759563; bh=WF9a+4xTSooI6ApIP+0Yd/CoT9WZkHMvxCNn2JHTzl8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=C224UHW/od2vUWJUV5sxndFt1RKPY3I1HW7bNLuitOWhEVpluU8FDnqbEPEJM8zls oAJDzm4i0KYqqawZnS+rWLq4UVHrwcgpyVg8FFBevKmBm4sA4uBMoz1tESLr0xzz2X nY3kBYYJ8CiZnsEjAvFQjJ3TPwIU6C284qr/0dJxIWTRVyfgOvjHIaG1QA5H/4sNaY fsEBJGj9sOl6d0CE3n3ClBppRd7/Mn7KHa8i3CBxV4W3ChODWy21iGhLGz6J6Gu9JO 9GCEs0WhiyhwhBcjRAlYyr+DA8MUWt60+M1MBo2e5NyI3ctR7x9jisEPp9nk5gxUZa syFozcvgSoZkQ== Date: Fri, 9 Sep 2022 14:39:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 9 Sep 2022, Jan Beulich wrote: > While I was suspicious of the compiler issuing a diagnostic about an > unused linking-only option when not doing any linking, I did check this > with a couple of gcc versions only, but not with Clang. (Oddly enough at > least older Clang versions complain about the use of '-nopie' now that > we actually use '-no-pie'.) Filter out the problematic option in all > cases where the variable is consumed for compilation only (which right > now is everywhere). > > Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") > Reported-by: Stefano Stabellini > Signed-off-by: Jan Beulich I don't think I can review the patch but it made the pipeline pass again: https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/636189844 So: Tested-by: Stefano Stabellini > --- > Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for > compiling, the option could be omitted from that variable right away. > But if any compile-and-link-in-one-go use appeared, there would be an > issue. > > --- a/tools/firmware/Rules.mk > +++ b/tools/firmware/Rules.mk > @@ -13,7 +13,7 @@ endif > > CFLAGS += -Werror > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > > $(call cc-option-add,CFLAGS,CC,-fcf-protection=none) > > --- a/tools/tests/x86_emulator/testcase.mk > +++ b/tools/tests/x86_emulator/testcase.mk > @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. > CFLAGS := > include $(XEN_ROOT)/tools/Rules.mk > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > > CFLAGS += -fno-builtin -g0 $($(TESTCASE)-cflags) > > --- a/xen/arch/arm/arch.mk > +++ b/xen/arch/arm/arch.mk > @@ -1,7 +1,7 @@ > ######################################## > # arm-specific definitions > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > $(call cc-option-add,CFLAGS,CC,-Wnested-externs) > > # Prevent floating-point variables from creeping into Xen. > --- a/xen/arch/x86/arch.mk > +++ b/xen/arch/x86/arch.mk > @@ -10,7 +10,7 @@ CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFF > # Prevent floating-point variables from creeping into Xen. > CFLAGS += -msoft-float > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > $(call cc-option-add,CFLAGS,CC,-Wnested-externs) > $(call as-option-add,CFLAGS,CC,"vmcall",-DHAVE_AS_VMX) > $(call as-option-add,CFLAGS,CC,"crc32 %eax$$(comma)%eax",-DHAVE_AS_SSE4_2) > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -12,7 +12,7 @@ endif > $(obj)/head.o: $(head-bin-objs:.o=.bin) > > CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS)) > -$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS_x86_32,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float > ifdef building_out_of_srctree > CFLAGS_x86_32 += -I$(objtree)/include > From xen-devel-bounces@lists.xenproject.org Fri Sep 09 23:05:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 23:05:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404578.647121 (Exim 4.92) (envelope-from ) id 1oWn4A-0000H8-G0; Fri, 09 Sep 2022 23:05:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404578.647121; Fri, 09 Sep 2022 23:05:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWn4A-0000H1-Bz; Fri, 09 Sep 2022 23:05:42 +0000 Received: by outflank-mailman (input) for mailman id 404578; Fri, 09 Sep 2022 23:05:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWn48-0000Gq-QJ; Fri, 09 Sep 2022 23:05:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWn48-00058l-NS; Fri, 09 Sep 2022 23:05:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWn48-0007V2-2g; Fri, 09 Sep 2022 23:05:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWn48-0005Vn-2B; Fri, 09 Sep 2022 23:05:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PNaAR+317N7bjBfWV0eZJeoUWfs/+L7ErX5gMFQFmiE=; b=l4Cw0LZ515XnOqoWK+a6i5wSk2 S7fHwbP8XzMD550TG6HKePD1FopvctPqpFQyrg4X5960rX7MAPVulSjosU+007Ab1PcsHtsLpr0+B p4Etf7QEYyjDF+qv8IDzP4pcg0SfXYMgAf37HAO3OUc/+I5z95hfUGLl8Lyama/7RQtc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173098: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 09 Sep 2022 23:05:40 +0000 flight 173098 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173098/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 277 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 09 23:27:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 09 Sep 2022 23:27:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404587.647132 (Exim 4.92) (envelope-from ) id 1oWnPO-0003LR-89; Fri, 09 Sep 2022 23:27:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404587.647132; Fri, 09 Sep 2022 23:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWnPO-0003LK-50; Fri, 09 Sep 2022 23:27:38 +0000 Received: by outflank-mailman (input) for mailman id 404587; Fri, 09 Sep 2022 23:27:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWnPN-0003LA-I3; Fri, 09 Sep 2022 23:27:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWnPN-0005Xk-Eo; Fri, 09 Sep 2022 23:27:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWnPM-0008K4-WD; Fri, 09 Sep 2022 23:27:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWnPM-0003DG-Vk; Fri, 09 Sep 2022 23:27:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jxYeCp0k89Nc5B5YLDWv+3K4vROPQ2e+T/Ew3ihWXCo=; b=WqTiu2qit7GZi2hwH2V+DoNaS5 J7qKAWEyta7PCXon2KuuJ5JGo1lWOqha0hE2vIB0/t5pP8wRnqEdQF8/V2WFmq053X543Uyjh2LFr 8MPnvs5iF3Vg7Dm7qjbuMUX+H/5GLIs5o6dNZ++duCF6LnMDNjLovQI/6YeD0WMRcVCc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173088: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-credit2::broken:regression qemu-mainline:test-armhf-armhf-xl-arndale::broken:regression qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug qemu-mainline:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 09 Sep 2022 23:27:36 +0000 flight 173088 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173088/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-arndale broken build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 5 host-install(5) broken pass in 173074 test-armhf-armhf-xl-credit2 5 host-install(5) broken pass in 173074 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 173060 pass in 173088 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 173060 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 173074 test-armhf-armhf-xl-vhd 12 debian-di-install fail pass in 173074 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173074 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173074 never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173074 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173074 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173074 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173074 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 37 days Failing since 172148 2022-08-04 21:39:38 Z 36 days 81 attempts Testing same since 173060 2022-09-08 07:34:59 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-arndale broken broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl-credit2 host-install(5) Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 00:26:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 00:26:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404596.647143 (Exim 4.92) (envelope-from ) id 1oWoKG-0003Sw-CK; Sat, 10 Sep 2022 00:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404596.647143; Sat, 10 Sep 2022 00:26:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoKG-0003Sp-9B; Sat, 10 Sep 2022 00:26:24 +0000 Received: by outflank-mailman (input) for mailman id 404596; Sat, 10 Sep 2022 00:26:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoKE-0003Sd-Iq; Sat, 10 Sep 2022 00:26:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoKE-0007P7-H8; Sat, 10 Sep 2022 00:26:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoKE-0001Mo-0q; Sat, 10 Sep 2022 00:26:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWoKE-00049G-01; Sat, 10 Sep 2022 00:26:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GSjtNZok0UrvF7etgrqgB6jfWH2qRdvOz7CqNOcfeAs=; b=EIzAMzDMXBr+uwIdHV83E0QwDI e2Lk3LKUthaGNyk+7Y1siUdD5VOwfaY9n0YeiGc4b77zyFLYzBZMlxgvSWr6ItfzyGMokNaPznyOo tK/fcxakJlmGIcIF08CFRryQDzY8x/xkH7XHI9/eNKS/6b/Zy/HuRJXvxs3r50ptnrsw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173096: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-armhf-armhf-xl:debian-install:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=52daa6a8483e4fbd6757c9d1b791e23931791608 X-Osstest-Versions-That: xen=9066d877bf57a47b0f09741dac996ee1055d6407 From: osstest service owner Date: Sat, 10 Sep 2022 00:26:22 +0000 flight 173096 xen-unstable-smoke real [real] flight 173099 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173096/ http://logs.test-lab.xenproject.org/osstest/logs/173099/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 12 debian-install fail REGR. vs. 173090 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173090 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 52daa6a8483e4fbd6757c9d1b791e23931791608 baseline version: xen 9066d877bf57a47b0f09741dac996ee1055d6407 Last test of basis 173090 2022-09-09 10:01:57 Z 0 days Testing same since 173096 2022-09-09 17:03:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Juergen Gross jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 52daa6a8483e4fbd6757c9d1b791e23931791608 Author: Juergen Gross Date: Fri Sep 9 14:53:47 2022 +0200 xen/gnttab: fix gnttab_acquire_resource() Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") was wrong, as vaddrs can legitimately be NULL in case XENMEM_resource_grant_table_id_status was specified for a grant table v1. This would result in crashes in debug builds due to ASSERT_UNREACHABLE() triggering. Check vaddrs only to be NULL in the rc == 0 case. Expand the tests in tools/tests/resource to tickle this path, and verify that using XENMEM_resource_grant_table_id_status on a v1 grant table fails. Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich # xen Reviewed-by: Andrew Cooper Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 00:59:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 00:59:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404609.647157 (Exim 4.92) (envelope-from ) id 1oWoqW-00087I-47; Sat, 10 Sep 2022 00:59:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404609.647157; Sat, 10 Sep 2022 00:59:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoqW-00087B-1A; Sat, 10 Sep 2022 00:59:44 +0000 Received: by outflank-mailman (input) for mailman id 404609; Sat, 10 Sep 2022 00:59:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoqV-000871-9e; Sat, 10 Sep 2022 00:59:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoqU-0008S0-S8; Sat, 10 Sep 2022 00:59:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWoqU-00036w-G0; Sat, 10 Sep 2022 00:59:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWoqU-0004Fv-FZ; Sat, 10 Sep 2022 00:59:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=J+aFz1WC/WMzJIb+i+TYvHQhC9cRk4v0465/z9DfnIA=; b=50ifNnHPSkl3a4gdePb787DnmH AJi1lpaB4DhrtBHHAR9ecwSmUsPYfWGFXQZ8RehpKjYvKrGiYEfqe1r5/u27tkEYzVQS64yreFcjn Zx/pjCc1abFIbTgDsDiwxaQcERiMQa3fcj/n2KfSYzw4KPC9ndC5LJ49r6ujVZBqfGYo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173091: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=506357871c18e06565840d71c2ef9f818e19f460 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 10 Sep 2022 00:59:42 +0000 flight 173091 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-arm64-arm64-examine 8 reboot fail pass in 173075 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 173075 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 506357871c18e06565840d71c2ef9f818e19f460 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 36 days Failing since 172152 2022-08-05 04:01:26 Z 35 days 81 attempts Testing same since 173075 2022-09-08 22:41:25 Z 1 days 2 attempts ------------------------------------------------------------ 1726 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 177251 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 01:10:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 01:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404618.647168 (Exim 4.92) (envelope-from ) id 1oWp1D-0000Kh-2p; Sat, 10 Sep 2022 01:10:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404618.647168; Sat, 10 Sep 2022 01:10:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWp1D-0000Ka-0F; Sat, 10 Sep 2022 01:10:47 +0000 Received: by outflank-mailman (input) for mailman id 404618; Sat, 10 Sep 2022 01:10:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWp1C-0000KM-3o; Sat, 10 Sep 2022 01:10:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWp1C-00070A-1z; Sat, 10 Sep 2022 01:10:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWp1B-0004HL-L3; Sat, 10 Sep 2022 01:10:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWp1B-0001Ed-Ka; Sat, 10 Sep 2022 01:10:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QNkci5BH01Gh3BWR6vZqEw0xbhn5i/qHKx+r1B66z7c=; b=C2S2T4AWcWJaGovwwmSs+K+X0N DYoepWENcAHrj+xU7+Z52cEyfyLXvQN10GxkwG9O0wvax7U7xQVQJ0diAzfoBxN9OfUQ8APoubimO u+nyJ1ZvSVEXYbUvpFJ6hTVpu4cUJlRqSopNGchCAGBqC2oi3PA5mUfQ5oc07w34nIPE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173100: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 01:10:45 +0000 flight 173100 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173100/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 35 days 278 attempts Testing same since 173081 2022-09-09 03:19:40 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 03:11:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 03:11:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404629.647187 (Exim 4.92) (envelope-from ) id 1oWqtq-0006ST-NT; Sat, 10 Sep 2022 03:11:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404629.647187; Sat, 10 Sep 2022 03:11:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWqtq-0006SK-Jy; Sat, 10 Sep 2022 03:11:18 +0000 Received: by outflank-mailman (input) for mailman id 404629; Sat, 10 Sep 2022 03:11:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWqtp-0006S6-Pj; Sat, 10 Sep 2022 03:11:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWqtp-00013v-N2; Sat, 10 Sep 2022 03:11:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWqtp-0002SW-A0; Sat, 10 Sep 2022 03:11:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWqtp-0004ti-9C; Sat, 10 Sep 2022 03:11:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x22ojGp4T03AzZzp242TfJeFgnsDSbTrP3C9DnN0TBo=; b=sY4NHFaBzfNCkOFFbjK5wW9w/u xWB1k36PNyZdjHZDditOrzcCr3QoE0tL++yx0bIUfwZvnhextvgAzg/CrItjsWUusuEX+xcG0i2DH zsvpT0+KvKUCqRn1bDsUcQ6+bqWrOPha/SSbhzb0EfDzOnrOR+5ZqOp4QrV20hmx5QbM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173093: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=36e3f41587788c60813b088b373960b7fb88c021 X-Osstest-Versions-That: xen=6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc From: osstest service owner Date: Sat, 10 Sep 2022 03:11:17 +0000 flight 173093 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173093/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173073 build-i386-libvirt 6 libvirt-build fail like 173073 build-arm64-libvirt 6 libvirt-build fail like 173073 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173073 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173073 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173073 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173073 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173073 build-armhf-libvirt 6 libvirt-build fail like 173073 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173073 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173073 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173073 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173073 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 36e3f41587788c60813b088b373960b7fb88c021 baseline version: xen 6bc1c1aba01f663687d7d2b48ccdf8d9432d92cc Last test of basis 173073 2022-09-08 22:08:56 Z 1 days Testing same since 173093 2022-09-09 12:13:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6bc1c1aba0..36e3f41587 36e3f41587788c60813b088b373960b7fb88c021 -> master From xen-devel-bounces@lists.xenproject.org Sat Sep 10 03:48:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 03:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404643.647202 (Exim 4.92) (envelope-from ) id 1oWrTz-0002Ds-OT; Sat, 10 Sep 2022 03:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404643.647202; Sat, 10 Sep 2022 03:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWrTz-0002Dl-KT; Sat, 10 Sep 2022 03:48:39 +0000 Received: by outflank-mailman (input) for mailman id 404643; Sat, 10 Sep 2022 03:48:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWrTy-0002Db-QP; Sat, 10 Sep 2022 03:48:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWrTy-0001fU-Ox; Sat, 10 Sep 2022 03:48:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWrTy-00045a-9K; Sat, 10 Sep 2022 03:48:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWrTy-0004aJ-8m; Sat, 10 Sep 2022 03:48:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vWhng990N1ngBXFBPXAruebQjCpDPqtEAZBckpX5TWc=; b=sfO2pa5gfCs8nIQlxi7IoU3pGU UJsmSyNjaoPEbgW3XDyDaummAqGy084zGQJJWTzwMcW2BtANAIkmHTVn9D7VXN4gdp+nr5ovpBHhu HUjTFhKKWaZvPppUWY8NALQ+1F6Y+3Pxcs7udKl8LdwQsuDfdkOHsIOIFs2ewi5k7VaY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173105: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 03:48:38 +0000 flight 173105 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173105/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 279 attempts Testing same since 173081 2022-09-09 03:19:40 Z 1 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 04:32:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 04:32:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404653.647216 (Exim 4.92) (envelope-from ) id 1oWsAX-0008UR-41; Sat, 10 Sep 2022 04:32:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404653.647216; Sat, 10 Sep 2022 04:32:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWsAW-0008UK-W1; Sat, 10 Sep 2022 04:32:36 +0000 Received: by outflank-mailman (input) for mailman id 404653; Sat, 10 Sep 2022 04:32:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWsAV-0008UE-KN for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 04:32:35 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96aafc08-30c1-11ed-a31c-8f8a9ae3403f; Sat, 10 Sep 2022 06:32:33 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CBC1122788; Sat, 10 Sep 2022 04:32:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E174133B7; Sat, 10 Sep 2022 04:32:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rCZRIWATHGOgRQAAMHmgww (envelope-from ); Sat, 10 Sep 2022 04:32:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96aafc08-30c1-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662784352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wmu5TuTQuFgZ9n+X2iSXvYVVuycazGCWPVsz4mGNJqY=; b=HXjQbKsHhQ4rbu+d3AkNHr10NgTIYeGImb3ltNxpGvVGdJ6799P0hP7f5/zvpPYOHcSxb0 1rUIykIvwuiaOXlyqpLf8xrAWEWZ3x6C9tIrP10+LQrYX3Ir5GfL9j+MpNfDb7x9EkOb3a J3SmdKIV6B54kT1M7R88Y6z5h6f5elU= Message-ID: <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> Date: Sat, 10 Sep 2022 06:32:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: Linux pin_user_pages_fast fails on Xen Content-Language: en-US To: Stefano Stabellini Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, JESHWANTHKUMAR.NK@amd.com, Devaraj.Rangasamy@amd.com, Mythri.Pandeshwarakrishna@amd.com, SivaSangeetha.SK@amd.com, Rijo-john.Thomas@amd.com References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------cxyZwa0kxLiD11n73B49tcjJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------cxyZwa0kxLiD11n73B49tcjJ Content-Type: multipart/mixed; boundary="------------QuWShdp0uLCnMsTW24i0CAVC"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, JESHWANTHKUMAR.NK@amd.com, Devaraj.Rangasamy@amd.com, Mythri.Pandeshwarakrishna@amd.com, SivaSangeetha.SK@amd.com, Rijo-john.Thomas@amd.com Message-ID: <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> Subject: Re: Linux pin_user_pages_fast fails on Xen References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> In-Reply-To: --------------QuWShdp0uLCnMsTW24i0CAVC Content-Type: multipart/mixed; boundary="------------67TaJGPtP0swgRswPKXriKVi" --------------67TaJGPtP0swgRswPKXriKVi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDkuMjIgMjI6MjUsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gRnJp LCA5IFNlcCAyMDIyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDkuMDkuMjIgMDQ6 MTEsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+PiBBZGRpbmcgbW9yZSBwZW9wbGUg aW4gQ0MNCj4+Pg0KPj4+IE9uIFRodSwgOCBTZXAgMjAyMiwgU3RlZmFubyBTdGFiZWxsaW5p IHdyb3RlOg0KPj4+PiBIaSBKdWVyZ2VuLA0KPj4+Pg0KPj4+PiBBIGNvbGxlYWd1ZSBpcyBz ZWVpbmcgYSBmYWlsdXJlIG9uIHg4NiBpbiBMaW51eCBEb20wLiBUaGUgZmFpbHVyZSBpcw0K Pj4+PiBwaW5fdXNlcl9wYWdlc19mYXN0IHdpdGggYWRkcmVzc2VzIHRoYXQgY29ycmVzcG9u ZCB0byBmb3JlaWduIG1lbW9yeQ0KPj4+PiBwYWdlczoNCj4+Pj4NCj4+Pj4gLSBRRU1VIG1h cHMgYSBkb21VIGFkZHJlc3MgdXNpbmcgZG1hX21lbW9yeV9tYXAgKHhlbl9tYXBfY2FjaGUp DQo+Pj4+IC0gUUVNVSBjYWxscyBhbiBJT0NUTCB0byB0aGUgVEVFIHN1YnN5c3RlbSB3aXRo IHRoZSBWaXJ0dWFsIEFkZHJlc3MNCj4+Pj4gICAgIHJldHVybmVkIGJ5IGRtYV9tZW1vcnlf bWFwDQo+Pj4+IC0gTGludXggdGVlX3NobV9yZWdpc3Rlci0+cGluX3VzZXJfcGFnZXNfZmFz dCBSZXR1cm5zIC0xNCAtDQo+Pj4+IGRyaXZlcnMvdGVlL3RlZV9zaG0uYw0KPj4+Pg0KPj4+ PiBPbmNlIHVwb24gYSB0aW1lIGl0IHVzZWQgdG8gYmUgdGhlIGNhc2UgdGhhdCBnZXRfdXNl cl9wYWdlc19mYXN0IHdvdWxkDQo+Pj4+IGZhaWwgb24gWGVuIGJlY2F1c2Ugd2UgZGlkbid0 IGhhdmUgYSBzdHJ1Y3QgcGFnZSBjb3JyZXNwb25kaW5nIHRvDQo+Pj4+IGZvcmVpZ24gbWVt b3J5IG1hcHBpbmdzLiBCdXQgdGhhdCBoYXNuJ3QgYmVlbiB0aGUgY2FzZSBmb3IgeWVhcnMg bm93Lg0KPj4+Pg0KPj4+PiBBbnkgb3RoZXIgaWRlYXMgd2h5IGl0IHdvdWxkIGZhaWw/DQo+ Pg0KPj4gSSB0aGluayB3ZSBjYW4gZXhwZWN0IHRoYXQgYWNjZXNzX29rKCkgaXNuJ3QgZmFp bGluZy4NCj4+DQo+PiBJIGFzc3VtZSB0aGUgbWFwcGluZyB3YXMgZG9uZSBhbGxvd2luZyB3 cml0ZXMgKHNvcnJ5IGZvciBwYXJhbm9pYSBtb2RlKT8NCj4gICANCj4gSSB3YXMgdG9sZCBp dCB3YXMgdmVyaWZpZWQ6IFFFTVUgY291bGQgcmVhZCBhbmQgd3JpdGUgdG8gdGhlIFZBIHJl dHVybmVkDQo+IGJ5IGRtYV9tZW1vcnlfbWFwLiBGcm9tIC9wcm9jLzxxZW11LXBpZD4vbWFw cywgdGhlIFZBIGFzc2lnbmVkIGFmdGVyIHRoZQ0KPiBtYXBwaW5nIGlzIHBvaW50aW5nIHRv IC9kZXYveGVuL3ByaXZjbWQuDQo+IA0KPiANCj4+IE90aGVyIHRoYW4gdGhhdCBJJ20gbm90 IGhhdmluZyBlbm91Z2ggbWVtb3J5IG1hbmFnZW1lbnQgc2tpbGxzLiBJdCBtaWdodCBiZQ0K Pj4gcmVsYXRlZCB0byBtbWFwKCktZWQgZm9yZWlnbiBwYWdlcyBoYXZpbmcgX1BBR0VfU1BF Q0lBTCBzZXQsIHRob3VnaC4NCj4gDQo+IERvIHdlIHN0aWxsIHNldCBQQUdFX1NQRUNJQUwg Zm9yIGZvcmVpZ24gbWFwcGVkIHBhZ2VzPyBJdCBsb29rcyBsaWtlIGl0DQo+IGlzIG5vdCB0 aGVyZSBhbnltb3JlPyBJZiBQQUdFX1NQRUNJQUwgaXMgbm90IHRoZXJlLCB0aGVuIHRoZXkg cmVhbGx5DQo+IHNob3VsZCBsb29rIGxpa2UgcmVndWxhciBwYWdlcz8NCg0KU2VlIHRoZSBj YWxsIG9mIHB0ZV9ta3NwZWNpYWwoKSBpbiByZW1hcF9hcmVhX3Bmbl9wdGVfZm4oKSAobW11 X3B2LmMpLg0KDQoNCkp1ZXJnZW4NCg== --------------67TaJGPtP0swgRswPKXriKVi Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------67TaJGPtP0swgRswPKXriKVi-- --------------QuWShdp0uLCnMsTW24i0CAVC-- --------------cxyZwa0kxLiD11n73B49tcjJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMcE2AFAwAAAAAACgkQsN6d1ii/Ey8n cAgAmCvjodBMa4eQr+1J2FIngIC1uhX29hrN4OBktSrNWHN2Jkg29dh2/J4PwA/N/5HJ7YERC1oJ 4ByTU/S9QYF4o1ZokG7b11Mi0ughKNqKQXde/WY79aHM+mRNGeUcfhRLvLrmeM4VTgJmKgPiDghi bem0vwxYq43HUG7FLC7kW2bCOZSWmd6Jp+sfg35KFigucO1h6dv8HHk+49deS0zkVQcoNzwUVgLE n690hUkKldfqNxJRB3iFmQhj4OaTSxll18HrZ6TBuEu8p/WBY09k8P/gNSQ6GZLRRMWeZa1xe8a7 DkxKqQsoxqAX7fEYTXkTQrNDCBQ1W0LCHoH6br6lgw== =IkZR -----END PGP SIGNATURE----- --------------cxyZwa0kxLiD11n73B49tcjJ-- From xen-devel-bounces@lists.xenproject.org Sat Sep 10 05:22:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 05:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404660.647227 (Exim 4.92) (envelope-from ) id 1oWswE-0006WE-ON; Sat, 10 Sep 2022 05:21:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404660.647227; Sat, 10 Sep 2022 05:21:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWswE-0006W7-Lg; Sat, 10 Sep 2022 05:21:54 +0000 Received: by outflank-mailman (input) for mailman id 404660; Sat, 10 Sep 2022 05:21:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWswC-0006Vw-UG; Sat, 10 Sep 2022 05:21:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWswC-0003mo-SO; Sat, 10 Sep 2022 05:21:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWswC-00004s-Ks; Sat, 10 Sep 2022 05:21:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWswC-0005eI-K4; Sat, 10 Sep 2022 05:21:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9SKvr4WI5DEIvzbdtpCXqt4iOTRDccKZyRLuV3qtf/g=; b=CVyJgLsg3F6LfPnU2l31vHZGSb f4yDHJfp1IFuszdcUTpWUOS4I3kaj0xAoAQE2NAT+MrEn/RA5glfaG6LfrXGhG7MKjXnmGh4PnjaW 5hdoJe3DDQ3lkk8DY3WBR6L+nzqpBlGB/hz71QtnjCHSUkV3YF0jmymKZXQeqBrA0zfk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173103: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c X-Osstest-Versions-That: xen=9066d877bf57a47b0f09741dac996ee1055d6407 From: osstest service owner Date: Sat, 10 Sep 2022 05:21:52 +0000 flight 173103 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173103/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173090 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c baseline version: xen 9066d877bf57a47b0f09741dac996ee1055d6407 Last test of basis 173090 2022-09-09 10:01:57 Z 0 days Failing since 173096 2022-09-09 17:03:34 Z 0 days 2 attempts Testing same since 173103 2022-09-10 01:03:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Jan Beulich Juergen Gross Julien Grall Penny Zheng Rahul Singh Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9066d877bf..942ac5fc15 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c -> smoke From xen-devel-bounces@lists.xenproject.org Sat Sep 10 06:42:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 06:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404669.647238 (Exim 4.92) (envelope-from ) id 1oWuBa-0007cM-KB; Sat, 10 Sep 2022 06:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404669.647238; Sat, 10 Sep 2022 06:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWuBa-0007cF-GD; Sat, 10 Sep 2022 06:41:50 +0000 Received: by outflank-mailman (input) for mailman id 404669; Sat, 10 Sep 2022 06:41:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWuBZ-0007c5-S7; Sat, 10 Sep 2022 06:41:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWuBZ-0005Df-QO; Sat, 10 Sep 2022 06:41:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWuBZ-0006Gu-ET; Sat, 10 Sep 2022 06:41:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWuBZ-0002qq-E3; Sat, 10 Sep 2022 06:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1ZWhMHzpFEwXsZtFBvBormhCTqooXTNsHlK9p4Mxe/Y=; b=1s+CBbLRjBvCmyI4pNBj2vucjR WFDqXzIvXkMMXGYRorBS6RBFTvxpAtNEV7/LgkOtxDV3GS4M//OIJEL0nP6YfgMwEOJ59matc5mc9 77HC/TY7Rv6fQ255gGiZc2PXbjQ77J8DZ9cstRhlTvuODQ3HpJbX6ci7JEW38mWmCRyc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173107: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 06:41:49 +0000 flight 173107 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173107/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 36 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 280 attempts Testing same since 173081 2022-09-09 03:19:40 Z 1 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 09:10:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 09:10:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404688.647249 (Exim 4.92) (envelope-from ) id 1oWwUt-0007v9-No; Sat, 10 Sep 2022 09:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404688.647249; Sat, 10 Sep 2022 09:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWwUt-0007v2-Kc; Sat, 10 Sep 2022 09:09:55 +0000 Received: by outflank-mailman (input) for mailman id 404688; Sat, 10 Sep 2022 09:09:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWwUs-0007us-F9; Sat, 10 Sep 2022 09:09:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWwUs-0008H7-AH; Sat, 10 Sep 2022 09:09:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWwUr-0007WX-Pb; Sat, 10 Sep 2022 09:09:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWwUr-0007Bs-PA; Sat, 10 Sep 2022 09:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+x82kP6dH3qqPZYT1+7QDJLFhHIKaewcAiDRZWWRGt0=; b=MWWK6GH11uKz/w4ofKYcusBRZR Mx8EX9XXucO0SmoK7cmFElfuHIvxPoYHGLLVDqKrRYUa4I04uf662D0NtBjueIldBQHEOnKBje7MV CY7/kd7u4jzpzfMy/8IaL4uDOlZFeccWdlZirYfxxdIK6a3suwMauTU+LpC5gyBGZS0U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173097: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sat, 10 Sep 2022 09:09:53 +0000 flight 173097 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173097/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken in 173080 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 5 host-install(5) broken in 173080 pass in 173097 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 173080 pass in 173097 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail pass in 173080 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173080 like 172108 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173080 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173080 never pass test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 37 days Failing since 172384 2022-08-11 11:13:58 Z 29 days 63 attempts Testing same since 173008 2022-09-05 15:47:43 Z 4 days 9 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 09:53:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 09:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404697.647259 (Exim 4.92) (envelope-from ) id 1oWxAa-0005LR-0H; Sat, 10 Sep 2022 09:53:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404697.647259; Sat, 10 Sep 2022 09:52:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWxAZ-0005LK-Tc; Sat, 10 Sep 2022 09:52:59 +0000 Received: by outflank-mailman (input) for mailman id 404697; Sat, 10 Sep 2022 09:52:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWxAZ-0005LA-86; Sat, 10 Sep 2022 09:52:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWxAZ-0000Xr-5P; Sat, 10 Sep 2022 09:52:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWxAY-0001NK-NM; Sat, 10 Sep 2022 09:52:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWxAY-0006D1-Mx; Sat, 10 Sep 2022 09:52:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wjzhxIvwYczM9LgyxjLh1TeACGQqxo0Q3QinPFLUBzM=; b=YHJwhddnx4K8FdnNqrs5CVB2lP j6AwCjZXraZPmaiAajXB8eXHJ6uyKZLfMz3XXpmoFbmqXey/+4eOKSbfjIBJ37DbKGeG0z5grytup S/xX4pze8KNP1FECxm+oonoHn28+I3mYXE5jyiLagSHEBuBkKCPvGsWLKwf9W84/GSII=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173110: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 09:52:58 +0000 flight 173110 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173110/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf cdb80a281fa3fd3457faf1dc65d5a443e8d512d3 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 281 attempts Testing same since 173081 2022-09-09 03:19:40 Z 1 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2401 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 11:24:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 11:24:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404706.647271 (Exim 4.92) (envelope-from ) id 1oWyah-0008M4-JI; Sat, 10 Sep 2022 11:24:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404706.647271; Sat, 10 Sep 2022 11:24:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWyah-0008Lx-Gc; Sat, 10 Sep 2022 11:24:03 +0000 Received: by outflank-mailman (input) for mailman id 404706; Sat, 10 Sep 2022 11:24:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWyag-0008Ln-Ui; Sat, 10 Sep 2022 11:24:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWyag-0002B2-PB; Sat, 10 Sep 2022 11:24:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWyag-0006jt-4o; Sat, 10 Sep 2022 11:24:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oWyag-0002hv-4L; Sat, 10 Sep 2022 11:24:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/akCT5rzFsomgrKidfAn2AmNSmaaYnCsjWM3QKI2+Mo=; b=qV4z9baNITUgZyzds6hTFNqyOW j2eOjl+Sw/nRLxbCrd0ADd+OfnYmwu4PniXKGIklHa6wk5juDc5z+a5ZbQzHPrSsGgtIH+H2afAV/ 7MJnb8LZFNvnnS4GcmmWbCqdNO9+rJH/4dbJDiUvzODv9vZ2+u6xL9Ogkf7QW2VIbzxY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173101: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 10 Sep 2022 11:24:02 +0000 flight 173101 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173101/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 37 days Failing since 172148 2022-08-04 21:39:38 Z 36 days 82 attempts Testing same since 173060 2022-09-08 07:34:59 Z 2 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 12:55:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 12:55:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404719.647282 (Exim 4.92) (envelope-from ) id 1oX00p-0002l8-Fk; Sat, 10 Sep 2022 12:55:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404719.647282; Sat, 10 Sep 2022 12:55:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX00p-0002l1-Cl; Sat, 10 Sep 2022 12:55:07 +0000 Received: by outflank-mailman (input) for mailman id 404719; Sat, 10 Sep 2022 12:55:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX00o-0002kr-E4; Sat, 10 Sep 2022 12:55:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX00o-0003jU-Am; Sat, 10 Sep 2022 12:55:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX00n-0004IU-U4; Sat, 10 Sep 2022 12:55:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX00n-0002pf-Tc; Sat, 10 Sep 2022 12:55:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sFLWqTLGPWA7jr1WfJ1HjLFKXJLLSCxy+1+OLuR+jwE=; b=6qtA4wXupVWXX7KRGO+g6iQE72 lPP/fg+XXCkZF6flP+Jv4ZAMsTJXQ4P6IchdjFSl4usmPez+bpn00KXWXat17Kh5MseCqAk+G77Sj +SYn8HBCGLiprto01IJmFE8s6OC5FDeV94oFlSkzCYQtiWKRxU6XsIK92oAmTCYeC9Ek=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173112: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 12:55:05 +0000 flight 173112 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173112/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 282 attempts Testing same since 173112 2022-09-10 10:12:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 13:27:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 13:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404729.647293 (Exim 4.92) (envelope-from ) id 1oX0W2-0006ud-1w; Sat, 10 Sep 2022 13:27:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404729.647293; Sat, 10 Sep 2022 13:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0W1-0006uW-Ts; Sat, 10 Sep 2022 13:27:21 +0000 Received: by outflank-mailman (input) for mailman id 404729; Sat, 10 Sep 2022 13:27:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0W0-0006uM-57; Sat, 10 Sep 2022 13:27:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0W0-0004Jn-1d; Sat, 10 Sep 2022 13:27:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0Vy-0007Db-PM; Sat, 10 Sep 2022 13:27:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX0Vy-00064L-Oq; Sat, 10 Sep 2022 13:27:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NVLWzOTxMiYTIgVnEw/Li3IJEKMQWQYb+Qn3eXyiw28=; b=bl3o9PGE84ivICWqK/7w5TvciD X8quHyl0S/Wnr94dpuOMsWsTychUH6ppMQjRCq74Zdixy4lTCowZolcMLhF9j1W9Uy6Kjp5ixVeeq 9JBoMxmAd8lWsVl80dgUVulxpztRAZjd2ihwzvSiqrJE04+JN5/kx6WMfmYKDterx9so=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173104: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ce888220d5c7a805e0e155302a318d5d23e62950 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 10 Sep 2022 13:27:18 +0000 flight 173104 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173104/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ce888220d5c7a805e0e155302a318d5d23e62950 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 37 days Failing since 172152 2022-08-05 04:01:26 Z 36 days 82 attempts Testing same since 173104 2022-09-10 01:12:11 Z 0 days 1 attempts ------------------------------------------------------------ 1761 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181191 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 13:40:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 13:40:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404738.647303 (Exim 4.92) (envelope-from ) id 1oX0ia-0001O0-4s; Sat, 10 Sep 2022 13:40:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404738.647303; Sat, 10 Sep 2022 13:40:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0ia-0001Nt-1s; Sat, 10 Sep 2022 13:40:20 +0000 Received: by outflank-mailman (input) for mailman id 404738; Sat, 10 Sep 2022 13:40:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0iY-0001Nd-Ld; Sat, 10 Sep 2022 13:40:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0iY-0004XL-Hy; Sat, 10 Sep 2022 13:40:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX0iY-00087S-4v; Sat, 10 Sep 2022 13:40:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX0iY-0003Ci-4Q; Sat, 10 Sep 2022 13:40:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YsZIqmvJKg/sgxBcWOMRnPHLYpu2CgnjYidBnyM0j8w=; b=gdY9/YBtrIGwSJ1JofP37nm+ww X21tOmCU2klm+wUNEOAiyuDeruO0nubmQ39f3JEh8Ld35Wwz5g7LWuZxG5YjmF/2FIMPu9UYFHknw WxLclt2EaMj6qMjmH8wxihyz/OBdmnx86ZgEuh7Su2jAtL3lexqx40nnTGYfwcp0nDc0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173106: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:allowable xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9066d877bf57a47b0f09741dac996ee1055d6407 X-Osstest-Versions-That: xen=36e3f41587788c60813b088b373960b7fb88c021 From: osstest service owner Date: Sat, 10 Sep 2022 13:40:18 +0000 flight 173106 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173106/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 173093 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173093 build-i386-libvirt 6 libvirt-build fail like 173093 build-arm64-libvirt 6 libvirt-build fail like 173093 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173093 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173093 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173093 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173093 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173093 build-armhf-libvirt 6 libvirt-build fail like 173093 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173093 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173093 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173093 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173093 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 9066d877bf57a47b0f09741dac996ee1055d6407 baseline version: xen 36e3f41587788c60813b088b373960b7fb88c021 Last test of basis 173093 2022-09-09 12:13:58 Z 1 days Testing same since 173106 2022-09-10 03:15:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 36e3f41587..9066d877bf 9066d877bf57a47b0f09741dac996ee1055d6407 -> master From xen-devel-bounces@lists.xenproject.org Sat Sep 10 14:01:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 14:01:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404751.647320 (Exim 4.92) (envelope-from ) id 1oX13A-0004YJ-0w; Sat, 10 Sep 2022 14:01:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404751.647320; Sat, 10 Sep 2022 14:01:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX139-0004YC-Sl; Sat, 10 Sep 2022 14:01:35 +0000 Received: by outflank-mailman (input) for mailman id 404751; Sat, 10 Sep 2022 14:01:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX138-0004Y6-EQ for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 14:01:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX137-0004zt-SM; Sat, 10 Sep 2022 14:01:33 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oX137-0003ny-Lf; Sat, 10 Sep 2022 14:01:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=5ZEoyji53cRCV76JF0zz9cdIdNOD3S6Xipmze9D463w=; b=42aPZBcvm5K5x6UJ+PXmrYota8 kuSnq3ZCAY4fZ+p/PHZ1sDakxeZuuyWxq10Y62f2XMvqFjV19sIMCfZcWvF6EHGY1s2PnKZTu7jZI IOH3hPfCmrlTHUBlkHE06y5nmxaxD5E8ThnUTAKRwpzF8HIMk+2dPWEXT9lDR8Ge8UQo=; Message-ID: Date: Sat, 10 Sep 2022 15:01:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-9-carlo.nonato@minervasys.tech> From: Julien Grall Subject: Re: [PATCH 08/12] Revert "xen/arm: setup: Add Xen as boot module before printing all boot modules" In-Reply-To: <20220826125111.152261-9-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 26/08/2022 13:51, Carlo Nonato wrote: > From: Luca Miccio > > This reverts commit 48fb2a9deba11ee48dde21c5c1aa93b4d4e1043b. > > The cache coloring support has the command line parsing as a prerequisite > because of the color configurations passed in this way. Also, the Xen boot > module will be placed at an address that depends on the coloring > initialization. This commit moves the Xen boot module after the coloring > initialization to allow the order of operations previously described to > take place. The commit you revert was created in order to print the position of Xen on the console. So while I understand your aim, you are (temporarily?) not printing Xen address anymore. Therefore your commit message, should contain some words explaining why this is fine and how this problem will be addressed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Sep 10 14:29:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 14:29:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404759.647330 (Exim 4.92) (envelope-from ) id 1oX1Tk-0007kt-4F; Sat, 10 Sep 2022 14:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404759.647330; Sat, 10 Sep 2022 14:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1Tk-0007km-0s; Sat, 10 Sep 2022 14:29:04 +0000 Received: by outflank-mailman (input) for mailman id 404759; Sat, 10 Sep 2022 14:29:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1Ti-0007kf-Oo for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 14:29:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1Ti-0005Ra-32; Sat, 10 Sep 2022 14:29:02 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oX1Th-0004vk-Oo; Sat, 10 Sep 2022 14:29:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=7C1oIQuZovOjAI+3YoXfrCNWAmhV1q+wkSxNOLTtroI=; b=Bio2lkXbnT1e7+7BMeHKOFhUN9 U1zm8jCI24UvoY+ZxTqAn1y1STuSWq1lxLct96MDD8ji4S+CqYpLgGiKel/EGc5u3ajLbSpYCrcap e0B568+wK9TPve7UyJA+ypaPg6EYHNHbvIq4ou6OcCLs+sm83eNIqBUymJxFoUmYYvFQ=; Message-ID: Date: Sat, 10 Sep 2022 15:28:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-10-carlo.nonato@minervasys.tech> From: Julien Grall Subject: Re: [PATCH 09/12] Revert "xen/arm: mm: Initialize page-tables earlier" In-Reply-To: <20220826125111.152261-10-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Carlo, On 26/08/2022 13:51, Carlo Nonato wrote: > From: Luca Miccio > > This reverts commit 3a5d341681af650825bbe3bee9be5d187da35080. Usually, this indicates that this was a clean revert. IOW, there was no clash or modification necessary. Looking at the diff below, this doesn't look to be the case because you are also reverting f8c818848fa6 "xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen()" and introduce a new version of create_boot_mappings(). So I think the commit message/title should be reworded to explain this is not a clean revert and what extra changes were made. But see below about re-introducing create_boot_mapping(). > > The cache coloring support will be configurable within the Xen command line, > but it will be initialized before the page-tables; this is necessary > for coloring the hypervisor itself beacuse we will create a specific > mapping for it that could be configured using some command line options. > In order to parse all the needed information from the device tree, we > need to revert the above commit and restore the previous order for > page-tables initialization. > > Signed-off-by: Carlo Nonato > Signed-off-by: Marco Solieri > --- > xen/arch/arm/mm.c | 33 ++++++++++++++++++++------------- > xen/arch/arm/setup.c | 4 ++-- > 2 files changed, 22 insertions(+), 15 deletions(-) > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index b42cddb1b4..1afa02b4af 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -368,6 +368,17 @@ static inline lpae_t pte_of_xenaddr(vaddr_t va) > return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); > } > > +static void __init create_boot_mappings(unsigned long virt_offset, > + mfn_t base_mfn) > +{ > + lpae_t pte; > + > + pte = mfn_to_xen_entry(base_mfn, MT_NORMAL); > + write_pte(&boot_second[second_table_offset(virt_offset)], pte); > + flush_xen_tlb_local(); > +} Please don't introduce a new function that create mappings. All mappings should be done using map_pages_to_xen(). Looking at the implementation, it should be usable with the following diff: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index c81c706c8b23..78afb8eb0ec1 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1104,7 +1104,7 @@ static int xen_pt_update(unsigned long virt, * * XXX: Add a check. */ - const mfn_t root = virt_to_mfn(THIS_CPU_PGTABLE); + const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); /* * The hardware was configured to forbid mapping both writeable and With that there is no change required in early_fdt_map() and ... > > + /* ... DTB */ > + pte = boot_second[second_table_offset(BOOT_FDT_VIRT_START)]; > + xen_second[second_table_offset(BOOT_FDT_VIRT_START)] = pte; > + pte = boot_second[second_table_offset(BOOT_FDT_VIRT_START + SZ_2M)]; > + xen_second[second_table_offset(BOOT_FDT_VIRT_START + SZ_2M)] = pte; > + ... rather than copying the 2 entries, you could call early_fdt_map() after the switch. The advantage is it will avoid to hardoded more page-table entries. As part of my switch_ttbr() rework, I am planning to re-introduce relocation (at least for testing). So I will include the changes I mention above in my series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Sep 10 14:43:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 14:43:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404766.647341 (Exim 4.92) (envelope-from ) id 1oX1hv-0001qf-CN; Sat, 10 Sep 2022 14:43:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404766.647341; Sat, 10 Sep 2022 14:43:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1hv-0001qY-9n; Sat, 10 Sep 2022 14:43:43 +0000 Received: by outflank-mailman (input) for mailman id 404766; Sat, 10 Sep 2022 14:43:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1hu-0001qO-IU; Sat, 10 Sep 2022 14:43:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1hu-0005g7-Dm; Sat, 10 Sep 2022 14:43:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX1hu-0002fj-23; Sat, 10 Sep 2022 14:43:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX1hu-00061u-1f; Sat, 10 Sep 2022 14:43:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Wfn4D578SwGbnR8WEelPjnNt1hKJjteQEZlt22d/C7s=; b=6lnOIYoaNPREgFRNgbt4PUkfb1 JVEfzLidaTwJIfQlMf34xLP/CKcovqlm2LMERrmNJJCW9N5511nrn0xhp1QmXaj03Kv64qcfyY28r CmTFlIpGYswiueUFpCoMNhffdKyDRUkR7W5ZZcYRYayJUNQx7m0YCODxXwQUzzbr1kxY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173109: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b48469fcdb42cea237578e000cfb82b13f05b0ff X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 10 Sep 2022 14:43:42 +0000 flight 173109 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173109/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt b48469fcdb42cea237578e000cfb82b13f05b0ff baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 792 days Failing since 151818 2020-07-11 04:18:52 Z 791 days 773 attempts Testing same since 173109 2022-09-10 04:19:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122707 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:12:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:12:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404775.647351 (Exim 4.92) (envelope-from ) id 1oX29b-0005ya-L3; Sat, 10 Sep 2022 15:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404775.647351; Sat, 10 Sep 2022 15:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX29b-0005yT-IQ; Sat, 10 Sep 2022 15:12:19 +0000 Received: by outflank-mailman (input) for mailman id 404775; Sat, 10 Sep 2022 15:12:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX29a-0005yN-9I for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:12:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX29Z-0006Bk-LX; Sat, 10 Sep 2022 15:12:17 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oX29Z-0007CG-Ey; Sat, 10 Sep 2022 15:12:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=coysem2E7p4X/oqTQYB6UNY9yBkvc9J+W5qwCElr7vw=; b=YuQr+p1n7Wae/Hr6zrYD0GCGMX eV6chw/QqAedWj2/ESaZPSyx+8y9E8VJIVMTvcNM5FbK3oTJJMls9RzPMYun/TkmEegmiq8Azu5si iVGGxP4A6OiAxWZ711Z9kea9HFF+9wwclQ6MdMEYpYSwvoWpdIiJZJzc5VbfQZww3JZc=; Message-ID: Date: Sat, 10 Sep 2022 16:12:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 00/12] Arm cache coloring To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> From: Julien Grall In-Reply-To: <20220826125111.152261-1-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Carlo, On 26/08/2022 13:50, Carlo Nonato wrote: > Shared caches in multi-core CPU architectures represent a problem for > predictability of memory access latency. This jeopardizes applicability > of many Arm platform in real-time critical and mixed-criticality > scenarios. We introduce support for cache partitioning with page > coloring, a transparent software technique that enables isolation > between domains and Xen, and thus avoids cache interference. > > When creating a domain, a simple syntax (e.g. `0-3` or `4-11`) allows > the user to define assignments of cache partitions ids, called colors, > where assigning different colors guarantees no mutual eviction on cache > will ever happen. This instructs the Xen memory allocator to provide > the i-th color assignee only with pages that maps to color i, i.e. that > are indexed in the i-th cache partition. > > The proposed implementation supports the dom0less feature. > The solution has been tested in several scenarios, including Xilinx Zynq > MPSoCs. > > Overview of implementation and commits structure > ------------------------------------------------ > > - [1-3] Coloring initialization, cache layout auto-probing and coloring > data for domains are added. > - [4-5] xl and Device Tree support for coloring is addedd. > - [6-7] A new page allocator for domain memory that implement the cache > coloring mechanism is introduced. > - [8-12] Coloring support is added for Xen .text region. > > Changes in v2 > ------------- > > Lot of things changed between the two versions, mainly I tried to follow > all the comments left by the maintainers after the previous version review. > Here is a brief list of the major points (even if, imho, it's easier to > repeat all the review process): The series doesn't build on Arm64 without cache coloring. Please make sure to compile and check that Xen still boot on system after your series with cache coloring disabled. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:13:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404784.647362 (Exim 4.92) (envelope-from ) id 1oX2AO-0006aP-2b; Sat, 10 Sep 2022 15:13:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404784.647362; Sat, 10 Sep 2022 15:13:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2AN-0006aI-W7; Sat, 10 Sep 2022 15:13:07 +0000 Received: by outflank-mailman (input) for mailman id 404784; Sat, 10 Sep 2022 15:13:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2AM-0006a2-Cr; Sat, 10 Sep 2022 15:13:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2AM-0006Cm-Bv; Sat, 10 Sep 2022 15:13:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2AL-00055c-Vj; Sat, 10 Sep 2022 15:13:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX2AL-0007U6-VG; Sat, 10 Sep 2022 15:13:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OrPUK5ajKR5vOQ7m8Aza8XDhtON/lOEazMaPR0JeC8U=; b=OEQo7udsx3VHh78mBwpO3ouwVQ LjR232dW/P1Fy4T//yJKwCU4BKEwD/iWks1UHhvXO87gJLiZ79qxScjeLTRZAOBbE+467uJ6k1/eh le2jTgyjH5rNDjOngxa7goi5lGy8/rYtS5GeKKZj4eLmV342IBtycy81gGIad1ujFZzU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173114: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 15:13:05 +0000 flight 173114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173114/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 173112 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 283 attempts Testing same since 173112 2022-09-10 10:12:05 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:23:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404793.647374 (Exim 4.92) (envelope-from ) id 1oX2Jz-0008J8-0w; Sat, 10 Sep 2022 15:23:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404793.647374; Sat, 10 Sep 2022 15:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2Jy-0008J1-TY; Sat, 10 Sep 2022 15:23:02 +0000 Received: by outflank-mailman (input) for mailman id 404793; Sat, 10 Sep 2022 15:23:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2Jw-0008Iv-Oa for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:23:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2Jw-0006Ma-4Y; Sat, 10 Sep 2022 15:23:00 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oX2Jv-0007Zj-Tm; Sat, 10 Sep 2022 15:23:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=gE/tP7ZMeZSMeGvobUJNeq3RobqPPKEvaZONzf2lMGY=; b=cLmgkz9IVHYCI3zjs8B8t3fg05 la/HLcTHHWIPgRQ7frl1lmcAbPKkNIRfO52qpitE+uJx+uvToJ9YZjhfkn/BuHuS0WUhKBGhNLruk JM+eWmHl7qb+etgmtMfUzQMfFUcRvot9Y2mOUbq0IcpXUuzdjZniP/oZBcDCpETcKvus=; Message-ID: <0adb27f2-dee8-310a-eea7-bdc31bfa40ca@xen.org> Date: Sat, 10 Sep 2022 16:22:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> From: Julien Grall Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen In-Reply-To: <20220826125111.152261-13-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Carlo, I haven't fully reviewed the patch yet. Just point out a couple of things I noticed while looking how you dealt with the relocation (I need some code to test my series :)). On 26/08/2022 13:51, Carlo Nonato wrote: > -#ifdef CONFIG_ARM_64 > +#ifdef CONFIG_CACHE_COLORING > + /* Copy Xen to the new location */ > + memcpy((void *)BOOT_RELOC_VIRT_START, (const void *)XEN_VIRT_START, > + (_end - _start)); If I am not mistaken, at this point, Xen will still be using the stack that is part of Xen binary (see cpu0_boot_stack). However, until the point switch_ttbr() is called the stack can still be used. In particular... > + clean_dcache_va_range((void *)BOOT_RELOC_VIRT_START, (_end - _start)); > + > + ttbr = virt_to_maddr_colored((vaddr_t)xen_pgtable); > +#elif CONFIG_ARM_64 > ttbr = (uintptr_t) xen_pgtable + phys_offset; > #else > ttbr = (uintptr_t) cpu0_pgtable + phys_offset; > @@ -530,6 +610,18 @@ void __init setup_pagetables(unsigned long boot_phys_offset) > ... the compiler may need to save some information on the stack. And then... > switch_ttbr(ttbr); ... restore it after switch_ttbr(). Xen will be using a different stack (same virtual address but different physical address) so the wrong value will be loaded. I am not aware of any guaranteed from the AAPCS{32, 64} that this can point (please provide a pointer if I am wrong). So I think we either want to copy the new Xen to the correct position in the assembly. This means we would want to revive partially f60658c6ae47 "xen/arm: Stop relocating Xen". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:23:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:23:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404800.647385 (Exim 4.92) (envelope-from ) id 1oX2KZ-0000Pp-8K; Sat, 10 Sep 2022 15:23:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404800.647385; Sat, 10 Sep 2022 15:23:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2KZ-0000Pi-5c; Sat, 10 Sep 2022 15:23:39 +0000 Received: by outflank-mailman (input) for mailman id 404800; Sat, 10 Sep 2022 15:23:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2KY-0000Oc-Bm for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:23:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2KX-0006NZ-FY; Sat, 10 Sep 2022 15:23:37 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oX2KX-0007aO-AJ; Sat, 10 Sep 2022 15:23:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=XFq1iLrR+55pgikNEV1cjpYYEeJOfG9uF25Z3klKTwY=; b=KPwfYcMOVp59XAIldTX2fde/vh EJq5fgJy0bFw+WRTuxTS7zpQR7eSdSbPywZoBn1Eey/aynC1ws6rJ/tvUprakn00EqSn5hxFbTYJU JH43ge1R75PQpU4pjmIaRYfWLFq5p3LG9CR28fCflRUuQhNALxyolQIN23KTiBqz8l38=; Message-ID: <698fa1df-6457-e560-3aab-9bd56978c4aa@xen.org> Date: Sat, 10 Sep 2022 16:23:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen From: Julien Grall To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> <0adb27f2-dee8-310a-eea7-bdc31bfa40ca@xen.org> In-Reply-To: <0adb27f2-dee8-310a-eea7-bdc31bfa40ca@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/09/2022 16:22, Julien Grall wrote: > Hi Carlo, > > I haven't fully reviewed the patch yet. Just point out a couple of > things I noticed while looking how you dealt with the relocation (I need > some code to test my series :)). > > On 26/08/2022 13:51, Carlo Nonato wrote: >> -#ifdef CONFIG_ARM_64 >> +#ifdef CONFIG_CACHE_COLORING >> +    /* Copy Xen to the new location */ >> +    memcpy((void *)BOOT_RELOC_VIRT_START, (const void *)XEN_VIRT_START, >> +           (_end - _start)); > > If I am not mistaken, at this point, Xen will still be using the stack > that is part of Xen binary (see cpu0_boot_stack). However, until the > point switch_ttbr() is called the stack can still be used. In particular... > >> +    clean_dcache_va_range((void *)BOOT_RELOC_VIRT_START, (_end - >> _start)); > + >> +    ttbr = virt_to_maddr_colored((vaddr_t)xen_pgtable); >> +#elif CONFIG_ARM_64 >>       ttbr = (uintptr_t) xen_pgtable + phys_offset; >>   #else >>       ttbr = (uintptr_t) cpu0_pgtable + phys_offset; >> @@ -530,6 +610,18 @@ void __init setup_pagetables(unsigned long >> boot_phys_offset) > > ... the compiler may need to save some information on the stack. And > then... > >>       switch_ttbr(ttbr); > > ... restore it after switch_ttbr(). Xen will be using a different stack > (same virtual address but different physical address) so the wrong value > will be loaded. > > I am not aware of any guaranteed from the AAPCS{32, 64} that this can > point (please provide a pointer if I am wrong). So I think we either s/point/not happen/ > want to copy the new Xen to the correct position in the assembly. > > This means we would want to revive partially f60658c6ae47 "xen/arm: Stop > relocating Xen". > > Cheers, > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:50:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:50:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404807.647396 (Exim 4.92) (envelope-from ) id 1oX2kB-0004c6-AB; Sat, 10 Sep 2022 15:50:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404807.647396; Sat, 10 Sep 2022 15:50:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kB-0004bz-6W; Sat, 10 Sep 2022 15:50:07 +0000 Received: by outflank-mailman (input) for mailman id 404807; Sat, 10 Sep 2022 15:50:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2k9-0004BJ-Sd for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:50:05 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ba19b87-3120-11ed-9760-273f2230c3a0; Sat, 10 Sep 2022 17:50:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 59B3B21B67; Sat, 10 Sep 2022 15:50:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA88A13441; Sat, 10 Sep 2022 15:50:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id huotMymyHGNQZAAAMHmgww (envelope-from ); Sat, 10 Sep 2022 15:50:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ba19b87-3120-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662825002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KvBcSJfTzw6ZlBSYvDzpGTuAHlQYr/2Q9gCeBjhjNFU=; b=a9Lx/Jn/nQKw+dBTWOaTD4U1zTAl9A1DBwroyPHCo87kHMYm8gCNgD7dkwAUhyuuOV0yDH cOmT4AcC18jYwqV9SwVBU7ZIxZcZamJXJRKzjsJAUOP2te6JeNOqLf96vv3pLhqH6dEsfb uBCfD5PeJxmYK7AXusnitYGYvi59W7o= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tamas K Lengyel , Lukasz Hawrylko , "Daniel P. Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Paul Durrant Subject: [RFC PATCH 0/3] xen/spinlock: make recursive spinlocks a dedicated type Date: Sat, 10 Sep 2022 17:49:56 +0200 Message-Id: <20220910154959.15971-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of being able to use normal spinlocks as recursive ones, too, make recursive spinlocks a special lock type. This will make the spinlock structure smaller in production builds and add type-safety. Juergen Gross (3): xen/spinlock: add explicit non-recursive locking functions xen/spinlock: split recursive spinlocks from normal ones xen/spinlock: support higher number of cpus xen/arch/arm/mm.c | 4 +-- xen/arch/x86/domain.c | 12 +++---- xen/arch/x86/include/asm/mm.h | 2 +- xen/arch/x86/mm.c | 12 +++---- xen/arch/x86/mm/mem_sharing.c | 8 ++--- xen/arch/x86/mm/mm-locks.h | 2 +- xen/arch/x86/mm/p2m-pod.c | 6 ++-- xen/arch/x86/mm/p2m.c | 4 +-- xen/arch/x86/numa.c | 4 +-- xen/arch/x86/tboot.c | 4 +-- xen/common/domain.c | 6 ++-- xen/common/domctl.c | 4 +-- xen/common/grant_table.c | 10 +++--- xen/common/ioreq.c | 2 +- xen/common/memory.c | 4 +-- xen/common/page_alloc.c | 18 +++++----- xen/common/spinlock.c | 22 +++++++----- xen/drivers/char/console.c | 24 ++++++------- xen/drivers/passthrough/pci.c | 4 +-- xen/include/xen/sched.h | 6 ++-- xen/include/xen/spinlock.h | 68 +++++++++++++++++++++++++---------- 21 files changed, 131 insertions(+), 95 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:50:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:50:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404808.647407 (Exim 4.92) (envelope-from ) id 1oX2kF-0004sK-Ie; Sat, 10 Sep 2022 15:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404808.647407; Sat, 10 Sep 2022 15:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kF-0004sD-Eg; Sat, 10 Sep 2022 15:50:11 +0000 Received: by outflank-mailman (input) for mailman id 404808; Sat, 10 Sep 2022 15:50:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kE-0004rT-GV for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:50:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ee2666c-3120-11ed-a31c-8f8a9ae3403f; Sat, 10 Sep 2022 17:50:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2231222004; Sat, 10 Sep 2022 15:50:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF63D13441; Sat, 10 Sep 2022 15:50:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W3KQKS+yHGNiZAAAMHmgww (envelope-from ); Sat, 10 Sep 2022 15:50:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ee2666c-3120-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662825008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YX7767BRvnYvt1UK4p6BHY9ImMXrDao1VWeozDcVM6o=; b=EniQIcBXKrVNcpGY7A9pztSJt35WlnHvbP9WEHwcy0OZSRVKQE+h0qbbvU3IF6SdLxDFsa jOXrljql5m9vh2GcHmaxbPDZJorzhVhkXGNcFddz6jDOLzMftnaLTaepOUNCIlgxtoeADg a1GSxerLR0XXoV90nvp+7rcskbzLONE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tamas K Lengyel , Lukasz Hawrylko , "Daniel P. Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Paul Durrant Subject: [RFC PATCH 1/3] xen/spinlock: add explicit non-recursive locking functions Date: Sat, 10 Sep 2022 17:49:57 +0200 Message-Id: <20220910154959.15971-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220910154959.15971-1-jgross@suse.com> References: <20220910154959.15971-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare a type-safe recursive spinlock structure, add explicitly non-recursive locking functions to be used for non-recursive locking of spinlocks, which are use recursively, too. Signed-off-by: Juergen Gross --- xen/arch/arm/mm.c | 4 ++-- xen/arch/x86/domain.c | 12 ++++++------ xen/arch/x86/mm.c | 12 ++++++------ xen/arch/x86/mm/mem_sharing.c | 8 ++++---- xen/arch/x86/mm/p2m-pod.c | 4 ++-- xen/arch/x86/mm/p2m.c | 4 ++-- xen/arch/x86/numa.c | 4 ++-- xen/arch/x86/tboot.c | 4 ++-- xen/common/domain.c | 4 ++-- xen/common/domctl.c | 4 ++-- xen/common/grant_table.c | 10 +++++----- xen/common/ioreq.c | 2 +- xen/common/memory.c | 4 ++-- xen/common/page_alloc.c | 18 +++++++++--------- xen/drivers/char/console.c | 24 ++++++++++++------------ xen/drivers/passthrough/pci.c | 4 ++-- xen/include/xen/spinlock.h | 17 ++++++++++++++++- 17 files changed, 77 insertions(+), 62 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 11ee49598b..bf88d2cab8 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1284,7 +1284,7 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, if ( page_get_owner(page) == d ) return; - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); /* * The incremented type count pins as writable or read-only. @@ -1315,7 +1315,7 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, page_list_add_tail(page, &d->xenpage_list); } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); } int xenmem_add_to_physmap_one( diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 41e1e3f272..a66846a6d1 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -213,7 +213,7 @@ void dump_pageframe_info(struct domain *d) { unsigned long total[MASK_EXTR(PGT_type_mask, PGT_type_mask) + 1] = {}; - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_for_each ( page, &d->page_list ) { unsigned int index = MASK_EXTR(page->u.inuse.type_info, @@ -232,13 +232,13 @@ void dump_pageframe_info(struct domain *d) _p(mfn_x(page_to_mfn(page))), page->count_info, page->u.inuse.type_info); } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); } if ( is_hvm_domain(d) ) p2m_pod_dump_data(d); - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_for_each ( page, &d->xenpage_list ) { @@ -254,7 +254,7 @@ void dump_pageframe_info(struct domain *d) page->count_info, page->u.inuse.type_info); } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); } void update_guest_memory_policy(struct vcpu *v, @@ -2456,10 +2456,10 @@ int domain_relinquish_resources(struct domain *d) } #endif - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_splice(&d->arch.relmem_list, &d->page_list); INIT_PAGE_LIST_HEAD(&d->arch.relmem_list); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); PROGRESS(xen): diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index db1817b691..e084ba04ad 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -499,7 +499,7 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, set_gpfn_from_mfn(mfn_x(page_to_mfn(page)), INVALID_M2P_ENTRY); - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); /* The incremented type count pins as writable or read-only. */ page->u.inuse.type_info = @@ -519,7 +519,7 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, page_list_add_tail(page, &d->xenpage_list); } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); } void make_cr3(struct vcpu *v, mfn_t mfn) @@ -3586,11 +3586,11 @@ long do_mmuext_op( { bool drop_ref; - spin_lock(&pg_owner->page_alloc_lock); + spin_lock_nonrecursive(&pg_owner->page_alloc_lock); drop_ref = (pg_owner->is_dying && test_and_clear_bit(_PGT_pinned, &page->u.inuse.type_info)); - spin_unlock(&pg_owner->page_alloc_lock); + spin_unlock_nonrecursive(&pg_owner->page_alloc_lock); if ( drop_ref ) { pin_drop: @@ -4413,7 +4413,7 @@ int steal_page( * that it might be upon return from alloc_domheap_pages with * MEMF_no_owner set. */ - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); BUG_ON(page->u.inuse.type_info & (PGT_count_mask | PGT_locked | PGT_pinned)); @@ -4425,7 +4425,7 @@ int steal_page( if ( !(memflags & MEMF_no_refcount) && !domain_adjust_tot_pages(d, -1) ) drop_dom_ref = true; - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); if ( unlikely(drop_dom_ref) ) put_domain(d); diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 649d93dc54..89817dc427 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -758,11 +758,11 @@ static int page_make_private(struct domain *d, struct page_info *page) if ( !get_page(page, dom_cow) ) return -EINVAL; - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); if ( d->is_dying ) { - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); put_page(page); return -EBUSY; } @@ -770,7 +770,7 @@ static int page_make_private(struct domain *d, struct page_info *page) expected_type = (PGT_shared_page | PGT_validated | PGT_locked | 2); if ( page->u.inuse.type_info != expected_type ) { - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); put_page(page); return -EEXIST; } @@ -787,7 +787,7 @@ static int page_make_private(struct domain *d, struct page_info *page) if ( domain_adjust_tot_pages(d, 1) == 1 ) get_knownalive_domain(d); page_list_add_tail(page, &d->page_list); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); put_page(page); diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index fc110506dc..deab55648c 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -39,7 +39,7 @@ static inline void lock_page_alloc(struct p2m_domain *p2m) { page_alloc_mm_pre_lock(p2m->domain); - spin_lock(&(p2m->domain->page_alloc_lock)); + spin_lock_nonrecursive(&(p2m->domain->page_alloc_lock)); page_alloc_mm_post_lock(p2m->domain, p2m->domain->arch.page_alloc_unlock_level); } @@ -47,7 +47,7 @@ static inline void lock_page_alloc(struct p2m_domain *p2m) static inline void unlock_page_alloc(struct p2m_domain *p2m) { page_alloc_mm_unlock(p2m->domain->arch.page_alloc_unlock_level); - spin_unlock(&(p2m->domain->page_alloc_lock)); + spin_unlock_nonrecursive(&(p2m->domain->page_alloc_lock)); } /* diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index a405ee5fde..30bc248f72 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -2245,7 +2245,7 @@ void audit_p2m(struct domain *d, /* Audit part two: walk the domain's page allocation list, checking * the m2p entries. */ - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_for_each ( page, &d->page_list ) { mfn = mfn_x(page_to_mfn(page)); @@ -2297,7 +2297,7 @@ void audit_p2m(struct domain *d, P2M_PRINTK("OK: mfn=%#lx, gfn=%#lx, p2mfn=%#lx\n", mfn, gfn, mfn_x(p2mfn)); } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); pod_unlock(p2m); p2m_unlock(p2m); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 627ae8aa95..90fbfdcb31 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -425,13 +425,13 @@ static void cf_check dump_numa(unsigned char key) for_each_online_node ( i ) page_num_node[i] = 0; - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_for_each(page, &d->page_list) { i = phys_to_nid(page_to_maddr(page)); page_num_node[i]++; } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); for_each_online_node ( i ) printk(" Node %u: %u\n", i, page_num_node[i]); diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index fe1abfdf08..93e8e3e90f 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -215,14 +215,14 @@ static void tboot_gen_domain_integrity(const uint8_t key[TB_KEY_SIZE], continue; printk("MACing Domain %u\n", d->domain_id); - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_for_each(page, &d->page_list) { void *pg = __map_domain_page(page); vmac_update(pg, PAGE_SIZE, &ctx); unmap_domain_page(pg); } - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); if ( !is_idle_domain(d) ) { diff --git a/xen/common/domain.c b/xen/common/domain.c index c23f449451..51160a4b5c 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -598,8 +598,8 @@ struct domain *domain_create(domid_t domid, atomic_set(&d->refcnt, 1); RCU_READ_LOCK_INIT(&d->rcu_lock); - spin_lock_init_prof(d, domain_lock); - spin_lock_init_prof(d, page_alloc_lock); + spin_lock_recursive_init_prof(d, domain_lock); + spin_lock_recursive_init_prof(d, page_alloc_lock); spin_lock_init(&d->hypercall_deadlock_mutex); INIT_PAGE_LIST_HEAD(&d->page_list); INIT_PAGE_LIST_HEAD(&d->extra_page_list); diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 452266710a..09870c87e0 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -651,14 +651,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) { uint64_t new_max = op->u.max_mem.max_memkb >> (PAGE_SHIFT - 10); - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); /* * NB. We removed a check that new_max >= current tot_pages; this means * that the domain will now be allowed to "ratchet" down to new_max. In * the meantime, while tot > max, all new allocations are disallowed. */ d->max_pages = min(new_max, (uint64_t)(typeof(d->max_pages))-1); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); break; } diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index ad773a6996..7acf8a9f6c 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -2349,7 +2349,7 @@ gnttab_transfer( mfn = page_to_mfn(page); } - spin_lock(&e->page_alloc_lock); + spin_lock_nonrecursive(&e->page_alloc_lock); /* * Check that 'e' will accept the page and has reservation @@ -2360,7 +2360,7 @@ gnttab_transfer( unlikely(domain_tot_pages(e) >= e->max_pages) || unlikely(!(e->tot_pages + 1)) ) { - spin_unlock(&e->page_alloc_lock); + spin_unlock_nonrecursive(&e->page_alloc_lock); if ( e->is_dying ) gdprintk(XENLOG_INFO, "Transferee d%d is dying\n", @@ -2384,7 +2384,7 @@ gnttab_transfer( * safely drop the lock and re-aquire it later to add page to the * pagelist. */ - spin_unlock(&e->page_alloc_lock); + spin_unlock_nonrecursive(&e->page_alloc_lock); okay = gnttab_prepare_for_transfer(e, d, gop.ref); /* @@ -2400,9 +2400,9 @@ gnttab_transfer( * Need to grab this again to safely free our "reserved" * page in the page total */ - spin_lock(&e->page_alloc_lock); + spin_lock_nonrecursive(&e->page_alloc_lock); drop_dom_ref = !domain_adjust_tot_pages(e, -1); - spin_unlock(&e->page_alloc_lock); + spin_unlock_nonrecursive(&e->page_alloc_lock); if ( okay /* i.e. e->is_dying due to the surrounding if() */ ) gdprintk(XENLOG_INFO, "Transferee d%d is now dying\n", diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index 4617aef29b..c46a5d70e6 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -1329,7 +1329,7 @@ unsigned int ioreq_broadcast(ioreq_t *p, bool buffered) void ioreq_domain_init(struct domain *d) { - spin_lock_init(&d->ioreq_server.lock); + spin_lock_recursive_init(&d->ioreq_server.lock); arch_ioreq_domain_init(d); } diff --git a/xen/common/memory.c b/xen/common/memory.c index ae8163a738..0b4313832e 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -769,10 +769,10 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) (1UL << in_chunk_order)) - (j * (1UL << exch.out.extent_order))); - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); drop_dom_ref = (dec_count && !domain_adjust_tot_pages(d, -dec_count)); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); if ( drop_dom_ref ) put_domain(d); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 62afb07bc6..35e6015ce2 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -469,7 +469,7 @@ unsigned long domain_adjust_tot_pages(struct domain *d, long pages) { long dom_before, dom_after, dom_claimed, sys_before, sys_after; - ASSERT(spin_is_locked(&d->page_alloc_lock)); + ASSERT(spin_recursive_is_locked(&d->page_alloc_lock)); d->tot_pages += pages; /* @@ -508,7 +508,7 @@ int domain_set_outstanding_pages(struct domain *d, unsigned long pages) * must always take the global heap_lock rather than only in the much * rarer case that d->outstanding_pages is non-zero */ - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); spin_lock(&heap_lock); /* pages==0 means "unset" the claim. */ @@ -554,7 +554,7 @@ int domain_set_outstanding_pages(struct domain *d, unsigned long pages) out: spin_unlock(&heap_lock); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); return ret; } @@ -2328,7 +2328,7 @@ int assign_pages( int rc = 0; unsigned int i; - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); if ( unlikely(d->is_dying) ) { @@ -2410,7 +2410,7 @@ int assign_pages( } out: - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); return rc; } @@ -2891,9 +2891,9 @@ mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) ASSERT_ALLOC_CONTEXT(); /* Acquire a page from reserved page list(resv_page_list). */ - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page = page_list_remove_head(&d->resv_page_list); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); if ( unlikely(!page) ) return INVALID_MFN; @@ -2912,9 +2912,9 @@ mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) */ unprepare_staticmem_pages(page, 1, false); fail: - spin_lock(&d->page_alloc_lock); + spin_lock_nonrecursive(&d->page_alloc_lock); page_list_add_tail(page, &d->resv_page_list); - spin_unlock(&d->page_alloc_lock); + spin_unlock_nonrecursive(&d->page_alloc_lock); return INVALID_MFN; } #endif diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index e8468c121a..2e861ad9d6 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -120,7 +120,7 @@ static int __read_mostly sercon_handle = -1; int8_t __read_mostly opt_console_xen; /* console=xen */ #endif -static DEFINE_SPINLOCK(console_lock); +static DEFINE_SPINLOCK_RECURSIVE(console_lock); /* * To control the amount of printing, thresholds are added. @@ -328,7 +328,7 @@ static void cf_check do_dec_thresh(unsigned char key, struct cpu_user_regs *regs static void conring_puts(const char *str, size_t len) { - ASSERT(spin_is_locked(&console_lock)); + ASSERT(spin_recursive_is_locked(&console_lock)); while ( len-- ) conring[CONRING_IDX_MASK(conringp++)] = *str++; @@ -369,9 +369,9 @@ long read_console_ring(struct xen_sysctl_readconsole *op) if ( op->clear ) { - spin_lock_irq(&console_lock); + spin_lock_nonrecursive_irq(&console_lock); conringc = p - c > conring_size ? p - conring_size : c; - spin_unlock_irq(&console_lock); + spin_unlock_nonrecursive_irq(&console_lock); } op->count = sofar; @@ -612,7 +612,7 @@ static long guest_console_write(XEN_GUEST_HANDLE_PARAM(char) buffer, if ( is_hardware_domain(cd) ) { /* Use direct console output as it could be interactive */ - spin_lock_irq(&console_lock); + spin_lock_nonrecursive_irq(&console_lock); console_serial_puts(kbuf, kcount); video_puts(kbuf, kcount); @@ -633,7 +633,7 @@ static long guest_console_write(XEN_GUEST_HANDLE_PARAM(char) buffer, tasklet_schedule(¬ify_dom0_con_ring_tasklet); } - spin_unlock_irq(&console_lock); + spin_unlock_nonrecursive_irq(&console_lock); } else { @@ -739,7 +739,7 @@ static void __putstr(const char *str) { size_t len = strlen(str); - ASSERT(spin_is_locked(&console_lock)); + ASSERT(spin_recursive_is_locked(&console_lock)); console_serial_puts(str, len); video_puts(str, len); @@ -1000,9 +1000,9 @@ void __init console_init_preirq(void) pv_console_set_rx_handler(serial_rx); /* HELLO WORLD --- start-of-day banner text. */ - spin_lock(&console_lock); + spin_lock_nonrecursive(&console_lock); __putstr(xen_banner()); - spin_unlock(&console_lock); + spin_unlock_nonrecursive(&console_lock); printk("Xen version %d.%d%s (%s@%s) (%s) %s %s\n", xen_major_version(), xen_minor_version(), xen_extra_version(), xen_compile_by(), xen_compile_domain(), xen_compiler(), @@ -1039,13 +1039,13 @@ void __init console_init_ring(void) } opt_conring_size = PAGE_SIZE << order; - spin_lock_irqsave(&console_lock, flags); + spin_lock_nonrecursive_irqsave(&console_lock, flags); for ( i = conringc ; i != conringp; i++ ) ring[i & (opt_conring_size - 1)] = conring[i & (conring_size - 1)]; conring = ring; smp_wmb(); /* Allow users of console_force_unlock() to see larger buffer. */ conring_size = opt_conring_size; - spin_unlock_irqrestore(&console_lock, flags); + spin_unlock_nonrecursive_irqrestore(&console_lock, flags); printk("Allocated console ring of %u KiB.\n", opt_conring_size >> 10); } @@ -1151,7 +1151,7 @@ void console_force_unlock(void) { watchdog_disable(); spin_debug_disable(); - spin_lock_init(&console_lock); + spin_lock_recursive_init(&console_lock); serial_force_unlock(sercon_handle); console_locks_busted = 1; console_start_sync(); diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index cdaf5c247f..c86b11be10 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -50,7 +50,7 @@ struct pci_seg { } bus2bridge[MAX_BUSES]; }; -static spinlock_t _pcidevs_lock = SPIN_LOCK_UNLOCKED; +static DEFINE_SPINLOCK_RECURSIVE(_pcidevs_lock); void pcidevs_lock(void) { @@ -64,7 +64,7 @@ void pcidevs_unlock(void) bool_t pcidevs_locked(void) { - return !!spin_is_locked(&_pcidevs_lock); + return !!spin_recursive_is_locked(&_pcidevs_lock); } static struct radix_tree_root pci_segments; diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 961891bea4..20f64102c9 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -40,7 +40,7 @@ union lock_debug { }; lock profiling on: Global locks which should be subject to profiling must be declared via - DEFINE_SPINLOCK. + DEFINE_SPINLOCK[_RECURSIVE]. For locks in structures further measures are necessary: - the structure definition must include a profile_head with exactly this @@ -146,6 +146,8 @@ struct lock_profile_qhead { }; #endif +#define DEFINE_SPINLOCK_RECURSIVE(l) DEFINE_SPINLOCK(l) + typedef union { u32 head_tail; struct { @@ -171,6 +173,8 @@ typedef struct spinlock { #define spin_lock_init(l) (*(l) = (spinlock_t)SPIN_LOCK_UNLOCKED) +#define spin_lock_recursive_init(l) (*(l) = (spinlock_t)SPIN_LOCK_UNLOCKED) +#define spin_lock_recursive_init_prof(s, l) spin_lock_init_prof(s, l) void _spin_lock(spinlock_t *lock); void _spin_lock_cb(spinlock_t *lock, void (*cond)(void *), void *data); @@ -223,9 +227,20 @@ void _spin_unlock_recursive(spinlock_t *lock); * part of a recursively-nested set must be protected by these forms. If there * are any critical regions that cannot form part of such a set, they can use * standard spin_[un]lock(). + * The related spin_[un]lock_nonrecursive() variants should be used when no + * recursion of locking is needed for locks, which might be taken recursively. */ #define spin_trylock_recursive(l) _spin_trylock_recursive(l) #define spin_lock_recursive(l) _spin_lock_recursive(l) #define spin_unlock_recursive(l) _spin_unlock_recursive(l) +#define spin_recursive_is_locked(l) spin_is_locked(l) + +#define spin_trylock_nonrecursive(l) spin_trylock(l) +#define spin_lock_nonrecursive(l) spin_lock(l) +#define spin_unlock_nonrecursive(l) spin_unlock(l) +#define spin_lock_nonrecursive_irq(l) spin_lock_irq(l) +#define spin_unlock_nonrecursive_irq(l) spin_unlock_irq(l) +#define spin_lock_nonrecursive_irqsave(l, f) spin_lock_irqsave(l, f) +#define spin_unlock_nonrecursive_irqrestore(l, f) spin_unlock_irqrestore(l, f) #endif /* __SPINLOCK_H__ */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:50:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:50:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404809.647417 (Exim 4.92) (envelope-from ) id 1oX2kK-0005Bm-Us; Sat, 10 Sep 2022 15:50:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404809.647417; Sat, 10 Sep 2022 15:50:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kK-0005Bd-Rr; Sat, 10 Sep 2022 15:50:16 +0000 Received: by outflank-mailman (input) for mailman id 404809; Sat, 10 Sep 2022 15:50:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kJ-0004BJ-5f for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:50:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 424092a1-3120-11ed-9760-273f2230c3a0; Sat, 10 Sep 2022 17:50:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C07BC22033; Sat, 10 Sep 2022 15:50:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7F72113441; Sat, 10 Sep 2022 15:50:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xUPdHTWyHGNoZAAAMHmgww (envelope-from ); Sat, 10 Sep 2022 15:50:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 424092a1-3120-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662825013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kww+P6/XyomSMqUmxNBEe2RQmOU2q/zA4hDRZaLZnr0=; b=jO9o5enxEgzbp+rDcM8wyj6qXdr3ETnN0plv8mu81kEud6L5zAdWNbweOIdnZmWBNFc/tm 9lpF9YoVdlFmvemJVp72Q2KUgI8bctjewD+G6rxLuUV4n7pYiCGpkxsH0NWzJwdj36EbKa FFaD2bF2P90kT/C/b4xpHKPdea/60V0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [RFC PATCH 2/3] xen/spinlock: split recursive spinlocks from normal ones Date: Sat, 10 Sep 2022 17:49:58 +0200 Message-Id: <20220910154959.15971-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220910154959.15971-1-jgross@suse.com> References: <20220910154959.15971-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Recursive and normal spinlocks are sharing the same data structure for representation of the lock. This has two major disadvantages: - it is not clear from the definition of a lock, whether it is intended to be used recursive or not, while a mixture of both usage variants needs to be - in production builds (builds without CONFIG_DEBUG_LOCKS) the needed data size of an ordinary spinlock is 8 bytes instead of 4, due to the additional recursion data needed (associated with that the rwlock data is using 12 instead of only 8 bytes) Fix that by introducing a struct spinlock_recursive for recursive spinlocks only, and switch recursive spinlock functions to require pointers to this new struct. This allows to check the correct usage at build time. The sizes per lock will change: lock type debug build non-debug build old new old new spinlock 8 8 8 4 recursive spinlock 8 12 8 8 rwlock 12 12 12 8 So the only downside is an increase for recursive spinlocks in debug builds, while in non-debug builds especially normal spinlocks and rwlocks are consuming less memory. Signed-off-by: Juergen Gross --- xen/arch/x86/include/asm/mm.h | 2 +- xen/arch/x86/mm/mm-locks.h | 2 +- xen/arch/x86/mm/p2m-pod.c | 2 +- xen/common/domain.c | 2 +- xen/common/spinlock.c | 21 ++++++----- xen/include/xen/sched.h | 6 ++-- xen/include/xen/spinlock.h | 65 +++++++++++++++++++++-------------- 7 files changed, 60 insertions(+), 40 deletions(-) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index 0fc826de46..8cf86b4796 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -610,7 +610,7 @@ unsigned long domain_get_maximum_gpfn(struct domain *d); /* Definition of an mm lock: spinlock with extra fields for debugging */ typedef struct mm_lock { - spinlock_t lock; + struct spinlock_recursive lock; int unlock_level; int locker; /* processor which holds the lock */ const char *locker_function; /* func that took it */ diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h index c1523aeccf..7b54e6914b 100644 --- a/xen/arch/x86/mm/mm-locks.h +++ b/xen/arch/x86/mm/mm-locks.h @@ -32,7 +32,7 @@ DECLARE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock); static inline void mm_lock_init(mm_lock_t *l) { - spin_lock_init(&l->lock); + spin_lock_recursive_init(&l->lock); l->locker = -1; l->locker_function = "nobody"; l->unlock_level = 0; diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index deab55648c..02c149f839 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -397,7 +397,7 @@ int p2m_pod_empty_cache(struct domain *d) /* After this barrier no new PoD activities can happen. */ BUG_ON(!d->is_dying); - spin_barrier(&p2m->pod.lock.lock); + spin_barrier(&p2m->pod.lock.lock.lock); lock_page_alloc(p2m); diff --git a/xen/common/domain.c b/xen/common/domain.c index 51160a4b5c..5e5ac4e74b 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -929,7 +929,7 @@ int domain_kill(struct domain *d) case DOMDYING_alive: domain_pause(d); d->is_dying = DOMDYING_dying; - spin_barrier(&d->domain_lock); + spin_barrier(&d->domain_lock.lock); argo_destroy(d); vnuma_destroy(d->vnuma); domain_set_outstanding_pages(d, 0); diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c index 62c83aaa6a..a48ed17ac6 100644 --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -224,6 +224,11 @@ void _spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags) } int _spin_is_locked(spinlock_t *lock) +{ + return lock->tickets.head != lock->tickets.tail; +} + +int _spin_recursive_is_locked(struct spinlock_recursive *lock) { /* * Recursive locks may be locked by another CPU, yet we return @@ -231,7 +236,7 @@ int _spin_is_locked(spinlock_t *lock) * ASSERT()s and alike. */ return lock->recurse_cpu == SPINLOCK_NO_CPU - ? lock->tickets.head != lock->tickets.tail + ? _spin_is_locked(&lock->lock) : lock->recurse_cpu == smp_processor_id(); } @@ -292,7 +297,7 @@ void _spin_barrier(spinlock_t *lock) smp_mb(); } -int _spin_trylock_recursive(spinlock_t *lock) +int _spin_trylock_recursive(struct spinlock_recursive *lock) { unsigned int cpu = smp_processor_id(); @@ -300,11 +305,11 @@ int _spin_trylock_recursive(spinlock_t *lock) BUILD_BUG_ON(NR_CPUS > SPINLOCK_NO_CPU); BUILD_BUG_ON(SPINLOCK_RECURSE_BITS < 3); - check_lock(&lock->debug, true); + check_lock(&lock->lock.debug, true); if ( likely(lock->recurse_cpu != cpu) ) { - if ( !spin_trylock(lock) ) + if ( !spin_trylock(&lock->lock) ) return 0; lock->recurse_cpu = cpu; } @@ -316,13 +321,13 @@ int _spin_trylock_recursive(spinlock_t *lock) return 1; } -void _spin_lock_recursive(spinlock_t *lock) +void _spin_lock_recursive(struct spinlock_recursive *lock) { unsigned int cpu = smp_processor_id(); if ( likely(lock->recurse_cpu != cpu) ) { - _spin_lock(lock); + _spin_lock(&lock->lock); lock->recurse_cpu = cpu; } @@ -331,12 +336,12 @@ void _spin_lock_recursive(spinlock_t *lock) lock->recurse_cnt++; } -void _spin_unlock_recursive(spinlock_t *lock) +void _spin_unlock_recursive(struct spinlock_recursive *lock) { if ( likely(--lock->recurse_cnt == 0) ) { lock->recurse_cpu = SPINLOCK_NO_CPU; - spin_unlock(lock); + spin_unlock(&lock->lock); } } diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 557b3229f6..8d45f522d5 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -375,9 +375,9 @@ struct domain rcu_read_lock_t rcu_lock; - spinlock_t domain_lock; + struct spinlock_recursive domain_lock; - spinlock_t page_alloc_lock; /* protects all the following fields */ + struct spinlock_recursive page_alloc_lock; /* protects following fields */ struct page_list_head page_list; /* linked list */ struct page_list_head extra_page_list; /* linked list (size extra_pages) */ struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ @@ -595,7 +595,7 @@ struct domain #ifdef CONFIG_IOREQ_SERVER /* Lock protects all other values in the sub-struct */ struct { - spinlock_t lock; + struct spinlock_recursive lock; struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; } ioreq_server; #endif diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 20f64102c9..d0cfb4c524 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -89,16 +89,21 @@ struct lock_profile_qhead { int32_t idx; /* index for printout */ }; -#define _LOCK_PROFILE(name) { 0, #name, &name, 0, 0, 0, 0, 0 } +#define _LOCK_PROFILE(name, var) { 0, #name, &var, 0, 0, 0, 0, 0 } #define _LOCK_PROFILE_PTR(name) \ static struct lock_profile * const __lock_profile_##name \ __used_section(".lockprofile.data") = \ &__lock_profile_data_##name -#define _SPIN_LOCK_UNLOCKED(x) { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG, x } +#define _SPIN_LOCK_UNLOCKED(x) { { 0 }, _LOCK_DEBUG, x } #define SPIN_LOCK_UNLOCKED _SPIN_LOCK_UNLOCKED(NULL) #define DEFINE_SPINLOCK(l) \ spinlock_t l = _SPIN_LOCK_UNLOCKED(NULL); \ - static struct lock_profile __lock_profile_data_##l = _LOCK_PROFILE(l); \ + static struct lock_profile __lock_profile_data_##l = _LOCK_PROFILE(l, l); \ + _LOCK_PROFILE_PTR(l) +#define DEFINE_SPINLOCK_RECURSIVE(l) \ + struct spinlock_recursive l = { .lock = _SPIN_LOCK_UNLOCKED(NULL) }; \ + static struct lock_profile __lock_profile_data_##l = \ + _LOCK_PROFILE(l, l.lock); \ _LOCK_PROFILE_PTR(l) #define spin_lock_init_prof(s, l) \ @@ -136,8 +141,10 @@ extern void cf_check spinlock_profile_reset(unsigned char key); struct lock_profile_qhead { }; -#define SPIN_LOCK_UNLOCKED { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG } +#define SPIN_LOCK_UNLOCKED { { 0 }, _LOCK_DEBUG } #define DEFINE_SPINLOCK(l) spinlock_t l = SPIN_LOCK_UNLOCKED +#define DEFINE_SPINLOCK_RECURSIVE(l) \ + struct spinlock_recursive l = { .lock = SPIN_LOCK_UNLOCKED } #define spin_lock_init_prof(s, l) spin_lock_init(&((s)->l)) #define lock_profile_register_struct(type, ptr, idx) @@ -146,8 +153,6 @@ struct lock_profile_qhead { }; #endif -#define DEFINE_SPINLOCK_RECURSIVE(l) DEFINE_SPINLOCK(l) - typedef union { u32 head_tail; struct { @@ -160,21 +165,30 @@ typedef union { typedef struct spinlock { spinlock_tickets_t tickets; - u16 recurse_cpu:SPINLOCK_CPU_BITS; -#define SPINLOCK_NO_CPU ((1u << SPINLOCK_CPU_BITS) - 1) -#define SPINLOCK_RECURSE_BITS (16 - SPINLOCK_CPU_BITS) - u16 recurse_cnt:SPINLOCK_RECURSE_BITS; -#define SPINLOCK_MAX_RECURSE ((1u << SPINLOCK_RECURSE_BITS) - 1) union lock_debug debug; #ifdef CONFIG_DEBUG_LOCK_PROFILE struct lock_profile *profile; #endif } spinlock_t; +struct spinlock_recursive { + struct spinlock lock; + u16 recurse_cpu:SPINLOCK_CPU_BITS; +#define SPINLOCK_NO_CPU ((1u << SPINLOCK_CPU_BITS) - 1) +#define SPINLOCK_RECURSE_BITS (16 - SPINLOCK_CPU_BITS) + u16 recurse_cnt:SPINLOCK_RECURSE_BITS; +#define SPINLOCK_MAX_RECURSE ((1u << SPINLOCK_RECURSE_BITS) - 1) +}; #define spin_lock_init(l) (*(l) = (spinlock_t)SPIN_LOCK_UNLOCKED) -#define spin_lock_recursive_init(l) (*(l) = (spinlock_t)SPIN_LOCK_UNLOCKED) -#define spin_lock_recursive_init_prof(s, l) spin_lock_init_prof(s, l) +#define spin_lock_recursive_init(l) (*(l) = (struct spinlock_recursive){ \ + .lock = (spinlock_t)SPIN_LOCK_UNLOCKED, \ + .recurse_cpu = SPINLOCK_NO_CPU }) +#define spin_lock_recursive_init_prof(s, l) do { \ + spin_lock_init_prof(s, l.lock); \ + (s)->l.recurse_cpu = SPINLOCK_NO_CPU; \ + (s)->l.recurse_cnt = 0; \ + } while (0) void _spin_lock(spinlock_t *lock); void _spin_lock_cb(spinlock_t *lock, void (*cond)(void *), void *data); @@ -189,9 +203,10 @@ int _spin_is_locked(spinlock_t *lock); int _spin_trylock(spinlock_t *lock); void _spin_barrier(spinlock_t *lock); -int _spin_trylock_recursive(spinlock_t *lock); -void _spin_lock_recursive(spinlock_t *lock); -void _spin_unlock_recursive(spinlock_t *lock); +int _spin_recursive_is_locked(struct spinlock_recursive *lock); +int _spin_trylock_recursive(struct spinlock_recursive *lock); +void _spin_lock_recursive(struct spinlock_recursive *lock); +void _spin_unlock_recursive(struct spinlock_recursive *lock); #define spin_lock(l) _spin_lock(l) #define spin_lock_cb(l, c, d) _spin_lock_cb(l, c, d) @@ -233,14 +248,14 @@ void _spin_unlock_recursive(spinlock_t *lock); #define spin_trylock_recursive(l) _spin_trylock_recursive(l) #define spin_lock_recursive(l) _spin_lock_recursive(l) #define spin_unlock_recursive(l) _spin_unlock_recursive(l) -#define spin_recursive_is_locked(l) spin_is_locked(l) - -#define spin_trylock_nonrecursive(l) spin_trylock(l) -#define spin_lock_nonrecursive(l) spin_lock(l) -#define spin_unlock_nonrecursive(l) spin_unlock(l) -#define spin_lock_nonrecursive_irq(l) spin_lock_irq(l) -#define spin_unlock_nonrecursive_irq(l) spin_unlock_irq(l) -#define spin_lock_nonrecursive_irqsave(l, f) spin_lock_irqsave(l, f) -#define spin_unlock_nonrecursive_irqrestore(l, f) spin_unlock_irqrestore(l, f) +#define spin_recursive_is_locked(l) _spin_recursive_is_locked(l) + +#define spin_trylock_nonrecursive(l) spin_trylock(&(l)->lock) +#define spin_lock_nonrecursive(l) spin_lock(&(l)->lock) +#define spin_unlock_nonrecursive(l) spin_unlock(&(l)->lock) +#define spin_lock_nonrecursive_irq(l) spin_lock_irq(&(l)->lock) +#define spin_unlock_nonrecursive_irq(l) spin_unlock_irq(&(l)->lock) +#define spin_lock_nonrecursive_irqsave(l, f) spin_lock_irqsave(&(l)->lock, f) +#define spin_unlock_nonrecursive_irqrestore(l, f) spin_unlock_irqrestore(&(l)->lock, f) #endif /* __SPINLOCK_H__ */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Sep 10 15:50:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 15:50:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404810.647428 (Exim 4.92) (envelope-from ) id 1oX2kP-0005Vh-7q; Sat, 10 Sep 2022 15:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404810.647428; Sat, 10 Sep 2022 15:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kP-0005VU-4l; Sat, 10 Sep 2022 15:50:21 +0000 Received: by outflank-mailman (input) for mailman id 404810; Sat, 10 Sep 2022 15:50:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX2kO-0004BJ-As for xen-devel@lists.xenproject.org; Sat, 10 Sep 2022 15:50:20 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4598fd20-3120-11ed-9760-273f2230c3a0; Sat, 10 Sep 2022 17:50:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 64A0621B67; Sat, 10 Sep 2022 15:50:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2835C13441; Sat, 10 Sep 2022 15:50:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SHyYCDuyHGNqZAAAMHmgww (envelope-from ); Sat, 10 Sep 2022 15:50:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4598fd20-3120-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662825019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HT/7IdQpKAQmA1bHFNkUTH+SSUmzVBMKCGG4nyC9O9s=; b=jz/mSRYOdzK5Rz8l4vKVkSxHUEgyJJvXeZvo62ktJg4xGVarCKlv5fs43igPIMlKhkKYCr 8MseAgKGswoK1fuT9PgS92W0QgQC1NGthqZiTkx3WHw8Yl6ac6z144K0Jc47QEnUE3iVGm XqM4wRxsVcicQV2bue67pHS947cm5hU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 3/3] xen/spinlock: support higher number of cpus Date: Sat, 10 Sep 2022 17:49:59 +0200 Message-Id: <20220910154959.15971-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220910154959.15971-1-jgross@suse.com> References: <20220910154959.15971-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is no real reason why the cpu fields of struct spinlock should be limited to 12 bits, now that there is a 2 byte padding hole after those fields. Make the related structures a little bit larger allowing 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. Signed-off-by: Juergen Gross --- xen/common/spinlock.c | 1 + xen/include/xen/spinlock.h | 18 +++++++++--------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c index a48ed17ac6..5509e4b79a 100644 --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -303,6 +303,7 @@ int _spin_trylock_recursive(struct spinlock_recursive *lock) /* Don't allow overflow of recurse_cpu field. */ BUILD_BUG_ON(NR_CPUS > SPINLOCK_NO_CPU); + BUILD_BUG_ON(SPINLOCK_CPU_BITS > sizeof(lock->recurse_cpu) * 8); BUILD_BUG_ON(SPINLOCK_RECURSE_BITS < 3); check_lock(&lock->lock.debug, true); diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index d0cfb4c524..e157b12f6e 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -6,16 +6,16 @@ #include #include -#define SPINLOCK_CPU_BITS 12 +#define SPINLOCK_CPU_BITS 16 #ifdef CONFIG_DEBUG_LOCKS union lock_debug { - uint16_t val; -#define LOCK_DEBUG_INITVAL 0xffff + uint32_t val; +#define LOCK_DEBUG_INITVAL 0xffffffff struct { - uint16_t cpu:SPINLOCK_CPU_BITS; -#define LOCK_DEBUG_PAD_BITS (14 - SPINLOCK_CPU_BITS) - uint16_t :LOCK_DEBUG_PAD_BITS; + uint32_t cpu:SPINLOCK_CPU_BITS; +#define LOCK_DEBUG_PAD_BITS (30 - SPINLOCK_CPU_BITS) + uint32_t :LOCK_DEBUG_PAD_BITS; bool irq_safe:1; bool unseen:1; }; @@ -173,10 +173,10 @@ typedef struct spinlock { struct spinlock_recursive { struct spinlock lock; - u16 recurse_cpu:SPINLOCK_CPU_BITS; + uint16_t recurse_cpu; #define SPINLOCK_NO_CPU ((1u << SPINLOCK_CPU_BITS) - 1) -#define SPINLOCK_RECURSE_BITS (16 - SPINLOCK_CPU_BITS) - u16 recurse_cnt:SPINLOCK_RECURSE_BITS; +#define SPINLOCK_RECURSE_BITS 8 + uint8_t recurse_cnt; #define SPINLOCK_MAX_RECURSE ((1u << SPINLOCK_RECURSE_BITS) - 1) }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Sep 10 18:54:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 18:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404839.647443 (Exim 4.92) (envelope-from ) id 1oX5cg-0002um-Fr; Sat, 10 Sep 2022 18:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404839.647443; Sat, 10 Sep 2022 18:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX5cg-0002uf-BJ; Sat, 10 Sep 2022 18:54:34 +0000 Received: by outflank-mailman (input) for mailman id 404839; Sat, 10 Sep 2022 18:54:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX5ce-0002uV-MW; Sat, 10 Sep 2022 18:54:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX5ce-0002Bu-JB; Sat, 10 Sep 2022 18:54:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX5ce-0003hn-4S; Sat, 10 Sep 2022 18:54:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX5ce-0002Yr-3T; Sat, 10 Sep 2022 18:54:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rE/Sl3RkQi0GndnnLXlcOXJA7VfCPZOYyH7E76VaVm8=; b=JaaBoaxTgvlvTLx+LiaenMa8zt dumeubNBRzOHeNmaVhbKAKLLnyQD9t1SHgcoGeM1dIsuP7B7JbU0V7QdJQ1cOWgKwfevECn9J93Bn Du6UweUzeC7tszOJIwiRZbbXb6O3mpAq3DmK1RhlRfqo96LDXkLrIiDsirABUH09c0CQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173111: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sat, 10 Sep 2022 18:54:32 +0000 flight 173111 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173111/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 173097 pass in 173111 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173097 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173097 like 172128 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173097 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173097 never pass test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 37 days Failing since 172384 2022-08-11 11:13:58 Z 30 days 64 attempts Testing same since 173008 2022-09-05 15:47:43 Z 5 days 10 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 20:46:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 20:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404851.647454 (Exim 4.92) (envelope-from ) id 1oX7Me-0007ZZ-L7; Sat, 10 Sep 2022 20:46:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404851.647454; Sat, 10 Sep 2022 20:46:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7Me-0007ZS-I3; Sat, 10 Sep 2022 20:46:08 +0000 Received: by outflank-mailman (input) for mailman id 404851; Sat, 10 Sep 2022 20:46:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7Md-0007ZI-HU; Sat, 10 Sep 2022 20:46:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7Md-0004D6-Fn; Sat, 10 Sep 2022 20:46:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7Mc-0002ac-VE; Sat, 10 Sep 2022 20:46:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX7Mc-0006BS-Uk; Sat, 10 Sep 2022 20:46:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hp6PFns8nbKN+1XS71+DbPo7M3v948PGvpP6KE1mmdg=; b=gNJYW6dSQ5l3vJy9T8N+za1GV7 xwXZfA8PAVko9jpA3kUVoKNG+1+/FxlGjp45v5LxdkFu5smditVRl4DiyE7XiAEfvuYIpv+ViDAe1 z4+VvmztPGr0khTBM8j7J19VFZDB9yFwWamLJ2yqlEMZSatLGti4UanRQgOlegsfRWLk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173117: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 20:46:06 +0000 flight 173117 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 284 attempts Testing same since 173112 2022-09-10 10:12:05 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 21:22:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 21:22:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404860.647465 (Exim 4.92) (envelope-from ) id 1oX7w0-0004EV-BK; Sat, 10 Sep 2022 21:22:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404860.647465; Sat, 10 Sep 2022 21:22:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7w0-0004EO-7x; Sat, 10 Sep 2022 21:22:40 +0000 Received: by outflank-mailman (input) for mailman id 404860; Sat, 10 Sep 2022 21:22:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7vz-0004EE-1J; Sat, 10 Sep 2022 21:22:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7vy-0004pA-SI; Sat, 10 Sep 2022 21:22:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oX7vy-0005Um-B9; Sat, 10 Sep 2022 21:22:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oX7vy-0005xM-6r; Sat, 10 Sep 2022 21:22:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cLQy3TCzBWajut2iQ7OYOSKhCGkErWUT/6FBjPVss+U=; b=jPioEorDmaDSTof1tz1ZAIUYJd rcrJXbhw6VCcGOlgctdWZdXyZxJVil5t/xCVkAePnkaQrNWBQ0DJF1yAiSOLkTCkHr/3CSfh/bhYx ra7lX/dPcqrwQJlX1WpasYewQ0EiU6rrsbofG5meUyklfiFDRzjy0DwzPKEBuy8WEpFY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173113: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 10 Sep 2022 21:22:38 +0000 flight 173113 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173113/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 38 days Failing since 172148 2022-08-04 21:39:38 Z 36 days 83 attempts Testing same since 173060 2022-09-08 07:34:59 Z 2 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 10 23:43:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 10 Sep 2022 23:43:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404869.647476 (Exim 4.92) (envelope-from ) id 1oXA8O-0003nL-Da; Sat, 10 Sep 2022 23:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404869.647476; Sat, 10 Sep 2022 23:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXA8O-0003nE-Aj; Sat, 10 Sep 2022 23:43:36 +0000 Received: by outflank-mailman (input) for mailman id 404869; Sat, 10 Sep 2022 23:43:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXA8N-0003n4-2r; Sat, 10 Sep 2022 23:43:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXA8N-0007Dp-1e; Sat, 10 Sep 2022 23:43:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXA8M-0006OX-KS; Sat, 10 Sep 2022 23:43:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXA8M-0006ST-Jx; Sat, 10 Sep 2022 23:43:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MbevmE5txXDJrqkMCuPXqz6xn5k14jsNolG5qr+g7TI=; b=mCgmdLXuhS41HTANgF6AbygNTq BzqVa1e+OPiWVJdwvTz3/wIaAJbC78jJXqflM04tyNCEDBzAcfMh/XArhrcs0W9pY8Z8unPo+0NmC A7fdgjuKq6LQCE03udPBI2iW594J1AsCO02255Jhxo+iBZEBBRo8ndwurQQIfH8eLAsc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173120: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 10 Sep 2022 23:43:34 +0000 flight 173120 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173120/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 285 attempts Testing same since 173112 2022-09-10 10:12:05 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 00:25:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 00:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404881.647486 (Exim 4.92) (envelope-from ) id 1oXAms-00016n-M4; Sun, 11 Sep 2022 00:25:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404881.647486; Sun, 11 Sep 2022 00:25:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXAms-00016g-JA; Sun, 11 Sep 2022 00:25:26 +0000 Received: by outflank-mailman (input) for mailman id 404881; Sun, 11 Sep 2022 00:25:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXAmr-00016W-JV; Sun, 11 Sep 2022 00:25:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXAmr-000076-HM; Sun, 11 Sep 2022 00:25:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXAmr-0000k5-4G; Sun, 11 Sep 2022 00:25:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXAmr-00045I-3m; Sun, 11 Sep 2022 00:25:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sMbBbGnzVNxljxIS7OhlK9qYHKVbuuP4JeVfnlFeKVQ=; b=UAv2SpDwD13588aL2HvYh8NYOD eOdksrwJ6C3KwnTkn0/Fg2LY9coG3HbxEwk8NMneGr/L+T59fdNJdmx2CnBXBn3qC8EQGXVbt4eoy Vm4q7mM6IZw5Ssuhm+XveQ+0+5/asZLBcIZc+Z+0bLhiW98SxfAfKGkqo3OWn2r+SOFI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173115: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ce888220d5c7a805e0e155302a318d5d23e62950 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sun, 11 Sep 2022 00:25:25 +0000 flight 173115 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173115/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 173104 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ce888220d5c7a805e0e155302a318d5d23e62950 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 37 days Failing since 172152 2022-08-05 04:01:26 Z 36 days 83 attempts Testing same since 173104 2022-09-10 01:12:11 Z 0 days 2 attempts ------------------------------------------------------------ 1761 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181191 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 02:27:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 02:27:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404905.647553 (Exim 4.92) (envelope-from ) id 1oXCh8-00062q-5R; Sun, 11 Sep 2022 02:27:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404905.647553; Sun, 11 Sep 2022 02:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXCh8-00062i-0R; Sun, 11 Sep 2022 02:27:38 +0000 Received: by outflank-mailman (input) for mailman id 404905; Sun, 11 Sep 2022 02:27:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXCh6-00062W-En; Sun, 11 Sep 2022 02:27:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXCh6-0000zN-AK; Sun, 11 Sep 2022 02:27:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXCh5-0000uH-Ss; Sun, 11 Sep 2022 02:27:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXCh5-0002cs-SL; Sun, 11 Sep 2022 02:27:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IlO4apWgNh4RNHdhlQeoxqCRmfKlHubPctvK1RCjeK8=; b=tpFFHeUPdoGnoQUAgUPd0Xmi5+ DKsTYxVqZgJz9QK7whxURAyJExo8vvbUwCCMxeWIdWZORis1GQa6CSKCbpDlKElHsN+OJcYrmsR9C 3763jaz9rILloIzWh2M4k5Ug8lld2j5cgHY2KqLLDoibFyVOaX/4E3hfqCcpbUV3S9CE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173116: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c X-Osstest-Versions-That: xen=9066d877bf57a47b0f09741dac996ee1055d6407 From: osstest service owner Date: Sun, 11 Sep 2022 02:27:35 +0000 flight 173116 xen-unstable real [real] flight 173124 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173116/ http://logs.test-lab.xenproject.org/osstest/logs/173124/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 173124-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173106 build-i386-libvirt 6 libvirt-build fail like 173106 build-arm64-libvirt 6 libvirt-build fail like 173106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173106 build-armhf-libvirt 6 libvirt-build fail like 173106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173106 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173106 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c baseline version: xen 9066d877bf57a47b0f09741dac996ee1055d6407 Last test of basis 173106 2022-09-10 03:15:03 Z 0 days Testing same since 173116 2022-09-10 14:08:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang Jan Beulich Juergen Gross Julien Grall Penny Zheng Rahul Singh Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9066d877bf..942ac5fc15 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c -> master From xen-devel-bounces@lists.xenproject.org Sun Sep 11 02:28:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 02:28:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404917.647564 (Exim 4.92) (envelope-from ) id 1oXChw-0006fs-HP; Sun, 11 Sep 2022 02:28:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404917.647564; Sun, 11 Sep 2022 02:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXChw-0006fl-Eh; Sun, 11 Sep 2022 02:28:28 +0000 Received: by outflank-mailman (input) for mailman id 404917; Sun, 11 Sep 2022 02:28:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXChu-0006fb-Mi; Sun, 11 Sep 2022 02:28:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXChu-00010j-LR; Sun, 11 Sep 2022 02:28:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXChu-00010L-4i; Sun, 11 Sep 2022 02:28:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXChu-0003a9-4F; Sun, 11 Sep 2022 02:28:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NM+JrBEqRJTNrZwa1mtCEwOsiVQ0zvY0moOohColbzQ=; b=lRFqbeJ7zIYMKwCf0U1g5yQk6G bper+WJB7Dtr4qIuGIWANLGj+o5MwcIjRUSN8CqGF/dXod8U75QYV42rrNsLheQF88i7BpGxCI33u Yj6Ell+V0ok+vMsYKTQKogCjJWd8aI4mTAuP7uqaqhznL21c+lKzgv66ohqoIFyZIC7o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173122: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 11 Sep 2022 02:28:26 +0000 flight 173122 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173122/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 36 days 286 attempts Testing same since 173112 2022-09-10 10:12:05 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 05:34:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 05:34:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404926.647574 (Exim 4.92) (envelope-from ) id 1oXFbo-0004se-Jw; Sun, 11 Sep 2022 05:34:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404926.647574; Sun, 11 Sep 2022 05:34:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXFbo-0004sX-Gq; Sun, 11 Sep 2022 05:34:20 +0000 Received: by outflank-mailman (input) for mailman id 404926; Sun, 11 Sep 2022 05:34:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXFbn-0004sN-8f; Sun, 11 Sep 2022 05:34:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXFbn-0005P0-3T; Sun, 11 Sep 2022 05:34:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXFbm-0003Zj-N1; Sun, 11 Sep 2022 05:34:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXFbm-00048k-Ka; Sun, 11 Sep 2022 05:34:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5BEG+kmo7wKCvawvCW64qt+WgbU1sezoR2bLW/cpXgY=; b=3sF6DYUG7OhxkTcYJmn5rQpt4Z UjN0kL4qHWFnitDpVZeHg+IBzFyn5m7mmNa+NAo4D+BqYNhQfZqRyBS/+rhH1YyfMhNt0vQVO4fxz 7ySd1/52YtrxJ7TiagIEVKWP8kUr/DHHAV8kvjBiMydsVY6QUvRF80CJbYs4WJUBwrCo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173119: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sun, 11 Sep 2022 05:34:18 +0000 flight 173119 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173119/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 38 days Failing since 172384 2022-08-11 11:13:58 Z 30 days 65 attempts Testing same since 173008 2022-09-05 15:47:43 Z 5 days 11 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 06:43:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 06:43:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404961.647587 (Exim 4.92) (envelope-from ) id 1oXGgb-0004wm-HM; Sun, 11 Sep 2022 06:43:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404961.647587; Sun, 11 Sep 2022 06:43:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXGgb-0004wf-CS; Sun, 11 Sep 2022 06:43:21 +0000 Received: by outflank-mailman (input) for mailman id 404961; Sun, 11 Sep 2022 06:43:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXGga-0004wV-4c; Sun, 11 Sep 2022 06:43:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXGga-0006dT-24; Sun, 11 Sep 2022 06:43:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXGgZ-0000Rs-JC; Sun, 11 Sep 2022 06:43:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXGgZ-0005Lg-Ij; Sun, 11 Sep 2022 06:43:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4ZEH2igfd5LvdYSa44bAPKcZk4iGkdLswVRE2XYvOhg=; b=gpHb49Tl3M46FA9dewkOPHn/jd wPtqAFp3pSrIlf2hWByeD09O/sJkBCk3qfnEGgzwaP6QEMbKrjAOkNboBFJ866YABmfg3oz75P4vQ 1uOaQJuDJZVSObsjjzcDkTrDIR9yH3ziA7B/VCCJnW75Q9Qc9tUthyXl4i6Nyt0bK4M0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173127: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 11 Sep 2022 06:43:19 +0000 flight 173127 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173127/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 37 days Failing since 172151 2022-08-05 02:40:28 Z 37 days 287 attempts Testing same since 173112 2022-09-10 10:12:05 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 07:25:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 07:25:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404973.647596 (Exim 4.92) (envelope-from ) id 1oXHLO-0001eV-Pl; Sun, 11 Sep 2022 07:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404973.647596; Sun, 11 Sep 2022 07:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXHLO-0001eO-NE; Sun, 11 Sep 2022 07:25:30 +0000 Received: by outflank-mailman (input) for mailman id 404973; Sun, 11 Sep 2022 07:25:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXHLN-0001eE-OE; Sun, 11 Sep 2022 07:25:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXHLN-0007Md-Jj; Sun, 11 Sep 2022 07:25:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXHLN-0003iC-0o; Sun, 11 Sep 2022 07:25:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXHLN-00082f-0G; Sun, 11 Sep 2022 07:25:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GTPEhooui0RmvDTckMeiRX+McChc2m45sIN0SXP1Vfc=; b=glUcOIn2PRDPdc78/caLNqk2kx sLFnxCJt8jHGsi67YqnH/OzYTR0PMVwVZGRAv0tOr5xqjbnY9okcnuHJq0L4cbNjxbZ2FK9B2JGBL stG76zdraaUtxaZQfbMrcTzSfhe1W09WqsLI9Jo9Pi8t94tKlTK4Kauurf/rCk0+VW4g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173121: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sun, 11 Sep 2022 07:25:29 +0000 flight 173121 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173121/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 38 days Failing since 172148 2022-08-04 21:39:38 Z 37 days 84 attempts Testing same since 173060 2022-09-08 07:34:59 Z 2 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 10:16:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 10:16:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404989.647607 (Exim 4.92) (envelope-from ) id 1oXK0x-0004rE-G3; Sun, 11 Sep 2022 10:16:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404989.647607; Sun, 11 Sep 2022 10:16:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXK0x-0004r7-DV; Sun, 11 Sep 2022 10:16:35 +0000 Received: by outflank-mailman (input) for mailman id 404989; Sun, 11 Sep 2022 10:16:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXK0r-0004r1-JN for xen-devel@lists.xenproject.org; Sun, 11 Sep 2022 10:16:34 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb1fd324-31ba-11ed-9760-273f2230c3a0; Sun, 11 Sep 2022 12:16:28 +0200 (CEST) Received: from nazgul.tnic (dynamic-046-114-095-207.46.114.pool.telefonica.de [46.114.95.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5D84B1EC051E; Sun, 11 Sep 2022 12:16:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb1fd324-31ba-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1662891381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=hJrCkWXjtCrX48n+DB+7ZxKF7ya+Il6FKndkZXY0O3U=; b=pYSvtLPy2UVoMjaip5Tp8A1pPKEn9TGAn6mcjjSmZ1ZYSZASFmzqizlye+FYIogPOnAWzz pv7QA+VdovvXBgn4U0qaoeiRe58UxUuVCEvDfXCQtadFSzuBXJtRwqDUQDQiYoqD2LsT9D r4/zbGNglCLHAAWama8Zv2FAptDJffI= Date: Sun, 11 Sep 2022 12:16:32 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-4-jgross@suse.com> On Thu, Sep 08, 2022 at 10:49:07AM +0200, Juergen Gross wrote: > diff --git a/arch/x86/include/asm/cacheinfo.h b/arch/x86/include/asm/cacheinfo.h > index 86b2e0dcc4bf..1aeafa9888f7 100644 > --- a/arch/x86/include/asm/cacheinfo.h > +++ b/arch/x86/include/asm/cacheinfo.h > @@ -2,6 +2,11 @@ > #ifndef _ASM_X86_CACHEINFO_H > #define _ASM_X86_CACHEINFO_H > > +/* Kernel controls MTRR and/or PAT MSRs. */ > +extern unsigned int cache_generic; So this should be called something more descriptive like memory_caching_types or so to denote that this is a bitfield of supported memory caching technologies. The code then would read as if (memory_caching_types & CACHE_MTRR) The name's still not optimal tho - needs more brooding over. > +#define CACHE_GENERIC_MTRR 0x01 > +#define CACHE_GENERIC_PAT 0x02 And those should be CACHE_{MTRR,PAT}. > void cacheinfo_amd_init_llc_id(struct cpuinfo_x86 *c, int cpu); > void cacheinfo_hygon_init_llc_id(struct cpuinfo_x86 *c, int cpu); > > diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c > index 66556833d7af..3b05d3ade7a6 100644 > --- a/arch/x86/kernel/cpu/cacheinfo.c > +++ b/arch/x86/kernel/cpu/cacheinfo.c > @@ -35,6 +35,9 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_llc_shared_map); > /* Shared L2 cache maps */ > DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_l2c_shared_map); > > +/* Kernel controls MTRR and/or PAT MSRs. */ > +unsigned int cache_generic; This should either be __ro_after_init and initialized to 0 or you need accessors... > u32 num_var_ranges; > -static bool __mtrr_enabled; > - > -static bool mtrr_enabled(void) > -{ > - return __mtrr_enabled; > -} > +static bool mtrr_enabled; Hmm, I don't like this. There's way too many boolean flags in the mtrr code. There's mtrr_state.enabled too. ;-\ Can we set (or clear) X86_FEATURE_MTRR to denote MTRR enablement status and get rid of one more boolean flag? ... > void __init mtrr_bp_init(void) > { > + bool use_generic = false; > u32 phys_addr; > > init_ifs(); > @@ -694,6 +691,7 @@ void __init mtrr_bp_init(void) > > if (boot_cpu_has(X86_FEATURE_MTRR)) { > mtrr_if = &generic_mtrr_ops; > + use_generic = true; > size_or_mask = SIZE_OR_MASK_BITS(36); > size_and_mask = 0x00f00000; > phys_addr = 36; > @@ -755,15 +753,18 @@ void __init mtrr_bp_init(void) > } > > if (mtrr_if) { > - __mtrr_enabled = true; > - set_num_var_ranges(); > + mtrr_enabled = true; > + set_num_var_ranges(use_generic); You don't need use_generic either: set_num_var_ranges(mtrr_if == generic_mtrr_ops); (The reason being I wanna get rid of that nasty minefield of boolean vars all round that code). -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Sun Sep 11 10:37:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 10:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.404997.647622 (Exim 4.92) (envelope-from ) id 1oXKKd-0007ez-6I; Sun, 11 Sep 2022 10:36:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 404997.647622; Sun, 11 Sep 2022 10:36:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXKKd-0007es-3V; Sun, 11 Sep 2022 10:36:55 +0000 Received: by outflank-mailman (input) for mailman id 404997; Sun, 11 Sep 2022 10:36:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXKKb-0007ei-QX; Sun, 11 Sep 2022 10:36:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXKKb-0002rS-Me; Sun, 11 Sep 2022 10:36:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXKKb-00018X-47; Sun, 11 Sep 2022 10:36:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXKKb-0002ua-3Z; Sun, 11 Sep 2022 10:36:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/drfZdM1ms4tbV4m3k6gp722yx1r6uaEPi85Yt73YuI=; b=hz4Uo0sD5p0SjXAwxgZW+95dSz 3HtZZzrikz/5vAzuicSL1LMkbJpCmyb1VCwq3M2CyJwagQRAzpSzM5LtXRxh6/RJzz9ZKup0K+Zvy d38Xi5M90u1Bra0L7EJE110EhhsH0NhQxB4UVzSioeP/ie5GzoAWwRgNGICm8zwkQtKQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173123: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b96fbd602d35739b5cdb49baa02048f2c41fdab1 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sun, 11 Sep 2022 10:36:53 +0000 flight 173123 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173123/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 172133 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b96fbd602d35739b5cdb49baa02048f2c41fdab1 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 38 days Failing since 172152 2022-08-05 04:01:26 Z 37 days 84 attempts Testing same since 173123 2022-09-11 00:43:12 Z 0 days 1 attempts ------------------------------------------------------------ 1764 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181564 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 11:02:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 11:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405008.647633 (Exim 4.92) (envelope-from ) id 1oXKjN-0003BT-Dv; Sun, 11 Sep 2022 11:02:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405008.647633; Sun, 11 Sep 2022 11:02:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXKjN-0003BM-Ar; Sun, 11 Sep 2022 11:02:29 +0000 Received: by outflank-mailman (input) for mailman id 405008; Sun, 11 Sep 2022 11:02:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXKjM-0003BF-5W for xen-devel@lists.xenproject.org; Sun, 11 Sep 2022 11:02:28 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38a5f848-31c1-11ed-9760-273f2230c3a0; Sun, 11 Sep 2022 13:02:26 +0200 (CEST) Received: from nazgul.tnic (dynamic-046-114-095-207.46.114.pool.telefonica.de [46.114.95.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 330B71EC04D3; Sun, 11 Sep 2022 13:02:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38a5f848-31c1-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1662894142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=P5kwIvUHBjyBBUAObapdTIJePWA8t5W0c1fO0gvG0vs=; b=JxDoua72qGlka0u6SbfQr0k6tskgWj4a+ra+EanXJI6cdjzdXPEn8BUPApQAAXfpU23ScR Mk2jxg6pbqFzDGGYrV5EZwbj6T/dyoTyEbFGAebQRmahNBMBjY/V22ilOCz3x1xZ0SOpvX zaQDMJML+OWaSCrr5uh+IOY9yPnhmeE= Date: Sun, 11 Sep 2022 13:02:34 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 04/10] x86: move some code out of arch/x86/kernel/cpu/mtrr Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-5-jgross@suse.com> On Thu, Sep 08, 2022 at 10:49:08AM +0200, Juergen Gross wrote: > Prepare making PAT and MTRR support independent from each other by > moving some code needed by both out of the MTRR specific sources. This needs to be two patches at least: first one is only *mechanical* move without any changes. The next one(s) do the renaming and other changes etc. Otherwise reviewing it is unnecessarily complicated. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Sun Sep 11 11:24:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 11:24:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405014.647643 (Exim 4.92) (envelope-from ) id 1oXL4q-00060i-67; Sun, 11 Sep 2022 11:24:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405014.647643; Sun, 11 Sep 2022 11:24:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXL4q-00060b-38; Sun, 11 Sep 2022 11:24:40 +0000 Received: by outflank-mailman (input) for mailman id 405014; Sun, 11 Sep 2022 11:24:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXL4o-00060R-EN; Sun, 11 Sep 2022 11:24:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXL4o-0003fS-Bb; Sun, 11 Sep 2022 11:24:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXL4n-0004Ik-Ak; Sun, 11 Sep 2022 11:24:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXL4n-0005KM-8U; Sun, 11 Sep 2022 11:24:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z6G8mo6YgUID2zOjQm3nGddZ/3WSu9XlEdjP4TfYmb4=; b=iXnyBOhbztQL+EDqVJMuSTlzv+ X3ajOticBXpemY/IZ8MUlYCbrDbjL7C26XKpCyV0fwSBZdIlfLZKCgMls2XTaZ8bErmKAz9PQDysV zoZEjkW7jcIaykVswqsIp2bfO9So0bZhS7ogYwUXIvh6ULON6naQirnAD/13GEw74v7o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173130: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 11 Sep 2022 11:24:37 +0000 flight 173130 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173130/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 38 days Failing since 172151 2022-08-05 02:40:28 Z 37 days 288 attempts Testing same since 173112 2022-09-10 10:12:05 Z 1 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 12:25:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 12:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405034.647655 (Exim 4.92) (envelope-from ) id 1oXM0z-0005K6-R8; Sun, 11 Sep 2022 12:24:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405034.647655; Sun, 11 Sep 2022 12:24:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXM0z-0005Jz-Ny; Sun, 11 Sep 2022 12:24:45 +0000 Received: by outflank-mailman (input) for mailman id 405034; Sun, 11 Sep 2022 12:24:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXM0z-0005Jp-7P; Sun, 11 Sep 2022 12:24:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXM0z-0004m9-2x; Sun, 11 Sep 2022 12:24:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXM0y-0007dh-Aq; Sun, 11 Sep 2022 12:24:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXM0y-0007jt-AP; Sun, 11 Sep 2022 12:24:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gElEodbEwwYfKoJIbaPTHLAlGuoh/YSbbrzikZpXSy0=; b=vGptA5qw8MH/qB72l4wrGfMOnd mrW41BYiyV+IypPPET9vBaxDpqUHDauGNFomxgjWzqyinEV5KmxhwLD5rYbUnUwV1GFPUVbZc/JXW XCDZMvAePY52cInBLWCgIiuX4nrH7KJJhZMzppmQR5ZTB1lbzPOVyg39Zzb+POTGyf/w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173128: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b48469fcdb42cea237578e000cfb82b13f05b0ff X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 11 Sep 2022 12:24:44 +0000 flight 173128 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173128/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt b48469fcdb42cea237578e000cfb82b13f05b0ff baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 793 days Failing since 151818 2020-07-11 04:18:52 Z 792 days 774 attempts Testing same since 173109 2022-09-10 04:19:58 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122707 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 13:27:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 13:27:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405071.647665 (Exim 4.92) (envelope-from ) id 1oXMzY-0004ha-JI; Sun, 11 Sep 2022 13:27:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405071.647665; Sun, 11 Sep 2022 13:27:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXMzY-0004hT-Gi; Sun, 11 Sep 2022 13:27:20 +0000 Received: by outflank-mailman (input) for mailman id 405071; Sun, 11 Sep 2022 13:27:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXMzX-0004hJ-41; Sun, 11 Sep 2022 13:27:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXMzW-0006Cs-Vr; Sun, 11 Sep 2022 13:27:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXMzV-0004G0-W9; Sun, 11 Sep 2022 13:27:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXMzV-0004Bv-Vi; Sun, 11 Sep 2022 13:27:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zR3mxq0oU66F4Ra0D6ezhrqSda8XPPFNtflMPJyzOG8=; b=tzCOHflY0ni20HFB9R2/AaCwPf O+9WdCLbTcRB8AJrNC8gJgf2PLvZLut6hhQj0O0fVilJCMODASxofx3Svw76NNOcUGNVZh5CCvJg+ 5Ju3fVayegdm8G+febQIl3RINaspxHzhrLwAFOzLuYUFeCL9aYo3L2FY6R0A33PfSJds=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173126: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c X-Osstest-Versions-That: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c From: osstest service owner Date: Sun, 11 Sep 2022 13:27:17 +0000 flight 173126 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173126/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 173116 pass in 173126 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 173116 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173116 build-i386-libvirt 6 libvirt-build fail like 173116 build-arm64-libvirt 6 libvirt-build fail like 173116 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173116 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173116 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173116 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173116 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173116 build-armhf-libvirt 6 libvirt-build fail like 173116 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173116 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173116 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173116 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173116 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c baseline version: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c Last test of basis 173126 2022-09-11 02:29:58 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Sep 11 15:36:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 15:36:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405114.647677 (Exim 4.92) (envelope-from ) id 1oXP0P-0003U1-58; Sun, 11 Sep 2022 15:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405114.647677; Sun, 11 Sep 2022 15:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXP0P-0003Tu-1K; Sun, 11 Sep 2022 15:36:21 +0000 Received: by outflank-mailman (input) for mailman id 405114; Sun, 11 Sep 2022 15:36:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXP0N-0003Tk-29; Sun, 11 Sep 2022 15:36:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXP0M-0000BS-TY; Sun, 11 Sep 2022 15:36:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXP0M-0004ZF-H0; Sun, 11 Sep 2022 15:36:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXP0M-0001qn-GZ; Sun, 11 Sep 2022 15:36:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o0Ap2AI7MWU8tGRA/8P5+JnPmqPAJYHsnh0qVckeqWw=; b=NlbbLUR0c1oEMOcmz4TiuW37ku iROvEs8pIVZo6FsohB5OxIk+pZFm1xkRKPYFJsZ2PIJr8bBdbkXcri+PJ+2FwTWOLkl+t30uCUoY0 eGPasGDS3GE0u+eeBT555f90/BaUVa0UanNGqgOCZDi6x/uZHeXFwXY9xyJ1q+155gRk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173134: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 11 Sep 2022 15:36:18 +0000 flight 173134 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173134/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 38 days Failing since 172151 2022-08-05 02:40:28 Z 37 days 289 attempts Testing same since 173112 2022-09-10 10:12:05 Z 1 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 16:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 16:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405128.647688 (Exim 4.92) (envelope-from ) id 1oXPfW-0000bB-B8; Sun, 11 Sep 2022 16:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405128.647688; Sun, 11 Sep 2022 16:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXPfW-0000b4-81; Sun, 11 Sep 2022 16:18:50 +0000 Received: by outflank-mailman (input) for mailman id 405128; Sun, 11 Sep 2022 16:18:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXPfV-0000au-K1; Sun, 11 Sep 2022 16:18:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXPfV-0001QQ-Fa; Sun, 11 Sep 2022 16:18:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXPfV-000734-4Y; Sun, 11 Sep 2022 16:18:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXPfV-0001Ne-44; Sun, 11 Sep 2022 16:18:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M3A6rX94HRgEl0S7hSKD+urH3jhgko+MFHNH0zVVwp0=; b=xTZPORFoGl5rvcmdQ0T4JAQE7J USA/vK61DnVgpAttKTusv9M794ISXFM9x3h3Kp3WA3FPluojMpmnfPWZ5URpQ6A+ld5Z8D9LBweBO hMAQxy46+p9SSR4xKiJlyAHTfesq7U6fv+bzZPtu6clUog73XPZ+hxUOkFyxB+wu8q2Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173129: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sun, 11 Sep 2022 16:18:49 +0000 flight 173129 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173129/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-examine-uefi 6 xen-install fail pass in 173119 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 173119 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173119 blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173119 like 172108 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173119 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173119 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173119 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173119 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 38 days Failing since 172384 2022-08-11 11:13:58 Z 31 days 66 attempts Testing same since 173008 2022-09-05 15:47:43 Z 6 days 12 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 17:31:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 17:31:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405183.647717 (Exim 4.92) (envelope-from ) id 1oXQnq-0002rA-5A; Sun, 11 Sep 2022 17:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405183.647717; Sun, 11 Sep 2022 17:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXQnq-0002r3-1H; Sun, 11 Sep 2022 17:31:30 +0000 Received: by outflank-mailman (input) for mailman id 405183; Sun, 11 Sep 2022 17:31:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXQnp-0002qt-0n; Sun, 11 Sep 2022 17:31:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXQno-0002dA-UH; Sun, 11 Sep 2022 17:31:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXQno-0001rh-Dg; Sun, 11 Sep 2022 17:31:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXQno-0005VC-DE; Sun, 11 Sep 2022 17:31:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hm8d7aB4dY80W/IIDVPfNNAr/LgfE8qhY2rheDUNk14=; b=r59L6CIm/n+nTMLyBK5oV0t8NE m9l2A9TmBVlgtu6yTFtyQjfuJ6vfs6e7MYUzOHfOozkma4ghV4n2He8sGrF+AToJ/7DWLACzRWRJ/ R9/Pb7M2AZJUHzaV86R9J7hU4mlj4+Q3IHJK5eNsKCfiM6YMrBspzOnNVSEmEvD5SU24=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173135: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 11 Sep 2022 17:31:28 +0000 flight 173135 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173135/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 38 days Failing since 172151 2022-08-05 02:40:28 Z 37 days 290 attempts Testing same since 173112 2022-09-10 10:12:05 Z 1 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 18:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 18:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405199.647728 (Exim 4.92) (envelope-from ) id 1oXRxn-000350-S6; Sun, 11 Sep 2022 18:45:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405199.647728; Sun, 11 Sep 2022 18:45:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXRxn-00034t-NZ; Sun, 11 Sep 2022 18:45:51 +0000 Received: by outflank-mailman (input) for mailman id 405199; Sun, 11 Sep 2022 18:45:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXRxl-00034j-Tg; Sun, 11 Sep 2022 18:45:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXRxl-0003uo-Mo; Sun, 11 Sep 2022 18:45:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXRxl-0006Kv-1U; Sun, 11 Sep 2022 18:45:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXRxl-0005Mf-12; Sun, 11 Sep 2022 18:45:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0AAqKrSxn9um8qnPeZvFDk4CIa/b27KYVT7YSZr9ENQ=; b=gECJX4XqXGuAQNb4Knj/Gt8RWS s4XaWDxrrJ2Bm/sgNAifdNHBVFNkHIQYSy67IBjnO2+mx3Nm6QiXZaKWs9uFG4hidOD3K/JBX8xcs X+skJWpiw6BtLe2suSrI1D9n+wsgXFDTCJ2piT7s0d7bFmB0Pz8HRdLkk3jP9sSN2bYg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173131: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sun, 11 Sep 2022 18:45:49 +0000 flight 173131 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173131/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173121 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 39 days Failing since 172148 2022-08-04 21:39:38 Z 37 days 85 attempts Testing same since 173060 2022-09-08 07:34:59 Z 3 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 20:43:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 20:43:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405267.647760 (Exim 4.92) (envelope-from ) id 1oXTnt-0000vM-QV; Sun, 11 Sep 2022 20:43:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405267.647760; Sun, 11 Sep 2022 20:43:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXTnt-0000vF-Ne; Sun, 11 Sep 2022 20:43:45 +0000 Received: by outflank-mailman (input) for mailman id 405267; Sun, 11 Sep 2022 20:43:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXTns-0000v5-3H; Sun, 11 Sep 2022 20:43:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXTns-0005ur-0i; Sun, 11 Sep 2022 20:43:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXTnr-0004KC-KJ; Sun, 11 Sep 2022 20:43:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXTnr-0004jo-Ja; Sun, 11 Sep 2022 20:43:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=db/GDnbJBp8Tt3H14YtJ8Rib/DHlhMkvqozF0qWHeNg=; b=ytsvcmlj5+jCaq6xpTy7ZNq9MD UdSn4OheahaBcf1TeyLA4VWB0SkD+AjeHaQi80eGtA08x8nbiJaHvIFWWikMKhoRo6hQj1j9kKUkc tQmwXsrAL/3aDnV6gHvTH9P7coL4uExrA5SKBTCi4Q9EuveS0dnLYlcpzhZdrm+AXvNI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173137: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sun, 11 Sep 2022 20:43:43 +0000 flight 173137 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173137/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 38 days Failing since 172151 2022-08-05 02:40:28 Z 37 days 291 attempts Testing same since 173112 2022-09-10 10:12:05 Z 1 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 11 22:45:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 11 Sep 2022 22:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405296.647770 (Exim 4.92) (envelope-from ) id 1oXVgz-0005rK-AZ; Sun, 11 Sep 2022 22:44:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405296.647770; Sun, 11 Sep 2022 22:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXVgz-0005rD-7K; Sun, 11 Sep 2022 22:44:45 +0000 Received: by outflank-mailman (input) for mailman id 405296; Sun, 11 Sep 2022 22:44:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXVgy-0005r3-E3; Sun, 11 Sep 2022 22:44:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXVgy-0007tP-BE; Sun, 11 Sep 2022 22:44:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXVgx-0003fm-Pm; Sun, 11 Sep 2022 22:44:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXVgx-0003T5-P2; Sun, 11 Sep 2022 22:44:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dVQ8RTawuDlmC0vI7pPqsAMiIbfABmMXTtiDUWHqWtM=; b=vnWHoLVgk3rilV2KegafHJdAiB A151PQb2MzY366i6C/UoJKg7+DCDiBvUqCHay/OmwHJ+uXZON1HaV7xjkF32vb8EMITgi7mGDKI1N bO3ae+tRZXgej1lwXgboSn+3YqN+1u3Z1zE3TtYfVwcuJGldF5lBuFdYYfgwQk1J5E7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173133: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b96fbd602d35739b5cdb49baa02048f2c41fdab1 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sun, 11 Sep 2022 22:44:43 +0000 flight 173133 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173133/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173123 pass in 173133 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173123 pass in 173133 test-amd64-amd64-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail pass in 173123 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b96fbd602d35739b5cdb49baa02048f2c41fdab1 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 38 days Failing since 172152 2022-08-05 04:01:26 Z 37 days 85 attempts Testing same since 173123 2022-09-11 00:43:12 Z 0 days 2 attempts ------------------------------------------------------------ 1764 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181564 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 00:40:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 00:40:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405332.647782 (Exim 4.92) (envelope-from ) id 1oXXUr-0003Th-BN; Mon, 12 Sep 2022 00:40:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405332.647782; Mon, 12 Sep 2022 00:40:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXXUr-0003Ta-8B; Mon, 12 Sep 2022 00:40:21 +0000 Received: by outflank-mailman (input) for mailman id 405332; Mon, 12 Sep 2022 00:40:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXXUp-0003TQ-67; Mon, 12 Sep 2022 00:40:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXXUp-0002Ca-2D; Mon, 12 Sep 2022 00:40:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXXUo-0003OR-Oh; Mon, 12 Sep 2022 00:40:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXXUo-0008Ja-Nx; Mon, 12 Sep 2022 00:40:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PxYsqtJ809WLBCMBh0zFeE0NxYiTxwHaus9GsHZMAWk=; b=18ISaw+VfJ5kBcRPz94YJVNRKG 21k/Xlp0bjN9ZBZp5IssspU21Fvug4t+0UY3aDdGmocASqHFXydQYYcROp7dG8WUdVknkq2tAHMBA FBN7uwDznVGf3hqGRQIl9JSOSgO0LtjVJn9kMMGSzlCWm260lhCFG8b8WkBZf9mE/TU4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173136: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Mon, 12 Sep 2022 00:40:18 +0000 flight 173136 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173136/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-examine-uefi 6 xen-install fail in 173129 pass in 173136 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173129 pass in 173136 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail pass in 173129 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit1 14 guest-start fail in 173129 like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 173129 like 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 38 days Failing since 172384 2022-08-11 11:13:58 Z 31 days 67 attempts Testing same since 173008 2022-09-05 15:47:43 Z 6 days 13 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 01:24:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 01:24:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405348.647792 (Exim 4.92) (envelope-from ) id 1oXYBV-0006k4-SI; Mon, 12 Sep 2022 01:24:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405348.647792; Mon, 12 Sep 2022 01:24:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXYBV-0006jx-PX; Mon, 12 Sep 2022 01:24:25 +0000 Received: by outflank-mailman (input) for mailman id 405348; Mon, 12 Sep 2022 01:24:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXYBU-0006jn-Fk; Mon, 12 Sep 2022 01:24:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXYBU-0001Ex-DE; Mon, 12 Sep 2022 01:24:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXYBU-0006pH-04; Mon, 12 Sep 2022 01:24:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXYBT-0006yy-Vm; Mon, 12 Sep 2022 01:24:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vSNzJUEMXaiGavPuO1JnPcjyPWpkZyrhI4S9WA6TcRo=; b=1h/gIFkzANMQTKVptHDQgFvUgE kSdWBGY8YpiZWPSGCmcw5a+4AxnbWoVXh6sPkO4w4gK2NpxE6HPTJcX6nfyjR/y4C6IIookxF6mcv gRwbCDGgcSoST1oIvx2FGQRuuGBF3lTWOyIJjpgUogoQokiQlM1y/A2HKRjLMDJSIHng=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173140: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 01:24:23 +0000 flight 173140 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 38 days Failing since 172151 2022-08-05 02:40:28 Z 37 days 292 attempts Testing same since 173112 2022-09-10 10:12:05 Z 1 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 04:01:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 04:01:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405373.647815 (Exim 4.92) (envelope-from ) id 1oXacz-0008M0-EE; Mon, 12 Sep 2022 04:00:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405373.647815; Mon, 12 Sep 2022 04:00:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXacz-0008Ks-9P; Mon, 12 Sep 2022 04:00:57 +0000 Received: by outflank-mailman (input) for mailman id 405373; Mon, 12 Sep 2022 04:00:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXacx-00086S-Sc for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 04:00:56 +0000 Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [2a0c:5a00:149::25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e9ac382-324f-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 06:00:52 +0200 (CEST) Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1oXact-009cFJ-Kp; Mon, 12 Sep 2022 06:00:51 +0200 Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1oXact-0004X1-1z; Mon, 12 Sep 2022 06:00:51 +0200 Received: by submission02.runbox with esmtpsa [Authenticated ID (536975)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1oXack-0003S3-8r; Mon, 12 Sep 2022 06:00:42 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e9ac382-324f-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To :Message-Id:Date:Subject:Cc:To:From; bh=MF+/wWILyr0C0xl3zopjiOTUR/mdZqutRIXvlF1iyQo=; b=Afk8Wm/UEp3pCO1d/xw7Ma5ptk ExtXe4A5rAJKu45XYpJWUauEuRBBoP7clumjUTa8k64IbvFXw2rBCdW1yr4H/q7QUa+bgjXAAbHgX cHP0pBQfuF0idhbbKFg3/ZVU66hJ/7XnVV8hRBt06wLl0MryQ3wna/kQAZgdUsJo5vCxe2U0dpR5C 1AK/Vti7racF1vFqeCVsgJCs0tj5RhPcOxTfr2o9OqIWNsQF1AWFhJy+s++0zVLhr1TI1t9aXgux9 FLjOacjtTCQWcBc7cA4lXHKJnwVtUvnZS9+CVx1BuRTDr3ju5V2opOEz1FRInuULztVkgLrjp/NGO GIif5umg==; From: "M. Vefa Bicakci" To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: m.v.b@runbox.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann Subject: [PATCH 2/2] xen/gntdev: Accommodate VMA splitting Date: Mon, 12 Sep 2022 00:00:02 -0400 Message-Id: <20220912040002.198191-3-m.v.b@runbox.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220912040002.198191-1-m.v.b@runbox.com> References: <20220912040002.198191-1-m.v.b@runbox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Prior to this commit, the gntdev driver code did not handle the following scenario correctly: * User process sets up a gntdev mapping composed of two grant mappings (i.e., two pages shared by another Xen domain). * User process munmap()s one of the pages. * User process munmap()s the remaining page. * User process exits. In the scenario above, the user process would cause the kernel to log the following messages in dmesg for the first munmap(), and the second munmap() call would result in similar log messages: BUG: Bad page map in process doublemap.test pte:... pmd:... page:0000000057c97bff refcount:1 mapcount:-1 \ mapping:0000000000000000 index:0x0 pfn:... ... page dumped because: bad pte ... file:gntdev fault:0x0 mmap:gntdev_mmap [xen_gntdev] readpage:0x0 ... Call Trace: dump_stack_lvl+0x46/0x5e print_bad_pte.cold+0x66/0xb6 unmap_page_range+0x7e5/0xdc0 unmap_vmas+0x78/0xf0 unmap_region+0xa8/0x110 __do_munmap+0x1ea/0x4e0 __vm_munmap+0x75/0x120 __x64_sys_munmap+0x28/0x40 do_syscall_64+0x38/0x90 entry_SYSCALL_64_after_hwframe+0x61/0xcb ... For each munmap() call, the Xen hypervisor (if built with CONFIG_DEBUG) would print out the following and trigger a general protection fault in dom0: (XEN) d0v... Attempt to implicitly unmap d0's grant PTE ... (XEN) d0v... Attempt to implicitly unmap d0's grant PTE ... As of this writing, gntdev_grant_map structure's vma field (referred to as map->vma below) is mainly used for checking the start and end addresses of mappings. However, with split VMAs, these may change, and there could be more than one VMA associated with a gntdev mapping. Hence, remove the use of map->vma and rely on map->pages_vm_start for the original start address and on (map->count << PAGE_SHIFT) for the original mapping size. Let the invalidate() and find_special_page() hooks use these. Also, given that there can be multiple VMAs associated with a gntdev mapping, move the "mmu_interval_notifier_remove(&map->notifier)" call to the end of gntdev_put_map, so that the MMU notifier is only removed after the closing of the last remaining VMA. Finally, use an atomic to prevent inadvertent gntdev mapping re-use, instead of using the map->live_grants atomic counter and/or the map->vma pointer (the latter of which is now removed). This prevents the userspace from mmap()'ing (with MAP_FIXED) a gntdev mapping over the same address range as a previously set up gntdev mapping. This scenario can be summarized with the following call-trace, which was valid prior to this commit: mmap gntdev_mmap mmap (repeat mmap with MAP_FIXED over the same address range) gntdev_invalidate unmap_grant_pages (sets 'being_removed' entries to true) gnttab_unmap_refs_async unmap_single_vma gntdev_mmap (maps the shared pages again) munmap gntdev_invalidate unmap_grant_pages (no-op because 'being_removed' entries are true) unmap_single_vma (Xen reports that a granted page is being unmapped and triggers a general protection fault in dom0 if Xen was built with CONFIG_DEBUG) The fix for this last scenario could be worth its own commit, but we opted for a single commit, because removing the gntdev_grant_map structure's vma field requires guarding the entry to gntdev_mmap(), and the live_grants atomic counter is not sufficient on its own to prevent the mmap() over a pre-existing mapping. Link: https://github.com/QubesOS/qubes-issues/issues/7631 Fixes: ab31523c2fca ("xen/gntdev: allow usermode to map granted pages") Cc: stable@vger.kernel.org Signed-off-by: M. Vefa Bicakci --- Note for reviewers: I am not 100% sure if the "Fixes" tag is correct. Based on a quick look at the history of the modified file, I am under the impression that VMA splits could be broken for the Xen gntdev driver since day 1 (i.e., v2.6.38), but I did not yet attempt to verify this by testing older kernels where the gntdev driver's code is sufficiently similar. Also, resetting the being_removed flags to false after the completion of unmap operation could be another potential solution (that I have not yet tested in the context of this change) to the mmap and MAP_FIXED issue discussed at the end of the patch description. --- drivers/xen/gntdev-common.h | 3 +- drivers/xen/gntdev.c | 58 ++++++++++++++++--------------------- 2 files changed, 27 insertions(+), 34 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 40ef379c28ab..9c286b2a1900 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -44,9 +44,10 @@ struct gntdev_unmap_notify { }; struct gntdev_grant_map { + atomic_t in_use; struct mmu_interval_notifier notifier; + bool notifier_init; struct list_head next; - struct vm_area_struct *vma; int index; int count; int flags; diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 485fa9c630aa..a3a0813dada3 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -286,6 +286,9 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map) */ } + if (use_ptemod && map->notifier_init) + mmu_interval_notifier_remove(&map->notifier); + if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) { notify_remote_via_evtchn(map->notify.event); evtchn_put(map->notify.event); @@ -298,7 +301,7 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map) static int find_grant_ptes(pte_t *pte, unsigned long addr, void *data) { struct gntdev_grant_map *map = data; - unsigned int pgnr = (addr - map->vma->vm_start) >> PAGE_SHIFT; + unsigned int pgnr = (addr - map->pages_vm_start) >> PAGE_SHIFT; int flags = map->flags | GNTMAP_application_map | GNTMAP_contains_pte | (1 << _GNTMAP_guest_avail0); u64 pte_maddr; @@ -518,11 +521,7 @@ static void gntdev_vma_close(struct vm_area_struct *vma) struct gntdev_priv *priv = file->private_data; pr_debug("gntdev_vma_close %p\n", vma); - if (use_ptemod) { - WARN_ON(map->vma != vma); - mmu_interval_notifier_remove(&map->notifier); - map->vma = NULL; - } + vma->vm_private_data = NULL; gntdev_put_map(priv, map); } @@ -550,29 +549,30 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn, struct gntdev_grant_map *map = container_of(mn, struct gntdev_grant_map, notifier); unsigned long mstart, mend; + unsigned long map_start, map_end; if (!mmu_notifier_range_blockable(range)) return false; + map_start = map->pages_vm_start; + map_end = map->pages_vm_start + (map->count << PAGE_SHIFT); + /* * If the VMA is split or otherwise changed the notifier is not * updated, but we don't want to process VA's outside the modified * VMA. FIXME: It would be much more understandable to just prevent * modifying the VMA in the first place. */ - if (map->vma->vm_start >= range->end || - map->vma->vm_end <= range->start) + if (map_start >= range->end || map_end <= range->start) return true; - mstart = max(range->start, map->vma->vm_start); - mend = min(range->end, map->vma->vm_end); + mstart = max(range->start, map_start); + mend = min(range->end, map_end); pr_debug("map %d+%d (%lx %lx), range %lx %lx, mrange %lx %lx\n", - map->index, map->count, - map->vma->vm_start, map->vma->vm_end, - range->start, range->end, mstart, mend); - unmap_grant_pages(map, - (mstart - map->vma->vm_start) >> PAGE_SHIFT, - (mend - mstart) >> PAGE_SHIFT); + map->index, map->count, map_start, map_end, + range->start, range->end, mstart, mend); + unmap_grant_pages(map, (mstart - map_start) >> PAGE_SHIFT, + (mend - mstart) >> PAGE_SHIFT); return true; } @@ -1052,18 +1052,15 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) return -EINVAL; pr_debug("map %d+%d at %lx (pgoff %lx)\n", - index, count, vma->vm_start, vma->vm_pgoff); + index, count, vma->vm_start, vma->vm_pgoff); mutex_lock(&priv->lock); map = gntdev_find_map_index(priv, index, count); if (!map) goto unlock_out; - if (use_ptemod && map->vma) - goto unlock_out; - if (atomic_read(&map->live_grants)) { - err = -EAGAIN; + if (!atomic_add_unless(&map->in_use, 1, 1)) goto unlock_out; - } + refcount_inc(&map->users); vma->vm_ops = &gntdev_vmops; @@ -1084,15 +1081,16 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) map->flags |= GNTMAP_readonly; } + map->pages_vm_start = vma->vm_start; + if (use_ptemod) { - map->vma = vma; err = mmu_interval_notifier_insert_locked( &map->notifier, vma->vm_mm, vma->vm_start, vma->vm_end - vma->vm_start, &gntdev_mmu_ops); - if (err) { - map->vma = NULL; + if (err) goto out_unlock_put; - } + + map->notifier_init = true; } mutex_unlock(&priv->lock); @@ -1109,7 +1107,6 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) */ mmu_interval_read_begin(&map->notifier); - map->pages_vm_start = vma->vm_start; err = apply_to_page_range(vma->vm_mm, vma->vm_start, vma->vm_end - vma->vm_start, find_grant_ptes, map); @@ -1138,13 +1135,8 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) out_unlock_put: mutex_unlock(&priv->lock); out_put_map: - if (use_ptemod) { + if (use_ptemod) unmap_grant_pages(map, 0, map->count); - if (map->vma) { - mmu_interval_notifier_remove(&map->notifier); - map->vma = NULL; - } - } gntdev_put_map(priv, map); return err; } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 04:01:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 04:01:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405372.647804 (Exim 4.92) (envelope-from ) id 1oXacy-00086f-3M; Mon, 12 Sep 2022 04:00:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405372.647804; Mon, 12 Sep 2022 04:00:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXacx-00086Y-VP; Mon, 12 Sep 2022 04:00:55 +0000 Received: by outflank-mailman (input) for mailman id 405372; Mon, 12 Sep 2022 04:00:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXacw-00086S-PB for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 04:00:55 +0000 Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com [2a0c:5a00:149::26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e89a40c-324f-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 06:00:52 +0200 (CEST) Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1oXact-009joN-Sw; Mon, 12 Sep 2022 06:00:51 +0200 Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1oXact-0004X5-Cu; Mon, 12 Sep 2022 06:00:51 +0200 Received: by submission02.runbox with esmtpsa [Authenticated ID (536975)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1oXach-0003S3-DL; Mon, 12 Sep 2022 06:00:39 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e89a40c-324f-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=UB4fTYWfrW3vEt2oDlOTKBk6EbS08X1+1sCyJYpMX6M=; b=wsBt9B rNhZlSmXaFOaUsL7bzGgtj6T7a5eDibuOqEJyMGFsWPJHhhEZ7XYhJuc4B5Nl1EqurFY12BPedUZz bfHkSGxrj1XbJp1AwXJy0UOSEcx2IeWNvPkf3IKz50q84/OFGAMT03HUT1v3MeAGEyBUOOdnZzM8a /o0ye5rKua9T7Klgi/hJwrnQqymFfyE5e4cG5MtZ19CYsFxRMRXUnrV+FKN21itSK65H6euVC3LGJ MQiDuyeA+4MVqW75zaAkcDGoAX+cBOMvTuYilUiWPpXxB0ZDLOvM12//HqjbLUNrSCWzHlJbg8B1B 9z7JeYqQ1fpFHHDJI73HWwoCXW9A==; From: "M. Vefa Bicakci" To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: m.v.b@runbox.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann Subject: [PATCH 0/2] xen/gntdev: Fixes for leaks and VMA splitting Date: Mon, 12 Sep 2022 00:00:00 -0400 Message-Id: <20220912040002.198191-1-m.v.b@runbox.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, The changes in this patch series intend to fix the Xen grant device driver, so that grant mapping leaks caused by partially failed grant mapping operations are avoided with the first patch, and so that the splitting of VMAs does not result in incorrectly unmapped grant pages with the second patch. The second patch also prevents a similar issue in a double-mapping scenario, where mmap() is used with MAP_FIXED to map grants over an existing mapping created with the same grants, and where grant pages are unmapped incorrectly as well. These commits were tested on top of Linux v5.15.67, but I have also verified that they compile fine on top of the base commit mentioned at the bottom of this cover letter. The base commit in question is tagged as "next-20220909". Thank you, Vefa M. Vefa Bicakci (2): xen/gntdev: Prevent leaking grants xen/gntdev: Accommodate VMA splitting drivers/xen/gntdev-common.h | 3 +- drivers/xen/gntdev.c | 90 +++++++++++++++++++++---------------- 2 files changed, 54 insertions(+), 39 deletions(-) base-commit: 9a82ccda91ed2b40619cb3c10d446ae1f97bab6e -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 04:01:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 04:01:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405374.647826 (Exim 4.92) (envelope-from ) id 1oXad3-0000CJ-KW; Mon, 12 Sep 2022 04:01:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405374.647826; Mon, 12 Sep 2022 04:01:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXad3-0000CA-Hq; Mon, 12 Sep 2022 04:01:01 +0000 Received: by outflank-mailman (input) for mailman id 405374; Mon, 12 Sep 2022 04:01:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXad1-0000AM-Ui for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 04:01:00 +0000 Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com [2a0c:5a00:149::26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 807703bb-324f-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 06:00:58 +0200 (CEST) Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1oXacx-009joX-FH; Mon, 12 Sep 2022 06:00:55 +0200 Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1oXacr-00022C-OX; Mon, 12 Sep 2022 06:00:50 +0200 Received: by submission02.runbox with esmtpsa [Authenticated ID (536975)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1oXaci-0003S3-RC; Mon, 12 Sep 2022 06:00:41 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 807703bb-324f-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To :Message-Id:Date:Subject:Cc:To:From; bh=NYGbYznUIsRn2pdVapESgYelwBLsRFvNvEAjFtNvGkY=; b=hUlUMRT6twm3sxZyGROBdgsTlJ fII5XbgviPM6jWxx2yNthBtrz/MU8KJhm1ZXqCcJjk8+J4mtYeXUqxigOFOwIYTQ2Zc4e48PDKWkl FiuU6VRFooF1FOHn4h4H/AHNXHvorUWqFMXGuCwLn7YIrQgWkgdhSx2EtufY38sDgmNT6MzRdbw/B AZQMJ+sqoJrsP6dYzR5QX5WCGleAnfX/i0WKifjcdY836iaxkt+tMhkZUw4Fs5nAuntsGQuiRGQhq zDSupC5d67TwaIuKszVMf40uPU44pvcTB/xuMPxDuJVHNzidix+97p7tXEK/85/2ZIUUHd2D4MF4J 2ngOSmFw==; From: "M. Vefa Bicakci" To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: m.v.b@runbox.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann Subject: [PATCH 1/2] xen/gntdev: Prevent leaking grants Date: Mon, 12 Sep 2022 00:00:01 -0400 Message-Id: <20220912040002.198191-2-m.v.b@runbox.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220912040002.198191-1-m.v.b@runbox.com> References: <20220912040002.198191-1-m.v.b@runbox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Prior to this commit, if a grant mapping operation failed partially, some of the entries in the map_ops array would be invalid, whereas all of the entries in the kmap_ops array would be valid. This in turn would cause the following logic in gntdev_map_grant_pages to become invalid: for (i = 0; i < map->count; i++) { if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; if (!use_ptemod) alloced++; } if (use_ptemod) { if (map->kmap_ops[i].status == GNTST_okay) { if (map->map_ops[i].status == GNTST_okay) alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; } } } ... atomic_add(alloced, &map->live_grants); Assume that use_ptemod is true (i.e., the domain mapping the granted pages is a paravirtualized domain). In the code excerpt above, note that the "alloced" variable is only incremented when both kmap_ops[i].status and map_ops[i].status are set to GNTST_okay (i.e., both mapping operations are successful). However, as also noted above, there are cases where a grant mapping operation fails partially, breaking the assumption of the code excerpt above. The aforementioned causes map->live_grants to be incorrectly set. In some cases, all of the map_ops mappings fail, but all of the kmap_ops mappings succeed, meaning that live_grants may remain zero. This in turn makes it impossible to unmap the successfully grant-mapped pages pointed to by kmap_ops, because unmap_grant_pages has the following snippet of code at its beginning: if (atomic_read(&map->live_grants) == 0) return; /* Nothing to do */ In other cases where only some of the map_ops mappings fail but all kmap_ops mappings succeed, live_grants is made positive, but when the user requests unmapping the grant-mapped pages, __unmap_grant_pages_done will then make map->live_grants negative, because the latter function does not check if all of the pages that were requested to be unmapped were actually unmapped, and the same function unconditionally subtracts "data->count" (i.e., a value that can be greater than map->live_grants) from map->live_grants. The side effects of a negative live_grants value have not been studied. The net effect of all of this is that grant references are leaked in one of the above conditions. In Qubes OS v4.1 (which uses Xen's grant mechanism extensively for X11 GUI isolation), this issue manifests itself with warning messages like the following to be printed out by the Linux kernel in the VM that had granted pages (that contain X11 GUI window data) to dom0: "g.e. 0x1234 still pending", especially after the user rapidly resizes GUI VM windows (causing some grant-mapping operations to partially or completely fail, due to the fact that the VM unshares some of the pages as part of the window resizing, making the pages impossible to grant-map from dom0). The fix for this issue involves counting all successful map_ops and kmap_ops mappings separately, and then adding the sum to live_grants. During unmapping, only the number of successfully unmapped grants is subtracted from live_grants. To determine which grants were successfully unmapped, their status fields are set to an arbitrary positive number (1), as was done in commit ebee0eab0859 ("Xen/gntdev: correct error checking in gntdev_map_grant_pages()"). The code is also modified to check for negative live_grants values after the subtraction and warn the user. Link: https://github.com/QubesOS/qubes-issues/issues/7631 Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") Cc: stable@vger.kernel.org Signed-off-by: M. Vefa Bicakci --- drivers/xen/gntdev.c | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 84b143eef395..485fa9c630aa 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) for (i = 0; i < map->count; i++) { if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; - if (!use_ptemod) - alloced++; + alloced++; } else if (!err) err = -EINVAL; @@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) if (use_ptemod) { if (map->kmap_ops[i].status == GNTST_okay) { - if (map->map_ops[i].status == GNTST_okay) - alloced++; + alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; } else if (!err) err = -EINVAL; @@ -394,8 +392,13 @@ static void __unmap_grant_pages_done(int result, unsigned int i; struct gntdev_grant_map *map = data->data; unsigned int offset = data->unmap_ops - map->unmap_ops; + int successful_unmaps = 0; + int live_grants; for (i = 0; i < data->count; i++) { + if (map->unmap_ops[offset + i].status == GNTST_okay) + successful_unmaps++; + WARN_ON(map->unmap_ops[offset + i].status != GNTST_okay && map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); pr_debug("unmap handle=%d st=%d\n", @@ -403,6 +406,9 @@ static void __unmap_grant_pages_done(int result, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { + if (map->kunmap_ops[offset + i].status == GNTST_okay) + successful_unmaps++; + WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay && map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); pr_debug("kunmap handle=%u st=%d\n", @@ -411,11 +417,15 @@ static void __unmap_grant_pages_done(int result, map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; } } + /* * Decrease the live-grant counter. This must happen after the loop to * prevent premature reuse of the grants by gnttab_mmap(). */ - atomic_sub(data->count, &map->live_grants); + live_grants = atomic_sub_return(successful_unmaps, &map->live_grants); + if (WARN_ON(live_grants < 0)) + pr_err("%s: live_grants became negative (%d) after unmapping %d pages!\n", + __func__, live_grants, successful_unmaps); /* Release reference taken by __unmap_grant_pages */ gntdev_put_map(NULL, map); @@ -424,6 +434,8 @@ static void __unmap_grant_pages_done(int result, static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, int pages) { + int idx; + if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { int pgno = (map->notify.addr >> PAGE_SHIFT); @@ -436,6 +448,16 @@ static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, } } + /* Set all unmap/kunmap status fields to an arbitrary positive value, + * so that it is possible to determine which grants were successfully + * unmapped by inspecting the status fields. + */ + for (idx = offset; idx < offset + pages; idx++) { + map->unmap_ops[idx].status = 1; + if (use_ptemod) + map->kunmap_ops[idx].status = 1; + } + map->unmap_data.unmap_ops = map->unmap_ops + offset; map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; map->unmap_data.pages = map->pages + offset; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 04:23:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 04:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405394.647841 (Exim 4.92) (envelope-from ) id 1oXayA-0003jm-EZ; Mon, 12 Sep 2022 04:22:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405394.647841; Mon, 12 Sep 2022 04:22:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXayA-0003je-9M; Mon, 12 Sep 2022 04:22:50 +0000 Received: by outflank-mailman (input) for mailman id 405394; Mon, 12 Sep 2022 04:22:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXay9-0003jU-7c; Mon, 12 Sep 2022 04:22:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXay9-0005Eb-35; Mon, 12 Sep 2022 04:22:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXay8-0000an-L1; Mon, 12 Sep 2022 04:22:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXay8-0005bK-KR; Mon, 12 Sep 2022 04:22:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VLg3Tjui/LhGTSwuxj9YWrh8txwBvSyzqNyX5GKnhMs=; b=nTmQPBZ3q0asvlxJtr6sqXpXN6 1k3cHCFnrFIBjLRw9paltKZ74A3Kw3a+Or4Sh/uj8A/0vkGiU8+rzjhylvTXqLu7Qu0Uty1HhJ8jM SHHqbTyGyQgm9EHIUhAwjEHjHO3j7KpgSHJYLDBLwj8EM9p+Q+jFvKWgObx6eTMOsiCM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173138: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Mon, 12 Sep 2022 04:22:48 +0000 flight 173138 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173131 pass in 173138 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 173131 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 39 days Failing since 172148 2022-08-04 21:39:38 Z 38 days 86 attempts Testing same since 173060 2022-09-08 07:34:59 Z 3 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 04:41:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 04:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405411.647850 (Exim 4.92) (envelope-from ) id 1oXbGP-0006gj-4w; Mon, 12 Sep 2022 04:41:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405411.647850; Mon, 12 Sep 2022 04:41:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXbGP-0006gc-2O; Mon, 12 Sep 2022 04:41:41 +0000 Received: by outflank-mailman (input) for mailman id 405411; Mon, 12 Sep 2022 04:41:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXbGO-0006gS-Bs; Mon, 12 Sep 2022 04:41:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXbGO-0005Xc-5B; Mon, 12 Sep 2022 04:41:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXbGN-0001ru-K0; Mon, 12 Sep 2022 04:41:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXbGN-000271-JU; Mon, 12 Sep 2022 04:41:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AdcmEaSPJ+nkFvk6e6fdkq6kxeH4oLxRo795AmTYbNc=; b=L92HVJV6z8ESdlGr3vgvwt6Mth b+dJ2QlKmuhDNPrZ07vCPfEKsKYwC/cGVYBRXj2TT78nF0+YsaqiENreZTQVAAR29EnyPqkE8iw5v Sv9Eqy8aQr11p4Em8I7Mi8sy8ygJa++tWriNS6NIs2APuNXg1cCeqtIH0ozkzAAr47bw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173143: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 04:41:39 +0000 flight 173143 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173143/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 38 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 293 attempts Testing same since 173112 2022-09-10 10:12:05 Z 1 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 05:54:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 05:54:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405420.647862 (Exim 4.92) (envelope-from ) id 1oXcOS-0006tE-HO; Mon, 12 Sep 2022 05:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405420.647862; Mon, 12 Sep 2022 05:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXcOS-0006t7-EN; Mon, 12 Sep 2022 05:54:04 +0000 Received: by outflank-mailman (input) for mailman id 405420; Mon, 12 Sep 2022 05:54:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXcOR-0006sx-1P for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 05:54:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a7ef5f3-325f-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 07:53:57 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 680C3227C7; Mon, 12 Sep 2022 05:53:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F519139BE; Mon, 12 Sep 2022 05:53:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3GJUBnfJHmMaawAAMHmgww (envelope-from ); Mon, 12 Sep 2022 05:53:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a7ef5f3-325f-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662962039; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dX1Ke72XAo0CL9AdJy6i1EaIYtD9OqqavrqU+iQnLi4=; b=PmqEQoNJ9VjJ7K7zyJlJtt5vBNFVyNt7ULvub2QYXQs5lmrGNQeqWiySEAnkdTXR3AXgsE 65z6RcU3FZKbmci8b5K5XtRNwqrnTwfOt2+NLyJUvrReRJ0jBdwa5EtQszjLqmpdiTDpWy SNapBQ/BWPySmbkd5tsbaHfuv7bxLVY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 0/2] xen/gnttab: reduce size of struct active_grant_entry Date: Mon, 12 Sep 2022 07:53:54 +0200 Message-Id: <20220912055356.24064-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While looking at the grant table code I thought it should be possible to have a smaller struct active_grant_entry. This approach should only hit transitive grants with some negative performance effect, "normal" grants should be not affected. I'm not sure that the domid_to_domain() helper is something we really want, though, so I'm sending out the series as RFC. Juergen Gross (2): xen: add domid_to_domain() helper xen/gnttab: reduce size of struct active_grant_entry xen/common/domain.c | 54 +++++++++++++++++++++++++--------------- xen/common/grant_table.c | 13 +++++----- xen/include/xen/sched.h | 4 +++ 3 files changed, 45 insertions(+), 26 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 05:54:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 05:54:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405421.647872 (Exim 4.92) (envelope-from ) id 1oXcOY-00079m-Oq; Mon, 12 Sep 2022 05:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405421.647872; Mon, 12 Sep 2022 05:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXcOY-00079f-MF; Mon, 12 Sep 2022 05:54:10 +0000 Received: by outflank-mailman (input) for mailman id 405421; Mon, 12 Sep 2022 05:54:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXcOW-00078t-Sn for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 05:54:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f5a542f-325f-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 07:54:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0A9451F98E; Mon, 12 Sep 2022 05:54:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C157D139BE; Mon, 12 Sep 2022 05:54:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kGLqLXzJHmMnawAAMHmgww (envelope-from ); Mon, 12 Sep 2022 05:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f5a542f-325f-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662962045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uD7RrO3aPkckiRSiv33Wtr4oGXbDCkJ2Ff62zi7V5Uc=; b=DTei/9XGCYT+qquqRDTge8bX7duA49Ou/AzSMJGkbtgYHWtnZM5j/ZxSN+aOdyNmUsjbWa FnmMZid9O9cf1zIubdXfUiBnITQa6YptuGZPYEs1+cfoZgkv+79g57F0c+xsY00MtnQfU5 U6HTD0qaprG3CDvZhp8Ox/pox03S/ng= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/2] xen: add domid_to_domain() helper Date: Mon, 12 Sep 2022 07:53:55 +0200 Message-Id: <20220912055356.24064-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220912055356.24064-1-jgross@suse.com> References: <20220912055356.24064-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a helper domid_to_domain() returning the struct domain pointer for a domain give by its domid and which is known not being able to be released (its reference count isn't incremented and no rcu_lock_domain() is called for it). In order to simplify coding add an internal helper for doing the lookup and call that from the new function and similar functions. Signed-off-by: Juergen Gross --- xen/common/domain.c | 54 ++++++++++++++++++++++++++--------------- xen/include/xen/sched.h | 4 +++ 2 files changed, 38 insertions(+), 20 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index c23f449451..2b1866ea42 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -832,25 +832,32 @@ out: return 0; } - -struct domain *get_domain_by_id(domid_t dom) +/* rcu_read_lock(&domlist_read_lock) must be held. */ +static struct domain *domid_2_domain(domid_t dom) { struct domain *d; - rcu_read_lock(&domlist_read_lock); - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); d != NULL; d = rcu_dereference(d->next_in_hashbucket) ) { if ( d->domain_id == dom ) - { - if ( unlikely(!get_domain(d)) ) - d = NULL; - break; - } + return d; } + return NULL; +} + +struct domain *get_domain_by_id(domid_t dom) +{ + struct domain *d; + + rcu_read_lock(&domlist_read_lock); + + d = domid_2_domain(dom); + if ( d && unlikely(!get_domain(d)) ) + d = NULL; + rcu_read_unlock(&domlist_read_lock); return d; @@ -859,20 +866,27 @@ struct domain *get_domain_by_id(domid_t dom) struct domain *rcu_lock_domain_by_id(domid_t dom) { - struct domain *d = NULL; + struct domain *d; rcu_read_lock(&domlist_read_lock); - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); - d != NULL; - d = rcu_dereference(d->next_in_hashbucket) ) - { - if ( d->domain_id == dom ) - { - rcu_lock_domain(d); - break; - } - } + d = domid_2_domain(dom); + if ( d ) + rcu_lock_domain(d); + + rcu_read_unlock(&domlist_read_lock); + + return d; +} + +/* Use only if struct domain is known to stay allocated! */ +struct domain *domid_to_domain(domid_t dom) +{ + struct domain *d; + + rcu_read_lock(&domlist_read_lock); + + d = domid_2_domain(dom); rcu_read_unlock(&domlist_read_lock); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 557b3229f6..f4c4d3a60f 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -737,8 +737,12 @@ static inline struct domain *rcu_lock_current_domain(void) return /*rcu_lock_domain*/(current->domain); } +/* Get struct domain AND increase ref-count of domain. */ struct domain *get_domain_by_id(domid_t dom); +/* Get struct domain known to stay allocated. */ +struct domain *domid_to_domain(domid_t dom); + struct domain *get_pg_owner(domid_t domid); static inline void put_pg_owner(struct domain *pg_owner) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 05:54:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 05:54:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405422.647884 (Exim 4.92) (envelope-from ) id 1oXcOc-0007RQ-21; Mon, 12 Sep 2022 05:54:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405422.647884; Mon, 12 Sep 2022 05:54:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXcOb-0007RJ-Un; Mon, 12 Sep 2022 05:54:13 +0000 Received: by outflank-mailman (input) for mailman id 405422; Mon, 12 Sep 2022 05:54:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXcOa-00078t-4d for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 05:54:12 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52a17d56-325f-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 07:54:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B3E25227C6; Mon, 12 Sep 2022 05:54:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E504139BE; Mon, 12 Sep 2022 05:54:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HJuEGYLJHmMuawAAMHmgww (envelope-from ); Mon, 12 Sep 2022 05:54:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52a17d56-325f-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662962050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ul1iFRnyaP+EjSwgFYHlOg+ezwj9WuwKzmQ6FnbRLy4=; b=ObwtyCGROAgkmoE9giDM1R+ryoK6UHuHq00FAOvQdcf+/7Kcq3LYYFsMD3OgNI7pZxuh8h cNs+ByOJlNBuI2UDlgaezEtW6bXLf0Xn+/YhDmNoLEpURH3UrT66OeeGAhoY1GJlecgOCR RMG6MXrMqlGp88Hr5SVcSgVXuoA9LYs= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/2] xen/gnttab: reduce size of struct active_grant_entry Date: Mon, 12 Sep 2022 07:53:56 +0200 Message-Id: <20220912055356.24064-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220912055356.24064-1-jgross@suse.com> References: <20220912055356.24064-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The size of struct active_grant_entry for 64-bit builds is 40 or 48 bytes today (with or without NDEBUG). It can easily be reduced by 8 bytes by replacing the trans_domain pointer with the domid of the related domain. trans_domain is only ever used for transitive grants, which last known user has been the old Xenolinux branch of the Linux kernel. This reduction will result in less memory usage and (for production builds) in faster code, as indexing into the active_grant_entry array will be much easier with an entry having a power-of-2 size. The performance loss when using transitive grants shouldn't really matter, given the probability that those aren't in use at all today. Signed-off-by: Juergen Gross --- xen/common/grant_table.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index fba329dcc2..8e4bbe3824 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -381,13 +381,13 @@ struct active_grant_entry { }) domid_t domid; /* Domain being granted access. */ + domid_t trans_domid; /* Domain granting access. */ unsigned int start:15; /* For sub-page grants, the start offset in the page. */ bool is_sub_page:1; /* True if this is a sub-page grant. */ unsigned int length:16; /* For sub-page grants, the length of the grant. */ grant_ref_t trans_gref; - struct domain *trans_domain; mfn_t mfn; /* Machine frame being granted. */ #ifndef NDEBUG gfn_t gfn; /* Guest's idea of the frame being granted. */ @@ -1095,7 +1095,7 @@ map_grant_ref( act->start = 0; act->length = PAGE_SIZE; act->is_sub_page = false; - act->trans_domain = rd; + act->trans_domid = rd->domain_id; act->trans_gref = ref; } } @@ -2494,7 +2494,8 @@ release_grant_for_copy( else { status = &status_entry(rgt, gref); - td = act->trans_domain; + td = (act->trans_domid == rd->domain_id) + ? rd : domid_to_domain(act->trans_domid); trans_gref = act->trans_gref; } @@ -2657,7 +2658,7 @@ acquire_grant_for_copy( !mfn_eq(act->mfn, grant_mfn) || act->start != trans_page_off || act->length != trans_length || - act->trans_domain != td || + act->trans_domid != td->domain_id || act->trans_gref != trans_gref || !act->is_sub_page)) ) { @@ -2676,7 +2677,7 @@ acquire_grant_for_copy( act->domid = ldom; act->start = trans_page_off; act->length = trans_length; - act->trans_domain = td; + act->trans_domid = td->domain_id; act->trans_gref = trans_gref; act->mfn = grant_mfn; act_set_gfn(act, INVALID_GFN); @@ -2738,7 +2739,7 @@ acquire_grant_for_copy( act->is_sub_page = is_sub_page; act->start = trans_page_off; act->length = trans_length; - act->trans_domain = td; + act->trans_domid = td->domain_id; act->trans_gref = trans_gref; act->mfn = grant_mfn; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 06:35:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 06:35:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405439.647895 (Exim 4.92) (envelope-from ) id 1oXd2f-0004kW-7Q; Mon, 12 Sep 2022 06:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405439.647895; Mon, 12 Sep 2022 06:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXd2f-0004kP-36; Mon, 12 Sep 2022 06:35:37 +0000 Received: by outflank-mailman (input) for mailman id 405439; Mon, 12 Sep 2022 06:35:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXd2d-0004kJ-M5 for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 06:35:35 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1539105e-3265-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 08:35:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6877.eurprd04.prod.outlook.com (2603:10a6:803:131::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 06:35:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 06:35:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1539105e-3265-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XjqHVwKzCmZNpPKkRuAat+QMkwbMcIRNNdAMSx15OcVcoEaLmsugcSqdDFls+xxCkkMsuOThPADAIMlidNFdeSBUdby7hyQd739KfVCVzIfvhibZA/A7gO6YhBZ5l99z0YupChY9EXOzLxo3eXbiC0HAg8yqTMob7ws61YzKcamXP1NB1252t3hCPWBuz7yisc1V56uhRfllVLerxwphN1vOW0yPYz3+58G1D3LvcjOC6Yds62ohOF046hsNkkEPYBRNy7jXmA/8DX+vvTOvGE5Qs84n61EwtGJcQcJkcZUoMzhjHsMY1m/YFW8L3Utca85XhRET5IdaUbqMItnfng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=084nf392cCI1P826PCCE/SQbqNwDObDQ09A3n9hmV6k=; b=Ur7HQY5jdD44faSHmmA8oPmNZOdixO6vC6ycLTpdRz4J63kluFLF15dL+9K6dAq37Wmzs6VBv67Bt+hM6TIp9cnnkQVnisfjjIh7mf5mL6y/6Yii4650hUd9I29fJEMBpNDTC30QpjVvHxe+iGNoIbxECZ+NxUJ1O6FOA0upU3yY31MB8ZXHGDafkPRaf0HKTdxG2LQnT64IImhCwrywuaQ7aZTZ1qeqKLebRBTAf/d2jLwtrTOVUYXOHIADanqoh+d/piEQwcvwaE1x9dbuCFvAsY/F2uHkI0+kpUtFLmi1R9P2vOTjdDZBz8TNhs3O5t2445vL5UUmzs4uI3byhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=084nf392cCI1P826PCCE/SQbqNwDObDQ09A3n9hmV6k=; b=NJQkBA2F2rCA6taVcm0K/EzjODQStEcjgwcdQOIDo8pbsfqHjLZsHTvtVW5DNkLQMb6bW7uFQKikV6/VYA5PLO2vHZLkOXXKmQcHXkXpkI/0ne5xpAGBKOjl2Vs0yrjZ8JN3Si8GnkFXLqXowaGfIdt6tRIHlLVk+kXD0EFSbgjRlJwPxyOd4/2xg2yrZNpGaubbAvZ9VRkyEceNcmYT3rdpICB6qFshYXEOpzv2LUoQdn942iHMhFZl4oe6KM1sBT6fS+/g+uL+fnqO9sFDDmBMu8XDXJ30SudTyk0OOFmACQePCojBivqfOHvieWIYFzue8EE991ozLaubuL8bTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Sep 2022 08:35:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] xsm/flask: adjust print messages to use %pd Content-Language: en-US To: "Daniel P. Smith" Cc: jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220909095012.4251-1-dpsmith@apertussolutions.com> <3da17c12-1cbe-165e-94f4-44face9a181f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR07CA0025.eurprd07.prod.outlook.com (2603:10a6:20b:451::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6877:EE_ X-MS-Office365-Filtering-Correlation-Id: 3104f890-06e0-4bbc-3a49-08da9488fc2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: waMSFkmXAEeYQ5Qab/CK7mraICoFOR58RLxjzdbn8iH+V/wRaO6MizGRd2PglfiF1LlN5E6LiETOGr51hfK4QnAtZ8qu/6yhxpjN7yoAa0DR4gTyJm45RhlvOyYXP13VlkxSufOJKkRSmV9a+vgonzyS3ZVW2Y+SxCIFCqEFK3DlDKg7ykgzF3bPwy6Bnjiuv0lsAlnAmQ3kQry0Y8tnvFC4CqaxsRE2pNLMLFFVelnGJYt0DaPWqZZVSJHr4rT/HHzVkbV69TqEqB/fVNBRkcso5E6J+g5VnlqGrHi00atXDVGn91BhH2kegaOyG/rKXCxke+YWy1iQC+5BJNOJnK7qtGryqE1FUyomujKKdZlRDc7FpO+TJ2OifJPAohLjOGzmEfo3vSbnlc4cKnO/Yk5eA1iU6Zkvpx7SDswTAAtg524+U3a0RK4Oyadu3E0s5HaG3588xQum4DMvdUhwOcm8aCDZsK0jmGepKvxX1+lRBn+AbUDPu//3/v/3OjjpfAQvGqh3j4vIZauoWeUZUuOwUvms1Qs0VaWOp//1jtBMXM1JbtMsvEjE0cS8yuEXzTomiSIZAkUvYulqhj4XUptidbYcJT+XDykjh2eXpC6Biwbq1IGbzZdDMfMIt99zv/OWzWLEFT2DtJt1VAi3uBAogBzu/wLazGKej/rCVTxdn5j++s2E7tDRgykYMJInPqyApg/+hc1WGsPXSJ8eA7I+Go6QvIM1jHgCvy2avscwnVAm4yhZo6T4/xgb5VFkRnoQQIPqwEWNkFLlWcQiuFv0jREhWxyWcGjGtqEnW7k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(366004)(376002)(396003)(39850400004)(2616005)(186003)(83380400001)(38100700002)(8936002)(15650500001)(36756003)(31686004)(316002)(66476007)(66556008)(2906002)(5660300002)(6916009)(8676002)(4326008)(66946007)(26005)(86362001)(6666004)(6486002)(6506007)(53546011)(478600001)(31696002)(6512007)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVhjWlZRNys1eGNDZ2RkUDFIOUtMb1VGOENsUWhxczdnY1N6dHpXNzh6Vjhz?= =?utf-8?B?ZHFtQng4MUlvVXZFRFQ5L0xEeXRZcmxNZTZ2YjZFb0RPdHdvL001dlJEVDIx?= =?utf-8?B?ZnNVTFNsY0JYSktKRnFVQ0hNcUlzQnJGR09YekYyRDlSUjROOFMrL0xHVlBq?= =?utf-8?B?RExXQ2w2VzJJejQ3b1VEWHVNcVdSbnNQdDFCeDhzcTRaR2t1WWlVbkNDbDMz?= =?utf-8?B?K3RCRkFQL1N6czcrdXliOEc0aDZnRllPS2dYVTBFV3ducU1jSHJ0R2Z1c05w?= =?utf-8?B?K2Rob3I4bHFDM21DSXgxNHVRRzgzb2JTcFZFRWNDVC90N3BabEtwNldNS0R4?= =?utf-8?B?U1pBejNyVlN0eUphZ0h0QUppQnV1VDV1Z0dDMTNmdlZ4NG14bFBCZXFvMmJs?= =?utf-8?B?Smk5THZMTG9ETGxPNEcxakxvUlJrbTdGTHRucGxjYytNT1AzazJhUnVFVXU3?= =?utf-8?B?TlFSVUVCRjVBWExlUG55WFY2Mm0zOG90VnBSNGJmT29hcHluZVFrbzhZTzd2?= =?utf-8?B?RVVDN0R1R0JmaExnL2F0aTAydkYyVWdrVDkvVHlsR2JlTzJGM24vVk8xZnV6?= =?utf-8?B?WmlSV0ZaM3h0eko1MVoxM28xajdGdEx0UGx2bWFYbmFLTmViM09EUXY5b000?= =?utf-8?B?dy9qQ3E0VG1oR1o4RTQrV3dyWnhxNk9RS21vZ1RxSFJ6Q3dCM1B4amVMeGFv?= =?utf-8?B?ZVZqa2FnaGxqNTJyOUxQNDdzRm82cUdXU2tXck9MMGNEbVhFcUNsaXlSREU1?= =?utf-8?B?bkJ1dHpyc0VETUthWHdSVTZ4TWJFTW53eFhXcldKakQ2dmVSU1dXSTZjV21m?= =?utf-8?B?dEZXTkpSVDRULzRVQXo5L1Y5RW1PMjh4ZGNGUVkwK0NUL0gvbFRzUVU4bVZG?= =?utf-8?B?VjJ2L0lRM2lFUjNhb25LWWlvNEp1bDh3Mk13MjJjYjdsK0s4SmdzV2xKcWNI?= =?utf-8?B?Zi9ZTzNLNEdYU2Q2TXF3L3JreStuWU9aUFFZQ1hWTlRRNnNzVm1hWG90Um1i?= =?utf-8?B?Q0RsbDVQZEZXclhmUDRTNnZNdXo5SFNRUDFROGVPNTh1Ty9pTGk0RXN0eEtY?= =?utf-8?B?SVBZRlpNSTB5ekp2TUlGK1lQOGJOaElERkJXR0thOVBWWkNiZlVRa0FCUXpp?= =?utf-8?B?TjBQSmhLSXQxTTU3WlJiWTA2cG16bjRYVWtacWpaWjVYZFRKVVRobSs4RDlB?= =?utf-8?B?NEkzejdIVzNyMkE2TXVQYXhKSElpS0JtZVBTTDNxcGwrL2ZzY3Npb2EvRDl2?= =?utf-8?B?V05XK0pLRWxTbXdxcmR2THBNdDc1YmpWZGpMNzM2NU5ONTJlMGZIa1F3aUhQ?= =?utf-8?B?c0JiWS84VjdhQmN5OHRld0xEUVpKNVF2STRCajJrTHFsbXljQnBuU3NkRURa?= =?utf-8?B?T0t6SUFXQk82NXVHZExNQTZMeHBKNEc1MGZhRi9RYWtaTkgxZGM4MWcwWXU4?= =?utf-8?B?Zm42Z3BPZXpZaS9Mc29Yd3FsR0hPQW1IWXF5dzc5RTdQTDNncllLUG1zSTlT?= =?utf-8?B?Y0ptbXAvMkNjZWxKZ0w1b1Nka3R2aVl0WkpkYzBBUTdWQUVyTDlpbzhIcVEr?= =?utf-8?B?b2JqU0hlYmE1ZEpsVGNEd3hHZFQzYlZkR3Ntcmp6bmxYbDdGSHJwbXJMZmRL?= =?utf-8?B?Tk9EZEZGVE1KcGlhWTl6clJZemlXNHlHUXkyZGRzYmRZNkpKNGpaTmtzKzBU?= =?utf-8?B?QVlnMXpONlh5aFd2dmkzNGRCOW1oTHJzOHB5UktQOUJzaVI2V25mVzdlR0o0?= =?utf-8?B?UXFkM01CM1lGT3psRk8yMzEwOXFOb0FmT1ZZTnVjMVErc2lvWGZhM3pDTUFT?= =?utf-8?B?UUdOZTRlSlhZOXBjSm5Qb1ZrcnExLzk4SnZFNVpreVVaODk0TzRLZzlybmkr?= =?utf-8?B?OWlNZWFlM294WDVEM3dBNHdHSkxQRGswaG5YKys5cjNDR2NTUFpjWWNPVnVI?= =?utf-8?B?RG1UN1plcHF6N0RSWitlNC9EVk1vZFlKODVoYjhPeENxTEtLK0tzdytvNlN5?= =?utf-8?B?cVc0TnppTExpR0xnZ1RmRzEwMVN1ZWo1UWdVYmJlN3ZpdTdYRWc0Sk1oR01P?= =?utf-8?B?a2JCRVNxSG1vb1hIZDcyd01lTUlTTHRqa3JlVlRLZHIwem1GWnVEcUVRWU1r?= =?utf-8?Q?Mm25PANuboGeOKMkzN6ifBxjw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3104f890-06e0-4bbc-3a49-08da9488fc2f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 06:35:29.5013 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RCMbjgNw0r+setBUYwJOtQbvK/fxCgIiQ1IP0oeS9FYi26Lbx5L0Wo0N6msDuK+6EA12wSCBhQuvLB1N6Zwifg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6877 On 09.09.2022 17:41, Daniel P. Smith wrote: > > On 9/9/22 08:10, Jan Beulich wrote: >> On 09.09.2022 13:34, Daniel P. Smith wrote: >>> On 9/9/22 06:04, Jan Beulich wrote: >>>> On 09.09.2022 11:50, Daniel P. Smith wrote: >>>>> --- a/xen/xsm/flask/avc.c >>>>> +++ b/xen/xsm/flask/avc.c >>>>> @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, >>>>> if ( a && (a->sdom || a->tdom) ) >>>>> { >>>>> if ( a->sdom && a->tdom && a->sdom != a->tdom ) >>>>> - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); >>>>> + avc_printk(&buf, "source=%pd target=%dp ", a->sdom, a->tdom); >>>>> else if ( a->sdom ) >>>>> - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); >>>>> + avc_printk(&buf, "source=%pd ", a->sdom); >>>>> else >>>>> - avc_printk(&buf, "target=%d ", a->tdom->domain_id); >>>>> + avc_printk(&buf, "target=%pd ", a->tdom); >>>> >>>> Apart from switching to %pd to also replace "domid" by "source". That's >>>> fine in the first case (where both domain IDs are logged), but in the >>>> second case it's a little questionable. Wouldn't it be better to be >>>> able to distinguish the tdom == NULL case from the tdom == sdom one, >>>> perhaps by using "source" in the former case but "domid" in the latter >>>> one? >>> >>> Apologies as I am not quite following your question. Let me provide my >>> reasoning and if it doesn't address your question, then please help me >>> understand your concern. >>> >>> The function avc_printk() allows for the incremental build up of an AVC >>> message. In this section, it is attempting to include the applicable >>> source and target that was used to render the AVC. With the switch to >>> %pd, the first and second lines would become "domid=d{id}". I personally >>> find that a bit redundant. Adding to that, in the context of this >>> function there is "sdom" which is source domain, "cdom" which is current >>> domain, and tdom which is target domain. The print statements using cdom >>> or tdom already denoted them with "current=" and "target=" respectively. >>> Whereas, sdom was prefixed with "domid=" in the print statements. To me, >>> it makes more sense to change the prefixes of sdom with "source=" to >>> accurately reflect the context of that domid. >> >> Well, yes, perhaps "domain" would be better than "domid" with the change >> to %pd. But I still think the middle of the three printk()s would better >> distinguish tdom == NULL from tdom == sdom: >> >> else if ( a->sdom ) >> avc_printk(&buf, "%s=%pd ", a->tdom ? "domain" : "source", a->sdom); > > Okay, I see you are trying to reduce away the last "else", but I have > several concerns about doing this suggestion. No, I don't. And I therefore think you further reply (left intact below) also doesn't really apply. The last else only applies when sdom == NULL, but the goal of my suggestion is to distinguish tdom == NULL from tdom == sdom. > - The biggest concern is the fact that in the past, a domain referred > to strictly as "domain" or "domid" in an AVC has always implied it was > the source. At the same time, the target domain has always been > referenced as "target". This suggestion would completely flip that > implied understanding around. In part, this change was to move source > from being implied to being explicitly reported. The end result is it > then makes source explicit as it is for current and target. > > - AFAICT the suggestion is not logically equivalent. The current form > checks first if sdom is defined, then prints it. If sdom is not defined, > then it is presumed that tdom will be defined, and will then print it. > AIUI, the suggestion will lose the case where sdom is not defined. > > - I haven't went to confirm this, but I believe the logic here is based > on an understanding of when sdom and tdom are defined. Specifically, the > expected situations are, > 1. sdom and tdom are defined and not equal, report both > 2. if sdom and tdom are defined and equal, report only sdom as tdom > is implied to be the same This isn't describing the behavior - tdom could also be NULL here. This is the case I think wants expressing in a way different from sdom == tdom. > 3. if sdom is not defined, then tdom must be defined, report only tdom > and sdom is implied to be cdom There are also no assumptions - see the enclosing if(). cdom is printed only if "a" is NULL (implying sdom and tdom to be NULL) or both sdom and tdom are NULL. Jan > Finally, as I was typing this up, I had a realization that I may not be > able to relabel the reference. It is believed at some point you could > feed Xen AVCs to audit2allow to generate an allow rule for the AVC. > Though recent versions do not appear to work, so I am going to try to > find a day or two to dig in and determine what influence this might have > on the change. > > v/r, > dps From xen-devel-bounces@lists.xenproject.org Mon Sep 12 06:46:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 06:46:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405448.647906 (Exim 4.92) (envelope-from ) id 1oXdDG-0006Vd-9m; Mon, 12 Sep 2022 06:46:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405448.647906; Mon, 12 Sep 2022 06:46:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXdDG-0006VW-6f; Mon, 12 Sep 2022 06:46:34 +0000 Received: by outflank-mailman (input) for mailman id 405448; Mon, 12 Sep 2022 06:46:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXdDE-0006VQ-Vo for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 06:46:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2967975-3266-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 08:46:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 06:46:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 06:46:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2967975-3266-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMq6+CkqdrAr42k5XudWqiAX90MYDbd32ZXKkzPiPyj3F2th+Mn0XknOH0sIbelcq/n24vwMDn2gJpk6bW5ushYuNVMvzUek9dB1y1gU8ZOljYaBborVHNFhorMRFJAyUzdrtKuUFJlBF5bvAtWP/HbFQ+MOevc6ioq8JOu7bt0l3CeIBdDVOVHTQrUb2c046S+mjQceewejGMKso8WrSOw3OJA7A7vWUJZZpW6CAiqcfxVPgn1nBVRfLEResueJySAFTRFf7Nw/EZ4FWpmb68sgGc0S1dVA3FTl0MjcTNXBaswWSU9poAI0razOnai27aEKaU4o87/7sCXMDuxyhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NbFs4FLfoe7rY9uiZUQIJxZ8jXRz6b8XdHmvqPqvCOE=; b=e7qseqA/a5TzRTAaIvkTjDIdPHWD5cSWsDQGWerL+WDWSrKuNDH5B2M8r9hGqQwtnzzkSCMgl/KF0Ewcw15TELULmfFEJ2NzsadzSQZ70bVx23z5bey1GCqkHRF2+6f9gjAzkaB4uJzDS/lM5BL48yXGdKCnWAWOgo9o2Dsq2A+gA0bkT5RngezTOKORFf2GKq0k7wSxYFdweE/kGVDJGsIxXpuzdwUdke23+Ya0kGHgd4jLX2E+Onl7Af2jFeo0z+Q+hddla+BBI6rdgLSrMaE5otc18H5kB2Ik+iqBkb10M7qjTwp/cjVjiyVWpt3WlCR/c9oRybx8FsZp5QxwJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbFs4FLfoe7rY9uiZUQIJxZ8jXRz6b8XdHmvqPqvCOE=; b=UCZpuUTb3Bs6wY7qaZKF96/MlST4sBL/apMLbrp02GHmLmlD1sDPmTL7ASBVHGhhMvyeiLTt3/VSAgXwg6GDreoAI5fkPLXLGVwm/Ga6XZKpPxdWnUUoPhOyQ2Wo7YaXbEGzNEojkAH4Y7TMzQkfy94+lPe31mWnWSfRYYs4xSQVNkD5Szhviq5//HkXSj8fg/w9oZIdg5I+NbjjJ72Yc823tQT5DsZzpo3OXHCkyIrjRWHeXo9JO/Oq+vyYwbJaUaZn98pGc1zHtDP2Aylh4NAo/mMEzpxt8IbUdkrJrVwDLDxD3cUaQdUHWIstxORubAItGWhGEt3A3897k3gs/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Sep 2022 08:46:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Jan Beulich Subject: [PATCH v2] build: correct cppcheck-misra make rule To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Anthony Perard Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: 7769b3c2-bdff-4bd6-d38a-08da948a8608 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vvpB80vfdOhGhmZPMcxwlzSpAddGkrnevzuRiUzbJ+vjHJYGMZjSJXlKPPAfa7k/1wNo7kk8Lb7PRPs1DpFH3+3PRuHeXQydSoDjz+glQbwoFNIrNkswoF0Poh8kiNpWsr5XsHPHIfh6mdrOo4TboTY2A1DtKPIbRfepdI4Cq8AwnZX08Ihre649lWPVRA0feBLYkEs4aVI2Qo2KD2girvjY5/dKWBNcYeXtRJCIFhjS6f2CQ3tgYMULsDmmwnLxICd9pYsWnFn7JgdrycI0+sIE4B74onmVK3/0Ler++0+f1FDyyrD4Tvt0bYL/aJHINW7qFs461NQ02rxZ8wUrC/eLfj4vEmu/rQhm583YWEMiVtgrUm6XobKfnGBHMUAJxFgkpPLyifRCXaeFG8GtvGyq0dSlQVPJfASawxlVakwU197JMgAl7d9XQk7CqW16Tj11sErSQv9XOuYS5fB2kH3WsGAhmRVZ0BMbWzn07QwJgyfE8Zrmr9VqbrhghLYZcx6ZIa8p6po9E4lhGTwNTFtbdWJV/PVU2Qaql9bttnH3TzrK2aA9uYQ/DA5cj+hf0VOgAU0gjSZ9v14Ng6RynHa9Lfobt/NkOC1UDNySMgIGqO6Ca7tFPj3gaJWjutkYLMn0JY/4wRqJQ1J3WWaZdEgbxwN7VhadAlD0LKCmsVkXIZfmg+t7O/3C8THIIBEqRAdtggMSiegSAsnMXFzNDFq98TVykXONyFJYs6OCkIYF2oKedUJCQc8zQAsEmd2l5jZZjirEHsFIPCFpO9xqsEGX++KFDpf1m3nHnGPJWqE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(136003)(366004)(376002)(66476007)(38100700002)(31686004)(86362001)(31696002)(4326008)(8676002)(66556008)(66946007)(36756003)(6506007)(478600001)(83380400001)(2616005)(6512007)(26005)(6486002)(41300700001)(6916009)(186003)(316002)(54906003)(2906002)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTU2Q25semhld1RQckxlWElCQ1AyaUNSbExGZ3pBb2pGdUVFMlJYdEJCdlI0?= =?utf-8?B?Yno1c2VoeFJFRnZDcCtFYWlBeENsNG5ZaUgzYm02NS93ZGdnK3dOMjRHanVI?= =?utf-8?B?Zk9wSUlmMnhuRWp5NVRjc3FTU2Z2RCtKcVFxNFpnWENIODVvR0k5N3hUTEY3?= =?utf-8?B?VVBQVmwxR3J5dFI5am5VQTdUVTExZXpJWGYvNGFxUFV1eER0TFNiNGx0Zk5N?= =?utf-8?B?RGRTaklBWXdCNHhQZlZ4V1Z0NmNFTGxvVGhIQys3ZmpQT241aWlaMWl6b0Nr?= =?utf-8?B?UUJ0UHNNdWFmQ2dxZEFFZ1NhUi9Pa2hFTWtZZEVFT0pDcHlTZ0dJSGJ4ZlJM?= =?utf-8?B?M1k5L3FobUp2M21JZGE5LzFsWUtEd2V3R1ZpMUdBK1hIUmdYYnpkUUdtT3RH?= =?utf-8?B?L2FEbWo4eVRJN29BY3poRW95dXhKbW1YL1BiUTM1NE1ydzFZVnE0c3ljeTl6?= =?utf-8?B?MnI3QzlFNk15ZXh6ZHRZWWRBRVJLVkQ4UGpyclZjYUIxNVNDclRIamxOK3hE?= =?utf-8?B?N3IyRDM0aUhQZlBkNVBEWVBFT3RXRUptMWRrdndPaGp0Nm1yYzB2cWlIT3gy?= =?utf-8?B?SEZHd29qQ004NTNKd0hra0YyR1FNQndCUWlPU1BFYXhUYlhZOHhzUytsL2xQ?= =?utf-8?B?bmtCeTFYUFA4YWwvU0FqODEzZDlmakk5WVlyZkV2Wko3MVF3ZVk0QWRQOEJT?= =?utf-8?B?eEgxTzV0dmFWd3ZuWnRpVzh6VnFVTVV0SG5kVFM5WlI2MHFVT3ZVWWkzUUM1?= =?utf-8?B?UWd1VHJrTFAwZ2dLWWJKUjZGR1kvS0JFaTQyTmtCTzdMSU9nOE13MHhobld6?= =?utf-8?B?QUNHQjg4NitCWTJGSGc3d1ZIRWJzTkt0NUdRalpwWFVMc2lJV1RwUmNBQkgv?= =?utf-8?B?eEFDMzFWdTM2N0Nia2ZwM3ozQVRzSWZucGtkbHZ6VXlmTVpRZGdwRmIrVDlJ?= =?utf-8?B?aG1jeXNVVGYzQnNTRmlFWXRPaFFia1RLRWVEeU1oZUlmTlM4TTJtVkRMK2lB?= =?utf-8?B?NkhweVlBM21PSE15eVJBNndZM1F6S1E3SHpHQngrTlhTeEpxZWdiOUJ4Vjlh?= =?utf-8?B?c2JmM25xeUg4OGhwTlpkVHkzMlF5d2NjQ3Iwb2hJeStwQ0dCWHdPVXlGaElv?= =?utf-8?B?MDQxN3hKRldRa1hpOXF2ZDl5ZmJkaHNlRi9VNnRuZTRjdUZiT3JyTWsreDRN?= =?utf-8?B?TXUzU0ZtWUl5NVJrWUtseFFiSlJ0c0NHaWNZTzhUN3NtVjd4U3FxQ2M4ZzZx?= =?utf-8?B?bnA0UUwxQnFKYldxaFdHUEhianpYNnR5eDE1NkxiM0NoY05tWWJPWW1GcnRk?= =?utf-8?B?NmlEUm1jMWtqZlkxeFd3dTlXRGlsek84VmtOY0ZoejhHaGM0czhqZzlnVmpk?= =?utf-8?B?YWNiWERaVUI4QVc0Y3BsemxRaGxOak9Xc3FqU01zMEtlbnRsMXRZRjQyeVBB?= =?utf-8?B?VzByRUdKZHg5VWlKRC80M3piYlRDWFRPWHNiV3lFMFVZZXV1bzF3Z0pNYlB2?= =?utf-8?B?UXFwR3FhaGJuelpPS2hiOWhWMzl2WGdYZlVPeXBaYmFJQmJabHZiTFVYVWV3?= =?utf-8?B?UE4rc21rQTFrY2JWN0lKcWg1YUVaa1VUajBMUE5ERkdIajdVV3pqRVREdVpO?= =?utf-8?B?b2xnZFByYjlLejY3cDBydllTNWw4cVJiT3QyM0hJUys1eE8yVmtTamcrSTJp?= =?utf-8?B?aHd3aGFTREk3Nzkya0JWVmVlYURjaUlmVXRqRXdMWGFjbjdmVmNMN1FJMFJq?= =?utf-8?B?WllWdncyM212akhrUTJ5cDhON0I4Sm1vNjdpVlNYWElWeUY2RUxSemhPUFV3?= =?utf-8?B?bWZyNzg5TU9WZ25YY3kyQ2JoVndxbjlyaWZJdlVPYjZ1SnZ6UFFYWU53N0Zm?= =?utf-8?B?ZUpNSGpTb3Fmb3ZVNkZxN2Y4clZ2RUhQQW9FajZmVks5UlZjNi92NVJoRUJB?= =?utf-8?B?SDBmMjZrT1NVMHVqZ2NPNzhuNEltWkhza2RSRHV1cjBTQ29HU0FVWWkwRFJW?= =?utf-8?B?MTRVWnpaZzF1K0hrU2JIVzhOUmpiRjZOczVhM1JQcEx6ZjJ1b2N5ckxzTE04?= =?utf-8?B?ZEFQVStFQnVYeUFacUg2R3ZWVUV6K0t1L2N3cWhOVEdjNlV3YWRBMzgzdENa?= =?utf-8?Q?Wd1sotAyZAGo16wP4rmWQG0i+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7769b3c2-bdff-4bd6-d38a-08da948a8608 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 06:46:30.2875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L+WO7xJrd5EIMZbRVdhTAL1UzfLtytZ0gieBgJt0FkYURneSnPRPZ+Fwj9IttFOKxOoV0YOq3x4aoQneAwtmEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Having cppcheck-misra.json depend on cppcheck-misra.txt does not properly address the multiple targets problem. If cppcheck-misra.json is deleted from the build tree but cppcheck-misra.txt is still there, nothing will re-generate cppcheck-misra.json. With GNU make 4.3 or newer we could use the &: grouped target separator, but since we support older make as well we need to use some other mechanism. Convert the rule to a pattern one (with "cppcheck" kind of arbitrarily chosen as the stem), thus making known to make that both files are created by a single command invocation. Since, as a result, the JSON file is now "intermediate" from make's perspective, prevent it being deleted again by making it a prereq of .PRECIOUS. Fixes: 57caa5375321 ("xen: Add MISRA support to cppcheck make rule") Signed-off-by: Jan Beulich --- v2: Add comment. Add Fixes: tag. --- It has been bothering me for a while that I made a bad suggestion during review; I'm sorry for that. --- a/xen/Makefile +++ b/xen/Makefile @@ -746,11 +746,12 @@ cppcheck-version: # documentation file. Also generate a json file with the right arguments for # cppcheck in json format including the list of rules to ignore. # -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j $(@:.txt=.json) - -# convert_misra_doc is generating both files. -cppcheck-misra.json: cppcheck-misra.txt +# convert_misra_doc.py, producing both targets at the same time, should be +# executed only once. Utilize a pattern rule to achieve this effect, with the +# stem kind of arbitrarily chosen to be "cppcheck". +.PRECIOUS: %-misra.json +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.txt -j $*-misra.json # Put this in generated headers this way it is cleaned by include/Makefile $(objtree)/include/generated/compiler-def.h: From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:11:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405503.647934 (Exim 4.92) (envelope-from ) id 1oXeXc-0001mj-8D; Mon, 12 Sep 2022 08:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405503.647934; Mon, 12 Sep 2022 08:11:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeXc-0001mc-4z; Mon, 12 Sep 2022 08:11:40 +0000 Received: by outflank-mailman (input) for mailman id 405503; Mon, 12 Sep 2022 08:11:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeXa-0001m3-Vq for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:11:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150041.outbound.protection.outlook.com [40.107.15.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 82103183-3272-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 10:11:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8325.eurprd04.prod.outlook.com (2603:10a6:20b:3f6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 08:11:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 08:11:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82103183-3272-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YM63gipaD2auCeehwYlzfC4VrE5B7SC3J7i20sPM1S8HkzGYhrBhYnE+INKgP0Ma8tI5gAhKubwjpQCEZzPo9RHZPGPnAzk67VL62MvfjY1/jtwtUqReMMaOSwqVLUOG48Jao8qSU0RN52r0OJeGz5HgqSUwg46wOAcBuHgbNLxcHzPOtmQmT7mjeqDZY+4tVTeYeQMRB0c31r+orh56gEeozCzKqEp8a32aVlSsgc3ioRjYHVmxmL/o19JLmb0dZWBCmTG+c2i5IIy4i+bZeJu82Aqhz0FQ6YSuqDDzso+ZwgbN9LqBvn9itXf6bqk31y3n6AT+fuU6hggMpvwbOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=emMbKCssggZ0MZ0oNAde9DnrhL345ZbHg7vU6va+QGI=; b=kxF+SdQR6wgMgOgwf25frhuac0eOYatWnm/hxyAbh5DgPfsYZ8an7o0NrJRX2/ql/CjE2R0dAASVGzIyYj+5tXeJ9znY+YgPQM3/h5MuoCVmAuIgjuNMElb7M9LogxpK8CVdbyxDfc99fqTOg+vZptD8Gg1Yi1pnp7pqeb2T0oWi6WcshAFRqPmTpcefzRZOXBdyKEDeaB9oIz0O2IFJZQpwI3hZB5AhhnIKcqBzRYkhSWtahqDV7XoXFwVETBNpgm8twGR3VVjq/y9kToJl5fDYPku3KeZwfuZNcagHLwV5zZKbczAQEoLiwInvX3KyclWVuwFoNEtHLShyd0mJLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=emMbKCssggZ0MZ0oNAde9DnrhL345ZbHg7vU6va+QGI=; b=rQicN7Je3I3jywOJS+OsRX6sIwgcGC9VfFQ50loCeM++8fwiuQDAH/a8EYgAO55Xr0QhgZWJGOCRA+lltnrAhBpN6wcSLpeu6HF6QrvhQY1o0rAxzpS219hdaufJ9fmpApw4KBE7+BiMZhe2ThTCKqeNXSVfGnNswVT24yLGQZdYei3ZkKnS83w93gvuizPQJL8ydG7Sl6H+ladm5dG9itzypqizqyOQiLs2Owzdrs5CFwcDJhJjq6ICQgMktXnVeB3QL+uVegmUK4eLy3PcsO1A5ZTFy3eZyzhdk8uhM2ufz4PSxJZ+9x1gaWvDUTA4kS4B/0WxREh2UKldtJXBeg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2241c6e3-74fd-55f3-6de3-93f3733baf2c@suse.com> Date: Mon, 12 Sep 2022 10:11:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/2] xen/gnttab: reduce size of struct active_grant_entry Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-3-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220912055356.24064-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8325:EE_ X-MS-Office365-Filtering-Correlation-Id: ea0c8710-5fd7-47a0-e8c9-08da9496691a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x0Kwa5fiS7T3O9SoIXnazwbwKhel0OuzOTZxWrNnfudUWbxGsG2MQ2+JD1U0liEKU0+g7z6SINt+FD2SsYiui3Ls5wO0S24kwYHVRePuT6L3ILmIX/LuH3JDeZ8BxQ9pgMC22GcrU5CMEjkmm+msPkez61lqK4ZOD72cSAIfZUsvL8WHZeBCxbt/OJPfEDf4HYfmO0UexRsujwdFTLn/3vwO9EBOaMI5BdLNxtubPsSaBX/FRlnjcdGSdSFApzOXXTp02XzIUeh2JFgqBjeo6O6/lVyD2SwSQk604e8CGBdF0+tgeQxCbfiJLlbjsj5X3oPQuUwQl8YBvtyQopk07VnoAwiBGMJzPJxIYCQd+cwvYzAHgrgGA6Rqfa/EbFbSlNwDUYcwtnhfdWPGLRapQby9KahNR1TWHzAg9l4QvE0TeGej2iatMCG3sn6kh5Jn1VNmTdjORnHJ1ef+J/CWNwiMAb3zvKPcO8BhVa7/omLgK6rJUS0TuRcbV9ife4WsezzpkzzKnIRrqp4YxxdGD3BsVhMMXoCm6EwdHw8KNIjbFIx+x5opDeo+pgOHm+tiIUtqkLT7DeE9JF2UQksU0XNgqf8jB/Fdyb/kOphAlHERsi0iyQp/g0haVXYazFc6HWK41WBYNDJGMQ34uyCHGk6jw5rIutJIgW8KTt71k7dhBNqpErrDKYjqJxL7p4zGQDSX65gWgwYaSD9KS4w0XWANCwesWLbftlocY7pqAtTK5czTIV25sIiQg3lhQbR1XdgXbHTy9nKuD1zdHYtGrHnbvJ+sCc7K25PODfSyVNA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(136003)(396003)(346002)(376002)(2616005)(186003)(83380400001)(38100700002)(8936002)(36756003)(31686004)(316002)(6636002)(66476007)(66556008)(6862004)(2906002)(5660300002)(54906003)(4326008)(8676002)(37006003)(66946007)(26005)(86362001)(6486002)(6506007)(53546011)(478600001)(6512007)(31696002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnEvVUR2dHEwTmpCaFU0V0ZKczJpRDVFOU1SekxjZ1ZDZk0vRDgyaU1hMDRJ?= =?utf-8?B?ZFJmdXpPTXBBYUJaSC9pamNFdXpTcXZ2SE9CdnBPNUJMSmEvTjhZNUlXVmhj?= =?utf-8?B?VTVvdFVscGRtdzJFbG10eDVSY09XbUhjSFdWUVdscGhNYXkyUjVacWsxWjc1?= =?utf-8?B?M0xWOTExbDFpeWQ0N3M2MHhESFZZNzcrcFNQVTFHVHMzeHRjdUNYQ0NWZHBr?= =?utf-8?B?RHVDU0t4ZkZvRGxjMmhHdnpKTVBxQ1E4RDFlenJSbW9GcWpCczlWQXZuUjFk?= =?utf-8?B?UW54ajJNM3dVUUFiRWRzYzA2OTYxdTZFUDVvamVkQmVPSVBJRWVVdmtlVEo3?= =?utf-8?B?cU9wTFBTSVJscFVOS1BZa25KZlFqZjVNTjJMNDNRSUtGUDBUOEl0Zk1KNGU0?= =?utf-8?B?dExKRFEzeForR1M2ejROQU9sSFNGa1NxSGk1dXhpODFOTE9mUTM1STk3WUFX?= =?utf-8?B?NGsyR3lMY0lBRkk0SkoxQWg1YnpqNmpKOXRSQ0V5c2ZGOXhIVFZyR0ZJR0hF?= =?utf-8?B?ZGpVbmN1cDBqdVRVaFNycUJTSHVMc2x5cXlhc2dkS0dHR011OFZYSHlwZ0U0?= =?utf-8?B?WTk2UHhOY0dGY1hoMnU5dmM4RXpta0lsbGZIWTlSUjBnT2RERGI2WUh5aEdk?= =?utf-8?B?VVFJLytWcWx2M1JCUE95TE1jR1NOWUVlQmMrWEtSMWUyUTg4WEhoVW9CTVJx?= =?utf-8?B?Nll2bHkweHJOTDkxdjB0RHNXb1c3Q2FXSjZYYUJWOUw1SUJ3THlQZDRBZHEv?= =?utf-8?B?M3lvVG1laXRmcU5pMzdyMUdWbkErbURDWmZyczZ3UFpxd2VWSVhETGhCbFU5?= =?utf-8?B?SFdnMU9YeE43cVJ2akpiNUhCZVE5NkNaNnhvTnZmWGcxMTgwSWZLc2xza3hr?= =?utf-8?B?elN1d1BPTW0vZ2ltWlhjcTBWRU9SWHBYMTFRc1E4Z1pDek55c1gwTlFmRlpW?= =?utf-8?B?UzhOTnpLd29iNHFidVl3RExHQzFFeEd6WU9naytNQUE1MjVnZTRiM09jTU9v?= =?utf-8?B?OUpEN2pVTzUwbnZSYXg0ZkpqbHpFSU5IQ3Nzd3FaUm5xUFltUjM4bUNsQ0Zw?= =?utf-8?B?SzhWL1ZCR1JrRzQ2Rno2QUVQUXNsdjViZHRRRUw2V2Ztd291U0dJOFlCc3lT?= =?utf-8?B?OFFOakM5L1NGTWtqNERsYmR6WmdhaldQWmVwVWxXRitycWZxU1NkdVdxNlRu?= =?utf-8?B?TWxud0I3bEd6VFN2dUFVbmxyVWtOa0pJODRIcUFJL2pKU2FCa2E0Vld2dW1k?= =?utf-8?B?VW5ZcVFybUdPNUl5Y1VsNWgxOUZaZHdhR1RZNnVhMEw0ZzhtOHFHMnliSGhq?= =?utf-8?B?TmxDVmNzZlkrT2JKRHNKVTZlQWxKMFFBUmkyK1lWUGxsKzUvTGhZNjZQNmZu?= =?utf-8?B?bU5wOWd6cytNQytKVklJblErYmVjS3ZZR1BGc3Y3Q0dyTUNsbWx0b3BOS0tE?= =?utf-8?B?REh2eXhhSVRuaVJBWHpMVmdIUytTZG9OQ0lSSTFCOEZuYmxib3FiNkJXSnVR?= =?utf-8?B?VldmV2dORGtEK2lUV3RWWk5XL1A3YmQ2dEdwV3BYMVJaNzdkbDRrbCsyckU5?= =?utf-8?B?NnZZMjFCSHVTREpJVlluN003eDYvelFSL0FJeksxSUpkSG02QmM0SFQxVGl1?= =?utf-8?B?MUNHNGc1NExMdXBCZmVYSnRWbjJCWnhyR0ZZR29RR1ZWdmQwVjViUXppdXFY?= =?utf-8?B?M0dDbzhNT084TFA5YXZNc3RDa3h1b0cvMmpSeXJ4aGwxbHM1MFpDUFo3WS9K?= =?utf-8?B?Nlc3V1FGWVpGSzhvc294RXVodmpLYVh5S1RUeGh2TmZLSm9MSmxmKzVjT2t2?= =?utf-8?B?eHhSaWdWZkpuNGRyUUk2YitxdVBGK2dFQ0lad1BCMXZzSVl1U2RqUEFRMXdD?= =?utf-8?B?cE1SSEw4WXJ1dkpMNnpmWTBGdmlDTlNlYmh0aUtUL3NNbm9YYkI5RHFTRi9a?= =?utf-8?B?WFRVc2tVUEh6VUZ2dzZBSDc3b3RzRDQ0SjdYSTl6c0FJUEhaSlhRZ2dWcGpS?= =?utf-8?B?R1JLbzlCZlVyMFpoYmVZSG9ldnREU2k0dTJPc1FjVFNvUWR3VzFyNkdUUWp3?= =?utf-8?B?R2xRMTR1WHNVUmttRmN1anlXZXRWRWRtY1lTNmpCSksrNW1tUVliS1ZYNEg0?= =?utf-8?Q?SUaQS3hqjfcpoNA4YkuNAY5uP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea0c8710-5fd7-47a0-e8c9-08da9496691a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 08:11:35.7285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EMOrqMN5Hs3sbKsQQp643vLc43meqiOb/GZ0qUyAueji+dsU0aIiamcI/SNNJbe5CF1xLLR52W7PdgSv8QNvhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8325 On 12.09.2022 07:53, Juergen Gross wrote: > The size of struct active_grant_entry for 64-bit builds is 40 or 48 > bytes today (with or without NDEBUG). ... and leaving aside DEBUG_LOCKS / DEBUG_LOCK_PROFILE. > It can easily be reduced by 8 bytes by replacing the trans_domain > pointer with the domid of the related domain. trans_domain is only ever > used for transitive grants, which last known user has been the old > Xenolinux branch of the Linux kernel. That tree used grant transfers, but I'm unaware of (actual) uses of transitive grants; there may have been code there to allow their use, but iirc that would then not have had any users. Or am I mis-remembering? > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -381,13 +381,13 @@ struct active_grant_entry { > }) > > domid_t domid; /* Domain being granted access. */ > + domid_t trans_domid; /* Domain granting access. */ I'm afraid I consider the comment misleading and not in line with field name. For normal grants this is merely the "source" domain (i.e. "granting" in the comment is correct, but "trans" in the name isn't), while for transitive grants there are two domains granting access. Therefore may I suggest to use src_domid or orig_domid, or otherwise omit the comment (just like there was none originally)? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:20:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:20:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405514.647946 (Exim 4.92) (envelope-from ) id 1oXefN-0000QA-EZ; Mon, 12 Sep 2022 08:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405514.647946; Mon, 12 Sep 2022 08:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXefN-0000Pk-8P; Mon, 12 Sep 2022 08:19:41 +0000 Received: by outflank-mailman (input) for mailman id 405514; Mon, 12 Sep 2022 08:19:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXefL-0000Pe-3M for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:19:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a3a6ec3d-3273-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 10:19:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8964.eurprd04.prod.outlook.com (2603:10a6:20b:42f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 08:19:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 08:19:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3a6ec3d-3273-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4m6Vz5ft/AVcWqRS1TszydO44aaAprXYDZ/BUwVj9q2VdH6OEYTmLvZ6YRo5LM+oqx+UE+8b9KaboKmj04b1j5kfiB745b3u+8O7x3AC4SUakV6KHdhs68fpSTTn3GsTr1LfrdqU8cMEE4F6BLdI+5hCrOnNqBF3T6LH1jWSU0O76TE9q4T4XvCHCdUt+V4ViwSGw9buUy2Ttc1rwOM6sIIKeHB7bvVU5Eqwn3GPGJVtSEbh/33Ipmbjc2MaduYPMaIxQKkcpj7fwcB1nEa1Z6mRbrA+WPM0HRBUzbFBN5+I7EwGjzYjqgRXz3a+nwGw+e1WRbtwUd9qyBb7OCN0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5CpTGMLyLtXeWbDHr5OLNdMgVmEoioIN6kAE9108s98=; b=JiMZve/LLXa9Go1moKswPIHMORE+7FIBUgP7ws6FaQ/tJDf+IrQp6XRVIbF89L1mjMn5qzgcEo4RrqBrEFOFk0n5bX3JRFd0wFi4NzmuuZ1PUc1MLhZ8gbjiFbyXb3H44R6kAKX/oLG9hKKkwqIagHeRYirAmB3lByYa4C/9dZDrI8u1PfBtVW9AG8yqCojues0pA6DdWgOjm7viEClSCFYpWfb1UrxMdW/2n+rG2CEsBHSHKa+uC+3G+8s4kUfD57CTNx8DZvPN+Ka1tv+aV+ppYNvWzRUrNhavoRMRpLIzBToTXLRejHUMYWTmcyzGFJNPX6T8UvPeuRUubZQvMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CpTGMLyLtXeWbDHr5OLNdMgVmEoioIN6kAE9108s98=; b=RlZC1PEBfAp3/ZqNjbzax1WRD5r8qpBkx7iAzAFlEis0fWIothEMm89yQkMVO5UDg3HXJoDkEJkik1s3V5S5J0CFdwUCkDh3X2CCHRmLd3VeWicBUxk3rE/58/CXfkopekcSCEjQU8mhGCrtONLOq4KVoy+ZxK/7M2yg/pGZNnE7jU1BxXugWhjXEuGO+BvYSqtNaBaheFrK07dvyEmvvZR704UzTMu+ixiAzC8Ca6E/qVsLQEo1FqcZdXSCdy/UQiA/DVI2G1v+cJ6msVQIxw8tFwDxx6gt1X5ag65TBLow4jKqND8enog5MmzzEIREIDKFh8OVSFlhT7zScbvNJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Sep 2022 10:19:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220912055356.24064-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8964:EE_ X-MS-Office365-Filtering-Correlation-Id: 27a717cc-3f75-4391-8ec4-08da9497870c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qPSuSFkaQuj2LVTG5CnKxTPVkBdSkGnWefhswKGvEm7AG/tSAK3HYQcnJwfx8fyw1dR+9+0Z1jfRDNEpGeIIdVbkvqJzWFYINk3egIExGrYOjMY93+wa2yLGNoICXb7mPg3g7ZXAUY/0hYUos04mNPOqhXjGi71u+FdJ7Xu49Rp8IUgKZgIv5mCqm9GsAQlLk8f1W5aCyKHqKLPoVkBC+E2oNymrqnN3zf1sc9le8Rs23iiBZGiMVO3+7UTU8qNsnwT6zyNaZkddU32qTVxhVGbaUlWfkhMkGAh0EAmP08rrLdIQgJvWNN26wSl1QP5PH+iTJ7dLc1rf/eNCkU8qFJQlKtvRSemSGkZgSMgRqFNIATMvQFWVFVnK60uuxbkhH/TM0aGsFJ6JJMl6Ny9LMkr29xcr2s0I6aTSbVAaeR5kYqDNvIxBsbwiSM/QpFitXkMNgpTMnp1GRYLH7I9QdjpkvH9qrJ+2sTWGHS0t3w5gQCfHex5QVQ+Qy0x1u6TqYfhPP08ytTcW0rMVOyufF+im/IvkaXcU3xQTw6eT5Kt4IicWF12+3J4dMc5yq/QFpd2h6ROrvZ1h8wtez8bEgpFr1gv7apWLxq2FNAY+TD9lZ4nuVxZFLkMmjT1PiBx9396f5PGqvrVkDQtaEi8LwnokYHjf0M9IJHGq/c9Cfe1b/w5WnpOipHJKEgbcQDctG88S6ZxhU7HKzdLLHzhrr8cz4A5ycWqS/Epvwz79TojOoZfweXby1Xeg178r/AGQ5NGttfH6lnYCHEPq9OJBL3d0Ob3kCfCNg161zGaP5yU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(376002)(396003)(136003)(38100700002)(8676002)(66476007)(66946007)(4326008)(66556008)(31686004)(31696002)(86362001)(36756003)(83380400001)(2616005)(6506007)(26005)(41300700001)(186003)(53546011)(6486002)(478600001)(6636002)(316002)(37006003)(54906003)(2906002)(6512007)(5660300002)(6862004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDRodUNZTkh5S0VXVVV3eU5XT0hYYjFHUVNkczdzNThrTVh6MDJVQ1djOVVG?= =?utf-8?B?WFhKQ0JpYjgvZ0E2cnhMc3p1RnJQUnF0UXQwUzFDUWdhcE5aNG1iSDNDLzNY?= =?utf-8?B?WUk1ZDVLNkZoRmpKdG1oK2d0YTh4dERnSzM3cFBWUmU5WGlKK2t2ZkZzcDBG?= =?utf-8?B?SCtZaC9rdittVFlzZG5lOG5GTTlGUFBWUUowWEp4MVhEVkppQnJzWWlDNUhR?= =?utf-8?B?L3lvT0FLSDQrM21JWU5jWmdvU2RCTXJyQXgvYTc4VVpDZlFsTVZhL1BjU3lx?= =?utf-8?B?RGErWENham1UZEU3MUR1MExFa05ESDBxWHRYK1pPMStHeXhkY05sYnVWT3Vu?= =?utf-8?B?U0t1WUxNWmt1Nkc0Wjc2V3pKRVJqQmtsbW4yR2VYV2RSZ3gzQVl1Vm9FcE5p?= =?utf-8?B?ZHZxUGwyWGFPQ3lhQmZrdzRZOU1RMUNwWmlvYUQ3RDgrV3FzMkRDUWZHd1VM?= =?utf-8?B?d1p4QmM0U3FGWXZpc3lwZnliaHRBcUlkbWFwU0gxYzRoa2ptaFE0Y2N6L3NO?= =?utf-8?B?UmxaSVlqYVpDU2piaU5QYjVEVDZxMFVNRlcxaXBxRFhmWHVMNWd6bndyQjRr?= =?utf-8?B?UVo0T0Y1djAxR1BDUGZyTjZNUlJnNkVxRnNwMmxkY0VsTnh5dE00NVJHMkhk?= =?utf-8?B?Y3l3V2huTnRYTHkzUndBSDYrSWdPNkdtRURrSldkbzJYYWlMT1hvbjdMbzJ4?= =?utf-8?B?S0dzSnorSngwSStqV1NGWXQyUVdjVE1jY3gxcWJhY2FLT0JEaGhPOWFqYXd3?= =?utf-8?B?cCtEYnAwSzRhMFlWRFkyaTh5SnAzSTF5VkR2djBndFprNythSTNlV2ROalVO?= =?utf-8?B?Rkw0Wi9jOHFYVFVvck5aYTFHRVQ0RVV6QlN1dS95MXNkZjhhb1JqaHRyNWRy?= =?utf-8?B?UXBTYUJWWWR1RXU2azFMZ21ycHVBMUFMOFhwWUYvaFAzckZFMm5oc0hCM1py?= =?utf-8?B?Z3BZdzcvVVVzRkNDMC9CVHBnSGFBTThvRk5Cb2s4U2szQ0t6YStEa0JsblV3?= =?utf-8?B?QkE1TlcrTGNSQ0Z3N2tMWWVPaldxUVc3NUJvQ3hVSjI4em5LWkRtdGYvUTVP?= =?utf-8?B?NDRyMmhMM283Ni9lMXYyY1Vlb0pQQVdlTjRrWnByNHg2TDR6bDN4N1pTaDJs?= =?utf-8?B?TnRlditEYWhvb25FeFJGaW5sSmVRRkRnVmh4OU5ubkhGMTR1OVFzODJCY2d6?= =?utf-8?B?cXlhZkwwT3JaS3NEcEs5NGdTdFFpc3k2RUVXYTJJVjlYemxPclpXMjBPYzhT?= =?utf-8?B?NTVRVlZndjV0RXJyR0xHTzhSQm1WclMzMlBMVEJPRWhwWDBxOGdLVStoSHlN?= =?utf-8?B?YWM3ZHRrREU4NVUxdjhnWFEzamZsdnFreFRwSVd6WnJTNkFwa2crdFpkTU5P?= =?utf-8?B?OVRqNm5QR3NPbGZhd3JpWVRzbTRhVE5JaTNQSG1LNkNrVlRhaDdaTXhsZE5N?= =?utf-8?B?aG43NWdyd0VFdTlvMTJpemQ5YzJGV1dVZVUvb25qS3c4eGZnRW9NNmQ4cGZV?= =?utf-8?B?eFNUMXAyQlFJTmp6VGFydFZwWlF6aUcvUTNPS3k1NEVDbVk0b1IvNkxvdHpp?= =?utf-8?B?ME1BWjFYSnNoWnVsc2FuaFdCZDVZWk0vdWU5S3k3cGRLdXM0bC93Q09jeGZP?= =?utf-8?B?Q3R0b2xWblZkRnVEdmROYzV0Wjl3NnVQMkx3dmk5bDNvYXUwUnR5K0lLMnhT?= =?utf-8?B?d1JaTHppUDJ0eG9HYVdZSGtPZ3FJQWpJd3lQWVgwNUM0L2VwWWVkYW1BZXlB?= =?utf-8?B?d2JRa3V0c3doRGw3dXB2UjdObzhnTXY1K2lnWWhjTTJZNDNEbXY5WWY5azF1?= =?utf-8?B?UU5OcjBRQUFBWWdxMnBDMG9mUk54bWxzTnFOQys0eXBuNm1PZGUzUWFxNTJx?= =?utf-8?B?Z2R1WXRBWktsWXZSWG1LUHFKcHNGQU50RGdoYWd3Y0Q4K3MyNUZaUmFUZzVq?= =?utf-8?B?Q3VSTitmUmFOamFaNThTdnFScS9mNTNEem5YYUNmRCtqck1pZ0FwZU1PL0FB?= =?utf-8?B?NHBYMUhnL3RKaGJoOTBnRmRETmRPSlVQVUFLL2Y0TjNiRzljWUg1K0M3ZE13?= =?utf-8?B?b3hFNFJmR0N6VmpYc3BGRGREa0E4TThxbXlLeDZHZ1BTVmZyWGEyV1FzUjRI?= =?utf-8?Q?OHXbk92ngrG2ftiz7sMOhMQxn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27a717cc-3f75-4391-8ec4-08da9497870c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 08:19:35.4003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yEpmYv0xy2UBSmXVS5LHpuqxmZtFPJ2aPY6ktphp9thrHB3/kkasAHReco2m85x1o8XNXzvTEC1RSbSvAOgMeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8964 On 12.09.2022 07:53, Juergen Gross wrote: > Add a helper domid_to_domain() returning the struct domain pointer for > a domain give by its domid and which is known not being able to be > released (its reference count isn't incremented and no rcu_lock_domain() > is called for it). > > In order to simplify coding add an internal helper for doing the lookup > and call that from the new function and similar functions. > > Signed-off-by: Juergen Gross I don't see an issue with adding such a helper (responding to your concern in the cover letter), but I think the constraints need to be empahsized more: We already have get_knownalive_domain() and get_domain_by_id(), so how about naming the new helper get_knownalive_domain_by_id()? And then ... > @@ -859,20 +866,27 @@ struct domain *get_domain_by_id(domid_t dom) > > struct domain *rcu_lock_domain_by_id(domid_t dom) > { > - struct domain *d = NULL; > + struct domain *d; > > rcu_read_lock(&domlist_read_lock); > > - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); > - d != NULL; > - d = rcu_dereference(d->next_in_hashbucket) ) > - { > - if ( d->domain_id == dom ) > - { > - rcu_lock_domain(d); > - break; > - } > - } > + d = domid_2_domain(dom); > + if ( d ) > + rcu_lock_domain(d); > + > + rcu_read_unlock(&domlist_read_lock); > + > + return d; > +} > + > +/* Use only if struct domain is known to stay allocated! */ > +struct domain *domid_to_domain(domid_t dom) > +{ > + struct domain *d; > + > + rcu_read_lock(&domlist_read_lock); > + > + d = domid_2_domain(dom); > > rcu_read_unlock(&domlist_read_lock); ... extend the comment here and in the header (or perhaps one in the header would suffice and the definition here doesn't need any further comment) to explicitly say "reference held or RCU-locked". Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:21:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:21:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405527.647956 (Exim 4.92) (envelope-from ) id 1oXegz-0001wN-QB; Mon, 12 Sep 2022 08:21:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405527.647956; Mon, 12 Sep 2022 08:21:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXegz-0001wG-Na; Mon, 12 Sep 2022 08:21:21 +0000 Received: by outflank-mailman (input) for mailman id 405527; Mon, 12 Sep 2022 08:21:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXegy-0001w8-Um for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:21:20 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1144e1b-3273-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 10:21:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5E6A0226CE; Mon, 12 Sep 2022 08:21:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2782A139E0; Mon, 12 Sep 2022 08:21:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id X2XrB//rHmNsJgAAMHmgww (envelope-from ); Mon, 12 Sep 2022 08:21:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1144e1b-3273-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662970879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7vmXbjdXLGxV9NpKCL417Hzt61WIiRyvRp+kk2oMR3s=; b=EDT8ela3CEBzqspkmYRt5qOqkyHcp74fXIE7PLYK9cX7qyh1CgmkisA/mQGO1yCrV33Syu pP7SfBrguPlMLHxHecFM5u6ERUKwpSJibGH+0RTDl/H/IIKkDtMjqWObEhRbPGazSXQ4Da PmFh5euXuF7ejlpHeUeIszLRhvFmvXM= Message-ID: <20d6999d-abd7-3d5c-7203-1bf986159f3b@suse.com> Date: Mon, 12 Sep 2022 10:21:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/2] xen/gnttab: reduce size of struct active_grant_entry Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-3-jgross@suse.com> <2241c6e3-74fd-55f3-6de3-93f3733baf2c@suse.com> From: Juergen Gross In-Reply-To: <2241c6e3-74fd-55f3-6de3-93f3733baf2c@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------NG207YcL0IUjp5jQCQVpNp5q" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------NG207YcL0IUjp5jQCQVpNp5q Content-Type: multipart/mixed; boundary="------------yiSQ76pz30eAViSuijKCHTRq"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <20d6999d-abd7-3d5c-7203-1bf986159f3b@suse.com> Subject: Re: [PATCH 2/2] xen/gnttab: reduce size of struct active_grant_entry References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-3-jgross@suse.com> <2241c6e3-74fd-55f3-6de3-93f3733baf2c@suse.com> In-Reply-To: <2241c6e3-74fd-55f3-6de3-93f3733baf2c@suse.com> --------------yiSQ76pz30eAViSuijKCHTRq Content-Type: multipart/mixed; boundary="------------QPqB0Fe9zFfMC2fiFeCqAcOg" --------------QPqB0Fe9zFfMC2fiFeCqAcOg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMTA6MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMi4wOS4yMDIy IDA3OjUzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVGhlIHNpemUgb2Ygc3RydWN0IGFj dGl2ZV9ncmFudF9lbnRyeSBmb3IgNjQtYml0IGJ1aWxkcyBpcyA0MCBvciA0OA0KPj4gYnl0 ZXMgdG9kYXkgKHdpdGggb3Igd2l0aG91dCBOREVCVUcpLg0KPiANCj4gLi4uIGFuZCBsZWF2 aW5nIGFzaWRlIERFQlVHX0xPQ0tTIC8gREVCVUdfTE9DS19QUk9GSUxFLg0KDQpPbmx5IGxl YXZpbmcgYXNpZGUgREVCVUdfTE9DS19QUk9GSUxFLiBERUJVR19MT0NLUyBkb2Vzbid0IG1h dHRlciByZWdhcmRpbmcNCnN0cnVjdCBhY3RpdmVfZ3JhbnRfZW50cnkgc2l6ZS4NCg0KPiAN Cj4+IEl0IGNhbiBlYXNpbHkgYmUgcmVkdWNlZCBieSA4IGJ5dGVzIGJ5IHJlcGxhY2luZyB0 aGUgdHJhbnNfZG9tYWluDQo+PiBwb2ludGVyIHdpdGggdGhlIGRvbWlkIG9mIHRoZSByZWxh dGVkIGRvbWFpbi4gdHJhbnNfZG9tYWluIGlzIG9ubHkgZXZlcg0KPj4gdXNlZCBmb3IgdHJh bnNpdGl2ZSBncmFudHMsIHdoaWNoIGxhc3Qga25vd24gdXNlciBoYXMgYmVlbiB0aGUgb2xk DQo+PiBYZW5vbGludXggYnJhbmNoIG9mIHRoZSBMaW51eCBrZXJuZWwuDQo+IA0KPiBUaGF0 IHRyZWUgdXNlZCBncmFudCB0cmFuc2ZlcnMsIGJ1dCBJJ20gdW5hd2FyZSBvZiAoYWN0dWFs KSB1c2VzIG9mDQo+IHRyYW5zaXRpdmUgZ3JhbnRzOyB0aGVyZSBtYXkgaGF2ZSBiZWVuIGNv ZGUgdGhlcmUgdG8gYWxsb3cgdGhlaXINCj4gdXNlLCBidXQgaWlyYyB0aGF0IHdvdWxkIHRo ZW4gbm90IGhhdmUgaGFkIGFueSB1c2Vycy4gT3IgYW0gSQ0KPiBtaXMtcmVtZW1iZXJpbmc/ DQoNCk9oLCBtYXliZSBJIG1peGVkIHRob3NlIHR3byBjYXNlcyB1cC4NCg0KPj4gLS0tIGEv eGVuL2NvbW1vbi9ncmFudF90YWJsZS5jDQo+PiArKysgYi94ZW4vY29tbW9uL2dyYW50X3Rh YmxlLmMNCj4+IEBAIC0zODEsMTMgKzM4MSwxMyBAQCBzdHJ1Y3QgYWN0aXZlX2dyYW50X2Vu dHJ5IHsNCj4+ICAgfSkNCj4+ICAgDQo+PiAgICAgICBkb21pZF90ICAgICAgIGRvbWlkOyAg LyogRG9tYWluIGJlaW5nIGdyYW50ZWQgYWNjZXNzLiAgICAgICAgICAgICAqLw0KPj4gKyAg ICBkb21pZF90ICAgICAgIHRyYW5zX2RvbWlkOyAvKiBEb21haW4gZ3JhbnRpbmcgYWNjZXNz LiAgICAgICAgICAgICAqLw0KPiANCj4gSSdtIGFmcmFpZCBJIGNvbnNpZGVyIHRoZSBjb21t ZW50IG1pc2xlYWRpbmcgYW5kIG5vdCBpbiBsaW5lIHdpdGgNCj4gZmllbGQgbmFtZS4gRm9y IG5vcm1hbCBncmFudHMgdGhpcyBpcyBtZXJlbHkgdGhlICJzb3VyY2UiIGRvbWFpbg0KPiAo aS5lLiAiZ3JhbnRpbmciIGluIHRoZSBjb21tZW50IGlzIGNvcnJlY3QsIGJ1dCAidHJhbnMi IGluIHRoZQ0KPiBuYW1lIGlzbid0KSwgd2hpbGUgZm9yIHRyYW5zaXRpdmUgZ3JhbnRzIHRo ZXJlIGFyZSB0d28gZG9tYWlucw0KPiBncmFudGluZyBhY2Nlc3MuIFRoZXJlZm9yZSBtYXkg SSBzdWdnZXN0IHRvIHVzZSBzcmNfZG9taWQgb3INCj4gb3JpZ19kb21pZCwgb3Igb3RoZXJ3 aXNlIG9taXQgdGhlIGNvbW1lbnQgKGp1c3QgbGlrZSB0aGVyZSB3YXMNCj4gbm9uZSBvcmln aW5hbGx5KT8NCg0KSSdkIHByZWZlciB0aGUgcmVuYW1lIHRvIHNyY19kb21pZCAob3JpZ19k b21pZCBzb3VuZHMgZm9yIG1lIGxpa2UgYW4gb2xkDQp2YWx1ZSBvZiBkb21pZCkuDQoNCg0K SnVlcmdlbg0K --------------QPqB0Fe9zFfMC2fiFeCqAcOg Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------QPqB0Fe9zFfMC2fiFeCqAcOg-- --------------yiSQ76pz30eAViSuijKCHTRq-- --------------NG207YcL0IUjp5jQCQVpNp5q Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMe6/4FAwAAAAAACgkQsN6d1ii/Ey9G lQf+JG40vDsudt8mAkX9ZmYZbEhgqOVaGHX7i0zX5sGVNzBqvyYB6B3jneMJGNSlJyLing4M3gXA bs/ghqEuzagulZ7Ujg6xKt/ucai21d+tqhnEG2NBxxwhnQIaRwdAIXmWjYHl0xW4gw67THfHPilm Fhbi1qsYhidIiTHbuRXhRRmx0UBN1kPp2e2b6ebbwS4bH0OKX/Wih9sy8sSkiwcoapdG0LcT+PXo fE147Ava6XXDG5Iat0sH3zFaOg03MYamMiHXoxNPjg4GZc7obQlg8b3Kfw5/KIzUDl3+5s2dRCM0 khRGhZfbP22YHbix7NeqxhVdzOu6OI2lVWkAcBD67A== =3XlP -----END PGP SIGNATURE----- --------------NG207YcL0IUjp5jQCQVpNp5q-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:23:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:23:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405533.647968 (Exim 4.92) (envelope-from ) id 1oXejG-0002Zk-77; Mon, 12 Sep 2022 08:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405533.647968; Mon, 12 Sep 2022 08:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXejG-0002Zd-4P; Mon, 12 Sep 2022 08:23:42 +0000 Received: by outflank-mailman (input) for mailman id 405533; Mon, 12 Sep 2022 08:23:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXejE-0002ZW-F1 for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:23:40 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33f5da71-3274-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 10:23:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B70061FA0A; Mon, 12 Sep 2022 08:23:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E1B8139E0; Mon, 12 Sep 2022 08:23:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rCYEHIrsHmNsJwAAMHmgww (envelope-from ); Mon, 12 Sep 2022 08:23:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33f5da71-3274-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662971018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pTyvCwiJViDhAwb3CqykfKBNOXyxabvwchEafMCB2B8=; b=rprufwgoxO1DHFgRMVnSVXVCjEVb//40w3yEVK0kdFnjM68LhwDGnyaRDT+vVFI5E9t98w QDpmve3D7Germ/XsWr+ADHZB2xULUHFFPgSU9SqiNHMn3CL5z+RxYRoEGOgDqg4vEknjUG GTYe5y3vdZiDHUHzIbD8uGBnywYi9V8= Message-ID: <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> Date: Mon, 12 Sep 2022 10:23:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3yO0Mmqo1aUIqxXy14lpC6Lo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3yO0Mmqo1aUIqxXy14lpC6Lo Content-Type: multipart/mixed; boundary="------------3WBMFl9fx8t9bZhELbR4bSTy"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> In-Reply-To: --------------3WBMFl9fx8t9bZhELbR4bSTy Content-Type: multipart/mixed; boundary="------------DXIa29hswfuGEodiYCCswbEX" --------------DXIa29hswfuGEodiYCCswbEX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMTA6MTksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMi4wOS4yMDIy IDA3OjUzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gQWRkIGEgaGVscGVyIGRvbWlkX3Rv X2RvbWFpbigpIHJldHVybmluZyB0aGUgc3RydWN0IGRvbWFpbiBwb2ludGVyIGZvcg0KPj4g YSBkb21haW4gZ2l2ZSBieSBpdHMgZG9taWQgYW5kIHdoaWNoIGlzIGtub3duIG5vdCBiZWlu ZyBhYmxlIHRvIGJlDQo+PiByZWxlYXNlZCAoaXRzIHJlZmVyZW5jZSBjb3VudCBpc24ndCBp bmNyZW1lbnRlZCBhbmQgbm8gcmN1X2xvY2tfZG9tYWluKCkNCj4+IGlzIGNhbGxlZCBmb3Ig aXQpLg0KPj4NCj4+IEluIG9yZGVyIHRvIHNpbXBsaWZ5IGNvZGluZyBhZGQgYW4gaW50ZXJu YWwgaGVscGVyIGZvciBkb2luZyB0aGUgbG9va3VwDQo+PiBhbmQgY2FsbCB0aGF0IGZyb20g dGhlIG5ldyBmdW5jdGlvbiBhbmQgc2ltaWxhciBmdW5jdGlvbnMuDQo+Pg0KPj4gU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gSSBkb24n dCBzZWUgYW4gaXNzdWUgd2l0aCBhZGRpbmcgc3VjaCBhIGhlbHBlciAocmVzcG9uZGluZyB0 byB5b3VyIGNvbmNlcm4NCj4gaW4gdGhlIGNvdmVyIGxldHRlciksIGJ1dCBJIHRoaW5rIHRo ZSBjb25zdHJhaW50cyBuZWVkIHRvIGJlIGVtcGFoc2l6ZWQNCj4gbW9yZTogV2UgYWxyZWFk eSBoYXZlIGdldF9rbm93bmFsaXZlX2RvbWFpbigpIGFuZCBnZXRfZG9tYWluX2J5X2lkKCks IHNvDQo+IGhvdyBhYm91dCBuYW1pbmcgdGhlIG5ldyBoZWxwZXIgZ2V0X2tub3duYWxpdmVf ZG9tYWluX2J5X2lkKCk/IEFuZCB0aGVuIC4uLg0KDQpJIGV4cGxpY2l0bHkgZGlkbid0IG5h bWUgaXQgImdldF8uLi4iLCBhcyB0aG9zZSBoZWxwZXJzIGFsbCBpbmNyZW1lbnQgdGhlDQpy ZWZlcmVuY2UgY291bnQgb2YgdGhlIGRvbWFpbi4gQW5kIHRoaXMgaXMgTk9UIGRvbmUgYnkg dGhlIG5ldyBoZWxwZXIuDQoNCj4gDQo+PiBAQCAtODU5LDIwICs4NjYsMjcgQEAgc3RydWN0 IGRvbWFpbiAqZ2V0X2RvbWFpbl9ieV9pZChkb21pZF90IGRvbSkNCj4+ICAgDQo+PiAgIHN0 cnVjdCBkb21haW4gKnJjdV9sb2NrX2RvbWFpbl9ieV9pZChkb21pZF90IGRvbSkNCj4+ICAg ew0KPj4gLSAgICBzdHJ1Y3QgZG9tYWluICpkID0gTlVMTDsNCj4+ICsgICAgc3RydWN0IGRv bWFpbiAqZDsNCj4+ICAgDQo+PiAgICAgICByY3VfcmVhZF9sb2NrKCZkb21saXN0X3JlYWRf bG9jayk7DQo+PiAgIA0KPj4gLSAgICBmb3IgKCBkID0gcmN1X2RlcmVmZXJlbmNlKGRvbWFp bl9oYXNoW0RPTUFJTl9IQVNIKGRvbSldKTsNCj4+IC0gICAgICAgICAgZCAhPSBOVUxMOw0K Pj4gLSAgICAgICAgICBkID0gcmN1X2RlcmVmZXJlbmNlKGQtPm5leHRfaW5faGFzaGJ1Y2tl dCkgKQ0KPj4gLSAgICB7DQo+PiAtICAgICAgICBpZiAoIGQtPmRvbWFpbl9pZCA9PSBkb20g KQ0KPj4gLSAgICAgICAgew0KPj4gLSAgICAgICAgICAgIHJjdV9sb2NrX2RvbWFpbihkKTsN Cj4+IC0gICAgICAgICAgICBicmVhazsNCj4+IC0gICAgICAgIH0NCj4+IC0gICAgfQ0KPj4g KyAgICBkID0gZG9taWRfMl9kb21haW4oZG9tKTsNCj4+ICsgICAgaWYgKCBkICkNCj4+ICsg ICAgICAgIHJjdV9sb2NrX2RvbWFpbihkKTsNCj4+ICsNCj4+ICsgICAgcmN1X3JlYWRfdW5s b2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+PiArDQo+PiArICAgIHJldHVybiBkOw0KPj4g K30NCj4+ICsNCj4+ICsvKiBVc2Ugb25seSBpZiBzdHJ1Y3QgZG9tYWluIGlzIGtub3duIHRv IHN0YXkgYWxsb2NhdGVkISAqLw0KPj4gK3N0cnVjdCBkb21haW4gKmRvbWlkX3RvX2RvbWFp bihkb21pZF90IGRvbSkNCj4+ICt7DQo+PiArICAgIHN0cnVjdCBkb21haW4gKmQ7DQo+PiAr DQo+PiArICAgIHJjdV9yZWFkX2xvY2soJmRvbWxpc3RfcmVhZF9sb2NrKTsNCj4+ICsNCj4+ ICsgICAgZCA9IGRvbWlkXzJfZG9tYWluKGRvbSk7DQo+PiAgIA0KPj4gICAgICAgcmN1X3Jl YWRfdW5sb2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+IA0KPiAuLi4gZXh0ZW5kIHRoZSBj b21tZW50IGhlcmUgYW5kIGluIHRoZSBoZWFkZXIgKG9yIHBlcmhhcHMgb25lIGluDQo+IHRo ZSBoZWFkZXIgd291bGQgc3VmZmljZSBhbmQgdGhlIGRlZmluaXRpb24gaGVyZSBkb2Vzbid0 IG5lZWQgYW55DQo+IGZ1cnRoZXIgY29tbWVudCkgdG8gZXhwbGljaXRseSBzYXkgInJlZmVy ZW5jZSBoZWxkIG9yIFJDVS1sb2NrZWQiLg0KDQpZZXMsIGdvb2QgaWRlYS4NCg0KDQpKdWVy Z2VuDQo= --------------DXIa29hswfuGEodiYCCswbEX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------DXIa29hswfuGEodiYCCswbEX-- --------------3WBMFl9fx8t9bZhELbR4bSTy-- --------------3yO0Mmqo1aUIqxXy14lpC6Lo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMe7IkFAwAAAAAACgkQsN6d1ii/Ey/+ vAf/blhSm4T58i9Dc2wMTuqX6aGhAJoI8w9qnLslrHDxE2mQ6bIan/aEiJYaq8N85xWgaDD8bPpA XYe9vUwgfUrFEloBNRmfNZ4mocjW+piBvK4JcMX3xACRrIk2EPBrmOk5Z25k7bHYhUt53cLhJBxt WtjOUQaTb9C0Gk/hOiqOiOFvxk0/SP2UvqBE02i90S9sB1AmA5WViDYJctSBDEsii8+Re87AD+34 xsS2VUBcJKQZr8/nA7glexk+L1tJgpncKfvbXZB6A/Jc2kbJ6kILIvpil5F4gUeA8+nsQJ7Xm/ME 32CgzgbYhYhLojyZXaP26dM/vcM8zhyXnLpjkylNTg== =4UIo -----END PGP SIGNATURE----- --------------3yO0Mmqo1aUIqxXy14lpC6Lo-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:25:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405539.647979 (Exim 4.92) (envelope-from ) id 1oXeka-0003A0-HU; Mon, 12 Sep 2022 08:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405539.647979; Mon, 12 Sep 2022 08:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeka-00039t-ET; Mon, 12 Sep 2022 08:25:04 +0000 Received: by outflank-mailman (input) for mailman id 405539; Mon, 12 Sep 2022 08:25:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXekY-00039j-Jy; Mon, 12 Sep 2022 08:25:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXekY-0000RH-HG; Mon, 12 Sep 2022 08:25:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXekY-0007cC-0m; Mon, 12 Sep 2022 08:25:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXekY-0003H4-0F; Mon, 12 Sep 2022 08:25:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H7BVuSzO9+BDcyFtNG2AaPvyhSW+7azjoXt73qjZNM4=; b=Fp/D8WZm9AnoU5GKeNs/6uLeEY 3mTxdPIdXobBYfBbQj7Z0Ourq+GEbeCdJ069cASvGt3TRHDWFMPs0XhpvEJCxjsc+yrfft8sqgJd0 ZuA9RS8jy+W9tPCkKjiQidlEp+UCY2Oik75s4actcTGYy67gFuigTSgbBWYvY44gvROo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173141: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=80e78fcce86de0288793a0ef0f6acf37656ee4cf X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Mon, 12 Sep 2022 08:25:02 +0000 flight 173141 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173141/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 80e78fcce86de0288793a0ef0f6acf37656ee4cf baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 39 days Failing since 172152 2022-08-05 04:01:26 Z 38 days 86 attempts Testing same since 173141 2022-09-11 23:13:15 Z 0 days 1 attempts ------------------------------------------------------------ 1774 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182330 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:31:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:31:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405551.647991 (Exim 4.92) (envelope-from ) id 1oXeqW-0004sN-FK; Mon, 12 Sep 2022 08:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405551.647991; Mon, 12 Sep 2022 08:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeqW-0004sG-9Y; Mon, 12 Sep 2022 08:31:12 +0000 Received: by outflank-mailman (input) for mailman id 405551; Mon, 12 Sep 2022 08:31:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeqV-0004sA-3R for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:31:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60062.outbound.protection.outlook.com [40.107.6.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e507dc8-3275-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 10:31:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9519.eurprd04.prod.outlook.com (2603:10a6:102:22e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 08:31:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 08:31:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e507dc8-3275-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=npJiBJ/3+aBXlTRTixIZWA4Zm7KWxVtaP+u6t/4PbUOZOx+jZDumvvPsRI8QlZySMux3bVWksFviHg7hL/dNd4sZ7zJvnVCwRF/8Kap+je6u9iTUIZO5b6pllD8pQOqnLTOn/uMillOiGrsES0rFwg6/6iiS/hohRVnU4YtO8Rs4xKkNATuviPGPt3Mwvn2Qd8Jm6OmPoixPGqFqJrACmWuOdF5sLvueJJwR4Mx+142j1ieBbu483LXLBI2Xgzn4MR7tc11AxLlyC032gkrNA+eK6uHGgxkgJEQ8gJTC6cYB9S/a7wEAU+R54PAR1h9OB3s7GAof9KihtRvbJ8S/mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arH8Ge7kYe2WbuEILHqOcMnSCpztvLBnDXsQR8cI+KY=; b=MdXUIzn05GLwpqM09RyqAHYpREWEV87dz9X3mSFxnp8TxrvOGrfJVz2AIxyqzFk8ee0H32Ac+hZhsScUIO7/N5KFCnr+Uv45Yi94JEW6XN8PyXoR7TRWUS67uehIKC4c/RH0u1O1lv6JV08MOM92hEYcrOk/8H9KIMzPVQAZ0azFDdP1RTF/ybPjJgP9qzcp4p1H6c/c26YJgI+LZO4SsPkYSSruEzLPMqDDiyZ0ZfODEG6LDokMzeyx+z0d5fzZG3fDMHGe7Ja3vQprQM1s27Jb4VrpNT544NCTwTNYTNbcr8Q3VZYrn7XQNR1UbC7TM3vZhzAu92N75+JEbJ3S/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=arH8Ge7kYe2WbuEILHqOcMnSCpztvLBnDXsQR8cI+KY=; b=TzH6n4gIjvlB9KRabOQ7FfIz4hWS9/D2BsRUY50Vj5NvzANnuqI5uaY6KQC/6VySGXn5etp/u1aVkMBQAvaBe9CeyPhuyy5fmluSZw2+sWlV52ftlkdn2Jc+aqW1QayVeSfSYffxF+n2fHFjBMww8aaMZZYmKmzrJeC60M+MQWAT9NUy/Nxs9RMyA5DAMPfBVIJOOBDTE19jdzteSXSVC8Y1LRa26ijOtDfoOG8xBzkA6zITfxcoAdbZqXrIHSSGm3AUgrxGQVrqrXUPzG/qEifz2E7v6iBVjQ83X5XkFD8iIf3K+ea3TlzIAvFES2B9JAnzXWI3MXr48wUlyep7lg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Sep 2022 10:31:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> From: Jan Beulich In-Reply-To: <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9519:EE_ X-MS-Office365-Filtering-Correlation-Id: 98af0ce5-ed21-4913-3b33-08da949920c9 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: THzsXKt/8HLkWMtKJ1cUKaavO9nSH07wPqityssk4TKcruDhttQQbpjUCR9u47swZxsCPCs/77aSYbOt3/Va+AmxrYRvpi3oMF58H/3Ou5/6M286rAe7Qys6i9NI2PQdG81c9M/N3C6NlVcu8UKqoex+KS9cjLhJ+vmj8EOVgLPrEEl9U97XaemJx6AFE/H731qWiz5lPf4vNaNbWeq31+fPyz/NYNavvp4aXNFn2xnNymfvrazhBocA9Hal19R888QKmsuV778gQVaTDf+Hq2Ur0dlXaAplqpdZQjmXUaV6nE9G5+SJj72GFJ02HjAZbEOKIjIQR4lAnTP9fYFtonJPnJ7dZpamqiHV2dlbBaa1LRS2Mv/ieqTWLSb7EWSmWLD4m09IkZaSExKw5io61Q3H6GZbffSFda0xQ2QUcMGFooNAwZdC0isdTTkGWudkGHYGD3+H1bHEmUu5KO7oovg+yRtQ7ugRuXoHIohQH5gQvsrz7MtHUaIO+0h3AU2Fsz6C36tCNHjdel4o8MKeQ6SySQCLJhHm01S1lrjp7JEBrXotNC2wYjDSly62DUBVm8U9Ckdjd0IqhK3DOaT9fAV6aBJT9rNoBj4HpRUMwy490ofXMH2MsZQzXbKtgULQ9Br2i6s5YvfYxE7kSumkivrvfZpxY1I4dk+VuMcEEETDxBpVPTm0drYPZ+msKCqsJD+WGe7e0ymhqwS8m7GD3d3wRxwHiG5a1DXV7atK4TpUY0Oi9JDNBj9QTi7FIIrZmUyp3T/eOpfixfN0CmAQqb4aZqmqtRkSP5v6zvURLfg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(376002)(136003)(346002)(396003)(66556008)(31686004)(37006003)(6636002)(54906003)(36756003)(316002)(478600001)(6486002)(66946007)(31696002)(6512007)(53546011)(26005)(2906002)(8676002)(4326008)(6506007)(86362001)(66476007)(5660300002)(38100700002)(8936002)(6862004)(41300700001)(2616005)(186003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3pzcEIzOGtIWDJuOVpON0k3Y29KR040aUpqVmZHR1Qwd2xyck93Q1JsaktI?= =?utf-8?B?TUhwdDIvLzR5T1pvRG1CaUp5MGxVSWQwcGN4b1QzZWo2M2U2eHd4cE0wRG1x?= =?utf-8?B?N2dpOEFkRmRpTGpOWEVzN2hlRWdIUm16dUpQWTQzSHFiY2xJSGp6OVdYZXNx?= =?utf-8?B?T0tKbk13UU1FcldTdkUwdnVkbTN5MTlCU1o5bWxsMG1Fd3JXeU9CU0dJYmp5?= =?utf-8?B?VkZrTmkvOTJyNEhWSk9GSmw0WmQxZDJzdG1rYndwTVRMK1ZEdHROMXhNTjZU?= =?utf-8?B?MEhldStSUGJlZzQ3WDZLcGRWRitibWJJUDVrN211alQwQUdRRTdyKzIwUVNO?= =?utf-8?B?eEdudURlYTg0bDFkN3hXSTRaM0EybnRGb2M5ek9NOFFYVFBwVmFiRDlNTG1l?= =?utf-8?B?ZFRiU2p4S2RNdStTVXMvUUExNVJKNVJaL1lIY0RhUUN5cGx6dFYrNGFZVllN?= =?utf-8?B?bjQyWTNMWmlKQTZLb1JWYjJZR2RLbmtBbng0aG5ieS8vdmF2dDNsQVJhOWh1?= =?utf-8?B?cDB1NVBiVHJaNTVLTndNVGJDTk5QY0R6dTdpMk1xd2VISE90Y01PejZCaGlY?= =?utf-8?B?WisrMlB0Z3FGb0xZSXJoZUFLT0JDN0t3NlBjcCtZWitjVzNhVWZNT0toNVNO?= =?utf-8?B?eGJqdWsyRTBIZDRBVm9qTUc2bWU2dHdsQ2twWU5wdGllK3lYZ0hESFV4OXU0?= =?utf-8?B?RTBSYTkvYWR4ZHRNaGtpVlhKS1d4L0pMMEI0STUzR09oM0tpRERPVFJoU3BW?= =?utf-8?B?WWV2di9iSjNEbXBRNTlTb1hMRkxVQkFnaDBTdTJZTDFLMXRKME1sZkUvd2Z3?= =?utf-8?B?SjVrNUUySko5cDNrZ2dFRHRERWNsb2NwNGl6M3NQWDBud1hpU0FxUXN3bzJx?= =?utf-8?B?ZzUzcEpzTjRjaE51RTVXV093Z3YxM0Z5RjFuMUJwVk5kakZLak1qM0xrYW5j?= =?utf-8?B?SU9POC9RM3ZGd1ZWbjJjMXY2d2VzMitoRmFLeDAwY0dXblFlQVNRNHFtZlVz?= =?utf-8?B?VWlhT1dYRjhhTXRqRmNLQXVGaGNFU290QXhjRWJjQlB3bDA5SUhLNTBMZkpu?= =?utf-8?B?Q3NPNjN3eXpnSmNhOU5ONzBCTkhXcE5hd05zRFoxTFllQzZ6Q3RwUmlzYW1J?= =?utf-8?B?WmEyZXVNang2ZUJxYWRIam1MS1UrN3BTU200dmpRZUo4WC9nQndPUGhqSWJw?= =?utf-8?B?OWcyQ3VlZExXMWpCVWN5RDc5V3Z4QTMzT25ETDBEOUhXK255Y2NmNTg0Nkhk?= =?utf-8?B?dXp3T2ZkZkdjWmdOUmlBTkRKTTJaYTR3WDNKNGtQeG9WcHVpUk5IMGVncWcx?= =?utf-8?B?U0J3NHZtVzF2aysyMlFxUWdoQWJFR2djUE9qeVNIdjlkajZMUVpwSTYzbHAx?= =?utf-8?B?RDRyTncyWmRqUVZDVTk3T1FWTlI0b0RFNHdvb2FuR0Y1cVQxdVVtQ2tJdU1z?= =?utf-8?B?N3d6WitWQ0Z5VTNyRE1UV1BvTENncTVNNEE1UmZWQitSc0FVNHZ0YkI2L1hT?= =?utf-8?B?VloxWGJLbExzdU1ETS96eXFNY2RocmEvR1RDNHA3eUpuZjBnSnFVKzE5R215?= =?utf-8?B?YVczT2R1dGpzODJPTUdRTmxuOVkrTGtjK1pVajRiNEwxcGhkblR6QUcxZzZn?= =?utf-8?B?VGlTckZ4eEtGWjZ2U1QyY2xhQWwzdFIyUlBaVDhYdFlpdml6dlc5T3hseC9o?= =?utf-8?B?dWdSVWk1YkdsYkx1SWFhY05LaUVQWTdra0k0eXM1b05XdEJsR2ZRVHg2Q3FZ?= =?utf-8?B?eHFBZ3FjZVp6U3BSN2R6VXo4U2JNczdpOWV5SWlIS0pOeDZwdjVTcmNQRWk1?= =?utf-8?B?MndObmtOeFk1bldhRThmclpnb0V6WjA0aEVEOE5sdmVnQW9JZjE4UmdraHhD?= =?utf-8?B?bnJvVE43Y25yMFEvemdGaVJJMGdvZHZaeHE0T2NrVDhCZDl0QnJ5L3ZFNk9I?= =?utf-8?B?Vms0OWs0K2Z4TjRqODFvcGpHSFdEK0I2bnA5U05LZVNGbm9Pb0FoSFQ0K256?= =?utf-8?B?bjhVdGNya0FmNC8xaGhQZHNxcE9Fa2drdlpTbXNYeDBBajR0SlhrRTAwWlpP?= =?utf-8?B?WmQvbUpDODZDc2VoMS9aQi9iM1BFNmJPeVk3ZjJWV3o1dHU1NlE4S1N5UHln?= =?utf-8?Q?efoi3SN0vo+u2xTPkY6McYkR7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98af0ce5-ed21-4913-3b33-08da949920c9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 08:31:02.8874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pGoHm1MTM6HyAXHq4bf43Ni3d4/Vc9nBfgQ2r3eo2MWYxf8oxe+hd8P4Mq9HjO4OpIoqPuqfRob2/9iixcXldA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9519 On 12.09.2022 10:23, Juergen Gross wrote: > On 12.09.22 10:19, Jan Beulich wrote: >> On 12.09.2022 07:53, Juergen Gross wrote: >>> Add a helper domid_to_domain() returning the struct domain pointer for >>> a domain give by its domid and which is known not being able to be >>> released (its reference count isn't incremented and no rcu_lock_domain() >>> is called for it). >>> >>> In order to simplify coding add an internal helper for doing the lookup >>> and call that from the new function and similar functions. >>> >>> Signed-off-by: Juergen Gross >> >> I don't see an issue with adding such a helper (responding to your concern >> in the cover letter), but I think the constraints need to be empahsized >> more: We already have get_knownalive_domain() and get_domain_by_id(), so >> how about naming the new helper get_knownalive_domain_by_id()? And then ... > > I explicitly didn't name it "get_...", as those helpers all increment the > reference count of the domain. And this is NOT done by the new helper. Hmm, agreed. But domid_to_domain() isn't expressing the "known alive" aspect, yet that's relevant to see when reviewing new uses of the function. Such uses aren't likely to make the reviewer go look at the function declaration when the function name is pretty "innocent". Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:33:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:33:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405557.648000 (Exim 4.92) (envelope-from ) id 1oXesi-0005T5-PG; Mon, 12 Sep 2022 08:33:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405557.648000; Mon, 12 Sep 2022 08:33:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXesi-0005Sy-Me; Mon, 12 Sep 2022 08:33:28 +0000 Received: by outflank-mailman (input) for mailman id 405557; Mon, 12 Sep 2022 08:33:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXesi-0005Sq-6d for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:33:28 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9279c6a4-3275-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 10:33:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EC1C91FB59; Mon, 12 Sep 2022 08:33:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A324D139E0; Mon, 12 Sep 2022 08:33:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2pdLJtbuHmNZLAAAMHmgww (envelope-from ); Mon, 12 Sep 2022 08:33:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9279c6a4-3275-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662971606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gIbEQYuRxed1sKs3TrZHbm3VQcicEvfnPymumYqyiDw=; b=NISn3GVT/rNm/ynyo7JdP5sp9q4saZ353nat5EltH6OOG60Puylbd884LeGiuZrjrIA2S5 s9WCExANZtKvfsf0yYsf2TNwkjlMlfOHgHvDfVT8mrpA3/GGkgKxgU71TsM3YBMxcFmRdJ n+yh1y5PuwU7ypzAql3Mlc283QiRSTE= Message-ID: <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> Date: Mon, 12 Sep 2022 10:33:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------bousNCkHmwnzyrJAod6Bp1fq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------bousNCkHmwnzyrJAod6Bp1fq Content-Type: multipart/mixed; boundary="------------VqUzmyUxRbs78XjvTeHv6LPC"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> In-Reply-To: --------------VqUzmyUxRbs78XjvTeHv6LPC Content-Type: multipart/mixed; boundary="------------V87TF1GjO8lo7dt2EUv00r19" --------------V87TF1GjO8lo7dt2EUv00r19 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMTA6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMi4wOS4yMDIy IDEwOjIzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTIuMDkuMjIgMTA6MTksIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDEyLjA5LjIwMjIgMDc6NTMsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IEFkZCBhIGhlbHBlciBkb21pZF90b19kb21haW4oKSByZXR1cm5p bmcgdGhlIHN0cnVjdCBkb21haW4gcG9pbnRlciBmb3INCj4+Pj4gYSBkb21haW4gZ2l2ZSBi eSBpdHMgZG9taWQgYW5kIHdoaWNoIGlzIGtub3duIG5vdCBiZWluZyBhYmxlIHRvIGJlDQo+ Pj4+IHJlbGVhc2VkIChpdHMgcmVmZXJlbmNlIGNvdW50IGlzbid0IGluY3JlbWVudGVkIGFu ZCBubyByY3VfbG9ja19kb21haW4oKQ0KPj4+PiBpcyBjYWxsZWQgZm9yIGl0KS4NCj4+Pj4N Cj4+Pj4gSW4gb3JkZXIgdG8gc2ltcGxpZnkgY29kaW5nIGFkZCBhbiBpbnRlcm5hbCBoZWxw ZXIgZm9yIGRvaW5nIHRoZSBsb29rdXANCj4+Pj4gYW5kIGNhbGwgdGhhdCBmcm9tIHRoZSBu ZXcgZnVuY3Rpb24gYW5kIHNpbWlsYXIgZnVuY3Rpb25zLg0KPj4+Pg0KPj4+PiBTaWduZWQt b2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pj4NCj4+PiBJIGRv bid0IHNlZSBhbiBpc3N1ZSB3aXRoIGFkZGluZyBzdWNoIGEgaGVscGVyIChyZXNwb25kaW5n IHRvIHlvdXIgY29uY2Vybg0KPj4+IGluIHRoZSBjb3ZlciBsZXR0ZXIpLCBidXQgSSB0aGlu ayB0aGUgY29uc3RyYWludHMgbmVlZCB0byBiZSBlbXBhaHNpemVkDQo+Pj4gbW9yZTogV2Ug YWxyZWFkeSBoYXZlIGdldF9rbm93bmFsaXZlX2RvbWFpbigpIGFuZCBnZXRfZG9tYWluX2J5 X2lkKCksIHNvDQo+Pj4gaG93IGFib3V0IG5hbWluZyB0aGUgbmV3IGhlbHBlciBnZXRfa25v d25hbGl2ZV9kb21haW5fYnlfaWQoKT8gQW5kIHRoZW4gLi4uDQo+Pg0KPj4gSSBleHBsaWNp dGx5IGRpZG4ndCBuYW1lIGl0ICJnZXRfLi4uIiwgYXMgdGhvc2UgaGVscGVycyBhbGwgaW5j cmVtZW50IHRoZQ0KPj4gcmVmZXJlbmNlIGNvdW50IG9mIHRoZSBkb21haW4uIEFuZCB0aGlz IGlzIE5PVCBkb25lIGJ5IHRoZSBuZXcgaGVscGVyLg0KPiANCj4gSG1tLCBhZ3JlZWQuIEJ1 dCBkb21pZF90b19kb21haW4oKSBpc24ndCBleHByZXNzaW5nIHRoZSAia25vd24gYWxpdmUi IGFzcGVjdCwNCj4geWV0IHRoYXQncyByZWxldmFudCB0byBzZWUgd2hlbiByZXZpZXdpbmcg bmV3IHVzZXMgb2YgdGhlIGZ1bmN0aW9uLiBTdWNoIHVzZXMNCj4gYXJlbid0IGxpa2VseSB0 byBtYWtlIHRoZSByZXZpZXdlciBnbyBsb29rIGF0IHRoZSBmdW5jdGlvbiBkZWNsYXJhdGlv biB3aGVuDQo+IHRoZSBmdW5jdGlvbiBuYW1lIGlzIHByZXR0eSAiaW5ub2NlbnQiLg0KDQpP a2F5LCB3aGF0IGFib3V0IGRvbWlkX3RvX2tub3duYWxpdmVfZG9tYWluKCk/DQoNCk9yIGtu b3duYWxpdmVfZG9tYWluX2Zyb21fZG9taWQoKT8NCg0KDQpKdWVyZ2VuDQo= --------------V87TF1GjO8lo7dt2EUv00r19 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------V87TF1GjO8lo7dt2EUv00r19-- --------------VqUzmyUxRbs78XjvTeHv6LPC-- --------------bousNCkHmwnzyrJAod6Bp1fq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMe7tYFAwAAAAAACgkQsN6d1ii/Ey+E sAgAlVE/tJYUmHggdxW2e6eslpbFOmxttoILGHILa7QgIWRrezUAMy2m1eotBk9Ni/0FCNFadIAb szaAR14GudDDCEQlDbvvf3j28Vy8BR7J9IE0HfbS5VAYVFbE0SO0mwQ8BCa9sNhd9ikaUKthlGu/ h6lgmNCEWFwfHFqKMNucSGWolFN9AtBMaUVk6Phqb9+S8OKMOCSmNvmWrt9unWfXjj7+vaPYVXxY kV1XsKZb1xrcAllidh9iBGwNhhVrPk1EFj5XPO4k4oSfjfNP/yC3vwVPnSp+pPhJHkT33al/hvfM hPUHRLL59azI9QYon9rBi67aF4pMBec8IYesIbG2Mw== =LNiV -----END PGP SIGNATURE----- --------------bousNCkHmwnzyrJAod6Bp1fq-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:34:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405563.648012 (Exim 4.92) (envelope-from ) id 1oXeti-00061D-23; Mon, 12 Sep 2022 08:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405563.648012; Mon, 12 Sep 2022 08:34:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeth-000616-VU; Mon, 12 Sep 2022 08:34:29 +0000 Received: by outflank-mailman (input) for mailman id 405563; Mon, 12 Sep 2022 08:34:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXeth-00060s-2g for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:34:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6c6c751-3275-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 10:34:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7312.eurprd04.prod.outlook.com (2603:10a6:800:1a5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 08:34:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 08:34:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6c6c751-3275-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPRIlbnOaD9hOu0OFdA25+Nj06aO3U95Cf0ljKYuU93Pd3n7l9SdTjerVmexeJaYWXZQzqd5LxrRomdbTh/tOrMek5y6pKTmxywqtgNzgk2bFpvPvGuAbeqWAAhSVeHmUFMA2zfP7bp9vbHQxirlR9KS8PiJpICbz+LbdZbpGSrHDiKJSIjYIBthr5QUXGSTHu8pcpsPMvBrBaqPlXs2dIyyQhxI6KZv1tDGGSfeeIRw9SG0DgdUPbqfroi0R4zeT9BUoUlcToDCMhkgLH4gZ0+/kAoZ2r1TSdPuHUBjdYTSQkFxskDPXgwfLv+XAMsyNE4U8O2Iwkhwo7LyFUULUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SwAjpLWz7zLWGNC8h48U8N86qrSvD1eKwMZ9h40wuSA=; b=X23Ui/s4FbGPjSc6ODG5ExP8yC3gQ8GcTGp3xrkIK72w4eM0g4Rxt+XMljhzWHt19qPfDfy4MaycTzx7hN2MrcRllulD+ppi0wcn2ZRAgB1B8++1KQOFgQioh0tg3O/X6Y2Vv3R66UkRyYvqRcDcwhh66IqltEDGpHvHMpDUWGYnPn7Vz9jUni9gZlrimZzyTUwY/g8SFzaEA7MHRp9EZ+5KvDiekBXV+Cfx1Q3EWTq+93C4RDCG+Y3UH+J90zAYzKhKbjrMON1YZ9w6O1MA2vnIQXTdg7jTPLRrF5mmvgIzYV1yKCyWa4MiOIEW2+hGeM3sweQnQP7muPt9J/au9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwAjpLWz7zLWGNC8h48U8N86qrSvD1eKwMZ9h40wuSA=; b=2YTfELbXWYwWM4n+X+1CMa4z8/MjRd7m/soLNesLr8C98jZVXol1jyohCYKNXmz6n4oM/VaGtm2U/HyORF+BeqZOeTkpD8z7xcjUXTi8VmC+hmqTu4qlU6oQJk9p4012HHawDDv48WffROVjrv4MCQ5Tvhvx4DOAxt05Z3TpRhCtzTGTNYDNABaxUsltXObRMJdKsHGSMCjXWPPolLvEgzHvSXU/WWJIz6HPJk7rYylo9w2E53CuI63guyX5wPcsROgCpR8a6PqP2HY0+HhCUEMMJ0BhX3HpNIc2SftoscEEkWTxfum4g1Bf258kYiNvGu4jhH7XmI7f1vnWQxmnuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <021b2bff-6a64-337a-ed2c-98b657e4f9dc@suse.com> Date: Mon, 12 Sep 2022 10:34:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> From: Jan Beulich In-Reply-To: <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7312:EE_ X-MS-Office365-Filtering-Correlation-Id: 59f5e124-1658-4470-d83b-08da94999913 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iYuJTrrURm04xvjruyw28q6HOsxA8QQmbyRdngQLZnEW7MokFB61XESNAeEt9mN5caPQGP3xHokTRqr4qUIAWlzITEKfhfF73Y0uyc+QC4Cs/yvt25Kv8/nxma9U694s8QTvZBJY2C2T8TmOA078ZeVx1DRqx0Gj/B43tQveWLgaSU/tZ+fkVOhPEJPxDhezRmZGxW2zaEHH1sSQ6b5db9Oml9MBEsuYSu9xH+NcTOgdhs0BwBNDFylu6AEbr7p50uDYoM/srHmELhv7kyZB08OCIvajHMYJIiAw0CMNMl9kzdO5KtXr435e5NP9HH06TE8g09SDPsuC0biA2rmXr4r12gQWL4Hje/jn/k3L8cLEFPkhd5DqIFl1srj19S9vA66E4NxdarGWY1jLkJkIWB8d+CTZ1o5xooRKkLqsmMZ6YFKtkjHCnrruCv6qvePP2tUQfeOdtXo5CVJtSnIIvvGF8SizgZhG0ZVwpIywgX/pb69nCOazliGNO3vvj/5neFwVgizXi8UzTsC5HHcvm/iN/ITickkQ5fdBzaxHNjDABPCtTHDYUSRFhYY23y+MHXYHMNPi5OpIemI8aK6jo2v8vbl73AqgkDJnEz9zTYmdiA5BQd1aE6Patn1gDkcdDQrS+Flk2PzT9zrWHOfBabZXOSIqNzfBXG39GAKZ9AERIBhtwhJ1fyJEIop0NG2lQZeQb2oPsrCUY0/sUAKJSrsLCZAKabx9x1fKOqYdbVhkGF4mEtxBZacvw4MZjqJO+x4uPWuvmyB2zkN6KdjWpzP+u1GFwMLkzC8JKTTCNjY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39850400004)(136003)(366004)(376002)(86362001)(31696002)(66946007)(8676002)(38100700002)(31686004)(66556008)(66476007)(4326008)(36756003)(186003)(83380400001)(2616005)(53546011)(26005)(6512007)(478600001)(6506007)(41300700001)(6486002)(2906002)(37006003)(6636002)(54906003)(316002)(5660300002)(6862004)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDBXeVhScjdHNVNXYUJSSVBQMGZLUXptaCtLckRQa3FYTVNpMDF0alYwZGwr?= =?utf-8?B?Z1MvVFkwWWs2KzNyYjFZRjNqOTd1QkhxRlRGNEdiK2pvZmE0UmVvMkE3b1FG?= =?utf-8?B?SmpVZllOMTVqQXBGK3Vidi8yaFg1Nk1ieTdGSEJrOEU0ZUZKK0VJVkE0UE1E?= =?utf-8?B?S2FrMGRkeng5RjIwSVZHenNMRWl0MlF1VU0zSmhiQTdSUkcvT1ZnYVFGWVNH?= =?utf-8?B?bHVveHlOekhyVzVHZlB0bTJxOXo2dkcrQUJEcks4eVlsZ2h6UjM0b05lVU5E?= =?utf-8?B?Mm1CNURTQ2poN3ZHQlAveTJ4WW1hMkRTQnI2blVVbmJBQ0dqYkhWKzhrb3NW?= =?utf-8?B?UGpBUjAyZ1hsUzNCOTl1M1hVb0hJTjBoU3pWL05lMEI5RmRJdlZodS9LZGZw?= =?utf-8?B?VEVhb1JjODkyVmVLSGtLUFFrWmRGMVY1ZHk1OWZQYzhtKzI4Vlh3Wnhra2dQ?= =?utf-8?B?b3gwYVJxSFcrNFdYNHBIUVRMaHduamNyMkFBTS85MlhpVFAzREUyRjk4NkFQ?= =?utf-8?B?bUt5L0wzOHVHazgybGV3cFJmekxXUzdGeUtsZS80RXdVWTVMaE1ySkY5UFR1?= =?utf-8?B?UHQ4cmk4M0Nsd1J5YjUrRXdrL2Y1SkQrak5QZWZuMG03dnhpTXVsdmpjUkdF?= =?utf-8?B?UERPM0NrZlBWL2J4THl0NHBZRkZWSjI4emZZNUFpY2x6bElJU3dRS1BMcjhz?= =?utf-8?B?SVhoYTNJMHNVcC8xZVA0ci9KY3lxaks4emp5eFBhN1hUNEUrUlZkcFcyZHl0?= =?utf-8?B?YVNLemZDRFNHbjY3eW5uaEtIb3dCR1RndWF5MzdpY0NyMFE3anl1RE1va3BS?= =?utf-8?B?OTZIbk9DeWFQK0kwNkNJRjIrMTlEcmRCcFA2dG1RekgxSGtwMUprdFRmR3gw?= =?utf-8?B?ZS9UUHh1Tk5icjdDa0VXVk5iRjhVUlRKcjd4cnFUVUlhSExwRzlHNjAreGp3?= =?utf-8?B?SUJodWJWc3BsYWxJM2xWRGxBcitiWlhxVk9JbjYybG0rYUd4dDR3MklFbVBP?= =?utf-8?B?aFVTTEYrSWhFbFpnZU4zRVo3VE05UVNpU0loQkpLSGF4eWZSQytpbXQ2Uzdw?= =?utf-8?B?OXlxcTBTUGJpS1V0eWo4cVZSTHRCR1FhMm9qbUJsaWtEM0NCckF0YldzT1pF?= =?utf-8?B?RkFSWEUvSWdSM1oyeU92UFdqNnpmcFJYOGVCeTBJaExCRU93eW5rakZKaU01?= =?utf-8?B?c3lGRkRiTW02SVlleU1uNXBZRjV6cTlWZTNuSVdqajIvcG1mNy8yNzFmU216?= =?utf-8?B?Y0NsNTQ2dGtnVzU0RkdlTVNJOHhiT2Y1SFBFc29nd3diRXM4OGw0THVSTzFL?= =?utf-8?B?UkVZWmltN0gwTE9hVFpBMmxYaTVya0FTWkJGZnRCTnF3cWJXL0I2R1MzbFRr?= =?utf-8?B?Zm1oZ002RjZjSTJUQTRsaklJZVZMVnM0KzBuZjVFY1A3eWFTM21wNTVJNUtl?= =?utf-8?B?RWlFYTIyUG9LQ0RTNFdYdHhkRVFvaXFJWS90MjRjTkh6UHUxVnU2aXZKQ0lL?= =?utf-8?B?NUxaaWVDVkxIL2tTQzdvaVFGU0ltUHBFS0FNQzVQYzJETTBnbmVydzh6SmVo?= =?utf-8?B?d3FOcFBwRXN1bmRxdHlqdVBXTUJJbWlxQm1SZm00VTZCdFFFK21oeStIeXFS?= =?utf-8?B?dGw3TXFJTUV4OVFCMlpEN0Y3eUVQbHlaNmw5dis0ckJGaldMcDVzRFFtN3hv?= =?utf-8?B?c2xlMG9sSDJjcmxnd1hOVzJFdDI4akJiZHAycENxNkhNOElMbHNTNGQxbGtB?= =?utf-8?B?RzA5eHlrbjZYbmY4RkQveXR3bUFpbjBrd0VUc0NrekpMY3drZmQ5a1NrejdF?= =?utf-8?B?VmNjWnlRQjdxOFdxeEpMOXVwbS9TWXBLTnNSRytpczRINWIwcUZ5b1pwNUQ0?= =?utf-8?B?bnQzR1ZNNDEvUDdlNk9CNnJ0Zm9INGtNTFBjQS9sVVU0eWNHZ1g2U09pa1U5?= =?utf-8?B?bjFOU2Zvak9pQlZidUdqd1hLenNTT3R3eUlCbEZjV3NaWklRYzZ5Q294dDhw?= =?utf-8?B?QXBuU3dHTjNWdVh1eXROMFpFQWpjbkNaSkM0QlExT0hVVm14a1Rzb3V5TU1O?= =?utf-8?B?WVNZZkxJTTgxNnVSZ3duaFJaSWJLcUxEMWV4SnZtTENWU3lFeDQwb0U1YXBh?= =?utf-8?Q?ZhZmyM56umyFKwSFUodvhvS9q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59f5e124-1658-4470-d83b-08da94999913 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 08:34:24.7343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XcsutJZQMOXz1VEeUGiPWxE9VxeD5W2hPycY76uc1T6M+rU11fEMsHiyLSWpzayicrKxXXKZi0qG5avhUZ80Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7312 On 12.09.2022 10:33, Juergen Gross wrote: > On 12.09.22 10:31, Jan Beulich wrote: >> On 12.09.2022 10:23, Juergen Gross wrote: >>> On 12.09.22 10:19, Jan Beulich wrote: >>>> On 12.09.2022 07:53, Juergen Gross wrote: >>>>> Add a helper domid_to_domain() returning the struct domain pointer for >>>>> a domain give by its domid and which is known not being able to be >>>>> released (its reference count isn't incremented and no rcu_lock_domain() >>>>> is called for it). >>>>> >>>>> In order to simplify coding add an internal helper for doing the lookup >>>>> and call that from the new function and similar functions. >>>>> >>>>> Signed-off-by: Juergen Gross >>>> >>>> I don't see an issue with adding such a helper (responding to your concern >>>> in the cover letter), but I think the constraints need to be empahsized >>>> more: We already have get_knownalive_domain() and get_domain_by_id(), so >>>> how about naming the new helper get_knownalive_domain_by_id()? And then ... >>> >>> I explicitly didn't name it "get_...", as those helpers all increment the >>> reference count of the domain. And this is NOT done by the new helper. >> >> Hmm, agreed. But domid_to_domain() isn't expressing the "known alive" aspect, >> yet that's relevant to see when reviewing new uses of the function. Such uses >> aren't likely to make the reviewer go look at the function declaration when >> the function name is pretty "innocent". > > Okay, what about domid_to_knownalive_domain()? > > Or knownalive_domain_from_domid()? Either would be fine with me. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:37:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405571.648024 (Exim 4.92) (envelope-from ) id 1oXew4-0006lm-Is; Mon, 12 Sep 2022 08:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405571.648024; Mon, 12 Sep 2022 08:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXew4-0006lf-E5; Mon, 12 Sep 2022 08:36:56 +0000 Received: by outflank-mailman (input) for mailman id 405571; Mon, 12 Sep 2022 08:36:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXew3-0006lX-5B for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:36:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXew1-0000eS-CP; Mon, 12 Sep 2022 08:36:53 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.12.199]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oXew1-00019V-2l; Mon, 12 Sep 2022 08:36:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QEQK4T29rY6JygK2dwkmoLUrw8PEApJRqbyL4SvDx/8=; b=H/oyGJ3GmJ5F776mrI3RqcZhEL S0ZRELK0JUBTtvuin8q9kQB6X6N4CYMPkI5mmnm6lW12soWiAcX1S2nkijI4gB0fO6sAkb9o9g1NF Os1EgVsubYFarVuNr3sf6lyxadG7aFIry9qzx5/DMfj6Lb1iKDWK1EC5EVLXGhdbgol0=; Message-ID: Date: Mon, 12 Sep 2022 09:36:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper To: Juergen Gross , Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> Content-Language: en-US From: Julien Grall In-Reply-To: <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 12/09/2022 09:33, Juergen Gross wrote: > On 12.09.22 10:31, Jan Beulich wrote: >> On 12.09.2022 10:23, Juergen Gross wrote: >>> On 12.09.22 10:19, Jan Beulich wrote: >>>> On 12.09.2022 07:53, Juergen Gross wrote: >>>>> Add a helper domid_to_domain() returning the struct domain pointer for >>>>> a domain give by its domid and which is known not being able to be >>>>> released (its reference count isn't incremented and no >>>>> rcu_lock_domain() >>>>> is called for it). >>>>> >>>>> In order to simplify coding add an internal helper for doing the >>>>> lookup >>>>> and call that from the new function and similar functions. >>>>> >>>>> Signed-off-by: Juergen Gross >>>> >>>> I don't see an issue with adding such a helper (responding to your >>>> concern >>>> in the cover letter), but I think the constraints need to be empahsized >>>> more: We already have get_knownalive_domain() and >>>> get_domain_by_id(), so >>>> how about naming the new helper get_knownalive_domain_by_id()? And >>>> then ... >>> >>> I explicitly didn't name it "get_...", as those helpers all increment >>> the >>> reference count of the domain. And this is NOT done by the new helper. >> >> Hmm, agreed. But domid_to_domain() isn't expressing the "known alive" >> aspect, >> yet that's relevant to see when reviewing new uses of the function. >> Such uses >> aren't likely to make the reviewer go look at the function declaration >> when >> the function name is pretty "innocent". > > Okay, what about domid_to_knownalive_domain()? > > Or knownalive_domain_from_domid()? FWIW, I am fine with either. However, please don't replace 'to' with '2' if you need a internal helper. Just suffixed with 'locked' to make clear this is a version where the caller should take the lock. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:42:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405577.648034 (Exim 4.92) (envelope-from ) id 1oXf1E-0008Lj-3d; Mon, 12 Sep 2022 08:42:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405577.648034; Mon, 12 Sep 2022 08:42:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf1E-0008Lc-14; Mon, 12 Sep 2022 08:42:16 +0000 Received: by outflank-mailman (input) for mailman id 405577; Mon, 12 Sep 2022 08:42:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf1C-0008LW-26 for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:42:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60070.outbound.protection.outlook.com [40.107.6.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb9696a3-3276-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 10:42:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9126.eurprd04.prod.outlook.com (2603:10a6:20b:449::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 08:42:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 08:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb9696a3-3276-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mL4n/qRu/0KxO/7AfDh14pTQPWc3ubydazIP6MYfbYYmmuxVa3/io8ZTN+HnDPnTA2qZIE0r7qXAu1WFAaBM4fy7geUuIZkpHD09mmIcC9WU5dJMRksssFlkTOrUWGD4lH1iEJxz9ubzk0qM+wSEuNtTjhE0NiONOODoA/OprBLzRhSyGea7Zgdg5bRYO3rL5k554ujlU20N/B0r6j0fuLS6irf3YwRMJq22u5J5zLxpEUTUt2MMkbBi4FxJkSEP75+Co0GUPbbK/ALmciysEJbDii/Y2jUZqPqOn0rdEVNO3E6nrxOW/2w/ULjNhg1qmBGBDb1ZO2WA5cfBFz6K+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ynvVUh/G9AgcgTk3W2ENe33XBmw5Uw8BzR+mr2nmam4=; b=VwJd2JULQi+Z2iBt1iBysjBf6BfMTs6GddlG8rZhMNhsy8/EjY/WR1KjUlTYmowjjDjwLGmScL/XU269LBSlmrecI19kQU0NHApS0mSs/IlFZCOWtNpRnet9fY0uQjNv/uGJ5IZoF7ROKUAPPdYIQQt9RHa1xFYpMBErYgBDPw3/aQn2RfQX7796vUk82u8cARzc8t9HzKFh3g/B3xPBXiD58kp8htsRp2aWoMXPNvUVURr/OsSF8Vl312up3BPe+j5hopoavliw3ER41XB6omKulHSDuiCy/NN5GtwOl6gq3QDNf/nNfjpHEQEi2F3hou4jmPteCRcVB3kUlRg2Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynvVUh/G9AgcgTk3W2ENe33XBmw5Uw8BzR+mr2nmam4=; b=fs6IqJy29Q1f7lDPyh3uI6Jy8sRcPDYfQyhsnyZs5W/RmTii4Lxqmyqn6u+MOmQzGamB0pBu45mu9vuEdM973FHSySxx8yM/E+kTXiXGZIg42DaSLHrCz4CLHTae84HJ8YGTcGYw/TCSUQB3kRPr26tuPMGNnEmbI6/UOlouHbMXDFgS/j5BgVITnncalYkBtraOUjvuASUnpcNV27jFPJhrheYQ3dFAZB2mZS+nInKRvkBtGXpxsE9h+SpV92aRU52k0MgkfcHLH+LoryN6r3nmdR9jLcETbgjno7FJEMjZ7xxtn71TQQwNMDUvA+7hxIaFa029+uIrXe3957vOSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Sep 2022 10:42:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Juergen Gross References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0275.eurprd06.prod.outlook.com (2603:10a6:20b:45a::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9126:EE_ X-MS-Office365-Filtering-Correlation-Id: dd7bbe10-67c2-4c7a-84ba-08da949aae7b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hm/DrCZ2QWQ9qHdBktYJgZwDrqLU/K8SD2huTgm2MAQBRcC4+w2ISvumlj7S/nQxUKpelNQp9/uSnjTmk5EGh0RFVTP2DLbZ6xNpufuu2WkxtPf3a44WeSkAaV+YSAfBdPgT9SwHFsUJTn3l1QPcswQ/pE00/CSuYaYA3EKBijQ5+lJtA26slAV+uqGgEy7g+mgOSFDVGXEooi2510BRmhSzvz1q1KB305a8eKx8fMfKWnrqu/m0UyXgFaTsaosEKAm7muqy2gPkyP1z3wVlwGxK0p3lOqlhxh3ae/f4VeAqMYcw0AHN+6DDFLO/Sl1XozzervU1jjE0dERkvjOKyKtAgPBnHif8Fb2ulv+o+atHPkb6LqPjtv7VaAAFnQs2wqR/ZVXhucRGyyV9YyxIp3QdCD9zIk2B29SlFcZJvN4u3uKW2L/pTqep16qGHHsV5Ce7Ry0V9QBFPcvQ8ve9fxevzb5zUt/4mUxt0jVOfNSNqIp7ln3iNPr88CA59XEzQuO95+DPg7mzdYoGWPwip2TAY5Tr7J/mfEh8ua4yZ2XktXJ+iv4TI0dXIy/N69sGY7HLSep+w2aFDoQlKczXwfEZDXaD4MBoi5x3J5DBSP70limhgaPojRC/YjQyxIxKtHv3I2nuqGeXbKVQN7Da8XU/v71oOzAS4Q72YLvBoRnD4+PD9EPibVrKy7d1MgfY97LVGcNsudOopwFRo+TCrKVPNvdwzIelS9HaxBahUPU4tngf2N+LuDMbK3v3I+rtuvU8ZIEozaWcCBMPnuk0U5Sbzq54nxCsMuUu522COFI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(39860400002)(366004)(136003)(6506007)(186003)(2616005)(2906002)(5660300002)(8936002)(4326008)(8676002)(66556008)(66476007)(66946007)(6512007)(53546011)(86362001)(36756003)(31686004)(83380400001)(41300700001)(26005)(478600001)(6486002)(107886003)(31696002)(54906003)(6916009)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXI1bHRZQlREc0hEd3lUL2NKSERCSXk0aUI4QjdqdmlWZnVDY3BXLy82ZFZq?= =?utf-8?B?MHloTGlvbW9xczBYUEdJMkk0YWdkQkdseGZtK3dIVHN0ZHcySS9EdWMxakc4?= =?utf-8?B?dEpUcVhZVzJtanJLclM3MzN0NUR5eVRQZTdDd01TWkdxRkFKdjdwcmh2N1VW?= =?utf-8?B?Z0J1NWxKZXQ4dkhEWGtUd0NiVkV0YzlPS2FXOTV1NldCUkZRdXdZUXBYSVpL?= =?utf-8?B?NzNHckhVeWJmNldOaS9vRThDd0txVFpGZFk5Zjk5eVp3MGhsR0Q0NEhZK3Q3?= =?utf-8?B?YjJOWng1anVOZ2tLYUVJblkyY1p6MFJ0NE1ja1Y2eWV4V0xZSlJIOG5nYUhz?= =?utf-8?B?SEcxeTdJR3A3WE02emtpMjdydFd2Tkg0bHVrQXhBVHRwMEgrZU1sdzBSQUE3?= =?utf-8?B?d0t5T0J2ZnUxWm4yMUJvcmlHZ25WQkhkQjR6U0lucVlyMEdTYStVS0JjNUdF?= =?utf-8?B?UXdzcEo2K0N0dlFrNkxKNERhZTN3VjQzNEhGdWNPVXdCK0UzMnV5cDU5TnJF?= =?utf-8?B?RmhZMmNFcm9DejNyVnIvUVZ2VDQ1Vy96bTB0eVd2b1kzNk14eFdVNldEcjJw?= =?utf-8?B?OGpwSkl0enp6NytWMzBRRkRlUHJXTEt3Q1RtS0c1QU9UM1lDV1lhTTB4Zy9E?= =?utf-8?B?bFVUUm5EaWNtUU5iZkdLVG9xenZRT2pyZEJnbW11YzJZOTM1YjlJckJhZEw0?= =?utf-8?B?aXVCT08xZUxVZ1VpckNNbFduY2F4bnBObFUzM0ovTGNoTUNQWU5ualAyaE9V?= =?utf-8?B?U0kvWGt1blBUc1RQL2xiWEJPdGk3d1NyNnlNN0k2L21vMDNBald0bEVVb1RH?= =?utf-8?B?QU1ZQUVQRWRyM2EwdTBkaC9ZMDF5VGZwTHRrZ1NuejBIVE8xcTBVSXNwbVJW?= =?utf-8?B?ZEFlSklPVjh3OTJSMzJ0VTI2L0M5ZFRNdHU1UHl5NU1yZGlOenh2ZU9XTG5R?= =?utf-8?B?K2RURU9HaTJBSmhkQ0RzUi9KTUhsUXpoeXpsVkJGVEVDNlZBODB3aU83bHVE?= =?utf-8?B?WVVUMnVOU3J0a1dRc3c4SnI3bWxBY1V3aUVNTk9XSW1EcWhVSUZtRFBzV25M?= =?utf-8?B?bDE5RkxlZzdCckVnbUZ3Tk1CQ3pVZTErS1pYV21XaFd2QTBlZTdDalhnUEZV?= =?utf-8?B?VEZYQlR0WWpaNi9ZbUIydXYwc3ZJek9RWjZuenM4cFY0K085T2tlVk9BM0pG?= =?utf-8?B?TEZhbkJrbC9aNGNiN2llRlUzaUxTQlV5TzFaMjl6ODhUUUJybDJqalp4Q0hE?= =?utf-8?B?eGhOZTNoajlGT05Lc0NHeFphTE9kMU1iMFUxNUEzMTI2L00vWmZMUk41MzFq?= =?utf-8?B?OWR4V05hWG10TmR4UnZNRzlsckRwc29Hb3Z5VUFNZ1dUNm10dWhzZU9oWFJX?= =?utf-8?B?dGdqYTFSVmxDZStSWVBEMXFkcklFdzdEODhXUFpsMExvOHloTnltUURIaWlx?= =?utf-8?B?aCtJcUJHZE5reVNNYi9kWW5iamxBR2hOcHVlc0lseE1WUkh1TUhnMzVFOTJq?= =?utf-8?B?cWthSU00UW1XMTNGNk5vN1IyeTMxNDhWR1hHQ1FldllMUDI2WGdHcUQrM2pT?= =?utf-8?B?d05LaXZPaTJmdGFKLzNmYmprc1pVbDhZRDBrK3BPcVAzbkVFWWo4MDRhdUZr?= =?utf-8?B?dUZBaTNkeDMxdmtuZ2hjVHdPMEVzWmpaQ09zek1YbWRjQU8rUEVqTU9jNzhJ?= =?utf-8?B?NjJXMldrb0pxN2RPUzk1Tmh5WUVsai9VckhnbDRqcDlQT1FvVEVGT2V5YnJO?= =?utf-8?B?dXBmSHlaWGcybnhjNHE0YzBZejFYMVlqZzNmcEpIN3JBeEtIQ2Y4WElHbHJO?= =?utf-8?B?cWhodXhEZG85Q1JyenJhYi83TE5tVkpJT1ZBR3U2WWdLQ0Viek85Vk96MElD?= =?utf-8?B?NHpWYTNzRVM1NzdCc04zQnZmSlNEK3pSWXlybEhFTzVYYzRibUNRTnIrNDVC?= =?utf-8?B?WURycFp5ODNLcGZqSFdnZmZiME9ZQjFwK21zUHltUU9acThrYnh5c21jWFFV?= =?utf-8?B?cFNlUmVoUi9SNzlMZTIzUHlPRHZDOGo2NkNYcFU3S2hNRU93SmY5MGp5UDJi?= =?utf-8?B?MWhSY0ErOTlhQVlkOU1UaG1PZzZLU3k5SVVURXlPRSs2SEF1RllNbDBYTCtT?= =?utf-8?Q?EJ7vtiSz05/wKIqGbSs8PvR3w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd7bbe10-67c2-4c7a-84ba-08da949aae7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 08:42:10.0957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hT7iuK743MR/ptj/LgCx82usdNL8EzofAs83dvaqDNrl5YEIHgsjwIerhCfKrvkSjI2N1QVGVYxqrE+enkOwMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9126 On 12.09.2022 10:36, Julien Grall wrote: > On 12/09/2022 09:33, Juergen Gross wrote: >> On 12.09.22 10:31, Jan Beulich wrote: >>> On 12.09.2022 10:23, Juergen Gross wrote: >>>> On 12.09.22 10:19, Jan Beulich wrote: >>>>> On 12.09.2022 07:53, Juergen Gross wrote: >>>>>> Add a helper domid_to_domain() returning the struct domain pointer for >>>>>> a domain give by its domid and which is known not being able to be >>>>>> released (its reference count isn't incremented and no >>>>>> rcu_lock_domain() >>>>>> is called for it). >>>>>> >>>>>> In order to simplify coding add an internal helper for doing the >>>>>> lookup >>>>>> and call that from the new function and similar functions. >>>>>> >>>>>> Signed-off-by: Juergen Gross >>>>> >>>>> I don't see an issue with adding such a helper (responding to your >>>>> concern >>>>> in the cover letter), but I think the constraints need to be empahsized >>>>> more: We already have get_knownalive_domain() and >>>>> get_domain_by_id(), so >>>>> how about naming the new helper get_knownalive_domain_by_id()? And >>>>> then ... >>>> >>>> I explicitly didn't name it "get_...", as those helpers all increment >>>> the >>>> reference count of the domain. And this is NOT done by the new helper. >>> >>> Hmm, agreed. But domid_to_domain() isn't expressing the "known alive" >>> aspect, >>> yet that's relevant to see when reviewing new uses of the function. >>> Such uses >>> aren't likely to make the reviewer go look at the function declaration >>> when >>> the function name is pretty "innocent". >> >> Okay, what about domid_to_knownalive_domain()? >> >> Or knownalive_domain_from_domid()? > > FWIW, I am fine with either. However, please don't replace 'to' with '2' > if you need a internal helper. Just suffixed with 'locked' to make clear > this is a version where the caller should take the lock. Hmm - personally I dislike "_locked" suffixes on functions. If the "internal helper" aspect is to be made more explicit, then perhaps by way of prefixing a single underscore? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:44:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:44:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405582.648045 (Exim 4.92) (envelope-from ) id 1oXf3p-0000Z6-IV; Mon, 12 Sep 2022 08:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405582.648045; Mon, 12 Sep 2022 08:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf3p-0000Yv-Fo; Mon, 12 Sep 2022 08:44:57 +0000 Received: by outflank-mailman (input) for mailman id 405582; Mon, 12 Sep 2022 08:44:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf3o-0000XD-8P for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:44:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf3m-0000nL-Of; Mon, 12 Sep 2022 08:44:54 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.12.199]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oXf3m-0001ZM-H2; Mon, 12 Sep 2022 08:44:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wXqBxaeIBedPXuA/QEvE/Se+Raopi9b5Nfv557htDlw=; b=gnWKzRfMqClP/FdZw5OYX4W8em ipjYGS9ZQH7AkwlPdkMWBaYUh253sKQJjZl4wrGilko3p1OG90W1xvSZOAeCDFobBNjmindTCK1Lz gwFi9DWGQZ8ZNRVs14/37vrMAd14s4vbu04fNDFVt7i2RZDGbHGKv+5peiyS/77tDYF8=; Message-ID: <161744a4-bd01-05e0-22c9-1a1a0731845b@xen.org> Date: Mon, 12 Sep 2022 09:44:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Juergen Gross References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/09/2022 09:42, Jan Beulich wrote: > On 12.09.2022 10:36, Julien Grall wrote: >> On 12/09/2022 09:33, Juergen Gross wrote: >>> On 12.09.22 10:31, Jan Beulich wrote: >>>> On 12.09.2022 10:23, Juergen Gross wrote: >>>>> On 12.09.22 10:19, Jan Beulich wrote: >>>>>> On 12.09.2022 07:53, Juergen Gross wrote: >>>>>>> Add a helper domid_to_domain() returning the struct domain pointer for >>>>>>> a domain give by its domid and which is known not being able to be >>>>>>> released (its reference count isn't incremented and no >>>>>>> rcu_lock_domain() >>>>>>> is called for it). >>>>>>> >>>>>>> In order to simplify coding add an internal helper for doing the >>>>>>> lookup >>>>>>> and call that from the new function and similar functions. >>>>>>> >>>>>>> Signed-off-by: Juergen Gross >>>>>> >>>>>> I don't see an issue with adding such a helper (responding to your >>>>>> concern >>>>>> in the cover letter), but I think the constraints need to be empahsized >>>>>> more: We already have get_knownalive_domain() and >>>>>> get_domain_by_id(), so >>>>>> how about naming the new helper get_knownalive_domain_by_id()? And >>>>>> then ... >>>>> >>>>> I explicitly didn't name it "get_...", as those helpers all increment >>>>> the >>>>> reference count of the domain. And this is NOT done by the new helper. >>>> >>>> Hmm, agreed. But domid_to_domain() isn't expressing the "known alive" >>>> aspect, >>>> yet that's relevant to see when reviewing new uses of the function. >>>> Such uses >>>> aren't likely to make the reviewer go look at the function declaration >>>> when >>>> the function name is pretty "innocent". >>> >>> Okay, what about domid_to_knownalive_domain()? >>> >>> Or knownalive_domain_from_domid()? >> >> FWIW, I am fine with either. However, please don't replace 'to' with '2' >> if you need a internal helper. Just suffixed with 'locked' to make clear >> this is a version where the caller should take the lock. > > Hmm - personally I dislike "_locked" suffixes on functions. If the > "internal helper" aspect is to be made more explicit, then perhaps > by way of prefixing a single underscore? I am OK with that. Although, from previous discussion, I would have expected that explicit name would have been your preference ("locked" is more explicit than "_"). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 12 08:47:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 08:47:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405588.648055 (Exim 4.92) (envelope-from ) id 1oXf6S-0001O3-Vj; Mon, 12 Sep 2022 08:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405588.648055; Mon, 12 Sep 2022 08:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf6S-0001Nw-T8; Mon, 12 Sep 2022 08:47:40 +0000 Received: by outflank-mailman (input) for mailman id 405588; Mon, 12 Sep 2022 08:47:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXf6R-0001Nq-JW for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 08:47:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8dd0d292-3277-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 10:47:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 17B992279B; Mon, 12 Sep 2022 08:47:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D3490139E0; Mon, 12 Sep 2022 08:47:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wqAvMinyHmPZMgAAMHmgww (envelope-from ); Mon, 12 Sep 2022 08:47:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dd0d292-3277-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662972458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YgTqOJxFI6coZ78jbYMdppqy8+zLTF9s4a9pMzQh86c=; b=rnSGMw8xjYYTdIQBLhaTiB3fWvx7ZKj4tZ62vkMEBPLerZ90I7oRHi07fBdUFa6ij/IORS AN7uW6kKIBXKYeHWnpDGGalU7LnNwOWm1L6yWV417v7Gt6ujODBmUWPJshoK6Z7NMwi7hB YbkO38Pztt21siWmbRE9WWkfBMqD5E0= Message-ID: Date: Mon, 12 Sep 2022 10:47:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper Content-Language: en-US To: Julien Grall , Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------5nm4ThQlerYa0nUZQVbiCxOA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------5nm4ThQlerYa0nUZQVbiCxOA Content-Type: multipart/mixed; boundary="------------AoA9YMWGoaS02hf6c5aKohTH"; protected-headers="v1" From: Juergen Gross To: Julien Grall , Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH 1/2] xen: add domid_to_domain() helper References: <20220912055356.24064-1-jgross@suse.com> <20220912055356.24064-2-jgross@suse.com> <28e13b17-1296-62e4-0dc5-867b58f40ba9@suse.com> <5893a2c0-f01d-f097-16bc-2ef14a1361f8@suse.com> In-Reply-To: --------------AoA9YMWGoaS02hf6c5aKohTH Content-Type: multipart/mixed; boundary="------------eZ2hSjHL5Px8QFa0I0IfwhE2" --------------eZ2hSjHL5Px8QFa0I0IfwhE2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMTA6MzYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDEyLzA5LzIwMjIgMDk6MzMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAxMi4wOS4yMiAxMDozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMTIuMDkuMjAy MiAxMDoyMywgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gT24gMTIuMDkuMjIgMTA6MTks IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4gT24gMTIuMDkuMjAyMiAwNzo1MywgSnVlcmdl biBHcm9zcyB3cm90ZToNCj4+Pj4+PiBBZGQgYSBoZWxwZXIgZG9taWRfdG9fZG9tYWluKCkg cmV0dXJuaW5nIHRoZSBzdHJ1Y3QgZG9tYWluIHBvaW50ZXIgZm9yDQo+Pj4+Pj4gYSBkb21h aW4gZ2l2ZSBieSBpdHMgZG9taWQgYW5kIHdoaWNoIGlzIGtub3duIG5vdCBiZWluZyBhYmxl IHRvIGJlDQo+Pj4+Pj4gcmVsZWFzZWQgKGl0cyByZWZlcmVuY2UgY291bnQgaXNuJ3QgaW5j cmVtZW50ZWQgYW5kIG5vIHJjdV9sb2NrX2RvbWFpbigpDQo+Pj4+Pj4gaXMgY2FsbGVkIGZv ciBpdCkuDQo+Pj4+Pj4NCj4+Pj4+PiBJbiBvcmRlciB0byBzaW1wbGlmeSBjb2RpbmcgYWRk IGFuIGludGVybmFsIGhlbHBlciBmb3IgZG9pbmcgdGhlIGxvb2t1cA0KPj4+Pj4+IGFuZCBj YWxsIHRoYXQgZnJvbSB0aGUgbmV3IGZ1bmN0aW9uIGFuZCBzaW1pbGFyIGZ1bmN0aW9ucy4N Cj4+Pj4+Pg0KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz dXNlLmNvbT4NCj4+Pj4+DQo+Pj4+PiBJIGRvbid0IHNlZSBhbiBpc3N1ZSB3aXRoIGFkZGlu ZyBzdWNoIGEgaGVscGVyIChyZXNwb25kaW5nIHRvIHlvdXIgY29uY2Vybg0KPj4+Pj4gaW4g dGhlIGNvdmVyIGxldHRlciksIGJ1dCBJIHRoaW5rIHRoZSBjb25zdHJhaW50cyBuZWVkIHRv IGJlIGVtcGFoc2l6ZWQNCj4+Pj4+IG1vcmU6IFdlIGFscmVhZHkgaGF2ZSBnZXRfa25vd25h bGl2ZV9kb21haW4oKSBhbmQgZ2V0X2RvbWFpbl9ieV9pZCgpLCBzbw0KPj4+Pj4gaG93IGFi b3V0IG5hbWluZyB0aGUgbmV3IGhlbHBlciBnZXRfa25vd25hbGl2ZV9kb21haW5fYnlfaWQo KT8gQW5kIHRoZW4gLi4uDQo+Pj4+DQo+Pj4+IEkgZXhwbGljaXRseSBkaWRuJ3QgbmFtZSBp dCAiZ2V0Xy4uLiIsIGFzIHRob3NlIGhlbHBlcnMgYWxsIGluY3JlbWVudCB0aGUNCj4+Pj4g cmVmZXJlbmNlIGNvdW50IG9mIHRoZSBkb21haW4uIEFuZCB0aGlzIGlzIE5PVCBkb25lIGJ5 IHRoZSBuZXcgaGVscGVyLg0KPj4+DQo+Pj4gSG1tLCBhZ3JlZWQuIEJ1dCBkb21pZF90b19k b21haW4oKSBpc24ndCBleHByZXNzaW5nIHRoZSAia25vd24gYWxpdmUiIGFzcGVjdCwNCj4+ PiB5ZXQgdGhhdCdzIHJlbGV2YW50IHRvIHNlZSB3aGVuIHJldmlld2luZyBuZXcgdXNlcyBv ZiB0aGUgZnVuY3Rpb24uIFN1Y2ggdXNlcw0KPj4+IGFyZW4ndCBsaWtlbHkgdG8gbWFrZSB0 aGUgcmV2aWV3ZXIgZ28gbG9vayBhdCB0aGUgZnVuY3Rpb24gZGVjbGFyYXRpb24gd2hlbg0K Pj4+IHRoZSBmdW5jdGlvbiBuYW1lIGlzIHByZXR0eSAiaW5ub2NlbnQiLg0KPj4NCj4+IE9r YXksIHdoYXQgYWJvdXQgZG9taWRfdG9fa25vd25hbGl2ZV9kb21haW4oKT8NCj4+DQo+PiBP ciBrbm93bmFsaXZlX2RvbWFpbl9mcm9tX2RvbWlkKCk/DQo+IA0KPiBGV0lXLCBJIGFtIGZp bmUgd2l0aCBlaXRoZXIuIEhvd2V2ZXIsIHBsZWFzZSBkb24ndCByZXBsYWNlICd0bycgd2l0 aCAnMicgaWYgeW91IA0KPiBuZWVkIGEgaW50ZXJuYWwgaGVscGVyLiBKdXN0IHN1ZmZpeGVk IHdpdGggJ2xvY2tlZCcgdG8gbWFrZSBjbGVhciB0aGlzIGlzIGEgDQo+IHZlcnNpb24gd2hl cmUgdGhlIGNhbGxlciBzaG91bGQgdGFrZSB0aGUgbG9jay4NCg0KSSBjYW4ganVzdCByZW5h bWUgaXQgdG8gImRvbWlkX3RvX2RvbWFpbigpIiwgbm93IHRoYXQgdGhlIG9mZmljaWFsIGhl bHBlciB3aWxsDQpnZXQgYW5vdGhlciBuYW1lLg0KDQoNCkp1ZXJnZW4NCg== --------------eZ2hSjHL5Px8QFa0I0IfwhE2 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------eZ2hSjHL5Px8QFa0I0IfwhE2-- --------------AoA9YMWGoaS02hf6c5aKohTH-- --------------5nm4ThQlerYa0nUZQVbiCxOA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMe8ikFAwAAAAAACgkQsN6d1ii/Ey97 Jwf/XiCOZBPw+oz4jPyflGOA3O+k+erqf6j+FGvgN0adb/Y/hSXcCgIjEPPuGQQ7b/sMXo4UJKO6 BtEuDWt4cuksxiQwgrQYiweKyapBwp5Aa3+kBQkZ1hWqdXRDP6pApk6RjZgUo3Xf9uZ8o4zD3Oai +lHK7V2ZjPyLYmm65322UmRIE29ZTkcznYU4sk/hompcj6U5HSWxgGx3MNlS06PK8Or9tx0ckPC0 c12lUu8vcnoEBVYoHC6Fe57laNUyeoIiK7ycrDJD04j8a2sN1Zbz9Kp1zH0xDol4WjVlQtjkbd2Q dMoqaBDtDbD928VNj+W7n8VUBJL8AeKest8M+CIQew== =ltjD -----END PGP SIGNATURE----- --------------5nm4ThQlerYa0nUZQVbiCxOA-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 09:10:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 09:10:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405612.648066 (Exim 4.92) (envelope-from ) id 1oXfSa-00057H-Sw; Mon, 12 Sep 2022 09:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405612.648066; Mon, 12 Sep 2022 09:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfSa-00057A-QM; Mon, 12 Sep 2022 09:10:32 +0000 Received: by outflank-mailman (input) for mailman id 405612; Mon, 12 Sep 2022 09:10:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfSZ-000574-LZ for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 09:10:31 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bfae0665-327a-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 11:10:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 230831FDE8; Mon, 12 Sep 2022 09:10:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA235139E0; Mon, 12 Sep 2022 09:10:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0kuyM4X3HmOnPQAAMHmgww (envelope-from ); Mon, 12 Sep 2022 09:10:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfae0665-327a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662973830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VrFu+GWgOCpM5QiWWOb2MH9U1mQKUvazALzL+fiP0MQ=; b=Y2+pe/vFvts8o8s4l3yqnMw7BIgbd7lIHoDsk1H+/9CPjGrlVxXSvD3DxRQ0DKCdaYgvZa vdjd1NRTDRb0XYZrEm09J22FidVHHbogl+uk+CZ+D4M2pC90cdZR6TVAB1Kb2c7m/lcyvH rmEKlnJAkycZX7KTNZVAK50roUHbRNg= Message-ID: <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> Date: Mon, 12 Sep 2022 11:10:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-4-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------10N96WsrFizMoApfIgie5x2c" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------10N96WsrFizMoApfIgie5x2c Content-Type: multipart/mixed; boundary="------------sJuVWfGGh2FIS08NSnXmT3RQ"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> Subject: Re: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-4-jgross@suse.com> In-Reply-To: --------------sJuVWfGGh2FIS08NSnXmT3RQ Content-Type: multipart/mixed; boundary="------------2ZwtFVK3TybacaG4smhlRi0P" --------------2ZwtFVK3TybacaG4smhlRi0P Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDkuMjIgMTI6MTYsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVGh1LCBT ZXAgMDgsIDIwMjIgYXQgMTA6NDk6MDdBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jYWNoZWluZm8uaCBiL2Fy Y2gveDg2L2luY2x1ZGUvYXNtL2NhY2hlaW5mby5oDQo+PiBpbmRleCA4NmIyZTBkY2M0YmYu LjFhZWFmYTk4ODhmNyAxMDA2NDQNCj4+IC0tLSBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL2Nh Y2hlaW5mby5oDQo+PiArKysgYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jYWNoZWluZm8uaA0K Pj4gQEAgLTIsNiArMiwxMSBAQA0KPj4gICAjaWZuZGVmIF9BU01fWDg2X0NBQ0hFSU5GT19I DQo+PiAgICNkZWZpbmUgX0FTTV9YODZfQ0FDSEVJTkZPX0gNCj4+ICAgDQo+PiArLyogS2Vy bmVsIGNvbnRyb2xzIE1UUlIgYW5kL29yIFBBVCBNU1JzLiAqLw0KPj4gK2V4dGVybiB1bnNp Z25lZCBpbnQgY2FjaGVfZ2VuZXJpYzsNCj4gDQo+IFNvIHRoaXMgc2hvdWxkIGJlIGNhbGxl ZCBzb21ldGhpbmcgbW9yZSBkZXNjcmlwdGl2ZSBsaWtlDQo+IA0KPiAJbWVtb3J5X2NhY2hp bmdfdHlwZXMNCg0KSW4gdGhlIGVuZCB0aGlzIHZhcmlhYmxlIGRvZXNuJ3Qgc3BlY2lmeSB3 aGljaCBjYWNoaW5nIHR5cGVzIGFyZSBhdmFpbGFibGUsDQpidXQgdGhlIHdheXMgdG8gc2Vs ZWN0L2NvbnRyb2wgdGhlIGNhY2hpbmcgdHlwZXMuDQoNClNvIHdoYXQgYWJvdXQgIm1lbW9y eV9jYWNoaW5nX3NlbGVjdCIgb3IgIm1lbW9yeV9jYWNoaW5nX2NvbnRyb2wiIGluc3RlYWQ/ DQoNCj4gb3Igc28gdG8gZGVub3RlIHRoYXQgdGhpcyBpcyBhIGJpdGZpZWxkIG9mIHN1cHBv cnRlZCBtZW1vcnkgY2FjaGluZw0KPiB0ZWNobm9sb2dpZXMuIFRoZSBjb2RlIHRoZW4gd291 bGQgcmVhZCBhcw0KPiANCj4gCWlmIChtZW1vcnlfY2FjaGluZ190eXBlcyAmIENBQ0hFX01U UlIpDQo+IA0KPiBUaGUgbmFtZSdzIHN0aWxsIG5vdCBvcHRpbWFsIHRobyAtIG5lZWRzIG1v cmUgYnJvb2Rpbmcgb3Zlci4NCj4gDQo+PiArI2RlZmluZSBDQUNIRV9HRU5FUklDX01UUlIg MHgwMQ0KPj4gKyNkZWZpbmUgQ0FDSEVfR0VORVJJQ19QQVQgIDB4MDINCj4gDQo+IEFuZCB0 aG9zZSBzaG91bGQgYmUgQ0FDSEVfe01UUlIsUEFUfS4NCg0KRmluZSB3aXRoIG1lLg0KDQo+ PiAgIHZvaWQgY2FjaGVpbmZvX2FtZF9pbml0X2xsY19pZChzdHJ1Y3QgY3B1aW5mb194ODYg KmMsIGludCBjcHUpOw0KPj4gICB2b2lkIGNhY2hlaW5mb19oeWdvbl9pbml0X2xsY19pZChz dHJ1Y3QgY3B1aW5mb194ODYgKmMsIGludCBjcHUpOw0KPj4gICANCj4+IGRpZmYgLS1naXQg YS9hcmNoL3g4Ni9rZXJuZWwvY3B1L2NhY2hlaW5mby5jIGIvYXJjaC94ODYva2VybmVsL2Nw dS9jYWNoZWluZm8uYw0KPj4gaW5kZXggNjY1NTY4MzNkN2FmLi4zYjA1ZDNhZGU3YTYgMTAw NjQ0DQo+PiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L2NhY2hlaW5mby5jDQo+PiArKysg Yi9hcmNoL3g4Ni9rZXJuZWwvY3B1L2NhY2hlaW5mby5jDQo+PiBAQCAtMzUsNiArMzUsOSBA QCBERUZJTkVfUEVSX0NQVV9SRUFEX01PU1RMWShjcHVtYXNrX3Zhcl90LCBjcHVfbGxjX3No YXJlZF9tYXApOw0KPj4gICAvKiBTaGFyZWQgTDIgY2FjaGUgbWFwcyAqLw0KPj4gICBERUZJ TkVfUEVSX0NQVV9SRUFEX01PU1RMWShjcHVtYXNrX3Zhcl90LCBjcHVfbDJjX3NoYXJlZF9t YXApOw0KPj4gICANCj4+ICsvKiBLZXJuZWwgY29udHJvbHMgTVRSUiBhbmQvb3IgUEFUIE1T UnMuICovDQo+PiArdW5zaWduZWQgaW50IGNhY2hlX2dlbmVyaWM7DQo+IA0KPiBUaGlzIHNo b3VsZCBlaXRoZXIgYmUgX19yb19hZnRlcl9pbml0IGFuZCBpbml0aWFsaXplZCB0byAwIG9y IHlvdSBuZWVkDQo+IGFjY2Vzc29ycy4uLg0KDQpPa2F5Lg0KDQo+IA0KPj4gICB1MzIgbnVt X3Zhcl9yYW5nZXM7DQo+PiAtc3RhdGljIGJvb2wgX19tdHJyX2VuYWJsZWQ7DQo+PiAtDQo+ PiAtc3RhdGljIGJvb2wgbXRycl9lbmFibGVkKHZvaWQpDQo+PiAtew0KPj4gLQlyZXR1cm4g X19tdHJyX2VuYWJsZWQ7DQo+PiAtfQ0KPj4gK3N0YXRpYyBib29sIG10cnJfZW5hYmxlZDsN Cj4gDQo+IEhtbSwgSSBkb24ndCBsaWtlIHRoaXMuIFRoZXJlJ3Mgd2F5IHRvbyBtYW55IGJv b2xlYW4gZmxhZ3MgaW4gdGhlIG10cnINCj4gY29kZS4gVGhlcmUncyBtdHJyX3N0YXRlLmVu YWJsZWQgdG9vLiA7LVwNCj4gDQo+IENhbiB3ZSBzZXQgKG9yIGNsZWFyKSBYODZfRkVBVFVS RV9NVFJSIHRvIGRlbm90ZSBNVFJSIGVuYWJsZW1lbnQgc3RhdHVzDQo+IGFuZCBnZXQgcmlk IG9mIG9uZSBtb3JlIGJvb2xlYW4gZmxhZz8NCg0KSSdsbCBoYXZlIGEgbG9vay4NCg0KPiAN Cj4gLi4uDQo+IA0KPj4gICB2b2lkIF9faW5pdCBtdHJyX2JwX2luaXQodm9pZCkNCj4+ICAg ew0KPj4gKwlib29sIHVzZV9nZW5lcmljID0gZmFsc2U7DQo+PiAgIAl1MzIgcGh5c19hZGRy Ow0KPj4gICANCj4+ICAgCWluaXRfaWZzKCk7DQo+PiBAQCAtNjk0LDYgKzY5MSw3IEBAIHZv aWQgX19pbml0IG10cnJfYnBfaW5pdCh2b2lkKQ0KPj4gICANCj4+ICAgCWlmIChib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfTVRSUikpIHsNCj4+ICAgCQltdHJyX2lmID0gJmdlbmVyaWNf bXRycl9vcHM7DQo+PiArCQl1c2VfZ2VuZXJpYyA9IHRydWU7DQo+PiAgIAkJc2l6ZV9vcl9t YXNrID0gU0laRV9PUl9NQVNLX0JJVFMoMzYpOw0KPj4gICAJCXNpemVfYW5kX21hc2sgPSAw eDAwZjAwMDAwOw0KPj4gICAJCXBoeXNfYWRkciA9IDM2Ow0KPj4gQEAgLTc1NSwxNSArNzUz LDE4IEBAIHZvaWQgX19pbml0IG10cnJfYnBfaW5pdCh2b2lkKQ0KPj4gICAJfQ0KPj4gICAN Cj4+ICAgCWlmIChtdHJyX2lmKSB7DQo+PiAtCQlfX210cnJfZW5hYmxlZCA9IHRydWU7DQo+ PiAtCQlzZXRfbnVtX3Zhcl9yYW5nZXMoKTsNCj4+ICsJCW10cnJfZW5hYmxlZCA9IHRydWU7 DQo+PiArCQlzZXRfbnVtX3Zhcl9yYW5nZXModXNlX2dlbmVyaWMpOw0KPiANCj4gWW91IGRv bid0IG5lZWQgdXNlX2dlbmVyaWMgZWl0aGVyOg0KPiANCj4gCQlzZXRfbnVtX3Zhcl9yYW5n ZXMobXRycl9pZiA9PSBnZW5lcmljX210cnJfb3BzKTsNCj4gDQo+IChUaGUgcmVhc29uIGJl aW5nIEkgd2FubmEgZ2V0IHJpZCBvZiB0aGF0IG5hc3R5IG1pbmVmaWVsZCBvZiBib29sZWFu DQo+IHZhcnMgYWxsIHJvdW5kIHRoYXQgY29kZSkuDQoNCkZpbmUgd2l0aCBtZS4NCg0KDQpK dWVyZ2VuDQo= --------------2ZwtFVK3TybacaG4smhlRi0P Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2ZwtFVK3TybacaG4smhlRi0P-- --------------sJuVWfGGh2FIS08NSnXmT3RQ-- --------------10N96WsrFizMoApfIgie5x2c Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMe94UFAwAAAAAACgkQsN6d1ii/Ey8j mAgAiwaZ2skUEx074gzV7xFZp/2XhoEokvt+MYcB/QkwhkccPft+ZZbQkDx7l1gZ8INDlXJVOG90 ZmTCZORv9SzNGzhwLzKZNAT76KjLPNieYcd2GMQJ5jZ3Fu847UQm2FI2QyJIsV2Ua+Mnl0zY/8RN 2crlpSCm/16q8Df1RyyHV/mNALh6IVgm8TWCkgEzEFjy6hapKWFrQ5f2yFWAbK6IHK6b/LhViY13 0l23m8Z44ZodoTNaUZ3bb2pgRA7QTVHvkAsfRI8wWe6gPiJ6C+J3m7Frj5hF27suKCYlki8bi9aH z9fTfWTC6nB33r8wt0lFJ4pOoO9/u1tgIHhN0gmuFw== =VpX0 -----END PGP SIGNATURE----- --------------10N96WsrFizMoApfIgie5x2c-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 09:11:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 09:11:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405615.648078 (Exim 4.92) (envelope-from ) id 1oXfT9-0005bn-5v; Mon, 12 Sep 2022 09:11:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405615.648078; Mon, 12 Sep 2022 09:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfT9-0005bg-2s; Mon, 12 Sep 2022 09:11:07 +0000 Received: by outflank-mailman (input) for mailman id 405615; Mon, 12 Sep 2022 09:11:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfT7-0005Zi-Cg for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 09:11:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3be265c-327a-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 11:11:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 38F961FDE3; Mon, 12 Sep 2022 09:11:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F0D79139E0; Mon, 12 Sep 2022 09:11:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qZKHOaf3HmPqPQAAMHmgww (envelope-from ); Mon, 12 Sep 2022 09:11:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3be265c-327a-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662973864; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/rss+wN69vk7SKXGViczeJ2vZjQCYX8Ku7x2rsknaWo=; b=ZB/31XLQsOoU/RbCydy6naAXBbAIfxyXgPsx7Ah+Otc6/aEyaU8peWRBQtBf7o3bVdTE/X M24fjyhBQsIWEh8tXEOz5TnuC5x8wnUYy2yrPs1/cxnT8Zah+uZFrEMVOSJ76xKYqjhrE8 yXJR9HrM8O2atcMqbzDYuNk86vl/C84= Message-ID: <15b8c614-b9cf-86fa-1a28-8615cba55e1b@suse.com> Date: Mon, 12 Sep 2022 11:11:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 04/10] x86: move some code out of arch/x86/kernel/cpu/mtrr Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-5-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3lpSR0la42BkQaTloOYqBR4w" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3lpSR0la42BkQaTloOYqBR4w Content-Type: multipart/mixed; boundary="------------O0QCQf7J6rWG9IdHKP3hZ6ZN"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <15b8c614-b9cf-86fa-1a28-8615cba55e1b@suse.com> Subject: Re: [PATCH v3 04/10] x86: move some code out of arch/x86/kernel/cpu/mtrr References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-5-jgross@suse.com> In-Reply-To: --------------O0QCQf7J6rWG9IdHKP3hZ6ZN Content-Type: multipart/mixed; boundary="------------oXEI8a1gD40R0kmIY0TC9nwq" --------------oXEI8a1gD40R0kmIY0TC9nwq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDkuMjIgMTM6MDIsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVGh1LCBT ZXAgMDgsIDIwMjIgYXQgMTA6NDk6MDhBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFByZXBhcmUgbWFraW5nIFBBVCBhbmQgTVRSUiBzdXBwb3J0IGluZGVwZW5kZW50IGZy b20gZWFjaCBvdGhlciBieQ0KPj4gbW92aW5nIHNvbWUgY29kZSBuZWVkZWQgYnkgYm90aCBv dXQgb2YgdGhlIE1UUlIgc3BlY2lmaWMgc291cmNlcy4NCj4gDQo+IFRoaXMgbmVlZHMgdG8g YmUgdHdvIHBhdGNoZXMgYXQgbGVhc3Q6IGZpcnN0IG9uZSBpcyBvbmx5ICptZWNoYW5pY2Fs Kg0KPiBtb3ZlIHdpdGhvdXQgYW55IGNoYW5nZXMuIFRoZSBuZXh0IG9uZShzKSBkbyB0aGUg cmVuYW1pbmcgYW5kIG90aGVyDQo+IGNoYW5nZXMgZXRjLiBPdGhlcndpc2UgcmV2aWV3aW5n IGl0IGlzIHVubmVjZXNzYXJpbHkgY29tcGxpY2F0ZWQuDQoNCk9rYXkuDQoNCg0KSnVlcmdl bg0KDQo= --------------oXEI8a1gD40R0kmIY0TC9nwq Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------oXEI8a1gD40R0kmIY0TC9nwq-- --------------O0QCQf7J6rWG9IdHKP3hZ6ZN-- --------------3lpSR0la42BkQaTloOYqBR4w Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMe96cFAwAAAAAACgkQsN6d1ii/Ey/m Wwf9He8a1dlZ/LU5PwlPAGLpG96aM+6b4hx8TRAvRtqknnoEpl1BbU4eChVXjUnDunE3TCNHwYhh S2agr/UyPGhJ/pxgVayFhfRkZ9yo90Szm8pPFo0YWoEfOrA6HxqhXWkz+JVqrMVqfuWn81YijmYz 2AG/d4byCZNlXgBnweR+z0k2bzl7h6ledO8xXG6kaf1W94+JVb5jtbEJ8pdcwRjtfy5WF652omwZ BiLYp0VhmMvPDBwB2ufoU1uus/Ys3t2egLxmBy+6A3zboNsbGBBVAGaDCur+fEoQu/rg9mk6CEbC 3b/gUTWJ3NHCdAoviky1izlhbRD/MoJ6Cm0+uLpuFQ== =zM4m -----END PGP SIGNATURE----- --------------3lpSR0la42BkQaTloOYqBR4w-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 09:27:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 09:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405631.648089 (Exim 4.92) (envelope-from ) id 1oXfig-0007bD-K8; Mon, 12 Sep 2022 09:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405631.648089; Mon, 12 Sep 2022 09:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfig-0007b6-FY; Mon, 12 Sep 2022 09:27:10 +0000 Received: by outflank-mailman (input) for mailman id 405631; Mon, 12 Sep 2022 09:27:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfig-0007aw-3T; Mon, 12 Sep 2022 09:27:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfif-0001Xc-VP; Mon, 12 Sep 2022 09:27:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfif-000430-I0; Mon, 12 Sep 2022 09:27:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXfif-00071q-HN; Mon, 12 Sep 2022 09:27:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xPAjnk3Vf/D/GroJRlNrEWB8NszOrOBmy1wEC4R6uz8=; b=FH7wT5KQZUVXW09GXDVAix3EkV xnCDNuBcF8xuK+la5iW1l0AhSxuFfXMecUsqkM5a+IsgApJ3POHCV6v35upsnvHr9aD9s6BqPQDPn D6/eCkV6l52H4P/zLKR24Gzs3zIaGTbOFFuLwHyaxaoRbNc02OXg2kK/NBwPnKMgcnmw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173146: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b48469fcdb42cea237578e000cfb82b13f05b0ff X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 12 Sep 2022 09:27:09 +0000 flight 173146 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173146/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt b48469fcdb42cea237578e000cfb82b13f05b0ff baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 794 days Failing since 151818 2020-07-11 04:18:52 Z 793 days 775 attempts Testing same since 173109 2022-09-10 04:19:58 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122707 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 10:04:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 10:04:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405646.648100 (Exim 4.92) (envelope-from ) id 1oXgIY-00045o-El; Mon, 12 Sep 2022 10:04:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405646.648100; Mon, 12 Sep 2022 10:04:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgIY-00045h-Ba; Mon, 12 Sep 2022 10:04:14 +0000 Received: by outflank-mailman (input) for mailman id 405646; Mon, 12 Sep 2022 10:04:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgIW-00045X-K5; Mon, 12 Sep 2022 10:04:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgIW-0002Df-GU; Mon, 12 Sep 2022 10:04:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgIW-0007f1-0X; Mon, 12 Sep 2022 10:04:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXgIV-000386-U5; Mon, 12 Sep 2022 10:04:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w8qD6BZBJwipR5ZMAUNlVGtEd/00/nWURQdh+HmyJTY=; b=rnBYTPh6ldqRu4MBfkCLyQgK5n UM7aK9ivaV93stHimxweLbufqPn+/yt44ml8k7iqrPQ69iM1i4o5DrWe+e+/qePRlanQrI04AkwNY lrEpSC4Dmun5NuRWIVnWvF5d6sbCzUj7RiyWqpt0JbSpLMPx05mgrQRQ3asMPm2JYWHg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173142: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Mon, 12 Sep 2022 10:04:11 +0000 flight 173142 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173142/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 173136 pass in 173142 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173136 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173136 blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173136 like 172108 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173136 like 172128 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173136 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173136 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173136 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173136 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173136 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173136 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 39 days Failing since 172384 2022-08-11 11:13:58 Z 31 days 68 attempts Testing same since 173008 2022-09-05 15:47:43 Z 6 days 14 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 10:17:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 10:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405690.648129 (Exim 4.92) (envelope-from ) id 1oXgVR-00075h-W2; Mon, 12 Sep 2022 10:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405690.648129; Mon, 12 Sep 2022 10:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgVR-00075a-S6; Mon, 12 Sep 2022 10:17:33 +0000 Received: by outflank-mailman (input) for mailman id 405690; Mon, 12 Sep 2022 10:17:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgVQ-00075N-Do; Mon, 12 Sep 2022 10:17:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgVQ-0002SR-Bo; Mon, 12 Sep 2022 10:17:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXgVP-0000C4-T2; Mon, 12 Sep 2022 10:17:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXgVP-00033n-Sd; Mon, 12 Sep 2022 10:17:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GaI+2w4hBwDHbgMEDpBvaYiN95ogHXjPpPfIyJOLsHk=; b=RbnXbG1v7uKmGRKVh7xZIKPOd8 b/nPJPd8oMuAhLHI86QElTGqoNhhfCIs+h9xFH2gxYPoptbMO9DEBAEq5GT7BZbTp1gHOud3XVbuN gThP+++T6NXi7iH5AxHIVALMJCVtGy+fYS9T1oMtTpt1BhNCSInYDJ23EIGy5zd3oA6w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173148: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 10:17:31 +0000 flight 173148 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173148/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 39 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 294 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 11:58:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 11:58:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405724.648140 (Exim 4.92) (envelope-from ) id 1oXi4k-000200-6u; Mon, 12 Sep 2022 11:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405724.648140; Mon, 12 Sep 2022 11:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi4k-0001zt-3m; Mon, 12 Sep 2022 11:58:06 +0000 Received: by outflank-mailman (input) for mailman id 405724; Mon, 12 Sep 2022 11:58:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi4j-0001zj-4X; Mon, 12 Sep 2022 11:58:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi4j-000429-1X; Mon, 12 Sep 2022 11:58:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi4i-0008B3-EL; Mon, 12 Sep 2022 11:58:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXi4i-0001xS-Dv; Mon, 12 Sep 2022 11:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HnpPMmfKfFIJiKFYWeV67P9t+r3XDN8mK3zWQy3Weso=; b=Oy6dXK4Cn0PPElx/JblHRlnv75 7nnycQgBrcwGxxBTohDPjhahc6XlCR0NEPFCs6j2xP5I3pZAVkqPt/AX1iWnVD/+NyMQIGcv7joA7 L193v6SvOy3zA6xzTb8xDnAgvwsnHskGEG4DblBweyVrIxZam+X6JigA2nVbVm9D6Cag=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173144: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c X-Osstest-Versions-That: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c From: osstest service owner Date: Mon, 12 Sep 2022 11:58:04 +0000 flight 173144 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173144/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173126 build-i386-libvirt 6 libvirt-build fail like 173126 build-arm64-libvirt 6 libvirt-build fail like 173126 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173126 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173126 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173126 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173126 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173126 build-armhf-libvirt 6 libvirt-build fail like 173126 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173126 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173126 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173126 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173126 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c baseline version: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c Last test of basis 173144 2022-09-12 01:54:20 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Sep 12 11:59:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 11:59:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405734.648151 (Exim 4.92) (envelope-from ) id 1oXi6A-0002b8-Ls; Mon, 12 Sep 2022 11:59:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405734.648151; Mon, 12 Sep 2022 11:59:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6A-0002b1-J3; Mon, 12 Sep 2022 11:59:34 +0000 Received: by outflank-mailman (input) for mailman id 405734; Mon, 12 Sep 2022 11:59:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi69-0002ar-MN for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 11:59:33 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55845897-3292-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 13:59:21 +0200 (CEST) Received: from MW4PR03CA0063.namprd03.prod.outlook.com (2603:10b6:303:b6::8) by CY8PR12MB7561.namprd12.prod.outlook.com (2603:10b6:930:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Mon, 12 Sep 2022 11:59:27 +0000 Received: from CO1NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::7c) by MW4PR03CA0063.outlook.office365.com (2603:10b6:303:b6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19 via Frontend Transport; Mon, 12 Sep 2022 11:59:27 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT069.mail.protection.outlook.com (10.13.174.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Mon, 12 Sep 2022 11:59:26 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 06:59:25 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 12 Sep 2022 06:59:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55845897-3292-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LH8fyNlXtdWQloh+/Q2fQr4GzzT6f7e+W76uvbDNG8kWhLrX3q14O3BPupCLrWwyxpkqgcYhQ6vTMLNvjnx3wmZzt+kGI4SeVhAecWQ4uVZkBTR690u52aIi3LKRsbVCseFaUKIHHQyrJklZ1xryfb0ijKHM7xiRRPEYmQHOYcu6eU5n6rfXC7LY/KdqhVZifsyeO3PI5JSXbU+OXgwRCDzLBQZFtM5/XHNOqqQUvmCi1FNSD/DhXHC6Bk2halZxOj1+BrCOJD9UDK0nV57MSUZBEG9DJT/W6RZS7s5bCdVzKYdvklNhpJUwDGg8nerQXjXnCQGIyaXgH46BZTD4SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=niQY12MejCdIqYR3XmRD1PiRy2OZQos16SZwajgZ1GE=; b=HNJeZQN4NkLYVsbEHH41PzrfE+MmMRHH81vSzkGqn4ptzL8I86ST+aqbHq8iKZhB4new/+Tj4dTAhmXWgljncbP7nHepNd/gyfqEtfPhKBi88gycRWRVrDN9QxOslt0xh+BbWeodibVdP2Q1eSejBMWz8Yd/uDi5I5YoBJE4Zjk4O+Wp2/NJLr0Zp68IfW5XzrmBw6FrvyylWnPQ/Usd9X6paiaaflVK1FXfKQbMYfClC8PiloAKJC2HktHPHyHwX7pvl+CXDc4t1d7o0/KvZKBecC5O3Y6fCcE/J3NUbM1cZr399HeDhqj6W6XIkCasY0wLSmuenS9K0xN0Se6DgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=niQY12MejCdIqYR3XmRD1PiRy2OZQos16SZwajgZ1GE=; b=grqZw+pmo8nEld8j+NKrmaCxuWNqgp4nfQMTmlmj749QGTVkWs+ZAJymm+RtykFOLnu+0dtdblfLiOegbj11KdVF3CcT6SgWb+Av48RoDQEsenSVqfXADhZvACzVxHtkrMapSwgbFCa8ZwkabeWYxhgeC0ozE1iZ21xLbK1gOUU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder] Update README.md Date: Mon, 12 Sep 2022 13:59:18 +0200 Message-ID: <20220912115918.19496-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT069:EE_|CY8PR12MB7561:EE_ X-MS-Office365-Filtering-Correlation-Id: bad0abd5-8687-417e-b511-08da94b63de8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YQlwub6X6naJ7nwSwRB3c9UbaeWsxJe9GemawNXafeDuLmmzEwScbC3e3NFgQNCbI2F/Yx5E9uiK3FKLRuK3OnNUckJQq7t6hB62g3qyt5YrlNQTYTxDVrr9a8r/dNvShpA3ibeT4Lvx6aIYy3yHZtDxLJLxMblW1KiD/7pkabeV45WHaO+geSUHogeMELXSuy5BMmsIKrePy33nrck2j9yhuA7gq5W0hBA/1urgOi4WJJbvUIdJ5KDcr/fZQ1mjPQHkpsXigdQU665155j06WBWmk8ho0Cb+lCH/J+fzInYEB1d/AQAGlPd7W5l6TGdp6NEdKsTeHWglqXDSpN1kJF5OcBDkKnwirEth9DZ69nsZeAuxhseGZuMfVb24ZV7Jtd2FE/xkzR6dv3Ua6gYkUxqJ5dL0kKujou3/pTOeeFdbDk/EapkDUtXFutmBLtuK4Oiq5jXtOFFjbLGlAtmQrOXAJalH1FNyaoGU0vxkiQjmUS+eFrkBTJx+MCNIOvxtUig0S89J18jntu9qQaunPBMN7+qntsKnncE5BnSQM8I4H3WRGSvIC7hWz2uChb79t01NOC+DLEHCLwLMmtq3vXpClTJJkjD4NvXFDLqWx5BFEV8QUy9o/uKxmcD6sEXJnxsZi6N4g2MhC/V5HMrqY4LE5BgDkcgdHBQMs02gmIR9ua3xFqTeFsnEUTa+VXfaXxjqBccdNcMVZO5VCKK9rmxwW/hdogn02Nl5NfWr0hi5yWhnTWhlvPtF+yro8jji8K0/cVYg7I7kjkU3s/PHfyfNhvFX0q8bMa2MXMPoOCCv2fzeR8gBHHeejupEq7i X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(47076005)(36860700001)(82740400003)(86362001)(356005)(81166007)(5660300002)(15650500001)(1076003)(83380400001)(6666004)(336012)(426003)(186003)(2616005)(82310400005)(41300700001)(26005)(478600001)(54906003)(70586007)(6916009)(8936002)(40480700001)(40460700003)(8676002)(4326008)(36756003)(70206006)(316002)(2906002)(44832011)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 11:59:26.8091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bad0abd5-8687-417e-b511-08da94b63de8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7561 Get rid of references to XEN_PASSTHROUGH_PATHS, as there is no such option and it should be replaced with DOMU_PASSTHROUGH_PATHS[number]. Update PASSTHROUGH_DTS_REPO example. The directory storing partial device trees is now device-trees-2021.2/zcu102 instead of device-trees-2021.2. Signed-off-by: Michal Orzel --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 041818349954..da9ba788a3bf 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ BOOT_CMD="booti" DEVICE_TREE="mpsoc.dtb" XEN="xen" XEN_CMD="console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1 bootscrub=0 vwfi=native sched=null" -PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2" +PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2/zcu102" DOM0_KERNEL="Image-dom0" DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused" DOM0_RAMDISK="dom0-ramdisk.cpio" @@ -99,9 +99,9 @@ Where: - PASSTHROUGH_DTS_REPO specifies the git repository and/or the directory which contains the partial device trees. This is optional. However, if - this is specified, then XEN_PASSTHROUGH_PATHS need to be specified. + this is specified, then DOMU_PASSTHROUGH_PATHS[number] need to be specified. uboot-script-gen will compile the partial device trees which have - been specified in XEN_PASSTHROUGH_PATHS. + been specified in DOMU_PASSTHROUGH_PATHS[number]. - DOM0_KERNEL specifies the Dom0 kernel file to load. For dom0less configurations, the parameter is optional. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 11:59:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 11:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405735.648162 (Exim 4.92) (envelope-from ) id 1oXi6J-0002u7-Us; Mon, 12 Sep 2022 11:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405735.648162; Mon, 12 Sep 2022 11:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6J-0002tv-Qo; Mon, 12 Sep 2022 11:59:43 +0000 Received: by outflank-mailman (input) for mailman id 405735; Mon, 12 Sep 2022 11:59:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6I-0002ar-Gc for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 11:59:42 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2054.outbound.protection.outlook.com [40.107.220.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5bb4e861-3292-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 13:59:31 +0200 (CEST) Received: from DM5PR06CA0089.namprd06.prod.outlook.com (2603:10b6:3:4::27) by BY5PR12MB4855.namprd12.prod.outlook.com (2603:10b6:a03:1dd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Mon, 12 Sep 2022 11:59:37 +0000 Received: from DM6NAM11FT081.eop-nam11.prod.protection.outlook.com (2603:10b6:3:4:cafe::39) by DM5PR06CA0089.outlook.office365.com (2603:10b6:3:4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Mon, 12 Sep 2022 11:59:37 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT081.mail.protection.outlook.com (10.13.172.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Mon, 12 Sep 2022 11:59:37 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 06:59:36 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 04:59:36 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 12 Sep 2022 06:59:35 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bb4e861-3292-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q4V5KrNzU1EkpuV5w91+bSgm1hytTwF/Ib8Hzi+Z7StE1aMJF4AdCsVL0hJNNZcbs1cIx8U/5X5FeeYjH5g0fhc7ZF6dmUsdxmcymfr2lmcrgaRLHR4ZmjKWeAkDIYWLP45uUhpUQKiKQl+2como7Xch+DoG7b9pZ7isFlAV6mp2p5ImwYczRNId6HP2ns9/3gtFJKpsmbe4Sf/uOq331UpUxqeOpA8DA/+u2igsdtC97sJUJATn/ehGa75qI2Zsjb/Nq/kSZ+avdH7GJRFlXhIKMEaucCdFWetTalUUEqihoxI5N8/U4Swn8YJH7zV1v/JLHYj8S2kVg/CUflPrGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4TOAwYTze3mjvpIMtporCy8pJQTnjRW/arh7mPjxADM=; b=VMfkaVtdX2LlV33FD/QUg5HjIa2fwM0EX9Cr9gY4ab8mUBfkDxr9WnWLG5PPXjcf8n3DZnzIhAHyStCKz61pGGoDEBhcYPZ1w8Yw345TA0ifUzSDBnSVsnYSc9qbcrqoAxgba8/u33B7oP3HtYoSKTkLt27gx30g0pt/vyjps4NSglC2F8uQPbK2RJkRmMDbCD8oKLDbCW/jBH2p0oJPVc0b0dYukvqyBmUhuIjzoJxg+v5f6OkLha6f6CJmgIb+hWUFoZW8ccDzbnWy7p0x4QcOky/1LT4QipRyVe4itFhdzvZRkSDmZwoyA0c6fkSg8WBtvOef0s60SsJrRevktQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4TOAwYTze3mjvpIMtporCy8pJQTnjRW/arh7mPjxADM=; b=aQrxpUJxJW+R0GhR4Z1tD/Wd7/JAKSz/AJnxSu2DUPqoFHbavpXNjstpcaDZJykJeh0aTIk8fDPPWYwOO+K/ALZXAFamxJbHzkesrLSw4c8qMPB1rzaIQxkgkSc+CvKccJ4nnFX8orKJ/HhSG5KsWUmCegExy7Yq0qNtRsDBTLY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder 0/2] Use lopper to generate partial dts Date: Mon, 12 Sep 2022 13:59:32 +0200 Message-ID: <20220912115934.19552-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT081:EE_|BY5PR12MB4855:EE_ X-MS-Office365-Filtering-Correlation-Id: b2392cac-3c7c-4f4b-c38e-08da94b6440e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OKzx2IDP9QwGFAPvASKdTSXULuct5SN9JixE0aBl+NnoWbbMJwliJs2pW7AF+3W0AWIuaHqa35Q4nfnyy1QdjJX0OayUo2tmFzOfiGNMd9VBq4MbmGWoQvAasJpkmCm153W5k/y9EXbh1olulJiO+I9i1NCth1Ntwqt814OQSasriRvsWuoKA8826a/JN/0l1NlPKVzdic9qrCt+s2RCOg7DsXkC3BwFlcsxZ0zjCLpsbGQMubH+uPtJEpALVBCATnNp9Mn5xrqbbpsYat3iuS/ZiFxdzFYCmqJDjxdsBbY7oPnYm8LbukvgEIiciYLzeQGjjKShHCRUj+qugQp45Lhwa3sLjtErsMu9PzuN5FmAJiD1LPAqzRQ3Dfi1Go6JzOR7tbX5a2NuV4s081epDl9km0UCSL0itAsWxKPdNRzgmpogU6oDE0xuTe1ExOwUTjKQvmerFaRCBS5QnbfNxTsUGq+IrlSnjmrnr2zwWLryQTBQ1rrfVIh3cfCvz87VlweLW2uDztMqybFqcrqMtYFF989BP+EgG++/nYTkU4eNuc+QxS0c8s2S5407fyWrqZHyl24MjLaIlkzF0qh+J0heRTZ42d1gOczx8HxJBpAksWwVP5GCZEFO3AjH3BB+PhEvLoc10E3hVr9zcEYd3IWZKjkPFCbixTsVEaPBjsiDDRTTH0DE7/R7ofeTpBWi3nq8bfjBKWEleEynDG64JbMBq6fqXVFOKAvwD6SdLzkpiWC4UmGckTpc79iRPcdKi0np4JGG5M3VPIVu+xVpVBvYkBJvj7tqGt9LtNZ+B05nL+5OJtDGDoPscoApcePLnboFQk9ycWk/pPVie7GXrg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(40470700004)(46966006)(36840700001)(40480700001)(8936002)(186003)(5660300002)(82310400005)(316002)(44832011)(2906002)(4744005)(41300700001)(2616005)(1076003)(6666004)(26005)(478600001)(336012)(47076005)(966005)(83380400001)(6916009)(426003)(54906003)(40460700003)(81166007)(356005)(70206006)(70586007)(86362001)(8676002)(4326008)(36756003)(82740400003)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 11:59:37.2029 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2392cac-3c7c-4f4b-c38e-08da94b6440e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT081.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4855 This patch series introduces support to generate automatically passthrough device trees using lopper. This feature should be used with care as the corresponding lopper changes are still in an early support state. Current integration has been tested with several devices from ZynqMP ZCU102 board e.g. serial, spi, ahci, mmc. When using this feature, make sure to use the latest lopper's master branch status [1]. [1] https://github.com/devicetree-org/lopper Michal Orzel (2): Refactor sanity_check_partial_dts Add support for lopper to generate partial dts README.md | 22 ++++++++++-- scripts/common | 73 +++++++++++++++++++++++++++++----------- scripts/uboot-script-gen | 17 ++++++++-- 3 files changed, 88 insertions(+), 24 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 11:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 11:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405737.648173 (Exim 4.92) (envelope-from ) id 1oXi6O-0003DD-6Q; Mon, 12 Sep 2022 11:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405737.648173; Mon, 12 Sep 2022 11:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6O-0003D4-2v; Mon, 12 Sep 2022 11:59:48 +0000 Received: by outflank-mailman (input) for mailman id 405737; Mon, 12 Sep 2022 11:59:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6M-0003B8-9S for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 11:59:46 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 634c3ef0-3292-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 13:59:44 +0200 (CEST) Received: from DM5PR06CA0091.namprd06.prod.outlook.com (2603:10b6:3:4::29) by PH7PR12MB5880.namprd12.prod.outlook.com (2603:10b6:510:1d8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Mon, 12 Sep 2022 11:59:41 +0000 Received: from DS1PEPF0000B078.namprd05.prod.outlook.com (2603:10b6:3:4:cafe::12) by DM5PR06CA0091.outlook.office365.com (2603:10b6:3:4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Mon, 12 Sep 2022 11:59:41 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B078.mail.protection.outlook.com (10.167.17.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.11 via Frontend Transport; Mon, 12 Sep 2022 11:59:39 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 06:59:38 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 12 Sep 2022 06:59:37 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 634c3ef0-3292-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUPkoRI0/elMm/uy7BD8W0q3EU8kHumJ0Mx3nCOqbPDlmTISdHtgEr0sF4wFiMJkkHWgHvYYHa3jvlAtMkENBP+eppwyUKrhPFBMsjCxID7d+uGT8OVTL6728g4DJCLx8nWGljE2AUas+dGYLBv3c1Z5QB0jAj+vVHPUR3CEm8e3SbNwfmWgMX3YSgidzKv5VF2WvtXnF2lP7rw73EwnvkPgSCDgl1HCMLHWjCf0RfpGpGx17rjeCgLcdZPRvWmfE+f1QbwlBBHJtq/1GMNuF88AEqk8putHBZgaylM0br32IqHVwAwXRPQjTEKxrrxBh+gHY2zynLEmmPZmdgaGlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Es1SbOkPTlR+DrVZyH6jYeYFx1nk2zGDWM3Y18G1Ths=; b=GNEMxXo4anOwFTpmUaRTR79W2ofzJg1yIg6IfUm6CT6KXu8kF5ew3vGBX6QKxpuLU3B88LjoPSWbz67sr/36hFOxrHNVlhzpNOjzCQEMIPj/6DnQzC9imkGgrwkavCblB7g+az25mDzFILFwXOv01Qyjd7cv++s3gFpw+X6Yl95OtI7DDLOy/MYQ+o1oAWFX0EItGJ+ijsTdY4QWXw9c1VvYp4jKuZ0wJngzS4X+0824CqVGWS/w4lI/lgBBF3pgm4cansSp1z2lWHG78eehR0oL6Da/8IOWiiSr2QeAhnzboWIStejg/2EFRL84PyWX2+s3rFgyS+oxCcvOVxbZJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Es1SbOkPTlR+DrVZyH6jYeYFx1nk2zGDWM3Y18G1Ths=; b=y2Y8srlpnzMe9Rlckx/oJpXdk61JZD+Xiw8+x9B09uET++LyTz4gr9ecHVi1Fj9f+qKZJH8JXmXq94EVNxbMk9nkxetlr1zmOe1QPoGi8uG1L0OaVEzmjnCuj+DOirtwV8yRqFoHYBJvSsQ/IUBLTlHt+ozou6mXfuJan81INDk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder 1/2] Refactor sanity_check_partial_dts Date: Mon, 12 Sep 2022 13:59:33 +0200 Message-ID: <20220912115934.19552-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220912115934.19552-1-michal.orzel@amd.com> References: <20220912115934.19552-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B078:EE_|PH7PR12MB5880:EE_ X-MS-Office365-Filtering-Correlation-Id: 32fa13c5-e663-4d8b-ae2b-08da94b64564 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XpWSVIvm+D2rkON8A3Q1id9TzVdv+NMhHIqOZ6iqdv9tK8FgkoBEQ9wv77nEOdcpNu9KlK5G4sa7eVxcrSIeJg0iTpblPsueVek6IUiJAxwKffeRD4zVsilG6OB70UPiIS0rRBgYBON+qxLUD4aOvTL0mYFT5jXgbk/++hyZCIphFEcRozzcBUR9uRkTUsFjaMTMZLJ0xItar81Ub1gtHXXwLJBCSCZFD2OmI5t+bxkmBBc9CfyyLzjYinxZukdioxerTudOsVRMLJV1hj5fW4Aic1Ivdj7TE6MaYo0DJ+JJgeqQJCBOujeTX+P+SO4/UbdE2gmvXRIw3VLWNP/zbW2eXLKiR1WEALKAE6X1U2/FTT8zFg2Buw7R951qHhPTQiVzRXCI7yYeQVIneZP2RMrm+sht9xjJ3FNXzid+wXn6+hiflhxIf6w9QgnmQ50uQtCK9Xc+YThETXEsyHUnrbs0K8D2tGqzKxnsCWVbdmH95yqYdmunwIxh0J4ft7Amt4zOu3GOvMVK5tr//8CSRMYYiDAKyQodf7kbLteINbRHoHo5cQvVT84mZaLDUILXbFlxkNlI1j6SrUu7wbiDvNdMiwYiFODrA1yIMTh23S2MMcdsUk+kCRolj6LJfTUqsnr1CSzNXBYpr5pJt4CTEEaf4AduiHf8U2HcHfQe4bqm0u+jiqsPCD4/kGB3WHql3vwAZ4TEr3l/bIqRmpIOsAXf8MBulli8PZyjBfbSRWYuMGi2xr53PuiZNa7ZKejPCYor18S+I5GTP1YtFKa8p09Sr9px75WjFqQ2R6MDJAX2P1SlYCHXRtDF0RNFJsZp X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(376002)(396003)(46966006)(36840700001)(40470700004)(426003)(47076005)(83380400001)(1076003)(2616005)(336012)(36756003)(54906003)(5660300002)(6916009)(2906002)(70206006)(316002)(70586007)(8676002)(4326008)(8936002)(40480700001)(44832011)(6666004)(86362001)(81166007)(186003)(356005)(26005)(82310400005)(40460700003)(41300700001)(478600001)(82740400003)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 11:59:39.4437 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32fa13c5-e663-4d8b-ae2b-08da94b64564 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B078.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5880 Currently function sanity_check_partial_dts from scripts/common takes three arguments where the last two (repo, dir) are used always in conjuction to form a path to a directory storing partial dts. Modify the function to take only two arguments where the second one is to be a path to a directory storing partial dts. This will help reusing this function in the future to perform sanity checks on partial dts that do not originate from a repository. Modify compile_merge_partial_dts to take this change into account. Signed-off-by: Michal Orzel --- scripts/common | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/scripts/common b/scripts/common index 25c041270c29..ccad03d82b30 100644 --- a/scripts/common +++ b/scripts/common @@ -40,8 +40,7 @@ function get_next_phandle() function sanity_check_partial_dts() { local domU_passthrough_path="$1" - local repo="$2" - local dir="$3" + local partial_dts_dir="$2" local address_cells_val local size_cells_val local tmpdtb @@ -51,7 +50,7 @@ function sanity_check_partial_dts() for devpath in $domU_passthrough_path do file=${devpath##*/} - file="$repo"/"$dir"/"$file".dts + file="$partial_dts_dir"/"$file".dts if ! test -f "$file" then @@ -96,6 +95,7 @@ function compile_merge_partial_dts() local dtb_dir=$1 local repo=$(echo "$2" | awk '{print $1}') local dir=$(echo "$2" | awk '{print $2}') + local partial_dts_dir local tmp local tmpdts local file @@ -123,6 +123,7 @@ function compile_merge_partial_dts() dir="." fi + partial_dts_dir="$repo"/"$dir" i=0 while test $i -lt $NUM_DOMUS do @@ -132,7 +133,7 @@ function compile_merge_partial_dts() return 1 fi - sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$repo" "$dir" + sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" if test $? -ne 0 then return 1 @@ -146,7 +147,7 @@ function compile_merge_partial_dts() for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} do file=${devpath##*/} - file="$repo"/"$dir"/"$file".dts + file="$partial_dts_dir"/"$file".dts # All the subsequent dts files should not have dts version mentioned if test $j -gt 1 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 11:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 11:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405738.648178 (Exim 4.92) (envelope-from ) id 1oXi6O-0003Fo-Ht; Mon, 12 Sep 2022 11:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405738.648178; Mon, 12 Sep 2022 11:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6O-0003FL-Bf; Mon, 12 Sep 2022 11:59:48 +0000 Received: by outflank-mailman (input) for mailman id 405738; Mon, 12 Sep 2022 11:59:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXi6N-0002ar-2i for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 11:59:47 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2066.outbound.protection.outlook.com [40.107.92.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e83f237-3292-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 13:59:36 +0200 (CEST) Received: from DM5PR06CA0096.namprd06.prod.outlook.com (2603:10b6:3:4::34) by CY8PR12MB7338.namprd12.prod.outlook.com (2603:10b6:930:52::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Mon, 12 Sep 2022 11:59:43 +0000 Received: from DS1PEPF0000B078.namprd05.prod.outlook.com (2603:10b6:3:4:cafe::4e) by DM5PR06CA0096.outlook.office365.com (2603:10b6:3:4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Mon, 12 Sep 2022 11:59:43 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B078.mail.protection.outlook.com (10.167.17.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.11 via Frontend Transport; Mon, 12 Sep 2022 11:59:41 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 06:59:40 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 12 Sep 2022 06:59:39 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e83f237-3292-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXaEVgL21XHy7oWPxo6GYOBSedTAlByjoCy8jT89HRLooAInga7DsXYD+EMuyCCFhfy6paksAvY8mqvpEve+k5MfBPDcEetxMqi0pqPQOA7OUKr/CuQKe7QTRXf0vpAyTCRzm+DcYxbNMaZx0EAvslt9pNUkBZD3xomzXM7C7HHSk66R5I2tgKK4l/KakFbfM897jaiIKUvaOSJC3IHmgjsCUxvpMJHWGuXjgXhdblD0fY4DDNFvyNrb0guqKvHEcELhwRL5W3SZE3DRiPcpxHHdxJktCLUPRaq+nDw9PhhXhpHHvJdEsiTgysXGvUcWDunJA51GJzve9+/ZVBzzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YLbr++EqGjibrAPyhyuMy+UbwTlyjwezISmhm+i7DKs=; b=UHbhJyjsrKGAGPsedd07Bek7D+tAIhFLFlRUVKgdTSkNjqGSyHO56PqVyWs1OR992GP3s3GrUdEAYyijLRci2qDMFdJdSW9i6nWO6akF0zUC4B3sDo7WHpOZx/JNpc3rz3CmcOdyYnO2DspHVGCOdyO0tsqEsySm6wUmJ88JBKUkMvb9KeWbtw/8PtqklL24XZaR2tENHeaTQKj9hKREs/woPpckapj55wqpdcsnEXQVV2bGuHlhny3Lsei8EiMnP2ic7mCuKFK56KgERQ5NTuljoClnmcyXy4IlHpOMNZd2Uvn5VIzPtpKXG3q9OQAizHf4ZdVZFVzdjSe88FG0TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLbr++EqGjibrAPyhyuMy+UbwTlyjwezISmhm+i7DKs=; b=2JaU4JXH27HDQiGl/pX4TTYhetKIzCn2imy53x0hDUnRweE5Qcxv4g2MSJflTZ6sJm3q6+pZXblIuBHvFGfseAF07AZTgBZIAyXDo9y4HeXXuWSb+hMNgOlOSiVobfsOJnyUkNDI2fWyk9RVDnp0DgSJweh7twHhgriF3D6+NS4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder 2/2] Add support for lopper to generate partial dts Date: Mon, 12 Sep 2022 13:59:34 +0200 Message-ID: <20220912115934.19552-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220912115934.19552-1-michal.orzel@amd.com> References: <20220912115934.19552-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B078:EE_|CY8PR12MB7338:EE_ X-MS-Office365-Filtering-Correlation-Id: 0799d4c0-4501-48d2-15ed-08da94b646b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a7/8FeqDj3P94UbIw4aD2FsW6sipC0rOHH8JHmZ9lYWq1ExbAq+VFSyeMf76LfaD4YpabXMhSp/X5GA7b35wv7EBX0oRPOsk3A/ToJCVR9qBZ4M7E8OSL3/61JyYaSQuDTLT3yDU7ZDuggdqOUkShhCyDCWm741y4iEfRZn3xexDwa6kFVdIbzTC7aM1ZhOThwNhv/3W3WfBgbiphjJKrbyKUoWrRGWm2ivSTv5Xeou6a5hf69d0EFSvKbmfjKQ9twWjXvjkrrlP8fwIJCVRI9+V+ET1tRM4LdUX2CBNCBXQpj0vdEO/1J7Nygp5ccCKTKHGJV389JVO9LJs6R2XnLDyu0Nnja3wWMPsSmoSuT8KnIsos40cYCxMLJOk/EMaAvrknQ8cbt8zYwWc5XRtPUgLcsoRrciMMxYJJpAj3XL45O0FpcNV0NdFjAAeJG0bXqGOvxazEe96Ud8pEzMpaOsG4qgD8OB6o3WsFy8dfSGNjv+xmepQwQkk8xfqO1rF8nLYmlw25vNTtWuUmKza0h/WjkT1tN2Q7K4lmoUPn3g5m08kKES93+A9LFJlNIfM9iCeii27rOb8p7oVQaF3u9HF/t0j/PtiO9er6J86Yt9qu/DYELDE0HmYdquKTdliRFgz4+zWRLWAZyKFlsOFxvTH8FbtuC+c0c9lcltvgMshgcq8jC5ouQN2h1E6kI3/v1Mx5ZmlYoUipSHA5UV9N6fDtJ8PiDn1JThb8xIpmsWtr5iS2f4C7KUTzc70EmvElTawNQQiqhgiNnc+VZ1HOHTS40IOMwbuvzqLizxoxKWyKmdPSG7WxhUt7t/mETOADB/TvVxJFT+p8GKeRzNTQA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(376002)(40470700004)(36840700001)(46966006)(83380400001)(5660300002)(82740400003)(36860700001)(86362001)(47076005)(81166007)(356005)(1076003)(6666004)(426003)(186003)(2616005)(70206006)(41300700001)(26005)(478600001)(54906003)(8936002)(6916009)(70586007)(40480700001)(40460700003)(8676002)(82310400005)(316002)(4326008)(336012)(2906002)(36756003)(44832011)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 11:59:41.6156 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0799d4c0-4501-48d2-15ed-08da94b646b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B078.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7338 Currently ImageBuilder can compile and merge partial dts obtained from a repository specified using PASSTHROUGH_DTS_REPO. With the recent changes done in the lopper, we can use it to generate partial dts automatically (to some extent as this is still an early support). Introduce LOPPER_PATH option to specify a path to a lopper.py script, that if set, will invoke lopper to generate partial dts for the passthrough devices specified in DOMU_PASSTHROUGH_PATHS. Introduce LOPPER_CMD option to specify custom command line arguments (if needed) for lopper's extract assist. Example usage: LOPPER_PATH="/home/user/lopper/lopper.py" DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" Signed-off-by: Michal Orzel --- README.md | 22 ++++++++++++-- scripts/common | 64 ++++++++++++++++++++++++++++++---------- scripts/uboot-script-gen | 17 +++++++++-- 3 files changed, 83 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index da9ba788a3bf..aaee0939b589 100644 --- a/README.md +++ b/README.md @@ -128,6 +128,19 @@ Where: - DT_OVERLAY[number] specifies the path to the hosts device tree overlays to be added at boot time in u-boot +- LOPPER_PATH specifies the path to lopper.py script. This is optional. + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need + to be specified. uboot-script-gen will invoke lopper to generate the partial + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. + This option is currently in experimental state as the corresponding lopper + changes are still in an early support state. + +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. + This is optional and only applicable when LOPPER_PATH is specified. Only to be + used to specify which nodes to include (using -i ) and which + nodes/properties to exclude (using -x ). If not set at all, the default + one is used applicable for ZynqMP MPSoC boards. + - NUM_DOMUS specifies how many Dom0-less DomUs to load - DOMU_KERNEL[number] specifies the DomU kernel to use. @@ -140,7 +153,7 @@ Where: - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( separated by spaces). It adds "xen,passthrough" to the corresponding dtb nodes in xen device tree blob. - This option is valid in the following two cases: + This option is valid in the following cases: 1. When PASSTHROUGH_DTS_REPO is provided. With this option, the partial device trees (corresponding to the @@ -149,7 +162,12 @@ Where: Note it assumes that the names of the partial device trees will match to the names of the devices specified here. - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only + 2. When LOPPER_PATH is provided. + With this option, the partial device trees (corresponding to the + passthrough devices) are generated by the lopper and then compiled and merged + by ImageBuilder to be used as DOMU[number] device tree blob. + + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only add "xen,passthrough" as mentioned before. - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees diff --git a/scripts/common b/scripts/common index ccad03d82b30..680c5090cd07 100644 --- a/scripts/common +++ b/scripts/common @@ -9,6 +9,9 @@ # - NUM_DOMUS # - DOMU_PASSTHROUGH_PATHS # - DOMU_PASSTHROUGH_DTB +# - LOPPER_PATH +# - LOPPER_CMD +# - DEVICE_TREE tmp_files=() tmp_dirs=() @@ -99,31 +102,41 @@ function compile_merge_partial_dts() local tmp local tmpdts local file + local node local i local j - if [[ "$repo" =~ .*@.*:.* ]] + if test "$repo" then - tmp=`mktemp -d` - tmp_dirs+=($tmp) - - echo "Cloning git repo \"$git_repo\"" - git clone "$repo" $tmp - if test $? -ne 0 + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO + if [[ "$repo" =~ .*@.*:.* ]] then - echo "Error occurred while cloning \"$git_repo\"" - return 1 - fi + tmp=`mktemp -d` + tmp_dirs+=($tmp) - repo=$tmp - fi + echo "Cloning git repo \"$git_repo\"" + git clone "$repo" $tmp + if test $? -ne 0 + then + echo "Error occurred while cloning \"$git_repo\"" + return 1 + fi - if test -z "$dir" - then - dir="." + repo=$tmp + fi + + if test -z "$dir" + then + dir="." + fi + partial_dts_dir="$repo"/"$dir" + else + # Partial dts will be generated by the lopper + tmp=`mktemp -d` + tmp_dirs+=($tmp) + partial_dts_dir="$tmp" fi - partial_dts_dir="$repo"/"$dir" i=0 while test $i -lt $NUM_DOMUS do @@ -133,6 +146,25 @@ function compile_merge_partial_dts() return 1 fi + if test -z "$repo" + then + # Generate partial dts using lopper + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} + do + node=${devpath##*/} + file="$partial_dts_dir"/"$node".dts + + $LOPPER_PATH --permissive -f $DEVICE_TREE \ + -- extract -t $devpath $LOPPER_CMD \ + -- extract-xen -t $node -o $file + + if test $? -ne 0 + then + return 1 + fi + done + fi + sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" if test $? -ne 0 then diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 1f8ab5ffd193..84a68d6bd0b0 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -1138,10 +1138,23 @@ fi # tftp or move the files to a partition cd "$uboot_dir" -if test "$PASSTHROUGH_DTS_REPO" +# If both PASSTHROUGH_DTS_REPO and LOPPER_PATH options are specified, +# the former takes precedence because the partial device trees are already +# created (probably tested), hence the reliability is higher than using lopper. +if test "$PASSTHROUGH_DTS_REPO" || test "$LOPPER_PATH" then output_dir=`mktemp -d "partial-dtbs-XXX"` - compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" + if test "$PASSTHROUGH_DTS_REPO" + then + compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" + else + if test -z "$LOPPER_CMD" + then + # Default for ZynqMP MPSoC + LOPPER_CMD="-i zynqmp-firmware -x interrupt-controller -x pinctrl -x power-domains -x resets -x current-speed" + fi + compile_merge_partial_dts $output_dir + fi if test $? -ne 0 then # Remove the output dir holding the partial dtbs in case of any error -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 12:24:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 12:24:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405775.648194 (Exim 4.92) (envelope-from ) id 1oXiTZ-0008FV-Rt; Mon, 12 Sep 2022 12:23:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405775.648194; Mon, 12 Sep 2022 12:23:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiTZ-0008FO-PA; Mon, 12 Sep 2022 12:23:45 +0000 Received: by outflank-mailman (input) for mailman id 405775; Mon, 12 Sep 2022 12:23:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiTY-0008FI-3v for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 12:23:44 +0000 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [2607:f8b0:4864:20::82f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b75e466d-3295-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 14:23:33 +0200 (CEST) Received: by mail-qt1-x82f.google.com with SMTP id s18so2982185qtx.6 for ; Mon, 12 Sep 2022 05:23:43 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:cc03:373b:6dc6:a951]) by smtp.gmail.com with ESMTPSA id f1-20020ac87f01000000b0031d283f4c4dsm6705092qtk.60.2022.09.12.05.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 05:23:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b75e466d-3295-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=plCROruMnCJO+u23xBOec2JrcA1xylXfcF6qLleFq0U=; b=CgaSqMF2JcSWi59eCI93+wiMQYsQBA+Csu1ab7rUypcxjWCI6X4ya4I0pA7uajrrEo KhjH/YVX8pzIe+mZRyMqJRTzJCsuM9ti/SYIUfEAyAikfFUddonE7S5BUaMw+Dc5BYrf zNeI+ygzs/PUpzBpLOlsL5TSdvea+sreL/O8Fy0e2j4FipcdfdwzrY4WTMqJfUmWbziC yOsoqYHg5KoPnekoivYAoBADFzLfKKMTRk5zoTSnl/NVCli4WXaDmQcexNt1lziQxrID SQ1Hzp26nDtGgiGSyfrSqJVaLAy9gB5MJ94l6ovqrlEMMLF86a9YQ4A0cPdA5hDl6bc/ OFYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=plCROruMnCJO+u23xBOec2JrcA1xylXfcF6qLleFq0U=; b=ujdXz2QRYrn/CsngBGrit563Z67dDEzpAW42eCLIo5qEYZ8EZYF6b0STxh1ilb/9Ax xbUtrkUZHA9MDIk9lOj23LYqmhDw69MLEROqwv+rg2lOs+/n0rOhFp3CV7wumN11zhk8 oROgBr3yRa2EM5gw4Jywswa3/mfZ8ICTAeXtXvMwp/bydceANpQUPXK23hof0RJFOMDi hOkoEjN7VkeV2zKUoH6EpV5g3nxlzIUjDMnhnsN8YqgrTTDVBgolUXiPZC0fw6fJVUTk YMAMTzCJKX4Fwzfcop1Fyy/xS+pypvwf9JzDDjwZ6OVJRrIpSdZhsyhDdn67QUdVOKra aFUQ== X-Gm-Message-State: ACgBeo3a5nH+3VtFgZsbjZJddUkjwtuh27373wupgEBWlVrNGMSbcQIL Xp46vSfYhaVOBd/mgdhepHP5oYB9948= X-Google-Smtp-Source: AA6agR6Oy46Paz+N0EgswBrqNpSZBtEJRHD2N4kYO2stMOkbjFCV6Xd4GxX/Pg3fK2agZIs2iPk1yQ== X-Received: by 2002:ac8:4e87:0:b0:343:6249:1810 with SMTP id 7-20020ac84e87000000b0034362491810mr22821180qtp.117.1662985421702; Mon, 12 Sep 2022 05:23:41 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v3 0/3] libxl smbios support Date: Mon, 12 Sep 2022 08:22:34 -0400 Message-Id: <20220912122237.5431-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. This patches adds a new xl.cfg option and libxl support to write the xenstore strings. The xl syntax looks like: smbios=["bios_vendor=Xen Project","system_version=1.0"] The Go binding generation needed extending to support Arrays inside a KeyedUnion, which is what the first patch does. The generated go code builds, but it is otherwise untested. There are also oem strings, oem-1..oem-99, that HVM loader supports. xl parse multiple oem strings like smbios=["oem=A,oem=B"], libxl then iterates over them and assigned to the oem-%d entries. Both xl and libxl check that the 99 string limit isn't exceeded. The rendered man page and html don't have a newline at the end of the new section after patch 2. """ battery_device_name=STRING ms_vm_genid="OPTION" """ however the txt format is correct: """ battery_device_name=STRING ms_vm_genid="OPTION" """ It goes away after patch 3 is applied since it adds text about the "oem" option in between the two lines above. I'm at a loss as to why this is happening. Jason Andryuk (3): golang/xenlight: Extend KeyedUnion to support Arrays xl/libxl: Add ability to specify SMBIOS strings xl/libxl: Add OEM string support to smbios docs/man/xl.cfg.5.pod.in | 49 +++++++++++++++++++ tools/golang/xenlight/gengotypes.py | 41 +++++++++------- tools/golang/xenlight/helpers.gen.go | 51 ++++++++++++++++++++ tools/golang/xenlight/types.gen.go | 28 +++++++++++ tools/include/libxl.h | 5 ++ tools/libs/light/libxl_dom.c | 33 +++++++++++++ tools/libs/light/libxl_types.idl | 27 +++++++++++ tools/xl/xl_parse.c | 71 +++++++++++++++++++++++++++- 8 files changed, 288 insertions(+), 17 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 12:24:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 12:24:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405780.648205 (Exim 4.92) (envelope-from ) id 1oXiTz-0000Fl-4N; Mon, 12 Sep 2022 12:24:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405780.648205; Mon, 12 Sep 2022 12:24:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiTz-0000Fe-1l; Mon, 12 Sep 2022 12:24:11 +0000 Received: by outflank-mailman (input) for mailman id 405780; Mon, 12 Sep 2022 12:24:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiTy-0000FB-8I for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 12:24:10 +0000 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [2607:f8b0:4864:20::f33]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ccc867e5-3295-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 14:24:09 +0200 (CEST) Received: by mail-qv1-xf33.google.com with SMTP id g4so6537987qvo.3 for ; Mon, 12 Sep 2022 05:24:09 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:cc03:373b:6dc6:a951]) by smtp.gmail.com with ESMTPSA id f1-20020ac87f01000000b0031d283f4c4dsm6705092qtk.60.2022.09.12.05.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 05:23:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccc867e5-3295-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=0c9AKXalp2sKJ7cfJ+vPBAUxcJIApFm3DGF7p3Liepw=; b=GcK1y9aaahXwbcuP53/qjwmjYWaYZl1iUQ6+L/YdsClBoW9m5IUSEZmXw4DR2H/Bna vBGroDqr9WjDf8YQImWmLk2X6VLWSGdcasQdIP9+s1DFP9cNzmBe7BFJ6j7BjUk2ttK8 lWu0xNfN6U0QgDlhfj9ICPZo1vRcKlw4f3pfR+fdPsT4ZhdtY6WUzyE0f3vHoJiv61mg ck+54zy72ZfZl+1VMmgmD9DQZVeuKPeSwFzlzYwvdGDH7mnviJwYzIRiV8yY2a8jFAXO yElKYlW6WBaiMrk8/qU1aUGeVNlvEz9DdH6W584kJS44/oxrCmQ95rRi5R3TqLOV1cMp B9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=0c9AKXalp2sKJ7cfJ+vPBAUxcJIApFm3DGF7p3Liepw=; b=QlxK4oZJgck3eO7edP/9x7pPq2dS6ylWIqrpI83Wed0RWz9wrvhI5rckWoAr1Reb6f ynLpFL3yDhBMp1uY4U/Jz+SN07Wo0AbGDMsaVwseFyOJk/0jA745d3KOHneOFklCARiX AS+nSzdo78NrL/Yo66+vNfh3BEtTZcQZFiR8Wrmu5peNfHpaNrr32MXlzfhgM6TOEpNT wHqaEsSFan1xiVDH0T5gMsD6VHa7DRvNsuTNuzk7EhfW3ZlsHguFZe66b20/3swgzOsA /qRaHyMsxflW6ibMhl3I/GcJ3yxF+LGjDhKLBsc0Ldgz9vYN5wq5joH3iGk5v3JKGxfN Ulzw== X-Gm-Message-State: ACgBeo2juSD1yQUIMQz3pXgT1mXUWIkri6vy999ve4rmymXgMl/f6V0Z vyslNh/HXdhq/nHpT5KOUW97x/34UwE= X-Google-Smtp-Source: AA6agR7qJTkI30XH0Nz/qgbFeljPySSkbTEpwkSueBJOF4cInHXoTWR+2cj+Om6JcNR0sNbkdBmKEA== X-Received: by 2002:a05:6214:260e:b0:4ac:8470:99a7 with SMTP id gu14-20020a056214260e00b004ac847099a7mr14683177qvb.102.1662985447730; Mon, 12 Sep 2022 05:24:07 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD Subject: [PATCH v3 1/3] golang/xenlight: Extend KeyedUnion to support Arrays Date: Mon, 12 Sep 2022 08:22:35 -0400 Message-Id: <20220912122237.5431-2-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220912122237.5431-1-jandryuk@gmail.com> References: <20220912122237.5431-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Generation for KeyedUnion types doesn't support Arrays. The smbios support will place an smbios array inside the hvm KeyedUnion, and gentotypes doesn't generate buildable Go code. Have KeyedUnion add an idl.Array check and issue the approriate xenlight_golang_array_to_C and xenlight_golang_array_from_C calls when needed. This matches how it is done in xenlight_golang_define_to_C & xenlight_golang_define_from_C xenlight_golang_array_to_C and xenlight_golang_array_from_C need to be extended to set the cvarname and govarname as approriate for the KeyedUnion cases to match the surrounding code. Signed-off-by: Jason Andryuk --- tools/golang/xenlight/gengotypes.py | 41 ++++++++++++++++++----------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.py index ac1cf060dd..745a3cb466 100644 --- a/tools/golang/xenlight/gengotypes.py +++ b/tools/golang/xenlight/gengotypes.py @@ -374,6 +374,10 @@ def xenlight_golang_union_from_C(ty = None, union_name = '', struct_name = ''): s += 'tmp := (*C.{0})(unsafe.Pointer(&xc.{1}[0]))\n'.format(typename,union_name) for nf in f.type.fields: + if isinstance(nf.type, idl.Array): + s += xenlight_golang_array_from_C(nf,cvarname='tmp') + continue + s += xenlight_golang_convert_from_C(nf,cvarname='tmp') s += 'return nil\n' @@ -414,7 +418,7 @@ def xenlight_golang_union_from_C(ty = None, union_name = '', struct_name = ''): return (s,extras) -def xenlight_golang_array_from_C(ty = None): +def xenlight_golang_array_from_C(ty = None, cvarname = 'xc'): """ Convert C array to Go slice using the method described here: @@ -431,9 +435,9 @@ def xenlight_golang_array_from_C(ty = None): clenvar = ty.type.lenvar.name s += 'x.{0} = nil\n'.format(goname) - s += 'if n := int(xc.{0}); n > 0 {{\n'.format(clenvar) + s += 'if n := int({0}.{1}); n > 0 {{\n'.format(cvarname,clenvar) s += '{0} := '.format(cslice) - s +='(*[1<<28]C.{0})(unsafe.Pointer(xc.{1}))[:n:n]\n'.format(ctypename, cname) + s +='(*[1<<28]C.{0})(unsafe.Pointer({1}.{2}))[:n:n]\n'.format(ctypename, cvarname, cname) s += 'x.{0} = make([]{1}, n)\n'.format(goname, gotypename) s += 'for i, v := range {0} {{\n'.format(cslice) @@ -577,6 +581,11 @@ def xenlight_golang_union_to_C(ty = None, union_name = '', s += 'var {0} C.{1}\n'.format(f.name,cgotype) for uf in f.type.fields: + if isinstance(uf.type, idl.Array): + s += xenlight_golang_array_to_C(uf, cvarname=f.name, + govarname="tmp") + continue + s += xenlight_golang_convert_to_C(uf,cvarname=f.name, govarname='tmp') @@ -594,7 +603,7 @@ def xenlight_golang_union_to_C(ty = None, union_name = '', return s -def xenlight_golang_array_to_C(ty = None): +def xenlight_golang_array_to_C(ty = None, cvarname="xc", govarname="x"): s = '' gotypename = xenlight_golang_fmt_name(ty.type.elem_type.typename) @@ -606,27 +615,27 @@ def xenlight_golang_array_to_C(ty = None): is_enum = isinstance(ty.type.elem_type,idl.Enumeration) if gotypename in go_builtin_types or is_enum: - s += 'if {0} := len(x.{1}); {2} > 0 {{\n'.format(golenvar,goname,golenvar) - s += 'xc.{0} = (*C.{1})(C.malloc(C.size_t({2}*{3})))\n'.format(cname,ctypename, + s += 'if {0} := len({1}.{2}); {3} > 0 {{\n'.format(golenvar,govarname,goname,golenvar) + s += '{0}.{1} = (*C.{2})(C.malloc(C.size_t({3}*{4})))\n'.format(cvarname,cname,ctypename, golenvar,golenvar) - s += 'xc.{0} = C.int({1})\n'.format(clenvar,golenvar) - s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer(xc.{2}))[:{3}:{4}]\n'.format(goname, - ctypename,cname, + s += '{0}.{1} = C.int({2})\n'.format(cvarname,clenvar,golenvar) + s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer({2}.{3}))[:{4}:{5}]\n'.format(goname, + ctypename,cvarname,cname, golenvar,golenvar) - s += 'for i,v := range x.{0} {{\n'.format(goname) + s += 'for i,v := range {0}.{1} {{\n'.format(govarname,goname) s += 'c{0}[i] = C.{1}(v)\n'.format(goname,ctypename) s += '}\n}\n' return s - s += 'if {0} := len(x.{1}); {2} > 0 {{\n'.format(golenvar,goname,golenvar) - s += 'xc.{0} = (*C.{1})(C.malloc(C.ulong({2})*C.sizeof_{3}))\n'.format(cname,ctypename, + s += 'if {0} := len({1}.{2}); {3} > 0 {{\n'.format(golenvar,govarname,goname,golenvar) + s += '{0}.{1} = (*C.{2})(C.malloc(C.ulong({3})*C.sizeof_{4}))\n'.format(cvarname,cname,ctypename, golenvar,ctypename) - s += 'xc.{0} = C.int({1})\n'.format(clenvar,golenvar) - s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer(xc.{2}))[:{3}:{4}]\n'.format(goname, - ctypename,cname, + s += '{0}.{1} = C.int({2})\n'.format(cvarname,clenvar,golenvar) + s += 'c{0} := (*[1<<28]C.{1})(unsafe.Pointer({2}.{3}))[:{4}:{5}]\n'.format(goname, + ctypename,cvarname,cname, golenvar,golenvar) - s += 'for i,v := range x.{0} {{\n'.format(goname) + s += 'for i,v := range {0}.{1} {{\n'.format(govarname,goname) s += 'if err := v.toC(&c{0}[i]); err != nil {{\n'.format(goname) s += 'return fmt.Errorf("converting field {0}: %v", err)\n'.format(goname) s += '}\n}\n}\n' -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 12:25:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 12:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405788.648218 (Exim 4.92) (envelope-from ) id 1oXiUd-0000tl-F4; Mon, 12 Sep 2022 12:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405788.648218; Mon, 12 Sep 2022 12:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiUd-0000te-9t; Mon, 12 Sep 2022 12:24:51 +0000 Received: by outflank-mailman (input) for mailman id 405788; Mon, 12 Sep 2022 12:24:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiUc-0000t5-5t for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 12:24:50 +0000 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [2607:f8b0:4864:20::733]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de9b7a44-3295-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 14:24:39 +0200 (CEST) Received: by mail-qk1-x733.google.com with SMTP id d15so5801364qka.9 for ; Mon, 12 Sep 2022 05:24:48 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:cc03:373b:6dc6:a951]) by smtp.gmail.com with ESMTPSA id f1-20020ac87f01000000b0031d283f4c4dsm6705092qtk.60.2022.09.12.05.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 05:24:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de9b7a44-3295-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=joJYsjy4tSiNhotj7nne40DqyOd3cM8XIQboEYpfiE4=; b=JWT0SsisRGZivxFMro7aPzg35Thn1e1qHMG181Z0lnHHvTTM7384+st+My27tYlxMT g+PpRwlVve6nxahJ3e3eerijlTIhu9JfQjlBCWhqGOPnDFDsZx46rVFfVhIbk2w2KTwU WdNb6U0pULstA6/KQ0gqbkr4SRvVfmXaA3yVIa2u/kJG1/33Ym972ezvGuTbGivOlt3l UN7w4jVspjnGck1XMJyr9tza2MqnXT/OS5r4vaJS+tNSXEyTlHwGTdsXfxcP7JwcHi1P WHwg8AGTUS2XYwoKvXwkHlXJq1p5T7N5E95YY8js/ob//86QSKT7KWqks4RfEAQHQyIW A/Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=joJYsjy4tSiNhotj7nne40DqyOd3cM8XIQboEYpfiE4=; b=UYfeJX6YVsZQevoGhbRFmvXvflsr68TArI4rcS1ECERwP74RDIcEe9OTJK4dodwHRd eQBXEeS8Zf9Awzp3WsJi3K3x69JHnjzGtX1oO6P7Q6CMcPhqekKD7v42NHtpGI0suARC ubC6FSO3k7HCiKZ/eOlSGy2i9IzFJXuAI5XmOKkjBNHq3SRjtfYWSsQ60QRmIuu1D+pG aucyKGQwg4RTWXQBdhF2Vs8z097c/gB+dEOjmO+GeLAv7R5GRqs7YKPagWs7m9AJSh0b 104k752jkIHH6NlgGm4IKemUx9VLtnBqcO1lD9OaDbpS3A7oH3FkpFO6Gs6XlOdjo09P PfBQ== X-Gm-Message-State: ACgBeo06sLgwt9GOmPpnWWOmV3KjIncwPSneLSKUdL6NN0O1Yl1dkzLg +QN2X2E/gXgB0T2eumx7+auOVNxrseg= X-Google-Smtp-Source: AA6agR4RHiMCGpqWpwMzQLwd/OX21vE2GaDUi6qD5z7kQye3jHbV3bHeWacCoesKr7OQaRP2zzN4gQ== X-Received: by 2002:a05:620a:246:b0:6cb:c0dd:2d7a with SMTP id q6-20020a05620a024600b006cbc0dd2d7amr14615091qkn.234.1662985487364; Mon, 12 Sep 2022 05:24:47 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [PATCH v3 2/3] xl/libxl: Add ability to specify SMBIOS strings Date: Mon, 12 Sep 2022 08:22:36 -0400 Message-Id: <20220912122237.5431-3-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220912122237.5431-1-jandryuk@gmail.com> References: <20220912122237.5431-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. Allow specifying the strings with the new xl.cfg option: smbios=["bios_vendor=Xen Project","system_version=1.0"] In terms of strings, the SMBIOS specification 3.5 says: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.5.0.pdf """ Strings must be encoded as UTF-8 with no byte order mark (BOM). For compatibility with older SMBIOS parsers, US-ASCII characters should be used. NOTE There is no limit on the length of each individual text string. However, the length of the entire structure table (including all strings) must be reported in the Structure Table Length field of the 32-bit Structure Table Entry Point (see 5.2.1) and/or the Structure Table Maximum Size field of the 64-bit Structure Table Entry Point (see 5.2.2). """ The strings aren't checked for utf-8 or length. hvmloader has a sanity check on the overall length. The libxl_smbios_type enum starts at 1 since otherwise the 0th key is not printed in the json output. Signed-off-by: Jason Andryuk --- v3 Disallow empty value strings xstrdup listitem before modifying Handle option=foo=bar -> option foo=bar Fix compilation - remove stray } Remove log message newline Add multiline comment star Rename variable v to type v2: Update s/_/-/ comment Update debug print to xs_path = "value" Error on xlu_cfg_get_listitem failure Use EXIT_FAILURE consistently free parsed strings Move break to new line The rendered man page and html don't have a newline at the end of the new section. """ battery_device_name=STRING ms_vm_genid="OPTION" """ however the txt format is correct: """ battery_device_name=STRING ms_vm_genid="OPTION" """ I'm at a loss as to why this is happening. --- docs/man/xl.cfg.5.pod.in | 45 +++++++++++++++++++++ tools/golang/xenlight/helpers.gen.go | 51 ++++++++++++++++++++++++ tools/golang/xenlight/types.gen.go | 27 +++++++++++++ tools/include/libxl.h | 5 +++ tools/libs/light/libxl_dom.c | 21 ++++++++++ tools/libs/light/libxl_types.idl | 26 +++++++++++++ tools/xl/xl_parse.c | 58 +++++++++++++++++++++++++++- 7 files changed, 232 insertions(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index b2901e04cf..fa78fba361 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2061,6 +2061,51 @@ number of vendor defined SMBIOS structures (type 128 - 255). Since SMBIOS structures do not present their overall size, each entry in the file must be preceded by a 32b integer indicating the size of the following structure. +=item B + +Specifies the SMBIOS values to be provided to the guest. These set or +override specific entries in the tables provided to the guest. + +Each B is a C string from the following list: + +=over 4 + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=back + =item B Provide a VM generation ID to the guest. diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index fa3cf2ab76..cae14ec6f5 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -589,6 +589,38 @@ xc.build_id = C.CString(x.BuildId)} return nil } +// NewSmbios returns an instance of Smbios initialized with defaults. +func NewSmbios() (*Smbios, error) { +var ( +x Smbios +xc C.libxl_smbios) + +C.libxl_smbios_init(&xc) +defer C.libxl_smbios_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *Smbios) fromC(xc *C.libxl_smbios) error { + x.Key = SmbiosType(xc.key) +x.Value = C.GoString(xc.value) + + return nil} + +func (x *Smbios) toC(xc *C.libxl_smbios) (err error){defer func(){ +if err != nil{ +C.libxl_smbios_dispose(xc)} +}() + +xc.key = C.libxl_smbios_type(x.Key) +if x.Value != "" { +xc.value = C.CString(x.Value)} + + return nil + } + // NewDomainCreateInfo returns an instance of DomainCreateInfo initialized with defaults. func NewDomainCreateInfo() (*DomainCreateInfo, error) { var ( @@ -1189,6 +1221,15 @@ return fmt.Errorf("converting field Altp2M: %v", err) } x.SystemFirmware = C.GoString(tmp.system_firmware) x.SmbiosFirmware = C.GoString(tmp.smbios_firmware) +x.Smbios = nil +if n := int(tmp.num_smbios); n > 0 { +cSmbios := (*[1<<28]C.libxl_smbios)(unsafe.Pointer(tmp.smbios))[:n:n] +x.Smbios = make([]Smbios, n) +for i, v := range cSmbios { +if err := x.Smbios[i].fromC(&v); err != nil { +return fmt.Errorf("converting field Smbios: %v", err) } +} +} x.AcpiFirmware = C.GoString(tmp.acpi_firmware) x.Hdtype = Hdtype(tmp.hdtype) if err := x.Nographic.fromC(&tmp.nographic);err != nil { @@ -1501,6 +1542,16 @@ if tmp.SystemFirmware != "" { hvm.system_firmware = C.CString(tmp.SystemFirmware)} if tmp.SmbiosFirmware != "" { hvm.smbios_firmware = C.CString(tmp.SmbiosFirmware)} +if numSmbios := len(tmp.Smbios); numSmbios > 0 { +hvm.smbios = (*C.libxl_smbios)(C.malloc(C.ulong(numSmbios)*C.sizeof_libxl_smbios)) +hvm.num_smbios = C.int(numSmbios) +cSmbios := (*[1<<28]C.libxl_smbios)(unsafe.Pointer(hvm.smbios))[:numSmbios:numSmbios] +for i,v := range tmp.Smbios { +if err := v.toC(&cSmbios[i]); err != nil { +return fmt.Errorf("converting field Smbios: %v", err) +} +} +} if tmp.AcpiFirmware != "" { hvm.acpi_firmware = C.CString(tmp.AcpiFirmware)} hvm.hdtype = C.libxl_hdtype(tmp.Hdtype) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index a0be7ada8c..e084c3540b 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -386,6 +386,32 @@ Commandline string BuildId string } +type SmbiosType int +const( +SmbiosTypeBiosVendor SmbiosType = 1 +SmbiosTypeBiosVersion SmbiosType = 2 +SmbiosTypeSystemManufacturer SmbiosType = 3 +SmbiosTypeSystemProductName SmbiosType = 4 +SmbiosTypeSystemVersion SmbiosType = 5 +SmbiosTypeSystemSerialNumber SmbiosType = 6 +SmbiosTypeBaseboardManufacturer SmbiosType = 7 +SmbiosTypeBaseboardProductName SmbiosType = 8 +SmbiosTypeBaseboardVersion SmbiosType = 9 +SmbiosTypeBaseboardSerialNumber SmbiosType = 10 +SmbiosTypeBaseboardAssetTag SmbiosType = 11 +SmbiosTypeBaseboardLocationInChassis SmbiosType = 12 +SmbiosTypeEnclosureManufacturer SmbiosType = 13 +SmbiosTypeEnclosureSerialNumber SmbiosType = 14 +SmbiosTypeEnclosureAssetTag SmbiosType = 15 +SmbiosTypeBatteryManufacturer SmbiosType = 16 +SmbiosTypeBatteryDeviceName SmbiosType = 17 +) + +type Smbios struct { +Key SmbiosType +Value string +} + type DomainCreateInfo struct { Type DomainType Hap Defbool @@ -568,6 +594,7 @@ NestedHvm Defbool Altp2M Defbool SystemFirmware string SmbiosFirmware string +Smbios []Smbios AcpiFirmware string Hdtype Hdtype Nographic Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 2321a648a5..023613d35b 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -174,6 +174,11 @@ */ #define LIBXL_HAVE_BUILDINFO_HVM_MS_VM_GENID 1 +/* + * libxl_domain_build_info has the u.hvm.smbios field. + */ +#define LIBXL_HAVE_BUILDINFO_HVM_SMBIOS 1 + /* * LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY indicates that a 'cpumap_soft' * field (of libxl_bitmap type) is present in libxl_vcpuinfo, diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 2abaab439c..4f85623c42 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -771,6 +771,27 @@ static int hvm_build_set_xs_values(libxl__gc *gc, goto err; } + for (int i = 0; i < info->u.hvm.num_smbios; i++) { + char *p; + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); + + /* Convert libxl_smbios_type string to xenstore path that hvmloader + * will use, as defined by HVM_XS_*. That is convert the '_' to '-'. */ + p = strrchr(path, '/'); + for ( ; *p; p++) { + if (*p == '_') + *p = '-'; + } + + LOGD(DEBUG, domid, "Writing %s = \"%s\"", path, + info->u.hvm.smbios[i].value); + ret = libxl__xs_printf(gc, XBT_NULL, path, "%s", + info->u.hvm.smbios[i].value); + if (ret) + goto err; + } + /* Only one module can be passed. PVHv2 guests do not support this. */ if (dom->acpi_modules[0].guest_addr_out && info->type == LIBXL_DOMAIN_TYPE_HVM) { diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d634f304cd..d04207748e 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -418,6 +418,31 @@ libxl_version_info = Struct("version_info", [ ("build_id", string), ], dir=DIR_OUT) +libxl_smbios_type = Enumeration("smbios_type", [ + (1, "bios_vendor"), + (2, "bios_version"), + (3, "system_manufacturer"), + (4, "system_product_name"), + (5, "system_version"), + (6, "system_serial_number"), + (7, "baseboard_manufacturer"), + (8, "baseboard_product_name"), + (9, "baseboard_version"), + (10, "baseboard_serial_number"), + (11, "baseboard_asset_tag"), + (12, "baseboard_location_in_chassis"), + (13, "enclosure_manufacturer"), + (14, "enclosure_serial_number"), + (15, "enclosure_asset_tag"), + (16, "battery_manufacturer"), + (17, "battery_device_name"), + ]) + +libxl_smbios = Struct("smbios", [ + ("key", libxl_smbios_type), + ("value", string), + ], dir=DIR_IN) + libxl_domain_create_info = Struct("domain_create_info",[ ("type", libxl_domain_type), ("hap", libxl_defbool), @@ -604,6 +629,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("altp2m", libxl_defbool), ("system_firmware", string), ("smbios_firmware", string), + ("smbios", Array(libxl_smbios, "num_smbios")), ("acpi_firmware", string), ("hdtype", libxl_hdtype), ("nographic", libxl_defbool), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1b5381cef0..47521e9924 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1220,8 +1220,9 @@ void parse_config_data(const char *config_source, XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms, *usbctrls, *usbdevs, *p9devs, *vdispls, *pvcallsifs_devs; XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs, - *mca_caps; + *mca_caps, *smbios; int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps; + int num_smbios; int pci_power_mgmt = 0; int pci_msitranslate = 0; int pci_permissive = 0; @@ -1783,6 +1784,61 @@ void parse_config_data(const char *config_source, xlu_cfg_replace_string(config, "acpi_firmware", &b_info->u.hvm.acpi_firmware, 0); + switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) + { + case 0: /* Success */ + b_info->u.hvm.num_smbios = num_smbios; + b_info->u.hvm.smbios = xcalloc(num_smbios, sizeof(libxl_smbios)); + for (i = 0; i < num_smbios; i++) { + libxl_smbios_type type; + char *option; + char *value; + + buf = xlu_cfg_get_listitem(smbios, i); + if (!buf) { + fprintf(stderr, + "xl: Unable to get element #%d in smbios list\n", + i); + exit(EXIT_FAILURE); + } + + option = xstrdup(buf); + value = strchr(option, '='); + if (value == NULL) { + fprintf(stderr, "xl: failed to split \"%s\" at '='\n", + option); + exit(EXIT_FAILURE); + } + + *value = '\0'; + value++; + + if (*value == '\0') { + fprintf(stderr, + "xl: empty value not allowed for smbios \"%s=\"\n", + option); + exit(EXIT_FAILURE); + } + + e = libxl_smbios_type_from_string(option, &type); + if (e) { + fprintf(stderr, "xl: unknown smbios type '%s'\n", option); + exit(EXIT_FAILURE); + } + + b_info->u.hvm.smbios[i].key = type; + b_info->u.hvm.smbios[i].value = xstrdup(value); + + free(option); + } + break; + case ESRCH: /* Option not present */ + break; + default: + fprintf(stderr,"xl: Unable to parse smbios options.\n"); + exit(EXIT_FAILURE); + } + if (!xlu_cfg_get_string(config, "ms_vm_genid", &buf, 0)) { if (!strcmp(buf, "generate")) { e = libxl_ms_vm_genid_generate(ctx, &b_info->u.hvm.ms_vm_genid); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 12:25:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 12:25:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405798.648227 (Exim 4.92) (envelope-from ) id 1oXiVP-0001lL-QE; Mon, 12 Sep 2022 12:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405798.648227; Mon, 12 Sep 2022 12:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiVP-0001lE-Ni; Mon, 12 Sep 2022 12:25:39 +0000 Received: by outflank-mailman (input) for mailman id 405798; Mon, 12 Sep 2022 12:25:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXiVO-0001jo-Gz for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 12:25:38 +0000 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [2607:f8b0:4864:20::831]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 018f9049-3296-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 14:25:37 +0200 (CEST) Received: by mail-qt1-x831.google.com with SMTP id r20so5265733qtn.12 for ; Mon, 12 Sep 2022 05:25:37 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:cc03:373b:6dc6:a951]) by smtp.gmail.com with ESMTPSA id f1-20020ac87f01000000b0031d283f4c4dsm6705092qtk.60.2022.09.12.05.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 05:25:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 018f9049-3296-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=V33BKHTi+CTctDhgtOfP1KF/zJZENPtCD+zRgxvpiFQ=; b=n66CkPP/jpCs8+8ebpJA+lRFwv18BalWVRObdIA5HywX88tSB7vZ8uMMafdENRf9DZ FI2EdcBeIJ86t6mDbLmDvvLwtRLOS/9yLiKGwaBuX73foAdXwRxdUUGAD1DoPZ8toGNJ SXEnI7oPDrjSqEue+0B0jSTk4ueJyMHMFCcgRCAh/tHeOE1mr+FV+HEYqTPjnQREsPwU ZdeW5+y9+IXHs6dXuTHHd12qZLEfGuFuIDZEcyPB+Xr/x520Ufxn6QPLwD1LDxdE7+Ya AB1DkVEXv2PX/RGM/xjRi+yioj+CBr4nRoxDAMwwnh3nVdIOyFaQFTeb9iK1AUDrgklU xlOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=V33BKHTi+CTctDhgtOfP1KF/zJZENPtCD+zRgxvpiFQ=; b=NqnsmttgEnp5G8wxnSbcnTghXn5kCutPvwsvzhQDUyMzb+lgbr9qzmrg9p+d7FTohv 5OA6TpWl+YaRE0RCvY2/Q9U0SdPQtTElZ4UYeDs3N8Zz2FBEtzD/fCJX4XDemAzEWJWI 7d4L6TotkH5HCAiK41M5vKSRYKu/VrD7GDHp9BVKPdHeI5Oap6/zu89q9SUpTELMmepO 17EiLqVSoa2zh7UTLCsBzWpFpgBV2+ZB++oPwtyk5yb4RS6F7CQKeGFVAaFX6Jt0R8HO bX+tHuGeiQVkCsH7rnBimT+AcZboD3t6qNXGFqaxRrybE8ymdsBtyHn5md//d+CsT1oK WUag== X-Gm-Message-State: ACgBeo0a+bqKnSC4x/iVTlT+kHQeI1LBDUpCRKvLLFOVMFGi1qlbHYiq ZAfbjBR5vvDrjwxKrxk7yw2Urm6U3QA= X-Google-Smtp-Source: AA6agR6Q89NHRTrIucyiJfsXV9WxAvd0EHT+kmUzh29EgEAeyTtrzRtuKnIrh1AEmn9hH3EPnCtAyw== X-Received: by 2002:ac8:5b8c:0:b0:35b:b653:70cb with SMTP id a12-20020ac85b8c000000b0035bb65370cbmr2582169qta.477.1662985536361; Mon, 12 Sep 2022 05:25:36 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [PATCH v3 3/3] xl/libxl: Add OEM string support to smbios Date: Mon, 12 Sep 2022 08:22:37 -0400 Message-Id: <20220912122237.5431-4-jandryuk@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220912122237.5431-1-jandryuk@gmail.com> References: <20220912122237.5431-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for OEM strings in the SMBIOS type 11. hvmloader checks them sequentially, so hide the implementation detail. Allow multiple plain oem= items and assign the numeric values internally. Signed-off-by: Jason Andryuk --- v3: Add } from patch 2 to parse_config_data Use EXIT_FAILURE Print error message in libxl for > 99 OEM strings v2: Move oem= description to be indented in docs Re-work oem= description Re-word oem string limit xl error message Replace OEM_{1,99) with just OEM and handle in libxl This change re-introduces the newline before ms_vm_genid. --- docs/man/xl.cfg.5.pod.in | 4 ++++ tools/golang/xenlight/types.gen.go | 1 + tools/libs/light/libxl_dom.c | 16 ++++++++++++++-- tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 13 +++++++++++++ 5 files changed, 33 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index fa78fba361..ddba1c3a05 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2104,6 +2104,10 @@ Each B is a C string from the following list: =item B +=item B + +oem= can be specified up to 99 times. + =back =item B diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index e084c3540b..51076249b4 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -405,6 +405,7 @@ SmbiosTypeEnclosureSerialNumber SmbiosType = 14 SmbiosTypeEnclosureAssetTag SmbiosType = 15 SmbiosTypeBatteryManufacturer SmbiosType = 16 SmbiosTypeBatteryDeviceName SmbiosType = 17 +SmbiosTypeOem SmbiosType = 18 ) type Smbios struct { diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 4f85623c42..12d027a575 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -753,6 +753,7 @@ static int hvm_build_set_xs_values(libxl__gc *gc, const libxl_domain_build_info *info) { char *path = NULL; + int num_oem = 1; int ret = 0; if (dom->smbios_module.guest_addr_out) { @@ -773,8 +774,19 @@ static int hvm_build_set_xs_values(libxl__gc *gc, for (int i = 0; i < info->u.hvm.num_smbios; i++) { char *p; - path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, - libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); + if (info->u.hvm.smbios[i].key == LIBXL_SMBIOS_TYPE_OEM) { + if (num_oem > 99) { + LOGD(ERROR, domid, "More than 99 SMBIOS OEM strings specified"); + ret = ERROR_INVAL; + goto err; + } + path = GCSPRINTF("/local/domain/%d/"HVM_XS_OEM_STRINGS, domid, + num_oem); + num_oem++; + } else { + path = GCSPRINTF("/local/domain/%d/"HVM_XS_BIOS_STRINGS"/%s", domid, + libxl_smbios_type_to_string(info->u.hvm.smbios[i].key)); + } /* Convert libxl_smbios_type string to xenstore path that hvmloader * will use, as defined by HVM_XS_*. That is convert the '_' to '-'. */ diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d04207748e..76651eea43 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -436,6 +436,7 @@ libxl_smbios_type = Enumeration("smbios_type", [ (15, "enclosure_asset_tag"), (16, "battery_manufacturer"), (17, "battery_device_name"), + (18, "oem"), ]) libxl_smbios = Struct("smbios", [ diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 47521e9924..f9b4db16a6 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1787,6 +1787,9 @@ void parse_config_data(const char *config_source, switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0)) { case 0: /* Success */ + { + unsigned int num_oem = 1; + b_info->u.hvm.num_smbios = num_smbios; b_info->u.hvm.smbios = xcalloc(num_smbios, sizeof(libxl_smbios)); for (i = 0; i < num_smbios; i++) { @@ -1826,12 +1829,22 @@ void parse_config_data(const char *config_source, exit(EXIT_FAILURE); } + if (type == LIBXL_SMBIOS_TYPE_OEM) { + if (num_oem > 99) { + fprintf(stderr, + "xl: smbios limited to 99 oem strings\n"); + exit(EXIT_FAILURE); + } + num_oem++; + } + b_info->u.hvm.smbios[i].key = type; b_info->u.hvm.smbios[i].value = xstrdup(value); free(option); } break; + } case ESRCH: /* Option not present */ break; default: -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 13:25:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 13:25:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405811.648239 (Exim 4.92) (envelope-from ) id 1oXjQT-0000NO-2Q; Mon, 12 Sep 2022 13:24:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405811.648239; Mon, 12 Sep 2022 13:24:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjQS-0000NH-Ur; Mon, 12 Sep 2022 13:24:36 +0000 Received: by outflank-mailman (input) for mailman id 405811; Mon, 12 Sep 2022 13:24:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjQR-0000NB-Oy for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 13:24:36 +0000 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [2607:f8b0:4864:20::f2a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36be879e-329e-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 15:24:23 +0200 (CEST) Received: by mail-qv1-xf2a.google.com with SMTP id y9so6667768qvo.4 for ; Mon, 12 Sep 2022 06:24:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36be879e-329e-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5P5x0IAgxd/2DXkuZ9Kq/5iwKCuZHBST8BjihYLy0Ag=; b=n8aguukkLKro3i5Gf5KKiagB6WL3yx5eXgE+tCTuXVbLlfjnX/3AcdpdVO8RBi0QfV 6f9OZ+fpj3kroz5lXo5ZYldjk+CaNaRVCArVMvdOwCeCbNTGqjG2I2WsfQq5jMEmsCYI s8w7nT6+ek7x2Svq7EE4Gc1qD1xeFIi2IQGmXldE8J7cL8vKHB5bcloHUIJKL9EYHzQc lY+o1XHN7Ouf7MrH2SCv0nBiJ280FgzVl/tZrX1mw60adfR0xnkxwJl2xMeZ0pxWQju+ scViTvwYhR3NL0le+gSrPKDrnDiFvMiFHWiVk6YCxchlf21Y3DrKeYS1mpeBDs2pQ6bC mrXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5P5x0IAgxd/2DXkuZ9Kq/5iwKCuZHBST8BjihYLy0Ag=; b=KTQFVEupvpTQpKZH6tiuMSWFoGcW5zViyBbav4loNyUQXPc0CAhBllN3gSJz5jdSWe +K0YEIZ3doiY77b9GyClUeTEZcHYeE8k2JfbjaUPtBe10g0qLNhnRX/Llj1AbwqqmvF8 +0wlnaSBIQQwiZJPabDSUXlhb2mtMXDx9FEuKjfNHR4pFFS6wsfVvQA5/FMeOMvVzQed gJqXwPEl0qHXRfIY2twBQtx4dTPhxsDHCoiE/g4OXgZJi3QwUFrWgzLHKINfK+qtyWhE x2ZFrotgNmbkEN/twAlBhYGYoFmJ2QIiaeiJMQnzK2KcdpQUyS+J2diYZ3K2P2jR2V2o Ha0Q== X-Gm-Message-State: ACgBeo09Vasi9Owvf/3GhpPY6eqncRePaQRLXW/wcJ1XoGt6Cod2xRCo VRsCUfgC2rdLXi6ThiVCSiEx6Z4WVNT2iUu6ix6Ieg== X-Google-Smtp-Source: AA6agR4pfmNXlrUDBmMBh3V7OAnqsodbb6V1xdaGCifmydawZ0xxOz15BsWC47sIn6wCnFvq7KAhm7ekGtSJ1xI0WXo= X-Received: by 2002:a05:6214:238b:b0:48a:f607:c4e0 with SMTP id fw11-20020a056214238b00b0048af607c4e0mr22877411qvb.44.1662989071787; Mon, 12 Sep 2022 06:24:31 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> In-Reply-To: From: Carlo Nonato Date: Mon, 12 Sep 2022 15:24:21 +0200 Message-ID: Subject: Re: [PATCH 00/12] Arm cache coloring To: Julien Grall , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com Content-Type: text/plain; charset="UTF-8" Hi Julien, On Sat, Sep 10, 2022 at 5:12 PM Julien Grall wrote: > > Hi Carlo, > > On 26/08/2022 13:50, Carlo Nonato wrote: > > Shared caches in multi-core CPU architectures represent a problem for > > predictability of memory access latency. This jeopardizes applicability > > of many Arm platform in real-time critical and mixed-criticality > > scenarios. We introduce support for cache partitioning with page > > coloring, a transparent software technique that enables isolation > > between domains and Xen, and thus avoids cache interference. > > > > When creating a domain, a simple syntax (e.g. `0-3` or `4-11`) allows > > the user to define assignments of cache partitions ids, called colors, > > where assigning different colors guarantees no mutual eviction on cache > > will ever happen. This instructs the Xen memory allocator to provide > > the i-th color assignee only with pages that maps to color i, i.e. that > > are indexed in the i-th cache partition. > > > > The proposed implementation supports the dom0less feature. > > The solution has been tested in several scenarios, including Xilinx Zynq > > MPSoCs. > > > > Overview of implementation and commits structure > > ------------------------------------------------ > > > > - [1-3] Coloring initialization, cache layout auto-probing and coloring > > data for domains are added. > > - [4-5] xl and Device Tree support for coloring is addedd. > > - [6-7] A new page allocator for domain memory that implement the cache > > coloring mechanism is introduced. > > - [8-12] Coloring support is added for Xen .text region. > > > > Changes in v2 > > ------------- > > > > Lot of things changed between the two versions, mainly I tried to follow > > all the comments left by the maintainers after the previous version review. > > Here is a brief list of the major points (even if, imho, it's easier to > > repeat all the review process): > > The series doesn't build on Arm64 without cache coloring. Please make > sure to compile and check that Xen still boot on system after your > series with cache coloring disabled. I'm sorry for that. Tested multiple times, but probably missed it after some last minute change. The following diff fixes it. diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 00351ee014..6abe2fdef7 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -411,7 +411,7 @@ static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn) #else #define virt_boot_xen(virt) virt #define set_value_for_secondary(var, val) \ - var = val; + var = val; \ clean_dcache(var); #endif > > Cheers, > > -- > Julien Grall Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Mon Sep 12 13:54:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 13:54:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405821.648252 (Exim 4.92) (envelope-from ) id 1oXjtf-0004GG-E6; Mon, 12 Sep 2022 13:54:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405821.648252; Mon, 12 Sep 2022 13:54:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjtf-0004G9-B3; Mon, 12 Sep 2022 13:54:47 +0000 Received: by outflank-mailman (input) for mailman id 405821; Mon, 12 Sep 2022 13:54:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjtd-0004G3-FS for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 13:54:45 +0000 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [2607:f8b0:4864:20::834]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7453953d-32a2-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 15:54:44 +0200 (CEST) Received: by mail-qt1-x834.google.com with SMTP id cb8so6214015qtb.0 for ; Mon, 12 Sep 2022 06:54:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7453953d-32a2-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=1TfDPzeWKoR38ig0PtJOl+hpfHqUaMAu2cCjgQ7L6uk=; b=wHJhPaJ9XAaizcdwTeQTnsOjl9z+FlLNuYlgj1UUtUcdMZrYSgBTd4qzn8gAt6zWjX EbJUy7zStO0RfI9PaXYvlOpF+kYRsynCGi9x+8hA468fLPCCy4lbaaodWf9aVegZQibm TDZXy0Li8lY8HZQM/PXodLdcelZ89Z38hf3SIb9oxL9xObpX0x2pBfUTKdrzpCeyT3gc Zgj7PqlvhxEqmqLLkHt7cXRpMDXjCM4RPQmsHm/eoMibEnwiizw9pU3CclcaX+C8IsN3 nKEF88PparwtMK7QNhVhM7cdyK80JbXnscbd6zCDABMVuQsW+KIHpvj/Uz44B/AsPGed 5ooQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=1TfDPzeWKoR38ig0PtJOl+hpfHqUaMAu2cCjgQ7L6uk=; b=rSEH9Pzudn5g+A1vi4qqT9l/BSKNqPhkbzJkBbdqz+QtCBlS9gIiOuazKgwsTOWAav Qoi0F0xzubWm0d+KSsx01oPzF0B09696+m0kWipGyU5nJp+O7zFQU+Gh/psmB69csvEd PxHC00e0Yp1ABQb+OLdSaWDZOz3VO17y+tRfmYPYNGHqq7xyu7nY4klycOYIqfVC5SOK PMGESR1LG5jZmvTutzPnAQJ+NDfgDTtDw6mK90adRcWvxGieBntLdO9LaYoAWWXyrPIn olz2dAlqBZCP87TYSD1FMMKMKSHY6Stx1b+bTdygcxQoZPhuc3IMeDMzNHA0dS9HJdu+ +8hQ== X-Gm-Message-State: ACgBeo07+6nfp0x54gpzG16MSc6l+cYs+IjO1Lj2qX/UbTB2DjzgLQvd aoMBUFqpILsCZKO9skV+qOVikxsIm/gaW83nzBIqruU+6vo6NQ== X-Google-Smtp-Source: AA6agR7Vm57a313IFHC04iCVaSL8FfVcBWTO7OslfPrjK+qMkV+7KzaQHqbmhyn4ZLO0fJF4Fkh0vYol81IBk5KMH90= X-Received: by 2002:ac8:57ce:0:b0:344:ad3e:cb16 with SMTP id w14-20020ac857ce000000b00344ad3ecb16mr23347234qta.214.1662990883199; Mon, 12 Sep 2022 06:54:43 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-9-carlo.nonato@minervasys.tech> In-Reply-To: From: Carlo Nonato Date: Mon, 12 Sep 2022 15:54:32 +0200 Message-ID: Subject: Re: [PATCH 08/12] Revert "xen/arm: setup: Add Xen as boot module before printing all boot modules" To: Julien Grall Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Julien, On Sat, Sep 10, 2022 at 4:01 PM Julien Grall wrote: > > Hi, > > On 26/08/2022 13:51, Carlo Nonato wrote: > > From: Luca Miccio > > > > This reverts commit 48fb2a9deba11ee48dde21c5c1aa93b4d4e1043b. > > > > The cache coloring support has the command line parsing as a prerequisite > > because of the color configurations passed in this way. Also, the Xen boot > > module will be placed at an address that depends on the coloring > > initialization. This commit moves the Xen boot module after the coloring > > initialization to allow the order of operations previously described to > > take place. > > The commit you revert was created in order to print the position of Xen > on the console. So while I understand your aim, you are (temporarily?) > not printing Xen address anymore. Yes. The address will be printed by the get_xen_paddr() function in later patches, but only when coloring is enabled. So I probably need to find a way to print it regardless of the configuration. Do you have any suggestions? Is it ok to add the print to this very patch explaining why I added that (since it would edit the clean revert)? > > Therefore your commit message, should contain some words explaining why > this is fine and how this problem will be addressed. > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 12 14:00:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 14:00:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405830.648264 (Exim 4.92) (envelope-from ) id 1oXjyn-0005gy-2w; Mon, 12 Sep 2022 14:00:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405830.648264; Mon, 12 Sep 2022 14:00:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjym-0005gN-UE; Mon, 12 Sep 2022 14:00:04 +0000 Received: by outflank-mailman (input) for mailman id 405830; Mon, 12 Sep 2022 14:00:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjym-0005Sy-7v for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 14:00:04 +0000 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [2607:f8b0:4864:20::f2f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3262bb06-32a3-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 16:00:03 +0200 (CEST) Received: by mail-qv1-xf2f.google.com with SMTP id d1so6776354qvs.0 for ; Mon, 12 Sep 2022 07:00:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3262bb06-32a3-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=oGjwpKdUm9W02bdQDqf4c8TH2tz3B8jnWHZnYzh17d0=; b=YIMU8doEhxv36d24kt3LEj91HmmWypRL8yu+2+qrZEqkynzDgkMXu7ds1nCrGaW0ja BJsjxjx06Zqv/dWBhlP8PfoD3aq/02tOa8mVL3exy24zU+rHmfN28HQYe1qVU4Gnb1UO qlFVFKa3I/oxMUpjehcZGjEoB+a/ad/huAoLCN5T6J981UP8NbXvmNcVhUWVe54wFVXy fZSy1zsIy2puHzT6sGQgdkxLpGLerWTGTLYvOez/Jm50YYX6cTJmeeqvzIMGfcQavgks jqR3WX+rk8FXDoJAUKnINTQpdxiUA0bJN6Sdw94+DDJRBDzoFG/0KqCzFDVj7yotZ9q+ KF2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=oGjwpKdUm9W02bdQDqf4c8TH2tz3B8jnWHZnYzh17d0=; b=oChv9UGPfv6FvabFw44LhyDAaBhoxQqpfaghzy2pvtzfRgjNytxz2tOSEem7+qBnpy L/pUuy5raeVgY15VQwBrMAc2lTb0PbRsKACe50PzOETqUjkU1Tk9GMv9F9wl7VMbrd2u /r/ZjfSCRgH8SSGh3iCy4W0132BFoHp1itOBy2TH1jBlZwdK+8M8yYXHanDTqj4i58+t BLv434w9tSNDPMmCrMqSqIZgasuR6a3V7Tb+7KjHw8R4yjYGUn662PxQYvyJJ0xfRF9z u2vdlZ2njz+myUYgxMvFt3bO7AqjGseE1sNI/+RDWp0sifscbLvkurnozB03xBs7nW0F ZS1g== X-Gm-Message-State: ACgBeo3z1ucmmL7mM3iaFDOQ1kexEEmQk5oL8v/g2myo44vK3jh+kQSX 7tHAyHbwcCaCYk2kQUWu0Cp/86r6ezljQNgBn8TZ+w== X-Google-Smtp-Source: AA6agR6zxinXFB3JWSAMOzo9H2jsPbK1TcEbkfNyw9scuC9y9x/WwQi2+d3h7AbrcOGu5hEKrGk327rQXj/k6yat0NQ= X-Received: by 2002:a05:6214:27e4:b0:4ac:a631:f551 with SMTP id jt4-20020a05621427e400b004aca631f551mr7620045qvb.12.1662991202016; Mon, 12 Sep 2022 07:00:02 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-10-carlo.nonato@minervasys.tech> In-Reply-To: From: Carlo Nonato Date: Mon, 12 Sep 2022 15:59:51 +0200 Message-ID: Subject: Re: [PATCH 09/12] Revert "xen/arm: mm: Initialize page-tables earlier" To: Julien Grall , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Julien, On Sat, Sep 10, 2022 at 4:29 PM Julien Grall wrote: > > Hi Carlo, > > On 26/08/2022 13:51, Carlo Nonato wrote: > > From: Luca Miccio > > > > This reverts commit 3a5d341681af650825bbe3bee9be5d187da35080. > > Usually, this indicates that this was a clean revert. IOW, there was no > clash or modification necessary. Looking at the diff below, this doesn't > look to be the case because you are also reverting f8c818848fa6 > "xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen()" > and introduce a new version of create_boot_mappings(). > > So I think the commit message/title should be reworded to explain this > is not a clean revert and what extra changes were made. > > But see below about re-introducing create_boot_mapping(). > > > > > The cache coloring support will be configurable within the Xen command line, > > but it will be initialized before the page-tables; this is necessary > > for coloring the hypervisor itself beacuse we will create a specific > > mapping for it that could be configured using some command line options. > > In order to parse all the needed information from the device tree, we > > need to revert the above commit and restore the previous order for > > page-tables initialization. > > > > Signed-off-by: Carlo Nonato > > Signed-off-by: Marco Solieri > > --- > > xen/arch/arm/mm.c | 33 ++++++++++++++++++++------------- > > xen/arch/arm/setup.c | 4 ++-- > > 2 files changed, 22 insertions(+), 15 deletions(-) > > > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > > index b42cddb1b4..1afa02b4af 100644 > > --- a/xen/arch/arm/mm.c > > +++ b/xen/arch/arm/mm.c > > @@ -368,6 +368,17 @@ static inline lpae_t pte_of_xenaddr(vaddr_t va) > > return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); > > } > > > > +static void __init create_boot_mappings(unsigned long virt_offset, > > + mfn_t base_mfn) > > +{ > > + lpae_t pte; > > + > > + pte = mfn_to_xen_entry(base_mfn, MT_NORMAL); > > + write_pte(&boot_second[second_table_offset(virt_offset)], pte); > > + flush_xen_tlb_local(); > > +} > Please don't introduce a new function that create mappings. All mappings > should be done using map_pages_to_xen(). Looking at the implementation, > it should be usable with the following diff: > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index c81c706c8b23..78afb8eb0ec1 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1104,7 +1104,7 @@ static int xen_pt_update(unsigned long virt, > * > * XXX: Add a check. > */ > - const mfn_t root = virt_to_mfn(THIS_CPU_PGTABLE); > + const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); > > /* > * The hardware was configured to forbid mapping both writeable and > > With that there is no change required in early_fdt_map() and ... > > > > > + /* ... DTB */ > > + pte = boot_second[second_table_offset(BOOT_FDT_VIRT_START)]; > > + xen_second[second_table_offset(BOOT_FDT_VIRT_START)] = pte; > > + pte = boot_second[second_table_offset(BOOT_FDT_VIRT_START + SZ_2M)]; > > + xen_second[second_table_offset(BOOT_FDT_VIRT_START + SZ_2M)] = pte; > > + > > ... rather than copying the 2 entries, you could call early_fdt_map() > after the switch. The advantage is it will avoid to hardoded more > page-table entries. Thanks for the diff and the suggestions. I just tested it and it works properly! Nice. > > As part of my switch_ttbr() rework, I am planning to re-introduce > relocation (at least for testing). So I will include the changes I > mention above in my series. > > Cheers, > > -- > Julien Grall Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Mon Sep 12 14:22:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 14:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405841.648275 (Exim 4.92) (envelope-from ) id 1oXkKF-0000Mj-PG; Mon, 12 Sep 2022 14:22:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405841.648275; Mon, 12 Sep 2022 14:22:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkKF-0000Mc-Mg; Mon, 12 Sep 2022 14:22:15 +0000 Received: by outflank-mailman (input) for mailman id 405841; Mon, 12 Sep 2022 14:22:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkKE-0000MS-8c; Mon, 12 Sep 2022 14:22:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkKE-0006Va-5x; Mon, 12 Sep 2022 14:22:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkKD-0001kQ-JH; Mon, 12 Sep 2022 14:22:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXkKD-0000xm-Ir; Mon, 12 Sep 2022 14:22:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2bS1Z6uFjq/qlxbSB4bc0NiA7CoVZe17Lqbp73DmU70=; b=4vWdkSeRehkt+8FsPLjQWntGYO MF//oosdYME/ZncAC+O4m3uVMrtf0BRMdSWDjTCotskftAU8FcCGvN1XdyQnz4NEnV98yycDOyc5A y9wpW3Vm4kpLGxZfIh8GiwFb+F4Z+/KhyDkOp9KSGlnUvx0QBnBoeGceYRCfO3mRG6rM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173151: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 14:22:13 +0000 flight 173151 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173151/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 39 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 295 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 14:43:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 14:43:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405852.648289 (Exim 4.92) (envelope-from ) id 1oXkea-0003EP-Lg; Mon, 12 Sep 2022 14:43:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405852.648289; Mon, 12 Sep 2022 14:43:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkea-0003EI-J2; Mon, 12 Sep 2022 14:43:16 +0000 Received: by outflank-mailman (input) for mailman id 405852; Mon, 12 Sep 2022 14:43:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkeY-0003E8-Pn; Mon, 12 Sep 2022 14:43:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkeY-0006rT-GL; Mon, 12 Sep 2022 14:43:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXkeX-0002gZ-Ul; Mon, 12 Sep 2022 14:43:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXkeX-0002bn-UH; Mon, 12 Sep 2022 14:43:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GquNOxVqPB2J//LV0qbD7sDvd8u+VO4DMcb4H0qOayo=; b=RskjDFRLfMFUHtYh3Pg7+BBGrw rMJExTRf0qw1gO8WAACS8+xtNVWT/OBq8VeRkUH9aiUWJIVla7AtltF25vfJ6FEZGBS/66jOPI2j8 42h57bOknB226HDhpfqwfjFHezOyTbM43V15h9GKkQ+Yllt1e/KR8eDj4bgwvcbrF1us=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173147: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Mon, 12 Sep 2022 14:43:13 +0000 flight 173147 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173147/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 173138 pass in 173147 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173138 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 39 days Failing since 172148 2022-08-04 21:39:38 Z 38 days 87 attempts Testing same since 173060 2022-09-08 07:34:59 Z 4 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 15:18:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 15:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405864.648300 (Exim 4.92) (envelope-from ) id 1oXlC8-00079l-DQ; Mon, 12 Sep 2022 15:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405864.648300; Mon, 12 Sep 2022 15:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXlC8-00079e-9P; Mon, 12 Sep 2022 15:17:56 +0000 Received: by outflank-mailman (input) for mailman id 405864; Mon, 12 Sep 2022 15:17:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXlC6-00079Y-PP for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 15:17:54 +0000 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1265ab5b-32ae-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 17:17:53 +0200 (CEST) Received: by mail-wr1-f41.google.com with SMTP id bq9so15928108wrb.4 for ; Mon, 12 Sep 2022 08:17:53 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id l128-20020a1c2586000000b003b340f00f10sm10620972wml.31.2022.09.12.08.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 08:17:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1265ab5b-32ae-11ed-a31c-8f8a9ae3403f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=rSdFp//FgK95mf2it0s18pZ/BW4X/WUoHMbm0UPV7z8=; b=sb63FUmwV1H2cBDbgzqrt0gBoxWgj66Y/dnkE+gTC411HPgcIZGMwJAOQesbP/5zW7 lofR7TFzwUDStWehxqrhwWJAQTgDL4UB24vkNG2+v4pwAQTUOhaVk1MZ7V9BA+EoZxyK rYkWU8isd5U2U4XungO9tpdGFi1VaegMcSG51MMNyHZ1cMhTUx4yWag0BpOnWL24Wkgt Ko7drrGQeaIftMOxq09fLkeJBmramEsi2FsKjq7iShFSkQ0/kzd7RKgZK2FHoKi8dcEk aDeHTpK55enO5+vGy1/KM4hCCtmNrtcRv62IPLTkXHLIkf9sDJk4H4iZpsfk5y92eC2p NJkw== X-Gm-Message-State: ACgBeo0/cx6zBh2kaOOinBt5TphcPTDrVdSKZS9w6pCsaBVlBnkTDsup RTmTTN51pef665tqEyI8evI= X-Google-Smtp-Source: AA6agR6UjoXyeanimEUu/0ShDd2DrSKVf2T+SZlfbgz83s1vDiNVKoZx1p80XujRdnPIWDmjvx62XQ== X-Received: by 2002:adf:e609:0:b0:22a:a6fd:cfe1 with SMTP id p9-20020adfe609000000b0022aa6fdcfe1mr2001572wrm.0.1662995873048; Mon, 12 Sep 2022 08:17:53 -0700 (PDT) Date: Mon, 12 Sep 2022 15:17:46 +0000 From: Wei Liu To: Ajay Kaher Cc: helgaas@kernel.org, bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, srivatsab@vmware.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, vsirnapalli@vmware.com, er.ajay.kaher@gmail.com, willy@infradead.org, namit@vmware.com, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, jailhouse-dev@googlegroups.com, xen-devel@lists.xenproject.org, acrn-dev@lists.projectacrn.org, Wei Liu Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on VMware hypervisor Message-ID: References: <1662448117-10807-1-git-send-email-akaher@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1662448117-10807-1-git-send-email-akaher@vmware.com> On Tue, Sep 06, 2022 at 12:38:37PM +0530, Ajay Kaher wrote: > During boot-time there are many PCI config reads, these could be performed > either using Port IO instructions (PIO) or memory mapped I/O (MMIO). > > PIO are less efficient than MMIO, they require twice as many PCI accesses > and PIO instructions are serializing. As a result, MMIO should be preferred > when possible over PIO. > > Virtual Machine test result using VMware hypervisor > 1 hundred thousand reads using raw_pci_read() took: > PIO: 12.809 seconds > MMIO: 8.517 seconds (~33.5% faster then PIO) > > Currently, when these reads are performed by a virtual machine, they all > cause a VM-exit, and therefore each one of them induces a considerable > overhead. > > This overhead can be further improved, by mapping MMIO region of virtual > machine to memory area that holds the values that the “emulated hardware” > is supposed to return. The memory region is mapped as "read-only” in the > NPT/EPT, so reads from these regions would be treated as regular memory > reads. Writes would still be trapped and emulated by the hypervisor. > > Virtual Machine test result with above changes in VMware hypervisor > 1 hundred thousand read using raw_pci_read() took: > PIO: 12.809 seconds > MMIO: 0.010 seconds > > This helps to reduce virtual machine PCI scan and initialization time by > ~65%. In our case it reduced to ~18 mSec from ~55 mSec. > > MMIO is also faster than PIO on bare-metal systems, but due to some bugs > with legacy hardware and the smaller gains on bare-metal, it seems prudent > not to change bare-metal behavior. > > Signed-off-by: Ajay Kaher The subject line should be fixed -- you're changing the behaviour for all hypervisors, not just VMWare. I almost skipped this because of the subject line. Thanks, Wei. From xen-devel-bounces@lists.xenproject.org Mon Sep 12 16:20:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 16:20:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405917.648332 (Exim 4.92) (envelope-from ) id 1oXmAp-00087z-DE; Mon, 12 Sep 2022 16:20:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405917.648332; Mon, 12 Sep 2022 16:20:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmAp-00087s-9y; Mon, 12 Sep 2022 16:20:39 +0000 Received: by outflank-mailman (input) for mailman id 405917; Mon, 12 Sep 2022 16:20:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmAn-00087m-Ty for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 16:20:38 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d3ca2521-32b6-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 18:20:35 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN2PR12MB4438.namprd12.prod.outlook.com (2603:10b6:208:267::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 16:20:31 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 16:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3ca2521-32b6-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gLHiz+K/7vdz8eBmmdICKKYl1HsdsQyj+WkEocLBLjhgt2UJr6QEgtJ0+h9Z6MRVsptbUPHIQfovycnDv4g1cCeK/qYwZ4ipKUgK7DvpO/2iENB2l6HeKYeHrjIMf5XrmPB7zoJRqnfbd1CaffFbM58DH5N/B8GVGicM79n+ACiU/n/xrT1Q+Njgk6YGYQh3adBXOyAlbFHIiDo04y+AagzndVJfUJwbkQafFqDDY3rssDzi20TErwsSL5Ry1yNpSYmHbAIGxWgR3ETWgggKmUB9g0f8SoAxZLIIHZvOiUU7suZKr5hU9HqCzQuOdV1lZrmKMYB5jQCLRE/Vz3Sf8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bA5j1ZJQf430YHTgcSreno3hXqKp6h4c7pse66j4lXI=; b=Bu3i3GZRnhk6nr6m7ST28D8R5Ozlj65v1r1md7p8SsvpZfY0ANxnUszYpNA3EWV595nWA5Qs7Rp7L65meJnNxrPN9qzbjaStkKZ2YaDLPwwBdBKb0gBc+py5pnwabnZhzQTl0CTj6ijGTJraCwitnBtJ0/BYDBWPA3oGsYrNr5LS/dcqDDR23b0hAFNm6g0wEN4G0/lYS5spsJLAb/Eveq8ex2EvrB059GDBRf9LGqwVhIPiBJECwXmSfq38qHDTn7m/V9IpF93L5hqKGGP2iJ3pPp1rLdypd/OZn9ORggpo998jWE9Mz8mX14KJeg6db4XFj6X7Ru94OVLMqZG75g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bA5j1ZJQf430YHTgcSreno3hXqKp6h4c7pse66j4lXI=; b=ST6naAQAFGHzn11wG5cczePQvXe51XcwdkP3315pWeMKx3liZg4JTWnn+DzxNYkM/i28PEyOGl8xqdsdL0GcyKlIFQu34+7wRk8EI1DmlBngcr9cungvs3ox2EJan9GmZcqPRBL16dBwAPTyBWKctn6ezlvKFgCMBxz+UWr6iBs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Mon, 12 Sep 2022 17:20:26 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [ImageBuilder] Update README.md To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20220912115918.19496-1-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220912115918.19496-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0548.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::11) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN2PR12MB4438:EE_ X-MS-Office365-Filtering-Correlation-Id: 53216402-c914-40a1-0703-08da94dab65a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Adv80JEgubVZJWi7fmD6EfPOhMTN3KxyG2jCLGp2fRQ0hg1KPVEJNIAzxpt5dGJItQ13e1xOtwp1u79SHf1ioiKPFXPlzWHxSY/PaTgNd7Mr9feLgF/+AP5TyLzutRaFhcyeVzeu+JGi7YajY8T3bKNa1xIJpSn4+kXgNBc8rFpD7VZc+mq/UQddTHRM0oZoQg0uuACugbKbMlI3Z6IwpwNMSUvqmIsfQML9/EGhdqW8nuhzzqfXBPE71B8LUgz1/FFQkFqP85BhgBQ+BjYzlIxe/lv59eTIxGder2Ne1NFxKtFxjpWG8HpdlFdBvYZLHh5IC4nv9LMSgCrdFHn8mxbLm9OjS9UjBSWBOhYG75lwF1o58lqJSqs3JKwYy6sJiOA3yFBrqHlCb0MwAKIo/rnFqFZ+c4tOxYgsCgeTvCr9LAFhwo3AqqNQCbf9czEKLuZvQxum2LOk3iXUmaBzntE2PyaPGiLYzXBc0YqT6HB6/L6t3xyVGzPSXDxItBk55olLLVq79RHlJ3R/yLiUS+GfohPbObxdkR9AvxBtnWB1YxWlg+kCVcEf0i7hIXw0/lYn5N2n/2nIV2xtlFJJ36Mr5JZlK0NbDKeNyfiQO7qc7yj0g8TiNZMxxw1JXARf9djPRTnEpj9oe6/0vFNjUUKSGkmoC8Vn2MI0cSIgKjw4EXhVhZcKdh6/Ep/q4gzcULy8h3+V/kdghevCVq6gr9KolsadDBWxN48xnntK9G/sgNj/P1bUluwIZl1ToaBbSmsskTWlmwwCHFxs5NyGjtdnaV/q8NxZ+im06cQMpdg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230017)(4636009)(346002)(396003)(39860400002)(376002)(366004)(136003)(8676002)(41300700001)(6666004)(38100700002)(53546011)(6512007)(186003)(478600001)(31686004)(5660300002)(6506007)(15650500001)(2616005)(83380400001)(6486002)(8936002)(36756003)(2906002)(66556008)(66946007)(26005)(4326008)(66476007)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmgwT1NoSkNia0JlTCthV3NKQzZVbS8xemJmNlNVMU42dnhGVEVXT0c1bnhL?= =?utf-8?B?QSt5eWw1d25qWHVVcTJsc2Z1V1hNVEtMQ0xLVnA5ZzJpQjF0U0IrWDJFc2l1?= =?utf-8?B?ck9IcHpkeFc3MWo5ZHdEMVVtMVpoSnJ0aGgrRytTclNWdEJueGhiaUx6NHFX?= =?utf-8?B?M2NtS0ZjZmtWeHVQdk0zSkFNQ1IzNlc2dVhQYlJxZE1oUnVEYzZ4cy9iaDJw?= =?utf-8?B?NDVqZDFJZjMxYnlKTmRmc3VzMTdvNTN6ODV3V3dqOFZKZ09uUTBXN2EyaFlJ?= =?utf-8?B?bWNxNmFrS0hEVE9HWFk5OUw4TkFOR0lLbTNCMVBDNW1Na0hUa1FNRWZ2LzNZ?= =?utf-8?B?Tm1HTk95VEJta2gxMDdFQXBxbCt2UDlvQ0lsV0hMTGhtT0xkbUN6S2Fqbk5C?= =?utf-8?B?QjdYdy9FdFVkVTllNDJMUy9XeDByWUhYUlIxVEM4WjJ0c3dpcVdQR2dqZWZM?= =?utf-8?B?QWhYYkl0dmZLb2UxbkhuNjVRVmtnZUZ1ekY4OEMrSFZmRXdVeWVTUDhobi9Y?= =?utf-8?B?SzFBWEJPZmh4NFVJTFVOSGdFMkVobkozNlRITWY0V1BiRjBQVlBzWUNiSW9T?= =?utf-8?B?dnl6VDNRMm10Z0xvN3duNjB2dHdTNWlORktCUkU3R2wvU1pIQUFGeWRkUEpU?= =?utf-8?B?VDM0Z214UGRDUFJ1eDgvb2s1bDZwYlQ0elF6MUdHajd4NHdqeERvcXVXcVNw?= =?utf-8?B?bmhwM3dGQnovWGZyYWs5MmgxTWJORlh6TzdML20wQmJKVXdyTnN3a1RxYzJs?= =?utf-8?B?cXF2bHJqTUlyd0t3TkNxaDg4TGN2bExqT3M3a1lBaWNUWDVGOFNDeVF4cUlz?= =?utf-8?B?NnFvSWJwc0pETUJJcTNUOTNIL0NYNEFuOVZJUms4RzNraEV5SmVJV3VDczRt?= =?utf-8?B?VlRUZlczU1FseTJwYlh6WmJXVEQ4Yi9XWnF1V1FwTWtSR0x1WFNTUEU3VTBX?= =?utf-8?B?ajlUSk5QdlU0dDZacXRTbmsycE53c0trYTlFaVpoWUNOYnFwQUNpcGpZdmlI?= =?utf-8?B?NjkvRmUxNTBLZVRzRW4yem5UOUE4WmNJV1RjTUdTWkFsQ2EyT2dWaSt3QzRV?= =?utf-8?B?VE9Va1ZmWi8xcjdPRC9zTzZ3UWtyREZpWnE2Z0haMnV0cUxYQWEwQllKSTJD?= =?utf-8?B?SllJbmxqRzAxR2ZQdzU4aWxOazdhaEo1ak9Wa3ZFYlhveDQ2L1Y2dkx2Wkdn?= =?utf-8?B?SkdXcjJGYUF5SEs5ZHVSeW80SC9RSnNwelRmSjhRMkVTQ3VzOWs5VWZlaThS?= =?utf-8?B?Zkh6b1c0Y3dVcjZVNHUveW4rZXkxVGRhWEpDSkt4blB1S0t3SE9rVzZVcG9B?= =?utf-8?B?SFlSWWxFNThQdzV2bFRpRnQ3eDJmaVdDWm8xc1VRRTVBYjZFRDdtYjVFUHVi?= =?utf-8?B?cWluZUhiQ0ZzS2VSVEZrQXFlU3FsY2sxTzNkcDhMYUV5b0NBa2dhaGNOTDha?= =?utf-8?B?VndkS25ZWHVnUDZ0MGJ6VmtSR0JnOGZGcjF1RnByZ2x6cG4wZnljR0ZIeFpM?= =?utf-8?B?K1Z3NjlPK3dBdkEzeWRLL1VmR25vRm1YVi9yekhpL1Awb3VwcmhHUjFaRWNT?= =?utf-8?B?YWp0RnI4UkcyM0hhSWdIRHpHaDJTYmZoRS80emNGblhBZi85dTdGd3U0VVhs?= =?utf-8?B?ZDNYSmlVcFZ3a0YzY011eGZXa1N0bDZZMGk0WTRSeUpLSVQyK2NvZVpud1Jn?= =?utf-8?B?YzJsUjJQcHVWVEFCV3diN3JTeERxZzh5Z0ZjdGJTeFkvQmlSMGEzeks5VEdN?= =?utf-8?B?N0RrVzg3d1ZnQzU0aDJPQ1F0aEo0dEcvVlJBL0JSaWZCc0VXS21zRU5ZZkxk?= =?utf-8?B?MTZNRmZQZktvbnA3dEhGVU9FZXp5K1NGaWRMK0RxT1cwU09TbHozOCtKT0NL?= =?utf-8?B?clZlVHNMMnh0WUkzYUtDOEJYRFUxNGR2UlNRanhvbXZ3WkxaQzI3M0xqcHNT?= =?utf-8?B?NGUrZGx6K0hDSFJLUWp3a0U1VW9QY1BEamV2ZW1ZTE1uWnUxOVNRcFhrZytr?= =?utf-8?B?WmxQOWRvcnhoUzUwQzJVUFc5dGFqS2dtTzJYTjlRRFJVdUwwRlpobWMzOG9s?= =?utf-8?B?MUNTajdyL3BEb2U0ZXhZYXI3WUpIL0ZJcnYxbGFuMWh3TmhQUEZ6MTlNV09F?= =?utf-8?Q?ririhkY3nFClIVZwT7hhVupwC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53216402-c914-40a1-0703-08da94dab65a X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 16:20:31.1668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lGE+3mbyF3Bkoj42cjucWahUTSDpQ3qlmQRygLsmCkVR4mqGbEPWbE8+DFjBwpcAdeP3URfWdbpNJJgwMp5Ebg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4438 On 12/09/2022 12:59, Michal Orzel wrote: > Get rid of references to XEN_PASSTHROUGH_PATHS, as there is no such option > and it should be replaced with DOMU_PASSTHROUGH_PATHS[number]. > > Update PASSTHROUGH_DTS_REPO example. The directory storing partial device > trees is now device-trees-2021.2/zcu102 instead of device-trees-2021.2. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder > --- > README.md | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/README.md b/README.md > index 041818349954..da9ba788a3bf 100644 > --- a/README.md > +++ b/README.md > @@ -34,7 +34,7 @@ BOOT_CMD="booti" > DEVICE_TREE="mpsoc.dtb" > XEN="xen" > XEN_CMD="console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1 bootscrub=0 vwfi=native sched=null" > -PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2" > +PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2/zcu102" > DOM0_KERNEL="Image-dom0" > DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused" > DOM0_RAMDISK="dom0-ramdisk.cpio" > @@ -99,9 +99,9 @@ Where: > > - PASSTHROUGH_DTS_REPO specifies the git repository and/or the directory > which contains the partial device trees. This is optional. However, if > - this is specified, then XEN_PASSTHROUGH_PATHS need to be specified. > + this is specified, then DOMU_PASSTHROUGH_PATHS[number] need to be specified. > uboot-script-gen will compile the partial device trees which have > - been specified in XEN_PASSTHROUGH_PATHS. > + been specified in DOMU_PASSTHROUGH_PATHS[number]. > > - DOM0_KERNEL specifies the Dom0 kernel file to load. > For dom0less configurations, the parameter is optional. From xen-devel-bounces@lists.xenproject.org Mon Sep 12 16:28:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 16:28:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405927.648343 (Exim 4.92) (envelope-from ) id 1oXmHw-0000e2-7t; Mon, 12 Sep 2022 16:28:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405927.648343; Mon, 12 Sep 2022 16:28:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmHw-0000dv-58; Mon, 12 Sep 2022 16:28:00 +0000 Received: by outflank-mailman (input) for mailman id 405927; Mon, 12 Sep 2022 16:27:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmHu-0000dZ-GK for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 16:27:58 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da83ba2a-32b7-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 18:27:55 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM4PR12MB5721.namprd12.prod.outlook.com (2603:10b6:8:5c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 16:27:53 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 16:27:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da83ba2a-32b7-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GTsc2NJyt0WjWPQrkBT1sBOtmb8mraGuXojn6pcLxqpWhrFHLS7UY6XHEgOsFQrbO70jqr8V0EPTvBqp1ZIxlSsqgM/2Usx/aG92/qa9GBdOJ+wsb4t+Z6cLbYBcVILFXPnXcgUKV3sDFvbNMsrZx26n2uRdcGvzBg8h5pJrukzE37uRL+tPdMo7iIrR0tPG5Tu/lkaYXoCoId8DpJty61QWHCKT6QP6HpRMVnjEZw64yO4oN/ayANgoaHulkHGGZ7oQBMwGf9TwWQWzQXeKiGY6+G+oYpVFZxuxndWGfw24NNJfyxFoXy2FgVSE93EkvqAo28B69Mfx0UdLdp3ghg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rpJ06u9BXM0JzeopbQ+Fova8Tdy6vBvUefEsnTwjJ0g=; b=bdfMRrGzF+IBcXKC2FEYJK4TotS8DFSpvXuc85V18dNNGlZOXLSB4rk8PUIy8A9nmIEfPX4BO/6ttBMLzoxMACKvI93MEGU7idnrAPO73NiC419/bzRbjiyl41dZHI7y/aSsesITw34w7hWCxaMdq+0ncWiT+01hSZkBY6lWwvXKWSDlpViB5IuuPW1Rk8IcrPWpjnIQsmb1Zcv4JpzQKofaOQJ5IriTD3HK/g7aRPvi4H7VKq3x7YSd5Xq5JgmAwZ1haiqaLQ7cAwK28eRR5w6MvH77IoUmYUzqKfitU3+KcEp3ig69nc1v4h14gY7mSv9tjmaQARtyXNvEFobRtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rpJ06u9BXM0JzeopbQ+Fova8Tdy6vBvUefEsnTwjJ0g=; b=ZIEUgMVBHx8XKiH6ajZ+DcmNBfD+zShX5WEj0wYH3+Jj1MyM0Zy3IljPbJnCZvzq+H+eUFRR8vaxCLkJrIsrxQytdjdNhWfOuE1GdC5AcAu5KkGqJj7RPv3VbD+6A3q0OoI1n4DOG4MA9S1p0GKqngApen8JWQGHyZ90lJyBBQA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <64aadcab-5f41-6d2f-4dc9-39415016816a@amd.com> Date: Mon, 12 Sep 2022 17:27:47 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [ImageBuilder 0/2] Use lopper to generate partial dts To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20220912115934.19552-1-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220912115934.19552-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0042.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::13) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM4PR12MB5721:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fdebf78-4f47-4dd2-6859-08da94dbbdb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 65dugSbKpmoO624oj6w40EHLxnFV7eLGY916e8bQW6PUTRObJOyhkFCwqWSCi1YY+9omRvUNfHOFTcLxy/1ox16Z51WWSbhim6I2i0TXrRUVnuNEJttVQ28EtYbQEoL6zr/tRuScBKKhPfF15c0jPNLwxkdfq28EdejthUapvutzKueXUmpCKryLzfu1NG0R3UKUv012b9oWZCkl9CyrqTbBiJwH2Yc96JyxfZL6zMF7sWaO5kyWz0uaKBjHO2Pqye72Xn8+2v0WJ6b8AMPVYEXIhg0cQrhEA424S7HMLqJ+oaJaRTAVbUCGnULnyX8zNAwSI4SAzLTu4W+Ggi4A2UAhOQwrkYm8CUOoRM1zijY/Mjb8yemyreTGugOZejZxMXFDzUgFisAHtDvmmsvdVdXoVx7bAEmu2+QP3+3MQw8Cs2vS/k+8IeJOxl8hWxYD1xgS9kfKydWYyW4e9fW7m18m0n/PEc/fZSkUXCGhe2VAskMwCUiaOEBJX5BegGRUAV6iJWQRfpG5lB3Bsa0lVp24gqd+i4TFrn5CFlKFcGKBtvcUmMh9A7C2czh7vCKb3Mk0fTAwtjZ1tGsWZXslj0HiU1pHPOeMRSUV1df7YfM5Odqe1yr5ZMCOShbiNSLAgB11Qe5VU7fYZ5vpY3+AuiZNiwp0KkA8fXUzZmQD/POPMeZBDZKOSTWePDYjVkGW0og9944O3huml4LobMiOdASsDUXqvtgpu6+RQqkJeEMEBujIVsOttFD4k+DulX7t9bQOpUrsz89RQgxM+uRib0Ow2JcoVN8l+tFVN/KgYGjT1Fosu1MSkeBPKBKqhdJMbyAgaYh47/kFsNYTmgEE4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230017)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(5660300002)(8936002)(2906002)(31686004)(36756003)(31696002)(83380400001)(966005)(316002)(66476007)(6486002)(38100700002)(66556008)(4326008)(66946007)(8676002)(41300700001)(6512007)(6666004)(53546011)(6506007)(26005)(478600001)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzVFRWZReGVkQkxmN2U3R0FNZzcwRUF0V0U4WEM5TW1OK0FzMnR0bkZvbmMx?= =?utf-8?B?TVZOWkp2dXVrd0RsUXg0N2lhVjB0dEY2Q0ZOY2ZoTXNwNjRKa3d4RkE4NGFr?= =?utf-8?B?eHpCMVdHTGRnQldlYjRwSkhtK2RVcWZBVkxhWTJtWXJVSFl2MFN2RlhUNlpU?= =?utf-8?B?UU9HTyt2RHhjQU4xUGkyMGs1ckRkQ0JDMVJwRFoyOTFwcnBrTDNYZEtZN0NY?= =?utf-8?B?UHdEUGJOUE5pQ2ovUnNLOUs4SEY2ejVmVUpSWllDalkxUHZtK2FIZzhLRDVa?= =?utf-8?B?ZGlTTWVhbVJFbG5wRWZCS1QxR1hNZHAwV0JXL2IrU3EzWERtUzhoTUVURzVG?= =?utf-8?B?ZGtxZllEck52WHNEZ3I1VGFMais2dHdLclVzQ1NzekNwWnBBOEt3Y01jVzBr?= =?utf-8?B?UURzUEcydnp1Unc4QjYwMkVDa1hza2htbVBTRFNTZXBaSVJuTkZSMHJYY05T?= =?utf-8?B?YWcra21CdXJURHd3QnRid1poYmlSL1IvUUtJclI0WVJRd2ZGZG9Xb0NmdHNI?= =?utf-8?B?Q0tBbWdLWGtnR3kyTEkySWhlRDlBWk5aQ3pLZDBvUDg2TW54WkgxdnZ0MWZr?= =?utf-8?B?anI0WHlFb2Juc2grSlpkSVVJenBHQW5GTk1qSXE3WDRJSDFTbW1hNjRRekpZ?= =?utf-8?B?SjMxYWU5MjFnRFVCRmhQd3hUYkdhMHdTVWRNd1BWSTd1OHZRbmp6TWlzaG0z?= =?utf-8?B?MnhoNEN0bVBXV1BEQ1lpM01tbGxMVGM3V0dSWHVPK1lUQ1JkMnFKRUFudUJV?= =?utf-8?B?Q2RzRy9uclMrdHdQWDdGSTVvR2lpVWlsVGZaendCbVdMaDVGZU5BTnM1cXdx?= =?utf-8?B?UytSbUcwQzBnTUtLRkdYaDl1NXptUFNwM1Rvd3pzaEN3NW9IV1RTVlYwZUpv?= =?utf-8?B?RHlHbHhjSm9FNklYc0hON3ZDU2Eyai96ZEtKV3hhc21TRDhXL2lpeWhZK2hR?= =?utf-8?B?Tm13TzRpTDA0eFpOYWZQT0pJMDByd241cERQYkdqZU9keThTN1V3Y3VVWkY0?= =?utf-8?B?UklIelRDMkdjWDlqMld0dG1EY1VRL2ZzQVRwMzMxTkg1bnhEdGd2MzJTUmJ4?= =?utf-8?B?NTNQVWFleVc5K3p3V01xdUVDeTV6K0J4ellZWFo4NnAvYlFCRCtUMXRqenhQ?= =?utf-8?B?dVNGZnRUWEFsOVJ3UFpqSkRSUTJmWmhHR0R3MWlRVHR3emI4VVQ3UWFIdExY?= =?utf-8?B?eGI3RnhMSkxET2V2VkowMFhNaEdHRE9uQVNzTWF0eXB1bHI0WG12RDBvYkxC?= =?utf-8?B?Q0NMWnZxc3lPS25ZS3ErYmZKbXZBbVlGZ3ZDOVhmMG91c2I5dkNYdU15dFIv?= =?utf-8?B?UXJ4ZXZyL1B4dWVYVUZOWkVsbjl1ZStSc0NabklqTEx1bzN6UE1jaVlhczIy?= =?utf-8?B?ODJPMHVFRlZqTi83NTdyenM0VzRlY01IbTJEd2JHdW1iL2FuRG01UW0veTU0?= =?utf-8?B?RTE0c2RMMEdwczk0V3hSSVorbnVvVkJIMGV3d1pjNm1zOWVUajZDTXZpelVY?= =?utf-8?B?bjIvZEdBTnoxOUJ4c3cyTTdlK1lRWTdUUVBBcm5yRys4KzZrbUJtcnNLdFQ3?= =?utf-8?B?M3E5U1JzR0loYlJ1VG9IeGVCMkFjVkFkY2ZCRnVIZ3FSU2FmT0l0dG5HaUkx?= =?utf-8?B?UGhwVGhzRkVrQVFxZDBEb1ZKNk80UUUwNGo2eDVMdzBlMEpJajl5SGRoUzQr?= =?utf-8?B?LzRURG5PNU5JSWxQUW9jUWZ4K3F5a1JOZ2Rwemo3ZlcxNFFqaVpBbk9pZE5w?= =?utf-8?B?RDIzdUtTemhaelZ1YTdvMVVoeitraThoN2FTVjkzWEN1Y2FsalRZWmVmaVBv?= =?utf-8?B?ZkEyOFJCaGhoNXpoV2Q4c0ZxeTQ4QmJjaGNlekJDSVdlUnFWYTVzVHRRYnZs?= =?utf-8?B?MnZKeVRiWERHWDdVWVF0Y1oxUU1ZUDVnYStjL3Fad24xTExhalE2aDJnaUYz?= =?utf-8?B?R1lzT08vNGw1ME1iOTN3V1VxczZJaEZnNzVrQUVFeGpVeXdCdUQxeURrcnZP?= =?utf-8?B?eFgyNmsybFpqSUVDN1NVZ2ZmMDJMQ3AzbUU2YUdDb2JvN0pTV09TVFBrOGl3?= =?utf-8?B?dWx5V3JHaVpxM3VaeVpyMlZNdFVuaHlqVHM4RkhrN3ArVXdmVnNrK29Xb2JT?= =?utf-8?Q?D1jabgtX6Y8mEhnQaj52FEi74?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fdebf78-4f47-4dd2-6859-08da94dbbdb8 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 16:27:53.0417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sCUApgX3FoG4MnkgmeRFNZ5VUzRw26osGF2TfxbJiriEHCFy8j0waRuy4l4aNDdOvcuFvEJJips6uO3W2yJ+Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5721 Hi Michal, On 12/09/2022 12:59, Michal Orzel wrote: > This patch series introduces support to generate automatically passthrough > device trees using lopper. This feature should be used with care as the > corresponding lopper changes are still in an early support state. Current > integration has been tested with several devices from ZynqMP ZCU102 board > e.g. serial, spi, ahci, mmc. > > When using this feature, make sure to use the latest lopper's master branch > status [1]. I am guessing that this is the first time the imagebuilder is using script from an external repo. There might always be a possibility that future changes to lopper (master branch) might not be backward compatible or might break something in imagebuilder. As such, will it make things better if lopper is included as a gitsubmodule for imagebuilder. This way a specific revision of lopper will be in sync with a specific revision of imagebuilder. Please let me know your thoughts. - Ayan > > [1] https://github.com/devicetree-org/lopper > > Michal Orzel (2): > Refactor sanity_check_partial_dts > Add support for lopper to generate partial dts > > README.md | 22 ++++++++++-- > scripts/common | 73 +++++++++++++++++++++++++++++----------- > scripts/uboot-script-gen | 17 ++++++++-- > 3 files changed, 88 insertions(+), 24 deletions(-) > From xen-devel-bounces@lists.xenproject.org Mon Sep 12 16:29:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 16:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405933.648354 (Exim 4.92) (envelope-from ) id 1oXmJO-0001CY-Ih; Mon, 12 Sep 2022 16:29:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405933.648354; Mon, 12 Sep 2022 16:29:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmJO-0001CR-FW; Mon, 12 Sep 2022 16:29:30 +0000 Received: by outflank-mailman (input) for mailman id 405933; Mon, 12 Sep 2022 16:29:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmJM-0001CL-Oj for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 16:29:28 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2086.outbound.protection.outlook.com [40.107.237.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10f264cf-32b8-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 18:29:26 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM6PR12MB4233.namprd12.prod.outlook.com (2603:10b6:5:210::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 16:29:24 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 16:29:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10f264cf-32b8-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzpeJsejORs7XKBLR9b11tm7SU825oy4FZNbqg2P1317NKNarNgJB/2nQJxifD0mxCc1DSQ6TZMtyDi5oHMNDPdjWfBP1zWLyvzl9W22sP3bjQqqZqCaZKgp0ksI1itGs/kg/xfnrpWrQWNTWmd/k1PSOJ3E5qbw0OTi7O4VkV3mpolAR9Klf8ETIw9zv3w3NuCopWAcIwWlvCAtl7vQfqcEaTeTbuo9h0sMbA1WliNbgsUKN9QO44TRengQ3zZklry4YzWxyKV3POv3dQL9y9/yVBoLtbgILWxbelZ+na3lAhGGon27yF+ixCWApEFFq1F3QlcLqL1fxpn5/ECzwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2wupiBvB/i7/iWOS2GCbqaekWYjthsGjCEZevNiQLtE=; b=JallzdvnBRRXeYfk3wl7NSqa5Ph+aKSiYFBO7xQGYPksLoGktg65W62YBuUdN6Z8n2cOc11o7n4mfrG4bBaGYTMsxDciEn40P7XfV833hPY1+EHvz5kbu+5s4g9wUtuKhI8yLym826D/4XTtnxx4L4k3FJtZxc7lNs9ojfV1rpsDDUlegxi/v2IWQnyZ1PYVaJRzY8U2MS0PI4GoIvmDlAWnhw0yUQkEG6XeD7zKBH/rRosOoKw/swvXg4akvMdFw02U9/Yy8bTzRGgcpL91eq5LaHsi65UE+rJNKr0D93DnKICJjNRpC3ObGvTee8TpQXQqSYfGeeVxXuYGrHMDvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wupiBvB/i7/iWOS2GCbqaekWYjthsGjCEZevNiQLtE=; b=cUR4iNP1oJGKgegLvtSPITAtIzaUe/kk9lc1WPUSuDGOYR7lnvLSBpzUQqFEsLzv0ykGXGLVgoKBK4HG6KeYv2qyPIPfVaHzrkvADjVOtGj1aK4FzUszR4sNlHRK4h3I3ZgC+acw95Bk7/6zfBm60mm5y/Ztf58VVui3QU3O168= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <64edb22b-eda8-2274-004e-9a036a972614@amd.com> Date: Mon, 12 Sep 2022 17:29:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [ImageBuilder 1/2] Refactor sanity_check_partial_dts To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-2-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220912115934.19552-2-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0039.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::19) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4233:EE_ X-MS-Office365-Filtering-Correlation-Id: f25635d3-3eff-4d14-5e8e-08da94dbf429 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TRbYCbdm8tPFwamlJoE+js7aHYnvgq5xm3mc62/EO81TxTGNKBE/cCJbIIU/wkuj13HpqpLDVO0xuS/XUKmai2YhXW5eoDBti5aud5ynQ86zrZhYKSv6zXQFCSbnqDnUF+jdVgINJYMLRtE+DKofGhsPc01vbRnrD+16+pYEyrJVd4K8QIleXIBfVUeQbDq8vUdZPmyRxumyfZIV/AWz8ryXib7e4/DG5hZkhNXJvrTpupHlCezIWtR0vkCnnvMp3UaSbQmIDCnQLERQTIP8+rNwWFk0/rMS6VoE3384uWe1JIAKHS5WmGYCofobKn8iDSCRPIqBdFACcw3Oq5mv8K8XI91JqJ1jXRzXDArmD8HnYUqdD2Png2WJFaTKka3fPHBgM7u3LDYklSN5caULykLj3Il/RIq8fzXPCH29yJtDk0eMow1WPLRWuTRL2BVDFSRXLOFjwBc1486GhI9erUJRa88pJo+9lnnMsIl2g/edh80cHMv+gh5OaGQ18ZYy06ynIkSj8MSnijkSQ6XC2Dr7u0L8Xm5GpHMJR/+jaFWb+HYH6wLpXhyDKDoVmoNHO7dmkNM/wHGpSFYcGsNfqQzrRzM+1UdiZTTDhGZO0wKFhJTp3PvrbVNptPFHrcCkgAbwIXo7Fb5an2LtOe2DDWU+semc6OuulVYJ9lGHRN0l/dWut3ArzPd+FYo+RMX9rnuckHMG/dDUx8gCnQwNeXMPq2C77RWq6PTGPylfq6GaTJIxD/JazqdlDaEAjuNWwoFVjivv8z34CHAOwJzMx+QoVOQknDbdRD5g4R6EbXE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230017)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(2906002)(5660300002)(6486002)(8936002)(26005)(6506007)(6512007)(6666004)(53546011)(83380400001)(478600001)(41300700001)(2616005)(186003)(66946007)(38100700002)(36756003)(31686004)(31696002)(316002)(66556008)(8676002)(4326008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlFlc3J0UHhLRTJ4dmRGaXpLRlYyZ1BRR3NvYjJ0bHVqNHVxb2dla0hZSXUy?= =?utf-8?B?cHpRSWFvRkNSZkdwTFVHYjQzdEtwYlJCTGtNUllDMCs3RUROd3pGTUFuQzE4?= =?utf-8?B?M0xmVW1HRWdkNm52T3A1dHowSEJKV0Z5N1dLVHJ4QzExZ25WQzdMWTFuWmtH?= =?utf-8?B?c1g4ejZub0RUdC9vWjJ2LzVFaFJZWDhFYlZ3Wnp4TmtYaVd0WkNnL2xXZGlw?= =?utf-8?B?UkQybGtJMFJpUGNkM0dUMHorYy9KdFdwWjBnY0hidmt4Zld1OUVxSWt5RG9z?= =?utf-8?B?ekJ5OThzM01XUlhlOVBWbVZLSWRETHhySC9XeDQzcm43V1I3QVhtWjQvQWds?= =?utf-8?B?UVlybWRvZkhvYXg1OHZ6cEgzUDNBWVdxWWd1VjhTaGcvT2NvL1A3cktEY0kv?= =?utf-8?B?RHNWSzVCNDlpRmQ2MXVzUkZ3Y0dIU1BrRENhK2JtMU9ERmh0MnM5YmpmUUZV?= =?utf-8?B?dmxHK0RaekdGSUtLSnIvSDVISmcxazNJZEROY05DNE5LbjFoeDY1MlpzT1Fx?= =?utf-8?B?K0xoYUN4MWV2RFNNUStsVXM0WlREZmcxcERGdzBFSEFuRGpVV0JFUTQxWVAz?= =?utf-8?B?SENOK0VUNDRmTktiNEM4Zm5KcXhtYWErQ2lhTzJvbmZkNk5rR3NhRkJMTXhN?= =?utf-8?B?eS9uT0g2K3h4SWpIOHZMMmNZeHIxdGRXZytZNnUrUURTMEozMlkwbmdUSjJP?= =?utf-8?B?R3FlaktmcDRQNTF1a2RLZzgra2k3c2F0eHZQcndRWTBUcW9iclVsd2NteXV4?= =?utf-8?B?NWRRb0FMTElqMUp2WEY3SGN5dkpZUXFSczNaL2xhRnE2NFRIZUxGa2pCUFNL?= =?utf-8?B?bE5iQ3B1WUVPbFJyOEhvcmlwenlEUzhsUktURm1GVFdWWDFtU3d1eXp0UzQ4?= =?utf-8?B?ekVEMUFsYmxyU3VabGRTaWF4WTk2bVRCTDlZYS9nRmZsWFZDYlhMd3lmSjVX?= =?utf-8?B?WTFVMWVFZjNTWXZPU2pueXE0OHh6emJxOXdzNzVmWU9TTm50SHRuS0tmb2JV?= =?utf-8?B?Y0N5dWJ0M3hmNnNqUE9zU3RBNTEwU2dYbzRjeUV6cDVOaWtRNXlwaUNsUTNn?= =?utf-8?B?MnZqS2EvNjFoYjZ1d1pPa3ZKbktEa3pwMEh2dk5OYm5Fc29pRkFja2VYUXBF?= =?utf-8?B?QjNYb3djUlZMWXZ4R0Ewc2Zsdm1uNHk2WVdRV0diVVU4RTlEbDFXMmN0VWhM?= =?utf-8?B?RjdjTThxVi9PcktCbTExU1RyRDIvMGVCQkpuOEgycTBYaUZvTkdDakRVcGZW?= =?utf-8?B?bkhSVTRzRWJNSURZME1rTDVqZ2JxZnIxeEJLZWZIWDk1Nkx3Y2hOZENMTzdi?= =?utf-8?B?b1EwTE9sNnZ3ZnJkbEZObFdVN1BackVCS3NES2tRc3AvMkRDS0pkaTYya3hK?= =?utf-8?B?ZmpTd1VjMnhjUTNZMmRhQVJ2MmNEZEh1RmhjR2RtbVZTdmkrVW51aGp2allq?= =?utf-8?B?STF1dEdNQ0NaWnNXVHdqdkNoQnVrdjFvSXpPazJwTEhZZUR0MDZuc0NiSjIr?= =?utf-8?B?VXJ3VU1rS3pkTzJtVS9FM1pTY3F2ZG5JNElmclFnekF1WXkrYXU2Vi9qRG10?= =?utf-8?B?eGVQSktYdVV0KzBTUWlKUVV4STNleTNNc1JSUkl4enovbGFETmxzZ0p3Rm13?= =?utf-8?B?eERBNXZFc2FOMUxKbWtCcjR3dVFXM1lRZGVKaVY0b0xabzBoekRmK0lLbnhL?= =?utf-8?B?Q0dTMmZSY1IyMkdoVnFBSEJ6RUlXOXdEaDBFV2xTK3ArOU5aM3hHc1Exd0hr?= =?utf-8?B?am55Y2R3cmNFcEtucGptQUg1SjhnWWordExveDEzTmM4ZHpIOURDbEZXMWZC?= =?utf-8?B?S2krZnlEZnRJOWJScW9VQTRJeHdmbkhsYTlrbE1YNlFuRUhNaGJVRlVMUHpm?= =?utf-8?B?cmR6WXdrcWRtNk9KQmZJRHhwZE50VnVzNThvL1VCYzkrTzVFd0Q4dFVGU0NN?= =?utf-8?B?R1c3U3VlZ3pibklBY1dSbFRDUGdwcXVDWUhVdzUxTjdwRFZqdzk5eG0wMkpn?= =?utf-8?B?V0xxNU9UT1doTWNyQ2ZvVnZiZWNIMldVTStRZVc5cnNwU2p1MDIySGRuMWJ2?= =?utf-8?B?Q3htNDJWajU1MEh1WHpncE9vK1lnSWNQaERROFFCNUUwK1Y2cGNHbkdiT1ZP?= =?utf-8?Q?V7mjbMLDo4xAeDYTa4ICA4t9q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f25635d3-3eff-4d14-5e8e-08da94dbf429 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 16:29:24.3790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fOssjBDXDLAYr3pF5QAfjFR4h/jJdUy2X6m/ju174Mn3P2ZV/88hbGWYvYINI/uZ9xNcSDcsXlBSvZ23HsMzKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4233 On 12/09/2022 12:59, Michal Orzel wrote: > Currently function sanity_check_partial_dts from scripts/common takes > three arguments where the last two (repo, dir) are used always in > conjuction to form a path to a directory storing partial dts. Modify the > function to take only two arguments where the second one is to be a path > to a directory storing partial dts. This will help reusing this function > in the future to perform sanity checks on partial dts that do not > originate from a repository. > > Modify compile_merge_partial_dts to take this change into account. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder > --- > scripts/common | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/scripts/common b/scripts/common > index 25c041270c29..ccad03d82b30 100644 > --- a/scripts/common > +++ b/scripts/common > @@ -40,8 +40,7 @@ function get_next_phandle() > function sanity_check_partial_dts() > { > local domU_passthrough_path="$1" > - local repo="$2" > - local dir="$3" > + local partial_dts_dir="$2" > local address_cells_val > local size_cells_val > local tmpdtb > @@ -51,7 +50,7 @@ function sanity_check_partial_dts() > for devpath in $domU_passthrough_path > do > file=${devpath##*/} > - file="$repo"/"$dir"/"$file".dts > + file="$partial_dts_dir"/"$file".dts > > if ! test -f "$file" > then > @@ -96,6 +95,7 @@ function compile_merge_partial_dts() > local dtb_dir=$1 > local repo=$(echo "$2" | awk '{print $1}') > local dir=$(echo "$2" | awk '{print $2}') > + local partial_dts_dir > local tmp > local tmpdts > local file > @@ -123,6 +123,7 @@ function compile_merge_partial_dts() > dir="." > fi > > + partial_dts_dir="$repo"/"$dir" > i=0 > while test $i -lt $NUM_DOMUS > do > @@ -132,7 +133,7 @@ function compile_merge_partial_dts() > return 1 > fi > > - sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$repo" "$dir" > + sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" > if test $? -ne 0 > then > return 1 > @@ -146,7 +147,7 @@ function compile_merge_partial_dts() > for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} > do > file=${devpath##*/} > - file="$repo"/"$dir"/"$file".dts > + file="$partial_dts_dir"/"$file".dts > > # All the subsequent dts files should not have dts version mentioned > if test $j -gt 1 From xen-devel-bounces@lists.xenproject.org Mon Sep 12 16:41:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 16:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405943.648364 (Exim 4.92) (envelope-from ) id 1oXmVA-0003hD-L1; Mon, 12 Sep 2022 16:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405943.648364; Mon, 12 Sep 2022 16:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmVA-0003h6-IC; Mon, 12 Sep 2022 16:41:40 +0000 Received: by outflank-mailman (input) for mailman id 405943; Mon, 12 Sep 2022 16:41:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXmV9-0003h0-GR for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 16:41:39 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c45cf1bd-32b9-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 18:41:37 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BL0PR12MB4881.namprd12.prod.outlook.com (2603:10b6:208:1c7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Mon, 12 Sep 2022 16:41:34 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 16:41:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c45cf1bd-32b9-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnaZf5s3836ASX61JRso23FJAu3hzZ1J53SCl8yAcxIsrNOSOQcx19fLa7B1ijyAPiaHA56f7883Z3nQDYM2sW6xlGXXp0yP4dVKudPFqsZp2sEKbhdCRrr/ApQc3lF4zcs/AQVRHIwKT3xh84KzcSscTi7xxZXvZVhs7sDkCZaAYPJqiKQwwSSKXAqkwQlgcwZz1nsUsQY2L3MbYX1msArvOM9sHTGEgI9kSeaUJnDQIgnI6ApPCblsgaUkg2wvGpqwOthPILP8FHFXuhzGzjqVhT5NTLU7uBRtuji+PfLeolS5ebX6YykR4AXwUATT/taAi8M5sI4pVSqRLkXtWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BvdGQAgT8wcsWoOOAirWtXjeIJ1Wk2SHhu09KgIVbvs=; b=eOm94mW8jhczIVnK6Cxsu5Rz6q0LV5cT3ZdOPox6YOnKkAN/1bMH7W/f++iUmokh3pqFBnQhc4MdKJxjjdLe1iwQDfJwt+wQTYCV5CKUvqdLTb8CB3teR82o9JZJG3PjPkfjmA/4NSlscoi4Nuu+iCy0wGsNUlRPNZ/Fk2+bjGNWChvRcjgDM5HLuXOQW7lCcFL5cA4zv3tiNStLnXJTN015s5cCMJMYtrI7ymngu+ektRqYBgCNMr4klEYB1TihmwhfDkg97+O8vRycNKUN4mDt4LexMLVp3W0evYpQ3dU6tpkiCUI/LgizscPQOwvnfX5Fdg0ED8CmqWTnnvmejQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvdGQAgT8wcsWoOOAirWtXjeIJ1Wk2SHhu09KgIVbvs=; b=J7wp3fkx+e9iLA0P+JgwHtrvXg7CwI4XRHOhV7fsjn0Gtk96Bs5VMDUfoiIOqh2CYLE2faH54IXLXTsPqQi4dpqEKmwz8U3UtLAtMO2OLZ4LLwVRhxcMJutN5/ic2HTXwQ8Rlx/mkl2CVx/DbcIUVc102HxcpvLhiV5QGBe6Lbc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <276bd45d-7ab8-fc5d-a065-df6188b4f42f@amd.com> Date: Mon, 12 Sep 2022 17:41:28 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [ImageBuilder 2/2] Add support for lopper to generate partial dts To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-3-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220912115934.19552-3-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0044.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::32) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BL0PR12MB4881:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d479750-2b56-4ece-a4e3-08da94dda71f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WU2aru2OcFK3kfkHL6C3wbuwLrLiBBAoRqmevp0gjQrqI7UwiOQ3CcyH2lzl6wKPI7nfGinf2occ716MoTPZIL/82wkW1dz6Q39oUaKa4o+RoOiwqXHc4ujTIsk3mnmgAyBEjLk30jHpduAR+mGjhoGPe2hiQbP5nO5TqrUJ7FMuNll/If57EmMvnLqGLVHbK1J5XMiKbXdca4QmaGDzYfK9k+8SCa8az5xxj+AAYaD0JG25EF9Zqw7jiNAiKXQfqr68vTuxvtgfENEyNUBLAjMFRXRhm+X3iNqrhQLFxtwFvVKLNIU28fzWmxTJ9i1ztOlrxrhT7lLSXKGtLS7BCvBk3ATuUOzvChuDB4NZrWmtqF0UYRXBm1ZNambyA5AoUjFhOdhzd16Ypu/Wg64BhPW9L3sW9OzG/ZjnIYQ7x8n92a7ZKkay6CGQ1ud4SRPmMnRCeZ2Ivn3HyvwE/uPFQAsQmyenuY5fKkltARwz0OsSbHbAdpexBCx6UIVE4R4VOQNtQo6sir9twgjmJ7tQ/B83hoj7q3Nv+NntgdfU0OQ55NoynXtDPGcoXBrxAXdSrApJalhmF0uSJ99MZmby1kEvo+LTtsLcp/6P6kxwtcwlLBS590dalEepeCWlJ8AY0ubyX2UH9sSkwj8TLpbAPTusThGeD/+ky3Qia4nGcoH4GmVWHOx5yGAl0pd5YDaMMRd5UeLGMQPDgLUnCxt3FoOoQMcxES5febgoIFwxoO3olpUpcIUU/kC8KTza9GdJrCzbXO1NNS9ZelEdaXGyAfvqN/+EnH1z5Oh1MXjsEHjLbKxkJNRFLP0A8fjS20on X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230017)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(66476007)(4326008)(8676002)(66556008)(5660300002)(186003)(6506007)(478600001)(26005)(2616005)(53546011)(41300700001)(6512007)(6666004)(2906002)(6486002)(66946007)(83380400001)(316002)(31686004)(31696002)(8936002)(36756003)(38100700002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGd5bi9tVWlML0E5WUJaQ1NFS0NOK2ZtbzMwR3ErOVA1Q0xZZThXc3B2eGZi?= =?utf-8?B?OEpDSkl0TmtrL1NINDNFdkNmQlJxZGkxQ2VBVjh1N05WLzZXV0l6dFZPaGEz?= =?utf-8?B?ZW9nNGx6RzAxWXpTOFhqK3orVXROUUNIanNtNVFzZUJQNnE5b1UvY2tIWkdi?= =?utf-8?B?WHByVTkyU1J2aHA5T3RHNnFVeHBhMDNDZ3BzZmYvNFVwcUNkazZpbHEyZUo1?= =?utf-8?B?QWpqQjYyYm9BSkFCR0dneldINEJSUFU4WHNaRzZSZ0tHWVdzZFlhVUxHb1ZV?= =?utf-8?B?UlRQaGE5dXFVMDd4SzRjekpMZU9nVE90SjRNNWRQT1RKUkNXUkpnQUQ0S1ow?= =?utf-8?B?ZmVoVjBmUWpvcUlXMWk2d0pXQ29yMEFFOCtFWThIYjZUdkY1QlQycjF5OWZN?= =?utf-8?B?dDlyTUJqUEJpczZCUUVWWmh6RStvM2Fma2kwQkZTc1NORWZIOEFTRGY2WHNK?= =?utf-8?B?dS9WWU4vVmVUSllpQXFsWlFGNzlXYWZnZ1A4bmUrdDdQRDhoK3BtMEpmcnVz?= =?utf-8?B?SjAvaHB1ZzJ0elZkWk5kKzVFOGcwUzRvS1hQc3lMTURxMWxERWV1M0hiVkVQ?= =?utf-8?B?UUZOZ2hBQkovaE1qaVl2d2lhRm4zVGRVWlM2U2s4QVM1UW1nQ3lZUTZwaTRy?= =?utf-8?B?aGMrVTdTREtHRURIVEp4YnZ5WVQxYXZCQzNVakpvTW1PbkJaRExoSDl1QmFo?= =?utf-8?B?MEJYMTNNanRxTE9pc2FPc3huMVRDcmg1RTIwbnZxVjlCd25SNHpvU0UyS2Fo?= =?utf-8?B?QlE0YTBIS1lsL1RlTUZXRnRVdlplMnFNWThDTEFGWDNFVzA4dnlCMWg4MUh2?= =?utf-8?B?aUhwVTFBV211Z0VrRGtJQ3liK0ljRHk5dW9jbEN1THFWbEhRT280TURzUEZS?= =?utf-8?B?UGdjaHUyWldFejVUM2dob0hDSUVHOGYyamI3UEpHMm5KVFNyOVQxRFBiWHBt?= =?utf-8?B?a3I0emQwdHkxdHdYMXBuTEhpbVBDQVQ1dGhtOFYzU3BEMTdNMmNqOVdLOHRW?= =?utf-8?B?aExZUUpSczdlTkM2UE1CNFEvYyt2ZXpCbTdCSXAxL1JvQ0Z1WUsrUzdyTnlh?= =?utf-8?B?L2tJSW9lWnY2OG9OMVN6SHNHYS84d1h5K0p1dzRXOGk1SjRMRVgyU3hUMlFm?= =?utf-8?B?WjFTZGN1MnhwSDFmK2lBNnNPMStTeGpId1lrUFVSeWpta3pFUHBkV241Vk9P?= =?utf-8?B?czY0bzdiVDZoMVVXamN3MXVDcjZwQzh3RGl1UThuUWFpZjU4elpSZ1dRRlZ3?= =?utf-8?B?Ry9LM3cyTnU2bzd0dHBSOEZEK2VjOE5ENjQ5SEtyZTNWcS9SZXg4bDdNeE4x?= =?utf-8?B?Qm9XSzVwYU90dWtMZkRtUXZ6S1Z0RW55bUhlWWhtTnUzYWdaME1HM1FTUzVW?= =?utf-8?B?Uzh6VUg3dnFOWEpGTmx1V014K0NyZEVldmczL09GL2hwdnhKWGxzbm5FME5o?= =?utf-8?B?VEE3a1VGMjF2czNwS2ZMdzVtM1o4alN6QWNrK1EybUNkMyt0cjc2bWRFZlBP?= =?utf-8?B?eVRYWWF1b05BWlRaazlkNXNHR1BPNUdRbUpwUS9Ja2xUbWZ5U094ckhXbitl?= =?utf-8?B?SE1xSzR2UE9hcGp1bGRBTWl5Y0doRVplazdGVGlNSFRZdVphZ2k4Y3QrVk1R?= =?utf-8?B?b3FHOUozbGVOWEI2Rmx1YldYekdIbk5rZU03OEtXRkpybDJnbUEzdktydGZZ?= =?utf-8?B?dEVnKzZ2Wlp6U1JhWkZxYTNrVExUbno5aWt6V0VWOHo0dk5aN1JtQ0lLT1Bt?= =?utf-8?B?NHJWS24vRWh1NDZlRkcwQmFCZENkRnlIbFdIWC9jYXIyOVEvTldQYU1SZ1FM?= =?utf-8?B?UDlIaXM4ZkNyZnlsOWZIT1NzalFqUmh3ZzN5WVhxTXZEeStPTXlva3JmVE1C?= =?utf-8?B?aHpQbGxXaGxGS1p5L0hYT1crTjZDcUVBeVRrUkVZUllGVUlySlpkUTNuNGZj?= =?utf-8?B?YkIwMm5wQVlmVFpEbkJ0cFpFYWxSeVVRcEZrQ1dIa2N2V1dyVkxZNWk4UW1T?= =?utf-8?B?WHZicGZkMi8vWGtqc3FiQWU4bFNFWDJHQkQvL1ZQTTFhbnREMkZZMW9UUHRO?= =?utf-8?B?eGZsY3hJQnJkWkhIWHIxdW53amIvNDhPT3JCc0U0M3NydzllditJb09vNDdK?= =?utf-8?Q?i+rAJ34dTXmtjHuICfr89GrBO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d479750-2b56-4ece-a4e3-08da94dda71f X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 16:41:34.1242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RJWJqDzgbKhnGoYT9SqvvAqIKD11XLPqfesueDnJkT6dDpaVG+7A9C5Onf9zUgihKAB2k5PBSdhwiXExuMrnsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4881 Hi Michal, On 12/09/2022 12:59, Michal Orzel wrote: > Currently ImageBuilder can compile and merge partial dts obtained from > a repository specified using PASSTHROUGH_DTS_REPO. With the recent > changes done in the lopper, we can use it to generate partial dts > automatically (to some extent as this is still an early support). > > Introduce LOPPER_PATH option to specify a path to a lopper.py script, > that if set, will invoke lopper to generate partial dts for the > passthrough devices specified in DOMU_PASSTHROUGH_PATHS. > > Introduce LOPPER_CMD option to specify custom command line arguments > (if needed) for lopper's extract assist. > > Example usage: > LOPPER_PATH="/home/user/lopper/lopper.py" > DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" > > Signed-off-by: Michal Orzel > --- > README.md | 22 ++++++++++++-- > scripts/common | 64 ++++++++++++++++++++++++++++++---------- > scripts/uboot-script-gen | 17 +++++++++-- > 3 files changed, 83 insertions(+), 20 deletions(-) > > diff --git a/README.md b/README.md > index da9ba788a3bf..aaee0939b589 100644 > --- a/README.md > +++ b/README.md > @@ -128,6 +128,19 @@ Where: > - DT_OVERLAY[number] specifies the path to the hosts device tree overlays > to be added at boot time in u-boot > > +- LOPPER_PATH specifies the path to lopper.py script. This is optional. > + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need > + to be specified. uboot-script-gen will invoke lopper to generate the partial > + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. > + This option is currently in experimental state as the corresponding lopper > + changes are still in an early support state. > + > +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. > + This is optional and only applicable when LOPPER_PATH is specified. Only to be > + used to specify which nodes to include (using -i ) and which > + nodes/properties to exclude (using -x ). If not set at all, the default > + one is used applicable for ZynqMP MPSoC boards. You are using some more arguments (besides -x and -i) :- --permissive -f -- extract -t -- extract-xen -t $node -o It will be good to have some explaination for these. See my comments below. > + > - NUM_DOMUS specifies how many Dom0-less DomUs to load > > - DOMU_KERNEL[number] specifies the DomU kernel to use. > @@ -140,7 +153,7 @@ Where: > - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( > separated by spaces). It adds "xen,passthrough" to the corresponding > dtb nodes in xen device tree blob. > - This option is valid in the following two cases: > + This option is valid in the following cases: > > 1. When PASSTHROUGH_DTS_REPO is provided. > With this option, the partial device trees (corresponding to the > @@ -149,7 +162,12 @@ Where: > Note it assumes that the names of the partial device trees will match > to the names of the devices specified here. > > - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only > + 2. When LOPPER_PATH is provided. > + With this option, the partial device trees (corresponding to the > + passthrough devices) are generated by the lopper and then compiled and merged > + by ImageBuilder to be used as DOMU[number] device tree blob. > + > + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only > add "xen,passthrough" as mentioned before. > > - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees > diff --git a/scripts/common b/scripts/common > index ccad03d82b30..680c5090cd07 100644 > --- a/scripts/common > +++ b/scripts/common > @@ -9,6 +9,9 @@ > # - NUM_DOMUS > # - DOMU_PASSTHROUGH_PATHS > # - DOMU_PASSTHROUGH_DTB > +# - LOPPER_PATH > +# - LOPPER_CMD > +# - DEVICE_TREE > > tmp_files=() > tmp_dirs=() > @@ -99,31 +102,41 @@ function compile_merge_partial_dts() > local tmp > local tmpdts > local file > + local node > local i > local j > > - if [[ "$repo" =~ .*@.*:.* ]] > + if test "$repo" > then > - tmp=`mktemp -d` > - tmp_dirs+=($tmp) > - > - echo "Cloning git repo \"$git_repo\"" > - git clone "$repo" $tmp > - if test $? -ne 0 > + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO > + if [[ "$repo" =~ .*@.*:.* ]] > then > - echo "Error occurred while cloning \"$git_repo\"" > - return 1 > - fi > + tmp=`mktemp -d` > + tmp_dirs+=($tmp) > > - repo=$tmp > - fi > + echo "Cloning git repo \"$git_repo\"" > + git clone "$repo" $tmp > + if test $? -ne 0 > + then > + echo "Error occurred while cloning \"$git_repo\"" > + return 1 > + fi > > - if test -z "$dir" > - then > - dir="." > + repo=$tmp > + fi > + > + if test -z "$dir" > + then > + dir="." > + fi > + partial_dts_dir="$repo"/"$dir" > + else > + # Partial dts will be generated by the lopper > + tmp=`mktemp -d` > + tmp_dirs+=($tmp) > + partial_dts_dir="$tmp" > fi > > - partial_dts_dir="$repo"/"$dir" > i=0 > while test $i -lt $NUM_DOMUS > do > @@ -133,6 +146,25 @@ function compile_merge_partial_dts() > return 1 > fi > > + if test -z "$repo" > + then > + # Generate partial dts using lopper > + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} > + do > + node=${devpath##*/} > + file="$partial_dts_dir"/"$node".dts > + > + $LOPPER_PATH --permissive -f $DEVICE_TREE \ > + -- extract -t $devpath $LOPPER_CMD \ > + -- extract-xen -t $node -o $file See below comment. Applies here as well. > + > + if test $? -ne 0 > + then > + return 1 > + fi > + done > + fi > + > sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" > if test $? -ne 0 > then > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 1f8ab5ffd193..84a68d6bd0b0 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -1138,10 +1138,23 @@ fi > # tftp or move the files to a partition > cd "$uboot_dir" > > -if test "$PASSTHROUGH_DTS_REPO" > +# If both PASSTHROUGH_DTS_REPO and LOPPER_PATH options are specified, > +# the former takes precedence because the partial device trees are already > +# created (probably tested), hence the reliability is higher than using lopper. > +if test "$PASSTHROUGH_DTS_REPO" || test "$LOPPER_PATH" > then > output_dir=`mktemp -d "partial-dtbs-XXX"` > - compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" > + if test "$PASSTHROUGH_DTS_REPO" > + then > + compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" > + else > + if test -z "$LOPPER_CMD" > + then > + # Default for ZynqMP MPSoC > + LOPPER_CMD="-i zynqmp-firmware -x interrupt-controller -x pinctrl -x power-domains -x resets -x current-speed" It will be very useful, if you could provide the link to Lopper's README which explains the arguments used here, as a comment. Even better if you can provide some explaination (as a comment) to what the command intends to do here. - Ayan > + fi > + compile_merge_partial_dts $output_dir > + fi > if test $? -ne 0 > then > # Remove the output dir holding the partial dtbs in case of any error From xen-devel-bounces@lists.xenproject.org Mon Sep 12 17:41:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 17:41:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405960.648375 (Exim 4.92) (envelope-from ) id 1oXnQz-0002LW-0R; Mon, 12 Sep 2022 17:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405960.648375; Mon, 12 Sep 2022 17:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXnQy-0002LP-Tv; Mon, 12 Sep 2022 17:41:24 +0000 Received: by outflank-mailman (input) for mailman id 405960; Mon, 12 Sep 2022 17:41:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXnQx-0002LF-O1; Mon, 12 Sep 2022 17:41:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXnQx-0001uf-ML; Mon, 12 Sep 2022 17:41:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXnQx-00035w-FP; Mon, 12 Sep 2022 17:41:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXnQx-0007M6-Db; Mon, 12 Sep 2022 17:41:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y0OQuh3HZo6HmOLE2wLxCvaaXef6XFA/VH8KsMLfFso=; b=MnBVMOZQlZUyG7Z2TCelJTe8nd J3pcfyPtcqw0LE81qtPbLgCh2VJu/pM5PvliCPIkFYrWgEOj0+cAVspoDu9rSqH5jRGBT6rSRT4Bo GR2SDNSc0p4RNDYmnC61hcGuHE0SXPTnn7n88gTapHJdb5hYQZ3E4S+PNWcg9bp98uZs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173152: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 17:41:23 +0000 flight 173152 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173152/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 39 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 296 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 17:44:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 17:44:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405968.648387 (Exim 4.92) (envelope-from ) id 1oXnTT-0002vF-E5; Mon, 12 Sep 2022 17:43:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405968.648387; Mon, 12 Sep 2022 17:43:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXnTT-0002v8-BA; Mon, 12 Sep 2022 17:43:59 +0000 Received: by outflank-mailman (input) for mailman id 405968; Mon, 12 Sep 2022 17:43:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXnTR-0002um-MG for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 17:43:58 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2049.outbound.protection.outlook.com [40.107.93.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78530616-32c2-11ed-a31c-8f8a9ae3403f; Mon, 12 Sep 2022 19:43:55 +0200 (CEST) Received: from BN9PR03CA0619.namprd03.prod.outlook.com (2603:10b6:408:106::24) by BL1PR12MB5048.namprd12.prod.outlook.com (2603:10b6:208:30a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18; Mon, 12 Sep 2022 17:43:52 +0000 Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:408:106:cafe::63) by BN9PR03CA0619.outlook.office365.com (2603:10b6:408:106::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Mon, 12 Sep 2022 17:43:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Mon, 12 Sep 2022 17:43:51 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 12:43:51 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 12 Sep 2022 12:43:50 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78530616-32c2-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBlPLHXHJHrl9EBpprXzeetoJn6S8Xj08f3xhQ+Cw35p/+FosKK5fnUu6sX0VXsZsOulI7YGK0IYLoZYSkXq8HqUdxRwrJKRaxA5vMa2WF2K0CgX41Vu8Lpr1qK8ztEbZcK6xL1zP0Zhk8MNUPSQf8IBVQvcxD5ZuDA3Sig1d/OrIiw9Z8s4sm24Ld3TqDI+IZPYPIjYrbe4s60OaSINh3/ZqfttKtGj4X02fc5x96Sf7A4R6eGp5fvERznb154pFkEg1hSSYyxog7LhyGcBnjhfIayolHEqpsbQBPXx1phwhxgd3KSrcxrYa6OGBTQgEjjuldioIcZ9H2ZhDSWnxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOYYOT3vSza1B0X2L7tBDBT9w17kawbMA9QA06xg/KQ=; b=agYKtIA5jJ5ADBDUvN2ZqLdRzdS2oaDdokGnWsQ1XxBYm6/+sEGCeS0nVMm9eAemVBhZUvpv19i1r7xrlIYJdGFdKpm1LVClEQOnOKBnzSTe/KL1qcZpdsiS82k1MCWBXebhcyRrZ4dmoaMHz1oLuNks5g9ZdL3H521wzDZ9j+vhY6v9VbqO7VH1wKDt2sZU/IjHl0Y+Wwhejvrvznzne4GWcgOB14N3hm3OxBVHBfCVjy0JqQ8vXU3PEx9dY/fvKf0weY1/8bj05DIhv+cy4E+fwmhBC1FD+3bWZFcz1Kmf6utoj0r/C9JfM8u1dWHlq2Nuuf605T74ixci/oe58g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOYYOT3vSza1B0X2L7tBDBT9w17kawbMA9QA06xg/KQ=; b=aXeH/+FJWakms0fp3pVb3nUjVRQB26DEsp4v9kXTbjwTNRyl5NuICCj/sAvjH2nJRNnV0y5xpjvsis7/ltKJ/LVT6WM2TrtIUw2AuyOZ7HLnaiFn+dwThU9Trs8KF/3zFgY3mnq6vTtnzZJRN+HBZwlOrOVyTbMsblvIDiVY94g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Mon, 12 Sep 2022 19:43:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [ImageBuilder 2/2] Add support for lopper to generate partial dts To: Ayan Kumar Halder , CC: References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-3-michal.orzel@amd.com> <276bd45d-7ab8-fc5d-a065-df6188b4f42f@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <276bd45d-7ab8-fc5d-a065-df6188b4f42f@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT052:EE_|BL1PR12MB5048:EE_ X-MS-Office365-Filtering-Correlation-Id: d658c294-0dfb-4669-8e55-08da94e65b1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AvYVTJfYCLYfVFnxgYl2jo28SjmdEVgrYy314BUoTmcDjxNh0tGTQMpviMEOtHvHglo5ChPiRPUPJUTtX2X66koOBTA/A1CNtgyb5lD9xPBXjujOZohgm1irqqNjGAg8W87S7RQPTZ+F+waVk4Z8H2107pX25K0CQcWiRRBPXDl4hTV+RpbZOCN4Gjef/MrOevLUNYo6rKCkCCigTkJ6fvyISGcvNOffF48IhxZFktyaAXsavz3/GOKn6w2aQmC++Y/sGYj8RX/lrdd2Wi3At7D3ZD+KKGQ23JtLQAtLpsctJeR8Az3Y05ulvJRZOCjOYQLlKX4EjnF3XCtYgjNbNKk0FzzutxIewXyAHjMsVEF4dTmyZZz6ieWi950QPeCAYKawYSi2TPIf7h6El180B04mmWYMcOjjh7GOdAKKTKUjchoPp5NotQMiS9CxeeesfCtdqYUU+lzTl1KjDXkbjKN4QGbUR5uvnjbjM8/7Z2fXkCC9/D39v17unDv4/7RADMbPZ6cpWNapPuKyWeS/XS58+ptBQZJMdMAh/S5qnPnntf0LWITIBsIOEHPKGoHJAlkrXg9PsIBd7Z/xpFG4Do1+YyT/gHcyHAam0kw6WTKzztg+ngN047EwJer2CR2AI+J/fpTGcyX+OfnrF+pYg3MmUty29Ofuhj6s3kZW2ZqgObnsRSI0okV1CuUERc9/qD3j+RMcqkS6150OdgWUemT67KOJI/68wzOA0OXFYIFyBjKQq5+QCIIVEz3/ATPesIYdRUDkpXCNv8A3A7AtE2qYjg3/u5sRs+D6X2mrDU2OdpEciDFdAU7k91sbZzmPkPslMzu4BzIUVy3uv+RxkD5ypYjJMMZkDYJhd71wCAk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(16576012)(316002)(31696002)(82310400005)(40480700001)(81166007)(41300700001)(26005)(36860700001)(110136005)(8676002)(86362001)(70586007)(36756003)(53546011)(356005)(336012)(478600001)(2616005)(47076005)(186003)(44832011)(40460700003)(8936002)(31686004)(426003)(83380400001)(4326008)(70206006)(82740400003)(5660300002)(2906002)(21314003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 17:43:51.7643 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d658c294-0dfb-4669-8e55-08da94e65b1b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5048 Hi Ayan, On 12/09/2022 18:41, Ayan Kumar Halder wrote: > Hi Michal, > > On 12/09/2022 12:59, Michal Orzel wrote: >> Currently ImageBuilder can compile and merge partial dts obtained from >> a repository specified using PASSTHROUGH_DTS_REPO. With the recent >> changes done in the lopper, we can use it to generate partial dts >> automatically (to some extent as this is still an early support). >> >> Introduce LOPPER_PATH option to specify a path to a lopper.py script, >> that if set, will invoke lopper to generate partial dts for the >> passthrough devices specified in DOMU_PASSTHROUGH_PATHS. >> >> Introduce LOPPER_CMD option to specify custom command line arguments >> (if needed) for lopper's extract assist. >> >> Example usage: >> LOPPER_PATH="/home/user/lopper/lopper.py" >> DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" >> >> Signed-off-by: Michal Orzel >> --- >> README.md | 22 ++++++++++++-- >> scripts/common | 64 ++++++++++++++++++++++++++++++---------- >> scripts/uboot-script-gen | 17 +++++++++-- >> 3 files changed, 83 insertions(+), 20 deletions(-) >> >> diff --git a/README.md b/README.md >> index da9ba788a3bf..aaee0939b589 100644 >> --- a/README.md >> +++ b/README.md >> @@ -128,6 +128,19 @@ Where: >> - DT_OVERLAY[number] specifies the path to the hosts device tree overlays >> to be added at boot time in u-boot >> >> +- LOPPER_PATH specifies the path to lopper.py script. This is optional. >> + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need >> + to be specified. uboot-script-gen will invoke lopper to generate the partial >> + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. >> + This option is currently in experimental state as the corresponding lopper >> + changes are still in an early support state. >> + >> +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. >> + This is optional and only applicable when LOPPER_PATH is specified. Only to be >> + used to specify which nodes to include (using -i ) and which >> + nodes/properties to exclude (using -x ). If not set at all, the default >> + one is used applicable for ZynqMP MPSoC boards. > > You are using some more arguments (besides -x and -i) :- > > --permissive -f > -- extract -t > -- extract-xen -t $node -o These ones are fixed and do not differ depending on the type of device or board. That is why LOPPER_CMD is used only to allow users to specify what can be required to support a new device (usually not necessary) or a new board. > > It will be good to have some explaination for these. See my comments below. > We don't seem to do it in general (see all the commands used by disk_image) so I think we should only describe what is available to the user. Otherwise we would need to be consistent and apply this rule to all the other places. >> + >> - NUM_DOMUS specifies how many Dom0-less DomUs to load >> >> - DOMU_KERNEL[number] specifies the DomU kernel to use. >> @@ -140,7 +153,7 @@ Where: >> - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( >> separated by spaces). It adds "xen,passthrough" to the corresponding >> dtb nodes in xen device tree blob. >> - This option is valid in the following two cases: >> + This option is valid in the following cases: >> >> 1. When PASSTHROUGH_DTS_REPO is provided. >> With this option, the partial device trees (corresponding to the >> @@ -149,7 +162,12 @@ Where: >> Note it assumes that the names of the partial device trees will match >> to the names of the devices specified here. >> >> - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only >> + 2. When LOPPER_PATH is provided. >> + With this option, the partial device trees (corresponding to the >> + passthrough devices) are generated by the lopper and then compiled and merged >> + by ImageBuilder to be used as DOMU[number] device tree blob. >> + >> + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only >> add "xen,passthrough" as mentioned before. >> >> - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees >> diff --git a/scripts/common b/scripts/common >> index ccad03d82b30..680c5090cd07 100644 >> --- a/scripts/common >> +++ b/scripts/common >> @@ -9,6 +9,9 @@ >> # - NUM_DOMUS >> # - DOMU_PASSTHROUGH_PATHS >> # - DOMU_PASSTHROUGH_DTB >> +# - LOPPER_PATH >> +# - LOPPER_CMD >> +# - DEVICE_TREE >> >> tmp_files=() >> tmp_dirs=() >> @@ -99,31 +102,41 @@ function compile_merge_partial_dts() >> local tmp >> local tmpdts >> local file >> + local node >> local i >> local j >> >> - if [[ "$repo" =~ .*@.*:.* ]] >> + if test "$repo" >> then >> - tmp=`mktemp -d` >> - tmp_dirs+=($tmp) >> - >> - echo "Cloning git repo \"$git_repo\"" >> - git clone "$repo" $tmp >> - if test $? -ne 0 >> + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO >> + if [[ "$repo" =~ .*@.*:.* ]] >> then >> - echo "Error occurred while cloning \"$git_repo\"" >> - return 1 >> - fi >> + tmp=`mktemp -d` >> + tmp_dirs+=($tmp) >> >> - repo=$tmp >> - fi >> + echo "Cloning git repo \"$git_repo\"" >> + git clone "$repo" $tmp >> + if test $? -ne 0 >> + then >> + echo "Error occurred while cloning \"$git_repo\"" >> + return 1 >> + fi >> >> - if test -z "$dir" >> - then >> - dir="." >> + repo=$tmp >> + fi >> + >> + if test -z "$dir" >> + then >> + dir="." >> + fi >> + partial_dts_dir="$repo"/"$dir" >> + else >> + # Partial dts will be generated by the lopper >> + tmp=`mktemp -d` >> + tmp_dirs+=($tmp) >> + partial_dts_dir="$tmp" >> fi >> >> - partial_dts_dir="$repo"/"$dir" >> i=0 >> while test $i -lt $NUM_DOMUS >> do >> @@ -133,6 +146,25 @@ function compile_merge_partial_dts() >> return 1 >> fi >> >> + if test -z "$repo" >> + then >> + # Generate partial dts using lopper >> + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} >> + do >> + node=${devpath##*/} >> + file="$partial_dts_dir"/"$node".dts >> + >> + $LOPPER_PATH --permissive -f $DEVICE_TREE \ >> + -- extract -t $devpath $LOPPER_CMD \ >> + -- extract-xen -t $node -o $file > See below comment. Applies here as well. >> + >> + if test $? -ne 0 >> + then >> + return 1 >> + fi >> + done >> + fi >> + >> sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" >> if test $? -ne 0 >> then >> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen >> index 1f8ab5ffd193..84a68d6bd0b0 100755 >> --- a/scripts/uboot-script-gen >> +++ b/scripts/uboot-script-gen >> @@ -1138,10 +1138,23 @@ fi >> # tftp or move the files to a partition >> cd "$uboot_dir" >> >> -if test "$PASSTHROUGH_DTS_REPO" >> +# If both PASSTHROUGH_DTS_REPO and LOPPER_PATH options are specified, >> +# the former takes precedence because the partial device trees are already >> +# created (probably tested), hence the reliability is higher than using lopper. >> +if test "$PASSTHROUGH_DTS_REPO" || test "$LOPPER_PATH" >> then >> output_dir=`mktemp -d "partial-dtbs-XXX"` >> - compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" >> + if test "$PASSTHROUGH_DTS_REPO" >> + then >> + compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" >> + else >> + if test -z "$LOPPER_CMD" >> + then >> + # Default for ZynqMP MPSoC >> + LOPPER_CMD="-i zynqmp-firmware -x interrupt-controller -x pinctrl -x power-domains -x resets -x current-speed" > > It will be very useful, if you could provide the link to Lopper's README > which explains the arguments used here, as a comment. > This lopper feature is still in an early state, hence there is no such information in the README. I described everything a user can change (like -i and -x option) using the information from the extract's help. > Even better if you can provide some explaination (as a comment) to what > the command intends to do here > > - Ayan > >> + fi >> + compile_merge_partial_dts $output_dir >> + fi >> if test $? -ne 0 >> then >> # Remove the output dir holding the partial dtbs in case of any error ~Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 12 19:48:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 19:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.405981.648404 (Exim 4.92) (envelope-from ) id 1oXpPF-00084p-K0; Mon, 12 Sep 2022 19:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 405981.648404; Mon, 12 Sep 2022 19:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpPF-00084i-HB; Mon, 12 Sep 2022 19:47:45 +0000 Received: by outflank-mailman (input) for mailman id 405981; Mon, 12 Sep 2022 19:47:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpPD-00084c-Oq for xen-devel@lists.xenproject.org; Mon, 12 Sep 2022 19:47:43 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1e9879c-32d3-11ed-9760-273f2230c3a0; Mon, 12 Sep 2022 21:47:41 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Sep 2022 15:47:30 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Mon, 12 Sep 2022 19:47:28 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::50e5:dec2:1f40:9648]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::50e5:dec2:1f40:9648%8]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 19:47:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1e9879c-32d3-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663012061; h=from:to:cc:subject:date:message-id:mime-version; bh=bY0AwzqlLfSbKGt0BwLOt6a0h0Eho4PZJppQMciLUmk=; b=RQF6QjLyMz68lumzloTo2zhvKm6r8kltxQkHUAx5lKgCcUdMiI6SRpMl rubT1qRRNteCGNV2NrkeuKvw70jqWbAkfMUcf2LDkcNsMCfdoUQ5pQcPT aeaowDgtDrg+1GCPXAoeHTI7oRVDm4rnBnuhxD7VCjEx9lWyZYoUdyvsb w=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 79491391 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FO1BfKhUUGp5DY9sksCL171mX1617REKZh0ujC45NGQN5FlGYwSy9 lOraxnFY6jUMyawOYxoOc7lxf41ycKHmIJkSQpr+3s2EH8Q+caZW4+VcRv5MinPc5STQEtp5 ZVGN4acIZA4FHOF/hqkPLS5p3Aii6yFGeDyVLGYNi0ZqWOIMMsEoUsLd7kR3t446TTAPz6wh D/SnyH+EAP81mEoajhK4f+Jpho0sqWs4mNC71ZkPakX4VKCyXVEXc4Tfa2/ESD1E9JedgKYq 0cv710bEkfxpUpF5gaNy+6jGqEyaueOe1LI0hK6YoD66jBavCs+z60nA/QVbEZTml2hkst4j d5ArvRccy9wVkH3sLlbAkIw/x1WZ/UcoueWeCLn6KR/8mWdG5fS66Q2ZK0JFdVwFtZfWQlm6 fEeITYRWRGP78reLGWTE7QEamwLdaEHDatH0p1S5Wix4cUOGPgvd57i995AtArcs+gVdRroi 2j1XhI0BPjIS0Un1l76k/vSls/w7pX0W2UwRF54OcPbSoUcpeB8+OGFDTbbRjCFbe9Ol2Kim Vv4xCfkEggoN/Ofihyn1H3504cjnQujMG4TPJuR06cwxXisnCkUAhBQUkanq/6kjEL4Q8hYN 0Ef5ispq+416VCvSd7+GRa/pRZovDZFA4YWT7J8tl/LlvG8DwWxXwDoShZuZds8u8JwaSEs0 laRt9joGSZuoPueTnf1GrK88mLuaHFOfDZqiSksagEo4t/mh40PpT31U9l9MI2FqOyqMGSlq 9yNhG1k71kJtuYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPAwVXb5OxFK4CxSliHo WgKnNWY4OkSDJaL0iuXT40w8KqB4v+ENHjZngRpFpx4rTC1oSb/JsZX/S10I1pvPoAcYzj1b UTPuARXophOIH+taqwxaIW0Yyg38ZXd+R3efqi8RrJzjlJZLWdrIAkGiZas4l3Q IronPort-HdrOrdr: A9a23:wfnpBqGRdkGJF/rspLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.93,310,1654574400"; d="asc'?scan'208";a="79491391" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z5DKnACBtqxr0miOZVaR2g+ClH1KDRVUfpa5ObAAujmW+M0s1ZaiWcPEEU3H6q1bPejCsl6u/PbfCkSd/YepT79yL49S6yp00lYhDldAMGaZd9xJvdOz6T7jNmrzdhLuTaAjvf3NJ74fWiU3gW6ApSNE8CQf836+VAlFwxUWNUu9Am96Jba6xJ8p8fmfYOQLR76+OG/oJQh/y7PYAmlaN3g0REXxohPRi3sfD2HmyjHnkUBsOy1Bo4OMs06ew37tugVeMkRW0o13D2Rfjc0FijfZPB88gUbkENqFJlQAV8533KxG7HvFsIbC5zcND3n0t7gRG0w2+lG2w565QDjnfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lXVFlcYr7FyE/XNnczWoykhCdjkLdF3Jay4ntLb4a24=; b=hiT6uic1YTQYPGa8AJk++RNZmGPhSXpzGnJfUa1s4DuR1u8ZQIEbC3a2kul4BMaOBFq6Ua+F11YjbBgIebfkrgeJYV4eLbqA0LfrETHi/bIg9NuSFI1nFmTSYgsFU2g66m2YiYiMOBAoD5fuxPbEzLAbQMyoRFbrLflKuny52mPk38cr6ftCbjGF8z72JfCFL3kRd03nneU0eYI8ESS6GZUbofdL3yGnNiC6RaEsZpDQjkjzOGJ05Uy0+4iKlOkL/A7B3VoLF9a0mE3qkf43eW1ROrBxsCQBJlTZtpFVuGYIieizlMPq91wFS4MGOTQz22i/rGfg3sU3Ha8pr9d2ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lXVFlcYr7FyE/XNnczWoykhCdjkLdF3Jay4ntLb4a24=; b=pbaINygjap6mXHXWsfJiGokz/1fxWAEJ2CtHpaVIxp6D2hn3jiwPDJrFiBkoIMnEKbXhMsGHOy5bcJ6qNJemqHSpsIGN/5OFJSvcdNWfWH/WnUkQmfNIYXNNSyqc/ItkTPo6C3RDz4tYnAhvMlEemZRzoHzs2GMNKjLFiP1HoIQ= From: George Dunlap To: Xen-devel CC: Evi Harmon Subject: POLL: Xen Summit and the Queen's Funeral Thread-Topic: POLL: Xen Summit and the Queen's Funeral Thread-Index: AQHYxuB8XGNckV6WvUCHiUEdqxOGyg== Date: Mon, 12 Sep 2022 19:47:27 +0000 Message-ID: <07D52A28-6A30-450C-9343-D8388F5AAF54@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|SA0PR03MB5610:EE_ x-ms-office365-filtering-correlation-id: 691a9743-911b-42bf-369e-08da94f79f79 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IaA5ewAIRIxiGZs1whLwMFQ/Tz0mC4gHslHVWY3VbXs7OV1lSUmr7xgy9+aHFBP8ySgNGWEE36tNbh3ADP6KAv50nGB9ZkGJmHAZAMrywXwlvzyUZZnW5OQRQe9Wxq+sTmD8T7fRlWXLcz1haCO3LbExxlx29BFqPpsEzE/kyzarwP4zDjnL+YwE7jVBV59htvAqoaxsbrAvHFS5UUGf9gI4Y+wTu3R13NSr130rL3LmORgl/JEvoR3vc4RCR7I6YAhYihLlejU1yZUXvU02B4T6mUGhdt4xh6wXKkvbKfghrE6dcSLZ2qYAUFKPyzxwc0gyyzehw2+DweJoidFuhhDSfi1qjdAKtHMnhfUf2/24USo5tNBqBsaZxhx8aqAivoJFFMvaGOWJ90sS5JgnW8zZEmftrSd3gDw57kdbpmjQ8KCAIL4SMkouMud8L9fQp2b+5YEcHBJE9+S/7oLp7A/2M2ZXfZAGsP8Y8M6igsnZVO2T5B4iSjlENKCfB0MQTC3vmZAgFKxirBKMZTwd5doOASCqtKQVYU8Jy0yR+ThUWDBaaTDOO4/DklRWvHCrmAHDPN9ZPwcBkzm+XYnA8ZFXVS496q0tpoyMA6rZzF7N7AZ91gX3JsM3eVrePqyAPTj0WyMUQuKLvyrAd74oiZ5/mN5GibQIZAIWeKZHnw65pRlxhlsr8CaTr65ZD5zw1Ic7mNBHmeXyKa8kSrDzNR0Qgv1x5BsGIwKnkCmVOUxBGd0njp0jmuksP5bscZEb5MorGEaW78ZgPyq5NZu59b94JsuUMLUNGdiWe3FcAlMxkdbJ79y4xc6dMj7GOgmgFBWjJq8WCU356QRiJ5ZqQQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(6506007)(99936003)(316002)(66476007)(6916009)(66556008)(41300700001)(66946007)(38070700005)(76116006)(36756003)(2616005)(66446008)(71200400001)(6512007)(122000001)(4326008)(6486002)(478600001)(8936002)(2906002)(966005)(5660300002)(86362001)(91956017)(64756008)(38100700002)(8676002)(33656002)(186003)(26005)(82960400001)(83380400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MytHQVRZVFNEZWpUeG1od1JVUXFmS1VGZXcwdmFRMzFEcWVpQUMwaUtCenEw?= =?utf-8?B?UGowdnd0TXdRNHlwcE4wWVJ2NEJ6UlRiQTRWVkk0L01mV29qTVhHaTF6S3By?= =?utf-8?B?L3RXOUFwbXk5VGNqTlYzbnJjUUtRakI4VjN5clk5ZnFCWEk1cklsVUdQTkky?= =?utf-8?B?aVNuUTYxamRkQlRtb29yc1dka1AyREN6S3BjYURKYkVwaC9MSVpoSS9wN1ph?= =?utf-8?B?ak12QjlWSHhsTGpxcE1kMjlHMGNuZnBpNUtJNzZUaVVONUZLMTZHVFRweWQv?= =?utf-8?B?ZmM4cXRlN1pqcm5hNkZEb05yU2tIQUxWUzhsc2NpUmtTbFJFTlhWU3FZMktx?= =?utf-8?B?OXhjY2Z2Q0IvU0FJNEZ4ZHBwRFlGZVJhSXUrWE5GNFpkNjVmUWxxYU1ma051?= =?utf-8?B?Y0N5djBKcnRnK2h5bSt6aGFkTlhwOGd4UnRMUStzTVM3N0dnUVNaMWJWSE5M?= =?utf-8?B?VjV2V1lYZVVrL2JwWGlqeTNlTitWOGY3cTB1RW9lMDFwQUZGVVVvaHo1dFZo?= =?utf-8?B?OEMyR05qOXhnSFhpSUFtSEY2Qm1OTkFpcUJnYUJMZ0FQMER3SUtFUHhUVVI1?= =?utf-8?B?R1N4dm5DREtsSCtTZng1MkQ2QmhrRm9DblFCWXY2OUhTamc1OTJFaCtwTWZ2?= =?utf-8?B?MXUxWVp1T05UdU9zTDlFVy9nQTU4Tm5xd2Z6UTBiTkZDdTZWeVp1b0VuRzF5?= =?utf-8?B?TEJvMURJTVRxWTNQTUdVaG1MTWxqeXUwbXR0ODdmMnYwOGJ4YjV2dHZsNDNJ?= =?utf-8?B?UkI3Sm5LWk94empnS09zc01PRk1sTjVRZ1FEYncrSHVmQ3duTFV6VHRzUkJP?= =?utf-8?B?aGpFVWg1Y0JWQ1c3U3FoVHpYbkVnWjVkeFZrRzhHUStmWHdnTS9PU2xvVXo5?= =?utf-8?B?WENBWVJJaGhiZjVmTTlGR1NWMW54aGxUVVpiZlg2clFEdlY0WERZdEk1Um1I?= =?utf-8?B?MEd3dDVoSzJ3aWkwZmtGeU5pZkdpeEl2RzFiT25hSzlYRnloVm53WW9vOHdk?= =?utf-8?B?N3o3RWxEbTgrb1h0ck5pU0NuNERSMG9yWXgzQzRETllIOXZwdnNDUEdITFFk?= =?utf-8?B?alBkMkNLS2RCUnFnNjZxeTkxMmRLcXZxdG16eWN5dmZTN3FrU3ZYMUJPTEE1?= =?utf-8?B?d1IwY2xmc0JIMW1NNU1TUW9tTGpqMVdhSzlPUmxMOW1ic2VMWkIzd1NGejg1?= =?utf-8?B?Q3lObGZzRG9VYXJJN3hMT3ZCaExWYVdKY2ZPR2JIS0dnMmZjSWtFY1RZQlNU?= =?utf-8?B?a0VxSk9BMlFIc09SM3plMmw5QnFiSGU4cmJGU3ZFQytoRHNnY01yS25ZZlU0?= =?utf-8?B?eERTSElFZTVkOTRBNCtvL3F1eDNrSlM3OEhwTCtjREdXVklYN3ltYTFIT3Ja?= =?utf-8?B?MjROeSt1SUYrOHFPWWxjaDNZblFVdnJFUXlTVnh6MDVFZ3pyUE91OVkyYUYy?= =?utf-8?B?RG9qdDVrRVh5c1ZVUElIRmhBc2ZyR3hnSUQ0djhpZFRBZk1RU2N5SVlhNFhV?= =?utf-8?B?aG9ZeklhUUEyVDFxYzBYOXl3RUxEbmRhMHZCcUxHdVRNTUJjZ1p1N0hvcnlS?= =?utf-8?B?Qy9xRUNnOENLeWIwMDZLZkZpK1hJbU1JT1FMc3NHc0EzcVI1cDJYeDNrcko0?= =?utf-8?B?TEs4ZUNDVHVyMzZ1MktldmQvM0p0UENoUDE3M2dlUnF6bWlUVHUwNkxOc0l1?= =?utf-8?B?YzJCQ2xYWXNRVFRqQ2tZQnJwTXZCQUhBd015ajIxTTdHRXRxNmZlNzBuTWVD?= =?utf-8?B?NmFGV0REM3BhcFlBU21OM2xXNEpOYVBjWko1WElBMnVBeU9KcjdOWFBFaC9u?= =?utf-8?B?M3ZMZnNaT0pqbTJtRm1meVdGZnNsVldBcVcwQjlEdUhZRXVJcEgySnpPSnk4?= =?utf-8?B?WDFVeVE2QVk4VlMrZkNCbkt2alRoUUFGWGhrTml0WmRLWnV1RURUVWkyQllk?= =?utf-8?B?L3JkQloyYnlNL1hJWmlWTDBLV0l3am14U09zOGprQXRyOTU5MGhkbGI3enhT?= =?utf-8?B?WDUxdkFmUE1QN0xUelc4VFduUjdzS1IyTk82c0ZwektyYWxVTG1PUllOL0dG?= =?utf-8?B?Y2o2VWJmeTIvbEZsenkzbEhhbjl6QVp6eVoxYlh5WEFLZWxERWhBaUlNMkYx?= =?utf-8?B?clNSMjg0N3VzVHNoOFhkRHZJNlNMTThaeWloaHJjRmpjNStWZ2NUTlA3d3lr?= =?utf-8?B?akE9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_A265FD68-C96F-4622-AB7A-13CA55A25E5C"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 691a9743-911b-42bf-369e-08da94f79f79 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2022 19:47:27.9231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nFWCyOtFnd5Jwp1iyf9zzQq7MfkQoNCJ9H6dt5K+m/Xo4SI8r5/yRTTdWmT+Tqc9EqfxntjyCAlwnSdiV+GVt5gQYSY/FwUhfCkiKm5l+uE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5610 --Apple-Mail=_A265FD68-C96F-4622-AB7A-13CA55A25E5C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 EXECUTIVE SUMMARY Due to the Queen=E2=80=99s funeral, the first day of the Xen Summit (19 = September) is now going to be a public holiday in the UK. We=E2=80=99re = trying to figure out what the best option is (detailed below). *If and only if* you are attending Xen Summit, please fill out the = following poll before Wednesday midnight: = https://cryptpad.fr/form/#/2/form/view/w8pI8KNpo9gxXSdUc0BwbvKiowzM8aL8ZBo= n7rrXf5U/ You don=E2=80=99t have to give your name, but if you do it will give us = some confidence that there hasn=E2=80=99t been =E2=80=9Cballot-stuffing=E2= =80=9D. THE SITUATION * The State Funeral for HM Queen Elizabeth II will be on Monday, 19 Sep. = It will also be a public holiday; so normal office workers in the UK = (such as those at Amazon, Citrix, and ARM) would normally have the day = off. * Official government guidance says: "There is no obligation to cancel = or postpone events and sporting fixtures, or close entertainment venues = during the National Mourning period. This is at the discretion of = individual organisations. As a mark of respect, organisations might wish = to consider cancelling or postponing events or closing venues on the day = of the State Funeral. They are under no obligation to do so and this is = entirely at the discretion of individual organisations.=E2=80=9D [1] * The Amazon offices will likely be open, but one of the conditions of = the event was to have a 6:1 ratio of external attendees to Amazon = employees. Additionally, the facilities manager wants to minimize the = number of people working that day. * We=E2=80=99ve already mostly consolidated the schedule into 3 days, = with a 4th day for =E2=80=9CHackathon / Extra discussions=E2=80=9D * Many people from outside the country will already have booked travel = to the UK to arrive on Sunday evening or Monday morning. It will be a = =E2=80=9Cnormal=E2=80=9D working day for them: they may not feel = comfortable taking it as a day to be a tourist, and working from a hotel = isn=E2=80=99t very nice. As far as I can tell, we have the following possible options: 1. Leave the schedule unchanged. This would require all the UK attendees = =E2=80=94 in particular the Amazon employees =E2=80=94 to =E2=80=9Cwork=E2= =80=9D on what would otherwise be a bank holiday. (Or alternately, would = require arranging at short notice to suspend the 6:1 ratio.) There=E2=80=99s also 1a: Leave the schedule unchanged, but get rid of = the physical component on Monday. We=E2=80=99d always intended the talks = to be virtual-first; we could just make it virtual-only. 2. Shift the schedule, so that the talks are on Tuesday, and Weds / = Thurs are the primary design session days. This has two flavors: 2a: Shift the schedule, and leave Monday empty. This means we don=E2=80=99= t have to worry at all about the 6:1 ratio; however, it=E2=80=99s not = great for people who will have travelled here from abroad, and may have = to work from their hotel rooms (or just take the day off). 2b: Shift the schedule, and make Monday an =E2=80=9CHackathon / = optional=E2=80=9D day: Open up the space for people who=E2=80=99ve = travelled from abroad, but hold no other events. This would still = require at least a few Amazon people to be willing to work, but the = number would be greatly reduced. (Or alternately, it would require the = 6:1 requirement to be relaxed, but this might be much easier with the = lower number of people.) There have been arguments both ways; please give your thoughts, as well = as specific ways in which each decision may affect you. NB that not all = options may be feasible. Thank you for your patience and flexibility as we deal with this = unprecedented event. Peace, -George Dunlap [1] = https://www.gov.uk/government/publications/the-demise-of-her-majesty-queen= -elizabeth-ii-national-mourning-guidance/the-demise-of-her-majesty-queen-e= lizabeth-ii-national-mourning-guidance --Apple-Mail=_A265FD68-C96F-4622-AB7A-13CA55A25E5C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmMfjM4ACgkQshXHp8eE G+1JTwf+L6O4qVBff1tNmMrddtByFkjhvSxKcYiHGvutz/CBeQmKUKAy7Ge0/5up 1IgScAhSpS7KGTu6KYl+v87xYx9MUK8V09FtZGn1xfh6+iTGg+xM5GwfH3ecA+vr er/rnCvrVGUp+8gJbVkZp3rQopyMZVe0n/NFt7V64IqZN0PIfHdBwIDtfqoIGzmu gOn1WiGxCfo44Kq9PJ7B/ms618HDwrlPDC0eW6JtIgOYq+L9QF5Lcsy+VekHlg8o 3i2NgqOwLJxUuH9s/jpxAKTE/Wv9z7zPkaP5iYn5bzHhPxkB4+bU06CTn2OseMUr PjwZOM2iZ/1AXDrBIC87ESg6zkH43g== =WmdI -----END PGP SIGNATURE----- --Apple-Mail=_A265FD68-C96F-4622-AB7A-13CA55A25E5C-- From xen-devel-bounces@lists.xenproject.org Mon Sep 12 20:08:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 20:08:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406003.648415 (Exim 4.92) (envelope-from ) id 1oXpj7-0002WM-E0; Mon, 12 Sep 2022 20:08:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406003.648415; Mon, 12 Sep 2022 20:08:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpj7-0002WF-BD; Mon, 12 Sep 2022 20:08:17 +0000 Received: by outflank-mailman (input) for mailman id 406003; Mon, 12 Sep 2022 20:08:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpj6-0002W4-3P; Mon, 12 Sep 2022 20:08:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpj5-0004Yg-UZ; Mon, 12 Sep 2022 20:08:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpj5-0003bV-Fa; Mon, 12 Sep 2022 20:08:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXpj5-0007XV-F7; Mon, 12 Sep 2022 20:08:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1gPfSmjVzUVWVetrTKNQvG+/i+kpwabevZgoVBGxnIo=; b=KZvz9v03BIHVVzPG95C9GKQ+9Z QcJhUPcel32Xm1Tt7KhSgYtw8iqxS91XJpZYB+03uOErSa3UksHFYhLCd8D8flmXGSj3/pkaEj/oi pDKEvg4weN1d1MjhgXxwRjW0pXZsc4ZDD50XWkj4QAG2KZBTA1UV4C1A682mvyG8r2po=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173149: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=80e78fcce86de0288793a0ef0f6acf37656ee4cf X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Mon, 12 Sep 2022 20:08:15 +0000 flight 173149 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173149/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 80e78fcce86de0288793a0ef0f6acf37656ee4cf baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 39 days Failing since 172152 2022-08-05 04:01:26 Z 38 days 87 attempts Testing same since 173141 2022-09-11 23:13:15 Z 0 days 2 attempts ------------------------------------------------------------ 1774 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182330 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 20:24:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 20:24:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406022.648425 (Exim 4.92) (envelope-from ) id 1oXpys-00056P-Qv; Mon, 12 Sep 2022 20:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406022.648425; Mon, 12 Sep 2022 20:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpys-00056I-OI; Mon, 12 Sep 2022 20:24:34 +0000 Received: by outflank-mailman (input) for mailman id 406022; Mon, 12 Sep 2022 20:24:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpys-000568-5n; Mon, 12 Sep 2022 20:24:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpys-0004p6-2f; Mon, 12 Sep 2022 20:24:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXpyr-0004Bx-J6; Mon, 12 Sep 2022 20:24:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXpyr-00025K-If; Mon, 12 Sep 2022 20:24:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V4jhwnzQ+ndFGZZ11dvsjiUvtjbhlMa77GX0kV+nSOY=; b=yCW4yU/HYdej7qjKcdY3LxsLvu /uH2EteVg+FP5vmEAAl/uMncZzVbXdxcZDlsX0Wixa/xKzzzYJ51RK245h7dnjIzToj7001tm6m1f BfskKcxfIiKGz1Bnj/SNCzf/q/AFLVvg0GhSOvNfMAnyG7HKE19bSwTMCX7G9QzsLC4M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173155: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 20:24:33 +0000 flight 173155 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173155/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 39 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 297 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 22:41:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 22:41:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406045.648436 (Exim 4.92) (envelope-from ) id 1oXs75-0003gm-OR; Mon, 12 Sep 2022 22:41:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406045.648436; Mon, 12 Sep 2022 22:41:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXs75-0003gf-Lu; Mon, 12 Sep 2022 22:41:11 +0000 Received: by outflank-mailman (input) for mailman id 406045; Mon, 12 Sep 2022 22:41:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXs74-0003gV-Ty; Mon, 12 Sep 2022 22:41:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXs74-000751-RA; Mon, 12 Sep 2022 22:41:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXs74-00040a-BK; Mon, 12 Sep 2022 22:41:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXs74-0006nW-Ap; Mon, 12 Sep 2022 22:41:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7AaUzoNfKEZA7R7cfKCR1AzuxKAzLFUURV3a9uiEGCQ=; b=wVRFDLoa/GdQFmiZes423Z66gW xWoZXRc0kBxih+CtdWj4P9FFkEwu3NNJxgcdk1d04/M/NVJLIBHDqcH2BfAePAKs23uX+WlWhubsQ pQWHuS2+C/er5XdFQX0OLovj25EEiXAjbJZJrlghSv0Dqa4Uoig/Cr8o+S5TyjQ+WZV0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173150: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Mon, 12 Sep 2022 22:41:10 +0000 flight 173150 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173150/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 39 days Failing since 172384 2022-08-11 11:13:58 Z 32 days 69 attempts Testing same since 173008 2022-09-05 15:47:43 Z 7 days 15 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 12 23:07:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 12 Sep 2022 23:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406056.648448 (Exim 4.92) (envelope-from ) id 1oXsWL-0006lO-Vt; Mon, 12 Sep 2022 23:07:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406056.648448; Mon, 12 Sep 2022 23:07:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXsWL-0006lH-Sz; Mon, 12 Sep 2022 23:07:17 +0000 Received: by outflank-mailman (input) for mailman id 406056; Mon, 12 Sep 2022 23:07:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXsWL-0006l7-0h; Mon, 12 Sep 2022 23:07:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXsWK-0007Wc-Uo; Mon, 12 Sep 2022 23:07:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXsWK-0004ld-Id; Mon, 12 Sep 2022 23:07:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXsWK-0003Zk-IA; Mon, 12 Sep 2022 23:07:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hWZpQAy0nQWkgzkCNXuYijEslBRmr4tQ1UE4PMamtek=; b=A2b+6OetAwUPYdNWUkOfzaQ4ZV BJOnglHzcRu2jus6weEYJJgP1bjkgQ1CEa3mMBRL6agbXsrsxUVs9qvCF5ykiuBqTGUQ8o5kzNZyj /5JkOgX/1R3WpifQInc+DhD9BoecbImm5x5B1dgE5Y+8GpFpSNXgLRN6TOpAvAzv6xrI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173157: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Mon, 12 Sep 2022 23:07:16 +0000 flight 173157 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173157/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 39 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 298 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 00:51:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 00:51:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406073.648458 (Exim 4.92) (envelope-from ) id 1oXu8u-0002G9-Ap; Tue, 13 Sep 2022 00:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406073.648458; Tue, 13 Sep 2022 00:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXu8u-0002G2-8J; Tue, 13 Sep 2022 00:51:12 +0000 Received: by outflank-mailman (input) for mailman id 406073; Tue, 13 Sep 2022 00:51:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXu8s-0002Fw-Qg for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 00:51:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26bfde7d-32fe-11ed-9760-273f2230c3a0; Tue, 13 Sep 2022 02:51:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ADF5E60F21; Tue, 13 Sep 2022 00:51:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87521C433D6; Tue, 13 Sep 2022 00:51:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26bfde7d-32fe-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663030266; bh=3GDVqr6ZFBQTMhXWnaF9L7B9qBdNmsR1PeWUnVoRMvk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Bgq4+0ZNb+Q4NKS/DEl8BU8oRQ07prRFZiAHmirWljJMgHfsZMs6FSqEzhTgu4GC9 kGqPm/IngMbJc4Ewiy35bteiBP1jcuwgRHx6WzODJvq86yz8aUSAgf+X6g0PC55CZB KcmhJZnqEr/KDdTUn35W86sFUY4wynh63EHVWDm9qkDLq+piwy1bXxyfemuV7aUkjQ R2ha2rP+IMYy3B579kz9uJZdzEzkQ85Snd4e2MPZJuPIfBXNJvNdTDhpc6w0+rT5L+ bWt/D6Nv1CXM9rOiCo8tiKuA0nEQwvrxsTU0SvwP0F7VfwwmfbxQo9XdKROGoTyOSU 82RONVSlBcJWA== Date: Mon, 12 Sep 2022 17:51:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: Michal Orzel , xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder] Update README.md In-Reply-To: Message-ID: References: <20220912115918.19496-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 12 Sep 2022, Ayan Kumar Halder wrote: > On 12/09/2022 12:59, Michal Orzel wrote: > > Get rid of references to XEN_PASSTHROUGH_PATHS, as there is no such option > > and it should be replaced with DOMU_PASSTHROUGH_PATHS[number]. > > > > Update PASSTHROUGH_DTS_REPO example. The directory storing partial device > > trees is now device-trees-2021.2/zcu102 instead of device-trees-2021.2. > > > > Signed-off-by: Michal Orzel > Reviewed-by: Ayan Kumar Halder Acked-by: Stefano Stabellini > > --- > > README.md | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/README.md b/README.md > > index 041818349954..da9ba788a3bf 100644 > > --- a/README.md > > +++ b/README.md > > @@ -34,7 +34,7 @@ BOOT_CMD="booti" > > DEVICE_TREE="mpsoc.dtb" > > XEN="xen" > > XEN_CMD="console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1 > > bootscrub=0 vwfi=native sched=null" > > > > -PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git > > device-trees-2021.2" > > +PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git > > device-trees-2021.2/zcu102" > > DOM0_KERNEL="Image-dom0" > > DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused" > > DOM0_RAMDISK="dom0-ramdisk.cpio" > > @@ -99,9 +99,9 @@ Where: > > - PASSTHROUGH_DTS_REPO specifies the git repository and/or the directory > > which contains the partial device trees. This is optional. However, if > > - this is specified, then XEN_PASSTHROUGH_PATHS need to be specified. > > + this is specified, then DOMU_PASSTHROUGH_PATHS[number] need to be > > specified. > > uboot-script-gen will compile the partial device trees which have > > - been specified in XEN_PASSTHROUGH_PATHS. > > + been specified in DOMU_PASSTHROUGH_PATHS[number]. > > - DOM0_KERNEL specifies the Dom0 kernel file to load. > > For dom0less configurations, the parameter is optional. > From xen-devel-bounces@lists.xenproject.org Tue Sep 13 00:55:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 00:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406080.648470 (Exim 4.92) (envelope-from ) id 1oXuCu-0002yk-Rw; Tue, 13 Sep 2022 00:55:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406080.648470; Tue, 13 Sep 2022 00:55:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuCu-0002yd-PI; Tue, 13 Sep 2022 00:55:20 +0000 Received: by outflank-mailman (input) for mailman id 406080; Tue, 13 Sep 2022 00:55:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuCu-0002yX-5R for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 00:55:20 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc4e1ebc-32fe-11ed-9760-273f2230c3a0; Tue, 13 Sep 2022 02:55:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B21C661259; Tue, 13 Sep 2022 00:55:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69A5DC433D6; Tue, 13 Sep 2022 00:55:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc4e1ebc-32fe-11ed-9760-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663030517; bh=ms+NxKiMLXxJiTg76z9itivlYrNHYd8j4xIAbBFQvmU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AWTWodT3cKXs6uxglQg6TRmrYQN/eEd3dyrVgEuyjIIKaXgJg0SNVe7cDLU4KSzkB TnaXlfx4rE4Lwdq9izG9BR7hLfKnK7g2r3HdVlXLZ6DoBiulVSomRGup22ADz/XFPy OT3UyhWHlXn89BRswd8VlPXtt2a57dd1LNl3sWIIfwNMklkSojBptmgX+fEky2+jtV WBobDC3QhqfPwDCgT1sZRdxNCkmNcUQ9XQBWVWkEscg3pDtCRFtOLIhjBIhcqE+rVS BjHfTMZ66LY3Cmke2BErWow8zLS/JNlZTUbSBMDpZYUkRCcZWn3qIh7+uEwLpmylBQ hHsjB0oqfbf4g== Date: Mon, 12 Sep 2022 17:55:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: Michal Orzel , xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder 1/2] Refactor sanity_check_partial_dts In-Reply-To: <64edb22b-eda8-2274-004e-9a036a972614@amd.com> Message-ID: References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-2-michal.orzel@amd.com> <64edb22b-eda8-2274-004e-9a036a972614@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 12 Sep 2022, Ayan Kumar Halder wrote: > On 12/09/2022 12:59, Michal Orzel wrote: > > Currently function sanity_check_partial_dts from scripts/common takes > > three arguments where the last two (repo, dir) are used always in > > conjuction to form a path to a directory storing partial dts. Modify the > > function to take only two arguments where the second one is to be a path > > to a directory storing partial dts. This will help reusing this function > > in the future to perform sanity checks on partial dts that do not > > originate from a repository. > > > > Modify compile_merge_partial_dts to take this change into account. > > > > Signed-off-by: Michal Orzel > Reviewed-by: Ayan Kumar Halder Acked-by: Stefano Stabellini > > --- > > scripts/common | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/scripts/common b/scripts/common > > index 25c041270c29..ccad03d82b30 100644 > > --- a/scripts/common > > +++ b/scripts/common > > @@ -40,8 +40,7 @@ function get_next_phandle() > > function sanity_check_partial_dts() > > { > > local domU_passthrough_path="$1" > > - local repo="$2" > > - local dir="$3" > > + local partial_dts_dir="$2" > > local address_cells_val > > local size_cells_val > > local tmpdtb > > @@ -51,7 +50,7 @@ function sanity_check_partial_dts() > > for devpath in $domU_passthrough_path > > do > > file=${devpath##*/} > > - file="$repo"/"$dir"/"$file".dts > > + file="$partial_dts_dir"/"$file".dts > > if ! test -f "$file" > > then > > @@ -96,6 +95,7 @@ function compile_merge_partial_dts() > > local dtb_dir=$1 > > local repo=$(echo "$2" | awk '{print $1}') > > local dir=$(echo "$2" | awk '{print $2}') > > + local partial_dts_dir > > local tmp > > local tmpdts > > local file > > @@ -123,6 +123,7 @@ function compile_merge_partial_dts() > > dir="." > > fi > > + partial_dts_dir="$repo"/"$dir" > > i=0 > > while test $i -lt $NUM_DOMUS > > do > > @@ -132,7 +133,7 @@ function compile_merge_partial_dts() > > return 1 > > fi > > - sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$repo" > > "$dir" > > + sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" > > "$partial_dts_dir" > > if test $? -ne 0 > > then > > return 1 > > @@ -146,7 +147,7 @@ function compile_merge_partial_dts() > > for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} > > do > > file=${devpath##*/} > > - file="$repo"/"$dir"/"$file".dts > > + file="$partial_dts_dir"/"$file".dts > > # All the subsequent dts files should not have dts version > > mentioned > > if test $j -gt 1 > From xen-devel-bounces@lists.xenproject.org Tue Sep 13 01:13:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 01:13:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406087.648480 (Exim 4.92) (envelope-from ) id 1oXuUZ-0003mI-CC; Tue, 13 Sep 2022 01:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406087.648480; Tue, 13 Sep 2022 01:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuUZ-0003mB-9a; Tue, 13 Sep 2022 01:13:35 +0000 Received: by outflank-mailman (input) for mailman id 406087; Tue, 13 Sep 2022 01:13:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuUY-0003m5-Ay for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 01:13:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47a1c0d8-3301-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 03:13:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A6FC612CC; Tue, 13 Sep 2022 01:13:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E574C433C1; Tue, 13 Sep 2022 01:13:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47a1c0d8-3301-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663031609; bh=CYyhikYDYUyrkYL8cB3aVHd5f9cMk6sNJ/S/LNxSRzw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=QmCU9vns4xsvuRc/aQ9UOP9uAvDIrkmrDCfuqv9FWHhxWfJxhx+Ll6rHTdPRB10Y7 pyHhK+OHQDZAc4NZdcXsnF6rMwStgWlf/i3wvwSxmYsPXrIC5gBqinkeADwFbdNSCO Eku64kZfYUUxpV8yLHNpyXdsUF2cUzuMT+i1aquUW1vtK0soFrt5rei7YltmdByHsg u4cGyz33kvTRodU548esMCJwjZWv35eqQtma+7sTJAO8doo7v3hNsRdXVsa7Qi+Zk7 stSWQUlP3084TDVS+aBf6sK+CpPHFHeo3cg/5fl6T4+mqy00sNeVCFGTbIgOUU9J3v brxrC5TtLcveQ== Date: Mon, 12 Sep 2022 18:13:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder 2/2] Add support for lopper to generate partial dts In-Reply-To: <20220912115934.19552-3-michal.orzel@amd.com> Message-ID: References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 12 Sep 2022, Michal Orzel wrote: > Currently ImageBuilder can compile and merge partial dts obtained from > a repository specified using PASSTHROUGH_DTS_REPO. With the recent > changes done in the lopper, we can use it to generate partial dts > automatically (to some extent as this is still an early support). > > Introduce LOPPER_PATH option to specify a path to a lopper.py script, > that if set, will invoke lopper to generate partial dts for the > passthrough devices specified in DOMU_PASSTHROUGH_PATHS. > > Introduce LOPPER_CMD option to specify custom command line arguments > (if needed) for lopper's extract assist. > > Example usage: > LOPPER_PATH="/home/user/lopper/lopper.py" > DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" Is lopper.py this file? https://github.com/devicetree-org/lopper/blob/master/lopper.py If so, it would be good to specify in the README that this is not just an arbitrary lopper.py script, but the main entry point of Lopper as a project. For instance: --- Introduce LOPPER_PATH option to specify a path to a lopper.py script, the main script in the Lopper repository (https://github.com/devicetree-org/lopper). If set, .... --- > Signed-off-by: Michal Orzel > --- > README.md | 22 ++++++++++++-- > scripts/common | 64 ++++++++++++++++++++++++++++++---------- > scripts/uboot-script-gen | 17 +++++++++-- > 3 files changed, 83 insertions(+), 20 deletions(-) > > diff --git a/README.md b/README.md > index da9ba788a3bf..aaee0939b589 100644 > --- a/README.md > +++ b/README.md > @@ -128,6 +128,19 @@ Where: > - DT_OVERLAY[number] specifies the path to the hosts device tree overlays > to be added at boot time in u-boot > > +- LOPPER_PATH specifies the path to lopper.py script. This is optional. > + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need > + to be specified. uboot-script-gen will invoke lopper to generate the partial > + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. > + This option is currently in experimental state as the corresponding lopper > + changes are still in an early support state. > + > +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. > + This is optional and only applicable when LOPPER_PATH is specified. Only to be > + used to specify which nodes to include (using -i ) and which > + nodes/properties to exclude (using -x ). If not set at all, the default > + one is used applicable for ZynqMP MPSoC boards. > + > - NUM_DOMUS specifies how many Dom0-less DomUs to load > > - DOMU_KERNEL[number] specifies the DomU kernel to use. > @@ -140,7 +153,7 @@ Where: > - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( > separated by spaces). It adds "xen,passthrough" to the corresponding > dtb nodes in xen device tree blob. > - This option is valid in the following two cases: > + This option is valid in the following cases: > > 1. When PASSTHROUGH_DTS_REPO is provided. > With this option, the partial device trees (corresponding to the > @@ -149,7 +162,12 @@ Where: > Note it assumes that the names of the partial device trees will match > to the names of the devices specified here. > > - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only > + 2. When LOPPER_PATH is provided. > + With this option, the partial device trees (corresponding to the > + passthrough devices) are generated by the lopper and then compiled and merged > + by ImageBuilder to be used as DOMU[number] device tree blob. > + > + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only > add "xen,passthrough" as mentioned before. > > - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees > diff --git a/scripts/common b/scripts/common > index ccad03d82b30..680c5090cd07 100644 > --- a/scripts/common > +++ b/scripts/common > @@ -9,6 +9,9 @@ > # - NUM_DOMUS > # - DOMU_PASSTHROUGH_PATHS > # - DOMU_PASSTHROUGH_DTB > +# - LOPPER_PATH > +# - LOPPER_CMD > +# - DEVICE_TREE > > tmp_files=() > tmp_dirs=() > @@ -99,31 +102,41 @@ function compile_merge_partial_dts() > local tmp > local tmpdts > local file > + local node > local i > local j > > - if [[ "$repo" =~ .*@.*:.* ]] > + if test "$repo" > then > - tmp=`mktemp -d` > - tmp_dirs+=($tmp) > - > - echo "Cloning git repo \"$git_repo\"" > - git clone "$repo" $tmp > - if test $? -ne 0 > + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO > + if [[ "$repo" =~ .*@.*:.* ]] > then > - echo "Error occurred while cloning \"$git_repo\"" > - return 1 > - fi > + tmp=`mktemp -d` > + tmp_dirs+=($tmp) > > - repo=$tmp > - fi > + echo "Cloning git repo \"$git_repo\"" > + git clone "$repo" $tmp > + if test $? -ne 0 > + then > + echo "Error occurred while cloning \"$git_repo\"" > + return 1 > + fi > > - if test -z "$dir" > - then > - dir="." > + repo=$tmp > + fi > + > + if test -z "$dir" > + then > + dir="." > + fi > + partial_dts_dir="$repo"/"$dir" > + else > + # Partial dts will be generated by the lopper > + tmp=`mktemp -d` > + tmp_dirs+=($tmp) setting tmp and tmp_dirs can be moved outside of the if > + partial_dts_dir="$tmp" > fi > > - partial_dts_dir="$repo"/"$dir" > i=0 > while test $i -lt $NUM_DOMUS > do > @@ -133,6 +146,25 @@ function compile_merge_partial_dts() > return 1 > fi > > + if test -z "$repo" > + then > + # Generate partial dts using lopper > + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} > + do > + node=${devpath##*/} > + file="$partial_dts_dir"/"$node".dts This is a minor NIT. As we do below: file=${devpath##*/} file="$partial_dts_dir"/"$file".dts Can you change the code below to use node and file as you do here for consistency? > + $LOPPER_PATH --permissive -f $DEVICE_TREE \ > + -- extract -t $devpath $LOPPER_CMD \ > + -- extract-xen -t $node -o $file > + > + if test $? -ne 0 > + then > + return 1 > + fi > + done > + fi > + > sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" > if test $? -ne 0 > then > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 1f8ab5ffd193..84a68d6bd0b0 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -1138,10 +1138,23 @@ fi > # tftp or move the files to a partition > cd "$uboot_dir" > > -if test "$PASSTHROUGH_DTS_REPO" > +# If both PASSTHROUGH_DTS_REPO and LOPPER_PATH options are specified, > +# the former takes precedence because the partial device trees are already > +# created (probably tested), hence the reliability is higher than using lopper. > +if test "$PASSTHROUGH_DTS_REPO" || test "$LOPPER_PATH" > then > output_dir=`mktemp -d "partial-dtbs-XXX"` > - compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" > + if test "$PASSTHROUGH_DTS_REPO" > + then > + compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" > + else > + if test -z "$LOPPER_CMD" > + then > + # Default for ZynqMP MPSoC > + LOPPER_CMD="-i zynqmp-firmware -x interrupt-controller -x pinctrl -x power-domains -x resets -x current-speed" > + fi > + compile_merge_partial_dts $output_dir > + fi > if test $? -ne 0 > then > # Remove the output dir holding the partial dtbs in case of any error > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Sep 13 01:16:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 01:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406093.648492 (Exim 4.92) (envelope-from ) id 1oXuXW-0004Yx-RQ; Tue, 13 Sep 2022 01:16:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406093.648492; Tue, 13 Sep 2022 01:16:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuXW-0004Yq-Nd; Tue, 13 Sep 2022 01:16:38 +0000 Received: by outflank-mailman (input) for mailman id 406093; Tue, 13 Sep 2022 01:16:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuXV-0004Yg-OY; Tue, 13 Sep 2022 01:16:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuXV-0000Cw-Hs; Tue, 13 Sep 2022 01:16:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuXV-0003al-6w; Tue, 13 Sep 2022 01:16:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXuXV-0006h7-6T; Tue, 13 Sep 2022 01:16:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=s+C4+OSdWRa9uk63PoS10mDYLQBgVsm5uQ9e6VGehJo=; b=RJGkTdEk70AWIM622za/5wzrKI lw1w2Tvsgd2JoGS8caNa2HthszUB80sLbcQ7TNIkmYCuFYksOrxcGgu8fY92APu31gJJdT12zvHWq xgnNqOS+sbn2Vm4yDOnfZiYsSIHt9xThaV7iUstMfstK39xA//9vTiyN+Endn5FGZR7o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173153: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Tue, 13 Sep 2022 01:16:37 +0000 flight 173153 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173153/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 173147 pass in 173153 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 173147 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 40 days Failing since 172148 2022-08-04 21:39:38 Z 39 days 88 attempts Testing same since 173060 2022-09-08 07:34:59 Z 4 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 01:26:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 01:26:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406105.648503 (Exim 4.92) (envelope-from ) id 1oXuh4-0006I1-S2; Tue, 13 Sep 2022 01:26:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406105.648503; Tue, 13 Sep 2022 01:26:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuh4-0006Hu-Ol; Tue, 13 Sep 2022 01:26:30 +0000 Received: by outflank-mailman (input) for mailman id 406105; Tue, 13 Sep 2022 01:26:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXuh2-0006Ho-Tb for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 01:26:29 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15947438-3303-11ed-9760-273f2230c3a0; Tue, 13 Sep 2022 03:26:26 +0200 (CEST) Received: from MW2PR16CA0009.namprd16.prod.outlook.com (2603:10b6:907::22) by MW4PR12MB7309.namprd12.prod.outlook.com (2603:10b6:303:22f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 01:26:23 +0000 Received: from CO1NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:907:0:cafe::a9) by MW2PR16CA0009.outlook.office365.com (2603:10b6:907::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22 via Frontend Transport; Tue, 13 Sep 2022 01:26:23 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT089.mail.protection.outlook.com (10.13.175.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 01:26:23 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 12 Sep 2022 20:26:21 -0500 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 12 Sep 2022 20:26:15 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15947438-3303-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3Hy4Ko6T+sV51jcS4v/HeaqSI05oke5o+S47xXef7lC8Whze5L4sI3CCriQlbDuQEMbHBQ748Z3NKLdBN0iiwnPR4MN5rbmrSnhCsnRZP5FaBtgfrO1DQt7NAcJbDJwJc6kB0mJhr0Z/BU/yo+z4DIT3IlmctNm8Q55aUMYbG0RHtocOCdvFWuaTBax8N8lOqxXZG2cR0Yc1cmziPz332y8J6X1su9Z2fL459KRg9VMDxt3fRQ0QGdFJ8JEFTOweY+2q24JJlMZM9ElNQPa9Mg+CjAr52Vr/59y2K0Uwn96QoRthPHirgmCiD5T0WsuvQZG4ldl57hb2bZVfB2ciQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DGw8WgM1pmYZjd/VUQ46RxQx+DVsuLSMgpygrSdoM7Y=; b=Wz/AdboP+cU0ZEbmfqMq4+uhHPsfgZLNin0U21yjqD1YsST+f0CMO4wSg8shXX/dlr8shUCNXtwKJZrLzXT7y5IInWj9Xn0vXyxjU7rog46Oi4ipentrYH0UGX4TDn1AFGuJdsjo+z7N8pTxIY30CwiB0K6oyGEmc2gFbk268sd4eRJy+znjeJuhIbB4XikDNpONzaMkSxTEkfdXY6YuaAMoCA6t2OagDLV1tnENzC6ZlQqiPNm3pdzueOQLcclfoKQuVlR6wxGjYKd3fMoSAPh3wCbA08FhFA8tVrTxo6S8dz5dyIOJwiOcBjGgt4DRAXb70EK6C6+EKkQ5hMUg8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=oracle.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGw8WgM1pmYZjd/VUQ46RxQx+DVsuLSMgpygrSdoM7Y=; b=vJo2TfSiA6byHf8ZwUUWt9N5DRnYLjuJ4kSHSKeI4Ft5eZFADpBsHsHQjf8wJQ/4EYoJi+5jTgK/eba113/ZA6fHUoBDOC17mE3iqSxXiXuytZTAd6rzh60r7P6HOX1Ccl4YE/ZRNIPZpulwt4sFxJOCTnbDaosSRMAr447Xxe8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Date: Mon, 12 Sep 2022 18:26:14 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: CC: Stefano Stabellini , , , , , , , , Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT089:EE_|MW4PR12MB7309:EE_ X-MS-Office365-Filtering-Correlation-Id: 902716c4-e11b-4a17-a7c0-08da9526f866 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBZmUyHr1egRxbHdtVodLtq4hnueOPxkAOO7lFwvgNJGAefbLflGNEs2oa5Etekk6wXr4WmWgV3lngYZrc8w1LdoR57lQXCpPw5ozy9uUo+j/hC2Z3P8GU5xJo+6CrnQGBMDyX8Hs9w7fX697482x8rjdmxICkx7hlg/K5L1UOrg9Q6sCtZqBWdhRpn7vdocmNgR0zdELME/Y9X+gtlqnH1niWXKa8avKjDXRVvkBw5v42QRiTVAlfRLDUuE7qJ1ZAsG136zo8jeHF3K/YGEI0o3rBudlrJj4S4Ldsy7rjN7ATP3icZiZjjRR1rDsQEgBCygltW/6b0526uAihszpeyQKfLJFZjUR2ryIQofqZrFS20dR9RL7zU4iz08MZZcsaZEiiG+YcxovsH9cyW3fJGTSVu2tKUSDfJDsA2BY6h9v12mxenftk542W+4aGEJP9fhh5kQvq/ole2oNhRWv7X77WOF8GrEg3C0bCcI93FFTiUAVdrK7mQzljHUBQbHKqoqqsE7Tp2ZVitFEOxPEPPzIOFN6vn3rjjK02ZDydH/jqmORAlsutOR2XZsU/KQ7/pK4oJYh0iE9N1aQCrWs6QLZlZSSACC3lM5oiuUEbpFwEAkTV8ivhs+2JHixwqMlgLEtWYfQel1GvQ/rUwhV1CVjnKhIyKZGDmUiWl5Piv4ozE6K8Hgcf8+EGNhOn8MUPvQj5DnYTzJjHI1IOkwuL+6+uOiPNQiitggPsIV/o8UKfRYym742epWSrjsKzQYNcFQLu+s36xePL6EUgkzQtix9Epb0wMTspwKTqaPh98= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(6862004)(316002)(2906002)(426003)(26005)(4326008)(70206006)(70586007)(47076005)(336012)(9686003)(82740400003)(356005)(6636002)(81166007)(82310400005)(41300700001)(8676002)(186003)(54906003)(44832011)(33716001)(86362001)(53546011)(83380400001)(8936002)(40480700001)(36860700001)(5660300002)(478600001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 01:26:23.3244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 902716c4-e11b-4a17-a7c0-08da9526f866 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7309 On Sat, 10 Sep 2022, Juergen Gross wrote: > On 09.09.22 22:25, Stefano Stabellini wrote: > > On Fri, 9 Sep 2022, Juergen Gross wrote: > > > On 09.09.22 04:11, Stefano Stabellini wrote: > > > > Adding more people in CC > > > > > > > > On Thu, 8 Sep 2022, Stefano Stabellini wrote: > > > > > Hi Juergen, > > > > > > > > > > A colleague is seeing a failure on x86 in Linux Dom0. The failure is > > > > > pin_user_pages_fast with addresses that correspond to foreign memory > > > > > pages: > > > > > > > > > > - QEMU maps a domU address using dma_memory_map (xen_map_cache) > > > > > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Address > > > > > returned by dma_memory_map > > > > > - Linux tee_shm_register->pin_user_pages_fast Returns -14 - > > > > > drivers/tee/tee_shm.c > > > > > > > > > > Once upon a time it used to be the case that get_user_pages_fast would > > > > > fail on Xen because we didn't have a struct page corresponding to > > > > > foreign memory mappings. But that hasn't been the case for years now. > > > > > > > > > > Any other ideas why it would fail? > > > > > > I think we can expect that access_ok() isn't failing. > > > > > > I assume the mapping was done allowing writes (sorry for paranoia mode)? > > I was told it was verified: QEMU could read and write to the VA returned > > by dma_memory_map. From /proc//maps, the VA assigned after the > > mapping is pointing to /dev/xen/privcmd. > > > > > > > Other than that I'm not having enough memory management skills. It might > > > be > > > related to mmap()-ed foreign pages having _PAGE_SPECIAL set, though. > > > > Do we still set PAGE_SPECIAL for foreign mapped pages? It looks like it > > is not there anymore? If PAGE_SPECIAL is not there, then they really > > should look like regular pages? > > See the call of pte_mkspecial() in remap_area_pfn_pte_fn() (mmu_pv.c). The kernel version is 5.16 and the return code is -EFAULT. Is it the following -EFAULT the one that triggers? mm/gup.c:internal_get_user_pages_fast: if (unlikely(!access_ok((void __user *)start, len))) return -EFAULT; From xen-devel-bounces@lists.xenproject.org Tue Sep 13 02:38:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 02:38:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406116.648517 (Exim 4.92) (envelope-from ) id 1oXvoV-0006IK-5l; Tue, 13 Sep 2022 02:38:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406116.648517; Tue, 13 Sep 2022 02:38:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXvoV-0006ID-2s; Tue, 13 Sep 2022 02:38:15 +0000 Received: by outflank-mailman (input) for mailman id 406116; Tue, 13 Sep 2022 02:38:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXvoU-0006I3-J7; Tue, 13 Sep 2022 02:38:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXvoU-0001zb-HO; Tue, 13 Sep 2022 02:38:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXvoU-0007Jx-4c; Tue, 13 Sep 2022 02:38:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXvoU-0008UV-48; Tue, 13 Sep 2022 02:38:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yqfp1mjrTWHYxofbUVZ9RkqerRFfMBLRxKGblAlTdW4=; b=308QM03DTIrCXRXbbXcDTCNW2m 9d4aicLp3ut8T7oVNQBnCfDKaEjvFLZRwG2MEEkRG1RH2y8noDFkad5M0HEAaH6tQJGUJyj+WyNEN 18QafIdOywK9aZAlIqeYONT6/prU8w3+DmDjvUyswyshZTjZhiCMCq4uaVqse7SBFnQQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173159: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 13 Sep 2022 02:38:14 +0000 flight 173159 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173159/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 39 days Failing since 172151 2022-08-05 02:40:28 Z 38 days 299 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 03:02:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 03:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406125.648528 (Exim 4.92) (envelope-from ) id 1oXwBd-0001RL-46; Tue, 13 Sep 2022 03:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406125.648528; Tue, 13 Sep 2022 03:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXwBd-0001RE-1J; Tue, 13 Sep 2022 03:02:09 +0000 Received: by outflank-mailman (input) for mailman id 406125; Tue, 13 Sep 2022 03:02:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXwBc-0001R8-67 for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 03:02:08 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2064.outbound.protection.outlook.com [40.107.220.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71c96c04-3310-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 05:02:05 +0200 (CEST) Received: from BL1PR12MB5993.namprd12.prod.outlook.com (2603:10b6:208:399::9) by SJ0PR12MB5470.namprd12.prod.outlook.com (2603:10b6:a03:3bd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Tue, 13 Sep 2022 03:02:01 +0000 Received: from BL1PR12MB5993.namprd12.prod.outlook.com ([fe80::7189:8652:da69:2158]) by BL1PR12MB5993.namprd12.prod.outlook.com ([fe80::7189:8652:da69:2158%7]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 03:02:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71c96c04-3310-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcJpAWxHp1YcHlSBrGMyCh7IPCE7B/tZFfQky92qWTWEOU+gliSzCp0EweCEAQxFGWXSJecg3pQ5aLWxkdUjxxOhP9PRl0COyF2+Krs7LDj3x+K6+9zNyTwmWRuNiMBi/mGxya3B93FdM9jrZe7F0dpRdy/pyV1DclCVRJVig7c05xJc6tC7rRZmXO2osenq1VFrkFXC2Jz/aMNJkaU0967Ug8i75wpObcjYUBqZapuSAV5rNtPUW7Ocw2Tfpacrme6EGba2Z8Lz0ZhDuHHLGr/ao6XEE5Ir6Qk78v+zxFG1o0b+t48krFDBMp/y6ddwSgEAwha9848RA4JjgsS+AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gkvIyBMgo/NmIFYsjc24BRclBG2sUpVhlh4owhI0ob8=; b=O+3f+HCPYK3imDVdGaHqBWtFzNU7hveaRnuTDNMnaU9gDmnFtIo9L/J9PaS1ct/KoFB81qpj8PFoPA3XLog/1XEISMsfoBj9oWU9lNlECSuSw3XsWjnPGIrsaST75reClSfcJWnj6mkxoKKjdIFlzVo0pgByAuB1K9qwPfwNkq2MzZig5vwUSGVoIIZdWCNqbFISJK2jsJPwOEI8ms+rI17+0fl76h5CDsZoCrDmhkanmaO9iHYBXmWP5Q43v2O0ESDnYeH5EYt9HwFZ6kg7wkXK/UkraZhZa69ANPfwJj21NjEKWZoWs6yZqsjN+kPAkYR2Tc75SUVKePYfAPKkLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gkvIyBMgo/NmIFYsjc24BRclBG2sUpVhlh4owhI0ob8=; b=RK0gWz8rGzuDT2Ec8scqJZLFyMRGInFxp3rkQRmPMxq+xbLmSZbM4RK5JMpVB7vGIUgSH1VVJdCdg4oDatItVZPMOmYZR69uxqAmbL5GqqV3br9SQ5I+EqIZbhqfPFbdyc6EewUhr+ey2Clo13TxEkcaLuUOnDdcCpIkf7KkmPM= From: "Ji, Ruili" To: Paul Durrant , "qemu-devel@nongnu.org" CC: "Liu, Aaron" , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Topic: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Index: AdjBw9S5XjagBB9xT0W01YXm2Fq4yQAkLQ9gATHwuGA= Date: Tue, 13 Sep 2022 03:02:01 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=149f7e60-4d0f-4975-8ab3-8497009eb09c;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-06T07:36:17Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR12MB5993:EE_|SJ0PR12MB5470:EE_ x-ms-office365-filtering-correlation-id: f6636885-7a33-4abe-0a97-08da9534545b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s3Sc6abCfjKTil2V9hICO9dRGrh2Nu2Ab/GFMnsSq5fPXiff2ZrgK1TCB/Pv4dxWtNyADjwAifc6Htjo7Od01Tltv72UiYgZbmOu2bSkLNwwieYjw8nYKRTLv1r3P3+2W2eOQZS/Xa2TSmC+2vlt+45gSie9/pAaAN+aL71IiuRUjyiy0HrZ1FE4BJUtZNM8UMJSV1MpBpdXIg0Xvv4i0gLYesXm6w0iMU4ad6rw3djzdceS7MHMKsAJsg8/PYpxQ3eDAU7h08ElJ173JveumscVUxso3X6Xq6vSMnkaI6lEAY6Z515IHwBGLBXL5NbLdXV9lreh/OpW9XQBUnbJKMspp3mxzCM8B5vu/XvHBTclto/yFqoke5WzRp6+6s0x41In/HSJeaZJi8V7O2pEjRNjUYppCrm6wp+JzVSIiC6tWoIj04hC9GdDnieaqkT7F/ySIQMnX1puT4PtZQX65pRotqvoCFspbgRc47mPkj26AM2PNVpRQNFAqIW4BVnRn3uCzj8c2q2OLeIxkbrvHJKtygX1W/hnHf2aq9zjFYv5L4ABLsSJw16LT0nymcjmyeFjfxGSKalJs+tMqstdX1QPStKI51+pqQK7rhZuBkPbj88vIXw6ZNp5IEkjyiWQWMKJ0ac2WY6wChw0mmGnfYXN9eTTyh3nhfwSJw5yPPVUm2sj/gNjUzI2OR+2pjRl9X+bGmodC5RgP/6aiunnqT52l+EA0tWmFCShfaL28fYUePv8xkUtPZOlY/rVF0wRbQqjGYiM4zg99+adwxElHFd2+FelNQ0K+bJx78rz0Vs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5993.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(451199015)(966005)(186003)(86362001)(9686003)(53546011)(316002)(41300700001)(64756008)(478600001)(110136005)(7696005)(33656002)(8936002)(122000001)(83380400001)(54906003)(52536014)(38100700002)(4326008)(66446008)(76116006)(66556008)(71200400001)(6506007)(5660300002)(66946007)(26005)(8676002)(66476007)(38070700005)(166002)(55016003)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?aTI1VmJ3NU9pU2syeG00QmZRd1lkZWtLK1NuOWttYzYvN09xUnlhVXVR?= =?iso-2022-jp?B?VytBcSt3VlRXODlSRkN6WGg0TkpuTXVDekxrVDFPRDdnRWhGTmFlenFE?= =?iso-2022-jp?B?UEVFclBHKzJEcW5DNWdFZ3RBdGE2YVVteHl0RWt2OEJwZzN0RWl1NUxh?= =?iso-2022-jp?B?RU1Ea3FBSGNSclRaZWgrVWs2U3ZwdmpMMk9xbm4yWW9sTmdkdUtRSCsv?= =?iso-2022-jp?B?U0tPeHNnVWJ2bXlYMDF2Q012VHdkdmdhdkJPM21JTnlqVVcxZmIyNkZ1?= =?iso-2022-jp?B?eGRhNCtHbmZWQ05DQm1mK1N3aVNhZmI4QXFHakRPcERVRmlnMXFueUIz?= =?iso-2022-jp?B?bEtETm84UzJVQW1NOTVvTlMwcmdHcVhJb0dBZU1RQ3daTTBqenJZek1l?= =?iso-2022-jp?B?SEw4M3Izb3dSTXpvZG5BUjdqTUdVVWNSOGFiNHEzbjB3cHEwNHVwZnZZ?= =?iso-2022-jp?B?WWZIcitWNkNYazd2TUNhckZVWDFCbzg5VVd2N0crZUh2dHl1aGRIWmx1?= =?iso-2022-jp?B?S3IxZHJTZ2s1dTdON2h6MjJ1WmErM0dOUnJBNTIrQS9uYmVzYzBrKyt2?= =?iso-2022-jp?B?UXBBQXl4blp1SFNtcm1YOEdUT3N0VmNzb3VnMlErbkZOMFZjTkNUYTk2?= =?iso-2022-jp?B?ZURjTUpOYXdrMkFFZFNPOC82VnIrV1AxRzFkWW9aTTlKN0lmWlhtb0dM?= =?iso-2022-jp?B?dWtENEFvajgrUWZQSFBFWmh2d0tVb01hL0xsTTlzdlVPOVNnMk13Umc0?= =?iso-2022-jp?B?RGNEWXNkYWNSVkc2ekhEODRrZER3cVV1Yk96SEh0alNIM0VTQU1qbXlZ?= =?iso-2022-jp?B?M3ZDdWNYNW5UTkl4eUNGdTZpUU9TcVNyN01QOFdrVUpUUEwzNkhud1Y2?= =?iso-2022-jp?B?YnpBM1BGMFNPaDdMRlBoNUpTVkN3ZktKYTJkbnZhRzRCeDZqeVV4NFF2?= =?iso-2022-jp?B?SUo4NklTYloxQmdHSENtVWVLc3h0RmZBVFlaN0t6cjRnTlY0OStHUWpm?= =?iso-2022-jp?B?WTRBT0g0a3FZNzN0ajZwZjlzZEZyV0RUNitjVUVDUXA1ak1vZjZmRE1m?= =?iso-2022-jp?B?a0Q2WEhCa3NMM1JtNU1RbzFLekxuUFNEbDExamVCbTBTcDQ5bURRcjha?= =?iso-2022-jp?B?V0R1ZkFnOTVDeENtdEFVYWhjL3I0SGNzQXpQMlhOZm5QcnBVZTlDYnBR?= =?iso-2022-jp?B?ZVlZQzE3cW5Qa1pTUHp5VnlUaUQxYndBMUJ0Qk1RRW02MTNPdWV3aGpJ?= =?iso-2022-jp?B?Zkc0TUd1Rjl3Q2M3ZXRxLzRVQi9FS3dFR3kyZDBpdVdxaUtuYVB1TXhI?= =?iso-2022-jp?B?UnA0aytVOWw4cTgzbENJRG12VlBXY3hqK1RVRjgyRU1zWVB1WmovZkRi?= =?iso-2022-jp?B?cVY3OE5mN0wreWhyRXd2ZTJRNmw4bWxYVXoxYld4SVgyOFIyTjVFTnVv?= =?iso-2022-jp?B?SmZiQ2hYNGN2Nlc4NnRrVTk3UlhYOE15SWdKVnZVZjVPTGUzYU1BU2pa?= =?iso-2022-jp?B?SW1LNEEyWHpDUGJtbTQ0cVdlc3FKU2dleS93UjJRU053R0lsdFREb2Fp?= =?iso-2022-jp?B?VSt4SkFUTm01UEtPc1IwY0dTWlNWenZ6bWFJemllNUIvdUd4ZVJXSzR6?= =?iso-2022-jp?B?cElnckdhTm1xNVFrNXp2ZmEyVTlqRHZPSFJwWkQwZ2NKTFBBYXFyZVJE?= =?iso-2022-jp?B?UDBzNjFCa2JMdXlFRUtCRmorMHR6K25qTUxaMzdiV3BTKzJ1N0FrNjZS?= =?iso-2022-jp?B?OSsrc2lDajV1Yi9lMGpjWVJUcmM1TFhxMGJrRDVjREpORVVqZVc4NlVQ?= =?iso-2022-jp?B?Y2RnVE85SmZ1K0VyNjJaTXdKZ0ZWNzRtb2JVYU40ZFBaTXpIa1NRNUlq?= =?iso-2022-jp?B?MW9aNXhiT3Vyek0vV3FVKzVCYXFyNUEydzM2U1ZTSCtyK3RhSUZNa3pP?= =?iso-2022-jp?B?WXpKVVhkY2hzQ3NLUittQ0ZCUFFpcEZDM2UzaFk0ZGdJZ2p0ZzBzandD?= =?iso-2022-jp?B?TDJwWUVpOHcvbThkNHVxRTFHVGRab1d0VzRJNGJtdWg4UExyNXB6V085?= =?iso-2022-jp?B?SVg1WGJadks0N3RsS0NnSDlFTWFQUmxrREMwK2xXcTBablY2cGgwU0tB?= =?iso-2022-jp?B?elh0QU5TbjYxa2I4TWNmYlk1RkxOSDFXREkyekJUck5pR2JZNmVVdVBI?= =?iso-2022-jp?B?ZUpLMkpVa2lkaGl1L09nVU5udWVGTTl5OWV3TzhZck42dGpLT2NKMnVi?= =?iso-2022-jp?B?OWwvNkZJYktSVDdNQ2dUWStaRDVtRDgxVXB0U0tkSU83eUx0amNRZHU0?= =?iso-2022-jp?B?K3NzUA==?= Content-Type: multipart/alternative; boundary="_000_BL1PR12MB5993DC46EDF5D01ED20E2E179B479BL1PR12MB5993namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5993.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6636885-7a33-4abe-0a97-08da9534545b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 03:02:01.2280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dw4VW8bG9CBpYjMk+loELpJCu9gjJ7IOvP0boZHIDBOCH1ltdEq8f8gU/8rOQwM+LygRHuh9VYf/bWLSrSEm2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5470 --_000_BL1PR12MB5993DC46EDF5D01ED20E2E179B479BL1PR12MB5993namp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Paul, Could you help to review this patch? Thanks From: Ji, Ruili Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B7=1B$BF|=1B(B 9:04 To: 'Paul Durrant' ; 'qemu-devel@nongnu.org' Cc: Liu, Aaron ; 'xen-devel@lists.xenproject.org' Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough de= vice FYI From: Ji, Ruili Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B6=1B$BF|=1B(B 15:40 To: qemu-devel@nongnu.org Cc: Liu, Aaron > Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device >From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Sep 17 00:00:00 2001 From: Ruili Ji ruili.ji@amd.com Date: Tue, 6 Sep 2022 14:09:41 +0800 Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Make guest os access pci device control 2 reg for passthrough device as struct XenPTRegInfo described in the file hw/xen/xen_pt.h. /* reg read only field mask (ON:RO/ROS, OFF:other) */ uint32_t ro_mask; /* reg emulate field mask (ON:emu, OFF:passthrough) */ uint32_t emu_mask; Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196 Signed-off-by: Aaron.Liu@amd.com Signed-off-by: ruili.ji@amd.com --- hw/xen/xen_pt_config_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index c5c4e943a8..adc565a00a 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D { .offset =3D 0x28, .size =3D 2, .init_val =3D 0x0000, - .ro_mask =3D 0xFFE0, - .emu_mask =3D 0xFFFF, + .ro_mask =3D 0xFFA0, + .emu_mask =3D 0xFFBF, .init =3D xen_pt_devctrl2_reg_init, .u.w.read =3D xen_pt_word_reg_read, .u.w.write =3D xen_pt_word_reg_write, -- 2.34.1 --_000_BL1PR12MB5993DC46EDF5D01ED20E2E179B479BL1PR12MB5993namp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi Paul,<= br>
Could you help to review this patch?

Thanks

From: Ji, Ruili
Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B7=1B$BF|=1B(B 9= :04
To: 'Paul Durrant' <paul@xen.org>; 'qemu-devel@nongnu.org' <= ;qemu-devel@nongnu.org>
Cc: Liu, Aaron <Aaron.Liu@amd.com>; 'xen-devel@lists.xenprojec= t.org' <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthr= ough device

 

FYI

 

From: Ji, Ruili
Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B6=1B$BF|=1B(B 15:40
To: qemu-devel@nongnu.org
Cc: Liu, Aaron <Aaron.Liu@am= d.com>
Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough= device

 

From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Se= p 17 00:00:00 2001

From: Ruili Ji r= uili.ji@amd.com

Date: Tue, 6 Sep 2022 14:09:41 +0800

Subject: [PATCH] hw/xen: set pci Atomic Ops requests= for passthrough device

 

Make guest os access pci device control 2 reg for pa= ssthrough device

as struct XenPTRegInfo described in the file hw/xen/= xen_pt.h.

/* reg read only field mask (ON:RO/ROS, OFF:other) *= /

uint32_t ro_mask;

/* reg emulate field mask (ON:emu, OFF:passthrough) = */

uint32_t emu_mask;

 

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196

Signed-off-by: = Aaron.Liu@amd.com

Signed-off-by: r= uili.ji@amd.com

---

hw/xen/xen_pt_config_init.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)=

 

diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xe= n_pt_config_init.c

index c5c4e943a8..adc565a00a 100644

--- a/hw/xen/xen_pt_config_init.c

+++ b/hw/xen/xen_pt_config_init.c

@@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_r= eg_pcie[] =3D {

         .of= fset     =3D 0x28,

         .si= ze       =3D 2,

         .in= it_val   =3D 0x0000,

-        .ro_mask=     =3D 0xFFE0,

-        .emu_mas= k   =3D 0xFFFF,

+        .ro_mask=     =3D 0xFFA0,

+        .emu_mas= k   =3D 0xFFBF,

         .in= it       =3D xen_pt_devctrl2_reg_init,

         .u.= w.read   =3D xen_pt_word_reg_read,

         .u.= w.write  =3D xen_pt_word_reg_write,

--

2.34.1

 

--_000_BL1PR12MB5993DC46EDF5D01ED20E2E179B479BL1PR12MB5993namp_-- From xen-devel-bounces@lists.xenproject.org Tue Sep 13 05:43:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 05:43:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406141.648539 (Exim 4.92) (envelope-from ) id 1oXyh3-0002HL-Oo; Tue, 13 Sep 2022 05:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406141.648539; Tue, 13 Sep 2022 05:42:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXyh3-0002HE-ME; Tue, 13 Sep 2022 05:42:45 +0000 Received: by outflank-mailman (input) for mailman id 406141; Tue, 13 Sep 2022 05:42:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXyh2-0002H4-6p; Tue, 13 Sep 2022 05:42:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXyh2-0005rQ-1P; Tue, 13 Sep 2022 05:42:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXyh1-0002aO-Ff; Tue, 13 Sep 2022 05:42:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oXyh1-0003qy-C0; Tue, 13 Sep 2022 05:42:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g1MYSS5wVhpsAjrtfMjTlecnrAJ2MJJgNryRGyUVQAI=; b=TvxtAWck9fHrmFfpzeUnYPkD+U NG4tIh9jzsZH5crNbunSGh3BzcV9jUuA17SrXpt+tUcjPy1AZSZbxy+kTFTi/DExSEnlhAGtFfSkM 9mtKBn678UOFoSdkH4JAiuLe9x4FlCiXb42LTlr66a6DIVBapHWqgULcmga6Oc1pO6D8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173156: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=80e78fcce86de0288793a0ef0f6acf37656ee4cf X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Tue, 13 Sep 2022 05:42:43 +0000 flight 173156 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 80e78fcce86de0288793a0ef0f6acf37656ee4cf baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 40 days Failing since 172152 2022-08-05 04:01:26 Z 39 days 88 attempts Testing same since 173141 2022-09-11 23:13:15 Z 1 days 3 attempts ------------------------------------------------------------ 1774 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182330 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 06:08:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 06:08:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406139.648550 (Exim 4.92) (envelope-from ) id 1oXz5O-0005B4-Q7; Tue, 13 Sep 2022 06:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406139.648550; Tue, 13 Sep 2022 06:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXz5O-0005Ax-Lz; Tue, 13 Sep 2022 06:07:54 +0000 Received: by outflank-mailman (input) for mailman id 406139; Tue, 13 Sep 2022 05:35:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXya1-0001OY-BX for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 05:35:29 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2081.outbound.protection.outlook.com [40.107.93.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3567431-3325-11ed-9760-273f2230c3a0; Tue, 13 Sep 2022 07:35:08 +0200 (CEST) Received: from DM6PR12MB4564.namprd12.prod.outlook.com (2603:10b6:5:2a9::18) by CH0PR12MB5234.namprd12.prod.outlook.com (2603:10b6:610:d1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 05:35:23 +0000 Received: from DM6PR12MB4564.namprd12.prod.outlook.com ([fe80::d0bb:4d4d:7767:19fd]) by DM6PR12MB4564.namprd12.prod.outlook.com ([fe80::d0bb:4d4d:7767:19fd%7]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 05:35:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3567431-3325-11ed-9760-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOKvTM2qqodYj2tOJW8tHBiGNCyiTdkuyTx/k+XtuMwkKTHozpsmbPE8x109sc/Bb1S49LFh2/rsvy3MVMDz1nqKWvqjsijhe1rw9GTTbkObz4ZxRTnL3VLMImZiHCIWsb8DwsvVuoPXGPcyZQTjlLzxOyAL2aSmLHZf7jK+zg+d+WaX/3K/pxq7JlQlHnE8s21iGT8/vYz5LdMZLFe0cBfLlc6mBx8/scUTCRCTN25RJcR4mgqN7t7/VQr+M0GlTEkylugW9LgXeaPg8haVnAD7qaYBQ0FN+ifFWIZ8V20+pHSaLIEE1s522Bk5Sc49WKAsQ+wH7laOFVjejsA7YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qWZip0tRpXcF+5svqmGfGfLAz4B+pwQkh82ZzR/olYE=; b=miHdcRstnJWIGcFx19AnZGrZYHBAwEBybZJX8gP2ECbDEi6SQl8xlYTxeLSRNKEMtsRQyJn0qbPuJqR8wdUZUXLcP2PUcu27YrAl8pWoIm4I6WVbvyU1mk1c46tM2M/9Vg0dUKZehGvvn7jgQ/mfhUD4+7MTi7TUFcC269VOKt8Sr/Zk8CZz4Pldfr2DU6D0b4iJY8uG0Q1U0Je8XXLW3YIXjg7q046xwvnJNaKhPqw5D0xyqGtB2SMwVeOG+j5RSJSD/FzaLVLYZpah5yJn9KGvcB8MKRtzDcuNsemwfCYbRfiTPPZTLsIAi6hNvYdp4xMbQ7KcfjRxnbV9CPqfcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qWZip0tRpXcF+5svqmGfGfLAz4B+pwQkh82ZzR/olYE=; b=NHhP3Qk0JCa0wwzcgTO1hxnHrotmAY9TJaF9byRFPZOvz7mmAZe5s1crPCOn/A86pvpQHDKYWiZON20OKHiuBhifAbg20my3TeL90CID+2b4XjD1U7Ol0NT9IPoboKMifFM2lxRsUSBFT/mywOCWTYFm/dgh/G5u9qdV8U4TZ2w= From: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" To: "Stabellini, Stefano" CC: "Stabellini, Stefano" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" Subject: RE: Linux pin_user_pages_fast fails on Xen Thread-Topic: Linux pin_user_pages_fast fails on Xen Thread-Index: AQHYw/FtbHk6dXjix0qU8E4gYrQhY63WppaAgADmKYCAAIgNAIAEgvEAgABFGKA= Date: Tue, 13 Sep 2022 05:35:23 +0000 Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-13T05:35:20Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ac6f7c04-2fd4-4892-9f5a-0d147769eed1; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_enabled: true msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_setdate: 2022-09-13T05:35:20Z msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_method: Standard msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_name: General msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_actionid: 994af694-58a0-4771-a281-be81576649a9 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4564:EE_|CH0PR12MB5234:EE_ x-ms-office365-filtering-correlation-id: a4f7aefd-fd84-4deb-922a-08da9549c169 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V1I+AVqgWSBdC7IO2wmR9nZSUCp2pL8SVJTBumIAS2qwP//rh9zjsmXC66sxKdOTuXhyDhLU5d8tzyPw9CRo8pZI+Sduw31ExRbjXz/WpeSPo30jdFzPgYwzBsINUXHJQiB+T5WLPGUFfhxpyZfOgihoigiwBU5+H7y+L/tMvnd9JG7ClfNx7nzDoOWnIZ0NhxuDsHHZdI9Um37Bc1mDT8IlrOk4r8QkE3eLM1uCMniCZxiru9VnJXnvrUYABozuCAmgJ/kXg3cVS+9bX1klM6K2fMcP4AQ5/2O9q4r2q15ex1wG75CVkzgzXGRE+aa2xEGL9Iw928Qtf4zaF6i6OaMaOJB//2Y4POaFyd2f1qdwZQWztUChOMIGFKtspM3cQ/5MSJcZ3xohjnUiglcNi9XOBLrrB7civ4OMxy/MyWCujEs+82e/vc+RuktOhidq8Obz8MrygpIjM0Le8HYJu/DuXeAgkddyymRaTmT2toikufCL51lojP8q1jcyrlT2md8Z7n67XoqN4Rw3/bH5LBqPNCrIpnLta/3oR6x2F2M3QChehkimxjhzIqX4tJSPvCxw+zEKLDEDxMy/BtX/Q/QI8jS4JXhgCjlng8wNaIRkNlSlQfTu85fB0D3Jjl4V2chQAumeASkoh545SLwQRHpIWl8qrNoiIyG01NjzjcV83cF4cBt+sGTusA93mvJr1A3kV/FXDsp+bzmcd7yRYyseUzx39XFutQy8Y6z1hqH3z3sPi/ejxvV3Mw5xGSGZ9mzh5bQ9bOgmO1yVeEE7ftga34G8qS7gs5kSl00M/oo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4564.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(4326008)(64756008)(86362001)(122000001)(38100700002)(54906003)(478600001)(316002)(66556008)(66446008)(966005)(53546011)(66476007)(55016003)(186003)(8936002)(2906002)(26005)(71200400001)(9686003)(7696005)(66946007)(6636002)(52536014)(76116006)(6862004)(33656002)(5660300002)(41300700001)(8676002)(83380400001)(38070700005)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qEbC/M2vCJj+b2nWW/5JX+H1BGTKFuMMwU/lz4co9Qg0svLkobL8RXpPHZr8?= =?us-ascii?Q?KibxsjtYrPC5GJ3JsHIc1cQ2/8Z8IuUU8TrvAfjSYNyA8yKAFMbP2Xv5wU+K?= =?us-ascii?Q?TXT7x0/9NINLXMlZ++QZ9X4BDLKqdHs2XPK5zLqI/X2X/3F1P0ekhq5ltdud?= =?us-ascii?Q?FlgFORqdJ1JLE9g288zTgoA89QfPFbGhm466luD+rq94zIarVesNfOfsoIx0?= =?us-ascii?Q?0NW+GQdbHCWm4ICwPMamaxBnHLVf95J9ur2wHXv5qzOOIo27NG9rM4t51KYF?= =?us-ascii?Q?gzXRQ0rqyxh5Kxu3v3tBfSOlOhF1nGlyHdbKsyFVdakwj5FKrDhkrOTJQa8Q?= =?us-ascii?Q?9uiUE26L+zPn2efD39tVDHuZRV6VUok+8IKli8brDOMu9kQZ9kpzuLLlJaHQ?= =?us-ascii?Q?SuMVi9dAEOA+Qk2RxzOBcPuaxfhbXtpNTN+ijixA67GlUUiGIW5TERCN90Sy?= =?us-ascii?Q?we+QRlwkR8SYf72JwuUdj1QNabMSTMDG7r4FK3pgBbQCmKzoWX4iOCZEssYc?= =?us-ascii?Q?AN2s+t5XzN1xDtzjx3J2gUF+wuMiTO60lRM8w4EDIDI1V4JCxEeH9YjAulc0?= =?us-ascii?Q?cE8xYAaKzYsR+MnTo3A/opwz1ReLbaMJx4YAiNKoFsVxVetMaGgIowFhXlAC?= =?us-ascii?Q?dW5TEjRsjtyo4IAlORLUkquUvn1xXRGfAOANLOa2L2YDCTXz9SYzCfk0/tYX?= =?us-ascii?Q?63aNslufIRQOgwnZm4jBZAwT7wlABBMGzi7kxgl6XJQZRD5JONgw59Vn7lHh?= =?us-ascii?Q?S+azMXbWCbjCr/FVmvZ9vqdsmExwubONZNBDUuY2bzqixIQYTfTAnm/0U73H?= =?us-ascii?Q?2HntOVOqeQ1ZV5/MdNzFqBFSGGHJTPaS4FPfjmqGSQoJmVqhyketkcABbApr?= =?us-ascii?Q?aoDwnzuzn03dVFFgLyQ6vsHIVP5tboahvMAeENjaHl9VvfHMJrzIlbH7FE4y?= =?us-ascii?Q?HoG/MMGMOq5rjNLhNIP7tknTHZsXBPoWooeY3gkic+9AjhoqrRRLmwLI3zUw?= =?us-ascii?Q?DneZRGVtEhqxmgiRXfW3obJJZn12tr1hUCp5wNFj+K/bK2Gt+w8Lo/jvRFAS?= =?us-ascii?Q?knD68cRy/tNntPfU6FBrQi4fSAlqdMy4owJ/uy5gBwnRK+UQYW/BVXkFKXpw?= =?us-ascii?Q?m5M3X4H9MZok8XPONFBvttd/rn05GCjxynP5LUFnN22hM80tf3Tq53QH8oYU?= =?us-ascii?Q?yYGD6UPi5RCEy9X8oZL7hmSj1JWo3S594bCc3FveT8EL5mB+3NUW369RX1Tw?= =?us-ascii?Q?uHX3yu44BF4dmO2v0y4ul1LGAE8gzSU+tNQV9N3wRQWaCsbCHMR7zcE8q8Ww?= =?us-ascii?Q?drUvnAujLwhEeE9GjNJnD3vslHHXipBb+cqXI1110cuBOg4RWrK+9k2TLbf/?= =?us-ascii?Q?7X/jWWcI0LEWGAC307NuyPxnzCM7KOVukQEgnVAtqGA7YcvkPx5/dpD964dU?= =?us-ascii?Q?i5EMIiTWSlPVkrnFyo8H2XYPsYocChJeOb8+AD3ihtqR/n+OgC80kjk3fqF1?= =?us-ascii?Q?e4F2onrvcRbbPQz3hT/njFeJ/Uct5MrvgsgUzW5O4yzaITK+srlNUs7JVGiL?= =?us-ascii?Q?w2x3lXzNkx0/XvqJWLc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4564.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4f7aefd-fd84-4deb-922a-08da9549c169 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 05:35:23.6262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kwbQ3pHOnhbXMU/FFn13YugrVZoOnsSXhfDI/HWCypQFLYnDF5ry6fciKa5PVIBt1pfPdKmIHW1sIuvRvwQyIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5234 [AMD Official Use Only - General] Hi Stefano, https://elixir.bootlin.com/linux/v5.16/source/mm/gup.c#L975 is the -EFAULT = returning for our current use case. access_ok is fine. Regards, Jeshwanth -----Original Message----- From: Stefano Stabellini =20 Sent: Tuesday, September 13, 2022 6:56 AM To: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) Cc: Stabellini, Stefano ; boris.ostrovsky@oracl= e.com; xen-devel@lists.xenproject.org; NK, JESHWANTHKUMAR (JESHWANTH KUMAR)= ; Rangasamy, Devaraj ; Pandeshwara krishna, Mythri ; SK, Siv= aSangeetha (Siva Sangeetha) ; Thomas, Rijo-john <= Rijo-john.Thomas@amd.com>; jgross@suse.com Subject: Re: Linux pin_user_pages_fast fails on Xen On Sat, 10 Sep 2022, Juergen Gross wrote: > On 09.09.22 22:25, Stefano Stabellini wrote: > > On Fri, 9 Sep 2022, Juergen Gross wrote: > > > On 09.09.22 04:11, Stefano Stabellini wrote: > > > > Adding more people in CC > > > >=20 > > > > On Thu, 8 Sep 2022, Stefano Stabellini wrote: > > > > > Hi Juergen, > > > > >=20 > > > > > A colleague is seeing a failure on x86 in Linux Dom0. The=20 > > > > > failure is pin_user_pages_fast with addresses that correspond=20 > > > > > to foreign memory > > > > > pages: > > > > >=20 > > > > > - QEMU maps a domU address using dma_memory_map=20 > > > > > (xen_map_cache) > > > > > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Addre= ss > > > > > returned by dma_memory_map > > > > > - Linux tee_shm_register->pin_user_pages_fast Returns -14 -=20 > > > > > drivers/tee/tee_shm.c > > > > >=20 > > > > > Once upon a time it used to be the case that=20 > > > > > get_user_pages_fast would fail on Xen because we didn't have a=20 > > > > > struct page corresponding to foreign memory mappings. But that ha= sn't been the case for years now. > > > > >=20 > > > > > Any other ideas why it would fail? > > >=20 > > > I think we can expect that access_ok() isn't failing. > > >=20 > > > I assume the mapping was done allowing writes (sorry for paranoia mod= e)? > > I was told it was verified: QEMU could read and write to the VA=20 > > returned by dma_memory_map. From /proc//maps, the VA=20 > > assigned after the mapping is pointing to /dev/xen/privcmd. > >=20 > >=20 > > > Other than that I'm not having enough memory management skills. It=20 > > > might be related to mmap()-ed foreign pages having _PAGE_SPECIAL=20 > > > set, though. > >=20 > > Do we still set PAGE_SPECIAL for foreign mapped pages? It looks like=20 > > it is not there anymore? If PAGE_SPECIAL is not there, then they=20 > > really should look like regular pages? >=20 > See the call of pte_mkspecial() in remap_area_pfn_pte_fn() (mmu_pv.c). The kernel version is 5.16 and the return code is -EFAULT. Is it the follow= ing -EFAULT the one that triggers? mm/gup.c:internal_get_user_pages_fast: if (unlikely(!access_ok((void __user *)start, len))) return -EFAULT; From xen-devel-bounces@lists.xenproject.org Tue Sep 13 06:22:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 06:22:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406161.648561 (Exim 4.92) (envelope-from ) id 1oXzJY-0007ff-5U; Tue, 13 Sep 2022 06:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406161.648561; Tue, 13 Sep 2022 06:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXzJY-0007fY-2c; Tue, 13 Sep 2022 06:22:32 +0000 Received: by outflank-mailman (input) for mailman id 406161; Tue, 13 Sep 2022 06:22:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oXzJW-0007fS-LC for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 06:22:30 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2042.outbound.protection.outlook.com [40.107.96.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7086b4e7-332c-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 08:22:28 +0200 (CEST) Received: from DM6PR12MB4564.namprd12.prod.outlook.com (2603:10b6:5:2a9::18) by SJ0PR12MB5612.namprd12.prod.outlook.com (2603:10b6:a03:427::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 13 Sep 2022 06:22:23 +0000 Received: from DM6PR12MB4564.namprd12.prod.outlook.com ([fe80::d0bb:4d4d:7767:19fd]) by DM6PR12MB4564.namprd12.prod.outlook.com ([fe80::d0bb:4d4d:7767:19fd%7]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 06:22:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7086b4e7-332c-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FW2Ggso/t2NevcsLRnbP8gLOBz0PzGzpQAH9D+V5UfOtZtee/fgpgfwPfekCEub91I+ATvlJBs/SNQV6pXxrYdZusGG5QCvT0MGlJ3Ft7BsBchvWtIgzWy6AQko1HgswCtZCH3JU//2OZ82+EOjaToiktydCGViNsiXzU+BPnIJaK431cg9m1E4wnt8LYD82CDbBTSQ9zJcNNkL4H/b7wYMylKXrVJI07vtoregw5dwGv7UKrj7IC9W2goP02nuwQFjgj0Fz8Xl98Jk1Gp9VW9B8ecXkWxPC45VFNHidv0pYN5xVAsDQ5v5SUDA8be9JtQCPTnFnntY1b2hM040RnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eeI2GHQoSQJ/z4bhyVAn5nh3VxtQLjdiG+MncCbq/GQ=; b=b6zpixlotxnTfy4cOdBBx+ViFGv13oKZXskU1cy/bztK3sFqF/1nLuKX9oBajhW2AabSNI6lMrHARwNZw9DqYqCYTCK3uRHXmcdOlyqBWzrizEu9pRhwUw8ts0h21gnewT1c2QMB78vqljoEB3XIlrNmRrmJn5wlYpguoVSbK0SzAoRgc11n7VUTtenuzCTavacWc/bObXRz4Jo/awv/iviS3QZ1RmVBdHsVDuzA8wJuYgUzPPPJ/YUV44+pMVdhH3tOg5QZbMquhxFsnFUSu6VKgHp409UA9ZN9Y3xe3Qw9QVYOTb23X8JXynb1/otXiByJ1nRzbhJV9cxNgNBPxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eeI2GHQoSQJ/z4bhyVAn5nh3VxtQLjdiG+MncCbq/GQ=; b=zERWJeCN2BdHNIPmx53q6k7NuRGGpf/EIBp4oEMRw48uwLMTlG8EU/+8Nh9if/cWLaAne0eTrcVnN/Cg4TCH6MfHSNyj3c58NbxIV4zVuHLK6vNmYtogvZHZEjLhkNa8rpBBTNTi2tGQaZC1YT03J1DeNHQ0HCviKIl+WNUMe/s= From: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" To: "Stabellini, Stefano" CC: "Stabellini, Stefano" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" Subject: RE: Linux pin_user_pages_fast fails on Xen Thread-Topic: Linux pin_user_pages_fast fails on Xen Thread-Index: AQHYw/FtbHk6dXjix0qU8E4gYrQhY63WppaAgADmKYCAAIgNAIAEgvEAgABFGKCAAA00AA== Date: Tue, 13 Sep 2022 06:22:23 +0000 Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-13T05:35:20Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ac6f7c04-2fd4-4892-9f5a-0d147769eed1; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_enabled: true msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_setdate: 2022-09-13T06:22:21Z msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_method: Standard msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_name: General msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_actionid: fe0e37e6-7c22-4e1c-9278-1114ea80da6d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4564:EE_|SJ0PR12MB5612:EE_ x-ms-office365-filtering-correlation-id: 57af4fc0-7c8f-4d97-7ee8-08da95505251 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jDb1dRHoJCV1Kg4+n1HSjQqp0gHDkztox7zwxTmVDyKA+0IAXewhU9Igs506OBziQnbiK1nr3/OZAXJ/Lp7ITu59N5wu1qdXC5H5Ym7NMqU3yeWpmF84KX4+pnMc/UHHOyPXeCmL0Pk2vUzXqbKTYkUyUXu4URs0DDmgkVFyJxaoo6E/9A6IzryIuXwteEpceJC4Vd1o9NUPohTr8mzY5ZUT6Cnz9PUzh1vLpyLRI2OqnhB8wsFbIsTbHEaYNQO2BSUu8jU13AVinxpVJ3mwM8srYvKnGw1TVX/nVF6k9OCbNsD4O+hJUW96I9BNdn1kc64V5JkzCjBFVMYBNwNo6ei3ewDlnveQ1H2WDmen2xzfVLscoSn6QiZajf/0GxhOZmVErBdq+8VgQ9UL6XaScV/0Vg1lMkIf2J/0jdHOGaBqZqZDnLaDZ6FebYu+MWPUxLjK861VYSx9aoMZmA0ZQp29FLjY1o+3okZckUNH9SIFKh6LyKQ2/oeYnmwqPxlHW2AFXdFI2ENyu4lGiS9QxKyl+3Oa2owQJwwd7Pi21VFJu+Q9YmpwQ8cd01SXq8ZPtzZReRgET9R2AqAtsb4fF8GUc7gKsD6IY9/oxJtVv1lymxVLeCmQ36tD9SyXxD55YfM2+hMRf5YPoixdPKS0vjbBPCypR/uBbAiZ6bDR3rkBHQOMqNIArgqD20o8lzoxm8WMaFj+kAcqorkr2F8++8owKUHBNrHNIYXKadlOdAHzfONWBa3o2858OiyVNuDSOD3jlE1coJHbRHLJr8X7ywt5GypbsykI9vGnz8FgG5Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4564.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(346002)(136003)(366004)(451199015)(4326008)(66556008)(66446008)(66946007)(8676002)(76116006)(66476007)(64756008)(5660300002)(6862004)(9686003)(966005)(38070700005)(6636002)(316002)(26005)(86362001)(54906003)(38100700002)(71200400001)(52536014)(33656002)(186003)(55016003)(6506007)(122000001)(7696005)(41300700001)(83380400001)(2940100002)(478600001)(2906002)(8936002)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7ewNgkvPqtJrvI3f6qnmoNkLgALgdUQJkb85P4SzUtCVG2eBA3AYRgPu2O9b?= =?us-ascii?Q?qpNDQyWYdz9UvF/mCzwQ9bDxLmq5dbHjFrS627/KuJop+63gTU2ShfVq4ebL?= =?us-ascii?Q?lWnODDG3O6xyjKUr5AnzfkoL2o1GEn8AIHNMqfEUtZhFAzs6O7C/PJVA0zJX?= =?us-ascii?Q?jZckVDRVTYQh/3YpIYINR5IBOK4HqhfHlq6huajNqWfxYhCQX0FRbPKTTrne?= =?us-ascii?Q?Awo8A4kCgBLWvsFOFHYqr+jbmIK7rAW6YfGE5GO0tuZBJjUVqq6x0AOtmMyr?= =?us-ascii?Q?hFZ18wpMuZfezykg3zR7xk9LSZCnfajVtswqcTQdnX5kYb59VTwK84iiXNXh?= =?us-ascii?Q?tHA0B3iK9fq9ltMySZnx1Qqvew+xO4ybEVl8szjLN3XeU1gEhf71yezUnDvT?= =?us-ascii?Q?Ywpnxu4G1P91SDyce0wdS3cpsOPzps01wWYwUsWs/Ufe/wgHj3ScyIYg6WBR?= =?us-ascii?Q?pMj1z65OtDmDGBAwlYpBc/z8Fp1bD/XezzJr/8V5wjhlPXo+PfGrtPxiiEd5?= =?us-ascii?Q?T7Oma0Db41ZG1LYLU1ESYcbU/4Rp6FSkfAG3Y6jjSV3CYrkbjEnKrpzSnbzD?= =?us-ascii?Q?KzCS+eFGsUIofkuAyEc17wjr/ZT55B5TTPV2MLGg7L78oO7ibMNnAGtMsRWt?= =?us-ascii?Q?3mj2Qw8kgNSK1DPFW+QIVO81BkpAs1eWmbxrxVEOm5yORqVmeWGGpO4//0iu?= =?us-ascii?Q?WxRsb4RggQ6zpctgsRezoG0kQ8Gk7yVo1fa8D1SetZTtekTPYX3C97sNySQv?= =?us-ascii?Q?mcTOs7x3Fj0txYGlz9fgzMyLICRI/ebne5tsWgEu5xNLH7CBMxLWu+mrse+2?= =?us-ascii?Q?S3SDwRo9uxIilh8nckpZ6ZklHcHlocJaZ0i2rpNNyvdJ2Nzg/IqXlF5nH1LC?= =?us-ascii?Q?ELHiouDOZfVmAQKGiZ44Uf8wfxA8pcnOJhcn5498xB4RtmgxeoPDg74qxkC/?= =?us-ascii?Q?ctGtWkuqPv8U3nZzcAAEAnFpT0qN8hw2/6g1sEx0wi0AYzld23egLa5gfsXq?= =?us-ascii?Q?IaIZiEzYfHxfx0/GJzlivqy7h41cq/MWN/GHmy+rZiuGzKO7KJw3oxs9yHNQ?= =?us-ascii?Q?S4jcrHtfQO0unpqg6AW3V2HJVdOJaRpBs7KGUnvXiFyQTc8TUGNak9UgfLGy?= =?us-ascii?Q?IcHD8Bv8vihfVAuTaBN3E8oOKwKPToCRCQ20g09nMsTq0nnC3zq81x78fyls?= =?us-ascii?Q?hwpokJBJRzJIuD+7q7J8It6F39neGEQyxyogT+mixmQQhx181A3QcDyG5+EE?= =?us-ascii?Q?XVbbNs5bX5CJ8mr3UKSDhJxkvznV9sazVq2mAFaUZpw4Yu1pyiS0G5Rdi1Gd?= =?us-ascii?Q?BZGRzLrzYgHFJA5w0v4rG/AvwQVHkfiYThqOwBTRZcM4KMWiemIMQBXJp6oE?= =?us-ascii?Q?tIPwa8ZAjePm2m1znvXJ/lIJkyHEULdDSyvFqDCZxtGPbbFz/MLnPF5LwZzU?= =?us-ascii?Q?WkwwXlIL1spb6N208S4Yjf9iHKgwau+KnsX8clQX2Ym9h7D+CXxdkyvl7DN7?= =?us-ascii?Q?Ztd1BMcn13GnTRY9M9GAuERNLSl0wlQNhY5jqfMH4o1B7JMYfT/5wANODU5a?= =?us-ascii?Q?M4zQp5VxloBjoKA6Gpo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4564.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57af4fc0-7c8f-4d97-7ee8-08da95505251 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 06:22:23.7185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mrDYBMjIuDlr0SWmJWmnErHkY9z/oi0YsqJrhAWT2Ahb9VQichtTWVjhXVP7zhP/g7+cqK/fa0BT0KkxyDRtRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5612 [AMD Official Use Only - General] Missed to update the Flag details: Flag for DMA Mapped VA - 0x0C0644BB Flag for Local VA - 0x08100073 VM_IO and VM_PFNMAP - Set in DMA mapped VA but not in local VA. Regards, Jeshwanth -----Original Message----- From: NK, JESHWANTHKUMAR (JESHWANTH KUMAR)=20 Sent: Tuesday, September 13, 2022 11:05 AM To: 'Stefano Stabellini' Cc: Stabellini, Stefano ; boris.ostrovsky@oracl= e.com; xen-devel@lists.xenproject.org; Rangasamy, Devaraj ; Pandeshwara krishna, Mythri = ; SK, SivaSangeetha (Siva Sangeetha) ; Thomas, Ri= jo-john ; jgross@suse.com Subject: RE: Linux pin_user_pages_fast fails on Xen [AMD Official Use Only - General] Hi Stefano, https://elixir.bootlin.com/linux/v5.16/source/mm/gup.c#L975 is the -EFAULT = returning for our current use case. access_ok is fine. Regards, Jeshwanth -----Original Message----- From: Stefano Stabellini Sent: Tuesday, September 13, 2022 6:56 AM To: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) Cc: Stabellini, Stefano ; boris.ostrovsky@oracl= e.com; xen-devel@lists.xenproject.org; NK, JESHWANTHKUMAR (JESHWANTH KUMAR)= ; Rangasamy, Devaraj ; Pandeshwara krishna, Mythri ; SK, Siv= aSangeetha (Siva Sangeetha) ; Thomas, Rijo-john <= Rijo-john.Thomas@amd.com>; jgross@suse.com Subject: Re: Linux pin_user_pages_fast fails on Xen On Sat, 10 Sep 2022, Juergen Gross wrote: > On 09.09.22 22:25, Stefano Stabellini wrote: > > On Fri, 9 Sep 2022, Juergen Gross wrote: > > > On 09.09.22 04:11, Stefano Stabellini wrote: > > > > Adding more people in CC > > > >=20 > > > > On Thu, 8 Sep 2022, Stefano Stabellini wrote: > > > > > Hi Juergen, > > > > >=20 > > > > > A colleague is seeing a failure on x86 in Linux Dom0. The=20 > > > > > failure is pin_user_pages_fast with addresses that correspond=20 > > > > > to foreign memory > > > > > pages: > > > > >=20 > > > > > - QEMU maps a domU address using dma_memory_map > > > > > (xen_map_cache) > > > > > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Addre= ss > > > > > returned by dma_memory_map > > > > > - Linux tee_shm_register->pin_user_pages_fast Returns -14 -=20 > > > > > drivers/tee/tee_shm.c > > > > >=20 > > > > > Once upon a time it used to be the case that=20 > > > > > get_user_pages_fast would fail on Xen because we didn't have a=20 > > > > > struct page corresponding to foreign memory mappings. But that ha= sn't been the case for years now. > > > > >=20 > > > > > Any other ideas why it would fail? > > >=20 > > > I think we can expect that access_ok() isn't failing. > > >=20 > > > I assume the mapping was done allowing writes (sorry for paranoia mod= e)? > > I was told it was verified: QEMU could read and write to the VA=20 > > returned by dma_memory_map. From /proc//maps, the VA=20 > > assigned after the mapping is pointing to /dev/xen/privcmd. > >=20 > >=20 > > > Other than that I'm not having enough memory management skills. It=20 > > > might be related to mmap()-ed foreign pages having _PAGE_SPECIAL=20 > > > set, though. > >=20 > > Do we still set PAGE_SPECIAL for foreign mapped pages? It looks like=20 > > it is not there anymore? If PAGE_SPECIAL is not there, then they=20 > > really should look like regular pages? >=20 > See the call of pte_mkspecial() in remap_area_pfn_pte_fn() (mmu_pv.c). The kernel version is 5.16 and the return code is -EFAULT. Is it the follow= ing -EFAULT the one that triggers? mm/gup.c:internal_get_user_pages_fast: if (unlikely(!access_ok((void __user *)start, len))) return -EFAULT; From xen-devel-bounces@lists.xenproject.org Tue Sep 13 07:54:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 07:54:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406174.648571 (Exim 4.92) (envelope-from ) id 1oY0kS-0000z5-Pi; Tue, 13 Sep 2022 07:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406174.648571; Tue, 13 Sep 2022 07:54:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY0kS-0000yy-N2; Tue, 13 Sep 2022 07:54:24 +0000 Received: by outflank-mailman (input) for mailman id 406174; Tue, 13 Sep 2022 07:54:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY0kR-0000ys-0f for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 07:54:23 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2088.outbound.protection.outlook.com [40.107.237.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45cbd9bb-3339-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 09:54:20 +0200 (CEST) Received: from DS7PR05CA0050.namprd05.prod.outlook.com (2603:10b6:8:2f::9) by DM4PR12MB7549.namprd12.prod.outlook.com (2603:10b6:8:10f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Tue, 13 Sep 2022 07:54:16 +0000 Received: from DM6NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::af) by DS7PR05CA0050.outlook.office365.com (2603:10b6:8:2f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.10 via Frontend Transport; Tue, 13 Sep 2022 07:54:16 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT004.mail.protection.outlook.com (10.13.172.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 07:54:16 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 02:54:14 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 02:54:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45cbd9bb-3339-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzTaOjRDjv9YWHOi6Yx4TVBofJ8rs8rKJCE7BkgVf/e6H5DEj0lYNmNDB6KrSJ30OAfVQHejjhcGY17I/e+PzxmgXfKg8HjNI5uLYHSe0ljXIX2ghtVnYkGV47/VGGuvKmWPwREzgWjyFQxBJ6oqdX1VuNGqVdLSEPNnaYFcDBddgYeS24A7425LBJNeDrBQsqGaG1itrfNVbbVtnN8vU6qI9iFp9B/uPBADW/6yy4jLZxmLDveaO9Zf0mY3+c/EBUmd9babbaXp1lE/dmICsoIFCHHlME5y0y+b8dLq7a/sHheltgHZ48D0kUt5CY+FBQcpgc+qaKGNJ3MaNcq89w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tiJ79U++0AcWuLpxbjDCIB1xyDR746SiRPXyj0e/xX8=; b=mq4dzxebfamloLTqGzMsLU/jjHK4Uip1fePmWqh41EyscgyGLuWpVWdlmYFB3YdcdjCOFB2NbOWNXw9wAIltgWm2SQmBmHmzgYX8yEboQ8vGsVGe5kVY2rGXni/0clJJOqTuKyUA4nXg+ahifQTN2OP/FH+hBQ3ky0JcDBftR/8mVLfU70nOPzJ0JFTBVZN3U4M3vCmqsd9chQ+J6fEAPo0Jw099SoW7MzfPEtVuOfpAtgaE76CPLcmaCwf8APkiER7xuI5XRD0KZsp1YCsDTLaSDZDRGOXuHyBL2/FVeJCye9fDER36i84PLpZuQPWWKlZD4ft8fGQuZqJTAqKUwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tiJ79U++0AcWuLpxbjDCIB1xyDR746SiRPXyj0e/xX8=; b=3V/7ayVo7c0RsyuPuGpzT7LPY5Nv3cW3S0SGpWm97gp3/Hu/GqDzZYpxCCkkNhzvbw+NKNs5Ks8/BoU354mazbq7OZq1gbvY36499QaJjDWogqNVaIxUD5iSUOgU87qCm83kYFw02lgMLruBhPMfu7mqgqPkDvOq/V84BKVTB1A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <57721e49-1692-64ec-92b1-ce393b79e070@amd.com> Date: Tue, 13 Sep 2022 09:54:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [ImageBuilder 2/2] Add support for lopper to generate partial dts Content-Language: en-US To: Stefano Stabellini CC: References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-3-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT004:EE_|DM4PR12MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 83d38a07-e7bd-4189-6618-08da955d2833 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: swyQeszxxTijeZ/RdR7BltET0QxhT7jxw5fcd8EFVMrZYI0Ge4VYYQ7ncfhwFnsddLrYY974RpKTCgdcdqi1CTYZMPZlal+jafJA9Gc5ll8FLAHAucD2oWf8NDCvhLwmIW4JylgZf8a1dfDptHD9EOFx54tji8c3tHGR6e3/667vEWLV45X9WMfGF/z+iPUCxQBBsDwfxwhRqUjY5/JVQ1tUzPZLQtGASmiw7JilLmhb60poCAa79VKEQRYvadM8WTn8qgw0GNlBhR44ivI976iLnyul0aKvK/JJdeM5QaFp8NrnB0Z1urlVocb09E1cWtLg5aUiHVV1yaTki1cWfr3CB5J3HdsxyPVf87tWscHJLJufVx9e5f1SP06mBsCPA8BCBhC6zpmG12zCqQRFpzYYTB9xShvPYZlGPrTePMkF0n3V3xZGAkJqfPLFVdUeyjxmA8wUW6BWk4DoPIRrZOYiKJplZ9n2N6As2/8YHfJJyE+LBzuSn4VNj6BeXmCiz7/J19l0s4aVFa7lnDd7H8L1xGauzU3pWKLEQ4zxjE3QbEsFtgAEiEoWdUN80V/XR7fs+sNkFt3eZ0yG2iP/7lOp5mzrW44S0IBCaV0zKIdgQVzi+3p9aA2wUw9CoHsoRG80/8fPl3ikJjOioPvyDKo+h+HUPXtdzNTNKBmWGyvEzPVqegPgKKpmxMYTF3oPB+yDgUAds2A5HePp+fsFgpN9YdXyxymZiLYHD7FhT25qSIhrc1L0Fpjmqv1cl28fKqbz4l8672wkv1hEm452r2jT4ulpDk+vWp2goppvj7xsTIU5x+ucTE/IzXBDViJWN60aApEikorj2/bbLfncbEixwS92CuS4gmRtphzz1ouLDhSs0Q/uII6QOwlUNEUrJPTQQvbBPiQVoczd2PNqUg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(53546011)(6916009)(8936002)(81166007)(5660300002)(316002)(966005)(31696002)(83380400001)(45080400002)(82310400005)(186003)(16576012)(26005)(41300700001)(478600001)(2616005)(4326008)(8676002)(82740400003)(40460700003)(36756003)(356005)(36860700001)(86362001)(426003)(44832011)(336012)(31686004)(70586007)(47076005)(2906002)(70206006)(40480700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 07:54:16.4363 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83d38a07-e7bd-4189-6618-08da955d2833 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7549 Hi Stefano, On 13/09/2022 03:13, Stefano Stabellini wrote: > > On Mon, 12 Sep 2022, Michal Orzel wrote: >> Currently ImageBuilder can compile and merge partial dts obtained from >> a repository specified using PASSTHROUGH_DTS_REPO. With the recent >> changes done in the lopper, we can use it to generate partial dts >> automatically (to some extent as this is still an early support). >> >> Introduce LOPPER_PATH option to specify a path to a lopper.py script, >> that if set, will invoke lopper to generate partial dts for the >> passthrough devices specified in DOMU_PASSTHROUGH_PATHS. >> >> Introduce LOPPER_CMD option to specify custom command line arguments >> (if needed) for lopper's extract assist. >> >> Example usage: >> LOPPER_PATH="/home/user/lopper/lopper.py" >> DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" > > Is lopper.py this file? > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Flopper%2Fblob%2Fmaster%2Flopper.py&data=05%7C01%7Cmichal.orzel%40amd.com%7Cb756682b3b0a460f5c3608da95252c7c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637986284138713501%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=KShbbVjvB1vG26vUQL6py7edWylpoZ63n5BW11dxbmo%3D&reserved=0 > > If so, it would be good to specify in the README that this is not just > an arbitrary lopper.py script, but the main entry point of Lopper as a > project. For instance: > > --- > Introduce LOPPER_PATH option to specify a path to a lopper.py script, > the main script in the Lopper repository > (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Flopper&data=05%7C01%7Cmichal.orzel%40amd.com%7Cb756682b3b0a460f5c3608da95252c7c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637986284138713501%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vEh2VZz84MQiZJnKyGzGejJ7QKO%2FYENwg1v4XdF8PRk%3D&reserved=0). If set, .... > --- > Sounds good. I will add this explanation. > >> Signed-off-by: Michal Orzel >> --- >> README.md | 22 ++++++++++++-- >> scripts/common | 64 ++++++++++++++++++++++++++++++---------- >> scripts/uboot-script-gen | 17 +++++++++-- >> 3 files changed, 83 insertions(+), 20 deletions(-) >> >> diff --git a/README.md b/README.md >> index da9ba788a3bf..aaee0939b589 100644 >> --- a/README.md >> +++ b/README.md >> @@ -128,6 +128,19 @@ Where: >> - DT_OVERLAY[number] specifies the path to the hosts device tree overlays >> to be added at boot time in u-boot >> >> +- LOPPER_PATH specifies the path to lopper.py script. This is optional. >> + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need >> + to be specified. uboot-script-gen will invoke lopper to generate the partial >> + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. >> + This option is currently in experimental state as the corresponding lopper >> + changes are still in an early support state. >> + >> +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. >> + This is optional and only applicable when LOPPER_PATH is specified. Only to be >> + used to specify which nodes to include (using -i ) and which >> + nodes/properties to exclude (using -x ). If not set at all, the default >> + one is used applicable for ZynqMP MPSoC boards. >> + >> - NUM_DOMUS specifies how many Dom0-less DomUs to load >> >> - DOMU_KERNEL[number] specifies the DomU kernel to use. >> @@ -140,7 +153,7 @@ Where: >> - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( >> separated by spaces). It adds "xen,passthrough" to the corresponding >> dtb nodes in xen device tree blob. >> - This option is valid in the following two cases: >> + This option is valid in the following cases: >> >> 1. When PASSTHROUGH_DTS_REPO is provided. >> With this option, the partial device trees (corresponding to the >> @@ -149,7 +162,12 @@ Where: >> Note it assumes that the names of the partial device trees will match >> to the names of the devices specified here. >> >> - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only >> + 2. When LOPPER_PATH is provided. >> + With this option, the partial device trees (corresponding to the >> + passthrough devices) are generated by the lopper and then compiled and merged >> + by ImageBuilder to be used as DOMU[number] device tree blob. >> + >> + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only >> add "xen,passthrough" as mentioned before. >> >> - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees >> diff --git a/scripts/common b/scripts/common >> index ccad03d82b30..680c5090cd07 100644 >> --- a/scripts/common >> +++ b/scripts/common >> @@ -9,6 +9,9 @@ >> # - NUM_DOMUS >> # - DOMU_PASSTHROUGH_PATHS >> # - DOMU_PASSTHROUGH_DTB >> +# - LOPPER_PATH >> +# - LOPPER_CMD >> +# - DEVICE_TREE >> >> tmp_files=() >> tmp_dirs=() >> @@ -99,31 +102,41 @@ function compile_merge_partial_dts() >> local tmp >> local tmpdts >> local file >> + local node >> local i >> local j >> >> - if [[ "$repo" =~ .*@.*:.* ]] >> + if test "$repo" >> then >> - tmp=`mktemp -d` >> - tmp_dirs+=($tmp) >> - >> - echo "Cloning git repo \"$git_repo\"" >> - git clone "$repo" $tmp >> - if test $? -ne 0 >> + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO >> + if [[ "$repo" =~ .*@.*:.* ]] >> then >> - echo "Error occurred while cloning \"$git_repo\"" >> - return 1 >> - fi >> + tmp=`mktemp -d` >> + tmp_dirs+=($tmp) >> >> - repo=$tmp >> - fi >> + echo "Cloning git repo \"$git_repo\"" >> + git clone "$repo" $tmp >> + if test $? -ne 0 >> + then >> + echo "Error occurred while cloning \"$git_repo\"" >> + return 1 >> + fi >> >> - if test -z "$dir" >> - then >> - dir="." >> + repo=$tmp >> + fi >> + >> + if test -z "$dir" >> + then >> + dir="." >> + fi >> + partial_dts_dir="$repo"/"$dir" >> + else >> + # Partial dts will be generated by the lopper >> + tmp=`mktemp -d` >> + tmp_dirs+=($tmp) > > setting tmp and tmp_dirs can be moved outside of the if > Ok. > >> + partial_dts_dir="$tmp" >> fi >> >> - partial_dts_dir="$repo"/"$dir" >> i=0 >> while test $i -lt $NUM_DOMUS >> do >> @@ -133,6 +146,25 @@ function compile_merge_partial_dts() >> return 1 >> fi >> >> + if test -z "$repo" >> + then >> + # Generate partial dts using lopper >> + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} >> + do >> + node=${devpath##*/} >> + file="$partial_dts_dir"/"$node".dts > > This is a minor NIT. As we do below: > > file=${devpath##*/} > file="$partial_dts_dir"/"$file".dts > > Can you change the code below to use node and file as you do here for > consistency? > Sure, I will modify them. ~Michal From xen-devel-bounces@lists.xenproject.org Tue Sep 13 08:16:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 08:16:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406191.648583 (Exim 4.92) (envelope-from ) id 1oY15p-0004Sw-66; Tue, 13 Sep 2022 08:16:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406191.648583; Tue, 13 Sep 2022 08:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY15p-0004Sp-1p; Tue, 13 Sep 2022 08:16:29 +0000 Received: by outflank-mailman (input) for mailman id 406191; Tue, 13 Sep 2022 08:16:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY15n-0004Sf-SJ; Tue, 13 Sep 2022 08:16:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY15n-0000gj-RC; Tue, 13 Sep 2022 08:16:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY15n-0004y8-Ij; Tue, 13 Sep 2022 08:16:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY15n-0000C4-ID; Tue, 13 Sep 2022 08:16:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HeIlX/AuD6wvmiXRyozIBd+z/lbnpsQPV5HtPwhw59g=; b=3z7V+7Hn02gV7Al7zI3DaHWNOw W1JGL7YAtcwt00nLFcaPoskDK1l91s08E9CE7xWfzFRs1nyNNrFCgdmgeEp4L5U37VpLQWwiDbV0k Kzw5STS8pzWWsoTEVqCNHQm6o8XoOToSt4uOJKO1yjHggsgboF3i9d+fQya2IO3gVApU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173163: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=970e26294905d2d27369cf4041c6778105754f5e X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 13 Sep 2022 08:16:27 +0000 flight 173163 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173163/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 970e26294905d2d27369cf4041c6778105754f5e baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 40 days Failing since 172151 2022-08-05 02:40:28 Z 39 days 300 attempts Testing same since 173112 2022-09-10 10:12:05 Z 2 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2470 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 08:43:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 08:43:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406202.648594 (Exim 4.92) (envelope-from ) id 1oY1W3-00082X-Dg; Tue, 13 Sep 2022 08:43:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406202.648594; Tue, 13 Sep 2022 08:43:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1W3-00082Q-At; Tue, 13 Sep 2022 08:43:35 +0000 Received: by outflank-mailman (input) for mailman id 406202; Tue, 13 Sep 2022 08:43:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1W2-00082G-Ev; Tue, 13 Sep 2022 08:43:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1W1-000176-MM; Tue, 13 Sep 2022 08:43:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1W1-0006YH-6S; Tue, 13 Sep 2022 08:43:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY1W1-0000M5-5y; Tue, 13 Sep 2022 08:43:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lJFWGZOTAOhV2c7q7wB/X3Xagg3l/6qMR2tdA1ndRGU=; b=q0w4uUwrBEQIkfhQyp3n364Ess 6OR/9U17hZcGX95HWlI65JGoAqUrTdH/G6LLCLrr9FLR7FDumFpIw3j56ISUBLFpUeXP33s/dh4N/ 09PWGlcZJwAyoToGMSvKX/aE1jwT2k3UHK/jjpo/jpYCcN50uczzrISfZdRuq949sCLg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173158: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Tue, 13 Sep 2022 08:43:33 +0000 flight 173158 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173158/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 40 days Failing since 172384 2022-08-11 11:13:58 Z 32 days 70 attempts Testing same since 173008 2022-09-05 15:47:43 Z 7 days 16 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 09:04:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 09:04:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406213.648605 (Exim 4.92) (envelope-from ) id 1oY1q4-0002I4-4Z; Tue, 13 Sep 2022 09:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406213.648605; Tue, 13 Sep 2022 09:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1q4-0002Hx-1t; Tue, 13 Sep 2022 09:04:16 +0000 Received: by outflank-mailman (input) for mailman id 406213; Tue, 13 Sep 2022 09:04:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1q2-0002Hn-LB; Tue, 13 Sep 2022 09:04:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1q2-0001TT-GN; Tue, 13 Sep 2022 09:04:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1q1-0007zX-Rv; Tue, 13 Sep 2022 09:04:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY1q1-0005qU-RS; Tue, 13 Sep 2022 09:04:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ivf/cDiVxYsBr0eEUGack1SbjiiZHwWKoT1BfAodCNw=; b=SJ/gyefavNwhJMbJPwsWLbUA9p gPM5CpgAeYNlBuwKbfHb5Q8qdOY0LqC49ZsekDA8gLqU3bSADk0yhpOipR5dQUuGgp8+koBzicliv XmEcxDksMXCSpBG4rakwThxkFQ4rTvkKdZ+jzC4R6L1Fg5bXIb18f7Fe1YKy5lnIg7bM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173164: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=d3397885d589c25b8962ae221fd0a71ced5597cb X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 13 Sep 2022 09:04:13 +0000 flight 173164 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173164/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt d3397885d589c25b8962ae221fd0a71ced5597cb baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 795 days Failing since 151818 2020-07-11 04:18:52 Z 794 days 776 attempts Testing same since 173164 2022-09-13 04:20:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122744 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 09:33:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 09:33:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406232.648627 (Exim 4.92) (envelope-from ) id 1oY2I0-0006NE-Pw; Tue, 13 Sep 2022 09:33:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406232.648627; Tue, 13 Sep 2022 09:33:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2I0-0006N5-N6; Tue, 13 Sep 2022 09:33:08 +0000 Received: by outflank-mailman (input) for mailman id 406232; Tue, 13 Sep 2022 09:33:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2Hz-0006MX-KI for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 09:33:07 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 125de643-3347-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 11:33:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 267C95C0F1; Tue, 13 Sep 2022 09:33:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2EB513AB5; Tue, 13 Sep 2022 09:33:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z1kxNlFOIGN6MwAAMHmgww (envelope-from ); Tue, 13 Sep 2022 09:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 125de643-3347-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663061586; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lx6c3891hAGbDFpKqMPhKGwIWWdvpb5PtucMX1OQj20=; b=V7FRTGGCSfXDd7GA62lTqPCmja654fPfHi28hgx4JJ3X0S/jQGkHafuDdBVTXNuLwo/ZKI B9/971Z1/pBw/0zNmddvQnkQWHnJIRQPARDeCblnfP33OqBzQOs+kP7y2sTWNyVzkgNh45 QebKl15vpmHmg55MonKJX+gey77f+tE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/2] xen: add knownalive_domain_from_domid() helper Date: Tue, 13 Sep 2022 11:32:55 +0200 Message-Id: <20220913093256.22880-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220913093256.22880-1-jgross@suse.com> References: <20220913093256.22880-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a helper knownalive_domain_from_domid() returning the struct domain pointer for a domain give by its domid and which is known not being able to be released (its reference count isn't incremented and no rcu_lock_domain() is called for it). In order to simplify coding add an internal helper for doing the lookup and call that from the new function and similar functions. Signed-off-by: Juergen Gross --- V2: - rename helper to knownalive_domain_from_domid() (Jan Beulich) - enhance comment in header (Jan Beulich) - rename internal helper (Julien Grall) --- xen/common/domain.c | 53 +++++++++++++++++++++++++---------------- xen/include/xen/sched.h | 4 ++++ 2 files changed, 37 insertions(+), 20 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 8dd6cd5a8f..35e0dc5139 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -835,25 +835,32 @@ out: return 0; } - -struct domain *get_domain_by_id(domid_t dom) +/* rcu_read_lock(&domlist_read_lock) must be held. */ +static struct domain *domid_to_domain(domid_t dom) { struct domain *d; - rcu_read_lock(&domlist_read_lock); - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); d != NULL; d = rcu_dereference(d->next_in_hashbucket) ) { if ( d->domain_id == dom ) - { - if ( unlikely(!get_domain(d)) ) - d = NULL; - break; - } + return d; } + return NULL; +} + +struct domain *get_domain_by_id(domid_t dom) +{ + struct domain *d; + + rcu_read_lock(&domlist_read_lock); + + d = domid_to_domain(dom); + if ( d && unlikely(!get_domain(d)) ) + d = NULL; + rcu_read_unlock(&domlist_read_lock); return d; @@ -862,20 +869,26 @@ struct domain *get_domain_by_id(domid_t dom) struct domain *rcu_lock_domain_by_id(domid_t dom) { - struct domain *d = NULL; + struct domain *d; rcu_read_lock(&domlist_read_lock); - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); - d != NULL; - d = rcu_dereference(d->next_in_hashbucket) ) - { - if ( d->domain_id == dom ) - { - rcu_lock_domain(d); - break; - } - } + d = domid_to_domain(dom); + if ( d ) + rcu_lock_domain(d); + + rcu_read_unlock(&domlist_read_lock); + + return d; +} + +struct domain *knownalive_domain_from_domid(domid_t dom) +{ + struct domain *d; + + rcu_read_lock(&domlist_read_lock); + + d = domid_to_domain(dom); rcu_read_unlock(&domlist_read_lock); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 557b3229f6..9e9c3d834b 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -737,8 +737,12 @@ static inline struct domain *rcu_lock_current_domain(void) return /*rcu_lock_domain*/(current->domain); } +/* Get struct domain AND increase ref-count of domain. */ struct domain *get_domain_by_id(domid_t dom); +/* Get struct domain known to have reference held or being RCU-locked. */ +struct domain *knownalive_domain_from_domid(domid_t dom); + struct domain *get_pg_owner(domid_t domid); static inline void put_pg_owner(struct domain *pg_owner) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Sep 13 09:33:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 09:33:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406231.648615 (Exim 4.92) (envelope-from ) id 1oY2Hw-00067I-Ig; Tue, 13 Sep 2022 09:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406231.648615; Tue, 13 Sep 2022 09:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2Hw-00067B-Fb; Tue, 13 Sep 2022 09:33:04 +0000 Received: by outflank-mailman (input) for mailman id 406231; Tue, 13 Sep 2022 09:33:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2Hu-000675-Mx for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 09:33:02 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1dcf1ed-3346-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 11:30:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 83D7434A56; Tue, 13 Sep 2022 09:33:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E3A013AB5; Tue, 13 Sep 2022 09:33:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FXfEDUxOIGNzMwAAMHmgww (envelope-from ); Tue, 13 Sep 2022 09:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1dcf1ed-3346-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663061580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/5pLYXZNjCGOsvALaYTumY4Dq6WSSAQIzCShFqFyEVM=; b=BVrOf7dx/BtsZ92d85fLDOvNFv7oqqdYA+SV8Rw8UtVwplG8/CedJ2yiG4qKc7bwUmCp05 tRP4WVTK9BFnE4zM/jy59OCBlXP9vdQEWJt4+G5rItlUmwasCSfKjM+q3oeyRR1zXZdlKJ M5hLnHx99ab9CoZvjcX+IyPlFABEmiw= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 0/2] xen/gnttab: reduce size of struct active_grant_entry Date: Tue, 13 Sep 2022 11:32:54 +0200 Message-Id: <20220913093256.22880-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While looking at the grant table code I thought it should be possible to have a smaller struct active_grant_entry. This approach should only hit transitive grants with some negative performance effect, "normal" grants should be not affected. Juergen Gross (2): xen: add knownalive_domain_from_domid() helper xen/gnttab: reduce size of struct active_grant_entry xen/common/domain.c | 53 +++++++++++++++++++++++++--------------- xen/common/grant_table.c | 13 +++++----- xen/include/xen/sched.h | 4 +++ 3 files changed, 44 insertions(+), 26 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Sep 13 09:33:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 09:33:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406233.648638 (Exim 4.92) (envelope-from ) id 1oY2I6-0006gu-43; Tue, 13 Sep 2022 09:33:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406233.648638; Tue, 13 Sep 2022 09:33:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2I6-0006gl-0m; Tue, 13 Sep 2022 09:33:14 +0000 Received: by outflank-mailman (input) for mailman id 406233; Tue, 13 Sep 2022 09:33:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2I4-0006MX-KT for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 09:33:12 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15b43bcc-3347-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 11:33:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC60434A56; Tue, 13 Sep 2022 09:33:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8515613AB5; Tue, 13 Sep 2022 09:33:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sKg1H1dOIGOQMwAAMHmgww (envelope-from ); Tue, 13 Sep 2022 09:33:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15b43bcc-3347-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663061591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fCT/cuoPBGBD3g7UNXsZEuzKp2LwjEpE8HR7l0u5x5Q=; b=XWLZ7yzP442dEmPKWuPDa4r7Sf53z1Z5qEcTw1vtk49OHlGciYylr4mRFLj7Lk4ae6NBD0 HqFerIkB3T/PfTs9n9i1wYS+P+D/6I+Ks9G/2AXmb8lOaqEGo7nJUBGxQkBHfsOq8sKByx gAcj5M8uzlCXO+h5S/XPfT5myj98O6Y= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/2] xen/gnttab: reduce size of struct active_grant_entry Date: Tue, 13 Sep 2022 11:32:56 +0200 Message-Id: <20220913093256.22880-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220913093256.22880-1-jgross@suse.com> References: <20220913093256.22880-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The size of struct active_grant_entry for 64-bit builds is 40 or 48 bytes today (with or without NDEBUG). It can easily be reduced by 8 bytes by replacing the trans_domain pointer with the domid of the related domain. trans_domain is only ever used for transitive grants, which doesn't have any known users. This reduction will result in less memory usage and (for production builds) in faster code, as indexing into the active_grant_entry array will be much easier with an entry having a power-of-2 size. The performance loss when using transitive grants shouldn't really matter, given the probability that those aren't in use at all. Signed-off-by: Juergen Gross --- V2: - rename trans_domid to src_domid (Jan Beulich) --- xen/common/grant_table.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index fba329dcc2..59342df3b7 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -381,13 +381,13 @@ struct active_grant_entry { }) domid_t domid; /* Domain being granted access. */ + domid_t src_domid; /* Domain granting access. */ unsigned int start:15; /* For sub-page grants, the start offset in the page. */ bool is_sub_page:1; /* True if this is a sub-page grant. */ unsigned int length:16; /* For sub-page grants, the length of the grant. */ grant_ref_t trans_gref; - struct domain *trans_domain; mfn_t mfn; /* Machine frame being granted. */ #ifndef NDEBUG gfn_t gfn; /* Guest's idea of the frame being granted. */ @@ -1095,7 +1095,7 @@ map_grant_ref( act->start = 0; act->length = PAGE_SIZE; act->is_sub_page = false; - act->trans_domain = rd; + act->src_domid = rd->domain_id; act->trans_gref = ref; } } @@ -2494,7 +2494,8 @@ release_grant_for_copy( else { status = &status_entry(rgt, gref); - td = act->trans_domain; + td = (act->src_domid == rd->domain_id) + ? rd : knownalive_domain_from_domid(act->src_domid); trans_gref = act->trans_gref; } @@ -2657,7 +2658,7 @@ acquire_grant_for_copy( !mfn_eq(act->mfn, grant_mfn) || act->start != trans_page_off || act->length != trans_length || - act->trans_domain != td || + act->src_domid != td->domain_id || act->trans_gref != trans_gref || !act->is_sub_page)) ) { @@ -2676,7 +2677,7 @@ acquire_grant_for_copy( act->domid = ldom; act->start = trans_page_off; act->length = trans_length; - act->trans_domain = td; + act->src_domid = td->domain_id; act->trans_gref = trans_gref; act->mfn = grant_mfn; act_set_gfn(act, INVALID_GFN); @@ -2738,7 +2739,7 @@ acquire_grant_for_copy( act->is_sub_page = is_sub_page; act->start = trans_page_off; act->length = trans_length; - act->trans_domain = td; + act->src_domid = td->domain_id; act->trans_gref = trans_gref; act->mfn = grant_mfn; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Sep 13 10:03:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 10:03:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406262.648648 (Exim 4.92) (envelope-from ) id 1oY2ld-0002eT-I4; Tue, 13 Sep 2022 10:03:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406262.648648; Tue, 13 Sep 2022 10:03:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2ld-0002eM-FB; Tue, 13 Sep 2022 10:03:45 +0000 Received: by outflank-mailman (input) for mailman id 406262; Tue, 13 Sep 2022 10:03:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2lb-0002eG-Tq for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 10:03:44 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9bf8100-334a-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 12:01:06 +0200 (CEST) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 06:03:38 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB5139.namprd03.prod.outlook.com (2603:10b6:408:db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 10:03:36 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 10:03:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9bf8100-334a-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663063422; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=btfGOdff9EapJKr9VJRX74+d5kCcGt2TG1OEK/1Z3SI=; b=DDzQ/evPVqli7zothPyLKSup8uMrJzK4eDqQrnV37YvK/bqFI/kQ/l9/ O4iKlkuiw5IqMSjm+pxK8OWenLs4oXGlOeab6vNzciX0VWyxtw/wnQiRM iav3ibA+cwvGK9sGwsd7utybwyR6nR9OFoh3q9uusISmDOPis4hFPK4L/ g=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 80373853 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AipPIsKqbCYSs4l2wigXcyH3dIi5eBgzWbkVVj?= =?us-ascii?q?Yv8NTMMsmFhBT8lAxcf/9W1sqUQdHbeeAXCVZk3hCVqO4JVvnTeZ44iYPQzR?= =?us-ascii?q?kmXdsxA6uyY7/rlrddsHXekj3hHxe+oNu1MEhH6EP2V2voesn31zbTKF3P5I?= =?us-ascii?q?pAmeetEFMGYNeowgvMo14yC6/eO4VRgyjIgKxGXwkDwJ8JjX0IEWMLX+aT3a?= =?us-ascii?q?Vg9QsCzAss/WWxo0/dRSFHuEcXFlUQgl1fNdJm2ezeRf981B2nJeFT9Apeaw?= =?us-ascii?q?9ZMonJRb4FiVk4Epcpx5YXqz70UFrqUadcky1Sp8KkhWR7l+kN8Sqzww3FKt?= =?us-ascii?q?Q676Yr5t4fBp8Wna2TOyNG+ESS+HA9fGNVYzUPWGNMNj5+OqBmmmC10ukFxa?= =?us-ascii?q?YbFAa5cFcxarQ7sFYOmZe/Mzu0zhNXPV7xEZywfk/gxSPFrOUYZOUuBo5g8p?= =?us-ascii?q?iRnbfaqnoXJ4/yTler/KMklzYIQ/uBDC/P70GhttVj0FGQq1Hdw9VlP9YS9S?= =?us-ascii?q?Fslw7Cste5pq433gXR5gCjTSFzWq9noXbdKMCPYj3R+w2vwMFXEasqPdPf37?= =?us-ascii?q?NEfKMeWIaAfT36JV1P9OkheVvtrdZ0xvQCOgl/7ZRDtmNLmc7Mo/bIzBywS4?= =?us-ascii?q?nOkc05QcTuiaCVt85pDA5k8VzKpPWR7K8nI6S8/ndL9EfyU947bxylvvZOm2?= =?us-ascii?q?r8AUnYrZHE7uDvyyeQhLZ0/ipF+CuxPPxtQrCf2w9lj2jmQOq4ci1nDN69pw?= =?us-ascii?q?1n8qwlCJg5JQ4zWv07mQIjQsN2KxWr2lsuSrUfTzv4zMgpxDVSIiZQNlH9/i?= =?us-ascii?q?fbI0NQtFe4cBjin65H4QVlYGSkfV3Hz/6m+KWOSG0m2LTaI+sBgioeZmsW4r?= =?us-ascii?q?R5qFyS93gVQXKRkRkREKZfQB1sJtJ70rPCk75d103tFiJUC/bCCNTw48IJzd?= =?us-ascii?q?BSlaycoro0vBiEnWzXmX0ZUz9VFGWRPwvRxZccmReUs7w/Nto42PaAF9dM2q?= =?us-ascii?q?0i5Krp2mO9gIDOiXqq4VLTu8M8U+NrNZKMsT6HMNySWSyk8NCR4/9ApJ/Hae?= =?us-ascii?q?1XO6AxBrD5S5c64Qj4mJSSpFG8Ha47NkteAEtaNBAyD1sLRo4ATA0KDC3mwM?= =?us-ascii?q?szQHBJ5vpSJQr+6eXyhBEsKU/JhiSeYM3e5FJU2Bry0j/pso80tKSVy6lr0n?= =?us-ascii?q?BAEyE30QETs0Sxpg2jXLgCW4CJo6843VfQjyWANsYCm7AK13/R5lrTKf3/AH?= =?us-ascii?q?GIi6LLJ+BS0lblroCMW6jf5GZvdCo3vxrOR5yux+No4KUl5IkwJoSuLEyWB3?= =?us-ascii?q?/2URykX9u5ZqRAW3JaFS06wmE9PP+zzGrw01F3Dx42E0io9Sk1VDn9mBvqFC?= =?us-ascii?q?gZpiVl5H4ISzgyDN1OFBxJSiKL9zhTdY97xBBLE0jz5sqdVNGIYzan+GdHMf?= =?us-ascii?q?984TnATiUH+hnT4dGECpLIv8HrUOJXrlyWD13gw2U+qRctMX+4qAWOTpxAFt?= =?us-ascii?q?MwuK7SiVcS6SRt5LasUVgMWf3m8aupcTv5+rVR734YXLiv4D1dYJOJbuPBqi?= =?us-ascii?q?SG/ihLUUq3FBOeQHUUv9sD55ElgDpzhr+r+jGsj59/SpU3/Gw34k/yHx2uEn?= =?us-ascii?q?P4/ssp4mUCsUk3scPOXuYPJh1J1HfAVBkAwv4YZdXl3w78XQcMcQv1SPNoMq?= =?us-ascii?q?g90DcALrMe+98gdjVbVysRpPW5ZYQrv/7ZREKEDZtE6Food+rElY9QQo1xvy?= =?us-ascii?q?7VO2CGEFiDELs6zu07JtX7G0xo5fcvrBf27TL+BAIdUmahKWUgOZKBYdSUPK?= =?us-ascii?q?EgGTAZwTwt3dgzrZxlWHjwn2lnpsBp+HFwYBCRXr1HA77MOtoyJit91dk+gC?= =?us-ascii?q?PZHN6iLkraiKa2nNgYfhFElHinkqDa0HDx88j5cokVH8WQDe8ll4b7r82Cod?= =?us-ascii?q?PB5rrbJbVdqRtRj/VfVUm1uN0MQ8eUFsmg6AEOwLfcsLzPYz35x48TCbTFB/?= =?us-ascii?q?juLwBYNlAEXXOiXQswtDlF3cwekgjS4ksDFlrfYbZRlO8116RkIl/KXnrwDJ?= =?us-ascii?q?0dBBQ2vtn3R+Q/9arbDaXI8mTWnAzJzn0a49Zmfz9nElk3OZqkjV3KiAFEkZ?= =?us-ascii?q?/OT5KENvrjsZj7QRgJcrVChrWqXjHQ+CFgsQfgUdmVBmtp4EEOns575exXgL?= =?us-ascii?q?gvzXgWCEX36ydaXy2OyX2w/Kh+HmKcsGuMy9MAcbcVW+BWzv7b+3JVuhiZ7x?= =?us-ascii?q?apUZtbtNwhHswhB5Z/ius0yI25NmMkFB+8NIyDqkq2btDOzCA3VRnjDEO1FG?= =?us-ascii?q?WNcvveMaSDlvcpB70DI/v9Fl2GCpL1jyBs+yMvAjD8BIhzFn1AtnC22f/mH/?= =?us-ascii?q?Zth2wKcEefqgG66gm5BvByQga6JIO9KOueuAKo7w5B8+mDR4XkW8taourIx2?= =?us-ascii?q?w=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,312,1654574400"; d="scan'208";a="80373853" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oLucxz4KE9olW9YbfDTh9f7zc8PQKmPokdxkdISvyxsijN/lZ1Ax3Bly8AystR5tLFsxktDw+E1doFYvk/26pSYA/WWgkq1g2bjStlAbeiL8+pzp9Rc8nDUnceKsl0QNwcSJcGJWFpy2RxOSosdng8HYVDCsuGI91T7Y5RtVbj/GbZmqm4rhUsDhbK5L+VYvZC2nFdge0toX7DP2DIB3M3QAqqMYq8m8U63QtNVTiw7RBltT3mqnSwKBXl46gTTyWXHeXR6gMTxYS0QLpgbQW2m4ZZHzZhQX4k69KP3TsKQaarVAYI0floJJY8JpC+bSDXM8IVINM34lB+UqWXQNZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9t7MxQ7mEc0WCJ817FW3QRBgGmcgGnWH2jZL/6FOtyU=; b=UdEY/fRlNMBlM0nycJBismy8xdF+u1Vgh2uqN+/gyBRIo7cvtjNEu+IRe13d9QBhQSlRTG5s3WNSNoHDlRvdAgOSG/UcTN/37m1X2BMMf+oumm9qHZGVKxAuzCUBeO0B8hguxyLjqHb51G8TUGX7JFRCWlHdNGLUvqBE8wtVSZdoZLQsCoaETgtgn4SyOtpTw9Y0dgNDylC/LxUXCQB+JWV/oqdjuEpJTitRLKc3SllPHmO/rhFP+9KWrvTiAdHCet0l9hQfv1pAFLwnSgT7gz7wsGdQA4aGO3VjgKWdcVPLqvHzNBChOZywwdKQTHUEajS+iq3LtaREdWMUXRDrTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9t7MxQ7mEc0WCJ817FW3QRBgGmcgGnWH2jZL/6FOtyU=; b=xmak0Vcl6peaURW31cDLLwW0T/gfkIHTu/i6m4JlWgKejh/G11W84I0dtkWdraJaBBltQ0XknVO8zmnXZrPh0xlSxtS0iHZBljMiY3DGVzLeIiNXwsj0xN9gBTpzxBG7pjKN4URM6bo4GOVfBubfIFwIxeOEz/jEkv46cdRFXjA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Ian Jackson , Anthony PERARD , Julien Grall Subject: [PATCH] libvirt: disable Werror for non-libvirt flights Date: Tue, 13 Sep 2022 12:03:28 +0200 Message-Id: <20220913100328.27771-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0031.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BN8PR03MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 604c3b8a-e21c-4abb-1549-08da956f391f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wYB5AGrPhwBGcCqryajJr5yPpOQxO0zLvEqOk3yUCOYuNvkBHwuKtvMdUG4mk+RNOKYmye6Jz+SHsnAEtYzZKJOrD9ks/cNtp8V3lQqaVey4+OzfSj1BCAaOfPf8/5hhIX1WrJGLHG4ErGI0bW22EBeUHJJpYtAv3WQCTOZ43Sbqbvpna96EhrNvfr9aHk7vcuYSUCEqjWc6XZxVMhPKdwD/DwYDAz7H//L2rOkkU44ZQiYCClmYXQtVqUmSQ/9f438bIhBX80ND6uj8AxZlmyjXveGA6XnHldovBzseUSW2tjSY5MOztiw98w1klNkW0zA5FdDkZKNwupuIfkCKsJplrrEcNHAPF7jzwsrvGoDhM7JcqBxyIp3ixzWhawA6eK4J38t6JJ5t7QRDw4+KfZityhwd31pMeHwP0dYLuoGEG/k9nFNf7m8KxxBayU8cfk1f6sjZHWt+QKQvbi/YaAFM+7nPVpj5mO9/UaU/jOUML2VYMWKo49c2JkNJTiOomvAM78czReKXuPC324qnLd1gcMjNu+kLQdTGnzgGXncMInuxVcOUbSUPC44ynYTtteIlLFCR+RA6mOjU+HdFQK8Bpsr/npifXgandUwPxrqyoCx4ZFWiVVfGlVIyEXf0xlhwQxNdxIJS/nNCjj5eXNqRo1R6/Fa+BYd95aLbkgEig0BMj3+w38nFHzS6DYbnsN5Q6zpDIV5Vf0R4UL6K0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199015)(41300700001)(82960400001)(478600001)(2616005)(6916009)(36756003)(38100700002)(6512007)(1076003)(316002)(66476007)(66946007)(6506007)(54906003)(26005)(83380400001)(66556008)(6486002)(186003)(6666004)(8676002)(4326008)(2906002)(5660300002)(8936002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjJIQzZqQmxZbUZuZnl0d3VUNEdwTkE4WmtRNjFBWmRjemJaVVZxQ0JGbkl0?= =?utf-8?B?SWRJcG9yVTNpM2ZxR1AyamIra2ZzY2xMTzZuU1haTy9sUlhUQTF3Z28wNkZK?= =?utf-8?B?azhBY3V0QjV4ZjV5dVdKS0xnT2lIMjJMdTlJWWlxU0hEK3lOZ3JTc3Fjb3Mz?= =?utf-8?B?ZGhoWDJxbTZUdktsOVNoTXVUQXpHVXQ3VkxubU9ZR3FmenA1dzhncDR6S2ZF?= =?utf-8?B?dmRWRG1DYjZVMWhjTlpUaGZ6TzM4WkN2U2V4TXZPcVJPTG5QSk1vd0llQ1Fy?= =?utf-8?B?SU8yQW9oOEt0R1VLNFZoRkxrSnhHTXJyamQ3czVhL1BwUUQ0SGZjMC9QOE9w?= =?utf-8?B?SC9YQlk2VnRmWE5TekE3ejRGN0hYRExZWHVOc3FMZVhJZGlNTjRnZXZrUWV0?= =?utf-8?B?Qm1URkphclhOcXhSR0JvRVlMVkJGVTR3cXJFNVNGczl3ZE1ONkRVLzRxVzZa?= =?utf-8?B?a0lLMVBoV0FaMWFXTVgwZzh0cHA0L1pRNkwrZkdzVk1INWVtc1lQMWVWTnhX?= =?utf-8?B?ZGRHVHBFbElZbGNjVndqaTlLNjhkTXYyWE1YUktubjRuOTRJMjNPR0Z3QmtW?= =?utf-8?B?bVZneDNOVzIzYVNhbjBydUdkSTFjZTFabWgrUmwwQ1N4dFY5cCtHSHY0enZO?= =?utf-8?B?YTZiRUNaTVIyWlVJMWFLSUttUExScENsY3lxVVFORzRjSkZUbVdqQnNTc0dn?= =?utf-8?B?cHN0SXVWSzRzOXNOcmcxV3NxQWdjTVJiWUd2dWphQi9ROVFOVjlnQTdTL2t4?= =?utf-8?B?NnFLcDkxWERuZitpZzdOY2REUmpwdFNaZVc0SWRrS003cUZoc3M2eU5NYWFL?= =?utf-8?B?SlE0RjhwRGYwellOc2dXR3drSWdjR24ybytidFB1WktDMktDVmpFK0R1Yk9p?= =?utf-8?B?Ui9SWWw4aDZYU0MxVy9OamFiWk1jN0tOUUZjRGVZUy80bFE4VlVDZnRleVBw?= =?utf-8?B?RUlEQ014Ui9IdWxnZmgzZGgyR0JKeEVuNWs1K0kvZ01iOHpmMWRRaCtGaU1I?= =?utf-8?B?ZitvVlhsWkJtZTF5ZzdDQlNDTlZacDVHS2tId01QOHFvODR5bG5mUnlJMnlX?= =?utf-8?B?aVhxK1VjL1p1a0pnTlhCdVV5SXFneHZjdlJEeEUvMFRzSURGVVd3WDBzU3M5?= =?utf-8?B?cWhkZkNkVE1STUdiTDdaVzV0YzF1cFlseWRFTnltVEFrNmhiMUpNemlhMXlk?= =?utf-8?B?cElVcTZHMGR6N1lWQUxlVzRySy9GUjN1QkMreFk0ZURXTTQyWFVkeE1mcGpC?= =?utf-8?B?UGpzVmtGNUZKM2Z3MXNXVVN0S21tQUZkYzhIZ01WaUIyMDczSlc5ODB3cU10?= =?utf-8?B?eWU4dStROGo0eGJTOGlzSWNsWjN6UklGTDRmQTNpd0hLa2xFMUY0ck5yUUVz?= =?utf-8?B?NkgzMzJMS0lneDJXa0Zhc3lHdU5lOWpsR0s3ODZSK1BHdk5OQzlzb3c5ZHhV?= =?utf-8?B?N2w4cEwxMmxWcmlzc0J2czZ2aC9wWFZMTVN3bnZRZHE5UTNZWUFHQUdlN21Q?= =?utf-8?B?UVk5Q3NZOEZPcTI3U3JDL2ovTHN5Z2x4eVlIY1JyaWtKTkJXLzB6eCtxaHZS?= =?utf-8?B?dno0RUV3WFdJU3l0cmR6eGtyczZHSmZFQkFlbzkvUndqMmU4Wm5kVzRvTU9k?= =?utf-8?B?TVJlRnB4bUdlUHVqUDUrQlBBMkRCRUQyTTVoeitFczNqeXlZNUxPZ1lwYnhX?= =?utf-8?B?N1NHZmExc1U3Mm1UWUkydTJEakFxaFNmay9TcE15enhlUENGZ1NhZm0yUWxW?= =?utf-8?B?bU1TT3hsbmZETzdXZ2ZVZndIai9MZ2JsamtTcGFVTW5vV09ZcjNHaTNiNUli?= =?utf-8?B?R1VTS2RES1h1UFRnNXJ3ZkNBWGdoZUJpcytmTGU1akF0NFhicnQ4N3ZIVzVL?= =?utf-8?B?cUZwMVVHVkNQRmM4R1JCcnVsaU1Pa2xSOUFlVEZFaEZoMTFlZTBRZURjZmRI?= =?utf-8?B?SmdRMzFCNEJ1S2JMNkNsaUxOV25xWEF1Z3VPTE1ORnBRUUR4bWJkZ2pLK083?= =?utf-8?B?T01JSVF5a2ZwK21JdFh6R01wTHY3eUVDdkluc3owajBOamkxQS9SYkVYY1o0?= =?utf-8?B?eFZKVjArYnZrdXBTZ3YvOUVSb0h2S2lFVURubU9YZ2NNVUFvT0xzK2thaXVi?= =?utf-8?Q?DfNwxZwQk15AXGFoa5v1krRgL?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 604c3b8a-e21c-4abb-1549-08da956f391f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 10:03:36.0936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E+X4NBCo6BCFYPIs4m3TDFaEBZgY0ZzwU3uANE13hxlOtiSMSIyjt1SuCXxDs4AimVzi0rDFYKLvMXEqkAosSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5139 Current usage of Werror=switch-enum by default for libvirt builds out of the git tree causes issues when new items are added to libxl public API enums if those are used in a switch statement in libvirt code. This leads to libvirt build failures for seemingly unrelated libxl changes. In order to prevent those errors from blocking the push gate, disable Werror for libvirt builds when not in a libvirt specific flight. The errors will be reported on the libvirt flight, and block the pushes there. So the author of the changes in libxl is still expected to send a fix to libvirt code. This is no ideal, but the other option is to just disable Werror for all libvirt builds and let libvirt developers fix the breakage when they notice it. runvar differences for a xen-unstable flight are: --- /dev/fd/63 2022-09-13 09:53:58.044441678 +0000 +++ /dev/fd/62 2022-09-13 09:53:58.044441678 +0000 @@ -574,6 +574,10 @@ test-xtf-amd64-amd64-3 arch amd64 test-xtf-amd64-amd64-4 arch amd64 test-xtf-amd64-amd64-5 arch amd64 +build-amd64-libvirt autogen_options --disable-werror +build-arm64-libvirt autogen_options --disable-werror +build-armhf-libvirt autogen_options --disable-werror +build-i386-libvirt autogen_options --disable-werror test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm bios seabios test-amd64-amd64-qemuu-nested-amd bios seabios test-amd64-amd64-qemuu-nested-intel bios seabios @@ -1217,6 +1221,10 @@ build-arm64-libvirt make_njobs 1 build-armhf-libvirt make_njobs 1 build-i386-libvirt make_njobs 1 +build-amd64-libvirt meson_options -Dgit_werror=disabled +build-arm64-libvirt meson_options -Dgit_werror=disabled +build-armhf-libvirt meson_options -Dgit_werror=disabled +build-i386-libvirt meson_options -Dgit_werror=disabled test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_nomigrate true Signed-off-by: Roger Pau Monné --- I'm unsure whether we want o disable Werror even for libvirt flights, but this seems more conservative. This does at least unblock the libvirt builds for both the xen-unstable and the libvirt flights. --- Cc: Ian Jackson Cc: Anthony PERARD Cc: Julien Grall --- mfi-common | 2 +- ts-libvirt-build | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mfi-common b/mfi-common index 59e712f4..450229e9 100644 --- a/mfi-common +++ b/mfi-common @@ -459,7 +459,7 @@ create_build_jobs () { libvirt_build_runvars='' case "$branch" in libvirt*) ;; - *) libvirt_build_runvars+=" make_njobs=1";; + *) libvirt_build_runvars+=" make_njobs=1 meson_options=-Dgit_werror=disabled autogen_options=--disable-werror";; esac job_create_build build-$arch-libvirt build-libvirt \ diff --git a/ts-libvirt-build b/ts-libvirt-build index 16b45cfd..e4faa1d7 100755 --- a/ts-libvirt-build +++ b/ts-libvirt-build @@ -73,7 +73,7 @@ sub config() { --with-libxl --without-xen --without-xenapi --without-selinux \\ --without-lxc --without-vbox --without-uml \\ --without-qemu --without-openvz --without-vmware \\ - --sysconfdir=/etc --localstatedir=/var #/ + --sysconfdir=/etc --localstatedir=/var $r{autogen_options} #/ END } else { target_cmd_build($ho, 3600, $builddir, < Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 10:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406280.648659 (Exim 4.92) (envelope-from ) id 1oY38A-0005UP-Hn; Tue, 13 Sep 2022 10:27:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406280.648659; Tue, 13 Sep 2022 10:27:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY38A-0005UI-Et; Tue, 13 Sep 2022 10:27:02 +0000 Received: by outflank-mailman (input) for mailman id 406280; Tue, 13 Sep 2022 10:27:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY388-0005UC-VT for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 10:27:01 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b569861-334e-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 12:24:22 +0200 (CEST) Received: from DS7PR03CA0286.namprd03.prod.outlook.com (2603:10b6:5:3ad::21) by DM6PR12MB4482.namprd12.prod.outlook.com (2603:10b6:5:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 10:26:55 +0000 Received: from DM6NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::73) by DS7PR03CA0286.outlook.office365.com (2603:10b6:5:3ad::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22 via Frontend Transport; Tue, 13 Sep 2022 10:26:55 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT078.mail.protection.outlook.com (10.13.173.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 10:26:55 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 05:26:54 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 05:26:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b569861-334e-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcPSFlomQaKnAr/cgy9Y0a7Ta5RKcPf8LteiaaCJv55iFIEnmxov1vdjcW6cAq5AvF49M035S9n7MDGn0obMP4xlf2NT/ZCggVdZKb++XjzsHkbp5kMxRwiBk4fVtgG9sKDoxMFSYxz3Oq4CvdHbqlLid0hgGroW1jWFOppZ0FWlFRUJoPM9KJik3/DjfQYGSLy6uDdPs7EWkQQe1sN6LeXXDaQwMZY1qPagqC01Pu22gzLO71b87pCZJ/Xg/og1Q4YSvmWRYemotffSFgfGieK8TS3bzlHdWLI4ZK0h7t7jCe0xVBIqR2ZWXTL+62Zzy0b3IL9TmRLeR4Bp9cptmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKIF4aseAT4bj9zk56AyTjkrKzQ/p+1kM91bR5dP4NU=; b=CqMeIRo3/YW6k+LiGPrw8uWnQejhiQ+0LCsRIkHbA8naj6d58JwW3keAE0yXbOa1Oz7f6GisIpj/rwF1+HrgONTTGAaF58LNFGS1HRJLtLZoqGRm1oI5K38UAomdHvQC74oYJUoKcDRY1IiMIB/LhD5FlpG5kxKDF0B12Un34YMJeafAmwQtEdb1RQgRWr2knEdO0OQ1NxYRApiVI6/41MVSSQd4Dx2S2Prlm1mXL9qsrehWnHtLELIVF7P7uvjyXAlsqhrD4P6P7q0x0G5pDFBVvSGosdW3lEGTlV1o6fzcDhr/G70omVL7CxRIK3arG6wRC/cHxZp5o3JggqX79g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKIF4aseAT4bj9zk56AyTjkrKzQ/p+1kM91bR5dP4NU=; b=vketUcggaWvRADyHcdcExbbyEAFWC9jFfGCfYKLT/ZNkZY2BSK6MBdX9JQIJrcNy+3J2eukUI/ZO80S5PpUGZepLTsdf+5o0NUZew8YBF6vbw1k7/lKtfBgFt3uPdC8XbaCfPj+vctPL6Q8kYUVzc0shMi/yjaB2igr0jJjLID8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <7b8deb6d-3638-c025-d7b3-8c0211497fee@amd.com> Date: Tue, 13 Sep 2022 12:26:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [ImageBuilder 2/2] Add support for lopper to generate partial dts Content-Language: en-US From: Michal Orzel To: Stefano Stabellini CC: References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-3-michal.orzel@amd.com> <57721e49-1692-64ec-92b1-ce393b79e070@amd.com> In-Reply-To: <57721e49-1692-64ec-92b1-ce393b79e070@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT078:EE_|DM6PR12MB4482:EE_ X-MS-Office365-Filtering-Correlation-Id: d9787f68-2b88-420e-291c-08da95727b66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AJT/nfx92GRRPBJbiUmpCFdIPx6soUgEdeYp/C7u8JDfGglnjVZUADOmPSJnTp21HpcweCEgcRSx2EDvcSYNOup8vJwpSBZv4I4sZeJdnM3fjDNUW5tMLf4gdZsiUl0EIY8n04Eba9EL8NGMAwyaCYoSl6OWpmLxznxDa3L+nR0jd/Snl9T6tX8OdbCWE4DU7gFEgX2pR1CGALvDvpqRIIns/sOndoWYIhXlB7pWLCEbHKeeuBckz+e235sm71DvV3MQh78q8EtA2vNDqUzQ5zoSsI76XxgVwEXhRbYnkkKDjY8TtUkzYpsOv3b+bCqfsnHu8/IxBEeQ/L210+3mXTbLSfFBCZ4hEdBU8ExN/k+MvzVapjqgsiMZfg/8ee7SwkVDlsz+ampCJVDWbx7xR2nYWRTT3gVuzhth/7VkbmPN02SL8A4qK/UgzZES/q/dYyvVe7Yxw1zkVPtvk76zNHkRdZ7wLPc8CtfJx3R3ltyEGxuyB5O5BcHkx6MWmwD713DyJRcwOZ/i2QYCZ6meXtbXARKjNtXRZs/7lzOHzxuouOovVB0mJTiJLuqpOC4Y5CbU8G/p+uzNhcFTwfUkIjQLd6CmBxJI4MVKp3Xz1BeL7Gd1wfOdx1H9Sa2PxMR8IElY8OX3NWWYSfc+PJcrV3F1gADp3Xir240fheqfOE0OyczYAbZ0dydgIX3zHc2AN095mY677zGdoMtxOn2TQVZASEg14laWkWK3DJycxdS93cQeoVkqDu/Wm7h1XSiONN3+Ook7CdDZt2w5xxS2yDuN3NGwAXyiJPiajiNxE6ohtQBE4RK55C1SpeUVsAnlOFn4T7fO9pNl1YWwb3KiOkw6IiEYp07uG1/1+FikQS1HVU6GgOwzo9/DZrrWEAVD1qaeII2YRCCMoz1VkGkbAQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(356005)(86362001)(31696002)(83380400001)(2616005)(966005)(40480700001)(41300700001)(478600001)(316002)(16576012)(81166007)(2906002)(40460700003)(8676002)(31686004)(70206006)(4326008)(8936002)(36860700001)(36756003)(186003)(5660300002)(53546011)(426003)(70586007)(26005)(82310400005)(45080400002)(336012)(6916009)(47076005)(44832011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 10:26:55.4512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9787f68-2b88-420e-291c-08da95727b66 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4482 On 13/09/2022 09:54, Michal Orzel wrote: > > Hi Stefano, > > On 13/09/2022 03:13, Stefano Stabellini wrote: >> >> On Mon, 12 Sep 2022, Michal Orzel wrote: >>> Currently ImageBuilder can compile and merge partial dts obtained from >>> a repository specified using PASSTHROUGH_DTS_REPO. With the recent >>> changes done in the lopper, we can use it to generate partial dts >>> automatically (to some extent as this is still an early support). >>> >>> Introduce LOPPER_PATH option to specify a path to a lopper.py script, >>> that if set, will invoke lopper to generate partial dts for the >>> passthrough devices specified in DOMU_PASSTHROUGH_PATHS. >>> >>> Introduce LOPPER_CMD option to specify custom command line arguments >>> (if needed) for lopper's extract assist. >>> >>> Example usage: >>> LOPPER_PATH="/home/user/lopper/lopper.py" >>> DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" >> >> Is lopper.py this file? >> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Flopper%2Fblob%2Fmaster%2Flopper.py&data=05%7C01%7Cmichal.orzel%40amd.com%7Ca7d4f0cc1c07424da8ba08da955d2fcc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637986524721374780%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oz5an1eISNbs6LoX3lE90RR%2FnYTX7ikZXw%2Fl57HlHV8%3D&reserved=0 >> >> If so, it would be good to specify in the README that this is not just >> an arbitrary lopper.py script, but the main entry point of Lopper as a >> project. For instance: >> >> --- >> Introduce LOPPER_PATH option to specify a path to a lopper.py script, >> the main script in the Lopper repository >> (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Flopper&data=05%7C01%7Cmichal.orzel%40amd.com%7Ca7d4f0cc1c07424da8ba08da955d2fcc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637986524721374780%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6ScZeGSMsX4MGgbOEi6I%2FDvkGNPlbVvBeSKQwexTHGA%3D&reserved=0). If set, .... >> --- >> > Sounds good. I will add this explanation. > >> >>> Signed-off-by: Michal Orzel >>> --- >>> README.md | 22 ++++++++++++-- >>> scripts/common | 64 ++++++++++++++++++++++++++++++---------- >>> scripts/uboot-script-gen | 17 +++++++++-- >>> 3 files changed, 83 insertions(+), 20 deletions(-) >>> >>> diff --git a/README.md b/README.md >>> index da9ba788a3bf..aaee0939b589 100644 >>> --- a/README.md >>> +++ b/README.md >>> @@ -128,6 +128,19 @@ Where: >>> - DT_OVERLAY[number] specifies the path to the hosts device tree overlays >>> to be added at boot time in u-boot >>> >>> +- LOPPER_PATH specifies the path to lopper.py script. This is optional. >>> + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need >>> + to be specified. uboot-script-gen will invoke lopper to generate the partial >>> + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. >>> + This option is currently in experimental state as the corresponding lopper >>> + changes are still in an early support state. >>> + >>> +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. >>> + This is optional and only applicable when LOPPER_PATH is specified. Only to be >>> + used to specify which nodes to include (using -i ) and which >>> + nodes/properties to exclude (using -x ). If not set at all, the default >>> + one is used applicable for ZynqMP MPSoC boards. >>> + >>> - NUM_DOMUS specifies how many Dom0-less DomUs to load >>> >>> - DOMU_KERNEL[number] specifies the DomU kernel to use. >>> @@ -140,7 +153,7 @@ Where: >>> - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( >>> separated by spaces). It adds "xen,passthrough" to the corresponding >>> dtb nodes in xen device tree blob. >>> - This option is valid in the following two cases: >>> + This option is valid in the following cases: >>> >>> 1. When PASSTHROUGH_DTS_REPO is provided. >>> With this option, the partial device trees (corresponding to the >>> @@ -149,7 +162,12 @@ Where: >>> Note it assumes that the names of the partial device trees will match >>> to the names of the devices specified here. >>> >>> - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only >>> + 2. When LOPPER_PATH is provided. >>> + With this option, the partial device trees (corresponding to the >>> + passthrough devices) are generated by the lopper and then compiled and merged >>> + by ImageBuilder to be used as DOMU[number] device tree blob. >>> + >>> + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only >>> add "xen,passthrough" as mentioned before. >>> >>> - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees >>> diff --git a/scripts/common b/scripts/common >>> index ccad03d82b30..680c5090cd07 100644 >>> --- a/scripts/common >>> +++ b/scripts/common >>> @@ -9,6 +9,9 @@ >>> # - NUM_DOMUS >>> # - DOMU_PASSTHROUGH_PATHS >>> # - DOMU_PASSTHROUGH_DTB >>> +# - LOPPER_PATH >>> +# - LOPPER_CMD >>> +# - DEVICE_TREE >>> >>> tmp_files=() >>> tmp_dirs=() >>> @@ -99,31 +102,41 @@ function compile_merge_partial_dts() >>> local tmp >>> local tmpdts >>> local file >>> + local node >>> local i >>> local j >>> >>> - if [[ "$repo" =~ .*@.*:.* ]] >>> + if test "$repo" >>> then >>> - tmp=`mktemp -d` >>> - tmp_dirs+=($tmp) >>> - >>> - echo "Cloning git repo \"$git_repo\"" >>> - git clone "$repo" $tmp >>> - if test $? -ne 0 >>> + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO >>> + if [[ "$repo" =~ .*@.*:.* ]] >>> then >>> - echo "Error occurred while cloning \"$git_repo\"" >>> - return 1 >>> - fi >>> + tmp=`mktemp -d` >>> + tmp_dirs+=($tmp) >>> >>> - repo=$tmp >>> - fi >>> + echo "Cloning git repo \"$git_repo\"" >>> + git clone "$repo" $tmp >>> + if test $? -ne 0 >>> + then >>> + echo "Error occurred while cloning \"$git_repo\"" >>> + return 1 >>> + fi >>> >>> - if test -z "$dir" >>> - then >>> - dir="." >>> + repo=$tmp >>> + fi >>> + >>> + if test -z "$dir" >>> + then >>> + dir="." >>> + fi >>> + partial_dts_dir="$repo"/"$dir" >>> + else >>> + # Partial dts will be generated by the lopper >>> + tmp=`mktemp -d` >>> + tmp_dirs+=($tmp) >> >> setting tmp and tmp_dirs can be moved outside of the if >> > Ok. > Actually, these cannot be moved outside of the if because we have 3 possibilities and we need to create tmp dir only in 2 of them. 1) partial dts stored in repository - tmp needed 2) partial dts stored in a local dir - tmp not needed 3) partial dts will be generated by lopper - tmp needed Moving the tmp creation at the top of if would result in creating redundant tmp for second case. So it should stay as it is. ~Michal From xen-devel-bounces@lists.xenproject.org Tue Sep 13 10:58:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 10:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406294.648671 (Exim 4.92) (envelope-from ) id 1oY3cV-0000vG-1R; Tue, 13 Sep 2022 10:58:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406294.648671; Tue, 13 Sep 2022 10:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3cU-0000v9-SM; Tue, 13 Sep 2022 10:58:22 +0000 Received: by outflank-mailman (input) for mailman id 406294; Tue, 13 Sep 2022 10:58:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3cT-0000uz-M1; Tue, 13 Sep 2022 10:58:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3cT-0003RL-II; Tue, 13 Sep 2022 10:58:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3cS-0007fF-VN; Tue, 13 Sep 2022 10:58:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY3cS-00087f-Uw; Tue, 13 Sep 2022 10:58:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2vzHTQE58zAVKzuCyFiCqmNyXThevAhUmIa84mLS0QU=; b=cA9Es0FpNYCDwd9mh8SFVkNXDB WHwbyqu3xIjuj7u9C1wRIkIAmd2npYsfa0vVlsYB7LF9Et2AvRRJNrvi26xalp39nwAKYsImqW5GZ MgWTEv+hbuea4KRFyTqFX7sFE/aAjf95h+vazB6cbIXP/uuCGaErHMBSHARzkYkfkoOg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173160: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Tue, 13 Sep 2022 10:58:20 +0000 flight 173160 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173160/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-pvops 6 kernel-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173153 pass in 173160 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173153 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 173153 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 173153 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173153 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 173153 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173153 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173153 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 173153 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173153 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 40 days Failing since 172148 2022-08-04 21:39:38 Z 39 days 89 attempts Testing same since 173060 2022-09-08 07:34:59 Z 5 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 11:00:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 11:00:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406306.648682 (Exim 4.92) (envelope-from ) id 1oY3eL-0002Ly-HN; Tue, 13 Sep 2022 11:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406306.648682; Tue, 13 Sep 2022 11:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3eL-0002Lr-D1; Tue, 13 Sep 2022 11:00:17 +0000 Received: by outflank-mailman (input) for mailman id 406306; Tue, 13 Sep 2022 11:00:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3eK-0002Li-CN for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 11:00:16 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0d25d83-3352-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 12:57:38 +0200 (CEST) Received: from mail-sn1anam02lp2041.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 07:00:12 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BY5PR03MB4920.namprd03.prod.outlook.com (2603:10b6:a03:1f0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Tue, 13 Sep 2022 11:00:10 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 11:00:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0d25d83-3352-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663066814; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=vH6VzT/RNfyLl94eOHdjCXVTLzgTshJAubtJkC+sEZU=; b=iBRHqsGf/sDIc6xgNFaxaYBEuUPNA5k+oKc/7Hw199c0JXUcDcTUqr/Y 36v302OnzImCu8deny8WtzvLFqE/f5ZU8AgF4u7COasEY+U6QjxKgCJ6D TpSKaU/pjEfVB8TzvwQ11Usp0udUnxb7ZP9HzhsF2CJyFxz1mAEtEmHar I=; X-IronPort-RemoteIP: 104.47.57.41 X-IronPort-MID: 80376958 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3Al9wbo6sE4VmgbMNhi+HjKxUGvefnOphVZvhN+?= =?us-ascii?q?MifNr3fj3mxXxfKvwFeecGOWvrvwR7zc1ddt3lPhdgZHeZvr8pSu/FqY+x+P?= =?us-ascii?q?cERelX8FoNJjALt4IUTleeGmZqm9GQuKgvmoC0JQ8Cuu2ojDyknEuM+KbNN9?= =?us-ascii?q?LyubXXFbD23S7m37+HUClbALuZ7b82mV4e0BRXoGip1egK1f0Rw44G+F4+ga?= =?us-ascii?q?XyBRs/KkQUsKvtEpZKB83RpbdtendRD0VAaiJPEWk+3stDjI5jZRmG8Cm2+2?= =?us-ascii?q?pBnPUa+CWyaVOHpf7B+1KUlbO7k16ko2pb/R97gZdQXnSCXVdCvmmEsz1B+n?= =?us-ascii?q?uAuNVHW84nPd/QgQG/yrGjffgUb4B2Dd/Zk+pEfkrr5c7KQzHgEaPHtQ9IE6?= =?us-ascii?q?9C5CMaqvFuNgbFGWaj3ab7ha1WHdZ30d7KcE25sOfngfxzWbutjJaHeUzQcl?= =?us-ascii?q?xCOLJlwfrQjCY1/7z4zTdmS1hwGDAzjjyNFcmEqdR+NOOyoCV37XnWO3Y5vy?= =?us-ascii?q?BOTKm59/JIDDNtRubbR7HKFHnIKUw4xX3JohiS2LQI6xnFZPoKuqPBBlAyVS?= =?us-ascii?q?q9eY0xMO8sf22a8g0EjClVUuor0CRwN7ByqZDQ8rRKJZVUixm+jZ5hGv61cG?= =?us-ascii?q?GkL+tmwk5qPEs/DnPHgNcKOGKGjKSO58P7Qygnm8L6zuuGJwzNO6389WdX9z?= =?us-ascii?q?GsrFUvi3syrdgN4cZp1UCm/zHnW4CekCKnHktX3i32G+djqxHT4PBy2NfkQ+?= =?us-ascii?q?IuK1hFC2RZzI5LMPCGH5WBk9Ox7FJJPK2R164ATki4YRReEnc5vu+zDb99a9?= =?us-ascii?q?Onf4Gjq3/7JvXG1kikv+WwqEqgn8u4AwcWm3j+PXJfxLU6I+npjmpcZ2/U4F?= =?us-ascii?q?D9llv9yoBl0+q2HOLN1Y1Th3blJ7xO3BzEVVaXk8QiVKYHiWzz5pYVt3utls?= =?us-ascii?q?xMlmobuP/XyM+MBnE4R7NdTW9g4bXTjsDW7dWD/6Chr2n51Jr6UiSGc4V0pV?= =?us-ascii?q?mEvbBV/FymisbX6zky9X6YwUB+EG7divAL4Uj0FyYCm8i36Ms4Cnh92Y3FhB?= =?us-ascii?q?U9zUZtMdDT9GkithzF9LTrg/re7oWXXOyyPgQaGre/R1MfN+PZrjMiC9lxka?= =?us-ascii?q?xIkQoETGzW3D+eV5i4L+k9fWE52LWPL81mQHEMVBdXAWRi5pTW/zlNLiSiDV?= =?us-ascii?q?QZe+brlXuwow36ho2LzENmVVesCituDvoGfE7OFwHw8MZDIYHQgxZKXp7ygk?= =?us-ascii?q?OmaW7vKmVAYA6JqMV+DqFGPwG53aX0/1J5S4sfft8u/PtR9ilB5gNAe9UGi8?= =?us-ascii?q?7XwfidskSyUPxiP/qsP56jHlxGGj7sCXCNFFJGgAFknLBdXTNB+NeNac7Anr?= =?us-ascii?q?j0VOs7juA16weGg+bCYaoYuJZiaqIbP2N4R38jaXzBc/n7Dm5DefxvDYO6K7?= =?us-ascii?q?C3xk+Jq8qfLzHUY9GGlIwAol0VRgWEXyaF2YzWdUU9TFCF52Z4Fm+b4HdPta?= =?us-ascii?q?liFeVk8XlnI+ATKxcqIF8a5qYYzg4qwCx10A4jMVSDWZGoENfJ4z2BKVscJP?= =?us-ascii?q?Mk4paquxl9jld+dor6ayGORpJQtFkHbCOa1CUNRFmyNkfUMVQjTixEFjYZoQ?= =?us-ascii?q?66VARya5wv25x70+dlNXatmbr0r3LY1AEgQhicWJWCzupQUMYaoGcUeVO8KU?= =?us-ascii?q?yYNgmi+k4lDJVP3s03ESfaUFv1QYnDKTlQwX6YMmsjH4Ab3uhfE8v6m+9uXV?= =?us-ascii?q?TxJpI2/sF2UwuI0bJAAc4q6rbTnnMgAb5IG8pDflptFe/dyrMIc+8/+4YkL9?= =?us-ascii?q?1eN7P7cfQFfDvh4wMplyiqqUkVymB13DigM6kfwHFp+CMPEqciHurT75fmN+?= =?us-ascii?q?RGaAI06VlXyUzBKtf7CU9qc7i14DnllQ6o9sp4GgKw/nuIUrvrEYZaj4y28b?= =?us-ascii?q?9Hgz3d5y3cyvO7g9yjbLKpIlvulh4/HabPIfIOFA+bYLa88Fa2Kxq/N6wQQs?= =?us-ascii?q?ouIzTi9WCuzfA9UvHygR+N3VQocsxf9NA2Xluspiu0f6rYLBLEFGw7LnrmVt?= =?us-ascii?q?hmRmd6wzu5z2rrqjyckfziiLE7HqdZv7Pylco87BALzn154FZXK/EJNdLNxu?= =?us-ascii?q?fppeiDKHWQ/RzuPpthjOsAWU1K8G4d2QkJIkmBLPJVl6JI4hMaBKB3Wri+L1?= =?us-ascii?q?bocA6tq94GkYyacs8qqD+8zrUfi88G5SvdcQwV4Bzci9A8t77AahU+kfZJGA?= =?us-ascii?q?u7xs0PTE1Y0S2QIzMpuewkODQc9ELCKd7IdsAH5JMQ49RCQaUjbsT8q5r9Xr?= =?us-ascii?q?067zwVxNFLOR1UJ61LBKYVTtnLbPASetS02reuNFZXVadT0zV4cBAjeNO6gj?= =?us-ascii?q?QCDBRpggcQ9VkiEU8XIyOi0WlyugDJYMGYvfDMVqFIMLkx3AwQY+cfTo68ff?= =?us-ascii?q?z4wJbCX0nUylvZAsW4gcYdTCPYTh08Bvckua1nd7JJWLd0ow2OeZDWINbSg+?= =?us-ascii?q?0uNnDQmjWb5W98WO6n5SSAXWVDsxcVlavpXXVL5UXGfeQd+PX1GA6ZOJwFs+?= =?us-ascii?q?QLzq/b5UbIxZ3zZqg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,312,1654574400"; d="scan'208";a="80376958" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlzvIfq7newQaLz8ml1oTmIgaK4h/rF8MSXE7VY9ahcqAY4MjShLVJAcISRb2zLdIdqTbnx1JnbBf31IkZOw8GE6sRoisKJk9s0sBJxl8NK5thEkFajh0t4J0t80yxJxps6e6/ahhWW+eOI7r13qcoYpuo5+KXuif/ccMK0IuK1s2Ks2bw5XQ2tqLo4JzJpqdV8RdGMphvR28O88Yoxb1oCfsf4bA+arsdf2v+TBozGTF0WOd210Hv/9qWcbEpGC9VgzFf2waDaeFVEjt0EgyeIf/r2lla/07KxI0gXCy95MyyJYmK2llIhdGRMjOykYo3WMaEdMteDUIxJm4sQTSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PrzBEVkX0OaF0KQ2cVhHaFzJfpyPpHhSb86Lhl4Vsks=; b=EKlMqsTW1LW3zg+6uaefnyC+CkU9IRiem9IpV5xtKuRDms1Iq8qn0E3TdSh/RDY9YIqUugxc17tFEvlBIFDd+Yspd6hd5yepyZQag2DR8HvS9MzHu8abPsnQQfk1sLi2wHwShyIjOPKXyPi7kKCA3o6iLOEiFkpy2o9yxxmzmO355FQfE/m6XcComAASwGulU8ir3QKUuoMYWKtqoonUfBiW0v+hYyGdn4ICKkIJW7qwAlwYH6G1FeCq/EtCspmJNUeZZcqQFUBJmZK2H2hiOVe9n++5fRn52LGpiXJt7Hplk/yufNohwx6bqb3dQpmFXuEh9TZxHwSophYuMVadgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PrzBEVkX0OaF0KQ2cVhHaFzJfpyPpHhSb86Lhl4Vsks=; b=LNoDgZ0uLHSPyRNP7r7I7embyICJp5KiJuDLIrMD5bU2ytmCBu37x8NVFPUywROlXNRd/TCYrBSZPg9EGOqS9+i7UxcWI4RH0nhV06qpovn+15x7HC2PI6vTpHET8eEWR2ZIffRi8KTDznaI1jCQggOVzx5ZUeIhgT8O9/HepYU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 13 Sep 2022 13:00:04 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , Wei Liu , Henry Wang , Community Manager , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Message-ID: References: <20220517153127.40276-1-roger.pau@citrix.com> <53cc6a9f-5a4e-0716-fe08-ad86fc155cbf@suse.com> <1dbab710-6d3c-a6cb-faa7-31558c04aab2@citrix.com> <3a975638-9675-9a95-fead-91120edefee1@suse.com> <07176f1c-2759-ddb0-1d59-38b4504d0ed4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <07176f1c-2759-ddb0-1d59-38b4504d0ed4@citrix.com> X-ClientProxiedBy: LO2P265CA0418.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BY5PR03MB4920:EE_ X-MS-Office365-Filtering-Correlation-Id: 30f2940a-b424-4d0d-8266-08da9577201a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EnUcStqtWmbPQLPDVeDBOyI72CmNu/Yoo8sPIRXYGNc4nTpmfahVwas1JYGTv25vs6TfhJ2Rnn5dPuhhkjJ6QgmidDNwRxvg3UnbW6McNmPSKy+C9iKWKAEIUmsjZh6RTaG3crG7rOqD61r+iC4U47E2m4tnF0LKY/fUGE5Vg2Ig3aGnnL6i3jMFMX9ATWw/ERUPlUrsFUaIUELw8S8LsFJGwvjb4T5wias1rUdheYgrVP3AhdpDZAZDAW9JWQ3ZWmB9k46d06HrAG1ngaIs2zYc87WQSxyEpBi9l8J91v/qeLzC6BvtBI8sxz+C/zSprXFLsr3XwzRbSeXmEixEQMoKSmKvQxvsJ8cBZ/8n/KKv2VMZlhw25kX3u1qKUHfRe6fTxKSGxDf82G4UUjh2qcVXAsNoj/WlB4eMxeGhWRbB1+iZIACFwDG3XVFlb7gV1rLdhU0yqWP9zlcxe8fzuUPtXzgd9kuevSAHHnfvfuVnf3z5bCXLYRASTm70PEpiXlFpu91JX8i++Wx4u1w4jYcCIXnpkPed7OFsKTLC59zA0bQpXJrZ3cfKearRjSGxsGqv2RWRPOhJzYMM9g+OL8BmEWacfTVcUiuxnT3G9CFibVpm9OkN1FIauGNeYRv5YBvqPyACQe9Kk5XZBri85K4niSAgA/4hY/ZI6+7AgTVe4bkPs0SxBHAkSd9U15/w695GHrHIG9P2ThEL7xRooqZz1Q6bPraH5D/BhesswcY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199015)(966005)(6862004)(316002)(4326008)(2906002)(478600001)(86362001)(8936002)(26005)(66946007)(41300700001)(53546011)(83380400001)(85182001)(66556008)(8676002)(6636002)(6666004)(9686003)(54906003)(6486002)(38100700002)(186003)(5660300002)(82960400001)(6506007)(6512007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkZaY3A3Zm1UZDA0d0IxQ21DcHNNa1hLZnAvVVRER2xTUEtsQzMzRUIyOFFJ?= =?utf-8?B?SWR0SEh4c0VtMjBwMjJFS0U4VnVHSWkwMzRTR2p5dEdWTFo5QU1pamlybjVN?= =?utf-8?B?cGsybGM5aHo4b0JHMHAzb3NJNS9vd3ZXVGZxVEEwdDRMb3FUSW9tcTJ1R0dM?= =?utf-8?B?NEkxWmJOVDVrOVdncGlRK1ZYUU9mb3RXelhLWTgwcWhlOGM4eWpoNjRvQmoz?= =?utf-8?B?clFVYzVFMXhISUorMTRlMGFIUnVKUzNVUXVGYU10bXBSajBObksxOHFXRUcy?= =?utf-8?B?eGZCWkpBOXpNSkYxNzZsWUlia3ZXSzFJYjhkUGN1MFVKZXpKUE5LbEcyOTRE?= =?utf-8?B?TVY3UGx1bW44MDVvNXd6OTJMeGlOUHBiYmxxaksvbkp2Nm82Y2Z2SFQreTVp?= =?utf-8?B?ZTNMd01lOS9Ua3NnOXhFNG9reXI1QWloazAxNzhOQ29yejhKQWVzbXFaUGZM?= =?utf-8?B?c0s2N21kUlNTSWU4MXA5QlY1RmpRVktCdDBPaWlac3BVei9DbFpGTUVuNlNF?= =?utf-8?B?QjBXTkFOZmZxQTR1SURJWGhrWTlselVmVThjK2VXb0xXSUNPaTFrUFdEdjdI?= =?utf-8?B?c0lYQnd4enQvZW1hdWJua3NVcjB1eDhyMHB3dmsvV2pPazk2cGhQL2ZNT0FD?= =?utf-8?B?cVBiZFQwRnZOYnRQdzZ4d2tQSSt3ZUw0MUJLdDdmcktkOHV0VTcxaDFyRGds?= =?utf-8?B?bTZmWkpMVTh1NzU3Q3pvQWtxazRBdGtXMjRtb2VUd0Y5T21lcXRDMVJDT0xX?= =?utf-8?B?UkYyeUZiLzZIUUliSUc4UXVSd0YvT3gyZ0k4a0NkQmxTa0xvVXgxY1dqSmJC?= =?utf-8?B?ZUlqckdrWW4vdU5IZXdSR2paNXNhYldzUkhPNHpuZDJaQTBESXcvaGY4cFVH?= =?utf-8?B?UE5zL0dzdTF1VjJCUDUzdWVpeEVMczRWNjYxbzM1N25kU3hRWFJ3SUJpQUo0?= =?utf-8?B?MGVNTTNGQWVPbXVacjhmd0lybVB4UlF2S3ZwMEgrY2ozMFpQTS85RXNkTGdV?= =?utf-8?B?WTg0dWJtN1Z5dmpIV3N6ZTlNcEVGdUpwRS81QjhhRGhmbkVCUUZiTkp3d3Fi?= =?utf-8?B?b01RR0RTZGFOWGhTcE9QbmhTNHVJM1lYQytsNU5idlprVTdIbnNNUG1Id1JF?= =?utf-8?B?UmxlYmJ1SGxTdTZvbnRPSUFnWndCL1FJOXBGaTRkenMvVzRPL2tEcEkwa3lz?= =?utf-8?B?Tjk5VnVxZXdmSGZRWEhOU2RwQUxGQVN0dW9ZbWtMd2o4aWd2Z3h4dnU3eDFG?= =?utf-8?B?UzY1UmUzWHA2Z1Z0anBDd2liOHl2T3ZibWpNYkVPNWs4Z0Irb3dHUVA5N0I3?= =?utf-8?B?Tm1FNFlIUzh6VFZQSHh4TjhkV0RIVDNUelJQK1VNeWsydWlmZFhCN1ltUmEr?= =?utf-8?B?dkJMeEZtelRNeks3cll3NkNjekoveGxFSE9uUW9TWTBRVEFHaFcvbTU0YTZu?= =?utf-8?B?R0E0eGVBYmh1eCtzSFpOSmoxUWljS1J3UmNKOThnRHFHOEZIK0MzUUhtc2tB?= =?utf-8?B?OVAzOW4rVi9TYS8xankrL3Byalh5MTlFc3ZDbVhiMHRHYm1jUzVhaHVjZVp1?= =?utf-8?B?bXVwanpKVG8yUjJSQlcyY2ZpUCtlbnRZQkVQY0NrbnVBWWswSDB3YW9HTmEz?= =?utf-8?B?OVBPVTNpWmtJeFV5TXlRK24xRVJCTDRVcjJVc1BlNXpOOUV3aUM3czN5VGJM?= =?utf-8?B?SjZqREVEM092V25nUUVYeDJzL1F2L04zUlByVWE5TGxWVXczbFZKb054MjR0?= =?utf-8?B?cGdkVlNKdDhKbklsRmFqbmVHN3VjclBUVFBLUjJkRVpVQmovcXNHbkd0bTE4?= =?utf-8?B?RmMvcm9SNWlSWkxPc0FjTDd2dE5JVlk3OExuZjRNTUlFMHJnYWxza1VGMnU5?= =?utf-8?B?UlR3eWxNYW9FSWFxKy93U3JNR3JZNGdaRCtFOUNsTjZiNUVqTFd2QU4rSnM4?= =?utf-8?B?TElNa1NCS3JlY1lnQ3ZRb2h5TjV2akxXdEcwV2VQRWpxNmZJQU5Cam5LdDdw?= =?utf-8?B?QlprSE8zck93eU5UaW5ZaDJWUm5CaEtLREdzUzFKZDhJbllheFhNQTQrcDc0?= =?utf-8?B?c3FSazR6Nm1BZ2FFQmJ3SmpKWUs5V1dabmFBL0luU1cwRUpZMkt6MFhmWng4?= =?utf-8?Q?zC34e9A1SG3IYtoy8tK5dT/RW?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30f2940a-b424-4d0d-8266-08da9577201a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 11:00:10.0944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o9t/PZmYbmfC2K145iAcWozWyndZYg0LsuUAWexVD/TfcsQoEXXSI50/cIqGSXhC/JiGBXnjPMNu9TWWdN6UmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4920 On Mon, Aug 15, 2022 at 06:49:08PM +0000, Andrew Cooper wrote: > On 15/08/2022 10:14, Jan Beulich wrote: > > On 15.08.2022 10:15, Andrew Cooper wrote: > >> On 15/08/2022 09:01, Jan Beulich wrote: > >>> On 17.05.2022 17:31, Roger Pau Monne wrote: > >>>> Roger Pau Monne (3): > >>>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL > >>>> amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests > >>>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD > >>> I came to realize that I had announced that I would commit this about a > >>> month ago. I've done so now, but there was quite a bit of re-basing > >>> necessary, to a fair degree because of this delay that I did introduce > >>> by oversight. I hope I didn't screw up anywhere. > >> Revert them, or I will. > > There is no basis for reverting > > You have falsified tags from me, which is a consequence of the series > not having been reviewed correctly. Seeing the changes done to the commits, I guess the problem was the 'Suggested-by' tag. This was added by me, and has been there since v1 because it was you who suggested to do this work, and additionally provided guidance on how the implementation should look like in: https://lore.kernel.org/xen-devel/4457dcd5-6a64-355a-b794-6b404cf90335@citrix.com/ I'm sorry if this turned out to not look like you expected/wanted. It's possible we had informal conversations about this where we discussed changes, but TBH I have quite a big queue of patches, so it's likely I've forgotten about. I'm happy to make any further adjustments to the code, but I will need to be pointed out at issues. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 11:05:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 11:05:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406315.648692 (Exim 4.92) (envelope-from ) id 1oY3ix-00031t-0e; Tue, 13 Sep 2022 11:05:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406315.648692; Tue, 13 Sep 2022 11:05:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3iw-00031m-U5; Tue, 13 Sep 2022 11:05:02 +0000 Received: by outflank-mailman (input) for mailman id 406315; Tue, 13 Sep 2022 11:05:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY3iw-00031g-BI for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 11:05:02 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2047.outbound.protection.outlook.com [40.107.220.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e82d5ddc-3353-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 13:05:00 +0200 (CEST) Received: from DM6PR06CA0007.namprd06.prod.outlook.com (2603:10b6:5:120::20) by CH0PR12MB5105.namprd12.prod.outlook.com (2603:10b6:610:bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 11:04:56 +0000 Received: from DM6NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::37) by DM6PR06CA0007.outlook.office365.com (2603:10b6:5:120::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 13 Sep 2022 11:04:56 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT024.mail.protection.outlook.com (10.13.172.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 11:04:56 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 06:04:55 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 04:04:55 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 06:04:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e82d5ddc-3353-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gg/J8jaubf7InKCqQqLSvF5TY8pmKM3VIUVlWSvIZOn7bhjdQXnKDtVFYcMJ0E4jO7bl0BVidsY3+tyyGZp7M2QWvT0tl/0ECjoVRF7H++agZ+gaXfYItWOk75btNi7WyA4YNKyA2UpKka7XzQnLcnFbR6xaPdqJrfB+emZTfDvtXDxHFFFSTRXnFUz8v2wk89O3G3Q3JtDtXWcjUc6kwFb/Cc63lVUGYikGqJZ/9NmbA8X5pBiCf+VOxdWg4tmMpNNS9NVk/ggCt5pwV3FUIQi7H/Qo3uH2LLckAkEAMAcoJzTGTdoT59SrCggEafmGXqxqdHU48kw6cS2Dk3E9Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sN8VBdMWyZWPYpYA5W4LZYJj/Fc+AssyBaluPAEqZS0=; b=CPGvXQIE0AJf9x29NVt5Skkqs0ZQGRLUxKHssqUzZyUBcxRENxk2HRn6gbPI/I+0q3aIblo6fE6OXQZsV+kn67Jq4l8yIx6fOkBXiBdmFWFyUofbt5fbaXATWFU/kkWzFiauWykgDGxCBCFOiiR3m4pIpsuc3CXja0Ro3PPD9MaJnS5HcP3w1+34eeJ5A2oYbF6Nt1z9QE539M+aojruDW5CIxIzLfyzR6sVIzlaY+I0bvhrfkZJi3IZEwrRztRzdkpZtw03IwOCQhyRb7lAX6afqGR5ulkBegsQvsmNYa7vyq7CwdnRaYctVrShKyRrRQluAuXQKcW4na9En667aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sN8VBdMWyZWPYpYA5W4LZYJj/Fc+AssyBaluPAEqZS0=; b=Eqtbt+Og/Y32zm90zVAxuhF3CGVbiXd+qk4NJFVZIUR7OwMhPbsylsnv1AGMQ95CMAQoqK3KpGH+BWrl6168IXxYBM0DeVrj1H6eomPGtPnqpsC7h6tVuu4zlW/EmV8mlZNyl/ZENb9bnKLwlRqhUXj8NyHpP6JoT8IDh/O25Do= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <81eee8c0-03e4-fa41-757d-ee749ebcbe07@amd.com> Date: Tue, 13 Sep 2022 13:04:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [ImageBuilder 0/2] Use lopper to generate partial dts Content-Language: en-US To: Ayan Kumar Halder , CC: References: <20220912115934.19552-1-michal.orzel@amd.com> <64aadcab-5f41-6d2f-4dc9-39415016816a@amd.com> From: Michal Orzel In-Reply-To: <64aadcab-5f41-6d2f-4dc9-39415016816a@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT024:EE_|CH0PR12MB5105:EE_ X-MS-Office365-Filtering-Correlation-Id: 5582ec9f-87dd-4594-1d1c-08da9577cac5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 67ZOE1FmEos5k3a7xG4zkQRMRLNlwwKp1feVmDL3vAhJZntN3LJJYncbc9jPFFXafq1c0VAr2oo+tENMRABx7KEMb+YzTg2MvucWnZ0fvGTFNCCj/qi7hpanbZg2EbFPlagMx5ueW2AA8QqmD3efdTStLWI0tOwqb2T/N8GeilE+loS5g8dlu4q59kPpuhE129j7YeLCHdV3JTJXMyj+kuvPYKRS91tiu0jBgUkJWFwPDmru6adz18pluiW2iJVFVLJb0XGxjKj6Y/HcZHmGJ2zUtUqtFKy7IrIICGJOqLKkKxI/5xA+zESQUw/6QsDlwBpzl14sMrkVR7zfjllIBW26E0xhfKyGWZ8KwZY9Ybnl++fskeJbVOBjYKKNqhC2njYE3Qmv/DR/vApDciOYDeSmbilSwY/WGCtOzrMG12tdpqrbL0CV8wHFzdCMmnQajsVzwy/wEC/KUcR0dqHMINIs7qlIcsayK/2GrjH9ALCD3B79plGELe0iMeTaNIx/VJ78yxtFfEKBbiGi69WzZdygd2C0PO8PLEa023zF/w5nvsp411yWDbEFhtoLVV7QrQPNHc5eYNlkSb7SMG+lu2Jry9jekCiWinlDCp7PzZxUhDTdLOzx9TwwxmkKE7oo21m3HX0l7tlzb1vqPblnmOT2AbUtPdRL7TKtcf96BgVzwkuk3T2kErDSeddmwx8Zil78LFZaE4EDDTI+2+vOTOCEusU5UNTI2VjlcfUKjR3BXtQ6z03LNcX5Zjtv82YxvwnVUxnWMlPseCQhBIJ9AtCmzwsWo3oPxfgyHSMHTSfQr3jgxlfZJkhvOaWvCk8mweB3zJeVvGdh4cVRzI+rzmvj7D6Cg3UZQ/DPLvOpCBc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(81166007)(426003)(40460700003)(36756003)(356005)(316002)(82740400003)(31696002)(2906002)(8676002)(2616005)(40480700001)(82310400005)(16576012)(70206006)(110136005)(966005)(47076005)(186003)(53546011)(31686004)(26005)(478600001)(83380400001)(41300700001)(86362001)(70586007)(336012)(44832011)(36860700001)(4326008)(5660300002)(8936002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 11:04:56.0815 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5582ec9f-87dd-4594-1d1c-08da9577cac5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5105 Hi Ayan, On 12/09/2022 18:27, Ayan Kumar Halder wrote: > Hi Michal, > > On 12/09/2022 12:59, Michal Orzel wrote: >> This patch series introduces support to generate automatically passthrough >> device trees using lopper. This feature should be used with care as the >> corresponding lopper changes are still in an early support state. Current >> integration has been tested with several devices from ZynqMP ZCU102 board >> e.g. serial, spi, ahci, mmc. >> >> When using this feature, make sure to use the latest lopper's master branch >> status [1]. > > I am guessing that this is the first time the imagebuilder is using > script from an external repo. There might always be a possibility that > future changes to lopper (master branch) might not be backward > compatible or might break something in imagebuilder. > > As such, will it make things better if lopper is included as a > gitsubmodule for imagebuilder. This way a specific revision of lopper > will be in sync with a specific revision of imagebuilder. > > Please let me know your thoughts. > I think it could be beneficial in the future but not in the current state. The reason why is that the lopper changes are in an early support state (I try to highlight it on each occasion). This means that in the near future we will be improving lopper extract assists to cover some corner cases. Adding lopper as a submodule now, would result in a need of additional commits for the ImageBuilder fetching new lopper changes each time we improve something in lopper. I think we do not need such overhead at this stage. Also lopper's README states that "Internal interfaces are subject to change" so we can assume that the interface given to the user will not change. > - Ayan > >> >> [1] https://github.com/devicetree-org/lopper >> >> Michal Orzel (2): >> Refactor sanity_check_partial_dts >> Add support for lopper to generate partial dts >> >> README.md | 22 ++++++++++-- >> scripts/common | 73 +++++++++++++++++++++++++++++----------- >> scripts/uboot-script-gen | 17 ++++++++-- >> 3 files changed, 88 insertions(+), 24 deletions(-) >> ~Michal From xen-devel-bounces@lists.xenproject.org Tue Sep 13 11:24:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 11:24:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406324.648711 (Exim 4.92) (envelope-from ) id 1oY41H-0005et-LX; Tue, 13 Sep 2022 11:23:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406324.648711; Tue, 13 Sep 2022 11:23:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY41H-0005em-GI; Tue, 13 Sep 2022 11:23:59 +0000 Received: by outflank-mailman (input) for mailman id 406324; Tue, 13 Sep 2022 11:23:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY41G-0005ec-Q5; Tue, 13 Sep 2022 11:23:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY41G-0003tJ-OT; Tue, 13 Sep 2022 11:23:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY41G-00013R-D5; Tue, 13 Sep 2022 11:23:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY41G-0005N6-Cd; Tue, 13 Sep 2022 11:23:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Jn1xSuRy2m8YKjkFMpxFZ6Lx+twiibg8unZCXYV0NUk=; b=u/BDXyY3eETgiUaIayenJ+0el1 LFMZndHlIaZw+MjWlvMI8pK7DsliGHywVgqpEy0ThJsst+6Zt5L4sgrwdcuK50ZmWHUjAXaKbmUOk oswBXkTWHlTt+sP/dkWZi1bcne775ZpQctsLQLh11DybSDG+kDPFJCy1iL/7H5ELMJz8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173166: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=db7afaee91423e988df3160624d04c3c534f294d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 13 Sep 2022 11:23:58 +0000 flight 173166 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173166/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf db7afaee91423e988df3160624d04c3c534f294d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 40 days Failing since 172151 2022-08-05 02:40:28 Z 39 days 301 attempts Testing same since 173166 2022-09-13 08:46:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2485 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 12:09:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 12:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406346.648726 (Exim 4.92) (envelope-from ) id 1oY4jO-0002JY-KC; Tue, 13 Sep 2022 12:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406346.648726; Tue, 13 Sep 2022 12:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY4jO-0002JB-Fl; Tue, 13 Sep 2022 12:09:34 +0000 Received: by outflank-mailman (input) for mailman id 406346; Tue, 13 Sep 2022 12:09:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY4jN-0002Fj-OI for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 12:09:33 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec5b6bad-335c-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 14:09:32 +0200 (CEST) Received: from BN0PR03CA0060.namprd03.prod.outlook.com (2603:10b6:408:e7::35) by LV2PR12MB5920.namprd12.prod.outlook.com (2603:10b6:408:172::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 12:09:29 +0000 Received: from BN8NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::df) by BN0PR03CA0060.outlook.office365.com (2603:10b6:408:e7::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Tue, 13 Sep 2022 12:09:29 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT110.mail.protection.outlook.com (10.13.176.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 12:09:28 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 07:09:28 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 07:09:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec5b6bad-335c-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdTVpN6Cnl6mCo9qmBVSjK4vgNuKEKgycPzdr918sRDIOmKuNjHqa3wjoA0ntd8YeoP0qGaHdSlF6Eho3dDz0VH9yxggCQdLz9mXW0Ukgjy3+JKsbVqwkF79D5ZQJE5Idn9vVnd9PzzyR+j8hlLtR/UEzaawnZBs3rH6PG3aHZ+iiUpr8/sKWvGjCCQ9bMo2ppOmT0/2E2NWy4UDN4Ssg8i5bEgkI6sMtQv3izVVhDknGRp739reVAKwrIsc+jFI91/boz+bi5KmFheEDknu1eYyPooES/+fjTV8M1ElKzK4dP4IpiftJzN6TuonBDoP3B1S3kv/C6uaGXKzDM+g+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MEXWX4yZaSQA0d1dChkxu1twPiiUlC11JnRmnwZf8V0=; b=Kab2njFk0k3r2FPF09olu7XxApf5K10OjQAryDGNldot/JZTnq87RPqCnxW4KfIZXXb/YYzNtRDITlXkitfugP4aYUnmDlgryLRXZy+FIBLiO7SJIYCyQnc0VcY1jxHwP1AGhzSeKtgcattcjWBQdvsttUC3DGtN8kfRNyxhf94hF9L/OCngCx7vReTggSHg7ROqsS8H1LJWO5eQ+XdQsC99EUUkDgYP7LaL34VJzpiU2wCO3s/B/NziG12tUt6Jn9tBBV0VofQB8D1Ku+6kw6mW2dDXYVaQm7TDtTyExOUA8dJ1UJgxMhBmbfOfqL5lGcnhPGXT+4b1zzk1nYiw4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MEXWX4yZaSQA0d1dChkxu1twPiiUlC11JnRmnwZf8V0=; b=DVdK4G5Q1TB49+OfTgJJpuUBkwBPxG0tF+5Sq0On4aiQmRA9WIydIOYltiJI3jhjpfdERROx4AAyMus40QDcDTXfSwKwio+6VBFh9/fcQLM7IF/VG62lb753JwONNrHYYXB6+ormngar4U2uemMTSMp5+8BP+smIphEAO3SMnqU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel , "Ayan Kumar Halder" Subject: [ImageBuilder v2 1/2] Refactor sanity_check_partial_dts Date: Tue, 13 Sep 2022 14:09:17 +0200 Message-ID: <20220913120918.31162-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220913120918.31162-1-michal.orzel@amd.com> References: <20220913120918.31162-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT110:EE_|LV2PR12MB5920:EE_ X-MS-Office365-Filtering-Correlation-Id: 51cddbc5-53d7-47bf-c536-08da9580cef0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6nHNiyaoQIW7lSrjHpPwLiG4m/jTuZpc67LyMZtZevljMbKDj4Uf125n4F+phYKkb/lZhHjENHyWgMglszbVC5vATNCvwtBUN4cQMxsBTvU1K1bG/TvchuVi6vXeIRec/hEvqg3jEhZyKd91A3Onmc/TL4MmTuL9n9Oy8A9YdGtEasQTofTg5gVyG0pZbemLrQbH/6dS96xh1jazms96tMzyuhKEuku1Zi3rdD2x0wxKRYlErLK+wNogJpz4qL1nayQ6F4+XpEliRurfS7xyzXtecMLT1+6gtHVsKaU3cpwFNaB5CF4WZmr577bHQDF1x6NL38GKwpFIHR8J//B9LkW3oht/2fwOEfMILait8Kkdjszo8WnkVBx9pnsHc6kkLXMz2PuvCM4mKeAgYuayqflpHyy9Mi/gGF/Qozblm+6j7vOFhjSd5tllt6/pLTrgt2xBxp9FG2oixb0VNb0LX7HJZQb9vhFyfFAY0NhPvIISxQJVU1In67ua4kcZhRQaasJiCPTLxySJM5+kavhinHnoKQtOmld9Kc6ahgAU0suiZKYD1AzwFBEbOOqQt5VKh1We1r8nttoba3U8rdkpj2M9NoI8QJxZ9ofCawnEpFkwDZHsLKXh56Z++vuWQ0JMhz8Ev0wnozacPZysDa2JbHsrsGLV2Mz2/St9iFMK4KROerybGaMN2u+Ve39YqpSTX16ztfPaJDfVBvCdHBl0rB7J6vewfXQ8ENpE1kRJxilxqFfcuj6z/I9adbEmuULf+ghCHPEwuNy6Uff1w/cY3EytXFgX9BWVGZu/02jTEChqT/IAZEWsAYrV2nIvAaUm X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199015)(36840700001)(46966006)(40470700004)(36860700001)(316002)(356005)(83380400001)(8936002)(36756003)(41300700001)(186003)(2616005)(26005)(82740400003)(6916009)(336012)(81166007)(478600001)(44832011)(8676002)(82310400005)(1076003)(40480700001)(70206006)(4326008)(70586007)(6666004)(2906002)(5660300002)(40460700003)(426003)(86362001)(47076005)(54906003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 12:09:28.5959 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51cddbc5-53d7-47bf-c536-08da9580cef0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5920 Currently function sanity_check_partial_dts from scripts/common takes three arguments where the last two (repo, dir) are used always in conjuction to form a path to a directory storing partial dts. Modify the function to take only two arguments where the second one is to be a path to a directory storing partial dts. This will help reusing this function in the future to perform sanity checks on partial dts that do not originate from a repository. Modify compile_merge_partial_dts to take this change into account. Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder Acked-by: Stefano Stabellini --- Changes in v2: - none --- scripts/common | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/scripts/common b/scripts/common index 25c041270c29..ccad03d82b30 100644 --- a/scripts/common +++ b/scripts/common @@ -40,8 +40,7 @@ function get_next_phandle() function sanity_check_partial_dts() { local domU_passthrough_path="$1" - local repo="$2" - local dir="$3" + local partial_dts_dir="$2" local address_cells_val local size_cells_val local tmpdtb @@ -51,7 +50,7 @@ function sanity_check_partial_dts() for devpath in $domU_passthrough_path do file=${devpath##*/} - file="$repo"/"$dir"/"$file".dts + file="$partial_dts_dir"/"$file".dts if ! test -f "$file" then @@ -96,6 +95,7 @@ function compile_merge_partial_dts() local dtb_dir=$1 local repo=$(echo "$2" | awk '{print $1}') local dir=$(echo "$2" | awk '{print $2}') + local partial_dts_dir local tmp local tmpdts local file @@ -123,6 +123,7 @@ function compile_merge_partial_dts() dir="." fi + partial_dts_dir="$repo"/"$dir" i=0 while test $i -lt $NUM_DOMUS do @@ -132,7 +133,7 @@ function compile_merge_partial_dts() return 1 fi - sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$repo" "$dir" + sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" if test $? -ne 0 then return 1 @@ -146,7 +147,7 @@ function compile_merge_partial_dts() for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} do file=${devpath##*/} - file="$repo"/"$dir"/"$file".dts + file="$partial_dts_dir"/"$file".dts # All the subsequent dts files should not have dts version mentioned if test $j -gt 1 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 13 12:09:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 12:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406345.648721 (Exim 4.92) (envelope-from ) id 1oY4jO-0002G1-Aw; Tue, 13 Sep 2022 12:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406345.648721; Tue, 13 Sep 2022 12:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY4jO-0002Fu-89; Tue, 13 Sep 2022 12:09:34 +0000 Received: by outflank-mailman (input) for mailman id 406345; Tue, 13 Sep 2022 12:09:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY4jM-0002Fj-O2 for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 12:09:32 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2043.outbound.protection.outlook.com [40.107.94.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb2a4e1e-335c-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 14:09:30 +0200 (CEST) Received: from BN9PR03CA0149.namprd03.prod.outlook.com (2603:10b6:408:fe::34) by CY5PR12MB6131.namprd12.prod.outlook.com (2603:10b6:930:25::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 12:09:27 +0000 Received: from BN8NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::88) by BN9PR03CA0149.outlook.office365.com (2603:10b6:408:fe::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 13 Sep 2022 12:09:27 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT044.mail.protection.outlook.com (10.13.177.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 12:09:26 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 07:09:25 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 07:09:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb2a4e1e-335c-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYgGOZugHoEZZaYF9qAyXULMUxHs0qLBN4IpoVQd4+RbG1wFo2irk//yx8KQwpmeWiq0pHA+OKxW0KEQ+WUO0c5UCZArkdI22sX8WQaKispLuuMdsu37/FA1PlxsDFtVzGswqTO++7RuDTQ/5/SCK++wMQpwtd+GF9KscqCpS4y/cl77GuDp7HeRBdPzXnQGlZGtEGVms1TJqcfxKiBO5In3Knce49Y7o4+huK7vebB3uivwNCnr9QW1zCmgQoG9yzOJBLIst7jHNDr9dJLfsDiVzwlUEFdfqest9h2ox8szUizk8fU9woO4W9GimwZYodOBPV1lyjGX7H00GSNOEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tyF0tR4xMYoYLzt3LlDRj6edeOruHgGGdZEG6tiK4DY=; b=ddgApKUMm4RJ0A8xNwECxajjS5GXYla2kuQDMxMlIDHy5S2V+uLp+nTm7x7oALt3N7OxSKOBdEip1WcRu7ah/4/RVdntY58HcNzmx/kJYHSceyjtPZZbVryBI8uRlQRI5V80gkfGH5NDFGrqRdgtHhlgbkJWU02dHo3kHBNQeHJ7wUOEIndYVQXpQlvsxNT83Ze4xXsaqmyjFrRN790REuXKe8U1OdwK006f52zUI3X32M4TS3H30czvrduORT+fswymLZCRriAcD7LSqzEapqAOpa8wlI0is91ToA2fdQsQY01d//ikdTOQ5kqJrhmOwXQRf0gMxG79B1ulDMfJEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyF0tR4xMYoYLzt3LlDRj6edeOruHgGGdZEG6tiK4DY=; b=YSQwUULqZpJx203u/5HVVqRNJWZxyvBjf+xQkoyuJO8aS9FImgBs5nfrvMT2ehP74D1VI8RhRomRKAmNU9IYt9O2faT8aPyh4ja1yu+nuY/dPB4BSWaVQUfUfnHvG7gW3SFrBtazR+AHh6eeP7tAaardxevCpHwMVLpNSUU6miU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder v2 0/2] Use lopper to generate partial dts Date: Tue, 13 Sep 2022 14:09:16 +0200 Message-ID: <20220913120918.31162-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT044:EE_|CY5PR12MB6131:EE_ X-MS-Office365-Filtering-Correlation-Id: 40b6f2bd-b6fd-4935-8c5e-08da9580cdee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ymfNSf79p5/1jx1uVyv5gcouwSfsN6ibaMP63tJBYgtNMEBzg9uipLp/4Do6W3VnXoNBUwI9c/R7Bx0+7xf4YApzwBy71yI9NFL+yLU/6DWWvw+K07G5vSU0sPpFjT8zztPriav6rdpkqUkMGZTBnyoUnpclAxqro2nQ0Cf2Owg71AJecVTUpb7s/eD49OP/x3ODrTj6pwTKGozhGQDKozUpc95KCMhORuWmTiQyed/NpDkia2A2h5ao2iybF8ae9gtqFz/BPTCLSU1j5mhQgrS1dIg74lM0ohZGqGkRfuJ464rkN8qs8oNnbN0SX0ir/GQSTcbC6ltLadGN3+b+RhT/9hO7tJ6O7aG8/riI6ygevSDWhr+uLRPji8EbT3o7IJTcEFFFT9ST7mgidK8q90QTrh6ZZ6D/cgsajDOEDY5BhU3UJ4aemJI3I05xnRr3ZjVYAAXT0qgNe3ilUAmNpv0c4qKnoVuXiOdLJJV1TRMFUD+Hrr6zi98EfxNfhos3O8zz1sZNiZGSWke7flqHYZAuRJrV+n1M357iX6mEAxpJ6PaXyv6Btb4W1OLfCiZKq/aM8oOZB3SBWzAKi43aNA8Ob7GQ5tdp2775LQg/s7YcsPLsX2IF+HWcUKnW4Pr4xcH6UjaN5WuJKGxkRK9wPWeLHhd4rxSQ9JXRcaBPDU7MbwgvLcL4+aM9ajN0njOMYyNtgLfUS/h47VuFRwS5aGPgD/JEnCZQSjVsbwZTcUOcJQDHW/4IqlHcglOmJ9m4iZmr/fl10PRWqgrZjvjG7ulEpACIwH8OrSLX87Z9Pm8way0mwiLJPCbFRABdAu+FSoZq/gqT/RO9Pefhkal2uQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(4326008)(8676002)(41300700001)(70586007)(86362001)(36756003)(6666004)(478600001)(356005)(40460700003)(40480700001)(6916009)(186003)(82310400005)(966005)(47076005)(54906003)(5660300002)(2906002)(70206006)(316002)(8936002)(81166007)(82740400003)(4744005)(36860700001)(83380400001)(426003)(336012)(44832011)(26005)(1076003)(2616005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 12:09:26.9036 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40b6f2bd-b6fd-4935-8c5e-08da9580cdee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6131 This patch series introduces support to generate automatically passthrough device trees using lopper. This feature should be used with care as the corresponding lopper changes are still in an early support state. Current integration has been tested with several devices from ZynqMP ZCU102 board e.g. serial, spi, ahci, mmc. When using this feature, make sure to use the latest lopper's master branch status [1]. [1] https://github.com/devicetree-org/lopper Michal Orzel (2): Refactor sanity_check_partial_dts Add support for lopper to generate partial dts README.md | 23 ++++++++++- scripts/common | 84 ++++++++++++++++++++++++++++++---------- scripts/uboot-script-gen | 22 ++++++++++- 3 files changed, 104 insertions(+), 25 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 13 12:09:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 12:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406347.648743 (Exim 4.92) (envelope-from ) id 1oY4jQ-0002kw-TT; Tue, 13 Sep 2022 12:09:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406347.648743; Tue, 13 Sep 2022 12:09:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY4jQ-0002kp-QH; Tue, 13 Sep 2022 12:09:36 +0000 Received: by outflank-mailman (input) for mailman id 406347; Tue, 13 Sep 2022 12:09:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY4jP-0002YT-EM for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 12:09:35 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8fe82052-335c-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 14:06:57 +0200 (CEST) Received: from BN0PR04CA0201.namprd04.prod.outlook.com (2603:10b6:408:e9::26) by BL0PR12MB4882.namprd12.prod.outlook.com (2603:10b6:208:1c3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 12:09:30 +0000 Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::7) by BN0PR04CA0201.outlook.office365.com (2603:10b6:408:e9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 13 Sep 2022 12:09:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 12:09:30 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 07:09:29 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 07:09:29 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fe82052-335c-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mt0++xon76TvOybOQqq/c4KzXztwyfdAcweGxFeFCGhFZYp25wu+H0n/AR3xzPRLbJdNdKE8Njsr4bvQEodd6pEeqmq0baC2hPvJxoxsBkweCFcOkEgLXjRkA/edIN+X4gQCO7JrhzOPXLjv2x1OqsCH96rrAKrRUPSWtvnQ1x8gvJloHf/1ljlFNBgEdeZfTlp4OVkreQx0P4JXJKg/re+oSh8vK3E6B03FDCgq6AAlSLSS785UYPCAf5g6Yn5Y5TZ7YILGOEaGai9xwgQUa146iqAdSRKD8f4BgNaj4hqfUtcbbYDxsrc+COadvOTdb+qNF8/p/JILLllBcoAc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8wTHJSvUWZwgvn3QOmXdODSY/f3JRBIovaGHJFdJ4Dw=; b=oMBr9gi0FeLnoPBFt/YdtB3ZusjycvSg+pXnlWhPUzjOjPhvOJzNJ3TkC+6ZeRjpdEkg3TBE6QixIN4UUuWXjZvp4fk9mNIjujilEUX/sluL+oeIoDf38Oloflxl+tts4fuOWp558jwzBRFCSkmSKOteysdS4qf+55ZjY4udy9UQ+GN6ocdm/DnMqzwgga8pI461KGjFQkIWqnMCTi26hnXqUjpm6B8ce+I1kv94nBtt0zGgWtYxuo4HmmizFx6Wh9D/q1fGq/zCfKRnSiaOL63biXsUEKSRn1Kc9o39HLC3hkk21P0dcN17bTjnKkP9f+A2TRYSzgP0yeTvQFppgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8wTHJSvUWZwgvn3QOmXdODSY/f3JRBIovaGHJFdJ4Dw=; b=rlnPAy1+BizH05ain82NQKcwyK9QEoXK1oyRAgnu1+po5/J9ZvvKlIpBU8OLR4Sak9dLvOWnFPRKvFs80rj1iiQKAFzPa8l8A3QrE/Sn7mRjltTeAIxEIu9KZnR9Y1doxsnkAwhpMUoJADJEZZ9BuUPGjClVpl2kClEfLrgJQ94= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder v2 2/2] Add support for lopper to generate partial dts Date: Tue, 13 Sep 2022 14:09:18 +0200 Message-ID: <20220913120918.31162-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220913120918.31162-1-michal.orzel@amd.com> References: <20220913120918.31162-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT066:EE_|BL0PR12MB4882:EE_ X-MS-Office365-Filtering-Correlation-Id: f7c64088-6f41-417e-dc2b-08da9580d00d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +3dO/v/KiIgL/hIZ7aTCyDK/j6m+JssOY3t6040uJb4JN6tZMjXdCaBGei6t1ahbuWMXEVQV6WmvMEn6SCSfqctMXgl22sCV98DYZgOvmQzRKyEXQ0Cacw7OWNd9lh8pe4x9ab0o+xLPiRN00VHDxZ4Ybcr47Usdk5YBpZdFHQzWAie0EVY8iKBYGCcwZc3wxan8mp6XeBT3Py8xJFwFurFkfNJCqYh8s4owHyz49sswthkQnQrC55Svc8yU4bEvvpWPM3bh8mpOtY2vxiaLauLbYezM0SGcLnp/eRi/iH9STQJy3UzsAi613mQ+EA+yovbNWlDFpvAIt1VvrmweSDuiYmjAtpmZniVKWP+D6Tz9Uj19O87Hf3tmYnFLQ45A6SUbVo6fJ0G31tYYKV3JzoXJNv3rAHKRgTj2LPru9d5eec/FQrgtC1jsv0cTkg8SwL9TafQqPPTSAfKHEVxXVT3Uozcpfwx5uUIMJhzRDcwqMdaI5HDJBKTTZ7/gp3dHdnLfIqytcshAJQYbzo+TiE7H/jBPVKM1asM4bn5f0mMcihi5auxNJTR6Rz8q621lIHdHb66dH4Wi3MO1Jas18Iz7LYjuh2lmtb2zjb3ESe5iR0pMP8Ryk83ymleA82hNQO88zlotBRBi4Vpbo1IL1qjN3UUJYO+Etcr7Mydrjkifuf/x+yexiIjZYyWBxPyQc3yT5G3BligARknMGvg5/bMj3rHRVhoI/iKGp/5IwOByhoIX+XcwUMcIeTFZTpFMbdpzAfRVEpoRjBQAcINUR91dxCTv9DzcGl5ivk2D47woQIBChK3DeyFfrZf+T4Y00e5FmGiM5KbrU9R+UgbitA2c34WuzAKxzvLnrPRhaL4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(36840700001)(46966006)(40470700004)(26005)(81166007)(4326008)(316002)(40460700003)(356005)(54906003)(6666004)(426003)(5660300002)(86362001)(478600001)(8676002)(82310400005)(336012)(36756003)(36860700001)(2616005)(70206006)(44832011)(1076003)(82740400003)(40480700001)(186003)(70586007)(47076005)(83380400001)(41300700001)(8936002)(6916009)(2906002)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 12:09:30.4487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7c64088-6f41-417e-dc2b-08da9580d00d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4882 Currently ImageBuilder can compile and merge partial dts obtained from a repository specified using PASSTHROUGH_DTS_REPO. With the recent changes done in the lopper, we can use it to generate partial dts automatically (to some extent as this is still an early support). Introduce LOPPER_PATH option to specify a path to a lopper.py script, the main script in the Lopper repository, that if set, will invoke lopper to generate partial dts for the passthrough devices specified in DOMU_PASSTHROUGH_PATHS. Introduce LOPPER_CMD option to specify custom command line arguments (if needed) for lopper's extract assist. Example usage: LOPPER_PATH="/home/user/lopper/lopper.py" DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" Signed-off-by: Michal Orzel --- Changes in v2: - improve documentation - update commit msg - use node=${devpath##*/} instead of file=${devpath##*/} --- README.md | 23 ++++++++++-- scripts/common | 77 ++++++++++++++++++++++++++++++---------- scripts/uboot-script-gen | 22 ++++++++++-- 3 files changed, 100 insertions(+), 22 deletions(-) diff --git a/README.md b/README.md index da9ba788a3bf..f4213d570033 100644 --- a/README.md +++ b/README.md @@ -128,6 +128,20 @@ Where: - DT_OVERLAY[number] specifies the path to the hosts device tree overlays to be added at boot time in u-boot +- LOPPER_PATH specifies the path to lopper.py script, the main script in the + Lopper repository (https://github.com/devicetree-org/lopper). This is + optional. However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] + needs to be specified. uboot-script-gen will invoke lopper to generate the + partial device trees for devices which have been listed in + DOMU_PASSTHROUGH_PATHS[number]. This option is currently in experimental state + as the corresponding lopper changes are still in an early support state. + +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. + This is optional and only applicable when LOPPER_PATH is specified. Only to be + used to specify which nodes to include (using -i ) and which + nodes/properties to exclude (using -x ). If not set at all, the default + one is used applicable for ZynqMP MPSoC boards. + - NUM_DOMUS specifies how many Dom0-less DomUs to load - DOMU_KERNEL[number] specifies the DomU kernel to use. @@ -140,7 +154,7 @@ Where: - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( separated by spaces). It adds "xen,passthrough" to the corresponding dtb nodes in xen device tree blob. - This option is valid in the following two cases: + This option is valid in the following cases: 1. When PASSTHROUGH_DTS_REPO is provided. With this option, the partial device trees (corresponding to the @@ -149,7 +163,12 @@ Where: Note it assumes that the names of the partial device trees will match to the names of the devices specified here. - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only + 2. When LOPPER_PATH is provided. + With this option, the partial device trees (corresponding to the + passthrough devices) are generated by the lopper and then compiled and merged + by ImageBuilder to be used as DOMU[number] device tree blob. + + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only add "xen,passthrough" as mentioned before. - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees diff --git a/scripts/common b/scripts/common index ccad03d82b30..2dd98fb94d3e 100644 --- a/scripts/common +++ b/scripts/common @@ -9,6 +9,9 @@ # - NUM_DOMUS # - DOMU_PASSTHROUGH_PATHS # - DOMU_PASSTHROUGH_DTB +# - LOPPER_PATH +# - LOPPER_CMD +# - DEVICE_TREE tmp_files=() tmp_dirs=() @@ -99,31 +102,41 @@ function compile_merge_partial_dts() local tmp local tmpdts local file + local node local i local j - if [[ "$repo" =~ .*@.*:.* ]] + if test "$repo" then - tmp=`mktemp -d` - tmp_dirs+=($tmp) - - echo "Cloning git repo \"$git_repo\"" - git clone "$repo" $tmp - if test $? -ne 0 + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO + if [[ "$repo" =~ .*@.*:.* ]] then - echo "Error occurred while cloning \"$git_repo\"" - return 1 - fi + tmp=`mktemp -d` + tmp_dirs+=($tmp) - repo=$tmp - fi + echo "Cloning git repo \"$git_repo\"" + git clone "$repo" $tmp + if test $? -ne 0 + then + echo "Error occurred while cloning \"$git_repo\"" + return 1 + fi - if test -z "$dir" - then - dir="." + repo=$tmp + fi + + if test -z "$dir" + then + dir="." + fi + partial_dts_dir="$repo"/"$dir" + else + # Partial dts will be generated by the lopper + tmp=`mktemp -d` + tmp_dirs+=($tmp) + partial_dts_dir="$tmp" fi - partial_dts_dir="$repo"/"$dir" i=0 while test $i -lt $NUM_DOMUS do @@ -133,6 +146,34 @@ function compile_merge_partial_dts() return 1 fi + if test -z "$repo" + then + # Generate partial dts using lopper + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} + do + node=${devpath##*/} + file="$partial_dts_dir"/"$node".dts + + # Execute lopper with the following assists: + # - extract: used to take the target node, extract it from the + # system device tree, chase the phandle references and place + # it in a new extracted tree structure, + # - extract-xen: used to perform Xen specific modifications + # on the extracted tree structure e.g. adding "xen,path", + # "xen,reg", interrupt-parent properties. + # For additional information, please see the lopper's README + # file as well as usage of the mentioned assists. + $LOPPER_PATH --permissive -f $DEVICE_TREE \ + -- extract -t $devpath $LOPPER_CMD \ + -- extract-xen -t $node -o $file + + if test $? -ne 0 + then + return 1 + fi + done + fi + sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" if test $? -ne 0 then @@ -146,8 +187,8 @@ function compile_merge_partial_dts() for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} do - file=${devpath##*/} - file="$partial_dts_dir"/"$file".dts + node=${devpath##*/} + file="$partial_dts_dir"/"$node".dts # All the subsequent dts files should not have dts version mentioned if test $j -gt 1 diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 1f8ab5ffd193..b24dca2b7f7e 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -1138,10 +1138,28 @@ fi # tftp or move the files to a partition cd "$uboot_dir" -if test "$PASSTHROUGH_DTS_REPO" +# If both PASSTHROUGH_DTS_REPO and LOPPER_PATH options are specified, +# the former takes precedence because the partial device trees are already +# created (probably tested), hence the reliability is higher than using lopper. +if test "$PASSTHROUGH_DTS_REPO" || test "$LOPPER_PATH" then output_dir=`mktemp -d "partial-dtbs-XXX"` - compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" + if test "$PASSTHROUGH_DTS_REPO" + then + compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" + else + if test -z "$LOPPER_CMD" + then + # Default for ZynqMP MPSoC. + # The following command instructs lopper's extract assist to always + # include zynqmp-firmware node (as it contains e.g. clock-controller + # required by most of the devices) in the extracted tree structure + # and to drop nodes/properties during the extraction process that + # are not needed. + LOPPER_CMD="-i zynqmp-firmware -x interrupt-controller -x pinctrl -x power-domains -x resets -x current-speed" + fi + compile_merge_partial_dts $output_dir + fi if test $? -ne 0 then # Remove the output dir holding the partial dtbs in case of any error -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 13 12:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 12:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406373.648754 (Exim 4.92) (envelope-from ) id 1oY5Kr-0008EG-0y; Tue, 13 Sep 2022 12:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406373.648754; Tue, 13 Sep 2022 12:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5Kq-0008E9-TA; Tue, 13 Sep 2022 12:48:16 +0000 Received: by outflank-mailman (input) for mailman id 406373; Tue, 13 Sep 2022 12:48:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5Kp-0008E3-3K for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 12:48:15 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-westcentralusazlp170100000.outbound.protection.outlook.com [2a01:111:f403:c112::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 530d1c91-3362-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 14:48:13 +0200 (CEST) Received: from PH0PR05MB8703.namprd05.prod.outlook.com (2603:10b6:510:bd::5) by BN6PR05MB3571.namprd05.prod.outlook.com (2603:10b6:405:3d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 12:47:47 +0000 Received: from PH0PR05MB8703.namprd05.prod.outlook.com ([fe80::ae59:5c22:5ddd:bec8]) by PH0PR05MB8703.namprd05.prod.outlook.com ([fe80::ae59:5c22:5ddd:bec8%7]) with mapi id 15.20.5632.012; Tue, 13 Sep 2022 12:47:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 530d1c91-3362-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtJpkbfq49CR2jtKrSjJ/4RMcsn+F8k2+MFY5KM6Wm0timcEqozRLg8BfpTtl8W+PkMYcqSoAE+hIVToQEycYt3ajw5aS/xzKn18Y5ySX2RBL6LnvuzubfBJRDdoio7LGn/1GMDwVIvnhxr5f2umJVyirZ6G/zZUR9b3gzWUZWos6V79HdPrf2BlT2mb7nOeNgb0KvHw5zkC1/e6SzMZiq7exopADAYb7ckrOf5MHx+AypAvGBefvKntMLjrGTy4DDmR0auy63slDvbGUQM/3HQ+bXOCzSrX3TtmxeST5qgqcN4YqTciCuzhDdKD3pGLmgDAQEO6fFoLkGju+UmjDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+1kM91Agf12XoqrQQtWbE4p8Mh3i7XKkWF6wocbZT10=; b=AhfBu1t1gCQfhnwpkv5AWFm1CCwEindEAB+3yav0C2Ic7Cm4xM0V5jjkPKdV/bLus2PPqnbZo7yDxrnsO6TRbIzGdzWpDuhVLxmIz7Pyl53v2Nb8p/Yo/nUaJULKSaX1S82HaE6iUMJejT1C2v/CkmskwZZOAWVPOLi0pzf3vf4AvVS0PukuYlS+DJKPNi6iA2unz41thbmC3Gw0AVYhSWgKaHVCT5+ejQMmyxxOGREGzSUTuROBcyoPNXj3YGpMUJAVyCRYOS+k1et+Iz7e/9awHxdp99PTBj5Ooepg/ZndWFB+93kpjvulDTQX+ynKsAsir9M63NRwQ0BbUeszDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+1kM91Agf12XoqrQQtWbE4p8Mh3i7XKkWF6wocbZT10=; b=0wkubBF3Ansn8Y0O/MeQTiMdpckfPpNT6Dv1kPwH/kyooSDlHiZC0q3kwSmYFiEwGr2vXPMni/j8QtDghz+nnWyR4lHU4+6CJqrxS3Srr485d/RNMrX9EvtbWpe+8eeN0p9Ac5TIBuhHinOdWM26etEDrZOr1VQ3p1mNykoEKFs= From: Ajay Kaher To: Vitaly Kuznetsov CC: "x86@kernel.org" , "hpa@zytor.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , Srivatsa Bhat , "srivatsa@csail.mit.edu" , Alexey Makhalov , Vasavi Sirnapalli , "er.ajay.kaher@gmail.com" , "willy@infradead.org" , Nadav Amit , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "jailhouse-dev@googlegroups.com" , "xen-devel@lists.xenproject.org" , "acrn-dev@lists.projectacrn.org" , "helgaas@kernel.org" , "bhelgaas@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , Alexander Graf Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor Thread-Index: AQHYx28G+J2WSwxm3kmFzqoOhSDYUA== Date: Tue, 13 Sep 2022 12:47:47 +0000 Message-ID: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> Accept-Language: en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/16.61.22050700 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR05MB8703:EE_|BN6PR05MB3571:EE_ x-ms-office365-filtering-correlation-id: 83ae9ce5-2764-4abe-962c-08da95862952 x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S6okgQKDNU7YC6DCZz5r6q/JLVAi66A29Certi1a09DKAj2U3ScSe2Wqij6E4e5JZKVxIpBVgRWP372d2SOH23IWP+PfLx8NbboCkx7XRJIMZK2WOcHHkEu5acp3GMBkoRHzvwwoLj3h0neERprKGcRT70J3BzEC2KCxnTySsn5WymAl4TFbDwVW0FAdncvJNMEh75iBO32pFAlx342ZZF2cer8V9ZSrLC8jTKDS8rK0A/KZZVO333EVrrykBqMrnfMwPteQFiI4jxOZQx+fH/WXDq3XDq/+j/ATqtDzG6uK/33Iz9kvtEonWN9xV3USsFW9qfzuiRATZqO03QxE40CteHP4ef8EdciZ5v836sf/Ku9WBftBrvcbjX8MLFsblowncAMPFZBbgs2QMXzXTcpV22ZCy2MFLNfPdDfFmVaL2k8i+efjoLqc3DzNqOscEkOKQC8S4U4u7hlr1Uyp6M0AUoUZLusdEtwfUIyCZsWNdZplRLOSH+EgWCEYWkFpNKlMzoOcGsek9cVXCOw6ZmMgyYHnKvbmMM5pnwwveGAl5BoLI0epv6GSQf77+2OXYbCOmVBulRy2QbpvwZuZXI6NoLgUuucAh31a9XhZu018PfgMLC35ntX+frT5AG2e7Z5fusDx96LvWjldRv5XX0KdV1ruzSMSOt1Mwe/J4DH9C3XKt+EohDBHbTqe+pzm9Dyq17deniBTyQv590MjEs/dDqK9Ou4mj0UAAvBOLUkyssc0WSYKk9R9P2JX+Nn6f/lOxSoxiTrdyD50qFHwjanm1pMronbvUHrjKILE9ibRgGS/9XA3u4NzXi/kPThNsQm6emcAHnqosETKogacvWPec//5mcTCyYr/bTcGYnY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8703.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199015)(6916009)(71200400001)(6506007)(478600001)(186003)(66946007)(6512007)(41300700001)(86362001)(38070700005)(8676002)(26005)(2616005)(33656002)(6486002)(91956017)(36756003)(2906002)(66446008)(7416002)(8936002)(122000001)(54906003)(66476007)(64756008)(66556008)(76116006)(38100700002)(316002)(5660300002)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y1JWM2JXVDFVaGl1SDlUand5UXZJNG9ZczIwWmdyVjQ2a21PZjBtdDhudkI4?= =?utf-8?B?RlN1SmpzallyOTg4SGdkb1A0cGdRRUhPS0R1eDBoZlhHTTFqVExsckE2OWFi?= =?utf-8?B?N004dC9tT001VVd1M3Btc2RPT3I5Z1NBN0hZZUJYMHdGWG1mZjhwSHFDUnRa?= =?utf-8?B?ZXJFdis5WGJqQXM0d2xBR0FEdmx0YnlOS3RyRk5mbnFjVVJoNXlaTmIxMERt?= =?utf-8?B?eHl3SDhTVFdJK1RVd1cwb21aSEN4VWdVeDJQaVVJeVpLbkFVdDkxcng2RXBD?= =?utf-8?B?eXZISnhkakhXRUFkWnJlWW1POHNaZ2hOSWdocGJWV3R4dTV0b285ZjVXM3lN?= =?utf-8?B?ZWZPbjAxeEVqSFlHaUNza1JzcUhXR3lTbWlYaXNsVmk4MzVRMytjaTQzU0Fn?= =?utf-8?B?eWt4MTJEZXlBV1pzaEFMOHhFQ3dKZUVpdHNOdVBVeTdMcEZFOXBSM0Z5cnU0?= =?utf-8?B?Y2lxdkRUUkM3RVN5NlhHL045SEV5eUw1U3kzK0FVNkp2NjhDNFFMcXU2RzNR?= =?utf-8?B?dGNlS0xIU1IzUEIzbFVjTm5OQ0lJeW1UR081NWRVWkZNbWhJMVFTZ1kvdkJQ?= =?utf-8?B?eUhWak5MeVJ6ZFpMMGI2Q2o1MDNydFhKQTNZQ0ZkVnhHS2JHUVJNR2lTM0Zs?= =?utf-8?B?aG1JWnNIcStZNnIwVkZ5anVHWFczaTVJaHBuODlJTGdETkFkczM3cWJtc3dh?= =?utf-8?B?cHVSa3A4bjBVeFI5aFBGQytNb1lLZ29RVnhlOC9CYjRjYkRIa3VKbUJ1Mmp1?= =?utf-8?B?WkN6NEt1Z1QyajJLOUJYTjg1NlpkZm0zVWFHcGxLanE1ZHB2dnJVcnZGM3pk?= =?utf-8?B?ZTE4ZzdyeWRvazRUSGVZWmE5amJKVkgzUjZKOFpDenVmRi8waisyQ0FtRE04?= =?utf-8?B?aFBvR3Eway9vZEMvekJRYndFVUNyR0hkWTFndVdBNUg3cHpMUXRRN01ybTB3?= =?utf-8?B?b2ZOdGtSaXZoNlhGVWJzOUcrbTVZN2hvVjZpRlJoT2ptSWNhdEdxdWxsN3d3?= =?utf-8?B?UkptQ3NHSWlIcVdVS3J5emNLT1NtTHF5bFdMNmlKSDhPNk4wUmFhMEUwazQz?= =?utf-8?B?TUtrek5CUDVFZi9VRG5PQzVPaUtNREZJcGpjL3VTSjZNVnRLS2N2bWl3MThR?= =?utf-8?B?Q3ZBUHJ2a0I1U2pRVUxZM0ZaZ1lrNmJKUnRxZ2lyTUdaL2NiVUpzYjNFait2?= =?utf-8?B?Z2V0YkZuUEVqTXRoMTNLT2F3S3JhQmhoMGdyUlVQT2RaM1VndGtVZ3dyd0ow?= =?utf-8?B?bVNPWlRLSlJGV1dJdE5tTUpMNWxJaDcvajNSMHU1NFdSMzNIeWhTQnY5eDN2?= =?utf-8?B?RDBqbWdMSHFNYy9sZHZsYktVVE9kc0hYY1MwVSs4KzUrcjJ0em9EeE0wNXpj?= =?utf-8?B?TW80V3RZMkVmUGRKTUkwVVRkaW0vcHY1VXRQY0hpQWVsUzRKbTJIektwNnJ2?= =?utf-8?B?MnR5MkNtdFVSVVhYS2ZvRUUyY01SM05kUytvZXpkOGVXZU1YTnRldDZQbE9T?= =?utf-8?B?ODBZZXEybzJGVjNGcVdaamVITFNVOGZpRmlId08xNXNPTURJOURVM0Q4QmJh?= =?utf-8?B?NEdwTVBtamhZbkVLYjhuWHlwY0lybldSSm9aUkI1UXdWOUxoczAyaW56am9s?= =?utf-8?B?RnowNERhZzNHeStCb3R6UjFUdGpHSlQ5aDZ6TDc0MWZNSXdHOC84RlNZa2NV?= =?utf-8?B?NVhtbzJkcjBySXdoN2lxMzMwNnlmM1RuN3RhdFVTOWFOTFA2R1pubElmN1pF?= =?utf-8?B?UGFSaEtZSXRSTG5YOGI3SkFHVlRhS1oyQndZT1RDbXhpVllMTDNBZERIYU5Y?= =?utf-8?B?cjZOY0JMbzVuL09TL045a01rbWF5SGtDa1AyL1dZTDBTM2xmQmFvQi9MN1Iw?= =?utf-8?B?eTZqRmduM0tyZHhnT3pBL016M1A2MWptRnUzZW5EU3FJRXFJaU50dTd2KzJ4?= =?utf-8?B?K0dFcEJoYnY0QzcvRGJSUU9jNmI2V2JnbFplbFdsS25RUlIvVXVLQkNXOHJG?= =?utf-8?B?cjFleXdQUXZvZnUrS0s2MlVjcENCTDJUU2Z1VGU1VW1vaU1LWGx2Q2tqWWxv?= =?utf-8?B?NGZlL3RSMTJFWFJmZGwwY3QwWk9NS3VmL1RXc0xKNVJzdVJWSnRMNldSSFBi?= =?utf-8?Q?Ou47ZUQSWaVMRp/nDBS9keO0v?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3571 DQpOb3RlOiBDb3JyZWN0ZWQgdGhlIFN1YmplY3QuDQoNCj4g77u/T24gMDcvMDkvMjIsIDg6NTAg UE0sICJWaXRhbHkgS3V6bmV0c292IiA8dmt1em5ldHNAcmVkaGF0LmNvbT4gd3JvdGU6DQo+DQo+ PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYvcGNpL2NvbW1vbi5jIGIvYXJjaC94ODYvcGNpL2NvbW1v bi5jDQo+PiBpbmRleCBkZGI3OTg2Li4xZTVhOGY3IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYv cGNpL2NvbW1vbi5jDQo+PiArKysgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMNCj4+IEBAIC0yMCw2 ICsyMCw3IEBADQo+PiAgI2luY2x1ZGUgPGFzbS9wY2lfeDg2Lmg+DQo+PiAgI2luY2x1ZGUgPGFz bS9zZXR1cC5oPg0KPj4gICNpbmNsdWRlIDxhc20vaXJxZG9tYWluLmg+DQo+PiArI2luY2x1ZGUg PGFzbS9oeXBlcnZpc29yLmg+DQo+Pg0KPj4gIHVuc2lnbmVkIGludCBwY2lfcHJvYmUgPSBQQ0lf UFJPQkVfQklPUyB8IFBDSV9QUk9CRV9DT05GMSB8IFBDSV9QUk9CRV9DT05GMiB8DQo+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfUFJPQkVfTU1DT05GOw0KPj4gQEAgLTU3LDE0 ICs1OCw1OCBAQCBpbnQgcmF3X3BjaV93cml0ZSh1bnNpZ25lZCBpbnQgZG9tYWluLCB1bnNpZ25l ZCBpbnQgYnVzLCB1bnNpZ25lZCBpbnQgZGV2Zm4sDQo+PiAgICAgICByZXR1cm4gLUVJTlZBTDsN Cj4+ICB9DQo+Pg0KPj4gKyNpZmRlZiBDT05GSUdfSFlQRVJWSVNPUl9HVUVTVA0KPj4gK3N0YXRp YyBpbnQgdm1fcmF3X3BjaV9yZWFkKHVuc2lnbmVkIGludCBkb21haW4sIHVuc2lnbmVkIGludCBi dXMsIHVuc2lnbmVkIGludCBkZXZmbiwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpbnQgcmVnLCBpbnQgbGVuLCB1MzIgKnZhbCkNCj4+ICt7DQo+PiAr ICAgICBpZiAocmF3X3BjaV9leHRfb3BzKQ0KPj4gKyAgICAgICAgICAgICByZXR1cm4gcmF3X3Bj aV9leHRfb3BzLT5yZWFkKGRvbWFpbiwgYnVzLCBkZXZmbiwgcmVnLCBsZW4sIHZhbCk7DQo+PiAr ICAgICBpZiAoZG9tYWluID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzKQ0KPj4gKyAg ICAgICAgICAgICByZXR1cm4gcmF3X3BjaV9vcHMtPnJlYWQoZG9tYWluLCBidXMsIGRldmZuLCBy ZWcsIGxlbiwgdmFsKTsNCj4+ICsgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gK30NCj4+ICsNCj4+ ICtzdGF0aWMgaW50IHZtX3Jhd19wY2lfd3JpdGUodW5zaWduZWQgaW50IGRvbWFpbiwgdW5zaWdu ZWQgaW50IGJ1cywgdW5zaWduZWQgaW50IGRldmZuLA0KPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZWcsIGludCBsZW4sIHUzMiB2YWwpDQo+PiAr ew0KPj4gKyAgICAgaWYgKHJhd19wY2lfZXh0X29wcykNCj4+ICsgICAgICAgICAgICAgcmV0dXJu IHJhd19wY2lfZXh0X29wcy0+d3JpdGUoZG9tYWluLCBidXMsIGRldmZuLCByZWcsIGxlbiwgdmFs KTsNCj4+ICsgICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcgPCAyNTYgJiYgcmF3X3BjaV9vcHMp DQo+PiArICAgICAgICAgICAgIHJldHVybiByYXdfcGNpX29wcy0+d3JpdGUoZG9tYWluLCBidXMs IGRldmZuLCByZWcsIGxlbiwgdmFsKTsNCj4+ICsgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gK30N Cj4NCj4gVGhlc2UgbG9vayBleGFjdGx5IGxpa2UgcmF3X3BjaV9yZWFkKCkvcmF3X3BjaV93cml0 ZSgpIGJ1dCB3aXRoIGludmVydGVkDQo+IHByaW9yaXR5LiBXZSBjb3VsZCd2ZSBhZGRlZCBhIHBh cmFtZXRlciBidXQgdG8gYmUgbW9yZSBmbGV4aWJsZSwgSSdkDQo+IHN1Z2dlc3Qgd2UgYWRkIGEg J3ByaW9yaXR5JyBmaWVsZCB0byAnc3RydWN0IHBjaV9yYXdfb3BzJyBhbmQgbWFrZQ0KPiByYXdf cGNpX3JlYWQoKS9yYXdfcGNpX3dyaXRlKCkgY2hlY2sgaXQgYmVmb3JlIGRlY2lkaW5nIHdoYXQg dG8gdXNlDQo+IGZpcnN0LiBUbyBiZSBvbiB0aGUgc2FmZSBzaWRlLCB5b3UgY2FuIGxlYXZlIHJh d19wY2lfb3BzJ3MgcHJpb3JpdHkNCj4gaGlnaGVyIHRoYW4gcmF3X3BjaV9leHRfb3BzJ3MgYnkg ZGVmYXVsdCBhbmQgb25seSB0d2VhayBpdCBpbg0KPiBhcmNoL3g4Ni9rZXJuZWwvY3B1L3Ztd2Fy ZS5jDQoNClRoYW5rcyBWaXRhbHkgZm9yIHlvdXIgcmVzcG9uc2UuDQoNCjEuIHdlIGhhdmUgbXVs dGlwbGUgb2JqZWN0cyBvZiBzdHJ1Y3QgcGNpX3Jhd19vcHMsIDIuIGFkZGluZyAncHJpb3JpdHkn IGZpZWxkIHRvIHN0cnVjdCBwY2lfcmF3X29wcw0KZG9lc24ndCBzZWVtcyB0byBiZSBhcHByb3By aWF0ZSBhcyBuZWVkIHRvIHRha2UgZGVjaXNpb24gd2hpY2ggb2JqZWN0IG9mIHN0cnVjdCBwY2lf cmF3X29wcyBoYXMNCnRvIGJlIHVzZWQsIG5vdCBzb21ldGhpbmcgd2l0aC1pbiBzdHJ1Y3QgcGNp X3Jhd19vcHMuDQoNCkl0J3MgYSBnZW5lcmljIHNvbHV0aW9uIGZvciBhbGwgaHlwZXJ2aXNvciAo c29ycnkgZm9yIGVhcmxpZXIgd3JvbmcgU3ViamVjdCksIG5vdCBzcGVjaWZpYyB0byBWTXdhcmUu DQoNCkZ1cnRoZXIgbG9va2luZyBmb3IgZmVlZGJhY2sgaWYgaXQncyBpbXBhY3RpbmcgdG8gYW55 IGh5cGVydmlzb3IuDQoNCi1BamF5IA0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 13 12:55:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 12:55:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406381.648765 (Exim 4.92) (envelope-from ) id 1oY5RP-0001NR-M4; Tue, 13 Sep 2022 12:55:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406381.648765; Tue, 13 Sep 2022 12:55:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5RP-0001NK-JC; Tue, 13 Sep 2022 12:55:03 +0000 Received: by outflank-mailman (input) for mailman id 406381; Tue, 13 Sep 2022 12:55:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5RO-0001NE-JU for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 12:55:03 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4649f7c8-3363-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 14:55:00 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.94.2 #2) with local (return-path ijackson@chiark.greenend.org.uk) id 1oY5RK-0005Cw-By; Tue, 13 Sep 2022 13:54:58 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4649f7c8-3363-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=chiark.greenend.org.uk; s=i.chiark; h=DKIM-Signature-Warning:References: In-Reply-To:Subject:Cc:To:Date:Message-ID:Content-Transfer-Encoding: Content-Type:MIME-Version:From:Sender:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=u/mf5+XHxvC2Vr8pe+4W6SHH4hwWcKDEX1QmTz6fzTM=; b=g4+NZbXVpT2H KBI64rp9FZEEASzsDCcVt1r1fb+aEasf8RRJL53oStBjLolnHmdNNLoGGVE5Jh+7+xLIjXNV1jciN fMuMQaK+J/9s9l2CxhGdWT3ZPlUbYthuBOAlq6x/amzNotOXIpttJ0gXTwsDtNhvkvq8XmpU3YmNu /jdw5FCsfePrkVc9czuusupc+8Mu6wYEzFpBgEIySdz3284UzC7OsThYhA96F/G5pqyFkM65l97Fq jzzxPr0A6tyQuHxyt30A7aBxzXHZ2wBv5H1Ky9c5/ymSkFw+w6xu5csp1fPa3DHXasTRv5vhXYElh qNyiLvgDOGoUxHSyhysjhA==; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <25376.32116.525864.165666@chiark.greenend.org.uk> Date: Tue, 13 Sep 2022 13:54:12 +0100 To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Anthony PERARD , Julien Grall Subject: Re: [PATCH] libvirt: disable Werror for non-libvirt flights In-Reply-To: <20220913100328.27771-1-roger.pau@citrix.com> References: <20220913100328.27771-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 27.1 (x86_64-pc-linux-gnu) DKIM-Signature-Warning: NOTE REGARDING DKIM KEY COMPROMISE https://www.chiark.greenend.org.uk/dkim-rotate/README.txt https://www.chiark.greenend.org.uk/dkim-rotate/ab/abe9e63fcd017dfafc3d4f51a03e88e5.pem Roger Pau Monne writes ("[PATCH] libvirt: disable Werror for non-libvirt flights"): > Current usage of Werror=switch-enum by default for libvirt builds out > of the git tree causes issues when new items are added to libxl public > API enums if those are used in a switch statement in libvirt code. > This leads to libvirt build failures for seemingly unrelated libxl > changes. > > In order to prevent those errors from blocking the push gate, disable > Werror for libvirt builds when not in a libvirt specific flight. > > The errors will be reported on the libvirt flight, and block the > pushes there. So the author of the changes in libxl is still expected > to send a fix to libvirt code. This is no ideal, but the other option > is to just disable Werror for all libvirt builds and let libvirt > developers fix the breakage when they notice it. .. > +build-i386-libvirt autogen_options --disable-werror We have no way to specify -Wno-error-switch-enum specifically ? (I'm not sure if that would be desirable.) > I'm unsure whether we want o disable Werror even for libvirt flights, > but this seems more conservative. Probably disabling it only for Xen is right. Ian. -- Ian Jackson These opinions are my own. Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 13:16:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 13:16:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406391.648776 (Exim 4.92) (envelope-from ) id 1oY5lT-0003zD-Ec; Tue, 13 Sep 2022 13:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406391.648776; Tue, 13 Sep 2022 13:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5lT-0003z6-Am; Tue, 13 Sep 2022 13:15:47 +0000 Received: by outflank-mailman (input) for mailman id 406391; Tue, 13 Sep 2022 13:15:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5lR-0003z0-PK for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 13:15:45 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ad5f0d0-3366-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 15:15:43 +0200 (CEST) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 09:15:10 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6272.namprd03.prod.outlook.com (2603:10b6:a03:3aa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Tue, 13 Sep 2022 13:15:08 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 13:15:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ad5f0d0-3366-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663074943; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6apVp30A8UXW/FTsQydNAJQiPAcvMjf6hCSgcJ3OH6k=; b=EKYaqSiaIe42GnMK7Dxl/Ph5nyYSKktMSngzI68mDA/B9zKIIwWyNtXd bNeNNgTC5LMqkdDbVoEQ3ztqxTVKyzhqSiTzvBxJkNWIejHSfKZGeTnHO 0pawderi0kzL/fUGcPUTJ3iqGAPJcrQDbMVdPYwIn/2RfpCiDqBLmSgmi w=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 82911856 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:EqG7yKMlE+Z8QIzvrR2KlsFynXyQoLVcMsEvi/4bfWQNrUolgmQEn zQZCG2CM6yIZGGnKopxOo6/9xsCv5fRzdBrGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMuvvY8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPs2vFyEk06GrQG//9LCGBN0 KMSKBA0O0Xra+KemNpXS8FKr+F6dYzAG9pavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr2wCCgLVW0q3rMzUYzy3LUwwFrlqDkLfLee8CQRNUTlUGdz o7D1zSjU0hDZIHBodaD2licguWVjC3iY6QDEYWc3dpA3VPNxHNGXXX6UnP++5FVkHWWWtBWI E8P/SwGpqgz/VaoCNbnUhC+rXiI+BkGVJxNEIUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRtrbmURHS15rqS6zSoNkAowXQqYCYFSU4O5IDlqYRq1xbXFI88Tuiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAtAGzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:++b7EqONIg86PsBcTyT155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2cqYRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv70voxKhNNKWs2N 60TJiAtIs+O/P+PpgNcNspcI+QNlHnZy7qHSa7HWnHfZt3S04l7aSHqIkI2A== X-IronPort-AV: E=Sophos;i="5.93,312,1654574400"; d="scan'208";a="82911856" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBcKJelxpiUuP5FevrMff+ArH2fOSXRNeJYyIPidXszwNEeonKI6bGmHrIcybWrwPVUrjxOAc9goUrrPpjWwwJXuF7qiM/xKpG7xsYu1QTjZC5RyPS+KquL54q5HO/kU0TkQ5qJ4qoUCqVhA4/uUPun14Kdi1dpbiGImjPyKbJKfQX/+iFqOBs+SPe8ojeSqODDoAmWKxjoetWJqGj2Tn8I5pJCyICzUD5PMzcmJydnh0dySBHR5BPmDlG3pY7SK3LkRsuUkY3mZ6K35B+CuVKa2XuYzozQdmSGsP3p1mic7EQTew/Hahfnz+K/siwGbmbgtjDNew4gCnGi20YmB0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2wxWZwwEf++RQVQliz6rN3H76q7ry3k9nfOI8TQn3zU=; b=k2q4TuymRkHlAS3nLc3HR1jpBKrprqWGu5/dOJwzqkLzga3a8LpdZ53LIBIk37qPf0rtjHQrmbCTfB5frWJHriVDoRPX9crVdchmXKgJ5yFgSsf4KBMLYuf2Tg1TUZgCTRxM6murqBUU/ZlHkZMBc8NtFsVUsL+OtvUgzfXvhSN6Pa6k4NiF6PvZZGBVRSu0zI9srPTxEvhUyyvsZOlrptzo41xD4vPrmBsoRXL84Ftcp4U6EVzsds8VX0SBTqMBIVrn75NyOiDEeXBqO1ktWC4Unu9Nm/cjNKfK8pO/eOEK9JKReTtgjWj5kXC+DXt+eVqs0dTWz+Ozx5Kyehqt7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wxWZwwEf++RQVQliz6rN3H76q7ry3k9nfOI8TQn3zU=; b=L8kemj/I+CdxOMtzPpmocW6QeMQuB99hGOlYiLAb0EBv4TqA8ZNNqK8CCIDHHDUPt2a3x/IyYLb6hzXtUDuc7oG4Lg/Ch6AZb0+YhDhjTetC5hwGNmYSDkus4Z/CpNAEfUu/F5AKOMB1YvS6mH6L7CrjrETKwbsXNrascTv6x1U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 13 Sep 2022 15:15:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Anthony PERARD , Julien Grall Subject: Re: [PATCH] libvirt: disable Werror for non-libvirt flights Message-ID: References: <20220913100328.27771-1-roger.pau@citrix.com> <25376.32116.525864.165666@chiark.greenend.org.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <25376.32116.525864.165666@chiark.greenend.org.uk> X-ClientProxiedBy: MR2P264CA0031.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|SJ0PR03MB6272:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a55fc3a-88d0-4280-4246-08da9589fae5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BzUN4tI6dmtN4Ct4ZT3XnHdb3jLaSUN/9PAas9VbxHRtwm/vlcL4oOATsfenBMxXEx7SByiW7ZML/gLkZUtr1LC/hHEKbeVPSMvbpViujB2GeYD/LGgXKFD3v2nVLmddQoLaErY311D6ZTY+J6CrVbwGI0APXWH0f3+ZlVCigBQ7H1IG29JkvaFEWcyGglpgAAcM4VoLFXVbBnofMogjdO3glrAM9zOloVOmxvpUfqcd7iyeTaUVc2xAtEZMBno4ltEephJTohiaac27RVwMzkEjT6VujuuCWnUrBFxCW6ylrFgaoSyysnS3TNzcANB9lbc1KN9cCEzUAAsWbUSZd2J2mlFg1tnqk4lxqtlP5uHqKZBG2ZjoN3F9k+g7CCUwmsOpdGG5JfStnpIF3u5T+TtMWPAUL8Xu4jytpmx8l5w3QWrbRswZ38gsTDTcmzQAbjZBfnCr0vm9sGqvjafcTMK2jVIhy6Wtybtfw3Ne3yVkO06Myr5Ra1uHasFcRGmMNkYycI8WWsmCizTyPahgb6Cpmlr4Wp4RUj2WmsBAOg08Te0WHEnDVdlzgtOyU2ver1TQg/7N2xuFA2eapijOBkQJUI96pKq6WVJ453zQ0S0RjD41UnsElSxhac/S0GegOAiSyuBc6LaFU9usjS4RELju3F66P46oUmwCnnHCx8lrspyMAQCchdd+LrC4FFN0oGeFy5KcXluRgG8WxiAUhg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199015)(66556008)(4326008)(6486002)(66946007)(2906002)(8936002)(186003)(478600001)(6666004)(9686003)(6512007)(26005)(38100700002)(8676002)(83380400001)(82960400001)(85182001)(5660300002)(86362001)(6916009)(54906003)(316002)(41300700001)(6506007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkRIZmYrNlpod0sybFc2bG9NUFRqaklXSUQzam1SVWtXMDZyWjhrcGFSN3VT?= =?utf-8?B?c3ZodnZKL1lxeHJPSnZqTXEwU3d5Q1QyREhUMllzdHBkOStlelJ1anR6R2do?= =?utf-8?B?OTh1ejhJWmN3Z0k4US9GRlF0QXpOWk1LT0lva3ZUaSsxT3FzaEM3TkorU25p?= =?utf-8?B?U0RlNXBzaTNTS1NueTlxVTVpSUVPVXpVazNoWE5mYmxQV0VyZlQ4b1BsZTRC?= =?utf-8?B?UU9ZT09HbU1VWkt1NzREZzBhSXpwcXZFYk5FczhOMkNQY04vcFVid1M0alV1?= =?utf-8?B?WGNwNUp2RnZqTnZOaW4xanFjTEZPS01mSlYrZ3Y2aGN1NnJHakEzTENGdTZj?= =?utf-8?B?TFVzb2FnUklySENqTlZhNWtUTzcyQm5EWUYwMDBIWmc1YmwyQ1hzNUxKRG0r?= =?utf-8?B?NEc2ZWRYRCtVSUlJVmJaRmRDVU1xeTZzaFY1bWhvQUpRcGdIZ2w0WkY3RlR0?= =?utf-8?B?RXFVYzhyWFZ4VllKNHBBOXBiZkVmT3VRWDZqaGJqem9ZUVI5UnNpYmcxNUsy?= =?utf-8?B?UnBCQUZBSHFPcWl3OHMyZTRkWHpZTnVkTHVGRVB3M3NDdWJtRDkySnBoOUJy?= =?utf-8?B?Q1gzSzc5d1N1Ri9lNlEyU0hUb3E2YVJsbzNOM25DNUpqQWt4Wmg5aUJkbE9N?= =?utf-8?B?L2hBTzJrTTgyMGxVaTNlRHV6dnBQODNxUVdKUkJNUHhFZHZSUkZBUDVNWjl5?= =?utf-8?B?TnY2aXNjUDlOODMxaVV0Zlk1YXFLZlNpZFVLVnVyLzVCdTg0eGpHSlJmbEpm?= =?utf-8?B?SWJnRlZnYk9VNTl2MXIrYzIwV1IzQUIxRDlXSFQ1bzMwbDNUMnVaRzZyT3Ez?= =?utf-8?B?TERSaDBYWEpOTWk4QUIxbGsyTmRTSnBkamhURTlvN3B5cSt0azJ5UTA2bVJt?= =?utf-8?B?V0k5ZmMwZXJQdHI5QzgzZHg0UDE2czdEaDA0WDMyb0N1d1VqeGd2WHpJRnlO?= =?utf-8?B?ZUxhNHBMVDdCZ0wyV2pwdVEraGpMY3had1FnNG8xSUF0ZHhTZ2N3WFZTaUpK?= =?utf-8?B?M09xUUx4SVMwUzZNL2pJVTdwdDM1V0c0T3FEOTZMRVJzMXE0UlFOclRkb2Ny?= =?utf-8?B?cm1NN0puakg0UnNWam8wNXdsNzJDTWRldm9OalhWOHhUV2l4VWNieHM5SGR3?= =?utf-8?B?Q1JDMzRqdDhPUjF0clFYRElCRzVyMmxacG5JcjY4Y3FONTY3RkJmRGlObHIx?= =?utf-8?B?VFRLMHlUcGMzYklIdXJacFdablJvTlVnMW5TTnRSSTNWb0VzaER1V0xJRWxN?= =?utf-8?B?c1FnVU9iYm5PZGRiSTFCR0E0ZG9TREw3WUVwRWJjcXNoekpGU1Jka3FlMGNt?= =?utf-8?B?dWc5NXFWcTRBNm5lY1REdVlBMC9DZVpSUVY3RndlUFlGTFViRHkwTFhDY3FF?= =?utf-8?B?UTZVUWJveUUza0FjMEdLNXlRTm44L09PR0hIQXZRM0NLbnEzTUtpaVpQZC9l?= =?utf-8?B?M3NVVTRTbHZYV3RnVXk1aWtEbm5KNXcyRnpyaUZHc3VIc21MNUhmUnlzUDdC?= =?utf-8?B?OVRwTDBjaXc0TE9sOG9pU3VyUVpZZnJEUkxrSFVMMmcyaXQvQWhadjZRL1M5?= =?utf-8?B?aDk1MFpmbkcvanpSR1ArMjFUOUhjcG1KR3VNRFBrTTI2RCtiUHZJcVFZbCsr?= =?utf-8?B?UVRKcjB3L1pQcnJmVmFqQlNrWU9DWjhmL0IvQkZHOUZBcy92ZXpxczhYMDdr?= =?utf-8?B?TW1RZGR1cUFocUJWUTBuS05Vdmd4V2RLTDJHQm50RzlCU21NeFc1YnhVODRY?= =?utf-8?B?OW1DS1RzQ1NvU3dMdnBLdC9iSjJsKzVqLy9lLzNBR0sxdStXMzFpeWRlTytO?= =?utf-8?B?MGJiRGJZaVBJUXpyYUVYdlQyaWEyUU0wMzEyd3A2MHZkNHFYS05rQlhRWWt6?= =?utf-8?B?RGJZMzBuUlJ3aTBWeGtZeUFIY29YcmtTaVN0TjJoNGJuNWdHVEtpREtRRmFV?= =?utf-8?B?MGtIZ2tJUis0RUtLdTRPUlBQTTZXTVpVQkhQMmZkSG1NRVRvYWwwK1c0a1pr?= =?utf-8?B?ZnBwcythZnF2dWpXa3ZjVzRRT2RDeUx1aDhyVEZ5ZnBlZldKbGZIUG1kUWo1?= =?utf-8?B?emE5SEk0VCtYclJXMitVVm84eUtHdzRNcDVRZ1J1cFUvUk1qRUhWWXdkUWdI?= =?utf-8?B?RUpDa3g2RSt2OFExVzd0ZFdyWW1vSW1EemJyWFAvdmZSNmdvSHhrNkhOZ3Fn?= =?utf-8?B?Y0E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a55fc3a-88d0-4280-4246-08da9589fae5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 13:15:08.1857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +uTrn4Whu5ce0FvtwcasHPzZYBE1Rkwn3OOLorHJv/laJ3aYETCMFi50U9IGLOT91JvLKSM/1kKJN0lSrY52fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6272 On Tue, Sep 13, 2022 at 01:54:12PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH] libvirt: disable Werror for non-libvirt flights"): > > Current usage of Werror=switch-enum by default for libvirt builds out > > of the git tree causes issues when new items are added to libxl public > > API enums if those are used in a switch statement in libvirt code. > > This leads to libvirt build failures for seemingly unrelated libxl > > changes. > > > > In order to prevent those errors from blocking the push gate, disable > > Werror for libvirt builds when not in a libvirt specific flight. > > > > The errors will be reported on the libvirt flight, and block the > > pushes there. So the author of the changes in libxl is still expected > > to send a fix to libvirt code. This is no ideal, but the other option > > is to just disable Werror for all libvirt builds and let libvirt > > developers fix the breakage when they notice it. > .. > > +build-i386-libvirt autogen_options --disable-werror > > We have no way to specify -Wno-error-switch-enum specifically ? > (I'm not sure if that would be desirable.) Hm, maybe playing with CFLAGS, but not from the autogen/meson options AFAIK. Using the autogen/meson flags seems cleaner and less error prone (albeit the disabling of Werror is more wide than what we strictly require). > > I'm unsure whether we want o disable Werror even for libvirt flights, > > but this seems more conservative. > > Probably disabling it only for Xen is right. Thanks, let's try this first then. Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 13:28:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 13:28:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406403.648786 (Exim 4.92) (envelope-from ) id 1oY5xf-0005ip-KM; Tue, 13 Sep 2022 13:28:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406403.648786; Tue, 13 Sep 2022 13:28:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5xf-0005ii-Hr; Tue, 13 Sep 2022 13:28:23 +0000 Received: by outflank-mailman (input) for mailman id 406403; Tue, 13 Sep 2022 13:28:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY5xd-0005ic-Gc for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 13:28:21 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id edeb1c84-3367-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 15:28:19 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2B3F95C017F; Tue, 13 Sep 2022 09:28:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 13 Sep 2022 09:28:18 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 09:28:17 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edeb1c84-3367-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663075698; x= 1663162098; bh=b5IwvONy+aPZig6uiZYmFqcObNpEzTolaCm7RCSv1cA=; b=Y ceNynn/q4lo+Tu+LKJ5+jVUGr691gly7lTNYG+/V5B7SSSUBCb3FamtoQPBnuDN0 Dhx9DxLqajryeEinEA3GGYviHKWHpSJkg5W2BsNmIXg3I8Nd8dS4FABb/lcToQhb VAD5wxNRJH/xcVgJVqKfPqpkW/0fXCyqBOd3fEvQQ85LVr3hOJxHC23MK70M65/F VSdd/xNFbErJsueXmUFkWnU7nCFenJBt/tNOoqWz+nnUQVFAMV/zVtntzhYkcnnz V6Y3YpHbmzfdEDqI/VoTwSAtUNdDAm7XyorzSHNFyoQwClvyrvN1yu3wnLyQsYfz BJ7IY0DnaAY+wu3P4v5Qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663075698; x=1663162098; bh=b5IwvONy+aPZig6uiZYmFqcObNpE zTolaCm7RCSv1cA=; b=qqNpaJjRAO5/+5GFPFLvA2RrnjZDadkpv0YqDbCnsMGS RDlR6r09f5ZfY+B124rHjgMVfmrKlb6kN4fCd5Y3jWCzKf1yCRmUEim1OP2hEKb1 64U+w/zcZBB+UroOIrsLZptt5JYm4/S1ycqlTJs/2Ddmw9dfeX6GbFy35L/ElnXS yGUH0xNDLZBbkjsO1QhFSDw5CQrwR0OSa2DAAGEmPwifJ0+WhD7YLH+XGiIoPcNi hB2LzDXhX00wIxiS3JKPxg36m9oCUw6OHmvnvWQ3hJjL09uwxic48Zdg9MwE6NhQ rI8udxV14nmfqVmaFKsXUDbZusBdaemP4cSmAtL1iA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 13 Sep 2022 09:27:53 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] Add support for ESRT loading under Xen Message-ID: References: <20220828025158.1455-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="37mLKXCcYa6M0yBY" Content-Disposition: inline In-Reply-To: --37mLKXCcYa6M0yBY Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Sep 2022 09:27:53 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] Add support for ESRT loading under Xen On Mon, Sep 05, 2022 at 01:46:54PM +0200, Ard Biesheuvel wrote: > On Sun, 28 Aug 2022 at 04:52, Demi Marie Obenour > wrote: > > > > This is needed for fwupd to work in Qubes OS. > > >=20 > Please elaborate on: Will do in v3. > - the current situation The ESRT is not available in dom0 under Xen. > - why this is a problem fwupd requires the ESRT to be available in dom0. Without it, users cannot update their firmware. > - why your approach is a reasonable solution. It is the approach already chosen by Xen upstream. See below for details. > > Signed-off-by: Demi Marie Obenour > > --- > > Changes since v1: > > > > - Use a different type (struct xen_efi_mem_info) for memory information > > provided by Xen, as Xen reports it in a different way than the > > standard Linux functions do. > > > > drivers/firmware/efi/esrt.c | 49 +++++++++++++++++++++++++++---------- > > drivers/xen/efi.c | 32 ++++++++++++++++++++++++++ > > include/linux/efi.h | 18 ++++++++++++++ > > 3 files changed, 86 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > > index 2a2f52b017e736dd995c69e8aeb5fbd7761732e5..c0fc149a838044cc16bb08a= 374a0c8ea6b7dcbff 100644 > > --- a/drivers/firmware/efi/esrt.c > > +++ b/drivers/firmware/efi/esrt.c > > @@ -243,27 +243,50 @@ void __init efi_esrt_init(void) > > void *va; > > struct efi_system_resource_table tmpesrt; > > size_t size, max, entry_size, entries_size; > > - efi_memory_desc_t md; > > - int rc; > > phys_addr_t end; > > - > > - if (!efi_enabled(EFI_MEMMAP)) > > - return; > > + uint32_t type; > > > > pr_debug("esrt-init: loading.\n"); > > if (!esrt_table_exists()) > > return; > > > > - rc =3D efi_mem_desc_lookup(efi.esrt, &md); > > - if (rc < 0 || > > - (!(md.attribute & EFI_MEMORY_RUNTIME) && > > - md.type !=3D EFI_BOOT_SERVICES_DATA && > > - md.type !=3D EFI_RUNTIME_SERVICES_DATA)) { > > - pr_warn("ESRT header is not in the memory map.\n"); > > + if (efi_enabled(EFI_MEMMAP)) { > > + efi_memory_desc_t md; > > + > > + if (efi_mem_desc_lookup(efi.esrt, &md) < 0 || > > + (!(md.attribute & EFI_MEMORY_RUNTIME) && > > + md.type !=3D EFI_BOOT_SERVICES_DATA && > > + md.type !=3D EFI_RUNTIME_SERVICES_DATA)) { > > + pr_warn("ESRT header is not in the memory map.\= n"); > > + return; > > + } > > + > > + type =3D md.type; > > + max =3D efi_mem_desc_end(&md); > > + } else if (IS_ENABLED(CONFIG_XEN_EFI) && efi_enabled(EFI_PARAVI= RT)) { > > + struct xen_efi_mem_info info; > > + > > + if (!xen_efi_mem_info_query(efi.esrt, &info)) { > > + pr_warn("Failed to lookup ESRT header in Xen me= mory map\n"); > > + return; > > + } > > + > > + type =3D info.type; > > + max =3D info.addr + info.size; > > + > > + /* Recent Xen versions relocate the ESRT to memory of t= ype > > + * EfiRuntimeServicesData, which Xen will not reuse. I= f the ESRT >=20 > This violates the EFI spec, which spells out very clearly that the > ESRT must be in EfiBootServicesData memory. Why are you deviating from > this? Xen will freely use EfiBootServicesData memory for its own purposes after calling ExitBootServices(). In particular, such memory may be allocated to, and become writable by, other guests. Since the ESRT is (of necessity) trusted, it cannot be used by Linux unless it is guaranteed to not be writable by other guests. Earlier patches to Xen just reserved the region containing the ESRT in the EFI memory map. However, this was tricky to implement correctly and required a new platform op to alert dom0 that the ESRT had been reserved by Xen. The final patch accepted upstream instead checks if the ESRT is in EfiBootServicesData memory, and if it is, relocates it to EfiRuntimeServicesData memory. This allowes using existing hypercalls to check if the ESRT has been reserved by Xen, which is exactly what this patch does. If I recall correctly, some firmware already allocates the ESRT from EfiRuntimeServicesData memory, so operating systems already need to support this case. Furthermore, the ESRT must not be clobbered by the OS or hypervisor, so EfiRuntimeServicesData is a more logical choice anyway. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --37mLKXCcYa6M0yBY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMghW8ACgkQsoi1X/+c IsFXOA/+L49ME+tYwPJiJQHmriPMx44MCB0a+MT8Q1JIsuTPZnCxWeT2gs6FN5q5 zPncQzYMOOOzyFpKsAR9Q2AHKu8qIf3qFoX1bc1Dsc36lAW3ADWtQBSRDqMfK8WL Q4oQX2ypgW4x3v9OHhKMSwHPIWxTsxLLoh7hLjm83phikRHy7I0EZYs2AviOYsen u04rNCH/ZitfzDimI1BEy2Fqp2f0hskkn46TObnjrz3crtZndkld8n3f7AN5bXFi 8dE5t9pHKKzGyj/R2HnDa4YV+agG5+87MW+LQrM0CgZC2aHNW5MRmmRaz/KAWOO1 B7LYbcL0WWmhAMVaDegZDeQpTSVKHYR80z3JmKXEqL59SoNE+kC7ld2FlTdeFrFs /+vo9UxLYX7VW4FLGFh/iMnozy6wf4VK82Il1nDNCJGnsgiRXoS4DCn7FbjSyidh STdSZ6JE/OHtqUjmY8RUlZH9jUIiLUMfHa30xXP30mvP3yQ/ulvJgp9bVC3HxioG lM9Ik6pZD4lSfFaOtdQRf/h8zL1grd+d2SEDbfIBlKd7jkid6d5gjoPjHIEUyETq xxPJkEWGk33t/hSLhvlrB+FEcu5Egs11e+VMHt49bveiSOdMxPN5r5DUxjcwUvFI iV0wewWHAEfemwiX5D6H8Tmx285a5EwLGWJd/zIogQwZ2W10r2k= =78/p -----END PGP SIGNATURE----- --37mLKXCcYa6M0yBY-- From xen-devel-bounces@lists.xenproject.org Tue Sep 13 13:31:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 13:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406410.648797 (Exim 4.92) (envelope-from ) id 1oY60Y-000766-2f; Tue, 13 Sep 2022 13:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406410.648797; Tue, 13 Sep 2022 13:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY60X-00075z-W5; Tue, 13 Sep 2022 13:31:21 +0000 Received: by outflank-mailman (input) for mailman id 406410; Tue, 13 Sep 2022 13:31:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY60W-00075p-7W; Tue, 13 Sep 2022 13:31:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY60W-00069N-3q; Tue, 13 Sep 2022 13:31:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY60V-0000ii-L8; Tue, 13 Sep 2022 13:31:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY60V-0006Z4-Kf; Tue, 13 Sep 2022 13:31:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7P8ZeqfhbQH8rlD2rG+EAxeIz9M+Z2tAvxyFiy5sQqY=; b=PEJtIxA/CiOLsD3oI8sXk051x9 vm2CiOUzt3+5bEe1e2vS6wtjfO0p6sSfg8AvJLe6mBwFYWn7AgGJinduKT5kbwAZ/qYHbCHi6U3vQ TKG0uDkVbOkxDfUkyDiY5xUJEBe2w5qK0t9prismYf4s8HCflm7EgcN6W5JS4bh9tPhY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173162: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-pygrub:guest-localmigrate:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c X-Osstest-Versions-That: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c From: osstest service owner Date: Tue, 13 Sep 2022 13:31:19 +0000 flight 173162 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173162/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-pygrub 17 guest-localmigrate fail pass in 173144 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173144 build-i386-libvirt 6 libvirt-build fail like 173144 build-arm64-libvirt 6 libvirt-build fail like 173144 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173144 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173144 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173144 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173144 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173144 build-armhf-libvirt 6 libvirt-build fail like 173144 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173144 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173144 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173144 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173144 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c baseline version: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c Last test of basis 173162 2022-09-13 01:52:08 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub fail test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 13:35:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 13:35:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406422.648809 (Exim 4.92) (envelope-from ) id 1oY642-0007pn-OC; Tue, 13 Sep 2022 13:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406422.648809; Tue, 13 Sep 2022 13:34:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY642-0007pg-Kf; Tue, 13 Sep 2022 13:34:58 +0000 Received: by outflank-mailman (input) for mailman id 406422; Tue, 13 Sep 2022 13:34:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY642-0007pY-4X for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 13:34:58 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id daa96d5b-3368-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 15:34:56 +0200 (CEST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-156-P_oeLiB8M_qJvoNcs8hSaA-1; Tue, 13 Sep 2022 09:34:54 -0400 Received: by mail-ej1-f70.google.com with SMTP id qw34-20020a1709066a2200b0077e0e8a55b4so2362732ejc.21 for ; Tue, 13 Sep 2022 06:34:54 -0700 (PDT) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id 1-20020a170906218100b00730b61d8a5esm6099500eju.61.2022.09.13.06.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 06:34:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daa96d5b-3368-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663076095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s3xh4EumEIvumafJwct5+WCk+ZsG9qjAIuO2sjxjanY=; b=M/IfkqASCXtjtwY/AYtLoCYgRwx5yTCT6uBjvEPS3t0X3dwIXvpIJ4sbsT3V6QliR4EPpg 6marNFJZW/9RWF35JVNVMOG2ddC4Pp7tvQoazyDtIh+YTTw2MsLfhmlARVxqAphPf4ISZd R/zQxQsjtwfpkgYPW9n0YZm8Qpq7Qa4= X-MC-Unique: P_oeLiB8M_qJvoNcs8hSaA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=vptXUYceNtwYVyKwfHyA3dKZqDg4HJHh7ydKyqgQ4H0=; b=QwYBYMcMsv4+t8+eS61DUIP26YyK9T3pD7MSTW8rWbTSdi2Gc84JCzrxaghshJMB+V k0WdG8/zB0X+h/R8qycmdTwOMd6QShEQhPRkgqnNNoW7CmEgc9z/C/j2rmFKZx+A1Gck uAXRfv+JNS4vQ/0+ndKOtXSvu/kGQKC/1Cn26oxSNquryyvlrFQW2lE601JAeBAZz0+p uHbJunVVpoLMX7z5hNuCObX1lqugGRJuelR4wJy/5ZmrHGHWtFG8V6OU318g+0lj6Ogx az30FTJ9kN7DKZ4aTFCRQB5nbMibcc1wrrxeYSf+CRVbJKehq3N4pFoAfz6P4OSEk98f Tzzg== X-Gm-Message-State: ACgBeo0xkXJ6vqBjIcAUIuK94zW3hDMRl909oZJikDtPFfwpyUPbXkK8 5ABkuoNoYMKpu9082hBF60Eu9zSiTtJts4zKNzAB1DizOflyfuXx4pgYBLYGZNGiij37wFo4ud+ wwFO1F3fcipT+kv5zgy7cF84FoCk= X-Received: by 2002:a17:907:7f91:b0:77f:c4c7:9155 with SMTP id qk17-20020a1709077f9100b0077fc4c79155mr3137426ejc.476.1663076093156; Tue, 13 Sep 2022 06:34:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR6avRwtqutArvSmcEzg7QncTSscL/a0gwHDnK2tQKDnZWQ3sHpo7gh8eU4Pf6A1+IXk9R/ikw== X-Received: by 2002:a17:907:7f91:b0:77f:c4c7:9155 with SMTP id qk17-20020a1709077f9100b0077fc4c79155mr3137408ejc.476.1663076092870; Tue, 13 Sep 2022 06:34:52 -0700 (PDT) From: Vitaly Kuznetsov To: Ajay Kaher Cc: "x86@kernel.org" , "hpa@zytor.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , Srivatsa Bhat , "srivatsa@csail.mit.edu" , Alexey Makhalov , Vasavi Sirnapalli , "er.ajay.kaher@gmail.com" , "willy@infradead.org" , Nadav Amit , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "jailhouse-dev@googlegroups.com" , "xen-devel@lists.xenproject.org" , "acrn-dev@lists.projectacrn.org" , "helgaas@kernel.org" , "bhelgaas@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , Alexander Graf Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor In-Reply-To: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> Date: Tue, 13 Sep 2022 15:34:50 +0200 Message-ID: <87zgf3pfd1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ajay Kaher writes: > Note: Corrected the Subject. > >> =EF=BB=BFOn 07/09/22, 8:50 PM, "Vitaly Kuznetsov" = wrote: >> >>> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c >>> index ddb7986..1e5a8f7 100644 >>> --- a/arch/x86/pci/common.c >>> +++ b/arch/x86/pci/common.c >>> @@ -20,6 +20,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> unsigned int pci_probe =3D PCI_PROBE_BIOS | PCI_PROBE_CONF1 | PCI_PROB= E_CONF2 | >>> PCI_PROBE_MMCONF; >>> @@ -57,14 +58,58 @@ int raw_pci_write(unsigned int domain, unsigned int= bus, unsigned int devfn, >>> return -EINVAL; >>> } >>> >>> +#ifdef CONFIG_HYPERVISOR_GUEST >>> +static int vm_raw_pci_read(unsigned int domain, unsigned int bus, unsi= gned int devfn, >>> + int reg, int len, u32 *va= l) >>> +{ >>> + if (raw_pci_ext_ops) >>> + return raw_pci_ext_ops->read(domain, bus, devfn, reg, len= , val); >>> + if (domain =3D=3D 0 && reg < 256 && raw_pci_ops) >>> + return raw_pci_ops->read(domain, bus, devfn, reg, len, va= l); >>> + return -EINVAL; >>> +} >>> + >>> +static int vm_raw_pci_write(unsigned int domain, unsigned int bus, uns= igned int devfn, >>> + int reg, int len, u32 val= ) >>> +{ >>> + if (raw_pci_ext_ops) >>> + return raw_pci_ext_ops->write(domain, bus, devfn, reg, le= n, val); >>> + if (domain =3D=3D 0 && reg < 256 && raw_pci_ops) >>> + return raw_pci_ops->write(domain, bus, devfn, reg, len, v= al); >>> + return -EINVAL; >>> +} >> >> These look exactly like raw_pci_read()/raw_pci_write() but with inverted >> priority. We could've added a parameter but to be more flexible, I'd >> suggest we add a 'priority' field to 'struct pci_raw_ops' and make >> raw_pci_read()/raw_pci_write() check it before deciding what to use >> first. To be on the safe side, you can leave raw_pci_ops's priority >> higher than raw_pci_ext_ops's by default and only tweak it in >> arch/x86/kernel/cpu/vmware.c > > Thanks Vitaly for your response. > > 1. we have multiple objects of struct pci_raw_ops, 2. adding 'priority' f= ield to struct pci_raw_ops > doesn't seems to be appropriate as need to take decision which object of = struct pci_raw_ops has > to be used, not something with-in struct pci_raw_ops. I'm not sure I follow, you have two instances of 'struct pci_raw_ops' which are called 'raw_pci_ops' and 'raw_pci_ext_ops'. What if you do something like (completely untested): diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.= h index 70533fdcbf02..fb8270fa6c78 100644 --- a/arch/x86/include/asm/pci_x86.h +++ b/arch/x86/include/asm/pci_x86.h @@ -116,6 +116,7 @@ extern void (*pcibios_disable_irq)(struct pci_dev *dev)= ; extern bool mp_should_keep_irq(struct device *dev); =20 struct pci_raw_ops { + int rating; int (*read)(unsigned int domain, unsigned int bus, unsigned int dev= fn, int reg, int len, u32 *val)= ; int (*write)(unsigned int domain, unsigned int bus, unsigned int de= vfn, diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index ddb798603201..e9965fd11576 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -40,7 +40,8 @@ const struct pci_raw_ops *__read_mostly raw_pci_ext_ops; int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int devfn= , int reg, int len, u32 *val) { - if (domain =3D=3D 0 && reg < 256 && raw_pci_ops) + if (domain =3D=3D 0 && reg < 256 && raw_pci_ops && + (!raw_pci_ext_ops || raw_pci_ext_ops->rating <=3D raw_pci_ops->= rating)) return raw_pci_ops->read(domain, bus, devfn, reg, len, val)= ; if (raw_pci_ext_ops) return raw_pci_ext_ops->read(domain, bus, devfn, reg, len, = val); @@ -50,7 +51,8 @@ int raw_pci_read(unsigned int domain, unsigned int bus, u= nsigned int devfn, int raw_pci_write(unsigned int domain, unsigned int bus, unsigned int devf= n, int reg, int len, u32 val) { - if (domain =3D=3D 0 && reg < 256 && raw_pci_ops) + if (domain =3D=3D 0 && reg < 256 && raw_pci_ops && + (!raw_pci_ext_ops || raw_pci_ext_ops->rating <=3D raw_pci_ops->= rating)) return raw_pci_ops->write(domain, bus, devfn, reg, len, val= ); if (raw_pci_ext_ops) return raw_pci_ext_ops->write(domain, bus, devfn, reg, len,= val); and then somewhere in Vmware hypervisor initialization code (arch/x86/kernel/cpu/vmware.c) you do raw_pci_ext_ops->rating =3D 100; why wouldn't it work?=20 (diclaimer: completely untested, raw_pci_ops/raw_pci_ext_ops initialization has to be checked so 'rating' is not garbage). > > It's a generic solution for all hypervisor (sorry for earlier wrong > Subject), not specific to VMware. Further looking for feedback if it's > impacting to any hypervisor. That's the tricky part. We can check modern hypervisor versions, but what about all other versions in existence? How can we know that there's no QEMU/Hyper-V/... version out there where MMIO path is broken? I'd suggest we limit the change to Vmware hypervisor, other hypervisors may use the same mechanism (like the one above) later (but the person suggesting the patch is always responsible for the research why it is safe to do so). --=20 Vitaly From xen-devel-bounces@lists.xenproject.org Tue Sep 13 13:36:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 13:36:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406428.648820 (Exim 4.92) (envelope-from ) id 1oY65S-0008VS-2g; Tue, 13 Sep 2022 13:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406428.648820; Tue, 13 Sep 2022 13:36:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY65R-0008VL-Vb; Tue, 13 Sep 2022 13:36:25 +0000 Received: by outflank-mailman (input) for mailman id 406428; Tue, 13 Sep 2022 13:36:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY65R-0008VB-Fu for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 13:36:25 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f344f7e-3369-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 15:36:24 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 92E015C0165; Tue, 13 Sep 2022 09:36:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 13 Sep 2022 09:36:23 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 09:36:22 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f344f7e-3369-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663076183; x= 1663162583; bh=Tc0xVHPsREMfS7uj8Z2PW8B/PBM01asP+Nsn6MzfR0o=; b=r GhhcP3aZj/0sP2D4/h+WRgh7wExihpOYP7qcV3LQcEI0rY+L/5skGRoSuf+oYUjV hdvVV+/1Wl46Qdz/77jnXUplPOGlGDHaTUkaB9Cp1NjLSuR5a85ZV5VRmLwHIG8V dnxfPLqgnMWczNxm442z895Gw3WTNXGbiXzFCY7KA5wbNLP4o7/KPbkdxnydeMgf 1NBGyxOM183OqEeOlGbQZa9+lqhX5/1fTFHFjAX06wbgvPcH/hCuCR7kkiFm+lor GMRY94HRUizfwn2E31cPXJA2MzoMnoqrz+1lh9eNNtYRIHTJltx29jPY+zmMyuKL DsSopt2eXvPC7pT5lPkUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663076183; x=1663162583; bh=Tc0xVHPsREMfS7uj8Z2PW8B/PBM0 1asP+Nsn6MzfR0o=; b=mxO4UwB6KgMan8JCywEwkBkA1UrDDtHz/D8l62ibI+J6 oeBPN+Z4I1p4WPRASDl7CHp6TMcomBhIIaaChQPJFsE+nKaLGfvp3any/QQORi9D T+l+37vm9GQ8A4esLCYFTacK+g6M/QgJ1LNLY407ARpkpRd0+3ttAbkGpU+lobzq No2PkVU9WgxT5ASXpZldNqswt1nv6e1qhmL1oNDKP/I01tjrwgaPiDunD4QP/U/b qqw5JY91tXStTZCgn3rYhJDxDvzCEIktrU226SuU0fJzW6BHaG0+V0viqXvvWe+t W796riM3UtFJEsdHPbmTw7bL1gG5AEGZMoUOOfSj9w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 13 Sep 2022 09:36:18 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Ard Biesheuvel , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH] Add support for ESRT loading under Xen Message-ID: References: <20220825215218.1606-1-demi@invisiblethingslab.com> <2a1a9e8c-0635-e207-e858-0e0bd1df0f11@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HB29iMzKquh2KHmV" Content-Disposition: inline In-Reply-To: <2a1a9e8c-0635-e207-e858-0e0bd1df0f11@suse.com> --HB29iMzKquh2KHmV Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Sep 2022 09:36:18 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Ard Biesheuvel , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH] Add support for ESRT loading under Xen On Tue, Sep 06, 2022 at 08:49:54AM +0200, Jan Beulich wrote: > On 26.08.2022 20:01, Demi Marie Obenour wrote: > > On Fri, Aug 26, 2022 at 09:53:29AM +0200, Jan Beulich wrote: > >> On 25.08.2022 23:52, Demi Marie Obenour wrote: > >>> @@ -40,6 +41,38 @@ > >>> =20 > >>> #define efi_data(op) (op.u.efi_runtime_call) > >>> =20 > >>> +static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT, > >>> + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); > >>> + > >>> +bool xen_efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *md) > >>> +{ > >>> + struct xen_platform_op op =3D { > >>> + .cmd =3D XENPF_firmware_info, > >>> + .u.firmware_info =3D { > >>> + .type =3D XEN_FW_EFI_INFO, > >>> + .index =3D XEN_FW_EFI_MEM_INFO, > >>> + .u.efi_info.mem.addr =3D phys_addr, > >>> + .u.efi_info.mem.size =3D ((u64)-1ULL) - phys_addr, > >>> + } > >>> + }; > >>> + union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_info; > >>> + int rc; > >>> + > >>> + memset(md, 0, sizeof(*md)); /* initialize md even on failure */ > >>> + rc =3D HYPERVISOR_platform_op(&op); > >>> + if (rc) { > >>> + pr_warn("Could not obtain information on address %llu from Xen: " > >>> + "error %d\n", phys_addr, rc); > >>> + return false; > >>> + } > >>> + > >>> + md->attribute =3D info->mem.attr; > >>> + md->type =3D info->mem.type; > >>> + md->num_pages =3D info->mem.size >> XEN_PAGE_SHIFT; > >>> + md->phys_addr =3D info->mem.addr; > >> > >> As indicated in reply to your patch changing XEN_FW_EFI_MEM_INFO in > >> the hypervisor: While this may fit the ESRT purpose, the address you > >> return here is not necessarily the start of the region, and hence > >> this function is not a general Xen replacement for the non-Xen > >> function. Therefore I think it also shouldn't give the impression of > >> doing so. > >=20 > > Is this just a matter of renaming the function? >=20 > Besides renaming the function perhaps it also shouldn't give the > impression of being generally usable. I would expect it to be a static > helper somewhere, or even be expanded inline. I would be fine with doing this, but I didn=E2=80=99t want to litter esrt.c= with Xen-specific code. IIUC Linux prefers to avoid #ifdef in .c files. > > Is it possible to > > implement the original function with the current hypervisor? >=20 > Yes, but doing so would be ugly: You'd need to "bisect" your way to > the start of the region. >=20 > As an aside (I think I did point this out before): Can you please > adjust the way your mail program sends mails? When I respond to your > mail (using Thunderbird), I find all the people previously on Cc on > the To: list, while your address is lost. As indicated I believe > this is a result of the Mail-Followup-To: tag your reply came with > (and I further think that TB's treatment of that tag is a reasonable > one, albeit perhaps there are other reasonable treatments as well; I > am not aware of this tag having any formally specified treatment). This was a misconfiguration on my end: I marked xen-devel as subscribed in my muttrc. I fixed this and also unset followup_to, so the Mail-Followup-To header should no longer be generated. Please let me know if this is still a problem. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --HB29iMzKquh2KHmV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMgh1QACgkQsoi1X/+c IsEMWg/+K/M5YDFYGZvZG8t9UVyp5AVxc+to/61bec+l2gPk2YyH3Bz4pd4Co1hH 1ZfIIW0nybYkWTXacg26fTMYqg7124vu+VH9mOEmfDp7ZmjWg/QvMYjOEevEQcFQ SWPhLavQ1pQvJJJacNrEtbk7ivAvYFaKzLPs4yvseBR9r3JyWFQU2fZfbDgi7Q9y XmuUxqVNerg5/9RQOn2d/+N8J4Bs8v1hclkr/J3KS7a44qukUa28TIEjlhbU3h3b WM+8zuTN/ksbHQ6/wWaG8KXt5+4UemsQhYOsgI/42eaM4YjjAPL/6d3Vb/bnr1cT Lk1A1/IXrMVq10GzZZ47sKnnZRD0t9QvXyP16trFJFPoNC2IniFyKfbm1cj5zrOl DJgvlRzNuFlTA3tHA+U9TW2HZ2xw9reQHWSGUmlB2q0JQ69ZiXOGT57WX5qPSepR OBXrf0yORshR6UkVewsQgPeGn7jzWpxFlR3y2NpZH1BOp6mVRIhKg6i6GRZqmCai /M+1IMFZn2CrNBxowxMGkn6Ixh5Zfz71/UTAArx1Ad7VUvrtnC2z/yCBUJ4JcSuQ hr9FnW/4TNH7OuB/Txm0smyJv4G9UUtSl932lqnOaqkPH12aXDJxjhtxH8y+hLga vU/DZwgOfeGRXHP4LBtP8cDDmDsModBrHDGOJQWd175eTbKiRiY= =7Q0Y -----END PGP SIGNATURE----- --HB29iMzKquh2KHmV-- From xen-devel-bounces@lists.xenproject.org Tue Sep 13 14:22:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 14:22:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406440.648831 (Exim 4.92) (envelope-from ) id 1oY6o6-0005qt-BH; Tue, 13 Sep 2022 14:22:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406440.648831; Tue, 13 Sep 2022 14:22:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY6o6-0005qm-8P; Tue, 13 Sep 2022 14:22:34 +0000 Received: by outflank-mailman (input) for mailman id 406440; Tue, 13 Sep 2022 14:22:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY6o4-0005qg-Mv for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 14:22:32 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f9ab6cd-336f-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 16:22:30 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 046D65C0176; Tue, 13 Sep 2022 10:22:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Sep 2022 10:22:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 10:22:28 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f9ab6cd-336f-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663078948; x= 1663165348; bh=V790zDsuQ68CsfWzc0YeGKmaeU08gUUaFFII1gpZAXQ=; b=L gynG4N+xLVl7wraFDA+Za6Co1M6BYONYUJ6RHLv+eWoi77JKVhGVS+TKg2wF37+k b5kTh7GoCbXiIoAShe4Iy/McI9jsQ4nXKGGEnq8KEUJE5qWlTQVFHji4CI/+SHsM WZ0hO7lQUD6E5xv4fgu/HHDm4j5iMTi1Buvzw8M+vVHgldozvD9JOzniEw8mF0+D qT54JfHpjZ+sawQs2pKhh92U3K0od1qHeUA8nXA2s2MLQSqVY/oBqB9mUAfqSFEd J06gq19wZBqOl5mF231KYxunyaizzm/x1VzOKOUHQhRpDVMCMzZ9u5E7nlZ7RwPm 1Z0lc2n0Dkvp9oJkQJa6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663078948; x=1663165348; bh=V790zDsuQ68CsfWzc0YeGKmaeU08 gUUaFFII1gpZAXQ=; b=S5esmuvhCCtGQrN9MtdJdmAShAgcGue+mQ3tzOoN/W2M Y4+yPKrCSwgrARuUAURrgB6/VG+ZDijlT/71PpymyVR4gbmR9u++Esj6At49NjRm fTsh781fovVMgYdQgthgY3LyGBfSxDfrBqirr/rjcuAr+6PaoaIWOpFXO9rV7A0j gzRo0Cgp6+1JSXyyjYjnE98l8lm2Bp4OsXqFgryMszVaFw54cn91SRBy9Aaa0fGW sjQV7/PmSFER8V77UH07b6sGe1eR3a04wKh7qPrGn/+MQcdc9EfVHI/oW2OBAPSw J4GJ6HQb2XwZlvHAtvAOOi4lFiHRIg78Qr0W6dtt1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleefjeeukeehkeegiedtgeekkeel tedvhfduudefgfffheffheeuvedvieelfefhnecuffhomhgrihhnpehkvghrnhgvlhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 13 Sep 2022 10:22:03 -0400 From: Demi Marie Obenour To: Andrew Cooper , Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion Subject: Re: Setting constant-time mode CPU flag Message-ID: References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="C5NFp40jmoLS1AkG" Content-Disposition: inline In-Reply-To: <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> --C5NFp40jmoLS1AkG Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Sep 2022 10:22:03 -0400 From: Demi Marie Obenour To: Andrew Cooper , Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion Subject: Re: Setting constant-time mode CPU flag On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: > On 06/09/2022 10:52, Jan Beulich wrote: > > On 02.09.2022 04:05, Demi Marie Obenour wrote: > >> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in > >> a CPU register to enforce constant-time execution. Linux plans to set > >> this bit by default; Xen should do the same. See > >> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. > >> I recommend setting the bit unconditionally and ignoring guest attempts > >> to change it. > > I don't think we ought to set it by default; I can see reasons why kern= els > > may want to set it by default (providing a way to turn it off). In Xen > > what I think we need is exposure of the bit to be guest-controllable. >=20 > We absolutely should not have it set by default.=C2=A0 It's a substantial > overhead for something that is only applicable to code which otherwise > crafted to be constant-time. Either Xen needs to set the bit by default, or guests need to both know the bit needs to be set and be able set it. Otherwise code that *is* intended to be constant-time has no way to protect itself. > As for why Xen doesn't enumerate/virtualise it, that's because > virtualising MSR_ARCH_CAPS for guests is still not working yet, so the > feature can't be enumerated yet even if we did support context switching = it. Intel and ARM64 guarantee that CPUs that do not enumerate this flag behave as if it is set unconditionally. Therefore, Xen=E2=80=99s current behavior on Intel is incorrect and insecure. On ARM64, it appears that the flag is currently a noop, but as this might change in the future, Xen should fix its behavior there too. Without support for virtualising MSR_ARCH_CAPS, the only secure behavior for Xen on Intel is to unconditionally set the DIT bit. On ARM8.4+, the bit currently appears to be a no-op, but as a precautionary measure, Xen should either set or virtualise it. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --C5NFp40jmoLS1AkG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMgkiIACgkQsoi1X/+c IsHlPhAA17jg04X2KmoRFs+STLRCcf2pTVc85lFxQz04GiXtUJ5iByw5IMx4Jd5N WAasL5PkJzeXnGHR8hIZhDcllUNHGzDrZDAQpAN0f7Ww1hygB7wI4YQz+ZN0w9Gs zF1R5/WcBRQcktyPt5biC47S31NZjKkYKynTMMnjzQqildCyjZurkwwhpc6D+w0T vqZNk+C3S9d85uxFxZT6HpP2KuVA1NRGE54rtGhGh2+1avhGhomJtgZIPJmXaoAg 2V2cPzEVfzVTbkJZzMNjQekSgGb+939dd5g1WQyNOrtaaMYHmP/b7lhXM3RUi11d o104sNuCwas5AHdJAbCvi4o4O9I+/mI0LIY3OoMYpaV8aWcOl6jX28SbHfKc6RBO jN3fSdFxGBU6ZAR/MzhGvjLXbVv7suOCf8bRLxJtVFjZAEeowv9QeXQGoi+iyrFP UckqMMealXVMqZGozydcKWCYLlBMTjZmgz6+UbcXybjA1OTUYqm7ppiMARGnrT1S vMnvboQTzwMwlY5FBd9S00ssHK1sZLYFnei4hV7wdenh/uIuM9JrAieeX9HuHayj 3KnZjbyUwmmeNsqd0oSTFp8R/BfvJ9xXa0DjwsIk7EuoghGGB0CoiTqK3wLt15qe RF4eFBDtta269NfUE7sJBzOfqKWBHyGPnp5uvXa4FyjeOBtwDjQ= =QBM/ -----END PGP SIGNATURE----- --C5NFp40jmoLS1AkG-- From xen-devel-bounces@lists.xenproject.org Tue Sep 13 14:47:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 14:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406453.648842 (Exim 4.92) (envelope-from ) id 1oY7CF-0000Es-Ba; Tue, 13 Sep 2022 14:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406453.648842; Tue, 13 Sep 2022 14:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY7CF-0000El-8o; Tue, 13 Sep 2022 14:47:31 +0000 Received: by outflank-mailman (input) for mailman id 406453; Tue, 13 Sep 2022 14:47:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY7CD-0000Ef-H1 for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 14:47:29 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150084.outbound.protection.outlook.com [40.107.15.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fce0d883-3372-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 16:47:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7521.eurprd04.prod.outlook.com (2603:10a6:20b:2df::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 14:47:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 14:47:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fce0d883-3372-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLb4FRFVjkm3VUH2JaTV4yzZzEwCWUpwjEu/k60dg7kCJmRQtm6Wg41Vnd2UOWp92EpD1ywrZF/3CVmCW2oAH/r+2aOFybuNti5yx1tVR1T81AGI/zTa14tCbs+zZEF8YxxMj+9QmYfU0VCZJa37SNQvKclaQP9tN1O4flEvgQ+IvID42eHlDF43PHG+xTV3BWh8mzpJsZKk72V4HyQQaE4TSlAwSppkw30cwNu+3ukGtMLWCmhntroRhNk8JpGspv5umOuLPqMw49VqdJvx1uicCsx5ZUWt2gWIFfljJ7rru3ttJvejPiCAD0n650wVgo/RVWI5OHQUzGcOQu/Eog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JieG0+yjczxZII7mkixQScW6qARtcfxGwTOvp1NNMqU=; b=lRCo6iF4hQ1lz5vXzhc6i2W12fBzUth0w9+ondaKpSsBTWgBRk8xuI2YgPky4nN+KaNqP5Tpk3U6FmGTReh3q2GP8I/4ejVGccoPHYgAeKQlyg+374vkgwfrF58AJ0AGJ4DoFht2RDuAF77DfEKAYS2YYebTIes40CB3KvKE/eer03WfzAZhf0kPZ6Qf4U36gTfhdSe5C0zhrC4FqNH1Ax7xlvfwl4+r7XEAIYG8axp95cozY+mWPIkYtNVhWHC2D3EF5oELXMxzgMvaln/Uxf7bLNf/VPuTeCBdYqK5EjqMeRfA2YdcPJ6dhSumJU8+vLHdEI1PovxJMMN1Nr5Avg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JieG0+yjczxZII7mkixQScW6qARtcfxGwTOvp1NNMqU=; b=KZDfMLkBKZyzAYPbZbSo15mXy/TzELA+UazaNbbWhqL5P0sBRIJIJucxg1n9rInB2HsWvd9UJD9vMeLhUmQmQPVjANeR9qhRiZHNDX/7Rm7QZ+Onw5IM3AfYvua8eE+GTJCWOBM0gKz22uE/W+sMndl/PAA0osdyFfhJuQ/U20r6nws+V+XjnP4fKvP9ytPCkwwkKrT3wVn/xRrmaiWMI//WjIW0RedspvxecIGbHBZocdDyKQ9W/uKpoWCXOZ7fP4/jGD1YSXgUKh/kOBU+HWZdWOUj1RlqAMkCZN3bdKWwM9mJCSdN9Kk9EhUiLjZd9lyVfv4kGKDg0vGiX2V9Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <037151d0-0920-5d99-9932-df044729c00a@suse.com> Date: Tue, 13 Sep 2022 16:47:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Setting constant-time mode CPU flag Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7521:EE_ X-MS-Office365-Filtering-Correlation-Id: 53fae753-b32a-4bd1-daaa-08da9596dfd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZT8Z+4lVpULOmffrB7pZC0eYIYuxmtRftuhDVNSGHFBsjUva8AQey5z2rOVy9ymjuPgkP2APt1y9uCiEfHQqXCBRdmqq3vSpGVUDIvhAdT0MH+78rA2Sx/oaRnIt7ln5Wome02WszL2y72v1YMaWJqzR3ZsEnP8kRgvd4MVMwbvyFkHxGDUCgRng4th1dC3EB49nrxHNgMyj9+YvJX0tftBXJAz/9MXkiYsaw6rLG2L4THXmPEGcFaWqRstXTyjB2gWmqGwh6UriNUdk2AVANn6jwihidQw2+9qdTXb3+VxEAsGycZ2yYt8U9INCektkJWcZpKQ2nWx52EWUebaXitaU47p+pyUzGrUmpcjpbWRvWXBOydEpAP8HdAIBLZuDuyv29AOc+jerczVPDvAiv72TkuwtnQfZ4ZLub7fERcvV9J50i00x2b0vM9VSWCC6g5ogQnbQRmQdzZxWX7RGup4SUZyTUDDk7lPYFX8Nc2iu6V8+cIHQSsbl0jzYlzZnhDgYDom1AMMoMzGiZbF3khakHz/gM3yO9e6kJoYfLhqtb84+JJXZzeIZxIf65YGL8+EInQXd3wuALyEpYxUOMLChSED+RE9m11C3ezJjK04Ertif8OPumpWkx/tFZE6x4pbjraFMwhY/D7BR6XpQHeUnF0Oqo2u5Dim3qWO1+Gi5W5QjazGtjs1FD3FFV3B+YWpt71SXXcbHdUQT7IR1U8qey18Rg3858QEehYltPRB/U7SQ9xlUdxloqPjuMod97z/dLybKkbJPmpI20arU9dH/X0XlIM/zf0U8CeOfcmEsolLqN7KzRo0MNTYVyLiWDoYOfJXoaZj0H41AVnBQ8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(186003)(6486002)(2616005)(8676002)(6916009)(54906003)(5660300002)(53546011)(4326008)(66556008)(86362001)(66946007)(966005)(6506007)(31696002)(66476007)(8936002)(6512007)(38100700002)(478600001)(2906002)(316002)(36756003)(41300700001)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDByTy9CNTFWQVZFd1ZEWkViZjFFbXV5c2NqMGRQYzJxaHNJMXY0UEMyQ1lO?= =?utf-8?B?S0NtZTU5N29BbmlsTmhKOU1pblp0MUJLWGt0eWt1SXV5UWZrVER2bEpuL0o5?= =?utf-8?B?ZjFYS09wTmR1Q1BWZGZQMlJGVmN1Q3FjTndhbkhvRWswNFFGVVpQT2tjaGJn?= =?utf-8?B?ajZrcVkrT0JFSE5VUmV0cTFWWUNrMU85b0JLU2ZzR1FyWE1taWt0UUlESk14?= =?utf-8?B?VndUS0xETXArUGJXdXk1VWpaN0FUVE5VZkVZZmRlK0RyVllrYTYxUUliL0dJ?= =?utf-8?B?OEtxaGdOS3o1NFh6OUZYT21BZUZjdFFoOUVjMVhjWC9CYlFsN0x5R3F0OWw5?= =?utf-8?B?bFJRazRBN0VEQ0wxNXBxUmExUVVQbGFYMFRmTlk0dmp2ckdMdTNNYm5QZDRn?= =?utf-8?B?bVZzVnBHb1VPbFZiVDc3cmNJbDE5MEI5My9HUXRqQmlVM1plREQyRDdvTzRs?= =?utf-8?B?cjBYTjQxRTAxOE1YNFo2djhUM1RDa0tGZ3p5a3k2T3lPa2htcGR3NEZJU0x1?= =?utf-8?B?b25EekI4bCsxQmkrZmpOa1NSOVpIUUh5SWZpbXBBb21IT1Q5NE14dUFCakRy?= =?utf-8?B?Wi9qN1JHRS94MW10ZGQxc1hmbnM5NUVLeGxWLzdhZVR5MnpMSFd3TmRUOTR1?= =?utf-8?B?YnFQczBsaDRFNXZkbTloTWJhTVJlL1NKczduMmFvaWZ1QVUxVWN1eC9NbElG?= =?utf-8?B?TWVndEZjNi9hRnFsTlQwQUxBRkkxa0l1MHNPQzkvdjZZbG4rZHl5NTRERS9a?= =?utf-8?B?QXorV1cycysxR3llYm9yeXlKcXBOcmNQb0Fwa0tJOWZSRkhHaTZuQXMwaUl4?= =?utf-8?B?YXZ4UlVDdisrQmxaQUF5UTFBNzR0YTZjLy9yMjcrcHZ3akZuZ2R4K3Y1R1lj?= =?utf-8?B?c0J2SHdxT0FHWmVzbldxRVZwYnFZQTBtcVZHbWFWWU5HdzJYUDhVVHdBVy93?= =?utf-8?B?aEpvbHdxMmdtT012ZWZWOFMvSDhEODNOM3R0M0tjaGFFeGVLcklvNlpwT1BX?= =?utf-8?B?K3ZuMFNRMys3cUxUeXE3ZGFsY1FZYmR0UVpPaXdZMnBpVU9TMTVQeEROL0h6?= =?utf-8?B?ZGFsL01VYmtIMlZYenE0a1M5anNKLzNVSEYxa2N2V3liRk4wcjRINURRV1ho?= =?utf-8?B?SjFPS1Q1dTczUzhqYVJxVC9LV3lHS1BMQ1FKMmc3aGdKZ0tlOWg1ekgycEox?= =?utf-8?B?MW9yUXVERnhkbVdHeVdZcVNUdzU5dS91clk5dHpHU2NlcVhvdmNBVWxtOFcw?= =?utf-8?B?ZFhxVEJ2T0k1S3ZiZXRmVGhTSGhTUTNFRjNLaTRnb2ZuMmJRTm9zYzRYUmwz?= =?utf-8?B?M2RRTHZJWTJkcFNoMmxOb3VCV3I0MnpBQUtTaEQzdFd2UG9UczBDOVN6VWox?= =?utf-8?B?TGcrWUdDUmd6Tk9sNkxGUnhzaGNxYVNWMDRMRzVWdGZJRGtrQ0xyTU8rejZw?= =?utf-8?B?L1BIakg0cHZxd1J6NjR2WjlDcERzeWNwRFF1cHZueVRYdEJ5Slhhemt4YitT?= =?utf-8?B?YXlBVS9kMkFrK1ZrR3hxVUcvL21YeUdNc0s4YXB4UFhEMU1XVmU2RitSMGtL?= =?utf-8?B?NGxPMlRlS0Nhb1dMVElEL1hGeUJKc1NIOHViK2taYlRGVFBCWWM4KzNOVTY2?= =?utf-8?B?QVdmUHEyU3VUYlEwTllJU21ZT3BKaXZQRFhuczl5cGZKeGM3WnlWbG81akZO?= =?utf-8?B?cDNKaGRpdDJBS2NhMnBoNnBoU3RzOTJ5Q3A0WFFMc1V4S0JlNWt5aXpMTHVw?= =?utf-8?B?LytPS0lNdUt3Tk1vQk9pQkgyUTkzcmNHV0tYQk9VaGw2Y1gxRDNldkJmRTI1?= =?utf-8?B?YUthTC8wQXFwOUMxMDk3QzB0OXJZZVpzei9IUkJsemFLUUJpOG5FdXl0Q1pU?= =?utf-8?B?TWdkYXRMNi8zaVBRZEhYRDRJc3M1M1NwbEZvamdIK0IvaFI1YVczNmVnTzNx?= =?utf-8?B?b1Y0TTdUeldiazJnMzRnV2ZGdDhRTStTeGtvcWRTRk5oWTJkaExBSGZSYVB3?= =?utf-8?B?eXc3blNjb2s4UjE3YWl4K01sSit5WGwzTWVFa29xWnZIUDBJdVhiby9RWS9y?= =?utf-8?B?dnhSc1JEK0dVVVZlZmJhYUFzMjhzWmVPUGhLN3IwZGtjZ3hNZFFtUHludGNI?= =?utf-8?Q?eLPfFW+R5PsNJKf0M0jwtsTr5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53fae753-b32a-4bd1-daaa-08da9596dfd6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 14:47:26.1098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KVX3OEI/YdpOCuPusW8QBARszgYu8TWjkyp3Thc4NwOuLKzqNpw7o1BFPhrq4z5RWvVSZaqH4UrVMT1ME8lt4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7521 On 13.09.2022 16:22, Demi Marie Obenour wrote: > On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: >> On 06/09/2022 10:52, Jan Beulich wrote: >>> On 02.09.2022 04:05, Demi Marie Obenour wrote: >>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in >>>> a CPU register to enforce constant-time execution. Linux plans to set >>>> this bit by default; Xen should do the same. See >>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. >>>> I recommend setting the bit unconditionally and ignoring guest attempts >>>> to change it. >>> I don't think we ought to set it by default; I can see reasons why kernels >>> may want to set it by default (providing a way to turn it off). In Xen >>> what I think we need is exposure of the bit to be guest-controllable. >> >> We absolutely should not have it set by default.  It's a substantial >> overhead for something that is only applicable to code which otherwise >> crafted to be constant-time. > > Either Xen needs to set the bit by default, or guests need to both know > the bit needs to be set and be able set it. Otherwise code that *is* > intended to be constant-time has no way to protect itself. > >> As for why Xen doesn't enumerate/virtualise it, that's because >> virtualising MSR_ARCH_CAPS for guests is still not working yet, so the >> feature can't be enumerated yet even if we did support context switching it. > > Intel and ARM64 guarantee that CPUs that do not enumerate this flag > behave as if it is set unconditionally. I'm not qualified to talk about the Arm side, but may I ask what you've derived this statement from for Intel? The doc page referenced by the link you did provide (still in context above) specifically further links to a page listing instruction with data operand independent timing. All other instructions, as I conclude, have variable timing unless the bit in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same name) is set. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 13 14:50:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 14:50:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406462.648853 (Exim 4.92) (envelope-from ) id 1oY7FW-0001gy-WE; Tue, 13 Sep 2022 14:50:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406462.648853; Tue, 13 Sep 2022 14:50:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY7FW-0001gr-So; Tue, 13 Sep 2022 14:50:54 +0000 Received: by outflank-mailman (input) for mailman id 406462; Tue, 13 Sep 2022 14:50:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY7FW-0001gg-1U for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 14:50:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7557d3d6-3373-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 16:50:52 +0200 (CEST) Received: from mail-dm3nam02lp2045.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 10:50:49 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN4PR03MB6717.namprd03.prod.outlook.com (2603:10b6:806:1ec::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 14:50:47 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 14:50:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7557d3d6-3373-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663080652; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=oXgEM/dC8I13s3+hejb49goh+TWzqq46wAWupbDUo7A=; b=fPczW612FaArP0iBN0q0s4ppyGLAEHQivVbmEipx7oNUmMxaw5zJKASd ec99xKQl+xdVGO3OYIyM3/MNyKGW0qMBErbGnmCjjOpU+ucBzBEUthJAq uwnuslTafhjLHu1TKVig1MYZu3XA1C4NUclP7dKH6ukr915uumlL4PgRs Y=; X-IronPort-RemoteIP: 104.47.56.45 X-IronPort-MID: 80398874 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3Axfh5JK5INpBV3DnwmtAKbwxR2vbMJdrFRiYv2?= =?us-ascii?q?zbJXl9qXhvvpoCK3Hf2+NmzPBGOoPRMvK+3Egw4zW5/0hKst7Fcx0yhoI2WS?= =?us-ascii?q?ZuAqXOia4AVNskEZGj0w74dKT2LAwGZG54l6FIS7U58JRVuLLKfz6SH4CaZz?= =?us-ascii?q?6SPDOGfZKtqw15gxh3/zNLIDiuxjggI8MgTerAhRDrBm5LjXdy/ldi28dE3X?= =?us-ascii?q?bu9Jea9ntmGP5XvGRBzOo/gGo4notYLlhw30KmXOznNODuBqT4gjlv2ehEnR?= =?us-ascii?q?VTgyC06lpGniydkZ8daOAJ224WhO2SUnabrG9ZeJED7o7r8cL5xHgBTOQftS?= =?us-ascii?q?3eubJVYRHNqQnxvbVlKtBe+sWRqcQw6uWtAWm1sk16CK5dLsN992zZ6TDNgO?= =?us-ascii?q?bZ1NAwgoqyxKixXXzoRZr/A4n8OpWgARHw9di6KvKnLBs7oiTtCQO4e+UnHG?= =?us-ascii?q?FMFLayXxFXLOfVa81k54fSzOH0y64x1/A7Q8R3A+Ss+CzDCQkSzm7iaN/Wbl?= =?us-ascii?q?9y0J4sjb/Z9nBD7l5yvsCc0ZEaIjjYzlawYoDGbBDl5FClKA07O9vI5ZrewN?= =?us-ascii?q?VtC1CRW6oBqISmuPrj/gfHKBXnQke+bHq1e6xBccwqoVKJlvF9k6F5FBBu7t?= =?us-ascii?q?nV1x+05KRlbEPlfHcl9XhFX7jef2cAJtqOgj5qv9ZcDyzehsRmsuOK+Q9FrE?= =?us-ascii?q?vTWmW5tXAQqAkXkE32RRPC/XjhLULTcdOhqa5kDknMu46SFqsRocx68G0sd2?= =?us-ascii?q?UQews34lOBsq/kYI/Q7wcjrX0nBE1oTyjIxRfFsYGFtxcnk3+wnJqmrq9MSt?= =?us-ascii?q?LMkVwbkLbS8vNim+dN7K9AEQWImk7U5ZN9onwMO/SscSsFeOzuQOm8SCZMy4?= =?us-ascii?q?L/vnIBWqyFhPrLZpK5wjpOoTy2tAzG6vWZXPCmHZ+jUOjbIdnzUvHW5/z1qH?= =?us-ascii?q?Tw0bZHlg6PZ5vKDnAYolLtaA+o8YPhTNcoh/DknkEHJpIAINSp2KqRPfEE1w?= =?us-ascii?q?Kau/pLRmLU7zr/JhQus8NvBWz5izY8sXMmzg7Swe89H/2JXIs4M2v3Y+oFmo?= =?us-ascii?q?iiLTtT40vU7GaaKokIwgkOdhwymjs2csePhxcq07YYqiy55NzTLRKrsoNrgv?= =?us-ascii?q?vWldqi/33JZyrYofrVm17QzeyN+p57KI9/KciqXLbOLzjd7Gf7BzLYWhYzGL?= =?us-ascii?q?YoObiqMfh6o69X0B0vqRR1M1AOlllgFJR1A1haTjuQUOe0DhCzlztjMy/SE/?= =?us-ascii?q?ZUkBaJEisp6BHFNmBxh6LcyNyjQGJICSWgbrpBRM87WK17I5th91qInmkTuL?= =?us-ascii?q?DviaWAlkAqeMngvOqJfz/bbcmdkU6hk8VJmzWfcfaQaiCjvS1IOf1Hgpkzjs?= =?us-ascii?q?R2K5jk+CSc7wqsvZe/4fgZoDdPMcz38AZv1D5EeuKrElJtAW2NE817J3DB6p?= =?us-ascii?q?7wHmsIoX8RVjyQTZTHZYYB9B8+SZbME6FwI7Ii03hC1pCqdTrkweINlN/vC+?= =?us-ascii?q?Du8gwd7tkyyXJb9CGFuU88fHYGQOsbggabogxk/zl5NfOdzPOfEn+aDvKigM?= =?us-ascii?q?AVzY3tox4oYSorn1Yh7HYlD0/qiq/dKIOOBx1W9h4d9RRPRaXoRPcykeZ4UX?= =?us-ascii?q?KUjfvCCVYXcvudSJWiluEpWCLzZLMcVoiKGqFWpje8CRC0CYAkn0lMUP7qU0?= =?us-ascii?q?C8HFefkUhTTjEz6uye1rce+BrASIemUNBK1Rv9g2NNHi2rHtGvDLBTIh8euN?= =?us-ascii?q?zDfYSiVNE+IhvMM0gTWtw1GbK2yksFAWwjL6+cjyPiXWvCZ+Tg6k8pOOXUxA?= =?us-ascii?q?+ZsWcANEeTj5tFPoxtjtsz6NNLu4Cpraq/GWGZ088QUyLli6ZsMzLI+Wp/a5?= =?us-ascii?q?a0x8BO06jSU6Rt6ov7ejzGSKjxUe7MIbOH36xVswGPHQ56lx/D2RfFwW5YJh?= =?us-ascii?q?u9b4Y8jah/BAPfi04Q2G01ZFvp/izX6tpEeKRoIQDbepRcbwzq3reqlK8bMd?= =?us-ascii?q?/UR3b32YdCwx2oh5Ch1ak/bcetjagFU11JZL1lyCKh1wohkUMoUoCz9u8NeY?= =?us-ascii?q?IKU1bF4ZjtZFbW8Tk8qKgpZqLdBLAbMJqO1MfhYlm5CbmygYnReQgMnxHTHq?= =?us-ascii?q?o4ZrTW+yPdtmahYklXDfFXemAMlZrv1LrqxDfu8belZmNEX4lms6OO6sgF2a?= =?us-ascii?q?GL/uJQDOQgPN30RKFj5shQ2dOJ3GvQwf4UvAy+F5DFdgqnolh+nAYO0pzyRi?= =?us-ascii?q?N58cEpfnD4UH5ayxPChNu5cbJ0bLxUuRm3DfFtMjUsjgvU5HPQfSP9a3O20R?= =?us-ascii?q?M+8HFXi2WtxvydHP0Xp4oghXSeoVtttyhmFzYc6KGhcgr86R0d549TvSo3K2?= =?us-ascii?q?WNGFLWZ?= X-IronPort-AV: E=Sophos;i="5.93,313,1654574400"; d="scan'208";a="80398874" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WtiAaPke35y7gFzu8QoGUuc5RxEM1uIX8YjM+kgDIW8xBQC67vzPY9bCbrIGdETSMCv8zg+rI66kqQOzMzT8/JZY93VQ5F6wOL49baeLx9RuEyWMrj29QLgvFEi8kzSXIDBUlwZZQTTX8VYjioRLSsjKF40O04XpRxyX7Pjg1mdtTW+U5mFhFxcC+EqIuubbpmRzzDABQ9RjI7N7T1XRrutsBOuXtBkJY7rF0p1aPhJFB49N0VQmYDoqPDoRaPADSrwMgiIBy74X+tCj4qoM6Rj7/igAIWxh3A3nEnL6NCHWXXvj6XoQRqG9YS2vz+6B68lBH9eD1x8/0mlf0KVwlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oXgEM/dC8I13s3+hejb49goh+TWzqq46wAWupbDUo7A=; b=JnojP1ncq8vEN+CnEPFAWTqa+p54TVmlgLf+c41R8od+QIjH3EuhQ0tZ2hvnMXQsyP3N/PfmxzjKQ3icPfrrcV8AGot7TqizJbssXYldVhxG2Y/rpTqu7K42vPGKvfHWzzHt58GsDzHAFayRDVFH6cV9QmN5ddBCy9F8aDdN/a4OCFteTjOEnihy29VYIYSxmY9v+zExdR3zaujJ50GDIbKmntJVHCF9OVQyYuRdD+f8A7iHapn4cPN6EwlwJ0B+r+PTEcBGR2O5bElhL597rM/bm55rpfvH4r7FGhkj7YABq8r5c+E66QVb3RmLClxFMJBaUBlYy/shtlirgbuN6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oXgEM/dC8I13s3+hejb49goh+TWzqq46wAWupbDUo7A=; b=Ivh8gOqb3ZkwchpB7c62QDET+cS6azGSk8QpP5w9hYDAFXFFuSfhZkNbL5Lq8jG2bGXnpt2BKZ5KLtMvhnock6gSmPZqsabLMbXSSCbCTt7T/7t2wV0p0ycRVfPVEOvbEHa8im/93LZemukm09vXR7JUN8X3EQijtI6Enrhilm4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 13 Sep 2022 16:50:43 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0033.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|SN4PR03MB6717:EE_ X-MS-Office365-Filtering-Correlation-Id: 76e39e84-396f-4440-7f77-08da959757c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aPdVMgBTk6cUEp0ohQ1enrRi8yHa3Jg/oSs0GKdFQ+izMgXnxiePtehYZkMv1Rj04ZgTljrdJBb7splsaHXqgPdG8thk8iFJZ6F1hCqO5QZktJ9ITk0iyjk9Qqwd0D+i9ubnwe+lXHTsMqJjEmIriTNYEaGqAk3HRxeJDUwxlLLJ9ckhV+j5gLxQt0k7Tw9HgdSGGJNj8BfrjM2YkXO3B5zMLrJLvN3dxtFEErBrryerQx1zO3wPRpJJCC76uRXFUjO+Kn2dErQvIMVmv1qRAPXXUXVGzVu0W/T5Q5sbB+Sb/1m8aYYGwslmKDQMQx65BoaVbV9mi3tuZppY4IM+yuzBpgahrAQ/Ma8/++060TYmkycjEPo0BSTep+/68rLrCwq6IqkqzwJierSZiuleuqF0QvFYw74XMqYYg/IR185MZQ07FVTbEK1bJgeJB0Lt3clmPrJBYTIykwOvSWj6PoVf2nZuf3vPjFBCdaya2Wj2AtV0byX0fRggqYa8CTaqAAXoJCumIFGbcqfbugYqwFKXc5+rvAI6G/JLg0bGMOl/2RWbyn+3+bgL2mpXRgCmKDkeNyxgULltsOmr1oQJyOgcbZVJac+Wzg6okQMPjTa8VW9mBw0MPfk2VgOtYG6xlrx2qrRxD+zwz9WoJsKgF8CcTJh63Fn96u++bQI7DWvHp4m8Edbkp4UklZtoNUXxLsffnA0YDOHY9LmVjDz477zSIpc/pii4LSBMpdUJnFmcfGuZlzJSx3hVomqtnMel0lRUREKUr2gSF3zVDu+lRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199015)(6916009)(2906002)(66556008)(5660300002)(86362001)(8676002)(6666004)(478600001)(66946007)(316002)(26005)(4326008)(82960400001)(6486002)(54906003)(186003)(41300700001)(4744005)(8936002)(9686003)(83380400001)(38100700002)(66476007)(6512007)(85182001)(6506007)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1cvYzhyREF1QUJJMTA0OEg1QmtLN0V0RzBGR1EvSU05UGpFNU5xbmttQ3hi?= =?utf-8?B?ZGRucFNsV3NZQmIva21QcVhvMnBaYWJ2ZCt5QXcrZlBtcEU3WXRDZjVOODdG?= =?utf-8?B?NXZKMGJ1UnpQTy9JY3JybjVweXp1bk50ZStCQ1ZLK0RtWi91aW5yVHY0S0Zk?= =?utf-8?B?OWlYcTFpOFdpNll2a1pZTHFjY01ybmxSaTB5b1pQdGZpb1gxMG93WHYxcjFC?= =?utf-8?B?ZGYvMlZid1NhS0pLZDhPemU2ckFjS2xNUkdvQnFVVkxaVjFvdDgwMTJ5V09r?= =?utf-8?B?STdMaFdZa0Y1NkVLU29jUEYrRHc1QXM0VDU0UXV5WFhDR3B1eG9yV2JJUFg0?= =?utf-8?B?Q3hpRGtwUWljaVluQ2NGYkJNbjB6UVBXUjBTbE9zdDliRnlWZEdldkppVFR1?= =?utf-8?B?ajNHVFc2YkxMSTVjWTlXY1FDcFMzNGY4Nm9xUnlYbTlkQmhGb1ozdE9MakRj?= =?utf-8?B?TjBZQzFtSm9ZQmhhRTF4MTVqWVFGa3dVQ2FyQWF0ZzlSVGRTSTQxdCtUbWoy?= =?utf-8?B?eDdjTU9yaHUwaTJrcUV4QnRuT1A5U2RrSTQ4eVNGMmRFZXhodFEwSDhEZ2NY?= =?utf-8?B?WlAwZXlXVjV5VWtRbTAzUmluRE5odzJVSWdrUzlPdk5EOEZVR0M4VDJldjBx?= =?utf-8?B?SmFMbzlSdXdtMlVpNjBhMEpRS2R4SWVJMW1rOUdWOXg5MXhtNkkzK0hSdmNl?= =?utf-8?B?MExldDIybjlqUEM2Unh6V3NsK1VDK3Jsa2V4R3JRMTlxajFkL3B3cnhTclo4?= =?utf-8?B?MDFxSERmVEtpMzZCODNoMWg5YUhBUHBGSE96T25vWTBDVkNhNWJWSDhKaytz?= =?utf-8?B?eHdoMjI5Zk80NnAxcitMbHBOem1URzB3OVNzbDlJRlNBd2RIV1dEY0gwOXlv?= =?utf-8?B?czNXdkxQYVo4NTgrbnhaeHEvK2cvUjIvUDNuQjBxYWlQYm5waUNhQUFobkp6?= =?utf-8?B?bFh4dW5KUVdmbFFleEd4NVAvb0p1Nnk2NkMxLzZPU2Via01xSWN1Tlo4YjNY?= =?utf-8?B?OG5nMThXbmR4T3BvWVZxdS9jRTVjUVREWUdvZUh0bG81NlZCanU2OWNjdnFl?= =?utf-8?B?aWVwcWNyZnRFR2lzQkxnZG9pRFBnQm11dGcvL2xPQlUzcVN2N1RTSGpqdUpL?= =?utf-8?B?d1REK3VqZjBZSlQvZXY2UGEyQXNZL3NpTGJyUXF0eGNvMXFJRGxWN1RmcDBn?= =?utf-8?B?K2FFZHg3OWc2SElaaUJJVDVXeG84QmdpZDRpR0REQWV5eStVMWtjK3Zra3Q1?= =?utf-8?B?RWpIdVhuc3paQi9Id1BCYk9wSFBkeGFhcEJ2TklBUXJzeDNEUTE3Sm9odjFO?= =?utf-8?B?ZkUyNEtsa1dGbEtUNnZ1c2lGcTJ6K3lTL29MSCtRNzVtR0JndVlrKzZtWHdU?= =?utf-8?B?ZGVHTFJ0dWY0N3VZVXd6S2g3UjBpMVZLUE5sUzNIMlhEMXBpUWhZdUJnSUp6?= =?utf-8?B?encxM2doWFZ5YXRPMlg0M0VSMm1FV2JJQks3ejlNNkJHNERkWVNvbjRtRlVT?= =?utf-8?B?bHhyNU82N2VxeWlGZk9WMWdoc05CMTFTR016ZERTQlRXUWluTUpldGlFdmdR?= =?utf-8?B?ZjAwblFyWHg1dFBuMUduTmh3bUZXWUk5a2w0RysvSUV4Y3grNzNmSHVlQVVa?= =?utf-8?B?d2xaR2tsMCtBOXFReWRldnU5OTJEUDY2SUdTUjZjVWdZS2NsWDdIOHl4OXZl?= =?utf-8?B?WG0wakVhUmxMaGVmMlNiVk8zUU5nM3g4bUJRZlNNbVVDQ2xROHRwc2VkOGxm?= =?utf-8?B?SFgzY2xMdTBHaU1QclF2eGhybjlDQzRzQ2tSZk9jSFdTSG0wNC8xejJZZFZz?= =?utf-8?B?WGxCUzJyVWFJQ0F5UGZPUlhRYVFOUThOcWp4b0JCOWtrOWFOWG5zNWhZMnVs?= =?utf-8?B?emNuUUxVMDdTRktDYkdjMEtWMDRDQnVJMTl4d0dzYzJwUGw0WE94RWhSeHZF?= =?utf-8?B?M3gyUWlnSFh5U05KdFlxMjNsUzJ3UFFyUUwxcHk1QXNYSlpqazd2S1cvZ0tK?= =?utf-8?B?RTRuNm9CNkR6bFdKeGMzeXIyUERxZ1VMOEc5SVBjdUFvUjNYQXpvQ2hhYjhG?= =?utf-8?B?UU5kV2FrYmk5ZnRoRnYrTVo5MmdoUkN6Ky9TWHk5dlovYnNaNXA4K3NZVXMv?= =?utf-8?B?d3Bib3NBQk8rU3lBVmFNTmhXUm56U2Irc0lGWTE3c2NvVHZUMUY5MXNrOVh4?= =?utf-8?B?MHc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76e39e84-396f-4440-7f77-08da959757c7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 14:50:47.5388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eyNnqIbv4Bc6RoP5Rs0xrTGbng7uPp6VyvCk1Sq1LOQ7jZ7B0osBFu1Ibg0CdoogcHxR6IljF6RaGLhLA4MuMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6717 On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: > show_hvm_stack() requires interrupts to be enabled to avoids triggering > the consistency check in check_lock() for the p2m lock. To do so in > spurious_interrupt() requires adding reentrancy protection / handling > there. There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will trigger when trying to acquire the p2m lock from spurious_interrupt() context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> percpu_write_lock(). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 15:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 15:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406472.648864 (Exim 4.92) (envelope-from ) id 1oY82Z-0007V5-Lr; Tue, 13 Sep 2022 15:41:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406472.648864; Tue, 13 Sep 2022 15:41:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY82Z-0007Uy-Il; Tue, 13 Sep 2022 15:41:35 +0000 Received: by outflank-mailman (input) for mailman id 406472; Tue, 13 Sep 2022 15:41:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY82Y-0007Us-Tb for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 15:41:35 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 884b9c77-337a-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 17:41:32 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 11:41:19 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN9PR03MB6012.namprd03.prod.outlook.com (2603:10b6:408:135::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Tue, 13 Sep 2022 15:41:16 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 15:41:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 884b9c77-337a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663083692; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Gzi+YsXN5uS/ov0zoXvbasJxi/PBOGpTh+thdcn4ucM=; b=HxraF27HjkBdEQD1iVcQpH58/UQ9GGRBx8NsqucKiEOFUq0RzL+av1zV lIooXGaLJZxITf6puE0yChsF6IDGv6k4PJC9nxTpIFg212Fa2eglgXG+a fFu3oLI26ySB0/sJG/9j5oaHG910wx3GwUgNLo/1kINmdsI7vhttJFDo0 U=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 82929062 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VwOXWKsAWTEq32uj8bTtA45Yu+fnVERfMUV32f8akzHdYApBsoF/q tZmKW6OM/yNYGDxKd50OYqz9UpX75TXmNBhSABtrngxFi9G+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4WhA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYYb9PR0Xntqz P0JJig8a0uAqcip/b3uH4GAhux7RCXqFKU2nyg5iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QLT/PRni4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWDUqCP02LWncSXTetkuCLqbq/RTpliQmGIiFEcuZ2WBrqzs4qK5c5cFQ 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neWm/v5CDopt6eaIU9x7Z+RpDK2fCITfWkLYHZdSRNfuoez5oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr/hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:xK0xeqG9RymDbmxwpLqFDZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tPKL Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+yLzGomjMlFx9fy7Yr9m bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHffWK1RH5m5+BwlquCm71gn1P HKvhcbJsx2r0jce2mkyCGdqTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MH40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIeLH45JlO01GkbKp ghMCmFj8wmMG9yLkqp9VWH+ebcEkjaRXy9Mwg/Us/86UkkoJk29Tpa+CUlpAZwyHsMceg62w 36CNUXqFhvdL5iUUsvPpZ0feKHTkrwfDnrDEW+ZXzaKYBvAQO8l3ew2sR82N2X X-IronPort-AV: E=Sophos;i="5.93,313,1654574400"; d="scan'208";a="82929062" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EruD3GtNEKiKgI6ZaVfzuF0c/KPM4ye35EuSprgL7pe0Em3rAoSSO5DP4Tontn1pQaJAosg/VPFoEgnZ4pkwdFyFGxY99s+NEVMZ/7fy7VwQD3J/Ig/1ekugLsng++EyIQcLRD4PXVTcRaBgXyGpexEEuGCOqasPqG0hVzpYURRW5rZEPySnq+6c9QKQeYyXrKWGTKP+Ozsv+kvz36c+dB2cCnHs8TNq+swlSd3IylXqySlpwrhs7MgZAHcxcZa7QSu4CvqbKX5Q5kwXzHum8fopqLbBssUzOcIEW56NcDg0VVf6Ty16gzwTKhgNaNISgm60ekF5sLKqy7frpGV5+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uiGZopffOrsqHm6hSKlZXobArX9sGqYV8e5b0TiaAT8=; b=IjtIwsqKiB7PLB1n738Y5A/2tANL/auiowlU0I1CQwuCoTZcfzKbIQDIxEz5FtUfguXG7PfsE3qXeBVyYtzv3D3JZhXWyoy19I6mgp0lojeKGbJfTu66/V6Jee6kT3JIU0WgvqVY5mOMF/8S1zdD3faQjNeTXBL7xFiLnabpGnvHq0Ma6rvkP/n4wHa8XB8EjvttD4AeDcUxRj3g27Seuia6v5wYM2QSZFhbQ5hG81lkU7NweLCQlCZY37EXUToTPd8p/9Tc5yx74NweZgOCBBLiEQ/axNF/EVKwijTXQ6LIHaMDhoPyTcXXTCCr5U/HB56IdpYU6iTKA5ZY5VdEjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uiGZopffOrsqHm6hSKlZXobArX9sGqYV8e5b0TiaAT8=; b=vhZ38WS0XunQnAJaF/EbDxRvf9VL69jRwYtgs15rMGamu7V3/AKBxjFv4iybBW+XGibLZumTtwZgc390/NTB2gxwR0IJtMjl53AmL0K/YyppcBV4caQpYhLnIPSnRG0CGsdGjzn4ispU7ggsqWzK+eNNo3BvnLRkfCoCWlpEeEM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 13 Sep 2022 17:41:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH v2] x86/PV: issue branch prediction barrier when switching 64-bit guest to kernel mode Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0159.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BN9PR03MB6012:EE_ X-MS-Office365-Filtering-Correlation-Id: 291a2766-c9ae-4eac-6fb1-08da959e654e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aS7KiRJUT4bmLCuMU4KTXjFOn+z2DO2L97m2VtaAxbct/rY/kwSud1gWcH/1yPhS1XQuxwvSajewZJwQTNulPhq1IpmfSDdGd2B/SdjdWmnoNdgmpBMFlTriwxwopSGZICwHLqBRNWSOBJO/sL4XuV9iGXrt4ZjupjE5lt4ON2dnCr7nfeJBh1DI7z5k05nMYy0E85J+LuCJfl4f3krHJYmtjhtIEHXyT7FuEa1yjqlr0TncwG25zmotOBpdTpuwOYcBZ1axu1OR/n+9U2+gQRB954plOfTQCfuP+M2Whjs+TPrtKjBW7qOB69L6uzL0Ensv+XJMstnqavtAtJKpxVWDO/YxAEo6UBWuM2fUNykBdNKMzRbRq8sG4Gc9v+CMwlyOZa6KkrCL1gWJtI3SMq07IOqXjSwD6lZqYcGbm9PHrUjn9YVOux9tytUt0C83FXJatHneGep7oZZX/VmQx9cUqI6N+xeQ7YO0AGFhr0RxWf5ngnvXyv0Tu90nR62o7J5vnSCZMW1CMVDNeDEHaZ4hz+r2+Fg/RZmOhAmOLofd9gioMJzkRA4cMuvXU/iW1ycOz8HL1z4Cg7BzCn3mESvjShAtpjYRZ52625/V/uikObU3mvJjcH4SqLG+2esGO3dyGN0FRr+bS+SUfWObURnImEWnVd93l6Cd/81fWXn5jE+YR0dQscb244eLum1ygR3CtTZzNYk80cglL+jzVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(366004)(376002)(136003)(451199015)(66476007)(26005)(6506007)(6666004)(66946007)(316002)(6916009)(82960400001)(38100700002)(8936002)(41300700001)(6486002)(2906002)(478600001)(9686003)(8676002)(66556008)(4326008)(54906003)(85182001)(186003)(86362001)(6512007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXNoZlpsb1BkYnUrVDBnYXdJUEdhUjdFOWk2TUU0aDF6eEZLOURQaDZhSVJD?= =?utf-8?B?UlJZWUZzcWEyRlJSRlBJSFc1MDZaaVhuR1JMYlFQd3I2Z1F4VXBOMHVxVTJT?= =?utf-8?B?MHUzalZZczRxRnlYYk1sTmwzcVhxb0dkb2IyODFHZENJS0pDM2g5MnNyaytn?= =?utf-8?B?MkdyWE55cncyRGt0YnZGdG45K2grYnFZVm1sWlBWeWdSdC9lSDNKUlhVVlhl?= =?utf-8?B?N1ZGemx1bFIwWWxYajhNVlNna1Z2a2t2cVdsZWRkMTNDNDdHQmsrOHBmajYx?= =?utf-8?B?ak95MGdzMHFacWRHQmlxaHQ3V0daM3hEdG5oTENmb1hGNzFPNStEdHF2U01T?= =?utf-8?B?QjRjRmNjdldLZFIzdEREUHk4SythU0pMdytjRmFmRWc1L21Uckl3RmFsTlBz?= =?utf-8?B?aVR1Wk8yNTI5dFpjN3JZVUVOWDRtYUNxWHBmakZGZUMzRnJYSEsxMVNldlRm?= =?utf-8?B?NUd5amdJa3BlaG1qK0ZjYTJQenVIVHU3Si9jNm5aWWw5UHIrSG1ncXhOSkJX?= =?utf-8?B?WUw5WjRPQS9HR1FpZW1nbG9sKzNwNXg0U2ZWZkkrdllHVDd6Z0YralVTNWZN?= =?utf-8?B?aVlSeGV2b0lnLzJ6RTZDejNXUnMxbnVhUEw0KzJ2dHFlbHBETVVLdGJUYnAw?= =?utf-8?B?eTRCRU1YYXp0NWhyNFVUcXZldXU0ODRJTFZJYW5ZZnVwZlprT0RKd0l5U0Zt?= =?utf-8?B?cXhPU1pHNGNHa1cxOFNpcXZXckp4UnN1T3pQaUp5bFdtemVVU0lZT0RLUWtG?= =?utf-8?B?KzhhcTBhVjVPMTV0NEZIdFQzcEtYaWNvME93TXJMYUlkYmJ6REV3UWtPbGlF?= =?utf-8?B?aWQza0ZQb05LbHJ2VEx6dnAram1ka0toM003M0VVV1lLblNQUVFWSXFGM1k0?= =?utf-8?B?NWpuKzk3M2ttWmRZcHJBVmUxQ1VLS0ZQRm1wK3BqUlVmQm1aS0Z1MEtUaHdP?= =?utf-8?B?ZTM5QWtRWk1Gc1ZxQTZ4SlJHWWd6YjlUODJIbVdFK1h0QnVqL2tsbVRIMG9Z?= =?utf-8?B?RDkwc21ZRzdjbDRCZ3lqQjlZdFV0RTJwak1KZHVsbEpOMWcrWUs0cGVRNi9Y?= =?utf-8?B?VFVCRS9YN08va0QxTWhjQVRBeldZelppellnWCtMQVZOb3JiaG1URHpoaGVy?= =?utf-8?B?bnhIS0RCUEQ0T0FwY2Y3MGNVWFhCVS9BVWFCbVI4UUpZUkMrYVpITzc1aFhm?= =?utf-8?B?OXZPSXI1Ui9QbWJjU0dldzh6RkJXZWJ1MGRLT2xZdlhBSFRJV3I0dG1hSm8w?= =?utf-8?B?SmJZR1FZL2RlSCs1ZkluQzhpRlF6VWs1RlQyQVhtdEJtSzNDSVNXTXFpQmlS?= =?utf-8?B?b0tqV24xS2J4ZXdRSjdRaDRYZEhnV1laNUJaeUROZ3d1TFE4VTdZakF6bFl2?= =?utf-8?B?dlpXWDhRemhEMjVTZkkrbGlaT3hhT2VwYzZkUmhuSEE0WXhQdS9RSENYcDc3?= =?utf-8?B?WU0rQmlGZFl6eE1Tcml1dEZ3UVhoTDRyTGFIN0VoWW1uNzU3SjRsZUZZOEdj?= =?utf-8?B?MGZ5RnVxbmRlNlJpTG9FaXEycVA4Z01weVo4T3pQWXJrNU9PaS85UDErb0lO?= =?utf-8?B?RXEwdXROTW0vWDVwSFRaazZyVnZCVXNBQUQ1Nlg3eUo1dDhrbk00UjdIL3pX?= =?utf-8?B?eExlaStxd0xWajg5bnpRRkpBWG82L2gwTDFhL2RsOUt2b3F1aTlmcStjSXRN?= =?utf-8?B?Y2lEZk1IZERwY2w0eERqOW1BNTJpc3liVy9QTTZ6TUZVaWV6dHduWGhscmZU?= =?utf-8?B?WHd2aXh4M0VyR0FjU2hWeHJSR29ITnB3aHUwb1pZNEFJSFlkOHpBbFlHK0R0?= =?utf-8?B?SXRsTjlVZkdjWTBQWXdnNHd2VzRST0VCLzBkN2phbEpoWTJGbExIeWRiL2xt?= =?utf-8?B?Umlyb2lzaEs5TytnY3dJOC94TFA4OHB5MWd0L2dMOXhiRktINVROY2s2NjZi?= =?utf-8?B?OWx4YytBeUV1NlBZTmFIY0p6aU9peFF4dGVxanN5aWRxbHVLd0poK2NxdndJ?= =?utf-8?B?ZTFERURUellXVjJVc1NZMFE3c2lLdEhUZlRVMmcrdTdCMWF2M3RtbXA5SWJN?= =?utf-8?B?MXZ2TkRMbDNrU1lFZ1BkOGNOUE5jWE1GNGI0RDhQQW9qREVHY1dDbDBHQmxP?= =?utf-8?B?NWdLaFlCS0lKSDlTOW1vQjUyQ2ZabmtoSFNiQVE5L3pRTWFqTitmZjdjYWwz?= =?utf-8?B?Z1E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 291a2766-c9ae-4eac-6fb1-08da959e654e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 15:41:16.6026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o5ASK1ZdODmmIkynsjNTtxmjVE7IBG+MFBsPRTZ3N2ZzzFi9GOrfTgD5XeKR3SU5cjhPCiyOOYBWj8OxZ/cF4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6012 On Tue, Jul 19, 2022 at 02:55:17PM +0200, Jan Beulich wrote: > Since both kernel and user mode run in ring 3, they run in the same > "predictor mode". While the kernel could take care of this itself, doing > so would be yet another item distinguishing PV from native. Additionally > we're in a much better position to issue the barrier command, and we can > save a #GP (for privileged instruction emulation) this way. > > To allow to recover performance, introduce a new VM assist allowing the guest > kernel to suppress this barrier. > > Signed-off-by: Jan Beulich > --- > v2: Leverage entry-IBPB. Add VM assist. Re-base. > --- > I'm not entirely happy with re-using opt_ibpb_ctxt_switch here (it's a > mode switch after all, but v1 used opt_ibpb here), but it also didn't > seem very reasonable to introduce yet another command line option. The > only feasible alternative I would see is to check the CPUID bits directly. Likely needs a mention in xen-command-line.md that the `ibpb` option also controls whether a barrier is executed by Xen in PV vCPU context switches from user-space to kernel. The current text only mentions vCPU context switches. The rest LGTM. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 15:52:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 15:52:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406481.648874 (Exim 4.92) (envelope-from ) id 1oY8DC-0000dw-Mg; Tue, 13 Sep 2022 15:52:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406481.648874; Tue, 13 Sep 2022 15:52:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8DC-0000dp-Jn; Tue, 13 Sep 2022 15:52:34 +0000 Received: by outflank-mailman (input) for mailman id 406481; Tue, 13 Sep 2022 15:52:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8DB-0000dj-27 for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 15:52:33 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1255b8fa-337c-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 17:52:31 +0200 (CEST) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 11:52:28 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DS7PR03MB5397.namprd03.prod.outlook.com (2603:10b6:5:2c0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 15:52:26 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 15:52:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1255b8fa-337c-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663084351; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=m4NTHbxnG8HEDRgGXUa7Rr1b/4bdnSXF16lb8g+Ovqs=; b=TiQ2Iim+IjyIpD0V59LxcoLuq0miDtGHIJGsGkyKor4UNLdsqmSSz2nA MaAGO3ShIEMYMAoj5olSwH0MAHciOR2yov+u2YoSoqQB3rxwfDG4d6uGE VRwTbcmHj+r/IE02DkyBLLb1Hsoj1faBwUN7mlvr+w0vkMxT1ymZyqz/3 I=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 80393606 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Lb4ZeKtYyAkxVFzTMqmGkLfmaufnVMxfMUV32f8akzHdYApBsoF/q tZmKW2EM/6PYzOgL4t1YI208U5X7JeBztFmQVNvrC9gQi9B+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4WhA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FaIFpc9KAEF+z 6AzLjZVax/eqdyYyYvuH4GAhux7RCXqFKU2nyg5iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T/PRni4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWLeoyny3rGncSXTBN4pFIKqy91Tu1S02m4WMSMRchzrvqzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv neLgtfoCDpHoLCTD3WH+d+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXrnUdJLAKOzyNrvFlnYw T+QqzMlr64OlsNN3KK+lXjtjiiwvJHPQkgQ7x/OQ2O+xgpjYciuYInAwXjW6+xRarmQSFapt WIB3cOZ6YgmCJiXkSWXTeYlHbe35u2EOjnRnV5uGZY68z2nvXWkeOhtDCpWIU5oNoMIfGHva UqK4AdJvsYNbD2tcLN9ZJ+3B4Iy16/8GN/5V/fSKN1Tfpx2cwzB9yZrDaKN413QfIEXuflXE f+mnQyEVB721YwPIOKKetog IronPort-HdrOrdr: A9a23:JoNgTaNtC5uK3cBcT1r155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REoGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUMTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJvXfwivZv3Evoz6hNO6Ws19 60TJiAq4s+P/P+TZgNcNvpEvHHfVDlcFbrDF+4B2jBOeUuB0/twqSHk4ndotvaM6A18A== X-IronPort-AV: E=Sophos;i="5.93,313,1654574400"; d="scan'208";a="80393606" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9HB3gSdiRmVkg+eS81K3UvzWmbFM0gQtXnLq3FqqVCfuDZdDnzl73Ua/zCusDyouFs4TNhP5n5oSfdHrpHPOWVS3qzjFe7ITqHxHAIRmnkO9Ko8wQM67PRw0k6H3+2Yy7S6XQhMWqRVsoX5uADjbwORJl1F17T38v01qMblAgbxMLHP17/mYzbxMnwqlJXHpboQCczmLWDQFM+eC9CenzdLC4P6WuzZUJTjaIG+k4n3xgxSKs9p80FddPTioh07NzmISXYiLifW64d6v43MCQxCdbKlvGK4/7iEpISPt/qnHFrE8CHoj/MPY6VS8J2p0elv4izMyt15L/HZYo8mtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRW7TM8+i9v6IJbAGrs89ZahD+E4S8+UFs5RzCtGduo=; b=OmOiPLjJ6UpT6/mWmm2Uxt8A32oY8T2V7lAGTNL0Q63ARKHwatcIgTVh6kKeXvgQ8IybNJdAMTqML9BpQlaqMRaXZdM2tWz1waphqgznfmMBEasflILOmUmOnmTC+bqyaKqsSSaBsERsrKtQic5nw0ziTLNXyOFJ7PBNdx2wL8+Vsl9KwJIlgXy4BEcDoQFl4H6nKjpI4GF8YJjVQQK0jkZBwyEUyhjh4fcOh1i7OTvEOiMttMAUz/cQvj9w+NdLwi37ioT32nPeESj5Y0Jr0FIYkrltoGOsk/vwKqNaeal8c7nO/ffHX1kuerzh9i6viUpiyQvKakOJJN6g9XOVig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FRW7TM8+i9v6IJbAGrs89ZahD+E4S8+UFs5RzCtGduo=; b=k3b8nXUYck1+FAEJf1lARZA+GwowQTVpsvnY2YtEKXq4Tm2Y4McEscgz1Wt542E2Tu4prplwNRyurhTG1QPZvXzWppwK/9+cJHQTujua+HjS4rVpVAfI3FIaZKFwJO8Hh4U7iAkGfryCuiUm6JQCu5xz5NDyNldLQXNswGIuvA4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 13 Sep 2022 17:52:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: xen-devel , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross , Bertrand Marquis , Henry Wang , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: Licensing issues Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0086.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|DS7PR03MB5397:EE_ X-MS-Office365-Filtering-Correlation-Id: b327fde0-63fc-4e05-0a62-08da959ff482 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XDc5tb5heydSR4d4/2yRKPC4t/Hl4Mm1oYToIur79WVLVlaRX81pFie12oXgCqBJZGjvFfu2SomA6IpEReQLFnq+mY53zy11nkjc+Yg4wPp3W9s95uCsLVk0u15VNpSUWlKWe1+CTokBcN7hZS/YIzwNReCQGjKufhB2UxSpVRxjbvjh1s/TL1W0bRR3WWCvnVxTWbFRjYWYVyWPD19iQOhZjh22ZvqaXy0GHSBkD4D4lW1JP1KzRK9Eboj4i9htSwfgXKVRcZ1swlJ361Jzag94A9XXstEsZVLTdzlPsFjVNhgkT8o1bPQFVU8mPR4SagTPD3tkLiq+VEqJIYa/4IlSFqTjmwWIwCmSXINZEch6WKOiH1TO17A17UNATmEKRS5amp6nabNRGAawTkjeemfd3Ao9dSIkq1fIWiHsaDHP28pRzN6zv3aPJ13yPH9j6HGH8Gpz0VEv1mBfaJv7neRQGDt+PzhwfjF/jLGCE+8SP6iT2wEhlBFsOxio4NxpRcF+KSfL9IoLt8Ds7UoLlVLopAujnoLp5UoZ8W5s9aDM8zl22YXc97E6nk5ElpQ6h0qOUwVn1kppoodHuEE9FJykImYC+Cg91ntoqLklyXbUDnjHxKzgL19SKJB0znVAMOIwpXAl5GZHh83uN3O/AFhxy+fF1BsEGWDKJvHBGWwefzpK2WO775ibymiD3GRPfv9lg227aKBsZ6S1gU7gFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(451199015)(6636002)(3480700007)(6666004)(6862004)(54906003)(8936002)(5660300002)(66476007)(316002)(2906002)(26005)(8676002)(66556008)(38100700002)(478600001)(41300700001)(4326008)(7116003)(66946007)(6486002)(186003)(82960400001)(9686003)(85182001)(6506007)(6512007)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDZ0eThnQk1EUU1ENVovWW5GYUJkS2kycDhSYW5IdlB4YWpGaW8xcnMrUVhR?= =?utf-8?B?bHZLWnBCbFdqcEJKZStkSEtWY0lHaThTWllacG5oY1ZTTkx1cHY5OXlrdFRC?= =?utf-8?B?UHI0RkRNV3JwYUtndkp6T25tVS9sK0l5WmM0aisxbmx5L01JQlZlemZqQTlM?= =?utf-8?B?NzBNcjRPRmgvNDd2YW42T0NUbVp0SllUczRtUWZjcFpLV0Z3dHJpZGMvK3Nn?= =?utf-8?B?MndFNU1veFNSVVZsZUc3RXlhd2hOOHAxWEIvTDBPV3g0YWNKUzE3eTZEK0Nn?= =?utf-8?B?RUtFdVAyVjFGRlpXaDcyUkpSd0U4M2lPRmlXTXhsVmdQL0NxNEtPR2VqWGpt?= =?utf-8?B?a0JaNE4yR0lrVnpBUXhYZ0FtbW5EOUFnVEVSaXJrSlhUWmd2VXk4Und6WTlu?= =?utf-8?B?cWY2MG5GSSs3aGdvMVJ0RGVVQ2hOZHU3djgrNkhkZzY5RFBKSVZNL3Zsa00v?= =?utf-8?B?Syt2MFJ4VDdBZXVxdlRBYjFadldpajZzQzV2cDhzSHd1VnBWZFZMTXFlNmJk?= =?utf-8?B?QXFhbWZQMkcrNGRxNFJpcXlENEsvMEN2MmNrYWZnQmtrZS9kd1hYazhEdzM5?= =?utf-8?B?ZHVFZjRZdU5XNlFKWWxPS3RrMmN4eVFuUnp4azNBUFVzUmpJdTNtYm1STjRx?= =?utf-8?B?UFVXcHowa0J2YjVyNlBhZHhTWGRDVlNwL0ZxN3VUNmJ4cnFKUU1zdUY2OHFa?= =?utf-8?B?b2k2MVZpT1BMVGNBdFg5MHJ1Z3VYY2lDM25JamRRd2xPeVBGTWUzT2JQaU9U?= =?utf-8?B?dXpCc3BYK1JaZ2QvdGE1THA0NmVZakNaa1lBSVFsdGp5MHB6M3MraTZWWFVX?= =?utf-8?B?VVFiUFpNcFViZFgxRWxLQ1RIL29YZUIzc1pwd1VtUjlnU1ZOYnVNSGFkMlF1?= =?utf-8?B?ZlUzUTV0TytjM3ZoOWVRbTZXeThXWnhEb1hNWUN1dzMweGdGTTFZSkpvVG5I?= =?utf-8?B?TnZwVmZoYWlreGpNSUphN2xJL1M4YTU1bDV6R0xEV2thdXNFYUtnZEhtL3k0?= =?utf-8?B?bFNYcHZ4UVBiaGZRZi95d1Z4YUozM3FKVzMxTmZNVFRhRHpQQ1cvWUpNT0Er?= =?utf-8?B?bnIvT0ppU1h1bXdjbjdzVlpORU0yWWVVMWRpZ0VzM2JqS0IrM25jaEJpREpx?= =?utf-8?B?dGRiYXp5elNvclNkWHFuUHBWM3l6YTlmd0FsNTVVRlJ4WjdHMHhQb3d4Qllw?= =?utf-8?B?bGVCMElTdDJaMit2cTVoQWNkU2hQMVoxSmlNL1psVTNmWFRWNFlyY3BrUnlK?= =?utf-8?B?UUN4RDBZK1VNNkVXc2JsZEtpVGx2L2JEckNPSFFZb0lxcVdaVFZFQ1RlSGhO?= =?utf-8?B?bExFQlFRRkNYd3NUOEt0NDl2OE13UnNrbExHUnI0UzJTWU5VODN6UmpBMDZu?= =?utf-8?B?bG5HTVR5WkZrY1FLSXB6dEdyNHJhS2ZMT1lXT21sRU9hMVhMTGhRN24rWE9r?= =?utf-8?B?UzVnbnlkMGt6SytxRi9YRk8yNVNET2I2bDJhcmVDaEFURnpoU2lqdHpqKy9C?= =?utf-8?B?ZkZ5U05pZWhUbVhzK004R3lMWkpvbmRRWEFpck9McHRtSEl6cllUQnl1OGtO?= =?utf-8?B?TitzR3BFL3lQRFZWTzhXb0gwRFp3djFJRjJ3Y0xmdmdGVDJOcmM0aFhxa29k?= =?utf-8?B?TTUwUjBvT3VZZ29vTEdCV3RBaXpqc2E4OS9ZZEJSUU1PdytleUlaSXZneVVZ?= =?utf-8?B?SEkvVVhNQnNNMXkzbzNWdlZCNEowWW5ubzhhWmlpTTFoZFJpOHNSMjNmTy9P?= =?utf-8?B?R2xjbVd2WEkxNUVpNHlHOHdOdkxKcXRYbnlxVTdvdHlCREdWUm10SjBycENs?= =?utf-8?B?bzhoclNwMHdNaGxYMVk1ODFUbnhuYXZZTHIvNCtuMVN2VjF4OWg4cXZoS0N5?= =?utf-8?B?OGl6bmNETzB1VWFVNWh3UklXZE9zc2pRRndnSE5YK0VqWmZocnRoQklhcmI0?= =?utf-8?B?dHFtd1hTOWsyVDY4OG0vNElVVDN1cC8yRWNqMnJEemdLWkV2M0ExN0lXWnJE?= =?utf-8?B?TnZJV0lwVFZQNk44VjEwc2EvcUJuU1VHbTRoL2U3d25sSC9JSnVLUm01dmFq?= =?utf-8?B?dkZoZXZEeTVqTXQ4bGJDZUVBNmZlZS9hS3B1MGZrK3VmV2I2N1RpamtQUG53?= =?utf-8?B?enVDdU5JZ01Gbk9jK3g3NGNtWjhaZnM4SzlhRnJyZVhLNlUzTENVbEJyMHM5?= =?utf-8?B?SGc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b327fde0-63fc-4e05-0a62-08da959ff482 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 15:52:26.3359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z4zdooCVem3AvvKI/cNjXwnLJ8dquWs6LAidrdCUhqODlDP7hLiauuebk8ROHZGT1JiJlZZc/C4puGEKH5Nf8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5397 On Fri, Jul 22, 2022 at 02:31:28PM +0000, Andrew Cooper wrote: > I've been cross-checking licensing details, and we have some problems. > > 1) We install xen/include/public/COPYING into /usr/include/xen/COPYING, > which is not common practice.  The installed file is mostly useless > because it discusses files based on their xen.git paths. > > 2) We actually use the MIT header for the public interface, but we don't > actually call it by it's common name anywhere. > > 3) The following files are missing the MIT header: > > /usr/include/xen/foreign/x86_32.h > /usr/include/xen/foreign/x86_64.h > /usr/include/xen/foreign/arm32.h > /usr/include/xen/foreign/arm64.h > /usr/include/xen/sys/gntalloc.h > /usr/include/xen/device_tree_defs.h > /usr/include/xen/errno.h > > Foreign are autogenerated from headers with MIT licences, so that's an > easy fix. > > errno.h was an oversight when we added it.  There's no problem fixing > it, as it is covered by multiple statements elsewhere in the tree. > > device_tree_defs.h is problematic.  It came into existence in c/s > 1c898a9fec7e4 when some LGPL code was moved out of libxl, and some GPL > code was copied out of Xen.  So there's currently an GPL+LGPL vs MIT > licensing violation. > > I have not looked through history, but it's likely that the copyright is > covered by individuals/companies who are still active members of Xen, > and I don't anticipate any problem getting it formally relicensed (it's > just a few constants), but this does need fixing. > > sys/gntalloc.h is more complicated.  It's stated as public domain which > is fine for our purposes, but inconsistent with everything else, and we > need to adjust the various files we've got which state that the full > public API is MIT. > > But it does raise a different bug.  Why do we have random linux headers > committed in the tree, used by some userspace libraries? I would guess this is because in the past (pre Linux pvops kernels) we wanted distros to be able to build Xen packages on boxes that did not run Xen patched kernels, and hence didn't have the user-space headers, that's why we had to add them to xen.git. I added the FreeBSD ones myself, but I did wonder whether it was required or not. I will see about removing the FreeBSD ones and using the ones in the system. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 16:05:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 16:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406491.648886 (Exim 4.92) (envelope-from ) id 1oY8Pp-00030a-1P; Tue, 13 Sep 2022 16:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406491.648886; Tue, 13 Sep 2022 16:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8Po-00030T-TU; Tue, 13 Sep 2022 16:05:36 +0000 Received: by outflank-mailman (input) for mailman id 406491; Tue, 13 Sep 2022 16:05:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8Pn-00030N-FS for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 16:05:35 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e5bd81dd-337d-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 18:05:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8016.eurprd04.prod.outlook.com (2603:10a6:102:cb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 16:05:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 16:05:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5bd81dd-337d-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXHbWun0SNX/d0TasIRlMI209ilhKtKMWOdB8yAoQw3IJaLCbUzBDaSNv2k0hlsNtVBl6StHm7kh1frCDVMbGLUUivc6vNMDCaNmCW2IstBWbQlsylXRbRz9lO49X6gDuYqTvkGMu0ai3QLqQdHhvTP/0pXEX9mvZKQub4G0S5I+P2d2EBlz/cA3W37Ue4GTaeFKxK39TdpoqMrM0JI3AIPdGRzyZHBRLeaM3JE+ZNv0sApbyKFHYropXC31eYr1sAptabs9edoSJO0bpznw/sUj2zCMgN0au3XTb7U4kOSs666oPYKB6zIrEccq4zwyFTamWlKDTlcrU7mUCfcm2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vj1hov6fb5jl/tl44YCiMk4xrRK/PezhTGj9DusRxbI=; b=k/Df3TzgK6QZpGTvCvCiIjVjl5/kWX8uqUFKYQqFULtc+Hh627ORCL6AoMWK3K95wwZ+lhN8X14z01N2CtlDMXy5FAF4vPjmyM/w618QIceorP6+0EOop9VsDS9oZN+O7WcnAYp1KKEqcfGQMJIrEQM3lLWeFQLT0919pOhFzBc7N8qYJcr11gg2a5Tn+6RsfFDqEylJLm07VfPfcxoHeXljiMchBIFoe2L9NdRsFctMJxvohHcpx55yVt5TcJaqzCS6NxxolRQaRnh3EN6W8wSjz/02+yeHOFiJZrbcsouf4LnbTLIFa2LciqN0U+bbu6QTrcFTB5KeI542fE/Sgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vj1hov6fb5jl/tl44YCiMk4xrRK/PezhTGj9DusRxbI=; b=24+JhpxwPxLy7dJdw8XqqQXAnkuGVs2i8vaev6zC0aoRti0GnfSvxDQZ/NVOYABYPjf5p76wW8Gr8ezO4Fk857t6dUMGpBSvnvqQFQQahf5epLt3Ora5jdl8uXa0fbih0rwhtSluJ/xHSvGp/bAZd2ommOQ9VRrXO7AKON5sRXhWf/0NFFnjmqpp4XYjZI8wodCRo8FMpHW5sPJw3XDy+uXlffhG1zCNO3ibk5SuHvFBIg6R9G/yZDhMSlJ0m8tbd/VQX8VEn3T9yHqv5ZwCzacM1dgNngw61IZzvPsk+HFzQ1vk/Glf9Yg0wbhAsDjuz/pRRUnFTokYX5L3vsgNlA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e1bad56-b239-c252-1b45-aae26499cc77@suse.com> Date: Tue, 13 Sep 2022 18:05:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] x86/PV: issue branch prediction barrier when switching 64-bit guest to kernel mode Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8016:EE_ X-MS-Office365-Filtering-Correlation-Id: 15723f8a-98c7-4a7e-3adb-08da95a1c8d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8UU7XjAaiDc0n+GaD7LlgIGqxEjoDqClpyxu49U0NufpZk+uLQjdy5k5uZIC1fQUUnlH/cqw+YGKvIAFwDUbX1rjTv3hMsn7foBp+n1635spGfG5pEgDS/aJjPinNo8wzEQAZGC4bbWrUJ53Rh/OS8WNZzl0O9cpq++nKI6c7qJ5a0cvo7OFwVV81DZhelqqusF+BpWv8l8iiA289wGaABh0blzwCcPYKX0ZNADxnVhLGCpL+F18p/EKj+0Y1vx9qNYf7qU6B2/MbDqyUQvLrBRBOdF+fMmOFKU2wUP3yciXiK+pJdaRWBhmxDgNusPUbs3IuV7XU/Z5PEF10WUHvw+b1ctr58TerGbACgZ6L+2IPNcmV4h1OmDcvMNCQOHXCxC+c8LqD/5wM9W31U+HAQ/5v8sLefJHWlieQPKFQFAX29AA+pXEgVdbvgMHpK4VAJLHLYJEAE7yYfRDRcO8pBbVb9qfNJ4A2AhmhEuIMXeMiByntLt3kfN3SPobLaLRMWIotsssSdlbxdl/MX3axrjyYVGXDmn+8fj8tJxVBOo/SDUA8y1lFLRsUlvsHBLUUcz1dsXf82Mmg2CRlz9Kyjf72ixSvbXJY3PQmyQOMs8sdxv/3/Z/C9wIfkLQRRZjDUsOlz2DBWzic5DFwHdGv3FhetGhnOvjauuuyhPD3Jxvu5PmGh6lvn1Who1dIcwXP3C02icnNdEL1qdWxqszuhsLIyIs+j39tzSAjS4n0CGuANdSxWZfffzGBZF/dvBED5+ETHCNbjmo7f3mbwVczggRnyMEm7JU5hC2UetN/Zg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199015)(6486002)(186003)(2616005)(8676002)(54906003)(6916009)(5660300002)(53546011)(4326008)(86362001)(66556008)(66946007)(6506007)(31696002)(66476007)(6512007)(8936002)(38100700002)(478600001)(2906002)(316002)(36756003)(41300700001)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmJETnhoK1hhNkdMN0lHWlBZZUZhY2NNdEVrTzhnak5BZEp4dFIyM3dZNCsy?= =?utf-8?B?YkNpck9RWWlIUHdhSmgySUJtNEdpdFZwN0VBYlhvL1BLOGNaVE82cFRPanl6?= =?utf-8?B?ZXdXNXF6TzBOa2NQZUx4RUVoclVyeWtuMXgrUXcvZVF6M1hVdC9VNDZxTFpu?= =?utf-8?B?MzBiRmUvSzJ5amhTU1Z2WTRzUlBMK244UndoNVdoczhxNUJZQjc0b0xEUzFt?= =?utf-8?B?WjBGVncybkVJbE9QeVBpZEtSK3A3WFFXakN1QnhjS3hPS0FKeVlYOWRCVitR?= =?utf-8?B?MUVUUE84SzR2Mkk1WlAzQUFyWkdxSFRWRXRyNVAwYWMra0dnVTBuUmQxd3M2?= =?utf-8?B?eWpqT2FSeGVDc0tWMm0vTCtMNURhZzRvR2FmQ0pGWGRMckxKdjh4aVVsMHpv?= =?utf-8?B?bGM4NzVlMGpmWjFTTXdQdCtKUHVWcDc5VjVCbjRQalpCOVZ2RFNyWVF0TVBa?= =?utf-8?B?SWVWeWI4VS9VUURpdzRmbk1xbmdVTk5uRTlWOU5LMVVoU1VQb0tRM1RRT3hm?= =?utf-8?B?bXRoV3V2NnFBUm1HbWd0cVc4OGladHdEWENJdmVGYVQweTJvb3NCVUdFd2Ra?= =?utf-8?B?T3lZNmNMZTFCelkza2w2UHZTVjNnRWxEYjZuOWMwSmgxVkQxSmFkVXJmdnJR?= =?utf-8?B?OUdjcmZLMG92citlalJ5czRSQVFtWEhidlZmTmdueElWQ2tIcTRnZGlZQ1dj?= =?utf-8?B?Qmgzb2lOT05kODg5ZytFc01Qd2RYdVBnTC81Y2R4ajBqV0JBeExPaXYxb0tZ?= =?utf-8?B?M1FreDZpVGhJM1orYlVjWHhVSmR3VnBOckY3bXpGdFloUitGQ09CbHlFYlM1?= =?utf-8?B?akpYVDJ1S01WaUVxSEE5eHcyWEFYWmFEaFZzQTBuNUN3QUJjY1FLTDZSQmhz?= =?utf-8?B?dGJYcWowOFlaN3NUdWlaRFBTZld3YWRSZkxnWWZIZ0c0em1mTWdpYkdHa2Iv?= =?utf-8?B?QTlmakNLQ1ExU2lubnQycm9KOXM3cno1b0QvSWlscEVQSzZpb29GenNZWWpu?= =?utf-8?B?cHo3NEt2a1RZZXh0TTNNcXlLbjVrL0N4amhkcnFMRUMwMnhGTDBHeXo3MURG?= =?utf-8?B?ZGFySVk5Nmd2TGtVQVRzSGNMdWZ1M1VRSGZyUVR5WDQyYVNuY0k1OTREYlBK?= =?utf-8?B?Y0ZEOXlHeUMvcS9xN1I4VllsOWZWUVl0RjRnMmFENEwwWjJNRnU0dEVTYjVX?= =?utf-8?B?blpoZWg2cjZOM1BXOVJTV3JSTU0vMWdaN3NBUm82Y1pTTXFWd0t6YkhBTHVj?= =?utf-8?B?VEVaMmVjNlBHWUtWaE5pTjlETmwrMlNCcHRWdDFBU0VXM2dJY0NET3JpQ0FX?= =?utf-8?B?VkN3am5RSDByNTVIOUZaL2tkRVJ0Q0dweG9PQkc1cktUSFJwbGJtVGhyL2Rm?= =?utf-8?B?SDRGdUhBZTYwZkcvZlVxSlRIM085ZVY3NUUvbi9hajg4S0Z3TSsrL3RmSXBq?= =?utf-8?B?UjN6VGdrN0J1UGVZYXlkY1ZMZXZrN1g0ZjE2UDBOMERGb1gvQ2ExM2xMOHJJ?= =?utf-8?B?RWxQSGEwQXlhYVkrRzhuRmdGYnlhRXAxM0lkOHcwM0wvcExoQ1ByWXNMcDZP?= =?utf-8?B?TTZlOU1DZlErd0NWSG1jd2dSaDNxcXlCSHJCd2R1S1RXNzFvek9aYmJlNFBl?= =?utf-8?B?ODBOVURrdkpnWDVoQUpWL1JETTNaQVVsZkU0WW9JMjF4ek50T3g2N1ZQaVZB?= =?utf-8?B?K3h6UUQ5emNzZC9QMHJsZHlXNlFCL3NyVmFOQWpSa1RtNzBsUFhqSE13aCtx?= =?utf-8?B?Q2N0RnVmVkR0YWh5eXhwZU9vTzVFVVorSDRPK2tmbHdUY2RQaDc5Y3pxaEZV?= =?utf-8?B?SFF5ZG5ITTN6V2NFT1hMTFVDczVHUG8vWnVxSnNMY0NzYzBxUS9CcUVjdzdZ?= =?utf-8?B?VUorWkdkKzZKbnNjWnRybkhlcFI1cnM5VWhJSjQ1eGZObGNadHJoeVJIdlJl?= =?utf-8?B?M1VDbUp4ZU5pL3ZBaHlBT0NCdFR5Nm9tcldPYXUwVHZBOGRWSW80TWlwYVo0?= =?utf-8?B?b3BJZFpuNU5GSWtZTjh3a214WDZ0blJjdXlVWXNqbFIxTUxvMXlhUW11dTJ3?= =?utf-8?B?U2ZHUVlXK3ZnMjN0NUlucStoVDlhOEMyODhpaXowenZOZURpK21CWktDUGc1?= =?utf-8?Q?ljCcwM+DXDhPkOdKpO1A35kYZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15723f8a-98c7-4a7e-3adb-08da95a1c8d4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 16:05:31.8909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fcJZQlBTaq9Dm9AZVLHYSM7aLJgWW0SFS8eHj1OvBRWOLXZWjmWCaPS8PwoKMeeubMRh+eXm4KSrT3WsdwBeWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8016 On 13.09.2022 17:41, Roger Pau Monné wrote: > On Tue, Jul 19, 2022 at 02:55:17PM +0200, Jan Beulich wrote: >> Since both kernel and user mode run in ring 3, they run in the same >> "predictor mode". While the kernel could take care of this itself, doing >> so would be yet another item distinguishing PV from native. Additionally >> we're in a much better position to issue the barrier command, and we can >> save a #GP (for privileged instruction emulation) this way. >> >> To allow to recover performance, introduce a new VM assist allowing the guest >> kernel to suppress this barrier. >> >> Signed-off-by: Jan Beulich >> --- >> v2: Leverage entry-IBPB. Add VM assist. Re-base. >> --- >> I'm not entirely happy with re-using opt_ibpb_ctxt_switch here (it's a >> mode switch after all, but v1 used opt_ibpb here), but it also didn't >> seem very reasonable to introduce yet another command line option. The >> only feasible alternative I would see is to check the CPUID bits directly. > > Likely needs a mention in xen-command-line.md that the `ibpb` option > also controls whether a barrier is executed by Xen in PV vCPU context > switches from user-space to kernel. The current text only mentions > vCPU context switches. Andrew and I actually discussed this perhaps better having a separate control. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 13 16:12:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 16:12:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406498.648897 (Exim 4.92) (envelope-from ) id 1oY8W6-0004U2-MV; Tue, 13 Sep 2022 16:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406498.648897; Tue, 13 Sep 2022 16:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8W6-0004Tv-JB; Tue, 13 Sep 2022 16:12:06 +0000 Received: by outflank-mailman (input) for mailman id 406498; Tue, 13 Sep 2022 16:12:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8W5-0004Tl-5c; Tue, 13 Sep 2022 16:12:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8W5-00018A-2G; Tue, 13 Sep 2022 16:12:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8W4-0003YK-F8; Tue, 13 Sep 2022 16:12:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY8W4-0003bk-EQ; Tue, 13 Sep 2022 16:12:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cQ7FvwIqbGpI90MLPNBPG3N+igwMFoQ3bk5qsqfZo0g=; b=m2Bny8nQoHImjzbbiFXPSVtChI LIQNENyX9EvyXGdC20ihhdHnr+RgJQXYE9MKBcL8zPl9qgEhQ1L8rm3fJnQu9fneIw6kQ5pMws3WJ AJ1ID5klJsD4GZldlSmrHROo8KtLBsY4xdvRPvZdm7H4XAes5hwn7SKJzB5SF+UYGVEI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173165: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e839a756012b6cad7a4eeb67b0598ac3f349f863 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Tue, 13 Sep 2022 16:12:04 +0000 flight 173165 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173165/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e839a756012b6cad7a4eeb67b0598ac3f349f863 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 40 days Failing since 172152 2022-08-05 04:01:26 Z 39 days 89 attempts Testing same since 173165 2022-09-13 05:47:23 Z 0 days 1 attempts ------------------------------------------------------------ 1776 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182637 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 16:15:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 16:15:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406505.648908 (Exim 4.92) (envelope-from ) id 1oY8Yt-00056L-4q; Tue, 13 Sep 2022 16:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406505.648908; Tue, 13 Sep 2022 16:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8Yt-00056E-26; Tue, 13 Sep 2022 16:14:59 +0000 Received: by outflank-mailman (input) for mailman id 406505; Tue, 13 Sep 2022 16:14:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8Yr-00054v-1c for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 16:14:57 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 338fc9b6-337f-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 18:14:55 +0200 (CEST) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Sep 2022 12:14:52 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MN2PR03MB5296.namprd03.prod.outlook.com (2603:10b6:208:1e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18; Tue, 13 Sep 2022 16:14:48 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 16:14:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 338fc9b6-337f-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663085695; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=V3lyu2VgTxIW0Wn9pWymZmCf8W4Dy61UscsxV+0vGrI=; b=fpO9EKu/i3m8MS1f+GPpfiHte0VsJUlDPwyH/TLJpQ1MtoV/ILM+mR4H r8FXJMKSITXKCZdVhbuoa1qL3TlCEuZVl22ii+C0bg0VUlDBmjgtBayVZ q4KcikRlpPX/RkHu/DmApIUkCsdUnmfYF6Ojd42fwCEMfvLkuO+p5cL7f k=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 80408336 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AOj245KvvikftC5fNe4GKGNA+6OfnOphVZjiD+?= =?us-ascii?q?MifNrXfiWXw2xPKv3m3sVAiTtXTOunIiNcj/pQV0QW/FX7A0JDBsTlM4+R2O?= =?us-ascii?q?9Dsiwl4E/wTnNjGyDgUMwsuPx56qaV/emZZ+Jjuyk2ZKT6bzz/j6veV7bI5W?= =?us-ascii?q?EyD2FjwfmxG3eKY5KwXd1czhiPNOzqlfXysJFMH7M0/JMNjXWMAaMKX+WDX5?= =?us-ascii?q?YIwXOxuf7LIwZwrGtqwnwqIX9ZRK9nLgYEOOGlXOFT2flsYxv2tXyvWBwJlA?= =?us-ascii?q?MZ8yK7cxggc0XVX6vqZ7qee/fnbrZ2MWpWfJHPIg62OS82At9wtWSUBvQ3WY?= =?us-ascii?q?lDqjsDCmx05D/9sySEWtfheoSWmR5pEfadPJ4LyHT0BLw5vEOHwK4h+hQTbE?= =?us-ascii?q?hwx7rF52QmdeHg7tx1j9G1SbyYjEyqC4QZ4f9apBHgabr7TvJ7aP8JSQ8S0g?= =?us-ascii?q?pkjfh2uOWee4A6ZAZ2JYFyleyb8dC5ikRcH/tUGoTZ49aJN0hBtselWUcz/f?= =?us-ascii?q?8hC8BzvUwW1lqWqDeQZIhMyGQhy9wpJzUmyMDvYf/D2xJLityLA8cJ0KvgIR?= =?us-ascii?q?6J4AbNvpSynzo1DQ6ZI1D71CQZ98mdhGd79xlpQkRaiNkQ46qj5fLMzH6iin?= =?us-ascii?q?aavc/FtTpV6CdTq/w5zfQlGIn1eIYH1LCi+dAj5phbsEvmeg2Xcly8MZfGus?= =?us-ascii?q?uIXwHfIuImaOqtTB/c77DKY+3WuBbxVxK4GYK99vcCNy95J7+qEPX7caiftd?= =?us-ascii?q?Qyc15l8XeW/JDzGskzyXXVJbwVw7w9I0Nu/A/crpURbKWOLtTXJocZFZEYcH?= =?us-ascii?q?7bkCF2rBNiFh7pohidY30gv+0UPm2FtosojIj+m1HNj19lbH30S9n8bRPi3q?= =?us-ascii?q?6vvR4xB6pxTqGyPO5MoLOPvFRoJn8FuHqQzp2idf56GVaCm1Us+9/6u/DL0N?= =?us-ascii?q?0JDXjYM6AYiqxFhe62VIqWeAOq5wkFA/KhP+dWZpU9BPfH1gPPnhgSk77jJv?= =?us-ascii?q?K5OXHN1aqE9jvAL5TkcTK+wiNVamiRs/dFAdTpgYb0Aqnzad/1Ei31rSgHhE?= =?us-ascii?q?fgmFGJfmhUPXbgL7dx+GbDndHlUjuvtpK43OfS80gEX/Ym9DPbfssAEMvKXR?= =?us-ascii?q?Y4NS/wAewo67xGVzbTI6ql4lmg7j9btngxqz3APe7bxW8InlhZKeG6k/Ea49?= =?us-ascii?q?a7zEhOK45duTGXvZs8JufcoZr73XskxV/980yeOkmpvPS9/OZczVWsq47zQD?= =?us-ascii?q?WMb3e2vj9eAazZyL9o/t6wexZvECImBVEUnNp964SsO9HV9tZmV4k1RJeV6W?= =?us-ascii?q?2aetdIVJyVAcXWKsMPCQFFYlDRSeJ8LPWGqBKCrYjjbUxwMd4jVQF4slfXfd?= =?us-ascii?q?3BoFQlwPpJv7r69IkxfEOtBZr5dRQtPZNKioIBQWd7+xfgwPQs+kuQJO/Spk?= =?us-ascii?q?XJBBYjN4Hkv9uzHP+JmflLoOKxl7BaN828CMAyPC+Nvn464pmWRbfeE6wQCh?= =?us-ascii?q?5+X2vi06nCgXmIgZ/7GLNIUh6EkXmdQII1/0+EFbEj4WRIDAXVs3L5pR3Sfc?= =?us-ascii?q?S55ND00I9eUBm7VhA2Ut0NFpDtCUf4vnsfRIXcv/SONEBIA6bBTZKVheC435?= =?us-ascii?q?ta77wNGSiXHZV7CcP9t9xw4H5OBYlpoEv4gbu2rEjgUycpSuCVeeukbYUsmO?= =?us-ascii?q?XhefkVL2RZJfCbDffF1dombtGJ7AScgro6e3WNfOaIeEAPPufdLjcT1Q92zm?= =?us-ascii?q?3vZF3huPT+D0BI1ySwXX6v2YqdHFQzuHIFKlY9AyWBQVFNahhBC+Zeo5afz6?= =?us-ascii?q?r7rm0Q9l+zU5IX/c326GhK1vPOKp/c0/0z7XPdbzvxQDXSTSbM9bKuudRLR8?= =?us-ascii?q?GWPJM5pwaavFxnusll8yz9Jbh48xJMfftyofBvzcqRnTIREW4M04X7VYIieI?= =?us-ascii?q?bJm4kpUDG+EJt0tszwTjzPTvkpenZv7v1ffqiEeAzhvQTc4YdieyOgw40rtO?= =?us-ascii?q?fqk51WVhtrj9D+CMMNQP+WHgsbOK/gm1y+7hHGqSHRx6CV4GWIWB/yzlOusW?= =?us-ascii?q?Qr1O/XGJsY4714wCTcRfhUMwsH3bZzliursNC6yumopR5Ow7KTSm/+tFwc7O?= =?us-ascii?q?t0zFnP4/oWnZOcG3u75rVH3d3ZsVpwsXB5FaiBsV2Jb4vdgB/JyUk7cdiErD?= =?us-ascii?q?AJLhuinWb2vSE7zKBKmBtPHdN2QZbe2QlUq3YGyLWahKmeTgrtyMJMeT5wVt?= =?us-ascii?q?ZPKXjZ7xjexYUXjR5HKT+CqCsoZgWgfg6vcjmLxWpxxBJXRgvPCMAZ+cfdD0?= =?us-ascii?q?kHCh1QY4qPZBY2m+ARYyF//EkdS0i93fQdX//59QHWzsGfGBGKal4jDhwlAe?= =?us-ascii?q?3+FS9ieacEG8yLOIJ+9a+dMV2GQZl1lO5p941B87HUapu3B6kFdcHe7oc8zZ?= =?us-ascii?q?59+9SGh0dY2Fodlixo4gr0e4w=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,313,1654574400"; d="scan'208";a="80408336" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LvzeQBFks8aF6QPWvZNc86Ubn6mpIWgmN0WnW7tqVXdyZueW+7W65I2VzX0LBee9k4h8SM8CZZKivVNX9LoFoZIXAU5fTrv96Rqynosev1qBOJg2Olxe61dXh2j/W8e6nELhb2c9IniP9gCCPyE7u8ivvxLNwF0zaGrE/13KsTLN+CSQPbBrrsu+z9eA8blFJeKxNLg5+rWkPjfb3wTRDVlSfinI7npJD9WYlDymgrvDF3eTkF/BRc5RHj9koqE8syZQU2RZDy4hbFrePNYpO75u7YRyfNsEHvWQ0UX5Zsg5TQijDE2x7OiPxgLYjbDjLibuwjSAJifjqDQ9fVTGGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lODT+xRofwDysBHrVHJIA4SslJBYbaTiJAewzTxPt/o=; b=V7jawNwLeitU1i5rXYxWcDm2MuIQkK6ttoBjgqlqbmM1bI60PIiv/xgaoMTkzPnbxdCE87K4SinkisRf/qJgU79V1osMNLjkeDPwNcZAajldYVnhB0dMcXq+MeWQ3dE9kMFAYlnVagV/o8BgKJubmbIfehxA/+wnv400qkQTw5iEIxR/X1N4wVzQpnqPgYQdy3xYyJNNgyRysImiFgIBmZ0FXA/+OqcUU+qFAkj6ueSkmUhyiidwSFVHBsCQNFVk/lvwM/HtL68cJde/vj3xUYCXQVXGERifTzjf0DnECanEXZ/ZohyT19dCOjFbXXqGZJB0snRH4Jf8F4f4jleHSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lODT+xRofwDysBHrVHJIA4SslJBYbaTiJAewzTxPt/o=; b=ZWRcdfzyFthdYn1xAh8IqmRG6CjihIBotAWM6frbwPqXpVZGKIfHralrj7+1zTd1cW9ZjVnBpBWl5RZfD08s9aF+CDttgh3f5ygcht5mrH7eUzVBXBDOqLq1Gjuh2FBepVUlShmzffroc226QGy1uTOiDaXY32Uxc50Ye1g2/eA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 13 Sep 2022 18:14:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH v2] x86/PV: issue branch prediction barrier when switching 64-bit guest to kernel mode Message-ID: References: <7e1bad56-b239-c252-1b45-aae26499cc77@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e1bad56-b239-c252-1b45-aae26499cc77@suse.com> X-ClientProxiedBy: MR1P264CA0178.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:58::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|MN2PR03MB5296:EE_ X-MS-Office365-Filtering-Correlation-Id: fa95b72a-6dfa-4e9d-1fd8-08da95a31488 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GSeAHjSf533IlZS2FMK58I/9Hp/nQ2q1cNsDDMNPXol/VVsnLvcMuxfvf2RvA84EJyi/nvQjT9KYygmW174uhPUAlFkuFScZNnSDZlBYZ7/JGqF7+7sFqN97sxBArgke4bL84qM/4H1xVvM0RKdJkDH2OoyRcde3Q4aRk3Yh16iU0gcuJa7FhviX3LYobjPoWSuCjLrTMQ11OUT1XshlloSJzuIwOoc7mPWhTUAvaoSteDkettroPVJOasHiJguQADIpy0Y8/HGOyPgS555HshSvwriqGUA3te1fsnBKDS6/tHPBvz2meSZsHttiUyMpiO3ImVQmAgcvInt8WmhRwIRP4/+5BATDWTBktR/4mzL+mXNe2XCZGX0Hq1Es7bO87Ri+A1lNvIpZj6sHqTTB3nJFN5HMAYawBSQihkha3l07B2L+yQJ/16XsFZ/YpPB4L7tgXeK9K0G1qVV2AB4qiMxYj2Qm9R4f5Eaqi4hK/2jk3+eYMSlc3jZenfLXRciYUmrkoyGPzYT8fhDrUgKWoQSOUp9eTYddAvrW2DuBr8R0U91W2sGqKbhgjWYm7A11Xi7de2NiYiHBZDluRvOiiCI0mb9zo8xQ8hIGU1Z7fV5IXFGO9P0dGguu10D1Q1rH7n3n/ImxvtrxHuEdJCgtXqR+oSD0IhwBP2HbVY1k2V3TLood2OvMbd5Yi0KeQEYQFPQAC9cnqM0JHQTtJWIubA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(451199015)(478600001)(66946007)(41300700001)(9686003)(85182001)(26005)(4326008)(53546011)(2906002)(86362001)(186003)(6512007)(6666004)(66476007)(6506007)(8676002)(6486002)(54906003)(6916009)(316002)(82960400001)(66556008)(8936002)(38100700002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUdqYXJSV3pRZUZqdkRYZzFzWG95bTFyK1RkYmZVb1hFcit1ZE16cHJXakJi?= =?utf-8?B?cytjWitBc1NYL3ZTTzJxSUU1S1A1c2M1NkZKcHpiSkpycEhoQTBxSVFoa1Zl?= =?utf-8?B?aUtsR2RpUStuMk9YQTN6aWxzaHZXNUdubXZxcFRRYnh2ZG9BdGdlUWx2QVlD?= =?utf-8?B?SVJQYlQzQkZTZVhydzBQb0kvYytzNzczTjgxSlBFYXdES0x5ckdaUU9tS2xx?= =?utf-8?B?eU5sTzRUOGVLd2tHZXhSQTMvVHd4R3pibTJMNzZWM1BHd2tEcFNQZHZWS244?= =?utf-8?B?djRvdGdqQ3BRZlFUWVdJb2JRZFdLQy94Q08zWGIybEdsampNNHZNeHplMzlD?= =?utf-8?B?bURBa285cTlwdTUxTUR6OWpqMTA4SVdSZHc4S3RmSHg0Z29tSyszWmpSTVFF?= =?utf-8?B?WVlUMFVLU2c2a1F1aXJCcHcxR3lPR1BYY0doME0ycU5wdXlWNnVoajB2ZWtJ?= =?utf-8?B?VHkvdnRXUzlmSktCc3pGSjdpVFlwaGFOVTlScVVueWxZcm8vbkhJK1AwdHE5?= =?utf-8?B?WGRPWjZnNjc1V252M0FWYXBNa3poMXk0WVBXM3kwTjBabVZwZDRxZTI5TWk1?= =?utf-8?B?WDZ1Z3JWYk5malhtZURvZlBYY1BGNDhCTEZUeG1rcnRYZEVpY2FVa3lCSnYw?= =?utf-8?B?U2tIdkxYM0J0dXZZTkRGQWFGRlFxT2ZtWHZtdXN2N0pvUGYxTTBFcnN3Q015?= =?utf-8?B?UmRhcHdqcHFLWENxd29HVVFoc0d1U2NRQTVPVm5zWWtMMkxWUlhjUUVZL0xN?= =?utf-8?B?UzhyUncvWTgxcHo3RlJLTVNCeXRzR1hCaGN2RGhYajgrbDRvcFZqbUxhcDlY?= =?utf-8?B?YWxubjJhZ2RhbDRpRUJqM3YzNU44QnNURDc4YnlJdUZmYUhTZVMrVW84dmVC?= =?utf-8?B?bHNYUkVJV1dDMFpsSXluNURPVjZpZ2Q5dnYzQ08rUDNYOE9kVzNaM1RpVlBJ?= =?utf-8?B?bjBQRXQycUViNndzejdxbEt4SGxnaGpLL2cvTXRPdDJoenBpMDVab1VnZy9i?= =?utf-8?B?REFwRCt4cEdaWExuZjZyS3BxUVljYWk3TFBhYVdyMmtEcWE1TzJLdUIzUlAw?= =?utf-8?B?L0REcW9pUWdJTjgza0txR2o2WCtnWEpqakdvN0w1cDVaNUVYa1czN1g0cTVL?= =?utf-8?B?aWdYTW1Sb084K2s5T3M5VThDbm5zS2VFVjVBWWVVVkpUNUk0OGIyamxybmhM?= =?utf-8?B?Y0dRTy92MmNlTXYycHhzQ1VGRFkwTzdKMzd5SFE4S2tPT2toUCtFTTFIZ0NF?= =?utf-8?B?MmxMZzdoVGlXSWowemxXS1gzaHc4ck4xRnhpUWdMNzBCS0UwMlYwRmJDcE1i?= =?utf-8?B?SmpmQzBJa3BFRmxnTUVCWUpaRmJJZmhPbnVyR0JEU1Jza2NWYjFKT2dkUUtC?= =?utf-8?B?emN1U3FSclVwRG1aT3pGaGtGdUQydTd5a21JM1MyNGFXMVZJYU81Y3lid0pQ?= =?utf-8?B?UXM3VkU5SnRHMnA0MUJwdGQ5Tms3SGhyTUJJbTYybmVQbWV4LzdjZVl6NGtO?= =?utf-8?B?ZjlwVDlqd3RjRkt0NXBjSnlMV25GVHUrdzh1SGkzZ2dnYzIwbTVPczJsOWk2?= =?utf-8?B?V1V1Z2JjbHlmZStHL3NiOEs0bVR1Z25GRlFNdUJjWUJ4WXV5bTVCOHVYVlBF?= =?utf-8?B?dHRPd1k4bDBqRXhVVFR3QzNFTjVQUzMzdG93aGNkYlZBWExCaTVjc3NGczZQ?= =?utf-8?B?S0tsQ05wQ1BRKzNJRkx0UHN0aHhrOEZuZFlKd3VrYTVqd2xIUGxZajkrMzVy?= =?utf-8?B?UDZVenhLenNpRE4wL2lIRUxXYnl0K2hWWW4wZVgrMWFDeVk5S0ZpTkdHZWFw?= =?utf-8?B?cTE3V2tjQjNJVGxYL3ZXT3pJSU1icXM5MjBsczRkYVRKOHBmcjRrU2c2b3pw?= =?utf-8?B?T1IwMWVmd01jM25tQmNhUHJaQ01Yb0NMb1lvcTV3UnFVUFYyajZrN0VNbUsy?= =?utf-8?B?ZHhJdkQyL2MxY2YxV2M2cS9zTmZWd2hRVzcwSFl1SzhweXpVNjJjN25qWTNK?= =?utf-8?B?MHF1ZUVTdGNrT3dTQWlYcXpseGRmRnNtd2JPL1NkaUszU1JleFAxTU0yNzN2?= =?utf-8?B?bFFWNXpBbGU1R0lGUTFpckxqcmYrNlFXYnc0VlRnczRMc2E3cW14cTdzY0dr?= =?utf-8?B?YW50SzlPc3lBUldQYzJ5MTNhZ2JQWUFpMnBoZ001d2Y2eU5XUXdvU0JYWis4?= =?utf-8?B?aHc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa95b72a-6dfa-4e9d-1fd8-08da95a31488 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 16:14:48.6000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fCAlnYHkqUh+2Ch+MJzccRcfjltdWl0WLyIkqkNRG1CkwmOMzeOGF2iISJ98SQYh8a7Yxb/a4/G8JB8z9NpcGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5296 On Tue, Sep 13, 2022 at 06:05:30PM +0200, Jan Beulich wrote: > On 13.09.2022 17:41, Roger Pau Monné wrote: > > On Tue, Jul 19, 2022 at 02:55:17PM +0200, Jan Beulich wrote: > >> Since both kernel and user mode run in ring 3, they run in the same > >> "predictor mode". While the kernel could take care of this itself, doing > >> so would be yet another item distinguishing PV from native. Additionally > >> we're in a much better position to issue the barrier command, and we can > >> save a #GP (for privileged instruction emulation) this way. > >> > >> To allow to recover performance, introduce a new VM assist allowing the guest > >> kernel to suppress this barrier. > >> > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Leverage entry-IBPB. Add VM assist. Re-base. > >> --- > >> I'm not entirely happy with re-using opt_ibpb_ctxt_switch here (it's a > >> mode switch after all, but v1 used opt_ibpb here), but it also didn't > >> seem very reasonable to introduce yet another command line option. The > >> only feasible alternative I would see is to check the CPUID bits directly. > > > > Likely needs a mention in xen-command-line.md that the `ibpb` option > > also controls whether a barrier is executed by Xen in PV vCPU context > > switches from user-space to kernel. The current text only mentions > > vCPU context switches. > > Andrew and I actually discussed this perhaps better having a separate > control. OK, didn't know there was some feedback here already. A separate control would indeed be clearer. I guess a new patch will appear then? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 13 16:33:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 16:33:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406518.648919 (Exim 4.92) (envelope-from ) id 1oY8qe-0007nC-PR; Tue, 13 Sep 2022 16:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406518.648919; Tue, 13 Sep 2022 16:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8qe-0007n5-Mm; Tue, 13 Sep 2022 16:33:20 +0000 Received: by outflank-mailman (input) for mailman id 406518; Tue, 13 Sep 2022 16:33:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8qe-0007mv-25; Tue, 13 Sep 2022 16:33:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8qe-0001Tv-0W; Tue, 13 Sep 2022 16:33:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY8qd-0004sn-LW; Tue, 13 Sep 2022 16:33:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oY8qd-0005wn-L2; Tue, 13 Sep 2022 16:33:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=37YJjJ8L4pvaysrKCQY4EpmEIFBHaAxVsbb0WX1XEg0=; b=CteqU9cBS+uBtNkdrDf42qKBxS KQ567TdcglMDJrB53+Q+pBPS1gqcMmfP4WOGzXcmZvl7ujIKRgy0U2b9A4u0tE4EGFh/FtYYDzAYh VhqBYsYPWRszODm5LIvs8L3HeBIV4lFpdMnBUq7W/fxgBWxp+ZpKq14vSOXDQR6KflL8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173175: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=db7afaee91423e988df3160624d04c3c534f294d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 13 Sep 2022 16:33:19 +0000 flight 173175 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173175/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf db7afaee91423e988df3160624d04c3c534f294d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 40 days Failing since 172151 2022-08-05 02:40:28 Z 39 days 302 attempts Testing same since 173166 2022-09-13 08:46:34 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2485 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 17:22:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 17:22:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406575.648965 (Exim 4.92) (envelope-from ) id 1oY9bu-0006zh-8p; Tue, 13 Sep 2022 17:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406575.648965; Tue, 13 Sep 2022 17:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY9bu-0006za-66; Tue, 13 Sep 2022 17:22:10 +0000 Received: by outflank-mailman (input) for mailman id 406575; Tue, 13 Sep 2022 17:22:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oY9bt-0006zQ-HJ for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 17:22:09 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 979ab941-3388-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 19:22:07 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B039F5C00D8; Tue, 13 Sep 2022 13:22:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Sep 2022 13:22:06 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 13:22:06 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 979ab941-3388-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663089726; x= 1663176126; bh=DlmL/OSMUtEOYHeDmhrm4rZF3WDXziGijEEBzTnopZU=; b=c A5z9wG/FyBIeExzYRRJZrmYMZm1mWb5IJXpFfEmrDRagmfsH4qje+Uju3W08WgV/ s+3VTkeY1QwCb3+naeB6DNffMx41wHsFitrRhDasSrdLg17eCtrdW789yatu02d9 q+jBZ2pDrVKcqpz2wzjJjC7fu7lyM0gSOFMiL7n3/n/c/mgcRQKqPpZZp1nQXWz1 t30R7PGxvj3Zb/whhjVI36tLM2GayOyrlfQzDGGwiI2WIr0nDtd+C9P3w71jr55p nk5/vf0Ec898GdJs1P/zjftL3uUm3Oo7ftLwwo6h+JI7Gcz414N782YUn4BS8L04 lLfDwS6o4bBG3khPajhEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663089726; x=1663176126; bh=DlmL/OSMUtEOYHeDmhrm4rZF3WDX ziGijEEBzTnopZU=; b=ibsJYHcqBJGa+/J0ijL4OTa1QSTwpGRnhjlf8TmWIh1i +R0xwO+1j2gFcX6wHwUSczj1zLISn3azumcGXHCegNUGZdEIX9JIEFO81wUlXVzy ArGKOKuBU/OMIQeUyqCMLNEPGOwIhDdOjPirOTBUyGxyXgMo0DuymRlht2Bfugsv 3p8sy6bEszaiZWjHvQdR5+gZJIhLBa9ZHllLJFgdQkkZBDX9YyDLUbP/nYSSlW5G i25m0qoTNFzcqgUQpzOX9uzjItIEc8gTuzwEwE5nbO/rFLDP8zz98Z/c9Ol5bmQg Mv1fnYuggop93+7gN8tiMXRbhBBVtCDHxYt1m+INcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelfeejueekheekgeeitdegkeek leetvdfhuddufefgffehffehueevvdeileefhfenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 13 Sep 2022 13:22:01 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag Message-ID: References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zBcvDbfW76gylCHE" Content-Disposition: inline In-Reply-To: <037151d0-0920-5d99-9932-df044729c00a@suse.com> --zBcvDbfW76gylCHE Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Sep 2022 13:22:01 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: > On 13.09.2022 16:22, Demi Marie Obenour wrote: > > On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: > >> On 06/09/2022 10:52, Jan Beulich wrote: > >>> On 02.09.2022 04:05, Demi Marie Obenour wrote: > >>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set= in > >>>> a CPU register to enforce constant-time execution. Linux plans to s= et > >>>> this bit by default; Xen should do the same. See > >>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for detai= ls. > >>>> I recommend setting the bit unconditionally and ignoring guest attem= pts > >>>> to change it. > >>> I don't think we ought to set it by default; I can see reasons why ke= rnels > >>> may want to set it by default (providing a way to turn it off). In Xen > >>> what I think we need is exposure of the bit to be guest-controllable. > >> > >> We absolutely should not have it set by default.=C2=A0 It's a substant= ial > >> overhead for something that is only applicable to code which otherwise > >> crafted to be constant-time. > >=20 > > Either Xen needs to set the bit by default, or guests need to both know > > the bit needs to be set and be able set it. Otherwise code that *is* > > intended to be constant-time has no way to protect itself. > >=20 > >> As for why Xen doesn't enumerate/virtualise it, that's because > >> virtualising MSR_ARCH_CAPS for guests is still not working yet, so the > >> feature can't be enumerated yet even if we did support context switchi= ng it. > >=20 > > Intel and ARM64 guarantee that CPUs that do not enumerate this flag > > behave as if it is set unconditionally. >=20 > I'm not qualified to talk about the Arm side, but may I ask what you've > derived this statement from for Intel? The doc page referenced by the > link you did provide (still in context above) specifically further links > to a page listing instruction with data operand independent timing. All > other instructions, as I conclude, have variable timing unless the bit > in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same name) > is set. My understanding is that only instructions in the constant-time subset are ever guaranteed to be constant time. On architectures where DOITM is not enumerated, this guarantee is unconditional. On architectures where DOITM is enumerated, this guarantee only holds when DOITM is set. Therefore, it is critical that on CPUs that enumerate DOITM, Xen does one of the following: - Ensure that all vCPUs enumerate DOITM, and virtualize the DOITM MSR bit for use by guests. - Set DOITM by default. Since Xen does not support virtualizing MSR_ARCH_CAPS, vCPUs cannot enumerate DOITM. Therefore, the only secure option is to set DOITM by default, so that guests do not need to be aware of it. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --zBcvDbfW76gylCHE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMgvDsACgkQsoi1X/+c IsFeHA//aCAzL+FXK/IZ8CUyToJ5Kn7z8nhx1P0nYiCjUdZluGizysv4jcj+X199 PKry44GgneMsaKYpvjyXzsUquTjHffRPQlzTsOU1H/n2csDR6brczOk0zG/lWbnS el+iRk+X7jyHgkx8cGmXyRKgO5rlDbVksgA9W6X1JaYTEDhAtt3PiURT7EZ+wj73 3MEU9lsJE4pq1GvudtscSb9ImS0hPkf3xtA6CDnW1+RDZoetv//NxaMyosfO9Dj3 BwGThUoDyqVYQtUJAWSen+nyHd9A5Q6gqmV70bFqG5MZ6CG0dedUl+QMqZXailUH KNQpGmiTJwyuxpytdEVXJ+BA239c0Lafo/74+ZmKdRqEhfRrLTpg8jW2F1I+VYaB w+S7dSoL5DCISeBAaH6xLi75h5eKugwzl0yyichhabPGHd847E6G/eLZF9DERNip cZhedxzG3lzt9Pl2kGPwZicMsEYulOjXXjvnRTx8VFUFx7Sd8OdajaEdmJ0O0CAV qAKsuG57cccqxi2iyWgz1tlO2kIK1a1j1SXQ3KpUtY6sm/19Oz8NXvk9HO/n1KhW Ze2cM5pJCDcm7lgDuldAz27OKnMdwUXRDbzVEHuYT1GhxVqRSIG4Sg/UFcWHXxHe ow7UZYujSOQCRCpJffjZyZn//0FF7/Tyl3edFmZhDqq07CPJqr8= =U+YQ -----END PGP SIGNATURE----- --zBcvDbfW76gylCHE-- From xen-devel-bounces@lists.xenproject.org Tue Sep 13 19:15:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 19:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406611.648977 (Exim 4.92) (envelope-from ) id 1oYBNS-00030f-Ch; Tue, 13 Sep 2022 19:15:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406611.648977; Tue, 13 Sep 2022 19:15:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBNS-00030Y-A4; Tue, 13 Sep 2022 19:15:22 +0000 Received: by outflank-mailman (input) for mailman id 406611; Tue, 13 Sep 2022 19:15:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBNQ-00030S-IO for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 19:15:20 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6776086b-3398-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 21:15:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB030B80DB8; Tue, 13 Sep 2022 19:15:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDCFEC433D6; Tue, 13 Sep 2022 19:15:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6776086b-3398-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663096516; bh=NBiBu1NMVErzYb/9lyzCIu4nd7Bzz/L+vCxhP/NfWB8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CwRND+9LxZsnyx9MnzPPNFpcaKy4D/XYLVyEO3o0FM+3nynl+5hnRpx8nNRcDiOpD MjhUje+H5x7Bad5tTukC+JtrFws+ClkQmeKQ4gYh7eZds/pFI3GnrSXHrMIdvKiL1R sxwDnobxf0/cB6iZhRTEwS+wpaTV0HqggWXe+5/uiP/koK7VF0N7Wjh1zHeHbGzKal DVwisTI3WuHjseahEcwgvxS16kWwIzPLqfzkRvhvRKcpYkbtyabm9Tdk45chJcPEqy sDKw6Y58PpGGTttVUtHRXefPyFvjjJUfyBP6eajtzseHN8c+YO8dLoUKEUemfQGgly ERS8vK9dM3x8A== Date: Tue, 13 Sep 2022 12:15:14 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Ayan Kumar Halder , xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder 2/2] Add support for lopper to generate partial dts In-Reply-To: Message-ID: References: <20220912115934.19552-1-michal.orzel@amd.com> <20220912115934.19552-3-michal.orzel@amd.com> <276bd45d-7ab8-fc5d-a065-df6188b4f42f@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 12 Sep 2022, Michal Orzel wrote: > On 12/09/2022 18:41, Ayan Kumar Halder wrote: > > Hi Michal, > > > > On 12/09/2022 12:59, Michal Orzel wrote: > >> Currently ImageBuilder can compile and merge partial dts obtained from > >> a repository specified using PASSTHROUGH_DTS_REPO. With the recent > >> changes done in the lopper, we can use it to generate partial dts > >> automatically (to some extent as this is still an early support). > >> > >> Introduce LOPPER_PATH option to specify a path to a lopper.py script, > >> that if set, will invoke lopper to generate partial dts for the > >> passthrough devices specified in DOMU_PASSTHROUGH_PATHS. > >> > >> Introduce LOPPER_CMD option to specify custom command line arguments > >> (if needed) for lopper's extract assist. > >> > >> Example usage: > >> LOPPER_PATH="/home/user/lopper/lopper.py" > >> DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" > >> > >> Signed-off-by: Michal Orzel > >> --- > >> README.md | 22 ++++++++++++-- > >> scripts/common | 64 ++++++++++++++++++++++++++++++---------- > >> scripts/uboot-script-gen | 17 +++++++++-- > >> 3 files changed, 83 insertions(+), 20 deletions(-) > >> > >> diff --git a/README.md b/README.md > >> index da9ba788a3bf..aaee0939b589 100644 > >> --- a/README.md > >> +++ b/README.md > >> @@ -128,6 +128,19 @@ Where: > >> - DT_OVERLAY[number] specifies the path to the hosts device tree overlays > >> to be added at boot time in u-boot > >> > >> +- LOPPER_PATH specifies the path to lopper.py script. This is optional. > >> + However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] need > >> + to be specified. uboot-script-gen will invoke lopper to generate the partial > >> + device trees which have been specified in DOMU_PASSTHROUGH_PATHS[number]. > >> + This option is currently in experimental state as the corresponding lopper > >> + changes are still in an early support state. > >> + > >> +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. > >> + This is optional and only applicable when LOPPER_PATH is specified. Only to be > >> + used to specify which nodes to include (using -i ) and which > >> + nodes/properties to exclude (using -x ). If not set at all, the default > >> + one is used applicable for ZynqMP MPSoC boards. > > > > You are using some more arguments (besides -x and -i) :- > > > > --permissive -f > > -- extract -t > > -- extract-xen -t $node -o > These ones are fixed and do not differ depending on the type of device or board. > That is why LOPPER_CMD is used only to allow users to specify what can be required > to support a new device (usually not necessary) or a new board. > > > > > It will be good to have some explaination for these. See my comments below. > > > We don't seem to do it in general (see all the commands used by disk_image) so I think > we should only describe what is available to the user. Otherwise we would need to be > consistent and apply this rule to all the other places. My thinking is that Lopper documentation is best kept under the Lopper repository. ImageBuilder documentation should be under the ImageBuilder repository. In this case, I think Lopper might benefit from better docs on how to use extract-xen. extract-xen doesn't even seem to be described in README.md? I think it would be good to add at least a mention there, or another doc under lopper.git. Here in ImageBuilder I don't know if I would add anything. We could explain why we chose this set of Lopper command line options, but I think that if Lopper was well documented we wouldn't need to. So in conclusion: I am OK with no extra docs in this series but please have a look at lopper.git to see if we are missing anything there. Do you guys agree? From xen-devel-bounces@lists.xenproject.org Tue Sep 13 19:28:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 19:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406617.648988 (Exim 4.92) (envelope-from ) id 1oYBaY-0004ie-IT; Tue, 13 Sep 2022 19:28:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406617.648988; Tue, 13 Sep 2022 19:28:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBaY-0004iX-Fm; Tue, 13 Sep 2022 19:28:54 +0000 Received: by outflank-mailman (input) for mailman id 406617; Tue, 13 Sep 2022 19:28:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBaW-0004iR-Ad for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 19:28:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b3af72a-339a-11ed-9761-273f2230c3a0; Tue, 13 Sep 2022 21:28:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54C8E61552; Tue, 13 Sep 2022 19:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30C40C433C1; Tue, 13 Sep 2022 19:28:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b3af72a-339a-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663097328; bh=7Qy2pf6lStgBgnZ9B5Pnmqjsv8fmEWyK4UeTZVi+NT8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EJ4nkHB8oGkH9Gj/frfCojf2rFGjbFD/SvX5gwZiBh4F66ulR9TL4lHynLi91gHY+ M8TkGo6U6ykaZ6N3+amBvxwJK9yoN0tgJdkKYDSkjg0hzF6oaNCHewcItwILJ38dCp wBjbzG4Z8I91i1tVJMLg9nJFol1IpQfpyveTjAggbtkiogRHKPBjglOTibantofrZQ bvWG2cO1jEkwiU8gDvexcNFjz0gbiz7KaPIOvrV4m01tNBeJthsHmQf1vAFVZzQ1jH UW89T8JSVx8ApDyZAhWbaYYCrAcHVZE06JcELyK2PbWeazSD1+HAeIkfU7E959qIdk GMAJfzuAVEsnA== Date: Tue, 13 Sep 2022 12:28:47 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Ayan Kumar Halder , xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder 0/2] Use lopper to generate partial dts In-Reply-To: <81eee8c0-03e4-fa41-757d-ee749ebcbe07@amd.com> Message-ID: References: <20220912115934.19552-1-michal.orzel@amd.com> <64aadcab-5f41-6d2f-4dc9-39415016816a@amd.com> <81eee8c0-03e4-fa41-757d-ee749ebcbe07@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 13 Sep 2022, Michal Orzel wrote: > Hi Ayan, > > On 12/09/2022 18:27, Ayan Kumar Halder wrote: > > Hi Michal, > > > > On 12/09/2022 12:59, Michal Orzel wrote: > >> This patch series introduces support to generate automatically passthrough > >> device trees using lopper. This feature should be used with care as the > >> corresponding lopper changes are still in an early support state. Current > >> integration has been tested with several devices from ZynqMP ZCU102 board > >> e.g. serial, spi, ahci, mmc. > >> > >> When using this feature, make sure to use the latest lopper's master branch > >> status [1]. > > > > I am guessing that this is the first time the imagebuilder is using > > script from an external repo. There might always be a possibility that > > future changes to lopper (master branch) might not be backward > > compatible or might break something in imagebuilder. > > > > As such, will it make things better if lopper is included as a > > gitsubmodule for imagebuilder. This way a specific revision of lopper > > will be in sync with a specific revision of imagebuilder. > > > > Please let me know your thoughts. > > I think it could be beneficial in the future but not in the current state. > The reason why is that the lopper changes are in an early support state > (I try to highlight it on each occasion). This means that in the near > future we will be improving lopper extract assists to cover some corner cases. > Adding lopper as a submodule now, would result in a need of additional commits > for the ImageBuilder fetching new lopper changes each time we improve something > in lopper. I think we do not need such overhead at this stage. > > Also lopper's README states that "Internal interfaces are subject to change" > so we can assume that the interface given to the user will not change. Forward and backward compatibility is something we'll need to think about at some point. Personally I dislike git submodules and I would try to avoid using them unless strictly necessary. However, we could specify a commit-id or tag to use (the same way Yocto specifies component versions.) Given that it is still early stage for this feature, I think we could ignore the problem for now and come back to it in the future. Or we could change this patch series now to take as LOPPER_PATH input something like a SRC_URI in Yocto, which could be any of the following: git://some.host/somepath;branch=branchX,branchY;name=nameX,nameY https://some.host/somepath;branch=branchX,branchY;name=nameX,nameY file://local.path/to/file.txt If we did this, it would be more future proof and we could use the https:// URI by default with the "master" or "master-next" branch so that we would automatically get the latest updates. In the future we would specificy a stable branch instead (e.g. v0.2022.x). From xen-devel-bounces@lists.xenproject.org Tue Sep 13 19:32:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 19:32:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406623.648999 (Exim 4.92) (envelope-from ) id 1oYBe7-000686-27; Tue, 13 Sep 2022 19:32:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406623.648999; Tue, 13 Sep 2022 19:32:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBe6-00067z-VO; Tue, 13 Sep 2022 19:32:34 +0000 Received: by outflank-mailman (input) for mailman id 406623; Tue, 13 Sep 2022 19:32:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBe5-00067p-Ri; Tue, 13 Sep 2022 19:32:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBe5-0004WJ-LB; Tue, 13 Sep 2022 19:32:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBe5-0006Yy-91; Tue, 13 Sep 2022 19:32:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYBe5-0004n8-8M; Tue, 13 Sep 2022 19:32:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ig266dJQnCAfjDVzqvZRqAFlHXk3feXn8HbRGb4xfC8=; b=Fmr8MmhpnBO4kwdd+3Mdlxc0C2 8n/pNHbOOLoq7grL+g7+Cij8YxtOoGSTUAS7lL1Qg+5/Bh6cEbJ14QYUhGYTDWMUeGemdD5gACG4t 8NTKpd/CiTP8wgsZq3ECxRF2M/0XW0U+Qrx0JG+HRAK8sszaEVUSMR8E9UMIFM3ic3J8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173172: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-pvhv2-intel::broken:regression qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:capture-logs(26):broken:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Tue, 13 Sep 2022 19:32:33 +0000 flight 173172 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173172/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvhv2-intel broken build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-pvops 6 kernel-build fail in 173160 REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvhv2-intel 26 capture-logs(26) broken pass in 173160 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173160 pass in 173172 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 173160 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 173160 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 41 days Failing since 172148 2022-08-04 21:39:38 Z 39 days 90 attempts Testing same since 173060 2022-09-08 07:34:59 Z 5 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel broken test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-pvhv2-intel broken broken-step test-amd64-amd64-xl-pvhv2-intel capture-logs(26) Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 19:32:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 19:32:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406626.649009 (Exim 4.92) (envelope-from ) id 1oYBeK-0006Si-Do; Tue, 13 Sep 2022 19:32:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406626.649009; Tue, 13 Sep 2022 19:32:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBeK-0006SZ-B3; Tue, 13 Sep 2022 19:32:48 +0000 Received: by outflank-mailman (input) for mailman id 406626; Tue, 13 Sep 2022 19:32:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBeJ-0006S2-PZ for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 19:32:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d76e9931-339a-11ed-a31c-8f8a9ae3403f; Tue, 13 Sep 2022 21:32:46 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACEA561562; Tue, 13 Sep 2022 19:32:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 130F8C433C1; Tue, 13 Sep 2022 19:32:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d76e9931-339a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663097564; bh=JfYzEoIygfy8CKHnNNxXnJCm52O6HXARQ6jS9spBjk4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Mx7bW5LZL5m7fmKuO1fDfbm+O/5fpsP6mcUG54q++TyAX/H0YrxVq40X5GHhiaXjY YrTz1xYRmtOr+w5WM2BHAaCCvkrAFn7EoNvTTYVWv2DmbVyoE1qBp6LvFaK1axgcui qK91W0rQx3yLUPTcsiNynmJX1bJ/rIfDiiLdIZf+/9sPHv0GbcAraV5CJ6UysQ73uL yKbice9I+whCJeeIRHVBazp42GZ7X/v7qhTDjsKKOoG+vVsAwSf+zr/g72Cjza7gLS rnsNvW2EGXk3Mw13zhXvcm3+ynmk/+D/MQU9SFlHpevvqmvkhBs6BVmd44ogCsRXOx 7EYRO13Kb8sbA== Date: Tue, 13 Sep 2022 12:32:43 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder v2 2/2] Add support for lopper to generate partial dts In-Reply-To: <20220913120918.31162-3-michal.orzel@amd.com> Message-ID: References: <20220913120918.31162-1-michal.orzel@amd.com> <20220913120918.31162-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 13 Sep 2022, Michal Orzel wrote: > Currently ImageBuilder can compile and merge partial dts obtained from > a repository specified using PASSTHROUGH_DTS_REPO. With the recent > changes done in the lopper, we can use it to generate partial dts > automatically (to some extent as this is still an early support). > > Introduce LOPPER_PATH option to specify a path to a lopper.py script, > the main script in the Lopper repository, that if set, will invoke lopper > to generate partial dts for the passthrough devices specified in > DOMU_PASSTHROUGH_PATHS. > > Introduce LOPPER_CMD option to specify custom command line arguments > (if needed) for lopper's extract assist. > > Example usage: > LOPPER_PATH="/home/user/lopper/lopper.py" > DOMU_PASSTHROUGH_PATHS[0]="/axi/spi@ff0f0000 /axi/serial@ff010000" > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini Given the state of the release I would commit these two patches to a "master-next" branch to be merged into "master" later. But I'll wait before committing to hear your thoughrs on the SRC_URI suggestion in the other email. > --- > Changes in v2: > - improve documentation > - update commit msg > - use node=${devpath##*/} instead of file=${devpath##*/} > --- > README.md | 23 ++++++++++-- > scripts/common | 77 ++++++++++++++++++++++++++++++---------- > scripts/uboot-script-gen | 22 ++++++++++-- > 3 files changed, 100 insertions(+), 22 deletions(-) > > diff --git a/README.md b/README.md > index da9ba788a3bf..f4213d570033 100644 > --- a/README.md > +++ b/README.md > @@ -128,6 +128,20 @@ Where: > - DT_OVERLAY[number] specifies the path to the hosts device tree overlays > to be added at boot time in u-boot > > +- LOPPER_PATH specifies the path to lopper.py script, the main script in the > + Lopper repository (https://github.com/devicetree-org/lopper). This is > + optional. However, if this is specified, then DOMU_PASSTHROUGH_PATHS[number] > + needs to be specified. uboot-script-gen will invoke lopper to generate the > + partial device trees for devices which have been listed in > + DOMU_PASSTHROUGH_PATHS[number]. This option is currently in experimental state > + as the corresponding lopper changes are still in an early support state. > + > +- LOPPER_CMD specifies the command line arguments for lopper's extract assist. > + This is optional and only applicable when LOPPER_PATH is specified. Only to be > + used to specify which nodes to include (using -i ) and which > + nodes/properties to exclude (using -x ). If not set at all, the default > + one is used applicable for ZynqMP MPSoC boards. > + > - NUM_DOMUS specifies how many Dom0-less DomUs to load > > - DOMU_KERNEL[number] specifies the DomU kernel to use. > @@ -140,7 +154,7 @@ Where: > - DOMU_PASSTHROUGH_PATHS[number] specifies the passthrough devices ( > separated by spaces). It adds "xen,passthrough" to the corresponding > dtb nodes in xen device tree blob. > - This option is valid in the following two cases: > + This option is valid in the following cases: > > 1. When PASSTHROUGH_DTS_REPO is provided. > With this option, the partial device trees (corresponding to the > @@ -149,7 +163,12 @@ Where: > Note it assumes that the names of the partial device trees will match > to the names of the devices specified here. > > - 2. When DOMU_NOBOOT[number] is provided. In this case, it will only > + 2. When LOPPER_PATH is provided. > + With this option, the partial device trees (corresponding to the > + passthrough devices) are generated by the lopper and then compiled and merged > + by ImageBuilder to be used as DOMU[number] device tree blob. > + > + 3. When DOMU_NOBOOT[number] is provided. In this case, it will only > add "xen,passthrough" as mentioned before. > > - DOMU_PASSTHROUGH_DTB[number] specifies the passthrough device trees > diff --git a/scripts/common b/scripts/common > index ccad03d82b30..2dd98fb94d3e 100644 > --- a/scripts/common > +++ b/scripts/common > @@ -9,6 +9,9 @@ > # - NUM_DOMUS > # - DOMU_PASSTHROUGH_PATHS > # - DOMU_PASSTHROUGH_DTB > +# - LOPPER_PATH > +# - LOPPER_CMD > +# - DEVICE_TREE > > tmp_files=() > tmp_dirs=() > @@ -99,31 +102,41 @@ function compile_merge_partial_dts() > local tmp > local tmpdts > local file > + local node > local i > local j > > - if [[ "$repo" =~ .*@.*:.* ]] > + if test "$repo" > then > - tmp=`mktemp -d` > - tmp_dirs+=($tmp) > - > - echo "Cloning git repo \"$git_repo\"" > - git clone "$repo" $tmp > - if test $? -ne 0 > + # Partial dts will be obtained from PASSTHROUGH_DTS_REPO > + if [[ "$repo" =~ .*@.*:.* ]] > then > - echo "Error occurred while cloning \"$git_repo\"" > - return 1 > - fi > + tmp=`mktemp -d` > + tmp_dirs+=($tmp) > > - repo=$tmp > - fi > + echo "Cloning git repo \"$git_repo\"" > + git clone "$repo" $tmp > + if test $? -ne 0 > + then > + echo "Error occurred while cloning \"$git_repo\"" > + return 1 > + fi > > - if test -z "$dir" > - then > - dir="." > + repo=$tmp > + fi > + > + if test -z "$dir" > + then > + dir="." > + fi > + partial_dts_dir="$repo"/"$dir" > + else > + # Partial dts will be generated by the lopper > + tmp=`mktemp -d` > + tmp_dirs+=($tmp) > + partial_dts_dir="$tmp" > fi > > - partial_dts_dir="$repo"/"$dir" > i=0 > while test $i -lt $NUM_DOMUS > do > @@ -133,6 +146,34 @@ function compile_merge_partial_dts() > return 1 > fi > > + if test -z "$repo" > + then > + # Generate partial dts using lopper > + for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} > + do > + node=${devpath##*/} > + file="$partial_dts_dir"/"$node".dts > + > + # Execute lopper with the following assists: > + # - extract: used to take the target node, extract it from the > + # system device tree, chase the phandle references and place > + # it in a new extracted tree structure, > + # - extract-xen: used to perform Xen specific modifications > + # on the extracted tree structure e.g. adding "xen,path", > + # "xen,reg", interrupt-parent properties. > + # For additional information, please see the lopper's README > + # file as well as usage of the mentioned assists. > + $LOPPER_PATH --permissive -f $DEVICE_TREE \ > + -- extract -t $devpath $LOPPER_CMD \ > + -- extract-xen -t $node -o $file > + > + if test $? -ne 0 > + then > + return 1 > + fi > + done > + fi > + > sanity_check_partial_dts "${DOMU_PASSTHROUGH_PATHS[$i]}" "$partial_dts_dir" > if test $? -ne 0 > then > @@ -146,8 +187,8 @@ function compile_merge_partial_dts() > > for devpath in ${DOMU_PASSTHROUGH_PATHS[$i]} > do > - file=${devpath##*/} > - file="$partial_dts_dir"/"$file".dts > + node=${devpath##*/} > + file="$partial_dts_dir"/"$node".dts > > # All the subsequent dts files should not have dts version mentioned > if test $j -gt 1 > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 1f8ab5ffd193..b24dca2b7f7e 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -1138,10 +1138,28 @@ fi > # tftp or move the files to a partition > cd "$uboot_dir" > > -if test "$PASSTHROUGH_DTS_REPO" > +# If both PASSTHROUGH_DTS_REPO and LOPPER_PATH options are specified, > +# the former takes precedence because the partial device trees are already > +# created (probably tested), hence the reliability is higher than using lopper. > +if test "$PASSTHROUGH_DTS_REPO" || test "$LOPPER_PATH" > then > output_dir=`mktemp -d "partial-dtbs-XXX"` > - compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" > + if test "$PASSTHROUGH_DTS_REPO" > + then > + compile_merge_partial_dts $output_dir "$PASSTHROUGH_DTS_REPO" > + else > + if test -z "$LOPPER_CMD" > + then > + # Default for ZynqMP MPSoC. > + # The following command instructs lopper's extract assist to always > + # include zynqmp-firmware node (as it contains e.g. clock-controller > + # required by most of the devices) in the extracted tree structure > + # and to drop nodes/properties during the extraction process that > + # are not needed. > + LOPPER_CMD="-i zynqmp-firmware -x interrupt-controller -x pinctrl -x power-domains -x resets -x current-speed" > + fi > + compile_merge_partial_dts $output_dir > + fi > if test $? -ne 0 > then > # Remove the output dir holding the partial dtbs in case of any error > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Sep 13 19:35:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 19:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406641.649020 (Exim 4.92) (envelope-from ) id 1oYBgd-0007M2-T5; Tue, 13 Sep 2022 19:35:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406641.649020; Tue, 13 Sep 2022 19:35:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBgd-0007Lv-QN; Tue, 13 Sep 2022 19:35:11 +0000 Received: by outflank-mailman (input) for mailman id 406641; Tue, 13 Sep 2022 19:35:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBgc-0007Lj-U3; Tue, 13 Sep 2022 19:35:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBgc-0004Yv-TB; Tue, 13 Sep 2022 19:35:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYBgc-0006fs-EC; Tue, 13 Sep 2022 19:35:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYBgc-0006l3-Dk; Tue, 13 Sep 2022 19:35:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2OQbFgzZWKutGwwqVi2zQxsx5Qr4QUmlHUyRLDcfH6I=; b=fAR16uFTQ0aMmK3Ed6ORkGSwVH xonj8ZILPODAD3oh8Cv4cO4PdrLax9lnmR0QWJObSdyCUcJcVnRcY6oA66puXP+p2kNfMra8hUO48 mdqsQsO6uJuHvYpguosXiU5ok1sPuTI0K8odYmUPM2BNbWdVPgHt3Lt2wQxJ4b4IB6Kg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173177: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=db7afaee91423e988df3160624d04c3c534f294d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 13 Sep 2022 19:35:10 +0000 flight 173177 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173177/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf db7afaee91423e988df3160624d04c3c534f294d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 40 days Failing since 172151 2022-08-05 02:40:28 Z 39 days 303 attempts Testing same since 173166 2022-09-13 08:46:34 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2485 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 20:47:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 20:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406652.649032 (Exim 4.92) (envelope-from ) id 1oYCoU-0006wJ-UM; Tue, 13 Sep 2022 20:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406652.649032; Tue, 13 Sep 2022 20:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYCoU-0006wC-PY; Tue, 13 Sep 2022 20:47:22 +0000 Received: by outflank-mailman (input) for mailman id 406652; Tue, 13 Sep 2022 20:47:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYCoT-0006w2-Id; Tue, 13 Sep 2022 20:47:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYCoT-0006Od-Fn; Tue, 13 Sep 2022 20:47:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYCoS-0001PC-Sl; Tue, 13 Sep 2022 20:47:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYCoS-0008Nq-SI; Tue, 13 Sep 2022 20:47:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F3wp/hLFOA41pe5/+2ofCiDBMPFZyxyCjf7Hki4Rm7o=; b=DLfQa7Xem53+o7pkzjnO7caXo9 1NkMYXisAtkvva7M7+NX0NXfyknWHMv2pRQq3+BkYWqSb0Kd1U6D9LIC1MQEmTF7h/HOUak6ptPBO gN9z+/j24YdoMCXuNpqdmMi+bcwKeXGUpAeU0ONgmMOt4kR0OdhUZP9Kn4D2erVsnmwQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173167: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Tue, 13 Sep 2022 20:47:20 +0000 flight 173167 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173167/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 40 days Failing since 172384 2022-08-11 11:13:58 Z 33 days 71 attempts Testing same since 173008 2022-09-05 15:47:43 Z 8 days 17 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 23:03:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 23:03:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406667.649046 (Exim 4.92) (envelope-from ) id 1oYEw9-0004vF-L3; Tue, 13 Sep 2022 23:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406667.649046; Tue, 13 Sep 2022 23:03:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYEw9-0004v8-Go; Tue, 13 Sep 2022 23:03:25 +0000 Received: by outflank-mailman (input) for mailman id 406667; Tue, 13 Sep 2022 23:03:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYEw8-0004uy-B8; Tue, 13 Sep 2022 23:03:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYEw8-0000N2-8D; Tue, 13 Sep 2022 23:03:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYEw7-0001Y3-Qt; Tue, 13 Sep 2022 23:03:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYEw7-0008Fw-QH; Tue, 13 Sep 2022 23:03:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ff2FEuGZWUH+U6vGzFCN6vIjCZ0TdiKrlNKjd34AuYk=; b=t/9Q8O1HQioHChnhWyVploePxW IRrRA1M8CdiWpBQMphBsko+Ey3Ts0v1JwKrt2hU8sbr/CYC2pRvyULJkFBxn2m7oBETWQriylhJn1 xQaUmzuWFBGBS9p5AmKtd9kcPEffRaKlcKzD/4Z4zGI8czXGGEbtDFJpCt6/TC1dO+NE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173179: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=db7afaee91423e988df3160624d04c3c534f294d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Tue, 13 Sep 2022 23:03:23 +0000 flight 173179 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173179/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf db7afaee91423e988df3160624d04c3c534f294d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 40 days Failing since 172151 2022-08-05 02:40:28 Z 39 days 304 attempts Testing same since 173166 2022-09-13 08:46:34 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2485 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 13 23:31:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 13 Sep 2022 23:31:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406676.649057 (Exim 4.92) (envelope-from ) id 1oYFNK-0008MG-Qq; Tue, 13 Sep 2022 23:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406676.649057; Tue, 13 Sep 2022 23:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYFNK-0008M9-O0; Tue, 13 Sep 2022 23:31:30 +0000 Received: by outflank-mailman (input) for mailman id 406676; Tue, 13 Sep 2022 23:31:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYFNJ-0008M3-Ku for xen-devel@lists.xenproject.org; Tue, 13 Sep 2022 23:31:29 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2046.outbound.protection.outlook.com [40.107.100.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2fd5208b-33bc-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 01:31:27 +0200 (CEST) Received: from DM6PR02CA0068.namprd02.prod.outlook.com (2603:10b6:5:177::45) by DM6PR12MB4468.namprd12.prod.outlook.com (2603:10b6:5:2ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 23:31:24 +0000 Received: from DM6NAM11FT081.eop-nam11.prod.protection.outlook.com (2603:10b6:5:177:cafe::a6) by DM6PR02CA0068.outlook.office365.com (2603:10b6:5:177::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 13 Sep 2022 23:31:24 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT081.mail.protection.outlook.com (10.13.172.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 13 Sep 2022 23:31:24 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 18:31:23 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 18:31:23 -0500 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 13 Sep 2022 18:31:22 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fd5208b-33bc-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHDuGO44ST1aD1iZ5Eyif8BG8RNk67h8Upg9hZH+zD6QDCxPxTY09DS1M8rDCpdWMdBHoE8cUXTGPkaPHMfbTjuYK+F3V/hB1J+i8MdPWm/bNYWfYOg9+zAIJ4/LY+IjOpHJTAmaGa4SrisuVnp4c8FzOm4xoFpXmkwx4EHHrqj8yvojNXA0HHOq+HxJKeAUCfcC1HAEr5eES1jpTNZBr9IyfKJdTVp9Bo51TNBmpuZaMpQL690me1UiRnmko3/DHhR2TIfnhYUHo1QElQd8dA8c4XkZP1JAC+ip0SfSj6YGJDL+D4KM5EOo6WcoKAo7guz8Rl6SCpW5UTpMcI5Aag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QCPA0ryzlmb4HnFaXCJB1t+nX8fM+ivDm5BLBBIaYDI=; b=JB0xswc86nZDekwoiCM8dIqXCHrpK8+61XCAz2UOUeGSaPARD4mcI1RNtyt+HyBrVXXhPNMPyDfLxOzesiDDZ5wXTVRSORJkhzTfedjEhtiNkw4Fr7w21/gjTyJ4w9OtuJMjBTLd9caabhI2fz8E17TM3NBSHTDXCRXdepKXD8RFaJIeIjwpkrO5pI4nAzDMC8Pj0P5Z7Omoeu6uQar3qS1eKFl6ShNX5izjWxhfYykKfnOcyVpGDLND9Wpe8LY0+6wLIrV84rqM2pNV5wn3yw77etvHA1GJBpYzXB5TAHztgL91/95VpZ6i9TtEC1X1HfUyYTOI2Jb2h/iksam95w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=oracle.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QCPA0ryzlmb4HnFaXCJB1t+nX8fM+ivDm5BLBBIaYDI=; b=ekfgdisxwThzr0eeW36ECIIC/sQgQBipLf/MvL1CGQadd1Az/LB+ZqMsYS6diIshmccPZzAOUaUbbo3ZfOu8EUuP1DyZiLQRZXb5eqYLdCV77d8ynTaDNFMBUPgQHzuKVkbslf0sJv5dPQ56241Pi8meNjLubMDke5Nera4W4eI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Date: Tue, 13 Sep 2022 16:31:21 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" CC: "Stabellini, Stefano" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" Subject: RE: Linux pin_user_pages_fast fails on Xen In-Reply-To: Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT081:EE_|DM6PR12MB4468:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f58bc28-270b-40aa-fe8a-08da95e01299 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cIaHVIe6qxYeWOqXOLI8hKUoCocnbZJpzoySgrt7QTD5o+HSQYyWtn9vrWTb0aSPJs624UcvZjT1ba9/by+vAxV2hsfOzUxTSFL/FA2x8HhWXODaZNudAlNWsNvB3wmYln5u1mfPnbXa58pa/a+TAmHhWoJSlxVRvvJYSlM363FTAFQnZkA/B3bbZT/KuiNbBctKYu0FNRDOI/I+JaupNoFwQpv2rfHT/l2d7LnQkrly4rJ8wRNpcyvG3x8FNpEPydd655B3sIHYTisYkkKbt2LRc5CG36A5zeW6sz7Wq4l4V89oHaE4Su1eADnSnhkEK9sFZ4tHRnm4OqpGyiHFxwz+xGGFX4gkA0iEEzkyRCVUNhrilnAxT4MiDwyXUs5fZKzYK3uiks6NeQB5yEXN4SmT41V2+sZ1tn4FgKnaP+uvF7NnW29tSKdr5YoYBH51P/Y6iCXG/3Bjpg9jVAXKQ9O/aE1RUn92e3gitj9NwRqGZtGmFMpzQkND8DOHtDNVwdTjThFZGG4F8rBdeNIXwTNGnNxrlk675sLRzs2ltJfD5WwX4z7pjRy5gIXJHaMiwPu9L9jV4o4qVQKFFNK4zquoOAZgFrOeRSZuZ+cVwOv1v/VTzs8vFSq29NiNnQ1LawTxFiEG51zY5W75trcfJXSd2CsmXJXJNpKao7ntH2r6wDNk5pAcqKWC2IfF1d4njW7kWsb+u4LI4I14DNl8PdZ6+8o17ej2FobF5jo1hXXrmAhP/NLPNl3QWa9ohAJZZnDFIj8RZYQQqW2DO0JuFUEfp66h247zP/8qZ64BT/mb2M8AX3ItnKTXDX9yow1YUi/ww2I/wBWOLewZZX3fXw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(41300700001)(70586007)(70206006)(44832011)(86362001)(8676002)(40460700003)(81166007)(40480700001)(53546011)(4326008)(6636002)(82310400005)(47076005)(2906002)(186003)(9686003)(6862004)(5660300002)(8936002)(54906003)(26005)(36860700001)(33716001)(426003)(83380400001)(316002)(478600001)(82740400003)(356005)(336012)(966005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 23:31:24.2704 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f58bc28-270b-40aa-fe8a-08da95e01299 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT081.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4468 The problem is that drivers/xen/privcmd.c:privcmd_mmap sets VM_IO | VM_PFNMAP, and either flag would cause check_vma_flags to return -EFAULT. Do you know if it works if you remove VM_IO | VM_PFNMAP from privcmd_mmap? Juergen, do you think the flags are necessary and useful? Any suggestions? On Mon, 12 Sep 2022, NK, JESHWANTHKUMAR (JESHWANTH KUMAR) wrote: > Missed to update the Flag details: > > Flag for DMA Mapped VA - 0x0C0644BB > Flag for Local VA - 0x08100073 > > > VM_IO and VM_PFNMAP - Set in DMA mapped VA but not in local VA. > > Regards, > Jeshwanth > > -----Original Message----- > From: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) > Sent: Tuesday, September 13, 2022 11:05 AM > To: 'Stefano Stabellini' > Cc: Stabellini, Stefano ; boris.ostrovsky@oracle.com; xen-devel@lists.xenproject.org; Rangasamy, Devaraj ; Pandeshwara krishna, Mythri ; SK, SivaSangeetha (Siva Sangeetha) ; Thomas, Rijo-john ; jgross@suse.com > Subject: RE: Linux pin_user_pages_fast fails on Xen > > [AMD Official Use Only - General] > > Hi Stefano, > > https://elixir.bootlin.com/linux/v5.16/source/mm/gup.c#L975 is the -EFAULT returning for our current use case. > > access_ok is fine. > > Regards, > Jeshwanth > > -----Original Message----- > From: Stefano Stabellini > Sent: Tuesday, September 13, 2022 6:56 AM > To: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) > Cc: Stabellini, Stefano ; boris.ostrovsky@oracle.com; xen-devel@lists.xenproject.org; NK, JESHWANTHKUMAR (JESHWANTH KUMAR) ; Rangasamy, Devaraj ; Pandeshwara krishna, Mythri ; SK, SivaSangeetha (Siva Sangeetha) ; Thomas, Rijo-john ; jgross@suse.com > Subject: Re: Linux pin_user_pages_fast fails on Xen > > On Sat, 10 Sep 2022, Juergen Gross wrote: > > On 09.09.22 22:25, Stefano Stabellini wrote: > > > On Fri, 9 Sep 2022, Juergen Gross wrote: > > > > On 09.09.22 04:11, Stefano Stabellini wrote: > > > > > Adding more people in CC > > > > > > > > > > On Thu, 8 Sep 2022, Stefano Stabellini wrote: > > > > > > Hi Juergen, > > > > > > > > > > > > A colleague is seeing a failure on x86 in Linux Dom0. The > > > > > > failure is pin_user_pages_fast with addresses that correspond > > > > > > to foreign memory > > > > > > pages: > > > > > > > > > > > > - QEMU maps a domU address using dma_memory_map > > > > > > (xen_map_cache) > > > > > > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Address > > > > > > returned by dma_memory_map > > > > > > - Linux tee_shm_register->pin_user_pages_fast Returns -14 - > > > > > > drivers/tee/tee_shm.c > > > > > > > > > > > > Once upon a time it used to be the case that > > > > > > get_user_pages_fast would fail on Xen because we didn't have a > > > > > > struct page corresponding to foreign memory mappings. But that hasn't been the case for years now. > > > > > > > > > > > > Any other ideas why it would fail? > > > > > > > > I think we can expect that access_ok() isn't failing. > > > > > > > > I assume the mapping was done allowing writes (sorry for paranoia mode)? > > > I was told it was verified: QEMU could read and write to the VA > > > returned by dma_memory_map. From /proc//maps, the VA > > > assigned after the mapping is pointing to /dev/xen/privcmd. > > > > > > > > > > Other than that I'm not having enough memory management skills. It > > > > might be related to mmap()-ed foreign pages having _PAGE_SPECIAL > > > > set, though. > > > > > > Do we still set PAGE_SPECIAL for foreign mapped pages? It looks like > > > it is not there anymore? If PAGE_SPECIAL is not there, then they > > > really should look like regular pages? > > > > See the call of pte_mkspecial() in remap_area_pfn_pte_fn() (mmu_pv.c). > > The kernel version is 5.16 and the return code is -EFAULT. Is it the following -EFAULT the one that triggers? > > mm/gup.c:internal_get_user_pages_fast: > > if (unlikely(!access_ok((void __user *)start, len))) > return -EFAULT; > From xen-devel-bounces@lists.xenproject.org Wed Sep 14 00:36:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 00:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406682.649068 (Exim 4.92) (envelope-from ) id 1oYGOM-0006oY-6D; Wed, 14 Sep 2022 00:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406682.649068; Wed, 14 Sep 2022 00:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYGOM-0006oR-3H; Wed, 14 Sep 2022 00:36:38 +0000 Received: by outflank-mailman (input) for mailman id 406682; Wed, 14 Sep 2022 00:36:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYGOJ-0006oH-UK; Wed, 14 Sep 2022 00:36:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYGOJ-0002Tt-Qr; Wed, 14 Sep 2022 00:36:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYGOJ-00074I-6l; Wed, 14 Sep 2022 00:36:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYGOJ-00052P-6G; Wed, 14 Sep 2022 00:36:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RCidbFziBsTtk76lP1Pi5J94v2lO6MOrMR2GKr3Sszo=; b=zpI+FNjr3Har1yAPf1TDuTDiKx 0QVDRJIlNRIwMLLGrXPHgbalx/45gQ6MRAeqLlKsfxCfmfZxXe6u1qtAUsU3Uo4IvZ3bQVWel6Ij/ C0+uXjwLhFw/XM9q/FHc5BLeRj2MIa70tjFbw4C9QAhncZij5ZgAX9xWYwx3AK38Yf5o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173176: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d1221cea11fca0f6946bdd032a45b22cecfc0f99 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Wed, 14 Sep 2022 00:36:35 +0000 flight 173176 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173176/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux d1221cea11fca0f6946bdd032a45b22cecfc0f99 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 40 days Failing since 172152 2022-08-05 04:01:26 Z 39 days 90 attempts Testing same since 173176 2022-09-13 16:43:02 Z 0 days 1 attempts ------------------------------------------------------------ 1776 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182668 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 03:37:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 03:37:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406740.649096 (Exim 4.92) (envelope-from ) id 1oYJDe-0006zq-J3; Wed, 14 Sep 2022 03:37:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406740.649096; Wed, 14 Sep 2022 03:37:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJDe-0006zj-GH; Wed, 14 Sep 2022 03:37:46 +0000 Received: by outflank-mailman (input) for mailman id 406740; Wed, 14 Sep 2022 03:37:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJDc-0006zZ-IP; Wed, 14 Sep 2022 03:37:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJDc-0004AP-Eh; Wed, 14 Sep 2022 03:37:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJDc-0003PL-2Z; Wed, 14 Sep 2022 03:37:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYJDc-0007yB-0y; Wed, 14 Sep 2022 03:37:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u09pN3yfFWo7W8Q2Oqo2b/IUua9qQPpSiVKaT7JJptM=; b=ctBP3ugwIW0+2dtHJw5YzR46sv hCkGS8E+XGx5iaEIRAVrZBQ0rHV8fYK9QmIvV2ZqH6UyB5wmkfDo7TI9Z8rESPubXH9dTFFcTEdXN D4ZTIG+LDyVvCjmQ5dChflgqJvEn66NW1MHhm+W4ZHFoVJADW6xwS+I5RFL8KBEZtBpk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173178: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-pvhv2-intel::broken:regression qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:capture-logs(26):broken:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Wed, 14 Sep 2022 03:37:44 +0000 flight 173178 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173178/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvhv2-intel broken in 173172 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-pvops 6 kernel-build fail in 173160 REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvhv2-intel 26 capture-logs(26) broken in 173172 pass in 173178 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173160 pass in 173178 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173172 pass in 173160 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 173172 pass in 173178 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173172 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 173160 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173172 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173172 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 41 days Failing since 172148 2022-08-04 21:39:38 Z 40 days 91 attempts Testing same since 173060 2022-09-08 07:34:59 Z 5 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-pvhv2-intel broken Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 04:04:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 04:04:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406749.649108 (Exim 4.92) (envelope-from ) id 1oYJdb-0001w7-OU; Wed, 14 Sep 2022 04:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406749.649108; Wed, 14 Sep 2022 04:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJdb-0001w0-Kp; Wed, 14 Sep 2022 04:04:35 +0000 Received: by outflank-mailman (input) for mailman id 406749; Wed, 14 Sep 2022 04:04:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJda-0001vq-Hc; Wed, 14 Sep 2022 04:04:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJda-0004hc-Ft; Wed, 14 Sep 2022 04:04:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYJda-0004ce-4u; Wed, 14 Sep 2022 04:04:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYJda-0006t9-2K; Wed, 14 Sep 2022 04:04:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IkuCnt4jLwmEFCX/Rct1WfakI9w0+zf/bgMq4B8X2uQ=; b=3/hvlsRPPaOuPtECgQgVwxVLW9 oPATWwqNH5qhjBK0iESOTLCRGV7Ju0mJZUTYSbQEsmMrPU4SbXGYo6aMUC20YqtgkF6+FRCZA3tHT xT50KEYlKcxEH/+TSrJyxAOcCYHyco4MrqrjFnc6LWLRGgtVL3DUhFXr1dsEbCu3zUfI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173182: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=db7afaee91423e988df3160624d04c3c534f294d X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 14 Sep 2022 04:04:34 +0000 flight 173182 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173182/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf db7afaee91423e988df3160624d04c3c534f294d baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 40 days Failing since 172151 2022-08-05 02:40:28 Z 40 days 305 attempts Testing same since 173166 2022-09-13 08:46:34 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2485 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 05:56:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 05:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406760.649119 (Exim 4.92) (envelope-from ) id 1oYLNR-0004u3-PL; Wed, 14 Sep 2022 05:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406760.649119; Wed, 14 Sep 2022 05:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYLNR-0004tw-LZ; Wed, 14 Sep 2022 05:56:01 +0000 Received: by outflank-mailman (input) for mailman id 406760; Wed, 14 Sep 2022 05:56:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYLNQ-0004tq-2E for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 05:56:00 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2052.outbound.protection.outlook.com [40.107.237.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5ebf529-33f1-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 07:55:56 +0200 (CEST) Received: from DM6PR12MB4564.namprd12.prod.outlook.com (2603:10b6:5:2a9::18) by PH7PR12MB5620.namprd12.prod.outlook.com (2603:10b6:510:137::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 05:55:51 +0000 Received: from DM6PR12MB4564.namprd12.prod.outlook.com ([fe80::d0bb:4d4d:7767:19fd]) by DM6PR12MB4564.namprd12.prod.outlook.com ([fe80::d0bb:4d4d:7767:19fd%7]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 05:55:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5ebf529-33f1-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1hd5NzTcH5votb7d4p9u27VB+RcWboZf2YORpTrwgfdpL1t5Z3AjJu2XsaLfXlmcB0zV2mWUR+eCOOtgt6BxemhjLvfI/M6Jl5t+TiJG9iQI9kk56MJf+tZcml88CEc42mbQqpoKvVNxtJ3CskqoUFTmN4zv6p2IOYNhycuR6t3jNaJi9CoX+Rxrco6n9rlnQLO04FAknuqGCSl/ee3gFQXRE5irKrerCAq8IHEpFk7TTMIFv21SUJxJBSXjSZSmeEmzcIG954SEx0NVPpxcWf0tmdZi5SGijf1owTc8Ay/vewzpMeUYmy6c0l9C3BIamEtUyMNlcHTCDb2gfAb3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8hvt5w/5N7F1waSWEQjT0FDXkcIy0ZJfe/mRHfozCXc=; b=TFd+xdDsYvklve5fVugOw84/t+XrwW/t02syGmlutf3ZHPnoO155fqHVczA9o5zGU4zXU3CFs1XsXbGietwxCM+7a4D7qHjwbbxAXFLDeircmrGUKqHx36mvqWDgkh/opINA59vuRHprLDkK4n9iHQhETjZ3RxHZuY7UVVA5UuVj6tt8QZodCakI+UqGOj2QCZYQ4i2DD9Iwk2+mzE/hO5mcoFqhPRJe6OTRfPFD94gYHTknP/QraCGoLWHauBjBgOM9pOCb4QZVtTKi+Lus9AFxFEtQbThqTZ/4Up50/eWW3YvMyF8HnMZ73udjmaczxTKSDgaDHciIj7ZvM1w8oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8hvt5w/5N7F1waSWEQjT0FDXkcIy0ZJfe/mRHfozCXc=; b=cojL1pqAEbO8X3S3wEc/ByQgqQjmzHSiMk4yq0YLtgb8LinC8yi3qHbUmVvlHqVrvpydV/dN2nBH9EFsfnGN/oTTEqf+3lHF2iW9eRwxQmWye+MSSmOjtDyl3c1hzTeFWCzfb62FbGyiTD+SOzPdIThg5wIgq4xtGO8HbwlbE7c= From: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" To: "Stabellini, Stefano" CC: "Stabellini, Stefano" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" Subject: RE: Linux pin_user_pages_fast fails on Xen Thread-Topic: Linux pin_user_pages_fast fails on Xen Thread-Index: AQHYw/FtbHk6dXjix0qU8E4gYrQhY63WppaAgADmKYCAAIgNAIAEgvEAgABFGKCAAA00AIABH/CAgABrF7A= Date: Wed, 14 Sep 2022 05:55:51 +0000 Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-14T05:54:39Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=0f1e805e-0243-482c-8c24-1dd1e468d677; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_enabled: true msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_setdate: 2022-09-14T05:55:48Z msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_method: Standard msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_name: General msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_actionid: 420cdc04-f722-4214-aaf5-bc769e6bc339 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4564:EE_|PH7PR12MB5620:EE_ x-ms-office365-filtering-correlation-id: 49441053-ab68-41a0-2627-08da9615c7ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9mnfMXYEpX3vJ2qTLYBvFLib2lBiGXVkWadAT5lguYAre9NA50WId5cHBAfP76VpgqJgwMaKdT1meO9qRLz60+gHRHTlRzOZMMVUpioNCbxe3I+vUXwH+dK4CyVWTlTQlcpETi9+xLMAG0Bypa5CT00HMRMg/6IjKm7sckr363oczBN/W9/T1R0W25yICtlvgF/yOaRy8UeSY3oXuj+cajopBHiEo28zQPjhJTppMKCk8IDOs1Js7G+Nup3khZAq6UwWP5chY6rV7+NaEwlqRjwjouMNUesJn7ckmX/ho6r3WoXB50Fjau5KxyHYhf7LAg7TIwgn3jXvfhoE1jS+wcMF8qYvb9ph1c27i6TM1zqz+Wg6FrDX9qbv/K/GvVk4dPCSKdLtZtfG7acJWSSuRTKsqhCM16jr6GLH08eyUDYdkTOF4EQCFZNTZiWZaGaUSLGqf9eni1+J89grUexwrai+bHVGEcM5QP4oZZjERN+p6DQbWNsZexvvfotHyzT4Mi+2YSILeKLSRJajyXjEw0c7i3HwAv2EfcHFL8kWQ5pscgUaQPQHyEcdH8fu+1pLTSW+FcR1ks0rsNEblEiFmPbbTH7eKzl7W3cVwvp1gO/Dgg//YxqKHgGMaIcsgji3KoAprexu4hthtNKwh/IBtslSFlMJgI1aOnrFKj+swzzCUhZtrx9zOmiIC9xEawydsgluHa4h2qiMUhy7Xas89bsOIzRky3vxZmOH+32Xk3R8PvRx+Je/8bDdvKobgby94qPPZoIEnYQZzocO9VT3T70dZNJLB43d8AUbG4J+vag= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4564.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(346002)(39860400002)(396003)(376002)(451199015)(8936002)(186003)(33656002)(6506007)(26005)(41300700001)(71200400001)(38100700002)(6862004)(478600001)(66446008)(6636002)(66476007)(8676002)(83380400001)(53546011)(66946007)(966005)(316002)(55016003)(64756008)(4326008)(66556008)(52536014)(76116006)(2906002)(7696005)(5660300002)(122000001)(9686003)(86362001)(54906003)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pax/rVO0LGCGAKxLKN3A39HJUZnUMywM+o7aCEX8mdTPC7qsenO5SgB2Tvi0?= =?us-ascii?Q?k/FQRibe+T203MWZldMWKB2UpWoy5K7DvAFqu2JXkaygC6/jDscurievGMdm?= =?us-ascii?Q?JK0TBQ8VxwM/YhC9GVjwbr/JQatCZn9diOsj8f79woNRaIZxGLkFfiVb9oJp?= =?us-ascii?Q?Skub/rW0QJTzF1O/1k3dSwHIc0vW05zMEmCXL4Cjo9YmK8xPGB0phvI3Rv4f?= =?us-ascii?Q?jmnhxdED347KFnyIVrC/dqccy9ieF+t56piv9mezY7VRE9uKdkYiGagbowh2?= =?us-ascii?Q?N2DUK0Uz6xbELptnKvKKodAITPllAGYGusC5NY0AN91OxoztD1jNam9PlG2k?= =?us-ascii?Q?n1o9/TRF1pRqpmZzBN4dwz1FHyhJjycJKwP3mqBQGqrXUV39aCHKI65l9rK5?= =?us-ascii?Q?LaBl6xF1Fb4DvS9fxieiqwOa6pWNiF0+63dIQ8Hy7AGAnsxjmnUsIBc5HNL3?= =?us-ascii?Q?NaGhw6/7tbAS2Th8f3R73mj9sb9RO0Il6YX5+N4IJYiX/ba9Vw1Baf5Yi2dC?= =?us-ascii?Q?ktRVhrBSqojguLJMep5bdaRBnwjho9NIknmIe+iOVZVmX7SBYlHOwHShaKGo?= =?us-ascii?Q?le+BJteVqadzPHS/NzJiW5ArOaTwuMnXpFEJwLwx0wNm93US99Dh0pfrttCF?= =?us-ascii?Q?AYRdRrJcR8Z/I6rqelGwhUF30i4wp8JVrkKF143ewRiFF8o2SXzJkM2rIiSo?= =?us-ascii?Q?x2xEDBY3qFh7Fyup/gNhomH8BXyt0+J8jyA77uby+tyFGu2ROlz7ptS4wkg0?= =?us-ascii?Q?Rsf2kVjeGxKvsvK8+JOyAHcwiQ+0HydsUEuWPb7ez95k9CnhFkoRcnHtIBoc?= =?us-ascii?Q?hc8YCSFKRfRjVBGNQ+XdlHD+FccV0oOJhLcdxD2Qo3MZ06kkuO2gzJknisHo?= =?us-ascii?Q?mzU+HXH8LduUKXgFdcC8kYdUeY+fIwW1MTa/VoSWYAFiVyCmAr2gCWKlQ/8f?= =?us-ascii?Q?LPxM3FYMspuN0EanajPa82gosEDkV9yQaHPLwXWqftwTDvEnor7qxczLSnfZ?= =?us-ascii?Q?X046Z8w2qSftHIuKFsu744Hy1AdwMGjnJ1AEBMUP3wXLw9P8iFcTlrbffIof?= =?us-ascii?Q?1emyxZAI851nwvl2dB2UzNTUuGlNQrru8aDyU1rj5GeCD9vUkqi78bt3ih7+?= =?us-ascii?Q?4oEuHnyuJ5/iU+qy3+PZgo2TrvheQD4NCU0UntWGfqYiD6nXmv/UvhcAgbKr?= =?us-ascii?Q?TBWg0MzU0EaRnnZ5T12a2Ug1r94BdslNVnKJruSxTS8LOz7T1H9KuWOBUXz7?= =?us-ascii?Q?fOhEI7OzGaf1NVnTDqRc5kzE8FKYLrKdpu6qm9rmYMCzKmSLycN7OXcrY90c?= =?us-ascii?Q?mjYD3lhFLUA2MElQpuvbJUEGUE6Erjh7SJifF2A3HB3TnTcNvZYl7/+dpKW0?= =?us-ascii?Q?M2DKDARQWmI8Yw9DgEiMspXKmOu7KhS166H4mDEY6k/wXzMsFqdumYjtRoeA?= =?us-ascii?Q?85/wFei0BjCJvtStIv+sEMIrAJSTg7ZvrIFg5/HtdpKIBsptUplMC9Cx76EK?= =?us-ascii?Q?Xy1TKxRhC9V7jKOefRIUKhauwaGIo/j6U766Hs7CW5TWIEtgOenBLkN2oK88?= =?us-ascii?Q?JxhZOcjD6/0ErGZvAEphOM4po2/D5Y07+bVhX0TH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4564.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49441053-ab68-41a0-2627-08da9615c7ad X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 05:55:51.4214 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ixW4aj5YVl3bXg0L1XEW9scDpvU/w4BtT8Hj5zd+f3MAlJmrndn7yGf2tRPQ6CCe00W9HXpBEggVUpnkGxSuUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5620 [AMD Official Use Only - General] Hi Stefano, Thanks for the suggestion, >Do you know if it works if you remove VM_IO | VM_PFNMAP from privcmd_mmap? >> Gave a try, looks like the DomU doesn't boot without these two flags. Regards, Jeshwanth -----Original Message----- From: Stefano Stabellini =20 Sent: Wednesday, September 14, 2022 5:01 AM To: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) Cc: Stabellini, Stefano ; boris.ostrovsky@oracl= e.com; xen-devel@lists.xenproject.org; Rangasamy, Devaraj ; Pandeshwara krishna, Mythri = ; SK, SivaSangeetha (Siva Sangeetha) ; Thomas, Ri= jo-john ; jgross@suse.com Subject: RE: Linux pin_user_pages_fast fails on Xen The problem is that drivers/xen/privcmd.c:privcmd_mmap sets VM_IO | VM_PFNM= AP, and either flag would cause check_vma_flags to return -EFAULT. Do you know if it works if you remove VM_IO | VM_PFNMAP from privcmd_mmap? Juergen, do you think the flags are necessary and useful? Any suggestions? On Mon, 12 Sep 2022, NK, JESHWANTHKUMAR (JESHWANTH KUMAR) wrote: > Missed to update the Flag details: >=20 > Flag for DMA Mapped VA - 0x0C0644BB > Flag for Local VA - 0x08100073 >=20 >=20 > VM_IO and VM_PFNMAP - Set in DMA mapped VA but not in local VA. >=20 > Regards, > Jeshwanth >=20 > -----Original Message----- > From: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) > Sent: Tuesday, September 13, 2022 11:05 AM > To: 'Stefano Stabellini' > Cc: Stabellini, Stefano ;=20 > boris.ostrovsky@oracle.com; xen-devel@lists.xenproject.org; Rangasamy,=20 > Devaraj ; Pandeshwara krishna, Mythri=20 > ; SK, SivaSangeetha (Siva=20 > Sangeetha) ; Thomas, Rijo-john=20 > ; jgross@suse.com > Subject: RE: Linux pin_user_pages_fast fails on Xen >=20 > [AMD Official Use Only - General] >=20 > Hi Stefano, >=20 > https://elixir.bootlin.com/linux/v5.16/source/mm/gup.c#L975 is the -EFAUL= T returning for our current use case. >=20 > access_ok is fine. >=20 > Regards, > Jeshwanth >=20 > -----Original Message----- > From: Stefano Stabellini > Sent: Tuesday, September 13, 2022 6:56 AM > To: NK, JESHWANTHKUMAR (JESHWANTH KUMAR) > Cc: Stabellini, Stefano ;=20 > boris.ostrovsky@oracle.com; xen-devel@lists.xenproject.org; NK,=20 > JESHWANTHKUMAR (JESHWANTH KUMAR) ;=20 > Rangasamy, Devaraj ; Pandeshwara krishna,=20 > Mythri ; SK, SivaSangeetha (Siva=20 > Sangeetha) ; Thomas, Rijo-john=20 > ; jgross@suse.com > Subject: Re: Linux pin_user_pages_fast fails on Xen >=20 > On Sat, 10 Sep 2022, Juergen Gross wrote: > > On 09.09.22 22:25, Stefano Stabellini wrote: > > > On Fri, 9 Sep 2022, Juergen Gross wrote: > > > > On 09.09.22 04:11, Stefano Stabellini wrote: > > > > > Adding more people in CC > > > > >=20 > > > > > On Thu, 8 Sep 2022, Stefano Stabellini wrote: > > > > > > Hi Juergen, > > > > > >=20 > > > > > > A colleague is seeing a failure on x86 in Linux Dom0. The=20 > > > > > > failure is pin_user_pages_fast with addresses that=20 > > > > > > correspond to foreign memory > > > > > > pages: > > > > > >=20 > > > > > > - QEMU maps a domU address using dma_memory_map > > > > > > (xen_map_cache) > > > > > > - QEMU calls an IOCTL to the TEE subsystem with the Virtual Add= ress > > > > > > returned by dma_memory_map > > > > > > - Linux tee_shm_register->pin_user_pages_fast Returns -14 -=20 > > > > > > drivers/tee/tee_shm.c > > > > > >=20 > > > > > > Once upon a time it used to be the case that=20 > > > > > > get_user_pages_fast would fail on Xen because we didn't have=20 > > > > > > a struct page corresponding to foreign memory mappings. But tha= t hasn't been the case for years now. > > > > > >=20 > > > > > > Any other ideas why it would fail? > > > >=20 > > > > I think we can expect that access_ok() isn't failing. > > > >=20 > > > > I assume the mapping was done allowing writes (sorry for paranoia m= ode)? > > > I was told it was verified: QEMU could read and write to the VA=20 > > > returned by dma_memory_map. From /proc//maps, the VA=20 > > > assigned after the mapping is pointing to /dev/xen/privcmd. > > >=20 > > >=20 > > > > Other than that I'm not having enough memory management skills.=20 > > > > It might be related to mmap()-ed foreign pages having=20 > > > > _PAGE_SPECIAL set, though. > > >=20 > > > Do we still set PAGE_SPECIAL for foreign mapped pages? It looks=20 > > > like it is not there anymore? If PAGE_SPECIAL is not there, then=20 > > > they really should look like regular pages? > >=20 > > See the call of pte_mkspecial() in remap_area_pfn_pte_fn() (mmu_pv.c). >=20 > The kernel version is 5.16 and the return code is -EFAULT. Is it the foll= owing -EFAULT the one that triggers? >=20 > mm/gup.c:internal_get_user_pages_fast: >=20 > if (unlikely(!access_ok((void __user *)start, len))) > return -EFAULT; >=20 From xen-devel-bounces@lists.xenproject.org Wed Sep 14 06:36:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 06:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406768.649133 (Exim 4.92) (envelope-from ) id 1oYM0K-0000r1-0G; Wed, 14 Sep 2022 06:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406768.649133; Wed, 14 Sep 2022 06:36:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYM0J-0000qu-Sy; Wed, 14 Sep 2022 06:36:11 +0000 Received: by outflank-mailman (input) for mailman id 406768; Wed, 14 Sep 2022 06:36:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYM0I-0000qo-N4 for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 06:36:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8238a1ca-33f7-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 08:36:05 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9056.eurprd04.prod.outlook.com (2603:10a6:150:1f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Wed, 14 Sep 2022 06:36:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 06:36:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8238a1ca-33f7-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiVXfZTxJ0mLOmrWlEhA9DwainaDbclgwpx3XMs976KLC85JrprKOaD5VA6JIREQnd2BRy1RrRUmDTwFE27Haw6NPfi40Bd2URcn7vuQ3/lf4w01rjO8o8bmSMh1YPmiIopTZ6L0G7XBLCzJpxhNgwEvdztNRmLCLh1AfNF7nxbGG/8vV31KpThGu5TolnGSlVEZfXxjJrcRfdp4zSu/qNoytLbzaG7uYJP1/mwBBJzNXLTevesYnsf2gqY1Tf/sCVKEPpMH2THEoZi7R9kVyl0TCsFbp6lXFzrDpz0xRXkT9wLM7IMHjAog5yZKmF4dPYZMMOrE8AjfoDhoPd5X5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8zMGW22NDvpi1glwglzXZuSQ6YwiL37WMVMl2GTCPk=; b=UbHjm+8mLu6y6ujQFdPdjN3R5G6YRShBi3zsOSuTHLt17t4AyIZnoJ45PBz02haaW7umRmZrTzxJ5sAm1tcRFJ5o3oIex7JRMUHhqlSgjG0VN56jXHs0oncMiVnCbg7Nxry0p4b+9zcM9X4PRSExEKfB5rXytAnXFDXQIpvUSIq2hU2KJwVeSRRgIhSDGMG1VJzXFP3TNmClfpSQU3zxwqx5BRA0x7xgNSCSh1hvkI5mNSwWOm4vlwfkGsiLJ8wLNgFRt5ChcNYd//gnNHZ2PklbSJvXDzRar/SU4jBPfYBSEUKZLEXsoZCxEGesqlk+CpowrjevrDAPzvzxsi6NrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T8zMGW22NDvpi1glwglzXZuSQ6YwiL37WMVMl2GTCPk=; b=CARlDPpw6fGTEh0BUMYhi1eaQkGHFNOSrZ9eCt2F/M9PjpGWsVTO1ZEGqiOngvm0dFuXN79zBq9sKIf6EIn8hYUcB2/aHwqvV5YxhpWqJ4Xiv/SuNVzYMe32S24nl4VAB5DTBNhUDZcMsQALMCv/4a5b3h7o1hUTFfpqU+CIikWLIxtNNoI17QeF5jgA9qIc6d05F2676EqNXDY6juAjIKi+40pkfOSDEN1wQ+Lg3CX9y2k2RDG7tGT8SldiOf+oc8u60wnLJIm11cv4IumGe223KLBUK+TQkr4TgnmntBB2zilPNR0FWgY5TUSjanjD+JksbKoGGP/OIc1wTns1qw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> Date: Wed, 14 Sep 2022 08:36:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Setting constant-time mode CPU flag Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0264.eurprd06.prod.outlook.com (2603:10a6:20b:45f::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9056:EE_ X-MS-Office365-Filtering-Correlation-Id: bc7bcfcd-657b-4ac6-a517-08da961b6599 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kkPCR2a38o8evTUKRDsHPBtxCUkTMfFn7LYkYQ7YQ2U/fbhh37GwhYMTeE9eR2u54B5ixoa8qUjuPQBM6b/9btmSbkK9dVfoZDNgnHo07RmbPvgJk0mJudoGFasZHb64SZReobeQ3MbRt8n45gQaU6Tdb4rFqSu6CaOSdQrDgtMQDtkCvFzS1Pg/XabSC8zPbSCSWabUti2T5i445HBZstabno3+qJsP84wI/r1PAdG3K9eVRdUDfADOIG6arwcqyozsV2LaWtjGVeT7v+0X7TP3nUV79kAuqMEBcXcv3v57GLzO8IeOX8N/A2TjMvnjXaBFmBqFFhUZfakTwM7UY1RK5U7LH7YY3hdBVemp393rYjNZEQfRNPoOxMDWh0RJrCQW27EF9c0FfBjXCQVvgkF1ewZWonIKOMcRBdj7haNdES9UP6Z9Vcx4YPV8pT74+YbHtudU/C0Qo/0oolD4w4bWJtSLy+0GJhT85vw57DIkII8tZkkPdW3s5bSxdpMR6Ky2704lYZUu2w5+UB3BF6Q+CbibbfcNUq7p8HoS5U+Z4yDhzHsgnurED2tBnWbKnqQ+0JkOCB7V1dTkGId3Ms/7j4BZJMnnFBF+Z88Z1wmiJgDYQoSDPgMpIJjxQh/8ZuKf8+vE6zn/F+E1LctSD2TB9Z++AK1tc5dN4i8bBg24+0TrLPW55aGh/HDZBH4bYEX1Cbuj2DiOPj+Rbs+MGGpaoPwzgVWiaNzyMMn2vm9ilyq3wIlvT2tHCKi2LGFTHQqVJqgpdnAbscVGbf1PHEM/uQNwOOc+vLYyJWpd680ZK+SwGrsPK5x/Mm6WoFD6gkmMmovqz/Kr/sZw4rl01A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(53546011)(86362001)(966005)(66946007)(2616005)(83380400001)(5660300002)(6512007)(6506007)(316002)(4326008)(6916009)(54906003)(478600001)(26005)(8676002)(41300700001)(186003)(38100700002)(31696002)(31686004)(66476007)(8936002)(66556008)(36756003)(6486002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTA3ckVOQUlISVQ5b1prc24yb1VJWVpndzBvMHZvUFcyMjRLMkFiK3EvUEVZ?= =?utf-8?B?MVZheU1EUGFLQ0xxa0dJcWhrZUFCZlZMaFgvVTBqbDF0ZXRZZzAwWjIrZ250?= =?utf-8?B?Q1NNUkEvWU05czFzbS9NNSt6d3FGSTYxVHpkdHZRWTNDbFZVK0wvWXFVR2NE?= =?utf-8?B?d0VaZE81NDIvSkNKdUNyZDlYWTBPdlRlSWdJTWdQbGdwbUtFS2cvTDFkaEU1?= =?utf-8?B?MnJCNXZyK0M3N1VrWTkyRlNqUEVPZG9jNE93OUdaWlBWRTZETFRMeXc3N0VR?= =?utf-8?B?YVg0V25JUHNvNnJ0eTdDdWFDZlRrWENaV2xaL3o5anRpL01YWGdycXE1aCtK?= =?utf-8?B?TmZOam1wTktUTFVYS2J0aTc4TDhFd2FhWWdDWHBuZFBEOFhGdWR2dDJ6NE5G?= =?utf-8?B?WFFFdnN4dThhWkpuaVhjMVp1VGw5c3Q0WmlCWWIzQ2hHM2V1R1AwR3F6eEdn?= =?utf-8?B?QUNLUnkxQWhNNk1JdGx5NzJHbzF2dXBucGYrZmMrQytOb2d1bTA1RENDblpN?= =?utf-8?B?ZEx5amI5SXlGYmlmbW8wNnl5VmtEQ1RlaVRwRGZONDZ1NXMrUEt0cUhrWnFQ?= =?utf-8?B?S3lCSDNHeHVrOUxHNUhZNUIwdnoyVERGcnVYRExzckhkNFBVTzU3QWV1NllD?= =?utf-8?B?QnlwYW82b3ROK1EySTlxTGxhbk1JYlVtY1NiUEdtQytlNkExN2VuTENPTXNl?= =?utf-8?B?YVhTbUpCOWRJNnd4YnpzQkw3U3pRNytzR1NQWHFoaEFtK3hnUjF4ZjEzNVN0?= =?utf-8?B?bzA0bnVMc3FlL1luT0dxYzVSUHhSMzhYcjFsVmpWTW1jdi9uUUR3UjE4Y3Mz?= =?utf-8?B?aEE5aVZkaEI0KzFUVzBSSjZGL1MzS2FKSWJhbEpUMHo4VGdIYTVQTy9NK3Ru?= =?utf-8?B?cElUSm5VbTJDdGk4Mmt3ZzlMWW9IVko0MFhwbFVoK0dCTkdEWHVwdWptOU9Z?= =?utf-8?B?OHpNcThSekpxN2lHc0FDeW5ScGFJSnFTK1E3ZnJUWGdsbjVwRmZ5cFdZelF4?= =?utf-8?B?NDErNm1EeXg4SXFwWUNoSENkd2syUndRbVBmcGtvcHpYNFhMZmk0VFNwVEh5?= =?utf-8?B?Vjd0VkRRRkNSaTRkNjZUMTdsbS8yOUVabnZFak9PbTZGY0xIRkpHL0tHQUxt?= =?utf-8?B?bnQ5eHIrOG5mMjd5YThZaUhnR1hwZWdRa3lpWkU5Wkxhb3dVQ2JSNUdORUJN?= =?utf-8?B?ZUxSM0QzMW5rM3UxcEo4MW5BcjNTR1RVbHh3ckxhdHRRVStpNkx4dThrR0J2?= =?utf-8?B?dWZKaUw2MHZHTGV5SWpQZE5INCtvWE9wS294NFhZOTFWZHIxb3h1NFFMaldX?= =?utf-8?B?c3ZjK2VCdE9aUDhoN1pacHN3SlpKOTQ1bjZMZU5KWHUxdzNLclo4K290cTh2?= =?utf-8?B?R2xMM3pGdXZ0Ti80WkJzQ2dKZlViZ0NpR01ua205clJ0d3JsYnpHVWwySS9E?= =?utf-8?B?VEdBZTZsZjVvUjFrYTh1Q3BRZEFTeWRyUTJGWUZCYkswVlI2UHV3NnNYTW54?= =?utf-8?B?RE5mVFM4bHR5ZVBTUnF5TTNKRUhDd3VMZnEyUytEQWhieHNoL2xsYklpM0V4?= =?utf-8?B?NkdMeFhsMndZbDN2WW1KN2lKTlJTeEs3bmdENStSY1UxekhLbEM0UXZXam9p?= =?utf-8?B?N3h5SDRnYVVVbGo5VmJmbm03Tm0rckpnMDFmM3BKYnM2TGxKQmUvUjBEbmJR?= =?utf-8?B?eVpweXVLc3ZWWVp0NytkYUJuQm5oTWIwWW9ZamxqTUhVdHJmc3M0cStCNzNY?= =?utf-8?B?VVN5cUphNEJVNEYyN3daMExMd2Y4NUU1dzBZS0tMUGJDN1pzakE3WURxcnNu?= =?utf-8?B?bkVZZUU0UnlGZWYzYVFacEFXanZNM1ZHakxzOGQveDgvYks2YVhkV1lqREFz?= =?utf-8?B?QjJiY0VsZHlkTHpKelVjbGs3SGhuOXNSSEpianFOVXVPSzBGUkFGLytWTkpG?= =?utf-8?B?eThLdE9NYTY5Uy9NZUJ0MC84dDlTU1lXcDU1UC9YUkVRSCtIRDcwekxzY1Y0?= =?utf-8?B?Z2pNamdEMHIwd1NjNmhpaWdLb0dIdFBOOEx6YWhxbnMwT2tVaUt1SjVtUHR2?= =?utf-8?B?NFZMYTNzYlRMRUJ5TStCRVNiaDJRaGZDUURWSENKVWZHM2wrTldnZ3k5QS85?= =?utf-8?Q?zCGEz0BZDkLG+tVn434shHnj3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc7bcfcd-657b-4ac6-a517-08da961b6599 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 06:36:04.0760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T2+jaoHqwDAHvs681p6oyfiIjA61/IE+M8f+yHxtmyhsQ0yYKuwf7iBzZzuDBQKdja+Si6+Ip5s/3ulB/s1mhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9056 On 13.09.2022 19:22, Demi Marie Obenour wrote: > On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: >> On 13.09.2022 16:22, Demi Marie Obenour wrote: >>> On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: >>>> On 06/09/2022 10:52, Jan Beulich wrote: >>>>> On 02.09.2022 04:05, Demi Marie Obenour wrote: >>>>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in >>>>>> a CPU register to enforce constant-time execution. Linux plans to set >>>>>> this bit by default; Xen should do the same. See >>>>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. >>>>>> I recommend setting the bit unconditionally and ignoring guest attempts >>>>>> to change it. >>>>> I don't think we ought to set it by default; I can see reasons why kernels >>>>> may want to set it by default (providing a way to turn it off). In Xen >>>>> what I think we need is exposure of the bit to be guest-controllable. >>>> >>>> We absolutely should not have it set by default.  It's a substantial >>>> overhead for something that is only applicable to code which otherwise >>>> crafted to be constant-time. >>> >>> Either Xen needs to set the bit by default, or guests need to both know >>> the bit needs to be set and be able set it. Otherwise code that *is* >>> intended to be constant-time has no way to protect itself. >>> >>>> As for why Xen doesn't enumerate/virtualise it, that's because >>>> virtualising MSR_ARCH_CAPS for guests is still not working yet, so the >>>> feature can't be enumerated yet even if we did support context switching it. >>> >>> Intel and ARM64 guarantee that CPUs that do not enumerate this flag >>> behave as if it is set unconditionally. >> >> I'm not qualified to talk about the Arm side, but may I ask what you've >> derived this statement from for Intel? The doc page referenced by the >> link you did provide (still in context above) specifically further links >> to a page listing instruction with data operand independent timing. All >> other instructions, as I conclude, have variable timing unless the bit >> in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same name) >> is set. > > My understanding is that only instructions in the constant-time subset > are ever guaranteed to be constant time. Hmm, yes, I did overlook respective wording in the doc. > On architectures where DOITM > is not enumerated, this guarantee is unconditional. I have to admit I'm suspicious of this "guarantee". > On architectures > where DOITM is enumerated, this guarantee only holds when DOITM is set. > Therefore, it is critical that on CPUs that enumerate DOITM, Xen does > one of the following: > > - Ensure that all vCPUs enumerate DOITM, and virtualize the DOITM MSR > bit for use by guests. > > - Set DOITM by default. > > Since Xen does not support virtualizing MSR_ARCH_CAPS, vCPUs cannot > enumerate DOITM. Therefore, the only secure option is to set DOITM by > default, so that guests do not need to be aware of it. I can see where you're coming from, but I also agree with Andrew that the resulting loss of performance is a counter-indication to making this the (universal) default. What I could see us doing is make this both Kconfig and command line controllable. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 14 06:40:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 06:40:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406774.649144 (Exim 4.92) (envelope-from ) id 1oYM4R-0002EL-Gj; Wed, 14 Sep 2022 06:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406774.649144; Wed, 14 Sep 2022 06:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYM4R-0002EE-Dy; Wed, 14 Sep 2022 06:40:27 +0000 Received: by outflank-mailman (input) for mailman id 406774; Wed, 14 Sep 2022 06:40:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYM4Q-0002E8-0h for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 06:40:26 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b720128-33f8-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 08:40:23 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3681C320093D; Wed, 14 Sep 2022 02:40:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 14 Sep 2022 02:40:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 02:40:20 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b720128-33f8-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663137620; x= 1663224020; bh=ORyS0cuyKu42z3iDxINAGfbaYo4Sq45Q6H4oW/9iDOc=; b=c wtMde9UL0ChNcQg74PwN7c+1YRr0cWPm7IVjBdsBuJmjKxb/u02nQkP8l+PpXHX2 D6ZZ/GY58RR3WqVBEshDbg9d4M4GoEZFehlDO39YGTj6gTlDxmccZv65H50Z3qXn KxtOkSKt2DOyXxuYmXWuFAwz1uBnbiYXnQMZUX7zntOqcBVV5i7vbJNIYZVg+vqo aFf8/5vfuPOM3bMG2qdnvqWgARisuZK+riW3N3SidokYDVgERd3enqPU1fUFJl9V ZZE2Piulk0i39cmPA8M4AmY4HIUpaF2q2k8mG/pKWq3KMXNpY9OvzKfXmaZb0crG 6Z+jWNozIwP1u6Rm6T3NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663137620; x=1663224020; bh=ORyS0cuyKu42z3iDxINAGfbaYo4S q45Q6H4oW/9iDOc=; b=OlNfE5j01CrILK18qVeKV3LGnC8qSdKXG2/2W+tXyTFW lSR+lvYOlnZLNl2ORmNRsPzODLAF6EbmTWSFBYmEN7gJNYSt85QTCI/jEa3K8ju7 /F5cgupUX5uLmWsvBIl6txDwzTRdbpnO/i8FW+AoogppWZ/Pni0W8Hqs4HwfCChd WJuMhwx7yRUDdfuFne9rkEbVEiSlO2upXXbE9EqVepPR9dHsi3BVpH479lzrvROC 2ZAhral6IL1Hj0ooCvqPLSoOsoUzRFUf7U7cOvPNJeN2FLyUuuoBP4atshn+GI30 LD67etl5gxgPJZA+wT1828ljTmzaGdTSRVV0ShLgjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduhedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelfeejueekheekgeeitdegkeek leetvdfhuddufefgffehffehueevvdeileefhfenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 14 Sep 2022 02:40:15 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag Message-ID: References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bgslkJ80w4A3ITBd" Content-Disposition: inline In-Reply-To: <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> --bgslkJ80w4A3ITBd Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Sep 2022 02:40:15 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag On Wed, Sep 14, 2022 at 08:36:02AM +0200, Jan Beulich wrote: > On 13.09.2022 19:22, Demi Marie Obenour wrote: > > On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: > >> On 13.09.2022 16:22, Demi Marie Obenour wrote: > >>> On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: > >>>> On 06/09/2022 10:52, Jan Beulich wrote: > >>>>> On 02.09.2022 04:05, Demi Marie Obenour wrote: > >>>>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be s= et in > >>>>>> a CPU register to enforce constant-time execution. Linux plans to= set > >>>>>> this bit by default; Xen should do the same. See > >>>>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for det= ails. > >>>>>> I recommend setting the bit unconditionally and ignoring guest att= empts > >>>>>> to change it. > >>>>> I don't think we ought to set it by default; I can see reasons why = kernels > >>>>> may want to set it by default (providing a way to turn it off). In = Xen > >>>>> what I think we need is exposure of the bit to be guest-controllabl= e. > >>>> > >>>> We absolutely should not have it set by default.=C2=A0 It's a substa= ntial > >>>> overhead for something that is only applicable to code which otherwi= se > >>>> crafted to be constant-time. > >>> > >>> Either Xen needs to set the bit by default, or guests need to both kn= ow > >>> the bit needs to be set and be able set it. Otherwise code that *is* > >>> intended to be constant-time has no way to protect itself. > >>> > >>>> As for why Xen doesn't enumerate/virtualise it, that's because > >>>> virtualising MSR_ARCH_CAPS for guests is still not working yet, so t= he > >>>> feature can't be enumerated yet even if we did support context switc= hing it. > >>> > >>> Intel and ARM64 guarantee that CPUs that do not enumerate this flag > >>> behave as if it is set unconditionally. > >> > >> I'm not qualified to talk about the Arm side, but may I ask what you've > >> derived this statement from for Intel? The doc page referenced by the > >> link you did provide (still in context above) specifically further lin= ks > >> to a page listing instruction with data operand independent timing. All > >> other instructions, as I conclude, have variable timing unless the bit > >> in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same na= me) > >> is set. > >=20 > > My understanding is that only instructions in the constant-time subset > > are ever guaranteed to be constant time. >=20 > Hmm, yes, I did overlook respective wording in the doc. >=20 > > On architectures where DOITM > > is not enumerated, this guarantee is unconditional. >=20 > I have to admit I'm suspicious of this "guarantee". Do you mean that previous CPUs had a vulnerability that has no fix? > > On architectures > > where DOITM is enumerated, this guarantee only holds when DOITM is set. > > Therefore, it is critical that on CPUs that enumerate DOITM, Xen does > > one of the following: > >=20 > > - Ensure that all vCPUs enumerate DOITM, and virtualize the DOITM MSR > > bit for use by guests. > >=20 > > - Set DOITM by default. > >=20 > > Since Xen does not support virtualizing MSR_ARCH_CAPS, vCPUs cannot > > enumerate DOITM. Therefore, the only secure option is to set DOITM by > > default, so that guests do not need to be aware of it. >=20 > I can see where you're coming from, but I also agree with Andrew that > the resulting loss of performance is a counter-indication to making > this the (universal) default. What I could see us doing is make this > both Kconfig and command line controllable. How large is the loss of performance? Linux seems to be setting the flag unconditionally, so I think my point about guests needing to be able to ensure the flag is set stands. The default can be changed once Xen gets support for virtualizing the bit properly, but until then unconditionally setting DOITM seems to be the only safe option. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --bgslkJ80w4A3ITBd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMhd1IACgkQsoi1X/+c IsG/oQ/8DcA7imP7bfjLWFNg9k81RRhAotJU9/MQTs0AfHRB87UC0mkuMBt1FkX8 2Q2SH6x+YBKoCyW0+4UC9sDq77yoh9M0AWvNJA+maavqppvsL9bVa9K+iBbSYWsz pYTOlE9JxKgxGJbIM6F1fvMnBnmEuafb+8HLj+S8JkkE8SMn7tiW4T4NSXw+djvc 861PrYtmRZonumLCYHAF6IXzRTgT5vA33zpUAJqYydTOT91IOu7SDM5P9epwENnO hHKQTYQEB7ZCCi9pa+HwvWAysajDRfAe5yphQzoasxNmTsNSgfEMN995vhbfpMet is1Vfj7hJBIOUO34tFviEt0dzvUXuJORuCPJ2PPkcahoeVG6fU/Wz8olKBH98iID ylzzy6OTt/lZ9QX7/VZhDPDzugRHeji5hZOEro86JZqfky6pH1kMANal6Quqatpx nKXPOhs9Mcmsk7OuC/u9H7/OgSz0UcKPCRjbLr48UlsO7aD/Z0Ap1YnUIYUkt0li c4CygO0O8IzM2ydAmEm5YOU1jAn8fugcvB0uW2J6SzQbQvfpteXvlIOwlrw6oVy5 b7eJu+vFFIXo/Ckw50WcsjwDCnJGEMHnXbpmUJ4zn07WviigneASbEph3ptCTc2u KHRRVcjrQWkK53etRk9EeGY/STYaFfdlLOSE2RnZWEa4CqJCBNw= =XNCu -----END PGP SIGNATURE----- --bgslkJ80w4A3ITBd-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 06:44:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 06:44:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406785.649155 (Exim 4.92) (envelope-from ) id 1oYM8O-0002vB-52; Wed, 14 Sep 2022 06:44:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406785.649155; Wed, 14 Sep 2022 06:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYM8O-0002v4-2J; Wed, 14 Sep 2022 06:44:32 +0000 Received: by outflank-mailman (input) for mailman id 406785; Wed, 14 Sep 2022 06:44:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYM8N-0002uy-7z for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 06:44:31 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10061.outbound.protection.outlook.com [40.107.1.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aedb5943-33f8-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 08:44:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7737.eurprd04.prod.outlook.com (2603:10a6:10:1e5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 06:44:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 06:44:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aedb5943-33f8-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=efQVeguR8UUiN4yv05XBSv6+aX+8EEQ4CBU3e+cP+1GlcQPAerNvcnmJ79pUBaIl1YXP2XoggrUgA2QlYvTqIBgnH3u1cLSfelw2U3OIRjazEA6Vlw+07xhARLkTgr1DglWpknBv/EZ/Mu1np5DDbTvtmzWfEKJZjKUZ9WwVhw1xnTETfSOVBQWRXu3QXgrrh4foBfhgorxpWHxa4Bo0sbvZDMFPGGI6Snmb42RYUFWHMJ5Yyh38pIiNyG0cXSpt+fN8xhFKO8EG8z8y00RJVxOa+CiRBR4d+OsFLnLxnBXPVQUh1nhnQh7xh2p54XnDm8HeRCPiZB3jZuGeDzMNQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HYaNcawrhpuZ47FaJSjbasxEWLPRosz4mIU8FFPRdNk=; b=BHqXAAEhVzTsHSL5te+hK0td2LG8oEGWKaqZuq21ewH4qx1Nkc2O5BAjqPw9sEUX4XOUVfr/rs9FRpSnbEKsVRWE8Njs7JJZdmyj+LQbHCs/wYJu79/R6e14iRmf9XZYGAr/SS/H8m46RMXcklPCya5JjGZtb4edDeVH/6ukK4XI6CJ5SCXf6hZLS/bQXojnWzEBvtj3lIrcDBDE9EVqzJuBWz3/qbcAB6briep8mbNRTDVWeWfCzFp4D9W9Sqp+/HQpcqvINeaR4ZL5liSzS9LrneHTrkpv5NVn/Qe33hNYHlM6Q3HKk12XfpXrhIcbIv3sDuUUGBfpravhVC0acA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HYaNcawrhpuZ47FaJSjbasxEWLPRosz4mIU8FFPRdNk=; b=pKDFneloNzUZXto/HOovEP/Z5sxdYzsQA5pr4UyEYtXAPoX+RtNrW7iF/2O1uVuhCsPiMFCaYb70AwsXLKKr63slbErvuvU9d4rNploBGFzvWLYC0dNKHaD0WGl9XhKEcws6KD+PFTJE6psGQrcO38WtvyzI84QLBNRtdv1v4NXU8fNSkAHzQTwYR9sYuVX1gfIGCdtlNf19AlGrLtqeYAxiYNK0cd6tOyZREsP2Fcy9N+RGu229F1+gB7m49j2urfLDqEZl/cK6MyD7stfRZ30rxvK4i0wM+1KVtgBs2vjfPKhN1M5FVWQRjWzRghTi/bd9uq74I8AmGlmUPPtUxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <62f0ebdb-d06b-f361-40e9-711258c03a56@suse.com> Date: Wed, 14 Sep 2022 08:44:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Setting constant-time mode CPU flag Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7737:EE_ X-MS-Office365-Filtering-Correlation-Id: 48e8a0f2-4fa5-4cfc-7884-08da961c9145 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9v9hvoj+Wnw00zNDnPVUffybtB7VpiTUIQCWHxgocIqkwy6zaAvf20nJMsF9wvznSm4jDAXJnQemgODpzCR3BFLQAHD0wZCucSNETec4eDVvjclTxMu86lS929mSDbSs+iNZX36RV4/n2H2SJ497FOPCxAHQU00bCB/6j9mZby6wxl18CS9Uvdsp46OlME0ue0bSj+ejLeSg7IDMa4I7Ij2Fh8+T/MCnnCMQUo70DdCrfeJE+W6mCnY4fC/5Ddm7Pe3+B+1Xw2sRIpxTYEQD7XF1su5r5KswuM91gk6LBgiAWXjlt83ys3hS31wTNGG2eY9tJw0kzw6mmrPPBegjrZwC5HgoeNEY6bpR4G/HsK/IeHClcXr5ketu88YHQvQULpyVA86DhnKMaXQ89/anRQadI2SqWIbNh2PO9m3boejwPbzhALIGb3KbeSkzkx3gk64bB3NdMlcaExZUIDT8nW7PY3I7HfZcKKHU5mlY5NOlZSZKB1LfGkejvodcSBPUouGkAks8yPPO55BFwr28MaNPuViZ/AvW8WchduNONxJXqsWvNxBDkT+xE3yxqb7Jcs/XfeWGR+ziFlY6KM/kfJTGZvcyuHSgGRXcnTzbqzuPOHi8khXKLnVHIqXGhbtpo8B0e5DfdAbYQoMp54WMnZywF/Jp7OVObyz7PQlvWnYsA91LKB8jv8NMZe0YB8xwG/1IZZjF99NCJRx6YOT3peGDMUOx+tSNUw3u6UCLc6vm+FNqk7y0jKeEw4UMmFOdjnTm4TdtcT5YfFohEtv2fh179KfbFDXOXaurifS5OgwVRa9gNBvhi5QqvtLGHabsx30V76XlJ45JBbBA+lVrGw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(136003)(366004)(376002)(451199015)(83380400001)(186003)(2616005)(38100700002)(5660300002)(8676002)(4326008)(8936002)(66476007)(26005)(2906002)(966005)(66946007)(6486002)(478600001)(316002)(6512007)(41300700001)(53546011)(6506007)(66556008)(31686004)(6916009)(54906003)(36756003)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkRtc3dGdEpPdDZEUkpPYWpPQU1nK0tLNzFicVZrRVNURkpKUlVWWjdWZUF2?= =?utf-8?B?Q3RtanI3RGhFRG4ycHNnRjFZR1c4RW9xTEg4UFc2MGlXUWpqdnZSR3U3c2xF?= =?utf-8?B?RHI5dTd3UStXTlc3Q3ZqaVV5Z2RLSUs2VXFXaXY5YTEzSXZpUlZ1Z0x2dStS?= =?utf-8?B?UG5kdndHekVHVWhDeStZYkk1VWplZGhPbWRTTk9Bd0tnV3FLM1NkaFUzN29D?= =?utf-8?B?WVpRVXZDWCt2YUZGMGRucUlSc3QzK3lQbjIvZUhaTGhwaXRnZlpIb0c5dzJ5?= =?utf-8?B?VlhpR1ljZkRuYm5PeFJKakpzOGNtS2RCSHNFS0VxZm54VjlXWTR2SHdKM1Fv?= =?utf-8?B?UGZQNXc3QzRxeVlYeDkrZHhSc2F2M0Y2NHQyQ1VMeHZvVUF6eVc0dWxPa2JV?= =?utf-8?B?Y3k2aEVXT0hsNTNXaUE4T0wyL081UFVlSDNDeVlqSmdDWGQxei84R0tXWW1i?= =?utf-8?B?d3RMWFFDcUthYzhwcW5iR1EvZUxYRnVwamEzZWZaejRuZ0kvbmcrTmhyYjBh?= =?utf-8?B?eU5zS2E4Z2ZsVnZMb0o3d0hkNFFLb2F2TDh1SmVBMkVmYkFPWnFKNkJ1SFY2?= =?utf-8?B?ZksxY3JuQTFvRHU0MFpPNkNMNmh3U0k0dlB4RmFSSXRuSWt2Q2FWOWdZN2dJ?= =?utf-8?B?M1U4ZFNha0dWcU5jL01KeXBpdTAzdE1yNFdkVlVreGRSOFZudDlrYmtXYVRt?= =?utf-8?B?VWw2NE5ZVWVDWFZhS250cDJxenArVml4RjJBZnpRZW5WU2hYRERkZ0RYWDIx?= =?utf-8?B?YXBLRldYVHR6Rk5ZWUU0VzZERTZmeFRlYjJjWEZUazJPWjlNVnV3ZlBzc0dt?= =?utf-8?B?SVlUMldGMkFaa0Zhb0tGSVVuT1U0OStiSEdwNU43SGVJcjZYVEQrMnp4OHZO?= =?utf-8?B?SFQ3cjdTdkd4RVVZc3lMUE4zTUE1VWtTK082YkZCa081Vkc2QXhMY2pqTEp1?= =?utf-8?B?UE5ES0plNFdiWnY4alA4TjlFRFZsRmxCcnpmMm9nbnpuZ2x5c1hRQ0ZWT3li?= =?utf-8?B?K0wvaVc1ZWxqMzhxKzB6QktBUGFISW56TzNhUmR3d3ZoRjB2RTZWUnNFZVdw?= =?utf-8?B?bWl1M2trV0dxb2hYVWxBampTeTlTWDNTcTZ6VlkxRlJtMjE0dEJCNlBFVGdt?= =?utf-8?B?dnZkVUcxT1hLRVBWSVc5MnAzY3J6ZHNzVGxLWFErWHVUNTh5SjlHczdRYytM?= =?utf-8?B?SVo4bVJaenNjYmNVRnFuMlhYdUhubnBzU0N0OGNIVXdrWGU1RnljK1ZlSU5K?= =?utf-8?B?Y1pSdHhKTEtic1pSREkyNHVnTVRKQWNrOVdPQjRjWU9NQTVhY2R4YnpSOHh0?= =?utf-8?B?cmNzU1czcklEU1hwanhjYWlrbDE3Z0xPMWIwV1NLL2x1WVdwOFBCa2YyVU95?= =?utf-8?B?VnNWN2o4cDhIYWxCRXJyRjVaYlQzdVVrODMwVTczcE5yc21FbVVaemlGTkN0?= =?utf-8?B?bW5FOFFVZ3BuK0VnWHRmSXBBWW5CQ3d5bmk3RHJJSnhpTndvaVc1bzhTOSs2?= =?utf-8?B?T29LV3FscjQvSjI1Wis2MnR4OE5BaDRleE5CMzZxbnROU2xSc0RLTkhRL2R4?= =?utf-8?B?RDhQYXYzRStQNDhabFhlNEdQb09tU2J0MzhRZDQvTXZUMHFEbU94NWJOMnpV?= =?utf-8?B?WHB4amhuVUp2Qkc1ZjUvbzVZUmNXcCtYVFA1aWFqQlZOb09VcnowR3d0czZq?= =?utf-8?B?MTFuQXVVQjdIWkNTV2xzYXJwTnNnV0xzaWxjaFJ1YVpEMmxhUVNyQXF4N1Rj?= =?utf-8?B?b0NnZTFQRXVvZXBIdkxSbnE5RGtnSC9lSDFJbSs2azV2Mi9YeFJyODZZR0w4?= =?utf-8?B?ZGZaTUpDSmZOVXhpaGtxQy9sam8xVDNUVUpyQ0R3R01oMjcwaEgzTEg3Tk0x?= =?utf-8?B?bGJsRjluZDZ5UUkyM0xZcDFmeVJEU1VBNU04T3pUcHFHMWRnVTNPS3U0dkF0?= =?utf-8?B?c3Azb1pkc1VJK05kbVY1dEx6ZjJRUnB6ZHlxZFloNytmNElMUm5xbmJCanJD?= =?utf-8?B?YkF4M09KV1RoK1VyZDJ2VWxNUXVCejQ5MHdMZmpacThvZDd5ZDJveFRndmdr?= =?utf-8?B?cVRUSFN5SXVmU3ZTR2JzR0dkc2Rpb1VHY0dtVVkzc1AxUGFncmlzVk5jbkVD?= =?utf-8?Q?P8NaREFa6EpS8iwzgkkokA1uk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48e8a0f2-4fa5-4cfc-7884-08da961c9145 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 06:44:26.8564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CkkOd3rlFFJNdPtJ2Y5vDSeL8MNAyyElxB9v0SYZNZHP6hlyI0ZtG7XsAfcJNCEvZrRVC3o7CIq7yRIguOiYAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7737 On 14.09.2022 08:40, Demi Marie Obenour wrote: > On Wed, Sep 14, 2022 at 08:36:02AM +0200, Jan Beulich wrote: >> On 13.09.2022 19:22, Demi Marie Obenour wrote: >>> On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: >>>> On 13.09.2022 16:22, Demi Marie Obenour wrote: >>>>> On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: >>>>>> On 06/09/2022 10:52, Jan Beulich wrote: >>>>>>> On 02.09.2022 04:05, Demi Marie Obenour wrote: >>>>>>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in >>>>>>>> a CPU register to enforce constant-time execution. Linux plans to set >>>>>>>> this bit by default; Xen should do the same. See >>>>>>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. >>>>>>>> I recommend setting the bit unconditionally and ignoring guest attempts >>>>>>>> to change it. >>>>>>> I don't think we ought to set it by default; I can see reasons why kernels >>>>>>> may want to set it by default (providing a way to turn it off). In Xen >>>>>>> what I think we need is exposure of the bit to be guest-controllable. >>>>>> >>>>>> We absolutely should not have it set by default.  It's a substantial >>>>>> overhead for something that is only applicable to code which otherwise >>>>>> crafted to be constant-time. >>>>> >>>>> Either Xen needs to set the bit by default, or guests need to both know >>>>> the bit needs to be set and be able set it. Otherwise code that *is* >>>>> intended to be constant-time has no way to protect itself. >>>>> >>>>>> As for why Xen doesn't enumerate/virtualise it, that's because >>>>>> virtualising MSR_ARCH_CAPS for guests is still not working yet, so the >>>>>> feature can't be enumerated yet even if we did support context switching it. >>>>> >>>>> Intel and ARM64 guarantee that CPUs that do not enumerate this flag >>>>> behave as if it is set unconditionally. >>>> >>>> I'm not qualified to talk about the Arm side, but may I ask what you've >>>> derived this statement from for Intel? The doc page referenced by the >>>> link you did provide (still in context above) specifically further links >>>> to a page listing instruction with data operand independent timing. All >>>> other instructions, as I conclude, have variable timing unless the bit >>>> in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same name) >>>> is set. >>> >>> My understanding is that only instructions in the constant-time subset >>> are ever guaranteed to be constant time. >> >> Hmm, yes, I did overlook respective wording in the doc. >> >>> On architectures where DOITM >>> is not enumerated, this guarantee is unconditional. >> >> I have to admit I'm suspicious of this "guarantee". > > Do you mean that previous CPUs had a vulnerability that has no fix? I'm not sure I'd call it a vulnerability, but at least if going back far enough in history I think you'll find insns on the list which don't have invariant timing. Like with other documentation on e.g. speculation issues I take it that Intel simply doesn't consider sufficiently old CPUs relevant anymore for such new documents. >>> On architectures >>> where DOITM is enumerated, this guarantee only holds when DOITM is set. >>> Therefore, it is critical that on CPUs that enumerate DOITM, Xen does >>> one of the following: >>> >>> - Ensure that all vCPUs enumerate DOITM, and virtualize the DOITM MSR >>> bit for use by guests. >>> >>> - Set DOITM by default. >>> >>> Since Xen does not support virtualizing MSR_ARCH_CAPS, vCPUs cannot >>> enumerate DOITM. Therefore, the only secure option is to set DOITM by >>> default, so that guests do not need to be aware of it. >> >> I can see where you're coming from, but I also agree with Andrew that >> the resulting loss of performance is a counter-indication to making >> this the (universal) default. What I could see us doing is make this >> both Kconfig and command line controllable. > > How large is the loss of performance? I have no (practical) way to know. Jan > Linux seems to be setting the > flag unconditionally, so I think my point about guests needing to be > able to ensure the flag is set stands. The default can be changed once > Xen gets support for virtualizing the bit properly, but until then > unconditionally setting DOITM seems to be the only safe option. From xen-devel-bounces@lists.xenproject.org Wed Sep 14 06:48:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 06:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406794.649165 (Exim 4.92) (envelope-from ) id 1oYMCI-0003cy-NM; Wed, 14 Sep 2022 06:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406794.649165; Wed, 14 Sep 2022 06:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMCI-0003cr-Kg; Wed, 14 Sep 2022 06:48:34 +0000 Received: by outflank-mailman (input) for mailman id 406794; Wed, 14 Sep 2022 06:48:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMCH-0003cl-6E for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 06:48:33 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00075.outbound.protection.outlook.com [40.107.0.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f49f5d9-33f9-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 08:48:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7895.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 06:48:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 06:48:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f49f5d9-33f9-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ls87wXN1SGxWypdEX8bMwE7HM4mN/cQgJUTzG9+6q+diMQ1n0O78s/4y47pGMTTX6ZFCFvxMLu2tHpjFPFiEJqlzMJi/uXH10YNo7bp0SJzkm2fdJ5nPLWr+1ufw4BmoYqOdOECiEl93HmJ0Xi4+HNpHdzc863YdI2N3FuJ8z1ZxZ37lncBcVu9vJZIuzcDIRv3EF05k0q+QLKK6PdDVNQGXXB2qoTFmYRetrNGk+4wUfRd0RTxJcgm3AdOJigsHLm00IU0R1LFf0OGAwqvn3uhC2pgxNaLHR17exOxo1cLrxsdF1xRUB65qH2ZCJcxsFfzaxJtHTPzdwTNkRuRH3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MNPbNEW4AISYA80cv1dDTg7APdR8JQdtJuymlONKBrA=; b=bU+3BZ3NoV4KqirBUvIncYj/DqFioZp5Z0LboZiM1aAS3jHr1EDdSz5S+7l56P5W/CTZaUR4GTxsUWS2xIgs1YOCGbvrcZx5D93LTgJbr6ieFQAO9se7tIyXc52GOlWhl2ZefUxFzgvPllEfb72annELnrL8BCEHb+foH1bGPib3Zwi2dZTS7ZIWrYKerCno4gGcNd0YLQgqPK9jgyO3dM64jRHOUCvuiQ0EP/Y7x04yP+774o4aHl0lU6vvSE6mlZSaKvTDlI+bdI2ut4h7OkcUfaE1EHo8kKZqOTzrxUadHZBmohfjBsA89GbEcjwXmPz4lcG2T7goe2GElR/Jlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MNPbNEW4AISYA80cv1dDTg7APdR8JQdtJuymlONKBrA=; b=wWA2oHM4IAoycgTRRj02G4PrvLdFEfL6nfOIuWEGBmjhug23ISYaQZVPkPhlxE5aa1HP49ZKZEYh+ZOZ67P7UTcbVFxGM7pImX2oO0SlLIaZk45XwUrygkt8HN5IPz5cBOkATEcZF7k4Nj5nJbGm4Ze+QGNChXfSE+BSIuvs3XlvrlFvN0DhGRlp3LpscQtaMVKaMkXO2YIcQFbnkyFpZb4NU/Q1nO7xi7FlAj4NsiusgAtAFH5z5TP6A3sHO2DpVy3BhwaQwSz9S3hEcn034n1H4C8YyGm7ZUaN86IMnJtMIhCCKpha3cQu0LFaOrOEdKb7hTgQytnIJRRh1IDpsg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> Date: Wed, 14 Sep 2022 08:48:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Linux pin_user_pages_fast fails on Xen Content-Language: en-US To: Stefano Stabellini , "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" Cc: "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0070.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::47) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7895:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ad500ea-944a-4d26-bf7e-08da961d21ff X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4zEVxgorSq9bxQ2SY+meoG29aV4r5YEailBbMT93qS8g6VsEUWtk+/qykZKdSLyhMCqKNzd8wW3/kNJ4Yi9AxzwREJfKG+7hM8D2hZ1E089frLqza6f4aKywzK78Mkw+FtfvDJPokLGgTO6Juh0C83dUHiBhWvxWhCAMn+bJa4yo+ICU+HVjN6rYt9Iy7zwzFI9b+zbb0Co9SzmDOiAFzthtCiPMBWVz/IiiN18tmes9QeEpS9mazrNOFaAnfUPQoo20CV3aX4s+o5tya88mIO3jMWdVZjzrWeU1/YdzzPCE1czQCsE0jeeb4hUNhm1hkmnL0QXg5Ch0bzWBXdCJJmbQXxpmynCg2m55aM5UYk7HAitY2EgQLq8jwaJJ4PvFcSLNOpoZIWXKMBaKkVp48ttAzggqP1k/dA6GFFzEgvGAyk4Ugzx5tzPB5kUK6nLnPUINN62Cbyp3XMqxxw121jyTQZrYdw8hnmCygOIA3ThDZtvb758rPjF0/iw1LWWigE0xmqpq3dmMANQ52e7MoMk6iR1sHZ7uthQKl/G9IPCGyzjyrPuabJtd6Ew2a3ZaSBy9uv9yTq6q0JwaElLGpwjvNVnoiXZzguXE47E6XVEKGJCCejcWAk1Vrl3qs39EVEHdesiIszYDCNclwZUod1YoPnoJK0G1XodhfZ3Q+sVC5gImiRfyDklWFPyl4p8x3b0051ylnnM9A5jd5NHsNXwPsNbxaNLdIa488mBjsYiEarqVTzXXNtdHsgjToB/BV8KhhSCf2Mh5OjKNh/hMB9WYOdXu0l+EdPQUxhH1g4Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199015)(41300700001)(86362001)(478600001)(6506007)(107886003)(8936002)(31686004)(66556008)(110136005)(4744005)(31696002)(316002)(4326008)(66476007)(8676002)(2906002)(54906003)(2616005)(5660300002)(38100700002)(36756003)(66946007)(6486002)(186003)(53546011)(26005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk4wSmlOaFB2UVpFckVNMzcxVVpvUTF2TUIxZHhoTnFaNE9IemNEdEpGbjdu?= =?utf-8?B?NmpreWFhdkRjZCtmRklzbTF0c1VXdmhtYytXOHVneG9hc01oVml0TTlvTVFv?= =?utf-8?B?WTJhNXBLMVB5WWFoVEtNQnNSamFINmt4RDJkbG9tSmJ3ajd1MHY2aHliMkhz?= =?utf-8?B?SVFZZW5mbmtLWGFEUklRUVJaWjJBMlRWVlVkMFQ2YXpXL2dkK1lvMkgvdE9q?= =?utf-8?B?UERtWFBQZFk2dWVzNkl3cTMya1Q5YjFHbXM3SlR5QUFzQXFLdlpUOFI0OWph?= =?utf-8?B?NlBnWU5ybmlZZDdjMjdOTnJucm9lNEgycHVjeFBwYk5YZ20yam01b2c3VUV6?= =?utf-8?B?aWtUd0Zxelg1MjVCc0taY2NCRDE4a05GUjZDM2ZJbHFjRi9yMTBDRGw2RDhF?= =?utf-8?B?aTlLNjUzZmtIVlNxUHhJY0V1YVZuMWg1cmZnSUltRXFZR2JLV3N2SE9QUVV2?= =?utf-8?B?ZzRSZGN5MDVLRGV4TUZZYXNtOVVzUDNnOFJ0Q0QyZ2NNTXo2NzEvVE1ZS1RR?= =?utf-8?B?YWlLQTY3MWNpSEtma0wyT3pwWHJCRzhXZlNEUklEb2o5VDZaTjJOOTZhMDR6?= =?utf-8?B?K2ZXTHE5cnhkYkF5MGpaMC9YdHVybk5GVVFtVEphQ2N5Z2d4bVF4aSs4SjI3?= =?utf-8?B?Zmk5SEpFWHozSDJ0K3RQQ05EQUlNWlVvUWRvRGI3bG8wMjFzejFFV0dwT2pB?= =?utf-8?B?Z0kzTzlzM3gzNXJDRGRTSHB4b1Fpbk1wNkFSejFvUml3bXJ1WWg3QzFCYjBa?= =?utf-8?B?YlZrc25UUEl5ZzZjcU1xZHFLUkFhL2xURGwyaVppczlwRVdYbXhobnFZTE1W?= =?utf-8?B?R3ZkMkJVVW10WEZXQ0txMFZlc2N2RVNoZ1l2QklLcW1nbUV6eUlWeG1XNGxL?= =?utf-8?B?cHFpdG5aQmM5NGx4VVdSckZTMWxRTDg0Y3JlUzAxb2ROOWtaZmljd3J6aG1G?= =?utf-8?B?M2w1ZHJFTGlIQ3k0alcyeHk5NnNIZFUxanpnNE9CWXY0SEtkNnFYWU9IRFBH?= =?utf-8?B?WmtzWkZJOE5xTVlTTkQvTE1oa2pmeVlVK1ppUThFRC9CM2hmemJxZXRKd0dT?= =?utf-8?B?WTRCRFo4ZXowMWRiSVJQTG5TbFpYcHlqL2VCVjMyT0YrNTZoSUxjayt4T2R2?= =?utf-8?B?bmhHQlh5eS9pQXBqaUFBd2Z0RlNJcDc4UVpYeVJHNW9BazFiMTd6aDhTT3Uz?= =?utf-8?B?UkhOcVVUQVRVV2RuQ1hFM2J1d04zbkM3eVRMWXBhRHhRajQ1T1VaaHlNZTcz?= =?utf-8?B?RzdSUFNaNEN3OXRWRDk2bFZ0ZjFNeHJnQ1BjRHBpbmI2L3FUVVNkbUVMVkZB?= =?utf-8?B?cngvWkl1Z3FpTkp2YU1pM08yWFdMcUZDT2pBdUl5MXZiQjhRYWRHeTdlUE9o?= =?utf-8?B?V01lRTdSQlNoWnBVaDltdnZnQnJBV0pHRTd3bHNlWm5HZlZ5R2JySHN6cnRB?= =?utf-8?B?Q0czbkJ2SDA0Tmd5Uk02dXBtNzdzRzlkUThVVDIwSDBQM21MZWgyZVZYYmI0?= =?utf-8?B?cENBRWEyS1FTMUYwSmw5MkRhNWxodU1jZmFMSytUaVBBcU9XYnJGVU9aYnF1?= =?utf-8?B?TFlrZnBYUHc5RWlmZUNXSnJpMTdwMk1tazJLemJPa2IyUWdRK0dnT3ZIdTVU?= =?utf-8?B?eGpPTlJ3VUZDZ0d5YnlYMGVWWTVuanlPZHg2RmF0TFdhcEhSRzkxaktmdUhx?= =?utf-8?B?a1BieDNqQVVFdWd6ZkQ4VlBVS2g0SjcvVExzSWhMUWdiOTFtVXZ3dHBFVzVX?= =?utf-8?B?bkZRdlRQZUZiUlBnWWR3ekY0Z2lxaTA5RWVmNkkveUFQbEZIYzk1YzdNRmxI?= =?utf-8?B?ejN5aVdpTUNxQkh3ekw0ZXVSeWNxd2ROYWNxaTJFQ1VxK2F4Sm53NkxiSGcw?= =?utf-8?B?RHA2N0lBYzVtUDJHeFlUUFFIUVNhNW5xRU1ZcVpXdTBQQnh0NTA3YmlDdlFz?= =?utf-8?B?TXVhUHFBc2pGMlRaQ3M1RlIxTlMvL2kza1NqWW16emNMUThpSVVpYUo0UGtL?= =?utf-8?B?eDBpR1QyQnZYNWMwSWVxdEtjWm9ONS93UXBkeHlzWWJkcE8rRzJNdkptNzds?= =?utf-8?B?S1NpcEJBUm04OHpXRXAxTEp3dXRMUjBFejhCR2Q2WEJHSm5lTFBWVHRiZ2Na?= =?utf-8?Q?kMbgix88uN1uXs/VXSMVjTXSi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad500ea-944a-4d26-bf7e-08da961d21ff X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 06:48:29.6535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7L+Ls3KD9ScAX4vQWEbms4iwEpkzeRJqKyIuhC9iNP1KGl5UxtAmsa2TgysI638CbTrfU4XbEBkXUgfDDlEtAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7895 On 14.09.2022 01:31, Stefano Stabellini wrote: > The problem is that drivers/xen/privcmd.c:privcmd_mmap sets VM_IO | > VM_PFNMAP, and either flag would cause check_vma_flags to return > -EFAULT. > > Do you know if it works if you remove VM_IO | VM_PFNMAP from > privcmd_mmap? My Linux MM knowledge is certainly rusty, but I don't think this can work, at the very least not without further changes elsewhere. I did look some at the specific use by the TEE subsystem, and it looks to me as if their "shared memory" machinery simply isn't meant to be used with non-local memory. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 14 06:48:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 06:48:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406796.649176 (Exim 4.92) (envelope-from ) id 1oYMCb-00043k-VO; Wed, 14 Sep 2022 06:48:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406796.649176; Wed, 14 Sep 2022 06:48:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMCb-00043b-Sd; Wed, 14 Sep 2022 06:48:53 +0000 Received: by outflank-mailman (input) for mailman id 406796; Wed, 14 Sep 2022 06:48:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMCa-00041v-7N; Wed, 14 Sep 2022 06:48:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMCa-0007sl-3z; Wed, 14 Sep 2022 06:48:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMCZ-0004yw-CD; Wed, 14 Sep 2022 06:48:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYMCZ-0002IE-Bl; Wed, 14 Sep 2022 06:48:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=D2rS2wRpyyrM7vAipmJt+TfRGg29JnLZifqwKX/3hbY=; b=Lh4I1MkV8hNTVBrLnGHb2/qQ8p npPc0F1JphLOl1fNBxlWKe8hRrnAOHb6ZZBHEMWH46Lf3voLwYsA3TlyBtq1nTR65MYoXfg4Icx+b rMKSHoliczA0FrSVc2J8YSYvyrnZOOhNQbHA72y8C32GMrxjKnE+TbCGgRxcSfW3mh7M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173180: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-examine-bios:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Wed, 14 Sep 2022 06:48:51 +0000 flight 173180 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173180/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-examine-bios 6 xen-install fail pass in 173167 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173167 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173167 like 172128 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173167 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173167 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 41 days Failing since 172384 2022-08-11 11:13:58 Z 33 days 72 attempts Testing same since 173008 2022-09-05 15:47:43 Z 8 days 18 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 06:52:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 06:52:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406792.649187 (Exim 4.92) (envelope-from ) id 1oYMFr-0005ej-JF; Wed, 14 Sep 2022 06:52:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406792.649187; Wed, 14 Sep 2022 06:52:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMFr-0005ec-GT; Wed, 14 Sep 2022 06:52:15 +0000 Received: by outflank-mailman (input) for mailman id 406792; Wed, 14 Sep 2022 06:47:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMBD-0003b8-0B for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 06:47:27 +0000 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15dedde5-33f9-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 08:47:24 +0200 (CEST) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MS9lV2t1mzmVGh; Wed, 14 Sep 2022 14:43:34 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 14 Sep 2022 14:47:19 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15dedde5-33f9-11ed-9761-273f2230c3a0 From: ruanjinjie To: , , , , , , , , , CC: Subject: [PATCH -next] xen-netfront: make bounce_skb static Date: Wed, 14 Sep 2022 14:43:39 +0800 Message-ID: <20220914064339.49841-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected The symbol is not used outside of the file, so mark it static. Fixes the following warning: ./drivers/net/xen-netfront.c:676:16: warning: symbol 'bounce_skb' was not declared. Should it be static? Signed-off-by: ruanjinjie --- drivers/net/xen-netfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 27a11cc08c61..2cb7e741e1a2 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -673,7 +673,7 @@ static int xennet_xdp_xmit(struct net_device *dev, int n, return nxmit; } -struct sk_buff *bounce_skb(const struct sk_buff *skb) +static struct sk_buff *bounce_skb(const struct sk_buff *skb) { unsigned int headerlen = skb_headroom(skb); /* Align size to allocate full pages and avoid contiguous data leaks */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 14 07:11:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 07:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406818.649199 (Exim 4.92) (envelope-from ) id 1oYMYX-00088u-7M; Wed, 14 Sep 2022 07:11:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406818.649199; Wed, 14 Sep 2022 07:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMYX-00088n-4Q; Wed, 14 Sep 2022 07:11:33 +0000 Received: by outflank-mailman (input) for mailman id 406818; Wed, 14 Sep 2022 07:11:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMYV-00088h-FE for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 07:11:31 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 723e52f9-33fc-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 09:11:28 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 7DB2132005BC; Wed, 14 Sep 2022 03:11:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 14 Sep 2022 03:11:24 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 03:11:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 723e52f9-33fc-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663139484; x= 1663225884; bh=surybMSUyy8slcdQIfJp1hbkyOSBYEO9RZYrDRimR3s=; b=p upZWJr0YX577GGczG2cHf6tLTM/FxiqJYT9bNZEHo6tOube5JYJ0cTVMyiAWBcCo OcEKnliVyEkg2lrSyviyBOihVbigdeGnmph0u4zcEo34r5LhlxEF4cLWPDlzT5m3 iF+nvX4oI7Ht+HiPWK5hTgk6sjHgm8PMJONXEMyRn/618qZtw7p+uiTAadGU2fV8 /ty7idRNsQiAEmFgzt71/hb46TB73+xB0PwGWJjz/IqoMxZpDKZJFOpwvvpB+L22 BXfIqkdPwdOa0nBC+fXKbfTdA4Ps8uNqLV9BXnLxpnpfRF6GD/mfcwzZac/uz1P0 ocllfcjWPfpyKer0ApvXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663139484; x=1663225884; bh=surybMSUyy8slcdQIfJp1hbkyOSB YEO9RZYrDRimR3s=; b=ZsnL3CcIjh/mDMLFcjTLZmDsHsEiDhpbWZHLDJgkdRCm eHqrjLar0QSm/bJpF/4ASEanPT5ECWdcZHThZM8G0OgXjMJgbG5os/W9YjUR4WPQ c0+00Jzdiil8p7IDoAsyuYDvkd9dqxr7lofFz6YkLitaijpVoyPzmWjw4ULBoPZj 17YtJoOQK+gbkBXSrfjYhmcLLS0yDTRrMdc91dMCRAYXF332iT6S1MGGtYxm8sQv SraTh4TH2JsNtS3+eHnLBXIAXpLyC70pFSsqYbsr/zFEQ9GcprblFw31l5yr9Lkj cM2KlA+UgKoXRbOEZkAUR7HjvzQxxOOl2gl5iUH1lA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduhedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelfeejueekheekgeeitdegkeek leetvdfhuddufefgffehffehueevvdeileefhfenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 14 Sep 2022 03:11:19 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag Message-ID: References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> <62f0ebdb-d06b-f361-40e9-711258c03a56@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CD7E7MzccNHbMBkD" Content-Disposition: inline In-Reply-To: <62f0ebdb-d06b-f361-40e9-711258c03a56@suse.com> --CD7E7MzccNHbMBkD Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Sep 2022 03:11:19 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag On Wed, Sep 14, 2022 at 08:44:25AM +0200, Jan Beulich wrote: > On 14.09.2022 08:40, Demi Marie Obenour wrote: > > On Wed, Sep 14, 2022 at 08:36:02AM +0200, Jan Beulich wrote: > >> On 13.09.2022 19:22, Demi Marie Obenour wrote: > >>> On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: > >>>> On 13.09.2022 16:22, Demi Marie Obenour wrote: > >>>>> On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: > >>>>>> On 06/09/2022 10:52, Jan Beulich wrote: > >>>>>>> On 02.09.2022 04:05, Demi Marie Obenour wrote: > >>>>>>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be= set in > >>>>>>>> a CPU register to enforce constant-time execution. Linux plans = to set > >>>>>>>> this bit by default; Xen should do the same. See > >>>>>>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for d= etails. > >>>>>>>> I recommend setting the bit unconditionally and ignoring guest a= ttempts > >>>>>>>> to change it. > >>>>>>> I don't think we ought to set it by default; I can see reasons wh= y kernels > >>>>>>> may want to set it by default (providing a way to turn it off). I= n Xen > >>>>>>> what I think we need is exposure of the bit to be guest-controlla= ble. > >>>>>> > >>>>>> We absolutely should not have it set by default.=C2=A0 It's a subs= tantial > >>>>>> overhead for something that is only applicable to code which other= wise > >>>>>> crafted to be constant-time. > >>>>> > >>>>> Either Xen needs to set the bit by default, or guests need to both = know > >>>>> the bit needs to be set and be able set it. Otherwise code that *i= s* > >>>>> intended to be constant-time has no way to protect itself. > >>>>> > >>>>>> As for why Xen doesn't enumerate/virtualise it, that's because > >>>>>> virtualising MSR_ARCH_CAPS for guests is still not working yet, so= the > >>>>>> feature can't be enumerated yet even if we did support context swi= tching it. > >>>>> > >>>>> Intel and ARM64 guarantee that CPUs that do not enumerate this flag > >>>>> behave as if it is set unconditionally. > >>>> > >>>> I'm not qualified to talk about the Arm side, but may I ask what you= 've > >>>> derived this statement from for Intel? The doc page referenced by the > >>>> link you did provide (still in context above) specifically further l= inks > >>>> to a page listing instruction with data operand independent timing. = All > >>>> other instructions, as I conclude, have variable timing unless the b= it > >>>> in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same = name) > >>>> is set. > >>> > >>> My understanding is that only instructions in the constant-time subset > >>> are ever guaranteed to be constant time. > >> > >> Hmm, yes, I did overlook respective wording in the doc. > >> > >>> On architectures where DOITM > >>> is not enumerated, this guarantee is unconditional. > >> > >> I have to admit I'm suspicious of this "guarantee". > >=20 > > Do you mean that previous CPUs had a vulnerability that has no fix? >=20 > I'm not sure I'd call it a vulnerability, but at least if going back far > enough in history I think you'll find insns on the list which don't have > invariant timing. Like with other documentation on e.g. speculation > issues I take it that Intel simply doesn't consider sufficiently old > CPUs relevant anymore for such new documents. Any examples? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --CD7E7MzccNHbMBkD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMhfpkACgkQsoi1X/+c IsFiBA//a1D+TXFlmwZYEv6h3uSCsG/cG/yuVbs9ISkcLg6zETnQPbW/4/yOfGjy 4f6ayvxgdoHwP6PljQbbHyrNnjm3VTinibBWWQwag+G9zZi08gRpiHScVkYeuAAT V4HT8ujRcZ9Qqh8xw5XofQcRcekb4cSCOKBcmIlw0a11AY7HKLZTp482ciZ2kUMV tot6pJldlTAWvfMF4OiZw5usbnWi2texJ5ShNkZBgSF/kf+14Cpo/Jw4CMtDGnIh eu2KF2cydLnSBU+JybU3VgI2xbt1YhDMOxMbwe+ctFlQxs4xpsysDcILnx6Jp/yk GGp15AZgf54U09pjwSobLKjbdpZiC8wvfr2VRF2+ZNOSq//eU438WUPuOK3uznlE dfi0UNSWSd2Kqfxms6SCZQ6t3RygeFVNtnEzAAj0jIAqOZcWC++hzkc8LSMx3jXx 5HdHCFuFSg1Y9QRqBatSXnt205iCXJDwSmlY3H8cZXGo0rZ2PJa4rfTIqcjfoths zmjhs9dWMnXZQTpTmlXrRV5ivM/SFdGpfUBDU7jFm7ubjxK818DvyeAQ6sxhJzH/ 5337Emu9ezrjeKplXQL9T+iXVTOf/wK0Mzgdv+YthZgpwvyVdWOVzbGIHyRwbuhC lUZZePZQsjrR/aoCH1ptXhWJjKQ/moQ6g3foEmWCbG4X2yNho5M= =zAVR -----END PGP SIGNATURE----- --CD7E7MzccNHbMBkD-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 07:32:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 07:32:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406827.649210 (Exim 4.92) (envelope-from ) id 1oYMt2-00029g-Va; Wed, 14 Sep 2022 07:32:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406827.649210; Wed, 14 Sep 2022 07:32:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMt2-00029Z-Sg; Wed, 14 Sep 2022 07:32:44 +0000 Received: by outflank-mailman (input) for mailman id 406827; Wed, 14 Sep 2022 07:32:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYMt2-00029T-8U for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 07:32:44 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150055.outbound.protection.outlook.com [40.107.15.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60794c13-33ff-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 09:32:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9469.eurprd04.prod.outlook.com (2603:10a6:102:2b4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 07:32:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 07:32:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60794c13-33ff-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWp7YDWzP/r7hapucOFYW0w5mbztWyxofd3w5UHg2srVAcCTc0A7gjyDOFB8ULEtOO5nsSiUHtVZKwd6cPqVKEpnlkwMBN0jQLg3l3LizirgL+FVvMAuDrRSpQiTgaRAjwqymxsYF04qX12TEvqLnQvH+SNS0zWpAqi1Idbd62oUDpz4NmsjgEtzALGKU283MKPUFxHtTg0vhh7ok83HuQ0UnmRn5m+aAnbbW+8Ldc3jQpn88Dg4keBuXDnZ5Oi7BAMpxx4s8edUd8jxVsw44yexZLaYpTX8kbhmxxR3DLoJY2S8NzkMY6hC5vWlOlf8q5Y7OzdlZYJjOJSf8MiUjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6VhwirDIUo3r33hIMDz5bvGs4vRBoNpPcNecpcQv3z0=; b=B2vrQeJdHfCxiKIS8dVkbUcRww34Xfoff3jllqWiwiTDzIaGapeH9H2yXLFyY9Y5kdZYhvdcFEjrNtMKkfnjZzzbV1Y8IvYDOPQmhp1LTYEa8SouaBhYT55WBmfdtPZTyzH4vv3sjRob7S2uZW4PYolIFfK44khX/BcxaPBIvLA1l71oNIvMTHLCAAO3Zm/f0naj1afU9NJNnfS+NaaVSNPHEGn3mdDLEyiVc796VMczsgTSSZ7GoDH8bZ6wrTfUbzgJIovPXzKiqvr0mQpdqbfzVrMC2R1QZxU7Er11+ft6PhSV09pRZs7lCmgek0cEbcdtsKQwWOi7zMUfwppZUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6VhwirDIUo3r33hIMDz5bvGs4vRBoNpPcNecpcQv3z0=; b=micZOSEKY9HWc5gQdJhGHKFAMDIu049HnWOVLmhLTFapc1jAY/tw17T2dCkLAF9YbcsNZalHc8Z/MPHrCLAm7OdUJFQGnfIbyEZLeWO6yvu7BeMUT+PS2v5vspd/NuemzBPEudULllOwd0A7D6Se196I42xlmKDQrLz3LJUUFsWQVZHTQfx9n7SikKXMA1KFXe5m0PLyqhtor8Z/nCPfs4IHnAXXfzhUxTCd4x89+113vK2y/jZMDbgSXjZVXmak0NhjuxXvTPMNGueSt9H0DqvssQgUAgozg4UAfkm6gH9dSpNT9GCS/3T630DS7SPl4tNMc08KI4Y17RRKprgjPw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 14 Sep 2022 09:32:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Setting constant-time mode CPU flag Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> <62f0ebdb-d06b-f361-40e9-711258c03a56@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9469:EE_ X-MS-Office365-Filtering-Correlation-Id: dde9e119-f94f-4496-42e9-08da96234370 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PVhbhnHV0TtLiC6YK1OhBiJknCFnpHjNwPASYiTajZLTHUsqb86nkcKjmK0SUzYnnYwIizHBb678us4oeiHnf+EOmDmFPM/uJuUDOhTxwZdMdEtV26QoBF5KluxUQcJ6+NqjbteiIt+l1lBb/3GZSKWcuNN5b05tLTn+BgxMYSeVeOvrdC2wwbfPkS/URwwjXD6hkhzMPQ2zsr6OYNbRjb6A/cO1nNcfxWcQ6nb7HTkL2Wue6jYSGaATwpAnPiP7e7IWaQZNGv2pSJdiu6V/I4RGecvqMomjfHode4HjwuuSw6lmv+SVbWOPNPhOKSWDtjjpm/Mq3nwbrGlPj+FWuWISkvzMwvWaogofjNlX4gKZboZ2CWdlcKIjDbwWZs5IN4G7fWIyVhrkzCl1TjCbmiHFnJ1QigMTtUxYMbfFmbQZ/gUjmn2yt156Ay1nbunVVV2E+wDNfhpE9M6ddSTiWVU/9uZfYNScqs2HMpejntk89N4YNfZkDIIr7nZi9e1SYfsk5s9rRiNmDW3XXD6oBzSoPDE15DyBljs5E20D7NHxRC+XmnsfVRH1bVUaXdlWMT0uBvamgGmjdahWz0XiOA6bUYEuYYbjwRVGLk2Sm00E2Ic061vz/YMgxjH91T0HVxtoHy37RPS5M/uctIzkGmPfblBWl8TyWKY1xSkMcsP1xFKLg3XP5XuVG5WlB8W8TnDw1ZJiDlzriDauHouTKzpBagyqz4QPk4qRXJobAFA0mXXI0fKiC+F8or7vJ3nd98rYP7sK4sJZ30C/QV/YNpYt88yzfKalz7UbSRuNSW1n6aelDMgVDIDDVb2iiUOOx6OHoPIQM5rnjtPsOEzDyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199015)(66556008)(6916009)(316002)(66476007)(66946007)(6506007)(6512007)(53546011)(36756003)(26005)(6486002)(5660300002)(8936002)(54906003)(86362001)(478600001)(31696002)(2616005)(966005)(2906002)(4326008)(8676002)(31686004)(83380400001)(41300700001)(38100700002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHBzeXdHRktpZ3dEQU04azNJVURHRDJjMmZZQ3Y1Sk8xZ3BLVDdRUXErRlAy?= =?utf-8?B?VFdBMDZTVkh1blltMCt6c3diUjREdUxiWDIwZmM3K0kvRitoWGczb2Z4VzY5?= =?utf-8?B?OXJlVWc1TkJpcHU4S2JNMmsxV2dMYzU5V2twZ2djN1ZWL0srREhvNi9yODRB?= =?utf-8?B?eGZEU1Zyb0hTVnJkcFh3ZmttMWhtczlvRkljSStEQ1dRRTBxbG05eTlwNndn?= =?utf-8?B?Y084UWdXUXRVc0tmRGlwTExidzZTcUg4TUZsOTlJWndGODBhL0F3NmV6eFlp?= =?utf-8?B?QTVEVVZ1S0gxckg3dEtxRGFvYWJ0SkJaUU9aWjBIRzlRblZJczNkbk5oZEZT?= =?utf-8?B?WTNZNHVyQzFEc3ViMDJJSGVzbW1GS2xZRkNheTVFMTlsNE5xVkVMMGFWak8w?= =?utf-8?B?TDNEa1AxVHdyYnhGZWE0aVNkUmU2QVhNbHJSZWl6VnBWeGw0ZFpnMmxnU1JJ?= =?utf-8?B?LzVmYjl4WERRVnJwQndTb2tFeXdxeEhlTml1N1hiY3djT0J4UGhoczUwOXNr?= =?utf-8?B?RlE4aE5WdEdqaUVnUTBzYVIvR1VQaUpCdGFpM052Q0JRaU5rUk9jRjhjeXJO?= =?utf-8?B?Z01jNWhqNmcrbk5pSVN2ZmNvNHZ1WklONkl4eWtJOEFHV3hvSWlQcGdtWGxa?= =?utf-8?B?ZmlZbnhjTVBsZnpZQldRcSsrdjZMbU5iS1l0SGRiN2tOeGE3aGhUVmxidFZW?= =?utf-8?B?SjVoZnI3dzdxUUFGNE1MSGdWd2NwTTdxNWxHY3RKb2kzZ1pKeVpFVmtkeW1S?= =?utf-8?B?L0wvZDNhWS9WSVhaV0J2UkhEdGlrUFlLNTMyaFE0a0JFeklnOXNpNU1pYXJo?= =?utf-8?B?eEswRmpyTmVOcDQ2UzFUZnhScURHNmtidFBjT2phTzJVbmJWbnZEM1JGc3pq?= =?utf-8?B?WE51elNJc0xrNHBjVVliQW4zaXJReXo2QzduWkUvYXZaaERLUU9zd3pyWVVM?= =?utf-8?B?TGV4TWp5NUNVZmFzWXlxWmlkRkFFK1VJNFlCWDRPdlVRK0ZTN2gwcVRpT2dZ?= =?utf-8?B?elR6ZnNqdDVoOTFGbUpqU3Roa29aRGpwem1kcjhCRlBxc0ErWnZ2Sk5RN0xK?= =?utf-8?B?VFE5d2g3UnFXOW91Zi93SnFwTXN1TkpYRk5oTUdhdUxpSG5HSTFBSzhNSWZq?= =?utf-8?B?Wkgwb1RHdmtHRnNNYXJvOFRtd0JudHlpOXlNRy9sQ250bjl0NE1FZUpVS0kr?= =?utf-8?B?VkJlNGhrMkRRTlRsc3UyODkrS3lla1NnQnVxUk1pb2c4SEEwOGd6UG1JOURQ?= =?utf-8?B?d3p0WnBLV1IxN0UzQ3hibEs2RlVyTVFpcXlVNi9hV2JWQmhxUGtUVUJ1aFNq?= =?utf-8?B?WnVmUzNoajMxd0hYcnFRTksrekM3UVRvM2JVRTlkdk00QVZQTlNFMXJQbG1k?= =?utf-8?B?SStMakV2MnE0MUFlMS80QmxQcFZUL0JnSHQyLzJNbFVjbm5nMEZjdGlOTGFa?= =?utf-8?B?SmtjMmdkOHZ5cFl4eVFFNVZJVithM3g2dDlwaThHdG1INWRORVNLdW5md2Vq?= =?utf-8?B?MDZmVVVpaytsRjJ6UU5RckxEUjIzUnhUdEhLYUJ6VXJPakF0UEhMUjRRZkxY?= =?utf-8?B?V1hXQjJPbVo0RENQbmRsZUNDVVRxZzllaGhpY0V2cjRybC8vZlZES3d4ZkpL?= =?utf-8?B?cEFvVnBKUHJvdWlBbHZPUXhVT0QrUXJyRlJITEloOG9HdWtoQzdSemdGMlI4?= =?utf-8?B?UVdXNEpSaGtINEVtOWZ1aks2VWVTdnY4SkVNOThRWDNwZU9tK2V5WTh4VWtM?= =?utf-8?B?SzhSTHJzUHVkNHhqK0tTUGdRcHZsbU9xN3JNZEpOSHM2b1NXNEk3M2NGc0hQ?= =?utf-8?B?UlBvM0oxelY5dzlEdytKNlQrUDh3RTUvRmt4amZvRkQxQ0VPai85UTJQNHZP?= =?utf-8?B?TWMvOVhTRU5kV0NxNm1vWWk2RC9tVi9hMG1sWEpqamEyTnpTcjg1Y2haNTE3?= =?utf-8?B?SHZ5ajV2UlhQQUFPUzhVd0pKZnl6c3RxSlRtaFZ0eUozdkJlbnpndktFbHVz?= =?utf-8?B?WGppU0RuVjI2c3NnK05TZk91VUY1VHlhUmllQy9ZYWE3S2ZwVjdNZmVzWXZW?= =?utf-8?B?NnNBTDA3MUVoeHNVTkhySlM2MEExNlY2UGwrT3l6M1lPNnRValBpcjJtUjZQ?= =?utf-8?Q?SnowKCSfpOIREwtf8GVtiMgAE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dde9e119-f94f-4496-42e9-08da96234370 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 07:32:22.7205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mZqIjebGmRYBboHMElv0/lz+o4zNALZ23RlcHtwojANn8kRzp7yedRtFrLbiZyMtny55Max+8aQaGNv+MOnrJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9469 On 14.09.2022 09:11, Demi Marie Obenour wrote: > On Wed, Sep 14, 2022 at 08:44:25AM +0200, Jan Beulich wrote: >> On 14.09.2022 08:40, Demi Marie Obenour wrote: >>> On Wed, Sep 14, 2022 at 08:36:02AM +0200, Jan Beulich wrote: >>>> On 13.09.2022 19:22, Demi Marie Obenour wrote: >>>>> On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: >>>>>> On 13.09.2022 16:22, Demi Marie Obenour wrote: >>>>>>> On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: >>>>>>>> On 06/09/2022 10:52, Jan Beulich wrote: >>>>>>>>> On 02.09.2022 04:05, Demi Marie Obenour wrote: >>>>>>>>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in >>>>>>>>>> a CPU register to enforce constant-time execution. Linux plans to set >>>>>>>>>> this bit by default; Xen should do the same. See >>>>>>>>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for details. >>>>>>>>>> I recommend setting the bit unconditionally and ignoring guest attempts >>>>>>>>>> to change it. >>>>>>>>> I don't think we ought to set it by default; I can see reasons why kernels >>>>>>>>> may want to set it by default (providing a way to turn it off). In Xen >>>>>>>>> what I think we need is exposure of the bit to be guest-controllable. >>>>>>>> >>>>>>>> We absolutely should not have it set by default.  It's a substantial >>>>>>>> overhead for something that is only applicable to code which otherwise >>>>>>>> crafted to be constant-time. >>>>>>> >>>>>>> Either Xen needs to set the bit by default, or guests need to both know >>>>>>> the bit needs to be set and be able set it. Otherwise code that *is* >>>>>>> intended to be constant-time has no way to protect itself. >>>>>>> >>>>>>>> As for why Xen doesn't enumerate/virtualise it, that's because >>>>>>>> virtualising MSR_ARCH_CAPS for guests is still not working yet, so the >>>>>>>> feature can't be enumerated yet even if we did support context switching it. >>>>>>> >>>>>>> Intel and ARM64 guarantee that CPUs that do not enumerate this flag >>>>>>> behave as if it is set unconditionally. >>>>>> >>>>>> I'm not qualified to talk about the Arm side, but may I ask what you've >>>>>> derived this statement from for Intel? The doc page referenced by the >>>>>> link you did provide (still in context above) specifically further links >>>>>> to a page listing instruction with data operand independent timing. All >>>>>> other instructions, as I conclude, have variable timing unless the bit >>>>>> in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the same name) >>>>>> is set. >>>>> >>>>> My understanding is that only instructions in the constant-time subset >>>>> are ever guaranteed to be constant time. >>>> >>>> Hmm, yes, I did overlook respective wording in the doc. >>>> >>>>> On architectures where DOITM >>>>> is not enumerated, this guarantee is unconditional. >>>> >>>> I have to admit I'm suspicious of this "guarantee". >>> >>> Do you mean that previous CPUs had a vulnerability that has no fix? >> >> I'm not sure I'd call it a vulnerability, but at least if going back far >> enough in history I think you'll find insns on the list which don't have >> invariant timing. Like with other documentation on e.g. speculation >> issues I take it that Intel simply doesn't consider sufficiently old >> CPUs relevant anymore for such new documents. > > Any examples? The one I easily recall in truly ancient, so maybe of only limited significance: MUL on 486 and older. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 14 08:11:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 08:11:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406838.649221 (Exim 4.92) (envelope-from ) id 1oYNUG-00070c-DL; Wed, 14 Sep 2022 08:11:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406838.649221; Wed, 14 Sep 2022 08:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYNUG-00070V-AA; Wed, 14 Sep 2022 08:11:12 +0000 Received: by outflank-mailman (input) for mailman id 406838; Wed, 14 Sep 2022 08:11:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYNUE-00070P-Ql for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 08:11:11 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c832cd89-3404-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 10:11:07 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 83D423200957; Wed, 14 Sep 2022 04:11:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 14 Sep 2022 04:11:05 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 04:11:03 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c832cd89-3404-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663143064; x= 1663229464; bh=vj+y3+GGgkN862ndlWOKlat1PtH5lOn+JU5tw72tph0=; b=N YH4aj73cU3m64O3u9jKtry5EwA+L65Gn/JjPspvgZjaGpZDm0FbY0lw4pTUk8TMh dM1EYTXAw5vYTT1FGESool2Hk7qDbrhd1vE9m40lRS8Ij0AqV7T89ePzKvALg7xJ 3Qr6Y9A4ZsbchVLgOltDdbsceqxNqHtgZ6ucxnULVXMr2389xXAEmgeRHa+Zx7r6 z/FvDwgZmzYqc3HN45X7NHUxzXofOlwhwnRA0UgjpDeT/kX9NeZCLkKkbZ9mKpCZ ULKXgDHPl0Ek8mVEojHvy6IM1oM43c9A5A7fK8XNlyKTFxDsrDVmEEshx4wxvbDq 3iDzloZIvGbsVSEmZlU/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663143064; x=1663229464; bh=vj+y3+GGgkN862ndlWOKlat1PtH5 lOn+JU5tw72tph0=; b=XrBN0xQ6L9jjnWfbuC3d1J8qUMrnn/I3VWdR1e5/EJ+F x9BkA9sns7utmFB0n8JzfFErRBxe8jeagzbhLC/qCIHzbDEUibFLnMvQ5KLTwOR/ BdY0hUi4dtyLmsiRtFHWeqt3B3cUFsIO56s5Wbs/ld7GUyQ6mPZHbn+1XtOuWqs8 B8Pb9ns5bnG99A/vC1CeASkw193V3q7ZSlDOQ1MsMj9PYCAw3We7Kc4beiMn1rJs IIEC0d2mQRZTyycY5Vzb64CQ+z8zRUMpagy+XKW/mL9LZLEhV6HHNMbIddJ7/Hra FJTHCcPveZVI+e4Wq/SPhrj8+psRtk51nGBEHQOQZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleefjeeukeehkeegiedtgeekkeel tedvhfduudefgfffheffheeuvedvieelfefhnecuffhomhgrihhnpehkvghrnhgvlhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 14 Sep 2022 04:10:58 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag Message-ID: References: <1d7b9e30-975b-b49f-fe09-e2aeda9e2af6@suse.com> <1b85702f-7efd-b13f-40d4-615750e20f4c@citrix.com> <037151d0-0920-5d99-9932-df044729c00a@suse.com> <61f083c8-34c7-563b-b010-8d8d0286da6a@suse.com> <62f0ebdb-d06b-f361-40e9-711258c03a56@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="o8v6Zj3B0DGUQAn1" Content-Disposition: inline In-Reply-To: --o8v6Zj3B0DGUQAn1 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Sep 2022 04:10:58 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser , Xen developer discussion , Andrew Cooper Subject: Re: Setting constant-time mode CPU flag On Wed, Sep 14, 2022 at 09:32:20AM +0200, Jan Beulich wrote: > On 14.09.2022 09:11, Demi Marie Obenour wrote: > > On Wed, Sep 14, 2022 at 08:44:25AM +0200, Jan Beulich wrote: > >> On 14.09.2022 08:40, Demi Marie Obenour wrote: > >>> On Wed, Sep 14, 2022 at 08:36:02AM +0200, Jan Beulich wrote: > >>>> On 13.09.2022 19:22, Demi Marie Obenour wrote: > >>>>> On Tue, Sep 13, 2022 at 04:47:24PM +0200, Jan Beulich wrote: > >>>>>> On 13.09.2022 16:22, Demi Marie Obenour wrote: > >>>>>>> On Tue, Sep 06, 2022 at 10:01:00AM +0000, Andrew Cooper wrote: > >>>>>>>> On 06/09/2022 10:52, Jan Beulich wrote: > >>>>>>>>> On 02.09.2022 04:05, Demi Marie Obenour wrote: > >>>>>>>>>> On Intel chips (Ice Lake and later) and ARM64, a bit needs to = be set in > >>>>>>>>>> a CPU register to enforce constant-time execution. Linux plan= s to set > >>>>>>>>>> this bit by default; Xen should do the same. See > >>>>>>>>>> https://lore.kernel.org/lkml/YwgCrqutxmX0W72r@gmail.com/T/ for= details. > >>>>>>>>>> I recommend setting the bit unconditionally and ignoring guest= attempts > >>>>>>>>>> to change it. > >>>>>>>>> I don't think we ought to set it by default; I can see reasons = why kernels > >>>>>>>>> may want to set it by default (providing a way to turn it off).= In Xen > >>>>>>>>> what I think we need is exposure of the bit to be guest-control= lable. > >>>>>>>> > >>>>>>>> We absolutely should not have it set by default.=C2=A0 It's a su= bstantial > >>>>>>>> overhead for something that is only applicable to code which oth= erwise > >>>>>>>> crafted to be constant-time. > >>>>>>> > >>>>>>> Either Xen needs to set the bit by default, or guests need to bot= h know > >>>>>>> the bit needs to be set and be able set it. Otherwise code that = *is* > >>>>>>> intended to be constant-time has no way to protect itself. > >>>>>>> > >>>>>>>> As for why Xen doesn't enumerate/virtualise it, that's because > >>>>>>>> virtualising MSR_ARCH_CAPS for guests is still not working yet, = so the > >>>>>>>> feature can't be enumerated yet even if we did support context s= witching it. > >>>>>>> > >>>>>>> Intel and ARM64 guarantee that CPUs that do not enumerate this fl= ag > >>>>>>> behave as if it is set unconditionally. > >>>>>> > >>>>>> I'm not qualified to talk about the Arm side, but may I ask what y= ou've > >>>>>> derived this statement from for Intel? The doc page referenced by = the > >>>>>> link you did provide (still in context above) specifically further= links > >>>>>> to a page listing instruction with data operand independent timing= =2E All > >>>>>> other instructions, as I conclude, have variable timing unless the= bit > >>>>>> in ARCH_CAPS enumerates DOITM and then the new MSR bit (of the sam= e name) > >>>>>> is set. > >>>>> > >>>>> My understanding is that only instructions in the constant-time sub= set > >>>>> are ever guaranteed to be constant time. > >>>> > >>>> Hmm, yes, I did overlook respective wording in the doc. > >>>> > >>>>> On architectures where DOITM > >>>>> is not enumerated, this guarantee is unconditional. > >>>> > >>>> I have to admit I'm suspicious of this "guarantee". > >>> > >>> Do you mean that previous CPUs had a vulnerability that has no fix? > >> > >> I'm not sure I'd call it a vulnerability, but at least if going back f= ar > >> enough in history I think you'll find insns on the list which don't ha= ve > >> invariant timing. Like with other documentation on e.g. speculation > >> issues I take it that Intel simply doesn't consider sufficiently old > >> CPUs relevant anymore for such new documents. > >=20 > > Any examples? >=20 > The one I easily recall in truly ancient, so maybe of only limited > significance: MUL on 486 and older. That is of very limited significance indeed. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --o8v6Zj3B0DGUQAn1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMhjJUACgkQsoi1X/+c IsHb4BAA3vCukiveJqUMGaIJMHSSaKsVGzvUMg9O0Z0X9Ki4ymVUo9EmmsYn3fn9 IuGNGfQXRswhr9nLs2vmVMIJWK6UcA7K8uGTB7kqHmJymoFkwTq9xgZjb4hgovEi 1v/I5Gdj2RNZsH3zfTMbdISVRdBziiLXgRCYMdb3+82dTmNDmL70I30lWB5/uS1F /2bSUWAzIVNkblb92M2ZW1xDTGVTdFN1KtF7aN+IyyuW4GHk8OtUMKSHDh1gnELX taVXy4gku9a3rxxYpdZPr1A7ktCXH+z17nZKyhdKhrzQzEjTix79dTzTNMiCj0ti gD4QrYwKu4JbcHiqjGIziVdc2tcL+gDqPX/aYr7GvOCp0YW4GQkqxdgEeehUX27d S6rqNF6mSSdRgsCNv3NbtaVQLwQ/oC5dIpIcA3JUflIp1Zr7/ancXyiV29qddvOp q2v+GgxG+6zVwc9hWfL+oBdy+SETh1HO5+KTv6nWSY4DPWflJ4q3Gq5lOcDIdlMD FJz+UpFLDFpYnwUC7sU/JPTWSOR4IqWTZVX26eUEOxClkVqjIIAvJuWs1PQmBI5W eHKGU5n/0nzuWsS9Y8+q+r+1bdzS/MEkROU8ZTW+Fi6qGcrZikBPqPOB8lJEmeRR KOdHgBOLGYF3v48oG79OuWy5mBQpqnAniLzGLkToE6KcBcNwcmo= =WFDs -----END PGP SIGNATURE----- --o8v6Zj3B0DGUQAn1-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 08:15:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 08:15:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406848.649232 (Exim 4.92) (envelope-from ) id 1oYNXr-0007fs-WA; Wed, 14 Sep 2022 08:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406848.649232; Wed, 14 Sep 2022 08:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYNXr-0007fl-TS; Wed, 14 Sep 2022 08:14:55 +0000 Received: by outflank-mailman (input) for mailman id 406848; Wed, 14 Sep 2022 08:14:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYNXr-0007ff-7f for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 08:14:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4fc74c16-3405-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 10:14:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8752.eurprd04.prod.outlook.com (2603:10a6:102:20e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 08:14:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 08:14:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fc74c16-3405-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=My+DdoCOmq6MTtDgtUKUhitdp0ZadFx2Q0qdtozfHFZ2hQdoVEgc0XGsxTjIbFnN3Bk/8Tc8FYcrqqeVv27aZsX/rzwwiZSXJxHEMPfLYI464dlbN//X3ASwqPulOhX1zmIJRTvp/GxopnIQ3DNrjfvH4TwmV8k8s+/uoogDpvnGXcqyqHIc9WRXS8DLggvkbuanDv3+BMXY0DDpvNf/eKH5VLX3Jjj1MXr1oSqcEa7v8yyrYLIx/GTyziE9nUTpe3C/FMghaqgozPAnfJHHh77G9aHb3uSViiSQCAjouSqubQw/VfHljocbC0NDsOIkK0sxIoSo6G0D99/Pzd7euQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DbXj8ibR//i39icqs8mySCSafR59HRZF90whP0u7nws=; b=DKS/Tnn13r1LcObfl/2oLDgfTyFgY0p3w45ey2UJd9mSqB/i1OUydiWWZo104agw5hrHAYJndxLDmYZWFL1SJadr3n6/AmK/W1pZd6mIkTQxbl29LTBlySGvNQ4XqusjlQQ4Sh71aqW3ig71IVQ+FYIUvBEIkofDVUmXrnJwSen9m6r0BZjFFn0yr3n3uFw5tb6YB6FvteJ+MD6FBHO/+h/rpYOSsetKHXBIksbonznhLZJBFSxeeBY0CgsnCZe9qu0Z1Z5qqSaKHgZ63dffe2+njwJ/c5/Nz6AR/0RkBS4+7/7KvQTaDst/fuDxaJEQoVw+amCSEal0Fa/NsslB2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DbXj8ibR//i39icqs8mySCSafR59HRZF90whP0u7nws=; b=3PZ0l6e21i6bkjEWoNMF/hpBozDWRF+0QkLBmveOtbx47d6ZUZykq1wdGhdc13LuefAtDIxHfbcPraBiZT2Pt3dzsd3JMd7ZrTVW44b9n0YCeBhnHuI7jUKkj68Wc90CWa3XPSDHSuKdgi/x0FO1hrF/5ECU/DUXnjxQBhv7/PDhP98SRWX/zSenz2hJJKIo8viNbi42wnIv0yxM82TQ+rZJVgkoh2ev0L/nZIlLmwmP5qkVdcM/QaXPCU5dXeqI4zlfANhEnEPvvwj//eqd5Z9/gF3cJLz3+HvqZ8U7q1s/y8QMoaTsebi9vh9xM8shuaHCXkbVSzR3ct4P/4EZPw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> Date: Wed, 14 Sep 2022 10:14:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR07CA0007.eurprd07.prod.outlook.com (2603:10a6:20b:46c::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8752:EE_ X-MS-Office365-Filtering-Correlation-Id: f0031182-b0b9-47cf-58cc-08da96293334 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vKFpm7DinFjAlHWrZJjFj2T6UvPL65o7C61IiFFKSBk3k4bjU+BGyfon6phEc9HjEyn9C9HoYGxhpNPoW7sV2QVoSEuxu6B8RLWotrA4/mI6w6AVdfmZW9nAyz6JKH5fERC3L0R/O0HvRasa38GiCpw8vXTeXdMPYtYhwh0WZVV89Ent+B3srFiqxh/gUs/X427Yc0Dx57dyR6rDvTNPIGpjhFtV9Gpjg8LFGU1elr68x1qxxad8RBqUQ+I9EMNMvB30+11xUNTcz4bPwy8s5wIpNTWsYvaogCsuo/NUwyNYqTwDMvIazqDQLfetWV7E20XFtTl07n1NHRC6BMiaS+GA0WNQI4HAGkJS0J1g7XsgOwxehw0g/KeQcpNvKE7IibJQM0O2Fp2WWdi2JSNX7nnM+yaMNG9NRNgS2F7F7epZOxFoi76O6Z7udLPwx2QU0EK8CPxpyW+RAnhUEu7By9vB+v9I0Ime75Dwp6FItl18zouqYxd+IPJi5cW62czJGgj9b3KYhZNJLRBVhPe7OyjhdFVvebro8BBubcHPOimQw4ZnFgCVEfy6XW2jKrPl0crNFj5U2g4JchaY75fjKs8YTgBvJZd0ig+iAfcB4OX76SPirBJaiB7C4DNbKEoDApOkgAdgBi9dXXz5gL0h0RDclBStzuXrDt6zJ1qPFNbrTbvL2d69tdvBEuq2+7QXQrPp/oCgMIt5ZZDsC7d5A+pyVYFv9RdyV7erVSir3Bf84tkesl2pB0BD6RKnQCJuvz9Uy+IR5rPTyMiGTdp3ESznQE0gYQPgN3TqMVsuO9U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199015)(41300700001)(66556008)(36756003)(5660300002)(8676002)(66946007)(83380400001)(54906003)(86362001)(53546011)(6486002)(316002)(6916009)(31686004)(31696002)(26005)(8936002)(2616005)(66476007)(38100700002)(6506007)(186003)(4326008)(2906002)(4744005)(6512007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmpZL2d4YkQwbzdXbWh3RVdOZDRkQmtjUGRlaFF5UGRzbmdQVU5hSmltc0Z3?= =?utf-8?B?R203eC83UkNOZHpUUXNwZldYVzIxMnpwbVlzKzRiMFo1cWROVnJiQzg1MDdY?= =?utf-8?B?emFTN21FLzZBb3h4NTRMVElQQmE3MTFoa3NRUEFyRUM4T2xkYVhkWlloQU9k?= =?utf-8?B?V0Rmdis5YjNhRGw1RUlwMGxXL09xK0tSYk1nUHlkRGVub24rTWZYblovdDIw?= =?utf-8?B?Ny9zVFo1aGk5SlppM2RDTUVKMGxSWUk4OC9KWlVSa1NEWjlVOWxNTHlJNk1q?= =?utf-8?B?amFFZ05Mc0pUTkVaUHp1ZjBvYURpOWx2bFFaNU50WkRuaDA3Yy9Pa3B2dUNp?= =?utf-8?B?VGRpT1pXakpuTlJoMTJOa0NYTnl3aHUrTHEvbUx6dHUzb0dITDM5RzJjMGhu?= =?utf-8?B?UXNPaWg3YnhrU2M4MlRhWW5OMlIzMjNjdGNKQUVaOHZtZ3ZCdTRiQXJTZVhZ?= =?utf-8?B?Nk54N2tKMDJaV0c2d3hpV2svNy9tN3UrWVRGOHlHZ2F4KzJsU2NDd05GMDNU?= =?utf-8?B?QzhFRzErWll1TEpyUVR2M21pSzBYbStXd056cVhielRkMXYrOHFOSXFtRjJE?= =?utf-8?B?aVlEdDhJa3NrSTFwZE90Y3NjZWZYRHl2cUZtRXRBSzB3cVBYNUlYRmVzQXlN?= =?utf-8?B?dEJ4aWJoRlE0RkRnQ0RTQkV3Q1JJMkhLU0lYVkRtMmxjRU56cjEzV0I1NG1S?= =?utf-8?B?N205cDl1QnAxNlpOSEVNNm5YcGpLcEE1SkVoWkw3OEZDTTd4aGgwak1GamZx?= =?utf-8?B?RlE2WlB6cEZJQUFlZjJkeWFKSHEyczE1L1pMZ2QxYlJUY3lTajVrTVlXaS95?= =?utf-8?B?M003cFZySHBlTmY2eDB0dE9KWlJxdkU5RVc0bWpUMEZoa1JNdGM1WEg0a0ti?= =?utf-8?B?R2ZzM1NXUi83NFgyODMzRUxxSnM3cnl3V0EvSHhWN1RkSUdnSGY2S0YzZFNC?= =?utf-8?B?YnI0YVlEcjNuaWF5bGFKMkxqTzl6Yi9nTlpOOGlyK0VDbEVvbWsvWEU3Nlcw?= =?utf-8?B?L2t6ejdHbjhyQlM3NmhrUEdQZmorSlE4RnppekNuKzVMeTJvQVd0UjJkTnZB?= =?utf-8?B?WEVmR0dVQm1WSk0zUDFSREE4OTBsM2gxejZtWFpFUjI5aHRxNW1WYjA4Q05Y?= =?utf-8?B?YmFXT3FZUnY1T3NzcEhNUWJqQmxyQllIazlGdHhKS3ZrZmdBR1BsOTNqeVo0?= =?utf-8?B?UnNadFJNems3eU5CZlk3bDRtUG5VWHcwZGtyajc3ZzNTeHVDRllsMnA3dTdN?= =?utf-8?B?QW1oeGZFYW1kdm1lYnBGY2NOMk5ta2pxQ1dvUE92S2FUcTRuZEd5S1EzTndi?= =?utf-8?B?amVtOHZ6c3lUNTRvVS9ta2RYWjNQOWJVd0JHVEpQSFhreFE4QUdtOWNxQk8x?= =?utf-8?B?NjFVK1pXOGxwc2JkdWk4S0hrRnJINDl0TWw1TlZrL2tQemtXN2lra2VFMjlE?= =?utf-8?B?cmx6U0F4VEptc2cza2RZUitaTWo1MC9pdDRqdjBqdml5UzNTREJUSHczcVc2?= =?utf-8?B?ZzloWUdHQ3hydzhYRk81SG1qY2krWnNqNUdtNzNxZGtlUHhrN3dTSWZhUS9z?= =?utf-8?B?WkFucjMyMDRKeWcwaEZwNU9XQW4xeENMUDdRZ0hocC9VY3J6d2RFRUJ4czZK?= =?utf-8?B?VjZpT3ZhQXlRVXZwenVHMDhMdUlFYkQvV2dQMS91Wk1UVDBVQkRrb0RBQ0sy?= =?utf-8?B?VFJPMUtmUEtNM2FRYjFXdmcrdC81U21PZXdXYUFwMnNFZDU4RzY2aFl4R1F3?= =?utf-8?B?WkxWMzI3UHh6V3FzVllWUUFocnZ2YTFKMWtiZ01pdWdIUDRsZWVhWTh5YS9U?= =?utf-8?B?QjJ6THI2aE5kVi9KMm83QXk3dUYybEZDNnpVLzlWUGZGM2tCeFNmb2JDNkp4?= =?utf-8?B?TEFiejFUNXVGbG5NV3p0OXhsREpOUlRvL1RSSlh0MzhnRTdDajh2ODZLOStL?= =?utf-8?B?MExlWlZLWUpUNCtna0FrSmlWZkZJMzBsQ2xzUSsvUEhJdWFFcHZwM1FQUTcv?= =?utf-8?B?dUZSMXAzZE9xeWZQZVF6eW1ENWFkcTlyTzFscHBKSmZYRGhEcC8rWXFVU2Qx?= =?utf-8?B?d09SQUd1ems3dC94ZmFLaWZrTmdIYjRPTTh4TWNQK01lM2lYcUZCZVNiWnBG?= =?utf-8?Q?YIJiGJSUgds3xT8KkDXF87Y9h?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0031182-b0b9-47cf-58cc-08da96293334 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 08:14:52.4334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gBxbluRi8xhk+epJLKIQhBQBfb4Q++b80+3YCgc9CLnYOqpK0/s8cljfe0yJfV/dMgfmHMdD4NfU5FNmCiqU1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8752 On 13.09.2022 16:50, Roger Pau Monné wrote: > On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: >> show_hvm_stack() requires interrupts to be enabled to avoids triggering >> the consistency check in check_lock() for the p2m lock. To do so in >> spurious_interrupt() requires adding reentrancy protection / handling >> there. > > There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will > trigger when trying to acquire the p2m lock from spurious_interrupt() > context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> > percpu_write_lock(). s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), but yes - we could nest inside a lower priority interrupt. I'll make local_irq_enable() depend on !in_irq(). Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 14 08:31:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 08:31:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406854.649243 (Exim 4.92) (envelope-from ) id 1oYNo6-0001hC-FG; Wed, 14 Sep 2022 08:31:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406854.649243; Wed, 14 Sep 2022 08:31:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYNo6-0001h5-Av; Wed, 14 Sep 2022 08:31:42 +0000 Received: by outflank-mailman (input) for mailman id 406854; Wed, 14 Sep 2022 08:31:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYNo5-0001gz-GB for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 08:31:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7dbfea5-3407-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 10:31:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8717.eurprd04.prod.outlook.com (2603:10a6:102:21c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 08:31:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 08:31:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7dbfea5-3407-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lcK+4DMrllOROweGiYI75Wg3WTaiM2FJ7c46s1norPjaaOByO4KtXOEV2hkwtAi23aDNJoiDutSh4DVkT9HywmqggVD4i1qSCU3Xa+tGLvVQTg9z5kZPMmHN4Py2jEsGX8Mdd30o5uDD7CzGygZXs4BOlwntaSXV1W2lHIu8tpcErm7WdZbawO0lHgxhmzKb/qnVBpg1IGCNafQC+OCT0+eB6Df5Wg6CHLc/UY5bySVKSbRAaAIW6EWlO6Vlrx8QtNKl/ZHeln7khrCysYnl9Kp2BvXdFA7l1cRQrusUKtOCIWzpFt5rQ/Y0BrW5UFhxU5OmYwh8a912cusg7NEwJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JybTfpscvAvH3KtABBW8YPzzHqukwqh1lv3Qv1WzSHs=; b=KNNImCL7fiBA9UJ47C3Sbw76ry1ErZza9jUCRghjaHZ5GT0UYeZ4n/QoxfDneTqwH8Sa3pdV4No1yFS5aFi/6yDOllRd0b/fUgqhkC+/ORnbToVibgQ+Twwwd3oFmeqDtMb0uzEpy/bwq5r4XwG6olnwvzQQF5r25iIZBpBZLchDb0HdK3FAoIOfrFtYNolCyss5SfzRbbXgKVK81Jx+NoFOsIT4j+IjP7+69QRIpMQc2dBNu8W/Gl0SL1cc0w0rsk5WJ62caUnW5UYDmJrtO4SaD+n6ChQsqCa8QcdkipRLpprPQBSrX3iKDyjsj0/fiaAdSLrxCQzO4BWlDD8xeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JybTfpscvAvH3KtABBW8YPzzHqukwqh1lv3Qv1WzSHs=; b=HqXSnOxG1OX8F+Q/X5rjkFIXFiFR54mP3XhwJO2mQmET0H2qiFWvfiDMn6j0a9bPTtqgMTsgi7P+ll4hXUD55IzpCnFLg8f25DED12kfFjZCwmwTP5ilmS2ydPv26GYV5bG7eScRbJNFlWc0Tvp4IZmOweu1nJ5g8rl41H8CEpBOM+a3skktZqCEgUaw0Oiz2ZyvQGtsUUOJhsaQ1o3sfSVncWF+WvSfvNcD9ALWRdLbN87wECSzOVRdpt9AYtNN8eRme92+PKKEFUqlGugLYcMK7mrGQ+keeKiPQvAGXchUH4fPez1/h4eTWhZAjgQAUU5Hkmv2LPeiZuGAia+PwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> Date: Wed, 14 Sep 2022 10:31:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> In-Reply-To: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8717:EE_ X-MS-Office365-Filtering-Correlation-Id: 92858496-ccf7-4afd-3178-08da962b892b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nGNwV6ScFQzjc5IflyeowaZrg9XJejdbF+WLUlngh/0t+UwotAKb/beqD2EGZynur90Yrm+4bRZddnnZhkIfkQbkVuybz7qUWu1qrLIjzXm4RKJl2KqgmV1WP/WoB3y1cZ2l+i6TnEv9EhXUrKokx9ocIWR0esxfgOQAQ8AeUMNk6eAHt2ESE9eNDlBaixx5W5OPYriD//dHPoYEbl0sQv4LSXp3XgWssTu/0xV/wn0ZS6CkkFHOKSKkVK619uuiz3Gput/KpM1/PbJlHeFbVncG2iTt1PgWAt/0wV+98S92cx8pgSPEttqIwctmGlvZzRpCjfcMovvlafklFZXLf2T0ER/lyhOOLgSZDOAcBTnVQw24yaw55NTInuZPtQxvSnNEdCTrZ9zTUdOdT9o5v5AxECOcba2nT9sqO/n9R54VcyEzsPWHE9bHF7Wx8DMygwkxWQYCIsZsv4Pw1SY0ZAqwEWnzDfGejvjYRrTkSGTAjOQgYMLXuhwj/1dfE5Icx+XkPpxa61Lo0BhQ2jsNYPhJTJh8JDUezXvCqZIdPdQfFLWeeIxdJpcUw6hxEHBclCwTEd1EMH/csD1ZJQa7j1v+XW/2tTKCjqhF8XKr4hPrThOoamtb188LCIVH1uO0AwN99j5TlTyHX2lVygqyHSVUx5UkEQ+SRyE8KHljsOMJ46Z+lGlwD9Gd6ALLymf80+atotnkkzQQikUjqTGGSL4GVen18ULQjjiMmpxeksaCSvCQK2y4KpnMNg7Gr6h7+LlBF5mL+bWe9l+9c7mNekDGS5PuOW0TdMQpJp4GOCk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(366004)(136003)(39860400002)(451199015)(41300700001)(86362001)(478600001)(6506007)(8936002)(31686004)(66556008)(316002)(31696002)(4326008)(66476007)(6916009)(8676002)(2906002)(54906003)(2616005)(5660300002)(38100700002)(36756003)(66946007)(6486002)(186003)(53546011)(26005)(6512007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2YxNVprOGZxcWRCTG5ZTU9QMzBkcytjUXNlUEFRQUlDSW56TlUwcVAzZ1U4?= =?utf-8?B?WUc4UVVBMGhPU0Nueks4ZnJnNjkyeEJaS3lWQ1lpWGN3KzRMUHovZmZoSnF6?= =?utf-8?B?Ukd4VlJyS01RWS9ua29xbzlBYWgveHR0SXBKV1hFWkxzOUVPR1A0dHhXT1Ev?= =?utf-8?B?UXZzd25xandRQWJyb1FZTUFJK3FVMlZGRWFGTkdTYnFJamxLZEJqMmQ0bDVL?= =?utf-8?B?WEFuTEsrNjJ0aVVrQWxRbXFkOWNRaHo5R1JkL3BIenZHbU5sSjkxejJwaEN2?= =?utf-8?B?cEVKdHFBb0ZOQUNzMVkzVlJkdWhGZU1ldDVOa2haVkhIaUxHZXo4a1RHV3Rs?= =?utf-8?B?dkxqTkgzRmZlL2FDOExkaUJQRVp6TVk0OVRySS9WcWd0NFVRMStkYUZLZVRF?= =?utf-8?B?SjdGQ3MrZnFWM3R6TXZadjhpOWt2NGFNR2w0bUMyTStRWWZmbiszR25KU2p1?= =?utf-8?B?V2h3ZzA4TWF2NTN0bW8xallkbllNci9nbGxjaUloQ3JHekV5V1lvaFRqYUZU?= =?utf-8?B?SmtGOWVUNytlSDBDUlhyYWpWQmhNbmRuMytKT3BaOTljUElqUWEyUThXd093?= =?utf-8?B?eElKWE8rTHVzSDBZc2tTVnRBMkNPWWxGdUdESlN3SmQwSUZHODYrYThVeVR3?= =?utf-8?B?ZWRDeG1OQi9oQm5LNlFOKzJrb2JDTVh2N1JjU2lRYVVWUzhxcGs3VTQ3U3Fn?= =?utf-8?B?dGw1enBIYmlZYUVodm1Fd1padkhJL3BtSjBCVitoTnp6R29SZE5wQlRKTHMv?= =?utf-8?B?N3BDTm9qWFhXaUk5RnlXMUtzMXdPY01OMU9iZVU3VUlxOXprenlrdlRsOGtF?= =?utf-8?B?bWxpZ2JPSmVHYWVIYUpLTlJWRkFyWVhTcS80TTdMSjQrTUFlNG5OVlNOcVZx?= =?utf-8?B?VURaOFd1Y2FycVNSTlhQSys0WGdLMC91RTJEa2pRa1pMV1JDclNjUWRTVDI5?= =?utf-8?B?eCtabHExMXIxRU1tRzIyTW1xd01aUGpQMWtwSmFHblIxMW5EemJXbmM2TEdo?= =?utf-8?B?QnJyNm14bjRZcy9VNkxLang4WkpmWW56ZW81Z3YvbERNdHlJTkxBQTZPQURY?= =?utf-8?B?VC9VUklMT2k3ODc3bERLNUhFTzdHT1FPTDJPbkNVb2xMVEQxWkZpZitaY2hh?= =?utf-8?B?L1U5RXFIdXIyNHlQamRuOW9RWnRBRm5JTys4MnZ1bTRVM1dTNUdXR1dMOWNk?= =?utf-8?B?cjJhSUdXek92a0ZmL1F2VkVxRGVmdHNGcHFFY0crc1lvTGNzYlNJRnhNQ01S?= =?utf-8?B?S3FuQVBSZlZFd01xWmtvb21vOWhYQWthTnlrR1UvdThER3N5M2RsMUN6Mmhv?= =?utf-8?B?T1ltOG5sekpKZXRRSTgvQkZkNHVMSzd0MzJvVTEwYkI4aVh4bk9MQjd5SVNF?= =?utf-8?B?dTVQLytTSG9XNTlzUEJLWDJUU1hIaHIxMkR4UXpzdFFIWlM0WEV4S0xTYzFE?= =?utf-8?B?QkRsb2xvcHNPbE1WMzNENDZrN3FzSC9OV2RDaTNVa3N6TXliR1JkdExCMlBR?= =?utf-8?B?M2ZxZTlGWDFzaHdyYUtycVZ3dUtHcS9zTnFLZGxGdml2bngzR25pcXp6VGRa?= =?utf-8?B?VC81V3lZS0MxNldieVIzb2hvR2loOW1EWUFOejUrNThQTi9kWFNWL0xxSWdm?= =?utf-8?B?aEVvZUtSbUJmdUxZN0czMFJxdmpJcGpvTEtndDV3UUVzVkY3SGhCcFdqbnpq?= =?utf-8?B?dHd2YmhwVk9JR3N2ZEdKMHE1RFFiZlNDaHZ5bmYyRUVmZTVwSjZoVU9PUWoy?= =?utf-8?B?bEJZdmJ3T3JVRzlVemNsVVRjRzRpSU1QSXJwek0wb2JYVDJoNXFrNk1CMTVN?= =?utf-8?B?S0JjZ1ovQnZaLzJuanV3aXFiSm5EeU9FMklSZDZnR2tWb3RZMXFzaEpOTmk1?= =?utf-8?B?L0IyVTV3ditDZm5xK3ZKZUNtZi9PVGI5WFZYL1hyN2Y4UU9SRnl0eFpOcmtp?= =?utf-8?B?bWFHTEtYdTRYcXB1VVpSam1PQ25tTVBNUnpzS1Zock94RHRKNVA3bmRDYmxB?= =?utf-8?B?SWhWc2t2bFhiUHFTVU9Ud2pMTWlpMkVrREo2UXZlYlpjTkI2eksyTGJicEZk?= =?utf-8?B?b2svNko1aHh0d0ZmZ3N6aVR6S05tbm9rbHVKUFB0YWFVMkJEU1I2UVZsek5k?= =?utf-8?Q?3OAVNGPx3qydzjUEa26rcZFRa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92858496-ccf7-4afd-3178-08da962b892b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 08:31:35.6822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82O4I1UjYVUN2+KcHZfvyUIFv47AWerhyu5Fcp5jl4eLRJwD8SV3TycvgKGQaJFtZsMWwA5rQXJ69mgMiElrSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8717 On 14.09.2022 10:14, Jan Beulich wrote: > On 13.09.2022 16:50, Roger Pau Monné wrote: >> On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: >>> show_hvm_stack() requires interrupts to be enabled to avoids triggering >>> the consistency check in check_lock() for the p2m lock. To do so in >>> spurious_interrupt() requires adding reentrancy protection / handling >>> there. >> >> There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will >> trigger when trying to acquire the p2m lock from spurious_interrupt() >> context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> >> percpu_write_lock(). > > s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), > but yes - we could nest inside a lower priority interrupt. I'll make > local_irq_enable() depend on !in_irq(). Upon further thought I guess more precautions are necessary: We might have interrupted code holding the P2M lock already, and we might also have interrupted code holding another MM lock precluding acquiring of the P2M lock. All of this probably plays into Andrew's concerns, yet still I don't view it as a viable route to omit the stack dump for HVM domains, and in particular for PVH Dom0. Sadly I can't think of any better approach ... Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 14 08:56:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 08:56:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406861.649253 (Exim 4.92) (envelope-from ) id 1oYOBy-0004Fb-DL; Wed, 14 Sep 2022 08:56:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406861.649253; Wed, 14 Sep 2022 08:56:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOBy-0004FU-Ag; Wed, 14 Sep 2022 08:56:22 +0000 Received: by outflank-mailman (input) for mailman id 406861; Wed, 14 Sep 2022 08:56:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOBw-0004FO-RZ for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 08:56:21 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2087.outbound.protection.outlook.com [40.107.94.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18c68907-340b-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 10:56:18 +0200 (CEST) Received: from MW4PR04CA0037.namprd04.prod.outlook.com (2603:10b6:303:6a::12) by MN2PR12MB4303.namprd12.prod.outlook.com (2603:10b6:208:198::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Wed, 14 Sep 2022 08:56:15 +0000 Received: from CO1NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::fa) by MW4PR04CA0037.outlook.office365.com (2603:10b6:303:6a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 14 Sep 2022 08:56:14 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT052.mail.protection.outlook.com (10.13.174.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 08:56:14 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 03:56:11 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Wed, 14 Sep 2022 03:56:10 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18c68907-340b-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jszu0xVS9WOKpZJSkuz1V3O+fxzNYQzA478zksv7UxdKr9eXnsgZEZrhOtjGgMTAbImgtKYzQGMLbKLdLKiT1dRcfQMSCMzRJHmyWI5NpiTlH1PD7y6lo96vSVrq7rafOm47oLd+jb2SsROagTiOTAuZoiZgycnhgy11CghmqwxtJE8sCJa5oE4ucYp699ZV+lrsMklvhgfp3l95C2vymORUhqauhITxQ+zdSdIBUj9iKV3WpOoX29XT8iDQ2LjBcsuDk0uMVGvfLrwHn8GGASPmpHFUoidz8NBtQSXSaKhdmft3s0Ba/JmWi9NYuJbgD9adk81w5Ob0AW7DDy8wpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MlSBLE5PhDzBmNfA4MbQV/g6UZ0OSm0ZZMm2UjqKgm4=; b=Xs22l7XcYc2HJ5xggSBivfzN6ItYaukOt0KXAATRV1GY7ks3adX83GhuGrETV87kAT+xGVM8SRwP47nVdxr47n1CmEf00L7dZx0IJcLFd51hW3ejCjdcsvogWZVK/7uRcygxdVHWloh+cUFcPgqNdxsi7yJrSPipR7vufR/2FvqQCZ8va/nkBAwE/qOzuCYkTGT+xtHSigM/hsD/DSA/FpyA7woMuCPZcTTcK7N/2q7ZxyPdLZsimDIqZt+hJ2Sl9SzraFt/OLP1ffjJqEg7/7UC2QjAjmFLQX1wyDBZp7WioGHGpvS/of4q3aLlhlBHg1SX8b7vAe6CNTEnO8IYnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MlSBLE5PhDzBmNfA4MbQV/g6UZ0OSm0ZZMm2UjqKgm4=; b=M4Y7lpQq0tfbwvnpMEcz+TnJQggjC1GRHta/Y2rddMxyRflXICPrcpUZ5WnNIibmm16A40AEordtOWCl4X9WxkSbbJeVZ9w66riOoyqKZGrl00HEnnWfWMn1OwP4QjrMS1vCATs0oWk+buoBOpC8jgYKv5p3iVTOY8EN++AYO6w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <04fd3e27-1105-4ba6-bf04-d3b25bd3b087@amd.com> Date: Wed, 14 Sep 2022 10:56:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [ImageBuilder 0/2] Use lopper to generate partial dts To: Stefano Stabellini CC: Ayan Kumar Halder , References: <20220912115934.19552-1-michal.orzel@amd.com> <64aadcab-5f41-6d2f-4dc9-39415016816a@amd.com> <81eee8c0-03e4-fa41-757d-ee749ebcbe07@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT052:EE_|MN2PR12MB4303:EE_ X-MS-Office365-Filtering-Correlation-Id: 76acce41-d823-48f3-79fd-08da962efa95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jBfJ3Syi0Jha29v4nbOtGWWtiywYvpH3EHKVy4IgMRANncorB/tlTkOYo93ohQoZiB0Uv2x5wU0Fza9fSS7VqCzWsFmnKHbruupmdsJnHCwqIx0e+qew/1IgQmKtcwT0P0dYRrpqfTcByYuDPKUB/P2iQkPOBOnNFl4Fc8qHHricrXS4CBoxpnDb4JdV2sFSnXIDFeNKhxZPHnaj2LUPtNqGzbiplOUG7gmmtCpu0Zst499SuoEWvIDyxFUkBqUUPMU8cQMQECLQFPhqKBSCgIf/iCBo3MNbwAQ4UUOaKoOQ7CkDzmAxUS1EQmJhfRn0x5O8VBdKpF1V4EhHPImctbJu5svdW6TTTjqJUja8LFcBaakxG7tVQRvHw1c/4rL6/QH0N0MA2bv02KSbxg5FZ/+azOkV+jTiO2edJU5httkxhFY/zIaEFtOwb4s3KD0qdNAom26FdMaXPAGXlg5uCXECK7d0Ks0c0h7rSK/FeK0NXar07Fox8qeVCE4kRey+l240mMdTabD6DSLYPIA4QQf2fPxDv/HgAnZ60A5+UxYcdsJOlc8IdW5uURVBU+IeuNiCFlpFnvahtAPUhd/ixDsfJMg2yKzFcI4DIXK8wYrfh0GgBE68B+ZoK81mxpD6+tEjguNYcK3Y5O6X62TzT1cpaOkj/SDPjwj2iY1FPIE8BNHV/UYvWfOdpqOq3UpR5169dUr/UxvvTbTgopwvGuRlabJ3G6E+IhJlhYqLpfe7Sy4APSXLZVlcvGvHJoTqsNx8Qp2UEiRj8HMfIoODNVGCAM6ilQvxSDT3KjCY4cHPgag62LcCJnynXbdqQ6DWxEg+vq056GaYmhEnsxheIWwyoTxkbepbHU55uZh/ag8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(4326008)(336012)(54906003)(16576012)(6916009)(47076005)(31696002)(86362001)(2906002)(41300700001)(26005)(966005)(5660300002)(36860700001)(83380400001)(53546011)(426003)(31686004)(316002)(82740400003)(186003)(356005)(40480700001)(82310400005)(40460700003)(8676002)(81166007)(478600001)(70586007)(45080400002)(36756003)(44832011)(70206006)(2616005)(8936002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 08:56:14.1077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76acce41-d823-48f3-79fd-08da962efa95 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4303 Hi Stefano, On 13/09/2022 21:28, Stefano Stabellini wrote: > > > On Tue, 13 Sep 2022, Michal Orzel wrote: >> Hi Ayan, >> >> On 12/09/2022 18:27, Ayan Kumar Halder wrote: >>> Hi Michal, >>> >>> On 12/09/2022 12:59, Michal Orzel wrote: >>>> This patch series introduces support to generate automatically passthrough >>>> device trees using lopper. This feature should be used with care as the >>>> corresponding lopper changes are still in an early support state. Current >>>> integration has been tested with several devices from ZynqMP ZCU102 board >>>> e.g. serial, spi, ahci, mmc. >>>> >>>> When using this feature, make sure to use the latest lopper's master branch >>>> status [1]. >>> >>> I am guessing that this is the first time the imagebuilder is using >>> script from an external repo. There might always be a possibility that >>> future changes to lopper (master branch) might not be backward >>> compatible or might break something in imagebuilder. >>> >>> As such, will it make things better if lopper is included as a >>> gitsubmodule for imagebuilder. This way a specific revision of lopper >>> will be in sync with a specific revision of imagebuilder. >>> >>> Please let me know your thoughts. >> >> I think it could be beneficial in the future but not in the current state. >> The reason why is that the lopper changes are in an early support state >> (I try to highlight it on each occasion). This means that in the near >> future we will be improving lopper extract assists to cover some corner cases. >> Adding lopper as a submodule now, would result in a need of additional commits >> for the ImageBuilder fetching new lopper changes each time we improve something >> in lopper. I think we do not need such overhead at this stage. >> >> Also lopper's README states that "Internal interfaces are subject to change" >> so we can assume that the interface given to the user will not change. > > Forward and backward compatibility is something we'll need to think > about at some point. > > Personally I dislike git submodules and I would try to avoid using them > unless strictly necessary. However, we could specify a commit-id or tag > to use (the same way Yocto specifies component versions.) > > Given that it is still early stage for this feature, I think we could > ignore the problem for now and come back to it in the future. > > Or we could change this patch series now to take as LOPPER_PATH input > something like a SRC_URI in Yocto, which could be any of the following: > > git://some.host/somepath;branch=branchX,branchY;name=nameX,nameY > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsome.host%2Fsomepath%3Bbranch%3DbranchX%2CbranchY%3Bname%3DnameX%2CnameY&data=05%7C01%7Cmichal.orzel%40amd.com%7C5ae88781fff24f8e6a8c08da95be2fb6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637986941323037721%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dHzcGYqr9mIv2t746FnEE8QTrSmxqBJ4G9esebbAnu4%3D&reserved=0 > file://local.path/to/file.txt > > If we did this, it would be more future proof and we could use the > https:// URI by default with the "master" or "master-next" branch so > that we would automatically get the latest updates. In the future we > would specificy a stable branch instead (e.g. v0.2022.x). This is a good idea in general but has one big drawback IMO. Specifying the git repository such as lopper to be cloned by ImageBuilder results in transferring the responsibility of installing prerequisite packages required by looper from a user to ImageBuilder. Some of the packages are available to download using apt-get install and some of them unfortunately using pip manager which can be tricky sometimes. In the current solution, lopper is an external dependency and the user is responsible for cloning the lopper and making sure the packages are installed, in the same way as we require e.g. mkfs.ext4 to be installed. However, cloning a project from ImageBuilder means that it is the one who needs to fulfill the requirements of the cloned project and keep up with syncing them (different package versions required by different versions of lopper). Once the lopper+imagebuilder integration is in the shippable state, we can just inform user in the README with regards to which lopper's branch/commit-id should be used. ~Michal From xen-devel-bounces@lists.xenproject.org Wed Sep 14 09:07:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 09:07:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406870.649265 (Exim 4.92) (envelope-from ) id 1oYON2-0005re-JP; Wed, 14 Sep 2022 09:07:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406870.649265; Wed, 14 Sep 2022 09:07:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYON2-0005rX-G3; Wed, 14 Sep 2022 09:07:48 +0000 Received: by outflank-mailman (input) for mailman id 406870; Wed, 14 Sep 2022 09:07:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYON0-0005rN-N8 for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 09:07:46 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b22d0c8b-340c-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 11:07:45 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id h8so17649200wrf.3 for ; Wed, 14 Sep 2022 02:07:45 -0700 (PDT) Received: from [172.20.8.228] ([167.98.135.4]) by smtp.gmail.com with ESMTPSA id z13-20020adfec8d000000b0022a297950cesm13462479wrn.23.2022.09.14.02.07.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 02:07:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b22d0c8b-340c-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=S3hbsnsO8bUP9TSp7ZglWfwWoT4ej0T3vP2Vf4axeRY=; b=G7jMJbsndfm2/QKZljNIpEuHp+Nieo2q5dF44Ga2Gd7uQyl4bDAB4lpIV97YVjZUNG 5l2wpV4wp59OQrqv1gzPkT4A1SFJEDOjCzUpAQCJN60PCuz1hHUrmuVV5feyVOo27ja7 tT8HOSzVz58NlbGZD1sw2PYQH00itM5CRhaVShG1+4/nSbu+2loATpGlSY1wjCVO4W/9 avKIktGjEkFiV1Om8Qu2A+Vuu9ZiMayZmxsflrcIFwpa0d9BNgqnVfTVMbNelkPCludl POhE8/XFnLAxKapqupXD35EQFrUr9Lx0YPYXsluxELh7TzXdtxpftT/3VdHgG+B7Kf/6 GG+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=S3hbsnsO8bUP9TSp7ZglWfwWoT4ej0T3vP2Vf4axeRY=; b=Fp7paX0IXqKh2K1F70H0sFLDjqj6mPPG4Mapx+LKxNgzxMs+R5UU4szppGZQCOlYyR WB75uhrC7SzmFSsHq1u3iGnSKw8mz7HmscHsA3/QtG9MGpSQ1NUrTSGfvPJXMMJkZ3z8 lExQ6D1/fhFvUs4C/tY9iH5ZMWxIK1XDPLjSsLNzHLjwFS6ab1VusgF38lwYcq/XVNPX HNqO4M6+72eRPwRtbDpGLW5/DC50H4/u4w4qWMwvD1TJBXHjHB2juyxo8JXG+qumP0Q+ phflbzIQvUpEBxZi9ca/0wCmCrcJcyVFgSQSkNPeP3QfZcjO6R88LDYIhLXIzui865Gw qchg== X-Gm-Message-State: ACgBeo19JqFA+WI0nO9Bsg+SR/jdWdi10mUpUbL2Q6a1XLT8EbsgvU87 1Q31170pKy87d+k6VzFTfJI= X-Google-Smtp-Source: AA6agR7d57jlvfQGD4mmVzestJI6g+JSFVhlnr9SWQBdqsNpL7CF9bwHEO3iRUr/ROcB4KuBgxJNjw== X-Received: by 2002:adf:a70b:0:b0:226:e1f5:7889 with SMTP id c11-20020adfa70b000000b00226e1f57889mr20199977wrd.108.1663146464747; Wed, 14 Sep 2022 02:07:44 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <8be84a25-c31d-fd88-f913-c03c15046a55@xen.org> Date: Wed, 14 Sep 2022 10:07:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device To: "Ji, Ruili" , "qemu-devel@nongnu.org" Cc: "Liu, Aaron" , "xen-devel@lists.xenproject.org" References: Content-Language: en-US Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/09/2022 04:02, Ji, Ruili wrote: > [AMD Official Use Only - General] > > > Hi Paul, > > Could you help to review this patch? > LGTM. You can add my R-b to it. Paul > Thanks > > *From:* Ji, Ruili > *Sent:* 2022年9月7日 9:04 > *To:* 'Paul Durrant' ; 'qemu-devel@nongnu.org' > > *Cc:* Liu, Aaron ; 'xen-devel@lists.xenproject.org' > > *Subject:* RE: [PATCH] hw/xen: set pci Atomic Ops requests for > passthrough device > > FYI > > *From:* Ji, Ruili > *Sent:* 2022年9月6日 15:40 > *To:* qemu-devel@nongnu.org > *Cc:* Liu, Aaron > > *Subject:* [PATCH] hw/xen: set pci Atomic Ops requests for passthrough > device > > From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Sep 17 00:00:00 2001 > > From: Ruili Ji ruili.ji@amd.com > > Date: Tue, 6 Sep 2022 14:09:41 +0800 > > Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device > > Make guest os access pci device control 2 reg for passthrough device > > as struct XenPTRegInfo described in the file hw/xen/xen_pt.h. > > /* reg read only field mask (ON:RO/ROS, OFF:other) */ > > uint32_t ro_mask; > > /* reg emulate field mask (ON:emu, OFF:passthrough) */ > > uint32_t emu_mask; > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196 > > > Signed-off-by: Aaron.Liu@amd.com > > Signed-off-by: ruili.ji@amd.com > > --- > > hw/xen/xen_pt_config_init.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c > > index c5c4e943a8..adc565a00a 100644 > > --- a/hw/xen/xen_pt_config_init.c > > +++ b/hw/xen/xen_pt_config_init.c > > @@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = { > >          .offset     = 0x28, > >          .size       = 2, > >          .init_val   = 0x0000, > > -        .ro_mask    = 0xFFE0, > > -        .emu_mask   = 0xFFFF, > > +        .ro_mask    = 0xFFA0, > > +        .emu_mask   = 0xFFBF, > >          .init       = xen_pt_devctrl2_reg_init, > >          .u.w.read   = xen_pt_word_reg_read, > >          .u.w.write  = xen_pt_word_reg_write, > > -- > > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 14 09:14:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 09:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406877.649276 (Exim 4.92) (envelope-from ) id 1oYOT6-0007HB-8Q; Wed, 14 Sep 2022 09:14:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406877.649276; Wed, 14 Sep 2022 09:14:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOT6-0007H4-5A; Wed, 14 Sep 2022 09:14:04 +0000 Received: by outflank-mailman (input) for mailman id 406877; Wed, 14 Sep 2022 09:14:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOT5-0007Gy-BC for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 09:14:03 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 91a7f811-340d-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 11:14:01 +0200 (CEST) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Sep 2022 05:13:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5839.namprd03.prod.outlook.com (2603:10b6:a03:2d2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 09:13:53 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 09:13:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91a7f811-340d-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663146841; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=RW/3n3gnlZBydCrVFpd9v+PdkceLxnz1W47cEu+zC5c=; b=MZxXRXLMqB8jwxY7yUOMhMngeE03Ac5FX3STw2UIX3fRxIF24JHYEksv gCu2Ggg9KcPmVpsifq/t3FykWIE9ReLE96BBvfdKL91jrQlgCQ4YlqIwQ 802Z1QJm92Fu8eeUiaSg3Y2IF5FpzgUOk+ebHLLPmRK3KiHHMfYfL/pk3 I=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 80147830 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9iENyaylLx0mg0oZbJN6t+clxyrEfRIJ4+MujC+fZmUNrF6WrkUGn 2MXXz/VOP+LZDenf9wiO97j8kJTvJOAyNc2GwdpqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Uoz5K2aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1yMWJxNpASyNxlEEh8q qMaEDomVD660rfeLLKTEoGAh+wFBeyyZcY0nSglyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCShNWQH9Dp5poJui4TX5BZ237X3dsLcZ/SBRNlPn1ber WXDl4j8KkFCbYDAmWHdmp6qrunAky3JZaUyLayfqK473BqqwHQuJzRDADNXptH80CZSQel3K UYZ5y4vpqga71GwQ5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceWjgCx lKP2dTzClRSXKa9THuc8vKfqmq0MC1MdGsaP3ZbEU0C/sXpp5w1glTXVNF/HaWpj9rzXzbt3 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdv207gkrNAttFWbOY IronPort-HdrOrdr: A9a23:G8RRran4QMfXAzzVDwezKGnjT1XpDfO3imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC D4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR8Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqXneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3GlpT1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfYzhDc5tAB2nhk3izyhSKITGZAVyIv7GeDlJhiWt6UkYoJgjpHFoh/D2nR87heAAotd/lq b5259T5cFzp/8tHNxA7dg6MLqK40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd L6IRhliVI= X-IronPort-AV: E=Sophos;i="5.93,315,1654574400"; d="scan'208";a="80147830" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhGOeAlvrTdFoK4yycEoavBZ0yiO8wgOUo0dqh2dVBMBuZbsVOwp1Y2BM18tOpU2i7ZSbNQGUVUabfoaHPmwu2MVqbKz5aFjUPGtIqS9if4/xC69nt27Ye/467a0TKzs6FvP6y471Zj9V+usMOGV0uFDC6Xq+Y3SgQPsXv7mygFTCQz42l0ayLYPLdV1QPxhFZUVVYvPJqqum3tjB2isGI3zkojHQiNB+RMyDsIGSonUf8yaAhQENDYGkSB0sRDOZdihB6dmkaTr+Br0MGrJghoFwXjKSvUHuDYfQEOJ9TRa6v8i6anasXJ5BsoJ6cZwhKeIOZBAG4+78f70xookwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HyIRimXdcvsWwDAu0Fp3XuJ3HBSlF0vaJM+TCBloFwI=; b=PHYgag/xJQz2kHvvNz+kIWFdRWujChp/nUuH7YpC5qgoBh5sKC/K+/QUuHYyTydmMRIJIPoZdJ8kyS1dG/i5jUMDpSo8cXsSfn0Dv41rcmhB52DotMcr3qy8IBbj6yQeP/zd658pry19bSW3r+SZBB2TOXaBQimLp7v+EVt9uaJZP9ePik9YknYj+3TSfjCfw0DNQDRiryfgxM+AE0p6K6S26xGO49dtTkOX0qqUJhnKXvm8rh48reexr586pL1mwrtg53GAbAT/tX2fMOfLLnJEaQUNv4TLSFIUmlfLzuEO5frN5cRAfwikioTBt1HjkoVdrw7ZTKv7dDV2mBOneg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HyIRimXdcvsWwDAu0Fp3XuJ3HBSlF0vaJM+TCBloFwI=; b=lAAVtJTXXIbSXQyXe0hmFSCiGYFjVwF3Pt73sd7heXAGenBJgXUbU70/0Aj7JtKfOvSbdpk1WCBSurW0RGjV/3lfCED9OqE3yQA6YnVjWTLJkL/8kcFi+5nrWbUKJ+rfiBv10JkeQVwUdBnySF1MLpyuqhJgPpPCjNs64nbLUbU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 14 Sep 2022 11:13:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Message-ID: References: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> X-ClientProxiedBy: MR1P264CA0198.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:57::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|SJ0PR03MB5839:EE_ X-MS-Office365-Filtering-Correlation-Id: a5494902-6f40-481c-1a24-08da96317198 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3wQkJS6T8UKLOqEeZvXN5RBx1CHNMXhIu+rtzxJWCljKKq5qGSiqtTxZR9L8PxiylyeoSyb5sqyvg2iTmWM6SeF20x+mT9xGPQt63Lq/nI/XEzpZdjLzsRadv34W12CG37e5t9qJ5qvRWbx6SMWsjG/Mpmn9lpLA4C8rlzi5Q9dsn1D9h0Z532lWei8aDrc0Dfuei1quRE/LNTSkN4wkBt4x74iSUIM7chvt1LSvI4MHEEa0RdOnlo5xopCxhehUgPir7aXmUmaaWFnG7onFJ4uMUB7zlBmB5FeL5QO4W9u3JbAdodwLjW6PRpmmGZ9Ne3LvEkat2ldN6CbsECZ/VVzgjUGieoa47kvJgONMQNrm4CuDeOESeoAtI2UkTLtHedYo7RJuHSHQBiDNJ0+oM9PUVUrIjXYXYaYlknhNUhV67N7Ls3lTlUPFcZfWwV2vNXzpSommM+UYNQ2EMSkJaWhJkRdlRsLt24UDUBUS4mRmJm0rjRjHxCDtUPDzlcW8pnNAXYGrOwirNpkZEnas8qdWprxlNMJTXb+eUiT72lebS4SqzNn14ssLg8NtoAPoBRktjHwgolvrrchtQMqsS69XUUZ+yUfEKFMtXYc4aP5mzV02gX0C5MZndRMcwef0lIpGRTxpCn40Cm46h6r0Jt+TWDH+pXy2HtBEXTi/nGUXhottc44U5eFL8qOVYCnoF6lrWqyQkg7qvog6XhalViEQQF2M8MdRWe+H6qQ/wzprHcSxJ+lOtFiZY3oTUjbecv+qm8ldlLQ/qdup1EN90w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199015)(85182001)(66476007)(4326008)(8676002)(6666004)(316002)(66556008)(6506007)(41300700001)(186003)(54906003)(9686003)(26005)(6916009)(8936002)(66946007)(5660300002)(82960400001)(2906002)(83380400001)(6512007)(53546011)(38100700002)(86362001)(478600001)(6486002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b045S0QyWTJ2eVJlWUc1QjZRVkRWMno1YzVva2duRmI3bHRtZzdneGlpd2RW?= =?utf-8?B?Qi9xSkxNK0MraytReTZrOENrS2pTQ0hXTG5qcFlBRjh1YWVDOWFZdEZtb3Fa?= =?utf-8?B?RUdsQ1h6dUtNaDlyTWhpcGZTQ2dpNW1MVUxYTDQzMmtCSVhtUVBhWVM3R2xP?= =?utf-8?B?Y25uSzhET1IwRHYvV1Y1S0NTemdZYmZ0SzFqYm1NMDJJTkdBYnA2dkJibEhV?= =?utf-8?B?dmtXNmVZV1ZWQ3oySW80bGZadUxlbE5uazFqRjFGa1o5YnBZWXZxYjhOaDJM?= =?utf-8?B?a0NEbk5IZXlHSFRBSjZxZUE4eEVSNXlwaUhuUjBVMEsrZDF2Y2N4WWlJMm51?= =?utf-8?B?UmNGU2dwNk9aM0NpSUo0QWlWVmZhZERYYkljT0kxYlp1cWY3V1VQREpHT1E1?= =?utf-8?B?T3FkOEJtU1JlY2lQY3NLc0x2aC9mM1h2d3RXVFZNZGtxMFpFdEZyQUw0L1JT?= =?utf-8?B?QjI5QmQ0dlBqMW9yRk0xOG1oc0RBYWFHQ3RPTFNHSmFZWndpUldCZ1VUUzdt?= =?utf-8?B?d3dNelRkb1NjZWVhVW9wZENVWU9WTjFPWTJZQ2x0eVliM3YzbmdaK1J3Y0xI?= =?utf-8?B?NitwTkM5R1RzMHBQRGFFZTc2a1VMTFJXRHAzRWxmbkJSSmxWSFNRUjhxRWhR?= =?utf-8?B?Mk1pQkZBdG0zVGo3WXU5OTFGR2RsTTVNVWxNQXRySnJKdm96a2lTd2diUWxZ?= =?utf-8?B?TVdaeG43MUFtVkoxeXpTbFVuMUlpM0dSSHQwamgvK2VNVjZkS0hOb3J3aXAx?= =?utf-8?B?SStwMGVEVUxvQ29TK0lFRHFFNnlYSHhvSmdIbEt1dzN1NkNZT2YzWEJRNTJr?= =?utf-8?B?RW1ueWh3ejhCTkZXckR4TVRTaDJWQk1xWldxMS8xQUdkWE9RaGxlZThFZUZy?= =?utf-8?B?Ym9LSXhUKzVzSC9WaXZTMjRZUWwvMVJLRy9WajgwT041MFZwaDN3Sm9pSjBn?= =?utf-8?B?dzQ0STN4bXJpd2svSFZ4UUdTRWNNcjE1VDRBbk0wYkhxdmwzSTBrekg0eC8r?= =?utf-8?B?S3ZLWHJ0aXljcjUvRi9RdHNaTlozT3JvTFVSVEkrZ2tXeUxBWUVrSVl0Um1t?= =?utf-8?B?TUVBRFJDY3NCNlF2bnVKdFFGZGNrN3BYYXhOU2lZT25FZ1ZSR3JKdk1lbTRs?= =?utf-8?B?TGNwb1hrVU9vWmZSazR2Zm1sRzhJd1FIUHdlL3pJU2g4TzdwYUFCZm0xQVox?= =?utf-8?B?RUdqSzAyVnB4TVZEbGNoQ1JiY0NMOG9SYXFOSGJvOWpYdmNuYlBBRG5Gblgy?= =?utf-8?B?d2ppMFZJSVEyZmZ5VE44ZU80bnZINnhjYWJwUzU3bFZzSkZmVk5XZWV3UjV0?= =?utf-8?B?V2hveWpxVURLSjhnUmNkRFo1M0FjZm1EL1hZVU4yNjlXdXc1Z0szRmhwUHVB?= =?utf-8?B?SEtxM21ZTEVkbHUxNVZnME5VeFU1WTFqRlAwUnNIQWhKMnY5WmpHc1dCMnEy?= =?utf-8?B?aGN6aGxQZndlVDA2Q3FWbUZxSVNZM0kxcDB6REZlaVVLOFJvOWpTR0NDRmVa?= =?utf-8?B?MXR4K2ZQRk9EVGxNQS9QejBYYjdwRlJxMkVabEMweTE5YkxPYjJNUkRyRlI0?= =?utf-8?B?Smp6cHUreGZYMWVhVVVDUkdOMDg3UTBUSHdBV0hTMGU5TkNOL2pzMXZ4UWNV?= =?utf-8?B?blRZd1kwNDgyZ3VsRU44QW9mYkd0KzRWY1hQeHA2MG1ZSCtyaUdzK1k3cnAw?= =?utf-8?B?dEkvSDdiQTF6OFU1by9DQ3E2UWFYRi94ZE9DLzcwM3dTTFR5aVRuZ2lwUFBL?= =?utf-8?B?NEgyRnQ1bjlhTm5FcjlTbk9hb0RIQ3ZlR1A1SU5uQ1V3ZHJvYzZtY1d6QXY1?= =?utf-8?B?dWs1bi9BQWVza1A4V09Ja1JwRVQ1VDdjZWlWNUxkdXpjVS93TnM0Q0Y2Y2dl?= =?utf-8?B?QXM5TWMvMHF2MnVINlI3czlHWWorQ2JHbWUxQ0tZSlpJbndscS9BZ24rRUxK?= =?utf-8?B?WDlLZU92OENNTHNuYzR5V2grcDVqT3MvUTZJTGpRaGdPdTFlS29QUkVISW9h?= =?utf-8?B?OGtJMEhHTUZSMlRDeTk4a3NsZUx4Nm92VWZXNG5sOWIrUjBuOU5YYzZ0Vkpj?= =?utf-8?B?TittMm95aHlmOWlKTWxJUUxNU0NOUnlyYWVQd05XRUcyaDVKMVJDRnpZeG4r?= =?utf-8?B?eVlaa212S0tzMlZSSTZzQUgrR0NsOCswVk9WMk1KdnNTcWhoMFRaL1ZsSVNF?= =?utf-8?B?OHc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5494902-6f40-481c-1a24-08da96317198 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 09:13:53.2515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mGTpkVzeKH3LPAkrwsczwC2aM7sd/nJFV48VbJoJcwge5vU9yCPHdPdP0iNzOA3cczAwdpuYHTY+P81GITdLtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5839 On Wed, Sep 14, 2022 at 10:31:34AM +0200, Jan Beulich wrote: > On 14.09.2022 10:14, Jan Beulich wrote: > > On 13.09.2022 16:50, Roger Pau Monné wrote: > >> On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: > >>> show_hvm_stack() requires interrupts to be enabled to avoids triggering > >>> the consistency check in check_lock() for the p2m lock. To do so in > >>> spurious_interrupt() requires adding reentrancy protection / handling > >>> there. > >> > >> There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will > >> trigger when trying to acquire the p2m lock from spurious_interrupt() > >> context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> > >> percpu_write_lock(). > > > > s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), do_IRQ() does call irq_enter(), and that's the caller of spurious_interrupt() AFAICT. > > but yes - we could nest inside a lower priority interrupt. I'll make > > local_irq_enable() depend on !in_irq(). > > Upon further thought I guess more precautions are necessary: We might > have interrupted code holding the P2M lock already, and we might also > have interrupted code holding another MM lock precluding acquiring of > the P2M lock. All of this probably plays into Andrew's concerns, yet > still I don't view it as a viable route to omit the stack dump for HVM > domains, and in particular for PVH Dom0. Sadly I can't think of any > better approach ... Yes, I also had those concerns. The mm locks are recursive, but spurious_interrupt() hitting in the middle of code already holding any mm lock is likely to end up triggering the mm lock order checker. One (likely very risky option ATM) is to introduce a per pCPU flag that when set will turn all mm locks into noops, and use it here in order to avoid any locking issues. This could introduce two issues at least: first one is how resilient page walking routines are against page tables changing under their feet. The second one is that any page table walker p2m helper should avoid doing modifications to the p2m, so no P2M_ALLOC or P2M_UNSHARE flags could be used. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 14 09:34:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 09:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406885.649287 (Exim 4.92) (envelope-from ) id 1oYOmc-0001Iq-Vb; Wed, 14 Sep 2022 09:34:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406885.649287; Wed, 14 Sep 2022 09:34:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOmc-0001Ij-S0; Wed, 14 Sep 2022 09:34:14 +0000 Received: by outflank-mailman (input) for mailman id 406885; Wed, 14 Sep 2022 09:34:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOmb-0001Id-Qg for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 09:34:13 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 643fdb3c-3410-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 11:34:12 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E3E6222522; Wed, 14 Sep 2022 09:34:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9900F134B3; Wed, 14 Sep 2022 09:34:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id r2T8IxOgIWM/LQAAMHmgww (envelope-from ); Wed, 14 Sep 2022 09:34:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 643fdb3c-3410-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663148051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mr7DJ+rONRlRTlvy+2ELh9/7A7OmuCGJ3+umwNNxXgM=; b=tZzq81NRhCyFGpPkYMpW4W43Ly6vzEB2hgOXxn7bnVELKQ8dmLSKQbl9jYKSentCuH3lRE ct3qtreOfAzXTSOAR95EOTP35/NEe3V6HmcxUK7FDtkDXx746sayJ3K8JlFP739GWppbv1 Qs7Knp/3YS1/fL3SjhQxyPboocM6Jz0= Message-ID: <739b7b48-c488-5216-064d-ff7fd77e76a6@suse.com> Date: Wed, 14 Sep 2022 11:34:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH -next] xen-netfront: make bounce_skb static Content-Language: en-US To: ruanjinjie , sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220914064339.49841-1-ruanjinjie@huawei.com> From: Juergen Gross In-Reply-To: <20220914064339.49841-1-ruanjinjie@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------z297QInJ2eAbukrn83P9heiv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------z297QInJ2eAbukrn83P9heiv Content-Type: multipart/mixed; boundary="------------FTlzLylkOtqjiWteUcsK9JYi"; protected-headers="v1" From: Juergen Gross To: ruanjinjie , sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <739b7b48-c488-5216-064d-ff7fd77e76a6@suse.com> Subject: Re: [PATCH -next] xen-netfront: make bounce_skb static References: <20220914064339.49841-1-ruanjinjie@huawei.com> In-Reply-To: <20220914064339.49841-1-ruanjinjie@huawei.com> --------------FTlzLylkOtqjiWteUcsK9JYi Content-Type: multipart/mixed; boundary="------------EOkORFmsPIA8fXrPfo0M0WHn" --------------EOkORFmsPIA8fXrPfo0M0WHn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTQuMDkuMjIgMDg6NDMsIHJ1YW5qaW5qaWUgd3JvdGU6DQo+IFRoZSBzeW1ib2wgaXMg bm90IHVzZWQgb3V0c2lkZSBvZiB0aGUgZmlsZSwgc28gbWFyayBpdCBzdGF0aWMuDQo+IA0K PiBGaXhlcyB0aGUgZm9sbG93aW5nIHdhcm5pbmc6DQo+IA0KPiAuL2RyaXZlcnMvbmV0L3hl bi1uZXRmcm9udC5jOjY3NjoxNjogd2FybmluZzogc3ltYm9sICdib3VuY2Vfc2tiJyB3YXMg bm90IGRlY2xhcmVkLiBTaG91bGQgaXQgYmUgc3RhdGljPw0KPiANCj4gU2lnbmVkLW9mZi1i eTogcnVhbmppbmppZSA8cnVhbmppbmppZUBodWF3ZWkuY29tPg0KDQpSZXZpZXdlZC1ieTog SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg== --------------EOkORFmsPIA8fXrPfo0M0WHn Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------EOkORFmsPIA8fXrPfo0M0WHn-- --------------FTlzLylkOtqjiWteUcsK9JYi-- --------------z297QInJ2eAbukrn83P9heiv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMhoBMFAwAAAAAACgkQsN6d1ii/Ey8a lwgAicNZRZqQAoZQeWQld5M/oFJQWydKiMEX0CTzhggmt6K5qGhDAh5S6fCjySBusrq2r9+q8U74 SmBvrKl4QpI8CyBtPXAdQo5nWjab5N8gOC7crIWqYwCgQf2YOOXFbGz5m0b0ufm1rXaSP/3dapOT NTKjcRBBX9Zhr01eJ0Zwga3A7m17gc8eTmAlS5U2JKicbfKpywOeLgqfoQz5mxDuZWysjuPg3Twc xALkdxjYAHSKGlvs68GNzM5dwReCB6pSTsr21+xvX0afp+DJ7qE32A/p8aV1SQ0tguo9QyWSmNi/ 1MeYehvVMY5u1TMH5SCwtHiMsCMgG9U/V9iZNNdV3Q== =SRkQ -----END PGP SIGNATURE----- --------------z297QInJ2eAbukrn83P9heiv-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 09:35:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 09:35:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406895.649298 (Exim 4.92) (envelope-from ) id 1oYOo9-0001yG-Ct; Wed, 14 Sep 2022 09:35:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406895.649298; Wed, 14 Sep 2022 09:35:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOo9-0001y9-9t; Wed, 14 Sep 2022 09:35:49 +0000 Received: by outflank-mailman (input) for mailman id 406895; Wed, 14 Sep 2022 09:35:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOo7-0001xv-Sb; Wed, 14 Sep 2022 09:35:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOo7-0002on-Qs; Wed, 14 Sep 2022 09:35:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOo7-0002zO-AD; Wed, 14 Sep 2022 09:35:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYOo7-0001YK-60; Wed, 14 Sep 2022 09:35:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9RahBTElt32jNoim+O5vGByXWGuu2CVPXrY8aF49VQE=; b=aeK0ao37v7xz0H3+dQbvXC80cd m53eHS3xj0KtiiiE0ltahSLeYKMHjmy0aN6/DbvBqbnlBe19EJLLTa5SgZ4Hi/XnU+wKH8NqPh2wF k5667638eTAcMTGwyZYJWwFdfOQ688CVkxM4oICa1HUyV/gEO+eHnBzZOdckDYFjKdPg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173186: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=838c730fe61578847823da1b815e4c9c5ee1bed4 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 14 Sep 2022 09:35:47 +0000 flight 173186 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173186/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 838c730fe61578847823da1b815e4c9c5ee1bed4 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 41 days Failing since 172151 2022-08-05 02:40:28 Z 40 days 306 attempts Testing same since 173186 2022-09-14 04:09:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2507 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 09:45:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 09:45:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406904.649309 (Exim 4.92) (envelope-from ) id 1oYOxL-0003Y9-CF; Wed, 14 Sep 2022 09:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406904.649309; Wed, 14 Sep 2022 09:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOxL-0003Y2-9O; Wed, 14 Sep 2022 09:45:19 +0000 Received: by outflank-mailman (input) for mailman id 406904; Wed, 14 Sep 2022 09:45:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYOxJ-0003Xw-L2 for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 09:45:17 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efa32e39-3411-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 11:45:16 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 59B3F5CBED; Wed, 14 Sep 2022 09:45:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D32E134B3; Wed, 14 Sep 2022 09:45:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n/4WBKuiIWM8NAAAMHmgww (envelope-from ); Wed, 14 Sep 2022 09:45:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efa32e39-3411-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663148715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yKfeJbs5hDA1o+ehIbGNBCxMhbUIcPjrCsvY/2cHkGk=; b=gooCARLUKZSIjud7D9AvrBfUKSxeZksVlb1RPSheoj5JXZuC6n4xxoF2y/Bl2cLj/9vkCS Csxu/Vg/YTJmb1z73Vk/AfJYgj4NJ3QRg9WewurGmr3JC2oHB9IMwDqIjLDMNQCuithW2e iXb91qGHh60wkR8BwkvqSMgYBt3URJ8= Message-ID: Date: Wed, 14 Sep 2022 11:45:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed Content-Language: en-US To: Paul Durrant , netdev@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <20220901115554.16996-1-pdurrant@amazon.com> From: Juergen Gross In-Reply-To: <20220901115554.16996-1-pdurrant@amazon.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mKgRau0TPHWuTQ3U8s6OtcMJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mKgRau0TPHWuTQ3U8s6OtcMJ Content-Type: multipart/mixed; boundary="------------CFFRyEQ0whO2VsENi2DVBvXQ"; protected-headers="v1" From: Juergen Gross To: Paul Durrant , netdev@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: Subject: Re: [PATCH net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed References: <20220901115554.16996-1-pdurrant@amazon.com> In-Reply-To: <20220901115554.16996-1-pdurrant@amazon.com> --------------CFFRyEQ0whO2VsENi2DVBvXQ Content-Type: multipart/mixed; boundary="------------Ku6rUqdbMST8shpZCHASxAtE" --------------Ku6rUqdbMST8shpZCHASxAtE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDkuMjIgMTM6NTUsIFBhdWwgRHVycmFudCB3cm90ZToNCj4gUmVtb3ZpbmcgJ2hv dHBsdWctc3RhdHVzJyBpbiBiYWNrZW5kX2Rpc2Nvbm5lY3RlZCgpIG1lYW5zIHRoYXQgaXQg d2lsbCBiZQ0KPiByZW1vdmVkIGV2ZW4gaW4gdGhlIGNhc2UgdGhhdCB0aGUgZnJvbnRlbmQg dW5pbGF0ZXJhbGx5IGRpc2Nvbm5lY3RzICh3aGljaA0KPiBpdCBpcyBmcmVlIHRvIGRvIGF0 IGFueSB0aW1lKS4gVGhlIGNvbnNlcXVlbmNlIG9mIHRoaXMgaXMgdGhhdCwgd2hlbiB0aGUN Cj4gZnJvbnRlbmQgYXR0ZW1wdHMgdG8gcmUtY29ubmVjdCwgdGhlIGJhY2tlbmQgZ2V0cyBz dHVjayBpbiAnSW5pdFdhaXQnDQo+IHJhdGhlciB0aGFuIG1vdmluZyBzdHJhaWdodCB0byAn Q29ubmVjdGVkJyAod2hpY2ggaXQgY2FuIGRvIGJlY2F1c2UgdGhlDQo+IGhvdHBsdWcgc2Ny aXB0IGhhcyBhbHJlYWR5IHJ1bikuDQo+IEluc3RlYWQsIHRoZSAnaG90cGx1Zy1zdGF0dXMn IG1vZGUgc2hvdWxkIGJlIHJlbW92ZWQgaW4gbmV0YmFja19yZW1vdmUoKQ0KPiBpLmUuIHdo ZW4gdGhlIHZpZiByZWFsbHkgaXMgZ29pbmcgYXdheS4NCj4gDQo+IEZpeGVzOiAwZjQ1NThh ZTkxODcgKCJSZXZlcnQgInhlbi1uZXRiYWNrOiByZW1vdmUgJ2hvdHBsdWctc3RhdHVzJyBv bmNlIGl0IGhhcyBzZXJ2ZWQgaXRzIHB1cnBvc2UiIikNCj4gU2lnbmVkLW9mZi1ieTogUGF1 bCBEdXJyYW50IDxwZHVycmFudEBhbWF6b24uY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdl biBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg== --------------Ku6rUqdbMST8shpZCHASxAtE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Ku6rUqdbMST8shpZCHASxAtE-- --------------CFFRyEQ0whO2VsENi2DVBvXQ-- --------------mKgRau0TPHWuTQ3U8s6OtcMJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMhoqoFAwAAAAAACgkQsN6d1ii/Ey8Z Xgf+Pl5pBGReldtMqSYSmITrQFpThIYU5cj2ulvyltkDXipWyYnAUcPbt00S5TUfmno+hNcLL/tj nZHMmmacifcOMWTVmLc2y9BC6DRITsBFukQRZFVOXGm7CwW/U+Nm497MeRXqKYz8O6l8G/DP3nLc Etkn2lcT0pyyWfwG7xOlYE0VhhWkRf++agkpVbwUbvnMS+lng3T6qJWcaijMAxrk2cge9QSQ9FNp io8vrNHT2jfcyYXsd/7koB0eQC8AVPSrky89/U31dbkhlO8PU+RpeXQ/75AZyB6kG1SuJrwPOnJc 55k883J/k5MrgmaoLMNp8kOzFN2+cyzVnuKhPGkEhA== =LrKm -----END PGP SIGNATURE----- --------------mKgRau0TPHWuTQ3U8s6OtcMJ-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 10:08:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 10:08:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406911.649320 (Exim 4.92) (envelope-from ) id 1oYPJQ-00068u-7n; Wed, 14 Sep 2022 10:08:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406911.649320; Wed, 14 Sep 2022 10:08:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYPJQ-00068n-3i; Wed, 14 Sep 2022 10:08:08 +0000 Received: by outflank-mailman (input) for mailman id 406911; Wed, 14 Sep 2022 10:08:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYPJO-00068h-19 for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 10:08:06 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1dedf6a3-3415-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 12:08:04 +0200 (CEST) Received: from BL1PR12MB5993.namprd12.prod.outlook.com (2603:10b6:208:399::9) by SJ1PR12MB6171.namprd12.prod.outlook.com (2603:10b6:a03:45a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Wed, 14 Sep 2022 10:07:59 +0000 Received: from BL1PR12MB5993.namprd12.prod.outlook.com ([fe80::7189:8652:da69:2158]) by BL1PR12MB5993.namprd12.prod.outlook.com ([fe80::7189:8652:da69:2158%7]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 10:07:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dedf6a3-3415-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEOrQx9G+VzoB3p3Nw5TxLvBc0Da2+wspTyv7bPAzvcfigdJRN09WyBf+LdRrzaCSjaFkObxQRlGQFR8awRYnzeBigrRmHQ/G9Z44Fr5TcUWe2vqyAGdX3zA/ngWsofXRoYTil3buxZribliwpbeWzMtYnJTNpl0WUFDUBnWiVx8VEppfI7f0wg+K5N3dncFMJ6TKiDx56o68n16a4zCFIbUdPrDLc4lrjayJVtVI/ctETZ5uuCrig8Rnd6Ua7nrGQl4ip3hdI6hXtkvlJWc98TcghSrRujsty0Ww3FyDP+deRTpa1lrze84/456RHMhcm/OdjmVdJ2Oy73EWXxJjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HQlRZp/LsDa23blJpgPD4b7fA8JpfcfZhwrf8HpH2rI=; b=k1Z+6bWx9XD0RrjGNsNVLWWyi5nRdiQx0RIC3x/edY7flc/l5TA4JNLElW0GfyNoOAB6tWaaJVxk/8xifAfffHsLLKTNyn/FdXPy3Ys01x6XSHIw0OvyuzUnhnPSv5cUAQGUdnP9n+J0fC2jmG+kuyIyhi7Reh8LR+0dLHUOuDAXYRXIW47js8kRLHmgrYAL0Y/BeZFaYvo39wUz5Jx3ZBLFpVSicKlIRsV7MxvifFB0+wrfrX8p8e2M7882P832Gl/kJd4g1oBJA6bATf3W6L4WwKjkeREW6uVuSwlYLdcEy60Jej6elfK3Jd0UvZ5ln56SbsMrprJipRP5IOreRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HQlRZp/LsDa23blJpgPD4b7fA8JpfcfZhwrf8HpH2rI=; b=X3wBkhBt5OC7e5a30NOz8oWRF5BJbZjgctoJuaLRZ08azf4HCTy7dhXHddTv8rYB+aEJONY9vYopvOYPActqlfURjjgmY57GJSbPLqt5yA33tAdrt2Mt/hR44NZuz5M4nLzJ/Ec81BDmljaxuavpZ/9R2BTF18M8Zz4GK2fhuC8= From: "Ji, Ruili" To: Paul Durrant , "qemu-devel@nongnu.org" CC: "Liu, Aaron" , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Topic: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Index: AdjBw9S5XjagBB9xT0W01YXm2Fq4yQAkLQ9gATHwuGAAP0mxgAAB/V+Q Date: Wed, 14 Sep 2022 10:07:59 +0000 Message-ID: References: <8be84a25-c31d-fd88-f913-c03c15046a55@xen.org> In-Reply-To: <8be84a25-c31d-fd88-f913-c03c15046a55@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fe71ddb2-53de-4503-92e7-b763c759a0b3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-14T10:04:41Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR12MB5993:EE_|SJ1PR12MB6171:EE_ x-ms-office365-filtering-correlation-id: a13cb2c6-4007-48a8-4bf2-08da96390096 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ITtvtnb2jLdJqsH9JHV+lVQfdmoR8JqdhLqK1t9yOgl+8rn1Okfr+aV5DKC5kOJUaqvXgZFeEuyG2r40T8ef4xxbk3FXjoYvGtPVG37458iNbD8FZ8odnBiEeYhB9LG/IVet2nX4LsZZNxpjpONkDU8plt5A+uyrJgzvtGOv9FhqnC2ePzXeiK8n9Zj9j0CIA9rCCwVbxGCg7z7rEsGaFHwOcG7twSPbniL0mHu51F0X+yoD9dp3SXh8fyu1Bi7WTGeKdSJw4xoGmtyNGJ+9DkHY5FB0gEBuWuMZaLex4cyV5onlg4J5hASg2tw2EAdWuQ3uGQCu2/0rnDEFrQZ7P/lOqQewLuqWt4JnIKmRkjh6LUBfcPVN2uAWBFKtbHc9g4FenfKfpblwu5d79boi2mSmKo0M1AaB5XhfQOYIQ7x4dW8NstmnFYUn3Ti48w3kizdTlRLwNKkeQHdQ69LvW5FPpvU9F2vKp/vv8v9HTd+ZTcQwBLVGt1ttEn28t1s1X5yARmzwrZgesRyCpeOGSWQzvGSvseeR/h75GfamV8onh/ChjDe7IBtSffNRXubJh9LDeEZLjDLufPn3rNYbGcGbyrTLedxILcHUArGHIXaNn7w0zlldj++RzT9xqh17jkxV0nlm166I3TyhAfX++6mlfryYyFlOgYCAPtOMQCl14NrCYKEVACqExOwQ1pDKH6KJdv9fzczvjEmvkcG7GzBkmB7GIQ/NvQwHWxR2p/JXmyAL8jYa5YeaugRYgVi+r63hkQ4bfNlYpvrNm2o5YznfR8Giaw7qYmr9j1N6cfrOV1BU6acoRuQh+5f65lVVGoZVVzRjHmb6izqu1Q0lAw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5993.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(451199015)(54906003)(186003)(66946007)(6506007)(26005)(4326008)(53546011)(9686003)(478600001)(316002)(71200400001)(45080400002)(86362001)(52536014)(38070700005)(66476007)(64756008)(41300700001)(55016003)(8676002)(76116006)(110136005)(66446008)(5660300002)(83380400001)(7696005)(66556008)(966005)(122000001)(38100700002)(8936002)(2906002)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?U1UxaHdoUElDRjEyVzhpVHF4SWlPS1FDQUh4aWQ4NXpzbnY2Vmwzam9C?= =?iso-2022-jp?B?SUR5bjhxUzdhNjVWWTNQeUNiblNaRGhuWkFlVC9DRFRTQjFZMW13TWtr?= =?iso-2022-jp?B?cm1MSVk3YkZyRHh2eXBCYXl2K2lIdlVZUDBuYVFrZTM1VHR4VXZ6UThG?= =?iso-2022-jp?B?Mk5CTVdhenhMMEFiaEx1N1VxeDJxT3k4RWxqdXg4amV6MHpQcXlHVGR0?= =?iso-2022-jp?B?QnZRc0JIZzJsckF3ZStHalgvMDFERmhoS1dlS0Jja3Z5YXlwVlZjSU04?= =?iso-2022-jp?B?emkvR0xCKzBGY1Zack5jeDRaaFJpbm9CdGNISWJ6RmJveGh0ZG1URE84?= =?iso-2022-jp?B?aldGZ0U3cWlid0pCOUxpdk5NRE5HdWwrb2UrMEUxWXlNQ3dub2JvRUNL?= =?iso-2022-jp?B?TWlMV0lpREp0WTRBVVBhWitNRTExOFlRajlBeGg3RjZnTUp2SUVGQ1h1?= =?iso-2022-jp?B?RjhIS1R5RzBQOFhRSGdHMVlwZEpPS2tUdjJua1RqR2xLQ2ZJOVVjKzBS?= =?iso-2022-jp?B?T1pVTmMrcWZadnBVaDhhVDg2a3cva3FRQ1lTNCt0aTVLQVB6TUpQM0xw?= =?iso-2022-jp?B?S1Y2aG9VSUpBZmFtYUgzVlFiSkg2V1AyUi9YSWM5TUJWNVdtcklDMGpI?= =?iso-2022-jp?B?NXZhMUpaODZPRGpETFAvRHpFc2U5U3RGMHNjRHpTSnNXQ20wL1JNSCtl?= =?iso-2022-jp?B?VkpvVlpMT2toZGQrblg0V3BwMXZhMkZxdEJSL1ZGbFJsRFpDKzVsUE5u?= =?iso-2022-jp?B?aS9TWndiVVIrSktnZ1hNRVNOWTVrbDRUTUcrdEppUm1lSktld0d3ejZY?= =?iso-2022-jp?B?VmlCL2RTYUVtVEVKQTlpbG4raDFNTmVMOXcvcURrQUtNWTEwSWhmUjEy?= =?iso-2022-jp?B?UGlsWkxtaXltd1ZkUkN3aXdDNDhDWmNxNW9ERnZYSWFEemxuRlArMjl3?= =?iso-2022-jp?B?aGRqY2oyeHc4NzFwSzJ2emdaZWRKbCs5ZWFXeE9yQ0ErNmlFeEI5YXRu?= =?iso-2022-jp?B?U3h4K3d6UjE3WnRGZXFJdTVjZElnejZqdWlaNDFQV2l2aEExVzRpSzZt?= =?iso-2022-jp?B?cWdOdHBhLy9XWDRxM1ZnN3lkQXhkemRqWVhhdGorNVpsMHB2bUt3d3By?= =?iso-2022-jp?B?RTM4aEMvaGVXckd1eXRHaWpSdkFDdXFybUtaNVY0YWpXV05ScGR2UHVs?= =?iso-2022-jp?B?NC81aDlrc3oyQ3V0V0x4eHFsdjQ5MkRKY3poTGM1Nk12QzRpNjcxZUt1?= =?iso-2022-jp?B?cUpMb25ZUm10VXRrZjduMmNNWlZtbFBrSHR6TzFncmtZYTArc2hnZ09z?= =?iso-2022-jp?B?blNqYlZ1NFRncmNwTjl1ajBLaUo2VTcwQk52UXo2Q3E2Q3QwWEJVTC82?= =?iso-2022-jp?B?Zi9pL3hOaHJ1RWhTTmJXZUR0QmJzYmI1QndiWnB4Z0xiZE15NzVQUmxW?= =?iso-2022-jp?B?NG9GUEdWOHhEbit2ZENZT01EMlljaHdpZ0hKWU5oU0hLZzI0SlNzbWdu?= =?iso-2022-jp?B?dmpITUVDc3NWQ0Ewenc4TThwbXRrL3FzKzhyZGxPSGdHNXlFaDFRRHJJ?= =?iso-2022-jp?B?anM1dmw2YTBBM05JdGxOK0tGa1JQYUNxUE90K0xZVmVOVnp6L3dqSGI5?= =?iso-2022-jp?B?dXBQNDBuS0JTVUQ3LzNzWUN2Nk1PYmNPZjV6UmVoZFFHcnVJNm92a1VN?= =?iso-2022-jp?B?R0U2bmNpVHBKL3V2TGhVNUxhbXF0djZkVFZCYjl5TVBJUjVDUFRJS1Zr?= =?iso-2022-jp?B?YVVpUXY0UEFqVEFuc1pLOEwvT0l2K1NRY1pwUGl4ZDU4RWg0UStDV0Rz?= =?iso-2022-jp?B?LzJlaUMzMUhVV1NZOHFQNDBTdWd4U0xTTkZTSmlpc0hnQTh5dUdmMzFu?= =?iso-2022-jp?B?ZVVid21mekJoUjNudk50NEtoVlNiZ1NWbFpPc2pKdTNwaVpPMTRNYTVj?= =?iso-2022-jp?B?a0pNbzRKWVpTVmc3WHZqQVJyVVByV1JId2IxakFyZVk4eTliQlNrK3NQ?= =?iso-2022-jp?B?Rjd3Lzd2RVFpaUd3ejdaUGlOVUROSm0zcHZ5TllGZm16bjM0T1hPYy9T?= =?iso-2022-jp?B?czhZYXVudjRzTFlMejFkbi9TdGEwMUg1d3VwenI1RlROS3ZwdmN3WHpy?= =?iso-2022-jp?B?N0FkVGNRaWJMN0JEMXVvZFZxYzk4eDVjSWlGRnRsRVBPS0hoM2pURURw?= =?iso-2022-jp?B?WG1jQ3AxR1cxL1pFRGxrY1RCVVRRK2hvaUx1TGFhcVZNS0laSzlWOHll?= =?iso-2022-jp?B?b29HSnRzc2UvSHNaUVBSS3IyZUNyN0dXSmMwOGRxTjBOd0dPVHR5MjFX?= =?iso-2022-jp?B?aW1JWA==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5993.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a13cb2c6-4007-48a8-4bf2-08da96390096 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 10:07:59.2873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qSV1OlcsAXyxGYwZ590nIn5Pg0JSnsxokizf2t6Z5TRf9/Bt4224EQocI49b9Rd2ju3KHOP0X0QPxXZE5i8LfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6171 [AMD Official Use Only - General] Hi Paul, Thank you! But how could we merge this patch ? Ruili -----Original Message----- From: Paul Durrant Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B14=1B$BF|=1B(B 17:08 To: Ji, Ruili ; qemu-devel@nongnu.org Cc: Liu, Aaron ; xen-devel@lists.xenproject.org Subject: Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough de= vice Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 13/09/2022 04:02, Ji, Ruili wrote: > [AMD Official Use Only - General] > > > Hi Paul, > > Could you help to review this patch? > LGTM. You can add my R-b to it. Paul > Thanks > > *From:* Ji, Ruili > *Sent:* 2022=1B$BG/=1B(B9=1B$B7n=1B(B7=1B$BF|=1B(B 9:04 > *To:* 'Paul Durrant' ; 'qemu-devel@nongnu.org' > > *Cc:* Liu, Aaron ; 'xen-devel@lists.xenproject.org' > > *Subject:* RE: [PATCH] hw/xen: set pci Atomic Ops requests for > passthrough device > > FYI > > *From:* Ji, Ruili > *Sent:* 2022=1B$BG/=1B(B9=1B$B7n=1B(B6=1B$BF|=1B(B 15:40 > *To:* qemu-devel@nongnu.org > *Cc:* Liu, Aaron > > *Subject:* [PATCH] hw/xen: set pci Atomic Ops requests for passthrough > device > > From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Sep 17 00:00:00 > 2001 > > From: Ruili Ji ruili.ji@amd.com > > Date: Tue, 6 Sep 2022 14:09:41 +0800 > > Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough > device > > Make guest os access pci device control 2 reg for passthrough device > > as struct XenPTRegInfo described in the file hw/xen/xen_pt.h. > > /* reg read only field mask (ON:RO/ROS, OFF:other) */ > > uint32_t ro_mask; > > /* reg emulate field mask (ON:emu, OFF:passthrough) */ > > uint32_t emu_mask; > > Resolves: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgitl > ab.com%2Fqemu-project%2Fqemu%2F-%2Fissues%2F1196&data=3D05%7C01%7CRu > ili.Ji%40amd.com%7Ca5e2c22a81544feb6bb408da96309702%7C3dd8961fe4884e60 > 8e11a82d994e183d%7C0%7C0%7C637987432689748212%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7C%7C%7C&sdata=3DJg8588FWkIZzmSEyt50TYCbck2NuoVJdm7ZP0Z%2FtFGc%3 > D&reserved=3D0 > lab.com%2Fqemu-project%2Fqemu%2F-%2Fissues%2F1196&data=3D05%7C01%7CR > uili.Ji%40amd.com%7Ca5e2c22a81544feb6bb408da96309702%7C3dd8961fe4884e6 > 08e11a82d994e183d%7C0%7C0%7C637987432689748212%7CUnknown%7CTWFpbGZsb3d > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 3000%7C%7C%7C&sdata=3DJg8588FWkIZzmSEyt50TYCbck2NuoVJdm7ZP0Z%2FtFGc% > 3D&reserved=3D0> > > Signed-off-by: Aaron.Liu@amd.com > > Signed-off-by: ruili.ji@amd.com > > --- > > hw/xen/xen_pt_config_init.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c > > index c5c4e943a8..adc565a00a 100644 > > --- a/hw/xen/xen_pt_config_init.c > > +++ b/hw/xen/xen_pt_config_init.c > > @@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D { > > .offset =3D 0x28, > > .size =3D 2, > > .init_val =3D 0x0000, > > - .ro_mask =3D 0xFFE0, > > - .emu_mask =3D 0xFFFF, > > + .ro_mask =3D 0xFFA0, > > + .emu_mask =3D 0xFFBF, > > .init =3D xen_pt_devctrl2_reg_init, > > .u.w.read =3D xen_pt_word_reg_read, > > .u.w.write =3D xen_pt_word_reg_write, > > -- > > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 14 10:14:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 10:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406920.649331 (Exim 4.92) (envelope-from ) id 1oYPP2-0007cM-03; Wed, 14 Sep 2022 10:13:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406920.649331; Wed, 14 Sep 2022 10:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYPP1-0007cF-TJ; Wed, 14 Sep 2022 10:13:55 +0000 Received: by outflank-mailman (input) for mailman id 406920; Wed, 14 Sep 2022 10:13:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYPP1-0007c9-3Q for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 10:13:55 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70089.outbound.protection.outlook.com [40.107.7.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef7b8b67-3415-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 12:13:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9596.eurprd04.prod.outlook.com (2603:10a6:102:23e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Wed, 14 Sep 2022 10:13:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 10:13:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef7b8b67-3415-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cLFJJxH6iLNOhBfuiBf3GgjmJvt5qKD1cATBrNJ5YPaqmhbZXEPgT2QC980d5x51xMLUeelOEm8iW44Qk+48QgfcvQxACWNlL1fNBtr73jvSCD0UQqakwhq8U7l8BdRTNocrDZLcuuj05KPxmjlw97S5+uj9a212kKoX6WtatukZPJQE3C49PqqZSXeotmDbLyHw5gbRdD8XhKXlm3vFMMH49EPaRj1JCJUz/nXnpuwWc6/ACt3/5nlHF+hfycMub5dgS9H7gNRn3cSjdVTFlauVjpF8mujx6LUDMZAwvNAhH43GPdnPZWxqNy0RuWfsPXZYcuwItm7UC5XndWyVHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OHynH6+WXjduIMM1wGlno8nKFnn1GiKfGrZapeQUmzE=; b=NS9k5mzaMr1DHKpk2TSMfSTBbZE4x1IgmcuTMHMFunOhSIOZxRKGuXddXM2EaUhY4WixPRb0Pq87/75xoC+M/CpSS/zKHvzpvEc6yYu3s3k3Yb0oHofzeh1il91c5Ms2yisWOCuH5pxj7ROpF7SHw9SqShGxnlwvaeYCoYOsu0yyo9aQK+JC9cjPwXQWWzUQK8pkHVv9DZBSsGHHY+qW5l6jnZguNK4dhsYQV9pA00v25uoh07uGeBAO1UhQBkeCw95n6BNBW8UuZxSC5wzfy0Z7nMVu2DsMHDsArwoHQOWzCIDFlUVvrpdnrpkxo5JzyP7L9wDs5w6iYRIDEHCT2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OHynH6+WXjduIMM1wGlno8nKFnn1GiKfGrZapeQUmzE=; b=OrWcwHk9vEwzVoEXSV7nNZN62Y3ClatiI4GY9VIMuDsN+WE192fmlHwh7eJdSzqjLS2CiVPv/EFXt/1WjRyKuW4X1QX+iSgYfq4tD8YVUB8sTiyB3gsqyLByQOwh/wNaCHXrpdthL2HIhgRt1+1kKTitufLtp0W/mtbDKdL3uveVtukeyWtJUA/osDyfSygL13NqdsinwJZIA+9UjC5Dg73Ao7noVBY6EeiMaqX63SZPW6p6tEeyiRZ2vt5cDCDgU38uGcCV7aKJ+kLGYTDR1iGiFyivqmrXFjfbwaPq3RnfJS//NPy/YUkh6DIoksgIMYKO4aq6JD1CHbnP6IleQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 14 Sep 2022 12:13:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0090.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9596:EE_ X-MS-Office365-Filtering-Correlation-Id: 150b02fd-749f-4b44-8693-08da9639d263 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CecQonKBZwmvrLz9SHhikLLakGLAK4diq4O9j2LeFzjkvHtmU/sw7ug6nrQB5/Do5ywWvuoE4wT96ZXRVIShOJFYfbh8J0TuZihZHzFTS0t9IVNHmRRmccAfe4UqIPY+VzKBcDfBP3LfkmAT2sr9F931YG9KABJ71pF8W/hWZhdJaVPvEdTSIUnOswXPGR3gz5biyiBbgySvqsLB4u6cvlbaGaZlhSO35JlNv2dssG0U3oiemwnxkadnQYB7op95Cez1ZDo2fWvTAi+EM4ZMz/7Tv2miQzm4RkEHfLMOeYCWSgnWhZwNTXgFUAbQiOOPVkhBcLd0GZ8lvWNjKFfMlLzRtMufS0y5z3lkPz3oV/tQd5clxmd39qtDRpUeS7ZLTFhvf39lk8Ji8onr1zvvXFTP7B6SOVYO1931XEt9uDU9U+YMGNG+SwJ8/KTzsfb01bL0CtAfALGCrDUDeWakKT81pjenV/31YQx8KTYhmaWcpXUeTpkrdu2ZM7FucB9sOCG2RFVyTdCcGWqxJGRE/17mNKZavxfutkJhpmatOsow9brfVUIce+dfd6PkSlWp6JPnfNiMssiK2skI7TjpTBFxJLzv8nhLd9rE1rZkQtY3t1rsA4SVMJM7VNOWCVBeFA7lwcSyZgr1m0Xm67uDWUDmdp8DesJF1cb8oHO05zwj9+eZx//scyCTF43yL4VTw9u0xEu6Cg5hS+pAGP5uueX4+c+rTGVQjsxIA97xEkHUny85rHKB/fSL4xI8qfNQsk5bHtxtFGmQcm92fwtc4+g4N01sx757E8wLgi9CBh4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(36756003)(6506007)(6512007)(53546011)(186003)(2616005)(31696002)(38100700002)(86362001)(478600001)(6486002)(41300700001)(26005)(8936002)(5660300002)(8676002)(83380400001)(2906002)(66476007)(66946007)(6916009)(31686004)(54906003)(316002)(66556008)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTQxS0M1MmcwbDBnbDNXaHMzc2lHalJHNTR1QUdpb0NKcXc1SWFlNy9sMzJ6?= =?utf-8?B?TDhnZC9MM3B5NGQ0aDJVN0Jod2ZkcmZadXowbXB1NzYvL01IK1o0dURtQmIr?= =?utf-8?B?QmhwMjFVSWRwZnRqZmUwdENybzkvNE9OT0JITWVvYTk0L3pWSGJQUVlKL3RH?= =?utf-8?B?RHpkdTdhVE9PN1ROSmRUZmp6RWdnTVBQcjFabFFTWFhnc0xJMlVpcDMxU01S?= =?utf-8?B?K3hvUnJsTHlGZzNoTVJJNlBNRkE4bkhhYWpzYzRZM1dNVTZpT3FvdVBqRHJw?= =?utf-8?B?TmpPQ2dEOUpubVpKQ2t5MjUzaFNEQlRTU3h5YktGU1VLZVZrS2t3TGVDZDIx?= =?utf-8?B?cWJXdTRRT25pTU9mQmN5aE8xVTVWWG1KcFhzRHdEclZYenR4cHJlQkJzREc5?= =?utf-8?B?SjNlaGI4R054NjhwRlI4TSttZGNBT0Q3allNeU9PUUgzQUdJZWREL1gyYStW?= =?utf-8?B?Nmo4UG9abkRCdUVzUHVYMVFGRFJ6UEt6azFXT3pPNnhod2kxdFg5ZzYreXhz?= =?utf-8?B?dXhacDRsNThNRlJLZzgrWHcwRkRicWdhTStCbEV3SmF4SmFmbTlWaCtGc1Fo?= =?utf-8?B?akkwZG90V1FBUUhUYk9pMFhLcldualFkWnREZkczS2VtdFUrVndkUkpiZ2tK?= =?utf-8?B?RW4rVXloVWdWUGN6OU5tQnEyVFF3RUJ2YVBRbmRtajJ6a0NBZTFmaGVXY3pv?= =?utf-8?B?TWZMQTk2VS81OG9HWHJ4WGZacHNCdmR0ejc2eTNWTjNOQlU0K2Nza2ZtUTZv?= =?utf-8?B?VU4wYVlzTXYwZXFtUndJWU5jaDZ4SDd0VFZBWTJ6R3MrZzBINUpleVluYUw1?= =?utf-8?B?UFJXc0FHRFU2NzJTK0pVMWtNZnY1Y25ZUjNlSWJxMWdDdmlRZlZ3bDFaYlRS?= =?utf-8?B?M3d4YzhnZTdtRm5mZnVnUkozSGg2NlpUcjFmbTUvYzVLTTVqSjY2ZElnWmoz?= =?utf-8?B?MFdNdm1ZU1VMWW9kNjhxU2h1alFhTkxNYlJvSlhTajhkL2pMQUFodXJIaFRu?= =?utf-8?B?aVd4aVNYWkt3RUZBZURLcGlESXJSTTFNajUvbTJaUHkzdjB2QWliRDZPUktN?= =?utf-8?B?Vm9lYlNCNUVIN0QxamxranBteXh4REtpS3BqNUZmcEkxdUFCOWl5YldaSFVv?= =?utf-8?B?YnFSZ1FIU21OSVRVY0xzWkZ3SDFPWWowNHBnNmFvNHIrVk84amNydW5iKytv?= =?utf-8?B?MkpTV1NqMUlJR0VJTk9ZMjVwbGhWTW1TOHc5aENHSUplMHRuVkRSVmxsdEtX?= =?utf-8?B?RXdTWk9KSFRzeTZBVjMwUDBQaHF6YTV5M3lMbERncmZvUVhDcmQ5dmZ5eFRt?= =?utf-8?B?MVpTSzZIRWF2aXpIbE9Od3MySytFZmpaTFNPV2NJUkxGd1JxM0dueTJqN3d3?= =?utf-8?B?d2ZBbWRtOUNET3UxTjJsQldVRDBBL0JUcXowbDlJYnJnT3ZRaXY0QnNpd3VO?= =?utf-8?B?dU1ER3RCYzUrL1NkQWN3VXdSbGZJMDVXZG0yRW9pWXVvYWhXem5JOEZNdnRU?= =?utf-8?B?a2VLVWtQY21wQmprSlEzNkhONDdKSGVmY2lUZktQVUtPek9jK1RQSUZYLytO?= =?utf-8?B?TTJqQkVSdmEwWm5kVmRIWmdLand6L0tsU2dXMW1WdlN2V1N6WVByUlhVZnZ5?= =?utf-8?B?RXBTanA3dXhzRlRKUzg1SHMySzdrSTBZc1AwbW5zRU1vZkdmQjNvUnJLN25v?= =?utf-8?B?Rkc4eERUc1pvNzgzRDZsNjgvSmQzbWRrZlEyTGhUL3l0M0QxSEo3VklRNUhv?= =?utf-8?B?T0IvL3p5Tk1JZEh3NXZhWnMvVFJvV1VBcitYWG5iNjZvVUFHZ1BSU2J6MXYz?= =?utf-8?B?S296VzRPeUxVM0dCVHBvczNzcURZWEFwVEs3eDVKeFhudVFuZ1QvWWlFNFNa?= =?utf-8?B?QXYrd2pDWE1nUmR4enNrcW50SWVUUExveklib0pMN0NtaTMvczVhSDE3ZUVy?= =?utf-8?B?blZ3cWlyT2xpQlhpY3pyUWs3clhOR1hoY041aWl5UURNK09zT1Z1MVlJSXZH?= =?utf-8?B?QVVmcFhIVVExOGJJS1hJRXVsMzJTZDlRTVV4R3Y0alZVTFBYUlF5WjM0cXpa?= =?utf-8?B?TTZndmVILzEydzErWHRhcnJoYkcva0c1eklBRUFlUnRYbE82YU5zYlNNM2Vz?= =?utf-8?Q?HARcEuE6HUUeGxNMSfj+HtgcV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 150b02fd-749f-4b44-8693-08da9639d263 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 10:13:51.7761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2CO4FuHXlV+thfHw8aVK2sEVs0GKyIXrQoe4bvcytWMTr2EMgG8i0qAFPebXaUYB750I7a62gn42phqLMj/7fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9596 On 14.09.2022 11:13, Roger Pau Monné wrote: > On Wed, Sep 14, 2022 at 10:31:34AM +0200, Jan Beulich wrote: >> On 14.09.2022 10:14, Jan Beulich wrote: >>> On 13.09.2022 16:50, Roger Pau Monné wrote: >>>> On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: >>>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering >>>>> the consistency check in check_lock() for the p2m lock. To do so in >>>>> spurious_interrupt() requires adding reentrancy protection / handling >>>>> there. >>>> >>>> There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will >>>> trigger when trying to acquire the p2m lock from spurious_interrupt() >>>> context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> >>>> percpu_write_lock(). >>> >>> s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), > > do_IRQ() does call irq_enter(), and that's the caller of > spurious_interrupt() AFAICT. Hmm, you're right. I was mislead by smp_call_function_interrupt() explicitly using irq_{enter,exit}(). I guess that should have been removed in b57458c1d02b ("x86: All vectored interrupts go through do_IRQ()"). I guess I need to either open-code the variant of in_irq() I'd need, or (perhaps better for overall state) explicitly irq_exit() before the check and irq_enter() after the call. Thoughts? >>> but yes - we could nest inside a lower priority interrupt. I'll make >>> local_irq_enable() depend on !in_irq(). >> >> Upon further thought I guess more precautions are necessary: We might >> have interrupted code holding the P2M lock already, and we might also >> have interrupted code holding another MM lock precluding acquiring of >> the P2M lock. All of this probably plays into Andrew's concerns, yet >> still I don't view it as a viable route to omit the stack dump for HVM >> domains, and in particular for PVH Dom0. Sadly I can't think of any >> better approach ... > > Yes, I also had those concerns. The mm locks are recursive, but > spurious_interrupt() hitting in the middle of code already holding any > mm lock is likely to end up triggering the mm lock order checker. Guarding against this is possible, while ... > One (likely very risky option ATM) is to introduce a per pCPU flag > that when set will turn all mm locks into noops, and use it here in > order to avoid any locking issues. This could introduce two issues at > least: first one is how resilient page walking routines are against > page tables changing under their feet. The second one is that any > page table walker p2m helper should avoid doing modifications to the > p2m, so no P2M_ALLOC or P2M_UNSHARE flags could be used. ... personally I view this as too risky. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 14 11:09:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 11:09:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406928.649341 (Exim 4.92) (envelope-from ) id 1oYQG5-0004eH-2e; Wed, 14 Sep 2022 11:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406928.649341; Wed, 14 Sep 2022 11:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYQG5-0004eA-00; Wed, 14 Sep 2022 11:08:45 +0000 Received: by outflank-mailman (input) for mailman id 406928; Wed, 14 Sep 2022 11:08:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYQG3-0004e0-8k; Wed, 14 Sep 2022 11:08:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYQG3-0004Xz-5O; Wed, 14 Sep 2022 11:08:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYQG2-00012c-Hb; Wed, 14 Sep 2022 11:08:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYQG2-0001of-Gl; Wed, 14 Sep 2022 11:08:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xtdKkrn4UggUU8UZpPCw5LLT6JvAFTLM1ZZU8BaqDLM=; b=REofNSw/ZX+5+RexTA0JL+3w0G bk0dIHiNCrQb+XrYdL2GTkWq5FWo7TeQd83XA97YUg+onhOqMzPiwmAfQu5HYWd+hkS00rcBkQmcQ vffcnzKG7aAGLD3Jz+uHHKENhyIPBTCnekzeZ5N/A4glnAo046eWvS3MPsKDeOM7wx64=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173183: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d1221cea11fca0f6946bdd032a45b22cecfc0f99 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Wed, 14 Sep 2022 11:08:42 +0000 flight 173183 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173183/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux d1221cea11fca0f6946bdd032a45b22cecfc0f99 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 41 days Failing since 172152 2022-08-05 04:01:26 Z 40 days 91 attempts Testing same since 173176 2022-09-13 16:43:02 Z 0 days 2 attempts ------------------------------------------------------------ 1776 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182668 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 11:28:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 11:28:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406936.649353 (Exim 4.92) (envelope-from ) id 1oYQZD-0007AV-Mt; Wed, 14 Sep 2022 11:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406936.649353; Wed, 14 Sep 2022 11:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYQZD-0007AO-JY; Wed, 14 Sep 2022 11:28:31 +0000 Received: by outflank-mailman (input) for mailman id 406936; Wed, 14 Sep 2022 11:28:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYQZB-0007AI-Sf for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 11:28:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ab39afe-3420-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 13:28:28 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1073E1F974; Wed, 14 Sep 2022 11:28:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A3E4013494; Wed, 14 Sep 2022 11:28:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PM4YJtu6IWOdYQAAMHmgww (envelope-from ); Wed, 14 Sep 2022 11:28:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ab39afe-3420-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663154908; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dv1+xG4QI6T64Nul1wKUmD7/bcGnE8zzXxRkKAVJ1Ag=; b=jgBo28K2qqcgvZm8FLYtR2V9gjRt7kPlDJp6b0kNooou2GG3vR6hdx4jcg2SzAfGp2LsRO PG3q/VDLseyPYRV61mV5IS6E/RUgPkdMw+MttpYPqb5vJ4bJiW6Q1jlvENbOdTIg6I3Yra FePamKJXqOnTvEP/pM8FBnR6BcpwiME= Message-ID: <7a068199-ef6f-89bd-ded1-56766b9420fe@suse.com> Date: Wed, 14 Sep 2022 13:28:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Cc: xen-devel , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Henry Wang , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: From: Juergen Gross Subject: Re: Licensing issues In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------sqzP2CkNwCmo1odwW9oUTFfE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------sqzP2CkNwCmo1odwW9oUTFfE Content-Type: multipart/mixed; boundary="------------csgXTQsWg6QMfn1aNaymTN9o"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Cc: xen-devel , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Henry Wang , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: <7a068199-ef6f-89bd-ded1-56766b9420fe@suse.com> Subject: Re: Licensing issues References: In-Reply-To: --------------csgXTQsWg6QMfn1aNaymTN9o Content-Type: multipart/mixed; boundary="------------IQF90RKiTCGUnoN0QjlvN45l" --------------IQF90RKiTCGUnoN0QjlvN45l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDkuMjIgMTc6NTIsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIEZyaSwg SnVsIDIyLCAyMDIyIGF0IDAyOjMxOjI4UE0gKzAwMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6 DQo+PiBJJ3ZlIGJlZW4gY3Jvc3MtY2hlY2tpbmcgbGljZW5zaW5nIGRldGFpbHMsIGFuZCB3 ZSBoYXZlIHNvbWUgcHJvYmxlbXMuDQo+Pg0KPj4gMSkgV2UgaW5zdGFsbCB4ZW4vaW5jbHVk ZS9wdWJsaWMvQ09QWUlORyBpbnRvIC91c3IvaW5jbHVkZS94ZW4vQ09QWUlORywNCj4+IHdo aWNoIGlzIG5vdCBjb21tb24gcHJhY3RpY2UuwqAgVGhlIGluc3RhbGxlZCBmaWxlIGlzIG1v c3RseSB1c2VsZXNzDQo+PiBiZWNhdXNlIGl0IGRpc2N1c3NlcyBmaWxlcyBiYXNlZCBvbiB0 aGVpciB4ZW4uZ2l0IHBhdGhzLg0KPj4NCj4+IDIpIFdlIGFjdHVhbGx5IHVzZSB0aGUgTUlU IGhlYWRlciBmb3IgdGhlIHB1YmxpYyBpbnRlcmZhY2UsIGJ1dCB3ZSBkb24ndA0KPj4gYWN0 dWFsbHkgY2FsbCBpdCBieSBpdCdzIGNvbW1vbiBuYW1lIGFueXdoZXJlLg0KPj4NCj4+IDMp IFRoZSBmb2xsb3dpbmcgZmlsZXMgYXJlIG1pc3NpbmcgdGhlIE1JVCBoZWFkZXI6DQo+Pg0K Pj4gL3Vzci9pbmNsdWRlL3hlbi9mb3JlaWduL3g4Nl8zMi5oDQo+PiAvdXNyL2luY2x1ZGUv eGVuL2ZvcmVpZ24veDg2XzY0LmgNCj4+IC91c3IvaW5jbHVkZS94ZW4vZm9yZWlnbi9hcm0z Mi5oDQo+PiAvdXNyL2luY2x1ZGUveGVuL2ZvcmVpZ24vYXJtNjQuaA0KPj4gL3Vzci9pbmNs dWRlL3hlbi9zeXMvZ250YWxsb2MuaA0KPj4gL3Vzci9pbmNsdWRlL3hlbi9kZXZpY2VfdHJl ZV9kZWZzLmgNCj4+IC91c3IvaW5jbHVkZS94ZW4vZXJybm8uaA0KPj4NCj4+IEZvcmVpZ24g YXJlIGF1dG9nZW5lcmF0ZWQgZnJvbSBoZWFkZXJzIHdpdGggTUlUIGxpY2VuY2VzLCBzbyB0 aGF0J3MgYW4NCj4+IGVhc3kgZml4Lg0KPj4NCj4+IGVycm5vLmggd2FzIGFuIG92ZXJzaWdo dCB3aGVuIHdlIGFkZGVkIGl0LsKgIFRoZXJlJ3Mgbm8gcHJvYmxlbSBmaXhpbmcNCj4+IGl0 LCBhcyBpdCBpcyBjb3ZlcmVkIGJ5IG11bHRpcGxlIHN0YXRlbWVudHMgZWxzZXdoZXJlIGlu IHRoZSB0cmVlLg0KPj4NCj4+IGRldmljZV90cmVlX2RlZnMuaCBpcyBwcm9ibGVtYXRpYy7C oCBJdCBjYW1lIGludG8gZXhpc3RlbmNlIGluIGMvcw0KPj4gMWM4OThhOWZlYzdlNCB3aGVu IHNvbWUgTEdQTCBjb2RlIHdhcyBtb3ZlZCBvdXQgb2YgbGlieGwsIGFuZCBzb21lIEdQTA0K Pj4gY29kZSB3YXMgY29waWVkIG91dCBvZiBYZW4uwqAgU28gdGhlcmUncyBjdXJyZW50bHkg YW4gR1BMK0xHUEwgdnMgTUlUDQo+PiBsaWNlbnNpbmcgdmlvbGF0aW9uLg0KPj4NCj4+IEkg aGF2ZSBub3QgbG9va2VkIHRocm91Z2ggaGlzdG9yeSwgYnV0IGl0J3MgbGlrZWx5IHRoYXQg dGhlIGNvcHlyaWdodCBpcw0KPj4gY292ZXJlZCBieSBpbmRpdmlkdWFscy9jb21wYW5pZXMg d2hvIGFyZSBzdGlsbCBhY3RpdmUgbWVtYmVycyBvZiBYZW4sDQo+PiBhbmQgSSBkb24ndCBh bnRpY2lwYXRlIGFueSBwcm9ibGVtIGdldHRpbmcgaXQgZm9ybWFsbHkgcmVsaWNlbnNlZCAo aXQncw0KPj4ganVzdCBhIGZldyBjb25zdGFudHMpLCBidXQgdGhpcyBkb2VzIG5lZWQgZml4 aW5nLg0KPj4NCj4+IHN5cy9nbnRhbGxvYy5oIGlzIG1vcmUgY29tcGxpY2F0ZWQuwqAgSXQn cyBzdGF0ZWQgYXMgcHVibGljIGRvbWFpbiB3aGljaA0KPj4gaXMgZmluZSBmb3Igb3VyIHB1 cnBvc2VzLCBidXQgaW5jb25zaXN0ZW50IHdpdGggZXZlcnl0aGluZyBlbHNlLCBhbmQgd2UN Cj4+IG5lZWQgdG8gYWRqdXN0IHRoZSB2YXJpb3VzIGZpbGVzIHdlJ3ZlIGdvdCB3aGljaCBz dGF0ZSB0aGF0IHRoZSBmdWxsDQo+PiBwdWJsaWMgQVBJIGlzIE1JVC4NCj4+DQo+PiBCdXQg aXQgZG9lcyByYWlzZSBhIGRpZmZlcmVudCBidWcuwqAgV2h5IGRvIHdlIGhhdmUgcmFuZG9t IGxpbnV4IGhlYWRlcnMNCj4+IGNvbW1pdHRlZCBpbiB0aGUgdHJlZSwgdXNlZCBieSBzb21l IHVzZXJzcGFjZSBsaWJyYXJpZXM/DQo+IA0KPiBJIHdvdWxkIGd1ZXNzIHRoaXMgaXMgYmVj YXVzZSBpbiB0aGUgcGFzdCAocHJlIExpbnV4IHB2b3BzIGtlcm5lbHMpIHdlDQo+IHdhbnRl ZCBkaXN0cm9zIHRvIGJlIGFibGUgdG8gYnVpbGQgWGVuIHBhY2thZ2VzIG9uIGJveGVzIHRo YXQgZGlkIG5vdA0KPiBydW4gWGVuIHBhdGNoZWQga2VybmVscywgYW5kIGhlbmNlIGRpZG4n dCBoYXZlIHRoZSB1c2VyLXNwYWNlIGhlYWRlcnMsDQo+IHRoYXQncyB3aHkgd2UgaGFkIHRv IGFkZCB0aGVtIHRvIHhlbi5naXQuDQoNCkl0IGlzbid0IHNvIGVhc3kuDQoNClRob3NlIGFy ZSBoZWFkZXJzIG9mIFhlbi1zcGVjaWZpYyBrZXJuZWwgZHJpdmVycy4NCg0KRXNwZWNpYWxs eSBpbiBjYXNlIG5ldyBmZWF0dXJlcyBhcmUgYWRkZWQgdG8gdGhlIHVwc3RyZWFtIGtlcm5l bCBkcml2ZXJzLA0Kd2Ugd2FudCB0byBiZSBhYmxlIHRvIGJ1aWxkIHRoZSBYZW4gdG9vbHMg dXNpbmcgdGhlbSB3aXRob3V0IHJlcXVpcmluZyBhDQpibGVlZGluZyBlZGdlIGtlcm5lbCBp bnN0YWxsZWQuDQoNClRoaXMgd2hvbGUgc2NoZW1lIHJlcXVpcmVzIHRvIG5vdCByZW1vdmUg YW55IGZlYXR1cmVzIGZyb20gdGhlIGhlYWRlcnMsDQpvZiBjb3Vyc2UsIHNpbWlsYXIgdG8g dGhlIGhhbmRsaW5nIG9mIG91ciBwdWJsaWMgWGVuIGhlYWRlcnMuDQoNCg0KSnVlcmdlbg0K --------------IQF90RKiTCGUnoN0QjlvN45l Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------IQF90RKiTCGUnoN0QjlvN45l-- --------------csgXTQsWg6QMfn1aNaymTN9o-- --------------sqzP2CkNwCmo1odwW9oUTFfE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMhutsFAwAAAAAACgkQsN6d1ii/Ey+q 9Af/eeKK1xjrooSkmOmPNyWITqJ5FM66aBU1enYkG3o3T1dyiCkTEmm4+GRfQcV3SLn0FJMD2D9F Mf2beg+xcq07Zx+CMsJ/dhXpF4cGpfYUVS+sAO4RRox4FbTlFtY72zita51mfkMG+kzK6i3DxfX/ pz1pr6O39cAox5YvlkYMp8u3s7NMi4L2GJZAGKiT3FNP+An1XWCxHrkHCx8T0KMHY1y9JKzO1P/V EiiAx+QkHmy2wltjfyOBU4M9Q5ResH6+9YRlw1I2GfTfLAPcggZpoc62rVz7BhQZdy0s/yyZx/aO bqQHHR2MqcNOoAvWrQQL1IfEWnkKi0Y4z7bLrkOaLw== =3CTy -----END PGP SIGNATURE----- --------------sqzP2CkNwCmo1odwW9oUTFfE-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 13:16:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 13:16:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406954.649364 (Exim 4.92) (envelope-from ) id 1oYSFP-0001cF-Ql; Wed, 14 Sep 2022 13:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406954.649364; Wed, 14 Sep 2022 13:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSFP-0001c8-NF; Wed, 14 Sep 2022 13:16:11 +0000 Received: by outflank-mailman (input) for mailman id 406954; Wed, 14 Sep 2022 13:16:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSFO-0001by-Fl; Wed, 14 Sep 2022 13:16:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSFO-0006eP-AB; Wed, 14 Sep 2022 13:16:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSFN-0001bt-RM; Wed, 14 Sep 2022 13:16:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYSFN-0002Yp-QX; Wed, 14 Sep 2022 13:16:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=61dlDmvHYeMRYLh5/GcQetocIdQfpVrrJKeSYcd0xJA=; b=qVvR1DW7MLyrPVEtYwWv9paOZT hggbhPHcUGolcsH4x9Kvh/TAkiPuWXYp/pNlfMvUJd4/x1mqz0o8qiqlZSUTXRkB4nEM49HCSRDa4 RmT1y1lehSigc+0Cr7q+mOxklJSmuoUvewxHVhWEwy+4aB1/1rSViGGOx4aE6jV9xg+A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173184: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-pygrub:guest-localmigrate:fail:heisenbug xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c X-Osstest-Versions-That: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c From: osstest service owner Date: Wed, 14 Sep 2022 13:16:09 +0000 flight 173184 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173184/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-pygrub 17 guest-localmigrate fail in 173162 pass in 173184 test-amd64-i386-xl-xsm 7 xen-install fail pass in 173162 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173162 build-i386-libvirt 6 libvirt-build fail like 173162 build-arm64-libvirt 6 libvirt-build fail like 173162 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173162 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173162 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173162 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173162 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173162 build-armhf-libvirt 6 libvirt-build fail like 173162 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173162 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173162 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173162 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173162 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c baseline version: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c Last test of basis 173184 2022-09-14 01:53:31 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Sep 14 13:50:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 13:50:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406966.649382 (Exim 4.92) (envelope-from ) id 1oYSmU-0005sj-JB; Wed, 14 Sep 2022 13:50:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406966.649382; Wed, 14 Sep 2022 13:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSmU-0005sc-FP; Wed, 14 Sep 2022 13:50:22 +0000 Received: by outflank-mailman (input) for mailman id 406966; Wed, 14 Sep 2022 13:50:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSmS-0005sW-NB for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 13:50:20 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29fd4ca0-3434-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 15:50:18 +0200 (CEST) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Sep 2022 09:50:15 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CH2PR03MB5253.namprd03.prod.outlook.com (2603:10b6:610:97::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Wed, 14 Sep 2022 13:50:11 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 13:50:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29fd4ca0-3434-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663163418; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=J1AU8plJZrxCjpnPUEeGqFq0bbbD8AuhAa8IqzdwvGg=; b=CE2FAQ/DvLcgVGjjJtxjtlxD4t5JYlfoj5bS6svD/BPjupw0TjA8A8pD rp/VrP/595QBMqWW5BH4DffCKL+Hdegka7t4TblSfoevjNXfa784dovvT VKr3i22HYqtr5BNNoPRl3eGuM+vtpGtdGXZsdXS3OKoxuXIJeVOWW4n0n Q=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 80487216 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AY9gdLK63kmE5hv9GcqHWKQxR2vbMJQuBRyYv2?= =?us-ascii?q?ybIXl8q2Bzspq5RRtaLSdRirHyfPWYI/V1F0QLCw8HWTaBjtYjshk9S1H9T/?= =?us-ascii?q?Ufviw/3dkcJ/7P7WYn33J+4kjf/KU4vY9Vx8fISpLue8SrrfFHZfH2vTPGoC?= =?us-ascii?q?U1jA/mez0Juz+rhqTzWPEGYQmnd9wd+03LOYCCZFxVuFnHGU2I+xZXZBL8p8?= =?us-ascii?q?BBf2VQweabRtQCTrVtsnBZejVVOjnIZvwgrE9/h0SwlF6aGAMYdUW1xUFS/o?= =?us-ascii?q?b7d+ZTQgfIK4Yg2jx2fzaVh50ROe45RxXKjvyVkzD9myIjFQwoqdqVfyvH48?= =?us-ascii?q?M1KKYPO62sECRLbUHdBhxUZisoltg+AaRB8uEzP/kWKjYkd1XBkQPP1SxB6s?= =?us-ascii?q?98wGtAfKQMNLc4nvu8cmYrThM4NiRnLmgH6dVvqi/Ac6UtXCsFogoXD+YIG0?= =?us-ascii?q?FJ0Kx+sRprHiLWa2IwqvcOj1rNfCL8BlCaLEaRfCp1IJmqSmoCF3axrUEIhX?= =?us-ascii?q?KnZgRkWwMU8K7i0UrE+FMGeWbOJ1W7kzAPui3mRXzWiuUz8uP70riweP5pbQ?= =?us-ascii?q?BcKRBF0lHF8BCJCquUoAeBci62xBsuoFfoD5OAbUp4/lyq0LnRmtLdNy3r/i?= =?us-ascii?q?99ASe0CQET+gV7KAa3Hgp1y0IjDQBdvJiESY+PRG/hEHOFpidUGXwo6elksf?= =?us-ascii?q?nyRtNymmi5sDbFGfhYRTu38r/Vf4TxwAyCwqtZM4tIc46IG92n0saC5TgNwa?= =?us-ascii?q?WChiVyBeLrCzhvvCpykURkzj/1ZjthhXbyD3WUiVjo9NpJ6UbkDqBrqHE19q?= =?us-ascii?q?cbrXmpdljklhaqQBtmgpE6LBiZDvSTyfRwfTBae1aNQZ58j6cim4Qe9ucaCX?= =?us-ascii?q?RghIlBThA9ozAFmHQINGGQqYkcjdVrtU1pdfCmi+qhHKkFHsQuz6lxkSnnBN?= =?us-ascii?q?BclxHWl+n/G/xZEr+xWaMKTZJU2ttyt5shU3SZNDXPC8v8BVoYgIJss+kYcW?= =?us-ascii?q?fGqmiCSCfCNVfVJBWvMA985FvVe9pttscP71iPss5kEriYPl7+I38/EO5IWK?= =?us-ascii?q?6AH9N2K13CQytL83bOlUPAwr5lIik14v6arOx2xJGP8ochY2FvsVBsY6aVnG?= =?us-ascii?q?+k7i7dVbuWXKkrYiMD5vmn8KUW10X+ZHjX6WTpSauoIOPVqTns8vwBcevIaP?= =?us-ascii?q?l+HHUkTreWXtosnUW33h1KQayYuUcmvnfTw/1CqLi/3XJ+XKWM3CDhvmcXQK?= =?us-ascii?q?x8AV808PLKOn4nqJpQl7HJrp6ZE130Gu0OAEjHzVuw56P87zsBg14cmSIQAY?= =?us-ascii?q?r/ImtDLqqk+F1oIzCrf0PUBNZMiLlH818F5hJ2/KJ9X7bxUi6tnc+Zhudg0M?= =?us-ascii?q?cshVoH2s06RPzRuaFUwNtQltJb1DsGdL7IOLkBfnBksMjMpxl7jSqfxxFjrE?= =?us-ascii?q?XzFgU+8eSI4xBSQNjidaOoRi5njHmIvJ3hLi3ISWM1xEFR/VACl5OrN5UK9X?= =?us-ascii?q?S3RWt9ZDZYewG0muuHmbsdQVGBBdaBu6q0By1F4TeZnngJbQx9dNoFSUdRHn?= =?us-ascii?q?PgrJSNzbAGzS4llUZKiOFti/uKvjLrXO6gGIzd2qx3UIkg0h+9Qf7Pkce+oq?= =?us-ascii?q?W/M4FzSj0xa+5g3oMdOtgg4bFBTBl3g1Q6n2j6KdaUXJICsAsTWkSE1ZJREr?= =?us-ascii?q?TsHSUbL5R8E/1Ad7tfyYBQ3EjU13V1uRsonZXVIknPHsCulSKVlJuAs845iN?= =?us-ascii?q?WOdZVz4mJaMxJljuvnW9hbOKtg9EnOfDIFbRvehwzGaXfwQr/k1L+J35I4H8?= =?us-ascii?q?kfD8qoYkYFCyZ6Y6DAKSfm+JSnTZhrWBKrrwT0+T8rRKlkt7jFlzcmiJVPZF?= =?us-ascii?q?PM7ks4/Fmz21PAInp1Ky0QP6Uhrnw9RdJODpIT83JbxvzuWJ/bpa6XtF2OQ6?= =?us-ascii?q?eNFII1l4gcxOZr3aLh7PsyBRi6/JVzg2kXWvmd84wganIoIpRmdGTTL6nyOh?= =?us-ascii?q?FYdlqdz7NHsOXBJoOaeJCMrwPwaBbnrLMGSNmBYDd9BVmNfVPtT0wQBUyjWU?= =?us-ascii?q?wVbGfwizaqU7RynYCssEMKamIKxhH39ZubVV5hh2Oi3rev1kyUfN1Xx37rIA?= =?us-ascii?q?3juRTtuvizLE5/XJmIfilpl/vK9yZWoESP2LrxYXpEy8OiiufXcn0OEavqGH?= =?us-ascii?q?k4giLsfoolPzQ5HRSZpj3d5JGM0g2baO+c90J1OQESM6Eyg6pvF/hhrlBiRR?= =?us-ascii?q?HtkPgmgg8gwMzK+MdpbfUVm+RkcvsT/k3Lr78zqr6G4EVPhimjZdIuKPKEhf?= =?us-ascii?q?+LcYL/VsZgw1eu/6H7KNfrXzw1i3/uJMVmqBYPfALtd0wGQgezViVu1/WnOy?= =?us-ascii?q?zatjktG/1YFjbq1LsAFeTCOlchCawqRLL4VQ1rR4bT2NZ/2Cgrv3iTzY2pO5?= =?us-ascii?q?vEHUkrQd7/q4zzlbuhQB76i24Y4C2k7S81/BZfJjR/xtclFD3b+m39qo/az2?= =?us-ascii?q?3Lp69Z89q555eBjA0F3Iv1g1gRGKg1ibkEF5yKNq3GiR7u7hNAL42yoawA+S?= =?us-ascii?q?Yp1E4DCn0PowpVEOoKoMjoRNeJX2LWag6Env8Bj6jL5qH3x/mvJX3w1ZOLdF?= =?us-ascii?q?F9FEGmtiB9IhAeWd1qonZthAdxj+iyXg3miYiauPa4BIBmoG6SZrrlmn9g/q?= =?us-ascii?q?/I/wVy05py4oFJ/Sgi75OuMUoLvwhQaya7OW3pLKLPPs6uFtjM3jJRr7P3sK?= =?us-ascii?q?3JPdNQ3YgkhICFcfjO6CF8LpaCsZHyesmx+Bo1t1+J9E7eHtHXsdZxRGI/K3?= =?us-ascii?q?Pb+Lhb8n43CSFPNDt1Wo3zuHllKBgIfVmw7k5AOmEoLzsCL?= X-IronPort-AV: E=Sophos;i="5.93,315,1654574400"; d="scan'208";a="80487216" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oaMoScj4Njdu7GMI3NAyczhrHnh9f5XS/gLgmqYCEJ9ktNTwWbKwFLAC6nbZS5FEO2fC4U6KKSM6HjgX4RITobBz770kAqCh/sQeDjnvFvl7SrOGe3B1GKyu7yQeVjWJmrfwESHOu6+rmH24kzvPKhgbl7lTOZRpYuN3iRhrIVhhBW8zdP1cKDV41qsY0tKaaqAA+pIAA+4sl6I8T+l5Q4ueYEDipGCeL95w722LySfxkIVarneJ2BO8E7KT4WtpUMWsWvd1XJHZfm9VS8SnLEBG3z62+7AjgZwlHqd30DAAK0qKIB8xyBjMXjD2CzQiVMVrYblbo0n2PVFsTX7b8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o2sOe/63kgG1OhSccS7QuJkq0DnuUDrkO+xJxjoRv/M=; b=Php4jEr2y3p9Wg9X47S9v1QW4DI9xfvn9fX7x9Mp2jHx9CHPahg9hybc/SqaVoBDvQqKJhxtVa9bmJf4/3HLSqBH/bk8g6iNa5Qf7VZIzkDa6CptavBTvn5N0iRA8QyiHaZnUMBAc4KkUCy/BQUxgq2u1iSnIwfoTchCoj8hAXQXDgTOJZh2UpXrXSjp60aCMrHTVZaTnvR+YuiL99iaL0XAIvfnksgfOG2HIjs3+rTuNaGUXIF4bfFuPRvEXHX9Pvw/1QjhWS/+E5zW3ktf7HkQI6AbwUx5TemQJmPD449COsDpolV40J26gG/+M0DHGA+SLlE6ey9WRfpKpLUUKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o2sOe/63kgG1OhSccS7QuJkq0DnuUDrkO+xJxjoRv/M=; b=F8dk+HsU9Ht3ZbueHfSSUYstVjllcjLiCxxmn03w1C7S5ue0rXeHrlPmfH3Bn0JyMeAOKMLhhaTZ3VembTgi3MkQCmqC/r89Nbl9sbDvqyhcqFo8bjc4w2udTpEd+u6cOcmo+1mDkhXteF/YQg9oKHAaY9LHU+o8O1GK4FvzNtw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 14 Sep 2022 15:50:06 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Juergen Gross Cc: Andrew Cooper , xen-devel , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Henry Wang , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: Licensing issues Message-ID: References: <7a068199-ef6f-89bd-ded1-56766b9420fe@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a068199-ef6f-89bd-ded1-56766b9420fe@suse.com> X-ClientProxiedBy: MR1P264CA0020.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|CH2PR03MB5253:EE_ X-MS-Office365-Filtering-Correlation-Id: 21f0114b-8805-4be6-e832-08da96580aa6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3D09o2Fcql/AYn5YQ3QOJYju3wvE7KoVgL7tXvsz2KNYyv1+Qv8K2iNI1ySWERGv0wlTh90L3QY63Zyb4Al3hiHnSyJR8IMXYoJf/8lzil8Kc6daroVCh4sznpSw8cUiSdn/Hbqw5bCGDhrDZcxdyZfItGBBIbVCsO0nF5FXCwaQYC8nClAPT8A7kWByYSxyyqbgXiiiF3MHXPCtWWYTQJXWrNSdOPp8hldw3MeaJ74KEpxNm2GMWNkOGL6Lahh9GjIy4pFae1hs9mA7ryKjKdsWu9IG21aSJdZQNCpOxXC1jXTYODsLhgb2sXs+gDzI0lVTHW+M6NPHVXCLkbA7owbinrd+8/mvFZfmX+CMQol5zk7cPSp97LurgCi3vGpJXCPXF71xnZyeclCRLk7bviv2+bMjvrTJ1x2S2+DQaiwIXc1Bfia3m4HGXJM6mTljQoANBO5fdEmoA//zu2b+Jr0lml8Ts1poM+T8TaPLB/KSjtCaqbEEUVh2QsDg8K27VNXChEhcfj4PGjLN0lTWRJAi9vzo/xfaw6aLmRhh4TyeqzH+rqMfX+/5PSzLVqTGwbZEgRGtovwjKn0JIh+S79V13eITAoPAQ/hPc9Px8YGIpvZlsFdS3ynhXsPW6FU/pOUXTvinJvluOSDje7Zt7yfaX9WMMsAsWKDOUu5bFmm5BQ+LCkZxbVAwq60jmfOvhQlj20jSQeAMLAm95ldZSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199015)(6512007)(38100700002)(82960400001)(66556008)(85182001)(3480700007)(8936002)(6506007)(6486002)(9686003)(66946007)(41300700001)(316002)(26005)(6916009)(6666004)(7116003)(478600001)(8676002)(2906002)(66476007)(86362001)(4326008)(53546011)(5660300002)(54906003)(186003)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1ZOd3ZwKy9GU1JkNURjZXRDajdUOGtJQS8wTmgxbDRxMGZNRFlXZExIUHY4?= =?utf-8?B?K255MU5XTWJPS0ducXdSOHBvVkMyUHVqQkZEYVR1UzBQenpPTEgyVUprZkVq?= =?utf-8?B?cG9jQ2Uya1BCU0NwZFBObHBWQUtRTGRkQXdCVi9jOHVYUk42T2NDYkFpWEZJ?= =?utf-8?B?RE4rNFN0eENFeitnQ2xrZlJxNzlGcFFtYU1RU01ma2wyNFV4Z2k3WlNDNnlq?= =?utf-8?B?bkdUTWVJV2U1MCtjN3lBcHRuNGxJZitFVFhNbnJFVXBySTF2TE9hQ0lvV0tO?= =?utf-8?B?QU9xZ084QTZwK2o2NDliRkZzakExSmlndEpvdE9OTm5SQ1R4TXgxTHRBSUdN?= =?utf-8?B?RWxROG9lcVpkU3ptVnMrOEZKTUdyOEhtdjNKUEsrOUpmYUhqd3JvN1FueE1M?= =?utf-8?B?Ymo2L1FmSWJ2d2lSVFJrYTNTNFNJQXlFbHNjS3g1Um9takFyb3RqV0dpUk9l?= =?utf-8?B?dGhsV2Q2S0tVVzVhQnRXZlFWWVFqMm5ySFFqMzhoTzZCMFBvb0haY1dLZHZQ?= =?utf-8?B?QmtZV1d1MXl5cTgwVGk1UzBMTm4wakZLQk1VY2ZpZjhUeEZ6WHdBWnN1MVZ5?= =?utf-8?B?WXVFN3dNaitoVVBxV0w0SDFnc1hzTEE1ZGw5WWpLMTN4bTd6MEkyYmNWd215?= =?utf-8?B?eEhrcWtlTlRJeW5pYzhqWWVNUFBsNUpUZ1pXbHRWbFZ1UE5JMHo5WDUvem5H?= =?utf-8?B?TUlCOW5rd0tubkZRL3hMa1JCN1NNVkJwOStLdHZrbWtsYVVXQmVIMnllWnZt?= =?utf-8?B?N2pObGEwVHZOVFJNS1NKOHVEYzd4ZFBack10UXpkbitxelV5YWpacStKemlq?= =?utf-8?B?VDROTGpyVE1COFlraGpGYm5XQ2tXb3BIZWxDYnlMb2tNVDFjb1JiQmlVclZN?= =?utf-8?B?cmRDdmJFMVQ0OVZRR2szQ2VEcVBLMkxGSjZxSS9mN3hkc0lROGpRaW8yNVVJ?= =?utf-8?B?RG12cUFnWXF1ZG1CYTVlQ3VJMkhmam9IbHpvY1d1ZUoxaWozdDhoMXkxL2VP?= =?utf-8?B?N0pJZmtPTzRhcVNhdlFwem9NNXF5WEt2cFhQMEtCWGJZVTVkYlNDN3lkYk80?= =?utf-8?B?bGhZbERoNW9ONzlvQmcrUXpUYU5JL2RVcXpDbHc2NDNXWTJHOEZnMElqWTNk?= =?utf-8?B?QW8xMnVWTTZiV3JrUUFRVUtGZ1BnM0FZQlltRVJ6aG1YUldHeUFzRkh0Yy90?= =?utf-8?B?QXdoVHRuRGhsSm1rL1RraWJ1MmxLOHd4SERzcE1qNCticURmYjZZVk4xYzVz?= =?utf-8?B?Rmlxb3IzejJkQWR1anBURCtXZVJxQ2VuUE9GTnFzODY2cmxyNFZ6aU1wRCt3?= =?utf-8?B?cGM3eVJyRUZDM0VhMldiRjd6TXQ0QzB6SmRPUUJXVEtKRm0vWktyS3pLeDdU?= =?utf-8?B?WStNdjBZRkpnTFlhUmpkOVBxUEFsekdvM0U0TzRGbTBSQW9iYXR3elQ3ZUtt?= =?utf-8?B?bGtVQk1OWDZtdnZMNFBFVmFpcVBLS2ZZcmVXTGZINmVyOHlEdXhRSSthaUpV?= =?utf-8?B?cTdHQ1hDeXVRR3oySFI4SXJXN2lmN2hQa2ZlZUlHVUNyUjVrN1NscEdjelNE?= =?utf-8?B?RDJQcXZlc0k3T0d2NVNoS1l3Qm95NnQ5U3ZEankyYnRrWkRPUTZTbFE0Zm9x?= =?utf-8?B?N21wVkdBS3Y1Z0dTVmlTSzl4cWZjZExLelowQ0tjamczcDM0eC9Sekx4dmVU?= =?utf-8?B?YXZwOHhlZkFPc3lISURVdmR4TUVneFJBZlRIUXE1bkk5UVJaY2NRS0daaWRZ?= =?utf-8?B?d0ozKzFFZmtvc0tPdlZiSU84QUJOZGhIUGhDWDB2d3Z1RGQ4bEl2T3UyTXZy?= =?utf-8?B?SWt1Wks4Y2prc2JGazRBSWs3YUtadVVvTlFCQWpSUXZGUlNPM0RZV2JIelh2?= =?utf-8?B?Nm9Kdkl2V1NGZWNPYXkzaStjaWU1RWFkYzUwRlJCTlZOb2tIQjVkS0dxdjlX?= =?utf-8?B?ZTNpSldJRFZLUC81a1R2VE9kVE5ycVNjSUNXbEhEaytqa1d5OUx1clJPdGpk?= =?utf-8?B?amRFR2VWYjJ6U25va2RvTGdVaU5mUmt1aWNwWDZvekZFY2F5RFdNUHNsdVR1?= =?utf-8?B?b3dhTER5MEEyZUJISi9tOW5QTWdCQnFmWjdNV3dEZUtScnlucVBab09ITExV?= =?utf-8?B?YXliMndHbGl4NGRnd20vcWRWcXBQVHhJTVJmZ0NaVjJhcC9YS3l3WlJpM3Zj?= =?utf-8?B?bXc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21f0114b-8805-4be6-e832-08da96580aa6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 13:50:11.0094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ESjH48mpBuZWtgNkNw52ZQRRQCzR+6Wg1GGnalXNZQ/3VTvAJWjO1WGYHNcwmp47qKSgO0q/mmkfj9gxCuIcAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5253 On Wed, Sep 14, 2022 at 01:28:27PM +0200, Juergen Gross wrote: > On 13.09.22 17:52, Roger Pau Monné wrote: > > On Fri, Jul 22, 2022 at 02:31:28PM +0000, Andrew Cooper wrote: > > > I've been cross-checking licensing details, and we have some problems. > > > > > > 1) We install xen/include/public/COPYING into /usr/include/xen/COPYING, > > > which is not common practice.  The installed file is mostly useless > > > because it discusses files based on their xen.git paths. > > > > > > 2) We actually use the MIT header for the public interface, but we don't > > > actually call it by it's common name anywhere. > > > > > > 3) The following files are missing the MIT header: > > > > > > /usr/include/xen/foreign/x86_32.h > > > /usr/include/xen/foreign/x86_64.h > > > /usr/include/xen/foreign/arm32.h > > > /usr/include/xen/foreign/arm64.h > > > /usr/include/xen/sys/gntalloc.h > > > /usr/include/xen/device_tree_defs.h > > > /usr/include/xen/errno.h > > > > > > Foreign are autogenerated from headers with MIT licences, so that's an > > > easy fix. > > > > > > errno.h was an oversight when we added it.  There's no problem fixing > > > it, as it is covered by multiple statements elsewhere in the tree. > > > > > > device_tree_defs.h is problematic.  It came into existence in c/s > > > 1c898a9fec7e4 when some LGPL code was moved out of libxl, and some GPL > > > code was copied out of Xen.  So there's currently an GPL+LGPL vs MIT > > > licensing violation. > > > > > > I have not looked through history, but it's likely that the copyright is > > > covered by individuals/companies who are still active members of Xen, > > > and I don't anticipate any problem getting it formally relicensed (it's > > > just a few constants), but this does need fixing. > > > > > > sys/gntalloc.h is more complicated.  It's stated as public domain which > > > is fine for our purposes, but inconsistent with everything else, and we > > > need to adjust the various files we've got which state that the full > > > public API is MIT. > > > > > > But it does raise a different bug.  Why do we have random linux headers > > > committed in the tree, used by some userspace libraries? > > > > I would guess this is because in the past (pre Linux pvops kernels) we > > wanted distros to be able to build Xen packages on boxes that did not > > run Xen patched kernels, and hence didn't have the user-space headers, > > that's why we had to add them to xen.git. > > It isn't so easy. > > Those are headers of Xen-specific kernel drivers. > > Especially in case new features are added to the upstream kernel drivers, > we want to be able to build the Xen tools using them without requiring a > bleeding edge kernel installed. We could #ifdef code based on what's defined in the headers. But that would have the side effect of limiting the builtin features to the support present in the kernel used for the build process, which can be an issue for Linux distros I guess. For FreeBSD that wouldn't be so bad because the kernel is packaged together with userspace. Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 14 13:52:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 13:52:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406974.649393 (Exim 4.92) (envelope-from ) id 1oYSou-0006Xk-3T; Wed, 14 Sep 2022 13:52:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406974.649393; Wed, 14 Sep 2022 13:52:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSou-0006Xd-0l; Wed, 14 Sep 2022 13:52:52 +0000 Received: by outflank-mailman (input) for mailman id 406974; Wed, 14 Sep 2022 13:52:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSos-0006XT-Np; Wed, 14 Sep 2022 13:52:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSos-0007EB-KN; Wed, 14 Sep 2022 13:52:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYSos-0004Mz-8x; Wed, 14 Sep 2022 13:52:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYSos-0005Nm-8S; Wed, 14 Sep 2022 13:52:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ri1zJcNUBIblLr3dIBJa2cZO3uz5D2jertWjFn5bGXE=; b=sAYm4Oc0/geo2tm13BlkGqdB71 Kmg7klwGJiJIN2EhTs0mAFrbhnrb5gvp21H2pGwasVLdjo9qC0nYQPGwFRuvWDs1O8i96IyOrvf/T EeOvLOfvzCmp/e1WTANq8fYb4QFzriflbbxuzfnfs0xaarvDhGyAwTlCD/QLpi0nIEJs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173187: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ac3abe0a3fb4702eaa9276a7544eb4fe81a6d8ba X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 14 Sep 2022 13:52:50 +0000 flight 173187 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173187/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt ac3abe0a3fb4702eaa9276a7544eb4fe81a6d8ba baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 796 days Failing since 151818 2020-07-11 04:18:52 Z 795 days 777 attempts Testing same since 173187 2022-09-14 04:19:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122969 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 14:23:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 14:23:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406984.649404 (Exim 4.92) (envelope-from ) id 1oYTIa-0001aI-G3; Wed, 14 Sep 2022 14:23:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406984.649404; Wed, 14 Sep 2022 14:23:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTIa-0001aB-DK; Wed, 14 Sep 2022 14:23:32 +0000 Received: by outflank-mailman (input) for mailman id 406984; Wed, 14 Sep 2022 14:23:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTIY-0001a5-EK for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 14:23:30 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb7a7bc5-3438-11ed-9761-273f2230c3a0; Wed, 14 Sep 2022 16:23:27 +0200 (CEST) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Sep 2022 10:23:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5551.namprd03.prod.outlook.com (2603:10b6:a03:279::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 14:23:11 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 14:23:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb7a7bc5-3438-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663165407; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=kMXXEszx/UDNx/Hlz+5OqZSi67cY+K2qH6GlXC0h+/M=; b=QULS4Lh2bLhyZwOm8oSzvxqoH5cNFk2BIm4lkVvgOIbq+TQJVbF4/7lO BRqSm3FZOYRNJrqk1GLO7RdhkdnhfAlFu48UjgGSZulZy4MjdZ4OwWjJs GkHyZv8Rqu1AI2A7vrKTXZ2lXU9yU6XBXOJKPFGM7HbqheNJNQ5yW4wOQ w=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 83015918 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ebv/oqBCfWyc6hVW/zTiw5YqxClBgxIJ4kV8jS/XYbTApD4h3zVWy mdLDGHUPPeLZzSmKdElYI239k8CvJHUn99nQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFsv7b8XuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW1HWyt5hHkM0AddbpMd1WEpK3 /YfcwlYO3hvh8ruqF66Ys9Fo516aeLMZcYYsHwmyizFB/E7R5yFW7/N+dJTwDY3gIZJAOraY M0aLzFoaXwsYTUWYgtRVM14wbnu3yajG9FbgAv9Sa4f+W/cwRY3yLHwGNHUZsaLVYNemUPwS mfurz+hW0xLbYz3JTyt+yqFu8bCr3nBaKVCO6eHytFJgFmeyTlGYPERfR7hyRWjsWa8Ud9CL 00f+gI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ5sOcmSDps0 UWG9+4FHhRqubyRDHmar7GdqGrrPTBPdDBeIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCTFGbZOi2/srqZ0z5E IronPort-HdrOrdr: A9a23:m4LK8a+j7117dqythCRuk+FDdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.93,315,1654574400"; d="scan'208";a="83015918" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TKx9CnxpClgtjpHt9UrB3XO4glg8PxLBPbFCGnYnNIqYrwv2vVG2k4HEcCROXcHx475u44CZSt8WK4fan4c5AMZK7CZGvVHvy6mTgoriYlMJVRo+PH4jdUWwOZBNZtBQpx6kADeR9b6qOnLJfg/YbFpoLzR1cLQIh8sgxVueVh7/+1zxc8a42a+NS7NwXpoz2dvK7yONeGwu2vfnoaxNQNs7Cw5sBFYE3Zq9Dc9NPl8YjwSKKck2Sgq0ET4WHIbbMFpJQlZLGdcF4ckJdgeuB8ZwzOIDCzgtmlcfG4SNBMNgU7k1pNaMSA1J6fdgUL6+MN6WVMKOwmwJ6Psg0Hwt3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CPNaKtubl7sRms6IbW97Z3xRV9+cgT+QxDinvrzBxR0=; b=ao1BtZddxymzBCoLw9/d8wWvQsYVitYUL8epyHM+B0LxLWI9G3q8voSgOp9zZoLmUh9gb1q1nAf/cFmG7L4QXPM/w6YgM/tBHb7jK7ADhHggzOQSKv0nMmTRrDolRFMTv3c6yxgNxVPLRKkcPZMv5p/X5QaLwBQg3n3xemSC97ZcnViPNPaGnccONlJRsYNyZJTbNge7Ppd6/lJJ2Vt+3aV2Oiy9b3Sn2Nc64wZhqrSxUN/YETPMEDvaYy3o7S0B6hzDnHEGOWRWXqGRMKmkwfCAIwQRRkv0QahMqNJK7q1ViSSxIabp1vMzfQSlxIploBQw/EwBsBcBmPVpbcv04A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CPNaKtubl7sRms6IbW97Z3xRV9+cgT+QxDinvrzBxR0=; b=ZLMzDe3CJiBcPiBoKGhhJJDbyxGlk418ZLnvk9xm0FrjkVrQ1QGGoIWaZm8YneIaLapgeso16pEEH86OhVG+/YpNrY1xfOBT17pMXjGyuyyzGdQi4kP3kIxjnFW9WyKVkuh7/EyEuLuHyyREphYvWKB8tksYNWQEIDZGK9tnzgU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 14 Sep 2022 16:23:07 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Message-ID: References: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0049.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|SJ0PR03MB5551:EE_ X-MS-Office365-Filtering-Correlation-Id: c3cf25a0-57d6-4507-c1ce-08da965ca71b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TeZHdwf/ec1S5xmmyx+QIVvqyur1HZXrq7vBI9e2evpZfHaxvZ4nEu9vOITq3MeJHNvq56/CzLW3ZRWVU4vm9WWWSPhwF54laU0CjGpzdEpD3VQ4lcQDgktBxiGTH8fyHK4NbtrTVEQvAu7ZIv3Oe6DA784Hcv41zLDZhkQWBIYPv/sCD6IByKR466e47mO5sAmB7eKL/lkIB9LMpZEvZU0QdNr/8150lLoSc/UE1wfXeGwSESbsRFDUEh9SmPiJA6V70hf8s9R862UVzyoxZJKb6POCE7ib6njSv5+QDpntCD1LtApJ4rBVMFGFkOJDt+WL+pysfsD0ZeO/vDocewZbR4M8g9yNuJxMQhnxehTfNieFI5j560qCLrF6Z53TXRXdQw/zx4Dpa3G6BWFZe/LbKl5oyzZ9bF9h3DySrnvNPuSHQ3p42qaKSiLfs2yDorDy0dcO9hPZ0F9KsMJJ80XZg/+CzYutEtXT1d6zDkin3PT441LeWUji1n0829p7CEV47LoN+IPXUHfU1Qr8UbKSb5ypTzUzk3iEMGPJ4GUC9Yh6XQ9gMEhFoyFg47QzDkEJDic+f+Vkj02oq+zKQiWpEgifSFpAJtpzVUoM50sSHwgW6hwJsKko/iCoJcHJOa7P6UNyTeqvSt4H6QyL/lif/n0BUPFSxbn9OcDWMDtKENKHLhIZtjM9jf520BJIW5YfayV6/WBe7fup7bGFnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(451199015)(66946007)(82960400001)(6506007)(53546011)(54906003)(66476007)(6916009)(86362001)(85182001)(4326008)(6666004)(5660300002)(66556008)(41300700001)(2906002)(26005)(6512007)(38100700002)(478600001)(316002)(8936002)(9686003)(83380400001)(6486002)(8676002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0NicUJwcFR6LzRzeHlWck5CUlBLSGE4TDhGR2NvYTFNZkpJUzlvTzYzdUhh?= =?utf-8?B?R0NxTHA1eHRINm0vTzR6NVRaRDFWdXZZUXh5ZmN6K1FTdEx0YTlJU25BWTFV?= =?utf-8?B?THBhUUdKOHF0Ym0xYUxCQStzaUVtYnVNWWRveWtiT2RwN0dOQUpTVTVYbm9O?= =?utf-8?B?enBEdDVMWVIvbUdjM3h5YU1vVmJvaytZSXd4bFBOc2tObGhDVk9BcDN0MnVa?= =?utf-8?B?cHBaR3YxSWRNWGpONm40aHBQNU9hSGxEZm1waDdFNmNNZUIrMGlVbmVJZjg5?= =?utf-8?B?ZnZaZTdiMGRnR2JTbXFZSW44cElLWnp1R3hQYy9DZ2pwYzVXUFIzN2R3RUJQ?= =?utf-8?B?WWwxcktubURXTVhLcDVoZGJsTWcwTlFUQVlpYUl4U3hGd1phMm8wTTF5bERE?= =?utf-8?B?bUt6djF2MHh3MG1DbWlqc0tHK1c5VnF5YVZMWjJXdnNKZWd0RVdjNTUwTUNJ?= =?utf-8?B?ZjRhV1VUNTk2S1JnSWlhU0Z5OStORHY4c1h5bEp2NnlVOWVjaFlQZFRaeXhE?= =?utf-8?B?bFo5c1hDS0o0ZUhCY08wamlnSFFyK2RlNTl5RE5CNlY5am1HcG1iTFMyWmV6?= =?utf-8?B?bHVGeDgrQXZ5N3RlL09mbEhqMkxQMHgyM3pvbUgxT3FhSXRML3NwdVBWSFZp?= =?utf-8?B?UVhwNWZZaDB6TUROV1NHNzE5WnRuMkJhU3NpZHI5eS9wL3F0VFYwUjlic09i?= =?utf-8?B?Tm9tZDRSOVdNZHhMaXFzWEx3RWtleTg4eW0wQzAwOWhpVW1pRFZnYWJwYnpm?= =?utf-8?B?Q1Q5UXhpTDFtQmVybStieCtZRzNNU2NHUCtOVnZMZXlOSXFQcngwdXEveUNT?= =?utf-8?B?azFtWDZGMDdwVld0MUgwWlFOQjhBQVRjc01kZ1UvYVJXL09uSnp1YStudmRV?= =?utf-8?B?clpWemJSbnVNSEhySDBRVWsxQUM3NmdJbytWcEQ3RmxPcG9zd2tZa0F0c2Rk?= =?utf-8?B?TDVmNE5MdmdydXhqYzNNMk8waEwvTllyUHpad3RCV3lLNmNDZXprenZaZ3gy?= =?utf-8?B?bkp4WjhTbTVaMUFqWXZVczVxbFF3VGIrZkhPU3Z5UElsUnZWdDNHWTFiV3NG?= =?utf-8?B?bC8xWXI0ckRMNDU5WFY5NmpsNVIvUndQNjJXRkRYelVrNnBsN2gzQUM0YnRJ?= =?utf-8?B?R2l3NW91Ui9KeXpPbXhJM2h3L2NPSmF3Z3VQTm9ab3VtNkx4NXUzTm9rMjhj?= =?utf-8?B?ZjdYRVRocHJrZmplcVI2dWhkTUYxZTdzVW5qNEtSalByUlNlcE9ZK2p4VXln?= =?utf-8?B?ZEFxYlgvUGZnZE1weHNrSHgwc25VSDNhSlhSTjlvUU1pSlFrc0grNWJqK2NP?= =?utf-8?B?N1dja0hnbG16TndMbTVhTERqbEUvZ08vMnRZRE9vOGZnV1kvZU53bWNpdzVZ?= =?utf-8?B?bzhmdDZXZU5YMDNvVXJzQ2lSazA0WHMrYXY0RFZ1aU1McHZrbS9KaTlnNTlo?= =?utf-8?B?bmpXcEtsVVdTR0M2R1lvMlRsdzQ5ZGpuSExZdnB2UGFHdUhUVW5uSHQ5NzFm?= =?utf-8?B?aHNUOExTbnhWL241QUlTbHUrNjRBeTVLeVR3cUNBcVNQNitYcGFCOXZzdUN3?= =?utf-8?B?N3dlSWExellSMEtCVTlTcjNsNWVham4ydHFhZmphRXFIT3Fkait3SnNSdEJr?= =?utf-8?B?WlZZQlhJRXYrRTRmdDhld3dFcnd2VkpsOU5UeFNpU2VpQ2o3bWpvZGIwVDE1?= =?utf-8?B?eUM4NW1MUmdNQjMvUEtLUVVDQ3d3WTFQTEh0b2xONExmZWNrM21pcWY2ZjZK?= =?utf-8?B?bXhMK0hJNzdwZnhoM3hHcVZpdnRWMm9VTkFqNjEzdjB3TnNYcHFLQVV6ZkNh?= =?utf-8?B?L0lBK2RESzloZHVyeU5SOWJXN3NNcjVjMWUzWVA2QSsxYlBudzd5TzZhUzk5?= =?utf-8?B?SEhMTldQYlJPU21yN0QzdGZHQlNtZTZvSXJQWG1lOWRVcWN5VlIzdjFvdVVz?= =?utf-8?B?VFJFK1d6WkJKTW9qTi9yL3VmU2kyMi9LS3pJSXI5L05wOWpJRGh2ZWxiTzdj?= =?utf-8?B?V0RVeENrbTNmUENjVXp6dlNVZWJ3REIyRXlYVTJVTStOUEdlQUdSNVY2eGxt?= =?utf-8?B?a2RVUzIySjRvTkxGNThJYno1YTBwOUdQaWdIeVZWMmI3OG0xei9JZ2Vyb042?= =?utf-8?B?b2tHckxTUFNsZWlaRFRuck1kbm54TUtwMEJ3aHVSVW1hTENLcThXdFh6OEto?= =?utf-8?B?K3c9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3cf25a0-57d6-4507-c1ce-08da965ca71b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 14:23:11.6720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TKz+Kud+ZtVTgjtr4Qv2UN+cK5nHJh99Msv8dyhLnTWM+TCLPwGCuEDWhCobn6ZuR+jFy7JnO2b6JEPR29oCFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5551 On Wed, Sep 14, 2022 at 12:13:49PM +0200, Jan Beulich wrote: > On 14.09.2022 11:13, Roger Pau Monné wrote: > > On Wed, Sep 14, 2022 at 10:31:34AM +0200, Jan Beulich wrote: > >> On 14.09.2022 10:14, Jan Beulich wrote: > >>> On 13.09.2022 16:50, Roger Pau Monné wrote: > >>>> On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: > >>>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering > >>>>> the consistency check in check_lock() for the p2m lock. To do so in > >>>>> spurious_interrupt() requires adding reentrancy protection / handling > >>>>> there. > >>>> > >>>> There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will > >>>> trigger when trying to acquire the p2m lock from spurious_interrupt() > >>>> context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> > >>>> percpu_write_lock(). > >>> > >>> s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), > > > > do_IRQ() does call irq_enter(), and that's the caller of > > spurious_interrupt() AFAICT. > > Hmm, you're right. I was mislead by smp_call_function_interrupt() > explicitly using irq_{enter,exit}(). I guess that should have been > removed in b57458c1d02b ("x86: All vectored interrupts go through > do_IRQ()"). I guess I need to either open-code the variant of in_irq() > I'd need, or (perhaps better for overall state) explicitly irq_exit() > before the check and irq_enter() after the call. Thoughts? Well, it's ugly but it's likely the easier way to get this working. > >>> but yes - we could nest inside a lower priority interrupt. I'll make > >>> local_irq_enable() depend on !in_irq(). > >> > >> Upon further thought I guess more precautions are necessary: We might > >> have interrupted code holding the P2M lock already, and we might also > >> have interrupted code holding another MM lock precluding acquiring of > >> the P2M lock. All of this probably plays into Andrew's concerns, yet > >> still I don't view it as a viable route to omit the stack dump for HVM > >> domains, and in particular for PVH Dom0. Sadly I can't think of any > >> better approach ... > > > > Yes, I also had those concerns. The mm locks are recursive, but > > spurious_interrupt() hitting in the middle of code already holding any > > mm lock is likely to end up triggering the mm lock order checker. > > Guarding against this is possible, while ... > > > One (likely very risky option ATM) is to introduce a per pCPU flag > > that when set will turn all mm locks into noops, and use it here in > > order to avoid any locking issues. This could introduce two issues at > > least: first one is how resilient page walking routines are against > > page tables changing under their feet. The second one is that any > > page table walker p2m helper should avoid doing modifications to the > > p2m, so no P2M_ALLOC or P2M_UNSHARE flags could be used. > > ... personally I view this as too risky. Is the dump of the stack only used for the debug key handler, or there are other places this is also used? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 14 14:38:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 14:38:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.406995.649415 (Exim 4.92) (envelope-from ) id 1oYTWo-0003F4-UN; Wed, 14 Sep 2022 14:38:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 406995.649415; Wed, 14 Sep 2022 14:38:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTWo-0003Ex-R8; Wed, 14 Sep 2022 14:38:14 +0000 Received: by outflank-mailman (input) for mailman id 406995; Wed, 14 Sep 2022 14:38:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTWo-0003En-6h; Wed, 14 Sep 2022 14:38:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTWo-00082R-3p; Wed, 14 Sep 2022 14:38:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTWn-00068l-Ma; Wed, 14 Sep 2022 14:38:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYTWn-000755-M9; Wed, 14 Sep 2022 14:38:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Afn/CXuqXRe8CiD5ZK/PoN3P7mKltxIYHwXvZkGVbn8=; b=SJHbiP4n2d6MFRamOEecXV7crp VEW1XrSq2JbuI48Ie+1HRx80F4mqUeHBxM1XrEXzgFyzm++U5HTYOZbX2pzGjE7DJzbiZ8qhbvfXA oBav9EZ5hbF23WdeiBaYLgbkJ+HcW1Tk1rGD1w3wpmjEPkdeJ4CJoDt2i8f9BMuR4r90=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173190: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=838c730fe61578847823da1b815e4c9c5ee1bed4 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 14 Sep 2022 14:38:13 +0000 flight 173190 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173190/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 838c730fe61578847823da1b815e4c9c5ee1bed4 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 41 days Failing since 172151 2022-08-05 02:40:28 Z 40 days 307 attempts Testing same since 173186 2022-09-14 04:09:03 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2507 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 14:49:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 14:49:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407004.649425 (Exim 4.92) (envelope-from ) id 1oYTh7-0004lY-Tx; Wed, 14 Sep 2022 14:48:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407004.649425; Wed, 14 Sep 2022 14:48:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTh7-0004lR-RF; Wed, 14 Sep 2022 14:48:53 +0000 Received: by outflank-mailman (input) for mailman id 407004; Wed, 14 Sep 2022 14:48:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTh6-0004lH-RM; Wed, 14 Sep 2022 14:48:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTh6-0008D4-Ny; Wed, 14 Sep 2022 14:48:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYTh6-0006jS-7s; Wed, 14 Sep 2022 14:48:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYTh6-0005zS-7O; Wed, 14 Sep 2022 14:48:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YSnSLVLzA2rSCpeF00cRKPcyq2Ta46Zag7luBm8v2UE=; b=a/tVPTyolciSXx8rnrzEF10ESe BEMy6lfLQ27eoD07Nl4C1kHQVP6Ix1WGlwxj/EiIPfOAZs8P6enEmSc7Xeb6aMyWkmI7XtfHj7sja VTE12vyTvIncYeVZWLg1U+WclDhEbg5tw/o0HLkfS1+NcCWvuKoiiD7tET7ibh1dyHcw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173185: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Wed, 14 Sep 2022 14:48:52 +0000 flight 173185 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173185/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 41 days Failing since 172148 2022-08-04 21:39:38 Z 40 days 92 attempts Testing same since 173060 2022-09-08 07:34:59 Z 6 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 16:35:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 16:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407019.649446 (Exim 4.92) (envelope-from ) id 1oYVLs-00089w-L5; Wed, 14 Sep 2022 16:35:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407019.649446; Wed, 14 Sep 2022 16:35:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYVLs-00089p-IE; Wed, 14 Sep 2022 16:35:04 +0000 Received: by outflank-mailman (input) for mailman id 407019; Wed, 14 Sep 2022 16:35:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYVLr-00089f-Ru; Wed, 14 Sep 2022 16:35:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYVLr-0002Av-Ov; Wed, 14 Sep 2022 16:35:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYVLr-0004JN-Bv; Wed, 14 Sep 2022 16:35:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYVLr-0002Wg-BT; Wed, 14 Sep 2022 16:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CiMgIuP22lpIimJrClYaukwuDmTp6gQijh0TCUuGub4=; b=Mw0s3uj9JcUYBa6TSV1Jp+pxdP wVpxbmr/77a5r4KkROr4MPmyYXN1th0SJgUm9+oIZYUaPlxozNAjl97Qs0ke0lVKTa2MjmFE2OCFl DXJeQhnLK4s5f2SvVfq7+55SYiF8d8h4TcmqzClctlhqjvzTKvSiAdboTT9feo8oRsys=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173193: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=838c730fe61578847823da1b815e4c9c5ee1bed4 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 14 Sep 2022 16:35:03 +0000 flight 173193 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173193/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 838c730fe61578847823da1b815e4c9c5ee1bed4 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 41 days Failing since 172151 2022-08-05 02:40:28 Z 40 days 308 attempts Testing same since 173186 2022-09-14 04:09:03 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2507 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 17:53:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 17:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407029.649457 (Exim 4.92) (envelope-from ) id 1oYWZs-0007s1-MV; Wed, 14 Sep 2022 17:53:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407029.649457; Wed, 14 Sep 2022 17:53:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWZs-0007ru-Jn; Wed, 14 Sep 2022 17:53:36 +0000 Received: by outflank-mailman (input) for mailman id 407029; Wed, 14 Sep 2022 17:53:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWZq-0007rk-Em; Wed, 14 Sep 2022 17:53:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWZq-0003So-Bt; Wed, 14 Sep 2022 17:53:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWZp-0000gc-UP; Wed, 14 Sep 2022 17:53:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYWZp-0002ij-Ty; Wed, 14 Sep 2022 17:53:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x5IXKCTeK6fAN2+nxpwYYTOJUIbjGaaihFxsxiuUI+s=; b=jYDCDkxiA1Pqh9cF7njFRXrk4o X5PS+2iCzlm3wIUqYXKf54YiWRhKaX5yIvCgbMzi38/an/4IL9WK4bmHT0mYS0jcJLz0sNhMVf8tY T44gVgNjrz+Gw3jETyMKl66KDIf2Tb1ktHg3GlN2gYm11JKAeEm8tZfj+Ym0mcjw4wU8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173192: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c From: osstest service owner Date: Wed, 14 Sep 2022 17:53:33 +0000 flight 173192 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173192/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173103 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c Last test of basis 173103 2022-09-10 01:03:22 Z 4 days Testing same since 173192 2022-09-14 14:03:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Smith jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 942ac5fc15..3007efadf7 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Sep 14 18:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 18:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407037.649468 (Exim 4.92) (envelope-from ) id 1oYWwq-000224-IF; Wed, 14 Sep 2022 18:17:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407037.649468; Wed, 14 Sep 2022 18:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWwq-00021x-F4; Wed, 14 Sep 2022 18:17:20 +0000 Received: by outflank-mailman (input) for mailman id 407037; Wed, 14 Sep 2022 18:17:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWwp-00021n-2m; Wed, 14 Sep 2022 18:17:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWwo-0003wz-V2; Wed, 14 Sep 2022 18:17:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWwo-0003U9-F3; Wed, 14 Sep 2022 18:17:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYWwo-00006x-Ed; Wed, 14 Sep 2022 18:17:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0iZlc713uEb60HJ/tLWWJ/7+mbUrQ0gEOz+G3T+SHiA=; b=3w5wc7eQP7DbMt/t9JCbyyeNTH s/QhBq81MxQkBpcL0haiAbkMFe83iDUHmPWAdzyVbMvwkjwnGMc+0KaXbvLADXpXEphSY8Gyqo1eI eKhgL5pnlDPDaFh7xF24oETE20qTRgB0PpddHuYkPqWSr7hmYrq30evu+UGeDTtt1XPQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173189: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-examine-bios:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start.2:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Wed, 14 Sep 2022 18:17:18 +0000 flight 173189 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173189/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-examine-bios 6 xen-install fail in 173180 pass in 173189 test-armhf-armhf-xl-rtds 14 guest-start fail in 173180 pass in 173189 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173180 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173180 test-amd64-i386-xl-qemuu-debianhvm-amd64 21 guest-start.2 fail pass in 173180 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173180 like 172108 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 173180 like 172128 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173180 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173180 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173180 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173180 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 41 days Failing since 172384 2022-08-11 11:13:58 Z 34 days 73 attempts Testing same since 173008 2022-09-05 15:47:43 Z 9 days 19 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 18:19:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 18:19:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407046.649479 (Exim 4.92) (envelope-from ) id 1oYWyi-0002bd-Uh; Wed, 14 Sep 2022 18:19:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407046.649479; Wed, 14 Sep 2022 18:19:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWyi-0002bW-Rm; Wed, 14 Sep 2022 18:19:16 +0000 Received: by outflank-mailman (input) for mailman id 407046; Wed, 14 Sep 2022 18:19:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYWyh-0002bO-GJ for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 18:19:15 +0000 Received: from MTA-06-3.privateemail.com (mta-06-3.privateemail.com [198.54.127.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbe80951-3459-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 20:19:14 +0200 (CEST) Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 1ADB418000AE for ; Wed, 14 Sep 2022 14:19:12 -0400 (EDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by mta-06.privateemail.com (Postfix) with ESMTPA id E9CD018000AD for ; Wed, 14 Sep 2022 14:19:11 -0400 (EDT) Received: by mail-yb1-f182.google.com with SMTP id t184so24089157yba.4 for ; Wed, 14 Sep 2022 11:19:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbe80951-3459-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1663179552; bh=8VjHqIchoQhw5vAXHOw6gSHzk+jCMGPckOt+hm/6P+U=; h=From:Date:Subject:To:Cc:From; b=PK8/sbLsygojnjF+9blC90vGWp8ND4fmTrtB/dKC0XnMotdzTIm5E+BkaPbphuggz 7aZ6tircspcAXQ0Mworjof0UaJS0y8JDjoztBOid/hAOyBd67D5u9801wMSFfgE1sr PcLJ78xA5EBBRlPxhOC0zNHjqG0OSc8SCmvP2pXRTCjhIxWwkLtzb4IwR06gDfXJGr BtlGknUGwkO8HBhxsVzOrAJcohkr44+T4tLkdNDqGJLEHHHQ6GpS1E7ojtwF/77wxj TU8vuODa11Sn4jsr5qRHcCYWj15pFdOQ5zChfpurveLCVDLf7R7eJbMg6uk4IG4yz4 G6iDBSj8iozzg== X-Gm-Message-State: ACrzQf2klE5TqyzJ4Qvp/7zKcZqR9bdWhEw7y3Ef48V34xvGRfxSIvT+ i125UwzDmZPC03oGO+rYrit2JKz26mQe3W1PVjE= X-Google-Smtp-Source: AMsMyM6CB2hfruwQNOtZ80Xg0l8faoT6gDvpHaXXppMu5zRkJ13zWk6NVmUvJTb6fDSa4nVfdFusWKGWZeKSwXRATi8= X-Received: by 2002:a25:a563:0:b0:6b0:297e:1e7b with SMTP id h90-20020a25a563000000b006b0297e1e7bmr1640301ybi.443.1663179550457; Wed, 14 Sep 2022 11:19:10 -0700 (PDT) MIME-Version: 1.0 From: Tamas K Lengyel Date: Wed, 14 Sep 2022 14:18:34 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Console output stops on dbgp=xhci To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Xen-devel Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP Hi Marek, I'm testing the latest Xen master git branch (942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c) with the now merged xue patches. My current boot command line includes dbgp=xhci@pci00:14.0 console=dbgp and this works in that the Xen boot log shows up on the other side of the debug cable: ... (XEN) Dom0 has maximum 8 VCPUs (XEN) ELF: phdr 0 at 0xffffffff81000000 -> 0xffffffff82c5cdac (XEN) ELF: phdr 1 at 0xffffffff82e00000 -> 0xffffffff831a1000 (XEN) ELF: phdr 2 at 0xffffffff831a1000 -> 0xffffffff831d5000 (XEN) ELF: phdr 3 at 0xffffffff831d5000 -> 0xffffffff84000000 However, debug output on the USB3 port stops at this point. I would expect to see the same as xl dmesg shows: (XEN) Dom0 has maximum 8 VCPUs (XEN) ELF: phdr 0 at 0xffffffff81000000 -> 0xffffffff82c5cdac (XEN) ELF: phdr 1 at 0xffffffff82e00000 -> 0xffffffff831a1000 (XEN) ELF: phdr 2 at 0xffffffff831a1000 -> 0xffffffff831d5000 (XEN) ELF: phdr 3 at 0xffffffff831d5000 -> 0xffffffff84000000 (XEN) Initial low memory virq threshold set at 0x4000 pages. (XEN) Scrubbing Free RAM in background (XEN) Std. Loglevel: All (XEN) Guest Loglevel: All (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input) (XEN) Freed 2048kB init memory ... Do you have any idea what might be going on and preventing the output from showing over USB3 afterwards? The /dev/ttyUSB0 device is still present on the receiving side, just nothing is being received over it. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Wed Sep 14 19:40:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 19:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407054.649489 (Exim 4.92) (envelope-from ) id 1oYYEZ-0002Om-Sr; Wed, 14 Sep 2022 19:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407054.649489; Wed, 14 Sep 2022 19:39:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYYEZ-0002Of-Po; Wed, 14 Sep 2022 19:39:43 +0000 Received: by outflank-mailman (input) for mailman id 407054; Wed, 14 Sep 2022 19:39:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYYEY-0002OV-Al; Wed, 14 Sep 2022 19:39:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYYEY-0005Gl-8B; Wed, 14 Sep 2022 19:39:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYYEX-0008Nw-Sg; Wed, 14 Sep 2022 19:39:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYYEX-0008TM-Rz; Wed, 14 Sep 2022 19:39:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0dV0lisBMfgeGKB+DOmXU6aFZtK78/toCWnF8QE3JJ0=; b=MiPyo89Ltsptri5v7rs8NLtacI otvpJ319cC3yUJjBJ6amyEPX0y0i0OrTE9V770zIKE17zOHuEkAeHDekw3RbmbesibTQbM7KGgkDD WwU2+ju+h1qTMZ+CYPut6WO7iOeJe6tvHlLDaoQi04yXgd0vR+8j7uXeoGR9yBPGoAWo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173196: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=838c730fe61578847823da1b815e4c9c5ee1bed4 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Wed, 14 Sep 2022 19:39:41 +0000 flight 173196 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173196/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 838c730fe61578847823da1b815e4c9c5ee1bed4 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 41 days Failing since 172151 2022-08-05 02:40:28 Z 40 days 309 attempts Testing same since 173186 2022-09-14 04:09:03 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2507 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 21:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 21:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407063.649501 (Exim 4.92) (envelope-from ) id 1oYaON-0007iE-UI; Wed, 14 Sep 2022 21:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407063.649501; Wed, 14 Sep 2022 21:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYaON-0007i7-RP; Wed, 14 Sep 2022 21:57:59 +0000 Received: by outflank-mailman (input) for mailman id 407063; Wed, 14 Sep 2022 21:57:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYaOL-0007hz-PL for xen-devel@lists.xenproject.org; Wed, 14 Sep 2022 21:57:58 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46731bc5-3478-11ed-a31c-8f8a9ae3403f; Wed, 14 Sep 2022 23:57:54 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DEA1332008C3; Wed, 14 Sep 2022 17:57:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 14 Sep 2022 17:57:49 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 17:57:47 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46731bc5-3478-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663192668; x= 1663279068; bh=OAN5LsID3X71jX+maQj61gzzhE9IyV63Ed8vjoMSWx4=; b=z Fzw/DwONX7hs/U9wEbASRlN3//lMDPn7bYw+Fm1tj6lktozMnd1J5WbqK7M+yK8H +i+BsH+q2wiyDGrqtqM3cILm/Ofsz+yMBdCoLfrLol1NuBtCM6bCa42z7zCbIwEI LtHtOok5ezNc93vieePOuPpSg/0j+qE2n06dPdJiVTk9n7SG3F+3y3S6io7BIiUY u59mBMKUgh2kPr7dbcmXrlOgavmMXBRmExbBr1rXmXVgSPmAuamcF8SqVVPAZ13g sMQ5le3U+gr9wo1bqh9Zr3+lIIg2S/1YdVLS4P5011dctyVtx7xk9uJltSPMhgWX Tpe/0ktsaZM5pLVEjIOBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663192668; x=1663279068; bh=OAN5LsID3X71jX+maQj61gzzhE9I yV63Ed8vjoMSWx4=; b=tdlBH7aM2qB8z8kWHk9BZlp4I3QcNDRGE+DBqWRNBCaK hZhZtSE3Qvyr/V9vynEbvRx2AAZML1tN8acDh29n3R7KjBi382VRRByRTL3GIz3n URISdmAHZNc2MjVm+y21Mkcz+TBfUF4RGQRbJfpQWE30zRsvwoytIrYeF0xckpWg Qorb1jRLfwMTZUihbCs3SGuxem7YJhlgl0QYPvVqETh/M2P9NwMTYYiaQG9MJya4 j3HUmLohWX1V1F/7e3M/diGeGxPcAS2WqVwzOWqUU1i3idRmqH2NW2k93j4XWTkV a6Ak6zXTjd0r07wHUpP1KxeLkdQbibnkDLNhJrG3NA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedujedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 14 Sep 2022 23:57:44 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Tamas K Lengyel Cc: Xen-devel Subject: Re: Console output stops on dbgp=xhci Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aVpFiCEGh7y89z61" Content-Disposition: inline In-Reply-To: --aVpFiCEGh7y89z61 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Sep 2022 23:57:44 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Tamas K Lengyel Cc: Xen-devel Subject: Re: Console output stops on dbgp=xhci On Wed, Sep 14, 2022 at 02:18:34PM -0400, Tamas K Lengyel wrote: > Hi Marek, > I'm testing the latest Xen master git branch > (942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c) with the now merged xue > patches. My current boot command line includes dbgp=3Dxhci@pci00:14.0 > console=3Ddbgp and this works in that the Xen boot log shows up on the > other side of the debug cable: >=20 > ... >=20 > (XEN) Dom0 has maximum 8 VCPUs >=20 > (XEN) ELF: phdr 0 at 0xffffffff81000000 -> 0xffffffff82c5cdac >=20 > (XEN) ELF: phdr 1 at 0xffffffff82e00000 -> 0xffffffff831a1000 >=20 > (XEN) ELF: phdr 2 at 0xffffffff831a1000 -> 0xffffffff831d5000 >=20 > (XEN) ELF: phdr 3 at 0xffffffff831d5000 -> 0xffffffff84000000 >=20 > However, debug output on the USB3 port stops at this point. I would > expect to see the same as xl dmesg shows: >=20 > (XEN) Dom0 has maximum 8 VCPUs > (XEN) ELF: phdr 0 at 0xffffffff81000000 -> 0xffffffff82c5cdac > (XEN) ELF: phdr 1 at 0xffffffff82e00000 -> 0xffffffff831a1000 > (XEN) ELF: phdr 2 at 0xffffffff831a1000 -> 0xffffffff831d5000 > (XEN) ELF: phdr 3 at 0xffffffff831d5000 -> 0xffffffff84000000 > (XEN) Initial low memory virq threshold set at 0x4000 pages. > (XEN) Scrubbing Free RAM in background > (XEN) Std. Loglevel: All > (XEN) Guest Loglevel: All > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input) > (XEN) Freed 2048kB init memory > ... >=20 > Do you have any idea what might be going on and preventing the output > from showing over USB3 afterwards? The /dev/ttyUSB0 device is still > present on the receiving side, just nothing is being received over it. There are few more patches in the series that are de facto required. Especially those about IOMMU, otherwise it can only possibly work with iommu=3D0 (which I'm not sure if even is enough). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --aVpFiCEGh7y89z61 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMiTlgACgkQ24/THMrX 1yzg3wf/cz+gkgHuT38bh2EO5E51EJKMvP0iDXyh4vyMpszXHYPtprrP9ZT6mVY1 TefFFuWxFOp///7iRzwMqRQgaVHe1UhK2ec7LzwbWxuP+U30BWyzM9bgSHtxaHKk 2qZvjcB9gVdBHqpUGRukidWHFVWAPW2zSwd0zojqKUQdftApTG6JqjDz85f0U+/H uh945c4YfDSyj46dMdfqAhZM2dhA1sONsmXjPM5jfe0wHMdP/lQ4hWpVpyxhZpig JSeqcFz5OCZdjArxKrVTKAD+ISANyNhJzR3cnEspCapXll84G8N/vceJdBiQOEj1 ElgfWIBm3sQ1qHC3DyrBgXf1y6Um+g== =TCXG -----END PGP SIGNATURE----- --aVpFiCEGh7y89z61-- From xen-devel-bounces@lists.xenproject.org Wed Sep 14 22:51:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 22:51:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407109.649530 (Exim 4.92) (envelope-from ) id 1oYbE5-0006TO-Ac; Wed, 14 Sep 2022 22:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407109.649530; Wed, 14 Sep 2022 22:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbE5-0006TH-6y; Wed, 14 Sep 2022 22:51:25 +0000 Received: by outflank-mailman (input) for mailman id 407109; Wed, 14 Sep 2022 22:51:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbE4-0006T5-3O; Wed, 14 Sep 2022 22:51:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbE4-0008Sa-0K; Wed, 14 Sep 2022 22:51:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbE3-0002Hj-KP; Wed, 14 Sep 2022 22:51:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYbE3-0006cv-Do; Wed, 14 Sep 2022 22:51:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9UXowyOu5X5rDDHvxyvhF2rwcpVq1kMjHGNJpx+NMzI=; b=dkMHKmKl4Jj5F01+hTSydvGiHS bJAiGz6CrPcMN4W/VQAUoOrIffPDtrAY+DP+LCg8g5/zYXWi+vSJDqsJA1rcOZYhJvHLw1UjuPt0z lkCjB1Bh3FRc8O2lLfGFK8WK3Xn0Q2doNDE6zTrgT21+Wt5qaDA3kbYAYfNbwHtmHe2E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173191: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3245cb65fd91cd514801bf91f5a3066d562f0ac4 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Wed, 14 Sep 2022 22:51:23 +0000 flight 173191 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173191/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3245cb65fd91cd514801bf91f5a3066d562f0ac4 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 41 days Failing since 172152 2022-08-05 04:01:26 Z 40 days 92 attempts Testing same since 173191 2022-09-14 11:10:31 Z 0 days 1 attempts ------------------------------------------------------------ 1779 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182803 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 14 23:05:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 14 Sep 2022 23:05:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407120.649541 (Exim 4.92) (envelope-from ) id 1oYbRz-0008AW-MI; Wed, 14 Sep 2022 23:05:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407120.649541; Wed, 14 Sep 2022 23:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbRz-0008AP-Ip; Wed, 14 Sep 2022 23:05:47 +0000 Received: by outflank-mailman (input) for mailman id 407120; Wed, 14 Sep 2022 23:05:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbRy-0008AF-85; Wed, 14 Sep 2022 23:05:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbRy-0000Ht-4R; Wed, 14 Sep 2022 23:05:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYbRx-00048v-MJ; Wed, 14 Sep 2022 23:05:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYbRx-0000O2-Lr; Wed, 14 Sep 2022 23:05:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5UQ2XU69L6jTevBHiDDW4IQOrYn6qd5NkyspTeohjk0=; b=QbFHs6wmzZCT7eVjUZY1qd4DNB e0mCmlcEdvoPEq2tGWSv7iKR/BJsqmh+x05bgjyRyFPs/AmNggAltHs98Pk1Lf66IYjIusY/19Pgc bskTXNMP39xNCpFiAYN7dJuNpAhX5t6F1MRogwlsAwAy6+BJvro/b8hkoTeqZSConE1k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173194: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Wed, 14 Sep 2022 23:05:45 +0000 flight 173194 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173194/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10 fail pass in 173185 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 42 days Failing since 172148 2022-08-04 21:39:38 Z 41 days 93 attempts Testing same since 173060 2022-09-08 07:34:59 Z 6 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 00:43:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 00:43:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407168.649570 (Exim 4.92) (envelope-from ) id 1oYcxn-0002vv-0p; Thu, 15 Sep 2022 00:42:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407168.649570; Thu, 15 Sep 2022 00:42:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYcxm-0002vo-Su; Thu, 15 Sep 2022 00:42:42 +0000 Received: by outflank-mailman (input) for mailman id 407168; Thu, 15 Sep 2022 00:42:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYcxl-0002vf-89 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 00:42:41 +0000 Received: from MTA-10-4.privateemail.com (mta-10-4.privateemail.com [198.54.122.149]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b4a3b18-348f-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 02:42:38 +0200 (CEST) Received: from mta-10.privateemail.com (localhost [127.0.0.1]) by mta-10.privateemail.com (Postfix) with ESMTP id CB2FD18000A1 for ; Wed, 14 Sep 2022 20:42:35 -0400 (EDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by mta-10.privateemail.com (Postfix) with ESMTPA id A7548180009F for ; Wed, 14 Sep 2022 20:42:35 -0400 (EDT) Received: by mail-yb1-f176.google.com with SMTP id 198so20272114ybc.1 for ; Wed, 14 Sep 2022 17:42:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b4a3b18-348f-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1663202555; bh=6c+E15qTNQYC/Wgk4Qqg+ltDuo8IcNO92o6suwDssqc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WJO+a/esGO7vZmjH9rkz+x+c3WXgVGPUwpkE+Q+8lHkMww+ox8GehLac0SBzPlWQu FwDFlsxzx+igUrWMr3kwDznmIkBLjwxWYLz9KROUo5vKWKHQiOKzti0ygciYTFIIBa 2vOvlgdjv+R83rsYHJG0l1mwb86iYFaLZyhx4B+7R6Xqw4HJvWl3gfTOJrP193cdKy DFvlk1qfcaVcXWNiHEuMvPS3AUsr1bwXCiX3hLXoJYhgJIvU96AjMjByEmo5Es8Dj8 iSzhhTqWamEKm+u4F6WqJSTiFitGHmMQZr1iJ/OeKr6OMnAZWd4Dtz+g12VKWAOZTQ 6lfCvHJ93mi8A== X-Gm-Message-State: ACgBeo0mnwQAr/HaqQLk4uq/XThKxvX9UxyxnzuMJjeL5IOGaguuWzqg CpdxTZWHtJnnbRb68ch1YT6oIGRcasshDu8Q0gU= X-Google-Smtp-Source: AA6agR6vNdfJmyrGtXQMpdHUrYYtj4+Ij8hZ6HdUfxbXI17jGnYNIJxWqfW62UGGAmoUVRm6hN6dv8FYjII3Pc8rjus= X-Received: by 2002:a25:42d7:0:b0:6ae:ae83:59c0 with SMTP id p206-20020a2542d7000000b006aeae8359c0mr18860776yba.165.1663202554967; Wed, 14 Sep 2022 17:42:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Wed, 14 Sep 2022 20:41:59 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Console output stops on dbgp=xhci To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Xen-devel Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP > > Do you have any idea what might be going on and preventing the output > > from showing over USB3 afterwards? The /dev/ttyUSB0 device is still > > present on the receiving side, just nothing is being received over it. > > There are few more patches in the series that are de facto required. > Especially those about IOMMU, otherwise it can only possibly work with > iommu=0 (which I'm not sure if even is enough). Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this on the console: (XEN) Panic on CPU 0: (XEN) FATAL PAGE FAULT (XEN) [error_code=0011] (XEN) Faulting linear address: 00000000328b3a54 Not sure what's up with that. Either way, can you post a git branch with the remaining patches that are not yet merged in master? Want to check if those patches resolve the issue. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Thu Sep 15 01:12:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 01:12:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407174.649581 (Exim 4.92) (envelope-from ) id 1oYdQS-0004cM-9K; Thu, 15 Sep 2022 01:12:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407174.649581; Thu, 15 Sep 2022 01:12:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdQS-0004cF-6L; Thu, 15 Sep 2022 01:12:20 +0000 Received: by outflank-mailman (input) for mailman id 407174; Thu, 15 Sep 2022 01:12:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdQR-0004c5-8d; Thu, 15 Sep 2022 01:12:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdQR-0001G6-1P; Thu, 15 Sep 2022 01:12:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdQQ-0004Ej-Kr; Thu, 15 Sep 2022 01:12:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYdQQ-0000vA-KP; Thu, 15 Sep 2022 01:12:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3+LGlLFdCFRwJTia3LPvjzyWX5WO9PynjfO+eaIjOa0=; b=N1DJIpHC2WxRztxM79IeMKc79C aa2/blSRbkm6u5fQ7Shjqx85s7DgtTbwZoaTuEuHJ3Z7QMOmogW6C+oXMewyikzFFeeSJoPIz914c gc9W9hOpz+Z/ZRPxdGPAxCgfMLIdSOfPlv9KqnycHKoe7elNAkfutZiAod50Cb5/Vz+U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173199: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=838c730fe61578847823da1b815e4c9c5ee1bed4 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 01:12:18 +0000 flight 173199 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173199/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 838c730fe61578847823da1b815e4c9c5ee1bed4 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 41 days Failing since 172151 2022-08-05 02:40:28 Z 40 days 310 attempts Testing same since 173186 2022-09-14 04:09:03 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2507 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 01:18:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 01:18:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407185.649592 (Exim 4.92) (envelope-from ) id 1oYdWa-0005Ni-41; Thu, 15 Sep 2022 01:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407185.649592; Thu, 15 Sep 2022 01:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdWa-0005Nb-1A; Thu, 15 Sep 2022 01:18:40 +0000 Received: by outflank-mailman (input) for mailman id 407185; Thu, 15 Sep 2022 01:18:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdWY-0005NV-BK for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 01:18:38 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2058.outbound.protection.outlook.com [40.107.243.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50d68eb5-3494-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 03:18:36 +0200 (CEST) Received: from MW2PR16CA0017.namprd16.prod.outlook.com (2603:10b6:907::30) by BL0PR12MB4946.namprd12.prod.outlook.com (2603:10b6:208:1c5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18; Thu, 15 Sep 2022 01:18:30 +0000 Received: from CO1NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:907:0:cafe::67) by MW2PR16CA0017.outlook.office365.com (2603:10b6:907::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14 via Frontend Transport; Thu, 15 Sep 2022 01:18:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT054.mail.protection.outlook.com (10.13.174.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Thu, 15 Sep 2022 01:18:30 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 20:18:29 -0500 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 14 Sep 2022 20:18:28 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50d68eb5-3494-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgxdrfDDuicq2VjnRv4jcbfmVPFIQoM3JyzcKW2qQDK4lbmhWPWcCLpRraFpcs2b3X78joY6Uu0QjtLVVsJkhbJ9fh7529N7e94lDV7Iu9WoAfQSasa9xvBpgkd4ZwCFd3T/UKemTUYOvRbVsTweR4cPyDku0Q5F4xY5EQeolPM25pJxIbgoiR1gN0r7vR6n3RQZOXSfJ2NKNy1y/hQjNb3tafde7i4KG+yWx/Q362P/UTD6jp67yG+4ujjFJ/w2n38WOIhdcAizzE2w04UiTPjXDtiGWO4O7YycsYvLgNlBiFhbcFov/dmmlO/NjAV4sf9TJLNyrJD9jQpHTTfcug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4jBzfq64zbmPoO+yKEshyOUcrteWknczyvtCfQcmjcQ=; b=XAiIhU3quFhvtWE0CwmeWzD5RzJ7HPUzpaP5MTwPEJzTxQHcsM30qIdCw04nhymIGI3st2G2p2b1JXCJcRFLEeUbZ4NBWvACoLzemLBt/ZJGCCc49ljGjZ/hO+aCgJlpEYMHAVEsS6H2+blcU7ErZSIqMQuIqVOdTQWILTD777eBVxEeev5XXLKrQoCQBHVht2g6OQ/r/DmjvNxpeC27rMPjdFNGn75c16Z2gSYo0QHbXAA13V2dxm99B8HGxCiOrnvQnLogv826KIxEuXdFUYlfVVH0BePMgrK/D4tQ9TwB1o1XHcjfZuMpBD2+ImKDm+YSe8QxHWafBj3bZ5qGGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4jBzfq64zbmPoO+yKEshyOUcrteWknczyvtCfQcmjcQ=; b=DKV0eouucYJKnFjhx6FIl0lsMSD2z82tq83WTProwl+nOClhUCwvQxyM3u68uI2X2fno1JH748Y+ZyEskswZg1Ne07GJ8P7Q3ID+zw7jZ/Vz7+qYECIrZDBqN9JnLy/msP3MJM1XpSjD9v0E5DrTdIHrBjr/vsc12vij+5SFGPM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Date: Wed, 14 Sep 2022 18:18:28 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich CC: Stefano Stabellini , "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT054:EE_|BL0PR12MB4946:EE_ X-MS-Office365-Filtering-Correlation-Id: 8671795a-313a-4dd3-806f-08da96b83349 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G72KHCbhq+11t/+Oh/S0ekVAP3hyGnKcrzIidWH8qjWS3k3ZKcjPC2oDowQmNIjuDCulOgz8b4/RDCYD6sVcSA+aE8cP4Iboz+RVswLt01bIWJKkSqU/ry3Of/TFebCcOlgqTUbjy1ajfYuLIRuJb608xQ18H5+TbDRXDhd0H19TX9RTWQGULaVf6s9Vt1BfkzHQvKBZ6oAtEB6EETqyT+aV25qK55MH45CCcZk/dL/x5WKFg+etmj0+r/sp84qehVjgcRe9pna/ERDvUZwMAhrKVg4n/VwOXaT73iMhFrTSV0fiwh/j9WuxgaP9BtY5V0bi39Qob0qG41T+dRBdXts1RKlQhnp0puMSWZ5HsVblDqkUb+NLpW++VpusQvVO2ejBm5p3sD5lnDryD+D/483a7UuJWDT/TKRlUpeC0LcFXh9k2UViDrfiuoKfjg1xtHTxG94XebxhPhJmwvdZk09nYW/74OgGIKPmQlPt3JMXOZYqvdbt5l/peCxbT3jzGT67xXgBU4UyH592Mi6wkcPCuWXWNaxmxdEtQM4ViX4aVix+Z5UD+rcNl9bvALI5h3BYBXVAd3vcBE3L2Trg58VfaOFL1kWViQ1Cj2M4+8sy0ELuWG9qdCVHzc3qQ6R03txbFGNxCcC9zn69UvMgExYqec3/uieoXMzC2fso/fcVNc+6ErJI2VyM4Wvbkh225HxPg9gfo5wNXyWQHC9Z7R/VXIm87G2nxKENGLBkLXNMMLzwaT3z2x8OUjOR0hOKdEJ8xdZ9YAOTivTlsJWljyS3aVpI71CL93qsNLQvO2xsTeCbub443CUeZvk0DGoD X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(8936002)(186003)(47076005)(40480700001)(9686003)(356005)(86362001)(81166007)(316002)(53546011)(41300700001)(426003)(82740400003)(478600001)(54906003)(33716001)(4326008)(83380400001)(6916009)(70206006)(40460700003)(70586007)(336012)(5660300002)(44832011)(36860700001)(26005)(8676002)(82310400005)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 01:18:30.3075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8671795a-313a-4dd3-806f-08da96b83349 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4946 On Wed, 14 Sep 2022, Jan Beulich wrote: > On 14.09.2022 01:31, Stefano Stabellini wrote: > > The problem is that drivers/xen/privcmd.c:privcmd_mmap sets VM_IO | > > VM_PFNMAP, and either flag would cause check_vma_flags to return > > -EFAULT. > > > > Do you know if it works if you remove VM_IO | VM_PFNMAP from > > privcmd_mmap? > > My Linux MM knowledge is certainly rusty, but I don't think this can > work, at the very least not without further changes elsewhere. The definition of VM_PFNMAP is: Page-ranges managed without "struct page", just pure PFN So it made perfect sense to use VM_PFNMAP back in the day when we were using address ranges without "struct page" for foreign mappings. However, nowadays Linux drivers typically call xen_alloc_unpopulated_pages to get local pages to be used for foreign mappings. xen_alloc_unpopulated_pages should work for both PV and autotranslated guests. So the local pages should have a regular "struct page" backing them. I noticed that privcmd calls alloc_empty_pages->xen_alloc_unpopulated_pages only for autotranslated guests. Do you guys think it is intentional? In theory, xen_alloc_unpopulated_pages should work for PV guests too. After that, privcmd calls xen_remap_domain_gfn_array, which calls xen_xlate_remap_gfn_array or xen_remap_pfn depending on PV or autotranslated. But then I can see the following at the top of xlate_remap_gfn_array: /* Kept here for the purpose of making sure code doesn't break x86 PVOPS */ BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO))); and a similar one in arch/x86/xen/mmu_pv.c:xen_remap_pfn: BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO))); Given that the pages passed to xen_xlate_remap_gfn_array and xen_remap_pfn could have been allocated with xen_alloc_unpopulated_pages, why the BUG_ON? Is this just legacy? In the sense that the following could work? - privcmd calls xen_alloc_unpopulated_pages for both PV & autotranslated - no setting VM_PFNMAP | VM_IO - no BUG_ON in xlate_remap_gfn_array - no BUG_ON in xen_remap_pfn Am I missing something? > I did look some at the specific use by the TEE subsystem, and it looks > to me as if their "shared memory" machinery simply isn't meant to be > used with non-local memory. Any more info? From xen-devel-bounces@lists.xenproject.org Thu Sep 15 01:28:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 01:28:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407192.649602 (Exim 4.92) (envelope-from ) id 1oYdg7-00072K-1r; Thu, 15 Sep 2022 01:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407192.649602; Thu, 15 Sep 2022 01:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdg6-00072D-VP; Thu, 15 Sep 2022 01:28:30 +0000 Received: by outflank-mailman (input) for mailman id 407192; Thu, 15 Sep 2022 01:28:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdg5-000727-Dp for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 01:28:29 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1e9796b-3495-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 03:28:27 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8F7523200A1A; Wed, 14 Sep 2022 21:28:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 14 Sep 2022 21:28:24 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 21:28:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1e9796b-3495-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663205304; x= 1663291704; bh=l1fnseSnzVShMhAuJkr5Ysl7c2SbHiOQMdqpYfguPIo=; b=G BZbCh8b/WDPE7fI+IwpCHthV9TsYzTqw4h3cW6DeN2kTMy4wLxPhiOCujBg2WHLm NGKuS9zd+3y9pC/98mrgIrGCqL4FnWbNBeWk2J8kxJ7X5j5A7qlB7j489SZJqqHb z42+9G8EQFfcQNJtAw1Kv0Rd1wwMglSffkwiOdERWANztXSpWdtWmQa4KqtILEe9 TtYHp1kZCp8Kq66lPmPQCExOMl0iAUm3LfKCJkzdHBi3VCuXW5zMX8Jv2PTId2SA xmES2mvudj6XwF3NeOcASiHENLlXhJRzCAkvYAZa8jDzfxEcyz3bMFtMMUcj5z1T ynZZUt+/VlCgaKWYlRtaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663205304; x=1663291704; bh=l1fnseSnzVShMhAuJkr5Ysl7c2Sb HiOQMdqpYfguPIo=; b=Kc7L0bURTw8EAvT9vPYMVzF5nCmUz3tolkXEF9ZwgF4S Jh5Rt8xZPX1V881bQEkjCCurUCddW+3q4imRkvv6f3Kz64ZOqnZhfkKUHzAFccXX ik/rssbZuHB/e623tPSZBWqbl3sr9xxULI3MBWSj0aa2Yybkb+eND2yW3NWHLr8j mJJnag4q/RIpNVtBmuXDQ5kYIguhkne09+hHASShFo6ToGGc1niaHdirLeErseG8 AAXRqFqlz6+opM272jSW4nEf0bPqqZ8ZFzQP5p/16n93mFwH7/K/a+mHheXuuxRM phwZWG2BHYs8v9JMBgHVdXuIOvshJN1sOlHXdO/DFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedujedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 15 Sep 2022 03:28:20 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Tamas K Lengyel Cc: Xen-devel Subject: Re: Console output stops on dbgp=xhci Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wKQ1kuJXuD1mREl3" Content-Disposition: inline In-Reply-To: --wKQ1kuJXuD1mREl3 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 15 Sep 2022 03:28:20 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Tamas K Lengyel Cc: Xen-devel Subject: Re: Console output stops on dbgp=xhci On Wed, Sep 14, 2022 at 08:41:59PM -0400, Tamas K Lengyel wrote: > > > Do you have any idea what might be going on and preventing the output > > > from showing over USB3 afterwards? The /dev/ttyUSB0 device is still > > > present on the receiving side, just nothing is being received over it. > > > > There are few more patches in the series that are de facto required. > > Especially those about IOMMU, otherwise it can only possibly work with > > iommu=3D0 (which I'm not sure if even is enough). >=20 > Unfortunately with iommu=3D0 Xen doesn't boot at all for me. I see this > on the console: >=20 > (XEN) Panic on CPU 0: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=3D0011] > (XEN) Faulting linear address: 00000000328b3a54 >=20 > Not sure what's up with that. Either way, can you post a git branch > with the remaining patches that are not yet merged in master? Want to > check if those patches resolve the issue. I keep it at https://github.com/marmarek/xen/tree/master-xue=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --wKQ1kuJXuD1mREl3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMif7QACgkQ24/THMrX 1yycgQf/XB3JIiv51Op5svRImHq/K8mrKWMHiQKTcTURs7eW4U2EKizneydQSKLh z79cRPuVMkqBbiJlYZ/YNzwygUKli0LjTAbtwgzRztnlzzs36Jq+FMN4dbG8J/3X LnUYmPwF4ql7UZz4NB2RP1l/EMA3j+uEbN4AsWmJGrkEpWJo3M2XVMlXL6etrlgr kBHTCIliXVFa4YxJYh4o4ivZ80t9X6RWQmUkV2mZky9KG7PEp7ZLI7yIASn0D/ed cyyrGCcEFFXjbUZws5mKaexBrbVRrXkiGL0pHZHIeHuECD75vnZ4H4lGfRLSFtTk WTxXmWghOnQ9GIbv9PeeIqgfKj0x+Q== =LVcj -----END PGP SIGNATURE----- --wKQ1kuJXuD1mREl3-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 02:36:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 02:36:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407201.649617 (Exim 4.92) (envelope-from ) id 1oYejd-0006Bl-4B; Thu, 15 Sep 2022 02:36:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407201.649617; Thu, 15 Sep 2022 02:36:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYejc-0006Bd-Vu; Thu, 15 Sep 2022 02:36:12 +0000 Received: by outflank-mailman (input) for mailman id 407201; Thu, 15 Sep 2022 02:36:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYeja-0006BX-Lu for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 02:36:10 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2057.outbound.protection.outlook.com [40.107.220.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 269451ba-349f-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 04:36:08 +0200 (CEST) Received: from MW4PR03CA0210.namprd03.prod.outlook.com (2603:10b6:303:b8::35) by DS7PR12MB5909.namprd12.prod.outlook.com (2603:10b6:8:7a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 02:36:04 +0000 Received: from CO1NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::8e) by MW4PR03CA0210.outlook.office365.com (2603:10b6:303:b8::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Thu, 15 Sep 2022 02:36:04 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT107.mail.protection.outlook.com (10.13.175.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Thu, 15 Sep 2022 02:36:04 +0000 Received: from rl2-Majolica-RN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 21:36:00 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 269451ba-349f-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TIHyF6hJUEnA596NSw1ntCkU/Gh7T27HDBU9BogeNWTgKazjfLzqZa+gM+U0h7tdOSfMOSVtoqIP3iwYAuwZ8veIdoUA4StXWSxFqJkhL5QhJWkZufIELa2PCDqpuO1OMgFCXAJGjo+9myTROJhhzB7KYgJuwib8sG/mUdpM5LrEmZFBsHSPsYhVTMSuzcn2lmEfzQ5KqTFRd9ZY5n6I8WBkipbDSMPlSUcHnxNsPjpYwcHqPMw1jWBz/MYD0cPfOEgVNSutii4+AN4w3AHD4jfMV5nakuE6qKUUkUa+AVwvCllfL5uLM+YNI6OUTd2pYkhPi0LvUqJ9nksmbVuzag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqyNMlb7/J0y1BadjEuQqbqAf+4dxOWDN7lqZDyDBck=; b=lfBpeLzq6xBsSYl6Vw50ok8Roa/3ZKaQspgMmrdbNFAeiXLKUv739SvUEbk/I1/kAOGt6c0EGmRFAvHbl651MvqbcG7nuZGw+Z6Hs2ZP/qavBHolH8kAK28x0N8NveQLswcprIiH9fJ22y9d6Ek6yon4ViuvuYlgCp9NwCGDqpZEfC/vTP02E4rJImM02dAtIur66LO8E62xis2dCK8f9v8NjHOuvp69lERYn0/fH325OeCfUtT5Hf70PR9UoyWCVSycLqo/C1oPifqk80Nm4Y02ZZNB5ZOWW06DZMfpG3aLERqn8lXxc8qwQz8fPXl6e24ARiUSn9aiV1UZpP0tJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqyNMlb7/J0y1BadjEuQqbqAf+4dxOWDN7lqZDyDBck=; b=D3fhDZpOsEHNlOxS0Dp78oT1TL7CZ/5w4q9voidqQhdknoP1nKE5Aiysp60aMpdbUoeLUSjPsqe0FgdkM9GosElu31uzuIjQfm1Dh9XWiKITEeMs9gJPkChT4Ur3Aj6AK30GVn8869k10v0uRZ9bUcaNyBKL79AOS3jNBB0oVr4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: "Ji, Ruili" To: , CC: Ruili Ji , Paul Durrant , Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Date: Thu, 15 Sep 2022 10:35:41 +0800 Message-ID: <20220915023541.5326-1-ruili.ji@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT107:EE_|DS7PR12MB5909:EE_ X-MS-Office365-Filtering-Correlation-Id: 55cffd5a-e76c-4989-6194-08da96c30960 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PBbiucyYkdgTlf3SmPjtqKXsn6gd0Z03M0h+RMPHCNdNPOyaCIsomW8JfVEDkUDzyxHYAuVhbaZTOYIAFZuPUVXtsIY4jFyfsYlOezcZsaw/qZpoPElYZUH7YqhhSlyvaUk+M6/eAl/xRewKeeSqnhvUE/8zTCuAs2/HMf8wr1DwPfeUIIS1/bxbEtonf3s0jnv11qdIDkPGrhWW4KS6O8rSdvF2ybHJBo8p5f3Ozef0AEujWM0KIKMueoLRFfEhxum5Xsp59xDA9dCboCQV1gOAwhu4fz3EQlele+FXeI0N8nYPX/c8kBm24+NzwqM7vR4vYom35eOIXSyNGAyVl9thSS7i8FTLwD7yI1PVHzcdmRTbf8+gYezJpSxABkPY2Vi8A7RrkkwV4Ju4qGYmwwKdE6Oc28nAIKdkfvMHFEDJH+NcEJlm3D+PtlOmOTUFImKolMKuwgWqFLH32GKXuTlByNDNmH9+ehEPPd++3DX04yr65EKqGeKmltpkViSf5pGZ1k40ZDxRNiCV8DG+NBW8dkUImN1JFFIkh7S8j+Wa0NLT2r0JNjdXJnglua3qTeI7DRUmjtDAUOU6DLkB+wQxrG1xV0yBkHzdKdYk36R/f40KgdZdb+O3fSw5Y8ndclArUuwlJGzrvXxnTE+h3CCkoAaejMVx+PooUekW7YWPQ/Chveyj16nD6mADgltof0myKthTj74HUSfJGmoHS2lbkchyUYpjM0P21Xn5SZfiNosJys/bNtk/+QrtK1QkqUcy67oGHtOkxo1UnDahx9WiG9WehND8nJm40ph82z8DiySbw8KE0sBXH5dcS4EGLxDLijl9bc1YE+CjTafa4FyEMYSKRo7Z63E5Yvjan8c= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(82310400005)(83380400001)(8676002)(110136005)(316002)(8936002)(86362001)(70206006)(70586007)(4326008)(16526019)(426003)(47076005)(36860700001)(2616005)(40460700003)(966005)(6666004)(7696005)(54906003)(41300700001)(478600001)(81166007)(336012)(356005)(26005)(186003)(82740400003)(40480700001)(1076003)(2906002)(5660300002)(36756003)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 02:36:04.4572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55cffd5a-e76c-4989-6194-08da96c30960 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5909 From: Ruili Ji Make guest os access pci device control 2 reg for passthrough device as struct XenPTRegInfo described in the file hw/xen/xen_pt.h. /* reg read only field mask (ON:RO/ROS, OFF:other) */ uint32_t ro_mask; /* reg emulate field mask (ON:emu, OFF:passthrough) */ uint32_t emu_mask; Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196 Reviewed-by: Paul Durrant Signed-off-by: Aaron.Liu@amd.com Signed-off-by: ruili.ji@amd.com --- hw/xen/xen_pt_config_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index c5c4e943a8..adc565a00a 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = { .offset = 0x28, .size = 2, .init_val = 0x0000, - .ro_mask = 0xFFE0, - .emu_mask = 0xFFFF, + .ro_mask = 0xFFA0, + .emu_mask = 0xFFBF, .init = xen_pt_devctrl2_reg_init, .u.w.read = xen_pt_word_reg_read, .u.w.write = xen_pt_word_reg_write, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 05:18:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 05:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407208.649628 (Exim 4.92) (envelope-from ) id 1oYhGi-0005tV-D5; Thu, 15 Sep 2022 05:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407208.649628; Thu, 15 Sep 2022 05:18:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhGi-0005tO-AN; Thu, 15 Sep 2022 05:18:32 +0000 Received: by outflank-mailman (input) for mailman id 407208; Thu, 15 Sep 2022 05:18:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhGg-0005tE-I9; Thu, 15 Sep 2022 05:18:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhGg-0006DN-E2; Thu, 15 Sep 2022 05:18:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhGf-000618-Rr; Thu, 15 Sep 2022 05:18:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYhGf-0001qe-Pg; Thu, 15 Sep 2022 05:18:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zBrTScbADs7RzPnXYJhyzEKrbnGmJTno8ZUTRZnOUEc=; b=CrGHaYBY4bWyBnGhzsCjM23Xi0 g9n0ubs5+UnXxwc6+uYzz4JiNInBVjtFCMwCUkGlHwqyS5Cnno7b5lRCJxOAGfebx/+RJolhb1J9/ 6EUikIRH1+/XcRbvoYee6MkPKncRfPf6oaul/baIU4MDO4+EOOyg1OEQfGsWjZB17y+M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173198: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-examine-bios:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start.2:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Thu, 15 Sep 2022 05:18:29 +0000 flight 173198 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173198/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-examine-bios 6 xen-install fail in 173180 pass in 173198 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173189 pass in 173198 test-amd64-i386-xl-qemuu-debianhvm-amd64 21 guest-start.2 fail in 173189 pass in 173198 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173180 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173189 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173180 like 172108 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 173180 like 172128 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173180 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173180 never pass test-armhf-armhf-xl-vhd 13 guest-start fail in 173189 like 172108 test-armhf-armhf-xl-credit1 14 guest-start fail in 173189 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173189 like 172128 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173189 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173189 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 42 days Failing since 172384 2022-08-11 11:13:58 Z 34 days 74 attempts Testing same since 173008 2022-09-05 15:47:43 Z 9 days 20 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 05:30:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 05:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407219.649639 (Exim 4.92) (envelope-from ) id 1oYhRt-0008Ci-MG; Thu, 15 Sep 2022 05:30:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407219.649639; Thu, 15 Sep 2022 05:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhRt-0008Bw-Hg; Thu, 15 Sep 2022 05:30:05 +0000 Received: by outflank-mailman (input) for mailman id 407219; Thu, 15 Sep 2022 05:30:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhRs-00084z-Ur; Thu, 15 Sep 2022 05:30:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhRs-0006Om-OK; Thu, 15 Sep 2022 05:30:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhRs-0006nG-DY; Thu, 15 Sep 2022 05:30:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYhRs-0001qR-D2; Thu, 15 Sep 2022 05:30:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MrxTu1i5RZnSk/xpgGWT/vfCHOkj9eMlM5pM5p1waoU=; b=GcQi+HjBU6iKZyBiFxTlPnqpNp smkaSTI4h8lV7rlT36TJ0aF0lHDR9tC3lhw1gZtjC4YwrJ0B/eUjeCvOMdViIYdmD043wj6v8axwe cDnJirV4bHxp6pG4ILs6ZwBNy5oCGNNCLr+LBW7d8ufquC+l6Qna3O8IDxzHWmN3Xq+8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173197: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c From: osstest service owner Date: Thu, 15 Sep 2022 05:30:04 +0000 flight 173197 xen-unstable real [real] flight 173204 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173197/ http://logs.test-lab.xenproject.org/osstest/logs/173204/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail pass in 173204-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 173184 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173184 build-i386-libvirt 6 libvirt-build fail like 173184 build-arm64-libvirt 6 libvirt-build fail like 173184 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173184 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173184 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173184 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173184 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173184 build-armhf-libvirt 6 libvirt-build fail like 173184 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173184 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173184 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173184 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173184 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 942ac5fc15ecc2f7ef1d9331c76d89d2cef10e5c Last test of basis 173184 2022-09-14 01:53:31 Z 1 days Testing same since 173197 2022-09-14 18:08:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Smith jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 942ac5fc15..3007efadf7 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 -> master From xen-devel-bounces@lists.xenproject.org Thu Sep 15 05:34:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 05:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407229.649654 (Exim 4.92) (envelope-from ) id 1oYhWG-0000Wh-9A; Thu, 15 Sep 2022 05:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407229.649654; Thu, 15 Sep 2022 05:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhWG-0000Wa-6J; Thu, 15 Sep 2022 05:34:36 +0000 Received: by outflank-mailman (input) for mailman id 407229; Thu, 15 Sep 2022 05:34:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhWF-0000WQ-FU; Thu, 15 Sep 2022 05:34:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhWF-0006TJ-Ej; Thu, 15 Sep 2022 05:34:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYhWE-00078j-Rh; Thu, 15 Sep 2022 05:34:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYhWE-0004yn-R8; Thu, 15 Sep 2022 05:34:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z7AcmOVgvugMOQlBpBYTggkvyXfkEkW9CdPowxewlYg=; b=Y9tvBcyyJqJPyHNEe0xWAPoG6T 8fuhLtf8g5wQFFrJABnZN7bOlkBWEEIzLyDyP0J4MLK5FseBIE4Mjk8ofvxuWzigz6rT0R9v1oun3 +qeOqJ44vOJ+pf5ueBTj6M40+f2YwNzxYHE48JQymKdV/0eLu52v2PTKIMt2sdSR3SJg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173202: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=838c730fe61578847823da1b815e4c9c5ee1bed4 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 05:34:34 +0000 flight 173202 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173202/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 838c730fe61578847823da1b815e4c9c5ee1bed4 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 41 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 311 attempts Testing same since 173186 2022-09-14 04:09:03 Z 1 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2507 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 06:42:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 06:42:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407238.649665 (Exim 4.92) (envelope-from ) id 1oYiZf-0007tw-27; Thu, 15 Sep 2022 06:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407238.649665; Thu, 15 Sep 2022 06:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYiZe-0007tp-VZ; Thu, 15 Sep 2022 06:42:10 +0000 Received: by outflank-mailman (input) for mailman id 407238; Thu, 15 Sep 2022 06:42:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYiZd-0007tj-S3 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 06:42:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8494adfc-34c1-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 08:42:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D6D433A2F; Thu, 15 Sep 2022 06:42:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB2B4139C8; Thu, 15 Sep 2022 06:42:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AKAKND7JImM0TwAAMHmgww (envelope-from ); Thu, 15 Sep 2022 06:42:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8494adfc-34c1-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663224127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3JmMwmLBDnkQ/gcVGLee+wpTgqcAwml++vmuBq3SbLU=; b=XJnrKUMqDmLHaZt88Zy7UYg+2RKfxPTXIRdgRJ35bQsMZIhfOvkeWQxxvVYZ/eChH3TFeO wOM5/Dqmb3wrPsC0nn5pwCSU5yj8V7FqpEeTb7xxjGmro0oku9tebw5bkdx9gBxLAt3MTs iQ0u+8s5IxyR+S0L8NpA/PnzIHEeeSY= Message-ID: Date: Thu, 15 Sep 2022 08:42:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Stefano Stabellini , Jan Beulich Cc: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> From: Juergen Gross Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------biiJqnzPU0CXD6IblapDZIG4" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------biiJqnzPU0CXD6IblapDZIG4 Content-Type: multipart/mixed; boundary="------------0jp0HFcCgn7FobYyXJ0iQLnN"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , Jan Beulich Cc: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" Message-ID: Subject: Re: Linux pin_user_pages_fast fails on Xen References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> In-Reply-To: --------------0jp0HFcCgn7FobYyXJ0iQLnN Content-Type: multipart/mixed; boundary="------------9HddmWv73H5VvPv3wXJmBu6Z" --------------9HddmWv73H5VvPv3wXJmBu6Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDkuMjIgMDM6MTgsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gV2Vk LCAxNCBTZXAgMjAyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAxNC4wOS4yMDIyIDAx OjMxLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+Pj4gVGhlIHByb2JsZW0gaXMgdGhh dCBkcml2ZXJzL3hlbi9wcml2Y21kLmM6cHJpdmNtZF9tbWFwIHNldHMgVk1fSU8gfA0KPj4+ IFZNX1BGTk1BUCwgYW5kIGVpdGhlciBmbGFnIHdvdWxkIGNhdXNlIGNoZWNrX3ZtYV9mbGFn cyB0byByZXR1cm4NCj4+PiAtRUZBVUxULg0KPj4+DQo+Pj4gRG8geW91IGtub3cgaWYgaXQg d29ya3MgaWYgeW91IHJlbW92ZSBWTV9JTyB8IFZNX1BGTk1BUCBmcm9tDQo+Pj4gcHJpdmNt ZF9tbWFwPw0KPj4NCj4+IE15IExpbnV4IE1NIGtub3dsZWRnZSBpcyBjZXJ0YWlubHkgcnVz dHksIGJ1dCBJIGRvbid0IHRoaW5rIHRoaXMgY2FuDQo+PiB3b3JrLCBhdCB0aGUgdmVyeSBs ZWFzdCBub3Qgd2l0aG91dCBmdXJ0aGVyIGNoYW5nZXMgZWxzZXdoZXJlLg0KPiANCj4gVGhl IGRlZmluaXRpb24gb2YgVk1fUEZOTUFQIGlzOg0KPiANCj4gICAgICBQYWdlLXJhbmdlcyBt YW5hZ2VkIHdpdGhvdXQgInN0cnVjdCBwYWdlIiwganVzdCBwdXJlIFBGTg0KPiANCj4gU28g aXQgbWFkZSBwZXJmZWN0IHNlbnNlIHRvIHVzZSBWTV9QRk5NQVAgYmFjayBpbiB0aGUgZGF5 IHdoZW4gd2Ugd2VyZQ0KPiB1c2luZyBhZGRyZXNzIHJhbmdlcyB3aXRob3V0ICJzdHJ1Y3Qg cGFnZSIgZm9yIGZvcmVpZ24gbWFwcGluZ3MuDQo+IA0KPiANCj4gSG93ZXZlciwgbm93YWRh eXMgTGludXggZHJpdmVycyB0eXBpY2FsbHkgY2FsbA0KPiB4ZW5fYWxsb2NfdW5wb3B1bGF0 ZWRfcGFnZXMgdG8gZ2V0IGxvY2FsIHBhZ2VzIHRvIGJlIHVzZWQgZm9yIGZvcmVpZ24NCj4g bWFwcGluZ3MuIHhlbl9hbGxvY191bnBvcHVsYXRlZF9wYWdlcyBzaG91bGQgd29yayBmb3Ig Ym90aCBQViBhbmQNCj4gYXV0b3RyYW5zbGF0ZWQgZ3Vlc3RzLiBTbyB0aGUgbG9jYWwgcGFn ZXMgc2hvdWxkIGhhdmUgYSByZWd1bGFyICJzdHJ1Y3QNCj4gcGFnZSIgYmFja2luZyB0aGVt Lg0KDQpJIGFncmVlIHRoYXQgYSBzdHJ1Y3QgcGFnZSBpcyBhc3NvY2lhdGVkIHdpdGggc3Vj aCBQRk5zLg0KDQpJJ20gbm90IHN1cmUgdGhlcmUgYXJlIG5vIG90aGVyIGltcGxpY2l0IGRl cGVuZGVuY2llcyBpbiBvdXIgZHJpdmVycyByZWx5aW5nDQpvbiBWTV9QRk5NQVAgYW5kL29y IFZNX0lPIGJlaW5nIHNldC4NCg0KVGhpcyB3b3VsZCBuZWVkIHJlYWxseSBpbnRlbnNpdmUg dGVzdGluZyBmb3IgdmVyaWZpY2F0aW9uLg0KDQo+IEkgbm90aWNlZCB0aGF0IHByaXZjbWQg Y2FsbHMNCj4gYWxsb2NfZW1wdHlfcGFnZXMtPnhlbl9hbGxvY191bnBvcHVsYXRlZF9wYWdl cyBvbmx5IGZvciBhdXRvdHJhbnNsYXRlZA0KPiBndWVzdHMuIERvIHlvdSBndXlzIHRoaW5r IGl0IGlzIGludGVudGlvbmFsPyBJbiB0aGVvcnksDQo+IHhlbl9hbGxvY191bnBvcHVsYXRl ZF9wYWdlcyBzaG91bGQgd29yayBmb3IgUFYgZ3Vlc3RzIHRvby4NCg0KSSBhZ3JlZSB0aGF0 IGl0IHNob3VsZCB3b3JrLCBidXQgaXQgaXNuJ3QgbmVlZGVkLg0KDQo+IEFmdGVyIHRoYXQs IHByaXZjbWQgY2FsbHMgeGVuX3JlbWFwX2RvbWFpbl9nZm5fYXJyYXksIHdoaWNoIGNhbGxz DQo+IHhlbl94bGF0ZV9yZW1hcF9nZm5fYXJyYXkgb3IgeGVuX3JlbWFwX3BmbiBkZXBlbmRp bmcgb24NCj4gUFYgb3IgYXV0b3RyYW5zbGF0ZWQuDQo+IA0KPiBCdXQgdGhlbiBJIGNhbiBz ZWUgdGhlIGZvbGxvd2luZyBhdCB0aGUgdG9wIG9mIHhsYXRlX3JlbWFwX2dmbl9hcnJheToN Cj4gDQo+IAkvKiBLZXB0IGhlcmUgZm9yIHRoZSBwdXJwb3NlIG9mIG1ha2luZyBzdXJlIGNv ZGUgZG9lc24ndCBicmVhaw0KPiAJICAgeDg2IFBWT1BTICovDQo+IAlCVUdfT04oISgodm1h LT52bV9mbGFncyAmIChWTV9QRk5NQVAgfCBWTV9JTykpID09IChWTV9QRk5NQVAgfCBWTV9J TykpKTsNCj4gDQo+IGFuZCBhIHNpbWlsYXIgb25lIGluIGFyY2gveDg2L3hlbi9tbXVfcHYu Yzp4ZW5fcmVtYXBfcGZuOg0KPiANCj4gCUJVR19PTighKCh2bWEtPnZtX2ZsYWdzICYgKFZN X1BGTk1BUCB8IFZNX0lPKSkgPT0gKFZNX1BGTk1BUCB8IFZNX0lPKSkpOw0KPiANCj4gDQo+ IEdpdmVuIHRoYXQgdGhlIHBhZ2VzIHBhc3NlZCB0byB4ZW5feGxhdGVfcmVtYXBfZ2ZuX2Fy cmF5IGFuZA0KPiB4ZW5fcmVtYXBfcGZuIGNvdWxkIGhhdmUgYmVlbiBhbGxvY2F0ZWQgd2l0 aA0KPiB4ZW5fYWxsb2NfdW5wb3B1bGF0ZWRfcGFnZXMsIHdoeSB0aGUgQlVHX09OPw0KPiAN Cj4gSXMgdGhpcyBqdXN0IGxlZ2FjeT8gSW4gdGhlIHNlbnNlIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb3VsZCB3b3JrPw0KPiANCj4gLSBwcml2Y21kIGNhbGxzIHhlbl9hbGxvY191bnBvcHVs YXRlZF9wYWdlcyBmb3IgYm90aCBQViAmIGF1dG90cmFuc2xhdGVkDQoNClRoaXMgd291bGQg YWRkIHNvbWUgcGVyZm9ybWFuY2UgcGVuYWx0eSBmb3IgUFYgY29tcGFyZWQgdG8gdG9kYXku DQoNCj4gLSBubyBzZXR0aW5nIFZNX1BGTk1BUCB8IFZNX0lPDQoNClRoaXMgd291bGQgbmVl ZCBzb21lIHZlcnkgdGhvcm91Z2ggdGVzdGluZyBmb3Igbm90IGJyZWFraW5nIGFueSBQViBk ZXZpY2UuDQpUaGVyZSBhcmUgZXZlbiBtb3JlIGltcGxpY2F0aW9ucywgYXMgZS5nLiB0aGUg a2VybmVsJ3MgbWVtb3J5IG1hbmFnZW1lbnQNCm1pZ2h0IGludGVyZmVyZSBpbiBleHRyZW1l IHNpdHVhdGlvbnMgbGlrZSBtZW1vcnkgc2hvcnRhZ2Ugb3IgcGFnZSBtaWdyYXRpb24NCndp dGggcGFnZXMgbm90IGhhdmluZyBzZXQgdGhlIGZsYWdzIChJIG1pZ2h0IGJlIHdyb25nIGhl cmUsIGJ1dCBiZXR0ZXIgc2FmZQ0KdGhhbiBzb3JyeSkuDQoNCj4gLSBubyBCVUdfT04gaW4g eGxhdGVfcmVtYXBfZ2ZuX2FycmF5DQo+IC0gbm8gQlVHX09OIGluIHhlbl9yZW1hcF9wZm4N Cg0KVGhvc2UgYXJlIHJhdGhlciBlYXN5LCBhcyBJJ20gbm90IGF3YXJlIG9mIHRob3NlIEJV R19PTigpcyBoYXZpbmcgdHJpZ2dlcmVkDQppbiB0aGUgbGFzdCBmZXcgeWVhcnMuDQoNCg0K SnVlcmdlbg0K --------------9HddmWv73H5VvPv3wXJmBu6Z Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------9HddmWv73H5VvPv3wXJmBu6Z-- --------------0jp0HFcCgn7FobYyXJ0iQLnN-- --------------biiJqnzPU0CXD6IblapDZIG4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMiyT4FAwAAAAAACgkQsN6d1ii/Ey/V Gwf/XQAQc+AleQMto7T03CT++gQ9Z7n1wXutzSLQ3M9AWpH0wTrQjuM+AhjHvo/7+Y1QXl/6l9V2 9rrxP6HyjmeaGuGpKqLZto3OPu+fXy8VpgJXAa9vHHcxFasX8u/Il7zsawLxGvIVNcynFBBgPq1i kFjG3AGxapqkFiXtBwcGRbnU7eQRht0y7ZyOW38vZrX1OMUKcYHlb5YY8x4W+AnvKZZB5SE3tRoz IN5S+6kTAXoRY8432FRkSqaYlNbcsMPPBrJWC4JnW3uj9d+2v169ChVBp67FJQwt/dDrA7/iAuMS ogmsaCM/ewE3R8WJyQEfKKslkvPQzel+A2FpUw7Dzw== =hwKP -----END PGP SIGNATURE----- --------------biiJqnzPU0CXD6IblapDZIG4-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 07:23:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 07:23:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407247.649676 (Exim 4.92) (envelope-from ) id 1oYjD4-0003y9-6C; Thu, 15 Sep 2022 07:22:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407247.649676; Thu, 15 Sep 2022 07:22:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjD4-0003y2-3X; Thu, 15 Sep 2022 07:22:54 +0000 Received: by outflank-mailman (input) for mailman id 407247; Thu, 15 Sep 2022 07:22:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjD2-0003xw-Rx for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 07:22:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60063.outbound.protection.outlook.com [40.107.6.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34fc20c6-34c7-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 09:22:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8230.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14; Thu, 15 Sep 2022 07:22:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:22:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34fc20c6-34c7-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZbGBjBJHe+6Dle6kJCy4v5Snpbu3FNAnERZ6AFgPDbgbJfyQxY6Mt8FEBIapbSH5iVQYNh0fsRulM9og/DjyCYylwrku2L97l6ZIC+C8RQCowD6G60vpDeHF7F/souVsVU+VfyGL8OXdUQ1ZXTi9UuTz3Y91LViYTeMMlRw4wlqJ1C0SJ5QmbL45vbekuhK5JWSnEKInEX/7zTTXM/Xd5yzQ5cYRuf60iYBj7BZrBYK6jm7mQagqATTnaAJMqHK0CHNIPfFhEOCx1/zU656+rVtV7R6dpv8VHMvBS5ySeEqen1vi4FdR4KozHNGPOOOQf0TVFhAl7fpfdFDQnsIBgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0NMgwMZFryGjeLshoYixp5UtIBsvl6HipZhufTopacQ=; b=XVarDBTiWO7IxYA33Yw0eGk3IddqX7y1txT208l26VH76TLx78btsn6nxZdcz3Wr8+/eqRoeT+5wd5oGI7x4wzgx15OGQhTyKnkGkqhVEspnxl9a58tlwvVRQZFei67+yxyXcznrwiZfb/9PhPYsLlf9OPAW3pNQzWAIjE4UW5+IqsFjyf64RMmQDk6NGbJn4NzxCFOa4iVvD+RdMzCyDwt+5mSPI8jsp+sD5hGzCs+iiZpmxDRH9Q4AKwPQMVD78Ugjq74Uo2SeRM1TNT077m1ShkBNefPv5W1b1EPNGjMY5G/DuEY7OukP3fNV+V+8mYZqrqup8g8r2vlB1OOxmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0NMgwMZFryGjeLshoYixp5UtIBsvl6HipZhufTopacQ=; b=LL6gTk4J25N8zvzvR2d77jMRjdjP68l5arxmr60Fu/tTgXeLCmSfkUGes67IATAdQYIMgHjxCwg+Tt8CizLn00nc5qveARwLwPgWsyHWBoBTSj+wUk8SGkO8TauYfUwzm7u3fYtF1yhlzK1szGsseVk9jRxlKEqlqct14Heh3QlOkDF855UEvCkgP8AAXhGKCoeYaTAhj1Ut43+akmSZpM/g3SlvP4l683hLTKGSznkso2sI4coY6rk81xKjpinbCes4shJjmKX21VD2yWkR6tzglWnM8g3yvftUut0noxmjS2RExpMBKuA8lLaHRkDuoJrGTQabgKdpeTuYCEYzmA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 15 Sep 2022 09:22:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86emul: respect NSCB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8230:EE_ X-MS-Office365-Filtering-Correlation-Id: c3cf6b9d-f256-4e7c-924a-08da96eb182c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kGljZIqaL3PlL7yYSiwXucAveOcmUAZe44rltFmlSoCgAHCuU3ksobJ/wPCEy9kPdr8E5BmYNnabKu9ZYV656hsaFo8nxTOMFb+busCwliUBOulKaEhydcpBuhyfuqa2B03yOA9Hgh2JMM0WMUQFWeuukoHVMmnqKHNMQVO46IOp3t+ZD+H3OBRHUzfrdJXr33Su6RW7RARf0y4m+fl0YGKlJwI1ElYUqsWqAFkKWC5qeOl5TaHJRz6mxrIj3ONfhEgDFbymGQj1jSGj/X0Mk9ns9teNbg/pNoxxGmicxAIc6kHE5cvx27kPfv6yMt/KbJT3eyg17lsi+lPrvXlGt2sBdz9G++vNoZMFkaueqlY8iBieCr3P6Fr7ckbDi2Jz2DtBkO5SeCuj1g51nFjXr2NtrVJ38Aw0/3ynbhI7ytdXhYoLy8cKFkCeggd/u1l1ljV5B4ByqoGdulHDmplyfbs8af8CZobnAGGIBbNZ1fdm/q8+EtdqvqEuC/dfkwj9BNVjRi/CqaUX7exw6JEVL8Yx5J2AZrqA0qMn9muvZ9CaBADlF6xzJU32LrbQs9f2fRRHKST5oOYQb+ZJhoomPH5cuZJNMrflgD67gAI4dq1/g8OfpsJu2jX/mrKe0FgIvDUKea0Q44rq91ncLOThaPGE5d10k4it3vWjcj50rbLcXk4Q9ILIobpm1NNTrDMlT7Y3jTfdkRIiAL4mbogDLt3pqntFUS7PT2vAb5MwhDmK1pyUmJ0ewbaQ3SLtkr8wYD9DjJwOYhvGDb2Xqr59RxgRoOBuJNSwwymsSRk6Ed0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(366004)(39860400002)(451199015)(31686004)(4326008)(8676002)(66476007)(66556008)(66946007)(6916009)(4744005)(6506007)(54906003)(8936002)(2616005)(2906002)(5660300002)(186003)(83380400001)(36756003)(6512007)(38100700002)(41300700001)(6486002)(26005)(478600001)(316002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnlIZWZ0TFR3R2FHQjBiZnVVRzRPSEJ3bVFUaENYcmRMNVBjalNMSXlRdjRs?= =?utf-8?B?SER2UktibzhGUWdmazBIeFpzRmw5VmZiNmFjai93U0ttTEFYYy9FcUV4RW9T?= =?utf-8?B?U3NVYWsxUERTZ0VXZm1nRytLZWV0VUlLK3R4SmY1UWJZVlloUFNxYTY1OVBX?= =?utf-8?B?YU1aYlNLMzhMelhMaXJmSFRmM0RINGROaEN6RnVXeWgwT0xYMEZCUVZpZmk4?= =?utf-8?B?dW9IdkdHcFVqaDhMUTlIOEhIN3pPM1VtdWwyd3habjRUd3l2ZDN3c2xrMVJM?= =?utf-8?B?dWk0VzNvbWdDS255djNMNG9ZeTRCQXZwRzUrcFRla1RxQktPN3ZvcXlpRFdk?= =?utf-8?B?N3Mya1BQVTBZV0UwaTVtVjdUb3VuNmhLWHRUNUNHa1orMjlvaVFHd2t0NDJv?= =?utf-8?B?UUJPaUxsUTA5OTFvY2dYM3NMZjNQMFZZMkJHSUE4SDhiYUpZNk4xZHEvZFBX?= =?utf-8?B?MnorY1FXTmVzS0FDN1AxaDJraXVycnhFVDF0Sm1sRzVjbm94d292YWxEWHNN?= =?utf-8?B?Ri9QcCtJQlVnT0JMWkxEczRadnlFVkdpWHFtSTdYanBGdTYrMHFyU0YyMFA1?= =?utf-8?B?RTE3emVqYmcvUHFEMmRtZVZ1azZNbTVSNUg5V08rekUrTENCUWY5RHJYR2Rh?= =?utf-8?B?RlFZamk4WTdwbjFsSmJNcjdBeGtsOTVBMG9ZWGFOZjJLUHZ5YkxuT0NRU3Rs?= =?utf-8?B?Ujk4YURDUjRnaTVMM2pWWmlEdFMrTTFQRE4zOWpLZThyZ0pCYm9HcHZ1KzU1?= =?utf-8?B?TE44dUpxakVNMzdUalFoVTJkOFU3UHgvRE9SaWswb2wxWlc3aVc2dEFBYjBZ?= =?utf-8?B?K0tVT1FwaExJWW5xS2wxa0Urc1ZINXBLZWpLaVpDYWhhUXcyU3czMHlUZ0Q3?= =?utf-8?B?aXozU3gvNjZwLy9oYlVFdlRxR3pHVC85MVoza2tRVVlrNXY0aGsxdENFL1ls?= =?utf-8?B?ZTFLamROZnZ5L1RmdWxCbzI3U1FLcUh1RDhReGZJS1F6YUFhRkE0MTJId2hH?= =?utf-8?B?RFF4UlZRRkk1UDh5NmdWVlpWZkdleHlqQWpINFZiU3pOeXppSDNRb2RTZERQ?= =?utf-8?B?TWNndXFCQ0xYQ3N5TEw2K0V0Z1pLQjhJR0pNSGQyQmZCdGhKd05icWlveUhD?= =?utf-8?B?ZlZSYmlOUUwybXRSVjE0TlQwQzFCVlVnc2ZoSHlvYVFJQnBlWXJHcUFnWnBL?= =?utf-8?B?SjVBR0I1RFVSNU9vWVAySlp0ZVBLRWJhb1dMc1FFbFBkMXFJZGtHRjQ3bzNj?= =?utf-8?B?R3hzNUg4eDZTcVJSN2kwOUtvYUFhbjg0QzJ6QmRZTktDdTRDWHl4aEtqUzZt?= =?utf-8?B?SlNVSDV3ZmRvNlhTeHpwQk11SDRhamxaaGNJZFI4NVRBZ0Ftbk5NVzlzOEVQ?= =?utf-8?B?aXBUTDRBSXcxdkY0NE5ucTZCQmhHOVNUMml1YlAvWFlkZ0w3RCtJZlhyem9X?= =?utf-8?B?a2E5cFpVQUU2dWpWNUNmaGZPUE1mK2pOeEg0a3BDUzNwbW1ueGR2bkZZMFVC?= =?utf-8?B?YTFWTzlQeVVtQkIzSVhBSWRPMUpYNWJ6V3ROSm9vdHRsMkhvckFVK1IwdWRG?= =?utf-8?B?MkRONzFDZWpSd2xreXpjbEM5djg2N1hDaDFTNjd3UTlqOHorajRJL2UrNW5H?= =?utf-8?B?T1U2UnRuRzErbk5qNUVrWXlhOEtRaDFGZ3cxc3Fmdlcwb3VyYWxEZGM2cUNm?= =?utf-8?B?TmN1a1NKNHJNL3pvdHBkRUhXVTh3b3MzS0VsVmptbGJGSVcvV2ZUYzNEVTRH?= =?utf-8?B?TFZUMGpkMGRtQW1OWmliN0c4TWNBRGFJQ0JGMzVGRms5VHhxeEt6bmVsN0hO?= =?utf-8?B?SFNXa1VQT0k4SXVJUWZPUGEydXo0bFVZdmU0TW5lcUhYY2tzUkhxMXBBaW9C?= =?utf-8?B?RWE4aDRFaTFxc3BNSFk1UGc1REJjNmhFTU1YWlZDbFd3S3d4bkpvNGxyU0o5?= =?utf-8?B?L0x0Z0hpZHlSMTYxelZBWDRQRkdCWkVTSWh5dlM3dlpaeGVlSW8wdzdodi9x?= =?utf-8?B?N0dVa3liWkRqUXIrK2Q3N1Q4dnNlNVR0ck1YcDRTMHM5Rmp3ajlDRm5LU3d5?= =?utf-8?B?MDFTMTVvalVtMHNGOUtKMzloclFpbXpGK1FPUVFZUm1hT0tNaVN1cDFxdU1s?= =?utf-8?Q?tUxY5iI0pFGcU+GAA79OpWPY3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3cf6b9d-f256-4e7c-924a-08da96eb182c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 07:22:49.5276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lM1DSEzV+VFDNHtdkgF39hEmE8Db+KzjfYU1bfURlz3SoiHYZBi3RPg2w2ri5qdT398Z5ImrmlGeXZwhjLbfaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8230 protmode_load_seg() would better adhere to that "feature" of clearing base (and limit) during NULL selector loads. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1970,6 +1970,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_tbm() (ctxt->cpuid->extd.tbm) #define vcpu_has_clzero() (ctxt->cpuid->extd.clzero) #define vcpu_has_wbnoinvd() (ctxt->cpuid->extd.wbnoinvd) +#define vcpu_has_nscb() (ctxt->cpuid->extd.nscb) #define vcpu_has_bmi1() (ctxt->cpuid->feat.bmi1) #define vcpu_has_hle() (ctxt->cpuid->feat.hle) @@ -2102,7 +2103,7 @@ protmode_load_seg( case x86_seg_tr: goto raise_exn; } - if ( !_amd_like(cp) || !ops->read_segment || + if ( !_amd_like(cp) || vcpu_has_nscb() || !ops->read_segment || ops->read_segment(seg, sreg, ctxt) != X86EMUL_OKAY ) memset(sreg, 0, sizeof(*sreg)); else From xen-devel-bounces@lists.xenproject.org Thu Sep 15 07:48:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 07:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407253.649686 (Exim 4.92) (envelope-from ) id 1oYjbu-0006ZM-7X; Thu, 15 Sep 2022 07:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407253.649686; Thu, 15 Sep 2022 07:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjbu-0006ZF-4x; Thu, 15 Sep 2022 07:48:34 +0000 Received: by outflank-mailman (input) for mailman id 407253; Thu, 15 Sep 2022 07:48:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjbs-0006Z9-NP for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 07:48:32 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00049.outbound.protection.outlook.com [40.107.0.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca94ca15-34ca-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 09:48:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7707.eurprd04.prod.outlook.com (2603:10a6:10:1f4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 07:48:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:48:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca94ca15-34ca-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EkqPUfa7tYXH6ca374tGRJPocE+WZifoxtT8E21XyHouVX4waYy9DQc1XyF6sVb2o9+DGGqiDK6XGudOLJTfIcIwhHOxZNxAcLTYeNQX9MyD6TKqe25/L9NzkuQy63YtH1bJhsjHvcFr1B2AzT1vbiPLaCQnWiPB6QGqkhD+2L+rSDj/ZUooiFq8NNyfLTM0F/RN1si2vrfVcYpxF7gpsUyc8hR22JZHsq9pYt7GRDUWZ8sksbM+YCD/qM1PuosTI+KB8Jr98I2IECvNRFM0Cl6nQjfw+vzAeFDypRYI+NAj6mA7MPfcpG8dftnHXD8y06R04MaxxJRzYEXtwQUfrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HCcOU/8pjM8fzUnYoWDwMgknAeFVxFT+TvEvWJ7qya8=; b=VvznKBxyD9Anqvy0BQUhLUvIp/89ZFFbaAbpJnfY+qKnhgCy188FxPuEPOBIj3TATwHqYK7+ADMlxK1VEm3z/4Ea97Q7e06Yy2Yd7RXKGfHrkFsQ+BwM0/U0PaJuj5ECg7myY8+Sq6jjsYqrJuLTCRquLn2x7m56JW/IuoKqCuRGF3JFCGsFzb7qaHY+hQRuWRykij6uxzWWr0eS945c2Nd2iv3MP4CSbCOnxiHur0WgWTWZwxCe24GN8PWxET5lVyXZrVcL4jGUM017Niyb86vMAVXkpJQFqbSiu2zcHiqQ0JmXr0ihlx7Fb4M5nxNcnL2zj8PQHUzRjJivoNCdOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HCcOU/8pjM8fzUnYoWDwMgknAeFVxFT+TvEvWJ7qya8=; b=HfJ59U0OneivDCycIfquYEuBnhxCGrARKyVwEHWS2YuyNcS7pCjcm3k9nQ+0iWqW5x+ZMitBLIH0gqePj/tCdYX1kMV/VJdUe6MYp9AFSXGfRfc8RGd1YC1YXa6PZ1xM+aOxfPMcV39WUAS533nQrSc7f76inRxctwh/885S2p4Gky/6siqYxS+btJQ0ZEyEt5CpcySX3ZcfzUTXVJNYdS0HQWjVyB31ogCUBJlkZ/Uc4uNzo1mEmPlReS/6F6YZF/7P87N5p0LF3kmwo8cKO4+vTdedUJAGJGZHcCY8Ffdi1tGuQ3qyeZ6XEDO+fj07NoPnfSBYHlAi5B9HD4iDgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 15 Sep 2022 09:48:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Linux pin_user_pages_fast fails on Xen Content-Language: en-US To: Stefano Stabellini Cc: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" , "jgross@suse.com" References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7707:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b598d12-eb7c-4a65-74ff-08da96eea8ec X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QkEG2+5h7AGNM8ogYGcawK0LnlJFsof4jQ6XukKb96mZGbsQb6pU9v9ZBEu5OLo4EMmeHMD+D8nTWdGKk12fAQ3YkTnpMAsyEbGnmA7dmHtuQuw/papk2VTIBoIqJea4b8XXh+75ZCGi7b/uDZ1dgjk1gujJmRBkoIhlxM0klDVjz/B7EkwUsSzKK+Lg6hZ5XSVnff6lmGEoF7OBvFf4yz4+dfpP/XYLanw0vdiXnnIqDEfwiLoby5chtgDkqo0J4ZZs35pH1ucn4K/B1E+rrr/gBwFbKEjCof1ZDVQe/mwbDSYfA4sMN2uEijrFkb9MOrD9CxCjjFhrYC1ZcEtIOZHa6UpY8+LKulZesrUtbjJ3XBJTtpu6aOa1fkjSJCEvEGU+hC5VpaldGL18FvqcGCm9sWXdnn796Ynn7jYCWDbhYx3baRiGNkmeWvCLIGxrZ2LI5RqMBhV1GRGDQyXDEpSGeiNeidK926hxTNRDyzmieGQN42og65fwXM9ySlkT/Bs6RghWUta9ZBteemubP5Xo1O+H5J228uYOWEXFhNxCsEBWM/dG5s5A2d2ealqf9Lk6mX+ZV95xjh2IrhfZL2DAMuEmUvwS9lwo8VvHwwSKPfl3r8QVniNH+tiDKqP3+Hu957VDAiIIyO72nyEgNYrljqd8rKv4FkWCURlNlRFhvXDNexu0Ii1FZ9xVN1Xp79DUx7QOUfc4K1uriikQsPnJ3Fm06nDVc2vHFntlEv0KZhT3Mwt/Vj9mZEdvcLRA6QmyoHyU3eT8kag9syhhzbHOnfycYPFUG9/tnxTOblc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(366004)(376002)(396003)(346002)(451199015)(26005)(6666004)(107886003)(6512007)(6506007)(53546011)(41300700001)(31686004)(36756003)(38100700002)(8676002)(6916009)(66476007)(54906003)(4326008)(66556008)(66946007)(86362001)(31696002)(2616005)(478600001)(186003)(6486002)(316002)(8936002)(5660300002)(2906002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmdTL1NJd1I0bWJBb2h5ZUorSXJYSkNSN0Y3OFlWckZ5amRnT09YdUhTV0VR?= =?utf-8?B?SzVoaVN2cUpJb1RtTG5QcXdhcUtmc2xnMnk0aGdpMktzWkg5blFaTTN1YkZv?= =?utf-8?B?SnJ4M2pnK0I0K2czWURwSUZydE53a0J5Nnd2V0ZYTUZybi9yRkRVdFNhb29C?= =?utf-8?B?a1pEL0VVVDh4R2pmNVY0bU1qUUJPd3BtZVhMZXBNbUkrcnhJVnlNKzlNL3RS?= =?utf-8?B?L2hRbUk2SDJxdldHUW9yUGh0L1RvMmRLWWp1d3cwOGNuTzQ2N1JRci9sT3BE?= =?utf-8?B?Y3ZuK0pySk1rUXdla3l1N09nS3pPZ0U0NDV2SmUwNkFBRHV1eDg2QitqQjhm?= =?utf-8?B?TW1YcjVINjMvK25UUHlLa2piQktKRitVaXNtSS9NL1RDckJtMVRETjgzWGhU?= =?utf-8?B?STdVbFpYUTFiSXdweWxSRE1DYm15clNxNGlyVG03czlZbkd0blN5WlU5RXRZ?= =?utf-8?B?c0c5NUh4UTh4S3pJSnlxa2QrTW5UVmdpUVh6enZ5L0Z1di9wbnYrUVVtUXVq?= =?utf-8?B?N1lWOXBhRys4V0w5MSt4Y3NrQlVRRUNjNTZWMEc3UTNDWFhrYStKZ3Z1OGlo?= =?utf-8?B?YTFWeFRmWTZPOXJvWmIvYnh5MHlKa0ZiSk1ZWC9WVHZwM3JpMUYrbmVrWGtu?= =?utf-8?B?M28wcVZ3ZmtwZXI3czYxNTk5VU5yaytnRHNRVS9IV1ZnVTZvRUczS0dCQURH?= =?utf-8?B?YUZkcU5HMWVnaWNyTnpkY1M3TitLQ1ZSS0plSW9iMHY5Y2JITDV2aG9EUjdz?= =?utf-8?B?Y1FuUGs0ZHc1SERIaHR3VC85L3EreE55Wk03UnlZNnlIdmtsM2lNbzlyQWUy?= =?utf-8?B?SUhiWUJlUmV1dlJsa2dzTWo3VHg1V3BRUUtzMmxPVGJVVW1uaWltYTR1NmYy?= =?utf-8?B?Qy81Uk81VHhWUE1MRmp0aVBVMi9IV21RK0Uwa2NSMytkaWtUeUN2WFgxQTFN?= =?utf-8?B?dHJocVJ4aXBBM09vUzM0WVp1ZkIwWEM5Qi85eW9mNFdPR21TNDdVVDE3Y2hZ?= =?utf-8?B?WjgvZ3JXYUk2aVpPb1ZLVnQySEZ0V1h6QkxQTG1CWTFTa3pZVllJZHBZTVRE?= =?utf-8?B?OGwzU2lQOVR6NGpMWGJCem15WDVKYWlQZ2NDZmk3K3Y2MmpabE1xQVhLcGUx?= =?utf-8?B?OTdXRFlhczU3aWZ3WG5scVVVa2NSZWpxSmtxSlZKVExDVVd2WmdqbGZaVTNm?= =?utf-8?B?Um1KckJQNVVZTWU1RW8ycTY1eEZDLy9CTFBpNUpPZzZWRCtJTVMxUWpjd2Vw?= =?utf-8?B?ZXVza29CUTBnUFFJSTZpY0RIMTEwRkdJdGlFdHoyNm1rTmpaa2ZGVyt1ODFh?= =?utf-8?B?Z3BnT1NUd0hlNDlvNmNNRXRUanF1U0hBSndkUVlVaDFTU2JXZkFTb3IwaCtO?= =?utf-8?B?N2hCOVRLeTdyOXh6R1U5UHlwWlFiMG1lWUREb2RMRTZUYUd2dWFpcitWd1pD?= =?utf-8?B?Q1NIcjNYS1o5aWZ1cTAwWVRCQUU2YjFtZzVwZkg3b2tjaEJXT2MzU0VBeFVH?= =?utf-8?B?QXRkemdOZk9vLy9LVVJlK0hnTDJxTFVoZGt1ZlBBYm9uS0ZJdUJoelhDUGI5?= =?utf-8?B?aTNndXJXT29hVEhReWlvVXNGcmN4TWEwUGhpbDVvOXZaR2lZR1I2NXhBSGhM?= =?utf-8?B?TXB5aENqZWFpWHBCUDVpMGt6a1dROUpPb0QxT1dIeXQ5V1ZCbUw4S241L0Qr?= =?utf-8?B?clN6ZTdYMnpWMXdLUjJBZ3BINmN6ZzRsS0hKQUQ2K3prd1VZbkIxcXNPN1dB?= =?utf-8?B?U1M5aHJoSGM1M1NKMzhmWkp6dXNrUXA2VCtTY0t4OGlvT1pZckhmb2lWSDhi?= =?utf-8?B?NWhyWXNsOXQ1UHc4ZFJ2Rkl3U0ExWGQzU3VZZXV6WDNOLy9jMEM1Rkx3Y0Ny?= =?utf-8?B?YXFRL09ocnp0bk1SVWVxeHlwQ1Nhc3Z6T1JGZ2laQkVqT0dwNTB3bk9RRVBT?= =?utf-8?B?S3pMVjdYN2pKQ2JQL1d0dStSQVpRNzdwUkhCLzBub0FiMGRuZGJyWDFRWU9m?= =?utf-8?B?NnFla1JKRkErZW1va2UyOGxMTHVnYlhxV2FwcjZ1QlBoSm1jOVlPRmY3TjEy?= =?utf-8?B?amErbWxOa3Q3dzF1aXA3cUkwcGx4aG1YOUdrS3N3RytieTlPdFFoYzU4Tjcy?= =?utf-8?Q?UDLAgOKSURE0elMfxbD7yPRZt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b598d12-eb7c-4a65-74ff-08da96eea8ec X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 07:48:20.8360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dOt16lNTMTyQxMLpM9DPIp1etsVHlgWMQiuE/pqx9KdJifLI6VwN0NbWmL5VCl1oFN227Y9kp7M4tz24+F0wng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7707 On 15.09.2022 03:18, Stefano Stabellini wrote: > On Wed, 14 Sep 2022, Jan Beulich wrote: >> I did look some at the specific use by the TEE subsystem, and it looks >> to me as if their "shared memory" machinery simply isn't meant to be >> used with non-local memory. > > Any more info? I guess that's not a question to me, but to the subsystem maintainer(s)? For everything else in your response I think Jürgen has addressed things sufficiently. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 07:56:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 07:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407260.649698 (Exim 4.92) (envelope-from ) id 1oYjjH-00085u-WA; Thu, 15 Sep 2022 07:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407260.649698; Thu, 15 Sep 2022 07:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjjH-00085n-TT; Thu, 15 Sep 2022 07:56:11 +0000 Received: by outflank-mailman (input) for mailman id 407260; Thu, 15 Sep 2022 07:56:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjjG-00085h-IF for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 07:56:10 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2066.outbound.protection.outlook.com [40.107.105.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d684f0a4-34cb-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 09:56:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9228.eurprd04.prod.outlook.com (2603:10a6:10:353::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 07:55:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:55:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d684f0a4-34cb-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4EJHfA1KUy/+1Oyj6xt+G0M0wyn/+2XYgkbctw0piCKSxMPDdrqIaG2kNZ7NuRnu4RcFSxOtDhPYXH15cCCRmgPLtX12zHsNcuBmRCWQ9A2fjq+Dnpy/gm+AyG28qVCPhINSlYAOT/GkZSlfb0rRDOnC2PdRgIiwMeGn5HSQDeasBbwh8TYWmzVQu5gX6e8huP5J6q1iGeTshL/iJc/DL9GN0FuDDzoSFfrbegAF7arK+2gY6rMfxzaOvlAb8t/2kbjYGxsVIbXq8tI+G9/7rdbgibRR0WShk4NU3GU+J6BTBXi7OPBTPBd3GGOIWi7094cmXtb20xzFU/qbshs1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z5ohhaQ2MfmDZ7UaICgzFDSFl5HclAU3EVjSzGrBo5A=; b=kWX/KWNk7ItVuc5B3wLlGb2Q+1cC7mB13jZ6zhVTHiPhHOS0aXfmFdSYwuPKaZLN9F+6Gn51SDVMXk0um07VojnXlDoRe0wME6Xr6MFenyUQB9+BZ9Za9rQ7ad4wL/jjF7cJFL33V4G7vokiUxaM5vT+OLNPv2vBbW7uSkVDUEqovjKyoPW3LepWqXS3pv5CaHDt4FtqU8jbyKc3VHauzK9tBvYsYHj8UQGR6+CI25ForYvY1VTn/2yVLkWY2LTbEmLT4CrNfvZXou3s9BwxGVN4crST9/9U9x01fvfI67O4W2hwAoY/Hffx1kx67oYOxbhUaw91amPuzb2XZ7ZDig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z5ohhaQ2MfmDZ7UaICgzFDSFl5HclAU3EVjSzGrBo5A=; b=2bhatioP1hka5e/nZELrTRCoRr1SK0JLviAPi3AvAWpNKXUmzIJFLTaSJgSVysr2foK2bdZp6Gprlw3mjFHuH1SRNYJHdiqstbSprkGBJ5MglQiM5wAAaYLusUQ8GhMS5O0X8WHikKkODVBwyzVLpc3Vd+z0UN3mKWNooLNFNA4SYbodix1uzojeut0PAU4AXMRJgPkLWEZnlB7kRu+yje3mKk7IT8ph5XM5y5AYDzCf/aLm/Am5lN+u34uA7/ZV3h2q3dKeWluHYFT9jtYVP5C/pn5rEqGD1ZWcWUNr6e1gJYZ1DaJ+EtgHV0HNRuyqBoktrR042sjaECjWcF9BIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> Date: Thu, 15 Sep 2022 09:55:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Console output stops on dbgp=xhci Content-Language: en-US To: Tamas K Lengyel Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0470.eurprd06.prod.outlook.com (2603:10a6:20b:49a::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9228:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b90ab60-713a-4178-e51c-08da96efb9c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O5ozZIB6sTTeGiWwhL/eBQC3rIC0UWuC8rU12I2p4QiauuZDsKNlTyhEiV/qeGltqDGYHW0zYu5Lbyx2R/m9yU0SMRDdfp9pu7nrfksprHubGpnnTc7wwOswNcNx7nkjg0nW3dLl0PBdOLb9oczuUqwNN9lexjpIEpLhmuCCXZuRUmvFd1ABiJ1QPNY4w6DshzxAdm+eAtBrkdJ+WIZTV7P6YoeTeJ4AXySxziRCNQ912d9+Ywe3NcELH6Gv77kOq1EZmFjuAorgMbfpCvdv5z7UTPo2JjHSV6g5sUBR506Cu/AHRfSh11ijnidd3yTGILbmqfVmhMluJGPFpwqBj1ebsX0abiG0+YkxTrVzggSy4ZfqRQ4DONmD6Jy0BEUiDe6ol4pno9PX50mbwk8Y+A8bbrZ5J53t4V4o+3NxzmUgRI60/PFBkwn4/NXZyl3xeZq3KG15aZubICW5s8zfOK5xPrCaPenzpfzZuw5UZnOhqpyEC9iqwINahbigqZ7GKER29YpyQWcnWw0qvJce84mjupr4dsyn/Ry7B6Ly3lSenA1VUwNtQYJUyFGYGuIkvaQqAMqHisdG0xK896C+ykip343Ha4Rvkvg01bJ+vJ1MOnsC8UBunUZJqtvV1cWwFqz4eYr/EWXqfaw64J/gvbn3yWOcGbB/7Am7GLOO6iZn8gp37TEcuNxfRDskfoyJ1VXCKRdgUVIDvAbqvsI3+04tJxfIG98PhS0yK6wQHxE+6Obw87vjYTYjIthulrtk3wOTR1ebYkYexHQZRuJzkFbPbzcTkXjaMpWB1ao4euk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(366004)(39860400002)(451199015)(38100700002)(316002)(66476007)(66946007)(4326008)(6916009)(31696002)(54906003)(31686004)(86362001)(66556008)(41300700001)(83380400001)(2616005)(26005)(53546011)(6512007)(6506007)(6486002)(8936002)(478600001)(186003)(8676002)(2906002)(5660300002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0k3SlNrd0VCUE1Yd3NHdndhMHpoNHQrc1E5MFRYWkx6T2pmR2UrZlNEOUdH?= =?utf-8?B?dFRQY0tySU8rU1hXazFPazJhTjlQbDA5MEE1RjVkRm1KTzZFcjE4M2p1eVA4?= =?utf-8?B?ZXFvbk9BMUFDNlZJcC9LQkx4Y25VUjd0eGd6ZUd6N2k3TnNQalZ6NGV1WDRa?= =?utf-8?B?cVZ6R0VhNWpOanVhSTdXWm1HZjh1Q1VLV3gvTWxSazFRaktNWmNwbzRRazJJ?= =?utf-8?B?QzJrSUtieWtqNUhrdGUrb1RIR0xuaHo2dnRlNmMxWHdtNGVwd0w1dHJRclh4?= =?utf-8?B?TkJhc1lOb2JONHlnQkRCQVNNblAzd0xqd1dhd3ZDUFQvWlE5SGE0N1NOQTZS?= =?utf-8?B?bGxibWVCcE5aK20wYnZJWFhaYkRLZ1paNE1vUjdjVVlkZW1keUZ5cnVUUDIw?= =?utf-8?B?MG1ZUE42dDRZbnFTQUk1c3RlcVpyY2owQ2FUckcxcThyd3BTZTVQWk96Vjdx?= =?utf-8?B?RDJFbHo4Z3RXVzE5UUpIMDJaa0RVSXR5WWRXbHE2a1pmQlA0WGUvZmxlWW05?= =?utf-8?B?b01QY1VZK21sUmhjdFZaQ2pSMzFVamlUQzhjb1NMZkp1ZG80TmZHbkVlS05w?= =?utf-8?B?NWc1cUszeDkyZXRaNTB5M2ZGRlRrUFQzN2NpOEdKNHpMSURkNzZUc1FjNFdB?= =?utf-8?B?UmQ4R1Z1bnpqWmVwYVQ4eEp4ZzFmS1E4NUdCNTZaR2ZnVnhMc3lQNmtRbk9y?= =?utf-8?B?ZUlWbTc4YmQ2b3U5cVUwVmovOVp4VWx1ZE9YT1h4aHQxUGtXMWZUcThManVN?= =?utf-8?B?VSt1WEtyR2lrekxZM3VOZUsrVVRGSm9aQU1WRHMrMGhVSHIrZEJpd0VpbTVU?= =?utf-8?B?Nm5kWmpnb09RZlAwbUhWZXJMTUhEdms4N3l6M3diRS93eW9qZE5KMFhwTjh5?= =?utf-8?B?d25pZndCZk0zSmtMa1U5WDRGYjUya1lCMEx6WS95R2xKR01jNGovWUFoMUY0?= =?utf-8?B?aU10M01lSjhJRkxyTGRzWFBTYTA4cEFIUFNNY2hXYXFLRlUwck1nQUVjVitn?= =?utf-8?B?dTZxM0tVbkw3dm9IRE9tMFFic3A2QmhrU0UxVjdwTGNOWTJOMU5wSVVkTFlx?= =?utf-8?B?ZWwyZjZhOG1Pd0hCNFBtZlVXd3B5MXE0UktzOWZUd2VzcmdmMVB0WWdzM1JB?= =?utf-8?B?V0ozL21uMW8yZlRvK3VRaGNDQVhTV1VWV2J5S2xHOTRzbXJwc0kwVlZ6U1M1?= =?utf-8?B?aWhLL2dxdkE5WVBKSC8zNXZ4Q05MU3E2aUQwY2JqKzdNOEFoa3ROVGROUzdR?= =?utf-8?B?dG1rVjRISk9uNVBkTkZ4RXB2WkdhTVFIS2psVVRwYlIrQ0dvczBsOGNoYnRN?= =?utf-8?B?MjhDaW00K1djelZNcHFkekUzQUJTcnhyYklOUHlPOUFtMUl3OUZoY0V2T0tH?= =?utf-8?B?UzhTaGtlamw4WG82d2NUZmp1NnVKZ3NtL0NSQklZMHlzcGhuVFJrNitGVG1W?= =?utf-8?B?Wng0Zy9xYy91c1JQU2VSdTJ0YVBjeVJ5bXlQYzlYNWp0UEwzai9IbDdXSGgw?= =?utf-8?B?d2V5b0s4dnJQMGJJSTZ0S1F4S1JDcWttTU8zQWsrb0dHYjJOUFBUWXRhemZz?= =?utf-8?B?Y09neWlKb3pHUHhiNVFDbWhsZU9kK3hlRHRQaElsMDc0ZldPS3FqeUdTQSsy?= =?utf-8?B?NGZxQXFUbGluNDhieWp2Y1g2Q1M5WmRlcHl4WnZHRGFUV0ViS0JENHB2WGdi?= =?utf-8?B?MElySWF3ZERkL0RIcjFzb1BZQlllVmN4VzdaTFkrUk11K3VMSncvYitkbk15?= =?utf-8?B?WE1yTk5tMGtCYW9UQ1VWTjFjLzFxSzN0Zmxjd2lrWWczbXdqRlR0dnppY2lG?= =?utf-8?B?K1dKZFFaTFd1NUVMbVQzZjZCd096a0x2TzNmZTFweVE3YW16NWlLQ0pVVTc5?= =?utf-8?B?TjhSTGl5ancxaExxbmVGYWxIMWpjazg0K0VFeUx3T20ybmtYRDlmYUNZTG5Z?= =?utf-8?B?dzRtRlQyR3Vxek44a3BVbzN6QVoyeklScUxDNHVQd3pKVHBWUW13ZmdFcExE?= =?utf-8?B?UDNLeEQzUkQ4SWR2Ky83RVFONlFGaXljSDJISGpaa1ZBY1h6V2M0dHpRdWdC?= =?utf-8?B?ZWtjaUlYdW8zV3VQYm0wUXN5WDh4SjZVV3NGWFE1RXA2c3FpaWpGM3AyUE14?= =?utf-8?Q?NyP28+o+SggTMS+OGI6C1NJsw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b90ab60-713a-4178-e51c-08da96efb9c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 07:55:58.5882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JJnVIiA8HPZSarDSWXaw6m+UhFI3BLzemsDXR2oOwIdBzmUJZEXG3FfyJj/Qcjs4WDpb98MGDUiOTVuo5dRtpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9228 On 15.09.2022 02:41, Tamas K Lengyel wrote: >>> Do you have any idea what might be going on and preventing the output >>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still >>> present on the receiving side, just nothing is being received over it. >> >> There are few more patches in the series that are de facto required. >> Especially those about IOMMU, otherwise it can only possibly work with >> iommu=0 (which I'm not sure if even is enough). > > Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this > on the console: > > (XEN) Panic on CPU 0: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0011] > (XEN) Faulting linear address: 00000000328b3a54 Perhaps in another thread, could you post details about this? I guess we want to address this independent of your XHCI issue. That's an attempt to execute code outside of the Xen image - the only reason I can think of for this would be an EFI boot services or runtime services call, with (possibly but not necessarily) quirky EFI firmware. Any other context this is appearing in would quite certainly require a fix in Xen, and I don't see how "iommu=0" could affect the set of EFI calls we make. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 08:01:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 08:01:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407275.649709 (Exim 4.92) (envelope-from ) id 1oYjoD-0001h7-3N; Thu, 15 Sep 2022 08:01:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407275.649709; Thu, 15 Sep 2022 08:01:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjoD-0001h0-0R; Thu, 15 Sep 2022 08:01:17 +0000 Received: by outflank-mailman (input) for mailman id 407275; Thu, 15 Sep 2022 08:01:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYjoC-0001gu-4E for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 08:01:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 919d376a-34cc-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 10:01:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8654.eurprd04.prod.outlook.com (2603:10a6:102:21d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 08:01:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 08:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 919d376a-34cc-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gD0wsQpRo/iCpELJojLLe92xQcQ8T7MxLuuzpWRQ1wmAOmDZUTeuwKttdATYNRPBBb2DcCr9lCKUknn+QRKGdr2Bh+3grxhTxvxwHFWrYbceUQfQPvSvMW4eOp7rcRiff/kMdQxYCyPt2hLoy+HGn5p97ZQjShBqQm6L2JL1SXh/Ak+CENAKQcXj5TF2fZZ9kCZ1mJ1yodw87a0il247BTi2j3HMUfB/ROrrlnUhniBMbwBvLMAoq8clC+TyMw3TfWWZya0w2z7oQlUjV45OXayGvKbNWa4MHIMRRWxHm02r+rD9Vt+lsGTWyxd2qbiSBx7Rzag0ixsYfe6EyxUo7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v2LgxLd5d+p++ENnAU5rvHkmCcSw+f/z9x7e8kBgz48=; b=FzfiDdrphWqSRgF/x0JHCg+kdJc6Os39zLkcwD+YiWbhOtZ7hZAyH3cNOYGi5Ku9/Bm0CS7LmLPnLwj50FHe11wimTZonsvw4+FPGqzY0xtcVnKCXTf8xbQ2sNYY/S4a4Uy59QoYWiDN6PDTVDNYguHfjY3kHghNlfNNL9hQrn6Ssiyuzgl8GE53s1no//Bh+q5n2hzrk6m4zbIdHa6fUExDo0OQ2lpqIeJDrcLuFn7GquIG/siSa9rE7e2QBays+79tOEATbMpEYfobMarMaejjImtCQRVqS4U5699iCtgin+RydHQGyuPzkKnG83F+neTLORIphF4ElovVhzsrFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v2LgxLd5d+p++ENnAU5rvHkmCcSw+f/z9x7e8kBgz48=; b=apNz8kzHIjec01hJMMHiyYZu2MfNzMYYq3zjse6KipUaFDXWFu+zzy/TjhzMGL/vYz92qE12EiY7/YGgRdVZiwEBX69hymi41jvvEQ+Ooq9pc4Nuhtilb1Nn1fXETOaqhd+S1YqK5rq74NDiAcFNzigMYA852Zm2e3V4H5vWuW76czBuN3gt/CaXIHXZUlQASigppBfoDkbkhlP245nqgwyfEKaO5hbdb4u0NCSxvWrKVQdYmn3bOyMRGcw7IvyVUOD2CTwl57BCJk/qsP55BTQqiOvvmxEskHouyz+HZs6qCJK7QM64fg+4GG/+olFcwUn8zdX0W5mA+GhSjg6WTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52cb5a00-83fb-8a35-4670-8dde87585f9d@suse.com> Date: Thu, 15 Sep 2022 10:01:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8P251CA0014.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8654:EE_ X-MS-Office365-Filtering-Correlation-Id: 3eb0a159-72da-4f97-c4d1-08da96f07567 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C22RmNytmuz8cqdF5OqewZwqEThug2OoJWVQkiYrx8q3XSIBkCwL0awlFviaQCZyYQ6nDQWQ8dw1eiUpsEXdt99XNOAEmI4gpYD/01HBWIizfhMdyBG+IdV/ggfydXzsAb+3WSxCuODhVuMMkIp03Fea6kVr0xIHFTYB0IiAZRbgy6mEvPLD6XykljuFytxOzci4ni0SGaMPtoIziqjc/ZrlbDQ06dGfAG8OdevzzZJVohp6V11+klCMPKuZWTniU/U0DDloVZTUgAQHzF4YTYHtGwyMgEI4hpBxynjJvtoVaNTOTGlxkndQQTwZCP+tP5uX32Q15b3j3Bka+uuasKehzu4A5Q9IeaAWZMqRX9kqTwVZQGIOpFeWA8RPOXWKA6su7WRi0PCRvhwsF3orY2FqMhiejgQRRS93aGqqTPTe8/b8F49oInBdvLZQftatagMkyZxiliZs0t0foHeqlS9JcY90Qul2a41gxVJ5sz8+EVvLrSpxf5+/pC6qHbaPi7qiGDxxPjJBoXY/sfstIy5aLf0BO8g7PX9bO8S+MqmIB7l2MaX2N6Zj9MSdhNruUmhqUaqzK/oUXD+KDb98CvENZJm0jkMq7IlGC9Qncp6xkv7YY+7UX5OXccX3JZSjGYKOISh4mt3/1tKpDmaiJAuXS+UnkhI4YxtnHrBZhdsMVoPSe63ZEtOaAhpayJ4hs/B0rVIJbLM55jvnJDCgQn/C0rsCzmaEAsW2TurG8vCgmu7oqQIVKDfzDnjvrIh2vWqK9gQMQagd6hg/NukeCNnxxUoKTt/DXIs94Y8dVJE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199015)(31686004)(8936002)(5660300002)(66556008)(478600001)(83380400001)(4326008)(66946007)(186003)(8676002)(66476007)(2906002)(2616005)(316002)(86362001)(26005)(6512007)(31696002)(6506007)(53546011)(41300700001)(54906003)(6916009)(36756003)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWVaTDV4cnJDS2pxNHJYaFM2aVp4TXlSdXUvU2UrZ3gzZVpPalBTT3NsM210?= =?utf-8?B?Q2IwNjBFUW9QSWI0L2xhY1JFL1VkUW1ocndaTS9vcmlabkdYYlZoWTBQbGlX?= =?utf-8?B?TGtnVWQyMWtrRVNGZjZ3dXNRMlUzWFNDQUhNRmVNMEpNeHVqT2E5end1Y1Jr?= =?utf-8?B?TkYzTzJFZHVsMFN5UHlBV0FFSHpsdlpKTDZya0VQUU9JSWlrV08wWkxDQTNk?= =?utf-8?B?clFKa3pkbDVYaWhvMTVGUU1lM1k4RG5hWUxSWE0wNDVweTUwOG9YS2hEU1ZY?= =?utf-8?B?elRyRjU1WXBuWDRuMnlpY0lSV0FSa3NSV1JpRFZTZjBDQm9JVFNGY1VwcTBr?= =?utf-8?B?QU5qMGdOSkxrZm5HSVZUMS9YRmhQZy9POVVxUllhaGtZYlF5bTFOZW1ucG9W?= =?utf-8?B?eG02VHgzVjUyNjJ0N2JFM0NYclM1TkFVL0ZqOExJZjZDdVRIb1AvNENOSDRE?= =?utf-8?B?b1JvWFRQaEEyNGE3MkJZYk5adUZsd0llT29mSkh2VUdNT3l3UXZXTlRneldQ?= =?utf-8?B?T2RXSkNCalhJUGk4NzVWd0tzQmtkNmZ6K3lhekhVT1EzcEtFMnllVTN6WG14?= =?utf-8?B?T2xkNlZnV0hLdCt1OGtxcmhFU3J6Rk1zaEdrS1c4aEIzWGtRQ2NkRUxhUWQw?= =?utf-8?B?ZGxnUkNiM2FrRHNXN2dDdWpCNytJUzZMVUNiOFRnM3F3c2EwL0UyLzFiODFu?= =?utf-8?B?Wjg3SkRVdHpkSFB6OXE5RU1MOXVaMWV1UktyMkVJcGdZWlNBaWJJZUwybU1E?= =?utf-8?B?VzBEdXh0MWJKSDlzL1g5UFhOVExCOGs2Q08yVEVjbEM0Z1JKR1JEL1M0eEw5?= =?utf-8?B?OHRDSFgzS2xraGZoTFo0UEVrQVdKU3NhcFBCVjFJaGdldVcwenJRS21sblFI?= =?utf-8?B?YURGV3hTQkFsTmttOWJHOHRwNWM2L2hpdWZkYUhLWjBmcWJBSWkzdG5teTBU?= =?utf-8?B?VVBlbTB2TGNTZEZ5ODNWdnBRZWRZSGpZSFlGRytVaGpvOVVMZlhXbjdrbnUz?= =?utf-8?B?RVovbTlqNUlDSzZCTjN1QkNkanI0RmxLQUhEZ29xVnJJTW4rSEc2U2dJUUxV?= =?utf-8?B?aXdRZlE3YmdodlUvOWQranN6eXFHTjFJQnVHeTJVOFpZTTBjWExzMFYzZ1RJ?= =?utf-8?B?S0pXa3B1YW4rT3ZMUTV5cll4WjhsalFEQjAvTjQwS3MxOWplK0NHSC9sQ1NB?= =?utf-8?B?aVVhUTl1RGdqdlNGY2F5S1lqKzdHaFQ2cHJGN3c5Vk1rMHorTW5YV0RVRmhF?= =?utf-8?B?TXAxbTA1eHQ0dFo4cTBRRW0zcGVMbnJWWHcrc1JpMnRCT01pQURFL2tPenBF?= =?utf-8?B?SStoUk13NU9GQktiNzhqaWZ2VUhuSXIxM2d5TFJKSnJyVDlnVWw3dzQ2QnhG?= =?utf-8?B?RWcxK1JIMjgrN2FmNTZ6YnJyT3BLclh1ZUg3RXkwd0hBYTR2RXJua1pzUVdD?= =?utf-8?B?emJLek5uODV1SHJ5TmZMYlU5MkRoWmRiMHpERmZRTElORFFja0pBc045Rkly?= =?utf-8?B?TnlUdlVPSnI2b21IZkFwTmlQd0ZoejVlY1FPaXZFd3ZCcDZEdWlGNktXbWQx?= =?utf-8?B?WE9mTkE1Zkw4MTlmdUJoaWNoM0VKK0F6ODBCTjcyYTZLSGF1WjBjL2piNGtw?= =?utf-8?B?eG5xOUVvclF0WlRoNysrMGRPaFlIaHdzaml5OU9mQlh3aG5RampkVUtXdWRR?= =?utf-8?B?S2lGejBSb0NEOVBiRWpZSUd6L3JiSXlqS00wd3pNZVo4VDQycTFaekt5c0d3?= =?utf-8?B?Q1JQdkVIZFQ2Ulhla0VHK2ppZE4vbFZuOElZSlo5N3JONFBiYmh0OHJYeXVZ?= =?utf-8?B?ZzFrWnJJY2JKQ1k1NzloZ29NMFlSRzRhNDhZbmlQTGhjaVlrWFVxdDh0ajBN?= =?utf-8?B?ZEE2VllLa3VtV0R3RkFQYVhaTDRhakpRSmNTZndPWk9HYVlrM0htVnhWYk16?= =?utf-8?B?RHptZWU0MHZUSytrOXR5bE9kSWtHV2ZFdE43N08zalJQb2NNYzNyTVNZeno3?= =?utf-8?B?ZzdQeVV0YlQ5bTRnVW1IVmNtWTRLMlRLbWZuTGkrRnN0ZFd6NlREZlE4OFhm?= =?utf-8?B?RmlYZk94SkRlRm1LUzhGT0lQU1g5SU5aZHV4cFNjSmxIZEF1YVdueGFtRkNn?= =?utf-8?Q?iZNhORPc8r0aCMG91SG7CULqo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb0a159-72da-4f97-c4d1-08da96f07567 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 08:01:13.3492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z5IN8sVj0/QTNDasR+U3t8YqEr8dz09wU0IV384PmUPKim6E8r49fxvKFlryeBfwYJtCnlvJkMWn3wxIMBFiOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8654 On 14.09.2022 16:23, Roger Pau Monné wrote: > On Wed, Sep 14, 2022 at 12:13:49PM +0200, Jan Beulich wrote: >> On 14.09.2022 11:13, Roger Pau Monné wrote: >>> On Wed, Sep 14, 2022 at 10:31:34AM +0200, Jan Beulich wrote: >>>> On 14.09.2022 10:14, Jan Beulich wrote: >>>>> On 13.09.2022 16:50, Roger Pau Monné wrote: >>>>>> On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: >>>>>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering >>>>>>> the consistency check in check_lock() for the p2m lock. To do so in >>>>>>> spurious_interrupt() requires adding reentrancy protection / handling >>>>>>> there. >>>>>> >>>>>> There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will >>>>>> trigger when trying to acquire the p2m lock from spurious_interrupt() >>>>>> context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> >>>>>> percpu_write_lock(). >>>>> >>>>> s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), >>> >>> do_IRQ() does call irq_enter(), and that's the caller of >>> spurious_interrupt() AFAICT. >> >> Hmm, you're right. I was mislead by smp_call_function_interrupt() >> explicitly using irq_{enter,exit}(). I guess that should have been >> removed in b57458c1d02b ("x86: All vectored interrupts go through >> do_IRQ()"). I guess I need to either open-code the variant of in_irq() >> I'd need, or (perhaps better for overall state) explicitly irq_exit() >> before the check and irq_enter() after the call. Thoughts? > > Well, it's ugly but it's likely the easier way to get this working. Just to clarify - the first of the options I did name is (of course) not viable: If we open-coded a local_irq_count() == 1 check here, the assertion you named would still trigger. >>>>> but yes - we could nest inside a lower priority interrupt. I'll make >>>>> local_irq_enable() depend on !in_irq(). >>>> >>>> Upon further thought I guess more precautions are necessary: We might >>>> have interrupted code holding the P2M lock already, and we might also >>>> have interrupted code holding another MM lock precluding acquiring of >>>> the P2M lock. All of this probably plays into Andrew's concerns, yet >>>> still I don't view it as a viable route to omit the stack dump for HVM >>>> domains, and in particular for PVH Dom0. Sadly I can't think of any >>>> better approach ... >>> >>> Yes, I also had those concerns. The mm locks are recursive, but >>> spurious_interrupt() hitting in the middle of code already holding any >>> mm lock is likely to end up triggering the mm lock order checker. >> >> Guarding against this is possible, while ... >> >>> One (likely very risky option ATM) is to introduce a per pCPU flag >>> that when set will turn all mm locks into noops, and use it here in >>> order to avoid any locking issues. This could introduce two issues at >>> least: first one is how resilient page walking routines are against >>> page tables changing under their feet. The second one is that any >>> page table walker p2m helper should avoid doing modifications to the >>> p2m, so no P2M_ALLOC or P2M_UNSHARE flags could be used. >> >> ... personally I view this as too risky. > > Is the dump of the stack only used for the debug key handler, or there > are other places this is also used? It's called from show_execution_state(), which also dumps state for e.g. crashes or WARN_ON()s. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 08:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 08:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407281.649719 (Exim 4.92) (envelope-from ) id 1oYkPW-0005IF-06; Thu, 15 Sep 2022 08:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407281.649719; Thu, 15 Sep 2022 08:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYkPV-0005I8-TQ; Thu, 15 Sep 2022 08:39:49 +0000 Received: by outflank-mailman (input) for mailman id 407281; Thu, 15 Sep 2022 08:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYkPU-0005I2-BV for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 08:39:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3ea0bfc-34d1-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 10:39:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0A2BA5BE25; Thu, 15 Sep 2022 08:39:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D37AE139C8; Thu, 15 Sep 2022 08:39:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kddZMtHkImMaBQAAMHmgww (envelope-from ); Thu, 15 Sep 2022 08:39:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3ea0bfc-34d1-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663231186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HVt4BOPE3fE7s0bXLMbHOkdxiGKbxOKgMrc/CZYuzgY=; b=dLG+eMrIelUr4qu3McoZ7ce3j253SI0fHwesCYVIeS/nO/cQIPsbxqQ9DLOzOBM7U4KvJU c1kKjUqSifCG7mvi16UBzFVy1ZwBCfKBecm84k7U06XTkyopFfg6R++02zKlFsj0NgRvEH tNRD+LL8YGDOSO2FbgkZvcvAoBZ3+Tc= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap() Date: Thu, 15 Sep 2022 10:39:44 +0200 Message-Id: <20220915083944.10097-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IOCTL_PRIVCMD_MMAP isn't in use by Xen since at least Xen 4.0. Remove it from the privcmd driver. Signed-off-by: Juergen Gross --- drivers/xen/privcmd.c | 138 +------------------------------------ include/uapi/xen/privcmd.h | 2 - include/xen/xen-ops.h | 24 ------- 3 files changed, 1 insertion(+), 163 deletions(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index e88e8f6f0a33..5136644f3008 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -147,42 +147,7 @@ static int gather_array(struct list_head *pagelist, /* * Call function "fn" on each element of the array fragmented * over a list of pages. - */ -static int traverse_pages(unsigned nelem, size_t size, - struct list_head *pos, - int (*fn)(void *data, void *state), - void *state) -{ - void *pagedata; - unsigned pageidx; - int ret = 0; - - BUG_ON(size > PAGE_SIZE); - - pageidx = PAGE_SIZE; - pagedata = NULL; /* hush, gcc */ - - while (nelem--) { - if (pageidx > PAGE_SIZE-size) { - struct page *page; - pos = pos->next; - page = list_entry(pos, struct page, lru); - pagedata = page_address(page); - pageidx = 0; - } - - ret = (*fn)(pagedata + pageidx, state); - if (ret) - break; - pageidx += size; - } - - return ret; -} - -/* - * Similar to traverse_pages, but use each page as a "block" of - * data to be processed as one unit. + * Use each page as a "block" of data to be processed as one unit. */ static int traverse_pages_block(unsigned nelem, size_t size, struct list_head *pos, @@ -211,103 +176,6 @@ static int traverse_pages_block(unsigned nelem, size_t size, return ret; } -struct mmap_gfn_state { - unsigned long va; - struct vm_area_struct *vma; - domid_t domain; -}; - -static int mmap_gfn_range(void *data, void *state) -{ - struct privcmd_mmap_entry *msg = data; - struct mmap_gfn_state *st = state; - struct vm_area_struct *vma = st->vma; - int rc; - - /* Do not allow range to wrap the address space. */ - if ((msg->npages > (LONG_MAX >> PAGE_SHIFT)) || - ((unsigned long)(msg->npages << PAGE_SHIFT) >= -st->va)) - return -EINVAL; - - /* Range chunks must be contiguous in va space. */ - if ((msg->va != st->va) || - ((msg->va+(msg->npages< vma->vm_end)) - return -EINVAL; - - rc = xen_remap_domain_gfn_range(vma, - msg->va & PAGE_MASK, - msg->mfn, msg->npages, - vma->vm_page_prot, - st->domain, NULL); - if (rc < 0) - return rc; - - st->va += msg->npages << PAGE_SHIFT; - - return 0; -} - -static long privcmd_ioctl_mmap(struct file *file, void __user *udata) -{ - struct privcmd_data *data = file->private_data; - struct privcmd_mmap mmapcmd; - struct mm_struct *mm = current->mm; - struct vm_area_struct *vma; - int rc; - LIST_HEAD(pagelist); - struct mmap_gfn_state state; - - /* We only support privcmd_ioctl_mmap_batch for non-auto-translated. */ - if (xen_feature(XENFEAT_auto_translated_physmap)) - return -ENOSYS; - - if (copy_from_user(&mmapcmd, udata, sizeof(mmapcmd))) - return -EFAULT; - - /* If restriction is in place, check the domid matches */ - if (data->domid != DOMID_INVALID && data->domid != mmapcmd.dom) - return -EPERM; - - rc = gather_array(&pagelist, - mmapcmd.num, sizeof(struct privcmd_mmap_entry), - mmapcmd.entry); - - if (rc || list_empty(&pagelist)) - goto out; - - mmap_write_lock(mm); - - { - struct page *page = list_first_entry(&pagelist, - struct page, lru); - struct privcmd_mmap_entry *msg = page_address(page); - - vma = find_vma(mm, msg->va); - rc = -EINVAL; - - if (!vma || (msg->va != vma->vm_start) || vma->vm_private_data) - goto out_up; - vma->vm_private_data = PRIV_VMA_LOCKED; - } - - state.va = vma->vm_start; - state.vma = vma; - state.domain = mmapcmd.dom; - - rc = traverse_pages(mmapcmd.num, sizeof(struct privcmd_mmap_entry), - &pagelist, - mmap_gfn_range, &state); - - -out_up: - mmap_write_unlock(mm); - -out: - free_page_list(&pagelist); - - return rc; -} - struct mmap_batch_state { domid_t domain; unsigned long va; @@ -844,10 +712,6 @@ static long privcmd_ioctl(struct file *file, ret = privcmd_ioctl_hypercall(file, udata); break; - case IOCTL_PRIVCMD_MMAP: - ret = privcmd_ioctl_mmap(file, udata); - break; - case IOCTL_PRIVCMD_MMAPBATCH: ret = privcmd_ioctl_mmap_batch(file, udata, 1); break; diff --git a/include/uapi/xen/privcmd.h b/include/uapi/xen/privcmd.h index d2029556083e..6101d1566238 100644 --- a/include/uapi/xen/privcmd.h +++ b/include/uapi/xen/privcmd.h @@ -113,8 +113,6 @@ struct privcmd_mmap_resource { */ #define IOCTL_PRIVCMD_HYPERCALL \ _IOC(_IOC_NONE, 'P', 0, sizeof(struct privcmd_hypercall)) -#define IOCTL_PRIVCMD_MMAP \ - _IOC(_IOC_NONE, 'P', 2, sizeof(struct privcmd_mmap)) #define IOCTL_PRIVCMD_MMAPBATCH \ _IOC(_IOC_NONE, 'P', 3, sizeof(struct privcmd_mmapbatch)) #define IOCTL_PRIVCMD_MMAPBATCH_V2 \ diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index dae0f350c678..a07e422be09a 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -159,30 +159,6 @@ static inline int xen_remap_domain_mfn_array(struct vm_area_struct *vma, true); } -/* xen_remap_domain_gfn_range() - map a range of foreign frames - * @vma: VMA to map the pages into - * @addr: Address at which to map the pages - * @gfn: First GFN to map. - * @nr: Number frames to map - * @prot: page protection mask - * @domid: Domain owning the pages - * @pages: Array of pages if this domain has an auto-translated physmap - * - * Returns the number of successfully mapped frames, or a -ve error - * code. - */ -static inline int xen_remap_domain_gfn_range(struct vm_area_struct *vma, - unsigned long addr, - xen_pfn_t gfn, int nr, - pgprot_t prot, unsigned int domid, - struct page **pages) -{ - if (xen_feature(XENFEAT_auto_translated_physmap)) - return -EOPNOTSUPP; - - return xen_remap_pfn(vma, addr, &gfn, nr, NULL, prot, domid, false); -} - int xen_unmap_domain_gfn_range(struct vm_area_struct *vma, int numpgs, struct page **pages); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 09:32:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 09:32:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407287.649731 (Exim 4.92) (envelope-from ) id 1oYlEI-00033P-Tc; Thu, 15 Sep 2022 09:32:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407287.649731; Thu, 15 Sep 2022 09:32:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlEI-00033I-Pz; Thu, 15 Sep 2022 09:32:18 +0000 Received: by outflank-mailman (input) for mailman id 407287; Thu, 15 Sep 2022 09:32:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlEH-00033C-1x for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 09:32:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4889964b-34d9-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 11:32:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7632.eurprd04.prod.outlook.com (2603:10a6:102:e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 09:32:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 09:32:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4889964b-34d9-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JGCZgrFrYu5JZgnbkbuAl2nh97pPHWWy7PicsktV2zJHru2XPtbIXvOzPki2rj6NsibEF9xSTVnLbrPfh+/OEpXXZGW/jR5L3vgNEXOe1oPPSkfmCYM/VEZHeZyavLmEDCfz8jAmOlcHoPvzzO1d1SdznvGYxq5xnisZySZV9mLizNznbHdHU21yEWjjkQFqD8/k0/hOPFPdE2ltSyqKTegousdP8m9bkChPtrGjRy9jBXUvFaSyQzCuxtSok0fJHb3AqKrw+QI45GBe8vwr7X4KfdMkvPN/ZQndmxCXUWHtQKjbCctNtpCB9gSgclH3aY3KWd9a6cXSnAkWs7xkvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ILzV6Uq8lnNhepmaqhpUu1XImfYV1rqfGGKmBx+yiOg=; b=eBzJjUHDond59PIHPm/2w7+Fs3Fm3Ya9jm7qmTzFOLF18Td+FPMgh9PnErHdki0meJ8GiJ+0eKbMQL4lAgB/a/XeHuyG1+9APRBKef1VRlCHXm0JbSGQOHh2jVHop5/hHrtfaNvVDWdxDuunhYtbLjLcwOhHQgkPkz3j9LRTiFmYybfyUHKATa0MGA7oOz/GVlyigjMYNJg07tgK4b6rCFMHAhZyvgxknRAk67r6NHdUSubGS4xDMDkp1147xSH785SXn9qEeMxe2BMjwwSoUt60OJXLGvZzb7q6okU1tiud2uwz8JHrtdbw7+YIpJJ7/XR8TXhjzVpJHJ5jcv3ylw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ILzV6Uq8lnNhepmaqhpUu1XImfYV1rqfGGKmBx+yiOg=; b=a3RizUP1OqH2FixccheVn2jZO9Ghrtbu8Kx4ULOgdvW6vKLicX4iv/aJdhz+uIVxMl2K5iNT/hUQZweZ1WHXLDZpUu4e2aq8s1AaL6Pzf2j9u5mfPpotuWUlvCJCesJYasSMbHLA7XfkE9gHB9G/1ipknZIF38Qk6tvdJ8gGpPet+PECoJ1n6lnH79+6XaEYi7Ld4MU2p0Kp7NgjvbfOSXTRhBelZK2am8adxbLAcS2jMJnxC8wPEAFqUx3Zl9H34mShuUoX4Xll2G+4Z6hpmRS6khUrbxsqRXflOBDcu9A9ceg/JEvHNYZcsnMJXPw43T554UGyLodLbvCpjkK7ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> Date: Thu, 15 Sep 2022 11:32:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap() Content-Language: en-US To: Juergen Gross Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20220915083944.10097-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220915083944.10097-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7632:EE_ X-MS-Office365-Filtering-Correlation-Id: 941c63d3-4f12-4a41-f89d-08da96fd2acc X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jbs9mMPTPPAylaDMDdWrARrx4LvEZzfVf5R2vhB5FNr6MES6C1DQNebwezZmvOPkXn5L6dvzz4BTsZYKmzjCwGThyhbfrxfL4JsPk2996PelpplspvwdRMH0Cj2psKSxHYsyUc5xwbynJlKIPEQdd96XOMnD5SaV4a+A4q0WxJ0gybW/MhsgiFI7QtJ/IlZIPf8XL+dD6obAu9vEpSNHXOBsTfMKBPvljjyw0Npjf06nDfOiYsdpcPzlHa/3UwchYJby1E0cWV48iXBH9/iy1x8Q6mu7Q95vhnc+KeXnPckIr/xWpyTqydok8cka+KPJZH/tUbgF+7V3TWLMa2vVVVdbF3K4fj1ZPJ95JfhhXxkNnCdcA0FXCyo/jz+yhwv39y6DleeIi3LtixbkC2rhSSOxdFNAK9nAnMaN04NBSZ5xa89wYdnrWdTXe7rIORFVT2e0oAcC23Ka4EWreINBeUdy6NTSn5kwJ+XEFgfBwpfo21HGnzfVO9ev73gdYEznN7wRW6VGIwijLTAFH1IIyKAVH4/6U1dE4lB55RunUFH3Oxqjb+NjJhjMYjZyA7o38EcFsyun4J4ZKMtqHmmVwkzj0xhSayETVfhz1KFDlZjQ0q1+fYww8Kl28O5SKHrUuWJ3SFAqFE/PAVs4QUAmq7sPRGd5s6UyY8w4rQdDjybbVt49Jh8N+KFeOHPT5SQB+US7WoERV468Wcl48o4L8LbP2JA1ehAjyv4RdzTGnRyBJglWlWCPAIEGFRKVRDb0YmcUkZMs7dfnIi4jfK5oZm78iWKS5yZ4iZFMfu1o0bo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(39860400002)(376002)(366004)(451199015)(66946007)(26005)(41300700001)(478600001)(4326008)(53546011)(6636002)(36756003)(2906002)(31696002)(31686004)(186003)(54906003)(6512007)(6506007)(2616005)(66476007)(6862004)(6486002)(8676002)(37006003)(8936002)(316002)(66556008)(5660300002)(4744005)(38100700002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGV0ZjhvMDloV2ZFUWlRUGtVYWNqbmpxRk9TN3BIUzRqSDE3NnFrbWJDQS9Q?= =?utf-8?B?ZEt5b0hIOFE2ME5lbDRDbGFtQis1dWJKNzh3K0NzcTFHUUpNQzZLZ3h6WVlS?= =?utf-8?B?aVNIZDJxa0hiN2g4WmlEdkVpcXNLbVkzeHpSbDkrRUYxeWQzUjVvaEJvSHZJ?= =?utf-8?B?V20wS0xvVEsvWFd2YkRoRm5ybUJTTUJnVzlyMWptY1FlRjluRGt4ZTNWakxk?= =?utf-8?B?MGx4dXJ2eEJBck9hWlAxUXkrVUh6NDFIbUJqMnA1ZERyQzlGMDQwM3hGUkF2?= =?utf-8?B?OUJwcU15QmdON2w5cThqVy9Qai9EZXFtYXZBcTEvU0I1TTkzNVJEaGRiRy9k?= =?utf-8?B?WENhUWJUWGZJQXBFNDI4eWc1cFptTW5uTzNhSkpMbCtDRkl6SU9WK01TVUtI?= =?utf-8?B?aXNteCs3VHdwN3dVSmdOZTlQNFk4bTlPL0czRVZwZ2pMeGU4bU5uUDJ0TUFI?= =?utf-8?B?dzJSRW1UaHdIV2pHajAvS0E0NjV0Tk1TdFhzTE9FRG9pMmczQkFIMk53VWNK?= =?utf-8?B?RTBxT2JJQ0dsekRWazV5d21Db1E0cFMvL2ZOWVlHSzFDcnVYSDVqd2p3UXBy?= =?utf-8?B?clZXditsajRaUW5kOU50TG0rcGRWREh1T2tEdFdoNG5lSG01L0w1VmR2a2hs?= =?utf-8?B?NnF6VHBuUU12U3loYjlHTkFPcjc0c3hGcDk4a1dXa3FRWXNFMVdOL0UyU3JZ?= =?utf-8?B?SktuQWFYSHNQZEZ2VTdhTnJ4UUg5bS9KeUhKYUpnSEkwTisvL2s5QVBwS2pk?= =?utf-8?B?Y25iK0VweFVUem9FYlZiOGJuZTlIN09ldTNRRDByUnFaRitKYk1ub2VEV3ll?= =?utf-8?B?WVQ5V0ZYMTExRmR4NENzS2ExVkFjakN1MURtOWVEZjUxT3VkcXh2S28xdUVQ?= =?utf-8?B?Qjk1Y0pOS0YralhydFozQ3RwWm1mTlRoNkhXamhSZmR5bzlpUE40RDlHRnh2?= =?utf-8?B?R2FWcHZiRmRsRHhBTElmU3pwQk9GbHF6SmRnWVFRTTlwNnh4Umd3YjBMMjlm?= =?utf-8?B?ek1nNkVFV2NIQ1RaTVZwSFd6ZWdxQ2c3aFV5SWZKSmtyUGNwZFZJbFo3VUVX?= =?utf-8?B?QzlPWTBQbHNTbG5JNHgra3F3OHU1QldvUFIxQnJnVVFJQmRRWUI2bHp0aFVy?= =?utf-8?B?Z3Nnc0M4cDE5K1JlSlg5WFR5OWIyK0hraDNwT2dGdkNVVlBJZWYrbXhTVy9s?= =?utf-8?B?MFNmSmFzMm41N2NuZWM4bE5BbFFCN3NDYVUzdE5BaCtWSHRQaHR3MStMM0xT?= =?utf-8?B?N2U3R29DM2I0clJ4SEUvekFyVmNYTzJXeGxlL0ZjcXc1dWVmTnB3RVM0MUw4?= =?utf-8?B?dnQ5bzdRVlNqa2UxdmZvWmRaZE9GTWtkR2lWaVh4b3A5UmtmRXZ1ZmNvTjRx?= =?utf-8?B?V0U4blF0NnFVSEl6c1Y0eTFQRTB5aUN0aWFtMndWei9RSDI0akQ2SUt4a1pG?= =?utf-8?B?MWZwYm9TOHltdG9URHc3TnRFSjVjMm83aFhKUGJSMFRBbG5MYTJnTGdYbXB5?= =?utf-8?B?K21vaHFYbmxPWWRwT3c3YjNyYVFhNW91TjgrelRlaHM1NWNBNFNtTitrWlky?= =?utf-8?B?eXFvSWhBVURwMDVDU2QySnJyOGFtU25oekRCMHN0M2dIclp1eEUvKzhrRjNB?= =?utf-8?B?R3QzRWdxSzFod1JmZmVnTzFyWC9SUFNCNHR4OWhHUys4dFZUVUpIVXh5TXBP?= =?utf-8?B?MC9ISDRFckZIaCtMOWFOYlMzZWVnNEtINzRrdFdEaUNsTXNHaCtvWXFnMldG?= =?utf-8?B?aHZLMEVGazVyMVRZdjJ1UUpmb0dwRkl3RlFZNHlZdEJMSktYMzd6Yy9WRzFC?= =?utf-8?B?YnJ1bXZFRStsTFpqMlM0a0ZQQTFmdkNjU0dSN0VBcTNXNlllVmpvcFB4RURj?= =?utf-8?B?eUVrZkJwbzNlbEozSnNrOElJYTgwcUs3aXpOVitpZzN3cDY1bitQenltbVBI?= =?utf-8?B?eWZuaytoaENqd1R3SzQxWXZwZTJWajhFWnRsaFpCaXZ2aWUvZ00wc0hyYVR4?= =?utf-8?B?dWx4T3dqdlROckdlTlY1Z3BIakZ4aE1xYm1DWHdVZjFrN1EyZW5QeDhjakh4?= =?utf-8?B?UC9nS3Q3RlUwZWxkRFA5Tzk0eU1IR29RVzA3L0IvNUl6VmFBUTU1QmVzR2lx?= =?utf-8?Q?CPdy9cG5S76kbnsJ07fGjNaKe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 941c63d3-4f12-4a41-f89d-08da96fd2acc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 09:32:11.7970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: osYeF35OKz7dyHVIpdvD5OmAdoDc+eBzkTG+Akr2zDi4eJnZZNwOo0FvnObVv0iZIf+RZ+EhukstRG48YClgsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7632 On 15.09.2022 10:39, Juergen Gross wrote: > The IOCTL_PRIVCMD_MMAP isn't in use by Xen since at least Xen 4.0. > > Remove it from the privcmd driver. > > Signed-off-by: Juergen Gross Can we reasonably remove an IOCTL, without being entirely certain that no users exist outside of xen.git? Even if so, shouldn't there be a staged deprecation process? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 09:33:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 09:33:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407293.649742 (Exim 4.92) (envelope-from ) id 1oYlF1-0003bS-Ak; Thu, 15 Sep 2022 09:33:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407293.649742; Thu, 15 Sep 2022 09:33:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlF1-0003bI-7D; Thu, 15 Sep 2022 09:33:03 +0000 Received: by outflank-mailman (input) for mailman id 407293; Thu, 15 Sep 2022 09:33:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlEz-0003Zw-UF; Thu, 15 Sep 2022 09:33:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlEz-0002ZU-Pj; Thu, 15 Sep 2022 09:33:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlEz-0003u2-EW; Thu, 15 Sep 2022 09:33:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYlEz-0004m8-Dk; Thu, 15 Sep 2022 09:33:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=60MB/NpajXkPEwr9vr0MVkGlqgwRJTbwfFZlDy9x8Oo=; b=ISc8hlJL6t9UyXAwF4yQMmaGB4 XCaplesGn5TpDU0W5qZHLCz68Tph3h7Th9QBIo+ztwRdZk5O6rJvjdfwogNxoLIa9NA5AjnTjuMkx ispuK5h0C4ExVQvZhbgm+2jqIb+D7l3aDGSq7BxUnmxO7IweNzwu/VcOYwHU6B6Iel0k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173200: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Thu, 15 Sep 2022 09:33:01 +0000 flight 173200 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173200/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 42 days Failing since 172148 2022-08-04 21:39:38 Z 41 days 94 attempts Testing same since 173060 2022-09-08 07:34:59 Z 7 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 10:05:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 10:05:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407303.649753 (Exim 4.92) (envelope-from ) id 1oYljx-0007Gy-Us; Thu, 15 Sep 2022 10:05:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407303.649753; Thu, 15 Sep 2022 10:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYljx-0007Gr-RZ; Thu, 15 Sep 2022 10:05:01 +0000 Received: by outflank-mailman (input) for mailman id 407303; Thu, 15 Sep 2022 10:05:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYljw-0007Gl-Qm for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 10:05:00 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db78721d-34dd-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 12:04:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7474.eurprd04.prod.outlook.com (2603:10a6:20b:1d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 10:04:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 10:04:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db78721d-34dd-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hj9HG8yQMK9a+F1KEA31lAIYeQyeEquy2wGrqIKF8CY8mHBp0Mjm0CDlfwiaTPz1X6zEX3stuodW9PN2CPxvw6q9nXCwHeDoemJ0CIlFhHmvn9GbCDNEeL73ryK1JcPXgb1nYioSJ21PmWw9japl9v016SwCAoOclUCzhCIXtLuVsLArgR4N2v6DCJjHpzARg0JtpnmKUMmFWCXnz/xqVOGyZLqIIVmSL1vKLxigZhCWIRE97nPVmtuS1vOJe1CHkuDu247O7DffEt92kV2c2ux1QSkCkzvYKBiBur15bkk8tqHqeeKzg3N0XN9cyrouk+uUpzq4IiV0moJrT/+/Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qI59twKsYmmesU3cRk8rF8XEn2z1DD7sDUYxjZMfDek=; b=NCG/+0UqbO8wFX7E/eR2R7uPmpGnQGQCg9WDt3yYC1pPzAia3HrW4MQmp4RfBy3mt8G1UOC1yNveQZae1vvYY8mCRh855k7p5n/DRG5VgshRcdzxW14I3xxOhEbdYALN+FxRkkX2y9fxsNDFrkcle/HvfX7AljfyonlZRcSzgrhq/u9mOBcUxLU5/GCbffJuu3ERKBx1vC8y6aC0cG5pl21u/KSkbUJWim30zH0YSCK3btp9jKhGAev8NiU23Od/3XrXP/Lr9euUmtUGJEBG6rBK/EkZ2dHEn8Wid1am9PWIDwsaIK+YIyuCevu3ZooL6QStyUw6paW4xa+q9lOcKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qI59twKsYmmesU3cRk8rF8XEn2z1DD7sDUYxjZMfDek=; b=dB3AhVo2PcMiV8goAq1vmwJE4lePJhQNdFKZ1cVGg3CRp24qJq5C0ITIBWbH4J4svmDk/Hoop3D6IIrn/poZ9u1USgQMh1syJKRzH0kxDvcQoqZgtZA+zgzaRQok0qnJZIwEcPSoJiAWEqhp0rrQKn64H/AqaYzoRj4Kqr1KKrrNH7/MmT4mfTbYZwGlR0Sr3Z7/vqCtFPL8gMu5dTVQtODhSTOoJUd9OwLotfYCNRt1bWEUoX9lbzaToiF8Ny28qA8GsejyRSZYB68aC61QCht9ZB5JjGyzctzL6UfXdfDnpTOTMXll+aIK4uk30NDhnKeccbjHK7C6nEVQDQqAkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 15 Sep 2022 12:04:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Demi Marie Obenour , Henry Wang From: Jan Beulich Subject: [PATCH for-4.17?] x86: support data operand independent timing mode Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0022.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7474:EE_ X-MS-Office365-Filtering-Correlation-Id: b278b8f7-2b5b-46e5-d5ff-08da9701bea7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MfJ6oiGZyXpEHwlKHl4xJKXjhDeiWi3binM6/GxeMX2A+mVQB+ik1XqzTbJwcHVa9hzi0uGgpL6ZgP+o6cWIicNtxczkeL0/E4DbcQytnftLatCfttMu8N8eM3X5Yk3XljG9agMXXkHW7T0lBZc+0VWjfuL/ICuTAPFzs+xeSu1ehApuVW+LKBWvEs54ILcdU9uXQOzIa/hiQZ7vvqetL8jpbDnVnTdPIIjbU684Tj2010d8O9YdWpDGQ4HfN4QstA7WRi1hiXacbEw8NJBPHhLV95VSffVPHqMfzW0LR7AUNvjCm+AVw+/g3uNUhBVX/l8iGWMLHhqhMzLo++pIqsdkkF33PLLzVFlnEJWlXgDZzTcVEPWDvSdxBGwNgB2Cl5zCa/x1hjWZmwwqfbVLZMV7lP0hJRwnDvvHZzp+2EZNDHTCigJeRR5R2AFyGRrDfdNynvPTcny/YdFw05iyFdQ2Qx9L0QEVSJOT0XcDJ6kTLDOek59Wj8H0uohUNpQe7H0PGVH1i2DBq2+LuGlfOkHXQBMLPdxAMq9NUevzJ75yufH7+cwriAuIqO8kzBkFPo/PHcZnHOJ4sj9+AoBMv6sZgT4gHbuEgiqy6L5QquIfjOGJchScYQwOgvVuNdMGjn4GbKmEtFA2+TSB4G9HC2o/NYjuogis+vYzplwteJNFh2gRRxeq4MWJ8e+kV9CVygFDhHuwiQL5UE4FKh1keK1t266Xudm09VADM9cKkjAQfYGM6xzh4eMHkrqsTk9Gwuo4Zf8m1QbQqualmik8JFbGVi+XeTFuCQR9mkEqR0h4Qoh7ribVMO3scVS9PcLixW766630MLYGgG8xeOPW1w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199015)(478600001)(66946007)(6506007)(86362001)(66556008)(4326008)(66476007)(186003)(966005)(8676002)(31696002)(26005)(2906002)(5660300002)(41300700001)(316002)(36756003)(31686004)(54906003)(6486002)(6916009)(2616005)(6512007)(8936002)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekJIalJIUTFtdnQxSHU5UjlYRkhISy9TNVdkQmVUYXhicEdIaStWSEJtbVZy?= =?utf-8?B?OGlERmRZUnNqMlp2MlEwYTV1ZDZoSEE4MnRkeG9Uemc1QzNkYWpsNk56ZlNG?= =?utf-8?B?TmdFd21EaXpPdW9Ua3BVSE1SRnVIQWYzSHk3NFIxeitVV3JiK1ZtdjdHZkx3?= =?utf-8?B?RjJ5VmxmbVlrdUY5eXZIcVJaRERLTUsxU09yTkNoK0IyZGtwandnRXZPa3o2?= =?utf-8?B?SG93TWIveDltSllYeWpIQXFNbDR1VVl3MStuY0JQczBwNjlpSDFTTkp2NzBP?= =?utf-8?B?QkRiTmFjU2lJSDR1bC9Nd1JYYUxCTVc1eTY3SDh0U2o3UUFraWhaWFBlNFRi?= =?utf-8?B?dHVHL1ZHa09lTm0zcndsSW00Rnc1MnIyblVRdEswWXVzZldyQUNPaGRqUmJy?= =?utf-8?B?Z2V1Q2ltWkFNQ0Q0aUNTNGpka1c5MTNaWk1Zcm11U3E1c1pGMnpOd041cnp4?= =?utf-8?B?WWdLOWpWcFVGZi9sckJYNFB1UXdQQnJHVWQvdVpveXN5alQ5TkFFQ2hXbEp4?= =?utf-8?B?ZTl2MHBZdVpOVm5VZVl4MDNBUFpKR3U0UE5pYnpydDZZOWhqT1ZMbGtrTytY?= =?utf-8?B?QzU3aW1ITXpjK2pJNkFidm8zSmpDdnFHaGVESlZnWldjc2o5UThYNldFaGhp?= =?utf-8?B?cjgvcVdkTHc3OGlMalZ2WGptOGg5WlM3ajJic2Nhck5nMklKdWJvcFNyc1lK?= =?utf-8?B?d1oxc2FMVnNPYndLWUZSN25SM1RYZ0VxOTVzRDRuOEI5SkRjbnZ0c2E4MUFH?= =?utf-8?B?VUdzL1RHVTNjMEc4MndlSDJTUkJhV0FSL2dRbVJVcHlDUlJGV2c2dGRoVFpv?= =?utf-8?B?aHRsWEhDa21CaFgwbkh2Vkc0c2kzbEVSWmRvemNUSG50ZjZKTmVwMFdKYTNz?= =?utf-8?B?Q3IxUXk1U1BxWG10MENwb2hVbEx3SHJYZkhBenA2eExnSEJid3NMcHFmc2lT?= =?utf-8?B?eUJUZHpyR0w0b0VnY2RTRlpaUlgzTVpJTm9HZ2N5SnBQb0cwYUhJMDdPSjFV?= =?utf-8?B?cHlqN1paYW0yWmIwTExoSjBxMHBHM1ZZZFB6TTFNQnk5WWt2ZDc4MEdRa1Bh?= =?utf-8?B?bEZuMXhFZ0N6cXNtMWxJeFlwSGtuaGtKUnB2RFFiSU0vNTBhdDh6ZDNDVXF5?= =?utf-8?B?akdtSWNkSEZpd09rWktjenBKTUpJSnhDVWZPcnh4SUkzMHBQWXgvcitjWHlR?= =?utf-8?B?c2FkYzU2VHAxWlM0dHFhc3lMUDBsL05XekFScnhFWkhOREhiVUt4Q0l1Q21K?= =?utf-8?B?ZjRzTFREUTZuQ1lCRXluVjBTOUYyQ0VXZWQyakJiNVBZL3pvbnk2NEpCQmpj?= =?utf-8?B?YXpReGNLdzVta1BSQmw5SERjN1ZmbndSQVV4WVJTQlhuZFkxVTc3YVRHN3U5?= =?utf-8?B?QWs4N3U3S1kvU25nbysyRFRBOGtiQXFxS0RISEVHOWgzbGdSZGpaaE1SdDB2?= =?utf-8?B?TndzcGw5bWEvbnVHeTUzRUtscUF1aUV4VkZCRldsTXJPTDA5UmhsbUMrUWNx?= =?utf-8?B?N0ZnMVl1THNXRDVFeUgxRnUwWEord20rRWNYTjQ1Vnd0UnFYQU95cVhTMGlh?= =?utf-8?B?d09LODlWRTRMcjJJV1JjV25nNkQvMFN4T3pUaXVRMlFlS2VDNkMyRTJSMU9B?= =?utf-8?B?ZWNPT3lRcS9GMWNFRzQ0YVFUYTNJNTh1NytlaHhZMDJELzJucXg0VDVxckNt?= =?utf-8?B?dFV5U0RuRkJCVUtJNFVRaGVyVUhWUy9HeHAzcVo3Vk1RK0ZFSURoVEcxM2Vr?= =?utf-8?B?dGtobUYyOTR4eVB0WkZQZXd5a1o2TnRabnhyZVBGeEVsRGRmZTJTTnZKNEF6?= =?utf-8?B?ai9HeUFFWk1yRGR0N0lsU2RtMDZ3cEorZEN1OGlrWnB2Si9TUHJ0c25jQWFG?= =?utf-8?B?clVURUc4MDFWM0k4aFNFbEpyUGd1MWhBZjh5ZXRsTnFpWVIydDU2ZTc5czZI?= =?utf-8?B?WU8wZ0dEbnVqTXFGUmFUSi9ETUFkT1o3OU5mbFZEcG5HSm0wVGtQY3NmZW5r?= =?utf-8?B?U3VXTnVIZGJETnJmaUsybkYzb21YQTg3REg3bTIwVkNzdktSR2NlbnBZMkVM?= =?utf-8?B?TlFyVlhzbUYvN3I3SUJNdmxFZ053cUNMQis4bng0cjdZak9BZERaNFZwR2d1?= =?utf-8?Q?3IZAg/B7atlZGPf9rA/pjAz2z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b278b8f7-2b5b-46e5-d5ff-08da9701bea7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 10:04:57.7340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c52ffJPoYHPEnGlIUWdDCLvjwOKAshFp69NI3udwSq/rIufnxYzlbZbQWL75jhJYwVxiUkUGOK7F7NBx46YaAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7474 [1] specifies a long list of instructions which are intended to exhibit timing behavior independent of the data they operate on. On certain hardware this independence is optional, controlled by a bit in a new MSR. Provide a command line option to control the mode Xen and its guests are to operate in, with a build time control over the default. Longer term we may want to allow guests to control this. Since Arm64 supposedly also has such a control, put command line option and Kconfig control in common files. [1] https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html Requested-by: Demi Marie Obenour Signed-off-by: Jan Beulich --- This may be viewed as a new feature, and hence be too late for 4.17. It may, however, also be viewed as security relevant, which is why I'd like to propose to at least consider it. Slightly RFC, in particular for whether the Kconfig option should default to Y or N. I would have wanted to invoke setup_doitm() from cpu_init(), but that works only on the BSP. On APs cpu_init() runs before ucode loading. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -746,6 +746,14 @@ Specify the size of the console debug tr additionally a trace buffer of the specified size is allocated per cpu. The debug trace feature is only enabled in debugging builds of Xen. +### dit (x86) +> `= ` + +> Default: `CONFIG_DIT_DEFAULT` + +Specify whether Xen and guests should operate in Data Independent Timing +mode. + ### dma_bits > `= ` --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -14,6 +14,7 @@ config X86 select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ + select HAS_DIT select HAS_EHCI select HAS_EX_TABLE select HAS_FAST_MULTIPLY --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -209,6 +209,24 @@ void ctxt_switch_levelling(const struct alternative_vcall(ctxt_switch_masking, next); } +static void setup_doitm(void) +{ + uint64_t msr; + + if ( !cpu_has_arch_caps ) + return; + + rdmsrl(MSR_ARCH_CAPABILITIES, msr); + if ( !(msr & ARCH_CAPS_DOITM) ) + return; + + rdmsrl(MSR_UARCH_MISC_CTRL, msr); + msr |= UARCH_CTRL_DOITM; + if ( !opt_dit ) + msr &= ~UARCH_CTRL_DOITM; + wrmsrl(MSR_UARCH_MISC_CTRL, msr); +} + bool_t opt_cpu_info; boolean_param("cpuinfo", opt_cpu_info); @@ -581,6 +599,8 @@ void identify_cpu(struct cpuinfo_x86 *c) mtrr_bp_init(); } + + setup_doitm(); } /* leaf 0xb SMT level */ --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -37,6 +37,9 @@ config HAS_COMPAT config HAS_DEVICE_TREE bool +config HAS_DIT # Data Independent Timing + bool + config HAS_EX_TABLE bool @@ -171,6 +174,18 @@ config SPECULATIVE_HARDEN_GUEST_ACCESS endmenu +config DIT_DEFAULT + bool "Data Independent Timing default" + depends on HAS_DIT + help + Hardware often surfaces instructions the timing of which is dependent + on the data they process. Some of these instructions may be used in + timing sensitive environments, e.g. cryptography. When such + instructions exist, hardware may further surface a control allowing + to make the behavior of such instructions independent of the data + they act upon. Choose the default here when no "dit" command line + option is present. + config HYPFS bool "Hypervisor file system support" default y --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -463,6 +463,11 @@ static int __init cf_check param_init(vo __initcall(param_init); #endif +#ifdef CONFIG_HAS_DIT +bool __ro_after_init opt_dit = IS_ENABLED(CONFIG_DIT_DEFAULT); +boolean_param("dit", opt_dit); +#endif + # define DO(fn) long do_##fn #endif --- a/xen/include/xen/param.h +++ b/xen/include/xen/param.h @@ -184,6 +184,8 @@ extern struct param_hypfs __paramhypfs_s string_param(_name, _var); \ string_runtime_only_param(_name, _var) +extern bool opt_dit; + static inline void no_config_param(const char *cfg, const char *param, const char *s, const char *e) { From xen-devel-bounces@lists.xenproject.org Thu Sep 15 10:14:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 10:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407311.649764 (Exim 4.92) (envelope-from ) id 1oYltJ-0000QU-VJ; Thu, 15 Sep 2022 10:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407311.649764; Thu, 15 Sep 2022 10:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYltJ-0000QN-Sa; Thu, 15 Sep 2022 10:14:41 +0000 Received: by outflank-mailman (input) for mailman id 407311; Thu, 15 Sep 2022 10:14:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYltJ-0000QD-8W; Thu, 15 Sep 2022 10:14:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYltJ-0003Kx-53; Thu, 15 Sep 2022 10:14:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYltI-0007rE-Rp; Thu, 15 Sep 2022 10:14:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYltI-0003Dd-RO; Thu, 15 Sep 2022 10:14:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TDmFyMTNv9zPiBCi+gZ4TtYAbZKbPDPNuX3jAu+TrOg=; b=fOLLl3xPJDpqDOX46hkKSlatdL nEdMhoSCDtc6oaKjSm9kIcIIjfvnonotV6j0J6m6lS62WMZIkTu0fnOFqoeDNkxedJhMYWeKtu756 KcQ4BeqsVOvD3snPjUFcAh+ubeEUTjNTXLjIMVtohNPdcBZZVjGJtW8jqodX3lLiNuL8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173205: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c83c6e4e7a68767ba69159bc0316884fa81158c4 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 15 Sep 2022 10:14:40 +0000 flight 173205 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173205/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c83c6e4e7a68767ba69159bc0316884fa81158c4 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 797 days Failing since 151818 2020-07-11 04:18:52 Z 796 days 778 attempts Testing same since 173205 2022-09-15 04:20:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122980 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 10:20:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 10:20:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407319.649774 (Exim 4.92) (envelope-from ) id 1oYlz1-0001vm-KA; Thu, 15 Sep 2022 10:20:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407319.649774; Thu, 15 Sep 2022 10:20:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlz1-0001vf-Hd; Thu, 15 Sep 2022 10:20:35 +0000 Received: by outflank-mailman (input) for mailman id 407319; Thu, 15 Sep 2022 10:20:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYlz0-0001vZ-9m for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 10:20:34 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08114123-34e0-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 12:20:33 +0200 (CEST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D8BDC338F0; Thu, 15 Sep 2022 10:20:32 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id A437F132BD; Thu, 15 Sep 2022 10:20:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id oDKvJnD8ImP5NQAAGKfGzw (envelope-from ); Thu, 15 Sep 2022 10:20:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08114123-34e0-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663237232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HhCePKYJ0tLeg3/2ELCexaxAxIag9Q8crxOOmoxZ4DI=; b=OSVd22bhANnJOZaYiZ5Lfb723Nx8fgTdw6AY7I/f5Lifn1KSGFPXFv9iMFGAdfEh8kjp79 +W4tQLQgQSoLkZd/wtpqjc4lE/N+XDleuNsOSjMYei7zJZhaYWAFsy1LnvpW4FLZZ8v8X4 QgEoRNgoRBiYNc0N3dsOo/65JWbqwAI= Message-ID: <4a95c3d1-d4e8-9b59-8db8-231b59cdb8f5@suse.com> Date: Thu, 15 Sep 2022 12:20:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap() Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20220915083944.10097-1-jgross@suse.com> <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> From: Juergen Gross In-Reply-To: <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Q7QhaY2nHUQ8dW2e63hvwHvn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Q7QhaY2nHUQ8dW2e63hvwHvn Content-Type: multipart/mixed; boundary="------------zOFfHkeq8k55aRjmtD0rMPzf"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <4a95c3d1-d4e8-9b59-8db8-231b59cdb8f5@suse.com> Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap() References: <20220915083944.10097-1-jgross@suse.com> <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> In-Reply-To: <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> --------------zOFfHkeq8k55aRjmtD0rMPzf Content-Type: multipart/mixed; boundary="------------di5Y7bRE4bzUsm9soBTDm6Mu" --------------di5Y7bRE4bzUsm9soBTDm6Mu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDkuMjIgMTE6MzIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxNS4wOS4yMDIy IDEwOjM5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVGhlIElPQ1RMX1BSSVZDTURfTU1B UCBpc24ndCBpbiB1c2UgYnkgWGVuIHNpbmNlIGF0IGxlYXN0IFhlbiA0LjAuDQo+Pg0KPj4g UmVtb3ZlIGl0IGZyb20gdGhlIHByaXZjbWQgZHJpdmVyLg0KPj4NCj4+IFNpZ25lZC1vZmYt Ynk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gDQo+IENhbiB3ZSByZWFz b25hYmx5IHJlbW92ZSBhbiBJT0NUTCwgd2l0aG91dCBiZWluZyBlbnRpcmVseSBjZXJ0YWlu IHRoYXQNCj4gbm8gdXNlcnMgZXhpc3Qgb3V0c2lkZSBvZiB4ZW4uZ2l0Pw0KDQpUaGlzIGlz IGEgdmFsaWQgcXVlc3Rpb24uIEknbSBub3Qgc3VyZSBob3cgcHJvYmFibGUgaXQgaXMgdGhh dCBzdWNoIGEgdXNlcg0KaXMgZXhpc3RpbmcuIEFyZSB0aGVyZSBhbnkgWGVuIHRvb2wgc3Rh Y2tzIG5vdCB1c2luZyB0aGUgWGVuIGxpYnJhcmllcz8NCg0KSWYgc28sIHdoeT8gRG8gd2Ug d2FudCB0byBzdXBwb3J0IHRob3NlIHVzZSBjYXNlcz8NCg0KPiBFdmVuIGlmIHNvLCBzaG91 bGRuJ3QgdGhlcmUgYmUgYQ0KPiBzdGFnZWQgZGVwcmVjYXRpb24gcHJvY2Vzcz8NCg0KRGVw ZW5kcyBvbiB0aGUgYW5zd2VyIHRvIGFib3ZlIHF1ZXN0aW9ucy4NCg0KDQpKdWVyZ2VuDQo= --------------di5Y7bRE4bzUsm9soBTDm6Mu Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------di5Y7bRE4bzUsm9soBTDm6Mu-- --------------zOFfHkeq8k55aRjmtD0rMPzf-- --------------Q7QhaY2nHUQ8dW2e63hvwHvn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMi/HAFAwAAAAAACgkQsN6d1ii/Ey+J Wwf/dqSi4udORAWWWkoB3jGSosa2tXXbXdxOUQdfbXCM6UQwer9J+Gu/IjD6ArMFIeUKMRJEf4bM CHAB+rZRg6RTWFqESi64lETQoLf1XPZo6/+sdjZQt/cragMrtZ2dYlVxqrSZLmNVUSxMAn8a72qI On6qu2/ZhCGI7+z8r5St8jmlMiExXAshh3zGn6Y80M6evONXEVJNAPgLioH+AZ2xmBo5Nhd0aFjA v+cMl1CUxv5z9ORAaEHgEwJ/enYopNz4laAdvFC+LyHmBK++REXER5FOuB5RSUNFF4JTu4Ec+GEu qfvlstLzE+9YxdnkytM4bQ1/KLQhF9WxG7adZkI+Tw== =ozXT -----END PGP SIGNATURE----- --------------Q7QhaY2nHUQ8dW2e63hvwHvn-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 11:12:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 11:12:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407325.649786 (Exim 4.92) (envelope-from ) id 1oYmmk-0007cY-EA; Thu, 15 Sep 2022 11:11:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407325.649786; Thu, 15 Sep 2022 11:11:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYmmk-0007cR-Ax; Thu, 15 Sep 2022 11:11:58 +0000 Received: by outflank-mailman (input) for mailman id 407325; Thu, 15 Sep 2022 11:11:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYmmi-0007cH-Qz; Thu, 15 Sep 2022 11:11:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYmmi-0004Hy-P1; Thu, 15 Sep 2022 11:11:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYmmi-0002tM-6w; Thu, 15 Sep 2022 11:11:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYmmi-0007tA-6R; Thu, 15 Sep 2022 11:11:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yu/n8RN8gOFRe8hJwZVXBUVbxGog7oMoRsf4AbDWvQI=; b=sRhrovOFGNYh3y32LfRCSbH5f8 MdEZ9+o49sXeW1Sh05QnWcYJ5tt8ZrZ0I/2zBVVs2bSkXihPGOp+y/X/JXwMs+7k38VyceUEMLTdm +YGs0QQn9bEirvA0+Ll+K/SWVKU6QJtHzbgNgeDgQ/UyE1bga47NvRO4NtZsS8tCAxYI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173201: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3245cb65fd91cd514801bf91f5a3066d562f0ac4 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 15 Sep 2022 11:11:56 +0000 flight 173201 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3245cb65fd91cd514801bf91f5a3066d562f0ac4 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 42 days Failing since 172152 2022-08-05 04:01:26 Z 41 days 93 attempts Testing same since 173191 2022-09-14 11:10:31 Z 0 days 2 attempts ------------------------------------------------------------ 1779 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182803 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 11:25:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 11:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407332.649797 (Exim 4.92) (envelope-from ) id 1oYmzN-0000vI-OK; Thu, 15 Sep 2022 11:25:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407332.649797; Thu, 15 Sep 2022 11:25:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYmzN-0000vB-Ki; Thu, 15 Sep 2022 11:25:01 +0000 Received: by outflank-mailman (input) for mailman id 407332; Thu, 15 Sep 2022 11:25:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYmzM-0000v5-A9 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 11:25:00 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 065ad3bc-34e9-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 13:24:57 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5653F5C00F7; Thu, 15 Sep 2022 07:24:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 15 Sep 2022 07:24:55 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 07:24:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 065ad3bc-34e9-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663241095; x=1663327495; bh=t+5vlnNWFl 2cjjReriBwLnwpXRazfTk790i5QhRRZaA=; b=v7tTZRGgEJqA3Pz+g2giCGbDVu 7APyzzCJxaI6Bkb52fI/BZvhLqpuFhoNmzxSE2fp9CqIfVCzw53WkcWn4xFK+GRU p2BmvZbYUHhraxPe44HEY5ClIzPltANy7dc2Bo3o4HXrzvOF3xwQkkNhitR3iPMT gnCy7Eglr2IqoMpw0gegb59JeGAAyB1toylMkvvU5TvRvHAP1PgU2iqfjYr5x3mv JI3oFPgeTKNbzn+TCmMLkN8x5znFaKtbyp8vpJE8OxwEbacR26AKLONMwlbHpYVF 8bX6vfACWDvbAxht9rV9i67EjIIPsvTJ4uDjAVNcBdFp94NlFxp6CTjZE29w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663241095; x= 1663327495; bh=t+5vlnNWFl2cjjReriBwLnwpXRazfTk790i5QhRRZaA=; b=Z e9rQ101PeXDYpED+/5tfpQ+eS4R/80rz8/W+oxnKQa0CE6d1Y2nkHF3Hv10LCQt3 9CgIgHvq4CSOll6VPHL2SY6ek7JjSEss3/r8aUZ9v+fAYzOfU7Cq6eRKQ0NzvuSN +iqkLPWoZUutIqqhhwa0Pk5+4R3tlLoSG4f98ZmOkD6P9DL8HFNPWm6n7ZTMtL+q QQ/TfeTYKTLZ/lUws9svU0ZcPllSI4NDGfzWvZnY4cmSOD+TrSzZrTtPxiV5+dgr 69GnsJS4wJNntxUuTr/2zgVb0Y7uVHQ04vMQISZoQnAsUPzq5WaSn8rhfoTchGcG kETDfY/VOQWjko4Qsu61Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtgfgjgesthhqredttddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepieegtefggfektefhvdeuudeuieff heekuefhgeeilefgieehleduueetveefteejnecuffhomhgrihhnpehinhhtvghlrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggv mhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 15 Sep 2022 07:24:51 -0400 From: Demi Marie Obenour To: Jan Beulich , "xen-devel@lists.xenproject.org" , Qubes OS Development Mailing List Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Henry Wang , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; x-action=pgp-signed Content-Transfer-Encoding: quoted-printable In-Reply-To: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Thu, Sep 15, 2022 at 12:04:55PM +0200, Jan Beulich wrote: > [1] specifies a long list of instructions which are intended to exhibit > timing behavior independent of the data they operate on. On certain > hardware this independence is optional, controlled by a bit in a new > MSR. Provide a command line option to control the mode Xen and its > guests are to operate in, with a build time control over the default. > Longer term we may want to allow guests to control this. >=20 > Since Arm64 supposedly also has such a control, put command line option > and Kconfig control in common files. >=20 > [1] https://www.intel.com/content/www/us/en/developer/articles/technical/= software-security-guidance/best-practices/data-operand-independent-timing-i= sa-guidance.html >=20 > Requested-by: Demi Marie Obenour > Signed-off-by: Jan Beulich Thanks for the patch, Jan! > This may be viewed as a new feature, and hence be too late for 4.17. It > may, however, also be viewed as security relevant, which is why I'd like > to propose to at least consider it. I consider it security relevant indeed, which is why I was so insistent on it. Whether it is worth a full XSA is up to the Xen Security Team. If it could be backported to stable releases, that would be great. Marek, Simon, would you consider backporting this to R4.1? > Slightly RFC, in particular for whether the Kconfig option should > default to Y or N. I think it should default to Y as long as guests do not have the ability to control this. Otherwise any cryptographic code in the guests thinks it is constant time when it may not be. Once guests have the ability to control this I would be open to reconsidering this. - --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMjC4MACgkQsoi1X/+c IsELUg//fTRCauj/woVL8a3NpcB/2T2/gM06Lhg/eT7DsW4aJEIinB+jZ1mQ4oUb MWEe3Ljwo0bxhbWbbQt2Xqp0pRM1MsDT7D0Boe0qEbpFYCgs8NrRvNE+MrtXG24x B+2E/KZBIesjLV26S3uWTItHfUiFbqo5xzJURCDNHZqZiDnvCs4adiCMNDfroXyL 4UnP1slglrL/x/WqU9VKsWOOJAHTId2cBFd5FDlCQ7UX/GQISUIk7NZqCvutbtny nJpSlbYoUcuQ3IfB4S7zDE4sN2YatCDqojZsAYuwRCRCRgM4nmZJUvK5KwzR1k6Z 0DfvZ0R4h5gdSrylqABzteEwLbob2icXxY89QHhssh/737R0HE5sRK2HKOPRZgUz bmdlismQMqAuzUceAFreIGoPsIQUongF2xZJIY6AtGLudvaB8GZVyeJCgvH/eYyA N05zybw3brLDgTjLN+HXTtsH4X7t4/ktCbGCLZWUytu5h4tr/wg/IXhd84uCu88n 3oLHLuqtpJUNItDYSmLSNQ7KO3Py4pbGjV7ienUl4fGpLS9MKG6raCTj12xO5nq8 5C/vMuzCRiJF3lEvHOrkVjH7vANk/8pfnqoHoMHs4lM2QnlskdOsjCPa17ZZWHs0 knT9OrN4hL7GgA2aU33rfhvgtDq6p7n5Xg2+YbNAbj7lSydjSho=3D =3Ddfry -----END PGP SIGNATURE----- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 11:44:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 11:44:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407336.649808 (Exim 4.92) (envelope-from ) id 1oYnHy-0003LC-C3; Thu, 15 Sep 2022 11:44:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407336.649808; Thu, 15 Sep 2022 11:44:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYnHy-0003L5-7U; Thu, 15 Sep 2022 11:44:14 +0000 Received: by outflank-mailman (input) for mailman id 407336; Thu, 15 Sep 2022 11:44:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYnHw-0003Kv-S5; Thu, 15 Sep 2022 11:44:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYnHw-0004nS-Pk; Thu, 15 Sep 2022 11:44:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYnHw-0004sU-H4; Thu, 15 Sep 2022 11:44:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYnHw-0004g0-GV; Thu, 15 Sep 2022 11:44:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dexvDYh3o1EZqvyvbK8hWG1mGhCTxkFB8Ny9l01Q8CU=; b=r9t8MIU/a+03LA+Vk6FSONit+H MZDcHNiwJ3Z1drHgRUweIkBwTgs9DLkTYldLKHstA7blQ6//3unukBEMvrJqsMdmvv5BSTcP5BN0S OSVKbIXL/+5VS7yssb7JRBV9fC6U+3BF510+Oo2Kp7CtqqHDqT9F8MZtx+5Zt4I3j1cE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173208: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=1dccbd1a382aa57719e4e0432b3bd6a03a888507 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 11:44:12 +0000 flight 173208 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173208/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 1dccbd1a382aa57719e4e0432b3bd6a03a888507 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 42 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 312 attempts Testing same since 173208 2022-09-15 05:35:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2523 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 11:56:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 11:56:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407342.649819 (Exim 4.92) (envelope-from ) id 1oYnTv-0004zl-E0; Thu, 15 Sep 2022 11:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407342.649819; Thu, 15 Sep 2022 11:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYnTv-0004ze-B6; Thu, 15 Sep 2022 11:56:35 +0000 Received: by outflank-mailman (input) for mailman id 407342; Thu, 15 Sep 2022 11:56:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYnTt-0004zV-Jp for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 11:56:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70c90343-34ed-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 13:56:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD9E41F88D; Thu, 15 Sep 2022 11:56:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A3E6213A49; Thu, 15 Sep 2022 11:56:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l3iIJu8SI2OrNQAAMHmgww (envelope-from ); Thu, 15 Sep 2022 11:56:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70c90343-34ed-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663242991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/og/nJIu9CtXSSOQWEO2KGDGYXfSlySFkKWBQQPtySk=; b=ulp3LGXigxWDVOVFIaLjB8Qvy7Pu/bnWitzuO3UcPHTcv4nhlM1rN8Ld3uKMDD9xczh7HC q+OBB/SD+9IYqxnA8YDBgoMVkft1lNZ02oAvOzQN4d+ux3HIJ3X1O3/hNkTYMbNwcZgHnU 0cXR6u6hs2r87tW/eH1EKxvS2/luQgg= Message-ID: <3bc938e9-c00e-577c-38be-f0d345dd1524@suse.com> Date: Thu, 15 Sep 2022 13:56:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 2/2] xen/gnttab: reduce size of struct active_grant_entry Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220913093256.22880-1-jgross@suse.com> <20220913093256.22880-3-jgross@suse.com> <232141b4-88ab-34d4-389d-e354f15e56ef@suse.com> From: Juergen Gross In-Reply-To: <232141b4-88ab-34d4-389d-e354f15e56ef@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HSj2JuEAjAHa5Jnfnrz07YjZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HSj2JuEAjAHa5Jnfnrz07YjZ Content-Type: multipart/mixed; boundary="------------wIVk9Pedx3FzXTWYpkpLcqoN"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <3bc938e9-c00e-577c-38be-f0d345dd1524@suse.com> Subject: Re: [PATCH v2 2/2] xen/gnttab: reduce size of struct active_grant_entry References: <20220913093256.22880-1-jgross@suse.com> <20220913093256.22880-3-jgross@suse.com> <232141b4-88ab-34d4-389d-e354f15e56ef@suse.com> In-Reply-To: <232141b4-88ab-34d4-389d-e354f15e56ef@suse.com> --------------wIVk9Pedx3FzXTWYpkpLcqoN Content-Type: multipart/mixed; boundary="------------ND74CCRPSZodvN0km9mi3mBW" --------------ND74CCRPSZodvN0km9mi3mBW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDkuMjIgMTM6NTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMy4wOS4yMDIy IDExOjMyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVGhlIHNpemUgb2Ygc3RydWN0IGFj dGl2ZV9ncmFudF9lbnRyeSBmb3IgNjQtYml0IGJ1aWxkcyBpcyA0MCBvciA0OA0KPj4gYnl0 ZXMgdG9kYXkgKHdpdGggb3Igd2l0aG91dCBOREVCVUcpLg0KPj4NCj4+IEl0IGNhbiBlYXNp bHkgYmUgcmVkdWNlZCBieSA4IGJ5dGVzIGJ5IHJlcGxhY2luZyB0aGUgdHJhbnNfZG9tYWlu DQo+PiBwb2ludGVyIHdpdGggdGhlIGRvbWlkIG9mIHRoZSByZWxhdGVkIGRvbWFpbi4gdHJh bnNfZG9tYWluIGlzIG9ubHkgZXZlcg0KPj4gdXNlZCBmb3IgdHJhbnNpdGl2ZSBncmFudHMs IHdoaWNoIGRvZXNuJ3QgaGF2ZSBhbnkga25vd24gdXNlcnMuDQo+Pg0KPj4gVGhpcyByZWR1 Y3Rpb24gd2lsbCByZXN1bHQgaW4gbGVzcyBtZW1vcnkgdXNhZ2UgYW5kIChmb3IgcHJvZHVj dGlvbg0KPj4gYnVpbGRzKSBpbiBmYXN0ZXIgY29kZSwgYXMgaW5kZXhpbmcgaW50byB0aGUg YWN0aXZlX2dyYW50X2VudHJ5IGFycmF5DQo+PiB3aWxsIGJlIG11Y2ggZWFzaWVyIHdpdGgg YW4gZW50cnkgaGF2aW5nIGEgcG93ZXItb2YtMiBzaXplLg0KPj4NCj4+IFRoZSBwZXJmb3Jt YW5jZSBsb3NzIHdoZW4gdXNpbmcgdHJhbnNpdGl2ZSBncmFudHMgc2hvdWxkbid0IHJlYWxs eQ0KPj4gbWF0dGVyLCBnaXZlbiB0aGUgcHJvYmFiaWxpdHkgdGhhdCB0aG9zZSBhcmVuJ3Qg aW4gdXNlIGF0IGFsbC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IFYyOg0KPj4gLSByZW5hbWUgdHJhbnNfZG9t aWQgdG8gc3JjX2RvbWlkIChKYW4gQmV1bGljaCkNCj4+IC0tLQ0KPj4gICB4ZW4vY29tbW9u L2dyYW50X3RhYmxlLmMgfCAxMyArKysrKysrLS0tLS0tDQo+PiAgIDEgZmlsZSBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBh L3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYyBiL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYw0K Pj4gaW5kZXggZmJhMzI5ZGNjMi4uNTkzNDJkZjNiNyAxMDA2NDQNCj4+IC0tLSBhL3hlbi9j b21tb24vZ3JhbnRfdGFibGUuYw0KPj4gKysrIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5j DQo+PiBAQCAtMzgxLDEzICszODEsMTMgQEAgc3RydWN0IGFjdGl2ZV9ncmFudF9lbnRyeSB7 DQo+PiAgIH0pDQo+PiAgIA0KPj4gICAgICAgZG9taWRfdCAgICAgICBkb21pZDsgIC8qIERv bWFpbiBiZWluZyBncmFudGVkIGFjY2Vzcy4gICAgICAgICAgICAgKi8NCj4+ICsgICAgZG9t aWRfdCAgICAgICBzcmNfZG9taWQ7IC8qIERvbWFpbiBncmFudGluZyBhY2Nlc3MuICAgICAg ICAgICAgICAgKi8NCj4gDQo+IEknbSBhZnJhaWQgSSBzdGlsbCB2aWV3IHRoZSBjb21tZW50 IGFzIGFtYmlndW91cywgZm9yIHRoZXJlIGJlaW5nIHR3bw0KPiBkb21haW5zIGludm9sdmVk IGluIGdyYW50aW5nIGFjY2VzcyBmb3IgdHJhbnNpdGl2ZSBncmFudHMuIFByZWZlcmFibHkN Cj4gd2l0aCBlLmcgIk9yaWdpbmFsIiBhZGRlZCAod2hpY2ggb2YgY291cnNlIGNvdWxkIGJl IGRvbmUgYnkgdGhlDQo+IGNvbW1pdHRlciwgcHJvdmlkZWQgdGhpcyBpc24ndCBsb3N0IGJ5 IHRoZSB0aW1lIDQuMTggb3BlbnMpLA0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFua3MuDQoNCkknbGwganVzdCBzZW5kIGFuIHVwZGF0 ZWQgVjMgKHByb2JhYmx5IHRvbW9ycm93KS4NCg0KDQpKdWVyZ2VuDQo= --------------ND74CCRPSZodvN0km9mi3mBW Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ND74CCRPSZodvN0km9mi3mBW-- --------------wIVk9Pedx3FzXTWYpkpLcqoN-- --------------HSj2JuEAjAHa5Jnfnrz07YjZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMjEu8FAwAAAAAACgkQsN6d1ii/Ey9g FQf+PDv4j82Elws+o63y/Hk7IZBKMdP+0P9DZ0R3SjuJwVag+HevqiU7SFP+ybTpOOX++tDuj1+i wp2N6Fk7UN90b4bOcRr9QKowInOcTrVXlCqpIKmDV5EKLW4n/M7z/iaEdD9yvmhs08PQ1BH/f8Ln pPYnEcoLlTtYfE1Fd5ScZrHjvdidNagdwh9RkT4rc4MA1JDO0sDJMR3B1g+02fNW0mdKL5n3UZDh nTze3ujvm2MuU2Y573KkkuGXJpaRWfhnXYmjjmULnlIoE8ZUADBFlYt5ZGxxxp0j8ApKgy8lGwjy By6iu+wg8pNDLiZqtFgL3nEoISrwNdoJy5Y71YHswQ== =jmdR -----END PGP SIGNATURE----- --------------HSj2JuEAjAHa5Jnfnrz07YjZ-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 12:49:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 12:49:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407351.649829 (Exim 4.92) (envelope-from ) id 1oYoJF-0002Gg-R7; Thu, 15 Sep 2022 12:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407351.649829; Thu, 15 Sep 2022 12:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYoJF-0002GZ-O4; Thu, 15 Sep 2022 12:49:37 +0000 Received: by outflank-mailman (input) for mailman id 407351; Thu, 15 Sep 2022 12:49:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYoJD-0002GT-VQ for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 12:49:36 +0000 Received: from server.eikelenboom.it (server.eikelenboom.it [91.121.65.215]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8f404a5-34f4-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 14:49:33 +0200 (CEST) Received: from 76-24-144-85.ftth.glasoperator.nl ([85.144.24.76]:53190 helo=[10.97.34.6]) by server.eikelenboom.it with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oYoIy-0006Te-Kw; Thu, 15 Sep 2022 14:49:20 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8f404a5-34f4-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type:Cc:To: Subject:From:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rF3bpi1+8UCL68aN7n0XDkI9TKmE1wkl48gvchSI0E8=; b=IlaidEycf+9ru/3eSfgD67ti63 ibDTEULdffpjoFdy95Xvpiiz7hmwvDe/tuxyY61vlemEov17pXDqyNUUlmSQlOibeaBBYy3LSlTMN b7iufNEaboQg+BIPUVW77NrH5QX5eOJ2ABYI260Sw46dgJkQ1rGpE2Z2HFMV9NVDCiUU=; Message-ID: Date: Thu, 15 Sep 2022 14:49:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: nl-NL From: Sander Eikelenboom Subject: Bisected: drivers/block/xen-blkback/xenbus.c:327 xen_blkif_disconnect+0x24f/0x260 To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, I'm having trouble booting my DomU's when trying to use a linux-5.19 kernel for both Dom0 and DomU. A dom0 5.19 kernel with a domU 5.18 kernel boots fine. I'm using durect kernel boot to boot the domU guest (kernel= and ramdisk= parameters). Since both xen-blkback and xen-blkfront could be into play, I bisected this by keeping dom0 fixed as a 5.19 kernel and do the bisecting on the domU kernel. Bisecting leads to commit 4573240f0764ee79d7558d74fc535baa1e110d20 "xen/xenbus: eliminate xenbus_grant_ring()" Reverting this specific commit makes the domU boot fine again. I have added the splat from dom0 kernel below (from using 5.19.8 kernel for both dom0 and domU), the domU does not seem to have any interessting logging, apart from not being able to find the root filesystem. Do you have any ideas ? -- Sander Dom0: [144007.320877] xen_bridge: port 3(vif17.0) entered blocking state [144007.320885] xen_bridge: port 3(vif17.0) entered disabled state [144007.320993] device vif17.0 entered promiscuous mode [144011.012144] xen-blkback: backend/vbd/17/51712: using 2 queues, protocol 1 (x86_64-abi) persistent grants [144011.014046] vbd vbd-17-51712: 9 mapping in shared page 9 from domain 17 [144011.015339] vbd vbd-17-51712: 2 mapping ring-ref port 13 [144011.016666] ------------[ cut here ]------------ [144011.016672] WARNING: CPU: 0 PID: 50 at drivers/block/xen-blkback/xenbus.c:327 xen_blkif_disconnect+0x24f/0x260 [144011.016687] Modules linked in: [144011.016691] CPU: 0 PID: 50 Comm: xenwatch Not tainted 5.19.8-20220913-doflr-mac80211debug+ #1 [144011.016695] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [144011.016698] RIP: e030:xen_blkif_disconnect+0x24f/0x260 [144011.016702] Code: 20 48 8d 56 20 48 8d 48 e0 48 3b 54 24 08 0f 84 a7 fe ff ff 4c 8b 74 24 10 48 89 4c 24 10 eb 82 0f 0b 0f 0b 0f 0b 0f 0b 0f 0b <0f> 0b e9 ef fe ff ff b8 f0 ff ff ff e9 34 ff ff ff 41 54 55 48 89 [144011.016705] RSP: e02b:ffffc90000847dd8 EFLAGS: 00010202 [144011.016708] RAX: 0000000000000040 RBX: 0000000000000001 RCX: ffff88802a03bc60 [144011.016710] RDX: 0000000000000000 RSI: 0000000000000200 RDI: 00000000ffffffff [144011.016711] RBP: ffff88802a03bc00 R08: 0000000000000001 R09: ffffffff82296a93 [144011.016713] R10: 00000000fffffffc R11: 00000000000222cd R12: 0000000000000000 [144011.016715] R13: ffff8880187d5000 R14: ffff88802a03bc40 R15: ffff88801caf0c00 [144011.016730] FS: 0000000000000000(0000) GS:ffff88807d200000(0000) knlGS:0000000000000000 [144011.016732] CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [144011.016740] CR2: 00007ffe03596084 CR3: 000000000adee000 CR4: 0000000000000660 [144011.016744] Call Trace: [144011.016744] [144011.016747] frontend_changed+0x3b2/0x470 [144011.016752] xenwatch_thread+0x9c/0x170 [144011.016757] ? cpu_core_flags+0x10/0x10 [144011.016764] ? find_watch+0x50/0x50 [144011.016766] kthread+0xe3/0x110 [144011.016773] ? kthread_complete_and_exit+0x20/0x20 [144011.016782] ret_from_fork+0x22/0x30 [144011.016785] [144011.016786] ---[ end trace 0000000000000000 ]--- [144011.016796] ------------[ cut here ]------------ [144011.016797] WARNING: CPU: 0 PID: 50 at drivers/block/xen-blkback/xenbus.c:327 xen_blkif_disconnect+0x24f/0x260 [144011.016801] Modules linked in: [144011.016802] CPU: 0 PID: 50 Comm: xenwatch Tainted: G W 5.19.8-20220913-doflr-mac80211debug+ #1 [144011.016805] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [144011.016806] RIP: e030:xen_blkif_disconnect+0x24f/0x260 [144011.016808] Code: 20 48 8d 56 20 48 8d 48 e0 48 3b 54 24 08 0f 84 a7 fe ff ff 4c 8b 74 24 10 48 89 4c 24 10 eb 82 0f 0b 0f 0b 0f 0b 0f 0b 0f 0b <0f> 0b e9 ef fe ff ff b8 f0 ff ff ff e9 34 ff ff ff 41 54 55 48 89 [144011.016811] RSP: e02b:ffffc90000847dd8 EFLAGS: 00010202 [144011.016813] RAX: 0000000000000040 RBX: 0000000000000001 RCX: ffff88802a03bdd8 [144011.016815] RDX: 0000000000000000 RSI: 0000000000000200 RDI: 00000000ffffffff [144011.016816] RBP: ffff88802a03bd78 R08: 0000000000000001 R09: ffffffff82296a93 [144011.016818] R10: 00000000fffffffc R11: 00000000000222cd R12: 0000000000000001 [144011.016819] R13: ffff8880187d5000 R14: ffff88802a03bdb8 R15: ffff88801caf0c00 [144011.016824] FS: 0000000000000000(0000) GS:ffff88807d200000(0000) knlGS:0000000000000000 [144011.016825] CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [144011.016827] CR2: 00007ffe03596084 CR3: 000000000adee000 CR4: 0000000000000660 [144011.016829] Call Trace: [144011.016831] [144011.016832] frontend_changed+0x3b2/0x470 [144011.016835] xenwatch_thread+0x9c/0x170 [144011.016837] ? cpu_core_flags+0x10/0x10 [144011.016840] ? find_watch+0x50/0x50 [144011.016842] kthread+0xe3/0x110 [144011.016844] ? kthread_complete_and_exit+0x20/0x20 [144011.016848] ret_from_fork+0x22/0x30 [144011.016851] [144011.016852] ---[ end trace 0000000000000000 ]--- [144011.154673] vif vif-17-0 vif17.0: Guest Rx ready [144011.154711] xen_bridge: port 3(vif17.0) entered blocking state [144011.154713] xen_bridge: port 3(vif17.0) entered forwarding state From xen-devel-bounces@lists.xenproject.org Thu Sep 15 12:56:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 12:56:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407359.649843 (Exim 4.92) (envelope-from ) id 1oYoPc-0003iq-Gm; Thu, 15 Sep 2022 12:56:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407359.649843; Thu, 15 Sep 2022 12:56:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYoPc-0003ij-E9; Thu, 15 Sep 2022 12:56:12 +0000 Received: by outflank-mailman (input) for mailman id 407359; Thu, 15 Sep 2022 12:56:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYoPb-0003id-3a for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 12:56:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYoPZ-0005zc-OQ; Thu, 15 Sep 2022 12:56:09 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.18.122]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oYoPZ-0003q8-Ge; Thu, 15 Sep 2022 12:56:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=eRKyrz5fVarARKgF6gqSbHQcFWNUcEEmQ2/Nmg7xrzo=; b=O0ikzSy2LZy4gqzcbi0XBXeMnM 25NG/3+z2fRpqAiEvjEUF/7qoKvnTqWBm4kIKq3Xx7x6knwFrynOSw1iT5eGrgA2tejWcAoIKsL7X GuJ6PYDdM2Mdan6qJhzdDzBwuI9nnCJF4HRKAtjWtfHhqR2iNrc5Oew5t2vHjrmTAzq0=; Message-ID: <006c5779-2ee5-0e37-1b00-c6c58ef57c71@xen.org> Date: Thu, 15 Sep 2022 13:56:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode Content-Language: en-US To: Demi Marie Obenour , Jan Beulich , "xen-devel@lists.xenproject.org" , Qubes OS Development Mailing List Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Simon Gaiser References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Demi, On 15/09/2022 12:24, Demi Marie Obenour wrote: > On Thu, Sep 15, 2022 at 12:04:55PM +0200, Jan Beulich wrote: >> [1] specifies a long list of instructions which are intended to exhibit >> timing behavior independent of the data they operate on. On certain >> hardware this independence is optional, controlled by a bit in a new >> MSR. Provide a command line option to control the mode Xen and its >> guests are to operate in, with a build time control over the default. >> Longer term we may want to allow guests to control this. > >> Since Arm64 supposedly also has such a control, put command line option >> and Kconfig control in common files. > >> [1] https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html > >> Requested-by: Demi Marie Obenour >> Signed-off-by: Jan Beulich > > Thanks for the patch, Jan! > >> This may be viewed as a new feature, and hence be too late for 4.17. It >> may, however, also be viewed as security relevant, which is why I'd like >> to propose to at least consider it. > > I consider it security relevant indeed, which is why I was so insistent > on it. Whether it is worth a full XSA is up to the Xen Security Team. > If it could be backported to stable releases, that would be great. > > Marek, Simon, would you consider backporting this to R4.1? > >> Slightly RFC, in particular for whether the Kconfig option should >> default to Y or N. > > I think it should default to Y as long as guests do not have the ability > to control this. This raises two questions: 1) What is the performance impact to turn this on by default? I am looking for actual numbers. 2) What happen on HW that doesn't support DIT? Are we going to mark them as unsupported? > Otherwise any cryptographic code in the guests thinks > it is constant time when it may not be. Why would a guest think that? Are we telling the guest DIT is supported but doesn't honour it? If yes, then I would argue that we should clear that bit. Otherwise... > Once guests have the ability to > control this I would be open to reconsidering this. ... this will introduce a problem once we expose it to the guest because we cannot change the global default as some user my start to rely on it on the default. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 15 13:10:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 13:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407365.649854 (Exim 4.92) (envelope-from ) id 1oYodH-0006Bd-P9; Thu, 15 Sep 2022 13:10:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407365.649854; Thu, 15 Sep 2022 13:10:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYodH-0006BW-M1; Thu, 15 Sep 2022 13:10:19 +0000 Received: by outflank-mailman (input) for mailman id 407365; Thu, 15 Sep 2022 13:10:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYodH-0006BQ-2O for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 13:10:19 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be7d9dcb-34f7-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 15:10:17 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 48AF31F8AE; Thu, 15 Sep 2022 13:10:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3331D13A49; Thu, 15 Sep 2022 13:10:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4MA9CzkkI2MTVwAAMHmgww (envelope-from ); Thu, 15 Sep 2022 13:10:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be7d9dcb-34f7-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663247417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C6UJ+Vo60tenYFuyHOS0X67/+j2cgnpWV9YLB3cVj6Y=; b=oOTPJHdplWuCa+G1vDrWgCv4V/OGwcaithsoh4FFisY4lLjE6gIzPLLLAavZE4bO4fSmor 1voBbcgidO4lU6Z4ZQ2AY4ow7bZaoAJEC3yX4aG/lILMSZ2vFU2DkcGLpgoZEl2nsqicI/ W08N+8C0osdN6+cHh2clP2srK0SXRGo= Message-ID: <17313adf-2881-9902-0d66-a4e723158434@suse.com> Date: Thu, 15 Sep 2022 15:10:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Sander Eikelenboom Cc: "xen-devel@lists.xenproject.org" References: From: Juergen Gross Subject: Re: Bisected: drivers/block/xen-blkback/xenbus.c:327 xen_blkif_disconnect+0x24f/0x260 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EBEDFISbmEqIMyHenYqnZVTS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EBEDFISbmEqIMyHenYqnZVTS Content-Type: multipart/mixed; boundary="------------C1hgxAGmeMgBIKo99LbrGa7g"; protected-headers="v1" From: Juergen Gross To: Sander Eikelenboom Cc: "xen-devel@lists.xenproject.org" Message-ID: <17313adf-2881-9902-0d66-a4e723158434@suse.com> Subject: Re: Bisected: drivers/block/xen-blkback/xenbus.c:327 xen_blkif_disconnect+0x24f/0x260 References: In-Reply-To: --------------C1hgxAGmeMgBIKo99LbrGa7g Content-Type: multipart/mixed; boundary="------------429UP0hUq6ZGG0HWvIvXMAC0" --------------429UP0hUq6ZGG0HWvIvXMAC0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDkuMjIgMTQ6NDksIFNhbmRlciBFaWtlbGVuYm9vbSB3cm90ZToNCj4gSGkgSnVl cmdlbiwNCj4gDQo+IEknbSBoYXZpbmcgdHJvdWJsZSBib290aW5nIG15IERvbVUncyB3aGVu IHRyeWluZyB0byB1c2UgYSBsaW51eC01LjE5IGtlcm5lbCBmb3IgDQo+IGJvdGggRG9tMCBh bmQgRG9tVS4NCj4gQSBkb20wIDUuMTkga2VybmVsIHdpdGggYSBkb21VIDUuMTgga2VybmVs IGJvb3RzIGZpbmUuDQo+IEknbSB1c2luZyBkdXJlY3Qga2VybmVsIGJvb3QgdG8gYm9vdCB0 aGUgZG9tVSBndWVzdCAoa2VybmVsPcKgIGFuZCByYW1kaXNrPSANCj4gcGFyYW1ldGVycyku DQo+IA0KPiBTaW5jZSBib3RoIHhlbi1ibGtiYWNrIGFuZCB4ZW4tYmxrZnJvbnQgY291bGQg YmUgaW50byBwbGF5LA0KPiBJIGJpc2VjdGVkIHRoaXMgYnkga2VlcGluZyBkb20wIGZpeGVk IGFzIGEgNS4xOSBrZXJuZWwgYW5kIGRvIHRoZSBiaXNlY3Rpbmcgb24gDQo+IHRoZSBkb21V IGtlcm5lbC4NCj4gDQo+IEJpc2VjdGluZyBsZWFkcyB0byBjb21taXQgNDU3MzI0MGYwNzY0 ZWU3OWQ3NTU4ZDc0ZmM1MzViYWExZTExMGQyMCAieGVuL3hlbmJ1czogDQo+IGVsaW1pbmF0 ZSB4ZW5idXNfZ3JhbnRfcmluZygpIg0KPiBSZXZlcnRpbmcgdGhpcyBzcGVjaWZpYyBjb21t aXQgbWFrZXMgdGhlIGRvbVUgYm9vdCBmaW5lIGFnYWluLg0KPiANCj4gSSBoYXZlIGFkZGVk IHRoZSBzcGxhdCBmcm9tIGRvbTAga2VybmVsIGJlbG93IChmcm9tIHVzaW5nIDUuMTkuOCBr ZXJuZWwgZm9yIGJvdGggDQo+IGRvbTAgYW5kIGRvbVUpLA0KPiB0aGUgZG9tVSBkb2VzIG5v dCBzZWVtIHRvIGhhdmUgYW55IGludGVyZXNzdGluZyBsb2dnaW5nLA0KPiBhcGFydCBmcm9t IG5vdCBiZWluZyBhYmxlIHRvIGZpbmQgdGhlIHJvb3QgZmlsZXN5c3RlbS4NCj4gDQo+IERv IHlvdSBoYXZlIGFueSBpZGVhcyA/DQoNCk91Y2guIFdoYXQgYSBzaWxseSwgc2lsbHksIHNp bGx5IGVycm9yIQ0KDQpEb2VzIHRoZSBhdHRhY2hlZCBwYXRjaCBmaXggaXQgZm9yIHlvdT8N Cg0KDQpKdWVyZ2VuDQo= --------------429UP0hUq6ZGG0HWvIvXMAC0 Content-Type: text/x-patch; charset=UTF-8; name="0001-xen-xenbus-fix-xenbus_setup_ring.patch" Content-Disposition: attachment; filename="0001-xen-xenbus-fix-xenbus_setup_ring.patch" Content-Transfer-Encoding: base64 RnJvbSAzOTA0NjFmM2ZiZGUwYTY1ZDE4ZTY1OTk5YTFiZDNkYjk4MzAxMzFiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClRvOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCkNjOiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+CkNjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtl cm5lbC5vcmc+CkNjOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVu a29AZXBhbS5jb20+CkNjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKRGF0ZTog VGh1LCAxNSBTZXAgMjAyMiAxNTowNTo0NSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHhlbi94 ZW5idXM6IGZpeCB4ZW5idXNfc2V0dXBfcmluZygpCgpDb21taXQgNDU3MzI0MGYwNzY0ICgi eGVuL3hlbmJ1czogZWxpbWluYXRlIHhlbmJ1c19ncmFudF9yaW5nKCkiKQppbnRyb2R1Y2Vk IGFuIGVycm9yIGZvciBpbml0aWFsaXphdGlvbiBvZiBtdWx0aS1wYWdlIHJpbmdzLgoKQ2M6 IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKRml4ZXM6IDQ1NzMyNDBmMDc2NCAoInhlbi94ZW5i dXM6IGVsaW1pbmF0ZSB4ZW5idXNfZ3JhbnRfcmluZygpIikKUmVwb3J0ZWQtYnk6IFNhbmRl ciBFaWtlbGVuYm9vbSA8bGludXhAZWlrZWxlbmJvb20uaXQ+ClNpZ25lZC1vZmYtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KLS0tCiBkcml2ZXJzL3hlbi94ZW5idXMv eGVuYnVzX2NsaWVudC5jIHwgOSArKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4veGVu YnVzL3hlbmJ1c19jbGllbnQuYyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50 LmMKaW5kZXggZDVmM2Y3NjM3MTdlLi5jYWE1YzVjMzJmOGUgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMKKysrIGIvZHJpdmVycy94ZW4veGVuYnVz L3hlbmJ1c19jbGllbnQuYwpAQCAtMzgyLDkgKzM4MiwxMCBAQCBpbnQgeGVuYnVzX3NldHVw X3Jpbmcoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldiwgZ2ZwX3QgZ2ZwLCB2b2lkICoqdmFk ZHIsCiAJdW5zaWduZWQgbG9uZyByaW5nX3NpemUgPSBucl9wYWdlcyAqIFhFTl9QQUdFX1NJ WkU7CiAJZ3JhbnRfcmVmX3QgZ3JlZl9oZWFkOwogCXVuc2lnbmVkIGludCBpOworCXZvaWQg KmFkZHI7CiAJaW50IHJldDsKIAotCSp2YWRkciA9IGFsbG9jX3BhZ2VzX2V4YWN0KHJpbmdf c2l6ZSwgZ2ZwIHwgX19HRlBfWkVSTyk7CisJYWRkciA9ICp2YWRkciA9IGFsbG9jX3BhZ2Vz X2V4YWN0KHJpbmdfc2l6ZSwgZ2ZwIHwgX19HRlBfWkVSTyk7CiAJaWYgKCEqdmFkZHIpIHsK IAkJcmV0ID0gLUVOT01FTTsKIAkJZ290byBlcnI7CkBAIC00MDEsMTMgKzQwMiwxNSBAQCBp bnQgeGVuYnVzX3NldHVwX3Jpbmcoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldiwgZ2ZwX3Qg Z2ZwLCB2b2lkICoqdmFkZHIsCiAJCXVuc2lnbmVkIGxvbmcgZ2ZuOwogCiAJCWlmIChpc192 bWFsbG9jX2FkZHIoKnZhZGRyKSkKLQkJCWdmbiA9IHBmbl90b19nZm4odm1hbGxvY190b19w Zm4odmFkZHJbaV0pKTsKKwkJCWdmbiA9IHBmbl90b19nZm4odm1hbGxvY190b19wZm4oYWRk cikpOwogCQllbHNlCi0JCQlnZm4gPSB2aXJ0X3RvX2dmbih2YWRkcltpXSk7CisJCQlnZm4g PSB2aXJ0X3RvX2dmbihhZGRyKTsKIAogCQlncmVmc1tpXSA9IGdudHRhYl9jbGFpbV9ncmFu dF9yZWZlcmVuY2UoJmdyZWZfaGVhZCk7CiAJCWdudHRhYl9ncmFudF9mb3JlaWduX2FjY2Vz c19yZWYoZ3JlZnNbaV0sIGRldi0+b3RoZXJlbmRfaWQsCiAJCQkJCQlnZm4sIDApOworCisJ CWFkZHIgKz0gUEFHRV9TSVpFOwogCX0KIAogCXJldHVybiAwOwotLSAKMi4zNS4zCgo= --------------429UP0hUq6ZGG0HWvIvXMAC0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------429UP0hUq6ZGG0HWvIvXMAC0-- --------------C1hgxAGmeMgBIKo99LbrGa7g-- --------------EBEDFISbmEqIMyHenYqnZVTS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMjJDgFAwAAAAAACgkQsN6d1ii/Ey8o Cgf/fzTuUgrpPZALZ2JQyPruAiDBTxpcBB8Kzq2gfHZdwFxmtMk+cZYid86cXhG1sQFbniND5PJp M0jsx2h/5h0BeriBhblhU6tZSpnZlMdoM494sMbPBJ3199iDlgC5ijHS4OP/vZvP96gGfY/LyVIv 0A94Wm9IzZCyDKHtVQGSR9GrGfhRVdtaq4GlZQkridlVVqXyUOq9KJFcIXGAHvpVID21ePIFDtZA h344RDH8cGRZHfjHluERKWoD4pNz13ZyEl4lAzfe/8mtz5VZVO7KNAWpD2MHvp9k0vdTNDCzYTEk x0ydM7QExf6jtFBUKjcW54aTkCBao/ykjZ8K/qbBhA== =W16C -----END PGP SIGNATURE----- --------------EBEDFISbmEqIMyHenYqnZVTS-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 13:13:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 13:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407371.649866 (Exim 4.92) (envelope-from ) id 1oYogP-0006nc-7C; Thu, 15 Sep 2022 13:13:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407371.649866; Thu, 15 Sep 2022 13:13:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYogP-0006nV-4B; Thu, 15 Sep 2022 13:13:33 +0000 Received: by outflank-mailman (input) for mailman id 407371; Thu, 15 Sep 2022 13:13:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYogN-0006nK-Mn for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 13:13:31 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 314432ce-34f8-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 15:13:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7192.eurprd04.prod.outlook.com (2603:10a6:20b:11e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 13:13:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 13:13:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 314432ce-34f8-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MuOtlH9sTMEGPkT0lwyWdv0SobSNYvOZGaUuTSLhxzFZ/xdPlG2F03SygYlAb0rR5k7xw8HCuYuoc37rd5+ANmjwzC9oPUXd+zY/GS3Sm5T2OYpk0W7b+tJGOebAVSFf0lTR9WLeTevUWxiCA1iev1YJwnC9npzo/9JCc6i2MndoLr5RE47SFSs8GH3a4QisiBLnbjliaxjXQsOilzZ2fATo1b09GH9IEquTDV1Tkrs7ZYyhayytRi85RhO+AQyoTCaUFj2GEq2cI7pTFVbd13sDviZccQilzHUmZkthPWgePRuoF7MuHkkQnsli8XXeQYxJGxnOE6ffe0YxeDC7iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E7ZW9IxP6fqgA/H2tgkcIDfG1a5VZJISiz6xJOiojI4=; b=T0By0PupOxDpbOkWhS7O3qV19QKOwzFUMZZ2giCuFzSxHIllWb4lYuZht/OR7AUKFRJPAl08StwJ+0jxot8BJIFhPJTVs7+E9wqNg5G4G/4lOF8jodTf7WrYkndw4WQK21pxCIpsXWe2SEZTb48Xu55gTxWnF29MKMe/5UdjZ2Vr6V5C13bCrnEwtbS13PuSl0rLJWNBc01EGajGI5pQmwbige8iBrZGQJJZc1iFQUBEILAzk2QtHtL83w4ErB99nELfBuflcOXT3NQBvd7vZ0przCdIWczXTmW0n1c/h9uLBqj9knzoI06wN1rV4RAcqy5bIxxmaiQ1ltV0J4vBuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E7ZW9IxP6fqgA/H2tgkcIDfG1a5VZJISiz6xJOiojI4=; b=C2uKF5PXB8iqzC1vKVWhdVKnPb+7I9VII0eN8rNhwiqanXrr80N6wNwhIdtedeHipX2BD0H3KE0FJKbzGph43VX1b6w7QWAbeKhFKSbkfSZwgAEDPM0Zs/iS0y4k9dThDL6uzBx9+pbZctqbZVJuF0r0binm2zwRuyreR1TR2yDtaYCuiwJq7/2XMZLJhrqZaUAm9aOXoxDA8RY14DMsRy7xInVN5mMT6ywHCSyytfYG7bCW4lvWn1pVejIlbJ2h/bsFnONe635fi37mb38FbzhLNbeYamjrxGfXwf2mMs5tOA3gFJIW0r41a+jo2ZPdMvBkW1PI5OPx/QvDv/q/Rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com> Date: Thu, 15 Sep 2022 15:13:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Jan Beulich Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for domains To: Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , "xen-devel@lists.xenproject.org" References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-7-carlo.nonato@minervasys.tech> Content-Language: en-US In-Reply-To: <20220826125111.152261-7-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7192:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fb39b80-5594-4074-69a5-08da971c1119 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YFesr92YERj85zDCi3n9Vd/wVwR0fGCKzu7b0dYnzIgZGm3IWd0tb09FJKThujqMHvTKqtYLMhWFGyrYCOy4k1yZK6d2iQF9uCvzG4zJXjKfka7mN/SH9jYDf0gx7/vbXutGhLob5Cy2rkUu/MHL63uYc7ZjCHEv1gQVg6pfLKqEQBFY6pJA5D9l+EN+IPSH8jPh21Bwxhe3webZI8EJ9XjvBlpesbVfz8c2gIIdS9Q7Qkbe0W7WNTsOrk46OBNOziNHq4jGj6rAZePG3/Z5LRmTreiL25rrOwGKzlIVTa12JMZbKZ25m1sV/zEshhTHu6ZpiqN2iF57xYNbuCIM8d8B7kjDq6FaRvIOBdhjwuNFoAt/kypIMF6WddDstfAnyj1xf004Sw4NJZl273a2NIARb2B9H48dnBVnD0RLm75lBpvgncBOteEJAyi+DpZdURE2fmMT9sl9/G37D9FJxb5YGxTwpqi/9J6395YS3naKtbx5QA8F3ZzryFTVNdKKurW0UDpu5VAhrVxDQBnfyiHMjai1aKCc2aWrsDqBohc7aaRpmBL9MdQV1IHH5LtHZydvzEMGuyVENYZT32EVhtYTbpq9j75x/o4OyQ/43jRadXHnBXunMj/6jymSFG7JVXsHL6Z47W3AbZBCfjRDkY3Wfc8Dw1JbA2uyGrU+BlQJh5ka2rds4RNfkn/7QhNljeMXy+r/pyJ6w/R5wQLd2aL2sD+4Na+ZtM63IeqLTBfWaaGFyTVTQ/t03ZgkwZ48i/MwdnSUKwjI/HPSOR/CsGZ5tQjJcf6rj8dwqM1V3Zg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199015)(31686004)(478600001)(6916009)(54906003)(316002)(8676002)(66476007)(66556008)(8936002)(66946007)(36756003)(186003)(6506007)(53546011)(41300700001)(86362001)(38100700002)(31696002)(2906002)(7416002)(2616005)(6486002)(4326008)(83380400001)(5660300002)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDBRdDZzTVZZM0M3eExYWTFCam15UlEyL25obi9JRm04U29tSk9tUnZjM1pJ?= =?utf-8?B?YjcvNG4yMFJvSTdFUHZsTXZOTjZoZVhQcEhyeXlMd1FTQ1RDQWduVll4eGg3?= =?utf-8?B?MFlDSmxSUFZpeGRNdFFlVVpjL1FuMFAvcCt6Mlp5Q3lGSno0Szk1WXp2cW5l?= =?utf-8?B?TUplMklGdUJHeDJlTFdJbVFCYmJMREhKWmQzR1QwZ25PWlFaK25WRDFqL1lR?= =?utf-8?B?Z0NFeVZkNUtrRng4QnByOTNVTE5SWGlWa09Ca05LN3V2QUNoRGF6Mkd3L3V6?= =?utf-8?B?NTJ2dExWR1VuMWNiMGE2OUpBVmVOdzNudElVOG1rVGNsS3JxVms5dUx4bnZi?= =?utf-8?B?NFFmZGw1RkxRU0ljVHVUdFpNdzFIaU5lM1YzR1E0LzdveER3MDdpMFhoVzZm?= =?utf-8?B?QXBJWFRIVlVMOFlIck9UR1V2WmlYbTdwNHI2THFtN25pZzZOM3FOanZXeUpT?= =?utf-8?B?eU5yMXVNcGZGNjl1OEUrNjdiUG8yaDFLMDR0NTkyUTlsRlRHNXlGUFQxNHds?= =?utf-8?B?aXN1REd4MjNOM3cyam1nbFlBZFJ0YWtzQ0RlQlRRUWhBZ1ZVejZZSHQxdFFR?= =?utf-8?B?WWoxS3FyTXBvYUlXeXcycGNZZVZIRVAzR2tiMjJVMmNSOHkwR1h5UVFFbzQw?= =?utf-8?B?SncyYWNDWnpWZXo4dXFLNWl3dm4zaWVMSjBEUWJMUTBLQ3hTWFMydFlQTmhk?= =?utf-8?B?Rm1IM0VwMEowMGpxQnB6YjJPRS9NN1p1UTg1Y05TTUJTSjBpYklJaFRaZm5o?= =?utf-8?B?QzZ0ZTVNNzRqckZKQWpCbkdFdkxrWTBtL1U2S0tkQ1JaZjFmVjFyM3R6Ykxr?= =?utf-8?B?T2MyTDZaalVKWnlVT25EMURDaTFZZ0VBc1F4cDBPVWdCaDBjVUVQbzBlSE84?= =?utf-8?B?Y2puZDNreFhxdHFjYzBscEFjWFVFVGpXNnNQSjFtS0xnNHJVQTUrRWw4a09Q?= =?utf-8?B?a0xENEhudk1nejJXQzJTYXZYSGdONUUvOGM0aGpGUXVvSDRoSWE0S2o0bU9W?= =?utf-8?B?U3JBTFhnVWZXL0paWTJmb3U3Z3lyR2JaalRXOUNDekRyeW9KMWJXY2J4QjVp?= =?utf-8?B?T0xDb3YwWmdSRHJEd0xBaEtrVjZ0OEkvMFFORFpwTS9DaGlsbVdaK0g1c25B?= =?utf-8?B?cXlMQ3V1bHYyRlZDMUM3WEhtZkFibHg5Wm9rcHVHaFovTTBBVXdlb2ozdzNs?= =?utf-8?B?b0x3VHhEK2hZWElqeTZ6QlU3REZiZ3VxQWNIMTRGTko1THBFcjNmWnFrd00w?= =?utf-8?B?WkRmcEd6TTNKN2JwandkbGJhcStWNVJ1WThQUFo5bExvZG14UW8rQnFINjQz?= =?utf-8?B?ZVhiQ1N5aGY0TUxGOFhvM2VzaVRod1FmNG9GbmhyTUxvSW5FVXpiTFcvb2N2?= =?utf-8?B?V2d2Z2RPS2hobVRLN3F3MWQ3N1I5NEVpNzBZcG0zdFdzZktmRi9lOGdyWUhU?= =?utf-8?B?WitVVnFWVXM3Umd1NHlHdnNSTDBsa3RpNjRkaTBnK3BPOUFGUVJsdE9MdFFH?= =?utf-8?B?am1vV1ZWMlM2NUhwSnZBS2QrR0VhQU9JSlA1NkkwQVVnSXF0c3hsVnVYajlq?= =?utf-8?B?djJGT3JUcnVOUXRvakJUVVZ3TitYMEZ0YzdlOUJTak0yOCt6SDBQZHBXaGl6?= =?utf-8?B?U2syelM5ZVZEMTBWN2Q4ajdoZThtb1Npa2RpQisrYi85aE1SMUVYeG5iNDEx?= =?utf-8?B?SmFUYmM1NUtUNUJDbFJlb2t4a0plUHo5dGRnMERzMkJoK29YNkRKbHdoMlVk?= =?utf-8?B?YWZ4ZjExNUtYbzZobXZScnpQMzROOVNYTTB6TkU2cEU1MFVyK3c1UDQwL2RV?= =?utf-8?B?N016U2E3YmYyNzh0M2dPY2RweER1U291Zm56bUtYSCt6T2o3c3RUa3VDcnVW?= =?utf-8?B?TW9ObG1PekZQMDJ3dlRHRVN0b0RHaWROcXlIOHIxZVhLUWhicVA2eW16N3lv?= =?utf-8?B?ZW4xamtBZC9nbk9iTmxRRmNQU3hpL24yUSs4NGUwdUYzUWMrbXVQRjFQU1pC?= =?utf-8?B?eHRIRVJ2UmhzbHdMZTlxMWtTR2laRVd2cUo0dmJqRHIyNy92RXNGK3J1TWxy?= =?utf-8?B?SlhkRThndFZHK3hJYlQ2M1RVeU1qUUFkcmN5aUQ3TmVGVVFQaDA5OHJ4QUNs?= =?utf-8?Q?dWWEXXFo45h9b1VK8l1izpe+W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fb39b80-5594-4074-69a5-08da971c1119 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 13:13:22.9509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4egZEabrcUCsXhljTa/kg13Z/h3vOVXcmYPohK0jtAd7BlqXDpq+W3edAL+FthxSNJn2qk3cXzMuC3PwLUuezA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7192 On 26.08.2022 14:51, Carlo Nonato wrote: > This commit adds a new memory page allocator that implements the cache > coloring mechanism. The allocation algorithm follows the given color > configuration of the domain and maximizes contiguity in the page selection. > > Pages are stored in a color-indexed data structure of lists, sorted by their > machine addresses, that are collectively called the colored heap. A simple > initialization function computes the color of any available page and inserts > it in the corresponding list. When a domain requests a page, the allocator > takes one from the subset of lists whose colors equals the domain > configuration. It chooses the page with the highest machine address such that > contiguous pages are sequentially allocated, if this is made possible by a > color assignment which includes adjacent colors. > > The allocator can handle only requests with order equals to 0 since the > single color granularity is represented in memory by one page. In the earlier paragraph you talk about contiguous pages using contiguous colors. This paragraph then appears to say the opposite, i.e. that contiguous multi-page allocations aren't possible. Which of the two is it? > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -147,6 +147,18 @@ config MAX_CACHE_COLORS > colors at boot. Note that if, at any time, a color configuration with more > colors than the maximum will be employed an error will be produced. > > +config BUDDY_ALLOCATOR_SIZE > + string "Buddy allocator reserved memory size" if CACHE_COLORING > + default "64M" if CACHE_COLORING > + default "0M" if !CACHE_COLORING I don't understand the purpose of this last line, nor the two earlier "if". Why not simply config BUDDY_ALLOCATOR_SIZE string "Buddy allocator reserved memory size" depend on CACHE_COLORING default "64M" ? Also does this really need to be a string, rather than a number (which then doesn't need parsing) with e.g. MiB granularity? Finally - how much of this is really Arm-specific? Shouldn't this be a common config option, perhaps merely restricted to Arm by the top level option (CACHE_COLORING?) depending on a further HAS_CACHE_COLORING, which only Arm would select? > --- a/xen/arch/arm/coloring.c > +++ b/xen/arch/arm/coloring.c > @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config, > config->num_colors = (uint16_t)num; > } > > +unsigned int page_to_color(struct page_info *pg) The parameter will want to be pointer-to-const and I wonder whether ... > +{ > + return addr_to_color(page_to_maddr(pg)); > +} ... the function as a whole wouldn't be a good candidate for being an inline one (requiring addr_to_color() to be available in outside of this file, of course). > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -143,6 +143,9 @@ struct page_info > #define PGC_count_width PG_shift(10) > #define PGC_count_mask ((1UL< > +#define _PGC_colored PG_shift(11) > +#define PGC_colored PG_mask(1, 11) I don't think this can work - you can't use bits already covered by the count. You'll need to shift up PGC_count_{width,mask} by one and insert your bit between PGC_extra and that. Or you could use one of the lower unused ones, between PGC_static and PGC_broken. > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -150,6 +150,9 @@ > #define p2m_pod_offline_or_broken_hit(pg) 0 > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) > #endif > +#ifdef CONFIG_CACHE_COLORING > +#include > +#endif > > #ifndef PGC_static > #define PGC_static 0 > @@ -231,6 +234,9 @@ static bool __read_mostly scrub_debug; > #define scrub_debug false > #endif > > +/* Memory required for buddy allocator to work with colored one */ > +static unsigned long __initdata buddy_alloc_size; > + > /* > * Bit width of the DMA heap -- used to override NUMA-node-first. > * allocation strategy, which can otherwise exhaust low memory. > @@ -440,7 +446,172 @@ mfn_t __init alloc_boot_pages(unsigned long nr_pfns, unsigned long pfn_align) > BUG(); > } > > +static DEFINE_SPINLOCK(heap_lock); > > +/* Initialise fields which have other uses for free pages. */ > +static void init_free_page_fields(struct page_info *pg) > +{ > + pg->u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER; > + page_set_owner(pg, NULL); > +} > + > +static bool is_page_colored(struct page_info *pg) > +{ > + return pg->count_info & PGC_colored; > +} > + > +#ifdef CONFIG_CACHE_COLORING > +/************************* > + * COLORED SIDE-ALLOCATOR > + * > + * Pages are stored by their color in separate lists. Each list defines a color > + * and it is initialized during end_boot_allocator, where each page's color > + * is calculated and the page itself is put in the correct list. > + * After initialization there will be N lists where N is the number of maximum > + * available colors on the platform. > + */ Nit: Perhaps either "maximum number of colors" or "number of available colors"? > +typedef struct page_list_head colored_pages_t; > +static colored_pages_t __ro_after_init *color_heap; Please place the attribute at its canonical slot: static colored_pages_t *__ro_after_init color_heap; It applies to the variable, not to the pointed-to type. > +#define colored_pages(color) &color_heap[(color)] The parentheses want to move: #define colored_pages(color) (&color_heap[color]) > +static void color_heap_insert_page(struct page_info *pg) > +{ > + struct page_info *pos; > + struct page_list_head *head = colored_pages(page_to_color(pg)); > + > + pg->count_info |= PGC_colored; The function isn't marked __init, so runtime correctness as to the (non-atomic) update here wants clarifying. > + /* Insert page in list in ascending machine address order */ Isn't is descending order that you actually use, also seeing that you take the first page of a list when allocating (further down)? > + page_list_for_each( pos, head ) > + { > + if ( page_to_maddr(pos) < page_to_maddr(pg) ) > + { > + head = &pos->list; > + break; > + } > + } Wait - a linear search for every single page insertion? How well is that going to perform on a multi-terabyte system? > + page_list_add_tail(pg, head); page_list_head and page_list_entry are generally different things, so I'm afraid this isn't correct in the common case, and you're getting away with it only because only Arm currently enables this code. > +} > + > +static void color_heap_remove_page(struct page_info *pg) > +{ > + page_list_del(pg, colored_pages(page_to_color(pg))); > +} > + > +static void __init init_col_heap_pages(struct page_info *pg, > + unsigned long nr_pages) > +{ > + unsigned int i; > + > + if ( !color_heap ) > + { > + unsigned int max_colors = get_max_colors(); > + color_heap = xmalloc_array(colored_pages_t, max_colors); Nit: Please always have a blank line between declaration(s) and statement(s). > + BUG_ON(!color_heap); > + > + for ( i = 0; i < max_colors; i++ ) > + INIT_PAGE_LIST_HEAD(colored_pages(i)); > + > + if ( !buddy_alloc_size ) > + buddy_alloc_size = parse_size_and_unit(CONFIG_BUDDY_ALLOCATOR_SIZE, > + NULL); > + } > + > + printk(XENLOG_INFO "Init color heap with %lu pages\n", nr_pages); > + printk(XENLOG_INFO "Paging starting from: 0x%"PRIx64"\n", > + page_to_maddr(pg)); "Paging"? And please prefer %# over 0x% for hex formatting, as we do elsewhere. > + for ( i = 0; i < nr_pages; i++ ) > + color_heap_insert_page(pg++); > +} > + > +/* Alloc one page based on domain color configuration */ > +static struct page_info *alloc_col_heap_page(unsigned int memflags, > + const unsigned int *colors, > + unsigned int num_colors) Array instead of pointer notation would better reflect the purpose. > +{ > + struct page_info *pg = NULL; > + unsigned int i; > + bool need_tlbflush = false; > + uint32_t tlbflush_timestamp = 0; > + > + spin_lock(&heap_lock); > + > + for ( i = 0; i < num_colors; i++ ) > + { > + struct page_info *tmp; > + > + if ( page_list_empty(colored_pages(colors[i])) ) > + continue; > + > + tmp = page_list_first(colored_pages(colors[i])); > + if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) ) > + pg = tmp; > + } > + > + if ( !pg ) > + { > + spin_unlock(&heap_lock); > + return NULL; > + } > + > + pg->count_info = PGC_state_inuse; Aren't you losing PGC_colored here? > +static struct page_info *alloc_col_domheap_page(struct domain *d, > + unsigned int memflags) > +{ > + struct page_info *pg; > + > + ASSERT(!in_irq()); ASSERT_ALLOC_CONTEXT()? Albeit that's redundant then with the sole caller. > +#else > +static void free_col_domheap_page(struct page_info *pg) > +{ > + return; > +} No need for "return" here. > @@ -1939,11 +2107,24 @@ void __init end_boot_allocator(void) > break; > } > } > - for ( i = nr_bootmem_regions; i-- > 0; ) > + > + for ( i = 0; i < nr_bootmem_regions; i++ ) I'm afraid you can't simply go and invert the direction this loop works without any justification. It's not even clear why you need to work forwards in the colored case. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 13:25:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 13:25:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407380.649877 (Exim 4.92) (envelope-from ) id 1oYosG-0008VT-DV; Thu, 15 Sep 2022 13:25:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407380.649877; Thu, 15 Sep 2022 13:25:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYosG-0008VM-Ai; Thu, 15 Sep 2022 13:25:48 +0000 Received: by outflank-mailman (input) for mailman id 407380; Thu, 15 Sep 2022 13:25:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYosF-0008VG-Bq for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 13:25:47 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70074.outbound.protection.outlook.com [40.107.7.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7deae78-34f9-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 15:25:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7690.eurprd04.prod.outlook.com (2603:10a6:10:200::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 13:25:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 13:25:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7deae78-34f9-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UA9lbMFAxiujxIwz+uIFC2wehApq6wpbUaHtMLLb9PTbYid9jgk2/UUSK86/3/jCnb61VrLyzu/4WiHDnL1OGHOheXLOoTF0DyCBPojLSFDaw0uLjbUzZi4s9HO3bfBRcLBofxOzEdUw4/mcS8kjtG2P8RZNMi9yyI1aobpfstQRzT6m5ojfC7Z3c7EeXzIhi5TNuxNzAaubazxxgVpCqjfmqPi6Wu4v84ZFOtrdYmM5Z/khXbrZKeYhn5m2HXhvWGt9A1bonTA+i1TfNN7AqpCGcX+LKmMyB9IZvYE1fWJLsw/q2m0hO6YSbBxgdE5FP4vnUjASVbkPu+S3FIl6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B4Z3F4o351xCf3aEuqf4PpLzBJ1/7waz0/pFnhv+1U4=; b=VUhVYZ0qacMlE3VYUsl8KUwp069paXAYusKC8QPlHO5Fg7FcwRVWzAv90z9g1JcdLKByNrgIBZT1r12Fa/AJatYE56h2Ld2tUhX60cOxzGPvTOmL5SU/XNGKGBiGAvuTM6no+/RmYR5xmtTgRuxPH8QBcqqRgCAecymtoBQuj0Qn0oJR3fYC+l7SOwbOgSj0JfiQvcunrzV68wdafwFNEfhV15nj2VJlYmvIFnwjlkrcmcXoLL5frmgiB6JaZ1Wrawhu5eO9HKWi3UsIC9aBnSBP6mQvGpyPG8+20wWf2lNzlrYogxrE/swrPzVwfQa/ZqeqC63qqjFRAk0Zk9bCEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B4Z3F4o351xCf3aEuqf4PpLzBJ1/7waz0/pFnhv+1U4=; b=0bMjS6SKypgrOfumXz/IYu+oIg19M9+4Ge1YEo8y7n+yK82zH8sesvVLfjtBwzuk+vmYN1Ii0trrdCExCzuodZQDSuuhrCz1u325eAd2GdnapD4WQ3wMVfnLvAdpTIpcKdB/orpNXJx9poAktJ4EDkXIoMjCEHkNJOzgndLhycmbXDg1x9ZBGcJLN7cn7CvfHx9C8hf0xQV+DoxEGkE9/qJeIPf2Aeynu7GWKO+dXWhgvn385TF61SG5rG1tEmU1xzkFpmOM7ZxKTu11q6woWavl37x9URU06FXMxVLO3tZtSGeTvGzD5BYgjFFQWA4qNgnMEJPSnNiYokzgB9wKiw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <93471d92-bc61-56fd-5b52-413303d35da1@suse.com> Date: Thu, 15 Sep 2022 15:25:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen Content-Language: en-US To: Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , xen-devel@lists.xenproject.org References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> From: Jan Beulich In-Reply-To: <20220826125111.152261-13-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7690:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cca7db9-36f8-40ae-8c99-08da971dca52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NNvwP/C64jTngpjWb45hyfiCEtgm2JmmmlmvwVYt84OvRw+haXEGnFBhYhw6GR7+8ieAo+RNZK3A7uiYfa5qWbfn3CGEax0OWFnyEG9I8Yj1667nes+oUP2EJYB1HQcnl4VJSmZFQbNoCDKXx3PZwFOUJ19P0XaGFb49EqAo21q47EE9GGII2h5F4dDl7Ih3VWBnhGjwjrTWtq6YvIqpgQJ5hcaN1KXGaFkz4nWdKyCOy4DtaLl/853N3R9SFffVOp9wpCKNARgW6WgikH3ngEfzGDTDX1jPIfOsBcESebA5ix5SYRURJaj+Ds3LhVhTmJxxPRmD6LoAi7pwEZB2aNhcI/KmTiTR3T0y7yvQbYXHdtfN24WfGaqkqT0M9fY8T+uCsy4VdN3rdsVhkK7gT5VhQvlfB4InCiv283STJ0O0KXAVlwn/T69PGSLNUSyFF9uwINPW2/+r9Y9QjjJZUhj+6xAVALHBZiD/ClT7xSIpLDtXbGSAtDEANp6SJjbP+E8oSXxKPBOgLV11hVpHD+Z0Ad1rZa5/zkGrP2ltWMR65fG1D8q8H1qNgpCmOAmiWBPVoI45r+TXYzCbPVo9LivCAdNZBpW6A+ZyvNT/mpg+vattp6fYObwlvGOY43ioK24CA4IIgo3yAedmjwo3jywMq6INiclVw+p1tLZ2qk6srxK0K1mG7FbzVAcB/He6CryozqYnQZTuvILmm/eLY1bU3DQgJV4WKr8R2Czt5IcQpUcuDaWLiEMxesA3DDAO5EYjLMUZDgoXlJhuLHk3xWOyZ38BasXkiA8mb5Tmypc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(31696002)(86362001)(38100700002)(8676002)(66556008)(66946007)(4326008)(66476007)(6916009)(316002)(8936002)(7416002)(2906002)(5660300002)(478600001)(186003)(2616005)(83380400001)(6486002)(53546011)(6506007)(26005)(6512007)(41300700001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yzc1WFI4Y2VzYjN0S0JSUHBqK3c1cUFOWFVtT0UvUjA2di9sdWloSHErbmxn?= =?utf-8?B?QVBpY0FPVG1uRjJsM2l2U1grWll2YkhwMzc1M2U2cnBXVE5OTEZjSzRhWFB1?= =?utf-8?B?K0psaVB6aW9GckVDU08wejFTdEprNFl5VkNwMVNpMDExUkp4MC82bHYwZjY2?= =?utf-8?B?TDk0S2RXNDZLcWNCU3NqYlM4SFE5M0puSWFodXo3R2VZazgyTUpONjhZV1Zk?= =?utf-8?B?WlVpc055OHRzV1RtVGFNbGZhLzZyYzVFL0MwMzFSQ1J6VnB5cUlGV3lBSWNl?= =?utf-8?B?R2ZvRjdwN2tRRHVLNURpWjNSZnJRWkxKTDlaY1p5RllnNGxhQW5sL0hwQVVI?= =?utf-8?B?MnlpeVRldEFzTElHc3pJRW1xd00wV0NHcHpBSEhZOTVtdVRnZ2FsL1MvMU9K?= =?utf-8?B?SVo4VmxLamk4alpjVnlGTldWMmtBVE5DNHlmWjRTWFJqaTBPUkg2UXh2T1lo?= =?utf-8?B?UU56SFhEQnJoTjdxS01ndWp2SFp2YWJxWllwRmJtMFJ2Qy9sNHlkKzBvc2VG?= =?utf-8?B?cituSHJ3SE94bTRoU2hna2RSMll3dHpGRnR3ZkJPL2U2U0NvdHl4OVV4RFhC?= =?utf-8?B?VkFWT1pOMlpvNWEramZtVHdiMjRpZWdIb0VoTDhwL1RpcG55SGJpUFdLVkNp?= =?utf-8?B?N3RqVUV3eG5vWVQ4bkdZTTBrczAwcnJwUTYvYzMwVVloblp4eEhpZE9ROHND?= =?utf-8?B?NHIwMVBBME1rWVNTNkRLL1crOHJNM09GWVNiZ2cxdTZIMWpoU3RweEtUU0h5?= =?utf-8?B?dFFicUduSmlIdnk2L0Nja05hQ1BtRGZ3ZjNLRzF0YlUxbzAreEFWaXpNTVhr?= =?utf-8?B?aElaVWlxY3IyQlE0ejh2cWdaSmVTdU9nVzFnZEljYmZ0VDdNS0VQSzliRUIw?= =?utf-8?B?dnhSeVVmSG1Va2p3UG5JLzhXWVZpVjJrTWlYQ3ZKOHBLSlVrM0xsbXFjalFt?= =?utf-8?B?WkFCL2dZblgyb2F0M2lEZnh1UEFFb1NCUEFkWk1qKzNFdFNXcTIycEZjb2Qy?= =?utf-8?B?dU9KOWlhWm54aytvTExUeEczdzIrVHA5aThKMmRhb2tXeFhFQWVGWW5NcWV6?= =?utf-8?B?QzY2SWVlVk9lUzQyN1RiS2NjYVhKdFRrbHl3YjRHb0cvK1pXdG9xRG04NEJ5?= =?utf-8?B?cnUwL2lpZm1wZGJIbERieUdTeFpGVzJPa1g2VGI2U2FIWEYvREpKR3ErK3hJ?= =?utf-8?B?a3pySUQ0cnk5U1JlQWI2djlEVlFpUTV6Z2R3aEZ1SEpSNjMzOWgwR1ZFWXVW?= =?utf-8?B?T1gzTVo2akh2b3BUcEtmSjhFZWFROGx5dXplSHNvc3YyYzdGUWVTanFBKzdz?= =?utf-8?B?bE1zT2hxaWFrN2dkZmZlSkNmNFV6aVdvZjJzb3d1OHA0TGZpdUR1NjhNRWxw?= =?utf-8?B?ZjE3bGJUQmp1UGRGZjJLekg0THlsZ1VyUWRNZDRGYzdpZ0VTNEVUakJNZTcz?= =?utf-8?B?N1BQbXBoSklidGFLLzN2amFzMmQyOThjem9SM2N2dVRzQUxHVXcxVnpqTTZ5?= =?utf-8?B?SzlzVWFQUko0dVBudWJYR1cxQjBySmkwK0Q5b3R6QWFWWHFCb0wwYzB3WnU3?= =?utf-8?B?WUlaNnFxOW5ZOTZzK2NOQ1gvekhnMlFJQzIwV2RuVGxUWmtINDd4cW5WZmhJ?= =?utf-8?B?a3h4aU9TUmRoajFVZ0xVM3lxSjRRUWRLa2l5bWxnSEhZYzdtcjRqRjIvWU42?= =?utf-8?B?dHlOT2ZJNTErbWRQRnVTWWdOMUd1Y0VkS21MYTRqNnFTcVgrTmVleHV1R2xH?= =?utf-8?B?MklYM2ZCMGgvSHBnWk9obWJZK3oyQTdOdDJkaVAzL3U0YWh4T0JRK2R6OUEy?= =?utf-8?B?Nzl6VUMvUFI5dVdDRTJEWURXQVBEU0pmcVZYcnRQOGlpcTJHNkRXd0l6YWZr?= =?utf-8?B?VVJ4L3JlT0hHUHpyLzN0R0hmRndzSGVpRkg0b21iYjBqdEhGYmZJNjJqcFp0?= =?utf-8?B?ZE1vOFNZWjBNcStjZ1d5MTd0eFJnUkZsL0FYTzlKZFp2M2VNME5qODRWM2NM?= =?utf-8?B?RndPeU9PZi9WeER3RFhVU21wRFg4VDkyTUFvak44dk13S2Q3TURrajB6QkRH?= =?utf-8?B?RC9PUlNRcTJFN09kajZQN3FKclB2NVZNL212WVdNT0QvdEVBWk8wbnNBTlVW?= =?utf-8?Q?pEFv+HfyTWdlgSq4Hd9KWiEGs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cca7db9-36f8-40ae-8c99-08da971dca52 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 13:25:43.4349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EeE6tybWU5/UKFKGOCcohHMUBX/OrFaGuX/uGYWdzzG5ZSYj/nH9kwT4XPSFlt9UqOJ2ykpKSTwLEMYrIJmcSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7690 On 26.08.2022 14:51, Carlo Nonato wrote: > --- a/xen/common/vmap.c > +++ b/xen/common/vmap.c > @@ -8,6 +8,9 @@ > #include > #include > #include > +#ifdef CONFIG_CACHE_COLORING > +#include > +#endif Even independent of my earlier question towards more code becoming common, I think there will want to be a xen/coloring.h which takes care of this abstraction, requiring such #ifdef in just a single place. > @@ -218,6 +221,28 @@ void *__vmap(const mfn_t *mfn, unsigned int granularity, > return va; > } > > +#ifdef CONFIG_CACHE_COLORING > +void * __vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, > + unsigned int flags, enum vmap_region type) Please no new functions with double underscores as prefix. Only static symbol names may start with an underscore, and then also only with a single one. > +{ > + void *va = vm_alloc(nr, align, type); > + unsigned long cur = (unsigned long)va; > + paddr_t pa = mfn_to_maddr(*mfn); > + > + for ( ; va && nr-- ; cur += PAGE_SIZE ) > + { > + pa = next_xen_colored(pa); This may alter the address, yet the caller expects that the original address be mapped. I must be missing something? > + if ( map_pages_to_xen(cur, maddr_to_mfn(pa), 1, flags) ) > + { > + vunmap(va); > + return NULL; > + } > + pa += PAGE_SIZE; > + } > + return va; > +} Afaics you only consume the first slot of *mfn. What about the other (nr - 1) ones? And compared to __vmap() there's no "granularity" parameter, which is what controls the mapping of multiple contiguous pages. > --- a/xen/include/xen/vmap.h > +++ b/xen/include/xen/vmap.h > @@ -14,6 +14,10 @@ void vm_init_type(enum vmap_region type, void *start, void *end); > > void *__vmap(const mfn_t *mfn, unsigned int granularity, unsigned int nr, > unsigned int align, unsigned int flags, enum vmap_region); > +#ifdef CONFIG_CACHE_COLORING > +void *__vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, > + unsigned int flags, enum vmap_region); > +#endif I don't think such a declaration really needs putting inside #ifdef. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 13:29:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 13:29:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407386.649887 (Exim 4.92) (envelope-from ) id 1oYova-0000hC-ST; Thu, 15 Sep 2022 13:29:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407386.649887; Thu, 15 Sep 2022 13:29:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYova-0000h5-Pp; Thu, 15 Sep 2022 13:29:14 +0000 Received: by outflank-mailman (input) for mailman id 407386; Thu, 15 Sep 2022 13:29:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYovZ-0000gx-6s for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 13:29:13 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60063.outbound.protection.outlook.com [40.107.6.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62a2b44f-34fa-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 15:29:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7690.eurprd04.prod.outlook.com (2603:10a6:10:200::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 13:29:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 13:29:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62a2b44f-34fa-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbNsQSB7VVvaS7vITkyPG7v0NL2P4jq/9lWXwndYKIUJf6D7o4Cl9bWMsBtOcj3Rgub5GzoR+Ol3hVWfZ2t6Qo4q/+zTt3eXt5+TCJNFdYFd0SfQc1iOc86+0Ick15Bq9OzNoZ/Lf6R7XxyavrImDrdyqHSHcLPFfgEjRCs7Vbw4mh7BF/XoNMFwxcdzbGwmH0Ylz4nJzsDgiEMsr+7Isjh/vy9JRYUqZ8blCEdUB3sawTMtmyL0fkoDNHNo16luKBHZSoKg/jcqauWTOphEDYPcUBsUko2mwbEPqOAgo3oqIfeVKYXDeoBnoV5yiBWypK/EfkwbBZzc8orbsSbpJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4X3P1EpZ7AG+nMna+lOXuXgbggKAIOOVNW3TjVq8YD0=; b=jDD91aHAh+nvH6k9VyIIntJYP/Gjv0EBXHEMnEPSYhKntu2wJNWezE0wK7yF1ZYoqnl/NiVvYAdu9a604umZQWL3edcSUGjY0iw6UOxnBWR3A0CB6I3CvV1mZujXmacsHJTeb69FI+xsTuyeKs1g1fn1APPc1Oi7UGMpYnuq0m9FvnurRH77mQewCS1Iy0PeYq6nnUapJy7jbAOLJu2n8EZ4g1IV4yNH7abW3Qq4pLXS8KYC5AsBFNhEyu0CShSTWn/sjI4jHG3SJcnSXeUl0xRbM2FKMhG0XNxOdi8854sw/ET8HtH/EfSY93m6RaZDQsUjhWaqGmJ+NsWkptf42A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4X3P1EpZ7AG+nMna+lOXuXgbggKAIOOVNW3TjVq8YD0=; b=CpRWPXQcZ87ycgL0OzVSFe2ymiyYTc/cviMbZ9rKigYqnaQ9TUu93Bgp9mL/kVlT1SQdSEu9zw+tb0g49vYnwn2byNw1AFsxe8wQsfyFKdPRLxfSepXbf9gO2lujE+D4FhwmSSATq68IltQhCQP/hg1SyzlRMEO9jsiUjBB9nEuECFU9771OwPDuV/+ufL682iWsthrLy7WdTwnjuy0lnpMzYc1Ak6g+byPI4Bwha4TlP8ai0YFGju2j6GvgbDLXD+5gLgQ0mig697b8vbfeirs9feOIPgcMqAJqbfotqOfSgjZ3qVkU189/T99jrr0N0oXwzMllb7tIJUl7JqwcnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <65f5a6b5-37a7-4b5f-b42b-805a51790a60@suse.com> Date: Thu, 15 Sep 2022 15:29:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 00/12] Arm cache coloring Content-Language: en-US To: Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, xen-devel@lists.xenproject.org References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> From: Jan Beulich In-Reply-To: <20220826125111.152261-1-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0056.eurprd02.prod.outlook.com (2603:10a6:20b:3a::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7690:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a07c812-4ed1-424e-3fa1-08da971e4622 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t3WcKnF4GsCdSzMgmYDKxJqiHOeMtFwWgiAGOfHWnKrrcUYa/oDydxUHnL6azoi2RNnvLjCpgkXG5x4FF6OPgZkCn32+6OR88JVAO8kghYSxsUmvINy35sF9rVgdODMpO8W3qi3pTwVqk/+DpRfnKeplMrDjwd8ROM3Cpdq+Yzf/qMJG3Won9fZXBTbD01yxSvQHmWGO3UnkRY4ea569udVMhjFfgeczKUAewbaCg58Q1phcW+q9Eh8NH92933eeOOSsMqAUV00XLixSqFlaU+vqaSy2A1xPGnVUW+XWMcBgvHHrwzHR47PjkI0YN64sY6ZtoXIuK+/m70T3Hok0TgwhqFLr7Oe5NSk5U2V8xYJ7SQ4RITxtWcsbp/Uz6H2bdaQ1GaXjhOkPRM/7jhPiDNaHXqcjet7njHcx6fOiJX058Hm5RY9YsDF7Q/3jz51fbItwUDaWYpqOeIBBxNJCJVRN8abSoChh6MSZyCkJlGu4PmE+xWIHqsvNj6IS+TB1AgnBnDZdMFQ3lsH1vqpKpH03oUXcWrjD5lYHySYzRt1WwO5lxEL0jMQzeXJXU8Z4llPPeQh9jN8QVCpM0LsnhzHrd7YJZ3L/l43Qda2r/6fZnUoStRukgBhjPnkky7ko5BWvB8vwnFJQX0YuQgH4ypF7elePMN73j1f1QdxkSMqRDoqtcsklz2kYas339aBCHhLwCqtq3hnaLZMsJOdc4ozC13PFUA9Q+YfQJqmtEaEJh0fC+5nBNl5b2NUR8MX7EM1y0vqZWTH1lE9HxLhHvypGXdEYCHDjHFZ+5HdjsJE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(366004)(396003)(376002)(451199015)(26005)(6512007)(6666004)(6506007)(53546011)(41300700001)(31686004)(36756003)(38100700002)(8676002)(6916009)(66476007)(4326008)(66946007)(66556008)(86362001)(31696002)(2616005)(83380400001)(186003)(6486002)(478600001)(316002)(8936002)(5660300002)(2906002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0hzQzdYcVlWNlN5WVRIdTh3cjBQSThobXNIbTV6dmlHWlFsY3I2K0RPMmpq?= =?utf-8?B?dVRIbU1xVjM3VlFaK3Rxb0d0bGVMK2FNWFFPYlpzdEovSGJ4NnU5a1BBMVcw?= =?utf-8?B?dCtMLzdZb0pKZ3VmcTlkR0xBZkl2emZOakVlYWxubHJ5ZXhUdWdhOWxZeWcv?= =?utf-8?B?TW1jMFNBTm05TkMzV3htMmtmVFh0cU1QaFFmTlY2SDFXMVMyMVhhbkRyVGl5?= =?utf-8?B?YWNIVURaZnRkbThZWXhwU2FzYmlZL3ZWRmxudENtbXRQVEZ1RlN1cERrdzVw?= =?utf-8?B?MlhXa1FmWTVqbnNmWldwVDlSMW1DeDYvekZvT1BCS2tTZ292c0pwSTN6WDQx?= =?utf-8?B?L2l6MWYxMEV1Sk1Kd1ludU9oMnA3OXQvMEN2NmxZN1JyZWk0ZjJsZ0s1bU02?= =?utf-8?B?SS9sNE01a09weUU0UGxYNERjL2p4UUMrRHB6Ly9PSnFDNEtHMmtpMXZ1SVdK?= =?utf-8?B?LzUwdGs5eEZZOEt3ZCtmd3dwamtkcndOUlFkTmkvL2FVM1dhUXhHbWRDNzQ0?= =?utf-8?B?WnU4SWNHcjZqMHp6KzJnUjd0SDIvbUY2WWN1a3BjNjlnWElxMmZOdTFuc2Jl?= =?utf-8?B?dllHOGtnTWhyVVdvY05mRklJTVlOT0xIQ2cwNHlkSTRKeEV5NVdCL0lqUWRr?= =?utf-8?B?R244UkR2NWlEZ0tTUjBTdkFkMlRZLzFrcFdlc1lxaStmSmp3bkpwMHk4UDN2?= =?utf-8?B?OStMV3JxM2pUUC9VbERETVVJVWdqYWllem9XQzc0RnBhTkd1Rk92ZkJWRlRZ?= =?utf-8?B?dzh1OTlrVVplRzRrS2k0OEd0clV4b1hPWE8vNGhuQVBSVWgxdDl2Y1k0UGdX?= =?utf-8?B?MTJtaVVRcVQ2TW5PRzJ5VWtZWkRBY3gyRVhnOEVOZDdmQXNFYkx1bHJBd2Y2?= =?utf-8?B?STQvN2ZHRUlDUHB6dndKczJOSXV0QzMyZGFoTnE1YTdSSU4veGhsRGdueWVm?= =?utf-8?B?Qnp0MlZDcUZkT2ZNOUVDM2QyZHAwU3pMQWdyTHRIV0s0MFoySWQ4QURpc1hn?= =?utf-8?B?QzlnYVRHVytTcDN3YWU2TEZLUlVyOTk2WWRieDdXSm0wblBQaytMSHk2SytP?= =?utf-8?B?c2VmcXRDWFR0cWhmR01KYjdWOXlCekgzRnFMYThWNWQwUmV3bGp2eGY1T0I3?= =?utf-8?B?MERWdU9jRlVWMDVtK1hFQ2U3UTlZTi9sd0dENjRRNTI1YUdOa0N5bFVKRWtk?= =?utf-8?B?Y3RIV1E2cGFXU0xmcUZGTzNiTHJTa0l0U0o0Wm1NUTRLNkJxRXh2Zlp3bTFs?= =?utf-8?B?eE5aaDhIbllJcFhzaHBhR29lVUUrNXMwVkcvakxDTGV2alBnSFRNeW5VRzNM?= =?utf-8?B?QTlqa1RxRUlsNFg3b3dsOUZ0UVhxNG5XSUlLdG1wWGVxZnJON25aMm5lQWwx?= =?utf-8?B?UmNHenZiLzJpOGxsUU5lL2ZSS21IZVNBZnoxazZiSWlQY1VJTnFXNStOVHg0?= =?utf-8?B?Z2VNZ3ZnendCc1NOdUJSOWNZeTlwTDMrOE1BTHVubEd3WFNzMEFmc2x6VGt6?= =?utf-8?B?dSt6VE5Ebzhid1J1TlBHZEtVMWlBWE1nbC9aUGdVU3ZsT0NLQnVoQ1RjdUtm?= =?utf-8?B?bmtUM1NlTy9BZGRpOWlmbC9ybW5qUDUxY0RhNjJReHg2SU54a05zM0RJQVBX?= =?utf-8?B?QTRRMzFqNy9PbG5oZUNaWElTeWJRYTVRNUdINURXQUdwNXBpdnJGaUJvMlov?= =?utf-8?B?STN1eVl2bi9UQUVQV2RENWdMZ1ZPQ1BmTXlZMVFQTHJ6Q1crRVZJQVdPRHcv?= =?utf-8?B?YmRUUHBzZmxoNys3c09BSXJOSEJBRjVJSTk4TnJPWU42bTNJVEVsbUdJU1pZ?= =?utf-8?B?enNwNWFLTlp5QVVGZERwUEF6ZmRsTmJnaWFRRUxGZ2JvUXE1UW5Vdzd0TzRs?= =?utf-8?B?dSs5NjlsT2ZMUndwVzVBb3ZleVQ2QlFPOGJzNEdZd0xVUTUraTdIY2tYTXhQ?= =?utf-8?B?RnY3MjZNaGcyQTFCeGgrTU5veU9iaEZrbG1hMXpxbGsyMDU3eUp1c2xITnBy?= =?utf-8?B?Z1NMS2E5NmtyM1NJb0Y2YitubmhDS0NXdnJsL1RuUnpqY3cybmFUTXp6dDln?= =?utf-8?B?T3ExRXEvZm9FVWZRekVWNVFXOEszTnJmZ0U1bm9NTXFHWkM2K1lxcHZjMCto?= =?utf-8?Q?wvAOIUOydf3d59wO0cUVUZfr1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a07c812-4ed1-424e-3fa1-08da971e4622 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 13:29:10.9527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jtBA0Vhc05UULJG8/5XrRC6CaHf+7o6JAfQNZuc2GmlMlE0JvzxKz4ycvjZAa9ePHYIVJRGLSfy3J7xifTMqTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7690 On 26.08.2022 14:50, Carlo Nonato wrote: > Shared caches in multi-core CPU architectures represent a problem for > predictability of memory access latency. This jeopardizes applicability > of many Arm platform in real-time critical and mixed-criticality > scenarios. We introduce support for cache partitioning with page > coloring, a transparent software technique that enables isolation > between domains and Xen, and thus avoids cache interference. > > When creating a domain, a simple syntax (e.g. `0-3` or `4-11`) allows > the user to define assignments of cache partitions ids, called colors, > where assigning different colors guarantees no mutual eviction on cache > will ever happen. This instructs the Xen memory allocator to provide > the i-th color assignee only with pages that maps to color i, i.e. that > are indexed in the i-th cache partition. > > The proposed implementation supports the dom0less feature. > The solution has been tested in several scenarios, including Xilinx Zynq > MPSoCs. Having looked at the non-Arm-specific parts of this I have one basic question: Wouldn't it be possible to avoid the addition of entirely new logic by treating the current model as just using a single color, therefore merely becoming a special case of what you want? Plus an advanced question: In how far does this interoperate with static allocation, which again is (for now) an Arm-only feature? Your reference to dom0less above doesn't cover this afaict. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:02:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:02:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407393.649899 (Exim 4.92) (envelope-from ) id 1oYpRj-00054N-Da; Thu, 15 Sep 2022 14:02:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407393.649899; Thu, 15 Sep 2022 14:02:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpRj-00054G-Ak; Thu, 15 Sep 2022 14:02:27 +0000 Received: by outflank-mailman (input) for mailman id 407393; Thu, 15 Sep 2022 14:02:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpRh-00054A-HJ for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:02:25 +0000 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0336e94c-34ff-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 16:02:21 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 07:02:12 -0700 Received: from tlengyel-mobl3.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.209.176.180]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 07:02:11 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0336e94c-34ff-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663250542; x=1694786542; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nm8d2LCDVjaNR+AJEi3DoLWSkOMQhFvCTPiTWL4iOaU=; b=mhJOYPgXKLNASBATZypDeG4Vw2L7sVtbQHbWY8DM6K2pXz9Bn62CabrB oSyp07pubq2o/jLpzg4Vcb9PTdwWIf2wuNMPSm5R1/SWCBV26C+9A7Unx dvYxDy+rGDaZLeX6cBkxuVwhsv3JVP6pAOxWcfX9uyqRzX37/ZIcbo6U1 0SNMwV7zqi7jf/yA8p2yqESocPb9JTuSmX6S8HzfSM6jfLqCQe+TW6LvA /2EYHRhc/g9kVcTUtPp+EiEdehGsSYRu/S06zu9dcwtkEtZ7DP07H18tG Dw/++cl3xl+Px7ooSiuXboHVDCrBjZOS76HN+zK8G4ZnY70p+5BSmBCh2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="324981275" X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="324981275" X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="685735205" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/vpmu: fix race-condition in vpmu_load Date: Thu, 15 Sep 2022 10:01:59 -0400 Message-Id: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While experimenting with the vPMU subsystem an ASSERT failure was observed in vmx_find_msr because the vcpu_runnable state was true. The root cause of the bug appears to be the fact that the vPMU subsystem doesn't save its state on context_switch. The vpmu_load function will attempt to gather the PMU state if its still loaded two different ways: 1. if the current pcpu is not where the vcpu ran before doing a remote save 2. if the current pcpu had another vcpu active before doing a local save However, in case the prev vcpu is being rescheduled on another pcpu its state has already changed and vcpu_runnable is returning true, thus #2 will trip the ASSERT. The only way to avoid this race condition is to make sure the prev vcpu is paused while being checked and its context saved. Once the prev vcpu is resumed and does #1 it will find its state already saved. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/cpu/vpmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index cacc24a30f..076c2e5a8d 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) vpmu = vcpu_vpmu(prev); /* Someone ran here before us */ + vcpu_pause(prev); vpmu_save_force(prev); vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); + vcpu_unpause(prev); vpmu = vcpu_vpmu(v); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:06:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:06:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407400.649909 (Exim 4.92) (envelope-from ) id 1oYpVK-0005kx-U4; Thu, 15 Sep 2022 14:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407400.649909; Thu, 15 Sep 2022 14:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpVK-0005kq-RK; Thu, 15 Sep 2022 14:06:10 +0000 Received: by outflank-mailman (input) for mailman id 407400; Thu, 15 Sep 2022 14:06:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpVJ-0005kh-S5 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:06:10 +0000 Received: from MTA-06-3.privateemail.com (mta-06-3.privateemail.com [198.54.127.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89f865b6-34ff-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 16:06:06 +0200 (CEST) Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 531BA18000AA for ; Thu, 15 Sep 2022 10:06:04 -0400 (EDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mta-06.privateemail.com (Postfix) with ESMTPA id 2E1D418000A8 for ; Thu, 15 Sep 2022 10:06:04 -0400 (EDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-3378303138bso221596477b3.9 for ; Thu, 15 Sep 2022 07:06:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89f865b6-34ff-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1663250764; bh=qa36mZLG4em6SsJOyNBocR7jBqxYwA5Hthf9k1r+Alw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gg4zWw6fEK7/WBkTb2cEIiFi9ymEG84IqselKLyJI75h5QWuJB1i7l64rNdtZc8Iw ryDCpi2l1de4n9o6ZHexHf8c9Huyx5d0BR4k/VTEakOpqHoObMnhZ6R6OD2EN/dTXH /GSBpcLI56Ufv2qAjWOapKL4BBDZg5yNDudt4wZk8+gBsaiXJHf45pslkCQq33OypO 53F5OIv1ac0M4c37P5DXdOjg07GQMeo3eRMIVnGckRTz6Nu0s2tD9RZZ0+1lE8TXTB 1glWdsvZKaEKyTfbxMeIwS8qYO3LMeq1USA0McalevGevmdx5Zi+MFN8qqb0nvZI0T e2Y2pTSvRCeDQ== X-Gm-Message-State: ACgBeo0KWCufRhv6yld5kcSA9RxhcXnxGTaFf0aOIUYO5HZfhZzmChyz IfqGqTfixaOghV7U+Ns1zkc00UmEy0lAX1Bee4k= X-Google-Smtp-Source: AA6agR6Al1bODeSVvdcHbGpCO8eiE81OHEMPbwVtHMDDFC9tdYiItWaHvrhV81rbON/pZWrN/zLMo+CwCKXjpmld/i0= X-Received: by 2002:a0d:f201:0:b0:335:4933:6683 with SMTP id b1-20020a0df201000000b0033549336683mr33302344ywf.23.1663250763453; Thu, 15 Sep 2022 07:06:03 -0700 (PDT) MIME-Version: 1.0 References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> In-Reply-To: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> From: Tamas K Lengyel Date: Thu, 15 Sep 2022 10:05:27 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Console output stops on dbgp=xhci To: Jan Beulich Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Sep 15, 2022 at 3:56 AM Jan Beulich wrote: > > On 15.09.2022 02:41, Tamas K Lengyel wrote: > >>> Do you have any idea what might be going on and preventing the output > >>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still > >>> present on the receiving side, just nothing is being received over it. > >> > >> There are few more patches in the series that are de facto required. > >> Especially those about IOMMU, otherwise it can only possibly work with > >> iommu=0 (which I'm not sure if even is enough). > > > > Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this > > on the console: > > > > (XEN) Panic on CPU 0: > > (XEN) FATAL PAGE FAULT > > (XEN) [error_code=0011] > > (XEN) Faulting linear address: 00000000328b3a54 > > Perhaps in another thread, could you post details about this? I guess > we want to address this independent of your XHCI issue. That's an > attempt to execute code outside of the Xen image - the only reason I > can think of for this would be an EFI boot services or runtime > services call, with (possibly but not necessarily) quirky EFI firmware. > Any other context this is appearing in would quite certainly require a > fix in Xen, and I don't see how "iommu=0" could affect the set of EFI > calls we make. This was indeed observed with a xen.efi booted directly from UEFI. Beside the limited boot log I get through xhci I don't have more insight but happy to send that (and anything else you think would be useful). Tamas From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:10:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:10:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407409.649921 (Exim 4.92) (envelope-from ) id 1oYpZJ-0007Dt-Kf; Thu, 15 Sep 2022 14:10:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407409.649921; Thu, 15 Sep 2022 14:10:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpZJ-0007Dm-Go; Thu, 15 Sep 2022 14:10:17 +0000 Received: by outflank-mailman (input) for mailman id 407409; Thu, 15 Sep 2022 14:10:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpZH-0007Dg-WB for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:10:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e61a42a-3500-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 16:10:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9269.eurprd04.prod.outlook.com (2603:10a6:102:2a4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 14:10:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 14:10:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e61a42a-3500-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PsPGZx9x75mhVYbsUi92mu6zoX3I7NZkVwlyuWuK0JecVxkXKk/KkpZkGah5nTEV1lEJ9KLiC6bYX7k2kLLibsrPLCVgbZckEtoLBg3HyoE5rY+IXb8J4AAS607RkwbCvjW+zyKXY35tpGL3Ry+orw2m/OiaTOf8pkmCrt7QklBrVpcYVvAWs6ConAqyS0qwcTGhP0w15Tgr8/gG3K+KjcNoZDlWLEO27+w/K+jsA6GNloH/k0cyvPHPSOM5huzCbtq7SE06bx4X/DQuzGyvVYCxu7qtmH6roTkGRccqyvRCoFplzAzD+X1FrDthzJY0B3eVA3SsgEgcBswVC0qaSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pjA1wDACamPBIavzDa3U2kJc3Ji464I5quEEqDqAaX0=; b=Gh4mBA/B4GP9pv1iPbyh2LylV8sgUpi6OS3/pD0xo+tMd1CxsfrN3NG9Nw3u4k31noWoeEdw5+o01eKf6DqaUly2gSczkED6blSmWdgIoW94Pq+STVD33hbOl+uRR7jaUc3moogoZhQHV0RInIHDwvvLwxHy++dJa0j00V70TDW0roSGMS7SEmHKCY+hxCdO2C9WFD+g6FUdL4jKFqzcZFMf5PBD1nXHJLTBTr5Xl/KUJmT3MfvBN4LzcSrdxN8tCRss1BbobMsIGuLJ7hEqwV0Fy7G6IiTqi+xncQ7r8/zN/TaNekfpQljLziO1ugWgdhEwwUOQR1UKGlOUYpJ+ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjA1wDACamPBIavzDa3U2kJc3Ji464I5quEEqDqAaX0=; b=0Q/n6yeDRQWYVpkCXV59f6n+yVdhRCFjNhl3NPCXk2mSNvvk0NxW2z7Dhdv2p0V9xMRbiH73vplArHujCuutxpHs6uqe3Aq6zTW/G2NyPKId6gGjf3fbktMkWvrHnvvinZTj4HCxSpFuj0O9z/wvLRUyP2NrvNcXcT/insWJSRVYZtNiJwSifYPK8UP4v1igYg/28zR0uYKgK5HTDccnvtP/923sgjM0gP1ckl8q46d+WUCNq5zpuvPO4sZ7/TctCS/LfA5NG7MzykJtjTm82IE4iBDJLt1yeBPGC/ikXejI4CIpIZ2ylMKUP4016Y5xBYSwH04zKqbwgwAXblTKQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> Date: Thu, 15 Sep 2022 16:10:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Console output stops on dbgp=xhci Content-Language: en-US To: Tamas K Lengyel Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0111.eurprd04.prod.outlook.com (2603:10a6:20b:531::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9269:EE_ X-MS-Office365-Filtering-Correlation-Id: b5f8e68b-d2d8-4e85-eaaf-08da9724014a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cEtqiXb4/R2Aikf490l/5gN0yJ9G1JgFSi9eigDVzicON/cCWC6k+q2d+oy+0TbvhQ+KvShLw7Lum+1C37CPlmdvKh46RteUnFE2CfYQZM3GmsOxLhFR4RI0Y8pgVe/lCsQRTXR5WhVJOlXPvuqUIaSS69MA1eyMsfnCI0fD/wfkMdXgCjJSEvPoNLdhzrPq8xGyIEXbVN8ivK0r1oW5jW1ZAR16UsJZPe4JlvOKKWbT4mpMyh3eXGvQ+Ibw/IyNfngKecLwIjjs+EAlEJ5SnVRAlqQoDpy+0AsOdAu3Tx323Mkq+xza/RrIPqXnFuJd9jSy/2dZIDqXYg17dHo0WrPJn5TvGihPXASwuYwpy/3+K1suXjZgaPQTkXNs3QNdHUjFlm9Ay9ci44zHaYrGQufLa/TxU/NQvF3dNvvPP8n9kbiVK7PIy/ozEcRXn3iT3cudJtx62vFBeFmkQ6j14Ao8QjEquYpkJ0VJqDWpT+TJl6IE58EuaSu2TPQKTHcrNQ+xYquvxIs1ThyK2L6Yozs46Gvbcx5knRqalypUpI5ShCITVqPID+MAYBHbrKWgPIV+WFM5EnPe2qoyeWAYrQ/v2BJ40klmZpa14DwUxpd2RMHR4fBgGdA0icJe9h2uQIiNTY/u4EdfhqyPJ0XF5ib7NGY9guLezDPfir/PzJoxYoh7Jf59Abx9q0yZRIMVarXYrgH9GGyuVJIY//U3v6egLs2YX6Nb0QhgMBxBr0mniAxDEYCbhnfDt28bSo6p3f9t36iTotrGRnrYhV6mk8dNHzuXIInbIAgAu4kmHrQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(31686004)(186003)(83380400001)(316002)(6486002)(41300700001)(38100700002)(53546011)(8676002)(54906003)(478600001)(6506007)(6512007)(6916009)(66476007)(2616005)(66946007)(66556008)(8936002)(4326008)(2906002)(26005)(5660300002)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXRPS0ZxZjRiV0lKUEVZLzFCdmF4b0lLSURocU5Qa2xFOGYxQW80V25qREgx?= =?utf-8?B?aW5iRFMrZEkwcFFUS3JPSFNTMlpzS2FJa1pTRzZsLzZOM1p0N0tmd25xV01W?= =?utf-8?B?SFdPUmlneTNUY2lDTE15QmNEbnhTTXNLeU9CR1Ezd1l6cXFNL2JRR3ZNcVNO?= =?utf-8?B?L3o3ZmhOSWdBVEVMQ2p2eFloenNnZ0lFWVFRNUhTY25UTnJ2QmF0bVdCRHdz?= =?utf-8?B?alk3TXFtcmtxTTJOTDVqM0dsL2lBQW96TE90QnRVRXhNRWFFZlR4cG5JcGVR?= =?utf-8?B?d0RDdHhiUlZHVlp1R0ZuWmV2aVhJY1I3MllydjZtTm5nYmZ4ZnNsa0lGbms3?= =?utf-8?B?WnFBN2VORjl3dEV3KzZBcnA5cGhlemJVWXQyTkVEajR4ZWJlNHZteG81OFNl?= =?utf-8?B?Y0R0Mkc4dHBBbGVVZCsvUExRRHJPWHMvVFUvbEpCNHBoM2ZFUEU5WGdldlh5?= =?utf-8?B?YmJzejJEa3BENDN2bENmZWhkOVlKU0RjN2FsU01GWEdPTnZ0eHVPL0g0dGVh?= =?utf-8?B?TkthVDZiL0NrSFRwWW53bjdNUExBSnArZkE2cUxGbVdkL1ZMOHBGS1lWemdT?= =?utf-8?B?VTBQbkhkcTArczRMenJIc3pxZ3BiZTZpM0NseTJRMWg4WWMyY3J2Y28xN1VE?= =?utf-8?B?NjZUL0RNTVlGcmdSZXZEcEtWTWYvOVQvT0dsd2JpQnNvQmlidlZiZW05cDJH?= =?utf-8?B?WWt3TE1CZDVUTzl4VnNUTnNiSFIvNnJGaFQ2NnU0amNNK0FITVJ1MVFBUjRS?= =?utf-8?B?QUdsbFlmZ0EwZlFya2tXalNFYm1PWjkwTWhQL2pHdGVZOFFaV3IzS0xlV0kx?= =?utf-8?B?ckxERUlOOEltbVUzaUM4YXQxR2VsYStEVzJVNGZXN2YwY2hXaUVxSHBmTVU5?= =?utf-8?B?TVFxUFJrNE00RGFKN1NZMzl2VndNQWsvVW92QnE5WDBQVjNBSmhIQ2hSVlRU?= =?utf-8?B?WmhuODZ5T0NuYzNoaEtPaVVBcHZwTlUzZTBhZkYyYUp2cXVLK0RpYlBzMEdB?= =?utf-8?B?aTVLSlN1bDd2eldsTXNaenZkVHlhVUFLbzZZM25XT3Q5elZHcE9jQkRYM3JB?= =?utf-8?B?TkZVd0sybC9KbmdNcGhYOVI2dVE2emRnWXVOYnhnVjRaQkpkeXNlN011d1N3?= =?utf-8?B?VVVtbURlNndocnQ4SFFMYW11NEJoNlp0Y2ZEQWJpbTNQRnN3aVU5VzUxL0tx?= =?utf-8?B?SlYyU0VUbmIvRU1lM0FkUDRDeHdjN3UyWFZ0TjA5S3lMM1JNSmRrWnVnY05C?= =?utf-8?B?eFpKM21paDlqZW01VFk1OUUxYmx1Z0R2ZStGcEFUYXlxamlUa3JKektxS1hE?= =?utf-8?B?L096Ujl0ZWJnaFZGd01uQW0xYk1DZm1ZbStmNHp6aUZ1VFMrNnIrZURlbFhj?= =?utf-8?B?b05DSDBXUFZ0d2xLdlFVMHRmdFMzMm14a0dXRGRuZVR0RkJkR1JOWWhCWnFL?= =?utf-8?B?SUdZMmdiSC9CZVc5TUVibS94MFZjRStudEFqZFFUUnM2MHpqTXRSSUlXNGI2?= =?utf-8?B?bzR1c0RYTk9nOHFCYlRZRS9YRUhKOUpXbDNWQzdXb0p1WllPMGt1am80ODNk?= =?utf-8?B?cVhYc1hpUmp0aC9aVlFzVnNoTGdjLzJTYkdzZGJLc0VaczRDT2x2cHpVN1l4?= =?utf-8?B?RVduQkJqRjNic015NjlmMm16RUU4c3BqSGNpdnYzOGlGdG9hMzIzOGROYlg5?= =?utf-8?B?a2wydVFaR3NKM28xZUdMK2prZmxwZU1nWjdZR3V5bWV4S0RTVHVYNW14Wnhh?= =?utf-8?B?RjQ5Ykljb0pDdjVpM2t3YlJ5cFEzQTFOQlg3bm9Bc1pYTm9KMHd1bVNvVTlS?= =?utf-8?B?ejhoL2U5bW9jQU42WW5ZcHJvY2Z4NUFpdTFyNDYxTnU2eTIwZzU4QnJQd1dp?= =?utf-8?B?TTdCV1J0dVNRTWFxT2d1V3RyTHR5alNvWDlPSzdVdm41TFRDb0dsK0Z1QVMz?= =?utf-8?B?eG9FSXNXS1hORjMzTmhvZlA3UUZpM1gvdCtKdFAvRzd1a2xkZFo1OE10Nitl?= =?utf-8?B?RUxadnZVUEhsWVlsMGF2SlZ0WHQvVGNJd0FRaHladTdjbmRDd29aM2E4bjQx?= =?utf-8?B?Y0VLM0JRZDdpWmVTTHVaYUtlNmVvTHBBYTF6ZXM5QnJ6VHV0SW9ZNzM3N1hq?= =?utf-8?Q?QpH8bDrAelEegiHE+pxpJkxwG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5f8e68b-d2d8-4e85-eaaf-08da9724014a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 14:10:12.3900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YIkLmctcCsf61PyREy1/7zYxKwvTm1rUmdDtWruQR5O/7VJZBjTyn5aXM1AJ0kD7b3M/wuDnr35qr+7nqqpQ1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9269 On 15.09.2022 16:05, Tamas K Lengyel wrote: > On Thu, Sep 15, 2022 at 3:56 AM Jan Beulich wrote: >> >> On 15.09.2022 02:41, Tamas K Lengyel wrote: >>>>> Do you have any idea what might be going on and preventing the output >>>>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still >>>>> present on the receiving side, just nothing is being received over it. >>>> >>>> There are few more patches in the series that are de facto required. >>>> Especially those about IOMMU, otherwise it can only possibly work with >>>> iommu=0 (which I'm not sure if even is enough). >>> >>> Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this >>> on the console: >>> >>> (XEN) Panic on CPU 0: >>> (XEN) FATAL PAGE FAULT >>> (XEN) [error_code=0011] >>> (XEN) Faulting linear address: 00000000328b3a54 >> >> Perhaps in another thread, could you post details about this? I guess >> we want to address this independent of your XHCI issue. That's an >> attempt to execute code outside of the Xen image - the only reason I >> can think of for this would be an EFI boot services or runtime >> services call, with (possibly but not necessarily) quirky EFI firmware. >> Any other context this is appearing in would quite certainly require a >> fix in Xen, and I don't see how "iommu=0" could affect the set of EFI >> calls we make. > > This was indeed observed with a xen.efi booted directly from UEFI. > Beside the limited boot log I get through xhci I don't have more > insight but happy to send that (and anything else you think would be > useful). And with "iommu=0" but no use of XHCI it doesn't crash? Or there you have no way to collect the log then? In any event, from your description the interesting part might be the EFI memory map. That ought to be pretty stable between boots, so you may be able to collect that in full via "xl dmesg" in a run without "iommu=0". Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:11:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:11:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407414.649931 (Exim 4.92) (envelope-from ) id 1oYpaD-0007m5-TJ; Thu, 15 Sep 2022 14:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407414.649931; Thu, 15 Sep 2022 14:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpaD-0007ly-Qm; Thu, 15 Sep 2022 14:11:13 +0000 Received: by outflank-mailman (input) for mailman id 407414; Thu, 15 Sep 2022 14:11:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpaC-0007Wm-5e for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:11:12 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cf3d91d-3500-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:11:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cf3d91d-3500-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663251067; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=jFF9lcmlFyPX/dnwX68oXyE9c54ljx1Iupap8m0/STI=; b=bNzGHToGJFtS+Y9YF6w3MDbBkwBrdg7Fd59D0EFjoboQk/O6ZZotWPKu FFfRxNB2CoW40RMNTsSUW0VKSF6YUuwonSnt2/Cl2InkDjGlF2pyTWwGy wW8Tigtvi6oXcCK2l9AUFzIGKrGmhTwGF+rcVNX9M27Fc05wewIi/OYZo g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80582908 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:zRx7LKtbBs0CWtyrqgjHa0js6OfnVD5eMUV32f8akzHdYApBsoF/q tZmKW6PPa3bM2bwc9glYdiw8BlXvMTWzdZnT1dr/CthFXlG+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4W5A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fa0EubwsUFMVz 99CNgsddyHet/rn+q3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYIKIKobbHZU9ckCwm G+b+HakCx8gENG9kzm7107vgd/kpHauMG4VPOLhraM76LGJ/UQRFRkXWF2TsfS/zEmkVLp3K lMW0jojq7Ao806mRcW7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/ gbXxZWzX2Up6eDLDyLGnluJkd+sEQgJbjVZNB1fdyhf/eLzubBuvgqedMk2RcZZkebJ9SHML yGi9XZg3O1O15ZWic1X7nic3Wvy+8Ghohodo1yOAzn7tl4RiJuNPdTA1LTN0RpXwG91pHGlt WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43Nzgbb1HRcNJG8yFoSLLQGypyGgWyL1VGsgFYyT1R 0TYpBlc4pReVFPzM/EsOtLpVplznPi4fTgAahwzRoMXCqWdiSfdpH0+DaJu9zqFfLcQfVEXZ s7ALJfE4YcyAqV71jumL9ogPUsQ7nlnnQvuqWXTlUvPPUy2OCHIEt/o8TKmMogE0U9ziFyMr ooAZ5LRlU83vS+XSnC/zLP/5GsidRATba0aYeQNL4Zv/iIO9LkdNsLs IronPort-HdrOrdr: A9a23:MW6VCK7AoH57SbtfTAPXwM7XdLJyesId70hD6qhwISY6TiW9rb HLoB19726StN9xYgBEpTnuAsS9qB/nmaKdpLNhW4tKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM RdmsBFeaTN5DNB7PoSjjPWL+od X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="80582908" Date: Thu, 15 Sep 2022 15:10:59 +0100 From: Anthony PERARD To: Roger Pau Monne CC: , Ian Jackson , "Julien Grall" Subject: Re: [PATCH] libvirt: disable Werror for non-libvirt flights Message-ID: References: <20220913100328.27771-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220913100328.27771-1-roger.pau@citrix.com> On Tue, Sep 13, 2022 at 12:03:28PM +0200, Roger Pau Monne wrote: > Current usage of Werror=switch-enum by default for libvirt builds out > of the git tree causes issues when new items are added to libxl public > API enums if those are used in a switch statement in libvirt code. > This leads to libvirt build failures for seemingly unrelated libxl > changes. > > In order to prevent those errors from blocking the push gate, disable > Werror for libvirt builds when not in a libvirt specific flight. > > The errors will be reported on the libvirt flight, and block the > pushes there. So the author of the changes in libxl is still expected > to send a fix to libvirt code. This is no ideal, but the other option > is to just disable Werror for all libvirt builds and let libvirt > developers fix the breakage when they notice it. > > runvar differences for a xen-unstable flight are: > > --- /dev/fd/63 2022-09-13 09:53:58.044441678 +0000 > +++ /dev/fd/62 2022-09-13 09:53:58.044441678 +0000 > @@ -574,6 +574,10 @@ > test-xtf-amd64-amd64-3 arch amd64 > test-xtf-amd64-amd64-4 arch amd64 > test-xtf-amd64-amd64-5 arch amd64 > +build-amd64-libvirt autogen_options --disable-werror > +build-arm64-libvirt autogen_options --disable-werror > +build-armhf-libvirt autogen_options --disable-werror > +build-i386-libvirt autogen_options --disable-werror > test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm bios seabios > test-amd64-amd64-qemuu-nested-amd bios seabios > test-amd64-amd64-qemuu-nested-intel bios seabios > @@ -1217,6 +1221,10 @@ > build-arm64-libvirt make_njobs 1 > build-armhf-libvirt make_njobs 1 > build-i386-libvirt make_njobs 1 > +build-amd64-libvirt meson_options -Dgit_werror=disabled > +build-arm64-libvirt meson_options -Dgit_werror=disabled > +build-armhf-libvirt meson_options -Dgit_werror=disabled > +build-i386-libvirt meson_options -Dgit_werror=disabled > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true > test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_nomigrate true For "osstest" flight or "xen-unstable-smoke" flight, we would have the same difference, right? The only branch with no change would be libvirt, right? > > Signed-off-by: Roger Pau Monn > --- > I'm unsure whether we want o disable Werror even for libvirt flights, > but this seems more conservative. > > This does at least unblock the libvirt builds for both the > xen-unstable and the libvirt flights. > --- > Cc: Ian Jackson > Cc: Anthony PERARD > Cc: Julien Grall > --- > mfi-common | 2 +- > ts-libvirt-build | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mfi-common b/mfi-common > index 59e712f4..450229e9 100644 > --- a/mfi-common > +++ b/mfi-common > @@ -459,7 +459,7 @@ create_build_jobs () { > libvirt_build_runvars='' > case "$branch" in > libvirt*) ;; > - *) libvirt_build_runvars+=" make_njobs=1";; > + *) libvirt_build_runvars+=" make_njobs=1 meson_options=-Dgit_werror=disabled autogen_options=--disable-werror";; For meson, I think '-Dwerror=false' would be enough, instead of the unusual 'git_werror' configuration. But, we might not need to disable all errors, for meson we can have: -Dc_args='-Wno-error=switch -Wno-error=switch-enum' But disabling werror is fine too, as less likely to be an issue later. Both 'werror' and 'c_args' seems to be meson built-in options rather than options implemented for only libvirt. https://mesonbuild.com/Builtin-options.html While 'git_werror' is libvirt only. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:16:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:16:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407423.649943 (Exim 4.92) (envelope-from ) id 1oYpfW-00005h-HP; Thu, 15 Sep 2022 14:16:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407423.649943; Thu, 15 Sep 2022 14:16:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpfW-00005Z-Eo; Thu, 15 Sep 2022 14:16:42 +0000 Received: by outflank-mailman (input) for mailman id 407423; Thu, 15 Sep 2022 14:16:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpfV-00005T-3x for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:16:41 +0000 Received: from MTA-11-3.privateemail.com (mta-11-3.privateemail.com [198.54.122.105]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0334041a-3501-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:16:39 +0200 (CEST) Received: from mta-11.privateemail.com (localhost [127.0.0.1]) by mta-11.privateemail.com (Postfix) with ESMTP id AC86718000A9 for ; Thu, 15 Sep 2022 10:16:37 -0400 (EDT) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by mta-11.privateemail.com (Postfix) with ESMTPA id 8712018000A4 for ; Thu, 15 Sep 2022 10:16:37 -0400 (EDT) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-3321c2a8d4cso222291827b3.5 for ; Thu, 15 Sep 2022 07:16:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0334041a-3501-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1663251397; bh=fAcQ92HRAYdVimKlK+uqkmFsfjVtOfVJWk9TUw4Gge0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WO3JE8gRm6u3+FUDavA8b2j27gZIWEl6ZgvEParG4m21fkPEu8u6HnZRJZLAEXHBp QvpbtZd6peERlKe3ATcUr5q3oqpaXhUUBilSVmVsbYovWvAEkl1/JLsDyxM2bnjJ3y Gf2+pwVfqY3fS8DLw/inJuP3EFXUPiU81haV7l8vR/HXter0RiCJMb3KU9SUs/e9bU uJKH6PfUYuAEGJ9uXL/fPUW2gYreh54jnNW5jmuJSxZ/uhSyRS0Ud1ez0ZyOo/d68S rIATTcQELQSRU/tv90tmZEFF0YPDNRJd2NOa74yJNL34g0f1pEbz0WlKvBrF2Ok19l vX/Ay0tg7/8bQ== X-Gm-Message-State: ACrzQf02qXk9R7r9XPOqoFKaST9N6pQpwmr15XRhgBD+wmRF7uDeEf9p xN72L7RxISIlGZc9teXG8ruVIf94h5ux8BZ91F0= X-Google-Smtp-Source: AMsMyM42+qYKtuotJxuZlXRUwuv+sHkQpOK3KNYCKA8ab3IAAcN2CbkWpIjzfDIQkeRww954ouRjBuJzcx/0xsDrzKA= X-Received: by 2002:a81:840f:0:b0:345:efb:1a2a with SMTP id u15-20020a81840f000000b003450efb1a2amr22098ywf.204.1663251396704; Thu, 15 Sep 2022 07:16:36 -0700 (PDT) MIME-Version: 1.0 References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> In-Reply-To: <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> From: Tamas K Lengyel Date: Thu, 15 Sep 2022 10:16:00 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Console output stops on dbgp=xhci To: Jan Beulich Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Sep 15, 2022 at 10:10 AM Jan Beulich wrote: > > On 15.09.2022 16:05, Tamas K Lengyel wrote: > > On Thu, Sep 15, 2022 at 3:56 AM Jan Beulich wrote: > >> > >> On 15.09.2022 02:41, Tamas K Lengyel wrote: > >>>>> Do you have any idea what might be going on and preventing the output > >>>>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still > >>>>> present on the receiving side, just nothing is being received over it. > >>>> > >>>> There are few more patches in the series that are de facto required. > >>>> Especially those about IOMMU, otherwise it can only possibly work with > >>>> iommu=0 (which I'm not sure if even is enough). > >>> > >>> Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this > >>> on the console: > >>> > >>> (XEN) Panic on CPU 0: > >>> (XEN) FATAL PAGE FAULT > >>> (XEN) [error_code=0011] > >>> (XEN) Faulting linear address: 00000000328b3a54 > >> > >> Perhaps in another thread, could you post details about this? I guess > >> we want to address this independent of your XHCI issue. That's an > >> attempt to execute code outside of the Xen image - the only reason I > >> can think of for this would be an EFI boot services or runtime > >> services call, with (possibly but not necessarily) quirky EFI firmware. > >> Any other context this is appearing in would quite certainly require a > >> fix in Xen, and I don't see how "iommu=0" could affect the set of EFI > >> calls we make. > > > > This was indeed observed with a xen.efi booted directly from UEFI. > > Beside the limited boot log I get through xhci I don't have more > > insight but happy to send that (and anything else you think would be > > useful). > > And with "iommu=0" but no use of XHCI it doesn't crash? Or there you have > no way to collect the log then? > > In any event, from your description the interesting part might be the > EFI memory map. That ought to be pretty stable between boots, so you may > be able to collect that in full via "xl dmesg" in a run without "iommu=0". I see the same crash with no xhci debug use. The EFI map is: (XEN) EFI memory map: (XEN) 0000000000000-000000009bfff type=7 attr=000000000000000f (XEN) 000000009c000-000000009dfff type=2 attr=000000000000000f (XEN) 000000009e000-000000009efff type=0 attr=000000000000000f (XEN) 000000009f000-000000009ffff type=4 attr=000000000000000f (XEN) 0000000100000-00000175a6fff type=7 attr=000000000000000f (XEN) 00000175a7000-00000175e6fff type=4 attr=000000000000000f (XEN) 00000175e7000-0000021e9efff type=7 attr=000000000000000f (XEN) 0000021e9f000-0000028587fff type=2 attr=000000000000000f (XEN) 0000028588000-000002ab79fff type=1 attr=000000000000000f (XEN) 000002ab7a000-000002bcd7fff type=7 attr=000000000000000f (XEN) 000002bcd8000-000002c6cafff type=2 attr=000000000000000f (XEN) 000002c6cb000-000002cd8cfff type=4 attr=000000000000000f (XEN) 000002cd8d000-000002cdcefff type=7 attr=000000000000000f (XEN) 000002cdcf000-000002ce77fff type=4 attr=000000000000000f (XEN) 000002ce78000-000002ced4fff type=7 attr=000000000000000f (XEN) 000002ced5000-000002ced7fff type=4 attr=000000000000000f (XEN) 000002ced8000-000002cedafff type=7 attr=000000000000000f (XEN) 000002cedb000-000002cedcfff type=4 attr=000000000000000f (XEN) 000002cedd000-000002ceddfff type=7 attr=000000000000000f (XEN) 000002cede000-000002e179fff type=4 attr=000000000000000f (XEN) 000002e17a000-000002e194fff type=3 attr=000000000000000f (XEN) 000002e195000-000002e1bffff type=4 attr=000000000000000f (XEN) 000002e1c0000-000002e1c9fff type=3 attr=000000000000000f (XEN) 000002e1ca000-000002e1e3fff type=4 attr=000000000000000f (XEN) 000002e1e4000-000002e1edfff type=3 attr=000000000000000f (XEN) 000002e1ee000-000002e1f2fff type=4 attr=000000000000000f (XEN) 000002e1f3000-000002e20dfff type=3 attr=000000000000000f (XEN) 000002e20e000-000002e22cfff type=4 attr=000000000000000f (XEN) 000002e22d000-000002e22efff type=3 attr=000000000000000f (XEN) 000002e22f000-000002e233fff type=4 attr=000000000000000f (XEN) 000002e234000-000002e236fff type=3 attr=000000000000000f (XEN) 000002e237000-000002e23dfff type=4 attr=000000000000000f (XEN) 000002e23e000-000002e23ffff type=3 attr=000000000000000f (XEN) 000002e240000-000002e245fff type=4 attr=000000000000000f (XEN) 000002e246000-000002e246fff type=3 attr=000000000000000f (XEN) 000002e247000-000002e24bfff type=4 attr=000000000000000f (XEN) 000002e24c000-000002e250fff type=3 attr=000000000000000f (XEN) 000002e251000-000002e26afff type=4 attr=000000000000000f (XEN) 000002e26b000-000002e29dfff type=3 attr=000000000000000f (XEN) 000002e29e000-000002e2d4fff type=4 attr=000000000000000f (XEN) 000002e2d5000-000002e2d5fff type=3 attr=000000000000000f (XEN) 000002e2d6000-000002e2e6fff type=4 attr=000000000000000f (XEN) 000002e2e7000-000002e2e7fff type=3 attr=000000000000000f (XEN) 000002e2e8000-000002e2f8fff type=4 attr=000000000000000f (XEN) 000002e2f9000-000002e2fbfff type=3 attr=000000000000000f (XEN) 000002e2fc000-000002e30efff type=4 attr=000000000000000f (XEN) 000002e30f000-000002e30ffff type=3 attr=000000000000000f (XEN) 000002e310000-000002e320fff type=4 attr=000000000000000f (XEN) 000002e321000-000002e340fff type=3 attr=000000000000000f (XEN) 000002e341000-000002e341fff type=4 attr=000000000000000f (XEN) 000002e342000-000002e352fff type=3 attr=000000000000000f (XEN) 000002e353000-000002e3edfff type=4 attr=000000000000000f (XEN) 000002e3ee000-000002e3f4fff type=3 attr=000000000000000f (XEN) 000002e3f5000-000002e40bfff type=4 attr=000000000000000f (XEN) 000002e40c000-000002e417fff type=3 attr=000000000000000f (XEN) 000002e418000-000002e42efff type=4 attr=000000000000000f (XEN) 000002e42f000-000002e42ffff type=3 attr=000000000000000f (XEN) 000002e430000-000002e440fff type=4 attr=000000000000000f (XEN) 000002e441000-000002e444fff type=3 attr=000000000000000f (XEN) 000002e445000-000002f56cfff type=4 attr=000000000000000f (XEN) 000002f56d000-000002f588fff type=3 attr=000000000000000f (XEN) 000002f589000-0000031ca5fff type=4 attr=000000000000000f (XEN) 0000031ca6000-0000031f71fff type=7 attr=000000000000000f (XEN) 0000031f72000-0000032a95fff type=3 attr=000000000000000f (XEN) 0000032a96000-0000034f95fff type=0 attr=000000000000000f (XEN) 0000034f96000-0000035215fff type=9 attr=000000000000000f (XEN) 0000035216000-0000035323fff type=10 attr=000000000000000f (XEN) 0000035324000-0000035efefff type=6 attr=800000000000000f (XEN) 0000035eff000-0000035ffefff type=5 attr=800000000000000f (XEN) 0000035fff000-0000035ffffff type=4 attr=000000000000000f (XEN) 0000100000000-00008c07fffff type=7 attr=000000000000000f (XEN) 00000000a0000-00000000fffff type=0 attr=0000000000000000 (XEN) 0000036000000-0000039ffffff type=0 attr=000000000000000f (XEN) 000003a000000-000003affffff type=0 attr=0000000000000009 (XEN) 000003b000000-000003f7fffff type=0 attr=0000000000000000 (XEN) 00000e0000000-00000efffffff type=11 attr=8000000000000001 (XEN) 00000fc000000-00000fc01ffff type=11 attr=800000000000100d (XEN) 00000fe000000-00000fe010fff type=11 attr=8000000000000001 (XEN) 00000fec00000-00000fec00fff type=11 attr=8000000000000001 (XEN) 00000fed00000-00000fed00fff type=11 attr=8000000000000001 (XEN) 00000fed20000-00000fed7ffff type=0 attr=0000000000000000 (XEN) 00000fee00000-00000fee00fff type=11 attr=8000000000000001 (XEN) 00000ff000000-00000ffffffff type=11 attr=800000000000100d (XEN) alt table ffff82d0406953b0 -> ffff82d040697686 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:18:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:18:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407431.649953 (Exim 4.92) (envelope-from ) id 1oYphQ-0000k9-0Z; Thu, 15 Sep 2022 14:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407431.649953; Thu, 15 Sep 2022 14:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYphP-0000k2-Tw; Thu, 15 Sep 2022 14:18:39 +0000 Received: by outflank-mailman (input) for mailman id 407431; Thu, 15 Sep 2022 14:18:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYphP-0000jw-18 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:18:39 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47cdbc97-3501-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:18:36 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 20C585C00B0; Thu, 15 Sep 2022 10:18:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 15 Sep 2022 10:18:33 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 10:18:32 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47cdbc97-3501-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663251513; x=1663337913; bh=uc+XqR1G3a dX/UrFkfpba42CUdgp2P3R7dUvUugk9ks=; b=WR8LTooNu/Y5Rsp8H6T2wm3hTE wv62Gtcbuwyeg6Gw0b3V/dFBV+GeW3yDJGtnH3s6pD6vTgZ61rKCCSjYVJ8NbsSc YWQpK6HroauI+tV8lOTsSIs+wTuDpc7PUvU5mK+QMBmRPdpS3eejDPqWeQvNXsJR cDDPEIL6F/LLWlplE1IPGUKkZid9gmPSCahsbKxzJZQISY6/D3jsTFCxBKqth+l8 91JDSoJ/uiqfZfoPjHtpB9HYUF9sfL+wHlLc29TC5s3KguebulzAoUeWZD6XabC/ VUArKbQLmw6GNwmsFMXGoVYUM118IthRivGGcF01+e6WjChZfsfsiBLToNuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663251513; x= 1663337913; bh=uc+XqR1G3adX/UrFkfpba42CUdgp2P3R7dUvUugk9ks=; b=r ulSo8nOOwbQ1MoJayIE1NQfamD9wZBC+Hcr1Mgfvn0FFU0dL0oZvCbx7e4MJY5Bj kI8EBrTgdwmzuVm2NvyfGuk5JnH5e8/RSnAPulb5nsrdTzcQJ93uZ6/mDFty9JnY IdA/9/1R3njJWz04aznAhndwvz0H69p6OXIam2uDUBFM45Knfb/x7omuBYXKlWXN UiD+sB4WC+59CG0Bfdv3MHtiUvPqYTZnTfjGsfETlQiJbH+LRRJjWrQNBjRgN4zE Ivu7X8+yoD/B48cuVHudW6SikOxztecStVIGh7lPUsi1Gw/EyQ9RMAoFh0Vy063n s3T1BzdcmhQ8UWReI3zhw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtgfgjgesthekredttddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteehueelveejteefuefhgffhudfg hfejgedtgedthfeuteegteetleevveethefhnecuffhomhgrihhnpehinhhtvghlrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggv mhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 15 Sep 2022 10:18:30 -0400 From: Demi Marie Obenour To: Julien Grall , Jan Beulich , "xen-devel@lists.xenproject.org" , Qubes OS Development Mailing List Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Henry Wang , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Simon Gaiser Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode Message-ID: References: <006c5779-2ee5-0e37-1b00-c6c58ef57c71@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; x-action=pgp-signed Content-Transfer-Encoding: 8bit In-Reply-To: <006c5779-2ee5-0e37-1b00-c6c58ef57c71@xen.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Thu, Sep 15, 2022 at 01:56:06PM +0100, Julien Grall wrote: > Hi Demi, > > On 15/09/2022 12:24, Demi Marie Obenour wrote: > > On Thu, Sep 15, 2022 at 12:04:55PM +0200, Jan Beulich wrote: > > > [1] specifies a long list of instructions which are intended to exhibit > > > timing behavior independent of the data they operate on. On certain > > > hardware this independence is optional, controlled by a bit in a new > > > MSR. Provide a command line option to control the mode Xen and its > > > guests are to operate in, with a build time control over the default. > > > Longer term we may want to allow guests to control this. > > > > > Since Arm64 supposedly also has such a control, put command line option > > > and Kconfig control in common files. > > > > > [1] https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html > > > > > Requested-by: Demi Marie Obenour > > > Signed-off-by: Jan Beulich > > > > Thanks for the patch, Jan! > > > > > This may be viewed as a new feature, and hence be too late for 4.17. It > > > may, however, also be viewed as security relevant, which is why I'd like > > > to propose to at least consider it. > > > > I consider it security relevant indeed, which is why I was so insistent > > on it. Whether it is worth a full XSA is up to the Xen Security Team. > > If it could be backported to stable releases, that would be great. > > > > Marek, Simon, would you consider backporting this to R4.1? > > > > > Slightly RFC, in particular for whether the Kconfig option should > > > default to Y or N. > > > > I think it should default to Y as long as guests do not have the ability > > to control this. > > This raises two questions: > 1) What is the performance impact to turn this on by default? I am looking > for actual numbers. I do not have access to such hardware and so cannot provide such numbers. I was hoping that someone else would be able to do the needed benchmarking. > 2) What happen on HW that doesn't support DIT? Are we going to mark them as > unsupported? The relevant text in Intel’s documentation is: > For Intel® Core™ family processors based on microarchitectures before > Ice Lake and Intel Atom® family processors based on microarchitectures > before Gracemont that do not enumerate IA32_UARCH_MISC_CTL, developers > may assume that the instructions listed here operate as if DOITM is > enabled. > > Intel Core family processors based on Ice Lake and later, such as > Tiger Lake, Lakefield, and Rocket Lake will enumerate DOITM. Intel > Atom processors based on Gracemont and later will also enumerate > DOITM. Refer to the Enumeration and Architectural MSRs section for > more information. In other words, no action is needed (or possible) on CPUs that do not enumerate DOITM. CPUs that do enumerate DOITM require it to be explicitly enabled by for cryptographic code to be secure. This was a poor design decision on Intel’s part, which might be why it appears that Linux will treat DOITM as a CPU bug. > > Otherwise any cryptographic code in the guests thinks > > it is constant time when it may not be. > > Why would a guest think that? Are we telling the guest DIT is supported but > doesn't honour it? Xen is telling guests that DOITM is not required for constant-time operation of cryptographic code, even though the hardware actually requires it. Furthermore, Xen does not allow guests to set DOITM. > If yes, then I would argue that we should clear that bit. Otherwise... Xen actually needs to *set* that bit, not clear it. > > Once guests have the ability to > > control this I would be open to reconsidering this. > > ... this will introduce a problem once we expose it to the guest because we > cannot change the global default as some user my start to rely on it on the > default. I would be fine with requiring the toolstack to opt-out from the safe default. - -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMjNDYACgkQsoi1X/+c IsEi+RAAskGqEC1ParSsfyWS7fw9mhKzH+pS+IsKE5tjCu1l6Ctub17qqysC3Oej yzqMPuK+YwwEW5X3SNlnd6Qs5C/2XIdkr8cwB8PitjMabS1dvJu01qIRbIyMDM2i ii9qtuTLCDUAz5rrLW+qr0TE9vBcfteOKzkcWkmQQpWjermZHy+lHooXNmwjS9oc J+nGbUWhNy1uNvFA+sUjEcEucAlSyM7UWkL/c9FzfWV2UwPWppdGpyz7jrRdZT+H brb3FwRd1hoS4t94Xv9ynzZ9K7KeEZ5pF8rKOoKh0cfZ9Ydcuh0wr9dtD6aWTS3r I2rNQig6AqurCF6AVUIlwf6TYcI71BRNDB3SQNAh7h5yxjy1S0srE0RLIZXFiboz 0RAyq76NFWS9qN2BG11PvfaG665EL14+7I+xaJxeSwPOZlUmbhTznYN7thFlx5MC AxSwthokvIThiy1tpu3XdiU1zFWb5Spd4vwkSv/bo2fCPySECJ59tGsDtNvreJbf z7A1CB968bTdPJAsYgY2OkkO+zFm3vR+fmrSia5b5cHoY80Mb0FmxKrPKxcOsyHJ PJGoWMDxRxi0RTYi5nrI3qGWJSl9GpryQPX5jaB01mLcXHo/mmQB1PiFda+PioPa T/bwpiYCc06EyeuJBMfu0Gv9NYnAuDC7qBtJfjKzm+OofrfWzQI= =mpE9 -----END PGP SIGNATURE----- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:21:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:21:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407438.649965 (Exim 4.92) (envelope-from ) id 1oYpjt-00028b-Cd; Thu, 15 Sep 2022 14:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407438.649965; Thu, 15 Sep 2022 14:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpjt-00028U-9o; Thu, 15 Sep 2022 14:21:13 +0000 Received: by outflank-mailman (input) for mailman id 407438; Thu, 15 Sep 2022 14:21:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpjr-00028M-O0 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:21:12 +0000 Received: from server.eikelenboom.it (server.eikelenboom.it [91.121.65.215]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1dca4b7-3501-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 16:21:04 +0200 (CEST) Received: from 76-24-144-85.ftth.glasoperator.nl ([85.144.24.76]:42219 helo=[10.97.34.6]) by server.eikelenboom.it with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oYpjX-0006eu-NL; Thu, 15 Sep 2022 16:20:51 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1dca4b7-3501-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=22uognlqXI1+pHDvRBF2Ij3fKa4BYOwUs5ctj3tBVJQ=; b=UE/s+hXseF49gZ5LNSId9Ercfj AETi0neENLCJrx5csxzUl+hnvNSDYJ1cULxJ+GLAmngTxTgNZX1PgBGOkOc8nQcDwNCcEehfZe9pA JCTloRMdjvUhJeXP3pFu218noA0g0vMIRTly6ZSczrcB0Y2UYznAQQBC7shsU++9cFsM=; Message-ID: Date: Thu, 15 Sep 2022 16:21:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Bisected: drivers/block/xen-blkback/xenbus.c:327 xen_blkif_disconnect+0x24f/0x260 To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" References: <17313adf-2881-9902-0d66-a4e723158434@suse.com> Content-Language: nl-NL From: Sander Eikelenboom In-Reply-To: <17313adf-2881-9902-0d66-a4e723158434@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/09/2022 15:10, Juergen Gross wrote: > On 15.09.22 14:49, Sander Eikelenboom wrote: >> Hi Juergen, >> >> I'm having trouble booting my DomU's when trying to use a linux-5.19 kernel for >> both Dom0 and DomU. >> A dom0 5.19 kernel with a domU 5.18 kernel boots fine. >> I'm using durect kernel boot to boot the domU guest (kernel=  and ramdisk= >> parameters). >> >> Since both xen-blkback and xen-blkfront could be into play, >> I bisected this by keeping dom0 fixed as a 5.19 kernel and do the bisecting on >> the domU kernel. >> >> Bisecting leads to commit 4573240f0764ee79d7558d74fc535baa1e110d20 "xen/xenbus: >> eliminate xenbus_grant_ring()" >> Reverting this specific commit makes the domU boot fine again. >> >> I have added the splat from dom0 kernel below (from using 5.19.8 kernel for both >> dom0 and domU), >> the domU does not seem to have any interessting logging, >> apart from not being able to find the root filesystem. >> >> Do you have any ideas ? > > Ouch. What a silly, silly, silly error! > > Does the attached patch fix it for you? > > > Juergen Hi Juergen, Yes this fixes the problem, thanks ! -- Sander From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:31:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407446.649976 (Exim 4.92) (envelope-from ) id 1oYpu4-0003i1-Cf; Thu, 15 Sep 2022 14:31:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407446.649976; Thu, 15 Sep 2022 14:31:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpu4-0003hu-9m; Thu, 15 Sep 2022 14:31:44 +0000 Received: by outflank-mailman (input) for mailman id 407446; Thu, 15 Sep 2022 14:31:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpu2-0003hV-Kh for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:31:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d4e6c5c-3503-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 16:31:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D1CD31F8AF; Thu, 15 Sep 2022 14:31:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9DA73133B6; Thu, 15 Sep 2022 14:31:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DRsmJUw3I2OVegAAMHmgww (envelope-from ); Thu, 15 Sep 2022 14:31:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d4e6c5c-3503-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663252300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dzoAgu6mheUOzlynwIyePFbncbuBp9hucJwC4AGAEMg=; b=cBu5DlTCREcpIg2AL2xFilshrjAlZTvrjdO687YcesK9GrOmCA581P3FxwwuYLrZ+YkHpE Sf7gTfCFQhBDBDudEhF0MI7TmSLcA60AMgyUI28s9e2hH5T3IFxj25WBCY7sZwFQXroC3E yL1W20RErwozixvr7renhuJpHHkbSjI= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , stable@vger.kernel.org, Sander Eikelenboom Subject: [PATCH] xen/xenbus: fix xenbus_setup_ring() Date: Thu, 15 Sep 2022 16:31:37 +0200 Message-Id: <20220915143137.1763-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 4573240f0764 ("xen/xenbus: eliminate xenbus_grant_ring()") introduced an error for initialization of multi-page rings. Cc: stable@vger.kernel.org Fixes: 4573240f0764 ("xen/xenbus: eliminate xenbus_grant_ring()") Reported-by: Sander Eikelenboom Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_client.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index d5f3f763717e..caa5c5c32f8e 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c @@ -382,9 +382,10 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, unsigned long ring_size = nr_pages * XEN_PAGE_SIZE; grant_ref_t gref_head; unsigned int i; + void *addr; int ret; - *vaddr = alloc_pages_exact(ring_size, gfp | __GFP_ZERO); + addr = *vaddr = alloc_pages_exact(ring_size, gfp | __GFP_ZERO); if (!*vaddr) { ret = -ENOMEM; goto err; @@ -401,13 +402,15 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, unsigned long gfn; if (is_vmalloc_addr(*vaddr)) - gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr[i])); + gfn = pfn_to_gfn(vmalloc_to_pfn(addr)); else - gfn = virt_to_gfn(vaddr[i]); + gfn = virt_to_gfn(addr); grefs[i] = gnttab_claim_grant_reference(&gref_head); gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id, gfn, 0); + + addr += PAGE_SIZE; } return 0; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:39:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407452.649986 (Exim 4.92) (envelope-from ) id 1oYq1g-0004Ro-5n; Thu, 15 Sep 2022 14:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407452.649986; Thu, 15 Sep 2022 14:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq1g-0004Rh-2o; Thu, 15 Sep 2022 14:39:36 +0000 Received: by outflank-mailman (input) for mailman id 407452; Thu, 15 Sep 2022 14:39:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq1e-0004Rb-Po for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:39:34 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150040.outbound.protection.outlook.com [40.107.15.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36d3d0c0-3504-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 16:39:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8869.eurprd04.prod.outlook.com (2603:10a6:10:2e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 14:39:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 14:39:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36d3d0c0-3504-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JTmCdjUTgbSPElaMUWTasffHGgQgLop1F+OL0Ap7oRju8sLLqStpHTiEcyXcnW6ZchEbBjeZGxiKse8QvIiVW2VFj7WPH+4E51TtfCZqXx/vb915g5hCl5h0Tb0MwaWjFgQrII/uTeC/GCZn8LAZOK1rI/5AbHjEt8thZNBqf7c4Hw2myl2goEUNyX/UaySimb6gYy0+2SLIPXaHfdasRpLf2bDoR6KkEizgJF7mo5XOlfsiuVIJ4yRQq7Tkd4ho6gM0JwFRmMN37WHcICe5muJhxqgutrGci1FM4Ips+9sGvQ5g9x0F7sXIRgFJmVGa7U/KJcy0BlvEUsD4+P47tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kl7CfccAFIRqJWKpcv86uiY+IlhyONP2g04JkSvjdZk=; b=MXh6/THH93Y8v7HFJ8oK/DW31rLE6kCLOWaLeb9taVFk0NiO+jMU1vOXaXGCl7dvD5uct6Mot0eYyvLBdLE8H88pdxPhj4KY3vXHbf1dq8MqPmJ1SCX1WNnz8hVsMk+EKHVdDEY/pnSWrNuWz3aLdjTZzEiWMoh5jgfM1wWqTkPVcwpnFM6Ca5n6h6FKvbGApZHjK/U9uDUVE3yJZQB1Ba3Ap1B/zmZbU6ek7PGyNF2ZxL7NvsGeHQqaiNbghLoZl8a0E57pslRsgRXgVAV4THIYLsI5KY13/4erTNWucRHGO8so4sFr6vEo/KSfbTeud1mTSb7rxjbd4p10IrEAIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kl7CfccAFIRqJWKpcv86uiY+IlhyONP2g04JkSvjdZk=; b=YexeUztDJ9inXyE+1B9jWfNTxDrynFLkfNy8i3dmtS+052mkNq257/GJME8ICmhOn3IdZXEhIuYCIXZ04p+0LJOWLAuATnl6cnDZzbPeMcNqQ7SwEA98UJWboZwKU3DrHDui0jBg8GEYzhv8JqfoTtHvZCagDxoxl4ZAZkRNV8Di5QIpBBBXLs7auNaKBMbrOLcRzFDC8tuFgwVWVb4f6NYeMaTj5JXK8L2RPhVp2q679Uw/5HHZYLiZY+lNUHa8zgKItu61hzJJLEjJ+219oSfp3I1aE9t4iOftZbRk8o2karh4kwoZxEF5IQGrtqi8KD9x1kQw0161XI6tWYelFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> Date: Thu, 15 Sep 2022 16:39:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Console output stops on dbgp=xhci Content-Language: en-US To: Tamas K Lengyel Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0324.eurprd06.prod.outlook.com (2603:10a6:20b:45b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8869:EE_ X-MS-Office365-Filtering-Correlation-Id: e5b18618-cad4-4c6f-0cb9-08da97281937 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yqaFidAWl+1S3eAWNHwFt9QsbgeW4ZzNNnPKcQX2XpB7OIe2YCfYiSJgH13UIhuqksboKXj92hr7zuEyqt3B8YD3zayC/sh2MdzsRMQGyDK9WlsG0A9rrm/b1yWEiJuQjbvPAgbXh9jgT92G+6NKaWksVrzaaMuMnpdJcdZMoOIGypVv1Ip/fFP2Q0pkDlZPUv+xUPzZiB345GTgy6i58MmwC8SYmZizlYF7IzZC0kH4bP7frw9abznWtUXdL7au3287yzvrgh91BqsF/ZZWmJgHgEAzKPXJ80vlFA2ERglv+Zj7oo2r2fN0Ddxwsv7gNynJbAWMZMpgYk9xnRRPBzq4Lr2qMgHuiAlaJYQ/GN94qbhHWpWaKZUnZjLHzDhXeGarCHiXiqk/QnQXUfdVVD5A3zrGE9HYF0OO8EWE6zCf4hitu3D9Xhde1rmdOL35ctBnMBhEJgNMItOB3sN96rmjz4aAHHt2y51et9Ftii/3UqScVHF0F6kyJa0YkwV+AxoD+0+JK8EGUndQv3PgyKD+S0Q7E3EMtoGjewiHGn1O0VPHh4Obw9KiHv+YC6q0RfNe9bC8zmLT6u8Uf7s2q80NX36hq4xp9iXHLBToLDKNaTiTU4L8nIOd9h4icfyBE1LFLQFkS61WIZM97T3bhAE8zFWGPo6AcO63/riusLBT9pblDgP48OIOpv5X5uLHzkOtbMdRYNJBWUUHNO0XbccwI+IfsaCJ+EzCp1fXWyf6MLw64h6Jcu+7ngZ46fYxOAbPtibe4qRftYxRuvJr2vTtopRjLiI5og3B95Hmaa4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199015)(6486002)(6506007)(66476007)(2616005)(8676002)(31686004)(31696002)(36756003)(53546011)(2906002)(6512007)(186003)(54906003)(86362001)(83380400001)(38100700002)(8936002)(6916009)(66556008)(5660300002)(316002)(66946007)(26005)(478600001)(41300700001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3NtdktiSnNvdnlQczdPb2E3bVFhdG10NENJWWdBbmk1MktNK3FjYVg4Tmo4?= =?utf-8?B?YWk2ZnpidDhNNGs4ZXV0VkQvSXN0V1FKZlN1NzZRZEs0UWg2U2Fha1liR0ZZ?= =?utf-8?B?eGh0RllzVnlhWEVRRVRJRER5QUJaK2NJa0RISStzbkdCalo4V3FYU2ttMlJ3?= =?utf-8?B?SHc1MCtleUN0R2RpdmZqc3p0cnpzd2E5cW9md0lBRy9UQ1ovdUxsOWhsWlpK?= =?utf-8?B?OVFYSFlLVW9hWmk1Q2NzU3VoaWdSakM3dXM3ekc4dVFyMmN2N2hVdUlUQldH?= =?utf-8?B?WnFna2xSdjFuR3VYMC9MM1JPbFIyeWtuR0tYU2hJelpLOHZ6a3RUSHhJTXpJ?= =?utf-8?B?a1JoR2p0MW1LRTBVTmhIL2VaT1BTTFltSmltcWJUMitlQWFpTkVBZWptSXVp?= =?utf-8?B?YTZnMFRIa2lNQi9VRFByWFNubDZJakdhMUw0TjVpVTFtOG03NjI5YlNYdUF6?= =?utf-8?B?bUFoWmRJWUJvME5LNE9IRTJrWlJqbVo1dnNZQzlYSjBIcFRFUklCcG95ZUpk?= =?utf-8?B?aVN5VE1VMzg5Y1NYRVBOWkNnZW8weHR5VkZMTXFDMDBRdGtpREJlYU9MR1Q1?= =?utf-8?B?TGROZE5aVUt1enl6QXlydmtxZk5vOGkyUTZmNFpycG1CdEU5ZFp4em5sVlJH?= =?utf-8?B?OW1wVEVhbURscldTNXk3SFN3ODZhMEkrNzNPenZPditEWFUyY2svdHhZRWpl?= =?utf-8?B?dGR6K1lPRXJGQU14bDU3UFF1M3R2V1JTRXNoTVdGdHNoSmw2Z2s0aGMwdHdW?= =?utf-8?B?YnNyNlBZZVRyUjNSYXRKdmhjUytoOHNqNi92U1dqUFQ3Y3prTjVwaVVKOFE4?= =?utf-8?B?WXNyUmhKMEQwc1QyYmtkYjAxOW5RT0xsRU9tTFl1SGMzcmgvZExmLzMyRVRt?= =?utf-8?B?QTVqUVhOSEIvb045NU04MTQ5TmM1VExaR1BndDg0alFQU05zZkQ5a2VYcEI0?= =?utf-8?B?SVkreDJ3aG1nTUxTZ21URjk2Q2g2SGYxSkg0WEl4VGdHM01CcGF2Qi9xeGU2?= =?utf-8?B?QTAya2pVY2ZIRUY3aHBrWHd2UTZ0QmFZWFB0NEE4Q3QxYnFnTmNrak9oVEU2?= =?utf-8?B?Rld1SGtIWVJ5d0hOdU9BVTZqR2xyRm55dEtQbGlCMUdQZ011ZjBQMEtFTWxV?= =?utf-8?B?T3hIUENxMnMza0cvdWozU1pjOW9RZkZodlBJTjZBQkJFVTJhYjgvUWRvd1l1?= =?utf-8?B?RkZZdnJXbHZYUmtUYWY5ejV6RHYzS1ppaThPMzU5UXdWckExeXFJWlpTYmZZ?= =?utf-8?B?U0xkaWY2eWw3S3RpOEgrZlNmbHlobVd2UXlTV0RyTHFRdWM0amhkK1VqVTJG?= =?utf-8?B?Q1FLWmcxbnVMbEgwZEVDQXRNTTBsVForTzV1RWdRZ1BRWms0NWsyTWlnWWZp?= =?utf-8?B?Z25sZ2h6eEQ2UHJET1BSUzVqREpQc1hIejRQdGJWenQ2UTZGMWg4Vms5bEFW?= =?utf-8?B?ZzM0VHl3TTBRWURkVlE2SkdyMGcxakJwZUZTR1pycCtNS1haOVRDWmJOQUl2?= =?utf-8?B?b0tDVUJTU0Nodk5zQ1UyekYwT0wxaERBd21sYng0UlNGZjRLMkh3MVFXeXgx?= =?utf-8?B?R1EyVzZQeFMyVUdyMWZyZmFmNFpEbjc1Sy84VmFGbGFhdWUxQVlpZXdpaDZv?= =?utf-8?B?NHNvU1ZINmo1bWRyT2JiWTIzbzgwdStkRVo0ZEdZTm5LdkxlRTAreGpZWjlP?= =?utf-8?B?RDR6emFiNmF3U2tZSVYwWTdYaXloQ0hBelpRdVZZQzVJLzRqODVOeXZ1TUh6?= =?utf-8?B?Z0JwY1hnUTd2UDZnamltR3BRNW9XU2hxWmtrblFaUnNOek5EYXVrT2QveXRj?= =?utf-8?B?RWJvMDFrMmVJbW9HWm55c3J5dloyUkp5anN2YTg1L0dGeVJsVnJQdW5aaHg4?= =?utf-8?B?WHNTZmNWd2dRajhzR2REMXhDOGpsZXh6cTNhc3RxTnc3eWdnL2ZRVkdOSWVy?= =?utf-8?B?MVlVczRwK0hlMDJLWmdWODJUalM5akZ1V0pJbS9NSjFlbHNualVqR0lqQ3Yz?= =?utf-8?B?WHpTZ3ZFNkNLdmdjZDZwb3NCaWxtMFZEODdKeFhuZ2kvQjJsTVJ4K0wvZTQv?= =?utf-8?B?MEF5UnBURUJJcmFzdGFKL0tYM2tnS1VkRjA3RW5tQ0ROZGVhRVo0S0w4R29T?= =?utf-8?Q?7JBkroBTbWJR596g3NRsyo2To?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5b18618-cad4-4c6f-0cb9-08da97281937 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 14:39:30.5745 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q0pmenFMFtpGxHjdaHs6VZqMpjwY96CZkXmk0kjRk7yWIj9bBrtrtiEEVxQKD81nI/3C9X/dDeTB37xNCc9s5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8869 On 15.09.2022 16:16, Tamas K Lengyel wrote: > On Thu, Sep 15, 2022 at 10:10 AM Jan Beulich wrote: >> >> On 15.09.2022 16:05, Tamas K Lengyel wrote: >>> On Thu, Sep 15, 2022 at 3:56 AM Jan Beulich wrote: >>>> >>>> On 15.09.2022 02:41, Tamas K Lengyel wrote: >>>>>>> Do you have any idea what might be going on and preventing the output >>>>>>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still >>>>>>> present on the receiving side, just nothing is being received over it. >>>>>> >>>>>> There are few more patches in the series that are de facto required. >>>>>> Especially those about IOMMU, otherwise it can only possibly work with >>>>>> iommu=0 (which I'm not sure if even is enough). >>>>> >>>>> Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this >>>>> on the console: >>>>> >>>>> (XEN) Panic on CPU 0: >>>>> (XEN) FATAL PAGE FAULT >>>>> (XEN) [error_code=0011] >>>>> (XEN) Faulting linear address: 00000000328b3a54 >>>> >>>> Perhaps in another thread, could you post details about this? I guess >>>> we want to address this independent of your XHCI issue. That's an >>>> attempt to execute code outside of the Xen image - the only reason I >>>> can think of for this would be an EFI boot services or runtime >>>> services call, with (possibly but not necessarily) quirky EFI firmware. >>>> Any other context this is appearing in would quite certainly require a >>>> fix in Xen, and I don't see how "iommu=0" could affect the set of EFI >>>> calls we make. >>> >>> This was indeed observed with a xen.efi booted directly from UEFI. >>> Beside the limited boot log I get through xhci I don't have more >>> insight but happy to send that (and anything else you think would be >>> useful). >> >> And with "iommu=0" but no use of XHCI it doesn't crash? Or there you have >> no way to collect the log then? >> >> In any event, from your description the interesting part might be the >> EFI memory map. That ought to be pretty stable between boots, so you may >> be able to collect that in full via "xl dmesg" in a run without "iommu=0". > > I see the same crash with no xhci debug use. The EFI map is: > > (XEN) EFI memory map: >[...] > (XEN) 0000031f72000-0000032a95fff type=3 attr=000000000000000f This is the entry covering the address, which is EfiBootServicesCode with no unusual attributes. Assuming the crash was still during boot (of Xen, not Dom0), do you also have at least the full stack walk from the crash, to know where in Xen the call chain started? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:42:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:42:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407460.649998 (Exim 4.92) (envelope-from ) id 1oYq4l-0005tv-PO; Thu, 15 Sep 2022 14:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407460.649998; Thu, 15 Sep 2022 14:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq4l-0005to-Kt; Thu, 15 Sep 2022 14:42:47 +0000 Received: by outflank-mailman (input) for mailman id 407460; Thu, 15 Sep 2022 14:42:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq4k-0005tV-Nz; Thu, 15 Sep 2022 14:42:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq4k-0007ve-Jk; Thu, 15 Sep 2022 14:42:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq4k-0002mc-3t; Thu, 15 Sep 2022 14:42:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYq4k-0000gS-1G; Thu, 15 Sep 2022 14:42:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7oxtJfcLjXvMV6lKfJsItpkK1ODLoRCBuIKpUBDUJ2Q=; b=L1A4Ds1JV4sipGtlPYJHs0Zou7 /9kGqyYxn6oilwHXk5C2sbYL7YWoFkXDI51+663bjfGVSGu+wrmHnu82JjcOJuRKkaDBqzZ9L61vS gPmeiv30ozI58CUasDQLgyWDj7u+rUeIQP5mkNNBBXPKCNvta1zy87nRU3SHNWtpbK4w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173206: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-rtds::broken:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-examine-bios:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start.2:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-examine:xen-install:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6deb370b5a5389256f160f711c58561e0868ddf X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Thu, 15 Sep 2022 14:42:46 +0000 flight 173206 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173206/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-rtds broken build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 5 host-install(5) broken pass in 173198 test-amd64-i386-examine-bios 6 xen-install fail in 173180 pass in 173206 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173189 pass in 173206 test-amd64-i386-xl-qemuu-debianhvm-amd64 21 guest-start.2 fail in 173189 pass in 173206 test-armhf-armhf-xl-rtds 14 guest-start fail in 173198 pass in 173189 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173180 test-amd64-i386-examine 6 xen-install fail pass in 173198 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173189 like 172128 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173189 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173189 never pass test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173198 blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173198 like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail in 173198 like 172128 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173198 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173198 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173198 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173198 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173198 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173198 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux d6deb370b5a5389256f160f711c58561e0868ddf baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 42 days Failing since 172384 2022-08-11 11:13:58 Z 35 days 75 attempts Testing same since 173008 2022-09-05 15:47:43 Z 9 days 21 attempts ------------------------------------------------------------ 460 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-rtds host-install(5) Not pushing. (No revision log; it would be 13933 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:45:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407469.650009 (Exim 4.92) (envelope-from ) id 1oYq7j-0006b7-9f; Thu, 15 Sep 2022 14:45:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407469.650009; Thu, 15 Sep 2022 14:45:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq7j-0006b0-4L; Thu, 15 Sep 2022 14:45:51 +0000 Received: by outflank-mailman (input) for mailman id 407469; Thu, 15 Sep 2022 14:45:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq7h-0006a9-Mz for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:45:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80045.outbound.protection.outlook.com [40.107.8.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 162416d5-3505-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:45:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8869.eurprd04.prod.outlook.com (2603:10a6:10:2e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 14:45:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 14:45:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 162416d5-3505-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DKydMhYbXa2Dbez1VE65D2N7NnO7U1TEMEccd5LOM/NGf/HaC0HNbVzldR3Og5hVZUGsI4fJ9yWMMoSL7UoOJ+QAC6WPGW3PGwbVPNzeZpwPCQxU3BTxELA7hicIfiECWcSqRqdYJNdWIo0TTV7fBOa2I+SQR4qkZUYKblGUxZDFfpPAhFgqbNRKrcv7030/kG01EdnnafiKoepZu5KRFBwjQEUWTwAyry3bHIA37VI/H2QeOBIyNdE19LuFko0s7haGZvbk4cJXFKfVIJiwphp4ZO7fR2FixydeNN8BqKheh+CKDgOUcDjWiIK9sqe4LtnBlG39BMrqlvMYPsHOOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJjeLxH1Deci1MDiuriHd4zkXDSiqoNcZH5YXYjOS/E=; b=NPx9nwQoeSTqwWANsk0OF1DY2oZQ1GGriA8avOKwXsNo06gDoGMLsAvJ+rpuiPW3iIa+5MomibNXwqgjxDAImxK1chXGoKHPOQOl7eBJtKcueADCxV/LMFTz1AMo7OE9skGqo/oeED+tkeVfhNv0e6/Zpa98MpKfolQwgB/WNaXxvVbNydj5UyUaLCLC4UAVW0hHHW3zNvjWW6QEg1Ok8VTeXOSIlJzz+PWXO4BJe5LYNnjv45gOT1OI1E8TmqDGlmeiTBW0JDDCj3SXsCs7pDBbnuslrQ2AADAIHq1tYXfv7zzbI72prXgrqTcvwdpxHcS/6AnEDatuJezZxZeohw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJjeLxH1Deci1MDiuriHd4zkXDSiqoNcZH5YXYjOS/E=; b=DkWaCTSvYMuvTtOvARyEiN7hKL9E0XOTC0y3a7ffIhT1d98WDVsoP2yCyvzNngDmgxo0b3ZW5pSOTKjtOG1dJ6V2SDc1eJogBTmMbEd4U9sX5F0Ijnwl04M1r9lTx7/cwHxpG6zLtBuoqMkgSYRMKWSCxV2WHlJK+OaAkk/YFQOjQ50eGXCxLaO3jI9Y7ydueDeSTvu0OQ9KCLeoqVQvRzEKUuXfawKUfCT9nKO0pr8TshaYliqn7Qfk3JcVcZOSHxj0EjZQFseU+ee/VOmoH72P+0WfNX8d8qNrbvQqpV7bOuJr2hHEk1C86HJOdkzPCTWa/TJG8F3yPxkE0zUZ6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 15 Sep 2022 16:45:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] xen/xenbus: fix xenbus_setup_ring() Content-Language: en-US To: Juergen Gross Cc: Stefano Stabellini , Oleksandr Tyshchenko , stable@vger.kernel.org, Sander Eikelenboom , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20220915143137.1763-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220915143137.1763-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8869:EE_ X-MS-Office365-Filtering-Correlation-Id: cf0e6ed3-a791-4ef0-926e-08da9728f931 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PztQYUn97TEjum4d5sBSp9fGeqA8Ylu030FJEoj2JTOolNmLaphpPX9Mmz5WeCAovH5FcNuIwobHDlgCA+VjRZvnHVbzF8rvc4xotSVIaeFdeK2QMk5ZSqhkKr4iEETvKRZc7a+hVdRP4KT26pK1rNoVIz0XwcmsAwdFOaMbup6RyOpnZGfHY+FpMkFXNXUC4gikAb8+boHbzTmPtcdQbEoEWgBN13deNk+o4MkwLiSGF7DXdIwSdQYt2ZfepKBALlYxEdAbfupt20cFbsUw84PL15wdVCBP3YXLTZqn14TsBALMWk52G2C5SfnrXY5O7Qp6Ixi+rBkU/bQB3hOhwIcadXqPI7ENhn/UaOId0wSBbGl5uQoEaZpGv5lbWNTi5jsfOVgbQXoZjd8fpDXxOH514kAeInMetIXq7e0ySAEUmplTpV7RTR11ZxRf55GRWdbOJYYTd6dph6Gf5iXWM5KXd5Au+3thVy6U50lFKraE5KR1w/9DW91NtbU4xm6YhZ0YMZpihWZn/w+Z6tXkcJ+s02PUs6P3YG4e1axzuSnSLOvgbsYl7gYex9nVokvGVjDuwEufIPDvd3EFXjEzvhXa8bFhTB+S93aLMjrI+4tPp+N8lEiRXs1Y1EbZPC/QQyPkF+Qay90D4bzU3AM9SYmOXTpXGQj34dwLw1M2svceGNW13SI9Ox2x3E84ZPVdMTQ1dXcGw6g1XG1wnFmHlQKGVLZFY0MuX5RX4U9Sf3QrEf8mh7ILBDyXsDnahA7152mMCqQHhvoiDPhcyZR50gxXLH6iHvsGUT7IvxAC1Ao= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199015)(6862004)(6486002)(6506007)(66476007)(2616005)(37006003)(8676002)(31686004)(31696002)(36756003)(6636002)(53546011)(2906002)(6512007)(186003)(54906003)(86362001)(38100700002)(4744005)(8936002)(66556008)(5660300002)(316002)(66946007)(26005)(478600001)(41300700001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzJXSlNsTDlHRE9NNGNxQnFsaUVJc3dndE4raUVQakhSYzYrMjZuRFQrOXlY?= =?utf-8?B?QXk0WENZV05YZjdCemFlcjN4M0Ywa1U5MHNmQXYybzIvN0RJNS9RZkROOHR0?= =?utf-8?B?UEZxNEgxWGNycGJwTi9hamovS1I5SzFyNkZEUUdUZmtnK0xxcEhDY2xSYXQ2?= =?utf-8?B?NHFEcVpsQ0xjeDBselljdmgySUtQa0VSTUdaVXp2K3lOeDFKUEFYdUpLOUNu?= =?utf-8?B?QTlnZnB6bVpoLzRKVlB2RW9vZkhld0k2NS9SYjZwUkhvYXZYcWl5ek5UV3FN?= =?utf-8?B?bmhHNTNzVVBsT016dU1wdzMzL1RpbkxaQm9HVjlXR2tBSWJjM1d0c1MvcVhC?= =?utf-8?B?NDZNeEY3QU1aS0pZVTJQSER2T3FicjBSZ0MrVHA3NFFONVNRMlZKUEdVR2x2?= =?utf-8?B?QXNLb1l3cmxtM0FGVzlRbUEzekRZa2M2eXF4UUZramNDNStiaWFFR2E0aldo?= =?utf-8?B?RlQ4WUtoR29IVk04MElMNy9FdDBmRWk4NnBkbyttQUJwYzREbzdyK1FJam9T?= =?utf-8?B?NGtxRE5Gby96b1c0VkdDcVVkYjZqZk1PYUVRR09LV1VCcUY4NkM3MmhiNTNC?= =?utf-8?B?OXQrRVM3ZWhXZlplTzludldkMUg1V2VJZFFNcUprOS9RL1BDTnEzMnF6V2lt?= =?utf-8?B?dlBhQkJWVzdiemRlVFJYQmlGUCtuUkZIeGV0QWMwWkMvVGFWZVRwQ3RIRUlQ?= =?utf-8?B?UmV5Qk1wRW9kUzRoSzduVlkrTisxdFhxMEtadDhTNnNzZzZVZVBuVGdScG9L?= =?utf-8?B?cmhyTUgybGpiRXlUN0FGSkUrZjI0TTlBUFRHdWJ1S1JBWjlkbW9NYXZhb1Rv?= =?utf-8?B?aERWUG9sREU3SDRDa05LWm1wVWE0aFZxMDVTZUFHbk4wNUFyMjlJVU9POVBJ?= =?utf-8?B?ZitYZEVMSmZFVDdpa2RNbDBwcnptcklpaXM2Q2dXZzhmOUtzYWNoWFNBWXdQ?= =?utf-8?B?aHdaNTM5QVkweUx1dzZFYkd2bW9BMzN4dW1vcXlXajU1NWVMYnZHRWNNWFdK?= =?utf-8?B?SG5ydnhjVy80cFo4bVFsdlpVTldqY0RhdGdyYk5mSDNCUGhmUnd1N3hNc2tL?= =?utf-8?B?UnFNVDFVVy9pVGhOT2xVR2xUeGhsek56UlRNc2hqWnpUVGllQ3RMdmtVeXZi?= =?utf-8?B?VWh5V3E2ZGg2eTZnaHg2LzRkMUloYlg0dWpGLzRTdzlQekFheE10SFZYRm9k?= =?utf-8?B?K1Z5YzhrWmhGeHlwNXNhNnRDRm5Kd0FGOEQxZ3hUOUU1VXphTmxsRG9JTytW?= =?utf-8?B?ZjNveVpmOC9tdE5PNEZ5dzdKQTFkaUx4bTE5OW1jQk85M2tWTGhkRyt6K2E2?= =?utf-8?B?YjRtSlI0a3hUYjhJci9TWDlNaVh3YW8raWdEc1JzZTJobzg3aktnRC9qSGZn?= =?utf-8?B?amE3aHZOVi8yR1R4SEZ4SzFzb09JZ01xZldnUmNyc1hjZldrODg4c2c0bGhC?= =?utf-8?B?bVZPTEpVeTBWR3pNVi9IQVVhSVpZTVVQby84QWpzOU0vTlQxdm95Q1ZaMW8v?= =?utf-8?B?WDFEVncwRHk0V2gvcGozeWcyRE9XOFZ5ZWxFR2ZaVVJYbjlsQU5leDIrYjhs?= =?utf-8?B?VVVtaTRiMzgyaWpXeGlHRnZaTi95UE1CY0lxMmNMaDA1em1WRC9EZG5Ua2JL?= =?utf-8?B?dlZhS3JWcTU3WFVyMDFPSjMzS05uSEJFU3VoK0YvNkhFaDRpOHgvZ3BxRG5x?= =?utf-8?B?NUFacVRwamk5Rzhla3dYM0ltcURETFpvY0YvWUY2L29SYWhIa0JVVkF0cEFD?= =?utf-8?B?VEN3WUhlaGdCQU1oNnFkdmR2TmxwbWV1TnNFSXR0Qi9mQTdPN3pKRGlIc1lP?= =?utf-8?B?QUdzcUhKSGZ4emlWZmtLc1B2bDJabnF2WENpbCtnRjRRVHRjUDJ4SFdXMmt3?= =?utf-8?B?b1NVSUE2VWYrOFFsNlZ5SmJYVFR3aVRuY2NvVFErR01mWHd6eHh0RmRSc3Aw?= =?utf-8?B?bjZLTXVyK3FHSHV3cDVRMk1YUDlITG01UGRIMjlObDM0dDJsVkFBWHFzWTRN?= =?utf-8?B?eTI4T0k0RWErMzQyV0NWUFFKenZwNU5sVmt3ZWFvcXcvdEwvNEFYR1BFQzJG?= =?utf-8?B?bVBaS1dkWURlMzUxOEFva09KS09tUThFYTYwd3FzaGJaaVlBVGZFZ0lDTWZ1?= =?utf-8?Q?TwceDnS36OdtCTvJbi4QCDCPr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf0e6ed3-a791-4ef0-926e-08da9728f931 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 14:45:46.3170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wuB47+DsDCniwhJnDoU9M7Qt064zvDZh3USwVMlD6aRmTTbP+OKMIxSEpdb7wYVluDEpxubIKvLLn3tOUaLZnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8869 On 15.09.2022 16:31, Juergen Gross wrote: > Commit 4573240f0764 ("xen/xenbus: eliminate xenbus_grant_ring()") > introduced an error for initialization of multi-page rings. > > Cc: stable@vger.kernel.org > Fixes: 4573240f0764 ("xen/xenbus: eliminate xenbus_grant_ring()") > Reported-by: Sander Eikelenboom > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:47:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:47:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407477.650019 (Exim 4.92) (envelope-from ) id 1oYq9L-0007Fh-Ms; Thu, 15 Sep 2022 14:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407477.650019; Thu, 15 Sep 2022 14:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq9L-0007Fa-KH; Thu, 15 Sep 2022 14:47:31 +0000 Received: by outflank-mailman (input) for mailman id 407477; Thu, 15 Sep 2022 14:47:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYq9J-0007FU-Dl for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:47:29 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50873f48-3505-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:47:27 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28FD3dCd001913; Thu, 15 Sep 2022 14:47:15 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3jjxy9qtgr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 14:47:15 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by GV1PR03MB8615.eurprd03.prod.outlook.com (2603:10a6:150:95::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 14:47:11 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::f575:76e9:4a40:7387]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::f575:76e9:4a40:7387%2]) with mapi id 15.20.5632.014; Thu, 15 Sep 2022 14:47:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50873f48-3505-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ag9hfkh5xvF6oxz72nXeMBI61H8uLDAf6qgc0qdlY64Ay0qVVxU787UD1TwKErDZkZZvlXyag1SKvicC/fWpeDzcKhANFQJLNhJKcMp84hcVurTZMnUXoo/K+5kxcpOYxrG9rxkU6+6kZH81zGaNjwpEe80YQMIIvvNIsMwZr/xrR1rEJ4lXpbJHaCjikkMjMI1jQygSoV2ylHsFUcw5VRZzTYrdHP+lVFd5ahguX0Y8I7ZKyfv7/fn1egNcihdbS5IcLr+2Nagr5uVDrav6ao+riDE7PpIQVJ2HdFN2FtlzOBY3blRlG7Ly0kPU4G4DTb1DEcWKDeqpofEfk7RsEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XmhH4OHAj83WUaq1+htPXu31XFk9cLRFSxiLf8O+Fcg=; b=J5v+D9ivMPnBfcge7t56EZBk/Dat8rw/FqFgEGZOeRIftzJD2b+lzKbWHI81TfZS2dc9wOJLi+wRjzG5rlQoar+FEae5VYxHnPxedBbGzqyvJuSrNtLOQbf5HiWUkccDzm+S0zuE/0Rwxz/YT97TN37BZB1ht74CNb44L5IhrpOUAmWWgSE/vKG13yLz7goc/Elxvow5XjQ4WVGq+NDBSeZsAKJXsCLAR5AenaVlRJY0+kaS7BEoE372Bm1Hrq8Fs7fyT+tVMAow1q+xtfRc7hagNRmp2HwXuaDGTjMYEEdAN5ndtKhTIgVpc7571zaJIt4oVbL9jIL7h5ubCo4drQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmhH4OHAj83WUaq1+htPXu31XFk9cLRFSxiLf8O+Fcg=; b=eg5IJ3pSbg2PDkhLsOy9tDOJz0fAYhX3/r8Xw4epWD++MFq9Sk4oUVi8u2RUXVE/xpmOWuBC4BDm8rpQkTUJpPP/eRmxqJyz3yGpsU1wqV3it8MJThzLh/EM0YvHfFvdJM+onf5JCv9NCPRUM8y7xBhloinpl/CpP/gOaeQb3c26Ox5epRXli71a+6PkVVHNpdYxMco9XXPaeOGD56Dr2J1AqijTRNBPAD/9tH36Jautbn2+TE2ZWXWHa2P07ym1GRe+ZnrHc1EkLt4/5DP821XSL9PLzROLsp3mM4MgXeLcIZGL2fZ1Fsh7lLb/Ksg8kw9FfPstt9cr3YeVSkhU7Q== From: Oleksandr Tyshchenko To: Juergen Gross , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" CC: Stefano Stabellini , "stable@vger.kernel.org" , Sander Eikelenboom Subject: Re: [PATCH] xen/xenbus: fix xenbus_setup_ring() Thread-Topic: [PATCH] xen/xenbus: fix xenbus_setup_ring() Thread-Index: AQHYyQ/iPv5e34GuQU2mfPtgOqQE7q3gkeuA Date: Thu, 15 Sep 2022 14:47:10 +0000 Message-ID: <34c9a80d-3a9d-cd51-32d2-cf778c981107@epam.com> References: <20220915143137.1763-1-jgross@suse.com> In-Reply-To: <20220915143137.1763-1-jgross@suse.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|GV1PR03MB8615:EE_ x-ms-office365-filtering-correlation-id: 92a2770e-4048-4809-f142-08da97292bba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y4BdEmSzi4pNvhkd4C0BU8NE5dAEKMm68mz2CjHs64aiNfljAXEjUdBNEmbT9vUc7DFCkqAZRvgLkV74G7h1tiLyWvrdDmI5/SL0HWza8/nEntu7YE8huKKGU5c+gpjpU8ShjlftuKZNlUdVIZxLeqgPKuUbCaQ5E/j6RKnPNRepgoyOwbFDMvdlRGHaVaX1Pcemio2SICkDTuyCLuXDY64G/LKb9seOnTGuNveA9iUMUpSPP3CYmEIPNQBmMQ9zuZrSFf1EBtplekhvo+JRCWDUFmSX6QKe6TGgBW69ys9jOgAS/GkRiAcGCQz6YjK2kJkhZ/bAI0pgz4zH+itrZlE/Sok4iY57jJUrOdUH5eectVZZiZudnl8G70ytYI2FTL43KhKw9LOatVcPFr1iTnOip3s2T5M3lPfH+YBZFNDQkhf3Mb/7+ediot8mgFzW77AZ9lFh0fiqm9g3ugiKUb6bz7DqSekAAqLLNr6+Ny6uQSXJXSjx1IFbFak2Z8Ha7vjOfZqzi+FdbCoUkMTfFbEmNwG2rtTEGel+BmRzD0/gvLW5armj6qNjArzZq+D4PvmI3wyAes1GmLuy8kYzkK3o/F9KJ8nK98CMtuJLgC9mStDFJ5pN1TivF7yywToZ1GXa3C2izz3Jjoc9wUOaLaPM8urJZcU4Y4cPkGMZntqSDFCtCC7ou3XohYwtub4fc4d9nPo334fp0Iur4VVYNsVrPh0YGE/IAmEqg3LyC7jDu8ubJsZgj9/jfUORpq8XThj/8xC8K0BzuHJq5R4vdFpgD7LSZUQZySyZcpRBVI4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199015)(478600001)(31686004)(71200400001)(6486002)(36756003)(55236004)(2616005)(41300700001)(316002)(110136005)(6512007)(31696002)(54906003)(53546011)(6506007)(26005)(86362001)(186003)(66476007)(38070700005)(66556008)(66446008)(5660300002)(76116006)(38100700002)(64756008)(8676002)(4326008)(66946007)(2906002)(91956017)(122000001)(8936002)(83380400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RUdhSVl2YmY0UVNiSldUeTlqTk5KN0J4YVFRNUpERGVYblU1aHh4UHhxRkN1?= =?utf-8?B?QWtSQ1FZT016UnB5ek8ycmNoM1IzMytuNzY0N01BRXZyRHJmN25lSUcrL1lK?= =?utf-8?B?UnFwNk9pbU1pNXA4eXQzK1M1bW1PYXRZM3VUSjdIQkR2V211T2dWWVAvL0Ux?= =?utf-8?B?dDV0MjBjVnM5V3cxWEN6VXNLOE54Q2NuNFlxSUNuVTBRbHh5NWhNczFBYlVs?= =?utf-8?B?QU1WT2FZS2VlN2N6ZHBSdkx3bkVMZ3lDY1Z6RGpNcm10UVJHaVJjMDZvS3FJ?= =?utf-8?B?S0dnUFkyK08yWXZJTkl4clVMTm5kaFhaOXorb000M0UyZ2FFbDZYZHNyczhn?= =?utf-8?B?T0FNeHhLU0NGRUFlVDBxVldwZkR4STQrcklQRXhab0VFd042QkJ6VkxQR0Ny?= =?utf-8?B?dTVCd3JHaXdjak1IcG5Ia2ZUQU90U1ZNaG9iL1RvMkRoZjRCOEVoSDJCeWxZ?= =?utf-8?B?MHJObVhrVzNnOXhMZUN6cFdCMVVWb1o4SkFESTNzUkxTNDVCY1RsbGdZMjVq?= =?utf-8?B?M1kxZUlIdkVUZ0U3RWtjZW1ZQmVKTzgwVXB5cXpPdE1GVTNsNjVZc0pzYVNx?= =?utf-8?B?b3QwQVI5d1p5bG8wdHM2Zm0yc3hjYkY3aml2czZST3ZkckFob1lPRUt0QWdi?= =?utf-8?B?QWxGZmFnVlNiQStYbDdwSEQwcnhJbFo4Y3pFMmlNT2pQdURaOXNmQ1E1MVl4?= =?utf-8?B?dVVSeWo2ZVByOXIyYzF5ZklSOCs0T3FOemEzSnRReEhlVGRXTGtsR0ZXZURs?= =?utf-8?B?aUNjdC92dGxJUEh4OHovU25JTDRXUWovcFF3SXJUeVpBOFNwemR2TWlnQUty?= =?utf-8?B?Z3d1dHpSdmdoMUQ1KzNoTGdiUndCaUlQQTdaMHBTV0dTNHNlSDJhaXFJU2k4?= =?utf-8?B?dmJ6WTg3Z092Qkc2ZWZDVWNCSEpiaXNZYW9rUmRaRGg3ZkFQRGhzWWNnRHNr?= =?utf-8?B?RDZpK2dCcWMrcHZrRVBDTmhTWHNwQTFibXZsYmM3WFhNN1dDaHdZNk94Z05K?= =?utf-8?B?Y0pFcUlFdlYxcHQ2a1JMVXZUMVZIY3NrTkNDK3VuVnMwS1hLcTJqTXFyd3Ju?= =?utf-8?B?cWNiL2pmRnJqNm5Ta0NZNFFlMEU0N3lER1VhVmdKZFNuS01VM2F1YWxNMTNv?= =?utf-8?B?OVNCT3ZvN28yS05qamlvUkF4c2tUUXBicXRienRWdHYxa0x1RjFBSFRqOUFh?= =?utf-8?B?MXNKTlZmRXhZQlROQ09WVEsycmlFdCs0RC91U3V0eTZ5aC8zc1U4dE1idFJG?= =?utf-8?B?d3FNU01ZTFYzemhwaW83SHZjK0NldFBJUVFzU1pvNXg1ZGRCNjljbVB4V2FS?= =?utf-8?B?bUZrRVhmVVpZTkk5RVZoemk0UFhNMXorNkVZRkJ1bUVDTFROK1dSQTJiVDhi?= =?utf-8?B?UjJRZ2V0dUgxYkg0NUErYXg3MGJDdktMa0h5Ni82a3I1UTBmSk5LbXBjSGxv?= =?utf-8?B?REZ0V2ZFTVlqd1czUGlnWHl6WGkwM25iRm5aUnVSU1d2cDUrOWpZQ3JYTFB0?= =?utf-8?B?NU5YK0NTc0tjNkQvVlNjeTZVcDl4OFBoTmFWQkJaQ2NOdWJlV3VDRURNMnNH?= =?utf-8?B?RUEzM0J1cnYwS2JGSWx6NjNzd282ZXFOUGVzcklZc1BIcURTd01NMzRwc0o5?= =?utf-8?B?L1ZwbmZhZHljdWM5U0RiNm1IUzYzbTIyY0FBTmZEUmkxR2ZOei9TQW1UYzZR?= =?utf-8?B?T1RtU2NYdVZWd09EWUFtQkJEY3dvUXpybmZGaEFXU3FKd05XZUVDbFc2YlRS?= =?utf-8?B?STFSVFdGdjI2UHlyUkM1cUZNQS9JOUE5RXoyTk1Pa1JUVW43RDBSSHZPRi9E?= =?utf-8?B?UDNyTjRqSEFUeGZkWGw1QlRKaWxRbzdPZlJQTHJOTWtpbUlZcHpuYVI0c1Vs?= =?utf-8?B?TkhKMTFrbG90U1liaUtyTldKNUZuWE12VUVzbGV1Q0tYZUdJVkQ4U0M5K3dw?= =?utf-8?B?RXlUc0tXSUllWDh3a0FYeDZhMW04ckNrMnhhTXc1V0IrbEZockowV3NCUVY4?= =?utf-8?B?ekYyOWx0a2pCdEVXaWMxSUJPMjBpTzNuMGw5QW9NWmRZejkwM3JaVCtBUkI0?= =?utf-8?B?LzJLeUE0eWtsS1QwaEdjNjdMbkhmWVhjSkxIUy9Xb0FFUmdCaGI4R0publRx?= =?utf-8?B?YnlrTGllWHlqdSsraGdVdkVLWmFUTVROS0tZQTZNMWM5ZTZUMWtmby9iMU91?= =?utf-8?Q?bTSjXgZ11JiO/GtgRJbScdM=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <9A3A4702C79CEA4A83E454F929660DB1@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92a2770e-4048-4809-f142-08da97292bba X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 14:47:10.8846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yFIpMb3t6B9Ys99g9NB5O4Wt9nkxsiqhD6jiBmSR89FGanVkkloh9PqTXEw9UVppSv74lZ+mGH09LLoeEBXLPnhRajVOayI09W+YpDDnkmU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR03MB8615 X-Proofpoint-GUID: 0uI7TKAlfT3CkPcY2wH27fau9WqKqwUG X-Proofpoint-ORIG-GUID: 0uI7TKAlfT3CkPcY2wH27fau9WqKqwUG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_08,2022-09-14_04,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 impostorscore=0 clxscore=1011 mlxscore=0 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000 definitions=main-2209150086 DQpPbiAxNS4wOS4yMiAxNzozMSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCg0KSGVsbG8gSnVlcmdl bg0KDQo+IENvbW1pdCA0NTczMjQwZjA3NjQgKCJ4ZW4veGVuYnVzOiBlbGltaW5hdGUgeGVuYnVz X2dyYW50X3JpbmcoKSIpDQo+IGludHJvZHVjZWQgYW4gZXJyb3IgZm9yIGluaXRpYWxpemF0aW9u IG9mIG11bHRpLXBhZ2UgcmluZ3MuDQo+DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+ IEZpeGVzOiA0NTczMjQwZjA3NjQgKCJ4ZW4veGVuYnVzOiBlbGltaW5hdGUgeGVuYnVzX2dyYW50 X3JpbmcoKSIpDQo+IFJlcG9ydGVkLWJ5OiBTYW5kZXIgRWlrZWxlbmJvb20gPGxpbnV4QGVpa2Vs ZW5ib29tLml0Pg0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+DQo+IC0tLQ0KPiAgIGRyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMgfCA5ICsr KysrKy0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NsaWVudC5j IGIvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYw0KPiBpbmRleCBkNWYzZjc2Mzcx N2UuLmNhYTVjNWMzMmY4ZSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1 c19jbGllbnQuYw0KPiArKysgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NsaWVudC5jDQo+ IEBAIC0zODIsOSArMzgyLDEwIEBAIGludCB4ZW5idXNfc2V0dXBfcmluZyhzdHJ1Y3QgeGVuYnVz X2RldmljZSAqZGV2LCBnZnBfdCBnZnAsIHZvaWQgKip2YWRkciwNCj4gICAJdW5zaWduZWQgbG9u ZyByaW5nX3NpemUgPSBucl9wYWdlcyAqIFhFTl9QQUdFX1NJWkU7DQo+ICAgCWdyYW50X3JlZl90 IGdyZWZfaGVhZDsNCj4gICAJdW5zaWduZWQgaW50IGk7DQo+ICsJdm9pZCAqYWRkcjsNCj4gICAJ aW50IHJldDsNCj4gICANCj4gLQkqdmFkZHIgPSBhbGxvY19wYWdlc19leGFjdChyaW5nX3NpemUs IGdmcCB8IF9fR0ZQX1pFUk8pOw0KPiArCWFkZHIgPSAqdmFkZHIgPSBhbGxvY19wYWdlc19leGFj dChyaW5nX3NpemUsIGdmcCB8IF9fR0ZQX1pFUk8pOw0KPiAgIAlpZiAoISp2YWRkcikgew0KPiAg IAkJcmV0ID0gLUVOT01FTTsNCj4gICAJCWdvdG8gZXJyOw0KPiBAQCAtNDAxLDEzICs0MDIsMTUg QEAgaW50IHhlbmJ1c19zZXR1cF9yaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsIGdmcF90 IGdmcCwgdm9pZCAqKnZhZGRyLA0KPiAgIAkJdW5zaWduZWQgbG9uZyBnZm47DQo+ICAgDQo+ICAg CQlpZiAoaXNfdm1hbGxvY19hZGRyKCp2YWRkcikpDQo+IC0JCQlnZm4gPSBwZm5fdG9fZ2ZuKHZt YWxsb2NfdG9fcGZuKHZhZGRyW2ldKSk7DQo+ICsJCQlnZm4gPSBwZm5fdG9fZ2ZuKHZtYWxsb2Nf dG9fcGZuKGFkZHIpKTsNCj4gICAJCWVsc2UNCj4gLQkJCWdmbiA9IHZpcnRfdG9fZ2ZuKHZhZGRy W2ldKTsNCj4gKwkJCWdmbiA9IHZpcnRfdG9fZ2ZuKGFkZHIpOw0KPiAgIA0KPiAgIAkJZ3JlZnNb aV0gPSBnbnR0YWJfY2xhaW1fZ3JhbnRfcmVmZXJlbmNlKCZncmVmX2hlYWQpOw0KPiAgIAkJZ250 dGFiX2dyYW50X2ZvcmVpZ25fYWNjZXNzX3JlZihncmVmc1tpXSwgZGV2LT5vdGhlcmVuZF9pZCwN Cj4gICAJCQkJCQlnZm4sIDApOw0KPiArDQo+ICsJCWFkZHIgKz0gUEFHRV9TSVpFOw0KDQpYRU5f UEFHRV9TSVpFPw0KDQoNClJldmlld2VkLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3Nh bmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQoNCg0KUC5TLg0KDQpJIHdvbmRlcmVkIHdoeSBJIGRp ZG4ndCBmYWNlIHRoZSBzaW1pbGFyIGlzc3VlKHMpIGFzIEkgdXNlZCBMaW51eCANCnY2LjAuMC1y YzEgYW5kIHNldmVyYWwgUFYgZHJpdmVycyBpbmNsdWRpbmcgUFYgYmxvY2sgZGV2aWNlLg0KDQpU aGUgYW5zd2VyIGlzIHRoYXQgdGhlIHNpbmdsZS1wYWdlIHJpbmcgaXMgYmVpbmcgdXNlZCBmb3Ig YWxsIG9mIHRoZW0gaW4gDQpteSBlbnZpcm9ubWVudC4NCg0KDQpyb290QHNhbHZhdG9yLXgtaDMt NHgyZy14dC1kb211On4jIGRtZXNnIHwgZ3JlcCB4ZW5idXNfc2V0dXBfcmluZw0KW8KgwqDCoCAw LjMzMjQ0OV0gdmRpc3BsIHZkaXNwbC0wOiAwIHhlbmJ1c19zZXR1cF9yaW5nOiAxIHBhZ2VzDQpb wqDCoMKgIDAuMzMzNDY0XSB2ZGlzcGwgdmRpc3BsLTA6IDAgeGVuYnVzX3NldHVwX3Jpbmc6IDEg cGFnZXMNClvCoMKgwqAgMC4zNDEzNTBdIHZiZCB2YmQtNTE3MTM6IDAgeGVuYnVzX3NldHVwX3Jp bmc6IDEgcGFnZXMNClvCoMKgwqAgMC4zNDI3NTBdIHZiZCB2YmQtNTE3MTM6IDAgeGVuYnVzX3Nl dHVwX3Jpbmc6IDEgcGFnZXMNClvCoMKgwqAgMC4zNDMyNjFdIHZiZCB2YmQtNTE3MTM6IDAgeGVu YnVzX3NldHVwX3Jpbmc6IDEgcGFnZXMNClvCoMKgwqAgMC4zNDM3OThdIHZiZCB2YmQtNTE3MTM6 IDAgeGVuYnVzX3NldHVwX3Jpbmc6IDEgcGFnZXMNClvCoMKgwqAgMC4zOTI5NjldIHZpZiB2aWYt MDogMCB4ZW5idXNfc2V0dXBfcmluZzogMSBwYWdlcw0KW8KgwqDCoCAwLjUxODczM10gdmlmIHZp Zi0wOiAwIHhlbmJ1c19zZXR1cF9yaW5nOiAxIHBhZ2VzDQpbwqDCoMKgIDAuNTE5MTk4XSB2aWYg dmlmLTA6IDAgeGVuYnVzX3NldHVwX3Jpbmc6IDEgcGFnZXMNClvCoMKgwqAgMC41MTk1MDFdIHZp ZiB2aWYtMDogMCB4ZW5idXNfc2V0dXBfcmluZzogMSBwYWdlcw0KW8KgwqDCoCAwLjUxOTk0OF0g dmlmIHZpZi0wOiAwIHhlbmJ1c19zZXR1cF9yaW5nOiAxIHBhZ2VzDQpbwqDCoMKgIDAuNTIwMzcx XSB2aWYgdmlmLTA6IDAgeGVuYnVzX3NldHVwX3Jpbmc6IDEgcGFnZXMNClvCoMKgwqAgMC41MjA4 MDVdIHZpZiB2aWYtMDogMCB4ZW5idXNfc2V0dXBfcmluZzogMSBwYWdlcw0KW8KgwqDCoCAwLjUy MTA3MF0gdmlmIHZpZi0wOiAwIHhlbmJ1c19zZXR1cF9yaW5nOiAxIHBhZ2VzDQpbwqDCoMKgIDAu NTc1NDUxXSB2c25kIHZzbmQtMDogMCB4ZW5idXNfc2V0dXBfcmluZzogMSBwYWdlcw0KW8KgwqDC oCAwLjU3Njg1NV0gdnNuZCB2c25kLTA6IDAgeGVuYnVzX3NldHVwX3Jpbmc6IDEgcGFnZXMNCg0K DQo+ICAgCX0NCj4gICANCj4gICAJcmV0dXJuIDA7DQoNCi0tIA0KUmVnYXJkcywNCg0KT2xla3Nh bmRyIFR5c2hjaGVua28NCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:53:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:53:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407484.650031 (Exim 4.92) (envelope-from ) id 1oYqEl-0000Fd-Cn; Thu, 15 Sep 2022 14:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407484.650031; Thu, 15 Sep 2022 14:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqEl-0000FW-8i; Thu, 15 Sep 2022 14:53:07 +0000 Received: by outflank-mailman (input) for mailman id 407484; Thu, 15 Sep 2022 14:53:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqEj-0000FQ-Ai for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:53:05 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19841464-3506-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:53:03 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id d1so1959074eje.8 for ; Thu, 15 Sep 2022 07:53:03 -0700 (PDT) Received: from localhost (nb2assolieri.mat.unimo.it. [155.185.4.56]) by smtp.gmail.com with ESMTPSA id tl1-20020a170907c30100b0077fde38993asm4263316ejc.152.2022.09.15.07.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 07:53:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19841464-3506-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=CM2op29jHNaWz7B0LewxVe7CUQIIdaDJXgS/4awh6zk=; b=qs+XMXiWQ8CvK1uMyMyhXZNfeg7vwqYe3PLUmDuEoWkcITNUzEzAgFMXCja0gb6L+3 9JiY3f8p6ZTWJ3Imyf9ecz0YkBqO2j25FuP6i4zqOysbVyT1yEuEzoFiIWupNNmv7HG+ upsA8SlO+dmeMubTaJ8otwv+Hg0bH5h3g4PBahKlI5uHroRDX6GiSkLcqIBej+s3jj9A WXfvz+IDGualb0jQcGS63oEULiO8vcux0T/Ktmc/jRW30On/SWM4NMwN+mkmsDgNcutd YIMFWeUrBYMPLnCZecucLpIa+tuz7XLZFi+OMR54UN0hMON+fZtFClNRFVyQWZtbDj/6 ppeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=CM2op29jHNaWz7B0LewxVe7CUQIIdaDJXgS/4awh6zk=; b=GrO0f/Yy7dnihC4nKZhnYimArqYQPuUC+JPtS0QmVce+yjwW7uTP9saga+gg4gKdDp MvzCOzIYrBvdMcZYiLsmSQ7JJce860dQC8X0Ht1jRUPbDh6VJnKfEMiz/UXD1Wb1NdU6 YBAjhu4lkbTC3ipYnbVuGB1jDr9aJ7NXlEgG0f7yc2X0KV/vka4NckMQZ/h22+GOp1y4 cGsaFo9ZQ8OOq3xwEPDXDh3u+sqte7bFhJ1zdDiQvcCLQpzB57fiuPq9FGo0wyR1X8ud 3S96cN3BLhBSEauGsLdImP+PLU6mvIttlyW+1sneh/JT/8agsC56YyDGkEi02p4kuDgv 3piQ== X-Gm-Message-State: ACrzQf2CR9+/PfSwp/J4paVtIkwIPFOl8yOOzuOhiFKYnNYu3uE5oX6B t1c95CBUX40u5q+SMzhTGIXVHQ== X-Google-Smtp-Source: AMsMyM7FxVisLUSk8IDplznq5ctacqcQU6hvRVh+liIumq4EYVF4pp4cy0BIlshgYXgJRrB04Yt2DQ== X-Received: by 2002:a17:906:7094:b0:73d:c95a:e66e with SMTP id b20-20020a170906709400b0073dc95ae66emr250618ejk.179.1663253582860; Thu, 15 Sep 2022 07:53:02 -0700 (PDT) Date: Thu, 15 Sep 2022 16:52:10 +0200 From: Marco Solieri To: Jan Beulich Cc: Carlo Nonato , andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/12] Arm cache coloring Message-ID: <20220915145210.wfdvhf2gskqagz4l@carbon.xt3.it> References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <65f5a6b5-37a7-4b5f-b42b-805a51790a60@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d7pn54jbtvcdo6a2" Content-Disposition: inline In-Reply-To: <65f5a6b5-37a7-4b5f-b42b-805a51790a60@suse.com> --d7pn54jbtvcdo6a2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jan, On Thu, Sep 15, 2022 at 03:29:08PM +0200, Jan Beulich wrote: > On 26.08.2022 14:50, Carlo Nonato wrote: > > Shared caches in multi-core CPU architectures represent a problem for > > predictability of memory access latency. This jeopardizes applicability > > of many Arm platform in real-time critical and mixed-criticality > > scenarios. We introduce support for cache partitioning with page > > coloring, a transparent software technique that enables isolation > > between domains and Xen, and thus avoids cache interference. > >=20 > > When creating a domain, a simple syntax (e.g. `0-3` or `4-11`) allows > > the user to define assignments of cache partitions ids, called colors, > > where assigning different colors guarantees no mutual eviction on cache > > will ever happen. This instructs the Xen memory allocator to provide > > the i-th color assignee only with pages that maps to color i, i.e. that > > are indexed in the i-th cache partition. > >=20 > > The proposed implementation supports the dom0less feature. > > The solution has been tested in several scenarios, including Xilinx Zynq > > MPSoCs. >=20 > Having looked at the non-Arm-specific parts of this I have one basic > question: Wouldn't it be possible to avoid the addition of entirely > new logic by treating the current model as just using a single color, > therefore merely becoming a special case of what you want? Nice question. Thanks! In principle, you are quite right: monochrome is just a degenerate choice of colouring---the colouring implementation with a single colour allows assigning all the available pages, exactly as it happens with the ordinary allocator. The difference lies in the allocation algorithm. In practice, that would be quite inefficient. This is because the allocation logic used by the coloured allocator is quite simpler, since it operates with lists, instead of binary trees. Now, upgrading the logic of the coloured allocator would be an overkill because lowering the complexity of insertion/removal operations from linear to logarithmic does not change much, since in the real world, the longest sequence of physically contiguous pages that may be assigned is max_colours - 1. Cheers. --=20 Marco Solieri, Ph.D. CEO & Founder Tel: +39-059-205-5182 -- Mobile: +39-349-678-66-65 -- OpenPGP: 0x75822E7E Minerva Systems SRL -- https://www.minervasys.tech Via Campi 213/B, 41125, Modena, Italy -- PIVA/CF 03996890368 ~~> Discover how to easily optimise complex embedded solutions for high-performance, safety and predictability. Together. > Plus an advanced question: In how far does this interoperate with > static allocation, which again is (for now) an Arm-only feature? > Your reference to dom0less above doesn't cover this afaict. >=20 > Jan --d7pn54jbtvcdo6a2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOC2XMK2o3tvc3F09Ctn83XWCLn4FAmMjPBMACgkQCtn83XWC Ln4zLQ//Y7S/raGU4rfr4w8AtCppbkuijfXl0m5cLy2yPCtZgqLEgITPUcHOf2zX jSn6ZlDx2OfS5GFqcgcssY+8NxjQEKxRhCDv4VEp9+kMbk+0eYNh0DpbsEOckQ4T Tb7C3agXfD5L0U6Mmuf/gWykKqu89tdvmHd8ORWN6381t73fINIBg3jatxeg4YiW ujEAtVN/AfaVm6mdl5CR1AIz1F0cpQ6DUpAEIc1ch5Va13+cz12R33kRQC33SnnC IcE1BqdZD7EdhveStckbMFyKTvE229DvSARowup3Z95y5o33ZPHjt16ys4DDl6fC TvBpUGcjYL5PAvleSAHjuM/GqQhzqZI8R9uV7cX8nHmpyE2swmgu8eRDzZk+wN2z n8NHZnbs/Me1lNlKAXC7aXmfW00QkAy0ep5CAfyHdQgoCS9ttiYTaba863Svp64R FIPZh5ixk+x/WlT096y4FejTiRnkzvW+gb239N0L8bSHEyPtk2C9tHAnz30nxhzm bWnqqbJL4mw13K3v9DbzaOoYxWSUpqnJpbajY8OHy9k/6KM1Dolvw49qJ7dxD3ES fXwsAZpk74ZAgOLCsMTr963A8+orAAo+glcRAQocl3+dpEAitjT6RJhGGEXIrq/z T05DtN8QUCkARN8+1Mv6Y+Ldm53sdeJjBMOVQEpqU0Ucd/5RBiE= =h9PM -----END PGP SIGNATURE----- --d7pn54jbtvcdo6a2-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 14:55:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 14:55:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407497.650059 (Exim 4.92) (envelope-from ) id 1oYqHU-0001VE-3W; Thu, 15 Sep 2022 14:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407497.650059; Thu, 15 Sep 2022 14:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqHU-0001V5-0i; Thu, 15 Sep 2022 14:55:56 +0000 Received: by outflank-mailman (input) for mailman id 407497; Thu, 15 Sep 2022 14:55:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqHS-0001Ox-Sq for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 14:55:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f08f0b4-3506-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 16:55:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 456F01F8D4; Thu, 15 Sep 2022 14:55:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 06CDC133B6; Thu, 15 Sep 2022 14:55:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id s3gpO/g8I2MnBgAAMHmgww (envelope-from ); Thu, 15 Sep 2022 14:55:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f08f0b4-3506-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663253753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Up584H0P24z3r3gFq4EXpD2t/lW/iWfr0mZFDdcmhXw=; b=BIFkM/hGv7VK2WLEAZHdqcYlEqZ+Eyiir8loQuZ+t5qFCrF3oP/WK5y9zaSUmuUgp2Sxw0 hBnrUpOfbkkWVl3WrmeCu06qSM4jf/g+nfB5YzpU96SOf1FiuAy3tTW8N+mLKbsgcOikdk YzQY44yYWMugyAemhGzoKdYkgem4FLI= Message-ID: <643ef313-b9a8-e6ab-4dcb-43919f4d7af6@suse.com> Date: Thu, 15 Sep 2022 16:55:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] xen/xenbus: fix xenbus_setup_ring() Content-Language: en-US To: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Cc: Stefano Stabellini , "stable@vger.kernel.org" , Sander Eikelenboom References: <20220915143137.1763-1-jgross@suse.com> <34c9a80d-3a9d-cd51-32d2-cf778c981107@epam.com> From: Juergen Gross In-Reply-To: <34c9a80d-3a9d-cd51-32d2-cf778c981107@epam.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------wFpgqiE47FhWtDq0JbwO0ovi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------wFpgqiE47FhWtDq0JbwO0ovi Content-Type: multipart/mixed; boundary="------------crtVEa6kfQw0NU0tyzTzdGi9"; protected-headers="v1" From: Juergen Gross To: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Cc: Stefano Stabellini , "stable@vger.kernel.org" , Sander Eikelenboom Message-ID: <643ef313-b9a8-e6ab-4dcb-43919f4d7af6@suse.com> Subject: Re: [PATCH] xen/xenbus: fix xenbus_setup_ring() References: <20220915143137.1763-1-jgross@suse.com> <34c9a80d-3a9d-cd51-32d2-cf778c981107@epam.com> In-Reply-To: <34c9a80d-3a9d-cd51-32d2-cf778c981107@epam.com> --------------crtVEa6kfQw0NU0tyzTzdGi9 Content-Type: multipart/mixed; boundary="------------IS3EwCOGghcUGT2zkq73JJEK" --------------IS3EwCOGghcUGT2zkq73JJEK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDkuMjIgMTY6NDcsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4g T24gMTUuMDkuMjIgMTc6MzEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IA0KPiBIZWxsbyBK dWVyZ2VuDQo+IA0KPj4gQ29tbWl0IDQ1NzMyNDBmMDc2NCAoInhlbi94ZW5idXM6IGVsaW1p bmF0ZSB4ZW5idXNfZ3JhbnRfcmluZygpIikNCj4+IGludHJvZHVjZWQgYW4gZXJyb3IgZm9y IGluaXRpYWxpemF0aW9uIG9mIG11bHRpLXBhZ2UgcmluZ3MuDQo+Pg0KPj4gQ2M6IHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmcNCj4+IEZpeGVzOiA0NTczMjQwZjA3NjQgKCJ4ZW4veGVuYnVz OiBlbGltaW5hdGUgeGVuYnVzX2dyYW50X3JpbmcoKSIpDQo+PiBSZXBvcnRlZC1ieTogU2Fu ZGVyIEVpa2VsZW5ib29tIDxsaW51eEBlaWtlbGVuYm9vbS5pdD4NCj4+IFNpZ25lZC1vZmYt Ynk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gICAgZHJp dmVycy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYyB8IDkgKysrKysrLS0tDQo+PiAgICAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPj4NCj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NsaWVudC5jIGIvZHJp dmVycy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYw0KPj4gaW5kZXggZDVmM2Y3NjM3MTdl Li5jYWE1YzVjMzJmOGUgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVu YnVzX2NsaWVudC5jDQo+PiArKysgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NsaWVu dC5jDQo+PiBAQCAtMzgyLDkgKzM4MiwxMCBAQCBpbnQgeGVuYnVzX3NldHVwX3Jpbmcoc3Ry dWN0IHhlbmJ1c19kZXZpY2UgKmRldiwgZ2ZwX3QgZ2ZwLCB2b2lkICoqdmFkZHIsDQo+PiAg ICAJdW5zaWduZWQgbG9uZyByaW5nX3NpemUgPSBucl9wYWdlcyAqIFhFTl9QQUdFX1NJWkU7 DQo+PiAgICAJZ3JhbnRfcmVmX3QgZ3JlZl9oZWFkOw0KPj4gICAgCXVuc2lnbmVkIGludCBp Ow0KPj4gKwl2b2lkICphZGRyOw0KPj4gICAgCWludCByZXQ7DQo+PiAgICANCj4+IC0JKnZh ZGRyID0gYWxsb2NfcGFnZXNfZXhhY3QocmluZ19zaXplLCBnZnAgfCBfX0dGUF9aRVJPKTsN Cj4+ICsJYWRkciA9ICp2YWRkciA9IGFsbG9jX3BhZ2VzX2V4YWN0KHJpbmdfc2l6ZSwgZ2Zw IHwgX19HRlBfWkVSTyk7DQo+PiAgICAJaWYgKCEqdmFkZHIpIHsNCj4+ICAgIAkJcmV0ID0g LUVOT01FTTsNCj4+ICAgIAkJZ290byBlcnI7DQo+PiBAQCAtNDAxLDEzICs0MDIsMTUgQEAg aW50IHhlbmJ1c19zZXR1cF9yaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsIGdmcF90 IGdmcCwgdm9pZCAqKnZhZGRyLA0KPj4gICAgCQl1bnNpZ25lZCBsb25nIGdmbjsNCj4+ICAg IA0KPj4gICAgCQlpZiAoaXNfdm1hbGxvY19hZGRyKCp2YWRkcikpDQo+PiAtCQkJZ2ZuID0g cGZuX3RvX2dmbih2bWFsbG9jX3RvX3Bmbih2YWRkcltpXSkpOw0KPj4gKwkJCWdmbiA9IHBm bl90b19nZm4odm1hbGxvY190b19wZm4oYWRkcikpOw0KPj4gICAgCQllbHNlDQo+PiAtCQkJ Z2ZuID0gdmlydF90b19nZm4odmFkZHJbaV0pOw0KPj4gKwkJCWdmbiA9IHZpcnRfdG9fZ2Zu KGFkZHIpOw0KPj4gICAgDQo+PiAgICAJCWdyZWZzW2ldID0gZ250dGFiX2NsYWltX2dyYW50 X3JlZmVyZW5jZSgmZ3JlZl9oZWFkKTsNCj4+ICAgIAkJZ250dGFiX2dyYW50X2ZvcmVpZ25f YWNjZXNzX3JlZihncmVmc1tpXSwgZGV2LT5vdGhlcmVuZF9pZCwNCj4+ICAgIAkJCQkJCWdm biwgMCk7DQo+PiArDQo+PiArCQlhZGRyICs9IFBBR0VfU0laRTsNCj4gDQo+IFhFTl9QQUdF X1NJWkU/DQoNCk9oLCBpbmRlZWQhIFdpbGwgY2hhbmdlIG9uIGNvbW1pdC4NCg0KPiANCj4g DQo+IFJldmlld2VkLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hj aGVua29AZXBhbS5jb20+DQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQo= --------------IS3EwCOGghcUGT2zkq73JJEK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------IS3EwCOGghcUGT2zkq73JJEK-- --------------crtVEa6kfQw0NU0tyzTzdGi9-- --------------wFpgqiE47FhWtDq0JbwO0ovi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMjPPgFAwAAAAAACgkQsN6d1ii/Ey9N XAf/bpqthZlSl1ixQKVVr9dS8fNG2tPVotRcLlJFDxlqzhiVrOdrcyL7dzDcyMRgMOJPzuz9CJYV yGfwD3XPNLLJ1qNdn7lY57i6bj1ZrcjwzqHbU69jXqbUUzHGpiTC0ivSLiByoNNGQp1KJ8Ld4hSX MDlOFL5H40DvovwXvdOIp8wAJosY4Xj6oxixVKP3B2nK2PehZ0/RUvWRj3eZB0D36HUXgMxfM4r4 +WtS6ZI0bEBh/70CGKBY6X8XH2et07lxa5HA3nbSrxMxpFaZAbdKgop61Xi7htlrUGHp6Dj3Oktz rHryOTk3wojNRZ9ECsEF3Tvfw8N7bsX/b5f686okaQ== =RHQ7 -----END PGP SIGNATURE----- --------------wFpgqiE47FhWtDq0JbwO0ovi-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 15:16:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 15:16:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407537.650071 (Exim 4.92) (envelope-from ) id 1oYqbF-0004e1-RS; Thu, 15 Sep 2022 15:16:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407537.650071; Thu, 15 Sep 2022 15:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqbF-0004du-OO; Thu, 15 Sep 2022 15:16:21 +0000 Received: by outflank-mailman (input) for mailman id 407537; Thu, 15 Sep 2022 15:16:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqbE-0004dk-0M; Thu, 15 Sep 2022 15:16:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqbD-00007p-Us; Thu, 15 Sep 2022 15:16:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqbD-0004ZJ-Ew; Thu, 15 Sep 2022 15:16:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYqbD-00059d-ET; Thu, 15 Sep 2022 15:16:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zYPlpe3TYGGeR0/kGAhxn3dvQ1ZAktvfOuLqk+Vhgqs=; b=AuZH1u5gBDfc0uoiyHpyh3kt9E UceYAo+5218GUaZEDa9yQl9NiQdHZYkEd9MbDRpe7j2MHGnfWqDczNB2wqBUa+kFDYLT0iJVZi990 bgJ7pWMHUwgHVWceH2qrxXQB2UkqL2/YqDDBnFijo9rGSE6W2p7ydUz4s5MbuSTbbD5k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173211: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=45297e6c9bd1be53b3c462adb9b37b4df2ea8681 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 15:16:19 +0000 flight 173211 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173211/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 45297e6c9bd1be53b3c462adb9b37b4df2ea8681 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 42 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 313 attempts Testing same since 173211 2022-09-15 12:14:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2543 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 15:24:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 15:24:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407545.650083 (Exim 4.92) (envelope-from ) id 1oYqjJ-00064e-Nt; Thu, 15 Sep 2022 15:24:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407545.650083; Thu, 15 Sep 2022 15:24:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqjJ-00064X-Iu; Thu, 15 Sep 2022 15:24:41 +0000 Received: by outflank-mailman (input) for mailman id 407545; Thu, 15 Sep 2022 15:24:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqjI-00064R-K7 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 15:24:40 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 820671d7-350a-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 17:24:38 +0200 (CEST) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Sep 2022 11:24:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN9PR03MB5979.namprd03.prod.outlook.com (2603:10b6:408:134::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 15:24:27 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Thu, 15 Sep 2022 15:24:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 820671d7-350a-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663255478; h=date:from:to:cc:subject:message-id:mime-version; bh=VABl6vMd1dJIgFwShDoQmWZp65IJUwBHc8cGrqnEnEs=; b=FAFQWZvUPObbwunsZAGWTR8Wa5Z+hMLjfJKdFnCU9j1+PX4YkVGRPmR0 FEftWKvz8eIXI8aaor9+jSazQevGZ/AYBGYgxvAevILxsXQBrMgtqVnat SphtjQ4j2jxfgbzykhZJGQPOXkTSTEDYWjAWCDJ9HSUiLH7VTsxKYZLWg 4=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 80281675 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tYv99KinD9twsW+oA1f2t7u+X161aREKZh0ujC45NGQN5FlHY01je htvDDyDOP3YamL3f4oiYNi/8EkAvJCGz9M1G1E4qHg9HiIb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaQr414rZ8Ek15KWr5WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eH4Nbo9pUA3906 vkCKzsPRAyfl+a3+efuIgVsrpxLwMjDGqo64ygl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTM+/pfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv GPWuW/+B3n2MfTPkWDVqyzz24cjmwujY7A3OLOE58d4o3LP+0ZDCCYoZ12k9KzRZkmWHog3x 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84hmbLngJSCZbb94rv9NwQiYlv mJlhPvsDD1r9bGQF3SU8+7NqSvoYHZFa2gfeSUDUA0JpcH5p50+hQ7OSdAlF7OpitryGnf7x DXiQDUCuoj/RPUjj82TlW0rSRr2znQVZmbZPjnqY18= IronPort-HdrOrdr: A9a23:ErsGJKAEkxUo9OnlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="80281675" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jdAij5FccnW0NwrVFzq4+ctdxtajAI9jyDw5+kjSb7vb5k5oHrQnJZTvjDxYqdGX7yVU9ENbUCKVQQC00DYzJQA1reFbvhJXkgxPXXTbb6InOitdVnO2OZDg/O4JHMvqnGU5gFKfYzi/cN1omhoFtQ493WWcvnh55qGBDuuH7VaLYykri/RwI/o+GpIUxf5pchfLBrgg1EQV+Ifq4z29iPMjoongo32LHX6lbHrbr985twQAryYCopcHKwnINZ5LxZTRam1J5sV03axM8w6O/Z8yodksMeyCiI61nRIXYc6xCvPOXia9bEldGxfT9FD+DxfpYQ6ADT8gubwUi6vg4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rGU1akVy4OKD7SyL8avyZnajpBBC2I+oEl7N+VuF/hA=; b=AVfAcTjqRbWj2mCuQhcRlGkI8KCiP/cy0una3QveLncLqlphMGx3LcyVdsKJJkFPoJWjLqbBauziVRvcvuvt+lpNP52VMpoMyUmE56FxuX06ALYVBi7E7IFe0296TvPGAkvPP/aAeXDjq0JPysGk3WFywENaPArsn8dEsgJDENsXbtrkwlOm0DrZKTqQc2H9tyAAOflsPGuJwSd4fHCR7NzW9wXihg9YsV0hDIKby8AzhSMGennVWSJEw9zEkLR5E3ETaVBUxnnmbGgeipWlOMBOunlUQrvlqcAofIm5mBTpsF/WcIOgUI2TJs/4snEzFk46nObfq68nnwv+NWMtGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGU1akVy4OKD7SyL8avyZnajpBBC2I+oEl7N+VuF/hA=; b=cKoaNTI+p3uT+7QQgBd861r2eU47Qiyi95x7Vb76tlqxw00sXJzkMMsUjxZAlWIbTbZJmbyTZugem+OW2OG00igMI7FxbaOcUDn2R1YSl5VBdy63/AV0o+6Ch8lE60nmbfSU+LATZF2FUCtmjPZRcDOJKWkvn94yrIqamdxXvUU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 15 Sep 2022 17:24:22 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org, Ian Jackson Cc: anthony.perard@citrix.com Subject: Sorting out osstest Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-ClientProxiedBy: LO2P123CA0032.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BN9PR03MB5979:EE_ X-MS-Office365-Filtering-Correlation-Id: 86ef3ba6-5bc7-4753-e8cd-08da972e605d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BPWE22FljCsjjOllfsbwzXOtoqWSIGb3sYI9H27qNHAVf0nR5M2TLDHo4Yvd97LsjQ6BVEROWPcx67x3+8hOzaruyI2FhmrQNuwuBosNSCXrvFRv3UNcNcVNhgjIDiBvtyttI5h3a5EbXLilev0UrUacfyrHy6HWdE5QMBl/ps3c6p7mYa/J7a2vNcoOTsbz0aMVYrm+QNuvEnf+USeoy5i+uk2WH1N6m6G++D7xiWC/giJsMtlNZGJtc/QqWM8HWLU9Vdy0xVhfA5oiSyffe1vSiLaOowlmNiZbT9IohXYgQkEhioCnjGPezyPGp6PKmnFkLazalKmEb6Y0Eed4/xWQR7JX++zTBH+G9+DlMMj4XvYVACjq9dG8T5/VQ+9bs9K4l3kiqy9ojEohq7uAg0oI420HNY28YFyQHzBrIxgUVw7oCyc3uCNIAvcTwE4NZbA/U/mqO1RwbQJsobPjcPOyoaQSO8yZv+oDFyPlJvoju87JbPBk2Q3z7CQYs/g2bvTbp6ySjqaxqgtkMLQaJ/6f10ah5owPJY0Uyux31//5yDXecd0FMAqgf1za1UO7b7GtULoJupeC65CluKmpGR7m+eOPveFy1YBVa6FndqIXuDRXqlrfAcJs5wnwcEonfiUHXqtBdN7aEV84ZtBtWv5e0eIu6A4f0FSJvIPVqKngyKyOtrfQuomYXNQHGSID/3/vKkg3komzUAUuJ2xlrz86QS3P+rT82nkg87SHQjmeAPaGZ0qHaxQF4VIs7L1h X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(376002)(396003)(39860400002)(451199015)(6666004)(107886003)(41300700001)(9686003)(6512007)(26005)(966005)(6486002)(6506007)(186003)(83380400001)(85182001)(66946007)(7116003)(8936002)(8676002)(5660300002)(4326008)(38100700002)(66556008)(478600001)(66476007)(3480700007)(2906002)(6916009)(316002)(86362001)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmlmL2xRK0RmRElSWkg2azJhdFl4MzNDdTAwL1ZLN3pYbU9CaVlCNWlGMzND?= =?utf-8?B?MG1SSnpVR1g4UUFzVWF5VjI1SzMraURMQUdyM1RJcTg2c3FmNXBtT1g5Tjcx?= =?utf-8?B?RFlteHhyWlJZNFZlUVJNMDhoREE5SlllT3NqUUIxQVlIMzNrOXFoVjZmdDNM?= =?utf-8?B?QTVUUEJ6NUYxenM0bFZkcVdVYWVsWWh0SDBOMWRjUXN2SFh5NEhWWGJnSTBk?= =?utf-8?B?cWs1ZTlRUUhhaXd3TUZqajN6U0RkeWlzUzY4TDkrMVpQTUpLSWJENmRXemJt?= =?utf-8?B?TURIMDY3UzNDcFhOTktzdlZTb0Z6ZUIrZFJ3V3AvaDFsbjBQWE5JRVFySGhy?= =?utf-8?B?Qk45K3d1VUhiR1NEVitaUTVGZzdBUGpWek94VGJqYlYra2hSZUs5S25CR2RX?= =?utf-8?B?ZVZ5TUQ0VDhMN2JGZ05zL2ZrNG01RVdMVlB4WlVOMVo1Vy9iQWJUM09VWmp1?= =?utf-8?B?MlJ6a3dldnFtUlBXTE53em05QjV0UHdSclhuVkZIYVNtdkZpT3NhbFV6WlVG?= =?utf-8?B?SFN4ekNYMzgzOW0xRmlZejZIbGx6L1lOaTJXMWUrT05SVThMalhjQjBDWTVZ?= =?utf-8?B?OEdQTEZ3bmx0MGEvenp5TmJnOFJaOVJ4N0pZR2ZiN1k1bzVEcDkwMTJ1KzJW?= =?utf-8?B?N3AreVd4WTNiRU9qdk5Gc2loc3JrMVN6UVZqbzB3RXJKT2Y4YUpuaWhjR3Vz?= =?utf-8?B?dFBqWER0MXF0ZDVTWkpoa3Vpa0xrQWtBNmJqNWU4SCtkbmpHTHI4UzZuRU8v?= =?utf-8?B?L3ViZ2ZSTENRQ1BrQ2tWdUhiUE80S1NScU8xNUlTWVV2V3g5SlNYSlMvMVEz?= =?utf-8?B?a3RIVHQrRExQYk56akZSbWNMbzJNdmhETWxwcHlWMC9maS8xQk5uWGlRNExx?= =?utf-8?B?dlhTdHFwWTl3RS95K0o3MmlBT1dPOExyNDN0R05nSEJmak00NzVMVWlqWFhh?= =?utf-8?B?UlBHdmFyN0tYS1A2SmpNcG9GeldJWEZLZnE4SWNHOHpPRDZOczlpV3dhcW01?= =?utf-8?B?ZVdDakJrR3pwbmFkNEF4cFZyTDVMdGRtZjNWYWV5b3JKZmlwQS9YVWE2Y3dF?= =?utf-8?B?Y01vMXg0K1Z2aVVXYUMxbitQWE5oM2lEQnZOVDBvYWVrTUI4aEdCNk16UThR?= =?utf-8?B?bGlKcWJpVWZpNG1JbTkrWUU5U0RsbnNKWXpyZDVMWHQxR3o2a2tZWGVMd3pT?= =?utf-8?B?d1hTWUJkWStManpWSUNLS3B0TzJWcFVHM3FXa1krZkplRWt2WlZpM25jRnVB?= =?utf-8?B?N3A4Vm5kU0FVYURyc1ZQZ0szQmpPSGhMOUtwOURUcDZLWVhhRjArNVV2NXVZ?= =?utf-8?B?U3BqUXdvUnJlM2RtWUZmUUpyMFFEZHZKdmQ3QUcwZUhBYkF2dG5sME92N0Ri?= =?utf-8?B?Vy9LUHNNV2pkUFN2bEk1Mi9ibWc5NmJDM3ZpQ1Y1YkV5ZGxVNnBKUkNwWWRH?= =?utf-8?B?bVJnTkJ6RWpMSytmbEVqUi9lWWc2b3R6VHowcEoxNWFTV2ozT1cyTFh6ck5h?= =?utf-8?B?VGI1cGhTNTMwOG1tc1JHZmE2bXQwVExnUkJ5OE4zeG1DZVFVRHMwSnJFK2ZP?= =?utf-8?B?SGVZb1J6cXBSTVFSdUkza1RRUzNPbDN1aENyNzRSNkpreFFOZnA1TldibUdF?= =?utf-8?B?OHdibEJhUmZaU2oxYklLdkpPeW5UMEZTNHJ2aW50dSt6TXR3K3FoMGhrSUZy?= =?utf-8?B?VWhXYStYTDdXd0E4TEthSmFZaHhsZzZmbFAveHg2VEJkWnVqZ25RcXYvZTRJ?= =?utf-8?B?SjFudzBhbFdjUG1NVjNEbFJXLzNEUTdtK0hhV1FIbkpUVmR0Vk83VW9Hc0tK?= =?utf-8?B?MmJKSWRuRUViK0x2THBxcHhRN2RDMUZkNnpJWnkvVnRiWHMyLzc3K2xaMjRT?= =?utf-8?B?aGd1NHFTanFRWlpnWTZXRjYwenRjdzRuNFRtZTREWGNvOXRoaDJNZzI3NjlF?= =?utf-8?B?NVFOY1pjOVRHektLc0xEdDRTZU1MRC8yYklzb3orMzRJR3l4cG9XMVFmSTNh?= =?utf-8?B?TDNxbCtTcy9LazBIZ2VGdFN4Q2s1bW5jQ0FsNDIvU1VFcCsva2RLUGtkTURG?= =?utf-8?B?SjZENGpOUHBLK3ZqdTA4QjRFZURxWFhyRXYyb2lqZkhoYTFoOTdZckpwZlU2?= =?utf-8?B?c0tjb0RWTGIxR1h1VWFMc2xiR1AvUUJ3U2tET29KYnNzRXhxY29QcU8vVWhj?= =?utf-8?B?UWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86ef3ba6-5bc7-4753-e8cd-08da972e605d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 15:24:26.9746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3A2rL02UqgsY0fdb0Jz1U0x2JpkhO0FdT1Rhlc94OGTgiviQ/qj8ncCB/6kVXASf1CKWX4lWBp3Oiolr2OXIuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5979 Hello, There was a bit of a mess with osstest, changes have been pushed directly into xenbits osstest.git#master. The same changes have also been pushed to testing.git#pretest (but it seems that with different hashes). Prestest however is not passing because of libvirt build issues. osstest.git#master: 8510c7df (origin/master, origin/HEAD) ts-libvirt-build: Rework to build with meson f9d084ab TestSupport: Add support for installing from backport repo b21b6e80 (testing/pretest) ts-xen-build-prep: Install newer NASM version, to build OVMF 2cffc6ec (testing/production, testing/master, refs/patches/fix_efi/debian-hvm-cd-update) osstest: update Debian Buster install CD media to 10.12 dc762d67 osstest: install irqbalance testing.git#pretest: 12c254e (HEAD -> pretest) ts-libvirt-build: Rework to build with meson c2c2f5a TestSupport: Add support for installing from backport repo b21b6e8 (production, master) ts-xen-build-prep: Install newer NASM version, to build OVMF 2cffc6e osstest: update Debian Buster install CD media to 10.12 dc762d6 osstest: install irqbalance My plan would be to pick osstest.git#master, add my libvirt fix on top of it: https://lore.kernel.org/xen-devel/20220913100328.27771-1-roger.pau@citrix.com/ And then force push the result into testing.git#pretest in order to overwrite the current pretest branch and have it based on osstest.git#master. I would then expect the pretest flight to succeed and do a fast forward push into xenbits osstest.git#master. Let me know if that sounds like a suitable plan. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 15 15:38:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 15:38:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407555.650092 (Exim 4.92) (envelope-from ) id 1oYqwz-0007oJ-Tm; Thu, 15 Sep 2022 15:38:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407555.650092; Thu, 15 Sep 2022 15:38:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqwz-0007oC-R3; Thu, 15 Sep 2022 15:38:49 +0000 Received: by outflank-mailman (input) for mailman id 407555; Thu, 15 Sep 2022 15:38:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYqwy-0007o6-OM for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 15:38:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7bdb0609-350c-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 17:38:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7bdb0609-350c-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663256327; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Iadj4JYfo230c1tOxQcP3tY1NRj8KoURbKAfkgTiKhg=; b=VZczGXR+EIlM6eKmTax8gvyC58oPR/4SDoPVFct2XwPGrrO3NycDkVSW uQw7ADZj6CgF5k7sNQmRkcXKCxFMnNy+X1z1uzre0kSA+z7JxWw2x9dqO Kn/eHHMh3VqhF93vzfcv/B9aae1EvRG8qw1yNMxlvgygmo1mN3Um5/5aU 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80606110 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AVqkKra6hh0hS4szd+fdleQxR2vbMJRcaRSYv2?= =?us-ascii?q?9bJ6EIq2BhvcrjodFUmCkIcWPpLnpZLPAsPED+bGMIyG+dUvupRQ9a1IjqZS?= =?us-ascii?q?3xd7v7rPxcKMrAeaYl13J+4oG6z6tQglgPC6T7PDiRhkJqnSNkcjsqaehiYA?= =?us-ascii?q?XU9X5efba1KtHU1tbQdm9MbbbmgLKc4/y4JTNXpLC9gWg8OjUa854Aop8QaP?= =?us-ascii?q?xCyNV0SJVopsGHhQqgbR2aZ/5IDw4YaZxDyHtuJroBYt5zerPNfmTXxksYnH?= =?us-ascii?q?A0jkfwQCP8yZTlX6QEwAaUEbqogyEFzEfLUO+E9iCH94SszdUr4opUOQZY7K?= =?us-ascii?q?iaO6kr2la6msCbKjZOQy9WEbzqR88p7GJg2G2rzHOIUKJzx4YThmZzXZvC9N?= =?us-ascii?q?+v7FnRhm7I14B7/BwPL7Mi8R4F5F22rxXa599Cu/vyjPW714n0uOdmNNDT8M?= =?us-ascii?q?17v4449vHj0hVr5hDXZRdpHyRZ6LQbO0pQbvgZ/oSe9/GpbEAPtd8kW1Z8bk?= =?us-ascii?q?tHVEda8QBpWn0DIfFJpT25Y7bT78wTaLoiTyEDZkTlzLmg8nNpFCX8eEc9ag?= =?us-ascii?q?NOUgd9bunFMTX481Kgv4BGeBwEJLQOEHfi6Z/eCelgJsx6v7IQC6bF/X6jZf?= =?us-ascii?q?q2L1Pp9ZUSrV8k/tmzOtZEdJS/qfegLq3a5UvhGeYu6NdYzGHy9abG1TZKHL?= =?us-ascii?q?ADc2g0NiQlufbfKcMnOhwhFZ4MRNxXTa85pX0GEUiMwaPm+qt9C9XL2qe0wj?= =?us-ascii?q?gVbGmF3KiG9YcetRNma2FUE9D+BvU8yGReVKLbPqKu6bpjFZCHJHHy2EKlUi?= =?us-ascii?q?V2E0WcX25BVmbjBUujTQvlzLuy5TLpzEoUWCXCcjDVqtmEx5BYdZ5udktR2J?= =?us-ascii?q?1W6F1i6IWtmbsfPd+d+PXLTa2ep8LNF/Ge9TT3L9Aenj3kSt5YVXtrHv5mcp?= =?us-ascii?q?QccYBa3h35zCy1JulrnVOw50jPlnQoMqqSpQ5H31OdzA4H/BLfCjthE1NM26?= =?us-ascii?q?cEnn3hTuQt3AvRBQGrksafrNEZPB7E4kgVhb/2vpQOGlSYQIW5BjRjZa+1Tt?= =?us-ascii?q?daHZlTQSgBAtGZmsa/vaxTzgMvH6RQur3Pu4fHFB5mc18fHFFdV3jXlXibgw?= =?us-ascii?q?moFWVIFykqG1wIRyIwaTPWDEtrEtw1PcBETCGdCOwMQWDe9QaheLolSJPs8C?= =?us-ascii?q?3TffJKWOEY6Tpahz7HgWz7FjWaIphdSEVLVtZzoAGjTCiQJdAeSaOPq96Slo?= =?us-ascii?q?Fh868rH9iyxFomVAm5iJRtunaO8Zx55tGe1VFhYtG9By4FBBJlp1FJRRDkMA?= =?us-ascii?q?KSB//LD6SsJCK8PHObPsoZZwUcy5S99UltdgFc4dVsp9g43aX3tqL1aXU+wg?= =?us-ascii?q?B+MiBq9/aiaIUBf4caM0S/SjxB0+ovQ38jrAu+86jtsqnl6oCKi+bXP9Excz?= =?us-ascii?q?ysghNeNImlaqTtaLzrspJtK1E6s4zayS9qG8YDCu1RzQjbA99UVAHMf7d2K/?= =?us-ascii?q?kF6+PD+asPW1jLvZTUfHbhOOWO8TXOL5FvrQpdmtYYVKrKYoOUSEtVqadXYk?= =?us-ascii?q?Pi4+FpgZbvJdIPFID9FWFMSsxlWRUCxYCgFMnQ3JavtMFJP8DkZg7PvNHaIJ?= =?us-ascii?q?DhPICHChft+dbZBWosrFu9OM8ehVIoa271701+4iSit4j/hZmfbXlQEZW6rk?= =?us-ascii?q?igsdHWM0zA5caemTyiumLJuU021Ox9Idyrhm7N2VRSr1QrBxm7YZQzbtBKrn?= =?us-ascii?q?CWz9o3KcQ93ybd19VTZ86L/Ee4PjW0djvhQ14U+Yofqg0rCPB5af/9UoPmxa?= =?us-ascii?q?Bs0qDJR318SI+v26UV3ub6cGsB3F+d+Ud/OrR01b3r4hTy/1sJnti1T1CJJl?= =?us-ascii?q?rIreDDxjhVI2MzQm3JAqENHUToNMrWWUkO+vqpJdZaEHyVXFhn5wwk2aYN/m?= =?us-ascii?q?5phn8I1HhXsbfgWE0XP4yhMQKiv3MuheX1M0AXNV/Uh7a+P77i3PNjC3ygUG?= =?us-ascii?q?yYsRYbY9ff/qiSKedqkXZwIf2TUYxD0AY3Jlhk6qVwSaad4DXjD6oxbLM9MB?= =?us-ascii?q?AhCvTTR1yLL8HqfFnlwsJUctSlZLOeSctlP0iUxR76SU5dEaMnAUFNA1zpbA?= =?us-ascii?q?oioh0clM9O3riTOhMZw4fTFDOumYEy4r93FR3MEjfATbcZgP5pOd1ha0LyNn?= =?us-ascii?q?dKEAuqmtLPOF0GaCdqQBI9pEQ4mz4j1gegKFg5NMxSGlxkZVRN27N4ujhyOs?= =?us-ascii?q?OxULFVz7CJ58o5vcVOhs+B7ldta16mXYOapPGGle7RX63genDZrKclFxx7Wo?= =?us-ascii?q?hjeov2GY4Nvv7PSN4HKzduJQ6ZWjM0qOvcyeoizX2BPuYENmwrV1NIiryHus?= =?us-ascii?q?Xckpkv//ZWWR/CnxBuciCohRBmEkJq7OGbB9/LibkU/w7mim+ewv1nBAv0iK?= =?us-ascii?q?C4Tm08jiEy0Z4L4TUR6GTg7ow70Wtx2a734PpMKXDmDjyFHFz8ms+sJbyeob?= =?us-ascii?q?bi1BnMkUUVnDn0WYSwVbMQt0W48NYABhozPgec0pnASc2USPdLyKw/QgB9EX?= =?us-ascii?q?7YTlcZuqqMSFPj4RHk7NRBF6GJjVmmqvW8xuGrg0FJJkt253wwsqXRM0GHkJ?= =?us-ascii?q?DQivQqyGucjXmtKdi2+RDgE/pph288Dds9YEnHmsKZce8g0sVuUJbuAy4G7T?= =?us-ascii?q?zcPR0OvoQSUzms7cAgQQ+1rNUdtLX79jpGTNDMnE+Z4xbeq9P5ua5OJ7Mr6v?= =?us-ascii?q?KyVO8b2dcCRM8XYgg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="80606110" Date: Thu, 15 Sep 2022 16:38:41 +0100 From: Anthony PERARD To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: , Ian Jackson Subject: Re: Sorting out osstest Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Sep 15, 2022 at 05:24:22PM +0200, Roger Pau Monn wrote: > Hello, > > There was a bit of a mess with osstest, changes have been pushed > directly into xenbits osstest.git#master. The same changes have also > been pushed to testing.git#pretest (but it seems that with different > hashes). Prestest however is not passing because of libvirt build > issues. > > osstest.git#master: > > 8510c7df (origin/master, origin/HEAD) ts-libvirt-build: Rework to build with meson > f9d084ab TestSupport: Add support for installing from backport repo > b21b6e80 (testing/pretest) ts-xen-build-prep: Install newer NASM version, to build OVMF > 2cffc6ec (testing/production, testing/master, refs/patches/fix_efi/debian-hvm-cd-update) osstest: update Debian Buster install CD media to 10.12 > dc762d67 osstest: install irqbalance > > testing.git#pretest: > > 12c254e (HEAD -> pretest) ts-libvirt-build: Rework to build with meson > c2c2f5a TestSupport: Add support for installing from backport repo > b21b6e8 (production, master) ts-xen-build-prep: Install newer NASM version, to build OVMF > 2cffc6e osstest: update Debian Buster install CD media to 10.12 > dc762d6 osstest: install irqbalance > > My plan would be to pick osstest.git#master, add my libvirt fix on > top of it: > > https://lore.kernel.org/xen-devel/20220913100328.27771-1-roger.pau@citrix.com/ > > And then force push the result into testing.git#pretest in order to > overwrite the current pretest branch and have it based on > osstest.git#master. > > I would then expect the pretest flight to succeed and do a fast > forward push into xenbits osstest.git#master. > > Let me know if that sounds like a suitable plan. Yes, that plan sound good to me. Just one thing, `git checkout master` in testing.git as at the moment "pretest" is the current branch. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 15 15:43:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 15:43:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407562.650104 (Exim 4.92) (envelope-from ) id 1oYr1m-0000mo-Fr; Thu, 15 Sep 2022 15:43:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407562.650104; Thu, 15 Sep 2022 15:43:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYr1m-0000mh-D5; Thu, 15 Sep 2022 15:43:46 +0000 Received: by outflank-mailman (input) for mailman id 407562; Thu, 15 Sep 2022 15:43:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYr1l-0000mb-1z for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 15:43:45 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cd53950-350d-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 17:43:43 +0200 (CEST) Received: from mail-bn8nam04lp2047.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Sep 2022 11:43:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB5912.namprd03.prod.outlook.com (2603:10b6:510:40::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 15:43:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Thu, 15 Sep 2022 15:43:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cd53950-350d-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663256623; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=imvobpJKOs+YK9Q3NP3nitqE+xSoQweHyBX2W9oPZ2M=; b=b+zcd6PFMIFWSz5nB+OAarJe+eTs25Np5OSjt+OmkH4qkrTFH4zNJV9X LS9RKOtHs9eSGEj6C+SJjDx8LjPIibV2k2zej+mELGBmTWY3utiL+RrE6 wX8qVgVbTD/84xfSi9sJ/P7AkzOnJl6AmZITwlfE0Z3MBIqDvQL3Fw0o9 c=; X-IronPort-RemoteIP: 104.47.74.47 X-IronPort-MID: 80606575 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AJXYSlaoxqjgE/GZvpIoOu1LwFiVeBgzWbkUCk?= =?us-ascii?q?Ij8NTMUsmV9RDklARbmC1H/SmUOH6lRJ12Li22o4QS1BUtn7T0DSHuUOmbDA?= =?us-ascii?q?6N/KNYXvgEZKOkUkPTFRcZNoWdCnu9XMzd4FtkxfN4T79Ix/fhR8XW2XWR5Y?= =?us-ascii?q?hB9/Plei9QJWo1DInWq7QvhStXeDfXG0b33pwp6WHyZ5NIKAONpfl4n0LwWe?= =?us-ascii?q?WZOhByqbOwbTJKsSXnvhjYKXquFOsrrcAbtrfMYS+q+3bFU6XsUuvsmyGpLo?= =?us-ascii?q?fzNdoWZlzxhRrxupRolpBU7z0qulPZzGOr356FOIsrHmprOaFC2E78M6rZHl?= =?us-ascii?q?aUseZp0nwJrsdglEryvS9ejXy2jJzswxUDzxqL2/KCB0WkUIgIPJB24T0KZL?= =?us-ascii?q?vvEGdU7VYtZoX56EwjA7dGvbrECrvLC0Q1rjNtlKj3ARAE7g17BuXJGKFym4?= =?us-ascii?q?TPnQfGuLgD4L90ZVDff6QknKUSo7CYZH1D6SCp9qt4UcSvQWtnGm3Yb6Rw4K?= =?us-ascii?q?Fe80b0xrjdWXbA3JWSL+L6Gvdx2jx3CBLW/3X6UO7uPqF9IM8vfqHZ8CauBw?= =?us-ascii?q?jRI6rUJxk9s4SQhcYDhb0/dHpUQMIKkHYUQDCPguR9JrQEA8VNauvB0UUXdA?= =?us-ascii?q?H8M0f2zRN/Fqk5cE/wDnB4WGH/7KFsS278noe30lhAKmM3E3I10IZ5LOCiFp?= =?us-ascii?q?0qCdCQucG5egw/DKLOVylZQhzsAS+l4QozgwdrG7awD6psw9SBvkbwmZTcZX?= =?us-ascii?q?8YLpV+9f2UpIzm4/85Gw4TFXznJf16CRTwGDLS5AKNsBAm5yq32wN6OQqx0G?= =?us-ascii?q?AvGoCeupwQCWjMOh/H7PNzq6d1WNKQEQFtIRcwj4TXb5wyS6itPDOpvxmlwU?= =?us-ascii?q?oY8Wpvl8rt5ritjXcJU7Mi34tItw9yYXtGV37Dn7VlNSrjmq4jBoWW4fV+ZX?= =?us-ascii?q?rmZrCWTxapVjzLYnQqvAN2kDvuuvxAHdBj6+xKy1ewEt6k+wCmglMQt39MaW?= =?us-ascii?q?oAsvuvBT6F/VPILleGKxfsf2/tMdQTJCfKXcMSJWNM7sMB2P+3AdB21/kaas?= =?us-ascii?q?tAa0bTLjrX5Vi/QaQVOeRQDx/g0Os9pyE2F3mz3ZTcCyDdgl7Cv2qU7bHXcJ?= =?us-ascii?q?atd5DxA+eAHtTP8rwnuHnp7Fn6DYxeogrM+jzlVqUYQwaaCuPTFQKTtHUpGy?= =?us-ascii?q?ZlS+3uW3OhZUQLGU2CJwii7Lq0Osob7hTeSgZbxWNTEeV5r4Lo9Q0R0Uy4D/?= =?us-ascii?q?m/zDmTDgf6iFx0J3xGZz5RmMBghPd/he4KADgv6A8OjrJJ9nAyRv0NLL3bR8?= =?us-ascii?q?X2ui0gSgsV9AvEANjT1SI+3oO+JZDbCDCdcWNdARlxPV2QiGWQM7kI3fCAFK?= =?us-ascii?q?hrK3PGOiX+iAWRORHHqqy1SBpz4KsGsfB7ptWxMSlmKtedu3gw+EvKi/HQZE?= =?us-ascii?q?BJPSIHNYFnjDQYnnpRAFs7rc0NyP77gkUKnsGyCWFTaa7c7w1UegfPxsDLQV?= =?us-ascii?q?AlzXoI3oSN7QOIjOOTfogzkQQrZ5dXXRj6Fyd8kVGuCn1jn+PZof6vBD9jYj?= =?us-ascii?q?1nUU1KxbLM810ZVLwtBpLzsdscyba2p07j+nEkTpdltB3j8zaCrt93wiHezv?= =?us-ascii?q?g/m55qJtB0utWWTocFp9k14lNhLgwVueOavcMr9pxjkexR1mwyHGdkLZNLEz?= =?us-ascii?q?sV2K13JTGuDj5/06yqV4Eb4Cr9Yg6ozT4ShPvn77ZP2iSaADEWa7cUMp7cOH?= =?us-ascii?q?Hs5NmCXZXWMKf7rpHvXvKVeGGVku/1r8IznABs03cZLM2svh1b+bjOF+MLCD?= =?us-ascii?q?YMFqoaA+rh7RP8cKcaUSqeKvp+7OMPdupuRP3tCgSVi0G4f9Aa9bac6ECEYT?= =?us-ascii?q?5C0OeTT2cAyFFpL2jIdu3/p7JLOuySJT3KTQLylgkK3f0N57Di4UmvedgnXH?= =?us-ascii?q?vDnvdYjdjTwqD0lnXVW2N2Ij7wNlfP336x64WFci7UbtMuNypjwpwB++8y36?= =?us-ascii?q?OkeKeyzIv14FYnMfT8tB8Smc6+rUDyxxmA/Otmlg576h+dPZ1NsNbzB+8GHG?= =?us-ascii?q?PB2Vt2yFSh2AojmYx/iBsfiyBGg9uz2Xs1FYwA+lU/7R/NCasZV3kvxTfRKm?= =?us-ascii?q?FEsabnUFuz3sh68ERplrDTFyqByXxSkVPefhv0Bm/h2Q41Qn+Z/RsDHxmy2b?= =?us-ascii?q?tvZAGxE7WqVZQdxM2LNuZ5uEosr+MDDCcp0cw4g41axAXroxIfaglG0ObVbu?= =?us-ascii?q?2iw3xBWoAj0/qItNWWVVjgeWnUBKVpPApxPJfJAZuYQnKlv39QRS2BMb3GIB?= =?us-ascii?q?Kwrybzu7FflCpMI743FOEbD/3D/+Rrpb32k6N+leSblyrlgbaIvN45oizO+H?= =?us-ascii?q?Bev4LXuDfLmagrA6g=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="80606575" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bsOrZl5FrxHA41IIjT9FXCME7fl1LJPqiOrTVYHAlt6qiKirhwCGxaynIlYU9KlX17sAxBUS7H7buglu+GKgHCp3Lgmm28X3HWujloXyb12XbVWYoCWnuIM9xcQbUh2bs9aDbLE1396YMXspvj0cvBXVowwn8fCWJxCLLIPl+ZA4lod2E3wr9eINNDzNTNNatAOL3nVz7ZQxRi+CCbJjSDmKdHFCeS5uAufaSVxfr5/0zzRR3A9pDasnSbOqzFOJ856X0rZnGyPlJBvAIl3W8i1CrCw993kyfOZycA/RbQ6UJ0w/YZmWY+P7oX8e2UhiPnjWfdTuvT9wDmO5WTTZaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R54Hv3p1A2LG97ycmJp3uzkpF4FYTACcAPHpo/K48iA=; b=aM8KThLDGDLVAaD7EhO8pR9NPQajbThbU7WAP7BC5mD+98pbnBmSNigLOaUpjUPBs3d/gDC9UGBrxYIjtyx2vbSfc0y61frfxrwOzTI1WIrg241yV5WiHaAi14iEIJK4r1gVVZWztlwNs5nYOniXVFgOEpY7z7NfRNTj5qWO04qNsZNQzd/mbjlHCk9TORJ4BoIKYkcVj4RC1ftERVm4+W2sXoXPAG86F4/kVXMmyNh5mcxnm68hNVDmODaHtpDaggc349hjgVmBm8VM2STRjehPtHSVjQmYfV164/xJagW9/rHoQg+vjA78QpEji7xe/2/HmTodINJvyaa/DLsuSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R54Hv3p1A2LG97ycmJp3uzkpF4FYTACcAPHpo/K48iA=; b=sbbJINuoYObywQ7asstWMRleQSGh8G6IcOVUsu1NpF/LTXrgruvqz1BtF07sIvpbG4UqdWUGNAQnBSeqAWe5dz8urTapDPfnALYApJ0szbHp5zFcJAy6tXGeoqjK4+JEWoqEFXcebypP9LBwfKwX85t2tCWPEUYwqjVBiD04LTk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 15 Sep 2022 17:43:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Message-ID: References: <74fcfb7c-a699-03d5-c8aa-5f654515c566@suse.com> <0ccfe125-9455-8f40-430e-cfa1347b0aed@suse.com> <52cb5a00-83fb-8a35-4670-8dde87585f9d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52cb5a00-83fb-8a35-4670-8dde87585f9d@suse.com> X-ClientProxiedBy: BN8PR12CA0005.namprd12.prod.outlook.com (2603:10b6:408:60::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|PH0PR03MB5912:EE_ X-MS-Office365-Filtering-Correlation-Id: 62140324-86b8-484b-1b13-08da97310627 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mUllo7kJMqgaoudCfPkQ6PE3mzO26F/jJvE7xcinyl7NmJP7Eg72O87qpflyOo4xKPaCPwH3QOWAloudVhJ7T8Pu+HtnG75i103O/N1/ZwqSNjqo2e287ZRc0B2ojirle5OEUVxAyHB5TZSb5eMvrLxM7eMQVfHPzPV45UQ6OcGd1iYCSMsV64n8OaQubPreuBNvO6QPJiqPnFwtz/skmm7nRHbHhqlaqVPge41dOZrItJN2CmRTIP2eNfSnPSV4Uyx9ql/T5neOAZof5qXJeFGgfWD/z2Jj4OVAZh0pXtlAnwMsduAQtItjd2TprGI6+uYe+JVdRQBAx9/2zU7S4u1XjxkEeYy8ChWzU7qiWImFxaDC+/9JP09e5MmlLFGij4sBXpyqJHdz0AqXt05SrosGF7f6DLL4eVor8YKGoJB4K/b1Pqc4fUernsk3C1aQ2prj/ZbH+3moHjlS73mozvbON9FSdg0SMdnQl6qLU1bP19cfx9Mf0z4wI29voQPMkGa04Qi866LgiN1UmQu32OPPd4kONm9RrjZNazuS+3JqJHptSSnU/eyckE7/PduOAkUkFY1IwUaaOaIy/3XhSGaQjtO5t5pQmN9w/6Ckt2iEdc94N/COrARJuk0Q1FxCeDOsnTyXOECcPulxRGUgs1KLJDBf5wPM+2hqS9s3z6VF2RG40/KdK/hllANUNITqTyZYOtY6hzipDXyoG8Ep6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(451199015)(41300700001)(6486002)(6666004)(478600001)(53546011)(6506007)(186003)(83380400001)(26005)(9686003)(6512007)(2906002)(316002)(54906003)(6916009)(8936002)(4326008)(66556008)(8676002)(66946007)(5660300002)(66476007)(86362001)(38100700002)(85182001)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym9RRHMxdkJ1SWZWQ1E4SlBpL0lFUFRtWGJPcWYzYTNFa3cvZWUxZlJ2djc1?= =?utf-8?B?M2NuME9Ia3NrWmJoMGVQblNXdW9lZS9QaEVVT0tFRlg1TlpTU0k3MVloNHBi?= =?utf-8?B?ZkpESXU3ejc4UWljZkxpNExxbTY3MmIrVk0vVUZiUlZ2bWlCeCt1WjQzWWRS?= =?utf-8?B?RHYrTG5VaFJxa1Y1Yk9pb3JaR2d1dEgzVmFxZGx6RC9FQXFmazRRT1FJUk53?= =?utf-8?B?Vks2SkFrQ1NNdWJUcDFWUUFKT3BGWW83d3lKc3AwcUdscUlQMG0rZEJLdHVN?= =?utf-8?B?SmRXQ3lkazZ1cU94Tkl1bFB1R2lSWTZMbk00QmtaaWFYakJ4WXUzNnN2SGtQ?= =?utf-8?B?alFUaERsN0NBd1NJZnhKRmNjd2x1WGpXUnVPbm5zbTM2SlI3elo0TzNoVTRx?= =?utf-8?B?N25Uc0R5NWE4UklXTmxCQkZCamUyQjRPbVp5NHB6Nnd5R0k3QjMwUnFINDd4?= =?utf-8?B?amRITi92YlBISkpLNER6aVFKQ1dyRzZPU044U0tVakN6NWFQUXFiQjZ1bFN4?= =?utf-8?B?U2I1c3k5MTVoTWZ6czhOa0xLS1JnM3U2bm8vdXo5YTZ0aW13U0FRbzlhQWM1?= =?utf-8?B?dVVnRU9jOHZib1RuTjJERnJWUDdYUndya3l4R1BicXlmTWVrc2s3b3pQNCtq?= =?utf-8?B?ZzdVQnpjbDNMK3QxWXNQNEh1MHlSTXd1YVN6bGJCNDVLNzNWVHN4Mm43cUpR?= =?utf-8?B?dXBGNFQ0bi81Qi9wSG5jdGVOMkFnZnlTeEFnekxFVEpBaXdTREZNNEZqRjAr?= =?utf-8?B?ZmRBQXpmRTZyWG5hYkVDRkNwZnE1ek8rRVRkM00vU0JyWHlhR2hhYytrQ0R3?= =?utf-8?B?TmhnK0M0ZS9LY3EwRUxGQjlqS25QTVRnRWNFZGk3ZnBUYk9CYUVkbzVtRWJP?= =?utf-8?B?OTVxVzhabWU3Q3dZNnRoaHhjZ213QkFQdG9uM2NRcE9xNytnOHBCUXlwNmc0?= =?utf-8?B?WEdlL1luOHZ6MGdKYWlrUFNYTEs1NStGTkN1NmVhamNNV1grQUUwVXhtOXln?= =?utf-8?B?WXU4RzVSTFp5aS9CRk5sMURnODVwbXEyc2NkNm5sZDM4VWZPSHpKa253dkI4?= =?utf-8?B?OHpkY21HQ0pJTllkOGtld1AxOVdmTDlJZWVtRFBqVnpCektqdEwraGRDRlYw?= =?utf-8?B?ZDd2ckQ2d3gzNFQ2VmlValo5NkNVMlFkUVl3TXF0RXRlRm1ob3RwS3U5am1H?= =?utf-8?B?VGxqRW4za052R0NEeWNIUW96TGlDU2t0dXhQOFFFdW0xMytsalRUbXVxNEZE?= =?utf-8?B?aEsyRkNNbUtEWE1wUzBRcnZYSEFEbmVyQ0p6Ly96cG9keUtYR202Q2hzVHBP?= =?utf-8?B?QW9FUmE1UHFaS1FkOWRaaWNXblpOcDE5eTQ3Y3c2UkhPOFV4OGpTWUR2UVc1?= =?utf-8?B?azZoWHV4U1JXNG55WTllMkNYejdYNTB4NzU4M3ViUmpjM21VVHJqczhTU0xk?= =?utf-8?B?RlNBbmxaQ0ZPMHpneDFnZzEwc1hNNHBuNjlGdE1valJEOVFPZmVQVEozU3p2?= =?utf-8?B?c2ZHb0hweWhRTU1mcWZFbzhFYy9FUDFIZGR0cFdyV0crUkw2Ukdnb0kvL09v?= =?utf-8?B?a2pJTXU5SlZsVnRza1VuTTdrcVZ6MVoxbC9nbSt0bHhqWkRERndjdjFGaWps?= =?utf-8?B?M0ExZFQrb1F1c25XVXJNWlhUd1FrclJmeXpNU0htY1phRnYvbDl6MjI5Wmgw?= =?utf-8?B?TEUzL1A3dVY4emhRRGRGaTRJeUNObkhOam9rY3R5UlJGY1pqekQrcWhybEJQ?= =?utf-8?B?NnBnNGJXOUdnSEZoQXZ0VXE0YmtXbk5NTUFKcSs0QXNvTlRJMWdTRjF4eitw?= =?utf-8?B?YWYwcC8rc0lxdWZnRHQwNjdpeHBpTG5sekhiaHdtT2hlSDluYlUxNzdLcUxY?= =?utf-8?B?VWEydGM1VWNYdXdMNCtzNHN3d1NlWXFHbXZZZGhNc2lxeXd5aTNtSkh1aG9V?= =?utf-8?B?YUVXMURNQk03WElJdlh0NlBVUTVlSWoxUElrYm1BR1FyZzYrY25tUW9CMjJC?= =?utf-8?B?T3Y0c1MxeDloUWpZL2RiWlVQK3hZVzhHWFJ6a2VRYkRkRnVTVlRDckpKZGRa?= =?utf-8?B?OWk3R2Y1K2JCb0pBaGEvSGUvbnZoMmphdEZYcXU2WWpIMEVwOW1UYlRwVmdM?= =?utf-8?B?b1VtNFlPLzFuU1YvMklxMlNIZDcxdzV5aE9TVWZ3T095QWRiTzJqR1djbG14?= =?utf-8?B?c0E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62140324-86b8-484b-1b13-08da97310627 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 15:43:24.1576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /vgqXEAgd5g9byjxwhnaYeyOEcvvhNP89xCLF5tywrOJotAetblOB2hSTjbbxjf6dGZZ5IgjRb6eP4SiGIoPjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5912 On Thu, Sep 15, 2022 at 10:01:11AM +0200, Jan Beulich wrote: > On 14.09.2022 16:23, Roger Pau Monné wrote: > > On Wed, Sep 14, 2022 at 12:13:49PM +0200, Jan Beulich wrote: > >> On 14.09.2022 11:13, Roger Pau Monné wrote: > >>> On Wed, Sep 14, 2022 at 10:31:34AM +0200, Jan Beulich wrote: > >>>> On 14.09.2022 10:14, Jan Beulich wrote: > >>>>> On 13.09.2022 16:50, Roger Pau Monné wrote: > >>>>>> On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote: > >>>>>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering > >>>>>>> the consistency check in check_lock() for the p2m lock. To do so in > >>>>>>> spurious_interrupt() requires adding reentrancy protection / handling > >>>>>>> there. > >>>>>> > >>>>>> There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will > >>>>>> trigger when trying to acquire the p2m lock from spurious_interrupt() > >>>>>> context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock -> > >>>>>> percpu_write_lock(). > >>>>> > >>>>> s/will/may/ since spurious_interrupt() doesn't itself use irq_enter(), > >>> > >>> do_IRQ() does call irq_enter(), and that's the caller of > >>> spurious_interrupt() AFAICT. > >> > >> Hmm, you're right. I was mislead by smp_call_function_interrupt() > >> explicitly using irq_{enter,exit}(). I guess that should have been > >> removed in b57458c1d02b ("x86: All vectored interrupts go through > >> do_IRQ()"). I guess I need to either open-code the variant of in_irq() > >> I'd need, or (perhaps better for overall state) explicitly irq_exit() > >> before the check and irq_enter() after the call. Thoughts? > > > > Well, it's ugly but it's likely the easier way to get this working. > > Just to clarify - the first of the options I did name is (of course) not > viable: If we open-coded a local_irq_count() == 1 check here, the > assertion you named would still trigger. Oh yes, sorry, I was referring to calling irq_{exit,enter}() around the show_hvm_stack() call. I'm slightly worried that this could cause errors with reentrancy in case we get further interrupts, or even and NMI. Mutating the environment to make it suitable for what the function expects seems troublesome in case we get any other interrupts or exceptions that rely on the state being correct. But again I cannot see a good way to sort this out short of introducing an unlocked p2m walker (and related accessors) to use under this conditions. I haven't looked myself, but I would expect this to be a non-trivial amount of work. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 15 15:47:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 15:47:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407572.650115 (Exim 4.92) (envelope-from ) id 1oYr5n-0001a5-4Z; Thu, 15 Sep 2022 15:47:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407572.650115; Thu, 15 Sep 2022 15:47:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYr5n-0001Zy-1H; Thu, 15 Sep 2022 15:47:55 +0000 Received: by outflank-mailman (input) for mailman id 407572; Thu, 15 Sep 2022 15:47:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYr5l-0001Zs-Vs for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 15:47:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c07db74d-350d-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 17:47:52 +0200 (CEST) Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Sep 2022 11:47:48 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO1PR03MB5681.namprd03.prod.outlook.com (2603:10b6:303:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 15:47:46 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Thu, 15 Sep 2022 15:47:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c07db74d-350d-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663256872; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/17yFRdhIG+5VyiAdO5sFFQPWMl/QM3Xl2shr23pc84=; b=JJGwrGWCOMnTurWDm4WFE/7kCEF0gBfJe4JkB/14iFC4GnU6syUd11Pe 9XluKQPcpHz0LTTq82COsJ+VmwZTSW3torU4Kx9GqxHTDaWhaOYBSDhuC mmgm2vX82+c7aHGi9x7mU/qilF3ilyLvy18ez36m98qK3Z1zggNlItkZh Y=; X-IronPort-RemoteIP: 104.47.51.47 X-IronPort-MID: 80606967 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A0nfM+6i8YJdeaEpnh2QWwUn5X17brhtdQwwMu?= =?us-ascii?q?6ucuGbil+go9fh2pWK5dtnrn2Wzm5RB0dnFy2UPe8JSwMZk4PhseMG38tLF6?= =?us-ascii?q?db8exdWDO4iNIRjo6Ip8j288T9qj+jSb7iFUX8xBe6QbDmqnkbE5zeiAaCdE?= =?us-ascii?q?SCjgQooSZ/4RdWtAdYzcnPWCx0xAKi4JjIBDGU+daWVdmdCcmZclXHwehAvd?= =?us-ascii?q?LOoSbUcpXqY6aVcTnruhrYNXqvEOor7CAOyjLwbbhnMxED0CH1XBGHBfT3EO?= =?us-ascii?q?WRPVXL9ebeTf79uxZpBLRb4zU0v7a5QtxFZ4olJuajeKyQ3d75YABFBt4hng?= =?us-ascii?q?gzUl/ksBLv7//9Qs8h4ntToSDw6stBWQ7NNOgWbOabCQ3v5XHSeFS6QdyNMt?= =?us-ascii?q?p3nNVNshaRd6OpUedA9BQwrTTYcLWkWEwJGS8Uv4PDPRGQ+yN4qgWjS/ynQs?= =?us-ascii?q?SrIv+j7+3GDJyUy5mRkYvLm0POsKODCCZjIoU1Tpb9884eWOntUrzA9vuK9P?= =?us-ascii?q?AUBItqE/dk3hsuitEQQQAaVtshhp7J+72yF9mtm0WFchJkMR8/jAsDhtM3jX?= =?us-ascii?q?cGSrLYJxlNs6CQRcLBIRmLV092JCeLMXg0pJjm46B5Jr1oN8XPCu3z3BE0r0?= =?us-ascii?q?z9j8e9ZtUef4swRcIgSXPIIKNsuZg5I5DDsrbj9IYY6+S/BjOj1GBYcXFjmH?= =?us-ascii?q?CBNEwsTlYN8uCmMwPO++tTtUx8bUs61aoEhel0eHrjVvATCbkYNPRFyGO75W?= =?us-ascii?q?gKwexhEhgxNpXHwixx0YEeSkYkJjFpD5RBsrdbHVRjnnQCQksltEwvcZmy2T?= =?us-ascii?q?wveYGUKHyVFaDEeRaqluQfJZsH+7j32D9aZ7CpEJx9+5ph4gLs+KlbqXeNI+?= =?us-ascii?q?vhxIHD2VdTRB2XW9ASFs6i34u+hdt9oz4D7ooR7NH4r0SaGIBEES6W1clTX3?= =?us-ascii?q?7EJ/7RP6G2So42+FKHdNrs0UAgoZmLqG9sZAoXM9vZJd3KxTQ74oqgPiFqBG?= =?us-ascii?q?mEOGDmSM5Wj2H0NBorkgb1sUI/E2iNkYo5PLL4Gl89TPCbbLlWrLB84JZwEm?= =?us-ascii?q?8LLz/e2gDkP+UBifZm0/CkJtgGAps8c66GYF26vDtCF3bya+zk0JJzvk1fnj?= =?us-ascii?q?dOOWmvQgwPfbUsrMxpj8ZWlxLnDDC3bcbHP3hznpSFz5+C8dzWPh0RaFtzTd?= =?us-ascii?q?1uQyLFyjiSj2uphxOmeRM8f0+dbxWOhof+7BfnHjlsUMXKVVHARvOzo61jA0?= =?us-ascii?q?RuOn2C4QCzeEK7/r8tiS73dIb62kbBaikIhV2Xz6sqQLVPDBwM81A4LOGzDi?= =?us-ascii?q?yUPtWIBr0XwMDW9BvcCAHG8AXs8Hh9p6wv6I+lddLOGWmscHKNcSql3TWgMK?= =?us-ascii?q?9fKOtbqAL8x4njfhOj/7ENL/wKNXV1zmtmOMpnpahLARfcYCpkYywuIu/ELm?= =?us-ascii?q?CfxvhU8WZ1+BcNLYqSIn9FPBFJNnYFtlLwsDmHDDS6Z5tuEt9naDgz6D2SMF?= =?us-ascii?q?f4xUTD8fc9wrR/YySoZUsZYrMYp39UGR8YwEA6lBGbyRdMRjNhnT2qCqAHTM?= =?us-ascii?q?6umJiommSIeJvfwAHc5poLKgjm/LAcDtVfvbRWBt4L/X/O2mwD87OX7dlud6?= =?us-ascii?q?RuQnAS1Svx35XiC5aW/bp8Hp5tsjQVnPd7v18ytozcBhU6PD4uUqTVYhkrNV?= =?us-ascii?q?6olyQkSFTKoAPcf8QCX/48M5XmvJpAlOb7a3LPWn4b6v4nJvb3lQouspa7e1?= =?us-ascii?q?w3aT6EUwlCSr0u7uaff94iO7mXklA4CJ1qqmCQ9pwW6NDy9AKsla3pyRTnca?= =?us-ascii?q?ZAwZ7wLBUd7fiAaA0/BC/AfU9dUfT7q00BTDAkiJ3Eg4FT4rwGOgZmm9VflU?= =?us-ascii?q?9iaNrNgSxqqniWT2PFjc2mcQNrQIDyY0DXHrkHdcioYJYQlDeuvt0bjbcLXw?= =?us-ascii?q?3HKw8Z6J1vJevInH9dfPJ3a9Ri9X5/pSNWLi7mKFJEW+26oWVjhoBvShk6wW?= =?us-ascii?q?0tQW0xwuvsUIPCJLMrUayT7EylpFbafhF5T/PIAvsphCvQZ1Wv3HvZbFWj6E?= =?us-ascii?q?XKiKqmTKF8L6OZp6KeXYID5vBY96E7vF88LRQtp5vmQJ8f/7JBaKZh4s6MRV?= =?us-ascii?q?JFiAHe4KSxk4Qs0oP03SEbsomMH/pM1/pmt2niwmVNIcWUpf7ZQiZJDKWrGi?= =?us-ascii?q?M/C9QLtfes0IPMA4FyrNmcY9Sh0bnZ0fCvgfKagRWCJzClNkw/U92YFtr+k0?= =?us-ascii?q?wLci05bpCAYhh/LvpYP1Jn0SW6chMlqyFrA5LlMRACv0pSBjBJF467yO3y1c?= =?us-ascii?q?9jUAYigpOjR2SIs5fw5lRF8JKrZPqR2D18sknvyRpEra1SqYMVw/lV508YUP?= =?us-ascii?q?3OEaSjEIqdSWxlegWcphBghS3yYMRXk51d2UMm4oi0s64upqsin7qPYmzP75?= =?us-ascii?q?cACYdpO0gk/VvF+d9dOAsvoI4a/hG/+umANntJBTALSfg/Hh0l8SKmb5zZZ1?= =?us-ascii?q?SC1O6Mn4AJN1wWANm8=3D?= X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="80606967" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPO/zGa94WSlqPMw32Alc1Ga5bd85pxzDJ0fB065L+vPGqQqIhaz7fi2r0SfVgVxJtNOxigKhlH98SLk8fVRqgON7k0p+mgH8iDiBOasEHaIGLnzoskPuKjzU/sVNx8fl1eWInw2i5yP5GBR/1AQvy4gLZ4nxMw5wSIEUgctdpub1DuscoPdaEnubanKlQiO5H8HdGKaVU5BASy1jqhsTssj0zbKg39rrACUyMlgrbux/qKM7WfMB5PkAz5sgoRsDSNcscQqLw1UnUWZ71+qhOszZsAHk7fvam6mvx4Mm6w2ZpzFKPogb5WPKs0pfkgAPXzqY2Xt2BlFdpWj3No9Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FH9VcU4cbLlRks4FhhET0OEZS/olN/hDHR6lQEb4pQQ=; b=TqGOyDtWu8l2IfxrYiQT9yTsMpqb2DrwoYhUl4L+sMW1VSJ8t+aUnNPEmDK8J5nqvBvdYqgDv8UiJmk6sevFgGAHC3pRKI6SZNeBx4ADVSQLWC/UFam2dtCGXz0JTlNMi9Dx0tcLYzvI4jOb2/UuIhhm7Q6o4f73qcvncBL+8z+2YRwB5EKxdeVpNPNgbpn9nbftMfQMSDEukqbnsQJUqcbx5CIJCBDJ8qQBMpNtSuPu+32pIqSH8zWQLZGGyUyssEfnDEUGmmPhtqsTyHhVZPVrWPyLy1OCnLCHsxBk9scrqe6Nqedd0hyI+Dl7EcsFD8fR+1UsAW/OSSdE7gz72g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FH9VcU4cbLlRks4FhhET0OEZS/olN/hDHR6lQEb4pQQ=; b=eSSnFY95+3541qVigaX4xKRI9zChzyytPvkd9q3HjcUXmc1iaGcPcGeYR7IUco1EkQ/1RvoOUhdz31d0XngKjdFLQ3C86GNfrhqpvwG4Ub83yLuA1BfAsZCTX8oqiTBYhhFs7Cvi2QdIAQiq+Q3x6nNfeuVDKuaiY8fMsWyG8vk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 15 Sep 2022 17:47:41 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Anthony PERARD , Ian Jackson Cc: xen-devel@lists.xenproject.org, Julien Grall Subject: Re: [PATCH] libvirt: disable Werror for non-libvirt flights Message-ID: References: <20220913100328.27771-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|CO1PR03MB5681:EE_ X-MS-Office365-Filtering-Correlation-Id: 84e08921-4fe3-4092-3fe4-08da9731a219 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CgEb0eQc4rXiNje1Kxkd2YgBvvGNepN3DUFcLWpwjutSK1PWOQLBwxhw3LJ+J15wP3F46P4Kvdq0HI5tVEs/F/z0N2Wrjyd/b2vK+Lb41tJyUvVcfF6rodnjNAG7eaaXoB9ZpSv6TQ0kTmkQsoC1aa9LESGVVv7+MeYclT7PXaWbARa7oujr1tpXZOdwM+8dHcxAzKS0aC1nCbH5/jY017VI7qui7DLrw5QjGePVfTDBYI/OG8JkSXJMoya3q1iHQdveu3GqXsTUVVj3gtC9qEHb6AkSy5ImEoDXwHPfVdKrQHS12+oOWvyrVUMgMCZDjDTfwxG1NplWilYgepdIndlfK58zFUXdP5hEAz2CChyK2V8ema+sgC3zpvbll3zrinitL7QxLbG5vufp/qsPYFdvd56oLNZg4C66xySu6A+o5fUZkR+BI2i9UPsdd61iIRrzhI2CWKd3HDzv7AXs1A5Q1N5TFfGupsl+9XyW4tWjFtRPCYPK5exy0/M0BB9gP2E3chDyq9zZ4OfITksDB61y5LicXfCgTaTxAtxLjHK49/bYCli3VcNH6cGqqCj2i6QzmP60YMsW+njLxro/uCGKEsDNe8n4AonjWrIHYhppU/O1d5+4mpDAFZr6Q19rFt3wR5klUVqv4vL9R14N7PbMfA+TzQMcBLugj6Zz85UoXrZdqeC9rXYj3K1t/5REU2D247MFPsk8Q4VcKChbQSH/qKCgZ4rLXH/kkfVYSD9Lf5XbVTcln99Qs0/K9cwo X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199015)(316002)(8676002)(38100700002)(82960400001)(5660300002)(86362001)(4326008)(66946007)(66556008)(66476007)(8936002)(2906002)(85182001)(41300700001)(186003)(9686003)(966005)(478600001)(6506007)(26005)(6512007)(6486002)(6666004)(110136005)(66899012)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkNSS3A5SnJob1M5VUtsNHRWZ1Ywd0dkNlA1dkwyQjgrMWN3dE9tN1psRHZu?= =?utf-8?B?bVJwZjJGV2VxOWJBRm1uL1A1QjlLTDJyanJPdmFoK3I3QzFGZ0loaU9qQTBl?= =?utf-8?B?bXJmVGVRS05VQXpsanlRNUthOWErN3ozbjJhaEhQNDVuZGRkWURzSUNJc0dj?= =?utf-8?B?MUl1enBTYVdKOHAxbWV3azUrdEF0ejBPM0dCeGd5ckhUUHFLdDdIMS95c1hF?= =?utf-8?B?L25FcmJLUXNpZnI5YWliQmR3SllJLzdqNENBK2VRMTRzUld0eXNVNWxKZnFv?= =?utf-8?B?VVJLSitYWjJPVHBWUTlZL294dFdrL3VLdWgrUFoyK052UDk1RUtXdnRwaTcz?= =?utf-8?B?WmRWZ0lYOThyaU9yZi81OWpuL3JjUkZTLzk0UVFuaWlHQTJoL281ZVF0K3Zu?= =?utf-8?B?NnpHQlNRRDM5OVRqVWhrUlQyRDlIRXpVcEI4ZXBHek1lMlh4eGlIQloxbTZQ?= =?utf-8?B?N0o5c29BUkEyempyKzhXMGE4NWpiNEdic0NZR0dhc0x0SHhPQnhHbCtVeHdG?= =?utf-8?B?K1ExY3dwaHNwOGd3VUpBT0pDbDNHU1dxazh5SFF0Z0RtbVpLeEF3T2k3cTF0?= =?utf-8?B?a1ozcytCdDd2VjRmb0QzTHRBNGdhYUhNRmJnOUhVQ1Y0RW8vOVdiTlR2OURi?= =?utf-8?B?MFpodTdHZWlhZElnQmlXRk12dHRpM1E5UVR6VWJHRnIrZnhjNVMyR2YwcERZ?= =?utf-8?B?Vi9QVmxoRkV2UTJiS21RMUxXek5ZWjBzcnp2alowM2JNUjRUMTRuU25Xd25X?= =?utf-8?B?U0tkcERFeE9GYU50Q2VjRTNQZ2VUWUQ3WXhrMDE0eGx1MFBXZVdzYm5BYTdF?= =?utf-8?B?MnZIWGdSZ1hDdm15RHB2UXFiMmczOXVRMDhCUldzcmVOSFRmK1diU3BaeGht?= =?utf-8?B?dkRvYmEyWlRWNDk3UjlCdVF5dks5UTFZaU1ob0lrV1dSNG1NUkFwUGc5SGV0?= =?utf-8?B?QVRTUDlYWjYrdGJGZ3BrSWJzVytJU1BmYmxFTGlBZS9leEhlVmg4NjNCT1R1?= =?utf-8?B?a2VlZGU5c2NwSHNpUnRvem5MTXplVnBPcXFiSnRPTGE0VDJGUXBlMXdjME5y?= =?utf-8?B?Q01tWTZvOHRROTZ2RXA3M082Y2ljZ0dQVDZlQUtHV2FpT05BcXhwV0FPbG5x?= =?utf-8?B?T3lNRnJEYTkwM1d1bUtRa2czQkszZDN4RzRJL28zNGRZQXlSeUZFM05FK1Er?= =?utf-8?B?c25NTjhmbFhuRmw2dWtWUEtzMVhoRHRhTzBnWmxTQ3I1T2VyM3FXSGNBVE1R?= =?utf-8?B?aDRoWENuVUp5WTVEMUlNa2JqTktYZEVldEZmaTZJYis1OHg1dDROK3NwUFEr?= =?utf-8?B?ZFFRR2xncDdRR0lnT1RKbmpWOFRBVGs1S2pudkpQV1JSNHZ2WXdFc2tTOTBM?= =?utf-8?B?elBWZjhlT1RzeS9QdUpJYVNuY28rQWdaWHdQcTVLcE9qNFNzNTM3Y2tyRVBn?= =?utf-8?B?NlYyRHZ6cnBFVC9MMkVSdEhZYWROUndqc0V0RkxmV083WjZiU0hUOHRMLzU0?= =?utf-8?B?WUxIUzRoWlNNajVlNmdEMmhUNW56RmlUWXRqUU9RT0pCVHRVRVEvMTV3Rm90?= =?utf-8?B?WDRIL1RGMmdQUDFDbE9RNmdtc0VUa0xqNFlkbGlwQkRncHRRTjJISlNwbUF5?= =?utf-8?B?UmtEZXIrWWpZZmI1eDJ5azhhUkN3eEZPc1h4SXZXNTZOdXVlNUpKcU9hRzU0?= =?utf-8?B?MkJ4ZFhhSHdjZzhKQm56dlpYbGtMU3NYSXRNV25hc21CemZoZ0tkcHBpeGNk?= =?utf-8?B?dkNaN3B4M0F3eG00UytQREhCNTQzaDZWd2VxNWYrRGF0eWNRUFJVYUZmUkNP?= =?utf-8?B?RVRPVXlqT1puZjE4QnlieGxUS2FCcndDSEFNdlVtZlpMMlRUb2dxbWlIdUlQ?= =?utf-8?B?cHBjSm1lQXhZT3NTRlhVSWNrdFQ5Q29GNnQ3QnJyNllIcFdzQkRvZ2xkODVt?= =?utf-8?B?NDF4b0lrdm1jZmxQelpONk4zY0dDOCsxemhBWDB3eGV4ZXRFTUpINm44Z2lC?= =?utf-8?B?TVJON0lFUHg4SldkdlJ0R2xaellBd0VleElnNnRBcnZTMldGeXl2V1hkS2FP?= =?utf-8?B?ZStURlNacS93czN1UzVjVXhLa0dLS3hVWnc1aG9mZHE3M3k3MkdMN3M1OGxv?= =?utf-8?B?SG9qbWNXM2FQTHN4UFF2RGp6dEZ6QXV6Y0M0WHdMbkxlaEVwMjh2VC9sZ2pR?= =?utf-8?B?MkE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84e08921-4fe3-4092-3fe4-08da9731a219 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 15:47:45.9163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6pnPj95OJa5tIwfdepyleiCDRyg6iCm/184zoF96mqI61ckU702p0B2Yv8PTgnNO9IIwkkurn2na0laVmcdLuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5681 On Thu, Sep 15, 2022 at 03:10:59PM +0100, Anthony PERARD wrote: > On Tue, Sep 13, 2022 at 12:03:28PM +0200, Roger Pau Monne wrote: > > Current usage of Werror=switch-enum by default for libvirt builds out > > of the git tree causes issues when new items are added to libxl public > > API enums if those are used in a switch statement in libvirt code. > > This leads to libvirt build failures for seemingly unrelated libxl > > changes. > > > > In order to prevent those errors from blocking the push gate, disable > > Werror for libvirt builds when not in a libvirt specific flight. > > > > The errors will be reported on the libvirt flight, and block the > > pushes there. So the author of the changes in libxl is still expected > > to send a fix to libvirt code. This is no ideal, but the other option > > is to just disable Werror for all libvirt builds and let libvirt > > developers fix the breakage when they notice it. > > > > runvar differences for a xen-unstable flight are: > > > > --- /dev/fd/63 2022-09-13 09:53:58.044441678 +0000 > > +++ /dev/fd/62 2022-09-13 09:53:58.044441678 +0000 > > @@ -574,6 +574,10 @@ > > test-xtf-amd64-amd64-3 arch amd64 > > test-xtf-amd64-amd64-4 arch amd64 > > test-xtf-amd64-amd64-5 arch amd64 > > +build-amd64-libvirt autogen_options --disable-werror > > +build-arm64-libvirt autogen_options --disable-werror > > +build-armhf-libvirt autogen_options --disable-werror > > +build-i386-libvirt autogen_options --disable-werror > > test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm bios seabios > > test-amd64-amd64-qemuu-nested-amd bios seabios > > test-amd64-amd64-qemuu-nested-intel bios seabios > > @@ -1217,6 +1221,10 @@ > > build-arm64-libvirt make_njobs 1 > > build-armhf-libvirt make_njobs 1 > > build-i386-libvirt make_njobs 1 > > +build-amd64-libvirt meson_options -Dgit_werror=disabled > > +build-arm64-libvirt meson_options -Dgit_werror=disabled > > +build-armhf-libvirt meson_options -Dgit_werror=disabled > > +build-i386-libvirt meson_options -Dgit_werror=disabled > > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true > > test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true > > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_nomigrate true > > For "osstest" flight or "xen-unstable-smoke" flight, we would have the > same difference, right? > > The only branch with no change would be libvirt, right? Indeed, that's the intention. > > > > Signed-off-by: Roger Pau Monné > > --- > > I'm unsure whether we want o disable Werror even for libvirt flights, > > but this seems more conservative. > > > > This does at least unblock the libvirt builds for both the > > xen-unstable and the libvirt flights. > > --- > > Cc: Ian Jackson > > Cc: Anthony PERARD > > Cc: Julien Grall > > --- > > mfi-common | 2 +- > > ts-libvirt-build | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mfi-common b/mfi-common > > index 59e712f4..450229e9 100644 > > --- a/mfi-common > > +++ b/mfi-common > > @@ -459,7 +459,7 @@ create_build_jobs () { > > libvirt_build_runvars='' > > case "$branch" in > > libvirt*) ;; > > - *) libvirt_build_runvars+=" make_njobs=1";; > > + *) libvirt_build_runvars+=" make_njobs=1 meson_options=-Dgit_werror=disabled autogen_options=--disable-werror";; > > For meson, I think '-Dwerror=false' would be enough, instead of the > unusual 'git_werror' configuration. > > But, we might not need to disable all errors, for meson we can have: > -Dc_args='-Wno-error=switch -Wno-error=switch-enum' > > But disabling werror is fine too, as less likely to be an issue later. > > Both 'werror' and 'c_args' seems to be meson built-in options rather > than options implemented for only libvirt. > https://mesonbuild.com/Builtin-options.html > While 'git_werror' is libvirt only. I don't have a strong opinion really, I've used git_werror because that's the first thing that I found in: https://libvirt.org/git/?p=libvirt.git;a=blob;f=meson_options.txt I don't mind using -Dwerror=false if that's considered better. Ian, do you have an opinion? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 15 16:21:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 16:21:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407579.650126 (Exim 4.92) (envelope-from ) id 1oYrbn-0006Vk-Im; Thu, 15 Sep 2022 16:20:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407579.650126; Thu, 15 Sep 2022 16:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrbn-0006Vd-FV; Thu, 15 Sep 2022 16:20:59 +0000 Received: by outflank-mailman (input) for mailman id 407579; Thu, 15 Sep 2022 16:20:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrbm-0006VT-Ju; Thu, 15 Sep 2022 16:20:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrbm-0001l1-Dw; Thu, 15 Sep 2022 16:20:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrbl-00011d-Rt; Thu, 15 Sep 2022 16:20:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYrbl-0007db-QB; Thu, 15 Sep 2022 16:20:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8JO+sGsoU4IIItQrKRXST3LYcv7+JnpdsmPRk2iDbZ4=; b=ukRIt9tx5C0JTNTYwenqqCpQ7/ iIiJiMX0Hwl12etfA4FtBvpmWDZ0oK3RqIkrltGcD0i88zhjQ6NZqCpf0bgkEPzzEh/0aUj/Tkfmt oWneyRUjUwD98P9Rl9y/7sIFBEv61Ct+HSwguU8mES2MPKM2/LBMgGZ/H8xaAbZfgU8w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173207: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Thu, 15 Sep 2022 16:20:57 +0000 flight 173207 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173207/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173197 build-i386-libvirt 6 libvirt-build fail like 173197 build-arm64-libvirt 6 libvirt-build fail like 173197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173197 build-armhf-libvirt 6 libvirt-build fail like 173197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173197 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173207 2022-09-15 05:32:42 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Sep 15 16:21:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 16:21:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407582.650137 (Exim 4.92) (envelope-from ) id 1oYrc3-0006pj-Ur; Thu, 15 Sep 2022 16:21:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407582.650137; Thu, 15 Sep 2022 16:21:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrc3-0006pb-RZ; Thu, 15 Sep 2022 16:21:15 +0000 Received: by outflank-mailman (input) for mailman id 407582; Thu, 15 Sep 2022 16:21:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrc2-0006of-11 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 16:21:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68e5a66d-3512-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 18:21:12 +0200 (CEST) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Sep 2022 12:21:09 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6389.namprd03.prod.outlook.com (2603:10b6:a03:398::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 15 Sep 2022 16:21:07 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%3]) with mapi id 15.20.5612.022; Thu, 15 Sep 2022 16:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68e5a66d-3512-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663258871; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=M3uvTqrHZB00+jjl+XtkjiPzMHJZq1iJsFn31UhsYv4=; b=Z2hYdKHxdMcwBGV2Bu68m+Ed1yPpWYtFR2FbqZXbtZa7I+pN7Sa26qig hyqwdsDpN8O05aeIxIIsumLslVxyasP3/Lnl+PxHKyWgg4FDR2L6OkTSK b32Lg7lO14SQwOgW6IVlZpI32abqrkJZmZVgfRdaOv4NrmTQSiCqqbucT I=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 80611577 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AZZ+mAqwNpQ1/g0g82zF6t4n5zX0xdTA+Zkaqj?= =?us-ascii?q?sTw1w6bGk6iVkaXd+b9/w+7gXlGCIjjn4Zkn4tCpUHvdacnWVnKKJyOAFfyh?= =?us-ascii?q?bJBTsUzFCKAgP0XvQGyBId1knYb0RTAM9uyzXox01n67day8LmuVjlEbsAVw?= =?us-ascii?q?TwiEr03nDoD1zQeJm3phUGQniEQ0neeNZZvYZZ5Kyo0szbGKeOA6qFFebK3m?= =?us-ascii?q?be6WgOUb/yshc8sixhpas4W2egfVBKIpuN+5TuQw2hPklOSQMuEhnRNC7Bx/?= =?us-ascii?q?jvJctqpncBSgkARyMnsTZHvYtqSMZpy9bQmb+HHgu9LLMjMFcahpMN7eDBYI?= =?us-ascii?q?h6G5RfE/lXCGbKJbJYqF8o8dmFGKB9TjAX03uzaQhwrVedko5Lz2IiyeI/Nx?= =?us-ascii?q?XlPXNnaGpkqfL6/tQBIKAd0+RK8iimF1Y7pJqnwVHo/CQTH3wu1enBD9BnxS?= =?us-ascii?q?CzI8jLDYyALvd0xI5xssOzIV7aJPMcI6fir0So9Vt5u0sqcJlf8eMwFqpBwq?= =?us-ascii?q?omy9AhujUK+a1v4HMv8Fv1Eca4xOeRg0Q2UOOyElmbNa+QzQUxpysNaIDBFr?= =?us-ascii?q?QI7vUkI7f0HSjEF4fQHrSO4AdWEd1QjawyK4EdR299udGljXW8X8NqL+BmST?= =?us-ascii?q?3cFzJnYqh5A2D20SocCdCUqcOluoYJ/+HwYWjMfPrt+dUOuTqY2NxF2XDN5u?= =?us-ascii?q?FvpYd3ClQOYY8EuRdFiTjEu64UujK/95SaHK/+xrJiAOuxyUAa14KdkmXhId?= =?us-ascii?q?HVHQ5eH9qW/aoebSRG27BMYbbUOGuqrVyzMpxLc3lw9PELSVGrAVzOM1hDHu?= =?us-ascii?q?u0ZGIjC3+F36AwqCB3B3CLztmveDf2MUwITXuy9fwVYVGqSgpMyyCLk+8UGa?= =?us-ascii?q?9NFyp2iyQLvG1h2iuaojjWVmASdcIH8g5QV2agtH8g8bQAxmMW2nmnFSGBYi?= =?us-ascii?q?ECMwJYbK8pNWOCIPTiKpYVO6yHj+QZ7OMBJ4oQ8iRVdI9zJlB8qjyBsh3Hiu?= =?us-ascii?q?+2RwLdxGI1jCUCA0iVK0b/tIs5J5VT6fwd2wic6972K9vsLwdeIQ7aM7uRAG?= =?us-ascii?q?YEAQgPt+Ilt4F8o81hl779L1tkMyfI848Ia+hQHmPd5Fckz6K5zwB4ioXXMZ?= =?us-ascii?q?rM7gxXURwnv/VQzf9Mdd0VpvEibI/PbTJswfOJCz7dW0ko/xFWatneAHuQBb?= =?us-ascii?q?KbdsGp1EFIyo4WTSooJxUPoR7TP5ZgSRm+yZeoCCrweEt0NARNi+OE2bSQxq?= =?us-ascii?q?IgXr1jCuE5XSDHaOnWVS/yL5x9hnb8sogcW6m+n8yVmTzw0VfM37RXO+wnVk?= =?us-ascii?q?/l6ERk5CptNQfbbJ7wllYuc3OTcmt57Ii14lw1HylBSGQJZmeRikEMepY14P?= =?us-ascii?q?NqZ5PYCtCCeDbuJQrT7u8goXxkQaLi+JeDYKzOubqfZxE9fNXdBa88hULiGY?= =?us-ascii?q?IYKIh0CDwRRio6hm6AukOGYLF28tEFSZMSr0iMDekED9KjhXH6+vs2onc3Mk?= =?us-ascii?q?5/PmSUZH/t8mwoJfHpTn0Nz6ZCt7ir1ETOe33Svp/LtTcSF9zcam1zmJKxt3?= =?us-ascii?q?9kRadP1iz7e69HJ9zede/fd3+y3K9mBL1/2fUax5IrzmoEYNRHmWwYo8WzqR?= =?us-ascii?q?rTeiOf21Q6ozTrs7qgF4VMMWhpl+aSZ6lYpp2EjtZ3DrXwsEVT3tNuu9nLEv?= =?us-ascii?q?e4ZN387D99Yo60d1fXEQp/0BMGkG8E/qxEz7wbDPoY0WEES+LbP9ThBIuXqX?= =?us-ascii?q?y7dc0zw8CSwFBeUHBvoEAlypwu4PPKZEt++I8LNRsCns9JWTgL/eEexbA7JM?= =?us-ascii?q?fmHkQGXdLE0z2FwrWtjqrda/IfzbGj0FIvfHZ7c8LM+Tr3CPBkd4eW0HPwwh?= =?us-ascii?q?hNRNXx04lM3FUXQZQZhKk9njDmdoI6EciMr3IiD/+JpH6MgsyaV0G50FjDhx?= =?us-ascii?q?Inr58TFD3P5uq2VSpFMzssaesArX5IR99LJa+Civjsk/atjLehVEGz5xelm4?= =?us-ascii?q?8JtngtwmsmjHD3Ky+ndphbmbhvQf/nMsKr0mhBSHJAHxi91TminG97QBNRvP?= =?us-ascii?q?32An8krNE/Tw5gxzfEuVn0sg7MC3Aq82fB/gq0mkC3euaLdh4LSZ9MGL665K?= =?us-ascii?q?ud0nvgpZ559NmjScmqbuIskPF0wdMcOONefBmmtcQtZvDS+HreSLAMxLCmtT?= =?us-ascii?q?OKhMxuqo68E15USDVunv0OWh5FI7hq2+fhbdBdFUlymsXcYfSm78bSVbZQyK?= =?us-ascii?q?pmEBpFf4WaBQ7mjtzarmPa7BaZN3UtcU/4CFWfnxb1s6CcnNnMBWcgcVsmJf?= =?us-ascii?q?+AU2enrDad4GY8Lx1HIYeRwjJ2YfA4mEffrm4ZJIK3/gL317oDlLg+myO5d8?= =?us-ascii?q?T+D4cMzjoaXaz8uCms93P/x7E7K1XQWCgpk21CXf3LaGm6dHHw=3D?= X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="80611577" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gmke1tjp9Lmbnu6Nzo7Zoygm+1vkAD1IR7yv/VLI3BKuOzBNo8J+Mn+YBlDbRZuCZWhDxlh8O8DkyURtSjL4XQK9/RGYfULjX3w+ZuoMpXi56pTglBsoaKe+vI0m87TvQ8QsBoQe5ayhSVOU0OKJQ8tLEhHdX6JVD0rlB2ou1n1zhJ/DT1zbGwe/QxkGUnKWoCkc639GHHBRKtlyXexVFQR/SHS2D4j8NVAjP/Uvh/pFYF4l93DSam3LE/x7ld1JLltxDZZtTuIGFlnOSRH6M+nSprdFuEu0KT8hcMpo7P3Kjt3xaSMDAB7MbqmZF5/3LDxbk2P+EKlH1MuiHHTNyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lto9s/xyWOi+R7V7nyNqLtesy9kZQNWDDHhlUjMdX4k=; b=AVHJj1YZFfJgJwjZOk/cfnZdWwJyqlE2CTU5ymYnYKCxDeHHf7dnOjiEwzDodaXWFR31RHOogNrH+auWt1H+6bp/9Lt8Rg+LcE9/DFPSgZkATyHmvh2Tjjeirff/PzXHppnDIoHD4qMl/BPICTp3GNi1R7LafG7lpPSRulxb5XlwFlhpBNGaC4Xz7lEHwTOZ0UHHqGQsNtkf8yDSzyivYu/q5hAUXYojrubTcn1OFYUuO9uLrve81em+0Ydezw/83lso/v3MFY/iydV639Twks+b+ku9kHymv6ZiT7c7P878VxgsOZ4XTseI5rCaifFwcIJlKdyEeAOdnUT6c7yxJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lto9s/xyWOi+R7V7nyNqLtesy9kZQNWDDHhlUjMdX4k=; b=MVcixKmDxBkwZDjZOKgMa2YWTNMUkDO5DiJkfBD8QIGYoyL5nz2nPTuehAHH4+tg4pmlruO7VFddw9fj+gATwCRJ1JiCGPv8y/79rSiuK0TFj/+ryfdJ5TfWUlRvVRg3Dk2ErHOfAoomEMb9kOg2noTig5oGyyXPkcubaFfEAfc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Ian Jackson , Anthony PERARD , Julien Grall Subject: [PATCH v2] libvirt: disable Werror for non-libvirt flights Date: Thu, 15 Sep 2022 18:20:52 +0200 Message-Id: <20220915162052.50522-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|SJ0PR03MB6389:EE_ X-MS-Office365-Filtering-Correlation-Id: ab1f1abe-7a39-450e-888c-08da97364b18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dF0qBUgzH8exLk4h8orbwzN0x4tPB1TOPVEgrl85QeoNXIzXdKwA+9pByPSAZTx4O6RsACcda+KAnn/ms/R6feG445CIvcTFPK/bZ9F5mOQRNQSohAcUsFcGRHvypvrVguXVT50Y80pJZFW/fqptBA3uBsp4Howgs5mdgL8QVcOytnhCtCUTp8LBZmCxuIrbGH3mQ9jEoZxFv9ex7ozAg0On4Ta133Hw32Em/+vUnGvjWazFfcuLd9jelYKVRzJT198aeuL83Lgq0TdmijRaMoXFbWqvLDsk2O54SFVCIYv2q6G2t+qX8EARIAqiyKVYvQzk/Xgc9xr2oUCw9BIM88BfSw6tpNUaRUpjrdApcXe7545Pt+EOXa8VDhREUnlLO+vq9bf4aDo/9EkfvLuyh/9Ha6VOB2F/oHi3KvPGxvnZy2CJAPAemQ0nESI32n6J5Hvzwb2Yqd/Lo/rtlgead3cUC/21LVkkku6l2joUmpnjW0wLlF3Xo4Eea4hW27TFM/Re5fs1+Aw2EzrSDzf8W31MeQsBvvuUPwYY00eLQ+qS3s5UuZLZynr5t2ppQlFO+65zqkFIfWLyiUi08J+9PBn/OFO7A5kxOrHX0LHk6Zt/5PQJbC+C1v8cNlFA2pUAThAaeLwNBx30T5MpDhAdIAuLNS60LeuJaFhltUjjiddeMRNA2tpj0HUywl7xzrO0MsCVYmpCMrxAlhtijqrq9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199015)(6512007)(86362001)(82960400001)(66476007)(2906002)(8676002)(6506007)(1076003)(478600001)(66556008)(54906003)(4326008)(36756003)(316002)(26005)(6486002)(8936002)(66899012)(41300700001)(2616005)(5660300002)(186003)(38100700002)(83380400001)(6666004)(66946007)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGVZa3NRWWdlNklXZVQvbVJkTHhkQ0g5SG1Md1dybzZJT25ScGJFSnJKQ3Vu?= =?utf-8?B?RTR6M2J4SlFIbWZka250QkF1dW9DQlRkb3dBQno2d2pCK2JHNXg0aWYxc05r?= =?utf-8?B?bEdkcWdPeCtVdUFhV2FvMUpFZE00cGNzUTFPWnN3Y1RodkF3OXdYcW9jbysy?= =?utf-8?B?MWFlKzRwUWdFUjM5M3ZoNVdYNENXUnFkYXBocHR5c09jL1FEaTQybFk4Q2hR?= =?utf-8?B?czhKemNZdFJEUFVEZjlxVUpYMEM5MkV4ZkprZHFXcjFPRFkzcmM1Ui9LaUIr?= =?utf-8?B?eWxYSGFwUnhuQTUzY1l1N3RQM1hDUG1RN1FLcHBEeHNhVzFqVFY3Z1Y1TGFJ?= =?utf-8?B?bGw3Q0hCbnU5MTNmRitXcU5xS2lxT1k4U0RBdGE3cm1iNjFuRW04b29DdU92?= =?utf-8?B?ZUprL0N2cnBjRkNQTStXTHhVNkpzaGU3YXloMnVHcVArMS9UN210QSsyNlI4?= =?utf-8?B?TnFRSFhlZXVzeEIrMmtBdmdRcnlVVm9XaldEeEg3alhycXZ6dXRCM0xnWG9t?= =?utf-8?B?RDdDcklSQzFSamNZeUxPcHNiSXZXUGF2K3FuSFV6RDVHRURBUitpM0FOMmw4?= =?utf-8?B?WHcwZVVxcnhWR2FTMmtXWEVQcGhWNVlNeGxLZnBwVmNhWUJVN0VTMEpXMnBU?= =?utf-8?B?Nk15NW0yc2JTbmhQZkRaakkwNXAyY3BuV3kzR3BQeHJJclFzRGdTeUFOVjRJ?= =?utf-8?B?eUJueGova0tuOHV4R2F2aGJjWUN4WUdTMkRJUFB6dXJxWEdtYWdUVDNoTXBS?= =?utf-8?B?aVlUVSsvcGxCM0o3NWViM3dPQUs0OCsrNjFvTXdOZXVwSXNPeTZJWmFFL1U5?= =?utf-8?B?c2FEL3RaUkRHR3ZUNHFDb2JnTWhKbGFqdnR6c1NtSUxiYU90RHZMazl0Y1pS?= =?utf-8?B?V3NiZC9Uc0ZxbmFvR3hMMlViWlJiQUw1SmpUZGROZFRZQVlranFSdFNHYWFH?= =?utf-8?B?dHNlcnB4RDlqTTc1M0h6b211cHpGTjRqY1JZcXlrUlV1ZnZhMUYzV01NMkJ1?= =?utf-8?B?UkRBb1VDbFRuR1FxQ0hIMng1ZzFYQ3ErdnFLUEFmWnhGVVdNL1A3Y3hIcjlw?= =?utf-8?B?MEIreXlEaWJoTDYyWklINmp3NVR5bGlhN3RtdFBaZzdIbW9CSUZHUjlFZDFs?= =?utf-8?B?Z0lnYmY2a1RiTVRiMHFQUkhOK0NjVjBHcEhXc0dMSU9HMEl3NWNwdmJ4T3hF?= =?utf-8?B?VSs3K1V2ekk2S0lhek9tdkpLdVNLZkF6K0xwZUxkdUpGZGpwZ0FWL0h4TXdY?= =?utf-8?B?VzlXVEg5MDg0YkJwSHMrS2U5UnVKRUI5UjFBeC9GTlNQaHRtcDRkdU5yVE53?= =?utf-8?B?QlpET1FmYjdVelY5NDVDRkdGVU10bWJDZFBrSlQzUGZBNlowYnlWQVU2UU1n?= =?utf-8?B?eWxObVlIUmgrUTdxZy9tYlB6NTU3WUhOMHRoOWxWNlR6WXhqSzRyVGtyS1gz?= =?utf-8?B?NkJyei9HcU5pK0ZiL0RoR0tBR0hXZm9xTjI3RHZoYWtYc2lPVk9hcnJnYkhL?= =?utf-8?B?UTFPMVU4aSt3MTVSdWhQUXRJZDNMdGlsVmVwUlltaU43Njh4dDZoZ2UzSVRY?= =?utf-8?B?Zy9BZjIvZy9yY1VuZFVNMnVVZ2NQZGZ6NTh1QUhKOERiM3VMZEJLY3lIMHYv?= =?utf-8?B?QTNrd2ZTaVYwTGM5V3V1ZVdsUDhSS1dSUzVGcjh2RklaaXhhUUhNZ1JaL2FG?= =?utf-8?B?eGtOZFV3VVFEVWwwT3JQYUw4dG5YbXJOU0t1NGFsY254MkdUUzNrTmVlUDIy?= =?utf-8?B?c0tlMG5rMVF1NDdxZ3VPMmhoaUNnOEpHbzhBUEExNHQ4ZlJ5OURlU1VNamk5?= =?utf-8?B?a24zZ25LMVppdUozNnhmRlRKV2ZETkw1M1YzQ25EOStpSTE3bFVKSm5HbVBH?= =?utf-8?B?cCsvZWwyT2dhY2tIVEE4OWsxczhJNW1UM2E4dVloKzNhcHZDQ1NvT3c4T0V3?= =?utf-8?B?cjVrekRaenRGREQ4NFpCSnM0MThJbU1Zd0JUNzhjYlhtdU9MS2hvSFZlWnRD?= =?utf-8?B?Qkh4SHhnb0xmMUFBNXVlUnFkZmVOT05NZGMwdUgwa283bDUzM2JnV2s1WGcw?= =?utf-8?B?ZjF5OTIzWjNlVFVhenVWV2twNUl6bE9DUWo5SFpKYzlteklTeTdMR0xYR2dv?= =?utf-8?B?UFFPZFgwaXI3dEZUK2xhRmNhU1BIWmQyUVZ1V05kV284dG5SWTIrblVyVGM2?= =?utf-8?B?MWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab1f1abe-7a39-450e-888c-08da97364b18 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 16:21:07.3241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2p2AaVbhlY9fqwg3i2T04tJkMcUAAkpHwcgRilGOXJ6tRST8NnqyLcH2yajGv9wsKafRW1Zc0KbXRP7/+Y8tlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6389 Current usage of Werror=switch-enum by default for libvirt builds out of the git tree causes issues when new items are added to libxl public API enums if those are used in a switch statement in libvirt code. This leads to libvirt build failures for seemingly unrelated libxl changes. In order to prevent those errors from blocking the push gate, disable Werror for libvirt builds when not in a libvirt specific flight. The errors will be reported on the libvirt flight, and block the pushes there. So the author of the changes in libxl is still expected to send a fix to libvirt code. This is no ideal, but the other option is to just disable Werror for all libvirt builds and let libvirt developers fix the breakage when they notice it. runvar differences for a xen-unstable flight are: --- /dev/fd/63 2022-09-15 15:57:44.340581730 +0000 +++ /dev/fd/62 2022-09-15 15:57:44.340581730 +0000 @@ -574,6 +574,10 @@ test-xtf-amd64-amd64-3 arch amd64 test-xtf-amd64-amd64-4 arch amd64 test-xtf-amd64-amd64-5 arch amd64 +build-amd64-libvirt autogen_options --disable-werror +build-arm64-libvirt autogen_options --disable-werror +build-armhf-libvirt autogen_options --disable-werror +build-i386-libvirt autogen_options --disable-werror test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm bios seabios test-amd64-amd64-qemuu-nested-amd bios seabios test-amd64-amd64-qemuu-nested-intel bios seabios @@ -1217,6 +1221,10 @@ build-arm64-libvirt make_njobs 1 build-armhf-libvirt make_njobs 1 build-i386-libvirt make_njobs 1 +build-amd64-libvirt meson_options -Dwerror=false +build-arm64-libvirt meson_options -Dwerror=false +build-armhf-libvirt meson_options -Dwerror=false +build-i386-libvirt meson_options -Dwerror=false test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_nomigrate true Signed-off-by: Roger Pau Monné --- Changes since v1: - Use -Dwerror=false instead of -Dgit_werror=disabled --- Cc: Ian Jackson Cc: Anthony PERARD Cc: Julien Grall --- mfi-common | 2 +- ts-libvirt-build | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mfi-common b/mfi-common index 59e712f4..51eb4a9c 100644 --- a/mfi-common +++ b/mfi-common @@ -459,7 +459,7 @@ create_build_jobs () { libvirt_build_runvars='' case "$branch" in libvirt*) ;; - *) libvirt_build_runvars+=" make_njobs=1";; + *) libvirt_build_runvars+=" make_njobs=1 meson_options=-Dwerror=false autogen_options=--disable-werror";; esac job_create_build build-$arch-libvirt build-libvirt \ diff --git a/ts-libvirt-build b/ts-libvirt-build index 16b45cfd..e4faa1d7 100755 --- a/ts-libvirt-build +++ b/ts-libvirt-build @@ -73,7 +73,7 @@ sub config() { --with-libxl --without-xen --without-xenapi --without-selinux \\ --without-lxc --without-vbox --without-uml \\ --without-qemu --without-openvz --without-vmware \\ - --sysconfdir=/etc --localstatedir=/var #/ + --sysconfdir=/etc --localstatedir=/var $r{autogen_options} #/ END } else { target_cmd_build($ho, 3600, $builddir, < Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 16:33:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407597.650148 (Exim 4.92) (envelope-from ) id 1oYrnt-0000JC-0u; Thu, 15 Sep 2022 16:33:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407597.650148; Thu, 15 Sep 2022 16:33:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrns-0000J5-UI; Thu, 15 Sep 2022 16:33:28 +0000 Received: by outflank-mailman (input) for mailman id 407597; Thu, 15 Sep 2022 16:33:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYrnr-0000Iy-98 for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 16:33:27 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e19dd44-3514-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 18:33:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e19dd44-3514-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663259605; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=9KCtAw+CG74CAe7fbKsxrOFejQJFw35vUc4ijoSaNBE=; b=SzeH3Jg7mkpbL8+HlBE0kjiipGKZ5XS57jJ0X1UDoXeufO6Z15up2eMs DzNCHKgBNiVMLXhU677KH+dMTKK63mv6kjrudxuGCNiw376B/HDq5qtBY 5RlJiQBgCXxVCss8AkmTO7EV9nVpogG1/oVQB7OloSFc2MfaK5m4o5E35 U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79764948 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:f3xN6qBJ8p8oeBVW/0Djw5YqxClBgxIJ4kV8jS/XYbTApDIj0jwPm jceC2rXO6vZN2D0fYwiOonj8hgHvcfWx9M1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFsv/b8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW0Xlw9g3Ml4IB7wj9dtGCmhxx P4aAglYO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDmMklAgjOiF3Nz9ecSOaJRSrgGjq 0XX/V7fEC0faIGf8G/Qmp6rrrCWxn6qMG4IL5W66/prjVu71mEVThoMWjOToOa7ol6zXcpFL E4Z8TZoqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj wLX2YOybdByjFGLYUyU9prNkyyMAxkuIlIzbiY7fAkHyeC29enfkSnzosZf/L+d14OrQmmtm WjX8kDSlJ1I05dVivzTEUTvxmv1+8OXFlNdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FKBvazt3MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC GeK510Kvc8LYSbzPP8vC25UNyjN5fG5fekJq9iONoYeCnSPXFXvEN5Sib64gDm2zRlEfVAXM paHa8e8ZUsn5VBc5GPvH48gPUoDnH9WKZX7Gc+mlHxKENO2OBaodFvyGAHWM7FivP/f8Vi9H hQ2H5Li9iizmdbWOkH/mbP/53hTRZTnLfgac/BqS9M= IronPort-HdrOrdr: A9a23:XEAlBK/Iz2sTN87RLy1uk+DeI+orL9Y04lQ7vn2YSXRuHPBws/ re+MjzsiWE7wr5OUtQ/OxoV5PsfZqxz/JICMwqTNGftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyIMbEQt6fHCWeDfOod/A== X-IronPort-AV: E=Sophos;i="5.93,318,1654574400"; d="scan'208";a="79764948" Date: Thu, 15 Sep 2022 17:33:06 +0100 From: Anthony PERARD To: Roger Pau Monne CC: , Ian Jackson , "Julien Grall" Subject: Re: [PATCH v2] libvirt: disable Werror for non-libvirt flights Message-ID: References: <20220915162052.50522-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220915162052.50522-1-roger.pau@citrix.com> On Thu, Sep 15, 2022 at 06:20:52PM +0200, Roger Pau Monne wrote: > Current usage of Werror=switch-enum by default for libvirt builds out > of the git tree causes issues when new items are added to libxl public > API enums if those are used in a switch statement in libvirt code. > This leads to libvirt build failures for seemingly unrelated libxl > changes. > > In order to prevent those errors from blocking the push gate, disable > Werror for libvirt builds when not in a libvirt specific flight. > > The errors will be reported on the libvirt flight, and block the > pushes there. So the author of the changes in libxl is still expected > to send a fix to libvirt code. This is no ideal, but the other option > is to just disable Werror for all libvirt builds and let libvirt > developers fix the breakage when they notice it. > > runvar differences for a xen-unstable flight are: > > --- /dev/fd/63 2022-09-15 15:57:44.340581730 +0000 > +++ /dev/fd/62 2022-09-15 15:57:44.340581730 +0000 > @@ -574,6 +574,10 @@ > test-xtf-amd64-amd64-3 arch amd64 > test-xtf-amd64-amd64-4 arch amd64 > test-xtf-amd64-amd64-5 arch amd64 > +build-amd64-libvirt autogen_options --disable-werror > +build-arm64-libvirt autogen_options --disable-werror > +build-armhf-libvirt autogen_options --disable-werror > +build-i386-libvirt autogen_options --disable-werror > test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm bios seabios > test-amd64-amd64-qemuu-nested-amd bios seabios > test-amd64-amd64-qemuu-nested-intel bios seabios > @@ -1217,6 +1221,10 @@ > build-arm64-libvirt make_njobs 1 > build-armhf-libvirt make_njobs 1 > build-i386-libvirt make_njobs 1 > +build-amd64-libvirt meson_options -Dwerror=false > +build-arm64-libvirt meson_options -Dwerror=false > +build-armhf-libvirt meson_options -Dwerror=false > +build-i386-libvirt meson_options -Dwerror=false > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true > test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_dmrestrict true > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict recipe_nomigrate true > > Signed-off-by: Roger Pau Monn Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 15 16:33:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 16:33:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407599.650158 (Exim 4.92) (envelope-from ) id 1oYroG-0000kM-8H; Thu, 15 Sep 2022 16:33:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407599.650158; Thu, 15 Sep 2022 16:33:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYroG-0000kF-58; Thu, 15 Sep 2022 16:33:52 +0000 Received: by outflank-mailman (input) for mailman id 407599; Thu, 15 Sep 2022 16:33:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYroE-0000Iy-QE for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 16:33:50 +0000 Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [2607:f8b0:4864:20::931]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d22d68f-3514-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 18:33:50 +0200 (CEST) Received: by mail-ua1-x931.google.com with SMTP id e3so6915781uax.4 for ; Thu, 15 Sep 2022 09:33:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d22d68f-3514-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=UZZ52unMNTSmadzO25VS8FGK2YPZOAf7FY2SxJz4H1M=; b=NPV1+ct6LByH+hFHUgpWv4IVdPTFJGBdSYdj2fyPREoZgmbwxNnqQJV9CM2n9ObLsu dIffmHuVlJpllX9Q76Pkj86J5Pc6SThNrBrrKlAkIqCt0aLjMvveQ5/i9UlwVmGHyTA4 A6aLT/9bI5INh9P7fk6b8yf8IlpuJLgguFNZ9IPuKKgq2AF/xsqQwGV1RFGS0fhYYRp7 VGrCm8nzIYRDO6zmbZvpIqlWvCZ3bjG4uuggJhb/eu0SU3xP5DazL0CeCkjyl09b98az ESmweY1dhv8D9HUob7T39GcxGdeQRnXuGwWeJSpoqMyqXSOQnBVtKZdh3FPmSIgPlriC 94yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=UZZ52unMNTSmadzO25VS8FGK2YPZOAf7FY2SxJz4H1M=; b=3qH0m+AyPeg/+4+lRuu/jH7JVoCTlP8Xe6WzLl+ujA0TFKA3RTIw/cz7o8PV3pqYRl NYfb40EfNLY5HF96JZCi+x83jatd6nCrf08l/yDhyy1e9tmdnmSnHpjJICxohtYFTKqr 0ewE8LIbv7OC2F/VOI3O2GpepfsuYZJwfVBgZ7MXnoS8uYS9F1zPlxzmF0WKdmqlBo6P XRz0HoYz8FB0xymE4VAk3lCkX7dWoa12UnqpbKuGKI15cq5C1xcNJI5OjqtqY8+jdAd7 +tWHMQdWShfl+v6ASGgGBirm3hRy+2eIiztnkEJAZ5UCwVsPfEKl68GSzhDgWNlgxeGK JobQ== X-Gm-Message-State: ACrzQf17hrAnagkBddYuvPeDlExUmB4TN6qNM0HZF/dAhwMH4t/jvhjc rmj4aV0YiInxnjt5jcDL3+bYG6h/6MiC7u+E4M6owabPyHg= X-Google-Smtp-Source: AMsMyM7q71h2cJ+APruZwn6D+Eg8x9dJNVV9BX0BH9r3Pw0GyVdzyWOf46dZ8sK9b81xKHc4G7GooMsg4RSGqZGpusE= X-Received: by 2002:ab0:2a96:0:b0:39f:749c:cf9f with SMTP id h22-20020ab02a96000000b0039f749ccf9fmr304280uar.21.1663259628381; Thu, 15 Sep 2022 09:33:48 -0700 (PDT) MIME-Version: 1.0 From: Neil Sikka Date: Thu, 15 Sep 2022 12:33:37 -0400 Message-ID: Subject: Crash when writing to x86 hardware debug registers To: Xen-devel Content-Type: multipart/alternative; boundary="00000000000051aa0a05e8b9cf7f" --00000000000051aa0a05e8b9cf7f Content-Type: text/plain; charset="UTF-8" Hi All, I am running a userland debugger in Windows 10 HVM on Xen 4.16 on an Intel chip. I noticed when I set a hardware breakpoint (which writes to the DR0 register), Windows 10 crashes. This crash reproduces both with and without viridian enabled in the DomU cfg file. (XEN) Xen version 4.16.1 (neil@) (gcc (Debian 10.2.1-6) 10.2.1 20210110) debug=n Tue Apr 19 11:20:04 EDT 2022 (XEN) d13v0 VIRIDIAN CRASH: 1e ffffffffc0000096 fffff8007f85562c 0 0 This output from xl dmesg shows that I am not running a debug hypervisor, and that theres a viridian crash. I've gotten the following stop codes in the BSOD from Windows: KMODE EXCEPTION NOT HANDLED, SYSTEM_SERVICE EXCEPTION. I see this code in xen/xen/arch/x86/msr.c inside guest_wrmsr(): case MSR_AMD64_DR0_ADDRESS_MASK: case MSR_AMD64_DR1_ADDRESS_MASK ... MSR_AMD64_DR3_ADDRESS_MASK: if ( !cp->extd.dbext ) goto gp_fault; I was assuming AMD64 refers to a 64 bit CPU rather than an AMD CPU, and this is one of the few references I found to DR0, and I saw a deliberate fault raised if dbext is not set. However I'm told that dbext is unrelated, set by default and does not need to be set at hypervisor compile time. Any ideas why I'm getting this crash? Thanks in Advance, Neil -- My Blog: http://www.neilscomputerblog.blogspot.com/ Twitter: @neilsikka --00000000000051aa0a05e8b9cf7f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All,
I am running a userland debugger in= Windows 10 HVM on Xen 4.16 on an Intel chip. I noticed when I set a hardwa= re breakpoint (which writes to the DR0 register), Windows 10 crashes. This = crash reproduces both with and without viridian enabled in the DomU cfg fil= e.

(XEN) Xen version 4.16.1 (neil@) (gcc (Debian 1= 0.2.1-6) 10.2.1 20210110) debug=3Dn Tue Apr 19 11:20:04 EDT 2022
<= div>(XEN) d13v0 VIRIDIAN CRASH: 1e ffffffffc0000096 fffff8007f85562c 0 0

This output from xl dmesg shows that I am not running= a debug hypervisor, and that theres a viridian crash. I've gotten the = following stop codes in the BSOD from Windows:=C2=A0KMODE EXCEPTION NOT HAN= DLED, SYSTEM_SERVICE EXCEPTION.

I see this code in=C2=A0= xen/xen/arch/x86/msr.c inside guest_wrmsr():
=C2=A0 =C2=A0 case M= SR_AMD64_DR0_ADDRESS_MASK:
=C2=A0 =C2=A0 case MSR_AMD64_DR1_ADDRESS_MASK= ... MSR_AMD64_DR3_ADDRESS_MASK:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !cp-&g= t;extd.dbext )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto gp_fault;<= br>

I was assuming AMD64 refers to a 64 bit CPU ra= ther than an AMD CPU, and this is one of the few references I found to DR0,= and I saw a deliberate fault raised if dbext is not set. However I'm t= old that dbext is unrelated, set by default and does not need to be set at = hypervisor compile time.

Any ideas why I'm get= ting this crash?

Thanks in Advance,
Neil

--
Twitter: @neilsikka
<= /div> --00000000000051aa0a05e8b9cf7f-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 16:49:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 16:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407613.650170 (Exim 4.92) (envelope-from ) id 1oYs33-0002fa-Kr; Thu, 15 Sep 2022 16:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407613.650170; Thu, 15 Sep 2022 16:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYs33-0002fT-IG; Thu, 15 Sep 2022 16:49:09 +0000 Received: by outflank-mailman (input) for mailman id 407613; Thu, 15 Sep 2022 16:49:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYs32-0002fN-5T for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 16:49:08 +0000 Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com [68.65.122.15]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f11bf32-3516-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 18:49:06 +0200 (CEST) Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 06CFB18000B2 for ; Thu, 15 Sep 2022 12:49:04 -0400 (EDT) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by mta-05.privateemail.com (Postfix) with ESMTPA id D709618000AD for ; Thu, 15 Sep 2022 12:49:03 -0400 (EDT) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-3454e58fe53so227988267b3.2 for ; Thu, 15 Sep 2022 09:49:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f11bf32-3516-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1663260543; bh=JZ8C7J0KQgGgRo+qCni2mXYj7kmGaMJzfb38RhyPcTc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cl5qam9j7y8hcpX708VyNSDwkXTVu1jIHDITi4r6sqPKAUKPyR2y81F+WI0/Sv08t 4LJyrWS7VLVIN+Ekiw4gd2LAijEMxrJFnsWMPqn26BtaWTbSCGUsgHQP96m4ef9mdM wDXzh1aFxHpRdJ+u3tTHQBfwDW5Y6PxVepdEiVCtCdsA7RzJnUWz5Dz+d3BugkCovV BbmNH4GnSNFfWco73j3AIjBtLJg4ofeotW1ZPbOoj5dhU7DsTZ0Hd2YsWqx0sNx8Zz vf7Lhd61Y6u3EgqWm/aVIxXSRwJwy1xs7YX/XqsqWFkirnmw6Krz3FK9gLgPuN5Akh snesGSZiiANaw== X-Gm-Message-State: ACrzQf25peBWvYhFw35gIizjFd2ABNqKGpVERDhUkIfTaRi3iljb5OaZ mhM0iT4SYQuMOqpu83BRZ6gXa01hghZuo2rGrsc= X-Google-Smtp-Source: AMsMyM4vlxa3J562aEzDTpW2//G6KlsNL8G+cjicemdVo5GiHN8yyz1qHBecMXS103yw+CyO8xMjgouXQGovY/8+ZYA= X-Received: by 2002:a81:6143:0:b0:335:3076:168e with SMTP id v64-20020a816143000000b003353076168emr610450ywb.460.1663260542974; Thu, 15 Sep 2022 09:49:02 -0700 (PDT) MIME-Version: 1.0 References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> In-Reply-To: <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> From: Tamas K Lengyel Date: Thu, 15 Sep 2022 12:48:27 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Console output stops on dbgp=xhci To: Jan Beulich Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Sep 15, 2022 at 10:39 AM Jan Beulich wrote: > > On 15.09.2022 16:16, Tamas K Lengyel wrote: > > On Thu, Sep 15, 2022 at 10:10 AM Jan Beulich wrote: > >> > >> On 15.09.2022 16:05, Tamas K Lengyel wrote: > >>> On Thu, Sep 15, 2022 at 3:56 AM Jan Beulich wrote: > >>>> > >>>> On 15.09.2022 02:41, Tamas K Lengyel wrote: > >>>>>>> Do you have any idea what might be going on and preventing the output > >>>>>>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still > >>>>>>> present on the receiving side, just nothing is being received over it. > >>>>>> > >>>>>> There are few more patches in the series that are de facto required. > >>>>>> Especially those about IOMMU, otherwise it can only possibly work with > >>>>>> iommu=0 (which I'm not sure if even is enough). > >>>>> > >>>>> Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this > >>>>> on the console: > >>>>> > >>>>> (XEN) Panic on CPU 0: > >>>>> (XEN) FATAL PAGE FAULT > >>>>> (XEN) [error_code=0011] > >>>>> (XEN) Faulting linear address: 00000000328b3a54 > >>>> > >>>> Perhaps in another thread, could you post details about this? I guess > >>>> we want to address this independent of your XHCI issue. That's an > >>>> attempt to execute code outside of the Xen image - the only reason I > >>>> can think of for this would be an EFI boot services or runtime > >>>> services call, with (possibly but not necessarily) quirky EFI firmware. > >>>> Any other context this is appearing in would quite certainly require a > >>>> fix in Xen, and I don't see how "iommu=0" could affect the set of EFI > >>>> calls we make. > >>> > >>> This was indeed observed with a xen.efi booted directly from UEFI. > >>> Beside the limited boot log I get through xhci I don't have more > >>> insight but happy to send that (and anything else you think would be > >>> useful). > >> > >> And with "iommu=0" but no use of XHCI it doesn't crash? Or there you have > >> no way to collect the log then? > >> > >> In any event, from your description the interesting part might be the > >> EFI memory map. That ought to be pretty stable between boots, so you may > >> be able to collect that in full via "xl dmesg" in a run without "iommu=0". > > > > I see the same crash with no xhci debug use. The EFI map is: > > > > (XEN) EFI memory map: > >[...] > > (XEN) 0000031f72000-0000032a95fff type=3 attr=000000000000000f > > This is the entry covering the address, which is EfiBootServicesCode > with no unusual attributes. Assuming the crash was still during boot > (of Xen, not Dom0), do you also have at least the full stack walk > from the crash, to know where in Xen the call chain started? I don't see a stack walk right now, but it looks like the path to it is a previous panic that wants to restart the machine: (XEN) Panic on CPU 0: (XEN) Couldn't enable IOMMU and iommu=required/force (XEN) **************************************** (XEN) (XEN) Reboot in five seconds... (XEN) ----[ Xen-4.17-unstable x86_64 debug=y Not tainted ]---- (XEN) CPU: 0 (XEN) RIP: e008:[<00000000328b3a54>] 00000000328b3a54 (XEN) RFLAGS: 0000000000010202 CONTEXT: hypervisor (XEN) rax: 0000000035efe498 rbx: 0000000035efe4d0 rcx: 0000000000000001 (XEN) rdx: 000000000311100a rsi: 0000000000000000 rdi: 0000000000000001 (XEN) rbp: 0000000000000001 rsp: ffff82d040657b18 r8: 0000000000000000 (XEN) r9: 0000000035fc2080 r10: 0000000000000001 r11: 0c00000000000000 (XEN) r12: 0000000000000000 r13: 000000000311100a r14: 000000000000001f (XEN) r15: 0000000035fc2080 cr0: 0000000080050033 cr4: 00000000007506e0 (XEN) cr3: 00000008a12ae000 cr2: 00000000328b3a54 (XEN) fsb: 0000000000000000 gsb: 0000000000000000 gss: 0000000000000000 (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: 0000 cs: e008 (XEN) Xen code around <00000000328b3a54> (00000000328b3a54): (XEN) 49 8b e3 5d c3 cc cc cc <33> c0 c3 cc 40 53 48 83 ec 20 44 8b d1 44 8b da (XEN) Xen stack trace from rsp=ffff82d040657b18: (XEN) 0000000035ff6737 ffff82d040657b60 0000000000000046 ffff82d040657b40 (XEN) ffff82d04024f48f 0000000000000000 ffff82d04024f50a 0000000000000000 (XEN) ffff82d040968d40 0000000000000000 0000000035fc2080 ffff82d04041a848 (XEN) ffff82d040930400 0000000000000001 0000000035ff67c9 0000000000000001 (XEN) 000000000311100a 0000000000000000 0000000000000000 0000000000000000 (XEN) ffff82d040922980 0000000000000000 0000000000000000 ffff82d04041a848 (XEN) 0000000035fc18e4 0000000000000000 0000000000000000 0000000000000000 (XEN) 0000000000000000 0000000000000000 0000000000000000 0000000000000000 (XEN) 0000000035fc15b0 0000000000000000 ffff82d040657fff 0000000000000000 (XEN) 00000000007506e0 000000000000000f 0000000000000000 ffff82d040930400 (XEN) 0000000035fba737 0000000000000000 0000000000000000 0000000000000000 (XEN) 0000000000000000 ffff82d040657cb0 ffff82d04028332c 0000000000000065 (XEN) ffff82d0402835d6 0000000000000000 ffff82d040657ce8 0000000000000000 (XEN) 00000008a12ae000 0000000028e16000 0000000000000000 000000000000e008 (XEN) 0000000000000287 0000000000000000 ffff82d040657d38 ffff82d04032dbee (XEN) 0000138840657d48 000082d040657d08 0000000000000000 0000000000000296 (XEN) ffff82d040930400 00000000ffffffff ffff82d04080b400 000000000000000f (XEN) ffff82d040657da0 ffff82d04024d682 0c00000000000010 ffff82d040657db0 (XEN) ffff82d040657d60 0000000000000000 ffff82d04043f16c 0000000000000001 (XEN) 0000000000171240 0000000000000000 7fffffffffffffff 00000000ffffffed (XEN) Xen call trace: (XEN) [<00000000328b3a54>] R 00000000328b3a54 (XEN) [<0000000035ff6737>] S 0000000035ff6737 (XEN) (XEN) Pagetable walk from 00000000328b3a54: (XEN) L4[0x000] = 00000008a12ad063 ffffffffffffffff (XEN) L3[0x000] = 0000000028e0e063 ffffffffffffffff (XEN) L2[0x194] = 80000000328001e3 ffffffffffffffff (PSE) (XEN) (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) FATAL PAGE FAULT (XEN) [error_code=0011] (XEN) Faulting linear address: 00000000328b3a54 (XEN) **************************************** (XEN) (XEN) Reboot in five seconds... (XEN) Resetting with ACPI MEMORY or I/O RESET_REG. From xen-devel-bounces@lists.xenproject.org Thu Sep 15 18:15:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 18:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407625.650181 (Exim 4.92) (envelope-from ) id 1oYtOk-0003nJ-PZ; Thu, 15 Sep 2022 18:15:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407625.650181; Thu, 15 Sep 2022 18:15:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYtOk-0003nC-MP; Thu, 15 Sep 2022 18:15:38 +0000 Received: by outflank-mailman (input) for mailman id 407625; Thu, 15 Sep 2022 18:15:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYtOj-0003n5-FF for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 18:15:37 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64001b7c-3522-11ed-a31c-8f8a9ae3403f; Thu, 15 Sep 2022 20:15:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1064FCE1C0A; Thu, 15 Sep 2022 18:15:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B8CC433D6; Thu, 15 Sep 2022 18:15:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64001b7c-3522-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663265731; bh=TLFsK3Vya/NKYK0efkkZ5bqOngb7MP8/8lEXrRfyuz4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Alh4PdGzgTSos6fdNBy2R4N+BzIZqboooXZbsAw7EFgqmRDQJKauniSwDDq2DWGCO cf+1dt+C9UlWlMDQt3qVvFvdUE0jWFl6dB2HK9GybtEzrax+Y7+YLFMknC6iaDdAu7 OkUlhfmfVi+0OEfFmn1aj8XTsTDPXQgw0bF7o/vjPyKuZeg9mD2R+DhXQ0vJRUEuYp oVvvmZwm+rH1jkEfsZ9ZoLcmKaIB6X5WhHQkgRzkNR/JjM5kbETiMQISA8XYjKa4Pg OdRR3TaEb/VEKR9U7SPhN4PzkBLYEtjkqI0xNDIMgSzmxzUEa1xyOPsbCqhcJnWmRO VHt5JnCnd6M7g== Date: Thu, 15 Sep 2022 11:15:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Carlo Nonato , andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/12] Arm cache coloring In-Reply-To: <65f5a6b5-37a7-4b5f-b42b-805a51790a60@suse.com> Message-ID: References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <65f5a6b5-37a7-4b5f-b42b-805a51790a60@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 15 Sep 2022, Jan Beulich wrote: > Plus an advanced question: In how far does this interoperate with > static allocation, which again is (for now) an Arm-only feature? > Your reference to dom0less above doesn't cover this afaict. I take you are referring to static-mem, the static memory ranges for dom0less domUs described in docs/misc/arm/device-tree/booting.txt. static-mem doesn't interoperate with cache coloring: each static range would span across multiple colors. You have to choose either feature, using both at the same time doesn't make sense. Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Thu Sep 15 19:00:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 19:00:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407632.650191 (Exim 4.92) (envelope-from ) id 1oYu6P-0000o6-3W; Thu, 15 Sep 2022 19:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407632.650191; Thu, 15 Sep 2022 19:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYu6P-0000nz-0r; Thu, 15 Sep 2022 19:00:45 +0000 Received: by outflank-mailman (input) for mailman id 407632; Thu, 15 Sep 2022 19:00:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYu6N-0000np-Nj; Thu, 15 Sep 2022 19:00:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYu6N-0004UA-F6; Thu, 15 Sep 2022 19:00:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYu6N-0002bG-3W; Thu, 15 Sep 2022 19:00:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYu6N-0000ue-37; Thu, 15 Sep 2022 19:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NY43Qonx7mUlanaXyabLAA2U80d+V6rERZQrTl8zGGM=; b=6BygNbjWVowXJO+FScrQgeWkd9 Wy3acNU6x+tuaTrz6rt9MKzu1+wO3KTqDiYTeY32SZMLvkzdv7v907Wv6RT3p04ZpM531RDVm0MrH cZa2n8Br1VVjIyCnoJP0yfvn5a53xsi57pTd5KTYWPYpvH+Y9YFHLvO//WjV2GXKBwzk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173214: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=45297e6c9bd1be53b3c462adb9b37b4df2ea8681 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 19:00:43 +0000 flight 173214 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173214/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 45297e6c9bd1be53b3c462adb9b37b4df2ea8681 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 42 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 314 attempts Testing same since 173211 2022-09-15 12:14:39 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2543 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 19:31:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 19:31:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407640.650203 (Exim 4.92) (envelope-from ) id 1oYuZl-0004Uy-Hb; Thu, 15 Sep 2022 19:31:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407640.650203; Thu, 15 Sep 2022 19:31:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYuZl-0004Ur-Ec; Thu, 15 Sep 2022 19:31:05 +0000 Received: by outflank-mailman (input) for mailman id 407640; Thu, 15 Sep 2022 19:31:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYuZj-0004Uh-0s for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 19:31:03 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0073.outbound.protection.office365.us [23.103.209.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec32966b-352c-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 21:30:59 +0200 (CEST) Received: from PH1P110MB1652.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:18e::22) by PH1P110MB1171.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:18f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Thu, 15 Sep 2022 19:30:54 +0000 Received: from PH1P110MB1652.NAMP110.PROD.OUTLOOK.COM ([fe80::e8ff:cf87:d387:3e7c]) by PH1P110MB1652.NAMP110.PROD.OUTLOOK.COM ([fe80::e8ff:cf87:d387:3e7c%4]) with mapi id 15.20.5612.023; Thu, 15 Sep 2022 19:30:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec32966b-352c-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=lrAcqohAWlbj/qj8V281t3Z2rSzAyVa7ZcQn/U14GgbPRR5xVdcEwFRIfPkZGkDi78GFIetxDG8il35PtSm9w+38gJPMFYJo96ZuLLpjOwWIhgbPDRlS7xFMRf0DmaRm5eOgMRbndlUd0G7UI+ISTG5cfrpbraSg/O6ObMEBx9cf+JMQrDfgvHvkAcYGw0DfcBMH9uNGFGeRK/2gpT1Jnt5XHlKP8qSM3J0az7v2+TNdDvu6VrZ//aCqxgN2vdO/CH2jv7jYWRxQW880OKz2sZswWbR/Q/uhvsiIGSkMfvG+sOjnssHw4/zAni1rEPepxrBWvOW9YHdgietkLo4WFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OnMJAcq7J1Niq1aAZycGEXxEibBg4ArBiRZzO5o3Abs=; b=cuSM6dLppH7MywCmAvMZrhEJ4L5QQQ/or8hedpSZnHwI5Ow6cqIUvbjtVnINtGIpT5aH4/CWMZlDRHZpTn3QpWAe48hUVt+x9ceIgfsPHZSx+jGLSp5ibQRGSmS7B461sgZlDQ2OdATKKwoFfkacoH3LGjNWPieVAQtw4BuMqjOTJgXCzlNddfB8hbH3LaClMMepZHm/+YHpWIQyHbur9RHPCI8ieaSRZEjtFNV2y0j7y+hmz7pMneaSakozKdDzsfE7E8rQkkS7rbmEFMhuCYSyg/Fk95rXeNt0PQA+whaBZ1QCnVLSTDrETriT2/1Xo7TTQlyY9X1yf45TGXWzww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dornerworks.com; dmarc=pass action=none header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dornerworks.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnMJAcq7J1Niq1aAZycGEXxEibBg4ArBiRZzO5o3Abs=; b=LhFY4eysvnrM086znWWyWXruVR0CDFrRBr37orwsvkYCwU8R3e5kmbtHQm+bxGwaJUs9h7MTQo4VBZBLx51GNYvgNIGX5uGCoXZwoqFAPf3doLsbLMkRTDwStPtyUYsb0gbTBPHNDSKNZffASs7MtgX1/yKXkvnexxbneGneKqZdcrvycyeS8nQYPgYqTBgeS1nRTaX5iF2WkJLVWQtPVLlY/VkWIiymEGmS/G0DBE7XMJHxzwvb1GEgcUWyfqxEfD+fb5GO9Dtskyo5iEPcHV8cmuaMDPUZ4NfbICvLQkf1yPQfNyYPk181J7f6t9O/5UtYP4FuvltzIr0UitJz0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=dornerworks.com; From: Stewart Hildebrand To: xen-devel@lists.xenproject.org Cc: Stewart Hildebrand , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jeff Kubascik , Nathan Studer , Robbie VanVossen , xen-devel@dornerworks.com, Stewart Hildebrand Subject: [PATCH] MAINTAINERS: change my email Date: Thu, 15 Sep 2022 15:30:27 -0400 Message-Id: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> X-Mailer: git-send-email 2.37.3 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: CY1P110CA0043.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:400::13) To PH1P110MB1652.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:18e::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH1P110MB1652:EE_|PH1P110MB1171:EE_ X-MS-Office365-Filtering-Correlation-Id: 1dea7828-e4d6-47c3-de9e-08da9750ce1c X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ar9jFq0YbMpGxSsBH1liWRK3b7zlc2ne3m3ZhDv9Waw+dJt3RVw3u32XptLjfe9d1j41K1SX7fV2Gv0y7InEMiSY3FlKD/d1PUy2KZcS15nxMN7vy+ANDEGxyhS8sNsQwhS3PvPXLzePSGpRgX6ZdMBRcm4VH1JVS+e58odXLZCj+GLEZu3JoCnnm/xRmOzexSxf8WCMuTVJfw4v7v2BZcaPgDlIGogwZcZL76Hb9dlqMJi8S0DP3yQEal4O8SDGaAX0RFVQwJ6aMfI3y3j/3KrFN7jTDM8CgU68rGEMkk4TdeGmtAQZtoY6vFClPK0bNvhLKYB6v/4uOIZ+2PAwTi9TpHm0A+2zBj2/KhO3Ya5EzA2BcW1yefHY6yiQHcY/5nVoLxwdSf/2rnGxM2jJlfk851aNc2Oju0/Sp8xt4QB+tQRe/Ur3CsizPT3iL7n4O3eM+C8Aho3EhXa+vG2tDtk1dXQnzST/qmN2EfhKx/Ke1VUKK3MxKNYiNmdNKMITrUqdr6jIGqWBfWZl5Mg608qf+x64WttW4Z7Dokv/ok6KkESrBwoCwslpBvFwR5xpAsMGgMj+RVe5e3FWjhfKZCGXjuQMnPeR33dPwYcF8fIMAx2pQAuFGlXWZ84XJurSJFBuabBi8Zw9G3BuAPBVitu7rfIsh9ZkYXf0MehQmIIjPtYGez17LqFKFMVeRNpR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH1P110MB1652.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39830400003)(396003)(366004)(136003)(451199015)(1076003)(6486002)(6916009)(54906003)(86362001)(6506007)(52116002)(38100700002)(2616005)(66946007)(38350700002)(4326008)(8676002)(66476007)(66556008)(186003)(41320700001)(8936002)(6666004)(508600001)(4744005)(41300700001)(36756003)(83380400001)(26005)(5660300002)(44832011)(6512007)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TshBsLVxj0+t4gOJURWs2tsdor6H+QgYORpX7PeCcNIa5DP66QNLfF7D0B3WwPBtYkOwb/OZm1MGSSkG5qpL5dOwpxyIKvWhBg4k8IdxY2APa1qY0wEri/gtUO7lGuwCkHf860BQd3rNTbo3xeHwq5rc8/hFTZZab8rz3cPwYt9tA1uR5KElA0p381u+MiES7a0Y6IsJxU3/std9cSLpphLZVcsPUdmKrT/iVKvtSUj7pOtO+IJCO8DWMb6ziEJdIOadax6HNPgI7IxykZJJj0xcR/B1T+83LD848boXYLluXzVzYtfCnjp+UANfnwg6qGl37PnJxZmg+gLxGFIFLjYV7S23arnm8oowvRoUvT5VWUzMTARIHA8IC62nyXzh2qOIMibDybjqMjXDK97dubRAOFhwK/2YERIajKBiRPo= X-OriginatorOrg: dornerworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dea7828-e4d6-47c3-de9e-08da9750ce1c X-MS-Exchange-CrossTenant-AuthSource: PH1P110MB1652.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 19:30:54.0959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 097cf9aa-db69-4b12-aeab-ab5f513dbff9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH1P110MB1171 I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in maintaining the ARINC 653 scheduler, so change to my personal email address. Also change status to Maintained. Signed-off-by: Stewart Hildebrand --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e12c499a28..f674b5f7ba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -221,8 +221,8 @@ F: xen/include/xen/argo.h F: xen/common/argo.c ARINC653 SCHEDULER -M: Stewart Hildebrand -S: Supported +M: Stewart Hildebrand +S: Maintained L: xen-devel@dornerworks.com F: xen/common/sched/arinc653.c F: tools/libs/ctrl/xc_arinc653.c -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 19:57:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 19:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407646.650215 (Exim 4.92) (envelope-from ) id 1oYuz0-0007R9-Lu; Thu, 15 Sep 2022 19:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407646.650215; Thu, 15 Sep 2022 19:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYuz0-0007R2-HN; Thu, 15 Sep 2022 19:57:10 +0000 Received: by outflank-mailman (input) for mailman id 407646; Thu, 15 Sep 2022 19:57:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYuyz-0007Qq-6I; Thu, 15 Sep 2022 19:57:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYuyz-0005Oz-18; Thu, 15 Sep 2022 19:57:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYuyy-0005W5-IE; Thu, 15 Sep 2022 19:57:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYuyy-0002Fj-Hm; Thu, 15 Sep 2022 19:57:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EesC9IPol8gPmPOaU+av7TdtIfgt5gotlioSdNRts74=; b=djwhs9JBTIL4eBuLGUAtO4r+L7 tcPteyNQ4Jf/XATajkhBh12FBaMu3M/eHAjaCaMf4xBETYm8aen1dnz0qd2nco0Q7TMOJWAPb0QMu Tn+sKZKNaJO53jWrgnCV8kvkXguDbz4tDEa4KYj/25l7kyUN9Xo8zKcVefzZwe9uYh7w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173209: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Thu, 15 Sep 2022 19:57:08 +0000 flight 173209 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173209/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173200 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 43 days Failing since 172148 2022-08-04 21:39:38 Z 41 days 95 attempts Testing same since 173060 2022-09-08 07:34:59 Z 7 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 20:04:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 20:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407656.650225 (Exim 4.92) (envelope-from ) id 1oYv6S-0000gl-I2; Thu, 15 Sep 2022 20:04:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407656.650225; Thu, 15 Sep 2022 20:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYv6S-0000ge-F4; Thu, 15 Sep 2022 20:04:52 +0000 Received: by outflank-mailman (input) for mailman id 407656; Thu, 15 Sep 2022 20:04:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYv6R-0000gX-Cu for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 20:04:51 +0000 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [2607:f8b0:4864:20::a2b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a74fc9fb-3531-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 22:04:50 +0200 (CEST) Received: by mail-vk1-xa2b.google.com with SMTP id s12so2951582vkn.11 for ; Thu, 15 Sep 2022 13:04:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a74fc9fb-3531-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=kbbeEAOlwLSV7w9n5pXFIfd9Vc0gpzZdqJ4FeejGH8U=; b=WlDVLYP+/jwjzUBVOMZTORS328sjM9LNs+6ky71SlCCQ7pqvW1+SoKKcTxKPZizV7u KmEIBz9IbcoQ9xIK9cW5dKHQ9s5qOB8tWJ0YiiQWvK8yqpItfGM4eHo3B1ngA1p+YM8V GYWtD/XOJi76vWtQOdHMygF8X07RD1F8KxVsiuj4vMbQw5Rh21MTiWkSheRvhYNNkTFS VR5sSkKsU8wZWjqi0cXaC9LLezOly49kd0n9r2lzHpMt2wVYSFgRu0E8XE2xVLJ7mGAs DUW2q+YzvZLpa/6UvIAaPisQnna4EtbUwk0YcgNZ8ugxhKQMeySqKDq4CfFUTf9KKx+Y GU5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=kbbeEAOlwLSV7w9n5pXFIfd9Vc0gpzZdqJ4FeejGH8U=; b=6L8DB2Pbv785mdpaOqXQ74jGjLsu/67lcKR+T2kiY868Nrg3lWzS6zAYwma7hcdnCn zHZhk8bjJ31wRha9Dk2+8NFp8SnKQ0ZahSHUgU+4ki/1bqqUslQTC9jpoVziVBWZBvOD I9VKsiNwZKqUWR796nC1eWMFkehBUGYEtvwwNzvZxVDBhIWu4EZiQbXjZjVX1mU2g7Bx 6pu1tp4OQn3wslocVN2sL/jbBfn8A+63cH09I/+R1gQ8eKiFu/3XiKX/RcofbZOQ37VV u/UOh2+Zd9oIvJf8JxQo6LPCRCBrNtB/yeAaPP0fIbuiYMoGnPIS2BMoe5ESPdihX63J VKfw== X-Gm-Message-State: ACrzQf0Qxr8/qYi+29W3mTuXNpdgP9yyEJj2xpubLFBSBmUqmvHxmbKQ MeQXKtzA4IeBBAsaFjGvl/aP2flOu+n/cotEsKVj1Ty8gaU= X-Google-Smtp-Source: AMsMyM7yCee1QfgectWtvhZvOyK2thkHqoZJ8kJBN7JD77zdHRd2JqT/DkDpEpDfZU4RRcv2g0BEHZKr4X+BSuYJWKE= X-Received: by 2002:a05:6122:d83:b0:39d:fe61:2a27 with SMTP id bc3-20020a0561220d8300b0039dfe612a27mr914542vkb.1.1663272288750; Thu, 15 Sep 2022 13:04:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Neil Sikka Date: Thu, 15 Sep 2022 16:04:38 -0400 Message-ID: Subject: Re: Crash when writing to x86 hardware debug registers To: Xen-devel Content-Type: multipart/alternative; boundary="000000000000ef926b05e8bcc1e0" --000000000000ef926b05e8bcc1e0 Content-Type: text/plain; charset="UTF-8" Update: I rebuilt the hypervisor binary in debug mode and get the following output in xl dmesg after the crash. (XEN) HVM9 restore: CPU 0 (XEN) HVM9 restore: PIC 0 (XEN) HVM9 restore: PIC 1 (XEN) HVM9 restore: IOAPIC 0 (XEN) HVM9 restore: LAPIC 0 (XEN) HVM9 restore: LAPIC_REGS 0 (XEN) HVM9 restore: PCI_IRQ 0 (XEN) HVM9 restore: ISA_IRQ 0 (XEN) HVM9 restore: PCI_LINK 0 (XEN) HVM9 restore: PIT 0 (XEN) HVM9 restore: RTC 0 (XEN) HVM9 restore: HPET 0 (XEN) HVM9 restore: PMTIMER 0 (XEN) HVM9 restore: MTRR 0 (XEN) HVM9 restore: VIRIDIAN_DOMAIN 0 (XEN) HVM9 restore: CPU_XSAVE 0 (XEN) HVM9 restore: VIRIDIAN_VCPU 0 (XEN) HVM9 restore: VMCE_VCPU 0 (XEN) HVM9 restore: TSC_ADJUST 0 (XEN) HVM9 restore: CPU_MSR 0 (XEN) d9: VIRIDIAN MSR_TIME_REF_COUNT: accessed (XEN) vmx.c:3295:d9v0 RDMSR 0x00000000 unimplemented (XEN) d9v0 VIRIDIAN CRASH: 1e ffffffffc0000096 fffff80575bc362c 0 0 On Thu, Sep 15, 2022 at 12:33 PM Neil Sikka wrote: > Hi All, > I am running a userland debugger in Windows 10 HVM on Xen 4.16 on an Intel > chip. I noticed when I set a hardware breakpoint (which writes to the DR0 > register), Windows 10 crashes. This crash reproduces both with and without > viridian enabled in the DomU cfg file. > > (XEN) Xen version 4.16.1 (neil@) (gcc (Debian 10.2.1-6) 10.2.1 20210110) > debug=n Tue Apr 19 11:20:04 EDT 2022 > (XEN) d13v0 VIRIDIAN CRASH: 1e ffffffffc0000096 fffff8007f85562c 0 0 > > This output from xl dmesg shows that I am not running a debug hypervisor, > and that theres a viridian crash. I've gotten the following stop codes in > the BSOD from Windows: KMODE EXCEPTION NOT HANDLED, SYSTEM_SERVICE > EXCEPTION. > > I see this code in xen/xen/arch/x86/msr.c inside guest_wrmsr(): > case MSR_AMD64_DR0_ADDRESS_MASK: > case MSR_AMD64_DR1_ADDRESS_MASK ... MSR_AMD64_DR3_ADDRESS_MASK: > if ( !cp->extd.dbext ) > goto gp_fault; > > I was assuming AMD64 refers to a 64 bit CPU rather than an AMD CPU, and > this is one of the few references I found to DR0, and I saw a deliberate > fault raised if dbext is not set. However I'm told that dbext is unrelated, > set by default and does not need to be set at hypervisor compile time. > > Any ideas why I'm getting this crash? > > Thanks in Advance, > Neil > > -- > My Blog: http://www.neilscomputerblog.blogspot.com/ > Twitter: @neilsikka > -- My Blog: http://www.neilscomputerblog.blogspot.com/ Twitter: @neilsikka --000000000000ef926b05e8bcc1e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Update: I rebuilt the hypervisor binary in debug mode and = get the following output in xl dmesg after the crash.

(XEN) = HVM9 restore: CPU 0
(XEN) HVM9 restore: PIC 0
(XEN) HVM9 restore: PIC 1
(XEN) HVM9 restore: IOAPIC 0
(XEN) HVM9 restore: LAPIC 0
(XEN) HVM9 restore: LAPIC_REGS 0
(XEN) HVM9 restore: PCI_IRQ 0
(XEN) HVM9 restore: ISA_IRQ 0
(XEN) HVM9 restore: PCI_LINK 0
(XEN) HVM9 restore: PIT 0
(XEN) HVM9 restore: RTC 0
(XEN) HVM9 restore: HPET 0
(XEN) HVM9 restore: PMTIMER 0
(XEN) HVM9 restore: MTRR 0
(XEN) HVM9 restore: VIRIDIAN_DOMAIN 0
(XEN) HVM9 restore: CPU_XSAVE 0
(XEN) HVM9 restore: VIRIDIAN_VCPU 0
(XEN) HVM9 restore: VMCE_VCPU 0
(XEN) HVM9 restore: TSC_ADJUST 0
(XEN) HVM9 restore: CPU_MSR 0
(XEN) d9: VIRIDIAN MSR_TIME_REF_COUNT: accessed
(XEN) vmx.c:3295:d9v0 RDMSR 0x00000000 unimplemented
(XEN) d9v0 VIRIDIAN CRASH: 1e ffffffffc0000096 fffff80575bc362c 0 0
=

On Thu, Sep 15, 2022 at 12:33 PM Neil Sikka <neilsikka@gmail.com> wrote:
Hi All,
I am running a userland debugger in Windows 10 HVM on Xen 4.16 on = an Intel chip. I noticed when I set a hardware breakpoint (which writes to = the DR0 register), Windows 10 crashes. This crash reproduces both with and = without viridian enabled in the DomU cfg file.

(XE= N) Xen version 4.16.1 (neil@) (gcc (Debian 10.2.1-6) 10.2.1 20210110) debug= =3Dn Tue Apr 19 11:20:04 EDT 2022
(XEN) d13v0 VIRIDIAN CRASH:= 1e ffffffffc0000096 fffff8007f85562c 0 0

This outp= ut from xl dmesg shows that I am not running a debug hypervisor, and that t= heres a viridian crash. I've gotten the following stop codes in the BSO= D from Windows:=C2=A0KMODE EXCEPTION NOT HANDLED, SYSTEM_SERVICE EXCEPTION.=

I see this code in=C2=A0xen/xen/arch/x86/msr.c inside g= uest_wrmsr():
=C2=A0 =C2=A0 case MSR_AMD64_DR0_ADDRESS_MASK:
= =C2=A0 =C2=A0 case MSR_AMD64_DR1_ADDRESS_MASK ... MSR_AMD64_DR3_ADDRESS_MAS= K:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !cp->extd.dbext )
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto gp_fault;

I was assuming AMD64 refers to a 64 bit CPU rather than an AMD CPU, and th= is is one of the few references I found to DR0, and I saw a deliberate faul= t raised if dbext is not set. However I'm told that dbext is unrelated,= set by default and does not need to be set at hypervisor compile time.

Any ideas why I'm getting this crash?

Thanks in Advance,
Neil

<= /div>--


--
Twitter: @neilsikka
--000000000000ef926b05e8bcc1e0-- From xen-devel-bounces@lists.xenproject.org Thu Sep 15 20:41:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 20:41:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407667.650235 (Exim 4.92) (envelope-from ) id 1oYvfd-0005Wv-8P; Thu, 15 Sep 2022 20:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407667.650235; Thu, 15 Sep 2022 20:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYvfd-0005Wo-5M; Thu, 15 Sep 2022 20:41:13 +0000 Received: by outflank-mailman (input) for mailman id 407667; Thu, 15 Sep 2022 20:41:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYvfb-0005Wf-BT for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 20:41:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7c5d34b-3536-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 22:41:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7c5d34b-3536-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663274466; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Iz134rqvwTvscS9CWxWtMb5PUbEKwnQkr/UCyWzFbGs=; b=beL7eLi1tIKmevNffmM2N5izb2P4SqCAFc370KXtCmjYYrwiYGxWU0eo +aVK8sXFhrII2xM5lCMIEqTEcPv4FDiVvaDDVVXYMVEUsBn0ewlXHmWvg cu4Vkh0Efg2wSH9PSY0b+TlibcjWkRVwkK/xDHYs8bvQHga4ByYINsq6C Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80632883 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AiasIg6y0w7c0oQPSk9N6t4n5zX0kqDA+Zkaqj?= =?us-ascii?q?vbM1gqbGSHpmQ7xaDEIGIziBwNmucJAR/E2mJKvnGiAAZiZk99MhMhh73mcn?= =?us-ascii?q?WFVNoP4hOpavdvxnnHGDB491RpDLt7iN+uwk4PNgtsu2SY2fjU706yP8RupN?= =?us-ascii?q?kF9VCgKMwBHr26FI97Z0QBCq9Lgk3bMzowxRC7BN+rfafEB5OidDcWht4TnH?= =?us-ascii?q?ZtYKZ6cRP2qSZ6jkqSmGTrKtZTzIMIn+Pg/fVZ705tS/k5BlFzesmScCTHvd?= =?us-ascii?q?C44kvaCynE/GaE9nWRC+kwUvAbBWExkoGQrDuy2ybcOtQQaU9lWZ72Jfrjih?= =?us-ascii?q?CMOChgfk6cJ8lxnLClKiTtkvSd6C1BsjXhDiwxsHlv057a0dd3SBZZ1bDek2?= =?us-ascii?q?fIWuz5ReqaT6kGi3E7HFDc9JaC9LQSQ3rGoy2VKJpXr1DIsSxEh4v7JaIpvP?= =?us-ascii?q?EhuiJwwtSf0xCM+cGMtLs1a7L67aIur3npssz8TeicsaQdmpkQpS19JmFJGa?= =?us-ascii?q?n0geYnS1c+A+xAbjAYiHKvyV3yfeor4Cg2cEelrLMp6d5d8P+3MleK75iUAj?= =?us-ascii?q?oDlL+9bIjot1zrst0IzZQjyXJLosXfzvhhK22OUBwNY/Uck3WRAka0NXrCZm?= =?us-ascii?q?xcuHp60jnCSuwI/r7CcNEW54c/tmt3ksqvJylnCcpw0h/anIRVlSXDRKzEzH?= =?us-ascii?q?J7/FnEOEE+8D4gLO/KeLF05OWpVwpITdT0MKxoO3hKS1bgC1Ns8lTUtl8pY3?= =?us-ascii?q?Ku3Cw/qNIU2QBn8/azqANPi/hf9G7ooygN3ftxO92vAOfMFo29kqUmDOekp+?= =?us-ascii?q?n1wllQSb1BVnDysgnufKbDLSqlPe9J0CoJMd84S8BE5S4uReSdA42rhBlaBT?= =?us-ascii?q?tS9NOEY5yrNdvwnb+i+nc7lPOC0vcT/uEW7NeLchcSedgotQzBQhphD3nRZW?= =?us-ascii?q?2SqzJzyAnPz4Ws+wm5HXyOhbsJSF5ooIvW5sQlnRWvwRPibJYbVyuAo+EgDI?= =?us-ascii?q?GMlvbh4YWGgOHqW225oG6KdqlBkKBJyieQ6PIjgmU947rmYkod048sOWyLTE?= =?us-ascii?q?kcmHEKw8sw8jYsItxIwLr13TjoLFoT0Yzd2BPo42P96rpGSEgT3wS2M9fC+/?= =?us-ascii?q?PXfEgiNWJu30YX98Op19vm6RIIAFyyFz8iMjA1iLCvfr+OHamow6TL+YTvpZ?= =?us-ascii?q?PXKbFfuJ5Pgu+83w22+6edTESTsOvDan61n5InVp5TQNzeVzBcD6m6Ketu/L?= =?us-ascii?q?dDj6eORp5IdAFl08o6zZwYysTouTc5IE5s+agDMkDoJkWstHmxepSpBkC1g1?= =?us-ascii?q?nLgbG48LhcDJFVP3GURpjFHM5NFT89PKqz7/6nMuebqPbEHfhAbXCnAQ62qc?= =?us-ascii?q?giaXb4+Z6tupamUwZHX3P1d1JT+k4fV9tki2hKN2NEOTPnQejTm6j48QsrEB?= =?us-ascii?q?kqG6tZNAVMhGmttySgFJ+ThM61nDZ1r0pkdSuyoV3z5YUYPN7PTnu5zdQ4QI?= =?us-ascii?q?XpVr8w6iYLXNl4YydffsXwJTzgCbVTgYZcH2EES5bzU9k7NHYZ15lOK8Y/dq?= =?us-ascii?q?bcyqeztItaxOpgTTZUWbeOykwZiUE6GAhiJOMNtE4HERwkmSQdAsh071qV3R?= =?us-ascii?q?NMzItsNq56L3t17zbF9j9aLrZexgYTY4y4jllL8giqCHGUmIIstcocC6+uTF?= =?us-ascii?q?T/zXXXlYxtpIXTfdQKdpL8+PYZjtUGdchbVYKypRGVzMAbJSvD1RLnkOOKv7?= =?us-ascii?q?+ATVslPx0NYY/I7tTJTVnrQfjpku7xgB9rRoK30WJhSf9rt9gEwzxjS4aPM7?= =?us-ascii?q?IANBz9y5cvWQEE9Qo1hW7mh9Mp03jftNOnyS6tlYhVhWTJktawEmoN62i5pc?= =?us-ascii?q?x7CKYREIBLH4HAb+TZwy1HibsK605GeeSTc9E7mYsaCdHcjKOpEdsSPqheMF?= =?us-ascii?q?qKeDfodUygTeMbfYptWGEvEBtm7nkXJsfBQNYDZgLXF7kdxkgsdCzm/C9kJ9?= =?us-ascii?q?oPS1OSvwfxBJIrZvPqIpmQcfuIvfbY+VQZ/ohMI+j7SIopNMZgT/iXYKlUHG?= =?us-ascii?q?EwWjFcquE8LGk/o9xJPpFv04f08U5zqTIWQVQjGsLE8ZWLJemaXlxJc+mw2d?= =?us-ascii?q?Aq/MYR8SO1G5ryafIdH0wZw8+2jXdQ57obhYqCIjPHbXARJMgXbNTysYAzZH?= =?us-ascii?q?zhg7Zrc+rohV7B7oaGp6fy3IbZfgczF1VKm3jDAp3i6LSYgV7vWnSJ55R6s6?= =?us-ascii?q?AbNorHwm3Ccna7fMt5TljK5j/I8fz0NXfq2AeFYm5x8seGXYlsMhEco1jsuI?= =?us-ascii?q?IOJCxa5wspbmSafxb8gUj05UVi33rndHvW9lLWvxhpEMABIhnrzZ54IHeWW1?= =?us-ascii?q?ip78krIVcsGxgDCJmofD5EkMJQptaqmg2AOH9lJUOczQlh0iaSLnrTeh2Xvr?= =?us-ascii?q?T8xJReuRY2pIiipZL75iDGUKIXajICYHsVTW93jr45BdNDiD55uVeTi+t2Zm?= =?us-ascii?q?28u66FIdZWQYjD3pktuKXePNomvoeFYjMz8qeKv4dFqa7tSf+SRykCrzbJlC?= =?us-ascii?q?HvVxPkomZnjoo83Hzj8FW0lnFzmPZJeaXgNIW0dZYc9DRblv3VoWVv8s15VB?= =?us-ascii?q?UfmjBJLJiq+ldijhdRS4YN5WH1urkOr9OlVaMRip4cFdlefV+xd95I3Hoaet?= =?us-ascii?q?XQ3NECbmLXJwXcpW7ZWEE9WtYCM4OAerV/v2ZfhULH8RRm96jIAddO2tnN8f?= =?us-ascii?q?iPGPpH/cVfKe40ngGtoutOD+UJn?= X-IronPort-AV: E=Sophos;i="5.93,319,1654574400"; d="scan'208";a="80632883" From: Jennifer Herbert To: , , , CC: , Jennifer Herbert Subject: [PATCH 2/2] acpi: Add TPM2 interface definition. Date: Thu, 15 Sep 2022 20:40:29 +0000 Message-ID: <20220915204029.1227112-2-jennifer.herbert@citrix.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220915204029.1227112-1-jennifer.herbert@citrix.com> References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> <20220915204029.1227112-1-jennifer.herbert@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- tools/firmware/hvmloader/config.h | 1 + tools/firmware/hvmloader/util.c | 7 ++++++ tools/libacpi/Makefile | 2 +- tools/libacpi/acpi2_0.h | 26 ++++++++++++++++++++++ tools/libacpi/build.c | 35 ++++++++++++++++++++++++++++++ tools/libacpi/libacpi.h | 1 + tools/libacpi/ssdt_tpm2.asl | 36 +++++++++++++++++++++++++++++++ 7 files changed, 107 insertions(+), 1 deletion(-) create mode 100644 tools/libacpi/ssdt_tpm2.asl diff --git a/tools/firmware/hvmloader/config.h b/tools/firmware/hvmloader/config.h index c82adf6dc5..4dec7195f0 100644 --- a/tools/firmware/hvmloader/config.h +++ b/tools/firmware/hvmloader/config.h @@ -56,6 +56,7 @@ extern uint8_t ioapic_version; #define PCI_ISA_IRQ_MASK 0x0c20U /* ISA IRQs 5,10,11 are PCI connected */ #define ACPI_TIS_HDR_ADDRESS 0xFED40F00UL +#define ACPI_CRB_HDR_ADDRESS 0xFED40034UL extern uint32_t pci_mem_start; extern const uint32_t pci_mem_end; diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 87bc2d677f..6e5d3609b9 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -1009,6 +1009,13 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, config->table_flags |= ACPI_HAS_TPM; config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; break; + case 2: + config->table_flags |= ACPI_HAS_TPM; + config->crb_hdr = (uint16_t *)ACPI_CRB_HDR_ADDRESS; + + mem_hole_populate_ram(TPM_LOG_AREA_ADDRESS >> PAGE_SHIFT, TPM_LOG_SIZE >> PAGE_SHIFT); + memset((void *)(TPM_LOG_AREA_ADDRESS), 0, TPM_LOG_SIZE); + break; } config->numa.nr_vmemranges = nr_vmemranges; diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile index 60860eaa00..125f29fb54 100644 --- a/tools/libacpi/Makefile +++ b/tools/libacpi/Makefile @@ -25,7 +25,7 @@ C_SRC-$(CONFIG_X86) = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c dsdt_pvh C_SRC-$(CONFIG_ARM_64) = dsdt_anycpu_arm.c DSDT_FILES ?= $(C_SRC-y) C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, $(DSDT_FILES)) -H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h ssdt_laptop_slate.h) +H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h ssdt_tpm2.h ssdt_laptop_slate.h) MKDSDT_CFLAGS-$(CONFIG_ARM_64) = -DCONFIG_ARM_64 MKDSDT_CFLAGS-$(CONFIG_X86) = -DCONFIG_X86 diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h index 2619ba32db..f4eb4d715b 100644 --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -121,6 +121,30 @@ struct acpi_20_tcpa { }; #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) +/* + * TPM2 + */ +struct acpi_20_tpm2 { + struct acpi_header header; + uint16_t platform_class; + uint16_t reserved; + uint64_t control_area_address; + uint32_t start_method; + uint8_t start_method_params[12]; + uint32_t log_area_minimum_length; + uint64_t log_area_start_address; +}; +#define TPM2_ACPI_CLASS_CLIENT 0 +#define TPM2_START_METHOD_CRB 7 + +#define TPM_CRB_ADDR_BASE 0xFED40000 +#define TPM_CRB_ADDR_CTRL (TPM_CRB_ADDR_BASE + 0x40) + +#define TPM_LOG_AREA_ADDRESS 0xFED50000 + +#define TPM_LOG_AREA_MINIMUM_SIZE (64 << 10) +#define TPM_LOG_SIZE (64 << 10) + /* * Fixed ACPI Description Table Structure (FADT) in ACPI 1.0. */ @@ -431,6 +455,7 @@ struct acpi_20_slit { #define ACPI_2_0_RSDT_SIGNATURE ASCII32('R','S','D','T') #define ACPI_2_0_XSDT_SIGNATURE ASCII32('X','S','D','T') #define ACPI_2_0_TCPA_SIGNATURE ASCII32('T','C','P','A') +#define ACPI_2_0_TPM2_SIGNATURE ASCII32('T','P','M','2') #define ACPI_2_0_HPET_SIGNATURE ASCII32('H','P','E','T') #define ACPI_2_0_WAET_SIGNATURE ASCII32('W','A','E','T') #define ACPI_2_0_SRAT_SIGNATURE ASCII32('S','R','A','T') @@ -444,6 +469,7 @@ struct acpi_20_slit { #define ACPI_2_0_RSDT_REVISION 0x01 #define ACPI_2_0_XSDT_REVISION 0x01 #define ACPI_2_0_TCPA_REVISION 0x02 +#define ACPI_2_0_TPM2_REVISION 0x04 #define ACPI_2_0_HPET_REVISION 0x01 #define ACPI_2_0_WAET_REVISION 0x01 #define ACPI_1_0_FADT_REVISION 0x01 diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index d313ccd8cf..d4f25a68d2 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -19,6 +19,7 @@ #include "ssdt_s3.h" #include "ssdt_s4.h" #include "ssdt_tpm.h" +#include "ssdt_tpm2.h" #include "ssdt_pm.h" #include "ssdt_laptop_slate.h" #include @@ -352,6 +353,7 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, struct acpi_20_tcpa *tcpa; unsigned char *ssdt; void *lasa; + struct acpi_20_tpm2 *tpm2; /* MADT. */ if ( (config->hvminfo->nr_vcpus > 1) || config->hvminfo->apic_mode ) @@ -449,6 +451,39 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, tcpa->header.length); } break; + + case 2: + if (!config->crb_hdr || + config->crb_hdr[0] == 0 || config->crb_hdr[0] == 0xffff) + break; + + ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm2), 16); + if (!ssdt) return -1; + memcpy(ssdt, ssdt_tpm2, sizeof(ssdt_tpm2)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); + + tpm2 = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tpm2), 16); + if (!tpm2) return -1; + memset(tpm2, 0, sizeof(*tpm2)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tpm2); + + tpm2->header.signature = ACPI_2_0_TPM2_SIGNATURE; + tpm2->header.length = sizeof(*tpm2); + tpm2->header.revision = ACPI_2_0_TPM2_REVISION; + fixed_strcpy(tpm2->header.oem_id, ACPI_OEM_ID); + fixed_strcpy(tpm2->header.oem_table_id, ACPI_OEM_TABLE_ID); + tpm2->header.oem_revision = ACPI_OEM_REVISION; + tpm2->header.creator_id = ACPI_CREATOR_ID; + tpm2->header.creator_revision = ACPI_CREATOR_REVISION; + tpm2->platform_class = TPM2_ACPI_CLASS_CLIENT; + tpm2->control_area_address = TPM_CRB_ADDR_CTRL; + tpm2->start_method = TPM2_START_METHOD_CRB; + tpm2->log_area_minimum_length = TPM_LOG_AREA_MINIMUM_SIZE; + tpm2->log_area_start_address = TPM_LOG_AREA_ADDRESS; + + set_checksum(tpm2, + offsetof(struct acpi_header, checksum), + tpm2->header.length); } } diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index 9143616130..b5d08ff09b 100644 --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -80,6 +80,7 @@ struct acpi_config { uint8_t tpm_version; const uint16_t *tis_hdr; + const uint16_t *crb_hdr; /* * Address where acpi_info should be placed. * This must match the OperationRegion(BIOS, SystemMemory, ....) diff --git a/tools/libacpi/ssdt_tpm2.asl b/tools/libacpi/ssdt_tpm2.asl new file mode 100644 index 0000000000..1801c338df --- /dev/null +++ b/tools/libacpi/ssdt_tpm2.asl @@ -0,0 +1,36 @@ +/* + * ssdt_tpm2.asl + * + * Copyright (c) 2018-2022, Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +/* SSDT for TPM CRB Interface for Xen with Qemu device model. */ + +DefinitionBlock ("SSDT_TPM2.aml", "SSDT", 2, "Xen", "HVM", 0) +{ + Device (TPM) + { + Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID: Hardware ID + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + { + Memory32Fixed (ReadWrite, + 0xFED40000, // Address Base + 0x00001000, // Address Length + ) + }) + Method (_STA, 0, NotSerialized) // _STA: Status + { + Return (0x0F) + } + } +} -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 20:41:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 20:41:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407668.650247 (Exim 4.92) (envelope-from ) id 1oYvfg-0005mX-Gf; Thu, 15 Sep 2022 20:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407668.650247; Thu, 15 Sep 2022 20:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYvfg-0005mQ-Cu; Thu, 15 Sep 2022 20:41:16 +0000 Received: by outflank-mailman (input) for mailman id 407668; Thu, 15 Sep 2022 20:41:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYvff-0005Wf-2j for xen-devel@lists.xenproject.org; Thu, 15 Sep 2022 20:41:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc7e9695-3536-11ed-9761-273f2230c3a0; Thu, 15 Sep 2022 22:41:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc7e9695-3536-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663274473; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=a81udNHz/IlPqVKBLEW5GyDm0ULIJu6/GbwCobxYlU8=; b=CeSkpd05aSPdG6oYylmBbfr/4TSiUcO/LMiW8StM2AUt5NNXmhINg8U5 k+bMMiJwUbI3aP6jyjt/QfX0MbeN1eUeMEUIVbuqIsmFvhv1qTlyHMaVS QGn9EarOAlFbi8ffLWEmZtsHN4tiXHNcPxjPvGdSRRD7yTCDsiLemwmZU k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83155908 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XQR+jaIYO6UYFy/KFE+RvJUlxSXFcZb7ZxGr2PjKsXjdYENS0DYCx zNJUWzQPKqOMWukLt4lPojl8klXsZHcyt9qSgdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/Pa9Us01BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEzq5IMWMfP6Ah/cFvGz1R2 OEhDD0KV0XW7w626OrTpuhEg80iKI/gPZ8Fu2EmxjbcZRokacmdGeOQv4YehWpuwJAVdRrdT 5NxhT5HbhnGZRxBN01RCJ8kluqymlH0ciFCqULTrq0yi4TW5FwqieWwYYKFEjCMbe5snBep5 X/bxUP4AkBELd3c8haI1X3504cjmgukAdlPRdVU7MVCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGS0SvHtUhv+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9RCm7y5W9rx6LPg8NNzMdSDI9aQYC2oy2yG0stS4jXuqPAYbs0IOuQWyqm 23UxMQtr+5N1JBWjs1X6XiC2mvx/caRE2bZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/5nzvZ5pyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN51gLusECZyr1Mf8fj2eN5yMClPCIKDgYfqqMMoomjmZZLmdrAx2ClWbPhjuwwSDAYIk0O IuBcNbEMEv2/Z9PlWPuL9rxJJdxmUjSM0uPGs2gp/lmuJLCDEOopUAtbgbfN71psfveyOgXm v4GX/a3J9xkeLWWSkHqHUQ7dzjm8VBT6UjKlvFq IronPort-HdrOrdr: A9a23:GEbk3qhJsuFPLZ+UWUFLbyqM5XBQXuIji2hC6mlwRA09TySZ// rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.93,319,1654574400"; d="scan'208";a="83155908" From: Jennifer Herbert To: , , , CC: , Jennifer Herbert Subject: [PATCH 1/2] acpi: Make TPM version configurable. Date: Thu, 15 Sep 2022 20:40:28 +0000 Message-ID: <20220915204029.1227112-1-jennifer.herbert@citrix.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This patch makes the TPM version, for which the ACPI libary probes, configurable. If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. I have also added to hvmloader an option to allow setting this new config, which can be triggered by setting the platform/tpm_verion xenstore key. Signed-off-by: Jennifer Herbert --- docs/misc/xenstore-paths.pandoc | 8 ++++ tools/firmware/hvmloader/util.c | 13 ++++++- tools/libacpi/build.c | 68 ++++++++++++++++++--------------- tools/libacpi/libacpi.h | 4 +- 4 files changed, 59 insertions(+), 34 deletions(-) diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index 5cd5c8a3b9..7270b46721 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -269,6 +269,14 @@ at the guest physical address in HVM_PARAM_VM_GENERATION_ID_ADDR. See Microsoft's "Virtual Machine Generation ID" specification for the circumstances where the generation ID needs to be changed. + +#### ~/platform/tpm_version = INTEGER [HVM,INTERNAL] + +The TPM version to be probed for. + +A value of 1 indicates to probe for TPM 1.2. If unset, or an +invalid version, then no TPM is probed. + ### Frontend device paths Paravirtual device frontends are generally specified by their own diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 581b35e5cf..87bc2d677f 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -994,13 +994,22 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | + config->table_flags |= (ACPI_HAS_TPM | ACPI_HAS_IOAPIC | ACPI_HAS_WAET | ACPI_HAS_PMTIMER | ACPI_HAS_BUTTONS | ACPI_HAS_VGA | ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); config->acpi_revision = 4; - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; + s = xenstore_read("platform/tpm_version", "0"); + config->tpm_version = strtoll(s, NULL, 0); + + switch( config->tpm_version ) + { + case 1: + config->table_flags |= ACPI_HAS_TPM; + config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; + break; + } config->numa.nr_vmemranges = nr_vmemranges; config->numa.nr_vnodes = nr_vnodes; diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index fe2db66a62..d313ccd8cf 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -409,38 +409,46 @@ static int construct_secondary_tables(struct acpi_ctxt *ctxt, memcpy(ssdt, ssdt_laptop_slate, sizeof(ssdt_laptop_slate)); table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); } - - /* TPM TCPA and SSDT. */ - if ( (config->table_flags & ACPI_HAS_TCPA) && - (config->tis_hdr[0] != 0 && config->tis_hdr[0] != 0xffff) && - (config->tis_hdr[1] != 0 && config->tis_hdr[1] != 0xffff) ) + /* TPM and SSDT. */ + if (config->table_flags & ACPI_HAS_TPM) { - ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); - if (!ssdt) return -1; - memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); - - tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); - if (!tcpa) return -1; - memset(tcpa, 0, sizeof(*tcpa)); - table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); - - tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; - tcpa->header.length = sizeof(*tcpa); - tcpa->header.revision = ACPI_2_0_TCPA_REVISION; - fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); - fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); - tcpa->header.oem_revision = ACPI_OEM_REVISION; - tcpa->header.creator_id = ACPI_CREATOR_ID; - tcpa->header.creator_revision = ACPI_CREATOR_REVISION; - if ( (lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16)) != NULL ) + switch (config->tpm_version) { - tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); - tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; - memset(lasa, 0, tcpa->laml); - set_checksum(tcpa, - offsetof(struct acpi_header, checksum), - tcpa->header.length); + case 1: + if (!config->tis_hdr || + config->tis_hdr[0] == 0 || config->tis_hdr[0] == 0xffff || + config->tis_hdr[1] == 0 || config->tis_hdr[1] == 0xffff) + break; + + ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm), 16); + if (!ssdt) return -1; + memcpy(ssdt, ssdt_tpm, sizeof(ssdt_tpm)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, ssdt); + + tcpa = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tcpa), 16); + if (!tcpa) return -1; + memset(tcpa, 0, sizeof(*tcpa)); + table_ptrs[nr_tables++] = ctxt->mem_ops.v2p(ctxt, tcpa); + + tcpa->header.signature = ACPI_2_0_TCPA_SIGNATURE; + tcpa->header.length = sizeof(*tcpa); + tcpa->header.revision = ACPI_2_0_TCPA_REVISION; + fixed_strcpy(tcpa->header.oem_id, ACPI_OEM_ID); + fixed_strcpy(tcpa->header.oem_table_id, ACPI_OEM_TABLE_ID); + tcpa->header.oem_revision = ACPI_OEM_REVISION; + tcpa->header.creator_id = ACPI_CREATOR_ID; + tcpa->header.creator_revision = ACPI_CREATOR_REVISION; + + if ( (lasa = ctxt->mem_ops.alloc(ctxt, ACPI_2_0_TCPA_LAML_SIZE, 16)) != NULL ) + { + tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); + tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; + memset(lasa, 0, tcpa->laml); + set_checksum(tcpa, + offsetof(struct acpi_header, checksum), + tcpa->header.length); + } + break; } } diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index a2efd23b0b..9143616130 100644 --- a/tools/libacpi/libacpi.h +++ b/tools/libacpi/libacpi.h @@ -27,7 +27,7 @@ #define ACPI_HAS_SSDT_PM (1<<4) #define ACPI_HAS_SSDT_S3 (1<<5) #define ACPI_HAS_SSDT_S4 (1<<6) -#define ACPI_HAS_TCPA (1<<7) +#define ACPI_HAS_TPM (1<<7) #define ACPI_HAS_IOAPIC (1<<8) #define ACPI_HAS_WAET (1<<9) #define ACPI_HAS_PMTIMER (1<<10) @@ -78,8 +78,8 @@ struct acpi_config { struct acpi_numa numa; const struct hvm_info_table *hvminfo; + uint8_t tpm_version; const uint16_t *tis_hdr; - /* * Address where acpi_info should be placed. * This must match the OperationRegion(BIOS, SystemMemory, ....) -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 15 21:19:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 21:19:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407684.650258 (Exim 4.92) (envelope-from ) id 1oYwGQ-0001q4-IC; Thu, 15 Sep 2022 21:19:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407684.650258; Thu, 15 Sep 2022 21:19:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwGQ-0001px-Ep; Thu, 15 Sep 2022 21:19:14 +0000 Received: by outflank-mailman (input) for mailman id 407684; Thu, 15 Sep 2022 21:19:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwGP-0001pm-K1; Thu, 15 Sep 2022 21:19:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwGP-0006ry-Iz; Thu, 15 Sep 2022 21:19:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwGP-0000wQ-6U; Thu, 15 Sep 2022 21:19:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYwGP-0002Ne-65; Thu, 15 Sep 2022 21:19:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LD+NOl6qXC/z+6sOpJxQZSN5asOCzQ7V/Pecow97fGs=; b=jY6kggAcr0AgOqZ3RaG4mmYALI 2gdnk5Xb3T+ceugbImqr46Fti0OtD0Q0A2ZDT63xxoNEukoYhi7J+Bfu7B73+VXzV4Hh2K/xWBO9D UKxJhHPuWdlkPzrqaLgOh+IAgG+ssCQZJviXflaARPrMAvOjdpPujnmUjIbXYFxNx4/E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173218: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=3184e44df1042ae41c1cd8d2acaa47d7d30cd07c X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 21:19:13 +0000 flight 173218 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173218/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 3184e44df1042ae41c1cd8d2acaa47d7d30cd07c baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 42 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 315 attempts Testing same since 173218 2022-09-15 19:13:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2616 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 21:38:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 21:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407692.650269 (Exim 4.92) (envelope-from ) id 1oYwYk-0004Zy-4k; Thu, 15 Sep 2022 21:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407692.650269; Thu, 15 Sep 2022 21:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwYk-0004Zr-1e; Thu, 15 Sep 2022 21:38:10 +0000 Received: by outflank-mailman (input) for mailman id 407692; Thu, 15 Sep 2022 21:38:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwYi-0004Zf-NY; Thu, 15 Sep 2022 21:38:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwYi-0007B0-Ju; Thu, 15 Sep 2022 21:38:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYwYi-0002Ej-3w; Thu, 15 Sep 2022 21:38:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYwYi-0002IK-3U; Thu, 15 Sep 2022 21:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jCdAxTc7SGXD5z3rAM6RICR8nvNIsWB1nozpkzhkXe0=; b=k7Hi5Wydn7nDDdhGzjJCvsRhe2 7RYO9ZuRFylX/jb+htqnWi581V0EZzS1fi56TckqzTjBvVfIZNlaACtnPJLJ9CdkChstFbtt5Hja4 rNk3KEZI79NuC4pUampmVPvIfgEsaTUpYp2SOTaE5wZ4pYLCQNTngDX8D5giqB/W1cv4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173210: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3245cb65fd91cd514801bf91f5a3066d562f0ac4 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Thu, 15 Sep 2022 21:38:08 +0000 flight 173210 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3245cb65fd91cd514801bf91f5a3066d562f0ac4 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 42 days Failing since 172152 2022-08-05 04:01:26 Z 41 days 94 attempts Testing same since 173191 2022-09-14 11:10:31 Z 1 days 3 attempts ------------------------------------------------------------ 1779 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182803 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 15 23:54:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 15 Sep 2022 23:54:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407705.650283 (Exim 4.92) (envelope-from ) id 1oYygI-0003ZF-Rg; Thu, 15 Sep 2022 23:54:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407705.650283; Thu, 15 Sep 2022 23:54:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYygI-0003Z8-NF; Thu, 15 Sep 2022 23:54:06 +0000 Received: by outflank-mailman (input) for mailman id 407705; Thu, 15 Sep 2022 23:54:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYygG-0003Yx-8U; Thu, 15 Sep 2022 23:54:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYygG-0000wf-5i; Thu, 15 Sep 2022 23:54:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYygF-0001WK-Mp; Thu, 15 Sep 2022 23:54:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oYygF-0005ss-MI; Thu, 15 Sep 2022 23:54:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nAN6W+qCmjc++uUiIWNv6UOE39AIsppv27bvoQBAykw=; b=2ti2TNsMg7PwRyURbF21dk8n86 +l+ngwJaimm5z6JMh/PMYw9Xw34C3sNUJsGt/x0Wzuv1Ok5xDEhYYNnWLmzy2hmKlJWJDHvIh+KfG HjdOer6h2oAS9CKJby7f/HMxvZoDDcv1CFJt+XuTbH63Jf1M/6BI3cBQMuYchIf3DwLE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173221: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=3184e44df1042ae41c1cd8d2acaa47d7d30cd07c X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Thu, 15 Sep 2022 23:54:03 +0000 flight 173221 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173221/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 3184e44df1042ae41c1cd8d2acaa47d7d30cd07c baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 42 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 316 attempts Testing same since 173218 2022-09-15 19:13:25 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2616 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 00:11:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 00:11:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407716.650294 (Exim 4.92) (envelope-from ) id 1oYyx1-0006f7-3e; Fri, 16 Sep 2022 00:11:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407716.650294; Fri, 16 Sep 2022 00:11:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYyx1-0006f0-0d; Fri, 16 Sep 2022 00:11:23 +0000 Received: by outflank-mailman (input) for mailman id 407716; Fri, 16 Sep 2022 00:11:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYywz-0006eu-JD for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 00:11:21 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16d406bb-3554-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 02:11:20 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDFCA6277F; Fri, 16 Sep 2022 00:11:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95BEBC433C1; Fri, 16 Sep 2022 00:11:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16d406bb-3554-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663287078; bh=Vy69aml8hU2McMw2JQr1x3Oz7RBNUPYxKERbs9nrDQY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OLTrcrlk//iYOL/3Cj/mI3AkwBU75vOjylohZ4EOEtPteOkOfto7yS/9SXMt7FpJE WjMzBujlqdlR39oRZOwJLgu/MHOIBZqaVFqcaseP5iXjetHW8AIPWC5Udxfi4du+u1 PTCyR2HlrDa7/051hMx2UeB/i/OflObry62g/u9eCK6nLQuhRg6FPCnJrVW9J7IcUn XPouayjNXw43swEHL4Mm0/lBXJmVg8pyXVVOrlMTIQsHMs2sj1Ns8m4m5esNP8++OQ XFSarM4KtTv9zMqJVp6iRxU2k5EViSOQylPG/aXwlfnvtjaUZelfutfvpe0d4Ykp+G 8g52HMWixRPmg== Date: Thu, 15 Sep 2022 17:11:16 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap() In-Reply-To: Message-ID: References: <20220915083944.10097-1-jgross@suse.com> <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> <4a95c3d1-d4e8-9b59-8db8-231b59cdb8f5@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 15 Sep 2022, Jan Beulich wrote: > On 15.09.2022 12:20, Juergen Gross wrote: > > On 15.09.22 11:32, Jan Beulich wrote: > >> On 15.09.2022 10:39, Juergen Gross wrote: > >>> The IOCTL_PRIVCMD_MMAP isn't in use by Xen since at least Xen 4.0. > >>> > >>> Remove it from the privcmd driver. > >>> > >>> Signed-off-by: Juergen Gross > >> > >> Can we reasonably remove an IOCTL, without being entirely certain that > >> no users exist outside of xen.git? > > > > This is a valid question. I'm not sure how probable it is that such a user > > is existing. Are there any Xen tool stacks not using the Xen libraries? > > > > If so, why? Do we want to support those use cases? > > I'm afraid I have no answers to these questions, and hence would generally > want to be conservative with removal of functionality. I don't know either, but maybe we could at least mark IOCTL_PRIVCMD_MMAP as deprecated in include/uapi/xen/privcmd.h ? From xen-devel-bounces@lists.xenproject.org Fri Sep 16 00:11:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 00:11:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407717.650305 (Exim 4.92) (envelope-from ) id 1oYyx8-0006wC-DB; Fri, 16 Sep 2022 00:11:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407717.650305; Fri, 16 Sep 2022 00:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYyx8-0006w3-9E; Fri, 16 Sep 2022 00:11:30 +0000 Received: by outflank-mailman (input) for mailman id 407717; Fri, 16 Sep 2022 00:11:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYyx6-0006vA-Pe for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 00:11:29 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19b8aa75-3554-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 02:11:27 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.94.2 #2) with local (return-path ijackson@chiark.greenend.org.uk) id 1oYyx1-0003ks-Oy; Fri, 16 Sep 2022 01:11:23 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19b8aa75-3554-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=chiark.greenend.org.uk; s=d.chiark; h=DKIM-Signature-Warning:References: In-Reply-To:Subject:Cc:To:Date:Message-ID:Content-Transfer-Encoding: Content-Type:MIME-Version:From:Sender:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=VxOwVn7em2fMK67pgBu6uBIF35SvIl1Jqln+63470P0=; b=aVS8PDV3KOES t9OW/l/dXFRwjpVKAOq4oM2QHWYZx232K3Bjq94WWTEMptWWtAoSFN13oPS1cFBqOejk66Yiph224 QOlJOp4LFi6WP3cGs20d2O7xWu1mZP/C5oVBPmXgRKOJHTNn/hqCzjByFXYn18xj2usiWGctJUfDW u7dPyyF4SHTmVJ3rMBciFoAqPzRxhuWBDYT1F3XSWQQlcgjq+ZpPbaqMuL+QuVbbbTbnNUVx2RcT+ 1kvDkBvvKaIUEBFUct44JG7ZVhf/KQYz0bT63W4XkQ+UURm1WSmD0e/fBBdUGlWD80jHQX1c8wS8V pMkJpZYJzUYBFMFx+c823Q==; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <25379.48939.677933.809426@chiark.greenend.org.uk> Date: Fri, 16 Sep 2022 01:11:23 +0100 To: Anthony PERARD Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Subject: osstest branch refs and self-push-gate Re: Sorting out osstest In-Reply-To: References: X-Mailer: VM 8.2.0b under 27.1 (x86_64-pc-linux-gnu) DKIM-Signature-Warning: NOTE REGARDING DKIM KEY COMPROMISE https://www.chiark.greenend.org.uk/dkim-rotate/README.txt https://www.chiark.greenend.org.uk/dkim-rotate/df/dfe474b8ea4127edd09b653f3faec3f3.pem Anthony PERARD writes ("Re: Sorting out osstest"): > Yes, that plan sound good to me. Just one thing, `git checkout master` > in testing.git as at the moment "pretest" is the current branch. Yes. Here's an overview of what's (supposed) to exist and happen. There are: osstest:~osstest/testing.git #pretest Push here to update osstest. Need not be fast forwarding. So if something is doomed, or you cancel te self-test flight by killing sg-execute-flight, you can rewind it. You can also update this while a self-test is running, like any osstest input branch. If it is not ff from #master, even a successful self-test won't be able to update master. osstest:~osstest/testing.git #master xenbits:osstest.git #master Tested version. Normally, automatically updated from pretest after a successful self-test. Both refs are supposed to be updated in step. To force push, ie, push something manually without a self-test, you can use ./ap-push. Don't use git push (ap-push updates both refs). For other trees, to perform a force push, ./mg-force-push is better since it can perform additional checks. xenbits:~osstest/osstest-massachusetts.git #refs/heads/flight-NNN Permanent record of the osstest code which ran some flight. Separated because of git's poor perf with trees with so many refs. HTH. -- Ian Jackson These opinions are my own. Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 00:12:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 00:12:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407729.650315 (Exim 4.92) (envelope-from ) id 1oYyy2-0007iR-Lp; Fri, 16 Sep 2022 00:12:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407729.650315; Fri, 16 Sep 2022 00:12:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYyy2-0007iK-JE; Fri, 16 Sep 2022 00:12:26 +0000 Received: by outflank-mailman (input) for mailman id 407729; Fri, 16 Sep 2022 00:12:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYyy1-0006vA-Dt for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 00:12:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ccf77dc-3554-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 02:12:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E82F862781; Fri, 16 Sep 2022 00:12:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BA31C433C1; Fri, 16 Sep 2022 00:12:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ccf77dc-3554-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663287142; bh=D6JNVX4L5f1CKCm5Ste0j39s2hx8Ri7r6fqTpPPufxQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g7cNe3Qa/zZmla1b66xZh8C3yqnfHSIfBlHUGm7wn3ogMLEKAv3gOoNsfYCKkj2X7 IXb9FiO3wApAZmSiHai9UsPHUoQzxYT1krxtrVBeDvCa6mew/QbgcARpOGZv6RI42+ x+/JQhHwLVy+RWPr72Vosy4RWB7YWP9/xrlgY0EEQNSta3E7wOjM995KHswFkO5l4z 3UsXIRXyRPiFwBYvDDUuSsJdQw/I+HIjuaapdglzSG7C4PIuzRnUM9S3HEy5Iu1PJs POM5Lhfo23rnV39h1gd6x42ssztaNezm4yWJcqwmASXjXm9t+lW8sUI7iUGGQ2UZAA r5/sFsbza6Y+A== Date: Thu, 15 Sep 2022 17:12:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: Stefano Stabellini , Jan Beulich , "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , "Rangasamy, Devaraj" , "Pandeshwara krishna, Mythri" , "SK, SivaSangeetha (Siva Sangeetha)" , "Thomas, Rijo-john" Subject: Re: Linux pin_user_pages_fast fails on Xen In-Reply-To: Message-ID: References: <017b8061-110b-a77f-6f0c-9f5679b7df13@suse.com> <9f11a181-75cb-aadf-2ce8-8bb6737af9ac@suse.com> <3c1eccfe-3ca5-32d8-ee5a-cf8e7b23d587@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 15 Sep 2022, Juergen Gross wrote: > On 15.09.22 03:18, Stefano Stabellini wrote: > > On Wed, 14 Sep 2022, Jan Beulich wrote: > > > On 14.09.2022 01:31, Stefano Stabellini wrote: > > > > The problem is that drivers/xen/privcmd.c:privcmd_mmap sets VM_IO | > > > > VM_PFNMAP, and either flag would cause check_vma_flags to return > > > > -EFAULT. > > > > > > > > Do you know if it works if you remove VM_IO | VM_PFNMAP from > > > > privcmd_mmap? > > > > > > My Linux MM knowledge is certainly rusty, but I don't think this can > > > work, at the very least not without further changes elsewhere. > > > > The definition of VM_PFNMAP is: > > > > Page-ranges managed without "struct page", just pure PFN > > > > So it made perfect sense to use VM_PFNMAP back in the day when we were > > using address ranges without "struct page" for foreign mappings. > > > > > > However, nowadays Linux drivers typically call > > xen_alloc_unpopulated_pages to get local pages to be used for foreign > > mappings. xen_alloc_unpopulated_pages should work for both PV and > > autotranslated guests. So the local pages should have a regular "struct > > page" backing them. > > I agree that a struct page is associated with such PFNs. > > I'm not sure there are no other implicit dependencies in our drivers relying > on VM_PFNMAP and/or VM_IO being set. > > This would need really intensive testing for verification. > > > I noticed that privcmd calls > > alloc_empty_pages->xen_alloc_unpopulated_pages only for autotranslated > > guests. Do you guys think it is intentional? In theory, > > xen_alloc_unpopulated_pages should work for PV guests too. > > I agree that it should work, but it isn't needed. Sorry I don't follow -- why isn't it needed? Don't we need a struct page so that get_user_pages_fast & friends work correctly for a given address? I thought that was the original intention behind all of the xen_alloc_unpopulated_pages rework. > > After that, privcmd calls xen_remap_domain_gfn_array, which calls > > xen_xlate_remap_gfn_array or xen_remap_pfn depending on > > PV or autotranslated. > > > > But then I can see the following at the top of xlate_remap_gfn_array: > > > > /* Kept here for the purpose of making sure code doesn't break > > x86 PVOPS */ > > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | > > VM_IO))); > > > > and a similar one in arch/x86/xen/mmu_pv.c:xen_remap_pfn: > > > > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | > > VM_IO))); > > > > > > Given that the pages passed to xen_xlate_remap_gfn_array and > > xen_remap_pfn could have been allocated with > > xen_alloc_unpopulated_pages, why the BUG_ON? > > > > Is this just legacy? In the sense that the following could work? > > > > - privcmd calls xen_alloc_unpopulated_pages for both PV & autotranslated > > This would add some performance penalty for PV compared to today. > > > - no setting VM_PFNMAP | VM_IO > > This would need some very thorough testing for not breaking any PV device. > There are even more implications, as e.g. the kernel's memory management > might interfere in extreme situations like memory shortage or page migration > with pages not having set the flags (I might be wrong here, but better safe > than sorry). For sure it would need to be very well tested. Given that we have done very good work in refactoring the kernel memory allocation for mapping foreign pages, and now it is a lot more solid and "compatible" with the rest of the Linux infrastructure, it would be nice if we could exploit it to the fullest and get rid of bugs such as "get_user_pages_fast doesn't work". > > - no BUG_ON in xlate_remap_gfn_array > > - no BUG_ON in xen_remap_pfn > > Those are rather easy, as I'm not aware of those BUG_ON()s having triggered > in the last few years. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 00:20:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 00:20:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407736.650327 (Exim 4.92) (envelope-from ) id 1oYz5r-0000rd-FJ; Fri, 16 Sep 2022 00:20:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407736.650327; Fri, 16 Sep 2022 00:20:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYz5r-0000rW-Bo; Fri, 16 Sep 2022 00:20:31 +0000 Received: by outflank-mailman (input) for mailman id 407736; Fri, 16 Sep 2022 00:20:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oYz5p-0000rQ-Rz for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 00:20:29 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e3589dd-3555-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 02:20:28 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.94.2 #2) with local (return-path ijackson@chiark.greenend.org.uk) id 1oYz5k-0005Wp-61; Fri, 16 Sep 2022 01:20:24 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e3589dd-3555-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=chiark.greenend.org.uk; s=d.chiark; h=DKIM-Signature-Warning:References: In-Reply-To:Subject:Cc:To:Date:Message-ID:Content-Transfer-Encoding: Content-Type:MIME-Version:From:Sender:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=z/Oshp60xl+JFflm5d7YrYXSrZUKWk3su2XBZzLs6xg=; b=fThbEwtInDzE VPr606US+xM8zo4ebdUq7DILg+vydSFEtIE9oul7XeRjMzgbOOXvZZg0Saj5ugEVlSC05OvM7p9/W tjcrxwepPXpC7kFCPmnYLJEg2F7ZtKS3kaXWrN3LE5UmQdStseUCMBuPVwsAHfdpwM0q/+A14KHf6 d/VuuRVKv2+/9VZUxBTWChgfPzjNOOACjWQybcnUOUXrouyJ60d4Be7vsYW1JKdYA1P/SGn1uvS73 ICCtEEg2dFrk/7Fb8FeZsPc4tHPHTlNtrXnP0PtM3c8KGOvvCEDZvWUJ61DRZurdEk4Ozs9yaZLmA qLiu4eT0l7DP/B8TyOZEZw==; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <25379.49467.262316.722608@chiark.greenend.org.uk> Date: Fri, 16 Sep 2022 01:20:11 +0100 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Julien Grall Subject: Re: [PATCH] libvirt: disable Werror for non-libvirt flights In-Reply-To: References: <20220913100328.27771-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 27.1 (x86_64-pc-linux-gnu) DKIM-Signature-Warning: NOTE REGARDING DKIM KEY COMPROMISE https://www.chiark.greenend.org.uk/dkim-rotate/README.txt https://www.chiark.greenend.org.uk/dkim-rotate/df/dfe474b8ea4127edd09b653f3faec3f3.pem Roger Pau Monn=E9 writes ("Re: [PATCH] libvirt: disable Werror for non-= libvirt flights"): > I don't mind using -Dwerror=3Dfalse if that's considered better. Ian,= do > you have an opinion? No, I don't think I do. I think it depends on what kinds of things are likely to change, or go wrong, in libvirt. - *) libvirt_build_runvars+=3D" make_njobs=3D1";; + *) libvirt_build_runvars+=3D" make_njobs=3D1 meson_options=3D= -Dwerror=3Dfalse autogen_options=3D--disable-werror";; I wonder if it would be better to abstract this away and instead have a runvar like "libvrit_build_werror=3Dfalse". But maybe that is gold-plating it. If you choose to keep that the way it is, then for either version of this patch: Acked-by: Ian Jackson --=20 Ian Jackson These opinions are my o= wn. =20 Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 01:25:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 01:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407747.650341 (Exim 4.92) (envelope-from ) id 1oZ067-0005OF-Ct; Fri, 16 Sep 2022 01:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407747.650341; Fri, 16 Sep 2022 01:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ067-0005O8-A6; Fri, 16 Sep 2022 01:24:51 +0000 Received: by outflank-mailman (input) for mailman id 407747; Fri, 16 Sep 2022 01:24:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ066-0005Nx-Lr; Fri, 16 Sep 2022 01:24:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ066-0001Q2-IL; Fri, 16 Sep 2022 01:24:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ066-0005gk-4k; Fri, 16 Sep 2022 01:24:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ066-00035N-4F; Fri, 16 Sep 2022 01:24:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MOIV9vLo1DwGMaztbSDDRhPOWNkHcuqX26akNOcEgVk=; b=nhQEWzA9WIO7sjKnnKY/Ny7Mtw 3avZMNmrkP5ClfSahfTtH+kFMbW55ElMq7zbUVMM4mC1rAa6BsnsCs44urZurD18M46UQtDC3M4qm A9NGcbYfIu9nhXUmbddun97ouONbqqBee3S3eTQ3y8byT2vp40xsT+xGPv7792k6Rybw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173213: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-examine:reboot:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 16 Sep 2022 01:24:50 +0000 flight 173213 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173213/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 test-arm64-arm64-examine 8 reboot fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 42 days Failing since 172384 2022-08-11 11:13:58 Z 35 days 76 attempts Testing same since 173213 2022-09-15 15:14:56 Z 0 days 1 attempts ------------------------------------------------------------ 544 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17161 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 01:28:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 01:28:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407757.650355 (Exim 4.92) (envelope-from ) id 1oZ09i-00067P-4z; Fri, 16 Sep 2022 01:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407757.650355; Fri, 16 Sep 2022 01:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ09i-00067I-1z; Fri, 16 Sep 2022 01:28:34 +0000 Received: by outflank-mailman (input) for mailman id 407757; Fri, 16 Sep 2022 01:28:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ09g-00067C-UY for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 01:28:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id def8a726-355e-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 03:28:30 +0200 (CEST) Received: from AM6P191CA0065.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::42) by DBBPR08MB5881.eurprd08.prod.outlook.com (2603:10a6:10:208::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 01:28:26 +0000 Received: from AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::1e) by AM6P191CA0065.outlook.office365.com (2603:10a6:209:7f::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14 via Frontend Transport; Fri, 16 Sep 2022 01:28:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT017.mail.protection.outlook.com (100.127.140.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Fri, 16 Sep 2022 01:28:26 +0000 Received: ("Tessian outbound 8ec96648b960:v124"); Fri, 16 Sep 2022 01:28:26 +0000 Received: from 0f65c7b16b00.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F0740137-3EAB-4398-9B57-5CDE1FB12FB7.1; Fri, 16 Sep 2022 01:28:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f65c7b16b00.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 16 Sep 2022 01:28:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6679.eurprd08.prod.outlook.com (2603:10a6:20b:393::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14; Fri, 16 Sep 2022 01:28:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::b46e:50dd:b6e2:5241]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::b46e:50dd:b6e2:5241%4]) with mapi id 15.20.5612.022; Fri, 16 Sep 2022 01:28:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: def8a726-355e-11ed-9761-273f2230c3a0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jsn57Vd0d5YqaKTE4os6tefSH4p0zjUu+Fgu5K3/b4V03INmxHCYz9JEdcviCuMJ63yGPeLso4rELsLI7teTQan3wClY4/9uam6Zr/iCkxlJtELa+AX35fqr/Zl7LwooGXZ5TZM55Yj4fgjeA2qNiGO6ePl6W6Rk5NwEYdEViAAN8QojilBG4ABjl3M8cqhqSeT+5jtRpawBGZuGUEUxhuurDck8F1k1l1iV2dozJnoBXdKTNhGdz2tXl1/Aevmqu7Nv+iPFhD+qtPiaYc0Ujt4UDigA92JPhzRyg4PbZKHCjCT3fUofsOagPFU2L0jTbvAtdWFXBwlEvfZtFwXUOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGJBZmrYN4//JR3hztF/NkGFo7HtMvqGf3BpixGCW4U=; b=mb1oGlRBfGFSBYamUQajfzurzuW9cDbIn1wo9whyJrrkekncbuJg6Yoal69A7afk46gHsmm7KIvjltqQa0+Og9Osj8W+KI0Nap/abOgV0r5RKHGVCJXmEmBkrrfB55nHThKa3naVKlpyVkY+V+a9kHn/TK+CE4icppvjcd0t4ekbZ96o6pl0pzpwLZwTMuUbqTKv/iwOTd7d7fF1tOOPLEnSx9cvHMzaNsNDLeLzAbZG/gDYaZd03siY2T45wrQT/GUFMeAH6mBTVhNlN4D/IpvwRnEwp+53STjftfp+ScpBjppj9MLDVpnRMC1sXv8ahbKfMY/NglzTTchRG4/Q4w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGJBZmrYN4//JR3hztF/NkGFo7HtMvqGf3BpixGCW4U=; b=rl+/1uyC+0OE4p3oZtLz0j58ABG+gyNbHZDr7DMw4HQZALv1BBtSMQr4y6v9YdRE8C4JrlSDIuDIEjCFEn/DJaOX89spqMIBW2osq45i/9H1dX103oaDV+X2yTYvC4KOOBkFi5owtEs39meg4VafUp4RnttzsaeWOXlDoUKZyec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eWTXWv4FeIb+poS2WZb5Pf7V0BszDTgw+pi2Fld0GLOST7nlshy+6Z5wI16vNiLVjYh/2qDsnqK53OuC+XE+aTnd8tEtK5q8q2X4Spd1JCszmjff023rSD2F7U2gXmOMYw+2OP4T5pBJPBJoat/kClJ4F/h3yqe1KB6hX/3ti+Rqisn52e6kTyRmfrMm8jX7vjj4ZCA4QNNmHASIu28l0BMla/dsguvMlzdB8Djtkw0tEaKxiBcJjNE7BkEuVzdZzOVrxu5BYCWLyTjq7EWIDqo65Q/kmQuseGRxqOD7+cZ28q6xsWjRh+yUb8/HjJr5nsemb9Eh9aPnS86T+JdUcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGJBZmrYN4//JR3hztF/NkGFo7HtMvqGf3BpixGCW4U=; b=ZrkfrVdc+hICdIEh/uF8cU11Wm1aS4Vr0wiiu8a09dP/KJfKXf87Xo5aNUfavmzcaDRZKDsvIfwbqr/fpeAEPKTq/yPsqu8ZuL9ZShpXe89JoGE3vrqsOpVVO04+p5Jzep22vhT7pqCeX94RZb2zQEpAe1Tv9wU4ZdEErd9h6cDN4AsvlMk8mBWpULAMV5243XjR9tHvjpna1QJwTZLUcugMIeDAGhYJ+fCnFyt1FEE8Y4ddC4XSbL0r2XPJ/OapVkOKUACOKwv95gQau953MLKCfBLTiK+IRRySzTdjN12otEkP4LNzYv2k5UxAcTmvs5a+9uzBy4hwyFV7fwOTxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGJBZmrYN4//JR3hztF/NkGFo7HtMvqGf3BpixGCW4U=; b=rl+/1uyC+0OE4p3oZtLz0j58ABG+gyNbHZDr7DMw4HQZALv1BBtSMQr4y6v9YdRE8C4JrlSDIuDIEjCFEn/DJaOX89spqMIBW2osq45i/9H1dX103oaDV+X2yTYvC4KOOBkFi5owtEs39meg4VafUp4RnttzsaeWOXlDoUKZyec= From: Henry Wang To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Demi Marie Obenour Subject: RE: [PATCH for-4.17?] x86: support data operand independent timing mode Thread-Topic: [PATCH for-4.17?] x86: support data operand independent timing mode Thread-Index: AQHYyOqob1u+YVxpCE2QK+LaZq4Qxa3hRDCA Date: Fri, 16 Sep 2022 01:28:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 10295DA66DC7214D89E168760DBF730B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6679:EE_|AM7EUR03FT017:EE_|DBBPR08MB5881:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cb89abf-ba73-4d72-00e2-08da9782c0fd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: s4UfP9epayFhNIgao3Fo39KkIkbfUVSdKNnwRsEP2c6D0z9MO29+RQS9QKwkkvKlrxaw5BPb9CCbuJmr2Ej8aXRPHMe2QbhPcqkJoWUgYKfOMwF4ij1EqNHb1nAAWQeFcxLzd5hrhAcpqVIrfklX0+PpygM2iHnPB7yMv6kw150skN1Q1YMIogFZ/j5Ox5VGB6FDTnyUe7AL8or+lzmT7MVlAN9VZQHOMK0Uz/XIZ/Wo84d7rLwoesaCrQGVV4UZyyxtm+lTjVwWvxyMkB4GN+uyApqUbXggXSkex2pNd+dOgBkpDCgPWIzKb2SX1hyEIKa1T4ucmfl6GWwXCjB8v7YmaG/oyRyLMh7Uq/yWH8dRjUNjODSB5NSzeXE9N1Bh1oarw31MijCC3kQuMB7QNMEzhxCaJlTP780Z5Q6vVZ5TaRshUZeEAQ8cG2a8HWVp4ppSp/IOeskTSjb93KN4OhI9eUVr0W5+sp7ofrsrqW+dSpoZzSnSqxU2d7zCLFAMu2tJW8QKPqHU4jX3Pq4d1vtHhpVO1AGUcT8CdLaCjU9LkTTXuI7ROwbISeZ1gYvWXn+f0R8B81VffsxJGEmF/fBGX+ypjtSmzEQ841l827pWhvy5yyplhTKazBv/asoYkc7oTqA1/t3AqapyuQ66HvEgRqT05VmP6YZ+IoEmiwNL97Z+n3jn56ni41vPO7qxnPVvLqVbdCLaxc9n/D4pUrRcuPmbTVGvnELIE9l3EtrtpwvboMPQPCD2p+a2jG1BQvoIOs1O+PPASrq8NHVcrDiMyk+55rfLPbBoTU5P4p4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(451199015)(66476007)(8936002)(64756008)(66946007)(76116006)(66556008)(4326008)(66446008)(2906002)(8676002)(52536014)(5660300002)(966005)(71200400001)(478600001)(38100700002)(122000001)(54906003)(6506007)(9686003)(41300700001)(26005)(55016003)(316002)(33656002)(110136005)(7696005)(86362001)(83380400001)(38070700005)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6679 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cc602f11-6cc1-46f1-ff30-08da9782bc63 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NuT8TjcFq1oaQSP+f9hfrimE6e0I6JuwX638TYP1SOAJIJhpOibxpqZ3B9UCQbQ+iaSHzaCa+hIh0bExyuUoWIgRtBOIuS1SVrmNJt/U0/dhtvutp76sl0I21g4N33+7omYkIz/z8C13kRtbLVDb8nKRbnjVWu980E7yRCo3GsTbPV4qYLAfN7KKpcwRxRuHaJC47J689uUlJF//08T71dDjJBvJkAAnl6YIXHQK0aZvHe2QOjosBDZdvlicBBi+YKlzqgHsjyNMONJ6G/TGOjeid2CUUOi1tB9oyVmPxkaEoutK5LF3BaNz2L1lBWjiojExhuvH1W3fTc49tpc0xang2AyNYEycaWzYGcWsE0+e3q+fRt5eybZJgP29Cy8qTaEdfCSmaT4JuHh8JxyAe5V2xKx1q+2+8SJY4iOOWqW68UcvTbrepZDmqRTn83zrNWWfYgTSIB9Avc00/WIjhR10RnCj2l2WXvYM8SfAQRojipRUfeFd3XJC0u5jU/eqazEwWBCHtYRVcm0808XjuB2L92M2jGTZZaXP/UY20t/C/KCgPa/EnoT+0Rr5ZH+T1EQPIK6Tu1HfuKLx5EVsSoOYqEAAkScxpJFrmMVy5HJ09D+z2z1vdV81aPOGJVoNR+dMQh6pNW8WNCY6X27C2PXjUKJVCPghzJ7OnYrgvE4P4QbgC6LC04AWm6337O0LvqkY2aZ5SdGDmSEvqflcaTo+RBj9oiNQfk862xDXvOm1hRFSjqAnj97JdgBz8lt5ioB6sDOuwBh1lXE++Z4pYlSxhJPbvgGTVtX3Nq6fFsQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(81166007)(2906002)(356005)(5660300002)(40460700003)(82740400003)(33656002)(26005)(9686003)(40480700001)(966005)(41300700001)(478600001)(7696005)(86362001)(36860700001)(8936002)(52536014)(316002)(336012)(107886003)(83380400001)(6506007)(82310400005)(55016003)(186003)(8676002)(110136005)(4326008)(70206006)(70586007)(47076005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 01:28:26.5070 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cb89abf-ba73-4d72-00e2-08da9782c0fd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5881 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFtQQVRD SCBmb3ItNC4xNz9dIHg4Njogc3VwcG9ydCBkYXRhIG9wZXJhbmQgaW5kZXBlbmRlbnQgdGltaW5n DQo+IG1vZGUNCj4gDQo+IFsxXSBzcGVjaWZpZXMgYSBsb25nIGxpc3Qgb2YgaW5zdHJ1Y3Rpb25z IHdoaWNoIGFyZSBpbnRlbmRlZCB0byBleGhpYml0DQo+IHRpbWluZyBiZWhhdmlvciBpbmRlcGVu ZGVudCBvZiB0aGUgZGF0YSB0aGV5IG9wZXJhdGUgb24uIE9uIGNlcnRhaW4NCj4gaGFyZHdhcmUg dGhpcyBpbmRlcGVuZGVuY2UgaXMgb3B0aW9uYWwsIGNvbnRyb2xsZWQgYnkgYSBiaXQgaW4gYSBu ZXcNCj4gTVNSLiBQcm92aWRlIGEgY29tbWFuZCBsaW5lIG9wdGlvbiB0byBjb250cm9sIHRoZSBt b2RlIFhlbiBhbmQgaXRzDQo+IGd1ZXN0cyBhcmUgdG8gb3BlcmF0ZSBpbiwgd2l0aCBhIGJ1aWxk IHRpbWUgY29udHJvbCBvdmVyIHRoZSBkZWZhdWx0Lg0KPiBMb25nZXIgdGVybSB3ZSBtYXkgd2Fu dCB0byBhbGxvdyBndWVzdHMgdG8gY29udHJvbCB0aGlzLg0KPiANCj4gU2luY2UgQXJtNjQgc3Vw cG9zZWRseSBhbHNvIGhhcyBzdWNoIGEgY29udHJvbCwgcHV0IGNvbW1hbmQgbGluZSBvcHRpb24N Cj4gYW5kIEtjb25maWcgY29udHJvbCBpbiBjb21tb24gZmlsZXMuDQo+IA0KPiBbMV0NCj4gaHR0 cHM6Ly93d3cuaW50ZWwuY29tL2NvbnRlbnQvd3d3L3VzL2VuL2RldmVsb3Blci9hcnRpY2xlcy90 ZWNobmljYWwvc28NCj4gZnR3YXJlLXNlY3VyaXR5LWd1aWRhbmNlL2Jlc3QtcHJhY3RpY2VzL2Rh dGEtb3BlcmFuZC1pbmRlcGVuZGVudC10aW1pbmctDQo+IGlzYS1ndWlkYW5jZS5odG1sDQo+IA0K PiBSZXF1ZXN0ZWQtYnk6IERlbWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3Ns YWIuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ DQo+IC0tLQ0KPiBUaGlzIG1heSBiZSB2aWV3ZWQgYXMgYSBuZXcgZmVhdHVyZSwgYW5kIGhlbmNl IGJlIHRvbyBsYXRlIGZvciA0LjE3LiBJdA0KPiBtYXksIGhvd2V2ZXIsIGFsc28gYmUgdmlld2Vk IGFzIHNlY3VyaXR5IHJlbGV2YW50LCB3aGljaCBpcyB3aHkgSSdkIGxpa2UNCj4gdG8gcHJvcG9z ZSB0byBhdCBsZWFzdCBjb25zaWRlciBpdC4NCg0KQmFzZWQgb24gdGhlIGRpc2N1c3Npb24gaW4g dGhpcyB0aHJlYWQgc28gZmFyLCBJIHRoaW5rIHBlb3BsZSB3b3VsZCB2aWV3DQp0aGlzIHBhdGNo IGFzIGEgc2VjdXJpdHkgcmVsZXZhbnQgcGF0Y2gsIHNvIEkgZ3Vlc3Mgd2l0aG91dCBzdHJvbmcN Cm9iamVjdGlvbiB0byBtZXJnZSB0aGlzIGluIDQuMTcsIGl0IGlzIGZpbmUgdG8gYWRkIHRoaXMg aW4gdGhlIHJlbGVhc2UgKHdpdGgNCnByb3BlciByZXZpZXcsIG9mIGNvdXJzZSkuDQoNCktpbmQg cmVnYXJkcywNCkhlbnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 16 02:16:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 02:16:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407766.650368 (Exim 4.92) (envelope-from ) id 1oZ0uG-0003Jq-Sj; Fri, 16 Sep 2022 02:16:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407766.650368; Fri, 16 Sep 2022 02:16:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ0uG-0003Jj-PT; Fri, 16 Sep 2022 02:16:40 +0000 Received: by outflank-mailman (input) for mailman id 407766; Fri, 16 Sep 2022 02:16:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ0uF-0003JZ-MQ; Fri, 16 Sep 2022 02:16:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ0uF-0002jj-Ka; Fri, 16 Sep 2022 02:16:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ0uF-0000u4-7D; Fri, 16 Sep 2022 02:16:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ0uF-0006VW-6l; Fri, 16 Sep 2022 02:16:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g4MgxJHaGG3lzGJg9CfKsZMLNd8TAtEgsfkF7CbhKkc=; b=zVoa0zkNWVxtqUZfnJ96bzafDD JI7qK0WFClmh9IOsOnOsCi3jhpK4LUtvjwZTDEtsBBHQ2QecA7IIh+XL6mPzgiM8NMdMtdNWnBg4w 9cOxgGK9a2v8sr66cMIM5mBUSQs6CmyAZ5qlv9QCJs0s2mREv9bVy4oSsMx9PUe4ovOA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173222: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=3184e44df1042ae41c1cd8d2acaa47d7d30cd07c X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 02:16:39 +0000 flight 173222 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173222/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 3184e44df1042ae41c1cd8d2acaa47d7d30cd07c baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 42 days Failing since 172151 2022-08-05 02:40:28 Z 41 days 317 attempts Testing same since 173218 2022-09-15 19:13:25 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2616 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 04:26:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 04:26:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407774.650380 (Exim 4.92) (envelope-from ) id 1oZ2vG-0007h8-R4; Fri, 16 Sep 2022 04:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407774.650380; Fri, 16 Sep 2022 04:25:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ2vG-0007h1-O2; Fri, 16 Sep 2022 04:25:50 +0000 Received: by outflank-mailman (input) for mailman id 407774; Fri, 16 Sep 2022 04:25:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ2vF-0007gr-N0; Fri, 16 Sep 2022 04:25:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ2vF-0004vV-Be; Fri, 16 Sep 2022 04:25:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ2vF-0001Fu-0I; Fri, 16 Sep 2022 04:25:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ2vE-0003lI-Th; Fri, 16 Sep 2022 04:25:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P2MV0KInYaYVBapgLC2MRg/w6U9G6e1GCTHalP9kUKg=; b=qMGCcnPGWDhq90GRhQq74ZGob3 CLdTYnlI8y9MngjUfuET4djxNzkslcC015SZOktQK4Yn8z7GtZRe92TrVe0V46ju7dSiDYJSqoVc0 XY/JhIPF27d2BZ8+JdBtzGAYVqjvWzDEu04GQnRiPiMAwlZgLg4YzKe4TvlEj2E1lMAM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173219: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 16 Sep 2022 04:25:48 +0000 flight 173219 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173219/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173200 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 173209 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 43 days Failing since 172148 2022-08-04 21:39:38 Z 42 days 96 attempts Testing same since 173060 2022-09-08 07:34:59 Z 7 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 05:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 05:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407783.650391 (Exim 4.92) (envelope-from ) id 1oZ4MZ-0000Pq-OW; Fri, 16 Sep 2022 05:58:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407783.650391; Fri, 16 Sep 2022 05:58:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4MZ-0000Pj-KO; Fri, 16 Sep 2022 05:58:07 +0000 Received: by outflank-mailman (input) for mailman id 407783; Fri, 16 Sep 2022 05:58:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4MX-0000Pd-EI for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 05:58:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60041.outbound.protection.outlook.com [40.107.6.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86b722b1-3584-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 07:58:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7493.eurprd04.prod.outlook.com (2603:10a6:20b:293::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 05:58:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 05:58:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86b722b1-3584-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alwNkLk8Xuv5SakcKwcrOe6z2XET3Fljfl2A9Atju+pEX5ZClyE9pNkS8HfxfSVXcvyqDX6nAmNPs80l8nbw5tmz6cEsnlS2pIhl6DpqctWHROkSIbXj5gJ4KrEexPIzQBGFz1KWvZRFmloaDBtoELMBcfERqRKEaC0ZcpAeTiwkrlO/2/7l9nSuJGxSQnFaop4V6MqJgB9GcQTds/OVCmCyPOnRtdH+SHkZbqlypSQjWsJ2bWQSDrsRRSze1Al1PruCb8KwxGOaTnfpYlKZmZMaPy+xutSItQgrC70XOWJVv3RzTYSkyofbGFPXO6E5g4dy/7KS0Gr0Af2I3vWPRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=67A3P69kv1ZBb0fhpT24bmWX6p7laKPIKjOQsCMuCao=; b=ZXWq8E7iNHtundmTyWNS9J73QGJp3VVGaL+ptb+5RjIkgj4FU1BLjF81t/5BrxN+cSNt2Ycrk2ZoY9t52e58eKvQran9Hzm7kBveV8WSc11/CHC6OtYFmzy7PWEgihTytcwUDBSAAzdcF2/M8iIdv/VyYP/e+VT3lYBqZrr8jsfFVuXlzsd3psQnldhf4A/5w9Aszyx9ThZ4J5xtrJFll4i3SYerAnBPjTaNODZ6GazZVXIr7SaKhoTLgCmsSuW5EJJ6ONKFRPpkLcCwIEmiK8hklJqZVwXjcLRWA5FEZe6pLyCOcpB/vXIe7p2Ws5Vy0ZoSwDymZCSjjcYdtkX0iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67A3P69kv1ZBb0fhpT24bmWX6p7laKPIKjOQsCMuCao=; b=3GDwhtvX8WqydwNp9DNbIzK1nUkWSxw4KroQI9Bkl9V8vCwKZBNWQLQZXy1RTa2zmOCjDCC1BaabU+0J318LdDLDam6iXCKRUktm7dhcBttGT/g+2vye852VjeddEibeZdZK+4C/NvVTx6XzpLswfKx+tYnHdrEufgCE2GjQaQ+nXsYKimBI8mFh1mhvCMO6ove19Ifqga+p4GEn3dIlcsQhq/q7251SNb6im+tr4n3UsrDndBh/O+hZ7YaBc0RClpZOvGGUHqtpyT04PV1eO/1nN3DbqvF4Rz0BxZno7gpt2SWndQJsj1dPOhxJpNM4jLlgJfyuOOHjJNe58K5lIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> Date: Fri, 16 Sep 2022 07:57:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Console output stops on dbgp=xhci Content-Language: en-US To: Tamas K Lengyel Cc: Xen-devel , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0090.eurprd06.prod.outlook.com (2603:10a6:20b:464::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7493:EE_ X-MS-Office365-Filtering-Correlation-Id: 40cc1c55-1648-47d2-033a-08da97a869ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FGdiWJ7wOq4dxDUlCW2b+XAAqV2i/Aiw8U8Pb2vMFpBndiqE2dAkTXoJhi850MCQHIh5OjhMUagf80aye4Ffhmh2n8tXXI1CZLavBZ1Vcod2WM2PzVEk6Zc+pZzbUvG8QKS4TppOsP7wycyw13V8gILJ5l3h3jeMJGqyCi+acUQUfRNiUv4qTBCTm7EJCJ48GiK+qP6CUExnttfJOQgx8W+BfZSZEVRvwm3rT8TBbzOcT9VaG+j6ca48vHPWJOgHjGvy8RvIotMCOSQdGMzxF8RD4iaEgz2t+Wn2dHrHEmn32Dh+LQKGzTx8F4PzgKXTqsXmkkjgd9THSB9os6JMsBZKVGww41SJaMEOqrFGX/Iaye8uG7dGgvwBYQI0PFp8M/S8LvDYo/5Erp1Gt6bx0Y8y4fUXX3d0f+xsTPL455XYm2TEHEwrZy2ItX73DEP+P6Hp77ZXf0DXWYQEGu72NXlepL/iLswRqzfXH7jP8j4aOQ9nhyxXt8bVOdqk7ENg2Hur9yhOR5V9vjiQKgjWmyC2fzrsnz+uUlx2VwkXbb2iETJJAUl2L5008AR6ekcBD/r+LZT0/d8gCSvqpJBtNzd+zRkwbyhK1HkJHdI/ysk6gPZcYYICkFbiv5A/yH1m83mxgZWcA5oPKpiOb3wCAw5ey3VjTZCxV7qxulZlvUvSCS+s7PteW47krF+IT0GBC6ySYQL+ChMqXX33CHYR42OYfwLlqln6bbTzL+eIeQzwpYmrBVrFnpuaeaZURnyCLNJT6SClQuh4gmv++wmhFi/wC1E0iCKXGHBYkfbwkUc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(316002)(36756003)(6916009)(31686004)(86362001)(31696002)(2906002)(5660300002)(66946007)(38100700002)(8936002)(66556008)(66476007)(478600001)(41300700001)(54906003)(8676002)(4326008)(53546011)(6506007)(186003)(26005)(6512007)(6486002)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVVkSXJiUGx5dit3SURrYWVNcE5VN08vb0o2UG96L0hkMGpJQXhvc0laeUY0?= =?utf-8?B?eERvQzVWeFFkTVVaQVkvWHVoQjh6ZUUwNzlFTDJpVnhzVEZ5WjBmMDFKTEVH?= =?utf-8?B?bVdLMDV2WXo5c3BqTGFVNkhMV0VnYlJweFd6U3k3cVY5REFuM0Z4QkZwcmtl?= =?utf-8?B?K2ZTbndzT3I5QVkwbjdtRWRvUnBmdTVtQW9BZ1hlc2xrOVRyUFovdW9rM0Zt?= =?utf-8?B?b2lSOGVpVitDeExRR3cvZDJQRFVmS0x5RWJKWlBMcjRLZUdpUmxQL0JyRUZE?= =?utf-8?B?ZW9jVHNNa3ZFUzFRY0tFUlBobzR6Ymt1enhIZ2c3RnpWcjE0VGVsWlo3ZWg2?= =?utf-8?B?WmJhMmR3RjhoMlVtOW9mNFUzbmo4Y29raUNKTXkrWkR1YWZqQmpoVkNBTVh5?= =?utf-8?B?dDViOEpUSTI5UFZNWnZ5TnBoUEc3QytDLzkrYjRiTFBNSHFYOE11ZnExTzBk?= =?utf-8?B?cnZNVEVCdXpnc1BUeVhoMVo5NzRwc3JuT05YaVRxYWZCUHFjcTg4RkEvT2Vz?= =?utf-8?B?UmdkMzlIRmhYVk85ajl6MFFNWU02S2lOT29kMzdCb3o0TVcxQWRzcUtCcHR6?= =?utf-8?B?cGNla3QvaThiRDMxKzIxRmZvYjFPaGJES0NOMFUyKzcyK1k5NkRJdk9ZMFNj?= =?utf-8?B?Umd3QS80UC9RbTV4aDNsTXpHZmlEU09pSm9yMTVXNmtpRkV3ZTdXV1k0Mnc5?= =?utf-8?B?NHl5MkFjUXM4RUZPMDdlbFNSbG92c0NMcGZDWHp3NVM2VkVRS2tDLzhRVVhi?= =?utf-8?B?WVNtUW42M3VPSDExVzNOcUtBOXU2L0V3Y2JHL3oxUEZDaGRaVWJ6eVhWYkho?= =?utf-8?B?dzNIdEJEYzFxVXZYMnBCZ0Y1UkhXemFJamRCZVVIb24zMGh4MDFYM1cyYjdW?= =?utf-8?B?VzNhbnVwVUhITmNDU1FjallTOW8ybGlZT0xQTFFVZXBxL3N1QmQ3Q1RRRFR2?= =?utf-8?B?SEUzNU9YVFFOY0tsQ3JWRTVkTzBMNnRGMlE3cGRkS2hUeFJqbFFyUmtkN0dm?= =?utf-8?B?RzRWdlhiWFU0UnZzN3QwbENzcmYzZ3FkYTZCTEpsK3FwZmFVR2VTU2tKK05B?= =?utf-8?B?Y05sbG5MODZ5UVRjcVo1NEwzWHl1MjRwTmpSZVNxbzRPQ21DcVUwb0UvWjJr?= =?utf-8?B?dUhoUDR0dC9rNUo1QlRxS0tMK1pxWmJ0OGlQWWthRWU0YUNhbkZlZWEvM0p2?= =?utf-8?B?ckNTRDFPTkhXRWRvYUIzVHB6NGMvaWQwVUQ2VWhuVjNCNGJRYnhEeEhvSUVo?= =?utf-8?B?S0tGZTMzSHNSdWg1eFREQ3pnT2lYcjRNYTVvZ0VrV2VWR09oYTUxN3hMbXRp?= =?utf-8?B?UnF3cGRhYUEySlIzM3g5Qit3Q0svVm5zbVVUWGMrcGJzQ0Z2RXhnSFFVeEw4?= =?utf-8?B?dW00RFBzWmlUQ05JbFgwcG1Nc0E1TXpaNU0ySmJzc0NFWFRWTHNOV0U3RVRH?= =?utf-8?B?ZnkxNG9hellWa1lrcksyajQraVpGcEU0WDhWb0MvcmJkTHBVWjJ5enFBd0E4?= =?utf-8?B?dGtPMDJnNjNTc2NYcmxKdGk3QmZyWDFoSmVKcysrU2hPSWZ3b3hUc0ZjcFZl?= =?utf-8?B?RENkMmxCNFJRZ25xQkdJcS90WXM0NUNydHcxZGlzNFRGUmQ1NlRQMmdZYlVD?= =?utf-8?B?TkRMNm1IOXVLdytDKzZ6ZkhMK3FjSjJzRzhkaHFwUWNBUUEvMksxbjdmM3p6?= =?utf-8?B?djhabVN0aXZ0TUxvSE02N1paTTEvbkdJMlhucUsrSFJxRUUycmhCS2dKRWJF?= =?utf-8?B?TE1JQTdmVGZGS05hVFlzai81aWtLcWVjUFFTLzNqMnR5UnpmNy8xeWVGZzZL?= =?utf-8?B?ZUt4RE1tcmtRVWRoNktUK3pDNjZnRVFSSThqMmRsR05ySUo0ZGxRRk1HQUNz?= =?utf-8?B?OXR0WmRYeGRsdC81bzEwY1FBbHlLbTk1c0szL0N5MUkxaE1hdkx4d3JSSUcy?= =?utf-8?B?SzlxL3krQXFzdnQyUWlPdjFjZ2o5WW5WcEczRUVxSXI1amdRK0E0clFNZllV?= =?utf-8?B?RWpTblVHQWtmbUFXTmxwU0VaeG9HZkVvTkkxNjZyZ2NPYTdvNlJuTzFxSHRw?= =?utf-8?B?d3dWUnpSSXk1VnBHNGNjZUZvQm9nandzMXpCbERodHpTMjRUUmlXVWlxQ2xx?= =?utf-8?Q?i2Hs3AX6Ewmm/UeX2sV3vAdWa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40cc1c55-1648-47d2-033a-08da97a869ad X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 05:58:01.1780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nf0AHExedJuXATR1tGoEFXIjH8w4kE82zQZrOTCWrSyuFrUYvFKwcuJvE+O99WyFOmMFnym1Q0C/XaSIO44uXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7493 On 15.09.2022 18:48, Tamas K Lengyel wrote: > On Thu, Sep 15, 2022 at 10:39 AM Jan Beulich wrote: >> >> On 15.09.2022 16:16, Tamas K Lengyel wrote: >>> On Thu, Sep 15, 2022 at 10:10 AM Jan Beulich wrote: >>>> >>>> On 15.09.2022 16:05, Tamas K Lengyel wrote: >>>>> On Thu, Sep 15, 2022 at 3:56 AM Jan Beulich wrote: >>>>>> >>>>>> On 15.09.2022 02:41, Tamas K Lengyel wrote: >>>>>>>>> Do you have any idea what might be going on and preventing the output >>>>>>>>> from showing over USB3 afterwards? The /dev/ttyUSB0 device is still >>>>>>>>> present on the receiving side, just nothing is being received over it. >>>>>>>> >>>>>>>> There are few more patches in the series that are de facto required. >>>>>>>> Especially those about IOMMU, otherwise it can only possibly work with >>>>>>>> iommu=0 (which I'm not sure if even is enough). >>>>>>> >>>>>>> Unfortunately with iommu=0 Xen doesn't boot at all for me. I see this >>>>>>> on the console: >>>>>>> >>>>>>> (XEN) Panic on CPU 0: >>>>>>> (XEN) FATAL PAGE FAULT >>>>>>> (XEN) [error_code=0011] >>>>>>> (XEN) Faulting linear address: 00000000328b3a54 >>>>>> >>>>>> Perhaps in another thread, could you post details about this? I guess >>>>>> we want to address this independent of your XHCI issue. That's an >>>>>> attempt to execute code outside of the Xen image - the only reason I >>>>>> can think of for this would be an EFI boot services or runtime >>>>>> services call, with (possibly but not necessarily) quirky EFI firmware. >>>>>> Any other context this is appearing in would quite certainly require a >>>>>> fix in Xen, and I don't see how "iommu=0" could affect the set of EFI >>>>>> calls we make. >>>>> >>>>> This was indeed observed with a xen.efi booted directly from UEFI. >>>>> Beside the limited boot log I get through xhci I don't have more >>>>> insight but happy to send that (and anything else you think would be >>>>> useful). >>>> >>>> And with "iommu=0" but no use of XHCI it doesn't crash? Or there you have >>>> no way to collect the log then? >>>> >>>> In any event, from your description the interesting part might be the >>>> EFI memory map. That ought to be pretty stable between boots, so you may >>>> be able to collect that in full via "xl dmesg" in a run without "iommu=0". >>> >>> I see the same crash with no xhci debug use. The EFI map is: >>> >>> (XEN) EFI memory map: >>> [...] >>> (XEN) 0000031f72000-0000032a95fff type=3 attr=000000000000000f >> >> This is the entry covering the address, which is EfiBootServicesCode >> with no unusual attributes. Assuming the crash was still during boot >> (of Xen, not Dom0), do you also have at least the full stack walk >> from the crash, to know where in Xen the call chain started? > > I don't see a stack walk right now, but it looks like the path to it > is a previous panic that wants to restart the machine: > > (XEN) Panic on CPU 0: > > (XEN) Couldn't enable IOMMU and iommu=required/force > > (XEN) **************************************** Okay, so there's a panic initially, and since it's unlikely that you passed iommu=force alongside iommu=0, I'd assume it's because of the IOMMU being needed to support running in x2APIC mode (earlier messages would tell us). Then ... > (XEN) Reboot in five seconds... ... this leads to the crash, which effectively tells us that this is likely yet another system where one needs to override the reboot method (e.g. reboot=acpi). Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 06:09:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 06:09:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407789.650402 (Exim 4.92) (envelope-from ) id 1oZ4X4-0001zz-NJ; Fri, 16 Sep 2022 06:08:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407789.650402; Fri, 16 Sep 2022 06:08:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4X4-0001zs-KN; Fri, 16 Sep 2022 06:08:58 +0000 Received: by outflank-mailman (input) for mailman id 407789; Fri, 16 Sep 2022 06:08:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4X3-0001zm-Jv for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 06:08:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c08e012-3586-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 08:08:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8695.eurprd04.prod.outlook.com (2603:10a6:10:2de::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 06:08:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 06:08:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c08e012-3586-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JGdBU4vqOs41jEUSPNhHcutp+2VTFAB6spQSAzXiuoOuYPGNt5b6A9Hx9wXMKjU7k3+PlFWcRWLcVTtaLKnDOrwy3SMkPPrnuO3I6wYUEyWDGz0FvxKe0F89ujMvJxs+vUmWeWCOP9u5w1ktUvzfBv2BMkYAOUwfp5wqnYOiboqz++ZTIQNcUY8ztVFS8tL2hO5xbwsjbkBZT1VsTav0yHlbp31oC+vaA6KeIXvBpRq3hbAQYaAuxJo0Qdkmi4dUtEvNQJJmpHzRGmLf4rJwbT5vaJjosJw9CDcLmnnO9rGxFTOYFwxRR9pjiMDMCGXuBM+GaCrPN2Mqf1/qQjoFyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XUvv/nHbW3/gUK+CygDDfpL/8c04TM3bWPa4V5IJR8w=; b=R4NRhYZ6lSrM3MkPZH15X3n9PwXFzpxabsdJGDL260ltrKdZkuuJjWeemF5letHWC2TZvkO862ZHokDBp2TE07gsV9LcGijrjbFyxbZVGS50kxpz8Vf+JmLCYS6nWIVk/LZ08Mg0HCgcIvNV9vsoIAEstylNAMoy4qNyshq5m8r0xUyfiHveTrVzFPUt1TvCxAbUPN7Mh8NRCB6CYJTyaR+S7WdQVbKL0vrjT3pL7AfwcsQrToFs8ROKir5z1za6UN0rkoJyig3oLm1zBqPpSJnr2PPZT5fdkQPEKFNLuNG0IottysGm7qarUb//vDxhJ0OaHz9cenVvnZnGamtMrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XUvv/nHbW3/gUK+CygDDfpL/8c04TM3bWPa4V5IJR8w=; b=V0oHq1sXUtYaAexSve7k8IJxVVPOGedqQcoTmdOFHwhTwgGWLYVxOnrfjZH8ZWdhzbde6f5nvr17bF7KbLw8SRbXjmi6FeqTNGT3Sj/OqmWsmoxZR89sX3x/mB0fLh7zQdED0d+rqiO/dMZcSs2CRoOotyD3VxbPfsThg4Mvmk6S8RuweVRNNAG3KkM+InznBtEW0ahtvvfrROZnhsf8yEtgp6sc86JwaPM39/fzaPfUt6o740TQZTwm/sIDTirh/4UUKWdAw0LIuNZu9RDX84qYl9XGXXonxaUFqxkUm2ybDs2kluMREggPEp69yLGhedBO1TtIczu8rLAn53iAIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 16 Sep 2022 08:08:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] MAINTAINERS: change my email Content-Language: en-US To: Stewart Hildebrand , Henry Wang Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jeff Kubascik , Nathan Studer , Robbie VanVossen , xen-devel@dornerworks.com, Stewart Hildebrand , xen-devel@lists.xenproject.org References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> From: Jan Beulich In-Reply-To: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8695:EE_ X-MS-Office365-Filtering-Correlation-Id: 262d954b-81d4-48f1-dc66-08da97a9eeae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4h5EF6ee3Do0Z43QXD+8vri0V2gd1CBxAI6DNnCVJa2MEMoUKU8t7c8KPegIF9n8HRAAgwPMo+Id7BPzgECXUo+RVlzUYFesakdTIjX2U4htwLYf1aMUZxsEnd5s+CqrwcNS4PNCiGkyeP12z9j2FKxnMtCZEJ+gt+3ibyAEV+UuOS3vAbrA9BkRkGnCdFMGy7eYLKstvQmJ+8Ypx5wzkeFgZrg0SxYoq4B3Vp92mnk6BepYscAykIPKWPPYTCqmSTP4Y81QCSC0UVXWdu7eniICSQ3LBL+jLK85jF9+EP4rjQDOvLOE+zEXLdN4PYyJwWN+l03m9hUoUK0813fmBLvoCiP/jXnpVED0OjpfBdx1tdUExeLzTmFOzA3h0yUBwyKwb8yqkdHPHcsj4F5IYZhwrvli3Y2IXDtqIMmE3udN1iVjSws6vmoqLtjxH/RMSrFJSvXThLZFTZqIi7eTu41CvEBuLGKpWsJw47t8L6os37zB0GDW78jXxuXU7N7Zx/pQDYlPfQ9DebMOOgPz9TMJee2jvtVhM6+chqNPTmFhei55YjLPmGeC/G11kZ9fY3cbMb99P7O2uWww2OwrgMNf7Ukm9wZ1dd8lsOAoWIRgHPtYpNxbImdfG9E4dZTbQ5r8yBeEqKpBW6RzJFK/f35R6yQMX7xA1P1rRRLbUE/4Nz8YvnBTmxHL6EneoLMd3pQjF9e5vZJFY/FskXQJ08Q0cJmqag7Th242IEEN6RAnJUMb6bN3flvjo0EfG0bSHKRDUWIxStPF9n9O2VGEqfAcj4ds3A4izYtlUYP8QYI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(6506007)(31686004)(53546011)(7416002)(31696002)(41300700001)(4326008)(66556008)(66476007)(66946007)(2616005)(2906002)(86362001)(110136005)(6512007)(54906003)(26005)(316002)(83380400001)(8936002)(36756003)(186003)(5660300002)(38100700002)(8676002)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDFkYkZ6S1lSVnA3ZllRUnpYM09JVUZFVy9IMzI1aUhsRGNQbGZyVmMrU0lB?= =?utf-8?B?bUlWV2N1T2crVkJXT2xmcXBvNkRVS0lWWW0reUZMVlFreDlMRjBJdkFuNHFx?= =?utf-8?B?c3BxcUZzeXgzeHJlTmlubmp0VmlrWVhwSFdCOWlwdlQzdmpMZW90U0tTTUxG?= =?utf-8?B?VDVCaWI3OWx4TXp2RXg0dG1wRVZiTlNHV3FYTUVxaHE2bUpCSUpSVVU0cGNj?= =?utf-8?B?TVl1eGl6VUhmdEtlWjJBNzhTSFJHT3lEbUlVZE8zeFFhaXJwRExGMXI2N2RQ?= =?utf-8?B?b0ozSGMvZlp6aENZR0FKbmdJTU5WNEMvSDRFVXVFOGF3QVRYbTcvR0VOcG1T?= =?utf-8?B?OWlxeTZBU2w2bWgrZGZMYkEzZnk1cUg3dEUwWWFQSHBzSmhmSG1oRVJidnRa?= =?utf-8?B?RGhLVzJwUFd5L0ZtVXM5MlpaSUpZSnhPbkNQbGtnUVVxK1RMS1hYZGpLb1FF?= =?utf-8?B?Uythak0zVUd0L3FrUFFhbkIwcVNVL1grS1JBQXo5QnhLQis2SEhhelFRNlFl?= =?utf-8?B?VDkvSlg1NXpUYWFJMHZpQVgvYnlSeXY4eklVTTJhNlExVWI2NnBaMC9SMTlL?= =?utf-8?B?WUh2aDR4a0dWa0xjTi9wVFpiTmd0UVBkS0p2MWtLTGVuZlZzOXcwZUFha1JG?= =?utf-8?B?Z2dyT1FDZG41RHNNcnhZUGo5Y2JmaW8rN3U5OC8rakt4RnBPRUdvRjNTbHlQ?= =?utf-8?B?RWNiV1ZUdmxXVlpXVzA0bzcvN2d3MERTSnpJeDE3RDR3c0U0aUt1eXdScUxR?= =?utf-8?B?N0s5WHZFRVF3NFgzV0JiSFNsc3lXQ2tsemFoVEQ3bFR4aHlWenVhcUgwYVFo?= =?utf-8?B?Y3FUYTViOUJucXdhMFJRYWt1QzFYT1ZUSktPN0xlSmo2TEhlcmxOZFRHWUUw?= =?utf-8?B?c2kzMm5qTlcxcFluTnhMR3JZVy9tZVY5cXZGaHZLN1VCbE9BQnBob1RkQ0xq?= =?utf-8?B?bzFIWHRpdmoyQS9LRUJOQzVxdTllbjdIYmVqckNKYW5JWnFpd0kweDZqTU1a?= =?utf-8?B?bUI1Y1UvU0huSWZBTDhkUndrMTliUGgyckRFemVXZjZ1SUUwamR5MU02MWFX?= =?utf-8?B?dlZmaUJWNU53NHdXWVU5aFRRTEdCR1J5Q25kdFhEQnQ1OVFZNFlOOHdSbjBk?= =?utf-8?B?b3poenpIZUpCVTN2NDA3RkN4cFQyWFhpT1RzOGMrbWhFVXc2YWdkb3JUNW50?= =?utf-8?B?VnBZZGt3RkZCL256aHVLTkZ0VE5TSHpzbEZndzdNM0c5M1JkQkc0ekpCU1Nw?= =?utf-8?B?TUJ1SnFESmdBZXpUMXM0VERudFZPMHRnYWgwU25lNnljVlFJc0JRdUVBTjlT?= =?utf-8?B?SGpWdTRxU1FoV1AvaXhidS94bUo2V1NOSjB5ekJwWWZVV242T1ZSWjJ4TXRO?= =?utf-8?B?U0I2QUsxQ3hlVjd1azk2WDlDSFZhUUxBWTNOZ0ZoOVljTTh3czA1R0RVUkl3?= =?utf-8?B?RFRGcFhRbS9QTHlpWFZFaW9aZlpRU0NZODdiWUNhc1lHZVJjN2FHVG1BTXlT?= =?utf-8?B?TUlwKzdiYUdYK3hpYlIwUmIvV2JLMDlEMlBXZWdJVkF3Qm9lNDB0cXJ6N3FY?= =?utf-8?B?d1hVcU9XTXlxVzZ3Y0NNd2tnYkZZaDNDZVVtSFU5STN3ZTlucyt1T01kREpy?= =?utf-8?B?Q0ZRYVBxaUd5blI0UEZYbVJJQU8zVmhoZUFBdkVIdzdOY0pGZUxYNjY3RUZU?= =?utf-8?B?NGhodlZDRnEvb25wTHlEaDhWRC92QlZXQzBJS1lSS3h3KzBoaU15S2U5Z2t4?= =?utf-8?B?bEcyYmt2VkhhTVVVcmZSdGswZjZySHM4TmlHSTgxTyswcFE0VXBreXVjUVZw?= =?utf-8?B?ODlqckpPYnVjWnNHRmtZVTFLTThucVlqZzVURkZDVHowL1dWN1JvbHNjQnFp?= =?utf-8?B?R2V5bmp6alBVZjRIcGowWXNKaUFuRFdOUkJWYUR5M3dBZXd6eTFzL1l1cW8x?= =?utf-8?B?NXhsc3hWbjFSdzhXZkEzYXlVV3lKa254UUp6dFlaMUVqdWZ5cURab3J1bndX?= =?utf-8?B?K1JrdThMV0JGMnpxOEhtd0ZKbURwcUJUaUJ5V2RNSWpXaWdDUHU1azFYSndW?= =?utf-8?B?TnRwaWxYYnN6Ui9GMFhvQVBlWnVpUEdyMktIWldQMU5IcDBPY3VPT2NxOENM?= =?utf-8?Q?p9Jf50paadlaxWJQMNd/8YSHm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 262d954b-81d4-48f1-dc66-08da97a9eeae X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 06:08:53.7456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /i7DfS162Jwdm5/29E2mkm4NiEi9t4asuVJTtO8nLb9lDoCwFNLqnTx3jyDXD2Tqtqp7S/SCV9QEQt7V40wFtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8695 On 15.09.2022 21:30, Stewart Hildebrand wrote: > I am departing DornerWorks. I will still be working with Xen in my next > role, and I still have an interest in maintaining the ARINC 653 > scheduler, so change to my personal email address. Also change status to > Maintained. > > Signed-off-by: Stewart Hildebrand > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e12c499a28..f674b5f7ba 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -221,8 +221,8 @@ F: xen/include/xen/argo.h > F: xen/common/argo.c > > ARINC653 SCHEDULER > -M: Stewart Hildebrand > -S: Supported > +M: Stewart Hildebrand > +S: Maintained > L: xen-devel@dornerworks.com > F: xen/common/sched/arinc653.c > F: tools/libs/ctrl/xc_arinc653.c If it was just for the email change, I would have said it can go in without release manager approval. But the support level change I think wants a release ack at this point. Just to not leave the question unasked: There's no interest within DornerWorks to have someone else be (co)maintainer of this code? Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 06:14:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 06:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407795.650412 (Exim 4.92) (envelope-from ) id 1oZ4ch-0003P7-An; Fri, 16 Sep 2022 06:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407795.650412; Fri, 16 Sep 2022 06:14:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4ch-0003P0-83; Fri, 16 Sep 2022 06:14:47 +0000 Received: by outflank-mailman (input) for mailman id 407795; Fri, 16 Sep 2022 06:14:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4cg-0003Ou-0G for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 06:14:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db5857c4-3586-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 08:14:44 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8695.eurprd04.prod.outlook.com (2603:10a6:10:2de::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 06:14:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 06:14:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db5857c4-3586-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PiObvRnxGkQuUTJwxRZpEBiz4cnNx+4bshFR2qE3wrrtGZN1UJ+roEbc/NJ2CgDM9nHOKZr11Z6FW0VgqcgiTHFfm29w2JTR6SW5cybP7SiEdX2cLt7vL1q28IaVLH2pRtQPu5Rdlo3PI1a2YnzQYXd2dL26f0nw0qRxv1lRGKsGy7cRoAtncSz9PbEmSXWhCzX4fXBu5mVk1JGxA0iPDd0CydDlaHx0tQFnU+Ur4HE/OoyQ7JfGXE3flMvBCs44+yk/k6bMMpFL8h7j1iOqsQZs9qMYA0stSEbCv+jMQXWBQ9kTRt+A0my99+lryHcf35tY4493FMcLEY/UetPAaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2sKk68G2ejVoiK/mjkvH8PMyl0bBzj2NtY3k4lU9CKE=; b=oUpsFSaRRHPUvubLxic6WPey/SWBGf/giadhpeSiSt01Rta5kRmHdF4e1drT213Z2YXZVm9QPYosXMOv78lvNi+iyxNEQ34spcYOcma9h5q7n1joAPUkPLNZORZrpDyyfaPUGNlW8HG231AMqLxLbbGjtenjzYRTb1YU8AYwcs/6trYkPAuGGOPfQioyS6KzvlenaKxdTX8HGZXanVylYh5j0FxRXDLjfjsloZjt3tE6Cz4yU/dPfcM1HE0QaPERy7+eaIgOFTWgaeaiaF422oULGingFfe5+yjgVnTJ/bXFLo2XkcAwYy1RMGcwUoMJ8R6RVE3peMYknQVtgxfFoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2sKk68G2ejVoiK/mjkvH8PMyl0bBzj2NtY3k4lU9CKE=; b=eTaIXQAGJTBa2Hqmk342i6ga0yBi3wpZENJrD6lZrwgfPE0NAmZ/PftfL9PJAZgtG3vhC6sya0Gn4ZswiZBeL1nABJkwe2JGRPmxxdWbG8eepvhQiVxvWx6STJI9ia04Iw8k8EqXJtwyXgGrSC2WRvOoPK4EKFtQO67jQm51uB8dE4hwgatmbC0LtLYz2KZ9TdZ7PlAmEvJU5uvf0jcDbxLCLzeckfm8JBgJx8c31zYFXQymJ8b6aZL9RBgE56xwnwecs3n7OZssf9gRpNrWN/33JbUVgWk5bi6YEi5Q3008+mKNJQ+NL8meY4y+X14LT3KymyvbN/4/dxL2Mm6S9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 16 Sep 2022 08:14:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Crash when writing to x86 hardware debug registers Content-Language: en-US To: Neil Sikka References: Cc: Xen-devel From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0074.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8695:EE_ X-MS-Office365-Filtering-Correlation-Id: fd59252a-26b8-4f26-757c-08da97aabf06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2uci7KxhPS22sfuOsJvf4wL47XoWPgslPLhWKsCjBX3koUksM4exs0Owq77yCeV3SdGUwurf6lOq/WISkPVVVIkv/bApUz71rntTdy7sgFgabCTKtA48Y0+XrVDWClk/EjvudEgrh4ZdmO+4G1Xc1H3MhOI+7YSwcvvN1ztExmMukY1g6hXbBj/LAvDWwmrboB2Zj5rpnZg0lnhd/ulik8bDGt66pcWRFAJcDSkuXdafT0qqUq65HKLzaMovPLDU8aU8gD2pf2Jyk8I5yKdZlY/zlAyODp0Fb1B6RU/N4MO/94TE+2tb46I5BFVrQEzrABIE2F6CMEHTuhSYW/oD6fXvuq9AHQ6n7lBOato8vA2IFwcXO6zHZRNTrPXrn1ssh8Qc/sJIDWbOO3n1XRv5B3Mq7c3aWfBv5LGGqgVMf0ChDiPVxEyQ5yOUkOmTeJA7yPQYFm3B2ZY6MLInW4FlxtnUjYjTC6kD8qAGEiXCeVMT2U9z+sa9gqwqLLdqI0dCUcEwYk0WJ11OHC8JdP3qnWEM4fSjQ9M/i2vqn8VHqd1hl8MEQm3u31hHH6Sg8woQqmD8amcS7Z4mejx2j+4wERos7zzLeIluKVKu4nVlp72Ol20k1YBU8B/ibxnePavCDqe0MIuaMxMK06zxY17MF04hD3GLUYL3EdptEOBqDn5vsVbA/dQKtE70RxcqqlBJMKPjn+jDzf4YQ1evrgS6bdSPMqlBfm22HUiHRh5uuKiUumXWelSq2JNDs+WNTLuqD/E8/lY3JPHQwP6lSxyDc4Dak3eXxnyF9lGc5GbPykM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(6506007)(31686004)(53546011)(31696002)(41300700001)(4326008)(66556008)(66476007)(66946007)(2616005)(2906002)(86362001)(6512007)(6916009)(26005)(316002)(83380400001)(8936002)(36756003)(186003)(5660300002)(38100700002)(8676002)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGZPSEJXQlVjUUhKMVE3QUhqWHVyU09YbFFROGJlT1A1Z2RXQmxnSlMxVzhI?= =?utf-8?B?MkRjRlV4Rm1ZaG9wcW1yd2RCbncvaEp2YS9kZmh4RzdyMHhFOWl4aDg0aTJ3?= =?utf-8?B?S3ZNWkFZWFdZSUl2M3JYeFJQcnBlMmJ1OVExMG4yODVtZXRhOWNYN2RpWEU3?= =?utf-8?B?TTJCbXNWN21BZWEwYnJZYTdCeFNpUHUzWjhZL254eDNFeWtFb21XQy93RFRr?= =?utf-8?B?dWtWcHhLTWd3S1htaTdnOGZIbWNvRFFVQTZXR0FRQlFNNnpWZWZ1M3h1R2dv?= =?utf-8?B?b1JwMlFZS2plR2pNQVp0TTcxQTVjV0pYY2JEVVgzeVdGZ2FOWEozV2J2Nndw?= =?utf-8?B?YXAyb3RTY1FMQnRBKy85Rm96c1VMS2hjVXVFQytxLzlhWStNdDV5dHBIWTNa?= =?utf-8?B?QS8xN3F3UDlkc0srMmR0aUR1ZjFwcVJOQ1lFTHNwODRScmpPQUxsZkhWQUF5?= =?utf-8?B?MCtCL2REVW1rTjBwS1JrWTZQZjFHQzNMT3gxSmFOSVcxNTZ2M1FheVhNaEc2?= =?utf-8?B?MDhDc29HakJrL3FkRHVNU2RLYzB4RnFUdE9Xcm13OU1zcDI3N1BNZEpiSmpa?= =?utf-8?B?WTgwbm8zOUN6MDZhdDh1TjU0b1RPbStEMGxTOXhPRExzaWxiUkdvMnNnUG11?= =?utf-8?B?U0s0bnpkVGt4Uk50Q1RheHBCdEZKUFBOVENDUlBIRkQzbFgzT1psMUVzVDhu?= =?utf-8?B?Wm0rMGo2SmF0MDZud0xoaS9DVkJjZHpXQ25zSW5RVDVhSS8xTHc3U1hRTmxt?= =?utf-8?B?TERSclBkWGZaa2ozS3hKcEVMTytHTHhJT2RSWTRlRGhHbGlOaUM1Tyt2Y1o1?= =?utf-8?B?M2VseXJhZm9ya3FxS3JRR1lwcmhMZS9HK2RETzZ5S28vck1wZ1pnMXlWUzdx?= =?utf-8?B?ODVoc1ZQVUw4MmxsSEhpcUtmZUFueWo2OWNXSXVmM1pEZ29ySEhOUXhGb21D?= =?utf-8?B?MGI4UlVuVGkwRzEweXZRU2JZeVU4Y2JFaWQ3d3pGME1DTkRuWjVoMEJndzVk?= =?utf-8?B?dXJia21GOFBrb3VIcVNCYWx3Ui8xUDE1QU1jcDRPNjhseXptYU5kUnlJVXZZ?= =?utf-8?B?U2tEajNBNTlUTEdJRFVqRmtCRHZNcVM2bUZsMDFTNndVQzk0azhzQy9DZGJJ?= =?utf-8?B?Ty92ZjJPdmc3WDAxaFl4Rm9ZZVNGZHViWXd1dER2Nit3SDJYWENaSWxmeWpa?= =?utf-8?B?R1BJS1NIbmlyM2FqR00rS2ljdzJGc2JsR1U2QnBDcWo1ZndCREJsNC9oUlpS?= =?utf-8?B?eEI1VXE3bUs3UTB5azlVQmxqRlduYVVBa0VjRDRIQ3gvK0VDM21BczRoeGtU?= =?utf-8?B?L0tRSFVsRWZJdFBERnd6bkl1a2pWMVdaRUo2RGp5T1NYdEVjZG9nNTBiYUVk?= =?utf-8?B?a0EyUnB5bXZ6V0p0Wm9JalJLNWNEaHYxTlgrcW9lZjZOZmMrczNnL0xEQ0Rt?= =?utf-8?B?QU0vWkJENTZXMkc3eVNiMi9JQVBEVktPSWZYYWNpRDF4RHZEb0VvclN3UkUz?= =?utf-8?B?a0gvOUJ2dmdqYVRXdEFyeXh3bEhVZzFiRjJ4SkhnZzJTbU1UdmNWYTEwbCsv?= =?utf-8?B?Z1c2T2lSdlFaVmZlSVl3Q05MTkxHYUtOMXcybzV0a0QrYzBXMWFzR0g1REor?= =?utf-8?B?cGZJVFJuMktGdDBmOEpJNEhmV3J6MVB2MHR4WGtvaUlMYnRyYTZwbjVUSzdN?= =?utf-8?B?VGdzM1Vhem5hUGEvSHQ3WGlXWnpBdG5vR0F1bTFEL3BpMDduVjJNMkpTVjd2?= =?utf-8?B?UFF0aXNZQmwyTm9ORENOZzlVcWVPVGsvOW5zWFNWNEFaRWtJSGtaOFMxYng0?= =?utf-8?B?eTR3SFlVS2c0SnN0Q1VrYUlwS3U3cGdMa1JhamxoSGsxUFdHN1B1VVc3RDhC?= =?utf-8?B?bE5RQy9kTWpQai9WRk5lUWl1OXNpTVdYZUNydGZXOW1pd1VlZXkvcS94cVBt?= =?utf-8?B?akNzQUc4ODVLaXZpYTBEWE5Lc3RrYWlxSE1JZU1FZmZsdkNsblJYdlEwQy9X?= =?utf-8?B?aE1IM1RqdkRTeU1TUDZuT1M0VUdEaEJtdkZTdDA0VW1YOGVFTVlSdndwTlcx?= =?utf-8?B?eWFhNzU5dHNRbGtZRjZMcjFLc2JzaXZFZnFRMlZXblBYNVc1Skk5dFB4RjNW?= =?utf-8?Q?tcK8onCyG3rVpMvhzIql/dEmh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd59252a-26b8-4f26-757c-08da97aabf06 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 06:14:43.2702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wyfwS0Hxkq+SX0jbEV8xr5ojn+ER1x0ZDrkOHTgIBz6t5Ttdqr1uMiOCx3u7gqy4HsRoIG1QnUaTFKnp0Y/E7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8695 On 15.09.2022 22:04, Neil Sikka wrote: > Update: I rebuilt the hypervisor binary in debug mode and get the following > output in xl dmesg after the crash. > > (XEN) HVM9 restore: CPU 0 > (XEN) HVM9 restore: PIC 0 > (XEN) HVM9 restore: PIC 1 > (XEN) HVM9 restore: IOAPIC 0 > (XEN) HVM9 restore: LAPIC 0 > (XEN) HVM9 restore: LAPIC_REGS 0 > (XEN) HVM9 restore: PCI_IRQ 0 > (XEN) HVM9 restore: ISA_IRQ 0 > (XEN) HVM9 restore: PCI_LINK 0 > (XEN) HVM9 restore: PIT 0 > (XEN) HVM9 restore: RTC 0 > (XEN) HVM9 restore: HPET 0 > (XEN) HVM9 restore: PMTIMER 0 > (XEN) HVM9 restore: MTRR 0 > (XEN) HVM9 restore: VIRIDIAN_DOMAIN 0 > (XEN) HVM9 restore: CPU_XSAVE 0 > (XEN) HVM9 restore: VIRIDIAN_VCPU 0 > (XEN) HVM9 restore: VMCE_VCPU 0 > (XEN) HVM9 restore: TSC_ADJUST 0 > (XEN) HVM9 restore: CPU_MSR 0 > (XEN) d9: VIRIDIAN MSR_TIME_REF_COUNT: accessed > (XEN) vmx.c:3295:d9v0 RDMSR 0x00000000 unimplemented Now that's MSR_P5_MC_ADDR, and hence an issue which Roger did already see and fix. You will want to update to 4.16.2. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 06:24:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 06:24:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407803.650424 (Exim 4.92) (envelope-from ) id 1oZ4lr-000512-Fv; Fri, 16 Sep 2022 06:24:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407803.650424; Fri, 16 Sep 2022 06:24:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4lr-00050v-CI; Fri, 16 Sep 2022 06:24:15 +0000 Received: by outflank-mailman (input) for mailman id 407803; Fri, 16 Sep 2022 06:22:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4kd-0004yo-KX for xen-devel@lists.xen.org; Fri, 16 Sep 2022 06:22:59 +0000 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [2607:f8b0:4864:20::1033]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01164b42-3588-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 08:22:58 +0200 (CEST) Received: by mail-pj1-x1033.google.com with SMTP id m10-20020a17090a730a00b001fa986fd8eeso24692241pjk.0 for ; Thu, 15 Sep 2022 23:22:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01164b42-3588-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=zKarCidyNQ+Vh9CZRi81EcMokbR1BeWipaXRHA43NV8=; b=Toc0LvQ1kxt0Xy0VHmPKQcgIYG7kQhd5sRHfMbF7ZalAStxyAcEtdz1+TrLStapC/T Df3fH2nkZtMeYrsD06AwzD2lhee2bgz4JDbvj0Dg4ZGMZJ0CF0UZmJOz1wSqV+taHYBH vZUIKgK/I84WfKVY2glNlAVwMozap6KeX32sRa/VNmbjY1/xb6kP2Wa7A4P+QnYWxnN7 FmksHGY4bHvGy4bgMJYuwydoJUkA3/uwe8EUqIrQs/Kv/h503fNal7PRPXT0wV7WWdSK gG5V0fgHN6PddcPl4Qc9KtiIzn7lpaDjJRQCzG7ESU4kna5Szxrgl5FTQU25mXVZYrw/ EW2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=zKarCidyNQ+Vh9CZRi81EcMokbR1BeWipaXRHA43NV8=; b=KBjn7j6si+Tm/clPOIryv9s8tqMRki4qRT97uFaqxIFS2jguLAvb/ul6HcY1iD0hvA Fq50rp9jKffvPzX2illsMJiH/RlfEk4Sz/BlCEx2YSah6qXb1vrQ9jeiv//eQFLHpFOE VGS0W1KU/nPDMUiZhTkTyzHypdwe9NnfaDbL2k/u1Fo6neHOEVGgmU+Yq429XD5G+9wF ijhPasNhwriBSAkb+ePSh1AnWZZLIqOC0q2ZG03GjsGwj527AiSfQuvBCAnKlCskVF8V UKlg52ho4MZXA+HKEtdk9mlYs2rqkK6sFYJnaY+d7cJN9tJv1eL0WjVRXMd/RadXLfQp 0KvA== X-Gm-Message-State: ACrzQf25ZIbKcSQksLg64eEjpswkhpFxD5w590za9V+AH4zngZf2K/Ck j2xza5SM0B/ulAHeIwPB+93pdG9629A0LGVdVpTCow0M5Nc= X-Google-Smtp-Source: AMsMyM5UYkz6cD1pn3caBGAb5cDR2B+F6oxNX4XEz6jSRAlp8zAyfOY6eBCbIrhCP+i71mdVMLytezJ86LiwHbzNWE0= X-Received: by 2002:a17:90b:4d05:b0:202:ec78:9d73 with SMTP id mw5-20020a17090b4d0500b00202ec789d73mr3812795pjb.103.1663309375738; Thu, 15 Sep 2022 23:22:55 -0700 (PDT) MIME-Version: 1.0 From: Adam Szewczyk Date: Fri, 16 Sep 2022 08:22:43 +0200 Message-ID: Subject: [BUG] problems with NICs pass through to OpenBSD guest To: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="0000000000007e16d005e8c564d8" --0000000000007e16d005e8c564d8 Content-Type: text/plain; charset="UTF-8" I have QubesOS 4.1.1 with Xen 4.14.5 hypervisor system on which I want to install OpenBSD as a HVM and pass through my NICs to it (Intel Wireless AC-9560 and Realtek 8168 rev 0x15: RTL8168H/8111H). I tested that when installing OpenBSD on actual hardware both NICs seems to working properly. But on hvm ethernet spamming me with: re0: watchdog timeout messages and not working. Wireless causing OpenBSD Panic! first throwing errors like this: iwm0: fw chunk addr 0x404000 len 712 failed to load. I previously try to report it on OpenBSD mailing list, with my dmesg when only eth passad through attached: https://marc.info/?l=openbsd-bugs&m=166318676430481&w=2 and also on QubesOS issue tracker: https://github.com/QubesOS/qubes-issues/issues/7765 I found also an similar issue with bhyve (re fw on guest not working when passed through the same eth NIC to OpenBSD) on FreeBSD mailing list: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245392 If You think that error is on the driver side please let me know, I will try to forced it on Open BSD mailing list or report to the fw vendor. --0000000000007e16d005e8c564d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I have QubesOS 4.1.1 with Xen 4.14.5 hypervisor syste= m on which I want to install OpenBSD as a HVM and pass through my NICs to i= t (Intel Wireless AC-9560 and Realtek 8168 rev 0x15: RTL8168H/8111H). I tes= ted that when installing OpenBSD on actual hardware both NICs seems to work= ing properly. But on hvm ethernet spamming me with: re0: watchdog timeout m= essages and not working. Wireless causing OpenBSD Panic! first throwing err= ors like this: iwm0: fw chunk addr 0x404000 len 712 failed to load.

I previously try to report it on OpenBSD mailing lis= t, with my dmesg when only eth passad through attached: https://marc= .info/?l=3Dopenbsd-bugs&m=3D166318676430481&w=3D2
and= also on QubesOS issue tracker: https://github.com/QubesOS/qubes-issues/issues/7765


--0000000000007e16d005e8c564d8-- From xen-devel-bounces@lists.xenproject.org Fri Sep 16 06:25:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 06:25:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407809.650434 (Exim 4.92) (envelope-from ) id 1oZ4n7-0005bq-Pq; Fri, 16 Sep 2022 06:25:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407809.650434; Fri, 16 Sep 2022 06:25:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4n7-0005bj-NA; Fri, 16 Sep 2022 06:25:33 +0000 Received: by outflank-mailman (input) for mailman id 407809; Fri, 16 Sep 2022 06:25:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ4n5-0005bd-MP for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 06:25:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5be09d84-3588-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 08:25:29 +0200 (CEST) Received: from AS9PR06CA0522.eurprd06.prod.outlook.com (2603:10a6:20b:49d::18) by PAWPR08MB9830.eurprd08.prod.outlook.com (2603:10a6:102:2e2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 06:25:27 +0000 Received: from VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49d:cafe::f9) by AS9PR06CA0522.outlook.office365.com (2603:10a6:20b:49d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16 via Frontend Transport; Fri, 16 Sep 2022 06:25:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT038.mail.protection.outlook.com (10.152.19.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Fri, 16 Sep 2022 06:25:26 +0000 Received: ("Tessian outbound 8ec96648b960:v124"); Fri, 16 Sep 2022 06:25:26 +0000 Received: from 5099fda9d754.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D5969C74-BD07-4478-8ECA-3D00D3D863B0.1; Fri, 16 Sep 2022 06:25:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5099fda9d754.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 16 Sep 2022 06:25:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB8719.eurprd08.prod.outlook.com (2603:10a6:20b:55f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Fri, 16 Sep 2022 06:25:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::b46e:50dd:b6e2:5241]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::b46e:50dd:b6e2:5241%4]) with mapi id 15.20.5612.022; Fri, 16 Sep 2022 06:25:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5be09d84-3588-11ed-a31c-8f8a9ae3403f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EyoeosfIg5CpILnc2VwIYcgx1ftFZFQGeNLlkJz3Ac+wBzNPF7P2jrTfdDj3e+yId2Njdj0iDgvBOV1lOzgw2oTUfbkLLc2V7yr2rNbJ9wQk3QuoNCWQqPVLSKmoAk1BThtdozsg4aXbEDiZXt7Vz6OcgZkxgW/pm2UFf/DhMMBDmOLJhUetb08dw2GhY9cRWV3kV8HE2UcZav7XxlEDXDyIbiYxFEVogddNE6SMJWSw0hkSEIXvsjlmTsnq6agbhGp7sXrzgxmbag+W39qx/N1eeJWXGClFKej0zIglggpOyM0Eka/b5M6POERAYPgQyjDU0onE1TwP3oEc9+vfaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghEtXSDot+0Gco/sjcHbeEswmqJTiSTLEnigzNEwBqQ=; b=AH9cmxkYLrJEZkHiW9cBbxHZuZ/kMXsvxHt0kjIZ29N4+FWJNPb3c36+3L7N4xFtJ1dJV9W1XpYXfDt+l9lWcKmLmrru1P/3edu36FER9HDIW/A0gafhCNyOi70rP5Kx0svCzC3hlYlqHg7wfCsqO1v3KdYp4d6iawQw/5F/UaSabkJ7BtKdBirzwuYcAuJMHh2K1bWhUa1B3gNEF+1tKvTakD8rXd39rQBHNfdWKW39okKrglKGBqq8/x1VNt52HuToChF86YHghkMVfcBJG9Gd6rB/LG3/RSzDq6gRfPM3o47HP8lGE+WMh5whKqECtVRGiz4U1PawZM8jatEibA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghEtXSDot+0Gco/sjcHbeEswmqJTiSTLEnigzNEwBqQ=; b=XBfAfLkygR4xLxRDSeAZ27IocQIMyMXBfHrUg2/Jdw8oQMfRVonDDfs5DsrC+GgC6t/MYt+/BCVyT+HMu2XaAt3nVvYf+WkvRXUvgyKPRJlPYugRvsr4FTXc7QXajOapCgNQyrktwwi95Qw3SdMQzfU5JMLZMqMLcAw3+QVqs2o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYNsh14KVjJKa12mTCy77bVoYmb2HlBMWdV/p4872ruquUewIfHC7DxjVSLUPNsiuXTiFohh+tyUCzJLy4AQx8Ya9nIJ/qRv40ypfmdO6YLjIyj7XFBffYfpge9gLA1Lom/Hhogia5j/sDs1BuY7IOGgSPfvwJq/PesLPCYPo/6ABjeF7I1xHMo6RqnBSc4FyjNtgyOR5xHFM02YqHIpM4pcboZryntlE23I3iCtWdcPDD8x2fbYW+wGyP8k6/yl5plVv/Uj0+PM+d6Dx/AUCpSAcyXdEVd+vTL19g9qMyfzYofJs8BB0aiuC+TxP6j33+30cwJhf6sFvvIW2hqjww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghEtXSDot+0Gco/sjcHbeEswmqJTiSTLEnigzNEwBqQ=; b=kntMnRikMiIaSUpEoJhvPW0E6s5M6uurKGUqu7vfKEZNM0FgFf2a+BM937vqYj7FkQ7Wan8FJQwrnO9Lqg7BUvy1EJTBOqgCIXkkuYUqdabnOPQYodfCy/GkgV6IsQN5nJyemix89X8dk9xzU7bH665emoNdjQVsFGMBO2m9XCmojHJ00raBmiDKTlrNjqphGh5+TpdrTKOW0/8JC9FWks5ZfNpRv+E/KnxPLcRHSme8NGQbny9SvChLuWxct/8gpMyZkMktugLQqF0UOxj7yjWRSGRRZJMUtmbw1WWmEDfd8gTK0JZnVmUWdf4+xIlGLyCgx+MInG5heMm8N1B11w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghEtXSDot+0Gco/sjcHbeEswmqJTiSTLEnigzNEwBqQ=; b=XBfAfLkygR4xLxRDSeAZ27IocQIMyMXBfHrUg2/Jdw8oQMfRVonDDfs5DsrC+GgC6t/MYt+/BCVyT+HMu2XaAt3nVvYf+WkvRXUvgyKPRJlPYugRvsr4FTXc7QXajOapCgNQyrktwwi95Qw3SdMQzfU5JMLZMqMLcAw3+QVqs2o= From: Henry Wang To: Jan Beulich , Stewart Hildebrand CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jeff Kubascik , Nathan Studer , Robbie VanVossen , "xen-devel@dornerworks.com" , Stewart Hildebrand , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] MAINTAINERS: change my email Thread-Topic: [PATCH] MAINTAINERS: change my email Thread-Index: AQHYyTnGoTPtdwiDy0Kyh6sCMW1eKa3hkyGAgAADTqA= Date: Fri, 16 Sep 2022 06:25:19 +0000 Message-ID: References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A730B994F02B1541BAC1D7C786FC6E9C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB8719:EE_|VE1EUR03FT038:EE_|PAWPR08MB9830:EE_ X-MS-Office365-Filtering-Correlation-Id: 90c17c22-f448-46a0-7703-08da97ac3ed4 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bc0eBbtGtAtp5U7NJJXTIYSYAR9lAkduFwyjclhFBJrWDF9wztO9puHiNM46rFTKPO7NmiQS2hVASuhPnuwdJp1bBhIBKgXQukXZz86J85JkAWQ9kZ7dawF6MLVT66oEvaEcx+I6ObPU1lWp/YaS9N1eN5KVxHhjc92n2lWGSWF69KX7ZJ8DFNa3BVgRlK+VbKr9g5jbizYIEodYdEahuxbdm2sb+nYE14Nth7dyji0PkXfFi1dS9UaByhcUXMn0tLM3EmmMa+DFD/X2M8p6Bh63+FJVZjM28I+lDBHIZmoOkeBYXSTgIoOzLiXz5pq9TGOaJJt6xoCC59FwhsUfG3KoFmZDNrAq1HTT/XCdV49FfrlKqIVk8styVERYgLwYt+9Lju+Ho2qDN9KbeUJ3FLWx/aHu5ImqZcVq5wA1pvtOCKhxdG8U+DSKzqZAZEmWWC2i7z3X5Tn4DImzs5R10IweKoZyqYvMUfNbK0d/yFSJitTYxVKnBI3Lve396aYXKk5WX8rIUc4l1OGWaS7ublC6xgWlqWg/T0KlvCaVTag55+EceYpwEChn9/AzSEzG/ryMbLaDQXX+6cjUzUz0E/aEAif92JACF6X+44DtJloHwGym8qWl/8e5w6bLaneeBQ4jpBMThwBvNyBJyVUIqHzlSY9pbDINdvvXQX/2/SN7T0A3wWUCvZ4mOIr8eM9YPMY1pAR5H1EoVHiCemN8OD9ovad1pJBAwqQwhadRvEohsUzMgFlXCRxBeIbxcgJxs7cBdU/G94GwjGELNw60RA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199015)(316002)(8676002)(122000001)(38100700002)(54906003)(55016003)(5660300002)(38070700005)(7416002)(52536014)(76116006)(2906002)(33656002)(66446008)(86362001)(66476007)(66556008)(66946007)(8936002)(4326008)(64756008)(41300700001)(71200400001)(186003)(9686003)(478600001)(6506007)(53546011)(110136005)(26005)(7696005)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8719 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2badfbb7-c3c5-4e34-c7b2-08da97ac3a69 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fB0jLXoT+7nle8dA2rZ0LQpzAxmuSgCirosWnW/I98rr30vz/9B/mhvFgCFG/T9YsIjqtCWdaW7Q0llq2ZnUWwkt3AtujP6eUQYwLRzlBmzl5k9S1QBJB4/CV1jrYV6bpn89DxVFpU8uGIbxVmcz1cyDknTXIGg7cHo5HNHWPOvsLUOJma70+/S2xr3CW7Vaxf6WGyk20lega8tblW7Xcyr5JaaOa9rc1d6y1bERi2PIb93Zy8b73LSSquRsGJCJgCA0ercDs19yZtKpVE/NDSejdtcUkmX7iWhzQiyDy8djEsJivWwKhGsP/fpn2I8lO38KNR6l10W5ze008dhsaLJT9W/XGkwLrUUH6D7PRpmrN3Wx42IHnwaph5iddOVpNb/M6fAH8g1br78D2kWJfCflcsmHXf8RjuhqBifKdo63vAqo6S9MXao1RtsFzcJO8rp2xlEAsAMK9b+WM7k+TZcHpsId98bHyBIb4p0ykP5gHMmHgzv51mrCGLFV4M06CVh4KS9wff3xCR/AFAdzJt6G7bKBLT5NowFWwyPtihujVp7hZitxXG7Mp+sgShWe2LFyTzU36ee88GwhEtgUvZWioWzDx71Q9ieGfEuqFI/cEVQ7KP6cs3HJobJe8cOJdNi6IitytPt/u+igyfni1g2dDwdb2JnUAOPplB8m8HXQRr16hd//F5nulMIOeNvZ1/jI2J4vH5QkdcktrRFdwxJRgSzL17M72iCQSm9hoOIqcsdhCzbTDB9jVVpDp3yd8vdTirqCqbkdsbjZA2xDrA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(336012)(186003)(83380400001)(478600001)(82310400005)(47076005)(110136005)(54906003)(26005)(316002)(33656002)(53546011)(9686003)(6506007)(7696005)(41300700001)(82740400003)(356005)(81166007)(40460700003)(36860700001)(86362001)(52536014)(8936002)(2906002)(5660300002)(4326008)(8676002)(40480700001)(55016003)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 06:25:26.9377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90c17c22-f448-46a0-7703-08da97ac3ed4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9830 SGkgSmFuIGFuZCBTdGV3YXJ0LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRD SF0gTUFJTlRBSU5FUlM6IGNoYW5nZSBteSBlbWFpbA0KPiANCj4gT24gMTUuMDkuMjAyMiAyMToz MCwgU3Rld2FydCBIaWxkZWJyYW5kIHdyb3RlOg0KPiA+IEkgYW0gZGVwYXJ0aW5nIERvcm5lcldv cmtzLiBJIHdpbGwgc3RpbGwgYmUgd29ya2luZyB3aXRoIFhlbiBpbiBteSBuZXh0DQo+ID4gcm9s ZSwgYW5kIEkgc3RpbGwgaGF2ZSBhbiBpbnRlcmVzdCBpbiBtYWludGFpbmluZyB0aGUgQVJJTkMg NjUzDQo+ID4gc2NoZWR1bGVyLCBzbyBjaGFuZ2UgdG8gbXkgcGVyc29uYWwgZW1haWwgYWRkcmVz cy4gQWxzbyBjaGFuZ2Ugc3RhdHVzIHRvDQo+ID4gTWFpbnRhaW5lZC4NCj4gPg0KPiA+IFNpZ25l ZC1vZmYtYnk6IFN0ZXdhcnQgSGlsZGVicmFuZCA8c3Rld2FydC5oaWxkZWJyYW5kQGRvcm5lcndv cmtzLmNvbT4NCj4gPiAtLS0NCj4gPiAgTUFJTlRBSU5FUlMgfCA0ICsrLS0NCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYg LS1naXQgYS9NQUlOVEFJTkVSUyBiL01BSU5UQUlORVJTDQo+ID4gaW5kZXggZTEyYzQ5OWEyOC4u ZjY3NGI1ZjdiYSAxMDA2NDQNCj4gPiAtLS0gYS9NQUlOVEFJTkVSUw0KPiA+ICsrKyBiL01BSU5U QUlORVJTDQo+ID4gQEAgLTIyMSw4ICsyMjEsOCBAQCBGOgl4ZW4vaW5jbHVkZS94ZW4vYXJnby5o DQo+ID4gIEY6CXhlbi9jb21tb24vYXJnby5jDQo+ID4NCj4gPiAgQVJJTkM2NTMgU0NIRURVTEVS DQo+ID4gLU06CVN0ZXdhcnQgSGlsZGVicmFuZCA8c3Rld2FydC5oaWxkZWJyYW5kQGRvcm5lcndv cmtzLmNvbT4NCj4gPiAtUzoJU3VwcG9ydGVkDQo+ID4gK006CVN0ZXdhcnQgSGlsZGVicmFuZCA8 c3Rld2FydEBzdGV3LmRrPg0KPiA+ICtTOglNYWludGFpbmVkDQo+ID4gIEw6CXhlbi1kZXZlbEBk b3JuZXJ3b3Jrcy5jb20NCj4gPiAgRjoJeGVuL2NvbW1vbi9zY2hlZC9hcmluYzY1My5jDQo+ID4g IEY6CXRvb2xzL2xpYnMvY3RybC94Y19hcmluYzY1My5jDQo+IA0KPiBJZiBpdCB3YXMganVzdCBm b3IgdGhlIGVtYWlsIGNoYW5nZSwgSSB3b3VsZCBoYXZlIHNhaWQgaXQgY2FuIGdvIGluIHdpdGhv dXQNCj4gcmVsZWFzZSBtYW5hZ2VyIGFwcHJvdmFsLiBCdXQgdGhlIHN1cHBvcnQgbGV2ZWwgY2hh bmdlIEkgdGhpbmsgd2FudHMgYQ0KPiByZWxlYXNlIGFjayBhdCB0aGlzIHBvaW50Lg0KDQpJIGp1 c3QgY2hlY2tlZCB0aGUgc3VwcG9ydCBsZXZlbCBpbiB0aGUgZG9jLCB0aGUgZGlmZmVyZW5jZSBv ZiB0aGVzZSB0d28NCnN1cHBvcnQgbGV2ZWwgaXM6DQoiU3VwcG9ydGVkOiAgIFNvbWVvbmUgaXMg YWN0dWFsbHkgcGFpZCB0byBsb29rIGFmdGVyIHRoaXMuIg0KIk1haW50YWluZWQ6ICBTb21lb25l IGFjdHVhbGx5IGxvb2tzIGFmdGVyIGl0LiINCg0KU28gdGhlIGNoYW5nZSBzZWVtcyBwbGF1c2li bGUgdG8gbWUuIElmIGFueW9uZSBuZWVkIHRoZSByZWxlYXNlIGFjayB0YWc6DQpSZWxlYXNlLWFj a2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywN CkhlbnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 16 06:45:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 06:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407815.650446 (Exim 4.92) (envelope-from ) id 1oZ56O-00085Y-DK; Fri, 16 Sep 2022 06:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407815.650446; Fri, 16 Sep 2022 06:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ56O-00085R-A9; Fri, 16 Sep 2022 06:45:28 +0000 Received: by outflank-mailman (input) for mailman id 407815; Fri, 16 Sep 2022 06:45:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ56N-00085H-SD; Fri, 16 Sep 2022 06:45:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ56N-0007mo-QA; Fri, 16 Sep 2022 06:45:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ56N-0001Uw-EX; Fri, 16 Sep 2022 06:45:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ56N-0006Ac-E4; Fri, 16 Sep 2022 06:45:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=umOaT3bhd/S7Mna4A4WVg8Dp4MGWCaaSqWxEA5HTu/E=; b=Pz8ZwU1I38lKtGOFElzz2F6XaH Wslb1csVp/i7Rafnugy3A8ZDNEy6+qBj1df1P1KdtkSYK3RIB6kibw6Wf6iyLhNXrBjxrEF7c5YGk FIC7CnVefi8aUgMtczzmRk5Q6sCVQfbOWfmXY6OS6hTjaEqNCW3r+sMBhEly3GbnXBZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173220: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3245cb65fd91cd514801bf91f5a3066d562f0ac4 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Fri, 16 Sep 2022 06:45:27 +0000 flight 173220 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173220/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3245cb65fd91cd514801bf91f5a3066d562f0ac4 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 43 days Failing since 172152 2022-08-05 04:01:26 Z 42 days 95 attempts Testing same since 173191 2022-09-14 11:10:31 Z 1 days 4 attempts ------------------------------------------------------------ 1779 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182803 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 07:19:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 07:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407826.650460 (Exim 4.92) (envelope-from ) id 1oZ5dU-0003DY-VN; Fri, 16 Sep 2022 07:19:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407826.650460; Fri, 16 Sep 2022 07:19:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ5dU-0003DR-SR; Fri, 16 Sep 2022 07:19:40 +0000 Received: by outflank-mailman (input) for mailman id 407826; Fri, 16 Sep 2022 07:19:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ5dT-0003DL-Qk for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 07:19:40 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2065.outbound.protection.outlook.com [40.107.101.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebc5f38c-358f-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 09:19:37 +0200 (CEST) Received: from BN9PR03CA0963.namprd03.prod.outlook.com (2603:10b6:408:109::8) by SA0PR12MB7074.namprd12.prod.outlook.com (2603:10b6:806:2d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 07:19:33 +0000 Received: from BN8NAM11FT094.eop-nam11.prod.protection.outlook.com (2603:10b6:408:109:cafe::92) by BN9PR03CA0963.outlook.office365.com (2603:10b6:408:109::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16 via Frontend Transport; Fri, 16 Sep 2022 07:19:33 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT094.mail.protection.outlook.com (10.13.176.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Fri, 16 Sep 2022 07:19:32 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 16 Sep 2022 02:19:31 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 16 Sep 2022 00:19:30 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 16 Sep 2022 02:19:29 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebc5f38c-358f-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ae6mqHZ1OaZnbTRYxcaRiCnSyH+5gleKA/iQPEkRFpnrPC3JcX6YMDXe4wcLfZCBjlKkJxoNkZlvTGezBHqJuTQUyo/at/42gy66YYHutcx6UtTLgYVERnrcIgeI8maIbP3msECwFjynCeHP754II2CrBXYbhb567NrV2SNsDhcmgXxlD3CPYv+ZqFHdPJ5Tn4QtsSOpDZ7bO+gifX9pM0/gN/Nj7I+u8l1EgbXVck7QIymc6Pf4M9qwLykZKqkA4CSqYVs2cpOxI4eT9uxoosuvvfiYGbZp2RXzsN/xGhoSU9v3Kv6y2MS9H8Myph9EscIIt4mLfTNV8iOPaQM2oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bYLwhphNxjPniBivxpg6SChjQHPi6Sajt8Scuh1Scvc=; b=HLyY97+MIGXBYpbTf3yrrfQRRrw3d5woLKM4oRMfDGGK9ILWUUINrNsxKxc2nUvIlbGxj0FpDDoY6j2axo+0GDGw1wKkxhzyK5s6By5fsCELCjaMuyYBgebvAcJI3BHVGEjkuIsNZNg8h+2L2YTG68UdOTAt0DePKuD4wNf+svCbzx0vELekIMrlMM0AIPxITApbgkTdPXsXLJN6Zo+UaRrIG/oFeYSN7lelr7Js/W956Aw0VvRdDxFTvIPrJllZrt1iFXszZnDxOiDlW36PY0jqjBlMtG7J0oPVKgcbsoYxAd+GjVNWlZ9Y56SLhS+9+QRD6DCRzbs0XMF0z9rWDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bYLwhphNxjPniBivxpg6SChjQHPi6Sajt8Scuh1Scvc=; b=LhpaK3TGNsLVhAsbDX2ePhnZVoW7JGoMyuHn21Gk27SENrd15xUW/8nNnnh8sN2zdEDUhwhmk7nbElNp27Kv41WgmoGzqyNOYn+ihE1BrGBnmthuF9V9Ep0ytPQbA7ymVb0Fq1AWvlZvb2O+hJR2oxe47/J9mG4EpfntalDSW/s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [for-4.17] xen/arm: domain_build: Do not use dprintk unconditionally Date: Fri, 16 Sep 2022 09:19:20 +0200 Message-ID: <20220916071920.8287-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT094:EE_|SA0PR12MB7074:EE_ X-MS-Office365-Filtering-Correlation-Id: fec4159c-159b-47cc-3b88-08da97b3cd61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JJuPHNqA1AC66kn8GhAndLPcM/o8WusngN26ywQRJ9dOh0Xv3eTyINUnaP+X5NH6SjEzOUVxe2ayVsidyMsGes3EKKlMpkNT+kJzaZpvILYxGuTfLCfEonQXQrWAXtR+yjt0M5y2MhqUs8gDHTSD4L9l7nE/HI4KUC1M+dGWCd+H4q+LbgFQYFPe3XWWPudc5buBF0MV2xe7cclZKppKrJXZ3H8jV3ker1Tue4f88Xp9/3YD5rqn+Fe9oht9rVqL2bFtyRTQVsqbCkB71Gz8mOnxBfWj07ocLVZjC6HAX4h7zk+bovNJNrkVkLO8G849zJ44mE/BWSZvOrVkjWQ4W2yMkjToBoXSt/XD65xzJTZRPJUQRruzydLv/eKoXFYBPmomoXzkpT7u8ZX5/h2sCB9EvlN7f8jn3vMJmhCLrNDB5dci6E01yKPW0+JMU8vXzJcQ+nPXKvskos8ITuPaKdZcHuF+38jzv6m8Qmuu7/m40AAPvFh27mX0mE6xYJcv3G4utDoOClOCd3dY0B2aOYJFtBCVLTQVNBQ7oefNsJt8ZHEqnddstmr32mSIpft9xVFqXKd9fIIlcBvkbY1EK8NOR3rOyBZ/QaX59eyPsSqXXCPd5OoJn1+5guy6l8pu6yLFiHsIhgvxcRJ4pSeEpwqDDXT1PVPN5qpZiFrjf54zcTgyldcyV1Kl/+ah5vojRnQ/gwZf81ennRxOju1mLiloz17Shl5tySDy200Hu1Y6hFoO73TiTeSeNOI8ihHEU8Pzzf3ZiOgKk8zeHq31VAbH/fRAZz3mP3DTyYTcPWX0fYkfz6AghaVtzRUO+gwq X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(36840700001)(40470700004)(46966006)(81166007)(2906002)(356005)(5660300002)(44832011)(40460700003)(82740400003)(1076003)(186003)(336012)(2616005)(83380400001)(478600001)(82310400005)(26005)(41300700001)(6666004)(40480700001)(8936002)(8676002)(86362001)(36756003)(70206006)(4326008)(70586007)(54906003)(426003)(316002)(6916009)(47076005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 07:19:32.6206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fec4159c-159b-47cc-3b88-08da97b3cd61 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT094.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7074 Using dprintk results in printing additionally file name and line number. This is something we do not want when printing regular information unconditionally as it looks like as if there was some issue. It also makes the logging inconsistent. Fix this by switching to printk because this information may also be helpful on the release builds (it would still require setting loglvl to "info" or lower level). Fixes: 5597f32f409c ("xen/arm: assign static shared memory to the default owner dom_io") Signed-off-by: Michal Orzel --- Rationale for taking this patch for 4.17: Current code results in an abnormal behavior [1] and was introduced by the 4.17 feature (static shared memory). Even though it can only be seen on a debug build, it should be fixed now so that we have a consistent behavior across all the logs. [1]: (XEN) arch/arm/domain_build.c:847: d0: allocate static shared memory BANK 0x00000070000000-0x00000080000000. --- xen/arch/arm/domain_build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 01c2aaccd82d..f47e77876a25 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -844,9 +844,9 @@ static int __init assign_shared_memory(struct domain *d, unsigned long nr_pages, nr_borrowers, i; struct page_info *page; - dprintk(XENLOG_INFO, - "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", - d, pbase, pbase + psize); + printk(XENLOG_INFO + "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); smfn = acquire_shared_memory_bank(d, pbase, psize); if ( mfn_eq(smfn, INVALID_MFN) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 16 07:56:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 07:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407832.650471 (Exim 4.92) (envelope-from ) id 1oZ6Cl-0007WL-OH; Fri, 16 Sep 2022 07:56:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407832.650471; Fri, 16 Sep 2022 07:56:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Cl-0007WE-LX; Fri, 16 Sep 2022 07:56:07 +0000 Received: by outflank-mailman (input) for mailman id 407832; Fri, 16 Sep 2022 07:56:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Cl-0007W4-0R; Fri, 16 Sep 2022 07:56:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Ck-0000Xl-Uv; Fri, 16 Sep 2022 07:56:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Ck-0006wq-F6; Fri, 16 Sep 2022 07:56:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ6Ck-0000jv-Eh; Fri, 16 Sep 2022 07:56:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7vGcbZHx7rPaW54tmUiKSdlve5bjJRbUzPDzpm+joiU=; b=zzHl2pIfOloL/U27uwGnEc58s/ Egy9NxjmdyHMGtlA68/zsF+VEabos6UqzZFIuZSa3Gk5jPtcXHo0bGzFT4S+k4qOUGwTUv4Ufv7ei K69ieYwht4ES+Qt9+n5lj7EZZQFr7kQvOVYaO1jMBk83HLLNFj7xStL/+KdY92xTsj4o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173228: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=3184e44df1042ae41c1cd8d2acaa47d7d30cd07c X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 07:56:06 +0000 flight 173228 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173228/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 3184e44df1042ae41c1cd8d2acaa47d7d30cd07c baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 318 attempts Testing same since 173218 2022-09-15 19:13:25 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2616 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 08:08:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 08:08:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407845.650485 (Exim 4.92) (envelope-from ) id 1oZ6Ok-0001BX-9T; Fri, 16 Sep 2022 08:08:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407845.650485; Fri, 16 Sep 2022 08:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Ok-0001BQ-6c; Fri, 16 Sep 2022 08:08:30 +0000 Received: by outflank-mailman (input) for mailman id 407845; Fri, 16 Sep 2022 08:08:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Oi-0001BK-C1 for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 08:08:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Oh-0001IV-U3; Fri, 16 Sep 2022 08:08:27 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.124.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oZ6Oh-0003QU-NE; Fri, 16 Sep 2022 08:08:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QnhwE4lqNX67ACyIjdJQ4LLBo+ol2ALyF9rc7n2FJbE=; b=r6IUg4mGmT/6VOa5R/MTRKy84d jmm9IpIxxRSL28UThogh8LFULsJYQZUUwSbZ8IC4D7csw0ARh2wt8Ton4Ux7mMnQogP3ROGU1CezU 6wb5Q7QSHAsf3ZwqiIe3vgIuSSStIZ+P6hQAwz1c4xc5IHTcL30wBgd1SmFaW2XZSZlM=; Message-ID: <4f4e254a-6b54-cdf7-40bc-89c25172bebf@xen.org> Date: Fri, 16 Sep 2022 09:08:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [for-4.17] xen/arm: domain_build: Do not use dprintk unconditionally To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220916071920.8287-1-michal.orzel@amd.com> Content-Language: en-US From: Julien Grall In-Reply-To: <20220916071920.8287-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 16/09/2022 08:19, Michal Orzel wrote: > Using dprintk results in printing additionally file name and line > number. This is something we do not want when printing regular > information unconditionally as it looks like as if there was some issue. I am OK if you want to switch to a printk() but I disagree with this argument. dprintk() is not about error, it is about anything that doesn't matter in release build. I don't think we should just switch to printk() because dprintk() add the line/file. There are message we don't necessarily want to have in release build. So dprintk(XENLOG_INFO, ...) would be right for them. Personally, I find them useful as there no grep required and/or confusion (but that's a matter of taste). If it were me, I would add the line/file everywhere. But I understand this takes space in the binary (hence why this is not present in release build). A better argument to switch to printk() is this information is useful to the user even outside of the debug build. > > Fix this by switching to printk because this information may also be > helpful on the release builds (it would still require setting loglvl to > "info" or lower level). I think we should drop XENLOG_INFO to be consistent with the other printk() in domain_build.c (after all this is a domain information like the other) or use XENLOG_INFO everywhere. My preference will be the former because otherwise most of the information will not printed in release build by default. > > Fixes: 5597f32f409c ("xen/arm: assign static shared memory to the default owner dom_io") Fixes should only be used for bugs. This is not one. > Signed-off-by: Michal Orzel > --- > Rationale for taking this patch for 4.17: > Current code results in an abnormal behavior [1] and was introduced by It is not abnormal (see above). This is an expected behavior when you use dprintk(). > the 4.17 feature (static shared memory). Even though it can only be seen > on a debug build, it should be fixed now so that we have a consistent > behavior across all the logs. As I wrote above, I agree this should be printed in release build. But I disagree with your arguments. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 16 08:20:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 08:20:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407855.650496 (Exim 4.92) (envelope-from ) id 1oZ6Zh-0002hY-Aw; Fri, 16 Sep 2022 08:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407855.650496; Fri, 16 Sep 2022 08:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Zh-0002hR-86; Fri, 16 Sep 2022 08:19:49 +0000 Received: by outflank-mailman (input) for mailman id 407855; Fri, 16 Sep 2022 08:19:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6Zf-0002hL-D4 for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 08:19:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50a212b9-3598-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 10:19:44 +0200 (CEST) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 04:19:39 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA0PR03MB5497.namprd03.prod.outlook.com (2603:10b6:806:b5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.17; Fri, 16 Sep 2022 08:19:35 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%4]) with mapi id 15.20.5632.017; Fri, 16 Sep 2022 08:19:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50a212b9-3598-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663316383; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=PtBnnS74mlK43yJvaSjYBuOYgj9NwQ/gJSj829EeLmI=; b=cNZ3FRDD5OmL3c8RSJ/l1UoAW/iHtPcADjltix+9lyxf4Etu4/4/6yXo zExXeY02yI+Ocn1eINpHU+I1c45fpVkWAp6PNk0yOAlKlnn1Ul/ZbskUi O4CsPtEg3wL4OHWnsbyk0qRrtgAIzpQKz7z385A0kkw03Wac6brMtWQNr I=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 80338946 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:SwRbsa2wPPqW69M4H/bD5f9wkn2cJEfYwER7XKvMYLTBsI5bp2RWn 2JNCGGFbquKZjPxftF0Pd61pENUv8KAm4JlHQA6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8U035ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/9KCmQ6Y5wpwe00Plh10 e1fJTMtSTnW0opawJrjIgVtruIKCZCxeak56jRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2yS5KmIAwL6WjfNfD2z71gt+3aKrKNPIUteLWd9UjgCTo WeuE2HRUklBb4zOlWTtHnSEh+juzSX0ZK0pLeep7vF1x1aP+0cvF0hDPbe8ibzj4qKkYPpeK UUf+TEpq4A59E2iVNq7UAe1rXiJuBJaXMBfVfA5gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+ITXOQ8J+EoDX0PjIaRVLufgcBRAoBptPl8Ic6i0uVSs45SfHtyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:cqPALKjp/o3C4+q02RZ+vvmaFnBQX0F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nGPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SuV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A7eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1whq7VBaM0pd gsCZ4Y5I2mfvVmE56VO91xMPdfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q 6xG29liQ== X-IronPort-AV: E=Sophos;i="5.93,320,1654574400"; d="scan'208";a="80338946" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzdOaPSDQ4ALuwbRS1oH5LjU48RU2BBW7PjN+hVHAOeMJf7FQ71BXdVb+IgBeWyQ/XbiTk4ETyarkrLac5a6LAeaeGbapHq3/AZsNobRz+OZg7uV55OmBrKEaIFaRt8LioSQvAvkkzV+WOPhqMs1uJvZ6DtxYm9VHrP7YaN/ODmvX2gCvZ/SzsRSNzv+j/lCkn2G1ATGAA45fa/cVOyuORWGcCEZRECYgczjc72/HHpSKlFwhrhOY+2BtB110JYzI5casvE+AqTggxqXRqzu7m1mNk9Dcabnx+k17UrE8ZZ7xBs9+kajU+ZLqOyBCt5PWnUQ6TspUFh43zDiiHfaeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RuY1MuLzIfClvyxlgwYR0xCJDqZXV4AXvdQHK3qP7HI=; b=aAU2ZePBaI4MD81B8+EOJ+0l3OLRJyN+moomPaNc0Xa4lVhSTapQ5OI8DnsvdC7fbArS3mpD03bMm6BDxL9qiWtSDDY5mNql7wnFqAgiT/AAnWPkB0e37s/bq1MOoI4bYtiRUFht6g0chMxb3qKjIkZ1ykxGVdS1uZxvpvtrPfG1uMwrdNSxK4SLqy1rlosy9kFEFFrS1YU0PJIi6RgS+JWJKVucuqAgTQZ6+fYk4i2gcU1+zO8S9FyHtAgSDEdo+2peaHIf/6nD0E+buLKWj/vb8QkXHsjoE3c3zHX92NV0/vD31kYU6guWIXp4RVQsefEEBrd9mnQRdoetxRI+eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RuY1MuLzIfClvyxlgwYR0xCJDqZXV4AXvdQHK3qP7HI=; b=wAxF6BFC0ZcDLvBXkVvqeRfY4G/zZrn0X7a8bp/9i3vDAHuwtVzs0ORTbPsv2PWmat+iVqeaFF7o6yfzEaOqhUi6t0tQvxXmgheBg1F8/a0tImxWynSCleGCAqRi+GVF3j4LWWuRp7L6WuabiHGKuOvoZrQ4sumN8Pl/iUyngEI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 16 Sep 2022 10:19:28 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Julien Grall Subject: Re: [PATCH] libvirt: disable Werror for non-libvirt flights Message-ID: References: <20220913100328.27771-1-roger.pau@citrix.com> <25379.49467.262316.722608@chiark.greenend.org.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <25379.49467.262316.722608@chiark.greenend.org.uk> X-ClientProxiedBy: LO4P265CA0125.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|SA0PR03MB5497:EE_ X-MS-Office365-Filtering-Correlation-Id: fdb7ff73-c3b9-44f4-aa0b-08da97bc3059 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ffWV7middAYDDgqaolmvbI3CLB46smeuhmERZRB2mV/33jSU6zbCiyLVEb8LHC5Vy3BUPb/pZrbPl4XjODSkdUpQbiI/vEwdvzKxgI3zzCIbNx0FzB5l7YiLlujvOY6QsNtIq7W3w9U4TPmW32gq6JWHiazGLhZeRxp2QQl7NgPL1oNH95mqwZd5/9IW+uXM9DyR8ePB7BHhNgmKtZs1EhiMsf9wfkZt6wHIO2+VXvbg+BDAiPhh9NrYw+cRsWxk5mbwXYYEk8bYrnPblS+rVOhsOhXd6zyje687hJs7B65kuP2+3qWe041l5ghl65MXYMk6P47NoVYvcx5+xxO7IIjLLwMXuTrPAUFcMz4RI8YlaPmrsqG41hiZhzNbhmDzKGtXB7XSlpYdHlN0sitcNSJB2llxh3nyVOxyhSTcpTkCDHqEofkLvudAcUCuLxJT2F5qFvFJaXEGfKA0IlJJUYXOj/Km7+cYjqmaym/Eg2sLGiQRk9+FHWU8KkC8DZtmpZUuWXR7JG7SOhgWOAEMs4tiOEEYWwCat8Y2iHlgI+Juf3l+rjLelMM90brgInB18xJ/f0OqrELUqPtMCNNTKEzKPQetzKbCaBZPSIPwGajJQfLzF7jZE3X3aMkNgflN26vynmwwhk/GyDgTidKqS5Igjq3KpJTAX0exp4milBs5s+mRT92iVGTqWURfeYroV7C2+dysyeuuHIOcWhn5dA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(451199015)(83380400001)(82960400001)(186003)(6512007)(26005)(9686003)(478600001)(41300700001)(6666004)(6486002)(54906003)(6506007)(38100700002)(6916009)(5660300002)(8676002)(316002)(8936002)(2906002)(66556008)(4326008)(66476007)(86362001)(85182001)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmlhNTUyRFJCTVVKVVpLVjFoSWMzWTZlL3M1QUl6VXFqSjN5eVNrelhxZ3pW?= =?utf-8?B?NDRUNXA4U0ZmS1dBWXRjRFEzZTVyM0FtZ29ITE5YVk9EQi8raDRvelI4eFpt?= =?utf-8?B?T1ZSN1RwT052UGxFZGF2aWorb3Z1TTdyNGl6Wm56RTFWV3RHTjRXQkhHeERG?= =?utf-8?B?emc2Y1BuVXhoTkFNM2VNdTc1blZWcHVGLzY3ekZxbXVBWjhFVHJ3dXFhdjI5?= =?utf-8?B?RVNxTllNYlYvbmtkY043bnpkNTRDWXJDM3VQOWo3OG5oR1ZXVmFYZUQyd1Bv?= =?utf-8?B?UUtYZ3hPSGVWZnkrci96d2pnRHpuVldNdmdIWm9HdWRvdGZ4aFBxZWhYRUox?= =?utf-8?B?T0J3aFBMdVU5eFhXbXBJS3RyNlJjSUdDdHFjM21RR0lmS1ltcVk5KzlzM2tz?= =?utf-8?B?TUxmQnNSZFJYRDcxRnFPUjRCUnFhNmtJbWNIZ2k5WjNRVG9XdFZuY3JLNmVz?= =?utf-8?B?Ky8rNFhXKzVKV2V0WFBlRzUxOWljTWNSdFk5RVczSkFWb1EzY0xaaGozNFdM?= =?utf-8?B?VW4vR0owT2lGYzlEa2ZORHpOeTZiYmRGQ2NqZUg0MzJyRmxlRTVCSUZTZDRh?= =?utf-8?B?NmdkUlFGOUhsWHdEcytQaERETmxxeW1ZR3hsUU1yTUprbWFYcDBiVzVXVEVW?= =?utf-8?B?MUd1bjYyVDRhdnpFdmRKa3o4L0lSN2JKb2FaYmVvL1dZY0x6dGQ2c1BYNVdO?= =?utf-8?B?ZHFtTS8wbXdPTHFQV2ExK2I1aWo0RWQwckJqZnJJc1EvRThVMmloZnBpaDQ1?= =?utf-8?B?R1RCelJ6YmZxR2pYbS95dWlwUk9HSmdLclQxSEF2b2JUYkxJQUpFckY3aDJF?= =?utf-8?B?YU9rakdnNExZMzlvSzB4Y29LOFFKYUx5RGVQTm9OaUJ3dHhCRjBTZmdLWlNV?= =?utf-8?B?WDJJQVJBOU81Zi9Rcm9mS2gvNmhLWk5mRTNTeE5aeDZTQ1lMdWhXbVJ6bHBC?= =?utf-8?B?MFR4MTB5ZUtiZFRDeTRZL0xqTDBFNTdjUjhnWEd5c1o3dkRZbUhjSDZPWkZH?= =?utf-8?B?V0JvM1BEci8xNm5VazQ0TDdrOVR0blIxOUs3OW1RS3dFOExTQ0FHdnMyWHFx?= =?utf-8?B?Y0lPaFdiekF6WHNrZ21oNE8yOUVhcVY5T0ZoeDJLYldhSGJOT0xRWDNsVE9Y?= =?utf-8?B?S2RLWTIrbkxLMGp6RkJ2aW1GYXRIclgvNTlJMFlhdHZFaHBjbTRYeWVyY2Vx?= =?utf-8?B?UkFwdnRRaHI4emVpeGtGNmhpenFLcE5oZkJDTDhHeExRa2FFV3ZQMHJnNkQw?= =?utf-8?B?bEtqR2swbFdoMmowUFBpOHVFeWZlSUJFTnVISkxYTUxXWjhDNTJXNUdtYTVK?= =?utf-8?B?cXhxOHg3L0ltdzR6RnB5L2dwQWhaMENNN2tSMUlVQTNLL3gxeGN6OFJ6WmlX?= =?utf-8?B?RUR4cTg2eTFiMTY1ZjJzaDJOVTRjMjNSSlRDOEZsR0lGamg1TWkxSEJDSDFB?= =?utf-8?B?N0NMcHc5ZTNGb3UrcUQwdHUwWHZpNHdwbEl2ZEtUT0ttR2p2QnBvcDFWbHln?= =?utf-8?B?ZlRZeE54MktwNkpGOHNyRHBOemN1MXFBcTNqYW0wVXRUU2FTY2ZyVlNBWWov?= =?utf-8?B?STVlOUphdFE3MVFZNFNSUk91K2RDZWY0bWJGaVVpM3paNEREdDFxaTJvRDRr?= =?utf-8?B?MDg3NjE5N2Q0c3RUYjQyR1k3NGtaSUhDRjBXczl2b0ZWZXVOVG9Pa0VUV20z?= =?utf-8?B?UFJOd25lUXVPazV2ZGRPekxwQjdyWkU4V0w1OGN2QjVjZVhhOXZWdmxGNlRx?= =?utf-8?B?ZXdrdk9VUVJoY2x3YTNTeGVxVzJ6UnBNdDJXS29kWUozQktoWVhhZk5pU2ky?= =?utf-8?B?d0RyQUF6cm1tV0FjcDR2RkM4SnVKcDBlbnlnYmhuazFpeU52VmJEQnpNLzZS?= =?utf-8?B?YmkzenRIdUhUcWloWTdmaEd5VTNtWjZtVEVCaEZra2Vrejh2K0NFSTYyeE9I?= =?utf-8?B?enNHc3JzMStXaEg0WG4wbERRUDB1ckpsT1Q4bURrTWVsNVRCbnVJMWU1VWk0?= =?utf-8?B?Nno1Z0NIMWREV1hqZUlGNTloL3htTlZrbkp1UXRVcUVxODYxSHlnUWRTN1lR?= =?utf-8?B?MjlEOWdTTGtaMUJYaVM2YjZwcnAxVFdadmQwR3hDQmRxTVhFb0tzOGdwbU4w?= =?utf-8?B?UVFRODM5QW1zMFNBSm5jekxhSUxQV05mUkFSQnBBQksyWGsyd1NxcXZuK0Ro?= =?utf-8?B?NHc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdb7ff73-c3b9-44f4-aa0b-08da97bc3059 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 08:19:35.0299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MY8DhgY5EQeSqFNXksl0SvfnMoRQX/XgxtWmv7kX/nhL/vnSRkLBlTeT1iHdUIIJOT4Ib92MK3ptra19h67WGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5497 On Fri, Sep 16, 2022 at 01:20:11AM +0100, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH] libvirt: disable Werror for non-libvirt flights"): > > I don't mind using -Dwerror=false if that's considered better. Ian, do > > you have an opinion? > > No, I don't think I do. I think it depends on what kinds of things > are likely to change, or go wrong, in libvirt. > > - *) libvirt_build_runvars+=" make_njobs=1";; > + *) libvirt_build_runvars+=" make_njobs=1 meson_options=-Dwerror=false autogen_options=--disable-werror";; > > I wonder if it would be better to abstract this away and instead have > a runvar like "libvrit_build_werror=false". But maybe that is > gold-plating it. Did consider this initially, but decided to use specific options for mesa/autogen in case we need to add further switches to specific configuration systems (unlikely I guess, because autogen won't be used anymore). > If you choose to keep that the way it is, then for either version of > this patch: > > Acked-by: Ian Jackson Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 08:32:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 08:32:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407863.650506 (Exim 4.92) (envelope-from ) id 1oZ6m8-000560-I3; Fri, 16 Sep 2022 08:32:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407863.650506; Fri, 16 Sep 2022 08:32:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6m8-00055t-FJ; Fri, 16 Sep 2022 08:32:40 +0000 Received: by outflank-mailman (input) for mailman id 407863; Fri, 16 Sep 2022 08:32:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6m7-00055k-O6 for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 08:32:39 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2052.outbound.protection.outlook.com [40.107.92.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e46a30f-359a-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 10:32:37 +0200 (CEST) Received: from BN0PR04CA0112.namprd04.prod.outlook.com (2603:10b6:408:ec::27) by MW4PR12MB6974.namprd12.prod.outlook.com (2603:10b6:303:207::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 16 Sep 2022 08:32:34 +0000 Received: from BN8NAM11FT070.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::80) by BN0PR04CA0112.outlook.office365.com (2603:10b6:408:ec::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18 via Frontend Transport; Fri, 16 Sep 2022 08:32:34 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT070.mail.protection.outlook.com (10.13.177.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Fri, 16 Sep 2022 08:32:33 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 16 Sep 2022 03:32:32 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 16 Sep 2022 03:32:31 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e46a30f-359a-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0BwXFBpOaGwzDPwRTlMFLaEbknjcKSlC9U1oSmJCW7jPdfdtx+vFkMC+VKTQot7AOT2QQHl7p5cEkDgsDM6x7tfCSQ50OMZaKSI1k0z/errChpbeoZW96vzZ9tEApUvzKa1ZTh+k6+ZyzqL/+AxI3RQc4qzI/ujRbc8xvPWBUo86gz9CRo7xPg4zHRMPJOMynDFQMfYFQUEyOV7MBla+e68jMY1WcOEmsqKJPMUIYYQsumvulFkU/yMNoEPqnpT54UPKfFfuefHrjW4Nf3s6bnXYO/ckCcZgw7W3tqtExSSdnorXHFPXyw8+T1Z3jMs8EskzoOreDdPWz5OReY/Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8u54E9dl5V4GQwLUHCI8FloeVzY+UsfS0AsZVT3a0tI=; b=X/LGk4nal/T46aKP2edBlpsG9qJEkgDk5NgomQzUU/Zs4Vmh+2Mli13hjKjj4B0bO4d5Yws3JNGGQixpr+Z1POl9jmIeNhuXJZVvlXQBZojm6z1bsa5sfbEs7FPq5uT8pudGCnqYq04bXaI53h1xKmWwmbUTiDjfm7eixr9Y5c6I2s3EwHmeDBlMPJcy77+lqLgSm+HHBOrbcxL+dZ81VwNSP/UlWjamAf8rY0h0W24EbssUm2zlFbUqhlYHg5eVJ/FXapQ9mLPPIH+hpM/7szYbxD1+pmx34KM3TyiaBOXG7xy8QYCXqXPJJnmurV3sHJZinY6+g3iRBhKmlrXQ7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8u54E9dl5V4GQwLUHCI8FloeVzY+UsfS0AsZVT3a0tI=; b=3VCMKLSSP/skZzFeyJaKb9gAFwKWnT5zLo7scDKV68UtWkqL40CtXpbG8DYZ9vvzIOg5antYvZoe6w/5hRNwr0SkUuNX/O0XvOxDhTP4q9XBJTfByamQa5I7pwfpfgyV5mzz+BdtaALnU7PAHHSnmmvn9UHWGp+QInGKg6pfeaI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 16 Sep 2022 10:32:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [for-4.17] xen/arm: domain_build: Do not use dprintk unconditionally Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220916071920.8287-1-michal.orzel@amd.com> <4f4e254a-6b54-cdf7-40bc-89c25172bebf@xen.org> From: Michal Orzel In-Reply-To: <4f4e254a-6b54-cdf7-40bc-89c25172bebf@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT070:EE_|MW4PR12MB6974:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f5f5432-e429-44de-fe97-08da97be0094 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YB2cw7wSokML3qv4YiMkRihAg4fWSyq97IZ3FlW48IDBQuXB2I2J+xHdzpdSaUn3w90ywF3CW3Oq1QoIBcH7wCUGZXXfzvihoBsnxANIxtEGe/Dx2xT92sspXxO29GCHfnMX07yt4rl/nOFIcg6vJboKmbUwbTXqHbP5KxHsHV+QtEFydZ0WE28zxMrtEs3YvQ2BWwTqjE5B+9rleUZ8qH0q6zp56tdcnYTZ/JQw5hkRgfPNW5gWf87tMkjcfjdb0bXigwE8fjGH9URyyhQLr4YnBrfwfi+tVtT4wb2c1O5pA+kpdelFd3m3HB0erRHFYmindO0EaSqjnQ2cBljNS8fqIx3K+gZzG5f/7LaQT5rkmITnl4jOSt2eIRDWEcrpzUyUIhuk6zd7LFPAPkPsUSnnIozUl6U42VslihUew3gtJr8tXdBZaEk5P3c0fQzUB5OPpwxlxsCIzV1QjMdZcUWAK7aoEmRT0bpCvqS/WayMib4Msp5E5dyYf61I/ciJgpm9NE0fFQo4mRZ0p+Erl3yL3fvp2lvM/N28EeTpRAbaseHP9QONv/Ty2IMD/fNyrrzPZJxKDAFzZ2Jtnm63qqN2iNw86ykgG70VpdT2EdA0ubMqYR/v6k5H+KEryRtfEoIcyYf8xin8s2bY9xQccACUyXwQrhaZuY0c1mM38Y4UERDCJdUTTxgvYQNDxAOn3VMjK3dbCNgLlNSnV8p3ZDKF09xJqdHKq1pIQKpxDQMH+bX9581VNpWKk07SXQSRaRnHkPqhcUib71fvINQdpVXtaWjHkIq49UEaHkd6qbOg4cZcib18OpMokkWxT6/dqyZNElTxFs+7p15rdKizlg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(46966006)(36840700001)(40470700004)(426003)(47076005)(54906003)(2616005)(110136005)(186003)(26005)(82740400003)(16576012)(336012)(53546011)(316002)(44832011)(83380400001)(36860700001)(5660300002)(82310400005)(70206006)(8936002)(41300700001)(31696002)(8676002)(36756003)(4326008)(70586007)(2906002)(86362001)(356005)(81166007)(478600001)(40480700001)(40460700003)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 08:32:33.5066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f5f5432-e429-44de-fe97-08da97be0094 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT070.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6974 Hi Julien, On 16/09/2022 10:08, Julien Grall wrote: > > > Hi, > > On 16/09/2022 08:19, Michal Orzel wrote: >> Using dprintk results in printing additionally file name and line >> number. This is something we do not want when printing regular >> information unconditionally as it looks like as if there was some issue. > I am OK if you want to switch to a printk() but I disagree with this > argument. dprintk() is not about error, it is about anything that > doesn't matter in release build. In the vast majority of cases, dprintk is used conditionally. That is why in the debug build you cannot spot a single line of log starting with a file name + line number. That is why I assume this behaviorto be abnormal compared to all the other logs. If someone adds a printk starting with e.g. "$$$" this is also not a bad usage of printk but would result in an inconsistent behavior. > > I don't think we should just switch to printk() because dprintk() add > the line/file. There are message we don't necessarily want to have in > release build. So dprintk(XENLOG_INFO, ...) would be right for them. I think this is a matter of being consistent. We do not have a helper to add printk only for a debug build but without adding filename/line number. That is why almost all the dprintks are used conditionally. > > Personally, I find them useful as there no grep required and/or > confusion (but that's a matter of taste). If it were me, I would add the > line/file everywhere. But I understand this takes space in the binary > (hence why this is not present in release build). > > A better argument to switch to printk() is this information is useful to > the user even outside of the debug build. > >> >> Fix this by switching to printk because this information may also be >> helpful on the release builds (it would still require setting loglvl to >> "info" or lower level). > > I think we should drop XENLOG_INFO to be consistent with the other > printk() in domain_build.c (after all this is a domain information like > the other) or use XENLOG_INFO everywhere. > > My preference will be the former because otherwise most of the > information will not printed in release build by default. > >> >> Fixes: 5597f32f409c ("xen/arm: assign static shared memory to the default owner dom_io") > > Fixes should only be used for bugs. This is not one. > >> Signed-off-by: Michal Orzel >> --- >> Rationale for taking this patch for 4.17: >> Current code results in an abnormal behavior [1] and was introduced by > > It is not abnormal (see above). This is an expected behavior when you > use dprintk(). I did not mean abnormal behavior of dprintk but abnormal behavior of logging even on debug builds. As I said before, I could not spot any message like this booting Xen at all. This is why I took this as a reference for "normal" behavior. > >> the 4.17 feature (static shared memory). Even though it can only be seen >> on a debug build, it should be fixed now so that we have a consistent >> behavior across all the logs. > > As I wrote above, I agree this should be printed in release build. But I > disagree with your arguments. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 16 09:00:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 09:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407870.650521 (Exim 4.92) (envelope-from ) id 1oZ7CU-0007e1-L6; Fri, 16 Sep 2022 08:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407870.650521; Fri, 16 Sep 2022 08:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ7CU-0007du-Hl; Fri, 16 Sep 2022 08:59:54 +0000 Received: by outflank-mailman (input) for mailman id 407870; Fri, 16 Sep 2022 08:59:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ7CT-0007do-IG for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 08:59:53 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2089.outbound.protection.outlook.com [40.107.20.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ecc60b9d-359d-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 10:59:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7034.eurprd04.prod.outlook.com (2603:10a6:10:128::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 08:59:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 08:59:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecc60b9d-359d-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UDx5LZ9AirpOeCX2Om55/FQD55WBNYmuIPkD+jLCPmCfreMFR7rVL9MbHy3cW6i08NhIeWqCqP21cxy/6guQ0XH9QmASaCEnNe8PS58FVlLWRP6NqG7DqXch8oQZm073kZ3hF9386obwzXrdzZWlXZB+OlIzL27TuDKMARHRu43aimssVcRr7e+kruFNW8oW90OnLZU+YC6FgdmQAjkuQCSn39CwVK85P8WYL/Q5556KHhdA5rFjn9steyuD9YbWHDMnlDAv8HEeikRw635RyM+nXe3jBxk65TEFy+oOSe0dIuPakNvIo4yTAmYo9S6uix8o+nfnd3UEaHEmUH+9Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rY/6OmsKQbsi3UUQuOxOs7Xe6uWtQ1Xlr23tnbdD/8U=; b=GfztoJ75w8hkka6geGPqw4Fg1reaLqdVNix/cLtxvaiWeIBtv8ZKkQqgkvUeTB6K1FAKbh2dVp0jE/AQ9A9JmZVJsoDSQyDYlbgilhh43NWDYe8ccg9AoJlfvlTz9p3D+i9kdmDvtO0934O53E0ZMEmj7t1I3xVxznW2vvQjUA7Jy9FPgLZVYIo7CLR5P61yepYv7jBTjRuB1nvPJVEeRTz5irbjUMRuGkIfEU0zWHzSmZYLdOyNpwG9NjZGiiPGAL5xntpqWnD6lRNzAW3Szx7WSMxnM+0ySWr96k5T1t3BEDOPKc4DQgWyf5VMRdLo7YgeJxXHXrz5riY6qXmWFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rY/6OmsKQbsi3UUQuOxOs7Xe6uWtQ1Xlr23tnbdD/8U=; b=urbDQaxCKtitwEx+zZXhDi4dvLZxsPkaAJou7fDFE0xzc6tDvFtdhe9xC683Zp2gmZvSAap0023FAHs3xXZgXPsJy+M6il/XY/NsUHxRpcRowUPe155MyXMQw1TPuv1D3Y1Xq4BfcO90o575xOAJqh3nH1YIEH0g48uferHaMpqJT6bGdBW7wfDp2UUcrB3eVEiBoFRMPYR6sChlh0WQ1kHxP2X3m5IadlUglUPFAtbxqM/qUHLxDGt4bB6GYorws2gyub1xEPT1OwrZU8FXxe7AEsoyrGTvxp/qRVrLZP2kGQGLok5jaeJICJxCzwb4JKtucSkwfAaGs28LKjzNXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 16 Sep 2022 10:59:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [for-4.17] xen/arm: domain_build: Do not use dprintk unconditionally Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , xen-devel@lists.xenproject.org References: <20220916071920.8287-1-michal.orzel@amd.com> <4f4e254a-6b54-cdf7-40bc-89c25172bebf@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7034:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e84f1d5-dd69-4a0d-a702-08da97c1cf72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JYhpKIEE4MFkppJU3cziiGTr0EkE038CGH3s2maV+t2UGhpqXaM+2I1m2P06DGkXOZctIrR5gLGvRTwQsMya8aRdY4y8j2WTJWqV8P5YJHh2tD+8gsStxzHNC4CCAPfQipLwd1Z28Gc/lbiOyOejHvAS1Gn4TalMXI8rHhp05EujuepjiWcrscHQf4jV1uyR4i3CGkt5NTt6XW2oXrAZlwF9bLDSKZJWrNhFzn7EO6nzXiYK27soi4PN2N1L2ejSMLCsNhrjs7eUCjmjFvRNrhqgHwLXvZd+sFxQg71sULNYMQYPKooLdJll5/8Z3C1Dx9NKh5M4liEt1oddT66KKXP5J9kkZ/tglioYItMnoT3jyB+FNZZMX0zBb6nX671NKe9MKBiMoPKXFCV4tRqQq2n5vrjsnOuVBhWuSdA/4R7J80rIqs4qJcPdkI1D6dRXaa5ympI17S0xZXYJbuNj/fbc6wDOV0lKkcxaIBLVRJX3uqJ4UsHlmDQE6UvAouOsp715nPr8r0ZQ3lvGhi9ge2JcT0CmErqETz5RP05KElwdXoQkBgceqFl//JnSD6+FtIMJu10CYkGTyd04CwwYN6nYhEHsx3I+pQ5mz/OzWCon4y6CnvC/g9Kqt4hT6WdjRY54YRJsLP/9/CV7mkH5n3k8/ToRNCpqFlP5tHKKnB3DpuB4Tz68SmafciMcqWhRRo0ot1r0+oMA+gmAC4XWJOIuFawh27Is07UqBnYzsIYG3v/oC9Pbivxhpt9QdljJiANR7kqsali4uGEosrAoK0W8KxlMsApok+pDNedpAxA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199015)(186003)(8936002)(2616005)(66476007)(66556008)(66946007)(8676002)(36756003)(4326008)(6916009)(316002)(54906003)(86362001)(5660300002)(38100700002)(31696002)(2906002)(83380400001)(6506007)(478600001)(6512007)(53546011)(6486002)(26005)(41300700001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpaOW1XQkhZMVJNTHpxa2JsV1dlNDM4YXR6RkM0NzNXSTE2R3pEMm96Ri9r?= =?utf-8?B?TU1wK0xZTlB3Z1ZDNC9Dbm4zeWZIcUo1RTdWVXZqVEM5bTNDejcwektpQmk3?= =?utf-8?B?b1dLcHJXbXdVU0NpZDNxVUpOd1RkRUxQSk1xU3VIR3hyQWE0eVY3L1BDTTZV?= =?utf-8?B?UzUrN2lVT25reDVHZGhTS1RhU3JuZWJiYzVBM2FoVjlCcGJCVE5YMDNyRHFQ?= =?utf-8?B?aUNFOHJHWS9pcUJLdmRYU3BGWVJ1YTZaZmF6M2xtbUV4a1dnc1MrMjNtWDZX?= =?utf-8?B?OGcrYm1pSTZoaGVrbzhCeXhBbmE1S3FwWUphQ1NIT0dxUWg4Z1FXbVdWMXdL?= =?utf-8?B?amdCTitDTS8ySVgyZ25oa1Z4cENrQTRhbW5jTGJPdTNBSlMzaWpUQzc2Sk5N?= =?utf-8?B?TElzRncxWmRZaDlKWDVnR25xckd5NDEyUUpnY2x2dUxvRVJETzZyaVd5QVdY?= =?utf-8?B?YTljekorZmRkV3Z3aWwyclBHb2wzMnRWdVJOZW8yZWNwaFRrSjRQL1c4YzRI?= =?utf-8?B?ZVZ5ZzhyNFhVSTl1em55Y0JlcFFBZXVoeXliaUt0QkRtQ09kaDc4Vmp4RmFT?= =?utf-8?B?NWpBTHNTUUZRdnQ0OHFudjdJSnpVZitPSUpXdFpJaW5nSWo1YjFSVm43QlJx?= =?utf-8?B?NDFtNHBJUjBDQlJYNXhzWVZ5c2xzSzVsUStsbDZvK2ZJTHd2Q0RRZ3NFai9X?= =?utf-8?B?aUNqdlkyeDRkeU1DMzM5VTh6SnRBNnJJVDBnSWEzM3pacDZCQm9xOVdINld0?= =?utf-8?B?aml5allTOTBKbitmeDJzM2NFNU9UdkJ4SGxNWGRqOE4wNXUvaU0yWlpLVVU2?= =?utf-8?B?djNNTUhtVU91UnRqRjI0SXRFTmxJLzE4MUdlYlhvMjRDUnFCTTdCTWkyKzVy?= =?utf-8?B?VFJpUUVEdENmZDlnYm9BUU1Oc3hjL3pNR1pRb0EvenczVUxubXIzM1p4OU0x?= =?utf-8?B?Vk4xWDRkdDNOaHFaR1VBazV2RzVHTkxVVWh0LzJTUnV4OTRPVmtLck1ueGh6?= =?utf-8?B?elQ0OFVZNjl0TVhPUUdXUWhzRG43VWhsU1JpMktURmxBcHlFOWJqbUlGRGI2?= =?utf-8?B?WnUyOHhuZERtS09ia0JJTjJDVFFuWG1TSHJnTS85Z3djdlU3Wkh2UGxvcUdF?= =?utf-8?B?NnN4VVVXV1BuZnpRR1ZXbXJDZTZMbTJiWXZSdHlmNWhOTkZHdDA2NVdRVUd5?= =?utf-8?B?bjFweC9hY3N5aytuQWFsVzBLcTRobmVCVFZESHhKSDloMmhoRDVsYmFmWE95?= =?utf-8?B?bkEyRTFKckFVZ2ZtZUs1M2lLQnF1ajd6VlJBQjkyM0RIQkpUZmk3cnJJKzk4?= =?utf-8?B?Z29aL2tTTTZYVHQ4UGZMOGNuNkE3bHNqZVd3UDNORVhLWTVoSkVVR2JxaUJo?= =?utf-8?B?QlExckhGMGxFeTRzZkNobm9PTmpOMFg2b0tjbW9VUUhUUXlXSUwyNHF6UWIr?= =?utf-8?B?ajN0WDhVRCtQV09wb3k1b2wrYm9weGhTYnV4MEpvRy9SbS9Ea3laVFpYNk9v?= =?utf-8?B?SUJZQW1WQ00rRWFWdEZiZ05kbmt4N3JvYkphK3B1UTUvNDcrckp5UGpydDlF?= =?utf-8?B?TzhqQjc3c0JEVUxYSWtJZ1hqbnpxTWg3YjI1ZGE1VFN1V0ZzTDZFM3BPdTl3?= =?utf-8?B?MUl4WmV4SFRqS0dVbUdlOXRzYmREK1BWVEhocVhZNkwzSk9sOWV2Vk9KVHJn?= =?utf-8?B?L1VsaUw5SFVNeHVXZFAwbVV0ZUhsTVA1cjlFZTdyMVNZYXI1NVdOa0EyQmth?= =?utf-8?B?aU5wWG1HT3FXUm5tNHJlWnovWENQaVAzcVArMUplOGZtcVJsc2xHVnh4OUk0?= =?utf-8?B?azFyU2MyckdrZStTQWErRTloUlp2RkdSUzZtL2hiYkczVmNpSmhqTEZxR2Q0?= =?utf-8?B?bXplVWFmZ0liNUQvWTZxcThld0tSMjBYYng2dWhhaDhWRXgvZGNabHd1aGRT?= =?utf-8?B?WkpwSDk5MC9iUUxGT2NUVlJzR3FReGlBR3VBUDdJd1FXbDdwNTRHNG5SbXlU?= =?utf-8?B?NFFNVzNBUFVwNVNUakZBYng5SGRPOVJHSmNNY2Jhd284VFNKbzg3MEF4RjEx?= =?utf-8?B?bmwvcWc2U0xxNzBiNlJaZFZoVEJFeG8vc1FSUXg1RVVkdFErMzBmZy90TGpB?= =?utf-8?Q?gVEwPc9wfuVjNv5sjaBivECvb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e84f1d5-dd69-4a0d-a702-08da97c1cf72 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 08:59:49.2476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZNOs+9/OQVwlmxzKf+caqzPpvAmOr5rWSdlTxGd0N1ty5s5BL+S9ajuTmmdPsLcBpU9FT3NJ2s+EChBZmPJU6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7034 On 16.09.2022 10:32, Michal Orzel wrote: > On 16/09/2022 10:08, Julien Grall wrote: >> On 16/09/2022 08:19, Michal Orzel wrote: >>> Using dprintk results in printing additionally file name and line >>> number. This is something we do not want when printing regular >>> information unconditionally as it looks like as if there was some issue. >> I am OK if you want to switch to a printk() but I disagree with this >> argument. dprintk() is not about error, it is about anything that >> doesn't matter in release build. > > In the vast majority of cases, dprintk is used conditionally. That is why > in the debug build you cannot spot a single line of log starting with > a file name + line number. That is why I assume this behaviorto be abnormal > compared to all the other logs. > > If someone adds a printk starting with e.g. "$$$" this is also not a bad > usage of printk but would result in an inconsistent behavior. > >> >> I don't think we should just switch to printk() because dprintk() add >> the line/file. There are message we don't necessarily want to have in >> release build. So dprintk(XENLOG_INFO, ...) would be right for them. > > I think this is a matter of being consistent. > We do not have a helper to add printk only for a debug build but without adding > filename/line number. That is why almost all the dprintks are used conditionally. FWIW I agree with Julien and I don't view the "conditional" aspect as relevant to decide whether to use printk() or dprintk(). Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 09:38:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 09:38:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407876.650532 (Exim 4.92) (envelope-from ) id 1oZ7nJ-0003Vr-Gy; Fri, 16 Sep 2022 09:37:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407876.650532; Fri, 16 Sep 2022 09:37:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ7nJ-0003Vk-E9; Fri, 16 Sep 2022 09:37:57 +0000 Received: by outflank-mailman (input) for mailman id 407876; Fri, 16 Sep 2022 09:37:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ7nH-0003VL-PT for xen-devel@lists.xen.org; Fri, 16 Sep 2022 09:37:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b95474f-35a3-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 11:37:53 +0200 (CEST) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 05:37:44 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN9PR03MB6107.namprd03.prod.outlook.com (2603:10b6:408:11c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 09:37:43 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%4]) with mapi id 15.20.5632.017; Fri, 16 Sep 2022 09:37:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b95474f-35a3-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663321072; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mc2nJ1snMab3RF5GejHaik3NRr7ALviPop4XuGC8W1g=; b=AYh9qsUlXthcv33I/RtuDrJxTyYA2HF79S0hyot5MU8icpAmUsyTOJvd Opgq0U1Ie3PP501/YYEwk4JSVnZ8esBbjdCMv4azSRE/GuNpy+dCjMOB1 tEaWghRLLV9rVHUKtjS1cnPCJV3H1LGNOsrGAsqZWSsykHWAZbZiDS7b0 U=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 79817449 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mjSygK2soeuVd3Zo+/bD5dJwkn2cJEfYwER7XKvMYLTBsI5bpzAGy 2YXXjuHbv7Za2ukedh+Od6zoR5X68fQyoIwTFFppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8U035ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/g+I3hqZY09xqV6JX0Xt vE7MncvTR/W0opawJrjIgVtruIKCZCxeaYg4DRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2Ce5L2MwRFG9/MLb50DJywN8yv71Ocf9cd2WX8RF2E2fo woq+kymU0FDa4DDmFJp9FqererKuDj9dr4eBaCg18Bq20aKyn46XUh+uVyT5KPRZlSFc8lNJ lMf4S0ohac3/U2vCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5UCeHGdsc9JaQNkvtctzQCNw0 FaMxontHWY37OPTTm+B/LCJqz/0ITISMWIJeS4DS00C/sXnp4YwyBnIS76PDZKIszE8Ihmoq xjikcT0r+x7YRIjv0ljwW36vg== IronPort-HdrOrdr: A9a23:YvOEqa7ac/HpqAlD8wPXwS2BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcV2/hpAV7GZmXbUQSTTL2KgbGSoAEIXheOjdK1tp 0QD5SWaueAamSS5PySiGfYLz9j+qjgzEnBv5ai854Hd3APV0gP1XYaNu7NeXcGPjWuSKBJY6 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWiSw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYErhJavmnhnQYseuv4FElnJ 3lpAohBd167zfrcmS8sXLWqnvd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7kl6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklWqvoJBiKp7zPLd MeQv01vJ1tABKnhjHizyJSKeWXLzgO9kzseDlDhiSXuwIm70yRgXFoh/D3pU1wha7Ve6M0mN gsDZ4Y6o2mbvVmGJ6VV91xNfefOyjqfS/mFl60DBDOKJwnUki926Ifpo9FrN2XRA== X-IronPort-AV: E=Sophos;i="5.93,320,1654574400"; d="scan'208";a="79817449" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CU6SuHzhW34mDfzZprCNJqm0KthFcLA3bZS25FtawgQod+W2dOL2CoL8UuPblARQaraTYevUIiAa3DUXCbucoAwkhCxCGpDSqozRiuT5Eq2FOLfAMv4MCURYeDiEEj3o38KdezCE+n+zbKtrSFaG///LcWiPhbR6NL7emDW0bxI3Bv8fgJfJg0e9TIvHFXMriRbIb5TTQCOUHbxzkVVJ450nhCO6D4DC/y80Jb8NAFt/35V07p1Q4JZ4W+yN5hPXh1nisjV2KYgrSmrBhjWWHEvMkZ40sHpCzjWOHwJfjkVqb4ZgOFbPGTCk3WzCHrpx7N1hGnKpAfvf2G8ChF5kGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47SEWiMq5Kg7lanT8g2K8KCV0HeDgSQYEYpcOst/oUk=; b=di9jGT5Q9NnGZzlPJXgiG1kSNTbH26PdN0npJEF4uj6Yx2PTG7G+0G7kg1/0MxWJ0e/zB8+VeP7NrP8J1p13tUhBQ1HTH/kBPsLZIJBRHZn8HozGDBEOF+mwY/t4pPaO3452ZN+boP0+I9geNEt6lg6ykSj99snMhmaaoz/K+btrKPQCecB3gvjjOYLFjSe7+FzgHhumtaikabp3ib1QmdPofowsd+ZCrYL7hk5dYfYLiJB8TTI7iMRIHcYEEDykwiJrTnrtB8zekiPCtmqOoh/qIr7L8QNb34nz1f74G22NX7w1Uuro7bRUb9ENGC0IhdsN/aCy/WVUFdS7XTFHMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47SEWiMq5Kg7lanT8g2K8KCV0HeDgSQYEYpcOst/oUk=; b=V4KeQ6BTrJsmv3iD27W8CuYtjdjYqxJXhMLV8skqRdI3ViiLo5Sn4nD3Lu+5gGXbyy/APNN2yLrCD3fXURtMSrbBlCeAve9FEfRWL2obE99l1G21P0epqTZ1KDqThprMgSYyoOCqpX2QaMwK/DRM7SYmIG0apmsp2yWxjA4O2ZE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 16 Sep 2022 11:37:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Adam Szewczyk Cc: xen-devel@lists.xen.org Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BN9PR03MB6107:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dd2c10f-876b-4659-cbc4-08da97c71a97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PPm0IARsMspBsaQdUP1K578L2s19eC+RFRwoV6P+SvaQ6xfbkEwOETLMgSE/vKS26xo0NGiRTeq6SBmWcYI9xqbc8vdnllm4nj7JGZ8BgmK/iU3Hd5HMM2rqkK5NE9MI1VypBsU/Ne8erCCE9VYP/JGUlcW+2xU1413P6Fqk1D+xSpZOHsKUHmFxPKX3fubX5sBmMQ1wENAUh5ylnz4z9IL0oldaUkuXd6qi7tnrNR8koBqfxor96Znw6wf9SfkmTgwBSkoaIe19Rvckimoym5bSQACGA9A18m88Wvjpmmck/k9B0OfSSsontp05leLSG36ZZuj0KyTQpnkD2ex48/RaJi6AT40ZWfpbUkld+EdRQzrqZmm7cbfumQ/ekCHOWpByN3y2xU0tEolOosIBtVS2eiPEhoOvZrvXFd4f2rOTMWagniBEUtl21ipvUWaI+W2Jw3ObdjCQcOCsFeIyuxw1PYWQw1INgDvlPVqUk0VDiXLginzmyhFnxa6u7EKEK81g2u40FTbxRfxf7rofrCpN/MkiHjitdKsA5ZLIo+F4D34aZFSrJSXuzurTVLqUUPfGj96jGrd7N3uR+ZaZigbf4t7rVFcv6Rj00CAvMmJ9zySBCqwPx3NIa07ffmKfKyM+L8oMY/P+ATxtwZMETtNAlHbfhOqrAoHgB+Lg8GE9B2X0w7a041vkNJa/gw8ZYA7WB/pcJq3sl33e9pur+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199015)(85182001)(38100700002)(8936002)(26005)(6512007)(9686003)(86362001)(6666004)(6486002)(41300700001)(478600001)(186003)(6506007)(83380400001)(4326008)(8676002)(66476007)(6916009)(66556008)(66946007)(316002)(82960400001)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qld4NTJia3lWaDc2MU5LVGJobnFiR0YxV0d0SnhIUk50NUVnL3lGbzUydDNS?= =?utf-8?B?bnY0SVJSYmtUYkRtYkRaTTVHUXp5TE5wdjhOVEJkd2pCT3BHRkxDUkE1c2NI?= =?utf-8?B?THd6WG5KclM5N1dlcmt3SmprZUJHNGhWZC9hNTU1WEswUUpFOEFybUQzUmRz?= =?utf-8?B?WkJHM1dFOWZZYkRTTlFyVTFBbUJhK1RwbXJqU3huenNtOERsNFZpOFRhWGlO?= =?utf-8?B?Qm9Cc3lRK2tWQ1dPbjdFSWtUL3k0dURDTUFaZUtSTHNHTFZLVHFzSkJacUpI?= =?utf-8?B?eFBBa1lXUEtuUkx3RVJlaWRvclFCRU5lcVlwSHFEVWhDWnF5S1lCRFFpQS9q?= =?utf-8?B?dFBvNW96OHZJa0Zwb2cxNklGTG00a3ByV0ZjSnVPMmhpNnZPU1VURlpWTnZp?= =?utf-8?B?ekhzc2x0OHFXeVRaeGVTSDc4MlNJSlBBTG9vU3pWY0VOVXoyeXh2djd3eS9R?= =?utf-8?B?ME5sQzhEMURFREp5OU5MRHJqRXVla0Jub0NmUERId25KSVVZMjNQNUx6dy9E?= =?utf-8?B?Q3JyQkg0d3E4UWVHQ082dGhNNzdjWGhLRzU2bEgxdjY3UmlzMk5RNmluT0Fm?= =?utf-8?B?Nk82UUJJaXpUNUNCenNjQkZOOW9mV0R1S1UvSHNCdFBUa213MGM1SnR0akN6?= =?utf-8?B?VXczUGZIN2o5cmFsZitrR3BUQmkvbXJpUU1UUEJjbzdZZDNYK3pYSVdPSDRP?= =?utf-8?B?M2s1RWVaMEZyWEpNYm52MzhYa2owUkY5d3JxbDdQTUJyVjVUcXgxampJTG0z?= =?utf-8?B?KzkxVjZDR1NUTW9taXRyRFVjNjV2UjZncmR0ODVtRHQxZ294cTZFaXgzQzNj?= =?utf-8?B?U05BVWtHb29LYytic2dqeVVWZFdrWHpvMEI1bUNvZTZTdEo1WHBFaDBDTk0w?= =?utf-8?B?QnFyd0NJZXM2OGxHSW04UEdBS09vRDJBYjdDNlF3bmtRY3dCbWIzRFJ1RDFS?= =?utf-8?B?dERtZm9tVzZlWmxoYTBocUozWm1ramNJc1NPdUpIV2lqYkpKeFRiVmFUWXJp?= =?utf-8?B?ZVRQRVBnYUk5TEZUSjBPeGtVd0VjY3dSZjd4dFB0Tm9BR3BFVlk5a01PU0FP?= =?utf-8?B?eXhXNkM4bWN5cm5MeUlpS2w4NCsyOGZrZldkVlVjTEVhdmxNOG9RVWx0VTNK?= =?utf-8?B?WTJSYkdRenRKczF2R2hWQnBzRU9YTm5LM1FGL290S1Q1L2Y1YjhBYVlaV0RZ?= =?utf-8?B?N0ozNTJRMGdWT1R1ZGY1TGlubDhOTllLRzcrQXpvUEZJTjJSRjI2cXh1NExN?= =?utf-8?B?ZVptcllWa0piRW9HZmFSY3NjODZ1QWIrcjU5YlFBT0p3WHkxSEIzZjliWTJy?= =?utf-8?B?YkZqYnQ3SDBUUXg4ZEc2ZjBDSGRGOUpORTNuN29ienNlVGp0UU5WamdyZWlw?= =?utf-8?B?Rkx6dUhaeFVWbWh4cFpwRTZJeGxBd3lWOWlFWU1zOW9qTDlHRm5JdGhsMzNN?= =?utf-8?B?NC8rdUx1MGx0WG83UEtRYi9uc0hnUkZjVFJ0S0k5NFhmajVEZndxL0xvVExh?= =?utf-8?B?RXN1MXNsbEZnMzJSR25VY3daVlpYVm1KdUppNS9GVFRnaStISlA0Z04vVDVX?= =?utf-8?B?MWdXZVpMV1hNNkRLTHlXaVBzNHQyZlpIZmVsbGJCTlJvYU0rVWNZVTRWUUNL?= =?utf-8?B?L1Fqd1pJdlpTSVZYR0JJalZINlJJYk9sZ0ZqSTdJVCs5d1BtenBPTEFENU1a?= =?utf-8?B?L3F6NTAveEp2QXdZT28vbzFjUytzWGZCaHdEYkpOTFJaUTJFdVNPV1lPVTJM?= =?utf-8?B?WW94VDJiQU4yL0R0OGNNVUQ5UThTdGdXSG4vbjAveWtIS0hyMzY2cmJ6dUtG?= =?utf-8?B?WVRmSzByNWI4Y25hSUxrUnMvS1QvYnFHK05aaEN3OXlKZzlVeXAzcVlMSDZs?= =?utf-8?B?bzM5MHVTMnRSRkk2dG1sLzhxMzB6ZFlJZVprdTFHaGV1dmF5akpXWlg2RGVP?= =?utf-8?B?WUQwQ1plc1ZSQU9SYmJwd2J0d0FDVlFJbVkrbmVtZ2pMaUtuQjQwMFRjMkJw?= =?utf-8?B?cllWOWdwL0NVa3djdEViRzltV0gycnNlODZJZ3pkUm50RVFKVXhjc0hZZ0ZM?= =?utf-8?B?RHFlZ1pYazJRV3BMNjBucGdzckkyZEtIYUs3cnpHZDUvTWVycTBMQjVwc2pq?= =?utf-8?B?SDZyWGx1RG1SZ2I3cHVwTmNnbEUwK3Y4aGVhZEZVWTU3dERuUTlTeXkyMnM3?= =?utf-8?B?UGc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd2c10f-876b-4659-cbc4-08da97c71a97 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 09:37:42.9131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UE6pfnZKbC3r0caTUaqDgy9PY+00ST+DWMgL3ALReEF9P2jGaAMOxJtzy/rfnaOj7a8jXLe/dkk7HYH2/HYVow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6107 On Fri, Sep 16, 2022 at 08:22:43AM +0200, Adam Szewczyk wrote: > I have QubesOS 4.1.1 with Xen 4.14.5 hypervisor system on which I want to > install OpenBSD as a HVM and pass through my NICs to it (Intel Wireless > AC-9560 and Realtek 8168 rev 0x15: RTL8168H/8111H). I tested that when > installing OpenBSD on actual hardware both NICs seems to working properly. > But on hvm ethernet spamming me with: re0: watchdog timeout messages and > not working. Wireless causing OpenBSD Panic! Can you also paste the panic message? > first throwing errors like > this: iwm0: fw chunk addr 0x404000 len 712 failed to load. So you tested with two different devices, and both failed to passthrough. We need to analyze the issues separately I think. AFAICT, for Intel Wireless AC-9560 you get: iwm0: fw chunk addr 0x404000 len 712 failed to load. For this, could you get the output of `pcidump -v` from inside the guest? And for Realtek 8168 rev 0x15: re0: watchdog timeout For this one, does disabling msi fix the issue? I've been looking, but have no idea how to prevent OpenBSD from using MSI interrupts, either for the re interface only or globally. With MSI enabled, and the guest running, can you paste the output of the 'M' and 'i' Xen debug keys? You can do that on the serial console, or alternatively: # xl debug-keys 'Mi' # xl dmesg You will see the output of the debug keys in the `xl dmesg` command. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 09:53:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 09:53:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407885.650542 (Exim 4.92) (envelope-from ) id 1oZ82D-0005w1-TM; Fri, 16 Sep 2022 09:53:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407885.650542; Fri, 16 Sep 2022 09:53:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ82D-0005vu-Qo; Fri, 16 Sep 2022 09:53:21 +0000 Received: by outflank-mailman (input) for mailman id 407885; Fri, 16 Sep 2022 09:53:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ82B-0005vo-Vg for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 09:53:20 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63c165ad-35a5-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 11:53:18 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6E2175C0242; Fri, 16 Sep 2022 05:53:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 16 Sep 2022 05:53:17 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 05:53:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63c165ad-35a5-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663321997; x= 1663408397; bh=3F5EhWcHZGFfFUAN3hVCv5Ci58w5HvyJL3q5jf9bKcw=; b=a rHg1GKjglLpaLViwNqQukHR8Vw90Ww4qqIL4s8VzSQ9+rFuKYBQuqw7rgkS55m8A CmUlqVmfAi01nMtM+dEF/Cz8mUNx6T9nUPbIhCa5EEhPYlFHwQBCCny9epuAYKp+ xYRX2yLlzB5OoNI/NpDUTeLjNzPx8d9JOTGMcfFFSUHvI1qfTIFOM28Y1aThIOqH 49fzyBF+k6xtfuJ0POlX+sQ8/qTeBbyoiOmCUM8+MweGipPbqUxf1+h4ZlfXe5E1 Ra40ia8Hj49es0cg5PCOzqUECOoT7EMkR+OLUxAt9zL50UbUuVYggp/JMp82dVqN 0KwuKEziv3nPrKkt3E6aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663321997; x=1663408397; bh=3F5EhWcHZGFfFUAN3hVCv5Ci58w5 HvyJL3q5jf9bKcw=; b=h9iTEpI7S9j0fpubzXRhn/UYM9i823ktxapnHZFCepNR k/QHctE4KTuPyPJ3PpOXvfbvmBE9x8ptR9lerRNoaZQsD6hJ9gJlfEFWGBh7qr6p SVpKrvEoVFBXvfjjR/XeJcX3qpsgsvIZ2ONpdbvr8MHVlt79RBfgKoqFQ0l/XtuR i0OaCnkg0mcSPC5ADbqb+1Gadx14fmhmVO8fH9RrLENi0m0K0BypOBP+fAJwOO7R GvOqhM13cArA5vpG+xLNY5X25cFg/GB8+lb8BVcwGdd7srH+LcgTKCYEOV2iqR4M WL6ay/9vFweXM4bmAhvu6bQBRVwS/xPgjwrdudbN+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvtddgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 16 Sep 2022 11:53:13 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Tamas K Lengyel , Xen-devel Subject: Default reboot method (was: Re: Console output stops on dbgp=xhci) Message-ID: References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YljcGCVhqb5A4CCT" Content-Disposition: inline In-Reply-To: <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> --YljcGCVhqb5A4CCT Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Sep 2022 11:53:13 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Tamas K Lengyel , Xen-devel Subject: Default reboot method (was: Re: Console output stops on dbgp=xhci) On Fri, Sep 16, 2022 at 07:57:59AM +0200, Jan Beulich wrote: > ... this leads to the crash, which effectively tells us that this is > likely yet another system where one needs to override the reboot > method (e.g. reboot=3Dacpi). At least Linux, but also XenServer uses reboot=3Dacpi by default (even on EFI systems), can we make it default in upstream Xen? Issues with reboot=3Defi are rather common, while reboot=3Dacpi just works. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --YljcGCVhqb5A4CCT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMkR4kACgkQ24/THMrX 1yytjgf/Q/qM4DVc+onkvsdHr1r9uzPSogSytyocsyaIJAu+RG+AmSB6uV9jNax0 ctEmU/Xtjz+pry9/9bsqVPLmBTV1T7Npgdlp3dqzERV8XK+D2IEbaFmWeV85Ffjq tBVbKrz3kMmJZte+XR1Nu5CeWKjxY7kv114ABl6ZLeGSDWHA3gMi60waT0o/h3b4 FT5vWJyBU10gETs8xJJTII4Y0r/1zJfx6JSL5BNbt6VMNI881SNt6tQ9G4L+J4xz FVsoLiVH5Bsqu5atnSy26ymHKHccl3a8FMnjClwVQjFmO0kt3gQl9yKT+9yIycWK ONq7WwApJtJoXJxt70G3tRIvKRChyg== =ObnP -----END PGP SIGNATURE----- --YljcGCVhqb5A4CCT-- From xen-devel-bounces@lists.xenproject.org Fri Sep 16 09:59:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 09:59:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407892.650554 (Exim 4.92) (envelope-from ) id 1oZ87o-0006bs-II; Fri, 16 Sep 2022 09:59:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407892.650554; Fri, 16 Sep 2022 09:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ87o-0006bl-FZ; Fri, 16 Sep 2022 09:59:08 +0000 Received: by outflank-mailman (input) for mailman id 407892; Fri, 16 Sep 2022 09:59:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ87n-0006bb-5r; Fri, 16 Sep 2022 09:59:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ87n-00038J-1S; Fri, 16 Sep 2022 09:59:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ87m-0007dc-Ik; Fri, 16 Sep 2022 09:59:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ87m-0008Rb-IC; Fri, 16 Sep 2022 09:59:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oIGENp3xacG6GTd5VgjQX6HaQ4lZ8S5Mu19TAPJrFzg=; b=gCLFzBi082kXFzynNvFU7e3ZE/ SkkRYeN+Z0cEHSaAW92yEG1XzCb5J72E6pNB4NaPpWQ4QzQQ3nFJJAONndKD5H6vnOscvYUpJL88v ejzc3OVq7HXaaL3Hu7pRp0LnejtAJ5Q5CenSVgSksr8Qfzseww39rAmApxLVXt0+N9DE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173229: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c83c6e4e7a68767ba69159bc0316884fa81158c4 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 16 Sep 2022 09:59:06 +0000 flight 173229 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173229/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c83c6e4e7a68767ba69159bc0316884fa81158c4 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 798 days Failing since 151818 2020-07-11 04:18:52 Z 797 days 779 attempts Testing same since 173205 2022-09-15 04:20:23 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122980 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 10:03:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 10:03:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407899.650565 (Exim 4.92) (envelope-from ) id 1oZ8CJ-00085Y-3q; Fri, 16 Sep 2022 10:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407899.650565; Fri, 16 Sep 2022 10:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8CJ-00085R-1H; Fri, 16 Sep 2022 10:03:47 +0000 Received: by outflank-mailman (input) for mailman id 407899; Fri, 16 Sep 2022 10:03:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8CH-00085L-La for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 10:03:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8CH-0003JL-AF; Fri, 16 Sep 2022 10:03:45 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.124.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oZ8CH-0000JV-3z; Fri, 16 Sep 2022 10:03:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=46U12yxP6rLIf93pLk8uQYCX8NtehS+vHwzRGrChdTI=; b=SDB53tqkGYV/r3klrUCaChqqPW A6SGiqm5EvoI0pqF0bk7piRL/KzuNfQHgsrtw1ym5i2kbrViClIe811K2OVQ1WFR4zsf5MrQEHaRe VMvhUBlQ2UYoiLdHC3pBEv5FrHEtk5dbSyYPdB8zwBzJQRSPMHuxCHgv5RqQb3uSHkSI=; Message-ID: <4eb0dbc8-ae37-5299-6aea-74a483668b99@xen.org> Date: Fri, 16 Sep 2022 11:03:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [for-4.17] xen/arm: domain_build: Do not use dprintk unconditionally Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220916071920.8287-1-michal.orzel@amd.com> <4f4e254a-6b54-cdf7-40bc-89c25172bebf@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/09/2022 09:32, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 16/09/2022 10:08, Julien Grall wrote: >> >> >> Hi, >> >> On 16/09/2022 08:19, Michal Orzel wrote: >>> Using dprintk results in printing additionally file name and line >>> number. This is something we do not want when printing regular >>> information unconditionally as it looks like as if there was some issue. >> I am OK if you want to switch to a printk() but I disagree with this >> argument. dprintk() is not about error, it is about anything that >> doesn't matter in release build. > > In the vast majority of cases, dprintk is used conditionally. That is why > in the debug build you cannot spot a single line of log starting with > a file name + line number. > That is why I assume this behaviorto be abnormal > compared to all the other logs. > > If someone adds a printk starting with e.g. "$$$" this is also not a bad > usage of printk but would result in an inconsistent behavior. Every lines are different, so it is not clear what you mean by inconsistent here. For instance, we have quite a few lines starting with the subsystem (your $$$) but not all of them. Would that be inconsistent to you? > >> >> I don't think we should just switch to printk() because dprintk() add >> the line/file. There are message we don't necessarily want to have in >> release build. So dprintk(XENLOG_INFO, ...) would be right for them. > > I think this is a matter of being consistent. You can't really argue about consistency without explaining what is a consistent line. As I wrote above, a message is mostly a free form. Some may use 'rc=%d' other 'error %d'... Yes it would be good if all the errors are printed the same way. However, this needs to be a tree-wide decision rather than localized and something really not worth the argument. >> Personally, I find them useful as there no grep required and/or >> confusion (but that's a matter of taste). If it were me, I would add the >> line/file everywhere. But I understand this takes space in the binary >> (hence why this is not present in release build). >> >> A better argument to switch to printk() is this information is useful to >> the user even outside of the debug build. >> >>> >>> Fix this by switching to printk because this information may also be >>> helpful on the release builds (it would still require setting loglvl to >>> "info" or lower level). >> >> I think we should drop XENLOG_INFO to be consistent with the other >> printk() in domain_build.c (after all this is a domain information like >> the other) or use XENLOG_INFO everywhere. >> >> My preference will be the former because otherwise most of the >> information will not printed in release build by default. >> >>> >>> Fixes: 5597f32f409c ("xen/arm: assign static shared memory to the default owner dom_io") >> >> Fixes should only be used for bugs. This is not one. >> >>> Signed-off-by: Michal Orzel >>> --- >>> Rationale for taking this patch for 4.17: >>> Current code results in an abnormal behavior [1] and was introduced by >> >> It is not abnormal (see above). This is an expected behavior when you >> use dprintk(). > > I did not mean abnormal behavior of dprintk but abnormal behavior of logging > even on debug builds. As I said before, I could not spot any message like this > booting Xen at all. This is why I took this as a reference for "normal" behavior. To me "abnormal" is quite a strong word and in this situation really a matter of taste. Anyway, there are way to write the commit message in a more objective way. Some like: xen/arm: domain_build: Always print the static memory region At the moment, the static memory region are only printed during debug build. The information could be helpful for the end user (which may not be the same as the person building the package). So switch to printk(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 16 10:21:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 10:21:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407912.650576 (Exim 4.92) (envelope-from ) id 1oZ8TD-00029B-Lt; Fri, 16 Sep 2022 10:21:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407912.650576; Fri, 16 Sep 2022 10:21:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8TD-000294-J1; Fri, 16 Sep 2022 10:21:15 +0000 Received: by outflank-mailman (input) for mailman id 407912; Fri, 16 Sep 2022 10:21:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8TC-00028y-3S for xen-devel@lists.xen.org; Fri, 16 Sep 2022 10:21:14 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a24d0d8-35a9-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 12:21:13 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id z25so34860427lfr.2 for ; Fri, 16 Sep 2022 03:21:13 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k28-20020a05651c10bc00b0025e00e0116esm3612372ljn.128.2022.09.16.03.21.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 03:21:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a24d0d8-35a9-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=unuENXp5XxWAMuOHE9gtvGUFk2dn9o6HiYCwiikE1MI=; b=Khpzc/tx42zQb/rh2bWodHFxgXN1ORuAODQnbikBmE5bck7kqwuaIAEoA3r7c/PqbF 9kgy1Se9OonniSyuYYXOH5XaQXVAzLIRP5d2XsFsSPhgl0ZEfs6Dmn4NlLqxD0lsqZpO trbui6UTkGemwg58bsN3o4kpf+O/V0+HEDTr1nsSJJQjy9WYsyWjBnAeAwG2DTKZtszB fxB9fCeb0xIdIvU1AI0ObTg0lh+3pBEOfSbVYepZoiDZg3AtXJ4qZBncnOKoxhAPMMle yL0ItgG6MzY+aI3J73f/2Tw8A/CB9ur7XevM3N0fBam0UOss5SfZ08LQR9ST13Ht06iD gObQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=unuENXp5XxWAMuOHE9gtvGUFk2dn9o6HiYCwiikE1MI=; b=Ov2aybMXDCRLAkFUXupoOcZXtaZ1fF/CQdzQhBhxFVkRpzxj2zLFAvdkP7EQOYivV8 V4bj0G/UXpRnclQQahrmBwT2gt2UH9+Zj8K6TTTc+UvykDS8CL0woeuPeQv6be5D75Lw NOavnzWPvn00KZewflMvecSxS5h3bXCGv97/HKJDA8rBXhdiWe4yQ0hIb3p6+xaHubI8 X2IhDNu8sksoHl+LcIjx1tUnneW59qRfFADIGoV/0WJAWGrZbiw50IE1+UQ111C8C7Yf 0uYZgLeBlGe5FNk5yhEd94iRAOAOAbViPI6lg7T1ExbXX/eDIpEG8EIO9FZwybSFYn07 e2cQ== X-Gm-Message-State: ACrzQf0JCBVqFQjifIB/D1g6HfsTbg1nr3QK8H1Oq7BlGkCNaXFC2wU8 akbJwrCaBZgOpagNcuzPdoE= X-Google-Smtp-Source: AMsMyM7/GVIyLpzH4/iC12nMtxo5LEvGitMwdQQWmpdp70mof0Slz3FZfb65wgQtpR/PtKuwlxL8Bw== X-Received: by 2002:a05:6512:38b2:b0:493:9a:ac2e with SMTP id o18-20020a05651238b200b00493009aac2emr1374758lft.126.1663323672293; Fri, 16 Sep 2022 03:21:12 -0700 (PDT) Message-ID: Date: Fri, 16 Sep 2022 13:21:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Content-Language: en-US To: Viresh Kumar , xen-devel@lists.xen.org Cc: Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Wei Liu , Juergen Gross , Julien Grall , Anthony PERARD References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.09.22 17:43, Viresh Kumar wrote: Hello Viresh > The iommu node will be required for other virtio device types too, not > just disk device. > > Move the call to make_xen_iommu_node(), out of the disk device specific > block and rename "iommu_created" variable to "iommu_needed", and set it > to true for virtio disk device. > > Signed-off-by: Viresh Kumar > --- > V6->V6.1: > - Initialize iommu_needed at declaration time only. > - Update comment. Reviewed-by: Oleksandr Tyshchenko > > tools/libs/light/libxl_arm.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 55aee15c10b4..fe1c92383dd6 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -1157,7 +1157,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > size_t fdt_size = 0; > int pfdt_size = 0; > libxl_domain_build_info *const info = &d_config->b_info; > - bool iommu_created; > + bool iommu_needed = false; > unsigned int i; > > const libxl_version_info *vers; > @@ -1265,22 +1265,25 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > if (d_config->num_pcidevs) > FDT( make_vpci_node(gc, fdt, ainfo, dom) ); > > - iommu_created = false; > for (i = 0; i < d_config->num_disks; i++) { > libxl_device_disk *disk = &d_config->disks[i]; > > if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > - if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID && > - !iommu_created) { > - FDT( make_xen_iommu_node(gc, fdt) ); > - iommu_created = true; > - } > + if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID) > + iommu_needed = true; > > FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, > disk->backend_domid) ); > } > } > > + /* > + * The iommu node should be created only once for all virtio-mmio > + * devices. > + */ > + if (iommu_needed) > + FDT( make_xen_iommu_node(gc, fdt) ); > + > if (pfdt) > FDT( copy_partial_fdt(gc, fdt, pfdt) ); > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Sep 16 10:28:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 10:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407917.650586 (Exim 4.92) (envelope-from ) id 1oZ8ab-0002p6-FH; Fri, 16 Sep 2022 10:28:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407917.650586; Fri, 16 Sep 2022 10:28:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8ab-0002oz-CO; Fri, 16 Sep 2022 10:28:53 +0000 Received: by outflank-mailman (input) for mailman id 407917; Fri, 16 Sep 2022 10:28:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8aZ-0002ot-GE for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 10:28:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a5aeaf8-35aa-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 12:28:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7331.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 10:28:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 10:28:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a5aeaf8-35aa-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bquvh/Zq01soxvTur9C8gb+AWAGFDQu0svPOh6jtoYxNDlLJzYDhTqQYJn8j3/+yzYJnf+VTwqbiKvxSGeZVjr8+BiJwYSXwgyLMWLCN3aQ8w37JteRms5FyEo9/y4ysLrOsQ7CR4NHmZLvYPKEWBraN4zSo1sdUz5+VqZelHVzQp3k7AP4FPqSPIXyuQW7keh0nTDN8grsgTb+L7OUMi/Y6EuhFoxL4ln46BWO+TnLfGZty+7+mGI7Fm1a+HmQ7NSvEmuqSkwgsUARsipvZsB3S2a8wVW0bjdsoDkscSACuswcgrYQQv0DkjZjGMTeAT/NELTed843ZGBEIe1RMug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQTYyB+8lI9R9twfp/m7oqt+qDJkVuIRiztfjyjIo2Y=; b=VWv+fRbflDaTxVvOFd44LHe8gaJ01agEHTJekafGIOq+GDtmu2sBRwcU6f4+36IgO5FtfIOe8WMORzuIY/0AgryiODwZBXedou37K3fhTqhTmrCySKhjkDdUhcNKfEHOnHZiuKze9+nzI3XilOM5+YUDEgyDDgZN9plNtfCo4vw5bf+AjsC8BPVhEVU3iopIv/LPEzkQrWvbFYks+TdKlqRNkEUBaFh6AmCjDSAXeijbzqTC4URWLCE1yXKBO4zxHuhuZmhsMD9kaADXQbD5o0z6N1ZqlWmdICWv6vAQJNVRVpCHKxnuVRD5sb8GUxJ4hdJXAEoPoTknEFDqgQ7MMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQTYyB+8lI9R9twfp/m7oqt+qDJkVuIRiztfjyjIo2Y=; b=vewWXD5ToPCKCsDZiIlfKB/aTjnG+VwLxjSgUxx3WqEnbLt7SA2gD+WrQBlkGu90+ddZZQsChkSpfXKroGwlkFsIpsCZ2W/D/jTyudwIx3CHgSJTAwWmdB3hnPwmj7pQNCPxEckT9oxtad2ogA7ss/UirKIDwzFnM5x2SyMlSpedqHd5cAK9Qnx/eQsjmgNNfMQXw0SZBNE6gvuU1yuJnukqIsdS2CXX9M5fbjpmHdV3RLGCZPkzZuAdBQnv6F91mEgsxItFTh9CeYWDvoQCXdMugIVwT88xI8WS6GQ/009DWXaCM5K0zPcvHXRjD46HuTK4moPYWRcGDlsjEeuiQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <92a8ad2a-9b9c-b147-c175-0a9b4dab4821@suse.com> Date: Fri, 16 Sep 2022 12:28:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Default reboot method (was: Re: Console output stops on dbgp=xhci) Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Tamas K Lengyel , Xen-devel References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7331:EE_ X-MS-Office365-Filtering-Correlation-Id: 6666fc17-b0b5-47b2-2508-08da97ce3d2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X/WKmrV14YzfLCc2XqgIcTWxXUEHhuwTL4Y2YqQbfDvwEh0dpB+KIa4Gy2k96enORFkCWQEiaZ2fQQVQkLnWb9e5LX2t43neGmYzipLZyhoS/CUG3Su+JYUBdfvIBIHVmJeufHJPignQPv0+VEI1NePBTG3ZjdbuehQnXTev3leqH363L/simz6rAbRzGLXr0XJns2DHvxQrp4maBvjJYlygYTOcZyi03j2+QBkM8C0MtfJYVwBseZ2aAjebdFNfmbCyO6kxn8L0S41V5EtgLOK6mKrkF5CDBw86myzhCQXREFypC5WgROs+n6j+E6Zq2eZTi23yiu30GmCvTTfW046P1ArGo9LiVJnrDvRLVi4PEiN6iKOPKFwcQUSK7JB3Yw+/uIUNdQyk61iIoZeTBoxPVQCkfUH4AKfAsCql6jw8SE6btCnoRRDhCcq5LpdKhaRsttjipEef/AzghPbY1G61u/XgaMo5D6H99Iv0n3zzhjuiiUGzve+4Msh3nXPhKHCm7F8vGmIRjX/NU8iMUGdnytE1NYd5zZ/RqSRwVOxXzJgQ5JCFu2/dxczTz30/N6amIKIEqhB7IffqRxln8JM3gaAU/HrOIph47lUu00MmBbSgi2iYiYeZqo8Vkw45NNM3+lX4GqV55SV9GG2JeHLU1bgwtukDwUdkKAMbN29IrFskmAcFoUAY20KwfimZEFdEoi00MyLKtBJeoba15Lj3clBCq6XCqOD0D1AuLlzsjjrXfbBk6lL8IPmpiSKnd/8z3EbaD2wujtG7zWRymYlsq+aDd082qgo7pBPwx+4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(66946007)(8936002)(2616005)(6506007)(4744005)(6512007)(26005)(53546011)(66574015)(186003)(316002)(86362001)(54906003)(6916009)(6486002)(36756003)(41300700001)(31696002)(478600001)(31686004)(5660300002)(2906002)(8676002)(38100700002)(4326008)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGlVbXlPYVJXWEhMbXByMkk2ckF1dEt0SUIvZUIxQzlhcVBIUTJvTklFVVpB?= =?utf-8?B?QjVEWTdSN2g1SUU5WDJmNmtKdjZ6TVBBRjBOYzBtbWdVM3k2aWg3ME9hOCtX?= =?utf-8?B?TVhYOHhhelpSdnBTZVNPUVZERTVTbGhoN1p0V1R6emk5Sjd3S1BKNExzc0ZU?= =?utf-8?B?RXJvVEZzRjZtSDhKZlByWnY1WW9aUDRtUlJCS1VKemZVS2JHMEhFZFUzT29D?= =?utf-8?B?ekdRMDFrVXdlQm52Qmc1Qnc0ekt1VnJrK3JTbW41dnAreGYyNFFqRkd1M3pq?= =?utf-8?B?ZU1RSWVjL3R1aEJQZ2RudE9Od1VPYnh3S2UwNStUT1lCSVBjN3hqU0w5VjRV?= =?utf-8?B?YVZ4MjlJVmJqZEN1QTVPM2tFWXJMVWxXWEJ0QjRVc00rRGt2a2VlV1RHcDFp?= =?utf-8?B?Z3NQMjJEZTZUTFU3SFZZMlJIaDRma1EwemtnYTg1L1kzU3RnVVozK3diUkxB?= =?utf-8?B?clUrUU1OOVVhVElWbUx3cDVLL0hVM2hXU1hQNlY5R082dFp4TjU4VFlZaDln?= =?utf-8?B?TDFwZTRvejN3cEdNR1pkL0MxMjZUQk92dG40UC8rR1FrcVRNeUdRd3pXdGtI?= =?utf-8?B?WjAvSTk0cWpJMVlXQmsvMjRVNStGZFhicVZ3cGsveVh4QW90akpLcTNyT2Ra?= =?utf-8?B?Mk1nc0VyY0ZOc3FzSjhOcnN0NCtPcWlDaVUvYzg3bktDQ0xSYjY3WnRrUVB0?= =?utf-8?B?N0x5bVhid1AyT2Y5U0l6MnRjSG5UVHVRdEFYM25EUFl3dVRuSWh4MVMzeTJY?= =?utf-8?B?eDVIbzlnNVpyQjV0VG5VZExPSXFrUGMxMTdiT0c0SGlBbGR1c2pRNjI4ZjhP?= =?utf-8?B?V3NqaGFGN00zYXFDNVQveUhRTzF5S3F3clJGM2hYTWpra2sxM1UzRjlzdG52?= =?utf-8?B?R2J0UllyRjFmUVYrdzJkMUdFNjJUeDBiTDJnYWxjOTIweTJ2Qm9rZnhJcjRU?= =?utf-8?B?RXNZU3NocWJkL2pUNnFIWUlSUW9DcUhEdEJvMkQzeWFacXNqV3FkUytFVTh6?= =?utf-8?B?cmdBZ0NqYm9lWjYxNkp4VWlYckRJdjFjNTJjcGJ2STBiNkRmWnhPOG9ZVWZU?= =?utf-8?B?VEMwbVEwQ0hyQXprMUtaYTF2UktRUmFEMVowYzJBZmlCRStxZVRCNFRiTWFS?= =?utf-8?B?Q05rNUh5YTNwMFd5LzdISWVHV3pVeTdrYjNHMWMzK283NFpqTnhxT1piRUV0?= =?utf-8?B?QUZ5T2xCUlFaZHdEU3RxWGtXUEZ0ZUdubkJlbUZ0dDlaS1ZuOFlrRUcvNGZa?= =?utf-8?B?a1Z1c2NXN0lvSXdCTEFvdkszenNHNDBKZ3VldnRSaUwvRXVCQVg4TjhNU05i?= =?utf-8?B?dXBrUGhyNWtUcjRPR0YrOVh6ck5YQk1nbjcxVEYwaURVeW5VV3R5UnRId0py?= =?utf-8?B?OWd2cUg3a080U1pSQlVFS1dCZ2htdWdDV0xpeGE4Ryt3ZnRCWFBqakdFbGh0?= =?utf-8?B?YmtoVGtjaTVJb0NYcUxVU1Z4YlZGeUZyQ01HZGVvT0ZrQ2huaXhPM0Y3dU85?= =?utf-8?B?TTNDcTB5SEhjcUlHcW0zTTdudGYrOVFTd3BDY3BEaXNTWDZaeHlrOTk1SjB4?= =?utf-8?B?bk1xZllUVzlRWllRODBQOXVHZ3BwRnE2NDI2b3ZPdUMzdHRZQ205bTRTUm9G?= =?utf-8?B?K2NzRXFpeHpwVEpNdDBUb2RWckhQclBWc2kwMXhZVmdzMFE5NU93VTBGdHlS?= =?utf-8?B?azlVdTZPT1FQS3pzOGFSQzZvdDBFelllRnA4SEN1RnJuaGlnWmtVRVZyN3Ji?= =?utf-8?B?a2VSZjdxZFdEd3luSEMvL0p2RGx4Y0lyWlkwZXYyYXdIcjE5WnI5QjIvNEVM?= =?utf-8?B?YVA3bWlLM0ladTE3SmYwTG9Xc1RudkxRTGdsaTlxekJpVFhwL0xYLzRtRmVW?= =?utf-8?B?ZUdITThxMnVHUGs2ZlZBQlgyclhyQTB0dk0zN2pCcWRWZnZ2MWVQclR3RGcy?= =?utf-8?B?RUM2bTUzeTJRUDlVVFJzUmR4ajlINWVwVTMzUitBVGxiZXhxZkJQTEduWnFw?= =?utf-8?B?M2tLTjVpVVdtL2tPS2dadk1MYzFuTTJZcjFNUnhOMU9sTzg0RnNpdm4xbUtq?= =?utf-8?B?bHUwVktVbGJxMXRoaW9Kb1d6YzFoSU45bDh1Q1FYWE1yMzQ2WWIrcWpyOW8z?= =?utf-8?Q?M5yk2GZoWWTuDvkkdGijLqtGZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6666fc17-b0b5-47b2-2508-08da97ce3d2a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 10:28:47.3294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rEyZ7CeaOlI1VNxRGDhEl2XxRTO4jkuJcmbacmx6jPd96ch1G649Id6IR5SW+GFoG+U9XsGu4Bj8EzfvbzdxqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7331 On 16.09.2022 11:53, Marek Marczykowski-Górecki wrote: > On Fri, Sep 16, 2022 at 07:57:59AM +0200, Jan Beulich wrote: >> ... this leads to the crash, which effectively tells us that this is >> likely yet another system where one needs to override the reboot >> method (e.g. reboot=acpi). > > At least Linux, but also XenServer uses reboot=acpi by default (even on > EFI systems), can we make it default in upstream Xen? Issues with > reboot=efi are rather common, while reboot=acpi just works. But rebooting by means other than the EFI runtime service has always been against the spirit of EFI. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 10:37:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 10:37:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407922.650598 (Exim 4.92) (envelope-from ) id 1oZ8j1-0004Iy-AG; Fri, 16 Sep 2022 10:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407922.650598; Fri, 16 Sep 2022 10:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8j1-0004Ir-7J; Fri, 16 Sep 2022 10:37:35 +0000 Received: by outflank-mailman (input) for mailman id 407922; Fri, 16 Sep 2022 10:37:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8j0-0004Il-Gz for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 10:37:34 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2058.outbound.protection.outlook.com [40.107.102.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 91ff8212-35ab-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 12:37:32 +0200 (CEST) Received: from DM6PR11CA0011.namprd11.prod.outlook.com (2603:10b6:5:190::24) by CH0PR12MB5204.namprd12.prod.outlook.com (2603:10b6:610:bb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 10:37:29 +0000 Received: from DM6NAM11FT108.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::b8) by DM6PR11CA0011.outlook.office365.com (2603:10b6:5:190::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16 via Frontend Transport; Fri, 16 Sep 2022 10:37:29 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT108.mail.protection.outlook.com (10.13.172.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Fri, 16 Sep 2022 10:37:29 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 16 Sep 2022 05:37:28 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 16 Sep 2022 05:37:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91ff8212-35ab-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1vHxPahjtp63rS1ff8LaHx7SpcUqYzyA/aRAQzBlKcuUoHZgyYFyw04kcyRZM+O3Ukd8H5kYnrdqe/P2/ab4ZPhUtqcsKqSsRefaRKqse3UFxshSbTVtFbQczN/lsYKUjzCFN9rlMp70D3hPJ7Dk7GUPoxnL4Paf8KMF4bcv+1+Z5KzA2bUVc/qPhPQn1OmDyagVl+YhQIzGHgbAL3uBaMcsfI6cp7u8FFB+r2lzIRRXy64lcKMIiAGzd36mbV9QkupamMmOJJaKsSCP2i1iwC8wbvHWVIyxyzvwrPj0eTOKcyDEITxieH4xfA7XINObvjDBkNKDaBk9I7vII32HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=etlaIZU/TW7+DS5pldYih6Ha+WXvrKAbjoFO2tu3zh0=; b=D6k3VxDePgxVyVY0KdG09gZNyKfEwo8gEoHty3jY8kP8wX4ZdBZdfgX/jeiKf0e9sBJrqyh5vlU/YXez/vQFDvw9yH9zf0ViwCscsN5NE2VjAqDOnqlXe+uo5mTOjLoASiV1UhIsVjZgUZjVc1DYCDD/TXL8Tmkmx0q2uUL3LlWwwbsx75BmbPGFlBDQpKH+nbhak02IgN5+JDJMBc/yiU22e5ZUwVZcVgritrvyQ6iiGMYvS4ugpZL7Rm6REbYE9AdB3VMMNgonX0m5h2zTJ53lRS7I43aZ1cO0QbQXgczCwHc+bSECvXydNHdVEmwT72gHsZVm2X4Dth7kop1T8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=etlaIZU/TW7+DS5pldYih6Ha+WXvrKAbjoFO2tu3zh0=; b=OcicySyfe/lZ0o6zjUIZWSxN9TbbZGoVcZKG+bPZUCuyinqZ5C092xypY0obyDuT+5JiMCzTtIGCRdew+LiZtH5hLivIqICG9gDokmHT7AnVoC67j1zk56wnpZMIh9di+WI1kE/w1E1lJBDxg//jig0GT1LYfq1xkrbXgSpcXwA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 16 Sep 2022 12:37:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [for-4.17] xen/arm: domain_build: Do not use dprintk unconditionally Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220916071920.8287-1-michal.orzel@amd.com> <4f4e254a-6b54-cdf7-40bc-89c25172bebf@xen.org> <4eb0dbc8-ae37-5299-6aea-74a483668b99@xen.org> From: Michal Orzel In-Reply-To: <4eb0dbc8-ae37-5299-6aea-74a483668b99@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT108:EE_|CH0PR12MB5204:EE_ X-MS-Office365-Filtering-Correlation-Id: bdea660f-6276-4bb0-c400-08da97cf7485 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wwm2rf/Hn7DjkKaMtjfz0c5MhgkgYIb09RkGM8fRv5sbf+imJV/rAqr+EQXPUNPZPVSNuKR3Bd86s9xg2ZCw/lrACmUFjz/9insUZklhzLfJ8T71g3/fKajqQxuQ2DjBQRBxvzCn6eMbOuAgAHcS1IJRH8A/Nt16RqMsdb3uG1P0Yekx641KPjTEzLBEVpCVX/EOfZVahZLCEf9HxzEhbMA/IrPHbFj7ttg9Z3Oqp065Z8ID06CUySWcCWGIBJ0lOYyqYnYq2ipcW53RgjGfcMRgc/N/ifeGT+VlKQYG47DCuMjidB3LckjIkhfsYb2djkhdd7N2eauwqsW7+3g3e1h/jFiBnSlvQ71RYMzsebrpvR8yl9RmmGTqNhF8q8lgNo3tx7zAb3jitHIySBy0ph//KZGGBasKkPrXCq7q868qU8STsHhf6sos+Db11JPZbewkyULcHtlZvEuHHqVijLLgshRnZqtSX6K7MxIPbXnAAtT/p1y8xDbGkCxwU1o7wSKoy/05nEVbw5HHev4PX4lSJnYWDoe9YeRxGgpJMHn33g49WSPmHlyImo4ArtsQhTamjA/8UcEhKJ70zyFR0CtznuC75OjRMda+ntzclooePhu3sI1aY6AAWNNJVQyZXKxrm0acKRe6DvXgcIlfc1tVOMjAuzTbnWxLM7lN0hr8UtgoPJsfwIjMNzDB4q5jtlixeJIFl2XquPDu2YaTXHexh4NFSCPxfhOMYULtLRgfzpqE4ZZJa0sW78cJ2fqgmT4C5zpJi94ZIqbPaYtuyksM7d1PJs9Sh2pj8GBbxhWbmAz3V6qDaSr0dcwL40WI0zqdawmlAo8i43OT/5EGIw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(86362001)(2616005)(31696002)(36756003)(40480700001)(82310400005)(31686004)(40460700003)(54906003)(110136005)(356005)(16576012)(81166007)(316002)(53546011)(82740400003)(478600001)(8676002)(70206006)(26005)(4326008)(8936002)(70586007)(41300700001)(36860700001)(5660300002)(186003)(2906002)(336012)(426003)(47076005)(83380400001)(44832011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 10:37:29.4200 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bdea660f-6276-4bb0-c400-08da97cf7485 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT108.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5204 On 16/09/2022 12:03, Julien Grall wrote: > > > On 16/09/2022 09:32, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 16/09/2022 10:08, Julien Grall wrote: >>> >>> >>> Hi, >>> >>> On 16/09/2022 08:19, Michal Orzel wrote: >>>> Using dprintk results in printing additionally file name and line >>>> number. This is something we do not want when printing regular >>>> information unconditionally as it looks like as if there was some issue. >>> I am OK if you want to switch to a printk() but I disagree with this >>> argument. dprintk() is not about error, it is about anything that >>> doesn't matter in release build. >> >> In the vast majority of cases, dprintk is used conditionally. That is why >> in the debug build you cannot spot a single line of log starting with >> a file name + line number. >> That is why I assume this behaviorto be abnormal >> compared to all the other logs. >> >> If someone adds a printk starting with e.g. "$$$" this is also not a bad >> usage of printk but would result in an inconsistent behavior. > Every lines are different, so it is not clear what you mean by > inconsistent here. For instance, we have quite a few lines starting with > the subsystem (your $$$) but not all of them. Would that be inconsistent > to you? No, it would not. The consistency I refer to is that during the "normal" build (by normal I mean without any warning/error conditions), we cannot spot a single line in the logfile that starts with a file name and line number. Something like this immediately catches at least my attention as such format is really meant for either errors or debug prints (the reason why most of the dprintks are used conditionally is because we do not have an alternative as I mentioned before). There is no reason why someone would want to see the file/line of such informative message. Printing filename and line number is not the same as printing subsystem name. There must be a good reason for choosing the former. It shall either be used during the error condition or with loglvl debug. Certainly not with XENLOG_INFO. Anyway, if I'm the only one who does not get used to seeing such messages prepended with file/line, then let's not spend too much time discussing what is the consistency because it is clearly a matter of taste :) > >> >>> >>> I don't think we should just switch to printk() because dprintk() add >>> the line/file. There are message we don't necessarily want to have in >>> release build. So dprintk(XENLOG_INFO, ...) would be right for them. >> >> I think this is a matter of being consistent. > > You can't really argue about consistency without explaining what is a > consistent line. > > As I wrote above, a message is mostly a free form. Some may use 'rc=%d' > other 'error %d'... > > Yes it would be good if all the errors are printed the same way. > However, this needs to be a tree-wide decision rather than localized and > something really not worth the argument. > >>> Personally, I find them useful as there no grep required and/or >>> confusion (but that's a matter of taste). If it were me, I would add the >>> line/file everywhere. But I understand this takes space in the binary >>> (hence why this is not present in release build). >>> >>> A better argument to switch to printk() is this information is useful to >>> the user even outside of the debug build. >>> >>>> >>>> Fix this by switching to printk because this information may also be >>>> helpful on the release builds (it would still require setting loglvl to >>>> "info" or lower level). >>> >>> I think we should drop XENLOG_INFO to be consistent with the other >>> printk() in domain_build.c (after all this is a domain information like >>> the other) or use XENLOG_INFO everywhere. >>> >>> My preference will be the former because otherwise most of the >>> information will not printed in release build by default. >>> >>>> >>>> Fixes: 5597f32f409c ("xen/arm: assign static shared memory to the default owner dom_io") >>> >>> Fixes should only be used for bugs. This is not one. >>> >>>> Signed-off-by: Michal Orzel >>>> --- >>>> Rationale for taking this patch for 4.17: >>>> Current code results in an abnormal behavior [1] and was introduced by >>> >>> It is not abnormal (see above). This is an expected behavior when you >>> use dprintk(). >> >> I did not mean abnormal behavior of dprintk but abnormal behavior of logging >> even on debug builds. As I said before, I could not spot any message like this >> booting Xen at all. This is why I took this as a reference for "normal" behavior. > > To me "abnormal" is quite a strong word and in this situation really a > matter of taste. > > Anyway, there are way to write the commit message in a more objective > way. Some like: > > xen/arm: domain_build: Always print the static memory region > > At the moment, the static memory region are only printed during debug > build. The information could be helpful for the end user (which may not > be the same as the person building the package). So switch to printk(). > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 16 10:39:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 10:39:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407929.650609 (Exim 4.92) (envelope-from ) id 1oZ8lB-0004wL-Pk; Fri, 16 Sep 2022 10:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407929.650609; Fri, 16 Sep 2022 10:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8lB-0004wE-N3; Fri, 16 Sep 2022 10:39:49 +0000 Received: by outflank-mailman (input) for mailman id 407929; Fri, 16 Sep 2022 10:39:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8lA-0004w2-7q; Fri, 16 Sep 2022 10:39:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8lA-0003up-6F; Fri, 16 Sep 2022 10:39:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ8l9-0002Dg-QT; Fri, 16 Sep 2022 10:39:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ8l9-0007il-Q1; Fri, 16 Sep 2022 10:39:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BAwt3yEkHq0kPqpC6QqmZU0ArYVllavFw4m6jyOWSrU=; b=hSGRxQc3cvHKLNRXtYYSZt15ap +ByJOnU3JsRXAm4ICyTXUn4r+LbCLh2YGQgsilK9xlFgSLW4GqVrdkbBXE5ZJs4xivNp8FYA6bM1Z gqqv9xH32muCalCG7vJaCT1NXJG9uWjTIbHLMxjpnQYdK9bKLW7SGl7j53ribMWXJJMw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173232: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=415fc406d6d8e9f8dee59d467108ee101670b545 X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 10:39:47 +0000 flight 173232 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173232/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 415fc406d6d8e9f8dee59d467108ee101670b545 baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 319 attempts Testing same since 173232 2022-09-16 08:13:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gang Chen Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2633 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 10:55:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 10:55:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407938.650621 (Exim 4.92) (envelope-from ) id 1oZ908-0007LL-5n; Fri, 16 Sep 2022 10:55:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407938.650621; Fri, 16 Sep 2022 10:55:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ908-0007LE-0z; Fri, 16 Sep 2022 10:55:16 +0000 Received: by outflank-mailman (input) for mailman id 407938; Fri, 16 Sep 2022 10:55:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ906-0007L8-Fy for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 10:55:14 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08dd8902-35ae-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 12:55:12 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5D0515C0215; Fri, 16 Sep 2022 06:55:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 16 Sep 2022 06:55:10 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 06:55:09 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08dd8902-35ae-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663325710; x= 1663412110; bh=ti6HR9BQlCCPHMLYEhtJ9VQX+0iCfL0mbkktC0+nmnw=; b=5 jWB27rW34AF/c11BcCiSsHPVb3JOl9AN1zoIF29Wz7maPYksCG28K0Nq9OLegRb1 v4I5etJEORKJyCureCd4wnnzUm/7BNHtaQ1YS5I7j0q4a7vLWQ1i4ZJkTZflMMH6 Z2N9sz7jVXtbZro/viYPYFJYwxDo4pucs19m0c9htRGjXzpNLymjJxExp3pJuIZ2 2BliVuRklS4YrgcNmjSUhcBNnREPFp3vWdbcsRGXVfwPwcYJnYPXbGGr3EJdd0e6 VAkVgT2d+eZ3afvwaARU1RA8yxUGse+AediCIL/KTUWPhuTDQw3lIvTXXfg0p5sJ GIJ2TkKaA7Rc/iaCN5DPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663325710; x=1663412110; bh=ti6HR9BQlCCPHMLYEhtJ9VQX+0iC fL0mbkktC0+nmnw=; b=FLyUYNg+F+HcS6lBuk/gmnctRxrajnbkHj7deLLrHvlP +AuJMoZ88uypH461mAExx8v05HFUCWI6PzUD3ZN619XWm1V8tTgBRs8dASpVyYH7 0ebt1m5d6yW9P+kHUaPaIKFvGSMQokSPgC1JDMT5mX1IQdNW74l1UQ3h04H3XX4a FTdBPFTz102+4wc6HzwLu5CuqisBgWPGVTAuuiy5lYerx6ApJnjJ9wuG6H+l5AhW DTt2nThIYP0k4H6rg4hNKiKZ6TihfhNXLf9CM2rjXJmXLR5cUq+youaccrRQTFZs 0Day8U1hpzImXSWmp975Aig1/IphsFi/ZPVBIgAeNQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvtddgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 16 Sep 2022 12:55:06 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Tamas K Lengyel , Xen-devel Subject: Re: Default reboot method (was: Re: Console output stops on dbgp=xhci) Message-ID: References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> <92a8ad2a-9b9c-b147-c175-0a9b4dab4821@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ocGg3IqZvWtAoCeT" Content-Disposition: inline In-Reply-To: <92a8ad2a-9b9c-b147-c175-0a9b4dab4821@suse.com> --ocGg3IqZvWtAoCeT Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Sep 2022 12:55:06 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Tamas K Lengyel , Xen-devel Subject: Re: Default reboot method (was: Re: Console output stops on dbgp=xhci) On Fri, Sep 16, 2022 at 12:28:46PM +0200, Jan Beulich wrote: > On 16.09.2022 11:53, Marek Marczykowski-G=C3=B3recki wrote: > > On Fri, Sep 16, 2022 at 07:57:59AM +0200, Jan Beulich wrote: > >> ... this leads to the crash, which effectively tells us that this is > >> likely yet another system where one needs to override the reboot > >> method (e.g. reboot=3Dacpi). > >=20 > > At least Linux, but also XenServer uses reboot=3Dacpi by default (even = on > > EFI systems), can we make it default in upstream Xen? Issues with > > reboot=3Defi are rather common, while reboot=3Dacpi just works. >=20 > But rebooting by means other than the EFI runtime service has always been > against the spirit of EFI. I'm afraid firmware developers (apparently) haven't heard of it. Can we have "works by default" behaviour? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --ocGg3IqZvWtAoCeT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMkVgkACgkQ24/THMrX 1yz+4wf+PPxcXqHuuIkWDIX6ECN9Lxqi+chlYwcWZjF25JXCo6Sn4waVMjiQIsvH GIAmmCcszLl5DYG8S1N/KYDs6sPLp54AQjE8S64ig9NvOG+RtHKHGaZWLNzfAN9F QEJZ06L7wet6RjS1TMbKwqt0EkZvMSD6kUZCf7E/q2CZ3SK9YrWSQQG/rQwlSvyf GNJt3JF2D78XBHCFawKNY2AOD3dbt02wYTcvFmdgzWUOgDg1LcfuEvUvAkhXGKsV jjIRFZPp3OQJgVGgkAk34eYU7x4h9E0qYXnccwZFpG80V2GNN6jGwJJSI8TvNNJt Kn+4iHzhywkV6U+yJDGCsOrOtU5FUA== =u189 -----END PGP SIGNATURE----- --ocGg3IqZvWtAoCeT-- From xen-devel-bounces@lists.xenproject.org Fri Sep 16 11:05:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 11:05:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407945.650631 (Exim 4.92) (envelope-from ) id 1oZ9AH-0000RZ-2K; Fri, 16 Sep 2022 11:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407945.650631; Fri, 16 Sep 2022 11:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9AG-0000RS-VU; Fri, 16 Sep 2022 11:05:44 +0000 Received: by outflank-mailman (input) for mailman id 407945; Fri, 16 Sep 2022 11:05:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9AF-0000RI-4i; Fri, 16 Sep 2022 11:05:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9AF-0004OL-0e; Fri, 16 Sep 2022 11:05:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9AE-0004Xa-A0; Fri, 16 Sep 2022 11:05:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZ9AE-0004B5-9V; Fri, 16 Sep 2022 11:05:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WFh2u/o4MLnKlZagQMWdQOzCaGXmKx6uGEmgBHqP5T8=; b=F2fKE5DOwAVcAplm8jIbQIshxR xwQBPzClpGh69MDlYeRXnpy/BFNjajb3ru4TYOZ+Y2A+g+/NdA/tGzP3vEt9CNboXBdov0EC9xs3k l5vxbG2P+IdWXP4PgyDfRbdVKlVSbYKk6E1hUw6WOJd+umoSR3CyGCwK2E3pXOn35gy4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173225: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 16 Sep 2022 11:05:42 +0000 flight 173225 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173225/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 43 days Failing since 172384 2022-08-11 11:13:58 Z 35 days 77 attempts Testing same since 173213 2022-09-15 15:14:56 Z 0 days 2 attempts ------------------------------------------------------------ 544 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17161 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 11:11:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 11:11:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407954.650642 (Exim 4.92) (envelope-from ) id 1oZ9Fd-0001xo-TV; Fri, 16 Sep 2022 11:11:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407954.650642; Fri, 16 Sep 2022 11:11:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9Fd-0001xh-QG; Fri, 16 Sep 2022 11:11:17 +0000 Received: by outflank-mailman (input) for mailman id 407954; Fri, 16 Sep 2022 11:11:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9Fb-0001xb-V3 for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 11:11:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44123fe6-35b0-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 13:11:11 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 07:11:02 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MW4PR03MB6331.namprd03.prod.outlook.com (2603:10b6:303:11e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Fri, 16 Sep 2022 11:11:00 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%4]) with mapi id 15.20.5632.017; Fri, 16 Sep 2022 11:11:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44123fe6-35b0-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663326670; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=OU37DuF8CE5gZYsrPaBua4T6Ke11Qs1Gjn8sBbCjCU0=; b=ZVcqYz0XXYWYyvg5UBy/GlXB6xZrComAZbSMUJGgzugFcYg2ZhTabwVN bdki/Rs3JSIc1HYr4a2zlTxFSiQQaauo+ptzhqqRg0dlQ6a+z5R0PtSaY OxECmvvx265EKKEbA4qLX/+/RcorlFfvnrGOp1YNuRSx6UOJwIBLBJl9t A=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 83195730 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7NL5rKyR/TMdPndYqCF6t+fzxyrEfRIJ4+MujC+fZmUNrF6WrkUFm zYfWmrSPvmLZmf0L49zaIXi8h5Tv5PRz9VjT1dr/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Uox5K2aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1OVHs1YJY94tx2DGRIr dAzKBI0UhGc0rfeLLKTEoGAh+wFBeyyZcY1nCElyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCSvNWQG+Tp5poJui4TX5BZ237X3dsLcZ/SBRNlPn1ber WXDl4j8KkFBbY3ClmHdmp6qruzugwzcabsZLpmHqM5lg32P3kVMLBJDADNXptH80CZSQel3L kUO/yM0oKsa9Uq1T8L8VRm1vH6FuBEHX9NaVeY97WmlyKDZ/gKYDWgsVSNaZZots8pebSAj0 1aSt8/qATFpv6yYTTSW8bL8hSO/P20ZIHEPYQcATBAZ+J/zrYcrlBXNQ91/VqmvgbXI9SrYx jmLqG00geUVhMtSjqGjpwmZ0nSru4TDSRMz6kPPRGW54whlZYmjIYu19Vzc6vUGJ4GcJrWcg EU5dwGlxLhmJfmweOalGY3hwJnBCy65DQDh IronPort-HdrOrdr: A9a23:PHUJZqvnv27CBKJr5GtDa+fd7skC7YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w 3+CNUZqFh/dL5pUUtDPpZxfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou WLbG9l X-IronPort-AV: E=Sophos;i="5.93,320,1654574400"; d="scan'208";a="83195730" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HA23yyHpL3AyHo89WEhFyzxBxS+KgL9EjJ6v/Gv4QyYkrmjNLsd+jbl58SA6zt5WFFDVi/79ZgPRqf1tjRlGN8yW9QbEFQOZu2DGFLQacYfx6cfDmGthg2QUZaiF0Rg417sfQdG7HpqgbSkL+lgBDNFYuCV5UU2n2VcMUlEHsfGiuko4WF2rUohC5+Fj6aeRm5lPlCdjaFQ/pPFuhm5Ypv0KRHkJ5/f2yvcgcOih/C8f11X0w+USDYmBHAbfs1OonGjI5PlZrNdwHqjR5yKRNVZB/F/1D32P6jn+hdJJ7Wpjrjno+2s+CQSmz9jTZFFXTnWL/rxZSG2Aq1dBuUH6WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qty7lOo/og7DxEbfingkjqjBkl9lH2CWGtqkUTY5N+c=; b=bvqitQs+c3Lzt+KF34GkOg3MZSgKq1hQxXPK9W6BskbNjGrYv5+utkCqbQbT/APRc+hLbBShXgJDX3zUv9Z1zaruhdJFAm4cQ3FBMyMvek6PLrSVEDslOOyz+Ucyoq5MxuJFK8MxA29W8lBiwGDK3z00XsosBieUHXzGwWByBidG6cLnsglWNplmQcRd9Z8g6hRl9dOSBc8UvfERwQQxatfS8TsAxKHurXTVKfomE9g6mWU3MfzMlGufDC4gyYapjXaVEPp+Jds9NpFodruiKUdWRVf3TWP+7ZFc0f6VgCxTg2S5VqtKEoiSGbR9XD+xDN5d1k1T5VP39yNozfsO+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qty7lOo/og7DxEbfingkjqjBkl9lH2CWGtqkUTY5N+c=; b=xCVRqVKMNW55AYKqZd7hvUsl+FIM2oVL7P5elfeCxeHyLtpRsh98TBR3y8IuMr31gouRtdp0KJWxdEOl08q67JGotp3It7uS/SU77SZf3wrqBjPU2Sj6h6XnsitOm2dWFNFEbePtqQ5YfhAyNwBhCQjGA3SmuQEQubMQ46ZmgkM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 16 Sep 2022 13:10:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Jan Beulich , Tamas K Lengyel , Xen-devel Subject: Re: Default reboot method (was: Re: Console output stops on dbgp=xhci) Message-ID: References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> <92a8ad2a-9b9c-b147-c175-0a9b4dab4821@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|MW4PR03MB6331:EE_ X-MS-Office365-Filtering-Correlation-Id: d0eb739a-546f-4665-dab5-08da97d422c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xgwUYXGwhcU3AdxENPxR6IVRY/yLWBNLuqLmXk/Ncg2MoVTwv1gnuDm23hNVC3zZN/c3UfKN6Erzc13s8TXld4YkfGTX7Wej7a8wiL19C/FQPgursxXr0S6K0TE1SGFBjBc3l6Jflo8zwiUaUr2ihS2/7q+dgTQDjEeZykrNTFsBGkOArYE6JYTVNBoeV/t48JXBADJwD8ZmaMkRN4gB09BymdijUwYOdXWNXB9VBrdBeDgDMKM0cNn7UsyQtk6f5KtI61n0hj1F+TcgdEjj1Dfwzy4fq594HigrTDNrv7rG98gllR0tkAAk/0KaS1LJKUvvhUFSEkzVQ81QyBsZm0+ohF/vfjSu1UmD1Lck2xHL4DrFOc0eDjrweBCIksllg1XSqTr+c0t8868DWEPCiTFq6nLNcrhmN4Rk3l4+6PF1PUKzCpp/T5Rx8NVKpaR+s4ZpOIP8D/65Mm1a7AAeofENmYC03v3FhNTQEYHaQ4S/0cM/ailz6p+skAkhWUY61xwIb4brHokuruo8Y7S79gNHYRlM46SqQpMl67+p3QcHyy9i6rpNtjeeZIdQ7g1e7gAUoWE05lhvhkvrnk2aOSzR+Vb+LqAKibVVsXxY6aM0fLssv7NNhpDUF6GfwYoqiArrbVBi1vB9/s02HOvqMIysFSwq83kvm3mbYgDgLQGf803xIZMvGGuQJ8TYKPS5vaJxsFFpb2wLgoANssF3zQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(366004)(136003)(39860400002)(451199015)(38100700002)(6486002)(66556008)(316002)(54906003)(4326008)(85182001)(6916009)(41300700001)(82960400001)(2906002)(5660300002)(66476007)(53546011)(6666004)(26005)(8936002)(478600001)(8676002)(6506007)(86362001)(9686003)(4744005)(66946007)(186003)(66574015)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2tteUhDWVNDNnJxMWMwZjhPNVlraTQvejE4TXhCYVRLUWpBOSsyR3VZUVE1?= =?utf-8?B?YlA2elZKU0pqbGhHZ25iTG9lb2VFMU5oaXBQT0VrcnY5bnYxS0VkTFdxSWtu?= =?utf-8?B?Rm96Y3B5UHVDWDdlYUZDdXRGZGR0cUFNZHBPdWhLdlIxbFcwaXROVmEzc0Uv?= =?utf-8?B?WHdkMkdrc0N1ZWxvWlVOMUNBcUVxVzZhQVVvcWY1QUtlc296RVJiWHdDK2c4?= =?utf-8?B?d1kwR0FYL2FKbWQ4bm85WHVlUEhUcmF1bzR2NDlocjBwaFBNenY3bFBkS1lL?= =?utf-8?B?dytSeCtHLzlvekxDc21kLytlZHlaNW04emtscC9Qc2Y1WXdFbjVlTGpqQlNh?= =?utf-8?B?VEhsNjI3Y3VsOWtCV3EwZkl2MktENlhaREhWcjFaallqOHVLWGVoRFE0VlpH?= =?utf-8?B?R1dYM1NxcU9FaTNHOWkrNGJLR2dCd3NidldZRHJMRi83dS8vUTlZUmJMODZG?= =?utf-8?B?RkQ2ekFhUWVUQW5GN1oxVTF6U1poOVpTVkMrSkRmd0JreS9ibUtXTnV6ekNV?= =?utf-8?B?WlptejFuTDdqK1FLRkFPaDZWN0dkenJTZEZabzhZSk43bklVMkRZY2RISmY4?= =?utf-8?B?SXNCM3kvTVVrTGdIMEthK1NiblRyTVBINzV3dVRGZHgvUkZ4dWZDVTVEK1Nu?= =?utf-8?B?emN2cTk5VEtCRzc0VzBKc080OWhJbUNPbVZpRHY4YURpL0xJcmExWmhVMmZU?= =?utf-8?B?Q0dGK1k3NkpqOGVpaE9ZUDNRbCtqTDAxZXNRbnVXQktPVEcram1mSXE2V0g2?= =?utf-8?B?ZjYvZUs1SFlKWC9mOXEyZEpqUzVOaTJzdzBJMW9jbllXQVNUQVdadG5uTWl0?= =?utf-8?B?eFZYREVZVmpmYU1MN2lDQVVWdERYRFFXYkRzeXNBREN1cGlnWWorQ3N4R041?= =?utf-8?B?SHBQSjFBY1pzVjBacGNQTk9OQW1XOVF4RU9UUXNkZG53V2tKdjg2ZE1obWEy?= =?utf-8?B?WWVKbnh2cmt1SUx2ZE9LT3JzUkNWR0pUWXJ1UHBHbDk1R0UrSGVNQWhZNjJq?= =?utf-8?B?M0xnL2RwaWtKcUJvLzNUZU5RNDh2K0kyaHRuS0dmSmpTSGlpNG14WWRsMld4?= =?utf-8?B?U000WGkvYTFSaUwxTE5rSnVIandIblNkRWkxNVlnM3VRNFgxS0szVmRRdWZn?= =?utf-8?B?Tm9TVThUV0dRdFlwcE82aktiWTJoVk1ibEY2dytZQU5RdjdzWHNQbk1qTGcv?= =?utf-8?B?YnMyQnVvbnNQb2txM0RmVWVibTRpd3RRZjFwY1BJQ1lBck9jWGVGN05KOUtI?= =?utf-8?B?ZDRDd2NKUG5ZNWdWY1Q3OTI3MXE2VUZmVjdIS0piWHRrOEFPU2I1ZXhSN2ZI?= =?utf-8?B?Z2Fmb3Avd2dzcGhjM2lqK0xBd2FSRlhZS0sySlVTdEJIa1Biazk5MDJoNU5S?= =?utf-8?B?azR6ZHJ5WmhEM00zV1doRDVKY2liNUVBVWRGRjdqRUdWVDBQeE0rcWFtWVBB?= =?utf-8?B?ekRkclNvVE9YWHpBODNucEpKc1NsUmIrZVU4ZGZpQjYvY2hqZWM2NTQxbzI0?= =?utf-8?B?eDJPZURXLzg5TTg2UTNlYytBbVRBc1pDQm9EY3I5S1hNZXBHSUNBRzNwaTBE?= =?utf-8?B?VmlVMndHQzNvSDVnZUp2WmlHNkdCb1VqdjRKQUdGTDJJT0FMT3VRVFVGVGhm?= =?utf-8?B?ZzFWZDFMaFVKOWMrUThDamxnV2hpV0xqclNWN1phMDVGWUF6Q0FlM1ZEZDhB?= =?utf-8?B?UVJjQnFQUHJuYzV2QnN1VUtNUks1d2o0VzljM3NlODQ2ZFpQTVNxMTZMa1d5?= =?utf-8?B?SXRkT1BwS21IdTl1R3AxNEhjeng3aXFZQ2QzRFNvbjZmdkFhM041MHBNNFRZ?= =?utf-8?B?clVXbjdpb3VyNU9wWXJhYW9HV0I4TXN3TVhvdlVNUHNNMVFlSys3eEowRnV3?= =?utf-8?B?Um8weHlvWituQVNFbzI1YS82cVRPVzNoZlpYT1ovTkJyeERQR0RockhEOXli?= =?utf-8?B?Slg0YlBPZm1TeHFwa1E5d2xxM2Urc0xCTTZ3L1NsallqYTN4bHJOU2M5MjJR?= =?utf-8?B?cVU4VCtHU3IzeGpXS0RCRjdsS0RYMWxvbWRLcGdPSGlqdmhXUFRMQWtrNis1?= =?utf-8?B?K1BNQ3B0Z1VqaCtmSGZ5SDJhQzM2aDNKZEdHVXBOZG83VzVldXJ2cXBuTGUv?= =?utf-8?B?SmpqR2t5bytjSGtuVC9ZR3JOZGh1MmcwR2l5b1VVZWhPNmRndXlodzdBNTRj?= =?utf-8?B?M2c9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0eb739a-546f-4665-dab5-08da97d422c7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 11:11:00.1386 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZAly+sYEgLkcIXHst7bHywd3JgLTFSym9ZuWLBkV4nc70K415rtB0pVETxn98ppvPyvWdiKYwg1FrfAbWhovQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6331 On Fri, Sep 16, 2022 at 12:55:06PM +0200, Marek Marczykowski-Górecki wrote: > On Fri, Sep 16, 2022 at 12:28:46PM +0200, Jan Beulich wrote: > > On 16.09.2022 11:53, Marek Marczykowski-Górecki wrote: > > > On Fri, Sep 16, 2022 at 07:57:59AM +0200, Jan Beulich wrote: > > >> ... this leads to the crash, which effectively tells us that this is > > >> likely yet another system where one needs to override the reboot > > >> method (e.g. reboot=acpi). > > > > > > At least Linux, but also XenServer uses reboot=acpi by default (even on > > > EFI systems), can we make it default in upstream Xen? Issues with > > > reboot=efi are rather common, while reboot=acpi just works. > > > > But rebooting by means other than the EFI runtime service has always been > > against the spirit of EFI. > > I'm afraid firmware developers (apparently) haven't heard of it. Can we > have "works by default" behaviour? We could make it a Kconfig option and set the default to acpi IMO. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 11:44:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 11:44:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407960.650653 (Exim 4.92) (envelope-from ) id 1oZ9ly-0005LR-E2; Fri, 16 Sep 2022 11:44:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407960.650653; Fri, 16 Sep 2022 11:44:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9ly-0005LK-B1; Fri, 16 Sep 2022 11:44:42 +0000 Received: by outflank-mailman (input) for mailman id 407960; Fri, 16 Sep 2022 11:44:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ9lw-0005LE-Uz for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 11:44:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2085.outbound.protection.outlook.com [40.107.22.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2212c97-35b4-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 13:44:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7888.eurprd04.prod.outlook.com (2603:10a6:102:b9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 11:44:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 11:44:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2212c97-35b4-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bR1OywNfVElKmKGYNCpb71FUyYi4y61ZcVhGgwYVugjofHdxh3ezu9QgHxllMIFex8EJ2gPUqgwcQM/1VFre6PnD2WCKgTrF0kr239XYvEPnCbi9LaeA65eWtEwlB6+vzAb3YJ1pHsimeapG2knUSA9lUxyIJ4uwh+q/F99hyyWHKTk9ixDRlraHfhS1xlOAiX0q4aIDeopCqHURz1QDpow/GJci1T4+RLhWA+3KA2ng7utaW01qeKxW5kWrYyMsmA8BNXkIIeH5RAX4mH9/lq2Ree+9H469NkMrQctjWkLziS2I5+gGgSSFcb12K7BEV0I3UcCYYnsOCBpzLOWCzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XllIYTTkFTYHUz4Udy1CQcJh8H9tgf+9m87/2Ua4Slc=; b=I0FH5RfYpI+b58UCnHsEPQQFgrnsv6RsLkhZRuSSXCrmUfOaPfIeGeS/Da6+ApS543+5Pic8rs8AbgHa4l2Kr2TjbI5WPgCol/+kvSxmD3r7N0QfG/ns+vjiw6JYHV1oXaCsI6kWlVUjBxvWKaLftkgd8IKlrXktH06Joky74Vf9ihTq8X6QNvNcKvXGNjk69GDHnwpqO+LcjlV78vTDObABz+RVN/aVIMFDVsoydnp8+gi5fjrdulQu1SQY/sDVv4eoehaJhaGy/OBFzpXwkTT/uBBlFAcPoRfRPXlIQdZjypWXU4bnGjDMUj5NzPsR7NBY5HVw9L8r13BVoqX1JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XllIYTTkFTYHUz4Udy1CQcJh8H9tgf+9m87/2Ua4Slc=; b=v9DOm2aSTsm477wE7POansGi1KPwtiOWq2pOTi7UzcR7CS2xGAiurHCHt0wI6daw9wdf5kd6GJipGLEznzN/EHdGQqEXn954XdEnAKhocgT6EvYdDeRQJyONnnFOJKREnuk22Dx1/UKWdZli1r/1+vM616AQBKj/w96rzO/wT6INGO+pofEJ2Lbs6XnS99e3/7M4F+EU0//OZbEq1D4YvUjADkl8m49fvUnxadcphY2xkKjhGcia9E8h7hNg8vWpF2RkDi9MNNSBFKntpcs/h3PUfHSg9zkjfnsZpU4z+8PBQtzr9mviJtPZg5Y0NelB4/2V5vxoRm+fRosb8q41JA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <951dd3b7-9489-a662-2252-baf6a5ceddfc@suse.com> Date: Fri, 16 Sep 2022 13:44:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Default reboot method (was: Re: Console output stops on dbgp=xhci) Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Tamas K Lengyel , Xen-devel References: <32e97d9a-a5b6-05bb-5cb2-bf9a1461c851@suse.com> <7adee56c-607e-7d3f-8aa6-1ee5b2fdd133@suse.com> <6bd99d37-f9e6-647a-6e2d-d774fcd597a3@suse.com> <2697981f-8ae2-d3e7-1a6a-046927a66246@suse.com> <92a8ad2a-9b9c-b147-c175-0a9b4dab4821@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR04CA0077.eurprd04.prod.outlook.com (2603:10a6:20b:313::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7888:EE_ X-MS-Office365-Filtering-Correlation-Id: a151d5e8-88bc-4b0a-8c93-08da97d8d54f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tnU4PArXhBMfp0HvDO1M0nipr7aeSSQh1JH1CMwn7ecyjh6iKmbqFe9RMObNTWCSHNQDQ31EjpZbouVq/3AvfWwuNw8XKX9oyv4sCtO/tkU9bXsxKz8oaQW9F+4QIAAT298c4ObMLKnIhkDF6phDN6fl1rlbhegsZpWF03dgCQlvPU9iEsJSQ0T+ozSL/nxxP3wIMKDYlbyyGAvyePoKHN1rGvf9Ou3xWtXSNTnMhuwWRmdPR/ZJfJqUKdAB9JMrFrgTYIH9tPDpHCuwBxUku0Fs7czLVdJkksfQKiqPG9o1uQcrQpuqNNSsXAUiV6n+e7HjvSiRmajS2PZnkEj/IBFbOEVux3BRN+JlnWoL3HTvIzh7VM26Ixzz9hLkr/S4XvHzk4RDhLhk7hRUn7zVqx6eNa6c6Swhu2+c9ibROYgfXHFHDSnqkDjoFVvjYaiDWqH1WRjeEoVjjyOesadzZpDrg7ZOiLR/9C6w2NoefFxhzD0mFmVgxS3Hf8TqaiNXLJqpxVbpZwh2RAYBryUktfnKwfv3404Xuuc15aegrUyNjLt09Oj8S59Xc3tmlNsdqhc0OsYr+F24vPVsWRVAG8TtcnD0fL0P/m/nOQ81Fa/M0LBs6zYN1FjEifG5+NLOr5BlpEg5Usc//e5saSbNFNeC+40dyrYn4SkYeA8v47pjoX0RJkyy6ZA1rfO+VDCiDwPNO0LusCszOHQ6i2Y16gr86zhlYUL+s2L6EtYTwix+UDlPtLzEIWEsX98iTCoQ+U/52xI7kIEBiDOyBEheGTk+ELHbpQWWSSIw7NwtK74= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(376002)(39860400002)(346002)(451199015)(66574015)(2616005)(6486002)(186003)(6916009)(54906003)(26005)(6512007)(316002)(53546011)(6506007)(41300700001)(38100700002)(478600001)(31696002)(86362001)(31686004)(8936002)(2906002)(5660300002)(4326008)(8676002)(36756003)(66946007)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXJtc2dOOEl4TnNDZEdWek9FQXU3SldBc0hDdXhmTFZoeVB0NG1INCs0Qm5Q?= =?utf-8?B?d0NZOXFLMTRib3E0ZHpwcTdhMkpubkVqOEVQaWZyR0hDcXJSQVVyOG41WFl2?= =?utf-8?B?Snozd0N4N2d5cGUwdTUvRThIOU1wTlE5ZEFQZC9xVk5ST0NsUjc1NDRCZUw0?= =?utf-8?B?REVUOTJYSHl2aWNBTW1sdE5lbzVvQ1pQa0p1VHNycXZic0FNYmZxcmMrQ0Yv?= =?utf-8?B?cFgvNDNTYWp1N0QvakRnZnJ1bStGMWJ1RTBoNUpFN0FSbVhXYSs5SHR1MWpj?= =?utf-8?B?MG1qWWpsblg5dG1CNjdKbUhzMUNOVWdEYlZGajY0RkVac0tJSUl2WDdlZUpH?= =?utf-8?B?akhHR3B2Q0FpeDZ3ZkNPSjBudzhqVm1JKy95cDJhWVFkUWY1ZVRUKzBsbk83?= =?utf-8?B?dGEvSmlidzkyVnFQaDVxeXY0MDBtRVErZUdTWlk2U3FXb3hWTnN1VE9DbEln?= =?utf-8?B?ODNBbSs3b2ZWZ0ZPdTVyTy9Vc3gxQ1p1RTFTWlhnOXlDdnkrdHIxTVFQTmpZ?= =?utf-8?B?KzRnTVh3Z1A2M2VvZE9rRmErY25sckNCd0dIcFJzWVhUcGM4UXJCa0xtYnZl?= =?utf-8?B?ZmVxQ0NqalNkT2E5VlpXSVQwYXJBNFZzY3NRT0hqeGhFcVpkZTJMekNIckJJ?= =?utf-8?B?QlE4bmhWMm00THAvY0QrVUJTWGJsQ1dWOUhreEI1WjZ5N3dTNDhzQnJ1Y1JB?= =?utf-8?B?TmY3c3hJdXozZUVST0JWQm0xTnVNR0wyMFBiVE42QkhYaXp0dkdCOC9oejM3?= =?utf-8?B?RGtsUlp4b1I3SnNJSlUzNFl4VnQyU3FROU8zTzUzbC9ZVnR2UXk3VERmWmRO?= =?utf-8?B?ZDBGMWJkSkhNY2phdURBV1NjN0ZmWDJpR3d6RUxYN0ZteGFVUEVGUytTbEFK?= =?utf-8?B?dkZsTm51S08vMWlrWmNuR2xneVBDY0E3cUFNL3AwYTJycUJXMy9HaEtZYitF?= =?utf-8?B?QXJXYnppWkEvczR1a2Z3NW5RcGt1NENOaFhwdHRldjhma2VxdjZLWWp2VEtN?= =?utf-8?B?aGN3SFFzQlNQSWsvTGxBWi8xYVR2amFqeWJqRVNxTi83RWJqRWhMR2dBeUY5?= =?utf-8?B?VDk5amJ1eGtXVDRObERDUzYxaUp2ZGhWZ0xlVVhFVDRYUkQycU5saktiTzIy?= =?utf-8?B?VXlTRlVoWWRwRGxiQkNJcUUrak9GS1ViSi9UaHU5VWZEK2pDcDVkem1zaWpM?= =?utf-8?B?Rm9vRTQrWERLZFdVeGVJOWhtei9YajJGb2xWalRZUjMvSGRuL3FCOWpQbHV3?= =?utf-8?B?TnFlZ1krUzBwQTVFQWFTcFBZR0xpWHdLamkvYWppSGt2dE8xdUFyZkFlSll4?= =?utf-8?B?bnBSeCt2SW1sQmIwRXlnUWlYUm9uKys0U3lhRGVVVE9uUEhSSGNXYVc0SG9J?= =?utf-8?B?eURMQlRWY0VpM0dubWlhTzEvbGFueWxZM3FJVnp4NktzRis5aUZBY3V5d211?= =?utf-8?B?TFNvM0FFL2plUXJDT2pHb3lrZGZ6WkNlWFJoN1dqQ1Q1UXVzeVJ1cjNpVzVI?= =?utf-8?B?QjB4aGhUeDFLMkZTNWc4N0VJR3drWUdMc3VMSVlSV29JZnErUXFQYW9tMHV2?= =?utf-8?B?U1JNM3M5SVM2R2NSdmFtbkswRlBVVFVKbEJFbHo5b1pGVXQwMHk4UEkxRlRF?= =?utf-8?B?d0RRYWM0YkU5c3lBWmFzRmV6NHJkaEVjT0dKdzZWL016d2VsQTBmb2NNREdQ?= =?utf-8?B?WXVwYzVMVWdza1FaQ3dmTlBrVW9JY2tuMWJDSU05aCtjUk8rbjFMUHVXdWJC?= =?utf-8?B?SE5LelFvMjNQUVpQaVVMT0Y0WVhXa0hkeVFUb3dnQS9rbGViaVp2UE9GUEor?= =?utf-8?B?SmREa2kvU29SWHJVN2swcGdjaTkwMlZldmptRjV0a0grQWJYYWhDYldnUVFU?= =?utf-8?B?cVVqeXU3djFyNzdjeXAxTjVKY2lhaUlYRnRkWmJwRzNDNzlVNVhSZnFtb1NT?= =?utf-8?B?MjdreGYyOW11L3dDUExOUm1nKzlMTU53T2ZoT1Z5Y1ZNYmlnSHZzVGZhMkpz?= =?utf-8?B?dStWTHphNDJnOXFaV1hUS2pSdFkrdkJHM3g1VkphRzR2VWdJaVo3Tmx2d215?= =?utf-8?B?dTF2RDFOZzVzL1BLR0x3eGJ4MnIxVEpHRHBjdk9ncWN4dmc0dUd4M09Iaksw?= =?utf-8?Q?VVRWOdmIvWOMBeVB2DscppZoj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a151d5e8-88bc-4b0a-8c93-08da97d8d54f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 11:44:37.4930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9rnl3NqTA03RPDmc2fJP7XNpbYTVlL+0a8UXVahZvVlo6YLeGPETnNFNjGkN6LyGAf+zH1MEK5wWK1/9n098Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7888 On 16.09.2022 12:55, Marek Marczykowski-Górecki wrote: > On Fri, Sep 16, 2022 at 12:28:46PM +0200, Jan Beulich wrote: >> On 16.09.2022 11:53, Marek Marczykowski-Górecki wrote: >>> On Fri, Sep 16, 2022 at 07:57:59AM +0200, Jan Beulich wrote: >>>> ... this leads to the crash, which effectively tells us that this is >>>> likely yet another system where one needs to override the reboot >>>> method (e.g. reboot=acpi). >>> >>> At least Linux, but also XenServer uses reboot=acpi by default (even on >>> EFI systems), can we make it default in upstream Xen? Issues with >>> reboot=efi are rather common, while reboot=acpi just works. >> >> But rebooting by means other than the EFI runtime service has always been >> against the spirit of EFI. > > I'm afraid firmware developers (apparently) haven't heard of it. Can we > have "works by default" behaviour? Just like with e.g. the RTC, assuming availability of ACPI reboot is wrong under EFI. A fully conforming implementation may not support the ACPI method, while supporting the EFI runtime service. It is such a (well written) implementation where I want Xen to work correctly by default. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 12:53:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 12:53:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407974.650664 (Exim 4.92) (envelope-from ) id 1oZAqA-0004Cy-Q3; Fri, 16 Sep 2022 12:53:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407974.650664; Fri, 16 Sep 2022 12:53:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZAqA-0004Cr-NN; Fri, 16 Sep 2022 12:53:06 +0000 Received: by outflank-mailman (input) for mailman id 407974; Fri, 16 Sep 2022 12:53:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZAq8-0004Cl-LH for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 12:53:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7edb0a7d-35be-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 14:53:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7042.eurprd04.prod.outlook.com (2603:10a6:208:1a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14; Fri, 16 Sep 2022 12:52:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 12:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7edb0a7d-35be-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=agOuRW/9IhIFQSevEYdRVuKVYvTj4wl1OwUgCSDxQKELbiHmoTQcOyO3QTpTnI0kKx3f6b4tCYl8X/RWaUmI8FwAVDktJetzJ0VPAacacf9fYnVCsVLfH+yIbR6p+tbKO3GxBRr8L+CZM4WMieEHdSiU4fqXEAzGiOSajt+/sc8N9SSGNgi6mEnarasoZilOcSGv1FGKjR7HdqFNyhdpGPvhT9QGI9hjrQ0boRJF7Nl3thwzxaA01o8+jz/pbP8oAg1vKwjDc65f5S5/8ie7J9fa5nnkYveWPGk5FbDbZXB8SxzsEcL9vWHNI0O+bg+RaGK8U5FE1imM+cnij86nbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kPA0VsTyaym7mRLLFMQiZ3Dvj3gi9SUOgJRwrtmv2jY=; b=ZOTFGqkwHwnduhyx0DFL5I6RyQMxSpwzMvF16MNgkoRgXt4KASono+v7kcUWYihEUc2JVBBNqwtNQTBF/mtkP++5VoAbeV5M8f0tYmZAvR+25VIkADFc4kJ+S/Sf8HpJuP+9HTkzDIYLgmUx3+6xd/DYX9+wMwfggC57HlyLs97utSQdUUcxsb7brWuCwMBqMEC/UBEdA8VkqMpDCCBa6FQvQTJ5BKRzJjsoF1lPRZtfPYrk4W59YUXTwsXGzY7mD5VaF2TtIHWKiBXRugF5R0lCmtu0e41NUbGTe2ErTqV7siwEatj4zKg+E/AZzIueUBwv+6SU+dD2G9YTJ3V4gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kPA0VsTyaym7mRLLFMQiZ3Dvj3gi9SUOgJRwrtmv2jY=; b=JvBG0QoAPa2SQCx/ETFWdvcWneGS7pwOCPM0OQntYewhzmVaN9wVSUFW6sxnrdtQ7unDAONy93BfpTeK0Cs6eo0S+6B7yGebVtMLYBk0N8bnPotRqTmaG3n+LMsZ5QVB0iQhix524b3Waap5LLtNc7kehrYg7VuxpNpaMyXUs4RyqVeeN1AYiJ36UmJCxgT5yqp4M6YhfpdT0Ek8b/B5GMOBaP2VbhuVxnNOe24pwYLJg8ON34iLaUpNrGRCOku9IfgU/j3I1Rn+AZeeonIwSUXXGxXnFOKop1natQIYsEwU7UBbiEMldpsbFm3WSMA83I5dsZswN3b59kpPqkT12Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> Date: Fri, 16 Sep 2022 14:52:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel , Boris Ostrovsky Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> From: Jan Beulich In-Reply-To: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0415.eurprd06.prod.outlook.com (2603:10a6:20b:461::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7042:EE_ X-MS-Office365-Filtering-Correlation-Id: a36387d7-9d5f-4885-5836-08da97e261a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1c6Qb4k+hKh5+T4G5+HPeARP/aWND8qZWmP0qPhLoWexKJ3vWw88LZQWOia2uBJvYExgIvACu0c/RADQe0YasYAd+qlfdToKK8OSohOw58UGl78ldALk0U4xj6QCjkqbDMchCyTCYf3LMky1EqN1TOxZFCDTkH7gspmchbw66WPQZAIn6FReYvBpt7P9Oj/HavBr9UkaBFAy/5BILKLFKW6einwE+uGC2pOFuJQODdAdfQjlHhjYYmT52LrgBYJ0Nx5FsqMIdiLf/vnYY0SGDX//xn2BSVRBnO7Qn7mc7pvX22KoRA8cNqNx1boMN8w9vzXOrgEMIMpNAbWcRYbcyCxtK4kEDOUY2bZ9E/mAukhgTgFS/ceFNjledzA4rzqSoPAUnIwgBhVnGT+ETpmTRlRSv5aoOgNU9+c6srwi1WFQBuizVaOPXvcsdOiwMLXQSs/DdVwL6l4wKbH364d++f0nydtM0nxXWAUXdYAY6T8DOW79om9p3Z7NIPKKeA3BVfyhvhMKMTMqZ1cbh8KPIt1OOlr/2DFleeVoJJfCliRVCBktiUX9oG9FIPiamUdLjb/smlP4Kc4kAzZgAZF2BgLhVNPbaCnE253YzCNRm4Mk7jccI1BX+weaVB+8oenhlyeBZ1X99HmDXdyLZB8Nju8mT8jxL4ZPN96sKO7lwXZfrpWJfsvDW8i7lGmaM+zgLfwEUiAEogC8B4bsHvgAc9GxcaRMM6XoGkuK7KOQUt0oXh6IhIIdc+J+12BMCvzziA6uRnYUB6H+mfiJFmDOcN4Im8isbHh++Q61PNYb2aw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(53546011)(6506007)(110136005)(54906003)(38100700002)(6666004)(41300700001)(478600001)(6486002)(2906002)(36756003)(86362001)(66946007)(31696002)(66476007)(4326008)(66556008)(316002)(8676002)(5660300002)(8936002)(31686004)(186003)(83380400001)(26005)(6512007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzdNOFYwc0pUMTFKdElSaTZhbWtGZzFDREpHR2Y5SlFSTmxZSWlPMFltV2RG?= =?utf-8?B?dzFwekxBVDlHWjRxOXRaNE1yMzEzOFRsbzlPSE1vUXJ5VHo3WGRVRi95U2dJ?= =?utf-8?B?ZmpiekxpWWRPS2p0WTc2RlpHcVZ0UGR5Qm01cUlSNHJzTGpXbEtvVnd3Q2NF?= =?utf-8?B?WWl4WEV3V213VStTbWxUV2pXM3UwY0d4Vzd0SDdTWGhFakVZVEJNYzA0Rk5I?= =?utf-8?B?VS9lRkxGZjdvM2NZNHVORmsxWGY2TFhzUzNVVHJSdzBqeUNVN0UyMHNIbjRj?= =?utf-8?B?bjBlcnJtaFU5VGdyQ0JmRjZEWUdmL0xLL2g2SFNWWFZrSGIwUFRiaUtXcitO?= =?utf-8?B?VUpmaGYwQlBWWXBTN1lINExyMTBxV2pXKzhrSWZ6UWFvMklBRG9HWE4yUWpi?= =?utf-8?B?Ry91UDkzWDZBb1FDKzBtYkF5bFVEa0RKcldyaGZoSnFPMVUxUUxLd3Qyc3hW?= =?utf-8?B?bmFyMlo5ZVRCeXJ6N2VZUzNZM3JYVGhweVRJMnNwQm5kZjZZNXNhMlJjaGRw?= =?utf-8?B?dmo3M3l3SXhGM3RxZ1FaVVh5TXZaWk45NmlvU0hLQjFnUm1Da2tQRXJLdmZr?= =?utf-8?B?cG1EYTNjVVc0STRNdk1ZM3ltU3RxaWFHcFFpSy9mYnV0K3lqQWZGc3pQY3lm?= =?utf-8?B?NldIVHZHN0Z4QzNvWnVwZjNDSWtRVlFGTnI4QVNoWGF2NXFoYU5xNzBkY2Vh?= =?utf-8?B?TUNMVHQvSHhSZkFLc1NnNVlNU0lpbXp2NnFGTE53cC9pU1RUSDlqV1lFVER5?= =?utf-8?B?cWNlaTFOTHhyK0Jzb0x1NmliVldaaVFFSXJSdUpjOEdwalNZdWRqMHpXTTk0?= =?utf-8?B?TmhyMk5YSHQ0SUpiVHQvbnhhK1N5UCtSOFVnNDJVWTVFbXRvUmtlU0kzTFdJ?= =?utf-8?B?RFBQQnlOaFZVbmx2bU12ZDVyZ0FvQldvbW94OVBzTGJlWWNFc3JjcW44Z1M5?= =?utf-8?B?bW9zS0RLS3FvTjFzczJqMGRETVJ5ZjZEaHZUTytlZkxxK0FLQ3ZUMlBsS1Ri?= =?utf-8?B?ZHo5bTJIZlpPbVJHaU9nRWlXaExEVWNWU2tUbXk3M3B2OWk4aDNWTFFVSnly?= =?utf-8?B?VlpRMW0vN250T0VvMHZTelVxWkhyTDQycVVQdFhYdXIxcHpXQ1hobHdQVWl2?= =?utf-8?B?ZjV4STNmMVdZTnFUYkxwOTdidjNqMnh1Zis4cnNMUzlnUkh1RThJa3B6UURT?= =?utf-8?B?T1AwTWlTQzI2aEh0UFNqSjIvS1lJZHFKUmhCNkJCa09LWTB4eTNleWJ5K1Rx?= =?utf-8?B?RFY3aE5iNXJXalNFWnExS0UvNGdudVV6Q0JtY3FvTWZwWkR5YkxjRVQ5Z3pZ?= =?utf-8?B?Q283R3ArTmxnc2d6YUdGZEczczZsMEh1NUFEcDZqaTBPT0ZZc1hGREJwc1Rw?= =?utf-8?B?L3kvcG1Xc05EM0ZXTDlrUjlOQ2lBcWJEMm9DbHZVNFNXQmJGcVV0WGJmdi83?= =?utf-8?B?N0VBSEhYV2JGWVZtT2Y0TS81MXloc0tpRVlYVnY5NjJ3cUFUN29tTnZvUEdu?= =?utf-8?B?dkVFaU0xL0ZQUzJXcCs4d1QrdGZvYmZMemIweldQYXVhS0o1L2NkN0pGTnQ2?= =?utf-8?B?TjZoWXlYSTh2THIrdWRaRjU4NTFya0FSL0ZVc294U3FMdnA1TGRXNllrOTNm?= =?utf-8?B?emFVeWc4OVR0SGhnaEc0WDhqb0wzUXBXZVNaZ3NMem5ZazNEc1NtL0ovUEZS?= =?utf-8?B?RHdFYTRza3c3TFV4MExXT2RFNTFCbVpqbzZnMHpKL29uSW5iSmRIcWxCUVc3?= =?utf-8?B?OHlxUzNmS1MxZHZpMW9jemowbERKa2xpMjgzNTZtaGxzWTRld0pzRUtIbWNz?= =?utf-8?B?d2RMOUI5UVRYMll5L1dVV0VYcnAvQ1FQOHZHK1BRK2JYUlB0bHM3VmlxS21F?= =?utf-8?B?TjFZS1FvWnB3K3B4R1BZNFFMMXlnYXdGU0pkM2pYcWtRaFJVR04wMXh1M3d2?= =?utf-8?B?K1pPYmR6dFNaWHBhY1RVUHRzZitXckdjTTlUbTFnZjJzaGRlK09FWDJqYVI3?= =?utf-8?B?N3Y1NmJxNlUzVndoRmh5a1NzQU05K3A1Zm5ScEt2bFVyRnFQb2FKaDlOV0Rh?= =?utf-8?B?Z2tPMmRXQWdab0x6K1NVUjMwSlFHczZSR25XQ1JJZHRFSXQ3QUZFRUVHUGJN?= =?utf-8?Q?rbdcCwSOoFhj0MpNpSlEJmJMW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a36387d7-9d5f-4885-5836-08da97e261a7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 12:52:59.2324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3htMQFTLWOZvHYXqLS/1obwc0X/vq0sZGfBAwd14nJoJSO8r4wB5TlH+t/IUk3CJlTVzGLwlViBoEP+Zio77aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7042 On 15.09.2022 16:01, Tamas K Lengyel wrote: > While experimenting with the vPMU subsystem an ASSERT failure was > observed in vmx_find_msr because the vcpu_runnable state was true. > > The root cause of the bug appears to be the fact that the vPMU subsystem > doesn't save its state on context_switch. The vpmu_load function will attempt > to gather the PMU state if its still loaded two different ways: > 1. if the current pcpu is not where the vcpu ran before doing a remote save > 2. if the current pcpu had another vcpu active before doing a local save > > However, in case the prev vcpu is being rescheduled on another pcpu its state > has already changed and vcpu_runnable is returning true, thus #2 will trip the > ASSERT. The only way to avoid this race condition is to make sure the > prev vcpu is paused while being checked and its context saved. Once the prev > vcpu is resumed and does #1 it will find its state already saved. While I consider this explanation plausible, I'm worried: > --- a/xen/arch/x86/cpu/vpmu.c > +++ b/xen/arch/x86/cpu/vpmu.c > @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) > vpmu = vcpu_vpmu(prev); > > /* Someone ran here before us */ > + vcpu_pause(prev); > vpmu_save_force(prev); > vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > + vcpu_unpause(prev); > > vpmu = vcpu_vpmu(v); > } We're running with IRQs off here, yet vcpu_pause() waits for the vcpu to actually be de-scheduled. Even with IRQs on this is already a relatively heavy operation (also including its impact on the remote side). Additionally the function is called from context_switch(), and I'm unsure of the usability of vcpu_pause() on such a path. In particular: Is there a risk of two CPUs doing this mutually to one another? If so, is deadlocking excluded? Hence at the very least I think the description wants extending, to discuss the safety of the change. Boris - any chance you could comment here? Iirc that's code you did introduce. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 13:09:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 13:09:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407980.650675 (Exim 4.92) (envelope-from ) id 1oZB6I-0005qX-85; Fri, 16 Sep 2022 13:09:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407980.650675; Fri, 16 Sep 2022 13:09:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZB6I-0005qQ-4h; Fri, 16 Sep 2022 13:09:46 +0000 Received: by outflank-mailman (input) for mailman id 407980; Fri, 16 Sep 2022 13:09:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZB6H-0005qK-9k for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 13:09:45 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d26d647a-35c0-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 15:09:42 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 09:09:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB5140.namprd03.prod.outlook.com (2603:10b6:408:7d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 13:09:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%4]) with mapi id 15.20.5632.017; Fri, 16 Sep 2022 13:09:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d26d647a-35c0-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663333782; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=JdlPdq19PNkXivfOlSMbxrfZ6weJ5GXQWe5ljGhsANo=; b=f/keCud/poxAr4tJsxECjgjqhodJLz77wibc9ooSZoCdCpRL0fZgPVZb 22HDauMrGRAzL8tq+WwUX+tVIfiygrq+Ms2exeFkmRhFJFj+Xly091tl9 PoF8AoVIox2VN0NNenh9yk3o6vL2RNtK8aqM9ng2BHiKoJW9B+7tStpxl 4=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 79830986 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:J5xBfakSvRAl8F3RBB0A9ZLo5gypJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIbCz3TM/qIMTbxKIgnboy28E5S78ODyoUyQVNtrig8ECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37a2s4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kLB7Q3/MBnGF1r9 N8VFm9OVRbEpryPlefTpulE3qzPLeHNFaZG4zRK62GcCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvL9cLb4ECKpOB1+KLqP9fPPMSDWO1en1qCp 3KA9GP8av0fHIPOmWHdoyLy7gPJtSjVWoUvCZCEzP1npFPQ5146GSZHWlTu9JFVjWb7AbqzM Xc84TgjsqMp80qDQdz0Xhn+q3mB1jYZUsBVGvc36ymMzLTV+AeTAmUYTj9HZ8civcVwTjsvv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRt3jX4iIQ6jxaKRNAzFqew14TxAWupn WDMqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgXpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:7gDpYq/5tqUg49Di05xuk+E9db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlGl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFfJccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiT7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri+knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYd099RrBmc8a+d RVfY/hDK48SyLaU5mZhBgl/DWUZAV+Iv/cKXJy+vB80FBt7QNEJgUjtY8id0w7heMAoql/lp v525tT5c9zp+8tHNdA7bQ6ML+KI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA= X-IronPort-AV: E=Sophos;i="5.93,320,1654574400"; d="scan'208";a="79830986" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eyU5sXPuAkB3mwgjHo+Pblv7kSUnR1tdiZSh4dEQB7eBKr+z3ExYVLTYLtO51ROxuoBEw+CZusgjEvWtWY5HvP7eUw1KyxJ4cLx9Nh5DQ2YN8tAZnllzYmcZu69cGhkem4gRa+5zjSgfB0Gme2ZdKzoaBb+EAjccwlLEaCZkPdPyIeNLIgqAawDe35FQUmQDdul5XeS4boLYJZM4U+q00s+Ccwn5ooKsDrtiuJaB4jPRAVvkK9iywco7Z4XyMosibjua3hDRrjvDUqA7M1oiUFdxokwmk2I2FNCW19Y/3OaRxdsKGvyQ6SJG5+HrlmK3bosxgmC60RUf0P48aZOM9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ODRnY/SE9sVqvYB79YIXmFVMbxNco6oSGy6y/lpmThQ=; b=fzKoJmj+9HVstdDC4mtIkcXRQFu26vfvMxBLJBpFjmozwnu7AjGQCuwv7FwNZKmKrrWTIOHLuVWtjaFEKMv/hMcss8UwWiFuQLsoOjKq/9f+YYrWDpGkEeq8GqtCjlevO0QRiC+1qcArM5v627iKFUvT5cA+4bBM926Ccij+zkdr+/Qp5EUo4ueJljiVW3v68FuA5DvDKxppgipzyef7o0Yec4T+y7/SMrlVpxpsjbDi2w+MG/uCl4w/DEwQPX0vF3vQeyQPwvtVyvc1+p4Pv1sQ6YTTQt0Pwu1+dRew8btpS/vfbJggmTM816dT2/urGu00lCPkPVld5aItcEMZBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ODRnY/SE9sVqvYB79YIXmFVMbxNco6oSGy6y/lpmThQ=; b=uVK6VMwcS5YduCX8zDLRebya7lBiUxGaEQsHTQKq+FFmWsGxwZ+ObE53vzCbiFKm4dqI7ecKf4w6j9h6cIO7ohmZms0JHWKZ7kUqdQRV3H1O1jc9gtFDejyjdv4TO9rCaPFu1Owwvmpmyk6IiQeCPTyXGzIyZqoAM6V+0aXwDYw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 16 Sep 2022 15:09:13 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Adam Szewczyk , marmarek@invisiblethingslab.com Cc: xen-devel@lists.xenproject.org Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0170.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BN8PR03MB5140:EE_ X-MS-Office365-Filtering-Correlation-Id: 33a4e8a3-65d5-4d35-909d-08da97e4ad2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s45yzYPFEjyeGkfMGJMBDdf4IBssfEeJ4knIoMza2L39v33b/Pn8sKR+c3Kh9hft6ZNabvLffaNUH6TIYW3hkZeRz/Xz+Q0/O/9TiZwBH79t/MBCRRPy6OP/UR1hfJEfp89f4MJt3V6uLuGiFFONQlgRNyij/+WJYKE8Ntbb5fsv1fjdd3vpQYEuYyQPgLndh6mK5jyQkhj/lODJ4qsbPZNGBDy7gf0ru0iUKLlQ+GCEQ62JabyMZAIoCYEaZYIOsnh6YTRAFINP2pYC8ZfOh1DGWHI70HVSdjom5WyEBhMrMOsuWg+eAmLXDrAno6ETUzoKpQVKtah/v2sIV9e5pfQIKHBJgQsDYopnfJn4WHhjbQ+S4nJSnXQ9JERwcdfDYAdDjYpgsQere89Q5p44H5CmLHMG7JYvojbo7zy6RBMoujoAXpYT40ATv8qIkTk+y/aarRDjreTeIxVrshkwQtmOca9ParTrv5HUVouWdi4IgC7rFZ9dEpULc5pqoS3ptvJ3wC+cLT6GRjf5vHD39fveOCtTcXkUGxkVGJOx9iPVGJ/JmiyKJYF3vb2ZJxj0Q6r6wrBs6IXUrpXr/pC2le/f7UOq/cqwZdEx2LJKu9XdaShTEOxsZC3LcZbppJIaVB+Y9+gVZpHzszwsNJhoy1+PpjuHOCzM1hxHqYCif8ruI5KrfEIm02/h/MPFH6GBa/qHydr0yxtlMOQcAYNPD8JOXmq/nqB1UCaGRrNPPzq4xft0khD+NQtfC/BOqNmq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8676002)(66476007)(66946007)(82960400001)(316002)(38100700002)(6666004)(966005)(66556008)(83380400001)(9686003)(33716001)(6512007)(6506007)(186003)(26005)(85182001)(478600001)(6486002)(86362001)(5660300002)(41300700001)(2906002)(8936002)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDg2Ni9WQTE0ejI5cDR1UVlGUDZuUXBIREpvbVBIY05iTDFhd1VZWGg5WjhL?= =?utf-8?B?VTVlRWFNcFZ4dlBUWnhqU20rL2toRFA5R253SklLOTNIckpQZ3JFcUF6RUQy?= =?utf-8?B?V1ljYUdOS2FNV1FuekVaa09OdnB5TnpLRGJsYVFNaUJQOVNkekYzcHlWbUVO?= =?utf-8?B?RnJudzJHYzNHeU9lYkRueVhxRHhlK05XUG5VckQ0dHpqWGJYczRHM1VHdlBr?= =?utf-8?B?TFNPWkdPNDIrYmxVUTNWQm5QVUxsNkRHM3dCQk9kMy83R3NNMVN3blBwdDdQ?= =?utf-8?B?TzJHeHV2U3phS1dyeEUyb2dkdFUzQ2dBU2FlU09OdklDem5wcEEvaHU2cTVj?= =?utf-8?B?SHFFOG5DTVFrWitJMUdrZmFoR09PMmMvRkNMb1VuRTI4MnlLVXFoek1lVkM2?= =?utf-8?B?RzlNS1dVUUFhSjFmVlpqNytJZyt6ZDRNZ2JjaVVCSi8xWEVUOExUcVJqSU1L?= =?utf-8?B?cTZVSU9VZTN3VktycDFOOFBKeGVTWWZWc3RTRDBSQTVaencyOTh3YVJoWmFx?= =?utf-8?B?WmxYNU5qSHJXMDZZWFNkRjc3cUJ3ZWRCaUExVG92d2dEOENpb05JNkJyMjdW?= =?utf-8?B?TFBLR2hJaGdLdG94M0Q4K3JRSENGYldRZXo1NjRHZm55Qm1UL0duUDB2TjJR?= =?utf-8?B?bnphNHFDd3FkL1hUUjYwYkg4bU5Eb000T2tsMVFpNTZ4bmlCU0lzZWRqcU9B?= =?utf-8?B?dkZSV3hFT2x1ZW9jbXJaTnpWRERBMkFkbElTVTdPV3lXM21sWTRzdzhiSC9X?= =?utf-8?B?anVxYmpoaE00NjVHK2JqQWhtMlRxZ0ZOdVJNRVpiM3NuWW0xMFRQU2dYaHdN?= =?utf-8?B?QmlWSmhqTFpQTnhLblhtTTlSK0F1bG1saDBXOHg1czRLZGdza2lVS3JITjBP?= =?utf-8?B?WEZpdnZEZWQxYjNyclBlLzJEaWtOTEsxanJtc1FHL3RVdnpOYkJkeHRlLzJJ?= =?utf-8?B?WHZOam52blpScU51bFpoaWtzbTArLzR0V3hMMUZxTzhneEJKcTAxTHdvTXdk?= =?utf-8?B?Y053a2dTdjVSTFp5SGdDU2pjTFJzRk8yRzRYcFlFVFRTNnNYcjUwR09wMytw?= =?utf-8?B?S29YbHBOQm9zUDh1SHNJZWJ5c2RUWnB4TkxxeERiUzlvTmdweWhGd0VmdUZR?= =?utf-8?B?T0lIKzFmTnNXeVhqUjUvRmU5Z0lKUHhEOXVyWXNKY2Y3MEdUWHBwL1VVdTYz?= =?utf-8?B?aFpJMlV1SW1MVHBUTE5mQWVpZ1lzcW9JS21Xa2piNFI1R0F5clMyZWFCc1hO?= =?utf-8?B?N3FYenIyS1dCUHNoRGVWaGNiZVVqY2ZYUURBdWJmTExBZGYzNDIwVERLdnlG?= =?utf-8?B?ZHVRM1h3cXFjYi8wemxXWmhjVXRSMUpyVFVETFFsWDBtS3hxb3BtTldydkRh?= =?utf-8?B?bGw0V1NGRjgwZjVlS09WT1R0alVJUXljcDFiVVgrZzhUeXFRTER6TlR4NUlr?= =?utf-8?B?d1drWnI0WklVNWFHRDNCY0FBdXFZcCs4c1NqTGd5bUxFNW1QRWc3V2ZwZUFy?= =?utf-8?B?WlpoYSttZXNhWU5vKzNwWUpMMVJ2VW81Uzg2a0pXSzhMdWZHSWVPeSt2YUVJ?= =?utf-8?B?bVhlSFdLN1QyekJHTmhVZEdubmdYSy9mTkY3WjhWVkVmemZsOHFxaEpCNU1X?= =?utf-8?B?a0pSZ1U5WGRaRHd3TmQ0UDlkd0V5MW5UblBrVTYra0duMFdaeGdIVzhUSjc0?= =?utf-8?B?TmJBdjhkdlhPOW9MSFdjRG4zMkVmd0xHOVd3UXVrV1lkSE9zeURhWExTUEIv?= =?utf-8?B?Q3NWN3lXRnl4d0F0eUw2WlpLdlY3TlNVU3dyS0pUOHVWd201eTBmd1BwVW9j?= =?utf-8?B?L0xnTmcwSDFUaEUvU1htQUY1QmlIN05tRTkxdjNyZStNVGF4bDhnZW5kc09q?= =?utf-8?B?dHoyRmwyLzk5cndJYlUvMEl0eS9PU2J3T1NSeUp1bDhPMVRZdFdvS1o5MFRa?= =?utf-8?B?Y01seEhWUzlDTlcwVlNsVW0vNzd6RFUzL1YzTmhQbmpWRC8wUWVNTHBaV05q?= =?utf-8?B?ZFlQZG5tLzFYUlJYRUZUU21jMFE3U3UzRTdBdlhwbGNCZnZtcjZ4S2VGNlZj?= =?utf-8?B?Qm5Mc0dUWEc2VW9JS21ONEZWUFcwQ2Q5amxWcTRWMW9QdUtvYklJMGRLWFR5?= =?utf-8?B?WXFnUFRoKzJneisySGFtVEJ4WTVvQXpBNmNUWW9CT3J1TnlYRjg2QTYvV1FG?= =?utf-8?B?b2c9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33a4e8a3-65d5-4d35-909d-08da97e4ad2c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 13:09:24.2093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rcDpUymCadvu2FWBRrNqwJnDACGajvf7byElwEZdfigdCeM1X1OyovmoOBw5DHCK0fXsn/ZxB5lQ+CypcQZRSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5140 Please keep xen-devel in Cc and avoid top-posting. On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: > After trying to configure previously disabled iwm0 interface first those > errors appears: > > > iwm0: fw chunk addr Ox404000 len 712 failed to load > > iwm0: could not load firmware chunk 0 (error 35) > > iwm0: failed to load init firmware > > > Then after second attempt or if config is set in /etc/hostname.iwm0 during > boot system panic: > > > panic: kernel diagnostic assertion "sc->task_refs.r_refs == 0" failed: > > file "/usr/src/sys/dev/pci/if_iwm.c", line 10352 > > Stopped at db_enter+0x10: popq %rbp > > TID PID UID PRFLAGS PFLAGS > > CPU COMMAND > > * 19554 71630 0 0x3 0 > > 0K ifconfig > > db_enter at db_enter+0x10 > > panic(ffffffff81f1e289) at panic 0xbf > > assert(ffffffff81f8dd81,ffffffff81f8a6db, 2870,ffffffff81f39e88) at > > assert+0x25 > > iwm_init(ffff800000211048) at iwm_init+0x2c4 > > iwm_ioctl(ffff800000211048, 80206910, ffff800014bc88c0) at iwm ioctl+0xf9 > > ifioctl(fffffd802900d8c0, 8020699dffff800014bc88c0,ffff800014b1f7a8) at > > ifioctly+0x92b > > soo_ioctl(fffffd8030f e0b40,80206990 ,ffff800014bc88c0,ffff800014b1f7a8) > > at soo_ioctl+0x161 > > sys_ioctl(ffff800014b1f7a8,ffff800014bc8900,ffff800014bc8a20) at > > sys_ioctl+0x2c > > syscall(ffff800014bc8a90) at syscall+0x374 > > Xsyscal10 at Xsyscall+Ox128 > > end of kernel > > end trace frame: Ox7f7fffc3330, count: 5 > > https://www.openbsd.org/ddb.html describes the minimum info required in > > bug reports. Insufficient info makes it difficult to find and fix bugs. > > ddb{0}> > > > > pcidump returns: > > > Domain /dev/pci0: > > 0:0:0: Intel 82441FX > > 0x0000: Vendor ID: 8086, Product ID: 1237 > > 0x0004: Command: 0004, Status: 0000 > > 0x0008: Class: 06 Bridge, Subclass: 00 Host, > > Interface: 00, Revision: 02 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR empty (00000000) > > 0x0014: BAR empty (00000000) > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > > 0:1:0: Intel 82371SB ISA > > 0x0000: Vendor ID: 8086, Product ID: 7000 > > 0x0004: Command: 0004, Status: 0200 > > 0x0008: Class: 06 Bridge, Subclass: 01 ISA, > > Interface: 00, Revision: 00 > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR empty (00000000) > > 0x0014: BAR empty (00000000) > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > > 0:1:1: Intel 82371SB IDE > > 0x0000: Vendor ID: 8086, Product ID: 7010 > > 0x0004: Command: 0005, Status: 0280 > > 0x0008: Class: 01 Mass Storage, Subclass: 01 IDE, > > Interface: 80, Revision: 00 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR empty (00000000) > > 0x0014: BAR empty (00000000) > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR io addr: 0x0000c200/0x0010 > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > > 0:1:3: Intel 82371AB Power > > 0x0000: Vendor ID: 8086, Product ID: 7113 > > 0x0004: Command: 0004, Status: 0280 > > 0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous, > > Interface: 00, Revision: 03 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR empty (00000000) > > 0x0014: BAR empty (00000000) > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat: 00 > > 0:2:0: XenSource Platform Device > > 0x0000: Vendor ID: 5853, Product ID: 0001 > > 0x0004: Command: 0007, Status: 0000 > > 0x0008: Class: ff (unknown), Subclass: 80 (unknown), > > Interface: 00, Revision: 01 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR io addr: 0x0000c000/0x0100 > > 0x0014: BAR mem prefetchable 32bit addr: 0xf0000000/0x01000000 > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 5853 Product ID: 0001 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 > > 0:3:0: Bochs VGA > > 0x0000: Vendor ID: 1234, Product ID: 1111 > > 0x0004: Command: 0007, Status: 0000 > > 0x0008: Class: 03 Display, Subclass: 00 VGA, > > Interface: 00, Revision: 02 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000 > > 0x0014: BAR empty (00000000) > > 0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000 > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: f2000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > > 0:4:0: Intel 82801DB USB > > 0x0000: Vendor ID: 8086, Product ID: 24cd > > 0x0004: Command: 0006, Status: 0000 > > 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, > > Interface: 20, Revision: 10 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000 > > 0x0014: BAR empty (00000000) > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00 > > 0:6:0: NEC xHCI > > 0x0000: Vendor ID: 1033, Product ID: 0194 > > 0x0004: Command: 0006, Status: 0010 > > 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, > > Interface: 30, Revision: 03 > > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR mem 64bit addr: 0x00000000f2010000/0x00004000 > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 > > 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 > > 0x0090: Capability 0x11: Extended Message Signalled Interrupts (MSI-X) > > Enabled: no; table size 16 (BAR 0:12288) > > 0x0070: Capability 0x05: Message Signalled Interrupts (MSI) > > Enabled: yes > > 0:7:0: Intel AC 9560 > > 0x0000: Vendor ID: 8086, Product ID: a370 > > 0x0004: Command: 0006, Status: 0010 > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, > > Interface: 00, Revision: 10 > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > Cache Line Size: 00 > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 > > 0x0018: BAR empty (00000000) > > 0x001c: BAR empty (00000000) > > 0x0020: BAR empty (00000000) > > 0x0024: BAR empty (00000000) > > 0x0028: Cardbus CIS: 00000000 > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 > > 0x0030: Expansion ROM Base Address: 00000000 > > 0x0038: 00000000 None of the BARs are at 0x404000 which seems to be where OpenBSD is trying to load the firmware? I would have to look at the code to figure out exactly what it is trying to do here (and why it fails). Can you also paste the output from `lspci -v`? Just to compare with what is OpenBSD is reporting. > > 0x003c: Interrupt Pin: 01 Line: 05 Min Gnt: 00 Max Lat: 00 > > 0x00c8: Capability 0x01: Power Management > > State: D0 > > 0x00d0: Capability 0x05: Message Signalled Interrupts (MSI) > > Enabled: no > > 0x0040: Capability 0x10: PCI Express > > Max Payload Size: 128 / 128 bytes > > Max Read Request Size: 512 bytes > > > > As for realtek can You send me some guide for using xl console or some > marks for xl dump to find those keys? I'm not sure about QubesOS, but you have to execute: # xl debug-keys 'Mi' # xl dmesg >From the control domain. I'm adding Marek because he can likely provide guidance about how to execute those commands from the control domain. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 13:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 13:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407988.650685 (Exim 4.92) (envelope-from ) id 1oZBVK-0000lu-Et; Fri, 16 Sep 2022 13:35:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407988.650685; Fri, 16 Sep 2022 13:35:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZBVK-0000ln-CC; Fri, 16 Sep 2022 13:35:38 +0000 Received: by outflank-mailman (input) for mailman id 407988; Fri, 16 Sep 2022 13:35:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZBVI-0000lh-VM for xen-devel@lists.xen.org; Fri, 16 Sep 2022 13:35:37 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 703148ad-35c4-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 15:35:35 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 09:35:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN9PR03MB6025.namprd03.prod.outlook.com (2603:10b6:408:136::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 13:35:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::352b:6017:176:4f6e%4]) with mapi id 15.20.5632.017; Fri, 16 Sep 2022 13:35:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 703148ad-35c4-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663335335; h=date:from:to:cc:subject:message-id: content-transfer-encoding:in-reply-to:mime-version; bh=kG5EzjFODtCwNsyXVF2QbPxc4glCcGst+oHLRR1MHGU=; b=XPaq4HSkDwWI6uvXn2GrpnnANlHr20jG0Del5+eU/lrCCcr53Lug9095 PPQ2XVHto9y56HPfL9Un1c5dTC73oi0/7NSXkp5BHg5NardtJ7TwVKcB9 HATs8KVXZPfl9mMaAZyFuQNfoGj/j8QAvofpGLraE9TpvjrcBHbEgL2V8 w=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 83205714 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:CsOaYKMXJAYKGJjvrR2llsFynXyQoLVcMsEvi/4bfWQNrUoh3zRSm 2NJC22HaPnfazf3f4ogPY+3pBkB6MeDn95gTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMuvvd8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFO9zeVpS0IfE7ZE3dhYO1gJy aQSJD0CO0Xra+KemNpXS8FKr+F6dYzBGtNavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr4wCChI1W0q3rMzUYzy3LUwwFrlqDkLfLee8CQRNUTlUGdz o7D1zSiWElHa4XDodaD2k+jmOvGjSfnYagDBZK/26VOkg2c+XNGXXX6UnP++5FVkHWWQMBSN EcP/SwGoq079UjtRd74NzWorXjBshMCVt54F+wh9BrL2qfSpQGDCQA5oiVpbdUnsIo8Q2ws3 1rQxtfxX2Ux4PuSVG6X8aqSoXWqIy8JIGQeZCgCCwwY/93kp4J1hRXKJjp+LJOIYhTOMWmY6 1i3QOIW3N3/UeZjO32HwG36 IronPort-HdrOrdr: A9a23:8OIbeaAVKauSb0vlHehJsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOE80kqQFmbX5XI3SOjUO3VHFEGgM1+vfKlHbak7DH6tmpN xdmstFeaHN5DpB/KHHCWCDer5PoeVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dO0EPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmffHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+3CVTbUkf4fHkCE+oemp5lpvuN 7Qoy04N8A20H/VdnHdm2qe5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe 929lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQlo+a87bW3HAb0cYa dT5Jm23ocWTbraVQGTgoBX+q3hYpxpdS32AnTruaSuoktrdT5CvgglLfck7wY9HaIGOuZ5Dt v/Q9pVfZF1P7orhPFGdZM8aPryLFDxajTxF0/XCWjbNcg8SgLwQtjMkf0I2N0= X-IronPort-AV: E=Sophos;i="5.93,320,1654574400"; d="scan'208";a="83205714" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nio5yoITYK5YRzYhcQK6+obUtqjv7NxWS0BSf92lhYLVzr3X/KUk2puiVZOqOBaKKRMxQsyB2QIe68o176zrymcHGmy+VtVDw71WDrwcuEq802/nvO1aCdMrQ13W/Q0E471rtLhGTJrmItqxG4kL7s/TPKBMssnESeenfCXGHAhsoonw4LgLBywDkZqlGfkVBEe+F0Lv8MnnpuW71dPARnKDwAk9jdYp0mbdBm3BQ+0Qo7Ld2oTDNhvCgFSXFdLdvPgMU7rXanu/uBGyEO49kN13tG9FNNXDcdmr1CLZlzSw7bsdRslb1r56Dg3mfkqciEFAOSMhr2e16LZiAYdP5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=99otT8we/7e0MOONlXF3h3V+jEf7LpLhX8cdYTMlN+Q=; b=W+79rIF2jWNXdh/5oB+21adj7qrQ3+/Gs/+erwhSLdMuN44B1ybY0sQxy4BAHopSbFCBqk3+yhd9A5LdgCmvhDSpMgLoXinzWQ4bl/Yv6901QN6YTcxWbVUuFjN4W5JMVSf7tmNRaK7udUXSSZDVIKPtKqFTJzdWnCIZ3GN657huydIU9Z/noADdREpMSypO/2nJOBGwq9oapsZ18tPearoGzfAs2/APuWj407ll6xPvuF/GHb3XY0cXOCFFI3Zz4XuAFmNqiIzCYKIFHENdlR4mpV/V/SBj939/l8eXUe8NwpXjF8Y4DgA+bOKA3rLDs+Wb8mALJUsJQfhCcOPDZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=99otT8we/7e0MOONlXF3h3V+jEf7LpLhX8cdYTMlN+Q=; b=qxVYqE3RDTzv0P/wobfD5Z3m0bFdYWuJfz0b3fwxpz33+4UVGZvpKWIMeWeEWOddZ26vg1G/HO0WTsizI374cLMBmYDQ9dEuEyCK4KsBYLAK0IzFBdsPYLonwokeSS3x1ae64pB3Tf9B7bIvYBB6Kx4nevOtXB3XxNsFBxkZaH8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 16 Sep 2022 15:35:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Adam Szewczyk Cc: xen-devel@lists.xen.org Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0425.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_|BN9PR03MB6025:EE_ X-MS-Office365-Filtering-Correlation-Id: f7cf5695-2707-4e53-9662-08da97e84fd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nZrRsCA0aGLAw3VT2+e3JnnUaa5CgVO5GIO/NIWcslZLBBraZ1IOjjHH6/Ak5VXlc7tHDFpuC6QltpM6jdT0AWz6rTFk1V2ilq9srLTJKrQ3PYin+2IoJdf7cAaciMPEwK0oXN0HLhhtiOi0HH4Jhpu8KEkluMYHS1IFJVWWMzZr+QFsR/UdKHqVQL6jzd0iLcTzCG+i3ePA+cb/5dEvW5PVQxHPezsoMTq1oea8w8tueWnzHBsUzyA1F2j4xW3tyT7lTT7EFr71Cf5+oToniln7DPu0nzT5WWClPIvJTh8bGJFU4Ux3LBItEGrOb0K/BXIqLxphmzNS+s8SWnS6+7fHzDBRWFCL3VhpkQQKmlZ9VPj7Y73elzujlimKI7ZjQHr4FNtfJmd5t+uIaKQv09bsReCk/Rn+VLe3UP3cvb7noP+uX5dcnAWIaTf/AUva0jwwXVG+qcVBv/HWdu59OUD5WpO6c/cNtECJoUOP4WjUahnq3Zrjf3b9Rji//Tp1svTpzZlqwsJdteKgU6GsmyPTR5KKK4qmLzliRPREfJsSxMHIv1pUXpBFT41ujO4tvrR4y4BNNag6GKsLR0iKunRoTcU854fk0Eb2+6TIIKF7AgLTGRSzdMhv6rCA0cT9tnLO1+4CFEsrBg0wSFCHVvxNnlwh5/o9AKzynpRzszCNJzkiv67j6yIYkFdXyCETjvhLjwI1ajHNPTjfgbs7HQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199015)(8676002)(316002)(8936002)(5660300002)(66476007)(6916009)(86362001)(4326008)(66556008)(66946007)(82960400001)(38100700002)(41300700001)(6666004)(6486002)(6506007)(478600001)(26005)(186003)(9686003)(6512007)(33716001)(2906002)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHpkK0pSUTJhL20xWW04eDFOTjJoM0laUnlXem5vTTZzY1VWSmM4b0dqNDR1?= =?utf-8?B?K2ZBT3dPSlE3TkU5RG9ENWF6eUZaNGJkQ3BXYVl0MHdGT01GaXlKVWpEOThP?= =?utf-8?B?dUo3eGpFdSswelBUbW1Fblpabytickgzbit3Q0R5VE5pV3REbTBuZUx5eFBa?= =?utf-8?B?cWhvcXlNc3pXQUJ1anFwdURrK2MxdndyUytOZ1ZQUFg3cUVSeVVtMkZzQTdq?= =?utf-8?B?YWpsTURrdkUzSzd3SXpKbWZvejlrQ3liNjNTRVMzUW0xODF5ZXhSTUhhRWpT?= =?utf-8?B?NTRFekdxaUZpYnJwYzhYUXdQL2U1RUZzcjZjKzZXRUUvbE0vOTArdWNDRVVE?= =?utf-8?B?d3h5QUo0ME1hY3laSFdXbm93WFNCbXUrbkh6OC9YSXR2Y1pWbVF2L09IM2Zj?= =?utf-8?B?WnlUZDJraTZXajd0UEEzUmw0ayt0RzJMTWFUV1d0Wkw0OStNMVBmYVVvR0x2?= =?utf-8?B?R3l6Y0xxMnhNcEMwR21MRTdpY3d1NkJQRlc1blBkdGY0VFVzN1BHbS93YzF4?= =?utf-8?B?aEZuWDdoWnEvUkZNeHp2RFpNOGVRZzNlblBSMnZOZ3RDdjBXRHpjNlhCSVZI?= =?utf-8?B?V0JaNUV6cVFVZGthdUJZMDNDSmh5c1NMaHkyWk1iSklFcE04c1hDaTl4a2Zu?= =?utf-8?B?eTVzaGoyNHFjQ0crY1U4eVZURVhaclErYkNXNExXejRrem51enJiS1IxYmpx?= =?utf-8?B?RGhBOGlIMldWMUdjV1AzamhITnUxMzlSemJMZHNMWDdWU2dMNm52ZlZkMndh?= =?utf-8?B?M0ZOejhxTkFIRkNyVndrTEU1UmJzZU5hSFB2bDRkT3NQSUJUWENqRmNXeE9m?= =?utf-8?B?d1RKUkVqa3c0aUkyTkNEWmZQWFR3SmpWbkdZbFI4Mm1nSndJQjEyMG9oSDFG?= =?utf-8?B?M3ZRMEFHM0tEUEdweWtxekpnZTZ1bVNFRTlVS2JmaUpYOUVNM09VVi9zdzVM?= =?utf-8?B?ZXZFTTBZVlV1T2lHeCt0R0VjVUVCVFQzREJhY3kwTmFvNXpmUFM3NE81cmtu?= =?utf-8?B?YkIwMFNtVk5YZVpyamI0R0hHL3hLazlnUTRlR05YOU04ci81Y3VlRGp1NTJU?= =?utf-8?B?dThYdStZV3lGZlFqaEoxbDNmQnYxNUE3T0dYODArdkU3YjFCUTZJRHY0aWRt?= =?utf-8?B?a24rVFJxeGpmSzJkRjYrcTFpem83dUp0bmhGTkdXbDVrZEorYkV5Q1RucFdk?= =?utf-8?B?aDVQTnljR01IdXBVZ2RlN2swYVFYbnZaVjJrMFJ5bGIvSWRYaDZSUDZUUjdY?= =?utf-8?B?MG8rc2tRbkhFNjZxblZjanJaR21Id3dlTzlwUjI1OW4vdHhDSG5SYUZqWi8w?= =?utf-8?B?a01hNitZeVg3M2tHU25TMjdZem05NlNpeFJuWkJjR0dVN2pWcnY2K2N6d1Nm?= =?utf-8?B?MlVQUHlPV0FpcnBxR1FINnRKWjVlZmY2MlFYREJvZ1YzSXNXYjg3eEdmOGhT?= =?utf-8?B?ajhJZ2o5WXBEMVo5TUYzQlVtTnJOWmNEV0hJK2V6NGM4OWpWSmR5cFV4ZkRO?= =?utf-8?B?UFQvRFB0Tjk0czdzVmp2Ym8zSUM1REJCUVQzTTJPZmRMcHBMOEpOVmJIMm5Y?= =?utf-8?B?SFM2V04yMjRqVmxTdzkzbkJUYWNQdzhHSGZ2TDUvZUpycFhZZHNzSWR0Tk9u?= =?utf-8?B?MS9iWVJPS1g5aE9vdVJ4cEI0T3hhT0NpOURDQW1oNW9sQVprQkFnM1FpUysx?= =?utf-8?B?YUl0Yk1waEdrNTJPc2tZdkE1Q3VRWURRdWVIOWRtU29xVk1PaTY5SGdJcTRW?= =?utf-8?B?OGp5MHA2anN1M0VtMDZRWFBKdU12K09BVE1rT2dZSmlQNkM2NCt2cDBjZVR6?= =?utf-8?B?bjRXM0V2VkxWTEVyR3p2OG1hbVZsQkExdGhzd2w0TGhhL2RDY1grSjM5REVt?= =?utf-8?B?M24yWlYvZFhSYWJZenlCZUU1elFrNGh3QTVyaXcrUlBjOG8wT2pvdEUwVmZB?= =?utf-8?B?ZnhkT29GOGJrWW1MQ0RqTCtRMUtOSjlQRWprbWNUZzFMQ2x3UDhqb0RobEpJ?= =?utf-8?B?UlBKb2szMlZCeU9iTHFkVEJMbGt6UmZWbTlnNlZaM2JrM1NRTTZZM2paVk55?= =?utf-8?B?cjBnZW9HZ2h5TDRxcFhzU3ExVThMUS9SRUhqaTU2NnFxSTNIOFdzQTFiYXUx?= =?utf-8?B?WjRNbTJFYXNYZ3kvbUtYT0VJbkRydTNlR0hNTnVlcE1rKzQvSWN0UzkybEhE?= =?utf-8?B?Rmc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7cf5695-2707-4e53-9662-08da97e84fd7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 13:35:25.6113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PGPmLYD5WQ7dW5TCcdmnLYxzFxTfiSxx1QZRudjY71TgM0mCQd8ppbxtXwloptO36qIDT0pezOwIh0mb9KQnrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6025 Again, please keep xen-devel on Cc and don't top-post. On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote: > I executed it in dom0 terminal and it prints lots of stuff, but when I run > jus xl dmesg it prints almost the same logs. So I'm not sure if I have > right output or what I shuld search for to paste it here. Hm, you should see something like: (XEN) [ 8729.266567] MSI information: [...] (XEN) [ 8709.154958] IRQ information: [...] In the output of `xl dmesg` You can paste the full output of `xl dmesg`, that should be fine. > Regards Adam. > > pt., 16 wrz 2022, 15:09 użytkownik Roger Pau Monné > napisał: > > > Please keep xen-devel in Cc and avoid top-posting. > > > > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: > > > > 0:7:0: Intel AC 9560 > > > > 0x0000: Vendor ID: 8086, Product ID: a370 > > > > 0x0004: Command: 0006, Status: 0010 > > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, > > > > Interface: 00, Revision: 10 > > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > > > Cache Line Size: 00 > > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 > > > > 0x0018: BAR empty (00000000) > > > > 0x001c: BAR empty (00000000) > > > > 0x0020: BAR empty (00000000) > > > > 0x0024: BAR empty (00000000) > > > > 0x0028: Cardbus CIS: 00000000 > > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 > > > > 0x0030: Expansion ROM Base Address: 00000000 > > > > 0x0038: 00000000 > > > > None of the BARs are at 0x404000 which seems to be where OpenBSD is > > trying to load the firmware? > > > > I would have to look at the code to figure out exactly what it is > > trying to do here (and why it fails). > > > > Can you also paste the output from `lspci -v`? You seem to have missed this bit. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 13:40:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 13:40:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.407996.650697 (Exim 4.92) (envelope-from ) id 1oZBaA-0002BA-0t; Fri, 16 Sep 2022 13:40:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 407996.650697; Fri, 16 Sep 2022 13:40:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZBa9-0002B3-U8; Fri, 16 Sep 2022 13:40:37 +0000 Received: by outflank-mailman (input) for mailman id 407996; Fri, 16 Sep 2022 13:40:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZBa8-0002At-3u; Fri, 16 Sep 2022 13:40:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZBa8-00072S-10; Fri, 16 Sep 2022 13:40:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZBa7-0007NN-FT; Fri, 16 Sep 2022 13:40:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZBa7-0003Et-DH; Fri, 16 Sep 2022 13:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p7ITYlmLqYdGHfn/6jYNcpSRjkfW/jkw/wU/7xayt40=; b=bYcfxTFtIRi47oM+fYZN412V09 lRg1nnx3QBXDiQoALptrI4Ycd4JJhwFlXORs3M18JfLTsEaC2wPomhlm9zuhJuBY35P7lhCm3bbTz HX96UVVhDdUb4P2ijsX5mbNGQ55e8V8JMdqvOOIJ2zFPTo61z849RO0DNyhrrcNJ3fME=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173227: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:build-amd64-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-i386-libvirt:libvirt-build:fail:nonblocking xen-unstable:build-arm64-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:build-armhf-libvirt:libvirt-build:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Fri, 16 Sep 2022 13:40:35 +0000 flight 173227 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173227/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a build-amd64-libvirt 6 libvirt-build fail like 173207 build-i386-libvirt 6 libvirt-build fail like 173207 build-arm64-libvirt 6 libvirt-build fail like 173207 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173207 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173207 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173207 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173207 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173207 build-armhf-libvirt 6 libvirt-build fail like 173207 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173207 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173207 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173207 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173207 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173227 2022-09-16 01:53:40 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Sep 16 14:22:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 14:22:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408007.650708 (Exim 4.92) (envelope-from ) id 1oZCEk-0006eK-BF; Fri, 16 Sep 2022 14:22:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408007.650708; Fri, 16 Sep 2022 14:22:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCEk-0006eD-7M; Fri, 16 Sep 2022 14:22:34 +0000 Received: by outflank-mailman (input) for mailman id 408007; Fri, 16 Sep 2022 14:22:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCEj-0006e3-Br; Fri, 16 Sep 2022 14:22:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCEj-0007oV-9y; Fri, 16 Sep 2022 14:22:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCEi-0001qv-Ht; Fri, 16 Sep 2022 14:22:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZCEi-0003zm-HN; Fri, 16 Sep 2022 14:22:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V+UU182BN3gw4M8XQzQRpIGJRzATd2gSH1dPet5dQis=; b=ByuxgIsMTrfgKJ2u6N6uKQV5qt f7ABQZnF3YeQ47dRx1xxXw72a77V/7CLN54YpI9RVzzPKhVbKLkkGMaKrsACrc/tJkATNwjda3b7F nfr6pKwIW8/DwS7Tn4C5GhZRCYwfG7aBsmhsVHhHPsPik/d7VgKCzTN5jUn+69CkhDk8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173234: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=2c17d676e402d75a3a674499342f7ddaccf387bd X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 14:22:32 +0000 flight 173234 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173234/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 2c17d676e402d75a3a674499342f7ddaccf387bd baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 320 attempts Testing same since 173234 2022-09-16 10:42:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gang Chen Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Nickle Wang Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2652 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 14:27:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 14:27:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408015.650719 (Exim 4.92) (envelope-from ) id 1oZCJF-0007JR-SV; Fri, 16 Sep 2022 14:27:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408015.650719; Fri, 16 Sep 2022 14:27:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCJF-0007JK-PP; Fri, 16 Sep 2022 14:27:13 +0000 Received: by outflank-mailman (input) for mailman id 408015; Fri, 16 Sep 2022 14:27:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCJE-0007JE-Cn for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 14:27:12 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a662c0a4-35cb-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 16:27:11 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id jm11so21562135plb.13 for ; Fri, 16 Sep 2022 07:27:11 -0700 (PDT) Received: from [172.19.1.55] (50-199-13-217-static.hfc.comcastbusiness.net. [50.199.13.217]) by smtp.gmail.com with ESMTPSA id f11-20020a170902ce8b00b0016dc78d0153sm14996189plg.296.2022.09.16.07.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 07:27:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a662c0a4-35cb-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=SxK+8r6WWXjaYbHfUsvSJpeaDsBL9HQkoqXbEeIiSHs=; b=fswotqqvFYVw6hNmcEvM666ymxj0V8DrfIzONxpAG9Po7dizcLi3Gtmr4ZYUtuRPgW Rl/r46WMcS199TMFj59sSZs/SzZpALHXkwBdldUHkAyHXvss9zrurV0UabYLvoITp5vD qPa5ceDUwemHH7i85JJ+PzR3YBa6AUiAlU14ptASnZnBXQwblen0voDtt+yLb0t2As0i kXe6fysqy1xgir/hOdPfqjJS3c+VE7Ub82wEz72WwCJ2EBdRuu0Y3LPKxo70ycGEPPKo 2e65gfmNo237+36HLpB1vB6a0ZyEJsFUkxN/2dg4/m/j6uqDAjyh46VTcSnwtZlfSevk iD6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=SxK+8r6WWXjaYbHfUsvSJpeaDsBL9HQkoqXbEeIiSHs=; b=QkqOMcObknIuP3n5P31GrJy8qkN+Vx7Ojv8THaR07r77k7OW/g0qvDvEokTmmFTy3s 8Taa2XyzL48jnd6Owp6bijeoipa2+Dx2ARigD1PEXxpExqJdwFST25cxh3r0jmDgVBiU gKP7y3UDRr7Lqu/+cQZVUY73k9SvC58hOaoFisLdXzbtRC/ZhggHRayFyeWgTe243Pa8 o1NKChih36GU4JCz+3hKnHuwdxe/nvf4ZHa+lk4HrcawGGiEwSvVlFzr5ZE60pgUcbOX eev7HhRaOTiE5wRUFpqF077/qegmoLIM1nR6TXAu2ES2LcWgQg4mIgkrDC5hw/ktxpy5 /V+w== X-Gm-Message-State: ACrzQf2m48PmpYdbSdtxeZY0nECSgpzAc1fGb20G3+1U1TcRWJRZ4qDW GEvDeeuAPMPg9wylqxbKabo= X-Google-Smtp-Source: AMsMyM6Bw0leUpkBF5PpoAEfrFywKU1AILoBcbk9yS14xVUriYHK73nLxSvENh7yDJhko9hlA9D7AQ== X-Received: by 2002:a17:902:f0d4:b0:176:988a:77fd with SMTP id v20-20020a170902f0d400b00176988a77fdmr113301pla.25.1663338429904; Fri, 16 Sep 2022 07:27:09 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: Date: Fri, 16 Sep 2022 07:27:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device To: "Ji, Ruili" , "qemu-devel@nongnu.org" Cc: "Liu, Aaron" , "xen-devel@lists.xenproject.org" , anthony.perard@citrix.com References: <8be84a25-c31d-fd88-f913-c03c15046a55@xen.org> Content-Language: en-US Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/09/2022 03:07, Ji, Ruili wrote: > [AMD Official Use Only - General] > > Hi Paul, > > Thank you! > But how could we merge this patch ? > AFAIK Anthony (anthony.perard@citrix.com) still deals with this. Cheers, Paul From xen-devel-bounces@lists.xenproject.org Fri Sep 16 15:09:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 15:09:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408044.650742 (Exim 4.92) (envelope-from ) id 1oZCy0-0003PQ-5H; Fri, 16 Sep 2022 15:09:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408044.650742; Fri, 16 Sep 2022 15:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCy0-0003PJ-2N; Fri, 16 Sep 2022 15:09:20 +0000 Received: by outflank-mailman (input) for mailman id 408044; Fri, 16 Sep 2022 15:09:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZCxy-0003PD-ED for xen-devel@lists.xen.org; Fri, 16 Sep 2022 15:09:18 +0000 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [2607:f8b0:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8587aead-35d1-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 17:09:13 +0200 (CEST) Received: by mail-pg1-x529.google.com with SMTP id 207so12227511pgc.7 for ; Fri, 16 Sep 2022 08:09:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8587aead-35d1-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=B1+ek0q0jjlVBw6oJoPlssOUueEinSZ/yPE3jdbA81k=; b=YZtmAlIKndjbpgFGIOUtac3GnXr/QcO4P87rFZnA9cn9AP8gRhGCIz/QMFoTsYuAsP gQwER1Up+n3/1/TUFN5LcQBtRswiSziGET3OgSeHqN2jpC99YJwZ3jj+BcvaXmkN7oLN yUIu2j4TCuaTAmynMm9BCVBbXZjnuUNqCJUu4zcj0zRxLS2+bkU0FfuPGLAsPrNwrzTp hlaIFHbLOSa70BDDSQR+SQsDc9ww2K+QwoERMqVQg0/LwMDqppqQhA7/CSVnJ7kpdR8D yHMrfsOXtjf6V7wTVVeDDqg1JVGorBZKhdvoEJ6OwGy02pcc4TKSRnhCZRDeR5YdU7nT +J7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=B1+ek0q0jjlVBw6oJoPlssOUueEinSZ/yPE3jdbA81k=; b=Rgk9joRDrpCgbYFd5rR7+cmbM6ehDOFVoOgvnFiv3+xPICbJdLWtkiMYyN/ZwgDMFD bTLyLWYZzd20IZeJUqmskhAl+VN+4PVEUj4dbtkXM8OGMs7CoX4YZxRN5HKsqaK1s7zY gTsW6HWlIn8uZx34OU8afR8e0fpQpcs1Nw6Rq/hp4tqiweqECNxy+mkjE78N2/WYaoaM pNmkQERGHR+v745rYn9/qTO1OvWbuHA48Bdn07HPV+Ubpy+pWL1QfgXY76Ni23FFuTbr Axtec8rFFPOEPlDB4/icSqT4Y2WbGEoQtgRzXyAZPBN7TfBmPWCyyzp1Iq51TsTetYtL MMWQ== X-Gm-Message-State: ACrzQf1vN49dk0A2rVNORHQCvgNWnc6Qd3X7U+nzIL+bBEiC1XW9eP9o 5l5XOAZqoHFaYUXMTYhpZZeMSob+Qga7o7Ksvej2l89HRRrkzw== X-Google-Smtp-Source: AMsMyM6KfsxyD42Apx5jN/YXoHVlXr6c/9aJrvuIPJUUQlxj+bYSxwVZgtHnnpULMWvXuBTNdiniT/Z/HYrN2BriUjw= X-Received: by 2002:a05:6a00:22cf:b0:545:90f3:8b96 with SMTP id f15-20020a056a0022cf00b0054590f38b96mr5452590pfj.58.1663340951337; Fri, 16 Sep 2022 08:09:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Szewczyk Date: Fri, 16 Sep 2022 17:08:59 +0200 Message-ID: Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="0000000000008b7fa505e8ccbee2" --0000000000008b7fa505e8ccbee2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, I always forgot that default answer is "answer" to not "answer to all". My xl dmesg after calling those debug-keys is: > t=3D0 d0: 8(---) > (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0: 9(---) > (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} mapp= ed, > unbound > (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 14(---) > (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-M-) > (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{2}/{0-11} > in-flight=3D1 d0: 17(---),d81: 17(-MM) > (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0: 18(---),d3: 18(-M-) > (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0: 20(---) > (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0: 83(---) > (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} > iommu.c#iommu_page_fault() > (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:951(---) > (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:950(---) > (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:949(---) > (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:948(---) > (XEN) IRQ: 125 vec:4a PCI-MSI status=3D010 aff:{6}/{0-11} > in-flight=3D0 d78:151(---) > (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:946(---) > (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:945(---) > (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:944(---) > (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:943(---) > (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:942(---) > (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0:941(---) > (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0:940(---) > (XEN) IRQ: 133 vec:52 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d81:151(-M-) > (XEN) IRQ: 134 vec:99 PCI-MSI status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:938(---) > (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:936(---) > (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0:935(---) > (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d3:151(---) > (XEN) IRQ: 139 vec:d9 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d3:150(---) > (XEN) Direct vector information: > (XEN) 0x22 -> irq_move_cleanup_interrupt() > (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() > (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() > (XEN) 0xf9 -> pmu_apic_interrupt() > (XEN) 0xfa -> apic_timer_interrupt() > (XEN) 0xfb -> call_function_interrupt() > (XEN) 0xfc -> event_check_interrupt() > (XEN) 0xfd -> invalidate_interrupt() > (XEN) 0xfe -> error_interrupt() > (XEN) 0xff -> spurious_interrupt() > (XEN) IO-APIC interrupt information: > (XEN) IRQ 0 Vec240: > (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 1 Vec 49: > (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000400 > (XEN) IRQ 3 Vec 64: > (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 4 Vec 72: > (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 5 Vec 80: > (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 6 Vec 88: > (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 7 Vec 96: > (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 8 Vec104: > (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 9 Vec 57: > (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 > (XEN) IRQ 10 Vec120: > (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 11 Vec136: > (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 12 Vec144: > (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 13 Vec152: > (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 > (XEN) IRQ 14 Vec160: > (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 15 Vec168: > (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 16 Vec176: > (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 17 Vec208: > (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 > polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 18 Vec184: > (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 > (XEN) IRQ 19 Vec161: > (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 > (XEN) IRQ 20 Vec224: > (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 83 Vec 65: > (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 > (XEN) MSI information: > (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /? > (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D00000= 100 > mask=3D0/ /? > (XEN) MSI 125 vec=3D4a lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D00000= 100 > mask=3D1/ /0 > (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D00000= 400 > mask=3D1/ /0 > (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D00000= 400 > mask=3D1/ /0 > (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D00000= 100 > mask=3D1/ /0 > (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI 133 vec=3D5a lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D00000= 555 > mask=3D0/ /? > (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) MSI 138 vec=3Dd1 lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI 139 vec=3Dd9 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) IRQ information: > (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} > time.c#timer_interrupt() > (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{10}/{0-11} > in-flight=3D0 d0: 1(---) > (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 8(---) > (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0: 9(---) > (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} mapp= ed, > unbound > (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 14(---) > (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-M-) > (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D030 aff:{10}/{0-11} > in-flight=3D1 d0: 17(---),d87: 17(-MM) > (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0: 18(---),d3: 18(-M-) > (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0: 20(---) > (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0: 83(---) > (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} > iommu.c#iommu_page_fault() > (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:951(---) > (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:950(---) > (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:949(---) > (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:948(---) > (XEN) IRQ: 125 vec:4a PCI-MSI status=3D010 aff:{2}/{0-11} > in-flight=3D0 d78:151(---) > (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:946(---) > (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:945(---) > (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0:944(---) > (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0:943(---) > (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:942(---) > (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:941(---) > (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:940(---) > (XEN) IRQ: 133 vec:5a PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d87:151(-M-) > (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{2}/{0-11} > in-flight=3D0 d0:938(---) > (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:936(---) > (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:935(---) > (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d3:151(---) > (XEN) IRQ: 139 vec:d9 PCI-MSI status=3D010 aff:{0}/{0-11} > in-flight=3D0 d3:150(---) > (XEN) Direct vector information: > (XEN) 0x22 -> irq_move_cleanup_interrupt() > (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() > (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() > (XEN) 0xf9 -> pmu_apic_interrupt() > (XEN) 0xfa -> apic_timer_interrupt() > (XEN) 0xfb -> call_function_interrupt() > (XEN) 0xfc -> event_check_interrupt() > (XEN) 0xfd -> invalidate_interrupt() > (XEN) 0xfe -> error_interrupt() > (XEN) 0xff -> spurious_interrupt() > (XEN) IO-APIC interrupt information: > (XEN) IRQ 0 Vec240: > (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 1 Vec 49: > (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000400 > (XEN) IRQ 3 Vec 64: > (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 4 Vec 72: > (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 5 Vec 80: > (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 6 Vec 88: > (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 7 Vec 96: > (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 8 Vec104: > (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 9 Vec 57: > (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 > (XEN) IRQ 10 Vec120: > (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 11 Vec136: > (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 12 Vec144: > (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 13 Vec152: > (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 > (XEN) IRQ 14 Vec160: > (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 15 Vec168: > (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 16 Vec176: > (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 17 Vec208: > (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 > polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 18 Vec184: > (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 > (XEN) IRQ 19 Vec161: > (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 > (XEN) IRQ 20 Vec224: > (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 83 Vec 65: > (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 > (XEN) MSI information: > (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /? > (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D00000= 100 > mask=3D0/ /? > (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D00000= 100 > mask=3D1/ /0 > (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D00000= 100 > mask=3D1/ /0 > (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D00000= 555 > mask=3D0/ /? > (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D00000= 400 > mask=3D0/ /? > (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) IRQ information: > (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} > time.c#timer_interrupt() > (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{6}/{0-11} > in-flight=3D0 d0: 1(---) > (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 8(---) > (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 9(---) > (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} mapp= ed, > unbound > (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 14(---) > (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 16(---),d92: 16(-M-) > (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{8}/{0-11} > in-flight=3D1 d0: 17(---),d94: 17(-MM) > (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 18(---),d92: 18(-M-) > (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0: 20(---) > (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0: 83(---) > (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} > iommu.c#iommu_page_fault() > (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:951(---) > (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:950(---) > (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:949(---) > (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0:948(---) > (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} > in-flight=3D0 d94:151(-M-) > (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:946(---) > (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:945(---) > (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:944(---) > (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:943(---) > (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:942(---) > (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:941(---) > (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:940(---) > (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{0}/{0-11} > in-flight=3D0 d0:938(---) > (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:936(---) > (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0:935(---) > (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d92:151(---) > (XEN) IRQ: 139 vec:6a PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d92:150(---) > (XEN) Direct vector information: > (XEN) 0x22 -> irq_move_cleanup_interrupt() > (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() > (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() > (XEN) 0xf9 -> pmu_apic_interrupt() > (XEN) 0xfa -> apic_timer_interrupt() > (XEN) 0xfb -> call_function_interrupt() > (XEN) 0xfc -> event_check_interrupt() > (XEN) 0xfd -> invalidate_interrupt() > (XEN) 0xfe -> error_interrupt() > (XEN) 0xff -> spurious_interrupt() > (XEN) IO-APIC interrupt information: > (XEN) IRQ 0 Vec240: > (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 1 Vec 49: > (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000040 > (XEN) IRQ 3 Vec 64: > (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 4 Vec 72: > (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 5 Vec 80: > (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 6 Vec 88: > (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 7 Vec 96: > (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 8 Vec104: > (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 9 Vec 57: > (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 10 Vec120: > (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 11 Vec136: > (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 12 Vec144: > (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 13 Vec152: > (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 > (XEN) IRQ 14 Vec160: > (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 15 Vec168: > (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 16 Vec176: > (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 17 Vec208: > (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 > polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000100 > (XEN) IRQ 18 Vec184: > (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 19 Vec161: > (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 > (XEN) IRQ 20 Vec224: > (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 83 Vec 65: > (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 > (XEN) MSI information: > (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /? > (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D00000= 100 > mask=3D0/ /? > (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D00000= 100 > mask=3D1/ /0 > (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D00000= 400 > mask=3D1/ /0 > (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D00000= 100 > mask=3D1/ /0 > (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /0 > (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D00000= 400 > mask=3D0/ /? > (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D00000= 555 > mask=3D0/ /? > (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D00000= 400 > mask=3D0/ /? > (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) IRQ information: > (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} > time.c#timer_interrupt() > (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{6}/{0-11} > in-flight=3D0 d0: 1(---) > (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 8(---) > (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 9(---) > (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} mapp= ed, > unbound > (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 14(---) > (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 16(---),d92: 16(-M-) > (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{8}/{0-11} > in-flight=3D1 d0: 17(---),d94: 17(-MM) > (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 18(---),d92: 18(-M-) > (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0: 20(---) > (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0: 83(---) > (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} > iommu.c#iommu_page_fault() > (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:951(---) > (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:950(---) > (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:949(---) > (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0:948(---) > (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} > in-flight=3D0 d94:151(-M-) > (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:946(---) > (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:945(---) > (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0:944(---) > (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:943(---) > (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:942(---) > (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:941(---) > (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:940(---) > (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{10}/{0-11} > in-flight=3D0 d0:938(---) > (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:936(---) > (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{10}/{0-11} > in-flight=3D0 d0:935(---) > (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d92:151(---) > (XEN) IRQ: 139 vec:6a PCI-MSI status=3D010 aff:{4}/{0-11} > in-flight=3D0 d92:150(---) > (XEN) Direct vector information: > (XEN) 0x22 -> irq_move_cleanup_interrupt() > (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() > (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() > (XEN) 0xf9 -> pmu_apic_interrupt() > (XEN) 0xfa -> apic_timer_interrupt() > (XEN) 0xfb -> call_function_interrupt() > (XEN) 0xfc -> event_check_interrupt() > (XEN) 0xfd -> invalidate_interrupt() > (XEN) 0xfe -> error_interrupt() > (XEN) 0xff -> spurious_interrupt() > (XEN) IO-APIC interrupt information: > (XEN) IRQ 0 Vec240: > (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 1 Vec 49: > (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000040 > (XEN) IRQ 3 Vec 64: > (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 4 Vec 72: > (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 5 Vec 80: > (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 6 Vec 88: > (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 7 Vec 96: > (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 8 Vec104: > (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 9 Vec 57: > (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 10 Vec120: > (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 11 Vec136: > (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 12 Vec144: > (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 13 Vec152: > (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 > (XEN) IRQ 14 Vec160: > (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 15 Vec168: > (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 16 Vec176: > (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 17 Vec208: > (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 > polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000100 > (XEN) IRQ 18 Vec184: > (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 19 Vec161: > (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 > (XEN) IRQ 20 Vec224: > (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 83 Vec 65: > (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 > I shutted down all VMs excluding sys-usb (which I need to be able to use keyboard) and OpenBSD HVM befor that command. My pcidum is: Domain /dev/pci0: > 0:0:0: Intel 82441FX > 0x0000: Vendor ID: 8086, Product ID: 1237 > 0x0004: Command: 0004, Status: 0000 > 0x0008: Class: 06 Bridge, Subclass: 00 Host, > Interface: 00, Revision: 02 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR empty (00000000) > 0x0014: BAR empty (00000000) > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > 0:1:0: Intel 82371SB ISA > 0x0000: Vendor ID: 8086, Product ID: 7000 > 0x0004: Command: 0004, Status: 0200 > 0x0008: Class: 06 Bridge, Subclass: 01 ISA, > Interface: 00, Revision: 00 > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR empty (00000000) > 0x0014: BAR empty (00000000) > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > 0:1:1: Intel 82371SB IDE > 0x0000: Vendor ID: 8086, Product ID: 7010 > 0x0004: Command: 0005, Status: 0280 > 0x0008: Class: 01 Mass Storage, Subclass: 01 IDE, > Interface: 80, Revision: 00 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR empty (00000000) > 0x0014: BAR empty (00000000) > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR io addr: 0x0000c200/0x0010 > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > 0:1:3: Intel 82371AB Power > 0x0000: Vendor ID: 8086, Product ID: 7113 > 0x0004: Command: 0004, Status: 0280 > 0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous, > Interface: 00, Revision: 03 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR empty (00000000) > 0x0014: BAR empty (00000000) > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat: 00 > 0:2:0: XenSource Platform Device > 0x0000: Vendor ID: 5853, Product ID: 0001 > 0x0004: Command: 0007, Status: 0000 > 0x0008: Class: ff (unknown), Subclass: 80 (unknown), > Interface: 00, Revision: 01 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR io addr: 0x0000c000/0x0100 > 0x0014: BAR mem prefetchable 32bit addr: 0xf0000000/0x01000000 > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 5853 Product ID: 0001 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 > 0:3:0: Bochs VGA > 0x0000: Vendor ID: 1234, Product ID: 1111 > 0x0004: Command: 0007, Status: 0000 > 0x0008: Class: 03 Display, Subclass: 00 VGA, > Interface: 00, Revision: 02 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000 > 0x0014: BAR empty (00000000) > 0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000 > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: f2000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 > 0:4:0: Intel 82801DB USB > 0x0000: Vendor ID: 8086, Product ID: 24cd > 0x0004: Command: 0006, Status: 0000 > 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, > Interface: 20, Revision: 10 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000 > 0x0014: BAR empty (00000000) > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00 > 0:6:0: NEC xHCI > 0x0000: Vendor ID: 1033, Product ID: 0194 > 0x0004: Command: 0006, Status: 0010 > 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, > Interface: 30, Revision: 03 > 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR mem 64bit addr: 0x00000000f2010000/0x00004000 > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 > 0x0090: Capability 0x11: Extended Message Signalled Interrupts (MSI-X) > Enabled: no; table size 16 (BAR 0:12288) > 0x0070: Capability 0x05: Message Signalled Interrupts (MSI) > Enabled: yes > 0:7:0: Intel AC 9560 > 0x0000: Vendor ID: 8086, Product ID: a370 > 0x0004: Command: 0006, Status: 0010 > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, > Interface: 00, Revision: 10 > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > Cache Line Size: 00 > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR empty (00000000) > 0x0024: BAR empty (00000000) > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 01 Line: 05 Min Gnt: 00 Max Lat: 00 > 0x00c8: Capability 0x01: Power Management > State: D0 > 0x00d0: Capability 0x05: Message Signalled Interrupts (MSI) > Enabled: no > 0x0040: Capability 0x10: PCI Express > Max Payload Size: 128 / 128 bytes > Max Read Request Size: 512 bytes > BR Adam Szewczyk pt., 16 wrz 2022 o 15:35 Roger Pau Monn=C3=A9 napisa= =C5=82(a): > Again, please keep xen-devel on Cc and don't top-post. > > On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote: > > I executed it in dom0 terminal and it prints lots of stuff, but when I > run > > jus xl dmesg it prints almost the same logs. So I'm not sure if I have > > right output or what I shuld search for to paste it here. > > Hm, you should see something like: > > (XEN) [ 8729.266567] MSI information: > [...] > (XEN) [ 8709.154958] IRQ information: > [...] > > In the output of `xl dmesg` > > You can paste the full output of `xl dmesg`, that should be fine. > > > Regards Adam. > > > > pt., 16 wrz 2022, 15:09 u=C5=BCytkownik Roger Pau Monn=C3=A9 > > > napisa=C5=82: > > > > > Please keep xen-devel in Cc and avoid top-posting. > > > > > > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: > > > > > 0:7:0: Intel AC 9560 > > > > > 0x0000: Vendor ID: 8086, Product ID: a370 > > > > > 0x0004: Command: 0006, Status: 0010 > > > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, > > > > > Interface: 00, Revision: 10 > > > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > > > > Cache Line Size: 00 > > > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 > > > > > 0x0018: BAR empty (00000000) > > > > > 0x001c: BAR empty (00000000) > > > > > 0x0020: BAR empty (00000000) > > > > > 0x0024: BAR empty (00000000) > > > > > 0x0028: Cardbus CIS: 00000000 > > > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 > > > > > 0x0030: Expansion ROM Base Address: 00000000 > > > > > 0x0038: 00000000 > > > > > > None of the BARs are at 0x404000 which seems to be where OpenBSD is > > > trying to load the firmware? > > > > > > I would have to look at the code to figure out exactly what it is > > > trying to do here (and why it fails). > > > > > > Can you also paste the output from `lspci -v`? > > You seem to have missed this bit. > > Regards, Roger. > --0000000000008b7fa505e8ccbee2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, I always forgot that default = answer is "answer" to not "answer to all".
My xl dmesg after calling those debug-keys is:
t=3D0 d0: =C2=A08(---)
(XEN= ) =C2=A0 =C2=A0IRQ: =C2=A0 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{= 4}/{0-11} in-flight=3D0 d0: =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A01= 0 vec:78 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec= :90 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0-15}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a= 0 IO-APIC-level =C2=A0 status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)(XEN) =C2=A0 =C2=A0IRQ: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status= =3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:= b0 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(--= -),d3: 16(-M-),d78: 16(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-A= PIC-level =C2=A0 status=3D010 aff:{2}/{0-11} in-flight=3D1 d0: 17(---),d81:= 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A018 vec:b8 IO-APIC-level =C2=A0 st= atus=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{0-= 15}/{0-11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-AP= IC-level =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
(X= EN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 aff= :{10}/{0-11} in-flight=3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:3= 0 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c#i= ommu_page_fault()
(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)
= (XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{0}/{0-11} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ= : 123 vec:d8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11= } in-flight=3D0 d0:949(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:94= 8(---)
(XEN) =C2=A0 =C2=A0IRQ: 125 vec:4a PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D010 aff:{6}/{0-11} in-flight=3D0 d78:151(---)
(XEN) =C2= =A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{= 8}/{0-11} in-flight=3D0 d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 P= CI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:= 945(---)
(XEN) =C2=A0 =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2= =A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 = =C2=A0IRQ: 129 vec:71 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{= 0-11} in-flight=3D0 d0:943(---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-M= SI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(= ---)
(XEN) =C2=A0 =C2=A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0s= tatus=3D030 aff:{10}/{0-11} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2= =A0IRQ: 132 vec:89 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{2}/{0-1= 1} in-flight=3D0 d0:940(---)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:52 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d81:1= 51(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2= =A0 =C2=A0IRQ: 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 = aff:{0-15}/{0-11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI= -MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 = d0:936(---)
(XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2= =A0 =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:935(---)
(XEN) = =C2=A0 =C2=A0IRQ: 138 vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D0= 30 aff:{2}/{0-11} in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 = vec:d9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-f= light=3D0 d3:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 = =C2=A00x22 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -&= gt; mce_intel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel= .c#intel_thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_inte= rrupt()
(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) = =C2=A0 =C2=A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xf= c -> event_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate= _interrupt()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) = =C2=A0 =C2=A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt inf= ormation:
(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0= =C2=A0 Apic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A01 Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A01: vec=3D31 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec= 64:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_i= d:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A05: vec=3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec= 88:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_i= d:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A08: vec=3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec= 57:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_i= d:00000010
(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2= =A0 Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polari= ty=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IR= Q 11 Vec136:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 13 Vec152:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 = dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 15 Vec168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec= =3Da8 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2= =A0 =C2=A0 =C2=A0 Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL sta= tus=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 17 Vec208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 7: vec=3Dd0 delivery=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig= =3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400
= (XEN) =C2=A0 =C2=A0 IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0= trig=3DL mask=3D1 dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000400
(XEN) MSI information:
(XEN) = =C2=A0IOMMU =C2=A0120 vec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000001 mask=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121= vec=3Dc0 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0124 vec=3De8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000100 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D4= a lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0= assert =C2=A0log lowest dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0= MSI-X =C2=A0127 vec=3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest d= est=3D00000010 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 l= owest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000400 mask=3D1/ = =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 a= ssert =C2=A0log lowest dest=3D00000400 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MS= I-X =C2=A0130 vec=3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 low= est =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D1/ =C2= =A0/0
(XEN) =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 asse= rt =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI = =C2=A0 =C2=A0133 vec=3D5a lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest = dest=3D00000004 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0134 vec= =3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask= =3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2=A0ed= ge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?
(XE= N) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert =C2= =A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 = =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3Dd1 lo= west =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0/ = =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3Dd9 lowest =C2=A0edge =C2= =A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) IRQ= information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge =C2= =A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2=A0= =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{10}= /{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 3 = vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0status= =3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec:= 50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(X= EN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D00= 2 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 IO= -APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-= M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D1 d0: 17(---),d87: 17(-MM)
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{= 0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2= =A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, un= bound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 statu= s=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ:= =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 sta= tus=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IR= Q: 122 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-1= 1} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:94= 9(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2= =A0 =C2=A0IRQ: 125 vec:4a PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 = aff:{2}/{0-11} in-flight=3D0 d78:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 126 ve= c:59 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN)= =C2=A0 =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{10}/{0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec= :71 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{10}/{0-11} in-flight= =3D0 d0:943(---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN)= =C2=A0 =C2=A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{8}/{0-11} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:= 89 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0= d0:940(---)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:5a PCI-MSI =C2=A0 =C2=A0 = =C2=A0 =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d87:151(-M-)
(XE= N) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D010 aff:{2}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: = 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-1= 1} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
= (XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ= : 138 vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{2}/{0-11= } in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:d9 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{0}/{0-11} in-flight=3D0 d3:15= 0(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 ->= irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c#= cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_thermal= _interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN)= =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb = -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_chec= k_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(X= EN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -&= gt; spurious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 = Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D31 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 = Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 = Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010
(XEN) = =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 0: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0= trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec16= 8:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Ve= c208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delivery=3D= LoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ = 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_= id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 = dest_id:00000100
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 v= ec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 ma= sk=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc0 lowest =C2=A0= edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(= XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3De= 8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D72 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec= =3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec= =3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI =C2=A0 =C2=A0134= vec=3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000400 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3D6= 2 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3D6a lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) = IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge = =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{= 6}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec= :50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d92: 16(-M-)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status=3D010 aff:{8= }/{0-11} in-flight=3D1 d0: 17(---),d94: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight= =3D0 d0: 18(---),d92: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO= -APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 83(--= -)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 = =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:= {0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 = PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight= =3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
= (XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{2}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ= : 125 vec:72 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11= } in-flight=3D0 d94:151(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/= -X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:946(---= )
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ= : 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-= flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X =C2= =A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:943(---)
(= XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D0= 30 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: 131 = vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight= =3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:89 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:940(---)
(XEN)= =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D= 010 aff:{0}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: 135= vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-11} = mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2=A0= =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
(XE= N) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ:= 138 vec:62 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11}= in-flight=3D0 d92:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:6a PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d92:1= 50(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 ->= ; irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c= #cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_therma= l_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN= ) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb= -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_che= ck_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(= XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -= > spurious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 = Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D31 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000040
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 = Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 = Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 0: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0= trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec16= 8:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Ve= c208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delivery=3D= LoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00= 000100
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ = 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_= id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 = dest_id:00000400
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 v= ec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 ma= sk=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc0 lowest =C2=A0= edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(= XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3De= 8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D72 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec= =3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000400 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec= =3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI =C2=A0 =C2=A0134= vec=3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000400 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000400 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3D6= 2 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3D6a lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) = IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge = =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{= 6}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec= :50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d92: 16(-M-)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status=3D010 aff:{8= }/{0-11} in-flight=3D1 d0: 17(---),d94: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight= =3D0 d0: 18(---),d92: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO= -APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 83(--= -)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 = =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:= {0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 = PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight= =3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
= (XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{2}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ= : 125 vec:72 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11= } in-flight=3D0 d94:151(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/= -X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:946(---= )
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ= : 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{10}/{0-11} in= -flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X = =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:943(---)(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status= =3D030 aff:{0}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: = 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-fl= ight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:89 PCI-MSI/-X =C2= =A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:940(---)
(= XEN) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 statu= s=3D010 aff:{10}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ= : 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0= -11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)<= br>(XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 s= tatus=3D030 aff:{10}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2= =A0IRQ: 138 vec:62 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d92:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:6a PC= I-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{4}/{0-11} in-flight=3D0= d92:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x2= 2 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_i= ntel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_= thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2= =A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> ev= ent_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt= ()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2= =A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt information:<= br>(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Ap= ic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarit= y=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ= =C2=A01 Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec= =3D31 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000040
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic= 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec= =3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic= 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec= =3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00= , Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:<= br>(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri = dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001=
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0= x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec15= 2:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Ve= c168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ = 17 Vec208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delive= ry=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_= id:00000100
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0= IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 = dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec= =3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL ma= sk=3D0 dest_id:00000400

I shutted dow= n all VMs excluding sys-usb (which I need to be able to use keyboard) and O= penBSD HVM befor that command.

My pcidum is:
=

Domai= n /dev/pci0:
=C2=A00:0:0: Intel 82441FX
0x0000: Vendor ID: 8086, Pro= duct ID: 1237
0x0004: Command: 0004, Status: 0000
0x0008: Class: 06= Bridge, Subclass: 00 Host,
Interface: 00, Revision: 02
0x000c: BI= ST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x= 0010: BAR empty (00000000)
0x0014: BAR empty (00000000)
0x0018: BAR= empty (00000000)
0x001c: BAR empty (00000000)
0x0020: BAR empty (0= 0000000)
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000=
0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansi= on ROM Base Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pi= n: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2=A00:1:0: Intel 82371SB ISA 0x0000: Vendor ID: 8086, Product ID: 7000
0x0004: Command: 0004, Stat= us: 0200
0x0008: Class: 06 Bridge, Subclass: 01 ISA,
Interface: 00= , Revision: 00
0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, Cache Line Size: 00
0x0010: BAR empty (00000000)
0x0014: BAR emp= ty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR empty (00000= 000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (00000000)
= 0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: 1af4 Product= ID: 1100
0x0030: Expansion ROM Base Address: 00000000
0x0038: 0000= 0000
0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2= =A00:1:1: Intel 82371SB IDE
0x0000: Vendor ID: 8086, Product ID: 7010 0x0004: Command: 0005, Status: 0280
0x0008: Class: 01 Mass Storage, = Subclass: 01 IDE,
Interface: 80, Revision: 00
0x000c: BIST: 00, He= ader Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x0010: BAR = empty (00000000)
0x0014: BAR empty (00000000)
0x0018: BAR empty (00= 000000)
0x001c: BAR empty (00000000)
0x0020: BAR io addr: 0x0000c20= 0/0x0010
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000=
0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansi= on ROM Base Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pi= n: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2=A00:1:3: Intel 82371AB Power<= br> 0x0000: Vendor ID: 8086, Product ID: 7113
0x0004: Command: 0004, St= atus: 0280
0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous,
I= nterface: 00, Revision: 03
0x000c: BIST: 00, Header Type: 00, Latency T= imer: 00,
Cache Line Size: 00
0x0010: BAR empty (00000000)
0x0= 014: BAR empty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR = empty (00000000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (00= 000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: = 1af4 Product ID: 1100
0x0030: Expansion ROM Base Address: 00000000
= 0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat= : 00
=C2=A00:2:0: XenSource Platform Device
0x0000: Vendor ID: 5853,= Product ID: 0001
0x0004: Command: 0007, Status: 0000
0x0008: Class= : ff (unknown), Subclass: 80 (unknown),
Interface: 00, Revision: 01 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Siz= e: 00
0x0010: BAR io addr: 0x0000c000/0x0100
0x0014: BAR mem prefet= chable 32bit addr: 0xf0000000/0x01000000
0x0018: BAR empty (00000000) 0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x0024= : BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsys= tem Vendor ID: 5853 Product ID: 0001
0x0030: Expansion ROM Base Address= : 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0b Min = Gnt: 00 Max Lat: 00
=C2=A00:3:0: Bochs VGA
0x0000: Vendor ID: 1234, = Product ID: 1111
0x0004: Command: 0007, Status: 0000
0x0008: Class:= 03 Display, Subclass: 00 VGA,
Interface: 00, Revision: 02
0x000c:= BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Size: 00
= 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000
0x0014:= BAR empty (00000000)
0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000=
0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x00= 24: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subs= ystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansion ROM Base Addre= ss: f2000000
0x0038: 00000000
0x003c: Interrupt Pin: 00 Line: 00 Mi= n Gnt: 00 Max Lat: 00
=C2=A00:4:0: Intel 82801DB USB
0x0000: Vendor = ID: 8086, Product ID: 24cd
0x0004: Command: 0006, Status: 0000
0x00= 08: Class: 0c Serial Bus, Subclass: 03 USB,
Interface: 20, Revision: 1= 0
0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line= Size: 00
0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000
0x0014:= BAR empty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR empt= y (00000000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (000000= 00)
0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: 1af4= Product ID: 1100
0x0030: Expansion ROM Base Address: 00000000
0x00= 38: 00000000
0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00=
=C2=A00:6:0: NEC xHCI
0x0000: Vendor ID: 1033, Product ID: 0194
= 0x0004: Command: 0006, Status: 0010
0x0008: Class: 0c Serial Bus, Subc= lass: 03 USB,
Interface: 30, Revision: 03
0x000c: BIST: 00, Header= Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x0010: BAR mem = 64bit addr: 0x00000000f2010000/0x00004000
0x0018: BAR empty (00000000)<= br> 0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x002= 4: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsy= stem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansion ROM Base Addres= s: 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0b Min= Gnt: 00 Max Lat: 00
0x0090: Capability 0x11: Extended Message Signalle= d Interrupts (MSI-X)
Enabled: no; table size 16 (BAR 0:12288)
0x00= 70: Capability 0x05: Message Signalled Interrupts (MSI)
Enabled: yes=C2=A00:7:0: Intel AC 9560
0x0000: Vendor ID: 8086, Product ID: a370<= br> 0x0004: Command: 0006, Status: 0010
0x0008: Class: 02 Network, Subc= lass: 80 Miscellaneous,
Interface: 00, Revision: 10
0x000c: BIST: = 00, Header Type: 80, Latency Timer: 00,
Cache Line Size: 00
0x0010= : BAR mem 64bit addr: 0x00000000f2014000/0x00004000
0x0018: BAR empty (= 00000000)
0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)=
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x0= 02c: Subsystem Vendor ID: 8086 Product ID: 0034
0x0030: Expansion ROM B= ase Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Li= ne: 05 Min Gnt: 00 Max Lat: 00
0x00c8: Capability 0x01: Power Managemen= t
State: D0
0x00d0: Capability 0x05: Message Signalled Interrupts = (MSI)
Enabled: no
0x0040: Capability 0x10: PCI Express
Max Pa= yload Size: 128 / 128 bytes
Max Read Request Size: 512 bytes

BR Adam Szewczyk


pt.,= 16 wrz 2022 o 15:35=C2=A0Roger Pau Monn=C3=A9 <roger.pau@citrix.com> napisa=C5=82(a):
Again, please keep xen-devel = on Cc and don't top-post.

On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote:
> I executed it in dom0 terminal and it prints lots of stuff, but when I= run
> jus xl dmesg it prints almost the same logs. So I'm not sure if I = have
> right output or what I shuld search for to paste it here.

Hm, you should see something like:

(XEN) [ 8729.266567] MSI information:
[...]
(XEN) [ 8709.154958] IRQ information:
[...]

In the output of `xl dmesg`

You can paste the full output of `xl dmesg`, that should be fine.

> Regards Adam.
>
> pt., 16 wrz 2022, 15:09 u=C5=BCytkownik Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> napisa=C5=82:
>
> > Please keep xen-devel in Cc and avoid top-posting.
> >
> > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: > > > >=C2=A0 0:7:0: Intel AC 9560
> > > > 0x0000: Vendor ID: 8086, Product ID: a370
> > > > 0x0004: Command: 0006, Status: 0010
> > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous,<= br> > > > > Interface: 00, Revision: 10
> > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > > > Cache Line Size: 00
> > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x000040= 00
> > > > 0x0018: BAR empty (00000000)
> > > > 0x001c: BAR empty (00000000)
> > > > 0x0020: BAR empty (00000000)
> > > > 0x0024: BAR empty (00000000)
> > > > 0x0028: Cardbus CIS: 00000000
> > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034
> > > > 0x0030: Expansion ROM Base Address: 00000000
> > > > 0x0038: 00000000
> >
> > None of the BARs are at 0x404000 which seems to be where OpenBSD = is
> > trying to load the firmware?
> >
> > I would have to look at the code to figure out exactly what it is=
> > trying to do here (and why it fails).
> >
> > Can you also paste the output from `lspci -v`?

You seem to have missed this bit.

Regards, Roger.
--0000000000008b7fa505e8ccbee2-- From xen-devel-bounces@lists.xenproject.org Fri Sep 16 15:32:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 15:32:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408054.650753 (Exim 4.92) (envelope-from ) id 1oZDKH-0006j0-6I; Fri, 16 Sep 2022 15:32:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408054.650753; Fri, 16 Sep 2022 15:32:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDKH-0006it-2z; Fri, 16 Sep 2022 15:32:21 +0000 Received: by outflank-mailman (input) for mailman id 408054; Fri, 16 Sep 2022 15:32:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDKF-0006ij-B8; Fri, 16 Sep 2022 15:32:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDKF-0000Wz-63; Fri, 16 Sep 2022 15:32:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDKE-0005EJ-J4; Fri, 16 Sep 2022 15:32:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZDKE-0004cl-Ic; Fri, 16 Sep 2022 15:32:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6fcnB5bEq/ud7hOKA2fL77KyfrEdbUPyPLn3BouNERs=; b=lHHpdYEJ2U0+zFSy4Rj3enKKiA MqrWySthvdw8NfnM/VFY05c0ok/KgU4gyJ64Xq5lNetrvOPlwQJVET8GUXIxc1XyVBZoAaAQ18BPD Wpt2Kr/mHOj4JcyXuThPV71mXCWw8N4zZXpoEeiR3Z42SKYQZrNwA1H137qaoYlfbZtc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173230: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Fri, 16 Sep 2022 15:32:18 +0000 flight 173230 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173230/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173219 pass in 173209 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173200 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 173219 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173219 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173200 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173200 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 43 days Failing since 172148 2022-08-04 21:39:38 Z 42 days 97 attempts Testing same since 173060 2022-09-08 07:34:59 Z 8 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 16:05:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 16:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408070.650763 (Exim 4.92) (envelope-from ) id 1oZDqW-0002Fr-P3; Fri, 16 Sep 2022 16:05:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408070.650763; Fri, 16 Sep 2022 16:05:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDqW-0002Fk-MR; Fri, 16 Sep 2022 16:05:40 +0000 Received: by outflank-mailman (input) for mailman id 408070; Fri, 16 Sep 2022 16:05:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDqU-0002Fe-I2 for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 16:05:38 +0000 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [2607:f8b0:4864:20::732]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 666bfe1c-35d9-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 18:05:36 +0200 (CEST) Received: by mail-qk1-x732.google.com with SMTP id g2so13217995qkk.1 for ; Fri, 16 Sep 2022 09:05:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 666bfe1c-35d9-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=gZJ0a6soAAQl4WWq651NOmdveJSbVmqt656874p+6qo=; b=TN25tjscCy7e3pHsHGj60SkUD13onWmohKyCwTpUhkWfO00QSShO0OdkDPIaej19HA btWUwoxzS83B8eUXlsS6V9Tiz8XvUfGEF6a3sBc5KEMKrCY5MAb+SJBCdjjSc4CPLZyw vXQFOCQkrKslXe/ft552744hcU2IPwbcJoXVf9XIEtHEWMhsptU8ZvNa8mmvGI/1FR5K y0jCmLxmTLmXMu7AALgChECufOhInEZP4caSI0BRCr9/p3PuHehF1e3e4iX9GMHhUCcV afHLBGfqJpD2za93B+6Dp2bfq1R0jPXixoKc9+LNr+uTlvR9RRH6TGDtC8VrkO/nJFdc Wvww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=gZJ0a6soAAQl4WWq651NOmdveJSbVmqt656874p+6qo=; b=lbKTCuuX4KqxyRmErKGB1/aGmrGLCzh6am13Jufq3eT8c0t4Ge7GhPVaRXhxilvwWi 8eE6X4Sy7vx4jQhXCPpOPFfFAUv5gOwaYB8PdBQBZ2qQbm5MSxRhfGvSs4qVD2JehvXi 5kLnrZ33GE+eF0KJivCz5WpsKgVbX+j2Pob1AcwXb9XqdGoNifMd3XZTrepNjGDYa1gC P8fJ3sc8utnx8qDVJVQp08Wq8ziNOvc7CisytEc194HnV5TH+KU35R4qaXPpek9+bL/Q Rrx4adac1ZY2yVS2XaWXj/D2h2nikDtUquU4+KpFbdcc1+bZ5lEivO1LCxfLwB1TPUWo NeEQ== X-Gm-Message-State: ACrzQf0TBXQ5aOTiVe2S0FVfadEUqc5Cc23B0E0h99+B0BJOWtXxECo6 ceMk5lx+VshatjnuBnSzHINlKBmjESoShFf3VN01Ug== X-Google-Smtp-Source: AMsMyM47cUAiNOd6dwEXCpW6EuGHrM/i55GTPre7Dvdrg3pblF3pipQgpY/NLEioYk7FnpMY00sGXnS6K6oPbKMBDmI= X-Received: by 2002:a05:620a:957:b0:6cd:ed32:ed2e with SMTP id w23-20020a05620a095700b006cded32ed2emr4552565qkw.48.1663344335163; Fri, 16 Sep 2022 09:05:35 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-7-carlo.nonato@minervasys.tech> <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com> In-Reply-To: <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com> From: Carlo Nonato Date: Fri, 16 Sep 2022 18:05:24 +0200 Message-ID: Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for domains To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Jan, On Thu, Sep 15, 2022 at 3:13 PM Jan Beulich wrote: > > On 26.08.2022 14:51, Carlo Nonato wrote: > > This commit adds a new memory page allocator that implements the cache > > coloring mechanism. The allocation algorithm follows the given color > > configuration of the domain and maximizes contiguity in the page selection. > > > > Pages are stored in a color-indexed data structure of lists, sorted by their > > machine addresses, that are collectively called the colored heap. A simple > > initialization function computes the color of any available page and inserts > > it in the corresponding list. When a domain requests a page, the allocator > > takes one from the subset of lists whose colors equals the domain > > configuration. It chooses the page with the highest machine address such that > > contiguous pages are sequentially allocated, if this is made possible by a > > color assignment which includes adjacent colors. > > > > The allocator can handle only requests with order equals to 0 since the > > single color granularity is represented in memory by one page. > > In the earlier paragraph you talk about contiguous pages using contiguous > colors. This paragraph then appears to say the opposite, i.e. that > contiguous multi-page allocations aren't possible. Which of the two is it? Here there's a little confusion, you're right. Probably it's better explained in the documentation that comes with this very patch: with a contiguous colors assignment, we *could* allocate contiguous pages using the "order" parameter greater than 0, but as a first implementation we simply decided not to care for such cases and force the order-0 pages only. However if two order-0 pages are requested subsequently, the allocator tries to allocate them using different colors so that the cache is used more efficiently and this is what I meant with "maximizes contiguity". > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -147,6 +147,18 @@ config MAX_CACHE_COLORS > > colors at boot. Note that if, at any time, a color configuration with more > > colors than the maximum will be employed an error will be produced. > > > > +config BUDDY_ALLOCATOR_SIZE > > + string "Buddy allocator reserved memory size" if CACHE_COLORING > > + default "64M" if CACHE_COLORING > > + default "0M" if !CACHE_COLORING > > I don't understand the purpose of this last line, nor the two earlier > "if". Why not simply > > config BUDDY_ALLOCATOR_SIZE > string "Buddy allocator reserved memory size" > depend on CACHE_COLORING > default "64M" This was just to have a value for the config option even with cache coloring disabled. All those ifs emulate the "depends on" keyword, but let the CONFIG_BUDDY_ALLOCATOR_SIZE takes "0M" when coloring is disabled. With just the "depends on" the macro isn't defined at all. I know that this can be handled with some simple #ifdef, but I found this way to be more elegant. Not an expert here so if you prefer the other way or a whole different one (more readable/better fitted) please let me know. > ? Also does this really need to be a string, rather than a number (which > then doesn't need parsing) with e.g. MiB granularity? Yeah it's easier like you said. I don't think there's a need for a < 1 MiB value. > Finally - how much of this is really Arm-specific? Shouldn't this be a > common config option, perhaps merely restricted to Arm by the top level > option (CACHE_COLORING?) depending on a further HAS_CACHE_COLORING, > which only Arm would select? I'm sorry, but I don't understand your suggestion. BUDDY_ALLOCATOR_SIZE is Arm specific because CACHE_COLORING is. In fact it depends only on this last config value and not on Arm config directly. Why should someone limit the buddy allocator when coloring isn't enabled? I've lost you on the HAS_CACHE_COLORING. Why should Arm config select this one? Cache coloring must remain optional. I'm probably missing something. > > --- a/xen/arch/arm/coloring.c > > +++ b/xen/arch/arm/coloring.c > > @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config, > > config->num_colors = (uint16_t)num; > > } > > > > +unsigned int page_to_color(struct page_info *pg) > > The parameter will want to be pointer-to-const and I wonder whether ... > > > +{ > > + return addr_to_color(page_to_maddr(pg)); > > +} > > ... the function as a whole wouldn't be a good candidate for being an > inline one (requiring addr_to_color() to be available in outside of > this file, of course). You mean defining it as static inline in the coloring.h header? > > --- a/xen/arch/arm/include/asm/mm.h > > +++ b/xen/arch/arm/include/asm/mm.h > > @@ -143,6 +143,9 @@ struct page_info > > #define PGC_count_width PG_shift(10) > > #define PGC_count_mask ((1UL< > > > +#define _PGC_colored PG_shift(11) > > +#define PGC_colored PG_mask(1, 11) > > I don't think this can work - you can't use bits already covered by > the count. You'll need to shift up PGC_count_{width,mask} by one and > insert your bit between PGC_extra and that. Or you could use one of > the lower unused ones, between PGC_static and PGC_broken. Yes you're right. I misinterpreted those values. Shame on me. > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -150,6 +150,9 @@ > > #define p2m_pod_offline_or_broken_hit(pg) 0 > > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) > > #endif > > +#ifdef CONFIG_CACHE_COLORING > > +#include > > +#endif > > > > #ifndef PGC_static > > #define PGC_static 0 > > @@ -231,6 +234,9 @@ static bool __read_mostly scrub_debug; > > #define scrub_debug false > > #endif > > > > +/* Memory required for buddy allocator to work with colored one */ > > +static unsigned long __initdata buddy_alloc_size; > > + > > /* > > * Bit width of the DMA heap -- used to override NUMA-node-first. > > * allocation strategy, which can otherwise exhaust low memory. > > @@ -440,7 +446,172 @@ mfn_t __init alloc_boot_pages(unsigned long nr_pfns, unsigned long pfn_align) > > BUG(); > > } > > > > +static DEFINE_SPINLOCK(heap_lock); > > > > +/* Initialise fields which have other uses for free pages. */ > > +static void init_free_page_fields(struct page_info *pg) > > +{ > > + pg->u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER; > > + page_set_owner(pg, NULL); > > +} > > + > > +static bool is_page_colored(struct page_info *pg) > > +{ > > + return pg->count_info & PGC_colored; > > +} > > + > > +#ifdef CONFIG_CACHE_COLORING > > +/************************* > > + * COLORED SIDE-ALLOCATOR > > + * > > + * Pages are stored by their color in separate lists. Each list defines a color > > + * and it is initialized during end_boot_allocator, where each page's color > > + * is calculated and the page itself is put in the correct list. > > + * After initialization there will be N lists where N is the number of maximum > > + * available colors on the platform. > > + */ > > Nit: Perhaps either "maximum number of colors" or "number of available > colors"? > > > +typedef struct page_list_head colored_pages_t; > > +static colored_pages_t __ro_after_init *color_heap; > > Please place the attribute at its canonical slot: > > static colored_pages_t *__ro_after_init color_heap; > > It applies to the variable, not to the pointed-to type. > > > +#define colored_pages(color) &color_heap[(color)] > > The parentheses want to move: > > #define colored_pages(color) (&color_heap[color]) > > > +static void color_heap_insert_page(struct page_info *pg) > > +{ > > + struct page_info *pos; > > + struct page_list_head *head = colored_pages(page_to_color(pg)); > > + > > + pg->count_info |= PGC_colored; > > The function isn't marked __init, so runtime correctness as to the > (non-atomic) update here wants clarifying. Yes. I need to check and probably add a spin lock for the color heap. > > + /* Insert page in list in ascending machine address order */ > > Isn't is descending order that you actually use, also seeing that > you take the first page of a list when allocating (further down)? Yes you're right. Forgot to change the comment. > > + page_list_for_each( pos, head ) > > + { > > + if ( page_to_maddr(pos) < page_to_maddr(pg) ) > > + { > > + head = &pos->list; > > + break; > > + } > > + } > > Wait - a linear search for every single page insertion? How well > is that going to perform on a multi-terabyte system? For our test cases (embedded systems) the linear search is good enough. I agree with you that in the general case this is bad (even though the main targets are indeed embedded systems). Are there any already available data structures that we can exploit to get better performances? > > + page_list_add_tail(pg, head); > > page_list_head and page_list_entry are generally different things, > so I'm afraid this isn't correct in the common case, and you're > getting away with it only because only Arm currently enables this > code. So how to insert in the middle of the list? > > > +} > > + > > +static void color_heap_remove_page(struct page_info *pg) > > +{ > > + page_list_del(pg, colored_pages(page_to_color(pg))); > > +} > > + > > +static void __init init_col_heap_pages(struct page_info *pg, > > + unsigned long nr_pages) > > +{ > > + unsigned int i; > > + > > + if ( !color_heap ) > > + { > > + unsigned int max_colors = get_max_colors(); > > + color_heap = xmalloc_array(colored_pages_t, max_colors); > > Nit: Please always have a blank line between declaration(s) and > statement(s). > > > + BUG_ON(!color_heap); > > + > > + for ( i = 0; i < max_colors; i++ ) > > + INIT_PAGE_LIST_HEAD(colored_pages(i)); > > + > > + if ( !buddy_alloc_size ) > > + buddy_alloc_size = parse_size_and_unit(CONFIG_BUDDY_ALLOCATOR_SIZE, > > + NULL); > > + } > > + > > + printk(XENLOG_INFO "Init color heap with %lu pages\n", nr_pages); > > + printk(XENLOG_INFO "Paging starting from: 0x%"PRIx64"\n", > > + page_to_maddr(pg)); > > "Paging"? And please prefer %# over 0x% for hex formatting, as we do > elsewhere. > > > + for ( i = 0; i < nr_pages; i++ ) > > + color_heap_insert_page(pg++); > > +} > > + > > +/* Alloc one page based on domain color configuration */ > > +static struct page_info *alloc_col_heap_page(unsigned int memflags, > > + const unsigned int *colors, > > + unsigned int num_colors) > > Array instead of pointer notation would better reflect the purpose. > > > +{ > > + struct page_info *pg = NULL; > > + unsigned int i; > > + bool need_tlbflush = false; > > + uint32_t tlbflush_timestamp = 0; > > + > > + spin_lock(&heap_lock); > > + > > + for ( i = 0; i < num_colors; i++ ) > > + { > > + struct page_info *tmp; > > + > > + if ( page_list_empty(colored_pages(colors[i])) ) > > + continue; > > + > > + tmp = page_list_first(colored_pages(colors[i])); > > + if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) ) > > + pg = tmp; > > + } > > + > > + if ( !pg ) > > + { > > + spin_unlock(&heap_lock); > > + return NULL; > > + } > > + > > + pg->count_info = PGC_state_inuse; > > Aren't you losing PGC_colored here? Right. Pretty nasty bug you found. > > +static struct page_info *alloc_col_domheap_page(struct domain *d, > > + unsigned int memflags) > > +{ > > + struct page_info *pg; > > + > > + ASSERT(!in_irq()); > > ASSERT_ALLOC_CONTEXT()? Albeit that's redundant then with the sole caller. > > > +#else > > +static void free_col_domheap_page(struct page_info *pg) > > +{ > > + return; > > +} > > No need for "return" here. > > > @@ -1939,11 +2107,24 @@ void __init end_boot_allocator(void) > > break; > > } > > } > > - for ( i = nr_bootmem_regions; i-- > 0; ) > > + > > + for ( i = 0; i < nr_bootmem_regions; i++ ) > > I'm afraid you can't simply go and invert the direction this loop works > without any justification. It's not even clear why you need to work > forwards in the colored case. The order was inverted because I'm assuming bootmem regions are stored in ascending order (this should be the case looking at bootmem_region_add(). Am I wrong?) and (second assumption) pages taken from each memory region are sorted in ascending order relatively to their machine address. This means that color_heap_insert_page() is called (at least during end_boot_allocator()) with always increasing machine addresses and so the linear search should be O(1). > Jan Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Fri Sep 16 16:07:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 16:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408080.650774 (Exim 4.92) (envelope-from ) id 1oZDsF-0002uG-9S; Fri, 16 Sep 2022 16:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408080.650774; Fri, 16 Sep 2022 16:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDsF-0002u9-6s; Fri, 16 Sep 2022 16:07:27 +0000 Received: by outflank-mailman (input) for mailman id 408080; Fri, 16 Sep 2022 16:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZDsE-0002u3-F9 for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 16:07:26 +0000 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [2607:f8b0:4864:20::f33]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6effc5d-35d9-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 18:07:24 +0200 (CEST) Received: by mail-qv1-xf33.google.com with SMTP id z9so5501163qvn.9 for ; Fri, 16 Sep 2022 09:07:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6effc5d-35d9-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=tLur3LQQNH99RcHI26JTcESnrDemBht0MgeTi6Y96vQ=; b=Oa5Feg4Q4/IG4bZWEdBQ1/eIelFz+L7TjTKWp7esOiuZedHNtPy8b53HovGrX5aK2Q 8bARaLnxj5JEGTl6GJQEzJ6yYwvuRbONVBuLYk7GKNvQ74vzYu+jpZ2MqeFfz6nTGj/e 5AJUW5fDlcZ0ckrigrszVz0rCUligNUpnzb5NBBUVf6GDrjKCBhU5jx7iJVkM6W3DboN v+d22bDqu83KbidqT5QTgE9eKrCxgH/DkDqvvIt06NpFCiOr7+8QM8+J1uGBJ1kRbhxE GQgmfmTRvgyGabXigCI8bIdprzPWxgevxLcpxhzdhOo2Isf00pjJIPVXg6GtyeyPRlz3 Wn4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=tLur3LQQNH99RcHI26JTcESnrDemBht0MgeTi6Y96vQ=; b=IgrlzKjiaFwq67Q9IIE/4n8d30bniFmjaiG0ZKvl6j/0QhOiDf2fs1uJ6NhdfaCL4Y vaHoelhvxujgV/1MCk3pB0lPmJewiF0ny6kxgeZpTP2Ex6Ta059vvq3hvyhkviKv6h2p /dHEGMPG/vxYuIflhJnubj70Doz+PkwTj/BNJtqh+pyNBzNC7beaP0YxpLit8As7xpc0 uaMvrsZmYIRvi3HZURXFy6sdQOifqHRx+kl29aPcgskAt76IBcfIFclHg84eHQgOeMoS xMUXhFKr0LSxSshqkcxUJt3LI0XEWgc8TooL8RZTImaQYVpCmOzaMJt9iZ4MYpc75pk5 dSsQ== X-Gm-Message-State: ACrzQf0yGvBiKqvQlpIsAVLqalCiEkpfuWzRewjkmQ4TivJ5GpQan64L G4UTHI/flXFU+b/R63PgKW5l6jEPE/BZOkPEP00cYA== X-Google-Smtp-Source: AMsMyM4C8iBFx6mzhXCDt0m1+AVoWx+oxSSR5u+kHKS4QTDcTRvF5UYaRwuCtVSQ+O8JpYTGFY6GwHOA/uYiHL4k1pU= X-Received: by 2002:ad4:5bac:0:b0:4ac:929b:3363 with SMTP id 12-20020ad45bac000000b004ac929b3363mr4643672qvq.32.1663344443813; Fri, 16 Sep 2022 09:07:23 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> <93471d92-bc61-56fd-5b52-413303d35da1@suse.com> In-Reply-To: <93471d92-bc61-56fd-5b52-413303d35da1@suse.com> From: Carlo Nonato Date: Fri, 16 Sep 2022 18:07:13 +0200 Message-ID: Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen To: Jan Beulich , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Jan, On Thu, Sep 15, 2022 at 3:25 PM Jan Beulich wrote: > > On 26.08.2022 14:51, Carlo Nonato wrote: > > --- a/xen/common/vmap.c > > +++ b/xen/common/vmap.c > > @@ -8,6 +8,9 @@ > > #include > > #include > > #include > > +#ifdef CONFIG_CACHE_COLORING > > +#include > > +#endif > > Even independent of my earlier question towards more code becoming common, > I think there will want to be a xen/coloring.h which takes care of this > abstraction, requiring such #ifdef in just a single place. > > > @@ -218,6 +221,28 @@ void *__vmap(const mfn_t *mfn, unsigned int granularity, > > return va; > > } > > > > +#ifdef CONFIG_CACHE_COLORING > > +void * __vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, > > + unsigned int flags, enum vmap_region type) > > Please no new functions with double underscores as prefix. Only static > symbol names may start with an underscore, and then also only with a > single one. > > > +{ > > + void *va = vm_alloc(nr, align, type); > > + unsigned long cur = (unsigned long)va; > > + paddr_t pa = mfn_to_maddr(*mfn); > > + > > + for ( ; va && nr-- ; cur += PAGE_SIZE ) > > + { > > + pa = next_xen_colored(pa); > > This may alter the address, yet the caller expects that the original > address be mapped. I must be missing something? If the original address color is assigned to Xen, then next_xen_colored() simply returns that address. If this isn't the case, then you're right: the address changes to the correct, colored, one. The caller should expect this behavior since this is the colored version of vmap, the one that takes into account the Xen coloring configuration. > > + if ( map_pages_to_xen(cur, maddr_to_mfn(pa), 1, flags) ) > > + { > > + vunmap(va); > > + return NULL; > > + } > > + pa += PAGE_SIZE; > > + } > > + return va; > > +} > > Afaics you only consume the first slot of *mfn. What about the other > (nr - 1) ones? Not sure I understood. The first slot is used as the starting point and then the addr of that mfn plus next_xen_colored() are the mechanism used to select the next mfns. Probably the first argument of vmap_colored is a bit misleading. > And compared to __vmap() there's no "granularity" > parameter, which is what controls the mapping of multiple contiguous > pages. That's because we don't support multiple contiguous pages in the sense that we only operate on one page at a time (like explained in the "Known limitations" doc section and elsewhere in those discussions). > > --- a/xen/include/xen/vmap.h > > +++ b/xen/include/xen/vmap.h > > @@ -14,6 +14,10 @@ void vm_init_type(enum vmap_region type, void *start, void *end); > > > > void *__vmap(const mfn_t *mfn, unsigned int granularity, unsigned int nr, > > unsigned int align, unsigned int flags, enum vmap_region); > > +#ifdef CONFIG_CACHE_COLORING > > +void *__vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, > > + unsigned int flags, enum vmap_region); > > +#endif > > I don't think such a declaration really needs putting inside #ifdef. > > Jan Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Fri Sep 16 17:27:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 17:27:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408091.650785 (Exim 4.92) (envelope-from ) id 1oZF7o-0002ZJ-2H; Fri, 16 Sep 2022 17:27:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408091.650785; Fri, 16 Sep 2022 17:27:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZF7n-0002ZC-Vo; Fri, 16 Sep 2022 17:27:35 +0000 Received: by outflank-mailman (input) for mailman id 408091; Fri, 16 Sep 2022 17:27:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZF7m-0002Z2-JN; Fri, 16 Sep 2022 17:27:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZF7m-0002yJ-Hk; Fri, 16 Sep 2022 17:27:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZF7m-0005IW-03; Fri, 16 Sep 2022 17:27:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZF7l-0000G5-Vl; Fri, 16 Sep 2022 17:27:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Rg0MtwOgVTBnQuKtqIf8wpb0fOYA9BYTX6N9SYN4Jpc=; b=fOaTfPvjIwVD/Get7XTw3bmliX qzcLbW/fDmi6P50FjtnC3jiqyk0ztpWCC/gMO1RhUHupJLXvURx2UrtVZtLy/wXEHzPWkMwBij8/Y B0AGJuCvqaiQSWfsmW8oQebLcXUdJhUMAS+q/giArfA93dEWsHJif5FvVzJ7hpGAAdiM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173236: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=2c17d676e402d75a3a674499342f7ddaccf387bd X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 17:27:33 +0000 flight 173236 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 2c17d676e402d75a3a674499342f7ddaccf387bd baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 321 attempts Testing same since 173234 2022-09-16 10:42:10 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gang Chen Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Nickle Wang Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2652 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 17:42:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 17:42:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408100.650797 (Exim 4.92) (envelope-from ) id 1oZFLj-0004tx-AN; Fri, 16 Sep 2022 17:41:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408100.650797; Fri, 16 Sep 2022 17:41:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZFLj-0004tq-7c; Fri, 16 Sep 2022 17:41:59 +0000 Received: by outflank-mailman (input) for mailman id 408100; Fri, 16 Sep 2022 17:41:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZFLi-0004tg-L5; Fri, 16 Sep 2022 17:41:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZFLi-0003CM-He; Fri, 16 Sep 2022 17:41:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZFLi-0006EX-1S; Fri, 16 Sep 2022 17:41:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZFLi-0006gI-0t; Fri, 16 Sep 2022 17:41:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Oea/cIYM4D7XUumWzplaij9UTG1JCyGYKNrOAq2Exy8=; b=ZtYVgCNcxdf0MKhNrUbg13VH4v 0pPdaSkjV2zChNU/knfLTaQqUrp2cqEntDvETMReKKIgkD0ECE+MiHkdwIkBENwvTVDiHgoy2Ik5F htl456dyTWXNNLmQ5Ja/JN38c9aq6JoLROYH+X+REUVjZmZH3VnAkczqUzzVTw1nKhJ4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173231: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3245cb65fd91cd514801bf91f5a3066d562f0ac4 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Fri, 16 Sep 2022 17:41:58 +0000 flight 173231 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173231/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 build-arm64-pvops 6 kernel-build fail REGR. vs. 172133 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 12 debian-di-install fail pass in 173220 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 173220 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 173220 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173220 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173220 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 173220 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173220 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 173220 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173220 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173220 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173220 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3245cb65fd91cd514801bf91f5a3066d562f0ac4 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 43 days Failing since 172152 2022-08-05 04:01:26 Z 42 days 96 attempts Testing same since 173191 2022-09-14 11:10:31 Z 2 days 5 attempts ------------------------------------------------------------ 1779 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182803 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 18:41:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 18:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408112.650808 (Exim 4.92) (envelope-from ) id 1oZGGt-0002mx-QW; Fri, 16 Sep 2022 18:41:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408112.650808; Fri, 16 Sep 2022 18:41:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZGGt-0002mq-Nl; Fri, 16 Sep 2022 18:41:03 +0000 Received: by outflank-mailman (input) for mailman id 408112; Fri, 16 Sep 2022 18:41:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZGGs-0002mU-8T for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 18:41:02 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b311431-35ef-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 20:41:00 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH2PR12MB5002.namprd12.prod.outlook.com (2603:10b6:610:6d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 18:40:55 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5632.015; Fri, 16 Sep 2022 18:40:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b311431-35ef-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/ICXphZGFPRhAPiO4slYzUVfjlGFuJfVn2d4E6DiwwvG7dY3J2JSrRxReanfB60ZFyirkbIN/B59fTgTniCWf99FbjEXKlzsRTZR/mZVCbsyEcvycNHKOFusaY1yg8nY0g/9n2WMgNqqPRW3ypsgGhrNz7XFRivVgX/vi/bRiTd8il33x57UkCwmP6/+iR7YuLMbZZpp6lgGYm22IzQrY8dbRFIMTEmtKWco/VBYXgRDTzcOxGZTtUUY8X6ecIh6fyWXQYayQ7XsD0wdxoRIMancXiv884tpasEE/C6Ejt7qRNKGaSL7RWg+32nGmpCFDpqkuL4n4WfgTlgnLxQEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2niwYhetKBpTYRmrYXKxjPz0rrtfaxqA1XpfjGMOl6Q=; b=JxtoUJ/2sbhZNRiXGpZjQ2BQkmqFfBFjjb738vOLqtoSENh9vjdjQ63dJFcmEmRuvhyYsBbfzDERmz35lwrLso9whnhWS8xSTwFYJEucirGW8u7kkzSmJP93T+6G+fU1x3xOW9z0byiF+C1k/S7MxGpUq97+wFPNHK+0ZG8u99rJysmUoofvBUJPX69LaOJM+lI24oBPP+ItpZZDU5ya1LfgWwlIXx/xZeT14Yj6g7QPtq3T/RKmuKT7klEAtbAxHVtPpvcNJcTAtaUPURF2Y6/yAYHeErjIXvlP77eLOXtvHNETczjLr5gjjE15ucqNb00dpTII3pePQQ9v2NUDuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2niwYhetKBpTYRmrYXKxjPz0rrtfaxqA1XpfjGMOl6Q=; b=v6erNQWd50dFskEKSGGfTPdBJE9ya0dewiGce6zXIVpBAV3VObP6GC3izHiHPIsthvDL5BMHzGgqeNM0lzgUzZPkVab3iORcPyhJYEgeeTfAnTR5mqwZ/0jvrM+X4pP+nVwmRype90Y83BrSqiYf1LSuDUuo1k2ZnQye1/Q6TqY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Fri, 16 Sep 2022 19:40:49 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Julien Grall , michal.orzel@amd.com, stefanos@amd.com, Henry Wang , Wei Chen , Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" From: Ayan Kumar Halder Subject: Xen crash seen on Cortex-R52 FVP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0468.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::24) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH2PR12MB5002:EE_ X-MS-Office365-Filtering-Correlation-Id: 6eb08318-a498-4345-9809-08da9812fd60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mKKqHDFmSRIFMfTfvOFq8QN9DpiaItxIDOBTwGkVB4j0PpxxW94DZRy0qsiT/wAn5CwuF5FzSsdqbmBYlTWzoO7cSzdsdH7hA6tbQ7EeQQ0rrb6xO6durJLUnukF6gajDUwYlUbJ4BbUWAYtQ/AfkpbqKhnlD4cFeamPYHvyiBp/35o14QKz3VNVXagBijsOHuUj1nztMndmChZl/8ZAq4ePDFEIUh1TY4AkJTStRm19JxS603zCmkp13spr20fMFXMJ9OG4AP8SWi9cAkxnnL+GKkgLZ4qh3+GpRBMKu5cXpgopuwaqTCyr+UTfdaXHfAaBYMQuNxKVHh4RRYxeyvUWBlXieI50iMH9ltHdo8zgN3k28SZNfdt5sKnoGwEwqihSVpIRs+NzTe2UFNdEQLF77HiPNqwEYtK/ceiNinWv+MxmrHzkFIl2rOCgCMLHSL3U0OaFzk/dfUFXtnE5qkER992I6loNJmvDneRAAtrRPlKrte2L2YwQa3bMfG/STSQCTQiTmmg7k7mEEY2YtdcBcBqNcPw+QGzzvxuJzsw6NVHI2r1jbfaK4/LNpUasVLANWbX29mgw0A8jhkFaQHw8DcrkCPrHktpzLQXbXcFOMSyyXyZyyXk2ykbjxtsqfDewGRCoJvR3XvKfQaYJ4txTwZnFo9sQjw0PcMng4a39LF+ULl7cf5aLXA9jk+d8fLJ4JcDNAYmubwOc+tLDS5AK/Sy4HkEaLOOjW9ORZ8DjkHs3d4LtXor5mPn/WHohM/nSQNXceqhTxrUPM5YRNP85ACWfCubi5JNT3Bi4DPJHdoXTYW6CErIOWKDq8JsXAySWOFgMET0aHu9TSn9FdA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(31686004)(36756003)(2906002)(4744005)(66556008)(8676002)(66476007)(66946007)(4326008)(38100700002)(110136005)(31696002)(8936002)(316002)(5660300002)(186003)(478600001)(2616005)(26005)(6512007)(966005)(6486002)(41300700001)(6506007)(6666004)(10126625003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b09jVU1scy8wQyt0Z2pEZzNLcXZtcVhPbTNmdElGOW5XSWZUeUc0bDlpcTJJ?= =?utf-8?B?MTJPYmludS9ZZUhKejJjTTNYQjJuc0dBNzdYUkhNQ0RwSlkyT3dPdkNiMk10?= =?utf-8?B?dFlhUi9yRmJTVG9hcGZuUDNxRGFmRlMwUXBjU2NsUVkzeFdBb0k1bi9ZYkdD?= =?utf-8?B?QnA5N3VtNGNKZHJZLyswZTE3ckl0ZnE1UEFUU1Y5ZUJvZmNSSG1YcU9RUGw2?= =?utf-8?B?YVdkaDlVazhtM05GZSszaUw0UEFyWVpFQ3BLRzBNQ3Z1TWNPc3VTZzNmMTRU?= =?utf-8?B?MXVGRGY1UFNYdjlWL2ZvR3dKME5RbFBJdTk5bzBvd01ENjM3NmgzS2ZKKzdn?= =?utf-8?B?dW1iTUVISVQvWGtzcytCK2tXVWp1QitJdVNjUmdxV2hMcVJ2WG03RCthZW1I?= =?utf-8?B?dVQ0Sm8wQjNVY3pOMHVpc0FxaTEvWW44SEFjbXdlOHY2VFluVTAyaEs2a1FG?= =?utf-8?B?ZGhLMlNYZER5cW1JMytaWHZsUlR2aFJxeXU2Vm90MGQrampOVDhxOGx4eHU4?= =?utf-8?B?Z2hoMFd3QUFmVUlxUkZHM2VKK3RUV3c5aGVzSW4wYUZRb3pUMnlwNUN0TmZu?= =?utf-8?B?OElNdzZYL3krZlAxVnlINStiSDJKS094SDdIWlpsQ2tEaU1Ud2pXYnI3TnUr?= =?utf-8?B?Tll2OXFjU3hIbEQxeFd0VThDMzI1cjlJRzFPU1N0M25hcUJjVjZUT21nRFR3?= =?utf-8?B?SXpJUlJSTGl1RmY5TnBoSnpYdHlBb0FMOXBiOCtoemM1cktlRjE2aE0ybWtY?= =?utf-8?B?VUlpTjc3OUczUXRDcWZyMzJhYThIMVB5bzR0eWxORlBmSk1ZelR2MFRuZFlG?= =?utf-8?B?UmxXcHplR1BtcjJFVHUzTVR1Y0J0Vjh1dFBwcVNpWGdpRmJ0RVZxdkEwZ0Fu?= =?utf-8?B?cVZjSUhUcEI4TXVYRUluREJlOERHc0lZM0ViOEFhYXBHRFc1eDFtWE04ekhS?= =?utf-8?B?bi8vRDUzVHdwblFRVXBUcmtCSmZCK2J3T0crZDRhVDhpYWJBaDZyOFpONmNt?= =?utf-8?B?SER4d1VsYzFGSlh5YmYxa3ZjZlM1UUhHTTJLYnFrWDVnblZHWFk5Mjljbkxo?= =?utf-8?B?YmxDNXhNYUlONVNYM3l3Tzc5eHpSbU1ZS1ZMVEdzL2g1dWtaS3RrV0lOUVFu?= =?utf-8?B?VTVQZ0dkVjBxcmFCSW9rMFdYd1N3OXNsRG5HQVRiRTlhOFZTWGxITkxKRjZ1?= =?utf-8?B?WnhHdU9OeWRqUk9UZEdKUFhNWWI2VTNzTFhkZjJ1eitVUjRVYkZVWFV5dWU3?= =?utf-8?B?UnhDT2tKaHdNZTJXVjFmSDFDVDM1NGlJc0R1SmZnRlNXbDVNdjVieDlQNlVu?= =?utf-8?B?MFdBNFloVkNqT0xzdThzVlpmNzVtaGw4c0c4NlRQanQvQnlnWHBiSWRQb2tv?= =?utf-8?B?MEV6YklkYXZ6NnhhalNGUXRQSE1aQjhLWTh0c1krVFdSVmV4Q0IrbkZEVlFE?= =?utf-8?B?bnNjbDFmQTRQTmdJQnhKazhuUzQ4Z3kxQzg5RkxNQU9CVjMzUGxlVFY3T3Bv?= =?utf-8?B?dnRWZ3ErRUtFWElvQW80UmxjdmJXa3hZZlBNVm9yT3ozYlVPNkpjQ2h3QnJ1?= =?utf-8?B?S2J3d0ZxMXJzcm9aZjAzSW93bWwrbmNLbWswL0NGZ0FOSytqMmJQd1dRZ29R?= =?utf-8?B?Wjdud1V1Y21IdWdJQ3FRK2pvU2gxS2thSTlxcVlZTWxHbit6ZHR5WW5YRWJC?= =?utf-8?B?Ynh3YkZISFR5YURMNHRsSW5vK0RzaEV3NkhQQTl6dWR0QStpL1VLbGxTUXpq?= =?utf-8?B?dmFqY3RxZVBLcXJVWHZlQlJMRUhvZjlEcERjL0xGYThnSCtweW9RRHpiaE9v?= =?utf-8?B?S3BBRGJmN2VFNjNySUEwOHJUdCtwVlNkdjRVODVVK2hNZjdhRktRODdVNTND?= =?utf-8?B?aGtPcmdGN29oTUNXWnpPL3ZlTFIyNWdEV3AwUWxCYzhTbE1JL1Q4WkV6OGIw?= =?utf-8?B?NllydEJJcGpKcUVuU1dzN3FIOVl6VkwwTCtNUnR6YTdxUXdXVlpsb0RobDQ2?= =?utf-8?B?NnF0TnFleU8yRG1PSHF6VTBLSXp5eWpwekY1QkVHbnRyMUtsRG53T3lXMVZP?= =?utf-8?B?am9xZFF2aXR1SGxjOXR3K0hJejVkd1lCSFJpUEczekNSalREVjZKUU03TDFT?= =?utf-8?Q?iSCkr6ND8/J1O0XUgx1/EYrr2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb08318-a498-4345-9809-08da9812fd60 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 18:40:55.6333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2wr07vtMsCq273jTEQz8w/hOLIM9hvgkKpP3Tj8J2M3Dbjout1H2prILvEKVK6em1JGUjVRZGFPrqDnhqTvwwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5002 Hi All, This is a follow up discussion on the crash issue being discussed on the IRC on 15th Sep. For the context, the issue is as follows :- Crash logs - https://pastebin.com/F2BKbW5a Codebase :- https://gitlab.com/ayankuma/xen-integration/-/tree/integration/mpu The crash is observed in idle_loop() --> scrub_free_pages() --> scrub_one_page(&pg[i]) ---> unmap_domain_page(memset(__map_domain_page(pg), SCRUB_BYTE_PATTERN, PAGE_SIZE)); &pg[i] = 0x6f002400 _map_domain_pg(0x6f002400) = 0x00122000 0x122000 has been marked as read only in early_fdt_map() because dtb is mapped in the region. See (XEN) MODULE[1]: 0000000000122000 - 0000000000122d22 Device Tree Thus, I am not very sure what I need to fix. Is the address returned by __map_domain_page(pg) is incorrect ? Any pointers/guidance is appreciated. Kind regards, Ayan From xen-devel-bounces@lists.xenproject.org Fri Sep 16 19:26:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 19:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408119.650819 (Exim 4.92) (envelope-from ) id 1oZGyl-0007En-9b; Fri, 16 Sep 2022 19:26:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408119.650819; Fri, 16 Sep 2022 19:26:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZGyl-0007Eg-66; Fri, 16 Sep 2022 19:26:23 +0000 Received: by outflank-mailman (input) for mailman id 408119; Fri, 16 Sep 2022 19:26:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZGyk-0007Ea-29 for xen-devel@lists.xen.org; Fri, 16 Sep 2022 19:26:22 +0000 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [2607:f8b0:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e3b4e82-35f5-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 21:26:16 +0200 (CEST) Received: by mail-pl1-x62a.google.com with SMTP id iw17so22372528plb.0 for ; Fri, 16 Sep 2022 12:26:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e3b4e82-35f5-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=2QvvCgGikxiC7eEptSFglJhutyHTvWpFpNg5/p7Qa2A=; b=SteGiFYay03QwDK/Ej0s5owWaiRtPhow7CM0cxNcIommrzD1CUyHbcPniIdKufdqHb R0w+J1uCcycz0RzwOP6eViqd2mXZPYx7gUrFTKTwNlgEoXcJBAve/rKRDEOas+XileM3 DsHEnFTee07CtB7/lZmiyd7HtD2fKfmaWRuH0AHdxPVGz0Hh6bOzBtKIzVTkRnuZR1SG IpAIg8xOsytbyorZzJB/U6QYPVYq9T9WIYlAlj89ANZJcLmBxfKcjBu3JEZ7j01CnyeL y7nxdqRg+EhhNQh0BEir6njVWDSc1zqkWcLX8oJELDV5lwHH/TgXsKqaHmgov9zCpY+G 8vBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2QvvCgGikxiC7eEptSFglJhutyHTvWpFpNg5/p7Qa2A=; b=0LKWsUo7fEj9c4ATspJxK6DVVz2sIdZwckTb8qgsYnzuDeLjzLs0d5ZtuRRY8ja7Lc YvC1/skH5r6XcdTR4/Bya/PdExH8/hplI8XU514Rn00TTzLiQmWCX/ySHrvFHqKMfnXF WgRRM+SgBl8XRofjFj+21rNJEdobKGr805JR/+tv3MKaRMvSx61GXxpvr+f+ty6jApoW 5bz/U+eJ8won4of0hbOqEIzSRxd379lESRzgYzUDf/t4iaMT3aGZtXW3oQT/erGwN+sK nXUhF2LDvF75WGLaAStPMogkc8AGTgRFzdi6NYV6y6FrYe6q/0poCNHU60TIskB+jXXD YbGQ== X-Gm-Message-State: ACrzQf0Td5y2VU5WPGEKxRGnDXk1azf0fyZ8HNXa6+grXvUAKcfj5/ua gbX1XcekfvAoiQ34TpaXRkuTuXIWeVeBhruyIgvOD/6De5/S0w== X-Google-Smtp-Source: AMsMyM4lhcdIB+r/6Pi+YhHa/BNLXv8matCG3QkAQc8ILXPQ0ClIWRt7NOeUXsrpMgpDTTF4M4HA1VF80ry6lqXxYCY= X-Received: by 2002:a17:902:d88b:b0:178:264b:5aa4 with SMTP id b11-20020a170902d88b00b00178264b5aa4mr1350336plz.44.1663356374253; Fri, 16 Sep 2022 12:26:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Szewczyk Date: Fri, 16 Sep 2022 21:26:01 +0200 Message-ID: Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000d2830905e8d055c7" --000000000000d2830905e8d055c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > 00:00.0 Host bridge: Intel Corporation 8th Gen Core Processor Host > Bridge/DRAM Registers (rev 07) > Subsystem: Lenovo Device 3807 > Flags: bus master, fast devsel, latency 0 > Capabilities: > > 00:01.0 PCI bridge: Intel Corporation 6th-10th Gen Core Processor PCIe > Controller (x16) (rev 07) (prog-if 00 [Normal decode]) > Flags: bus master, fast devsel, latency 0, IRQ 158 > Bus: primary=3D00, secondary=3D01, subordinate=3D05, sec-latency=3D0 > I/O behind bridge: 00004000-00004fff [size=3D4K] > Memory behind bridge: a0000000-b40fffff [size=3D321M] > Prefetchable memory behind bridge: 00000000b4100000-00000000b41fffff > [size=3D1M] > Capabilities: > Kernel driver in use: pcieport > > 00:04.0 Signal processing controller: Intel Corporation Xeon E3-1200 > v5/E3-1500 v5/6th Gen Core Processor Thermal Subsystem (rev 07) > Subsystem: Lenovo Device 382f > Flags: bus master, fast devsel, latency 0, IRQ 16 > Memory at b4510000 (64-bit, non-prefetchable) [size=3D32K] > Capabilities: > Kernel driver in use: proc_thermal > Kernel modules: processor_thermal_device_pci_legacy > > 00:08.0 System peripheral: Intel Corporation Xeon E3-1200 v5/v6 / E3-1500 > v5 / 6th/7th/8th Gen Core Processor Gaussian Mixture Model > Subsystem: Lenovo Device 3864 > Flags: bus master, fast devsel, latency 0, IRQ 255 > Memory at b4524000 (64-bit, non-prefetchable) [size=3D4K] > Capabilities: > > 00:12.0 Signal processing controller: Intel Corporation Cannon Lake PCH > Thermal Controller (rev 10) > Subsystem: Lenovo Device 3802 > Flags: bus master, fast devsel, latency 0, IRQ 16 > Memory at b4525000 (64-bit, non-prefetchable) [size=3D4K] > Capabilities: > Kernel driver in use: intel_pch_thermal > Kernel modules: intel_pch_thermal > > 00:14.0 USB controller: Intel Corporation Cannon Lake PCH USB 3.1 xHCI > Host Controller (rev 10) (prog-if 30 [XHCI]) > Subsystem: Lenovo Device 3806 > Flags: bus master, medium devsel, latency 0, IRQ 16 > Memory at b4500000 (64-bit, non-prefetchable) [size=3D64K] > Capabilities: > Kernel driver in use: pciback > Kernel modules: xhci_pci > > 00:14.2 RAM memory: Intel Corporation Cannon Lake PCH Shared SRAM (rev 10= ) > Subsystem: Lenovo Device 3824 > Flags: bus master, fast devsel, latency 0 > Memory at b4520000 (64-bit, non-prefetchable) [size=3D8K] > Memory at b4526000 (64-bit, non-prefetchable) [size=3D4K] > Capabilities: > > 00:14.3 Network controller: Intel Corporation Wireless-AC 9560 [Jefferson > Peak] (rev 10) > Subsystem: Intel Corporation Device 0034 > Flags: fast devsel, IRQ 16 > Memory at b4518000 (64-bit, non-prefetchable) [size=3D16K] > Capabilities: > Kernel driver in use: pciback > Kernel modules: iwlwifi > > 00:15.0 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH > Serial IO I2C Controller #0 (rev 10) > Subsystem: Lenovo Device 3803 > Flags: bus master, fast devsel, latency 0, IRQ 16 > Memory at b4527000 (64-bit, non-prefetchable) [virtual] [size=3D4K] > Capabilities: > Kernel driver in use: intel-lpss > > 00:15.1 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH > Serial IO I2C Controller #1 (rev 10) > Subsystem: Lenovo Device 3804 > Flags: bus master, fast devsel, latency 0, IRQ 17 > Memory at b4528000 (64-bit, non-prefetchable) [virtual] [size=3D4K] > Capabilities: > Kernel driver in use: intel-lpss > > 00:16.0 Communication controller: Intel Corporation Cannon Lake PCH HECI > Controller (rev 10) > Subsystem: Lenovo Device 3810 > Flags: bus master, fast devsel, latency 0, IRQ 174 > Memory at b4529000 (64-bit, non-prefetchable) [size=3D4K] > Capabilities: > Kernel driver in use: mei_me > Kernel modules: mei_me > > 00:17.0 SATA controller: Intel Corporation Cannon Lake Mobile PCH SATA > AHCI Controller (rev 10) (prog-if 01 [AHCI 1.0]) > Subsystem: Lenovo Device 3808 > Flags: bus master, 66MHz, medium devsel, latency 0, IRQ 162 > Memory at b4522000 (32-bit, non-prefetchable) [size=3D8K] > Memory at b452e000 (32-bit, non-prefetchable) [size=3D256] > I/O ports at 5040 [size=3D8] > I/O ports at 5048 [size=3D4] > I/O ports at 5020 [size=3D32] > Memory at b452d000 (32-bit, non-prefetchable) [size=3D2K] > Capabilities: > Kernel driver in use: ahci > > 00:1d.0 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express Root > Port #9 (rev f0) (prog-if 00 [Normal decode]) > Flags: bus master, fast devsel, latency 0, IRQ 159 > Bus: primary=3D00, secondary=3D06, subordinate=3D06, sec-latency=3D0 > I/O behind bridge: [disabled] > Memory behind bridge: b4400000-b44fffff [size=3D1M] > Prefetchable memory behind bridge: [disabled] > Capabilities: > Kernel driver in use: pcieport > > 00:1d.5 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express Root > Port #14 (rev f0) (prog-if 00 [Normal decode]) > Flags: bus master, fast devsel, latency 0, IRQ 160 > Bus: primary=3D00, secondary=3D07, subordinate=3D07, sec-latency=3D0 > I/O behind bridge: 00003000-00003fff [size=3D4K] > Memory behind bridge: b4300000-b43fffff [size=3D1M] > Prefetchable memory behind bridge: [disabled] > Capabilities: > Kernel driver in use: pcieport > > 00:1e.0 Communication controller: Intel Corporation Cannon Lake PCH Seria= l > IO UART Host Controller (rev 10) > Subsystem: Lenovo Device 3813 > Flags: bus master, fast devsel, latency 0, IRQ 20 > Memory at b452a000 (64-bit, non-prefetchable) [virtual] [size=3D4K] > Capabilities: > Kernel driver in use: intel-lpss > > 00:1f.0 ISA bridge: Intel Corporation HM470 Chipset LPC/eSPI Controller > (rev 10) > Subsystem: Lenovo Device 380e > Flags: bus master, medium devsel, latency 0 > > 00:1f.3 Audio device: Intel Corporation Cannon Lake PCH cAVS (rev 10) > Subsystem: Lenovo Device 380f > Flags: bus master, fast devsel, latency 32, IRQ 175 > Memory at b451c000 (64-bit, non-prefetchable) [size=3D16K] > Memory at b4200000 (64-bit, non-prefetchable) [size=3D1M] > Capabilities: > Kernel driver in use: snd_hda_intel > Kernel modules: snd_hda_intel, snd_soc_skl, snd_sof_pci_intel_cnl > > 00:1f.4 SMBus: Intel Corporation Cannon Lake PCH SMBus Controller (rev 10= ) > Subsystem: Lenovo Device 3814 > Flags: medium devsel, IRQ 16 > Memory at b452b000 (64-bit, non-prefetchable) [size=3D256] > I/O ports at 5000 [size=3D32] > Kernel driver in use: i801_smbus > Kernel modules: i2c_i801 > > 00:1f.5 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH > SPI Controller (rev 10) > Subsystem: Lenovo Device 3827 > Flags: bus master, fast devsel, latency 0 > Memory at fe010000 (32-bit, non-prefetchable) [size=3D4K] > > 01:00.0 VGA compatible controller: NVIDIA Corporation TU116M [GeForce GTX > 1660 Ti Mobile] (rev a1) (prog-if 00 [VGA controller]) > Subsystem: Lenovo Device 3ffc > Flags: bus master, fast devsel, latency 0, IRQ 172 > Memory at b3000000 (32-bit, non-prefetchable) [size=3D16M] > Memory at a0000000 (64-bit, prefetchable) [size=3D256M] > Memory at b0000000 (64-bit, prefetchable) [size=3D32M] > I/O ports at 4000 [size=3D128] > Expansion ROM at b2000000 [disabled] [size=3D512K] > Capabilities: > Kernel driver in use: nouveau > Kernel modules: nouveau > > 01:00.1 Audio device: NVIDIA Corporation TU116 High Definition Audio > Controller (rev a1) > Subsystem: Lenovo Device 3ffc > Flags: bus master, fast devsel, latency 0, IRQ 17 > Memory at b4000000 (32-bit, non-prefetchable) [size=3D16K] > Capabilities: > Kernel driver in use: snd_hda_intel > Kernel modules: snd_hda_intel > > 01:00.2 USB controller: NVIDIA Corporation TU116 USB 3.1 Host Controller > (rev a1) (prog-if 30 [XHCI]) > Subsystem: Lenovo Device 3ffc > Flags: bus master, fast devsel, latency 0, IRQ 18 > Memory at b4100000 (64-bit, prefetchable) [size=3D256K] > Memory at b4140000 (64-bit, prefetchable) [size=3D64K] > Capabilities: > Kernel driver in use: pciback > Kernel modules: xhci_pci > > 01:00.3 Serial bus controller [0c80]: NVIDIA Corporation TU116 USB Type-C > UCSI Controller (rev a1) > Subsystem: Lenovo Device 3ffc > Flags: bus master, fast devsel, latency 0, IRQ 173 > Memory at b4004000 (32-bit, non-prefetchable) [size=3D4K] > Capabilities: > Kernel driver in use: nvidia-gpu > Kernel modules: i2c_nvidia_gpu > > 06:00.0 Non-Volatile memory controller: Sandisk Corp WD Blue SN500 / PC > SN520 NVMe SSD (rev 01) (prog-if 02 [NVM Express]) > Subsystem: Sandisk Corp WD Blue SN500 / PC SN520 NVMe SSD > Flags: bus master, fast devsel, latency 0, IRQ 16, NUMA node 0 > Memory at b4400000 (64-bit, non-prefetchable) [size=3D16K] > Capabilities: > Kernel driver in use: nvme > Kernel modules: nvme > > 07:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. > RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 15) > Subsystem: Lenovo Device 38cd > Flags: bus master, fast devsel, latency 0, IRQ 17 > I/O ports at 3000 [size=3D256] > Memory at b4304000 (64-bit, non-prefetchable) [size=3D4K] > Memory at b4300000 (64-bit, non-prefetchable) [size=3D16K] > Capabilities: > Kernel driver in use: pciback > Kernel modules: r8169 > Sorry I forgot about lscpi -v pt., 16 wrz 2022 o 17:08 Adam Szewczyk napisa=C5=82(a)= : > Sorry, I always forgot that default answer is "answer" to not "answer to > all". > > My xl dmesg after calling those debug-keys is: > >> t=3D0 d0: 8(---) >> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0: 9(---) >> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >> mapped, unbound >> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 14(---) >> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-M-) >> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{2}/{0-11} >> in-flight=3D1 d0: 17(---),d81: 17(-MM) >> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0: 18(---),d3: 18(-M-) >> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0: 20(---) >> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0: 83(---) >> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >> iommu.c#iommu_page_fault() >> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:951(---) >> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:950(---) >> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:949(---) >> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:948(---) >> (XEN) IRQ: 125 vec:4a PCI-MSI status=3D010 aff:{6}/{0-11} >> in-flight=3D0 d78:151(---) >> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:946(---) >> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:945(---) >> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:944(---) >> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:943(---) >> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:942(---) >> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0:941(---) >> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0:940(---) >> (XEN) IRQ: 133 vec:52 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d81:151(-M-) >> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:938(---) >> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:936(---) >> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0:935(---) >> (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d3:151(---) >> (XEN) IRQ: 139 vec:d9 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d3:150(---) >> (XEN) Direct vector information: >> (XEN) 0x22 -> irq_move_cleanup_interrupt() >> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >> (XEN) 0xf9 -> pmu_apic_interrupt() >> (XEN) 0xfa -> apic_timer_interrupt() >> (XEN) 0xfb -> call_function_interrupt() >> (XEN) 0xfc -> event_check_interrupt() >> (XEN) 0xfd -> invalidate_interrupt() >> (XEN) 0xfe -> error_interrupt() >> (XEN) 0xff -> spurious_interrupt() >> (XEN) IO-APIC interrupt information: >> (XEN) IRQ 0 Vec240: >> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 1 Vec 49: >> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000400 >> (XEN) IRQ 3 Vec 64: >> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 4 Vec 72: >> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 5 Vec 80: >> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 6 Vec 88: >> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 7 Vec 96: >> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 8 Vec104: >> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 9 Vec 57: >> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 >> (XEN) IRQ 10 Vec120: >> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 11 Vec136: >> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 12 Vec144: >> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 13 Vec152: >> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >> (XEN) IRQ 14 Vec160: >> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 15 Vec168: >> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 16 Vec176: >> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 17 Vec208: >> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 >> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 18 Vec184: >> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >> (XEN) IRQ 19 Vec161: >> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >> (XEN) IRQ 20 Vec224: >> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 83 Vec 65: >> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >> (XEN) MSI information: >> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /? >> (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D0/ /? >> (XEN) MSI 125 vec=3D4a lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D1/ /0 >> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D0000= 0400 >> mask=3D1/ /0 >> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D0000= 0400 >> mask=3D1/ /0 >> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D1/ /0 >> (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI 133 vec=3D5a lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D0000= 0555 >> mask=3D0/ /? >> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) MSI 138 vec=3Dd1 lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI 139 vec=3Dd9 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) IRQ information: >> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >> time.c#timer_interrupt() >> (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{10}/{0-11} >> in-flight=3D0 d0: 1(---) >> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 8(---) >> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0: 9(---) >> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >> mapped, unbound >> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 14(---) >> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-M-) >> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D030 aff:{10}/{0-11} >> in-flight=3D1 d0: 17(---),d87: 17(-MM) >> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0: 18(---),d3: 18(-M-) >> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0: 20(---) >> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0: 83(---) >> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >> iommu.c#iommu_page_fault() >> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:951(---) >> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:950(---) >> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:949(---) >> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:948(---) >> (XEN) IRQ: 125 vec:4a PCI-MSI status=3D010 aff:{2}/{0-11} >> in-flight=3D0 d78:151(---) >> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:946(---) >> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:945(---) >> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0:944(---) >> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0:943(---) >> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:942(---) >> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:941(---) >> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:940(---) >> (XEN) IRQ: 133 vec:5a PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d87:151(-M-) >> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{2}/{0-11} >> in-flight=3D0 d0:938(---) >> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:936(---) >> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:935(---) >> (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d3:151(---) >> (XEN) IRQ: 139 vec:d9 PCI-MSI status=3D010 aff:{0}/{0-11} >> in-flight=3D0 d3:150(---) >> (XEN) Direct vector information: >> (XEN) 0x22 -> irq_move_cleanup_interrupt() >> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >> (XEN) 0xf9 -> pmu_apic_interrupt() >> (XEN) 0xfa -> apic_timer_interrupt() >> (XEN) 0xfb -> call_function_interrupt() >> (XEN) 0xfc -> event_check_interrupt() >> (XEN) 0xfd -> invalidate_interrupt() >> (XEN) 0xfe -> error_interrupt() >> (XEN) 0xff -> spurious_interrupt() >> (XEN) IO-APIC interrupt information: >> (XEN) IRQ 0 Vec240: >> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 1 Vec 49: >> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000400 >> (XEN) IRQ 3 Vec 64: >> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 4 Vec 72: >> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 5 Vec 80: >> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 6 Vec 88: >> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 7 Vec 96: >> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 8 Vec104: >> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 9 Vec 57: >> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 >> (XEN) IRQ 10 Vec120: >> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 11 Vec136: >> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 12 Vec144: >> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 13 Vec152: >> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >> (XEN) IRQ 14 Vec160: >> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 15 Vec168: >> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 16 Vec176: >> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 17 Vec208: >> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 >> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 18 Vec184: >> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >> (XEN) IRQ 19 Vec161: >> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >> (XEN) IRQ 20 Vec224: >> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 83 Vec 65: >> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 >> (XEN) MSI information: >> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /? >> (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D0/ /? >> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D1/ /0 >> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D1/ /0 >> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D0000= 0555 >> mask=3D0/ /? >> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D0000= 0400 >> mask=3D0/ /? >> (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) IRQ information: >> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >> time.c#timer_interrupt() >> (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{6}/{0-11} >> in-flight=3D0 d0: 1(---) >> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 8(---) >> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 9(---) >> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >> mapped, unbound >> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 14(---) >> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 16(---),d92: 16(-M-) >> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{8}/{0-11} >> in-flight=3D1 d0: 17(---),d94: 17(-MM) >> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 18(---),d92: 18(-M-) >> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0: 20(---) >> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0: 83(---) >> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >> iommu.c#iommu_page_fault() >> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:951(---) >> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:950(---) >> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:949(---) >> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0:948(---) >> (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d94:151(-M-) >> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:946(---) >> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:945(---) >> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:944(---) >> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:943(---) >> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:942(---) >> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:941(---) >> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:940(---) >> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{0}/{0-11} >> in-flight=3D0 d0:938(---) >> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:936(---) >> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0:935(---) >> (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d92:151(---) >> (XEN) IRQ: 139 vec:6a PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d92:150(---) >> (XEN) Direct vector information: >> (XEN) 0x22 -> irq_move_cleanup_interrupt() >> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >> (XEN) 0xf9 -> pmu_apic_interrupt() >> (XEN) 0xfa -> apic_timer_interrupt() >> (XEN) 0xfb -> call_function_interrupt() >> (XEN) 0xfc -> event_check_interrupt() >> (XEN) 0xfd -> invalidate_interrupt() >> (XEN) 0xfe -> error_interrupt() >> (XEN) 0xff -> spurious_interrupt() >> (XEN) IO-APIC interrupt information: >> (XEN) IRQ 0 Vec240: >> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 1 Vec 49: >> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000040 >> (XEN) IRQ 3 Vec 64: >> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 4 Vec 72: >> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 5 Vec 80: >> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 6 Vec 88: >> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 7 Vec 96: >> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 8 Vec104: >> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 9 Vec 57: >> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 10 Vec120: >> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 11 Vec136: >> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 12 Vec144: >> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 13 Vec152: >> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >> (XEN) IRQ 14 Vec160: >> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 15 Vec168: >> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 16 Vec176: >> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 17 Vec208: >> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 >> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000100 >> (XEN) IRQ 18 Vec184: >> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 19 Vec161: >> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >> (XEN) IRQ 20 Vec224: >> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 83 Vec 65: >> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >> (XEN) MSI information: >> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /? >> (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D0/ /? >> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D1/ /0 >> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D0000= 0400 >> mask=3D1/ /0 >> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D1/ /0 >> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /0 >> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D0000= 0400 >> mask=3D0/ /? >> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D0000= 0555 >> mask=3D0/ /? >> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D0000= 0400 >> mask=3D0/ /? >> (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) IRQ information: >> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >> time.c#timer_interrupt() >> (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{6}/{0-11} >> in-flight=3D0 d0: 1(---) >> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 8(---) >> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 9(---) >> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >> mapped, unbound >> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 14(---) >> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 16(---),d92: 16(-M-) >> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{8}/{0-11} >> in-flight=3D1 d0: 17(---),d94: 17(-MM) >> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 18(---),d92: 18(-M-) >> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0: 20(---) >> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0: 83(---) >> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >> iommu.c#iommu_page_fault() >> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:951(---) >> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:950(---) >> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:949(---) >> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0:948(---) >> (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d94:151(-M-) >> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:946(---) >> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:945(---) >> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0:944(---) >> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:943(---) >> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:942(---) >> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:941(---) >> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:940(---) >> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{10}/{0-11} >> in-flight=3D0 d0:938(---) >> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:936(---) >> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{10}/{0-11} >> in-flight=3D0 d0:935(---) >> (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d92:151(---) >> (XEN) IRQ: 139 vec:6a PCI-MSI status=3D010 aff:{4}/{0-11} >> in-flight=3D0 d92:150(---) >> (XEN) Direct vector information: >> (XEN) 0x22 -> irq_move_cleanup_interrupt() >> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >> (XEN) 0xf9 -> pmu_apic_interrupt() >> (XEN) 0xfa -> apic_timer_interrupt() >> (XEN) 0xfb -> call_function_interrupt() >> (XEN) 0xfc -> event_check_interrupt() >> (XEN) 0xfd -> invalidate_interrupt() >> (XEN) 0xfe -> error_interrupt() >> (XEN) 0xff -> spurious_interrupt() >> (XEN) IO-APIC interrupt information: >> (XEN) IRQ 0 Vec240: >> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 1 Vec 49: >> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000040 >> (XEN) IRQ 3 Vec 64: >> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 4 Vec 72: >> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 5 Vec 80: >> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 6 Vec 88: >> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 7 Vec 96: >> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 8 Vec104: >> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 9 Vec 57: >> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 10 Vec120: >> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 11 Vec136: >> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 12 Vec144: >> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 13 Vec152: >> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >> (XEN) IRQ 14 Vec160: >> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 15 Vec168: >> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 16 Vec176: >> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 17 Vec208: >> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL status= =3D1 >> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000100 >> (XEN) IRQ 18 Vec184: >> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 19 Vec161: >> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >> (XEN) IRQ 20 Vec224: >> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 83 Vec 65: >> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >> > > I shutted down all VMs excluding sys-usb (which I need to be able to use > keyboard) and OpenBSD HVM befor that command. > > My pcidum is: > > Domain /dev/pci0: >> 0:0:0: Intel 82441FX >> 0x0000: Vendor ID: 8086, Product ID: 1237 >> 0x0004: Command: 0004, Status: 0000 >> 0x0008: Class: 06 Bridge, Subclass: 00 Host, >> Interface: 00, Revision: 02 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR empty (00000000) >> 0x0014: BAR empty (00000000) >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >> 0:1:0: Intel 82371SB ISA >> 0x0000: Vendor ID: 8086, Product ID: 7000 >> 0x0004: Command: 0004, Status: 0200 >> 0x0008: Class: 06 Bridge, Subclass: 01 ISA, >> Interface: 00, Revision: 00 >> 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR empty (00000000) >> 0x0014: BAR empty (00000000) >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >> 0:1:1: Intel 82371SB IDE >> 0x0000: Vendor ID: 8086, Product ID: 7010 >> 0x0004: Command: 0005, Status: 0280 >> 0x0008: Class: 01 Mass Storage, Subclass: 01 IDE, >> Interface: 80, Revision: 00 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR empty (00000000) >> 0x0014: BAR empty (00000000) >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR io addr: 0x0000c200/0x0010 >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >> 0:1:3: Intel 82371AB Power >> 0x0000: Vendor ID: 8086, Product ID: 7113 >> 0x0004: Command: 0004, Status: 0280 >> 0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous, >> Interface: 00, Revision: 03 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR empty (00000000) >> 0x0014: BAR empty (00000000) >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat: 00 >> 0:2:0: XenSource Platform Device >> 0x0000: Vendor ID: 5853, Product ID: 0001 >> 0x0004: Command: 0007, Status: 0000 >> 0x0008: Class: ff (unknown), Subclass: 80 (unknown), >> Interface: 00, Revision: 01 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR io addr: 0x0000c000/0x0100 >> 0x0014: BAR mem prefetchable 32bit addr: 0xf0000000/0x01000000 >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 5853 Product ID: 0001 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 >> 0:3:0: Bochs VGA >> 0x0000: Vendor ID: 1234, Product ID: 1111 >> 0x0004: Command: 0007, Status: 0000 >> 0x0008: Class: 03 Display, Subclass: 00 VGA, >> Interface: 00, Revision: 02 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000 >> 0x0014: BAR empty (00000000) >> 0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000 >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: f2000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >> 0:4:0: Intel 82801DB USB >> 0x0000: Vendor ID: 8086, Product ID: 24cd >> 0x0004: Command: 0006, Status: 0000 >> 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, >> Interface: 20, Revision: 10 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000 >> 0x0014: BAR empty (00000000) >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00 >> 0:6:0: NEC xHCI >> 0x0000: Vendor ID: 1033, Product ID: 0194 >> 0x0004: Command: 0006, Status: 0010 >> 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, >> Interface: 30, Revision: 03 >> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR mem 64bit addr: 0x00000000f2010000/0x00004000 >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 >> 0x0090: Capability 0x11: Extended Message Signalled Interrupts (MSI-X) >> Enabled: no; table size 16 (BAR 0:12288) >> 0x0070: Capability 0x05: Message Signalled Interrupts (MSI) >> Enabled: yes >> 0:7:0: Intel AC 9560 >> 0x0000: Vendor ID: 8086, Product ID: a370 >> 0x0004: Command: 0006, Status: 0010 >> 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, >> Interface: 00, Revision: 10 >> 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, >> Cache Line Size: 00 >> 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 >> 0x0018: BAR empty (00000000) >> 0x001c: BAR empty (00000000) >> 0x0020: BAR empty (00000000) >> 0x0024: BAR empty (00000000) >> 0x0028: Cardbus CIS: 00000000 >> 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 >> 0x0030: Expansion ROM Base Address: 00000000 >> 0x0038: 00000000 >> 0x003c: Interrupt Pin: 01 Line: 05 Min Gnt: 00 Max Lat: 00 >> 0x00c8: Capability 0x01: Power Management >> State: D0 >> 0x00d0: Capability 0x05: Message Signalled Interrupts (MSI) >> Enabled: no >> 0x0040: Capability 0x10: PCI Express >> Max Payload Size: 128 / 128 bytes >> Max Read Request Size: 512 bytes >> > > BR Adam Szewczyk > > > pt., 16 wrz 2022 o 15:35 Roger Pau Monn=C3=A9 > napisa=C5=82(a): > >> Again, please keep xen-devel on Cc and don't top-post. >> >> On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote: >> > I executed it in dom0 terminal and it prints lots of stuff, but when I >> run >> > jus xl dmesg it prints almost the same logs. So I'm not sure if I have >> > right output or what I shuld search for to paste it here. >> >> Hm, you should see something like: >> >> (XEN) [ 8729.266567] MSI information: >> [...] >> (XEN) [ 8709.154958] IRQ information: >> [...] >> >> In the output of `xl dmesg` >> >> You can paste the full output of `xl dmesg`, that should be fine. >> >> > Regards Adam. >> > >> > pt., 16 wrz 2022, 15:09 u=C5=BCytkownik Roger Pau Monn=C3=A9 < >> roger.pau@citrix.com> >> > napisa=C5=82: >> > >> > > Please keep xen-devel in Cc and avoid top-posting. >> > > >> > > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: >> > > > > 0:7:0: Intel AC 9560 >> > > > > 0x0000: Vendor ID: 8086, Product ID: a370 >> > > > > 0x0004: Command: 0006, Status: 0010 >> > > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, >> > > > > Interface: 00, Revision: 10 >> > > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, >> > > > > Cache Line Size: 00 >> > > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 >> > > > > 0x0018: BAR empty (00000000) >> > > > > 0x001c: BAR empty (00000000) >> > > > > 0x0020: BAR empty (00000000) >> > > > > 0x0024: BAR empty (00000000) >> > > > > 0x0028: Cardbus CIS: 00000000 >> > > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 >> > > > > 0x0030: Expansion ROM Base Address: 00000000 >> > > > > 0x0038: 00000000 >> > > >> > > None of the BARs are at 0x404000 which seems to be where OpenBSD is >> > > trying to load the firmware? >> > > >> > > I would have to look at the code to figure out exactly what it is >> > > trying to do here (and why it fails). >> > > >> > > Can you also paste the output from `lspci -v`? >> >> You seem to have missed this bit. >> >> Regards, Roger. >> > --000000000000d2830905e8d055c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
00:00.0 Host bridge: Intel Corporation 8th Gen Core Processor Host= Bridge/DRAM Registers (rev 07)
Subsystem: Lenovo Device 3807
Flags= : bus master, fast devsel, latency 0
Capabilities: <access denied>= ;

00:01.0 PCI bridge: Intel Corporation 6th-10th Gen Core Processor = PCIe Controller (x16) (rev 07) (prog-if 00 [Normal decode])
Flags: bus = master, fast devsel, latency 0, IRQ 158
Bus: primary=3D00, secondary=3D= 01, subordinate=3D05, sec-latency=3D0
I/O behind bridge: 00004000-00004= fff [size=3D4K]
Memory behind bridge: a0000000-b40fffff [size=3D321M] Prefetchable memory behind bridge: 00000000b4100000-00000000b41fffff [si= ze=3D1M]
Capabilities: <access denied>
Kernel driver in use: = pcieport

00:04.0 Signal processing controller: Intel Corporation Xeo= n E3-1200 v5/E3-1500 v5/6th Gen Core Processor Thermal Subsystem (rev 07) Subsystem: Lenovo Device 382f
Flags: bus master, fast devsel, latenc= y 0, IRQ 16
Memory at b4510000 (64-bit, non-prefetchable) [size=3D32K]<= br> Capabilities: <access denied>
Kernel driver in use: proc_ther= mal
Kernel modules: processor_thermal_device_pci_legacy

00:08.0 = System peripheral: Intel Corporation Xeon E3-1200 v5/v6 / E3-1500 v5 / 6th/= 7th/8th Gen Core Processor Gaussian Mixture Model
Subsystem: Lenovo Dev= ice 3864
Flags: bus master, fast devsel, latency 0, IRQ 255
Memory = at b4524000 (64-bit, non-prefetchable) [size=3D4K]
Capabilities: <ac= cess denied>

00:12.0 Signal processing controller: Intel Corporat= ion Cannon Lake PCH Thermal Controller (rev 10)
Subsystem: Lenovo Devic= e 3802
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at = b4525000 (64-bit, non-prefetchable) [size=3D4K]
Capabilities: <acces= s denied>
Kernel driver in use: intel_pch_thermal
Kernel modules= : intel_pch_thermal

00:14.0 USB controller: Intel Corporation Cannon= Lake PCH USB 3.1 xHCI Host Controller (rev 10) (prog-if 30 [XHCI])
Sub= system: Lenovo Device 3806
Flags: bus master, medium devsel, latency 0,= IRQ 16
Memory at b4500000 (64-bit, non-prefetchable) [size=3D64K]
= Capabilities: <access denied>
Kernel driver in use: pciback
K= ernel modules: xhci_pci

00:14.2 RAM memory: Intel Corporation Cannon= Lake PCH Shared SRAM (rev 10)
Subsystem: Lenovo Device 3824
Flags:= bus master, fast devsel, latency 0
Memory at b4520000 (64-bit, non-pre= fetchable) [size=3D8K]
Memory at b4526000 (64-bit, non-prefetchable) [s= ize=3D4K]
Capabilities: <access denied>

00:14.3 Network co= ntroller: Intel Corporation Wireless-AC 9560 [Jefferson Peak] (rev 10)
= Subsystem: Intel Corporation Device 0034
Flags: fast devsel, IRQ 16
= Memory at b4518000 (64-bit, non-prefetchable) [size=3D16K]
Capabilitie= s: <access denied>
Kernel driver in use: pciback
Kernel modul= es: iwlwifi

00:15.0 Serial bus controller [0c80]: Intel Corporation = Cannon Lake PCH Serial IO I2C Controller #0 (rev 10)
Subsystem: Lenovo = Device 3803
Flags: bus master, fast devsel, latency 0, IRQ 16
Memor= y at b4527000 (64-bit, non-prefetchable) [virtual] [size=3D4K]
Capabili= ties: <access denied>
Kernel driver in use: intel-lpss

00:= 15.1 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH Serial= IO I2C Controller #1 (rev 10)
Subsystem: Lenovo Device 3804
Flags:= bus master, fast devsel, latency 0, IRQ 17
Memory at b4528000 (64-bit,= non-prefetchable) [virtual] [size=3D4K]
Capabilities: <access denie= d>
Kernel driver in use: intel-lpss

00:16.0 Communication con= troller: Intel Corporation Cannon Lake PCH HECI Controller (rev 10)
Sub= system: Lenovo Device 3810
Flags: bus master, fast devsel, latency 0, I= RQ 174
Memory at b4529000 (64-bit, non-prefetchable) [size=3D4K]
Ca= pabilities: <access denied>
Kernel driver in use: mei_me
Kern= el modules: mei_me

00:17.0 SATA controller: Intel Corporation Cannon= Lake Mobile PCH SATA AHCI Controller (rev 10) (prog-if 01 [AHCI 1.0])
= Subsystem: Lenovo Device 3808
Flags: bus master, 66MHz, medium devsel, = latency 0, IRQ 162
Memory at b4522000 (32-bit, non-prefetchable) [size= =3D8K]
Memory at b452e000 (32-bit, non-prefetchable) [size=3D256]
I= /O ports at 5040 [size=3D8]
I/O ports at 5048 [size=3D4]
I/O ports = at 5020 [size=3D32]
Memory at b452d000 (32-bit, non-prefetchable) [size= =3D2K]
Capabilities: <access denied>
Kernel driver in use: ah= ci

00:1d.0 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express= Root Port #9 (rev f0) (prog-if 00 [Normal decode])
Flags: bus master, = fast devsel, latency 0, IRQ 159
Bus: primary=3D00, secondary=3D06, subo= rdinate=3D06, sec-latency=3D0
I/O behind bridge: [disabled]
Memory = behind bridge: b4400000-b44fffff [size=3D1M]
Prefetchable memory behind= bridge: [disabled]
Capabilities: <access denied>
Kernel driv= er in use: pcieport

00:1d.5 PCI bridge: Intel Corporation Cannon Lak= e PCH PCI Express Root Port #14 (rev f0) (prog-if 00 [Normal decode])
F= lags: bus master, fast devsel, latency 0, IRQ 160
Bus: primary=3D00, se= condary=3D07, subordinate=3D07, sec-latency=3D0
I/O behind bridge: 0000= 3000-00003fff [size=3D4K]
Memory behind bridge: b4300000-b43fffff [size= =3D1M]
Prefetchable memory behind bridge: [disabled]
Capabilities: = <access denied>
Kernel driver in use: pcieport

00:1e.0 Com= munication controller: Intel Corporation Cannon Lake PCH Serial IO UART Hos= t Controller (rev 10)
Subsystem: Lenovo Device 3813
Flags: bus mast= er, fast devsel, latency 0, IRQ 20
Memory at b452a000 (64-bit, non-pref= etchable) [virtual] [size=3D4K]
Capabilities: <access denied>
= Kernel driver in use: intel-lpss

00:1f.0 ISA bridge: Intel Corporat= ion HM470 Chipset LPC/eSPI Controller (rev 10)
Subsystem: Lenovo Device= 380e
Flags: bus master, medium devsel, latency 0

00:1f.3 Audio = device: Intel Corporation Cannon Lake PCH cAVS (rev 10)
Subsystem: Leno= vo Device 380f
Flags: bus master, fast devsel, latency 32, IRQ 175
= Memory at b451c000 (64-bit, non-prefetchable) [size=3D16K]
Memory at b4= 200000 (64-bit, non-prefetchable) [size=3D1M]
Capabilities: <access = denied>
Kernel driver in use: snd_hda_intel
Kernel modules: snd_= hda_intel, snd_soc_skl, snd_sof_pci_intel_cnl

00:1f.4 SMBus: Intel C= orporation Cannon Lake PCH SMBus Controller (rev 10)
Subsystem: Lenovo = Device 3814
Flags: medium devsel, IRQ 16
Memory at b452b000 (64-bit= , non-prefetchable) [size=3D256]
I/O ports at 5000 [size=3D32]
Kern= el driver in use: i801_smbus
Kernel modules: i2c_i801

00:1f.5 Se= rial bus controller [0c80]: Intel Corporation Cannon Lake PCH SPI Controlle= r (rev 10)
Subsystem: Lenovo Device 3827
Flags: bus master, fast de= vsel, latency 0
Memory at fe010000 (32-bit, non-prefetchable) [size=3D4= K]

01:00.0 VGA compatible controller: NVIDIA Corporation TU116M [GeF= orce GTX 1660 Ti Mobile] (rev a1) (prog-if 00 [VGA controller])
Subsyst= em: Lenovo Device 3ffc
Flags: bus master, fast devsel, latency 0, IRQ 1= 72
Memory at b3000000 (32-bit, non-prefetchable) [size=3D16M]
Memor= y at a0000000 (64-bit, prefetchable) [size=3D256M]
Memory at b0000000 (= 64-bit, prefetchable) [size=3D32M]
I/O ports at 4000 [size=3D128]
E= xpansion ROM at b2000000 [disabled] [size=3D512K]
Capabilities: <acc= ess denied>
Kernel driver in use: nouveau
Kernel modules: nouvea= u

01:00.1 Audio device: NVIDIA Corporation TU116 High Definition Aud= io Controller (rev a1)
Subsystem: Lenovo Device 3ffc
Flags: bus mas= ter, fast devsel, latency 0, IRQ 17
Memory at b4000000 (32-bit, non-pre= fetchable) [size=3D16K]
Capabilities: <access denied>
Kernel = driver in use: snd_hda_intel
Kernel modules: snd_hda_intel

01:00= .2 USB controller: NVIDIA Corporation TU116 USB 3.1 Host Controller (rev a1= ) (prog-if 30 [XHCI])
Subsystem: Lenovo Device 3ffc
Flags: bus mast= er, fast devsel, latency 0, IRQ 18
Memory at b4100000 (64-bit, prefetch= able) [size=3D256K]
Memory at b4140000 (64-bit, prefetchable) [size=3D6= 4K]
Capabilities: <access denied>
Kernel driver in use: pciba= ck
Kernel modules: xhci_pci

01:00.3 Serial bus controller [0c80]= : NVIDIA Corporation TU116 USB Type-C UCSI Controller (rev a1)
Subsyste= m: Lenovo Device 3ffc
Flags: bus master, fast devsel, latency 0, IRQ 17= 3
Memory at b4004000 (32-bit, non-prefetchable) [size=3D4K]
Capabil= ities: <access denied>
Kernel driver in use: nvidia-gpu
Kerne= l modules: i2c_nvidia_gpu

06:00.0 Non-Volatile memory controller: Sa= ndisk Corp WD Blue SN500 / PC SN520 NVMe SSD (rev 01) (prog-if 02 [NVM Expr= ess])
Subsystem: Sandisk Corp WD Blue SN500 / PC SN520 NVMe SSD
Fla= gs: bus master, fast devsel, latency 0, IRQ 16, NUMA node 0
Memory at b= 4400000 (64-bit, non-prefetchable) [size=3D16K]
Capabilities: <acces= s denied>
Kernel driver in use: nvme
Kernel modules: nvme
07:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/= 8411 PCI Express Gigabit Ethernet Controller (rev 15)
Subsystem: Lenovo= Device 38cd
Flags: bus master, fast devsel, latency 0, IRQ 17
I/O = ports at 3000 [size=3D256]
Memory at b4304000 (64-bit, non-prefetchable= ) [size=3D4K]
Memory at b4300000 (64-bit, non-prefetchable) [size=3D16K= ]
Capabilities: <access denied>
Kernel driver in use: pciback=
Kernel modules: r8169

Sorry = I forgot about lscpi -v

pt., 16 wrz 2022 o 17:08=C2=A0Adam Szewczyk &= lt;szewcson@gmail.com> napisa= =C5=82(a):
Sorry, I always forgot that default answe= r is "answer" to not "answer to all".

My xl dmesg after calling those debug-keys is:
t=3D0 d0: =C2=A08(---)
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{4}/{0= -11} in-flight=3D0 d0: =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec= :78 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 af= f:{0-15}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-= APIC-level =C2=A0 status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XE= N) =C2=A0 =C2=A0IRQ: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002= aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-= APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d3:= 16(-M-),d78: 16(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-le= vel =C2=A0 status=3D010 aff:{2}/{0-11} in-flight=3D1 d0: 17(---),d81: 17(-M= M)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A018 vec:b8 IO-APIC-level =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{0-15}= /{0-11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-= level =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 aff:{1= 0}/{0-11} in-flight=3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 D= MA_MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c#iomm= u_page_fault()
(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 = =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)
(XEN= ) =C2=A0 =C2=A0IRQ: 122 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D030 aff:{0}/{0-11} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: = 123 vec:d8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} = in-flight=3D0 d0:949(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2= =A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:948(-= --)
(XEN) =C2=A0 =C2=A0IRQ: 125 vec:4a PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D010 aff:{6}/{0-11} in-flight=3D0 d78:151(---)
(XEN) =C2=A0 = =C2=A0IRQ: 126 vec:59 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{= 0-11} in-flight=3D0 d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-M= SI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:945(= ---)
(XEN) =C2=A0 =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0s= tatus=3D030 aff:{6}/{0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0= IRQ: 129 vec:71 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} = in-flight=3D0 d0:943(---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X = =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(---)(XEN) =C2=A0 =C2=A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status= =3D030 aff:{10}/{0-11} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ:= 132 vec:89 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{2}/{0-11} in-f= light=3D0 d0:940(---)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:52 PCI-MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d81:151(-M-)=
(XEN) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 = status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2= =A0IRQ: 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-= 15}/{0-11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:93= 6(---)
(XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2= =A0 =C2=A0IRQ: 138 vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 = aff:{2}/{0-11} in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec= :d9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flig= ht=3D0 d3:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2= =A00x22 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 ->= mce_intel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#= intel_thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interru= pt()
(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2= =A0 =C2=A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -= > event_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_in= terrupt()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2= =A0 =C2=A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt inform= ation:
(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D= 0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ =C2=A01 Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2= =A01: vec=3D31 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 tr= ig=3DE mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:=
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D= 0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2= =A05: vec=3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 tr= ig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:=
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D= 0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2= =A08: vec=3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 tr= ig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:=
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00= 000010
(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = 11 Vec136:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_= id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 13 Vec152:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 = dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 15 Vec168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec= =3Da8 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2= =A0 =C2=A0 =C2=A0 Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL sta= tus=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 17 Vec208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 7: vec=3Dd0 delivery=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig= =3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400
= (XEN) =C2=A0 =C2=A0 IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0= trig=3DL mask=3D1 dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000400
(XEN) MSI information:
(XEN) = =C2=A0IOMMU =C2=A0120 vec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000001 mask=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121= vec=3Dc0 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0124 vec=3De8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000100 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D4= a lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0= assert =C2=A0log lowest dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0= MSI-X =C2=A0127 vec=3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest d= est=3D00000010 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 l= owest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000400 mask=3D1/ = =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 a= ssert =C2=A0log lowest dest=3D00000400 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MS= I-X =C2=A0130 vec=3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 low= est =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D1/ =C2= =A0/0
(XEN) =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 asse= rt =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI = =C2=A0 =C2=A0133 vec=3D5a lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest = dest=3D00000004 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0134 vec= =3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask= =3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2=A0ed= ge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?
(XE= N) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert =C2= =A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 = =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3Dd1 lo= west =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0/ = =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3Dd9 lowest =C2=A0edge =C2= =A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) IRQ= information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge =C2= =A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2=A0= =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{10}= /{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 3 = vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0status= =3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec:= 50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(X= EN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D00= 2 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 IO= -APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-= M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D1 d0: 17(---),d87: 17(-MM)
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{= 0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2= =A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, un= bound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 statu= s=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ:= =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 sta= tus=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IR= Q: 122 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-1= 1} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:94= 9(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2= =A0 =C2=A0IRQ: 125 vec:4a PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 = aff:{2}/{0-11} in-flight=3D0 d78:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 126 ve= c:59 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN)= =C2=A0 =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{10}/{0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec= :71 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{10}/{0-11} in-flight= =3D0 d0:943(---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN)= =C2=A0 =C2=A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{8}/{0-11} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:= 89 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0= d0:940(---)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:5a PCI-MSI =C2=A0 =C2=A0 = =C2=A0 =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d87:151(-M-)
(XE= N) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D010 aff:{2}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: = 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-1= 1} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
= (XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ= : 138 vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{2}/{0-11= } in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:d9 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{0}/{0-11} in-flight=3D0 d3:15= 0(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 ->= irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c#= cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_thermal= _interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN)= =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb = -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_chec= k_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(X= EN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -&= gt; spurious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 = Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D31 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 = Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 = Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010
(XEN) = =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 0: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0= trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec16= 8:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Ve= c208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delivery=3D= LoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ = 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_= id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 = dest_id:00000100
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 v= ec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 ma= sk=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc0 lowest =C2=A0= edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(= XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3De= 8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D72 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec= =3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec= =3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI =C2=A0 =C2=A0134= vec=3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000400 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3D6= 2 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3D6a lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) = IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge = =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{= 6}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec= :50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d92: 16(-M-)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status=3D010 aff:{8= }/{0-11} in-flight=3D1 d0: 17(---),d94: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight= =3D0 d0: 18(---),d92: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO= -APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 83(--= -)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 = =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:= {0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 = PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight= =3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
= (XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{2}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ= : 125 vec:72 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11= } in-flight=3D0 d94:151(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/= -X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:946(---= )
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ= : 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-= flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X =C2= =A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:943(---)
(= XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D0= 30 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: 131 = vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight= =3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:89 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:940(---)
(XEN)= =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D= 010 aff:{0}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: 135= vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-11} = mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2=A0= =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
(XE= N) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ:= 138 vec:62 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11}= in-flight=3D0 d92:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:6a PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d92:1= 50(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 ->= ; irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c= #cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_therma= l_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN= ) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb= -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_che= ck_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(= XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -= > spurious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 = Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D31 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000040
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 = Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 = Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 0: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0= trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec16= 8:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Ve= c208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delivery=3D= LoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00= 000100
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ = 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_= id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 = dest_id:00000400
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 v= ec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 ma= sk=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc0 lowest =C2=A0= edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(= XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3De= 8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D72 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec= =3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000400 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec= =3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI =C2=A0 =C2=A0134= vec=3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000400 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000400 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3D6= 2 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3D6a lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) = IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge = =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{= 6}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec= :50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d92: 16(-M-)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status=3D010 aff:{8= }/{0-11} in-flight=3D1 d0: 17(---),d94: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight= =3D0 d0: 18(---),d92: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO= -APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 83(--= -)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 = =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:= {0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 = PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight= =3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
= (XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{2}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ= : 125 vec:72 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11= } in-flight=3D0 d94:151(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/= -X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:946(---= )
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ= : 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{10}/{0-11} in= -flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X = =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:943(---)(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status= =3D030 aff:{0}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: = 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-fl= ight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:89 PCI-MSI/-X =C2= =A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:940(---)
(= XEN) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 statu= s=3D010 aff:{10}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ= : 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0= -11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)<= br>(XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 s= tatus=3D030 aff:{10}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2= =A0IRQ: 138 vec:62 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d92:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:6a PC= I-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{4}/{0-11} in-flight=3D0= d92:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x2= 2 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_i= ntel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_= thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2= =A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> ev= ent_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt= ()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2= =A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt information:<= br>(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Ap= ic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarit= y=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ= =C2=A01 Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec= =3D31 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000040
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic= 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec= =3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic= 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec= =3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00= , Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:<= br>(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri = dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001=
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0= x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec15= 2:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Ve= c168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ = 17 Vec208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delive= ry=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_= id:00000100
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0= IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 = dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec= =3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL ma= sk=3D0 dest_id:00000400

I shutted dow= n all VMs excluding sys-usb (which I need to be able to use keyboard) and O= penBSD HVM befor that command.

My pcidum is:
=

Domai= n /dev/pci0:
=C2=A00:0:0: Intel 82441FX
0x0000: Vendor ID: 8086, Pro= duct ID: 1237
0x0004: Command: 0004, Status: 0000
0x0008: Class: 06= Bridge, Subclass: 00 Host,
Interface: 00, Revision: 02
0x000c: BI= ST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x= 0010: BAR empty (00000000)
0x0014: BAR empty (00000000)
0x0018: BAR= empty (00000000)
0x001c: BAR empty (00000000)
0x0020: BAR empty (0= 0000000)
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000=
0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansi= on ROM Base Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pi= n: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2=A00:1:0: Intel 82371SB ISA 0x0000: Vendor ID: 8086, Product ID: 7000
0x0004: Command: 0004, Stat= us: 0200
0x0008: Class: 06 Bridge, Subclass: 01 ISA,
Interface: 00= , Revision: 00
0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, Cache Line Size: 00
0x0010: BAR empty (00000000)
0x0014: BAR emp= ty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR empty (00000= 000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (00000000)
= 0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: 1af4 Product= ID: 1100
0x0030: Expansion ROM Base Address: 00000000
0x0038: 0000= 0000
0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2= =A00:1:1: Intel 82371SB IDE
0x0000: Vendor ID: 8086, Product ID: 7010 0x0004: Command: 0005, Status: 0280
0x0008: Class: 01 Mass Storage, = Subclass: 01 IDE,
Interface: 80, Revision: 00
0x000c: BIST: 00, He= ader Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x0010: BAR = empty (00000000)
0x0014: BAR empty (00000000)
0x0018: BAR empty (00= 000000)
0x001c: BAR empty (00000000)
0x0020: BAR io addr: 0x0000c20= 0/0x0010
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000=
0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansi= on ROM Base Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pi= n: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2=A00:1:3: Intel 82371AB Power<= br> 0x0000: Vendor ID: 8086, Product ID: 7113
0x0004: Command: 0004, St= atus: 0280
0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous,
I= nterface: 00, Revision: 03
0x000c: BIST: 00, Header Type: 00, Latency T= imer: 00,
Cache Line Size: 00
0x0010: BAR empty (00000000)
0x0= 014: BAR empty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR = empty (00000000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (00= 000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: = 1af4 Product ID: 1100
0x0030: Expansion ROM Base Address: 00000000
= 0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat= : 00
=C2=A00:2:0: XenSource Platform Device
0x0000: Vendor ID: 5853,= Product ID: 0001
0x0004: Command: 0007, Status: 0000
0x0008: Class= : ff (unknown), Subclass: 80 (unknown),
Interface: 00, Revision: 01 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Siz= e: 00
0x0010: BAR io addr: 0x0000c000/0x0100
0x0014: BAR mem prefet= chable 32bit addr: 0xf0000000/0x01000000
0x0018: BAR empty (00000000) 0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x0024= : BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsys= tem Vendor ID: 5853 Product ID: 0001
0x0030: Expansion ROM Base Address= : 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0b Min = Gnt: 00 Max Lat: 00
=C2=A00:3:0: Bochs VGA
0x0000: Vendor ID: 1234, = Product ID: 1111
0x0004: Command: 0007, Status: 0000
0x0008: Class:= 03 Display, Subclass: 00 VGA,
Interface: 00, Revision: 02
0x000c:= BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Size: 00
= 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000
0x0014:= BAR empty (00000000)
0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000=
0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x00= 24: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subs= ystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansion ROM Base Addre= ss: f2000000
0x0038: 00000000
0x003c: Interrupt Pin: 00 Line: 00 Mi= n Gnt: 00 Max Lat: 00
=C2=A00:4:0: Intel 82801DB USB
0x0000: Vendor = ID: 8086, Product ID: 24cd
0x0004: Command: 0006, Status: 0000
0x00= 08: Class: 0c Serial Bus, Subclass: 03 USB,
Interface: 20, Revision: 1= 0
0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line= Size: 00
0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000
0x0014:= BAR empty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR empt= y (00000000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (000000= 00)
0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: 1af4= Product ID: 1100
0x0030: Expansion ROM Base Address: 00000000
0x00= 38: 00000000
0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00=
=C2=A00:6:0: NEC xHCI
0x0000: Vendor ID: 1033, Product ID: 0194
= 0x0004: Command: 0006, Status: 0010
0x0008: Class: 0c Serial Bus, Subc= lass: 03 USB,
Interface: 30, Revision: 03
0x000c: BIST: 00, Header= Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x0010: BAR mem = 64bit addr: 0x00000000f2010000/0x00004000
0x0018: BAR empty (00000000)<= br> 0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x002= 4: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsy= stem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansion ROM Base Addres= s: 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0b Min= Gnt: 00 Max Lat: 00
0x0090: Capability 0x11: Extended Message Signalle= d Interrupts (MSI-X)
Enabled: no; table size 16 (BAR 0:12288)
0x00= 70: Capability 0x05: Message Signalled Interrupts (MSI)
Enabled: yes=C2=A00:7:0: Intel AC 9560
0x0000: Vendor ID: 8086, Product ID: a370<= br> 0x0004: Command: 0006, Status: 0010
0x0008: Class: 02 Network, Subc= lass: 80 Miscellaneous,
Interface: 00, Revision: 10
0x000c: BIST: = 00, Header Type: 80, Latency Timer: 00,
Cache Line Size: 00
0x0010= : BAR mem 64bit addr: 0x00000000f2014000/0x00004000
0x0018: BAR empty (= 00000000)
0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)=
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x0= 02c: Subsystem Vendor ID: 8086 Product ID: 0034
0x0030: Expansion ROM B= ase Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Li= ne: 05 Min Gnt: 00 Max Lat: 00
0x00c8: Capability 0x01: Power Managemen= t
State: D0
0x00d0: Capability 0x05: Message Signalled Interrupts = (MSI)
Enabled: no
0x0040: Capability 0x10: PCI Express
Max Pa= yload Size: 128 / 128 bytes
Max Read Request Size: 512 bytes

BR Adam Szewczyk


pt.,= 16 wrz 2022 o 15:35=C2=A0Roger Pau Monn=C3=A9 <roger.pau@citrix.com> napisa=C5=82= (a):
Again, plea= se keep xen-devel on Cc and don't top-post.

On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote:
> I executed it in dom0 terminal and it prints lots of stuff, but when I= run
> jus xl dmesg it prints almost the same logs. So I'm not sure if I = have
> right output or what I shuld search for to paste it here.

Hm, you should see something like:

(XEN) [ 8729.266567] MSI information:
[...]
(XEN) [ 8709.154958] IRQ information:
[...]

In the output of `xl dmesg`

You can paste the full output of `xl dmesg`, that should be fine.

> Regards Adam.
>
> pt., 16 wrz 2022, 15:09 u=C5=BCytkownik Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> napisa=C5=82:
>
> > Please keep xen-devel in Cc and avoid top-posting.
> >
> > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: > > > >=C2=A0 0:7:0: Intel AC 9560
> > > > 0x0000: Vendor ID: 8086, Product ID: a370
> > > > 0x0004: Command: 0006, Status: 0010
> > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous,<= br> > > > > Interface: 00, Revision: 10
> > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > > > Cache Line Size: 00
> > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x000040= 00
> > > > 0x0018: BAR empty (00000000)
> > > > 0x001c: BAR empty (00000000)
> > > > 0x0020: BAR empty (00000000)
> > > > 0x0024: BAR empty (00000000)
> > > > 0x0028: Cardbus CIS: 00000000
> > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034
> > > > 0x0030: Expansion ROM Base Address: 00000000
> > > > 0x0038: 00000000
> >
> > None of the BARs are at 0x404000 which seems to be where OpenBSD = is
> > trying to load the firmware?
> >
> > I would have to look at the code to figure out exactly what it is=
> > trying to do here (and why it fails).
> >
> > Can you also paste the output from `lspci -v`?

You seem to have missed this bit.

Regards, Roger.
--000000000000d2830905e8d055c7-- From xen-devel-bounces@lists.xenproject.org Fri Sep 16 19:48:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 19:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408128.650830 (Exim 4.92) (envelope-from ) id 1oZHK0-0001J2-2z; Fri, 16 Sep 2022 19:48:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408128.650830; Fri, 16 Sep 2022 19:48:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZHJz-0001Iv-Vp; Fri, 16 Sep 2022 19:48:19 +0000 Received: by outflank-mailman (input) for mailman id 408128; Fri, 16 Sep 2022 19:48:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZHJy-0001Il-VX; Fri, 16 Sep 2022 19:48:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZHJy-0005MG-SC; Fri, 16 Sep 2022 19:48:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZHJy-0004xS-CT; Fri, 16 Sep 2022 19:48:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZHJy-0001yf-By; Fri, 16 Sep 2022 19:48:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/iS1rXrbRXKaLFPzNSzqeza3o9rLNMVnlGD3UmMtocc=; b=Ri9LD2Q7/jBBNkoDQK+d7L+r1C 1r48gWqlDZd+uUzE4SQDdZDlyty28I/kEYo48v/fRX8qkYKiAOGaVpS6iLkOdcK228O40bLO40Yz+ yl8ja8v8WPCOKeAuPvXwkUlwB5kFFoYCKNbApYFHOrw5hmZjNTDlkNH/w5WLRQJte2YE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173238: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=2c17d676e402d75a3a674499342f7ddaccf387bd X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 19:48:18 +0000 flight 173238 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 2c17d676e402d75a3a674499342f7ddaccf387bd baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 322 attempts Testing same since 173234 2022-09-16 10:42:10 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gang Chen Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Nickle Wang Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2652 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 20:51:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 20:51:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408136.650841 (Exim 4.92) (envelope-from ) id 1oZIIg-0008Kf-PH; Fri, 16 Sep 2022 20:51:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408136.650841; Fri, 16 Sep 2022 20:51:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIIg-0008KY-Lt; Fri, 16 Sep 2022 20:51:02 +0000 Received: by outflank-mailman (input) for mailman id 408136; Fri, 16 Sep 2022 20:51:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIIf-0008KS-95 for xen-devel@lists.xen.org; Fri, 16 Sep 2022 20:51:02 +0000 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [2607:f8b0:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4079cc9a-3601-11ed-a31c-8f8a9ae3403f; Fri, 16 Sep 2022 22:50:55 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id u132so22329844pfc.6 for ; Fri, 16 Sep 2022 13:50:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4079cc9a-3601-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=RHhAxueFz7Z6689o5G8Ia/LvsYdt6687RmWD0K5aPcw=; b=IM5M4QQ4hCZs9mi0NZx5GuMCajXsfNFVsgw6UT2ZU1xnvlwM7s1e9/bxNxb7eNn055 uwVH57JrPvhrO8xbTvTDFRx1eNtdEz8SWNV5U7OZhN2fJn3zvuY+dgfiQW17efaLXCJG MaYZJv76i0qWEV6n5FXekYNJt+1E3HgH+tjnZlU9LHcbRAkWrn4la6dbnGg6VHiA3P9u 5X1OGM1ZXilkwT9MyDGcjjwJ0MjLCWhVWeajXiJTBgMCp5nWxiWRgAIKuuSqLvss5c7l XhXExSHnnS5WWUhZmCJA+fKp/cfy4SDK5jjYsABEKM2l/w0r8fMIruQc0/6zhXhQ8a2F KuCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=RHhAxueFz7Z6689o5G8Ia/LvsYdt6687RmWD0K5aPcw=; b=PZt9HtmcHWxeqibUujxKf8dI5frjzn9Kg20uSYo35XyW9/pi7aJl5ym4Wl8Ht/9ZBx QGRfzMypv2yVdZeCHRxV3vPTBiE2JXGBMgOlvZJB/B0vycTEzgNYVXdNM/uY5xSxOCMe QzH8o3KSBL0MFC/3GpfzIBxRKuAEttQXdO6v32Hp219J0GMelr8NQ8ima4+MXapjeLO6 GnHx6e5pZfKBpuGwIaab7epDy8VhKeyW+a9sdD/VFl6nLOYwke/Pp8vTPb7QxKycNTm3 BG+HoUxmm/LQYPqC6n6lbPGV6PyiNmuz6vQwd1a4xkZi59wPBRLZ2068C68MyXGacaco cbuA== X-Gm-Message-State: ACrzQf3AeUozaK57mixRIlxSlK+iU7Yplhlcbf/y282EXlCE+EVYGfYG cBecCnx6lo6Cv7xV6ojatDCaw7KAkhma/SzEDpIbyOrHIpo= X-Google-Smtp-Source: AMsMyM7UmuNV7mUoWUZpz5hl2/Q6WlkN5ZbVOqHqbAN5ttDf6ApG/KgclewD9XxGuHuQ/YSKeYulJSYwJYTikewPa4w= X-Received: by 2002:aa7:8397:0:b0:535:933b:54c with SMTP id u23-20020aa78397000000b00535933b054cmr7111544pfm.38.1663361451390; Fri, 16 Sep 2022 13:50:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Szewczyk Date: Fri, 16 Sep 2022 22:50:39 +0200 Message-ID: Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000717a4005e8d18430" --000000000000717a4005e8d18430 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I made another experiment. I tried if eth pass trough works in HVMs with other OSes. FreeBSD can't configure connection using DHCP. Ubuntu 22.04 kickstart the connection on Live Cd. BR Adam pt., 16 wrz 2022 o 21:26 Adam Szewczyk napisa=C5=82(a)= : > 00:00.0 Host bridge: Intel Corporation 8th Gen Core Processor Host >> Bridge/DRAM Registers (rev 07) >> Subsystem: Lenovo Device 3807 >> Flags: bus master, fast devsel, latency 0 >> Capabilities: >> >> 00:01.0 PCI bridge: Intel Corporation 6th-10th Gen Core Processor PCIe >> Controller (x16) (rev 07) (prog-if 00 [Normal decode]) >> Flags: bus master, fast devsel, latency 0, IRQ 158 >> Bus: primary=3D00, secondary=3D01, subordinate=3D05, sec-latency=3D0 >> I/O behind bridge: 00004000-00004fff [size=3D4K] >> Memory behind bridge: a0000000-b40fffff [size=3D321M] >> Prefetchable memory behind bridge: 00000000b4100000-00000000b41fffff >> [size=3D1M] >> Capabilities: >> Kernel driver in use: pcieport >> >> 00:04.0 Signal processing controller: Intel Corporation Xeon E3-1200 >> v5/E3-1500 v5/6th Gen Core Processor Thermal Subsystem (rev 07) >> Subsystem: Lenovo Device 382f >> Flags: bus master, fast devsel, latency 0, IRQ 16 >> Memory at b4510000 (64-bit, non-prefetchable) [size=3D32K] >> Capabilities: >> Kernel driver in use: proc_thermal >> Kernel modules: processor_thermal_device_pci_legacy >> >> 00:08.0 System peripheral: Intel Corporation Xeon E3-1200 v5/v6 / E3-150= 0 >> v5 / 6th/7th/8th Gen Core Processor Gaussian Mixture Model >> Subsystem: Lenovo Device 3864 >> Flags: bus master, fast devsel, latency 0, IRQ 255 >> Memory at b4524000 (64-bit, non-prefetchable) [size=3D4K] >> Capabilities: >> >> 00:12.0 Signal processing controller: Intel Corporation Cannon Lake PCH >> Thermal Controller (rev 10) >> Subsystem: Lenovo Device 3802 >> Flags: bus master, fast devsel, latency 0, IRQ 16 >> Memory at b4525000 (64-bit, non-prefetchable) [size=3D4K] >> Capabilities: >> Kernel driver in use: intel_pch_thermal >> Kernel modules: intel_pch_thermal >> >> 00:14.0 USB controller: Intel Corporation Cannon Lake PCH USB 3.1 xHCI >> Host Controller (rev 10) (prog-if 30 [XHCI]) >> Subsystem: Lenovo Device 3806 >> Flags: bus master, medium devsel, latency 0, IRQ 16 >> Memory at b4500000 (64-bit, non-prefetchable) [size=3D64K] >> Capabilities: >> Kernel driver in use: pciback >> Kernel modules: xhci_pci >> >> 00:14.2 RAM memory: Intel Corporation Cannon Lake PCH Shared SRAM (rev 1= 0) >> Subsystem: Lenovo Device 3824 >> Flags: bus master, fast devsel, latency 0 >> Memory at b4520000 (64-bit, non-prefetchable) [size=3D8K] >> Memory at b4526000 (64-bit, non-prefetchable) [size=3D4K] >> Capabilities: >> >> 00:14.3 Network controller: Intel Corporation Wireless-AC 9560 [Jefferso= n >> Peak] (rev 10) >> Subsystem: Intel Corporation Device 0034 >> Flags: fast devsel, IRQ 16 >> Memory at b4518000 (64-bit, non-prefetchable) [size=3D16K] >> Capabilities: >> Kernel driver in use: pciback >> Kernel modules: iwlwifi >> >> 00:15.0 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH >> Serial IO I2C Controller #0 (rev 10) >> Subsystem: Lenovo Device 3803 >> Flags: bus master, fast devsel, latency 0, IRQ 16 >> Memory at b4527000 (64-bit, non-prefetchable) [virtual] [size=3D4K] >> Capabilities: >> Kernel driver in use: intel-lpss >> >> 00:15.1 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH >> Serial IO I2C Controller #1 (rev 10) >> Subsystem: Lenovo Device 3804 >> Flags: bus master, fast devsel, latency 0, IRQ 17 >> Memory at b4528000 (64-bit, non-prefetchable) [virtual] [size=3D4K] >> Capabilities: >> Kernel driver in use: intel-lpss >> >> 00:16.0 Communication controller: Intel Corporation Cannon Lake PCH HECI >> Controller (rev 10) >> Subsystem: Lenovo Device 3810 >> Flags: bus master, fast devsel, latency 0, IRQ 174 >> Memory at b4529000 (64-bit, non-prefetchable) [size=3D4K] >> Capabilities: >> Kernel driver in use: mei_me >> Kernel modules: mei_me >> >> 00:17.0 SATA controller: Intel Corporation Cannon Lake Mobile PCH SATA >> AHCI Controller (rev 10) (prog-if 01 [AHCI 1.0]) >> Subsystem: Lenovo Device 3808 >> Flags: bus master, 66MHz, medium devsel, latency 0, IRQ 162 >> Memory at b4522000 (32-bit, non-prefetchable) [size=3D8K] >> Memory at b452e000 (32-bit, non-prefetchable) [size=3D256] >> I/O ports at 5040 [size=3D8] >> I/O ports at 5048 [size=3D4] >> I/O ports at 5020 [size=3D32] >> Memory at b452d000 (32-bit, non-prefetchable) [size=3D2K] >> Capabilities: >> Kernel driver in use: ahci >> >> 00:1d.0 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express Root >> Port #9 (rev f0) (prog-if 00 [Normal decode]) >> Flags: bus master, fast devsel, latency 0, IRQ 159 >> Bus: primary=3D00, secondary=3D06, subordinate=3D06, sec-latency=3D0 >> I/O behind bridge: [disabled] >> Memory behind bridge: b4400000-b44fffff [size=3D1M] >> Prefetchable memory behind bridge: [disabled] >> Capabilities: >> Kernel driver in use: pcieport >> >> 00:1d.5 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express Root >> Port #14 (rev f0) (prog-if 00 [Normal decode]) >> Flags: bus master, fast devsel, latency 0, IRQ 160 >> Bus: primary=3D00, secondary=3D07, subordinate=3D07, sec-latency=3D0 >> I/O behind bridge: 00003000-00003fff [size=3D4K] >> Memory behind bridge: b4300000-b43fffff [size=3D1M] >> Prefetchable memory behind bridge: [disabled] >> Capabilities: >> Kernel driver in use: pcieport >> >> 00:1e.0 Communication controller: Intel Corporation Cannon Lake PCH >> Serial IO UART Host Controller (rev 10) >> Subsystem: Lenovo Device 3813 >> Flags: bus master, fast devsel, latency 0, IRQ 20 >> Memory at b452a000 (64-bit, non-prefetchable) [virtual] [size=3D4K] >> Capabilities: >> Kernel driver in use: intel-lpss >> >> 00:1f.0 ISA bridge: Intel Corporation HM470 Chipset LPC/eSPI Controller >> (rev 10) >> Subsystem: Lenovo Device 380e >> Flags: bus master, medium devsel, latency 0 >> >> 00:1f.3 Audio device: Intel Corporation Cannon Lake PCH cAVS (rev 10) >> Subsystem: Lenovo Device 380f >> Flags: bus master, fast devsel, latency 32, IRQ 175 >> Memory at b451c000 (64-bit, non-prefetchable) [size=3D16K] >> Memory at b4200000 (64-bit, non-prefetchable) [size=3D1M] >> Capabilities: >> Kernel driver in use: snd_hda_intel >> Kernel modules: snd_hda_intel, snd_soc_skl, snd_sof_pci_intel_cnl >> >> 00:1f.4 SMBus: Intel Corporation Cannon Lake PCH SMBus Controller (rev 1= 0) >> Subsystem: Lenovo Device 3814 >> Flags: medium devsel, IRQ 16 >> Memory at b452b000 (64-bit, non-prefetchable) [size=3D256] >> I/O ports at 5000 [size=3D32] >> Kernel driver in use: i801_smbus >> Kernel modules: i2c_i801 >> >> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Cannon Lake PCH >> SPI Controller (rev 10) >> Subsystem: Lenovo Device 3827 >> Flags: bus master, fast devsel, latency 0 >> Memory at fe010000 (32-bit, non-prefetchable) [size=3D4K] >> >> 01:00.0 VGA compatible controller: NVIDIA Corporation TU116M [GeForce GT= X >> 1660 Ti Mobile] (rev a1) (prog-if 00 [VGA controller]) >> Subsystem: Lenovo Device 3ffc >> Flags: bus master, fast devsel, latency 0, IRQ 172 >> Memory at b3000000 (32-bit, non-prefetchable) [size=3D16M] >> Memory at a0000000 (64-bit, prefetchable) [size=3D256M] >> Memory at b0000000 (64-bit, prefetchable) [size=3D32M] >> I/O ports at 4000 [size=3D128] >> Expansion ROM at b2000000 [disabled] [size=3D512K] >> Capabilities: >> Kernel driver in use: nouveau >> Kernel modules: nouveau >> >> 01:00.1 Audio device: NVIDIA Corporation TU116 High Definition Audio >> Controller (rev a1) >> Subsystem: Lenovo Device 3ffc >> Flags: bus master, fast devsel, latency 0, IRQ 17 >> Memory at b4000000 (32-bit, non-prefetchable) [size=3D16K] >> Capabilities: >> Kernel driver in use: snd_hda_intel >> Kernel modules: snd_hda_intel >> >> 01:00.2 USB controller: NVIDIA Corporation TU116 USB 3.1 Host Controller >> (rev a1) (prog-if 30 [XHCI]) >> Subsystem: Lenovo Device 3ffc >> Flags: bus master, fast devsel, latency 0, IRQ 18 >> Memory at b4100000 (64-bit, prefetchable) [size=3D256K] >> Memory at b4140000 (64-bit, prefetchable) [size=3D64K] >> Capabilities: >> Kernel driver in use: pciback >> Kernel modules: xhci_pci >> >> 01:00.3 Serial bus controller [0c80]: NVIDIA Corporation TU116 USB Type-= C >> UCSI Controller (rev a1) >> Subsystem: Lenovo Device 3ffc >> Flags: bus master, fast devsel, latency 0, IRQ 173 >> Memory at b4004000 (32-bit, non-prefetchable) [size=3D4K] >> Capabilities: >> Kernel driver in use: nvidia-gpu >> Kernel modules: i2c_nvidia_gpu >> >> 06:00.0 Non-Volatile memory controller: Sandisk Corp WD Blue SN500 / PC >> SN520 NVMe SSD (rev 01) (prog-if 02 [NVM Express]) >> Subsystem: Sandisk Corp WD Blue SN500 / PC SN520 NVMe SSD >> Flags: bus master, fast devsel, latency 0, IRQ 16, NUMA node 0 >> Memory at b4400000 (64-bit, non-prefetchable) [size=3D16K] >> Capabilities: >> Kernel driver in use: nvme >> Kernel modules: nvme >> >> 07:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. >> RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 15) >> Subsystem: Lenovo Device 38cd >> Flags: bus master, fast devsel, latency 0, IRQ 17 >> I/O ports at 3000 [size=3D256] >> Memory at b4304000 (64-bit, non-prefetchable) [size=3D4K] >> Memory at b4300000 (64-bit, non-prefetchable) [size=3D16K] >> Capabilities: >> Kernel driver in use: pciback >> Kernel modules: r8169 >> > > Sorry I forgot about lscpi -v > > pt., 16 wrz 2022 o 17:08 Adam Szewczyk napisa=C5=82(= a): > >> Sorry, I always forgot that default answer is "answer" to not "answer to >> all". >> >> My xl dmesg after calling those debug-keys is: >> >>> t=3D0 d0: 8(---) >>> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0: 9(---) >>> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >>> mapped, unbound >>> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 14(---) >>> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-M-) >>> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{2}/{0-11} >>> in-flight=3D1 d0: 17(---),d81: 17(-MM) >>> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0: 18(---),d3: 18(-M-) >>> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0: 20(---) >>> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0: 83(---) >>> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >>> iommu.c#iommu_page_fault() >>> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:951(---) >>> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:950(---) >>> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:949(---) >>> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:948(---) >>> (XEN) IRQ: 125 vec:4a PCI-MSI status=3D010 aff:{6}/{0-11} >>> in-flight=3D0 d78:151(---) >>> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:946(---) >>> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:945(---) >>> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:944(---) >>> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:943(---) >>> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:942(---) >>> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0:941(---) >>> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0:940(---) >>> (XEN) IRQ: 133 vec:52 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d81:151(-M-) >>> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:938(---) >>> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:936(---) >>> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0:935(---) >>> (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d3:151(---) >>> (XEN) IRQ: 139 vec:d9 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d3:150(---) >>> (XEN) Direct vector information: >>> (XEN) 0x22 -> irq_move_cleanup_interrupt() >>> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >>> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >>> (XEN) 0xf9 -> pmu_apic_interrupt() >>> (XEN) 0xfa -> apic_timer_interrupt() >>> (XEN) 0xfb -> call_function_interrupt() >>> (XEN) 0xfc -> event_check_interrupt() >>> (XEN) 0xfd -> invalidate_interrupt() >>> (XEN) 0xfe -> error_interrupt() >>> (XEN) 0xff -> spurious_interrupt() >>> (XEN) IO-APIC interrupt information: >>> (XEN) IRQ 0 Vec240: >>> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 1 Vec 49: >>> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000400 >>> (XEN) IRQ 3 Vec 64: >>> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 4 Vec 72: >>> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 5 Vec 80: >>> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 6 Vec 88: >>> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 7 Vec 96: >>> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 8 Vec104: >>> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 9 Vec 57: >>> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 >>> (XEN) IRQ 10 Vec120: >>> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 11 Vec136: >>> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 12 Vec144: >>> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 13 Vec152: >>> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >>> (XEN) IRQ 14 Vec160: >>> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 15 Vec168: >>> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 16 Vec176: >>> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 17 Vec208: >>> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL statu= s=3D1 >>> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 18 Vec184: >>> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >>> (XEN) IRQ 19 Vec161: >>> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >>> (XEN) IRQ 20 Vec224: >>> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 83 Vec 65: >>> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >>> (XEN) MSI information: >>> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D1/ /? >>> (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D0/ /? >>> (XEN) MSI 125 vec=3D4a lowest edge assert log lowest dest=3D000= 00004 >>> mask=3D0/ /? >>> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D1/ /0 >>> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D1/ /0 >>> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D000= 00400 >>> mask=3D1/ /0 >>> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D000= 00400 >>> mask=3D1/ /0 >>> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D000= 00040 >>> mask=3D1/ /0 >>> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D1/ /0 >>> (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D000= 00040 >>> mask=3D1/ /0 >>> (XEN) MSI 133 vec=3D5a lowest edge assert log lowest dest=3D000= 00004 >>> mask=3D0/ /? >>> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D000= 00004 >>> mask=3D0/ /? >>> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D000= 00555 >>> mask=3D0/ /? >>> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D0/ /? >>> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D0/ /? >>> (XEN) MSI 138 vec=3Dd1 lowest edge assert log lowest dest=3D000= 00004 >>> mask=3D0/ /? >>> (XEN) MSI 139 vec=3Dd9 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) IRQ information: >>> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >>> time.c#timer_interrupt() >>> (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{10}/{0-11} >>> in-flight=3D0 d0: 1(---) >>> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 8(---) >>> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0: 9(---) >>> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >>> mapped, unbound >>> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 14(---) >>> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-M-) >>> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D030 aff:{10}/{0-11} >>> in-flight=3D1 d0: 17(---),d87: 17(-MM) >>> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0: 18(---),d3: 18(-M-) >>> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0: 20(---) >>> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0: 83(---) >>> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >>> iommu.c#iommu_page_fault() >>> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:951(---) >>> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:950(---) >>> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:949(---) >>> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:948(---) >>> (XEN) IRQ: 125 vec:4a PCI-MSI status=3D010 aff:{2}/{0-11} >>> in-flight=3D0 d78:151(---) >>> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:946(---) >>> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:945(---) >>> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0:944(---) >>> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0:943(---) >>> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:942(---) >>> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:941(---) >>> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:940(---) >>> (XEN) IRQ: 133 vec:5a PCI-MSI status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d87:151(-M-) >>> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{2}/{0-11} >>> in-flight=3D0 d0:938(---) >>> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:936(---) >>> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:935(---) >>> (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d3:151(---) >>> (XEN) IRQ: 139 vec:d9 PCI-MSI status=3D010 aff:{0}/{0-11} >>> in-flight=3D0 d3:150(---) >>> (XEN) Direct vector information: >>> (XEN) 0x22 -> irq_move_cleanup_interrupt() >>> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >>> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >>> (XEN) 0xf9 -> pmu_apic_interrupt() >>> (XEN) 0xfa -> apic_timer_interrupt() >>> (XEN) 0xfb -> call_function_interrupt() >>> (XEN) 0xfc -> event_check_interrupt() >>> (XEN) 0xfd -> invalidate_interrupt() >>> (XEN) 0xfe -> error_interrupt() >>> (XEN) 0xff -> spurious_interrupt() >>> (XEN) IO-APIC interrupt information: >>> (XEN) IRQ 0 Vec240: >>> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 1 Vec 49: >>> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000400 >>> (XEN) IRQ 3 Vec 64: >>> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 4 Vec 72: >>> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 5 Vec 80: >>> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 6 Vec 88: >>> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 7 Vec 96: >>> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 8 Vec104: >>> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 9 Vec 57: >>> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 >>> (XEN) IRQ 10 Vec120: >>> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 11 Vec136: >>> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 12 Vec144: >>> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 13 Vec152: >>> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >>> (XEN) IRQ 14 Vec160: >>> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 15 Vec168: >>> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 16 Vec176: >>> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 17 Vec208: >>> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL statu= s=3D1 >>> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 18 Vec184: >>> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >>> (XEN) IRQ 19 Vec161: >>> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >>> (XEN) IRQ 20 Vec224: >>> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 83 Vec 65: >>> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 >>> (XEN) MSI information: >>> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D1/ /? >>> (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D000= 00004 >>> mask=3D0/ /? >>> (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D0/ /? >>> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D1/ /0 >>> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D1/ /0 >>> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D1/ /0 >>> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D1/ /0 >>> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D000= 00040 >>> mask=3D1/ /0 >>> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D1/ /0 >>> (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D000= 00040 >>> mask=3D1/ /0 >>> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D000= 00555 >>> mask=3D0/ /? >>> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D0/ /? >>> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D000= 00400 >>> mask=3D0/ /? >>> (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D0/ /? >>> (XEN) IRQ information: >>> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >>> time.c#timer_interrupt() >>> (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{6}/{0-11} >>> in-flight=3D0 d0: 1(---) >>> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 8(---) >>> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 9(---) >>> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >>> mapped, unbound >>> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 14(---) >>> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 16(---),d92: 16(-M-) >>> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{8}/{0-11} >>> in-flight=3D1 d0: 17(---),d94: 17(-MM) >>> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 18(---),d92: 18(-M-) >>> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0: 20(---) >>> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0: 83(---) >>> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >>> iommu.c#iommu_page_fault() >>> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:951(---) >>> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:950(---) >>> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:949(---) >>> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0:948(---) >>> (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d94:151(-M-) >>> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:946(---) >>> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:945(---) >>> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:944(---) >>> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:943(---) >>> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:942(---) >>> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:941(---) >>> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:940(---) >>> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{0}/{0-11} >>> in-flight=3D0 d0:938(---) >>> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:936(---) >>> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0:935(---) >>> (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d92:151(---) >>> (XEN) IRQ: 139 vec:6a PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d92:150(---) >>> (XEN) Direct vector information: >>> (XEN) 0x22 -> irq_move_cleanup_interrupt() >>> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >>> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >>> (XEN) 0xf9 -> pmu_apic_interrupt() >>> (XEN) 0xfa -> apic_timer_interrupt() >>> (XEN) 0xfb -> call_function_interrupt() >>> (XEN) 0xfc -> event_check_interrupt() >>> (XEN) 0xfd -> invalidate_interrupt() >>> (XEN) 0xfe -> error_interrupt() >>> (XEN) 0xff -> spurious_interrupt() >>> (XEN) IO-APIC interrupt information: >>> (XEN) IRQ 0 Vec240: >>> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 1 Vec 49: >>> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000040 >>> (XEN) IRQ 3 Vec 64: >>> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 4 Vec 72: >>> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 5 Vec 80: >>> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 6 Vec 88: >>> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 7 Vec 96: >>> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 8 Vec104: >>> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 9 Vec 57: >>> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 10 Vec120: >>> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 11 Vec136: >>> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 12 Vec144: >>> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 13 Vec152: >>> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >>> (XEN) IRQ 14 Vec160: >>> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 15 Vec168: >>> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 16 Vec176: >>> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 17 Vec208: >>> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL statu= s=3D1 >>> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000100 >>> (XEN) IRQ 18 Vec184: >>> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 19 Vec161: >>> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >>> (XEN) IRQ 20 Vec224: >>> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 83 Vec 65: >>> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >>> (XEN) MSI information: >>> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D1/ /? >>> (XEN) MSI 121 vec=3Dc0 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 122 vec=3Dc8 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 123 vec=3Dd8 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 124 vec=3De8 lowest edge assert log lowest dest=3D000= 00004 >>> mask=3D0/ /? >>> (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D0/ /? >>> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D1/ /0 >>> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D1/ /0 >>> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D000= 00400 >>> mask=3D1/ /0 >>> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D000= 00100 >>> mask=3D1/ /0 >>> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D1/ /0 >>> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D1/ /0 >>> (XEN) MSI-X 132 vec=3D89 lowest edge assert log lowest dest=3D000= 00040 >>> mask=3D1/ /0 >>> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D000= 00400 >>> mask=3D0/ /? >>> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D000= 00555 >>> mask=3D0/ /? >>> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D0/ /? >>> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D000= 00400 >>> mask=3D0/ /? >>> (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D000= 00001 >>> mask=3D0/ /? >>> (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D000= 00010 >>> mask=3D0/ /? >>> (XEN) IRQ information: >>> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >>> time.c#timer_interrupt() >>> (XEN) IRQ: 1 vec:31 IO-APIC-edge status=3D034 aff:{6}/{0-11} >>> in-flight=3D0 d0: 1(---) >>> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 8(---) >>> (XEN) IRQ: 9 vec:39 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 9(---) >>> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >>> mapped, unbound >>> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >>> in-flight=3D0 d0: 14(---) >>> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mappe= d, >>> unbound >>> (XEN) IRQ: 16 vec:b0 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 16(---),d92: 16(-M-) >>> (XEN) IRQ: 17 vec:d0 IO-APIC-level status=3D010 aff:{8}/{0-11} >>> in-flight=3D1 d0: 17(---),d94: 17(-MM) >>> (XEN) IRQ: 18 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0: 18(---),d92: 18(-M-) >>> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 20 vec:e0 IO-APIC-level status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0: 20(---) >>> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0: 83(---) >>> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >>> iommu.c#iommu_page_fault() >>> (XEN) IRQ: 121 vec:c0 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:951(---) >>> (XEN) IRQ: 122 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:950(---) >>> (XEN) IRQ: 123 vec:d8 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:949(---) >>> (XEN) IRQ: 124 vec:e8 PCI-MSI status=3D030 aff:{2}/{0-11} >>> in-flight=3D0 d0:948(---) >>> (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d94:151(-M-) >>> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:946(---) >>> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:945(---) >>> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0:944(---) >>> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{8}/{0-11} >>> in-flight=3D0 d0:943(---) >>> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d0:942(---) >>> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:941(---) >>> (XEN) IRQ: 132 vec:89 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >>> in-flight=3D0 d0:940(---) >>> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D010 aff:{10}/{0-11} >>> in-flight=3D0 d0:938(---) >>> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >>> mapped, unbound >>> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >>> in-flight=3D0 d0:936(---) >>> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{10}/{0-11} >>> in-flight=3D0 d0:935(---) >>> (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} >>> in-flight=3D0 d92:151(---) >>> (XEN) IRQ: 139 vec:6a PCI-MSI status=3D010 aff:{4}/{0-11} >>> in-flight=3D0 d92:150(---) >>> (XEN) Direct vector information: >>> (XEN) 0x22 -> irq_move_cleanup_interrupt() >>> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >>> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >>> (XEN) 0xf9 -> pmu_apic_interrupt() >>> (XEN) 0xfa -> apic_timer_interrupt() >>> (XEN) 0xfb -> call_function_interrupt() >>> (XEN) 0xfc -> event_check_interrupt() >>> (XEN) 0xfd -> invalidate_interrupt() >>> (XEN) 0xfe -> error_interrupt() >>> (XEN) 0xff -> spurious_interrupt() >>> (XEN) IO-APIC interrupt information: >>> (XEN) IRQ 0 Vec240: >>> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 1 Vec 49: >>> (XEN) Apic 0x00, Pin 1: vec=3D31 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000040 >>> (XEN) IRQ 3 Vec 64: >>> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 4 Vec 72: >>> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 5 Vec 80: >>> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 6 Vec 88: >>> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 7 Vec 96: >>> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 8 Vec104: >>> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 9 Vec 57: >>> (XEN) Apic 0x00, Pin 9: vec=3D39 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 10 Vec120: >>> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 11 Vec136: >>> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 12 Vec144: >>> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 13 Vec152: >>> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >>> (XEN) IRQ 14 Vec160: >>> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 15 Vec168: >>> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >>> (XEN) IRQ 16 Vec176: >>> (XEN) Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 17 Vec208: >>> (XEN) Apic 0x00, Pin 17: vec=3Dd0 delivery=3DLoPri dest=3DL statu= s=3D1 >>> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000100 >>> (XEN) IRQ 18 Vec184: >>> (XEN) Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >>> (XEN) IRQ 19 Vec161: >>> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >>> (XEN) IRQ 20 Vec224: >>> (XEN) Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >>> (XEN) IRQ 83 Vec 65: >>> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL statu= s=3D0 >>> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400 >>> >> >> I shutted down all VMs excluding sys-usb (which I need to be able to use >> keyboard) and OpenBSD HVM befor that command. >> >> My pcidum is: >> >> Domain /dev/pci0: >>> 0:0:0: Intel 82441FX >>> 0x0000: Vendor ID: 8086, Product ID: 1237 >>> 0x0004: Command: 0004, Status: 0000 >>> 0x0008: Class: 06 Bridge, Subclass: 00 Host, >>> Interface: 00, Revision: 02 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR empty (00000000) >>> 0x0014: BAR empty (00000000) >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >>> 0:1:0: Intel 82371SB ISA >>> 0x0000: Vendor ID: 8086, Product ID: 7000 >>> 0x0004: Command: 0004, Status: 0200 >>> 0x0008: Class: 06 Bridge, Subclass: 01 ISA, >>> Interface: 00, Revision: 00 >>> 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR empty (00000000) >>> 0x0014: BAR empty (00000000) >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >>> 0:1:1: Intel 82371SB IDE >>> 0x0000: Vendor ID: 8086, Product ID: 7010 >>> 0x0004: Command: 0005, Status: 0280 >>> 0x0008: Class: 01 Mass Storage, Subclass: 01 IDE, >>> Interface: 80, Revision: 00 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR empty (00000000) >>> 0x0014: BAR empty (00000000) >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR io addr: 0x0000c200/0x0010 >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >>> 0:1:3: Intel 82371AB Power >>> 0x0000: Vendor ID: 8086, Product ID: 7113 >>> 0x0004: Command: 0004, Status: 0280 >>> 0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous, >>> Interface: 00, Revision: 03 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR empty (00000000) >>> 0x0014: BAR empty (00000000) >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat: 00 >>> 0:2:0: XenSource Platform Device >>> 0x0000: Vendor ID: 5853, Product ID: 0001 >>> 0x0004: Command: 0007, Status: 0000 >>> 0x0008: Class: ff (unknown), Subclass: 80 (unknown), >>> Interface: 00, Revision: 01 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR io addr: 0x0000c000/0x0100 >>> 0x0014: BAR mem prefetchable 32bit addr: 0xf0000000/0x01000000 >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 5853 Product ID: 0001 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 >>> 0:3:0: Bochs VGA >>> 0x0000: Vendor ID: 1234, Product ID: 1111 >>> 0x0004: Command: 0007, Status: 0000 >>> 0x0008: Class: 03 Display, Subclass: 00 VGA, >>> Interface: 00, Revision: 02 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000 >>> 0x0014: BAR empty (00000000) >>> 0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000 >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: f2000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00 >>> 0:4:0: Intel 82801DB USB >>> 0x0000: Vendor ID: 8086, Product ID: 24cd >>> 0x0004: Command: 0006, Status: 0000 >>> 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, >>> Interface: 20, Revision: 10 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000 >>> 0x0014: BAR empty (00000000) >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00 >>> 0:6:0: NEC xHCI >>> 0x0000: Vendor ID: 1033, Product ID: 0194 >>> 0x0004: Command: 0006, Status: 0010 >>> 0x0008: Class: 0c Serial Bus, Subclass: 03 USB, >>> Interface: 30, Revision: 03 >>> 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR mem 64bit addr: 0x00000000f2010000/0x00004000 >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00 >>> 0x0090: Capability 0x11: Extended Message Signalled Interrupts (MSI-X) >>> Enabled: no; table size 16 (BAR 0:12288) >>> 0x0070: Capability 0x05: Message Signalled Interrupts (MSI) >>> Enabled: yes >>> 0:7:0: Intel AC 9560 >>> 0x0000: Vendor ID: 8086, Product ID: a370 >>> 0x0004: Command: 0006, Status: 0010 >>> 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, >>> Interface: 00, Revision: 10 >>> 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, >>> Cache Line Size: 00 >>> 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 >>> 0x0018: BAR empty (00000000) >>> 0x001c: BAR empty (00000000) >>> 0x0020: BAR empty (00000000) >>> 0x0024: BAR empty (00000000) >>> 0x0028: Cardbus CIS: 00000000 >>> 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 >>> 0x0030: Expansion ROM Base Address: 00000000 >>> 0x0038: 00000000 >>> 0x003c: Interrupt Pin: 01 Line: 05 Min Gnt: 00 Max Lat: 00 >>> 0x00c8: Capability 0x01: Power Management >>> State: D0 >>> 0x00d0: Capability 0x05: Message Signalled Interrupts (MSI) >>> Enabled: no >>> 0x0040: Capability 0x10: PCI Express >>> Max Payload Size: 128 / 128 bytes >>> Max Read Request Size: 512 bytes >>> >> >> BR Adam Szewczyk >> >> >> pt., 16 wrz 2022 o 15:35 Roger Pau Monn=C3=A9 >> napisa=C5=82(a): >> >>> Again, please keep xen-devel on Cc and don't top-post. >>> >>> On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote: >>> > I executed it in dom0 terminal and it prints lots of stuff, but when = I >>> run >>> > jus xl dmesg it prints almost the same logs. So I'm not sure if I hav= e >>> > right output or what I shuld search for to paste it here. >>> >>> Hm, you should see something like: >>> >>> (XEN) [ 8729.266567] MSI information: >>> [...] >>> (XEN) [ 8709.154958] IRQ information: >>> [...] >>> >>> In the output of `xl dmesg` >>> >>> You can paste the full output of `xl dmesg`, that should be fine. >>> >>> > Regards Adam. >>> > >>> > pt., 16 wrz 2022, 15:09 u=C5=BCytkownik Roger Pau Monn=C3=A9 < >>> roger.pau@citrix.com> >>> > napisa=C5=82: >>> > >>> > > Please keep xen-devel in Cc and avoid top-posting. >>> > > >>> > > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: >>> > > > > 0:7:0: Intel AC 9560 >>> > > > > 0x0000: Vendor ID: 8086, Product ID: a370 >>> > > > > 0x0004: Command: 0006, Status: 0010 >>> > > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous, >>> > > > > Interface: 00, Revision: 10 >>> > > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, >>> > > > > Cache Line Size: 00 >>> > > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x00004000 >>> > > > > 0x0018: BAR empty (00000000) >>> > > > > 0x001c: BAR empty (00000000) >>> > > > > 0x0020: BAR empty (00000000) >>> > > > > 0x0024: BAR empty (00000000) >>> > > > > 0x0028: Cardbus CIS: 00000000 >>> > > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034 >>> > > > > 0x0030: Expansion ROM Base Address: 00000000 >>> > > > > 0x0038: 00000000 >>> > > >>> > > None of the BARs are at 0x404000 which seems to be where OpenBSD is >>> > > trying to load the firmware? >>> > > >>> > > I would have to look at the code to figure out exactly what it is >>> > > trying to do here (and why it fails). >>> > > >>> > > Can you also paste the output from `lspci -v`? >>> >>> You seem to have missed this bit. >>> >>> Regards, Roger. >>> >> --000000000000717a4005e8d18430 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I made another experiment. I tried if eth pass trough= works in HVMs with other OSes. FreeBSD can't configure connection usin= g DHCP. Ubuntu 22.04 kickstart the connection on Live Cd.

BR Adam

pt., 16 wrz 2022 o 21:26=C2=A0Adam Szewczyk <szewcson@gmail.com> napisa=C5=82= (a):
00= :00.0 Host bridge: Intel Corporation 8th Gen Core Processor Host Bridge/DRA= M Registers (rev 07)
Subsystem: Lenovo Device 3807
Flags: bus maste= r, fast devsel, latency 0
Capabilities: <access denied>

00= :01.0 PCI bridge: Intel Corporation 6th-10th Gen Core Processor PCIe Contro= ller (x16) (rev 07) (prog-if 00 [Normal decode])
Flags: bus master, fas= t devsel, latency 0, IRQ 158
Bus: primary=3D00, secondary=3D01, subordi= nate=3D05, sec-latency=3D0
I/O behind bridge: 00004000-00004fff [size= =3D4K]
Memory behind bridge: a0000000-b40fffff [size=3D321M]
Prefet= chable memory behind bridge: 00000000b4100000-00000000b41fffff [size=3D1M]<= br> Capabilities: <access denied>
Kernel driver in use: pcieport<= br>
00:04.0 Signal processing controller: Intel Corporation Xeon E3-1200= v5/E3-1500 v5/6th Gen Core Processor Thermal Subsystem (rev 07)
Subsys= tem: Lenovo Device 382f
Flags: bus master, fast devsel, latency 0, IRQ = 16
Memory at b4510000 (64-bit, non-prefetchable) [size=3D32K]
Capab= ilities: <access denied>
Kernel driver in use: proc_thermal
K= ernel modules: processor_thermal_device_pci_legacy

00:08.0 System pe= ripheral: Intel Corporation Xeon E3-1200 v5/v6 / E3-1500 v5 / 6th/7th/8th G= en Core Processor Gaussian Mixture Model
Subsystem: Lenovo Device 3864<= br> Flags: bus master, fast devsel, latency 0, IRQ 255
Memory at b45240= 00 (64-bit, non-prefetchable) [size=3D4K]
Capabilities: <access deni= ed>

00:12.0 Signal processing controller: Intel Corporation Canno= n Lake PCH Thermal Controller (rev 10)
Subsystem: Lenovo Device 3802 Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at b4525000 = (64-bit, non-prefetchable) [size=3D4K]
Capabilities: <access denied&= gt;
Kernel driver in use: intel_pch_thermal
Kernel modules: intel_p= ch_thermal

00:14.0 USB controller: Intel Corporation Cannon Lake PCH= USB 3.1 xHCI Host Controller (rev 10) (prog-if 30 [XHCI])
Subsystem: L= enovo Device 3806
Flags: bus master, medium devsel, latency 0, IRQ 16 Memory at b4500000 (64-bit, non-prefetchable) [size=3D64K]
Capabilit= ies: <access denied>
Kernel driver in use: pciback
Kernel mod= ules: xhci_pci

00:14.2 RAM memory: Intel Corporation Cannon Lake PCH= Shared SRAM (rev 10)
Subsystem: Lenovo Device 3824
Flags: bus mast= er, fast devsel, latency 0
Memory at b4520000 (64-bit, non-prefetchable= ) [size=3D8K]
Memory at b4526000 (64-bit, non-prefetchable) [size=3D4K]=
Capabilities: <access denied>

00:14.3 Network controller:= Intel Corporation Wireless-AC 9560 [Jefferson Peak] (rev 10)
Subsystem= : Intel Corporation Device 0034
Flags: fast devsel, IRQ 16
Memory a= t b4518000 (64-bit, non-prefetchable) [size=3D16K]
Capabilities: <ac= cess denied>
Kernel driver in use: pciback
Kernel modules: iwlwi= fi

00:15.0 Serial bus controller [0c80]: Intel Corporation Cannon La= ke PCH Serial IO I2C Controller #0 (rev 10)
Subsystem: Lenovo Device 38= 03
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at b452= 7000 (64-bit, non-prefetchable) [virtual] [size=3D4K]
Capabilities: <= ;access denied>
Kernel driver in use: intel-lpss

00:15.1 Seri= al bus controller [0c80]: Intel Corporation Cannon Lake PCH Serial IO I2C C= ontroller #1 (rev 10)
Subsystem: Lenovo Device 3804
Flags: bus mast= er, fast devsel, latency 0, IRQ 17
Memory at b4528000 (64-bit, non-pref= etchable) [virtual] [size=3D4K]
Capabilities: <access denied>
= Kernel driver in use: intel-lpss

00:16.0 Communication controller: = Intel Corporation Cannon Lake PCH HECI Controller (rev 10)
Subsystem: L= enovo Device 3810
Flags: bus master, fast devsel, latency 0, IRQ 174 Memory at b4529000 (64-bit, non-prefetchable) [size=3D4K]
Capabilitie= s: <access denied>
Kernel driver in use: mei_me
Kernel module= s: mei_me

00:17.0 SATA controller: Intel Corporation Cannon Lake Mob= ile PCH SATA AHCI Controller (rev 10) (prog-if 01 [AHCI 1.0])
Subsystem= : Lenovo Device 3808
Flags: bus master, 66MHz, medium devsel, latency 0= , IRQ 162
Memory at b4522000 (32-bit, non-prefetchable) [size=3D8K]
= Memory at b452e000 (32-bit, non-prefetchable) [size=3D256]
I/O ports a= t 5040 [size=3D8]
I/O ports at 5048 [size=3D4]
I/O ports at 5020 [s= ize=3D32]
Memory at b452d000 (32-bit, non-prefetchable) [size=3D2K]
= Capabilities: <access denied>
Kernel driver in use: ahci

= 00:1d.0 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express Root Port= #9 (rev f0) (prog-if 00 [Normal decode])
Flags: bus master, fast devse= l, latency 0, IRQ 159
Bus: primary=3D00, secondary=3D06, subordinate=3D= 06, sec-latency=3D0
I/O behind bridge: [disabled]
Memory behind bri= dge: b4400000-b44fffff [size=3D1M]
Prefetchable memory behind bridge: [= disabled]
Capabilities: <access denied>
Kernel driver in use:= pcieport

00:1d.5 PCI bridge: Intel Corporation Cannon Lake PCH PCI = Express Root Port #14 (rev f0) (prog-if 00 [Normal decode])
Flags: bus = master, fast devsel, latency 0, IRQ 160
Bus: primary=3D00, secondary=3D= 07, subordinate=3D07, sec-latency=3D0
I/O behind bridge: 00003000-00003= fff [size=3D4K]
Memory behind bridge: b4300000-b43fffff [size=3D1M]
= Prefetchable memory behind bridge: [disabled]
Capabilities: <access= denied>
Kernel driver in use: pcieport

00:1e.0 Communication= controller: Intel Corporation Cannon Lake PCH Serial IO UART Host Controll= er (rev 10)
Subsystem: Lenovo Device 3813
Flags: bus master, fast d= evsel, latency 0, IRQ 20
Memory at b452a000 (64-bit, non-prefetchable) = [virtual] [size=3D4K]
Capabilities: <access denied>
Kernel dr= iver in use: intel-lpss

00:1f.0 ISA bridge: Intel Corporation HM470 = Chipset LPC/eSPI Controller (rev 10)
Subsystem: Lenovo Device 380e
= Flags: bus master, medium devsel, latency 0

00:1f.3 Audio device: In= tel Corporation Cannon Lake PCH cAVS (rev 10)
Subsystem: Lenovo Device = 380f
Flags: bus master, fast devsel, latency 32, IRQ 175
Memory at = b451c000 (64-bit, non-prefetchable) [size=3D16K]
Memory at b4200000 (64= -bit, non-prefetchable) [size=3D1M]
Capabilities: <access denied>=
Kernel driver in use: snd_hda_intel
Kernel modules: snd_hda_intel,= snd_soc_skl, snd_sof_pci_intel_cnl

00:1f.4 SMBus: Intel Corporation= Cannon Lake PCH SMBus Controller (rev 10)
Subsystem: Lenovo Device 381= 4
Flags: medium devsel, IRQ 16
Memory at b452b000 (64-bit, non-pref= etchable) [size=3D256]
I/O ports at 5000 [size=3D32]
Kernel driver = in use: i801_smbus
Kernel modules: i2c_i801

00:1f.5 Serial bus c= ontroller [0c80]: Intel Corporation Cannon Lake PCH SPI Controller (rev 10)=
Subsystem: Lenovo Device 3827
Flags: bus master, fast devsel, late= ncy 0
Memory at fe010000 (32-bit, non-prefetchable) [size=3D4K]

= 01:00.0 VGA compatible controller: NVIDIA Corporation TU116M [GeForce GTX 1= 660 Ti Mobile] (rev a1) (prog-if 00 [VGA controller])
Subsystem: Lenovo= Device 3ffc
Flags: bus master, fast devsel, latency 0, IRQ 172
Mem= ory at b3000000 (32-bit, non-prefetchable) [size=3D16M]
Memory at a0000= 000 (64-bit, prefetchable) [size=3D256M]
Memory at b0000000 (64-bit, pr= efetchable) [size=3D32M]
I/O ports at 4000 [size=3D128]
Expansion R= OM at b2000000 [disabled] [size=3D512K]
Capabilities: <access denied= >
Kernel driver in use: nouveau
Kernel modules: nouveau

0= 1:00.1 Audio device: NVIDIA Corporation TU116 High Definition Audio Control= ler (rev a1)
Subsystem: Lenovo Device 3ffc
Flags: bus master, fast = devsel, latency 0, IRQ 17
Memory at b4000000 (32-bit, non-prefetchable)= [size=3D16K]
Capabilities: <access denied>
Kernel driver in = use: snd_hda_intel
Kernel modules: snd_hda_intel

01:00.2 USB con= troller: NVIDIA Corporation TU116 USB 3.1 Host Controller (rev a1) (prog-if= 30 [XHCI])
Subsystem: Lenovo Device 3ffc
Flags: bus master, fast d= evsel, latency 0, IRQ 18
Memory at b4100000 (64-bit, prefetchable) [siz= e=3D256K]
Memory at b4140000 (64-bit, prefetchable) [size=3D64K]
Ca= pabilities: <access denied>
Kernel driver in use: pciback
Ker= nel modules: xhci_pci

01:00.3 Serial bus controller [0c80]: NVIDIA C= orporation TU116 USB Type-C UCSI Controller (rev a1)
Subsystem: Lenovo = Device 3ffc
Flags: bus master, fast devsel, latency 0, IRQ 173
Memo= ry at b4004000 (32-bit, non-prefetchable) [size=3D4K]
Capabilities: <= ;access denied>
Kernel driver in use: nvidia-gpu
Kernel modules:= i2c_nvidia_gpu

06:00.0 Non-Volatile memory controller: Sandisk Corp= WD Blue SN500 / PC SN520 NVMe SSD (rev 01) (prog-if 02 [NVM Express])
= Subsystem: Sandisk Corp WD Blue SN500 / PC SN520 NVMe SSD
Flags: bus ma= ster, fast devsel, latency 0, IRQ 16, NUMA node 0
Memory at b4400000 (6= 4-bit, non-prefetchable) [size=3D16K]
Capabilities: <access denied&g= t;
Kernel driver in use: nvme
Kernel modules: nvme

07:00.0 E= thernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI E= xpress Gigabit Ethernet Controller (rev 15)
Subsystem: Lenovo Device 38= cd
Flags: bus master, fast devsel, latency 0, IRQ 17
I/O ports at 3= 000 [size=3D256]
Memory at b4304000 (64-bit, non-prefetchable) [size=3D= 4K]
Memory at b4300000 (64-bit, non-prefetchable) [size=3D16K]
Capa= bilities: <access denied>
Kernel driver in use: pciback
Kerne= l modules: r8169

Sorry I forgot a= bout lscpi -v

pt., 16 wrz 2022 o 17:08=C2=A0Adam Szewczyk <szewcson@gmail.com>= napisa=C5=82(a):
Sorry, I always forgot that defaul= t answer is "answer" to not "answer to all".
=
My xl dmesg after calling those debug-keys is:
t=3D0 d0: =C2=A08(---)
(X= EN) =C2=A0 =C2=A0IRQ: =C2=A0 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff= :{4}/{0-11} in-flight=3D0 d0: =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2= =A010 vec:78 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unb= ound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0s= tatus=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012= vec:90 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound<= br>(XEN) =C2=A0 =C2=A0IRQ: =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status= =3D002 aff:{0-15}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 v= ec:a0 IO-APIC-level =C2=A0 status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(--= -)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0sta= tus=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 v= ec:b0 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16= (---),d3: 16(-M-),d78: 16(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 I= O-APIC-level =C2=A0 status=3D010 aff:{2}/{0-11} in-flight=3D1 d0: 17(---),d= 81: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A018 vec:b8 IO-APIC-level =C2=A0= status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN= ) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{= 0-15}/{0-11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-= APIC-level =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
= (XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 a= ff:{10}/{0-11} in-flight=3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec= :30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c= #iommu_page_fault()
(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)<= br>(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 s= tatus=3D030 aff:{0}/{0-11} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0= IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0= -11} in-flight=3D0 d0:949(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MS= I =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:= 948(---)
(XEN) =C2=A0 =C2=A0IRQ: 125 vec:4a PCI-MSI =C2=A0 =C2=A0 =C2=A0= =C2=A0 status=3D010 aff:{6}/{0-11} in-flight=3D0 d78:151(---)
(XEN) =C2= =A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{= 8}/{0-11} in-flight=3D0 d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 P= CI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:= 945(---)
(XEN) =C2=A0 =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2= =A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 = =C2=A0IRQ: 129 vec:71 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{= 0-11} in-flight=3D0 d0:943(---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-M= SI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(= ---)
(XEN) =C2=A0 =C2=A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0s= tatus=3D030 aff:{10}/{0-11} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2= =A0IRQ: 132 vec:89 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{2}/{0-1= 1} in-flight=3D0 d0:940(---)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:52 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d81:1= 51(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2= =A0 =C2=A0IRQ: 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 = aff:{0-15}/{0-11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI= -MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 = d0:936(---)
(XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2= =A0 =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:935(---)
(XEN) = =C2=A0 =C2=A0IRQ: 138 vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D0= 30 aff:{2}/{0-11} in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 = vec:d9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-f= light=3D0 d3:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 = =C2=A00x22 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -&= gt; mce_intel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel= .c#intel_thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_inte= rrupt()
(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) = =C2=A0 =C2=A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xf= c -> event_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate= _interrupt()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) = =C2=A0 =C2=A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt inf= ormation:
(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0= =C2=A0 Apic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A01 Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A01: vec=3D31 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec= 64:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_i= d:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A05: vec=3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec= 88:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_i= d:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A08: vec=3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec= 57:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_i= d:00000010
(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2= =A0 Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polari= ty=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IR= Q 11 Vec136:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 13 Vec152:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 = dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 15 Vec168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec= =3Da8 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2= =A0 =C2=A0 =C2=A0 Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL sta= tus=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 17 Vec208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 7: vec=3Dd0 delivery=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig= =3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400
= (XEN) =C2=A0 =C2=A0 IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0= trig=3DL mask=3D1 dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000400
(XEN) MSI information:
(XEN) = =C2=A0IOMMU =C2=A0120 vec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000001 mask=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121= vec=3Dc0 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0124 vec=3De8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000100 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D4= a lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0= assert =C2=A0log lowest dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0= MSI-X =C2=A0127 vec=3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest d= est=3D00000010 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 l= owest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000400 mask=3D1/ = =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 a= ssert =C2=A0log lowest dest=3D00000400 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MS= I-X =C2=A0130 vec=3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 low= est =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D1/ =C2= =A0/0
(XEN) =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 asse= rt =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI = =C2=A0 =C2=A0133 vec=3D5a lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest = dest=3D00000004 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0134 vec= =3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask= =3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2=A0ed= ge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?
(XE= N) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert =C2= =A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 = =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3Dd1 lo= west =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0/ = =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3Dd9 lowest =C2=A0edge =C2= =A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) IRQ= information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge =C2= =A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2=A0= =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{10}= /{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 3 = vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0status= =3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec:= 50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(X= EN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D00= 2 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 IO= -APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d3: 16(-M-),d78: 16(-= M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D1 d0: 17(---),d87: 17(-MM)
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{= 0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2= =A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, un= bound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 statu= s=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ:= =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 sta= tus=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IR= Q: 122 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-1= 1} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:94= 9(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2= =A0 =C2=A0IRQ: 125 vec:4a PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 = aff:{2}/{0-11} in-flight=3D0 d78:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 126 ve= c:59 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN)= =C2=A0 =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{10}/{0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec= :71 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{10}/{0-11} in-flight= =3D0 d0:943(---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN)= =C2=A0 =C2=A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{8}/{0-11} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:= 89 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0= d0:940(---)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:5a PCI-MSI =C2=A0 =C2=A0 = =C2=A0 =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d87:151(-M-)
(XE= N) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D010 aff:{2}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: = 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-1= 1} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
= (XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ= : 138 vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{2}/{0-11= } in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:d9 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{0}/{0-11} in-flight=3D0 d3:15= 0(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 ->= irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c#= cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_thermal= _interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN)= =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb = -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_chec= k_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(X= EN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -&= gt; spurious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 = Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D31 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 = Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 = Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000010
(XEN) = =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 0: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0= trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec16= 8:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Ve= c208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delivery=3D= LoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ = 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_= id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 = dest_id:00000100
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 v= ec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 ma= sk=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc0 lowest =C2=A0= edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(= XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3De= 8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D72 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec= =3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec= =3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI =C2=A0 =C2=A0134= vec=3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000400 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3D6= 2 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3D6a lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) = IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge = =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{= 6}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec= :50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d92: 16(-M-)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status=3D010 aff:{8= }/{0-11} in-flight=3D1 d0: 17(---),d94: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight= =3D0 d0: 18(---),d92: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO= -APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 83(--= -)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 = =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:= {0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 = PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight= =3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
= (XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{2}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ= : 125 vec:72 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11= } in-flight=3D0 d94:151(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/= -X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:946(---= )
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ= : 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-= flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X =C2= =A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:943(---)
(= XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D0= 30 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: 131 = vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight= =3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:89 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:940(---)
(XEN)= =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D= 010 aff:{0}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: 135= vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-11} = mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2=A0= =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
(XE= N) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status= =3D030 aff:{10}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ:= 138 vec:62 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11}= in-flight=3D0 d92:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:6a PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d92:1= 50(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 ->= ; irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c= #cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_therma= l_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN= ) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb= -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_che= ck_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(= XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -= > spurious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 = Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D31 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000040
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 = Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, = Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 = Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN) =C2=A0 = =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri dest=3DL st= atus=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 0: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0= trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec16= 8:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Ve= c208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delivery=3D= LoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00= 000100
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ = 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_= id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 = dest_id:00000400
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 v= ec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 ma= sk=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc0 lowest =C2=A0= edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(= XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dc8 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0123 vec=3Dd8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3De= 8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0125 vec=3D72 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec= =3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000400 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000100 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec= =3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask= =3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) = =C2=A0MSI-X =C2=A0132 vec=3D89 lowest =C2=A0edge =C2=A0 assert =C2=A0log lo= west dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI =C2=A0 =C2=A0134= vec=3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000400 = mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2= =A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?(XEN) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert= =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2= =A0 =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest des= t=3D00000400 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3D6= 2 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0139 vec=3D6a lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) = IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge = =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 1 vec:31 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{= 6}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound=
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0statu= s=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec= :50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:39 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b0 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d92: 16(-M-)
(XEN)= =C2=A0 =C2=A0IRQ: =C2=A017 vec:d0 IO-APIC-level =C2=A0 status=3D010 aff:{8= }/{0-11} in-flight=3D1 d0: 17(---),d94: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:b8 IO-APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight= =3D0 d0: 18(---),d92: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO= -APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e0 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{10}/{0-11} in-flight=3D0 d0: 83(--= -)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2= =A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 = =C2=A0IRQ: 121 vec:c0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:= {0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:c8 = PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight= =3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:d8 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
= (XEN) =C2=A0 =C2=A0IRQ: 124 vec:e8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 stat= us=3D030 aff:{2}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ= : 125 vec:72 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11= } in-flight=3D0 d94:151(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/= -X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:946(---= )
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0stat= us=3D030 aff:{4}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ= : 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{10}/{0-11} in= -flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X = =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:943(---)(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status= =3D030 aff:{0}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: = 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-fl= ight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:89 PCI-MSI/-X =C2= =A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:940(---)
(= XEN) =C2=A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 statu= s=3D010 aff:{10}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ= : 135 vec:a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0= -11} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)<= br>(XEN) =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 s= tatus=3D030 aff:{10}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2= =A0IRQ: 138 vec:62 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d92:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 139 vec:6a PC= I-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{4}/{0-11} in-flight=3D0= d92:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x2= 2 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_i= ntel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_= thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2= =A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> ev= ent_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt= ()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2= =A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt information:<= br>(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Ap= ic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarit= y=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ= =C2=A01 Vec 49:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec= =3D31 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000040
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic= 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec= =3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic= 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec= =3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec 57:
(XEN)= =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3D39 delivery=3DLoPri des= t=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000004(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00= , Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:<= br>(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri = dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001=
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0= x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr= =3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec15= 2:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoP= ri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000= 001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Ve= c168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec176:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 16: vec=3Db0 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ = 17 Vec208:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd0 delive= ry=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_= id:00000100
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec184:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 18: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0= IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 = dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec224:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 20: vec=3De0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec= =3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL ma= sk=3D0 dest_id:00000400

I shutted dow= n all VMs excluding sys-usb (which I need to be able to use keyboard) and O= penBSD HVM befor that command.

My pcidum is:
=

Domai= n /dev/pci0:
=C2=A00:0:0: Intel 82441FX
0x0000: Vendor ID: 8086, Pro= duct ID: 1237
0x0004: Command: 0004, Status: 0000
0x0008: Class: 06= Bridge, Subclass: 00 Host,
Interface: 00, Revision: 02
0x000c: BI= ST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x= 0010: BAR empty (00000000)
0x0014: BAR empty (00000000)
0x0018: BAR= empty (00000000)
0x001c: BAR empty (00000000)
0x0020: BAR empty (0= 0000000)
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000=
0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansi= on ROM Base Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pi= n: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2=A00:1:0: Intel 82371SB ISA 0x0000: Vendor ID: 8086, Product ID: 7000
0x0004: Command: 0004, Stat= us: 0200
0x0008: Class: 06 Bridge, Subclass: 01 ISA,
Interface: 00= , Revision: 00
0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, Cache Line Size: 00
0x0010: BAR empty (00000000)
0x0014: BAR emp= ty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR empty (00000= 000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (00000000)
= 0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: 1af4 Product= ID: 1100
0x0030: Expansion ROM Base Address: 00000000
0x0038: 0000= 0000
0x003c: Interrupt Pin: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2= =A00:1:1: Intel 82371SB IDE
0x0000: Vendor ID: 8086, Product ID: 7010 0x0004: Command: 0005, Status: 0280
0x0008: Class: 01 Mass Storage, = Subclass: 01 IDE,
Interface: 80, Revision: 00
0x000c: BIST: 00, He= ader Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x0010: BAR = empty (00000000)
0x0014: BAR empty (00000000)
0x0018: BAR empty (00= 000000)
0x001c: BAR empty (00000000)
0x0020: BAR io addr: 0x0000c20= 0/0x0010
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000=
0x002c: Subsystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansi= on ROM Base Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pi= n: 00 Line: 00 Min Gnt: 00 Max Lat: 00
=C2=A00:1:3: Intel 82371AB Power<= br> 0x0000: Vendor ID: 8086, Product ID: 7113
0x0004: Command: 0004, St= atus: 0280
0x0008: Class: 06 Bridge, Subclass: 80 Miscellaneous,
I= nterface: 00, Revision: 03
0x000c: BIST: 00, Header Type: 00, Latency T= imer: 00,
Cache Line Size: 00
0x0010: BAR empty (00000000)
0x0= 014: BAR empty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR = empty (00000000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (00= 000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: = 1af4 Product ID: 1100
0x0030: Expansion ROM Base Address: 00000000
= 0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0a Min Gnt: 00 Max Lat= : 00
=C2=A00:2:0: XenSource Platform Device
0x0000: Vendor ID: 5853,= Product ID: 0001
0x0004: Command: 0007, Status: 0000
0x0008: Class= : ff (unknown), Subclass: 80 (unknown),
Interface: 00, Revision: 01 0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Siz= e: 00
0x0010: BAR io addr: 0x0000c000/0x0100
0x0014: BAR mem prefet= chable 32bit addr: 0xf0000000/0x01000000
0x0018: BAR empty (00000000) 0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x0024= : BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsys= tem Vendor ID: 5853 Product ID: 0001
0x0030: Expansion ROM Base Address= : 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0b Min = Gnt: 00 Max Lat: 00
=C2=A00:3:0: Bochs VGA
0x0000: Vendor ID: 1234, = Product ID: 1111
0x0004: Command: 0007, Status: 0000
0x0008: Class:= 03 Display, Subclass: 00 VGA,
Interface: 00, Revision: 02
0x000c:= BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line Size: 00
= 0x0010: BAR mem prefetchable 32bit addr: 0xf1000000/0x01000000
0x0014:= BAR empty (00000000)
0x0018: BAR mem 32bit addr: 0xf2018000/0x00001000=
0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x00= 24: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subs= ystem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansion ROM Base Addre= ss: f2000000
0x0038: 00000000
0x003c: Interrupt Pin: 00 Line: 00 Mi= n Gnt: 00 Max Lat: 00
=C2=A00:4:0: Intel 82801DB USB
0x0000: Vendor = ID: 8086, Product ID: 24cd
0x0004: Command: 0006, Status: 0000
0x00= 08: Class: 0c Serial Bus, Subclass: 03 USB,
Interface: 20, Revision: 1= 0
0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
Cache Line= Size: 00
0x0010: BAR mem 32bit addr: 0xf2019000/0x00001000
0x0014:= BAR empty (00000000)
0x0018: BAR empty (00000000)
0x001c: BAR empt= y (00000000)
0x0020: BAR empty (00000000)
0x0024: BAR empty (000000= 00)
0x0028: Cardbus CIS: 00000000
0x002c: Subsystem Vendor ID: 1af4= Product ID: 1100
0x0030: Expansion ROM Base Address: 00000000
0x00= 38: 00000000
0x003c: Interrupt Pin: 04 Line: 05 Min Gnt: 00 Max Lat: 00=
=C2=A00:6:0: NEC xHCI
0x0000: Vendor ID: 1033, Product ID: 0194
= 0x0004: Command: 0006, Status: 0010
0x0008: Class: 0c Serial Bus, Subc= lass: 03 USB,
Interface: 30, Revision: 03
0x000c: BIST: 00, Header= Type: 00, Latency Timer: 00,
Cache Line Size: 00
0x0010: BAR mem = 64bit addr: 0x00000000f2010000/0x00004000
0x0018: BAR empty (00000000)<= br> 0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)
0x002= 4: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x002c: Subsy= stem Vendor ID: 1af4 Product ID: 1100
0x0030: Expansion ROM Base Addres= s: 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Line: 0b Min= Gnt: 00 Max Lat: 00
0x0090: Capability 0x11: Extended Message Signalle= d Interrupts (MSI-X)
Enabled: no; table size 16 (BAR 0:12288)
0x00= 70: Capability 0x05: Message Signalled Interrupts (MSI)
Enabled: yes=C2=A00:7:0: Intel AC 9560
0x0000: Vendor ID: 8086, Product ID: a370<= br> 0x0004: Command: 0006, Status: 0010
0x0008: Class: 02 Network, Subc= lass: 80 Miscellaneous,
Interface: 00, Revision: 10
0x000c: BIST: = 00, Header Type: 80, Latency Timer: 00,
Cache Line Size: 00
0x0010= : BAR mem 64bit addr: 0x00000000f2014000/0x00004000
0x0018: BAR empty (= 00000000)
0x001c: BAR empty (00000000)
0x0020: BAR empty (00000000)=
0x0024: BAR empty (00000000)
0x0028: Cardbus CIS: 00000000
0x0= 02c: Subsystem Vendor ID: 8086 Product ID: 0034
0x0030: Expansion ROM B= ase Address: 00000000
0x0038: 00000000
0x003c: Interrupt Pin: 01 Li= ne: 05 Min Gnt: 00 Max Lat: 00
0x00c8: Capability 0x01: Power Managemen= t
State: D0
0x00d0: Capability 0x05: Message Signalled Interrupts = (MSI)
Enabled: no
0x0040: Capability 0x10: PCI Express
Max Pa= yload Size: 128 / 128 bytes
Max Read Request Size: 512 bytes

BR Adam Szewczyk


pt.,= 16 wrz 2022 o 15:35=C2=A0Roger Pau Monn=C3=A9 <roger.pau@citrix.com> napisa=C5=82= (a):
Again, plea= se keep xen-devel on Cc and don't top-post.

On Fri, Sep 16, 2022 at 03:19:30PM +0200, Adam Szewczyk wrote:
> I executed it in dom0 terminal and it prints lots of stuff, but when I= run
> jus xl dmesg it prints almost the same logs. So I'm not sure if I = have
> right output or what I shuld search for to paste it here.

Hm, you should see something like:

(XEN) [ 8729.266567] MSI information:
[...]
(XEN) [ 8709.154958] IRQ information:
[...]

In the output of `xl dmesg`

You can paste the full output of `xl dmesg`, that should be fine.

> Regards Adam.
>
> pt., 16 wrz 2022, 15:09 u=C5=BCytkownik Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> napisa=C5=82:
>
> > Please keep xen-devel in Cc and avoid top-posting.
> >
> > On Fri, Sep 16, 2022 at 02:35:17PM +0200, Adam Szewczyk wrote: > > > >=C2=A0 0:7:0: Intel AC 9560
> > > > 0x0000: Vendor ID: 8086, Product ID: a370
> > > > 0x0004: Command: 0006, Status: 0010
> > > > 0x0008: Class: 02 Network, Subclass: 80 Miscellaneous,<= br> > > > > Interface: 00, Revision: 10
> > > > 0x000c: BIST: 00, Header Type: 80, Latency Timer: 00, > > > > Cache Line Size: 00
> > > > 0x0010: BAR mem 64bit addr: 0x00000000f2014000/0x000040= 00
> > > > 0x0018: BAR empty (00000000)
> > > > 0x001c: BAR empty (00000000)
> > > > 0x0020: BAR empty (00000000)
> > > > 0x0024: BAR empty (00000000)
> > > > 0x0028: Cardbus CIS: 00000000
> > > > 0x002c: Subsystem Vendor ID: 8086 Product ID: 0034
> > > > 0x0030: Expansion ROM Base Address: 00000000
> > > > 0x0038: 00000000
> >
> > None of the BARs are at 0x404000 which seems to be where OpenBSD = is
> > trying to load the firmware?
> >
> > I would have to look at the code to figure out exactly what it is=
> > trying to do here (and why it fails).
> >
> > Can you also paste the output from `lspci -v`?

You seem to have missed this bit.

Regards, Roger.
--000000000000717a4005e8d18430-- From xen-devel-bounces@lists.xenproject.org Fri Sep 16 21:12:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 21:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408145.650855 (Exim 4.92) (envelope-from ) id 1oZId0-0002Rq-N3; Fri, 16 Sep 2022 21:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408145.650855; Fri, 16 Sep 2022 21:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZId0-0002Rj-K7; Fri, 16 Sep 2022 21:12:02 +0000 Received: by outflank-mailman (input) for mailman id 408145; Fri, 16 Sep 2022 21:12:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIcz-0002RZ-A1; Fri, 16 Sep 2022 21:12:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIcz-0006qr-7G; Fri, 16 Sep 2022 21:12:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIcy-00013r-KM; Fri, 16 Sep 2022 21:12:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZIcy-0003iI-Js; Fri, 16 Sep 2022 21:12:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=krgILxrjpLSeFHCfD+mXTrB/Q31ptRvwwTTyF5UblQk=; b=Iqcs9iJ/Kic/kb7ewd1ybsCquI k0uli2JgtA5Do7Qnz7AhRK1zlo+loyVbzqV7ug3sXRZC+5Ixxy3FNfG3RycmzgtDZEVMNBe85sQgT TA8aoSKmUjgfoTDc7YN0p/KqhRHDYK/r2yO07oZJsmsbv/WoEIlEgetsCbZ4n42vDxp8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173235: regressions - FAIL X-Osstest-Failures: linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Fri, 16 Sep 2022 21:12:00 +0000 flight 173235 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173235/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172128 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-xl-credit2 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 43 days Failing since 172384 2022-08-11 11:13:58 Z 36 days 78 attempts Testing same since 173213 2022-09-15 15:14:56 Z 1 days 3 attempts ------------------------------------------------------------ 544 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17161 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 16 21:35:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 21:35:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408154.650865 (Exim 4.92) (envelope-from ) id 1oZIzc-0004v9-Lt; Fri, 16 Sep 2022 21:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408154.650865; Fri, 16 Sep 2022 21:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIzc-0004v2-J7; Fri, 16 Sep 2022 21:35:24 +0000 Received: by outflank-mailman (input) for mailman id 408154; Fri, 16 Sep 2022 21:35:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZIza-0004uw-SH for xen-devel@lists.xenproject.org; Fri, 16 Sep 2022 21:35:23 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7635e80b-3607-11ed-9761-273f2230c3a0; Fri, 16 Sep 2022 23:35:20 +0200 (CEST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28GLDsai029988; Fri, 16 Sep 2022 21:35:18 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jm8xcbn2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Sep 2022 21:35:18 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28GJmR69016348; Fri, 16 Sep 2022 21:35:16 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2109.outbound.protection.outlook.com [104.47.70.109]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jm8xewcyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Sep 2022 21:35:16 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DS0PR10MB6150.namprd10.prod.outlook.com (2603:10b6:8:c6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Fri, 16 Sep 2022 21:35:15 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::70bc:4817:75d6:48d3]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::70bc:4817:75d6:48d3%6]) with mapi id 15.20.5632.017; Fri, 16 Sep 2022 21:35:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7635e80b-3607-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=emhWqIyC7PTSoMg/ElSrz0uYX6lmAr6CSIuPDXtAY+0=; b=PnEgi2YVhJnC1oB7K+I5esOX1ri7eqEI3XOb+wMZdKrf+BdzE9GfwaOIrTjUGAxM++lT 9xzvRppP+cC2TyOe4kgPmtoUIEu2+XnAoTsM1PVr8Blnd00qhuvKVZPxm9xIvfQ5du50 MKDNwaeC+iaygVw2GwvS5xZAnVqHBdlWRYA7ALezdNowjotSXEGYLg8LHSOaOq7yslR4 uKf5Tz9NNKVGrsovbUouz9xJc4C9AXs/KLaO9mHmEPimVtN49EoXTVKX5oTe6vm9DDiP yrZ0Mgg8pQMWPfENhdAamXkAvVnqPYaOpsIKAaJ6kPMu3uzN/NxmZ2FZuxfuFr7G9T11 Bw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNry4+EKkKSOKiDLSUOje3tphoMzaMCdRTo1M7NSCD5Okk0rawcqBYzmD61IJO37wJyQTcjWmD/XUpUOtVOS2kktDO+d6VvVbeQNs08E2QHBsKZJ4RNHOoBMJiUFSIn1i80UNWWG6FrNarF997UbA0P6UxM37gzpSYnwt90ixbuJxIpdWi3fZVPL2XHT/TqdF02TZXOKYIVHE/vgCX0LHyf32ZdSuzBBClKlsiu3kFbXd0P6g25OXX+ixsEMY+iwSTp7xZk8zgTmCQj7u3tkyCnPc73t/3qN94fZvmCXuy/CPjAPyLuiKZ4ItgG1XMyuYPu/KSPp+WP1+8DrhFk4dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=emhWqIyC7PTSoMg/ElSrz0uYX6lmAr6CSIuPDXtAY+0=; b=UIVHpgfFra5d85bbZ35P10sHgxVYusGy7XriQjd9L05Fi9uuCJ+2dPxoPbDbORByYkORzYSRguqwNJN/WI8GCsql07mxUwdngEFmq7uw+wJgELBbkc6vd2Qt9DNizkLAiO5u2uJ3l+fC04+C4/YsqEyWHWwqdjq1QlMCBtnpsvdEyEDL1/gwAkDQA3D+am1CDRdnKj3OAI0Xysb0LDYq9al2AAZeFupCGtenjCF7gsb4vdHgnUt07IQYoV2Lw3Dn9cKKHZUd7H9vzLGU/vbWhxFS5SxSvdykka+z+xfon6joWGU6fmSe/ngo0LQ6q1t4ZD6iMJa0cUzvh1SmTju+Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=emhWqIyC7PTSoMg/ElSrz0uYX6lmAr6CSIuPDXtAY+0=; b=jnnPI22lgV89A2VWV4VuKxtFcwSs184uEElE1PepY6Ik5ad4Lb9FlTNU7QCiI40r1QHQGp5TBvsg72XPIWHs2MvMPgc0BZxBDLELyTmSxCzWDkA3AmU1b2Ld2JzLWC4kpmpmtVXbRaLN8AjRYCenxH7Yl9orl0HXcMbOGGHpiYc= Message-ID: <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> Date: Fri, 16 Sep 2022 17:35:12 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Jan Beulich , Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> From: Boris Ostrovsky Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load In-Reply-To: <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR07CA0014.namprd07.prod.outlook.com (2603:10b6:208:1a0::24) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|DS0PR10MB6150:EE_ X-MS-Office365-Filtering-Correlation-Id: b94441ba-1aac-4454-b5c3-08da982b57d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DcifciAKfO7yvpmVmwaYYcruwy7guC632I1uSl4CqXSIts2dcaeGIddNhQishrz8sa/5bZfC4ctk/MBIChRbLjzI4lUNPEgTXNotCWoxDbh6e6SxMKUPKuiPjhzt8OHBe6t1X+wxeTU9flhpqL2o+SK552fanLtxBUt6xKz+Id0cHTPyTAhJP7/GgRmzyeMz/eUH03+HEAPTmaTShX8MZPWBW9fMi6V6cgFZXc2yDI0GcczEqIdwR8fIsEQ51MyMVXV/9QFDsaKUsCTgB9kUfywZEhWMLNAJypzKd7WBJrW1UVTd88Z6Zi4ewMXic+w0vBNKGtnENqRHohw+OIBcTY8FbLW5CdB8w9o9to2ot5/o4+YzrtXo08Hp23qePyYjnZya4LIbgDUFLwbh+MuUSLmJLCqkz+44aQNtFgnb5IT9DX7uXtrRlSZopy5R0/sKcuzkaJWWbvqZJAPum+Uvwj8KGmrhjH/rn+Db4AG9VVth/68JaG6gHe7UYXz5iP9Q0x+z+gzeBe4n3pUz1qlq0xAjPPgBnKnQY9C51P86R/8mBV0MWVxvbnA1x+hLVgXOzpgqSjnObhf7ur5H0tgmuFkW9MBjRGIu+vrEhmKtxCMrvqBTxTV+0nnmKFetGVrc/PlCeSv1OSVBVovP2IuMr7kjMv4nE+D6wydoIC9nmNC9FxRsQOKlxItBoxSeJ6RZCcemIzuQgrPqo6XQBeVcLPTNUvp88MT/BtD2zhNo/FsQqcDHfvUntt3EttOuUGCjNaliq+GiLzjin7QVjcb8/zVIiqUtged2WVjxdgNG+WA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(31696002)(66946007)(186003)(8676002)(31686004)(66476007)(478600001)(5660300002)(54906003)(38100700002)(44832011)(66556008)(6666004)(8936002)(110136005)(2906002)(316002)(6512007)(86362001)(53546011)(2616005)(6506007)(41300700001)(26005)(83380400001)(36756003)(6486002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak9wZXJrR2t6bTM2SEFkUzlLa3RSR0VRcE9jQU5PNHRva2QwWmsxT2V6U041?= =?utf-8?B?NFRMSnVVTzlCanNHWHhJTitRWU5IOHFSNkp4VmRLS3UydjhpS2ZHdnRFZDFx?= =?utf-8?B?M1BiYkJQRzcrRHhwZ0pBMS9LdGlMNktMUnlLSzU3T1VOcXNJTFRhSzZQRUNu?= =?utf-8?B?MUF2RVdFK2lSV3B2Z1ZKenNybVZXWnhlMkNhWFhwK2FUMk5yMEhNajVTU01r?= =?utf-8?B?US9JcU01SnVnTDZ0U3hNOUxnWUhiczhtUlZQY0NsQzF2NzNhYVAzSlQreVhQ?= =?utf-8?B?WWZ0S3hBOEl6V01YRXBvaWNCNUJYdVJ3RjYra0NrME5OSFlkdjdIT2N1NDBP?= =?utf-8?B?ZFRENWt5V2FpUWgwRThTVnIwOG9Uc2Vuazhjb0dORDJ4QVZkLytvZzlvWVFW?= =?utf-8?B?aGxGRkFCYWlzY3JDY3lSMHdYelF0d0hpRVd0eml4Q0piSW1PeXhBZllwaFpl?= =?utf-8?B?dWwwVkxKbVVTK3o2bmtGc3JQU0RaS3hSSkdZclFKZndzMzlxVVJmeE04cDdo?= =?utf-8?B?UmVPc0cySkg2cmdmTkxIc3ZWVVNLemhvRytqL29jTU9pV0E0ZEhzQ28yckpw?= =?utf-8?B?c2xwWEdQWVJkTTdOWnF6UExIelBoVHVnRW9rSjNXKzQyQ0VTblBhbXVOYUtH?= =?utf-8?B?R2NhcFpOWkNQaGRqSTNMNGpTcHdMKzA3WmMzR28xV21xeVNUMEJLRXVhUTQ0?= =?utf-8?B?SkIwL0pEaGsrTVBmZ0NMVUE3STRkS3lEQ1llYTdZbE9aa1VydGMrMW03eFh4?= =?utf-8?B?UkE2UDhGbUdTcEtGVmoyU0VxRTBBQTVlbGhQT1A0UTMwZXhPeHA3LzZwdUNB?= =?utf-8?B?S3lRcjZsUWVlY1N3bk5ESDh3eHRPancwQVhoWVptRC80ZzIvUG5qQkIrWjgy?= =?utf-8?B?RldqZ0lCS0J3aW5xMnlQbXZCRkpMbm5oZFNacm5PeVVBZE82QUJBV3hrMEtk?= =?utf-8?B?aXdrNDVtZ3BrcEd0c2s3eThaVngzL0hmaGV0WVp2Y1ZxM1AwTmpWK0VZb1FN?= =?utf-8?B?OVdQRjloME1UNXhTV0thVFB5Qk9XMEk4Nk9ZVFBVVEdLV1hSU01ib0srRFhM?= =?utf-8?B?SW1obFEwbEdYaFNiY3BNSG1DU1o1Y3ZldVpkditoY0xXYXkybHlCOUFFelN1?= =?utf-8?B?bEZZay9MYnRGZXh6U0gzSkdOWThlQ2xBVDlxOWVWT3JMVEZrMy9KY1FabmpY?= =?utf-8?B?NTM5TGhYRzQybThSZUhxdkJ0dlF6NmU0elI4b2E1M1BSdDJlM2l2cUVIVzlq?= =?utf-8?B?enppbzBmcDIxZUUyWGV6OHZHQk1RNkRkQWlMQS84Vng1WmVJa0hzNzFEUG5m?= =?utf-8?B?K0pneDIvM3pkQTg4SDJkK1h1d1ZZKzQ0VEtxekRza0QwOWtOaFFxWXBFUHZ5?= =?utf-8?B?bXBuNnZjZUFoMmxYa0NWNEtGRlI3UU50QzdsME5IZHZTdWo4R1lCbjRoUWs5?= =?utf-8?B?NXIwcWRTWVlvbUl3MDJNaXB2Vm1qYU01OGtiZXFlaFBlcHB4ODRVZHVkakJU?= =?utf-8?B?bjRBbkhMYVBzVmhLa3dkQmM3MGV0UkRBSjJ5T0haME9jZEEwNWhGanIxeWVs?= =?utf-8?B?WE9UWTlDMlBxVElvazdLd2RZWDkvWW5uUm00NWdyYXh0OS90bHExRnM1UDdW?= =?utf-8?B?QUlja3F5MHF6bXRiZkpUQkNPU3N2T2dXME96cEtQcG0rWjVuMFFOWXEwR201?= =?utf-8?B?aTBwUnRkQ2tWdWJkVXY1cTFaZWRraHh6U3pEOWE0RTBiSHBCNExKOHJXRGIy?= =?utf-8?B?ZjJJbEtpVGFFZUJDQk5kRWNwVE9pQk9Jb0U5QmZTVEV3bEhQL3hMRjVvYk9X?= =?utf-8?B?S2E5WDJmS0lVa1N4RVd6RnVndVhLbjBIMjVoZi82dGJSd0h1RmIzNzdKMXJm?= =?utf-8?B?aXB1NFhiQXdRNFBLSVVlcjRJTGs4K0tFc09qRlp5WS9rK3hCWmJIN09WbXdv?= =?utf-8?B?cnUvSUY3MWRmTVZ1ZU9ycVFhU2FRbXNqMVFCWVpqc3hoTkVsdklLd0YzUktY?= =?utf-8?B?QlZiUVNVODlIOWRkZWhzc29WSVNPbHE1M1BjUlpIc3BpMFdTdTB4SnFYUDZK?= =?utf-8?B?YmNZeDlSTEVKeEloUDU2cHArckVlK0JsQXdQeHNKTnZTZGFnS2E0Q2gvUTBG?= =?utf-8?B?aFdGcnRvc0MwNGM3QjV2VFhyckMvVVh4eklFRnhha0N3cFBtaUwxWUN1U0FY?= =?utf-8?B?V2c9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b94441ba-1aac-4454-b5c3-08da982b57d0 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 21:35:15.2220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jBUChakm2p+SWFUcy2lIhN3CPHVB5Tlph+vD5Am2Zz2GVX9Qq93ikvhSj1W9cSJM7IJ999Eg1qmc9ozUEZYy66kpETZyYyt7gPz6uEIOtnw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6150 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-16_14,2022-09-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 mlxscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209160154 X-Proofpoint-ORIG-GUID: zSdLdsL5-uMBcyF5ArHcMeZl-3km1ZkB X-Proofpoint-GUID: zSdLdsL5-uMBcyF5ArHcMeZl-3km1ZkB On 9/16/22 8:52 AM, Jan Beulich wrote: > On 15.09.2022 16:01, Tamas K Lengyel wrote: >> While experimenting with the vPMU subsystem an ASSERT failure was >> observed in vmx_find_msr because the vcpu_runnable state was true. >> >> The root cause of the bug appears to be the fact that the vPMU subsystem >> doesn't save its state on context_switch. The vpmu_load function will attempt >> to gather the PMU state if its still loaded two different ways: >> 1. if the current pcpu is not where the vcpu ran before doing a remote save >> 2. if the current pcpu had another vcpu active before doing a local save >> >> However, in case the prev vcpu is being rescheduled on another pcpu its state >> has already changed and vcpu_runnable is returning true, thus #2 will trip the >> ASSERT. The only way to avoid this race condition is to make sure the >> prev vcpu is paused while being checked and its context saved. Once the prev >> vcpu is resumed and does #1 it will find its state already saved. > While I consider this explanation plausible, I'm worried: > >> --- a/xen/arch/x86/cpu/vpmu.c >> +++ b/xen/arch/x86/cpu/vpmu.c >> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) >> vpmu = vcpu_vpmu(prev); >> >> /* Someone ran here before us */ >> + vcpu_pause(prev); >> vpmu_save_force(prev); >> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >> + vcpu_unpause(prev); >> >> vpmu = vcpu_vpmu(v); >> } > We're running with IRQs off here, yet vcpu_pause() waits for the vcpu > to actually be de-scheduled. Even with IRQs on this is already a > relatively heavy operation (also including its impact on the remote > side). Additionally the function is called from context_switch(), and > I'm unsure of the usability of vcpu_pause() on such a path. In > particular: Is there a risk of two CPUs doing this mutually to one > another? If so, is deadlocking excluded? > > Hence at the very least I think the description wants extending, to > discuss the safety of the change. > > Boris - any chance you could comment here? Iirc that's code you did > introduce. Is the assertion in vmx_find_msr() really needs to be for runnable vcpu or can it be a check on whether vcpu is actually running (e.g. RUNSTATE_running)? I think call chain vpmu_load()->..->*_vpmu_save()->...->vmx_find_msr() is the only one where we are doing it for non-current vcpu. If we can guarantee that run state is set after vpmu_load() call (maybe it is already, I haven't checked) then testing the state may avoid the assertion. -boris From xen-devel-bounces@lists.xenproject.org Fri Sep 16 22:05:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 16 Sep 2022 22:05:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408163.650877 (Exim 4.92) (envelope-from ) id 1oZJSX-0008Mb-72; Fri, 16 Sep 2022 22:05:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408163.650877; Fri, 16 Sep 2022 22:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZJSX-0008MU-2k; Fri, 16 Sep 2022 22:05:17 +0000 Received: by outflank-mailman (input) for mailman id 408163; Fri, 16 Sep 2022 22:05:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZJSV-0008MK-Qw; Fri, 16 Sep 2022 22:05:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZJSV-0007jt-PB; Fri, 16 Sep 2022 22:05:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZJSV-0002jo-7K; Fri, 16 Sep 2022 22:05:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZJSV-0007LG-6n; Fri, 16 Sep 2022 22:05:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AwLrIAPnZNvlj+RQlbdd+7mK7Oh2pJ0tHc6izoma5iE=; b=h7Hz8Zs+hLkD1D1HIoMHzAHc5L dYAhoR+IKycOm/zy8mMxJf8LF1RniNdScXKD4bWeO78XKQO0jPIpLFX64+/H0yO17UHm9koQDj2Ac aYXULcHtNFzgSuWAsh21hDSQsaSrTfWKm2GB3B+UAj1prCoVC1eLCAfXdhKKi7Wj0EDE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173241: regressions - FAIL X-Osstest-Failures: ovmf:build-i386-libvirt:libvirt-build:fail:regression ovmf:build-amd64-libvirt:libvirt-build:fail:regression X-Osstest-Versions-This: ovmf=2c17d676e402d75a3a674499342f7ddaccf387bd X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Fri, 16 Sep 2022 22:05:15 +0000 flight 173241 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173241/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt 6 libvirt-build fail REGR. vs. 172136 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172136 version targeted for testing: ovmf 2c17d676e402d75a3a674499342f7ddaccf387bd baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 323 attempts Testing same since 173234 2022-09-16 10:42:10 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gang Chen Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Nickle Wang Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2652 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 17 00:23:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 00:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408171.650888 (Exim 4.92) (envelope-from ) id 1oZLcH-0005aK-CY; Sat, 17 Sep 2022 00:23:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408171.650888; Sat, 17 Sep 2022 00:23:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLcH-0005aD-7K; Sat, 17 Sep 2022 00:23:29 +0000 Received: by outflank-mailman (input) for mailman id 408171; Sat, 17 Sep 2022 00:23:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLcG-0005a3-3g; Sat, 17 Sep 2022 00:23:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLcG-0002Dw-0p; Sat, 17 Sep 2022 00:23:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLcF-0002ed-G6; Sat, 17 Sep 2022 00:23:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZLcF-0007Ap-FM; Sat, 17 Sep 2022 00:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5AuSbmIoJw+3uvxgBePT/19eAtpjS0M/3SuZmGyG1Dk=; b=sHccwC+4Y7UxZOucN8gZR5hQQf 2vPnJyeYGhO2aCXFQdBblcMrUxCAiYdI2oWRZlwWxRnmIy6nV//TcUtHB6KJNVNny9270vNplgwle 1D3HUhSp/3JhICh5SxBlqV9kv8tcID39Y6e0qaaQM/RSde39aPeAcYRfyRO0TJE0Ey+Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173237: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 17 Sep 2022 00:23:27 +0000 flight 173237 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173237/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172123 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 44 days Failing since 172148 2022-08-04 21:39:38 Z 43 days 98 attempts Testing same since 173060 2022-09-08 07:34:59 Z 8 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 17 00:29:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 00:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408179.650899 (Exim 4.92) (envelope-from ) id 1oZLiT-0006Fl-2E; Sat, 17 Sep 2022 00:29:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408179.650899; Sat, 17 Sep 2022 00:29:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLiS-0006Fe-U1; Sat, 17 Sep 2022 00:29:52 +0000 Received: by outflank-mailman (input) for mailman id 408179; Sat, 17 Sep 2022 00:29:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLiR-0006FR-Mg; Sat, 17 Sep 2022 00:29:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLiR-0002Kw-Fv; Sat, 17 Sep 2022 00:29:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZLiR-0002uO-3C; Sat, 17 Sep 2022 00:29:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZLiR-0002gH-2i; Sat, 17 Sep 2022 00:29:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7IyCCODnW2tUkrAeTBobUAYEGPMGwWDoez3t5ayiB5s=; b=kEEzc09PKuo3nLCrdUQMJfn1tZ pzgjx+DPruh7WAIXu1GiVF08XgP7kK7NtWQVQRehYYJkUxYF7GvrP3nbz5hgDi5rmDlIll9WNu0Tq 0IVT/k/inOvFG7ptOOh4yiBlAtPJMdn+ZDVnNySv8gj+/W2on7gUGUUHSrEUxG9dqIOQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173243: all pass - PUSHED X-Osstest-Versions-This: ovmf=2c17d676e402d75a3a674499342f7ddaccf387bd X-Osstest-Versions-That: ovmf=444260d45ec2a84e8f8c192b3539a3cd5591d009 From: osstest service owner Date: Sat, 17 Sep 2022 00:29:51 +0000 flight 173243 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173243/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2c17d676e402d75a3a674499342f7ddaccf387bd baseline version: ovmf 444260d45ec2a84e8f8c192b3539a3cd5591d009 Last test of basis 172136 2022-08-04 06:43:42 Z 43 days Failing since 172151 2022-08-05 02:40:28 Z 42 days 324 attempts Testing same since 173234 2022-09-16 10:42:10 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Lee, Chun-Yi" Abdul Lateef Attar Abner Chang Annie Li Ard Biesheuvel Baraneedharan Anbazhagan Bob Feng Bret Barkelew Chasel Chiu Chen, Xiao X Corvin Köhne Czajkowski, Maciej Dimitrije Pavlov Dun Tan Edward Pickup Feng, Bob C Foster Nong Gang Chen Gerd Hoffmann Gregx Yeh Guo Dong Heng Luo Igor Kulchytskyy James Lu Jeff Brasen Jianyong Wu Jiaxin Wu Jose Marinho KasimX Liu Kavya Konstantin Aladyshev Kun Qin Kuo, Ted Laszlo Ersek Lee, Chun-Yi Leif Lindholm Liming Gao Liu, Zhiguang Maciej Czajkowski Michael D Kinney Michael Kubacki Min M Xu Min Xu Nickle Wang Oliver Steffen Pierre Gondois Pranav Madhu Ray Ni Rebecca Cran Rebecca Cran Rohit Mathew Sainadh Nagolu Sami Mujawar Sebastien Boeuf Shengfengx Xue Ted Kuo Wenyi Xie Wu, Jiaxin Xiao X Chen Yuan Yu Yuanhao Xie Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 444260d45e..2c17d676e4 2c17d676e402d75a3a674499342f7ddaccf387bd -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Sep 17 01:58:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 01:58:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408191.650910 (Exim 4.92) (envelope-from ) id 1oZN5y-00050R-LB; Sat, 17 Sep 2022 01:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408191.650910; Sat, 17 Sep 2022 01:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZN5y-00050J-Gg; Sat, 17 Sep 2022 01:58:14 +0000 Received: by outflank-mailman (input) for mailman id 408191; Sat, 17 Sep 2022 01:58:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZN5x-000509-Si; Sat, 17 Sep 2022 01:58:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZN5x-00028f-Q2; Sat, 17 Sep 2022 01:58:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZN5x-0006pR-4U; Sat, 17 Sep 2022 01:58:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZN5x-00034N-3d; Sat, 17 Sep 2022 01:58:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gs1ie1KPqrUNvF+uLTxsuziHKNVUQj4BAnwDkEoOV+o=; b=QV6RxebyWjAvoOM3PElJXzX8PX jE/d6R1Yiw6IWGp7BQwfQy4y7mwxUQZ16LkutvC5+od1eXdSeHIsrQOOfPk420AQRcgueRU4yBC+D kTOFgSRrbMpC3zBaWPyeNDI4J/WJmaMpIdV1fFnUKJUvAP0GVY+0m4KnEDdIYGzXfxqc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173239: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-libvirt:libvirt-build:fail:regression linux-linus:build-i386-libvirt:libvirt-build:fail:regression linux-linus:build-amd64-libvirt:libvirt-build:fail:regression linux-linus:build-armhf-libvirt:libvirt-build:fail:regression linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6879c2d3b96039ff1668b4328a4d0dd3ea952cff X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 17 Sep 2022 01:58:13 +0000 flight 173239 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173239/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-i386-libvirt 6 libvirt-build fail REGR. vs. 172133 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 172133 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 172133 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 6879c2d3b96039ff1668b4328a4d0dd3ea952cff baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 43 days Failing since 172152 2022-08-05 04:01:26 Z 42 days 97 attempts Testing same since 173239 2022-09-16 18:11:50 Z 0 days 1 attempts ------------------------------------------------------------ 1795 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 184325 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408200.650927 (Exim 4.92) (envelope-from ) id 1oZNvo-0002zn-TJ; Sat, 17 Sep 2022 02:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408200.650927; Sat, 17 Sep 2022 02:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvo-0002zA-Ni; Sat, 17 Sep 2022 02:51:48 +0000 Received: by outflank-mailman (input) for mailman id 408200; Sat, 17 Sep 2022 02:51:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvn-0002wR-M2 for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:47 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a96cd88d-3633-11ed-a31c-8f8a9ae3403f; Sat, 17 Sep 2022 04:51:44 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DFD5C5C00A9; Fri, 16 Sep 2022 22:51:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 16 Sep 2022 22:51:42 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:40 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a96cd88d-3633-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1663383102; x=1663469502; bh=azpcZR6JeUZIjxremNW7dMxcSa72o8Eqspg 1UYeperM=; b=rVBrqaUaVy5k6ji35yWuVwf5gUECeUatT+jwluP9dJO89eWwcQF GSyDtw+2jiitfN/iFUbgfA3JMMnNo6vr2ynGAwXuJqFhJJcOwZfgCxsm8xf2F1jk bGQhyYf+QrOrKh9BpLRiRcgIY2e06wZSXuDxPey3771dEMJ/oZkn5P3yIngtmpc5 HV7S4EiAIs8Pj9Ge0y18yBUTbvkJi2mnqXQaVlLHdI9HrZ9SHCQjMDjGdd7TaJbB OTgTwjQFh3qdftSIDJeRofE2+E2B6SSe1OVuqZ9ugjpfzT+i6QzEADVs4qe+jc9Q gWLbFzGIoIrXysfoiB611E1G5VV41Lq2OKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663383102; x=1663469502; bh=azpcZR6JeUZIj xremNW7dMxcSa72o8Eqspg1UYeperM=; b=owE7MAZsZdwCbLBirD5OKdiE+bWX1 Nfu30cDUGXL4S2u11oAo+ymRsqW5bKgoJg8gEqpKeRH2BGHutOqzyxo7BWoXavKD jVDaeDIyerUiWlTnYSJA0HH2Kj/JYw7Pv/yAg1whJa56z04btRi+8tQtd5wh0ICv wqVWgco2hwCkU5wvGEhA5YajhPikXWHi1n82ZWn1ucNMFAoJXSmh2VOnidtNkEiV ckoEdlFVUMdkEmivttMJzBtoUtamMnIyPa1RPh5kG3Fy8w0Vs9N0ofwInyPKbaK0 /V8nVnXcJyBe4+iksd0NeyT1im3b1loTj4R7aOTT0feQSPxRmoMheqSBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefgffg geevhffggfetfefhffeuvefhvdevkeehkedttddtgeefkeduheevffduleenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Paul Durrant , Kevin Tian , Connor Davis Subject: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability Date: Sat, 17 Sep 2022 04:51:19 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports console via USB3 debug capability. The capability is designed to operate mostly independently of normal XHCI driver, so this patch series allows dom0 to drive standard USB3 controller part, while Xen uses DbC for console output. Changes since RFC: - move the driver to xue.c, remove non-Xen parts, remove now unneeded abstraction - adjust for Xen code style - build for x86 only - drop patch hidding the device from dom0 Changes since v1: - drop ehci patch - already applied - adjust for review comments from Jan (see changelogs in individual patches) Changes since v2: - add runtime option to share (or not) the controller with dom0 or other domains - add RX support - several smaller changes according to review comments Changes since v3: - put controller sharing behind experimental kconfig option - several other changes according to review comments Changes since v4: - drop first 4 patches - already applied to staging - split dbgp=xhci into dbc=xhci Changes since v5: - roll dbc=xhci back into dbgp=xhci, but make it work together with dbgp=ehci Changes since v6: - reorder patches - put acked ones early (I've put acked IOMMU ones early too, even without VT-d, because they do make it work on AMD, and it's kind of required to get the console work with IOMMU enabled) - drop barriers patch (at least for now) - new patches for suspend support and console=ehci alias Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Paul Durrant Cc: Kevin Tian Cc: Connor Davis Marek Marczykowski-Górecki (11): drivers/char: allow using both dbgp=xhci and dbgp=ehci IOMMU: add common API for device reserved memory IOMMU/AMD: wire common device reserved memory API drivers/char: mark DMA buffers as reserved for the XHCI drivers/char: add RX support to the XHCI driver drivers/char: fix handling cable re-plug in XHCI console driver drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC IOMMU/VT-d: wire common device reserved memory API console: support multiple serial console simultaneously drivers/char: suspend handling in XHCI console driver drivers/char: add console=ehci as an alias for console=dbgp docs/misc/xen-command-line.pandoc | 30 +- xen/drivers/char/Kconfig | 11 +- xen/drivers/char/console.c | 98 ++++-- xen/drivers/char/ehci-dbgp.c | 14 +- xen/drivers/char/serial.c | 12 +- xen/drivers/char/xhci-dbc.c | 392 +++++++++++++++++++++--- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +- xen/drivers/passthrough/iommu.c | 46 +++- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++----- xen/include/xen/iommu.h | 14 +- xen/include/xen/serial.h | 4 +- 11 files changed, 693 insertions(+), 150 deletions(-) base-commit: 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408203.650965 (Exim 4.92) (envelope-from ) id 1oZNvr-0003wG-P7; Sat, 17 Sep 2022 02:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408203.650965; Sat, 17 Sep 2022 02:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvr-0003w9-Lc; Sat, 17 Sep 2022 02:51:51 +0000 Received: by outflank-mailman (input) for mailman id 408203; Sat, 17 Sep 2022 02:51:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvq-0002wS-75 for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:50 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aca1c01f-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 684DC5C00AC; Fri, 16 Sep 2022 22:51:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Sep 2022 22:51:48 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:47 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aca1c01f-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383108; x=1663469508; bh=oHCR6T8UU3 IPX2fsRqB667MqjSnGtYktvgSa8odFN3E=; b=VtRY7XJHW0MmqBXTNZOzMQDbk+ pdw2+49IlbBVkCsKnAw1b8hWIp1pfe26bAMPM0IuKRoulWyjckGluxmeGvF9eUjc Dqqq4bV7g6EJrmmR+DxO2cxvKX8jrrPXSmZ7KHWImZOoQqIxf207X6yKEjawSLd/ QMPwgp09KifZnX5AzrDVhXElhjsVImroDIcqoZAybBVvqjcOW4T0HKmFetS2sImE RB/UAdcVBVdSp1f+0vrI0Wg8bE2ZG5r0zvJ/4bziq5W3sRGPn7QxO3g3OK0n4rcU W1Jjny+CGVQRwwApe1dlFG3AUlwC5ajFc6KV/TjHFxyqq5ZHJx0iBFSKXnIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383108; x= 1663469508; bh=oHCR6T8UU3IPX2fsRqB667MqjSnGtYktvgSa8odFN3E=; b=i uSvItKX15NTQV2CPBU+v9LDvxdz9FnZps+3saZyAsoCt6cFP86+vsuQLc0KDxXRS l2gfxYrv2wA52tVd2QfzVMb5RMcdLL439dJwjFUQ8hg47DqgwUViXOW85r0qKuHH GLl2t+N5KQDU8a7yjbe34a84ZjRdpVU4ho4ecQI0mvVZ4++xf8PBoVJZriG7gM9t 6TMpHbMsnWNMmULc7GLcCb14hO2TiWPM9yEjpc7cOmzbAj9BrEg2vGt8qwpEbk/H 66e2f101NWldTbaEYdKABA5z8aMS9tJfJQc7a3WNP650jdC3YmRfc9sqWB6JOe7p HzyTbBn8wiyaxBqZO68XA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 04/11] drivers/char: mark DMA buffers as reserved for the XHCI Date: Sat, 17 Sep 2022 04:51:23 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later patches), that domain will effectively have access to those buffers too. It does give such domain yet another way to DoS the system (as is the case when having PCI device assigned already), but also possibly steal the console ring content. Thus, such domain should be a trusted one. In any case, prevent anything else being placed on those pages by adding artificial padding. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v5: - add missing alignment Changes in v3: - adjust for xhci-dbc rename - do not raise MAX_USER_RMRR_PAGES - adjust alignment of DMA buffers --- xen/drivers/char/xhci-dbc.c | 43 +++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 14 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 4712faaabef7..f55f73e382fc 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -1051,13 +1052,21 @@ static struct uart_driver dbc_uart_driver = { }; /* Those are accessed via DMA. */ -static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; -static struct xhci_erst_segment erst __aligned(16); -static struct xhci_dbc_ctx ctx __aligned(16); -static uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; -static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +struct dbc_dma_bufs { + struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; + struct xhci_trb out_trb[DBC_TRB_RING_CAP]; + struct xhci_trb in_trb[DBC_TRB_RING_CAP]; + uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; + struct xhci_erst_segment erst __aligned(16); + struct xhci_dbc_ctx ctx __aligned(16); + struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; + /* + * Don't place anything else on this page - it will be + * DMA-reachable by the USB controller. + */ +}; +static struct dbc_dma_bufs __section(".bss.page_aligned") __aligned(PAGE_SIZE) + dbc_dma_bufs; static int __init xhci_parse_dbgp(const char *opt_dbgp) { @@ -1104,16 +1113,22 @@ void __init xhci_dbc_uart_init(void) if ( !dbc->enable ) return; - dbc->dbc_ctx = &ctx; - dbc->dbc_erst = &erst; - dbc->dbc_ering.trb = evt_trb; - dbc->dbc_oring.trb = out_trb; - dbc->dbc_iring.trb = in_trb; - dbc->dbc_owork.buf = out_wrk_buf; - dbc->dbc_str = str_buf; + dbc->dbc_ctx = &dbc_dma_bufs.ctx; + dbc->dbc_erst = &dbc_dma_bufs.erst; + dbc->dbc_ering.trb = dbc_dma_bufs.evt_trb; + dbc->dbc_oring.trb = dbc_dma_bufs.out_trb; + dbc->dbc_iring.trb = dbc_dma_bufs.in_trb; + dbc->dbc_owork.buf = dbc_dma_bufs.out_wrk_buf; + dbc->dbc_str = dbc_dma_bufs.str_buf; if ( dbc_open(dbc) ) + { + iommu_add_extra_reserved_device_memory( + PFN_DOWN(virt_to_maddr(&dbc_dma_bufs)), + PFN_UP(sizeof(dbc_dma_bufs)), + uart->dbc.sbdf); serial_register_uart(SERHND_XHCI, &dbc_uart_driver, &dbc_uart); + } } #ifdef DBC_DEBUG -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408201.650943 (Exim 4.92) (envelope-from ) id 1oZNvq-0003S7-8X; Sat, 17 Sep 2022 02:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408201.650943; Sat, 17 Sep 2022 02:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvq-0003S0-3h; Sat, 17 Sep 2022 02:51:50 +0000 Received: by outflank-mailman (input) for mailman id 408201; Sat, 17 Sep 2022 02:51:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvo-0002wS-6q for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:48 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab09f4b6-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:46 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BC6215C00AC; Fri, 16 Sep 2022 22:51:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Sep 2022 22:51:45 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:44 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab09f4b6-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383105; x=1663469505; bh=9gt4X0S6LT y3mZR525t0hd3leGbrVBuq9ANTQAYGNoU=; b=G7Jt9cFJQUz9cIycj5qrKJzoJd dAhbUQurOCRLigF5InxZ5ibTGHJVCebuPSKqHQen4LEuSxh3ZWw2vmnfcJhmvTZk TD/E/Aso7HHdHTnnYwdcnvox5JQ9b+FiGQ6/3HfmVyYdXMxzC2GIektGEmkJGXbP w0VaqZXAPOnSRNKZuYONon3+A2R0IPtNymwZKiB3RxIV8f75fhQK9+qQc/72ZdqZ EAqC/7myQAoqzlcJhnZm3gSU7mVC3OP7B0dgtoFxnaokeg5JCHu4OrSC4d5ju5gt tV5qa5/50vZyweGQj2qA3dwcfUvxEuWsyUXGUhJPoDhjexu5xJb5u3oNgdHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383105; x= 1663469505; bh=9gt4X0S6LTy3mZR525t0hd3leGbrVBuq9ANTQAYGNoU=; b=n gBOf7m0bX4tptvMoQn64Qmiv67aIP9wowae+iD2hbHttJo3g+iWhNmWV4QKczD0s AM+gNK2qanRXd2eHyT88fCxCRZWF8xXhpgdmHN6cjoNL/YmFqTc4cRKHYU7gfE0Z pxoIZvD0tQx9fNwJCAJwHPfVOHqR3+Ed4KI0H0zi9JFJTAp/HlYi2Qv42KMVxax5 8y60J0zVW/bTXTi9n1i8/SLIYMIMzY0b/BOw/wqWcWFays6/uPGEuidIAfKYau39 S7JBkGy8J3sEKLFkUhaSov5CPLfPZ9D2ClwrBVmMJppaVUmXyB85TWQAA7tK1noq tz7gUlirUlJNUNeqgpSiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v7 02/11] IOMMU: add common API for device reserved memory Date: Sat, 17 Sep 2022 04:51:21 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add API similar to rmrr= and ivmd= arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for user-supplied reserved memory, and it may be useful for other drivers in the future too. This commit just introduces an API, subsequent patches will plug it in appropriate places. The reserved memory ranges needs to be saved locally, because at the point when they are collected, Xen doesn't know yet which IOMMU driver will be used. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v5: - fix indentation, keep full "reserved_device_memory" for consistency with iommu_get_reserved_device_memory Changes in v4: - mark functions as __init - use pci_sbdf_t type Changes in v3: - adjust code style --- xen/drivers/passthrough/iommu.c | 46 ++++++++++++++++++++++++++++++++++- xen/include/xen/iommu.h | 14 ++++++++++- 2 files changed, 60 insertions(+) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 134cdb47e0dc..5e2a720d29b9 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -669,6 +669,52 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } +#define MAX_EXTRA_RESERVED_RANGES 20 +struct extra_reserved_range { + unsigned long start; + unsigned long nr; + pci_sbdf_t sbdf; +}; +static unsigned int __initdata nr_extra_reserved_ranges; +static struct extra_reserved_range __initdata + extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; + +int __init iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + pci_sbdf_t sbdf) +{ + unsigned int idx; + + if ( nr_extra_reserved_ranges >= MAX_EXTRA_RESERVED_RANGES ) + return -ENOMEM; + + idx = nr_extra_reserved_ranges++; + extra_reserved_ranges[idx].start = start; + extra_reserved_ranges[idx].nr = nr; + extra_reserved_ranges[idx].sbdf = sbdf; + + return 0; +} + +int __init iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, + void *ctxt) +{ + unsigned int idx; + int ret; + + for ( idx = 0; idx < nr_extra_reserved_ranges; idx++ ) + { + ret = func(extra_reserved_ranges[idx].start, + extra_reserved_ranges[idx].nr, + extra_reserved_ranges[idx].sbdf.sbdf, + ctxt); + if ( ret < 0 ) + return ret; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 1240d7762d99..4f22fc1bed55 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -304,6 +304,20 @@ struct iommu_ops { #endif }; +/* + * To be called by Xen internally, to register extra RMRR/IVMD ranges. + * Needs to be called before IOMMU initialization. + */ +extern int iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + pci_sbdf_t sbdf); +/* + * To be called by specific IOMMU driver during initialization, + * to fetch ranges registered with iommu_add_extra_reserved_device_memory(). + */ +extern int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, + void *ctxt); + #include #ifndef iommu_call -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408202.650949 (Exim 4.92) (envelope-from ) id 1oZNvq-0003VM-MA; Sat, 17 Sep 2022 02:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408202.650949; Sat, 17 Sep 2022 02:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvq-0003UU-CP; Sat, 17 Sep 2022 02:51:50 +0000 Received: by outflank-mailman (input) for mailman id 408202; Sat, 17 Sep 2022 02:51:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvp-0002wS-71 for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:49 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abb65e3e-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id DC6A45C00A9; Fri, 16 Sep 2022 22:51:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Sep 2022 22:51:46 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:45 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abb65e3e-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383106; x=1663469506; bh=/pD4K+B9L0 ba8VyhoGCQP8h4YWebGtRYWp1NDk3Q7sk=; b=itEbC7X1dp21xKuLNKJyo8Ai0w CJ9n5XfOAD85GITEj4vmv8VMnIBniOsGpsAL4KO64mvbNEpzEdD6WsSp3R4mLIVK D5VaNsG2eqjfLgDgXhaOWu5sU7upEDdaZANeecRs1ALGHbQprAdeKTOsQCqnvCqu wL4kO9FmGM9jhmUZ9KhZUIWGck+shy7RNc2+t6tfzHOmwfKudVnVY5bAPsa9LraX WUIIL9+AuFfOxPiarxjdLdxBXn0qYwltuq7g3Nf5ch/U/dQk40VD4oVDnOlRTr+l k0bsN58zDYLosOOFS7QoGIGlK8KPXh8mYsb47yvH+3Z9B4z4CXUAUGao7Wxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383106; x= 1663469506; bh=/pD4K+B9L0ba8VyhoGCQP8h4YWebGtRYWp1NDk3Q7sk=; b=c 9hkK3BV+CD1f2jOiqRsY+BY0mKGT1abbztFWy5uhlS0PYPsjkf2GvsWsN+AS7L5A ZdMdbJ5uayyTnNeJW5zWWdzFuUQe0/f2ay03nEBp7xsf2ok+XYJ7oKECulj4krgZ 9/N7t3yEGSsP8JziQpVLaA/mhdD21PkUTDZeby3CwJLfPteoRvDSyjM6FiPZ+bkl m0jWMjOgcTEQFlYGv4khM74k6TAjCtj84sNFPSMI5ju4n0U/kY6jPYkBclTJRYyz /iXzkFj9JgFfCyFiSe2sS5VNIyWidxhLxqaOU5jMdGmCXH7dORmUp9uk5TCaKvUZ 57gbJBgS2Q2fU7LnObAZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper Subject: [PATCH v7 03/11] IOMMU/AMD: wire common device reserved memory API Date: Sat, 17 Sep 2022 04:51:22 +0200 Message-Id: <49615badb40907157c900996f185e169b7f3d611.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Register common device reserved memory similar to how ivmd= parameter is handled. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v3: - use variable initializer - use pfn_to_paddr() --- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index ac6835225bae..3b577c9b390c 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -1078,6 +1078,25 @@ static inline bool_t is_ivmd_block(u8 type) type == ACPI_IVRS_TYPE_MEMORY_IOMMU); } +static int __init cf_check add_one_extra_ivmd(unsigned long start, + unsigned long nr, + uint32_t id, void *ctxt) +{ + struct acpi_ivrs_memory ivmd = { + .header = { + .length = sizeof(ivmd), + .flags = ACPI_IVMD_UNITY | ACPI_IVMD_READ | ACPI_IVMD_WRITE, + .device_id = id, + .type = ACPI_IVRS_TYPE_MEMORY_ONE, + }, + }; + + ivmd.start_address = pfn_to_paddr(start); + ivmd.memory_length = pfn_to_paddr(nr); + + return parse_ivmd_block(&ivmd); +} + static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) { const struct acpi_ivrs_header *ivrs_block; @@ -1121,6 +1140,8 @@ static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) AMD_IOMMU_DEBUG("IVMD: %u command line provided entries\n", nr_ivmd); for ( i = 0; !error && i < nr_ivmd; ++i ) error = parse_ivmd_block(user_ivmds + i); + if ( !error ) + error = iommu_get_extra_reserved_device_memory(add_one_extra_ivmd, NULL); /* Each IO-APIC must have been mentioned in the table. */ for ( apic = 0; !error && iommu_intremap && apic < nr_ioapics; ++apic ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408199.650921 (Exim 4.92) (envelope-from ) id 1oZNvo-0002wp-IL; Sat, 17 Sep 2022 02:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408199.650921; Sat, 17 Sep 2022 02:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvo-0002wh-Fd; Sat, 17 Sep 2022 02:51:48 +0000 Received: by outflank-mailman (input) for mailman id 408199; Sat, 17 Sep 2022 02:51:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvn-0002wS-ET for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:47 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa4bef6e-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:45 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7F8025C00F8; Fri, 16 Sep 2022 22:51:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 16 Sep 2022 22:51:44 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:43 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa4bef6e-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383104; x=1663469504; bh=lrkiGrmoKq AiVQo0EOwsLXEqHNX4rJOp8Mpa4BXZipo=; b=lUy/vstw7xfZtd5HZtQGnQQLWz TxjW1JYGtJzEnDt+QFr+kajn6k6/1T/3OghR9AfMh+Y1+gMjSIKDOyft1TFR9NUE zjnrCChavxLvE23d4MY3YfkJdtAxDflcDxbg/xeEUdJ9+1Fh+z3BiL57sxUNCAzw bK7NPfdOetzKky6Tck7JywcWwTj2dn0UPCsCX/sUfcgEXEwKyM/cFsfQAE5vBvT7 ME12mt3Fkc7ZfAn40L592ushwXa8ffONoEtn1faNOmUq2xBrv1G3d5WFHiV1KoDb fRuV2KmUgxU0rUE/rIjsiou4ybqnbb6WN2btIwKek8oNIwptHmod3mZM0ttg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383104; x= 1663469504; bh=lrkiGrmoKqAiVQo0EOwsLXEqHNX4rJOp8Mpa4BXZipo=; b=g dt00lbwvTVi1BALh0a8QBpRYoli8sevqOOOWqv65aN+CT/v0MNq8wgF7OrDMpzg1 b8r0HnedXHiTqat3x3jAkGG8mOZvJ4vlxuosGbmUI3Kfd8MuAgrmgcszV43tJKco V+TIHhAMAAFsKEGswhA5JC9yL87hdlRzTtD0gWKZs1N2/8UzONQbRCKB5KrW0gK+ rCHzBe3ZlNZ3miiR/QLIIY0I7z/YpdGVH8BGoCezcj3QkjXNbm+hxBJWUlDcHlNA MDSeBGIs3QEZCN0njhZ158A6udtkrb+W8Ar3nbCDVuKJ/3DHGIV+dj8WwsCCHaYY /N1LoXCapM+gIVLTbjcQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 01/11] drivers/char: allow using both dbgp=xhci and dbgp=ehci Date: Sat, 17 Sep 2022 04:51:20 +0200 Message-Id: <4586e8d0ce166d6ff47ee9cba7f0ef7831a19a87.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This allows configuring EHCI and XHCI consoles separately, simultaneously. This changes string_param() to custom_param() in both ehci and xhci drivers. Both drivers parse only values applicable to them. Suggested-by: Jan Beulich Signed-off-by: Marek Marczykowski-Górecki --- Changes in v7: - restore memset in xhci_parse_dbgp() Changes in v6: - keep dbgp=xhci, but use custom_param() to parse multiple values separately - modify ehci-dbgp to use custom_param() too - change console=dbc to console=xhci, as 'dbc' doesn't appear in any other option anymore - update comment in serial.h new in v5 --- docs/misc/xen-command-line.pandoc | 6 ++++-- xen/drivers/char/ehci-dbgp.c | 14 ++++++++++++-- xen/drivers/char/serial.c | 6 ++++++ xen/drivers/char/xhci-dbc.c | 27 +++++++++++++++++++-------- xen/include/xen/serial.h | 3 ++- 5 files changed, 43 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 9a79385a3712..c8b07042f58e 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -409,7 +409,7 @@ The following are examples of correct specifications: Specify the size of the console ring buffer. ### console -> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | none ]` +> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | xhci | none ]` > Default: `console=com1,vga` @@ -428,7 +428,9 @@ cleared. This allows a single port to be shared by two subsystems `pv` indicates that Xen should use Xen's PV console. This option is only available when used together with `pv-in-pvh`. -`dbgp` indicates that Xen should use a USB debug port. +`dbgp` indicates that Xen should use a USB2 debug port. + +`xhci` indicates that Xen should use a USB3 debug port. `none` indicates that Xen should not use a console. This option only makes sense on its own. diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c index 92c588ec0aa3..8a0b95850609 100644 --- a/xen/drivers/char/ehci-dbgp.c +++ b/xen/drivers/char/ehci-dbgp.c @@ -1464,7 +1464,17 @@ static struct uart_driver __read_mostly ehci_dbgp_driver = { static struct ehci_dbgp ehci_dbgp = { .state = dbgp_unsafe, .phys_port = 1 }; static char __initdata opt_dbgp[30]; -string_param("dbgp", opt_dbgp); + +static int __init parse_ehci_dbgp(const char *opt) +{ + if ( strncmp(opt, "ehci", 4) ) + return 0; + + strlcpy(opt_dbgp, opt, sizeof(opt_dbgp)); + + return 0; +} +custom_param("dbgp", parse_ehci_dbgp); void __init ehci_dbgp_init(void) { @@ -1472,7 +1482,7 @@ void __init ehci_dbgp_init(void) u32 debug_port, offset, bar_val; const char *e; - if ( strncmp(opt_dbgp, "ehci", 4) ) + if ( !opt_dbgp[0] ) return; if ( isdigit(opt_dbgp[4]) || !opt_dbgp[4] ) diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c index 47899222cef8..9d9445039232 100644 --- a/xen/drivers/char/serial.c +++ b/xen/drivers/char/serial.c @@ -311,6 +311,12 @@ int __init serial_parse_handle(const char *conf) goto common; } + if ( !strncmp(conf, "xhci", 4) && (!conf[4] || conf[4] == ',') ) + { + handle = SERHND_XHCI; + goto common; + } + if ( !strncmp(conf, "dtuart", 6) ) { handle = SERHND_DTUART; diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index ca7d4a62139e..4712faaabef7 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -245,6 +245,7 @@ struct dbc { uint64_t xhc_dbc_offset; void __iomem *xhc_mmio; + bool enable; /* whether dbgp=xhci was set at all */ bool open; unsigned int xhc_num; /* look for n-th xhc */ }; @@ -1058,18 +1059,14 @@ static struct xhci_dbc_ctx ctx __aligned(16); static uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; -static char __initdata opt_dbgp[30]; - -string_param("dbgp", opt_dbgp); - -void __init xhci_dbc_uart_init(void) +static int __init xhci_parse_dbgp(const char *opt_dbgp) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; const char *e; if ( strncmp(opt_dbgp, "xhci", 4) ) - return; + return 0; memset(dbc, 0, sizeof(*dbc)); @@ -1087,12 +1084,26 @@ void __init xhci_dbc_uart_init(void) printk(XENLOG_ERR "Invalid dbgp= PCI device spec: '%s'\n", opt_dbgp + 8); - return; + return -EINVAL; } dbc->sbdf = PCI_SBDF(0, bus, slot, func); } + dbc->enable = true; + + return 0; +} +custom_param("dbgp", xhci_parse_dbgp); + +void __init xhci_dbc_uart_init(void) +{ + struct dbc_uart *uart = &dbc_uart; + struct dbc *dbc = &uart->dbc; + + if ( !dbc->enable ) + return; + dbc->dbc_ctx = &ctx; dbc->dbc_erst = &erst; dbc->dbc_ering.trb = evt_trb; @@ -1102,7 +1113,7 @@ void __init xhci_dbc_uart_init(void) dbc->dbc_str = str_buf; if ( dbc_open(dbc) ) - serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); + serial_register_uart(SERHND_XHCI, &dbc_uart_driver, &dbc_uart); } #ifdef DBC_DEBUG diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 4cd4ae5e6f1c..f0aff7ea7661 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -91,10 +91,11 @@ struct uart_driver { }; /* 'Serial handles' are composed from the following fields. */ -#define SERHND_IDX (3<<0) /* COM1, COM2, DBGP, DTUART? */ +#define SERHND_IDX (3<<0) /* COM1, COM2, DBGP, XHCI, DTUART? */ # define SERHND_COM1 (0<<0) # define SERHND_COM2 (1<<0) # define SERHND_DBGP (2<<0) +# define SERHND_XHCI (3<<0) # define SERHND_DTUART (0<<0) /* Steal SERHND_COM1 value */ #define SERHND_HI (1<<2) /* Mux/demux each transferred char by MSB. */ #define SERHND_LO (1<<3) /* Ditto, except that the MSB is cleared. */ -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408204.650976 (Exim 4.92) (envelope-from ) id 1oZNvu-0004I5-4s; Sat, 17 Sep 2022 02:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408204.650976; Sat, 17 Sep 2022 02:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvu-0004Hu-0D; Sat, 17 Sep 2022 02:51:54 +0000 Received: by outflank-mailman (input) for mailman id 408204; Sat, 17 Sep 2022 02:51:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvs-0002wS-4i for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:52 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id adb87390-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:51 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 421155C00A9; Fri, 16 Sep 2022 22:51:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 16 Sep 2022 22:51:50 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:48 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adb87390-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383110; x=1663469510; bh=NTR4tfYTOW iTukVNEGbCZsZdDOh1oxGQd+Xm0uEc8NQ=; b=p2UJrWwg0RS1GasOYoHj5Xt1c9 /SJKEmAUq5Y+mjPJETk/tyQrKDjMzgZ5Io6h3E6Bxr4tFUQqXTDCpITAgYFoPMgP IwkkQXSWz2zggEEtmnaazqY5p0+8fPtGVWsLIa0NvggWA49Zf7DXY1lVuvecgXZo VHF5zomAd+XgLrEise9IGS7KoB5uy3N+cDdDnY0r7Pd52Y5bt7YswDakQqFOCRS5 dTwA0gGVndkWYIk2naSzkzkFu1eJkwvuy+xyYGHp0bPsJVIv9QQSf2afXltBttAv mT+VPyy5u14IUsEOFg1cfwePOHY/j39huz8SxxFHXnyLsxwFRcTznaOj0ROA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383110; x= 1663469510; bh=NTR4tfYTOWiTukVNEGbCZsZdDOh1oxGQd+Xm0uEc8NQ=; b=p hLWQry5y9/pV0G7t69cNPSRQ0TKySoJuqmMRAslg0o+GvLcP/TCVxJooRnWnfcWS PzmiVqXr4TYtBrGuEDVJBlO2kpLM0K/WM/bwLZpslW1niedaRAL2n7ctR+0og1JU pTFSC1xhoxC8Td6lVUpah3jlhgNgyU05INPuhjTLx3S6UtPuKoHs2VrbW/V1WXo6 ePmnSF2Vc3weB6MVRmAGIbvOoVkLPEDhLM2WAAlKcfG1up6NyIkm6DMPdCqmFL0T UB04cwmFXAn9S2GuX21pkJaCi4vDNQRwKOtZWiYERvm6zuKbLrxgr52Bma3XLJxt xJZ1JrO7kK3zdVhcZpd0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 05/11] drivers/char: add RX support to the XHCI driver Date: Sat, 17 Sep 2022 04:51:24 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add another work ring buffer for received data, and point IN TRB at it. Ensure there is always at least one pending IN TRB, so the controller has a way to send incoming data to the driver. Note that both "success" and "short packet" completion codes are okay - in fact it will be "short packet" most of the time, as the TRB length is about maximum size, not required size. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v4: - adjust return types - add some const New patch in v3 --- docs/misc/xen-command-line.pandoc | 6 +- xen/drivers/char/xhci-dbc.c | 129 +++++++++++++++++++++++++++++++- 2 files changed, 132 insertions(+), 3 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index c8b07042f58e..92d668afa06c 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -728,9 +728,9 @@ Available alternatives, with their meaning, are: Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). -Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (output -only). XHCI driver will wait indefinitely for the debug host to connect - make -sure the cable is connected. +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability. +XHCI driver will wait indefinitely for the debug host to connect - make sure +the cable is connected. ### debug_stack_lines > `= ` diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index f55f73e382fc..00ab4ae4a27e 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -111,6 +111,7 @@ enum { enum { XHCI_TRB_CC_SUCCESS = 1, XHCI_TRB_CC_TRB_ERR = 5, + XHCI_TRB_CC_SHORT_PACKET = 13, }; /* DbC endpoint types */ @@ -239,6 +240,7 @@ struct dbc { struct xhci_trb_ring dbc_oring; struct xhci_trb_ring dbc_iring; struct dbc_work_ring dbc_owork; + struct dbc_work_ring dbc_iwork; struct xhci_string_descriptor *dbc_str; pci_sbdf_t sbdf; @@ -444,6 +446,16 @@ static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) trb->ctrl |= 0x20; } +static uint64_t xhci_trb_norm_buf(const struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_norm_len(const struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /** * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event * TRBs are read-only from software @@ -453,6 +465,17 @@ static uint64_t xhci_trb_tfre_ptr(const struct xhci_trb *trb) return trb->params; } +static uint32_t xhci_trb_tfre_cc(const struct xhci_trb *trb) +{ + return trb->status >> 24; +} + +/* Amount of data _not_ transferred */ +static uint32_t xhci_trb_tfre_len(const struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /* Fields for link TRBs (section 6.4.4.1) */ static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) { @@ -494,6 +517,14 @@ static bool xhci_trb_ring_full(const struct xhci_trb_ring *ring) return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) == ring->deq; } +static unsigned int xhci_trb_ring_size(const struct xhci_trb_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return ring->enq - ring->deq; + + return DBC_TRB_RING_CAP - ring->deq + ring->enq; +} + static bool dbc_work_ring_full(const struct dbc_work_ring *ring) { return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) == ring->deq; @@ -507,6 +538,14 @@ static unsigned int dbc_work_ring_size(const struct dbc_work_ring *ring) return DBC_WORK_RING_CAP - ring->deq + ring->enq; } +static unsigned int dbc_work_ring_space_to_end(const struct dbc_work_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return DBC_WORK_RING_CAP - ring->enq; + + return ring->deq - ring->enq; +} + static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, uint64_t dma, uint64_t len) { @@ -567,6 +606,31 @@ static unsigned int dbc_push_work(struct dbc *dbc, struct dbc_work_ring *ring, return i; } +static void dbc_rx_trb(struct dbc *dbc, struct xhci_trb *trb, + uint64_t not_transferred) +{ + struct dbc_work_ring *ring = &dbc->dbc_iwork; + unsigned int rx_len; + unsigned int end, start = ring->enq; + + if ( xhci_trb_type(trb) != XHCI_TRB_NORM ) + /* Can be Link TRB for example. */ + return; + + ASSERT(xhci_trb_norm_buf(trb) == ring->dma + ring->enq); + ASSERT(xhci_trb_norm_len(trb) >= not_transferred); + rx_len = xhci_trb_norm_len(trb) - not_transferred; + + /* It can hit the ring end, but should not wrap around. */ + ASSERT(ring->enq + rx_len <= DBC_WORK_RING_CAP); + ring->enq = (ring->enq + rx_len) & (DBC_WORK_RING_CAP - 1); + + end = ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); +} + /* * Note that if IN transfer support is added, then this * will need to be changed; it assumes an OUT transfer ring only @@ -576,6 +640,7 @@ static void dbc_pop_events(struct dbc *dbc) struct dbc_reg *reg = dbc->dbc_reg; struct xhci_trb_ring *er = &dbc->dbc_ering; struct xhci_trb_ring *tr = &dbc->dbc_oring; + struct xhci_trb_ring *ir = &dbc->dbc_iring; struct xhci_trb *event = &er->trb[er->deq]; uint64_t erdp = readq(®->erdp); uint32_t portsc; @@ -601,6 +666,14 @@ static void dbc_pop_events(struct dbc *dbc) trb_idx = (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; tr->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); } + else if ( event_ptr - ir->dma < DBC_TRB_RING_BYTES ) + { + trb_idx = (event_ptr - ir->dma) >> XHCI_TRB_SHIFT; + if ( xhci_trb_tfre_cc(event) == XHCI_TRB_CC_SUCCESS || + xhci_trb_tfre_cc(event) == XHCI_TRB_CC_SHORT_PACKET ) + dbc_rx_trb(dbc, &ir->trb[trb_idx], xhci_trb_tfre_len(event)); + ir->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } else dbc_alert("event: TRB 0x%lx not found in any ring\n", event_ptr); @@ -871,6 +944,7 @@ static bool __init dbc_open(struct dbc *dbc) return false; dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_init_work_ring(dbc, &dbc->dbc_iwork); dbc_enable_dbc(dbc); dbc->open = true; @@ -947,6 +1021,33 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, } /** + * Ensure DbC has a pending transfer TRB to receive data into. + * + * @param dbc the dbc to flush + * @param trb the ring for the TRBs to transfer + * @param wrk the work ring to receive data into + */ +static void dbc_enqueue_in(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t db = (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + /* Check if there is already queued TRB */ + if ( xhci_trb_ring_size(trb) >= 1 ) + return; + + if ( dbc_work_ring_full(wrk) ) + return; + + dbc_push_trb(dbc, trb, wrk->dma + wrk->enq, + dbc_work_ring_space_to_end(wrk)); + + wmb(); + writel(db, ®->db); +} + +/** * Queue a single character to the DbC. A transfer TRB will be created * if the character is a newline and the DbC will be notified that data is * available for writing to the debug host. @@ -969,6 +1070,19 @@ static int64_t dbc_putc(struct dbc *dbc, char c) return 1; } +static int dbc_getc(struct dbc *dbc, char *c) +{ + struct dbc_work_ring *wrk = &dbc->dbc_iwork; + + if ( dbc_work_ring_size(wrk) == 0 ) + return 0; + + *c = wrk->buf[wrk->deq]; + wrk->deq = (wrk->deq + 1) & (DBC_WORK_RING_CAP - 1); + + return 1; +} + struct dbc_uart { struct dbc dbc; struct timer timer; @@ -987,10 +1101,16 @@ static void cf_check dbc_uart_poll(void *data) if ( spin_trylock_irqsave(&port->tx_lock, flags) ) { if ( dbc_ensure_running(dbc) ) + { dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + dbc_enqueue_in(dbc, &dbc->dbc_iring, &dbc->dbc_iwork); + } spin_unlock_irqrestore(&port->tx_lock, flags); } + while ( dbc_work_ring_size(&dbc->dbc_iwork) ) + serial_rx_interrupt(port, guest_cpu_user_regs()); + serial_tx_interrupt(port, guest_cpu_user_regs()); set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); } @@ -1029,6 +1149,12 @@ static void cf_check dbc_uart_putc(struct serial_port *port, char c) dbc_putc(&uart->dbc, c); } +static int cf_check dbc_uart_getc(struct serial_port *port, char *c) +{ + struct dbc_uart *uart = port->uart; + return dbc_getc(&uart->dbc, c); +} + static void cf_check dbc_uart_flush(struct serial_port *port) { s_time_t goal; @@ -1048,6 +1174,7 @@ static struct uart_driver dbc_uart_driver = { .init_postirq = dbc_uart_init_postirq, .tx_ready = dbc_uart_tx_ready, .putc = dbc_uart_putc, + .getc = dbc_uart_getc, .flush = dbc_uart_flush, }; @@ -1057,6 +1184,7 @@ struct dbc_dma_bufs { struct xhci_trb out_trb[DBC_TRB_RING_CAP]; struct xhci_trb in_trb[DBC_TRB_RING_CAP]; uint8_t out_wrk_buf[DBC_WORK_RING_CAP]; + uint8_t in_wrk_buf[DBC_WORK_RING_CAP]; struct xhci_erst_segment erst __aligned(16); struct xhci_dbc_ctx ctx __aligned(16); struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; @@ -1119,6 +1247,7 @@ void __init xhci_dbc_uart_init(void) dbc->dbc_oring.trb = dbc_dma_bufs.out_trb; dbc->dbc_iring.trb = dbc_dma_bufs.in_trb; dbc->dbc_owork.buf = dbc_dma_bufs.out_wrk_buf; + dbc->dbc_iwork.buf = dbc_dma_bufs.in_wrk_buf; dbc->dbc_str = dbc_dma_bufs.str_buf; if ( dbc_open(dbc) ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408205.650982 (Exim 4.92) (envelope-from ) id 1oZNvu-0004PV-RX; Sat, 17 Sep 2022 02:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408205.650982; Sat, 17 Sep 2022 02:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvu-0004NW-J0; Sat, 17 Sep 2022 02:51:54 +0000 Received: by outflank-mailman (input) for mailman id 408205; Sat, 17 Sep 2022 02:51:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvt-0002wS-Cz for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:53 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aea86660-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:52 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C9F625C00AC; Fri, 16 Sep 2022 22:51:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 16 Sep 2022 22:51:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:50 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aea86660-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383111; x=1663469511; bh=IyFutLja57 /fivONhEJ7wzgB6O+d/UdKnwYWMwrAmNA=; b=Bvs3Cc6N8ZMiYJz7sDxvjB8G7n gm3M/5dTu4GCw+rTHvgqFjw1a0vBdk6QnVd8yWyxtWr8YVr06wc+uN8o2Gr9oP6E OUXb4TgUcimdFHoUMEwDvD4I54aZY6x7jhaJAz+YPysxXa2yIjlJEzGqzJcSsSlG p/5zKUquEl8i42tMSGdtbGycn+VNaqFabTxIGWevkpPr7NjWnXZLFA9ZwPmpEonh L91LGV3v9mk9FwGqwOEDExgY95qem+cQqGyTnZOxNtjSpc7hh7awI74xB0mHJmpE IfNs51sr7gy5iHOAEXtdEJ0wo0mpRo2Xr5cE+KmceFDmhlq9dKUV4iQ1klpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383111; x= 1663469511; bh=IyFutLja57/fivONhEJ7wzgB6O+d/UdKnwYWMwrAmNA=; b=w RWjE+wgK5xJBPaukH/JpHHi06ehpNlDOmFep0NYPcc4zQrI+MA6J1fqK70AP90zy cYuYHsERK8TtaNLgtfUSDs2Yh80UsTkNvVyMf9yM/fMdT6v32j81MgsP9D8yAI3v 6HzsW3/CT6dSAfHZrfv3kMwwe4LYW/ONCPVEa4X2HHNbP36tt2GrKrPIqrbKw9Lx XIRms3VBaVfpu28qg8aKewWBKojdS8vJvfocA6ycXuvY6aMig2wi7lEPY1fhWA8c 1qaGaMv2NF88ESmW/jC25Q04MpAH74KvgDMgva1bd8Qq2/r8r6VvU0NbdMXnsHBf maBsDK1JYvRm589jPM6Pg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 06/11] drivers/char: fix handling cable re-plug in XHCI console driver Date: Sat, 17 Sep 2022 04:51:25 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When cable is unplugged, dbc_ensure_running() correctly detects this situation (DBC_CTRL_DCR flag is clear), and prevent sending data immediately to the device. It gets only queued in work ring buffers. When cable is plugged in again, subsequent dbc_flush() will send the buffered data. But there is a corner case, where no subsequent data was buffered in the work buffer, but a TRB was still pending. Ring the doorbell to let the controller re-send them. For console output it is rare corner case (TRB is pending for a very short time), but for console input it is very normal case (there is always one pending TRB for input). Extract doorbell ringing into separate function to avoid duplication. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v6: - keep barriers consistent --- xen/drivers/char/xhci-dbc.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 00ab4ae4a27e..5f47733c1801 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -546,6 +546,15 @@ static unsigned int dbc_work_ring_space_to_end(const struct dbc_work_ring *ring) return ring->deq - ring->enq; } +static void dbc_ring_doorbell(struct dbc *dbc, int doorbell) +{ + uint32_t __iomem *db_reg = &dbc->dbc_reg->db; + uint32_t db = (readl(db_reg) & ~DBC_DOORBELL_TARGET_MASK) | + (doorbell << DBC_DOORBELL_TARGET_SHIFT); + + writel(db, db_reg); +} + static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, uint64_t dma, uint64_t len) { @@ -973,6 +982,8 @@ static bool dbc_ensure_running(struct dbc *dbc) writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); wmb(); + dbc_ring_doorbell(dbc, dbc->dbc_iring.db); + dbc_ring_doorbell(dbc, dbc->dbc_oring.db); } return true; @@ -990,10 +1001,6 @@ static bool dbc_ensure_running(struct dbc *dbc) static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, struct dbc_work_ring *wrk) { - struct dbc_reg *reg = dbc->dbc_reg; - uint32_t db = (readl(®->db) & ~DBC_DOORBELL_TARGET_MASK) | - (trb->db << DBC_DOORBELL_TARGET_SHIFT); - if ( xhci_trb_ring_full(trb) ) return; @@ -1017,7 +1024,7 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, } wmb(); - writel(db, ®->db); + dbc_ring_doorbell(dbc, trb->db); } /** -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408206.650998 (Exim 4.92) (envelope-from ) id 1oZNvx-0004un-3S; Sat, 17 Sep 2022 02:51:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408206.650998; Sat, 17 Sep 2022 02:51:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvw-0004ub-Vp; Sat, 17 Sep 2022 02:51:56 +0000 Received: by outflank-mailman (input) for mailman id 408206; Sat, 17 Sep 2022 02:51:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvv-0002wS-6Z for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:55 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af96ef2a-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:54 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 632395C00A9; Fri, 16 Sep 2022 22:51:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Sep 2022 22:51:53 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af96ef2a-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383113; x=1663469513; bh=NiyNOXiNwr iNwBPnQLIEDaYmk/WxMl7jUGwTLDkTZnY=; b=l5qqbsUMOsoYp45rOMwIcZ9cy8 YKw4H30YbIlatKG9UWO3DbwmHg2bHbzSkvwkDXcvdDVUPvAgWXFf4JRHIe969fvn h5NnMSqybsxnqZGr+N9Csmvzrs+uccbDLT7nN9rMb1ZQtmhz5ewuFKvFHHrfvnUv 4A6WYilJko5NEMruCVW3iYOJQjuQy4bloatHwQOMqAf6+zZh0aadIA1gNa350Ihf Vg4h49jekggAhsQpPqevFSyeYhFOuprA/fOy0B7mSxqiDoRQj4T7GFJkGEuOEF41 RZEOZ0VCvoZAba167FixX0vKfV5ZaTsKq42fLsQlhg+H3X0JUsGLkSUnqZMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383113; x= 1663469513; bh=NiyNOXiNwriNwBPnQLIEDaYmk/WxMl7jUGwTLDkTZnY=; b=R M2S+tL24N5FRiCN4eJSJSHj5iCIwX1beSVXWUQRhcBKa4rpPXZYrJQCIxRwq1ACK s3DXdyVyRgVL/4O5QGmHNebQ769rW3a1rKvPauyAfKti0F9W3vxJvVF/xmMPebDR 4W7VWc4UakwoU8THg+lKefLrYR4HCBSiXTKbMTLYbRTd54ptVMCQlx1fRZ0Z1cAO U1A3L6vqJAMaRZG6x5iLFAnM+cseUF1W4w1mzGMRasSxVKd2sub3tmfhDMl41ALu OBeBY1Yx3XTcYOB/9Ji/5qZOj1Qp+043y04MX0KKwQVSgK5mz1izaYLlSxHZ1swU ZrFmKS8ceWAgEcwVZz7KA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 07/11] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC Date: Sat, 17 Sep 2022 04:51:26 +0200 Message-Id: <41e4f161de6f22d92db81f4822c164a9ad256147.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack - re-enabling bus mastering behind dom0's backs. Linux driver does similar thing - see drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). When controller sharing is enabled in kconfig (option marked as experimental), dom0 is allowed to use the controller even if Xen uses it for debug console. Additionally, option `dbgp=xhci,share=` is available to either prevent even dom0 from using it (`no` value), or allow any domain using it (`any` value). In any case, to avoid Linux messing with the DbC, mark this MMIO area as read-only. This might cause issues for Linux's driver (if it tries to write something on the same page - like anoter xcap), but makes Xen's use safe. In practice, as of Linux 5.18, it seems to work without issues. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich --- Changes in v5: - drop CONFIG_XHCI_SHARE - make XHCI_SHARE_HWDOM = 0 - use parse_boolean - add comment about mmio_ro_ranges - fix doc Changes in v4: - minor fix for cmdline parsing - make sharing opt-in build time, with option marked as EXPERIMENTAL - change cmdline syntax to share=|hwdom - make share=hwdom default (if enabled build-time) Changes in v3: - adjust for xhci-dbc rename - adjust for dbc_ensure_running() split - wrap long lines - add runtime option for sharing USB controller --- docs/misc/xen-command-line.pandoc | 14 ++- xen/drivers/char/xhci-dbc.c | 129 +++++++++++++++++++++++++++++-- 2 files changed, 134 insertions(+), 9 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 92d668afa06c..bbb4652bbfcd 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -723,7 +723,7 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` -> `= xhci[ | @pci:. ]` +> `= xhci[ | @pci:. ][,share=|hwdom]` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). @@ -731,6 +731,18 @@ over the PCI busses sequentially) or by PCI device (must be on segment 0). Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability. XHCI driver will wait indefinitely for the debug host to connect - make sure the cable is connected. +The `share` option for xhci controls who else can use the controller: +* `no`: use the controller exclusively for console, even hardware domain + (dom0) cannot use it +* `hwdom`: hardware domain may use the controller too, ports not used for debug + console will be available for normal devices; this is the default +* `yes`: the controller can be assigned to any domain; it is not safe to assign + the controller to untrusted domain + +Choosing `share=hwdom` (the default) or `share=yes` allows a domain to reset the +controller, which may cause small portion of the console output to be lost. + +The `share=yes` configuration is not security supported. ### debug_stack_lines > `= ` diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 5f47733c1801..5f92234a9594 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -232,6 +233,12 @@ struct dbc_work_ring { uint64_t dma; }; +enum xhci_share { + XHCI_SHARE_HWDOM = 0, + XHCI_SHARE_NONE, + XHCI_SHARE_ANY +}; + struct dbc { struct dbc_reg __iomem *dbc_reg; struct xhci_dbc_ctx *dbc_ctx; @@ -250,6 +257,7 @@ struct dbc { bool enable; /* whether dbgp=xhci was set at all */ bool open; + enum xhci_share share; unsigned int xhc_num; /* look for n-th xhc */ }; @@ -961,13 +969,56 @@ static bool __init dbc_open(struct dbc *dbc) } /* - * Ensure DbC is still running, handle events, and possibly re-enable if cable - * was re-plugged. Returns true if DbC is operational. + * Ensure DbC is still running, handle events, and possibly + * re-enable/re-configure if cable was re-plugged or controller was reset. + * Returns true if DbC is operational. */ static bool dbc_ensure_running(struct dbc *dbc) { struct dbc_reg *reg = dbc->dbc_reg; uint32_t ctrl; + uint16_t cmd; + + if ( dbc->share != XHCI_SHARE_NONE ) + { + /* + * Re-enable memory decoding and later bus mastering, if dom0 (or + * other) disabled it in the meantime. + */ + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MEMORY) ) + { + cmd |= PCI_COMMAND_MEMORY; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + + /* + * FIXME: Make Linux coordinate XHCI reset, so the DbC driver can + * prepare for it properly, instead of only detecting it after the + * fact. See EHCI driver for similar handling. + */ + if ( dbc->open && !(readl(®->ctrl) & (1U << DBC_CTRL_DCE)) ) + { + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + } + else + { + /* + * dbc_init_dbc() takes care about it, so check only if it wasn't + * called. + */ + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MASTER) ) + { + cmd |= PCI_COMMAND_MASTER; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + } + } dbc_pop_events(dbc); @@ -1136,10 +1187,38 @@ static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) init_timer(&uart->timer, dbc_uart_poll, port, 0); set_timer(&uart->timer, NOW() + MILLISECS(1)); - if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) - printk(XENLOG_WARNING - "Failed to mark read-only %pp used for XHCI console\n", - &uart->dbc.sbdf); + switch ( uart->dbc.share ) + { + case XHCI_SHARE_NONE: + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_HWDOM: + if ( pci_hide_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to hide %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_ANY: + /* Do not hide. */ + break; + } +#ifdef CONFIG_X86 + /* + * This marks the whole page as R/O, which may include other registers + * unrelated to DbC. Xen needs only DbC area protected, but it seems + * Linux's XHCI driver (as of 5.18) works without writting to the whole + * page, so keep it simple. + */ + if ( rangeset_add_range(mmio_ro_ranges, + PFN_DOWN(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset), + PFN_UP(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset + + sizeof(*uart->dbc.dbc_reg)) - 1) ) + printk(XENLOG_INFO + "Error while adding MMIO range of device to mmio_ro_ranges\n"); +#endif } static int cf_check dbc_uart_tx_ready(struct serial_port *port) @@ -1207,13 +1286,15 @@ static int __init xhci_parse_dbgp(const char *opt_dbgp) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; - const char *e; + const char *e, *opt; + int val; if ( strncmp(opt_dbgp, "xhci", 4) ) return 0; memset(dbc, 0, sizeof(*dbc)); + e = &opt_dbgp[4]; if ( isdigit(opt_dbgp[4]) ) { dbc->xhc_num = simple_strtoul(opt_dbgp + 4, &e, 10); @@ -1223,7 +1304,7 @@ static int __init xhci_parse_dbgp(const char *opt_dbgp) unsigned int bus, slot, func; e = parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); - if ( !e || *e ) + if ( !e || (*e && *e != ',') ) { printk(XENLOG_ERR "Invalid dbgp= PCI device spec: '%s'\n", @@ -1233,6 +1314,38 @@ static int __init xhci_parse_dbgp(const char *opt_dbgp) dbc->sbdf = PCI_SBDF(0, bus, slot, func); } + opt = e; + + /* other options */ + while ( *opt == ',' ) + { + opt++; + e = strchr(opt, ','); + if ( !e ) + e = strchr(opt, '\0'); + + if ( (val = parse_boolean("share", opt, e)) != -1 ) + { + if ( val == -2 && !cmdline_strcmp(opt + 6, "hwdom") ) + dbc->share = XHCI_SHARE_HWDOM; + else if ( val == 0 ) + dbc->share = XHCI_SHARE_NONE; + else if ( val == 1 ) + dbc->share = XHCI_SHARE_ANY; + else + break; + } + else + break; + + opt = e; + } + + if ( *opt ) + { + printk(XENLOG_ERR "Invalid dbgp= parameters: '%s'\n", opt); + return -EINVAL; + } dbc->enable = true; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408207.651008 (Exim 4.92) (envelope-from ) id 1oZNvy-0005CP-Fe; Sat, 17 Sep 2022 02:51:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408207.651008; Sat, 17 Sep 2022 02:51:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvy-0005BG-9T; Sat, 17 Sep 2022 02:51:58 +0000 Received: by outflank-mailman (input) for mailman id 408207; Sat, 17 Sep 2022 02:51:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvw-0002wS-3N for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:56 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b02f319b-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:55 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 62CB55C00F8; Fri, 16 Sep 2022 22:51:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 16 Sep 2022 22:51:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b02f319b-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383114; x=1663469514; bh=CFew235jgq 1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=5emUe0PrOOKfUKZIsY/YgLkeUh 4nBypB6uDJD5GdhYq8VghMTagP0/O4m65p7LbPd1UB4FghkB8jA8fVhu5pejoN7G 7r9AUFcc2o94UT8+bO350SQGNhxIfVVdg38+1SexrNAHNcerZ9rhP9p0iJsAsZuf Jvan4YE/DelYwqkS3kz8xrFW1RXcMJO4wp+kgov76nL2CBuf4bxTXZEBjPDuzOdP umcgJVdSgR8UkAxxHFc5lbhzcI7atdY+sek/RT+ppWRYNfjdoMhjcsBPe+zXKnaU PIG6D/Ekq9NhhzdeS7/4tC/lH8JESN4d6H8/d6sFONhhU8SlcXHSACSN1B2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383114; x= 1663469514; bh=CFew235jgq1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=D f5XfKecY5uWI4hvuTB5AwCvLP5JmX2/PBpcRpqk6cu+8SBuIExHTGB6Br6/hpYFf JYbExtn4vV03RrZ9dvXAy6ttoNi3b9DjH2Se+1vN+domp0qyYtj4uSPGT6z1RlRq ldKcN3C7K0oF5BikqMJ0n20Ug3kidrTh2G5XDE0JjZKK+cI0NGS1Gb38lDcpsMR0 5AcYxICQ7PLeKvT741k5ks3aTPOc5hwN1bGo1nFzMcJtYUTOqfKrKe813j0V+aOb D2QetYDY2YbLnZYhyuMcEkOPi2ogBh/fEekGvrJCHofV1jDQYPIDof+ugYUsQGui VtF8Woxzkn1mzp889+PPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Date: Sat, 17 Sep 2022 04:51:27 +0200 Message-Id: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-use rmrr= parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- 1 file changed, 119 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 367304c8739c..3df5f6b69719 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -861,111 +861,139 @@ static struct user_rmrr __initdata user_rmrrs[MAX_USER_RMRR]; /* Macro for RMRR inclusive range formatting. */ #define ERMRRU_FMT "[%lx-%lx]" -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn +#define ERMRRU_ARG base_pfn, end_pfn + +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf); static int __init add_user_rmrr(void) { + unsigned int i; + int ret; + + for ( i = 0; i < nr_rmrr; i++ ) + { + ret = add_one_user_rmrr(user_rmrrs[i].base_pfn, + user_rmrrs[i].end_pfn, + user_rmrrs[i].dev_count, + user_rmrrs[i].sbdf); + if ( ret < 0 ) + return ret; + } + return 0; +} + +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf) +{ struct acpi_rmrr_unit *rmrr, *rmrru; - unsigned int idx, seg, i; - unsigned long base, end; + unsigned int idx, seg; + unsigned long base_iter; bool overlap; - for ( i = 0; i < nr_rmrr; i++ ) + if ( iommu_verbose ) + printk(XENLOG_DEBUG VTDPREFIX + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\n", + dev_count, sbdf[0], ERMRRU_ARG); + + if ( base_pfn > end_pfn ) { - base = user_rmrrs[i].base_pfn; - end = user_rmrrs[i].end_pfn; + printk(XENLOG_ERR VTDPREFIX + "Invalid RMRR Range "ERMRRU_FMT"\n", + ERMRRU_ARG); + return 0; + } - if ( base > end ) + overlap = false; + list_for_each_entry(rmrru, &acpi_rmrr_units, list) + { + if ( pfn_to_paddr(base_pfn) <= rmrru->end_address && + rmrru->base_address <= pfn_to_paddr(end_pfn) ) { printk(XENLOG_ERR VTDPREFIX - "Invalid RMRR Range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", + ERMRRU_ARG, + paddr_to_pfn(rmrru->base_address), + paddr_to_pfn(rmrru->end_address)); + overlap = true; + break; } + } + /* Don't add overlapping RMRR. */ + if ( overlap ) + return 0; - if ( (end - base) >= MAX_USER_RMRR_PAGES ) + base_iter = base_pfn; + do + { + if ( !mfn_valid(_mfn(base_iter)) ) { printk(XENLOG_ERR VTDPREFIX - "RMRR range "ERMRRU_FMT" exceeds "\ - __stringify(MAX_USER_RMRR_PAGES)" pages\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + break; } + } while ( base_iter++ < end_pfn ); - overlap = false; - list_for_each_entry(rmrru, &acpi_rmrr_units, list) - { - if ( pfn_to_paddr(base) <= rmrru->end_address && - rmrru->base_address <= pfn_to_paddr(end) ) - { - printk(XENLOG_ERR VTDPREFIX - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", - ERMRRU_ARG(user_rmrrs[i]), - paddr_to_pfn(rmrru->base_address), - paddr_to_pfn(rmrru->end_address)); - overlap = true; - break; - } - } - /* Don't add overlapping RMRR. */ - if ( overlap ) - continue; + /* Invalid pfn in range as the loop ended before end_pfn was reached. */ + if ( base_iter <= end_pfn ) + return 0; - do - { - if ( !mfn_valid(_mfn(base)) ) - { - printk(XENLOG_ERR VTDPREFIX - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - break; - } - } while ( base++ < end ); + rmrr = xzalloc(struct acpi_rmrr_unit); + if ( !rmrr ) + return -ENOMEM; - /* Invalid pfn in range as the loop ended before end_pfn was reached. */ - if ( base <= end ) - continue; + rmrr->scope.devices = xmalloc_array(u16, dev_count); + if ( !rmrr->scope.devices ) + { + xfree(rmrr); + return -ENOMEM; + } - rmrr = xzalloc(struct acpi_rmrr_unit); - if ( !rmrr ) - return -ENOMEM; + seg = 0; + for ( idx = 0; idx < dev_count; idx++ ) + { + rmrr->scope.devices[idx] = sbdf[idx]; + seg |= PCI_SEG(sbdf[idx]); + } + if ( seg != PCI_SEG(sbdf[0]) ) + { + printk(XENLOG_ERR VTDPREFIX + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + scope_devices_free(&rmrr->scope); + xfree(rmrr); + return 0; + } - rmrr->scope.devices = xmalloc_array(u16, user_rmrrs[i].dev_count); - if ( !rmrr->scope.devices ) - { - xfree(rmrr); - return -ENOMEM; - } + rmrr->segment = seg; + rmrr->base_address = pfn_to_paddr(base_pfn); + /* Align the end_address to the end of the page */ + rmrr->end_address = pfn_to_paddr(end_pfn) | ~PAGE_MASK; + rmrr->scope.devices_cnt = dev_count; - seg = 0; - for ( idx = 0; idx < user_rmrrs[i].dev_count; idx++ ) - { - rmrr->scope.devices[idx] = user_rmrrs[i].sbdf[idx]; - seg |= PCI_SEG(user_rmrrs[i].sbdf[idx]); - } - if ( seg != PCI_SEG(user_rmrrs[i].sbdf[0]) ) - { - printk(XENLOG_ERR VTDPREFIX - "Segments are not equal for RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - scope_devices_free(&rmrr->scope); - xfree(rmrr); - continue; - } + if ( register_one_rmrr(rmrr) ) + printk(XENLOG_ERR VTDPREFIX + "Could not register RMMR range "ERMRRU_FMT"\n", + ERMRRU_ARG); - rmrr->segment = seg; - rmrr->base_address = pfn_to_paddr(user_rmrrs[i].base_pfn); - /* Align the end_address to the end of the page */ - rmrr->end_address = pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAGE_MASK; - rmrr->scope.devices_cnt = user_rmrrs[i].dev_count; + return 1; +} - if ( register_one_rmrr(rmrr) ) - printk(XENLOG_ERR VTDPREFIX - "Could not register RMMR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - } +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) +{ + u32 sbdf_array[] = { id }; + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); +} - return 0; +static int __init add_extra_rmrr(void) +{ + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NULL); } #include @@ -1010,7 +1038,7 @@ int __init acpi_dmar_init(void) { iommu_init_ops = &intel_iommu_init_ops; - return add_user_rmrr(); + return add_user_rmrr() || add_extra_rmrr(); } return ret; @@ -1108,6 +1136,15 @@ static int __init cf_check parse_rmrr_param(const char *str) else end = start; + if ( (end - start) >= MAX_USER_RMRR_PAGES ) + { + printk(XENLOG_ERR VTDPREFIX + "RMRR range "ERMRRU_FMT" exceeds "\ + __stringify(MAX_USER_RMRR_PAGES)" pages\n", + start, end); + return -E2BIG; + } + user_rmrrs[nr_rmrr].base_pfn = start; user_rmrrs[nr_rmrr].end_pfn = end; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:51:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:51:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408208.651014 (Exim 4.92) (envelope-from ) id 1oZNvz-0005JW-6u; Sat, 17 Sep 2022 02:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408208.651014; Sat, 17 Sep 2022 02:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvy-0005Hz-Un; Sat, 17 Sep 2022 02:51:58 +0000 Received: by outflank-mailman (input) for mailman id 408208; Sat, 17 Sep 2022 02:51:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvx-0002wR-TB for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:58 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b124062d-3633-11ed-a31c-8f8a9ae3403f; Sat, 17 Sep 2022 04:51:56 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EE9DC5C00F8; Fri, 16 Sep 2022 22:51:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 16 Sep 2022 22:51:55 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:54 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b124062d-3633-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383115; x=1663469515; bh=EnXHwNrOAT v3ottA2Lx9tzDlTANRIkNdp9+f2qyQX4E=; b=CXbKiYLI5aRFzz37W/gw8iUnvd kyusrKIr4cvUhhVZvYZlv8Un00V2dRF/SDgFuB/WCIBrg8AqW1eyyj6Sudm00JYz RGv/Bch0ZhnXp6fHkKmRbBnce9vrWT6nZQ0OywhjcqdE8SPSC0OjNo6GradE7ReN Y+32HKBc2A0bej3udmh2if1mRVz4dncjCtgZJlGCTgVWogBlQhfFA9PN6xnbiLVA cvc+hAFXD1Um72hfrB0bQFr+QaECJgY9hPfFmMVbJljb5A9E1WFc3E4eyyvJlz3B YHkhvDc+H9ibS1yTk7hb0hA5WpJ8vXGOoa/lFIcuD1rI/KKMgDJaazpyQ8rA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383115; x= 1663469515; bh=EnXHwNrOATv3ottA2Lx9tzDlTANRIkNdp9+f2qyQX4E=; b=1 tNOl+qYZQouHTA1VJMkpb3ewID8lmowoAYftfLc561yft0zvlVq890WGn8rdugT4 niP3jIdCQvMkOXk3gBFRaAZhruDxTWOB8Bqqv6r8HoJugtqgdEuZ0olmMdv8mW/d Lm4MDC0zTX9QIAL+vlLVLpy5Pm8SXJO4Pwt3CGCXO/qyUQQNLKbWftvLX6VImM4J TnkfYEhd7KsKY9MNcK0Pni3SqQw0sTmifAd7ek9oFJ+HaSV0tdco4cAMnYW/jRxK 4KtFePUf5q8BIntrJBvV4BFZhm3PU+i3pzEfweAHgwCjTBtm1o6UzSyAEeRGsU8Q /bdOyAWKvH9OjPQ3G4k+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 09/11] console: support multiple serial console simultaneously Date: Sat, 17 Sep 2022 04:51:28 +0200 Message-Id: <45b3424896bb26d716ff81f1cb29411fe926a4c6.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously only one serial console was supported at the same time. Using console=com1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of MAX_SERCONS can be chosen in kconfig, the default (4) is arbitrary, inspired by the number of SERHND_IDX values. Make console_steal() aware of multiple consoles too. It can now either steal output from specific console (for gdbstub), or from all of them at once (for console suspend). Signed-off-by: Marek Marczykowski-Górecki --- Changes in v4: - use unsigned int for loop counters - other minor changes Changes in v3: - adjust console_steal() for multiple consoles too - add MAX_SERCONS to kconfig - add warning about sync_console impact - add warning if too many consoles are configured - log issue with PCI spec parsing --- docs/misc/xen-command-line.pandoc | 4 +- xen/drivers/char/Kconfig | 11 ++++- xen/drivers/char/console.c | 98 ++++++++++++++++++++++++-------- xen/include/xen/serial.h | 1 +- 4 files changed, 92 insertions(+), 22 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index bbb4652bbfcd..1c755563c40d 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -435,6 +435,9 @@ only available when used together with `pv-in-pvh`. `none` indicates that Xen should not use a console. This option only makes sense on its own. +Specifying more than one serial console will increase console latency, +especially when `sync_console` option is used. + ### console_timestamps > `= none | date | datems | boot | raw` @@ -2417,6 +2420,7 @@ vulnerabilities. Flag to force synchronous console output. Useful for debugging, but not suitable for production environments due to incurred overhead. +If multiple consoles are configured, the incurred overhead is even bigger. ### tboot (x86) > `= 0x` diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index 06350c387371..7b5ff0c414ec 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -85,6 +85,17 @@ config SERIAL_TX_BUFSIZE Default value is 16384 (16kiB). +config MAX_SERCONS + int "Maximum number of serial consoles active at once" + default 4 + help + Controls how many serial consoles can be active at once. Configuring more + using `console=` parameter will be ignored. + When multiple consoles are configured, overhead of `sync_console` option + is even bigger. + + Default value is 4. + config XHCI bool "XHCI DbC UART driver" depends on X86 diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index e8468c121ad0..60d42284f606 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -113,7 +113,9 @@ static char *__read_mostly conring = _conring; static uint32_t __read_mostly conring_size = _CONRING_SIZE; static uint32_t conringc, conringp; -static int __read_mostly sercon_handle = -1; +#define MAX_SERCONS CONFIG_MAX_SERCONS +static int __read_mostly sercon_handle[MAX_SERCONS]; +static unsigned int __read_mostly nr_sercon_handle = 0; #ifdef CONFIG_X86 /* Tristate: 0 disabled, 1 user enabled, -1 default enabled */ @@ -393,32 +395,61 @@ long read_console_ring(struct xen_sysctl_readconsole *op) static char serial_rx_ring[SERIAL_RX_SIZE]; static unsigned int serial_rx_cons, serial_rx_prod; -static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; +/* The last entry means "steal from all consoles" */ +static void (*serial_steal_fn[])(const char *, size_t nr) = { + [MAX_SERCONS] = early_puts, +}; +/* + * Redirect console *handle* output to *fn*. Use SERHND_STEAL_ALL as *handle* to + * redirect all the consoles. + */ int console_steal(int handle, void (*fn)(const char *, size_t nr)) { - if ( (handle == -1) || (handle != sercon_handle) ) - return 0; + unsigned int i; + + if ( handle == -1 ) + return -ENOENT; + if ( serial_steal_fn[MAX_SERCONS] != NULL ) + return -EBUSY; + if ( handle == SERHND_STEAL_ALL ) + { + serial_steal_fn[MAX_SERCONS] = fn; + return MAX_SERCONS; + } + for ( i = 0; i < nr_sercon_handle; i++ ) + if ( handle == sercon_handle[i] ) + break; + if ( i == nr_sercon_handle ) + return -ENOENT; - if ( serial_steal_fn != NULL ) + if ( serial_steal_fn[i] != NULL ) return -EBUSY; - serial_steal_fn = fn; - return 1; + serial_steal_fn[i] = fn; + return i; } void console_giveback(int id) { - if ( id == 1 ) - serial_steal_fn = NULL; + if ( id >= 0 && id <= MAX_SERCONS ) + serial_steal_fn[id] = NULL; } void console_serial_puts(const char *s, size_t nr) { - if ( serial_steal_fn != NULL ) - serial_steal_fn(s, nr); + unsigned int i; + + if ( serial_steal_fn[MAX_SERCONS] != NULL ) + serial_steal_fn[MAX_SERCONS](s, nr); else - serial_puts(sercon_handle, s, nr); + for ( i = 0; i < nr_sercon_handle; i++ ) + { + if ( serial_steal_fn[i] != NULL ) + serial_steal_fn[i](s, nr); + else + serial_puts(sercon_handle[i], s, nr); + } /* Copy all serial output into PV console */ pv_console_puts(s, nr); @@ -957,6 +988,7 @@ void __init console_init_preirq(void) { char *p; int sh; + unsigned int i; serial_init_preirq(); @@ -977,8 +1009,12 @@ void __init console_init_preirq(void) continue; else if ( (sh = serial_parse_handle(p)) >= 0 ) { - sercon_handle = sh; - serial_steal_fn = NULL; + if ( nr_sercon_handle < MAX_SERCONS ) + sercon_handle[nr_sercon_handle++] = sh; + else + printk("Too many consoles (max %d), ignoring '%s'\n", + MAX_SERCONS, p); + serial_steal_fn[MAX_SERCONS] = NULL; } else { @@ -996,7 +1032,8 @@ void __init console_init_preirq(void) opt_console_xen = 0; #endif - serial_set_rx_handler(sercon_handle, serial_rx); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_set_rx_handler(sercon_handle[i], serial_rx); pv_console_set_rx_handler(serial_rx); /* HELLO WORLD --- start-of-day banner text. */ @@ -1014,7 +1051,8 @@ void __init console_init_preirq(void) if ( opt_sync_console ) { - serial_start_sync(sercon_handle); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_sync(sercon_handle[i]); add_taint(TAINT_SYNC_CONSOLE); printk("Console output is synchronous.\n"); warning_add(warning_sync_console); @@ -1121,13 +1159,19 @@ int __init console_has(const char *device) void console_start_log_everything(void) { - serial_start_log_everything(sercon_handle); + unsigned int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_log_everything(sercon_handle[i]); atomic_inc(&print_everything); } void console_end_log_everything(void) { - serial_end_log_everything(sercon_handle); + unsigned int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_log_everything(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1149,23 +1193,32 @@ void console_unlock_recursive_irqrestore(unsigned long flags) void console_force_unlock(void) { + unsigned int i; + watchdog_disable(); spin_debug_disable(); spin_lock_init(&console_lock); - serial_force_unlock(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_force_unlock(sercon_handle[i]); console_locks_busted = 1; console_start_sync(); } void console_start_sync(void) { + unsigned int i; + atomic_inc(&print_everything); - serial_start_sync(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_start_sync(sercon_handle[i]); } void console_end_sync(void) { - serial_end_sync(sercon_handle); + unsigned int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_sync(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1291,7 +1344,8 @@ static int suspend_steal_id; int console_suspend(void) { - suspend_steal_id = console_steal(sercon_handle, suspend_steal_fn); + if ( nr_sercon_handle ) + suspend_steal_id = console_steal(SERHND_STEAL_ALL, suspend_steal_fn); serial_suspend(); return 0; } diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index f0aff7ea7661..226139841e71 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -100,6 +100,7 @@ struct uart_driver { #define SERHND_HI (1<<2) /* Mux/demux each transferred char by MSB. */ #define SERHND_LO (1<<3) /* Ditto, except that the MSB is cleared. */ #define SERHND_COOKED (1<<4) /* Newline/carriage-return translation? */ +#define SERHND_STEAL_ALL 0xff /* Synthetic handle used in console_steal() */ /* Three-stage initialisation (before/during/after IRQ-subsystem setup). */ void serial_init_preirq(void); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:52:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:52:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408209.651026 (Exim 4.92) (envelope-from ) id 1oZNw0-0005gy-H5; Sat, 17 Sep 2022 02:52:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408209.651026; Sat, 17 Sep 2022 02:52:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNw0-0005fp-Bp; Sat, 17 Sep 2022 02:52:00 +0000 Received: by outflank-mailman (input) for mailman id 408209; Sat, 17 Sep 2022 02:51:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNvz-0002wS-3N for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:51:59 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b20af080-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:58 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7F4B15C00AC; Fri, 16 Sep 2022 22:51:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 16 Sep 2022 22:51:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:56 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b20af080-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383117; x=1663469517; bh=aUXbRcRCV6 JyIMsNvZBMmFwwnT4bncaXUatuQgqKC8I=; b=hrwTSlAmBEurETa0SdKNsHFVhp YYdutLUlbvW7V6+e4i8fma2rBXItvH784MUMfvUXSY6JiXg9I+zha3ETpPFif6Q2 YMLBepSWhPF27X73KmxU8c67OFhTDMq/WZNcnuhJMcms8L9KYdk/9TW1w75fv2hN L4doZd2y2+vyOj450rPeTsZBXC8RQvrR7CllwQQn/+oCODPkZWfmtnqRyFBGbRHy IrQzAPQwCHTP2yxyGX4crRtKTXLhijGvQuNqu8T6lHp5Pg5zfuXdc1U1MOBkMku1 j91PbKZGX0Ir6Jt8Cx18WNRasAP6+a9rH/MZfj5SX7w7dcbspfaa7qGlMVrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383117; x= 1663469517; bh=aUXbRcRCV6JyIMsNvZBMmFwwnT4bncaXUatuQgqKC8I=; b=t QJQpEIgQXyRGELsZubrcM1kWswGGm2eh/w5hsJPnxArJ2PKKD9EVPFzQrQg57hut r3Xi7oxvFfN/Z273nUdrnqpi1afNwOpd9rojn9ZNMFrAqZjZ0hfTlXxdB46SBV5r 4ouMWHBOvKA9XR6351UJZIW0u/UXQdfvi570sOqZp61A8XsQT7qCQtAK8PWvgMr9 VVVG6J7H/NS6/mLwqqDqzsYEeE+s5CLywg+hUsynagfBrKIZCPGQomI5q2FWcZew sDnKgzpgAyk0+8UiX/pIAJNPoqhsPrqdQAJEPNNMlBwuFCdEoAc+4NMLhCpGBg6k JohlKsT1ntcJ38icPPR7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 10/11] drivers/char: suspend handling in XHCI console driver Date: Sat, 17 Sep 2022 04:51:29 +0200 Message-Id: <927d01aa54cf6f5291e506179e3d15dc32ebad40.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Similar to the EHCI driver - save/restore relevant BAR and command register, re-configure DbC on resume and stop/start timer. On resume trigger sending anything that was queued in the meantime. Save full BAR value, instead of just the address part, to ease restoring on resume. Signed-off-by: Marek Marczykowski-Górecki --- New in v7 Without this patch, the console is broken after S3, and in some cases the suspend doesn't succeed at all (when xhci console is enabled). Very similar (if not the same) functions might be used for coordinated reset handling. I tried to include it in this patch too, but it's a bit more involved, mostly due to share=yes case (PHYSDEVOP_dbgp_op can be called by the hardware domain only). --- xen/drivers/char/xhci-dbc.c | 55 +++++++++++++++++++++++++++++++++----- 1 file changed, 49 insertions(+), 6 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 5f92234a9594..81a4fd5b12c3 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -251,7 +251,7 @@ struct dbc { struct xhci_string_descriptor *dbc_str; pci_sbdf_t sbdf; - uint64_t xhc_mmio_phys; + uint64_t bar_val; uint64_t xhc_dbc_offset; void __iomem *xhc_mmio; @@ -259,6 +259,9 @@ struct dbc { bool open; enum xhci_share share; unsigned int xhc_num; /* look for n-th xhc */ + /* state saved across suspend */ + bool suspended; + uint16_t pci_cr; }; static void *dbc_sys_map_xhc(uint64_t phys, size_t size) @@ -358,8 +361,9 @@ static bool __init dbc_init_xhc(struct dbc *dbc) pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); - dbc->xhc_mmio_phys = (bar0 & PCI_BASE_ADDRESS_MEM_MASK) | (bar1 << 32); - dbc->xhc_mmio = dbc_sys_map_xhc(dbc->xhc_mmio_phys, xhc_mmio_size); + dbc->bar_val = bar0 | (bar1 << 32); + dbc->xhc_mmio = dbc_sys_map_xhc(dbc->bar_val & PCI_BASE_ADDRESS_MEM_MASK, + xhc_mmio_size); if ( dbc->xhc_mmio == NULL ) return false; @@ -979,6 +983,9 @@ static bool dbc_ensure_running(struct dbc *dbc) uint32_t ctrl; uint16_t cmd; + if ( dbc->suspended ) + return false; + if ( dbc->share != XHCI_SHARE_NONE ) { /* @@ -1213,9 +1220,11 @@ static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) * page, so keep it simple. */ if ( rangeset_add_range(mmio_ro_ranges, - PFN_DOWN(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset), - PFN_UP(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset + - sizeof(*uart->dbc.dbc_reg)) - 1) ) + PFN_DOWN((uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + + uart->dbc.xhc_dbc_offset), + PFN_UP((uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + + uart->dbc.xhc_dbc_offset + + sizeof(*uart->dbc.dbc_reg)) - 1) ) printk(XENLOG_INFO "Error while adding MMIO range of device to mmio_ro_ranges\n"); #endif @@ -1255,6 +1264,38 @@ static void cf_check dbc_uart_flush(struct serial_port *port) set_timer(&uart->timer, goal); } +static void cf_check dbc_uart_suspend(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + dbc_pop_events(dbc); + stop_timer(&uart->timer); + dbc->pci_cr = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + dbc->suspended = true; +} + +static void cf_check dbc_uart_resume(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, dbc->bar_val & 0xFFFFFFFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, dbc->bar_val >> 32); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, dbc->pci_cr); + + if ( !dbc_init_dbc(dbc) ) + { + dbc_error("resume failed\n"); + return; + } + + dbc_enable_dbc(dbc); + dbc->suspended = false; + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); +} + static struct uart_driver dbc_uart_driver = { .init_preirq = dbc_uart_init_preirq, .init_postirq = dbc_uart_init_postirq, @@ -1262,6 +1303,8 @@ static struct uart_driver dbc_uart_driver = { .putc = dbc_uart_putc, .getc = dbc_uart_getc, .flush = dbc_uart_flush, + .suspend = dbc_uart_suspend, + .resume = dbc_uart_resume, }; /* Those are accessed via DMA. */ -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 02:55:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 02:55:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408255.651042 (Exim 4.92) (envelope-from ) id 1oZNz2-0000sO-Ga; Sat, 17 Sep 2022 02:55:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408255.651042; Sat, 17 Sep 2022 02:55:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNz2-0000sG-DM; Sat, 17 Sep 2022 02:55:08 +0000 Received: by outflank-mailman (input) for mailman id 408255; Sat, 17 Sep 2022 02:55:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZNw2-0002wS-3w for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 02:52:02 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b2f6f342-3633-11ed-9761-273f2230c3a0; Sat, 17 Sep 2022 04:51:59 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0D4AB5C00A9; Fri, 16 Sep 2022 22:51:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 16 Sep 2022 22:51:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 22:51:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2f6f342-3633-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663383119; x=1663469519; bh=IOSjuCul4w NhkTi/wMpmUnl0G6R+XqWCZmHQlR92CgM=; b=qiyCpUjq+YPAbKEg+TibaXgOFr KJk2VQViikzQS2hZcUWFZjbb0BdDjTHcWXrcXiokaEJU02Rs5RFq8scf4E0XMNFw g+Mnqj8jz8MHM3PS8kEJw3+YqL+5ya4HHnQpel+tO2AN8Z7Z0BUDCOzOEKw4qqyV Egva0vf2N4UAGXOzg/zt/tVYHm5szmxsD4BX5rY95MwrEuccZMx2AP+XQD8i+z1o jlJymD7FBp8IkyVwKivpyKi/DzhqVfjxIhwwAZxOx6v8CMx8Sx+V+lIq0ifbyse9 LgoEIrmvpr0YWgQh/UVIVUuPHe+bdieKQ1kAjdErkz18WlZTwDFtpTFUYzNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663383119; x= 1663469519; bh=IOSjuCul4wNhkTi/wMpmUnl0G6R+XqWCZmHQlR92CgM=; b=h b9tVyw/6wwWYFb8YC5xfiNup5lirrUJRu8AJJqCF/z9Prl0B4bWiw6iOaHyN/rVC XT+VT5d4d6R0BvhVtK8mgk9DtYjAOX/yRjzYJ26zx0ZqIotNGdvAfZGB5s7XGR1R mFbS8zL2TB21GgcuYkOdEQdPnKORlzDdHe6hHjuoNQp7Jn35d5xdIMcpPApb2b6g YsgX9H1XFzG3ztUTrPf1IJiti3PEt/ac4bv6dChHbXoa94kWvNsVCzaS+qPueMZV ftmGW+Wcbo71r0+VG2WCTHegVLW6R+7/xmOem5Z8/3gARPBsTTicZzr5rXjkosJU G5o06IIMozrQTfA5tV8jA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v7 11/11] drivers/char: add console=ehci as an alias for console=dbgp Date: Sat, 17 Sep 2022 04:51:30 +0200 Message-Id: <6832b5dd97a1cd09ea8060e64fe1e8c8310e4974.1663383053.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make it consistent with console=xhci. Suggested-by: Jan Beulich Signed-off-by: Marek Marczykowski-Górecki --- docs/misc/xen-command-line.pandoc | 4 ++-- xen/drivers/char/serial.c | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 1c755563c40d..74b519f0c5bd 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -409,7 +409,7 @@ The following are examples of correct specifications: Specify the size of the console ring buffer. ### console -> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | xhci | none ]` +> `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | ehci | xhci | none ]` > Default: `console=com1,vga` @@ -428,7 +428,7 @@ cleared. This allows a single port to be shared by two subsystems `pv` indicates that Xen should use Xen's PV console. This option is only available when used together with `pv-in-pvh`. -`dbgp` indicates that Xen should use a USB2 debug port. +`dbgp` or `ehci` indicates that Xen should use a USB2 debug port. `xhci` indicates that Xen should use a USB3 debug port. diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c index 9d9445039232..00efe69574f3 100644 --- a/xen/drivers/char/serial.c +++ b/xen/drivers/char/serial.c @@ -311,6 +311,12 @@ int __init serial_parse_handle(const char *conf) goto common; } + if ( !strncmp(conf, "ehci", 4) && (!conf[4] || conf[4] == ',') ) + { + handle = SERHND_DBGP; + goto common; + } + if ( !strncmp(conf, "xhci", 4) && (!conf[4] || conf[4] == ',') ) { handle = SERHND_XHCI; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Sat Sep 17 04:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 04:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408285.651053 (Exim 4.92) (envelope-from ) id 1oZPgo-0003yh-Fh; Sat, 17 Sep 2022 04:44:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408285.651053; Sat, 17 Sep 2022 04:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZPgo-0003ya-Cw; Sat, 17 Sep 2022 04:44:26 +0000 Received: by outflank-mailman (input) for mailman id 408285; Sat, 17 Sep 2022 04:44:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZPgm-0003yQ-Uv; Sat, 17 Sep 2022 04:44:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZPgm-0005lr-RM; Sat, 17 Sep 2022 04:44:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZPgm-00005q-Fu; Sat, 17 Sep 2022 04:44:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZPgm-0007ZP-FG; Sat, 17 Sep 2022 04:44:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nF0ekdTuK1FusNPSuUuqQkOdnZjK+V4xvUUyl4TSEV8=; b=uh7KKG8A/KJGpiP4U5FvJonwqD L7R6QwQkjH+Gsmv6Em3qMJVvU23Hyt1PKm9humoi/oGcChlXX8bRKlTjqEFpWhZ9q7GAP8JUM9Exv 3YXPAUWVgzmMV4UsmPMW1U+rUWos39tyN31Smy3+1NZyWpqinlzwq9hMv8tHfBmlhLuo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173242: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-5.4:build-armhf::broken:regression linux-5.4:build-armhf:host-build-prep:fail:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sat, 17 Sep 2022 04:44:24 +0000 flight 173242 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173242/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 5 host-build-prep fail REGR. vs. 172128 build-i386-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-amd64-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 173235 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 173235 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 173235 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 173235 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked in 173235 n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173235 blocked in 172128 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173235 like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail in 173235 like 172108 test-armhf-armhf-xl-credit2 14 guest-start fail in 173235 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173235 like 172128 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173235 never pass test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 44 days Failing since 172384 2022-08-11 11:13:58 Z 36 days 79 attempts Testing same since 173213 2022-09-15 15:14:56 Z 1 days 4 attempts ------------------------------------------------------------ 544 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. (No revision log; it would be 17161 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 17 08:33:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 08:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408295.651063 (Exim 4.92) (envelope-from ) id 1oZTFt-0001UO-0q; Sat, 17 Sep 2022 08:32:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408295.651063; Sat, 17 Sep 2022 08:32:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZTFs-0001UH-US; Sat, 17 Sep 2022 08:32:52 +0000 Received: by outflank-mailman (input) for mailman id 408295; Sat, 17 Sep 2022 08:32:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZTFr-0001U7-Qt; Sat, 17 Sep 2022 08:32:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZTFr-00022B-Na; Sat, 17 Sep 2022 08:32:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZTFr-00057q-5w; Sat, 17 Sep 2022 08:32:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZTFr-0003Ev-5W; Sat, 17 Sep 2022 08:32:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CvDQUGmE/bwm8oFhWqmuC+C6w6dRnmTZ/cw2lklyOY0=; b=sMuNmPmrsFm61JALehO/byECFq gpKdbGMdO/XWB0vuKrnq1Ud+2BNPa/jd+4HRGzHaITEbctUTOSNSRizS/zJW5D16SngKXuoHaZ5pe mFD97pXATCyKZX9ik59BhdKJgMGjp49qHaRtJrPjmoBq/LOu7NYS0JM8TBwJIw0hLBzo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173244: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression qemu-mainline:build-amd64-libvirt:libvirt-build:fail:regression qemu-mainline:build-i386-libvirt:libvirt-build:fail:regression qemu-mainline:build-arm64-libvirt:libvirt-build:fail:regression qemu-mainline:build-armhf-libvirt:libvirt-build:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 17 Sep 2022 08:32:51 +0000 flight 173244 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173244/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 172123 build-amd64-libvirt 6 libvirt-build fail in 173237 REGR. vs. 172123 build-i386-libvirt 6 libvirt-build fail in 173237 REGR. vs. 172123 build-arm64-libvirt 6 libvirt-build fail in 173237 REGR. vs. 172123 build-armhf-libvirt 6 libvirt-build fail in 173237 REGR. vs. 172123 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 173237 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked in 173237 n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked in 173237 n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 173237 n/a test-amd64-i386-libvirt 1 build-check(1) blocked in 173237 n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked in 173237 n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 173237 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 173237 n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked in 173237 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 173237 n/a test-armhf-armhf-libvirt 1 build-check(1) blocked in 173237 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 173237 n/a test-amd64-amd64-libvirt 1 build-check(1) blocked in 173237 n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked in 173237 n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked in 173237 n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked in 173237 n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 172123 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 172123 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 172123 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 44 days Failing since 172148 2022-08-04 21:39:38 Z 43 days 99 attempts Testing same since 173060 2022-09-08 07:34:59 Z 9 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7269 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 17 11:13:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 11:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408307.651078 (Exim 4.92) (envelope-from ) id 1oZVlL-00006q-LO; Sat, 17 Sep 2022 11:13:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408307.651078; Sat, 17 Sep 2022 11:13:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZVlL-00006j-Ho; Sat, 17 Sep 2022 11:13:31 +0000 Received: by outflank-mailman (input) for mailman id 408307; Sat, 17 Sep 2022 11:13:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZVlJ-00006Z-VA; Sat, 17 Sep 2022 11:13:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZVlJ-0004ip-Ql; Sat, 17 Sep 2022 11:13:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZVlJ-00019Z-CG; Sat, 17 Sep 2022 11:13:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZVlJ-0004Pl-Bp; Sat, 17 Sep 2022 11:13:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZL++AirrXbD+qdTCrsJopQIblmWV3mNWMhLLlEQzVCU=; b=m8t2wEjRcTS1MA12alH52EVNg1 fG2p0/IYFBgFG7wEWRPNFVDzR9MdbsQo/Z7+jfOG6LAxNvqBwE08En1gvxOqgyUxt9DsW2yQHkuQy 9QU+NexghW6pG8RZ4P90Hy44AbpaDA91W5ITm2vEjqxktjRoXl12MNbofXMSuxNqLzg8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173245: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Sat, 17 Sep 2022 11:13:29 +0000 flight 173245 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173245/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 173227 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173227 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 173227 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173227 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173227 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173227 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173227 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173227 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173227 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173227 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173227 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173227 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173245 2022-09-17 01:52:13 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Sep 17 13:28:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 13:28:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408319.651089 (Exim 4.92) (envelope-from ) id 1oZXrs-0004Re-CN; Sat, 17 Sep 2022 13:28:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408319.651089; Sat, 17 Sep 2022 13:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZXrs-0004RX-8x; Sat, 17 Sep 2022 13:28:24 +0000 Received: by outflank-mailman (input) for mailman id 408319; Sat, 17 Sep 2022 13:28:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZXrq-0004RN-Im; Sat, 17 Sep 2022 13:28:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZXrq-0006ws-Fw; Sat, 17 Sep 2022 13:28:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZXrq-0000Un-12; Sat, 17 Sep 2022 13:28:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZXrq-0000oX-0a; Sat, 17 Sep 2022 13:28:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p8wvdzwoycv/afLBkoW/xuX79E5hR+CdlooJu6vQJDM=; b=ZBBBojgWpuDaO7boZNhSw1vdG5 Dq7RZEkyj05O0rqNbrzlW96a2TG7GsvsC8PgNI9FKTeiyyuL5n+eyQ62chWoOnK/esryu/Q4zPujK +qmCV+fAzeDjwRjAgL9LfznU2H2lWqDU5G39GpmSNoXSIYRT9FKfuvs6ahJPH9BX7GUo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173246: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a335366bad1364a07f49df9da1fdfa6d411a5f39 X-Osstest-Versions-That: linux=b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 From: osstest service owner Date: Sat, 17 Sep 2022 13:28:22 +0000 flight 173246 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173246/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 172133 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 172133 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172133 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 172133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172133 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux a335366bad1364a07f49df9da1fdfa6d411a5f39 baseline version: linux b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Last test of basis 172133 2022-08-04 05:14:48 Z 44 days Failing since 172152 2022-08-05 04:01:26 Z 43 days 98 attempts Testing same since 173246 2022-09-17 02:01:08 Z 0 days 1 attempts ------------------------------------------------------------ 1798 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b44f2fd87919..a335366bad13 a335366bad1364a07f49df9da1fdfa6d411a5f39 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Sep 17 15:01:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 15:01:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408327.651100 (Exim 4.92) (envelope-from ) id 1oZZJj-0005n0-6N; Sat, 17 Sep 2022 15:01:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408327.651100; Sat, 17 Sep 2022 15:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZZJj-0005mt-3A; Sat, 17 Sep 2022 15:01:15 +0000 Received: by outflank-mailman (input) for mailman id 408327; Sat, 17 Sep 2022 15:01:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZZJi-0005mT-Df; Sat, 17 Sep 2022 15:01:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZZJi-00009Z-9G; Sat, 17 Sep 2022 15:01:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZZJh-0003oS-O1; Sat, 17 Sep 2022 15:01:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZZJh-0005Y2-NZ; Sat, 17 Sep 2022 15:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BfukpGIALSZuWOjCmpq9e2R/qLE2C9UWd58OoCnxqc8=; b=NSrGvv42XcEcvK/Cq8PH4rj82F Do7l1huO6xAU3pcQdx076IGK1Wag3dA+X09GpS0K6iBcpKGJ8aZ7NEwHClB1VQ3XHrrQ9ni/EeJ04 B5jLAexN4bKZ0LOaBv0aaThYlmlAtRzZmZ9ytczkYB7/e5c6K7hbaqlvYHzjti26JjwY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173247: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=c83c6e4e7a68767ba69159bc0316884fa81158c4 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 17 Sep 2022 15:01:13 +0000 flight 173247 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173247/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 151777 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 151777 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: libvirt c83c6e4e7a68767ba69159bc0316884fa81158c4 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 799 days Failing since 151818 2020-07-11 04:18:52 Z 798 days 780 attempts Testing same since 173205 2022-09-15 04:20:23 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Carlos Bilbao Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe de Dinechin Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dario Faggioli David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao jiangjiacheng Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Ludek Janda Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Oleksandr Tyshchenko Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 2c846fa6bc..c83c6e4e7a c83c6e4e7a68767ba69159bc0316884fa81158c4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Sep 17 17:29:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 17:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408348.651110 (Exim 4.92) (envelope-from ) id 1oZbdE-000390-M0; Sat, 17 Sep 2022 17:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408348.651110; Sat, 17 Sep 2022 17:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZbdE-00038t-JK; Sat, 17 Sep 2022 17:29:32 +0000 Received: by outflank-mailman (input) for mailman id 408348; Sat, 17 Sep 2022 17:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZbdD-00038j-RV; Sat, 17 Sep 2022 17:29:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZbdD-00037Y-La; Sat, 17 Sep 2022 17:29:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZbdD-0007Pq-9M; Sat, 17 Sep 2022 17:29:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZbdD-0001ID-8s; Sat, 17 Sep 2022 17:29:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LZyvwy4Rmb4XrOz4MfE/4iajTBayqeKhwp1aphmT/z4=; b=bIdy5A+KbhDz5tHNCA0Nk67cLF iHWCraDzyin1fL/cWWl8gd6f9q9/svlRIAnzJF3QttCOgh31/V1hSxByJ+MFEm7mLGVPz2dIPTYdi qkqbCK4oWMviWZeF9tdh6msNZo5jdT9RZNnqHeZeFwW0xosKOQtAMg7keYms/wj0B13E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173248: regressions - FAIL X-Osstest-Failures: linux-5.4:build-armhf::broken:regression linux-5.4:build-amd64-libvirt:libvirt-build:fail:regression linux-5.4:build-i386-libvirt:libvirt-build:fail:regression linux-5.4:build-arm64-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf-libvirt:libvirt-build:fail:regression linux-5.4:build-armhf:host-build-prep:fail:regression linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sat, 17 Sep 2022 17:29:31 +0000 flight 173248 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173248/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 173242 build-amd64-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-i386-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-arm64-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-armhf-libvirt 6 libvirt-build fail in 173235 REGR. vs. 172128 build-armhf 5 host-build-prep fail in 173242 REGR. vs. 172128 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail in 173242 pass in 173248 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 173235 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 173235 test-arm64-arm64-xl-credit2 8 xen-boot fail pass in 173242 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173242 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 173235 n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt 1 build-check(1) blocked in 173235 n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 173235 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked in 173235 n/a test-armhf-armhf-libvirt 1 build-check(1) blocked in 173235 n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt 1 build-check(1) blocked in 173235 n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked in 173235 n/a test-armhf-armhf-examine 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked in 173242 n/a build-armhf-libvirt 1 build-check(1) blocked in 173242 n/a test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 172128 test-armhf-armhf-xl-credit2 14 guest-start fail in 173235 like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173235 like 172128 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173235 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173235 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173235 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 172108 test-armhf-armhf-xl-vhd 13 guest-start fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 172128 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 44 days Failing since 172384 2022-08-11 11:13:58 Z 37 days 80 attempts Testing same since 173213 2022-09-15 15:14:56 Z 2 days 5 attempts ------------------------------------------------------------ 544 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. (No revision log; it would be 17161 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 17 21:40:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 21:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408359.651131 (Exim 4.92) (envelope-from ) id 1oZfXU-0001hp-3q; Sat, 17 Sep 2022 21:39:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408359.651131; Sat, 17 Sep 2022 21:39:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZfXU-0001hi-0k; Sat, 17 Sep 2022 21:39:52 +0000 Received: by outflank-mailman (input) for mailman id 408359; Sat, 17 Sep 2022 21:39:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZfXS-0001hc-9p for xen-devel@lists.xenproject.org; Sat, 17 Sep 2022 21:39:50 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 402e9231-36d1-11ed-a31c-8f8a9ae3403f; Sat, 17 Sep 2022 23:39:49 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id l8so12847213wmi.2 for ; Sat, 17 Sep 2022 14:39:47 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id 185-20020a1c02c2000000b003b482fbd93bsm7096378wmc.24.2022.09.17.14.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Sep 2022 14:39:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 402e9231-36d1-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=UuxlmufKDaO+uVhqh434cR8OZGtikvtxCDQMwyzPUDg=; b=VNJkQefiZ8CtsVmyF/p0QFLF9afGazBT24Og6lL6U+0jm/ABVUFt2C9T7VeQcOTH1y bCAxUfca3sJdfduGFWYtQE07kDzw8UdREKg4SzRiWX/3edcUWApA3lRpsfbsrt5n9a+C DWiYNSuywVbl+AOWYctjMBB46x6KKWXMX8wBeO8yv5T6kGeUZ0g6Wv9zsRF+L3yIf8Uh Zave+cjPU2gUI6NCyDKt5KAS9IEVEKFsFyFAmZEiqFdweiJ6GldwxCq8MMXVzRdDo4iC jLUwOYU/P1RA/fRTnZuL86YRQ/WgKIre9EKcs5N+iT9Rd53pYQ3Vzb27ag2kaf8DZQ// 2J9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=UuxlmufKDaO+uVhqh434cR8OZGtikvtxCDQMwyzPUDg=; b=d5zzVeJhhyxiozqN0ZxdH0jE8cnQs+KsuUo8rTUpHiB7LKEWM8L95E96HN87llvl6/ mX6PP//L+DydJoONUqzJUpIOPJZUSjtwm0GUse/gS84+uzJ77kC61BBMeutNevwG8+TL MM7JQN1icgjAXg8MlWpxQezy2Sk+RzRzNkpnQ8vOA4M6FNbYcCKG673UW3seKuUFnTzw Qg4/Z+8TdgRwr3m2NRa1AQeIIl2iHs1di6FQeMOCZriPn18m58UT+k0Olvnc/zbUFc7j GeLpPeTU7j3rGwFilCip3mjuMIe72FCPSnok1NEeuZPW8XkwRyo2DBpEuvCrUbeXJQJe 18lg== X-Gm-Message-State: ACrzQf0zuQR+p0sVApMPGn4/toUL8Ismg/kUL3hjSdDwO8acZpEYnLX2 siC2AbyBNcMVN9u8bPqYR9A= X-Google-Smtp-Source: AMsMyM4VEzNjWX+DIvRxsRDeKWviiS3epJjRpOEM+YnLjCI5zY7u4P4YPCVZcwzu2u1ARLSCnLzOvg== X-Received: by 2002:a05:600c:33a8:b0:3b4:874c:f48f with SMTP id o40-20020a05600c33a800b003b4874cf48fmr7392003wmp.131.1663450786853; Sat, 17 Sep 2022 14:39:46 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <9af8b91d-92d4-7e6e-2c8c-34bc29859d46@amsat.org> Date: Sat, 17 Sep 2022 23:39:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 2/4] scripts/ci/setup: Fix libxen requirements Content-Language: en-US To: "Lucas Mateus Castro(alqotel)" , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Thomas Huth , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Daniel Henrique Barboza , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:Xen CPUs" References: <20220914124153.61017-1-lucas.araujo@eldorado.org.br> <20220914124153.61017-3-lucas.araujo@eldorado.org.br> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220914124153.61017-3-lucas.araujo@eldorado.org.br> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/9/22 14:41, Lucas Mateus Castro(alqotel) wrote: > From: "Lucas Mateus Castro (alqotel)" > > XEN hypervisor is only available in ARM and x86, but the yaml only > checked if the architecture is different from s390x, changed it to > a more accurate test. > Tested this change on a Ubuntu 20.04 ppc64le. > > Signed-off-by: Lucas Mateus Castro (alqotel) > Reviewed-by: Alex Bennée > --- > scripts/ci/setup/build-environment.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml > index 6df3e61d94..7535228685 100644 > --- a/scripts/ci/setup/build-environment.yml > +++ b/scripts/ci/setup/build-environment.yml > @@ -97,7 +97,7 @@ > state: present > when: > - ansible_facts['distribution'] == 'Ubuntu' > - - ansible_facts['architecture'] != 's390x' > + - ansible_facts['architecture'] == 'aarch64' or ansible_facts['architecture'] == 'x86_64' > > - name: Install basic packages to build QEMU on Ubuntu 20.04 > package: Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Sat Sep 17 22:11:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 17 Sep 2022 22:11:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408373.651142 (Exim 4.92) (envelope-from ) id 1oZg2K-0005zW-Nm; Sat, 17 Sep 2022 22:11:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408373.651142; Sat, 17 Sep 2022 22:11:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZg2K-0005zP-L0; Sat, 17 Sep 2022 22:11:44 +0000 Received: by outflank-mailman (input) for mailman id 408373; Sat, 17 Sep 2022 22:11:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZg2K-0005zF-2P; Sat, 17 Sep 2022 22:11:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZg2J-0007zb-TX; Sat, 17 Sep 2022 22:11:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZg2J-000416-DZ; Sat, 17 Sep 2022 22:11:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZg2J-0003lk-D1; Sat, 17 Sep 2022 22:11:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R7cSNgND6B2Fj4xh2cQb1KSRzbTSLPICCkJjpbLWEQE=; b=mkwhq4+Ue2yg839olRhoFByAr9 1skcTtBfvKR92KOJpHDao8K9vZVT6Rz0NtVa2gUF6k3xM7hcKSuB3NLl9gOM02OqLACgGvXPcelLZ 8kHnaTyivs1bMuAXTiGK4Alj9IIry0O3Fs/YJCPvYfo9DG7lHs34wmMTcY1Z5ggEw5R0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173249: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 X-Osstest-Versions-That: qemuu=2480f3bbd03814b0651a1f74959f5c6631ee5819 From: osstest service owner Date: Sat, 17 Sep 2022 22:11:43 +0000 flight 173249 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173249/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 172123 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 172123 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172123 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 172123 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172123 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172123 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 baseline version: qemuu 2480f3bbd03814b0651a1f74959f5c6631ee5819 Last test of basis 172123 2022-08-03 18:10:07 Z 45 days Failing since 172148 2022-08-04 21:39:38 Z 44 days 100 attempts Testing same since 173060 2022-09-08 07:34:59 Z 9 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Akihiko Odaki Alex Bennée Alexey Baturo Alexey Kardashevskiy Alistair Francis Andrea Bolognani Anton Kochkov Anup Patel Atish Patra Atish Patra BALATON Zoltan Bin Meng Bin Meng Christian Borntraeger Conor Dooley Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Daniel P. Berrangé Dao Lu David Hildenbrand dramforever eop Chen eopXD Eugenio Pérez Frédéric Pétrot Gerd Hoffmann Heiko Stuebner Helge Deller Igor Mammedov Ilya Leoshkevich Jason A. Donenfeld Jason Wang John Millikin John Snow Jonathan Cameron Junqiang Wang Kevin Wolf Laurent Vivier Leonardo Bras Lucas Mateus Castro (alqotel) Marc-André Lureau Mark Cave-Ayland Markus Armbruster Matheus Tavares Bernardino Michael S. Tsirkin Nicholas Piggin Paolo Bonzini Paul Brook Pavel Dovgalyuk Peter Maydell Philippe Mathieu-Daudé Priyankar Jain Qi Hu Qiang Liu Rahul Pathak Richard Henderson Richard W.M. Jones Samuel Thibault Song Gao Stafford Horne Stefan Hajnoczi Stefan Weil Thomas Huth Tomasz Martyniak Victor Toso Vitaly Buka Vitaly Kuznetsov Weiwei Li Wilfred Mallawa Xiaojuan Yang Xuzhou Cheng Yonggang Luo Yueh-Ting (eop) Chen Zenghui Yu Zhang Chen Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 2480f3bbd0..79dfa177ae 79dfa177ae348bb5ab5f97c0915359b13d6186e2 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Sep 18 01:02:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 18 Sep 2022 01:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408381.651153 (Exim 4.92) (envelope-from ) id 1oZigv-00048f-En; Sun, 18 Sep 2022 01:01:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408381.651153; Sun, 18 Sep 2022 01:01:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZigv-00048Y-BV; Sun, 18 Sep 2022 01:01:49 +0000 Received: by outflank-mailman (input) for mailman id 408381; Sun, 18 Sep 2022 01:01:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZigu-00048O-4d; Sun, 18 Sep 2022 01:01:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZigu-0004MY-0C; Sun, 18 Sep 2022 01:01:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZigt-0001js-Io; Sun, 18 Sep 2022 01:01:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZigt-00067y-IK; Sun, 18 Sep 2022 01:01:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EF0kLFRKD2AK/zDidcFKt+Lby8vxrf3daSgK9+Q1tf4=; b=hyIBl4lqmuWJOPD0hqrrXmBkRO oAa3mdIqSLj0AIwgFKcqBQ8CVCTrGW29GBvLr6179fEig0YltTaUOlLAVM3Qv/QTJ1k6vTpzBe5OW 8P+pzCTROnkzuZrItXsmGsocWUdIvwduREm1euwl35fixTgTGcm74uCIng/sNRXTqGpw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173251: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 X-Osstest-Versions-That: linux=8d8935e76f6f419ef2f7617de252f258b6a597d3 From: osstest service owner Date: Sun, 18 Sep 2022 01:01:47 +0000 flight 173251 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173251/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 172108 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 172108 test-armhf-armhf-xl-multivcpu 14 guest-start fail like 172128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 172128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 172128 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 172128 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 172128 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 172128 test-armhf-armhf-xl-credit1 14 guest-start fail like 172128 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 172128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 172128 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 baseline version: linux 8d8935e76f6f419ef2f7617de252f258b6a597d3 Last test of basis 172128 2022-08-04 02:00:25 Z 44 days Failing since 172384 2022-08-11 11:13:58 Z 37 days 81 attempts Testing same since 173213 2022-09-15 15:14:56 Z 2 days 6 attempts ------------------------------------------------------------ 544 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 8d8935e76f6f..7e17397001a9 7e17397001a93541ffefdef553a3d541f9c1c8f8 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sun Sep 18 04:32:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 18 Sep 2022 04:32:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408397.651164 (Exim 4.92) (envelope-from ) id 1oZlyD-0007UP-GP; Sun, 18 Sep 2022 04:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408397.651164; Sun, 18 Sep 2022 04:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZlyD-0007UI-CZ; Sun, 18 Sep 2022 04:31:53 +0000 Received: by outflank-mailman (input) for mailman id 408397; Sun, 18 Sep 2022 04:31:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZlyB-0007U8-Vz; Sun, 18 Sep 2022 04:31:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZlyB-0005bm-RG; Sun, 18 Sep 2022 04:31:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZlyB-0004k3-59; Sun, 18 Sep 2022 04:31:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZlyB-0002xy-48; Sun, 18 Sep 2022 04:31:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NgAqeBTuA8fYEI/O9ceebDAkAWB78WCpyS4wiuOoKR0=; b=Q9eeCQXCNM8UKoDhpDwD13QJxh m21msiAmxWBtqZgqc7HtlYadBhlhPIWoGaX9Ql7PKqxZDshw/06eA2yXvB2zdLMUgV4ezK5X0pC2c XGcIJlQl+dLT9EA5HmCnxoZuy2hy3YkRz0kiehUWXr7HUxeqsTRMHEyGHLUlhQMwdkzY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173253: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d29201ff34a135cdfc197f4413c1c5047e4f58bb X-Osstest-Versions-That: qemuu=79dfa177ae348bb5ab5f97c0915359b13d6186e2 From: osstest service owner Date: Sun, 18 Sep 2022 04:31:51 +0000 flight 173253 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173253/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 173249 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 173230 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 173244 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173249 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173249 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173249 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173249 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173249 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173249 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173249 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173249 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu d29201ff34a135cdfc197f4413c1c5047e4f58bb baseline version: qemuu 79dfa177ae348bb5ab5f97c0915359b13d6186e2 Last test of basis 173249 2022-09-17 08:36:42 Z 0 days Testing same since 173253 2022-09-17 22:39:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Dongli Zhang Dr. David Alan Gilbert Enrik Berkhan Hao Wu Laurent Vivier Max Filippov Peter Maydell Richard Henderson Ross Lagerwall Stefan Berger Stefan Hajnoczi zhenwei pi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 79dfa177ae..d29201ff34 d29201ff34a135cdfc197f4413c1c5047e4f58bb -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Sep 18 11:20:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 18 Sep 2022 11:20:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408407.651175 (Exim 4.92) (envelope-from ) id 1oZsLd-0004SU-VX; Sun, 18 Sep 2022 11:20:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408407.651175; Sun, 18 Sep 2022 11:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZsLd-0004SN-SS; Sun, 18 Sep 2022 11:20:29 +0000 Received: by outflank-mailman (input) for mailman id 408407; Sun, 18 Sep 2022 11:20:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZsLb-0004Ru-V1; Sun, 18 Sep 2022 11:20:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZsLb-00053h-Qu; Sun, 18 Sep 2022 11:20:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZsLb-0001gb-Bu; Sun, 18 Sep 2022 11:20:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oZsLb-0008RU-BT; Sun, 18 Sep 2022 11:20:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rJGGRONA9Vxf45FPzUpPQvPvpaJ6x/veinMPYHnQj8Y=; b=3I9LdHUM8MdudtlTlZ7OGY+zvE ZfTBBDc+lUFt/53kKMZOh8BC77o/ULAlG8Xzvipt/9LrcScsiKkp3OyxzTrMQOWlUMI6BtJT5yYje DxPOqIlURSkPqDlkOIYV9xVxEa9wmuDzqil9/cSrDbc0IQyPuqm/A+RGzZAFp+lVAx/M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173254: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Sun, 18 Sep 2022 11:20:27 +0000 flight 173254 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173254/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 12 debian-install fail pass in 173245 test-armhf-armhf-xl-vhd 12 debian-di-install fail pass in 173245 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail pass in 173245 test-armhf-armhf-xl-credit2 12 debian-install fail pass in 173245 test-armhf-armhf-xl-rtds 12 debian-install fail pass in 173245 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail in 173245 blocked in 173254 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173245 blocked in 173254 test-armhf-armhf-libvirt 15 migrate-support-check fail in 173245 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173245 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 173245 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173245 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173245 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173245 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 173245 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173245 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173245 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173245 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173245 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173245 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173245 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173245 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173245 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173245 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173245 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173245 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173254 2022-09-18 01:54:52 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Sep 18 12:42:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 18 Sep 2022 12:42:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408416.651186 (Exim 4.92) (envelope-from ) id 1oZtcY-00041v-2D; Sun, 18 Sep 2022 12:42:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408416.651186; Sun, 18 Sep 2022 12:42:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZtcX-00041o-VJ; Sun, 18 Sep 2022 12:42:01 +0000 Received: by outflank-mailman (input) for mailman id 408416; Sun, 18 Sep 2022 12:42:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZtcX-00041i-1H for xen-devel@lists.xenproject.org; Sun, 18 Sep 2022 12:42:01 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46a109ea-374f-11ed-a31c-8f8a9ae3403f; Sun, 18 Sep 2022 14:41:58 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 34C7C5C017F; Sun, 18 Sep 2022 08:41:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 18 Sep 2022 08:41:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Sep 2022 08:41:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46a109ea-374f-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1663504914; x=1663591314; bh=bKbdWKvAtc oz9rUvoSebxEYZUmTL5GNyMUEKwzf4WLU=; b=t2tGHHdT6mR3Dzm45cLy2c0N45 czn2DpDXwmJcUqdFxPZd4t0TIkVsTTjXw1k5CM1o4dB97ptpurCZM1fe04madBt0 dJYJ+rPrN3Cg2J7MHaVgOOVckLWZr4Yo8cdqvS7Aq8fw/ataY+Shr1J0wiUMPzKO 6kxhgXcdi1ijpPBlWMA0bALNWAC7wANzWdCQByS7kQKVdzVBI4LOtTJJejRLgIWF kWktJv9kvIj8O2bi1EGaaNG3kn/QnCRspS5WZqIMJSvKSTQ3afbtGeRGUVMD7gG6 4pVZ4ZAr3DelTmLtflgguDEy8qTqKH5P773ObSac51Th+Mp9bwxL1im66bZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663504914; x= 1663591314; bh=bKbdWKvAtcoz9rUvoSebxEYZUmTL5GNyMUEKwzf4WLU=; b=g 3+MCzkuB6BzFOCFNv6/H9boIdyDFvZf5lng7cUTn7MstVkeGcNVuZ9TKKy9xN0Eo IcIfNbjuU52hzERz1/ZCfKALGIgtQzS6PxnwIb1cSr4l1orvue77A8j5JvWT9d5H OMXZ7C4QE8VfsTP6ujbvSOFaP0Kt02ntQk0P0ecUw2kWrfWXFaiMo6rD8WuM7ctv 6fiBvh/C1OkaOq2/rgAEIaVmeX1WerY2X//M/tr85/aqGpLlZsZIwushNzt6U7cx nA7DN8rLNkqI5XAP83GTJUHWszmOWL5YypbB8A296Vuof9/xHJREK9D9x2X/Mmz/ MiN23exWXm3SEpcFU7Wag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvhedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggusehgtderredttddvnecuhfhrohhmpeffvghmihcuofgr rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg gsrdgtohhmqeenucggtffrrghtthgvrhhnpedujefgjeeggeelhfevkeeltdekvdeuhfet iefffefhkeehhfevhefhkefgudegkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggs rdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Sun, 18 Sep 2022 08:41:25 -0400 From: Demi Marie Obenour To: Xen developer discussion , netdev@vger.kernel.org Subject: Layer 3 (point-to-point) netfront and netback drivers Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="abVE5BDavORpi+Qm" Content-Disposition: inline --abVE5BDavORpi+Qm Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 18 Sep 2022 08:41:25 -0400 From: Demi Marie Obenour To: Xen developer discussion , netdev@vger.kernel.org Subject: Layer 3 (point-to-point) netfront and netback drivers How difficult would it be to provide layer 3 (point-to-point) versions of the existing netfront and netback drivers? Ideally, these would share almost all of the code with the existing drivers, with the only difference being how they are registered with the kernel. Advantages compared to the existing drivers include less attack surface (since the peer is no longer network-adjacent), slightly better performance, and no need for ARP or NDP traffic. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --abVE5BDavORpi+Qm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMnEg8ACgkQsoi1X/+c IsFkEg/8CWRHrWImZE0hPlNZ9964WWkwqv1l9jOWxrPGFS06OEjgvaVqr7bgNPlm S6tBi9Nh56qNDt6O5QIHtrnFF9oxr74LUq2d9onPQAsClpa655wuHohsEwN73iMg nvuF9Z/4aCkaExU14U2xxVKbH0PNSf9nW0raUzhoE3DH4gXYT3xTCsVA2Nw4+rVc p/DhtylzMs9A2Bk0HaYXIJUtpR7MRL17fi9CDStrXmAbP0naiwSnzHcKkccN/mox cC/cZvGl0t6Y2ZPnfI0eBkmmW94tf4M8alJtAQyAwVYjHhwMjogIN4mbcJkqfhhW pN3aT9RIhfI2EUUiKUmVTF8HFlgdRzn4GiemjnPYbQYTS39cQ0OZIxIvL1LGCfua s2Hsdz8FH36kIamGnHioNocyu9/nZBJOQDGATGM0/1Vk+P7wfC1ZJE4t4cgqPEde EdcSz4ck48dXH4LVRKpWAL5qI50ZHeNXzBF7lS7AurBDtEH1C1JVaA3puVd/TjAg mQcBDemE3fqWhH5II3ITZdwnVbmbz35vMuwxAO4EzUqRwDv2M8SR9QLjxxPN0AdA MM88y5yQcpOTSYh5kHgaokiSaQ+9ZUuYOpraJLiBlaxud+42cN1e4lZB23s+UPAz VVIXnrvBZYuFRF2PMqNOMKolStQrL+xEk6MNOj1h+H//YW1imAE= =b4ml -----END PGP SIGNATURE----- --abVE5BDavORpi+Qm-- From xen-devel-bounces@lists.xenproject.org Sun Sep 18 13:19:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 18 Sep 2022 13:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408423.651196 (Exim 4.92) (envelope-from ) id 1oZuD5-0007Rm-VA; Sun, 18 Sep 2022 13:19:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408423.651196; Sun, 18 Sep 2022 13:19:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZuD5-0007Rf-SZ; Sun, 18 Sep 2022 13:19:47 +0000 Received: by outflank-mailman (input) for mailman id 408423; Sun, 18 Sep 2022 13:19:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZuD4-0007RZ-B5 for xen-devel@lists.xenproject.org; Sun, 18 Sep 2022 13:19:46 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f2ce39e-3754-11ed-a31c-8f8a9ae3403f; Sun, 18 Sep 2022 15:19:44 +0200 (CEST) Received: from [192.168.1.137] (host-87-17-203-39.retail.telecomitalia.it [87.17.203.39]) by support.bugseng.com (Postfix) with ESMTPSA id 10B024EE0780; Sun, 18 Sep 2022 15:02:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f2ce39e-3754-11ed-a31c-8f8a9ae3403f Message-ID: Date: Sun, 18 Sep 2022 15:02:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050929 Thunderbird/1.0.7 Fedora/1.0.7-1.1.fc4 Mnenhy/0.7.3.0 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Stefano Stabellini , roberto.bagnara@bugseng.com Cc: Bertrand Marquis , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , burzalodowa@gmail.com References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> From: Roberto Bagnara In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/09/22 02:52, Stefano Stabellini wrote: > +Roberto > > I think we need Roberto's advice on Rule 20.7. (Full thread below.) Hi there, sorry for the delay: I missed this message. Please see below, where I took the freedom of rearranging the cases. > The question is on the interpretation of Rule 20.7. Are parenthesis > required by Rule 20.7 in the following cases: > > - macro parameters used as function arguments > [...] > - macro parameter used as lhs in assignment You can obtain different semantics depending on whether parentheses are or are not used (in the macro call and/or macro expansion depending on the case): #include void g(int v) { printf("%d\n", v); } #define m1(x, y, ...) g(y) void f1(int x, int y, ...) { g(y); } #define p 0, 1 void test1() { m1(p, 2); f1(p, 2); } #define m4(x) x = 4 void f4(int &x) { x = 4; } void test4() { int y; int z; z = 3; m4(y = z); printf("%d\n", z); z = 3; f4(y = z); printf("%d\n", z); } int main() { test1(); test4(); } > - macro parameters used as macro arguments Please note that Rule 20.7 depends on the final expansion: so whether parentheses are or are not used in a certain macro body is irrelevant, the point being that, at the end of all expansions, expressions resulting from the expansion of macro parameters are enclosed in parentheses. > - macro parameter used as array index This is safe today, but my understanding is that in C++23 the [] operator will accept more than one expression. A similar change might (who knows?) be considered for C26 or even offered before (intentionally or by mistake) by some C compiler. > Some of these cases are interesting because they should function > correctly even without parenthesis, hence the discussion. In particular > parenthesis don't seem necessary at least for the function argument > case. This is not the right spirit for MISRA compliance: why would you want splitting hairs when inserting a pair of parentheses is so easy? C and C++ are very complex languages, and the MISRA coding standards are the result of a (very difficult!) compromise between simplicity and effectiveness: rules that are exactly targeted to all and only all the problematic instances would be very difficult to express and to remember. So, yes: in many cases you might spend time to demonstrate that a particular (real) MISRA violation does not imply the existence of a real issue, but this time is not well spent. Critical code must be boring and obviously right, in the sense that whomever is reading the code should not be distracted by thoughts like "there are no parentheses here: am I sure nothing bad can happen?" > Regardless of the MISRA C interpretation, Xenia noticed that Eclair > reports violations on these cases (cppcheck does not, I don't know other > checkers). I am not aware of any false positives (or flse negatives) for the current version of ECLAIR on Rule 20.7. Nonetheless, ECLAIR can be configured to selectively deviate on each of the cases mentioned above by means of checker configuration. However, as I said, it only makes sense deviating the rule in the cases where you are not allowed to add the parentheses (e.g., because both the macro definition and the macro invocations are in legacy code you are not allowed to touch). In contrast, cppcheck is no more than a toy when MISRA compliance is concerned. It claims to support 153 out of 175 MISRA C:2012 guidelines. For 103 of those 153 it has a significant number of false negatives (FN) and false positives (FP). I recently participated to an evaluation of cppcheck 2.8 and here is a summary I can disclose: Rule 1.3 FP Rule 2.1 FN Rule 2.2 FN+FP Rule 2.4 FN+FP Rule 2.5 FP Rule 2.7 FP Rule 3.2 FN Rule 4.2 FN Rule 5.1 FP Rule 5.3 FN Rule 5.6 FN+FP Rule 5.7 FN+FP Rule 5.8 FN+FP Rule 5.9 FN+FP Rule 6.1 FN+FP Rule 7.1 FN Rule 7.3 FN Rule 7.4 FN+FP Rule 8.1 FN Rule 8.2 FN+FP Rule 8.3 FN Rule 8.4 FP Rule 8.5 FN+FP Rule 8.6 FP Rule 8.7 FN Rule 8.8 FN Rule 8.9 FN Rule 8.10 FN Rule 8.13 FN Rule 8.14 FP Rule 9.1 FN+FP Rule 9.3 FN Rule 10.1 FN Rule 10.2 FN Rule 10.3 FN+FP Rule 10.4 FP Rule 10.5 FN+FP Rule 10.6 FP Rule 10.7 FN+FP Rule 10.8 FP Rule 11.1 FN+FP Rule 11.2 FN Rule 11.3 FN+FP Rule 11.4 FP Rule 11.5 FP Rule 11.7 FN Rule 11.8 FN+FP Rule 11.9 FN Rule 12.1 FN Rule 12.2 FP Rule 12.3 FP Rule 13.1 FN Rule 13.2 FN Rule 13.4 FP Rule 13.5 FN Rule 13.6 FP Rule 14.2 FN Rule 14.3 FN Rule 15.5 FN+FP Rule 15.6 FN+FP Rule 16.1 FN Rule 16.3 FN Rule 16.6 FP Rule 16.7 FP Rule 17.1 FP Rule 17.2 FN+FP Rule 17.4 FN Rule 17.5 FN Rule 17.7 FP Rule 18.1 FN Rule 18.3 FN Rule 18.4 FP Rule 19.1 FN Rule 19.2 FP Rule 20.2 FN Rule 20.4 FP Rule 20.5 FN Rule 20.7 FP Rule 20.9 FN Rule 20.10 FP Rule 20.12 FP Rule 21.1 FN+FP Rule 21.2 FN Rule 21.3 FP Rule 21.6 FP Rule 21.8 FN+FP Rule 21.12 FN Rule 21.13 FP Rule 21.14 FN Rule 21.15 FN Rule 21.16 FN+FP Rule 21.17 FN Rule 21.18 FN Rule 21.19 FN Rule 21.20 FN Rule 22.1 FP Rule 22.2 FN+FP Rule 22.5 FN Rule 22.6 FN Rule 22.7 FN Rule 22.8 FN+FP Rule 22.9 FN+FP Rule 22.10 FP These results are clearly relative to the testsuite employed: while very large, it cannot of course reach 100% coverage. For instance, if you noticed Rule 20.7 reports given by ECLAIR and not by cppcheck, then maybe line Rule 20.7 FP should be Rule 20.7 FN+FP If you can let me have an indication of the code that ECLAIR is flagging for Rule 20.7 and cppcheck does not flag, I will be happy to double-check. While the sheer amount of false negatives of cppcheck 2.8 precludes its use for safety-related development, the many false positives are also a big problem: people will waste time investigating them and, unless they have been properly trained on the MISRA guidelines so as to be able to recognize false positives, they might be tempted to change the code when there is no reason to do so. When the latter thing happens, code quality will typically decrease. Kind regards, Roberto > On Fri, 2 Sep 2022, Xenia Ragiadakou wrote: >> On 9/2/22 05:07, Stefano Stabellini wrote: >>> On Thu, 1 Sep 2022, Bertrand Marquis wrote: >>>> Hi Xenia, >>>> >>>>> On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: >>>>> >>>>> >>>>> On 9/1/22 01:35, Stefano Stabellini wrote: >>>>>> Patches 1, 4, and 6 are already committed. I plan to commit patches 2, >>>>>> 3 >>>>>> and 5 in the next couple of days. >>>>>> Patch 7 needs further discussions and it is best addressed during the >>>>>> next MISRA C sync-up. >>>>> >>>>> I would like to share here, before the next MISRA C sync, my >>>>> understandings that will hopefully resolve a wrong impression of mine, >>>>> that I may have spread around, regarding this rule. >>>>> There was a misunderstanding regarding the rule 20.7 from my part and I >>>>> think that Jan is absolutely right that parenthesizing macro parameters >>>>> used as function arguments is not required by the rule. >>>>> >>>>> The rule 20.7 states "Expressions resulting from the expansion of macro >>>>> parameters shall be enclosed in parentheses" and in the rationale of the >>>>> rule states "If a macro parameter is not being used as an expression >>>>> then the parentheses are not necessary because no operators are >>>>> involved.". >>>>> >>>>> Initially, based on the title, my understanding was that it requires for >>>>> the expression resulting from the expansion of the macro to be enclosed >>>>> in parentheses. Then, based on the rule explanation and the examples >>>>> given, my understanding was that it requires the macro parameters that >>>>> are used as expressions to be enclosed in parentheses. >>>>> But, after re-thinking about it, the most probable and what makes more >>>>> sense, is that it require parentheses around the macro parameters that >>>>> are part of an expression and not around those that are used as >>>>> expressions. >>>>> >>>>> Therefore, macro parameters being used as function arguments are not >>>>> required to be enclosed in parentheses, because the function arguments >>>>> are part of an expression list, not of an expression (comma is evaluated >>>>> as separator, not as operator). >>>>> While, macro parameters used as rhs and lhs expressions of the >>>>> assignment operator are required to be enclosed in parentheses because >>>>> they are part of an assignment expression. >>>>> >>>>> I verified that the violation reported by cppcheck is not due to missing >>>>> parentheses around the function argument (though still I have not >>>>> understood the origin of the warning). Also, Eclair does not report it. >>>>> >>>>> Hence, it was a misunderstanding of mine and there is no inconsistency, >>>>> with respect to this rule, in adding parentheses around macro parameters >>>>> used as rhs of assignments. The rule does not require adding parentheses >>>>> around macro parameters used as function arguments and neither cppcheck >>>>> nor Eclair report violation for missing parentheses around macro >>>>> parameters used as function arguments. >>>> >>>> >>>> Thanks a lot for the detailed explanation :-) >>>> >>>> What you say does make sense and I agree with your analysis here, only >>>> protect when part of an expression and not use as a subsequent parameter >>>> (for a function or an other macro). >>> >>> Yeah I also agree with your analysis, and many thanks for >>> double-checking the cppcheck and Eclair's reports. >> >> Unfortunately in the specific case that I checked, it was not reported because >> it was actually an argument to a macro, not a function. >> Eclair does report as violations of Rule 20.7 the macro parameters that are >> used as function arguments and are not enclosed in parentheses. >> >> So, one tool reports it as violation and the other one not. >> >> The same goes, also, for the case where a macro parameter is used as index to >> an array. Eclair reports it as violation while cppcheck does not. > From xen-devel-bounces@lists.xenproject.org Sun Sep 18 23:20:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 18 Sep 2022 23:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408445.651208 (Exim 4.92) (envelope-from ) id 1oa3aA-0005R6-Pg; Sun, 18 Sep 2022 23:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408445.651208; Sun, 18 Sep 2022 23:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa3aA-0005Qy-Kx; Sun, 18 Sep 2022 23:20:14 +0000 Received: by outflank-mailman (input) for mailman id 408445; Sun, 18 Sep 2022 23:20:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa3a9-0005Qo-Kr; Sun, 18 Sep 2022 23:20:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa3a9-0001Ox-FQ; Sun, 18 Sep 2022 23:20:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa3a8-0005xo-RF; Sun, 18 Sep 2022 23:20:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oa3a8-00007H-Qn; Sun, 18 Sep 2022 23:20:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qYIBHSm+vHHm7pM9ez8lrgnL25jMjmD7hXKEk3a6DrQ=; b=y7Yn4BJauDf0eGjL8JLHQovsuL rB8rWKjJDBHobjGDRnJ43TjEzBTaF7KMTCwUSZplpd+7bSiez+sJ5KWwHNHM9BXNPHQvYiDPtCBGB EPCu2d8k0BAxaOXJS4P8p5PEupNApFxIfiVUd+bZDmFATNHs67YJr788kqxi2lYCmS7E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173255: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=38eddeedbbeac33f26845c29e7414b9313ea70db X-Osstest-Versions-That: linux=a335366bad1364a07f49df9da1fdfa6d411a5f39 From: osstest service owner Date: Sun, 18 Sep 2022 23:20:12 +0000 flight 173255 linux-linus real [real] flight 173256 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173255/ http://logs.test-lab.xenproject.org/osstest/logs/173256/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail pass in 173256-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail in 173256 like 173246 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173246 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173246 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173246 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173246 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173246 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173246 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173246 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 38eddeedbbeac33f26845c29e7414b9313ea70db baseline version: linux a335366bad1364a07f49df9da1fdfa6d411a5f39 Last test of basis 173246 2022-09-17 02:01:08 Z 1 days Testing same since 173255 2022-09-18 17:12:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jens Axboe Linus Torvalds Pavel Begunkov Stefan Metzmacher jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git a335366bad13..38eddeedbbea 38eddeedbbeac33f26845c29e7414b9313ea70db -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Sep 19 02:16:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 02:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408464.651219 (Exim 4.92) (envelope-from ) id 1oa6K8-0003ud-N9; Mon, 19 Sep 2022 02:15:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408464.651219; Mon, 19 Sep 2022 02:15:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa6K8-0003uV-Ii; Mon, 19 Sep 2022 02:15:52 +0000 Received: by outflank-mailman (input) for mailman id 408464; Mon, 19 Sep 2022 02:15:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa6K7-0003ss-Ep for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 02:15:51 +0000 Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [2001:4860:4864:20::2d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9625f74-37c0-11ed-a31c-8f8a9ae3403f; Mon, 19 Sep 2022 04:15:50 +0200 (CEST) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1274ec87ad5so60105907fac.0 for ; Sun, 18 Sep 2022 19:15:48 -0700 (PDT) Received: from localhost.localdomain ([2607:fb91:1108:ae0:6e73:b13c:9e3e:3750]) by smtp.gmail.com with ESMTPSA id q43-20020a056871082b00b00127616039e7sm7026064oap.29.2022.09.18.19.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Sep 2022 19:15:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9625f74-37c0-11ed-a31c-8f8a9ae3403f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stew.dk; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=vzgmi1/fG6Z0oTGCQSGRpxHTj5JtqrXJnowUsIznWHM=; b=BGML0tP5aOp54rI0rWltcEW741AHPXy518GlPfjwVoGyXqznCUp/Bso/9Hg6COH4x/ bYvlXU5G885jhnxw2LXI5GWgYHHqYvxKFo7Z3X4Ih7YG/gd0/PZXcdoseHdURZUbgyJF n+PuC+pLtoHw/9+RLK5ZsmVgcnhsNimyjafXs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=vzgmi1/fG6Z0oTGCQSGRpxHTj5JtqrXJnowUsIznWHM=; b=OIyTic36gBIkutf5r3xBZaJbvIjH6V9iimDppDEDi+ZOQ6rT8aD9cc1PMK5rCRvq+e 0+IkdDerYAtKXu32kE3yBo8SZNle4ukYkn6ONiAs03i/sFebqbXowuj+fzMJ+3OVOY62 yo9eQ8AXA+5Ibv1igLNaK9IJfQ7bs/igvbNa+QBnkLx2+U5I/JoYRfr+cjMELQVZ5lx9 GVZCKgPWyr2q3EwkneoeLp8Co9zUMc2H7L+PQ9lQJ6DwrWpGKGHYvBhVTUqsm5pmsyvu 7CXW8rbxfY8QsUhqkUoAKfvsfQ0m6loNTfk3feTk3Wp7sGhVeH3Y4NVS2QQlhVhvFPOz YjzQ== X-Gm-Message-State: ACrzQf3HFXg261T/k8JBYnKMs0BrK/DOjXMxmAvWtMfW5TX+gDEItiNi r0Gw1CpHzEnoAZXdA3cmFpX8o3AQIbSHADUYKe8= X-Google-Smtp-Source: AMsMyM7a59iJVp1cSsB4h2AMyU0RSoYugvNA9Ql+TsYLFpOBmKnM0lTBMVML4/2Qxk6w42lWml4p9Q== X-Received: by 2002:a05:6870:e99a:b0:12c:8a51:ba3f with SMTP id r26-20020a056870e99a00b0012c8a51ba3fmr6696900oao.276.1663553746926; Sun, 18 Sep 2022 19:15:46 -0700 (PDT) From: Stewart Hildebrand To: xen-devel@lists.xenproject.org Cc: Stewart Hildebrand , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Nathan Studer , Jeff Kubascik , Robbie VanVossen , xen-devel@dornerworks.com, Stewart Hildebrand Subject: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates Date: Sun, 18 Sep 2022 22:10:02 -0400 Message-Id: <20220919021002.2193665-1-stewart@stew.dk> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stewart Hildebrand Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e12c499a28..816656950a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -221,7 +221,8 @@ F: xen/include/xen/argo.h F: xen/common/argo.c ARINC653 SCHEDULER -M: Stewart Hildebrand +M: Nathan Studer +M: Stewart Hildebrand S: Supported L: xen-devel@dornerworks.com F: xen/common/sched/arinc653.c -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 05:13:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 05:13:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408515.651247 (Exim 4.92) (envelope-from ) id 1oa95a-0005xb-1k; Mon, 19 Sep 2022 05:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408515.651247; Mon, 19 Sep 2022 05:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa95Z-0005xU-VM; Mon, 19 Sep 2022 05:13:01 +0000 Received: by outflank-mailman (input) for mailman id 408515; Mon, 19 Sep 2022 05:13:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa95Z-0005xK-2V; Mon, 19 Sep 2022 05:13:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa95Y-0007iV-V1; Mon, 19 Sep 2022 05:13:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oa95Y-0000Gz-F7; Mon, 19 Sep 2022 05:13:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oa95Y-000528-8p; Mon, 19 Sep 2022 05:13:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Nirwc1x3vBSFqdHtKEDkzztK1ffAzbe3OT6kCGgqM0o=; b=RWyj8rYECmm+T5CTMkSxh+jFUF 6ylqPqxkezhA63XsTEqSvn43SRheSwu6sZSZaO64uWkoIF3/gtimZIL3QCk5LrFnMn1H/vGjKIZQX 1IlgW0rySv3x2P7cMoJP65IEroOPAon460nNIeouszSuBrr7SFTuj2KUtU6KF+RZmxlo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173257: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=521a547ced6477c54b4b0cc206000406c221b4d6 X-Osstest-Versions-That: linux=38eddeedbbeac33f26845c29e7414b9313ea70db From: osstest service owner Date: Mon, 19 Sep 2022 05:13:00 +0000 flight 173257 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173257/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 173255 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 173255 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173255 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173255 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173255 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173255 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173255 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173255 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173255 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 521a547ced6477c54b4b0cc206000406c221b4d6 baseline version: linux 38eddeedbbeac33f26845c29e7414b9313ea70db Last test of basis 173255 2022-09-18 17:12:53 Z 0 days Testing same since 173257 2022-09-18 23:40:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ben Hutchings Helge Deller Jiangshan Yi Linus Torvalds Rolf Eike Beer Salvatore Bonaccorso Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 38eddeedbbea..521a547ced64 521a547ced6477c54b4b0cc206000406c221b4d6 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Sep 19 06:26:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 06:26:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408523.651259 (Exim 4.92) (envelope-from ) id 1oaAEb-0004ax-Fz; Mon, 19 Sep 2022 06:26:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408523.651259; Mon, 19 Sep 2022 06:26:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaAEb-0004aq-Cs; Mon, 19 Sep 2022 06:26:25 +0000 Received: by outflank-mailman (input) for mailman id 408523; Mon, 19 Sep 2022 06:26:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaAEZ-0004ah-Q6 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 06:26:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9e325a1-37e3-11ed-9761-273f2230c3a0; Mon, 19 Sep 2022 08:26:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8742.eurprd04.prod.outlook.com (2603:10a6:10:2e0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 06:26:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 06:26:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9e325a1-37e3-11ed-9761-273f2230c3a0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpyBR51jbHMtIxRklDKBcRa0RFpC0dtIPNaeg6yc7CQfS98JIOyw2oVcH1d1kN30IHybppToh8XPTG6AiTuXcNGNDCp/vFqusoQ2f9NkSU7SJHMrR/MaPNkX4CSqfJyTmdlQlycljy7mfb6EdpTLpm/Ez00lFin7FmF/qk4Y7pPzHgD1Jnm9Hm9UVG7GQGkwabLmdBqatExcGyFG7C9dumCWQvB9i2KNByOHiwEAaESNnNICNXqWgqOqHr1IygK8mNcEbIaP1vOukVgexQZsbMyJEBVJ0fEXINbcI1qOU84ECRNX8pb5BkkGb/bbAIIA/D/EtRF9UrMvSKuzORz36g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eckbcM2lQ6kmZ4wzMH2CUCKJ1xiHQ1Joy54oP1OZmK8=; b=XrblN2F2ABAXmOjT6/vwh2jEVtEAW+fRU+CxQwdtz0jDh9QA5RBKUXIG3PucKPapvWBr1xid/SZD80FS1Vr6uZ2E6TlB4wJXaxjh57QHKPOMDzDs55eE2bF7ZbVfcRX5VjgxLL2OYtoiBPLCxkiJGwDF+2o7YTtO6D7kKnhVp65bQKxUwvW45Pl/RM3dTR0SnS8krcxz2/CFQw/p3/2wQvwmtjp9LRnrF/QFw7pwdyq3WhIQVNTBByzR+T6/sJVL9OiMwUJdctnoAW9WArkJNqpoxnWxIgKTp/9pRaK0syjNY539ysTJ1e/pwaHWDerDIj/NO3PnHN2efABxsYhiHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eckbcM2lQ6kmZ4wzMH2CUCKJ1xiHQ1Joy54oP1OZmK8=; b=FzHWuYdQoAgeT+cdvMwfUsk9VCA8wkQbqDgLWXq2ozdZUFb2R90ZCS7S+sqGyns+Rlq29k2Dpyu7nfKABjsolLdqJaXzo3DezmqrULhNnx7EYwy70kG1Ce7oCN9o46PIUYf6T1FadNkmHuxin0LkBejK2xzd4mPk254v6z0rOspUOFIViyaiK8ePKm5+UcRwCBIlnPLDtGzxa3GYfYCeppNwvZbPhuVQX0Tm4diBIVLaTvG1ZVxGRPsdOoUV6s3RwgQGGnVEU6KCxj2X+Afs6EBzbSqa21pHggd5EvhhR9HEfIeVfpDrVS3MRizKzfWJgjdrnccXJNk9xjR/sx6wzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com> Date: Mon, 19 Sep 2022 08:26:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for domains To: Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , "xen-devel@lists.xenproject.org" References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-7-carlo.nonato@minervasys.tech> <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR10CA0101.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8742:EE_ X-MS-Office365-Filtering-Correlation-Id: f917cc2b-074b-443f-a660-08da9a07dc58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nd3t2oj3XgtOMbDmwMIN6qqsQPUHVH+lYjwRMgWT1qNjYgSJab0dygz0bWmDoc5wDONcOYUsOUDPhkbJI2FT66Oxm2AUVBGRBHtI2pjSgtLsn/7JEWJeteN3ArbGY2MQnzt+ltDqp1ycxbQebbHK2YR4qLNyl7OiouNv6fDD6s3NET2RrKy7W861TmcTmBdPuJzZbiRCk9BkrlYskobs7L8bQyfB5ozpMwE5AC6YjgMlLOn4SP8ZZRTujLIBAmw4iHaXWSIYNZxewy5dpYi/Q3t2zr9fXnjpN4SvMHcoUMFACa6JH/txuez/kDDnFtT4GyDct5GOQ44Q9MRqPJ7Vi0Alk48hXPNE+BH+/KTqj6mSOFjsEabb4Zcr3aN9/9la6xqV+OryKNdnDkap+hQZCV3fp9XABAXqnGBhH0IUcvf7sKypy6y12y89Tb962MoIKWKuN2+mgmyi3K9oJPiBe3oM3yvXNV5+4/dXrvdZVf5iJGq9EXz2/Uz0A6jp6BtxJ9rVkN/0dmQ/tuwvw64SZUickxEn2T4BsJufUrc9nkvroc9cDNF7qfEKEhPDHT/vqO1gOaRXh3/mH2HTIDvxM1DpGEgLQKInw50WYFMy4w3NZ2QA7E0QvrllSz7GTZe5qSD3xylVBt/TOAfpjpJPU+Y/Suw8Psqet6qM8h+RSqtmrGhGRaj4GKb+YbjiZ/QkrgLidw6qD5wwMBXoUhJuTLeOnd4LhpxjS2cZflaEZG+xb5VnRTpj9OwNAuetmGTqL/7lQmHBcnhqLqCYFUbOj7rkAH2sGChWkaqh5fROgxc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(376002)(136003)(346002)(451199015)(36756003)(66476007)(2616005)(2906002)(4326008)(66946007)(66556008)(38100700002)(186003)(83380400001)(8936002)(41300700001)(54906003)(478600001)(31696002)(86362001)(8676002)(6486002)(26005)(6512007)(6916009)(316002)(53546011)(31686004)(6506007)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk9jQWk5TVpETEY5Zmk3MHQ1NUN5S3hTeDBEcHhZWGxWdFRubWwzM1diUVhJ?= =?utf-8?B?cStIekRDU3FEajQzTXVBMjUrakp0VzN4M0JrRGJNMWdJN3krUEhnTzZhb01K?= =?utf-8?B?eHYxK1lmUkQxWk1wV3BiR2xVbUsxOGZmSVUrck55dVhwYjBMOVVCeEk2c0FM?= =?utf-8?B?TjNMa0lYdGpBS1gzNnY5MW1GTDN5TlRDM1ZsUXdCYnM1NVFDVXF6SDdpZTFT?= =?utf-8?B?anI4VEM0akpvc0NzTFp4TXZMWVFCVnJyYkhoN01kZ09rZnVRd2IvaytELzVs?= =?utf-8?B?NTVmR2tNUFVCMTZYZWdXMmk1cjAxKzZ3WCs3SnFtWElCZVFhb0kxWUZ2N2My?= =?utf-8?B?VHNycktvR3BWSVhwczE3Wlg2MUdoVEdTZGR5TC9wRTg0SUN2ZHFxOEVVM01T?= =?utf-8?B?TTVTVFBpeVdHRDVGVkNabDlFNVRkbENCZWE3dnJTZUxjbi9KcGxNOVNXZnZ6?= =?utf-8?B?VWZmU3c4Y3BkZHpjQ21CZGVnUnZzVWEwNzdockg1emRMT1lLK2FXd3lPbFJy?= =?utf-8?B?YUM5YU9vakMwTzlKVS9uRk9tU2dtS01qdllZbzR3NXJoSVNHdVBBelVxbm92?= =?utf-8?B?UVkybXUwdHJ2a0d3K0YxcGI3Y0FIdGJsSWU4eGxsaGR1OEp2bHE5Z2ovRy9V?= =?utf-8?B?VC9hcGpadWo1UXFwdkw5V2h3aGJxN0Q5em9rUzMrNkxkeTFKSXRhQTFmd2NX?= =?utf-8?B?cHF4SkhCWndscG80c0hXcnFGeG0zQzFwRjZJK0w4OWJrY1NURGhCZUVUMlBZ?= =?utf-8?B?WXU5eU5qa0pvVUdzYUI1Rm9jbmNTR3p5eDIvSC9nc0dSV0Z5eE1hUm1EeFdS?= =?utf-8?B?Q2RrbzdxUWk1S3d1dXdTVm9WSXEzdS9WNk04VVhqbUc3YUVQMUJrUzJkZVkx?= =?utf-8?B?eVBwQnplL1hIVlU4azY3bVNlQUFIc1VPVGdCUDFaTFFQR1JyNmRpM2ZZeE0z?= =?utf-8?B?WjZWMExnODFoKzZtb0FGeWI3bWswZ1pJSEVUUmZjc1BpNjkzTDFua2VIVWY3?= =?utf-8?B?WklkRVQvcnh6cHo5SVBwRndvWDZIMGpvanduNFVVZmkvOHA3YUZUcHo1c2J2?= =?utf-8?B?TFVLMTNQTkFNekg5cEloc21oN3RsOER2UCs4KzRJbFd1ZkxadUlxVGFGQ3F0?= =?utf-8?B?Y3JHWTZ2b3BQVVU3VXdzc2pWVk53ZWhYRzlMS1p2MjU5M0tJY29icGppcHFU?= =?utf-8?B?SFJMcnorRmNzZVBWcnFtY05kZ1hHNVVVQkJkU1lQNDZZN3FMUDBORmppZ0JT?= =?utf-8?B?QUJFNzZ3OG96c1VSdTRNYis2MXc0cUdka0JMQzY3L09nTFBBdVVPU0ZUTHJN?= =?utf-8?B?WFZXQytaVllGL1ZKZDErSi83cTFVV1ZXN2lZME5xMkNQSEZxWTgrL3BOM0hr?= =?utf-8?B?aS8rdVQ0UEl4LzVWNkQrWVRoNTJIVzUzZSsrc1pnU2R5MkxpaWpWZm1BTUIz?= =?utf-8?B?UWFBNTZqMWduYWxZdy9pR1dkNlZ3WDBRMmF6MDNiK05LQjRrcmdRK0xlYXZB?= =?utf-8?B?WlpRQnZzdFh6NHdyUGdOaEw3VDJGbEF3eXJCWjZHNUluVmNlVmRlWWRpWGpO?= =?utf-8?B?NjRlcVEyeGtVUlh3dWlISG5KcmpMT2RQazZqOHhlWkRGdW9HWHRXU1AyU3Fz?= =?utf-8?B?WDN6eGlrZWVvR01XUkZESnVoRituelNHaURpN3ZMaVJYckFnVU1EODFpRmds?= =?utf-8?B?SjJiM2FBNGQ3L0JYYjFJTEV1NWRqcWZDRm5QZ0FIdG45MnM0NUdRSTVMdG5F?= =?utf-8?B?VFlkbHl1eFZiTDNHMm82bTRVUTVoZ1cxVFNNQzJzSnV6T0ZHWU9GdlJTaTlM?= =?utf-8?B?VFp5VE1RSERMM2N5QVptYUpTMWlZUFJmOU9OWEZrODFOQ1AwRTUxTTlFeVdU?= =?utf-8?B?b2taTDQ1VFI5UWpCdnFPd3BaZGVoYlBIMHVDSElOS0lQOW9VUFVTbmRESDhv?= =?utf-8?B?N0xKZlMxVlhuSWJHRkt4cVpubTAraDVqQlR2c2FGZ1JJUzRlVUswTmxZQlZh?= =?utf-8?B?SGpCbzhuY0lUcldxWFV1ZXlzVWRWYUlIL0ZsaUxzWkhPVW11UGpsUTFZZC9X?= =?utf-8?B?NlZtZEhjQnBqRWFNVHFWUldHSWFabEx3eThQb1ZSenUvK2pXbVRydmk0N1Y2?= =?utf-8?Q?picHOjqXwB2MsodJhT2VSvJLJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f917cc2b-074b-443f-a660-08da9a07dc58 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 06:26:18.0467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gkj/xlhK4hoL0ESsry5vSYUBQo85NsOT5ZCmjya0gDXURVseC9pYtOhKLt58xoenhcyKaeBaddhVMGW2kHH7+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8742 On 16.09.2022 18:05, Carlo Nonato wrote: > On Thu, Sep 15, 2022 at 3:13 PM Jan Beulich wrote: >> On 26.08.2022 14:51, Carlo Nonato wrote: >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -147,6 +147,18 @@ config MAX_CACHE_COLORS >>> colors at boot. Note that if, at any time, a color configuration with more >>> colors than the maximum will be employed an error will be produced. >>> >>> +config BUDDY_ALLOCATOR_SIZE >>> + string "Buddy allocator reserved memory size" if CACHE_COLORING >>> + default "64M" if CACHE_COLORING >>> + default "0M" if !CACHE_COLORING >> >> I don't understand the purpose of this last line, nor the two earlier >> "if". Why not simply >> >> config BUDDY_ALLOCATOR_SIZE >> string "Buddy allocator reserved memory size" >> depend on CACHE_COLORING >> default "64M" > > This was just to have a value for the config option even with cache coloring > disabled. All those ifs emulate the "depends on" keyword, but let the > CONFIG_BUDDY_ALLOCATOR_SIZE takes "0M" when coloring is disabled. With just > the "depends on" the macro isn't defined at all. I know that this can be > handled with some simple #ifdef, but I found this way to be more elegant. > Not an expert here so if you prefer the other way or a whole different one > (more readable/better fitted) please let me know. As far as I saw, the sole use was already inside a suitable #ifdef. Hence yes, I clearly would see "depends on" as the better fit. Please also don't forget that if later cache coloring would be enabled for another architecture, that default of zero (pre-recorded in a .config) would get in the way; one would need to manually change it (and remember to do so). >> Finally - how much of this is really Arm-specific? Shouldn't this be a >> common config option, perhaps merely restricted to Arm by the top level >> option (CACHE_COLORING?) depending on a further HAS_CACHE_COLORING, >> which only Arm would select? > > I'm sorry, but I don't understand your suggestion. BUDDY_ALLOCATOR_SIZE > is Arm specific because CACHE_COLORING is. In fact it depends only on this > last config value and not on Arm config directly. Why should someone limit > the buddy allocator when coloring isn't enabled? My comment wasn't on this on setting alone, but on the coloring ones as a set. > I've lost you on the HAS_CACHE_COLORING. Why should Arm config select this > one? Cache coloring must remain optional. I'm probably missing something. HAS_* settings only express what an arch is capable of; they don't replace dependent options which actually are user-selectable. (That said, we have a number where there's no user selection possible, but that's not of interest here.) >>> --- a/xen/arch/arm/coloring.c >>> +++ b/xen/arch/arm/coloring.c >>> @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config, >>> config->num_colors = (uint16_t)num; >>> } >>> >>> +unsigned int page_to_color(struct page_info *pg) >> >> The parameter will want to be pointer-to-const and I wonder whether ... >> >>> +{ >>> + return addr_to_color(page_to_maddr(pg)); >>> +} >> >> ... the function as a whole wouldn't be a good candidate for being an >> inline one (requiring addr_to_color() to be available in outside of >> this file, of course). > > You mean defining it as static inline in the coloring.h header? That would seem preferable for a simple function like this one. >>> +static void color_heap_insert_page(struct page_info *pg) >>> +{ >>> + struct page_info *pos; >>> + struct page_list_head *head = colored_pages(page_to_color(pg)); >>> + >>> + pg->count_info |= PGC_colored; >> >> The function isn't marked __init, so runtime correctness as to the >> (non-atomic) update here wants clarifying. > > Yes. I need to check and probably add a spin lock for the color heap. I'm afraid a spin lock won't help. May I suggest you look at some of the staticmem discussions that had happened, including a similar topic. (Sorry, I don't have a link at hand to the exact mail.) >>> + page_list_for_each( pos, head ) >>> + { >>> + if ( page_to_maddr(pos) < page_to_maddr(pg) ) >>> + { >>> + head = &pos->list; >>> + break; >>> + } >>> + } >> >> Wait - a linear search for every single page insertion? How well >> is that going to perform on a multi-terabyte system? > > For our test cases (embedded systems) the linear search is good enough. > I agree with you that in the general case this is bad (even though the main > targets are indeed embedded systems). > Are there any already available data structures that we can exploit to get > better performances? I'm afraid there aren't any that I would see as a good fit here. >>> + page_list_add_tail(pg, head); >> >> page_list_head and page_list_entry are generally different things, >> so I'm afraid this isn't correct in the common case, and you're >> getting away with it only because only Arm currently enables this >> code. > > So how to insert in the middle of the list? That likely would require a page_list_*() new helper function. So far we simply had no need to insert at other than head or tail, iirc. >>> @@ -1939,11 +2107,24 @@ void __init end_boot_allocator(void) >>> break; >>> } >>> } >>> - for ( i = nr_bootmem_regions; i-- > 0; ) >>> + >>> + for ( i = 0; i < nr_bootmem_regions; i++ ) >> >> I'm afraid you can't simply go and invert the direction this loop works >> without any justification. It's not even clear why you need to work >> forwards in the colored case. > > The order was inverted because I'm assuming bootmem regions are stored in > ascending order (this should be the case looking at bootmem_region_add(). > Am I wrong?) and (second assumption) pages taken from each memory region > are sorted in ascending order relatively to their machine address. > This means that color_heap_insert_page() is called (at least during > end_boot_allocator()) with always increasing machine addresses and so the > linear search should be O(1). Indeed that was my guess. Yet the present order of processing is there for a reason, so you need to both retain it and supply justification (perhaps by way of a brief comment) why you need alternative code for your allocator. Even better would of course be if insertion was more efficient and didn't require the logic here to specifically take care. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 08:38:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 08:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408542.651270 (Exim 4.92) (envelope-from ) id 1oaCIO-0000lC-Jp; Mon, 19 Sep 2022 08:38:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408542.651270; Mon, 19 Sep 2022 08:38:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCIO-0000l5-HJ; Mon, 19 Sep 2022 08:38:28 +0000 Received: by outflank-mailman (input) for mailman id 408542; Mon, 19 Sep 2022 08:38:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCIM-0000ky-VD for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 08:38:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d13b24c-37f6-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 10:38:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8983.eurprd04.prod.outlook.com (2603:10a6:10:2e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 08:38:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 08:38:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d13b24c-37f6-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BP7O15ebqzjkH7aEN5ti0fwTNAS7hGJBdLMoyg9Chx2Dsd/ZYL7XeyeugMMFJ1pmU3wJSYHHDD/Bz9lRpLJoiV25ObBRZnB0ATIs2j/eqTwOVAI2+CIpzXpywDdYXrLvVU61bC64+MiovKh3zvbdMmMyQSu7X/1rDH3/cYh3dgMILWz6jRkwkMDmNmvn4Z0aP57uabnts81YqtPqx2IynGzXZ44OLz8eJ8kQeCPl+jCy0tS4oE494f6B2AHSh5jWdjOIR8IVnw2I4MDfMeiWqwIWULJAL0ysZRTElKISErbvEQanDtcRWrmoFB02Boe/YCZ/VVbLGVDRChudperMkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k8DWXVniuDY2a1GkNtaQhvHV30BSkuH4wDwj9+9FosE=; b=XoqbnuutVymRxxDNacLwV40qgBDEMLBqn5k4Unb2gYpLscm9J73ushToGQNwwIRjtE37U+gwsAGQ1EkMpVh88rkz5W9i15NtOS0+gYu76N7LRMCuh5H9oSgLO+jufsSwnRN6NaXRFQEZCnJ/BHkrJmPLhatkC4hi9U9SEv30gd7pPihJ8OpUGsufY/5/1fUpigTeaNryZlwV7v/GN3MICqPmYNMW7tbDVR+4XvaCw3frjTIhPsefu7AUqjvPyWxAoHTZFwsb4LnZcUMdcxBIbYmrWDLOGkXfkYRCROn9PYHOtUp7wQl/N/Nbxk+v/cvT8n62gBGDjuEWN9RkvLk7cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k8DWXVniuDY2a1GkNtaQhvHV30BSkuH4wDwj9+9FosE=; b=UO+WuKDxWhzdOokIj+vrnwN1DxetUuYzJodHVuGAuCM3likz2pbxP5xhaaZrejH6vifAvVerDaSwfYa6RwsaA6rMZBOrS9ppzSdDjBNEciX0NWnVdlFNZVF1SJyEjjbG0Du6vP9tzWObA6OAbbSO+s+TeDi8+o82YhCh243UxQBSvBDveBHilfghOKW5Sj6GXs9Gc/TIcBgwN0JRZnBLQdva8kUAlcXSlBjdpea70jQbzuCUeHs17ZZYZWDb8VLKxoMkto77veNrqLy7yQuaCzUFEcRyVz2Yrre2nPuvfjjS3hggOQ+tkcNC0s/+Qtr/1OYA1SwPo6jiNK/dW4j55w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ba1ede9-cd8c-01ec-939c-e0915d7c18b4@suse.com> Date: Mon, 19 Sep 2022 10:38:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen Content-Language: en-US To: Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , xen-devel@lists.xenproject.org References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> <93471d92-bc61-56fd-5b52-413303d35da1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0042.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8983:EE_ X-MS-Office365-Filtering-Correlation-Id: 82bf18dd-7ed7-480e-9af4-08da9a1a4f76 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lQPxLEsj1sxUcIks3yspxgPn6YCL34+WPczpe8L3G94o6x4CT8bZWpsdKh2oz4++cUcUUqQukLhoDrzbDIPsYQWWNlp7DwiIoKOOufLYzt278TO7GESvO3mt7SqzOiNKY0g7Dakiv+6CPHRm9yjJvuu4QepN3qO/sOHLXlw/Cp3GY+pC+iEMaGmW80SsUaUMOxHHcg/XVyVqcPv13Z7BPg+wA+7reLSckY+yb6WVURrprU6DvRYypd35Q4fHfK+oOvKvQBwAUwrFiuYngZge/JE9TiYk004mOSJZdyEeSBDHbeMaAUkM6SjI3zafpJ+nWyXE0TT9fyPYJQKD3scc7oe2nrrCqshFdJkNzrglAw+g/QgrgyzFZkW3zLk+qjGGxcNyeS+FQgFPNHTGhSCrAJlYmXZIO1tfDuNNi2p00YH2EemyoJikkeI6ebnviFL3Xe3fhYmyYGbv8CSymd8LB4+19y2/SZdbwOqAS9rR5o1YnWd5jb7bvvUXJQ1LHFefxQTC6VlFuyacQRm9wsfsS0w9B409iE5pT9x8sTWPrE4L2jZt54b22fYKsHGiMBV6r2UwB1wevjPzrLr723kiV3JCCBxazIbvJyNXvdqwscJG0A4RJvj9iS4sJwGWY5tRsUTmckybpQ9AmKLef9sRtGnLnXodIZL4w4T5RQuTF3kru4ds49jlJXNmVoUpdioLpnghdwVQKSx7pjOle6ETcCgjUZlkoUcNe+hNLI3obVly6PhpslwNPpXVL9K156mhSnUU3bv53kwWcWbNnJjIcVgZnzZlLcvxCoXvm0hcGX0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(366004)(376002)(136003)(39860400002)(451199015)(2616005)(83380400001)(186003)(31696002)(38100700002)(86362001)(5660300002)(41300700001)(7416002)(8936002)(66556008)(8676002)(4326008)(66476007)(66946007)(2906002)(6916009)(26005)(6506007)(6512007)(53546011)(316002)(6486002)(478600001)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTRBdDVKM3Qwalk2MTMwUDVuc0VCS21KbkhHeTc4YWZGazg5Sk85Zk5nZE54?= =?utf-8?B?aEtGMzFEMDVTaXBhZ3p0NWZRZkFGb2wxRndkUEFxbk1RZTJ2QjV3ZkY4Tk43?= =?utf-8?B?L2NNWnBBeGF5aTlQbVp0allWamhLak9sRWxnRjFPWExwVFArT0l4dnJVL1pX?= =?utf-8?B?V2U3MVhLdFVmUXFXSnJybHMyRDVwTHZQaUV2TzkwUEIyY0tTZFdBUmlLVkNi?= =?utf-8?B?QTg1UmFralpiK1BEcFV2WEpsVTJvbUtjeENzaFpWdWlPTHdmeW5OaTBQUXVv?= =?utf-8?B?bVB2cy9EcysvbW5OTGhjekY0bnIyeUhVT21DejN5WEw2dW90OFdsTzdMWE9Y?= =?utf-8?B?MnZIQWhLeDR6emhsalp0MWQwWWNQR01xcTdFemt3aURqTDU4TnVYOUZkMzZH?= =?utf-8?B?bkhSeW9XRy9ZNXZxK2o1WGQ3Nk9hTVpLNnBCek9CQzJabHBiSjBLN0MzUmY5?= =?utf-8?B?cUtBVWFEYkU2TUFUTnh5UTY5TmlROGdBS2RZL3ZEZkRGTm1sNkEzeGJFc3lH?= =?utf-8?B?ZVpnM2dCUDZxeTJFTU1JMWtCUEpHNjZCVEhER0xzZ0xmYUxvZUpQWTdtck1Y?= =?utf-8?B?Zms5VHJ2Smh5M1ZwT2IrQngxMXQ0YWdBMUZWTnFVb1VHS1VmZGg4aFJwbGJL?= =?utf-8?B?VDNzQU1NNFU0NVhLV3dhdTlCeG95Y1NKbTREc09UZ3NsWmVKajh3OXJCd0R4?= =?utf-8?B?NUxhcGNTbW1lL0VrTUFTZWoxN1NNSzhzVzRHYnhRYk5VYkdlT0g4N2RsdmdP?= =?utf-8?B?WXk5R0FyS3REWVFCSGRjTUFkQXo5NXo1ZWt2akZKRmpiUVpoclRjUmVXbzRj?= =?utf-8?B?MjhVRWlUTlo1ZlBYNmxNUGk3UWkzN2QwaWNod3d6Sk80c1dRZUd2ZC9haWU2?= =?utf-8?B?TUpvaG1vQUtMZlUyVk53LzJnMW9WWEpTKzFaWXRESDZIdDdqQ3ZST21UWDQ3?= =?utf-8?B?K2JZU0RoaGh6UEdNbys0WXltZHlkVDVDZFhGaWZOemNUL0VFUFFxNk5SZHM4?= =?utf-8?B?ZHVKVjJmWFNhZEptVkFjRlZicmpIa1ErdVRnU2ZuY1RtbWRNRlF2Y2tqcVFv?= =?utf-8?B?d2tQUTFUalJSYXp5K2JoS3lLbmFidUsralpUYytiMTdsUWJxekN6TTdXNkFv?= =?utf-8?B?eEFHNDlHcStGRFhNNmR3eEh4dTB1bk5uK1lLak9oZ3VjSWs2MVhXeFcwYVlq?= =?utf-8?B?M1pKczlmcTJuVXZuQ29DbmZDZElPTEVRMHlQeHpnVEphUmM3UmJNNG1lMUM0?= =?utf-8?B?R2xHWXlma1QxdlhxKzJmR21hR1ozdVJuUk5oMnVmcVVuMjdzTXVlVWFzRzlP?= =?utf-8?B?aGRvRk5tbmdnNVMxR1RGc29RUnZiQ0YrbS82Um9YcTdVeDIxVDJPWGJMekJF?= =?utf-8?B?ZVpaRjRYdVVScUNWaGoxVFZVMEdoc1MxdWMzdFgrc1NXMzNXOVdOZG9sWUQy?= =?utf-8?B?bGFibWYxVjAwWnE5MGY4d2ZZMkE0dVYxcXd0eElDWjJMSTd1NnJoQ1hrZzZZ?= =?utf-8?B?c0Y2KzhNNWFkYlorNFAzWUY5YmtsTmVtcXZmTWRPbjd3MTYzcWZpQjAwKzJ1?= =?utf-8?B?Y2ZjRFFNbW5JcHM1UDlzN2ZxUTdKcEdRMU13c0xsZE1XSjlsUy9kVDh4TWFE?= =?utf-8?B?V00rSWVRdjVJc3BHdm9LdWplOXlkZnFaWmxVNGJOeG9JWHpSc2VkelIvYUE1?= =?utf-8?B?aEx4dmVyK3FWeU1GLy9JK2gxMUwvR1RZOWh4VWlsR3JrbXMyVDRCcVgrQ1JO?= =?utf-8?B?NDdYa05DYWliRFpiOE4wb0dnbThVRllJcjY3ZmN4WFBOdm4yclQ3cjZDNWdF?= =?utf-8?B?MEtxL1ExL2dOMlNVRzd6MVk3NWh0aEtYaXMwSEFTSDlRblhYeUI5QmFVazBo?= =?utf-8?B?Ni95akY2NmlIZGJNMVRJSWhUZWtSVVpIakNOcm9WcXh6TDF3WnlNWWc5VXZQ?= =?utf-8?B?a0tCL1JZR2pUdFF4TS9mQmRqRlhINzAvNS9CdTE2Qkh0YzlWQ2ZnbElGdUxE?= =?utf-8?B?WjV0VVRlQTJtdE9WZCs1aE1Tc3pmeExxbmZ4UVQxQ3FUT2ZpMFNQMzB2YVdG?= =?utf-8?B?OENWdyt2SjJoQWJjZ3IrRloxOFZRd3A2eWhGa25UamR5Z29XZEhkZzNrMHpB?= =?utf-8?Q?slR9H/aRaGNRMDiOVZQ68VPOA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82bf18dd-7ed7-480e-9af4-08da9a1a4f76 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 08:38:22.0909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 04hQ3ZoND57VEHq7Av4A3LPiNhoG6Lok9ZL33pwN+0jgv/jUGWAeDsRnMEXUHFhKAzyvg8jZdYKRTaBpTc/kdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8983 On 16.09.2022 18:07, Carlo Nonato wrote: > On Thu, Sep 15, 2022 at 3:25 PM Jan Beulich wrote: >> On 26.08.2022 14:51, Carlo Nonato wrote: >>> @@ -218,6 +221,28 @@ void *__vmap(const mfn_t *mfn, unsigned int granularity, >>> return va; >>> } >>> >>> +#ifdef CONFIG_CACHE_COLORING >>> +void * __vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, >>> + unsigned int flags, enum vmap_region type) >>> +{ >>> + void *va = vm_alloc(nr, align, type); >>> + unsigned long cur = (unsigned long)va; >>> + paddr_t pa = mfn_to_maddr(*mfn); >>> + >>> + for ( ; va && nr-- ; cur += PAGE_SIZE ) >>> + { >>> + pa = next_xen_colored(pa); >> >> This may alter the address, yet the caller expects that the original >> address be mapped. I must be missing something? > > If the original address color is assigned to Xen, then next_xen_colored() > simply returns that address. If this isn't the case, then you're right: the > address changes to the correct, colored, one. The caller should expect > this behavior since this is the colored version of vmap, the one that takes > into account the Xen coloring configuration. That's (to me at least) very surprising behavior, and hence needs properly calling out in a code comment at the least. Personally I'm not convinced of having a function with this behavior, and instead I think the normal vmap() should do. As long as you're only allowing for order-0 allocations, that shouldn't be an issue anyway. >>> + if ( map_pages_to_xen(cur, maddr_to_mfn(pa), 1, flags) ) >>> + { >>> + vunmap(va); >>> + return NULL; >>> + } >>> + pa += PAGE_SIZE; >>> + } >>> + return va; >>> +} >> >> Afaics you only consume the first slot of *mfn. What about the other >> (nr - 1) ones? > > Not sure I understood. The first slot is used as the starting point and then > the addr of that mfn plus next_xen_colored() are the mechanism used to select > the next mfns. Probably the first argument of vmap_colored is a bit > misleading. Yes - it shouldn't be an array if it's not used as one. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 08:41:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 08:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408547.651281 (Exim 4.92) (envelope-from ) id 1oaCLA-00028m-2m; Mon, 19 Sep 2022 08:41:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408547.651281; Mon, 19 Sep 2022 08:41:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCL9-00028f-Vd; Mon, 19 Sep 2022 08:41:19 +0000 Received: by outflank-mailman (input) for mailman id 408547; Mon, 19 Sep 2022 08:41:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCL9-00028V-Aj; Mon, 19 Sep 2022 08:41:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCL9-0003Yr-6a; Mon, 19 Sep 2022 08:41:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCL8-0007rk-Qi; Mon, 19 Sep 2022 08:41:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oaCL8-0000rI-QF; Mon, 19 Sep 2022 08:41:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ec8piEOqgtUoJJn4vQlK9jxOP12dLvDUVeMxxHBRnuI=; b=C/2gpZ0nLfyEtyvXXxh2P1ErgJ M9YQkL1ppxgDrDyc7CohzNOoyOfYqsIeKvefn3MLsCZH5pqERfLHy/ZdUMlqLyQr6yLBxZJh0q2ij EE4nhQvde6gtZBpIGlguzdY0BrwKugjBrLRkz8YSQMd7T28BDAWsBT8IpPFJXq4N+GPU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173258: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:debian-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:debian-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Mon, 19 Sep 2022 08:41:18 +0000 flight 173258 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173258/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 12 debian-install fail in 173254 pass in 173258 test-armhf-armhf-xl-vhd 12 debian-di-install fail in 173254 pass in 173258 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173254 pass in 173258 test-armhf-armhf-xl-credit2 12 debian-install fail in 173254 pass in 173258 test-armhf-armhf-xl-rtds 12 debian-install fail in 173254 pass in 173258 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 173254 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173254 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 173254 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173254 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 173254 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 173254 like 173245 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173245 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173245 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173254 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173254 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173254 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173254 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173254 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173254 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173254 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173254 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173254 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173258 2022-09-19 01:53:28 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Sep 19 08:44:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 08:44:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408557.651291 (Exim 4.92) (envelope-from ) id 1oaCOI-0002ow-NA; Mon, 19 Sep 2022 08:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408557.651291; Mon, 19 Sep 2022 08:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCOI-0002op-Kc; Mon, 19 Sep 2022 08:44:34 +0000 Received: by outflank-mailman (input) for mailman id 408557; Mon, 19 Sep 2022 08:44:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCOH-0002oj-Bb for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 08:44:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061.outbound.protection.outlook.com [40.107.21.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47e9288c-37f7-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 10:44:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7386.eurprd04.prod.outlook.com (2603:10a6:102:85::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 08:44:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 08:44:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47e9288c-37f7-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Le723PQ22HoGx4s8C4ChAbxC32rjvM6e0NrsyvGgM4r6uo+6ZJq3EDt87l/WW+949dJQbhwkmquck8pUNI4DW3pwej60V6UNYND1dfN1FXrc+cOZwXu4ZwZvpGDgQ2K5hXYFEIonY1n1oKStjVWjOBs3qRtt4L2HSyiupGW7yHlJja2LJpknu8B1lERHi6MBDRszklvcjdeJDriedSmKgCPtArc73Y7brqXrEKm3VfIfSnTBMhyDFd8SJ8TQbUe5UsKFR2CMzKX0ZRmgw72RR9hYstQBZe9LCHgBnziuLnV9g8XX2/dT7tVTAF9QuEmyumu/ywwYqzdW/PzPcFqg5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5C8Z2z0fbTbmBFnSHAFbE3QlZIU3E7qCgbv4J5hAaDg=; b=Oih7MFGSLFg+M2FvgEgaY/ZiFjmHMU8WFthdbwWi+ZGdF84PNp6f+TILLYNKGMhyvv/SVvHdpmVDanefEdhbOytL2IblDgMQ8ihiV0/VqrciETPsZWzvW+TMeb/3YfcOxmgbbXFRUDu5Af8vX+FY4vj3aNZNlsefThF0Lz1pwKCRGzDnNp3IKDX12XQtNWffYPtI3OVrx3pTxUPsNZiF3aYuHI1mzT4TWm4fDVyQAijdHXA7nMyX1n+Vp5iA1QI88Sf4xVT8fgVTwt9xkldl4ND1WyXEP0HqRKAB60HFkmDIoVEF1Idgb0hQvKyD74yA4YnqDptQ7WmGseBUx3Njrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5C8Z2z0fbTbmBFnSHAFbE3QlZIU3E7qCgbv4J5hAaDg=; b=Qb4/EIB8xUujt8oykXwv8guj+HxBgdb4EmASflIkElLhUaMiFCIXZFKCnk2gKL8+iaBBkOdr7ekGu1d7P4ur3SCbvVfDz24n/s/3ydVq6KywcAzCf49jIECYtTNEUkoZvxslBAAh22OeIWatxFntOqYB4rIMQ+17D+oBooY3CSP6uLVfzA5TO2nDfvB4JPc76YEcZSHic40hrrlDcFYEMNByy7F7q0IiER9zrFviZTei5Lk+9xt0mTNVwNSotgFBj1qo4MXfcmixaOOz5FD6D0d2PDamV/PN0l3oeWV5qSFN6Q3OTSIinmGOiU+x/nH9fqtNDDyxA6dxRzRnq4KTTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b0bb561-0bad-5e7c-55f0-4c44a185f187@suse.com> Date: Mon, 19 Sep 2022 10:44:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates Content-Language: en-US To: Stewart Hildebrand Cc: Stewart Hildebrand , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Nathan Studer , Jeff Kubascik , Robbie VanVossen , xen-devel@dornerworks.com, xen-devel@lists.xenproject.org References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> <20220919021002.2193665-1-stewart@stew.dk> From: Jan Beulich In-Reply-To: <20220919021002.2193665-1-stewart@stew.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0358.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7386:EE_ X-MS-Office365-Filtering-Correlation-Id: 60877265-cc58-4bc9-cf51-08da9a1b2b2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FyS4CR0c7qO7B62e+q8JTb4+0gVvOws8yfTz3Vmn20uAi0sPsWrqt8FCrv47qxnxRMtvNdQp4vTqFfNIkVjxiMhYersvNK2e4s0mWN1IA/vJc9qITVa8734hF7z/McEj1dyaLIdPhgWxXER6caXZbNWRNBU9BmHFhz0DsGVhpEAmFflNuGQUcrn0S9a1upHGmmgqcl/3+hDgo68GQZCZfBocY+L1y4560XSpHT/OB3xdizopceQWygyv3C69mUAD3tSFA9wBqzx8wFBXW22LyOR7PDiq9p2xUoi2hX7g4sDsPdZ5Bb8LUdAIeG+55VTtdVXf751EeAYoJJANxoq0DvFTQbn8wxPhJC+IgHbBsT/9MbzgXOlFQoDnjAMh9wFaEZp0W+09ZCnqbUTElf74l8z+E/OV4Xo0/S9nVPtJy/dgLBhBtQaP9a3ZPOeLT096CGRP+oafsLvJLtGIf7PIni8L/OZVj+aqiTfgn0pCKgCHoeu3DX4HurV05jKVSsN6o/WD0XQSgdM6NSTwNNR0eB7KWjMwMBwPhWE3VwhuKDgv585BMnQ09ArnFABsLiUIXtu+ZPtiAXZbfnP6XFeTRm8hmvJzwIv2y7VKoTKjgM8v5pDNGwaMz3AWa6ybraSY/zanWdZ4ejxAetO6Uk4Tf3z2T73K7K8ritbqVsoSeC5IAMSmUd6XFypSCGWzALwsBWXy6NTp8jpWT/fMsLJvE9qjOlYJoAbxrUr7nUc1I5EvTclk9jR0e6Hpbe66fZUqZx7lB9UAv1ANEerXQ+wvy3gKkmqjSzXHZglP8XvcsPw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199015)(54906003)(4744005)(2616005)(2906002)(53546011)(41300700001)(6506007)(4326008)(8676002)(86362001)(66476007)(66556008)(66946007)(6916009)(316002)(6486002)(5660300002)(36756003)(7416002)(186003)(31696002)(8936002)(478600001)(6512007)(38100700002)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDBLb2J5R2ROUmQ3OWJucXpJeUJSSExxUW80QmkrK3k0MlZOQ1p2NTFwWjU0?= =?utf-8?B?a0JTS0Z6WG04NWZacE5qa29KUy9XU0tkb0tBQm9Fd3pLQnZXQWc3a0FtOEcr?= =?utf-8?B?Ykx4TlRkcElHMlhwNFNlOVp5MGFPWGFpdzJlVllaR2hiNkZydG5uMEl4Z1F1?= =?utf-8?B?dGhWNjdCd25wQjJ2anlqQVJFT3c0TG5UR3QwWVpRNUgwclVRUDdNUkJIbE11?= =?utf-8?B?QTIwVzk4L0syR2tlZ3pKUHRTYm5EVXp2WE1Gc3hrYWR6SmJDUFhHNDNnbnAv?= =?utf-8?B?b1ZrUUY1cEVTbjRsRERkR0F6T2dKTlg1ZzA0R3BIb0RKck1MMHNudDJoek55?= =?utf-8?B?OFdudWdURzI4OFNCZlZTQlBxWTMrN1JPODJ4L29WdXljb1FtV29hR20rdVpI?= =?utf-8?B?KzhKdGhvMndXOGM1L0RYdlRTU2lEU1JHdEZVbU1yNW9nbGN1Y2lRMHRENUUv?= =?utf-8?B?MmNIWUpYSkcwK3JLZkdBNURyUGpLOWhSMlBuLy9kVGVPakoxWHJpSENtamM1?= =?utf-8?B?SXJGN21jR0cwRlRDVkdWOUllTFVvTm1xQUROeHRHQkRZSitNWDhrVm9XdmNI?= =?utf-8?B?SnN5TkxaLzhRb1JEY3ltaDV0eGgvMk11N0hSbVprUUdHcG51N2x5MFFpY3dh?= =?utf-8?B?QnRReXdqeVUwWmdQd3hteEFjR3Y2S3cxRkUxakRsbENRSytZTmQ2ek04Nm5G?= =?utf-8?B?VDM1eUJKK3JnYXhVcVVZb21McHRCQ055YVZJdGhPOTJqaFgwYng5NkNmZ1Q2?= =?utf-8?B?aG5nSW5UeHl6eFNpWUxlczJZK3E0czI3Ui9rSHM0dXQvUitkc2ZJYVJsd0cz?= =?utf-8?B?cXNwdjMrT1pDd3hwWXRzM25oL3JpTmQrbEZQajFJZkZqei9zRUdUczRUYWRI?= =?utf-8?B?L21SUGJ4WTVMV1F5SHVZNU5ycmVVSWFsNER5VU54b0I5L2VDUHBSRlIxNlp2?= =?utf-8?B?Wjc4TzFrVHRoTG1Sdm44bVVOcTEwbmZjWUQ0d2xscDBoNkp3emdEOWs1eXBt?= =?utf-8?B?M2ZvcDRXUWI1Yk1wZ1pwd3dFTnZKY3JMQ29handwT01ycU44SUtEMTJmeitw?= =?utf-8?B?eHZRaTJqL1VYMHVTQXVBZkxaSWZtbHhaanBUOXpVVmY4NzJaT1lqWVFld1VV?= =?utf-8?B?Q2srQUtDRlBHb0ltZzdsK0VUSVJRSnF6Y2hvdmpLaDMrK2hmQzNxNndEOVhH?= =?utf-8?B?ZHBhQWhUQUVVRTJWL21DYWpOdUlzVjVyZGc2Y0wrSzBrYTlpeWJVUlNpQTly?= =?utf-8?B?YlFhYm5uR1NoRVNTSFR1VVBkcldEWmxXMUNMaTllOG5yakFOOVY2YitaNHFY?= =?utf-8?B?ZnRVTWNlWUNUaDQzbFVqaDVTQVY2dVZTNEhFeWZlQmttYldIdFV2L1REU3R6?= =?utf-8?B?Q0kwWGh2bU9sNWQ1U3ljS3dPNElJaHRzMXpkNVB0VDI4c29xSjNObmJ1REh2?= =?utf-8?B?QTlvdG1iSUZMaGEyMmQrUXE1cmZ2TEoxbE5pd3JzRzB6YkNCaFVWVUptMTNa?= =?utf-8?B?SG5CUEgyRE1YWHlqcmJyak8vRE54bFZpVE5jRDlyWnQ0VnJMWFk4U0hMNjBQ?= =?utf-8?B?NG1la1BKR0ROVXpWSHJCZjdMTHdSem92dlBGdWN0dWQvcERhbUowei9TY2Fh?= =?utf-8?B?Y2lVd01MdGt6bmE2U2pDUmJ6c3JTY25hVWUvMWR4TjJoaWVJTklBTlplZVdJ?= =?utf-8?B?RXJBUTkzajRCMlpWc2pFdTAzMGxQbW5wRE9Kd2l0ZkZFVUZwdlc0WEd4RjFt?= =?utf-8?B?OVQ5SDNFQTcyNVBHa1pmMm5Qa2ZXL0grM29IYWM3QmRzT01aRzE5WTcvbFVY?= =?utf-8?B?WUo5bklNeStVM0Z3dmRpNENncFFxSHBJaGpRWGV4bEdYMm5JRlpMZ2p4RDlQ?= =?utf-8?B?MFlkTDU1WVlncTFnTGExV3ViMnF2dkhVUEVJSWd3dzZLMWNJcncrTUcyWHhQ?= =?utf-8?B?SzZmci9PVkhEei8vcE9OYUtLZnlhVG9XVjNFN2VqcVRPMm1YU2FIQ2ZGRHVa?= =?utf-8?B?MElCcDVPd0RvT3RRSkdmclAvUW96RmtLMzZVQnBzM3JoOFYyM3FUakp3Yy9D?= =?utf-8?B?V1U0d0xoMUhhVGE4RFZncks3cmoxRE16VU9Gemt0dDkrMjBPc3N2K1ZQRGFE?= =?utf-8?Q?uGogS3Is/wBla2PU3P/am3jDB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60877265-cc58-4bc9-cf51-08da9a1b2b2a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 08:44:30.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0l4+vfyDmSTxrlGhJ0fiArVMhtsrhm+1cMGdOmOaesAWVjpuFQ23H84Mhu1zcZ1+VszG/88guy8bpjiT8IcjVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7386 On 19.09.2022 04:10, Stewart Hildebrand wrote: > From: Stewart Hildebrand > > Add Nathan Studer as co-maintainer. > > I am departing DornerWorks. I will still be working with Xen in my next > role, and I still have an interest in co-maintaining the ARINC 653 > scheduler, so change to my personal email address. > > Signed-off-by: Stewart Hildebrand Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Sep 19 08:49:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 08:49:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408562.651303 (Exim 4.92) (envelope-from ) id 1oaCTK-0003Sk-9y; Mon, 19 Sep 2022 08:49:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408562.651303; Mon, 19 Sep 2022 08:49:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCTK-0003Sd-6v; Mon, 19 Sep 2022 08:49:46 +0000 Received: by outflank-mailman (input) for mailman id 408562; Mon, 19 Sep 2022 08:49:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCTI-0003SX-KW for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 08:49:44 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00e372ab-37f8-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 10:49:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7386.eurprd04.prod.outlook.com (2603:10a6:102:85::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 08:49:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 08:49:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00e372ab-37f8-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZMF/pfgPk8YYFDRVRevRD0YeAHd1nJOnthdIEkcGy/WgNmVvEbNlHy1B62pZTAM9fyLxjENoQ77xb17XULf4f1542DubFrZWKFbiFTZUF2ECUboJ8XnWVPpfIIuiywuNwDCjDxMdua+ByGHtKFCuPeTkvT6lMl7cunSrMV2Dv1QcZEumQnsP8SrouHRIIX0VaB0bV9qaVx3WxjrDazNMIZEF6gXeLkohYssX6kOAzi93/HKWN1VUinQ9p1ILZuHzhtTu4mRAiiDOz7PKZIjIPhsWwdF+FxRp4a1nDMVEga+eYowv5DSP1zxSI1YSujoEdm+kHCglfqgBDa97kIqEOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DoyiVSSKTAaGbNGdLpExynzIhvjdm0im6annt1PcpDA=; b=YIH6YVTrxs0KxKA4KwN5Mo/m3CAOLCDRF+LGWfzeuvnf/fgwrC3ZwFl0ZDcA7s7dMqJuGT48zRcugC0S2W8dIBzKSxQ+c0PDXa+t1b9UxmJ82FGPR6vWaCADkvextvS4CGejEC/2THt6Os0U2OKq91aPxLBJ7N/xRvJrchdWKxRgc8fe8/Q7oEjzUu/XLODd6uYFsi+9HTxWldMOX3Ziloe3cjNui0w0n9twdCzMKcgmtXwn5vlZ+z+x5rpKvttc//xTo6h4zhl/shpHsLM2CsStn+kLgd2ACalqi3FnUiHD9oh094Z4XuynuTwrAjMCjEY/5bL9Fe1K8+0SwxAk1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DoyiVSSKTAaGbNGdLpExynzIhvjdm0im6annt1PcpDA=; b=emVJ6TQzgnSQvW00dzDSM652BzH5aJmAS84O9HZFuJvib11rpQFIH0xnxKvkJv0ux2jERG8cvbaBZKD2ELmZV+6b11uZ5ek0PxDmLC8LRg2wfho6emgoVcyxjCsPQtu0pgcWnGR08zJ90CVHshFGBb1yZyAlzeNTW0ryESXmNU1m6RYuDrs8VtGG43539JHaQKnrUUtG/wpCx6KmADeCHXjC/uc1fFheqz6/CHUBMY+Gn/+kT0Aq/UM9jDowqx8+WJfx+/XEqvLOn8SHgE/troqSIcawY+pLd5oZ/tFIjpE7m/AFgJJ5CIx63LXTzHBaZFZHwwK8tNdraXBlcIhynA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <146598b5-2b98-3dc0-e9de-d23e7d83481e@suse.com> Date: Mon, 19 Sep 2022 10:49:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 11/11] drivers/char: add console=ehci as an alias for console=dbgp Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <6832b5dd97a1cd09ea8060e64fe1e8c8310e4974.1663383053.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <6832b5dd97a1cd09ea8060e64fe1e8c8310e4974.1663383053.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0553.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7386:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bd96145-c262-4e0e-4765-08da9a1be446 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7cwUuWhf3kBdIxg2OCfFXGw9xgaxMLtfpf1F7yOAqQhQqfo43bp8C8t3N20UjdSQyHmrOoCH+dzeKuM7TmJWJhKDn/H1NxSdfZ2zOX8WHFJDy3MN79y4IkSSRrUlh/d0YMbGep/BRR41BNd6hVhXfB6njSH4YZk+TbdQsqvhaaydI1bYowjtcX7oq7B5XuDrnHW8QN20teLXQa0GkeM9xcgZO0c2L+470X/fOKOzLWs1okQZz9F7bxMbkZsP9DJOXPruF5b29YYVIzLFgcEarrMASBS+HGjBDRskMHU77Nhgfgf1slMP9vauUbxkJV+ZGPScYbxK6bQGFXqTb5Fxw+ACi5+PIdi06eIrQ6PGkgTb96CF5nl6Tu/71k5vt5xmQ3q/6+ofqL5QCoq31i9yE0Tr/FoC1kYSOh52O2KJJ+ubBee3ocP4gSc/W8luRE/7BcT1qOCdUuM2O50vP2q65sqO+3UUeq/nO9E5kpjXZoBUQskpdWbyHHgufwrrSpnyobGa2oVlrwMKPCci2TowBYoSKWrZVZlWrjFNajKhSxbUE0aqWd93Bytagxfoi2532pFnXLmpemIU5AecL06E2aiEzBK4YkvMcTtX/Od8KT67gIBz2uAHyVwtkZ8s6g4n08DpOCHWwToPITwJjgAQ3xYe46vCq7fw1VeUTETIMJxC78gHhDBOLvXIOfwPvwt69bgdkv06dQqc3EIaToR7Lo36ZT/lv8VMDe4Ak2BOm5Af+4g6k80f3Uz6ojvzyzfjgVLO/+xHSLOSUS01RDQrnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(346002)(396003)(366004)(451199015)(31686004)(38100700002)(6512007)(26005)(6506007)(8676002)(4326008)(2906002)(2616005)(54906003)(41300700001)(53546011)(31696002)(186003)(5660300002)(36756003)(478600001)(86362001)(8936002)(316002)(66946007)(66556008)(66476007)(558084003)(6916009)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTVtYTZZdTNtb0VKaERveHdpdElGMGhvR0xDaVdJUWY5Z0VlOWtmUWNCWHVk?= =?utf-8?B?Ykt3bUtRTG5Ybm02MzNkK1psKzV0anZIeVo3N3VZdDVPMFdncEE0RnJ3ODVo?= =?utf-8?B?ODdLQkNYVy9GZkhOTjdvdFM3UTF4MEFvWFowZVMyd3JDdTBsMFVIeWpuVnFY?= =?utf-8?B?VW1mU0hJdFp5MXRZdnBlblgyOWhiOEhFemR2QjNIVytJekg4M2drVnBuMm5Z?= =?utf-8?B?ek94STFKL3A2OGdzSHFCcGhXSnpCTXoxVjE3MVY1Tm1FTVRhb282cE9zOHhO?= =?utf-8?B?REIwMTZQdCs4bUcybkdtSXF0Z2RwRC9LKzVRMHd2Q3plREw2MWlrVkVKY1h3?= =?utf-8?B?V1J4Tnd0SDJuWUJVNW91aCtvL2t0UFlRdWU3dG53M1J5Yy8yNG1BN3pQUEJj?= =?utf-8?B?MDE5d0JmNllMNS91SnRXOEgwSXhJU1pSNEZyaUM3WmlWSnZZcHFyUUE1eGcy?= =?utf-8?B?TmkwM0xHMnVvc0dGenpjZ0p4QXErWTJrdUNCVkQ2alloajBPU2FIQXY1Skhr?= =?utf-8?B?V0tESFBQazZhbG9xZ01nUGZlRmZNaXhjWWpJSEZxdkQxZkZNQ3MwYmtiTHU5?= =?utf-8?B?MWV1R0ZkeFhQcFN5T1NHOTM2UDgyMlpaTnQyMTJPV3IwNFRndTV1dytjeW5B?= =?utf-8?B?b3o3elBrT1ovUmZEdEJjTGJxOU1DNnk0VkM2bFhSbFc3Sm1IcGtGQkFSVERp?= =?utf-8?B?ZEZCS1J3S0paRVBrLzQ2alFGVjdRTnoyVWVGY3d6djhRVHBnZklwelU4RDkz?= =?utf-8?B?NWI2a2VidFNxUXJvSkdxdDg4MTNoWHFwVXlaWDFWNGQ3WThFQmprVDVGMWFL?= =?utf-8?B?c1NyMlhZb1ZRS3dXR053SGI4UGs4dXFFaCtHL2ZNK2dtZGZBTXk4UzMwVVNR?= =?utf-8?B?ZkMyWHdtbUtLYTc2elZBVUhFQ1FOWjNGcE1MZHVmYjhYZGVUY25TSC9SMTNU?= =?utf-8?B?eUtHSjJIZGk1bld6b3ZWcWRBdzVjcWoxdm9iUzd6cXBzZnJvbTBkcWk4VmJm?= =?utf-8?B?UStNOU1wN3R1Q1N3NEFJbVNHdjc3WGd1MDVXMWlKYWVZeG5BcVBlT2FJN213?= =?utf-8?B?TWM1SExlU3NnTWdlTWdJa0xOM0NtOW12VDcySWVNcEFZTG0xYmo5R0Q0OGp5?= =?utf-8?B?NTFBVHprUXdoS2xjQytyNTlTTHd0Y0hDZ2U2bmVrVktNTG51SVRwTnR6NXdx?= =?utf-8?B?TWkzN3o1WGc3am91UFdNeGdJYVQrdHVxK2JEaHBCanNtV1BBS3kxL1oweGR0?= =?utf-8?B?dmdLZjEzaGErQVpmT1BaaWxSMGxzMTNyOXQxU0xDU1dGZk1yTlhFbFdLVW9U?= =?utf-8?B?bXM5R3RkSlRNWk5SSkQzVGJ6OXVFa2dtOVk3WERQVzVqdys0Q215U2xBRy9W?= =?utf-8?B?Uk0vOFdqclhvd0k1N1JxWWp2Z3d1NnhzaHNGak5XeUZxSEN0M1hGaUFUbzJk?= =?utf-8?B?Q0RXamZZRW5DWU1nYzhBM1VBRUhXWUNwZTcwQkd1dkRlRnhYUEwzMHFNQ3ZB?= =?utf-8?B?T2ZicktJV1NKR2l2VlY1aTJ6QXRWRXFMelorc3p4TUtZYzJNeXpBeXNKNGNJ?= =?utf-8?B?Y3RPZ0xxSXRkdzRLcTBNNXU1TGI0aE9IaVp3M2ppYlFCS3JQamc0Yld6cFoy?= =?utf-8?B?cXVPTzJvMnIrMW81Vmc5L2dvRmZlSHpGWWUrVkNiYkdWcUREQ3RNY2pWWk1Y?= =?utf-8?B?TEx5VTNQYVQvdk5RRm5XMXZHOFpJN0lWYXU3YUw2d1lFbXgyYTJIbnc5cWJX?= =?utf-8?B?OGN5NEpZYjYzc05WbFp5eHhtWGZKNzVIamFTazRHMWVpZ2ZMSEtFZ0xiTTZz?= =?utf-8?B?aEV4WWc5T0xlaDZpMGpBbUxDa1AyRjErbTU0c2FEREZGYmZ5a3pXaUg4UWpX?= =?utf-8?B?ZEFiVWF3US9VUVFHVHVTMTg3Qit5Y204TlJiSWdPMGVZMmcwak9VZzl3SDlZ?= =?utf-8?B?MEUwYnRrK2haYVhwRzhSVlNTdm5vbUxidVJ6NkV0aDJWRkxyelhUdy8rYlZz?= =?utf-8?B?L093OFkvZXdyL2tuU0lWMHFlUVEwQnF1MHNoMDRXWlh3ZlRITXpzWmtnUDFw?= =?utf-8?B?RVlGOXN5QTQxTTZPMGhSS0EzVEc2UmlOSkxBRWNkRlJjSDFxWkFIOVU3L3lE?= =?utf-8?Q?F//++nxO2GkClAFlSudgoj44a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd96145-c262-4e0e-4765-08da9a1be446 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 08:49:41.3139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kvOXW0IRtvBniLViR034UjwG4EyQoECTp/+ID4F64RDwzEqn4Cvqiz9pg8keWGzCSBn4FRWi14KjrzkMKvrewg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7386 On 17.09.2022 04:51, Marek Marczykowski-Górecki wrote: > Make it consistent with console=xhci. > > Suggested-by: Jan Beulich > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Sep 19 08:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 08:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408434.651314 (Exim 4.92) (envelope-from ) id 1oaCWX-0004ql-Q1; Mon, 19 Sep 2022 08:53:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408434.651314; Mon, 19 Sep 2022 08:53:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCWX-0004qe-Mc; Mon, 19 Sep 2022 08:53:05 +0000 Received: by outflank-mailman (input) for mailman id 408434; Sun, 18 Sep 2022 19:18:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oZzoc-0007t5-3e for xen-devel@lists.xenproject.org; Sun, 18 Sep 2022 19:18:54 +0000 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [2607:f8b0:4864:20::d2e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba8e3432-3786-11ed-9761-273f2230c3a0; Sun, 18 Sep 2022 21:18:52 +0200 (CEST) Received: by mail-io1-xd2e.google.com with SMTP id p3so11547573iof.13 for ; Sun, 18 Sep 2022 12:18:52 -0700 (PDT) Received: from ?IPV6:2001:db8::165a:5551:20c6:ecaf? ([2607:fb91:1108:ae0:6e73:b13c:9e3e:3750]) by smtp.gmail.com with ESMTPSA id x12-20020a92b00c000000b002f5d9f49852sm46044ilh.14.2022.09.18.12.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Sep 2022 12:18:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba8e3432-3786-11ed-9761-273f2230c3a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stew.dk; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=lexXoQKidOKdhRihDMwjma87tp56OUQpeUHq174CHio=; b=XefqwD8UH088hbVFvga6zGD4KEDEtR3H81gXPkB0J5j7n9nKzmYRso2oqzLzWqu0dU oVCf7E4YuqH+gSF+nJiGRH1Tg8zhimQMnSCHtasSQTT0C8fyDP7vEFYP42ZXCXZky0Bt 1opcODbn2li/8fOVr5VRG9EOQG2pq1YXOLUMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=lexXoQKidOKdhRihDMwjma87tp56OUQpeUHq174CHio=; b=aF60ae14gDg2pEsYluGAIfONmfrzwSFqHkRWgkkbxnw3Ka0v7mLotSgyLm/dNZltG3 yj4oPoRIp/DPbBQoS96f266fLq1BL4TKwYh8EiobNASKJv7vzPPE8iyse3cEPSdjIoaH Sae38ezrhJ+fxZvnwFmmP21/U/h3KSSR4z63Rxf+GMx8fOO7uVZGSf3AoUmHdRJAZocc cvD1nvd3D5swBZ9pecv2I7CjRIAbbxRUevs3DUUFrOG9rXDNnhvxqGwaAzc5mNToiN10 hg9o5qNHZAw8xKdaP+psLqhT9M2L7DptG/JZ5Dy2QQcUn0mOJ/CqI2bOxAEjhbifmBuv NWVQ== X-Gm-Message-State: ACrzQf10WSJOHuczp6314ffDKqUpcWqz8GTz5fSnO05HYuzKUFxcV7Bj hwm+h/aBX6I3QmEgszHC/aoRmA== X-Google-Smtp-Source: AMsMyM5AkVMZzQA+6h69sO2EOknGNQt0Ip6n8W9jIZ9/YvEQdIXyAQbSbV22hrjqVaxuIl9ar0TluQ== X-Received: by 2002:a05:6602:1609:b0:6a1:899e:bf36 with SMTP id x9-20020a056602160900b006a1899ebf36mr5473711iow.121.1663528730811; Sun, 18 Sep 2022 12:18:50 -0700 (PDT) Message-ID: Date: Sun, 18 Sep 2022 15:18:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] MAINTAINERS: change my email Content-Language: en-US To: Jan Beulich , Stewart Hildebrand , Henry Wang Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jeff Kubascik , Nathan Studer , Robbie VanVossen , xen-devel@dornerworks.com, xen-devel@lists.xenproject.org References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> From: Stewart Hildebrand In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/16/22 02:08, Jan Beulich wrote: > On 15.09.2022 21:30, Stewart Hildebrand wrote: >> I am departing DornerWorks. I will still be working with Xen in my next >> role, and I still have an interest in maintaining the ARINC 653 >> scheduler, so change to my personal email address. Also change status to >> Maintained. >> >> Signed-off-by: Stewart Hildebrand >> --- >> MAINTAINERS | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e12c499a28..f674b5f7ba 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -221,8 +221,8 @@ F: xen/include/xen/argo.h >> F: xen/common/argo.c >> >> ARINC653 SCHEDULER >> -M: Stewart Hildebrand >> -S: Supported >> +M: Stewart Hildebrand >> +S: Maintained >> L: xen-devel@dornerworks.com >> F: xen/common/sched/arinc653.c >> F: tools/libs/ctrl/xc_arinc653.c > > If it was just for the email change, I would have said it can go in without > release manager approval. But the support level change I think wants a > release ack at this point. Just to not leave the question unasked: There's > no interest within DornerWorks to have someone else be (co)maintainer of > this code? Yes, there is interest. Nathan Studer has expressed interest. I will send out a v2. Stewart From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408574.651325 (Exim 4.92) (envelope-from ) id 1oaCpa-0007Fy-HZ; Mon, 19 Sep 2022 09:12:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408574.651325; Mon, 19 Sep 2022 09:12:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpa-0007Fr-Dw; Mon, 19 Sep 2022 09:12:46 +0000 Received: by outflank-mailman (input) for mailman id 408574; Mon, 19 Sep 2022 09:12:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpa-0007Fl-0i for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:46 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c4ec038-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:23 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id z25so45932663lfr.2 for ; Mon, 19 Sep 2022 02:12:44 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c4ec038-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=AfPstKk13JdIZMSlOZN4GRY7iYaNj9hgjfOeyJ3u/H0=; b=Uj/5rHaYI73vHgrkjKMjL4/ZAg/JHHp0Q0p2aOLnB9mldSt2vZ5HYQ+ro9Gi1cbiGp 38qjgO09JySceBCZOFHlTQTqE069fipPRsJ/hkjotympEqRRoygT5mNog/tbXdXmjNV7 cmA68sGMAkl3Bset38htDuD9JhI40Dp7QM12l184gINxIYHT1jxIcb7kfSFoJIimNDrB rVjE7AdyEW5DEsVvDfRqfiJm8OXQgtv5M9IwhgdVMsD+BJIi6YmLzWuu13m7IBpZcFaJ G6s6ggQAs01MctWZdHLM6hNbYCHQbeRBS5qwjHXQA4zLHAObWgV4sR0cBzF/xRDOPD1M 9Wqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=AfPstKk13JdIZMSlOZN4GRY7iYaNj9hgjfOeyJ3u/H0=; b=1CcOMpjZL4R7RHMjn06eHaFos+DibhD/+cA7lWW5+TwXPSQeeZZT2YTOiY4vYUfxGz msVfwgmBdjTCDQ1hNVJ+rBUE6oRShxbPBXRgENg18aZOFlhsiVCNVwRB04ozVDyMWMgO 9HbCddsO7gRzrTlLrxWKrrwaV9ao9JjLR3qjDvaHsPir4KIWhX9r0ofC/Ey0GbV2Mojz wDIsVEyZihjl2Meqc2XXxN2NKzV4LcZ3B7qZwrbaX/Txxa9wfrxOtxCZe+auz/aBfAZC 9vRaMpj7uOsUNvP6/hhJatXdhpGkAPN61X+L75MAXfb7/jjPNLLvX3PNCqQszPs5s3fl KjSg== X-Gm-Message-State: ACrzQf3fya4rSJ5W4tB1hJEbOJu8OAh6sRtyK8LvfCHMvLHzTCGmBGMs LcqQNO4SoMFZTGGY2awXNYvsOeBt0T4usVJW X-Google-Smtp-Source: AMsMyM7YU7mNt6wj9pTfRwsVfqlk0vs2DcQvdvP8nZTxCFTm1Hp6dbMlkk8HEL/enIEKZM4U5ay7eA== X-Received: by 2002:a05:6512:370c:b0:49f:c4fb:8706 with SMTP id z12-20020a056512370c00b0049fc4fb8706mr363638lfr.635.1663578764018; Mon, 19 Sep 2022 02:12:44 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 0/9] Xen FF-A mediator Date: Mon, 19 Sep 2022 11:12:29 +0200 Message-Id: <20220919091238.2068052-1-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This patch sets add a FF-A [1] mediator modeled after the TEE mediator already present in Xen. The FF-A mediator implements the subset of the FF-A 1.1 specification needed to communicate with OP-TEE using FF-A as transport mechanism instead of SMC/HVC as with the TEE mediator. It allows a similar design in OP-TEE as with the TEE mediator where OP-TEE presents one virtual partition of itself to each guest in Xen. The FF-A mediator is generic in the sense it has nothing OP-TEE specific except that only the subset needed for OP-TEE is implemented so far. The hooks needed to inform OP-TEE that a guest is created or destroyed is part of the FF-A specification. It should be possible to extend the FF-A mediator to implement a larger portion of the FF-A 1.1 specification without breaking with the way OP-TEE is communicated with here. So it should be possible to support any TEE or Secure Partition using FF-A as transport with this mediator. [1] https://developer.arm.com/documentation/den0077/latest Thanks, Jens v5->v6: * Updated "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" commit message and moved the patch right before the patch which needs it. Applied Michal Orzel's R-B tag. * Renamed the guest configuration option "ffa_enabled" to "ffa" and updated the description. * More tools update in "xen/arm: add a primitive FF-A mediator" with the "ffa" option, including golang and ocaml. * Update ffa_domain_init() to return an error if communication with the SPMC can't be established. * Factored out a ffa_domain_destroy() from ffa_relinquish_resources(). * Added ffa_get_call_count() to give an accurate number of FF-A function, updated in each patch as new FF-A functions are added. * Added a flags field in struct xen_arch_domainconfig that replaces the ffa_enabled field. * Made check_mandatory_feature() __init * Replaced a few printk() calls with gprintk() where needed. * Rebased on staging as of 2022-09-14 V4->v5: * Added "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" * Added documentation for the "ffa_enabled" guest config flag * Changed to GPL license for xen/arch/arm/ffa.c * Added __read_mostly and const where applicable * Added more describing comments in the code * Moved list of shared memory object ("ffa_mem_list") into the guest context as they are guest specific * Simplified a few of the simple wrapper functions for SMC to SPMC * Added a BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE) since the mediator currently depends on the page size to be same as FFA_PAGE_SIZE (4k). * Added max number of shared memory object per guest and max number of size of each shared memory object * Added helper macros to calculate offsets of different FF-A data structures in the communication buffer instead of relying on pointer arithmetic * Addressed style issues and other comments * Broke the commit "xen/arm: add FF-A mediator" into multiple parts, trying to add a few features at a time as requested * Added a missing call to rxtx_unmap() in ffa_relinquish_resources() * Assignment of "ffa_enabled" is kept as is until I have something definitive on the type etc. * Tested with CONFIG_DEBUG=y v3->v4: * Missed v3 and sent a v4 instead by mistake. v2->v3: * Generates offsets into struct arm_smccc_1_2_regs with asm-offsets.c in order to avoid hard coded offsets in the assembly function arm_smccc_1_2_smc() * Adds an entry in SUPPORT.md on the FF-A status * Adds a configuration variable "ffa_enabled" to tell if FF-A should be enabled for a particular domu guest * Moves the ffa_frag_list for fragmented memory share requests into struct ffa_ctx instead to keep it per guest in order to avoid mixups and simplify locking * Adds a spinlock to struct ffa_ctx for per guest locking * Addressing style issues and suggestions * Uses FFA_FEATURES to check that all the needed features are available before initializing the mediator * Rebased on staging as of 2022-06-20 v1->v2: * Rebased on staging to resolve some merge conflicts as requested Jens Wiklander (9): xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers xen/arm: add a primitive FF-A mediator xen/arm: ffa: add direct request support xen/arm: ffa: map SPMC rx/tx buffers xen/arm: ffa: send guest events to Secure Partitions xen/arm: ffa: support mapping guest RX/TX buffers xen/arm: ffa: support guest FFA_PARTITION_INFO_GET xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h xen/arm: ffa: support sharing memory SUPPORT.md | 7 + docs/man/xl.cfg.5.pod.in | 15 + tools/golang/xenlight/helpers.gen.go | 6 + tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 6 + tools/libs/light/libxl_arm.c | 6 + tools/libs/light/libxl_types.idl | 1 + tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/xl/xl_parse.c | 1 + xen/arch/arm/Kconfig | 11 + xen/arch/arm/Makefile | 1 + xen/arch/arm/arm64/asm-offsets.c | 9 + xen/arch/arm/arm64/smc.S | 42 + xen/arch/arm/domain.c | 11 + xen/arch/arm/domain_build.c | 1 + xen/arch/arm/ffa.c | 1827 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/domain.h | 4 + xen/arch/arm/include/asm/ffa.h | 78 ++ xen/arch/arm/include/asm/regs.h | 12 + xen/arch/arm/include/asm/smccc.h | 40 + xen/arch/arm/tee/optee.c | 11 - xen/arch/arm/vsmc.c | 19 +- xen/include/public/arch-arm.h | 4 + 24 files changed, 2100 insertions(+), 15 deletions(-) create mode 100644 xen/arch/arm/ffa.c create mode 100644 xen/arch/arm/include/asm/ffa.h -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408576.651347 (Exim 4.92) (envelope-from ) id 1oaCpf-0007mZ-7s; Mon, 19 Sep 2022 09:12:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408576.651347; Mon, 19 Sep 2022 09:12:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpf-0007mQ-3V; Mon, 19 Sep 2022 09:12:51 +0000 Received: by outflank-mailman (input) for mailman id 408576; Mon, 19 Sep 2022 09:12:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpd-0007Fl-Su for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:50 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e31760d-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:27 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id o2so43702278lfc.10 for ; Mon, 19 Sep 2022 02:12:48 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e31760d-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=kAMKsZJY8NuAHY6tLmixBTxvq2W8l0uN2A1EwOiyZdk=; b=tts75IWt0qI9nuAxiPpC6BhVuZAnWOfxgtyVqolADuj+XQu5vGDug6/ozSmI692NNp Q82M0Fz20aoittutCKvy+HcYY7BjOCvrUeIs/vqowgeIJ+VMZTOQWrbMN1qVi1xr9D7I gU4fCcbJjfLbEVgEMMGSNsxICrOCaiL3MPycTbETt3A5y9J5sXHBbL+ZdByradjQEkZK 7loUHgIMeptLWLzaVPTaoRNXsdbfzE7MCK4Uev3sTYiq4vGWVGQr8SMrLy9jMcrnSrQI 9GznT37KIE9Uo38JZ2/pEzAEhIHFKEV+2llO9BpT4vFCSziiNiFs1l+IUv3QhFdtHZHU iOMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=kAMKsZJY8NuAHY6tLmixBTxvq2W8l0uN2A1EwOiyZdk=; b=EwanK3VD2IddE46UtpX/aP34WzeYXL2FyBMdLfyGF0KlM3SVdBgnP0JgN5++ue5y12 7YJlfL4LWj/QkQbx8HV2uvFoZaRyoPs3aXI1nHhXMtd0YJFuFMplGFnZmhrr8FR3dqpJ 9sIQ3hCH2JyksGcMt25cLgOowjCVP+X88QhoK51R7bXZR1PZnxD1T8Mv0y9YkTgdRIph w1fwcxbDgOV4YACe4MZsfn1+Y0Cquu+DiuexA0Th2/4hSSgeZnezthN/yzroXfsCMm7H URW/kcUErWOlNtiGAjLGXfEtbGNtHRIzuVq+luvxxLFlNzKJ3h0JMnlVmggkdoz3B9OK 52Fw== X-Gm-Message-State: ACrzQf1m/YjlYf8rny5S0nm/dPpB/SftusmRzbJxwejibBP6VvJiqNE+ zya4l/2XZa//DuGyARj2th444zl25doVg4qQ X-Google-Smtp-Source: AMsMyM6vdt6qVWQzc8iEefPiMFX90fV/cdraP+8Z7ZOc88N12lvKJoPfJmwJEFSPBpALpzEfhju6Kg== X-Received: by 2002:a05:6512:3b0b:b0:49a:d44b:428 with SMTP id f11-20020a0565123b0b00b0049ad44b0428mr6297019lfv.0.1663578767047; Mon, 19 Sep 2022 02:12:47 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 2/9] xen/arm: add a primitive FF-A mediator Date: Mon, 19 Sep 2022 11:12:31 +0200 Message-Id: <20220919091238.2068052-3-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. This commit brings in only the parts needed to negotiate FF-A version number with guest and SPMC. A guest configuration variable "ffa_enabled" is used to indicate if a guest is trusted to use FF-A. This is loosely based on the TEE mediator framework and the OP-TEE mediator. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md | 7 + docs/man/xl.cfg.5.pod.in | 15 ++ tools/golang/xenlight/helpers.gen.go | 6 + tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 6 + tools/libs/light/libxl_arm.c | 6 + tools/libs/light/libxl_types.idl | 1 + tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/xl/xl_parse.c | 1 + xen/arch/arm/Kconfig | 11 + xen/arch/arm/Makefile | 1 + xen/arch/arm/domain.c | 11 + xen/arch/arm/domain_build.c | 1 + xen/arch/arm/ffa.c | 372 +++++++++++++++++++++++++++ xen/arch/arm/include/asm/domain.h | 4 + xen/arch/arm/include/asm/ffa.h | 78 ++++++ xen/arch/arm/vsmc.c | 17 +- xen/include/public/arch-arm.h | 4 + 19 files changed, 541 insertions(+), 3 deletions(-) create mode 100644 xen/arch/arm/ffa.c create mode 100644 xen/arch/arm/include/asm/ffa.h diff --git a/SUPPORT.md b/SUPPORT.md index 8ebd63ad8230..bf95e11857a1 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -806,6 +806,13 @@ that covers the DMA of the device to be passed through. No support for QEMU backends in a 16K or 64K domain. +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator + + Status, Arm64: Tech Preview + +There are still some code paths where a vCPU may hog a pCPU longer than +necessary. The FF-A mediator is not yet implemented for Arm32. + ### ARM: Guest Device Tree support Status: Supported diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index b2901e04cf6f..3391f32dffdd 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1616,6 +1616,21 @@ This feature is a B. =back +=item B + +B Allow a guest to communicate via FF-A with Secure Partitions +(SP), default false. + +Currently is only a small subset of the FF-A specification supported. Just +enough to communicate with OP-TEE. In general only direct messaging and +sharing memory with one SP. More advanced use cases where memory might be +shared or donated to multple SPs is not supported. + +See L for more +informantion about FF-A. + +This feature is a B. + =head2 Paravirtualised (PV) Guest Specific Options The following options apply only to Paravirtual (PV) guests. diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index fa3cf2ab7658..036cf284be13 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1117,6 +1117,9 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} x.ArchArm.GicVersion = GicVersion(xc.arch_arm.gic_version) x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) +if err := x.ArchArm.Ffa.fromC(&xc.arch_arm.ffa);err != nil { +return fmt.Errorf("converting field ArchArm.Ffa: %v", err) +} if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } @@ -1608,6 +1611,9 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} xc.arch_arm.gic_version = C.libxl_gic_version(x.ArchArm.GicVersion) xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) +if err := x.ArchArm.Ffa.toC(&xc.arch_arm.ffa); err != nil { +return fmt.Errorf("converting field ArchArm.Ffa: %v", err) +} if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index a0be7ada8c63..6bc029ecb6fa 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -531,6 +531,7 @@ TypeUnion DomainBuildInfoTypeUnion ArchArm struct { GicVersion GicVersion Vuart VuartType +Ffa Defbool } ArchX86 struct { MsrRelaxed Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 2321a648a59a..1102fe1002c5 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -278,6 +278,12 @@ */ #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 +/* + * LIBXL_HAVE_BUILDINFO_ARM_FFA_ENABLED indicates that + * libxl_domain_build_info has the arm.ffa_enabled field. + */ +#define LIBXL_HAVE_BUILDINFO_ARM_FFA_ENABLED 1 + /* * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing * 'soft reset' for domains and there is 'soft_reset' shutdown reason diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 1a3ac1646e94..5332a5e339c8 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -179,6 +179,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + libxl_defbool_setdefault(&d_config->b_info.arch_arm.ffa, false); + if ( libxl_defbool_val(d_config->b_info.arch_arm.ffa) ) + config->arch.flags |= XEN_ARM_FLAGS_FFA; + return 0; } @@ -1561,6 +1565,8 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, b_info->type = LIBXL_DOMAIN_TYPE_INVALID; libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH); + libxl_defbool_setdefault(&b_info->arch_arm.ffa, false); + return 0; } diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d634f304cda2..b093f115de81 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -658,6 +658,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), + ("ffa", libxl_defbool), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), ("assisted_xapic", libxl_defbool), diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 0c71e5eef3c7..3329c24fbb89 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -33,6 +33,7 @@ type xen_arm_arch_domainconfig = gic_version: int; nr_spis: int; clock_frequency: int32; + ffa: bool; } type x86_arch_emulation_flags = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index a8458e19ca4b..7474652bd06d 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -27,6 +27,7 @@ type xen_arm_arch_domainconfig = { gic_version: int; nr_spis: int; clock_frequency: int32; + ffa: bool; } type x86_arch_emulation_flags = diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1b5381cef033..46053b2bebbe 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2750,6 +2750,7 @@ skip_usbdev: exit(-ERROR_FAIL); } } + xlu_cfg_get_defbool(config, "ffa", &b_info->arch_arm.ffa, 0); parse_vkb_list(config, d_config); diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 1fe5faf847b8..09aba684bf41 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -140,6 +140,17 @@ config TEE source "arch/arm/tee/Kconfig" +config FFA + bool "Enable FF-A mediator support" if EXPERT + default n + depends on ARM_64 + help + This option enables a minimal FF-A mediator. The mediator is + generic as it follows the FF-A specification [1], but it only + implements a small subset of the specification. + + [1] https://developer.arm.com/documentation/den0077/latest + config STATIC_SHM bool "Statically shared memory on a dom0less system" if UNSUPPORTED depends on STATIC_MEMORY diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 4d076b278b10..5085e1c92aa6 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -21,6 +21,7 @@ obj-$(CONFIG_ARCH_MAP_DOMAIN_PAGE) += domain_page.o obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += efi/ +obj-$(CONFIG_FFA) += ffa.o obj-y += gic.o obj-y += gic-v2.o obj-$(CONFIG_GICV3) += gic-v3.o diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2d6253181a94..2ec4d5efa5e1 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -757,6 +758,9 @@ int arch_domain_create(struct domain *d, if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) goto fail; + if ( (rc = ffa_domain_init(d, config->arch.flags)) != 0 ) + goto fail; + update_domain_wallclock_time(d); /* @@ -799,6 +803,7 @@ void arch_domain_destroy(struct domain *d) */ iommu_domain_destroy(d); p2m_teardown(d); + ffa_domain_destroy(d); domain_vgic_free(d); domain_vuart_free(d); free_xenheap_page(d->shared_info); @@ -998,6 +1003,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) enum { PROG_pci = 1, PROG_tee, + PROG_ffa, PROG_xen, PROG_page, PROG_mapping, @@ -1043,6 +1049,11 @@ int domain_relinquish_resources(struct domain *d) PROGRESS(tee): ret = tee_relinquish_resources(d); + if ( ret ) + return ret; + + PROGRESS(ffa): + ret = ffa_relinquish_resources(d); if (ret ) return ret; diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 01c2aaccd82d..ad458e4b530f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -4021,6 +4021,7 @@ void __init create_dom0(void) if ( gic_number_lines() > 992 ) printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); dom0_cfg.arch.tee_type = tee_get_type(); + dom0_cfg.arch.flags = XEN_ARM_FLAGS_FFA; dom0_cfg.max_vcpus = dom0_max_vcpus(); if ( iommu_enabled ) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c new file mode 100644 index 000000000000..2c59c1f9b738 --- /dev/null +++ b/xen/arch/arm/ffa.c @@ -0,0 +1,372 @@ +/* + * xen/arch/arm/ffa.c + * + * Arm Firmware Framework for ARMv8-A (FF-A) mediator + * + * Copyright (C) 2022 Linaro Limited + * + * This program is free software; you can redistribute it and/or + * modify it under the terms and conditions of the GNU General Public + * License, version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; If not, see . + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +/* Error codes */ +#define FFA_RET_OK 0 +#define FFA_RET_NOT_SUPPORTED -1 +#define FFA_RET_INVALID_PARAMETERS -2 +#define FFA_RET_NO_MEMORY -3 +#define FFA_RET_BUSY -4 +#define FFA_RET_INTERRUPTED -5 +#define FFA_RET_DENIED -6 +#define FFA_RET_RETRY -7 +#define FFA_RET_ABORTED -8 + +/* FFA_VERSION helpers */ +#define FFA_VERSION_MAJOR_SHIFT 16U +#define FFA_VERSION_MAJOR_MASK 0x7FFFU +#define FFA_VERSION_MINOR_SHIFT 0U +#define FFA_VERSION_MINOR_MASK 0xFFFFU +#define MAKE_FFA_VERSION(major, minor) \ + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ + ((minor) & FFA_VERSION_MINOR_MASK)) + +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) + +/* + * This is the version we want to use in communication with guests and SPs. + * During negotiation with a guest or a SP we may need to lower it for + * that particular guest or SP. + */ +#define FFA_MY_VERSION_MAJOR 1U +#define FFA_MY_VERSION_MINOR 1U +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ + FFA_MY_VERSION_MINOR) + +#define FFA_PAGE_SIZE SZ_4K + +/* + * Limit for shared buffer size. Please note that this define limits + * number of pages. But user buffer can be not aligned to a page + * boundary. So it is possible that user would not be able to share + * exactly MAX_SHM_BUFFER_PG * PAGE_SIZE bytes. + * + * FF-A doesn't have any direct requirments on GlobalPlatform or vice + * versa, but an implementation can very well use FF-A in order to provide + * a GlobalPlatform interface on top. + * + * Global Platform specification for TEE requires that any TEE + * implementation should allow to share buffers with size of at least + * 512KB, which equals to 128 4kB pages. Due to align issue mentioned + * above, we need to increase this value to 129. + */ +#define FFA_MAX_SHM_PAGE_COUNT 129 + +/* + * Limits the number of shared buffers that guest can have at once. This + * is to prevent case, when guests tricks XEN into exhausting its own + * memory by allocating many small buffers. This value has been chosen + * arbitrary. + */ +#define FFA_MAX_SHM_COUNT 32 + +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) + +/* Memory attributes: Normal memory, Write-Back cacheable, Inner shareable */ +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU + +/* Memory access permissions: Read-write */ +#define FFA_MEM_ACC_RW 0x2U + +/* Clear memory before mapping in receiver */ +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) +/* Relayer may time slice this operation */ +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) +/* Clear memory after receiver relinquishes it */ +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) + +/* Share memory transaction */ +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) + +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL + +/* Framework direct request/response */ +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) +#define FFA_MSG_TYPE_MASK 0xFFU; +#define FFA_MSG_PSCI 0x0U +#define FFA_MSG_SEND_VM_CREATED 0x4U +#define FFA_MSG_RESP_VM_CREATED 0x5U +#define FFA_MSG_SEND_VM_DESTROYED 0x6U +#define FFA_MSG_RESP_VM_DESTROYED 0x7U + +/* + * Flags used for the FFA_PARTITION_INFO_GET return message: + * BIT(0): Supports receipt of direct requests + * BIT(1): Can send direct requests + * BIT(2): Can send and receive indirect messages + * BIT(3): Supports receipt of notifications + * BIT(4-5): Partition ID is a PE endpoint ID + */ +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) +#define FFA_PART_PROP_IS_PE_ID (0U << 4) +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) + +/* + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition + * count only. + */ +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) + +/* Function IDs */ +#define FFA_ERROR 0x84000060U +#define FFA_SUCCESS_32 0x84000061U +#define FFA_SUCCESS_64 0xC4000061U +#define FFA_INTERRUPT 0x84000062U +#define FFA_VERSION 0x84000063U +#define FFA_FEATURES 0x84000064U +#define FFA_RX_ACQUIRE 0x84000084U +#define FFA_RX_RELEASE 0x84000065U +#define FFA_RXTX_MAP_32 0x84000066U +#define FFA_RXTX_MAP_64 0xC4000066U +#define FFA_RXTX_UNMAP 0x84000067U +#define FFA_PARTITION_INFO_GET 0x84000068U +#define FFA_ID_GET 0x84000069U +#define FFA_SPM_ID_GET 0x84000085U +#define FFA_MSG_WAIT 0x8400006BU +#define FFA_MSG_YIELD 0x8400006CU +#define FFA_MSG_RUN 0x8400006DU +#define FFA_MSG_SEND2 0x84000086U +#define FFA_MSG_SEND_DIRECT_REQ_32 0x8400006FU +#define FFA_MSG_SEND_DIRECT_REQ_64 0xC400006FU +#define FFA_MSG_SEND_DIRECT_RESP_32 0x84000070U +#define FFA_MSG_SEND_DIRECT_RESP_64 0xC4000070U +#define FFA_MEM_DONATE_32 0x84000071U +#define FFA_MEM_DONATE_64 0xC4000071U +#define FFA_MEM_LEND_32 0x84000072U +#define FFA_MEM_LEND_64 0xC4000072U +#define FFA_MEM_SHARE_32 0x84000073U +#define FFA_MEM_SHARE_64 0xC4000073U +#define FFA_MEM_RETRIEVE_REQ_32 0x84000074U +#define FFA_MEM_RETRIEVE_REQ_64 0xC4000074U +#define FFA_MEM_RETRIEVE_RESP 0x84000075U +#define FFA_MEM_RELINQUISH 0x84000076U +#define FFA_MEM_RECLAIM 0x84000077U +#define FFA_MEM_FRAG_RX 0x8400007AU +#define FFA_MEM_FRAG_TX 0x8400007BU +#define FFA_MSG_SEND 0x8400006EU +#define FFA_MSG_POLL 0x8400006AU + +struct ffa_ctx { + uint32_t guest_vers; +}; + +/* Negotiated FF-A version to use with the SPMC */ +static uint32_t ffa_version __ro_after_init; + +static bool ffa_get_version(uint32_t *vers) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_VERSION, + .a1 = FFA_MY_VERSION, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) + { + gprintk(XENLOG_ERR, "ffa: FFA_VERSION returned not supported\n"); + return false; + } + + *vers = resp.a0; + + return true; +} + +static u16 get_vm_id(const struct domain *d) +{ + /* +1 since 0 is reserved for the hypervisor in FF-A */ + return d->domain_id + 1; +} + +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, + register_t v2, register_t v3, register_t v4, register_t v5, + register_t v6, register_t v7) +{ + set_user_reg(regs, 0, v0); + set_user_reg(regs, 1, v1); + set_user_reg(regs, 2, v2); + set_user_reg(regs, 3, v3); + set_user_reg(regs, 4, v4); + set_user_reg(regs, 5, v5); + set_user_reg(regs, 6, v6); + set_user_reg(regs, 7, v7); +} + +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, + uint32_t w3) +{ + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); +} + +static void handle_version(struct cpu_user_regs *regs) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + uint32_t vers = get_user_reg(regs, 1); + + if ( vers < FFA_VERSION_1_1 ) + vers = FFA_VERSION_1_0; + else + vers = FFA_VERSION_1_1; + + ctx->guest_vers = vers; + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); +} + +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + + if ( !ctx ) + return false; + + switch ( fid ) + { + case FFA_VERSION: + handle_version(regs); + return true; + case FFA_ID_GET: + set_regs_success(regs, get_vm_id(d), 0); + return true; + + default: + gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); + return false; + } +} + +uint32_t ffa_get_call_count(void) +{ + uint32_t count = 0; + + if ( IS_ENABLED(CONFIG_FFA) ) + count += 2; + + return count; +} + +int ffa_domain_init(struct domain *d, uint32_t flags) +{ + struct ffa_ctx *ctx; + + if ( !ffa_version || !(flags & XEN_ARM_FLAGS_FFA) ) + return -ENODEV; + + ctx = xzalloc(struct ffa_ctx); + if ( !ctx ) + return -ENOMEM; + + d->arch.ffa = ctx; + + return 0; +} + +/* This function is supposed to undo what ffa_domain_init() has done */ +void ffa_domain_destroy(struct domain *d) +{ + struct ffa_ctx *ctx = d->arch.ffa; + + if ( !ctx ) + return; + + XFREE(d->arch.ffa); +} + +/* + * This function is supposed to undo what has been done after + * ffa_domain_init(). + */ +int ffa_relinquish_resources(struct domain *d) +{ + return 0; +} + +static int __init ffa_init(void) +{ + uint32_t vers; + unsigned int major_vers; + unsigned int minor_vers; + + /* + * FFA_PAGE_SIZE is defined to 4k and we're currently depending on + * using that page size. + */ + BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE); + + /* + * psci_init_smccc() updates this value with what's reported by EL-3 + * or secure world. + */ + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) + { + printk(XENLOG_ERR + "ffa: unsupported SMCCC version %#x (need at least %#x)\n", + smccc_ver, ARM_SMCCC_VERSION_1_2); + return 0; + } + + if ( !ffa_get_version(&vers) ) + return 0; + + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) + { + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers); + return 0; + } + + major_vers = (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR_MASK; + minor_vers = vers & FFA_VERSION_MINOR_MASK; + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", + FFA_MY_VERSION_MAJOR, FFA_MY_VERSION_MINOR); + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", + major_vers, minor_vers); + + ffa_version = vers; + + return 0; +} + +__initcall(ffa_init); diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 26a8348eed2b..e3c30fbaa99a 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -104,6 +104,10 @@ struct arch_domain void *tee; #endif +#ifdef CONFIG_FFA + void *ffa; +#endif + } __cacheline_aligned; struct arch_vcpu diff --git a/xen/arch/arm/include/asm/ffa.h b/xen/arch/arm/include/asm/ffa.h new file mode 100644 index 000000000000..b2ab12496a51 --- /dev/null +++ b/xen/arch/arm/include/asm/ffa.h @@ -0,0 +1,78 @@ +/* + * xen/arch/arm/ffa.c + * + * Arm Firmware Framework for ARMv8-A(FFA) mediator + * + * Copyright (C) 2021 Linaro Limited + * + * Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without restriction, + * including without limitation the rights to use, copy, modify, merge, + * publish, distribute, sublicense, and/or sell copies of the Software, + * and to permit persons to whom the Software is furnished to do so, + * subject to the following conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + */ + +#ifndef __ASM_ARM_FFA_H__ +#define __ASM_ARM_FFA_H__ + +#include + +#include +#include + +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) + +static inline bool is_ffa_fid(uint32_t fid) +{ + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; + + return fn >= FFA_FNUM_MIN_VALUE && fn <= FFA_FNUM_MAX_VALUE; +} + +#ifdef CONFIG_FFA +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid); +uint32_t ffa_get_call_count(void); +int ffa_domain_init(struct domain *d, uint32_t flags); +void ffa_domain_destroy(struct domain *d); +int ffa_relinquish_resources(struct domain *d); +#else +static inline bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) +{ + return false; +} + +static inline uint32_t ffa_get_call_count(void) +{ + return 0; +} + +static inline int ffa_domain_init(struct domain *d, bool ffa_enabled) +{ + return -ENODEV; +} + +static inline void ffa_domain_destroy(struct domain *d) +{ +} + +static inline int ffa_relinquish_resources(struct domain *d) +{ + return 0; +} +#endif + +#endif /*__ASM_ARM_FFA_H__*/ diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index 6f90c08a6304..b1b9be36d238 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -32,7 +33,7 @@ #define XEN_SMCCC_FUNCTION_COUNT 3 /* Number of functions currently supported by Standard Service Service Calls. */ -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + ffa_get_call_count()) static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) { @@ -196,13 +197,23 @@ static bool handle_existing_apis(struct cpu_user_regs *regs) return do_vpsci_0_1_call(regs, fid); } +static bool is_psci_fid(uint32_t fid) +{ + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; + + return fn >= 0 && fn <= 0x1fU; +} + /* PSCI 0.2 interface and other Standard Secure Calls */ static bool handle_sssc(struct cpu_user_regs *regs) { uint32_t fid = (uint32_t)get_user_reg(regs, 0); - if ( do_vpsci_0_2_call(regs, fid) ) - return true; + if ( is_psci_fid(fid) ) + return do_vpsci_0_2_call(regs, fid); + + if ( is_ffa_fid(fid) ) + return ffa_handle_call(regs, fid); switch ( fid ) { diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index c8b6058d3a83..0c5381439196 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -335,6 +335,10 @@ struct xen_arch_domainconfig { * */ uint32_t clock_frequency; +#define _XEN_ARM_FLAGS_FFA 0 +#define XEN_ARM_FLAGS_FFA (1U << _XEN_ARM_FLAGS_FFA) + /* IN */ + uint32_t flags; }; #endif /* __XEN__ || __XEN_TOOLS__ */ -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408575.651336 (Exim 4.92) (envelope-from ) id 1oaCpc-0007Vu-Uo; Mon, 19 Sep 2022 09:12:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408575.651336; Mon, 19 Sep 2022 09:12:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpc-0007Vn-RY; Mon, 19 Sep 2022 09:12:48 +0000 Received: by outflank-mailman (input) for mailman id 408575; Mon, 19 Sep 2022 09:12:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpb-0007S6-OT for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:47 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39a953fc-37fb-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 11:12:46 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id a14so30954049ljj.8 for ; Mon, 19 Sep 2022 02:12:46 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39a953fc-37fb-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=NUUOOqYydiRztk2+PXHvZdFqULJvxVlGXUcw0oHBVH8=; b=pOsW907B4i0eugdEEMl5LxmCXFPIdoH958yELCS0//NTftT/UReY0PZxEZ7NzXMPOY vN0wvrNrSHVqywfibzPJ87+zN/Ws1YI1+guEKJyM7zWNJP5t6WQuCk5zbt28j5c7cR5V 4/B71UkVlvaky0/DrgRqMhlcquWI0/lDSSWPsjYfP2pXELO4g1V+xIgM9GDRmB6pjpLJ gn4cUbq5gxM20JfY76j20uIo96soNq3fSLwSb1zKgblyGvM0RBNd89JH433IKWdXcwaM 7IWzwmQQkoD7jtXorQwLmvvrH4MTRroTsM0TvXSpiIT5Vy2lbegtdabxScRB+BypjdPH hxuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=NUUOOqYydiRztk2+PXHvZdFqULJvxVlGXUcw0oHBVH8=; b=CatYY8vJCxWUtfMaE2UiNkqZM9ev35f5iSiCLQHnR/tMqZjQoYOafL/LNmvLZniDH3 TuNYaDIkAFu5xYXVIlBI8DXhm+ujCmwQF1g4IfrgKZFw+mQzxAD7w8/hp65HncrcTFcK QQHhHR7Of2uAUhAFnGuVjxC084Isy52kQ2AwG28Fm0R74g817so9YoeSyuUrYsEEAw2X otDijT4NP5mKPnsbM9khAzwoX18gpbPQtHtf6FbwPqlUmqqgUe+BhkwiT5ew9+QUQfh0 GCcWuCfHEKQ/W9fEkxV2XMhq59wC+O6QwL8NI3kcug0IRSOh92oH8iIO28FfjPf3h1UF 3/+g== X-Gm-Message-State: ACrzQf0Mn6mZRXMyPi+3fVvOP+9uPFmiGYgrrvkSPQhtej7IzDCWqZZg LU0TvZ6hgN5or9Ogmjf3fZHGGyNuD2YtMQ== X-Google-Smtp-Source: AMsMyM5s2r1MCsUEqCwIfhgAOWd42+fV7GRVsCB/L54JET58STh/4c5m0fGQ7ZiUkFrJNDjeUYy5Iw== X-Received: by 2002:a2e:940f:0:b0:261:b9ca:6207 with SMTP id i15-20020a2e940f000000b00261b9ca6207mr4956248ljh.192.1663578765398; Mon, 19 Sep 2022 02:12:45 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander , Luca Fancellu Subject: [PATCH v6 1/9] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers Date: Mon, 19 Sep 2022 11:12:30 +0200 Message-Id: <20220919091238.2068052-2-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SMCCC v1.2 [1] AArch64 allows x0-x17 to be used as both parameter registers and result registers for the SMC and HVC instructions. Arm Firmware Framework for Armv8-A specification makes use of x0-x7 as parameter and result registers. Let us add new interface to support this extended set of input/output registers. This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 extended input/output registers") by Sudeep Holla from the Linux kernel The SMCCC version reported to the VM is bumped to 1.2 in order to support handling FF-A messages. [1] https://developer.arm.com/documentation/den0028/c/?lang=en Reviewed-by: Luca Fancellu Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/asm-offsets.c | 9 +++++++ xen/arch/arm/arm64/smc.S | 42 ++++++++++++++++++++++++++++++++ xen/arch/arm/include/asm/smccc.h | 40 ++++++++++++++++++++++++++++++ xen/arch/arm/vsmc.c | 2 +- 4 files changed, 92 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/asm-offsets.c b/xen/arch/arm/arm64/asm-offsets.c index 280ddb55bfd4..1721e1ed26e1 100644 --- a/xen/arch/arm/arm64/asm-offsets.c +++ b/xen/arch/arm/arm64/asm-offsets.c @@ -56,6 +56,15 @@ void __dummy__(void) BLANK(); OFFSET(SMCCC_RES_a0, struct arm_smccc_res, a0); OFFSET(SMCCC_RES_a2, struct arm_smccc_res, a2); + OFFSET(ARM_SMCCC_1_2_REGS_X0_OFFS, struct arm_smccc_1_2_regs, a0); + OFFSET(ARM_SMCCC_1_2_REGS_X2_OFFS, struct arm_smccc_1_2_regs, a2); + OFFSET(ARM_SMCCC_1_2_REGS_X4_OFFS, struct arm_smccc_1_2_regs, a4); + OFFSET(ARM_SMCCC_1_2_REGS_X6_OFFS, struct arm_smccc_1_2_regs, a6); + OFFSET(ARM_SMCCC_1_2_REGS_X8_OFFS, struct arm_smccc_1_2_regs, a8); + OFFSET(ARM_SMCCC_1_2_REGS_X10_OFFS, struct arm_smccc_1_2_regs, a10); + OFFSET(ARM_SMCCC_1_2_REGS_X12_OFFS, struct arm_smccc_1_2_regs, a12); + OFFSET(ARM_SMCCC_1_2_REGS_X14_OFFS, struct arm_smccc_1_2_regs, a14); + OFFSET(ARM_SMCCC_1_2_REGS_X16_OFFS, struct arm_smccc_1_2_regs, a16); } /* diff --git a/xen/arch/arm/arm64/smc.S b/xen/arch/arm/arm64/smc.S index 91bae62dd4d2..fc6b676e2ee3 100644 --- a/xen/arch/arm/arm64/smc.S +++ b/xen/arch/arm/arm64/smc.S @@ -27,3 +27,45 @@ ENTRY(__arm_smccc_1_0_smc) stp x2, x3, [x4, #SMCCC_RES_a2] 1: ret + +/* + * void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, + * struct arm_smccc_1_2_regs *res) + */ +ENTRY(arm_smccc_1_2_smc) + /* Save `res` and free a GPR that won't be clobbered by SMC call */ + stp x1, x19, [sp, #-16]! + + /* Ensure `args` won't be clobbered while loading regs in next step */ + mov x19, x0 + + /* Load the registers x0 - x17 from the struct arm_smccc_1_2_regs */ + ldp x0, x1, [x19, #ARM_SMCCC_1_2_REGS_X0_OFFS] + ldp x2, x3, [x19, #ARM_SMCCC_1_2_REGS_X2_OFFS] + ldp x4, x5, [x19, #ARM_SMCCC_1_2_REGS_X4_OFFS] + ldp x6, x7, [x19, #ARM_SMCCC_1_2_REGS_X6_OFFS] + ldp x8, x9, [x19, #ARM_SMCCC_1_2_REGS_X8_OFFS] + ldp x10, x11, [x19, #ARM_SMCCC_1_2_REGS_X10_OFFS] + ldp x12, x13, [x19, #ARM_SMCCC_1_2_REGS_X12_OFFS] + ldp x14, x15, [x19, #ARM_SMCCC_1_2_REGS_X14_OFFS] + ldp x16, x17, [x19, #ARM_SMCCC_1_2_REGS_X16_OFFS] + + smc #0 + + /* Load the `res` from the stack */ + ldr x19, [sp] + + /* Store the registers x0 - x17 into the result structure */ + stp x0, x1, [x19, #ARM_SMCCC_1_2_REGS_X0_OFFS] + stp x2, x3, [x19, #ARM_SMCCC_1_2_REGS_X2_OFFS] + stp x4, x5, [x19, #ARM_SMCCC_1_2_REGS_X4_OFFS] + stp x6, x7, [x19, #ARM_SMCCC_1_2_REGS_X6_OFFS] + stp x8, x9, [x19, #ARM_SMCCC_1_2_REGS_X8_OFFS] + stp x10, x11, [x19, #ARM_SMCCC_1_2_REGS_X10_OFFS] + stp x12, x13, [x19, #ARM_SMCCC_1_2_REGS_X12_OFFS] + stp x14, x15, [x19, #ARM_SMCCC_1_2_REGS_X14_OFFS] + stp x16, x17, [x19, #ARM_SMCCC_1_2_REGS_X16_OFFS] + + /* Restore original x19 */ + ldp xzr, x19, [sp], #16 + ret diff --git a/xen/arch/arm/include/asm/smccc.h b/xen/arch/arm/include/asm/smccc.h index b3dbeecc90ad..b5e3f67eb34e 100644 --- a/xen/arch/arm/include/asm/smccc.h +++ b/xen/arch/arm/include/asm/smccc.h @@ -33,6 +33,7 @@ #define ARM_SMCCC_VERSION_1_0 SMCCC_VERSION(1, 0) #define ARM_SMCCC_VERSION_1_1 SMCCC_VERSION(1, 1) +#define ARM_SMCCC_VERSION_1_2 SMCCC_VERSION(1, 2) /* * This file provides common defines for ARM SMC Calling Convention as @@ -265,6 +266,45 @@ void __arm_smccc_1_0_smc(register_t a0, register_t a1, register_t a2, else \ arm_smccc_1_0_smc(__VA_ARGS__); \ } while ( 0 ) + +/** + * struct arm_smccc_1_2_regs - Arguments for or Results from SMC call + * @a0-a17 argument values from registers 0 to 17 + */ +struct arm_smccc_1_2_regs { + unsigned long a0; + unsigned long a1; + unsigned long a2; + unsigned long a3; + unsigned long a4; + unsigned long a5; + unsigned long a6; + unsigned long a7; + unsigned long a8; + unsigned long a9; + unsigned long a10; + unsigned long a11; + unsigned long a12; + unsigned long a13; + unsigned long a14; + unsigned long a15; + unsigned long a16; + unsigned long a17; +}; + +/** + * arm_smccc_1_2_smc() - make SMC calls + * @args: arguments passed via struct arm_smccc_1_2_regs + * @res: result values via struct arm_smccc_1_2_regs + * + * This function is used to make SMC calls following SMC Calling Convention + * v1.2 or above. The content of the supplied param are copied from the + * structure to registers prior to the SMC instruction. The return values + * are updated with the content from registers on return from the SMC + * instruction. + */ +void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, + struct arm_smccc_1_2_regs *res); #endif /* CONFIG_ARM_64 */ #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index 676740ef1520..6f90c08a6304 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -93,7 +93,7 @@ static bool handle_arch(struct cpu_user_regs *regs) switch ( fid ) { case ARM_SMCCC_VERSION_FID: - set_user_reg(regs, 0, ARM_SMCCC_VERSION_1_1); + set_user_reg(regs, 0, ARM_SMCCC_VERSION_1_2); return true; case ARM_SMCCC_ARCH_FEATURES_FID: -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408577.651358 (Exim 4.92) (envelope-from ) id 1oaCpg-00084T-Ja; Mon, 19 Sep 2022 09:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408577.651358; Mon, 19 Sep 2022 09:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpg-00084J-FY; Mon, 19 Sep 2022 09:12:52 +0000 Received: by outflank-mailman (input) for mailman id 408577; Mon, 19 Sep 2022 09:12:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpe-0007Fl-TF for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:51 +0000 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [2a00:1450:4864:20::22a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ed57079-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:28 +0200 (CEST) Received: by mail-lj1-x22a.google.com with SMTP id p5so33065449ljc.13 for ; Mon, 19 Sep 2022 02:12:49 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ed57079-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=dTuNjXgyBfvzCCDCoc8QvNxOjT9fIIF4QTxOBbjxKnU=; b=vOibNR0jsvRxa0U570LXmRFO0UM2Uy2rL0UbI05pfuUz7h9bb8idHhEYPBTypqB0NP kKizqz9yBTSKEIaU967BgnN4WCtbYShcajiHTqcssCKJEJQVPpRfmisdtu9nz0x6yVw+ lcxxXZkPPJ64t/Qhq87zyYJj3zczGVvhj9wtRYdMbLSPMFn/oqYQP9wJmaY7cQvivBMU hVHidJvute8DqRCDnlfEZCnFbxQO118s8CH/yIWl4hcEei6Ew15VsY6MAN0GHQGFROvv ww2zSGxwvVpooFrk8qPIg/ruN9LjKv3ny3RHh2u2teZtDt58P7PX9t2Fqw7xrvMrQ0Xl aDCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=dTuNjXgyBfvzCCDCoc8QvNxOjT9fIIF4QTxOBbjxKnU=; b=Xhle93laZinRDuAA3jzQZCTxjDpRUIoj509/MLuOGOZI4E4oIbM85UcOp+abgipjHY iBPfczvs+OA3hkaJSeVscJGJfKWFuBWmKGhOUgCHrLSvxvuEVklwD8Lw5QOSPXUwB0Pz IPI5uHZ6gFNj0h0dIUad/ZO/iN8P+3HjGSVP1SgZtdvky430Uv1GcXedb/npZm1XTDX6 +io2uMP37Bhwk+dxPbR8cGbsS+iMW1pzmRZ6g4dnfRUU4PTxBzBiyyzAbYE8O/Gh9Cvn JUt4+b87nc9Z8EycaMlLSg1acaV7Ztcc+oPOTvqRRUKA1VjaSdkehearUAeowBlq/bdC YU0g== X-Gm-Message-State: ACrzQf1Q1qXp0bseRviZ0rJXx2ryKr/jUl1IveYupjmi6OMzbtOrQ28r Ff8OnQH1cSnJfsOapuoEYc5xC86v43wp+Q== X-Google-Smtp-Source: AMsMyM7CMGig3UNzqX+bWPXFW4HhKtyfrOldKWaFCcuo2awNTJ7TdKKaYnUOjSimQVWBbZZN5eaKzA== X-Received: by 2002:a2e:99cf:0:b0:26a:b558:9023 with SMTP id l15-20020a2e99cf000000b0026ab5589023mr5207365ljj.519.1663578768409; Mon, 19 Sep 2022 02:12:48 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 3/9] xen/arm: ffa: add direct request support Date: Mon, 19 Sep 2022 11:12:32 +0200 Message-Id: <20220919091238.2068052-4-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for sending a FF-A direct request. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 125 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 124 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 2c59c1f9b738..90b5aa10a1fa 100644 --- a/xen/arch/arm/ffa.c +++ b/xen/arch/arm/ffa.c @@ -189,6 +189,7 @@ struct ffa_ctx { uint32_t guest_vers; + bool interrupted; }; /* Negotiated FF-A version to use with the SPMC */ @@ -214,6 +215,55 @@ static bool ffa_get_version(uint32_t *vers) return true; } +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) +{ + switch ( resp->a0 ) + { + case FFA_ERROR: + if ( resp->a2 ) + return resp->a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + case FFA_SUCCESS_64: + return FFA_RET_OK; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a2, + register_t a3, register_t a4) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = fid, + .a1 = a1, + .a2 = a2, + .a3 = a3, + .a4 = a4, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + return get_ffa_ret_code(&resp); +} + +static int32_t ffa_features(uint32_t id) +{ + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); +} + +static bool __init check_mandatory_feature(uint32_t id) +{ + uint32_t ret = ffa_features(id); + + if (ret) + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id); + + return !ret; +} + static u16 get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -255,6 +305,66 @@ static void handle_version(struct cpu_user_regs *regs) set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); } +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) +{ + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; + struct arm_smccc_1_2_regs resp = { }; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + uint32_t src_dst; + uint64_t mask; + + if ( smccc_is_conv_64(fid) ) + mask = GENMASK_ULL(63, 0); + else + mask = GENMASK_ULL(31, 0); + + src_dst = get_user_reg(regs, 1); + if ( (src_dst >> 16) != get_vm_id(d) ) + { + resp.a0 = FFA_ERROR; + resp.a2 = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + arg.a1 = src_dst; + arg.a2 = get_user_reg(regs, 2) & mask; + arg.a3 = get_user_reg(regs, 3) & mask; + arg.a4 = get_user_reg(regs, 4) & mask; + arg.a5 = get_user_reg(regs, 5) & mask; + arg.a6 = get_user_reg(regs, 6) & mask; + arg.a7 = get_user_reg(regs, 7) & mask; + + while ( true ) + { + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_INTERRUPT: + ctx->interrupted = true; + goto out; + case FFA_ERROR: + case FFA_SUCCESS_32: + case FFA_SUCCESS_64: + case FFA_MSG_SEND_DIRECT_RESP_32: + case FFA_MSG_SEND_DIRECT_RESP_64: + goto out; + default: + /* Bad fid, report back. */ + memset(&arg, 0, sizeof(arg)); + arg.a0 = FFA_ERROR; + arg.a1 = src_dst; + arg.a2 = FFA_RET_NOT_SUPPORTED; + continue; + } + } + +out: + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & mask, + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); +} + bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) { struct domain *d = current->domain; @@ -271,6 +381,12 @@ bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) case FFA_ID_GET: set_regs_success(regs, get_vm_id(d), 0); return true; + case FFA_MSG_SEND_DIRECT_REQ_32: +#ifdef CONFIG_ARM_64 + case FFA_MSG_SEND_DIRECT_REQ_64: +#endif + handle_msg_send_direct_req(regs, fid); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -283,7 +399,11 @@ uint32_t ffa_get_call_count(void) uint32_t count = 0; if ( IS_ENABLED(CONFIG_FFA) ) - count += 2; + { + if ( IS_ENABLED(CONFIG_ARM_64) ) + count += 1; + count += 3; + } return count; } @@ -364,6 +484,9 @@ static int __init ffa_init(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); + if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + return 0; + ffa_version = vers; return 0; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408578.651363 (Exim 4.92) (envelope-from ) id 1oaCph-000889-0M; Mon, 19 Sep 2022 09:12:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408578.651363; Mon, 19 Sep 2022 09:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpg-00087Y-QU; Mon, 19 Sep 2022 09:12:52 +0000 Received: by outflank-mailman (input) for mailman id 408578; Mon, 19 Sep 2022 09:12:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpf-0007Fl-TZ for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:52 +0000 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [2a00:1450:4864:20::234]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2fa1d8ae-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:29 +0200 (CEST) Received: by mail-lj1-x234.google.com with SMTP id a10so247609ljq.0 for ; Mon, 19 Sep 2022 02:12:50 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fa1d8ae-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=6I3/XH3qPV3YutRTqfgDPkoEm9m6vnrvTMroZ0piAAQ=; b=B3T/f6oj76QvIWRa+RhS/iC5bJ7/14WTEXrZwB53jAd8KlbG29+wHvozzIHA4flZat H7XTfkHpIHTYDKdTEuQ4+zlZ7bceOSLVW7DtcUc7g4LYxSyY3NSNsnX04GaSTn/xFguW RqthVJJkOWEpxHGoKn6Br1zlGMxFf6ENGfW6pMmuNg6CMk7B5FVk6U05DSPxkBoZLtOn 8vG9VCUEmd+eUAruqMLS6dJukku2gE2rhw6naNp4JeZdmgKTM8rnF4VT7tfCWqSfhvQk oRVsVbEDoYn1kQfA7mbHdCxSy1qCaohGBX5gbqFHsevBBSzsXi6V/QHGi5AdJ1xl2Gfw vV7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=6I3/XH3qPV3YutRTqfgDPkoEm9m6vnrvTMroZ0piAAQ=; b=jEmO/kl32JoxjT3+MJey+QGiu716K+pn3vYzKLBags9QGTzlCQqWuo47bdjTMaBdqo kDQ3+zMkwZIPpg44jFpKVkxs50vrIcIiqt/rpO7zCxBZ3lv6Q4+apZE5vOIuGgu8vh2E 9vZOpTBfIeypXKbUAz3XRyqIkA7s+UvX8Zm3iGyg+Px24A5Ee4ZddHskA4TkeP0EU7AF aVWLyKrMSHO4eVSf+IWIzYyuK100P2K1430HnTnVaraeyZPdztKdLeCB7v7/D3G6YIXu 1p84w2U2r0UsDibzm8gc1s16iWhgt1xF3LSz/FlrG/nXegcYhtI+1aq8u6fUZDJqY5XW GyuQ== X-Gm-Message-State: ACrzQf3keu/Zduhh3X7UDGC0Ve2+zdGkwiLYEj3262++Q8y5x/T7SFJQ W9QzI6sY07eN3aMiowOOa76Lg0S1wyxf54d5 X-Google-Smtp-Source: AMsMyM6CtZP4doffMlot6spC0CdCddbWHMTt7PwC8Yu/I60Kei1HUpWsLsqbeCSj9xasLrSgJ5N4jw== X-Received: by 2002:a2e:b5b5:0:b0:26a:c76d:145a with SMTP id f21-20020a2eb5b5000000b0026ac76d145amr5201438ljn.119.1663578769762; Mon, 19 Sep 2022 02:12:49 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 4/9] xen/arm: ffa: map SPMC rx/tx buffers Date: Mon, 19 Sep 2022 11:12:33 +0200 Message-Id: <20220919091238.2068052-5-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When initializing the FF-A mediator map the RX and TX buffers shared with the SPMC. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 57 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 90b5aa10a1fa..8cb5c829a394 100644 --- a/xen/arch/arm/ffa.c +++ b/xen/arch/arm/ffa.c @@ -195,6 +195,15 @@ struct ffa_ctx { /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; +/* + * Our rx/tx buffers shared with the SPMC. + * + * ffa_page_count is the number of pages used in each of these buffers. + */ +static void *ffa_rx __read_mostly; +static void *ffa_tx __read_mostly; +static unsigned int ffa_page_count __read_mostly; + static bool ffa_get_version(uint32_t *vers) { const struct arm_smccc_1_2_regs arg = { @@ -264,6 +273,17 @@ static bool __init check_mandatory_feature(uint32_t id) return !ret; } +static int32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, + uint32_t page_count) +{ + uint32_t fid = FFA_RXTX_MAP_32; + + if ( IS_ENABLED(CONFIG_ARM_64) ) + fid = FFA_RXTX_MAP_64; + + return ffa_simple_call(fid, tx_addr, rx_addr, page_count, 0); +} + static u16 get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -447,6 +467,7 @@ int ffa_relinquish_resources(struct domain *d) static int __init ffa_init(void) { uint32_t vers; + int e; unsigned int major_vers; unsigned int minor_vers; @@ -484,11 +505,45 @@ static int __init ffa_init(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); - if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + if ( +#ifdef CONFIG_ARM_64 + !check_mandatory_feature(FFA_RXTX_MAP_64) || +#endif +#ifdef CONFIG_ARM_32 + !check_mandatory_feature(FFA_RXTX_MAP_32) || +#endif + !check_mandatory_feature(FFA_RXTX_UNMAP) || + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + return 0; + + ffa_rx = alloc_xenheap_pages(0, 0); + if ( !ffa_rx ) return 0; + ffa_tx = alloc_xenheap_pages(0, 0); + if ( !ffa_tx ) + goto err_free_ffa_rx; + + e = ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), 1); + if ( e ) + { + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", e); + goto err_free_ffa_tx; + } + ffa_page_count = 1; ffa_version = vers; + return 0; + +err_free_ffa_tx: + free_xenheap_pages(ffa_tx, 0); + ffa_tx = NULL; +err_free_ffa_rx: + free_xenheap_pages(ffa_rx, 0); + ffa_rx = NULL; + ffa_page_count = 0; + ffa_version = 0; + return 0; } -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408579.651380 (Exim 4.92) (envelope-from ) id 1oaCpj-0000Dj-74; Mon, 19 Sep 2022 09:12:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408579.651380; Mon, 19 Sep 2022 09:12:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpj-0000DY-41; Mon, 19 Sep 2022 09:12:55 +0000 Received: by outflank-mailman (input) for mailman id 408579; Mon, 19 Sep 2022 09:12:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCph-0007Fl-2L for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:53 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3099e9cf-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:31 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id j16so18854656lfg.1 for ; Mon, 19 Sep 2022 02:12:52 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3099e9cf-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=fW+HOuAthe2zj2QR4QYWX0sNZcRkvvPLxIfXZPseyvA=; b=nJ992wnIUb+QKl4BkCiXrlnk8R0vYbvYNvYisr0vKT8xg8gmeIcCppwFLN/qypUoyq RvXMJKDNUtQR9UoLVpJL+tN3YK7rktI8CWaVqdUGWeV7mcMB29jGWmd29eDU+sBKpK4a r05IPt/H3w9rVoBFECvg3+hbWXVQtgJNNlUeh+zgKD7jHwOzS4Chqachdbg1vQX0r4mg lCEp8+Ycg9oe7l+nEyUXYJ7h2aJbOP203OHzI8UZ2b2FUfV59a8BBkxKkacj6+wgFxl8 Zw8kHDtlDmFBaEELGRcqRpnkfXPQ0ugYyYSGvOsVx91vkjkno2aFD5HikJcJ8bBFDBfE H0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=fW+HOuAthe2zj2QR4QYWX0sNZcRkvvPLxIfXZPseyvA=; b=5/K41PdTpJWXZ3+F9zhd2dJSLoEBB+WGxEzcyF4dlQonazOJuQRBaeXSUon6k7IrFd 8xnGK8vN2vNREDBBRTol6zkR66stp9wkATzeXqtCb3dPno+cEq8HPNsBXtkUOpavo7lm Qa3KTHkgRGxohkJdd1l2ItlFM8hzbjoYpe/8ayypPAgY2e29kWKTJgn1K5WhGld/lzc3 P6BEYdiHZFvRD7ef017Kkywfvw8SmhVtxc3DNtOoPo3KvOLTEcjFQNfx9J4jJEVa1OsF ExjRp8mzuZYR2hJFll+2yiPtWEuv+sS4vWfLVIbBzKNim5ie9liYAJe4tlg0dzDT2n8e snsA== X-Gm-Message-State: ACrzQf2Nw73Rh//tieDdeJ7wn3K4AqFxSv0KhePF8fyY8bEQkpK0p2pv JPHT8907jO6JBe2wSULK1nG5ysFrSbe/UMAU X-Google-Smtp-Source: AMsMyM6gvPM4SAz1fDLYinKsm/IA6OpO80ZaLT3MBqPMIH4pMJUMn4AN+WvD6ZDUunUi/9CUyrIewQ== X-Received: by 2002:a05:6512:10d3:b0:499:cce2:37a8 with SMTP id k19-20020a05651210d300b00499cce237a8mr5674929lfg.169.1663578771228; Mon, 19 Sep 2022 02:12:51 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 5/9] xen/arm: ffa: send guest events to Secure Partitions Date: Mon, 19 Sep 2022 11:12:34 +0200 Message-Id: <20220919091238.2068052-6-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The FF-A specification defines framework messages sent as direct requests when certain events occurs. For instance when a VM (guest) is created or destroyed. Only SPs which have subscribed to these events will receive them. An SP can subscribe to these messages in its partition properties. The partition properties of each SP is retrieved with FFA_PARTITION_INFO_GET which returns the information in our RX buffer. Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the caller (us), so once we're done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 192 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 191 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 8cb5c829a394..1e94113b20bd 100644 --- a/xen/arch/arm/ffa.c +++ b/xen/arch/arm/ffa.c @@ -187,6 +187,14 @@ #define FFA_MSG_SEND 0x8400006EU #define FFA_MSG_POLL 0x8400006AU +/* Partition information descriptor */ +struct ffa_partition_info_1_1 { + uint16_t id; + uint16_t execution_context; + uint32_t partition_properties; + uint8_t uuid[16]; +}; + struct ffa_ctx { uint32_t guest_vers; bool interrupted; @@ -195,6 +203,12 @@ struct ffa_ctx { /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; +/* SPs subscribing to VM_CREATE and VM_DESTROYED events */ +static uint16_t *subscr_vm_created __read_mostly; +static unsigned int subscr_vm_created_count __read_mostly; +static uint16_t *subscr_vm_destroyed __read_mostly; +static unsigned int subscr_vm_destroyed_count __read_mostly; + /* * Our rx/tx buffers shared with the SPMC. * @@ -284,6 +298,72 @@ static int32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, return ffa_simple_call(fid, tx_addr, rx_addr, page_count, 0); } +static int32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, + uint32_t w4, uint32_t w5, + uint32_t *count) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_PARTITION_INFO_GET, + .a1 = w1, + .a2 = w2, + .a3 = w3, + .a4 = w4, + .a5 = w5, + }; + struct arm_smccc_1_2_regs resp; + uint32_t ret; + + arm_smccc_1_2_smc(&arg, &resp); + + ret = get_ffa_ret_code(&resp); + if ( !ret ) + *count = resp.a2; + + return ret; +} + +static int32_t ffa_rx_release(void) +{ + return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); +} + +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, + uint8_t msg) +{ + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; + int32_t res; + + if ( msg == FFA_MSG_SEND_VM_CREATED ) + exp_resp |= FFA_MSG_RESP_VM_CREATED; + else if ( msg == FFA_MSG_SEND_VM_DESTROYED ) + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; + else + return FFA_RET_INVALID_PARAMETERS; + + do { + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, + .a1 = sp_id, + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, + .a5 = vm_id, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) + { + /* + * This is an invalid response, likely due to some error in the + * implementation of the ABI. + */ + return FFA_RET_INVALID_PARAMETERS; + } + res = resp.a3; + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); + + return res; +} + static u16 get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -431,6 +511,10 @@ uint32_t ffa_get_call_count(void) int ffa_domain_init(struct domain *d, uint32_t flags) { struct ffa_ctx *ctx; + unsigned int n; + unsigned int m; + unsigned int c_pos; + int32_t res; if ( !ffa_version || !(flags & XEN_ARM_FLAGS_FFA) ) return -ENODEV; @@ -439,19 +523,54 @@ int ffa_domain_init(struct domain *d, uint32_t flags) if ( !ctx ) return -ENOMEM; + for ( n = 0; n < subscr_vm_created_count; n++ ) + { + res = ffa_direct_req_send_vm(subscr_vm_created[n], get_vm_id(d), + FFA_MSG_SEND_VM_CREATED); + if ( res ) + { + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %u to %u: res %d\n", + get_vm_id(d), subscr_vm_created[n], res); + c_pos = n; + goto err; + } + } + d->arch.ffa = ctx; return 0; + +err: + /* Undo any already sent vm created messaged */ + for ( n = 0; n < c_pos; n++ ) + for ( m = 0; m < subscr_vm_destroyed_count; m++ ) + if ( subscr_vm_destroyed[m] == subscr_vm_created[n] ) + ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id(d), + FFA_MSG_SEND_VM_DESTROYED); + + return -ENOMEM; } /* This function is supposed to undo what ffa_domain_init() has done */ void ffa_domain_destroy(struct domain *d) { struct ffa_ctx *ctx = d->arch.ffa; + unsigned int n; + int32_t res; if ( !ctx ) return; + for ( n = 0; n < subscr_vm_destroyed_count; n++ ) + { + res = ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id(d), + FFA_MSG_SEND_VM_DESTROYED); + + if ( res ) + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_id %u to %u: res %d\n", + get_vm_id(d), subscr_vm_destroyed[n], res); + } + XFREE(d->arch.ffa); } @@ -464,6 +583,68 @@ int ffa_relinquish_resources(struct domain *d) return 0; } +static bool __init init_subscribers(void) +{ + struct ffa_partition_info_1_1 *fpi; + bool ret = false; + uint32_t count; + int e; + uint32_t n; + uint32_t c_pos; + uint32_t d_pos; + + if ( ffa_version < FFA_VERSION_1_1 ) + return true; + + e = ffa_partition_info_get(0, 0, 0, 0, 0, &count); + if ( e ) + { + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", e); + goto out; + } + + fpi = ffa_rx; + subscr_vm_created_count = 0; + subscr_vm_destroyed_count = 0; + for ( n = 0; n < count; n++ ) + { + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) + subscr_vm_created_count++; + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) + subscr_vm_destroyed_count++; + } + + if ( subscr_vm_created_count ) + subscr_vm_created = xzalloc_array(uint16_t, subscr_vm_created_count); + if ( subscr_vm_destroyed_count ) + subscr_vm_destroyed = xzalloc_array(uint16_t, + subscr_vm_destroyed_count); + if ( (subscr_vm_created_count && !subscr_vm_created) || + (subscr_vm_destroyed_count && !subscr_vm_destroyed) ) + { + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"); + subscr_vm_created_count = 0; + subscr_vm_destroyed_count = 0; + XFREE(subscr_vm_created); + XFREE(subscr_vm_destroyed); + goto out; + } + + for ( c_pos = 0, d_pos = 0, n = 0; n < count; n++ ) + { + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) + subscr_vm_created[c_pos++] = fpi[n].id; + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED ) + subscr_vm_destroyed[d_pos++] = fpi[n].id; + } + + ret = true; +out: + ffa_rx_release(); + + return ret; +} + static int __init ffa_init(void) { uint32_t vers; @@ -505,9 +686,11 @@ static int __init ffa_init(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); - if ( + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || + !check_mandatory_feature(FFA_RX_RELEASE) || #ifdef CONFIG_ARM_64 !check_mandatory_feature(FFA_RXTX_MAP_64) || + !check_mandatory_feature(FFA_MEM_SHARE_64) || #endif #ifdef CONFIG_ARM_32 !check_mandatory_feature(FFA_RXTX_MAP_32) || @@ -533,6 +716,9 @@ static int __init ffa_init(void) ffa_page_count = 1; ffa_version = vers; + if ( !init_subscribers() ) + goto err_free_ffa_tx; + return 0; err_free_ffa_tx: @@ -543,6 +729,10 @@ err_free_ffa_rx: ffa_rx = NULL; ffa_page_count = 0; ffa_version = 0; + XFREE(subscr_vm_created); + subscr_vm_created_count = 0; + XFREE(subscr_vm_destroyed); + subscr_vm_destroyed_count = 0; return 0; } -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408580.651391 (Exim 4.92) (envelope-from ) id 1oaCpk-0000WT-JB; Mon, 19 Sep 2022 09:12:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408580.651391; Mon, 19 Sep 2022 09:12:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpk-0000Va-FU; Mon, 19 Sep 2022 09:12:56 +0000 Received: by outflank-mailman (input) for mailman id 408580; Mon, 19 Sep 2022 09:12:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpi-0007S6-DQ for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:54 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3dff489f-37fb-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 11:12:53 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id f14so44929945lfg.5 for ; Mon, 19 Sep 2022 02:12:53 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dff489f-37fb-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=d/lfQmPa7aVwv3c0xxQhp+oc8I6qS6gZxD1dn3anQyY=; b=BOKWfiyggmTLWBl+TwAnuXcPiTGAnmUlypFRpm20Ks3avTq3GIUt3jXtkumA3qadmn syTSWRuh3WezxtiDzUFx/BbEnP1LvNalmO+Bu5ZdLv5LkCrGJz5yRHev2Ji1DqY+j0dL bYqHTvHOEGcfNmMUhR1srZA9Mw6bkWXE4PklQ2iXfyCsalX/MJefSStFkZXeweuC8J70 PD8ELb5Z5tC3ytBk5OsvcQwt8XnTNiG4v0vqFvO/GkVhP+9rwqebykSxZ1Ua5E8+Kt6Y 4xo8GMJDWj9gnqF94CCgUH9HWs+yYlN6mbT/gOefypu+YxqSXndyncE2qMGcipQdiQkL J74A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=d/lfQmPa7aVwv3c0xxQhp+oc8I6qS6gZxD1dn3anQyY=; b=EheXvRw6NKXIWDL9zGYnOmESvdgdHFFC+k+P0qQ60tqOMkUwJVaApMN4Gn+VtDxGM4 ZBjBuCwARRWpSwmW4WSeMexbJa6J/VBPqpo7PIJjGiV4aBIZOn0bY0SbS2hZys0sI06k jNNvOrmzqtC3VAzRSZv7+J1i+u06klTQUX8MVAU90WLNI4AA3HaBhJCEaaiV4VdlnJMU GZ1vndzcGiF4OASm5TLlpfE1s31SzxCrFLxX08c8cE6oad/gjSEqKj1t1X99nAswq1Kh v5nEwbVfpCTJtvgDoLMDjiuGUGcYDQ80pAG2PkG0rlvhbi0GT7EY2QiPo2UigBHDB95H fezw== X-Gm-Message-State: ACrzQf0CHUAYL2SAu0Ux1Vzq2Q6LiEp/OrNUKZYeDRjtoArW04oRO5KT /iURMvmYh4LQOz0Jf8xEADgje23hi9Al5KKf X-Google-Smtp-Source: AMsMyM6aF0Ag3BpGisebgyaixDUAp747EzlUvzOJAhp3V8Gy2jIps3yZP6qB0MT44RnehoMwoK30VQ== X-Received: by 2002:a05:6512:3d25:b0:49a:d2a0:7208 with SMTP id d37-20020a0565123d2500b0049ad2a07208mr5834398lfv.82.1663578772807; Mon, 19 Sep 2022 02:12:52 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 6/9] xen/arm: ffa: support mapping guest RX/TX buffers Date: Mon, 19 Sep 2022 11:12:35 +0200 Message-Id: <20220919091238.2068052-7-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support in the mediator to map and unmap the RX and TX buffers provided by the guest using the two FF-A functions FFA_RXTX_MAP and FFA_RXTX_UNMAP. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 131 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 129 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 1e94113b20bd..60157a696a9a 100644 --- a/xen/arch/arm/ffa.c +++ b/xen/arch/arm/ffa.c @@ -196,10 +196,17 @@ struct ffa_partition_info_1_1 { }; struct ffa_ctx { + void *rx; + const void *tx; + struct page_info *rx_pg; + struct page_info *tx_pg; + unsigned int page_count; uint32_t guest_vers; + bool tx_is_mine; bool interrupted; }; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -384,6 +391,11 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, set_user_reg(regs, 7, v7); } +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) +{ + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); +} + static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, uint32_t w3) { @@ -405,6 +417,99 @@ static void handle_version(struct cpu_user_regs *regs) set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); } +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, + register_t rx_addr, uint32_t page_count) +{ + uint32_t ret = FFA_RET_INVALID_PARAMETERS; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + struct page_info *tx_pg; + struct page_info *rx_pg; + p2m_type_t t; + void *rx; + void *tx; + + if ( !smccc_is_conv_64(fid) ) + { + tx_addr &= UINT32_MAX; + rx_addr &= UINT32_MAX; + } + + /* For now to keep things simple, only deal with a single page */ + if ( page_count != 1 ) + return FFA_RET_NOT_SUPPORTED; + + /* Already mapped */ + if ( ctx->rx ) + return FFA_RET_DENIED; + + tx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(tx_addr)), &t, P2M_ALLOC); + if ( !tx_pg ) + return FFA_RET_INVALID_PARAMETERS; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + goto err_put_tx_pg; + + rx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(rx_addr)), &t, P2M_ALLOC); + if ( !tx_pg ) + goto err_put_tx_pg; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + goto err_put_rx_pg; + + tx = __map_domain_page_global(tx_pg); + if ( !tx ) + goto err_put_rx_pg; + + rx = __map_domain_page_global(rx_pg); + if ( !rx ) + goto err_unmap_tx; + + ctx->rx = rx; + ctx->tx = tx; + ctx->rx_pg = rx_pg; + ctx->tx_pg = tx_pg; + ctx->page_count = 1; + ctx->tx_is_mine = true; + return FFA_RET_OK; + +err_unmap_tx: + unmap_domain_page_global(tx); +err_put_rx_pg: + put_page(rx_pg); +err_put_tx_pg: + put_page(tx_pg); + + return ret; +} + +static void rxtx_unmap(struct ffa_ctx *ctx) +{ + unmap_domain_page_global(ctx->rx); + unmap_domain_page_global(ctx->tx); + put_page(ctx->rx_pg); + put_page(ctx->tx_pg); + ctx->rx = NULL; + ctx->tx = NULL; + ctx->rx_pg = NULL; + ctx->tx_pg = NULL; + ctx->page_count = 0; + ctx->tx_is_mine = false; +} + +static uint32_t handle_rxtx_unmap(void) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + + if ( !ctx->rx ) + return FFA_RET_INVALID_PARAMETERS; + + rxtx_unmap(ctx); + + return FFA_RET_OK; +} + static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) { struct arm_smccc_1_2_regs arg = { .a0 = fid, }; @@ -469,6 +574,7 @@ bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) { struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.ffa; + int e; if ( !ctx ) return false; @@ -481,6 +587,24 @@ bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) case FFA_ID_GET: set_regs_success(regs, get_vm_id(d), 0); return true; + case FFA_RXTX_MAP_32: +#ifdef CONFIG_ARM_64 + case FFA_RXTX_MAP_64: +#endif + e = handle_rxtx_map(fid, get_user_reg(regs, 1), get_user_reg(regs, 2), + get_user_reg(regs, 3)); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; + case FFA_RXTX_UNMAP: + e = handle_rxtx_unmap(); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; case FFA_MSG_SEND_DIRECT_REQ_32: #ifdef CONFIG_ARM_64 case FFA_MSG_SEND_DIRECT_REQ_64: @@ -501,8 +625,8 @@ uint32_t ffa_get_call_count(void) if ( IS_ENABLED(CONFIG_FFA) ) { if ( IS_ENABLED(CONFIG_ARM_64) ) - count += 1; - count += 3; + count += 2; + count += 5; } return count; @@ -571,6 +695,9 @@ void ffa_domain_destroy(struct domain *d) get_vm_id(d), subscr_vm_destroyed[n], res); } + if ( ctx->rx ) + rxtx_unmap(ctx); + XFREE(d->arch.ffa); } -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408581.651397 (Exim 4.92) (envelope-from ) id 1oaCpl-0000eQ-Bd; Mon, 19 Sep 2022 09:12:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408581.651397; Mon, 19 Sep 2022 09:12:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpl-0000cr-2M; Mon, 19 Sep 2022 09:12:57 +0000 Received: by outflank-mailman (input) for mailman id 408581; Mon, 19 Sep 2022 09:12:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpk-0007Fl-30 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:56 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 328d5be7-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:34 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id j16so18854851lfg.1 for ; Mon, 19 Sep 2022 02:12:55 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 328d5be7-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ozCWnQmrg0Y3cJZGj3Z//D5S620Z/IqhK5L1rRo8nAE=; b=X4/bq3DoaHxjNDXlvc3iXQ+3x3NjlCcGKZYOcvynCCBNWijhtm24MBXgEVY+x3QL3i qKaYzPw3gpgzOgwStSiof9GXtS9w9/kVfgNUWG3ci/GyCQAnHNu4YqL/SCTt5OVIwMcc 7XBTCc+TEcmujF/M0ki4AkzXwc2kuXiEuSwIFXRovIVbdhoA3OfOdloaT8t9aXLKLyu/ oS/JNoIZ8T6thPR7XLDegacR16hUaBa/grMm3pOYMzI2boMH0Wqgj/kbh6V0ioCZTcLD vhEkd3j0tFXB4httpoveybKYCoihx4xUtYQxyra/pFttbG7c5uWa7nPuzbtFOA6ea4c1 YqQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ozCWnQmrg0Y3cJZGj3Z//D5S620Z/IqhK5L1rRo8nAE=; b=Odt71vnvzQ2UFuxVNRP7kJyofMXxU56NVf9hnhUHDaj2W0kOctgFsip286ZEe+QnNP 3WCxooDAvpyGXZ7CFe6/Kwf3hJ+XvFr7bfmtMWepx+lwlYMi1nCiixQZwyvxaCz+OIed H8hNI7PfFr75GCOPsvCHcCVSHWilyNUOG/wfrI1gHWI4maMeVtZW76/Z+BZPnXMrDVMQ EDOXc3N8S0QdRXjY3Ev1laeurrNbTJWvj9fe7K4tKAYNwwnN/cwhlM3glEsp+4tdp5ze Pg+/nk3Om+tSzVm94FNf00VHkXkucVf8DiOIoba6nFJkFVhhvG0Ln8d1BfzWDYcoaBy4 jHMA== X-Gm-Message-State: ACrzQf1fVR1U6zWguRYTf8HgYaJCzaxZl8NahjicI3d75jla1DwJi57o 28twtabAY9bhmNT+Edo+OhvPQ/AHqbjv4A== X-Google-Smtp-Source: AMsMyM4WSNM7W60/EtoyRXwIQxLceTQyLfWq1J5YhJe5HiF1n++s9SWE7xlBe+CSc4iDOdebbCzCGQ== X-Received: by 2002:ac2:5d25:0:b0:497:a280:9825 with SMTP id i5-20020ac25d25000000b00497a2809825mr5683821lfb.409.1663578774592; Mon, 19 Sep 2022 02:12:54 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 7/9] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET Date: Mon, 19 Sep 2022 11:12:36 +0200 Message-Id: <20220919091238.2068052-8-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests from a guest. The requests are forwarded to the SPMC and the response is translated according to the FF-A version in use by the guest. Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the caller (the guest in this case), so once it is done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 126 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 60157a696a9a..4c88da9d6d3b 100644 --- a/xen/arch/arm/ffa.c +++ b/xen/arch/arm/ffa.c @@ -188,6 +188,12 @@ #define FFA_MSG_POLL 0x8400006AU /* Partition information descriptor */ +struct ffa_partition_info_1_0 { + uint16_t id; + uint16_t execution_context; + uint32_t partition_properties; +}; + struct ffa_partition_info_1_1 { uint16_t id; uint16_t execution_context; @@ -204,9 +210,8 @@ struct ffa_ctx { uint32_t guest_vers; bool tx_is_mine; bool interrupted; + spinlock_t lock; }; - - /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -220,10 +225,16 @@ static unsigned int subscr_vm_destroyed_count __read_mostly; * Our rx/tx buffers shared with the SPMC. * * ffa_page_count is the number of pages used in each of these buffers. + * + * The RX buffer is protected from concurrent usage with ffa_rx_buffer_lock. + * Note that the SPMC is also tracking the ownership of our RX buffer so + * for calls which uses our RX buffer to deliver a result we must call + * ffa_rx_release() to let the SPMC know that we're done with the buffer. */ static void *ffa_rx __read_mostly; static void *ffa_tx __read_mostly; static unsigned int ffa_page_count __read_mostly; +static DEFINE_SPINLOCK(ffa_rx_buffer_lock); static bool ffa_get_version(uint32_t *vers) { @@ -510,6 +521,98 @@ static uint32_t handle_rxtx_unmap(void) return FFA_RET_OK; } +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, + uint32_t w4, uint32_t w5, + uint32_t *count) +{ + bool query_count_only = w5 & FFA_PARTITION_INFO_GET_COUNT_FLAG; + uint32_t w5_mask = 0; + uint32_t ret = FFA_RET_DENIED; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + + /* + * FF-A v1.0 has w5 MBZ while v1.1 allows + * FFA_PARTITION_INFO_GET_COUNT_FLAG to be non-zero. + */ + if ( ctx->guest_vers == FFA_VERSION_1_1 ) + w5_mask = FFA_PARTITION_INFO_GET_COUNT_FLAG; + if ( w5 & ~w5_mask ) + return FFA_RET_INVALID_PARAMETERS; + + if ( query_count_only ) + return ffa_partition_info_get(w1, w2, w3, w4, w5, count); + + if ( !ffa_page_count ) + return FFA_RET_DENIED; + + spin_lock(&ctx->lock); + spin_lock(&ffa_rx_buffer_lock); + if ( !ctx->page_count || !ctx->tx_is_mine ) + goto out; + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); + if ( ret ) + goto out; + + if ( ctx->guest_vers == FFA_VERSION_1_0 ) + { + size_t n; + struct ffa_partition_info_1_1 *src = ffa_rx; + struct ffa_partition_info_1_0 *dst = ctx->rx; + + if ( ctx->page_count * FFA_PAGE_SIZE < *count * sizeof(*dst) ) + { + ret = FFA_RET_NO_MEMORY; + goto out_rx_release; + } + + for ( n = 0; n < *count; n++ ) + { + dst[n].id = src[n].id; + dst[n].execution_context = src[n].execution_context; + dst[n].partition_properties = src[n].partition_properties; + } + } + else + { + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); + + if ( ctx->page_count * FFA_PAGE_SIZE < sz ) + { + ret = FFA_RET_NO_MEMORY; + goto out_rx_release; + } + + + memcpy(ctx->rx, ffa_rx, sz); + } + ctx->tx_is_mine = false; +out_rx_release: + ffa_rx_release(); +out: + spin_unlock(&ffa_rx_buffer_lock); + spin_unlock(&ctx->lock); + + return ret; +} + +static uint32_t handle_rx_release(void) +{ + uint32_t ret = FFA_RET_DENIED; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + + spin_lock(&ctx->lock); + if ( !ctx->page_count || ctx->tx_is_mine ) + goto out; + ret = FFA_RET_OK; + ctx->tx_is_mine = true; +out: + spin_unlock(&ctx->lock); + + return ret; +} + static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) { struct arm_smccc_1_2_regs arg = { .a0 = fid, }; @@ -574,6 +677,7 @@ bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) { struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.ffa; + uint32_t count; int e; if ( !ctx ) @@ -605,6 +709,24 @@ bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) else set_regs_success(regs, 0, 0); return true; + case FFA_PARTITION_INFO_GET: + e = handle_partition_info_get(get_user_reg(regs, 1), + get_user_reg(regs, 2), + get_user_reg(regs, 3), + get_user_reg(regs, 4), + get_user_reg(regs, 5), &count); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, count, 0); + return true; + case FFA_RX_RELEASE: + e = handle_rx_release(); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; case FFA_MSG_SEND_DIRECT_REQ_32: #ifdef CONFIG_ARM_64 case FFA_MSG_SEND_DIRECT_REQ_64: -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:12:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:12:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408582.651411 (Exim 4.92) (envelope-from ) id 1oaCpm-00012F-R1; Mon, 19 Sep 2022 09:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408582.651411; Mon, 19 Sep 2022 09:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpm-00010h-J4; Mon, 19 Sep 2022 09:12:58 +0000 Received: by outflank-mailman (input) for mailman id 408582; Mon, 19 Sep 2022 09:12:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpl-0007Fl-AH for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:12:57 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33473681-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:35 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id y14so2632639ljn.7 for ; Mon, 19 Sep 2022 02:12:56 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33473681-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=MVzlwh9ZWd5r9tSvwBW+tgS5BQq9td5KtU8nL+38bko=; b=kdNv91pcvqhyO1pdo68gLMXnqms2yVDgV4Uk3jzf6bJd9lmapkd6rxGCusajFPTUbr XCtEuF5zjv6aDT1JApxnXcfSCqR9U4p9eWLXbYKYskybt44htZQrSRIazXxcvAAzkqk4 RBC0zYTd+5gS0jsXaOkQzGZ9d2tPoevk2xjPJ+3Z6LgIUyWQvxa9ldCdxG1Mh5F1P0kR n2lJtl3adv0Q8+7aiynX6b34lpU5Xj4A4NOAVMjvcVvhU+e6J1KDicoME/bP8kP7e45/ swe9ydS+ON5sYHwPDT2hDGoXHNvpXEtHMpk/HaqIF6EKECb+Xq9M646MfdqXz+uMrRp+ FsjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=MVzlwh9ZWd5r9tSvwBW+tgS5BQq9td5KtU8nL+38bko=; b=j6Dbf/jBwRpibTYg0vdsde9woKNkbyWr1Ab8wyDyAAap5HinSjCoLKBqpRho7IpbcG WjdXhWo+wnIiK1lVZjAAISr0Leq3lnEkzCmsGQLeQr/EVrs0HS37ooqwqoyW05jmj9G3 kYQYino7j4Jgdn3aB4lXbV+oIznpaG3aNnbepfAD4DgxNum8zvf6bYdAYR9pOM4ht751 1z/y0BCORbUYHZtimnex2KAKTEdeMlBpG8Ef6SeUdROzoi38oMWauf3Jsmos/81wabNi ueDAYPQMTni5VUHsivH3z6Ke7T9Ea+pnRghA0Qd5trXw2H3WoD3p6PuD0IY+kkrwrwJw sB8g== X-Gm-Message-State: ACrzQf0e8qlMDdXvQpXO7eaFLRAFFdZx9kwNYfm+oFlPq9nMsn1H18VM nL736V5Ux0tp6lFP1GiPk1UQhLYfjKAfYVUe X-Google-Smtp-Source: AMsMyM4kUE+fIr13DjUJsuyY1YVO4KHee+mVnrgYsumRL9/jGqomHHpREwMRjN3WqVrGQOfxV9q20w== X-Received: by 2002:a05:651c:1141:b0:261:6ea9:ac97 with SMTP id h1-20020a05651c114100b002616ea9ac97mr5043579ljo.434.1663578775902; Mon, 19 Sep 2022 02:12:55 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander , Michal Orzel Subject: [PATCH v6 8/9] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h Date: Mon, 19 Sep 2022 11:12:37 +0200 Message-Id: <20220919091238.2068052-9-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Moves the two helper functions regpair_to_uint64() and uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm specific regs.h. This enables reuse of these functions in the FF-A mediator in a subsequent patch. Reviewed-by: Michal Orzel Signed-off-by: Jens Wiklander --- xen/arch/arm/include/asm/regs.h | 12 ++++++++++++ xen/arch/arm/tee/optee.c | 11 ----------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/include/asm/regs.h b/xen/arch/arm/include/asm/regs.h index 0693a681315f..aa39e83ee5f4 100644 --- a/xen/arch/arm/include/asm/regs.h +++ b/xen/arch/arm/include/asm/regs.h @@ -60,6 +60,18 @@ static inline bool guest_mode(const struct cpu_user_regs *r) register_t get_user_reg(struct cpu_user_regs *regs, int reg); void set_user_reg(struct cpu_user_regs *regs, int reg, register_t val); +static inline uint64_t regpair_to_uint64(register_t reg0, register_t reg1) +{ + return ((uint64_t)reg0 << 32) | (uint32_t)reg1; +} + +static inline void uint64_to_regpair(register_t *reg0, register_t *reg1, + uint64_t val) +{ + *reg0 = val >> 32; + *reg1 = (uint32_t)val; +} + #endif #endif /* __ARM_REGS_H__ */ diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 9cb9f16d43cb..47027ecef47c 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -268,17 +268,6 @@ static int optee_domain_init(struct domain *d) return 0; } -static uint64_t regpair_to_uint64(register_t reg0, register_t reg1) -{ - return ((uint64_t)reg0 << 32) | (uint32_t)reg1; -} - -static void uint64_to_regpair(register_t *reg0, register_t *reg1, uint64_t val) -{ - *reg0 = val >> 32; - *reg1 = (uint32_t)val; -} - static struct page_info *get_domain_ram_page(gfn_t gfn) { struct page_info *page; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408583.651424 (Exim 4.92) (envelope-from ) id 1oaCpq-0001dk-BD; Mon, 19 Sep 2022 09:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408583.651424; Mon, 19 Sep 2022 09:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpq-0001d5-2F; Mon, 19 Sep 2022 09:13:02 +0000 Received: by outflank-mailman (input) for mailman id 408583; Mon, 19 Sep 2022 09:13:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCpo-0007Fl-G6 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:13:00 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 345a216a-37fb-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:12:37 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id x27so12658355lfu.0 for ; Mon, 19 Sep 2022 02:12:58 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id f3-20020a05651c02c300b0025fdf1af42asm4815394ljo.78.2022.09.19.02.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:12:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 345a216a-37fb-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ujN4gLjELhxsneoZje9PAv8Lul+Pc5HXRqkkybR+SbU=; b=HAIoGs15DCKQd8EaR+Gam1JBnj9MrPAiU0ISKqTf8QmZAwViTP73X1F3lsV/J8b5Yg udwCuCwwSbnXO/UmYTVnEv55U8flkm2N2mTi0dhyhtKjxia05ztXaRI88UqHBNFjjXUo VhI3ZHFj8T5TFskO75tyt4qPcmIU2/EdV1eXK6wjl8RmwugrRG2oFn8O/kPRL4bGaMQO DBhX4HS6zhwHG49IX8lE2zY+CwNrB5DBG8Empg1iigXPWqWxf6Nt8QxRzz1O2GU67w/2 vgAuUnwzC3Bu4a2QBC1Km/rYue6JBp7PMFUjW2lUqaoKHH82fDiAnJ0zSlQdC2r9NZQG d9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ujN4gLjELhxsneoZje9PAv8Lul+Pc5HXRqkkybR+SbU=; b=Mb9UALAuG2A87q+stOu9oqCZPhmaj8t5M3TE1SrrUXmtYweVL+hGFKQvAXXsNAOBDC bYmt9rJKaF+MrgXjH3ExStBd6KNUQlbf3CKsCBQJal+d01T/jQRZWunW7UDUX66/oDh7 yUHwTre0A+46TJBii6AKZQq6Ulx4YP4zBoZOSS3hO6jR7y6av4Y8XFBxqavupRKuNvDb WV4m66NIAawFG6Bf9EZscLrHhOXZVMooL31m4zHYwiLM3MuLMZnQmsJppbEXcr/+NJZS oXVlTC3oe/jeGs/pgcVRU1LO5L3AQK82/DC6Ukyihc4sndlrauvG24z35kiYYTrtOVdP 5w6w== X-Gm-Message-State: ACrzQf0mai+61vJP3sVH4D9oXT3oToFlRb7FvzxILVSRNCEILXPsg466 f+EOcZ09QPkY5g6edyvrUIDJfPq8LyodsQ== X-Google-Smtp-Source: AMsMyM72dyiV/QrzVvC5ahbeWabet6T5JApmPHjNN9JyYrv9UovYtbNVBBLVQkkOx6Uj4trihX9acQ== X-Received: by 2002:ac2:4c50:0:b0:49a:3768:da81 with SMTP id o16-20020ac24c50000000b0049a3768da81mr5444260lfk.247.1663578777362; Mon, 19 Sep 2022 02:12:57 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu , Marc Bonnici , Achin Gupta , Jens Wiklander Subject: [PATCH v6 9/9] xen/arm: ffa: support sharing memory Date: Mon, 19 Sep 2022 11:12:38 +0200 Message-Id: <20220919091238.2068052-10-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org> References: <20220919091238.2068052-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for a guest to share memory with an SP using FFA_MEM_SHARE, FFA_MEM_RECLAIM and FFA_MEM_FRAG_TX. Small memory regions can be shared using FFA_MEM_SHARE, but larger memory regions may need to be transmitted in fragments with FFA_MEM_FRAG_TX. A memory region that doesn't need to be shared any longer can be reclaimed with FFA_MEM_RECLAIM once the SP doesn't use it any longer. This is checked by the SPMC and not in control of the mediator. With this commit we have a FF-A version 1.1 [1] mediator able to communicate with a Secure Partition in secure world. The secure world must use FF-A version 1.1, but the guest is free to use version 1.0 or version 1.1. The implementation is the bare minimum to be able to communicate with OP-TEE running as an SPMC at S-EL1. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 842 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 840 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 4c88da9d6d3b..c4a77307a18f 100644 --- a/xen/arch/arm/ffa.c +++ b/xen/arch/arm/ffa.c @@ -201,6 +201,107 @@ struct ffa_partition_info_1_1 { uint8_t uuid[16]; }; +/* Constituent memory region descriptor */ +struct ffa_address_range { + uint64_t address; + uint32_t page_count; + uint32_t reserved; +}; + +/* Composite memory region descriptor */ +struct ffa_mem_region { + uint32_t total_page_count; + uint32_t address_range_count; + uint64_t reserved; + struct ffa_address_range address_range_array[]; +}; + +/* Memory access permissions descriptor */ +struct ffa_mem_access_perm { + uint16_t endpoint_id; + uint8_t perm; + uint8_t flags; +}; + +/* Endpoint memory access descriptor */ +struct ffa_mem_access { + struct ffa_mem_access_perm access_perm; + uint32_t region_offs; + uint64_t reserved; +}; + +/* Lend, donate or share memory transaction descriptor */ +struct ffa_mem_transaction_1_0 { + uint16_t sender_id; + uint8_t mem_reg_attr; + uint8_t reserved0; + uint32_t flags; + uint64_t global_handle; + uint64_t tag; + uint32_t reserved1; + uint32_t mem_access_count; + struct ffa_mem_access mem_access_array[]; +}; + +struct ffa_mem_transaction_1_1 { + uint16_t sender_id; + uint16_t mem_reg_attr; + uint32_t flags; + uint64_t global_handle; + uint64_t tag; + uint32_t mem_access_size; + uint32_t mem_access_count; + uint32_t mem_access_offs; + uint8_t reserved[12]; +}; + +/* Calculate offset of struct ffa_mem_access from start of buffer */ +#define MEM_ACCESS_OFFSET(access_idx) \ + ( sizeof(struct ffa_mem_transaction_1_1) + \ + ( access_idx ) * sizeof(struct ffa_mem_access) ) + +/* Calculate offset of struct ffa_mem_region from start of buffer */ +#define REGION_OFFSET(access_count, region_idx) \ + ( MEM_ACCESS_OFFSET(access_count) + \ + ( region_idx ) * sizeof(struct ffa_mem_region) ) + +/* Calculate offset of struct ffa_address_range from start of buffer */ +#define ADDR_RANGE_OFFSET(access_count, region_count, range_idx) \ + ( REGION_OFFSET(access_count, region_count) + \ + ( range_idx ) * sizeof(struct ffa_address_range) ) + +/* + * The parts needed from struct ffa_mem_transaction_1_0 or struct + * ffa_mem_transaction_1_1, used to provide an abstraction of difference in + * data structures between version 1.0 and 1.1. This is just an internal + * interface and can be changed without changing any ABI. + */ +struct ffa_mem_transaction_x { + uint16_t sender_id; + uint8_t mem_reg_attr; + uint8_t flags; + uint8_t mem_access_size; + uint8_t mem_access_count; + uint16_t mem_access_offs; + uint64_t global_handle; + uint64_t tag; +}; + +/* Endpoint RX/TX descriptor */ +struct ffa_endpoint_rxtx_descriptor_1_0 { + uint16_t sender_id; + uint16_t reserved; + uint32_t rx_range_count; + uint32_t tx_range_count; +}; + +struct ffa_endpoint_rxtx_descriptor_1_1 { + uint16_t sender_id; + uint16_t reserved; + uint32_t rx_region_offs; + uint32_t tx_region_offs; +}; + struct ffa_ctx { void *rx; const void *tx; @@ -210,8 +311,33 @@ struct ffa_ctx { uint32_t guest_vers; bool tx_is_mine; bool interrupted; + struct list_head frag_list; + struct list_head shm_list; + unsigned int shm_count; spinlock_t lock; }; + +struct ffa_shm_mem { + struct list_head list; + uint16_t sender_id; + uint16_t ep_id; /* endpoint, the one lending */ + uint64_t handle; /* FFA_HANDLE_INVALID if not set yet */ + unsigned int page_count; + struct page_info *pages[]; +}; + +struct mem_frag_state { + struct list_head list; + struct ffa_shm_mem *shm; + uint32_t range_count; + unsigned int current_page_idx; + unsigned int frag_offset; + unsigned int range_offset; + const uint8_t *buf; + unsigned int buf_size; + struct ffa_address_range range; +}; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -226,6 +352,8 @@ static unsigned int subscr_vm_destroyed_count __read_mostly; * * ffa_page_count is the number of pages used in each of these buffers. * + * The TX buffer is protected from concurrent usage with ffa_tx_buffer_lock. + * * The RX buffer is protected from concurrent usage with ffa_rx_buffer_lock. * Note that the SPMC is also tracking the ownership of our RX buffer so * for calls which uses our RX buffer to deliver a result we must call @@ -235,6 +363,7 @@ static void *ffa_rx __read_mostly; static void *ffa_tx __read_mostly; static unsigned int ffa_page_count __read_mostly; static DEFINE_SPINLOCK(ffa_rx_buffer_lock); +static DEFINE_SPINLOCK(ffa_tx_buffer_lock); static bool ffa_get_version(uint32_t *vers) { @@ -345,6 +474,78 @@ static int32_t ffa_rx_release(void) return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); } +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, + register_t addr, uint32_t pg_count, + uint64_t *handle) +{ + struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MEM_SHARE_32, + .a1 = tot_len, + .a2 = frag_len, + .a3 = addr, + .a4 = pg_count, + }; + struct arm_smccc_1_2_regs resp; + + if ( IS_ENABLED(CONFIG_ARM_64) ) + arg.a0 = FFA_MEM_SHARE_64; + + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_ERROR: + if ( resp.a2 ) + return resp.a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + *handle = regpair_to_uint64(resp.a3, resp.a2); + return FFA_RET_OK; + case FFA_MEM_FRAG_RX: + *handle = regpair_to_uint64(resp.a2, resp.a1); + return resp.a3; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, + uint16_t sender_id) +{ + struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MEM_FRAG_TX, + .a1 = handle & UINT32_MAX, + .a2 = handle >> 32, + .a3 = frag_len, + .a4 = (uint32_t)sender_id << 16, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_ERROR: + if ( resp.a2 ) + return resp.a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + return FFA_RET_OK; + case FFA_MEM_FRAG_RX: + return resp.a3; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + +static int32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, + uint32_t flags) +{ + return ffa_simple_call(FFA_MEM_RECLAIM, handle_lo, handle_hi, flags, 0); +} + static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, uint8_t msg) { @@ -413,6 +614,14 @@ static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); } +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, + uint32_t handle_hi, uint32_t frag_offset, + uint16_t sender_id) +{ + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, + (uint32_t)sender_id << 16, 0, 0, 0); +} + static void handle_version(struct cpu_user_regs *regs) { struct domain *d = current->domain; @@ -673,6 +882,611 @@ out: resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); } +/* + * Gets all page and assigns them to the supplied shared memory object. If + * this function fails then the caller is still expected to call + * put_shm_pages() as a cleanup. + */ +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, + const struct ffa_address_range *range, + uint32_t range_count, unsigned int start_page_idx, + unsigned int *last_page_idx) +{ + unsigned int pg_idx = start_page_idx; + gfn_t gfn; + unsigned int n; + unsigned int m; + p2m_type_t t; + uint64_t addr; + + for ( n = 0; n < range_count; n++ ) + { + for ( m = 0; m < range[n].page_count; m++ ) + { + if ( pg_idx >= shm->page_count ) + return FFA_RET_INVALID_PARAMETERS; + + addr = read_atomic(&range[n].address); + gfn = gaddr_to_gfn(addr + m * FFA_PAGE_SIZE); + shm->pages[pg_idx] = get_page_from_gfn(d, gfn_x(gfn), &t, + P2M_ALLOC); + if ( !shm->pages[pg_idx] ) + return FFA_RET_DENIED; + pg_idx++; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + return FFA_RET_DENIED; + } + } + + *last_page_idx = pg_idx; + + return FFA_RET_OK; +} + +static void put_shm_pages(struct ffa_shm_mem *shm) +{ + unsigned int n; + + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) + { + put_page(shm->pages[n]); + shm->pages[n] = NULL; + } +} + +static struct ffa_shm_mem *alloc_ffa_shm_mem(struct ffa_ctx *ctx, + unsigned int page_count) +{ + struct ffa_shm_mem *shm; + + if ( page_count >= FFA_MAX_SHM_PAGE_COUNT || + ctx->shm_count >= FFA_MAX_SHM_COUNT ) + return NULL; + + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); + if ( shm ) + { + ctx->shm_count++; + shm->page_count = page_count; + } + + return shm; +} + +static void free_ffa_shm_mem(struct ffa_ctx *ctx, struct ffa_shm_mem *shm) +{ + if ( shm ) { + ASSERT(ctx->shm_count > 0); + ctx->shm_count--; + put_shm_pages(shm); + xfree(shm); + } +} + +static void init_range(struct ffa_address_range *addr_range, + paddr_t pa) +{ + memset(addr_range, 0, sizeof(*addr_range)); + addr_range->address = pa; + addr_range->page_count = 1; +} + +/* + * This function uses the ffa_tx buffer to transmit the memory transaction + * descriptor. The function depends ffa_tx_buffer_lock to be used to guard + * the buffer from concurent use. + */ +static int share_shm(struct ffa_shm_mem *shm) +{ + const uint32_t max_frag_len = ffa_page_count * FFA_PAGE_SIZE; + struct ffa_mem_access *mem_access_array; + struct ffa_mem_transaction_1_1 *descr; + struct ffa_address_range *addr_range; + struct ffa_mem_region *region_descr; + const unsigned int region_count = 1; + void *buf = ffa_tx; + uint32_t frag_len; + uint32_t tot_len; + paddr_t last_pa; + unsigned int n; + paddr_t pa; + bool first; + int ret; + + ASSERT(spin_is_locked(&ffa_tx_buffer_lock)); + if ( !shm->page_count ) + { + ASSERT_UNREACHABLE(); + return FFA_RET_INVALID_PARAMETERS; + } + + descr = buf; + memset(descr, 0, sizeof(*descr)); + descr->sender_id = shm->sender_id; + descr->global_handle = shm->handle; + descr->mem_reg_attr = FFA_NORMAL_MEM_REG_ATTR; + descr->mem_access_count = 1; + descr->mem_access_size = sizeof(*mem_access_array); + descr->mem_access_offs = MEM_ACCESS_OFFSET(0); + + mem_access_array = buf + descr->mem_access_offs; + memset(mem_access_array, 0, sizeof(*mem_access_array)); + mem_access_array[0].access_perm.endpoint_id = shm->ep_id; + mem_access_array[0].access_perm.perm = FFA_MEM_ACC_RW; + mem_access_array[0].region_offs = REGION_OFFSET(descr->mem_access_count, 0); + + region_descr = buf + mem_access_array[0].region_offs; + memset(region_descr, 0, sizeof(*region_descr)); + region_descr->total_page_count = shm->page_count; + + region_descr->address_range_count = 1; + last_pa = page_to_maddr(shm->pages[0]); + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) + { + pa = page_to_maddr(shm->pages[n]); + if ( last_pa + FFA_PAGE_SIZE == pa ) + continue; + region_descr->address_range_count++; + } + + tot_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, + region_descr->address_range_count); + + /* + * Sharing memory with secure world may have to be done with multiple + * calls depending on how many address ranges will be needed. If we're + * sharing physically contiguous memory we will only need one range but + * we will also need to deal with the worst case where all physical + * pages are non-contiguous. For the first batch of address ranges we + * call ffa_mem_share() and for all that follows ffa_mem_frag_tx(). + * + * We use frag_len to keep track of how far into the transmit buffer we + * have gone. + */ + addr_range = region_descr->address_range_array; + frag_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, 1); + last_pa = page_to_maddr(shm->pages[0]); + init_range(addr_range, last_pa); + first = true; + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) + { + pa = page_to_maddr(shm->pages[n]); + if ( last_pa + FFA_PAGE_SIZE == pa ) + { + addr_range->page_count++; + continue; + } + + if ( frag_len == max_frag_len ) + { + if ( first ) + { + ret = ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + first = false; + } + else + { + ret = ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); + } + if ( ret <= 0 ) + return ret; + frag_len = sizeof(*addr_range); + addr_range = buf; + } + else + { + frag_len += sizeof(*addr_range); + addr_range++; + } + init_range(addr_range, pa); + } + + if ( first ) + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + else + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); +} + +static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, + struct ffa_mem_transaction_x *trans) +{ + uint16_t mem_reg_attr; + uint32_t flags; + uint32_t count; + uint32_t offs; + uint32_t size; + + if ( ffa_vers >= FFA_VERSION_1_1 ) + { + const struct ffa_mem_transaction_1_1 *descr; + + if ( blen < sizeof(*descr) ) + return FFA_RET_INVALID_PARAMETERS; + + descr = buf; + trans->sender_id = descr->sender_id; + mem_reg_attr = descr->mem_reg_attr; + flags = descr->flags; + trans->global_handle = descr->global_handle; + trans->tag = descr->tag; + + count = descr->mem_access_count; + size = descr->mem_access_size; + offs = descr->mem_access_offs; + } + else + { + const struct ffa_mem_transaction_1_0 *descr; + + if ( blen < sizeof(*descr) ) + return FFA_RET_INVALID_PARAMETERS; + + descr = buf; + trans->sender_id = descr->sender_id; + mem_reg_attr = descr->mem_reg_attr; + flags = descr->flags; + trans->global_handle = descr->global_handle; + trans->tag = descr->tag; + + count = descr->mem_access_count; + size = sizeof(struct ffa_mem_access); + offs = offsetof(struct ffa_mem_transaction_1_0, mem_access_array); + } + /* + * Make sure that "descr" which is shared with the guest isn't accessed + * again after this point. + */ + barrier(); + + /* + * We're doing a rough check to see that no information is lost when + * tranfering the values into a struct ffa_mem_transaction_x below. The + * fields in struct ffa_mem_transaction_x are wide enough to hold any + * valid value so being out of range means that something is wrong. + */ + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_MAX || + count > UINT8_MAX || offs > UINT16_MAX ) + return FFA_RET_INVALID_PARAMETERS; + + /* Check that the endpoint memory access descriptor array fits */ + if ( size * count + offs > blen ) + return FFA_RET_INVALID_PARAMETERS; + + trans->mem_reg_attr = mem_reg_attr; + trans->flags = flags; + trans->mem_access_size = size; + trans->mem_access_count = count; + trans->mem_access_offs = offs; + + return 0; +} + +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int offs, + unsigned int frag_len) +{ + struct domain *d = current->domain; + unsigned int o = offs; + unsigned int l; + int ret; + + if ( frag_len < o ) + return FFA_RET_INVALID_PARAMETERS; + + /* Fill up the first struct ffa_address_range */ + l = min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_offset); + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); + s->range_offset += l; + o += l; + if ( s->range_offset != sizeof(s->range) ) + goto out; + s->range_offset = 0; + + while ( true ) + { + ret = get_shm_pages(d, s->shm, &s->range, 1, s->current_page_idx, + &s->current_page_idx); + if ( ret ) + return ret; + if ( s->range_count == 1 ) + return 0; + s->range_count--; + if ( frag_len - o < sizeof(s->range) ) + break; + memcpy(&s->range, s->buf + o, sizeof(s->range)); + o += sizeof(s->range); + } + + /* Collect any remaining bytes for the next struct ffa_address_range */ + s->range_offset = frag_len - o; + memcpy(&s->range, s->buf + o, frag_len - o); +out: + s->frag_offset += frag_len; + + return s->frag_offset; +} + +static void handle_mem_share(struct cpu_user_regs *regs) +{ + static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; + uint32_t tot_len = get_user_reg(regs, 1); + uint32_t frag_len = get_user_reg(regs, 2); + uint64_t addr = get_user_reg(regs, 3); + uint32_t page_count = get_user_reg(regs, 4); + const struct ffa_mem_region *region_descr; + const struct ffa_mem_access *mem_access; + struct ffa_mem_transaction_x trans; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + struct ffa_shm_mem *shm = NULL; + unsigned int last_page_idx = 0; + register_t handle_hi = 0; + register_t handle_lo = 0; + int ret = FFA_RET_DENIED; + uint32_t range_count; + uint32_t region_offs; + + /* + * We're only accepting memory transaction descriptors via the rx/tx + * buffer. + */ + if ( addr ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + /* Check that fragment length doesn't exceed total length */ + if ( frag_len > tot_len ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_unlock; + } + + spin_lock(&ctx->lock); + + if ( frag_len > ctx->page_count * FFA_PAGE_SIZE ) + goto out_unlock; + + if ( !ffa_page_count ) + { + ret = FFA_RET_NO_MEMORY; + goto out_unlock; + } + + ret = read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &trans); + if ( ret ) + goto out_unlock; + + if ( trans.mem_reg_attr != FFA_NORMAL_MEM_REG_ATTR ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out; + } + + /* Only supports sharing it with one SP for now */ + if ( trans.mem_access_count != 1 ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + if ( trans.sender_id != get_vm_id(d) ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_unlock; + } + + /* Check that it fits in the supplied data */ + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) + goto out_unlock; + + mem_access = ctx->tx + trans.mem_access_offs; + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + region_offs = read_atomic(&mem_access->region_offs); + if ( sizeof(*region_descr) + region_offs > frag_len ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + region_descr = ctx->tx + region_offs; + range_count = read_atomic(®ion_descr->address_range_count); + page_count = read_atomic(®ion_descr->total_page_count); + + shm = alloc_ffa_shm_mem(ctx, page_count); + if ( !shm ) + { + ret = FFA_RET_NO_MEMORY; + goto out; + } + shm->sender_id = trans.sender_id; + shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); + + if ( frag_len != tot_len ) + { + struct mem_frag_state *s = xzalloc(struct mem_frag_state); + + if ( !s ) + { + ret = FFA_RET_NO_MEMORY; + goto out; + } + s->shm = shm; + s->range_count = range_count; + s->buf = ctx->tx; + s->buf_size = ffa_page_count * FFA_PAGE_SIZE; + ret = add_mem_share_frag(s, sizeof(*region_descr) + region_offs, + frag_len); + if ( ret <= 0 ) + { + xfree(s); + if ( ret < 0 ) + goto out; + } + else + { + shm->handle = next_handle++; + uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); + list_add_tail(&s->list, &ctx->frag_list); + } + goto out_unlock; + } + + /* + * Check that the Composite memory region descriptor fits. + */ + if ( sizeof(*region_descr) + region_offs + + range_count * sizeof(struct ffa_address_range) > frag_len ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, + 0, &last_page_idx); + if ( ret ) + goto out; + if ( last_page_idx != shm->page_count ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + /* Note that share_shm() uses our tx buffer */ + spin_lock(&ffa_tx_buffer_lock); + ret = share_shm(shm); + spin_unlock(&ffa_tx_buffer_lock); + if ( ret ) + goto out; + + list_add_tail(&shm->list, &ctx->shm_list); + + uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); + +out: + if ( ret ) + free_ffa_shm_mem(ctx, shm); +out_unlock: + spin_unlock(&ctx->lock); + + if ( ret > 0 ) + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.sender_id); + else if ( ret == 0) + set_regs_success(regs, handle_lo, handle_hi); + else + set_regs_error(regs, ret); +} + +static struct mem_frag_state *find_frag_state(struct ffa_ctx *ctx, + uint64_t handle) +{ + struct mem_frag_state *s; + + list_for_each_entry(s, &ctx->frag_list, list) + if ( s->shm->handle == handle ) + return s; + + return NULL; +} + +static void handle_mem_frag_tx(struct cpu_user_regs *regs) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + uint32_t frag_len = get_user_reg(regs, 3); + uint32_t handle_lo = get_user_reg(regs, 1); + uint32_t handle_hi = get_user_reg(regs, 2); + uint64_t handle = regpair_to_uint64(handle_hi, handle_lo); + struct mem_frag_state *s; + uint16_t sender_id = 0; + int ret; + + spin_lock(&ctx->lock); + s = find_frag_state(ctx, handle); + if ( !s ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + sender_id = s->shm->sender_id; + + if ( frag_len > s->buf_size ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + ret = add_mem_share_frag(s, 0, frag_len); + if ( ret == 0 ) + { + /* Note that share_shm() uses our tx buffer */ + spin_lock(&ffa_tx_buffer_lock); + ret = share_shm(s->shm); + spin_unlock(&ffa_tx_buffer_lock); + if ( ret == 0 ) + list_add_tail(&s->shm->list, &ctx->shm_list); + else + free_ffa_shm_mem(ctx, s->shm); + } + else if ( ret < 0 ) + free_ffa_shm_mem(ctx, s->shm); + list_del(&s->list); + xfree(s); +out: + spin_unlock(&ctx->lock); + + if ( ret > 0 ) + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id); + else if ( ret == 0) + set_regs_success(regs, handle_lo, handle_hi); + else + set_regs_error(regs, ret); +} + +static int handle_mem_reclaim(uint64_t handle, uint32_t flags) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.ffa; + struct ffa_shm_mem *shm; + register_t handle_hi; + register_t handle_lo; + int ret; + + spin_lock(&ctx->lock); + list_for_each_entry(shm, &ctx->shm_list, list) + { + if ( shm->handle == handle ) + goto found_it; + } + shm = NULL; + ret = FFA_RET_INVALID_PARAMETERS; + goto out; +found_it: + + uint64_to_regpair(&handle_hi, &handle_lo, handle); + ret = ffa_mem_reclaim(handle_lo, handle_hi, flags); + if ( ret ) + { + shm = NULL; + goto out; + } + + list_del(&shm->list); + +out: + free_ffa_shm_mem(ctx, shm); + spin_unlock(&ctx->lock); + + + return ret; +} + bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) { struct domain *d = current->domain; @@ -733,6 +1547,24 @@ bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) #endif handle_msg_send_direct_req(regs, fid); return true; + case FFA_MEM_SHARE_32: +#ifdef CONFIG_ARM_64 + case FFA_MEM_SHARE_64: +#endif + handle_mem_share(regs); + return true; + case FFA_MEM_RECLAIM: + e = handle_mem_reclaim(regpair_to_uint64(get_user_reg(regs, 2), + get_user_reg(regs, 1)), + get_user_reg(regs, 3)); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; + case FFA_MEM_FRAG_TX: + handle_mem_frag_tx(regs); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -747,8 +1579,8 @@ uint32_t ffa_get_call_count(void) if ( IS_ENABLED(CONFIG_FFA) ) { if ( IS_ENABLED(CONFIG_ARM_64) ) - count += 2; - count += 5; + count += 3; + count += 9; } return count; @@ -782,6 +1614,9 @@ int ffa_domain_init(struct domain *d, uint32_t flags) } } + INIT_LIST_HEAD(&ctx->frag_list); + INIT_LIST_HEAD(&ctx->shm_list); + d->arch.ffa = ctx; return 0; @@ -945,6 +1780,9 @@ static int __init ffa_init(void) !check_mandatory_feature(FFA_RXTX_MAP_32) || #endif !check_mandatory_feature(FFA_RXTX_UNMAP) || + !check_mandatory_feature(FFA_MEM_SHARE_32) || + !check_mandatory_feature(FFA_MEM_FRAG_TX) || + !check_mandatory_feature(FFA_MEM_RECLAIM) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return 0; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:21:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:21:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408638.651435 (Exim 4.92) (envelope-from ) id 1oaCyI-0005ia-Kj; Mon, 19 Sep 2022 09:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408638.651435; Mon, 19 Sep 2022 09:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCyI-0005iT-HB; Mon, 19 Sep 2022 09:21:46 +0000 Received: by outflank-mailman (input) for mailman id 408638; Mon, 19 Sep 2022 09:21:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaCyH-0005iN-70 for xen-devel@lists.xen.org; Mon, 19 Sep 2022 09:21:45 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b1e1a5a-37fc-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:21:21 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Sep 2022 05:21:38 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN8PR03MB5026.namprd03.prod.outlook.com (2603:10b6:408:d6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 09:21:36 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5632.019; Mon, 19 Sep 2022 09:21:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b1e1a5a-37fc-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663579302; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=nOfZ0mqT6i7TQfX6dS2wrKgyBQ8HnRVJZc3Xq4Y0RSw=; b=GPsFDRobtOUDHo7YiUSMAmBnajfnj8O7vVVCjJccG6hn3lkbLGTRBKPH L6AsArDRrZyQSUhWOTpkWYhVhja9qgFaKVjiubCXXvuCFVMIlCwnaP7u0 tgb/Kwlt69OD6w8kLnOYbSiunmXqDXIV6sw1leDP6dE0+Rgo67esZ8OM0 o=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 81237308 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:H5edo6s9Drh6z//DscLuVCLjVefnVFZfMUV32f8akzHdYApBsoF/q tZmKWzQOPjbajGmfox1aonnpE1VvJ/Tn9ZgHQZpqCEwHnsU+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4WJA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FZME+cNxEGRAz vkVNQ03QkDEory6zL3uH4GAhux7RCXqFKU2nyg5iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QLT/PRni4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWPfqS333r+ncSXTZ5wyD5+R/6dR22bN7UsMAzFLUVKAiKzs4qK5c5cFQ 6AOwQI1v6Ut/1esSPHyWhS5pDiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzgHb8Yp3PLaXhQv3 16N2tnvVTpmteTMTWrHr+nE6zSvJSISMGkOIzceShcI6MXip4d1iQ/TStFkE+i+idid9SzM/ g1mZRMW39075fPnHY3ilbwbq1pAfqT0czM= IronPort-HdrOrdr: A9a23:J/8hgqv+SlZ2ukkgyRSxklTB7skCk4Mji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH PQ3LsxmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZWbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYcz1gBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxemUPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesbMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlOx1GkeKp ggMCjg3ocZTbvDBEqp/1WHgebcFUjbJy32DnTr4aeuonhrdHMQ9Tpq+CVQpAZCyHsHceg02w 31CNUWqFhwdL5pUUtcPpZ1fSLlMB24fTv8dESvHH/AKIYrf1rwlr+f2sRE2AjtQu1B8KcP X-IronPort-AV: E=Sophos;i="5.93,327,1654574400"; d="scan'208";a="81237308" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PMRNa9hSY54MJl6GGF3rRmoImZQEz/teoHzO9K+WyLDmsfKXWEopO+V72gpFuSxiAFSnSYQnif79Qp0yQtFAJGgglPIDQEA4dhYJTrL8UveCsfEGkVT5gTTkKGjZ2UG6DKfl2oDs0BOv+9ZyJOc2Fb5Sa6t3XpShkkHiw+9ER9W9JTBWvSGSyuOV0hbA1nVrY4nq2xef/PEcI8Qv1yJGgfoevFhgbbuP9+QCGlbDac9yve9oRM7y3DsmPnECvWDybPAmtpp+EraLV+eRcURUz6OqZZNsxx+XA0kWzPc9BYwnYzVZ+KZnZSIMtKHrdqH5swKMYY2Ndsoom+D410Gz6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LBk+G0ZMMyPoNS41TcAh9VbeoonGdwsm0J/JBubJNKU=; b=WKUmtty69ycVz0pJgUAYnXMz6odM5eufDwYfGZXm9h9aHucqwKe78XqUK9aZ+gQ2/joFjw9fTk2ZsdmzAXtijgR8E4YGEb1QjKgynGngRA/QtE37HzaK2bWQfpALQ+evLfQcJ8CKfVTkM8oMUyA4Xm2J3pV7c1+mbdQ6u9c8Ee7vj6Czpl4n6P76p+Jdxlj521v8JVeNknOyoLfJRSy2FNTnEhfWNOJ3tVt3RHl/Ncv80YX9oVD2UBIDRAdmZSPW/HGyUXmE7SLOE650XELIO0lAamHDeZW8TUwT9GXPoUsbEc1f+WU7p4N/k5EElW7JSrCt2N0oy7tkv7zqKYAlsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LBk+G0ZMMyPoNS41TcAh9VbeoonGdwsm0J/JBubJNKU=; b=UPnZhWsBQOvjmb0UGSnhINEtwatqcotkQmH1YIOw38tSLtYfUxlq4fD6yZ+VDnPOYL7PN5K84EyOGkuLeCqEjygKYOWjZJJiOLRhjbyktI0RMAAhR3QVodckmtAQUekNI7yHR4WeTsGDXRjJ7mqkLbMnBuuGYTj5N6LY1jk2IGc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 19 Sep 2022 11:21:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Adam Szewczyk Cc: xen-devel@lists.xen.org Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN8PR03MB5026:EE_ X-MS-Office365-Filtering-Correlation-Id: 78a81f57-e7be-4277-ef30-08da9a20593e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X5TrOMseFOm8ZAEtyeGe9PlEIlVMTkK5j7NKSRBx5HWqQgH300uT95oO6+tGZkoFHCcuA6qBx3B5vdEa2AMnsMO7fAqMFcyWcwGp/AbvPoAET+yuDW4abdGEqL4EGuJ1Ym5TMjLmXF68hpPI5EbfD4etAy7lj3jo7C1y61Psn6chXJrCv9RB+lV54pHkKoQjmiw4Nj1gkqwd6de9pbfxBc8hLblOzyb8X/0u+p/IQDmej/LXItcoR5/8OCd4ZEF9gsoYiz42XSjbOCuT6zxU282FbRT7//9nldlIM4Aam/yUFHhxUCNuOkaes1f+omGhEU7sW/rWeFv7PYCti6/R8XOpEwAEzKqEgNt/ARmnxLOL+ay3IrvCB1t7UCJQPnNLYkcs05cXOFEsvDcL1hs1IgO5JG0ArLPrsE2ZDrsPlSs3Nxx6gkqjfXVPJTjY+mjknlY6hw7R809SbmYEfHepN9xIGwToWUkGjKyxoyFrPDBwmqIcHavlbAaJ1V53kqiXg5f9rhRwyTl+CQ3dr2n3UzTEy2+Bq4oF1z8Skpu3Qf8HWeru0aRU+SUYcpRcgyDPdgjuUS7VRuinnsLko/9jdu73d0bzhKbmOSqU0CywewYLCz417pSHnuTvRkTv2PQWjOjr9K71QxPB/xB2lAALuCMz7fVLvZFcAsjCt5yqCSV9VsEL7BpJ2xciI8m83denEKSxd0FQHKG2d9zeVy3EFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(376002)(346002)(396003)(136003)(366004)(451199015)(85182001)(2906002)(316002)(82960400001)(38100700002)(66556008)(8676002)(5660300002)(4326008)(66476007)(66946007)(8936002)(6916009)(86362001)(186003)(478600001)(9686003)(6512007)(26005)(83380400001)(6506007)(6486002)(6666004)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlNuYU9FWnhlQ2wzRVhTL2RZNDRkSkhuZTVJY28yWGxPNnZ4VjNDalFiSTdH?= =?utf-8?B?Ni9CYzdzWDB6UTlBOUNCcUFuSWJXU3JGTDRsOCtQam9yWnZHcVNVTDZwZGEy?= =?utf-8?B?WEYxWTFRaHhKUkt1amx6eTIvU1d6NGlMdXFENzlJSm5QN2NyNzh2emsvb3cx?= =?utf-8?B?QjIvWXFGVVRBc2Z4czArVncwZHMwaFNPQ0FZcVdIK3krUUFDVXRvd1RrYUtK?= =?utf-8?B?U0VxSklmTVJSS3htYU00a1B2a3pQOUlaN2JaMHRFN09HMVdlSk12QkNsSkpB?= =?utf-8?B?MW5FNUNML2tUckpUMkcrYzBDVFFrQjQ0V2gzcWE5cDM3Yk9VM0lxWk95cDhJ?= =?utf-8?B?MDVqMm5zbmVCalkwSmlpaGp4OVZOdjVERG80TW9qMUxBNjRFTkVHb0VpS2VI?= =?utf-8?B?K1JvVjBOaG12OURJaTIwekkzUjE2TThVN1NWdmY5UDVUTXlnb0ljNzhhNWZ5?= =?utf-8?B?QW9SamtLVDY0UFlTSHdjTnlPai9NSWVsU1djZ3hlNDc1MHdSdThUc1R2Nmxj?= =?utf-8?B?VkVCMUtnbFZPZHp5QTJQN3hiVXdwVGo4THRtTGw3SFMvTDJlYkYrY1BwenJN?= =?utf-8?B?WHpWdm4rRU1UVExKNU9ycGlFUFZscEduREQxbW1iMTRHK2lKSUkyTU8wQjI3?= =?utf-8?B?QWlrS2ZISmhXSTNWY1VrK3VzTnlPL1kxL2U5TkxPbG82cGZIQXcrbHY0emhQ?= =?utf-8?B?K0tyN3BCWng5S0djd1F4RjlpbzAyeUFVekRTbDI3S2VIL0RSd3VEUWtWdXBn?= =?utf-8?B?bVdLQ3BmTEdsTlJDQm8zNG5Pb3liN050ZDR6SEdNdWZENG4zOVZrODMyQVRO?= =?utf-8?B?Wm5EczBKK0tMcG8xVGxadklLOWlYWUpkeVBMaVFUSHMxL3JBWEVWbVBTY2Zy?= =?utf-8?B?YlpZSml3YjlxbFJRVkRNUDZWR21SMFkxVU9BOE45bVNFV0RKZDN2UmRid1B3?= =?utf-8?B?U0haR0NvNDNpN282MEVXeFBUUUo1NEUyWVdpclNXRFpxRGZJSDRnUFp1T0Y5?= =?utf-8?B?TmdhOCtqVTYrOXM1bUc3R25WeXNMbWQzKzRpQnZpdkZXZEVJdmlmQ2kxMkdD?= =?utf-8?B?OUtpOXhRdmU2elJjMFRHTkJxZ0owNEJ1YnAxNjNHeDBjT0Irak5oVFVXaEJ6?= =?utf-8?B?dW1NNlVDSUdEUmxFWDNEUDFGQVk4UHJOM241c2dNTTdjS1FpWWNHdVo0OFZT?= =?utf-8?B?MElNMGFLWStSTloxQW9VTkl5eEFnTGJtTFViNEU0V1Vzc1VxdFRaMzFsYzNH?= =?utf-8?B?ZXY0ZXBvZk92Ky9NQW13cWFKSTY5N3N1RHdvOEZSb1B2MFBGVUlXUUZjZWdk?= =?utf-8?B?bmd4UUhtdjNKZ3lzdGVpc3FjZ0hLWWFSV2xEL3k1Y3BsR1NlVzBrcHJXaFJt?= =?utf-8?B?WXYzY2hHM0dJN2tDblN0cXZwMXllRFg4UEhWSmRLQXJKVVdCMUlXVGZpVkJK?= =?utf-8?B?ZENzNXRrRFU0TFdNQkZGZWxvcUdNZ0ozK0FPQ25DMVdESmtsMFd5cTIvSXN6?= =?utf-8?B?bGZyRFJWTVJRbzA5VmN0NGtEUkkyMTh6UTJ5WHBTV1ZnZVBDdW5QVEFmRk9X?= =?utf-8?B?SGlCdVVWYVZKWElwVTZwcGZLUFg2bDJzUGc2bXBwOVZqN2kzclV1Q1M3b2pq?= =?utf-8?B?c1ZidmR5emhiaExmcVVKWk13OTdzT1h5OERvYmtDWHJURnFQK2E1NXUvcFcy?= =?utf-8?B?cC9lTGhhVzZpcFhpZnY5NDdFVjhPd1BkYUFlTms0ZmhvQmErdkZUeTBVZklW?= =?utf-8?B?TmdjTDNqc0gwQTF4d1NBVkJYS1owWkcvSjZIR3lhMTlxQ1VlVmdwakNPc3hK?= =?utf-8?B?QWh5ejlGbUd4Z1hoVUZwZmgzaEpSRXZ5SGNpanFNam9oTWEzYS8vU0FESFpl?= =?utf-8?B?SWJFL2gwVU5QU3kzRGpCTklKekZtMzQxbWpMMGZjUzZYd1FUUjBhSStOZitG?= =?utf-8?B?QkNyUlpqaWgydEpRS3BYTGphaFNvS3dsaExFQVdkc1hkdjd4b1JXUG5aZFFU?= =?utf-8?B?T0NVWU83c3NQTHJ5bEdrSkYzdlUyZU9id0VXazhiREhzcm1YMmRRMXVUanlk?= =?utf-8?B?TFhuZDZnNGV1S3Q4TjlJUytscXNTN2dEOEhKM2FRUG5ZVXRaN016dW1GYktX?= =?utf-8?Q?NuHyu7eh9JbxiMRI/1rFgM9JU?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78a81f57-e7be-4277-ef30-08da9a20593e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 09:21:36.5955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rD9/kO3RIcusTJfpjDKgYoymnqtK3tq6qUPbqNQNVZ2cbar71AYQfnSh5TqbjOt0OdQgGuOeRcu+rv90/sCiuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5026 On Fri, Sep 16, 2022 at 05:08:59PM +0200, Adam Szewczyk wrote: > Sorry, I always forgot that default answer is "answer" to not "answer to > all". > > My xl dmesg after calling those debug-keys is: Trimming the trace: > (XEN) MSI information: > (XEN) MSI 125 vec=72 lowest edge assert log lowest dest=00000100 > mask=0/ /? > (XEN) MSI 138 vec=62 lowest edge assert log lowest dest=00000001 > mask=0/ /? > (XEN) MSI 139 vec=6a lowest edge assert log lowest dest=00000010 > mask=0/ /? > (XEN) IRQ information: > (XEN) IRQ: 125 vec:72 PCI-MSI status=030 aff:{8}/{0-11} > in-flight=0 d94:151(-M-) > (XEN) IRQ: 138 vec:62 PCI-MSI status=030 aff:{0}/{0-11} > in-flight=0 d92:151(---) > (XEN) IRQ: 139 vec:6a PCI-MSI status=010 aff:{4}/{0-11} > in-flight=0 d92:150(---) Was domain with ID 94 your OpenBSD box? There's another domain with passthrough devices (ID 92). If your OpenBSD domain is the one with ID 94 it seems like the interrupt source is masked, so no interrupts will be injected to the guest. That however might be just the response from the guest after seeing that the interrupt source is not behaving correctly. Are yuo using a debug hypervisor? If not it would be helpful to do so, in order to maybe get more information on `xl dmesg`. Can you also paste the QEMU log for the OpeNSD domain? Those logs are in /var/log/xen/qemu-dm-.log, on most distros, not sure if QubesOS puts them at the same place. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:23:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:23:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408644.651446 (Exim 4.92) (envelope-from ) id 1oaD0N-0006Hl-W6; Mon, 19 Sep 2022 09:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408644.651446; Mon, 19 Sep 2022 09:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaD0N-0006He-TN; Mon, 19 Sep 2022 09:23:55 +0000 Received: by outflank-mailman (input) for mailman id 408644; Mon, 19 Sep 2022 09:23:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaD0N-0006HY-4Z for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:23:55 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2055.outbound.protection.outlook.com [40.107.105.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb000294-37fc-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:23:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8565.eurprd04.prod.outlook.com (2603:10a6:10:2d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 09:23:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 09:23:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb000294-37fc-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwn5EcgWsBEtFnf67jswXuIhlkdjiVycgB5sLhbU3heXF/3pLG9JVKmNycsnnDs4m3/hC9IBk/d2Y2M2doCj7Z6KV1wAuiIcrgotTsGWhvPXIIUlOz/MX2wpB903FZUupOOrPNqMCeRddUuZNARq/+LR1sgYzzD0TOmg629Rmllw7a2NxOTaKlCLgVovm1TmpFR6Pf7GHMqdT6Luupnd3X71HkZOMLLgVQo/WMJqRgSpAbM0/X2OkOUrCjB3Qau6sLWWrXCiwyFVMy+QrX+jqVKPu3qO9ak5VCVpzAsy1cZJQLc92CNBnbyqyAOV9IC9jij9AoByr3ZTEbpDC6rbnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1bD0OXo/TMREN6xJbQBro6A2OazDB4aHvq19+U1c86w=; b=ahbVZanoXfXI7ziXXAI4M22W/dgxqjrfyzEXGENdnws1UVdzAOVtVj0hUtFSXpBzVJhof008XjLye5wmG4i91zUjDG/RNquJg2K8ucfvu4JHoNXoxBX35JN4TkfMDYBVDmP0nUBFe0My8IJE6zSxuRatwHJzdkAF+RJ/i1fnS45V/oLk+XGVGAQWgCUzswrOf2M4P6AEk8SBdPW/ea7V8yQZpuVbTGdcWiHMCdMo4E4QOi4YNbThhGQjt/zJyonRF+3aZRd7h+5dwpu0DfTpukbxtUSA/b/f4aix7FseFA0VMlfja9a5D+AV2ounwA0dJaVxJR//an68ab8ORgfyRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1bD0OXo/TMREN6xJbQBro6A2OazDB4aHvq19+U1c86w=; b=sB+ULnElKiVQkKdq73dPV0BIHYKetZF3CkfsQJeqJ1z1yw8oTotD6TaGhGma0UzLfaU/bbb9bDAkDymAIfWfxcfpjL251wXgB1bkXimGm61x0JAAAk58MsZM3k1xvB2O7yNqj673HPQhI7o55wCXq+5/Hr4GZaA9md4L9Nu8y8d35IxcWAmAVo/OXrwBLLB/dRtheEFODdr06zxNdvP79r6HQEC08fzz8oIHLyIqUQtjs7DXVXDnLeRBA5Sfm8XznT6cIVG46KzKPNNCzgeRF0Y9/9m5+toOksT6u/mE+u4ZHIBq4GiyPLRqGylrZ/AnT1cD5WQFlw/OX836ceKDrg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 19 Sep 2022 11:23:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Roberto Bagnara Cc: Bertrand Marquis , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Wei Liu , burzalodowa@gmail.com, Stefano Stabellini References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0684.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8565:EE_ X-MS-Office365-Filtering-Correlation-Id: e027d501-50cb-412a-783c-08da9a20aae9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K/2iJTC1sDpZwoaxYxfoNdfqVj1hpcaSv9LiTA1mh+6TDAkXcXqTI4ZbH6Ah+VkNV0+RaC737OM2P0yB5PUpi8FSwSPfsjxfOMBmPAcqM6nywjPljBUWPrcVx7bcX+Bwx0d46M9h/59TDH22ps8enbgUB44pWMrwvM3umGt4YQViNpnPASRUL5HDm0ZVylOldlKFU9Zoryer/rZ/ofWdQ0jK4sFklXZtfs0dRuKZ2hPmvcL+f60i2bo5caL4jFJ0PxACp5JFqvyoMgmYtLiLeoxPMcb5BPsNyPOtMAFHKOJ7L2u3Sc8CXUid9CXGYZlMd9UMFNzc8YJx/G2weEGrzXVHvdQ0Rn3yrXPpn9hvpV2dPijL6ak0UCxIV72Q9QfC8XIw0hR85iiz30tW1DViUKptSWOVFz4sLPB/DbQvZ5jVuIXTSJTLdMMbi3UtYlKA28mF4qcx429Tvt4ZtOh4XsB7KvS2IIrb/zKsuJ32+Pndgrlshncxx4Ex/NRuYd942K8Y+LGtrHIQTTe/owBQytIT+/z14lROBrnOcMh/zGqpSoOuuFX2e8S62zj7H3ULV9aFF9paMhbLkYLyw2PZH23s81kDDK/z3piTLUXXh1OnkyX8yYfIE4D3W6aSDuijqlwg4BzsL475kXOTdpsZkt5DV8YGBkE9biWZZlz3U6E75nX7fNrxcOiONvRxgq7WOnzBCUSfdkRXjdn6ffEvGfP/vyZILLPga+wyDenCit43Dq4fKglixLHWZhdbohtg9AWSSFF0klksOve8qL8217Ktp0EVh8Rbq24dEF6Jt6E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(366004)(136003)(396003)(451199015)(2906002)(31686004)(36756003)(316002)(38100700002)(66556008)(8676002)(5660300002)(4326008)(7416002)(66476007)(66946007)(8936002)(31696002)(54906003)(6916009)(86362001)(186003)(478600001)(2616005)(6512007)(26005)(83380400001)(6506007)(6486002)(53546011)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0hCT1Foc2ZuMkVGdFQ5NDNsWi9KYjJ1RVBydk1Vc0syRVdWcUQyRlJoWlZ6?= =?utf-8?B?NE4yNDRFWFJXT1N0SGRRc0UwWnRWQlp3c3NKWTdVNHY1bDQySTMyTC9pVTRI?= =?utf-8?B?eXdaa1FuSDIwY1lqMnZ0bUd6cVJaZTNNc2dTTFZXNWpUVStpcVJHOEk0dVpy?= =?utf-8?B?VWpIWHRUZ3lpYW9pRnE4eE1QWW1xczRURWpZaHFjSDl5enZFRnJ3a3VJQU9J?= =?utf-8?B?VUtMdzJyUElWYUtZaUVwTmVOT080Z1VGRXhqU09qMFdLWi9wdG5vZHVWL0Qy?= =?utf-8?B?T1ptUFpUWHVFVS8zVGV4UVZtUm9XN2pVWVdXUTlEOW0zVEdYODVoaWhuS3Fo?= =?utf-8?B?LzNRdkJOU2UxcWk0VFkwLzdFWEsvaHEvNmZiWmplTFdCY0xyLzhUL3dCQnl4?= =?utf-8?B?Nm13bmV4Nm5tam9WRWVjWWVIVHhoNDJBaUtMNWwxTS9oTUlBajBNdWl0Z3hX?= =?utf-8?B?ZDVKWWg0dnZ4SWZjZndaNFBjMXB2NGR0WU5FUVQwV1VTUkR3ME5sUWVIZHhD?= =?utf-8?B?WEh6TTJpck1VTWY4WVV6clpoaXNRY3RkT1FBelJkV0tEdEhRZEJFeFMvbWcz?= =?utf-8?B?Q043R0hqLzI5cDhueE53V1JoUkN1NGxrOGJKb29qK0luajZlVjFOWXdEVlMx?= =?utf-8?B?bW5jUGJVdmxkSjFNMit3STg5MW81Q09GUWVZS3JxRGFlQ21vOUdiQ2xwVGtl?= =?utf-8?B?QjA5RytWZHlGRjlNc3l6dExsYUlRdkR1VmFBRUVnY2t4ZERsZVA1bzBQdHk4?= =?utf-8?B?dElZN3hmcUZGaG9GT3B6NnRxNGRqMWxabVJoenk2d1FkV2NqRXFaTlJPZEVS?= =?utf-8?B?NHFTbXpldjZZZ1RrSi9Cd0hMY0JVRndlcVlSWWx2dkNQVW9xK0RzZURTd3Z3?= =?utf-8?B?WUxjVWNITHpJVE9zYzZVMVZJeWhDZ1lVTEF5a2RWQ0tIeHlHNU1WRkF0Szl0?= =?utf-8?B?Wk9LL0EyTElIdkVlK3BFaWxjKzJNYjdIdk9oWmdteTdJc29VNW0zTFVOU0pu?= =?utf-8?B?WkFndkJtcnNDbDhyZ1RlcjFJYXgxajlWbHdXK2ZJQnpYekRGNzBhekRPMUxh?= =?utf-8?B?RFJaK3M2NEtDd3d1ckJneGhFTkpyUUtXMDhwc24rdzhDYXk3cXI1d2FMa1lw?= =?utf-8?B?QUR2by9aaVB4L2FkcjQ4L3h6TUlSc2VvZzNaNGhQazZkV2wwZXJJa096MGhq?= =?utf-8?B?YVN6WXlYL0RSMFc1Sk0xRTNXZEsvMjdjckk5c01YL2tvVVp5ZWhjMlRpRUpF?= =?utf-8?B?NWU2R1V2MmZxYkV5b1BZeW1NejljYkx4S0dlSzcrYVpPemNuOHdpZ3pyNXpC?= =?utf-8?B?UUZoVHBzNTUzL3Q1aDRSRGZEYThDamZjdnc0UDMwZlozdGhsZWtLVWs2cjl4?= =?utf-8?B?QU9LOFd5aThxZlBKb2hlazB5anB3bk1BdW1qMCtpaUV2N2t3SnFoYmpVNUkw?= =?utf-8?B?a3UydVEzWGprYWZpSlpmTnhOMnBZNGptT1Q5eXpuUEd3bWJnOWVPMlFEVmgv?= =?utf-8?B?VjAzUWt0SFFESFlzc3Nib1doUkxib1BMQXQwdDRiK1pIS2tyaVg0SWhFZjZS?= =?utf-8?B?Wkw1NHpDWTF2UUpnZ3RrejN2ZW9BSk9JV0JZNVZqMnRRWFVuWUlXbGN4Yng5?= =?utf-8?B?OW9GcEFxWmx2bE1UUXBvQTFkRjY0VkFkVnd4OEQ1Rm4zL1ppcVJFTTRMRk5m?= =?utf-8?B?M1ZvTDh1YWpWejhmQklDczErM0hGVVo3Vk9SbXFSd3ZjN1luZlQvOWVhY3Z3?= =?utf-8?B?aFMya0paV0xPbm1EcFpheTdmYkFPR25GYm5hWWs4Y0hKSERmZHozbGhySVB6?= =?utf-8?B?NVBpNG5LSlA2OUtpS0NCZGdWYTk2TlFkMEttVFA2NzBtdURBTDVjbmR4MXdn?= =?utf-8?B?RnBVZzlpRVI3d1RGeUJaZ0VPQUhHWVNaRFlTa2diQTQwa3NjODEzdWp4WU8w?= =?utf-8?B?d24zQ1VmYnJzaUVXWjU2dEN4eWlJMzhBVjNkbStkbHZVSkFhUlR2UFYwUWlS?= =?utf-8?B?RWtRZlN3UnE1cUkxTGYxbGRRZC9UQ3d4aDJiSVJ5ekZZRkdnS0FBU1Y2bkkz?= =?utf-8?B?KzBTb3lUOHZDb2gvcGM4eDVrSWtVaHo4YkU3U1BzN1NqU0JFVWlhTWdLVzM5?= =?utf-8?Q?+9TDehPj8oOa3xFGGSQXZsDzT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e027d501-50cb-412a-783c-08da9a20aae9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 09:23:52.4498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Oe5LKkXHn8GNTblVGGBMZaByxXtfaq0s4sxmcDhFNm/1HVT2ftRcDZgwbbrsYMWQQWXElUSoySaVDuD/Y64fA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8565 On 18.09.2022 15:02, Roberto Bagnara wrote: > On 03/09/22 02:52, Stefano Stabellini wrote: >> The question is on the interpretation of Rule 20.7. Are parenthesis >> required by Rule 20.7 in the following cases: >> >> - macro parameters used as function arguments > > [...] > > - macro parameter used as lhs in assignment > > You can obtain different semantics depending on whether parentheses > are or are not used (in the macro call and/or macro expansion > depending on the case): > > > #include > > void g(int v) { > printf("%d\n", v); > } > > #define m1(x, y, ...) g(y) > > void f1(int x, int y, ...) { > g(y); > } > > #define p 0, 1 > > void test1() { > m1(p, 2); > f1(p, 2); > } > > #define m4(x) x = 4 > > void f4(int &x) { Let's focus on C here. > x = 4; > } > > > void test4() { > int y; > int z; > z = 3; > m4(y = z); > printf("%d\n", z); > z = 3; > f4(y = z); > printf("%d\n", z); > } > > int main() { > test1(); > test4(); > } > >> - macro parameters used as macro arguments > > Please note that Rule 20.7 depends on the final expansion: > so whether parentheses are or are not used in a certain > macro body is irrelevant, the point being that, at the > end of all expansions, expressions resulting from the > expansion of macro parameters are enclosed in parentheses. > >> - macro parameter used as array index > > This is safe today, but my understanding is that in C++23 > the [] operator will accept more than one expression. > A similar change might (who knows?) be considered for C26 > or even offered before (intentionally or by mistake) by some > C compiler. > >> Some of these cases are interesting because they should function >> correctly even without parenthesis, hence the discussion. In particular >> parenthesis don't seem necessary at least for the function argument >> case. > > This is not the right spirit for MISRA compliance: why would you want > splitting hairs when inserting a pair of parentheses is so easy? I think I've said so before - too many parentheses harm readability. > C and C++ are very complex languages, and the MISRA coding standards > are the result of a (very difficult!) compromise between simplicity > and effectiveness: rules that are exactly targeted to all and only all > the problematic instances would be very difficult to express and to remember. > So, yes: in many cases you might spend time to demonstrate that a particular > (real) MISRA violation does not imply the existence of a real issue, > but this time is not well spent. Critical code must be boring and obviously > right, in the sense that whomever is reading the code should not be > distracted by thoughts like "there are no parentheses here: am I sure > nothing bad can happen?" I also did indicate before that "(x) = ..." visually (but not syntactically) can raise the question of whether the left side actually is an lvalue. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:27:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:27:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408651.651456 (Exim 4.92) (envelope-from ) id 1oaD44-0006xA-FC; Mon, 19 Sep 2022 09:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408651.651456; Mon, 19 Sep 2022 09:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaD44-0006x3-CY; Mon, 19 Sep 2022 09:27:44 +0000 Received: by outflank-mailman (input) for mailman id 408651; Mon, 19 Sep 2022 09:27:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaD42-0006wx-V6 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:27:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42d6b0df-37fd-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 11:27:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7227.eurprd04.prod.outlook.com (2603:10a6:102:82::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Mon, 19 Sep 2022 09:27:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 09:27:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42d6b0df-37fd-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLXivkKfA/atjgTmwy91+llHlSxxy7CUpQpysvRtRYKflu15GD0JCy0cOTdIfDTea5J4Q5BZMZQ5VjdlJFVeLlCWwLtLVUzCyAsFN27um9I6uNgN7HsMrIf8ee41E+IYqHX1rAncc+0ZTvhePh8r99jphvkQTgsuhgt3IV1wOcDIFe5aLPXWuZoNXSzuUgF/x1cwf67rpL8wlqRGkdVd1eAGeQ11Jkigm23jOxHKGTnTAQ6pFeTOmgDX7mPoZmIl8dtEjgIoOU4MVGzMxF8rbRJC79bra0rzGkodBW6vmLSfIjBzr2eiUvSktjEVXGmWnmzTH3vvvY1+NlpAmXjh1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RfjF2Ow96NNxWkR0u2rSRqq5+oo8NUCL9NhBeZjuwM4=; b=CJEkqlYkEWTG+385JcW8j91TOh1NvNaBEKEcL9j0HwsjhxIcDat7xS1QOW4u3pnK4zIx64vH6I7/913ZzgYM+n0FH9/cytaQGb8sskXuF83vWZiNKfrzg20gKBGBcuA0cC2guBUXVzd9vWcDkshJsHpaNnICRVP5wM390GpWCeZs7KR/aCxCoJzm919HPZe6G9pR0rHnJSuGoNIcvRarxYQf5QOdzUXSX7zsjH54W3YtVIjyI5mTAqAbgo/Ft05J5mA4i7LF+3/uTikyq10J9IlL3PeiDxEtqvu3mp3kCmvSuHmW7jHy60z5d7y64USbjhL59YUjL1X3dZel/060yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RfjF2Ow96NNxWkR0u2rSRqq5+oo8NUCL9NhBeZjuwM4=; b=QRikdWY+wI+Rw2qpBnueue2oJUEp1phy6+VjV4tzIxQcvBsP6qJBidLPExa00bZARqHpWR3nC/oXCcC9NyIlTncJZBUtRWBBun67vkW/8WspxQIAw9q/wSg8jEHZWRv4EPY3LObU6MO+fhGRhpf950+yGvZwQvKQ4NYexVADNOPQ9xK1kkfOgKyO7KC6rLlXfD/Eq4I+kjZ5KD1XEtV9Zu8/kygs71cpqRs/+1KL+dHlJkQfTy0TXPf/ScMjWXjYF+uUf0RihmjRFYPLjv5gVqyxzYbNJ+n2tSesQLSDNaZjuVYrtKSkYhBUX8IIyP13gTJlnqECH9OAKLXvghST7A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> Date: Mon, 19 Sep 2022 11:27:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Boris Ostrovsky Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> From: Jan Beulich In-Reply-To: <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0028.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7227:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b3a7311-a757-401f-8884-08da9a21326b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eSL9N6Poe4+LjRFNIq0Ryyce0CxSmYJI6RBWTyCLgScNWXDecyxdJ2zvYiJMc0MS74+AVdOR3BExLB5oEi5ARy6Q/I8HzuH5BlohveAM51cyYLkDQhby/WRx7kRpaECAu8TBySDNeCzd4i/0A6xJllaHxIJEURysWgppyDLfDZZzpGRTclBp0REP6eeakEXbtMaLt8cVmVUJo7/t+OajwJQ7qfwxAfq3GYt2IuVBvdTP3cryGtFWtjmD3Ae+t84Jo2I7x/CxaWhRTS/lmVz8Hha9WsIxBKmWMLbkXwnqmAap7ex+G5hWXIYL5uO6CVi7+BE0gSa9Kc1bQa2KxQshWmBCxhYDN5IgEsjr3wO/zmVWOhF55jW2ex8KhnsKq+zV+V7/UblD0k1D8AAZyPS/wbBZ4UfAKl0C8NAmpaikQNdu1nB8VLS4EL5CUdPo7PgkncRT9A3NYeeyYknB3S9PRQezjtjQ4h31xCT4XN5I6d+FcHdnRBG6BdralQo7TL57RBMMghADeFkDcgSxnrs++s3BYJzguvPSkvByQx4UBLn+28ZRs7qrH7fgm6p/FUC5BL6zOgMkXR6Oa2deB5vG5fq+m/3TSCxBE2LMur6shniVB3Bo1wfF12Ce4q8B5YOIaG6m1uKhUaXdUnmRSx9H0cnvWAv8c6lfGhgwLPu0hvQkqJ4ccbcMC4+q1R7LrkTwz2WkjOikwA6iDB+Ggv5GRHjQeSCMZTIloFyKNIiAYANAwWVZBUR54nh+wMMJZ+TTzr5qfVX091anlnJhY722HYzQigzac5V2+3xbGY437OY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(39860400002)(136003)(376002)(451199015)(2906002)(31686004)(36756003)(316002)(83380400001)(38100700002)(66556008)(4326008)(8676002)(5660300002)(66476007)(66946007)(31696002)(8936002)(6916009)(54906003)(86362001)(186003)(478600001)(2616005)(6512007)(26005)(6506007)(6486002)(41300700001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmROaWpkT1JmNnorWmQ0WEN3Q3p6NmZROFRkUmZ4OERRa2hjWVpWaHgyeXFn?= =?utf-8?B?bGhEQnBvaTB1SVRUZDlNVkt2Vi9Sd0pYZUdhMi9uZ1kwNjV2ZWllM05oSnFy?= =?utf-8?B?cVUrVW80NFRvdHlHTlN1NTg0MlRtS1JWQXJqa3ZQbkdHaCt0OWMvVGFkUDFI?= =?utf-8?B?RXMyRFhDWHdpNlZRbXM0cGE2UW0wZm05ZUs3NDZwdi9WUUNSZnVzbmpVazIy?= =?utf-8?B?aGVrWFJwYW9IczJSR1R5WjNoeTJjRElaTHFDUVR3cFlkZzkxa2FrcU9STzNl?= =?utf-8?B?NEtyWEp4a0oybXB4M1F4RXNlOHJNSUJDNE9zZ1plN2dPcUJVV0gvQnAvQW0v?= =?utf-8?B?aHFHRVdDeEZEa3g3d2tIY2hkeGhKRnFYRlRHYndrcVYrVmNDNGlxYTgxOExm?= =?utf-8?B?SE1mNTJjY0Y0aW9kdHcvZVkvTW1Gd2hCVFpOc21BcUhBUTFubWNFdXVLN1ph?= =?utf-8?B?Rm93bW9mMlpva0pGbkdSVXJIekpYQUVsTGduLzhsTjRKekZINnE2TEZCb2l3?= =?utf-8?B?bG96MzhaYzZxRUtFN1JlOTVzT2t1SUl6MzNBbDFaclhlM2lpRVptaHprVUov?= =?utf-8?B?VjhxZ1Z1WjYrL2U4QytTaG9WSnUwNmNpNW01L0VQZERKajJFTzQ3OEh2NFdH?= =?utf-8?B?OTRjOVFndVZMYndUR3ZGOTBCVkd0TEViNDF0RXNVeHZQN2MxT1ZBVzA2TGNR?= =?utf-8?B?UWkzTHp4STdMazNtSWFTZFZoTXQ5dWZVOStCRGdNZHA3bkx1MVNZMDJDcVJU?= =?utf-8?B?NXVhTyswZXlmZ1U2bS9Ma0VjT3NKejhXN0l5YlV2U01LZjhFc2NkNER5bUhG?= =?utf-8?B?ZzNibTdxZHg1SmVFL2xCd3MwWERGWjd1VmxNMFgwalVCam4vOHdHbnFKYlNN?= =?utf-8?B?RW82S0xtZldIS1Y1MURxdDNlbnJkSG1aMXNPSmZmcW56cWxYSTdCbjg3K0dP?= =?utf-8?B?dWhEY01OUzhwaERzRUwrcU1CdFd3Vlh5TFlyaFBCUFRYOHlMcEhIRWJiT3Uv?= =?utf-8?B?V01yS2dGNTRGUWRHcFpJdktCSHo2dDFRcVIrcXhvMEozbC9uYnBJcC9GT1F6?= =?utf-8?B?S3NTOGRoNXo5Tkx2YVIvRXRkZUt5Qk52N0JBZlRSa2pKajdDcXBGS3JuVW8x?= =?utf-8?B?eVhBaVhjRkJjQXcwMEFNcGJYWWhmS3kveDBrd1A1UVhiZ1ZLZXZ3TE1aY3Rs?= =?utf-8?B?ak42RUZuM0tHdVF3SlN2QlpsQmZuK2c0MzhiQWRBUE9QRWZvM3VJbWM5eE1s?= =?utf-8?B?bEpQUW44bnVZZ0dTWnFBTk1TSFcyaTVaUmtWbWFJK1VNNjFuMEswc3JadWJr?= =?utf-8?B?TVY0MzdRZDUyaUM2MnF1M0FkdDNtRXpob2lRQnhVSHcxY3hCcUg5SmVpczVu?= =?utf-8?B?VXhuZjc2anY0SVBtcGEwYlpUWHdqM2s2S0NKNHNrMEV5Wk4xamVid0ZoMklU?= =?utf-8?B?M0N5Z0FXYUlGbzhIL1A3Mk5LcUZLREhKYTJ4NFUweU40YlZRVmtqemhVVjky?= =?utf-8?B?emhVSXlvNStjTERZWk9tb2lKbldwVzFiNE1QVVBqU05yTDB5d1k2M0NxSU1S?= =?utf-8?B?YUZFakRMcUxhWGFzRExBL29rTHJxSG1GbnRLWGRva3lYRVI3SlpzdytvYms4?= =?utf-8?B?MkdhUUFsM2srZ0I2N3hVcS9CWTYzTGlKYTZlVGxnSE5JZTVNcFBKTEdmV2xZ?= =?utf-8?B?OWo3cHZBOVFrL1BRaVlxd0VCVERCTlBuREh0SlMyV0FxS0NrSlkzS2FLeG1I?= =?utf-8?B?ditoRVFQZ0JGelQvNlkrUi9BcE5RNC9HOFBZczNwSXhoeHVyRXEyS2pqNklO?= =?utf-8?B?UFZpN1VYaGZReHpob2xYV0dkWEl3czN6QVFLdFNQSFpDeTZXR1dGQmpzekNY?= =?utf-8?B?TjFJSlo3VVQ5UldYSDBFU1kwbDRVM3hwRm9uR3RGaStWdFB3TlVYVDlxeHBy?= =?utf-8?B?ODJpazBieC9iY1ZaRmNjeWlIZDNqMTFaSndxNUdHbHNMTS9kMnIrYmF0TkVs?= =?utf-8?B?UlZ5YWp3ZWE2ZHFCQTJIVGlDLzBNaXpsRURGRENLdVVKTmhWc3Ric1Y2emZP?= =?utf-8?B?a0Q5TkgzV21taHAwbW12UmlncWxackVsWHFXbkJOTFIwcTNLSnVzallzUUwv?= =?utf-8?Q?ZC56yyG6xGl7lgtbsVNrAWz3Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b3a7311-a757-401f-8884-08da9a21326b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 09:27:39.8415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IXKNn2nr2k5tKac/+zEYr13EIKiuSIl4ysXkdwXCwOQX9tNFyCuJiQyz/AWVMKJDaLhj/rog6Z8M0NH31opdhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7227 On 16.09.2022 23:35, Boris Ostrovsky wrote: > > On 9/16/22 8:52 AM, Jan Beulich wrote: >> On 15.09.2022 16:01, Tamas K Lengyel wrote: >>> While experimenting with the vPMU subsystem an ASSERT failure was >>> observed in vmx_find_msr because the vcpu_runnable state was true. >>> >>> The root cause of the bug appears to be the fact that the vPMU subsystem >>> doesn't save its state on context_switch. The vpmu_load function will attempt >>> to gather the PMU state if its still loaded two different ways: >>> 1. if the current pcpu is not where the vcpu ran before doing a remote save >>> 2. if the current pcpu had another vcpu active before doing a local save >>> >>> However, in case the prev vcpu is being rescheduled on another pcpu its state >>> has already changed and vcpu_runnable is returning true, thus #2 will trip the >>> ASSERT. The only way to avoid this race condition is to make sure the >>> prev vcpu is paused while being checked and its context saved. Once the prev >>> vcpu is resumed and does #1 it will find its state already saved. >> While I consider this explanation plausible, I'm worried: >> >>> --- a/xen/arch/x86/cpu/vpmu.c >>> +++ b/xen/arch/x86/cpu/vpmu.c >>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) >>> vpmu = vcpu_vpmu(prev); >>> >>> /* Someone ran here before us */ >>> + vcpu_pause(prev); >>> vpmu_save_force(prev); >>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>> + vcpu_unpause(prev); >>> >>> vpmu = vcpu_vpmu(v); >>> } >> We're running with IRQs off here, yet vcpu_pause() waits for the vcpu >> to actually be de-scheduled. Even with IRQs on this is already a >> relatively heavy operation (also including its impact on the remote >> side). Additionally the function is called from context_switch(), and >> I'm unsure of the usability of vcpu_pause() on such a path. In >> particular: Is there a risk of two CPUs doing this mutually to one >> another? If so, is deadlocking excluded? >> >> Hence at the very least I think the description wants extending, to >> discuss the safety of the change. >> >> Boris - any chance you could comment here? Iirc that's code you did >> introduce. > > > Is the assertion in vmx_find_msr() really needs to be for runnable vcpu or can it be a check on whether vcpu is actually running (e.g. RUNSTATE_running)? You cannot safely check for "running", as "runnable" may transition to/from "running" behind your back. Jan > I think call chain vpmu_load()->..->*_vpmu_save()->...->vmx_find_msr() is the only one where we are doing it for non-current vcpu. If we can guarantee that run state is set after vpmu_load() call (maybe it is already, I haven't checked) then testing the state may avoid the assertion. > > > -boris > From xen-devel-bounces@lists.xenproject.org Mon Sep 19 09:52:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 09:52:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408662.651467 (Exim 4.92) (envelope-from ) id 1oaDRz-0001qa-Fk; Mon, 19 Sep 2022 09:52:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408662.651467; Mon, 19 Sep 2022 09:52:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaDRz-0001qT-D8; Mon, 19 Sep 2022 09:52:27 +0000 Received: by outflank-mailman (input) for mailman id 408662; Mon, 19 Sep 2022 09:52:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaDRy-0001q9-A2 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 09:52:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c37ddd6c-3800-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 11:52:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF83221D88; Mon, 19 Sep 2022 09:52:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 714AE13ABD; Mon, 19 Sep 2022 09:52:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /TXzGdg7KGMzYQAAMHmgww (envelope-from ); Mon, 19 Sep 2022 09:52:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c37ddd6c-3800-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663581144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ni1KGj6fHNi2L8wZnDcDKSF7+VC35L2jQ93te+J2OPo=; b=jqw9eWwRlKsDUFZ3uQnMSehEr1B4GflMhccfF1aPb7DzrTUOwajxaAps6+HbC0nR6RJ4Hu 9NdUEw2VaS1+7qJAk1RW8vEv+odB+L9CVM+W7DukB0+I7xqPQTTETD7zZ4wvSwqFlVAYlQ 9DdxIO0/fdF7SCjhJnA8qbbsdMyQB2s= Message-ID: Date: Mon, 19 Sep 2022 11:52:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen/gntdev: Prevent leaking grants To: "M. Vefa Bicakci" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann References: <20220912040002.198191-1-m.v.b@runbox.com> <20220912040002.198191-2-m.v.b@runbox.com> Content-Language: en-US From: Juergen Gross In-Reply-To: <20220912040002.198191-2-m.v.b@runbox.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------aFjZl0pJMi9O2HQyrVB08eZJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------aFjZl0pJMi9O2HQyrVB08eZJ Content-Type: multipart/mixed; boundary="------------eV0m9qh006RDgFkMVNGTjRkm"; protected-headers="v1" From: Juergen Gross To: "M. Vefa Bicakci" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann Message-ID: Subject: Re: [PATCH 1/2] xen/gntdev: Prevent leaking grants References: <20220912040002.198191-1-m.v.b@runbox.com> <20220912040002.198191-2-m.v.b@runbox.com> In-Reply-To: <20220912040002.198191-2-m.v.b@runbox.com> --------------eV0m9qh006RDgFkMVNGTjRkm Content-Type: multipart/mixed; boundary="------------0HZAFkn1IrghtMNUXP7cOlbR" --------------0HZAFkn1IrghtMNUXP7cOlbR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMDY6MDAsIE0uIFZlZmEgQmljYWtjaSB3cm90ZToNCj4gUHJpb3IgdG8g dGhpcyBjb21taXQsIGlmIGEgZ3JhbnQgbWFwcGluZyBvcGVyYXRpb24gZmFpbGVkIHBhcnRp YWxseSwNCj4gc29tZSBvZiB0aGUgZW50cmllcyBpbiB0aGUgbWFwX29wcyBhcnJheSB3b3Vs ZCBiZSBpbnZhbGlkLCB3aGVyZWFzIGFsbA0KPiBvZiB0aGUgZW50cmllcyBpbiB0aGUga21h cF9vcHMgYXJyYXkgd291bGQgYmUgdmFsaWQuIFRoaXMgaW4gdHVybiB3b3VsZA0KPiBjYXVz ZSB0aGUgZm9sbG93aW5nIGxvZ2ljIGluIGdudGRldl9tYXBfZ3JhbnRfcGFnZXMgdG8gYmVj b21lIGludmFsaWQ6DQo+IA0KPiAgICBmb3IgKGkgPSAwOyBpIDwgbWFwLT5jb3VudDsgaSsr KSB7DQo+ICAgICAgaWYgKG1hcC0+bWFwX29wc1tpXS5zdGF0dXMgPT0gR05UU1Rfb2theSkg ew0KPiAgICAgICAgbWFwLT51bm1hcF9vcHNbaV0uaGFuZGxlID0gbWFwLT5tYXBfb3BzW2ld LmhhbmRsZTsNCj4gICAgICAgIGlmICghdXNlX3B0ZW1vZCkNCj4gICAgICAgICAgYWxsb2Nl ZCsrOw0KPiAgICAgIH0NCj4gICAgICBpZiAodXNlX3B0ZW1vZCkgew0KPiAgICAgICAgaWYg KG1hcC0+a21hcF9vcHNbaV0uc3RhdHVzID09IEdOVFNUX29rYXkpIHsNCj4gICAgICAgICAg aWYgKG1hcC0+bWFwX29wc1tpXS5zdGF0dXMgPT0gR05UU1Rfb2theSkNCj4gICAgICAgICAg ICBhbGxvY2VkKys7DQo+ICAgICAgICAgIG1hcC0+a3VubWFwX29wc1tpXS5oYW5kbGUgPSBt YXAtPmttYXBfb3BzW2ldLmhhbmRsZTsNCj4gICAgICAgIH0NCj4gICAgICB9DQo+ICAgIH0N Cj4gICAgLi4uDQo+ICAgIGF0b21pY19hZGQoYWxsb2NlZCwgJm1hcC0+bGl2ZV9ncmFudHMp Ow0KPiANCj4gQXNzdW1lIHRoYXQgdXNlX3B0ZW1vZCBpcyB0cnVlIChpLmUuLCB0aGUgZG9t YWluIG1hcHBpbmcgdGhlIGdyYW50ZWQNCj4gcGFnZXMgaXMgYSBwYXJhdmlydHVhbGl6ZWQg ZG9tYWluKS4gSW4gdGhlIGNvZGUgZXhjZXJwdCBhYm92ZSwgbm90ZSB0aGF0DQo+IHRoZSAi YWxsb2NlZCIgdmFyaWFibGUgaXMgb25seSBpbmNyZW1lbnRlZCB3aGVuIGJvdGgga21hcF9v cHNbaV0uc3RhdHVzDQo+IGFuZCBtYXBfb3BzW2ldLnN0YXR1cyBhcmUgc2V0IHRvIEdOVFNU X29rYXkgKGkuZS4sIGJvdGggbWFwcGluZw0KPiBvcGVyYXRpb25zIGFyZSBzdWNjZXNzZnVs KS4gIEhvd2V2ZXIsIGFzIGFsc28gbm90ZWQgYWJvdmUsIHRoZXJlIGFyZQ0KPiBjYXNlcyB3 aGVyZSBhIGdyYW50IG1hcHBpbmcgb3BlcmF0aW9uIGZhaWxzIHBhcnRpYWxseSwgYnJlYWtp bmcgdGhlDQo+IGFzc3VtcHRpb24gb2YgdGhlIGNvZGUgZXhjZXJwdCBhYm92ZS4NCj4gDQo+ IFRoZSBhZm9yZW1lbnRpb25lZCBjYXVzZXMgbWFwLT5saXZlX2dyYW50cyB0byBiZSBpbmNv cnJlY3RseSBzZXQuIEluDQo+IHNvbWUgY2FzZXMsIGFsbCBvZiB0aGUgbWFwX29wcyBtYXBw aW5ncyBmYWlsLCBidXQgYWxsIG9mIHRoZSBrbWFwX29wcw0KPiBtYXBwaW5ncyBzdWNjZWVk LCBtZWFuaW5nIHRoYXQgbGl2ZV9ncmFudHMgbWF5IHJlbWFpbiB6ZXJvLiBUaGlzIGluIHR1 cm4NCj4gbWFrZXMgaXQgaW1wb3NzaWJsZSB0byB1bm1hcCB0aGUgc3VjY2Vzc2Z1bGx5IGdy YW50LW1hcHBlZCBwYWdlcyBwb2ludGVkDQo+IHRvIGJ5IGttYXBfb3BzLCBiZWNhdXNlIHVu bWFwX2dyYW50X3BhZ2VzIGhhcyB0aGUgZm9sbG93aW5nIHNuaXBwZXQgb2YNCj4gY29kZSBh dCBpdHMgYmVnaW5uaW5nOg0KPiANCj4gICAgaWYgKGF0b21pY19yZWFkKCZtYXAtPmxpdmVf Z3JhbnRzKSA9PSAwKQ0KPiAgICAgIHJldHVybjsgLyogTm90aGluZyB0byBkbyAqLw0KPiAN Cj4gSW4gb3RoZXIgY2FzZXMgd2hlcmUgb25seSBzb21lIG9mIHRoZSBtYXBfb3BzIG1hcHBp bmdzIGZhaWwgYnV0IGFsbA0KPiBrbWFwX29wcyBtYXBwaW5ncyBzdWNjZWVkLCBsaXZlX2dy YW50cyBpcyBtYWRlIHBvc2l0aXZlLCBidXQgd2hlbiB0aGUNCj4gdXNlciByZXF1ZXN0cyB1 bm1hcHBpbmcgdGhlIGdyYW50LW1hcHBlZCBwYWdlcywgX191bm1hcF9ncmFudF9wYWdlc19k b25lDQo+IHdpbGwgdGhlbiBtYWtlIG1hcC0+bGl2ZV9ncmFudHMgbmVnYXRpdmUsIGJlY2F1 c2UgdGhlIGxhdHRlciBmdW5jdGlvbg0KPiBkb2VzIG5vdCBjaGVjayBpZiBhbGwgb2YgdGhl IHBhZ2VzIHRoYXQgd2VyZSByZXF1ZXN0ZWQgdG8gYmUgdW5tYXBwZWQNCj4gd2VyZSBhY3R1 YWxseSB1bm1hcHBlZCwgYW5kIHRoZSBzYW1lIGZ1bmN0aW9uIHVuY29uZGl0aW9uYWxseSBz dWJ0cmFjdHMNCj4gImRhdGEtPmNvdW50IiAoaS5lLiwgYSB2YWx1ZSB0aGF0IGNhbiBiZSBn cmVhdGVyIHRoYW4gbWFwLT5saXZlX2dyYW50cykNCj4gZnJvbSBtYXAtPmxpdmVfZ3JhbnRz LiBUaGUgc2lkZSBlZmZlY3RzIG9mIGEgbmVnYXRpdmUgbGl2ZV9ncmFudHMgdmFsdWUNCj4g aGF2ZSBub3QgYmVlbiBzdHVkaWVkLg0KPiANCj4gVGhlIG5ldCBlZmZlY3Qgb2YgYWxsIG9m IHRoaXMgaXMgdGhhdCBncmFudCByZWZlcmVuY2VzIGFyZSBsZWFrZWQgaW4gb25lDQo+IG9m IHRoZSBhYm92ZSBjb25kaXRpb25zLiBJbiBRdWJlcyBPUyB2NC4xICh3aGljaCB1c2VzIFhl bidzIGdyYW50DQo+IG1lY2hhbmlzbSBleHRlbnNpdmVseSBmb3IgWDExIEdVSSBpc29sYXRp b24pLCB0aGlzIGlzc3VlIG1hbmlmZXN0cw0KPiBpdHNlbGYgd2l0aCB3YXJuaW5nIG1lc3Nh Z2VzIGxpa2UgdGhlIGZvbGxvd2luZyB0byBiZSBwcmludGVkIG91dCBieSB0aGUNCj4gTGlu dXgga2VybmVsIGluIHRoZSBWTSB0aGF0IGhhZCBncmFudGVkIHBhZ2VzICh0aGF0IGNvbnRh aW4gWDExIEdVSQ0KPiB3aW5kb3cgZGF0YSkgdG8gZG9tMDogImcuZS4gMHgxMjM0IHN0aWxs IHBlbmRpbmciLCBlc3BlY2lhbGx5IGFmdGVyIHRoZQ0KPiB1c2VyIHJhcGlkbHkgcmVzaXpl cyBHVUkgVk0gd2luZG93cyAoY2F1c2luZyBzb21lIGdyYW50LW1hcHBpbmcNCj4gb3BlcmF0 aW9ucyB0byBwYXJ0aWFsbHkgb3IgY29tcGxldGVseSBmYWlsLCBkdWUgdG8gdGhlIGZhY3Qg dGhhdCB0aGUgVk0NCj4gdW5zaGFyZXMgc29tZSBvZiB0aGUgcGFnZXMgYXMgcGFydCBvZiB0 aGUgd2luZG93IHJlc2l6aW5nLCBtYWtpbmcgdGhlDQo+IHBhZ2VzIGltcG9zc2libGUgdG8g Z3JhbnQtbWFwIGZyb20gZG9tMCkuDQo+IA0KPiBUaGUgZml4IGZvciB0aGlzIGlzc3VlIGlu dm9sdmVzIGNvdW50aW5nIGFsbCBzdWNjZXNzZnVsIG1hcF9vcHMgYW5kDQo+IGttYXBfb3Bz IG1hcHBpbmdzIHNlcGFyYXRlbHksIGFuZCB0aGVuIGFkZGluZyB0aGUgc3VtIHRvIGxpdmVf Z3JhbnRzLg0KPiBEdXJpbmcgdW5tYXBwaW5nLCBvbmx5IHRoZSBudW1iZXIgb2Ygc3VjY2Vz c2Z1bGx5IHVubWFwcGVkIGdyYW50cyBpcw0KPiBzdWJ0cmFjdGVkIGZyb20gbGl2ZV9ncmFu dHMuIFRvIGRldGVybWluZSB3aGljaCBncmFudHMgd2VyZSBzdWNjZXNzZnVsbHkNCj4gdW5t YXBwZWQsIHRoZWlyIHN0YXR1cyBmaWVsZHMgYXJlIHNldCB0byBhbiBhcmJpdHJhcnkgcG9z aXRpdmUgbnVtYmVyDQo+ICgxKSwgYXMgd2FzIGRvbmUgaW4gY29tbWl0IGViZWUwZWFiMDg1 OSAoIlhlbi9nbnRkZXY6IGNvcnJlY3QgZXJyb3INCj4gY2hlY2tpbmcgaW4gZ250ZGV2X21h cF9ncmFudF9wYWdlcygpIikuIFRoZSBjb2RlIGlzIGFsc28gbW9kaWZpZWQgdG8NCj4gY2hl Y2sgZm9yIG5lZ2F0aXZlIGxpdmVfZ3JhbnRzIHZhbHVlcyBhZnRlciB0aGUgc3VidHJhY3Rp b24gYW5kIHdhcm4gdGhlDQo+IHVzZXIuDQo+IA0KPiBMaW5rOiBodHRwczovL2dpdGh1Yi5j b20vUXViZXNPUy9xdWJlcy1pc3N1ZXMvaXNzdWVzLzc2MzENCj4gRml4ZXM6IGRiZTk3Y2Zm N2RkOSAoInhlbi9nbnRkZXY6IEF2b2lkIGJsb2NraW5nIGluIHVubWFwX2dyYW50X3BhZ2Vz KCkiKQ0KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBN LiBWZWZhIEJpY2FrY2kgPG0udi5iQHJ1bmJveC5jb20+DQo+IC0tLQ0KPiAgIGRyaXZlcnMv eGVuL2dudGRldi5jIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0NCj4g ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCj4g DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9nbnRkZXYuYyBiL2RyaXZlcnMveGVuL2du dGRldi5jDQo+IGluZGV4IDg0YjE0M2VlZjM5NS4uNDg1ZmE5YzYzMGFhIDEwMDY0NA0KPiAt LS0gYS9kcml2ZXJzL3hlbi9nbnRkZXYuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9nbnRkZXYu Yw0KPiBAQCAtMzY3LDggKzM2Nyw3IEBAIGludCBnbnRkZXZfbWFwX2dyYW50X3BhZ2VzKHN0 cnVjdCBnbnRkZXZfZ3JhbnRfbWFwICptYXApDQo+ICAgCWZvciAoaSA9IDA7IGkgPCBtYXAt PmNvdW50OyBpKyspIHsNCj4gICAJCWlmIChtYXAtPm1hcF9vcHNbaV0uc3RhdHVzID09IEdO VFNUX29rYXkpIHsNCj4gICAJCQltYXAtPnVubWFwX29wc1tpXS5oYW5kbGUgPSBtYXAtPm1h cF9vcHNbaV0uaGFuZGxlOw0KPiAtCQkJaWYgKCF1c2VfcHRlbW9kKQ0KPiAtCQkJCWFsbG9j ZWQrKzsNCj4gKwkJCWFsbG9jZWQrKzsNCj4gICAJCX0gZWxzZSBpZiAoIWVycikNCj4gICAJ CQllcnIgPSAtRUlOVkFMOw0KPiAgIA0KPiBAQCAtMzc3LDggKzM3Niw3IEBAIGludCBnbnRk ZXZfbWFwX2dyYW50X3BhZ2VzKHN0cnVjdCBnbnRkZXZfZ3JhbnRfbWFwICptYXApDQo+ICAg DQo+ICAgCQlpZiAodXNlX3B0ZW1vZCkgew0KPiAgIAkJCWlmIChtYXAtPmttYXBfb3BzW2ld LnN0YXR1cyA9PSBHTlRTVF9va2F5KSB7DQo+IC0JCQkJaWYgKG1hcC0+bWFwX29wc1tpXS5z dGF0dXMgPT0gR05UU1Rfb2theSkNCj4gLQkJCQkJYWxsb2NlZCsrOw0KPiArCQkJCWFsbG9j ZWQrKzsNCj4gICAJCQkJbWFwLT5rdW5tYXBfb3BzW2ldLmhhbmRsZSA9IG1hcC0+a21hcF9v cHNbaV0uaGFuZGxlOw0KPiAgIAkJCX0gZWxzZSBpZiAoIWVycikNCj4gICAJCQkJZXJyID0g LUVJTlZBTDsNCj4gQEAgLTM5NCw4ICszOTIsMTMgQEAgc3RhdGljIHZvaWQgX191bm1hcF9n cmFudF9wYWdlc19kb25lKGludCByZXN1bHQsDQo+ICAgCXVuc2lnbmVkIGludCBpOw0KPiAg IAlzdHJ1Y3QgZ250ZGV2X2dyYW50X21hcCAqbWFwID0gZGF0YS0+ZGF0YTsNCj4gICAJdW5z aWduZWQgaW50IG9mZnNldCA9IGRhdGEtPnVubWFwX29wcyAtIG1hcC0+dW5tYXBfb3BzOw0K PiArCWludCBzdWNjZXNzZnVsX3VubWFwcyA9IDA7DQo+ICsJaW50IGxpdmVfZ3JhbnRzOw0K PiAgIA0KPiAgIAlmb3IgKGkgPSAwOyBpIDwgZGF0YS0+Y291bnQ7IGkrKykgew0KPiArCQlp ZiAobWFwLT51bm1hcF9vcHNbb2Zmc2V0ICsgaV0uc3RhdHVzID09IEdOVFNUX29rYXkpDQo+ ICsJCQlzdWNjZXNzZnVsX3VubWFwcysrOw0KDQpTaG91bGRuJ3QgdGhpcyB0ZXN0IGluY2x1 ZGUgIiYmIGhhbmRsZSAhPSBJTlZBTElEX0dSQU5UX0hBTkRMRSIgPw0KDQpUaGlzIHNob3Vs ZCBlbmFibGUgeW91IHRvIGRyb3Agc2V0dGluZyBzdGF0dXMgdG8gMSBiZWxvdy4NCg0KPiAr DQo+ICAgCQlXQVJOX09OKG1hcC0+dW5tYXBfb3BzW29mZnNldCArIGldLnN0YXR1cyAhPSBH TlRTVF9va2F5ICYmDQo+ICAgCQkJbWFwLT51bm1hcF9vcHNbb2Zmc2V0ICsgaV0uaGFuZGxl ICE9IElOVkFMSURfR1JBTlRfSEFORExFKTsNCj4gICAJCXByX2RlYnVnKCJ1bm1hcCBoYW5k bGU9JWQgc3Q9JWRcbiIsDQo+IEBAIC00MDMsNiArNDA2LDkgQEAgc3RhdGljIHZvaWQgX191 bm1hcF9ncmFudF9wYWdlc19kb25lKGludCByZXN1bHQsDQo+ICAgCQkJbWFwLT51bm1hcF9v cHNbb2Zmc2V0K2ldLnN0YXR1cyk7DQo+ICAgCQltYXAtPnVubWFwX29wc1tvZmZzZXQraV0u aGFuZGxlID0gSU5WQUxJRF9HUkFOVF9IQU5ETEU7DQo+ICAgCQlpZiAodXNlX3B0ZW1vZCkg ew0KPiArCQkJaWYgKG1hcC0+a3VubWFwX29wc1tvZmZzZXQgKyBpXS5zdGF0dXMgPT0gR05U U1Rfb2theSkNCj4gKwkJCQlzdWNjZXNzZnVsX3VubWFwcysrOw0KPiArDQo+ICAgCQkJV0FS Tl9PTihtYXAtPmt1bm1hcF9vcHNbb2Zmc2V0ICsgaV0uc3RhdHVzICE9IEdOVFNUX29rYXkg JiYNCj4gICAJCQkJbWFwLT5rdW5tYXBfb3BzW29mZnNldCArIGldLmhhbmRsZSAhPSBJTlZB TElEX0dSQU5UX0hBTkRMRSk7DQo+ICAgCQkJcHJfZGVidWcoImt1bm1hcCBoYW5kbGU9JXUg c3Q9JWRcbiIsDQo+IEBAIC00MTEsMTEgKzQxNywxNSBAQCBzdGF0aWMgdm9pZCBfX3VubWFw X2dyYW50X3BhZ2VzX2RvbmUoaW50IHJlc3VsdCwNCj4gICAJCQltYXAtPmt1bm1hcF9vcHNb b2Zmc2V0K2ldLmhhbmRsZSA9IElOVkFMSURfR1JBTlRfSEFORExFOw0KPiAgIAkJfQ0KPiAg IAl9DQo+ICsNCj4gICAJLyoNCj4gICAJICogRGVjcmVhc2UgdGhlIGxpdmUtZ3JhbnQgY291 bnRlci4gIFRoaXMgbXVzdCBoYXBwZW4gYWZ0ZXIgdGhlIGxvb3AgdG8NCj4gICAJICogcHJl dmVudCBwcmVtYXR1cmUgcmV1c2Ugb2YgdGhlIGdyYW50cyBieSBnbnR0YWJfbW1hcCgpLg0K PiAgIAkgKi8NCj4gLQlhdG9taWNfc3ViKGRhdGEtPmNvdW50LCAmbWFwLT5saXZlX2dyYW50 cyk7DQo+ICsJbGl2ZV9ncmFudHMgPSBhdG9taWNfc3ViX3JldHVybihzdWNjZXNzZnVsX3Vu bWFwcywgJm1hcC0+bGl2ZV9ncmFudHMpOw0KPiArCWlmIChXQVJOX09OKGxpdmVfZ3JhbnRz IDwgMCkpDQo+ICsJCXByX2VycigiJXM6IGxpdmVfZ3JhbnRzIGJlY2FtZSBuZWdhdGl2ZSAo JWQpIGFmdGVyIHVubWFwcGluZyAlZCBwYWdlcyFcbiIsDQo+ICsJCSAgICAgICBfX2Z1bmNf XywgbGl2ZV9ncmFudHMsIHN1Y2Nlc3NmdWxfdW5tYXBzKTsNCj4gICANCj4gICAJLyogUmVs ZWFzZSByZWZlcmVuY2UgdGFrZW4gYnkgX191bm1hcF9ncmFudF9wYWdlcyAqLw0KPiAgIAln bnRkZXZfcHV0X21hcChOVUxMLCBtYXApOw0KPiBAQCAtNDI0LDYgKzQzNCw4IEBAIHN0YXRp YyB2b2lkIF9fdW5tYXBfZ3JhbnRfcGFnZXNfZG9uZShpbnQgcmVzdWx0LA0KPiAgIHN0YXRp YyB2b2lkIF9fdW5tYXBfZ3JhbnRfcGFnZXMoc3RydWN0IGdudGRldl9ncmFudF9tYXAgKm1h cCwgaW50IG9mZnNldCwNCj4gICAJCQkgICAgICAgaW50IHBhZ2VzKQ0KPiAgIHsNCj4gKwlp bnQgaWR4Ow0KPiArDQo+ICAgCWlmIChtYXAtPm5vdGlmeS5mbGFncyAmIFVOTUFQX05PVElG WV9DTEVBUl9CWVRFKSB7DQo+ICAgCQlpbnQgcGdubyA9IChtYXAtPm5vdGlmeS5hZGRyID4+ IFBBR0VfU0hJRlQpOw0KPiAgIA0KPiBAQCAtNDM2LDYgKzQ0OCwxNiBAQCBzdGF0aWMgdm9p ZCBfX3VubWFwX2dyYW50X3BhZ2VzKHN0cnVjdCBnbnRkZXZfZ3JhbnRfbWFwICptYXAsIGlu dCBvZmZzZXQsDQo+ICAgCQl9DQo+ICAgCX0NCj4gICANCj4gKwkvKiBTZXQgYWxsIHVubWFw L2t1bm1hcCBzdGF0dXMgZmllbGRzIHRvIGFuIGFyYml0cmFyeSBwb3NpdGl2ZSB2YWx1ZSwN Cj4gKwkgKiBzbyB0aGF0IGl0IGlzIHBvc3NpYmxlIHRvIGRldGVybWluZSB3aGljaCBncmFu dHMgd2VyZSBzdWNjZXNzZnVsbHkNCj4gKwkgKiB1bm1hcHBlZCBieSBpbnNwZWN0aW5nIHRo ZSBzdGF0dXMgZmllbGRzLg0KPiArCSAqLw0KPiArCWZvciAoaWR4ID0gb2Zmc2V0OyBpZHgg PCBvZmZzZXQgKyBwYWdlczsgaWR4KyspIHsNCj4gKwkJbWFwLT51bm1hcF9vcHNbaWR4XS5z dGF0dXMgPSAxOw0KPiArCQlpZiAodXNlX3B0ZW1vZCkNCj4gKwkJCW1hcC0+a3VubWFwX29w c1tpZHhdLnN0YXR1cyA9IDE7DQo+ICsJfQ0KPiArDQo+ICAgCW1hcC0+dW5tYXBfZGF0YS51 bm1hcF9vcHMgPSBtYXAtPnVubWFwX29wcyArIG9mZnNldDsNCj4gICAJbWFwLT51bm1hcF9k YXRhLmt1bm1hcF9vcHMgPSB1c2VfcHRlbW9kID8gbWFwLT5rdW5tYXBfb3BzICsgb2Zmc2V0 IDogTlVMTDsNCj4gICAJbWFwLT51bm1hcF9kYXRhLnBhZ2VzID0gbWFwLT5wYWdlcyArIG9m ZnNldDsNCg0KSnVlcmdlbg0K --------------0HZAFkn1IrghtMNUXP7cOlbR Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0HZAFkn1IrghtMNUXP7cOlbR-- --------------eV0m9qh006RDgFkMVNGTjRkm-- --------------aFjZl0pJMi9O2HQyrVB08eZJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMoO9cFAwAAAAAACgkQsN6d1ii/Ey+0 1Af/Wi78cbkhn3nEileqiP0UGFhY9yc3IvgkOFjUqjxi4McywcXaERTJzYh7fasUjR9UP1Wmgf+H ywbUqZUgLuLLYhZm+vu8KwU7J6Yo1jg4p/Adu9OoWqoXlIbvOFAq1m/vzHcekdJiEgCqKUkGz3zm JDrtXtDenTlrol4xUnx2WsGJzN2eu2/PuJ7Zmwuh+XrCP0X2gsMVc+hrvd9zarIEbuhB3oLa5MIk XedWX+DqbOm/j7TGM9r9OsdAU5S89QsM0o+/X/w2HWjCY5EMFMlN9uJVl6bEDy42q45YGw25DCps UgBKaI+xLR6WP3jQTkv7Wpbas39Kc2yjxfGixMAP8A== =T19P -----END PGP SIGNATURE----- --------------aFjZl0pJMi9O2HQyrVB08eZJ-- From xen-devel-bounces@lists.xenproject.org Mon Sep 19 10:19:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 10:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408671.651479 (Exim 4.92) (envelope-from ) id 1oaDsC-0004Nw-N5; Mon, 19 Sep 2022 10:19:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408671.651479; Mon, 19 Sep 2022 10:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaDsC-0004Np-K2; Mon, 19 Sep 2022 10:19:32 +0000 Received: by outflank-mailman (input) for mailman id 408671; Mon, 19 Sep 2022 10:19:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaDsA-0004Nj-IH for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 10:19:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b88f61f-3804-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 12:19:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8607.eurprd04.prod.outlook.com (2603:10a6:102:21a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 10:19:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 10:19:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b88f61f-3804-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WujtaAusYGVYRNW8sBTyZY1UrcnqrKmqECpEa1jim+dzGR+YCpvYwmEJko6yVaKrAZGGbi+y6gR5JWFhOjh5MLfkUctbKJSzfaSXmtg+yD6Z5chZQE898eEKmIJhljJjMDWxHjVnE8P+4Rl/BH1deusb7mhYco6SMVDhT6zHuOrTc2IrOdtksQtkCILcXOodUFJSpB7lbn5+Xv/jjrWSErpRZA5+kTfThiCnk+QJMwk6S6OkjqNbQy8Xx1swkxEaXctVyZ8r1JGrgLEkYR57LA2Ac3z0ASJxMP/eDHC4+Kjq/e952Bu9ny8bOImtCQma3pdbNB9lJFYEGBuqrrsAKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xw+BMow05VRz5iuOzQEnbtb0xxj8OkDZVK3R17H9mro=; b=m6TlVWkYl//Z7eM0JQhuOK+1hBCeKnlEbT69b8rth0tEGAJG8J/kOSsM0y+sbTt7KcgyRz3rbBUQ5Xe+SsO94JbjHgO7EJi9woCyq86VhcFmlFv4AlK/fqrw1m8kQ5ewbJtEMDoYhoawRkc0BWBS23H1sb3+hlnS8tvj6Ec8sICeab2Q7TsgpBH+m0LneHwKqZ4gw+RWa3Nvb1DxqywJfDPsG+fpnhVBUhQltMgMcrd5otGtGu4mKq4au1oHsH5JvySa3U0pPZtv/LKsrH0CPRfPIDGn8f7hWFLC7QiOgMaNgMJcyCszexmKofZ+9L39SWTl0XccfQccmsYa55qY2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xw+BMow05VRz5iuOzQEnbtb0xxj8OkDZVK3R17H9mro=; b=L9PaoUhhEnrjmw/KBNQvnkJCxpRFnResK5kvfmjotcA9fVxVeesSdb92s1/vxONEiVDkp8BuE6MWPtEQK1NfbyvU9KfbZIh/KNOijCB96GAowJ6xTnc8ct3M0CwtPBqlP/VSBabIOO1PvFP5FgP60Yo5N4yoFU09thTN2hvCC+UF6aie2dFjxfwindNi+4Y7S1WwB2Igr6Psju6Pqd2dHbZa35MfYNI1/Yu4CmTGiROsXiOhxvr5vHzUC+f7diucfNe5RZ45OXaD7X8fhNGQchd2sy6taau0ZHVflSbsaZkvoN3P09ImvHFDeHisx5naLED5UAliIb/2zid1GfRyZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <039ff47a-064a-bfaf-31a0-68d4e055cfdc@suse.com> Date: Mon, 19 Sep 2022 12:19:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] acpi: Make TPM version configurable. Content-Language: en-US To: Jennifer Herbert Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, wl@xen.org, roger.pau@citrix.com References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> <20220915204029.1227112-1-jennifer.herbert@citrix.com> From: Jan Beulich In-Reply-To: <20220915204029.1227112-1-jennifer.herbert@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0667.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8607:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e2c1a7c-65c4-4500-c550-08da9a286f15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8XOy3QNQZWvZfRg/S2V7K/GRa0ReIgdOyoTxkK+3+ZPzxdCy319NlaK8LEdrAFYgE+0XY82X3hOBGXlU3a9r+wP4Kn61lLMqcr76OhwzqtWN0/irAtnh33JY3IiGd1aOxMNLrb7BEo3CW7Bu4NXsTBHuwEFwHeyv1knywdni0yMBwoCNAiz3Ik3DaEw2H7LqO/0cownja20xzCjU8+Ve6W7/fxdVhazvUYAirY9aJa3Fxt0NMplYmFNMQNVU4Vtu4RWiEVCUfffnEUA+w0VD7g0N/mr5Yi/teOISvJXRA+yKxr2Sdl5mx4Y+m0EfUSTcoWq27KJXBPoVf3RGNqE+2w/NmiApvJQD0iUEe9z+G82jn631gWPdQPLWsd7DNqq5mMzRzEd2i2L8tHYnot46hFWTn5Fn6UUoD+wdAOv30zCJfy/TwhPjz39BQjNrEcRoE8q/c15S7jqC1Dc0XHtmVnhRuiXE47dhvgFILxkenWiyMooRZVq6wedocxEqGqAiE/ewG8Twu0+w9pUdrwo2D8YGZt6LvTLLGsYo+kCaNtt99zGpGmGH3qi/jBbFyfXKqW7BLZtA1VGv/0iTp39ynCefZPG3E5y/mNH3eiY3vTArW7uP+lel+vfFFKKzYU1KyYmoClb415YsSGbK/ilrO8bHhqmZzPy8crsiutD+8U2Fn9DJXydp2VSeaxEm5S2OnL5/xTIN2uCR7F+wxuswUDUdfEPLG8NOChwgaGp7twIIsOd0J2kHurG5WKguNULhjDvkGgDFy5vk92Gmyt17KNRSaXs8GrVhzDKCKQXFmME= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199015)(31686004)(36756003)(2906002)(316002)(38100700002)(4326008)(66556008)(8676002)(66476007)(5660300002)(66946007)(8936002)(31696002)(86362001)(6916009)(186003)(478600001)(2616005)(6512007)(26005)(53546011)(6506007)(6486002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVpxR0dNc3VkYXBlSXdVOGV5eTgyTTR5OGhaNTdNellSa3VjQy9mR0djUFRC?= =?utf-8?B?TmMweGFQcHc2ZktVbFRERjdNNE5CcFlWUytjajZrT2pQS3ljcWdUdFRsaDJH?= =?utf-8?B?bk1KNnRScjd3emlxWVNMR1RFMnVIdExVRG50VXh1UGdHMjNiNzYrNEFndVpE?= =?utf-8?B?Nzg5bGJ1ZE9jc3ZnTWw1OGJVeXYwZTNaWW1ERmplUE9EZjFFUGx4RkxkZnhT?= =?utf-8?B?L3JyaDFMKzd3SUg2b2xsckxMTWJxRmd1emxWTG16NGYrV2NXN2Y0L1IvRE1E?= =?utf-8?B?cHNleU9VQkUwdGIwU00wYmJoandaYUdPMGsrQVRHbytrWjBCMGU0YUlTOFUy?= =?utf-8?B?VHRLMnl2eUkremxsdHZHUE9VS005WTJKajBCZEcyb05xTm9aR3RmNFhjMFZ6?= =?utf-8?B?WmZNektxR2xtOThiK2N3NEtKcjhCZGRSUWVwblNuT2Y4UUc5WXVZL09vTzNM?= =?utf-8?B?T25BZGk0Rk5tdVF0Tk1RK21lS2Y0Tlh5TjBUdis3T0FZTFFZTEFsNFVxWFpn?= =?utf-8?B?V01jaE9kamdENGQ0STdsT1J2aVZsNG9RalZiOG5Vc0RielhMaW1hVlRJd3d6?= =?utf-8?B?WDhXQzh3aWQzUWhzZDhsS2ZMUVErMS9GUE01ekdHVWp2bEVPSEVpYmRQNzhD?= =?utf-8?B?VEd0Y25rNlJsMStrR2Z4aGJUV1FiWnkvQ1RKT1NGcDEwOWR1YmNva2hZZ1M0?= =?utf-8?B?UkNYR0pzTlgrYjNQRVVWazdzbDBucVB2MTdNc1Ftc1BsM1pyc3V4cWN3ZThj?= =?utf-8?B?aURVbkFiN0YwUVBSMlFndW4wNmlvWEViQkhJSUdmSlRtZXg0K1hDYXhTQXFM?= =?utf-8?B?aDlmYVZQeis1a001R2NsUkxJQW0vR3ArcDcxdk5FRTZrOUZLd0ZqRlRYQUxq?= =?utf-8?B?amFNQVQ2UExWR1YySFFTUzg4c3ZlY1ZwYnJSMWE4WlhJZ2FhQ2tzVVZ6TXR0?= =?utf-8?B?QWJZNktVWVpPanMrazEzcnJlVGpOWklBdGVCMXA4Ty84U0J1eS9WOHZBOEkz?= =?utf-8?B?QmhpcjRnSFpwU1kxcWtwMDE5N2R6L1kyY2VieGxkOEJHSXltQzJRcm42RUE1?= =?utf-8?B?aWUrQWNQMDVvazJXdGNwMTczVlUyQ1Rkam5FekVXMnB4eDY4NHA0ZDFZUXR0?= =?utf-8?B?eWZaWVFNdEljM0I5aGtoY0NLV1hJb0dhdWZWRlFXVnZ3dWQrU2xHRUU2eXJF?= =?utf-8?B?dTJ5cytlUmRJeDJWOFlld0xiRWF2V05XckdlUUlITCtFWGRGY0tabUVsUk1a?= =?utf-8?B?U3FkYmxNeW5DRFNhSEdZUnlqUlYyZFdVZ3QySmZOUkVSalF5dTB0K01UTldy?= =?utf-8?B?SmtIUnVEYzJaMTNNbzdBRnJTYkhiMXltSUJVc2E1bXZURjN4T1ZVN2JwekVH?= =?utf-8?B?U0kzb1RydzBBdUkrZENpcmJNelRwcUFnTndFUEl5R013anNUNUxjRnhwUk5H?= =?utf-8?B?V0xTTlZmckdVUFgzTzZhRWNsd2ovV2h6SHVhV1lmaVlsbFU1eHNPVlp0eGw5?= =?utf-8?B?WUNjSlVDM0Zobll4L1FUdnIxVGtMYzg4bWpmc3g3clRiMDdxUk5MQ0hSTEJ0?= =?utf-8?B?UkpJWUZoeUdVdUxrWmduMFpuZkNMeUl0ZlZCcmR3NUUyZ242Ly9oVFBPemhv?= =?utf-8?B?aUI2YjBqcnBPaVc0NlZ2cU5zTTA5VVVZZWY0ZnN5YkgxVmxKYm1KQTZJZE9y?= =?utf-8?B?bUdSM1N6TFc3WjVCUTd3SVg4UUxiQVl5ZTNsbG9pdnZydnJSSE8wQlNLNHhw?= =?utf-8?B?WmtJa0JKQ1Y4Y0dlT0VKakhrOUdoVDNnK1M5Q1EzZSttTnV6aERLQ3FjNHdi?= =?utf-8?B?cTQ2V3JyVk9jeXBRME9OeE5yamJ0OEdza3hyNWhrRldGR1BnRG9jdTBXMmNJ?= =?utf-8?B?a1ZLV0xPbHZJNldSQWFnbHFxd3J0NU9uWjdNeU51UXJzZDBJOUN3VGlEWjVW?= =?utf-8?B?c0ZnZmNTY0tvZXdLQnVDdjQ4cERkWGRoK1JtU2lpMXQ0NVp3d0hUZ0cwTklG?= =?utf-8?B?S0t0ekh0NVJVcDNnSnpFQ01rdWpWY1VqdVE5M1VBVFJZKzJFNEVydDhjd3Uz?= =?utf-8?B?dlMxNWZRWk55Y3JIU2NubDNZZFcwY2RzZ1FjZmVLMC8xaUNTeGNMWVVFQkhC?= =?utf-8?Q?ownzBEqiWrHvFPD4LXGwL8WYs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e2c1a7c-65c4-4500-c550-08da9a286f15 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 10:19:28.0819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sxIda1CYewLq2HOdxRzneXv5srptydztKYIs1+jmqKbAm6qqNjx/ULRz7g/2mkQB5HAuDY2cWViD5fsNeSOMmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8607 On 15.09.2022 22:40, Jennifer Herbert wrote: First of all - please follow patch submission guidelines and send patches To: the list only, with maintainers Cc:-ed. > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -994,13 +994,22 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, > if ( !strncmp(xenstore_read("platform/acpi_laptop_slate", "0"), "1", 1) ) > config->table_flags |= ACPI_HAS_SSDT_LAPTOP_SLATE; > > - config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | > + config->table_flags |= (ACPI_HAS_TPM | ACPI_HAS_IOAPIC | > ACPI_HAS_WAET | ACPI_HAS_PMTIMER | > ACPI_HAS_BUTTONS | ACPI_HAS_VGA | > ACPI_HAS_8042 | ACPI_HAS_CMOS_RTC); Did you not mean to drop ACPI_HAS_TPM here when ... > config->acpi_revision = 4; > > - config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; > + s = xenstore_read("platform/tpm_version", "0"); > + config->tpm_version = strtoll(s, NULL, 0); > + > + switch( config->tpm_version ) > + { > + case 1: > + config->table_flags |= ACPI_HAS_TPM; ... you now OR it in here? Or else what use is this statement? As to the use of strtoll() - I realize we have nothing else in hvmloader, but I'm still weary of the overflow potential. Just a remark, not really something to act upon. > @@ -78,8 +78,8 @@ struct acpi_config { > struct acpi_numa numa; > const struct hvm_info_table *hvminfo; > > + uint8_t tpm_version; > const uint16_t *tis_hdr; > - > /* > * Address where acpi_info should be placed. > * This must match the OperationRegion(BIOS, SystemMemory, ....) Please don't remove the blank line here. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 10:29:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 10:29:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408680.651490 (Exim 4.92) (envelope-from ) id 1oaE1Z-0005v7-Qk; Mon, 19 Sep 2022 10:29:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408680.651490; Mon, 19 Sep 2022 10:29:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaE1Z-0005v0-My; Mon, 19 Sep 2022 10:29:13 +0000 Received: by outflank-mailman (input) for mailman id 408680; Mon, 19 Sep 2022 10:29:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaE1Y-0005uu-Hz for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 10:29:12 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4c8bdd5-3805-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 12:29:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4c8bdd5-3805-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663583350; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9fCOPYaZ+Rqod5rKTzTfHr0PwGZrUV8jtcxuaIG3Egw=; b=KUov7LBaHm9CObr4hi42Q1KyAielwXu0WlY8TLIJ3eLv86HYC4gvkUHR JKCxYOuwWCxPRs/ak3arIDAWKxdCE1dbCt8rYpwlWZZRbHbkNK/16TMvj etZ2lAAW5tDT/BwnN8uky+TXusenOJhl+0e/v6dcp2mvDVcMD8zGxE2k4 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80808917 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3ArWcM+q8SunMLI8aGxZkxDrVtTnXEUVd1BUUsT?= =?us-ascii?q?fz0RtKz9vc5HHgccn9MqfcsoEvDyjPWbcjPeUPEDOy0nFIVS4qThMgn+dHI8?= =?us-ascii?q?/TOagSf6BinscZLeqByQ9T2Meb45HdCtpm9kyXJWgOjiMBPd8tMiX2t0E8jF?= =?us-ascii?q?vLXOmJopbtxGav1y6Rx+8W1iVjZDzc4Ju9ySpg9uqFq423+QLxHaVt5IWsxX?= =?us-ascii?q?qeHgY7BXo+NbmzsUtdHKmb6kOZVuWAWjWzoQEHOyu4A2iGzq1zVgcPw72J47?= =?us-ascii?q?vbfuDeNK2OWH1jm5Z+MUcj9Pwqt1WlgaKE+woatzXaqGJbm7oN6l6/y0/OLN?= =?us-ascii?q?GK7eQF3+JDvr9bkAcATKOEshpCqndsltP72RoMK+IgM02kkuipNawOB1WW4T?= =?us-ascii?q?oAzY2fJ5oYtmyrpeipnm9LPSykZja3cRt00U+SohmjVz6nTnJK5ZK/q4LpxI?= =?us-ascii?q?C8jZalpiuWUGx16vtuulrwRtTvrF42HJmPV2zTLfRiSO7udxpfS6zU8M1Nas?= =?us-ascii?q?Fh1BnrMRDW5nqXav2IbnFXoVcUq+wLTHSfHNzdYIfLf1HK9DpLg6YZ/7vAPe?= =?us-ascii?q?WS+Nc+DtvftwIWxBSRxkoWtNVB00dook4JEOaTi2/rBpWqQcO31kkGGwsnAM?= =?us-ascii?q?qVM4+n1Q3z8RPQ6ddVUGggMwTX2qKFsZFw/ENC94S9altPLaduDPgl9iO9f1?= =?us-ascii?q?tV3ezlEy0s98qmvZpZxsruo+1OadaLCPPbQJWNymuQ2OIgbcQl2c1cC9qBex?= =?us-ascii?q?Uz9iD/untIfHN22JxrjJRmE4VXKZu2ABPPF52gnTUwDz5yp6GEVfSrbdoLyd?= =?us-ascii?q?qjAbPRtlSau0epvMQTdwZwqEJ7c4pRdSQHCPpOGdSl/oTvdI+9A7EG5d4kUO?= =?us-ascii?q?6UUBcAaR4z11uMLGfEMMi2nYTHnJYueXq7jcwTu2XvZPWxYWOgpn0ikq41RE?= =?us-ascii?q?lCHwfCpDof8lml/wFPpvEblw8BXyZCyYnF7wfAzmefr9lfLuia5ulFO4tR3G?= =?us-ascii?q?Fadi0v7oS3p9GisxUhqx/txHnZLySsQkM1mJXVPUu7SWy47cBpUITMs1BRH9?= =?us-ascii?q?OTBbWtbsO3VJOLqbOISfy16rTWSHp71YTP2OlBMJ6X5rSN0b6kgU+DHRtAgZ?= =?us-ascii?q?D1X1fpW2uimW6XrtDYW7Lsckaw8ejVCcziUOzEG8MMdKR84qGAogOwI8hqb1?= =?us-ascii?q?tdpUATr3GX7e94S38IUCT4Ds5BvOlc4Ui2v747ZXqRAe1YNlzlFnQ7b+JDMt?= =?us-ascii?q?R0mgCRmjQ/H43th12+TnU8nNEqKwSb8QOOoKxyOLua4N5a9Vkwx5bDvz4Sh9?= =?us-ascii?q?sdWA7EX55c6EXUgELpDT0+tt0HR4nSm8TRoMHCjOCwc6m/QSCgK0N6h21t0c?= =?us-ascii?q?6TX5RDksprB6FefypDf+PyAEqytysq0bljn0Qg2aqfifTU8C2592GMyO/4M1?= =?us-ascii?q?X3Oc2TNHGU/dA2AdNk+tHdKi+kEVbs2R7R+7WgLp1KOhbNz7hKwmY3oXuldh?= =?us-ascii?q?j6P0S518YoZDgc1W8kXDFoNxKlXIMhCibGD9x5DH/LYeOOCPact/1AndHj9A?= =?us-ascii?q?zv3HoeSRj3e6FuTpabfW03mcaqyBauz900E/w5ugZn78TknsCG5YynBX8IXy?= =?us-ascii?q?lIrOO4M6RAcG/+sSlVg8w61fbVLUYM21GJVAZm8SYClLv59YCVOpNm0xNP2z?= =?us-ascii?q?mObvzMZF/uaJoUgX0WFvfVjW0ogEz6wE3HFcFklHt8lfWMAWatlX/ynYBrHt?= =?us-ascii?q?PYYoCC6C0vngI5blbUmnEqyX6Zgqk6JhsUBcsI8hXiqatoprMXasFuVFHStW?= =?us-ascii?q?82eX47mExDSTvfN2/Z/XKy2SpizeGdvz8NbYK3N/sYyKFUXaq+izFr4H7I3n?= =?us-ascii?q?9CBqowAlHG0q9jZCLt3bAb7CjxY31rJlFsp3+UZN2XimJcv7eO5fX97KvYWK?= =?us-ascii?q?/t01TpdpiyJG6qlTsTpU4tLGJ0j1k7780ncYJctuzJ4mucsm30RyCq6HFnCb?= =?us-ascii?q?82z1Vj5fv4Q5TTQqZCSbEd9hyS8WQiKmn/fxHO/UIzNlTWL/3cPPRGTTXjOV?= =?us-ascii?q?uNpn/8j/ifVMrMvWXtqbHxA4oWQKXxc/zMjK+NgEkTRjJQhbEyBd5Nd3DII2?= =?us-ascii?q?qXSVorDyF2rxlrePbPjnANEU3zLd3dm+FKiyj9jbsL1ZQDHYt+R6jZMXr4fk?= =?us-ascii?q?O2TI/UKnN7B+lwKETf4YrTcqEt33Y9GUmW/cwtTtP2+isbBA1xjv8hUKb+jY?= =?us-ascii?q?D6H0ANCThMHnGsj5A3bjmj0VA0mhjSFenMynH/FS9D+aU6I0TXJk1Rs2XwuY?= =?us-ascii?q?VIeov7cTRrqM2A901XFFeRYZufcMRJptdQ1LNRHE/DTMwgxYHqSvLpdfSyja?= =?us-ascii?q?zyfFc7UNi/5LOQALzv4l2zFvAxoW0xAGT9D3R4flJqhP4qQLZ24MX/dzyQro?= =?us-ascii?q?qP/WZbI+H2/wS55GJOGQZ1UTSnLC6zIuxEt6eeEN61yPHQ2w1EF6GYukVIWl?= =?us-ascii?q?hgFGdabxQGlLtodd+XNM386Y2VhabwHR4/W4sCYbWJq4QSCmsYivTL9efvka?= =?us-ascii?q?5oOiabzAoX5en29QdYqejBkiLf8bQmmxMW6CTZBhpEGVyzjALCLqRviYf6vm?= =?us-ascii?q?irZwXwu4CvvLVnyMUuw8lqSjT/nYWWuLdA5Q8ptSLi10Z/LZCKW8vo+68tWg?= =?us-ascii?q?l4T30+AUzruILluVFIVMWTSXHo4f/bBO6c6U+6yXm87phev16MzaRN62C2oz?= =?us-ascii?q?iQ+3v/m2W2FIRgiqGaUq4fgQ6Tv91pbAve4EfsqrTmfVjeYbHj0KBzgMdbC7?= =?us-ascii?q?tXqNaHsmeDmjoPpw1Wekx+yHJq2GInI5KgVfEh9mTx1kkd2eFpB/pBVrFzWf?= =?us-ascii?q?GsK5ZOkN+ODIpvgDNuMbMfTEGv2J0hyUP7pFXK0tFj/TsSORvq2kxtWxZIOo?= =?us-ascii?q?vVMqvsFZmx/rdW11n3HJJn0xjGtuTKY2qBwgtL3j/BVcqhS7g+GUOnTmeQZo?= =?us-ascii?q?xPNCwGDEOz/72Z2qhijbCbpUjs+v1nDJbTjeGkULfQU?= X-IronPort-AV: E=Sophos;i="5.93,327,1654574400"; d="scan'208";a="80808917" From: Anthony PERARD To: CC: Wei Chen , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH v3] build: Fix x86 out-of-tree build without EFI Date: Mon, 19 Sep 2022 11:28:31 +0100 Message-ID: <20220919102831.17438-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain We can't have a source file with the same name that exist in both the common code and in the arch specific code for efi/. This can lead to confusion in make and it can pick up the wrong source file. This issue lead to a failure to build a pv-shim for x86 out-of-tree, as this is one example of an x86 build using the efi/stub.c. The issue is that in out-of-tree, make might find x86/efi/stub.c via VPATH, but as the target needs to be rebuilt due to FORCE, make actually avoid changing the source tree and rebuilt the target with VPATH ignored, so $@ lead to the build tree where "stub.c" doesn't exist yet so a link is made to "common/stub.c". Rework the new common/stub.c file to have a different name than the already existing one, by renaming the existing one. We can hide the compat aliases that x86 uses behind CONFIG_COMPAT so a Arm build will not have them. Also revert the change to the rule that creates symbolic links it's better to just recreate the link in cases where an existing file exist or the link goes to the wrong file. Avoid using $(EFIOBJ-y) as an alias for $(clean-files), add "stub.c" directly to $(clean-files). Also update .gitignore as this was also missing from the original patch. Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- Notes: v3: - back to using common-stub.c - include the x86 compat function alias in common-stub.c but guard them with CONFIG_COMPAT v2: - instead of renaming common/efi/stub.c to common_stub.c; we rename arch/*/efi/stub.c to stub.h and include it from common/stub.c - update .gitignore CC: Wei Chen xen/arch/arm/efi/Makefile | 6 +----- xen/arch/x86/efi/Makefile | 2 +- xen/common/efi/efi-common.mk | 4 ++-- xen/arch/x86/efi/stub.c | 7 ------- xen/common/efi/{stub.c => common-stub.c} | 10 ++++++++++ .gitignore | 1 + 6 files changed, 15 insertions(+), 15 deletions(-) rename xen/common/efi/{stub.c => common-stub.c} (64%) diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile index bd954a3b2d..2459cbae3a 100644 --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -4,11 +4,7 @@ ifeq ($(CONFIG_ARM_EFI),y) obj-y += $(EFIOBJ-y) obj-$(CONFIG_ACPI) += efi-dom0.init.o else -# Add stub.o to EFIOBJ-y to re-use the clean-files in -# efi-common.mk. Otherwise the link of stub.c in arm/efi -# will not be cleaned in "make clean". -EFIOBJ-y += stub.o -obj-y += stub.o +obj-y += common-stub.o $(obj)/stub.o: CFLAGS-y += -fno-short-wchar diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile index 034ec87895..24dfecfad1 100644 --- a/xen/arch/x86/efi/Makefile +++ b/xen/arch/x86/efi/Makefile @@ -11,7 +11,7 @@ $(obj)/boot.init.o: $(obj)/buildid.o $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4) $(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS_stack_boundary := $(cflags-stack-boundary) -obj-y := stub.o +obj-y := common-stub.o stub.o obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y)) obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y)) extra-$(XEN_BUILD_EFI) += buildid.o relocs-dummy.o diff --git a/xen/common/efi/efi-common.mk b/xen/common/efi/efi-common.mk index ec2c34f198..53fdb81583 100644 --- a/xen/common/efi/efi-common.mk +++ b/xen/common/efi/efi-common.mk @@ -9,9 +9,9 @@ CFLAGS-y += -iquote $(srcdir) # e.g.: It transforms "dir/foo/bar" into successively # "dir foo bar", ".. .. ..", "../../.." $(obj)/%.c: $(srctree)/common/efi/%.c FORCE - $(Q)test -f $@ || \ - ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( #include #include -#include "../../../common/efi/stub.c" /* * Here we are in EFI stub. EFI calls are not supported due to lack @@ -55,9 +54,3 @@ bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) } void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { } - -int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *) - __attribute__((__alias__("efi_get_info"))); - -int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *) - __attribute__((__alias__("efi_runtime_call"))); diff --git a/xen/common/efi/stub.c b/xen/common/efi/common-stub.c similarity index 64% rename from xen/common/efi/stub.c rename to xen/common/efi/common-stub.c index 15694632c2..5a91fe28cc 100644 --- a/xen/common/efi/stub.c +++ b/xen/common/efi/common-stub.c @@ -30,3 +30,13 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op) { return -ENOSYS; } + +#ifdef CONFIG_COMPAT + +int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *) + __attribute__((__alias__("efi_get_info"))); + +int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *) + __attribute__((__alias__("efi_runtime_call"))); + +#endif diff --git a/.gitignore b/.gitignore index af9bf749c4..98adcf02ad 100644 --- a/.gitignore +++ b/.gitignore @@ -280,6 +280,7 @@ xen/arch/*/efi/ebmalloc.c xen/arch/*/efi/efi.h xen/arch/*/efi/pe.c xen/arch/*/efi/runtime.c +xen/arch/*/efi/common-stub.c xen/arch/*/include/asm/asm-offsets.h xen/common/config_data.S xen/common/config.gz -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 19 10:30:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 10:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408685.651501 (Exim 4.92) (envelope-from ) id 1oaE3A-0007Gt-5N; Mon, 19 Sep 2022 10:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408685.651501; Mon, 19 Sep 2022 10:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaE3A-0007Gm-1g; Mon, 19 Sep 2022 10:30:52 +0000 Received: by outflank-mailman (input) for mailman id 408685; Mon, 19 Sep 2022 10:30:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaE39-0007EJ-3T for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 10:30:51 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2041.outbound.protection.outlook.com [40.107.21.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 216e8d6f-3806-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 12:30:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9289.eurprd04.prod.outlook.com (2603:10a6:20b:4e4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Mon, 19 Sep 2022 10:30:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 10:30:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 216e8d6f-3806-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hExYrSg6/TBs4hlj3oNh/4rKbOfYZayuMElHZAe6Xg4qT3rqbMPhSvXuxeXie5Lv7ylCZZ/eqTbLH/JgdkLWvpKHOw74shi9SAGAehKur22AsIPKuW3FglrzsTgfRjo9BEJf6rMtJo+yKLxLB8C1J9cjNFlslHij6NWQ3CAOM51/Tb4StoIxOh0qvxldKchWIIvTCDZW6fsbIMcKRTJ8cCthUN/HNNOSKDRPR94S8ZoODUWVgl0wGpdkPy8MW4cN+m8Oq8vy5awWarCiQceemrzAJJRrvkvdGWSZz7mex1p0XFQLRXBcyY4mORV9Pq0pjUyOnOBUrTpovirGHQwzVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dr+IfXt0NMB0EKOt8VY3rXX1XSMAnYxBCKrKyzgMbOU=; b=iw/SRyyTaIvfm9HKSlEm/UivwFY4i2f7jcjFKi/z6Qhx5QjqNAk4joz+2gGCuTz7j+O3/noJ7WQxhMIg1ITAB1AkD4JC7V1kP4e8oS/EhJAh1ZS4e27pVPO4ZUKFqvW5UFtXdTHcxbXEjb8henxk7R8p53iYRsLukWXRai+qtV4qL6qvKrNFoAd6SbyiL6/T7oLlAyU8BgBjymXQ083yVERufGrSWULGX8CjvZry/rGasFyot9CL8o31uvswIyNX/ojkBdHGK1NKkca1t3Tovo/xw1OB+WIQYMoRboenKFdG95vEhiliAlZoVT2OkCSJR/cA+MGhVO/soyRTTHJk6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dr+IfXt0NMB0EKOt8VY3rXX1XSMAnYxBCKrKyzgMbOU=; b=XPjXtEJ/S1QzG4SRw832kwnVqp/uhqPFRFHrfm3+w33q9ZTed0raM4Lezr4TW+oOSPT8RavydGtqv6BdV3OK2aI/eQPUgVCv/A2UNl9lHpBbAmdwWRlnFaocpC2MdsOy6yqf9StFetPqEuyw26yti48D4oVE1qTGqVHtEuuktqPOX7nK6vI8Kim7UFWaNcL+N1rphOT6WTSUMvupU78zh4OwHb8XepKRXUpstsuWwDyA2OKMUtIPDtqfC915LcOf6el0DOKApj3RXUmjJd3zit3+UCxnadRN3wUPJhGg4EK5n3LyyWO5/4gCgJgu6ZHjY6W5nLsF0FH5dM9po2OowQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 19 Sep 2022 12:30:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/2] acpi: Add TPM2 interface definition. Content-Language: en-US To: Jennifer Herbert Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, wl@xen.org, roger.pau@citrix.com References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> <20220915204029.1227112-1-jennifer.herbert@citrix.com> <20220915204029.1227112-2-jennifer.herbert@citrix.com> From: Jan Beulich In-Reply-To: <20220915204029.1227112-2-jennifer.herbert@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0489.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9289:EE_ X-MS-Office365-Filtering-Correlation-Id: cdb9b700-31dc-4d1d-70e4-08da9a2a0474 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0I7Jh2o9XTzsjaQS2hzyEHxGEOy45u9nmoCK4utyyawqRnulqUh45GpXS5ymdp/WYQN/OGarDV/WRRZ2xc8FG7Z8uCEt/PRSW/VWcWNJw5KB6nP8OSvPvEQmIfQNmVjkC/HuDs/j2THSpDdF+Ry9UXQjP5gkzLw9da4rrqRGrt4rFXvYl+BrlJos+3C8fUzHIk3ibBqB+ngs8ntY/oGM54+mMit6+M7ViVG0Az1A3CYh9ntTkfRFsO94uhYbromaITrkD8PNG7V1lBYOwyWrsottOz7A3lZ96pFzp7gOKuo3Dmo+BAIaKdK04KqRiKeqoAGqbLdf20raLJP4s/XQnIiZBkJJzK5cneaw4SBB+9oiB+P8GY2mfpkPE62obNMSMTSsCVBY8c/NmRmoJEigC1Bmmx2TPO+/gj9A4VhUjXxu6a9H/+f3+slNrPfcnqnfS1GDj3ZB/mroTbBJi1SQyYhkykC2AwZOyCG+Uy/2TvNzzg4Nvovluell3ESahAY4rCaWJ94epJ2VRilM946RrtM7E82n4roxPzHad6lMf3aMGvUeBiCmz5YqmbM+vDNZiqIypspLqrZ8SVJGnrqw9cFoKlHxndBnIm88J/xrIiFnmcGXxKnAkwkqwqNBjh/iqspqNdif+d67DzTR2sCuy1NjegTxhb8HhkSQ4Uk6C7dvyH+U+/xPsXQzPUUSfAWqRRWIi7mF2gzPfI2PoiaOl4A56HU3ZUAh+/e7NNDOA0ZgFRsVC34egwzWWsMC42fY0CS2e7r5E5fENCswNaNq0P2yMSl6lysvuh0vKu2dbjc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(346002)(136003)(366004)(451199015)(31686004)(6506007)(41300700001)(53546011)(6512007)(36756003)(8936002)(478600001)(6486002)(26005)(2906002)(2616005)(316002)(186003)(31696002)(6916009)(86362001)(5660300002)(8676002)(66946007)(66476007)(4326008)(38100700002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEdUSHh5SUcvQnVOTEhXQTJVZ3hkWFlBVEYwT01pV0dSSC9OYys3SCtBbDJh?= =?utf-8?B?UXh0UmpzWEo0eUdrVURLdStlRlJKNG1IUmZVSHY1Y0ZvcEJiWDJpWmZUZDRZ?= =?utf-8?B?cXZpVldzYk5lSDRpcVJueHVHQnM3SUwrcmxocjJOa3RwcTBGMGdLN3M2WnlM?= =?utf-8?B?M1I0MFk2TjRUYW56RXNrckRYQWRGbm4wbk1WZXhGSHNlQ0VtcHpjdlRtMkdS?= =?utf-8?B?S2g2WDdEV3VBMFRyUmpka3BqbzBtckxvQm1RbzFUU2piVjdKekFrZUVFL3RT?= =?utf-8?B?cU9JRGliLzBEaUJYbm9ITy9VR1Y3eWpSY2xvTlFKMGM3VXh0VVN3ajEvTzdt?= =?utf-8?B?K2pzWmJ4THRiUDBaaW1xcWI1VDJVUFBxR0tZeTlzbXFXQmxVQ3dlbUpNK21l?= =?utf-8?B?S2ZTZXIreGJURmJqaVhWd3VzSHpxQW9xL2VIZDVzaGJieFlReC9nRCtpM1V2?= =?utf-8?B?VFNNMDVxQ0I0MFl2aSswZnNwY3FZcERJR2k0YU5GTm14V1piTVBQbmp5dGla?= =?utf-8?B?QjliVkNYS1BBNmRUQXlpVkE0dVJObWxTbnN0dUlENjFsVWVRNjFmdWZFVkxu?= =?utf-8?B?SWVsNWszT3pRSXpLQjNzTWd2S2dhTjAyd09adU5QZzFsSUljYUlCZ3pZL0dM?= =?utf-8?B?VGVhTXhWaXpYMEdyYUorSC9jellMTkNNVVM4STZPZThvaDA5Ymt4VzBZQ0o2?= =?utf-8?B?aUlwVkdUK2ZXYitRdHFlQ0hkM1NzTEdtK3hLWE9leFh3Y1grTi8zem5BWFU3?= =?utf-8?B?TDg2UUl5cHhySHFlRlI3bGw1bmxqUm1JY2t2dVBtaTBjc0l2WnlOeFQrTjBr?= =?utf-8?B?TmY3QjVlQzg5TkhpZTZZU0ltSmcwUFJKSXp1UmF3NElnemxOaytNb1R6TGNN?= =?utf-8?B?MVZJdVFFRmtpQ3h5a21rQk0xTXh1VEUyRkFjTmE1bXMyS0JQRFhvRDVNN1Rw?= =?utf-8?B?dGNLblA1VjVIRjBvSjg1aVNzSEFqSlZwcjF5Nm9Ja3owZ1lpdHkwTjBTOEI1?= =?utf-8?B?UGNEc2phNFJxaTl5cUdVNGxlSUM5R2lwWWc3ZDdjc3hIZUIxZW9CSkY0VWJ4?= =?utf-8?B?bm82Z2hNRHd2bFNHdDlFY3NxLzJCRHNhdWVIZ2RLNHBqWHhKNDlUbGRlM2lW?= =?utf-8?B?aUZyQXQ4Y1FyVWxiSzF0aFJiZHc3WXE3RzhTN2x1K0MvUUN0bHZFUjFWL0FS?= =?utf-8?B?dG1UUlozejV0YzRoT1duWFNxckZ0Sml6Vm1XK0VyRWttUi9DYkVDL2NPcDdi?= =?utf-8?B?OHZmTDNZR210Vk8zOXFzeCtYSW9xd3JTY2o2MzVvMFRTdGdBTE5ZWTl3azZi?= =?utf-8?B?SmdQSlJKVG5OVUhLWTNuSXpwa0ZXVDZnUmoxMzB3VmdwakpLWkVldXpUd2R4?= =?utf-8?B?MU5iYXQ4eWhaRnpKNEZxK1Bjd3BGLzFyY0lzdDVIeWxNOHErY09qVWt3cG1V?= =?utf-8?B?MktlMjIwMnI3cStlOXExcWU2cFdseGkvNVhtNFNIU2FkdHlOd0JnbXNweFY1?= =?utf-8?B?bFJnTFBSalhvVmZLN0dyQ3ZVcmdEK3ZRWmk3amNpcEFQeXpOVjhNWlU5Rito?= =?utf-8?B?UnZyU3ZtWkZqckt5TllZdGJldW5VTzg0dVovaFgxZTlkOWJjWWtObTFvVStu?= =?utf-8?B?VXdHc1VBS29pWlFiNjBYTlI3NHZXeU9leHNrS2pPVnl3UGQweFBnZUxSb3JW?= =?utf-8?B?Y2dRclhzcUVaK3RocytXbUhDOW5waGFMVWkyaXdmN212MTRWZlVacU4vbWV5?= =?utf-8?B?amI3dDFOdjEzZ2NqTVYyaFBPQU5OaXk5ZmJidU1Mb1R5aGVuRWlOTVBGTVMv?= =?utf-8?B?RnVrVFZpc1dhRGV6cHdZTzBtR3k3RGRjNENLb092VnJaV1NpLzlZY0VneVd6?= =?utf-8?B?dWdPbWRrTnBLQXhBTlBOaWFJRVZrVnhIU2d0ZHJ3ZGFUdGNEQ3p0T3FyRnRu?= =?utf-8?B?MHc3NWNxdGpHSTMzWXRiQmRWNm00a25pMDBnSGRVNXB3cXc0UWtCZUxSV3Ni?= =?utf-8?B?U0MzM3I3TG9jMVhLOExKb3JndkRMNUt3VThUKzlzWUxIUFdhVzlPejdPR0ly?= =?utf-8?B?NW1mOUhHVWIzalh6OTFDaTN4Z3VCaFlFbDg3bHVFWEhob3hTUVdEeGErMkpr?= =?utf-8?Q?Sezy4XcRkX11FxX8sGxtiWxNf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdb9b700-31dc-4d1d-70e4-08da9a2a0474 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 10:30:48.1796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wiQnWjRYGadiAursxbQFK3ZCueW0E45k9KW2+fMPRge0TIu2G45HIncgmv2sZtaJpcVmUHjd+1NPZZGfhhkauQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9289 On 15.09.2022 22:40, Jennifer Herbert wrote: > --- a/tools/firmware/hvmloader/config.h > +++ b/tools/firmware/hvmloader/config.h > @@ -56,6 +56,7 @@ extern uint8_t ioapic_version; > #define PCI_ISA_IRQ_MASK 0x0c20U /* ISA IRQs 5,10,11 are PCI connected */ > > #define ACPI_TIS_HDR_ADDRESS 0xFED40F00UL > +#define ACPI_CRB_HDR_ADDRESS 0xFED40034UL I understand it may not be feasible to express this here as a proper derivation from other constants, but then you want to have a BUILD_BUG_ON() somewhere making (and guaranteeing) the connection. Thi may of course involve moving the #define to a header which both hvmloader and libacpi can (legitimately) include. > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -1009,6 +1009,13 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, > config->table_flags |= ACPI_HAS_TPM; > config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS; > break; > + case 2: > + config->table_flags |= ACPI_HAS_TPM; > + config->crb_hdr = (uint16_t *)ACPI_CRB_HDR_ADDRESS; > + > + mem_hole_populate_ram(TPM_LOG_AREA_ADDRESS >> PAGE_SHIFT, TPM_LOG_SIZE >> PAGE_SHIFT); Nit: Long line. > + memset((void *)(TPM_LOG_AREA_ADDRESS), 0, TPM_LOG_SIZE); No need to parenthesize the operand of the cast? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 10:32:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 10:32:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408692.651512 (Exim 4.92) (envelope-from ) id 1oaE58-0007rq-HP; Mon, 19 Sep 2022 10:32:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408692.651512; Mon, 19 Sep 2022 10:32:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaE58-0007rj-EW; Mon, 19 Sep 2022 10:32:54 +0000 Received: by outflank-mailman (input) for mailman id 408692; Mon, 19 Sep 2022 10:32:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaE56-0007rZ-M6 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 10:32:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69a913b9-3806-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 12:32:51 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 39A4B220F4; Mon, 19 Sep 2022 10:32:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8DEF13A96; Mon, 19 Sep 2022 10:32:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1hBHN1JFKGPrcgAAMHmgww (envelope-from ); Mon, 19 Sep 2022 10:32:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69a913b9-3806-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663583571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7mvLW9LotoDgDB6BsSj7jpHjmR0P2hhEFaL5fVZtX90=; b=sDu7boVgTSMd4sISRSooQBNhyVK6FxYZXxZYs87cUz93bxIsnTWlWk5bQ6IOQs8yu6ie9q kEQ9i1HbTNdFFqXLLgaYbdRPZXPQ2ceE7YoJwF7zkQRLpnS80K0yrJyzgOPGmA5huv7IF7 99CocNJxi4A47f3/efq37TL8vzvfjTA= Message-ID: Date: Mon, 19 Sep 2022 12:32:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/2] xen/gntdev: Accommodate VMA splitting Content-Language: en-US To: "M. Vefa Bicakci" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann References: <20220912040002.198191-1-m.v.b@runbox.com> <20220912040002.198191-3-m.v.b@runbox.com> From: Juergen Gross In-Reply-To: <20220912040002.198191-3-m.v.b@runbox.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------taO9UrUHsRh2N1i26QA65PFP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------taO9UrUHsRh2N1i26QA65PFP Content-Type: multipart/mixed; boundary="------------6q5orJvlsQYaVIVVg9B4f2nF"; protected-headers="v1" From: Juergen Gross To: "M. Vefa Bicakci" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann Message-ID: Subject: Re: [PATCH 2/2] xen/gntdev: Accommodate VMA splitting References: <20220912040002.198191-1-m.v.b@runbox.com> <20220912040002.198191-3-m.v.b@runbox.com> In-Reply-To: <20220912040002.198191-3-m.v.b@runbox.com> --------------6q5orJvlsQYaVIVVg9B4f2nF Content-Type: multipart/mixed; boundary="------------WLb5L0dbJE4aWejsnRRU0psh" --------------WLb5L0dbJE4aWejsnRRU0psh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMDY6MDAsIE0uIFZlZmEgQmljYWtjaSB3cm90ZToNCj4gUHJpb3IgdG8g dGhpcyBjb21taXQsIHRoZSBnbnRkZXYgZHJpdmVyIGNvZGUgZGlkIG5vdCBoYW5kbGUgdGhl DQo+IGZvbGxvd2luZyBzY2VuYXJpbyBjb3JyZWN0bHk6DQo+IA0KPiAqIFVzZXIgcHJvY2Vz cyBzZXRzIHVwIGEgZ250ZGV2IG1hcHBpbmcgY29tcG9zZWQgb2YgdHdvIGdyYW50IG1hcHBp bmdzDQo+ICAgIChpLmUuLCB0d28gcGFnZXMgc2hhcmVkIGJ5IGFub3RoZXIgWGVuIGRvbWFp bikuDQo+ICogVXNlciBwcm9jZXNzIG11bm1hcCgpcyBvbmUgb2YgdGhlIHBhZ2VzLg0KPiAq IFVzZXIgcHJvY2VzcyBtdW5tYXAoKXMgdGhlIHJlbWFpbmluZyBwYWdlLg0KPiAqIFVzZXIg cHJvY2VzcyBleGl0cy4NCj4gDQo+IEluIHRoZSBzY2VuYXJpbyBhYm92ZSwgdGhlIHVzZXIg cHJvY2VzcyB3b3VsZCBjYXVzZSB0aGUga2VybmVsIHRvIGxvZw0KPiB0aGUgZm9sbG93aW5n IG1lc3NhZ2VzIGluIGRtZXNnIGZvciB0aGUgZmlyc3QgbXVubWFwKCksIGFuZCB0aGUgc2Vj b25kDQo+IG11bm1hcCgpIGNhbGwgd291bGQgcmVzdWx0IGluIHNpbWlsYXIgbG9nIG1lc3Nh Z2VzOg0KPiANCj4gICAgQlVHOiBCYWQgcGFnZSBtYXAgaW4gcHJvY2VzcyBkb3VibGVtYXAu dGVzdCAgcHRlOi4uLiBwbWQ6Li4uDQo+ICAgIHBhZ2U6MDAwMDAwMDA1N2M5N2JmZiByZWZj b3VudDoxIG1hcGNvdW50Oi0xIFwNCj4gICAgICBtYXBwaW5nOjAwMDAwMDAwMDAwMDAwMDAg aW5kZXg6MHgwIHBmbjouLi4NCj4gICAgLi4uDQo+ICAgIHBhZ2UgZHVtcGVkIGJlY2F1c2U6 IGJhZCBwdGUNCj4gICAgLi4uDQo+ICAgIGZpbGU6Z250ZGV2IGZhdWx0OjB4MCBtbWFwOmdu dGRldl9tbWFwIFt4ZW5fZ250ZGV2XSByZWFkcGFnZToweDANCj4gICAgLi4uDQo+ICAgIENh bGwgVHJhY2U6DQo+ICAgICA8VEFTSz4NCj4gICAgIGR1bXBfc3RhY2tfbHZsKzB4NDYvMHg1 ZQ0KPiAgICAgcHJpbnRfYmFkX3B0ZS5jb2xkKzB4NjYvMHhiNg0KPiAgICAgdW5tYXBfcGFn ZV9yYW5nZSsweDdlNS8weGRjMA0KPiAgICAgdW5tYXBfdm1hcysweDc4LzB4ZjANCj4gICAg IHVubWFwX3JlZ2lvbisweGE4LzB4MTEwDQo+ICAgICBfX2RvX211bm1hcCsweDFlYS8weDRl MA0KPiAgICAgX192bV9tdW5tYXArMHg3NS8weDEyMA0KPiAgICAgX194NjRfc3lzX211bm1h cCsweDI4LzB4NDANCj4gICAgIGRvX3N5c2NhbGxfNjQrMHgzOC8weDkwDQo+ICAgICBlbnRy eV9TWVNDQUxMXzY0X2FmdGVyX2h3ZnJhbWUrMHg2MS8weGNiDQo+ICAgICAuLi4NCj4gDQo+ IEZvciBlYWNoIG11bm1hcCgpIGNhbGwsIHRoZSBYZW4gaHlwZXJ2aXNvciAoaWYgYnVpbHQg d2l0aCBDT05GSUdfREVCVUcpDQo+IHdvdWxkIHByaW50IG91dCB0aGUgZm9sbG93aW5nIGFu ZCB0cmlnZ2VyIGEgZ2VuZXJhbCBwcm90ZWN0aW9uIGZhdWx0IGluDQo+IGRvbTA6DQo+IA0K PiAgICAoWEVOKSBkMHYuLi4gQXR0ZW1wdCB0byBpbXBsaWNpdGx5IHVubWFwIGQwJ3MgZ3Jh bnQgUFRFIC4uLg0KPiAgICAoWEVOKSBkMHYuLi4gQXR0ZW1wdCB0byBpbXBsaWNpdGx5IHVu bWFwIGQwJ3MgZ3JhbnQgUFRFIC4uLg0KPiANCj4gQXMgb2YgdGhpcyB3cml0aW5nLCBnbnRk ZXZfZ3JhbnRfbWFwIHN0cnVjdHVyZSdzIHZtYSBmaWVsZCAocmVmZXJyZWQgdG8NCj4gYXMg bWFwLT52bWEgYmVsb3cpIGlzIG1haW5seSB1c2VkIGZvciBjaGVja2luZyB0aGUgc3RhcnQg YW5kIGVuZA0KPiBhZGRyZXNzZXMgb2YgbWFwcGluZ3MuIEhvd2V2ZXIsIHdpdGggc3BsaXQg Vk1BcywgdGhlc2UgbWF5IGNoYW5nZSwgYW5kDQo+IHRoZXJlIGNvdWxkIGJlIG1vcmUgdGhh biBvbmUgVk1BIGFzc29jaWF0ZWQgd2l0aCBhIGdudGRldiBtYXBwaW5nLg0KPiBIZW5jZSwg cmVtb3ZlIHRoZSB1c2Ugb2YgbWFwLT52bWEgYW5kIHJlbHkgb24gbWFwLT5wYWdlc192bV9z dGFydCBmb3INCj4gdGhlIG9yaWdpbmFsIHN0YXJ0IGFkZHJlc3MgYW5kIG9uIChtYXAtPmNv dW50IDw8IFBBR0VfU0hJRlQpIGZvciB0aGUNCj4gb3JpZ2luYWwgbWFwcGluZyBzaXplLiBM ZXQgdGhlIGludmFsaWRhdGUoKSBhbmQgZmluZF9zcGVjaWFsX3BhZ2UoKQ0KPiBob29rcyB1 c2UgdGhlc2UuDQo+IA0KPiBBbHNvLCBnaXZlbiB0aGF0IHRoZXJlIGNhbiBiZSBtdWx0aXBs ZSBWTUFzIGFzc29jaWF0ZWQgd2l0aCBhIGdudGRldg0KPiBtYXBwaW5nLCBtb3ZlIHRoZSAi bW11X2ludGVydmFsX25vdGlmaWVyX3JlbW92ZSgmbWFwLT5ub3RpZmllcikiIGNhbGwgdG8N Cj4gdGhlIGVuZCBvZiBnbnRkZXZfcHV0X21hcCwgc28gdGhhdCB0aGUgTU1VIG5vdGlmaWVy IGlzIG9ubHkgcmVtb3ZlZA0KPiBhZnRlciB0aGUgY2xvc2luZyBvZiB0aGUgbGFzdCByZW1h aW5pbmcgVk1BLg0KPiANCj4gRmluYWxseSwgdXNlIGFuIGF0b21pYyB0byBwcmV2ZW50IGlu YWR2ZXJ0ZW50IGdudGRldiBtYXBwaW5nIHJlLXVzZSwNCj4gaW5zdGVhZCBvZiB1c2luZyB0 aGUgbWFwLT5saXZlX2dyYW50cyBhdG9taWMgY291bnRlciBhbmQvb3IgdGhlIG1hcC0+dm1h DQo+IHBvaW50ZXIgKHRoZSBsYXR0ZXIgb2Ygd2hpY2ggaXMgbm93IHJlbW92ZWQpLiBUaGlz IHByZXZlbnRzIHRoZQ0KPiB1c2Vyc3BhY2UgZnJvbSBtbWFwKCknaW5nICh3aXRoIE1BUF9G SVhFRCkgYSBnbnRkZXYgbWFwcGluZyBvdmVyIHRoZQ0KPiBzYW1lIGFkZHJlc3MgcmFuZ2Ug YXMgYSBwcmV2aW91c2x5IHNldCB1cCBnbnRkZXYgbWFwcGluZy4gVGhpcyBzY2VuYXJpbw0K PiBjYW4gYmUgc3VtbWFyaXplZCB3aXRoIHRoZSBmb2xsb3dpbmcgY2FsbC10cmFjZSwgd2hp Y2ggd2FzIHZhbGlkIHByaW9yDQo+IHRvIHRoaXMgY29tbWl0Og0KPiANCj4gICAgbW1hcA0K PiAgICAgIGdudGRldl9tbWFwDQo+ICAgIG1tYXAgKHJlcGVhdCBtbWFwIHdpdGggTUFQX0ZJ WEVEIG92ZXIgdGhlIHNhbWUgYWRkcmVzcyByYW5nZSkNCj4gICAgICBnbnRkZXZfaW52YWxp ZGF0ZQ0KPiAgICAgICAgdW5tYXBfZ3JhbnRfcGFnZXMgKHNldHMgJ2JlaW5nX3JlbW92ZWQn IGVudHJpZXMgdG8gdHJ1ZSkNCj4gICAgICAgICAgZ250dGFiX3VubWFwX3JlZnNfYXN5bmMN Cj4gICAgICB1bm1hcF9zaW5nbGVfdm1hDQo+ICAgICAgZ250ZGV2X21tYXAgKG1hcHMgdGhl IHNoYXJlZCBwYWdlcyBhZ2FpbikNCj4gICAgbXVubWFwDQo+ICAgICAgZ250ZGV2X2ludmFs aWRhdGUNCj4gICAgICAgIHVubWFwX2dyYW50X3BhZ2VzDQo+ICAgICAgICAgIChuby1vcCBi ZWNhdXNlICdiZWluZ19yZW1vdmVkJyBlbnRyaWVzIGFyZSB0cnVlKQ0KPiAgICAgIHVubWFw X3NpbmdsZV92bWEgKFhlbiByZXBvcnRzIHRoYXQgYSBncmFudGVkIHBhZ2UgaXMgYmVpbmcN Cj4gICAgICAgIHVubWFwcGVkIGFuZCB0cmlnZ2VycyBhIGdlbmVyYWwgcHJvdGVjdGlvbiBm YXVsdCBpbiBkb20wDQo+ICAgICAgICBpZiBYZW4gd2FzIGJ1aWx0IHdpdGggQ09ORklHX0RF QlVHKQ0KPiANCj4gVGhlIGZpeCBmb3IgdGhpcyBsYXN0IHNjZW5hcmlvIGNvdWxkIGJlIHdv cnRoIGl0cyBvd24gY29tbWl0LCBidXQgd2UNCj4gb3B0ZWQgZm9yIGEgc2luZ2xlIGNvbW1p dCwgYmVjYXVzZSByZW1vdmluZyB0aGUgZ250ZGV2X2dyYW50X21hcA0KPiBzdHJ1Y3R1cmUn cyB2bWEgZmllbGQgcmVxdWlyZXMgZ3VhcmRpbmcgdGhlIGVudHJ5IHRvIGdudGRldl9tbWFw KCksIGFuZA0KPiB0aGUgbGl2ZV9ncmFudHMgYXRvbWljIGNvdW50ZXIgaXMgbm90IHN1ZmZp Y2llbnQgb24gaXRzIG93biB0byBwcmV2ZW50DQo+IHRoZSBtbWFwKCkgb3ZlciBhIHByZS1l eGlzdGluZyBtYXBwaW5nLg0KPiANCj4gTGluazogaHR0cHM6Ly9naXRodWIuY29tL1F1YmVz T1MvcXViZXMtaXNzdWVzL2lzc3Vlcy83NjMxDQo+IEZpeGVzOiBhYjMxNTIzYzJmY2EgKCJ4 ZW4vZ250ZGV2OiBhbGxvdyB1c2VybW9kZSB0byBtYXAgZ3JhbnRlZCBwYWdlcyIpDQo+IENj OiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+IFNpZ25lZC1vZmYtYnk6IE0uIFZlZmEgQmlj YWtjaSA8bS52LmJAcnVuYm94LmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------WLb5L0dbJE4aWejsnRRU0psh Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WLb5L0dbJE4aWejsnRRU0psh-- --------------6q5orJvlsQYaVIVVg9B4f2nF-- --------------taO9UrUHsRh2N1i26QA65PFP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMoRVIFAwAAAAAACgkQsN6d1ii/Ey8o XwgAl4AT7Yj7lhtuq6ecnq/Zj8+/sUnv1oVssk4oS6NSlyVUlu+wyB0rCVXOSu4LLsRN6XW7ZCeU hG8scPfJiM+5/fC806wGuAlMWciJzu2JeizRclnE7Q5+FzHwvOYelUdrjydXNZRC964WCJEXGNgJ YRMN7OEGRtatkjibRubq/uIGSAokfG85sF9J9BfkHu7QGIOb/xf5tMSff6spHDhinth/eQAJwQK8 wlymY5veUNIDoErxri564T7vuiAN3YXoHAg2iB0qT31H0oAs3xjY5s4KmwiRDmoneP/N/KpEbAEh B36XsvXZHpGk8rB8KSiaLZMyj4NUFwgLfxlJeHoVIQ== =650t -----END PGP SIGNATURE----- --------------taO9UrUHsRh2N1i26QA65PFP-- From xen-devel-bounces@lists.xenproject.org Mon Sep 19 11:03:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 11:03:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408700.651523 (Exim 4.92) (envelope-from ) id 1oaEYH-0002qg-0k; Mon, 19 Sep 2022 11:03:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408700.651523; Mon, 19 Sep 2022 11:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaEYG-0002qZ-Sx; Mon, 19 Sep 2022 11:03:00 +0000 Received: by outflank-mailman (input) for mailman id 408700; Mon, 19 Sep 2022 11:02:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaEYF-0002qT-5P for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 11:02:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70077.outbound.protection.outlook.com [40.107.7.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e649908-380a-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 13:02:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7450.eurprd04.prod.outlook.com (2603:10a6:102:8a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 11:02:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 11:02:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e649908-380a-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdwH/z2VCdt0FL1XFObizg86TlNKwzLQ1wmH76LPf/OxTC5vN7YQA+VwzKA0UUR37dCYkKh2Hj9yvmnEYZ09gdLqLCdmaSK2B1AQvGpoa2z0gMy0O3S9GxA1USSz5nCanLYgYOg3IXqlDVXxQn9cD00PIEVTfunH2AVw+Xbx9G1DT7ju6EZADYP0nu2k3MKWkYkXrNoj6yKboIVCJtjtmnxqNQDIYJje2nTbG+Bg1It++Ha/j85qG89/Yig6RAaxtLqwDpBevLf/aB+d5nE/c+vgjVahHV2LUAKudmHLBPGps2NcVkuoPaBq6/LEikiiUQmMYT0GkMkD3gZbzuKW/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02xU9hjYOfhnYP2ePWIEqxRClQxXIq7p6wgidrJu+3E=; b=FkF40NtYajTViYWvxkZwwRTBORAvxyaS2HfMwQBkGanASDqWyUB5R+YnJkIpLMIouw1Yxhs4JBFvorcxCOrT0Mm4OnD9aFBNtOg9YMETzt7ZkiS7VXcnW3oDsd6shGXH4AHczsjplgrg3HNlT7azBQZgnzJ51KPR471nea5ydVNIDOopUK9UVtdTucMbaFUhI+Xkof7HagCtdATRnXLMDkUet/5UOYjlL6vN901KqjyON+ME9wsZyJt9obyTRyE0kzs4mV72PZlP9S+eCn0g/Wr16tEtTPPFc75II75SpbTSOt9CKgJbL30ycZU5Hpn9G9cEtemu58xUKqtM5YnH8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02xU9hjYOfhnYP2ePWIEqxRClQxXIq7p6wgidrJu+3E=; b=Zkh4SuVOhhrDMC1XvW8yEWOGOSXYReKeR5ktU/7wB39+/GDnNIoTLI0z8+FUqPCtd4cc5QEbJ38O0LKZV9LIYPGAVekAwCRXiFeiZ/J3E+HEFPr9R2CFSsDcFJkTaEVghgekDzJBlzn3OXmC+SJJwI+jX3facczSA/Y2iaxKgZL40ebUcFcpxfBzTX2N+AyNbjHLZk21pX6HkW+urwmfX/GGFxVu55ZnIAqfr1OY1r7QJKIrpow+NF0UeKDsi1JJqDMUtsieauZ94n/3XPKpQl5auKH4I4+11LA+YoeKYKjS1mrVFF22JiBtY+ixQDcxLzACYa2AqEuYvBaD7qpB+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 19 Sep 2022 13:02:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [XEN PATCH v3] build: Fix x86 out-of-tree build without EFI Content-Language: en-US To: Anthony PERARD Cc: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220919102831.17438-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20220919102831.17438-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0150.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7450:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e05f1e9-20e0-40cc-2838-08da9a2e80af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M8lAVySBHnv6yVdup02+J9jsEf6EoHIicGg97qXbAvB8u9HmJOh5KJGPTXqFIjz7XO+DrWcEM+ATGx4A6zZYs1PBqqbe4z1FruJZUnum8da620d7qyNchP5zl2mzrlM2hfg40mQhBSoTIGjfoM2D2ORgH6Wp0KThalkc2SiEs22+U/c+W9CoknDQjGW1TvUhsrGS6Kl9oDO7q/NvNkZddBvZEowLWonPFtH69P6jLFmt1HTgl88arAYsQrN3nTFfaXUArJmOPK1OjR7dkv6CoN9MA3ctmaNBvGEvRIHoQPDXuTWTrYJO46KjFeXPaybizxmmMYcOYyaB1Fkyk0NfCROSjASg9THjWyV8PZguaINntMnRFLEawsnrGmII40k2ZL6vZZ5JJ3zMkvmUm89iBM1QzfvTHVWznhVZ8M9Apnyyr2p4YXIQdqFO0Gnj/Dk0VAy4tUWJKP2/Wl3KdgLvQH2dS2TJcar4FdGNDDsu2XqB8Pu0zk4u5XnB4CqGq+Is7DWW07PzR86PrjvHcyHSJJYM/bsDw91GOdHPfQLqEwaWWKsCHx5WG/7vymUBrDJQFZrEPRMhNhxVvijcyJ/ytAPCiLKtG5TO586uaqJ4FtyAi9Irrs+bsXwxGoQ/ZjNGr5A5/hzJ49gKurqonvQMB8mTQSYK7IKbj80uPFV5qG8OiiE9R7XT0fk4Ou3UYXMsr4XwpAj3PIEfxJkD/yncwcUbrcbWQQRbj03gnWQ4CFbYRxQbc5XTvrq+yQF6+12qOxy4Y4pgik1MCxaEBu4/b2PULf5frYnCaM5vopKeHPs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199015)(66946007)(4326008)(5660300002)(8676002)(66556008)(66476007)(7416002)(54906003)(31696002)(6916009)(86362001)(8936002)(316002)(38100700002)(83380400001)(53546011)(41300700001)(6486002)(6506007)(478600001)(2616005)(186003)(26005)(6512007)(31686004)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1VYQVBTQXNyanNMOEU0cG12L1JWQldYcnpHOXVIMWxoTmQwZDkvT1lHM2dn?= =?utf-8?B?dFdHbHRXNm00cmtjcTJYU3NoYzE0RXdOTkp5QnNPZ09QN3hrNG8rbUpKaHNk?= =?utf-8?B?N0U5Q1YyNGNpWGpnS0NoRVdSNGpET0RUQXJMVlFRY3puUVN5SUEwK0lVakR1?= =?utf-8?B?QWwzM3hMdldmb3lRWUZVS3U3MWNIWjd0dGNWSG9JSW1oYzVYVkRaL0NJaGNw?= =?utf-8?B?bWdDRWs1emx6TFFqdnR0WEJvMWFOdHhhR1E5VXMwaHU2NHh6bDlZdGt5b2Mr?= =?utf-8?B?V0dHUVJxbG9yd1p4RGtBc1lCV0paRjg2RXYxRnNiZFFBeWlHYk5XUU9nMkty?= =?utf-8?B?aGNURDJVZ3B4dFRyOTdFK3FjQUFDeFIwc3RUcE1UTUN0cDFNNnZqSXQ5OFBQ?= =?utf-8?B?bHVHdm53dmpKS0h6bUJSQ3BiWEZSeXcrWUlHQXFuSEhMem8zd0tZd2JjNmpm?= =?utf-8?B?ODMwTEpjVEVOQXBiUDBab1MrK2dDSGQxaXNnRWRBUWh2Z3hOTldwdDZUWGE3?= =?utf-8?B?TUdEeDd1VlN3bHRXczVlT0NEOCs3QVVzYWtja0FRblplRjBDZmVGZGhvOE0z?= =?utf-8?B?RjVac0RXN0NGbnEyOXFkM1NxL0NjOFFRSWNzdzNNTVJaZWJ4WmNRV2lTL0Q2?= =?utf-8?B?djlPcU0zeDFSbjlXMENtcmpKcTlkL2FOV1ZOOW52dnhiUGQvZEZvM1ZEMWFk?= =?utf-8?B?S3ZyWGMwaHpNbVJOQjRoVnFITlF6MTY0bEpUU21PU2ZhQmJxYVU5NTF3Rzdu?= =?utf-8?B?cERqeDZvVlcyb3NETzhLc2hTaExqQ1NjdjFzb3hyNTZSZHBHUU5lc1lTNnov?= =?utf-8?B?YWt4bjBFOFNjallvY1QyWkt2U0lVVkN6UVBqMXN3YmswOGI0eWZ1Z2NWK2NL?= =?utf-8?B?dUZwUzBGVWFrZEVDcHNKbmwrY2tieW5Ha2RQOTArZk1kN1FpTVVnYTlZY2ta?= =?utf-8?B?N1FIWFlIZ3l0NFM0RHRLeWlzU0VjOTE3SU9yNVpCb0NMRnNKSTBGR2NOSEZs?= =?utf-8?B?WUF2SDZCVXhaUDNEZXowZWdSeFpBRDJ4a3pEWTEvOGU4VHhvYlA4VFBUUy9j?= =?utf-8?B?RGxJM0x0b3hvY25wTWQxSDM3T1JPZ0tmbGVqSmNUemNyb2V0V2ZHbTFSbTNi?= =?utf-8?B?RUJNdUtOTExxWXdQYzdkbDI3d3FDb3dNZjFWZFFnT0xGLy9lQWZ0TjRUS1VL?= =?utf-8?B?U0M5Vm5sV2tOWEtaR2plaTRqSk1aa2FrK0J4KzdLZEpINWpnVHlDUnFGVjYr?= =?utf-8?B?bDQyRGxIenFtYVhsUmhwL3RQS1FpcWhicG1ZdjlCZnZHNmo1aWorK1B1WHBr?= =?utf-8?B?WUFGNFE4TmJBMnY5b3RSaXBhZkhhNHp1QzhaZElRTHkrNDlhbVF6VmVGZHNk?= =?utf-8?B?WFBOVFRvaEVjc2Q1bG9uV1RPRzBTVjNGVzI4VWxRVmRPbFdLdm9kOHVzMzRR?= =?utf-8?B?VHQ2blExT1hnQzZDUmFMelpXNGdCZjRIU1JlY2RBUnBwY21OUjB3MU93aGdj?= =?utf-8?B?aDA5ZnhzcXljcTZKaUl2QThVVm1qV2NJYU02YW1NNDBqRk42eGVhY05PVHFF?= =?utf-8?B?Z3U1eURqbEhUVmhyTVBjc21jazhyL3VsN0RYY1gzcXpvV1lzSWtYSGhtNkVP?= =?utf-8?B?cEMzdlpwZGlTcnVuZDFLVEd1eDdUaFF6L0ZqeFNWR0xEZzByeVdVd0x6TE9F?= =?utf-8?B?NU9xQ2tsSFJSU0cvT2Qva1UxMStxeDR1ck84dXZnQ0ZZdlJJcHYyU0l2T2dt?= =?utf-8?B?TVN1MnJUc2dGQTRwc3duTDVkQXNjdCtiY0liaWl6cE9VOFplRmJadVBPbnp5?= =?utf-8?B?NERHTzN4UzlRQkozbndIbCt5cnF3MEZ3UzFQUHlRRGtCUCs0SWtYeWRKLzFi?= =?utf-8?B?REJPQUsrek9hNUFicjFyK2tlaUNtNzJjMmNsMEJGTjV1MWl6K3NwUHA2K0xP?= =?utf-8?B?R2lVS1dxRm41bUlsbENkYXFTWDlBZi9qcER5NFIxc1N0OUkzTXdaRUVmeWFN?= =?utf-8?B?b1dtRGltSEh2cXdaUWJiMWwxanR5a2JxTGcrN3pNYXB4bmxUeHVlMUJmR0Jz?= =?utf-8?B?WUw3ZHE0VjFiVGZRVnRVYXN1OWk4UHl3cjlyLy95ZWZaL2NOQlFJbFAzZjZz?= =?utf-8?Q?90FbSUNHTF7JT0k5tINRM7OY1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e05f1e9-20e0-40cc-2838-08da9a2e80af X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 11:02:54.6513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ua8ryscwaPv9MegdeyBE9dSpmj0GyXnRNpX5aEXq99lLY8u+4nI373SZgI2B4ZyArUSzZWwY8e3LnJRetAiuIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7450 On 19.09.2022 12:28, Anthony PERARD wrote: > We can't have a source file with the same name that exist in both the > common code and in the arch specific code for efi/. This can lead to > confusion in make and it can pick up the wrong source file. This issue > lead to a failure to build a pv-shim for x86 out-of-tree, as this is > one example of an x86 build using the efi/stub.c. > > The issue is that in out-of-tree, make might find x86/efi/stub.c via > VPATH, but as the target needs to be rebuilt due to FORCE, make > actually avoid changing the source tree and rebuilt the target with > VPATH ignored, so $@ lead to the build tree where "stub.c" doesn't > exist yet so a link is made to "common/stub.c". > > Rework the new common/stub.c file to have a different name than the > already existing one, by renaming the existing one. We can hide the > compat aliases that x86 uses behind CONFIG_COMPAT so a Arm build will > not have them. > > Also revert the change to the rule that creates symbolic links it's > better to just recreate the link in cases where an existing file exist > or the link goes to the wrong file. > > Avoid using $(EFIOBJ-y) as an alias for $(clean-files), add > "stub.c" directly to $(clean-files). > > Also update .gitignore as this was also missing from the original > patch. > > Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm") > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich with a remark and one more adjustment: > --- > > Notes: > v3: > - back to using common-stub.c As said in person, I'm a little puzzled by this, as the v2 discussion had no hint in that direction. > --- a/.gitignore > +++ b/.gitignore > @@ -280,6 +280,7 @@ xen/arch/*/efi/ebmalloc.c > xen/arch/*/efi/efi.h > xen/arch/*/efi/pe.c > xen/arch/*/efi/runtime.c > +xen/arch/*/efi/common-stub.c > xen/arch/*/include/asm/asm-offsets.h > xen/common/config_data.S > xen/common/config.gz The new line wants inserting a few lines further up, to retain sorting. Can perhaps be done while committing. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 12:26:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 12:26:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408718.651534 (Exim 4.92) (envelope-from ) id 1oaFqX-0002Vz-6S; Mon, 19 Sep 2022 12:25:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408718.651534; Mon, 19 Sep 2022 12:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaFqX-0002Vs-33; Mon, 19 Sep 2022 12:25:57 +0000 Received: by outflank-mailman (input) for mailman id 408718; Mon, 19 Sep 2022 12:25:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaFqV-0002Vm-Io for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 12:25:55 +0000 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [2607:f8b0:4864:20::b32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33d56ed6-3816-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 14:25:53 +0200 (CEST) Received: by mail-yb1-xb32.google.com with SMTP id e81so22841293ybb.13 for ; Mon, 19 Sep 2022 05:25:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33d56ed6-3816-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=8e+V29mBkEytMtPLtjYXo/iiLXCf5zHfYegqib6BMTw=; b=pj8RfUan9LLTztnqD8lvL/jTk3+uRXOFKiLKl6bDHWKAII9mYnxf2AHQ0Mw+rlkBW1 UFI3jCloBx469IWoHXhKwl4jbyYwQNOE1kMfbYOm1Lk7TgS3l7d/zQLPZy3l9HKlua2/ p2rPcBlgoAymc2NFvqKcWINnwcS6YYOnuq0cMUScC9nrNLEt/BK/24g+tQiC/+D6SMBs QsYXjGify9AD1s3cJl253jdx9E+8mwRF0pqsKo7Mojmwi4y0S2BlmAmXsclcoKwtNmR3 RvudYuTYeSSV8hdiUgFRkn+VMHIa1VdOpISPqyN2jVBI56Z9RJTSIlC/ypVUsHLeLbu2 eTTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=8e+V29mBkEytMtPLtjYXo/iiLXCf5zHfYegqib6BMTw=; b=spgNX4TW8jDVuKzaY+iePqKo5ZwpXZnI/BaVjH5rJFyCcm0LhWs2iZGoUpATr3GzZZ 3oF7i5z2fcrT922feyRYtbXpyKZDxx5Yox8zrZYP0iLjlYyeoEpe2KJq1SmuQEpY9lKF mOzb8zWuXUlhCtb3H41MZRuB1GzTCA9JWxg4n8Md5h1Ht0/IQ1nJ6tYoGr/aAynAMbnb JpBNo/oVg8fCpp5WDw4DlcJLL0HwdlbEHCuUsbjwOKRAj0JB5Z81TVJlRlAJcHX78KiF etjY4wTUBHkgr9QBltpAz/vTwp+giQ6f4VyiEhviBqTZi85KynOHdD6G1Jr4sm2efv4P XnLA== X-Gm-Message-State: ACrzQf1o4DUQWdmANEa54djTWfCG1Si+GosqvLGVEJ+O1aISmNFatcOH QPkTd/PE27tJH3/TAwX2oQm8frl4gflN7AAEoBI= X-Google-Smtp-Source: AMsMyM7Bv58KNzRU5+3ZIP/me3bvlwtyl7kTnhRhshWMiFqxeOgVyaS1sgQqgoQaQirrFT3DG1+OBI+CSZztEvHd5no= X-Received: by 2002:a25:9d01:0:b0:66e:9087:4fb9 with SMTP id i1-20020a259d01000000b0066e90874fb9mr15063191ybp.159.1663590352396; Mon, 19 Sep 2022 05:25:52 -0700 (PDT) MIME-Version: 1.0 References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> In-Reply-To: <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> From: Tamas K Lengyel Date: Mon, 19 Sep 2022 08:25:18 -0400 Message-ID: Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load To: Jan Beulich Cc: Boris Ostrovsky , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel Content-Type: text/plain; charset="UTF-8" On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: > > On 16.09.2022 23:35, Boris Ostrovsky wrote: > > > > On 9/16/22 8:52 AM, Jan Beulich wrote: > >> On 15.09.2022 16:01, Tamas K Lengyel wrote: > >>> While experimenting with the vPMU subsystem an ASSERT failure was > >>> observed in vmx_find_msr because the vcpu_runnable state was true. > >>> > >>> The root cause of the bug appears to be the fact that the vPMU subsystem > >>> doesn't save its state on context_switch. The vpmu_load function will attempt > >>> to gather the PMU state if its still loaded two different ways: > >>> 1. if the current pcpu is not where the vcpu ran before doing a remote save > >>> 2. if the current pcpu had another vcpu active before doing a local save > >>> > >>> However, in case the prev vcpu is being rescheduled on another pcpu its state > >>> has already changed and vcpu_runnable is returning true, thus #2 will trip the > >>> ASSERT. The only way to avoid this race condition is to make sure the > >>> prev vcpu is paused while being checked and its context saved. Once the prev > >>> vcpu is resumed and does #1 it will find its state already saved. > >> While I consider this explanation plausible, I'm worried: > >> > >>> --- a/xen/arch/x86/cpu/vpmu.c > >>> +++ b/xen/arch/x86/cpu/vpmu.c > >>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) > >>> vpmu = vcpu_vpmu(prev); > >>> > >>> /* Someone ran here before us */ > >>> + vcpu_pause(prev); > >>> vpmu_save_force(prev); > >>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > >>> + vcpu_unpause(prev); > >>> > >>> vpmu = vcpu_vpmu(v); > >>> } > >> We're running with IRQs off here, yet vcpu_pause() waits for the vcpu > >> to actually be de-scheduled. Even with IRQs on this is already a > >> relatively heavy operation (also including its impact on the remote > >> side). Additionally the function is called from context_switch(), and > >> I'm unsure of the usability of vcpu_pause() on such a path. In > >> particular: Is there a risk of two CPUs doing this mutually to one > >> another? If so, is deadlocking excluded? > >> > >> Hence at the very least I think the description wants extending, to > >> discuss the safety of the change. > >> > >> Boris - any chance you could comment here? Iirc that's code you did > >> introduce. > > > > > > Is the assertion in vmx_find_msr() really needs to be for runnable vcpu or can it be a check on whether vcpu is actually running (e.g. RUNSTATE_running)? > > You cannot safely check for "running", as "runnable" may transition > to/from "running" behind your back. The more I look at this the more I think the only sensible solution is to have the vPMU state be saved on vmexit for all vCPUs. That way all this having to figure out where and when a context needs saving during scheduling goes away. Yes, it adds a bit of overhead for cases where the vCPU will resume on the same pCPU and that context saved could have been skipped, but it makes it so that the vCPU can be resumed on any pCPU without having to have evidently fragile checks that may potentially lead to deadlocks (TBH I don't know if that's a real concern at the moment because the current setup is very hard to reason about). We can still keep track if the context needs reloading from the saved context and skip that if we know the state is still active. Any objection to that change in light of these issues? Tamas From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:21:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:21:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408723.651546 (Exim 4.92) (envelope-from ) id 1oaGia-00005c-AI; Mon, 19 Sep 2022 13:21:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408723.651546; Mon, 19 Sep 2022 13:21:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaGia-00005V-4t; Mon, 19 Sep 2022 13:21:48 +0000 Received: by outflank-mailman (input) for mailman id 408723; Mon, 19 Sep 2022 13:21:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaGiZ-00005P-2B for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:21:47 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2042.outbound.protection.outlook.com [40.107.105.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01ed5faa-381e-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 15:21:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9423.eurprd04.prod.outlook.com (2603:10a6:102:2b3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 13:21:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 13:21:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01ed5faa-381e-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Os4mcu8msuIl8+5V9jnsGl39VNdWX2up76anL7T7dTbC/Eh5ujwN4ABQcHtTUGoxp50Fn+B9l7ts7ds2awi4CoSe0J5jP/O+Kd+75EdZ3V5ZnnHsNW5pFABCWbey02ukbC+v40FraMb9/80zppCD0Eq7xmcqNIoIysaaJ+mbi/3GcppWrREFsjBUfFWKCK6MwIS6INPwXefe2g9V28Rz57zn5hVoDinxcLwkW6Dr7i4PvUZSPlLkKGSb813czkenSXGzHJPg/3L95IwUlbbieRmiCJtVOXTYyw9rmGHBASjMXQNJf5Eaq445c7S0YAeMiQveVTz1R1IQRGgyEFAqXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SIWZ0/lDECLxy5/HW67iD21PHxulpsqP+pyianc6Py8=; b=kU6DMMS1E8natU8SEHg/XX7No96vZTyxYOAM0b/9NWk36+EUBOt93uaobLhz8Cnh/OaWGx/QZGBASO+HLC8ZrKyeDEV1wwhJQAy7khWT3rRKr22yAbTU8GibrHTfAveugL943o6hv+O/a1h2ZyDvTmDNCpX684zic3UUqCRvjzWzSlHN8r/+i1jm4QJlKmFQILH6rLaqRj96f2K3gNsqYBOHs4timRR8+1vL5KNIyHVDnMLEqLL2vlwbYND7HnyZTgvESwtmKunlT+8aXzV/iperXZOjd3N2kjYkyCeJv1RQSvbjv77cnSCmuL5EJQ5hzgIjUu+M7Ctqk5/k7SdT3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SIWZ0/lDECLxy5/HW67iD21PHxulpsqP+pyianc6Py8=; b=J7AA5Bd1OQnHCVj3S0oBxUi3AEh49uh2yZK3Pwm6SDwT7eA2qfqgisKYTJaEZHQ7ALvy1ZQ5b3444k9g51lQw33ILqQPXTp62pEfxcTITJ1qpj0Ecf8M/qcFPRSgGmi/jHrUYyQhT8DXgzNhOZ5LDvYh/7tOunB/xHRl1FI6cAiuAiFChrF2Jtqal4EjPq17izCrpmhauqucJMcUgd9HgNgynDOaN51JE+W5OBwazMFTVa+LL6OkxhhT8sfm7dW7FtApG4fGrCOBDloJSkOvzf8QTjNJVIfRGf+p+Mjyl3s1ZWVEMc1JorasgsuYx61fB+YVFsFU5g6ZoXTyjOv43g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29d29f64-b799-d56c-1292-661fb5127728@suse.com> Date: Mon, 19 Sep 2022 15:21:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Boris Ostrovsky , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0058.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9423:EE_ X-MS-Office365-Filtering-Correlation-Id: e80faf34-251e-4631-0e77-08da9a41e481 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 36utEoHzg25/zZJxziv6/OTZQQiF54XqZTy1i6YXeOnZVQX0OeOptjNXVHp7M5ttAmUxcRjCH/3plTqx2xCSVYMWTVuOJkjV+e73GvY82LjYg1GYljnw1Gd2fHykHcJL4wG25jxuHgcDQXlee/wjMdWCkoJni/iEpx9jYSdf50rrCWkdAl0KMtYSHbGXYRs/yh35v0GxfArYoPEvzyosCr4MkfSehq5N3drIGYNnvXPpM6+i6aBOPOy8EjET+78lHd97yGGWYJFFIwNJRzJvlKLxGKOGTLaerTnn/bpJGVaTJbGPEJJK5lLIXsOXna9LR3fuqsPQFcPOOXiSUMigTP3Gfyp/o/fP44w17H6e7ga/L+VzJH0nXk80pfdNuZl9Kv/cSbKo9NBpQhjCdasYXC1fQw+P7cnJpmDqQsnkGH42vMuTj+ir0yEFTDrux6F8x4IwGZcKjWCE8aCsbN8e2fKwtJ0fHW+riiwxuzWcR0sIkVMPyMR7+ldCNb9tzjxas7US502tCvnjitvVTuzn2d3pbWjzEdGZY+kx/qLzABixE4TIjusfT0uM8qBMbuEn0XOnLA1YTKFSZRcej7+OqbWJ+wE9JxpmIU0mZHBAr9yGZgI0Ki3BDOoXWxy4fxGYWRrWSr/pllVf53alMLL4p8aG5oMEBhc02vPdROgrNvutXRFf/r+3D/nXME6EFcgMkRli9Al5X1ZnpuNL9wuN/P98BuaU0gQa4IaUC44FpMJ5ji1l8X+Aty4BmGh146wheBTD2oeDYwwZdspnxNWjA8MXdxMHZEoRDenhvx0cDD8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(346002)(136003)(396003)(451199015)(53546011)(26005)(6512007)(6506007)(2616005)(31686004)(38100700002)(478600001)(6486002)(2906002)(5660300002)(66476007)(36756003)(86362001)(31696002)(186003)(41300700001)(83380400001)(4326008)(66946007)(66556008)(8676002)(6916009)(54906003)(316002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d25jNk0zOW1oOWNHUFk1SkxaVDVhWU1BOWRPangxeWJUelRzdXdRY1NqRzZ2?= =?utf-8?B?Qk5hbjRTU0J2b1FKQlJXWmpQMWIzRW10ZHNQaUIyYzhJcVQvcVkwNkkzZ2Qz?= =?utf-8?B?NXR2MFFWWHByeE9SdU5VSE93aHRNZW5jV1Q0SHJKdDRsWDdad2Z0RXNpdXg1?= =?utf-8?B?WHRjNkVnZTNyc0pGNjgyMEhBQTNkWThLbzM0Mm9KUWsrWnpMMzFmRndmL2pQ?= =?utf-8?B?Nm9xYkZPT1hRN3RsSGk3S0NCb3psWFhKbUdibnhCOEdpYysyMElJOW9FOGhL?= =?utf-8?B?bHJRVE9lTklFdzVidW9WZi9nVWswZlhwK0JuZDZxOTFmeGg0aUhwVGRVTWRL?= =?utf-8?B?ZG1zOEVEeFliWGpaZWhVQjl6TVBaUU4waTI5U3gxK0k5WjF2RXBxcVFQUEJV?= =?utf-8?B?czAzWnFNODZUVzFDWlNHcnpWSGJiZll2MU4yRGJYODYrSDVyckNDVGx1QVdz?= =?utf-8?B?OFN6b0IxcTRCOHIvVDhCRlFURnlvcE1xb0d4aERSbDRBMnVxWnZrUTNqSTcw?= =?utf-8?B?dDUvM1FOWVorR0dldWhmY25QM1NzNkZsejdUVTFaN1k2QVM4ZVlrSm1scXJn?= =?utf-8?B?LzFJaFUrQmpiR2xPYzd2UE9vK3BxWnZDeFNZeUhwMldVMWo3M2V5Ym96eURt?= =?utf-8?B?bnlJYjNEL2h3c3pIZ2NVM3ZpamhwMENLNjgxUExOQkNhQytZOWRaTnZoQWty?= =?utf-8?B?TzIyRU9nVUVwU29vNjN1a01wSlcyekhvc2tEaHNDb0pVZFY2VUM2R29Qa2Zw?= =?utf-8?B?Ni9kSmdIMThTTjZXMXpVUWNiVmo0TU12dkV5dGhXRVFRZlpmYVU4WmRxRmlR?= =?utf-8?B?YnNCcjE2clRFN2ZKOEZJRTRaazBVZklERlFGcldHWExHV2E0N253V2xFMHk1?= =?utf-8?B?NjU4STI4dzE5SnJXZU1yZHBWU0lQakFWM2hFUXJQUmhpbVNsdWxFU2dFd1By?= =?utf-8?B?WktrYzBxUjdKeVRucVFaNExkVjJoUkU0RXlESitnK0ZXUWxFaFNSQmhON0lF?= =?utf-8?B?dTRNcFdQT1BJNVBpbHdBR0ZzVWI2TGd3RjBZOURCek50SG42c3k2RmNsMTJM?= =?utf-8?B?bXNmcGlSZWNKb1lZL3U4UGpIQVNoTktCbUU5K1k4bnIxN1Y2SlhlMVNjcmJE?= =?utf-8?B?bEsvdHdVTzJWb2pnaUV6SXE0OEx0a3R5dWVNRDZMRFR1SU9OTW9iWE1qWVpz?= =?utf-8?B?d1ZFVEZ2NUNvOGd3RmlkZmhIS0gzbFRnMEpZTWlCNldLYysveDJVTXgrTEZZ?= =?utf-8?B?cEptOERlSFZpbHNpZTFXbE9jcjc3cGpJQ0tDSDFyYU52bWIrbXJlcGFBNktv?= =?utf-8?B?eTNSY0Fnd29nbDV5a3hwV0FUVDRrWHV0SjByQXRleDRtanp5QlJqOFJldGND?= =?utf-8?B?cTM1eG1tMnJuVU5rVzYxZzlId1JyT0prbUhaODk0MWlHSThYc3NMdWlocThy?= =?utf-8?B?OUpyc3RoOTlIaWZuSmFQT2dMVXY4ZVVkMWJRUm9HVlMyQk1nN0JVbnY2N25w?= =?utf-8?B?T1JwZE42VUJpY1Jac0orSE03NFN2d003T292bHE0eENBQ0dyeS9FV0IxaTMx?= =?utf-8?B?U1hQbWp4OUNWSng4Q01RR0ZEeXdYMGNWMk1NaEE5dW55S0p6ZEJkeW1nMlV3?= =?utf-8?B?aWkyWmlXTXZGZDB2TzhONTZjeXlnczNwRnRuK1NYK1AzTkdyZzZhTkRsYVgv?= =?utf-8?B?Z0lpS1dKWGdER1pQT2dGNEJXdGxpRTVxSVVTYU04ejI4czZJcUtjakUwSmlt?= =?utf-8?B?cFhWamowWm5LY0VScmorYzI2eFRuUTBORCtiZjRHbnd4dG1SeWVuVEFsUGtZ?= =?utf-8?B?TFVGbzV5UmsyRWY5Zjh2SE45VUtMbkFLc0o5bENzaGtUb1FqZzZHTGRZL1Rs?= =?utf-8?B?cXBVVHk4Nis2aVBkMkdlNEZzQVppRG9jaXRpWVFYT2dDS2k2MjEwMG52eDd1?= =?utf-8?B?SmVnKzRmeFZBN3lFbTNETzZJVzk2R0RucHN1NW12NE1hTVY1VEZLd3JsNGtn?= =?utf-8?B?RjlNQlpwZEFVckdqbjVGekhGMkFvd1ZTOExtYnNlWmozWnVzaWVIM0JGY09k?= =?utf-8?B?ZGx3b2hnTnROWHpNMUdmTlJEZDh0N2x5UVVnc0RjQkxUR1hDME9tbDhEN0ZG?= =?utf-8?Q?2m6Cleeur6g+wNlOqiW90E22j?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e80faf34-251e-4631-0e77-08da9a41e481 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 13:21:42.8092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MoXgeIxhAy/a5P4Ywh0WOocX23LOdl72BlWur41rcVMeVmbq/feTpS5tBngJn7SiIzuM1zN4SPvY/Yt35HGtwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9423 On 19.09.2022 14:25, Tamas K Lengyel wrote: > On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: >> >> On 16.09.2022 23:35, Boris Ostrovsky wrote: >>> >>> On 9/16/22 8:52 AM, Jan Beulich wrote: >>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: >>>>> While experimenting with the vPMU subsystem an ASSERT failure was >>>>> observed in vmx_find_msr because the vcpu_runnable state was true. >>>>> >>>>> The root cause of the bug appears to be the fact that the vPMU subsystem >>>>> doesn't save its state on context_switch. For the further reply below - is this actually true? What is the vpmu_switch_from() (resolving to vpmu_save()) doing then early in context_switch()? >>>>> The vpmu_load function will attempt >>>>> to gather the PMU state if its still loaded two different ways: >>>>> 1. if the current pcpu is not where the vcpu ran before doing a remote save >>>>> 2. if the current pcpu had another vcpu active before doing a local save >>>>> >>>>> However, in case the prev vcpu is being rescheduled on another pcpu its state >>>>> has already changed and vcpu_runnable is returning true, thus #2 will trip the >>>>> ASSERT. The only way to avoid this race condition is to make sure the >>>>> prev vcpu is paused while being checked and its context saved. Once the prev >>>>> vcpu is resumed and does #1 it will find its state already saved. >>>> While I consider this explanation plausible, I'm worried: >>>> >>>>> --- a/xen/arch/x86/cpu/vpmu.c >>>>> +++ b/xen/arch/x86/cpu/vpmu.c >>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) >>>>> vpmu = vcpu_vpmu(prev); >>>>> >>>>> /* Someone ran here before us */ >>>>> + vcpu_pause(prev); >>>>> vpmu_save_force(prev); >>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>> + vcpu_unpause(prev); >>>>> >>>>> vpmu = vcpu_vpmu(v); >>>>> } >>>> We're running with IRQs off here, yet vcpu_pause() waits for the vcpu >>>> to actually be de-scheduled. Even with IRQs on this is already a >>>> relatively heavy operation (also including its impact on the remote >>>> side). Additionally the function is called from context_switch(), and >>>> I'm unsure of the usability of vcpu_pause() on such a path. In >>>> particular: Is there a risk of two CPUs doing this mutually to one >>>> another? If so, is deadlocking excluded? >>>> >>>> Hence at the very least I think the description wants extending, to >>>> discuss the safety of the change. >>>> >>>> Boris - any chance you could comment here? Iirc that's code you did >>>> introduce. >>> >>> >>> Is the assertion in vmx_find_msr() really needs to be for runnable vcpu or can it be a check on whether vcpu is actually running (e.g. RUNSTATE_running)? >> >> You cannot safely check for "running", as "runnable" may transition >> to/from "running" behind your back. > > The more I look at this the more I think the only sensible solution is > to have the vPMU state be saved on vmexit for all vCPUs. Do you really mean vmexit? It would suffice if state was reliably saved during context-switch-out, wouldn't it? At that point the vCPU can't be resumed on another pCPU, yet. > That way all > this having to figure out where and when a context needs saving during > scheduling goes away. Yes, it adds a bit of overhead for cases where > the vCPU will resume on the same pCPU and that context saved could > have been skipped, If you really mean vmexit, then I'm inclined to say that's more than just "a bit of overhead". I'd agree if you really meant context-switch-out, but as said further up it looks to me as if that was already occurring. Apparently I'm overlooking something crucial ... Jan > but it makes it so that the vCPU can be resumed on > any pCPU without having to have evidently fragile checks that may > potentially lead to deadlocks (TBH I don't know if that's a real > concern at the moment because the current setup is very hard to reason > about). We can still keep track if the context needs reloading from > the saved context and skip that if we know the state is still active. > Any objection to that change in light of these issues? > > Tamas From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:25:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:25:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408728.651556 (Exim 4.92) (envelope-from ) id 1oaGmA-0000iE-NR; Mon, 19 Sep 2022 13:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408728.651556; Mon, 19 Sep 2022 13:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaGmA-0000i7-Kp; Mon, 19 Sep 2022 13:25:30 +0000 Received: by outflank-mailman (input) for mailman id 408728; Mon, 19 Sep 2022 13:25:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaGm8-0000i1-OK for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:25:28 +0000 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [2607:f8b0:4864:20::b32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 861f9f31-381e-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 15:25:27 +0200 (CEST) Received: by mail-yb1-xb32.google.com with SMTP id e81so23083971ybb.13 for ; Mon, 19 Sep 2022 06:25:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 861f9f31-381e-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=hHA46XAy9IS/HsZ7WagEcP60CX98wkXEL3EQg41vkvI=; b=o9YIwa5J3twi0Y2vLSCntQ1ToAkk/yZh1vhdozJ7RsZukizFRC2kOXze6a5nG2moO4 q2p5aD7x7ExRMmQww2953KNQMHJ+lkDGVCR01tjqJnazioip66V5ev+dYjlIzeOPQbyS GJDU3t8CDWf72lwY+MhMWxjQDB8TUmqrEU2ie1W0jvezem2MNMgOwc8NtE80CGp4o8+U dUfmSmpm4EDYibEW26eBqNtHLnBWMzVxqrWvjBHLuwxYsTR144hJBiR/u65IOpaFfPfa yGIfCUpA1e7JZ8+1UnhEGu3ChJ1+zzLSgqTf85O40lkgCk6/wztd5Oxj6gX6C16Wb5v7 lW8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hHA46XAy9IS/HsZ7WagEcP60CX98wkXEL3EQg41vkvI=; b=GkB8MXMJ2/v2FU7llwHy73nKBhL/XNFyWAmdOKpVVJVkP0at9kWbvHmuuMEjIzx4e4 Z/g6+7M5BVzLZymVvtvTkICI8/fh5NBG/bAbRwIkz6FucD73uRvV3cIEXNxOzzvTQwl/ wEiyG6Ho5qCHv0i3xo+qOaStK9TGpA9tAmzC5Z+Xi4yv17Jtl9UiLkFKlYdOQEkwT+iC A67HNDC11tIVEin4yTY9QUjylJkO6ksDczVFMk1qJgHeb9jtxn+T/6MuiIQqbcxmaDbP +yDrRNtGqbiUwCHfDbRYsKTIchlIFQUo01vsPG+GvlzfkvlFfzNhTAkm+aFmB0alYwW0 CKRQ== X-Gm-Message-State: ACrzQf2WgRq58iS2v39jaQg779x1ToVKo6ILkyXpzdtLaNM1NRQ0Nr+N Z4Qcyw4Dg706YEjt36HCNxkQA2fRWV0dEVxbK8Y= X-Google-Smtp-Source: AMsMyM7fJfoJSdJGOhLEO3Gr0fCPs0DukInMNVx4S0VKeDTIJhfuApyZQj8dcf4H2Uy6GEBKhfSidsbV0MPbPIIbxa0= X-Received: by 2002:a25:2554:0:b0:6ae:af3f:4137 with SMTP id l81-20020a252554000000b006aeaf3f4137mr14550006ybl.230.1663593926408; Mon, 19 Sep 2022 06:25:26 -0700 (PDT) MIME-Version: 1.0 References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> In-Reply-To: <29d29f64-b799-d56c-1292-661fb5127728@suse.com> From: Tamas K Lengyel Date: Mon, 19 Sep 2022 09:24:52 -0400 Message-ID: Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load To: Jan Beulich Cc: Boris Ostrovsky , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel Content-Type: text/plain; charset="UTF-8" On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich wrote: > > On 19.09.2022 14:25, Tamas K Lengyel wrote: > > On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: > >> > >> On 16.09.2022 23:35, Boris Ostrovsky wrote: > >>> > >>> On 9/16/22 8:52 AM, Jan Beulich wrote: > >>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: > >>>>> While experimenting with the vPMU subsystem an ASSERT failure was > >>>>> observed in vmx_find_msr because the vcpu_runnable state was true. > >>>>> > >>>>> The root cause of the bug appears to be the fact that the vPMU subsystem > >>>>> doesn't save its state on context_switch. > > For the further reply below - is this actually true? What is the > vpmu_switch_from() (resolving to vpmu_save()) doing then early > in context_switch()? > > >>>>> The vpmu_load function will attempt > >>>>> to gather the PMU state if its still loaded two different ways: > >>>>> 1. if the current pcpu is not where the vcpu ran before doing a remote save > >>>>> 2. if the current pcpu had another vcpu active before doing a local save > >>>>> > >>>>> However, in case the prev vcpu is being rescheduled on another pcpu its state > >>>>> has already changed and vcpu_runnable is returning true, thus #2 will trip the > >>>>> ASSERT. The only way to avoid this race condition is to make sure the > >>>>> prev vcpu is paused while being checked and its context saved. Once the prev > >>>>> vcpu is resumed and does #1 it will find its state already saved. > >>>> While I consider this explanation plausible, I'm worried: > >>>> > >>>>> --- a/xen/arch/x86/cpu/vpmu.c > >>>>> +++ b/xen/arch/x86/cpu/vpmu.c > >>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) > >>>>> vpmu = vcpu_vpmu(prev); > >>>>> > >>>>> /* Someone ran here before us */ > >>>>> + vcpu_pause(prev); > >>>>> vpmu_save_force(prev); > >>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > >>>>> + vcpu_unpause(prev); > >>>>> > >>>>> vpmu = vcpu_vpmu(v); > >>>>> } > >>>> We're running with IRQs off here, yet vcpu_pause() waits for the vcpu > >>>> to actually be de-scheduled. Even with IRQs on this is already a > >>>> relatively heavy operation (also including its impact on the remote > >>>> side). Additionally the function is called from context_switch(), and > >>>> I'm unsure of the usability of vcpu_pause() on such a path. In > >>>> particular: Is there a risk of two CPUs doing this mutually to one > >>>> another? If so, is deadlocking excluded? > >>>> > >>>> Hence at the very least I think the description wants extending, to > >>>> discuss the safety of the change. > >>>> > >>>> Boris - any chance you could comment here? Iirc that's code you did > >>>> introduce. > >>> > >>> > >>> Is the assertion in vmx_find_msr() really needs to be for runnable vcpu or can it be a check on whether vcpu is actually running (e.g. RUNSTATE_running)? > >> > >> You cannot safely check for "running", as "runnable" may transition > >> to/from "running" behind your back. > > > > The more I look at this the more I think the only sensible solution is > > to have the vPMU state be saved on vmexit for all vCPUs. > > Do you really mean vmexit? It would suffice if state was reliably > saved during context-switch-out, wouldn't it? At that point the > vCPU can't be resumed on another pCPU, yet. > > > That way all > > this having to figure out where and when a context needs saving during > > scheduling goes away. Yes, it adds a bit of overhead for cases where > > the vCPU will resume on the same pCPU and that context saved could > > have been skipped, > > If you really mean vmexit, then I'm inclined to say that's more > than just "a bit of overhead". I'd agree if you really meant > context-switch-out, but as said further up it looks to me as if > that was already occurring. Apparently I'm overlooking something > crucial ... Yes, the current setup is doing exactly that, saving the vPMU context on context-switch-out, and that's where the ASSERT failure occurs because the vCPU it needs to save the context for is already runnable on another pCPU. Tamas From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:34:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:34:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408733.651567 (Exim 4.92) (envelope-from ) id 1oaGuO-0002Bi-HF; Mon, 19 Sep 2022 13:34:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408733.651567; Mon, 19 Sep 2022 13:34:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaGuO-0002Bb-EX; Mon, 19 Sep 2022 13:34:00 +0000 Received: by outflank-mailman (input) for mailman id 408733; Mon, 19 Sep 2022 13:33:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaGuN-0002BV-JQ for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:33:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6aad8c1-381f-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 15:33:58 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7929.eurprd04.prod.outlook.com (2603:10a6:10:1ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 13:33:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 13:33:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6aad8c1-381f-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ShG0+c4MDHq+TRPNf5eEa1rv01x+5V6MlUVDyX2imoOn0xrn+4Th8BqN0UKtK4BbI6QUqJ8Avd52EJxgPvZaIuIrTy/DDPLWPWQMJUjbZ1cj2LDvZWX0sbFqt1Ks/rEmVH+V3wWaha+t9T2urvMHrh51+DNkjvK7Ru6qpnJ3mRRmQTwbyr7RnGsLOFgcvOiz2qrPjjd9k6pYlM1PmYsCJWIikjG4HooMd09GTq6oEFmrurQLYPgnmlNM4HVGoijN0WQf4I9HkMhbB1b52VEtsIkXlu7rzK/mNCrWSVqm9vyrPLIn09qJcS6AcdOCrqnTaM6hsi5V8CMlm3tvVkgO1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jrBA+O2CEsDVuJpb0NA0D6TzHQhOStL3qp5Kfu5RO2s=; b=O4WOb7pMTJMNJINnYOKZ9k7tpBRr1cN1w7xjEYLMszVaF0s3VjDeW+MUiGPdbKjhs7NRsHBsTS0J8zCyF5oF0Zygq9yXEVO/Izk72jm9oJohcfGtiacMn4+HclaBMBvhgOvMd4j5fpFtzknEt/OnD5NqC406dnZxIQZ6ipFnjA58e+gGtxQhGBWkQATlgI1zmdOybo1OFoj53v5OlN/uhW/eEn9Yr5Th9DdcwxK7TmWMU70kq6EvgB0Vjo7MKsMQ76GmmJXc3fdiejSRM+rIilscYla80JCaPNbhgCs+F1kurmRWWX9VSzOMLTXLK96lDne+OdNNyCnbToh0iKqu+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jrBA+O2CEsDVuJpb0NA0D6TzHQhOStL3qp5Kfu5RO2s=; b=wNVGD7ra9OTfvFhN9TFPFFXyr4wlzwsXIRFt92Xxg18ilj4mieO6DqDwabhvoDle8VGhuiGEXadp7XDShSJlhAJhtLzxewYGJ8USHhElyNVio79Cb+XV5vXXIM8YUOn3p4ORmUL/iuvNmTG0iDnzhHz+nT1O6u29xgAb/FgZuU1BdazWHM8WVprLWinylKT0ovyN6xhjHSvee5SczMClT6Bqb2IiDlY9ZlPW3x1eHxaAlvFWI9aLQOYkZ8ToHQaNfETBnctlpfTfMqh7PhxTv9LAaXO1V4XEdws9GUvjgliEWEkOvrbPNhSrSgSUde/ulFXAHKuuqVK9OgD6vRHNAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6211a296-c4ba-5783-f6b4-8dbed8261a2a@suse.com> Date: Mon, 19 Sep 2022 15:33:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability Content-Language: en-US To: Henry Wang Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Kevin Tian , Connor Davis , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7929:EE_ X-MS-Office365-Filtering-Correlation-Id: e8b4e4c2-4f5e-4f24-e409-08da9a439a0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gKZKAtgjjgjBrMQHnZrQXIJpOlcvbm+qhmXJBIU47ig25Moa8jNdtAIFyvJO1FtUFyW6vQ4d2HE4m2FGPRBLuofcdom15grT4Gg0peCIu4Ou4neqWgDSSlFLeu0Sq1Hg+eCCbwfsudd6npgygGD1AWHZKBirNNbeFNzS8iW9jdH+lHmHJEnQklr5m4DiPnlli8qyQEZqdOhu4JTUAc2Ktl2quz6SU8/jTye108j/wSvSdhEQPGUkS++6qDNJM66CI8FhalcuMX7+uVo3udfo+/ZZcJAFH1eFRZTQN84QujGWYSLRGe5e6O5Ein/X1SnrLHL2/bF8rhuiOyCiVfiRnLsBtYegAxiwxdCnVXzR0LStANUhGgDLft7iSLA68kXFQfbZApf68HVuRNEs2O+7DPx+W6tIvFf0nJlaQwDMtYnU0ihuIQJ0DqCE+TtsvXWwUNaUuBEU+72obkwdr9zWH1txAxhqfamJgZMIVFShSvNgdQ9WsoUwyTRqqxdZCOoHqss2mQa/ZzFmrUqzrEIRiCbrTBlxAAl8048Eoz+m5P96IoIVmvqh7PbE3nFOFZKJrkFqKy5ZbYFk2JxiJjO5tOGlJqA0yM19B397c32NpYthRopLkXE7alWpwF/4Bg6NK98aje1x5Fv7cBajPS1ZEzKWXwajOT8Jh9Gt5vQX/LnYW9+V0LY24uAxsAR/uHMcLguP7wdG29aUporez+7qKQTKaSwnKsNTnlJA08LjRZBv9X/2L/TdMyZtaQkiFeuR2yUzGcm10d5daZw6UNwEnbKDI5CNiK0Fc+iR1XsrmSMncbqebwvMpgPINUkehGdr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199015)(7416002)(31686004)(5660300002)(2906002)(83380400001)(66574015)(41300700001)(966005)(316002)(66946007)(36756003)(38100700002)(2616005)(186003)(66476007)(66556008)(8936002)(478600001)(26005)(53546011)(31696002)(8676002)(6486002)(86362001)(54906003)(6916009)(6506007)(6512007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0Q2OTh4ODJhMnBvbG1HUnQ5aVhydXg0aC9BdHNHamVtMFN6cnZGZG5mTXVs?= =?utf-8?B?V2VVTkVNQzk4SXRMVDF6SDQ0alN4akRhbmZUSTlJTUx4czJBcDVBU3VqR0dW?= =?utf-8?B?WkxGMmliSFRIbVNvZU5ZMjF6NzR2bFJoL0FKM3M5MkJkd1N5ajRsdjc4Z3hZ?= =?utf-8?B?UHdsdGtDOTVMbmNLMGdYSFVWKzZPaWV3SkFTNEhGTTBETjUvMkNPb1Q5M2x6?= =?utf-8?B?MTZyUXovS1h0dzl3MWVIZ094M3pmcnEyMTF6OTBQUmt6Y1E1RXA1TUJ6TGdH?= =?utf-8?B?Y0RWMFZxY0hyalB3K3ZCNU1YeVR5SWdhVHdRNHROd1E4bDNVUC9QUWh3ZHB2?= =?utf-8?B?ZU50TXBUNFliR2E1cjIwWHQvMkJBbkVjT1l4UWJvWVZMUU5HRURNYURTc1Q5?= =?utf-8?B?MnI2VVI2eDVrV0tZQm12Ukowa0REdFpMejBYdnhvOFFXVGEzRVQwMlhCTDZh?= =?utf-8?B?VFRvbmZOdTRWaXBXNmpPUXE5V0YxOTF2MDR2STZnRHlqb1NNS2xyZlc1Q3BR?= =?utf-8?B?ZUh0NUFyVGd6OEozM0pIN3U5akhrN3hIMUlkR2Q1WjNtSnNFUlpmMjhNS2kr?= =?utf-8?B?TE9GckYrVEhFMlk0WU9yVWkyNFNaWDRTaWg5cVJmcjFTNHhoM2MxWkdzNXo0?= =?utf-8?B?WFltcnFDZG5WY21xQ0hkZ1JDVDhncGFsUHhkVXZtQm0wMWRWaUJtaldqUTBF?= =?utf-8?B?V1VCaFduN2RCWWpYSy8xUU9oRFQvQ1JrOTNaNWFDd2RzZGMybEErRlB2RUVz?= =?utf-8?B?ZW9GWHdNdjdDZTZ4QW1MbEJuUmNmdUt1eXZNb2NQU1hnaFN4dnFWcjB3b0t4?= =?utf-8?B?WFU1MlR0Ukk2WXF4NWhVT1BnQllCb2tJUG8weU82UHFvQzBEUmYvSTk4VklM?= =?utf-8?B?RnZCcmxNWW94QjMzTzE5OFhGd1U1S1JvM3k3L0E4ZHE3eDYrTXB0K1MvMWU0?= =?utf-8?B?RnhNS0lXZ2lwWERFTjBiVXN4QU1HZDM1OFFHNVd2S1FyUFNuN25Vc1BFOHhu?= =?utf-8?B?ZTlncXlSTTdTOVRXNldVY0lhUUVuZEhTSHNXcTJKRkxFb2p0bUQrSXdkVVZR?= =?utf-8?B?YWZKMnQ2aHZPSTRFUmN3dmpIT2VGZnpHL1lyOEQ1aFpqL3VONk93L0hvWDc2?= =?utf-8?B?YWVXaXlDaFpkemFsR2ZNT3dHd0REYUtyRGlaVWU0ZFNWRU1heWZ4Mi9tZEFN?= =?utf-8?B?L1ZjZlRVYWQreXJvdkJZUWlrd3Fwb25PdDh1YklSd01VN3lFaEhqdGVKcUcr?= =?utf-8?B?eUFCYWEyNVBoWGdyeFgvYXd0cFVvOVdzbXMwL2wwL3JwQmw1WG1pU1NKTUJl?= =?utf-8?B?cndMU1RReTdrVlVZVkFCT3lNdktPWkhyazJXSEx1bjlZaDBQdy9hZUY3NDk4?= =?utf-8?B?QkFpaWNidzBrdDZwTnUxLzc4NDdyYzBnZms4QWJDZ01ubUxLcFFubFZBdFlH?= =?utf-8?B?QjZRWmtoRFU2aUFKSjlVNzJBVnYrNUdHdTUwaXdXbU9PbUlOWlBSN0ZpMHRU?= =?utf-8?B?UTBYaXl4c1d1bHF2WFI0QXBVd2k4T1Z0SkM4alRzS0RlZnY2aVA3WE1BMzdx?= =?utf-8?B?Qkc4V3FLN0xBZmw0WTEzYU5NUVV5dktSRERZUTg5aHdwVXpIaWxNMUE4Z1BH?= =?utf-8?B?c0ppaEx0THVLNXFlQU1CSHZLK01WUDNvaVdueEw1NURCMjJNWWEzb1RUa3pY?= =?utf-8?B?bVBrY2RhaGc3ZTRwOVdrem1GRzNQWGtiQ25CazQ3c1Z4L1JlOEhCYlhxa0x2?= =?utf-8?B?UTRvdWxUWDhnbDdaUDlJNzJkSXZCbmhtZW1lbzF3eU5vQWxUcVMzR3ZyeU1U?= =?utf-8?B?Q1Z6eHZWbHFnNXVNT1JjQTREcU4wU2lHbWdaMTBwM1FYWXRpQ2dNY0E4cVkz?= =?utf-8?B?ZTN0OGJhWm9oUTZlL05vd0sva1lOYmR5OVZrWlZYd2djemFrZ2F5L2lUcGIy?= =?utf-8?B?Z1l6eTIreWlveC9pVlJWVitodjdJM1d5b2V5Z05vRERjMnZrcE1aaWJ0TkU1?= =?utf-8?B?RWtzVVRXcXNIa0FCMHdadHhyUFMrS2VKY2YrUGY4VXBvaUdRT3c2RnRFM05D?= =?utf-8?B?U3VhaWhNNno3U21MTlBMR3lBQm8yTFdYVTlxYUhQNjV4Z1hJSGNMQXIwRk1r?= =?utf-8?Q?fjAxH4dan4UKpi71qsnD2HOXH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8b4e4c2-4f5e-4f24-e409-08da9a439a0e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 13:33:56.5906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f1WKHFKcQf9sC2mgy6LVl9/+ivw66meVxHgc/wrxorucWt8a66Y3O083u3tlM0XRQr7/IVqyigD6TQbQFdzTCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7929 On 17.09.2022 04:51, Marek Marczykowski-Górecki wrote: > This is integration of https://github.com/connojd/xue into mainline Xen. > This patch series includes several patches that I made in the process, some are > very loosely related. > > The driver developed by Connor supports console via USB3 debug capability. The > capability is designed to operate mostly independently of normal XHCI driver, > so this patch series allows dom0 to drive standard USB3 controller part, while > Xen uses DbC for console output. >[...] > Marek Marczykowski-Górecki (11): > drivers/char: allow using both dbgp=xhci and dbgp=ehci > IOMMU: add common API for device reserved memory > IOMMU/AMD: wire common device reserved memory API > drivers/char: mark DMA buffers as reserved for the XHCI > drivers/char: add RX support to the XHCI driver > drivers/char: fix handling cable re-plug in XHCI console driver > drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC > IOMMU/VT-d: wire common device reserved memory API > console: support multiple serial console simultaneously > drivers/char: suspend handling in XHCI console driver > drivers/char: add console=ehci as an alias for console=dbgp Henry, this series is kind of on the edge between a feature submission and corrections to existing code, as the base patch introducing the new driver was merged only recently, and at least some of the things here aren't clearly "bug" fixes. Additionally it's on the side of larger ones considering the point in time. To summarize state: Patches 2-7 are ready to be committed, and Marek tells me that they're independent of patch 1 (except for a context conflict). Patch 11 probably also falls in this category. Patch 10, otoh, is pretty likely to be viewed as a new feature, and hence likely wants postponing. In any event - if I was to commit any of these, this couldn't happen earlier than next Monday, as the laptop I'm currently working with is not (yet) set up to do commits from. Do you have any particular opinion on the disposition of this series? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:50:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:50:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408742.651578 (Exim 4.92) (envelope-from ) id 1oaH9y-0004Us-2o; Mon, 19 Sep 2022 13:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408742.651578; Mon, 19 Sep 2022 13:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaH9x-0004Ul-Tt; Mon, 19 Sep 2022 13:50:05 +0000 Received: by outflank-mailman (input) for mailman id 408742; Mon, 19 Sep 2022 13:50:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaH9w-000481-B8 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:50:04 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4376770-3821-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 15:50:01 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BE9D45C03BB; Mon, 19 Sep 2022 09:49:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 19 Sep 2022 09:49:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 09:49:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4376770-3821-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663595399; x= 1663681799; bh=jdhxF0O7zXn/CcIP+xNswbx4VrKnAba3DX6vvzfwYLY=; b=B L9qnTZLOmbBzxh9FJC0wF2xajeARDxsNu96xNNdS7qk1MmR4zHO/BsLDTW8lqH0P RJpRJt868OAee+MvFewgjOY2Wglc61OmoHe6Uet5ISj1tRtrVuaTp9MaPsHiSGT8 TKbJVjdlg2hyfl8mvWc2OV+ScOs5EUH95XMAeiP6OHR3DwyGEq3Vd5NT0zctCiDT 7rIFfIqt7D4VLEqmNIcNK3V3+/iZnvGZK9F7eVsGQOK7YsklTbeNULCYJihGtHtT 6s+L68wnFHXzbRWGfhIMMReeYRLQBAUDcmQWAZbGFobyJuuwV/y4lzCK5j2NIazP d0xTYR5WjjRoJfwgGB6xA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663595399; x=1663681799; bh=jdhxF0O7zXn/CcIP+xNswbx4VrKn Aba3DX6vvzfwYLY=; b=FeRVOQqBJXaYZmeHeTrjPfweJIFnQQ7a2kU8z3zre/Sv AEEKD2nXczeqBvjA4niPT9eogmEw6FuBpkqWExejrDU/hQpaos3+HNxV8n7AG7cb PssJ63fjLbcgcuBCXKB+rOQEMKyLD3yovuHdySVUNMC4QFp3M51rQmrkie9B5FgD pmfDhoD/e1ZmLdtDrEw40ZHdRG+t5DkG5cP1OR2NudHwXlByyHgWpyHtGXwnHy+T izydlelukR5J8Ra60kTwoOrMyP5xrOZlo+31ibK2CzhDjJcvgFj9vOysVTX8XLZT x56UKFpxDA6bS8vUlftwsp7CwsfGpljTWWtU4JpJDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvjedgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 19 Sep 2022 15:49:53 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Henry Wang Cc: Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability Message-ID: References: <6211a296-c4ba-5783-f6b4-8dbed8261a2a@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lVLAy8tK65j9UJDb" Content-Disposition: inline In-Reply-To: <6211a296-c4ba-5783-f6b4-8dbed8261a2a@suse.com> --lVLAy8tK65j9UJDb Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Sep 2022 15:49:53 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Henry Wang Cc: Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability On Mon, Sep 19, 2022 at 03:33:55PM +0200, Jan Beulich wrote: > On 17.09.2022 04:51, Marek Marczykowski-G=C3=B3recki wrote: > > This is integration of https://github.com/connojd/xue into mainline Xen. > > This patch series includes several patches that I made in the process, = some are > > very loosely related. > >=20 > > The driver developed by Connor supports console via USB3 debug capabili= ty. The > > capability is designed to operate mostly independently of normal XHCI d= river, > > so this patch series allows dom0 to drive standard USB3 controller part= , while > > Xen uses DbC for console output. > >[...]=20 > > Marek Marczykowski-G=C3=B3recki (11): > > drivers/char: allow using both dbgp=3Dxhci and dbgp=3Dehci > > IOMMU: add common API for device reserved memory > > IOMMU/AMD: wire common device reserved memory API > > drivers/char: mark DMA buffers as reserved for the XHCI > > drivers/char: add RX support to the XHCI driver > > drivers/char: fix handling cable re-plug in XHCI console driver > > drivers/char: allow driving the rest of XHCI by a domain while Xen us= es DbC > > IOMMU/VT-d: wire common device reserved memory API > > console: support multiple serial console simultaneously > > drivers/char: suspend handling in XHCI console driver > > drivers/char: add console=3Dehci as an alias for console=3Ddbgp >=20 > Henry, >=20 > this series is kind of on the edge between a feature submission and > corrections to existing code, as the base patch introducing the new > driver was merged only recently, and at least some of the things here > aren't clearly "bug" fixes. Additionally it's on the side of larger > ones considering the point in time. >=20 > To summarize state: Patches 2-7 are ready to be committed, and Marek > tells me that they're independent of patch 1 (except for a context > conflict). Patch 11 probably also falls in this category. Patch 10, > otoh, is pretty likely to be viewed as a new feature, and hence > likely wants postponing. In any event - if I was to commit any of > these, this couldn't happen earlier than next Monday, as the laptop > I'm currently working with is not (yet) set up to do commits from. I'd like to add for the risk analysis, that most of this code get exercised only when explicit dbgp=3Dxhci parameter is given (which is a new feature introduced with a patch already committed for 4.17). Exception to this are patches: - patch 1 touches also dbgp=3Dehci case - patches 2, 3, and 8 (the last one missing an ack) touch IOMMU code in general, but changes are rather not invasive - patch 9 touches generic console code, but can be safely dropped (is completely independent from the others) > Do you have any particular opinion on the disposition of this series? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --lVLAy8tK65j9UJDb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMoc4IACgkQ24/THMrX 1yxCaAf/WMU7vwKuqbZEN21t9s1y8OcTZJKVdDBaZImyaI8Fpt8XuTjKu08bn2Ta WfVxogI+788XHRGCmAFnAC4Aasz1QHDg84l8udVBz707DbtjESv37X6xuT1F6hRQ 4+XoqoLOGFUWB0+/ekji/fpJSDIeyyUBxSUWXsfM4VQqTrCGW1fs9gpOKHwETlv7 zMtXSHOxomNkC8f8uDfm9BKQZRdkrfKLgkbAUZXradmvpXkHizmyw454/N1d3ARj UAsxkLFBI4xDqBUbAS56HMesXMM87zDr6wicdvOPDJw+cDj2TF7h3zxAleV1kRHs nT9LQboKFTZBbPJ2fnqdPzAKqsRcjA== =NIh2 -----END PGP SIGNATURE----- --lVLAy8tK65j9UJDb-- From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408749.651589 (Exim 4.92) (envelope-from ) id 1oaHGx-0005FE-PD; Mon, 19 Sep 2022 13:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408749.651589; Mon, 19 Sep 2022 13:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHGx-0005F7-MP; Mon, 19 Sep 2022 13:57:19 +0000 Received: by outflank-mailman (input) for mailman id 408749; Mon, 19 Sep 2022 13:57:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHGw-0005F1-B8 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:57:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8b1ae1d-3822-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 15:57:17 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AB410222C5; Mon, 19 Sep 2022 13:57:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C50413ABD; Mon, 19 Sep 2022 13:57:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id d2X0FDx1KGNMUwAAMHmgww (envelope-from ); Mon, 19 Sep 2022 13:57:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8b1ae1d-3822-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663595836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/5pLYXZNjCGOsvALaYTumY4Dq6WSSAQIzCShFqFyEVM=; b=nvvPo21K5WC+i8QCzIWLt+aE6wLWb0xYrUwtf/ApDwvqfDw8ZWTlgZxMSu1+t7BlV1Rhee xrAg1k8Kk4T30G/T+6+TgnRtV3Xpkuy7nciEHWIQdjkHGKnwIrnIxmTaY5gyy4PXGhkYDu OYtJnXdSK/WOwJCwf87rVNUNhOmUpqk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 0/2] xen/gnttab: reduce size of struct active_grant_entry Date: Mon, 19 Sep 2022 15:57:11 +0200 Message-Id: <20220919135713.16577-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While looking at the grant table code I thought it should be possible to have a smaller struct active_grant_entry. This approach should only hit transitive grants with some negative performance effect, "normal" grants should be not affected. Juergen Gross (2): xen: add knownalive_domain_from_domid() helper xen/gnttab: reduce size of struct active_grant_entry xen/common/domain.c | 53 +++++++++++++++++++++++++--------------- xen/common/grant_table.c | 13 +++++----- xen/include/xen/sched.h | 4 +++ 3 files changed, 44 insertions(+), 26 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:57:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:57:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408752.651600 (Exim 4.92) (envelope-from ) id 1oaHHL-0005hK-1I; Mon, 19 Sep 2022 13:57:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408752.651600; Mon, 19 Sep 2022 13:57:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHHK-0005hD-Up; Mon, 19 Sep 2022 13:57:42 +0000 Received: by outflank-mailman (input) for mailman id 408752; Mon, 19 Sep 2022 13:57:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHHJ-0005fY-BE for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:57:41 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff4d3c18-3822-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 15:57:28 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 15D8E21D34; Mon, 19 Sep 2022 13:57:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C883B13ABD; Mon, 19 Sep 2022 13:57:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9hq7Lkd1KGNiUwAAMHmgww (envelope-from ); Mon, 19 Sep 2022 13:57:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff4d3c18-3822-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663595848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EiGpOOfo6nM2u8o3TQyMPZ74pkfux6LagS477LbaOOM=; b=LyiNTbhWJmDJM2LwFwBXSt8Sol7FYU0socBXEOQqXYTMLQCX+nsERpf/4g+1fEplrsMYxh xbo4GAQ4WVW9liXHOUdN0aI+KoSFzEGSwTWMaY0lmNtl4PnOA/e8lI4qHeeSjFjE0MUw4I ah01snMiwqZFd35jbaTqcs1nw4tP7Jc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 2/2] xen/gnttab: reduce size of struct active_grant_entry Date: Mon, 19 Sep 2022 15:57:13 +0200 Message-Id: <20220919135713.16577-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220919135713.16577-1-jgross@suse.com> References: <20220919135713.16577-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The size of struct active_grant_entry for 64-bit builds is 40 or 48 bytes today (with or without NDEBUG). It can easily be reduced by 8 bytes by replacing the trans_domain pointer with the domid of the related domain. trans_domain is only ever used for transitive grants, which doesn't have any known users. This reduction will result in less memory usage and (for production builds) in faster code, as indexing into the active_grant_entry array will be much easier with an entry having a power-of-2 size. The performance loss when using transitive grants shouldn't really matter, given the probability that those aren't in use at all. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - rename trans_domid to src_domid (Jan Beulich) V3: - update comment (Jan Beulich) --- xen/common/grant_table.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index fba329dcc2..f3890c9124 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -381,13 +381,13 @@ struct active_grant_entry { }) domid_t domid; /* Domain being granted access. */ + domid_t src_domid; /* Original domain granting access. */ unsigned int start:15; /* For sub-page grants, the start offset in the page. */ bool is_sub_page:1; /* True if this is a sub-page grant. */ unsigned int length:16; /* For sub-page grants, the length of the grant. */ grant_ref_t trans_gref; - struct domain *trans_domain; mfn_t mfn; /* Machine frame being granted. */ #ifndef NDEBUG gfn_t gfn; /* Guest's idea of the frame being granted. */ @@ -1095,7 +1095,7 @@ map_grant_ref( act->start = 0; act->length = PAGE_SIZE; act->is_sub_page = false; - act->trans_domain = rd; + act->src_domid = rd->domain_id; act->trans_gref = ref; } } @@ -2494,7 +2494,8 @@ release_grant_for_copy( else { status = &status_entry(rgt, gref); - td = act->trans_domain; + td = (act->src_domid == rd->domain_id) + ? rd : knownalive_domain_from_domid(act->src_domid); trans_gref = act->trans_gref; } @@ -2657,7 +2658,7 @@ acquire_grant_for_copy( !mfn_eq(act->mfn, grant_mfn) || act->start != trans_page_off || act->length != trans_length || - act->trans_domain != td || + act->src_domid != td->domain_id || act->trans_gref != trans_gref || !act->is_sub_page)) ) { @@ -2676,7 +2677,7 @@ acquire_grant_for_copy( act->domid = ldom; act->start = trans_page_off; act->length = trans_length; - act->trans_domain = td; + act->src_domid = td->domain_id; act->trans_gref = trans_gref; act->mfn = grant_mfn; act_set_gfn(act, INVALID_GFN); @@ -2738,7 +2739,7 @@ acquire_grant_for_copy( act->is_sub_page = is_sub_page; act->start = trans_page_off; act->length = trans_length; - act->trans_domain = td; + act->src_domid = td->domain_id; act->trans_gref = trans_gref; act->mfn = grant_mfn; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:57:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:57:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408754.651605 (Exim 4.92) (envelope-from ) id 1oaHHL-0005kb-Bn; Mon, 19 Sep 2022 13:57:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408754.651605; Mon, 19 Sep 2022 13:57:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHHL-0005jY-7w; Mon, 19 Sep 2022 13:57:43 +0000 Received: by outflank-mailman (input) for mailman id 408754; Mon, 19 Sep 2022 13:57:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHHK-0005fY-3s for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:57:42 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fbe970a8-3822-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 15:57:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 62544210DF; Mon, 19 Sep 2022 13:57:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1BEBC13ABD; Mon, 19 Sep 2022 13:57:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id g4JTBUJ1KGNUUwAAMHmgww (envelope-from ); Mon, 19 Sep 2022 13:57:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbe970a8-3822-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663595842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tz8gsHMxNLDss6Wcz9zH14FFQ/wItJfEktj91VmkdgY=; b=dz0FiBOpB+hNTb2zbyB8hKdKBj6xPn2dCVnLjKX0gAHtX1AydzLxjqgmCskodQjq3uhEBu RP44MCyWHrDWigWV8oP3ZJpyFM6UOFILvEIXT1scgFN81nQw2nuIhndtOqEZKeccXjORFG JQVxM8iLlvxqyp9OSmxO2L+wvTM8UAo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 1/2] xen: add knownalive_domain_from_domid() helper Date: Mon, 19 Sep 2022 15:57:12 +0200 Message-Id: <20220919135713.16577-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220919135713.16577-1-jgross@suse.com> References: <20220919135713.16577-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a helper knownalive_domain_from_domid() returning the struct domain pointer for a domain give by its domid and which is known not being able to be released (its reference count isn't incremented and no rcu_lock_domain() is called for it). In order to simplify coding add an internal helper for doing the lookup and call that from the new function and similar functions. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - rename helper to knownalive_domain_from_domid() (Jan Beulich) - enhance comment in header (Jan Beulich) - rename internal helper (Julien Grall) --- xen/common/domain.c | 53 +++++++++++++++++++++++++---------------- xen/include/xen/sched.h | 4 ++++ 2 files changed, 37 insertions(+), 20 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 8dd6cd5a8f..35e0dc5139 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -835,25 +835,32 @@ out: return 0; } - -struct domain *get_domain_by_id(domid_t dom) +/* rcu_read_lock(&domlist_read_lock) must be held. */ +static struct domain *domid_to_domain(domid_t dom) { struct domain *d; - rcu_read_lock(&domlist_read_lock); - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); d != NULL; d = rcu_dereference(d->next_in_hashbucket) ) { if ( d->domain_id == dom ) - { - if ( unlikely(!get_domain(d)) ) - d = NULL; - break; - } + return d; } + return NULL; +} + +struct domain *get_domain_by_id(domid_t dom) +{ + struct domain *d; + + rcu_read_lock(&domlist_read_lock); + + d = domid_to_domain(dom); + if ( d && unlikely(!get_domain(d)) ) + d = NULL; + rcu_read_unlock(&domlist_read_lock); return d; @@ -862,20 +869,26 @@ struct domain *get_domain_by_id(domid_t dom) struct domain *rcu_lock_domain_by_id(domid_t dom) { - struct domain *d = NULL; + struct domain *d; rcu_read_lock(&domlist_read_lock); - for ( d = rcu_dereference(domain_hash[DOMAIN_HASH(dom)]); - d != NULL; - d = rcu_dereference(d->next_in_hashbucket) ) - { - if ( d->domain_id == dom ) - { - rcu_lock_domain(d); - break; - } - } + d = domid_to_domain(dom); + if ( d ) + rcu_lock_domain(d); + + rcu_read_unlock(&domlist_read_lock); + + return d; +} + +struct domain *knownalive_domain_from_domid(domid_t dom) +{ + struct domain *d; + + rcu_read_lock(&domlist_read_lock); + + d = domid_to_domain(dom); rcu_read_unlock(&domlist_read_lock); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 557b3229f6..9e9c3d834b 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -737,8 +737,12 @@ static inline struct domain *rcu_lock_current_domain(void) return /*rcu_lock_domain*/(current->domain); } +/* Get struct domain AND increase ref-count of domain. */ struct domain *get_domain_by_id(domid_t dom); +/* Get struct domain known to have reference held or being RCU-locked. */ +struct domain *knownalive_domain_from_domid(domid_t dom); + struct domain *get_pg_owner(domid_t domid); static inline void put_pg_owner(struct domain *pg_owner) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 13:58:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 13:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408763.651622 (Exim 4.92) (envelope-from ) id 1oaHID-0006rq-LG; Mon, 19 Sep 2022 13:58:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408763.651622; Mon, 19 Sep 2022 13:58:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHID-0006rj-HV; Mon, 19 Sep 2022 13:58:37 +0000 Received: by outflank-mailman (input) for mailman id 408763; Mon, 19 Sep 2022 13:58:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHIC-0005F1-E4 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 13:58:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 276b8fc0-3823-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 15:58:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9439.eurprd04.prod.outlook.com (2603:10a6:102:2ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 19 Sep 2022 13:58:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 13:58:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 276b8fc0-3823-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eiUevjIDluKJwmwqLSrkpCTwTgUFFmbi99hShdNv6apjwDwTYtTrU1QQAfSvaWleMp3vgHRQR/ep9QU2dee7qlxXnu8P0aT+hEnnvd9Mh1TEUSeSWnbQts0v7ffBofi0nzHerkeESIy/i5bfuqqunkmWXlSsuB3qXV/5ciz5ll0y10de3neN9zETl5OPNclE7E1Fv1iRp280eXWn7SU31HLo8rVDkoJD55jmUxeS9cP0K7PhPccGidlF6DIs8fzG9h/IZ/4frctUKaDU+NcohtPVMy5VfwVLPWG2UouZLdotpaL8LAn/ouNgO3wAlUY0GrY0tmW86vpC2UVO7YMHvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=70h6zE93Yjhpm8cfkbsJwWQgswYjHgzw136/Ypnf52k=; b=Aol3a06rBsbGI8VzTTapGHfmPgJTeNjOiY0zc0LgJaBMbM3NWJzIm5HZeAJglaScH3gM4G7eQM6G2qwNH2MWhwPj2rAV7Xxe191f9DJovfPW9t5SlzarXZbM+Sfl3kEoFhQV8kZ/9wpJOZ/LDASJYNTS9E59G+VQSAl3FO7a132atZTjcH5dlfAox1evyTN5FPsnjTxReOu7N0H35fEDPxJWpHLgnbDglZpS1YYTuSN0hJVP1BA6rVltKu+Fc0uUQt9bB364S6J9mO2UJGR4Fn4FFjsBUNvWHn+zaQNGANC31oBiXHuNvd61mQCBbqpO29Nr3q9GHKiKXZ1+fh7A0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=70h6zE93Yjhpm8cfkbsJwWQgswYjHgzw136/Ypnf52k=; b=l+xqbyACvEO2FZO6rF6424TcHMQWeuRjifFGnhX1WAcQ9MJIhzVESa0Bdb4uZFosEt26owJT+6moEX3p8kM8zeKxGVGc5X/Mv59fb8uxgRjsF3k7YVlAcX9Z2n3s4Q2Q1cl7dFI3rxuGfJgXsyzjavWjz3b1IIRvaalpdIrkdQYn2eNoeQo6+gMnfsOYGcq52cmrB4pEkEEeXlV+9LANvz/lWqgUp8upH2ToEsPSVo62mVuMprWJvFn8/lW7TyRAXxFDD3yQF3hsuuFgcBXE0O4Le/4Bb3O9it2IS7iHq7TBkzjiwPHKIvWD825vLTpAruW3lA6ohv19QbfA+xijjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> Date: Mon, 19 Sep 2022 15:58:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Boris Ostrovsky , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9439:EE_ X-MS-Office365-Filtering-Correlation-Id: b56939b8-1172-4971-fe66-08da9a470aa1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +7DVDcCOfPFlcyCuapyU8IXWTzToKISGTN4Y4sr1ecc4oZLmfbVr6IMkHuJaiMlQ60tNjIaPE0YDgMe3PlqEdx1kb1WQwCvzEMyAUXedUV9/7JH+R9oe6Gh0yFU6m7EJP86jyzMID3o9+KG/G/9aikUAd+4Bxs8DUGzgwFCet6LDksljsNXw+TVdA/tPzulraFUr2u2+uM0ks/Lxab0BYG6asz5Kwia32qLBr8t3dJdP8d7YggKsyTV/Ii6Z24o2JEjv5RfU+OL23670ninyBdB+JqP+rJaNW5EXluHOXau7i+1Rs4Cw0UtZzMuIEBdrJvjVwo3lSgyufUoM7cE4Wuh0Rf/Bb2j22Op+WTgk1PC5vFrqGlRTXKosvBiEnRFxJGHiybaiyHMASSrXxZT/hmca4p+uq67WJEbcg8BFPYL5r0xlf3lqJZ8rJqJSxS2GXSOvPcAGT8AKWwL26VLr183s6W8kum9/NIn0xyNLdbFDcPK6i39XjnwJB2QR9Y9fKwuqg+4rjB1XHWdGXxR7za7RoF37z6VlXpXIyGCpGllrf2vDFFZlCe565DMp0eyC7sQXDc92x/ncsSq+BcG6cpymtwfSXInePmlYvTj7XD6T5AtbbTg7eGSt7c9AHqJ08/999i3I/GcfC1AVkdvc0iF8icoWYSpH+OGHtu9ThIYGFi+gH668LqRLfYHUFwSqV3o9xQH5pruMYolinlzVG3obP0Ku5yk69IMF4FPeXWglSTjNpxH63BQLNHNzSYYFSoO58PSLD7qIX4O+AuslwR7s6e/T1npIJUueANRVA0o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(39860400002)(136003)(366004)(376002)(451199015)(66946007)(66556008)(2616005)(66476007)(54906003)(26005)(53546011)(41300700001)(478600001)(6486002)(86362001)(8676002)(2906002)(83380400001)(316002)(4326008)(6506007)(6916009)(38100700002)(5660300002)(31686004)(186003)(31696002)(36756003)(8936002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEhMT24yTytsZlYyWHlaYTBZYk1lRjlaZUp6cjhJUzI5cVp3d1JmN1FvWTlL?= =?utf-8?B?ZFB1UnJIWlo4UUJqNmF0NG5Ca0hkK3Q1eGRFZ1VYemxmUkZsQVh6a1BqWDNN?= =?utf-8?B?alBRYTEvUHlxWHZsMjBoYW8zVUM4M0xuTGJQRURNaG9kTCsxSGp1NUd3bHBQ?= =?utf-8?B?eEVlSkVlM3F0T09lWEhTdTNTL0g3K01QQ0JWcHN5VDVaZGFaQytoT0tFQW5H?= =?utf-8?B?VVE0czJLbUtJeFV0N0pNT2R3T0F0dEc4aVpIWlFnem9vbndvSENqNFJOSHpH?= =?utf-8?B?dmFzTGg5eEN6SkpkdC9qczA2NEMwbVZQaGU1elBYNXZnZ0tRRVVlOEpWUHhl?= =?utf-8?B?Q3ozM0Urd2xFTWUrcW1hVzErQVR3N3JuWVV2aVhDSWJocEN4ZXdXL0FOcURr?= =?utf-8?B?UVdiSSt2bWhJR1UxWHdUVDFzOEROK3ZlZEN0ajdJUiszd3Z5SjNOZUxlaUpX?= =?utf-8?B?ODdvUWZSbUpueTYyejdBYTdkaVFlTmlkOE9GNWpuWnpPejNDRlZxcy9EMm1G?= =?utf-8?B?TmM2a09CN0R6ejAvM1I0Wi9nQlZrdUJxQWNJWC9aQVkyWndZeFBzQi9oS0o1?= =?utf-8?B?MTlnL01lUjdSUXAxWURuZUJXRGwvbkExTmY0UmNLd2ljUHo5aXJ4dStHV0NG?= =?utf-8?B?ajdPUnZMaStJMmtVR3BhV2YxRkMybWUwSTNJS2FSSDNPQXFZaHFCZThnL3dh?= =?utf-8?B?UTErVGtwMUFXcW0vaE9CVS80RXNZUVdqV2tQN25Ldk1kYmJLby9iRC9laVhu?= =?utf-8?B?QTBIUmluM2N6QmE0ZG04NDZqdTc3bWtIUXpKandUekt6WVhGdGUyaWljVGJh?= =?utf-8?B?MEZZS3oxZUFIdUc5QVRYam00Ym9rSW41RGJ5a2RvZWpnaGYwdXprQ2c3UnBY?= =?utf-8?B?S3ZLRzYzSSs1UzV6c0FIbW5SV3ROZHhhKzY1MEIxS1pEbWFqcWUxMUN3Vkd0?= =?utf-8?B?MUNsN2hQNXRid2pjcW8vcHY2ZnVNZDlrV0pJU3hTWC9udWNOY21ROXNrc0Rv?= =?utf-8?B?YlVWY1N0R2pkbnJGekYzS0ZtMXpYaWQ5MDJYR3NhcGJ4dzFRNEg3YTdaV0do?= =?utf-8?B?S1VCaXhmWTVKUHE5TDlRK0MwRVpVdW9ZTUtmbXdGVURoOHVCMmJZYkNucytB?= =?utf-8?B?L0VGNE9ZbUtWZDRNQXBaU1I3eFlXZ2F0bWNSemlsMisraUFZWTh3RGJMaEVB?= =?utf-8?B?L2pxR2JHU3owREtVTStId2tQZjJKSk0rMXV5bnFHZTR1MHp0a1JueTYzLzJw?= =?utf-8?B?alZvOEZ0Z3NWZVdLMThUNDBDUHZOdXlNSURYalUza0JUT1ViMVo3N2dxb09r?= =?utf-8?B?L2htSk8wRGR4SXZGYzBDd2tTY25UTmZrVHZvWTl2NHZBbVZoQUQvNnBPU210?= =?utf-8?B?dkVOR3orTWhlSWRiSFl0Vk1EK3hxbUNlVFA2UGw1bHFGTTgreDBzYnpNa2FI?= =?utf-8?B?eThMeGt0TEQ3TU9paGJuTjgyL1Q5b3dDelkwWjE5SXVQUFVKYUUvclpGLzdX?= =?utf-8?B?TnZMT0ZIeERnOGRXbTcxM21aQS81MVlOWmQydG9KajduMFpOZHlCK05RdU9P?= =?utf-8?B?VTMzejVFVW9ocFJaY1liRkRjSE9oSEZQWWVZLy91RXp3WGlJMWgycnNWNlFj?= =?utf-8?B?Ri96cGY4cmVYUE5UcHRvTllUd1ZGanBDeUdaWnBOTEp5TGkwTTYvQmNxZUxM?= =?utf-8?B?a0RoY3BFZk1ZU3pMN1AweDFJMkM5QWd6TE82MTBreTR1SmRxNlY4TFdtbzJL?= =?utf-8?B?WXE3Y3VMQzRzd2ZENVU3ZzZLaHZUSkNZV2N1MytGZVhEaHA4UGtuSWpVdWlk?= =?utf-8?B?c1c5aFZlNlVDbTFNWFJwWEMzNDhvUUxnSDd3b0JNaHdBZkRkM0JlRGxRclNQ?= =?utf-8?B?bTZvb0piaU5uVktSZm5DQWlzeXVlVzhQa2ZtTVVwdHI5N2dFaGo1eWhqS3Qx?= =?utf-8?B?VmlTdW1odVBiM2tKSWNha0szdVFicGF3bmJrVXpwSGdCMU9iWGI1cGlxanVP?= =?utf-8?B?NDNpQzNPdUhGR05DVmMwdmxzNlFranhjYTRnS1FsNEd3OVRXWHNWeTFkbklV?= =?utf-8?B?ZTRtNEVWMENITGJqWnZ4TU9YOW4vU2lScHNyL3Q4djlUQ0plMGlndGVlUzNX?= =?utf-8?Q?whZ44GUzonsD+EK8D/cTjeA2u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b56939b8-1172-4971-fe66-08da9a470aa1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 13:58:33.9340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RuvRBnTMtuTTlKjhr6eI3hRQDQlNqmwF2f5CHSyXgXTpb64fqoeRLnXsUhFFgUj55faZk2L20un9ADNN4WclOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9439 On 19.09.2022 15:24, Tamas K Lengyel wrote: > On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich wrote: >> >> On 19.09.2022 14:25, Tamas K Lengyel wrote: >>> On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: >>>> >>>> On 16.09.2022 23:35, Boris Ostrovsky wrote: >>>>> >>>>> On 9/16/22 8:52 AM, Jan Beulich wrote: >>>>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: >>>>>>> While experimenting with the vPMU subsystem an ASSERT failure was >>>>>>> observed in vmx_find_msr because the vcpu_runnable state was true. >>>>>>> >>>>>>> The root cause of the bug appears to be the fact that the vPMU subsystem >>>>>>> doesn't save its state on context_switch. >> >> For the further reply below - is this actually true? What is the >> vpmu_switch_from() (resolving to vpmu_save()) doing then early >> in context_switch()? >> >>>>>>> The vpmu_load function will attempt >>>>>>> to gather the PMU state if its still loaded two different ways: >>>>>>> 1. if the current pcpu is not where the vcpu ran before doing a remote save >>>>>>> 2. if the current pcpu had another vcpu active before doing a local save >>>>>>> >>>>>>> However, in case the prev vcpu is being rescheduled on another pcpu its state >>>>>>> has already changed and vcpu_runnable is returning true, thus #2 will trip the >>>>>>> ASSERT. The only way to avoid this race condition is to make sure the >>>>>>> prev vcpu is paused while being checked and its context saved. Once the prev >>>>>>> vcpu is resumed and does #1 it will find its state already saved. >>>>>> While I consider this explanation plausible, I'm worried: >>>>>> >>>>>>> --- a/xen/arch/x86/cpu/vpmu.c >>>>>>> +++ b/xen/arch/x86/cpu/vpmu.c >>>>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t from_guest) >>>>>>> vpmu = vcpu_vpmu(prev); >>>>>>> >>>>>>> /* Someone ran here before us */ >>>>>>> + vcpu_pause(prev); >>>>>>> vpmu_save_force(prev); >>>>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>>>> + vcpu_unpause(prev); >>>>>>> >>>>>>> vpmu = vcpu_vpmu(v); >>>>>>> } >>>>>> We're running with IRQs off here, yet vcpu_pause() waits for the vcpu >>>>>> to actually be de-scheduled. Even with IRQs on this is already a >>>>>> relatively heavy operation (also including its impact on the remote >>>>>> side). Additionally the function is called from context_switch(), and >>>>>> I'm unsure of the usability of vcpu_pause() on such a path. In >>>>>> particular: Is there a risk of two CPUs doing this mutually to one >>>>>> another? If so, is deadlocking excluded? >>>>>> >>>>>> Hence at the very least I think the description wants extending, to >>>>>> discuss the safety of the change. >>>>>> >>>>>> Boris - any chance you could comment here? Iirc that's code you did >>>>>> introduce. >>>>> >>>>> >>>>> Is the assertion in vmx_find_msr() really needs to be for runnable vcpu or can it be a check on whether vcpu is actually running (e.g. RUNSTATE_running)? >>>> >>>> You cannot safely check for "running", as "runnable" may transition >>>> to/from "running" behind your back. >>> >>> The more I look at this the more I think the only sensible solution is >>> to have the vPMU state be saved on vmexit for all vCPUs. >> >> Do you really mean vmexit? It would suffice if state was reliably >> saved during context-switch-out, wouldn't it? At that point the >> vCPU can't be resumed on another pCPU, yet. >> >>> That way all >>> this having to figure out where and when a context needs saving during >>> scheduling goes away. Yes, it adds a bit of overhead for cases where >>> the vCPU will resume on the same pCPU and that context saved could >>> have been skipped, >> >> If you really mean vmexit, then I'm inclined to say that's more >> than just "a bit of overhead". I'd agree if you really meant >> context-switch-out, but as said further up it looks to me as if >> that was already occurring. Apparently I'm overlooking something >> crucial ... > > Yes, the current setup is doing exactly that, saving the vPMU context > on context-switch-out, and that's where the ASSERT failure occurs > because the vCPU it needs to save the context for is already runnable > on another pCPU. Well, if that's the scenario (sorry for not understanding it that way earlier on), then the assertion is too strict: While in context switch, the vCPU may be runnable, but certainly won't actually run anywhere. Therefore I'd be inclined to suggest to relax the condition just enough to cover this case, without actually going to checking for "running". Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 14:11:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 14:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408781.651632 (Exim 4.92) (envelope-from ) id 1oaHUs-0000zP-0d; Mon, 19 Sep 2022 14:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408781.651632; Mon, 19 Sep 2022 14:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHUr-0000zI-UD; Mon, 19 Sep 2022 14:11:41 +0000 Received: by outflank-mailman (input) for mailman id 408781; Mon, 19 Sep 2022 14:11:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHUq-0000zC-BY for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 14:11:40 +0000 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [2607:f8b0:4864:20::1134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9fe323b-3824-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 16:11:39 +0200 (CEST) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-349c4310cf7so175219867b3.3 for ; Mon, 19 Sep 2022 07:11:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9fe323b-3824-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=onHH+rf0TFLFOgUFsPT3XTtvXGzHKwlZcupwcOYXDA8=; b=E2qqJVo9OIivs3LaWLDimkywGcrSuVu5oXeL4go6nqrZt3Aa6x0G3qhv0h1NeWHyQO 9Yh2142QZz/Iszi0Pl4Uowz1F0alTErTpcHq//uL5Fegu7CNub9BwR/9zlt+3bbyLxSV oO91kD7iMFehJfelR1anQzDNequJWZxzX7wf435N/9ajN30G5w0rxkGZhXPsAPnBzbQ+ XxjyrHlZlyR8PvyX83ZMxwjqMFrwwi60lPQmGFG5HIiXAS5vfjUOIU412azcC3BBr0uL 59yvexPao58owkQTodbII2jXZS7uIcDmM9GSazLm3dumCBZIcj0t9wCzowTz7xSgE2u2 5vSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=onHH+rf0TFLFOgUFsPT3XTtvXGzHKwlZcupwcOYXDA8=; b=k3wVtnrK5HiUNC9y01CSgEatKcsYVge4EWx9QVHweTJhcJjpfYbk2NR2Y+bBlojjSz TniEvhMdwZHuHuqGt5VtCjbXrUiITCxz1mHj2pX2mCGGdRUeFXECyIGTTLNYX/M6VDkG nNDK3bRf8RScn0SwDu0da2pt9+q/4A2eU4PlJWwAtwLCBti6GezTNeJXX49sJpZTTAWV Tjl8LI/CFpKDFrr3TShyIkXyxbUWfPVcJGyM8MGipEhkCFuwt7pIVpe28tE9Xs8Jmipe K8VQd9h9tbXLA4vIt8Xkb6g8JG1FXlCMUVYFhnenPJdO+KnzS/DKSyC1u1eaSq/KST0k QF/A== X-Gm-Message-State: ACrzQf1ga0xkuxuWEdmb9OzQg+ig5qTtxM8Q+e05rSSvV6wTBAOlgtjl bEMZKkJ0b7Db7ZgiLg4mYc2uLCF+p7zbnzYho1c= X-Google-Smtp-Source: AMsMyM5UgJAfLFB2ZlR1viRNbK+8pmfAQO8uxvtdvDBZC//EpJ0dfIXYWnrjv+SEfu4j9+D50CBpmJyZhGsiujh3d1s= X-Received: by 2002:a81:d344:0:b0:345:1751:e648 with SMTP id d4-20020a81d344000000b003451751e648mr15437260ywl.159.1663596697721; Mon, 19 Sep 2022 07:11:37 -0700 (PDT) MIME-Version: 1.0 References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> In-Reply-To: <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> From: Tamas K Lengyel Date: Mon, 19 Sep 2022 10:11:03 -0400 Message-ID: Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load To: Jan Beulich Cc: Boris Ostrovsky , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel Content-Type: multipart/alternative; boundary="000000000000379f8405e9084ab2" --000000000000379f8405e9084ab2 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 19, 2022 at 9:58 AM Jan Beulich wrote: > On 19.09.2022 15:24, Tamas K Lengyel wrote: > > On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich wrote: > >> > >> On 19.09.2022 14:25, Tamas K Lengyel wrote: > >>> On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: > >>>> > >>>> On 16.09.2022 23:35, Boris Ostrovsky wrote: > >>>>> > >>>>> On 9/16/22 8:52 AM, Jan Beulich wrote: > >>>>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: > >>>>>>> While experimenting with the vPMU subsystem an ASSERT failure was > >>>>>>> observed in vmx_find_msr because the vcpu_runnable state was true. > >>>>>>> > >>>>>>> The root cause of the bug appears to be the fact that the vPMU > subsystem > >>>>>>> doesn't save its state on context_switch. > >> > >> For the further reply below - is this actually true? What is the > >> vpmu_switch_from() (resolving to vpmu_save()) doing then early > >> in context_switch()? > >> > >>>>>>> The vpmu_load function will attempt > >>>>>>> to gather the PMU state if its still loaded two different ways: > >>>>>>> 1. if the current pcpu is not where the vcpu ran before doing > a remote save > >>>>>>> 2. if the current pcpu had another vcpu active before doing a > local save > >>>>>>> > >>>>>>> However, in case the prev vcpu is being rescheduled on another > pcpu its state > >>>>>>> has already changed and vcpu_runnable is returning true, thus #2 > will trip the > >>>>>>> ASSERT. The only way to avoid this race condition is to make sure > the > >>>>>>> prev vcpu is paused while being checked and its context saved. > Once the prev > >>>>>>> vcpu is resumed and does #1 it will find its state already saved. > >>>>>> While I consider this explanation plausible, I'm worried: > >>>>>> > >>>>>>> --- a/xen/arch/x86/cpu/vpmu.c > >>>>>>> +++ b/xen/arch/x86/cpu/vpmu.c > >>>>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t > from_guest) > >>>>>>> vpmu = vcpu_vpmu(prev); > >>>>>>> > >>>>>>> /* Someone ran here before us */ > >>>>>>> + vcpu_pause(prev); > >>>>>>> vpmu_save_force(prev); > >>>>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > >>>>>>> + vcpu_unpause(prev); > >>>>>>> > >>>>>>> vpmu = vcpu_vpmu(v); > >>>>>>> } > >>>>>> We're running with IRQs off here, yet vcpu_pause() waits for the > vcpu > >>>>>> to actually be de-scheduled. Even with IRQs on this is already a > >>>>>> relatively heavy operation (also including its impact on the remote > >>>>>> side). Additionally the function is called from context_switch(), > and > >>>>>> I'm unsure of the usability of vcpu_pause() on such a path. In > >>>>>> particular: Is there a risk of two CPUs doing this mutually to one > >>>>>> another? If so, is deadlocking excluded? > >>>>>> > >>>>>> Hence at the very least I think the description wants extending, to > >>>>>> discuss the safety of the change. > >>>>>> > >>>>>> Boris - any chance you could comment here? Iirc that's code you did > >>>>>> introduce. > >>>>> > >>>>> > >>>>> Is the assertion in vmx_find_msr() really needs to be for runnable > vcpu or can it be a check on whether vcpu is actually running (e.g. > RUNSTATE_running)? > >>>> > >>>> You cannot safely check for "running", as "runnable" may transition > >>>> to/from "running" behind your back. > >>> > >>> The more I look at this the more I think the only sensible solution is > >>> to have the vPMU state be saved on vmexit for all vCPUs. > >> > >> Do you really mean vmexit? It would suffice if state was reliably > >> saved during context-switch-out, wouldn't it? At that point the > >> vCPU can't be resumed on another pCPU, yet. > >> > >>> That way all > >>> this having to figure out where and when a context needs saving during > >>> scheduling goes away. Yes, it adds a bit of overhead for cases where > >>> the vCPU will resume on the same pCPU and that context saved could > >>> have been skipped, > >> > >> If you really mean vmexit, then I'm inclined to say that's more > >> than just "a bit of overhead". I'd agree if you really meant > >> context-switch-out, but as said further up it looks to me as if > >> that was already occurring. Apparently I'm overlooking something > >> crucial ... > > > > Yes, the current setup is doing exactly that, saving the vPMU context > > on context-switch-out, and that's where the ASSERT failure occurs > > because the vCPU it needs to save the context for is already runnable > > on another pCPU. > > Well, if that's the scenario (sorry for not understanding it that > way earlier on), then the assertion is too strict: While in context > switch, the vCPU may be runnable, but certainly won't actually run > anywhere. Therefore I'd be inclined to suggest to relax the > condition just enough to cover this case, without actually going to > checking for "running". > What ensures the vCPU won't actually run anywhere if it's in the runnable state? And how do I relax the condition just enough to cover just this case? Tamas --000000000000379f8405e9084ab2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Sep 19, 2022 at 9:58 AM Jan B= eulich <jbeulich@suse.com> w= rote:
On 19.09.2= 022 15:24, Tamas K Lengyel wrote:
> On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 19.09.2022 14:25, Tamas K Lengyel wrote:
>>> On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich <jbeulich@suse.com> wrote: >>>>
>>>> On 16.09.2022 23:35, Boris Ostrovsky wrote:
>>>>>
>>>>> On 9/16/22 8:52 AM, Jan Beulich wrote:
>>>>>> On 15.09.2022 16:01, Tamas K Lengyel wrote:
>>>>>>> While experimenting with the vPMU subsystem an= ASSERT failure was
>>>>>>> observed in vmx_find_msr because the vcpu_runn= able state was true.
>>>>>>>
>>>>>>> The root cause of the bug appears to be the fa= ct that the vPMU subsystem
>>>>>>> doesn't save its state on context_switch.<= br> >>
>> For the further reply below - is this actually true? What is the >> vpmu_switch_from() (resolving to vpmu_save()) doing then early
>> in context_switch()?
>>
>>>>>>> The vpmu_load function will attempt
>>>>>>> to gather the PMU state if its still loaded tw= o different ways:
>>>>>>>=C2=A0 =C2=A0 =C2=A0 1. if the current pcpu is = not where the vcpu ran before doing a remote save
>>>>>>>=C2=A0 =C2=A0 =C2=A0 2. if the current pcpu had= another vcpu active before doing a local save
>>>>>>>
>>>>>>> However, in case the prev vcpu is being resche= duled on another pcpu its state
>>>>>>> has already changed and vcpu_runnable is retur= ning true, thus #2 will trip the
>>>>>>> ASSERT. The only way to avoid this race condit= ion is to make sure the
>>>>>>> prev vcpu is paused while being checked and it= s context saved. Once the prev
>>>>>>> vcpu is resumed and does #1 it will find its s= tate already saved.
>>>>>> While I consider this explanation plausible, I'= ;m worried:
>>>>>>
>>>>>>> --- a/xen/arch/x86/cpu/vpmu.c
>>>>>>> +++ b/xen/arch/x86/cpu/vpmu.c
>>>>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu= *v, bool_t from_guest)
>>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu = =3D vcpu_vpmu(prev);
>>>>>>>
>>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Som= eone ran here before us */
>>>>>>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 vcpu_pause(prev);=
>>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_s= ave_force(prev);
>>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_r= eset(vpmu, VPMU_CONTEXT_LOADED);
>>>>>>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 vcpu_unpause(prev= );
>>>>>>>
>>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu = =3D vcpu_vpmu(v);
>>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0}
>>>>>> We're running with IRQs off here, yet vcpu_pau= se() waits for the vcpu
>>>>>> to actually be de-scheduled. Even with IRQs on thi= s is already a
>>>>>> relatively heavy operation (also including its imp= act on the remote
>>>>>> side). Additionally the function is called from co= ntext_switch(), and
>>>>>> I'm unsure of the usability of vcpu_pause() on= such a path. In
>>>>>> particular: Is there a risk of two CPUs doing this= mutually to one
>>>>>> another? If so, is deadlocking excluded?
>>>>>>
>>>>>> Hence at the very least I think the description wa= nts extending, to
>>>>>> discuss the safety of the change.
>>>>>>
>>>>>> Boris - any chance you could comment here? Iirc th= at's code you did
>>>>>> introduce.
>>>>>
>>>>>
>>>>> Is the assertion in vmx_find_msr() really needs to be = for runnable vcpu or can it be a check on whether vcpu is actually running = (e.g. RUNSTATE_running)?
>>>>
>>>> You cannot safely check for "running", as "= runnable" may transition
>>>> to/from "running" behind your back.
>>>
>>> The more I look at this the more I think the only sensible sol= ution is
>>> to have the vPMU state be saved on vmexit for all vCPUs.
>>
>> Do you really mean vmexit? It would suffice if state was reliably<= br> >> saved during context-switch-out, wouldn't it? At that point th= e
>> vCPU can't be resumed on another pCPU, yet.
>>
>>> That way all
>>> this having to figure out where and when a context needs savin= g during
>>> scheduling goes away. Yes, it adds a bit of overhead for cases= where
>>> the vCPU will resume on the same pCPU and that context saved c= ould
>>> have been skipped,
>>
>> If you really mean vmexit, then I'm inclined to say that's= more
>> than just "a bit of overhead". I'd agree if you real= ly meant
>> context-switch-out, but as said further up it looks to me as if >> that was already occurring. Apparently I'm overlooking somethi= ng
>> crucial ...
>
> Yes, the current setup is doing exactly that, saving the vPMU context<= br> > on context-switch-out, and that's where the ASSERT failure occurs<= br> > because the vCPU it needs to save the context for is already runnable<= br> > on another pCPU.

Well, if that's the scenario (sorry for not understanding it that
way earlier on), then the assertion is too strict: While in context
switch, the vCPU may be runnable, but certainly won't actually run
anywhere. Therefore I'd be inclined to suggest to relax the
condition just enough to cover this case, without actually going to
checking for "running".

What = ensures the vCPU won't actually run anywhere if it's in the runnabl= e state? And how do I relax the condition just enough to cover just this ca= se?

Tamas
--000000000000379f8405e9084ab2-- From xen-devel-bounces@lists.xenproject.org Mon Sep 19 14:18:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 14:18:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408785.651644 (Exim 4.92) (envelope-from ) id 1oaHbA-0001eh-Nb; Mon, 19 Sep 2022 14:18:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408785.651644; Mon, 19 Sep 2022 14:18:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHbA-0001ea-KG; Mon, 19 Sep 2022 14:18:12 +0000 Received: by outflank-mailman (input) for mailman id 408785; Mon, 19 Sep 2022 14:18:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaHb8-0001eS-Uf for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 14:18:10 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1cf6bc3-3825-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 16:18:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1cf6bc3-3825-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663597088; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KkpfSMbNKG9R+2YO41Ijpv1tQpYikTfshHrCmhB9Peg=; b=O9lAoksmiz1r54lJFDF/Pd2Ab3O5lHJxoONiWi89zmIVxIzcQ+jGUDiv XV17xDPx+ZAy8EYpA/EFg72lM4c4xiunHO9gG89arORT8OrRYxKbXh6gP 7VaATIMX5RQE/foLSADthaDQiXsWVGAHztcb8o3aJIwOZ5wyynXn4VCNA s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80826994 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3ALB6noqse4Hfd0/kgdGhtqaqJ+efnOphVZltV8?= =?us-ascii?q?MifNqXetXmJ2xPK1anx4FJ00kkjnHarUPUpu5siBHQZlyfxrspDZzCHZc7qt?= =?us-ascii?q?vZeKG7bGsruekzRALxkPUs+UEpRX5tPcWw4MrWR7Z1jU+m5SDYjuwQRJk2sO?= =?us-ascii?q?o7jg/e0qpvFJGU6U+g91+TvQLqyea/gpW2GKdll19h8e3Jzs7ZaonkIV98nS?= =?us-ascii?q?Typaw3fPgBMi3Y+ioyYdX5s86sOmIL3ek1imlPPu3/QtoHWjAKpQeZ9mqm8b?= =?us-ascii?q?V1b+ryeFcCMhpDvcbBLHCpB74ve/rtrNh0kk9uvZGP7gdDCzYHwVAAEgj3oL?= =?us-ascii?q?zTaBuiJEk81CsLFSmOFJ3hf3GuLTiKh6WO3dJsXT6aBlA3PQS//6GRDSE0ZY?= =?us-ascii?q?be16ko6ODWyCS87HxisgHm5czo2P+BFP+YMKw6/MNWXbIy55QxV0g16O4oMC?= =?us-ascii?q?+aQMIjqg/Y3GscYRvL+u4sjN6WKB5mRqx8fIwjPKqf4GJoJHUm7sEqVMRhAL?= =?us-ascii?q?KyrRazKlkjT1g5wGR5c0QgT2bL0c28g8MiHGTp8zDGWlHmcVR+60w0b7OC34?= =?us-ascii?q?PuN2vvNUsDdEvOYpBSvsnHHr5Bj1hlVG6mNo6VsHlBqbreOtIJVdT3ngAxoF?= =?us-ascii?q?kcM6PhVf02o7OD9b8vpfIV60IDDmkxPmyZWUlIJ46W3FqhpS5Tmn4s5iVSns?= =?us-ascii?q?PUetO9uQ3H2RbGGv6MLguDzr5G6qHF5O0bmytbc5UJPHUSo9e8zV/e4B6lM/?= =?us-ascii?q?XPQXl6zQMxslFLgzNqPgd395dj/gu9kn9NUsK9l3ifoKti2e03TrbWvqgVdY?= =?us-ascii?q?CXZhPa66x5TUPzwsBv25lpozFqP33Xanv+t6HglEbpMFiVha80+AiQgQ5XGm?= =?us-ascii?q?ZF4cKdOZ32I3PlO5NZssxSB1LftNAUFJUy/tqNSOSVbmMPjjjoe8r0lAjGPY?= =?us-ascii?q?zTqFvkwbxB9b1lXYqUdXR3EjV9OVYuhKACeWZFDQ2F7bE6m2NI5Xwi8ekk6v?= =?us-ascii?q?rDNnrpcmHQpwuyHOwgOX/QOQ9jxxwwEjWLSQDknlf+5D0zBBorJ82J8K2+kt?= =?us-ascii?q?4RfKgRa7YuSekpi5Br4BH444Htpc4hX7knO0V3rj/ZtJP++4K7NCBjyCoO2g?= =?us-ascii?q?JI/P97Hg31Jzvl47DwMEI7iiELFAdjnzZxQeOmZIXZNFN2yxwQW9me4cKN1H?= =?us-ascii?q?KphpP1VKhwUATYq/xQa1laV43OVilpX5PviGZ/hbxIvNK5Q+Uhl+zQ/7DhCT?= =?us-ascii?q?+Ei9pMUF+C5l1lH+E+WtX6XvYJI11yGCbB3idfFHeE6I9hM/NwwryfmU1YNd?= =?us-ascii?q?bb0NFQMbaBqAoKjYwZQ799htQB6g5z6ZjuYGR4arqedYIJTMiwHAdHKEYipd?= =?us-ascii?q?xVc6XHK4HtFcp2JtAni1tqC9D3S3FNEAPol4SOYPWGuXwUvNmrOur99A46jp?= =?us-ascii?q?k01l+CtBI6jACKaVFX0gxzdXgDZV6kmFMIalGnP5dYiLxtcftnYHUGqNBdhP?= =?us-ascii?q?DiJowFq9Scybarwb2GFeDpOJ3XeqPIvpj8badnx7KiByH9ry7VPl2LLVdWt6?= =?us-ascii?q?CzEizLIDNx0Mb3yk4A6GFgqGoVGanA4rxfBY1/Zi7ZeMFN5/oOmMR3bRAusb?= =?us-ascii?q?iQtsAufZZl74b0KMZdJm6/Iy+6Bfj5vkvWeAyN9MD3hEywVLaKvwZRrZX0yh?= =?us-ascii?q?/v3pp1MeCQ5zlQdUYXMaWO6rTTT3w/IObS94fRG3EFPqc2YQ9pE/sc1QP6Cr?= =?us-ascii?q?c6FzPDMOsuStPWkiKDN23NvV879WeT/24ZmFNoLEIszzBp2r1KF56gmfVu+z?= =?us-ascii?q?hfrX0MpXj5zO43d4TZ0Z0zECBn8Muj19v+kDTbMC9eqhzFFSk6ULqDSJqp5X?= =?us-ascii?q?4G3OfiCdtDaw9BJTx/5fw5mVuNsKSWWzDEEF0/FRZ+FhUoRxfob1Qd565Mfr?= =?us-ascii?q?LM37ZMGrlc9nNearGv+V+g05vz/nVvHGanrCeKtclkN/rPVcrf74wvfnWh5o?= =?us-ascii?q?5A1iiUOQmBRaCo7Y/vOIYYJRJgVk2qttBG0BU9pNS1GpuQ/a/lB2WtwfvhJ6?= =?us-ascii?q?8tgrWkgbUhqE4UYpWQa4b+WaICFQ6eWcT9m72QhCupYPIhsZDh2NkrBS333F?= =?us-ascii?q?/Ovv/viuZhqJYX7UtGpUE3tM0NXpVuslgENmwSAFiBvLZCgdVLmuX3K4yzar?= =?us-ascii?q?XejR8E3N0WoxBp9ma+HlK/GRNoOGtLqCvLt0n1kvId6h4JBMXgYtTd0LZwhY?= =?us-ascii?q?Lw3lUicr4riXtL1t+cQX33TQgvh3fCef1iKeWtMwefWVatAfvD+WYM7pnEL0?= =?us-ascii?q?ZrMQQNLDmcs+F0fjqU5gvyl+bwfTbQzaJy711pe3ZJw13cHEmP2jvzniwHkE?= =?us-ascii?q?VG/bdMlMAuq1VCFMYSQc3zjpuufl3NCQr5jxLBzjH9/7s+92ouGjoIBn4Tzw?= =?us-ascii?q?57p28++fA4pc8sa1nw2KCvNz3cpuTOp9uYoFN0tpvHOXLpBR83sxyGKQV0UI?= =?us-ascii?q?mvnHkoMAgjTu5KqOKoC4DNTxXmoELn2SYNmdHeI6RnyZyu/d5U3ghNDUaIBY?= =?us-ascii?q?sHQx0x5FwZlIfHqo6JaKEf5PnQ5Qt0ifZdAe3KBdq5EdVsYvXq6w8yM2PaYt?= =?us-ascii?q?PkcaxznLxhO5fLj/DvT3S7C7K4/1WUwWdt3SK9PLabq7GXz6I6yWVfSojd+X?= =?us-ascii?q?iG2aJrCfJr7WVHmZ2BoDTP9Kqb1fjIlDgua2/VxNgMvUsWpPTSLRs02HIxbq?= =?us-ascii?q?GzWgItMUtN1WhObK+0MP26dYROEm0+X0dOMwMHg35KYOybw2dXnYV5aL+RPF?= =?us-ascii?q?u2POiQQCPxkPvLZSwUvSQM14Emko09rw4ro/rdujQomJkjoLt357BpP5OFRc?= =?us-ascii?q?ZdIVWCMYEViQ4CzzwqG0SAvisTxyV2Ti2ncYG24dXYB+kX21Q2zLBeI3smFJ?= =?us-ascii?q?4Zt5zgmAB3mY8GVr+TanHyBlKtM5PWwpI3RRPoMRS1PRhAD7hrxJBLVGvkI5?= =?us-ascii?q?/IxjwFFjresyrsAzyG6APIB5NXFA0XeOXEZpE+r5NWKe84p0hmrOvY6UHF8h?= =?us-ascii?q?gy/+bFSyFchhrRsscyJQjhVOh/9DbdMij/Am03Z/nVhYrm2FDvT9v1RcYQGn?= =?us-ascii?q?g=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,328,1654574400"; d="scan'208";a="80826994" Date: Mon, 19 Sep 2022 15:18:02 +0100 From: Anthony PERARD To: Jan Beulich CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "Bertrand Marquis" , Volodymyr Babchuk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Subject: Re: [XEN PATCH v3] build: Fix x86 out-of-tree build without EFI Message-ID: References: <20220919102831.17438-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Sep 19, 2022 at 01:02:52PM +0200, Jan Beulich wrote: > On 19.09.2022 12:28, Anthony PERARD wrote: > > Acked-by: Jan Beulich > with a remark and one more adjustment: > > > --- > > > > Notes: > > v3: > > - back to using common-stub.c > > As said in person, I'm a little puzzled by this, as the v2 discussion > had no hint in that direction. I think it's because the discussion continued on V1, and I mostly follow that: https://lore.kernel.org/xen-devel/5d926715-b6af-234f-9798-622cdb53f181@xen.org/ > > --- a/.gitignore > > +++ b/.gitignore > > @@ -280,6 +280,7 @@ xen/arch/*/efi/ebmalloc.c > > xen/arch/*/efi/efi.h > > xen/arch/*/efi/pe.c > > xen/arch/*/efi/runtime.c > > +xen/arch/*/efi/common-stub.c > > xen/arch/*/include/asm/asm-offsets.h > > xen/common/config_data.S > > xen/common/config.gz > > The new line wants inserting a few lines further up, to retain sorting. Oops, forgot to re-sort after renaming from "stub" to "common-stub". > Can perhaps be done while committing. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 19 14:56:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 14:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408794.651655 (Exim 4.92) (envelope-from ) id 1oaICM-0005qJ-Qo; Mon, 19 Sep 2022 14:56:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408794.651655; Mon, 19 Sep 2022 14:56:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaICM-0005qC-Md; Mon, 19 Sep 2022 14:56:38 +0000 Received: by outflank-mailman (input) for mailman id 408794; Mon, 19 Sep 2022 14:56:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaICL-0005q6-D9 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 14:56:37 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00077.outbound.protection.outlook.com [40.107.0.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41d8fb73-382b-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 16:56:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6838.eurprd04.prod.outlook.com (2603:10a6:20b:10a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 14:56:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 14:56:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41d8fb73-382b-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y3EaANv2CHxoj4V2/3ffJF1W6d/GwfY2X9kLdoA0M7pGPoTGb3jhcnJXHBTW3LNGLduvUjIZ+yBNIL7MMiJnH8BnjSiF+BXSAeUyz3DN1x1ZyXI+nSmSsBv+SuACTqK3TPJlZFaUfbfcNVIKdU1F8o5sWgJC7Zu4D7Y7iOwGJQj064AvT1QPkIp+flM9VxZygXlDwz6nbMezKEuecLxYhYAFNHhkz9IAumDugiF1i6YsUOCBYflB2DJxYtosSrlQpxqvOXt3tM4u/qXr3J70Tek+Jt+W6htOWaRSby299rGALCAunDswnkO+2aThy9MwY+MS5l1NVF1t+8Np42worA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYa2cO6OR55n+mZdOPe8nbfglTyz7w+xNjEemBx/x1g=; b=KA1vl+I5AJD8fU9hDy9+3Fl5qhAFGGCjBqyycExp4OV6fFXTjMGk5VME6cs+sYhrc9dlsV4PPl2ldNJUftcIpzzB/tsKfntqtcMp11/iHsC6HNcUkcgOoPHjYHAgkpn+6/Y5OyfZts1UO0xw1xJbzPKU/5W3GP6fYytD/c4FQSutPGPcqLoeg2/Q+BELwZo9OOg/PzfFlc3uRRBdAc7REPYECdQrf0l7ug9c6e9bnv6q329TiWQy5XVZzFahCsYwapnmfPjGIzemP7YGxNzqU4oGkQG9FKotDNtXopxsAu3NU6DIPVkBkogLp8C40BeOq+sO+nzwR0cWvdKEhkfwXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYa2cO6OR55n+mZdOPe8nbfglTyz7w+xNjEemBx/x1g=; b=fKyPCnmOyo53ts3mbMldWqpfd0I71oD23dC4QcxZ3vk/a/iieaMSCQqw8tCIvdFNHnEc9/Y43ttt/lOcIVlbzPgqko3FGazPqouKdqO40x2TO33B4GIU7q+iqfhLFaS83aAloE81g5+Xwz893XNHDzx8RHDhNlMw4yXRhaW/5FUpQ8199D/JarZ5C8lzcwzjkrfqnWMcXmxrQYFxSYuW/Ab8XYKMH5/9TSskJPYC6aoHqGdFO5C42etW6zKQNes+b01KK79EHxuZp5w2BVhgKmRuVca9+MeWKbDTIFBdPqNrpgDTd9H9xGsiR7eR517dLNJQeLk46MPcSO21hx/lnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> Date: Mon, 19 Sep 2022 16:56:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Boris Ostrovsky , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6838:EE_ X-MS-Office365-Filtering-Correlation-Id: e3b90610-96e9-4b96-7169-08da9a4f2476 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 73TDYTIa5xYn6gBElGCD+DgWzI8I0fGQtOUYgq7U+r+ff6eFAqUA6p/i5md6cYPToTKDWlqBBPyWuxpu5JsKHtuoNBkobTv+cOMVxOKp6tSqjZ+qcETZE//nPYGw4x+k7nT7B1xE9nDR4ze1rydHa/47XFc1wTQ7EV3az9nv/mKWXKkzsVnJ9prP6lOslk3bt66NQTCgtHJEPrk43yPCZED+tBiKGRYYvvA+QhGBDtXYw3MZ/5SSSuQHr5ynBuMimO+TPbVvtGDd75jS403s0yX9qdMQTE4u4DAlfvjfCvKhR9Pq4pPooJNTZRxUxjWPf6vWPtw8Hy0tXrI6xYfbehWrkSA9fhlQEARz93FqQGrMs3ncLMYUD5c9CkU+Eee2Gn9RhBliZDPW9K36JSYheLkRFyEAPOcmynD3Y6Lq9eC8n0KE7Bo2So2PcJQhbbSo59cDqnIaMigTBT4GKMg70bCc3GE12rGypiOaBFsGndq9ZdXShhEmg+EKppqv5GyfEnHBRS1o1PilT8o4VZrECgZMI/elyDH6NaQzSuaQKtoCssd0xa/jCqpR6FRIALu9mu3M6Dr1UB5LRvAJSKVdga7yVQC6ilxReJm/KZvLxDCt4/b75tYQQVDHVFSiNNFmN1yXLjeX+EF28+8a9JpAHlf/K99q4fh5ZREkgkO6525oEhMx9yzruO9FDWv4S4NzwONghg79UN35arP667I4zFQHqvv8QRcypYPJ8Q5fVSHPGOgjyQowUkwgNBKshxqhc8wG7aVAGv2FMmmkWHCqLQTEBjYDK1kvQypHnm8MDFmKyIwLCpbxEzooGThuVOO7mwbG3pNedHzANErMTpW0zg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39850400004)(396003)(346002)(366004)(451199015)(66946007)(4326008)(5660300002)(8676002)(66556008)(66476007)(54906003)(31696002)(6916009)(86362001)(8936002)(316002)(66574015)(38100700002)(83380400001)(53546011)(41300700001)(6486002)(6506007)(478600001)(2616005)(186003)(26005)(6512007)(31686004)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTl4R09JVDIxZDhRRXQ3RVpZNGVuM1VrUU1qK3R0T1pyKzBoNnRoeXNPVEN2?= =?utf-8?B?QXo4RE9QRTlrclZpTUNtdHptVlJnaGVUQU1OT3BuMU1BZXBOSm5TbFptcUw3?= =?utf-8?B?VGNYc3djWFBPdnpZdE01QU8xVFNyeWtQdW1kWnNpQUt3SUlCUkhZNWJHU000?= =?utf-8?B?elZIZHBPS0k5Mmo0ejlHU3cvNUsrYS9YdE12TjdMUnBYcnMyOGUxcjVhMS9v?= =?utf-8?B?SmNSWElMZkNJREtMazZIZ1o0NWZnRmMxR1NJaFJ0MG4xUWVEbWFBVmRKenZD?= =?utf-8?B?N3ltTmpSVDlNZWxQeURpTnBCY2tLTlBhbnc5RzlVWS9nQlZLRmo4SkgxUEtS?= =?utf-8?B?L1JKYmw1S1pPaXZlRGpDZkdhWUdoRk8yTzNpNFJreGNtUzEwcTM2NVV3TGRS?= =?utf-8?B?SytFV0xzMEVSaVAzckNyN1NXZk0wQ01KSTc0by9adjhaNUhmRGpkN0tCTTVO?= =?utf-8?B?Sk52UXhiN1BDZ0VKRm9DekJ6MGhjSkhLd1lQbTFadkhiVC8wYnpKYUswWVVR?= =?utf-8?B?dTdpNG5mS0xQYkF5SHJkM3Q3bFNGaXdkWER3ckpWeUltT3FaVFU5THZxTW4w?= =?utf-8?B?OHhaenNsS2prKzNXUDE2YlFRTTc3cStXS250TzZETmF0TWZYVHBkeDhLaUFW?= =?utf-8?B?Wi9ySDRUN3dnektXZ0pucm9jRHZaVDdSc3NMTXVOMGMyQWMrUFJ4Y0svcFNz?= =?utf-8?B?ekI4WWRnMkpHeThOWWtsZ3dpV0taS2s1TUU1M3k0WVZ4S0tmV0JGRklBT2xa?= =?utf-8?B?dFdWTGVsd2dLeGs0SFZnOFBSbE9pUE5EdDlzT0dPeWdsYWtHSTluNis2d2J0?= =?utf-8?B?a1d3a1drTWZ2OVFlRHdQNGxsc3lRZ1hIazM5enVYdmY3T3ByaUhuMVFkVTJu?= =?utf-8?B?UkFWUG9wVW52bmc2Sk9MdDdXUCtiQzlMcUlJTG56VlRoSG00TllkOHRmRWxI?= =?utf-8?B?TnVQeTZhVy9peWIvZGZ2MTRjelMxdFpzYUJTQkNQQTlFQTYwNnRVSjNtcWxj?= =?utf-8?B?di8xR3FZSERnSXR2SWUzei9oSWQ4K2Vka0Nqb2FZV2Vld3pRN3JuNjlsb2ov?= =?utf-8?B?UWNqTkpqc0ZwdGoxakdpRzN5c0RFMnBZQVFqVWZtSjhIaVRpMWRldHpqejhF?= =?utf-8?B?eGhPaHgwcU90NGxlSVBYVU9STU9hajMvb0ZiOHBzaE5XT3FwVDZ0aUROYnNY?= =?utf-8?B?OFJmRHFmZ3ZvOHZzSWpQNG05c2J0ZERPOVZZVUlBNkdaZGdtSVl1RGptN05j?= =?utf-8?B?MVM0M1ozdmFzcEdqM3NyU3hZeUNkS1RVMGpQbnZxNC85eStJRXg0bDNvYjRa?= =?utf-8?B?aklFNC9POEdUZE1Xa0Y2RWdrUm12Y1Vyc2NhYUxrZ3E3MGlFbzR3YW0yLzlE?= =?utf-8?B?KzY3QW0wRXVqL041SDFNbWxQMmp0eVFlbGFENjQxaDR6L21tSHJFL1pHUW8w?= =?utf-8?B?NjRiRE5HVm5JbWtrekJwSHZvSEZTbTRNM3FHRHRvaERvamZJVGVITDcwWDF4?= =?utf-8?B?REtuU2pYMXRxVW1NK0Q5NnNSS3RyTG00MkY0WjI0VEJ2Q2t4ZHByVW9XcElI?= =?utf-8?B?K1p1SFUzN2VJL2pjSjVaT1h6VjdvTGwrVUJ1RWtRVFVCMnBFRGNQNFFJUUpl?= =?utf-8?B?RENYclNFTnFNSjBoMmpkU29YTFlXWmVzeENpNVduaGc1TUkxbFlZZW0zd0J0?= =?utf-8?B?azhwa1NtUVlmb2xmODNLejh0N01Gd2R3MlpBcmE0cllpSUlRK2VQSmVERThS?= =?utf-8?B?QlpXOUV1OUZXdUZPVWxXMnpQWTRTT2hZQzFERmtjaWNRYkZZNmk0RHZ3U0lt?= =?utf-8?B?R1hySHZHK29RQ00wVVVxbnpkcEZ0djFOckV0bkpWdFVQWUl1NUJDeDFOUVBa?= =?utf-8?B?MEdVZnZlZ2UvU0FlNjZGdC84Nno2cUNyM3Qvb3FucFEvS1luUjFyZTY4R20z?= =?utf-8?B?aHJOSERFQUxqV3VQcHNXVGIveVlaU2QxdklzOTVRazJCWXRsNmttM3k0QlY4?= =?utf-8?B?S1BCYmhpazY0TlR6aTk3N01UNExDT3QwdFhEd2ZVdVh2SFN3MEJIRmM0Nldp?= =?utf-8?B?Skd3MmJSaTRMNGYxVTNSVjNvS1VVSG9WOEdCNURDRGVOUTB4K0k3ZGNGT1F4?= =?utf-8?Q?swv99cwwEHnjgRZy3vN4200np?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3b90610-96e9-4b96-7169-08da9a4f2476 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 14:56:33.2901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zId2lAScBtBzt7hLBSuYcYhkCVlT8mK7cqfbg9AVoSmD2OYmLLlJzIGR8y0ijr5vWwC3If1MqsmWwXRba3aEUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6838 On 19.09.2022 16:11, Tamas K Lengyel wrote: > On Mon, Sep 19, 2022 at 9:58 AM Jan Beulich wrote: > >> On 19.09.2022 15:24, Tamas K Lengyel wrote: >>> On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich wrote: >>>> >>>> On 19.09.2022 14:25, Tamas K Lengyel wrote: >>>>> On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: >>>>>> >>>>>> On 16.09.2022 23:35, Boris Ostrovsky wrote: >>>>>>> >>>>>>> On 9/16/22 8:52 AM, Jan Beulich wrote: >>>>>>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: >>>>>>>>> While experimenting with the vPMU subsystem an ASSERT failure was >>>>>>>>> observed in vmx_find_msr because the vcpu_runnable state was true. >>>>>>>>> >>>>>>>>> The root cause of the bug appears to be the fact that the vPMU >> subsystem >>>>>>>>> doesn't save its state on context_switch. >>>> >>>> For the further reply below - is this actually true? What is the >>>> vpmu_switch_from() (resolving to vpmu_save()) doing then early >>>> in context_switch()? >>>> >>>>>>>>> The vpmu_load function will attempt >>>>>>>>> to gather the PMU state if its still loaded two different ways: >>>>>>>>> 1. if the current pcpu is not where the vcpu ran before doing >> a remote save >>>>>>>>> 2. if the current pcpu had another vcpu active before doing a >> local save >>>>>>>>> >>>>>>>>> However, in case the prev vcpu is being rescheduled on another >> pcpu its state >>>>>>>>> has already changed and vcpu_runnable is returning true, thus #2 >> will trip the >>>>>>>>> ASSERT. The only way to avoid this race condition is to make sure >> the >>>>>>>>> prev vcpu is paused while being checked and its context saved. >> Once the prev >>>>>>>>> vcpu is resumed and does #1 it will find its state already saved. >>>>>>>> While I consider this explanation plausible, I'm worried: >>>>>>>> >>>>>>>>> --- a/xen/arch/x86/cpu/vpmu.c >>>>>>>>> +++ b/xen/arch/x86/cpu/vpmu.c >>>>>>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t >> from_guest) >>>>>>>>> vpmu = vcpu_vpmu(prev); >>>>>>>>> >>>>>>>>> /* Someone ran here before us */ >>>>>>>>> + vcpu_pause(prev); >>>>>>>>> vpmu_save_force(prev); >>>>>>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>>>>>> + vcpu_unpause(prev); >>>>>>>>> >>>>>>>>> vpmu = vcpu_vpmu(v); >>>>>>>>> } >>>>>>>> We're running with IRQs off here, yet vcpu_pause() waits for the >> vcpu >>>>>>>> to actually be de-scheduled. Even with IRQs on this is already a >>>>>>>> relatively heavy operation (also including its impact on the remote >>>>>>>> side). Additionally the function is called from context_switch(), >> and >>>>>>>> I'm unsure of the usability of vcpu_pause() on such a path. In >>>>>>>> particular: Is there a risk of two CPUs doing this mutually to one >>>>>>>> another? If so, is deadlocking excluded? >>>>>>>> >>>>>>>> Hence at the very least I think the description wants extending, to >>>>>>>> discuss the safety of the change. >>>>>>>> >>>>>>>> Boris - any chance you could comment here? Iirc that's code you did >>>>>>>> introduce. >>>>>>> >>>>>>> >>>>>>> Is the assertion in vmx_find_msr() really needs to be for runnable >> vcpu or can it be a check on whether vcpu is actually running (e.g. >> RUNSTATE_running)? >>>>>> >>>>>> You cannot safely check for "running", as "runnable" may transition >>>>>> to/from "running" behind your back. >>>>> >>>>> The more I look at this the more I think the only sensible solution is >>>>> to have the vPMU state be saved on vmexit for all vCPUs. >>>> >>>> Do you really mean vmexit? It would suffice if state was reliably >>>> saved during context-switch-out, wouldn't it? At that point the >>>> vCPU can't be resumed on another pCPU, yet. >>>> >>>>> That way all >>>>> this having to figure out where and when a context needs saving during >>>>> scheduling goes away. Yes, it adds a bit of overhead for cases where >>>>> the vCPU will resume on the same pCPU and that context saved could >>>>> have been skipped, >>>> >>>> If you really mean vmexit, then I'm inclined to say that's more >>>> than just "a bit of overhead". I'd agree if you really meant >>>> context-switch-out, but as said further up it looks to me as if >>>> that was already occurring. Apparently I'm overlooking something >>>> crucial ... >>> >>> Yes, the current setup is doing exactly that, saving the vPMU context >>> on context-switch-out, and that's where the ASSERT failure occurs >>> because the vCPU it needs to save the context for is already runnable >>> on another pCPU. >> >> Well, if that's the scenario (sorry for not understanding it that >> way earlier on), then the assertion is too strict: While in context >> switch, the vCPU may be runnable, but certainly won't actually run >> anywhere. Therefore I'd be inclined to suggest to relax the >> condition just enough to cover this case, without actually going to >> checking for "running". >> > > What ensures the vCPU won't actually run anywhere if it's in the runnable > state? The fact that the vCPU is the subject of context_switch(). > And how do I relax the condition just enough to cover just this case? That's the more difficult question. The immediate solution, passing a boolean or flag to vpmu_switch_from(), may not be practical, as it would likely mean passing this through many layers. Utilizing that I have Jürgen sitting next to me, I've discussed this with him, and he suggested to simply check for v == current. And indeed - set_current() in context_switch() happens a few lines after vpmu_switch_from(). However, going back to vmx_find_msr() I find that the v == current case is already included there. Which makes me wonder again - what exactly is the scenario that you're observing the assertion triggering? Would you mind spelling out the call chain, perhaps by way of the call stack from the assertion? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 15:05:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 15:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408804.651666 (Exim 4.92) (envelope-from ) id 1oaIKY-0007Nu-Qh; Mon, 19 Sep 2022 15:05:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408804.651666; Mon, 19 Sep 2022 15:05:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaIKY-0007Nk-Mz; Mon, 19 Sep 2022 15:05:06 +0000 Received: by outflank-mailman (input) for mailman id 408804; Mon, 19 Sep 2022 15:05:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaIKW-0007NU-NF for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 15:05:04 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e98468b-382c-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 17:05:03 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 043C25C03B4; Mon, 19 Sep 2022 11:05:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Sep 2022 11:05:00 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 11:04:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e98468b-382c-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1663599900; x=1663686300; bh=odLXxxvz6nzbkbzsLziod48m46GNXZ+65lY HR3Efirk=; b=IkFyEF7Zhk7LlFdQFWorz3dd5x8SvrrW4HjqEDxh7jpQSqLAcGt tVjuD5y1RtJ4rjS4qH3YJkHn/ahyJs9pb7T8xIkaXjPr+Z7yJlZh5nYg6KOan5Pl QNj+rYq2CajRVJwotRKxI/OdYudWZF82ZlUNPOlPA75c0O4H5ew6aLAiE+nmVSIl fNWxDFULqwnAHXZkFD4y3bZzzq7a/q+TmDe2A7BAKBdHEUaVcr23Cx077U6kl0aV tsIgSvyRcRK1gHfRy0TkncOLDY85zfXcjBj1jkN0J1GxKVlyddwdQF7SJUUdchcj OWzN7ati0VbqR3IT40bRIe75ehN8X+b+epw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663599900; x=1663686300; bh=odLXxxvz6nzbk bzsLziod48m46GNXZ+65lYHR3Efirk=; b=PmBJAMzXRHMaSGce8Xp8ZudPA1c6V Fw7+aeUyVQHlsqq5DlP8JFG6WejWKSF1Yx5F1hwX+SZx7wEPeuWpPAzuXczUx7iU bbDvxwzTzJiCgEoBy80WXTOUlu7D70R+kNm0OijQVTfGQvLPI8baYHq8lQY40A1f 2KyYxN9YHfBs2idPIXlfvVyUnbr3b/9+eN4RrsVo/DDI5T3qtNKH0HVQ5t+zkW01 dVIgCOSW4zPDG3bY0bMBxYgVgoXtAXrD67bxDfsZa4YDmCxbz1BIHWQRR5ijH2SJ S6eW4DzzN3HnfKYYk2E4m/iEvadrl7GvNOdTBiHJsKw8HI3b5ThHct+DA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvjedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues Date: Mon, 19 Sep 2022 17:04:53 +0200 Message-Id: <20220919150453.29927-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Documentation for credit2_runqueue=all says it should create one queue for all pCPUs on the host. But since introduction sched_credit2_max_cpus_runqueue, it actually created separate runqueue per socket, even if the CPUs count is below sched_credit2_max_cpus_runqueue. Adjust the condition to skip syblink check in case of credit2_runqueue=all. Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a runqueue") Signed-off-by: Marek Marczykowski-Górecki --- The whole thing is under cpu_runqueue_match() already, so maybe cpu_runqueue_siblings_match() isn't needed at all? --- xen/common/sched/credit2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 0e3f89e5378e..9b8ca4d5ae24 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, unsigned int cpu) * * Otherwise, let's try to make sure that siblings stay in the * same runqueue, pretty much under any cinrcumnstances. + * + * Furthermore, try to respect credit2_runqueue=all, as long as + * max_cpus_runq isn't violated. */ if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran != SCHED_GRAN_cpu || - cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) ) + cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) || + opt_runqueue == OPT_RUNQUEUE_ALL) ) { /* * This runqueue is ok, but as we said, we also want an even -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 15:10:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 15:10:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408814.651676 (Exim 4.92) (envelope-from ) id 1oaIPq-0000NA-Dz; Mon, 19 Sep 2022 15:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408814.651676; Mon, 19 Sep 2022 15:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaIPq-0000N3-BN; Mon, 19 Sep 2022 15:10:34 +0000 Received: by outflank-mailman (input) for mailman id 408814; Mon, 19 Sep 2022 15:10:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaIPp-0000Mx-VC for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 15:10:33 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34834d54-382d-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 17:10:33 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B28525C0382; Mon, 19 Sep 2022 11:10:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 19 Sep 2022 11:10:31 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 11:10:30 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34834d54-382d-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1663600231; x=1663686631; bh=SsHRX7ivaPDrWcKxpWksUgGOVgR6mEQwwJ9 Ag7XUYB4=; b=JW/gPK7d71tLzzL8RfvLcc9UIOy6CIOBdgiVNFndKdmtg//33pb Bf8P9vhlHngJfgmEcL2yB77cLNvNUe2bQQTQa02E1MIyHl0waz+C22gejquHA3JA 0z7RBfZGu+TXrqkIaAgS4e09BIod4/zVWc3TNfS04Q5xRNmtPg9DfbKuRKv+Nevz 4+4afMgEMhwix/Yl8vf0lGog+MmLMjmBfluZfCXIfU4s3q4QQG4eeN7VeVyUZd9P N9mu/d7pAZjHCFHAoS93fvP3fEQE2eVho4c9gNS7jPDW7Ikuvlhxge3gFe0m++vh 2K81ycrlk/w2K31vp5of2q+b2QDOowkcijw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663600231; x=1663686631; bh=SsHRX7ivaPDrW cKxpWksUgGOVgR6mEQwwJ9Ag7XUYB4=; b=LSrK/2rfFF0zzM7V3WohwUUyQM+2P BSK3N4cz2VTRXzLDpN7cgcz8TML7DtalCtz5R3ScB2bwUAVnSryxcdEKk4cgUbqD sG6OoRggQHV6OWrfjaPvzSHy1N9FBYj1Mumh7T00kdQqvjl+gRJwBdBJzdEoKM4P 8qQqrzSlf1h3ng1XpHvU1AGy4cN22q8kSJtW5d0CrcC4rWWH2va+dj7lY0b9qMZ2 xNGjHRN2R8iDm+SdQd3AEG0B2tO4VNu7LvwLNiAHOCAcb8yyB7wiSCJAE5QY/kRO AlcxrZcVsEQ+YUWFy+km0VzarvE2hRrO9Bl2Uwu0GnpNl9mBM13Qk3Www== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvjedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , George Dunlap , Dario Faggioli Subject: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues Date: Mon, 19 Sep 2022 17:09:28 +0200 Message-Id: <20220919150927.30081-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Documentation for credit2_runqueue=all says it should create one queue for all pCPUs on the host. But since introduction sched_credit2_max_cpus_runqueue, it actually created separate runqueue per socket, even if the CPUs count is below sched_credit2_max_cpus_runqueue. Adjust the condition to skip syblink check in case of credit2_runqueue=all. Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a runqueue") Signed-off-by: Marek Marczykowski-Górecki --- The whole thing is under cpu_runqueue_match() already, so maybe cpu_runqueue_siblings_match() isn't needed at all? [resent with fixed xen-devel address...] --- xen/common/sched/credit2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 0e3f89e5378e..9b8ca4d5ae24 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, unsigned int cpu) * * Otherwise, let's try to make sure that siblings stay in the * same runqueue, pretty much under any cinrcumnstances. + * + * Furthermore, try to respect credit2_runqueue=all, as long as + * max_cpus_runq isn't violated. */ if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran != SCHED_GRAN_cpu || - cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) ) + cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) || + opt_runqueue == OPT_RUNQUEUE_ALL) ) { /* * This runqueue is ok, but as we said, we also want an even -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 17:19:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 17:19:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408867.651707 (Exim 4.92) (envelope-from ) id 1oaKQ2-0005Ge-Vl; Mon, 19 Sep 2022 17:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408867.651707; Mon, 19 Sep 2022 17:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaKQ2-0005GX-R1; Mon, 19 Sep 2022 17:18:54 +0000 Received: by outflank-mailman (input) for mailman id 408867; Mon, 19 Sep 2022 17:18:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaKQ1-0005GR-B8 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 17:18:53 +0000 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [2607:f8b0:4864:20::d2c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21a403a9-383f-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 19:18:52 +0200 (CEST) Received: by mail-io1-xd2c.google.com with SMTP id r134so77501iod.8 for ; Mon, 19 Sep 2022 10:18:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21a403a9-383f-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ITpYqLR+bXSCs/G+SgS3cZYa1rXHQaZ/9kX7yDXaFac=; b=IJbzYe3Ab9ZGwq99AujxkiD9E6fvBnAJfwn6CMnSCBfQGhOpypywgojYPTN1Sn3flj kS04QYT54pB6+PFwKqV3QUKvK/YEu1qvmwzRtfoL6p8ggB3y+qOQd/eMEBS0czEwa/GT lGJ1eOTR6B39UuA1DvVCOZmh1I7dRjg12D2OEbm0ZQuO5TSzIAZAwVnI5b25NC4KVsm0 eu/cX/VymISAMW7LDAhrzDYxZ+2nlG6H43XICy3vfaBW4u2AcUEwxGLwoXnCW5xmabp3 FaIIvXZdgM3iJaZF4av+tiVaMOO3l9ktZfBve0/eIIUSS80+SGq5ql033lffdxdaRnSR 39kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ITpYqLR+bXSCs/G+SgS3cZYa1rXHQaZ/9kX7yDXaFac=; b=4Wf5s/hU99OfI6fBZm9fZa8tTb+fLVF89m6Q1RYw0v82DkwBUo+vbhkkhQpIsKYPu3 QmSiiqhZmAUzZWJgv9IKOdORd7nOfKYzIGQJhP0CMh1UCJbwDAOi1hhrzRvs4QsmaeFa EZPtxERC9nYOKSfshGfCHD69MM2KGgvYq1rKCrGQStARyorwdj0HnbuG9bPek/XpqdU/ wNxIjUwBvRcuRk7nN7F6e++FZ4zZahAEC2GmGpzQMVHxlIK8ke5Y2KFewy5H8P4yJtGJ 7b2nAnB7nCu3LH1NtuLoFfnzJwnuK3YYNg8tEabr5MsypMoADjir+XZIJwVnYYFOhnzL ol/g== X-Gm-Message-State: ACrzQf2wqp7EdVk0j8aklOM4jrpVLEC79sfuFmJtNgBpRh0GIZsWeGZj QTMdCrO6X9U/biPauvhoc1nUjREmRRutYTIBZ7s= X-Google-Smtp-Source: AMsMyM7CKNZYu0slHiffyHEluWyj7A3zdYu5sFJLLZ2XXeOIyfeHtOovsQSLRw3bV4jgtiYoSu0hQVlwCkuzwc4NAFY= X-Received: by 2002:a05:6602:1609:b0:6a1:899e:bf36 with SMTP id x9-20020a056602160900b006a1899ebf36mr7191878iow.121.1663607931226; Mon, 19 Sep 2022 10:18:51 -0700 (PDT) MIME-Version: 1.0 References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com> <20220915204029.1227112-1-jennifer.herbert@citrix.com> In-Reply-To: <20220915204029.1227112-1-jennifer.herbert@citrix.com> From: Jason Andryuk Date: Mon, 19 Sep 2022 13:18:39 -0400 Message-ID: Subject: Re: [PATCH 1/2] acpi: Make TPM version configurable. To: Jennifer Herbert Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, wl@xen.org, roger.pau@citrix.com, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Thu, Sep 15, 2022 at 4:41 PM Jennifer Herbert wrote: > > This patch makes the TPM version, for which the ACPI libary probes, configurable. > If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed. > I have also added to hvmloader an option to allow setting this new config, which can > be triggered by setting the platform/tpm_verion xenstore key. > > Signed-off-by: Jennifer Herbert > --- > docs/misc/xenstore-paths.pandoc | 8 ++++ > tools/firmware/hvmloader/util.c | 13 ++++++- > tools/libacpi/build.c | 68 ++++++++++++++++++--------------- > tools/libacpi/libacpi.h | 4 +- > 4 files changed, 59 insertions(+), 34 deletions(-) > > diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc > index 5cd5c8a3b9..7270b46721 100644 > --- a/docs/misc/xenstore-paths.pandoc > +++ b/docs/misc/xenstore-paths.pandoc > @@ -269,6 +269,14 @@ at the guest physical address in HVM_PARAM_VM_GENERATION_ID_ADDR. > See Microsoft's "Virtual Machine Generation ID" specification for the > circumstances where the generation ID needs to be changed. > > + > +#### ~/platform/tpm_version = INTEGER [HVM,INTERNAL] > + > +The TPM version to be probed for. > + > +A value of 1 indicates to probe for TPM 1.2. If unset, or an > +invalid version, then no TPM is probed. > + Hi, In patch 2, I think you want to expand this section for TPM 2.0 support. Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon Sep 19 18:13:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 18:13:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408874.651717 (Exim 4.92) (envelope-from ) id 1oaLH7-00030w-0P; Mon, 19 Sep 2022 18:13:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408874.651717; Mon, 19 Sep 2022 18:13:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaLH6-00030p-TL; Mon, 19 Sep 2022 18:13:44 +0000 Received: by outflank-mailman (input) for mailman id 408874; Mon, 19 Sep 2022 18:13:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaLH5-00030i-GY for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 18:13:43 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c90cb575-3846-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 20:13:40 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by MN2PR12MB4502.namprd12.prod.outlook.com (2603:10b6:208:263::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 18:13:35 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::badf:4ed4:db1d:e5d4]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::badf:4ed4:db1d:e5d4%3]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 18:13:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c90cb575-3846-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ao7FsFtwPzM1iolLbeEMBBV9em/Kayt+EYJpiBNAJDr/JX94/NV5K6A+JBaPvXoxdyAB2QNf8qVfYjd0IONLg6IQyuL9xJ4DTY8yQ6JnoC3xFB4E8ikMLVmPHiRcCTPfU2YVnuBU827h4AuuVPZquD91RAT3A8v1HZcf0lDq5oG4RZrP/ux4duYmc+1IWr8zyyK9SJ46oo/Zbt4+wweKJAO5+pz5v95zxvcNGqc3r2Tj7xCysoEIWhaeTlRRstnbdl5tXhARwvWnQPfTw6krN/f7+G/N46CxeB+PcfWmvI5EHnMEjW10u9aUkyIWEtfd/NGZp1HRbgpLOhzTFiehFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TddeYItWX+tu+s2zTYHM1m3sYMGMLNbNHHAkbEEfq1s=; b=LrdD81KNupU9FNu2UdHVvlJBEpFbf8ygMOgYwMBtTRQMito1LZ+3rjdSajqrWCU7HKnmP+GFE1MbHyZyySlIdGKwdxn/rioWIf8T15kVlyaFe945l7lg3+B9N3A3ke2dZ7JNCRfYtlzy8bilgUpQaNJIVbOajTf6cJtZKq8O/qMg+U4sFmtTjZqkemtLM5ZuY0CEqQlGQbMY8ZOZht+eBQ0YL81yRwDmQckItOIWft/3x9Elc1Hskbb8dJTpqjM7Bsu5p7Hu7ytHAQzvA8GvOG3VnqR5eIzU+JDrmvOe2wA3MR5mentFrhRhaMWWZnG4FBBLcOL+8Uci9qmtMIboJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TddeYItWX+tu+s2zTYHM1m3sYMGMLNbNHHAkbEEfq1s=; b=10TTL+baKr2W0qsdXTlpMKVTIQ5fMO0alTfPS9tV3D+EUtILWv6loUUQwCD2sTVcy4E7TqS+N36WbErfZWOkC3hLDCOaXR3jNNZtwOPonG9oQbQL+U3J/uWYqCFvyxaE3PHhvFHxOr1ZxWypJwnFD4zyd4gbprcC+tuJ3o78GbM= From: "SHARMA, JYOTIRMOY" To: "xen-devel@lists.xenproject.org" CC: "Mallela, RaghavendraPrasad (Raghavendra Prasad)" Subject: where are xs APIs defined Thread-Topic: where are xs APIs defined Thread-Index: AdjMU0z+DCbAdhQcS5m0EtpwYKQWwA== Date: Mon, 19 Sep 2022 18:13:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-19T18:13:33Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=4fa26e8d-5e7f-412c-becf-e471622aa051; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4297:EE_|MN2PR12MB4502:EE_ x-ms-office365-filtering-correlation-id: abb30ab4-5911-43ce-ba1f-08da9a6aab02 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dt5Clkw5WE2r9fgdjIz6nDYt9c1XYPf/KXKqgSc/wh2rqBNDr8mlSP+UbSvl1KzrK1c1nCPXu/l+K7+3nMaYyGNcpMHBnNHijPpPTx7V8gQk5NaBZJABZ6xQUCuw5WjjTGS7XR7SCaEx8pwQy3cRfd3bxk8bSH9CJcgApU4A2CVvYz0JEWvSyHZI/WYqp7q2ymOCeXUwJPQu9sYXGnqZlWtt9OVy8p55sORAI2sJFCOe+MdYw4AB22k3kydV4W+8Vee1I3nJdVP/4diaZo2itU35cZ/qUSAJNtSrPwQOGRA9zLYFLpD1dEcJYy2Z9iColmNllAhaVpFePtBMxb/iaEi13w7eB5IHJu23AdOeW4PKgRlyRc+zlLprf2heVEP8/TunPd7IKTTXAZaSkh0/hpHjYP5Ucmer6jm9MfrGeMSfxDCx6xNy2Rprd26N5jilVlFXI2EDWtcMr3hh2EkhlhTwcGpApgyVKmfoGacH4S3oPvNVjLjlsYQclZge7s0OOMc7FMFC6vhA6+wwPH1LcWN66M8IvWqzxzuRrrmKNcSiQTXIQXOQ4RwZDNd0ebu6aCID/XRbzQTmevhe0DhDCZHB+zUoappk2EeNf6AgYpdB/JXQLu2nD1OJu8CBq7FYs6++Pll921ZsFxzPTAPo8BbslujxHx7ahThIGSCH/KJr3YiKnBbZzHMcU1L8wamX6JWyy3cOZDu6nhpSPIfjcEEIuuAmOpcBWwkuA/kj/a1Abhx6UvWxysYw894WRg1jh0EX0YutWF/GeYQZH9cKVw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199015)(2906002)(38070700005)(7696005)(41300700001)(64756008)(6506007)(55016003)(4326008)(33656002)(8676002)(76116006)(66446008)(66476007)(66946007)(83380400001)(6916009)(558084003)(66556008)(316002)(52536014)(71200400001)(5660300002)(186003)(8936002)(86362001)(478600001)(38100700002)(26005)(9686003)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/daG2VB6oOLGaVXMFAennk9l9ZIXu2Z6RY8P5UH4wFeWM5YXb8kxzNumifvO?= =?us-ascii?Q?dk3mNC7F19FsORUJ/3475IaGR/ONlH4LkWa6yuo5gaztoPDISTHhl5bz8Sn+?= =?us-ascii?Q?ZGZ6bqEIlDzPAuPNaS3U6kGPuPI4mVBnx322Kbc33IJjtpEU5yMBgyss9thk?= =?us-ascii?Q?CKwyAhLCPtbK083Axz52a1VZ7mUpOt8z3XcS/LqtnqZv66IL0TTit90/IZQc?= =?us-ascii?Q?aTnT6YgrzvHVltB1UuAUbHWsHJGW+/POok4L5k6dDt1oevrWYXPP4GdXqrKk?= =?us-ascii?Q?JR7EnFtjhPcbtFYd4CPTDDrNTERtK8eRikilWymFAO81oLsLZlWjPwTxWGNS?= =?us-ascii?Q?1nAqAgFp7I86lgdo5/m+afUXcbaRJ/0pS/5yrgDhBXbV6x68pv6C1qTK4gdK?= =?us-ascii?Q?tfOh7x+fRAEbKmho2okfoAanGujegZMCSZoxW+lDZrVyViTl5vzk2t+kHrJJ?= =?us-ascii?Q?iau4jiAh6bVgYp71WaPWrj/P6nLEXd3bwvQko1owzbP+hf2orlcspkZ6bhPA?= =?us-ascii?Q?6SHxQf2zZMKnRG2XXCKqY7L3yX3ZDo2k8TR13g8SPE5hUwdSs8Pk7nPLXq5U?= =?us-ascii?Q?fmi9oujxsD6sUh/gyfF2mJmUoEhSEPOBHj+1EXdIEGcAPKCF9XJA2EkvNf1P?= =?us-ascii?Q?ZV0//pArl3ozFO1aKmOoV/9NOifsbMwI+643SIy5eQgyTwBf7Nzeuo659aK/?= =?us-ascii?Q?XitdVgcmkMhZPudSdhf2ZplWa/5C3EE4M1g5/xI49wbgGJn/RF7JMi5ighov?= =?us-ascii?Q?cTmqhXDI7A/1Wa5fsKpG9Dw5okbN58OZ5ao/RXCqliemKKNkZKMRc6B6hCnm?= =?us-ascii?Q?G7js6u5z+cfZ/cBXobdyg2ApHcnIdU8k3zLd67t6BTnW2j8DsjZFA9xun6PN?= =?us-ascii?Q?SvlEyuLaxcHHB1WrbI/ICEyFrkLUwz+dDIexWpZc+PUjFhnIzyPYKoVx/8Xv?= =?us-ascii?Q?ulMhNMvafI+FOW4MquY1jS+OWXI1VcMDkLbuLt5klRu1ZPJqBebUZV0zFFoj?= =?us-ascii?Q?ytGoArId697vLv++sVTuRwWUpwAtoU8Tqeb87VvZ3a38+78nhq7Pc3+HdDKY?= =?us-ascii?Q?Li7laAVszdTmP74ZKHGS5OMjKIhBWRhmraoQYDRA761vKglq89qu8Uw6WOZv?= =?us-ascii?Q?BCFo8LqgUf126fabZud/8D0MU65tX8xQQMnRd0sPOriuDmKNHGM+u8BzQXka?= =?us-ascii?Q?hD8ASTxA5axLg7aE+lYg6enuNNStOhyE5VhCZK4Nd75QIOnOxyPxd98kvzJI?= =?us-ascii?Q?N0kJN3Alsjlax4HJfxNeTHdkobWIQmcbCDTQQ+mWXKaIq7YW0/bTa2zglVFN?= =?us-ascii?Q?7wpZfeJRaGioVezWhsfhZzj+5eco7DOzYPymvdgeeVL1gbe2b6TW0A/N2H4d?= =?us-ascii?Q?zv2JCb32WNZb0hOmyK34WYblVeHCOnXHuagzD50g5NGE32CwQ6IP4XT2DxLT?= =?us-ascii?Q?p7GQP5gJdaTdDQnPgCxw2TexQJbU51bDp5MiC1Uh5pRI7/6/ABFx6IMq+8EJ?= =?us-ascii?Q?f6qRp63PDOxHespClZD8y1jimNwEbHYWWJ33uNrEzWGGF4yCPOcTagC430Dx?= =?us-ascii?Q?Fr4ahcWgS7yLcil+j2kteO9YyL3CXUV61/6pU5iL?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB4297953EB76ED8376286F8199F4D9DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abb30ab4-5911-43ce-ba1f-08da9a6aab02 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2022 18:13:35.2483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AviVDwRDyiiS/pW6VVNcZMIlh3WVL5nqiq/A075oFk3XPRojewwNfpEKFU63ghWLhIXKTL1DRtVmHu2uI7m14A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4502 --_000_DM6PR12MB4297953EB76ED8376286F8199F4D9DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hello, I am looking for the source code where Xenstore access APIs like xs_open(),= xs_read() are defined. Please help. Regards, Jyotirmoy --_000_DM6PR12MB4297953EB76ED8376286F8199F4D9DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


Hello,

 

I am looking for the source code where Xenstore acce= ss APIs like xs_open(), xs_read() are defined.

Please help.

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB4297953EB76ED8376286F8199F4D9DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Mon Sep 19 18:38:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 18:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408883.651728 (Exim 4.92) (envelope-from ) id 1oaLeY-0005WL-1m; Mon, 19 Sep 2022 18:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408883.651728; Mon, 19 Sep 2022 18:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaLeX-0005WE-Tc; Mon, 19 Sep 2022 18:37:57 +0000 Received: by outflank-mailman (input) for mailman id 408883; Mon, 19 Sep 2022 18:37:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaLeW-0005W6-Om for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 18:37:56 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2074.outbound.protection.outlook.com [40.107.94.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c5c9eaf-384a-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 20:37:55 +0200 (CEST) Received: from BN9P221CA0026.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::24) by CH0PR12MB5387.namprd12.prod.outlook.com (2603:10b6:610:d6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 18:37:51 +0000 Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::7c) by BN9P221CA0026.outlook.office365.com (2603:10b6:408:10a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Mon, 19 Sep 2022 18:37:51 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Mon, 19 Sep 2022 18:37:50 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 19 Sep 2022 13:37:50 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 19 Sep 2022 13:37:49 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c5c9eaf-384a-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfS1TMHKzPnioeD0vg7FUkyic4qhUTBSJhEUeYcGCTo+FGPrqfw/AfhATNIMiSANwqkZaaujXP0HmIQ67cXtP+slfZkXf7Fitbq8ERSLfSGVL3K22DEM28RJq2kyyPkWZJeKtG7vX8NrxEKewA5EZhyQ671CusA5xKs4qYg1aF2yNX0B4uBJHTLXecC4Rr7ECfvOXh+VWAJGWgXjmWM5UGbLNzTEqsHIpextTSMy3VPT6PHUJTQ/OghW95prOm2legifjJAgsUUyX59TnF8RPOJKKVx25JZLum2jI0GHoL3ho8+nF6/KyTTuF86wTvfbcZKtFcBQ3+DRu2aw+uuaRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L6Sabc4pZq9IA1rmU3S2UQoeU2Nxuf8Lvhkj3rNxmAY=; b=YzsTrj+g5MULMHLwDduAbn2GSd4tJ6F0mkNjJcU/vDDVNH6IQNJqf5MjF+HXlRjewlyMswADv7LlBnYrpKRk8KdT42kahkHWteYxUIkvXUvZr8fwT3qwK1kCCjg095qkw7fL1yh2csKHBM5yG1/vz8sohiTzI7Z2LsGXX9RAbv3XVFjGa3EFxo1fLKpfaCJsmm1yl9+Hs60J5tGTSKVNeXslYnS8RjIxnHfJFCgg3KH+vaIzNmRWHicrG6BewEWPv561bLx7vGvtHtxgn+KLS7Mxb374oR+BvaC79ud8Ho9jNDQ81BjZTlBmD9gVhkm2Xh4o94tJOFwBZ2qdr+Z5Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L6Sabc4pZq9IA1rmU3S2UQoeU2Nxuf8Lvhkj3rNxmAY=; b=qREgYJTrslErtUurPMHsnnFHRfbmbyrkazNOKDf8H7Hm5lvDbypbLjut9oaWxlOe/58BqRxjemADgpGi2yHFPmQlG+AfxvSep7x6H97ogyVI5S6rznZOZfmeQdeNbpgzlGYIrlBNhcp8VDc/iBKYPmaC9639QS6UBp5dtRb0zM0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [for-4.17 v2] xen/arm: domain_build: Always print the static shared memory region Date: Mon, 19 Sep 2022 20:37:37 +0200 Message-ID: <20220919183737.14067-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT022:EE_|CH0PR12MB5387:EE_ X-MS-Office365-Filtering-Correlation-Id: 43b901a7-4785-4474-a61f-08da9a6e0ebd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NsfQvwfNzNtst29+i2FP+cH5IyApxvRKzby99dUS0UhPisOguscE/Qf9bFkp5C9fQ6IKLNqAI4ibFp675OJuQlkZYkueUfqhlROYzsW531wgY5+OoCFAWI+L3SvkTMfs+/r3b4KNjvFFNY8IL6T4LzY2cUdiA6ttU5Nz1h7LgU1R3uvBUtfuAfZDbfkrk7hRPfxzn5mehtltCADeak7L/DzRyoEvFxpHjzZ4utf1dDZ8nZ2iX3or7DXkLSuR4OwC0DTr+zOsobCc1XZi+sj5FG9zXqLDyxVXiHZtJ3OTJ4FBqEcIKNYwziCIgKn9E0CDF7OGkv+WraQeAaalq1qpo1V3dvIeToZAMDDH1r1thwCPh2YXzaHNsXU3Pq/OGwi/NoBCW5NVVV5XSbFeptdKUYnFikrD8mjXfBRPx83/Jm/BXh7ZmlZn9Mbrwxh8NaQmMlnT2jM29a6DRUVZfEbLp18SR4Udv3TmZdVC2sBoMmdiWB3yUk1ICfKpgPJAyasVC0JhdqEdRNcqJrbvDt+TB5kLzCr30CgWUXeZlZ/jZzKFjQABmUQMTscB5pg/9Ke8Z1HHg2dUEFqG9JZqwx23c320vg9mIrUGITXyHFybDdjaSbXEk98dwjbsVJ7wD1sKzTbpWgeMApKGWaQ7cMZJ+y8XAamF9dWTVMy64CR8dj8f7gLcRSrYPYovYMzO/BFXhIFJenDNzQ4ZaE5HrQ9N8Z5UC0YSbW+N1raLAx90+Yz0l73Ro7+FttltPlHO3AZyxo7ZyVNrJnIK/0hXwfdatQtBl/QriA65Jl0BNYrnG5I= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(40470700004)(46966006)(36840700001)(2616005)(2906002)(54906003)(44832011)(82310400005)(41300700001)(356005)(36860700001)(6666004)(40480700001)(4326008)(8676002)(70206006)(70586007)(83380400001)(6916009)(426003)(336012)(40460700003)(1076003)(316002)(5660300002)(36756003)(47076005)(186003)(8936002)(86362001)(478600001)(26005)(81166007)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 18:37:50.9955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43b901a7-4785-4474-a61f-08da9a6e0ebd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5387 At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel --- The other motivation for this patch is to be consistent with regards to the format of the informative logs. We do not really use dprintk with XENLOG_INFO unconditionally as it results in printing additionally filename and line number which may be misleading for someone reading the boot log. Such extra information is helpful on error conditions to make the process of debugging easier. Rationale for taking this patch for 4.17: Useful information printed always instead of only during the debug build. Changes in v2: - use different argumentation - drop XENLOG_INFO --- xen/arch/arm/domain_build.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 01c2aaccd82d..40e3c2e1195c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -844,9 +844,8 @@ static int __init assign_shared_memory(struct domain *d, unsigned long nr_pages, nr_borrowers, i; struct page_info *page; - dprintk(XENLOG_INFO, - "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", - d, pbase, pbase + psize); + printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); smfn = acquire_shared_memory_bank(d, pbase, psize); if ( mfn_eq(smfn, INVALID_MFN) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 19:10:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 19:10:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408889.651739 (Exim 4.92) (envelope-from ) id 1oaM9r-0001Ch-G6; Mon, 19 Sep 2022 19:10:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408889.651739; Mon, 19 Sep 2022 19:10:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaM9r-0001Ca-DQ; Mon, 19 Sep 2022 19:10:19 +0000 Received: by outflank-mailman (input) for mailman id 408889; Mon, 19 Sep 2022 19:10:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaM9o-0001CU-RI for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 19:10:17 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0e031b9-384e-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 21:10:14 +0200 (CEST) Received: from zn.tnic (p200300ea9733e79d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e79d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CC4751EC01D2; Mon, 19 Sep 2022 21:10:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0e031b9-384e-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1663614609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=mu2esohdM2sPF1b210YRZnBukLG7jBgVAsUUa3wE11E=; b=QLTTFmFiZtmxou/z76o527wSr6qZCJkH0qFFhBzI5BpmHtqIGuw/zQPA/v1DvgfSqcKY+V YBT9Iiu4FIfQnCerKuBmbTK+QShttbY4Cw5pIoA78zSEkHWB3oZx/xO76gi+VaVuxfdgrk 6y43x6orRu6tHVz23i7XkbsSyaqpqTE= Date: Mon, 19 Sep 2022 21:10:05 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-4-jgross@suse.com> <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> On Mon, Sep 12, 2022 at 11:10:29AM +0200, Juergen Gross wrote: > In the end this variable doesn't specify which caching types are available, > but the ways to select/control the caching types. > > So what about "memory_caching_select" or "memory_caching_control" instead? _control sounds like the right thing. As in, which of the memory caching things the kernel controls. Along with a comment above it what this exactly is. Yap. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Sep 19 19:25:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 19:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408895.651750 (Exim 4.92) (envelope-from ) id 1oaMOl-0002me-R0; Mon, 19 Sep 2022 19:25:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408895.651750; Mon, 19 Sep 2022 19:25:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaMOl-0002mX-NE; Mon, 19 Sep 2022 19:25:43 +0000 Received: by outflank-mailman (input) for mailman id 408895; Mon, 19 Sep 2022 19:25:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaMOj-0002mR-MK for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 19:25:41 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7dcc260-3850-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 21:25:39 +0200 (CEST) Received: from zn.tnic (p200300ea9733e79d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e79d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6AE7D1EC01D2; Mon, 19 Sep 2022 21:25:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7dcc260-3850-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1663615534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=F9PypRJJonu/owp4xrRfoXhBJ3jDL2onqnjEb1GXu3Y=; b=e73OG2H0WGw9U8n57rAKIiTBCILi25gC0NTfDGY8v21Yznj6PkJjSepxXE+TLVdgVuXfBP JTb1vTweHpXufHSi//l9bVP40yg3OS7zY3NuanLnAgGopwqabn4DwvIdJ+nJlG3iOB19h3 O+cPJ4/A4lxbtmRf0RizHjQwCcaMCTA= Date: Mon, 19 Sep 2022 21:25:30 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 05/10] x86/mtrr: split generic_set_all() Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-6-jgross@suse.com> On Thu, Sep 08, 2022 at 10:49:09AM +0200, Juergen Gross wrote: > Split generic_set_all() into multiple parts, while moving the main > function body into cacheinfo.c. > > This prepares the support of PAT without needing MTRR support by "Prepare PAT support without ... " > moving the main function body of generic_set_all() into cacheinfo.c > while renaming it to cache_cpu_init(). The MTRR specific parts are > moved into a dedicated small function called by cache_cpu_init(). > The PAT and MTRR specific functions are called conditionally based > on the cache_generic bit settings. > > The setting of smp_changes_mask is merged into the (new) function ... and so on. So the commit message should not say what you're doing - that should be visible from the diff itself. It should talk more about the *why* you're doing it. ... > diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c > index 47e2c72fa8a4..36378604ec61 100644 > --- a/arch/x86/kernel/cpu/cacheinfo.c > +++ b/arch/x86/kernel/cpu/cacheinfo.c > @@ -1120,3 +1120,22 @@ void cache_enable(void) __releases(cache_disable_lock) > > raw_spin_unlock(&cache_disable_lock); > } > + > +void cache_cpu_init(void) > +{ > + unsigned long flags; > + > + local_irq_save(flags); > + cache_disable(); > + > + /* Set MTRR state. */ Yeah, and when you name the functions properly as you've done, you don't really need those comments anymore either. > + if (cache_generic & CACHE_GENERIC_MTRR) > + mtrr_generic_set_state(); > + > + /* Set PAT. */ And this one. > + if (cache_generic & CACHE_GENERIC_PAT) > + pat_init(); > + > + cache_enable(); > + local_irq_restore(flags); > +} > diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c > index 5ed397f03a87..fc7b2d952737 100644 > --- a/arch/x86/kernel/cpu/mtrr/generic.c > +++ b/arch/x86/kernel/cpu/mtrr/generic.c > @@ -731,30 +731,19 @@ void mtrr_enable(void) > mtrr_wrmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); > } > > -static void generic_set_all(void) > +void mtrr_generic_set_state(void) > { > unsigned long mask, count; > - unsigned long flags; > - > - local_irq_save(flags); > - cache_disable(); > > /* Actually set the state */ > mask = set_mtrr_state(); > > - /* also set PAT */ > - pat_init(); > - > - cache_enable(); > - local_irq_restore(flags); > - > /* Use the atomic bitops to update the global mask */ > for (count = 0; count < sizeof(mask) * 8; ++count) { > if (mask & 0x01) > set_bit(count, &smp_changes_mask); > mask >>= 1; > } > - > } > > /** > @@ -854,7 +843,7 @@ int positive_have_wrcomb(void) > * Generic structure... > */ > const struct mtrr_ops generic_mtrr_ops = { > - .set_all = generic_set_all, > + .set_all = cache_cpu_init, I was gonna say that this looks weird - a set_all function pointer assigned to a init function but that changes in the next patch. But yeah, I like where this is going. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Sep 19 19:33:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 19:33:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408901.651760 (Exim 4.92) (envelope-from ) id 1oaMWH-0004EX-Iy; Mon, 19 Sep 2022 19:33:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408901.651760; Mon, 19 Sep 2022 19:33:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaMWH-0004EQ-GH; Mon, 19 Sep 2022 19:33:29 +0000 Received: by outflank-mailman (input) for mailman id 408901; Mon, 19 Sep 2022 19:33:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaMWF-0004EK-T5 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 19:33:28 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec9adca7-3851-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 21:33:25 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6224732002D8; Mon, 19 Sep 2022 15:33:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 19 Sep 2022 15:33:22 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 15:33:20 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec9adca7-3851-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1663616000; x= 1663702400; bh=/wIED5ZiGUUNAQXfShqAlwSBTSaTfAqoWYXPaDLttnM=; b=h kgJ2ZUpFUNE/ZQE8nR28FjzCOVEuiYm5BYxbPBkgODqYWDnsj/NUC4X5ybuG/WZ6 y/tRocPfez+HYk8xG4p3JkPIWg4C87kqbCoOWE+HlbfFlfMx1tuXb94FFdrdB570 c7IwsCYk0Mj6vGlU6QOoSsxXBLIiZp44PLKiPCKco+6FNgHiVZx6rhNvBLkzrOtX kQsFbsLjCBw06pw4n4+qM1KenlOiVyl/egWTm+QWUvEkME30hErWQRBSUWvCEMWZ HKRFkO+xhoCvoF0zdsqUz2BfVU0EQRh+Z6a2au5oWVb6Eil/3wX8AN7mAAHRCdI+ huCqplCSuPbN0wlj6yEUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1663616000; x=1663702400; bh=/wIED5ZiGUUNAQXfShqAlwSBTSaTfAqoWYX PaDLttnM=; b=AAEJAHuptd0YMViwiHVvpODaKlcUwqPwKy99WZfKt49l4Y6WgHI WLOtdD+Wkw9y79Q5u45HecJ2nWYG1JY0lJ/F/i5R/woJ1Wzynhsrv6JvgIdDbJOZ p5nn8lwV8/qiPWLU5yJ64+jyVc8Vc54jgO527H6Mdjim4qjTSj6ZLvOP28Q5O/mO flmL8F6zCjmTNrNXBL0+RGhxUpEhW1uOdq/2mKY+d4FW8RvVnCpVn4rW2GY11drx iIzQY2VmO5mWzVH7JS1kU1QdwwbydXGlezMTgSefxfJfoSM00HUQJ3CjzDa92xID V9y8TwftmQZBVtf8jPjyACEDNklcDLbzhlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvjedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvfeegkedvkefgffegkefhieejtdff keehhfelheefjeeutefgleeggfdtveeileenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Ard Biesheuvel , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Demi Marie Obenour , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3] Support ESRT in Xen dom0 Date: Mon, 19 Sep 2022 15:32:57 -0400 Message-Id: <20220919193257.2031-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fwupd requires access to the EFI System Resource Table (ESRT) to discover which firmware can be updated by the OS. Currently, Linux does not expose the ESRT when running as a Xen dom0. Therefore, it is not possible to use fwupd in a Xen dom0, which is a serious problem for e.g. Qubes OS. Before Xen 4.16, this was not fixable due to hypervisor limitations. The UEFI specification requires the ESRT to be in EfiBootServicesData memory, which Xen will use for whatever purposes it likes. Therefore, Linux cannot safely access the ESRT, as Xen may have overwritten it. Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData memory, Xen allocates some memory of type EfiRuntimeServicesData, copies the ESRT to it, and finally replaces the ESRT pointer with a pointer to the copy. Since Xen will not clobber EfiRuntimeServicesData memory, this ensures that the ESRT can safely be accessed by the OS. It is safe to access the ESRT under Xen if, and only if, it is in memory of type EfiRuntimeServicesData. When running as a Xen dom0, check if the ESRT is in memory of type EfiRuntimeServicesData, and if it is, parse it as if not running under Xen. This allows programs such as fwupd which require the ESRT to run under Xen, and so makes fwupd support in Qubes OS possible. Signed-off-by: Demi Marie Obenour --- Changes since v2: - Massively updated commit message. - Fetch the ESRT inline in drivers/firmware/efi/esrt.c, instead of using a single-use helper in drivers/xen/efi.c. Changes since v1: - Use a different type (struct xen_efi_mem_info) for memory information provided by Xen, as Xen reports it in a different way than the standard Linux functions do. drivers/firmware/efi/esrt.c | 71 ++++++++++++++++++++++++++++++------- 1 file changed, 58 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 2a2f52b017e736dd995c69e8aeb5fbd7761732e5..378bf2ea770ad3bd747345a89258216919eb21bb 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -28,6 +28,11 @@ #include #include +#ifdef CONFIG_XEN_EFI +#include +#include +#endif + struct efi_system_resource_entry_v1 { efi_guid_t fw_class; u32 fw_type; @@ -243,27 +248,67 @@ void __init efi_esrt_init(void) void *va; struct efi_system_resource_table tmpesrt; size_t size, max, entry_size, entries_size; - efi_memory_desc_t md; - int rc; phys_addr_t end; - - if (!efi_enabled(EFI_MEMMAP)) - return; + uint32_t type; pr_debug("esrt-init: loading.\n"); if (!esrt_table_exists()) return; - rc = efi_mem_desc_lookup(efi.esrt, &md); - if (rc < 0 || - (!(md.attribute & EFI_MEMORY_RUNTIME) && - md.type != EFI_BOOT_SERVICES_DATA && - md.type != EFI_RUNTIME_SERVICES_DATA)) { - pr_warn("ESRT header is not in the memory map.\n"); + if (efi_enabled(EFI_MEMMAP)) { + efi_memory_desc_t md; + + if (efi_mem_desc_lookup(efi.esrt, &md) < 0 || + (!(md.attribute & EFI_MEMORY_RUNTIME) && + md.type != EFI_BOOT_SERVICES_DATA && + md.type != EFI_RUNTIME_SERVICES_DATA)) { + pr_warn("ESRT header is not in the memory map.\n"); + return; + } + + type = md.type; + max = efi_mem_desc_end(&md); +#ifdef CONFIG_XEN_EFI + } else if (efi_enabled(EFI_PARAVIRT)) { + static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); + + struct xen_platform_op op = { + .cmd = XENPF_firmware_info, + .u.firmware_info = { + .type = XEN_FW_EFI_INFO, + .index = XEN_FW_EFI_MEM_INFO, + .u.efi_info.mem.addr = efi.esrt, + .u.efi_info.mem.size = ((u64)-1ULL) - efi.esrt, + } + }; + union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info; + int rc = HYPERVISOR_platform_op(&op); + + if (rc) { + pr_warn("Failed to lookup ESRT header %lu in Xen memory map: error %d\n", + efi.esrt, rc); + return; + } + type = info->mem.type; + max = info->mem.addr + info->mem.size; + + /* + * Recent Xen versions relocate the ESRT to memory of type + * EfiRuntimeServicesData, which Xen will not reuse. If the ESRT + * is not in EfiRuntimeServicesData memory, it has not been reserved + * by Xen and might be allocated to other guests, so it cannot + * safely be used. + */ + if (type != EFI_RUNTIME_SERVICES_DATA) { + pr_warn("Xen did not reserve ESRT, ignoring it\n"); + return; + } +#endif + } else { return; } - max = efi_mem_desc_end(&md); if (max < efi.esrt) { pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n", (void *)efi.esrt, (void *)max); @@ -333,7 +378,7 @@ void __init efi_esrt_init(void) end = esrt_data + size; pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end); - if (md.type == EFI_BOOT_SERVICES_DATA) + if (type == EFI_BOOT_SERVICES_DATA) efi_mem_reserve(esrt_data, esrt_data_size); pr_debug("esrt-init: loaded.\n"); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Sep 19 21:30:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 21:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408984.651807 (Exim 4.92) (envelope-from ) id 1oaOL7-0000v9-QW; Mon, 19 Sep 2022 21:30:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408984.651807; Mon, 19 Sep 2022 21:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaOL7-0000uT-NL; Mon, 19 Sep 2022 21:30:05 +0000 Received: by outflank-mailman (input) for mailman id 408984; Mon, 19 Sep 2022 21:30:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaOL7-0000lQ-75 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 21:30:05 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37e223c7-3862-11ed-9647-05401a9f4f97; Mon, 19 Sep 2022 23:30:02 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 28JKl0ox092890 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 19 Sep 2022 16:47:06 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 28JKkxYl092889; Mon, 19 Sep 2022 13:46:59 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37e223c7-3862-11ed-9647-05401a9f4f97 Date: Mon, 19 Sep 2022 13:46:59 -0700 From: Elliott Mitchell To: Demi Marie Obenour Cc: Xen developer discussion , netdev@vger.kernel.org Subject: Re: Layer 3 (point-to-point) netfront and netback drivers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Sun, Sep 18, 2022 at 08:41:25AM -0400, Demi Marie Obenour wrote: > How difficult would it be to provide layer 3 (point-to-point) versions > of the existing netfront and netback drivers? Ideally, these would > share almost all of the code with the existing drivers, with the only > difference being how they are registered with the kernel. Advantages > compared to the existing drivers include less attack surface (since the > peer is no longer network-adjacent), slightly better performance, and no > need for ARP or NDP traffic. I've actually been wondering about a similar idea. How about breaking the entire network stack off and placing /that/ in a separate VM? One use for this is a VM could be constrained to *exclusively* have network access via Tor. This would allow a better hidden service as it would have no network topology knowledge. The other use is network cards which are increasingly able to handle more of the network stack. The Linux network team have been resistant to allowing more offloading, so perhaps it is time to break *everything* off. I'm unsure the benefits would justify the effort, but I keep thinking of this as the solution to some interesting issues. Filtering becomes more interesting, but BPF could work across VMs. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 21:41:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 21:41:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.408992.651819 (Exim 4.92) (envelope-from ) id 1oaOW2-0002bc-1A; Mon, 19 Sep 2022 21:41:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 408992.651819; Mon, 19 Sep 2022 21:41:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaOW1-0002bV-UO; Mon, 19 Sep 2022 21:41:21 +0000 Received: by outflank-mailman (input) for mailman id 408992; Mon, 19 Sep 2022 21:41:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaOW0-0002bP-DZ for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 21:41:20 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca7769d1-3863-11ed-bad8-01ff208a15ba; Mon, 19 Sep 2022 23:41:18 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6A0453200344; Mon, 19 Sep 2022 17:41:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 19 Sep 2022 17:41:15 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 17:41:14 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca7769d1-3863-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663623674; x= 1663710074; bh=jxWV4dOsyu+3ryQjpZlY6LkzMcupG8P/PjnrR48KzuY=; b=f LAeN9703nShbmPg1TjvHQIv53lVcCoR0R7E1NYQAmYMp73uWORkpr0FQTvwuqPiy 9oiBCZe1xkJj56kVXtWp5UqzBednGKBzDiQdBL8wzz4++//aFiW7T1dR6osuHXla Pgk2LRSIZ4/yh8eZ1/MaU4mQV4XsMOPNGMdY29eIBkeyIxBeAcuqGYV/1YH9FWih 83xu1bW33f2roFzNBUvqfdurXqbJCzsBLh3vENzdCYTYBVPD0uvajbBmv96bnpYQ qaXFUupQVJaiLoEhMNxQPdu/+ohpCUHYWo6P0CbXM/306uhlPZP9VIOX9cCBEMTt G0OD4rtcea9vb8xyu3gUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663623674; x=1663710074; bh=jxWV4dOsyu+3ryQjpZlY6LkzMcup G8P/PjnrR48KzuY=; b=RTlFKHngI/6dbbfCx0myS2/BZgKuPxor/kUBYhNRqw4S MxqoSfQQuxZmlJmQ8Xp4Yg7C+m0UQz0w6KJtiQtQrp/hlnZvwyx6XcXToVsYFzP0 KtxNt7nyDwop9gF85AFApsjWywULOuvnrR86sIc9fHwfy2b6hNk55MQxBjnY9u86 lCBR+Tz02qXDDNqX1SVliTGGaDnDefO0Zishc+KM2uFPSvH2/gQoXs2CNOO7TEnE MaTupORFNSxLX++KJW8mDKzVJiVfdokYucufcVZlfxe9aVxcqMIr+f3UOcgg3SSh zmrSneKUaOQ9dm9L2H90JzP/OW6EEbu+Jf37TyOO+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvkedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 19 Sep 2022 17:41:05 -0400 From: Demi Marie Obenour To: Elliott Mitchell Cc: Xen developer discussion , netdev@vger.kernel.org Subject: Re: Layer 3 (point-to-point) netfront and netback drivers Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T0kr/1729fBpPed0" Content-Disposition: inline In-Reply-To: --T0kr/1729fBpPed0 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Sep 2022 17:41:05 -0400 From: Demi Marie Obenour To: Elliott Mitchell Cc: Xen developer discussion , netdev@vger.kernel.org Subject: Re: Layer 3 (point-to-point) netfront and netback drivers On Mon, Sep 19, 2022 at 01:46:59PM -0700, Elliott Mitchell wrote: > On Sun, Sep 18, 2022 at 08:41:25AM -0400, Demi Marie Obenour wrote: > > How difficult would it be to provide layer 3 (point-to-point) versions > > of the existing netfront and netback drivers? Ideally, these would > > share almost all of the code with the existing drivers, with the only > > difference being how they are registered with the kernel. Advantages > > compared to the existing drivers include less attack surface (since the > > peer is no longer network-adjacent), slightly better performance, and no > > need for ARP or NDP traffic. >=20 > I've actually been wondering about a similar idea. How about breaking > the entire network stack off and placing /that/ in a separate VM? This is going to be very hard to do without awesome but difficult changes to applications. Switching to layer 3 links is a much smaller change that should be transparent to applications. > One use for this is a VM could be constrained to *exclusively* have > network access via Tor. This would allow a better hidden service as it > would have no network topology knowledge. That is great in theory, but in practice programs will expect to use network protocols to connect to Tor. Whonix already implements this with the current Xen netfront/netback. > The other use is network cards which are increasingly able to handle more > of the network stack. The Linux network team have been resistant to > allowing more offloading, so perhaps it is time to break *everything* > off. Do you have any particular examples? The only one I can think of is that Linux is not okay with TCP offload engines. > I'm unsure the benefits would justify the effort, but I keep thinking of > this as the solution to some interesting issues. Filtering becomes more > interesting, but BPF could work across VMs. Classic BPF perhaps, but eBPF's attack surface is far too large for this to be viable. Unprivileged eBPF is already disabled by default. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --T0kr/1729fBpPed0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMo4fgACgkQsoi1X/+c IsFzmA/9E0X+XvseW+IwtUzRhlUyXUex7IusyCAld76yiXh0XdPlKLUAXv3ue2Ef zAR7ewfTwbLQ/cJWFUjxOM6fIiCsexW5HAQ8/DACmvHATzGaBBsxBTVs0TKCveM5 Hn5nep8rQKW5vtQ/e5d0+y6Cwqt3Ya5H40YuitSDtjoUieKSYQoKMS4FPdM8MQWI sc7YPR57G3isR9Hb2+B9lmUFxj0Nq5T0esnfA7Uk3Lw102eJHFiTigqjPI3YTeBL EdcBEs5q/Rt8q0uDn3Rn4DuMZpxHyo3QxQXb5bgwpqLOerhEdg9UmAOAYK5fPUB1 IS8B+CvPEc/mb2y8QoVA9fvJxrCInfnA9DnvYpfFBAOxkNNB2DZuj202Lsd/R7MA oV1BrW7Zpr6LQ5hMRSlu2TrMnqnPHYUcbzCiu7Pxkvqw++RlG21slnwBg7CZ6MLl 5GTdbhfXRnLSr7X+1oG4OqU6+LVtffAAE5FpGMopKVxANkrE+9dxzezPQWWOE+C/ xjrA83kHNzJJqGaa862kP8kYo0AHvOBf62QeV5pZZ7zk3g/qRdQ5u1qvVjXz8ULj sTXYQWPlwCwQjtJrJQGm53fuOeTRmxGYOiTaRoreLq/xc/TvbgFaZuEe/UCHLnVd xQjhv7kGJTPfz8RtwqaiLZlmPf/PfmLuGPN8d/ZUHGIGQeQaKzY= =3tWA -----END PGP SIGNATURE----- --T0kr/1729fBpPed0-- From xen-devel-bounces@lists.xenproject.org Mon Sep 19 22:42:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 22:42:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409000.651830 (Exim 4.92) (envelope-from ) id 1oaPTD-0000Gp-L2; Mon, 19 Sep 2022 22:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409000.651830; Mon, 19 Sep 2022 22:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaPTD-0000Gi-Hy; Mon, 19 Sep 2022 22:42:31 +0000 Received: by outflank-mailman (input) for mailman id 409000; Mon, 19 Sep 2022 22:42:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaPTB-0000Gc-Ao for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 22:42:29 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54f9dac7-386c-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 00:42:26 +0200 (CEST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28JMQCnj028825; Mon, 19 Sep 2022 22:42:22 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jn6stda04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Sep 2022 22:42:22 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28JMXOoW016459; Mon, 19 Sep 2022 22:42:21 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jp3cmm98e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Sep 2022 22:42:20 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MW4PR10MB6511.namprd10.prod.outlook.com (2603:10b6:303:225::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Mon, 19 Sep 2022 22:42:18 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::70bc:4817:75d6:48d3]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::70bc:4817:75d6:48d3%6]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 22:42:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54f9dac7-386c-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : from : to : cc : references : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=ZUDRru5dXfisBBHvA9fyqdSqWDmQ2ycDGpseeBP+EQk=; b=LrKW5WY67h/ADONKFjQR1eChrGaBvkErgTf+yKP5DlEIdvvvyh8A6o3U+76Y8VTOmAYU Nu8jZj4sMHOFQFAsGjajvityM71G4VRekfB4B+/Ere0fA9CAJ5hWoFV+vdv/5giAokGL Y7ChMM8yysJdTz2ipz6GTe/7/+AIEuF4JssrRDMYNDhi9Ez6Oa2ttNh9LjfHA25Sc3VX PTBiEXRVYCQ7gcoaVAK6OkzWKDHmTd/0mK5VBK6xayuKgX9GgADYk3TcYPEqn/iigQ9S k/POaSkiH4svLChJa8hsVUWk5DqzJff++mOnwaQXx3wwGjbcEOkAgPD2sFesAWHQnzX1 Jg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWKzOXgzKRkUQOx/Z+yGkN2q4AfUbU2QDbKwBJsKuLVaoDEr8LRqilR0M8jDInEoCAonLRAzT7i1qf18lIpmeVQJpD1Q88Fk1tnaCRlosnVCjyDQPXcuMqB9n+evfUu0Hm/DEi7EXCdwROJxvR3+T6TZKxjqgVf9Nan6H7rwpZsbu0GxYHvo5fkDxbnvyvZ1IqfTsg3dCqXgQKeUM80hsmn0Lhqu7u9kVpdsMQssnjnIE4ye2eJ8nfFbGiXgMdeB1nsvG4klZlc68vWitsn9vMA2Fk57CbK0kfglPWnnxMjgiofqy2OzD+HA8kKfcnC3e3mtIsKfejGURF/3uM023Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZUDRru5dXfisBBHvA9fyqdSqWDmQ2ycDGpseeBP+EQk=; b=hVLkVXDTjslvGL960+OcEuNzWpgAI5ZA6pdDtXRrzZowezsgkI9ToqHAHm012nuYjvYo2tTvfq1jO8jo0lBcqMAtrhPwD/hhEC1bIjHjePl3V3mO+a7pDyJDFCjLeeUtjBFqv2hztBHTSaLNyTvv2E63LxlLvUxCjOsuvZ2YtY39w8MyZpF9/fHymkroWP0bTdiXe4MziFw7ff63RU+Kuopk47sjWLurRL4v7n7nE2mPkI7B/qG9BVkMJEblYo7kR0ERL/Khz2bH8lCOrE4gXesKNNEvEippTrjGbpygbuKFLw/LWaQrz0Ana2cW7NEoJw0H4erRaF6SLiusYBYYFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZUDRru5dXfisBBHvA9fyqdSqWDmQ2ycDGpseeBP+EQk=; b=pN3Wl0D7GaxkxyK2bjJ+nmuBCjNy+8Gg/N7KSwEjeKkwDF/hmUQXqE2TlMSiVgTtCc4BfBo27aM0c0VAyL3rwtWIGeH7VdcqHgv8RVLMh1qLF8zbfdiRlkM8bdDMgWf8wT+LMWJ8wzc7cNKoQdxm8okxgv0PRGj3ZtiOgxH2y0E= Message-ID: Date: Mon, 19 Sep 2022 18:42:15 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 From: Boris Ostrovsky To: Jan Beulich , Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> Content-Language: en-US Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load In-Reply-To: <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR11CA0007.namprd11.prod.outlook.com (2603:10b6:208:23b::12) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|MW4PR10MB6511:EE_ X-MS-Office365-Filtering-Correlation-Id: 79388891-8389-48ea-513b-08da9a903507 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jKCD/t+IDl5CO02G6nP/oBdp4etzLiJD0r1sssA/Jrnbg1zSnE8JwHxwPr17x+08xtigAG4rAsaDZiRnMw+jnSiDATHmr9oXFC3Kk/Dlg3tShP6S5evMAiz1mcKmpqvNIsPqxmNBeg7QGm6GyDHycHlkVrQHp0CR9tIYs+IWfxidZ66vgr7OzknrwD2juCl2FFVxMSZfiSeMC4YnR/fb7yi0rILoJHqZEicxG5CBAY0JoCoGoLDzeWPLhczU5BrCVhda1QtckOXlLAQEc/bSuobm65c9+Cq1labYmERKV8wtsO/foJKgg7StCilh20dYKUPcEUQslJLM8RIcKekwNZKrhv3b4EjMsZFEedDXkRTkqmdl5QNZOfu+0MzzCPy1busy5VK7echTm7d+isNjJObLJBnGhQZLswITh1QKa61Scal/xcSagv13OGxE21xRHGUjmY4S2OJaTiZ45rdM37ib+WXwhnwTdFQlqfHjgDUS88IQLdIwTBvlTzSae5CfoT6quH3aRtTV8fB+RxoX6RhT/fUWBN6zM0x8oDDOqvohfUrreJA05PF6ufYIuGsovYvauAgI/+fF9O23t8Qz3xlmTev17rAanvp8uhI9WCyPDErGBpsSmpbTywyogs3PcW5BqMkomu7yrYWT95TsMbFRKi9WsmkJQ9NqhIc06ZVAvZewlx2uBYeF3IZFuUgQhvHfc+gUWi30kWKfMZu6zBQJrsToxt4lTtWHSGFQZ0GSO34jtGMvycu6SrMZkpXFwTl1TW6C2VbIHk0l6qsXzGIMOVcvRNPvZ3YshEmF+Fk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199015)(66476007)(31696002)(36756003)(66946007)(44832011)(86362001)(38100700002)(5660300002)(2906002)(6486002)(478600001)(66574015)(66556008)(4326008)(8676002)(110136005)(8936002)(316002)(54906003)(186003)(83380400001)(41300700001)(6666004)(6506007)(2616005)(53546011)(6512007)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEV0SVRwNGVaVUhZYzVpck4rOHR3TGZXS0g4TkorUnNqY3ROOWE0SmpJVzlB?= =?utf-8?B?VjA0ZUdkak9VYW9VR2VLZDZHWERtQmhqWm1kQ3h1R3FIa051cVlINGFCZFI4?= =?utf-8?B?WldXaVIrZ3JuNXFPTC9UOGp1aERPcFVhNUpSREJpL3RWS3d6ZEFxc0tVY0lE?= =?utf-8?B?elBWSUJ6NE5LQTdFL2ZRdTVMYVlQK0dwYm10cUI0NlRNdnN6YXppSVRtMjI0?= =?utf-8?B?d3VpU2RqWGhSUmZxL0VWekNBKzh4eTIwd2pMRDMwYXdhWE1LQ3FHbzRXdTBU?= =?utf-8?B?aEtaY3phV2xHenEzZnlSTmpBNlVYUElWTDlzUHhES241Yk0zb2cxaDZ1RkRn?= =?utf-8?B?QWJRSFpoK1VQc2ZLYmNLbloveWRVQ21xT3QxM1VHMElQeGZBRkNjYm16Ui9Z?= =?utf-8?B?UzYycHZKOHM1VWZuMnQ3eUFybm9kbXlrUU5JakNZWkNhbHIzeUFqcmRFMS9h?= =?utf-8?B?dnZKcFRFUnhFSi9zd0NwUzJZVjNpRnpuczJ2MlM2TVEzYlpUOWhZNEpLSE5U?= =?utf-8?B?NXRCU0lvem1ySVBuSzJycFQzbUNxam1ZVjQwcE9Ta3VEeWo3b3dwVSs5WXNI?= =?utf-8?B?WWtCQ0x1aWZlcGRuUGhVU01aTDY0TUp4NDROQVRnT2RzTzgwdVFkczF6cXR0?= =?utf-8?B?SHlwdk1PQ2c4NDgwc08yaTFwMFdMbmxHMkRtN1E1aEU2T1c4TjQrWHVCMFVu?= =?utf-8?B?SnlwbTBOYkZ2eVR3Mm9jbitCbGtGTFVhVFZGVzUvbm41V0U0RUQ3bXBhVlBD?= =?utf-8?B?WkpKZk5oY0ZVU0M0MHc2Ky84dGNBMml2WEc4dEx5YVFUbjVpNkNLamllOGFX?= =?utf-8?B?dVJ6UnBjSk1FMDV1RE9VRElrQmUySEs5SWl2d21MYWxid2xmeEhiREZ1MDEv?= =?utf-8?B?a09LTWVIeStuQlBuOHVSb2VwUVBnL2pYR0FuRTAyb1FvV3ZNam5sVGg3SitP?= =?utf-8?B?ejBpaFRYdU1wV2hYOXNBNW9QVGN5ZjlxRWZiKzJEV2VLczVhVkc3Mm5rbU1s?= =?utf-8?B?SVI0bGRFSHpkUUROL2V4elpETnFVZnJWZzdoZGFpK1ZkbEdVbHRHVDlZdVVW?= =?utf-8?B?blRnVmhXRFBFSEtpQ2hEUld5OU5Pb1VLZHBWdmpQMldSU1FEcVA5OE9BelhT?= =?utf-8?B?Zkt4Yzd3cTVlaHJyUTcyYkJqbm9va0xLbzBvL2d5Z2tGMDZndkN0N2poSGhQ?= =?utf-8?B?NC9YSmYyeU1MK0NId29XbUdjQ21rWHpHeFMveHliYVFkUGlFTkhDK2pKck03?= =?utf-8?B?Q2JIdzZpSUU3YllaYUJSSHYxOGlZQTlCYUpiU1RENHp1a1habEFkVmxDd0R4?= =?utf-8?B?RDZXUWFQTkxlQjFxTGNRcDJqZTZqdUxwMUxoNU9LZFRoWndBb3BMZ3lkRmNG?= =?utf-8?B?NUdWNkVKenEvMWY1VVFBKzFEaUNQR2RncXp3WklNREhHMWd6Q0FXSk15bDNK?= =?utf-8?B?UU5aYVd3MlVDUlB6QkYxZCtTckdlY2xFLzM1dk94endLR043b0Yxc1lkT00x?= =?utf-8?B?eGV1Z0NacGZEZWs2OWE3Vlh0dkJnWHFRQUNibENxY1FHcUpTaFplWlJDYXFv?= =?utf-8?B?dUhGRXFURi9XbnZYeFZBbExaSTJ2WS9mLzBCSXNwa0U3d2l0T2xxeTRJN1Ro?= =?utf-8?B?OG1KRGVqc3BpRGxVemozeWVZQTJXN1Z5TlNaUkZWTGdFM3FsUE9VNTRoUE13?= =?utf-8?B?UFgxY1dMa3FkM0dpazc3RVN5eFRNSnQvZWVVRDFsUHNNd3d2ckgxeFdqWk9a?= =?utf-8?B?NEZtV3RmU3JLbStocmlvTnJodVF5QXpjVmM3QVRPU1FyRzVaK3puNFhMVGZx?= =?utf-8?B?K0pDU2JBa3pJTW4yK2FDTTBKTUo2RnNjcEM2Q05OQXNQSk9WZHpCU285b1lP?= =?utf-8?B?MEtTRkRPcEIwZDRqOWZKT0ZMWWl4dU9SMGJQQWUybnRzWjVBbnJkS1VFN01F?= =?utf-8?B?SHdoNWZySmcyK053SHdGZ3JvdUoxelptenBFTnRtWTlkd0xYeWRZR0IxYWRG?= =?utf-8?B?V3VMQUhuQ0Q3S0pidDJaVmdUQ2tjaFB4S0FMeUt5RmtNZ044V2x1WWlRNDNv?= =?utf-8?B?UUdybnRsZFdpSS93NUJRYngrQkE1NEhrclZLU1hUTHg4c29ibEV0Q0twOTEx?= =?utf-8?B?aXF1K3poUVp0YjRyM1lzRjV1OHR2SENZNjlEU3BzWE5nZkpRSWdIUlhFRlk1?= =?utf-8?B?Nnc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79388891-8389-48ea-513b-08da9a903507 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 22:42:18.2767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QdHwpdfh2HwyqUukMQUY0TU+UNGg3Dj5hNEeQY2x/OjdHgdn2/bqDb4Fap2na5cKyn0TSNjs+7Gs07c1+t0KpoRX8tm1c0VU4eNNEO4KX5w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6511 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-19_05,2022-09-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209190151 X-Proofpoint-GUID: Yja_HkMapCUZ8HWgVMVrI3KGvkxjw5ot X-Proofpoint-ORIG-GUID: Yja_HkMapCUZ8HWgVMVrI3KGvkxjw5ot On 9/19/22 10:56 AM, Jan Beulich wrote: > On 19.09.2022 16:11, Tamas K Lengyel wrote: >> On Mon, Sep 19, 2022 at 9:58 AM Jan Beulich wrote: >> >>> On 19.09.2022 15:24, Tamas K Lengyel wrote: >>>> On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich wrote: >>>>> >>>>> On 19.09.2022 14:25, Tamas K Lengyel wrote: >>>>>> On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: >>>>>>> >>>>>>> On 16.09.2022 23:35, Boris Ostrovsky wrote: >>>>>>>> >>>>>>>> On 9/16/22 8:52 AM, Jan Beulich wrote: >>>>>>>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: >>>>>>>>>> While experimenting with the vPMU subsystem an ASSERT failure was >>>>>>>>>> observed in vmx_find_msr because the vcpu_runnable state was true. >>>>>>>>>> >>>>>>>>>> The root cause of the bug appears to be the fact that the vPMU >>> subsystem >>>>>>>>>> doesn't save its state on context_switch. >>>>> >>>>> For the further reply below - is this actually true? What is the >>>>> vpmu_switch_from() (resolving to vpmu_save()) doing then early >>>>> in context_switch()? >>>>> >>>>>>>>>> The vpmu_load function will attempt >>>>>>>>>> to gather the PMU state if its still loaded two different ways: >>>>>>>>>> 1. if the current pcpu is not where the vcpu ran before doing >>> a remote save >>>>>>>>>> 2. if the current pcpu had another vcpu active before doing a >>> local save >>>>>>>>>> >>>>>>>>>> However, in case the prev vcpu is being rescheduled on another >>> pcpu its state >>>>>>>>>> has already changed and vcpu_runnable is returning true, thus #2 >>> will trip the >>>>>>>>>> ASSERT. The only way to avoid this race condition is to make sure >>> the >>>>>>>>>> prev vcpu is paused while being checked and its context saved. >>> Once the prev >>>>>>>>>> vcpu is resumed and does #1 it will find its state already saved. >>>>>>>>> While I consider this explanation plausible, I'm worried: >>>>>>>>> >>>>>>>>>> --- a/xen/arch/x86/cpu/vpmu.c >>>>>>>>>> +++ b/xen/arch/x86/cpu/vpmu.c >>>>>>>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t >>> from_guest) >>>>>>>>>> vpmu = vcpu_vpmu(prev); >>>>>>>>>> >>>>>>>>>> /* Someone ran here before us */ >>>>>>>>>> + vcpu_pause(prev); >>>>>>>>>> vpmu_save_force(prev); >>>>>>>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>>>>>>> + vcpu_unpause(prev); >>>>>>>>>> >>>>>>>>>> vpmu = vcpu_vpmu(v); >>>>>>>>>> } >>>>>>>>> We're running with IRQs off here, yet vcpu_pause() waits for the >>> vcpu >>>>>>>>> to actually be de-scheduled. Even with IRQs on this is already a >>>>>>>>> relatively heavy operation (also including its impact on the remote >>>>>>>>> side). Additionally the function is called from context_switch(), >>> and >>>>>>>>> I'm unsure of the usability of vcpu_pause() on such a path. In >>>>>>>>> particular: Is there a risk of two CPUs doing this mutually to one >>>>>>>>> another? If so, is deadlocking excluded? >>>>>>>>> >>>>>>>>> Hence at the very least I think the description wants extending, to >>>>>>>>> discuss the safety of the change. >>>>>>>>> >>>>>>>>> Boris - any chance you could comment here? Iirc that's code you did >>>>>>>>> introduce. >>>>>>>> >>>>>>>> >>>>>>>> Is the assertion in vmx_find_msr() really needs to be for runnable >>> vcpu or can it be a check on whether vcpu is actually running (e.g. >>> RUNSTATE_running)? >>>>>>> >>>>>>> You cannot safely check for "running", as "runnable" may transition >>>>>>> to/from "running" behind your back. >>>>>> >>>>>> The more I look at this the more I think the only sensible solution is >>>>>> to have the vPMU state be saved on vmexit for all vCPUs. >>>>> >>>>> Do you really mean vmexit? It would suffice if state was reliably >>>>> saved during context-switch-out, wouldn't it? At that point the >>>>> vCPU can't be resumed on another pCPU, yet. >>>>> >>>>>> That way all >>>>>> this having to figure out where and when a context needs saving during >>>>>> scheduling goes away. Yes, it adds a bit of overhead for cases where >>>>>> the vCPU will resume on the same pCPU and that context saved could >>>>>> have been skipped, >>>>> >>>>> If you really mean vmexit, then I'm inclined to say that's more >>>>> than just "a bit of overhead". I'd agree if you really meant >>>>> context-switch-out, but as said further up it looks to me as if >>>>> that was already occurring. Apparently I'm overlooking something >>>>> crucial ... >>>> >>>> Yes, the current setup is doing exactly that, saving the vPMU context >>>> on context-switch-out, and that's where the ASSERT failure occurs >>>> because the vCPU it needs to save the context for is already runnable >>>> on another pCPU. >>> >>> Well, if that's the scenario (sorry for not understanding it that >>> way earlier on), then the assertion is too strict: While in context >>> switch, the vCPU may be runnable, but certainly won't actually run >>> anywhere. Therefore I'd be inclined to suggest to relax the >>> condition just enough to cover this case, without actually going to >>> checking for "running". >>> >> >> What ensures the vCPU won't actually run anywhere if it's in the runnable >> state? > > The fact that the vCPU is the subject of context_switch(). > >> And how do I relax the condition just enough to cover just this case? > > That's the more difficult question. The immediate solution, passing a > boolean or flag to vpmu_switch_from(), may not be practical, as it > would likely mean passing this through many layers. > > Utilizing that I have Jürgen sitting next to me, I've discussed this > with him, and he suggested to simply check for v == current. And > indeed - set_current() in context_switch() happens a few lines after > vpmu_switch_from(). It is saving vpmu data from current pcpu's MSRs for a remote vcpu so @v in vmx_find_msr() is not @current: vpmu_load() ... prev = per_cpu(last_vcpu, pcpu); vpmu_save_force(prev) core2_vpmu_save() __core2_vpmu_save() vmx_read_guest_msr() vmx_find_msr() The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder though whether this call is needed when code path above is executed (i.e. when we are saving remove vcpu) -boris > > However, going back to vmx_find_msr() I find that the v == current > case is already included there. Which makes me wonder again - what > exactly is the scenario that you're observing the assertion > triggering? Would you mind spelling out the call chain, perhaps by > way of the call stack from the assertion? > > Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 19 22:43:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 22:43:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409004.651840 (Exim 4.92) (envelope-from ) id 1oaPTj-0000kr-Tk; Mon, 19 Sep 2022 22:43:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409004.651840; Mon, 19 Sep 2022 22:43:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaPTj-0000kk-Qw; Mon, 19 Sep 2022 22:43:03 +0000 Received: by outflank-mailman (input) for mailman id 409004; Mon, 19 Sep 2022 22:43:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaPTj-0000aW-48 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 22:43:03 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a2bb0a0-386c-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 00:43:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 47CC2618CB; Mon, 19 Sep 2022 22:43:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F421C433C1; Mon, 19 Sep 2022 22:42:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a2bb0a0-386c-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663627379; bh=7QmkftuHXBne/ZLjnwy/flj1EAb7/w9UQ9aVHuADPgE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZPuJIGsLwqekZRodOUntiwBxIrqFUvmRnfe5zpvXmtPmWKe+39Dpcim//HArU+qmV K+26qzGaqumats0m9Mr2jqaDh6Dci19Nj7Oyvtjh2sNlCOlM/K60gMn3M14vvdPpHq C/s/6xYQxeVq/XKe4kb69uNKQG8hjRM9H4xXXarPukcNsZ1pEaa34TLert1deFiZ5R HroOirTamRppm33Mm4CAgG4Uy9Suebt1/tGIuPXGtoI4JW0V+lp9YM/UHZiZXpRWvV ReE/Pr4eeRanQEd8sTSMwjBrcIrplT/wLF28lfNv1eyNYQaFXenrqeNS1kW4MFyd36 +mAuVYtdJ4SQA== Date: Mon, 19 Sep 2022 15:42:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Carlo Nonato , andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for domains In-Reply-To: <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com> Message-ID: References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-7-carlo.nonato@minervasys.tech> <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com> <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 19 Sep 2022, Jan Beulich wrote: > On 16.09.2022 18:05, Carlo Nonato wrote: > > On Thu, Sep 15, 2022 at 3:13 PM Jan Beulich wrote: > >> On 26.08.2022 14:51, Carlo Nonato wrote: > >>> --- a/xen/arch/arm/Kconfig > >>> +++ b/xen/arch/arm/Kconfig > >>> @@ -147,6 +147,18 @@ config MAX_CACHE_COLORS > >>> colors at boot. Note that if, at any time, a color configuration with more > >>> colors than the maximum will be employed an error will be produced. > >>> > >>> +config BUDDY_ALLOCATOR_SIZE > >>> + string "Buddy allocator reserved memory size" if CACHE_COLORING > >>> + default "64M" if CACHE_COLORING > >>> + default "0M" if !CACHE_COLORING > >> > >> I don't understand the purpose of this last line, nor the two earlier > >> "if". Why not simply > >> > >> config BUDDY_ALLOCATOR_SIZE > >> string "Buddy allocator reserved memory size" > >> depend on CACHE_COLORING > >> default "64M" > > > > This was just to have a value for the config option even with cache coloring > > disabled. All those ifs emulate the "depends on" keyword, but let the > > CONFIG_BUDDY_ALLOCATOR_SIZE takes "0M" when coloring is disabled. With just > > the "depends on" the macro isn't defined at all. I know that this can be > > handled with some simple #ifdef, but I found this way to be more elegant. > > Not an expert here so if you prefer the other way or a whole different one > > (more readable/better fitted) please let me know. > > As far as I saw, the sole use was already inside a suitable #ifdef. Hence > yes, I clearly would see "depends on" as the better fit. Please also don't > forget that if later cache coloring would be enabled for another > architecture, that default of zero (pre-recorded in a .config) would get > in the way; one would need to manually change it (and remember to do so). > > >> Finally - how much of this is really Arm-specific? Shouldn't this be a > >> common config option, perhaps merely restricted to Arm by the top level > >> option (CACHE_COLORING?) depending on a further HAS_CACHE_COLORING, > >> which only Arm would select? > > > > I'm sorry, but I don't understand your suggestion. BUDDY_ALLOCATOR_SIZE > > is Arm specific because CACHE_COLORING is. In fact it depends only on this > > last config value and not on Arm config directly. Why should someone limit > > the buddy allocator when coloring isn't enabled? > > My comment wasn't on this on setting alone, but on the coloring ones as a > set. > > > I've lost you on the HAS_CACHE_COLORING. Why should Arm config select this > > one? Cache coloring must remain optional. I'm probably missing something. > > HAS_* settings only express what an arch is capable of; they don't replace > dependent options which actually are user-selectable. (That said, we have > a number where there's no user selection possible, but that's not of > interest here.) > > >>> --- a/xen/arch/arm/coloring.c > >>> +++ b/xen/arch/arm/coloring.c > >>> @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config, > >>> config->num_colors = (uint16_t)num; > >>> } > >>> > >>> +unsigned int page_to_color(struct page_info *pg) > >> > >> The parameter will want to be pointer-to-const and I wonder whether ... > >> > >>> +{ > >>> + return addr_to_color(page_to_maddr(pg)); > >>> +} > >> > >> ... the function as a whole wouldn't be a good candidate for being an > >> inline one (requiring addr_to_color() to be available in outside of > >> this file, of course). > > > > You mean defining it as static inline in the coloring.h header? > > That would seem preferable for a simple function like this one. > > >>> +static void color_heap_insert_page(struct page_info *pg) > >>> +{ > >>> + struct page_info *pos; > >>> + struct page_list_head *head = colored_pages(page_to_color(pg)); > >>> + > >>> + pg->count_info |= PGC_colored; > >> > >> The function isn't marked __init, so runtime correctness as to the > >> (non-atomic) update here wants clarifying. > > > > Yes. I need to check and probably add a spin lock for the color heap. > > I'm afraid a spin lock won't help. May I suggest you look at some of > the staticmem discussions that had happened, including a similar > topic. (Sorry, I don't have a link at hand to the exact mail.) I searched through the recent staticmem discussions to try to provide a helpful link for Carlo, but I don't think I managed to find what you had in mind. I found these two lock-related emails: https://marc.info/?l=xen-devel&m=165476642832402 https://marc.info/?l=xen-devel&m=165632461420257 If they are not relevant, could you please provide a few more details? From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409015.651852 (Exim 4.92) (envelope-from ) id 1oaQ1r-0004MP-Q7; Mon, 19 Sep 2022 23:18:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409015.651852; Mon, 19 Sep 2022 23:18:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ1r-0004MI-NF; Mon, 19 Sep 2022 23:18:19 +0000 Received: by outflank-mailman (input) for mailman id 409015; Mon, 19 Sep 2022 23:18:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ1q-0004MC-Fu for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:18 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57b145ae-3871-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 01:18:17 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id y3so2237647ejc.1 for ; Mon, 19 Sep 2022 16:18:17 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57b145ae-3871-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=/k4I9yFOQcmiC4x/pIxNVj/VFsZVkB/VTnKtzXV6Nqg=; b=HeU8zrtYBI/0x6nYhy30ykBOxV7FJFi9qix+CVX0GQ295jAdVYP99cwpVxn/2LzxCi ZP5HRKIK6CCkoV8ZYaMeoxr7Er2J7tkGFzoZESbBQa3Q/GPx3mVwKz2IoZNjt/UK7KTA +ihVNLs1B8kQsrWVCKS154FLqcTZ7LjxhE5wx61z1x9ykd/cnWa6+EObscXByUSrlnxu 2p8uLD9vwG4GAwVM6hnJqUMiO5KALvwOqjrkAiOSaB7w+Ho12rSGreEd514XIyflj9qP 8m6Uxp0tRrmxmCRjrG0e2Upp6UcGEKsXugZH9piZvYjMOtG1eklpjW88WsouvJFJCC5o ldSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=/k4I9yFOQcmiC4x/pIxNVj/VFsZVkB/VTnKtzXV6Nqg=; b=ryBU0CoayWhSaLUw5WJpGqofPokfVu2Sy5wCtM3gRttTnWrTV9cD3K1tXgz8RK2qPh 3riV3ejTavhgBwPkfJfSRitKnsx+t+cCvawqi/M02zrkJbYd8+l9XQUfFp9AeyY5FWiw j611Cu7r/YraOPCorAE8FPcAwMpMtYNlbjeP9n/KFe51r3vcrEhr31zqM2ZSjnA1NfMb r+MhM6eNrWywwTcJTAFjf8m9ugut6AyR0ahCOhqB2Orpqq5yKyCA+fFauHxcMDmp1zPV CNF1mdkdrRv5ysuldAPkHbWNrZtPKQbe1euhEvwC8/ondlebk6KBofXilUG/3soRd0sE CL3g== X-Gm-Message-State: ACrzQf2AHC6lC8es4aH+9v9d0Fnd/pdqwHzqYXoX+GAqQPt9NYpBKT0r 0ABaujDSbi/C8OcnrA0J2rI= X-Google-Smtp-Source: AMsMyM6qssf98dEArMM6jpNsUS/ykm1rQJXRhzB+Z5C5spX4oNAkXfl0aR9MWbXenJhowWfNIt1+Yg== X-Received: by 2002:a17:907:2c62:b0:77a:e3ce:5ef0 with SMTP id ib2-20020a1709072c6200b0077ae3ce5ef0mr15170276ejc.553.1663629496806; Mon, 19 Sep 2022 16:18:16 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al Date: Tue, 20 Sep 2022 01:17:11 +0200 Message-Id: <20220919231720.163121-1-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In address-spaces.h it can be read that get_system_memory() and=0D get_system_io() are temporary interfaces which "should only be used tempora= rily=0D until a proper bus interface is available". This statement certainly extend= s to=0D the address_space_memory and address_space_io singletons. This series attem= pts=0D to stop further proliferation of their use by turning TYPE_SYSTEM_BUS into = an=0D object-oriented, "proper bus interface" inspired by PCIBus.=0D =0D While at it, also the main_system_bus singleton is turned into an attribute= of=0D MachineState. Together, this resolves five singletons in total, making the= =0D ownership relations much more obvious which helps comprehension.=0D =0D The series is structured as follows: Patch 1 fixes a memory corruption issu= e=0D uncovered by running `make check` on the last but one patch of this series.= =0D Patches 2 and 3 turn the main_system_bus singleton into an attribute of=0D MachineState which provides an alternative to sysbus_get_default(). Patches= 4-7=0D resolve the address space singletons and deprecate the legacy=0D get_system_memory() et. al functions. Patch 8 attempts to optimize the new= =0D implementations of these legacy functions.=0D =0D Testing done:=0D * make check (passes without any issues)=0D * make check-avocado (no new issues seem to be introduced compared to maste= r)=0D =0D Bernhard Beschow (9):=0D hw/riscv/sifive_e: Fix inheritance of SiFiveEState=0D exec/hwaddr.h: Add missing include=0D hw/core/sysbus: Resolve main_system_bus singleton=0D hw/ppc/spapr: Fix code style problems reported by checkpatch=0D exec/address-spaces: Wrap address space singletons into functions=0D target/loongarch/cpu: Remove unneeded include directive=0D hw/sysbus: Introduce dedicated struct SysBusState for TYPE_SYSTEM_BUS=0D softmmu/physmem: Let SysBusState absorb memory region and address=0D space singletons=0D exec/address-spaces: Inline legacy functions=0D =0D accel/hvf/hvf-accel-ops.c | 2 +-=0D accel/kvm/kvm-all.c | 12 +++----=0D hw/alpha/dp264.c | 4 +--=0D hw/alpha/typhoon.c | 4 +--=0D hw/arm/smmu-common.c | 4 +--=0D hw/arm/smmuv3.c | 14 ++++----=0D hw/arm/virt.c | 2 +-=0D hw/char/goldfish_tty.c | 4 +--=0D hw/core/bus.c | 5 ++-=0D hw/core/loader.c | 2 +-=0D hw/core/machine.c | 3 ++=0D hw/core/sysbus.c | 24 ++++----------=0D hw/dma/pl330.c | 2 +-=0D hw/dma/rc4030.c | 2 +-=0D hw/dma/xlnx-zynq-devcfg.c | 4 +--=0D hw/dma/xlnx_dpdma.c | 8 ++---=0D hw/hppa/machine.c | 4 +--=0D hw/hyperv/hyperv.c | 2 +-=0D hw/hyperv/vmbus.c | 2 +-=0D hw/i386/amd_iommu.c | 18 +++++-----=0D hw/i386/fw_cfg.c | 2 +-=0D hw/i386/intel_iommu.c | 24 +++++++-------=0D hw/i386/microvm.c | 4 +--=0D hw/i386/pc.c | 2 +-=0D hw/i386/xen/xen-hvm.c | 4 +--=0D hw/ide/ahci.c | 2 +-=0D hw/ide/macio.c | 10 +++---=0D hw/intc/apic.c | 2 +-=0D hw/intc/openpic_kvm.c | 2 +-=0D hw/intc/pnv_xive.c | 6 ++--=0D hw/intc/pnv_xive2.c | 6 ++--=0D hw/intc/riscv_aplic.c | 2 +-=0D hw/intc/spapr_xive.c | 2 +-=0D hw/intc/xive.c | 4 +--=0D hw/intc/xive2.c | 4 +--=0D hw/mips/jazz.c | 4 +--=0D hw/misc/lasi.c | 2 +-=0D hw/misc/macio/mac_dbdma.c | 8 ++---=0D hw/net/ftgmac100.c | 16 ++++-----=0D hw/net/i82596.c | 24 +++++++-------=0D hw/net/imx_fec.c | 22 ++++++-------=0D hw/net/lasi_i82596.c | 2 +-=0D hw/net/npcm7xx_emc.c | 14 ++++----=0D hw/openrisc/boot.c | 2 +-=0D hw/pci-host/dino.c | 6 ++--=0D hw/pci-host/pnv_phb3.c | 6 ++--=0D hw/pci-host/pnv_phb3_msi.c | 6 ++--=0D hw/pci-host/pnv_phb4.c | 10 +++---=0D hw/pci/pci.c | 2 +-=0D hw/ppc/pnv_psi.c | 2 +-=0D hw/ppc/spapr.c | 4 +--=0D hw/ppc/spapr_events.c | 2 +-=0D hw/ppc/spapr_hcall.c | 4 +--=0D hw/ppc/spapr_iommu.c | 4 +--=0D hw/ppc/spapr_ovec.c | 8 ++---=0D hw/ppc/spapr_rtas.c | 2 +-=0D hw/remote/iommu.c | 2 +-=0D hw/remote/message.c | 4 +--=0D hw/remote/proxy-memory-listener.c | 2 +-=0D hw/riscv/boot.c | 6 ++--=0D hw/riscv/sifive_e.c | 2 +-=0D hw/riscv/sifive_u.c | 2 +-=0D hw/riscv/virt.c | 2 +-=0D hw/s390x/css.c | 16 ++++-----=0D hw/s390x/ipl.h | 2 +-=0D hw/s390x/s390-pci-bus.c | 4 +--=0D hw/s390x/s390-pci-inst.c | 10 +++---=0D hw/s390x/s390-skeys.c | 2 +-=0D hw/s390x/virtio-ccw.c | 10 +++---=0D hw/sd/sdhci.c | 2 +-=0D hw/sh4/r2d.c | 4 +--=0D hw/sparc/sun4m.c | 2 +-=0D hw/sparc/sun4m_iommu.c | 4 +--=0D hw/sparc64/sun4u_iommu.c | 4 +--=0D hw/timer/hpet.c | 2 +-=0D hw/usb/hcd-ehci-pci.c | 2 +-=0D hw/usb/hcd-ehci-sysbus.c | 2 +-=0D hw/usb/hcd-ohci.c | 2 +-=0D hw/usb/hcd-xhci-sysbus.c | 2 +-=0D hw/vfio/ap.c | 2 +-=0D hw/vfio/ccw.c | 2 +-=0D hw/vfio/common.c | 8 ++---=0D hw/vfio/platform.c | 2 +-=0D hw/virtio/vhost-vdpa.c | 2 +-=0D hw/virtio/vhost.c | 2 +-=0D hw/virtio/virtio-bus.c | 4 +--=0D hw/virtio/virtio-iommu.c | 6 ++--=0D hw/virtio/virtio-pci.c | 2 +-=0D hw/xen/xen_pt.c | 4 +--=0D include/exec/address-spaces.h | 49 +++++++++++++++++++++++-----=0D include/exec/hwaddr.h | 1 +=0D include/hw/boards.h | 2 ++=0D include/hw/elf_ops.h | 4 +--=0D include/hw/misc/macio/macio.h | 2 +-=0D include/hw/ppc/spapr.h | 6 ++--=0D include/hw/ppc/vof.h | 4 +--=0D include/hw/riscv/sifive_e.h | 3 +-=0D include/hw/sysbus.h | 14 ++++++--=0D monitor/misc.c | 4 +--=0D softmmu/ioport.c | 12 +++----=0D softmmu/memory_mapping.c | 2 +-=0D softmmu/physmem.c | 41 ++++++++---------------=0D target/arm/hvf/hvf.c | 4 +--=0D target/arm/kvm.c | 4 +--=0D target/avr/helper.c | 8 ++---=0D target/i386/hax/hax-all.c | 2 +-=0D target/i386/hax/hax-mem.c | 2 +-=0D target/i386/hvf/hvf.c | 2 +-=0D target/i386/hvf/vmx.h | 2 +-=0D target/i386/hvf/x86_mmu.c | 6 ++--=0D target/i386/nvmm/nvmm-all.c | 4 +--=0D target/i386/sev.c | 4 +--=0D target/i386/tcg/sysemu/misc_helper.c | 12 +++----=0D target/i386/whpx/whpx-all.c | 4 +--=0D target/loongarch/cpu.h | 1 -=0D target/s390x/diag.c | 2 +-=0D target/s390x/mmu_helper.c | 2 +-=0D target/s390x/sigp.c | 2 +-=0D target/xtensa/dbg_helper.c | 2 +-=0D tests/qtest/fuzz/generic_fuzz.c | 4 +--=0D 120 files changed, 355 insertions(+), 328 deletions(-)=0D =0D -- =0D 2.37.3=0D =0D From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409016.651863 (Exim 4.92) (envelope-from ) id 1oaQ1x-0004cT-2G; Mon, 19 Sep 2022 23:18:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409016.651863; Mon, 19 Sep 2022 23:18:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ1w-0004cM-Ve; Mon, 19 Sep 2022 23:18:24 +0000 Received: by outflank-mailman (input) for mailman id 409016; Mon, 19 Sep 2022 23:18:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ1v-0004MC-Iz for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:23 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5affec36-3871-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 01:18:22 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id z2so1412038edi.1 for ; Mon, 19 Sep 2022 16:18:22 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5affec36-3871-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Fjo518UYX1pucjz3VPXRbua9nNVIHRhAk9ua0pzX1XA=; b=lbugUhiXpcHvVHxmNQCd7XhVHqDDxchx16Djox3J75B7ePDdncyCGse6eZA2NqPqFh hr1ilTebkO5lbr+2+TZ5mEGLS4PtyKRFbfCqqAv12AEVAMkQWO0zrazSj3q2ZqeRKBT/ NbDJbiJXOnw+DznNgyjbvAx0+B4DavYnJ8efSi50qdYGRhMcVApJ9LYs+43cIJnPnFH9 p7WTSOkQVMZ/TBIgKfij+g6XFoQIUWCHughrTftkcd/1hY2CNeeMm/CAqplFQVur0kCT P6Vi6hDAGyycMZR5ghfx4ycMPoY3eP4zAl+AtKcz4IBZGYhSpX7tdpCvm4nrUNQHxaPV fQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Fjo518UYX1pucjz3VPXRbua9nNVIHRhAk9ua0pzX1XA=; b=JZVvydJR8bFgKXJxRTpjmPA+aLxXk02b1DDdGISGpzrDNOYqcLJThpK63OGc9kBALf KfOtv8oux9N3FJsBgKdh21P42gHl3eayJjoYl5dour4jr7Y/WAxUgi+1xEmTPhc8WnmE rUTcAVMv6dXu4AhSGex8uv4N1Iub9RfkS4/JcJAX0rFXzkluYdc2ZmOPlyPl8YQgCC5Q +mCjOn6qiv8Y3i8XR+pb70a+ZDVn29Evis8iiDEyqDO0lonSGAnC1jdtCQG4y0lSPWKB chU1WXngTVHfm3Zj4DpXuGfDKjQlF+ZJVs3k9goFLynhSytBvt/hP9CU1zlIGuAky9DM t3ew== X-Gm-Message-State: ACrzQf0gg9fjqcZEuIUPhoL0b7D3He9uLpkuuQyUFB3n8oeoxD9qss2o IlhsiasTm/eG/i5TN32XnMc= X-Google-Smtp-Source: AMsMyM59+Un1+bbndkQl90bc+w6Ku/wLNzkfWCb5H+mf7flr0JF2IyQRo4Sr55rK2P8tkNt3yzBwMA== X-Received: by 2002:a50:fc9a:0:b0:454:6a56:7d27 with SMTP id f26-20020a50fc9a000000b004546a567d27mr470765edq.73.1663629502405; Mon, 19 Sep 2022 16:18:22 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState Date: Tue, 20 Sep 2022 01:17:12 +0200 Message-Id: <20220919231720.163121-2-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to inherit from TYPE_MACHINE. This is an inconsistency which can cause undefined behavior such as memory corruption. Change SiFiveEState to inherit from MachineState since it is registered as a machine. Signed-off-by: Bernhard Beschow --- include/hw/riscv/sifive_e.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/riscv/sifive_e.h b/include/hw/riscv/sifive_e.h index 83604da805..d738745925 100644 --- a/include/hw/riscv/sifive_e.h +++ b/include/hw/riscv/sifive_e.h @@ -22,6 +22,7 @@ #include "hw/riscv/riscv_hart.h" #include "hw/riscv/sifive_cpu.h" #include "hw/gpio/sifive_gpio.h" +#include "hw/boards.h" #define TYPE_RISCV_E_SOC "riscv.sifive.e.soc" #define RISCV_E_SOC(obj) \ @@ -41,7 +42,7 @@ typedef struct SiFiveESoCState { typedef struct SiFiveEState { /*< private >*/ - SysBusDevice parent_obj; + MachineState parent_obj; /*< public >*/ SiFiveESoCState soc; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409017.651874 (Exim 4.92) (envelope-from ) id 1oaQ24-0004xv-B1; Mon, 19 Sep 2022 23:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409017.651874; Mon, 19 Sep 2022 23:18:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ24-0004xm-7x; Mon, 19 Sep 2022 23:18:32 +0000 Received: by outflank-mailman (input) for mailman id 409017; Mon, 19 Sep 2022 23:18:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ22-0004vz-4n for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:30 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ea1020b-3871-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:18:29 +0200 (CEST) Received: by mail-ed1-x533.google.com with SMTP id m3so1324025eda.12 for ; Mon, 19 Sep 2022 16:18:28 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ea1020b-3871-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=YuQwXC400wn1XG3lPzRkN46CWgPRCmkTZD5KrMqPnvc=; b=OfOTlhHIdUYcoHKPguW/SrroW/2HH31KpnqDNx1VDOdScP9GFw+hcz6wLKt9qwYKmr tUiVUE0COMOBBIwnlZk33ru5T+PAhA69FfCE40NYduQ5A2+ZLn3WJwfMhsySvcTEX8NG kUvI2CGts6p4THnGkq0xeeKDTU5xPudeCwmi2+6sBCLSQZmuxjpnNtMXwBahzmJp9kZR Ylpol3lEYtvuiLAmcekgtLJXtFpD/8AjmspSTSwXdjX14Lafob9CFzE0RecWT58O2Hq9 Vl+Tlro5icVzofsz7kyjKQ+0/Ll3mwbPbZepIT1+f4hmtu3MFNqsfZTqVJBagsK7iMxp 9/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=YuQwXC400wn1XG3lPzRkN46CWgPRCmkTZD5KrMqPnvc=; b=oHE6emLB8xbszUOMZBMgLpLA16eL8iPrP/OxndVlLR5292mfos8tiazfKKR+OGM03l N2IFNvAvVhc4Cq9jHO+ul0Lymq698O0vKcFQyFMxy7+5TpYTTpU5K1UMaZIl2ZNQwUf3 ut7Ncg3HUk2cZ01C0aozZFnew7ZK7TkW5RsjCc9N9sdn6dmSunZJrrt+9hoaOUezYHwN v0xziZ14pWKTMN55+yG792Ql7qH+TDL4+gRIuesCUUkb/GEdlpxiuUvn39+b9fj655pk 64lZxL3YsmMMg9D5f9dIfvHR9RpUJEeI6inl1BYcYfEGGiciQmSEXwBoTtPMMtzrDFuu kkKA== X-Gm-Message-State: ACrzQf3eP0I8zkatJhCIT1X4W/rpcCcmnB4tAk3EeJzD4VP0gGk3i+PG EkFBif2Aj5EkIUx0yaeiY6o= X-Google-Smtp-Source: AMsMyM4dA5dnazvKBz2RVfKC8EJQkafmLFlSOVYf1X2uY4aMLi4DKxlHP7A25Z9KlTvDpLqBqvU2+Q== X-Received: by 2002:a05:6402:1b06:b0:44e:a073:1dd8 with SMTP id by6-20020a0564021b0600b0044ea0731dd8mr16910792edb.391.1663629508436; Mon, 19 Sep 2022 16:18:28 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 2/9] exec/hwaddr.h: Add missing include Date: Tue, 20 Sep 2022 01:17:13 +0200 Message-Id: <20220919231720.163121-3-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The next commit would not compile w/o the include directive. Signed-off-by: Bernhard Beschow --- include/exec/hwaddr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h index 8f16d179a8..616255317c 100644 --- a/include/exec/hwaddr.h +++ b/include/exec/hwaddr.h @@ -3,6 +3,7 @@ #ifndef HWADDR_H #define HWADDR_H +#include "qemu/osdep.h" #define HWADDR_BITS 64 /* hwaddr is the type of a physical address (its size can -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409018.651885 (Exim 4.92) (envelope-from ) id 1oaQ28-0005LY-Q7; Mon, 19 Sep 2022 23:18:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409018.651885; Mon, 19 Sep 2022 23:18:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ28-0005LK-MP; Mon, 19 Sep 2022 23:18:36 +0000 Received: by outflank-mailman (input) for mailman id 409018; Mon, 19 Sep 2022 23:18:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ27-0004vz-P6 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:35 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62212fbb-3871-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:18:35 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id y17so2189841ejo.6 for ; Mon, 19 Sep 2022 16:18:34 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62212fbb-3871-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ScsUFIDAHrm9/OPFECQYAYLcM3exK8eoaXsBNG48BMc=; b=bklrnXC+Q9cSo2FFOWfTXPpVHkz7irXkFbdyd6/BCU2xuyoZleDIoNMU8HijhM8/f/ 12oHjj6bdYlh8ovjo9fbo/AzzIKh/s88xDprTDDu6uVtD36FZCWsn66rd086C8EY+gRS b3PgE5tctP66cgHs7ldVIlsIuNOVQEBmmny+GbC5huXVVzJ4n4/hjoj0ooNBMuoyC7+/ IwvCtApFdCbrV78O3C5mq3mtM7+Rv7m08+xwa8/kKzar8suXKXKnclqYu1UxttLqEop6 3JIuCuLhTHc4skzYus3eB+AmX/fOGOrCA9D1UqE8mKBQsr1TgwZu8W5CRb5gZpTnS7Dn LqUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ScsUFIDAHrm9/OPFECQYAYLcM3exK8eoaXsBNG48BMc=; b=SD+EpRo2IwRLrb91fLjcpIpSLREmrgQv8WSV6zsPiHmrnFJXW6RExsNwS+spciltHQ inEYruF8RKbIdstWDdLIiCUnKYl59b0qwNbvuyUsFsA3iVRKLc+4NxRntKEwN4pL1t8w 9vEtgN88vMuCdK+wuS9cLKpYo02zmKCF0TxNAgMOPvL1d5+yt0P56d2iGP+SjfFkbIIG srBVDYjo0rcqdEoD/hsb0T8hgK8m+C+8yqaUc5X0GSWkqJDCTYiuih3BtFiltTRkLzBD c+1X/W3hNo/IomwvekZaXAncqus2ZSHlqBgaWhgZ7tbGjeXiQPp7VB02VbMlSuM/H3rj 6plA== X-Gm-Message-State: ACrzQf3Qn4lmojsr4aQvXIvrVNaLF/CPjqCHS3VHivRYwghH6Z7upxqj FFRJNL4ZneHe/jjR/GlqDsw= X-Google-Smtp-Source: AMsMyM5zOFXr+h5fB5zVLEWuIudF3jkOWN1HVQ7NnRGDLPPjOGxYXkHu7b5fRJV74nWfwRAhpeBFrQ== X-Received: by 2002:a17:907:7207:b0:77b:3647:c24 with SMTP id dr7-20020a170907720700b0077b36470c24mr14030221ejc.417.1663629514343; Mon, 19 Sep 2022 16:18:34 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 3/9] hw/core/sysbus: Resolve main_system_bus singleton Date: Tue, 20 Sep 2022 01:17:14 +0200 Message-Id: <20220919231720.163121-4-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In QEMU, a machine and the main_system_bus always go togehter. Usually the bus is part of the machine which suggsts to host it there. Since tere is already a current_machine singleton, all code that accesses the main_system_bus can be changed (behind the scenes) to go through current_machine. This resolves a singleton. Futhermore, by reifying it in code, the every-machine-has-exactly-one-main-system-bus relationship becomes very obvious. Note that the main_system_bus attribute is a value rather than a pointer. This trades pointer dereferences for pointer arithmetic. The idea is to reduce cache misses - a rule of thumb says that every pointer dereference causes a cache miss while arithmetic is basically free. Signed-off-by: Bernhard Beschow --- hw/core/bus.c | 5 ++++- hw/core/machine.c | 3 +++ hw/core/sysbus.c | 22 +++++----------------- include/hw/boards.h | 1 + 4 files changed, 13 insertions(+), 18 deletions(-) diff --git a/hw/core/bus.c b/hw/core/bus.c index c7831b5293..e3e807946c 100644 --- a/hw/core/bus.c +++ b/hw/core/bus.c @@ -129,9 +129,12 @@ static void qbus_init_internal(BusState *bus, DeviceState *parent, bus->parent->num_child_bus++; object_property_add_child(OBJECT(bus->parent), bus->name, OBJECT(bus)); object_unref(OBJECT(bus)); + + /* The only bus without a parent is the main system bus */ + assert(sysbus_get_default()); } else { /* The only bus without a parent is the main system bus */ - assert(bus == sysbus_get_default()); + assert(!sysbus_get_default()); } } diff --git a/hw/core/machine.c b/hw/core/machine.c index aa520e74a8..ebd3e0ff08 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1097,6 +1097,9 @@ static void machine_initfn(Object *obj) ms->smp.threads = 1; machine_copy_boot_config(ms, &(BootConfiguration){ 0 }); + + qbus_init(&ms->main_system_bus, sizeof(ms->main_system_bus), + TYPE_SYSTEM_BUS, NULL, "main-system-bus"); } static void machine_finalize(Object *obj) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 05c1da3d31..16a9b4d7a0 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/module.h" +#include "hw/boards.h" #include "hw/sysbus.h" #include "monitor/monitor.h" #include "exec/address-spaces.h" @@ -336,26 +337,13 @@ static const TypeInfo sysbus_device_type_info = { .class_init = sysbus_device_class_init, }; -static BusState *main_system_bus; - -static void main_system_bus_create(void) -{ - /* - * assign main_system_bus before qbus_init() - * in order to make "if (bus != sysbus_get_default())" work - */ - main_system_bus = g_malloc0(system_bus_info.instance_size); - qbus_init(main_system_bus, system_bus_info.instance_size, - TYPE_SYSTEM_BUS, NULL, "main-system-bus"); - OBJECT(main_system_bus)->free = g_free; -} - BusState *sysbus_get_default(void) { - if (!main_system_bus) { - main_system_bus_create(); + if (!current_machine) { + return NULL; } - return main_system_bus; + + return ¤t_machine->main_system_bus; } static void sysbus_register_types(void) diff --git a/include/hw/boards.h b/include/hw/boards.h index 311ed17e18..7af940102d 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -346,6 +346,7 @@ struct MachineState { */ MemoryRegion *ram; DeviceMemoryState *device_memory; + BusState main_system_bus; ram_addr_t ram_size; ram_addr_t maxram_size; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409022.651896 (Exim 4.92) (envelope-from ) id 1oaQ2F-0005qf-3F; Mon, 19 Sep 2022 23:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409022.651896; Mon, 19 Sep 2022 23:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2F-0005qQ-0N; Mon, 19 Sep 2022 23:18:43 +0000 Received: by outflank-mailman (input) for mailman id 409022; Mon, 19 Sep 2022 23:18:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2D-0004MC-7c for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:41 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6580164a-3871-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 01:18:40 +0200 (CEST) Received: by mail-ed1-x52f.google.com with SMTP id z13so1318179edb.13 for ; Mon, 19 Sep 2022 16:18:40 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6580164a-3871-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=08Zu8gSbNoVwH6SgINHBVlRGcpHDOzJ+Q2vxMgjaChc=; b=LfVaavpRhFpUWtJPmOxeHcORJMDqIlM8LXxn6uYegGeyIw7Hse/ODmgBL9aKBhrBR+ QDDcqQqAdIZTX3WL1AetyE3jL8Z7UfxdRlbeYmgC3KxoQ1JGUO5P/z0aHKwwmXDVbECj AuFfIQm7sMB0W8Fn1uWO/41uzUy2iQROSJACK1zFtCB5Ab5h3m+zMu7WKhoWQK1NOfC6 FGmzCigSE7vWW/M9qBClZbQwtO4eC/7gkX0vt5SaBL49Jx2Ea8iuUqxrqNunzGJXm1oE JWUZFC3ZmBZazxQinxj2ElsyYVRjc4rohZ/gwlRQDOLEWPgCW/Y5CMxXPPgmtldeeeIg RE6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=08Zu8gSbNoVwH6SgINHBVlRGcpHDOzJ+Q2vxMgjaChc=; b=ne3b8uXK7cG3w9DqD8bw14bQMv6ywk/eJmiWR78no8E7QrdNUwFyVQFxB0UnDztQaO 3g9+fczmgrAbrSsYrgtsdo4I3PEyGkaXNWz/YzN5xv3YQn4r2IzUgG4K8dkjEK0RhnGB s5yNeFbHmEq8Sp+ex679yInzMdeMuYdTY0ci0JQk/tPOPIn5RmWZMNkSKkFxKeK/k31q DDe+81mFpLVN9jFhxpYhFMlq3g3suYJ7/a7zKP8ED2k4yf83JeQdG8+X1YvV+t683wJ0 3nJVCt3PGm4VTAXPxkjfxUIIo8hrzWwtU2OVOeFIpnLKrk8r9TnWvZjpYKwJKSy8PIeb rxmw== X-Gm-Message-State: ACrzQf3ipP9RzL0TbyYsT/Ifqz6vgq+ocXcR39bkSdLVqychBMRvMVRj MzsfFtDu5+BG0MgBGwdWJgU= X-Google-Smtp-Source: AMsMyM6+ebOfksS7/dKAeoPOeQiFYFMU9VBsL7Wg1bKooGg4PafvZv5MknBjnq/lOyGHV8ZLR+girw== X-Received: by 2002:a05:6402:50ca:b0:451:a711:1389 with SMTP id h10-20020a05640250ca00b00451a7111389mr17116111edb.239.1663629520004; Mon, 19 Sep 2022 16:18:40 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 4/9] hw/ppc/spapr: Fix code style problems reported by checkpatch Date: Tue, 20 Sep 2022 01:17:15 +0200 Message-Id: <20220919231720.163121-5-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Bernhard Beschow --- include/hw/ppc/spapr.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index 530d739b1d..04a95669ab 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -848,7 +848,8 @@ static inline uint64_t ppc64_phys_to_real(uint64_t addr) static inline uint32_t rtas_ld(target_ulong phys, int n) { - return ldl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n)); + return ldl_be_phys(&address_space_memory, + ppc64_phys_to_real(phys + 4 * n)); } static inline uint64_t rtas_ldq(target_ulong phys, int n) @@ -858,7 +859,7 @@ static inline uint64_t rtas_ldq(target_ulong phys, int n) static inline void rtas_st(target_ulong phys, int n, uint32_t val) { - stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n), val); + stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), val); } typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, SpaprMachineState *sm, -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409027.651907 (Exim 4.92) (envelope-from ) id 1oaQ2O-0006ap-EH; Mon, 19 Sep 2022 23:18:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409027.651907; Mon, 19 Sep 2022 23:18:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2O-0006ai-A8; Mon, 19 Sep 2022 23:18:52 +0000 Received: by outflank-mailman (input) for mailman id 409027; Mon, 19 Sep 2022 23:18:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2M-0004MC-Ef for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:51 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69b98dd0-3871-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 01:18:47 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id sb3so2145415ejb.9 for ; Mon, 19 Sep 2022 16:18:47 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69b98dd0-3871-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=HNjIuvBWBMHHLOqn5zrB7u7ljJXJuukzmTCa/ZFYEn8=; b=V71bgNCssvCAB/XbTauczuwnSjaL+/G4TKNv4iDWFIWJPxr7O9/AhfLHvxzLh9Mqkt fvSKUN53lb7jgdhb7HSWfVOKS/lFRNfHffwpej6A5d2iVNs+xZODYJf/RqrTpW+ZZJ9a EysGMSfZ/me806xSpju4zQf5DwceuvSsmwmeP83POftTvt/QuFzc2MizSBb4Sc2mhDgo C58kEU04vVLXx54hWUB2nFHKNLfnvAxPjK/2rguIYnGUYMhyRPuxlIe4hXDK7SDrzBel MyY87hnOjuTcamNCavVtRDgYBRJE51+ngd0TxJZ9vnNukwrhSgg4egOEEC8rDlSDNaw9 Ua1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=HNjIuvBWBMHHLOqn5zrB7u7ljJXJuukzmTCa/ZFYEn8=; b=QaKW0ll94UFLc9RRMcH4akaRm0XcdKsZNsoNtvg6xusGfubDAcI9jqSLE/sC4JS/en zclxXatGO7CF+sBsfJeZb+hbptRQqosBa/r+JKj1cUQ8IJ4XAASX0WqEBXHIRlEsRHFW z/SJCrof1wqo8GU8gS62yLTn60nHabJiAyirDhE0sZi3ShXcqFcm5UYfQ6U7x9NYgyGV GuxxjzR360a9Oz7P9opdbGpc3SfLHXqqRW8LGtWg2Qtmk9Mas7/MltAp+3tfaD32XzcJ eG/ftFr4gOINfwu3PZrX27XI8b231KDZ01jaMIdg802eB/b0JnUD2VQM8d+Nwiflec4X /p5g== X-Gm-Message-State: ACrzQf00WqsyBcRWtcT1KoF0sp/EYV+CIVfWhHXhadMNZb4Sw32qTn6K 5HCop3yt44V2xPxUEPnkg/I= X-Google-Smtp-Source: AMsMyM7Wl4N4mGmDplitIMmO6Bj41ZDnFTXlF4w0czobjbTaz9kyJms96EaCzn9CqANbD0Vtcz5G2A== X-Received: by 2002:a17:907:97d3:b0:780:5b1c:b45e with SMTP id js19-20020a17090797d300b007805b1cb45emr14558699ejc.251.1663629526555; Mon, 19 Sep 2022 16:18:46 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 5/9] exec/address-spaces: Wrap address space singletons into functions Date: Tue, 20 Sep 2022 01:17:16 +0200 Message-Id: <20220919231720.163121-6-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the next steps, these singletons will be resolved by turning them into attributes of the system bus. The system bus is already accessible via the global current_machine variable which will be made use of later in the wrapper functions. All changes have been performed with search-and-replace: * s/&address_space_memory/get_address_space_memory()/ * s/&address_space_io/get_address_space_io()/ The only exceptions were exec/address-spaces.h and softmmu/physmem.c which have been manually changed. Signed-off-by: Bernhard Beschow --- accel/hvf/hvf-accel-ops.c | 2 +- accel/kvm/kvm-all.c | 12 ++++++------ hw/alpha/dp264.c | 4 ++-- hw/alpha/typhoon.c | 4 ++-- hw/arm/smmu-common.c | 4 ++-- hw/arm/smmuv3.c | 14 +++++++------- hw/arm/virt.c | 2 +- hw/char/goldfish_tty.c | 4 ++-- hw/core/loader.c | 2 +- hw/dma/pl330.c | 2 +- hw/dma/rc4030.c | 2 +- hw/dma/xlnx-zynq-devcfg.c | 4 ++-- hw/dma/xlnx_dpdma.c | 8 ++++---- hw/hppa/machine.c | 4 ++-- hw/hyperv/hyperv.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/i386/amd_iommu.c | 18 +++++++++--------- hw/i386/fw_cfg.c | 2 +- hw/i386/intel_iommu.c | 24 ++++++++++++------------ hw/i386/microvm.c | 4 ++-- hw/i386/pc.c | 2 +- hw/i386/xen/xen-hvm.c | 4 ++-- hw/ide/ahci.c | 2 +- hw/ide/macio.c | 10 +++++----- hw/intc/apic.c | 2 +- hw/intc/openpic_kvm.c | 2 +- hw/intc/pnv_xive.c | 6 +++--- hw/intc/pnv_xive2.c | 6 +++--- hw/intc/riscv_aplic.c | 2 +- hw/intc/spapr_xive.c | 2 +- hw/intc/xive.c | 4 ++-- hw/intc/xive2.c | 4 ++-- hw/mips/jazz.c | 4 ++-- hw/misc/lasi.c | 2 +- hw/misc/macio/mac_dbdma.c | 8 ++++---- hw/net/ftgmac100.c | 16 ++++++++-------- hw/net/i82596.c | 24 ++++++++++++------------ hw/net/imx_fec.c | 22 +++++++++++----------- hw/net/lasi_i82596.c | 2 +- hw/net/npcm7xx_emc.c | 14 +++++++------- hw/openrisc/boot.c | 2 +- hw/pci-host/dino.c | 6 +++--- hw/pci-host/pnv_phb3.c | 6 +++--- hw/pci-host/pnv_phb3_msi.c | 6 +++--- hw/pci-host/pnv_phb4.c | 10 +++++----- hw/pci/pci.c | 2 +- hw/ppc/pnv_psi.c | 2 +- hw/ppc/spapr.c | 4 ++-- hw/ppc/spapr_events.c | 2 +- hw/ppc/spapr_hcall.c | 4 ++-- hw/ppc/spapr_iommu.c | 4 ++-- hw/ppc/spapr_ovec.c | 8 ++++---- hw/ppc/spapr_rtas.c | 2 +- hw/remote/iommu.c | 2 +- hw/remote/message.c | 4 ++-- hw/remote/proxy-memory-listener.c | 2 +- hw/riscv/boot.c | 6 +++--- hw/riscv/sifive_e.c | 2 +- hw/riscv/sifive_u.c | 2 +- hw/riscv/virt.c | 2 +- hw/s390x/css.c | 16 ++++++++-------- hw/s390x/ipl.h | 2 +- hw/s390x/s390-pci-bus.c | 4 ++-- hw/s390x/s390-pci-inst.c | 10 +++++----- hw/s390x/s390-skeys.c | 2 +- hw/s390x/virtio-ccw.c | 10 +++++----- hw/sd/sdhci.c | 2 +- hw/sh4/r2d.c | 4 ++-- hw/sparc/sun4m.c | 2 +- hw/sparc/sun4m_iommu.c | 4 ++-- hw/sparc64/sun4u_iommu.c | 4 ++-- hw/timer/hpet.c | 2 +- hw/usb/hcd-ehci-pci.c | 2 +- hw/usb/hcd-ehci-sysbus.c | 2 +- hw/usb/hcd-ohci.c | 2 +- hw/usb/hcd-xhci-sysbus.c | 2 +- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- hw/vfio/common.c | 8 ++++---- hw/vfio/platform.c | 2 +- hw/virtio/vhost-vdpa.c | 2 +- hw/virtio/vhost.c | 2 +- hw/virtio/virtio-bus.c | 4 ++-- hw/virtio/virtio-iommu.c | 6 +++--- hw/virtio/virtio-pci.c | 2 +- hw/xen/xen_pt.c | 4 ++-- include/exec/address-spaces.h | 4 ++-- include/hw/elf_ops.h | 4 ++-- include/hw/ppc/spapr.h | 5 +++-- include/hw/ppc/vof.h | 4 ++-- monitor/misc.c | 4 ++-- softmmu/ioport.c | 12 ++++++------ softmmu/memory_mapping.c | 2 +- softmmu/physmem.c | 17 ++++++++++++++--- target/arm/hvf/hvf.c | 4 ++-- target/arm/kvm.c | 4 ++-- target/avr/helper.c | 8 ++++---- target/i386/hax/hax-all.c | 2 +- target/i386/hax/hax-mem.c | 2 +- target/i386/hvf/hvf.c | 2 +- target/i386/hvf/vmx.h | 2 +- target/i386/hvf/x86_mmu.c | 6 +++--- target/i386/nvmm/nvmm-all.c | 4 ++-- target/i386/sev.c | 4 ++-- target/i386/tcg/sysemu/misc_helper.c | 12 ++++++------ target/i386/whpx/whpx-all.c | 4 ++-- target/s390x/diag.c | 2 +- target/s390x/mmu_helper.c | 2 +- target/s390x/sigp.c | 2 +- target/xtensa/dbg_helper.c | 2 +- tests/qtest/fuzz/generic_fuzz.c | 4 ++-- 111 files changed, 285 insertions(+), 273 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 24913ca9c4..62317ee005 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -335,7 +335,7 @@ static int hvf_accel_init(MachineState *ms) } hvf_state = s; - memory_listener_register(&hvf_memory_listener, &address_space_memory); + memory_listener_register(&hvf_memory_listener, get_address_space_memory()); return hvf_arch_init(); } diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 136c8eaed3..413b5a7fa9 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2639,13 +2639,13 @@ static int kvm_init(MachineState *ms) s->memory_listener.listener.coalesced_io_del = kvm_uncoalesce_mmio_region; kvm_memory_listener_register(s, &s->memory_listener, - &address_space_memory, 0, "kvm-memory"); + get_address_space_memory(), 0, "kvm-memory"); if (kvm_eventfds_allowed) { memory_listener_register(&kvm_io_listener, - &address_space_io); + get_address_space_io()); } memory_listener_register(&kvm_coalesced_pio_listener, - &address_space_io); + get_address_space_io()); s->many_ioeventfds = kvm_check_many_ioeventfds(); @@ -2694,7 +2694,7 @@ static void kvm_handle_io(uint16_t port, MemTxAttrs attrs, void *data, int direc uint8_t *ptr = data; for (i = 0; i < count; i++) { - address_space_rw(&address_space_io, port, attrs, + address_space_rw(get_address_space_io(), port, attrs, ptr, size, direction == KVM_EXIT_IO_OUT); ptr += size; @@ -2745,7 +2745,7 @@ void kvm_flush_coalesced_mmio_buffer(void) ent = &ring->coalesced_mmio[ring->first]; if (ent->pio == 1) { - address_space_write(&address_space_io, ent->phys_addr, + address_space_write(get_address_space_io(), ent->phys_addr, MEMTXATTRS_UNSPECIFIED, ent->data, ent->len); } else { @@ -2955,7 +2955,7 @@ int kvm_cpu_exec(CPUState *cpu) case KVM_EXIT_MMIO: DPRINTF("handle_mmio\n"); /* Called outside BQL */ - address_space_rw(&address_space_memory, + address_space_rw(get_address_space_memory(), run->mmio.phys_addr, attrs, run->mmio.data, run->mmio.len, diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index f4349eba83..d55a807650 100644 --- a/hw/alpha/dp264.c +++ b/hw/alpha/dp264.c @@ -197,11 +197,11 @@ static void clipper_init(MachineState *machine) load_image_targphys(initrd_filename, initrd_base, ram_size - initrd_base); - address_space_stq(&address_space_memory, param_offset + 0x100, + address_space_stq(get_address_space_memory(), param_offset + 0x100, initrd_base + 0xfffffc0000000000ULL, MEMTXATTRS_UNSPECIFIED, NULL); - address_space_stq(&address_space_memory, param_offset + 0x108, + address_space_stq(get_address_space_memory(), param_offset + 0x108, initrd_size, MEMTXATTRS_UNSPECIFIED, NULL); } } diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index bd39c8ca86..45bd943f61 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -609,7 +609,7 @@ static const MemoryRegionOps pchip_ops = { static bool make_iommu_tlbe(hwaddr taddr, hwaddr mask, IOMMUTLBEntry *ret) { *ret = (IOMMUTLBEntry) { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .translated_addr = taddr, .addr_mask = mask, .perm = IOMMU_RW, @@ -621,7 +621,7 @@ static bool make_iommu_tlbe(hwaddr taddr, hwaddr mask, IOMMUTLBEntry *ret) translation, given the address of the PTE. */ static bool pte_translate(hwaddr pte_addr, IOMMUTLBEntry *ret) { - uint64_t pte = address_space_ldq(&address_space_memory, pte_addr, + uint64_t pte = address_space_ldq(get_address_space_memory(), pte_addr, MEMTXATTRS_UNSPECIFIED, NULL); /* Check valid bit. */ diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c index e09b9c13b7..22207399a4 100644 --- a/hw/arm/smmu-common.c +++ b/hw/arm/smmu-common.c @@ -193,7 +193,7 @@ static int get_pte(dma_addr_t baseaddr, uint32_t index, uint64_t *pte, dma_addr_t addr = baseaddr + index * sizeof(*pte); /* TODO: guarantee 64-bit single-copy atomicity */ - ret = dma_memory_read(&address_space_memory, addr, pte, sizeof(*pte), + ret = dma_memory_read(get_address_space_memory(), addr, pte, sizeof(*pte), MEMTXATTRS_UNSPECIFIED); if (ret != MEMTX_OK) { @@ -474,7 +474,7 @@ static void smmu_unmap_notifier_range(IOMMUNotifier *n) IOMMUTLBEvent event; event.type = IOMMU_NOTIFIER_UNMAP; - event.entry.target_as = &address_space_memory; + event.entry.target_as = get_address_space_memory(); event.entry.iova = n->start; event.entry.perm = IOMMU_NONE; event.entry.addr_mask = n->end - n->start; diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index daa80e9c7b..3728aefef2 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -102,7 +102,7 @@ static inline MemTxResult queue_read(SMMUQueue *q, void *data) { dma_addr_t addr = Q_CONS_ENTRY(q); - return dma_memory_read(&address_space_memory, addr, data, q->entry_size, + return dma_memory_read(get_address_space_memory(), addr, data, q->entry_size, MEMTXATTRS_UNSPECIFIED); } @@ -111,7 +111,7 @@ static MemTxResult queue_write(SMMUQueue *q, void *data) dma_addr_t addr = Q_PROD_ENTRY(q); MemTxResult ret; - ret = dma_memory_write(&address_space_memory, addr, data, q->entry_size, + ret = dma_memory_write(get_address_space_memory(), addr, data, q->entry_size, MEMTXATTRS_UNSPECIFIED); if (ret != MEMTX_OK) { return ret; @@ -294,7 +294,7 @@ static int smmu_get_ste(SMMUv3State *s, dma_addr_t addr, STE *buf, trace_smmuv3_get_ste(addr); /* TODO: guarantee 64-bit single-copy atomicity */ - ret = dma_memory_read(&address_space_memory, addr, buf, sizeof(*buf), + ret = dma_memory_read(get_address_space_memory(), addr, buf, sizeof(*buf), MEMTXATTRS_UNSPECIFIED); if (ret != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, @@ -316,7 +316,7 @@ static int smmu_get_cd(SMMUv3State *s, STE *ste, uint32_t ssid, trace_smmuv3_get_cd(addr); /* TODO: guarantee 64-bit single-copy atomicity */ - ret = dma_memory_read(&address_space_memory, addr, buf, sizeof(*buf), + ret = dma_memory_read(get_address_space_memory(), addr, buf, sizeof(*buf), MEMTXATTRS_UNSPECIFIED); if (ret != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, @@ -421,7 +421,7 @@ static int smmu_find_ste(SMMUv3State *s, uint32_t sid, STE *ste, l2_ste_offset = sid & ((1 << s->sid_split) - 1); l1ptr = (dma_addr_t)(strtab_base + l1_ste_offset * sizeof(l1std)); /* TODO: guarantee 64-bit single-copy atomicity */ - ret = dma_memory_read(&address_space_memory, l1ptr, &l1std, + ret = dma_memory_read(get_address_space_memory(), l1ptr, &l1std, sizeof(l1std), MEMTXATTRS_UNSPECIFIED); if (ret != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, @@ -649,7 +649,7 @@ static IOMMUTLBEntry smmuv3_translate(IOMMUMemoryRegion *mr, hwaddr addr, SMMUTransTableInfo *tt; SMMUTransCfg *cfg = NULL; IOMMUTLBEntry entry = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr, .translated_addr = addr, .addr_mask = ~(hwaddr)0, @@ -839,7 +839,7 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr, } event.type = IOMMU_NOTIFIER_UNMAP; - event.entry.target_as = &address_space_memory; + event.entry.target_as = get_address_space_memory(); event.entry.iova = iova; event.entry.addr_mask = num_pages * (1 << granule) - 1; event.entry.perm = IOMMU_NONE; diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 0961e053e5..350071f9a6 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2259,7 +2259,7 @@ static void machvirt_init(MachineState *machine) */ create_virtio_devices(vms); - vms->fw_cfg = create_fw_cfg(vms, &address_space_memory); + vms->fw_cfg = create_fw_cfg(vms, get_address_space_memory()); rom_set_fw(vms->fw_cfg); create_platform_bus(vms); diff --git a/hw/char/goldfish_tty.c b/hw/char/goldfish_tty.c index 20b77885c1..649ec344c9 100644 --- a/hw/char/goldfish_tty.c +++ b/hw/char/goldfish_tty.c @@ -97,7 +97,7 @@ static void goldfish_tty_cmd(GoldfishTTYState *s, uint32_t cmd) while (len) { to_copy = MIN(GOLFISH_TTY_BUFFER_SIZE, len); - address_space_rw(&address_space_memory, ptr, + address_space_rw(get_address_space_memory(), ptr, MEMTXATTRS_UNSPECIFIED, data_out, to_copy, 0); qemu_chr_fe_write_all(&s->chr, data_out, to_copy); @@ -110,7 +110,7 @@ static void goldfish_tty_cmd(GoldfishTTYState *s, uint32_t cmd) ptr = s->data_ptr; while (len && !fifo8_is_empty(&s->rx_fifo)) { buf = (uint8_t *)fifo8_pop_buf(&s->rx_fifo, len, &to_copy); - address_space_rw(&address_space_memory, ptr, + address_space_rw(get_address_space_memory(), ptr, MEMTXATTRS_UNSPECIFIED, buf, to_copy, 1); len -= to_copy; diff --git a/hw/core/loader.c b/hw/core/loader.c index 0548830733..7713180a6f 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -930,7 +930,7 @@ static void rom_insert(Rom *rom) /* The user didn't specify an address space, this is the default */ if (!rom->as) { - rom->as = &address_space_memory; + rom->as = get_address_space_memory(); } rom->committed = false; diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c index 08e5938ec7..42c5812410 100644 --- a/hw/dma/pl330.c +++ b/hw/dma/pl330.c @@ -1573,7 +1573,7 @@ static void pl330_realize(DeviceState *dev, Error **errp) return; } else if (s->mem_mr == get_system_memory()) { /* Avoid creating new AS for system memory. */ - s->mem_as = &address_space_memory; + s->mem_as = get_address_space_memory(); } else { s->mem_as = g_new0(AddressSpace, 1); address_space_init(s->mem_as, s->mem_mr, diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c index aa1d323a36..794cff786e 100644 --- a/hw/dma/rc4030.c +++ b/hw/dma/rc4030.c @@ -501,7 +501,7 @@ static IOMMUTLBEntry rc4030_dma_translate(IOMMUMemoryRegion *iommu, hwaddr addr, { rc4030State *s = container_of(iommu, rc4030State, dma_mr); IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr & ~(DMA_PAGESIZE - 1), .translated_addr = 0, .addr_mask = DMA_PAGESIZE - 1, diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index f5ad1a0d22..1132b55124 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -161,13 +161,13 @@ static void xlnx_zynq_devcfg_dma_go(XlnxZynqDevcfg *s) btt = MIN(btt, dmah->dest_len); } DB_PRINT("reading %x bytes from %x\n", btt, dmah->src_addr); - dma_memory_read(&address_space_memory, dmah->src_addr, buf, btt, + dma_memory_read(get_address_space_memory(), dmah->src_addr, buf, btt, MEMTXATTRS_UNSPECIFIED); dmah->src_len -= btt; dmah->src_addr += btt; if (loopback && (dmah->src_len || dmah->dest_len)) { DB_PRINT("writing %x bytes from %x\n", btt, dmah->dest_addr); - dma_memory_write(&address_space_memory, dmah->dest_addr, buf, btt, + dma_memory_write(get_address_space_memory(), dmah->dest_addr, buf, btt, MEMTXATTRS_UNSPECIFIED); dmah->dest_len -= btt; dmah->dest_addr += btt; diff --git a/hw/dma/xlnx_dpdma.c b/hw/dma/xlnx_dpdma.c index dd66be5265..1f6d28cfd6 100644 --- a/hw/dma/xlnx_dpdma.c +++ b/hw/dma/xlnx_dpdma.c @@ -651,7 +651,7 @@ size_t xlnx_dpdma_start_operation(XlnxDPDMAState *s, uint8_t channel, desc_addr = xlnx_dpdma_descriptor_next_address(s, channel); } - if (dma_memory_read(&address_space_memory, desc_addr, &desc, + if (dma_memory_read(get_address_space_memory(), desc_addr, &desc, sizeof(DPDMADescriptor), MEMTXATTRS_UNSPECIFIED)) { s->registers[DPDMA_EISR] |= ((1 << 1) << channel); xlnx_dpdma_update_irq(s); @@ -705,7 +705,7 @@ size_t xlnx_dpdma_start_operation(XlnxDPDMAState *s, uint8_t channel, if (xlnx_dpdma_desc_is_contiguous(&desc)) { source_addr[0] = xlnx_dpdma_desc_get_source_address(&desc, 0); while (transfer_len != 0) { - if (dma_memory_read(&address_space_memory, + if (dma_memory_read(get_address_space_memory(), source_addr[0], &s->data[channel][ptr], line_size, @@ -734,7 +734,7 @@ size_t xlnx_dpdma_start_operation(XlnxDPDMAState *s, uint8_t channel, size_t fragment_len = DPDMA_FRAG_MAX_SZ - (source_addr[frag] % DPDMA_FRAG_MAX_SZ); - if (dma_memory_read(&address_space_memory, + if (dma_memory_read(get_address_space_memory(), source_addr[frag], &(s->data[channel][ptr]), fragment_len, @@ -755,7 +755,7 @@ size_t xlnx_dpdma_start_operation(XlnxDPDMAState *s, uint8_t channel, /* The descriptor need to be updated when it's completed. */ DPRINTF("update the descriptor with the done flag set.\n"); xlnx_dpdma_desc_set_done(&desc); - dma_memory_write(&address_space_memory, desc_addr, &desc, + dma_memory_write(get_address_space_memory(), desc_addr, &desc, sizeof(DPDMADescriptor), MEMTXATTRS_UNSPECIFIED); } diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index e53d5f0fa7..2f46704318 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -44,7 +44,7 @@ static void hppa_powerdown_req(Notifier *n, void *opaque) hwaddr soft_power_reg = HPA_POWER_BUTTON; uint32_t val; - val = ldl_be_phys(&address_space_memory, soft_power_reg); + val = ldl_be_phys(get_address_space_memory(), soft_power_reg); if ((val >> 8) == 0) { /* immediately shut down when under hardware control */ qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); @@ -53,7 +53,7 @@ static void hppa_powerdown_req(Notifier *n, void *opaque) /* clear bit 31 to indicate that the power switch was pressed. */ val &= ~1; - stl_be_phys(&address_space_memory, soft_power_reg, val); + stl_be_phys(get_address_space_memory(), soft_power_reg, val); } static Notifier hppa_system_powerdown_notifier = { diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 4a1b59cb9d..4f462d6b45 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -679,7 +679,7 @@ uint16_t hyperv_hcall_signal_event(uint64_t param, bool fast) return HV_STATUS_INVALID_ALIGNMENT; } - param = ldq_phys(&address_space_memory, addr); + param = ldq_phys(get_address_space_memory(), addr); } /* diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 30bc04e1c4..de58644db4 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -2298,7 +2298,7 @@ static void vmbus_dev_realize(DeviceState *dev, Error **errp) } } - vdev->dma_as = &address_space_memory; + vdev->dma_as = get_address_space_memory(); create_channels(vmbus, vdev, &err); if (err) { diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 725f69095b..4a87fb5745 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -159,7 +159,7 @@ static void amdvi_generate_msi_interrupt(AMDVIState *s) if (msi_enabled(&s->pci.dev)) { msg = msi_get_message(&s->pci.dev, 0); - address_space_stl_le(&address_space_memory, msg.address, msg.data, + address_space_stl_le(get_address_space_memory(), msg.address, msg.data, attrs, NULL); } } @@ -180,7 +180,7 @@ static void amdvi_log_event(AMDVIState *s, uint64_t *evt) return; } - if (dma_memory_write(&address_space_memory, s->evtlog + s->evtlog_tail, + if (dma_memory_write(get_address_space_memory(), s->evtlog + s->evtlog_tail, evt, AMDVI_EVENT_LEN, MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_evntlog_fail(s->evtlog, s->evtlog_tail); } @@ -379,7 +379,7 @@ static void amdvi_completion_wait(AMDVIState *s, uint64_t *cmd) s->cmdbuf + s->cmdbuf_head); } if (extract64(cmd[0], 0, 1)) { - if (dma_memory_write(&address_space_memory, addr, &data, + if (dma_memory_write(get_address_space_memory(), addr, &data, AMDVI_COMPLETION_DATA_SIZE, MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_completion_wait_fail(addr); @@ -506,7 +506,7 @@ static void amdvi_cmdbuf_exec(AMDVIState *s) { uint64_t cmd[2]; - if (dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, + if (dma_memory_read(get_address_space_memory(), s->cmdbuf + s->cmdbuf_head, cmd, AMDVI_COMMAND_SIZE, MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_command_read_fail(s->cmdbuf, s->cmdbuf_head); amdvi_log_command_error(s, s->cmdbuf + s->cmdbuf_head); @@ -840,7 +840,7 @@ static bool amdvi_get_dte(AMDVIState *s, int devid, uint64_t *entry) { uint32_t offset = devid * AMDVI_DEVTAB_ENTRY_SIZE; - if (dma_memory_read(&address_space_memory, s->devtab + offset, entry, + if (dma_memory_read(get_address_space_memory(), s->devtab + offset, entry, AMDVI_DEVTAB_ENTRY_SIZE, MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_dte_get_fail(s->devtab, offset); /* log error accessing dte */ @@ -886,7 +886,7 @@ static inline uint64_t amdvi_get_pte_entry(AMDVIState *s, uint64_t pte_addr, { uint64_t pte; - if (dma_memory_read(&address_space_memory, pte_addr, + if (dma_memory_read(get_address_space_memory(), pte_addr, &pte, sizeof(pte), MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_get_pte_hwerror(pte_addr); amdvi_log_pagetab_error(s, devid, pte_addr, 0); @@ -1010,7 +1010,7 @@ static IOMMUTLBEntry amdvi_translate(IOMMUMemoryRegion *iommu, hwaddr addr, AMDVIAddressSpace *as = container_of(iommu, AMDVIAddressSpace, iommu); AMDVIState *s = as->iommu_state; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr, .translated_addr = 0, .addr_mask = ~(hwaddr)0, @@ -1050,7 +1050,7 @@ static int amdvi_get_irte(AMDVIState *s, MSIMessage *origin, uint64_t *dte, trace_amdvi_ir_irte(irte_root, offset); - if (dma_memory_read(&address_space_memory, irte_root + offset, + if (dma_memory_read(get_address_space_memory(), irte_root + offset, irte, sizeof(*irte), MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_ir_err("failed to get irte"); return -AMDVI_IR_GET_IRTE; @@ -1110,7 +1110,7 @@ static int amdvi_get_irte_ga(AMDVIState *s, MSIMessage *origin, uint64_t *dte, offset = (origin->data & AMDVI_IRTE_OFFSET) << 4; trace_amdvi_ir_irte(irte_root, offset); - if (dma_memory_read(&address_space_memory, irte_root + offset, + if (dma_memory_read(get_address_space_memory(), irte_root + offset, irte, sizeof(*irte), MEMTXATTRS_UNSPECIFIED)) { trace_amdvi_ir_err("failed to get irte_ga"); return -AMDVI_IR_GET_IRTE; diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c index a283785a8d..4b9964c340 100644 --- a/hw/i386/fw_cfg.c +++ b/hw/i386/fw_cfg.c @@ -104,7 +104,7 @@ FWCfgState *fw_cfg_arch_create(MachineState *ms, int nb_numa_nodes = ms->numa_state->num_nodes; fw_cfg = fw_cfg_init_io_dma(FW_CFG_IO_BASE, FW_CFG_IO_BASE + 4, - &address_space_memory); + get_address_space_memory()); fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, boot_cpus); /* FW_CFG_MAX_CPUS is a bit confusing/problematic on x86: diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 05d53a1aa9..c7c08de1ba 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -576,7 +576,7 @@ static int vtd_get_root_entry(IntelIOMMUState *s, uint8_t index, dma_addr_t addr; addr = s->root + index * sizeof(*re); - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, re, sizeof(*re), MEMTXATTRS_UNSPECIFIED)) { re->lo = 0; return -VTD_FR_ROOT_TABLE_INV; @@ -610,7 +610,7 @@ static int vtd_get_context_entry_from_root(IntelIOMMUState *s, } addr = addr + index * ce_size; - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, ce, ce_size, MEMTXATTRS_UNSPECIFIED)) { return -VTD_FR_CONTEXT_TABLE_INV; } @@ -647,7 +647,7 @@ static uint64_t vtd_get_slpte(dma_addr_t base_addr, uint32_t index) assert(index < VTD_SL_PT_ENTRY_NR); - if (dma_memory_read(&address_space_memory, + if (dma_memory_read(get_address_space_memory(), base_addr + index * sizeof(slpte), &slpte, sizeof(slpte), MEMTXATTRS_UNSPECIFIED)) { slpte = (uint64_t)-1; @@ -713,7 +713,7 @@ static int vtd_get_pdire_from_pdir_table(dma_addr_t pasid_dir_base, index = VTD_PASID_DIR_INDEX(pasid); entry_size = VTD_PASID_DIR_ENTRY_SIZE; addr = pasid_dir_base + index * entry_size; - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, pdire, entry_size, MEMTXATTRS_UNSPECIFIED)) { return -VTD_FR_PASID_TABLE_INV; } @@ -738,7 +738,7 @@ static int vtd_get_pe_in_pasid_leaf_table(IntelIOMMUState *s, index = VTD_PASID_TABLE_INDEX(pasid); entry_size = VTD_PASID_ENTRY_SIZE; addr = addr + index * entry_size; - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, pe, entry_size, MEMTXATTRS_UNSPECIFIED)) { return -VTD_FR_PASID_TABLE_INV; } @@ -1281,7 +1281,7 @@ static int vtd_page_walk_level(dma_addr_t addr, uint64_t start, * * In either case, we send an IOTLB notification down. */ - event.entry.target_as = &address_space_memory; + event.entry.target_as = get_address_space_memory(); event.entry.iova = iova & subpage_mask; event.entry.perm = IOMMU_ACCESS_FLAG(read_cur, write_cur); event.entry.addr_mask = ~subpage_mask; @@ -2049,7 +2049,7 @@ static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, IOMMUTLBEvent event = { .type = IOMMU_NOTIFIER_UNMAP, .entry = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr, .translated_addr = 0, .addr_mask = size - 1, @@ -2320,7 +2320,7 @@ static bool vtd_get_inv_desc(IntelIOMMUState *s, uint32_t dw = s->iq_dw ? 32 : 16; dma_addr_t addr = base_addr + offset * dw; - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, inv_desc, dw, MEMTXATTRS_UNSPECIFIED)) { error_report_once("Read INV DESC failed."); return false; @@ -2354,7 +2354,7 @@ static bool vtd_process_wait_desc(IntelIOMMUState *s, VTDInvDesc *inv_desc) dma_addr_t status_addr = inv_desc->hi; trace_vtd_inv_desc_wait_sw(status_addr, status_data); status_data = cpu_to_le32(status_data); - if (dma_memory_write(&address_space_memory, status_addr, + if (dma_memory_write(get_address_space_memory(), status_addr, &status_data, sizeof(status_data), MEMTXATTRS_UNSPECIFIED)) { trace_vtd_inv_desc_wait_write_fail(inv_desc->hi, inv_desc->lo); @@ -3016,7 +3016,7 @@ static IOMMUTLBEntry vtd_iommu_translate(IOMMUMemoryRegion *iommu, hwaddr addr, IntelIOMMUState *s = vtd_as->iommu_state; IOMMUTLBEntry iotlb = { /* We'll fill in the rest later. */ - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), }; bool success; @@ -3173,7 +3173,7 @@ static int vtd_irte_get(IntelIOMMUState *iommu, uint16_t index, } addr = iommu->intr_root + index * sizeof(*entry); - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, entry, sizeof(*entry), MEMTXATTRS_UNSPECIFIED)) { error_report_once("%s: read failed: ind=0x%x addr=0x%" PRIx64, __func__, index, addr); @@ -3543,7 +3543,7 @@ static void vtd_address_space_unmap(VTDAddressSpace *as, IOMMUNotifier *n) event.type = IOMMU_NOTIFIER_UNMAP; event.entry.iova = start; event.entry.addr_mask = mask; - event.entry.target_as = &address_space_memory; + event.entry.target_as = get_address_space_memory(); event.entry.perm = IOMMU_NONE; /* This field is meaningless for unmap */ event.entry.translated_addr = 0; diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 52cafa003d..b56a56fe16 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -318,7 +318,7 @@ static void microvm_memory_init(MicrovmMachineState *mms) } fw_cfg = fw_cfg_init_io_dma(FW_CFG_IO_BASE, FW_CFG_IO_BASE + 4, - &address_space_memory); + get_address_space_memory()); fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, machine->smp.cpus); fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, machine->smp.max_cpus); @@ -342,7 +342,7 @@ static void microvm_memory_init(MicrovmMachineState *mms) } x86ms->fw_cfg = fw_cfg; - x86ms->ioapic_as = &address_space_memory; + x86ms->ioapic_as = get_address_space_memory(); } static gchar *microvm_get_mmio_cmdline(gchar *name, uint32_t virtio_irq_base) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 566accf7e6..f48c630941 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1130,7 +1130,7 @@ void pc_memory_init(PCMachineState *pcms, x86ms->fw_cfg = fw_cfg; /* Init default IOAPIC address space */ - x86ms->ioapic_as = &address_space_memory; + x86ms->ioapic_as = get_address_space_memory(); /* Init ACPI memory hotplug IO base address */ pcms->memhp_io_base = ACPI_MEMORY_HOTPLUG_BASE; diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index e4293d6d66..e38996a88f 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -1491,11 +1491,11 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); state->memory_listener = xen_memory_listener; - memory_listener_register(&state->memory_listener, &address_space_memory); + memory_listener_register(&state->memory_listener, get_address_space_memory()); state->log_for_dirtybit = NULL; state->io_listener = xen_io_listener; - memory_listener_register(&state->io_listener, &address_space_io); + memory_listener_register(&state->io_listener, get_address_space_io()); state->device_listener = xen_device_listener; QLIST_INIT(&state->dev_list); diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 7ce001cacd..ed294ae25b 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1789,7 +1789,7 @@ static void sysbus_ahci_realize(DeviceState *dev, Error **errp) { SysbusAHCIState *s = SYSBUS_AHCI(dev); - ahci_realize(&s->ahci, dev, &address_space_memory, s->num_ports); + ahci_realize(&s->ahci, dev, get_address_space_memory(), s->num_ports); } static Property sysbus_ahci_properties[] = { diff --git a/hw/ide/macio.c b/hw/ide/macio.c index 1c15c37ec5..09979f40a3 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -96,7 +96,7 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int ret) if (s->lba == -1) { /* Non-block ATAPI transfer - just copy to RAM */ s->io_buffer_size = MIN(s->io_buffer_size, io->len); - dma_memory_write(&address_space_memory, io->addr, s->io_buffer, + dma_memory_write(get_address_space_memory(), io->addr, s->io_buffer, s->io_buffer_size, MEMTXATTRS_UNSPECIFIED); io->len = 0; ide_atapi_cmd_ok(s); @@ -108,7 +108,7 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int ret) offset = ((int64_t)s->lba << 11) + s->io_buffer_index; qemu_sglist_init(&s->sg, DEVICE(m), io->len / MACIO_PAGE_SIZE + 1, - &address_space_memory); + get_address_space_memory()); qemu_sglist_add(&s->sg, io->addr, io->len); s->io_buffer_size -= io->len; s->io_buffer_index += io->len; @@ -119,7 +119,7 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int ret) return; done: - dma_memory_unmap(&address_space_memory, io->dma_mem, io->dma_len, + dma_memory_unmap(get_address_space_memory(), io->dma_mem, io->dma_len, io->dir, io->dma_len); if (ret < 0) { @@ -174,7 +174,7 @@ static void pmac_ide_transfer_cb(void *opaque, int ret) offset = (ide_get_sector(s) << 9) + s->io_buffer_index; qemu_sglist_init(&s->sg, DEVICE(m), io->len / MACIO_PAGE_SIZE + 1, - &address_space_memory); + get_address_space_memory()); qemu_sglist_add(&s->sg, io->addr, io->len); s->io_buffer_size -= io->len; s->io_buffer_index += io->len; @@ -202,7 +202,7 @@ static void pmac_ide_transfer_cb(void *opaque, int ret) return; done: - dma_memory_unmap(&address_space_memory, io->dma_mem, io->dma_len, + dma_memory_unmap(get_address_space_memory(), io->dma_mem, io->dma_len, io->dir, io->dma_len); if (s->dma_cmd == IDE_DMA_READ || s->dma_cmd == IDE_DMA_WRITE) { diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 3df11c34d6..7eff017fce 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -123,7 +123,7 @@ static void apic_sync_vapic(APICCommonState *s, int sync_type) } vapic_state.irr = vector & 0xff; - address_space_write_rom(&address_space_memory, + address_space_write_rom(get_address_space_memory(), s->vapic_paddr + start, MEMTXATTRS_UNSPECIFIED, ((void *)&vapic_state) + start, length); diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c index 557dd0c2bf..1e861793ef 100644 --- a/hw/intc/openpic_kvm.c +++ b/hw/intc/openpic_kvm.c @@ -235,7 +235,7 @@ static void kvm_openpic_realize(DeviceState *dev, Error **errp) opp->mem_listener.region_add = kvm_openpic_region_add; opp->mem_listener.region_del = kvm_openpic_region_del; opp->mem_listener.name = "openpic-kvm"; - memory_listener_register(&opp->mem_listener, &address_space_memory); + memory_listener_register(&opp->mem_listener, get_address_space_memory()); /* indicate pic capabilities */ msi_nonbroken = true; diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c index c7b75ed12e..c1066ff521 100644 --- a/hw/intc/pnv_xive.c +++ b/hw/intc/pnv_xive.c @@ -152,7 +152,7 @@ static uint64_t pnv_xive_vst_addr_indirect(PnvXive *xive, uint32_t type, /* Get the page size of the indirect table. */ vsd_addr = vsd & VSD_ADDRESS_MASK; - if (ldq_be_dma(&address_space_memory, vsd_addr, &vsd, + if (ldq_be_dma(get_address_space_memory(), vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED)) { xive_error(xive, "VST: failed to access %s entry %x @0x%" PRIx64, info->name, idx, vsd_addr); @@ -180,7 +180,7 @@ static uint64_t pnv_xive_vst_addr_indirect(PnvXive *xive, uint32_t type, /* Load the VSD we are looking for, if not already done */ if (vsd_idx) { vsd_addr = vsd_addr + vsd_idx * XIVE_VSD_SIZE; - if (ldq_be_dma(&address_space_memory, vsd_addr, &vsd, + if (ldq_be_dma(get_address_space_memory(), vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED)) { xive_error(xive, "VST: failed to access %s entry %x @0x%" PRIx64, info->name, vsd_idx, vsd_addr); @@ -560,7 +560,7 @@ static uint64_t pnv_xive_vst_per_subpage(PnvXive *xive, uint32_t type) /* Get the page size of the indirect table. */ vsd_addr = vsd & VSD_ADDRESS_MASK; - if (ldq_be_dma(&address_space_memory, vsd_addr, &vsd, + if (ldq_be_dma(get_address_space_memory(), vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED)) { xive_error(xive, "VST: failed to access %s entry @0x%" PRIx64, info->name, vsd_addr); diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c index f22ce5ca59..1ae0660c36 100644 --- a/hw/intc/pnv_xive2.c +++ b/hw/intc/pnv_xive2.c @@ -159,7 +159,7 @@ static uint64_t pnv_xive2_vst_addr_indirect(PnvXive2 *xive, uint32_t type, /* Get the page size of the indirect table. */ vsd_addr = vsd & VSD_ADDRESS_MASK; - ldq_be_dma(&address_space_memory, vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED); + ldq_be_dma(get_address_space_memory(), vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED); if (!(vsd & VSD_ADDRESS_MASK)) { xive2_error(xive, "VST: invalid %s entry %x !?", info->name, idx); @@ -180,7 +180,7 @@ static uint64_t pnv_xive2_vst_addr_indirect(PnvXive2 *xive, uint32_t type, /* Load the VSD we are looking for, if not already done */ if (vsd_idx) { vsd_addr = vsd_addr + vsd_idx * XIVE_VSD_SIZE; - ldq_be_dma(&address_space_memory, vsd_addr, &vsd, + ldq_be_dma(get_address_space_memory(), vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED); if (!(vsd & VSD_ADDRESS_MASK)) { @@ -2044,7 +2044,7 @@ static uint64_t pnv_xive2_vst_per_subpage(PnvXive2 *xive, uint32_t type) /* Get the page size of the indirect table. */ vsd_addr = vsd & VSD_ADDRESS_MASK; - ldq_be_dma(&address_space_memory, vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED); + ldq_be_dma(get_address_space_memory(), vsd_addr, &vsd, MEMTXATTRS_UNSPECIFIED); if (!(vsd & VSD_ADDRESS_MASK)) { #ifdef XIVE2_DEBUG diff --git a/hw/intc/riscv_aplic.c b/hw/intc/riscv_aplic.c index cfd007e629..31ca6da794 100644 --- a/hw/intc/riscv_aplic.c +++ b/hw/intc/riscv_aplic.c @@ -350,7 +350,7 @@ static void riscv_aplic_msi_send(RISCVAPLICState *aplic, addr |= (uint64_t)(guest_idx & APLIC_xMSICFGADDR_PPN_HART(lhxs)); addr <<= APLIC_xMSICFGADDR_PPN_SHIFT; - address_space_stl_le(&address_space_memory, addr, + address_space_stl_le(get_address_space_memory(), addr, eiid, MEMTXATTRS_UNSPECIFIED, &result); if (result != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, "%s: MSI write failed for " diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c index dc641cc604..987769a217 100644 --- a/hw/intc/spapr_xive.c +++ b/hw/intc/spapr_xive.c @@ -1708,7 +1708,7 @@ static target_ulong h_int_esb(PowerPCCPU *cpu, } else { mmio_addr = xive->vc_base + xive_source_esb_mgmt(xsrc, lisn) + offset; - if (dma_memory_rw(&address_space_memory, mmio_addr, &data, 8, + if (dma_memory_rw(get_address_space_memory(), mmio_addr, &data, 8, (flags & SPAPR_XIVE_ESB_STORE), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "XIVE: failed to access ESB @0x%" diff --git a/hw/intc/xive.c b/hw/intc/xive.c index a986b96843..1333a3f7a1 100644 --- a/hw/intc/xive.c +++ b/hw/intc/xive.c @@ -1294,7 +1294,7 @@ void xive_end_queue_pic_print_info(XiveEND *end, uint32_t width, Monitor *mon) uint64_t qaddr = qaddr_base + (qindex << 2); uint32_t qdata = -1; - if (dma_memory_read(&address_space_memory, qaddr, + if (dma_memory_read(get_address_space_memory(), qaddr, &qdata, sizeof(qdata), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "XIVE: failed to read EQ @0x%" HWADDR_PRIx "\n", qaddr); @@ -1359,7 +1359,7 @@ static void xive_end_enqueue(XiveEND *end, uint32_t data) uint32_t qdata = cpu_to_be32((qgen << 31) | (data & 0x7fffffff)); uint32_t qentries = 1 << (qsize + 10); - if (dma_memory_write(&address_space_memory, qaddr, + if (dma_memory_write(get_address_space_memory(), qaddr, &qdata, sizeof(qdata), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "XIVE: failed to write END data @0x%" HWADDR_PRIx "\n", qaddr); diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c index 4d9ff41956..58987e556c 100644 --- a/hw/intc/xive2.c +++ b/hw/intc/xive2.c @@ -58,7 +58,7 @@ void xive2_end_queue_pic_print_info(Xive2End *end, uint32_t width, uint64_t qaddr = qaddr_base + (qindex << 2); uint32_t qdata = -1; - if (dma_memory_read(&address_space_memory, qaddr, &qdata, + if (dma_memory_read(get_address_space_memory(), qaddr, &qdata, sizeof(qdata), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "XIVE: failed to read EQ @0x%" HWADDR_PRIx "\n", qaddr); @@ -149,7 +149,7 @@ static void xive2_end_enqueue(Xive2End *end, uint32_t data) uint32_t qdata = cpu_to_be32((qgen << 31) | (data & 0x7fffffff)); uint32_t qentries = 1 << (qsize + 10); - if (dma_memory_write(&address_space_memory, qaddr, &qdata, sizeof(qdata), + if (dma_memory_write(get_address_space_memory(), qaddr, &qdata, sizeof(qdata), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "XIVE: failed to write END data @0x%" HWADDR_PRIx "\n", qaddr); diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c index 6aefe9a61b..1a17bac510 100644 --- a/hw/mips/jazz.c +++ b/hw/mips/jazz.c @@ -70,7 +70,7 @@ static void main_cpu_reset(void *opaque) static uint64_t rtc_read(void *opaque, hwaddr addr, unsigned size) { uint8_t val; - address_space_read(&address_space_memory, 0x90000071, + address_space_read(get_address_space_memory(), 0x90000071, MEMTXATTRS_UNSPECIFIED, &val, 1); return val; } @@ -79,7 +79,7 @@ static void rtc_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { uint8_t buf = val & 0xff; - address_space_write(&address_space_memory, 0x90000071, + address_space_write(get_address_space_memory(), 0x90000071, MEMTXATTRS_UNSPECIFIED, &buf, 1); } diff --git a/hw/misc/lasi.c b/hw/misc/lasi.c index 23a7634a8c..c35b4bde0a 100644 --- a/hw/misc/lasi.c +++ b/hw/misc/lasi.c @@ -220,7 +220,7 @@ static void lasi_set_irq(void *opaque, int irq, int level) uint32_t iar = s->iar; s->irr |= bit; if ((s->icr & ICR_BUS_ERROR_BIT) == 0) { - stl_be_phys(&address_space_memory, iar & -32, iar & 31); + stl_be_phys(get_address_space_memory(), iar & -32, iar & 31); } } } diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdma.c index efcc02609f..cb7ef894a6 100644 --- a/hw/misc/macio/mac_dbdma.c +++ b/hw/misc/macio/mac_dbdma.c @@ -93,7 +93,7 @@ static void dbdma_cmdptr_load(DBDMA_channel *ch) { DBDMA_DPRINTFCH(ch, "dbdma_cmdptr_load 0x%08x\n", ch->regs[DBDMA_CMDPTR_LO]); - dma_memory_read(&address_space_memory, ch->regs[DBDMA_CMDPTR_LO], + dma_memory_read(get_address_space_memory(), ch->regs[DBDMA_CMDPTR_LO], &ch->current, sizeof(dbdma_cmd), MEMTXATTRS_UNSPECIFIED); } @@ -103,7 +103,7 @@ static void dbdma_cmdptr_save(DBDMA_channel *ch) ch->regs[DBDMA_CMDPTR_LO], le16_to_cpu(ch->current.xfer_status), le16_to_cpu(ch->current.res_count)); - dma_memory_write(&address_space_memory, ch->regs[DBDMA_CMDPTR_LO], + dma_memory_write(get_address_space_memory(), ch->regs[DBDMA_CMDPTR_LO], &ch->current, sizeof(dbdma_cmd), MEMTXATTRS_UNSPECIFIED); } @@ -371,7 +371,7 @@ static void load_word(DBDMA_channel *ch, int key, uint32_t addr, return; } - dma_memory_read(&address_space_memory, addr, ¤t->cmd_dep, len, + dma_memory_read(get_address_space_memory(), addr, ¤t->cmd_dep, len, MEMTXATTRS_UNSPECIFIED); if (conditional_wait(ch)) @@ -404,7 +404,7 @@ static void store_word(DBDMA_channel *ch, int key, uint32_t addr, return; } - dma_memory_write(&address_space_memory, addr, ¤t->cmd_dep, len, + dma_memory_write(get_address_space_memory(), addr, ¤t->cmd_dep, len, MEMTXATTRS_UNSPECIFIED); if (conditional_wait(ch)) diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c index 83ef0a783e..53c464c2e5 100644 --- a/hw/net/ftgmac100.c +++ b/hw/net/ftgmac100.c @@ -453,7 +453,7 @@ static void do_phy_ctl(FTGMAC100State *s) static int ftgmac100_read_bd(FTGMAC100Desc *bd, dma_addr_t addr) { - if (dma_memory_read(&address_space_memory, addr, + if (dma_memory_read(get_address_space_memory(), addr, bd, sizeof(*bd), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to read descriptor @ 0x%" HWADDR_PRIx "\n", __func__, addr); @@ -474,7 +474,7 @@ static int ftgmac100_write_bd(FTGMAC100Desc *bd, dma_addr_t addr) lebd.des1 = cpu_to_le32(bd->des1); lebd.des2 = cpu_to_le32(bd->des2); lebd.des3 = cpu_to_le32(bd->des3); - if (dma_memory_write(&address_space_memory, addr, + if (dma_memory_write(get_address_space_memory(), addr, &lebd, sizeof(lebd), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to write descriptor @ 0x%" HWADDR_PRIx "\n", __func__, addr); @@ -556,7 +556,7 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t tx_ring, len = sizeof(s->frame) - frame_size; } - if (dma_memory_read(&address_space_memory, bd.des3, + if (dma_memory_read(get_address_space_memory(), bd.des3, ptr, len, MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to read packet @ 0x%x\n", __func__, bd.des3); @@ -1033,23 +1033,23 @@ static ssize_t ftgmac100_receive(NetClientState *nc, const uint8_t *buf, bd.des1 = lduw_be_p(buf + 14) | FTGMAC100_RXDES1_VLANTAG_AVAIL; if (s->maccr & FTGMAC100_MACCR_RM_VLAN) { - dma_memory_write(&address_space_memory, buf_addr, buf, 12, + dma_memory_write(get_address_space_memory(), buf_addr, buf, 12, MEMTXATTRS_UNSPECIFIED); - dma_memory_write(&address_space_memory, buf_addr + 12, + dma_memory_write(get_address_space_memory(), buf_addr + 12, buf + 16, buf_len - 16, MEMTXATTRS_UNSPECIFIED); } else { - dma_memory_write(&address_space_memory, buf_addr, buf, + dma_memory_write(get_address_space_memory(), buf_addr, buf, buf_len, MEMTXATTRS_UNSPECIFIED); } } else { bd.des1 = 0; - dma_memory_write(&address_space_memory, buf_addr, buf, buf_len, + dma_memory_write(get_address_space_memory(), buf_addr, buf, buf_len, MEMTXATTRS_UNSPECIFIED); } buf += buf_len; if (size < 4) { - dma_memory_write(&address_space_memory, buf_addr + buf_len, + dma_memory_write(get_address_space_memory(), buf_addr + buf_len, crc_ptr, 4 - size, MEMTXATTRS_UNSPECIFIED); crc_ptr += 4 - size; } diff --git a/hw/net/i82596.c b/hw/net/i82596.c index ec21e2699a..b7b07b725a 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -88,28 +88,28 @@ enum commands { static uint8_t get_byte(uint32_t addr) { - return ldub_phys(&address_space_memory, addr); + return ldub_phys(get_address_space_memory(), addr); } static void set_byte(uint32_t addr, uint8_t c) { - return stb_phys(&address_space_memory, addr, c); + return stb_phys(get_address_space_memory(), addr, c); } static uint16_t get_uint16(uint32_t addr) { - return lduw_be_phys(&address_space_memory, addr); + return lduw_be_phys(get_address_space_memory(), addr); } static void set_uint16(uint32_t addr, uint16_t w) { - return stw_be_phys(&address_space_memory, addr, w); + return stw_be_phys(get_address_space_memory(), addr, w); } static uint32_t get_uint32(uint32_t addr) { - uint32_t lo = lduw_be_phys(&address_space_memory, addr); - uint32_t hi = lduw_be_phys(&address_space_memory, addr + 2); + uint32_t lo = lduw_be_phys(get_address_space_memory(), addr); + uint32_t hi = lduw_be_phys(get_address_space_memory(), addr + 2); return (hi << 16) | lo; } @@ -150,7 +150,7 @@ static void i82596_transmit(I82596State *s, uint32_t addr) if (s->nic && len) { assert(len <= sizeof(s->tx_buffer)); - address_space_read(&address_space_memory, tba, + address_space_read(get_address_space_memory(), tba, MEMTXATTRS_UNSPECIFIED, s->tx_buffer, len); DBG(PRINT_PKTHDR("Send", &s->tx_buffer)); DBG(printf("Sending %d bytes\n", len)); @@ -174,7 +174,7 @@ static void set_individual_address(I82596State *s, uint32_t addr) nc = qemu_get_queue(s->nic); m = s->conf.macaddr.a; - address_space_read(&address_space_memory, addr + 8, + address_space_read(get_address_space_memory(), addr + 8, MEMTXATTRS_UNSPECIFIED, m, ETH_ALEN); qemu_format_nic_info_str(nc, m); trace_i82596_new_mac(nc->info_str); @@ -192,7 +192,7 @@ static void set_multicast_list(I82596State *s, uint32_t addr) } for (i = 0; i < mc_count; i++) { uint8_t multicast_addr[ETH_ALEN]; - address_space_read(&address_space_memory, addr + i * ETH_ALEN, + address_space_read(get_address_space_memory(), addr + i * ETH_ALEN, MEMTXATTRS_UNSPECIFIED, multicast_addr, ETH_ALEN); DBG(printf("Add multicast entry " MAC_FMT "\n", MAC_ARG(multicast_addr))); @@ -261,7 +261,7 @@ static void command_loop(I82596State *s) byte_cnt = MAX(byte_cnt, 4); byte_cnt = MIN(byte_cnt, sizeof(s->config)); /* copy byte_cnt max. */ - address_space_read(&address_space_memory, s->cmd_p + 8, + address_space_read(get_address_space_memory(), s->cmd_p + 8, MEMTXATTRS_UNSPECIFIED, s->config, byte_cnt); /* config byte according to page 35ff */ s->config[2] &= 0x82; /* mask valid bits */ @@ -654,7 +654,7 @@ ssize_t i82596_receive(NetClientState *nc, const uint8_t *buf, size_t sz) /* Still some of the actual data buffer to transfer */ assert(bufsz >= bufcount); bufsz -= bufcount; - address_space_write(&address_space_memory, rba, + address_space_write(get_address_space_memory(), rba, MEMTXATTRS_UNSPECIFIED, buf, bufcount); rba += bufcount; buf += bufcount; @@ -663,7 +663,7 @@ ssize_t i82596_receive(NetClientState *nc, const uint8_t *buf, size_t sz) /* Write as much of the CRC as fits */ if (crccount > 0) { - address_space_write(&address_space_memory, rba, + address_space_write(get_address_space_memory(), rba, MEMTXATTRS_UNSPECIFIED, crc_ptr, crccount); rba += crccount; crc_ptr += crccount; diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 8c11b237de..d16ac730cf 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -387,7 +387,7 @@ static void imx_phy_write(IMXFECState *s, int reg, uint32_t val) static void imx_fec_read_bd(IMXFECBufDesc *bd, dma_addr_t addr) { - dma_memory_read(&address_space_memory, addr, bd, sizeof(*bd), + dma_memory_read(get_address_space_memory(), addr, bd, sizeof(*bd), MEMTXATTRS_UNSPECIFIED); trace_imx_fec_read_bd(addr, bd->flags, bd->length, bd->data); @@ -395,13 +395,13 @@ static void imx_fec_read_bd(IMXFECBufDesc *bd, dma_addr_t addr) static void imx_fec_write_bd(IMXFECBufDesc *bd, dma_addr_t addr) { - dma_memory_write(&address_space_memory, addr, bd, sizeof(*bd), + dma_memory_write(get_address_space_memory(), addr, bd, sizeof(*bd), MEMTXATTRS_UNSPECIFIED); } static void imx_enet_read_bd(IMXENETBufDesc *bd, dma_addr_t addr) { - dma_memory_read(&address_space_memory, addr, bd, sizeof(*bd), + dma_memory_read(get_address_space_memory(), addr, bd, sizeof(*bd), MEMTXATTRS_UNSPECIFIED); trace_imx_enet_read_bd(addr, bd->flags, bd->length, bd->data, @@ -410,7 +410,7 @@ static void imx_enet_read_bd(IMXENETBufDesc *bd, dma_addr_t addr) static void imx_enet_write_bd(IMXENETBufDesc *bd, dma_addr_t addr) { - dma_memory_write(&address_space_memory, addr, bd, sizeof(*bd), + dma_memory_write(get_address_space_memory(), addr, bd, sizeof(*bd), MEMTXATTRS_UNSPECIFIED); } @@ -478,7 +478,7 @@ static void imx_fec_do_tx(IMXFECState *s) len = ENET_MAX_FRAME_SIZE - frame_size; s->regs[ENET_EIR] |= ENET_INT_BABT; } - dma_memory_read(&address_space_memory, bd.data, ptr, len, + dma_memory_read(get_address_space_memory(), bd.data, ptr, len, MEMTXATTRS_UNSPECIFIED); ptr += len; frame_size += len; @@ -560,7 +560,7 @@ static void imx_enet_do_tx(IMXFECState *s, uint32_t index) len = ENET_MAX_FRAME_SIZE - frame_size; s->regs[ENET_EIR] |= ENET_INT_BABT; } - dma_memory_read(&address_space_memory, bd.data, ptr, len, + dma_memory_read(get_address_space_memory(), bd.data, ptr, len, MEMTXATTRS_UNSPECIFIED); ptr += len; frame_size += len; @@ -1109,11 +1109,11 @@ static ssize_t imx_fec_receive(NetClientState *nc, const uint8_t *buf, buf_len += size - 4; } buf_addr = bd.data; - dma_memory_write(&address_space_memory, buf_addr, buf, buf_len, + dma_memory_write(get_address_space_memory(), buf_addr, buf, buf_len, MEMTXATTRS_UNSPECIFIED); buf += buf_len; if (size < 4) { - dma_memory_write(&address_space_memory, buf_addr + buf_len, + dma_memory_write(get_address_space_memory(), buf_addr + buf_len, crc_ptr, 4 - size, MEMTXATTRS_UNSPECIFIED); crc_ptr += 4 - size; } @@ -1217,7 +1217,7 @@ static ssize_t imx_enet_receive(NetClientState *nc, const uint8_t *buf, */ const uint8_t zeros[2] = { 0 }; - dma_memory_write(&address_space_memory, buf_addr, zeros, + dma_memory_write(get_address_space_memory(), buf_addr, zeros, sizeof(zeros), MEMTXATTRS_UNSPECIFIED); buf_addr += sizeof(zeros); @@ -1227,11 +1227,11 @@ static ssize_t imx_enet_receive(NetClientState *nc, const uint8_t *buf, shift16 = false; } - dma_memory_write(&address_space_memory, buf_addr, buf, buf_len, + dma_memory_write(get_address_space_memory(), buf_addr, buf, buf_len, MEMTXATTRS_UNSPECIFIED); buf += buf_len; if (size < 4) { - dma_memory_write(&address_space_memory, buf_addr + buf_len, + dma_memory_write(get_address_space_memory(), buf_addr + buf_len, crc_ptr, 4 - size, MEMTXATTRS_UNSPECIFIED); crc_ptr += 4 - size; } diff --git a/hw/net/lasi_i82596.c b/hw/net/lasi_i82596.c index e37f7fabe9..9df88f72d9 100644 --- a/hw/net/lasi_i82596.c +++ b/hw/net/lasi_i82596.c @@ -55,7 +55,7 @@ static void lasi_82596_mem_write(void *opaque, hwaddr addr, * Provided for SeaBIOS only. Write MAC of Network card to addr @val. * Needed for the PDC_LAN_STATION_ID_READ PDC call. */ - address_space_write(&address_space_memory, val, + address_space_write(get_address_space_memory(), val, MEMTXATTRS_UNSPECIFIED, d->state.conf.macaddr.a, ETH_ALEN); break; diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c86bb52e5..0ebe1eb1b1 100644 --- a/hw/net/npcm7xx_emc.c +++ b/hw/net/npcm7xx_emc.c @@ -199,7 +199,7 @@ static void emc_update_irq_from_reg_change(NPCM7xxEMCState *emc) static int emc_read_tx_desc(dma_addr_t addr, NPCM7xxEMCTxDesc *desc) { - if (dma_memory_read(&address_space_memory, addr, desc, + if (dma_memory_read(get_address_space_memory(), addr, desc, sizeof(*desc), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Failed to read descriptor @ 0x%" HWADDR_PRIx "\n", __func__, addr); @@ -220,7 +220,7 @@ static int emc_write_tx_desc(const NPCM7xxEMCTxDesc *desc, dma_addr_t addr) le_desc.txbsa = cpu_to_le32(desc->txbsa); le_desc.status_and_length = cpu_to_le32(desc->status_and_length); le_desc.ntxdsa = cpu_to_le32(desc->ntxdsa); - if (dma_memory_write(&address_space_memory, addr, &le_desc, + if (dma_memory_write(get_address_space_memory(), addr, &le_desc, sizeof(le_desc), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Failed to write descriptor @ 0x%" HWADDR_PRIx "\n", __func__, addr); @@ -231,7 +231,7 @@ static int emc_write_tx_desc(const NPCM7xxEMCTxDesc *desc, dma_addr_t addr) static int emc_read_rx_desc(dma_addr_t addr, NPCM7xxEMCRxDesc *desc) { - if (dma_memory_read(&address_space_memory, addr, desc, + if (dma_memory_read(get_address_space_memory(), addr, desc, sizeof(*desc), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Failed to read descriptor @ 0x%" HWADDR_PRIx "\n", __func__, addr); @@ -252,7 +252,7 @@ static int emc_write_rx_desc(const NPCM7xxEMCRxDesc *desc, dma_addr_t addr) le_desc.rxbsa = cpu_to_le32(desc->rxbsa); le_desc.reserved = cpu_to_le32(desc->reserved); le_desc.nrxdsa = cpu_to_le32(desc->nrxdsa); - if (dma_memory_write(&address_space_memory, addr, &le_desc, + if (dma_memory_write(get_address_space_memory(), addr, &le_desc, sizeof(le_desc), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Failed to write descriptor @ 0x%" HWADDR_PRIx "\n", __func__, addr); @@ -367,7 +367,7 @@ static void emc_try_send_next_packet(NPCM7xxEMCState *emc) buf = malloced_buf; } - if (dma_memory_read(&address_space_memory, next_buf_addr, buf, + if (dma_memory_read(get_address_space_memory(), next_buf_addr, buf, length, MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Failed to read packet @ 0x%x\n", __func__, next_buf_addr); @@ -553,10 +553,10 @@ static ssize_t emc_receive(NetClientState *nc, const uint8_t *buf, size_t len1) buf_addr = rx_desc.rxbsa; emc->regs[REG_CRXBSA] = buf_addr; - if (dma_memory_write(&address_space_memory, buf_addr, buf, + if (dma_memory_write(get_address_space_memory(), buf_addr, buf, len, MEMTXATTRS_UNSPECIFIED) || (!(emc->regs[REG_MCMDR] & REG_MCMDR_SPCRC) && - dma_memory_write(&address_space_memory, buf_addr + len, + dma_memory_write(get_address_space_memory(), buf_addr + len, crc_ptr, 4, MEMTXATTRS_UNSPECIFIED))) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Bus error writing packet\n", __func__); diff --git a/hw/openrisc/boot.c b/hw/openrisc/boot.c index 128ccbcba2..50a70c01f7 100644 --- a/hw/openrisc/boot.c +++ b/hw/openrisc/boot.c @@ -110,7 +110,7 @@ uint32_t openrisc_load_fdt(void *fdt, hwaddr load_start, qemu_fdt_dumpdtb(fdt, fdtsize); rom_add_blob_fixed_as("fdt", fdt, fdtsize, fdt_addr, - &address_space_memory); + get_address_space_memory()); return fdt_addr; } diff --git a/hw/pci-host/dino.c b/hw/pci-host/dino.c index f257c24e64..3aa1081ff0 100644 --- a/hw/pci-host/dino.c +++ b/hw/pci-host/dino.c @@ -104,7 +104,7 @@ static MemTxResult dino_chip_read_with_attrs(void *opaque, hwaddr addr, switch (addr) { case DINO_PCI_IO_DATA ... DINO_PCI_IO_DATA + 3: /* Read from PCI IO space. */ - io = &address_space_io; + io = get_address_space_io(); ioaddr = phb->config_reg + (addr & 3); switch (size) { case 1: @@ -199,7 +199,7 @@ static MemTxResult dino_chip_write_with_attrs(void *opaque, hwaddr addr, switch (addr) { case DINO_IO_DATA ... DINO_PCI_IO_DATA + 3: /* Write into PCI IO space. */ - io = &address_space_io; + io = get_address_space_io(); ioaddr = phb->config_reg + (addr & 3); switch (size) { case 1: @@ -382,7 +382,7 @@ static void dino_set_irq(void *opaque, int irq, int level) s->ilr = old_ilr | bit; if (ena & s->imr) { uint32_t iar = (ena & s->icr ? s->iar1 : s->iar0); - stl_be_phys(&address_space_memory, iar & -32, iar & 31); + stl_be_phys(get_address_space_memory(), iar & -32, iar & 31); } } else { s->ilr = old_ilr & ~bit; diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c index af8575c007..d495a929b5 100644 --- a/hw/pci-host/pnv_phb3.c +++ b/hw/pci-host/pnv_phb3.c @@ -716,7 +716,7 @@ static bool pnv_phb3_resolve_pe(PnvPhb3DMASpace *ds) bus_num = pci_bus_num(ds->bus); addr = rtt & PHB_RTT_BASE_ADDRESS_MASK; addr += 2 * ((bus_num << 8) | ds->devfn); - if (dma_memory_read(&address_space_memory, addr, &rte, + if (dma_memory_read(get_address_space_memory(), addr, &rte, sizeof(rte), MEMTXATTRS_UNSPECIFIED)) { phb3_error(ds->phb, "Failed to read RTT entry at 0x%"PRIx64, addr); /* Set error bits ? fence ? ... */ @@ -797,7 +797,7 @@ static void pnv_phb3_translate_tve(PnvPhb3DMASpace *ds, hwaddr addr, /* Grab the TCE address */ taddr = base | (((addr >> sh) & ((1ul << tbl_shift) - 1)) << 3); - if (dma_memory_read(&address_space_memory, taddr, &tce, + if (dma_memory_read(get_address_space_memory(), taddr, &tce, sizeof(tce), MEMTXATTRS_UNSPECIFIED)) { phb3_error(phb, "Failed to read TCE at 0x%"PRIx64, taddr); return; @@ -843,7 +843,7 @@ static IOMMUTLBEntry pnv_phb3_translate_iommu(IOMMUMemoryRegion *iommu, int tve_sel; uint64_t tve, cfg; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr, .translated_addr = 0, .addr_mask = ~(hwaddr)0, diff --git a/hw/pci-host/pnv_phb3_msi.c b/hw/pci-host/pnv_phb3_msi.c index 2f4112907b..120009d1dc 100644 --- a/hw/pci-host/pnv_phb3_msi.c +++ b/hw/pci-host/pnv_phb3_msi.c @@ -52,7 +52,7 @@ static bool phb3_msi_read_ive(PnvPHB3 *phb, int srcno, uint64_t *out_ive) return false; } - if (dma_memory_read(&address_space_memory, ive_addr, + if (dma_memory_read(get_address_space_memory(), ive_addr, &ive, sizeof(ive), MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "Failed to read IVE at 0x%" PRIx64, ive_addr); @@ -73,7 +73,7 @@ static void phb3_msi_set_p(Phb3MsiState *msi, int srcno, uint8_t gen) return; } - if (dma_memory_write(&address_space_memory, ive_addr + 4, + if (dma_memory_write(get_address_space_memory(), ive_addr + 4, &p, 1, MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "Failed to write IVE (set P) at 0x%" PRIx64, ive_addr); @@ -90,7 +90,7 @@ static void phb3_msi_set_q(Phb3MsiState *msi, int srcno) return; } - if (dma_memory_write(&address_space_memory, ive_addr + 5, + if (dma_memory_write(get_address_space_memory(), ive_addr + 5, &q, 1, MEMTXATTRS_UNSPECIFIED)) { qemu_log_mask(LOG_GUEST_ERROR, "Failed to write IVE (set Q) at 0x%" PRIx64, ive_addr); diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 824e1a73fb..42959a5b23 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1192,7 +1192,7 @@ static bool pnv_phb4_resolve_pe(PnvPhb4DMASpace *ds) bus_num = pci_bus_num(ds->bus); addr = rtt & PHB_RTT_BASE_ADDRESS_MASK; addr += 2 * PCI_BUILD_BDF(bus_num, ds->devfn); - if (dma_memory_read(&address_space_memory, addr, &rte, + if (dma_memory_read(get_address_space_memory(), addr, &rte, sizeof(rte), MEMTXATTRS_UNSPECIFIED)) { phb_error(ds->phb, "Failed to read RTT entry at 0x%"PRIx64, addr); /* Set error bits ? fence ? ... */ @@ -1264,7 +1264,7 @@ static void pnv_phb4_translate_tve(PnvPhb4DMASpace *ds, hwaddr addr, /* Grab the TCE address */ taddr = base | (((addr >> sh) & ((1ul << tbl_shift) - 1)) << 3); - if (dma_memory_read(&address_space_memory, taddr, &tce, + if (dma_memory_read(get_address_space_memory(), taddr, &tce, sizeof(tce), MEMTXATTRS_UNSPECIFIED)) { phb_error(ds->phb, "Failed to read TCE at 0x%"PRIx64, taddr); return; @@ -1310,7 +1310,7 @@ static IOMMUTLBEntry pnv_phb4_translate_iommu(IOMMUMemoryRegion *iommu, int tve_sel; uint64_t tve, cfg; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr, .translated_addr = 0, .addr_mask = ~(hwaddr)0, @@ -1633,7 +1633,7 @@ static void pnv_phb4_xive_notify_abt(PnvPHB4 *phb, uint32_t srcno, trace_pnv_phb4_xive_notify_ic(addr, data); - address_space_stq_be(&address_space_memory, addr, data, + address_space_stq_be(get_address_space_memory(), addr, data, MEMTXATTRS_UNSPECIFIED, &result); if (result != MEMTX_OK) { phb_error(phb, "trigger failed @%"HWADDR_PRIx "\n", addr); @@ -1655,7 +1655,7 @@ static void pnv_phb4_xive_notify_ic(PnvPHB4 *phb, uint32_t srcno, trace_pnv_phb4_xive_notify_ic(notif_port, data); - address_space_stq_be(&address_space_memory, notif_port, data, + address_space_stq_be(get_address_space_memory(), notif_port, data, MEMTXATTRS_UNSPECIFIED, &result); if (result != MEMTX_OK) { phb_error(phb, "trigger failed @%"HWADDR_PRIx "\n", notif_port); diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 2f450f6a72..8a28d55e7a 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2829,7 +2829,7 @@ AddressSpace *pci_device_iommu_address_space(PCIDevice *dev) if (!pci_bus_bypass_iommu(bus) && iommu_bus && iommu_bus->iommu_fn) { return iommu_bus->iommu_fn(bus, iommu_bus->iommu_opaque, devfn); } - return &address_space_memory; + return get_address_space_memory(); } void pci_setup_iommu(PCIBus *bus, PCIIOMMUFunc fn, void *opaque) diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c index 98045ed3d2..981cb8417d 100644 --- a/hw/ppc/pnv_psi.c +++ b/hw/ppc/pnv_psi.c @@ -662,7 +662,7 @@ static void pnv_psi_notify(XiveNotifier *xf, uint32_t srcno, bool pq_checked) return; } - address_space_stq_be(&address_space_memory, notify_addr, data, + address_space_stq_be(get_address_space_memory(), notify_addr, data, MEMTXATTRS_UNSPECIFIED, &result); if (result != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, "%s: trigger failed @%" diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index fb790b61e4..92598f6cce 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3450,8 +3450,8 @@ void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg) } addr = rtas_addr + RTAS_ERROR_LOG_MAX + cs->cpu_index * sizeof(uint64_t)*2; - stq_be_phys(&address_space_memory, addr, env->gpr[3]); - stq_be_phys(&address_space_memory, addr + sizeof(uint64_t), 0); + stq_be_phys(get_address_space_memory(), addr, env->gpr[3]); + stq_be_phys(get_address_space_memory(), addr + sizeof(uint64_t), 0); env->gpr[3] = addr; } ppc_cpu_do_system_reset(cs); diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 4508e40814..eb9776f123 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -853,7 +853,7 @@ static void spapr_mce_dispatch_elog(SpaprMachineState *spapr, PowerPCCPU *cpu, */ spapr->fwnmi_machine_check_interlock = cpu->vcpu_id; - stq_be_phys(&address_space_memory, rtas_addr + RTAS_ERROR_LOG_OFFSET, + stq_be_phys(get_address_space_memory(), rtas_addr + RTAS_ERROR_LOG_OFFSET, env->gpr[3]); cpu_physical_memory_write(rtas_addr + RTAS_ERROR_LOG_OFFSET + sizeof(env->gpr[3]), &log, sizeof(log)); diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index a8d4a6bcf0..5296225d95 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -1055,8 +1055,8 @@ static uint32_t cas_check_pvr(PowerPCCPU *cpu, uint32_t max_compat, for (i = 0; i < 512; ++i) { uint32_t pvr, pvr_mask; - pvr_mask = ldl_be_phys(&address_space_memory, *addr); - pvr = ldl_be_phys(&address_space_memory, *addr + 4); + pvr_mask = ldl_be_phys(get_address_space_memory(), *addr); + pvr = ldl_be_phys(get_address_space_memory(), *addr + 4); *addr += 8; if (~pvr_mask & pvr) { diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 63e34d457a..7917d81db0 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -118,7 +118,7 @@ static IOMMUTLBEntry spapr_tce_translate_iommu(IOMMUMemoryRegion *iommu, SpaprTceTable *tcet = container_of(iommu, SpaprTceTable, iommu); uint64_t tce; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = 0, .translated_addr = 0, .addr_mask = ~(hwaddr)0, @@ -462,7 +462,7 @@ static target_ulong put_tce_emu(SpaprTceTable *tcet, target_ulong ioba, tcet->table[index] = tce; - event.entry.target_as = &address_space_memory, + event.entry.target_as = get_address_space_memory(), event.entry.iova = (ioba - tcet->bus_offset) & page_mask; event.entry.translated_addr = tce & page_mask; event.entry.addr_mask = ~page_mask; diff --git a/hw/ppc/spapr_ovec.c b/hw/ppc/spapr_ovec.c index b2567caa5c..07cfe3ab6b 100644 --- a/hw/ppc/spapr_ovec.c +++ b/hw/ppc/spapr_ovec.c @@ -163,14 +163,14 @@ static target_ulong vector_addr(target_ulong table_addr, int vector) uint16_t vector_count, vector_len; int i; - vector_count = ldub_phys(&address_space_memory, table_addr) + 1; + vector_count = ldub_phys(get_address_space_memory(), table_addr) + 1; if (vector > vector_count) { return 0; } table_addr++; /* skip nr option vectors */ for (i = 0; i < vector - 1; i++) { - vector_len = ldub_phys(&address_space_memory, table_addr) + 1; + vector_len = ldub_phys(get_address_space_memory(), table_addr) + 1; table_addr += vector_len + 1; /* bit-vector + length byte */ } return table_addr; @@ -192,12 +192,12 @@ SpaprOptionVector *spapr_ovec_parse_vector(target_ulong table_addr, int vector) return NULL; } - vector_len = ldub_phys(&address_space_memory, addr++) + 1; + vector_len = ldub_phys(get_address_space_memory(), addr++) + 1; g_assert(vector_len <= OV_MAXBYTES); ov = spapr_ovec_new(); for (i = 0; i < vector_len; i++) { - uint8_t entry = ldub_phys(&address_space_memory, addr + i); + uint8_t entry = ldub_phys(get_address_space_memory(), addr + i); if (entry) { trace_spapr_ovec_parse_vector(vector, i + 1, vector_len, entry); guest_byte_to_bitmap(entry, ov->bitmap, i * BITS_PER_BYTE); diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index d58b65e88f..17c01adfd4 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -259,7 +259,7 @@ static inline int sysparm_st(target_ulong addr, target_ulong len, if (len < 2) { return RTAS_OUT_SYSPARM_PARAM_ERROR; } - stw_be_phys(&address_space_memory, phys, vallen); + stw_be_phys(get_address_space_memory(), phys, vallen); cpu_physical_memory_write(phys + 2, val, MIN(len - 2, vallen)); return RTAS_OUT_SUCCESS; } diff --git a/hw/remote/iommu.c b/hw/remote/iommu.c index fd723d91f3..d13fe3744f 100644 --- a/hw/remote/iommu.c +++ b/hw/remote/iommu.c @@ -67,7 +67,7 @@ void remote_iommu_unplug_dev(PCIDevice *pci_dev) AddressSpace *as = pci_device_iommu_address_space(pci_dev); RemoteIommuElem *elem = NULL; - if (as == &address_space_memory) { + if (as == get_address_space_memory()) { return; } diff --git a/hw/remote/message.c b/hw/remote/message.c index 50f6bf2d49..792104bb2c 100644 --- a/hw/remote/message.c +++ b/hw/remote/message.c @@ -143,7 +143,7 @@ static void process_bar_write(QIOChannel *ioc, MPQemuMsg *msg, Error **errp) ERRP_GUARD(); BarAccessMsg *bar_access = &msg->data.bar_access; AddressSpace *as = - bar_access->memory ? &address_space_memory : &address_space_io; + bar_access->memory ? get_address_space_memory() : get_address_space_io(); MPQemuMsg ret = { 0 }; MemTxResult res; uint64_t val; @@ -184,7 +184,7 @@ static void process_bar_read(QIOChannel *ioc, MPQemuMsg *msg, Error **errp) MemTxResult res; uint64_t val = 0; - as = bar_access->memory ? &address_space_memory : &address_space_io; + as = bar_access->memory ? get_address_space_memory() : get_address_space_io(); if (!is_power_of_2(bar_access->size) || (bar_access->size > sizeof(uint64_t))) { diff --git a/hw/remote/proxy-memory-listener.c b/hw/remote/proxy-memory-listener.c index eb9918fe72..e357fb9abf 100644 --- a/hw/remote/proxy-memory-listener.c +++ b/hw/remote/proxy-memory-listener.c @@ -222,5 +222,5 @@ void proxy_memory_listener_configure(ProxyMemoryListener *proxy_listener, proxy_listener->listener.name = "proxy"; memory_listener_register(&proxy_listener->listener, - &address_space_memory); + get_address_space_memory()); } diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c index 1ae7596873..381b5251b7 100644 --- a/hw/riscv/boot.c +++ b/hw/riscv/boot.c @@ -240,7 +240,7 @@ uint64_t riscv_load_fdt(hwaddr dram_base, uint64_t mem_size, void *fdt) qemu_fdt_dumpdtb(fdt, fdtsize); rom_add_blob_fixed_as("fdt", fdt, fdtsize, fdt_addr, - &address_space_memory); + get_address_space_memory()); return fdt_addr; } @@ -279,7 +279,7 @@ void riscv_rom_copy_firmware_info(MachineState *machine, hwaddr rom_base, rom_add_blob_fixed_as("mrom.finfo", &dinfo, dinfo_len, rom_base + reset_vec_size, - &address_space_memory); + get_address_space_memory()); } void riscv_setup_rom_reset_vec(MachineState *machine, RISCVHartArrayState *harts, @@ -323,7 +323,7 @@ void riscv_setup_rom_reset_vec(MachineState *machine, RISCVHartArrayState *harts reset_vec[i] = cpu_to_le32(reset_vec[i]); } rom_add_blob_fixed_as("mrom.reset", reset_vec, sizeof(reset_vec), - rom_base, &address_space_memory); + rom_base, get_address_space_memory()); riscv_rom_copy_firmware_info(machine, rom_base, rom_size, sizeof(reset_vec), kernel_entry); } diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index d65d2fd869..085a95725b 100644 --- a/hw/riscv/sifive_e.c +++ b/hw/riscv/sifive_e.c @@ -111,7 +111,7 @@ static void sifive_e_machine_init(MachineState *machine) reset_vec[i] = cpu_to_le32(reset_vec[i]); } rom_add_blob_fixed_as("mrom.reset", reset_vec, sizeof(reset_vec), - memmap[SIFIVE_E_DEV_MROM].base, &address_space_memory); + memmap[SIFIVE_E_DEV_MROM].base, get_address_space_memory()); if (machine->kernel_filename) { riscv_load_kernel(machine->kernel_filename, diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index e4c814a3ea..97109d1781 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -664,7 +664,7 @@ static void sifive_u_machine_init(MachineState *machine) reset_vec[i] = cpu_to_le32(reset_vec[i]); } rom_add_blob_fixed_as("mrom.reset", reset_vec, sizeof(reset_vec), - memmap[SIFIVE_U_DEV_MROM].base, &address_space_memory); + memmap[SIFIVE_U_DEV_MROM].base, get_address_space_memory()); riscv_rom_copy_firmware_info(machine, memmap[SIFIVE_U_DEV_MROM].base, memmap[SIFIVE_U_DEV_MROM].size, diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index befa9d2c26..bca9313a46 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1118,7 +1118,7 @@ static FWCfgState *create_fw_cfg(const MachineState *mc) FWCfgState *fw_cfg; fw_cfg = fw_cfg_init_mem_wide(base + 8, base, 8, base + 16, - &address_space_memory); + get_address_space_memory()); fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)mc->smp.cpus); return fw_cfg; diff --git a/hw/s390x/css.c b/hw/s390x/css.c index 7d9523f811..2b8148c05e 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -830,7 +830,7 @@ static int ccw_dstream_rw_noflags(CcwDataStream *cds, void *buff, int len, goto incr; } if (!cds->do_skip) { - ret = address_space_rw(&address_space_memory, cds->cda, + ret = address_space_rw(get_address_space_memory(), cds->cda, MEMTXATTRS_UNSPECIFIED, buff, len, op); } else { ret = MEMTX_OK; @@ -872,7 +872,7 @@ static inline int ida_read_next_idaw(CcwDataStream *cds) if (idaw_addr & 0x07 || !cds_ccw_addrs_ok(idaw_addr, 0, ccw_fmt1)) { return -EINVAL; /* channel program check */ } - ret = address_space_read(&address_space_memory, idaw_addr, + ret = address_space_read(get_address_space_memory(), idaw_addr, MEMTXATTRS_UNSPECIFIED, &idaw.fmt2, sizeof(idaw.fmt2)); cds->cda = be64_to_cpu(idaw.fmt2); @@ -881,7 +881,7 @@ static inline int ida_read_next_idaw(CcwDataStream *cds) if (idaw_addr & 0x03 || !cds_ccw_addrs_ok(idaw_addr, 0, ccw_fmt1)) { return -EINVAL; /* channel program check */ } - ret = address_space_read(&address_space_memory, idaw_addr, + ret = address_space_read(get_address_space_memory(), idaw_addr, MEMTXATTRS_UNSPECIFIED, &idaw.fmt1, sizeof(idaw.fmt1)); cds->cda = be64_to_cpu(idaw.fmt1); @@ -932,7 +932,7 @@ static int ccw_dstream_rw_ida(CcwDataStream *cds, void *buff, int len, iter_len = MIN(len, cont_left); if (op != CDS_OP_A) { if (!cds->do_skip) { - ret = address_space_rw(&address_space_memory, cds->cda, + ret = address_space_rw(get_address_space_memory(), cds->cda, MEMTXATTRS_UNSPECIFIED, buff, iter_len, op); } else { @@ -1578,12 +1578,12 @@ static void css_update_chnmon(SubchDev *sch) /* Format 1, per-subchannel area. */ uint32_t count; - count = address_space_ldl(&address_space_memory, + count = address_space_ldl(get_address_space_memory(), sch->curr_status.mba, MEMTXATTRS_UNSPECIFIED, NULL); count++; - address_space_stl(&address_space_memory, sch->curr_status.mba, count, + address_space_stl(get_address_space_memory(), sch->curr_status.mba, count, MEMTXATTRS_UNSPECIFIED, NULL); } else { /* Format 0, global area. */ @@ -1591,12 +1591,12 @@ static void css_update_chnmon(SubchDev *sch) uint16_t count; offset = sch->curr_status.pmcw.mbi << 5; - count = address_space_lduw(&address_space_memory, + count = address_space_lduw(get_address_space_memory(), channel_subsys.chnmon_area + offset, MEMTXATTRS_UNSPECIFIED, NULL); count++; - address_space_stw(&address_space_memory, + address_space_stw(get_address_space_memory(), channel_subsys.chnmon_area + offset, count, MEMTXATTRS_UNSPECIFIED, NULL); } diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h index dfc6dfd89c..da3c02d0e4 100644 --- a/hw/s390x/ipl.h +++ b/hw/s390x/ipl.h @@ -251,7 +251,7 @@ static inline bool ipl_valid_pv_header(IplParameterBlock *iplb) return false; } - if (!address_space_access_valid(&address_space_memory, + if (!address_space_access_valid(get_address_space_memory(), ipib_pv->pv_header_addr, ipib_pv->pv_header_len, false, diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 4b2bdd94b3..a6174b9659 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -447,7 +447,7 @@ static uint64_t table_translate(S390IOTLBEntry *entry, uint64_t to, int8_t ett, uint16_t err = 0; tx = get_table_index(entry->iova, ett); - te = address_space_ldq(&address_space_memory, to + tx * sizeof(uint64_t), + te = address_space_ldq(get_address_space_memory(), to + tx * sizeof(uint64_t), MEMTXATTRS_UNSPECIFIED, NULL); if (!te) { @@ -529,7 +529,7 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr, uint64_t iova = addr & TARGET_PAGE_MASK; uint16_t error = 0; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = 0, .translated_addr = 0, .addr_mask = ~(hwaddr)0, diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index 6d400d4147..3e6951d27e 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-inst.c @@ -610,7 +610,7 @@ static uint32_t s390_pci_update_iotlb(S390PCIIOMMU *iommu, IOMMUTLBEvent event = { .type = entry->perm ? IOMMU_NOTIFIER_MAP : IOMMU_NOTIFIER_UNMAP, .entry = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = entry->iova, .translated_addr = entry->translated_addr, .perm = entry->perm, @@ -976,22 +976,22 @@ static int fmb_do_update(S390PCIBusDevice *pbdev, int offset, uint64_t val, switch (len) { case 8: - address_space_stq_be(&address_space_memory, dst, val, + address_space_stq_be(get_address_space_memory(), dst, val, MEMTXATTRS_UNSPECIFIED, &ret); break; case 4: - address_space_stl_be(&address_space_memory, dst, val, + address_space_stl_be(get_address_space_memory(), dst, val, MEMTXATTRS_UNSPECIFIED, &ret); break; case 2: - address_space_stw_be(&address_space_memory, dst, val, + address_space_stw_be(get_address_space_memory(), dst, val, MEMTXATTRS_UNSPECIFIED, &ret); break; case 1: - address_space_stb(&address_space_memory, dst, val, + address_space_stb(get_address_space_memory(), dst, val, MEMTXATTRS_UNSPECIFIED, &ret); break; diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c index 5024faf411..aed7759f1a 100644 --- a/hw/s390x/s390-skeys.c +++ b/hw/s390x/s390-skeys.c @@ -87,7 +87,7 @@ void hmp_info_skeys(Monitor *mon, const QDict *qdict) return; } - if (!address_space_access_valid(&address_space_memory, + if (!address_space_access_valid(get_address_space_memory(), addr & TARGET_PAGE_MASK, TARGET_PAGE_SIZE, false, MEMTXATTRS_UNSPECIFIED)) { monitor_printf(mon, "Error: The given address is not valid\n"); diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index e33e5207ab..502b87bb13 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -506,7 +506,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) if (!ccw.cda) { ret = -EFAULT; } else { - address_space_stb(&address_space_memory, ccw.cda, vdev->status, + address_space_stb(get_address_space_memory(), ccw.cda, vdev->status, MEMTXATTRS_UNSPECIFIED, NULL); sch->curr_status.scsw.count = ccw.count - sizeof(vdev->status); ret = 0; @@ -893,12 +893,12 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t vector) } } else { assert(vector < NR_CLASSIC_INDICATOR_BITS); - indicators = address_space_ldq(&address_space_memory, + indicators = address_space_ldq(get_address_space_memory(), dev->indicators->addr, MEMTXATTRS_UNSPECIFIED, NULL); indicators |= 1ULL << vector; - address_space_stq(&address_space_memory, dev->indicators->addr, + address_space_stq(get_address_space_memory(), dev->indicators->addr, indicators, MEMTXATTRS_UNSPECIFIED, NULL); css_conditional_io_interrupt(sch); } @@ -906,12 +906,12 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t vector) if (!dev->indicators2) { return; } - indicators = address_space_ldq(&address_space_memory, + indicators = address_space_ldq(get_address_space_memory(), dev->indicators2->addr, MEMTXATTRS_UNSPECIFIED, NULL); indicators |= 1ULL; - address_space_stq(&address_space_memory, dev->indicators2->addr, + address_space_stq(get_address_space_memory(), dev->indicators2->addr, indicators, MEMTXATTRS_UNSPECIFIED, NULL); css_conditional_io_interrupt(sch); } diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 0e5e988927..cfcb59246b 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1519,7 +1519,7 @@ static void sdhci_sysbus_realize(DeviceState *dev, Error **errp) address_space_init(s->dma_as, s->dma_mr, "sdhci-dma"); } else { /* use system_memory() if property "dma" not set */ - s->dma_as = &address_space_memory; + s->dma_as = get_address_space_memory(); } sysbus_init_irq(sbd, &s->irq); diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c index 39fc4f19d9..6ff1357493 100644 --- a/hw/sh4/r2d.c +++ b/hw/sh4/r2d.c @@ -330,9 +330,9 @@ static void r2d_init(MachineState *machine) } /* initialization which should be done by firmware */ - address_space_stl(&address_space_memory, SH7750_BCR1, 1 << 3, + address_space_stl(get_address_space_memory(), SH7750_BCR1, 1 << 3, MEMTXATTRS_UNSPECIFIED, NULL); /* cs3 SDRAM */ - address_space_stw(&address_space_memory, SH7750_BCR2, 3 << (3 * 2), + address_space_stw(get_address_space_memory(), SH7750_BCR2, 3 << (3 * 2), MEMTXATTRS_UNSPECIFIED, NULL); /* cs3 32bit */ /* Start from P2 area */ reset_info->vector = (SDRAM_BASE + LINUX_LOAD_OFFSET) | 0xa0000000; diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index d9288326d6..d3e315884d 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -560,7 +560,7 @@ static void idreg_init(hwaddr addr) sysbus_realize_and_unref(s, &error_fatal); sysbus_mmio_map(s, 0, addr); - address_space_write_rom(&address_space_memory, addr, + address_space_write_rom(get_address_space_memory(), addr, MEMTXATTRS_UNSPECIFIED, idreg_data, sizeof(idreg_data)); } diff --git a/hw/sparc/sun4m_iommu.c b/hw/sparc/sun4m_iommu.c index 71f5465249..9783942172 100644 --- a/hw/sparc/sun4m_iommu.c +++ b/hw/sparc/sun4m_iommu.c @@ -254,7 +254,7 @@ static uint32_t iommu_page_get_flags(IOMMUState *s, hwaddr addr) iopte = s->regs[IOMMU_BASE] << 4; addr &= ~s->iostart; iopte += (addr >> (IOMMU_PAGE_SHIFT - 2)) & ~3; - ret = address_space_ldl_be(&address_space_memory, iopte, + ret = address_space_ldl_be(get_address_space_memory(), iopte, MEMTXATTRS_UNSPECIFIED, NULL); trace_sun4m_iommu_page_get_flags(pa, iopte, ret); return ret; @@ -294,7 +294,7 @@ static IOMMUTLBEntry sun4m_translate_iommu(IOMMUMemoryRegion *iommu, int is_write = (flags & IOMMU_WO) ? 1 : 0; uint32_t pte; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = 0, .translated_addr = 0, .addr_mask = ~(hwaddr)0, diff --git a/hw/sparc64/sun4u_iommu.c b/hw/sparc64/sun4u_iommu.c index 1c1dca712e..1059d8a3c8 100644 --- a/hw/sparc64/sun4u_iommu.c +++ b/hw/sparc64/sun4u_iommu.c @@ -81,7 +81,7 @@ static IOMMUTLBEntry sun4u_translate_iommu(IOMMUMemoryRegion *iommu, uint64_t tte; uint32_t tsbsize; IOMMUTLBEntry ret = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = 0, .translated_addr = 0, .addr_mask = ~(hwaddr)0, @@ -156,7 +156,7 @@ static IOMMUTLBEntry sun4u_translate_iommu(IOMMUMemoryRegion *iommu, } } - tte = address_space_ldq_be(&address_space_memory, baseaddr + offset, + tte = address_space_ldq_be(get_address_space_memory(), baseaddr + offset, MEMTXATTRS_UNSPECIFIED, NULL); if (!(tte & IOMMU_TTE_DATA_V)) { diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 9520471be2..7e67432cb7 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -208,7 +208,7 @@ static void update_irq(struct HPETTimer *timer, int set) qemu_irq_lower(s->irqs[route]); } } else if (timer_fsb_route(timer)) { - address_space_stl_le(&address_space_memory, timer->fsb >> 32, + address_space_stl_le(get_address_space_memory(), timer->fsb >> 32, timer->fsb & 0xffffffff, MEMTXATTRS_UNSPECIFIED, NULL); } else if (timer->config & HPET_TN_TYPE_LEVEL) { diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 4c37c8e227..f73a7b56df 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @@ -132,7 +132,7 @@ static void usb_ehci_pci_write_config(PCIDevice *dev, uint32_t addr, return; } busmaster = pci_get_word(dev->config + PCI_COMMAND) & PCI_COMMAND_MASTER; - i->ehci.as = busmaster ? pci_get_address_space(dev) : &address_space_memory; + i->ehci.as = busmaster ? pci_get_address_space(dev) : get_address_space_memory(); } static Property ehci_pci_properties[] = { diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c index a12e218848..b44ad07d52 100644 --- a/hw/usb/hcd-ehci-sysbus.c +++ b/hw/usb/hcd-ehci-sysbus.c @@ -68,7 +68,7 @@ static void ehci_sysbus_init(Object *obj) s->opregbase = sec->opregbase; s->portscbase = sec->portscbase; s->portnr = sec->portnr; - s->as = &address_space_memory; + s->as = get_address_space_memory(); usb_ehci_init(s, DEVICE(obj)); sysbus_init_mmio(d, &s->mem); diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 895b29fb86..b6db6b2e5a 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -1901,7 +1901,7 @@ static void ohci_realize_pxa(DeviceState *dev, Error **errp) usb_ohci_init(&s->ohci, dev, s->num_ports, s->dma_offset, s->masterbus, s->firstport, - &address_space_memory, ohci_sysbus_die, &err); + get_address_space_memory(), ohci_sysbus_die, &err); if (err) { error_propagate(errp, err); return; diff --git a/hw/usb/hcd-xhci-sysbus.c b/hw/usb/hcd-xhci-sysbus.c index a14e438196..1ca6f00bd4 100644 --- a/hw/usb/hcd-xhci-sysbus.c +++ b/hw/usb/hcd-xhci-sysbus.c @@ -47,7 +47,7 @@ static void xhci_sysbus_realize(DeviceState *dev, Error **errp) s->xhci.as = g_malloc0(sizeof(AddressSpace)); address_space_init(s->xhci.as, s->xhci.dma_mr, NULL); } else { - s->xhci.as = &address_space_memory; + s->xhci.as = get_address_space_memory(); } sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->xhci.mem); diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index e0dd561e85..f22e81bde3 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -81,7 +81,7 @@ static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, Error **errp) g_free(group_path); - return vfio_get_group(groupid, &address_space_memory, errp); + return vfio_get_group(groupid, get_address_space_memory(), errp); } static void vfio_ap_realize(DeviceState *dev, Error **errp) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 0354737666..da147fe507 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -650,7 +650,7 @@ static VFIOGroup *vfio_ccw_get_group(S390CCWDevice *cdev, Error **errp) return NULL; } - return vfio_get_group(groupid, &address_space_memory, errp); + return vfio_get_group(groupid, get_address_space_memory(), errp); } static void vfio_ccw_realize(DeviceState *dev, Error **errp) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index ace9562a9b..860d8220a7 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -588,7 +588,7 @@ static bool vfio_get_xlat_addr(IOMMUTLBEntry *iotlb, void **vaddr, * this IOMMU to its immediate target. We need to translate * it the rest of the way through to memory. */ - mr = address_space_translate(&address_space_memory, + mr = address_space_translate(get_address_space_memory(), iotlb->translated_addr, &xlat, &len, writable, MEMTXATTRS_UNSPECIFIED); @@ -671,7 +671,7 @@ static void vfio_iommu_map_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb) trace_vfio_iommu_map_notify(iotlb->perm == IOMMU_NONE ? "UNMAP" : "MAP", iova, iova + iotlb->addr_mask); - if (iotlb->target_as != &address_space_memory) { + if (iotlb->target_as != get_address_space_memory()) { error_report("Wrong target AS \"%s\", only system memory is allowed", iotlb->target_as->name ? iotlb->target_as->name : "none"); return; @@ -1352,7 +1352,7 @@ static void vfio_iommu_map_dirty_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb) trace_vfio_iommu_map_dirty_notify(iova, iova + iotlb->addr_mask); - if (iotlb->target_as != &address_space_memory) { + if (iotlb->target_as != get_address_space_memory()) { error_report("Wrong target AS \"%s\", only system memory is allowed", iotlb->target_as->name ? iotlb->target_as->name : "none"); return; @@ -2158,7 +2158,7 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as, container->prereg_listener = vfio_prereg_listener; memory_listener_register(&container->prereg_listener, - &address_space_memory); + get_address_space_memory()); if (container->error) { memory_listener_unregister(&container->prereg_listener); ret = -1; diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index 5af73f9287..7137e5c7f3 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -577,7 +577,7 @@ static int vfio_base_device_init(VFIODevice *vbasedev, Error **errp) trace_vfio_platform_base_device_init(vbasedev->name, groupid); - group = vfio_get_group(groupid, &address_space_memory, errp); + group = vfio_get_group(groupid, get_address_space_memory(), errp); if (!group) { return -ENOENT; } diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 7468e44b87..269ccab876 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -1115,7 +1115,7 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started) } if (started) { - memory_listener_register(&v->listener, &address_space_memory); + memory_listener_register(&v->listener, get_address_space_memory()); return vhost_vdpa_add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK); } else { vhost_vdpa_reset_device(dev); diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index f758f177bb..57cbe08a6c 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1449,7 +1449,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque, hdev->log_size = 0; hdev->log_enabled = false; hdev->started = false; - memory_listener_register(&hdev->memory_listener, &address_space_memory); + memory_listener_register(&hdev->memory_listener, get_address_space_memory()); QLIST_INSERT_HEAD(&vhost_devices, hdev, entry); if (used_memslots > hdev->vhost_ops->vhost_backend_memslots_limit(hdev)) { diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c index 896feb37a1..8cac66b85a 100644 --- a/hw/virtio/virtio-bus.c +++ b/hw/virtio/virtio-bus.c @@ -78,7 +78,7 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, Error **errp) return; } - vdev->dma_as = &address_space_memory; + vdev->dma_as = get_address_space_memory(); if (has_iommu) { vdev_has_iommu = virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM); /* @@ -89,7 +89,7 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, Error **errp) virtio_add_feature(&vdev->host_features, VIRTIO_F_IOMMU_PLATFORM); if (klass->get_dma_as) { vdev->dma_as = klass->get_dma_as(qbus->parent); - if (!vdev_has_iommu && vdev->dma_as != &address_space_memory) { + if (!vdev_has_iommu && vdev->dma_as != get_address_space_memory()) { error_setg(errp, "iommu_platform=true is not supported by the device"); return; diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 62e07ec2e4..e93323c584 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -240,7 +240,7 @@ static void virtio_iommu_notify_map(IOMMUMemoryRegion *mr, hwaddr virt_start, paddr, perm); event.type = IOMMU_NOTIFIER_MAP; - event.entry.target_as = &address_space_memory; + event.entry.target_as = get_address_space_memory(); event.entry.perm = perm; event.entry.translated_addr = paddr; @@ -259,7 +259,7 @@ static void virtio_iommu_notify_unmap(IOMMUMemoryRegion *mr, hwaddr virt_start, trace_virtio_iommu_notify_unmap(mr->parent_obj.name, virt_start, virt_end); event.type = IOMMU_NOTIFIER_UNMAP; - event.entry.target_as = &address_space_memory; + event.entry.target_as = get_address_space_memory(); event.entry.perm = IOMMU_NONE; event.entry.translated_addr = 0; @@ -859,7 +859,7 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, interval.high = addr + 1; IOMMUTLBEntry entry = { - .target_as = &address_space_memory, + .target_as = get_address_space_memory(), .iova = addr, .translated_addr = addr, .addr_mask = (1 << ctz32(s->config.page_size_mask)) - 1, diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index a50c5a57d7..dc2165eb59 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1134,7 +1134,7 @@ static bool virtio_pci_iommu_enabled(DeviceState *d) PCIDevice *dev = &proxy->pci_dev; AddressSpace *dma_as = pci_device_iommu_address_space(dev); - if (dma_as == &address_space_memory) { + if (dma_as == get_address_space_memory()) { return false; } diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..d3dfd1e818 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -913,8 +913,8 @@ out: } } - memory_listener_register(&s->memory_listener, &address_space_memory); - memory_listener_register(&s->io_listener, &address_space_io); + memory_listener_register(&s->memory_listener, get_address_space_memory()); + memory_listener_register(&s->io_listener, get_address_space_io()); s->listener_set = true; XEN_PT_LOG(d, "Real physical device %02x:%02x.%d registered successfully\n", diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h index db8bfa9a92..d5c8cbd718 100644 --- a/include/exec/address-spaces.h +++ b/include/exec/address-spaces.h @@ -33,8 +33,8 @@ MemoryRegion *get_system_memory(void); */ MemoryRegion *get_system_io(void); -extern AddressSpace address_space_memory; -extern AddressSpace address_space_io; +AddressSpace *get_address_space_memory(void); +AddressSpace *get_address_space_io(void); #endif diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 7c3b1d0f6c..f4a6469d39 100644 --- a/include/hw/elf_ops.h +++ b/include/hw/elf_ops.h @@ -549,7 +549,7 @@ static ssize_t glue(load_elf, SZ)(const char *name, int fd, } else { MemTxResult res; - res = address_space_write(as ? as : &address_space_memory, + res = address_space_write(as ? as : get_address_space_memory(), addr, MEMTXATTRS_UNSPECIFIED, data, file_size); if (res != MEMTX_OK) { @@ -560,7 +560,7 @@ static ssize_t glue(load_elf, SZ)(const char *name, int fd, * from file */ if (file_size < mem_size) { - res = address_space_set(as ? as : &address_space_memory, + res = address_space_set(as ? as : get_address_space_memory(), addr + file_size, 0, mem_size - file_size, MEMTXATTRS_UNSPECIFIED); diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index 04a95669ab..24e2692a4d 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -848,7 +848,7 @@ static inline uint64_t ppc64_phys_to_real(uint64_t addr) static inline uint32_t rtas_ld(target_ulong phys, int n) { - return ldl_be_phys(&address_space_memory, + return ldl_be_phys(get_address_space_memory(), ppc64_phys_to_real(phys + 4 * n)); } @@ -859,7 +859,8 @@ static inline uint64_t rtas_ldq(target_ulong phys, int n) static inline void rtas_st(target_ulong phys, int n, uint32_t val) { - stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), val); + stl_be_phys(get_address_space_memory(), ppc64_phys_to_real(phys + 4 * n), + val); } typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, SpaprMachineState *sm, diff --git a/include/hw/ppc/vof.h b/include/hw/ppc/vof.h index f8c0effcaf..c65a88413b 100644 --- a/include/hw/ppc/vof.h +++ b/include/hw/ppc/vof.h @@ -54,10 +54,10 @@ struct VofMachineIfClass { #define VOF_STACK_SIZE 0x8000 #define VOF_MEM_READ(pa, buf, size) \ - address_space_read(&address_space_memory, \ + address_space_read(get_address_space_memory(), \ (pa), MEMTXATTRS_UNSPECIFIED, (buf), (size)) #define VOF_MEM_WRITE(pa, buf, size) \ - address_space_write(&address_space_memory, \ + address_space_write(get_address_space_memory(), \ (pa), MEMTXATTRS_UNSPECIFIED, (buf), (size)) #define PROM_ERROR (~0U) diff --git a/monitor/misc.c b/monitor/misc.c index 6436a8786b..4f79e59fc0 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -579,7 +579,7 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, if (l > line_size) l = line_size; if (is_physical) { - AddressSpace *as = cs ? cs->as : &address_space_memory; + AddressSpace *as = cs ? cs->as : get_address_space_memory(); MemTxResult r = address_space_read(as, addr, MEMTXATTRS_UNSPECIFIED, buf, l); if (r != MEMTX_OK) { @@ -821,7 +821,7 @@ static void hmp_sum(Monitor *mon, const QDict *qdict) sum = 0; for(addr = start; addr < (start + size); addr++) { - uint8_t val = address_space_ldub(&address_space_memory, addr, + uint8_t val = address_space_ldub(get_address_space_memory(), addr, MEMTXATTRS_UNSPECIFIED, NULL); /* BSD sum algorithm ('sum' Unix command) */ sum = (sum >> 1) | (sum << 15); diff --git a/softmmu/ioport.c b/softmmu/ioport.c index cb8adb0b93..f47ca28214 100644 --- a/softmmu/ioport.c +++ b/softmmu/ioport.c @@ -57,7 +57,7 @@ const MemoryRegionOps unassigned_io_ops = { void cpu_outb(uint32_t addr, uint8_t val) { trace_cpu_out(addr, 'b', val); - address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + address_space_write(get_address_space_io(), addr, MEMTXATTRS_UNSPECIFIED, &val, 1); } @@ -67,7 +67,7 @@ void cpu_outw(uint32_t addr, uint16_t val) trace_cpu_out(addr, 'w', val); stw_p(buf, val); - address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + address_space_write(get_address_space_io(), addr, MEMTXATTRS_UNSPECIFIED, buf, 2); } @@ -77,7 +77,7 @@ void cpu_outl(uint32_t addr, uint32_t val) trace_cpu_out(addr, 'l', val); stl_p(buf, val); - address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + address_space_write(get_address_space_io(), addr, MEMTXATTRS_UNSPECIFIED, buf, 4); } @@ -85,7 +85,7 @@ uint8_t cpu_inb(uint32_t addr) { uint8_t val; - address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + address_space_read(get_address_space_io(), addr, MEMTXATTRS_UNSPECIFIED, &val, 1); trace_cpu_in(addr, 'b', val); return val; @@ -96,7 +96,7 @@ uint16_t cpu_inw(uint32_t addr) uint8_t buf[2]; uint16_t val; - address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, buf, 2); + address_space_read(get_address_space_io(), addr, MEMTXATTRS_UNSPECIFIED, buf, 2); val = lduw_p(buf); trace_cpu_in(addr, 'w', val); return val; @@ -107,7 +107,7 @@ uint32_t cpu_inl(uint32_t addr) uint8_t buf[4]; uint32_t val; - address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, buf, 4); + address_space_read(get_address_space_io(), addr, MEMTXATTRS_UNSPECIFIED, buf, 4); val = ldl_p(buf); trace_cpu_in(addr, 'l', val); return val; diff --git a/softmmu/memory_mapping.c b/softmmu/memory_mapping.c index f6f0a829fd..9a74e4415e 100644 --- a/softmmu/memory_mapping.c +++ b/softmmu/memory_mapping.c @@ -287,7 +287,7 @@ void guest_phys_blocks_append(GuestPhysBlockList *list) g.list = list; g.listener.region_add = &guest_phys_blocks_region_add; - memory_listener_register(&g.listener, &address_space_memory); + memory_listener_register(&g.listener, get_address_space_memory()); memory_listener_unregister(&g.listener); } diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 56e03e07b5..0ac920d446 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -89,8 +89,8 @@ RAMList ram_list = { .blocks = QLIST_HEAD_INITIALIZER(ram_list.blocks) }; static MemoryRegion *system_memory; static MemoryRegion *system_io; -AddressSpace address_space_io; -AddressSpace address_space_memory; +static AddressSpace address_space_io; +static AddressSpace address_space_memory; static MemoryRegion io_mem_unassigned; @@ -2690,6 +2690,16 @@ MemoryRegion *get_system_io(void) return system_io; } +AddressSpace *get_address_space_memory(void) +{ + return &address_space_memory; +} + +AddressSpace *get_address_space_io(void) +{ + return &address_space_io; +} + static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, hwaddr length) { @@ -3319,7 +3329,8 @@ void *cpu_physical_memory_map(hwaddr addr, void cpu_physical_memory_unmap(void *buffer, hwaddr len, bool is_write, hwaddr access_len) { - return address_space_unmap(&address_space_memory, buffer, len, is_write, access_len); + return address_space_unmap(&address_space_memory, buffer, len, + is_write, access_len); } #define ARG1_DECL AddressSpace *as diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 060aa0ccf4..10401c7dc5 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1231,11 +1231,11 @@ int hvf_vcpu_exec(CPUState *cpu) if (iswrite) { val = hvf_get_reg(cpu, srt); - address_space_write(&address_space_memory, + address_space_write(get_address_space_memory(), hvf_exit->exception.physical_address, MEMTXATTRS_UNSPECIFIED, &val, len); } else { - address_space_read(&address_space_memory, + address_space_read(get_address_space_memory(), hvf_exit->exception.physical_address, MEMTXATTRS_UNSPECIFIED, &val, len); hvf_set_reg(cpu, srt, val); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index e5c1bd50d2..c7d4ad7efc 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -393,7 +393,7 @@ void kvm_arm_register_device(MemoryRegion *mr, uint64_t devid, uint64_t group, } if (QSLIST_EMPTY(&kvm_devices_head)) { - memory_listener_register(&devlistener, &address_space_memory); + memory_listener_register(&devlistener, get_address_space_memory()); qemu_add_machine_init_done_notifier(¬ify); } kd = g_new0(KVMDevice, 1); @@ -1004,7 +1004,7 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route, MemoryRegionSection mrs; MemoryRegion *mr; - if (as == &address_space_memory) { + if (as == get_address_space_memory()) { return 0; } diff --git a/target/avr/helper.c b/target/avr/helper.c index 156dde4e92..c43e2e78eb 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -244,7 +244,7 @@ target_ulong helper_inb(CPUAVRState *env, uint32_t port) break; default: /* not a special register, pass to normal memory access */ - data = address_space_ldub(&address_space_memory, + data = address_space_ldub(get_address_space_memory(), OFFSET_IO_REGISTERS + port, MEMTXATTRS_UNSPECIFIED, NULL); } @@ -303,7 +303,7 @@ void helper_outb(CPUAVRState *env, uint32_t port, uint32_t data) break; default: /* not a special register, pass to normal memory access */ - address_space_stb(&address_space_memory, OFFSET_IO_REGISTERS + port, + address_space_stb(get_address_space_memory(), OFFSET_IO_REGISTERS + port, data, MEMTXATTRS_UNSPECIFIED, NULL); } } @@ -326,7 +326,7 @@ target_ulong helper_fullrd(CPUAVRState *env, uint32_t addr) data = helper_inb(env, addr - NUMBER_OF_CPU_REGISTERS); } else { /* memory */ - data = address_space_ldub(&address_space_memory, OFFSET_DATA + addr, + data = address_space_ldub(get_address_space_memory(), OFFSET_DATA + addr, MEMTXATTRS_UNSPECIFIED, NULL); } return data; @@ -353,7 +353,7 @@ void helper_fullwr(CPUAVRState *env, uint32_t data, uint32_t addr) helper_outb(env, addr - NUMBER_OF_CPU_REGISTERS, data); } else { /* memory */ - address_space_stb(&address_space_memory, OFFSET_DATA + addr, data, + address_space_stb(get_address_space_memory(), OFFSET_DATA + addr, data, MEMTXATTRS_UNSPECIFIED, NULL); } } diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index b185ee8de4..07a8d242e9 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -393,7 +393,7 @@ static int hax_handle_io(CPUArchState *env, uint32_t df, uint16_t port, ptr = buffer + size * count - size; } for (i = 0; i < count; i++) { - address_space_rw(&address_space_io, port, attrs, + address_space_rw(get_address_space_io(), port, attrs, ptr, size, direction == HAX_EXIT_IO_OUT); if (!df) { ptr += size; diff --git a/target/i386/hax/hax-mem.c b/target/i386/hax/hax-mem.c index 05dbe8cce3..e5a1b14a76 100644 --- a/target/i386/hax/hax-mem.c +++ b/target/i386/hax/hax-mem.c @@ -319,5 +319,5 @@ static struct RAMBlockNotifier hax_ram_notifier = { void hax_memory_init(void) { ram_block_notifier_add(&hax_ram_notifier); - memory_listener_register(&hax_memory_listener, &address_space_memory); + memory_listener_register(&hax_memory_listener, get_address_space_memory()); } diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 8d2248bb3f..ba7749cc34 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -106,7 +106,7 @@ void hvf_handle_io(CPUArchState *env, uint16_t port, void *buffer, uint8_t *ptr = buffer; for (i = 0; i < count; i++) { - address_space_rw(&address_space_io, port, MEMTXATTRS_UNSPECIFIED, + address_space_rw(get_address_space_io(), port, MEMTXATTRS_UNSPECIFIED, ptr, size, direction); ptr += size; diff --git a/target/i386/hvf/vmx.h b/target/i386/hvf/vmx.h index fcd9a95e5b..4781ec4b04 100644 --- a/target/i386/hvf/vmx.h +++ b/target/i386/hvf/vmx.h @@ -130,7 +130,7 @@ static inline void macvm_set_cr0(hv_vcpuid_t vcpu, uint64_t cr0) if ((cr0 & CR0_PG_MASK) && (rvmcs(vcpu, VMCS_GUEST_CR4) & CR4_PAE_MASK) && !(efer & MSR_EFER_LME)) { - address_space_read(&address_space_memory, + address_space_read(get_address_space_memory(), rvmcs(vcpu, VMCS_GUEST_CR3) & ~0x1f, MEMTXATTRS_UNSPECIFIED, pdpte, 32); /* Only set PDPTE when appropriate. */ diff --git a/target/i386/hvf/x86_mmu.c b/target/i386/hvf/x86_mmu.c index 96d117567e..52ea629fcd 100644 --- a/target/i386/hvf/x86_mmu.c +++ b/target/i386/hvf/x86_mmu.c @@ -86,7 +86,7 @@ static bool get_pt_entry(struct CPUState *cpu, struct gpt_translation *pt, } index = gpt_entry(pt->gva, level, pae); - address_space_read(&address_space_memory, gpa + index * pte_size(pae), + address_space_read(get_address_space_memory(), gpa + index * pte_size(pae), MEMTXATTRS_UNSPECIFIED, &pte, pte_size(pae)); pt->pte[level - 1] = pte; @@ -236,7 +236,7 @@ void vmx_write_mem(struct CPUState *cpu, target_ulong gva, void *data, int bytes if (!mmu_gva_to_gpa(cpu, gva, &gpa)) { VM_PANIC_EX("%s: mmu_gva_to_gpa %llx failed\n", __func__, gva); } else { - address_space_write(&address_space_memory, gpa, + address_space_write(get_address_space_memory(), gpa, MEMTXATTRS_UNSPECIFIED, data, copy); } @@ -257,7 +257,7 @@ void vmx_read_mem(struct CPUState *cpu, void *data, target_ulong gva, int bytes) if (!mmu_gva_to_gpa(cpu, gva, &gpa)) { VM_PANIC_EX("%s: mmu_gva_to_gpa %llx failed\n", __func__, gva); } - address_space_read(&address_space_memory, gpa, MEMTXATTRS_UNSPECIFIED, + address_space_read(get_address_space_memory(), gpa, MEMTXATTRS_UNSPECIFIED, data, copy); bytes -= copy; diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index b75738ee9c..faecbd634c 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -505,7 +505,7 @@ nvmm_io_callback(struct nvmm_io *io) MemTxAttrs attrs = { 0 }; int ret; - ret = address_space_rw(&address_space_io, io->port, attrs, io->data, + ret = address_space_rw(get_address_space_io(), io->port, attrs, io->data, io->size, !io->in); if (ret != MEMTX_OK) { error_report("NVMM: I/O Transaction Failed " @@ -1198,7 +1198,7 @@ nvmm_accel_init(MachineState *ms) return -err; } - memory_listener_register(&nvmm_memory_listener, &address_space_memory); + memory_listener_register(&nvmm_memory_listener, get_address_space_memory()); ram_block_notifier_add(&nvmm_ram_notifier); printf("NetBSD Virtual Machine Monitor accelerator is operational\n"); diff --git a/target/i386/sev.c b/target/i386/sev.c index 32f7dbac4e..c9b5b2fbb9 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -1336,7 +1336,7 @@ bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp) * Populate the hashes table in the guest's memory at the OVMF-designated * area for the SEV hashes table */ - padded_ht = address_space_map(&address_space_memory, area->base, + padded_ht = address_space_map(get_address_space_memory(), area->base, &mapped_len, true, attrs); if (!padded_ht || mapped_len != sizeof(*padded_ht)) { error_setg(errp, "SEV: cannot map hashes table guest memory area"); @@ -1366,7 +1366,7 @@ bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp) ret = false; } - address_space_unmap(&address_space_memory, padded_ht, + address_space_unmap(get_address_space_memory(), padded_ht, mapped_len, true, mapped_len); return ret; diff --git a/target/i386/tcg/sysemu/misc_helper.c b/target/i386/tcg/sysemu/misc_helper.c index 1328aa656f..d5f5ca7321 100644 --- a/target/i386/tcg/sysemu/misc_helper.c +++ b/target/i386/tcg/sysemu/misc_helper.c @@ -28,37 +28,37 @@ void helper_outb(CPUX86State *env, uint32_t port, uint32_t data) { - address_space_stb(&address_space_io, port, data, + address_space_stb(get_address_space_io(), port, data, cpu_get_mem_attrs(env), NULL); } target_ulong helper_inb(CPUX86State *env, uint32_t port) { - return address_space_ldub(&address_space_io, port, + return address_space_ldub(get_address_space_io(), port, cpu_get_mem_attrs(env), NULL); } void helper_outw(CPUX86State *env, uint32_t port, uint32_t data) { - address_space_stw(&address_space_io, port, data, + address_space_stw(get_address_space_io(), port, data, cpu_get_mem_attrs(env), NULL); } target_ulong helper_inw(CPUX86State *env, uint32_t port) { - return address_space_lduw(&address_space_io, port, + return address_space_lduw(get_address_space_io(), port, cpu_get_mem_attrs(env), NULL); } void helper_outl(CPUX86State *env, uint32_t port, uint32_t data) { - address_space_stl(&address_space_io, port, data, + address_space_stl(get_address_space_io(), port, data, cpu_get_mem_attrs(env), NULL); } target_ulong helper_inl(CPUX86State *env, uint32_t port) { - return address_space_ldl(&address_space_io, port, + return address_space_ldl(get_address_space_io(), port, cpu_get_mem_attrs(env), NULL); } diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index b22a3314b4..3a08a96136 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -792,7 +792,7 @@ static HRESULT CALLBACK whpx_emu_ioport_callback( WHV_EMULATOR_IO_ACCESS_INFO *IoAccess) { MemTxAttrs attrs = { 0 }; - address_space_rw(&address_space_io, IoAccess->Port, attrs, + address_space_rw(get_address_space_io(), IoAccess->Port, attrs, &IoAccess->Data, IoAccess->AccessSize, IoAccess->Direction); return S_OK; @@ -2435,7 +2435,7 @@ static MemoryListener whpx_memory_listener = { static void whpx_memory_init(void) { - memory_listener_register(&whpx_memory_listener, &address_space_memory); + memory_listener_register(&whpx_memory_listener, get_address_space_memory()); } /* diff --git a/target/s390x/diag.c b/target/s390x/diag.c index 76b01dcd68..110ed26609 100644 --- a/target/s390x/diag.c +++ b/target/s390x/diag.c @@ -62,7 +62,7 @@ static int diag308_parm_check(CPUS390XState *env, uint64_t r1, uint64_t addr, s390_program_interrupt(env, PGM_SPECIFICATION, ra); return -1; } - if (!address_space_access_valid(&address_space_memory, addr, + if (!address_space_access_valid(get_address_space_memory(), addr, sizeof(IplParameterBlock), write, MEMTXATTRS_UNSPECIFIED)) { s390_program_interrupt(env, PGM_ADDRESSING, ra); diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index b04b57c235..1ff04c140e 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -96,7 +96,7 @@ target_ulong mmu_real2abs(CPUS390XState *env, target_ulong raddr) bool mmu_absolute_addr_valid(target_ulong addr, bool is_write) { - return address_space_access_valid(&address_space_memory, + return address_space_access_valid(get_address_space_memory(), addr & TARGET_PAGE_MASK, TARGET_PAGE_SIZE, is_write, MEMTXATTRS_UNSPECIFIED); diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c index 9dd977349a..056b5da588 100644 --- a/target/s390x/sigp.c +++ b/target/s390x/sigp.c @@ -280,7 +280,7 @@ static void sigp_set_prefix(CPUState *cs, run_on_cpu_data arg) cpu_synchronize_state(cs); - if (!address_space_access_valid(&address_space_memory, addr, + if (!address_space_access_valid(get_address_space_memory(), addr, sizeof(struct LowCore), false, MEMTXATTRS_UNSPECIFIED)) { set_sigp_status(si, SIGP_STAT_INVALID_PARAMETER); diff --git a/target/xtensa/dbg_helper.c b/target/xtensa/dbg_helper.c index ce2a820c60..dbce96b8c7 100644 --- a/target/xtensa/dbg_helper.c +++ b/target/xtensa/dbg_helper.c @@ -42,7 +42,7 @@ static void tb_invalidate_virtual_addr(CPUXtensaState *env, uint32_t vaddr) int ret = xtensa_get_physical_addr(env, false, vaddr, 2, 0, &paddr, &page_size, &access); if (ret == 0) { - tb_invalidate_phys_addr(&address_space_memory, paddr, + tb_invalidate_phys_addr(get_address_space_memory(), paddr, MEMTXATTRS_UNSPECIFIED); } } diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c index afc1d20355..c539627b85 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -325,14 +325,14 @@ static bool get_pio_address(address_range *result, * up fuzzing a completely different MemoryRegion/Device. Therefore, check * that the address here is within the PIO space limits. */ - bool found = get_io_address(result, &address_space_io, index, offset); + bool found = get_io_address(result, get_address_space_io(), index, offset); return result->addr <= 0xFFFF ? found : false; } static bool get_mmio_address(address_range *result, uint8_t index, uint32_t offset) { - return get_io_address(result, &address_space_memory, index, offset); + return get_io_address(result, get_address_space_memory(), index, offset); } static void op_in(QTestState *s, const unsigned char * data, size_t len) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409032.651918 (Exim 4.92) (envelope-from ) id 1oaQ2S-00074O-0n; Mon, 19 Sep 2022 23:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409032.651918; Mon, 19 Sep 2022 23:18:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2R-00074H-Th; Mon, 19 Sep 2022 23:18:55 +0000 Received: by outflank-mailman (input) for mailman id 409032; Mon, 19 Sep 2022 23:18:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2Q-0004vz-7N for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:18:54 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d5d8fe1-3871-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:18:53 +0200 (CEST) Received: by mail-ed1-x533.google.com with SMTP id m3so1325007eda.12 for ; Mon, 19 Sep 2022 16:18:53 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d5d8fe1-3871-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=5XlQ1VpPqIV9nkbL5heHBJQIeqw1Mqo2GOdHAQq5+II=; b=V1Xkq1+a6hse0yYR3fG7QmZf7eJLZ9IHXShDEimvhNxJCgJXQZEhiB7rS29v8mOpv8 P6Q/NgzpGGR1zjQswFV9oVsIkApjiLp/TuMLa8asbQeDVSJ9xcqsRDBMPPfvubQ/ud8M 6dma9SHs8xseeoX1geC075YVhTJkg5UYKK9V145qBxKkDYQso+5CEuESYbx9GpS5ITt/ geAPZY2mvKURWXNpdq+82LS5ePfVg2MiJ8HHMrB93gDn3YIy3WMpYdI3RCQ1Wj2jPwFe D51PhycmYQXgI5PX3syysunfpaQHEnp6cVcDiO8I65JrGDV+oaRZA47creHSMX5+vVkK EpTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=5XlQ1VpPqIV9nkbL5heHBJQIeqw1Mqo2GOdHAQq5+II=; b=yQUShdS5fT3BNKT9Bg5DoZAt98IQLCS+iIujlvkWIRdyk7jNSOwVGQndzJohVO5OYz npA/DXcRlGY2Onv9SGDeqFEi0XxA8gKDGsoWXnqp9T5I5rO25WCWIPJHGQELDKfSuRih +bf+36lFnvKZ3wZFBRLG7IVbrHpvF8mcZ3aZJYoSOT8cmo2lMVtAEUHEfzWP6RvnAuif XbHmfIp3ZGM5HxfXkZWmee9Yd8jroaJZZMgmOg9Kh+FGROMT2K9ewAQpnwxlfkEH4ViH H5mfh0v3oQHSSsU3pEcEiA69RHY6ih6bnebav3R5hgjbnNMDZXQTeFGl3B5vyq9980OR E63w== X-Gm-Message-State: ACrzQf1KZS3HRa3w2CodtE/Dp4axDmRCZcFxrla7BmjF1LeJ2SllzjUK TEXRPLFNR1Sin4ZKHLRiG50= X-Google-Smtp-Source: AMsMyM6LQ7zX0snjJOKDhu4y1VtCyR5HxEAeYDZgQV0qmXEZF7bGIa6sBksILYTX9vlQa3QJPxyguw== X-Received: by 2002:a05:6402:2711:b0:451:327a:365f with SMTP id y17-20020a056402271100b00451327a365fmr17131653edd.315.1663629533162; Mon, 19 Sep 2022 16:18:53 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 6/9] target/loongarch/cpu: Remove unneeded include directive Date: Tue, 20 Sep 2022 01:17:17 +0200 Message-Id: <20220919231720.163121-7-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The cpu is used in both user and system emulation context while sysbus.h is system-only. Remove it since it's not needed anyway. Furthermore, it would cause a compile error in the next commit. Signed-off-by: Bernhard Beschow --- target/loongarch/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h index dce999aaac..c9ed2cb3e7 100644 --- a/target/loongarch/cpu.h +++ b/target/loongarch/cpu.h @@ -13,7 +13,6 @@ #include "hw/registerfields.h" #include "qemu/timer.h" #include "exec/memory.h" -#include "hw/sysbus.h" #define IOCSRF_TEMP 0 #define IOCSRF_NODECNT 1 -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:19:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409038.651929 (Exim 4.92) (envelope-from ) id 1oaQ2Y-0007Vu-AV; Mon, 19 Sep 2022 23:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409038.651929; Mon, 19 Sep 2022 23:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2Y-0007Vb-5u; Mon, 19 Sep 2022 23:19:02 +0000 Received: by outflank-mailman (input) for mailman id 409038; Mon, 19 Sep 2022 23:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2W-0004vz-Fd for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:19:00 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70edeb49-3871-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:18:59 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id a26so2211283ejc.4 for ; Mon, 19 Sep 2022 16:18:59 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:18:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70edeb49-3871-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=18L1CetNQZRcWgrF+bLfFklTWcjPuzsdD8LCMjAGf1E=; b=V5XT6ePhglxVVnzO7wTKlIaCCViZpN/zYqMG+wnd7lcxvsQ6bFt9WuDSwUs61yQfOq pOOrLokv5qVrEanQf1jerp+JQbj02Jx+4/DTXLbk4VGzNoVT9LMVzK0PC7mepLvnFIDH zNU2Iq8+Tt8hwKBJJHRAekFsH64zOK5KDx2DOj+3xLFeQHbqLBayBI84MwLSLyDfmRzn Bn02SXOCet8dJvaSko0kLZJJa9dUhgUekK1verWyRQXlYweUX2DfajwnVTkn8xSB6xdY xhTzjewc6CjRhf/YtZTPMPm/29EOtiCPc87CrZipbkfmhngf1laAFdu+hBwMKfqzao83 81vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=18L1CetNQZRcWgrF+bLfFklTWcjPuzsdD8LCMjAGf1E=; b=NGfoZftkobjudmTRVVLMiBU9vuK86+dS5rRwsPzJWYKiClhOgPm3scHYcXX1QkEQnp vScdUxvnCLdeZwugvpYjZC2KPAZp0DFmyzJp0UHBesQPnP8BVfbwTyNuk4clzcerfy6R p2MC8dyPtmmFBW1TdjhovNKZqeT43yJDleAC+vu6jaZBi1tpRMcOQjXyZlOQctconp3R kXcyWq4Tv83oZQbZLM9cmuE3dCSNoQ8GdrwokaDTDUyZRWa4KY0PlpmTyDVz3CVNNguL qtGm13SeBUOMSodTsx/zyhJ4dCcfnRNE8nAimcmR1ZCZdXg8NLZ1hxhsQ9LAg7ClB5vj 17yA== X-Gm-Message-State: ACrzQf0uNO2logD2g/TxI3rq7OaNRtpPIwzgFJdSyxtMi9OpLxsRP2mf zFfigJtQL6axCI6I5mOlc1I= X-Google-Smtp-Source: AMsMyM4eJjU/NOUzNOFcRv5on/MypRLn/EbDnZquypCWBAyuQiQwWxxTAmP7wvB5d1YGt/EQ80NS8w== X-Received: by 2002:a17:907:2e0b:b0:77f:5fd8:8712 with SMTP id ig11-20020a1709072e0b00b0077f5fd88712mr13751388ejc.575.1663629539177; Mon, 19 Sep 2022 16:18:59 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 7/9] hw/sysbus: Introduce dedicated struct SysBusState for TYPE_SYSTEM_BUS Date: Tue, 20 Sep 2022 01:17:18 +0200 Message-Id: <20220919231720.163121-8-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With this out of the way, in the next step, SysBusState gains attributes for its memory and address recouces. Signed-off-by: Bernhard Beschow --- hw/core/sysbus.c | 4 ++-- include/hw/boards.h | 3 ++- include/hw/misc/macio/macio.h | 2 +- include/hw/sysbus.h | 8 ++++++-- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 16a9b4d7a0..1100f3ad6c 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -84,7 +84,7 @@ static void system_bus_class_init(ObjectClass *klass, void *data) static const TypeInfo system_bus_info = { .name = TYPE_SYSTEM_BUS, .parent = TYPE_BUS, - .instance_size = sizeof(BusState), + .instance_size = sizeof(SysBusState), .class_init = system_bus_class_init, }; @@ -343,7 +343,7 @@ BusState *sysbus_get_default(void) return NULL; } - return ¤t_machine->main_system_bus; + return ¤t_machine->main_system_bus.parent_obj; } static void sysbus_register_types(void) diff --git a/include/hw/boards.h b/include/hw/boards.h index 7af940102d..63a4f990ea 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -11,6 +11,7 @@ #include "qemu/module.h" #include "qom/object.h" #include "hw/core/cpu.h" +#include "hw/sysbus.h" #define TYPE_MACHINE_SUFFIX "-machine" @@ -346,7 +347,7 @@ struct MachineState { */ MemoryRegion *ram; DeviceMemoryState *device_memory; - BusState main_system_bus; + SysBusState main_system_bus; ram_addr_t ram_size; ram_addr_t maxram_size; diff --git a/include/hw/misc/macio/macio.h b/include/hw/misc/macio/macio.h index 6c05f3bfd2..0944be587f 100644 --- a/include/hw/misc/macio/macio.h +++ b/include/hw/misc/macio/macio.h @@ -44,7 +44,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(MacIOBusState, MACIO_BUS) struct MacIOBusState { /*< private >*/ - BusState parent_obj; + SysBusState parent_obj; }; /* MacIO IDE */ diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 3564b7b6a2..5bb3b88501 100644 --- a/include/hw/sysbus.h +++ b/include/hw/sysbus.h @@ -11,9 +11,13 @@ #define QDEV_MAX_PIO 32 #define TYPE_SYSTEM_BUS "System" -DECLARE_INSTANCE_CHECKER(BusState, SYSTEM_BUS, - TYPE_SYSTEM_BUS) +OBJECT_DECLARE_SIMPLE_TYPE(SysBusState, SYSTEM_BUS) +struct SysBusState { + /*< private >*/ + BusState parent_obj; + /*< public >*/ +}; #define TYPE_SYS_BUS_DEVICE "sys-bus-device" OBJECT_DECLARE_TYPE(SysBusDevice, SysBusDeviceClass, -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:19:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409042.651940 (Exim 4.92) (envelope-from ) id 1oaQ2e-00087o-Mo; Mon, 19 Sep 2022 23:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409042.651940; Mon, 19 Sep 2022 23:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2e-00087e-Jd; Mon, 19 Sep 2022 23:19:08 +0000 Received: by outflank-mailman (input) for mailman id 409042; Mon, 19 Sep 2022 23:19:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2c-0004vz-SJ for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:19:07 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 74b8b9ab-3871-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:19:05 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id y17so2191945ejo.6 for ; Mon, 19 Sep 2022 16:19:05 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:19:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74b8b9ab-3871-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GY9FLwpbhpko1ROroTaJ6wfQD1OQmuRWRFOe6XO0HkE=; b=WvtWhaz7RfTahuePkkE9xIcuGxfWCiGa1wTboB9PRKNnjFohCiK5pF4LK4IJs9vf5N yZ9b8tZiP/Tk5sTxggCXSX9hx4EUFuokcV4BrpDDY1zJG3SQgv2WDt7AMvozCWevYw/y FMq1uucw4j5Oqi3St2U+VPdyyKPs808bAQonJw6bTfZqftbvg4Azml8efQ5tZ1HTfiv1 i2uAlpDSRqaRvcSiFKosYvLwQd4zFza7DGwVf1WV4BT2+jgksxTrQDJm9O6L00Q8j9I8 4KmIJLgd7IBUyEMozx+cv/IZSOQLBXyIH5zHVtq82KU+JwLn3+FsLbrutbLKXuQqQsVI bQYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GY9FLwpbhpko1ROroTaJ6wfQD1OQmuRWRFOe6XO0HkE=; b=Gbcy3BOWpsXkTb8VssuD5vKyGHCeci6qGnuECfAlwzQC5CnR6oq25/8lb/YFHoJ91b IC7+TaVNhZJOQEl93JcKswd2/op5SsbRECCvfAmaNckLepnw4RVLvvj9wdzvN/Y650jW yO7VLoEuGPnL3hAp3X+ARieSUPxdi5E7ymf7P4t6Kjs6hUWGMk2C9gLqkkPaoSbLfaSw CWzZWxctkApR9sNIUVtJZ6fzkNPTPmZvP+GdT5Z069qZYYpL76oeIO6tAaT8kImxwlZI MY4upAAe1s78tL8M55R5R4yU/DRj8LO3MZODYf/y/VyNVlqOi8VJ82XZYT/Bnc6lKmC4 WAzg== X-Gm-Message-State: ACrzQf0BpCv9zsYA4tIXr6zizNbHh/bFmOxHowR1rXvEDwUE/fGg1/6Q t52/mB+RqFg0Ga2AFMlNpxM= X-Google-Smtp-Source: AMsMyM4qkgaEMGM0QJXD77Pkxb2n4WftV+KsIglPwhyeQygcGRI6lNjr6tviLaBlIrFPXV7KHzllzg== X-Received: by 2002:a17:907:3e86:b0:6f5:917:10cc with SMTP id hs6-20020a1709073e8600b006f5091710ccmr15309153ejc.53.1663629545495; Mon, 19 Sep 2022 16:19:05 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 8/9] softmmu/physmem: Let SysBusState absorb memory region and address space singletons Date: Tue, 20 Sep 2022 01:17:19 +0200 Message-Id: <20220919231720.163121-9-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit These singletons are actually properties of the system bus but so far it hasn't been modelled that way. Fix this to make this relationship very obvious. The idea of the patch is to restrain futher proliferation of the use of get_system_memory() and get_system_io() which are "temprary interfaces" "until a proper bus interface is available". This should now be the case. Note that the new attributes are values rather than a pointers. This trades pointer dereferences for pointer arithmetic. The idea is to reduce cache misses - a rule of thumb says that every pointer dereference causes a cache miss while arithmetic is basically free. Signed-off-by: Bernhard Beschow --- include/exec/address-spaces.h | 19 ++++++++++++--- include/hw/sysbus.h | 6 +++++ softmmu/physmem.c | 46 ++++++++++++++++++----------------- 3 files changed, 45 insertions(+), 26 deletions(-) diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h index d5c8cbd718..b31bd8dcf0 100644 --- a/include/exec/address-spaces.h +++ b/include/exec/address-spaces.h @@ -23,17 +23,28 @@ #ifndef CONFIG_USER_ONLY -/* Get the root memory region. This interface should only be used temporarily - * until a proper bus interface is available. +/** + * Get the root memory region. This is a legacy function, provided for + * compatibility. Prefer using SysBusState::system_memory directly. */ MemoryRegion *get_system_memory(void); -/* Get the root I/O port region. This interface should only be used - * temporarily until a proper bus interface is available. +/** + * Get the root I/O port region. This is a legacy function, provided for + * compatibility. Prefer using SysBusState::system_io directly. */ MemoryRegion *get_system_io(void); +/** + * Get the root memory address space. This is a legacy function, provided for + * compatibility. Prefer using SysBusState::address_space_memory directly. + */ AddressSpace *get_address_space_memory(void); + +/** + * Get the root I/O port address space. This is a legacy function, provided + * for compatibility. Prefer using SysBusState::address_space_io directly. + */ AddressSpace *get_address_space_io(void); #endif diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 5bb3b88501..516e9091dc 100644 --- a/include/hw/sysbus.h +++ b/include/hw/sysbus.h @@ -17,6 +17,12 @@ struct SysBusState { /*< private >*/ BusState parent_obj; /*< public >*/ + + MemoryRegion system_memory; + MemoryRegion system_io; + + AddressSpace address_space_io; + AddressSpace address_space_memory; }; #define TYPE_SYS_BUS_DEVICE "sys-bus-device" diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 0ac920d446..07e9a9171c 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -86,12 +86,6 @@ */ RAMList ram_list = { .blocks = QLIST_HEAD_INITIALIZER(ram_list.blocks) }; -static MemoryRegion *system_memory; -static MemoryRegion *system_io; - -static AddressSpace address_space_io; -static AddressSpace address_space_memory; - static MemoryRegion io_mem_unassigned; typedef struct PhysPageEntry PhysPageEntry; @@ -146,7 +140,7 @@ typedef struct subpage_t { #define PHYS_SECTION_UNASSIGNED 0 static void io_mem_init(void); -static void memory_map_init(void); +static void memory_map_init(SysBusState *sysbus); static void tcg_log_global_after_sync(MemoryListener *listener); static void tcg_commit(MemoryListener *listener); @@ -2667,37 +2661,45 @@ static void tcg_commit(MemoryListener *listener) tlb_flush(cpuas->cpu); } -static void memory_map_init(void) +static void memory_map_init(SysBusState *sysbus) { - system_memory = g_malloc(sizeof(*system_memory)); + MemoryRegion *system_memory = &sysbus->system_memory; + MemoryRegion *system_io = &sysbus->system_io; memory_region_init(system_memory, NULL, "system", UINT64_MAX); - address_space_init(&address_space_memory, system_memory, "memory"); + address_space_init(&sysbus->address_space_memory, system_memory, "memory"); - system_io = g_malloc(sizeof(*system_io)); memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io", 65536); - address_space_init(&address_space_io, system_io, "I/O"); + address_space_init(&sysbus->address_space_io, system_io, "I/O"); } MemoryRegion *get_system_memory(void) { - return system_memory; + assert(current_machine); + + return ¤t_machine->main_system_bus.system_memory; } MemoryRegion *get_system_io(void) { - return system_io; + assert(current_machine); + + return ¤t_machine->main_system_bus.system_io; } AddressSpace *get_address_space_memory(void) { - return &address_space_memory; + assert(current_machine); + + return ¤t_machine->main_system_bus.address_space_memory; } AddressSpace *get_address_space_io(void) { - return &address_space_io; + assert(current_machine); + + return ¤t_machine->main_system_bus.address_space_io; } static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, @@ -3003,7 +3005,7 @@ MemTxResult address_space_set(AddressSpace *as, hwaddr addr, void cpu_physical_memory_rw(hwaddr addr, void *buf, hwaddr len, bool is_write) { - address_space_rw(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED, + address_space_rw(get_address_space_memory(), addr, MEMTXATTRS_UNSPECIFIED, buf, len, is_write); } @@ -3074,7 +3076,7 @@ void cpu_flush_icache_range(hwaddr start, hwaddr len) return; } - address_space_write_rom_internal(&address_space_memory, + address_space_write_rom_internal(get_address_space_memory(), start, MEMTXATTRS_UNSPECIFIED, NULL, len, FLUSH_CACHE); } @@ -3140,7 +3142,7 @@ void cpu_exec_init_all(void) */ finalize_target_page_bits(); io_mem_init(); - memory_map_init(); + memory_map_init(¤t_machine->main_system_bus); qemu_mutex_init(&map_client_list_lock); } @@ -3322,14 +3324,14 @@ void *cpu_physical_memory_map(hwaddr addr, hwaddr *plen, bool is_write) { - return address_space_map(&address_space_memory, addr, plen, is_write, + return address_space_map(get_address_space_memory(), addr, plen, is_write, MEMTXATTRS_UNSPECIFIED); } void cpu_physical_memory_unmap(void *buffer, hwaddr len, bool is_write, hwaddr access_len) { - return address_space_unmap(&address_space_memory, buffer, len, + return address_space_unmap(get_address_space_memory(), buffer, len, is_write, access_len); } @@ -3554,7 +3556,7 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr) bool res; RCU_READ_LOCK_GUARD(); - mr = address_space_translate(&address_space_memory, + mr = address_space_translate(get_address_space_memory(), phys_addr, &phys_addr, &l, false, MEMTXATTRS_UNSPECIFIED); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:21:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:21:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409060.651951 (Exim 4.92) (envelope-from ) id 1oaQ57-00020i-BS; Mon, 19 Sep 2022 23:21:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409060.651951; Mon, 19 Sep 2022 23:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ57-00020b-7g; Mon, 19 Sep 2022 23:21:41 +0000 Received: by outflank-mailman (input) for mailman id 409060; Mon, 19 Sep 2022 23:21:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ56-00020I-6R for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:21:40 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf31aaf9-3871-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:21:38 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 28JNLRj0093396 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 19 Sep 2022 19:21:33 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 28JNLRQU093395; Mon, 19 Sep 2022 16:21:27 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf31aaf9-3871-11ed-9647-05401a9f4f97 Date: Mon, 19 Sep 2022 16:21:27 -0700 From: Elliott Mitchell To: Demi Marie Obenour Cc: Xen developer discussion , netdev@vger.kernel.org Subject: Re: Layer 3 (point-to-point) netfront and netback drivers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Mon, Sep 19, 2022 at 05:41:05PM -0400, Demi Marie Obenour wrote: > On Mon, Sep 19, 2022 at 01:46:59PM -0700, Elliott Mitchell wrote: > > On Sun, Sep 18, 2022 at 08:41:25AM -0400, Demi Marie Obenour wrote: > > > How difficult would it be to provide layer 3 (point-to-point) versions > > > of the existing netfront and netback drivers? Ideally, these would > > > share almost all of the code with the existing drivers, with the only > > > difference being how they are registered with the kernel. Advantages > > > compared to the existing drivers include less attack surface (since the > > > peer is no longer network-adjacent), slightly better performance, and no > > > need for ARP or NDP traffic. > > > > I've actually been wondering about a similar idea. How about breaking > > the entire network stack off and placing /that/ in a separate VM? > > This is going to be very hard to do without awesome but difficult > changes to applications. Switching to layer 3 links is a much smaller > change that should be transparent to applications. Indeed for ones which modify network settings, but not for ones which merely use the sockets API. Isn't this the same issue for what you're suggesting? (I'm suggesting pushing more into a separate VM, but the principle is the same) > > One use for this is a VM could be constrained to *exclusively* have > > network access via Tor. This would allow a better hidden service as it > > would have no network topology knowledge. > > That is great in theory, but in practice programs will expect to use > network protocols to connect to Tor. Whonix already implements this > with the current Xen netfront/netback. Whonix is wrapping at layer 2 and simply NATing everything. I'm suggesting cutting at a higher layer. > > The other use is network cards which are increasingly able to handle more > > of the network stack. The Linux network team have been resistant to > > allowing more offloading, so perhaps it is time to break *everything* > > off. > > Do you have any particular examples? The only one I can think of is > that Linux is not okay with TCP offload engines. That is precisely what I was thinking of. While I understand the desire for control, when it comes down to it a network card which lies could simply transparently proxy everything. Anything not protected by cryptography is vulnerable, so worrying about raw packets doesn't seem useful. > > I'm unsure the benefits would justify the effort, but I keep thinking of > > this as the solution to some interesting issues. Filtering becomes more > > interesting, but BPF could work across VMs. > > Classic BPF perhaps, but eBPF's attack surface is far too large for this > to be viable. Unprivileged eBPF is already disabled by default. I was thinking of classic BPF. If everything below the sockets layer was in a separate VM, filtering rules could still work by pushing BPF rules to the other side. Your idea is to push less into a separate VM than I was thinking. I wanted to bring up it might be worthwhile pushing more. If your project launches I imagine eventually you'll be trying to encompass more, so it may be easier to consider what the future will hold. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:25:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:25:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409074.651961 (Exim 4.92) (envelope-from ) id 1oaQ8J-0002gg-Pg; Mon, 19 Sep 2022 23:24:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409074.651961; Mon, 19 Sep 2022 23:24:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ8J-0002gZ-N6; Mon, 19 Sep 2022 23:24:59 +0000 Received: by outflank-mailman (input) for mailman id 409074; Mon, 19 Sep 2022 23:24:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQ2j-0004MC-7V for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:19:13 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 788365cf-3871-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 01:19:12 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id e18so1404318edj.3 for ; Mon, 19 Sep 2022 16:19:12 -0700 (PDT) Received: from localhost.localdomain (dynamic-078-054-077-055.78.54.pool.telefonica.de. [78.54.77.55]) by smtp.gmail.com with ESMTPSA id rn24-20020a170906d93800b00780f6071b5dsm4800926ejb.188.2022.09.19.16.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 16:19:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 788365cf-3871-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=CsS8/+NcmmUwF5Nr1L7YiFLpUSnCt26Ro0cbZ1iTpA0=; b=LvQxLOmJmGVQ6sYu0MsAHfg8Ds6mykcGi7e3toDd9OFsfFEnWXTEkQZsRgcA0qsBVK Ax5qZ/FGRkcXZjgQXjmpXzOndgONzyLEOfYdR+g0wP59Ui6GKvlOYss+hr/WgF94LAQG ax/WwLFBL1+LRyQIy+7lhc0PSm9DLccB1NsqeZVjbmbqGQFnyw6exKqa/w0WN+cCU129 HszwSLx/FOWeL2QB5xupKDxKOyewPDDsvvE6piEkWTsl/i3Bmnlz2slYtvmUZUAw6hb3 NZGTv/8KL9eBHuB2KB1+1rAmJut32xrcuUgfT1HQYK6PmCKcw+vZEvVx72whU341ZIbN rvxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=CsS8/+NcmmUwF5Nr1L7YiFLpUSnCt26Ro0cbZ1iTpA0=; b=tXseVwCr54CW8/v1dVZ6TsAPeC3XpzmR1paSbaThURmzL8caBbmuqpNG5Kj6QzFDQF ItGNwaBZ0YBMpyL5q+jGqw6+/SDIceBRkvPNHDpwI+669J+B8j35BvThm+IRmM+PRgn4 2n5nFTz0FQVx7uCC9AXA8yxMr00e5eMBqxYMdUZjXBRomyroQTQIZR/fJqi6hd1Etp95 gsZxAmPE1C7DvB7pAmh9naXWmutTvTsYAiJkebQ7R/fYeoo0MxxRj8iSrCZAyc1GWKMI PYStEYDlR6YSsWw8K5UKy+d64NbvbwQXltnc4DuvX9FEhs3tAeF6LvScWCTdZvp+YjzC IOcQ== X-Gm-Message-State: ACrzQf2vvugipFg6ek8eVQiKrFDs3HLzsdhv2MiB8NZ6tmgLIm4qKSTN Z68DcHz6oCJsCXQuhPgvZkg= X-Google-Smtp-Source: AMsMyM54oAh1Hs8YDp/oSyEMdroOBdvLpZ3fCGRY2SIbSMd17jic9985Tclql7Fyu3Qp56FgVgfeBA== X-Received: by 2002:aa7:da83:0:b0:44e:69ba:81c7 with SMTP id q3-20020aa7da83000000b0044e69ba81c7mr17400003eds.323.1663629551883; Mon, 19 Sep 2022 16:19:11 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne , Bernhard Beschow Subject: [PATCH 9/9] exec/address-spaces: Inline legacy functions Date: Tue, 20 Sep 2022 01:17:20 +0200 Message-Id: <20220919231720.163121-10-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> References: <20220919231720.163121-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions just access a global pointer and perform some pointer arithmetic on top. Allow the compiler to see through this by inlining. Signed-off-by: Bernhard Beschow --- include/exec/address-spaces.h | 30 ++++++++++++++++++++++++++---- softmmu/physmem.c | 28 ---------------------------- 2 files changed, 26 insertions(+), 32 deletions(-) diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h index b31bd8dcf0..182af27cad 100644 --- a/include/exec/address-spaces.h +++ b/include/exec/address-spaces.h @@ -23,29 +23,51 @@ #ifndef CONFIG_USER_ONLY +#include "hw/boards.h" + /** * Get the root memory region. This is a legacy function, provided for * compatibility. Prefer using SysBusState::system_memory directly. */ -MemoryRegion *get_system_memory(void); +inline MemoryRegion *get_system_memory(void) +{ + assert(current_machine); + + return ¤t_machine->main_system_bus.system_memory; +} /** * Get the root I/O port region. This is a legacy function, provided for * compatibility. Prefer using SysBusState::system_io directly. */ -MemoryRegion *get_system_io(void); +inline MemoryRegion *get_system_io(void) +{ + assert(current_machine); + + return ¤t_machine->main_system_bus.system_io; +} /** * Get the root memory address space. This is a legacy function, provided for * compatibility. Prefer using SysBusState::address_space_memory directly. */ -AddressSpace *get_address_space_memory(void); +inline AddressSpace *get_address_space_memory(void) +{ + assert(current_machine); + + return ¤t_machine->main_system_bus.address_space_memory; +} /** * Get the root I/O port address space. This is a legacy function, provided * for compatibility. Prefer using SysBusState::address_space_io directly. */ -AddressSpace *get_address_space_io(void); +inline AddressSpace *get_address_space_io(void) +{ + assert(current_machine); + + return ¤t_machine->main_system_bus.address_space_io; +} #endif diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 07e9a9171c..dce088f55c 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2674,34 +2674,6 @@ static void memory_map_init(SysBusState *sysbus) address_space_init(&sysbus->address_space_io, system_io, "I/O"); } -MemoryRegion *get_system_memory(void) -{ - assert(current_machine); - - return ¤t_machine->main_system_bus.system_memory; -} - -MemoryRegion *get_system_io(void) -{ - assert(current_machine); - - return ¤t_machine->main_system_bus.system_io; -} - -AddressSpace *get_address_space_memory(void) -{ - assert(current_machine); - - return ¤t_machine->main_system_bus.address_space_memory; -} - -AddressSpace *get_address_space_io(void) -{ - assert(current_machine); - - return ¤t_machine->main_system_bus.address_space_io; -} - static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, hwaddr length) { -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:31:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:31:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409081.651972 (Exim 4.92) (envelope-from ) id 1oaQEn-00047u-GN; Mon, 19 Sep 2022 23:31:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409081.651972; Mon, 19 Sep 2022 23:31:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQEn-00047n-Dj; Mon, 19 Sep 2022 23:31:41 +0000 Received: by outflank-mailman (input) for mailman id 409081; Mon, 19 Sep 2022 23:31:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQEl-00047h-EP for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:31:39 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34b6bc07-3873-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 01:31:38 +0200 (CEST) Received: by mail-pj1-x102e.google.com with SMTP id q35-20020a17090a752600b002038d8a68fbso4969217pjk.0 for ; Mon, 19 Sep 2022 16:31:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34b6bc07-3873-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=NSIvRNfXT4BgiWoAffM4RsDVDd2SOkBJz5nw83+ZE0Q=; b=dIO7rKlwpt1a4Rr55TM/1OaCkqXzxn5HQ5hnLXBRwWHTkpqxju5K46xUcpujcqqOhY UT1qtY65c18HaDPPSpvVTvhQ9+fVBIzAfgdO1ePcqTnS8abQ/ssqUdN4PA8+BBbGscY4 zcHOxvhGd/Rw79kJ916G+ztNW9eW1CWpGEOd7bJnYuq86Ev2kMsm0q8+XzwBszG8pjQ2 Pve2h3B9fmVc6VWU3tTQ2teTgIPA46kmE7p9DGMxzzCgzN9yNZgGgirx1IC7zm5IGED/ gjezyCWZTWWjo3xYAtiH58mh8QAjO7bV/tNRRbQG7XhlchTkciQZvl7gHKj0RWl+10FH DxUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=NSIvRNfXT4BgiWoAffM4RsDVDd2SOkBJz5nw83+ZE0Q=; b=HSIfk0WUtqqhJTUazxxQBl1KTYUsfdAFrOIu7EpsL9lEBB8zypW3bbYYv2cN9EXvp3 phQNQsagibPvJneeEGyEbV/Za/mKJXbvoUX933SbaKZV8lYbiACeg4guJFO3idRNvzFj 5zJDCMRORLVocEo6f3iASPOkCrti6RrmDbgXggkwB+nouLZmgkgoHqkskJYmamiXkhKn z8Enzdf9srlnZ9UwqOh7Tu/cdysH8xFfpCJIpNiCazncT5XKWakF0Het5y8qoMsHskA6 vjIvNdVK3UYgMzNUKg2wBsiMK7Kkxjd1sSXIkEoZ9d8aiEAe1cfRQsBldZ35mvXnOBsL Mlow== X-Gm-Message-State: ACrzQf1MOBMX2oh0VN44pZj7+Edo1VMI0Oo4qr+5tVBQZlVEY+h43RFD pf4wdlZ8BDpL1I2WWqg3Np/cIprUc1GLrAdyXc0= X-Google-Smtp-Source: AMsMyM5CNfH4JqOtjO62MVBjvYF0+2r5Smy7El5C/g8RoLI2QIg17MckqusD++UPU8lggRnlhnNJDkN9NdqBYMgnYv8= X-Received: by 2002:a17:90b:1b50:b0:202:f495:6b43 with SMTP id nv16-20020a17090b1b5000b00202f4956b43mr680878pjb.85.1663630296957; Mon, 19 Sep 2022 16:31:36 -0700 (PDT) MIME-Version: 1.0 References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> In-Reply-To: <20220919231720.163121-2-shentey@gmail.com> From: Alistair Francis Date: Tue, 20 Sep 2022 09:31:10 +1000 Message-ID: Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState To: Bernhard Beschow Cc: "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , "open list:New World" , Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Content-Type: text/plain; charset="UTF-8" On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: > > SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to > inherit from TYPE_MACHINE. This is an inconsistency which can cause > undefined behavior such as memory corruption. > > Change SiFiveEState to inherit from MachineState since it is registered > as a machine. > > Signed-off-by: Bernhard Beschow Reviewed-by: Alistair Francis Alistair > --- > include/hw/riscv/sifive_e.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/hw/riscv/sifive_e.h b/include/hw/riscv/sifive_e.h > index 83604da805..d738745925 100644 > --- a/include/hw/riscv/sifive_e.h > +++ b/include/hw/riscv/sifive_e.h > @@ -22,6 +22,7 @@ > #include "hw/riscv/riscv_hart.h" > #include "hw/riscv/sifive_cpu.h" > #include "hw/gpio/sifive_gpio.h" > +#include "hw/boards.h" > > #define TYPE_RISCV_E_SOC "riscv.sifive.e.soc" > #define RISCV_E_SOC(obj) \ > @@ -41,7 +42,7 @@ typedef struct SiFiveESoCState { > > typedef struct SiFiveEState { > /*< private >*/ > - SysBusDevice parent_obj; > + MachineState parent_obj; > > /*< public >*/ > SiFiveESoCState soc; > -- > 2.37.3 > > From xen-devel-bounces@lists.xenproject.org Mon Sep 19 23:33:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 19 Sep 2022 23:33:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409085.651983 (Exim 4.92) (envelope-from ) id 1oaQGF-0004gs-Qk; Mon, 19 Sep 2022 23:33:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409085.651983; Mon, 19 Sep 2022 23:33:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQGF-0004gl-O4; Mon, 19 Sep 2022 23:33:11 +0000 Received: by outflank-mailman (input) for mailman id 409085; Mon, 19 Sep 2022 23:33:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaQGD-0004gd-Bn for xen-devel@lists.xenproject.org; Mon, 19 Sep 2022 23:33:09 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6852d7d4-3873-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 01:33:07 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D72613200413; Mon, 19 Sep 2022 19:33:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Sep 2022 19:33:03 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 19:33:01 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6852d7d4-3873-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663630382; x= 1663716782; bh=sPAQpBuT7DX/lS7+acc/WtdRkKeL6R3TMHiLOl+w4tY=; b=m Vd6slNt65xIsHqtglp3hdsadw9lSQeYd0+CyRJCK/LtUxBhuq6fGjwADWRWeVrQ9 1py8PrsiIdWulP0BLiLKic7lzDYEhpzvCxfLLtyuVSCA7jzAbQRe1u4MTDGmkEqj Vw1EJXPUEcjyjnEFgzRAIXCpLY4dnwUBJX9njHeoY3D7qcZzLW0Bq8TPHGaynwlq KtEnHgStfVVmBKn6e0fk57BiVMYZE3wFVjbgFN9cBO98fdEx2d8F7FT2pQcmVpXC pgtrRU9lwWB5wzs8oCS2NOVpGf0f6NgmReKYNRHx7gmeSY9TgdTb8m9WufVGPIio OOsRbpIpnNG1B1km+pK9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663630382; x=1663716782; bh=sPAQpBuT7DX/lS7+acc/WtdRkKeL 6R3TMHiLOl+w4tY=; b=KqkDgd/qSeq2+spD9+IBUbKo10/GuXRMFhkG1t9Mom5Z 0Jphwrq/t6v36FYAusrcFUjR6iC7qNknOtsdqxSFdfN4ohY+JeNXne4cW8nX+gxk 6onMhgm1gAgBAlDeMYwqvpDGggfANBSrCfLq+dmMKOYkW5C5Hn4QA7oldvmSLJuu 1Yq/EcwrRomaBgJaZSBMf2BDOrx5e9QWUuQ693Im7pYCJ6SfCKqjdxH3sdz/di1p tO1fZHZc4z55PXxYMZ1EQQus+HU99LWNkbBoCJERWEQplPW9gcwQKhh+bCtRE5TH k86pz7ZVrT9WW491oPOfDobzY3TOuG+03YGsVX4L4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvkedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 19 Sep 2022 19:32:57 -0400 From: Demi Marie Obenour To: Elliott Mitchell Cc: Xen developer discussion , netdev@vger.kernel.org Subject: Re: Layer 3 (point-to-point) netfront and netback drivers Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Xuc8mAzzLN+qoJxE" Content-Disposition: inline In-Reply-To: --Xuc8mAzzLN+qoJxE Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Sep 2022 19:32:57 -0400 From: Demi Marie Obenour To: Elliott Mitchell Cc: Xen developer discussion , netdev@vger.kernel.org Subject: Re: Layer 3 (point-to-point) netfront and netback drivers On Mon, Sep 19, 2022 at 04:21:27PM -0700, Elliott Mitchell wrote: > On Mon, Sep 19, 2022 at 05:41:05PM -0400, Demi Marie Obenour wrote: > > On Mon, Sep 19, 2022 at 01:46:59PM -0700, Elliott Mitchell wrote: > > > On Sun, Sep 18, 2022 at 08:41:25AM -0400, Demi Marie Obenour wrote: > > > > How difficult would it be to provide layer 3 (point-to-point) versi= ons > > > > of the existing netfront and netback drivers? Ideally, these would > > > > share almost all of the code with the existing drivers, with the on= ly > > > > difference being how they are registered with the kernel. Advantag= es > > > > compared to the existing drivers include less attack surface (since= the > > > > peer is no longer network-adjacent), slightly better performance, a= nd no > > > > need for ARP or NDP traffic. > > >=20 > > > I've actually been wondering about a similar idea. How about breaking > > > the entire network stack off and placing /that/ in a separate VM? > >=20 > > This is going to be very hard to do without awesome but difficult > > changes to applications. Switching to layer 3 links is a much smaller > > change that should be transparent to applications. >=20 > Indeed for ones which modify network settings, but not for ones which > merely use the sockets API. Isn't this the same issue for what you're > suggesting? No. What I am referring to is having netfront and netback carry IP packets instead of Ethernet frames. This is transparent to applications that use the sockets API. What you are talking about, if I understand correctly, requires changing the implementation of the sockets API, which is much harder. > > > The other use is network cards which are increasingly able to handle = more > > > of the network stack. The Linux network team have been resistant to > > > allowing more offloading, so perhaps it is time to break *everything* > > > off. > >=20 > > Do you have any particular examples? The only one I can think of is > > that Linux is not okay with TCP offload engines. >=20 > That is precisely what I was thinking of. While I understand the desire > for control, when it comes down to it a network card which lies could > simply transparently proxy everything. Anything not protected by > cryptography is vulnerable, so worrying about raw packets doesn't seem > useful. IIRC the problems with TCP offload engines are that they do not support all of Linux=E2=80=99s features (such as netfilter), require invasive hooks= so that various configuration can be handled using standard Linux tools, and have closed-source firmware with substantial remote attack surface. > > > I'm unsure the benefits would justify the effort, but I keep thinking= of > > > this as the solution to some interesting issues. Filtering becomes m= ore > > > interesting, but BPF could work across VMs. > >=20 > > Classic BPF perhaps, but eBPF's attack surface is far too large for this > > to be viable. Unprivileged eBPF is already disabled by default. >=20 > I was thinking of classic BPF. If everything below the sockets layer > was in a separate VM, filtering rules could still work by pushing BPF > rules to the other side. >=20 >=20 > Your idea is to push less into a separate VM than I was thinking. I > wanted to bring up it might be worthwhile pushing more. If your project > launches I imagine eventually you'll be trying to encompass more, so it > may be easier to consider what the future will hold. I don=E2=80=99t actually plan to go beyond this, although you are of course= free to do so. This change is simply to reduce attack surface and complexity in Qubes OS, which uses layer 2 links where layer 3 links would do. I am hoping this is just a matter of how the netback and netfront drivers register with Linux. I also don=E2=80=99t have the time to implement the c= hange right now. My question is about what the change would involve. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --Xuc8mAzzLN+qoJxE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMo/CwACgkQsoi1X/+c IsHOOg/+KqLw+taYcsMHLuXvlNlifovgaaztkj6UMVN1i6d06lqX/ts1cWHztq4n +ANyU9y9Z3uKRx/DvFqpiaNnnF6T5v3qEjxd4/dljQVrP5NGHgrJacUHBqmUnNp6 k50ONZBp5kDUjZpA/InekCmKGezVwIhamC2brbi+V74Cs5ILP29HWFXaa+ZoU4lc kwvCpViNjFmHIUzYq22a3PQJ7whZVU0w5oe5yEXGNO5ISKjoajiSpCmqWZRwShgZ IJuyMSnXjkZEQ6iQ35e4YGi4lBRSLPlF5qrgIxgLoqWU0sveBN/0y6LT3bWSdfLo y6xDkBOEyUh6c+TesqO5OdW8zS3B8S94SiqW148ZQTpNZx3qERILtgjvjaVHV/rr Q80k2nlrt85UwHHoHvVSzfkJoAnuNKBisQkxx5ZB6/fUPP0PVYWkKBFCKv5CNfXr 9cMxSuiyGYt+/xBoDPwc0w7p7bmfAQuYQGdPwo8nYMF8cg4K/c74wTGWTm//aARJ PYclKujh3N4rdHM/7sjSLuKpc3BdFh8rbSV/R6bpzGTqt5CHy5Ue+gN51V2kfWIu 0V3uXW+OO5/7VbngyshxXDvEtjNO4hm0suRqoj/2THsiA/Q7gWkXW8t3OHOCjSmx /JvPxYLOPLyS6/9MBtk2aDbixS2Y6YK8lBZkOhm3kp4j77sFYPI= =kwTi -----END PGP SIGNATURE----- --Xuc8mAzzLN+qoJxE-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 01:38:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 01:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409100.651995 (Exim 4.92) (envelope-from ) id 1oaSDe-0006m8-Kh; Tue, 20 Sep 2022 01:38:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409100.651995; Tue, 20 Sep 2022 01:38:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaSDe-0006m1-HC; Tue, 20 Sep 2022 01:38:38 +0000 Received: by outflank-mailman (input) for mailman id 409100; Tue, 20 Sep 2022 01:38:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaSDc-0006lv-96 for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 01:38:36 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20058.outbound.protection.outlook.com [40.107.2.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f020267c-3884-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 03:38:34 +0200 (CEST) Received: from AS9PR06CA0071.eurprd06.prod.outlook.com (2603:10a6:20b:464::22) by DB9PR08MB7423.eurprd08.prod.outlook.com (2603:10a6:10:370::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 01:38:30 +0000 Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::20) by AS9PR06CA0071.outlook.office365.com (2603:10a6:20b:464::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 01:38:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 01:38:29 +0000 Received: ("Tessian outbound 9236804a5e9b:v124"); Tue, 20 Sep 2022 01:38:29 +0000 Received: from b8628569d284.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 461416BB-9A5B-480D-A5F2-3A7366F712A7.1; Tue, 20 Sep 2022 01:38:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8628569d284.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 01:38:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR3PR08MB5692.eurprd08.prod.outlook.com (2603:10a6:102:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 01:38:22 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5632.019; Tue, 20 Sep 2022 01:38:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f020267c-3884-11ed-bad8-01ff208a15ba ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cwT/NL6/+mGkLABhcQHCs0Z4wnTnwr0xjHliOmH+i+zFDy0eA8HGvSF4tr4RDndlbD7alPuViWSi9DXFzUSvMbZF2aodTSBoAIyf51nl6/qaEuHhmFleZR38Uj49fwVFAaqBsa8xs2HcopnqK99/pw4hTcddd5UTUSXpVYj50t4uT2N8M1wb04ZdvTLBmeLKtOtKz9GatfxYEl5F4A68L1fiyKPvl8Dgnw673jK7xnbuekMM32yTnVNnGHRgEYBq0h4woKLHUQd8ptjxFIBxOinwsR4+6Ul1dri1kWr8zNbwIOFr8n1pr2iVxbUcAbZ5APNBh1NKvI9eVYHEE2mAow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1uP1fjcRXa+FFxfK+iSFV340Ed5Qip3Kuo10Mx4Qg8=; b=h4Vn2QgdXgpnVpQHfloY470u/P5o6I+vV9A5IfkReVTEUrfcKfYNInzJoHJDJePu7Ce7VjEYs4Es8FqYPQ5ipHEg66i2CiUd93cWuFU6WK0z3TKZqKwpEhD3eaGwejfJmAaxlqK1gLzd5Nylv0DL48BRM42G9z1ODAmZVYOrkUoDvEdsDCsh/XxcuYwgMczkKduOGd8iNQkUpvJQsNVABSYiT1MS7F6U+MhvJ9fb6iU5Omr4Adgg+XmQrb+aVv2ZCoXB92CBFXmh3uoADlzIiAYo45CQVgGbFF4DgHZgOJpufc/CHHgSu7i+h43hmEC/2+DUkvPj2+MCLKsdUtgyYw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1uP1fjcRXa+FFxfK+iSFV340Ed5Qip3Kuo10Mx4Qg8=; b=or07ohQyoTmkYWUoPKkV7vzduSeo2smXyv6AW+7gaXe5s4NmwK+Vf6MNN7qAiS7WUPCq215vriRQ2+kdT+fOIZk38P/dqVQjp/CHXsZaao882LnurDr268jVC8KuvgXcm6mIzBqXxZaAObp1mYAFmbJFe44nPbRT+m4YdDGqu+I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLTdeFapy6i/7JP9PbX6oEahAa0sP67Nn0JLUaO8eKZP2W1Y9XT+vtaOEJrlLaMWnhODmra8LLU1HCjommttqI/hYn/1TxIyfJSTUc+1+W3mpg00ihvJhdMjFxRhGs3dhEL5/iZGs/6jSPN4RIM9ptHU4lWbBIA7PfIsRjxS5PJNYADRr/akUO5JUIkwCo4sLFQGMcdUxJBxdRBbP4D3RKs9166xxr1p/ms7PqqSC4PI8Q9xWdIbSZ+vbTkRcAaj9gmegFuzog1VxpNbicDMfwPy9hilmsxwyc4WXlYLSa3ruoi1P0i50UFA1g66LIiNcWUYZBtR9tHWQowsHDCQVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1uP1fjcRXa+FFxfK+iSFV340Ed5Qip3Kuo10Mx4Qg8=; b=mV0k+LL7oAoxYrbLt7DlYRBa7moMizVN+a5pJ4r9tTTeWXqt+/4Tpxt9EUBSUYpDvP6AgZ2sEBjgMOR2O/QGA1olE1qcljd9b+wOLzEIHPzbNkBW+pf3DpQ6rukOvDgSbsklwDR7vBp9BUGxEQ+eSMmr/jjCjWzuylFmpMsd3LSS7EQURnco+9sftmwjgQNF0uWlv+BobBjViVa6GKPQy/GudI7TaYA4WfeBieYe0Zw12HqRkg+y65FpfoLF5Oq2f6GaogCUbP0yIVdPDWuY+//sSokZkWrn53WuVAebkBGe9L/rFWbonCUiFhIn4XlBs+WKFP8Ep1RL41kMIoYvAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1uP1fjcRXa+FFxfK+iSFV340Ed5Qip3Kuo10Mx4Qg8=; b=or07ohQyoTmkYWUoPKkV7vzduSeo2smXyv6AW+7gaXe5s4NmwK+Vf6MNN7qAiS7WUPCq215vriRQ2+kdT+fOIZk38P/dqVQjp/CHXsZaao882LnurDr268jVC8KuvgXcm6mIzBqXxZaAObp1mYAFmbJFe44nPbRT+m4YdDGqu+I= From: Henry Wang To: Jan Beulich , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Paul Durrant , Kevin Tian , Connor Davis , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability Thread-Topic: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability Thread-Index: AQHYykB84mg4uPAeVUC/H1cP2JLxkK3mxGyAgADG5TA= Date: Tue, 20 Sep 2022 01:38:22 +0000 Message-ID: References: <6211a296-c4ba-5783-f6b4-8dbed8261a2a@suse.com> In-Reply-To: <6211a296-c4ba-5783-f6b4-8dbed8261a2a@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 81F389C7AA8DAC4B93EE9FFA1941A781.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PR3PR08MB5692:EE_|VE1EUR03FT011:EE_|DB9PR08MB7423:EE_ X-MS-Office365-Filtering-Correlation-Id: bdad8e39-e6ea-408c-08f0-08da9aa8d253 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GuA6N/l+RmjfHeisFXZ0IqQRCe0iGjHJK/ZeEaqOtAyzQ3cLO0gZg2PQHeHXt0V+3jWH7Hit9jcKAmDYsw7VyBpIZugeL7aMnDBgFL+l2ocO0tkRZnl6l3XQ2Z5RaY/gc7NhGrxauDgiQfh41+FNsSck8OMsxe2qljvhHKkn/Pby/aWyHACt2kojeUuoKvo0WFg3NWepcJ0cvyyuomsNerQTMLS1MXVhnB+bprr2FSX/wHWkUWZUxGTUSuJ3I/CWX1ccvTiLSzkoQM6hqOfuQoL22Gj/VZJNk2OasAHyb6DrP8Ror9CbcWTivVoSwJf87tITwT4npGDqZFkOccnoXX3wRSN3ESlQzo3QOEs1FBheSNJ2RmH+MB4YPhNeXN0ceobOweiOthcjI81Rcea0PAjnb/vhbauilj7rSat6ZDnwdrMvuegLahysiqoNfJ4r0gjJ1dVptDIBoDmH5P3MAjMrMDiA5tAXozDS+G4NO+99Qa1y5ESzGicK05PEGDzWFWu0g1VyhtgPX+eUTuXJQPQGxop2QN9XFlcS3nsjA0RI0m4gqBq8wp2K621idJtSdHFn3mKIWnXuxSV19yjbh4xSs0y8r5hS7zDPEPVho/Q20c6PxBRcNcnBtR1vuFy8NdHJyaeze7iwzSajxD7AV0KyjJEckvSiyxysMHjxw6GxmJlypD4bRdGlnQZID9W/57hztHBo4pp/GCrkhouSQKC2Gdex1NHGTUew70PA3ikTo1BjKPGMZg7Ei+QJYPEXJgfdrTiChxIGCcbFPtFJJw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199015)(9686003)(38100700002)(26005)(122000001)(55016003)(64756008)(6506007)(8676002)(33656002)(76116006)(4326008)(2906002)(54906003)(41300700001)(38070700005)(7696005)(186003)(71200400001)(5660300002)(7416002)(478600001)(86362001)(8936002)(110136005)(316002)(66446008)(66556008)(66946007)(66476007)(83380400001)(66574015)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5692 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e33a9f31-f384-453b-4e8c-08da9aa8cda0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R2ET5PKeZkntyqm84g+s2CthHmv1mTD5FbPwTrYkqREkeR2LnbPZ+TAcoEdLgc6lxiaMR8AsKIe+lf79w1bx6qi8VLU8u2YVMWZYauTno8953L0Bjl1up9z+A2Hx//xOMH6j/FVIQ0qCskAWRwWwE2JzcWrBNPJCGKI/tvFTX/NmNMlSTUA8/PdeSYXsgobzWem67ByMYtvPbQ5fZ7WlXk+W7CSymf16pdqO14i/TTXMyyN/1fMyfV1lmRnfj+4J0v3KbjbHIcBWUVGC/KYck/xkEMQI+AsPrSwxD/WMkRo8HnJG4n1HKt2HJdkneOx+sq0joi9JemX3NLT8SPDFwLIMp2lltMgbsjTlQYjlu1/woLWRLCHQhw/rVYR9I6PzfNz7+BLm9pKN1u+IujPR2h2AXGh74gYCvISeJjkAB48mtZSO3g3yuHfLqaSGdFzDmtIO4PB49ruMeN3lL8XCo2168gNf4/uClYLArszjrlE9m/RJZPMAKWXfehSWlo7RaSbGMZNnUsGLSfPGXya2Cg7xcp335a41yngszIGjVOYdH/yxsjZJSluc77WmKovt6KF4zticjl4Djc0dBbzX6SBSWnlZHm7sTjxpJzejaHhkVnTdQdnFyyYMIRc31ZtxwLwBQ1txx4n+1uAwyCQBR/kmlhkWF1+H0GkNi3K5Uf8LxPbItARARlRl1yvhrlusnubdACu+6q3PSus0/h0vdOsb+peEUzvlcQDvvLjxSwPLWmJbzPeBQHx55iCMeCNFjfBdIYNjFvyoWY/xbzFCzQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(82310400005)(9686003)(26005)(81166007)(82740400003)(70586007)(40480700001)(55016003)(6506007)(36860700001)(8676002)(33656002)(4326008)(2906002)(54906003)(356005)(41300700001)(7696005)(186003)(47076005)(70206006)(5660300002)(478600001)(86362001)(8936002)(110136005)(316002)(83380400001)(66574015)(40460700003)(52536014)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 01:38:29.9088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bdad8e39-e6ea-408c-08f0-08da9aa8d253 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7423 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kg KDExKToNCj4gPiAgIGRyaXZlcnMvY2hhcjogYWxsb3cgdXNpbmcgYm90aCBkYmdwPXhoY2kgYW5k IGRiZ3A9ZWhjaQ0KPiA+ICAgSU9NTVU6IGFkZCBjb21tb24gQVBJIGZvciBkZXZpY2UgcmVzZXJ2 ZWQgbWVtb3J5DQo+ID4gICBJT01NVS9BTUQ6IHdpcmUgY29tbW9uIGRldmljZSByZXNlcnZlZCBt ZW1vcnkgQVBJDQo+ID4gICBkcml2ZXJzL2NoYXI6IG1hcmsgRE1BIGJ1ZmZlcnMgYXMgcmVzZXJ2 ZWQgZm9yIHRoZSBYSENJDQo+ID4gICBkcml2ZXJzL2NoYXI6IGFkZCBSWCBzdXBwb3J0IHRvIHRo ZSBYSENJIGRyaXZlcg0KPiA+ICAgZHJpdmVycy9jaGFyOiBmaXggaGFuZGxpbmcgY2FibGUgcmUt cGx1ZyBpbiBYSENJIGNvbnNvbGUgZHJpdmVyDQo+ID4gICBkcml2ZXJzL2NoYXI6IGFsbG93IGRy aXZpbmcgdGhlIHJlc3Qgb2YgWEhDSSBieSBhIGRvbWFpbiB3aGlsZSBYZW4gdXNlcw0KPiBEYkMN Cj4gPiAgIElPTU1VL1ZULWQ6IHdpcmUgY29tbW9uIGRldmljZSByZXNlcnZlZCBtZW1vcnkgQVBJ DQo+ID4gICBjb25zb2xlOiBzdXBwb3J0IG11bHRpcGxlIHNlcmlhbCBjb25zb2xlIHNpbXVsdGFu ZW91c2x5DQo+ID4gICBkcml2ZXJzL2NoYXI6IHN1c3BlbmQgaGFuZGxpbmcgaW4gWEhDSSBjb25z b2xlIGRyaXZlcg0KPiA+ICAgZHJpdmVycy9jaGFyOiBhZGQgY29uc29sZT1laGNpIGFzIGFuIGFs aWFzIGZvciBjb25zb2xlPWRiZ3ANCj4gDQo+IEhlbnJ5LA0KPiANCj4gdGhpcyBzZXJpZXMgaXMg a2luZCBvZiBvbiB0aGUgZWRnZSBiZXR3ZWVuIGEgZmVhdHVyZSBzdWJtaXNzaW9uIGFuZA0KPiBj b3JyZWN0aW9ucyB0byBleGlzdGluZyBjb2RlLCBhcyB0aGUgYmFzZSBwYXRjaCBpbnRyb2R1Y2lu ZyB0aGUgbmV3DQo+IGRyaXZlciB3YXMgbWVyZ2VkIG9ubHkgcmVjZW50bHksIGFuZCBhdCBsZWFz dCBzb21lIG9mIHRoZSB0aGluZ3MgaGVyZQ0KPiBhcmVuJ3QgY2xlYXJseSAiYnVnIiBmaXhlcy4g QWRkaXRpb25hbGx5IGl0J3Mgb24gdGhlIHNpZGUgb2YgbGFyZ2VyDQo+IG9uZXMgY29uc2lkZXJp bmcgdGhlIHBvaW50IGluIHRpbWUuDQo+IA0KPiBUbyBzdW1tYXJpemUgc3RhdGU6IFBhdGNoZXMg Mi03IGFyZSByZWFkeSB0byBiZSBjb21taXR0ZWQsIGFuZCBNYXJlaw0KPiB0ZWxscyBtZSB0aGF0 IHRoZXkncmUgaW5kZXBlbmRlbnQgb2YgcGF0Y2ggMSAoZXhjZXB0IGZvciBhIGNvbnRleHQNCj4g Y29uZmxpY3QpLiBQYXRjaCAxMSBwcm9iYWJseSBhbHNvIGZhbGxzIGluIHRoaXMgY2F0ZWdvcnku IFBhdGNoIDEwLA0KPiBvdG9oLCBpcyBwcmV0dHkgbGlrZWx5IHRvIGJlIHZpZXdlZCBhcyBhIG5l dyBmZWF0dXJlLCBhbmQgaGVuY2UNCj4gbGlrZWx5IHdhbnRzIHBvc3Rwb25pbmcuIEluIGFueSBl dmVudCAtIGlmIEkgd2FzIHRvIGNvbW1pdCBhbnkgb2YNCj4gdGhlc2UsIHRoaXMgY291bGRuJ3Qg aGFwcGVuIGVhcmxpZXIgdGhhbiBuZXh0IE1vbmRheSwgYXMgdGhlIGxhcHRvcA0KPiBJJ20gY3Vy cmVudGx5IHdvcmtpbmcgd2l0aCBpcyBub3QgKHlldCkgc2V0IHVwIHRvIGRvIGNvbW1pdHMgZnJv bS4NCj4gDQo+IERvIHlvdSBoYXZlIGFueSBwYXJ0aWN1bGFyIG9waW5pb24gb24gdGhlIGRpc3Bv c2l0aW9uIG9mIHRoaXMgc2VyaWVzPw0KDQpUaGFuayB5b3UgZm9yIHRoZSBpbmZvcm1hdGlvbiBh bmQgdGhlIGRldGFpbGVkIHN1bW1hcnkhDQoNCkZyb20gdGhlIGNvdmVyIGxldHRlciBhbmQgdGhl IHJpc2sgYW5hbHlzaXMgZnJvbSBNYXJlaywgSSBhbSBvayB0bw0KY29tbWl0IHBhdGNoICMyLSM3 IGFuZCBwYXRjaCMxMSwgYXMgbG9uZyBhcyB0aGV5IGFyZSBpbmRlcGVuZGVudA0KcGF0Y2hlcyBh bmQgd2lsbCBub3QgYnJlYWsgY3VycmVudCBkcml2ZXIuIFRoYW5rIHlvdSBmb3IgdGFraW5nIGNh cmUNCm9mIHRoZSBjb21taXR0aW5nIDopKQ0KDQpTaW5jZSBmcm9tIHRoZSBkaXNjdXNzaW9uIGVh cmxpZXIsIHRoZSByZWxlYXNlLWFjayB0YWcgaXMgYSBsaXR0bGUgYml0IHRvbw0KZWFybHkgaW4g dGhpcyBzdGFnZSwgaXQgaXMgdXAgdG8geW91IHRvIGFkZCB0aGUgcmVsZWFzZS1hY2sgdGFnIHdo ZW4geW91DQpkbyB0aGUgY29tbWl0dGluZy4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAN Cj4gVGhhbmtzLCBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 20 04:47:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 04:47:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409111.652006 (Exim 4.92) (envelope-from ) id 1oaVAT-0008UZ-Af; Tue, 20 Sep 2022 04:47:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409111.652006; Tue, 20 Sep 2022 04:47:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVAT-0008US-77; Tue, 20 Sep 2022 04:47:33 +0000 Received: by outflank-mailman (input) for mailman id 409111; Tue, 20 Sep 2022 04:47:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVAR-0008UM-Pt for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 04:47:31 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5460b3bb-389f-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 06:47:28 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so848025wmq.1 for ; Mon, 19 Sep 2022 21:47:28 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id t17-20020a5d6a51000000b0022a3517d3besm422533wrw.5.2022.09.19.21.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 21:47:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 5460b3bb-389f-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=KtR01irQlKfoVSoywg7Q8i2vGYnSpe0gOOi9G0TIGZk=; b=iy+ELMmiklQjwT1+jywydBJ5+uxMHApNzethnZSDLsOLcpqYwTl/L3jMA4qoDz8Vgt w+Zblb3q8eecZv5hoyVTkxAUKOUB7SjAcJt3mU0KYDPm/VaDxqRWiQ0wC9/zbVrZZis7 j9gdYkWkuaAmuo0z60zuslsYYToAfBKPXwZmVQJBEG5mP6JtBMvspJdkUhGczPVSyVLW AMWpvBS0kLE3Jl8TbBbkf0NLUdIlCsuxnOQtGToWq/POoImJ6W1ldYQRqwX3nm/fduu3 H7pHiAfteys/6W/f75pZmmz+EK8R5Vq1pd/eDZvZGiBh7iRrJr8vbFyQVn5huf1FeiG9 ojLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=KtR01irQlKfoVSoywg7Q8i2vGYnSpe0gOOi9G0TIGZk=; b=wIPYaNv9e63hHdqHoIDD42/RgoSySm/XH5pDfLUQmcoUvOe98cVRp5qS6/3QsQbR0R Cii5sCiIXnluVHaAvDOLDsMLu26QkXH6AqS8+4uPglICwpKjXaMXr+7XRIvc83Hknkdq GlEf4dGKbNqoRS3Fte2OSaVA42hCgEuNN8/GNNf5ErYBvQ87058SGuSXZJgqDNIPpbBt prX8zzm55B6hg2mLd8nduYBuuewM19CS8rj9NP9mmGGadW8Z1XHKNN06MrllD/39w5Tm 3sij7jgc+j+y0IZCZuho1v0KioSkZNmXCYuOHLVDNaFYR0LNd8KN6xxJkgHXPLIOne20 MXCA== X-Gm-Message-State: ACrzQf2cIK2FLuEB7TsXR1ZxIrn8JjkVsuRUUb7z4qUoHx43eg35VzeY 37C7eJnODh+B9qKV8ba1Dsc= X-Google-Smtp-Source: AMsMyM6/3r6XZlxjTcSgaP6bxzxf2Ik/wGOXJdYrZFcBlYSJNyYytY3sWi+uthO+WMCqXKrc3KkApA== X-Received: by 2002:a05:600c:3b94:b0:3b4:9cdc:dbd4 with SMTP id n20-20020a05600c3b9400b003b49cdcdbd4mr887376wms.159.1663649248092; Mon, 19 Sep 2022 21:47:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <86328362-ec6c-8ff5-7533-321f2eef86fe@amsat.org> Date: Tue, 20 Sep 2022 06:47:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org, Palmer Dabbelt Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-2-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/9/22 01:17, Bernhard Beschow wrote: > SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to > inherit from TYPE_MACHINE. This is an inconsistency which can cause > undefined behavior such as memory corruption. > > Change SiFiveEState to inherit from MachineState since it is registered > as a machine. > > Signed-off-by: Bernhard Beschow > --- > include/hw/riscv/sifive_e.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/hw/riscv/sifive_e.h b/include/hw/riscv/sifive_e.h > index 83604da805..d738745925 100644 > --- a/include/hw/riscv/sifive_e.h > +++ b/include/hw/riscv/sifive_e.h > @@ -22,6 +22,7 @@ > #include "hw/riscv/riscv_hart.h" > #include "hw/riscv/sifive_cpu.h" > #include "hw/gpio/sifive_gpio.h" > +#include "hw/boards.h" > > #define TYPE_RISCV_E_SOC "riscv.sifive.e.soc" > #define RISCV_E_SOC(obj) \ > @@ -41,7 +42,7 @@ typedef struct SiFiveESoCState { > > typedef struct SiFiveEState { > /*< private >*/ > - SysBusDevice parent_obj; > + MachineState parent_obj; Ouch. Fixes: 0869490b1c ("riscv: sifive_e: Manually define the machine") Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Tue Sep 20 04:51:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 04:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409117.652016 (Exim 4.92) (envelope-from ) id 1oaVDn-0001RD-Q3; Tue, 20 Sep 2022 04:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409117.652016; Tue, 20 Sep 2022 04:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVDn-0001R6-N3; Tue, 20 Sep 2022 04:50:59 +0000 Received: by outflank-mailman (input) for mailman id 409117; Tue, 20 Sep 2022 04:50:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVDl-0001R0-S3 for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 04:50:57 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0625675-389f-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 06:50:57 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id n12so2282556wrx.9 for ; Mon, 19 Sep 2022 21:50:56 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c154c00b003a62052053csm20902170wmg.18.2022.09.19.21.50.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 21:50:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d0625675-389f-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=AOjdR7SFZiHY1uiELRpo0rpHv870srIhKUXZHTwkqUI=; b=MfFJU2m3Hp+LpkC7yASngF/y3vweUTL23ftLfII94KRq1fh9uTp6TvbPfhA5JM7g/4 BVreu+b5bogN3xvS5EzGpIbQ3ng9dHhuRm5e0Vic64Hq0UMgtlOEtv6O2XVqLujTsiv+ 6KwJpHbGhyeJM9cFKDzK2kyye8yL1PlPeQc88f8cJP9g1alsMDm8NjaIbYUlA7jlTSSm LQm1oSmvlVAB4NutamOypWH24lc9dzVMwaSgX/dOayiJh8AZara/qgGIpz+9dkwcj6y7 O5rpwXra/Dcl72TDHgcZpvuttTtBdPNyqw9sm6ljJOpkgbDiG4P62kLG+lMBo2jwJzze Fw0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=AOjdR7SFZiHY1uiELRpo0rpHv870srIhKUXZHTwkqUI=; b=i2J7LilaL12NzSruKT29rgYmO5Q7sIowmxW3/bsG/B1aYFZz5eskBdDqhbf64PVKuJ X9+cF79sGoQr5f1S8eY5uKrZGnwyXc6QfBWBtjHqwQL4ZHgPwgfvy6MgbvbO9qIkvvGb 3MuVvdauapwdtrSAiu5YKTOTD4J7ClsXpAskDQaGdgOAdiJKDk0/tmq/nlD3eGZSlsBe A1rE5i1prc5lbYtBDhqyqfHR/k5vGZxh6DODyVrnEmpkGbvU95CoItU1wG6VG08Vzvv6 6jdXKazzZuLbYC0j+9R5v2gC5E2898Js9v/qn3fqOcybNLduDkRnlAjqNFzDvHFDxgiH YW5A== X-Gm-Message-State: ACrzQf23CFdJUr71f3knnBhmZw4YgHIeqDMvoVu9pzaEyqQjJpyNtrEU adR2RtIzKYqhrtSXsKKxWEg= X-Google-Smtp-Source: AMsMyM5Zw3Yb5SwTXaejaf1oX7/x3SNh9tZo3tfn0QC4ZXWZZxDxIYm9wdK1FGZNM51fQBEYeXIOWA== X-Received: by 2002:a5d:550c:0:b0:22b:1942:4bf6 with SMTP id b12-20020a5d550c000000b0022b19424bf6mr190273wrv.520.1663649456084; Mon, 19 Sep 2022 21:50:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <3fcb707c-47c3-7696-86ec-62048e39bfe1@amsat.org> Date: Tue, 20 Sep 2022 06:50:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/9] exec/hwaddr.h: Add missing include Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-3-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-3-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/9/22 01:17, Bernhard Beschow wrote: > The next commit would not compile w/o the include directive. > > Signed-off-by: Bernhard Beschow > --- > include/exec/hwaddr.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h > index 8f16d179a8..616255317c 100644 > --- a/include/exec/hwaddr.h > +++ b/include/exec/hwaddr.h > @@ -3,6 +3,7 @@ > #ifndef HWADDR_H > #define HWADDR_H > > +#include "qemu/osdep.h" NAck: This is an anti-pattern. "qemu/osdep.h" must not be included in .h, only in .c. Isn't including "hw/qdev-core.h" in "include/hw/boards.h" enough in the next patch? From xen-devel-bounces@lists.xenproject.org Tue Sep 20 04:53:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 04:53:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409124.652027 (Exim 4.92) (envelope-from ) id 1oaVFk-00025E-AX; Tue, 20 Sep 2022 04:53:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409124.652027; Tue, 20 Sep 2022 04:53:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVFk-000257-7m; Tue, 20 Sep 2022 04:53:00 +0000 Received: by outflank-mailman (input) for mailman id 409124; Tue, 20 Sep 2022 04:52:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVFj-000251-DP for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 04:52:59 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18e11a88-38a0-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 06:52:58 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id n10so2264155wrw.12 for ; Mon, 19 Sep 2022 21:52:58 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003b477532e66sm1328087wmq.2.2022.09.19.21.52.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 21:52:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 18e11a88-38a0-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=yXWBrA+VdOJ2eLhZR3jbWLCq6szWmV0B8FUoTOgqB0Y=; b=aJV1CFqMLGvYtz55pBXOVpWmVSQoYNCnNBeTgMiTAsRFuzH5R6W2APpLLxvjT8WmD4 +Aq7iwdNNrStFOY9aOqRysX4Fi1hb2Ai05q9KoqfdPoBoG8CctBSGiXnl5/iVsdJ+gtv G1xO0rGV43OaEcuEgmtP7LmuG+YfSqRa24lK6FNEcUouwvSx2/shKBcNCI2GLEjS+cs3 iopHzNjcN5/YTwRaIMxWArxIjRTpTenXmoMfOgDIkxoUoUYf8tucr0luciR3FCLpBLPl nYQ3yr3DJaimwbslpab29lcOYdhw+Pw4taR5Nq2MUO+stSchiopNm0u210j4zdGi4ZvP JV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=yXWBrA+VdOJ2eLhZR3jbWLCq6szWmV0B8FUoTOgqB0Y=; b=StTFxszMveJPro+C9uwxxNoaaDRAs4OlKpVNlAoT2C/PgPbZAGYRyGoqKh15w+RVIm MF8LhuB7Qiq2Z+y7lfCDSoSMe05g+s7AyszMZgmSuY/bVsFWULpwYg3lke7rwctN03+V Fu/TsRwv4+fVwzs1fIn1BpL3CfDln2tv3jDgoyE7xgdVMZDTQjCnevm3SEK272UVVTTO hsPCeZd5Y+C05OT/F8jVY5dsRE3b7bU6aSiCtwNcxVuH4VriF59s05Dm8RHW3rhXB0RV XuohUW7k0hb8/rFbdC2ukSHKpZakLyXsl6jpkAMnp3o4RpilIgX6g7vzKyWxrd90rfGU EiHQ== X-Gm-Message-State: ACrzQf16/PK6ss+O3zEDgkpVYXNPowAw74FptSLIyEeX4u98YQbKkVAu iRgjta7GAdnTtkxcbVVhksM= X-Google-Smtp-Source: AMsMyM6arlbxvVjWRWfyODWA+1XBF2D6twCUtKI65uSf3S2vAcndKsZknTjHvTjJhdM7wtQh4z6qXA== X-Received: by 2002:a5d:4284:0:b0:22a:291e:fa8f with SMTP id k4-20020a5d4284000000b0022a291efa8fmr12816362wrq.553.1663649577762; Mon, 19 Sep 2022 21:52:57 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <6af33d73-1e34-304d-998f-a46c8c05f4bb@amsat.org> Date: Tue, 20 Sep 2022 06:52:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 3/9] hw/core/sysbus: Resolve main_system_bus singleton Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-4-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-4-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/9/22 01:17, Bernhard Beschow wrote: > In QEMU, a machine and the main_system_bus always go togehter. Usually > the bus is part of the machine which suggsts to host it there. "together", "suggests" > Since tere is already a current_machine singleton, all code that > accesses the main_system_bus can be changed (behind the scenes) to go > through current_machine. This resolves a singleton. Futhermore, by "Furthermore" > reifying it in code, the every-machine-has-exactly-one-main-system-bus > relationship becomes very obvious. > > Note that the main_system_bus attribute is a value rather than a > pointer. This trades pointer dereferences for pointer arithmetic. The > idea is to reduce cache misses - a rule of thumb says that > every pointer dereference causes a cache miss while arithmetic is > basically free. > > Signed-off-by: Bernhard Beschow > --- > hw/core/bus.c | 5 ++++- > hw/core/machine.c | 3 +++ > hw/core/sysbus.c | 22 +++++----------------- > include/hw/boards.h | 1 + > 4 files changed, 13 insertions(+), 18 deletions(-) > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 311ed17e18..7af940102d 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h Likely missing the BusState declaration: #include "hw/qdev-core.h" > @@ -346,6 +346,7 @@ struct MachineState { > */ > MemoryRegion *ram; > DeviceMemoryState *device_memory; > + BusState main_system_bus; > > ram_addr_t ram_size; > ram_addr_t maxram_size; From xen-devel-bounces@lists.xenproject.org Tue Sep 20 04:57:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 04:57:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409129.652038 (Exim 4.92) (envelope-from ) id 1oaVKE-0002mI-SV; Tue, 20 Sep 2022 04:57:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409129.652038; Tue, 20 Sep 2022 04:57:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVKE-0002mB-Pv; Tue, 20 Sep 2022 04:57:38 +0000 Received: by outflank-mailman (input) for mailman id 409129; Tue, 20 Sep 2022 04:57:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVKE-0002m5-6M for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 04:57:38 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf193eaf-38a0-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 06:57:37 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id t7so2292675wrm.10 for ; Mon, 19 Sep 2022 21:57:37 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id c3-20020a05600c0a4300b003b47ff307e1sm749536wmq.31.2022.09.19.21.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 21:57:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: bf193eaf-38a0-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=sf+yjXUZ2IXukhH5UaeERJtNyhl+QRIlnvPlc0mykq8=; b=INBRXUtTn4f77El/2/P3WXjwa3VcUTxtrP1wFIDUvyAEGQuR4JdU8p5dXhkW+WOyoi aoucRXOyi92aAnFe7bOLEAZibHBlkHtvFejKVFbXmRBMjzPIh0QtKo5E1ehhEN3by8eV 17JDnHMtDeKFLvdX8LOcEdcAGUaBlxldWLzJeEDB059E3k0gVClrPR8sLUj64MYCBXPW U4IWEn9NgUDZaS84v7Xcnwa8N50RXPQuuOzX7HKjzYTF1wFu0KvbUzVHydFrkNBQIdcj 7SYes6exvX/5Vh89DdneU4padIai8aVEZ3yvM9L6bEsaMF8cH4VwUMhR2Fe4nYLK5lrT f3Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=sf+yjXUZ2IXukhH5UaeERJtNyhl+QRIlnvPlc0mykq8=; b=CMCqwRiwmEPA/qp27iaE1sdTjmxlUH14I9fbpizK+pSsMpbQeVWzE+1QTxGf+8kpeO kQLOEoMX3d17CwOF1+fJ1XIhCzj1B1ZfeFyKiuhJJm8kMkJQknGlBCDEarhwru72oWgE kFbBYcTJrh9VWZvActQCxpZGJyeJqXJ1xD9ckTjFsLgHOX36Bo1XN+487xR5DrZozld7 odN3y00syif+MpHxHY9hYnfuh+LE/QKb21+6oNPHlztSegFX6OTH5wo0S4zPLsMd6/Xq ParfJ+fOQ+jB3nQEf4ocxzVn3oXOjMIRYRBk7FutAsHFaU3SuPnQWcJleXpWMudruLaD v3Eg== X-Gm-Message-State: ACrzQf2abCe7ikURp4ZtSUTOTzvnwO04SL3d5TTQAGe9jnjt05cpI1UJ E5BQX3f4y3BQ0VsGbqJmkow= X-Google-Smtp-Source: AMsMyM7xk9eQhMG0hy5vzO0uxqQyyAFLD2EaloYjIUcvuXMcivTCqCiOehaR1VmADyoWYmuRlw8Yow== X-Received: by 2002:a5d:4d4e:0:b0:22a:e7fe:e3bd with SMTP id a14-20020a5d4d4e000000b0022ae7fee3bdmr9244091wru.311.1663649856601; Mon, 19 Sep 2022 21:57:36 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <07db3f3a-90d9-c0db-df26-de7a667620be@amsat.org> Date: Tue, 20 Sep 2022 06:57:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 6/9] target/loongarch/cpu: Remove unneeded include directive Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-7-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-7-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/9/22 01:17, Bernhard Beschow wrote: > The cpu is used in both user and system emulation context while sysbus.h > is system-only. Remove it since it's not needed anyway. Furthermore, it > would cause a compile error in the next commit. > > Signed-off-by: Bernhard Beschow > --- > target/loongarch/cpu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h > index dce999aaac..c9ed2cb3e7 100644 > --- a/target/loongarch/cpu.h > +++ b/target/loongarch/cpu.h > @@ -13,7 +13,6 @@ > #include "hw/registerfields.h" > #include "qemu/timer.h" > #include "exec/memory.h" > -#include "hw/sysbus.h" > > #define IOCSRF_TEMP 0 > #define IOCSRF_NODECNT 1 Renaming the subject as 'target: Remove unneeded "hw/sysbus.h" include directive' and fixing target/ppc/kvm.c: Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Tue Sep 20 05:12:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 05:12:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409134.652050 (Exim 4.92) (envelope-from ) id 1oaVY6-0005PV-2z; Tue, 20 Sep 2022 05:11:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409134.652050; Tue, 20 Sep 2022 05:11:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVY6-0005PO-0A; Tue, 20 Sep 2022 05:11:58 +0000 Received: by outflank-mailman (input) for mailman id 409134; Tue, 20 Sep 2022 05:11:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVY4-0005PH-Ti for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 05:11:56 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bec36bc4-38a2-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 07:11:55 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id t7so2327424wrm.10 for ; Mon, 19 Sep 2022 22:11:55 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id y12-20020adfe6cc000000b0022a293ab1e9sm452848wrm.11.2022.09.19.22.11.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 22:11:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: bec36bc4-38a2-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=pnla9efotYFd/3Jw4qRJIL4xlOWxFHoq332oc/9bbqo=; b=WvvRv/4VUhzyb4J7QRcwkeJBidNZGJR96FFEPsAXWbf8VLcpCXht2BEDjJNBcmmf4q B9BYrOZLleB7KiX3SS/A3sJvc264Ej3tiwc3zGaUvi5i726p0npX6EaT2nlzWeA2+YFX 8GTlDoczWFQldhtWnsIUiRTYwYsgNJm3kyA/24figJL3TCNySpOfwDjd3289KgW1XDyL ERzD6kKsPvOAQCvh+laZl5zPT/ZSZiZs1LcmpHaoACHzTBRIGuB5hrb+MzvGTkUhNaoj 4ok/LujOcM0U/ZAvrwSbQDTdue9Vb6REatLt7pz9bKtwK5aVEYH2l8wALn4jushh7SCo jWTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=pnla9efotYFd/3Jw4qRJIL4xlOWxFHoq332oc/9bbqo=; b=7G8T7A96wz+TuokV+/b3FXyzH8G+FsTJ/VyihiAb4wTTlkVis4KblWMGlxfeKG01S2 cYSSxCzLCrJxg7422Ym+TnePmIFDuwhkjLgczo6EtVkT4RgcRQL8HBYBjEGoerSZvMXP xA1JGSG7MYlKAXDQCQxCFA3oAqxm6BwMNeYtwpICJkQmjVtVuZEmnizz5SkzlUjYepEM PMs3CWiGzqrMAPPEUvxzjVWLKwC/Y6S9QWiBGatm0qm1F4nWqa3npETyR6bD2itt+J18 hc7qJX1M0GryvDlpuduysExQzNBxK5GMU+wkw8swQbMScLdFBvaIkes4JQjLr/0V+xH1 paMw== X-Gm-Message-State: ACrzQf2GSEgpY0ZafLcprK1l9Lbp4RUEiPh2JEMkdguNy0ak/P585/sG SRtdYlH3utekLndL7ut9RHE= X-Google-Smtp-Source: AMsMyM68Pblt5BIGotnw6q4CbijQ/TryMLJf4D1jxUGITEtnEY/vODYKCiaQW21HjH1kYP7yEoWclA== X-Received: by 2002:a5d:6147:0:b0:22a:6035:a878 with SMTP id y7-20020a5d6147000000b0022a6035a878mr12295976wrt.528.1663650715031; Mon, 19 Sep 2022 22:11:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: Date: Tue, 20 Sep 2022 07:11:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 8/9] softmmu/physmem: Let SysBusState absorb memory region and address space singletons Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-9-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-9-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/9/22 01:17, Bernhard Beschow wrote: > These singletons are actually properties of the system bus but so far it > hasn't been modelled that way. Fix this to make this relationship very > obvious. > > The idea of the patch is to restrain futher proliferation of the use of > get_system_memory() and get_system_io() which are "temprary interfaces" "further", "temporary" > "until a proper bus interface is available". This should now be the > case. > > Note that the new attributes are values rather than a pointers. This > trades pointer dereferences for pointer arithmetic. The idea is to > reduce cache misses - a rule of thumb says that every pointer > dereference causes a cache miss while arithmetic is basically free. > > Signed-off-by: Bernhard Beschow > --- > include/exec/address-spaces.h | 19 ++++++++++++--- > include/hw/sysbus.h | 6 +++++ > softmmu/physmem.c | 46 ++++++++++++++++++----------------- > 3 files changed, 45 insertions(+), 26 deletions(-) > > diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h > index d5c8cbd718..b31bd8dcf0 100644 > --- a/include/exec/address-spaces.h > +++ b/include/exec/address-spaces.h > @@ -23,17 +23,28 @@ > > #ifndef CONFIG_USER_ONLY > > -/* Get the root memory region. This interface should only be used temporarily > - * until a proper bus interface is available. > +/** > + * Get the root memory region. This is a legacy function, provided for > + * compatibility. Prefer using SysBusState::system_memory directly. > */ > MemoryRegion *get_system_memory(void); > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h > index 5bb3b88501..516e9091dc 100644 > --- a/include/hw/sysbus.h > +++ b/include/hw/sysbus.h > @@ -17,6 +17,12 @@ struct SysBusState { > /*< private >*/ > BusState parent_obj; > /*< public >*/ > + > + MemoryRegion system_memory; > + MemoryRegion system_io; > + > + AddressSpace address_space_io; > + AddressSpace address_space_memory; Alternatively (renaming doc accordingly): struct { MemoryRegion mr; AddressSpace as; } io, memory; > }; > > #define TYPE_SYS_BUS_DEVICE "sys-bus-device" > diff --git a/softmmu/physmem.c b/softmmu/physmem.c > index 0ac920d446..07e9a9171c 100644 > --- a/softmmu/physmem.c > +++ b/softmmu/physmem.c > @@ -86,12 +86,6 @@ > */ > RAMList ram_list = { .blocks = QLIST_HEAD_INITIALIZER(ram_list.blocks) }; > > -static MemoryRegion *system_memory; > -static MemoryRegion *system_io; > - > -static AddressSpace address_space_io; > -static AddressSpace address_space_memory; > - > static MemoryRegion io_mem_unassigned; > > typedef struct PhysPageEntry PhysPageEntry; > @@ -146,7 +140,7 @@ typedef struct subpage_t { > #define PHYS_SECTION_UNASSIGNED 0 > > static void io_mem_init(void); > -static void memory_map_init(void); > +static void memory_map_init(SysBusState *sysbus); > static void tcg_log_global_after_sync(MemoryListener *listener); > static void tcg_commit(MemoryListener *listener); > > @@ -2667,37 +2661,45 @@ static void tcg_commit(MemoryListener *listener) > tlb_flush(cpuas->cpu); > } > > -static void memory_map_init(void) > +static void memory_map_init(SysBusState *sysbus) > { No need to pass a singleton by argument. assert(current_machine); You can use get_system_memory() and get_system_io() in place :) LGTM otherwise, great! > - system_memory = g_malloc(sizeof(*system_memory)); > + MemoryRegion *system_memory = &sysbus->system_memory; > + MemoryRegion *system_io = &sysbus->system_io; > > memory_region_init(system_memory, NULL, "system", UINT64_MAX); > - address_space_init(&address_space_memory, system_memory, "memory"); > + address_space_init(&sysbus->address_space_memory, system_memory, "memory"); > > - system_io = g_malloc(sizeof(*system_io)); > memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io", > 65536); > - address_space_init(&address_space_io, system_io, "I/O"); > + address_space_init(&sysbus->address_space_io, system_io, "I/O"); > } > > MemoryRegion *get_system_memory(void) > { > - return system_memory; > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.system_memory; > } > > MemoryRegion *get_system_io(void) > { > - return system_io; > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.system_io; > } > > AddressSpace *get_address_space_memory(void) > { > - return &address_space_memory; > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.address_space_memory; > } > > AddressSpace *get_address_space_io(void) > { > - return &address_space_io; > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.address_space_io; > } From xen-devel-bounces@lists.xenproject.org Tue Sep 20 05:16:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 05:16:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409143.652061 (Exim 4.92) (envelope-from ) id 1oaVc0-000644-Jl; Tue, 20 Sep 2022 05:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409143.652061; Tue, 20 Sep 2022 05:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVc0-00063x-G0; Tue, 20 Sep 2022 05:16:00 +0000 Received: by outflank-mailman (input) for mailman id 409143; Tue, 20 Sep 2022 05:15:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVbz-00063r-BC for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 05:15:59 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f5f1732-38a3-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 07:15:58 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id y5so2411586wrh.3 for ; Mon, 19 Sep 2022 22:15:58 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id t1-20020adfdc01000000b002252ec781f7sm480793wri.8.2022.09.19.22.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 22:15:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 4f5f1732-38a3-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=zoCj17/FoLXwtexZcC8HC08ap2gyp0m31eL5ZvThkKo=; b=R32rY7NSj7Fx9wnIFsIakEDibCO9xnK1hZUIT2HKqPdw/Ary8UunlhchQEe50uZAKt IcHwDoHg8BNyr+4XdYGESfHcm//PXvOEVjvXhZPD7y8P5Fpsvk8XUpPTrNV902a8L/l1 kcrrndYyNFP2f9XhMPsIOO8AQ/iM1BglRxvcvsKItT0E660ecmBZDaSsn0HIoqSf61pq K8m/cNkANRYMDuR3+HLK4MzuEAvEdEvPrSnSDqRQAwpf1NMYx6hw3Df9VJdBqPRBqe1C BtFe2Lxkcsnodwk0vjI79xEIH7dEOtyIxG8EM0q8g5XNnP9vD2TPzFgVglIz9uW5QTr9 RzWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=zoCj17/FoLXwtexZcC8HC08ap2gyp0m31eL5ZvThkKo=; b=fqI1r7pxLd/ffzC8/XlcYmdYreNlKpJQV03cBYiqFy9MYc7ml3WlVJg4BeQyvWtKx6 0jZ2MGydJMi5gT5RQf65wXl+9w5EuMbK19qAbzmBRilXeS4k2Pwbq0hbjM107w2TrVZa SgrvWP/qCi6GOVsE8bBGUwizROQWUlUTKM4hs5TuaH0ihxmpOFOAzEIRaOPECj9vig/z d8cKHfrgxf1JzJgxxuskJ56TF/bDDgZdTNG9ETnwEAd4L69Ccc0i7lc2WH2jXO8nmudH H/7rrXqVIp5tqXJk5YjHhleb8It5V7N31E5qAVqgTEJJc2sqY+s8LYq/K5FVnj2aTpC2 83bg== X-Gm-Message-State: ACrzQf22F7hDbb776Sq2E7EN0QvJN8n+XbE+IZ0nVxqWrIyl42Z1Tjfe uhCC8fIQEQC2vVIA5B3QkU8= X-Google-Smtp-Source: AMsMyM765pemA7LP3GGPKGAEZ4snxehIWXXseDoYmmmzhMIFFSLEBCiGTStpb6E6ujtqvUpeq7Gp3g== X-Received: by 2002:a05:6000:2a7:b0:22a:f98f:b75f with SMTP id l7-20020a05600002a700b0022af98fb75fmr6627886wry.373.1663650957809; Mon, 19 Sep 2022 22:15:57 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: Date: Tue, 20 Sep 2022 07:15:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 9/9] exec/address-spaces: Inline legacy functions Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-10-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-10-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/9/22 01:17, Bernhard Beschow wrote: > The functions just access a global pointer and perform some pointer > arithmetic on top. Allow the compiler to see through this by inlining. I thought about this while reviewing the previous patch, ... > Signed-off-by: Bernhard Beschow > --- > include/exec/address-spaces.h | 30 ++++++++++++++++++++++++++---- > softmmu/physmem.c | 28 ---------------------------- > 2 files changed, 26 insertions(+), 32 deletions(-) > > diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h > index b31bd8dcf0..182af27cad 100644 > --- a/include/exec/address-spaces.h > +++ b/include/exec/address-spaces.h > @@ -23,29 +23,51 @@ > > #ifndef CONFIG_USER_ONLY > > +#include "hw/boards.h" ... but I'm not a fan of including this header here. It is restricted to system emulation, but still... Let see what the others think. > /** > * Get the root memory region. This is a legacy function, provided for > * compatibility. Prefer using SysBusState::system_memory directly. > */ > -MemoryRegion *get_system_memory(void); > +inline MemoryRegion *get_system_memory(void) > +{ > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.system_memory; > +} > > /** > * Get the root I/O port region. This is a legacy function, provided for > * compatibility. Prefer using SysBusState::system_io directly. > */ > -MemoryRegion *get_system_io(void); > +inline MemoryRegion *get_system_io(void) > +{ > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.system_io; > +} > > /** > * Get the root memory address space. This is a legacy function, provided for > * compatibility. Prefer using SysBusState::address_space_memory directly. > */ > -AddressSpace *get_address_space_memory(void); > +inline AddressSpace *get_address_space_memory(void) > +{ > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.address_space_memory; > +} > > /** > * Get the root I/O port address space. This is a legacy function, provided > * for compatibility. Prefer using SysBusState::address_space_io directly. > */ > -AddressSpace *get_address_space_io(void); > +inline AddressSpace *get_address_space_io(void) > +{ > + assert(current_machine); > + > + return ¤t_machine->main_system_bus.address_space_io; > +} > > #endif > > diff --git a/softmmu/physmem.c b/softmmu/physmem.c > index 07e9a9171c..dce088f55c 100644 > --- a/softmmu/physmem.c > +++ b/softmmu/physmem.c > @@ -2674,34 +2674,6 @@ static void memory_map_init(SysBusState *sysbus) > address_space_init(&sysbus->address_space_io, system_io, "I/O"); > } > > -MemoryRegion *get_system_memory(void) > -{ > - assert(current_machine); > - > - return ¤t_machine->main_system_bus.system_memory; > -} > - > -MemoryRegion *get_system_io(void) > -{ > - assert(current_machine); > - > - return ¤t_machine->main_system_bus.system_io; > -} > - > -AddressSpace *get_address_space_memory(void) > -{ > - assert(current_machine); > - > - return ¤t_machine->main_system_bus.address_space_memory; > -} > - > -AddressSpace *get_address_space_io(void) > -{ > - assert(current_machine); > - > - return ¤t_machine->main_system_bus.address_space_io; > -} > - > static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, > hwaddr length) > { From xen-devel-bounces@lists.xenproject.org Tue Sep 20 05:30:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 05:30:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409150.652071 (Exim 4.92) (envelope-from ) id 1oaVpR-0007eG-UE; Tue, 20 Sep 2022 05:29:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409150.652071; Tue, 20 Sep 2022 05:29:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVpR-0007e9-RP; Tue, 20 Sep 2022 05:29:53 +0000 Received: by outflank-mailman (input) for mailman id 409150; Tue, 20 Sep 2022 05:29:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVpQ-0007e0-8i for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 05:29:52 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3fba9b16-38a5-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 07:29:51 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id y5so2444527wrh.3 for ; Mon, 19 Sep 2022 22:29:51 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id t18-20020adfdc12000000b0022762b0e2a2sm510363wri.6.2022.09.19.22.29.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 22:29:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 3fba9b16-38a5-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=vLavNPct5HZ2zw6lCN44DF82TIWb7S+NcGLLhGiFgbY=; b=EK29FpxAwJTevxxTP1Jl5+8Y1nnFTDF4cikh0gdLoXjAqssLIc3NK6aJqtIC/sl76l dQN74iwKJIJ8m0vzpT+oBMXb5MWlRMSIdHBzXKYK5Up+7xMeAWU2OrFa0PkuuSntFnfD X7ztP7+ETA8Fnzon/RDPQskBBm2PsWXO/DiTgFqR7DYzUYuJeytUDF0rJT4iCR/ALlAA RNwcv8k60hb5BUXFwIL4fqj+86FL8NznWTo23V8HDCS9Sc8g3g84j4YS3ADG95ZJ5qc0 HY0W7gF2cKRT2O+FinLEbnd2WC7FWDJUGcCanGw3nw0m2niEWG4+ilLXeWs4pDnNwah0 Td6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=vLavNPct5HZ2zw6lCN44DF82TIWb7S+NcGLLhGiFgbY=; b=vaqYOl7d58NCNJ7xLmS77CWfvHAQkcPWly4fEyHOfOSdRTb22H6vHDEkuw4a+f4blR gdeFBxU1ce/RNyPwl6IBChlsYgQ4iLXSFaBMIGgwJtVXn7MiiC1bWRZyuAVdG+IrBMFD QyZxqKiEtMtW2/P8MVivqIMoCs0/2mC1PQ2/GHW1dq+k4+K995GWY3QkBSGGT3/qScqY 7Il1xiIKq0COIvmTEHzpj4SpAqdtk0Sf4A7sm5hTG3t33YExj4Q0OCL0ei6kqbFDNRWO dIUE9h+1J5HM3BZf2D3QT7B+miD8pF2N1AAe6M4gzWMhN3skpQCVnAXRsvNGW4a3FrhL bOgw== X-Gm-Message-State: ACrzQf0gj7KyoJKuF9/ZCv3KenwF3/diaNtHzCA+r/9mZS1zACd95IXU hH8fRd7jSF1LIo5ygpBol40= X-Google-Smtp-Source: AMsMyM7ISxf8TowQHPXzwCB3gJbnhv9fjXayvDOx/H9iOPRnaX40Rdq5is+DoWs7bHq7Ygny4DwhKA== X-Received: by 2002:adf:eec3:0:b0:22a:d159:456c with SMTP id a3-20020adfeec3000000b0022ad159456cmr12283036wrp.463.1663651790518; Mon, 19 Sep 2022 22:29:50 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <63a4afba-546b-5c4c-94f8-c689b8fa0e0b@amsat.org> Date: Tue, 20 Sep 2022 07:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 9/9] exec/address-spaces: Inline legacy functions Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-10-shentey@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/9/22 07:15, Philippe Mathieu-Daudé wrote: > On 20/9/22 01:17, Bernhard Beschow wrote: >> The functions just access a global pointer and perform some pointer >> arithmetic on top. Allow the compiler to see through this by inlining. > > I thought about this while reviewing the previous patch, ... > >> Signed-off-by: Bernhard Beschow >> --- >>   include/exec/address-spaces.h | 30 ++++++++++++++++++++++++++---- >>   softmmu/physmem.c             | 28 ---------------------------- >>   2 files changed, 26 insertions(+), 32 deletions(-) >> >> diff --git a/include/exec/address-spaces.h >> b/include/exec/address-spaces.h >> index b31bd8dcf0..182af27cad 100644 >> --- a/include/exec/address-spaces.h >> +++ b/include/exec/address-spaces.h >> @@ -23,29 +23,51 @@ >>   #ifndef CONFIG_USER_ONLY >> +#include "hw/boards.h" > > ... but I'm not a fan of including this header here. It is restricted to > system emulation, but still... Let see what the others think. > >>   /** >>    * Get the root memory region.  This is a legacy function, provided for >>    * compatibility. Prefer using SysBusState::system_memory directly. >>    */ >> -MemoryRegion *get_system_memory(void); >> +inline MemoryRegion *get_system_memory(void) >> +{ >> +    assert(current_machine); >> + >> +    return ¤t_machine->main_system_bus.system_memory; >> +} Maybe we can simply declare them with __attribute__ ((const)) in the previous patch? See https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes From xen-devel-bounces@lists.xenproject.org Tue Sep 20 05:36:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 05:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409156.652083 (Exim 4.92) (envelope-from ) id 1oaVvb-0000h3-KS; Tue, 20 Sep 2022 05:36:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409156.652083; Tue, 20 Sep 2022 05:36:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVvb-0000gw-Gu; Tue, 20 Sep 2022 05:36:15 +0000 Received: by outflank-mailman (input) for mailman id 409156; Tue, 20 Sep 2022 05:36:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVva-0000gq-Ml for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 05:36:14 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23c3090b-38a6-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 07:36:13 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id c11so2374924wrp.11 for ; Mon, 19 Sep 2022 22:36:13 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id u16-20020a05600c035000b003b492753826sm804412wmd.43.2022.09.19.22.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 22:36:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 23c3090b-38a6-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=IZ5Zv4/7hTO/6wXmRF3z+PXEnTdcge7XTl0lYv1HpKI=; b=b0lsnmuCPz8cDwBFaPfL1ExlL6hZoGBvsAo90EdbWfbIty8yoFPD3+pM+wCc6r61jh 02HNF8QWjamjJ/5XkxHcwZWxllIZeCL3Ej0ajT59Sui+41jMg10A8+RqC1gMCPSMNtsr Ynq/WHREdM5adnH2c34ZUcVa02IKeDn0yv7w2JXYtOXYSOzmC9i4UAlhnWs8IdBRdaKj +EoC2mIXhoHnXN/nP7wSPWSC/fSlPbfxoLGWA4NiqceL28aaTcdr66NmRjIBw+kyTQ0O 3ODJqwU5La/Ozm1eqms4cfz6/VM9dp4JBRM4j1m070bia2cnFcYGHu8fJFoQ3iRtxQbn S8QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=IZ5Zv4/7hTO/6wXmRF3z+PXEnTdcge7XTl0lYv1HpKI=; b=BX6fz31AseqDFQFsdlTAhB//i7o2pqmtBwTBSlxwJ5pQmeSFBruehDwEXnqeqlLaEE EvwTCtlfghOXfOuFefEkuf8S1RpPRS9v1QsLYx4Mh3nckO7lw0ha6v1EAiO5V77rW27D FBEFr9/EEow9Ppeme/JX+ei2f/uxO9MnRIBy8mIj9WLVTsVrQvgukZuwE++iLVkD+Kq3 mS1AKDC+OuovTmDHe2zKd4CR5yGFEp4jPTkY7ZMzNcV5Z/f3nzERQtv1aki1gw4EowID N/lGdtvKrixCggR3Msc5oGua+OY9/smLa7/MVE2xG5rBexTeKEcx3xjoD8aDWZygQ3MF 2qiA== X-Gm-Message-State: ACrzQf0pQ/Optfizpl/3BZDtNKk32p+inkYjfdqu6ReAXfT+VOD07xbS Q6N9iKaPJSLHU6N8fHU04ew= X-Google-Smtp-Source: AMsMyM41BnChgmCmf9YfgCAJVBq1U7Xim3pjrtlZIlh9K+YaFBQ0IHYFPx6NutQTrNaAkhNW/vMGlg== X-Received: by 2002:a5d:69ca:0:b0:228:dd17:9534 with SMTP id s10-20020a5d69ca000000b00228dd179534mr13398301wrw.652.1663652172930; Mon, 19 Sep 2022 22:36:12 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <38bd4756-dacd-9862-3999-60d609d52f46@amsat.org> Date: Tue, 20 Sep 2022 07:36:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 5/9] exec/address-spaces: Wrap address space singletons into functions Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-6-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-6-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/9/22 01:17, Bernhard Beschow wrote: > In the next steps, these singletons will be resolved by turning them > into attributes of the system bus. The system bus is already accessible > via the global current_machine variable which will be made use of later > in the wrapper functions. > > All changes have been performed with search-and-replace: > * s/&address_space_memory/get_address_space_memory()/ > * s/&address_space_io/get_address_space_io()/ > The only exceptions were exec/address-spaces.h and softmmu/physmem.c > which have been manually changed. > > Signed-off-by: Bernhard Beschow > --- > accel/hvf/hvf-accel-ops.c | 2 +- > accel/kvm/kvm-all.c | 12 ++++++------ > hw/alpha/dp264.c | 4 ++-- > hw/alpha/typhoon.c | 4 ++-- > hw/arm/smmu-common.c | 4 ++-- > hw/arm/smmuv3.c | 14 +++++++------- > hw/arm/virt.c | 2 +- > hw/char/goldfish_tty.c | 4 ++-- > hw/core/loader.c | 2 +- > hw/dma/pl330.c | 2 +- > hw/dma/rc4030.c | 2 +- > hw/dma/xlnx-zynq-devcfg.c | 4 ++-- > hw/dma/xlnx_dpdma.c | 8 ++++---- > hw/hppa/machine.c | 4 ++-- > hw/hyperv/hyperv.c | 2 +- > hw/hyperv/vmbus.c | 2 +- > hw/i386/amd_iommu.c | 18 +++++++++--------- > hw/i386/fw_cfg.c | 2 +- > hw/i386/intel_iommu.c | 24 ++++++++++++------------ > hw/i386/microvm.c | 4 ++-- > hw/i386/pc.c | 2 +- > hw/i386/xen/xen-hvm.c | 4 ++-- > hw/ide/ahci.c | 2 +- > hw/ide/macio.c | 10 +++++----- > hw/intc/apic.c | 2 +- > hw/intc/openpic_kvm.c | 2 +- > hw/intc/pnv_xive.c | 6 +++--- > hw/intc/pnv_xive2.c | 6 +++--- > hw/intc/riscv_aplic.c | 2 +- > hw/intc/spapr_xive.c | 2 +- > hw/intc/xive.c | 4 ++-- > hw/intc/xive2.c | 4 ++-- > hw/mips/jazz.c | 4 ++-- > hw/misc/lasi.c | 2 +- > hw/misc/macio/mac_dbdma.c | 8 ++++---- > hw/net/ftgmac100.c | 16 ++++++++-------- > hw/net/i82596.c | 24 ++++++++++++------------ > hw/net/imx_fec.c | 22 +++++++++++----------- > hw/net/lasi_i82596.c | 2 +- > hw/net/npcm7xx_emc.c | 14 +++++++------- > hw/openrisc/boot.c | 2 +- > hw/pci-host/dino.c | 6 +++--- > hw/pci-host/pnv_phb3.c | 6 +++--- > hw/pci-host/pnv_phb3_msi.c | 6 +++--- > hw/pci-host/pnv_phb4.c | 10 +++++----- > hw/pci/pci.c | 2 +- > hw/ppc/pnv_psi.c | 2 +- > hw/ppc/spapr.c | 4 ++-- > hw/ppc/spapr_events.c | 2 +- > hw/ppc/spapr_hcall.c | 4 ++-- > hw/ppc/spapr_iommu.c | 4 ++-- > hw/ppc/spapr_ovec.c | 8 ++++---- > hw/ppc/spapr_rtas.c | 2 +- > hw/remote/iommu.c | 2 +- > hw/remote/message.c | 4 ++-- > hw/remote/proxy-memory-listener.c | 2 +- > hw/riscv/boot.c | 6 +++--- > hw/riscv/sifive_e.c | 2 +- > hw/riscv/sifive_u.c | 2 +- > hw/riscv/virt.c | 2 +- > hw/s390x/css.c | 16 ++++++++-------- > hw/s390x/ipl.h | 2 +- > hw/s390x/s390-pci-bus.c | 4 ++-- > hw/s390x/s390-pci-inst.c | 10 +++++----- > hw/s390x/s390-skeys.c | 2 +- > hw/s390x/virtio-ccw.c | 10 +++++----- > hw/sd/sdhci.c | 2 +- > hw/sh4/r2d.c | 4 ++-- > hw/sparc/sun4m.c | 2 +- > hw/sparc/sun4m_iommu.c | 4 ++-- > hw/sparc64/sun4u_iommu.c | 4 ++-- > hw/timer/hpet.c | 2 +- > hw/usb/hcd-ehci-pci.c | 2 +- > hw/usb/hcd-ehci-sysbus.c | 2 +- > hw/usb/hcd-ohci.c | 2 +- > hw/usb/hcd-xhci-sysbus.c | 2 +- > hw/vfio/ap.c | 2 +- > hw/vfio/ccw.c | 2 +- > hw/vfio/common.c | 8 ++++---- > hw/vfio/platform.c | 2 +- > hw/virtio/vhost-vdpa.c | 2 +- > hw/virtio/vhost.c | 2 +- > hw/virtio/virtio-bus.c | 4 ++-- > hw/virtio/virtio-iommu.c | 6 +++--- > hw/virtio/virtio-pci.c | 2 +- > hw/xen/xen_pt.c | 4 ++-- > include/exec/address-spaces.h | 4 ++-- > include/hw/elf_ops.h | 4 ++-- > include/hw/ppc/spapr.h | 5 +++-- > include/hw/ppc/vof.h | 4 ++-- > monitor/misc.c | 4 ++-- > softmmu/ioport.c | 12 ++++++------ > softmmu/memory_mapping.c | 2 +- > softmmu/physmem.c | 17 ++++++++++++++--- > target/arm/hvf/hvf.c | 4 ++-- > target/arm/kvm.c | 4 ++-- > target/avr/helper.c | 8 ++++---- > target/i386/hax/hax-all.c | 2 +- > target/i386/hax/hax-mem.c | 2 +- > target/i386/hvf/hvf.c | 2 +- > target/i386/hvf/vmx.h | 2 +- > target/i386/hvf/x86_mmu.c | 6 +++--- > target/i386/nvmm/nvmm-all.c | 4 ++-- > target/i386/sev.c | 4 ++-- > target/i386/tcg/sysemu/misc_helper.c | 12 ++++++------ > target/i386/whpx/whpx-all.c | 4 ++-- > target/s390x/diag.c | 2 +- > target/s390x/mmu_helper.c | 2 +- > target/s390x/sigp.c | 2 +- > target/xtensa/dbg_helper.c | 2 +- > tests/qtest/fuzz/generic_fuzz.c | 4 ++-- > 111 files changed, 285 insertions(+), 273 deletions(-) Please consider using scripts/git.orderfile for tree-wide refactors, it helps reviewers. > diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h > index db8bfa9a92..d5c8cbd718 100644 > --- a/include/exec/address-spaces.h > +++ b/include/exec/address-spaces.h > @@ -33,8 +33,8 @@ MemoryRegion *get_system_memory(void); > */ > MemoryRegion *get_system_io(void); > > -extern AddressSpace address_space_memory; > -extern AddressSpace address_space_io; > +AddressSpace *get_address_space_memory(void); > +AddressSpace *get_address_space_io(void); > > #endif > diff --git a/softmmu/physmem.c b/softmmu/physmem.c > index 56e03e07b5..0ac920d446 100644 > --- a/softmmu/physmem.c > +++ b/softmmu/physmem.c > @@ -89,8 +89,8 @@ RAMList ram_list = { .blocks = QLIST_HEAD_INITIALIZER(ram_list.blocks) }; > static MemoryRegion *system_memory; > static MemoryRegion *system_io; > > -AddressSpace address_space_io; > -AddressSpace address_space_memory; > +static AddressSpace address_space_io; > +static AddressSpace address_space_memory; > > static MemoryRegion io_mem_unassigned; > > @@ -2690,6 +2690,16 @@ MemoryRegion *get_system_io(void) > return system_io; > } > > +AddressSpace *get_address_space_memory(void) > +{ > + return &address_space_memory; > +} > + > +AddressSpace *get_address_space_io(void) > +{ > + return &address_space_io; > +} Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Tue Sep 20 05:49:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 05:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409161.652094 (Exim 4.92) (envelope-from ) id 1oaW8S-0002CR-QJ; Tue, 20 Sep 2022 05:49:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409161.652094; Tue, 20 Sep 2022 05:49:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaW8S-0002CK-NT; Tue, 20 Sep 2022 05:49:32 +0000 Received: by outflank-mailman (input) for mailman id 409161; Tue, 20 Sep 2022 05:49:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaW8R-0002CE-W2 for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 05:49:32 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe3ea393-38a7-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 07:49:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20B1321E76; Tue, 20 Sep 2022 05:49:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DEF1C13ABD; Tue, 20 Sep 2022 05:49:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LwjPM2hUKWOdIwAAMHmgww (envelope-from ); Tue, 20 Sep 2022 05:49:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe3ea393-38a7-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663652969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lX23H5Mmw5Toj1BwLnr2+4Yen8Aug6TwQ9Yk5gvBUEo=; b=PWSpncar1OW67iQenc5sDRSuItG2Xe9nX+gaVZF2Wb2hJAPIROzkenNrorCvqmzBW2AJpY p5Kx/6tdLzsBliSJPldmN9mIZ6SYfFGaP9Z7/Nt1vYz8U90TPbR9xe5b3o/jnker4UoL2N yvnNfYvLBxYrjYw4xTY5IiOL9sW/e+8= Message-ID: <301dedd2-9407-2386-2c20-f0ad6ee42f42@suse.com> Date: Tue, 20 Sep 2022 07:49:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: where are xs APIs defined To: "SHARMA, JYOTIRMOY" , "xen-devel@lists.xenproject.org" Cc: "Mallela, RaghavendraPrasad (Raghavendra Prasad)" References: Content-Language: en-US From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JHBBXtEyvBsb8pFM9946uQPD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JHBBXtEyvBsb8pFM9946uQPD Content-Type: multipart/mixed; boundary="------------vv99lJ8N1mVxzbkZRh0RV3Sf"; protected-headers="v1" From: Juergen Gross To: "SHARMA, JYOTIRMOY" , "xen-devel@lists.xenproject.org" Cc: "Mallela, RaghavendraPrasad (Raghavendra Prasad)" Message-ID: <301dedd2-9407-2386-2c20-f0ad6ee42f42@suse.com> Subject: Re: where are xs APIs defined References: In-Reply-To: --------------vv99lJ8N1mVxzbkZRh0RV3Sf Content-Type: multipart/mixed; boundary="------------j4VkwGAPdn2xMGekZPj6bFwD" --------------j4VkwGAPdn2xMGekZPj6bFwD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDkuMjIgMjA6MTMsIFNIQVJNQSwgSllPVElSTU9ZIHdyb3RlOg0KPiBbQU1EIE9m ZmljaWFsIFVzZSBPbmx5IC0gR2VuZXJhbF0NCj4gDQo+IA0KPiBIZWxsbywNCj4gDQo+IEkg YW0gbG9va2luZyBmb3IgdGhlIHNvdXJjZSBjb2RlIHdoZXJlIFhlbnN0b3JlIGFjY2VzcyBB UElzIGxpa2UgeHNfb3BlbigpLCANCj4geHNfcmVhZCgpIGFyZSBkZWZpbmVkLg0KDQpIYXZl IGEgbG9vayBhdCB0b29scy9saWJzL3N0b3JlLw0KDQpFdmVyIHRob3VnaHQgb2YgdXNpbmcg c29tZXRoaW5nIGxpa2UgY3Njb3BlPyBFdmVuICJnaXQgZ3JlcCIgd291bGQgaGF2ZSBoZWxw ZWQNCnRvIGZpbmQgdGhlIGNvcnJlY3Qgc291cmNlLg0KDQoNCkp1ZXJnZW4NCg0K --------------j4VkwGAPdn2xMGekZPj6bFwD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------j4VkwGAPdn2xMGekZPj6bFwD-- --------------vv99lJ8N1mVxzbkZRh0RV3Sf-- --------------JHBBXtEyvBsb8pFM9946uQPD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMpVGgFAwAAAAAACgkQsN6d1ii/Ey9z 8gf/ROh1iDntYbCUUtKRJTcQzR5twIS9eWuZS6tX99E6wypjKsHZaXXx4RkVRm9+K0+W9mrrjQg4 4qaUBMJsrlwEIz17fMo1idcfwf2pAFiFakpiaWiorq8/Tlh5ubipPzaew2mlJbVu4p/kOSk8r+Mj ixBOE2rQZEUe2Wqn8vnqkGf9HWBjf3FVz8lZBbuAXdRWRdhuKkahJ1WF/QKYhRydf3VhEPGGAKpE /lyHuD/duVANXM7OF8ZJpvAqO7OxDR5Wm0BnQT79LGsSLz7/mJIPYc7tNC6j4pBTBR/RY6EsD9BM XPpKA6Vtjj4Zf+hIF+IJ3MSwWKbUmQKqbCnbjX4SmA== =BUrt -----END PGP SIGNATURE----- --------------JHBBXtEyvBsb8pFM9946uQPD-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 05:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 05:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409170.652105 (Exim 4.92) (envelope-from ) id 1oaWGz-0003jz-Mv; Tue, 20 Sep 2022 05:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409170.652105; Tue, 20 Sep 2022 05:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaWGz-0003js-KE; Tue, 20 Sep 2022 05:58:21 +0000 Received: by outflank-mailman (input) for mailman id 409170; Tue, 20 Sep 2022 05:58:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaWGx-0003jm-TF for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 05:58:20 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38dcd22c-38a9-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 07:58:18 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by PH7PR12MB5927.namprd12.prod.outlook.com (2603:10b6:510:1da::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 05:58:13 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::badf:4ed4:db1d:e5d4]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::badf:4ed4:db1d:e5d4%3]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 05:58:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38dcd22c-38a9-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ocurGGHv5J16ULNy9CqmfUHDY81MuffM+Bf+BNtAJNezOWfjgNrnMpJahTX7oAaY53NxSPkLzwqLRLAizzEocAtr4QiPFuclZZz7mQHOTa1D+IukuLZUdM0uIIdW4G1AaF9jI+yN35xOkp8ePmaYLu7MmLePJnInbOqVc+rXTEcFzrP6iqccL0rPG4CYc+kA88S+BGHP4n/UAKGBYYyycpN9TlqAvfmuyifvx32dpYUV8jlmOj57dYRAks8Rp3LAnElV+WzkYXeFbMnQqL7Q+eNUlOmOY1+Xbw6d7g0242Qya00GUsj+BfG7gbQnlJbwqazOhhaeA0H5yUFgV8I9GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tf+JvIjyGEPaxAP0I8b6I/S8oRQUndgmiZAxEYLbEvA=; b=fLa5uMqPd62F9wGk+5GqcrtJpPExPpTZzuUjCCYjjf2eZM8st3SF0LkafnjQLkqgdlax5dIU3QLZEjn5uY10LpvZIdV7/+KugFiPkZ7V9FPEehvyq+8U94Bv5cNn06QMfRPfrpgyHwV8OXYmcsorLjijWUyJBOyYaGOaXDyn90GNpzXRd/44UOX+azyAzuC2FXM0htmjvjlw1hajEDTl/J/kHY6nByuHmP2U3/KVgW7MsP5LsIvGywR9uAepVKe/lE+oYs7aXHfl8gP9ypk7cGrfhenMdqa1MxkkE0ChwloRRaVuZ2dlCggWe2tB2qTL4ERdISuN2GfDrvb41vGQGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tf+JvIjyGEPaxAP0I8b6I/S8oRQUndgmiZAxEYLbEvA=; b=ML3oqZ5YbB2Ho7yBRQkZTPNYEh+3iotuZmlPgX9JQ3c0pyDzImtKk2NCUFP0T+Frku6PP8vKl4vFMLCaHdpVAtYqqfYkRyArlhfZJVLQ9K7Eb1yvjBHJbL2cve9frA9Edn3HiZ/HbK2cp2Ax+tnZllUxbMPmuDpccZoRAHCIPwU= From: "SHARMA, JYOTIRMOY" To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "Mallela, RaghavendraPrasad (Raghavendra Prasad)" Subject: RE: where are xs APIs defined Thread-Topic: where are xs APIs defined Thread-Index: AdjMU0z+DCbAdhQcS5m0EtpwYKQWwAAYXIcAAAA5VtA= Date: Tue, 20 Sep 2022 05:58:12 +0000 Message-ID: References: <301dedd2-9407-2386-2c20-f0ad6ee42f42@suse.com> In-Reply-To: <301dedd2-9407-2386-2c20-f0ad6ee42f42@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-20T05:58:10Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6773cdd2-ac38-4114-87a3-40ef6af50bbe; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4297:EE_|PH7PR12MB5927:EE_ x-ms-office365-filtering-correlation-id: fc5c2bd6-e488-4977-9174-08da9acd1a6d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u/CNTupZVRMdhMe318HvaCLyPpbi3br12KWLniZtAZ+M5CGrJO8nqaDICr1lAvfEYLgOa82u9pQRWTzuijDXo7CEiQCeKxQs8Q6uY7sfa4aCOAlzrM56ZHGn3TkvmlcuS9c3SEbmsRj4YAkrPr3XUKuJBcED8C+RovQ4K7fyihtUP3m0x50zvEx44wYWRvmdV9dnizS57AbP1k/FeslYz0IALCTlVE5hMYYgVtjFH7AZwnq6+Erjg4SbTtbSIycW/QxyqUcvgHX/wpT08cTTql9Fe4tEWQCyZ7yRY5RKx7pG38GC4LP8+971Q2yRL9WsPIwyWLRlAtvplAdblZcJpiqCm4uPPivwnx+BQd3IUxF9rImm+g/VmKyjbvpdHGojWJD+6XPIMPXvXr/TsTQM0E9Nr5aDm0PyT/c75Bqm4Llnr9VCljIRvJlsibA89x4QvqCEziMH6OuZhxr8HhJf3aXcdIDQoBes5otruu6hnj+fyZnEVxOZx2wI15uQLYqKK5pQOVoK3rLeVFStEn+Z9aXv2gIfadLe0ukFzjbzhgSWaaknnWDZcH8RlVI95nYBo3ByTU2HWsXZUxhFxo4Ca6oy+HZF/4G1LycVRoe0/a362WOOpQhluiB5dOb003ZJ3rAnPk8AyA2Tkvuo0n86RXlxgsQDKglKkcKCZNwSxHjLNLroXCrDOpTzqEjlbAlFSQQzzKWqUp7dGJJEC7O4nkJKAxgFD3d4Ly1GyDrZcwf6xZPj4Kv9Ee8Sy3s6424eAMj51yPbaykCJob5YoEzBA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199015)(5660300002)(186003)(316002)(4744005)(52536014)(53546011)(55016003)(8936002)(38100700002)(86362001)(26005)(9686003)(76116006)(7696005)(6506007)(38070700005)(4326008)(71200400001)(2906002)(66556008)(478600001)(110136005)(83380400001)(33656002)(66446008)(8676002)(66476007)(66946007)(122000001)(64756008)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mnESAu8fq63ADrmxNA6EPzNUUohFxF3LvvS/2o07P7FatNNelfn55ggkbG0A?= =?us-ascii?Q?DcMpxlUY/i4/eRw9TZrMM4VeLklCfyq8MDC+lkgJO9MyDV40MBq75iIsV5lj?= =?us-ascii?Q?jEMNLNR8Y1UdQ8RW1m+2tXjUU/3UHBbDuYJbS9nGG6uwqDq1PAdY0wtbpf/S?= =?us-ascii?Q?QACDEvnFq/iImJauSJgcSHhbb/OFm0KK46J5G9zxmpTETgVjtblY9eEJLjqh?= =?us-ascii?Q?3yoXcZ0yzo5JNMb6c89bPPCXemUTGzre7NdKiqkgWCEMW+qKBWvSYcOekhYH?= =?us-ascii?Q?oYI52Q++/d24V56j+h5erjJpxHYUp9nzLGOyfabABuUOXVpFBXf31pauCvGR?= =?us-ascii?Q?oyuxyeECow465GmVo0OZG4UTSGLwW0vyHIT/dUnAhOxmfMv50dk5qx/Vwnoy?= =?us-ascii?Q?b7KzXFbSvlMRlLE/hPAuTcXFrElHP7iT/zKPBIKgdbh/aafL1VY/+Kn88may?= =?us-ascii?Q?zWBL2f8ufxlU8+q1z7uekXBSmHgRJq32n33o8A4j/Exq47dT/FvBzvzLtIXW?= =?us-ascii?Q?5HTuPG2gzWHn7cn5vSriFTurejikP7KIsaRIu0RWolGEdscRIw7skkcs3gMu?= =?us-ascii?Q?k1/K7NaDXdFIgszmFkkNidBRc2foiewMrRJ8cUD/KHPppSSO/wYGZPazNAv4?= =?us-ascii?Q?am6ksYQ3sWg7W1Bal9ngnCkqSAhUfgl0h/IJq3RMF5SQMjTEqpOAbIEQWiDT?= =?us-ascii?Q?6VAkJKsTE+vDYVbdDrQ/ySWijPbkvoNme7H79SAcQn3eCH2K0TpdVB42JKjt?= =?us-ascii?Q?B/EfO7hhKNTmtndvvwonepui8Pv/MfNZdXE4mx2QB0ysbifk+F/dIebo5BLo?= =?us-ascii?Q?e1ew/X/8dpNs43Xb5Kn13l3i0u01hJHgfP3qwVZORsbcC/3oyG79OSSqgnTH?= =?us-ascii?Q?qcSJJFCyXRZ0eLi+8myR+I5bb6sDU46/0SGfV/O+QMEeGjYmUxRBkGAVJLvE?= =?us-ascii?Q?pKohJGdIlrNTUXf2N6DJdC0aOiNYNQt9gEZMDTXp9bPMvxZY7KVi8EA92P5r?= =?us-ascii?Q?LuFq1N38PhznieagAlcvcwT6iaStHvVpM/0lu0gVKv90p0dVVMHEWnEqQZXk?= =?us-ascii?Q?M3Ux39dFtCPvREsLHyoD+XSrUB/tn6+F0QR40LsK5fAj+Ju6I2SuPhMk0iCS?= =?us-ascii?Q?YMXdzTUTvwMPA+++TvKtPpTc3tlcUrb6pCks7NtzvwHNZd6efx2VhXYsJHZf?= =?us-ascii?Q?GNFIQw/WflXKRAoUy75vUec6G1PqJPrMbgNv0MeYo4RB028nsiyLAGH5hY3S?= =?us-ascii?Q?925R5AfPQ6OReBWfmPxGELNT1ZA2GAq0P32X3+uD60M9WKIioWgca42Vf8BZ?= =?us-ascii?Q?99oivX8eugUsnRocEJ3o3iPC2MPcRYCIVviv4a4gGdB3Gs9FwGfBoMTezZZ1?= =?us-ascii?Q?KrYy5HBRisKQfRFw7E02vuFWGo1Cw8nsUDytabqWf5eaSBlxlWRRuqrEpAFV?= =?us-ascii?Q?bqsZh8ELYmKFFXsmxCuDRB6mJoeKPzQs7rAK3caPlk9SamZ6gVJMwZ74zu9r?= =?us-ascii?Q?WsA3Lqtd40VqGf68vSh8HnXiW8LEGsuA/oOSBwrAqBjP30Dg64ru/B2WHa33?= =?us-ascii?Q?mxNUMKKeFcqo9EvO1oG2nZ/1TCWRTiZkAoO7DzRh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc5c2bd6-e488-4977-9174-08da9acd1a6d X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 05:58:12.8239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O01HLAd2ZiFx07Z9KgL4Vizx4vREy/wST8jeXgyRpVTGQ2EKGSpmBSi6zmPQrXf9vE67yCk3iq1N1kDV/DSHJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5927 [AMD Official Use Only - General] Hello, Thanks for the help. I use Visual Studio Code and somehow it is not able to= find. Regards, Jyotirmoy -----Original Message----- From: Juergen Gross =20 Sent: Tuesday, September 20, 2022 11:19 AM To: SHARMA, JYOTIRMOY ; xen-devel@lists.xenprojec= t.org Cc: Mallela, RaghavendraPrasad (Raghavendra Prasad) Subject: Re: where are xs APIs defined Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 07:42:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 07:42:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409178.652116 (Exim 4.92) (envelope-from ) id 1oaXtO-00066z-Vp; Tue, 20 Sep 2022 07:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409178.652116; Tue, 20 Sep 2022 07:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaXtO-00066s-T4; Tue, 20 Sep 2022 07:42:06 +0000 Received: by outflank-mailman (input) for mailman id 409178; Tue, 20 Sep 2022 07:42:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaXtN-00066m-Ui for xen-devel@lists.xen.org; Tue, 20 Sep 2022 07:42:06 +0000 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [2607:f8b0:4864:20::1036]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b72c1856-38b7-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 09:42:03 +0200 (CEST) Received: by mail-pj1-x1036.google.com with SMTP id fs14so2126022pjb.5 for ; Tue, 20 Sep 2022 00:42:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b72c1856-38b7-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=1sMWQkaPjZ6B1lFWgJf0Wo39KVCMF8HW83cCGlHJITs=; b=iOSEA+FcmEuj70qoUmH37gsciTlfgIG2owBRfPA89MZiVCUnLISrqk9+i+0Ofbl4oi RGn7yc7R633T95VKdqhX1Z3wgHMuI4iMprK8zPKQzHlTrqkwhdlDcMITV0iwn/XhsNPb miTTKPfjX3hclDjyTl2vwhnLjeAGYNATARP3myenEVUwHykyoqIF51Cy6/legUm+XI1F c6MokWRtBFIs3ogipUHsjJZp6Ks/HSSNq0z7BVnDSeh/thftijGFAVhZMMGXiWHw1iK3 LQmI1vPv91l16NF9gdaYUlozdds5fE7QaF0AFdBp9oHVYf6kFzzmlF6rKg8eLS+dAcMF iiyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=1sMWQkaPjZ6B1lFWgJf0Wo39KVCMF8HW83cCGlHJITs=; b=6lQB4OeRxmnl4csgoUHnngVhhLcD03lWkH4tyPrDBhyazHF/yhQSRI+aInxUewwR1y jolE+J2IXG7PswfYlkjAYGO05NesRZEKWmRdJJ+hO4L8LQiMPiN0GZyPC0a/CNEkErRr 5yUXpE29ri+Sh85WZG31H7D2ALMK9bvMwtqIJOQ9wIiA9Rl0/WsDRnayKSSRy3fZJ9JR VVZOJYgz7qiYvkG+qSss50NKxcJ9zGdSVrGCMoVRN56Zq846rRma7MqzAPPCfnrpFiJ5 c6u8DiJvHiSAaar+jHfXXf7siJTonn64Hzfw7fzbZ2SA/DeT1oNiHoSU29KKMD5/GyNx xZMg== X-Gm-Message-State: ACrzQf2R7fPEOPEUznzGxOg3zD95+uCajPySzR6XANT5bWgLeTEz33Ux zqGWA/H56ywfSsUh5sD37RlC9Du26dHu9x2n19VuUYukoQY= X-Google-Smtp-Source: AMsMyM5utsWax+lFkefOqTvdPK9jjvYiAvbciJKxRJzGiL3NwS6C3UL6Y9x5o7EwvRn76qTubsWHNae6NfK4zFIFqF4= X-Received: by 2002:a17:90a:f291:b0:200:acc9:422d with SMTP id fs17-20020a17090af29100b00200acc9422dmr2396820pjb.21.1663659721434; Tue, 20 Sep 2022 00:42:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Szewczyk Date: Tue, 20 Sep 2022 09:41:48 +0200 Message-ID: Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000b9296e05e916f69a" --000000000000b9296e05e916f69a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > (XEN) Built-in command line: ept=3Dexec-sp spec-ctrl=3Dunpriv-mmio > (XEN) parameter "no-real-mode" unknown! > Xen 4.14.5 > (XEN) Xen version 4.14.5 (mockbuild@[unknown]) (gcc (GCC) 10.3.1 20210422 > (Red Hat 10.3.1-1)) debug=3Dn Wed Aug 24 00:00:00 UTC 2022 > (XEN) Latest ChangeSet: > (XEN) Bootloader: GRUB 2.04 > (XEN) Command line: placeholder console=3Dnone dom0_mem=3Dmin:1024M > dom0_mem=3Dmax:4096M ucode=3Dscan smt=3Doff gnttab_max_frames=3D2048 > gnttab_max_maptrack_frames=3D4096 no-real-mode edd=3Doff > (XEN) Xen image load base address: 0x9c200000 > (XEN) Video information: > (XEN) VGA is graphics mode 1920x1080, 32 bpp > (XEN) Disc information: > (XEN) Found 0 MBR signatures > (XEN) Found 2 EDD information structures > (XEN) EFI RAM map: > (XEN) [0000000000000000, 000000000009efff] (usable) > (XEN) [000000000009f000, 00000000000fffff] (reserved) > (XEN) [0000000000100000, 0000000086466fff] (usable) > (XEN) [0000000086467000, 0000000086d66fff] (reserved) > (XEN) [0000000086d67000, 000000009cf7dfff] (usable) > (XEN) [000000009cf7e000, 000000009e49dfff] (reserved) > (XEN) [000000009e49e000, 000000009eb8dfff] (ACPI NVS) > (XEN) [000000009eb8e000, 000000009ec0dfff] (ACPI data) > (XEN) [000000009ec0e000, 000000009ec0efff] (usable) > (XEN) [000000009ec0f000, 000000009fffffff] (reserved) > (XEN) [00000000e0000000, 00000000efffffff] (reserved) > (XEN) [00000000fe000000, 00000000fe010fff] (reserved) > (XEN) [00000000fed10000, 00000000fed19fff] (reserved) > (XEN) [00000000fed84000, 00000000fed84fff] (reserved) > (XEN) [00000000fee00000, 00000000fee00fff] (reserved) > (XEN) [00000000ff600000, 00000000ffffffff] (reserved) > (XEN) [0000000100000000, 000000085dffffff] (usable) > (XEN) ACPI: RSDP 9EC0D014, 0024 (r2 LENOVO) > (XEN) ACPI: XSDT 9EBEE188, 00FC (r1 LENOVO CB-01 1 100001= 3) > (XEN) ACPI: FACP 9EBF1000, 010C (r5 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: DSDT 9EBBD000, 2FF34 (r2 LENOVO CB-01 1 ACPI > 40000) > (XEN) ACPI: FACS 9EB0D000, 0040 > (XEN) ACPI: UEFI 9EC0C000, 0236 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EC0A000, 1B1C (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EC06000, 31D0 (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: UEFI 9EC05000, 0042 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EC04000, 045A (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EC03000, 0046 (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: TPM2 9EC02000, 0034 (r3 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: POAT 9EC01000, 0055 (r3 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBFC000, 44B6 (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: LPIT 9EBFB000, 0094 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: WSMT 9EBFA000, 0028 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBF9000, 0C2F (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: DBGP 9EBF8000, 0034 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: DBG2 9EBF7000, 0061 (r0 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBF6000, 0896 (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBF3000, 2F89 (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: ASF! 9EBF2000, 00A5 (r32 LENOVO CB-01 1 ACPI > 40000) > (XEN) ACPI: HPET 9EBF0000, 0038 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: APIC 9EBEF000, 012C (r3 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: MCFG 9EBED000, 003C (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBBA000, 2BBF (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: DMAR 9EBB9000, 0070 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBB6000, 2B68 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: SSDT 9EBB5000, 004C (r2 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: FPDT 9EBB4000, 0044 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) ACPI: BGRT 9EBB3000, 0038 (r1 LENOVO CB-01 1 ACPI 4000= 0) > (XEN) System RAM: 32678MB (33462392kB) > (XEN) Domain heap initialised > (XEN) ACPI: 32/64X FACS address mismatch in FADT - > 9eb0d000/0000000000000000, using 32 > (XEN) IOAPIC[0]: apic_id 2, version 32, address 0xfec00000, GSI 0-119 > (XEN) Enabling APIC mode: Phys. Using 1 I/O APICs > (XEN) Switched to APIC driver x2apic_cluster > (XEN) CPU0: TSC: ratio: 216 / 2 > (XEN) CPU0: bus: 100 MHz base: 2600 MHz max: 4500 MHz > (XEN) CPU0: 800 ... 2600 MHz > (XEN) xstate: size: 0x440 and states: 0x1f > (XEN) Speculative mitigation facilities: > (XEN) Hardware hints: RSBA > (XEN) Hardware features: IBPB IBRS STIBP SSBD L1D_FLUSH MD_CLEAR > SRBDS_CTRL > (XEN) Compiled-in support: INDIRECT_THUNK > (XEN) Xen settings: BTI-Thunk JMP, SPEC_CTRL: IBRS+ STIBP+ SSBD-, Other= : > SRB_LOCK+ IBPB-ctxt L1D_FLUSH VERW BRANCH_HARDEN > (XEN) L1TF: believed vulnerable, maxphysaddr L1D 46, CPUID 39, Safe > address 8000000000 > (XEN) Support for HVM VMs: MSR_SPEC_CTRL RSB EAGER_FPU MD_CLEAR > (XEN) Support for PV VMs: MSR_SPEC_CTRL EAGER_FPU MD_CLEAR > (XEN) XPTI (64-bit PV only): Dom0 enabled, DomU enabled (with PCID) > (XEN) PV L1TF shadowing: Dom0 disabled, DomU enabled > (XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2) > (XEN) Initializing Credit2 scheduler > (XEN) Disabling HPET for being unreliable > (XEN) Platform timer is 3.580MHz ACPI PM Timer > (XEN) Detected 2591.999 MHz processor. > (XEN) Unknown cachability for MFNs 0xa0-0xff > (XEN) Unknown cachability for MFNs 0x9f000-0x9ffff > (XEN) Intel VT-d iommu 0 supported page sizes: 4kB, 2MB, 1GB > (XEN) Intel VT-d Snoop Control enabled. > (XEN) Intel VT-d Dom0 DMA Passthrough not enabled. > (XEN) Intel VT-d Queued Invalidation enabled. > (XEN) Intel VT-d Interrupt Remapping enabled. > (XEN) Intel VT-d Posted Interrupt not enabled. > (XEN) Intel VT-d Shared EPT tables enabled. > (XEN) I/O virtualisation enabled > (XEN) - Dom0 mode: Relaxed > (XEN) Interrupt remapping enabled > (XEN) Enabled directed EOI with ioapic_ack_old on! > (XEN) ENABLING IO-APIC IRQs > (XEN) -> Using old ACK method > (XEN) Allocated console ring of 32 KiB. > (XEN) VMX: Supported advanced features: > (XEN) - APIC MMIO access virtualisation > (XEN) - APIC TPR shadow > (XEN) - Extended Page Tables (EPT) > (XEN) - Virtual-Processor Identifiers (VPID) > (XEN) - Virtual NMI > (XEN) - MSR direct-access bitmap > (XEN) - Unrestricted Guest > (XEN) - VM Functions > (XEN) - Virtualisation Exceptions > (XEN) - Page Modification Logging > (XEN) HVM: ASIDs enabled. > (XEN) HVM: VMX enabled > (XEN) HVM: Hardware Assisted Paging (HAP) detected > (XEN) HVM: HAP page sizes: 4kB, 2MB, 1GB > (XEN) Brought up 6 CPUs > (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource > (XEN) Dom0 has maximum 952 PIRQs > (XEN) Xen kernel: 64-bit, lsb, compat32 > (XEN) Dom0 kernel: 64-bit, PAE, lsb, paddr 0x1000000 -> 0x4000000 > (XEN) PHYSICAL MEMORY ARRANGEMENT: > (XEN) Dom0 alloc.: 0000000838000000->0000000840000000 (1007932 pages t= o > be allocated) > (XEN) Init. ramdisk: 000000085c13c000->000000085dffff1d > (XEN) VIRTUAL MEMORY ARRANGEMENT: > (XEN) Loaded kernel: ffffffff81000000->ffffffff84000000 > (XEN) Init. ramdisk: 0000000000000000->0000000000000000 > (XEN) Phys-Mach map: 0000008000000000->0000008000800000 > (XEN) Start info: ffffffff84000000->ffffffff840004b8 > (XEN) Xenstore ring: 0000000000000000->0000000000000000 > (XEN) Console ring: 0000000000000000->0000000000000000 > (XEN) Page tables: ffffffff84001000->ffffffff84026000 > (XEN) Boot stack: ffffffff84026000->ffffffff84027000 > (XEN) TOTAL: ffffffff80000000->ffffffff84400000 > (XEN) ENTRY ADDRESS: ffffffff830fb1c0 > (XEN) Dom0 has maximum 6 VCPUs > (XEN) Initial low memory virq threshold set at 0x4000 pages. > (XEN) Scrubbing Free RAM in background > (XEN) Std. Loglevel: Errors and warnings > (XEN) Guest Loglevel: Nothing (Rate-limited: Errors and warnings) > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input= ) > (XEN) Freed 580kB init memory > (XEN) MSI information: > (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /? > (XEN) MSI 121 vec=3Dc8 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 122 vec=3Dd0 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 123 vec=3De0 lowest edge assert log lowest dest=3D00000= 001 > mask=3D0/ /? > (XEN) MSI 124 vec=3D31 lowest edge assert log lowest dest=3D00000= 040 > mask=3D0/ /? > (XEN) MSI-X 125 vec=3D51 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D00000= 004 > mask=3D1/ /0 > (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /0 > (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D00000= 010 > mask=3D1/ /0 > (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D00000= 040 > mask=3D1/ /0 > (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D00000= 001 > mask=3D1/ /0 > (XEN) MSI 132 vec=3Dd9 lowest edge assert log lowest dest=3D00000= 100 > mask=3D0/ /? > (XEN) MSI 133 vec=3Dc9 lowest edge assert log lowest dest=3D00000= 004 > mask=3D0/ /? > (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D00000= 100 > mask=3D0/ /? > (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D00000= 555 > mask=3D0/ /? > (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D00000= 010 > mask=3D0/ /? > (XEN) MSI 138 vec=3Dd1 lowest edge assert log lowest dest=3D00000= 100 > mask=3D0/ /? > (XEN) IRQ information: > (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} > time.c#timer_interrupt() > (XEN) IRQ: 1 vec:39 IO-APIC-edge status=3D034 aff:{8}/{0-11} > in-flight=3D0 d0: 1(---) > (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 8(---) > (XEN) IRQ: 9 vec:b0 IO-APIC-level status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0: 9(---) > (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} mapp= ed, > unbound > (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} > in-flight=3D0 d0: 14(---) > (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped, > unbound > (XEN) IRQ: 16 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} > in-flight=3D0 d0: 16(---),d3: 16(-M-) > (XEN) IRQ: 17 vec:d8 IO-APIC-level status=3D010 aff:{10}/{0-11} > in-flight=3D2 d0: 17(P-M),d7: 17(-MM) > (XEN) IRQ: 18 vec:c0 IO-APIC-level status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0: 18(---),d3: 18(-M-) > (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 20 vec:e8 IO-APIC-level status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0: 20(---) > (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0: 83(---) > (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} > iommu.c#iommu_page_fault() > (XEN) IRQ: 121 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:951(---) > (XEN) IRQ: 122 vec:d0 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:950(---) > (XEN) IRQ: 123 vec:e0 PCI-MSI status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:949(---) > (XEN) IRQ: 124 vec:31 PCI-MSI status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:948(---) > (XEN) IRQ: 125 vec:51 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:947(---) > (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D010 aff:{2}/{0-11} > in-flight=3D0 d0:946(---) > (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:945(---) > (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:944(---) > (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:943(---) > (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} > in-flight=3D0 d0:942(---) > (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{0}/{0-11} > in-flight=3D0 d0:941(---) > (XEN) IRQ: 132 vec:d9 PCI-MSI status=3D030 aff:{8}/{0-11} > in-flight=3D0 d7:151(-M-) > (XEN) IRQ: 133 vec:c9 PCI-MSI status=3D030 aff:{2}/{0-11} > in-flight=3D0 d3:151(---) > (XEN) IRQ: 134 vec:99 PCI-MSI status=3D030 aff:{8}/{0-11} > in-flight=3D0 d0:938(---) > (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} > mapped, unbound > (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:936(---) > (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{4}/{0-11} > in-flight=3D0 d0:935(---) > (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D010 aff:{8}/{0-11} > in-flight=3D0 d3:150(---) > (XEN) Direct vector information: > (XEN) 0x22 -> irq_move_cleanup_interrupt() > (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() > (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() > (XEN) 0xf9 -> pmu_apic_interrupt() > (XEN) 0xfa -> apic_timer_interrupt() > (XEN) 0xfb -> call_function_interrupt() > (XEN) 0xfc -> event_check_interrupt() > (XEN) 0xfd -> invalidate_interrupt() > (XEN) 0xfe -> error_interrupt() > (XEN) 0xff -> spurious_interrupt() > (XEN) IO-APIC interrupt information: > (XEN) IRQ 0 Vec240: > (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 1 Vec 57: > (XEN) Apic 0x00, Pin 1: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000100 > (XEN) IRQ 3 Vec 64: > (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 4 Vec 72: > (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 5 Vec 80: > (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 6 Vec 88: > (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 7 Vec 96: > (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 8 Vec104: > (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 9 Vec176: > (XEN) Apic 0x00, Pin 9: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 > (XEN) IRQ 10 Vec120: > (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 11 Vec136: > (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 12 Vec144: > (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 13 Vec152: > (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 > (XEN) IRQ 14 Vec160: > (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 15 Vec168: > (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 > (XEN) IRQ 16 Vec184: > (XEN) Apic 0x00, Pin 16: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 > (XEN) IRQ 17 Vec216: > (XEN) Apic 0x00, Pin 17: vec=3Dd8 delivery=3DLoPri dest=3DL status= =3D1 > polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000400 > (XEN) IRQ 18 Vec192: > (XEN) Apic 0x00, Pin 18: vec=3Dc0 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 > (XEN) IRQ 19 Vec161: > (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 > (XEN) IRQ 20 Vec232: > (XEN) Apic 0x00, Pin 20: vec=3De8 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 > (XEN) IRQ 83 Vec 65: > (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 > polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 Name ID Mem VCPUs State Time(s) > Domain-0 0 4080 6 r----- > 288.6 > sys-usb 3 284 2 -b---- > 20.5 > sys-usb-dm 4 144 1 -b---- > 3.5 > openbsd-71 7 511 2 -b---- > 63.0 > openbsd-71-dm 8 144 1 -b---- > 14.0 > How I can enable install this debug hypervisor? I have problems finding anything about it. I don't have logs with qemu in the name, instead I have gmp-proxy logs. But their all looks empty. BR Adam pon., 19 wrz 2022 o 11:21 Roger Pau Monn=C3=A9 napis= a=C5=82(a): > On Fri, Sep 16, 2022 at 05:08:59PM +0200, Adam Szewczyk wrote: > > Sorry, I always forgot that default answer is "answer" to not "answer t= o > > all". > > > > My xl dmesg after calling those debug-keys is: > > Trimming the trace: > > > (XEN) MSI information: > > > (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D000= 00100 > > mask=3D0/ /? > > > (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D000= 00001 > > mask=3D0/ /? > > (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D000= 00010 > > mask=3D0/ /? > > > (XEN) IRQ information: > > > (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} > > in-flight=3D0 d94:151(-M-) > > > (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} > > in-flight=3D0 d92:151(---) > > (XEN) IRQ: 139 vec:6a PCI-MSI status=3D010 aff:{4}/{0-11} > > in-flight=3D0 d92:150(---) > > Was domain with ID 94 your OpenBSD box? There's another domain with > passthrough devices (ID 92). > > If your OpenBSD domain is the one with ID 94 it seems like the > interrupt source is masked, so no interrupts will be injected to the > guest. That however might be just the response from the guest after > seeing that the interrupt source is not behaving correctly. > > Are yuo using a debug hypervisor? If not it would be helpful to do so, > in order to maybe get more information on `xl dmesg`. > > Can you also paste the QEMU log for the OpeNSD domain? Those logs are > in /var/log/xen/qemu-dm-.log, on most distros, not sure > if QubesOS puts them at the same place. > > Regards, Roger. > --000000000000b9296e05e916f69a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(XEN) Bu= ilt-in command line: ept=3Dexec-sp spec-ctrl=3Dunpriv-mmio
(XEN) paramet= er "no-real-mode" unknown!
=C2=A0Xen 4.14.5
(XEN) Xen versi= on 4.14.5 (mockbuild@[unknown]) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-= 1)) debug=3Dn =C2=A0Wed Aug 24 00:00:00 UTC 2022
(XEN) Latest ChangeSet:=
(XEN) Bootloader: GRUB 2.04
(XEN) Command line: placeholder console= =3Dnone dom0_mem=3Dmin:1024M dom0_mem=3Dmax:4096M ucode=3Dscan smt=3Doff gn= ttab_max_frames=3D2048 gnttab_max_maptrack_frames=3D4096 no-real-mode edd= =3Doff
(XEN) Xen image load base address: 0x9c200000
(XEN) Video info= rmation:
(XEN) =C2=A0VGA is graphics mode 1920x1080, 32 bpp
(XEN) Dis= c information:
(XEN) =C2=A0Found 0 MBR signatures
(XEN) =C2=A0Found 2= EDD information structures
(XEN) EFI RAM map:
(XEN) =C2=A0[000000000= 0000000, 000000000009efff] (usable)
(XEN) =C2=A0[000000000009f000, 00000= 000000fffff] (reserved)
(XEN) =C2=A0[0000000000100000, 0000000086466fff]= (usable)
(XEN) =C2=A0[0000000086467000, 0000000086d66fff] (reserved)(XEN) =C2=A0[0000000086d67000, 000000009cf7dfff] (usable)
(XEN) =C2=A0[= 000000009cf7e000, 000000009e49dfff] (reserved)
(XEN) =C2=A0[000000009e49= e000, 000000009eb8dfff] (ACPI NVS)
(XEN) =C2=A0[000000009eb8e000, 000000= 009ec0dfff] (ACPI data)
(XEN) =C2=A0[000000009ec0e000, 000000009ec0efff]= (usable)
(XEN) =C2=A0[000000009ec0f000, 000000009fffffff] (reserved)(XEN) =C2=A0[00000000e0000000, 00000000efffffff] (reserved)
(XEN) =C2= =A0[00000000fe000000, 00000000fe010fff] (reserved)
(XEN) =C2=A0[00000000= fed10000, 00000000fed19fff] (reserved)
(XEN) =C2=A0[00000000fed84000, 00= 000000fed84fff] (reserved)
(XEN) =C2=A0[00000000fee00000, 00000000fee00f= ff] (reserved)
(XEN) =C2=A0[00000000ff600000, 00000000ffffffff] (reserve= d)
(XEN) =C2=A0[0000000100000000, 000000085dffffff] (usable)
(XEN) AC= PI: RSDP 9EC0D014, 0024 (r2 LENOVO)
(XEN) ACPI: XSDT 9EBEE188, 00FC (r1 = LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 =C2=A0 =C2=A0 =C2=A0 1000= 013)
(XEN) ACPI: FACP 9EBF1000, 010C (r5 LENOVO CB-01 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: DSDT 9EBBD000, = 2FF34 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2= =A040000)
(XEN) ACPI: FACS 9EB0D000, 0040
(XEN) ACPI: UEFI 9EC0C000, = 0236 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2= =A040000)
(XEN) ACPI: SSDT 9EC0A000, 1B1C (r2 LENOVO CB-01 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EC060= 00, 31D0 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 = =C2=A040000)
(XEN) ACPI: UEFI 9EC05000, 0042 (r1 LENOVO CB-01 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EC= 04000, 045A (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2= =A0 =C2=A040000)
(XEN) ACPI: SSDT 9EC03000, 0046 (r2 LENOVO CB-01 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: TPM2= 9EC02000, 0034 (r3 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI = =C2=A0 =C2=A040000)
(XEN) ACPI: POAT 9EC01000, 0055 (r3 LENOVO CB-01 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: S= SDT 9EBFC000, 44B6 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 AC= PI =C2=A0 =C2=A040000)
(XEN) ACPI: LPIT 9EBFB000, 0094 (r1 LENOVO CB-01 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI= : WSMT 9EBFA000, 0028 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1= ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EBF9000, 0C2F (r2 LENOVO CB-= 01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) A= CPI: DBGP 9EBF8000, 0034 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: DBG2 9EBF7000, 0061 (r0 LENOV= O CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(X= EN) ACPI: SSDT 9EBF6000, 0896 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EBF3000, 2F89 (r2 LE= NOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)(XEN) ACPI: ASF! 9EBF2000, 00A5 (r32 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: HPET 9EBF0000, 0038 (r= 1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000= )
(XEN) ACPI: APIC 9EBEF000, 012C (r3 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: MCFG 9EBED000, 003C= (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040= 000)
(XEN) ACPI: SSDT 9EBBA000, 2BBF (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: DMAR 9EBB9000, = 0070 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2= =A040000)
(XEN) ACPI: SSDT 9EBB6000, 2B68 (r1 LENOVO CB-01 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EBB50= 00, 004C (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 = =C2=A040000)
(XEN) ACPI: FPDT 9EBB4000, 0044 (r1 LENOVO CB-01 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: BGRT 9EB= B3000, 0038 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2= =A0 =C2=A040000)
(XEN) System RAM: 32678MB (33462392kB)
(XEN) Domain = heap initialised
(XEN) ACPI: 32/64X FACS address mismatch in FADT - 9eb0= d000/0000000000000000, using 32
(XEN) IOAPIC[0]: apic_id 2, version 32, = address 0xfec00000, GSI 0-119
(XEN) Enabling APIC mode: =C2=A0Phys.=C2= =A0 Using 1 I/O APICs
(XEN) Switched to APIC driver x2apic_cluster
(X= EN) CPU0: TSC: ratio: 216 / 2
(XEN) CPU0: bus: 100 MHz base: 2600 MHz ma= x: 4500 MHz
(XEN) CPU0: 800 ... 2600 MHz
(XEN) xstate: size: 0x440 an= d states: 0x1f
(XEN) Speculative mitigation facilities:
(XEN) =C2=A0 = Hardware hints: RSBA
(XEN) =C2=A0 Hardware features: IBPB IBRS STIBP SSB= D L1D_FLUSH MD_CLEAR SRBDS_CTRL
(XEN) =C2=A0 Compiled-in support: INDIRE= CT_THUNK
(XEN) =C2=A0 Xen settings: BTI-Thunk JMP, SPEC_CTRL: IBRS+ STIB= P+ SSBD-, Other: SRB_LOCK+ IBPB-ctxt L1D_FLUSH VERW BRANCH_HARDEN
(XEN) = =C2=A0 L1TF: believed vulnerable, maxphysaddr L1D 46, CPUID 39, Safe addres= s 8000000000
(XEN) =C2=A0 Support for HVM VMs: MSR_SPEC_CTRL RSB EAGER_F= PU MD_CLEAR
(XEN) =C2=A0 Support for PV VMs: MSR_SPEC_CTRL EAGER_FPU MD_= CLEAR
(XEN) =C2=A0 XPTI (64-bit PV only): Dom0 enabled, DomU enabled (wi= th PCID)
(XEN) =C2=A0 PV L1TF shadowing: Dom0 disabled, DomU enabled
= (XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2)
(XEN) Initial= izing Credit2 scheduler
(XEN) Disabling HPET for being unreliable
(XE= N) Platform timer is 3.580MHz ACPI PM Timer
(XEN) Detected 2591.999 MHz = processor.
(XEN) Unknown cachability for MFNs 0xa0-0xff
(XEN) Unknown= cachability for MFNs 0x9f000-0x9ffff
(XEN) Intel VT-d iommu 0 supported= page sizes: 4kB, 2MB, 1GB
(XEN) Intel VT-d Snoop Control enabled.
(X= EN) Intel VT-d Dom0 DMA Passthrough not enabled.
(XEN) Intel VT-d Queued= Invalidation enabled.
(XEN) Intel VT-d Interrupt Remapping enabled.
= (XEN) Intel VT-d Posted Interrupt not enabled.
(XEN) Intel VT-d Shared E= PT tables enabled.
(XEN) I/O virtualisation enabled
(XEN) =C2=A0- Dom= 0 mode: Relaxed
(XEN) Interrupt remapping enabled
(XEN) Enabled direc= ted EOI with ioapic_ack_old on!
(XEN) ENABLING IO-APIC IRQs
(XEN) =C2= =A0-> Using old ACK method
(XEN) Allocated console ring of 32 KiB.(XEN) VMX: Supported advanced features:
(XEN) =C2=A0- APIC MMIO access = virtualisation
(XEN) =C2=A0- APIC TPR shadow
(XEN) =C2=A0- Extended P= age Tables (EPT)
(XEN) =C2=A0- Virtual-Processor Identifiers (VPID)
(= XEN) =C2=A0- Virtual NMI
(XEN) =C2=A0- MSR direct-access bitmap
(XEN)= =C2=A0- Unrestricted Guest
(XEN) =C2=A0- VM Functions
(XEN) =C2=A0- = Virtualisation Exceptions
(XEN) =C2=A0- Page Modification Logging
(XE= N) HVM: ASIDs enabled.
(XEN) HVM: VMX enabled
(XEN) HVM: Hardware Ass= isted Paging (HAP) detected
(XEN) HVM: HAP page sizes: 4kB, 2MB, 1GB
= (XEN) Brought up 6 CPUs
(XEN) Scheduling granularity: cpu, 1 CPU per sch= ed-resource
(XEN) Dom0 has maximum 952 PIRQs
(XEN) =C2=A0Xen =C2=A0ke= rnel: 64-bit, lsb, compat32
(XEN) =C2=A0Dom0 kernel: 64-bit, PAE, lsb, p= addr 0x1000000 -> 0x4000000
(XEN) PHYSICAL MEMORY ARRANGEMENT:
(XE= N) =C2=A0Dom0 alloc.: =C2=A0 0000000838000000->0000000840000000 (1007932= pages to be allocated)
(XEN) =C2=A0Init. ramdisk: 000000085c13c000->= 000000085dffff1d
(XEN) VIRTUAL MEMORY ARRANGEMENT:
(XEN) =C2=A0Loaded= kernel: ffffffff81000000->ffffffff84000000
(XEN) =C2=A0Init. ramdisk= : 0000000000000000->0000000000000000
(XEN) =C2=A0Phys-Mach map: 00000= 08000000000->0000008000800000
(XEN) =C2=A0Start info: =C2=A0 =C2=A0ff= ffffff84000000->ffffffff840004b8
(XEN) =C2=A0Xenstore ring: 000000000= 0000000->0000000000000000
(XEN) =C2=A0Console ring: =C2=A000000000000= 00000->0000000000000000
(XEN) =C2=A0Page tables: =C2=A0 ffffffff84001= 000->ffffffff84026000
(XEN) =C2=A0Boot stack: =C2=A0 =C2=A0ffffffff84= 026000->ffffffff84027000
(XEN) =C2=A0TOTAL: =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ffffffff80000000->ffffffff84400000
(XEN) =C2=A0ENTRY ADDRESS: fff= fffff830fb1c0
(XEN) Dom0 has maximum 6 VCPUs
(XEN) Initial low memory= virq threshold set at 0x4000 pages.
(XEN) Scrubbing Free RAM in backgro= und
(XEN) Std. Loglevel: Errors and warnings
(XEN) Guest Loglevel: No= thing (Rate-limited: Errors and warnings)
(XEN) *** Serial input to DOM0= (type 'CTRL-a' three times to switch input)
(XEN) Freed 580kB i= nit memory
(XEN) MSI information:
(XEN) =C2=A0IOMMU =C2=A0120 vec=3D3= 0 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D1= / =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 vec=3Dc8 lowest =C2=A0edge = =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) = =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dd0 lowest =C2=A0edge =C2=A0 assert =C2=A0l= og lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2= =A0123 vec=3De0 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D000= 00001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0124 vec=3D31 lowes= t =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask=3D0/ =C2= =A0/?
(XEN) =C2=A0MSI-X =C2=A0125 vec=3D51 lowest =C2=A0edge =C2=A0 asse= rt =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X= =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest= =3D00000004 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0127 vec=3D61 lowe= st =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2= =A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest =C2=A0edge =C2=A0 asse= rt =C2=A0log lowest dest=3D00000001 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X= =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest= =3D00000010 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0130 vec=3D79 lowe= st =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2= =A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest =C2=A0edge =C2=A0 asse= rt =C2=A0log lowest dest=3D00000001 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI = =C2=A0 =C2=A0132 vec=3Dd9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest = dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0133 vec= =3Dc9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000004 mask= =3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0134 vec=3D99 lowest =C2=A0ed= ge =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XE= N) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2=A0edge =C2=A0 assert =C2= =A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 = =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0137 vec=3Db9 lo= west =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000010 mask=3D0/ = =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3Dd1 lowest =C2=A0edge =C2= =A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) IRQ= information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:f0 IO-APIC-edge =C2= =A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrupt()
(XEN) =C2=A0= =C2=A0IRQ: =C2=A0 1 vec:39 IO-APIC-edge =C2=A0 =C2=A0status=3D034 aff:{8}/= {0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 3 v= ec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge =C2=A0 =C2=A0status= =3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 5 vec:= 50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(X= EN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2=A0 =C2=A0status=3D00= 2 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 7 vec:60 IO= -APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 =C2=A0status=3D030 af= f:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 = 9 vec:b0 IO-APIC-level =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d0:= =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec:78 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 IO-APIC-edge =C2=A0 = =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0-15}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-APIC-level =C2=A0 = status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b8 IO-APIC-level =C2=A0 = status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d3: 16(-M-)
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A017 vec:d8 IO-APIC-level =C2=A0 status=3D010 aff:{10= }/{0-11} in-flight=3D2 d0: 17(P-M),d7: 17(-MM)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A018 vec:c0 IO-APIC-level =C2=A0 status=3D030 aff:{8}/{0-11} in-flight= =3D0 d0: 18(---),d3: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A019 vec:a1 IO-= APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A020 vec:e8 IO-APIC-level =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A083 vec:4= 1 IO-APIC-level =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0: 83(---= )
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0= status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()
(XEN) =C2=A0 =C2= =A0IRQ: 121 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2=A0IRQ: 122 vec:d0 PCI= -MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 = d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:e0 PCI-MSI =C2=A0 =C2=A0 =C2= =A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:949(---)
(XEN) = =C2=A0 =C2=A0IRQ: 124 vec:31 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D0= 30 aff:{6}/{0-11} in-flight=3D0 d0:948(---)
(XEN) =C2=A0 =C2=A0IRQ: 125 = vec:51 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{6}/{0-11} in-flight= =3D0 d0:947(---)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:59 PCI-MSI/-X =C2=A0 = =C2=A0 =C2=A0status=3D010 aff:{2}/{0-11} in-flight=3D0 d0:946(---)
(XEN)= =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 a= ff:{6}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0 =C2=A0IRQ: 128 vec:= 69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/{0-11} in-flight=3D0= d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-MSI/-X =C2=A0 =C2=A0= =C2=A0status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:943(---)
(XEN) =C2= =A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{= 6}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2=A0IRQ: 131 vec:81 P= CI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:= 941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:d9 PCI-MSI =C2=A0 =C2=A0 =C2=A0= =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d7:151(-M-)
(XEN) =C2= =A0 =C2=A0IRQ: 133 vec:c9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 = aff:{2}/{0-11} in-flight=3D0 d3:151(---)
(XEN) =C2=A0 =C2=A0IRQ: 134 vec= :99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11} in-flig= ht=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: 135 vec:a9 PCI-MSI =C2=A0 =C2= =A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D0= 30 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
(XEN) =C2=A0 =C2=A0IRQ: 137 = vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-f= light=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ: 138 vec:d1 PCI-MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{8}/{0-11} in-flight=3D0 d3:150(---)<= br>(XEN) Direct vector information:
(XEN) =C2=A0 =C2=A00x22 -> irq_mo= ve_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -> mce_intel.c#cmci_in= terrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel.c#intel_thermal_interr= upt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_interrupt()
(XEN) =C2=A0= =C2=A00xfa -> apic_timer_interrupt()
(XEN) =C2=A0 =C2=A00xfb -> c= all_function_interrupt()
(XEN) =C2=A0 =C2=A00xfc -> event_check_inter= rupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate_interrupt()
(XEN) =C2= =A0 =C2=A00xfe -> error_interrupt()
(XEN) =C2=A0 =C2=A00xff -> spu= rious_interrupt()
(XEN) IO-APIC interrupt information:
(XEN) =C2=A0 = =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2= =A02: vec=3Df0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 tr= ig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A01 Vec 57:=
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A01: vec=3D39 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000100
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec 64:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 delivery=3DLoPri dest=3DL status=3D= 0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2= =A04: vec=3D48 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 tr= ig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A05 Vec 80:=
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A05: vec=3D50 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec 88:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 delivery=3DLoPri dest=3DL status=3D= 0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2= =A07: vec=3D60 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 tr= ig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A08 Vec104:=
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A08: vec=3D68 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00= 000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec176:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin =C2=A09: vec=3Db0 delivery=3DLoPri dest=3DL status=3D= 0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000100
(XEN) =C2=A0 = =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 10: vec= =3D78 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 11 Vec136:
(XEN) =C2= =A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL sta= tus=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) = =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 2: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig= =3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 13 Vec152:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001
= (XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0= trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 15 Vec168:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 16 Vec184:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 16: vec=3Db8 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) =C2=A0 =C2=A0 IRQ 17 Vec21= 6:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 17: vec=3Dd8 delivery=3DLoP= ri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000= 400
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec192:
(XEN) =C2=A0 =C2=A0 =C2=A0 Api= c 0x00, Pin 18: vec=3Dc0 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 = irr=3D0 trig=3DL mask=3D0 dest_id:00000100
(XEN) =C2=A0 =C2=A0 IRQ 19 Ve= c161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 19: vec=3Da1 delivery=3D= LoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00= 000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec232:
(XEN) =C2=A0 =C2=A0 =C2=A0 = Apic 0x00, Pin 20: vec=3De8 delivery=3DLoPri dest=3DL status=3D0 polarity= =3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ = 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 83: vec=3D41 delive= ry=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_= id:00000010

=C2=A0Name =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0ID =C2=A0 Mem VCPUs State Time(s)
Domain-0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0 =C2=A04080 =C2=A0 =C2=A0 6 = =C2=A0 =C2=A0 r----- =C2=A0 =C2=A0 288.6
sys-usb =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A03 =C2=A0 284 =C2=A0 =C2=A0 2 =C2=A0 = =C2=A0 -b---- =C2=A0 =C2=A0 =C2=A020.5
sys-usb-dm =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 4 =C2=A0 144 =C2=A0 =C2=A0 1 =C2=A0 =C2=A0 -b---- = =C2=A0 =C2=A0 =C2=A0 3.5
openbsd-71 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 7 =C2=A0 511 =C2=A0 =C2=A0 2 =C2=A0 =C2=A0 -b---- =C2=A0 =C2=A0 = =C2=A063.0
openbsd-71-dm =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A08 =C2=A0 = 144 =C2=A0 =C2=A0 1 =C2=A0 =C2=A0 -b---- =C2=A0 =C2=A0 =C2=A014.0

How I can enable install this debug hypervisor= ? I have problems finding anything about it.

I don= 't have logs with qemu in the name, instead I have gmp-proxy logs. But = their all looks empty.

BR Adam

=
pon., 19 w= rz 2022 o 11:21=C2=A0Roger Pau Monn=C3=A9 <roger.pau@citrix.com> napisa=C5=82(a):
On Fri, Sep 16, 2022 at 05:08:59PM= +0200, Adam Szewczyk wrote:
> Sorry, I always forgot that default answer is "answer" to no= t "answer to
> all".
>
> My xl dmesg after calling those debug-keys is:

Trimming the trace:

> (XEN) MSI information:

> (XEN)=C2=A0 MSI=C2=A0 =C2=A0 125 vec=3D72 lowest=C2=A0 edge=C2=A0 =C2= =A0assert=C2=A0 log lowest dest=3D00000100
> mask=3D0/=C2=A0 /?

> (XEN)=C2=A0 MSI=C2=A0 =C2=A0 138 vec=3D62 lowest=C2=A0 edge=C2=A0 =C2= =A0assert=C2=A0 log lowest dest=3D00000001
> mask=3D0/=C2=A0 /?
> (XEN)=C2=A0 MSI=C2=A0 =C2=A0 139 vec=3D6a lowest=C2=A0 edge=C2=A0 =C2= =A0assert=C2=A0 log lowest dest=3D00000010
> mask=3D0/=C2=A0 /?

> (XEN) IRQ information:

> (XEN)=C2=A0 =C2=A0 IRQ: 125 vec:72 PCI-MSI=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0status=3D030 aff:{8}/{0-11}
> in-flight=3D0 d94:151(-M-)

> (XEN)=C2=A0 =C2=A0 IRQ: 138 vec:62 PCI-MSI=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0status=3D030 aff:{0}/{0-11}
> in-flight=3D0 d92:151(---)
> (XEN)=C2=A0 =C2=A0 IRQ: 139 vec:6a PCI-MSI=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0status=3D010 aff:{4}/{0-11}
> in-flight=3D0 d92:150(---)

Was domain with ID 94 your OpenBSD box? There's another domain with
passthrough devices (ID 92).

If your OpenBSD domain is the one with ID 94 it seems like the
interrupt source is masked, so no interrupts will be injected to the
guest.=C2=A0 That however might be just the response from the guest after seeing that the interrupt source is not behaving correctly.

Are yuo using a debug hypervisor? If not it would be helpful to do so,
in order to maybe get more information on `xl dmesg`.

Can you also paste the QEMU log for the OpeNSD domain?=C2=A0 Those logs are=
in /var/log/xen/qemu-dm-<domain name>.log, on most distros, not sure<= br> if QubesOS puts them at the same place.

Regards, Roger.
--000000000000b9296e05e916f69a-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 07:54:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 07:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409185.652127 (Exim 4.92) (envelope-from ) id 1oaY5k-0007gR-Ad; Tue, 20 Sep 2022 07:54:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409185.652127; Tue, 20 Sep 2022 07:54:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaY5k-0007gK-7r; Tue, 20 Sep 2022 07:54:52 +0000 Received: by outflank-mailman (input) for mailman id 409185; Tue, 20 Sep 2022 07:54:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaY5i-0007gE-Sz for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 07:54:51 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00064.outbound.protection.outlook.com [40.107.0.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 808a6463-38b9-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 09:54:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7509.eurprd04.prod.outlook.com (2603:10a6:20b:23e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Tue, 20 Sep 2022 07:54:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 07:54:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 808a6463-38b9-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A4YKNw/oK8rliBYu8SC5HdMwrOTaWXxtMrJVcFUtR0DPuyfEiHV12NhHnSq7oCg+TfH1PZoEGBrnpVjolNloYzIVlpVea2/ATsVZlOb23Ooe02JqjmfiU6EpGArOOOkkLbXWYVyw6Z71x5qw96YWhNINAcdLX0U1JQj95wwpXas7p2WLKaZdJct6NIyKPX8ec+vBAj74Eix8REiHmQMJSAGsh6S+ZQdFzGRpI/29Xepj/ZK82bJxOizj+FC5LYKWi2BdMuwrDyH3zsZ2p5gRgcABebzmJclyoRH/x2z3gSXvksSlLgo90+fCBNoa5JBxlmDg+hSdMlaBf1PXKJaAng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MysRIsQ17qDd1LEt6AIEzjoRbiXpSHgN+WMUcuepDKU=; b=IpuRPNmEHlQ8+IlOe3ThCrTs7tBeWPGhLpZlhmxniyq5y1KyIy9U5/o2l1NEFqYHO8NSVFMmLLIRH24kXXTfhmB7tBQj3k8T+53DKP+1bWKItEWfZUC8zndRPsUx06YtOYgIUx7wcJPrbQeSxj3pDMk7aIvoyhKUm2h9DFBUC//9VhUR1lVweMfLftbv40mFiCqpI4j1f7JFhEuCMipF0v+DZHlGP8BckB2SdtcZor8Idp+4pPa3fJR6v7DdEd5rghjo/ZFVq+OhTT4h81inSxhsExYT32AuXPoGXSUZP3NzXHGN36gu3xlPkyXapDpujl5antxc6zGoFM8wJarp1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MysRIsQ17qDd1LEt6AIEzjoRbiXpSHgN+WMUcuepDKU=; b=gVQVmSA8TmfTX7Y65YH6UNnnrcsnx6ST3JXLgsVAJ1Xj8E0qgNi/ko9GXZtTLZgWpA5pW1pkVPyCdEwzdg2Ib4i9xoHfZB5rbtRik+9j+7/io42RD+XR+K0WvsFQxii3wS7AB2bhtMI62r09DdtwROAG1KV5Q7cp5YoCza8tgJlBTksDqJ9qRQjlJ49F3gt32XzJlZNKgHR9xwJ5A/QjZq4BoXPFyOZsuJHGCN9R19oDf+OPvjkPXRsIAsvhVvAeoq9iosga9/LFtiD6W3Fodu+Ue3KOWkMoJ0My+5QLQ9rd+fscPyMXQPessMWnfF+j8xrGJLoqRF0QT1dfHI0RSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 20 Sep 2022 09:54:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for domains To: Stefano Stabellini Cc: Carlo Nonato , andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , "xen-devel@lists.xenproject.org" References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-7-carlo.nonato@minervasys.tech> <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com> <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0200.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7509:EE_ X-MS-Office365-Filtering-Correlation-Id: e68ff8c1-87cf-4983-ab6e-08da9add634f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7CwdgKi9RTcariMVm8g4YAtvch6S33E8wbcl0hLaplOk9LKkk7btQ99fVL+ES6cpjKid95uWZTKsYdCwiQ7NPt3KD4ILBV5SK7eLadSSAU17bc6Kj5BYd81m0Duqb8vBfX+H4HlMin1Acnd/tTRavOytq11A6xV9915St3cd3/Ln0Qn2DDjlIrfG9KA3RUapsmTgTBbgSbn3LOQ84+W2c5uTV6E7cq6+X9H25hIuE9SDS05nwzMHZ1cOG8ZaHgOFxEhS0UYSBFQX+0l8837CG8KhoIwLQhvAwoIzVQuZj5VwO6KKBDOzSZTg4nEKO9DWDq89xIs4YfycCLuXVXkuPJxmoSo+cO3nJ4q+tjL79MuztZsAH3HFy/dBFhJl3RGaaJ7QDNDtieiVd/cZxWfHz5oEA+4ghMd+4juGsBgMEdgU/3pjbt8Da9yYRUbjukAwJbYOz4q80P/Pn4QosgE/HNWVXVmFFw28V2Eqht3BR2MClNeXD+RXA0bvt1e68zcsVMf3gcDdl+ErowueE7WLJSYO8tiBbq8NeR4fvJMkzMGc2lpI3OsnO1yEUf5SgVwiTqsj83jQjExfTb++d/jAsgOgZYXXQ/GzKuVkICGwKjUS8yJRWn1/5ocDJ3q9DwMIEQX6MYUJU44a22q/6VYKaeA7DgSXJTbNose+u+HvZaoDCg8oTRWv36JkNpGOnQFGDXFV8Krlk3IFnX0J7HRcPUOdoHgdNtTUFLd9ZgT7m6efhJUhRLHpF+rs7p9e7m/53UBSElrxsllCZQbhhk7zaA6Cea0yvobx/6DvkRHwFcr5qqG4q9c7uW5oS4re2OJvtXqLrs+ATX23j+tYMYoWZRzKlcyLdfulUsZ11w/3ujo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(376002)(366004)(451199015)(31686004)(86362001)(31696002)(36756003)(54906003)(7416002)(4326008)(316002)(6916009)(966005)(478600001)(38100700002)(6486002)(6512007)(6506007)(26005)(66556008)(41300700001)(66476007)(2616005)(66946007)(8936002)(2906002)(5660300002)(8676002)(186003)(83380400001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2VtU3FHdEhWSkthYTRDYTdsRlc0WXltc051ZUxvTHJqRFEwUWRGYzlHdG9Z?= =?utf-8?B?WTl4ekRKK1JkZVBFTlBpZHoyR3dXU3JvV0ppdG5CT1k4U0c1eDdrNDhXZDJM?= =?utf-8?B?L3ZoSnlhNHJ2bkliRncwVGdIaFdlT2ZSdDNEWDQ3UG5jY3dROXZEQXNMTEtX?= =?utf-8?B?TkVKNHhKRW9FRi9yWlNNZFVkSDgyaG1aZFF1RXJxT0o0YnYweFFub2QzR3di?= =?utf-8?B?K2tCRWFiTzJmcmM5T3FWazE0NnVUa3hvQlYwVHVkR0JBb1p3cDYyQmpiRGda?= =?utf-8?B?Uy84b0RPQy8vWmZyalBid3RBY0ZxSmFOTVVYL2xNKyszV3lPZWl2TEFhMTlt?= =?utf-8?B?NVZjUmp4d09DMlVnamhyQ0ZFaTZTcVZWZ3pUUEsrMTBHTXhld05RMlNGaFBV?= =?utf-8?B?eDNubHRpT2hmSGNHOUhUeFpsQ21qS1Z5WXRqTmxaRXVDRFQzOHNmeHJyc3Zq?= =?utf-8?B?cXFMV0w4OUc2dDJVcHNiTVdrZGU1RDdLUzc1RkVVbVBVRHpJRUJwVnhuR2VY?= =?utf-8?B?QUpEbExuRmJmR3ZuNzdDa2I3dE96bDIxbkRIVHpjeGNuZ2paMjdyZlFyZTN1?= =?utf-8?B?cWlETHNydFJmNmpoWTduMk8zTzV5THFXbUtqQ3NXc0dxR2c5ZnZORkM0N2hK?= =?utf-8?B?OFV4cXlNL3NYUVlUZjhHYW9nWU01amk5ZkNHRVc1ckdoQ0lBVG9qK2hxYSt1?= =?utf-8?B?Umk1MXBRNVN2dnFHTm9NSDJmZ3pyYklJR2dQOUFWS3NVOGFpV2MrSXdHWXJQ?= =?utf-8?B?QkxyODhoVG9sRnJlODZZOXIrZ2FpMWJhYlJGSjRrL00rOWNxOVlLVzVRK1Bk?= =?utf-8?B?K1MxbGZhb1VsL3liQmFjaDVNSXJ3UlJ6UFFEZTJ0NnptREZzcHYvUXcwK3Rm?= =?utf-8?B?Z2Z2eklscTFLWCt2S3h0MVRCWVpqQmFPRjhhR2o1NU5DQVVQcUhqZ3NjYW8v?= =?utf-8?B?K3lCbUVzaWZaK3BnK0tTL2ppcW5zK2N0MFhXbHZFNlB4ZnJOOFY0MXpkYlNM?= =?utf-8?B?dGxmTWJDZnVIcTVvU29uMGNScU0wTWlhU0ZLZ0RXSmVWWDNyQUJYWDNJNnZ5?= =?utf-8?B?dGc3MzBIT09vV3FhaGcrU2lpeTBiV3dHaVdMazAvS3FkUG42b3Q1VkFMS1Vi?= =?utf-8?B?VVhmVkpwbE8wYWpxK0J2TzY4eTliRENybHNwbVNXSjNtUzNzZ3lOalVLYUNn?= =?utf-8?B?VnNRYldndlNSMFRYSXU5STVZVTBmRXdVdm1ETXpkL205YnFFMkh6NERCTUsy?= =?utf-8?B?aXpDOXhaVEcrR3MvZ2UzeFgxcVRRMms3d1NLSm1XUWVkTXhyeXd4K3RUQ2VB?= =?utf-8?B?c2FDaG5HV0U3bkZpWHNncHlBU0NrSVdCUERKOFY2MHZOMDJEY09OUUw0TnZR?= =?utf-8?B?amJ2MzBSRDd1b0lJRWZON3k5YTY1SkhLdThVMGsrVnBUeW9aTWhVUHJ5by8r?= =?utf-8?B?ekk0WjBFVk5jNDZ0L3l2cHVvUWZlZ1BESVNQdFFpT1h5QXNSdHYvYjlZRmxU?= =?utf-8?B?TjRVY2lIVmxoL3ZPWEdiMXVIeDNERjlCaktTTi9lMHV3NTNWaFU0ZjVOWm9C?= =?utf-8?B?U2VGdHNyWHMwU2dxbHlXa1ZTMkg5bkhJNkw4QWNBVGZ0czdQSWx5SERTOWU4?= =?utf-8?B?Y0h0ZjFJUnMrT3BYejBzQ0NYS01pVEY0V2hmSngvRHFMZ2RUckxPcEpmWkVt?= =?utf-8?B?WUZ4TGZGWU05QWtHcDhRcDVtMmVyb09jeFIxZEVsZzZySHNHbDRjUXcveE9E?= =?utf-8?B?UHllVGxBd01xd0JObzNwYXdVRkEvSWNSNnQrVmJzYWZmajRpM1BwZjY5TlVy?= =?utf-8?B?YjhyZWJaQ29wd3FBUllidjVqVTZwQjgzQUtRSVMwdk5VK3hkM2RFVmxNTmlX?= =?utf-8?B?V0JHVyttekdJaGI3VzV5aXIzWCs4UzlzZDl5dnBZR3ZNOTkxYWpMRllqZ1U5?= =?utf-8?B?RmIwUEczWkZNS1g2d0Z1VUM2SzlYc3A1VGFUTVBuak5XUGlrUUhtTEhYMUFS?= =?utf-8?B?ZFh0SHh3Z0crakdwNjRXVEhuZ3FIQzJqR25laER5UDZhVGtrRDA1U2cvc2tF?= =?utf-8?B?RWpZa1hiYnlhNVJ4bWpIY0kxRjc1WXp4QjNBcjViTXRwUTdTUmFUbHFiOVp6?= =?utf-8?Q?9N0fcydvtf6Gieg8r9OtQmK3P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e68ff8c1-87cf-4983-ab6e-08da9add634f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 07:54:47.3930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WUjxsK3+G9dwLTcML958QwYA46jtSWiAP14qF9U4DycnR3uI4jT44222RYnLedziz9jeTGSPgkU6GpAqwHJkMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7509 On 20.09.2022 00:42, Stefano Stabellini wrote: > On Mon, 19 Sep 2022, Jan Beulich wrote: >> On 16.09.2022 18:05, Carlo Nonato wrote: >>> On Thu, Sep 15, 2022 at 3:13 PM Jan Beulich wrote: >>>> On 26.08.2022 14:51, Carlo Nonato wrote: >>>>> --- a/xen/arch/arm/Kconfig >>>>> +++ b/xen/arch/arm/Kconfig >>>>> @@ -147,6 +147,18 @@ config MAX_CACHE_COLORS >>>>> colors at boot. Note that if, at any time, a color configuration with more >>>>> colors than the maximum will be employed an error will be produced. >>>>> >>>>> +config BUDDY_ALLOCATOR_SIZE >>>>> + string "Buddy allocator reserved memory size" if CACHE_COLORING >>>>> + default "64M" if CACHE_COLORING >>>>> + default "0M" if !CACHE_COLORING >>>> >>>> I don't understand the purpose of this last line, nor the two earlier >>>> "if". Why not simply >>>> >>>> config BUDDY_ALLOCATOR_SIZE >>>> string "Buddy allocator reserved memory size" >>>> depend on CACHE_COLORING >>>> default "64M" >>> >>> This was just to have a value for the config option even with cache coloring >>> disabled. All those ifs emulate the "depends on" keyword, but let the >>> CONFIG_BUDDY_ALLOCATOR_SIZE takes "0M" when coloring is disabled. With just >>> the "depends on" the macro isn't defined at all. I know that this can be >>> handled with some simple #ifdef, but I found this way to be more elegant. >>> Not an expert here so if you prefer the other way or a whole different one >>> (more readable/better fitted) please let me know. >> >> As far as I saw, the sole use was already inside a suitable #ifdef. Hence >> yes, I clearly would see "depends on" as the better fit. Please also don't >> forget that if later cache coloring would be enabled for another >> architecture, that default of zero (pre-recorded in a .config) would get >> in the way; one would need to manually change it (and remember to do so). >> >>>> Finally - how much of this is really Arm-specific? Shouldn't this be a >>>> common config option, perhaps merely restricted to Arm by the top level >>>> option (CACHE_COLORING?) depending on a further HAS_CACHE_COLORING, >>>> which only Arm would select? >>> >>> I'm sorry, but I don't understand your suggestion. BUDDY_ALLOCATOR_SIZE >>> is Arm specific because CACHE_COLORING is. In fact it depends only on this >>> last config value and not on Arm config directly. Why should someone limit >>> the buddy allocator when coloring isn't enabled? >> >> My comment wasn't on this on setting alone, but on the coloring ones as a >> set. >> >>> I've lost you on the HAS_CACHE_COLORING. Why should Arm config select this >>> one? Cache coloring must remain optional. I'm probably missing something. >> >> HAS_* settings only express what an arch is capable of; they don't replace >> dependent options which actually are user-selectable. (That said, we have >> a number where there's no user selection possible, but that's not of >> interest here.) >> >>>>> --- a/xen/arch/arm/coloring.c >>>>> +++ b/xen/arch/arm/coloring.c >>>>> @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config, >>>>> config->num_colors = (uint16_t)num; >>>>> } >>>>> >>>>> +unsigned int page_to_color(struct page_info *pg) >>>> >>>> The parameter will want to be pointer-to-const and I wonder whether ... >>>> >>>>> +{ >>>>> + return addr_to_color(page_to_maddr(pg)); >>>>> +} >>>> >>>> ... the function as a whole wouldn't be a good candidate for being an >>>> inline one (requiring addr_to_color() to be available in outside of >>>> this file, of course). >>> >>> You mean defining it as static inline in the coloring.h header? >> >> That would seem preferable for a simple function like this one. >> >>>>> +static void color_heap_insert_page(struct page_info *pg) >>>>> +{ >>>>> + struct page_info *pos; >>>>> + struct page_list_head *head = colored_pages(page_to_color(pg)); >>>>> + >>>>> + pg->count_info |= PGC_colored; >>>> >>>> The function isn't marked __init, so runtime correctness as to the >>>> (non-atomic) update here wants clarifying. >>> >>> Yes. I need to check and probably add a spin lock for the color heap. >> >> I'm afraid a spin lock won't help. May I suggest you look at some of >> the staticmem discussions that had happened, including a similar >> topic. (Sorry, I don't have a link at hand to the exact mail.) > > I searched through the recent staticmem discussions to try to provide a > helpful link for Carlo, but I don't think I managed to find what you had > in mind. I found these two lock-related emails: > > https://marc.info/?l=xen-devel&m=165476642832402 > https://marc.info/?l=xen-devel&m=165632461420257 > > If they are not relevant, could you please provide a few more details? Those aren't the ones. The point is that count_info is a somewhat odd field: It's not consistently updated under (all the same) lock, and it's also not consistently updated atomically. Hence new updates that appear in the code need properly justifying that the way updates are done there doesn't conflict with any other of the already existing updates. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 07:55:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 07:55:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409188.652137 (Exim 4.92) (envelope-from ) id 1oaY6J-0008Ec-JF; Tue, 20 Sep 2022 07:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409188.652137; Tue, 20 Sep 2022 07:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaY6J-0008EV-GS; Tue, 20 Sep 2022 07:55:27 +0000 Received: by outflank-mailman (input) for mailman id 409188; Tue, 20 Sep 2022 07:55:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaY6G-0007gE-CZ for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 07:55:26 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:3::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93ce8d26-38b9-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 09:55:22 +0200 (CEST) Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaY5v-001WMi-Uv; Tue, 20 Sep 2022 07:55:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93ce8d26-38b9-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=H0mXB3qLzd6nyp4U82pUC+0jG9YRP9G0sb9CuKu7rQc=; b=YCkxzsVunikesQe2vmc4oMq2Hn Jg33iFWFuD4QHdvq6fDWy8Z3gojgL0RTxp2wHVG11PD9SGiG94LnDwCfM0D5ZbFKC//BwQb83f5kt KwsNLeOUgUUU3MHlb6KJoYbFbSJuTfGC5UEoEajTXpzQIwfGeW85tyLb7xxH/Ao7q2EwK2BNuzYWc aNL14xoXbcw6ZY0YsF3QsrggrY8mOuwt3JZRUErGulwoWldPYHn9QdDr2suz3ZVXuunT+RoLnvWlg xDYTJiVsEp/MPK7zZcEyW9nsCtWowlraCvfA3e1XhM3BAyuqxe7ilU6LfUtfHbB5iLnEj7CYeZdr3 XHziMGFA==; Date: Tue, 20 Sep 2022 00:55:03 -0700 From: Christoph Hellwig To: Dongli Zhang Cc: iommu@lists.linux.dev, x86@kernel.org, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, sstabellini@kernel.org, linux@armlinux.org.uk, tsbogend@alpha.franken.de, jgross@suse.com, boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, m.szyprowski@samsung.com, konrad.wilk@oracle.com, robin.murphy@arm.com, hpa@zytor.com, oleksandr_tyshchenko@epam.com, joe.jin@oracle.com Subject: Re: [PATCH RFC v2 1/1] wiotlb: split buffer into 32-bit default and 64-bit extra zones Message-ID: References: <20220820074250.5460-1-dongli.zhang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820074250.5460-1-dongli.zhang@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Sat, Aug 20, 2022 at 12:42:50AM -0700, Dongli Zhang wrote: > Hello, > > I used to send out RFC v1 to introduce an extra io_tlb_mem (created with > SWIOTLB_ANY) in addition to the default io_tlb_mem (32-bit). The > dev->dma_io_tlb_mem is set to either default or the extra io_tlb_mem, > depending on dma mask. However, that is not good for setting > dev->dma_io_tlb_mem at swiotlb layer transparently as suggested by > Christoph Hellwig. > > https://lore.kernel.org/all/20220609005553.30954-1-dongli.zhang@oracle.com/ > > Therefore, this is another RFC v2 implementation following a different > direction. The core ideas are: > > 1. The swiotlb is splited into two zones, io_tlb_mem->zone[0] (32-bit) and > io_tlb_mem->zone[1] (64-bit). > > struct io_tlb_mem { > struct io_tlb_zone zone[SWIOTLB_NR]; > struct dentry *debugfs; > bool late_alloc; > bool force_bounce; > bool for_alloc; > bool has_extra; > }; > > struct io_tlb_zone { > phys_addr_t start; > phys_addr_t end; > void *vaddr; > unsigned long nslabs; > unsigned long used; > unsigned int nareas; > unsigned int area_nslabs; > struct io_tlb_area *areas; > struct io_tlb_slot *slots; > }; > > 2. By default, only io_tlb_mem->zone[0] is available. The > io_tlb_mem->zone[1] is allocated conditionally if: > > - the "swiotlb=" is configured to allocate extra buffer, and > - the SWIOTLB_EXTRA is set in the flag (this is to make sure arch(s) other > than x86/sev/xen will not enable it until it is fully tested by each > arch, e.g., mips/powerpc). Currently it is enabled for x86 and xen. > > 3. During swiotlb map, whether zone[0] (32-bit) or zone[1] (64-bit > SWIOTLB_ANY) > is used depends on min_not_zero(*dev->dma_mask, dev->bus_dma_limit). > > To test the RFC v2, here is the QEMU command line. > > qemu-system-x86_64 -smp 8 -m 32G -enable-kvm -vnc :5 -hda disk.img \ > -kernel path-to-linux/arch/x86_64/boot/bzImage \ > -append "root=/dev/sda1 init=/sbin/init text console=ttyS0 loglevel=7 swiotlb=32768,4194304,force" \ > -net nic -net user,hostfwd=tcp::5025-:22 \ > -device nvme,drive=nvme01,serial=helloworld -drive file=test.qcow2,if=none,id=nvme01 \ > -serial stdio > > There is below in syslog. The extra 8GB buffer is allocated. > > [ 0.152251] software IO TLB: area num 8. > ... ... > [ 3.706088] PCI-DMA: Using software bounce buffering for IO (SWIOTLB) > [ 3.707334] software IO TLB: mapped default [mem 0x00000000bbfd7000-0x00000000bffd7000] (64MB) > [ 3.708585] software IO TLB: mapped extra [mem 0x000000061cc00000-0x000000081cc00000] (8192MB) > > After the FIO is triggered over NVMe, the 64-bit buffer is used. > > $ cat /sys/kernel/debug/swiotlb/io_tlb_nslabs_extra > 4194304 > $ cat /sys/kernel/debug/swiotlb/io_tlb_used_extra > 327552 > > Would you mind helping if this is the right direction to go? > > Thank you very much! > > Cc: Konrad Wilk > Cc: Joe Jin > Signed-off-by: Dongli Zhang > --- > arch/arm/xen/mm.c | 2 +- > arch/mips/pci/pci-octeon.c | 5 +- > arch/x86/include/asm/xen/swiotlb-xen.h | 2 +- > arch/x86/kernel/pci-dma.c | 6 +- > drivers/xen/swiotlb-xen.c | 18 +- > include/linux/swiotlb.h | 73 +++-- > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 3d826c0..4edfa42 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -125,7 +125,7 @@ static int __init xen_mm_init(void) > return 0; > > /* we can work with the default swiotlb */ > - if (!io_tlb_default_mem.nslabs) { > + if (!io_tlb_default_mem.zone[SWIOTLB_DF].nslabs) { > rc = swiotlb_init_late(swiotlb_size_or_default(), > xen_swiotlb_gfp(), NULL); > if (rc < 0) First thing we need before doing anything about multiple default pools is to get all the knowledge of details hidden inside swiotlb.c. For swiotlb_init_late that seems easy as we can just move the check into it. > diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c > index e457a18..0bf0859 100644 > --- a/arch/mips/pci/pci-octeon.c > +++ b/arch/mips/pci/pci-octeon.c > @@ -654,6 +654,9 @@ static int __init octeon_pci_setup(void) > octeon_pci_mem_resource.end = > octeon_pci_mem_resource.start + (1ul << 30); > } else { > + struct io_tlb_mem *mem = &io_tlb_default_mem; > + struct io_tlb_zone *zone = &mem->zone[SWIOTLB_DF]; > + > /* Remap the Octeon BAR 0 to map 128MB-(128MB+4KB) */ > octeon_npi_write32(CVMX_NPI_PCI_CFG04, 128ul << 20); > octeon_npi_write32(CVMX_NPI_PCI_CFG05, 0); > @@ -664,7 +667,7 @@ static int __init octeon_pci_setup(void) > > /* BAR1 movable regions contiguous to cover the swiotlb */ > octeon_bar1_pci_phys = > - io_tlb_default_mem.start & ~((1ull << 22) - 1); > + zone->start & ~((1ull << 22) - 1); But we'll need to do something about this mess. I'll need help from the octeon maintainer on it. > - x86_swiotlb_flags |= SWIOTLB_ANY; > + x86_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_EXTRA; I don't think this is how it is suppoed to be. SWIOTLB_ANY already says give me a pool with no addressing constrains. We don't need two pools without that. EXTRA is also not exactly a very helpful name here. > #ifdef CONFIG_X86 > -int xen_swiotlb_fixup(void *buf, unsigned long nslabs) > +int xen_swiotlb_fixup(void *buf, unsigned long nslabs, unsigned int flags) > { > int rc; > unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT); > unsigned int i, dma_bits = order + PAGE_SHIFT; > dma_addr_t dma_handle; > phys_addr_t p = virt_to_phys(buf); > + unsigned int max_dma_bits = 32; I think live will be a lot simple if the addressing bits are passed to this function, and not some kind of flags. > +#define SWIOTLB_DF 0 > +#define SWIOTLB_EX 1 > +#define SWIOTLB_NR 2 These names are not very descriptive. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 08:01:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 08:01:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409201.652149 (Exim 4.92) (envelope-from ) id 1oaYBv-0001sO-Ko; Tue, 20 Sep 2022 08:01:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409201.652149; Tue, 20 Sep 2022 08:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYBv-0001sH-H8; Tue, 20 Sep 2022 08:01:15 +0000 Received: by outflank-mailman (input) for mailman id 409201; Tue, 20 Sep 2022 08:01:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYBu-0001sB-CG for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 08:01:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64c84f80-38ba-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 10:01:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9495.eurprd04.prod.outlook.com (2603:10a6:10:32f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 08:01:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 08:01:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64c84f80-38ba-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQr01c8i+RmBqil7veqyssJsLI/sJiR0FXpCJk4qZkFJ14nuIrcGPTwWwOSUYKU0/LyMuCjN3va0z2VfJb64jA7PeMHFtKwZ7TSypFNwErO9QF9SF/dHVFWVwysW0qrpcgG7e3eO+i1aXY+tatDpXi60aBZhzIAuqYovdW3/bw8kwXWGxrobGdkwpHvzA4rIS9W4BK3Ylsbpsh9bCOPbGgZFoxnvi4OuvDd8yhavNcb4l/XT18JgqCjQHslJJXNFwgPdVu9DB6Pbl3ApsUPAr1vColqtPmhgbadkRGa5kNhE2xtaZcI+1PzDsZUqVcl+ZaNiYr55STWv8Mb0odKTxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iGh7TJp3vd4Xz7oPly1MlJad6+tATQGi4gsDzYkglUw=; b=dF8fqDbCsInJdMCSVYBlq/a21zEcTDafX+MzBirXzWWoMrluZhYHY7QlKH4yB+HTJI7ar1HsA9U/Q2SsGeUhnqvZekzc/ivZJsAQJEvRoNpjTo3e0Ml91cPgbVIRJ1d3WeHPQaBlc6x/BBne0LRK67z/vYhYvX+II+QDHMWsGyII+mBJUp0I9ISUpVGPcb9biZogY7KOjJggANcGy1UjzI0dS38qaYK8pnUTHJwx4An/lS3rfcisAfiWsMX9kB1UBDHk4V4z1ZelnPdfAI3ZqUNK/egUQoLQjgmVO+LBWdldvz3Vcdu1C5vj0KdtXnfhUSLX00S0N0YmfIF1NYvrQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iGh7TJp3vd4Xz7oPly1MlJad6+tATQGi4gsDzYkglUw=; b=rKfecoa/tFGJNbqiu7JhnQsQ2lEKpNRa1zF6tioSfpzwdU39kGy2Y3cPuYtAzJ8ms/hNvbC5ytv+qr2m6lC3bvnIQd5XTT9Ob5zifhZkC6IT0i8tRh1IX1eSp7FoQ8fqpOHNQTuElhD88EyQzdrvwgVJEAWNb3xk8LlTKa9GsahMKqKFVna84ovzuCV7cMY4HEOrkPtahk8oMo3yJVUlEjO7L8PnB8jrPiXK7pW/hBeQ0qKkbv7fvUgm3grM+QZ5/J28P9Gn1pJVg3hEAu4iHOjyv1oRpoj/jmaxhE+GwwzjUrXdFFW64v7nzHylL5gQ/31nxna5nGU4HHfTypckVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> Date: Tue, 20 Sep 2022 10:01:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Boris Ostrovsky Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel , Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0556.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9495:EE_ X-MS-Office365-Filtering-Correlation-Id: 790c895a-f2e9-49db-a189-08da9ade47fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RCSK0Z/5382RL5NTFNj/r5HfE1JcNxIVhPvoYFxkNjK9g9dYXLXPdLfSPbUeiG72eXKque7mgstZwnUlhkSyCBaVAyKVC968RKrU0DNe4mf+xVevQIFuHye+3/KoBm9DikY2dPQpauBw+BRkhBFxD9FRdxPQqUMeChjt8HUFDAPFoW6/CZLezaCfByB8TN79IrKRxIZU1tWBf634y2tUfVzCU3lU+cfuVkLX1GUoRFh6FrvY9MJlfz539PxiJMDyCLoVbxv7VQWOV5NBuh13CBwVzZuiwzy0Sr/UDxQ7dnZhBGhMR4ihzRvF4K/hdgtUWWUAXD4fKt2lcXF2CtECiYFp5ZrSm9PUWcEx8SfAU5Brr/ayWYAXEriRey5pqQCNy5PMJyeuejCM1a4yb1pVmxhAr+LPhj0QXM7nCj4WAqDNYOhr//T1ZwlsmGk06xK88CxO9oAP9NGBmYNQM3ROyimUXBOe3kcOskR6RNFMQlz7lHc5sZ4iLGXhy8RLQaPVWvVuJyPEA4YPbwHD1IXVlDRJKlp7mzpAxJBL8ouJL0OMscPK2u1zKULTDMvL/CkMtDyAJJi5elkeZen5pfvhW6ykTauRPDzqEcxVHItj0CJomsdTSF2ccHm15j+1TLQqUGdG172VuS2UizLri4zmDNAlrORqKodXkr6/5SJgf8Ewb+ztVbes5i59Ezide02RSNsEpQf8+iNJOd99/zbXx8I6Ewk1Npw7t5SCRqCEXfoWWGkl0ZqpwN5xq/l9g/J4bhpes830RXnTlPg0iFygn9eAsgyN6YDlN5JyFDKvqsk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(346002)(396003)(366004)(451199015)(6486002)(478600001)(31696002)(86362001)(8936002)(41300700001)(5660300002)(8676002)(316002)(54906003)(6916009)(66556008)(66476007)(4326008)(66946007)(38100700002)(2616005)(186003)(53546011)(6506007)(6512007)(26005)(66574015)(83380400001)(36756003)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFFMbW1RVFhrZ2ZDQUV1VmxnQW1sUmloNzJMRWtuMEUyWkRBMjJqc2hYSk96?= =?utf-8?B?S05lMXZkRG0xaHB1aE1yN1RVdnBySzh3UjNvOFlGMEMvZU0wdGFsNVNPZ2Y5?= =?utf-8?B?KzQ2bWMzeXVhWXFobXBQTW9Xb2lvbC9zSlJmTlhlcGV2ZDNWamovQndaNFhp?= =?utf-8?B?aG5yTDREQVRMdFVlYUk1OWg1VGQzT2JSaHZ2bW82V0pnRmozRW9GT1ZjeG15?= =?utf-8?B?aE1UenY5dGwxT0hnaTVsZUFVd2xDc243Sy9rdlBodzZMT3lHUytnSlFzbDhH?= =?utf-8?B?emtDa2RCRjFxbE9hZW5RVGJ4NDk0RW1sWnVoRzZYNnVMYVovWjNmK004ZVVH?= =?utf-8?B?c0p6VUg5Q1ZJcFVMcUh3SFBISnd5ZTgzQWxOVzRaVVgwNXNTL1NIOGFpcmtQ?= =?utf-8?B?OWwzZ3NCa3dkMFhmN2FuTkN6Wm9MZ29YZ251cjgzYithaTFxamZzbkFadzln?= =?utf-8?B?UnJxelF6bXplUmxob1I2NlMxU2pPazdEN2J4WWliMkVPS1hzK1dKOG5rT0NN?= =?utf-8?B?NlFlc21rVHAyNHJsTVRCZGlGdDRoNm81clNsM3NhNkJLK1dsbzNGYTBkUTFO?= =?utf-8?B?MDRuZTVzeEtFMkxPbjNySXg4NFJUWEJJRFV6NEc1dzVrV0FOTUNvUVBmMkU5?= =?utf-8?B?QmgxUWw4Y0NZb1NsaHdWTUp1V3lkZzlaVlVSSkdlMDBXUnVmK1JlZDN1dm1I?= =?utf-8?B?RGFVZHg0TXgzYlBnZm9Gd3Q0clcxUFRCTGYzMDJSOTN5K3Vib1FldnQ2MzFE?= =?utf-8?B?ZWV4Y3JFZW5HbTZhYzZaeU9iUFRTdVdXOXhvdmdwaGNobDZHUEhmMEowaERO?= =?utf-8?B?Vk9wNHVxdWZZVmxpZlFVdTVldmNrQVVDRGlDcjN3N3RWZ3lNQm5ERDJ5bWQ4?= =?utf-8?B?VHl6TWdSN0hqK09UQjZzZVo0R1dQQzBrMFVVU2hmQmhmY3lnbnl3enNwVlpu?= =?utf-8?B?dUp1bWJUaGlNVEF3VU5UdGcrVTdXcy9rQTZRbVZsWFhKYnhMVHhXS1JKdGlR?= =?utf-8?B?b3loS1ZYODFQN21kMXJWa28ydWMzQnJCbDhEalBPS2ZONlh2VWttMlA0d25L?= =?utf-8?B?M0IvR3hDYkp1NUw5N2hxT2FyWUlyRDVrY1lLYXArTi8xSnNLMHVUOVZ4NmRP?= =?utf-8?B?OFh6MkszcXNYTGVVblpXQkJCU1JObDRTaFc3WVZFeWFSMEtmaCtJUVp6UmRT?= =?utf-8?B?RjMyeE4vbnB5ejhtbDRrcUIzd2M5cFUrTnVzN2FGUzIza1M1SlI2ZzI4WW14?= =?utf-8?B?Nmk2TGYyeDNhblBYWmVEK2k0MEp2UTNySE5oL1JiNi90ODd2eXl0Z3dQSWVT?= =?utf-8?B?WUoxdExQTDA3QlFuUXIyQzhHNDhqMDY5RkRJUnl2bzJENHhyZndXTm11V0p4?= =?utf-8?B?dlR3am01N0VuSTc4SmJrcmhvd0R3RWY0WmplVnZjb1NIY25ycVBvdXFmUEVH?= =?utf-8?B?WEdrdFo2T1BTd2xaOC9SbEs3Q2FsUTZNa3g2eXJZMk1mdzFpUE9nVXE1cVBy?= =?utf-8?B?R0MxdzFmSWZ0aXVKS0dqMS9JNExROC85NjFGTHBneXZvYTRVbmZUU3hNNmd0?= =?utf-8?B?NTBzK1lIblBKQ0FJWnRleTlEOEsrNitpL0diMmFzb0lqR3VyTTFMckV3V2M0?= =?utf-8?B?bTY4andmcUt2VUNYWWZQZGVnZ1B4M09QWHdrbWxzNFFYcEd0bW5tdHVqREtL?= =?utf-8?B?YVlBb2V0RjE4Q2ptNFQ3dGVEQ2dVQmFRTHlaa0dPRXZ0S0pZczNFN2djekdn?= =?utf-8?B?NHNDTmwxZ056WU1QU2tPMkdMSlc0N29qb0lkRjU4cy8zUC9pN2Jyc3ZFTWx4?= =?utf-8?B?endwaktZRWF6OWhTbDhQejFEZ2hSYnRSQ2xQdm55SU54RkllUmVBVm5NQ0lH?= =?utf-8?B?bHhYVms0UU13M1htZlpZcGVFNjVvcjhIUnR6ekhjVUYzMWxOUzljMVlZWXk3?= =?utf-8?B?aDA5Mk1WVCt1eCtiMFZZSTJRWThWbmFWY0FyM2wyTmsrTDB6Q0U0ZSsyb1ZV?= =?utf-8?B?d1gzTHRjd3V3Y1V3R1dHYUROeVFNbGZ1VWFFL2xFMEx2TThFQWU2VFREL1Uw?= =?utf-8?B?TjBPWFd4OHFGWkpPeEIwb3dpRnZsRjJVYVRmbDd3T1hWYTZ5cWp5dDI5UG1B?= =?utf-8?Q?vdGwt6ylGWglMCEV9OEORZhhD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 790c895a-f2e9-49db-a189-08da9ade47fb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 08:01:10.8999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H6YEjfg0NaWh5V44FnTsz8A+jJoFmfOBmLhTOCLp0BZ0ulX4CIOhyixySDOwcffMUGQPb1nGCRyN2oTtMsSlNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9495 On 20.09.2022 00:42, Boris Ostrovsky wrote: > > > On 9/19/22 10:56 AM, Jan Beulich wrote: >> On 19.09.2022 16:11, Tamas K Lengyel wrote: >>> On Mon, Sep 19, 2022 at 9:58 AM Jan Beulich wrote: >>> >>>> On 19.09.2022 15:24, Tamas K Lengyel wrote: >>>>> On Mon, Sep 19, 2022 at 9:21 AM Jan Beulich wrote: >>>>>> >>>>>> On 19.09.2022 14:25, Tamas K Lengyel wrote: >>>>>>> On Mon, Sep 19, 2022 at 5:28 AM Jan Beulich wrote: >>>>>>>> >>>>>>>> On 16.09.2022 23:35, Boris Ostrovsky wrote: >>>>>>>>> >>>>>>>>> On 9/16/22 8:52 AM, Jan Beulich wrote: >>>>>>>>>> On 15.09.2022 16:01, Tamas K Lengyel wrote: >>>>>>>>>>> While experimenting with the vPMU subsystem an ASSERT failure was >>>>>>>>>>> observed in vmx_find_msr because the vcpu_runnable state was true. >>>>>>>>>>> >>>>>>>>>>> The root cause of the bug appears to be the fact that the vPMU >>>> subsystem >>>>>>>>>>> doesn't save its state on context_switch. >>>>>> >>>>>> For the further reply below - is this actually true? What is the >>>>>> vpmu_switch_from() (resolving to vpmu_save()) doing then early >>>>>> in context_switch()? >>>>>> >>>>>>>>>>> The vpmu_load function will attempt >>>>>>>>>>> to gather the PMU state if its still loaded two different ways: >>>>>>>>>>> 1. if the current pcpu is not where the vcpu ran before doing >>>> a remote save >>>>>>>>>>> 2. if the current pcpu had another vcpu active before doing a >>>> local save >>>>>>>>>>> >>>>>>>>>>> However, in case the prev vcpu is being rescheduled on another >>>> pcpu its state >>>>>>>>>>> has already changed and vcpu_runnable is returning true, thus #2 >>>> will trip the >>>>>>>>>>> ASSERT. The only way to avoid this race condition is to make sure >>>> the >>>>>>>>>>> prev vcpu is paused while being checked and its context saved. >>>> Once the prev >>>>>>>>>>> vcpu is resumed and does #1 it will find its state already saved. >>>>>>>>>> While I consider this explanation plausible, I'm worried: >>>>>>>>>> >>>>>>>>>>> --- a/xen/arch/x86/cpu/vpmu.c >>>>>>>>>>> +++ b/xen/arch/x86/cpu/vpmu.c >>>>>>>>>>> @@ -419,8 +419,10 @@ int vpmu_load(struct vcpu *v, bool_t >>>> from_guest) >>>>>>>>>>> vpmu = vcpu_vpmu(prev); >>>>>>>>>>> >>>>>>>>>>> /* Someone ran here before us */ >>>>>>>>>>> + vcpu_pause(prev); >>>>>>>>>>> vpmu_save_force(prev); >>>>>>>>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>>>>>>>> + vcpu_unpause(prev); >>>>>>>>>>> >>>>>>>>>>> vpmu = vcpu_vpmu(v); >>>>>>>>>>> } >>>>>>>>>> We're running with IRQs off here, yet vcpu_pause() waits for the >>>> vcpu >>>>>>>>>> to actually be de-scheduled. Even with IRQs on this is already a >>>>>>>>>> relatively heavy operation (also including its impact on the remote >>>>>>>>>> side). Additionally the function is called from context_switch(), >>>> and >>>>>>>>>> I'm unsure of the usability of vcpu_pause() on such a path. In >>>>>>>>>> particular: Is there a risk of two CPUs doing this mutually to one >>>>>>>>>> another? If so, is deadlocking excluded? >>>>>>>>>> >>>>>>>>>> Hence at the very least I think the description wants extending, to >>>>>>>>>> discuss the safety of the change. >>>>>>>>>> >>>>>>>>>> Boris - any chance you could comment here? Iirc that's code you did >>>>>>>>>> introduce. >>>>>>>>> >>>>>>>>> >>>>>>>>> Is the assertion in vmx_find_msr() really needs to be for runnable >>>> vcpu or can it be a check on whether vcpu is actually running (e.g. >>>> RUNSTATE_running)? >>>>>>>> >>>>>>>> You cannot safely check for "running", as "runnable" may transition >>>>>>>> to/from "running" behind your back. >>>>>>> >>>>>>> The more I look at this the more I think the only sensible solution is >>>>>>> to have the vPMU state be saved on vmexit for all vCPUs. >>>>>> >>>>>> Do you really mean vmexit? It would suffice if state was reliably >>>>>> saved during context-switch-out, wouldn't it? At that point the >>>>>> vCPU can't be resumed on another pCPU, yet. >>>>>> >>>>>>> That way all >>>>>>> this having to figure out where and when a context needs saving during >>>>>>> scheduling goes away. Yes, it adds a bit of overhead for cases where >>>>>>> the vCPU will resume on the same pCPU and that context saved could >>>>>>> have been skipped, >>>>>> >>>>>> If you really mean vmexit, then I'm inclined to say that's more >>>>>> than just "a bit of overhead". I'd agree if you really meant >>>>>> context-switch-out, but as said further up it looks to me as if >>>>>> that was already occurring. Apparently I'm overlooking something >>>>>> crucial ... >>>>> >>>>> Yes, the current setup is doing exactly that, saving the vPMU context >>>>> on context-switch-out, and that's where the ASSERT failure occurs >>>>> because the vCPU it needs to save the context for is already runnable >>>>> on another pCPU. >>>> >>>> Well, if that's the scenario (sorry for not understanding it that >>>> way earlier on), then the assertion is too strict: While in context >>>> switch, the vCPU may be runnable, but certainly won't actually run >>>> anywhere. Therefore I'd be inclined to suggest to relax the >>>> condition just enough to cover this case, without actually going to >>>> checking for "running". >>>> >>> >>> What ensures the vCPU won't actually run anywhere if it's in the runnable >>> state? >> >> The fact that the vCPU is the subject of context_switch(). >> >>> And how do I relax the condition just enough to cover just this case? >> >> That's the more difficult question. The immediate solution, passing a >> boolean or flag to vpmu_switch_from(), may not be practical, as it >> would likely mean passing this through many layers. >> >> Utilizing that I have Jürgen sitting next to me, I've discussed this >> with him, and he suggested to simply check for v == current. And >> indeed - set_current() in context_switch() happens a few lines after >> vpmu_switch_from(). > > > > It is saving vpmu data from current pcpu's MSRs for a remote vcpu so @v > in vmx_find_msr() is not @current: > > vpmu_load() > ... > prev = per_cpu(last_vcpu, pcpu); > vpmu_save_force(prev) > core2_vpmu_save() > __core2_vpmu_save() > vmx_read_guest_msr() > vmx_find_msr() > > > The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder though whether > this call is needed when code path above is executed (i.e. when we are saving > remove vcpu) How could it not be needed? We need to obtain the guest value. The thing I don't understand is why this forced saving is necessary, when context_switch() unconditionally calls vpmu_switch_from(). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 08:13:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 08:13:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409210.652160 (Exim 4.92) (envelope-from ) id 1oaYNg-0003Ri-Sl; Tue, 20 Sep 2022 08:13:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409210.652160; Tue, 20 Sep 2022 08:13:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYNg-0003Rb-PO; Tue, 20 Sep 2022 08:13:24 +0000 Received: by outflank-mailman (input) for mailman id 409210; Tue, 20 Sep 2022 08:13:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYNe-0003RV-Hi for xen-devel@lists.xen.org; Tue, 20 Sep 2022 08:13:23 +0000 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [2607:f8b0:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 133ba715-38bc-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 10:13:15 +0200 (CEST) Received: by mail-pl1-x633.google.com with SMTP id f23so1613333plr.6 for ; Tue, 20 Sep 2022 01:13:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 133ba715-38bc-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=opcyzx6BRUE4Gx/VuLLL7PZ1mjeghnOpID4J2zs2kGA=; b=bdyeSB/cVNAF0E5BkzrKUiTJJS1oRn0rrHI7WgQTZCybx3JnXSVhs8tHj6FxnnDlcV 9BohFAIcBGdr8peqooACK9XpAl23jWlmCqVo47pXdqzOq50qXPgkuB/8Tx6Jfsirg3Dd cO1/qr7Gp5WIWaHFnCFNaA08nQ1uzNCdNSmlnyKsrjBZ+ux/gK8+B8IbY7I4qizBDHCk koNxvns6dh2G/pP+5uM5jU6CF0cD1+ysLrFwIhiDCTFUGAHSNGwPpwmBC1yaPyDwZmZ3 dKUx6lJ6gW0FsnwRbjzy2c5pKozxL/zvuNqG0c2vMvUUjP2JaGEa/YHcu2zWUOErjbvv c1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=opcyzx6BRUE4Gx/VuLLL7PZ1mjeghnOpID4J2zs2kGA=; b=TJjmijIif87bPrfBKzGq/TYL9gHlMwTFRBlpCibY8HmCA9mNdUEiLRw6ZVUZBaa3lZ UYyxoAUZM2tAWcakE/kBoye5WIKV9dBRyJG2DpCcslQ2FlYLHNrjjz5KevdT5fwXSSLe RxhPyG8D9gEDt60ZPf7lYcqEGzMrzWQiTq5oATCUD4IWzXcBYkVirRM4xJWKl1zjTugl WYL2GEhbu/MRubdSLwsm8yx/UGxipfcSfIwttFNihxojEnvaOEwYGKYT7fghEcaBUwIm APn5u6OBXXSemALLNyMskrNVu1BbvK4JEd0P8pkpf/vorO/RVUK+pV8gOLMSSQWQxbes 5YqA== X-Gm-Message-State: ACrzQf1RApJnHegpHrMBqze+CX3ylXjIrVkV2aUZzkQgj1Gay54bou0+ BHI+SPCBimNgfqPiYOrty42N0ZXBjs29NHKMtF/Lo+XmpkA= X-Google-Smtp-Source: AMsMyM5XVWw0QVHVTiefnIiEq75Wh51q/wJBW/a8YP19HEUROWjRdka8sDvFX+NIM7IMDNlK/eBJno1Ogf0kaEQpyrY= X-Received: by 2002:a17:90a:f291:b0:200:acc9:422d with SMTP id fs17-20020a17090af29100b00200acc9422dmr2512629pjb.21.1663661591774; Tue, 20 Sep 2022 01:13:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Szewczyk Date: Tue, 20 Sep 2022 10:12:58 +0200 Message-ID: Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000344bfe05e9176609" --000000000000344bfe05e9176609 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On, log section i Qubes manager also those logs are empty, but I can attach /var/log/xen/console/guest-openbsd-71-dm.log: [2022-09-19 19:50:55] Logfile Opened [2022-09-19 19:50:56] Linux version 5.10.105-xen-stubdom (mockbuild@0c9ad8f2058f40c49bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld version 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022 [2022-09-19 19:50:56] Command line: [2022-09-19 19:50:56] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [2022-09-19 19:50:56] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [2022-09-19 19:50:56] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [2022-09-19 19:50:56] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 25= 6 [2022-09-19 19:50:56] x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'standard' format. [2022-09-19 19:50:56] Released 0 page(s) [2022-09-19 19:50:56] BIOS-provided physical RAM map: [2022-09-19 19:50:56] Xen: [mem 0x0000000000000000-0x000000000009ffff] usable [2022-09-19 19:50:56] Xen: [mem 0x00000000000a0000-0x00000000000fffff] reserved [2022-09-19 19:50:56] Xen: [mem 0x0000000000100000-0x0000000008ffffff] usable [2022-09-19 19:50:56] NX (Execute Disable) protection: active [2022-09-19 19:50:56] Hypervisor detected: Xen PV [2022-09-19 19:50:56] tsc: Fast TSC calibration failed [2022-09-19 19:50:56] tsc: Detected 2591.990 MHz processor [2022-09-19 19:50:56] last_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000 [2022-09-19 19:50:56] x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC [2022-09-19 19:50:56] RAMDISK: [mem 0x02000000-0x03f7afff] [2022-09-19 19:50:56] Zone ranges: [2022-09-19 19:50:56] DMA32 [mem 0x0000000000001000-0x0000000008ffffff= ] [2022-09-19 19:50:56] Normal empty [2022-09-19 19:50:56] Movable zone start for each node [2022-09-19 19:50:56] Early memory node ranges [2022-09-19 19:50:56] node 0: [mem 0x0000000000001000-0x000000000009ffff] [2022-09-19 19:50:56] node 0: [mem 0x0000000000100000-0x0000000008ffffff] [2022-09-19 19:50:56] Initmem setup node 0 [mem 0x0000000000001000-0x0000000008ffffff] [2022-09-19 19:50:56] On node 0, zone DMA32: 1 pages in unavailable ranges [2022-09-19 19:50:56] On node 0, zone DMA32: 96 pages in unavailable ranges [2022-09-19 19:50:56] On node 0, zone DMA32: 28672 pages in unavailable ranges [2022-09-19 19:50:56] p2m virtual area at (____ptrval____), size is 200000 [2022-09-19 19:50:56] Remapped 0 page(s) [2022-09-19 19:50:56] [mem 0x09000000-0xffffffff] available for PCI devices [2022-09-19 19:50:56] Booting paravirtualized kernel on Xen [2022-09-19 19:50:56] Xen version: 4.14.5 (preserve-AD) [2022-09-19 19:50:56] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns [2022-09-19 19:50:56] Built 1 zonelists, mobility grouping on. Total pages: 36170 [2022-09-19 19:50:56] Kernel command line: clocksource=3Dtsc [2022-09-19 19:50:56] Dentry cache hash table entries: 32768 (order: 6, 262144 bytes, linear) [2022-09-19 19:50:56] Inode-cache hash table entries: 16384 (order: 5, 131072 bytes, linear) [2022-09-19 19:50:56] mem auto-init: stack:byref_all(zero), heap alloc:off, heap free:off [2022-09-19 19:50:56] Memory: 96968K/147068K available (6145K kernel code, 842K rwdata, 428K rodata, 696K init, 476K bss, 49848K reserved, 0K cma-reserved) [2022-09-19 19:50:56] random: get_random_u64 called from 0xffffffff810a0f18 with crng_init=3D0 [2022-09-19 19:50:56] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs= =3D1, Nodes=3D1 [2022-09-19 19:50:56] Using NULL legacy PIC [2022-09-19 19:50:56] NR_IRQS: 4352, nr_irqs: 24, preallocated irqs: 0 [2022-09-19 19:50:56] xen:events: Using FIFO-based ABI [2022-09-19 19:50:56] printk: console [hvc0] enabled [2022-09-19 19:50:56] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns [2022-09-19 19:50:56] installing Xen timer for CPU 0 [2022-09-19 19:50:56] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x255cad98bda, max_idle_ns: 440795306906 ns [2022-09-19 19:50:56] Calibrating delay loop (skipped), value calculated using timer frequency.. 5183.98 BogoMIPS (lpj=3D10367960) [2022-09-19 19:50:56] pid_max: default: 4096 minimum: 301 [2022-09-19 19:50:56] Mount-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-19 19:50:56] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-19 19:50:56] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8 [2022-09-19 19:50:56] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4 [2022-09-19 19:50:56] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (family: 0x6, model: 0x9e, stepping: 0xa) [2022-09-19 19:50:56] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization [2022-09-19 19:50:56] Spectre V2 : Mitigation: Retpolines [2022-09-19 19:50:56] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch [2022-09-19 19:50:56] Spectre V2 : Enabling Restricted Speculation for firmware calls [2022-09-19 19:50:56] Spectre V2 : mitigation: Enabling conditional Indirect Branch Prediction Barrier [2022-09-19 19:50:56] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and seccomp [2022-09-19 19:50:56] SRBDS: Unknown: Dependent on hypervisor status [2022-09-19 19:50:56] MDS: Mitigation: Clear CPU buffers [2022-09-19 19:50:56] Performance Events: unsupported p6 CPU model 158 no PMU driver, software events only. [2022-09-19 19:50:56] devtmpfs: initialized [2022-09-19 19:50:56] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [2022-09-19 19:50:56] futex hash table entries: 16 (order: -4, 384 bytes, linear) [2022-09-19 19:50:56] NET: Registered protocol family 16 [2022-09-19 19:50:56] xen:grant_table: Grant tables using version 1 layout [2022-09-19 19:50:56] Grant table initialized [2022-09-19 19:50:56] PCI: setting up Xen PCI frontend stub [2022-09-19 19:50:56] xen:balloon: Initialising balloon driver [2022-09-19 19:50:56] usbcore: registered new interface driver usbfs [2022-09-19 19:50:56] usbcore: registered new interface driver hub [2022-09-19 19:50:56] usbcore: registered new device driver usb [2022-09-19 19:50:56] PCI: System does not support PCI [2022-09-19 19:50:56] clocksource: Switched to clocksource xen [2022-09-19 19:50:56] NET: Registered protocol family 2 [2022-09-19 19:50:56] IP idents hash table entries: 4096 (order: 3, 32768 bytes, linear) [2022-09-19 19:50:56] tcp_listen_portaddr_hash hash table entries: 256 (order: 0, 4096 bytes, linear) [2022-09-19 19:50:56] TCP established hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-19 19:50:56] TCP bind hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-19 19:50:56] TCP: Hash tables configured (established 2048 bind 2048) [2022-09-19 19:50:56] UDP hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-19 19:50:56] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-19 19:50:56] NET: Registered protocol family 1 [2022-09-19 19:50:56] Unpacking initramfs... [2022-09-19 19:50:56] Freeing initrd memory: 32236K [2022-09-19 19:50:56] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x255cad98bda, max_idle_ns: 440795306906 ns [2022-09-19 19:50:56] clocksource: Switched to clocksource tsc [2022-09-19 19:50:56] workingset: timestamp_bits=3D62 max_order=3D15 bucket_order=3D0 [2022-09-19 19:50:56] xen:xen_evtchn: Event-channel device installed [2022-09-19 19:50:56] Invalid max_queues (4), will use default max: 1. [2022-09-19 19:50:56] tun: Universal TUN/TAP device driver, 1.6 [2022-09-19 19:50:56] xen_netfront: Initialising Xen virtual ethernet drive= r [2022-09-19 19:50:56] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-19 19:50:56] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 1 [2022-09-19 19:50:56] vhci_hcd: created sysfs vhci_hcd.0 [2022-09-19 19:50:56] hub 1-0:1.0: USB hub found [2022-09-19 19:50:56] hub 1-0:1.0: 8 ports detected [2022-09-19 19:50:56] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-19 19:50:56] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 2 [2022-09-19 19:50:56] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [2022-09-19 19:50:56] hub 2-0:1.0: USB hub found [2022-09-19 19:50:56] hub 2-0:1.0: 8 ports detected [2022-09-19 19:50:56] NET: Registered protocol family 17 [2022-09-19 19:50:56] sched_clock: Marking stable (273283961, 179377)->(275136085, -1672747) [2022-09-19 19:50:56] random: fast init done [2022-09-19 19:50:56] blkfront: xvda: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-19 19:50:56] xvda: xvda4 [2022-09-19 19:50:56] blkfront: xvdb: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-19 19:50:56] blkfront: xvdc: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-19 19:50:56] Freeing unused kernel image (initmem) memory: 696K [2022-09-19 19:50:56] Write protecting the kernel read-only data: 10240k [2022-09-19 19:50:56] Freeing unused kernel image (text/rodata gap) memory: 2044K [2022-09-19 19:50:56] Freeing unused kernel image (rodata/data gap) memory: 1620K [2022-09-19 19:50:56] Run /init as init process [2022-09-19 19:50:56] + mount -t devtmpfs none /dev [2022-09-19 19:50:56] + mount -t sysfs /sys /sys [2022-09-19 19:50:56] + mount -t proc /proc /proc [2022-09-19 19:50:56] + mount -t tmpfs -o 'size=3D1m,nodev,noexec' /tmp /tm= p [2022-09-19 19:50:56] + mount -o remount,ro / [2022-09-19 19:50:56] + echo 1 [2022-09-19 19:50:56] + printf '%d\n' 1073741824 [2022-09-19 19:50:56] + /bin/xenstore-read target [2022-09-19 19:50:56] + domid=3D62 [2022-09-19 19:50:56] + xenstore-read /local/domain/62/vm [2022-09-19 19:50:56] + vm_path=3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3 [2022-09-19 19:50:56] + sort [2022-09-19 19:50:56] + xenstore-list -p /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv [2022-09-19 19:50:56] + xenstore-read /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/004 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/009 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/014 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/018 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/023 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/028 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033 [2022-09-19 19:50:56] + dm_args=3D'-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + usb_args=3D [2022-09-19 19:50:56] + test -e /bin/qrexec-agent [2022-09-19 19:50:56] + usb_args=3D'-device [2022-09-19 19:50:56] nec-usb-xhci,id=3Dxhci' [2022-09-19 19:50:56] + mkdir -p /var/run/qubes [2022-09-19 19:50:56] + touch /dev/mdev.log [2022-09-19 19:50:56] + mdev -d [2022-09-19 19:50:56] + USER=3Droot qrexec-agent [2022-09-19 19:50:56] + sed -n '/^-soundhw/ {n;p}' [2022-09-19 19:50:56] + echo '-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + audio_model=3D [2022-09-19 19:50:56] + '[' -n ] [2022-09-19 19:50:56] + sed -n /^-qubes-net:/p [2022-09-19 19:50:56] + echo '-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + net_args=3D [2022-09-19 19:50:56] + sed /^-qubes-net:/d [2022-09-19 19:50:56] + echo '-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + dm_args=3D'-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + test -e /sys/class/net/eth0 [2022-09-19 19:50:56] + echo 'No network interface named eth0.' [2022-09-19 19:50:56] No network interface named eth0. [2022-09-19 19:50:56] + ls -l /sys/class/net/ [2022-09-19 19:50:56] total 0 [2022-09-19 19:50:56] lrwxrwxrwx 1 root 0 0 Sep 19 17:50 .[1;36mlo.[m -> .[1;34m../../devices/virtual/net/lo.[m [2022-09-19 19:50:56] + xenstore-read target [2022-09-19 19:50:56] + target=3D62 [2022-09-19 19:50:56] + device_model=3Ddevice-model/62 [2022-09-19 19:50:56] + mkdir /tmp/qmp [2022-09-19 19:50:56] + kernel=3D [2022-09-19 19:50:56] + grep -q ^-append [2022-09-19 19:50:56] + echo '-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + mkfifo /tmp/qmp/qemu.in /tmp/qmp/qemu.out [2022-09-19 19:50:56] + set +x [2022-09-19 19:50:56] Clearing kmsg buffer... [2022-09-19 19:50:56] + set +x [2022-09-19 19:50:56] + set +x [2022-09-19 19:50:56] + sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/' [2022-09-19 19:50:56] + echo '-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + dm_args=3D'-xen-domid [2022-09-19 19:50:56] 62 [2022-09-19 19:50:56] -no-shutdown [2022-09-19 19:50:56] -nodefaults [2022-09-19 19:50:56] -no-user-config [2022-09-19 19:50:56] -name [2022-09-19 19:50:56] openbsd-71 [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] VGA,vgamem_mb=3D16 [2022-09-19 19:50:56] -boot [2022-09-19 19:50:56] order=3Ddc [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-ehci,id=3Dehci [2022-09-19 19:50:56] -device [2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0 [2022-09-19 19:50:56] -smp [2022-09-19 19:50:56] 2,maxcpus=3D2 [2022-09-19 19:50:56] -net [2022-09-19 19:50:56] none [2022-09-19 19:50:56] -display [2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 19:50:56] -machine [2022-09-19 19:50:56] xenfv [2022-09-19 19:50:56] -m [2022-09-19 19:50:56] 496 [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 19:50:56] -drive [2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 19:50:56] + xenstore-read device/console/2 [2022-09-19 19:50:56] + xenstore-read device/console/1 [2022-09-19 19:50:57] + IFS=3D' [2022-09-19 19:50:57] ' [2022-09-19 19:50:57] + set -f [2022-09-19 19:50:57] + set +f [2022-09-19 19:50:57] + unset IFS [2022-09-19 19:50:57] + qemu_pid=3D171 [2022-09-19 19:50:57] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-19 19:50:57] + sleep 0.1 [2022-09-19 19:50:57] + qemu -sandbox 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resourcecontrol= =3Ddeny' -chardev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm' -mon 'chardev=3Dm,mode=3Dcontro= l' -chardev 'socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm2,mode=3Dcontrol' -xen-domid 62 -no-shutdown -nodefaults -no-user-config -name openbsd-71 -display none -device 'VGA,vgamem_mb=3D16' -boot 'order=3Ddc' -device 'usb-ehci,id=3Dehci' -device 'usb-tablet,bus=3De= hci.0' -smp '2,maxcpus=3D2' -net none -display 'qubes-gui,domid=3D0,log-level=3D0' -machine xenfv -m 496 -drive 'file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -device 'nec-usb-xhci,id=3Dxhci' [2022-09-19 19:50:57] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'server' deprecated [2022-09-19 19:50:57] Please use server=3Don instead [2022-09-19 19:50:57] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'nowait' deprecated [2022-09-19 19:50:57] Please use wait=3Doff instead [2022-09-19 19:50:57] random: qemu: uninitialized urandom read (16 bytes read) [2022-09-19 19:50:57] + tee /proc/self/fd/2 [2022-09-19 19:50:57] + echo '{"execute": "qmp_capabilities"}' [2022-09-19 19:50:57] {"QMP": {"version": {"qemu": {"micro": 0, "minor": 1, "major": 6}, "package": ""}, "capabilities": ["oob"]}} [2022-09-19 19:50:57] {"execute": "qmp_capabilities"} [2022-09-19 19:50:57] qubes_gui/init: 573 [2022-09-19 19:50:57] qubes_gui/init: 582 [2022-09-19 19:50:57] qubes_gui/init: 584 [2022-09-19 19:50:57] qubes_gui/init[611]: version sent, waiting for xorg conf [2022-09-19 19:50:57] {"return": {}} [2022-09-19 19:50:57] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-19 19:50:57] + '[' -e /proc/self/fd/4 ] [2022-09-19 19:50:57] + '[' -e /proc/self/fd/3 ] [2022-09-19 19:50:57] + true [2022-09-19 19:50:57] + printf '=3D=3D=3D=3D Press enter for shell =3D=3D= =3D=3D\n' [2022-09-19 19:50:57] =3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D [2022-09-19 19:50:57] + read [2022-09-19 19:50:57] + vchan-socket-proxy 0 device-model/62/qmp-vchan /tmp/qemu.qmp [2022-09-19 19:50:57] written 110 bytes to vchan [2022-09-19 19:50:57] written 34 bytes to vchan [2022-09-19 19:50:57] written 34 bytes to vchan [2022-09-19 19:50:57] qubes_gui/init[622]: got xorg conf, creating window [2022-09-19 19:50:57] qubes_gui/init: 632 [2022-09-19 19:50:57] random: crng init done [2022-09-19 19:50:57] configure msg, x/y 600 365 (was 0 0), w/h 720 400 [2022-09-19 20:03:09] {"timestamp": {"seconds": 1663610590, "microseconds": 147671}, "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}= } [2022-09-19 20:03:09] {"timestamp": {"seconds": 1663610590, "microseconds": 148655}, "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}= } [2022-09-19 20:25:36] Logfile Opened [2022-09-19 20:25:36] Linux version 5.10.105-xen-stubdom (mockbuild@0c9ad8f2058f40c49bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld version 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022 [2022-09-19 20:25:36] Command line: [2022-09-19 20:25:36] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [2022-09-19 20:25:36] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [2022-09-19 20:25:36] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [2022-09-19 20:25:36] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 25= 6 [2022-09-19 20:25:36] x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'standard' format. [2022-09-19 20:25:36] Released 0 page(s) [2022-09-19 20:25:36] BIOS-provided physical RAM map: [2022-09-19 20:25:36] Xen: [mem 0x0000000000000000-0x000000000009ffff] usable [2022-09-19 20:25:36] Xen: [mem 0x00000000000a0000-0x00000000000fffff] reserved [2022-09-19 20:25:36] Xen: [mem 0x0000000000100000-0x0000000008ffffff] usable [2022-09-19 20:25:36] NX (Execute Disable) protection: active [2022-09-19 20:25:36] Hypervisor detected: Xen PV [2022-09-19 20:25:36] tsc: Fast TSC calibration failed [2022-09-19 20:25:36] tsc: Detected 2591.998 MHz processor [2022-09-19 20:25:36] last_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000 [2022-09-19 20:25:36] x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC [2022-09-19 20:25:36] RAMDISK: [mem 0x02000000-0x03f7afff] [2022-09-19 20:25:36] Zone ranges: [2022-09-19 20:25:36] DMA32 [mem 0x0000000000001000-0x0000000008ffffff= ] [2022-09-19 20:25:36] Normal empty [2022-09-19 20:25:36] Movable zone start for each node [2022-09-19 20:25:36] Early memory node ranges [2022-09-19 20:25:36] node 0: [mem 0x0000000000001000-0x000000000009ffff] [2022-09-19 20:25:36] node 0: [mem 0x0000000000100000-0x0000000008ffffff] [2022-09-19 20:25:36] Initmem setup node 0 [mem 0x0000000000001000-0x0000000008ffffff] [2022-09-19 20:25:36] On node 0, zone DMA32: 1 pages in unavailable ranges [2022-09-19 20:25:36] On node 0, zone DMA32: 96 pages in unavailable ranges [2022-09-19 20:25:36] On node 0, zone DMA32: 28672 pages in unavailable ranges [2022-09-19 20:25:36] p2m virtual area at (____ptrval____), size is 200000 [2022-09-19 20:25:36] Remapped 0 page(s) [2022-09-19 20:25:36] [mem 0x09000000-0xffffffff] available for PCI devices [2022-09-19 20:25:36] Booting paravirtualized kernel on Xen [2022-09-19 20:25:36] Xen version: 4.14.5 (preserve-AD) [2022-09-19 20:25:36] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns [2022-09-19 20:25:36] Built 1 zonelists, mobility grouping on. Total pages: 36170 [2022-09-19 20:25:36] Kernel command line: clocksource=3Dtsc [2022-09-19 20:25:36] Dentry cache hash table entries: 32768 (order: 6, 262144 bytes, linear) [2022-09-19 20:25:36] Inode-cache hash table entries: 16384 (order: 5, 131072 bytes, linear) [2022-09-19 20:25:36] mem auto-init: stack:byref_all(zero), heap alloc:off, heap free:off [2022-09-19 20:25:36] Memory: 96968K/147068K available (6145K kernel code, 842K rwdata, 428K rodata, 696K init, 476K bss, 49848K reserved, 0K cma-reserved) [2022-09-19 20:25:36] random: get_random_u64 called from 0xffffffff810a0f18 with crng_init=3D0 [2022-09-19 20:25:36] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs= =3D1, Nodes=3D1 [2022-09-19 20:25:36] Using NULL legacy PIC [2022-09-19 20:25:36] NR_IRQS: 4352, nr_irqs: 24, preallocated irqs: 0 [2022-09-19 20:25:36] xen:events: Using FIFO-based ABI [2022-09-19 20:25:36] printk: console [hvc0] enabled [2022-09-19 20:25:36] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns [2022-09-19 20:25:36] installing Xen timer for CPU 0 [2022-09-19 20:25:36] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns [2022-09-19 20:25:36] Calibrating delay loop (skipped), value calculated using timer frequency.. 5183.99 BogoMIPS (lpj=3D10367992) [2022-09-19 20:25:36] pid_max: default: 4096 minimum: 301 [2022-09-19 20:25:36] Mount-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-19 20:25:36] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-19 20:25:36] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8 [2022-09-19 20:25:36] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4 [2022-09-19 20:25:36] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (family: 0x6, model: 0x9e, stepping: 0xa) [2022-09-19 20:25:36] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization [2022-09-19 20:25:36] Spectre V2 : Mitigation: Retpolines [2022-09-19 20:25:36] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch [2022-09-19 20:25:36] Spectre V2 : Enabling Restricted Speculation for firmware calls [2022-09-19 20:25:36] Spectre V2 : mitigation: Enabling conditional Indirect Branch Prediction Barrier [2022-09-19 20:25:36] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and seccomp [2022-09-19 20:25:36] SRBDS: Unknown: Dependent on hypervisor status [2022-09-19 20:25:36] MDS: Mitigation: Clear CPU buffers [2022-09-19 20:25:36] Performance Events: unsupported p6 CPU model 158 no PMU driver, software events only. [2022-09-19 20:25:36] devtmpfs: initialized [2022-09-19 20:25:36] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [2022-09-19 20:25:36] futex hash table entries: 16 (order: -4, 384 bytes, linear) [2022-09-19 20:25:36] NET: Registered protocol family 16 [2022-09-19 20:25:36] xen:grant_table: Grant tables using version 1 layout [2022-09-19 20:25:36] Grant table initialized [2022-09-19 20:25:36] PCI: setting up Xen PCI frontend stub [2022-09-19 20:25:36] xen:balloon: Initialising balloon driver [2022-09-19 20:25:36] usbcore: registered new interface driver usbfs [2022-09-19 20:25:36] usbcore: registered new interface driver hub [2022-09-19 20:25:36] usbcore: registered new device driver usb [2022-09-19 20:25:36] PCI: System does not support PCI [2022-09-19 20:25:36] clocksource: Switched to clocksource xen [2022-09-19 20:25:36] NET: Registered protocol family 2 [2022-09-19 20:25:36] IP idents hash table entries: 4096 (order: 3, 32768 bytes, linear) [2022-09-19 20:25:36] tcp_listen_portaddr_hash hash table entries: 256 (order: 0, 4096 bytes, linear) [2022-09-19 20:25:36] TCP established hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-19 20:25:36] TCP bind hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-19 20:25:36] TCP: Hash tables configured (established 2048 bind 2048) [2022-09-19 20:25:36] UDP hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-19 20:25:36] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-19 20:25:36] NET: Registered protocol family 1 [2022-09-19 20:25:36] Unpacking initramfs... [2022-09-19 20:25:36] Freeing initrd memory: 32236K [2022-09-19 20:25:36] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns [2022-09-19 20:25:36] clocksource: Switched to clocksource tsc [2022-09-19 20:25:36] workingset: timestamp_bits=3D62 max_order=3D15 bucket_order=3D0 [2022-09-19 20:25:36] xen:xen_evtchn: Event-channel device installed [2022-09-19 20:25:36] Invalid max_queues (4), will use default max: 1. [2022-09-19 20:25:36] tun: Universal TUN/TAP device driver, 1.6 [2022-09-19 20:25:36] xen_netfront: Initialising Xen virtual ethernet drive= r [2022-09-19 20:25:36] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-19 20:25:36] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 1 [2022-09-19 20:25:36] vhci_hcd: created sysfs vhci_hcd.0 [2022-09-19 20:25:36] hub 1-0:1.0: USB hub found [2022-09-19 20:25:36] hub 1-0:1.0: 8 ports detected [2022-09-19 20:25:36] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-19 20:25:36] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 2 [2022-09-19 20:25:36] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [2022-09-19 20:25:36] hub 2-0:1.0: USB hub found [2022-09-19 20:25:36] hub 2-0:1.0: 8 ports detected [2022-09-19 20:25:36] NET: Registered protocol family 17 [2022-09-19 20:25:36] sched_clock: Marking stable (269302379, 234771)->(271578343, -2041193) [2022-09-19 20:25:36] random: fast init done [2022-09-19 20:25:36] pcifront pci-0: Installing PCI frontend [2022-09-19 20:25:36] xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB [2022-09-19 20:25:36] software IO TLB: mapped [mem 0x0000000003800000-0x0000000003c00000] (4MB) [2022-09-19 20:25:36] pcifront pci-0: Creating PCI Frontend Bus 0000:00 [2022-09-19 20:25:36] pcifront pci-0: PCI host bridge to bus 0000:00 [2022-09-19 20:25:36] pci_bus 0000:00: root bus resource [io 0x0000-0xffff= ] [2022-09-19 20:25:36] pci_bus 0000:00: root bus resource [mem 0x00000000-0x7fffffffff] [2022-09-19 20:25:36] pci_bus 0000:00: root bus resource [bus 00-ff] [2022-09-19 20:25:36] pci 0000:00:00.0: [10ec:8168] type 00 class 0x020000 [2022-09-19 20:25:36] pci 0000:00:00.0: reg 0x10: [io 0x3000-0x30ff] [2022-09-19 20:25:36] pci 0000:00:00.0: reg 0x18: [mem 0xb4304000-0xb4304fff 64bit] [2022-09-19 20:25:36] pci 0000:00:00.0: reg 0x20: [mem 0xb4300000-0xb4303fff 64bit] [2022-09-19 20:25:36] pci 0000:00:00.0: supports D1 D2 [2022-09-19 20:25:36] pcifront pci-0: claiming resource 0000:00:00.0/0 [2022-09-19 20:25:36] pcifront pci-0: claiming resource 0000:00:00.0/2 [2022-09-19 20:25:36] pcifront pci-0: claiming resource 0000:00:00.0/4 [2022-09-19 20:25:36] blkfront: xvda: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-19 20:25:36] xvda: xvda4 [2022-09-19 20:25:36] blkfront: xvdb: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-19 20:25:36] blkfront: xvdc: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-19 20:25:36] Freeing unused kernel image (initmem) memory: 696K [2022-09-19 20:25:36] Write protecting the kernel read-only data: 10240k [2022-09-19 20:25:36] Freeing unused kernel image (text/rodata gap) memory: 2044K [2022-09-19 20:25:36] Freeing unused kernel image (rodata/data gap) memory: 1620K [2022-09-19 20:25:36] Run /init as init process [2022-09-19 20:25:36] + mount -t devtmpfs none /dev [2022-09-19 20:25:36] + mount -t sysfs /sys /sys [2022-09-19 20:25:36] + mount -t proc /proc /proc [2022-09-19 20:25:36] + mount -t tmpfs -o 'size=3D1m,nodev,noexec' /tmp /tm= p [2022-09-19 20:25:36] + mount -o remount,ro / [2022-09-19 20:25:36] + echo 1 [2022-09-19 20:25:36] + printf '%d\n' 1073741824 [2022-09-19 20:25:36] + /bin/xenstore-read target [2022-09-19 20:25:36] + domid=3D12 [2022-09-19 20:25:36] + xenstore-read /local/domain/12/vm [2022-09-19 20:25:36] + vm_path=3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3 [2022-09-19 20:25:36] + sort [2022-09-19 20:25:36] + xenstore-list -p /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv [2022-09-19 20:25:36] + xenstore-read /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/004 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/009 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/014 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/018 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/023 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/028 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033 [2022-09-19 20:25:36] + dm_args=3D'-xen-domid [2022-09-19 20:25:36] 12 [2022-09-19 20:25:36] -no-shutdown [2022-09-19 20:25:36] -nodefaults [2022-09-19 20:25:36] -no-user-config [2022-09-19 20:25:36] -name [2022-09-19 20:25:36] openbsd-71 [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] VGA,vgamem_mb=3D16 [2022-09-19 20:25:36] -boot [2022-09-19 20:25:36] order=3Ddc [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-ehci,id=3Dehci [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:36] -smp [2022-09-19 20:25:36] 2,maxcpus=3D2 [2022-09-19 20:25:36] -net [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:36] -machine [2022-09-19 20:25:36] xenfv [2022-09-19 20:25:36] -m [2022-09-19 20:25:36] 496 [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:36] + usb_args=3D [2022-09-19 20:25:36] + test -e /bin/qrexec-agent [2022-09-19 20:25:36] + usb_args=3D'-device [2022-09-19 20:25:36] nec-usb-xhci,id=3Dxhci' [2022-09-19 20:25:36] + mkdir -p /var/run/qubes [2022-09-19 20:25:36] + touch /dev/mdev.log [2022-09-19 20:25:36] + USER=3Droot qrexec-agent [2022-09-19 20:25:36] + mdev -d [2022-09-19 20:25:36] + sed -n '/^-soundhw/ {n;p}' [2022-09-19 20:25:36] + echo '-xen-domid [2022-09-19 20:25:36] 12 [2022-09-19 20:25:36] -no-shutdown [2022-09-19 20:25:36] -nodefaults [2022-09-19 20:25:36] -no-user-config [2022-09-19 20:25:36] -name [2022-09-19 20:25:36] openbsd-71 [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] VGA,vgamem_mb=3D16 [2022-09-19 20:25:36] -boot [2022-09-19 20:25:36] order=3Ddc [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-ehci,id=3Dehci [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:36] -smp [2022-09-19 20:25:36] 2,maxcpus=3D2 [2022-09-19 20:25:36] -net [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:36] -machine [2022-09-19 20:25:36] xenfv [2022-09-19 20:25:36] -m [2022-09-19 20:25:36] 496 [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:36] + audio_model=3D [2022-09-19 20:25:36] + '[' -n ] [2022-09-19 20:25:36] + sed -n /^-qubes-net:/p [2022-09-19 20:25:36] + echo '-xen-domid [2022-09-19 20:25:36] 12 [2022-09-19 20:25:36] -no-shutdown [2022-09-19 20:25:36] -nodefaults [2022-09-19 20:25:36] -no-user-config [2022-09-19 20:25:36] -name [2022-09-19 20:25:36] openbsd-71 [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] VGA,vgamem_mb=3D16 [2022-09-19 20:25:36] -boot [2022-09-19 20:25:36] order=3Ddc [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-ehci,id=3Dehci [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:36] -smp [2022-09-19 20:25:36] 2,maxcpus=3D2 [2022-09-19 20:25:36] -net [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:36] -machine [2022-09-19 20:25:36] xenfv [2022-09-19 20:25:36] -m [2022-09-19 20:25:36] 496 [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:36] -drive [2022-09-19 20:25:36] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:36] + net_args=3D [2022-09-19 20:25:36] + sed /^-qubes-net:/d [2022-09-19 20:25:36] + echo '-xen-domid [2022-09-19 20:25:36] 12 [2022-09-19 20:25:36] -no-shutdown [2022-09-19 20:25:36] -nodefaults [2022-09-19 20:25:36] -no-user-config [2022-09-19 20:25:36] -name [2022-09-19 20:25:36] openbsd-71 [2022-09-19 20:25:36] -display [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] VGA,vgamem_mb=3D16 [2022-09-19 20:25:36] -boot [2022-09-19 20:25:36] order=3Ddc [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-ehci,id=3Dehci [2022-09-19 20:25:36] -device [2022-09-19 20:25:36] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:36] -smp [2022-09-19 20:25:36] 2,maxcpus=3D2 [2022-09-19 20:25:36] -net [2022-09-19 20:25:36] none [2022-09-19 20:25:36] -display [2022-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:37] -machine [2022-09-19 20:25:37] xenfv [2022-09-19 20:25:37] -m [2022-09-19 20:25:37] 496 [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:37] + dm_args=3D'-xen-domid [2022-09-19 20:25:37] 12 [2022-09-19 20:25:37] -no-shutdown [2022-09-19 20:25:37] -nodefaults [2022-09-19 20:25:37] -no-user-config [2022-09-19 20:25:37] -name [2022-09-19 20:25:37] openbsd-71 [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] VGA,vgamem_mb=3D16 [2022-09-19 20:25:37] -boot [2022-09-19 20:25:37] order=3Ddc [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-ehci,id=3Dehci [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:37] -smp [2022-09-19 20:25:37] 2,maxcpus=3D2 [2022-09-19 20:25:37] -net [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:37] -machine [2022-09-19 20:25:37] xenfv [2022-09-19 20:25:37] -m [2022-09-19 20:25:37] 496 [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:37] + test -e /sys/class/net/eth0 [2022-09-19 20:25:37] + echo 'No network interface named eth0.' [2022-09-19 20:25:37] No network interface named eth0. [2022-09-19 20:25:37] + ls -l /sys/class/net/ [2022-09-19 20:25:37] total 0 [2022-09-19 20:25:37] lrwxrwxrwx 1 root 0 0 Sep 19 18:25 .[1;36mlo.[m -> .[1;34m../../devices/virtual/net/lo.[m [2022-09-19 20:25:37] + xenstore-read target [2022-09-19 20:25:37] + target=3D12 [2022-09-19 20:25:37] + device_model=3Ddevice-model/12 [2022-09-19 20:25:37] + mkdir /tmp/qmp [2022-09-19 20:25:37] + kernel=3D [2022-09-19 20:25:37] + grep -q ^-append [2022-09-19 20:25:37] + echo '-xen-domid [2022-09-19 20:25:37] 12 [2022-09-19 20:25:37] -no-shutdown [2022-09-19 20:25:37] -nodefaults [2022-09-19 20:25:37] -no-user-config [2022-09-19 20:25:37] -name [2022-09-19 20:25:37] openbsd-71 [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] VGA,vgamem_mb=3D16 [2022-09-19 20:25:37] -boot [2022-09-19 20:25:37] order=3Ddc [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-ehci,id=3Dehci [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:37] -smp [2022-09-19 20:25:37] 2,maxcpus=3D2 [2022-09-19 20:25:37] -net [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:37] -machine [2022-09-19 20:25:37] xenfv [2022-09-19 20:25:37] -m [2022-09-19 20:25:37] 496 [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:37] + mkfifo /tmp/qmp/qemu.in /tmp/qmp/qemu.out [2022-09-19 20:25:37] + set +x [2022-09-19 20:25:37] Clearing kmsg buffer... [2022-09-19 20:25:37] + set +x [2022-09-19 20:25:37] + set +x [2022-09-19 20:25:37] + sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/' [2022-09-19 20:25:37] + echo '-xen-domid [2022-09-19 20:25:37] 12 [2022-09-19 20:25:37] -no-shutdown [2022-09-19 20:25:37] -nodefaults [2022-09-19 20:25:37] -no-user-config [2022-09-19 20:25:37] -name [2022-09-19 20:25:37] openbsd-71 [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] VGA,vgamem_mb=3D16 [2022-09-19 20:25:37] -boot [2022-09-19 20:25:37] order=3Ddc [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-ehci,id=3Dehci [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:37] -smp [2022-09-19 20:25:37] 2,maxcpus=3D2 [2022-09-19 20:25:37] -net [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:37] -machine [2022-09-19 20:25:37] xenfv [2022-09-19 20:25:37] -m [2022-09-19 20:25:37] 496 [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:37] + dm_args=3D'-xen-domid [2022-09-19 20:25:37] 12 [2022-09-19 20:25:37] -no-shutdown [2022-09-19 20:25:37] -nodefaults [2022-09-19 20:25:37] -no-user-config [2022-09-19 20:25:37] -name [2022-09-19 20:25:37] openbsd-71 [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] VGA,vgamem_mb=3D16 [2022-09-19 20:25:37] -boot [2022-09-19 20:25:37] order=3Ddc [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-ehci,id=3Dehci [2022-09-19 20:25:37] -device [2022-09-19 20:25:37] usb-tablet,bus=3Dehci.0 [2022-09-19 20:25:37] -smp [2022-09-19 20:25:37] 2,maxcpus=3D2 [2022-09-19 20:25:37] -net [2022-09-19 20:25:37] none [2022-09-19 20:25:37] -display [2022-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0 [2022-09-19 20:25:37] -machine [2022-09-19 20:25:37] xenfv [2022-09-19 20:25:37] -m [2022-09-19 20:25:37] 496 [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-19 20:25:37] -drive [2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-19 20:25:37] + xenstore-read device/console/2 [2022-09-19 20:25:37] + xenstore-read device/console/1 [2022-09-19 20:25:37] + IFS=3D' [2022-09-19 20:25:37] ' [2022-09-19 20:25:37] + set -f [2022-09-19 20:25:37] + set +f [2022-09-19 20:25:37] + unset IFS [2022-09-19 20:25:37] + qemu_pid=3D130 [2022-09-19 20:25:37] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-19 20:25:37] + sleep 0.1 [2022-09-19 20:25:37] + qemu -sandbox 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resourcecontrol= =3Ddeny' -chardev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm' -mon 'chardev=3Dm,mode=3Dcontro= l' -chardev 'socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm2,mode=3Dcontrol' -xen-domid 12 -no-shutdown -nodefaults -no-user-config -name openbsd-71 -display none -device 'VGA,vgamem_mb=3D16' -boot 'order=3Ddc' -device 'usb-ehci,id=3Dehci' -device 'usb-tablet,bus=3De= hci.0' -smp '2,maxcpus=3D2' -net none -display 'qubes-gui,domid=3D0,log-level=3D0' -machine xenfv -m 496 -drive 'file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -device 'nec-usb-xhci,id=3Dxhci' [2022-09-19 20:25:37] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'server' deprecated [2022-09-19 20:25:37] Please use server=3Don instead [2022-09-19 20:25:37] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'nowait' deprecated [2022-09-19 20:25:37] Please use wait=3Doff instead [2022-09-19 20:25:37] + tee /proc/self/fd/2 [2022-09-19 20:25:37] + echo '{"execute": "qmp_capabilities"}' [2022-09-19 20:25:37] random: qemu: uninitialized urandom read (16 bytes read) [2022-09-19 20:25:37] {"execute": "qmp_capabilities"} [2022-09-19 20:25:37] {"QMP": {"version": {"qemu": {"micro": 0, "minor": 1, "major": 6}, "package": ""}, "capabilities": ["oob"]}} [2022-09-19 20:25:37] qubes_gui/init: 573 [2022-09-19 20:25:37] qubes_gui/init: 582 [2022-09-19 20:25:37] qubes_gui/init: 584 [2022-09-19 20:25:37] qubes_gui/init[611]: version sent, waiting for xorg conf [2022-09-19 20:25:37] {"return": {}} [2022-09-19 20:25:37] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-19 20:25:37] + '[' -e /proc/self/fd/4 ] [2022-09-19 20:25:37] + '[' -e /proc/self/fd/3 ] [2022-09-19 20:25:37] + true [2022-09-19 20:25:37] + printf '=3D=3D=3D=3D Press enter for shell =3D=3D= =3D=3D\n' [2022-09-19 20:25:37] =3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D [2022-09-19 20:25:37] + read [2022-09-19 20:25:37] + vchan-socket-proxy 0 device-model/12/qmp-vchan /tmp/qemu.qmp [2022-09-19 20:25:37] written 110 bytes to vchan [2022-09-19 20:25:37] written 34 bytes to vchan [2022-09-19 20:25:37] [00:06.0] xen_pt_realize: Assigning real physical device 07:00.0 to devfn 0x30 [2022-09-19 20:25:37] [00:06.0] xen_pt_register_regions: IO region 0 registered (size=3D0x00000100 base_addr=3D0x00003000 type: 0x1) [2022-09-19 20:25:37] [00:06.0] xen_pt_register_regions: IO region 2 registered (size=3D0x00001000 base_addr=3D0xb4304000 type: 0x4) [2022-09-19 20:25:37] [00:06.0] xen_pt_register_regions: IO region 4 registered (size=3D0x00004000 base_addr=3D0xb4300000 type: 0x4) [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x000e mismatch! Emulated=3D0x0080, host=3D0x0000, syncing to 0x0000. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0010 mismatch! Emulated=3D0x0000, host=3D0x3001, syncing to 0x3001. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0018 mismatch! Emulated=3D0x0000, host=3D0xb4304004, syncing to 0xb4304004. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0020 mismatch! Emulated=3D0x0000, host=3D0xb4300004, syncing to 0xb4300004. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0042 mismatch! Emulated=3D0x0000, host=3D0x07c3, syncing to 0x0603. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0052 mismatch! Emulated=3D0x0000, host=3D0x0080, syncing to 0x0080. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0074 mismatch! Emulated=3D0x0000, host=3D0x5908cc0, syncing to 0x5908cc0. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x007a mismatch! Emulated=3D0x0000, host=3D0x0010, syncing to 0x0010. [2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0082 mismatch! Emulated=3D0x0000, host=3D0x1011, syncing to 0x1011. [2022-09-19 20:25:37] [00:06.0] xen_pt_pci_intx: intx=3D1 [2022-09-19 20:25:37] [00:06.0] xen_pt_realize: Real physical device 07:00.0 registered successfully [2022-09-19 20:25:37] written 34 bytes to vchan [2022-09-19 20:25:37] written 2048 bytes to vchan [2022-09-19 20:25:37] written 979 bytes to vchan [2022-09-19 20:25:37] written 110 bytes to vchan [2022-09-19 20:25:37] written 34 bytes to vchan [2022-09-19 20:25:37] written 34 bytes to vchan [2022-09-19 20:25:37] qubes_gui/init[622]: got xorg conf, creating window [2022-09-19 20:25:37] qubes_gui/init: 632 [2022-09-19 20:25:37] configure msg, x/y 640 325 (was 0 0), w/h 640 480 [2022-09-19 20:25:37] configure msg, x/y 640 325 (was 640 325), w/h 640 480 [2022-09-19 20:25:37] random: crng init done [2022-09-19 20:25:39] qubes_gui: got unknown msg type 145, ignoring [2022-09-19 20:25:57] [00:06.0] Write-back to unknown field 0x44 (partially) inhibited (0x0000ffff) [2022-09-19 20:25:57] [00:06.0] If the device doesn't work, try enabling permissive mode [2022-09-19 20:25:57] [00:06.0] (unsafe) and if it helps report the problem to xen-devel [2022-09-19 20:25:57] [00:06.0] xen_pt_msgctrl_reg_write: setup MSI (register: 81). [2022-09-19 20:25:57] [00:06.0] xen_pt_msi_setup: MSI mapped with pirq 151. [2022-09-19 20:25:57] [00:06.0] msi_msix_update: Updating MSI with pirq 151 gvec 0x72 gflags 0x0 (entry: 0x0) [2022-09-19 20:27:19] qubes_gui: got unknown msg type 145, ignoring [2022-09-19 21:48:58] {"timestamp": {"seconds": 1663616939, "microseconds": 194886}, "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}= } [2022-09-19 21:48:58] {"timestamp": {"seconds": 1663616939, "microseconds": 196105}, "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}= } [2022-09-19 21:49:00] pcifront pci-0: Rescanning PCI Frontend Bus 0000:00 [2022-09-20 09:21:32] Logfile Opened [2022-09-20 09:21:33] Linux version 5.10.105-xen-stubdom (mockbuild@0c9ad8f2058f40c49bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld version 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022 [2022-09-20 09:21:33] Command line: [2022-09-20 09:21:33] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [2022-09-20 09:21:33] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [2022-09-20 09:21:33] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [2022-09-20 09:21:33] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 25= 6 [2022-09-20 09:21:33] x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'standard' format. [2022-09-20 09:21:33] Released 0 page(s) [2022-09-20 09:21:33] BIOS-provided physical RAM map: [2022-09-20 09:21:33] Xen: [mem 0x0000000000000000-0x000000000009ffff] usable [2022-09-20 09:21:33] Xen: [mem 0x00000000000a0000-0x00000000000fffff] reserved [2022-09-20 09:21:33] Xen: [mem 0x0000000000100000-0x0000000008ffffff] usable [2022-09-20 09:21:33] NX (Execute Disable) protection: active [2022-09-20 09:21:33] Hypervisor detected: Xen PV [2022-09-20 09:21:33] tsc: Fast TSC calibration failed [2022-09-20 09:21:33] tsc: Detected 2591.998 MHz processor [2022-09-20 09:21:33] last_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000 [2022-09-20 09:21:33] x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC [2022-09-20 09:21:33] RAMDISK: [mem 0x02000000-0x03f7afff] [2022-09-20 09:21:33] Zone ranges: [2022-09-20 09:21:33] DMA32 [mem 0x0000000000001000-0x0000000008ffffff= ] [2022-09-20 09:21:33] Normal empty [2022-09-20 09:21:33] Movable zone start for each node [2022-09-20 09:21:33] Early memory node ranges [2022-09-20 09:21:33] node 0: [mem 0x0000000000001000-0x000000000009ffff] [2022-09-20 09:21:33] node 0: [mem 0x0000000000100000-0x0000000008ffffff] [2022-09-20 09:21:33] Initmem setup node 0 [mem 0x0000000000001000-0x0000000008ffffff] [2022-09-20 09:21:33] On node 0, zone DMA32: 1 pages in unavailable ranges [2022-09-20 09:21:33] On node 0, zone DMA32: 96 pages in unavailable ranges [2022-09-20 09:21:33] On node 0, zone DMA32: 28672 pages in unavailable ranges [2022-09-20 09:21:33] p2m virtual area at (____ptrval____), size is 200000 [2022-09-20 09:21:33] Remapped 0 page(s) [2022-09-20 09:21:33] [mem 0x09000000-0xffffffff] available for PCI devices [2022-09-20 09:21:33] Booting paravirtualized kernel on Xen [2022-09-20 09:21:33] Xen version: 4.14.5 (preserve-AD) [2022-09-20 09:21:33] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns [2022-09-20 09:21:33] Built 1 zonelists, mobility grouping on. Total pages: 36170 [2022-09-20 09:21:33] Kernel command line: clocksource=3Dtsc [2022-09-20 09:21:33] Dentry cache hash table entries: 32768 (order: 6, 262144 bytes, linear) [2022-09-20 09:21:33] Inode-cache hash table entries: 16384 (order: 5, 131072 bytes, linear) [2022-09-20 09:21:33] mem auto-init: stack:byref_all(zero), heap alloc:off, heap free:off [2022-09-20 09:21:33] Memory: 96968K/147068K available (6145K kernel code, 842K rwdata, 428K rodata, 696K init, 476K bss, 49848K reserved, 0K cma-reserved) [2022-09-20 09:21:33] random: get_random_u64 called from 0xffffffff810a0f18 with crng_init=3D0 [2022-09-20 09:21:33] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs= =3D1, Nodes=3D1 [2022-09-20 09:21:33] Using NULL legacy PIC [2022-09-20 09:21:33] NR_IRQS: 4352, nr_irqs: 24, preallocated irqs: 0 [2022-09-20 09:21:33] xen:events: Using FIFO-based ABI [2022-09-20 09:21:33] printk: console [hvc0] enabled [2022-09-20 09:21:33] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns [2022-09-20 09:21:33] installing Xen timer for CPU 0 [2022-09-20 09:21:33] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns [2022-09-20 09:21:33] Calibrating delay loop (skipped), value calculated using timer frequency.. 5183.99 BogoMIPS (lpj=3D10367992) [2022-09-20 09:21:33] pid_max: default: 4096 minimum: 301 [2022-09-20 09:21:33] Mount-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-20 09:21:33] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-20 09:21:33] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8 [2022-09-20 09:21:33] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4 [2022-09-20 09:21:33] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (family: 0x6, model: 0x9e, stepping: 0xa) [2022-09-20 09:21:33] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization [2022-09-20 09:21:33] Spectre V2 : Mitigation: Retpolines [2022-09-20 09:21:33] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch [2022-09-20 09:21:33] Spectre V2 : Enabling Restricted Speculation for firmware calls [2022-09-20 09:21:33] Spectre V2 : mitigation: Enabling conditional Indirect Branch Prediction Barrier [2022-09-20 09:21:33] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and seccomp [2022-09-20 09:21:33] SRBDS: Unknown: Dependent on hypervisor status [2022-09-20 09:21:33] MDS: Mitigation: Clear CPU buffers [2022-09-20 09:21:33] Performance Events: unsupported p6 CPU model 158 no PMU driver, software events only. [2022-09-20 09:21:33] devtmpfs: initialized [2022-09-20 09:21:33] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [2022-09-20 09:21:33] futex hash table entries: 16 (order: -4, 384 bytes, linear) [2022-09-20 09:21:33] NET: Registered protocol family 16 [2022-09-20 09:21:33] xen:grant_table: Grant tables using version 1 layout [2022-09-20 09:21:33] Grant table initialized [2022-09-20 09:21:33] PCI: setting up Xen PCI frontend stub [2022-09-20 09:21:33] xen:balloon: Initialising balloon driver [2022-09-20 09:21:33] usbcore: registered new interface driver usbfs [2022-09-20 09:21:33] usbcore: registered new interface driver hub [2022-09-20 09:21:33] usbcore: registered new device driver usb [2022-09-20 09:21:33] PCI: System does not support PCI [2022-09-20 09:21:33] clocksource: Switched to clocksource xen [2022-09-20 09:21:33] NET: Registered protocol family 2 [2022-09-20 09:21:33] IP idents hash table entries: 4096 (order: 3, 32768 bytes, linear) [2022-09-20 09:21:33] tcp_listen_portaddr_hash hash table entries: 256 (order: 0, 4096 bytes, linear) [2022-09-20 09:21:33] TCP established hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-20 09:21:33] TCP bind hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-20 09:21:33] TCP: Hash tables configured (established 2048 bind 2048) [2022-09-20 09:21:33] UDP hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-20 09:21:33] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-20 09:21:33] NET: Registered protocol family 1 [2022-09-20 09:21:33] Unpacking initramfs... [2022-09-20 09:21:33] Freeing initrd memory: 32236K [2022-09-20 09:21:33] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns [2022-09-20 09:21:33] clocksource: Switched to clocksource tsc [2022-09-20 09:21:33] workingset: timestamp_bits=3D62 max_order=3D15 bucket_order=3D0 [2022-09-20 09:21:33] xen:xen_evtchn: Event-channel device installed [2022-09-20 09:21:33] Invalid max_queues (4), will use default max: 1. [2022-09-20 09:21:33] random: fast init done [2022-09-20 09:21:33] tun: Universal TUN/TAP device driver, 1.6 [2022-09-20 09:21:33] xen_netfront: Initialising Xen virtual ethernet drive= r [2022-09-20 09:21:33] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-20 09:21:33] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 1 [2022-09-20 09:21:33] vhci_hcd: created sysfs vhci_hcd.0 [2022-09-20 09:21:33] hub 1-0:1.0: USB hub found [2022-09-20 09:21:33] hub 1-0:1.0: 8 ports detected [2022-09-20 09:21:33] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-20 09:21:33] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 2 [2022-09-20 09:21:33] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [2022-09-20 09:21:33] hub 2-0:1.0: USB hub found [2022-09-20 09:21:33] hub 2-0:1.0: 8 ports detected [2022-09-20 09:21:33] NET: Registered protocol family 17 [2022-09-20 09:21:33] sched_clock: Marking stable (439658149, 279138)->(442513139, -2575852) [2022-09-20 09:21:33] pcifront pci-0: Installing PCI frontend [2022-09-20 09:21:33] xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB [2022-09-20 09:21:33] software IO TLB: mapped [mem 0x0000000003800000-0x0000000003c00000] (4MB) [2022-09-20 09:21:33] pcifront pci-0: Creating PCI Frontend Bus 0000:00 [2022-09-20 09:21:33] pcifront pci-0: PCI host bridge to bus 0000:00 [2022-09-20 09:21:33] pci_bus 0000:00: root bus resource [io 0x0000-0xffff= ] [2022-09-20 09:21:33] pci_bus 0000:00: root bus resource [mem 0x00000000-0x7fffffffff] [2022-09-20 09:21:33] pci_bus 0000:00: root bus resource [bus 00-ff] [2022-09-20 09:21:33] pci 0000:00:00.0: [10ec:8168] type 00 class 0x020000 [2022-09-20 09:21:33] pci 0000:00:00.0: reg 0x10: [io 0x3000-0x30ff] [2022-09-20 09:21:33] pci 0000:00:00.0: reg 0x18: [mem 0xb4304000-0xb4304fff 64bit] [2022-09-20 09:21:33] pci 0000:00:00.0: reg 0x20: [mem 0xb4300000-0xb4303fff 64bit] [2022-09-20 09:21:33] pci 0000:00:00.0: supports D1 D2 [2022-09-20 09:21:33] pcifront pci-0: claiming resource 0000:00:00.0/0 [2022-09-20 09:21:33] pcifront pci-0: claiming resource 0000:00:00.0/2 [2022-09-20 09:21:33] pcifront pci-0: claiming resource 0000:00:00.0/4 [2022-09-20 09:21:33] blkfront: xvda: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-20 09:21:33] xvda: xvda4 [2022-09-20 09:21:33] blkfront: xvdb: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-20 09:21:33] blkfront: xvdc: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-20 09:21:33] Freeing unused kernel image (initmem) memory: 696K [2022-09-20 09:21:33] Write protecting the kernel read-only data: 10240k [2022-09-20 09:21:33] Freeing unused kernel image (text/rodata gap) memory: 2044K [2022-09-20 09:21:33] Freeing unused kernel image (rodata/data gap) memory: 1620K [2022-09-20 09:21:33] Run /init as init process [2022-09-20 09:21:33] + mount -t devtmpfs none /dev [2022-09-20 09:21:33] + mount -t sysfs /sys /sys [2022-09-20 09:21:33] + mount -t proc /proc /proc [2022-09-20 09:21:33] + mount -t tmpfs -o 'size=3D1m,nodev,noexec' /tmp /tm= p [2022-09-20 09:21:33] + mount -o remount,ro / [2022-09-20 09:21:33] + echo 1 [2022-09-20 09:21:33] + printf '%d\n' 1073741824 [2022-09-20 09:21:33] + /bin/xenstore-read target [2022-09-20 09:21:33] + domid=3D7 [2022-09-20 09:21:33] + xenstore-read /local/domain/7/vm [2022-09-20 09:21:33] + vm_path=3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3 [2022-09-20 09:21:33] + sort [2022-09-20 09:21:33] + xenstore-list -p /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv [2022-09-20 09:21:33] + xenstore-read /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/004 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/009 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/014 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/018 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/023 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/028 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033 [2022-09-20 09:21:33] + dm_args=3D'-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + usb_args=3D [2022-09-20 09:21:33] + test -e /bin/qrexec-agent [2022-09-20 09:21:33] + usb_args=3D'-device [2022-09-20 09:21:33] nec-usb-xhci,id=3Dxhci' [2022-09-20 09:21:33] + mkdir -p /var/run/qubes [2022-09-20 09:21:33] + touch /dev/mdev.log [2022-09-20 09:21:33] + mdev -d [2022-09-20 09:21:33] + USER=3Droot qrexec-agent [2022-09-20 09:21:33] + sed -n '/^-soundhw/ {n;p}' [2022-09-20 09:21:33] + echo '-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + audio_model=3D [2022-09-20 09:21:33] + '[' -n ] [2022-09-20 09:21:33] + sed -n /^-qubes-net:/p [2022-09-20 09:21:33] + echo '-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + net_args=3D [2022-09-20 09:21:33] + sed /^-qubes-net:/d [2022-09-20 09:21:33] + echo '-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + dm_args=3D'-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + test -e /sys/class/net/eth0 [2022-09-20 09:21:33] + echo 'No network interface named eth0.' [2022-09-20 09:21:33] No network interface named eth0. [2022-09-20 09:21:33] + ls -l /sys/class/net/ [2022-09-20 09:21:33] total 0 [2022-09-20 09:21:33] lrwxrwxrwx 1 root 0 0 Sep 20 07:21 .[1;36mlo.[m -> .[1;34m../../devices/virtual/net/lo.[m [2022-09-20 09:21:33] + xenstore-read target [2022-09-20 09:21:33] + target=3D7 [2022-09-20 09:21:33] + device_model=3Ddevice-model/7 [2022-09-20 09:21:33] + mkdir /tmp/qmp [2022-09-20 09:21:33] + kernel=3D [2022-09-20 09:21:33] + grep -q ^-append [2022-09-20 09:21:33] + echo '-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + mkfifo /tmp/qmp/qemu.in /tmp/qmp/qemu.out [2022-09-20 09:21:33] + set +x [2022-09-20 09:21:33] Clearing kmsg buffer... [2022-09-20 09:21:33] + set +x [2022-09-20 09:21:33] + set+ sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/' [2022-09-20 09:21:33] +x [2022-09-20 09:21:33] + echo '-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + dm_args=3D'-xen-domid [2022-09-20 09:21:33] 7 [2022-09-20 09:21:33] -no-shutdown [2022-09-20 09:21:33] -nodefaults [2022-09-20 09:21:33] -no-user-config [2022-09-20 09:21:33] -name [2022-09-20 09:21:33] openbsd-71 [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] VGA,vgamem_mb=3D16 [2022-09-20 09:21:33] -boot [2022-09-20 09:21:33] order=3Ddc [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-ehci,id=3Dehci [2022-09-20 09:21:33] -device [2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0 [2022-09-20 09:21:33] -smp [2022-09-20 09:21:33] 2,maxcpus=3D2 [2022-09-20 09:21:33] -net [2022-09-20 09:21:33] none [2022-09-20 09:21:33] -display [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 09:21:33] -machine [2022-09-20 09:21:33] xenfv [2022-09-20 09:21:33] -m [2022-09-20 09:21:33] 496 [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 09:21:33] -drive [2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 09:21:33] + xenstore-read device/console/2 [2022-09-20 09:21:33] + xenstore-read device/console/1 [2022-09-20 09:21:33] + IFS=3D' [2022-09-20 09:21:33] ' [2022-09-20 09:21:33] + set -f [2022-09-20 09:21:33] + set +f [2022-09-20 09:21:33] + unset IFS [2022-09-20 09:21:33] + qemu_pid=3D72 [2022-09-20 09:21:33] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-20 09:21:33] + sleep 0.1 [2022-09-20 09:21:33] + qemu -sandbox+ '[' '!' -e /tmp/qemu.qmp ] [2022-09-20 09:21:33] + sleep 0.1 [2022-09-20 09:21:34] 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resourcecontrol= =3Ddeny' -chardev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm' -mon 'chardev=3Dm,mode=3Dcontro= l' -chardev 'socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm2,mode=3Dcontrol' -xen-domid 7 -no-shutdown -nodefaults -no-user-config -name openbsd-71 -display none -device 'VGA,vgamem_mb=3D16' -boot 'order=3Ddc' -device 'usb-ehci,id=3Dehci' -device 'usb-tablet,bus=3De= hci.0' -smp '2,maxcpus=3D2' -net none -display 'qubes-gui,domid=3D0,log-level=3D0' -machine xenfv -m 496 -drive 'file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -device 'nec-usb-xhci,id=3Dxhci' [2022-09-20 09:21:34] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-20 09:21:34] + sleep 0.1 [2022-09-20 09:21:34] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'server' deprecated [2022-09-20 09:21:34] Please use server=3Don instead [2022-09-20 09:21:34] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'nowait' deprecated [2022-09-20 09:21:34] Please use wait=3Doff instead [2022-09-20 09:21:34] + tee /proc/self/fd/2 [2022-09-20 09:21:34] + echo '{"execute": "qmp_capabilities"}' [2022-09-20 09:21:34] {"execute": "qmp_capabilities"} [2022-09-20 09:21:34] random: qemu: uninitialized urandom read (16 bytes read) [2022-09-20 09:21:34] {"QMP": {"version": {"qemu": {"micro": 0, "minor": 1, "major": 6}, "package": ""}, "capabilities": ["oob"]}} [2022-09-20 09:21:34] qubes_gui/init: 573 [2022-09-20 09:21:34] qubes_gui/init: 582 [2022-09-20 09:21:34] qubes_gui/init: 584 [2022-09-20 09:21:34] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-20 09:21:34] + '[' -e /proc/self/fd/4 ] [2022-09-20 09:21:34] + '[' -e /proc/self/fd/3 ] [2022-09-20 09:21:34] + true [2022-09-20 09:21:34] + printf '=3D=3D=3D=3D Press enter for shell =3D=3D= =3D=3D\n' [2022-09-20 09:21:34] =3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D [2022-09-20 09:21:34] + read [2022-09-20 09:21:34] + vchan-socket-proxy 0 device-model/7/qmp-vchan /tmp/qemu.qmp [2022-09-20 09:21:34] qubes_gui/init[611]: version sent, waiting for xorg conf [2022-09-20 09:21:34] {"return": {}} [2022-09-20 09:21:34] written 110 bytes to vchan [2022-09-20 09:21:34] written 34 bytes to vchan [2022-09-20 09:21:34] [00:06.0] xen_pt_realize: Assigning real physical device 07:00.0 to devfn 0x30 [2022-09-20 09:21:34] [00:06.0] xen_pt_register_regions: IO region 0 registered (size=3D0x00000100 base_addr=3D0x00003000 type: 0x1) [2022-09-20 09:21:34] [00:06.0] xen_pt_register_regions: IO region 2 registered (size=3D0x00001000 base_addr=3D0xb4304000 type: 0x4) [2022-09-20 09:21:34] [00:06.0] xen_pt_register_regions: IO region 4 registered (size=3D0x00004000 base_addr=3D0xb4300000 type: 0x4) [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x000e mismatch! Emulated=3D0x0080, host=3D0x0000, syncing to 0x0000. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0010 mismatch! Emulated=3D0x0000, host=3D0x3001, syncing to 0x3001. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0018 mismatch! Emulated=3D0x0000, host=3D0xb4304004, syncing to 0xb4304004. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0020 mismatch! Emulated=3D0x0000, host=3D0xb4300004, syncing to 0xb4300004. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0042 mismatch! Emulated=3D0x0000, host=3D0x07c3, syncing to 0x0603. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0052 mismatch! Emulated=3D0x0000, host=3D0x0080, syncing to 0x0080. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0074 mismatch! Emulated=3D0x0000, host=3D0x5908cc0, syncing to 0x5908cc0. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x007a mismatch! Emulated=3D0x0000, host=3D0x0010, syncing to 0x0010. [2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0082 mismatch! Emulated=3D0x0000, host=3D0x1011, syncing to 0x1011. [2022-09-20 09:21:34] [00:06.0] xen_pt_pci_intx: intx=3D1 [2022-09-20 09:21:34] [00:06.0] xen_pt_realize: Real physical device 07:00.0 registered successfully [2022-09-20 09:21:34] written 34 bytes to vchan [2022-09-20 09:21:34] written 2048 bytes to vchan [2022-09-20 09:21:34] written 979 bytes to vchan [2022-09-20 09:21:34] written 110 bytes to vchan [2022-09-20 09:21:34] written 34 bytes to vchan [2022-09-20 09:21:34] written 34 bytes to vchan [2022-09-20 09:21:34] qubes_gui/init[622]: got xorg conf, creating window [2022-09-20 09:21:34] qubes_gui/init: 632 [2022-09-20 09:21:34] configure msg, x/y 640 325 (was 0 0), w/h 640 480 [2022-09-20 09:21:34] configure msg, x/y 640 325 (was 640 325), w/h 640 480 [2022-09-20 09:21:35] random: crng init done [2022-09-20 09:21:58] [00:06.0] Write-back to unknown field 0x44 (partially) inhibited (0x0000ffff) [2022-09-20 09:21:58] [00:06.0] If the device doesn't work, try enabling permissive mode [2022-09-20 09:21:58] [00:06.0] (unsafe) and if it helps report the problem to xen-devel [2022-09-20 09:21:58] [00:06.0] xen_pt_msgctrl_reg_write: setup MSI (register: 81). [2022-09-20 09:21:58] [00:06.0] xen_pt_msi_setup: MSI mapped with pirq 151. [2022-09-20 09:21:58] [00:06.0] msi_msix_update: Updating MSI with pirq 151 gvec 0x72 gflags 0x0 (entry: 0x0) [2022-09-20 09:31:19] qubes_gui: got unknown msg type 145, ignoring [2022-09-20 09:33:54] qubes_gui: got unknown msg type 145, ignoring [2022-09-20 09:42:36] {"timestamp": {"seconds": 1663659756, "microseconds": 783476}, "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}= } [2022-09-20 09:42:36] {"timestamp": {"seconds": 1663659756, "microseconds": 784673}, "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}= } [2022-09-20 09:42:38] pcifront pci-0: Rescanning PCI Frontend Bus 0000:00 [2022-09-20 10:08:20] Logfile Opened [2022-09-20 10:08:20] Linux version 5.10.105-xen-stubdom (mockbuild@0c9ad8f2058f40c49bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld version 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022 [2022-09-20 10:08:20] Command line: [2022-09-20 10:08:20] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [2022-09-20 10:08:20] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [2022-09-20 10:08:20] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [2022-09-20 10:08:20] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 25= 6 [2022-09-20 10:08:20] x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'standard' format. [2022-09-20 10:08:20] Released 0 page(s) [2022-09-20 10:08:20] BIOS-provided physical RAM map: [2022-09-20 10:08:20] Xen: [mem 0x0000000000000000-0x000000000009ffff] usable [2022-09-20 10:08:20] Xen: [mem 0x00000000000a0000-0x00000000000fffff] reserved [2022-09-20 10:08:20] Xen: [mem 0x0000000000100000-0x0000000008ffffff] usable [2022-09-20 10:08:20] NX (Execute Disable) protection: active [2022-09-20 10:08:20] Hypervisor detected: Xen PV [2022-09-20 10:08:20] tsc: Fast TSC calibration failed [2022-09-20 10:08:20] tsc: Detected 2591.998 MHz processor [2022-09-20 10:08:20] last_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000 [2022-09-20 10:08:20] x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC [2022-09-20 10:08:20] RAMDISK: [mem 0x02000000-0x03f7afff] [2022-09-20 10:08:20] Zone ranges: [2022-09-20 10:08:20] DMA32 [mem 0x0000000000001000-0x0000000008ffffff= ] [2022-09-20 10:08:20] Normal empty [2022-09-20 10:08:20] Movable zone start for each node [2022-09-20 10:08:20] Early memory node ranges [2022-09-20 10:08:20] node 0: [mem 0x0000000000001000-0x000000000009ffff] [2022-09-20 10:08:20] node 0: [mem 0x0000000000100000-0x0000000008ffffff] [2022-09-20 10:08:20] Initmem setup node 0 [mem 0x0000000000001000-0x0000000008ffffff] [2022-09-20 10:08:20] On node 0, zone DMA32: 1 pages in unavailable ranges [2022-09-20 10:08:20] On node 0, zone DMA32: 96 pages in unavailable ranges [2022-09-20 10:08:20] On node 0, zone DMA32: 28672 pages in unavailable ranges [2022-09-20 10:08:20] p2m virtual area at (____ptrval____), size is 200000 [2022-09-20 10:08:20] Remapped 0 page(s) [2022-09-20 10:08:20] [mem 0x09000000-0xffffffff] available for PCI devices [2022-09-20 10:08:20] Booting paravirtualized kernel on Xen [2022-09-20 10:08:20] Xen version: 4.14.5 (preserve-AD) [2022-09-20 10:08:20] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns [2022-09-20 10:08:20] Built 1 zonelists, mobility grouping on. Total pages: 36170 [2022-09-20 10:08:20] Kernel command line: clocksource=3Dtsc [2022-09-20 10:08:20] Dentry cache hash table entries: 32768 (order: 6, 262144 bytes, linear) [2022-09-20 10:08:20] Inode-cache hash table entries: 16384 (order: 5, 131072 bytes, linear) [2022-09-20 10:08:20] mem auto-init: stack:byref_all(zero), heap alloc:off, heap free:off [2022-09-20 10:08:20] Memory: 96968K/147068K available (6145K kernel code, 842K rwdata, 428K rodata, 696K init, 476K bss, 49848K reserved, 0K cma-reserved) [2022-09-20 10:08:20] random: get_random_u64 called from 0xffffffff810a0f18 with crng_init=3D0 [2022-09-20 10:08:20] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs= =3D1, Nodes=3D1 [2022-09-20 10:08:20] Using NULL legacy PIC [2022-09-20 10:08:20] NR_IRQS: 4352, nr_irqs: 24, preallocated irqs: 0 [2022-09-20 10:08:20] xen:events: Using FIFO-based ABI [2022-09-20 10:08:20] printk: console [hvc0] enabled [2022-09-20 10:08:20] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns [2022-09-20 10:08:20] installing Xen timer for CPU 0 [2022-09-20 10:08:20] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns [2022-09-20 10:08:20] Calibrating delay loop (skipped), value calculated using timer frequency.. 5183.99 BogoMIPS (lpj=3D10367992) [2022-09-20 10:08:20] pid_max: default: 4096 minimum: 301 [2022-09-20 10:08:20] Mount-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-20 10:08:20] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes, linear) [2022-09-20 10:08:20] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8 [2022-09-20 10:08:20] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4 [2022-09-20 10:08:20] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (family: 0x6, model: 0x9e, stepping: 0xa) [2022-09-20 10:08:20] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization [2022-09-20 10:08:20] Spectre V2 : Mitigation: Retpolines [2022-09-20 10:08:20] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch [2022-09-20 10:08:20] Spectre V2 : Enabling Restricted Speculation for firmware calls [2022-09-20 10:08:20] Spectre V2 : mitigation: Enabling conditional Indirect Branch Prediction Barrier [2022-09-20 10:08:20] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and seccomp [2022-09-20 10:08:20] SRBDS: Unknown: Dependent on hypervisor status [2022-09-20 10:08:20] MDS: Mitigation: Clear CPU buffers [2022-09-20 10:08:20] Performance Events: unsupported p6 CPU model 158 no PMU driver, software events only. [2022-09-20 10:08:20] devtmpfs: initialized [2022-09-20 10:08:20] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [2022-09-20 10:08:20] futex hash table entries: 16 (order: -4, 384 bytes, linear) [2022-09-20 10:08:20] NET: Registered protocol family 16 [2022-09-20 10:08:20] xen:grant_table: Grant tables using version 1 layout [2022-09-20 10:08:20] Grant table initialized [2022-09-20 10:08:20] PCI: setting up Xen PCI frontend stub [2022-09-20 10:08:20] xen:balloon: Initialising balloon driver [2022-09-20 10:08:20] usbcore: registered new interface driver usbfs [2022-09-20 10:08:20] usbcore: registered new interface driver hub [2022-09-20 10:08:20] usbcore: registered new device driver usb [2022-09-20 10:08:20] PCI: System does not support PCI [2022-09-20 10:08:20] clocksource: Switched to clocksource xen [2022-09-20 10:08:20] NET: Registered protocol family 2 [2022-09-20 10:08:20] IP idents hash table entries: 4096 (order: 3, 32768 bytes, linear) [2022-09-20 10:08:20] tcp_listen_portaddr_hash hash table entries: 256 (order: 0, 4096 bytes, linear) [2022-09-20 10:08:20] TCP established hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-20 10:08:20] TCP bind hash table entries: 2048 (order: 2, 16384 bytes, linear) [2022-09-20 10:08:20] TCP: Hash tables configured (established 2048 bind 2048) [2022-09-20 10:08:20] UDP hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-20 10:08:20] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes, linear) [2022-09-20 10:08:20] NET: Registered protocol family 1 [2022-09-20 10:08:20] Unpacking initramfs... [2022-09-20 10:08:20] Freeing initrd memory: 32236K [2022-09-20 10:08:20] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns [2022-09-20 10:08:20] clocksource: Switched to clocksource tsc [2022-09-20 10:08:20] workingset: timestamp_bits=3D62 max_order=3D15 bucket_order=3D0 [2022-09-20 10:08:20] xen:xen_evtchn: Event-channel device installed [2022-09-20 10:08:20] Invalid max_queues (4), will use default max: 1. [2022-09-20 10:08:21] random: fast init done [2022-09-20 10:08:21] tun: Universal TUN/TAP device driver, 1.6 [2022-09-20 10:08:21] xen_netfront: Initialising Xen virtual ethernet drive= r [2022-09-20 10:08:21] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-20 10:08:21] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 1 [2022-09-20 10:08:21] vhci_hcd: created sysfs vhci_hcd.0 [2022-09-20 10:08:21] hub 1-0:1.0: USB hub found [2022-09-20 10:08:21] hub 1-0:1.0: 8 ports detected [2022-09-20 10:08:21] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller [2022-09-20 10:08:21] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 2 [2022-09-20 10:08:21] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [2022-09-20 10:08:21] hub 2-0:1.0: USB hub found [2022-09-20 10:08:21] hub 2-0:1.0: 8 ports detected [2022-09-20 10:08:21] NET: Registered protocol family 17 [2022-09-20 10:08:21] sched_clock: Marking stable (312462849, 188928)->(314330248, -1678471) [2022-09-20 10:08:21] pcifront pci-0: Installing PCI frontend [2022-09-20 10:08:21] xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB [2022-09-20 10:08:21] software IO TLB: mapped [mem 0x0000000003800000-0x0000000003c00000] (4MB) [2022-09-20 10:08:21] pcifront pci-0: Creating PCI Frontend Bus 0000:00 [2022-09-20 10:08:21] pcifront pci-0: PCI host bridge to bus 0000:00 [2022-09-20 10:08:21] pci_bus 0000:00: root bus resource [io 0x0000-0xffff= ] [2022-09-20 10:08:21] pci_bus 0000:00: root bus resource [mem 0x00000000-0x7fffffffff] [2022-09-20 10:08:21] pci_bus 0000:00: root bus resource [bus 00-ff] [2022-09-20 10:08:21] pci 0000:00:00.0: [10ec:8168] type 00 class 0x020000 [2022-09-20 10:08:21] pci 0000:00:00.0: reg 0x10: [io 0x3000-0x30ff] [2022-09-20 10:08:21] pci 0000:00:00.0: reg 0x18: [mem 0xb4304000-0xb4304fff 64bit] [2022-09-20 10:08:21] pci 0000:00:00.0: reg 0x20: [mem 0xb4300000-0xb4303fff 64bit] [2022-09-20 10:08:21] pci 0000:00:00.0: supports D1 D2 [2022-09-20 10:08:21] pcifront pci-0: claiming resource 0000:00:00.0/0 [2022-09-20 10:08:21] pcifront pci-0: claiming resource 0000:00:00.0/2 [2022-09-20 10:08:21] pcifront pci-0: claiming resource 0000:00:00.0/4 [2022-09-20 10:08:21] blkfront: xvda: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-20 10:08:21] xvda: xvda4 [2022-09-20 10:08:21] blkfront: xvdb: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-20 10:08:21] blkfront: xvdc: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled; [2022-09-20 10:08:21] Freeing unused kernel image (initmem) memory: 696K [2022-09-20 10:08:21] Write protecting the kernel read-only data: 10240k [2022-09-20 10:08:21] Freeing unused kernel image (text/rodata gap) memory: 2044K [2022-09-20 10:08:21] Freeing unused kernel image (rodata/data gap) memory: 1620K [2022-09-20 10:08:21] Run /init as init process [2022-09-20 10:08:21] + mount -t devtmpfs none /dev [2022-09-20 10:08:21] + mount -t sysfs /sys /sys [2022-09-20 10:08:21] + mount -t proc /proc /proc [2022-09-20 10:08:21] + mount -t tmpfs -o 'size=3D1m,nodev,noexec' /tmp /tm= p [2022-09-20 10:08:21] + mount -o remount,ro / [2022-09-20 10:08:21] + echo 1 [2022-09-20 10:08:21] + printf '%d\n' 1073741824 [2022-09-20 10:08:21] + /bin/xenstore-read target [2022-09-20 10:08:21] + domid=3D19 [2022-09-20 10:08:21] + xenstore-read /local/domain/19/vm [2022-09-20 10:08:21] + vm_path=3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3 [2022-09-20 10:08:21] + sort [2022-09-20 10:08:21] + xenstore-list -p /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv [2022-09-20 10:08:21] + xenstore-read /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/004 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/009 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/014 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/018 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/023 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/028 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033 [2022-09-20 10:08:21] + dm_args=3D'-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + usb_args=3D [2022-09-20 10:08:21] + test -e /bin/qrexec-agent [2022-09-20 10:08:21] + usb_args=3D'-device [2022-09-20 10:08:21] nec-usb-xhci,id=3Dxhci' [2022-09-20 10:08:21] + mkdir -p /var/run/qubes [2022-09-20 10:08:21] + touch /dev/mdev.log [2022-09-20 10:08:21] + USER=3Droot qrexec-agent [2022-09-20 10:08:21] + mdev -d [2022-09-20 10:08:21] + sed -n '/^-soundhw/ {n;p}' [2022-09-20 10:08:21] + echo '-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + audio_model=3D [2022-09-20 10:08:21] + '[' -n ] [2022-09-20 10:08:21] + sed -n /^-qubes-net:/p [2022-09-20 10:08:21] + echo '-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + net_args=3D [2022-09-20 10:08:21] + sed /^-qubes-net:/d [2022-09-20 10:08:21] + echo '-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + dm_args=3D'-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + test -e /sys/class/net/eth0 [2022-09-20 10:08:21] + echo 'No network interface named eth0.' [2022-09-20 10:08:21] No network interface named eth0. [2022-09-20 10:08:21] + ls -l /sys/class/net/ [2022-09-20 10:08:21] total 0 [2022-09-20 10:08:21] lrwxrwxrwx 1 root 0 0 Sep 20 08:08 .[1;36mlo.[m -> .[1;34m../../devices/virtual/net/lo.[m [2022-09-20 10:08:21] + xenstore-read target [2022-09-20 10:08:21] + target=3D19 [2022-09-20 10:08:21] + device_model=3Ddevice-model/19 [2022-09-20 10:08:21] + mkdir /tmp/qmp [2022-09-20 10:08:21] + kernel=3D [2022-09-20 10:08:21] + grep -q ^-append [2022-09-20 10:08:21] + echo '-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + mkfifo /tmp/qmp/qemu.in /tmp/qmp/qemu.out [2022-09-20 10:08:21] + set +x [2022-09-20 10:08:21] Clearing kmsg buffer... [2022-09-20 10:08:21] + set +x [2022-09-20 10:08:21] + set +x [2022-09-20 10:08:21] + sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/' [2022-09-20 10:08:21] + echo '-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + dm_args=3D'-xen-domid [2022-09-20 10:08:21] 19 [2022-09-20 10:08:21] -no-shutdown [2022-09-20 10:08:21] -nodefaults [2022-09-20 10:08:21] -no-user-config [2022-09-20 10:08:21] -name [2022-09-20 10:08:21] openbsd-71 [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] VGA,vgamem_mb=3D16 [2022-09-20 10:08:21] -boot [2022-09-20 10:08:21] order=3Ddc [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-ehci,id=3Dehci [2022-09-20 10:08:21] -device [2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0 [2022-09-20 10:08:21] -smp [2022-09-20 10:08:21] 2,maxcpus=3D2 [2022-09-20 10:08:21] -net [2022-09-20 10:08:21] none [2022-09-20 10:08:21] -display [2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0 [2022-09-20 10:08:21] -machine [2022-09-20 10:08:21] xenfv [2022-09-20 10:08:21] -m [2022-09-20 10:08:21] 496 [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback [2022-09-20 10:08:21] -drive [2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback' [2022-09-20 10:08:21] + xenstore-read device/console/2 [2022-09-20 10:08:21] + xenstore-read device/console/1 [2022-09-20 10:08:21] + IFS=3D' [2022-09-20 10:08:21] ' [2022-09-20 10:08:21] + set -f [2022-09-20 10:08:21] + set +f [2022-09-20 10:08:21] + unset IFS [2022-09-20 10:08:21] + qemu_pid=3D148 [2022-09-20 10:08:21] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-20 10:08:21] + sleep 0.1 [2022-09-20 10:08:21] + qemu -sandbox 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resourcecontrol= =3Ddeny' -chardev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm' -mon 'chardev=3Dm,mode=3Dcontro= l' -chardev 'socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm2,mode=3Dcontrol' -xen-domid 19 -no-shutdown -nodefaults -no-user-config -name openbsd-71 -display none -device 'VGA,vgamem_mb=3D16' -boot 'order=3Ddc' -device 'usb-ehci,id=3Dehci' -device 'usb-tablet,bus=3De= hci.0' -smp '2,maxcpus=3D2' -net none -display 'qubes-gui,domid=3D0,log-level=3D0' -machine xenfv -m 496 -drive 'file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -drive 'file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cach= e=3Dwriteback' -device 'nec-usb-xhci,id=3Dxhci' [2022-09-20 10:08:21] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'server' deprecated [2022-09-20 10:08:21] Please use server=3Don instead [2022-09-20 10:08:21] qemu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'nowait' deprecated [2022-09-20 10:08:21] Please use wait=3Doff instead [2022-09-20 10:08:21] + tee /proc/self/fd/2 [2022-09-20 10:08:21] random: qemu: uninitialized urandom read (16 bytes read) [2022-09-20 10:08:21] + echo '{"execute": "qmp_capabilities"}' [2022-09-20 10:08:21] {"QMP": {"version": {"qemu": {"micro": 0, "minor": 1, "major": 6}, "package": ""}, "capabilities": ["oob"]}} [2022-09-20 10:08:21] {"execute": "qmp_capabilities"} [2022-09-20 10:08:21] qubes_gui/init: 573 [2022-09-20 10:08:21] qubes_gui/init: 582 [2022-09-20 10:08:21] qubes_gui/init: 584 [2022-09-20 10:08:21] qubes_gui/init[611]: version sent, waiting for xorg conf [2022-09-20 10:08:21] {"return": {}} [2022-09-20 10:08:21] + '[' '!' -e /tmp/qemu.qmp ] [2022-09-20 10:08:21] + '[' -e /proc/self/fd/4 ] [2022-09-20 10:08:21] + '[' -e /proc/self/fd/3 ] [2022-09-20 10:08:21] + true [2022-09-20 10:08:21] + printf '=3D=3D=3D=3D Press enter for shell =3D=3D= =3D=3D\n' [2022-09-20 10:08:21] =3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D [2022-09-20 10:08:21] + read [2022-09-20 10:08:21] + vchan-socket-proxy 0 device-model/19/qmp-vchan /tmp/qemu.qmp [2022-09-20 10:08:21] written 110 bytes to vchan [2022-09-20 10:08:21] written 34 bytes to vchan [2022-09-20 10:08:22] [00:06.0] xen_pt_realize: Assigning real physical device 07:00.0 to devfn 0x30 [2022-09-20 10:08:22] [00:06.0] xen_pt_register_regions: IO region 0 registered (size=3D0x00000100 base_addr=3D0x00003000 type: 0x1) [2022-09-20 10:08:22] [00:06.0] xen_pt_register_regions: IO region 2 registered (size=3D0x00001000 base_addr=3D0xb4304000 type: 0x4) [2022-09-20 10:08:22] [00:06.0] xen_pt_register_regions: IO region 4 registered (size=3D0x00004000 base_addr=3D0xb4300000 type: 0x4) [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x000e mismatch! Emulated=3D0x0080, host=3D0x0000, syncing to 0x0000. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0010 mismatch! Emulated=3D0x0000, host=3D0x3001, syncing to 0x3001. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0018 mismatch! Emulated=3D0x0000, host=3D0xb4304004, syncing to 0xb4304004. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0020 mismatch! Emulated=3D0x0000, host=3D0xb4300004, syncing to 0xb4300004. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0042 mismatch! Emulated=3D0x0000, host=3D0x07c3, syncing to 0x0603. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0052 mismatch! Emulated=3D0x0000, host=3D0x0080, syncing to 0x0080. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0074 mismatch! Emulated=3D0x0000, host=3D0x5908cc0, syncing to 0x5908cc0. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x007a mismatch! Emulated=3D0x0000, host=3D0x0010, syncing to 0x0010. [2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0082 mismatch! Emulated=3D0x0000, host=3D0x1011, syncing to 0x1011. [2022-09-20 10:08:22] [00:06.0] xen_pt_pci_intx: intx=3D1 [2022-09-20 10:08:22] [00:06.0] xen_pt_realize: Real physical device 07:00.0 registered successfully [2022-09-20 10:08:22] written 34 bytes to vchan [2022-09-20 10:08:22] written 2048 bytes to vchan [2022-09-20 10:08:22] written 979 bytes to vchan [2022-09-20 10:08:22] written 110 bytes to vchan [2022-09-20 10:08:22] written 34 bytes to vchan [2022-09-20 10:08:22] written 34 bytes to vchan [2022-09-20 10:08:22] qubes_gui/init[622]: got xorg conf, creating window [2022-09-20 10:08:22] qubes_gui/init: 632 [2022-09-20 10:08:22] configure msg, x/y 640 325 (was 0 0), w/h 640 480 [2022-09-20 10:08:23] random: crng init done [2022-09-20 10:08:43] [00:06.0] Write-back to unknown field 0x44 (partially) inhibited (0x0000ffff) [2022-09-20 10:08:43] [00:06.0] If the device doesn't work, try enabling permissive mode [2022-09-20 10:08:43] [00:06.0] (unsafe) and if it helps report the problem to xen-devel [2022-09-20 10:08:43] [00:06.0] xen_pt_msgctrl_reg_write: setup MSI (register: 81). [2022-09-20 10:08:43] [00:06.0] xen_pt_msi_setup: MSI mapped with pirq 151. [2022-09-20 10:08:43] [00:06.0] msi_msix_update: Updating MSI with pirq 151 gvec 0x72 gflags 0x0 (entry: 0x0) BR Adam wt., 20 wrz 2022 o 09:41 Adam Szewczyk napisa=C5=82(a)= : > (XEN) Built-in command line: ept=3Dexec-sp spec-ctrl=3Dunpriv-mmio >> (XEN) parameter "no-real-mode" unknown! >> Xen 4.14.5 >> (XEN) Xen version 4.14.5 (mockbuild@[unknown]) (gcc (GCC) 10.3.1 >> 20210422 (Red Hat 10.3.1-1)) debug=3Dn Wed Aug 24 00:00:00 UTC 2022 >> (XEN) Latest ChangeSet: >> (XEN) Bootloader: GRUB 2.04 >> (XEN) Command line: placeholder console=3Dnone dom0_mem=3Dmin:1024M >> dom0_mem=3Dmax:4096M ucode=3Dscan smt=3Doff gnttab_max_frames=3D2048 >> gnttab_max_maptrack_frames=3D4096 no-real-mode edd=3Doff >> (XEN) Xen image load base address: 0x9c200000 >> (XEN) Video information: >> (XEN) VGA is graphics mode 1920x1080, 32 bpp >> (XEN) Disc information: >> (XEN) Found 0 MBR signatures >> (XEN) Found 2 EDD information structures >> (XEN) EFI RAM map: >> (XEN) [0000000000000000, 000000000009efff] (usable) >> (XEN) [000000000009f000, 00000000000fffff] (reserved) >> (XEN) [0000000000100000, 0000000086466fff] (usable) >> (XEN) [0000000086467000, 0000000086d66fff] (reserved) >> (XEN) [0000000086d67000, 000000009cf7dfff] (usable) >> (XEN) [000000009cf7e000, 000000009e49dfff] (reserved) >> (XEN) [000000009e49e000, 000000009eb8dfff] (ACPI NVS) >> (XEN) [000000009eb8e000, 000000009ec0dfff] (ACPI data) >> (XEN) [000000009ec0e000, 000000009ec0efff] (usable) >> (XEN) [000000009ec0f000, 000000009fffffff] (reserved) >> (XEN) [00000000e0000000, 00000000efffffff] (reserved) >> (XEN) [00000000fe000000, 00000000fe010fff] (reserved) >> (XEN) [00000000fed10000, 00000000fed19fff] (reserved) >> (XEN) [00000000fed84000, 00000000fed84fff] (reserved) >> (XEN) [00000000fee00000, 00000000fee00fff] (reserved) >> (XEN) [00000000ff600000, 00000000ffffffff] (reserved) >> (XEN) [0000000100000000, 000000085dffffff] (usable) >> (XEN) ACPI: RSDP 9EC0D014, 0024 (r2 LENOVO) >> (XEN) ACPI: XSDT 9EBEE188, 00FC (r1 LENOVO CB-01 1 >> 1000013) >> (XEN) ACPI: FACP 9EBF1000, 010C (r5 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: DSDT 9EBBD000, 2FF34 (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: FACS 9EB0D000, 0040 >> (XEN) ACPI: UEFI 9EC0C000, 0236 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EC0A000, 1B1C (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EC06000, 31D0 (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: UEFI 9EC05000, 0042 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EC04000, 045A (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EC03000, 0046 (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: TPM2 9EC02000, 0034 (r3 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: POAT 9EC01000, 0055 (r3 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBFC000, 44B6 (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: LPIT 9EBFB000, 0094 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: WSMT 9EBFA000, 0028 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBF9000, 0C2F (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: DBGP 9EBF8000, 0034 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: DBG2 9EBF7000, 0061 (r0 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBF6000, 0896 (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBF3000, 2F89 (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: ASF! 9EBF2000, 00A5 (r32 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: HPET 9EBF0000, 0038 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: APIC 9EBEF000, 012C (r3 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: MCFG 9EBED000, 003C (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBBA000, 2BBF (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: DMAR 9EBB9000, 0070 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBB6000, 2B68 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: SSDT 9EBB5000, 004C (r2 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: FPDT 9EBB4000, 0044 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) ACPI: BGRT 9EBB3000, 0038 (r1 LENOVO CB-01 1 ACPI >> 40000) >> (XEN) System RAM: 32678MB (33462392kB) >> (XEN) Domain heap initialised >> (XEN) ACPI: 32/64X FACS address mismatch in FADT - >> 9eb0d000/0000000000000000, using 32 >> (XEN) IOAPIC[0]: apic_id 2, version 32, address 0xfec00000, GSI 0-119 >> (XEN) Enabling APIC mode: Phys. Using 1 I/O APICs >> (XEN) Switched to APIC driver x2apic_cluster >> (XEN) CPU0: TSC: ratio: 216 / 2 >> (XEN) CPU0: bus: 100 MHz base: 2600 MHz max: 4500 MHz >> (XEN) CPU0: 800 ... 2600 MHz >> (XEN) xstate: size: 0x440 and states: 0x1f >> (XEN) Speculative mitigation facilities: >> (XEN) Hardware hints: RSBA >> (XEN) Hardware features: IBPB IBRS STIBP SSBD L1D_FLUSH MD_CLEAR >> SRBDS_CTRL >> (XEN) Compiled-in support: INDIRECT_THUNK >> (XEN) Xen settings: BTI-Thunk JMP, SPEC_CTRL: IBRS+ STIBP+ SSBD-, >> Other: SRB_LOCK+ IBPB-ctxt L1D_FLUSH VERW BRANCH_HARDEN >> (XEN) L1TF: believed vulnerable, maxphysaddr L1D 46, CPUID 39, Safe >> address 8000000000 >> (XEN) Support for HVM VMs: MSR_SPEC_CTRL RSB EAGER_FPU MD_CLEAR >> (XEN) Support for PV VMs: MSR_SPEC_CTRL EAGER_FPU MD_CLEAR >> (XEN) XPTI (64-bit PV only): Dom0 enabled, DomU enabled (with PCID) >> (XEN) PV L1TF shadowing: Dom0 disabled, DomU enabled >> (XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2) >> (XEN) Initializing Credit2 scheduler >> (XEN) Disabling HPET for being unreliable >> (XEN) Platform timer is 3.580MHz ACPI PM Timer >> (XEN) Detected 2591.999 MHz processor. >> (XEN) Unknown cachability for MFNs 0xa0-0xff >> (XEN) Unknown cachability for MFNs 0x9f000-0x9ffff >> (XEN) Intel VT-d iommu 0 supported page sizes: 4kB, 2MB, 1GB >> (XEN) Intel VT-d Snoop Control enabled. >> (XEN) Intel VT-d Dom0 DMA Passthrough not enabled. >> (XEN) Intel VT-d Queued Invalidation enabled. >> (XEN) Intel VT-d Interrupt Remapping enabled. >> (XEN) Intel VT-d Posted Interrupt not enabled. >> (XEN) Intel VT-d Shared EPT tables enabled. >> (XEN) I/O virtualisation enabled >> (XEN) - Dom0 mode: Relaxed >> (XEN) Interrupt remapping enabled >> (XEN) Enabled directed EOI with ioapic_ack_old on! >> (XEN) ENABLING IO-APIC IRQs >> (XEN) -> Using old ACK method >> (XEN) Allocated console ring of 32 KiB. >> (XEN) VMX: Supported advanced features: >> (XEN) - APIC MMIO access virtualisation >> (XEN) - APIC TPR shadow >> (XEN) - Extended Page Tables (EPT) >> (XEN) - Virtual-Processor Identifiers (VPID) >> (XEN) - Virtual NMI >> (XEN) - MSR direct-access bitmap >> (XEN) - Unrestricted Guest >> (XEN) - VM Functions >> (XEN) - Virtualisation Exceptions >> (XEN) - Page Modification Logging >> (XEN) HVM: ASIDs enabled. >> (XEN) HVM: VMX enabled >> (XEN) HVM: Hardware Assisted Paging (HAP) detected >> (XEN) HVM: HAP page sizes: 4kB, 2MB, 1GB >> (XEN) Brought up 6 CPUs >> (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource >> (XEN) Dom0 has maximum 952 PIRQs >> (XEN) Xen kernel: 64-bit, lsb, compat32 >> (XEN) Dom0 kernel: 64-bit, PAE, lsb, paddr 0x1000000 -> 0x4000000 >> (XEN) PHYSICAL MEMORY ARRANGEMENT: >> (XEN) Dom0 alloc.: 0000000838000000->0000000840000000 (1007932 pages >> to be allocated) >> (XEN) Init. ramdisk: 000000085c13c000->000000085dffff1d >> (XEN) VIRTUAL MEMORY ARRANGEMENT: >> (XEN) Loaded kernel: ffffffff81000000->ffffffff84000000 >> (XEN) Init. ramdisk: 0000000000000000->0000000000000000 >> (XEN) Phys-Mach map: 0000008000000000->0000008000800000 >> (XEN) Start info: ffffffff84000000->ffffffff840004b8 >> (XEN) Xenstore ring: 0000000000000000->0000000000000000 >> (XEN) Console ring: 0000000000000000->0000000000000000 >> (XEN) Page tables: ffffffff84001000->ffffffff84026000 >> (XEN) Boot stack: ffffffff84026000->ffffffff84027000 >> (XEN) TOTAL: ffffffff80000000->ffffffff84400000 >> (XEN) ENTRY ADDRESS: ffffffff830fb1c0 >> (XEN) Dom0 has maximum 6 VCPUs >> (XEN) Initial low memory virq threshold set at 0x4000 pages. >> (XEN) Scrubbing Free RAM in background >> (XEN) Std. Loglevel: Errors and warnings >> (XEN) Guest Loglevel: Nothing (Rate-limited: Errors and warnings) >> (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch inpu= t) >> (XEN) Freed 580kB init memory >> (XEN) MSI information: >> (XEN) IOMMU 120 vec=3D30 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /? >> (XEN) MSI 121 vec=3Dc8 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 122 vec=3Dd0 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 123 vec=3De0 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D0/ /? >> (XEN) MSI 124 vec=3D31 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D0/ /? >> (XEN) MSI-X 125 vec=3D51 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI-X 126 vec=3D59 lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D1/ /0 >> (XEN) MSI-X 127 vec=3D61 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI-X 128 vec=3D69 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /0 >> (XEN) MSI-X 129 vec=3D71 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D1/ /0 >> (XEN) MSI-X 130 vec=3D79 lowest edge assert log lowest dest=3D0000= 0040 >> mask=3D1/ /0 >> (XEN) MSI-X 131 vec=3D81 lowest edge assert log lowest dest=3D0000= 0001 >> mask=3D1/ /0 >> (XEN) MSI 132 vec=3Dd9 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D0/ /? >> (XEN) MSI 133 vec=3Dc9 lowest edge assert log lowest dest=3D0000= 0004 >> mask=3D0/ /? >> (XEN) MSI 134 vec=3D99 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D0/ /? >> (XEN) MSI 135 vec=3Da9 lowest edge assert log lowest dest=3D0000= 0555 >> mask=3D0/ /? >> (XEN) MSI 136 vec=3Db1 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) MSI 137 vec=3Db9 lowest edge assert log lowest dest=3D0000= 0010 >> mask=3D0/ /? >> (XEN) MSI 138 vec=3Dd1 lowest edge assert log lowest dest=3D0000= 0100 >> mask=3D0/ /? >> (XEN) IRQ information: >> (XEN) IRQ: 0 vec:f0 IO-APIC-edge status=3D000 aff:{0}/{0} >> time.c#timer_interrupt() >> (XEN) IRQ: 1 vec:39 IO-APIC-edge status=3D034 aff:{8}/{0-11} >> in-flight=3D0 d0: 1(---) >> (XEN) IRQ: 3 vec:40 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 4 vec:48 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 5 vec:50 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 6 vec:58 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 7 vec:60 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 8 vec:68 IO-APIC-edge status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 8(---) >> (XEN) IRQ: 9 vec:b0 IO-APIC-level status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0: 9(---) >> (XEN) IRQ: 10 vec:78 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 11 vec:88 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 12 vec:90 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 13 vec:98 IO-APIC-edge status=3D002 aff:{0-15}/{0} >> mapped, unbound >> (XEN) IRQ: 14 vec:a0 IO-APIC-level status=3D030 aff:{0}/{0} >> in-flight=3D0 d0: 14(---) >> (XEN) IRQ: 15 vec:a8 IO-APIC-edge status=3D002 aff:{0}/{0} mapped= , >> unbound >> (XEN) IRQ: 16 vec:b8 IO-APIC-level status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d0: 16(---),d3: 16(-M-) >> (XEN) IRQ: 17 vec:d8 IO-APIC-level status=3D010 aff:{10}/{0-11} >> in-flight=3D2 d0: 17(P-M),d7: 17(-MM) >> (XEN) IRQ: 18 vec:c0 IO-APIC-level status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0: 18(---),d3: 18(-M-) >> (XEN) IRQ: 19 vec:a1 IO-APIC-level status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 20 vec:e8 IO-APIC-level status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0: 20(---) >> (XEN) IRQ: 83 vec:41 IO-APIC-level status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0: 83(---) >> (XEN) IRQ: 120 vec:30 DMA_MSI status=3D000 aff:{0-15}/{0} >> iommu.c#iommu_page_fault() >> (XEN) IRQ: 121 vec:c8 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:951(---) >> (XEN) IRQ: 122 vec:d0 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:950(---) >> (XEN) IRQ: 123 vec:e0 PCI-MSI status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:949(---) >> (XEN) IRQ: 124 vec:31 PCI-MSI status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:948(---) >> (XEN) IRQ: 125 vec:51 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:947(---) >> (XEN) IRQ: 126 vec:59 PCI-MSI/-X status=3D010 aff:{2}/{0-11} >> in-flight=3D0 d0:946(---) >> (XEN) IRQ: 127 vec:61 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:945(---) >> (XEN) IRQ: 128 vec:69 PCI-MSI/-X status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:944(---) >> (XEN) IRQ: 129 vec:71 PCI-MSI/-X status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:943(---) >> (XEN) IRQ: 130 vec:79 PCI-MSI/-X status=3D030 aff:{6}/{0-11} >> in-flight=3D0 d0:942(---) >> (XEN) IRQ: 131 vec:81 PCI-MSI/-X status=3D030 aff:{0}/{0-11} >> in-flight=3D0 d0:941(---) >> (XEN) IRQ: 132 vec:d9 PCI-MSI status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d7:151(-M-) >> (XEN) IRQ: 133 vec:c9 PCI-MSI status=3D030 aff:{2}/{0-11} >> in-flight=3D0 d3:151(---) >> (XEN) IRQ: 134 vec:99 PCI-MSI status=3D030 aff:{8}/{0-11} >> in-flight=3D0 d0:938(---) >> (XEN) IRQ: 135 vec:a9 PCI-MSI status=3D002 aff:{0-15}/{0-11} >> mapped, unbound >> (XEN) IRQ: 136 vec:b1 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:936(---) >> (XEN) IRQ: 137 vec:b9 PCI-MSI status=3D030 aff:{4}/{0-11} >> in-flight=3D0 d0:935(---) >> (XEN) IRQ: 138 vec:d1 PCI-MSI status=3D010 aff:{8}/{0-11} >> in-flight=3D0 d3:150(---) >> (XEN) Direct vector information: >> (XEN) 0x22 -> irq_move_cleanup_interrupt() >> (XEN) 0xf1 -> mce_intel.c#cmci_interrupt() >> (XEN) 0xf2 -> mce_intel.c#intel_thermal_interrupt() >> (XEN) 0xf9 -> pmu_apic_interrupt() >> (XEN) 0xfa -> apic_timer_interrupt() >> (XEN) 0xfb -> call_function_interrupt() >> (XEN) 0xfc -> event_check_interrupt() >> (XEN) 0xfd -> invalidate_interrupt() >> (XEN) 0xfe -> error_interrupt() >> (XEN) 0xff -> spurious_interrupt() >> (XEN) IO-APIC interrupt information: >> (XEN) IRQ 0 Vec240: >> (XEN) Apic 0x00, Pin 2: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 1 Vec 57: >> (XEN) Apic 0x00, Pin 1: vec=3D39 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000100 >> (XEN) IRQ 3 Vec 64: >> (XEN) Apic 0x00, Pin 3: vec=3D40 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 4 Vec 72: >> (XEN) Apic 0x00, Pin 4: vec=3D48 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 5 Vec 80: >> (XEN) Apic 0x00, Pin 5: vec=3D50 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 6 Vec 88: >> (XEN) Apic 0x00, Pin 6: vec=3D58 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 7 Vec 96: >> (XEN) Apic 0x00, Pin 7: vec=3D60 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 8 Vec104: >> (XEN) Apic 0x00, Pin 8: vec=3D68 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 9 Vec176: >> (XEN) Apic 0x00, Pin 9: vec=3Db0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 >> (XEN) IRQ 10 Vec120: >> (XEN) Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 11 Vec136: >> (XEN) Apic 0x00, Pin 11: vec=3D88 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 12 Vec144: >> (XEN) Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 13 Vec152: >> (XEN) Apic 0x00, Pin 13: vec=3D98 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D1 dest_id:00000001 >> (XEN) IRQ 14 Vec160: >> (XEN) Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 15 Vec168: >> (XEN) Apic 0x00, Pin 15: vec=3Da8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001 >> (XEN) IRQ 16 Vec184: >> (XEN) Apic 0x00, Pin 16: vec=3Db8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004 >> (XEN) IRQ 17 Vec216: >> (XEN) Apic 0x00, Pin 17: vec=3Dd8 delivery=3DLoPri dest=3DL status= =3D1 >> polarity=3D1 irr=3D1 trig=3DL mask=3D0 dest_id:00000400 >> (XEN) IRQ 18 Vec192: >> (XEN) Apic 0x00, Pin 18: vec=3Dc0 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000100 >> (XEN) IRQ 19 Vec161: >> (XEN) Apic 0x00, Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D1 dest_id:00000555 >> (XEN) IRQ 20 Vec232: >> (XEN) Apic 0x00, Pin 20: vec=3De8 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001 >> (XEN) IRQ 83 Vec 65: >> (XEN) Apic 0x00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status= =3D0 >> polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000010 > > > Name ID Mem VCPUs State Time(s) >> Domain-0 0 4080 6 r----- >> 288.6 >> sys-usb 3 284 2 -b---- >> 20.5 >> sys-usb-dm 4 144 1 -b---- >> 3.5 >> openbsd-71 7 511 2 -b---- >> 63.0 >> openbsd-71-dm 8 144 1 -b---- >> 14.0 >> > > How I can enable install this debug hypervisor? I have problems finding > anything about it. > > I don't have logs with qemu in the name, instead I have gmp-proxy logs. > But their all looks empty. > > BR Adam > > pon., 19 wrz 2022 o 11:21 Roger Pau Monn=C3=A9 > napisa=C5=82(a): > >> On Fri, Sep 16, 2022 at 05:08:59PM +0200, Adam Szewczyk wrote: >> > Sorry, I always forgot that default answer is "answer" to not "answer = to >> > all". >> > >> > My xl dmesg after calling those debug-keys is: >> >> Trimming the trace: >> >> > (XEN) MSI information: >> >> > (XEN) MSI 125 vec=3D72 lowest edge assert log lowest dest=3D00= 000100 >> > mask=3D0/ /? >> >> > (XEN) MSI 138 vec=3D62 lowest edge assert log lowest dest=3D00= 000001 >> > mask=3D0/ /? >> > (XEN) MSI 139 vec=3D6a lowest edge assert log lowest dest=3D00= 000010 >> > mask=3D0/ /? >> >> > (XEN) IRQ information: >> >> > (XEN) IRQ: 125 vec:72 PCI-MSI status=3D030 aff:{8}/{0-11} >> > in-flight=3D0 d94:151(-M-) >> >> > (XEN) IRQ: 138 vec:62 PCI-MSI status=3D030 aff:{0}/{0-11} >> > in-flight=3D0 d92:151(---) >> > (XEN) IRQ: 139 vec:6a PCI-MSI status=3D010 aff:{4}/{0-11} >> > in-flight=3D0 d92:150(---) >> >> Was domain with ID 94 your OpenBSD box? There's another domain with >> passthrough devices (ID 92). >> >> If your OpenBSD domain is the one with ID 94 it seems like the >> interrupt source is masked, so no interrupts will be injected to the >> guest. That however might be just the response from the guest after >> seeing that the interrupt source is not behaving correctly. >> >> Are yuo using a debug hypervisor? If not it would be helpful to do so, >> in order to maybe get more information on `xl dmesg`. >> >> Can you also paste the QEMU log for the OpeNSD domain? Those logs are >> in /var/log/xen/qemu-dm-.log, on most distros, not sure >> if QubesOS puts them at the same place. >> >> Regards, Roger. >> > --000000000000344bfe05e9176609 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On, log section i Qubes manager also those logs are e= mpty, but I can attach /var/log/xen/console/guest-openbsd-71-dm.log:
<= div>[2022-09-19 19:50:55] Logfile Opened
[2022-09-19 19:50:56] Linux ver= sion 5.10.105-xen-stubdom (mockbuild@0c9ad8f2058f40c49bc934dcc2ea73c7) (gcc= (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld version 2.34-6.fc32) #1 F= ri Apr 22 17:53:39 CEST 2022
[2022-09-19 19:50:56] Command line:
[20= 22-09-19 19:50:56] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floati= ng point registers'
[2022-09-19 19:50:56] x86/fpu: Supporting XSAVE = feature 0x002: 'SSE registers'
[2022-09-19 19:50:56] x86/fpu: Su= pporting XSAVE feature 0x004: 'AVX registers'
[2022-09-19 19:50:= 56] x86/fpu: xstate_offset[2]: =C2=A0576, xstate_sizes[2]: =C2=A0256
[20= 22-09-19 19:50:56] x86/fpu: Enabled xstate features 0x7, context size is 83= 2 bytes, using 'standard' format.
[2022-09-19 19:50:56] Released= 0 page(s)
[2022-09-19 19:50:56] BIOS-provided physical RAM map:
[202= 2-09-19 19:50:56] Xen: [mem 0x0000000000000000-0x000000000009ffff] usable[2022-09-19 19:50:56] Xen: [mem 0x00000000000a0000-0x00000000000fffff] re= served
[2022-09-19 19:50:56] Xen: [mem 0x0000000000100000-0x0000000008ff= ffff] usable
[2022-09-19 19:50:56] NX (Execute Disable) protection: acti= ve
[2022-09-19 19:50:56] Hypervisor detected: Xen PV
[2022-09-19 19:5= 0:56] tsc: Fast TSC calibration failed
[2022-09-19 19:50:56] tsc: Detect= ed 2591.990 MHz processor
[2022-09-19 19:50:56] last_pfn =3D 0x9000 max_= arch_pfn =3D 0x400000000
[2022-09-19 19:50:56] x86/PAT: Configuration [0= -7]: WB =C2=A0WT =C2=A0UC- UC =C2=A0WC =C2=A0WP =C2=A0UC =C2=A0UC =C2=A0[2022-09-19 19:50:56] RAMDISK: [mem 0x02000000-0x03f7afff]
[2022-09-19 = 19:50:56] Zone ranges:
[2022-09-19 19:50:56] =C2=A0 DMA32 =C2=A0 =C2=A0[= mem 0x0000000000001000-0x0000000008ffffff]
[2022-09-19 19:50:56] =C2=A0 = Normal =C2=A0 empty
[2022-09-19 19:50:56] Movable zone start for each no= de
[2022-09-19 19:50:56] Early memory node ranges
[2022-09-19 19:50:5= 6] =C2=A0 node =C2=A0 0: [mem 0x0000000000001000-0x000000000009ffff]
[20= 22-09-19 19:50:56] =C2=A0 node =C2=A0 0: [mem 0x0000000000100000-0x00000000= 08ffffff]
[2022-09-19 19:50:56] Initmem setup node 0 [mem 0x000000000000= 1000-0x0000000008ffffff]
[2022-09-19 19:50:56] On node 0, zone DMA32: 1 = pages in unavailable ranges
[2022-09-19 19:50:56] On node 0, zone DMA32:= 96 pages in unavailable ranges
[2022-09-19 19:50:56] On node 0, zone DM= A32: 28672 pages in unavailable ranges
[2022-09-19 19:50:56] p2m virtual= area at (____ptrval____), size is 200000
[2022-09-19 19:50:56] Remapped= 0 page(s)
[2022-09-19 19:50:56] [mem 0x09000000-0xffffffff] available f= or PCI devices
[2022-09-19 19:50:56] Booting paravirtualized kernel on X= en
[2022-09-19 19:50:56] Xen version: 4.14.5 (preserve-AD)
[2022-09-1= 9 19:50:56] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xff= ffffff, max_idle_ns: 7645519600211568 ns
[2022-09-19 19:50:56] Built 1 z= onelists, mobility grouping on.=C2=A0 Total pages: 36170
[2022-09-19 19:= 50:56] Kernel command line: clocksource=3Dtsc
[2022-09-19 19:50:56] Den= try cache hash table entries: 32768 (order: 6, 262144 bytes, linear)
[20= 22-09-19 19:50:56] Inode-cache hash table entries: 16384 (order: 5, 131072 = bytes, linear)
[2022-09-19 19:50:56] mem auto-init: stack:byref_all(zero= ), heap alloc:off, heap free:off
[2022-09-19 19:50:56] Memory: 96968K/14= 7068K available (6145K kernel code, 842K rwdata, 428K rodata, 696K init, 47= 6K bss, 49848K reserved, 0K cma-reserved)
[2022-09-19 19:50:56] random: = get_random_u64 called from 0xffffffff810a0f18 with crng_init=3D0
[2022-0= 9-19 19:50:56] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs=3D1, N= odes=3D1
[2022-09-19 19:50:56] Using NULL legacy PIC
[2022-09-19 19:5= 0:56] NR_IRQS: 4352, nr_irqs: 24, preallocated irqs: 0
[2022-09-19 19:50= :56] xen:events: Using FIFO-based ABI
[2022-09-19 19:50:56] printk: cons= ole [hvc0] enabled
[2022-09-19 19:50:56] clocksource: xen: mask: 0xfffff= fffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns
[202= 2-09-19 19:50:56] installing Xen timer for CPU 0
[2022-09-19 19:50:56] c= locksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x255cad98bda, = max_idle_ns: 440795306906 ns
[2022-09-19 19:50:56] Calibrating delay loo= p (skipped), value calculated using timer frequency.. 5183.98 BogoMIPS (lpj= =3D10367960)
[2022-09-19 19:50:56] pid_max: default: 4096 minimum: 301[2022-09-19 19:50:56] Mount-cache hash table entries: 512 (order: 0, 4096= bytes, linear)
[2022-09-19 19:50:56] Mountpoint-cache hash table entrie= s: 512 (order: 0, 4096 bytes, linear)
[2022-09-19 19:50:56] Last level i= TLB entries: 4KB 64, 2MB 8, 4MB 8
[2022-09-19 19:50:56] Last level dTLB = entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4
[2022-09-19 19:50:56] CPU: Intel(R)= Core(TM) i7-9750H CPU @ 2.60GHz (family: 0x6, model: 0x9e, stepping: 0xa)<= br>[2022-09-19 19:50:56] Spectre V1 : Mitigation: usercopy/swapgs barriers = and __user pointer sanitization
[2022-09-19 19:50:56] Spectre V2 : Mitig= ation: Retpolines
[2022-09-19 19:50:56] Spectre V2 : Spectre v2 / Spectr= eRSB mitigation: Filling RSB on context switch
[2022-09-19 19:50:56] Spe= ctre V2 : Enabling Restricted Speculation for firmware calls
[2022-09-19= 19:50:56] Spectre V2 : mitigation: Enabling conditional Indirect Branch Pr= ediction Barrier
[2022-09-19 19:50:56] Speculative Store Bypass: Mitigat= ion: Speculative Store Bypass disabled via prctl and seccomp
[2022-09-19= 19:50:56] SRBDS: Unknown: Dependent on hypervisor status
[2022-09-19 19= :50:56] MDS: Mitigation: Clear CPU buffers
[2022-09-19 19:50:56] Perform= ance Events: unsupported p6 CPU model 158 no PMU driver, software events on= ly.
[2022-09-19 19:50:56] devtmpfs: initialized
[2022-09-19 19:50:56]= clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns= : 7645041785100000 ns
[2022-09-19 19:50:56] futex hash table entries: 16= (order: -4, 384 bytes, linear)
[2022-09-19 19:50:56] NET: Registered pr= otocol family 16
[2022-09-19 19:50:56] xen:grant_table: Grant tables usi= ng version 1 layout
[2022-09-19 19:50:56] Grant table initialized
[20= 22-09-19 19:50:56] PCI: setting up Xen PCI frontend stub
[2022-09-19 19:= 50:56] xen:balloon: Initialising balloon driver
[2022-09-19 19:50:56] us= bcore: registered new interface driver usbfs
[2022-09-19 19:50:56] usbco= re: registered new interface driver hub
[2022-09-19 19:50:56] usbcore: r= egistered new device driver usb
[2022-09-19 19:50:56] PCI: System does n= ot support PCI
[2022-09-19 19:50:56] clocksource: Switched to clocksourc= e xen
[2022-09-19 19:50:56] NET: Registered protocol family 2
[2022-0= 9-19 19:50:56] IP idents hash table entries: 4096 (order: 3, 32768 bytes, l= inear)
[2022-09-19 19:50:56] tcp_listen_portaddr_hash hash table entries= : 256 (order: 0, 4096 bytes, linear)
[2022-09-19 19:50:56] TCP establish= ed hash table entries: 2048 (order: 2, 16384 bytes, linear)
[2022-09-19 = 19:50:56] TCP bind hash table entries: 2048 (order: 2, 16384 bytes, linear)=
[2022-09-19 19:50:56] TCP: Hash tables configured (established 2048 bin= d 2048)
[2022-09-19 19:50:56] UDP hash table entries: 128 (order: 0, 409= 6 bytes, linear)
[2022-09-19 19:50:56] UDP-Lite hash table entries: 128 = (order: 0, 4096 bytes, linear)
[2022-09-19 19:50:56] NET: Registered pro= tocol family 1
[2022-09-19 19:50:56] Unpacking initramfs...
[2022-09-= 19 19:50:56] Freeing initrd memory: 32236K
[2022-09-19 19:50:56] clockso= urce: tsc: mask: 0xffffffffffffffff max_cycles: 0x255cad98bda, max_idle_ns:= 440795306906 ns
[2022-09-19 19:50:56] clocksource: Switched to clocksou= rce tsc
[2022-09-19 19:50:56] workingset: timestamp_bits=3D62 max_order= =3D15 bucket_order=3D0
[2022-09-19 19:50:56] xen:xen_evtchn: Event-chann= el device installed
[2022-09-19 19:50:56] Invalid max_queues (4), will u= se default max: 1.
[2022-09-19 19:50:56] tun: Universal TUN/TAP device d= river, 1.6
[2022-09-19 19:50:56] xen_netfront: Initialising Xen virtual = ethernet driver
[2022-09-19 19:50:56] vhci_hcd vhci_hcd.0: USB/IP Virtua= l Host Controller
[2022-09-19 19:50:56] vhci_hcd vhci_hcd.0: new USB bus= registered, assigned bus number 1
[2022-09-19 19:50:56] vhci_hcd: creat= ed sysfs vhci_hcd.0
[2022-09-19 19:50:56] hub 1-0:1.0: USB hub found
= [2022-09-19 19:50:56] hub 1-0:1.0: 8 ports detected
[2022-09-19 19:50:56= ] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller
[2022-09-19 19:50:= 56] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number 2
[= 2022-09-19 19:50:56] usb usb2: We don't know the algorithms for LPM for= this host, disabling LPM.
[2022-09-19 19:50:56] hub 2-0:1.0: USB hub fo= und
[2022-09-19 19:50:56] hub 2-0:1.0: 8 ports detected
[2022-09-19 1= 9:50:56] NET: Registered protocol family 17
[2022-09-19 19:50:56] sched_= clock: Marking stable (273283961, 179377)->(275136085, -1672747)
[202= 2-09-19 19:50:56] random: fast init done
[2022-09-19 19:50:56] blkfront:= xvda: flush diskcache: enabled; persistent grants: enabled; indirect descr= iptors: enabled;
[2022-09-19 19:50:56] =C2=A0xvda: xvda4
[2022-09-19 = 19:50:56] blkfront: xvdb: flush diskcache: enabled; persistent grants: enab= led; indirect descriptors: enabled;
[2022-09-19 19:50:56] blkfront: xvdc= : flush diskcache: enabled; persistent grants: enabled; indirect descriptor= s: enabled;
[2022-09-19 19:50:56] Freeing unused kernel image (initmem) = memory: 696K
[2022-09-19 19:50:56] Write protecting the kernel read-only= data: 10240k
[2022-09-19 19:50:56] Freeing unused kernel image (text/ro= data gap) memory: 2044K
[2022-09-19 19:50:56] Freeing unused kernel imag= e (rodata/data gap) memory: 1620K
[2022-09-19 19:50:56] Run /init as ini= t process
[2022-09-19 19:50:56] + mount -t devtmpfs none /dev
[2022-0= 9-19 19:50:56] + mount -t sysfs /sys /sys
[2022-09-19 19:50:56] + mount = -t proc /proc /proc
[2022-09-19 19:50:56] + mount -t tmpfs -o 'size= =3D1m,nodev,noexec' /tmp /tmp
[2022-09-19 19:50:56] + mount -o remou= nt,ro /
[2022-09-19 19:50:56] + echo 1
[2022-09-19 19:50:56] + printf= '%d\n' 1073741824
[2022-09-19 19:50:56] + /bin/xenstore-read ta= rget
[2022-09-19 19:50:56] + domid=3D62
[2022-09-19 19:50:56] + xenst= ore-read /local/domain/62/vm
[2022-09-19 19:50:56] + vm_path=3D/vm/53ce9= bfa-8c06-4587-9b52-dcccd76169b3
[2022-09-19 19:50:56] + sort
[2022-09= -19 19:50:56] + xenstore-list -p /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/i= mage/dm-argv
[2022-09-19 19:50:56] + xenstore-read /vm/53ce9bfa-8c06-458= 7-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c06-4587-9b52-dcccd7616= 9b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-arg= v/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/004 /vm/53ce9b= fa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/53ce9bfa-8c06-4587-9b5= 2-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/i= mage/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/008= /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/009 /vm/53ce9bfa-8c= 06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9bfa-8c06-4587-9b52-dcc= cd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/= dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/013 /vm/= 53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/014 /vm/53ce9bfa-8c06-45= 87-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8c06-4587-9b52-dcccd761= 69b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-ar= gv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/018 /vm/53ce9= bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm/53ce9bfa-8c06-4587-9b= 52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/= image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/02= 2 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/023 /vm/53ce9bfa-8= c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce9bfa-8c06-4587-9b52-dc= ccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image= /dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/027 /vm= /53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/028 /vm/53ce9bfa-8c06-4= 587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-8c06-4587-9b52-dcccd76= 169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-a= rgv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/032 /vm/53ce= 9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033
[2022-09-19 19:50:56]= + dm_args=3D'-xen-domid
[2022-09-19 19:50:56] 62
[2022-09-19 19:= 50:56] -no-shutdown
[2022-09-19 19:50:56] -nodefaults
[2022-09-19 19:= 50:56] -no-user-config
[2022-09-19 19:50:56] -name
[2022-09-19 19:50:= 56] openbsd-71
[2022-09-19 19:50:56] -display
[2022-09-19 19:50:56] n= one
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] VGA,vgamem_mb= =3D16
[2022-09-19 19:50:56] -boot
[2022-09-19 19:50:56] order=3Ddc[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-ehci,id=3Dehci<= br>[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-tablet,bus=3D= ehci.0
[2022-09-19 19:50:56] -smp
[2022-09-19 19:50:56] 2,maxcpus=3D2=
[2022-09-19 19:50:56] -net
[2022-09-19 19:50:56] none
[2022-09-19= 19:50:56] -display
[2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level= =3D0
[2022-09-19 19:50:56] -machine
[2022-09-19 19:50:56] xenfv
[2= 022-09-19 19:50:56] -m
[2022-09-19 19:50:56] 496
[2022-09-19 19:50:56= ] -drive
[2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media= =3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:50:56] -dr= ive
[2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddi= sk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:50:56] -drive[2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,fo= rmat=3Dhost_device,cache=3Dwriteback'
[2022-09-19 19:50:56] + usb_ar= gs=3D
[2022-09-19 19:50:56] + test -e /bin/qrexec-agent
[2022-09-19 1= 9:50:56] + usb_args=3D'-device
[2022-09-19 19:50:56] nec-usb-xhci,id= =3Dxhci'
[2022-09-19 19:50:56] + mkdir -p /var/run/qubes
[2022-09= -19 19:50:56] + touch /dev/mdev.log
[2022-09-19 19:50:56] + mdev -d
[= 2022-09-19 19:50:56] + USER=3Droot qrexec-agent
[2022-09-19 19:50:56] + = sed -n '/^-soundhw/ {n;p}'
[2022-09-19 19:50:56] + echo '-xe= n-domid
[2022-09-19 19:50:56] 62
[2022-09-19 19:50:56] -no-shutdown[2022-09-19 19:50:56] -nodefaults
[2022-09-19 19:50:56] -no-user-confi= g
[2022-09-19 19:50:56] -name
[2022-09-19 19:50:56] openbsd-71
[20= 22-09-19 19:50:56] -display
[2022-09-19 19:50:56] none
[2022-09-19 19= :50:56] -device
[2022-09-19 19:50:56] VGA,vgamem_mb=3D16
[2022-09-19 = 19:50:56] -boot
[2022-09-19 19:50:56] order=3Ddc
[2022-09-19 19:50:56= ] -device
[2022-09-19 19:50:56] usb-ehci,id=3Dehci
[2022-09-19 19:50:= 56] -device
[2022-09-19 19:50:56] usb-tablet,bus=3Dehci.0
[2022-09-19= 19:50:56] -smp
[2022-09-19 19:50:56] 2,maxcpus=3D2
[2022-09-19 19:50= :56] -net
[2022-09-19 19:50:56] none
[2022-09-19 19:50:56] -display[2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0
[2022-09-19 19= :50:56] -machine
[2022-09-19 19:50:56] xenfv
[2022-09-19 19:50:56] -m=
[2022-09-19 19:50:56] 496
[2022-09-19 19:50:56] -drive
[2022-09-1= 9 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_= device,cache=3Dwriteback
[2022-09-19 19:50:56] -drive
[2022-09-19 19:= 50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_devic= e,cache=3Dwriteback
[2022-09-19 19:50:56] -drive
[2022-09-19 19:50:56= ] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cac= he=3Dwriteback'
[2022-09-19 19:50:56] + audio_model=3D
[2022-09-1= 9 19:50:56] + '[' -n =C2=A0]
[2022-09-19 19:50:56] + sed -n /^-q= ubes-net:/p
[2022-09-19 19:50:56] + echo '-xen-domid
[2022-09-19 = 19:50:56] 62
[2022-09-19 19:50:56] -no-shutdown
[2022-09-19 19:50:56]= -nodefaults
[2022-09-19 19:50:56] -no-user-config
[2022-09-19 19:50:= 56] -name
[2022-09-19 19:50:56] openbsd-71
[2022-09-19 19:50:56] -dis= play
[2022-09-19 19:50:56] none
[2022-09-19 19:50:56] -device
[202= 2-09-19 19:50:56] VGA,vgamem_mb=3D16
[2022-09-19 19:50:56] -boot
[202= 2-09-19 19:50:56] order=3Ddc
[2022-09-19 19:50:56] -device
[2022-09-1= 9 19:50:56] usb-ehci,id=3Dehci
[2022-09-19 19:50:56] -device
[2022-09= -19 19:50:56] usb-tablet,bus=3Dehci.0
[2022-09-19 19:50:56] -smp
[202= 2-09-19 19:50:56] 2,maxcpus=3D2
[2022-09-19 19:50:56] -net
[2022-09-1= 9 19:50:56] none
[2022-09-19 19:50:56] -display
[2022-09-19 19:50:56]= qubes-gui,domid=3D0,log-level=3D0
[2022-09-19 19:50:56] -machine
[20= 22-09-19 19:50:56] xenfv
[2022-09-19 19:50:56] -m
[2022-09-19 19:50:5= 6] 496
[2022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev= /xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwritebac= k
[2022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdb= ,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
= [2022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdc,if= =3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'[2022-09-19 19:50:56] + net_args=3D
[2022-09-19 19:50:56] + sed /^-qub= es-net:/d
[2022-09-19 19:50:56] + echo '-xen-domid
[2022-09-19 19= :50:56] 62
[2022-09-19 19:50:56] -no-shutdown
[2022-09-19 19:50:56] -= nodefaults
[2022-09-19 19:50:56] -no-user-config
[2022-09-19 19:50:56= ] -name
[2022-09-19 19:50:56] openbsd-71
[2022-09-19 19:50:56] -displ= ay
[2022-09-19 19:50:56] none
[2022-09-19 19:50:56] -device
[2022-= 09-19 19:50:56] VGA,vgamem_mb=3D16
[2022-09-19 19:50:56] -boot
[2022-= 09-19 19:50:56] order=3Ddc
[2022-09-19 19:50:56] -device
[2022-09-19 = 19:50:56] usb-ehci,id=3Dehci
[2022-09-19 19:50:56] -device
[2022-09-1= 9 19:50:56] usb-tablet,bus=3Dehci.0
[2022-09-19 19:50:56] -smp
[2022-= 09-19 19:50:56] 2,maxcpus=3D2
[2022-09-19 19:50:56] -net
[2022-09-19 = 19:50:56] none
[2022-09-19 19:50:56] -display
[2022-09-19 19:50:56] q= ubes-gui,domid=3D0,log-level=3D0
[2022-09-19 19:50:56] -machine
[2022= -09-19 19:50:56] xenfv
[2022-09-19 19:50:56] -m
[2022-09-19 19:50:56]= 496
[2022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/x= vda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback<= br>[2022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdb,i= f=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2= 022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Di= de,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2= 022-09-19 19:50:56] + dm_args=3D'-xen-domid
[2022-09-19 19:50:56] 62=
[2022-09-19 19:50:56] -no-shutdown
[2022-09-19 19:50:56] -nodefaults=
[2022-09-19 19:50:56] -no-user-config
[2022-09-19 19:50:56] -name[2022-09-19 19:50:56] openbsd-71
[2022-09-19 19:50:56] -display
[202= 2-09-19 19:50:56] none
[2022-09-19 19:50:56] -device
[2022-09-19 19:5= 0:56] VGA,vgamem_mb=3D16
[2022-09-19 19:50:56] -boot
[2022-09-19 19:5= 0:56] order=3Ddc
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] = usb-ehci,id=3Dehci
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56= ] usb-tablet,bus=3Dehci.0
[2022-09-19 19:50:56] -smp
[2022-09-19 19:5= 0:56] 2,maxcpus=3D2
[2022-09-19 19:50:56] -net
[2022-09-19 19:50:56] = none
[2022-09-19 19:50:56] -display
[2022-09-19 19:50:56] qubes-gui,d= omid=3D0,log-level=3D0
[2022-09-19 19:50:56] -machine
[2022-09-19 19:= 50:56] xenfv
[2022-09-19 19:50:56] -m
[2022-09-19 19:50:56] 496
[2= 022-09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvda,if=3Di= de,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-0= 9-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,in= dex=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 = 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index= =3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-1= 9 19:50:56] + test -e /sys/class/net/eth0
[2022-09-19 19:50:56] + echo &= #39;No network interface named eth0.'
[2022-09-19 19:50:56] No netwo= rk interface named eth0.
[2022-09-19 19:50:56] + ls -l /sys/class/net/[2022-09-19 19:50:56] total 0
[2022-09-19 19:50:56] lrwxrwxrwx =C2=A0 = =C2=A01 root =C2=A0 =C2=A0 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A00 Sep 19 17:50 .[1;36mlo.[m -> .[1;34m../../devices/virtual/ne= t/lo.[m
[2022-09-19 19:50:56] + xenstore-read target
[2022-09-19 19:5= 0:56] + target=3D62
[2022-09-19 19:50:56] + device_model=3Ddevice-model/= 62
[2022-09-19 19:50:56] + mkdir /tmp/qmp
[2022-09-19 19:50:56] + ker= nel=3D
[2022-09-19 19:50:56] + grep -q ^-append
[2022-09-19 19:50:56]= + echo '-xen-domid
[2022-09-19 19:50:56] 62
[2022-09-19 19:50:56= ] -no-shutdown
[2022-09-19 19:50:56] -nodefaults
[2022-09-19 19:50:56= ] -no-user-config
[2022-09-19 19:50:56] -name
[2022-09-19 19:50:56] o= penbsd-71
[2022-09-19 19:50:56] -display
[2022-09-19 19:50:56] none[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] VGA,vgamem_mb=3D16=
[2022-09-19 19:50:56] -boot
[2022-09-19 19:50:56] order=3Ddc
[202= 2-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-ehci,id=3Dehci
[2= 022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-tablet,bus=3Dehci.= 0
[2022-09-19 19:50:56] -smp
[2022-09-19 19:50:56] 2,maxcpus=3D2
[= 2022-09-19 19:50:56] -net
[2022-09-19 19:50:56] none
[2022-09-19 19:5= 0:56] -display
[2022-09-19 19:50:56] qubes-gui,domid=3D0,log-level=3D0[2022-09-19 19:50:56] -machine
[2022-09-19 19:50:56] xenfv
[2022-09= -19 19:50:56] -m
[2022-09-19 19:50:56] 496
[2022-09-19 19:50:56] -dri= ve
[2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddis= k,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:50:56] -drive[2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,for= mat=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:50:56] -drive
[202= 2-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format= =3Dhost_device,cache=3Dwriteback'
[2022-09-19 19:50:56] + mkfifo /tm= p/qmp/qemu.in /tmp/qmp/qemu.out
[2022-09-= 19 19:50:56] + set +x
[2022-09-19 19:50:56] Clearing kmsg buffer...
[= 2022-09-19 19:50:56] + set +x
[2022-09-19 19:50:56] + set +x
[2022-09= -19 19:50:56] + sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/'
[20= 22-09-19 19:50:56] + echo '-xen-domid
[2022-09-19 19:50:56] 62
[2= 022-09-19 19:50:56] -no-shutdown
[2022-09-19 19:50:56] -nodefaults
[2= 022-09-19 19:50:56] -no-user-config
[2022-09-19 19:50:56] -name
[2022= -09-19 19:50:56] openbsd-71
[2022-09-19 19:50:56] -display
[2022-09-1= 9 19:50:56] none
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] = VGA,vgamem_mb=3D16
[2022-09-19 19:50:56] -boot
[2022-09-19 19:50:56] = order=3Ddc
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-eh= ci,id=3Dehci
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-= tablet,bus=3Dehci.0
[2022-09-19 19:50:56] -smp
[2022-09-19 19:50:56] = 2,maxcpus=3D2
[2022-09-19 19:50:56] -net
[2022-09-19 19:50:56] none[2022-09-19 19:50:56] -display
[2022-09-19 19:50:56] qubes-gui,domid= =3D0,log-level=3D0
[2022-09-19 19:50:56] -machine
[2022-09-19 19:50:5= 6] xenfv
[2022-09-19 19:50:56] -m
[2022-09-19 19:50:56] 496
[2022-= 09-19 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,i= ndex=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19= 19:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index= =3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:= 50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,= media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-19 19:= 50:56] + dm_args=3D'-xen-domid
[2022-09-19 19:50:56] 62
[2022-09-= 19 19:50:56] -no-shutdown
[2022-09-19 19:50:56] -nodefaults
[2022-09-= 19 19:50:56] -no-user-config
[2022-09-19 19:50:56] -name
[2022-09-19 = 19:50:56] openbsd-71
[2022-09-19 19:50:56] -display
[2022-09-19 19:50= :56] none
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] VGA,vga= mem_mb=3D16
[2022-09-19 19:50:56] -boot
[2022-09-19 19:50:56] order= =3Ddc
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-ehci,id= =3Dehci
[2022-09-19 19:50:56] -device
[2022-09-19 19:50:56] usb-table= t,bus=3Dehci.0
[2022-09-19 19:50:56] -smp
[2022-09-19 19:50:56] 2,max= cpus=3D2
[2022-09-19 19:50:56] -net
[2022-09-19 19:50:56] none
[20= 22-09-19 19:50:56] -display
[2022-09-19 19:50:56] qubes-gui,domid=3D0,lo= g-level=3D0
[2022-09-19 19:50:56] -machine
[2022-09-19 19:50:56] xenf= v
[2022-09-19 19:50:56] -m
[2022-09-19 19:50:56] 496
[2022-09-19 1= 9:50:56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvda,if=3Dide,index=3D= 0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:50:= 56] -drive
[2022-09-19 19:50:56] file=3D/dev/xvdb,if=3Dide,index=3D1,med= ia=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 19:50:56] -= drive
[2022-09-19 19:50:56] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3D= disk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-19 19:50:56] += xenstore-read device/console/2
[2022-09-19 19:50:56] + xenstore-read de= vice/console/1
[2022-09-19 19:50:57] + IFS=3D'
[2022-09-19 19:50:= 57] '
[2022-09-19 19:50:57] + set -f
[2022-09-19 19:50:57] + set = +f
[2022-09-19 19:50:57] + unset IFS
[2022-09-19 19:50:57] + qemu_pid= =3D171
[2022-09-19 19:50:57] + '[' '!' -e /tmp/qemu.qmp = ]
[2022-09-19 19:50:57] + sleep 0.1
[2022-09-19 19:50:57] + qemu -san= dbox 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny' -chardev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm' -mo= n 'chardev=3Dm,mode=3Dcontrol' -chardev 'socket,server,nowait,p= ath=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm2,mode=3Dcontrol'= -xen-domid 62 -no-shutdown -nodefaults -no-user-config -name openbsd-71 -d= isplay none -device 'VGA,vgamem_mb=3D16' -boot 'order=3Ddc'= -device 'usb-ehci,id=3Dehci' -device 'usb-tablet,bus=3Dehci.0&= #39; -smp '2,maxcpus=3D2' -net none -display 'qubes-gui,domid= =3D0,log-level=3D0' -machine xenfv -m 496 -drive 'file=3D/dev/xvda,= if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'= -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost= _device,cache=3Dwriteback' -drive 'file=3D/dev/xvdc,if=3Dide,index= =3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback' -device '= nec-usb-xhci,id=3Dxhci'
[2022-09-19 19:50:57] qemu: -chardev socket,= server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form boolean opt= ion 'server' deprecated
[2022-09-19 19:50:57] Please use server= =3Don instead
[2022-09-19 19:50:57] qemu: -chardev socket,server,nowait,= path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form boolean option 'nowai= t' deprecated
[2022-09-19 19:50:57] Please use wait=3Doff instead[2022-09-19 19:50:57] random: qemu: uninitialized urandom read (16 bytes r= ead)
[2022-09-19 19:50:57] + tee /proc/self/fd/2
[2022-09-19 19:50:57= ] + echo '{"execute": "qmp_capabilities"}'
[= 2022-09-19 19:50:57] {"QMP": {"version": {"qemu&qu= ot;: {"micro": 0, "minor": 1, "major": 6}, &q= uot;package": ""}, "capabilities": ["oob"= ;]}}

[2022-09-19 19:50:57] {"execute": "qmp_capabilit= ies"}
[2022-09-19 19:50:57] qubes_gui/init: 573
[2022-09-19 19:5= 0:57] qubes_gui/init: 582
[2022-09-19 19:50:57] qubes_gui/init: 584
[= 2022-09-19 19:50:57] qubes_gui/init[611]: version sent, waiting for xorg co= nf
[2022-09-19 19:50:57] {"return": {}}

[2022-09-19 19:= 50:57] + '[' '!' -e /tmp/qemu.qmp ]
[2022-09-19 19:50:57= ] + '[' -e /proc/self/fd/4 ]
[2022-09-19 19:50:57] + '['= -e /proc/self/fd/3 ]
[2022-09-19 19:50:57] + true
[2022-09-19 19:50:= 57] + printf '=3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D\n'[2022-09-19 19:50:57] =3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D
[= 2022-09-19 19:50:57] + read
[2022-09-19 19:50:57] + vchan-socket-proxy 0= device-model/62/qmp-vchan /tmp/qemu.qmp
[2022-09-19 19:50:57] written 1= 10 bytes to vchan
[2022-09-19 19:50:57] written 34 bytes to vchan
[20= 22-09-19 19:50:57] written 34 bytes to vchan
[2022-09-19 19:50:57] qubes= _gui/init[622]: got xorg conf, creating window
[2022-09-19 19:50:57] qub= es_gui/init: 632
[2022-09-19 19:50:57] random: crng init done
[2022-0= 9-19 19:50:57] configure msg, x/y 600 365 (was 0 0), w/h 720 400
[2022-0= 9-19 20:03:09] {"timestamp": {"seconds": 1663610590, &q= uot;microseconds": 147671}, "event": "RESET", &quo= t;data": {"guest": true, "reason": "guest-res= et"}}

[2022-09-19 20:03:09] {"timestamp": {"seco= nds": 1663610590, "microseconds": 148655}, "event"= : "RESET", "data": {"guest": true, "reas= on": "guest-reset"}}

[2022-09-19 20:25:36] Logfile Op= ened
[2022-09-19 20:25:36] Linux version 5.10.105-xen-stubdom (mockbuild= @0c9ad8f2058f40c49bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3= .1-1), GNU ld version 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022
[202= 2-09-19 20:25:36] Command line:
[2022-09-19 20:25:36] x86/fpu: Supporti= ng XSAVE feature 0x001: 'x87 floating point registers'
[2022-09-= 19 20:25:36] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers= 9;
[2022-09-19 20:25:36] x86/fpu: Supporting XSAVE feature 0x004: 'A= VX registers'
[2022-09-19 20:25:36] x86/fpu: xstate_offset[2]: =C2= =A0576, xstate_sizes[2]: =C2=A0256
[2022-09-19 20:25:36] x86/fpu: Enable= d xstate features 0x7, context size is 832 bytes, using 'standard' = format.
[2022-09-19 20:25:36] Released 0 page(s)
[2022-09-19 20:25:36= ] BIOS-provided physical RAM map:
[2022-09-19 20:25:36] Xen: [mem 0x0000= 000000000000-0x000000000009ffff] usable
[2022-09-19 20:25:36] Xen: [mem = 0x00000000000a0000-0x00000000000fffff] reserved
[2022-09-19 20:25:36] Xe= n: [mem 0x0000000000100000-0x0000000008ffffff] usable
[2022-09-19 20:25:= 36] NX (Execute Disable) protection: active
[2022-09-19 20:25:36] Hyperv= isor detected: Xen PV
[2022-09-19 20:25:36] tsc: Fast TSC calibration fa= iled
[2022-09-19 20:25:36] tsc: Detected 2591.998 MHz processor
[2022= -09-19 20:25:36] last_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000
[2022-= 09-19 20:25:36] x86/PAT: Configuration [0-7]: WB =C2=A0WT =C2=A0UC- UC =C2= =A0WC =C2=A0WP =C2=A0UC =C2=A0UC =C2=A0
[2022-09-19 20:25:36] RAMDISK: [= mem 0x02000000-0x03f7afff]
[2022-09-19 20:25:36] Zone ranges:
[2022-0= 9-19 20:25:36] =C2=A0 DMA32 =C2=A0 =C2=A0[mem 0x0000000000001000-0x00000000= 08ffffff]
[2022-09-19 20:25:36] =C2=A0 Normal =C2=A0 empty
[2022-09-1= 9 20:25:36] Movable zone start for each node
[2022-09-19 20:25:36] Early= memory node ranges
[2022-09-19 20:25:36] =C2=A0 node =C2=A0 0: [mem 0x0= 000000000001000-0x000000000009ffff]
[2022-09-19 20:25:36] =C2=A0 node = =C2=A0 0: [mem 0x0000000000100000-0x0000000008ffffff]
[2022-09-19 20:25:= 36] Initmem setup node 0 [mem 0x0000000000001000-0x0000000008ffffff]
[20= 22-09-19 20:25:36] On node 0, zone DMA32: 1 pages in unavailable ranges
= [2022-09-19 20:25:36] On node 0, zone DMA32: 96 pages in unavailable ranges=
[2022-09-19 20:25:36] On node 0, zone DMA32: 28672 pages in unavailable= ranges
[2022-09-19 20:25:36] p2m virtual area at (____ptrval____), size= is 200000
[2022-09-19 20:25:36] Remapped 0 page(s)
[2022-09-19 20:25= :36] [mem 0x09000000-0xffffffff] available for PCI devices
[2022-09-19 2= 0:25:36] Booting paravirtualized kernel on Xen
[2022-09-19 20:25:36] Xen= version: 4.14.5 (preserve-AD)
[2022-09-19 20:25:36] clocksource: refine= d-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600= 211568 ns
[2022-09-19 20:25:36] Built 1 zonelists, mobility grouping on.= =C2=A0 Total pages: 36170
[2022-09-19 20:25:36] Kernel command line: clo= cksource=3Dtsc
[2022-09-19 20:25:36] Dentry cache hash table entries: 3= 2768 (order: 6, 262144 bytes, linear)
[2022-09-19 20:25:36] Inode-cache = hash table entries: 16384 (order: 5, 131072 bytes, linear)
[2022-09-19 2= 0:25:36] mem auto-init: stack:byref_all(zero), heap alloc:off, heap free:of= f
[2022-09-19 20:25:36] Memory: 96968K/147068K available (6145K kernel c= ode, 842K rwdata, 428K rodata, 696K init, 476K bss, 49848K reserved, 0K cma= -reserved)
[2022-09-19 20:25:36] random: get_random_u64 called from 0xff= ffffff810a0f18 with crng_init=3D0
[2022-09-19 20:25:36] SLUB: HWalign=3D= 64, Order=3D0-3, MinObjects=3D0, CPUs=3D1, Nodes=3D1
[2022-09-19 20:25:3= 6] Using NULL legacy PIC
[2022-09-19 20:25:36] NR_IRQS: 4352, nr_irqs: 2= 4, preallocated irqs: 0
[2022-09-19 20:25:36] xen:events: Using FIFO-bas= ed ABI
[2022-09-19 20:25:36] printk: console [hvc0] enabled
[2022-09-= 19 20:25:36] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42= e4dffb, max_idle_ns: 881590591483 ns
[2022-09-19 20:25:36] installing Xe= n timer for CPU 0
[2022-09-19 20:25:36] clocksource: tsc-early: mask: 0x= ffffffffffffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns[2022-09-19 20:25:36] Calibrating delay loop (skipped), value calculated u= sing timer frequency.. 5183.99 BogoMIPS (lpj=3D10367992)
[2022-09-19 20:= 25:36] pid_max: default: 4096 minimum: 301
[2022-09-19 20:25:36] Mount-c= ache hash table entries: 512 (order: 0, 4096 bytes, linear)
[2022-09-19 = 20:25:36] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes, l= inear)
[2022-09-19 20:25:36] Last level iTLB entries: 4KB 64, 2MB 8, 4MB= 8
[2022-09-19 20:25:36] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, = 1GB 4
[2022-09-19 20:25:36] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GH= z (family: 0x6, model: 0x9e, stepping: 0xa)
[2022-09-19 20:25:36] Spectr= e V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization=
[2022-09-19 20:25:36] Spectre V2 : Mitigation: Retpolines
[2022-09-1= 9 20:25:36] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on= context switch
[2022-09-19 20:25:36] Spectre V2 : Enabling Restricted S= peculation for firmware calls
[2022-09-19 20:25:36] Spectre V2 : mitigat= ion: Enabling conditional Indirect Branch Prediction Barrier
[2022-09-19= 20:25:36] Speculative Store Bypass: Mitigation: Speculative Store Bypass d= isabled via prctl and seccomp
[2022-09-19 20:25:36] SRBDS: Unknown: Depe= ndent on hypervisor status
[2022-09-19 20:25:36] MDS: Mitigation: Clear = CPU buffers
[2022-09-19 20:25:36] Performance Events: unsupported p6 CPU= model 158 no PMU driver, software events only.
[2022-09-19 20:25:36] de= vtmpfs: initialized
[2022-09-19 20:25:36] clocksource: jiffies: mask: 0x= ffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns
[2022-= 09-19 20:25:36] futex hash table entries: 16 (order: -4, 384 bytes, linear)=
[2022-09-19 20:25:36] NET: Registered protocol family 16
[2022-09-19= 20:25:36] xen:grant_table: Grant tables using version 1 layout
[2022-09= -19 20:25:36] Grant table initialized
[2022-09-19 20:25:36] PCI: setting= up Xen PCI frontend stub
[2022-09-19 20:25:36] xen:balloon: Initialisin= g balloon driver
[2022-09-19 20:25:36] usbcore: registered new interface= driver usbfs
[2022-09-19 20:25:36] usbcore: registered new interface dr= iver hub
[2022-09-19 20:25:36] usbcore: registered new device driver usb=
[2022-09-19 20:25:36] PCI: System does not support PCI
[2022-09-19 2= 0:25:36] clocksource: Switched to clocksource xen
[2022-09-19 20:25:36] = NET: Registered protocol family 2
[2022-09-19 20:25:36] IP idents hash t= able entries: 4096 (order: 3, 32768 bytes, linear)
[2022-09-19 20:25:36]= tcp_listen_portaddr_hash hash table entries: 256 (order: 0, 4096 bytes, li= near)
[2022-09-19 20:25:36] TCP established hash table entries: 2048 (or= der: 2, 16384 bytes, linear)
[2022-09-19 20:25:36] TCP bind hash table e= ntries: 2048 (order: 2, 16384 bytes, linear)
[2022-09-19 20:25:36] TCP: = Hash tables configured (established 2048 bind 2048)
[2022-09-19 20:25:36= ] UDP hash table entries: 128 (order: 0, 4096 bytes, linear)
[2022-09-19= 20:25:36] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes, linear)<= br>[2022-09-19 20:25:36] NET: Registered protocol family 1
[2022-09-19 2= 0:25:36] Unpacking initramfs...
[2022-09-19 20:25:36] Freeing initrd mem= ory: 32236K
[2022-09-19 20:25:36] clocksource: tsc: mask: 0xffffffffffff= ffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns
[2022-09-19= 20:25:36] clocksource: Switched to clocksource tsc
[2022-09-19 20:25:36= ] workingset: timestamp_bits=3D62 max_order=3D15 bucket_order=3D0
[2022-= 09-19 20:25:36] xen:xen_evtchn: Event-channel device installed
[2022-09-= 19 20:25:36] Invalid max_queues (4), will use default max: 1.
[2022-09-1= 9 20:25:36] tun: Universal TUN/TAP device driver, 1.6
[2022-09-19 20:25:= 36] xen_netfront: Initialising Xen virtual ethernet driver
[2022-09-19 2= 0:25:36] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller
[2022-09-19= 20:25:36] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number= 1
[2022-09-19 20:25:36] vhci_hcd: created sysfs vhci_hcd.0
[2022-09-= 19 20:25:36] hub 1-0:1.0: USB hub found
[2022-09-19 20:25:36] hub 1-0:1.= 0: 8 ports detected
[2022-09-19 20:25:36] vhci_hcd vhci_hcd.0: USB/IP Vi= rtual Host Controller
[2022-09-19 20:25:36] vhci_hcd vhci_hcd.0: new USB= bus registered, assigned bus number 2
[2022-09-19 20:25:36] usb usb2: W= e don't know the algorithms for LPM for this host, disabling LPM.
[2= 022-09-19 20:25:36] hub 2-0:1.0: USB hub found
[2022-09-19 20:25:36] hub= 2-0:1.0: 8 ports detected
[2022-09-19 20:25:36] NET: Registered protoco= l family 17
[2022-09-19 20:25:36] sched_clock: Marking stable (269302379= , 234771)->(271578343, -2041193)
[2022-09-19 20:25:36] random: fast i= nit done
[2022-09-19 20:25:36] pcifront pci-0: Installing PCI frontend[2022-09-19 20:25:36] xen:swiotlb_xen: Warning: only able to allocate 4 M= B for software IO TLB
[2022-09-19 20:25:36] software IO TLB: mapped [mem= 0x0000000003800000-0x0000000003c00000] (4MB)
[2022-09-19 20:25:36] pcif= ront pci-0: Creating PCI Frontend Bus 0000:00
[2022-09-19 20:25:36] pcif= ront pci-0: PCI host bridge to bus 0000:00
[2022-09-19 20:25:36] pci_bus= 0000:00: root bus resource [io =C2=A00x0000-0xffff]
[2022-09-19 20:25:3= 6] pci_bus 0000:00: root bus resource [mem 0x00000000-0x7fffffffff]
[202= 2-09-19 20:25:36] pci_bus 0000:00: root bus resource [bus 00-ff]
[2022-0= 9-19 20:25:36] pci 0000:00:00.0: [10ec:8168] type 00 class 0x020000
[202= 2-09-19 20:25:36] pci 0000:00:00.0: reg 0x10: [io =C2=A00x3000-0x30ff]
[= 2022-09-19 20:25:36] pci 0000:00:00.0: reg 0x18: [mem 0xb4304000-0xb4304fff= 64bit]
[2022-09-19 20:25:36] pci 0000:00:00.0: reg 0x20: [mem 0xb430000= 0-0xb4303fff 64bit]
[2022-09-19 20:25:36] pci 0000:00:00.0: supports D1 = D2
[2022-09-19 20:25:36] pcifront pci-0: claiming resource 0000:00:00.0/= 0
[2022-09-19 20:25:36] pcifront pci-0: claiming resource 0000:00:00.0/2=
[2022-09-19 20:25:36] pcifront pci-0: claiming resource 0000:00:00.0/4<= br>[2022-09-19 20:25:36] blkfront: xvda: flush diskcache: enabled; persiste= nt grants: enabled; indirect descriptors: enabled;
[2022-09-19 20:25:36]= =C2=A0xvda: xvda4
[2022-09-19 20:25:36] blkfront: xvdb: flush diskcache= : enabled; persistent grants: enabled; indirect descriptors: enabled;
[2= 022-09-19 20:25:36] blkfront: xvdc: flush diskcache: enabled; persistent gr= ants: enabled; indirect descriptors: enabled;
[2022-09-19 20:25:36] Free= ing unused kernel image (initmem) memory: 696K
[2022-09-19 20:25:36] Wri= te protecting the kernel read-only data: 10240k
[2022-09-19 20:25:36] Fr= eeing unused kernel image (text/rodata gap) memory: 2044K
[2022-09-19 20= :25:36] Freeing unused kernel image (rodata/data gap) memory: 1620K
[202= 2-09-19 20:25:36] Run /init as init process
[2022-09-19 20:25:36] + moun= t -t devtmpfs none /dev
[2022-09-19 20:25:36] + mount -t sysfs /sys /sys=
[2022-09-19 20:25:36] + mount -t proc /proc /proc
[2022-09-19 20:25:= 36] + mount -t tmpfs -o 'size=3D1m,nodev,noexec' /tmp /tmp
[2022= -09-19 20:25:36] + mount -o remount,ro /
[2022-09-19 20:25:36] + echo 1<= br>[2022-09-19 20:25:36] + printf '%d\n' 1073741824
[2022-09-19 = 20:25:36] + /bin/xenstore-read target
[2022-09-19 20:25:36] + domid=3D12=
[2022-09-19 20:25:36] + xenstore-read /local/domain/12/vm
[2022-09-1= 9 20:25:36] + vm_path=3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3
[2022-0= 9-19 20:25:36] + sort
[2022-09-19 20:25:36] + xenstore-list -p /vm/53ce9= bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv
[2022-09-19 20:25:36] + xe= nstore-read /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/= 53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-45= 87-9b52-dcccd76169b3/image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd761= 69b3/image/dm-argv/004 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-ar= gv/005 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9= bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b= 52-dcccd76169b3/image/dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/= image/dm-argv/009 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/01= 0 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8= c06-4587-9b52-dcccd76169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dc= ccd76169b3/image/dm-argv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image= /dm-argv/014 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm= /53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4= 587-9b52-dcccd76169b3/image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76= 169b3/image/dm-argv/018 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-a= rgv/019 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce= 9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9= b52-dcccd76169b3/image/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3= /image/dm-argv/023 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/0= 24 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-= 8c06-4587-9b52-dcccd76169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-d= cccd76169b3/image/dm-argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/imag= e/dm-argv/028 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /v= m/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-= 4587-9b52-dcccd76169b3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd7= 6169b3/image/dm-argv/032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-= argv/033
[2022-09-19 20:25:36] + dm_args=3D'-xen-domid
[2022-09-1= 9 20:25:36] 12
[2022-09-19 20:25:36] -no-shutdown
[2022-09-19 20:25:3= 6] -nodefaults
[2022-09-19 20:25:36] -no-user-config
[2022-09-19 20:2= 5:36] -name
[2022-09-19 20:25:36] openbsd-71
[2022-09-19 20:25:36] -d= isplay
[2022-09-19 20:25:36] none
[2022-09-19 20:25:36] -device
[2= 022-09-19 20:25:36] VGA,vgamem_mb=3D16
[2022-09-19 20:25:36] -boot
[2= 022-09-19 20:25:36] order=3Ddc
[2022-09-19 20:25:36] -device
[2022-09= -19 20:25:36] usb-ehci,id=3Dehci
[2022-09-19 20:25:36] -device
[2022-= 09-19 20:25:36] usb-tablet,bus=3Dehci.0
[2022-09-19 20:25:36] -smp
[2= 022-09-19 20:25:36] 2,maxcpus=3D2
[2022-09-19 20:25:36] -net
[2022-09= -19 20:25:36] none
[2022-09-19 20:25:36] -display
[2022-09-19 20:25:3= 6] qubes-gui,domid=3D0,log-level=3D0
[2022-09-19 20:25:36] -machine
[= 2022-09-19 20:25:36] xenfv
[2022-09-19 20:25:36] -m
[2022-09-19 20:25= :36] 496
[2022-09-19 20:25:36] -drive
[2022-09-19 20:25:36] file=3D/d= ev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteb= ack
[2022-09-19 20:25:36] -drive
[2022-09-19 20:25:36] file=3D/dev/xv= db,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback[2022-09-19 20:25:36] -drive
[2022-09-19 20:25:36] file=3D/dev/xvdc,if= =3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'[2022-09-19 20:25:36] + usb_args=3D
[2022-09-19 20:25:36] + test -e /b= in/qrexec-agent
[2022-09-19 20:25:36] + usb_args=3D'-device
[2022= -09-19 20:25:36] nec-usb-xhci,id=3Dxhci'
[2022-09-19 20:25:36] + mkd= ir -p /var/run/qubes
[2022-09-19 20:25:36] + touch /dev/mdev.log
[202= 2-09-19 20:25:36] + USER=3Droot qrexec-agent
[2022-09-19 20:25:36] + mde= v -d
[2022-09-19 20:25:36] + sed -n '/^-soundhw/ {n;p}'
[2022= -09-19 20:25:36] + echo '-xen-domid
[2022-09-19 20:25:36] 12
[202= 2-09-19 20:25:36] -no-shutdown
[2022-09-19 20:25:36] -nodefaults
[202= 2-09-19 20:25:36] -no-user-config
[2022-09-19 20:25:36] -name
[2022-0= 9-19 20:25:36] openbsd-71
[2022-09-19 20:25:36] -display
[2022-09-19 = 20:25:36] none
[2022-09-19 20:25:36] -device
[2022-09-19 20:25:36] VG= A,vgamem_mb=3D16
[2022-09-19 20:25:36] -boot
[2022-09-19 20:25:36] or= der=3Ddc
[2022-09-19 20:25:36] -device
[2022-09-19 20:25:36] usb-ehci= ,id=3Dehci
[2022-09-19 20:25:36] -device
[2022-09-19 20:25:36] usb-ta= blet,bus=3Dehci.0
[2022-09-19 20:25:36] -smp
[2022-09-19 20:25:36] 2,= maxcpus=3D2
[2022-09-19 20:25:36] -net
[2022-09-19 20:25:36] none
= [2022-09-19 20:25:36] -display
[2022-09-19 20:25:36] qubes-gui,domid=3D0= ,log-level=3D0
[2022-09-19 20:25:36] -machine
[2022-09-19 20:25:36] x= enfv
[2022-09-19 20:25:36] -m
[2022-09-19 20:25:36] 496
[2022-09-1= 9 20:25:36] -drive
[2022-09-19 20:25:36] file=3D/dev/xvda,if=3Dide,index= =3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 20:= 25:36] -drive
[2022-09-19 20:25:36] file=3D/dev/xvdb,if=3Dide,index=3D1,= media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-19 20:25:36= ] -drive
[2022-09-19 20:25:36] file=3D/dev/xvdc,if=3Dide,index=3D2,media= =3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-19 20:25:36= ] + audio_model=3D
[2022-09-19 20:25:36] + '[' -n =C2=A0]
[20= 22-09-19 20:25:36] + sed -n /^-qubes-net:/p
[2022-09-19 20:25:36] + echo= '-xen-domid
[2022-09-19 20:25:36] 12
[2022-09-19 20:25:36] -no-s= hutdown
[2022-09-19 20:25:36] -nodefaults
[2022-09-19 20:25:36] -no-u= ser-config
[2022-09-19 20:25:36] -name
[2022-09-19 20:25:36] openbsd-= 71
[2022-09-19 20:25:36] -display
[2022-09-19 20:25:36] none
[2022= -09-19 20:25:36] -device
[2022-09-19 20:25:36] VGA,vgamem_mb=3D16
[20= 22-09-19 20:25:36] -boot
[2022-09-19 20:25:36] order=3Ddc
[2022-09-19= 20:25:36] -device
[2022-09-19 20:25:36] usb-ehci,id=3Dehci
[2022-09-= 19 20:25:36] -device
[2022-09-19 20:25:36] usb-tablet,bus=3Dehci.0
[2= 022-09-19 20:25:36] -smp
[2022-09-19 20:25:36] 2,maxcpus=3D2
[2022-09= -19 20:25:36] -net
[2022-09-19 20:25:36] none
[2022-09-19 20:25:36] -= display
[2022-09-19 20:25:36] qubes-gui,domid=3D0,log-level=3D0
[2022= -09-19 20:25:36] -machine
[2022-09-19 20:25:36] xenfv
[2022-09-19 20:= 25:36] -m
[2022-09-19 20:25:36] 496
[2022-09-19 20:25:36] -drive
[= 2022-09-19 20:25:36] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,forma= t=3Dhost_device,cache=3Dwriteback
[2022-09-19 20:25:36] -drive
[2022-= 09-19 20:25:36] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dh= ost_device,cache=3Dwriteback
[2022-09-19 20:25:36] -drive
[2022-09-19= 20:25:36] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_d= evice,cache=3Dwriteback'
[2022-09-19 20:25:36] + net_args=3D
[202= 2-09-19 20:25:36] + sed /^-qubes-net:/d
[2022-09-19 20:25:36] + echo = 9;-xen-domid
[2022-09-19 20:25:36] 12
[2022-09-19 20:25:36] -no-shutd= own
[2022-09-19 20:25:36] -nodefaults
[2022-09-19 20:25:36] -no-user-= config
[2022-09-19 20:25:36] -name
[2022-09-19 20:25:36] openbsd-71[2022-09-19 20:25:36] -display
[2022-09-19 20:25:36] none
[2022-09-= 19 20:25:36] -device
[2022-09-19 20:25:36] VGA,vgamem_mb=3D16
[2022-0= 9-19 20:25:36] -boot
[2022-09-19 20:25:36] order=3Ddc
[2022-09-19 20:= 25:36] -device
[2022-09-19 20:25:36] usb-ehci,id=3Dehci
[2022-09-19 2= 0:25:36] -device
[2022-09-19 20:25:36] usb-tablet,bus=3Dehci.0
[2022-= 09-19 20:25:36] -smp
[2022-09-19 20:25:36] 2,maxcpus=3D2
[2022-09-19 = 20:25:36] -net
[2022-09-19 20:25:36] none
[2022-09-19 20:25:36] -disp= lay
[2022-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0
[2022-09-= 19 20:25:37] -machine
[2022-09-19 20:25:37] xenfv
[2022-09-19 20:25:3= 7] -m
[2022-09-19 20:25:37] 496
[2022-09-19 20:25:37] -drive
[2022= -09-19 20:25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3D= host_device,cache=3Dwriteback
[2022-09-19 20:25:37] -drive
[2022-09-1= 9 20:25:37] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_= device,cache=3Dwriteback
[2022-09-19 20:25:37] -drive
[2022-09-19 20:= 25:37] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_devic= e,cache=3Dwriteback'
[2022-09-19 20:25:37] + dm_args=3D'-xen-dom= id
[2022-09-19 20:25:37] 12
[2022-09-19 20:25:37] -no-shutdown
[20= 22-09-19 20:25:37] -nodefaults
[2022-09-19 20:25:37] -no-user-config
= [2022-09-19 20:25:37] -name
[2022-09-19 20:25:37] openbsd-71
[2022-09= -19 20:25:37] -display
[2022-09-19 20:25:37] none
[2022-09-19 20:25:3= 7] -device
[2022-09-19 20:25:37] VGA,vgamem_mb=3D16
[2022-09-19 20:25= :37] -boot
[2022-09-19 20:25:37] order=3Ddc
[2022-09-19 20:25:37] -de= vice
[2022-09-19 20:25:37] usb-ehci,id=3Dehci
[2022-09-19 20:25:37] -= device
[2022-09-19 20:25:37] usb-tablet,bus=3Dehci.0
[2022-09-19 20:2= 5:37] -smp
[2022-09-19 20:25:37] 2,maxcpus=3D2
[2022-09-19 20:25:37] = -net
[2022-09-19 20:25:37] none
[2022-09-19 20:25:37] -display
[20= 22-09-19 20:25:37] qubes-gui,domid=3D0,log-level=3D0
[2022-09-19 20:25:3= 7] -machine
[2022-09-19 20:25:37] xenfv
[2022-09-19 20:25:37] -m
[= 2022-09-19 20:25:37] 496
[2022-09-19 20:25:37] -drive
[2022-09-19 20:= 25:37] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_devic= e,cache=3Dwriteback
[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37= ] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cac= he=3Dwriteback
[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] fil= e=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3D= writeback'
[2022-09-19 20:25:37] + test -e /sys/class/net/eth0
[2= 022-09-19 20:25:37] + echo 'No network interface named eth0.'
[2= 022-09-19 20:25:37] No network interface named eth0.
[2022-09-19 20:25:3= 7] + ls -l /sys/class/net/
[2022-09-19 20:25:37] total 0
[2022-09-19 = 20:25:37] lrwxrwxrwx =C2=A0 =C2=A01 root =C2=A0 =C2=A0 0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00 Sep 19 18:25 .[1;36mlo.[m -> .[1= ;34m../../devices/virtual/net/lo.[m
[2022-09-19 20:25:37] + xenstore-rea= d target
[2022-09-19 20:25:37] + target=3D12
[2022-09-19 20:25:37] + = device_model=3Ddevice-model/12
[2022-09-19 20:25:37] + mkdir /tmp/qmp[2022-09-19 20:25:37] + kernel=3D
[2022-09-19 20:25:37] + grep -q ^-app= end
[2022-09-19 20:25:37] + echo '-xen-domid
[2022-09-19 20:25:37= ] 12
[2022-09-19 20:25:37] -no-shutdown
[2022-09-19 20:25:37] -nodefa= ults
[2022-09-19 20:25:37] -no-user-config
[2022-09-19 20:25:37] -nam= e
[2022-09-19 20:25:37] openbsd-71
[2022-09-19 20:25:37] -display
= [2022-09-19 20:25:37] none
[2022-09-19 20:25:37] -device
[2022-09-19 = 20:25:37] VGA,vgamem_mb=3D16
[2022-09-19 20:25:37] -boot
[2022-09-19 = 20:25:37] order=3Ddc
[2022-09-19 20:25:37] -device
[2022-09-19 20:25:= 37] usb-ehci,id=3Dehci
[2022-09-19 20:25:37] -device
[2022-09-19 20:2= 5:37] usb-tablet,bus=3Dehci.0
[2022-09-19 20:25:37] -smp
[2022-09-19 = 20:25:37] 2,maxcpus=3D2
[2022-09-19 20:25:37] -net
[2022-09-19 20:25:= 37] none
[2022-09-19 20:25:37] -display
[2022-09-19 20:25:37] qubes-g= ui,domid=3D0,log-level=3D0
[2022-09-19 20:25:37] -machine
[2022-09-19= 20:25:37] xenfv
[2022-09-19 20:25:37] -m
[2022-09-19 20:25:37] 496[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/xvda,if= =3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[20= 22-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/xvdb,if=3Did= e,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09= -19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Dide,ind= ex=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09= -19 20:25:37] + mkfifo /tmp/qmp/qemu.in /tmp= /qmp/qemu.out
[2022-09-19 20:25:37] + set +x
[2022-09-19 20:25:37] Cl= earing kmsg buffer...
[2022-09-19 20:25:37] + set +x
[2022-09-19 20:2= 5:37] + set +x
[2022-09-19 20:25:37] + sed 's/\$STUBDOM_RESTORE_INCO= MING_ARG/fd:3/'
[2022-09-19 20:25:37] + echo '-xen-domid
[202= 2-09-19 20:25:37] 12
[2022-09-19 20:25:37] -no-shutdown
[2022-09-19 2= 0:25:37] -nodefaults
[2022-09-19 20:25:37] -no-user-config
[2022-09-1= 9 20:25:37] -name
[2022-09-19 20:25:37] openbsd-71
[2022-09-19 20:25:= 37] -display
[2022-09-19 20:25:37] none
[2022-09-19 20:25:37] -device=
[2022-09-19 20:25:37] VGA,vgamem_mb=3D16
[2022-09-19 20:25:37] -boot=
[2022-09-19 20:25:37] order=3Ddc
[2022-09-19 20:25:37] -device
[2= 022-09-19 20:25:37] usb-ehci,id=3Dehci
[2022-09-19 20:25:37] -device
= [2022-09-19 20:25:37] usb-tablet,bus=3Dehci.0
[2022-09-19 20:25:37] -smp=
[2022-09-19 20:25:37] 2,maxcpus=3D2
[2022-09-19 20:25:37] -net
[2= 022-09-19 20:25:37] none
[2022-09-19 20:25:37] -display
[2022-09-19 2= 0:25:37] qubes-gui,domid=3D0,log-level=3D0
[2022-09-19 20:25:37] -machin= e
[2022-09-19 20:25:37] xenfv
[2022-09-19 20:25:37] -m
[2022-09-19= 20:25:37] 496
[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] fil= e=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3D= writeback
[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/= dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwrite= back
[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/x= vdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback&= #39;
[2022-09-19 20:25:37] + dm_args=3D'-xen-domid
[2022-09-19 20= :25:37] 12
[2022-09-19 20:25:37] -no-shutdown
[2022-09-19 20:25:37] -= nodefaults
[2022-09-19 20:25:37] -no-user-config
[2022-09-19 20:25:37= ] -name
[2022-09-19 20:25:37] openbsd-71
[2022-09-19 20:25:37] -displ= ay
[2022-09-19 20:25:37] none
[2022-09-19 20:25:37] -device
[2022-= 09-19 20:25:37] VGA,vgamem_mb=3D16
[2022-09-19 20:25:37] -boot
[2022-= 09-19 20:25:37] order=3Ddc
[2022-09-19 20:25:37] -device
[2022-09-19 = 20:25:37] usb-ehci,id=3Dehci
[2022-09-19 20:25:37] -device
[2022-09-1= 9 20:25:37] usb-tablet,bus=3Dehci.0
[2022-09-19 20:25:37] -smp
[2022-= 09-19 20:25:37] 2,maxcpus=3D2
[2022-09-19 20:25:37] -net
[2022-09-19 = 20:25:37] none
[2022-09-19 20:25:37] -display
[2022-09-19 20:25:37] q= ubes-gui,domid=3D0,log-level=3D0
[2022-09-19 20:25:37] -machine
[2022= -09-19 20:25:37] xenfv
[2022-09-19 20:25:37] -m
[2022-09-19 20:25:37]= 496
[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/x= vda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback<= br>[2022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/xvdb,i= f=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2= 022-09-19 20:25:37] -drive
[2022-09-19 20:25:37] file=3D/dev/xvdc,if=3Di= de,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2= 022-09-19 20:25:37] + xenstore-read device/console/2
[2022-09-19 20:25:3= 7] + xenstore-read device/console/1
[2022-09-19 20:25:37] + IFS=3D'<= br>[2022-09-19 20:25:37] '
[2022-09-19 20:25:37] + set -f
[2022-0= 9-19 20:25:37] + set +f
[2022-09-19 20:25:37] + unset IFS
[2022-09-19= 20:25:37] + qemu_pid=3D130
[2022-09-19 20:25:37] + '[' '!&#= 39; -e /tmp/qemu.qmp ]
[2022-09-19 20:25:37] + sleep 0.1
[2022-09-19 = 20:25:37] + qemu -sandbox 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,= spawn=3Ddeny,resourcecontrol=3Ddeny' -chardev 'pipe,path=3D/tmp/qmp= /qemu,id=3Dm' -mon 'chardev=3Dm,mode=3Dcontrol' -chardev 's= ocket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm= 2,mode=3Dcontrol' -xen-domid 12 -no-shutdown -nodefaults -no-user-confi= g -name openbsd-71 -display none -device 'VGA,vgamem_mb=3D16' -boot= 'order=3Ddc' -device 'usb-ehci,id=3Dehci' -device 'usb= -tablet,bus=3Dehci.0' -smp '2,maxcpus=3D2' -net none -display &= #39;qubes-gui,domid=3D0,log-level=3D0' -machine xenfv -m 496 -drive = 9;file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cac= he=3Dwriteback' -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media= =3Ddisk,format=3Dhost_device,cache=3Dwriteback' -drive 'file=3D/dev= /xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwritebac= k' -device 'nec-usb-xhci,id=3Dxhci'
[2022-09-19 20:25:37] qe= mu: -chardev socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: sh= ort-form boolean option 'server' deprecated
[2022-09-19 20:25:37= ] Please use server=3Don instead
[2022-09-19 20:25:37] qemu: -chardev so= cket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form boolea= n option 'nowait' deprecated
[2022-09-19 20:25:37] Please use wa= it=3Doff instead
[2022-09-19 20:25:37] + tee /proc/self/fd/2
[2022-09= -19 20:25:37] + echo '{"execute": "qmp_capabilities"= ;}'
[2022-09-19 20:25:37] random: qemu: uninitialized urandom read (= 16 bytes read)
[2022-09-19 20:25:37] {"execute": "qmp_cap= abilities"}
[2022-09-19 20:25:37] {"QMP": {"version&= quot;: {"qemu": {"micro": 0, "minor": 1, &quo= t;major": 6}, "package": ""}, "capabilities&q= uot;: ["oob"]}}

[2022-09-19 20:25:37] qubes_gui/init: 573<= br>[2022-09-19 20:25:37] qubes_gui/init: 582
[2022-09-19 20:25:37] qubes= _gui/init: 584
[2022-09-19 20:25:37] qubes_gui/init[611]: version sent, = waiting for xorg conf
[2022-09-19 20:25:37] {"return": {}}
=
[2022-09-19 20:25:37] + '[' '!' -e /tmp/qemu.qmp ]
[= 2022-09-19 20:25:37] + '[' -e /proc/self/fd/4 ]
[2022-09-19 20:2= 5:37] + '[' -e /proc/self/fd/3 ]
[2022-09-19 20:25:37] + true[2022-09-19 20:25:37] + printf '=3D=3D=3D=3D Press enter for shell =3D= =3D=3D=3D\n'
[2022-09-19 20:25:37] =3D=3D=3D=3D Press enter for shel= l =3D=3D=3D=3D
[2022-09-19 20:25:37] + read
[2022-09-19 20:25:37] + v= chan-socket-proxy 0 device-model/12/qmp-vchan /tmp/qemu.qmp
[2022-09-19 = 20:25:37] written 110 bytes to vchan
[2022-09-19 20:25:37] written 34 by= tes to vchan
[2022-09-19 20:25:37] [00:06.0] xen_pt_realize: Assigning r= eal physical device 07:00.0 to devfn 0x30
[2022-09-19 20:25:37] [00:06.0= ] xen_pt_register_regions: IO region 0 registered (size=3D0x00000100 base_a= ddr=3D0x00003000 type: 0x1)
[2022-09-19 20:25:37] [00:06.0] xen_pt_regis= ter_regions: IO region 2 registered (size=3D0x00001000 base_addr=3D0xb43040= 00 type: 0x4)
[2022-09-19 20:25:37] [00:06.0] xen_pt_register_regions: I= O region 4 registered (size=3D0x00004000 base_addr=3D0xb4300000 type: 0x4)<= br>[2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x000e mi= smatch! Emulated=3D0x0080, host=3D0x0000, syncing to 0x0000.
[2022-09-19= 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0010 mismatch! Emulat= ed=3D0x0000, host=3D0x3001, syncing to 0x3001.
[2022-09-19 20:25:37] [00= :06.0] xen_pt_config_reg_init: Offset 0x0018 mismatch! Emulated=3D0x0000, h= ost=3D0xb4304004, syncing to 0xb4304004.
[2022-09-19 20:25:37] [00:06.0]= xen_pt_config_reg_init: Offset 0x0020 mismatch! Emulated=3D0x0000, host=3D= 0xb4300004, syncing to 0xb4300004.
[2022-09-19 20:25:37] [00:06.0] xen_p= t_config_reg_init: Offset 0x0042 mismatch! Emulated=3D0x0000, host=3D0x07c3= , syncing to 0x0603.
[2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_i= nit: Offset 0x0052 mismatch! Emulated=3D0x0000, host=3D0x0080, syncing to 0= x0080.
[2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x= 0074 mismatch! Emulated=3D0x0000, host=3D0x5908cc0, syncing to 0x5908cc0.[2022-09-19 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x007a mis= match! Emulated=3D0x0000, host=3D0x0010, syncing to 0x0010.
[2022-09-19 = 20:25:37] [00:06.0] xen_pt_config_reg_init: Offset 0x0082 mismatch! Emulate= d=3D0x0000, host=3D0x1011, syncing to 0x1011.
[2022-09-19 20:25:37] [00:= 06.0] xen_pt_pci_intx: intx=3D1
[2022-09-19 20:25:37] [00:06.0] xen_pt_r= ealize: Real physical device 07:00.0 registered successfully
[2022-09-19= 20:25:37] written 34 bytes to vchan
[2022-09-19 20:25:37] written 2048 = bytes to vchan
[2022-09-19 20:25:37] written 979 bytes to vchan
[2022= -09-19 20:25:37] written 110 bytes to vchan
[2022-09-19 20:25:37] writte= n 34 bytes to vchan
[2022-09-19 20:25:37] written 34 bytes to vchan
[= 2022-09-19 20:25:37] qubes_gui/init[622]: got xorg conf, creating window[2022-09-19 20:25:37] qubes_gui/init: 632
[2022-09-19 20:25:37] configu= re msg, x/y 640 325 (was 0 0), w/h 640 480
[2022-09-19 20:25:37] configu= re msg, x/y 640 325 (was 640 325), w/h 640 480
[2022-09-19 20:25:37] ran= dom: crng init done
[2022-09-19 20:25:39] qubes_gui: got unknown msg typ= e 145, ignoring
[2022-09-19 20:25:57] [00:06.0] Write-back to unknown fi= eld 0x44 (partially) inhibited (0x0000ffff)
[2022-09-19 20:25:57] [00:06= .0] If the device doesn't work, try enabling permissive mode
[2022-0= 9-19 20:25:57] [00:06.0] (unsafe) and if it helps report the problem to xen= -devel
[2022-09-19 20:25:57] [00:06.0] xen_pt_msgctrl_reg_write: setup M= SI (register: 81).
[2022-09-19 20:25:57] [00:06.0] xen_pt_msi_setup: MSI= mapped with pirq 151.
[2022-09-19 20:25:57] [00:06.0] msi_msix_update: = Updating MSI with pirq 151 gvec 0x72 gflags 0x0 (entry: 0x0)
[2022-09-19= 20:27:19] qubes_gui: got unknown msg type 145, ignoring
[2022-09-19 21:= 48:58] {"timestamp": {"seconds": 1663616939, "micr= oseconds": 194886}, "event": "RESET", "data&q= uot;: {"guest": true, "reason": "guest-reset"= }}

[2022-09-19 21:48:58] {"timestamp": {"seconds"= ;: 1663616939, "microseconds": 196105}, "event": "= RESET", "data": {"guest": true, "reason"= : "guest-reset"}}

[2022-09-19 21:49:00] pcifront pci-0: Re= scanning PCI Frontend Bus 0000:00
[2022-09-20 09:21:32] Logfile Opened[2022-09-20 09:21:33] Linux version 5.10.105-xen-stubdom (mockbuild@0c9ad= 8f2058f40c49bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1),= GNU ld version 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022
[2022-09-2= 0 09:21:33] Command line:
[2022-09-20 09:21:33] x86/fpu: Supporting XSA= VE feature 0x001: 'x87 floating point registers'
[2022-09-20 09:= 21:33] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers'
= [2022-09-20 09:21:33] x86/fpu: Supporting XSAVE feature 0x004: 'AVX reg= isters'
[2022-09-20 09:21:33] x86/fpu: xstate_offset[2]: =C2=A0576, = xstate_sizes[2]: =C2=A0256
[2022-09-20 09:21:33] x86/fpu: Enabled xstate= features 0x7, context size is 832 bytes, using 'standard' format.<= br>[2022-09-20 09:21:33] Released 0 page(s)
[2022-09-20 09:21:33] BIOS-p= rovided physical RAM map:
[2022-09-20 09:21:33] Xen: [mem 0x000000000000= 0000-0x000000000009ffff] usable
[2022-09-20 09:21:33] Xen: [mem 0x000000= 00000a0000-0x00000000000fffff] reserved
[2022-09-20 09:21:33] Xen: [mem = 0x0000000000100000-0x0000000008ffffff] usable
[2022-09-20 09:21:33] NX (= Execute Disable) protection: active
[2022-09-20 09:21:33] Hypervisor det= ected: Xen PV
[2022-09-20 09:21:33] tsc: Fast TSC calibration failed
= [2022-09-20 09:21:33] tsc: Detected 2591.998 MHz processor
[2022-09-20 0= 9:21:33] last_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000
[2022-09-20 09= :21:33] x86/PAT: Configuration [0-7]: WB =C2=A0WT =C2=A0UC- UC =C2=A0WC =C2= =A0WP =C2=A0UC =C2=A0UC =C2=A0
[2022-09-20 09:21:33] RAMDISK: [mem 0x020= 00000-0x03f7afff]
[2022-09-20 09:21:33] Zone ranges:
[2022-09-20 09:2= 1:33] =C2=A0 DMA32 =C2=A0 =C2=A0[mem 0x0000000000001000-0x0000000008ffffff]=
[2022-09-20 09:21:33] =C2=A0 Normal =C2=A0 empty
[2022-09-20 09:21:3= 3] Movable zone start for each node
[2022-09-20 09:21:33] Early memory n= ode ranges
[2022-09-20 09:21:33] =C2=A0 node =C2=A0 0: [mem 0x0000000000= 001000-0x000000000009ffff]
[2022-09-20 09:21:33] =C2=A0 node =C2=A0 0: [= mem 0x0000000000100000-0x0000000008ffffff]
[2022-09-20 09:21:33] Initmem= setup node 0 [mem 0x0000000000001000-0x0000000008ffffff]
[2022-09-20 09= :21:33] On node 0, zone DMA32: 1 pages in unavailable ranges
[2022-09-20= 09:21:33] On node 0, zone DMA32: 96 pages in unavailable ranges
[2022-0= 9-20 09:21:33] On node 0, zone DMA32: 28672 pages in unavailable ranges
= [2022-09-20 09:21:33] p2m virtual area at (____ptrval____), size is 200000<= br>[2022-09-20 09:21:33] Remapped 0 page(s)
[2022-09-20 09:21:33] [mem 0= x09000000-0xffffffff] available for PCI devices
[2022-09-20 09:21:33] Bo= oting paravirtualized kernel on Xen
[2022-09-20 09:21:33] Xen version: 4= .14.5 (preserve-AD)
[2022-09-20 09:21:33] clocksource: refined-jiffies: = mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns[2022-09-20 09:21:33] Built 1 zonelists, mobility grouping on.=C2=A0 Tota= l pages: 36170
[2022-09-20 09:21:33] Kernel command line: clocksource=3D= tsc
[2022-09-20 09:21:33] Dentry cache hash table entries: 32768 (order= : 6, 262144 bytes, linear)
[2022-09-20 09:21:33] Inode-cache hash table = entries: 16384 (order: 5, 131072 bytes, linear)
[2022-09-20 09:21:33] me= m auto-init: stack:byref_all(zero), heap alloc:off, heap free:off
[2022-= 09-20 09:21:33] Memory: 96968K/147068K available (6145K kernel code, 842K r= wdata, 428K rodata, 696K init, 476K bss, 49848K reserved, 0K cma-reserved)<= br>[2022-09-20 09:21:33] random: get_random_u64 called from 0xffffffff810a0= f18 with crng_init=3D0
[2022-09-20 09:21:33] SLUB: HWalign=3D64, Order= =3D0-3, MinObjects=3D0, CPUs=3D1, Nodes=3D1
[2022-09-20 09:21:33] Using = NULL legacy PIC
[2022-09-20 09:21:33] NR_IRQS: 4352, nr_irqs: 24, preall= ocated irqs: 0
[2022-09-20 09:21:33] xen:events: Using FIFO-based ABI[2022-09-20 09:21:33] printk: console [hvc0] enabled
[2022-09-20 09:21:= 33] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, m= ax_idle_ns: 881590591483 ns
[2022-09-20 09:21:33] installing Xen timer f= or CPU 0
[2022-09-20 09:21:33] clocksource: tsc-early: mask: 0xfffffffff= fffffff max_cycles: 0x255cb518234, max_idle_ns: 440795279333 ns
[2022-09= -20 09:21:33] Calibrating delay loop (skipped), value calculated using time= r frequency.. 5183.99 BogoMIPS (lpj=3D10367992)
[2022-09-20 09:21:33] pi= d_max: default: 4096 minimum: 301
[2022-09-20 09:21:33] Mount-cache hash= table entries: 512 (order: 0, 4096 bytes, linear)
[2022-09-20 09:21:33]= Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes, linear)[2022-09-20 09:21:33] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8
[20= 22-09-20 09:21:33] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4
= [2022-09-20 09:21:33] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (family= : 0x6, model: 0x9e, stepping: 0xa)
[2022-09-20 09:21:33] Spectre V1 : Mi= tigation: usercopy/swapgs barriers and __user pointer sanitization
[2022= -09-20 09:21:33] Spectre V2 : Mitigation: Retpolines
[2022-09-20 09:21:3= 3] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context = switch
[2022-09-20 09:21:33] Spectre V2 : Enabling Restricted Speculatio= n for firmware calls
[2022-09-20 09:21:33] Spectre V2 : mitigation: Enab= ling conditional Indirect Branch Prediction Barrier
[2022-09-20 09:21:33= ] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled v= ia prctl and seccomp
[2022-09-20 09:21:33] SRBDS: Unknown: Dependent on = hypervisor status
[2022-09-20 09:21:33] MDS: Mitigation: Clear CPU buffe= rs
[2022-09-20 09:21:33] Performance Events: unsupported p6 CPU model 15= 8 no PMU driver, software events only.
[2022-09-20 09:21:33] devtmpfs: i= nitialized
[2022-09-20 09:21:33] clocksource: jiffies: mask: 0xffffffff = max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns
[2022-09-20 09:= 21:33] futex hash table entries: 16 (order: -4, 384 bytes, linear)
[2022= -09-20 09:21:33] NET: Registered protocol family 16
[2022-09-20 09:21:33= ] xen:grant_table: Grant tables using version 1 layout
[2022-09-20 09:21= :33] Grant table initialized
[2022-09-20 09:21:33] PCI: setting up Xen P= CI frontend stub
[2022-09-20 09:21:33] xen:balloon: Initialising balloon= driver
[2022-09-20 09:21:33] usbcore: registered new interface driver u= sbfs
[2022-09-20 09:21:33] usbcore: registered new interface driver hub<= br>[2022-09-20 09:21:33] usbcore: registered new device driver usb
[2022= -09-20 09:21:33] PCI: System does not support PCI
[2022-09-20 09:21:33] = clocksource: Switched to clocksource xen
[2022-09-20 09:21:33] NET: Regi= stered protocol family 2
[2022-09-20 09:21:33] IP idents hash table entr= ies: 4096 (order: 3, 32768 bytes, linear)
[2022-09-20 09:21:33] tcp_list= en_portaddr_hash hash table entries: 256 (order: 0, 4096 bytes, linear)
= [2022-09-20 09:21:33] TCP established hash table entries: 2048 (order: 2, 1= 6384 bytes, linear)
[2022-09-20 09:21:33] TCP bind hash table entries: 2= 048 (order: 2, 16384 bytes, linear)
[2022-09-20 09:21:33] TCP: Hash tabl= es configured (established 2048 bind 2048)
[2022-09-20 09:21:33] UDP has= h table entries: 128 (order: 0, 4096 bytes, linear)
[2022-09-20 09:21:33= ] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes, linear)
[2022-= 09-20 09:21:33] NET: Registered protocol family 1
[2022-09-20 09:21:33] = Unpacking initramfs...
[2022-09-20 09:21:33] Freeing initrd memory: 3223= 6K
[2022-09-20 09:21:33] clocksource: tsc: mask: 0xffffffffffffffff max_= cycles: 0x255cb518234, max_idle_ns: 440795279333 ns
[2022-09-20 09:21:33= ] clocksource: Switched to clocksource tsc
[2022-09-20 09:21:33] working= set: timestamp_bits=3D62 max_order=3D15 bucket_order=3D0
[2022-09-20 09:= 21:33] xen:xen_evtchn: Event-channel device installed
[2022-09-20 09:21:= 33] Invalid max_queues (4), will use default max: 1.
[2022-09-20 09:21:3= 3] random: fast init done
[2022-09-20 09:21:33] tun: Universal TUN/TAP d= evice driver, 1.6
[2022-09-20 09:21:33] xen_netfront: Initialising Xen v= irtual ethernet driver
[2022-09-20 09:21:33] vhci_hcd vhci_hcd.0: USB/IP= Virtual Host Controller
[2022-09-20 09:21:33] vhci_hcd vhci_hcd.0: new = USB bus registered, assigned bus number 1
[2022-09-20 09:21:33] vhci_hcd= : created sysfs vhci_hcd.0
[2022-09-20 09:21:33] hub 1-0:1.0: USB hub fo= und
[2022-09-20 09:21:33] hub 1-0:1.0: 8 ports detected
[2022-09-20 0= 9:21:33] vhci_hcd vhci_hcd.0: USB/IP Virtual Host Controller
[2022-09-20= 09:21:33] vhci_hcd vhci_hcd.0: new USB bus registered, assigned bus number= 2
[2022-09-20 09:21:33] usb usb2: We don't know the algorithms for = LPM for this host, disabling LPM.
[2022-09-20 09:21:33] hub 2-0:1.0: USB= hub found
[2022-09-20 09:21:33] hub 2-0:1.0: 8 ports detected
[2022-= 09-20 09:21:33] NET: Registered protocol family 17
[2022-09-20 09:21:33]= sched_clock: Marking stable (439658149, 279138)->(442513139, -2575852)<= br>[2022-09-20 09:21:33] pcifront pci-0: Installing PCI frontend
[2022-0= 9-20 09:21:33] xen:swiotlb_xen: Warning: only able to allocate 4 MB for sof= tware IO TLB
[2022-09-20 09:21:33] software IO TLB: mapped [mem 0x000000= 0003800000-0x0000000003c00000] (4MB)
[2022-09-20 09:21:33] pcifront pci-= 0: Creating PCI Frontend Bus 0000:00
[2022-09-20 09:21:33] pcifront pci-= 0: PCI host bridge to bus 0000:00
[2022-09-20 09:21:33] pci_bus 0000:00:= root bus resource [io =C2=A00x0000-0xffff]
[2022-09-20 09:21:33] pci_bu= s 0000:00: root bus resource [mem 0x00000000-0x7fffffffff]
[2022-09-20 0= 9:21:33] pci_bus 0000:00: root bus resource [bus 00-ff]
[2022-09-20 09:2= 1:33] pci 0000:00:00.0: [10ec:8168] type 00 class 0x020000
[2022-09-20 0= 9:21:33] pci 0000:00:00.0: reg 0x10: [io =C2=A00x3000-0x30ff]
[2022-09-2= 0 09:21:33] pci 0000:00:00.0: reg 0x18: [mem 0xb4304000-0xb4304fff 64bit][2022-09-20 09:21:33] pci 0000:00:00.0: reg 0x20: [mem 0xb4300000-0xb4303= fff 64bit]
[2022-09-20 09:21:33] pci 0000:00:00.0: supports D1 D2
[20= 22-09-20 09:21:33] pcifront pci-0: claiming resource 0000:00:00.0/0
[202= 2-09-20 09:21:33] pcifront pci-0: claiming resource 0000:00:00.0/2
[2022= -09-20 09:21:33] pcifront pci-0: claiming resource 0000:00:00.0/4
[2022-= 09-20 09:21:33] blkfront: xvda: flush diskcache: enabled; persistent grants= : enabled; indirect descriptors: enabled;
[2022-09-20 09:21:33] =C2=A0xv= da: xvda4
[2022-09-20 09:21:33] blkfront: xvdb: flush diskcache: enabled= ; persistent grants: enabled; indirect descriptors: enabled;
[2022-09-20= 09:21:33] blkfront: xvdc: flush diskcache: enabled; persistent grants: ena= bled; indirect descriptors: enabled;
[2022-09-20 09:21:33] Freeing unuse= d kernel image (initmem) memory: 696K
[2022-09-20 09:21:33] Write protec= ting the kernel read-only data: 10240k
[2022-09-20 09:21:33] Freeing unu= sed kernel image (text/rodata gap) memory: 2044K
[2022-09-20 09:21:33] F= reeing unused kernel image (rodata/data gap) memory: 1620K
[2022-09-20 0= 9:21:33] Run /init as init process
[2022-09-20 09:21:33] + mount -t devt= mpfs none /dev
[2022-09-20 09:21:33] + mount -t sysfs /sys /sys
[2022= -09-20 09:21:33] + mount -t proc /proc /proc
[2022-09-20 09:21:33] + mou= nt -t tmpfs -o 'size=3D1m,nodev,noexec' /tmp /tmp
[2022-09-20 09= :21:33] + mount -o remount,ro /
[2022-09-20 09:21:33] + echo 1
[2022-= 09-20 09:21:33] + printf '%d\n' 1073741824
[2022-09-20 09:21:33]= + /bin/xenstore-read target
[2022-09-20 09:21:33] + domid=3D7
[2022-= 09-20 09:21:33] + xenstore-read /local/domain/7/vm
[2022-09-20 09:21:33]= + vm_path=3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3
[2022-09-20 09:21:= 33] + sort
[2022-09-20 09:21:33] + xenstore-list -p /vm/53ce9bfa-8c06-45= 87-9b52-dcccd76169b3/image/dm-argv
[2022-09-20 09:21:33] + xenstore-read= /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c= 06-4587-9b52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcc= cd76169b3/image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/= dm-argv/004 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/= 53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-45= 87-9b52-dcccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd761= 69b3/image/dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-ar= gv/009 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9= bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b= 52-dcccd76169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/= image/dm-argv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/01= 4 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8= c06-4587-9b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dc= ccd76169b3/image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image= /dm-argv/018 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm= /53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4= 587-9b52-dcccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76= 169b3/image/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-a= rgv/023 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce= 9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9= b52-dcccd76169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3= /image/dm-argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/0= 28 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-= 8c06-4587-9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-d= cccd76169b3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/imag= e/dm-argv/032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033[2022-09-20 09:21:33] + dm_args=3D'-xen-domid
[2022-09-20 09:21:33]= 7
[2022-09-20 09:21:33] -no-shutdown
[2022-09-20 09:21:33] -nodefaul= ts
[2022-09-20 09:21:33] -no-user-config
[2022-09-20 09:21:33] -name<= br>[2022-09-20 09:21:33] openbsd-71
[2022-09-20 09:21:33] -display
[2= 022-09-20 09:21:33] none
[2022-09-20 09:21:33] -device
[2022-09-20 09= :21:33] VGA,vgamem_mb=3D16
[2022-09-20 09:21:33] -boot
[2022-09-20 09= :21:33] order=3Ddc
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33= ] usb-ehci,id=3Dehci
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:= 33] usb-tablet,bus=3Dehci.0
[2022-09-20 09:21:33] -smp
[2022-09-20 09= :21:33] 2,maxcpus=3D2
[2022-09-20 09:21:33] -net
[2022-09-20 09:21:33= ] none
[2022-09-20 09:21:33] -display
[2022-09-20 09:21:33] qubes-gui= ,domid=3D0,log-level=3D0
[2022-09-20 09:21:33] -machine
[2022-09-20 0= 9:21:33] xenfv
[2022-09-20 09:21:33] -m
[2022-09-20 09:21:33] 496
= [2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvda,if= =3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[20= 22-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Did= e,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09= -20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,ind= ex=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09= -20 09:21:33] + usb_args=3D
[2022-09-20 09:21:33] + test -e /bin/qrexec-= agent
[2022-09-20 09:21:33] + usb_args=3D'-device
[2022-09-20 09:= 21:33] nec-usb-xhci,id=3Dxhci'
[2022-09-20 09:21:33] + mkdir -p /var= /run/qubes
[2022-09-20 09:21:33] + touch /dev/mdev.log
[2022-09-20 09= :21:33] + mdev -d
[2022-09-20 09:21:33] + USER=3Droot qrexec-agent
[2= 022-09-20 09:21:33] + sed -n '/^-soundhw/ {n;p}'
[2022-09-20 09:= 21:33] + echo '-xen-domid
[2022-09-20 09:21:33] 7
[2022-09-20 09:= 21:33] -no-shutdown
[2022-09-20 09:21:33] -nodefaults
[2022-09-20 09:= 21:33] -no-user-config
[2022-09-20 09:21:33] -name
[2022-09-20 09:21:= 33] openbsd-71
[2022-09-20 09:21:33] -display
[2022-09-20 09:21:33] n= one
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33] VGA,vgamem_mb= =3D16
[2022-09-20 09:21:33] -boot
[2022-09-20 09:21:33] order=3Ddc[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33] usb-ehci,id=3Dehci<= br>[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33] usb-tablet,bus=3D= ehci.0
[2022-09-20 09:21:33] -smp
[2022-09-20 09:21:33] 2,maxcpus=3D2=
[2022-09-20 09:21:33] -net
[2022-09-20 09:21:33] none
[2022-09-20= 09:21:33] -display
[2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level= =3D0
[2022-09-20 09:21:33] -machine
[2022-09-20 09:21:33] xenfv
[2= 022-09-20 09:21:33] -m
[2022-09-20 09:21:33] 496
[2022-09-20 09:21:33= ] -drive
[2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media= =3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 09:21:33] -dr= ive
[2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddi= sk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 09:21:33] -drive[2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,fo= rmat=3Dhost_device,cache=3Dwriteback'
[2022-09-20 09:21:33] + audio_= model=3D
[2022-09-20 09:21:33] + '[' -n =C2=A0]
[2022-09-20 0= 9:21:33] + sed -n /^-qubes-net:/p
[2022-09-20 09:21:33] + echo '-xen= -domid
[2022-09-20 09:21:33] 7
[2022-09-20 09:21:33] -no-shutdown
= [2022-09-20 09:21:33] -nodefaults
[2022-09-20 09:21:33] -no-user-config<= br>[2022-09-20 09:21:33] -name
[2022-09-20 09:21:33] openbsd-71
[2022= -09-20 09:21:33] -display
[2022-09-20 09:21:33] none
[2022-09-20 09:2= 1:33] -device
[2022-09-20 09:21:33] VGA,vgamem_mb=3D16
[2022-09-20 09= :21:33] -boot
[2022-09-20 09:21:33] order=3Ddc
[2022-09-20 09:21:33] = -device
[2022-09-20 09:21:33] usb-ehci,id=3Dehci
[2022-09-20 09:21:33= ] -device
[2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0
[2022-09-20 0= 9:21:33] -smp
[2022-09-20 09:21:33] 2,maxcpus=3D2
[2022-09-20 09:21:3= 3] -net
[2022-09-20 09:21:33] none
[2022-09-20 09:21:33] -display
= [2022-09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 09:2= 1:33] -machine
[2022-09-20 09:21:33] xenfv
[2022-09-20 09:21:33] -m[2022-09-20 09:21:33] 496
[2022-09-20 09:21:33] -drive
[2022-09-20 = 09:21:33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_de= vice,cache=3Dwriteback
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21= :33] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,= cache=3Dwriteback
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] = file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback'
[2022-09-20 09:21:33] + net_args=3D
[2022-09-20 09:= 21:33] + sed /^-qubes-net:/d
[2022-09-20 09:21:33] + echo '-xen-domi= d
[2022-09-20 09:21:33] 7
[2022-09-20 09:21:33] -no-shutdown
[2022= -09-20 09:21:33] -nodefaults
[2022-09-20 09:21:33] -no-user-config
[2= 022-09-20 09:21:33] -name
[2022-09-20 09:21:33] openbsd-71
[2022-09-2= 0 09:21:33] -display
[2022-09-20 09:21:33] none
[2022-09-20 09:21:33]= -device
[2022-09-20 09:21:33] VGA,vgamem_mb=3D16
[2022-09-20 09:21:3= 3] -boot
[2022-09-20 09:21:33] order=3Ddc
[2022-09-20 09:21:33] -devi= ce
[2022-09-20 09:21:33] usb-ehci,id=3Dehci
[2022-09-20 09:21:33] -de= vice
[2022-09-20 09:21:33] usb-tablet,bus=3Dehci.0
[2022-09-20 09:21:= 33] -smp
[2022-09-20 09:21:33] 2,maxcpus=3D2
[2022-09-20 09:21:33] -n= et
[2022-09-20 09:21:33] none
[2022-09-20 09:21:33] -display
[2022= -09-20 09:21:33] qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 09:21:33]= -machine
[2022-09-20 09:21:33] xenfv
[2022-09-20 09:21:33] -m
[20= 22-09-20 09:21:33] 496
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21= :33] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,= cache=3Dwriteback
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] = file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file= =3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dw= riteback'
[2022-09-20 09:21:33] + dm_args=3D'-xen-domid
[2022= -09-20 09:21:33] 7
[2022-09-20 09:21:33] -no-shutdown
[2022-09-20 09:= 21:33] -nodefaults
[2022-09-20 09:21:33] -no-user-config
[2022-09-20 = 09:21:33] -name
[2022-09-20 09:21:33] openbsd-71
[2022-09-20 09:21:33= ] -display
[2022-09-20 09:21:33] none
[2022-09-20 09:21:33] -device[2022-09-20 09:21:33] VGA,vgamem_mb=3D16
[2022-09-20 09:21:33] -boot[2022-09-20 09:21:33] order=3Ddc
[2022-09-20 09:21:33] -device
[202= 2-09-20 09:21:33] usb-ehci,id=3Dehci
[2022-09-20 09:21:33] -device
[2= 022-09-20 09:21:33] usb-tablet,bus=3Dehci.0
[2022-09-20 09:21:33] -smp[2022-09-20 09:21:33] 2,maxcpus=3D2
[2022-09-20 09:21:33] -net
[202= 2-09-20 09:21:33] none
[2022-09-20 09:21:33] -display
[2022-09-20 09:= 21:33] qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 09:21:33] -machine<= br>[2022-09-20 09:21:33] xenfv
[2022-09-20 09:21:33] -m
[2022-09-20 0= 9:21:33] 496
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file= =3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dw= riteback
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/d= ev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteb= ack
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xv= dc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback&#= 39;
[2022-09-20 09:21:33] + test -e /sys/class/net/eth0
[2022-09-20 0= 9:21:33] + echo 'No network interface named eth0.'
[2022-09-20 0= 9:21:33] No network interface named eth0.
[2022-09-20 09:21:33] + ls -l = /sys/class/net/
[2022-09-20 09:21:33] total 0
[2022-09-20 09:21:33] l= rwxrwxrwx =C2=A0 =C2=A01 root =C2=A0 =C2=A0 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A00 Sep 20 07:21 .[1;36mlo.[m -> .[1;34m../../d= evices/virtual/net/lo.[m
[2022-09-20 09:21:33] + xenstore-read target[2022-09-20 09:21:33] + target=3D7
[2022-09-20 09:21:33] + device_model= =3Ddevice-model/7
[2022-09-20 09:21:33] + mkdir /tmp/qmp
[2022-09-20 = 09:21:33] + kernel=3D
[2022-09-20 09:21:33] + grep -q ^-append
[2022-= 09-20 09:21:33] + echo '-xen-domid
[2022-09-20 09:21:33] 7
[2022-= 09-20 09:21:33] -no-shutdown
[2022-09-20 09:21:33] -nodefaults
[2022-= 09-20 09:21:33] -no-user-config
[2022-09-20 09:21:33] -name
[2022-09-= 20 09:21:33] openbsd-71
[2022-09-20 09:21:33] -display
[2022-09-20 09= :21:33] none
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33] VGA,= vgamem_mb=3D16
[2022-09-20 09:21:33] -boot
[2022-09-20 09:21:33] orde= r=3Ddc
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33] usb-ehci,i= d=3Dehci
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:33] usb-tabl= et,bus=3Dehci.0
[2022-09-20 09:21:33] -smp
[2022-09-20 09:21:33] 2,ma= xcpus=3D2
[2022-09-20 09:21:33] -net
[2022-09-20 09:21:33] none
[2= 022-09-20 09:21:33] -display
[2022-09-20 09:21:33] qubes-gui,domid=3D0,l= og-level=3D0
[2022-09-20 09:21:33] -machine
[2022-09-20 09:21:33] xen= fv
[2022-09-20 09:21:33] -m
[2022-09-20 09:21:33] 496
[2022-09-20 = 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvda,if=3Dide,index= =3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 09:= 21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Dide,index=3D1,= media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 09:21:33= ] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,index=3D2,media= =3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-20 09:21:33= ] + mkfifo /tmp/qmp/qemu.in /tmp/qmp/qemu.ou= t
[2022-09-20 09:21:33] + set +x
[2022-09-20 09:21:33] Clearing kmsg = buffer...
[2022-09-20 09:21:33] + set +x
[2022-09-20 09:21:33] + set+= sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/'
[2022-09-20 09:21:= 33] =C2=A0+x
[2022-09-20 09:21:33] + echo '-xen-domid
[2022-09-20= 09:21:33] 7
[2022-09-20 09:21:33] -no-shutdown
[2022-09-20 09:21:33]= -nodefaults
[2022-09-20 09:21:33] -no-user-config
[2022-09-20 09:21:= 33] -name
[2022-09-20 09:21:33] openbsd-71
[2022-09-20 09:21:33] -dis= play
[2022-09-20 09:21:33] none
[2022-09-20 09:21:33] -device
[202= 2-09-20 09:21:33] VGA,vgamem_mb=3D16
[2022-09-20 09:21:33] -boot
[202= 2-09-20 09:21:33] order=3Ddc
[2022-09-20 09:21:33] -device
[2022-09-2= 0 09:21:33] usb-ehci,id=3Dehci
[2022-09-20 09:21:33] -device
[2022-09= -20 09:21:33] usb-tablet,bus=3Dehci.0
[2022-09-20 09:21:33] -smp
[202= 2-09-20 09:21:33] 2,maxcpus=3D2
[2022-09-20 09:21:33] -net
[2022-09-2= 0 09:21:33] none
[2022-09-20 09:21:33] -display
[2022-09-20 09:21:33]= qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 09:21:33] -machine
[20= 22-09-20 09:21:33] xenfv
[2022-09-20 09:21:33] -m
[2022-09-20 09:21:3= 3] 496
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev= /xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwritebac= k
[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdb= ,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
= [2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdc,if= =3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'[2022-09-20 09:21:33] + dm_args=3D'-xen-domid
[2022-09-20 09:21:33= ] 7
[2022-09-20 09:21:33] -no-shutdown
[2022-09-20 09:21:33] -nodefau= lts
[2022-09-20 09:21:33] -no-user-config
[2022-09-20 09:21:33] -name=
[2022-09-20 09:21:33] openbsd-71
[2022-09-20 09:21:33] -display
[= 2022-09-20 09:21:33] none
[2022-09-20 09:21:33] -device
[2022-09-20 0= 9:21:33] VGA,vgamem_mb=3D16
[2022-09-20 09:21:33] -boot
[2022-09-20 0= 9:21:33] order=3Ddc
[2022-09-20 09:21:33] -device
[2022-09-20 09:21:3= 3] usb-ehci,id=3Dehci
[2022-09-20 09:21:33] -device
[2022-09-20 09:21= :33] usb-tablet,bus=3Dehci.0
[2022-09-20 09:21:33] -smp
[2022-09-20 0= 9:21:33] 2,maxcpus=3D2
[2022-09-20 09:21:33] -net
[2022-09-20 09:21:3= 3] none
[2022-09-20 09:21:33] -display
[2022-09-20 09:21:33] qubes-gu= i,domid=3D0,log-level=3D0
[2022-09-20 09:21:33] -machine
[2022-09-20 = 09:21:33] xenfv
[2022-09-20 09:21:33] -m
[2022-09-20 09:21:33] 496[2022-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvda,if= =3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[20= 22-09-20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdb,if=3Did= e,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09= -20 09:21:33] -drive
[2022-09-20 09:21:33] file=3D/dev/xvdc,if=3Dide,ind= ex=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09= -20 09:21:33] + xenstore-read device/console/2
[2022-09-20 09:21:33] + x= enstore-read device/console/1
[2022-09-20 09:21:33] + IFS=3D'
[20= 22-09-20 09:21:33] '
[2022-09-20 09:21:33] + set -f
[2022-09-20 0= 9:21:33] + set +f
[2022-09-20 09:21:33] + unset IFS
[2022-09-20 09:21= :33] + qemu_pid=3D72
[2022-09-20 09:21:33] + '[' '!' -e = /tmp/qemu.qmp ]
[2022-09-20 09:21:33] + sleep 0.1
[2022-09-20 09:21:3= 3] + qemu -sandbox+ '[' '!' -e /tmp/qemu.qmp ]
[2022-09-= 20 09:21:33] + sleep 0.1
[2022-09-20 09:21:34] =C2=A0'on,obsolete=3D= deny,elevateprivileges=3Ddeny,spawn=3Ddeny,resourcecontrol=3Ddeny' -cha= rdev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm' -mon 'chardev=3Dm,mode= =3Dcontrol' -chardev 'socket,server,nowait,path=3D/tmp/qemu.qmp,id= =3Dm2' -mon 'chardev=3Dm2,mode=3Dcontrol' -xen-domid 7 -no-shut= down -nodefaults -no-user-config -name openbsd-71 -display none -device = 9;VGA,vgamem_mb=3D16' -boot 'order=3Ddc' -device 'usb-ehci,= id=3Dehci' -device 'usb-tablet,bus=3Dehci.0' -smp '2,maxcpu= s=3D2' -net none -display 'qubes-gui,domid=3D0,log-level=3D0' -= machine xenfv -m 496 -drive 'file=3D/dev/xvda,if=3Dide,index=3D0,media= =3Ddisk,format=3Dhost_device,cache=3Dwriteback' -drive 'file=3D/dev= /xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwritebac= k' -drive 'file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format= =3Dhost_device,cache=3Dwriteback' -device 'nec-usb-xhci,id=3Dxhci&#= 39;
[2022-09-20 09:21:34] + '[' '!' -e /tmp/qemu.qmp ][2022-09-20 09:21:34] + sleep 0.1
[2022-09-20 09:21:34] qemu: -chardev= socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form boo= lean option 'server' deprecated
[2022-09-20 09:21:34] Please use= server=3Don instead
[2022-09-20 09:21:34] qemu: -chardev socket,server,= nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form boolean option = 9;nowait' deprecated
[2022-09-20 09:21:34] Please use wait=3Doff ins= tead
[2022-09-20 09:21:34] + tee /proc/self/fd/2
[2022-09-20 09:21:34= ] + echo '{"execute": "qmp_capabilities"}'
[= 2022-09-20 09:21:34] {"execute": "qmp_capabilities"}[2022-09-20 09:21:34] random: qemu: uninitialized urandom read (16 bytes r= ead)
[2022-09-20 09:21:34] {"QMP": {"version": {&quo= t;qemu": {"micro": 0, "minor": 1, "major"= ;: 6}, "package": ""}, "capabilities": ["= ;oob"]}}

[2022-09-20 09:21:34] qubes_gui/init: 573
[2022-09-= 20 09:21:34] qubes_gui/init: 582
[2022-09-20 09:21:34] qubes_gui/init: 5= 84
[2022-09-20 09:21:34] + '[' '!' -e /tmp/qemu.qmp ][2022-09-20 09:21:34] + '[' -e /proc/self/fd/4 ]
[2022-09-20 09= :21:34] + '[' -e /proc/self/fd/3 ]
[2022-09-20 09:21:34] + true<= br>[2022-09-20 09:21:34] + printf '=3D=3D=3D=3D Press enter for shell = =3D=3D=3D=3D\n'
[2022-09-20 09:21:34] =3D=3D=3D=3D Press enter for s= hell =3D=3D=3D=3D
[2022-09-20 09:21:34] + read
[2022-09-20 09:21:34] = + vchan-socket-proxy 0 device-model/7/qmp-vchan /tmp/qemu.qmp
[2022-09-2= 0 09:21:34] qubes_gui/init[611]: version sent, waiting for xorg conf
[20= 22-09-20 09:21:34] {"return": {}}

[2022-09-20 09:21:34] wr= itten 110 bytes to vchan
[2022-09-20 09:21:34] written 34 bytes to vchan=
[2022-09-20 09:21:34] [00:06.0] xen_pt_realize: Assigning real physical= device 07:00.0 to devfn 0x30
[2022-09-20 09:21:34] [00:06.0] xen_pt_reg= ister_regions: IO region 0 registered (size=3D0x00000100 base_addr=3D0x0000= 3000 type: 0x1)
[2022-09-20 09:21:34] [00:06.0] xen_pt_register_regions:= IO region 2 registered (size=3D0x00001000 base_addr=3D0xb4304000 type: 0x4= )
[2022-09-20 09:21:34] [00:06.0] xen_pt_register_regions: IO region 4 r= egistered (size=3D0x00004000 base_addr=3D0xb4300000 type: 0x4)
[2022-09-= 20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x000e mismatch! Emul= ated=3D0x0080, host=3D0x0000, syncing to 0x0000.
[2022-09-20 09:21:34] [= 00:06.0] xen_pt_config_reg_init: Offset 0x0010 mismatch! Emulated=3D0x0000,= host=3D0x3001, syncing to 0x3001.
[2022-09-20 09:21:34] [00:06.0] xen_p= t_config_reg_init: Offset 0x0018 mismatch! Emulated=3D0x0000, host=3D0xb430= 4004, syncing to 0xb4304004.
[2022-09-20 09:21:34] [00:06.0] xen_pt_conf= ig_reg_init: Offset 0x0020 mismatch! Emulated=3D0x0000, host=3D0xb4300004, = syncing to 0xb4300004.
[2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg= _init: Offset 0x0042 mismatch! Emulated=3D0x0000, host=3D0x07c3, syncing to= 0x0603.
[2022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset = 0x0052 mismatch! Emulated=3D0x0000, host=3D0x0080, syncing to 0x0080.
[2= 022-09-20 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x0074 mismatc= h! Emulated=3D0x0000, host=3D0x5908cc0, syncing to 0x5908cc0.
[2022-09-2= 0 09:21:34] [00:06.0] xen_pt_config_reg_init: Offset 0x007a mismatch! Emula= ted=3D0x0000, host=3D0x0010, syncing to 0x0010.
[2022-09-20 09:21:34] [0= 0:06.0] xen_pt_config_reg_init: Offset 0x0082 mismatch! Emulated=3D0x0000, = host=3D0x1011, syncing to 0x1011.
[2022-09-20 09:21:34] [00:06.0] xen_pt= _pci_intx: intx=3D1
[2022-09-20 09:21:34] [00:06.0] xen_pt_realize: Real= physical device 07:00.0 registered successfully
[2022-09-20 09:21:34] w= ritten 34 bytes to vchan
[2022-09-20 09:21:34] written 2048 bytes to vch= an
[2022-09-20 09:21:34] written 979 bytes to vchan
[2022-09-20 09:21= :34] written 110 bytes to vchan
[2022-09-20 09:21:34] written 34 bytes t= o vchan
[2022-09-20 09:21:34] written 34 bytes to vchan
[2022-09-20 0= 9:21:34] qubes_gui/init[622]: got xorg conf, creating window
[2022-09-20= 09:21:34] qubes_gui/init: 632
[2022-09-20 09:21:34] configure msg, x/y = 640 325 (was 0 0), w/h 640 480
[2022-09-20 09:21:34] configure msg, x/y = 640 325 (was 640 325), w/h 640 480
[2022-09-20 09:21:35] random: crng in= it done
[2022-09-20 09:21:58] [00:06.0] Write-back to unknown field 0x44= (partially) inhibited (0x0000ffff)
[2022-09-20 09:21:58] [00:06.0] If t= he device doesn't work, try enabling permissive mode
[2022-09-20 09:= 21:58] [00:06.0] (unsafe) and if it helps report the problem to xen-devel[2022-09-20 09:21:58] [00:06.0] xen_pt_msgctrl_reg_write: setup MSI (regi= ster: 81).
[2022-09-20 09:21:58] [00:06.0] xen_pt_msi_setup: MSI mapped = with pirq 151.
[2022-09-20 09:21:58] [00:06.0] msi_msix_update: Updating= MSI with pirq 151 gvec 0x72 gflags 0x0 (entry: 0x0)
[2022-09-20 09:31:1= 9] qubes_gui: got unknown msg type 145, ignoring
[2022-09-20 09:33:54] q= ubes_gui: got unknown msg type 145, ignoring
[2022-09-20 09:42:36] {&quo= t;timestamp": {"seconds": 1663659756, "microseconds&quo= t;: 783476}, "event": "RESET", "data": {"= ;guest": true, "reason": "guest-reset"}}

[2= 022-09-20 09:42:36] {"timestamp": {"seconds": 166365975= 6, "microseconds": 784673}, "event": "RESET",= "data": {"guest": true, "reason": "gues= t-reset"}}

[2022-09-20 09:42:38] pcifront pci-0: Rescanning PCI= Frontend Bus 0000:00
[2022-09-20 10:08:20] Logfile Opened
[2022-09-2= 0 10:08:20] Linux version 5.10.105-xen-stubdom (mockbuild@0c9ad8f2058f40c49= bc934dcc2ea73c7) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld vers= ion 2.34-6.fc32) #1 Fri Apr 22 17:53:39 CEST 2022
[2022-09-20 10:08:20] = Command line:
[2022-09-20 10:08:20] x86/fpu: Supporting XSAVE feature 0= x001: 'x87 floating point registers'
[2022-09-20 10:08:20] x86/f= pu: Supporting XSAVE feature 0x002: 'SSE registers'
[2022-09-20 = 10:08:20] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers'<= br>[2022-09-20 10:08:20] x86/fpu: xstate_offset[2]: =C2=A0576, xstate_sizes= [2]: =C2=A0256
[2022-09-20 10:08:20] x86/fpu: Enabled xstate features 0x= 7, context size is 832 bytes, using 'standard' format.
[2022-09-= 20 10:08:20] Released 0 page(s)
[2022-09-20 10:08:20] BIOS-provided phys= ical RAM map:
[2022-09-20 10:08:20] Xen: [mem 0x0000000000000000-0x00000= 0000009ffff] usable
[2022-09-20 10:08:20] Xen: [mem 0x00000000000a0000-0= x00000000000fffff] reserved
[2022-09-20 10:08:20] Xen: [mem 0x0000000000= 100000-0x0000000008ffffff] usable
[2022-09-20 10:08:20] NX (Execute Disa= ble) protection: active
[2022-09-20 10:08:20] Hypervisor detected: Xen P= V
[2022-09-20 10:08:20] tsc: Fast TSC calibration failed
[2022-09-20 = 10:08:20] tsc: Detected 2591.998 MHz processor
[2022-09-20 10:08:20] las= t_pfn =3D 0x9000 max_arch_pfn =3D 0x400000000
[2022-09-20 10:08:20] x86/= PAT: Configuration [0-7]: WB =C2=A0WT =C2=A0UC- UC =C2=A0WC =C2=A0WP =C2=A0= UC =C2=A0UC =C2=A0
[2022-09-20 10:08:20] RAMDISK: [mem 0x02000000-0x03f7= afff]
[2022-09-20 10:08:20] Zone ranges:
[2022-09-20 10:08:20] =C2=A0= DMA32 =C2=A0 =C2=A0[mem 0x0000000000001000-0x0000000008ffffff]
[2022-09= -20 10:08:20] =C2=A0 Normal =C2=A0 empty
[2022-09-20 10:08:20] Movable z= one start for each node
[2022-09-20 10:08:20] Early memory node ranges[2022-09-20 10:08:20] =C2=A0 node =C2=A0 0: [mem 0x0000000000001000-0x000= 000000009ffff]
[2022-09-20 10:08:20] =C2=A0 node =C2=A0 0: [mem 0x000000= 0000100000-0x0000000008ffffff]
[2022-09-20 10:08:20] Initmem setup node = 0 [mem 0x0000000000001000-0x0000000008ffffff]
[2022-09-20 10:08:20] On n= ode 0, zone DMA32: 1 pages in unavailable ranges
[2022-09-20 10:08:20] O= n node 0, zone DMA32: 96 pages in unavailable ranges
[2022-09-20 10:08:2= 0] On node 0, zone DMA32: 28672 pages in unavailable ranges
[2022-09-20 = 10:08:20] p2m virtual area at (____ptrval____), size is 200000
[2022-09-= 20 10:08:20] Remapped 0 page(s)
[2022-09-20 10:08:20] [mem 0x09000000-0x= ffffffff] available for PCI devices
[2022-09-20 10:08:20] Booting paravi= rtualized kernel on Xen
[2022-09-20 10:08:20] Xen version: 4.14.5 (prese= rve-AD)
[2022-09-20 10:08:20] clocksource: refined-jiffies: mask: 0xffff= ffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns
[2022-09-2= 0 10:08:20] Built 1 zonelists, mobility grouping on.=C2=A0 Total pages: 361= 70
[2022-09-20 10:08:20] Kernel command line: clocksource=3Dtsc
[202= 2-09-20 10:08:20] Dentry cache hash table entries: 32768 (order: 6, 262144 = bytes, linear)
[2022-09-20 10:08:20] Inode-cache hash table entries: 163= 84 (order: 5, 131072 bytes, linear)
[2022-09-20 10:08:20] mem auto-init:= stack:byref_all(zero), heap alloc:off, heap free:off
[2022-09-20 10:08:= 20] Memory: 96968K/147068K available (6145K kernel code, 842K rwdata, 428K = rodata, 696K init, 476K bss, 49848K reserved, 0K cma-reserved)
[2022-09-= 20 10:08:20] random: get_random_u64 called from 0xffffffff810a0f18 with crn= g_init=3D0
[2022-09-20 10:08:20] SLUB: HWalign=3D64, Order=3D0-3, MinObj= ects=3D0, CPUs=3D1, Nodes=3D1
[2022-09-20 10:08:20] Using NULL legacy PI= C
[2022-09-20 10:08:20] NR_IRQS: 4352, nr_irqs: 24, preallocated irqs: 0=
[2022-09-20 10:08:20] xen:events: Using FIFO-based ABI
[2022-09-20 1= 0:08:20] printk: console [hvc0] enabled
[2022-09-20 10:08:20] clocksourc= e: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 88= 1590591483 ns
[2022-09-20 10:08:20] installing Xen timer for CPU 0
[2= 022-09-20 10:08:20] clocksource: tsc-early: mask: 0xffffffffffffffff max_cy= cles: 0x255cb518234, max_idle_ns: 440795279333 ns
[2022-09-20 10:08:20] = Calibrating delay loop (skipped), value calculated using timer frequency.. = 5183.99 BogoMIPS (lpj=3D10367992)
[2022-09-20 10:08:20] pid_max: default= : 4096 minimum: 301
[2022-09-20 10:08:20] Mount-cache hash table entries= : 512 (order: 0, 4096 bytes, linear)
[2022-09-20 10:08:20] Mountpoint-ca= che hash table entries: 512 (order: 0, 4096 bytes, linear)
[2022-09-20 1= 0:08:20] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8
[2022-09-20 10:08= :20] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4
[2022-09-20 10= :08:20] CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (family: 0x6, model: = 0x9e, stepping: 0xa)
[2022-09-20 10:08:20] Spectre V1 : Mitigation: user= copy/swapgs barriers and __user pointer sanitization
[2022-09-20 10:08:2= 0] Spectre V2 : Mitigation: Retpolines
[2022-09-20 10:08:20] Spectre V2 = : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch
[202= 2-09-20 10:08:20] Spectre V2 : Enabling Restricted Speculation for firmware= calls
[2022-09-20 10:08:20] Spectre V2 : mitigation: Enabling condition= al Indirect Branch Prediction Barrier
[2022-09-20 10:08:20] Speculative = Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and s= eccomp
[2022-09-20 10:08:20] SRBDS: Unknown: Dependent on hypervisor sta= tus
[2022-09-20 10:08:20] MDS: Mitigation: Clear CPU buffers
[2022-09= -20 10:08:20] Performance Events: unsupported p6 CPU model 158 no PMU drive= r, software events only.
[2022-09-20 10:08:20] devtmpfs: initialized
= [2022-09-20 10:08:20] clocksource: jiffies: mask: 0xffffffff max_cycles: 0x= ffffffff, max_idle_ns: 7645041785100000 ns
[2022-09-20 10:08:20] futex h= ash table entries: 16 (order: -4, 384 bytes, linear)
[2022-09-20 10:08:2= 0] NET: Registered protocol family 16
[2022-09-20 10:08:20] xen:grant_ta= ble: Grant tables using version 1 layout
[2022-09-20 10:08:20] Grant tab= le initialized
[2022-09-20 10:08:20] PCI: setting up Xen PCI frontend st= ub
[2022-09-20 10:08:20] xen:balloon: Initialising balloon driver
[20= 22-09-20 10:08:20] usbcore: registered new interface driver usbfs
[2022-= 09-20 10:08:20] usbcore: registered new interface driver hub
[2022-09-20= 10:08:20] usbcore: registered new device driver usb
[2022-09-20 10:08:2= 0] PCI: System does not support PCI
[2022-09-20 10:08:20] clocksource: S= witched to clocksource xen
[2022-09-20 10:08:20] NET: Registered protoco= l family 2
[2022-09-20 10:08:20] IP idents hash table entries: 4096 (ord= er: 3, 32768 bytes, linear)
[2022-09-20 10:08:20] tcp_listen_portaddr_ha= sh hash table entries: 256 (order: 0, 4096 bytes, linear)
[2022-09-20 10= :08:20] TCP established hash table entries: 2048 (order: 2, 16384 bytes, li= near)
[2022-09-20 10:08:20] TCP bind hash table entries: 2048 (order: 2,= 16384 bytes, linear)
[2022-09-20 10:08:20] TCP: Hash tables configured = (established 2048 bind 2048)
[2022-09-20 10:08:20] UDP hash table entrie= s: 128 (order: 0, 4096 bytes, linear)
[2022-09-20 10:08:20] UDP-Lite has= h table entries: 128 (order: 0, 4096 bytes, linear)
[2022-09-20 10:08:20= ] NET: Registered protocol family 1
[2022-09-20 10:08:20] Unpacking init= ramfs...
[2022-09-20 10:08:20] Freeing initrd memory: 32236K
[2022-09= -20 10:08:20] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x255c= b518234, max_idle_ns: 440795279333 ns
[2022-09-20 10:08:20] clocksource:= Switched to clocksource tsc
[2022-09-20 10:08:20] workingset: timestamp= _bits=3D62 max_order=3D15 bucket_order=3D0
[2022-09-20 10:08:20] xen:xen= _evtchn: Event-channel device installed
[2022-09-20 10:08:20] Invalid ma= x_queues (4), will use default max: 1.
[2022-09-20 10:08:21] random: fas= t init done
[2022-09-20 10:08:21] tun: Universal TUN/TAP device driver, = 1.6
[2022-09-20 10:08:21] xen_netfront: Initialising Xen virtual etherne= t driver
[2022-09-20 10:08:21] vhci_hcd vhci_hcd.0: USB/IP Virtual Host = Controller
[2022-09-20 10:08:21] vhci_hcd vhci_hcd.0: new USB bus regist= ered, assigned bus number 1
[2022-09-20 10:08:21] vhci_hcd: created sysf= s vhci_hcd.0
[2022-09-20 10:08:21] hub 1-0:1.0: USB hub found
[2022-0= 9-20 10:08:21] hub 1-0:1.0: 8 ports detected
[2022-09-20 10:08:21] vhci_= hcd vhci_hcd.0: USB/IP Virtual Host Controller
[2022-09-20 10:08:21] vhc= i_hcd vhci_hcd.0: new USB bus registered, assigned bus number 2
[2022-09= -20 10:08:21] usb usb2: We don't know the algorithms for LPM for this h= ost, disabling LPM.
[2022-09-20 10:08:21] hub 2-0:1.0: USB hub found
= [2022-09-20 10:08:21] hub 2-0:1.0: 8 ports detected
[2022-09-20 10:08:21= ] NET: Registered protocol family 17
[2022-09-20 10:08:21] sched_clock: = Marking stable (312462849, 188928)->(314330248, -1678471)
[2022-09-20= 10:08:21] pcifront pci-0: Installing PCI frontend
[2022-09-20 10:08:21]= xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB[2022-09-20 10:08:21] software IO TLB: mapped [mem 0x0000000003800000-0x0= 000000003c00000] (4MB)
[2022-09-20 10:08:21] pcifront pci-0: Creating PC= I Frontend Bus 0000:00
[2022-09-20 10:08:21] pcifront pci-0: PCI host br= idge to bus 0000:00
[2022-09-20 10:08:21] pci_bus 0000:00: root bus reso= urce [io =C2=A00x0000-0xffff]
[2022-09-20 10:08:21] pci_bus 0000:00: roo= t bus resource [mem 0x00000000-0x7fffffffff]
[2022-09-20 10:08:21] pci_b= us 0000:00: root bus resource [bus 00-ff]
[2022-09-20 10:08:21] pci 0000= :00:00.0: [10ec:8168] type 00 class 0x020000
[2022-09-20 10:08:21] pci 0= 000:00:00.0: reg 0x10: [io =C2=A00x3000-0x30ff]
[2022-09-20 10:08:21] pc= i 0000:00:00.0: reg 0x18: [mem 0xb4304000-0xb4304fff 64bit]
[2022-09-20 = 10:08:21] pci 0000:00:00.0: reg 0x20: [mem 0xb4300000-0xb4303fff 64bit]
= [2022-09-20 10:08:21] pci 0000:00:00.0: supports D1 D2
[2022-09-20 10:08= :21] pcifront pci-0: claiming resource 0000:00:00.0/0
[2022-09-20 10:08:= 21] pcifront pci-0: claiming resource 0000:00:00.0/2
[2022-09-20 10:08:2= 1] pcifront pci-0: claiming resource 0000:00:00.0/4
[2022-09-20 10:08:21= ] blkfront: xvda: flush diskcache: enabled; persistent grants: enabled; ind= irect descriptors: enabled;
[2022-09-20 10:08:21] =C2=A0xvda: xvda4
[= 2022-09-20 10:08:21] blkfront: xvdb: flush diskcache: enabled; persistent g= rants: enabled; indirect descriptors: enabled;
[2022-09-20 10:08:21] blk= front: xvdc: flush diskcache: enabled; persistent grants: enabled; indirect= descriptors: enabled;
[2022-09-20 10:08:21] Freeing unused kernel image= (initmem) memory: 696K
[2022-09-20 10:08:21] Write protecting the kerne= l read-only data: 10240k
[2022-09-20 10:08:21] Freeing unused kernel ima= ge (text/rodata gap) memory: 2044K
[2022-09-20 10:08:21] Freeing unused = kernel image (rodata/data gap) memory: 1620K
[2022-09-20 10:08:21] Run /= init as init process
[2022-09-20 10:08:21] + mount -t devtmpfs none /dev=
[2022-09-20 10:08:21] + mount -t sysfs /sys /sys
[2022-09-20 10:08:2= 1] + mount -t proc /proc /proc
[2022-09-20 10:08:21] + mount -t tmpfs -o= 'size=3D1m,nodev,noexec' /tmp /tmp
[2022-09-20 10:08:21] + moun= t -o remount,ro /
[2022-09-20 10:08:21] + echo 1
[2022-09-20 10:08:21= ] + printf '%d\n' 1073741824
[2022-09-20 10:08:21] + /bin/xensto= re-read target
[2022-09-20 10:08:21] + domid=3D19
[2022-09-20 10:08:2= 1] + xenstore-read /local/domain/19/vm
[2022-09-20 10:08:21] + vm_path= =3D/vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3
[2022-09-20 10:08:21] + sort=
[2022-09-20 10:08:21] + xenstore-list -p /vm/53ce9bfa-8c06-4587-9b52-dc= ccd76169b3/image/dm-argv
[2022-09-20 10:08:21] + xenstore-read /vm/53ce9= bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/001 /vm/53ce9bfa-8c06-4587-9b= 52-dcccd76169b3/image/dm-argv/002 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/= image/dm-argv/003 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/00= 4 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/005 /vm/53ce9bfa-8= c06-4587-9b52-dcccd76169b3/image/dm-argv/006 /vm/53ce9bfa-8c06-4587-9b52-dc= ccd76169b3/image/dm-argv/007 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image= /dm-argv/008 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/009 /vm= /53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/010 /vm/53ce9bfa-8c06-4= 587-9b52-dcccd76169b3/image/dm-argv/011 /vm/53ce9bfa-8c06-4587-9b52-dcccd76= 169b3/image/dm-argv/012 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-a= rgv/013 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/014 /vm/53ce= 9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/015 /vm/53ce9bfa-8c06-4587-9= b52-dcccd76169b3/image/dm-argv/016 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3= /image/dm-argv/017 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/0= 18 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/019 /vm/53ce9bfa-= 8c06-4587-9b52-dcccd76169b3/image/dm-argv/020 /vm/53ce9bfa-8c06-4587-9b52-d= cccd76169b3/image/dm-argv/021 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/imag= e/dm-argv/022 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/023 /v= m/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/024 /vm/53ce9bfa-8c06-= 4587-9b52-dcccd76169b3/image/dm-argv/025 /vm/53ce9bfa-8c06-4587-9b52-dcccd7= 6169b3/image/dm-argv/026 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-= argv/027 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/028 /vm/53c= e9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/029 /vm/53ce9bfa-8c06-4587-= 9b52-dcccd76169b3/image/dm-argv/030 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b= 3/image/dm-argv/031 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/= 032 /vm/53ce9bfa-8c06-4587-9b52-dcccd76169b3/image/dm-argv/033
[2022-09-= 20 10:08:21] + dm_args=3D'-xen-domid
[2022-09-20 10:08:21] 19
[20= 22-09-20 10:08:21] -no-shutdown
[2022-09-20 10:08:21] -nodefaults
[20= 22-09-20 10:08:21] -no-user-config
[2022-09-20 10:08:21] -name
[2022-= 09-20 10:08:21] openbsd-71
[2022-09-20 10:08:21] -display
[2022-09-20= 10:08:21] none
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] V= GA,vgamem_mb=3D16
[2022-09-20 10:08:21] -boot
[2022-09-20 10:08:21] o= rder=3Ddc
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] usb-ehc= i,id=3Dehci
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] usb-t= ablet,bus=3Dehci.0
[2022-09-20 10:08:21] -smp
[2022-09-20 10:08:21] 2= ,maxcpus=3D2
[2022-09-20 10:08:21] -net
[2022-09-20 10:08:21] none[2022-09-20 10:08:21] -display
[2022-09-20 10:08:21] qubes-gui,domid=3D= 0,log-level=3D0
[2022-09-20 10:08:21] -machine
[2022-09-20 10:08:21] = xenfv
[2022-09-20 10:08:21] -m
[2022-09-20 10:08:21] 496
[2022-09-= 20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,inde= x=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 10= :08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1= ,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 10:08:2= 1] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,medi= a=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-20 10:08:2= 1] + usb_args=3D
[2022-09-20 10:08:21] + test -e /bin/qrexec-agent
[2= 022-09-20 10:08:21] + usb_args=3D'-device
[2022-09-20 10:08:21] nec-= usb-xhci,id=3Dxhci'
[2022-09-20 10:08:21] + mkdir -p /var/run/qubes<= br>[2022-09-20 10:08:21] + touch /dev/mdev.log
[2022-09-20 10:08:21] + U= SER=3Droot qrexec-agent
[2022-09-20 10:08:21] + mdev -d
[2022-09-20 1= 0:08:21] + sed -n '/^-soundhw/ {n;p}'
[2022-09-20 10:08:21] + ec= ho '-xen-domid
[2022-09-20 10:08:21] 19
[2022-09-20 10:08:21] -no= -shutdown
[2022-09-20 10:08:21] -nodefaults
[2022-09-20 10:08:21] -no= -user-config
[2022-09-20 10:08:21] -name
[2022-09-20 10:08:21] openbs= d-71
[2022-09-20 10:08:21] -display
[2022-09-20 10:08:21] none
[20= 22-09-20 10:08:21] -device
[2022-09-20 10:08:21] VGA,vgamem_mb=3D16
[= 2022-09-20 10:08:21] -boot
[2022-09-20 10:08:21] order=3Ddc
[2022-09-= 20 10:08:21] -device
[2022-09-20 10:08:21] usb-ehci,id=3Dehci
[2022-0= 9-20 10:08:21] -device
[2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0
= [2022-09-20 10:08:21] -smp
[2022-09-20 10:08:21] 2,maxcpus=3D2
[2022-= 09-20 10:08:21] -net
[2022-09-20 10:08:21] none
[2022-09-20 10:08:21]= -display
[2022-09-20 10:08:21] qubes-gui,domid=3D0,log-level=3D0
[20= 22-09-20 10:08:21] -machine
[2022-09-20 10:08:21] xenfv
[2022-09-20 1= 0:08:21] -m
[2022-09-20 10:08:21] 496
[2022-09-20 10:08:21] -drive[2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,for= mat=3Dhost_device,cache=3Dwriteback
[2022-09-20 10:08:21] -drive
[202= 2-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format= =3Dhost_device,cache=3Dwriteback
[2022-09-20 10:08:21] -drive
[2022-0= 9-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dho= st_device,cache=3Dwriteback'
[2022-09-20 10:08:21] + audio_model=3D<= br>[2022-09-20 10:08:21] + '[' -n =C2=A0]
[2022-09-20 10:08:21] = + sed -n /^-qubes-net:/p
[2022-09-20 10:08:21] + echo '-xen-domid[2022-09-20 10:08:21] 19
[2022-09-20 10:08:21] -no-shutdown
[2022-09= -20 10:08:21] -nodefaults
[2022-09-20 10:08:21] -no-user-config
[2022= -09-20 10:08:21] -name
[2022-09-20 10:08:21] openbsd-71
[2022-09-20 1= 0:08:21] -display
[2022-09-20 10:08:21] none
[2022-09-20 10:08:21] -d= evice
[2022-09-20 10:08:21] VGA,vgamem_mb=3D16
[2022-09-20 10:08:21] = -boot
[2022-09-20 10:08:21] order=3Ddc
[2022-09-20 10:08:21] -device<= br>[2022-09-20 10:08:21] usb-ehci,id=3Dehci
[2022-09-20 10:08:21] -devic= e
[2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0
[2022-09-20 10:08:21]= -smp
[2022-09-20 10:08:21] 2,maxcpus=3D2
[2022-09-20 10:08:21] -net<= br>[2022-09-20 10:08:21] none
[2022-09-20 10:08:21] -display
[2022-09= -20 10:08:21] qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 10:08:21] -m= achine
[2022-09-20 10:08:21] xenfv
[2022-09-20 10:08:21] -m
[2022-= 09-20 10:08:21] 496
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21= ] file=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cac= he=3Dwriteback
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] fil= e=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3D= writeback
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/= dev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwrite= back'
[2022-09-20 10:08:21] + net_args=3D
[2022-09-20 10:08:21] += sed /^-qubes-net:/d
[2022-09-20 10:08:21] + echo '-xen-domid
[20= 22-09-20 10:08:21] 19
[2022-09-20 10:08:21] -no-shutdown
[2022-09-20 = 10:08:21] -nodefaults
[2022-09-20 10:08:21] -no-user-config
[2022-09-= 20 10:08:21] -name
[2022-09-20 10:08:21] openbsd-71
[2022-09-20 10:08= :21] -display
[2022-09-20 10:08:21] none
[2022-09-20 10:08:21] -devic= e
[2022-09-20 10:08:21] VGA,vgamem_mb=3D16
[2022-09-20 10:08:21] -boo= t
[2022-09-20 10:08:21] order=3Ddc
[2022-09-20 10:08:21] -device
[= 2022-09-20 10:08:21] usb-ehci,id=3Dehci
[2022-09-20 10:08:21] -device[2022-09-20 10:08:21] usb-tablet,bus=3Dehci.0
[2022-09-20 10:08:21] -sm= p
[2022-09-20 10:08:21] 2,maxcpus=3D2
[2022-09-20 10:08:21] -net
[= 2022-09-20 10:08:21] none
[2022-09-20 10:08:21] -display
[2022-09-20 = 10:08:21] qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 10:08:21] -machi= ne
[2022-09-20 10:08:21] xenfv
[2022-09-20 10:08:21] -m
[2022-09-2= 0 10:08:21] 496
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] fi= le=3D/dev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache= =3Dwriteback
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file= =3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dw= riteback
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/d= ev/xvdc,if=3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteb= ack'
[2022-09-20 10:08:21] + dm_args=3D'-xen-domid
[2022-09-2= 0 10:08:21] 19
[2022-09-20 10:08:21] -no-shutdown
[2022-09-20 10:08:2= 1] -nodefaults
[2022-09-20 10:08:21] -no-user-config
[2022-09-20 10:0= 8:21] -name
[2022-09-20 10:08:21] openbsd-71
[2022-09-20 10:08:21] -d= isplay
[2022-09-20 10:08:21] none
[2022-09-20 10:08:21] -device
[2= 022-09-20 10:08:21] VGA,vgamem_mb=3D16
[2022-09-20 10:08:21] -boot
[2= 022-09-20 10:08:21] order=3Ddc
[2022-09-20 10:08:21] -device
[2022-09= -20 10:08:21] usb-ehci,id=3Dehci
[2022-09-20 10:08:21] -device
[2022-= 09-20 10:08:21] usb-tablet,bus=3Dehci.0
[2022-09-20 10:08:21] -smp
[2= 022-09-20 10:08:21] 2,maxcpus=3D2
[2022-09-20 10:08:21] -net
[2022-09= -20 10:08:21] none
[2022-09-20 10:08:21] -display
[2022-09-20 10:08:2= 1] qubes-gui,domid=3D0,log-level=3D0
[2022-09-20 10:08:21] -machine
[= 2022-09-20 10:08:21] xenfv
[2022-09-20 10:08:21] -m
[2022-09-20 10:08= :21] 496
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/d= ev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteb= ack
[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xv= db,if=3Dide,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdc,if= =3Dide,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'[2022-09-20 10:08:21] + test -e /sys/class/net/eth0
[2022-09-20 10:08:= 21] + echo 'No network interface named eth0.'
[2022-09-20 10:08:= 21] No network interface named eth0.
[2022-09-20 10:08:21] + ls -l /sys/= class/net/
[2022-09-20 10:08:21] total 0
[2022-09-20 10:08:21] lrwxrw= xrwx =C2=A0 =C2=A01 root =C2=A0 =C2=A0 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A00 Sep 20 08:08 .[1;36mlo.[m -> .[1;34m../../devices= /virtual/net/lo.[m
[2022-09-20 10:08:21] + xenstore-read target
[2022= -09-20 10:08:21] + target=3D19
[2022-09-20 10:08:21] + device_model=3Dde= vice-model/19
[2022-09-20 10:08:21] + mkdir /tmp/qmp
[2022-09-20 10:0= 8:21] + kernel=3D
[2022-09-20 10:08:21] + grep -q ^-append
[2022-09-2= 0 10:08:21] + echo '-xen-domid
[2022-09-20 10:08:21] 19
[2022-09-= 20 10:08:21] -no-shutdown
[2022-09-20 10:08:21] -nodefaults
[2022-09-= 20 10:08:21] -no-user-config
[2022-09-20 10:08:21] -name
[2022-09-20 = 10:08:21] openbsd-71
[2022-09-20 10:08:21] -display
[2022-09-20 10:08= :21] none
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] VGA,vga= mem_mb=3D16
[2022-09-20 10:08:21] -boot
[2022-09-20 10:08:21] order= =3Ddc
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] usb-ehci,id= =3Dehci
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] usb-table= t,bus=3Dehci.0
[2022-09-20 10:08:21] -smp
[2022-09-20 10:08:21] 2,max= cpus=3D2
[2022-09-20 10:08:21] -net
[2022-09-20 10:08:21] none
[20= 22-09-20 10:08:21] -display
[2022-09-20 10:08:21] qubes-gui,domid=3D0,lo= g-level=3D0
[2022-09-20 10:08:21] -machine
[2022-09-20 10:08:21] xenf= v
[2022-09-20 10:08:21] -m
[2022-09-20 10:08:21] 496
[2022-09-20 1= 0:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,index=3D= 0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 10:08:= 21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index=3D1,med= ia=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 10:08:21] -= drive
[2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,media=3D= disk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-20 10:08:21] += mkfifo /tmp/qmp/qemu.in /tmp/qmp/qemu.out[2022-09-20 10:08:21] + set +x
[2022-09-20 10:08:21] Clearing kmsg buf= fer...
[2022-09-20 10:08:21] + set +x
[2022-09-20 10:08:21] + set +x<= br>[2022-09-20 10:08:21] + sed 's/\$STUBDOM_RESTORE_INCOMING_ARG/fd:3/&= #39;
[2022-09-20 10:08:21] + echo '-xen-domid
[2022-09-20 10:08:2= 1] 19
[2022-09-20 10:08:21] -no-shutdown
[2022-09-20 10:08:21] -nodef= aults
[2022-09-20 10:08:21] -no-user-config
[2022-09-20 10:08:21] -na= me
[2022-09-20 10:08:21] openbsd-71
[2022-09-20 10:08:21] -display[2022-09-20 10:08:21] none
[2022-09-20 10:08:21] -device
[2022-09-20= 10:08:21] VGA,vgamem_mb=3D16
[2022-09-20 10:08:21] -boot
[2022-09-20= 10:08:21] order=3Ddc
[2022-09-20 10:08:21] -device
[2022-09-20 10:08= :21] usb-ehci,id=3Dehci
[2022-09-20 10:08:21] -device
[2022-09-20 10:= 08:21] usb-tablet,bus=3Dehci.0
[2022-09-20 10:08:21] -smp
[2022-09-20= 10:08:21] 2,maxcpus=3D2
[2022-09-20 10:08:21] -net
[2022-09-20 10:08= :21] none
[2022-09-20 10:08:21] -display
[2022-09-20 10:08:21] qubes-= gui,domid=3D0,log-level=3D0
[2022-09-20 10:08:21] -machine
[2022-09-2= 0 10:08:21] xenfv
[2022-09-20 10:08:21] -m
[2022-09-20 10:08:21] 496<= br>[2022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvda,i= f=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2= 022-09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Di= de,index=3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-0= 9-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,in= dex=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-0= 9-20 10:08:21] + dm_args=3D'-xen-domid
[2022-09-20 10:08:21] 19
[= 2022-09-20 10:08:21] -no-shutdown
[2022-09-20 10:08:21] -nodefaults
[= 2022-09-20 10:08:21] -no-user-config
[2022-09-20 10:08:21] -name
[202= 2-09-20 10:08:21] openbsd-71
[2022-09-20 10:08:21] -display
[2022-09-= 20 10:08:21] none
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21]= VGA,vgamem_mb=3D16
[2022-09-20 10:08:21] -boot
[2022-09-20 10:08:21]= order=3Ddc
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] usb-e= hci,id=3Dehci
[2022-09-20 10:08:21] -device
[2022-09-20 10:08:21] usb= -tablet,bus=3Dehci.0
[2022-09-20 10:08:21] -smp
[2022-09-20 10:08:21]= 2,maxcpus=3D2
[2022-09-20 10:08:21] -net
[2022-09-20 10:08:21] none<= br>[2022-09-20 10:08:21] -display
[2022-09-20 10:08:21] qubes-gui,domid= =3D0,log-level=3D0
[2022-09-20 10:08:21] -machine
[2022-09-20 10:08:2= 1] xenfv
[2022-09-20 10:08:21] -m
[2022-09-20 10:08:21] 496
[2022-= 09-20 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvda,if=3Dide,i= ndex=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20= 10:08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdb,if=3Dide,index= =3D1,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback
[2022-09-20 10:= 08:21] -drive
[2022-09-20 10:08:21] file=3D/dev/xvdc,if=3Dide,index=3D2,= media=3Ddisk,format=3Dhost_device,cache=3Dwriteback'
[2022-09-20 10:= 08:21] + xenstore-read device/console/2
[2022-09-20 10:08:21] + xenstore= -read device/console/1
[2022-09-20 10:08:21] + IFS=3D'
[2022-09-2= 0 10:08:21] '
[2022-09-20 10:08:21] + set -f
[2022-09-20 10:08:21= ] + set +f
[2022-09-20 10:08:21] + unset IFS
[2022-09-20 10:08:21] + = qemu_pid=3D148
[2022-09-20 10:08:21] + '[' '!' -e /tmp/q= emu.qmp ]
[2022-09-20 10:08:21] + sleep 0.1
[2022-09-20 10:08:21] + q= emu -sandbox 'on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,= resourcecontrol=3Ddeny' -chardev 'pipe,path=3D/tmp/qmp/qemu,id=3Dm&= #39; -mon 'chardev=3Dm,mode=3Dcontrol' -chardev 'socket,server,= nowait,path=3D/tmp/qemu.qmp,id=3Dm2' -mon 'chardev=3Dm2,mode=3Dcont= rol' -xen-domid 19 -no-shutdown -nodefaults -no-user-config -name openb= sd-71 -display none -device 'VGA,vgamem_mb=3D16' -boot 'order= =3Ddc' -device 'usb-ehci,id=3Dehci' -device 'usb-tablet,bus= =3Dehci.0' -smp '2,maxcpus=3D2' -net none -display 'qubes-g= ui,domid=3D0,log-level=3D0' -machine xenfv -m 496 -drive 'file=3D/d= ev/xvda,if=3Dide,index=3D0,media=3Ddisk,format=3Dhost_device,cache=3Dwriteb= ack' -drive 'file=3D/dev/xvdb,if=3Dide,index=3D1,media=3Ddisk,forma= t=3Dhost_device,cache=3Dwriteback' -drive 'file=3D/dev/xvdc,if=3Did= e,index=3D2,media=3Ddisk,format=3Dhost_device,cache=3Dwriteback' -devic= e 'nec-usb-xhci,id=3Dxhci'
[2022-09-20 10:08:21] qemu: -chardev = socket,server,nowait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form bool= ean option 'server' deprecated
[2022-09-20 10:08:21] Please use = server=3Don instead
[2022-09-20 10:08:21] qemu: -chardev socket,server,n= owait,path=3D/tmp/qemu.qmp,id=3Dm2: warning: short-form boolean option '= ;nowait' deprecated
[2022-09-20 10:08:21] Please use wait=3Doff inst= ead
[2022-09-20 10:08:21] + tee /proc/self/fd/2
[2022-09-20 10:08:21]= random: qemu: uninitialized urandom read (16 bytes read)
[2022-09-20 10= :08:21] + echo '{"execute": "qmp_capabilities"}'= ;
[2022-09-20 10:08:21] {"QMP": {"version": {"q= emu": {"micro": 0, "minor": 1, "major": = 6}, "package": ""}, "capabilities": ["oo= b"]}}

[2022-09-20 10:08:21] {"execute": "qmp_cap= abilities"}
[2022-09-20 10:08:21] qubes_gui/init: 573
[2022-09-2= 0 10:08:21] qubes_gui/init: 582
[2022-09-20 10:08:21] qubes_gui/init: 58= 4
[2022-09-20 10:08:21] qubes_gui/init[611]: version sent, waiting for x= org conf
[2022-09-20 10:08:21] {"return": {}}

[2022-09-= 20 10:08:21] + '[' '!' -e /tmp/qemu.qmp ]
[2022-09-20 10= :08:21] + '[' -e /proc/self/fd/4 ]
[2022-09-20 10:08:21] + '= [' -e /proc/self/fd/3 ]
[2022-09-20 10:08:21] + true
[2022-09-20 = 10:08:21] + printf '=3D=3D=3D=3D Press enter for shell =3D=3D=3D=3D\n&#= 39;
[2022-09-20 10:08:21] =3D=3D=3D=3D Press enter for shell =3D=3D=3D= =3D
[2022-09-20 10:08:21] + read
[2022-09-20 10:08:21] + vchan-socket= -proxy 0 device-model/19/qmp-vchan /tmp/qemu.qmp
[2022-09-20 10:08:21] w= ritten 110 bytes to vchan
[2022-09-20 10:08:21] written 34 bytes to vcha= n
[2022-09-20 10:08:22] [00:06.0] xen_pt_realize: Assigning real physica= l device 07:00.0 to devfn 0x30
[2022-09-20 10:08:22] [00:06.0] xen_pt_re= gister_regions: IO region 0 registered (size=3D0x00000100 base_addr=3D0x000= 03000 type: 0x1)
[2022-09-20 10:08:22] [00:06.0] xen_pt_register_regions= : IO region 2 registered (size=3D0x00001000 base_addr=3D0xb4304000 type: 0x= 4)
[2022-09-20 10:08:22] [00:06.0] xen_pt_register_regions: IO region 4 = registered (size=3D0x00004000 base_addr=3D0xb4300000 type: 0x4)
[2022-09= -20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x000e mismatch! Emu= lated=3D0x0080, host=3D0x0000, syncing to 0x0000.
[2022-09-20 10:08:22] = [00:06.0] xen_pt_config_reg_init: Offset 0x0010 mismatch! Emulated=3D0x0000= , host=3D0x3001, syncing to 0x3001.
[2022-09-20 10:08:22] [00:06.0] xen_= pt_config_reg_init: Offset 0x0018 mismatch! Emulated=3D0x0000, host=3D0xb43= 04004, syncing to 0xb4304004.
[2022-09-20 10:08:22] [00:06.0] xen_pt_con= fig_reg_init: Offset 0x0020 mismatch! Emulated=3D0x0000, host=3D0xb4300004,= syncing to 0xb4300004.
[2022-09-20 10:08:22] [00:06.0] xen_pt_config_re= g_init: Offset 0x0042 mismatch! Emulated=3D0x0000, host=3D0x07c3, syncing t= o 0x0603.
[2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset= 0x0052 mismatch! Emulated=3D0x0000, host=3D0x0080, syncing to 0x0080.
[= 2022-09-20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x0074 mismat= ch! Emulated=3D0x0000, host=3D0x5908cc0, syncing to 0x5908cc0.
[2022-09-= 20 10:08:22] [00:06.0] xen_pt_config_reg_init: Offset 0x007a mismatch! Emul= ated=3D0x0000, host=3D0x0010, syncing to 0x0010.
[2022-09-20 10:08:22] [= 00:06.0] xen_pt_config_reg_init: Offset 0x0082 mismatch! Emulated=3D0x0000,= host=3D0x1011, syncing to 0x1011.
[2022-09-20 10:08:22] [00:06.0] xen_p= t_pci_intx: intx=3D1
[2022-09-20 10:08:22] [00:06.0] xen_pt_realize: Rea= l physical device 07:00.0 registered successfully
[2022-09-20 10:08:22] = written 34 bytes to vchan
[2022-09-20 10:08:22] written 2048 bytes to vc= han
[2022-09-20 10:08:22] written 979 bytes to vchan
[2022-09-20 10:0= 8:22] written 110 bytes to vchan
[2022-09-20 10:08:22] written 34 bytes = to vchan
[2022-09-20 10:08:22] written 34 bytes to vchan
[2022-09-20 = 10:08:22] qubes_gui/init[622]: got xorg conf, creating window
[2022-09-2= 0 10:08:22] qubes_gui/init: 632
[2022-09-20 10:08:22] configure msg, x/y= 640 325 (was 0 0), w/h 640 480
[2022-09-20 10:08:23] random: crng init = done
[2022-09-20 10:08:43] [00:06.0] Write-back to unknown field 0x44 (p= artially) inhibited (0x0000ffff)
[2022-09-20 10:08:43] [00:06.0] If the = device doesn't work, try enabling permissive mode
[2022-09-20 10:08:= 43] [00:06.0] (unsafe) and if it helps report the problem to xen-devel
[= 2022-09-20 10:08:43] [00:06.0] xen_pt_msgctrl_reg_write: setup MSI (registe= r: 81).
[2022-09-20 10:08:43] [00:06.0] xen_pt_msi_setup: MSI mapped wit= h pirq 151.
[2022-09-20 10:08:43] [00:06.0] msi_msix_update: Updating MS= I with pirq 151 gvec 0x72 gflags 0x0 (entry: 0x0)

= BR Adam




wt., 20 wrz 2= 022 o 09:41=C2=A0Adam Szewczyk <sz= ewcson@gmail.com> napisa=C5=82(a):
(XEN) Built-in command line: ept=3Dexec-sp spec-ctrl=3Dun= priv-mmio
(XEN) parameter "no-real-mode" unknown!
=C2=A0Xen= 4.14.5
(XEN) Xen version 4.14.5 (mockbuild@[unknown]) (gcc (GCC) 10.3.1= 20210422 (Red Hat 10.3.1-1)) debug=3Dn =C2=A0Wed Aug 24 00:00:00 UTC 2022<= br>(XEN) Latest ChangeSet:
(XEN) Bootloader: GRUB 2.04
(XEN) Command= line: placeholder console=3Dnone dom0_mem=3Dmin:1024M dom0_mem=3Dmax:4096M= ucode=3Dscan smt=3Doff gnttab_max_frames=3D2048 gnttab_max_maptrack_frames= =3D4096 no-real-mode edd=3Doff
(XEN) Xen image load base address: 0x9c20= 0000
(XEN) Video information:
(XEN) =C2=A0VGA is graphics mode 1920x1= 080, 32 bpp
(XEN) Disc information:
(XEN) =C2=A0Found 0 MBR signature= s
(XEN) =C2=A0Found 2 EDD information structures
(XEN) EFI RAM map:(XEN) =C2=A0[0000000000000000, 000000000009efff] (usable)
(XEN) =C2=A0= [000000000009f000, 00000000000fffff] (reserved)
(XEN) =C2=A0[00000000001= 00000, 0000000086466fff] (usable)
(XEN) =C2=A0[0000000086467000, 0000000= 086d66fff] (reserved)
(XEN) =C2=A0[0000000086d67000, 000000009cf7dfff] (= usable)
(XEN) =C2=A0[000000009cf7e000, 000000009e49dfff] (reserved)
(= XEN) =C2=A0[000000009e49e000, 000000009eb8dfff] (ACPI NVS)
(XEN) =C2=A0[= 000000009eb8e000, 000000009ec0dfff] (ACPI data)
(XEN) =C2=A0[000000009ec= 0e000, 000000009ec0efff] (usable)
(XEN) =C2=A0[000000009ec0f000, 0000000= 09fffffff] (reserved)
(XEN) =C2=A0[00000000e0000000, 00000000efffffff] (= reserved)
(XEN) =C2=A0[00000000fe000000, 00000000fe010fff] (reserved)(XEN) =C2=A0[00000000fed10000, 00000000fed19fff] (reserved)
(XEN) =C2= =A0[00000000fed84000, 00000000fed84fff] (reserved)
(XEN) =C2=A0[00000000= fee00000, 00000000fee00fff] (reserved)
(XEN) =C2=A0[00000000ff600000, 00= 000000ffffffff] (reserved)
(XEN) =C2=A0[0000000100000000, 000000085dffff= ff] (usable)
(XEN) ACPI: RSDP 9EC0D014, 0024 (r2 LENOVO)
(XEN) ACPI: = XSDT 9EBEE188, 00FC (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 = =C2=A0 =C2=A0 =C2=A0 1000013)
(XEN) ACPI: FACP 9EBF1000, 010C (r5 LENOVO= CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XE= N) ACPI: DSDT 9EBBD000, 2FF34 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: FACS 9EB0D000, 0040
(XE= N) ACPI: UEFI 9EC0C000, 0236 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EC0A000, 1B1C (r2 LE= NOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)(XEN) ACPI: SSDT 9EC06000, 31D0 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: UEFI 9EC05000, 0042 (r= 1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000= )
(XEN) ACPI: SSDT 9EC04000, 045A (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EC03000, 0046= (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040= 000)
(XEN) ACPI: TPM2 9EC02000, 0034 (r3 LENOVO CB-01 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: POAT 9EC01000, = 0055 (r3 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2= =A040000)
(XEN) ACPI: SSDT 9EBFC000, 44B6 (r2 LENOVO CB-01 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: LPIT 9EBFB0= 00, 0094 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 = =C2=A040000)
(XEN) ACPI: WSMT 9EBFA000, 0028 (r1 LENOVO CB-01 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EB= F9000, 0C2F (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2= =A0 =C2=A040000)
(XEN) ACPI: DBGP 9EBF8000, 0034 (r1 LENOVO CB-01 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: DBG2= 9EBF7000, 0061 (r0 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI = =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EBF6000, 0896 (r2 LENOVO CB-01 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: S= SDT 9EBF3000, 2F89 (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 AC= PI =C2=A0 =C2=A040000)
(XEN) ACPI: ASF! 9EBF2000, 00A5 (r32 LENOVO CB-01= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACP= I: HPET 9EBF0000, 0038 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: APIC 9EBEF000, 012C (r3 LENOVO CB= -01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) = ACPI: MCFG 9EBED000, 003C (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EBBA000, 2BBF (r2 LENOV= O CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(X= EN) ACPI: DMAR 9EBB9000, 0070 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: SSDT 9EBB6000, 2B68 (r1 LE= NOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)(XEN) ACPI: SSDT 9EBB5000, 004C (r2 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) ACPI: FPDT 9EBB4000, 0044 (r= 1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000= )
(XEN) ACPI: BGRT 9EBB3000, 0038 (r1 LENOVO CB-01 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 1 ACPI =C2=A0 =C2=A040000)
(XEN) System RAM: 32678MB (3346= 2392kB)
(XEN) Domain heap initialised
(XEN) ACPI: 32/64X FACS address= mismatch in FADT - 9eb0d000/0000000000000000, using 32
(XEN) IOAPIC[0]:= apic_id 2, version 32, address 0xfec00000, GSI 0-119
(XEN) Enabling API= C mode: =C2=A0Phys.=C2=A0 Using 1 I/O APICs
(XEN) Switched to APIC drive= r x2apic_cluster
(XEN) CPU0: TSC: ratio: 216 / 2
(XEN) CPU0: bus: 100= MHz base: 2600 MHz max: 4500 MHz
(XEN) CPU0: 800 ... 2600 MHz
(XEN) = xstate: size: 0x440 and states: 0x1f
(XEN) Speculative mitigation facili= ties:
(XEN) =C2=A0 Hardware hints: RSBA
(XEN) =C2=A0 Hardware feature= s: IBPB IBRS STIBP SSBD L1D_FLUSH MD_CLEAR SRBDS_CTRL
(XEN) =C2=A0 Compi= led-in support: INDIRECT_THUNK
(XEN) =C2=A0 Xen settings: BTI-Thunk JMP,= SPEC_CTRL: IBRS+ STIBP+ SSBD-, Other: SRB_LOCK+ IBPB-ctxt L1D_FLUSH VERW B= RANCH_HARDEN
(XEN) =C2=A0 L1TF: believed vulnerable, maxphysaddr L1D 46,= CPUID 39, Safe address 8000000000
(XEN) =C2=A0 Support for HVM VMs: MSR= _SPEC_CTRL RSB EAGER_FPU MD_CLEAR
(XEN) =C2=A0 Support for PV VMs: MSR_S= PEC_CTRL EAGER_FPU MD_CLEAR
(XEN) =C2=A0 XPTI (64-bit PV only): Dom0 ena= bled, DomU enabled (with PCID)
(XEN) =C2=A0 PV L1TF shadowing: Dom0 disa= bled, DomU enabled
(XEN) Using scheduler: SMP Credit Scheduler rev2 (cre= dit2)
(XEN) Initializing Credit2 scheduler
(XEN) Disabling HPET for b= eing unreliable
(XEN) Platform timer is 3.580MHz ACPI PM Timer
(XEN) = Detected 2591.999 MHz processor.
(XEN) Unknown cachability for MFNs 0xa0= -0xff
(XEN) Unknown cachability for MFNs 0x9f000-0x9ffff
(XEN) Intel = VT-d iommu 0 supported page sizes: 4kB, 2MB, 1GB
(XEN) Intel VT-d Snoop = Control enabled.
(XEN) Intel VT-d Dom0 DMA Passthrough not enabled.
(= XEN) Intel VT-d Queued Invalidation enabled.
(XEN) Intel VT-d Interrupt = Remapping enabled.
(XEN) Intel VT-d Posted Interrupt not enabled.
(XE= N) Intel VT-d Shared EPT tables enabled.
(XEN) I/O virtualisation enable= d
(XEN) =C2=A0- Dom0 mode: Relaxed
(XEN) Interrupt remapping enabled<= br>(XEN) Enabled directed EOI with ioapic_ack_old on!
(XEN) ENABLING IO-= APIC IRQs
(XEN) =C2=A0-> Using old ACK method
(XEN) Allocated cons= ole ring of 32 KiB.
(XEN) VMX: Supported advanced features:
(XEN) =C2= =A0- APIC MMIO access virtualisation
(XEN) =C2=A0- APIC TPR shadow
(X= EN) =C2=A0- Extended Page Tables (EPT)
(XEN) =C2=A0- Virtual-Processor I= dentifiers (VPID)
(XEN) =C2=A0- Virtual NMI
(XEN) =C2=A0- MSR direct-= access bitmap
(XEN) =C2=A0- Unrestricted Guest
(XEN) =C2=A0- VM Funct= ions
(XEN) =C2=A0- Virtualisation Exceptions
(XEN) =C2=A0- Page Modif= ication Logging
(XEN) HVM: ASIDs enabled.
(XEN) HVM: VMX enabled
(= XEN) HVM: Hardware Assisted Paging (HAP) detected
(XEN) HVM: HAP page si= zes: 4kB, 2MB, 1GB
(XEN) Brought up 6 CPUs
(XEN) Scheduling granulari= ty: cpu, 1 CPU per sched-resource
(XEN) Dom0 has maximum 952 PIRQs
(X= EN) =C2=A0Xen =C2=A0kernel: 64-bit, lsb, compat32
(XEN) =C2=A0Dom0 kerne= l: 64-bit, PAE, lsb, paddr 0x1000000 -> 0x4000000
(XEN) PHYSICAL MEMO= RY ARRANGEMENT:
(XEN) =C2=A0Dom0 alloc.: =C2=A0 0000000838000000->000= 0000840000000 (1007932 pages to be allocated)
(XEN) =C2=A0Init. ramdisk:= 000000085c13c000->000000085dffff1d
(XEN) VIRTUAL MEMORY ARRANGEMENT:=
(XEN) =C2=A0Loaded kernel: ffffffff81000000->ffffffff84000000
(XE= N) =C2=A0Init. ramdisk: 0000000000000000->0000000000000000
(XEN) =C2= =A0Phys-Mach map: 0000008000000000->0000008000800000
(XEN) =C2=A0Star= t info: =C2=A0 =C2=A0ffffffff84000000->ffffffff840004b8
(XEN) =C2=A0X= enstore ring: 0000000000000000->0000000000000000
(XEN) =C2=A0Console = ring: =C2=A00000000000000000->0000000000000000
(XEN) =C2=A0Page table= s: =C2=A0 ffffffff84001000->ffffffff84026000
(XEN) =C2=A0Boot stack: = =C2=A0 =C2=A0ffffffff84026000->ffffffff84027000
(XEN) =C2=A0TOTAL: = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ffffffff80000000->ffffffff84400000
(XEN) = =C2=A0ENTRY ADDRESS: ffffffff830fb1c0
(XEN) Dom0 has maximum 6 VCPUs
= (XEN) Initial low memory virq threshold set at 0x4000 pages.
(XEN) Scrub= bing Free RAM in background
(XEN) Std. Loglevel: Errors and warnings
= (XEN) Guest Loglevel: Nothing (Rate-limited: Errors and warnings)
(XEN) = *** Serial input to DOM0 (type 'CTRL-a' three times to switch input= )
(XEN) Freed 580kB init memory
(XEN) MSI information:
(XEN) =C2= =A0IOMMU =C2=A0120 vec=3D30 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowes= t dest=3D00000001 mask=3D1/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0121 ve= c=3Dc8 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mas= k=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0122 vec=3Dd0 lowest =C2=A0e= dge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(X= EN) =C2=A0MSI =C2=A0 =C2=A0123 vec=3De0 lowest =C2=A0edge =C2=A0 assert =C2= =A0log lowest dest=3D00000001 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 = =C2=A0124 vec=3D31 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000040 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI-X =C2=A0125 vec=3D51 lowest = =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000040 mask=3D1/ =C2=A0/= 0
(XEN) =C2=A0MSI-X =C2=A0126 vec=3D59 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000004 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X = =C2=A0127 vec=3D61 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0128 vec=3D69 lowest = =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D1/ =C2=A0/= 0
(XEN) =C2=A0MSI-X =C2=A0129 vec=3D71 lowest =C2=A0edge =C2=A0 assert = =C2=A0log lowest dest=3D00000010 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X = =C2=A0130 vec=3D79 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000040 mask=3D1/ =C2=A0/0
(XEN) =C2=A0MSI-X =C2=A0131 vec=3D81 lowest = =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000001 mask=3D1/ =C2=A0/= 0
(XEN) =C2=A0MSI =C2=A0 =C2=A0132 vec=3Dd9 lowest =C2=A0edge =C2=A0 ass= ert =C2=A0log lowest dest=3D00000100 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI = =C2=A0 =C2=A0133 vec=3Dc9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest = dest=3D00000004 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0134 vec= =3D99 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask= =3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0135 vec=3Da9 lowest =C2=A0ed= ge =C2=A0 assert =C2=A0log lowest dest=3D00000555 mask=3D0/ =C2=A0/?
(XE= N) =C2=A0MSI =C2=A0 =C2=A0136 vec=3Db1 lowest =C2=A0edge =C2=A0 assert =C2= =A0log lowest dest=3D00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 = =C2=A0137 vec=3Db9 lowest =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D= 00000010 mask=3D0/ =C2=A0/?
(XEN) =C2=A0MSI =C2=A0 =C2=A0138 vec=3Dd1 lo= west =C2=A0edge =C2=A0 assert =C2=A0log lowest dest=3D00000100 mask=3D0/ = =C2=A0/?
(XEN) IRQ information:
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 0 vec:= f0 IO-APIC-edge =C2=A0 =C2=A0status=3D000 aff:{0}/{0} time.c#timer_interrup= t()
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 1 vec:39 IO-APIC-edge =C2=A0 =C2=A0st= atus=3D034 aff:{8}/{0-11} in-flight=3D0 d0: =C2=A01(---)
(XEN) =C2=A0 = =C2=A0IRQ: =C2=A0 3 vec:40 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{= 0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 4 vec:48 IO-APIC-edge = =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2= =A0IRQ: =C2=A0 5 vec:50 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} = mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 6 vec:58 IO-APIC-edge =C2= =A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IR= Q: =C2=A0 7 vec:60 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mappe= d, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A0 8 vec:68 IO-APIC-edge =C2=A0 = =C2=A0status=3D030 aff:{0}/{0} in-flight=3D0 d0: =C2=A08(---)
(XEN) =C2= =A0 =C2=A0IRQ: =C2=A0 9 vec:b0 IO-APIC-level =C2=A0 status=3D030 aff:{8}/{0= -11} in-flight=3D0 d0: =C2=A09(---)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A010 vec= :78 IO-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(= XEN) =C2=A0 =C2=A0IRQ: =C2=A011 vec:88 IO-APIC-edge =C2=A0 =C2=A0status=3D0= 02 aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A012 vec:90 I= O-APIC-edge =C2=A0 =C2=A0status=3D002 aff:{0}/{0} mapped, unbound
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A013 vec:98 IO-APIC-edge =C2=A0 =C2=A0status=3D002 af= f:{0-15}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A014 vec:a0 IO-= APIC-level =C2=A0 status=3D030 aff:{0}/{0} in-flight=3D0 d0: 14(---)
(XE= N) =C2=A0 =C2=A0IRQ: =C2=A015 vec:a8 IO-APIC-edge =C2=A0 =C2=A0status=3D002= aff:{0}/{0} mapped, unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A016 vec:b8 IO-= APIC-level =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d0: 16(---),d3:= 16(-M-)
(XEN) =C2=A0 =C2=A0IRQ: =C2=A017 vec:d8 IO-APIC-level =C2=A0 st= atus=3D010 aff:{10}/{0-11} in-flight=3D2 d0: 17(P-M),d7: 17(-MM)
(XEN) = =C2=A0 =C2=A0IRQ: =C2=A018 vec:c0 IO-APIC-level =C2=A0 status=3D030 aff:{8}= /{0-11} in-flight=3D0 d0: 18(---),d3: 18(-M-)
(XEN) =C2=A0 =C2=A0IRQ: = =C2=A019 vec:a1 IO-APIC-level =C2=A0 status=3D002 aff:{0-15}/{0-11} mapped,= unbound
(XEN) =C2=A0 =C2=A0IRQ: =C2=A020 vec:e8 IO-APIC-level =C2=A0 st= atus=3D030 aff:{0}/{0-11} in-flight=3D0 d0: 20(---)
(XEN) =C2=A0 =C2=A0I= RQ: =C2=A083 vec:41 IO-APIC-level =C2=A0 status=3D030 aff:{4}/{0-11} in-fli= ght=3D0 d0: 83(---)
(XEN) =C2=A0 =C2=A0IRQ: 120 vec:30 DMA_MSI =C2=A0 = =C2=A0 =C2=A0 =C2=A0 status=3D000 aff:{0-15}/{0} iommu.c#iommu_page_fault()=
(XEN) =C2=A0 =C2=A0IRQ: 121 vec:c8 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 = status=3D030 aff:{0}/{0-11} in-flight=3D0 d0:951(---)
(XEN) =C2=A0 =C2= =A0IRQ: 122 vec:d0 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}= /{0-11} in-flight=3D0 d0:950(---)
(XEN) =C2=A0 =C2=A0IRQ: 123 vec:e0 PCI= -MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{0}/{0-11} in-flight=3D0 = d0:949(---)
(XEN) =C2=A0 =C2=A0IRQ: 124 vec:31 PCI-MSI =C2=A0 =C2=A0 =C2= =A0 =C2=A0 status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:948(---)
(XEN) = =C2=A0 =C2=A0IRQ: 125 vec:51 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 af= f:{6}/{0-11} in-flight=3D0 d0:947(---)
(XEN) =C2=A0 =C2=A0IRQ: 126 vec:5= 9 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D010 aff:{2}/{0-11} in-flight=3D0 = d0:946(---)
(XEN) =C2=A0 =C2=A0IRQ: 127 vec:61 PCI-MSI/-X =C2=A0 =C2=A0 = =C2=A0status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:945(---)
(XEN) =C2=A0= =C2=A0IRQ: 128 vec:69 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/= {0-11} in-flight=3D0 d0:944(---)
(XEN) =C2=A0 =C2=A0IRQ: 129 vec:71 PCI-= MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:943= (---)
(XEN) =C2=A0 =C2=A0IRQ: 130 vec:79 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0= status=3D030 aff:{6}/{0-11} in-flight=3D0 d0:942(---)
(XEN) =C2=A0 =C2= =A0IRQ: 131 vec:81 PCI-MSI/-X =C2=A0 =C2=A0 =C2=A0status=3D030 aff:{0}/{0-1= 1} in-flight=3D0 d0:941(---)
(XEN) =C2=A0 =C2=A0IRQ: 132 vec:d9 PCI-MSI = =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 aff:{8}/{0-11} in-flight=3D0 d7:15= 1(-M-)
(XEN) =C2=A0 =C2=A0IRQ: 133 vec:c9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 = =C2=A0 status=3D030 aff:{2}/{0-11} in-flight=3D0 d3:151(---)
(XEN) =C2= =A0 =C2=A0IRQ: 134 vec:99 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D030 = aff:{8}/{0-11} in-flight=3D0 d0:938(---)
(XEN) =C2=A0 =C2=A0IRQ: 135 vec= :a9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D002 aff:{0-15}/{0-11} mapp= ed, unbound
(XEN) =C2=A0 =C2=A0IRQ: 136 vec:b1 PCI-MSI =C2=A0 =C2=A0 =C2= =A0 =C2=A0 status=3D030 aff:{4}/{0-11} in-flight=3D0 d0:936(---)
(XEN) = =C2=A0 =C2=A0IRQ: 137 vec:b9 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D0= 30 aff:{4}/{0-11} in-flight=3D0 d0:935(---)
(XEN) =C2=A0 =C2=A0IRQ: 138 = vec:d1 PCI-MSI =C2=A0 =C2=A0 =C2=A0 =C2=A0 status=3D010 aff:{8}/{0-11} in-f= light=3D0 d3:150(---)
(XEN) Direct vector information:
(XEN) =C2=A0 = =C2=A00x22 -> irq_move_cleanup_interrupt()
(XEN) =C2=A0 =C2=A00xf1 -&= gt; mce_intel.c#cmci_interrupt()
(XEN) =C2=A0 =C2=A00xf2 -> mce_intel= .c#intel_thermal_interrupt()
(XEN) =C2=A0 =C2=A00xf9 -> pmu_apic_inte= rrupt()
(XEN) =C2=A0 =C2=A00xfa -> apic_timer_interrupt()
(XEN) = =C2=A0 =C2=A00xfb -> call_function_interrupt()
(XEN) =C2=A0 =C2=A00xf= c -> event_check_interrupt()
(XEN) =C2=A0 =C2=A00xfd -> invalidate= _interrupt()
(XEN) =C2=A0 =C2=A00xfe -> error_interrupt()
(XEN) = =C2=A0 =C2=A00xff -> spurious_interrupt()
(XEN) IO-APIC interrupt inf= ormation:
(XEN) =C2=A0 =C2=A0 IRQ =C2=A00 Vec240:
(XEN) =C2=A0 =C2=A0= =C2=A0 Apic 0x00, Pin =C2=A02: vec=3Df0 delivery=3DLoPri dest=3DL status= =3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A01 Vec 57:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A01: vec=3D39 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000100
(XEN) =C2=A0 =C2=A0 IRQ =C2=A03 Vec= 64:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A03: vec=3D40 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_i= d:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A04 Vec 72:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin =C2=A04: vec=3D48 delivery=3DLoPri dest=3DL statu= s=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A05 Vec 80:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A05: vec=3D50 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A06 Vec= 88:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A06: vec=3D58 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_i= d:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A07 Vec 96:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin =C2=A07: vec=3D60 delivery=3DLoPri dest=3DL statu= s=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2= =A0 =C2=A0 IRQ =C2=A08 Vec104:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin= =C2=A08: vec=3D68 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D= 0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ =C2=A09 Vec= 176:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin =C2=A09: vec=3Db0 deliver= y=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DL mask=3D0 dest_i= d:00000100
(XEN) =C2=A0 =C2=A0 IRQ 10 Vec120:
(XEN) =C2=A0 =C2=A0 =C2= =A0 Apic 0x00, Pin 10: vec=3D78 delivery=3DLoPri dest=3DL status=3D0 polari= ty=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IR= Q 11 Vec136:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 11: vec=3D88 deli= very=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D0 des= t_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 12 Vec144:
(XEN) =C2=A0 =C2=A0 = =C2=A0 Apic 0x00, Pin 12: vec=3D90 delivery=3DLoPri dest=3DL status=3D0 pol= arity=3D0 irr=3D0 trig=3DE mask=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0= IRQ 13 Vec152:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 13: vec=3D98 d= elivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE mask=3D1 = dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 14 Vec160:
(XEN) =C2=A0 =C2= =A0 =C2=A0 Apic 0x00, Pin 14: vec=3Da0 delivery=3DLoPri dest=3DL status=3D0= polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001
(XEN) =C2=A0 = =C2=A0 IRQ 15 Vec168:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 15: vec= =3Da8 delivery=3DLoPri dest=3DL status=3D0 polarity=3D0 irr=3D0 trig=3DE ma= sk=3D0 dest_id:00000001
(XEN) =C2=A0 =C2=A0 IRQ 16 Vec184:
(XEN) =C2= =A0 =C2=A0 =C2=A0 Apic 0x00, Pin 16: vec=3Db8 delivery=3DLoPri dest=3DL sta= tus=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000004
(XEN) = =C2=A0 =C2=A0 IRQ 17 Vec216:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 1= 7: vec=3Dd8 delivery=3DLoPri dest=3DL status=3D1 polarity=3D1 irr=3D1 trig= =3DL mask=3D0 dest_id:00000400
(XEN) =C2=A0 =C2=A0 IRQ 18 Vec192:
(XE= N) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 18: vec=3Dc0 delivery=3DLoPri dest= =3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000100
= (XEN) =C2=A0 =C2=A0 IRQ 19 Vec161:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00,= Pin 19: vec=3Da1 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr=3D0= trig=3DL mask=3D1 dest_id:00000555
(XEN) =C2=A0 =C2=A0 IRQ 20 Vec232:(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x00, Pin 20: vec=3De8 delivery=3DLoPri d= est=3DL status=3D0 polarity=3D1 irr=3D0 trig=3DL mask=3D0 dest_id:00000001<= br>(XEN) =C2=A0 =C2=A0 IRQ 83 Vec 65:
(XEN) =C2=A0 =C2=A0 =C2=A0 Apic 0x= 00, Pin 83: vec=3D41 delivery=3DLoPri dest=3DL status=3D0 polarity=3D1 irr= =3D0 trig=3DL mask=3D0 dest_id:00000010

=C2=A0Name =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ID =C2=A0 Mem VCPUs State T= ime(s)
Domain-0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0 =C2= =A04080 =C2=A0 =C2=A0 6 =C2=A0 =C2=A0 r----- =C2=A0 =C2=A0 288.6
sys-usb= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A03 =C2=A0 284 =C2= =A0 =C2=A0 2 =C2=A0 =C2=A0 -b---- =C2=A0 =C2=A0 =C2=A020.5
sys-usb-dm = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4 =C2=A0 144 =C2=A0 =C2=A0 1 = =C2=A0 =C2=A0 -b---- =C2=A0 =C2=A0 =C2=A0 3.5
openbsd-71 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 7 =C2=A0 511 =C2=A0 =C2=A0 2 =C2=A0 =C2=A0 = -b---- =C2=A0 =C2=A0 =C2=A063.0
openbsd-71-dm =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A08 =C2=A0 144 =C2=A0 =C2=A0 1 =C2=A0 =C2=A0 -b---- =C2=A0 =C2= =A0 =C2=A014.0

How I can enable insta= ll this debug hypervisor? I have problems finding anything about it.
<= div>
I don't have logs with qemu in the name, instead I h= ave gmp-proxy logs. But their all looks empty.

BR = Adam

pon., 19 wrz 2022 o 11:21=C2=A0Roger Pau Monn=C3=A9 <roger.pau@citrix.com= > napisa=C5=82(a):
On Fri, Sep 16, 2022 at 05:08:59PM +0200, Adam Szewczyk wrote: > Sorry, I always forgot that default answer is "answer" to no= t "answer to
> all".
>
> My xl dmesg after calling those debug-keys is:

Trimming the trace:

> (XEN) MSI information:

> (XEN)=C2=A0 MSI=C2=A0 =C2=A0 125 vec=3D72 lowest=C2=A0 edge=C2=A0 =C2= =A0assert=C2=A0 log lowest dest=3D00000100
> mask=3D0/=C2=A0 /?

> (XEN)=C2=A0 MSI=C2=A0 =C2=A0 138 vec=3D62 lowest=C2=A0 edge=C2=A0 =C2= =A0assert=C2=A0 log lowest dest=3D00000001
> mask=3D0/=C2=A0 /?
> (XEN)=C2=A0 MSI=C2=A0 =C2=A0 139 vec=3D6a lowest=C2=A0 edge=C2=A0 =C2= =A0assert=C2=A0 log lowest dest=3D00000010
> mask=3D0/=C2=A0 /?

> (XEN) IRQ information:

> (XEN)=C2=A0 =C2=A0 IRQ: 125 vec:72 PCI-MSI=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0status=3D030 aff:{8}/{0-11}
> in-flight=3D0 d94:151(-M-)

> (XEN)=C2=A0 =C2=A0 IRQ: 138 vec:62 PCI-MSI=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0status=3D030 aff:{0}/{0-11}
> in-flight=3D0 d92:151(---)
> (XEN)=C2=A0 =C2=A0 IRQ: 139 vec:6a PCI-MSI=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0status=3D010 aff:{4}/{0-11}
> in-flight=3D0 d92:150(---)

Was domain with ID 94 your OpenBSD box? There's another domain with
passthrough devices (ID 92).

If your OpenBSD domain is the one with ID 94 it seems like the
interrupt source is masked, so no interrupts will be injected to the
guest.=C2=A0 That however might be just the response from the guest after seeing that the interrupt source is not behaving correctly.

Are yuo using a debug hypervisor? If not it would be helpful to do so,
in order to maybe get more information on `xl dmesg`.

Can you also paste the QEMU log for the OpeNSD domain?=C2=A0 Those logs are=
in /var/log/xen/qemu-dm-<domain name>.log, on most distros, not sure<= br> if QubesOS puts them at the same place.

Regards, Roger.
--000000000000344bfe05e9176609-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 08:39:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 08:39:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409219.652171 (Exim 4.92) (envelope-from ) id 1oaYmQ-000628-67; Tue, 20 Sep 2022 08:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409219.652171; Tue, 20 Sep 2022 08:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYmQ-000621-31; Tue, 20 Sep 2022 08:38:58 +0000 Received: by outflank-mailman (input) for mailman id 409219; Tue, 20 Sep 2022 08:38:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYmP-00061r-3v; Tue, 20 Sep 2022 08:38:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYmP-0005vH-0P; Tue, 20 Sep 2022 08:38:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYmO-0004i4-D5; Tue, 20 Sep 2022 08:38:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oaYmO-0005q2-CZ; Tue, 20 Sep 2022 08:38:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HgC3+P6c3GU5E2NykHp7pIkE1h1HGSq6AjvR55AXK0Y=; b=RtGhIhvFBIoj8SCaZQALMqu6Vh S9+3bAQ09asDKsUK1i9g/PIFvzMBT/Vx9/oB4ByGLtufHDRWsoQXvZyGOU1bYO996qQQURpvKkSzn Nh8TEvWMyKPYWzmJYDD5ZiEgRtd9dIVMoYsmtsKQt/nRqjOPnajmL9EMp3M3UGEVNcPw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173259: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Tue, 20 Sep 2022 08:38:56 +0000 flight 173259 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173259/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173254 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173258 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173258 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173258 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173258 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173258 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173258 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173258 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173258 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173258 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173258 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173258 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173258 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173259 2022-09-20 01:54:44 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 08:50:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 08:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409226.652182 (Exim 4.92) (envelope-from ) id 1oaYxD-0008KT-8U; Tue, 20 Sep 2022 08:50:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409226.652182; Tue, 20 Sep 2022 08:50:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYxD-0008KM-4r; Tue, 20 Sep 2022 08:50:07 +0000 Received: by outflank-mailman (input) for mailman id 409226; Tue, 20 Sep 2022 08:50:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaYxC-0008BU-DI for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 08:50:06 +0000 Received: from zero.eik.bme.hu (zero.eik.bme.hu [152.66.115.2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 377ef738-38c1-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 10:50:04 +0200 (CEST) Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 39177746335; Tue, 20 Sep 2022 10:50:02 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id E0C2A74632C; Tue, 20 Sep 2022 10:50:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id DBD6474632B; Tue, 20 Sep 2022 10:50:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 377ef738-38c1-11ed-9647-05401a9f4f97 Date: Tue, 20 Sep 2022 10:50:01 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= cc: Bernhard Beschow , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-15?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-15?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-15?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 8/9] softmmu/physmem: Let SysBusState absorb memory region and address space singletons In-Reply-To: Message-ID: References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-9-shentey@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1142243070-1663663801=:43449" X-Spam-Checker-Version: Sophos PMX: 6.4.8.2820816, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2022.9.20.84220, AntiVirus-Engine: 5.93.0, AntiVirus-Data: 2022.9.15.5930000 X-Spam-Flag: NO X-Spam-Probability: 9% X-Spam-Level: X-Spam-Status: No, score=9% required=50% This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1142243070-1663663801=:43449 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 20 Sep 2022, Philippe Mathieu-Daudé via wrote: > On 20/9/22 01:17, Bernhard Beschow wrote: >> These singletons are actually properties of the system bus but so far it >> hasn't been modelled that way. Fix this to make this relationship very >> obvious. >> >> The idea of the patch is to restrain futher proliferation of the use of >> get_system_memory() and get_system_io() which are "temprary interfaces" > > "further", "temporary" > >> "until a proper bus interface is available". This should now be the >> case. >> >> Note that the new attributes are values rather than a pointers. This >> trades pointer dereferences for pointer arithmetic. The idea is to >> reduce cache misses - a rule of thumb says that every pointer >> dereference causes a cache miss while arithmetic is basically free. >> >> Signed-off-by: Bernhard Beschow >> --- >> include/exec/address-spaces.h | 19 ++++++++++++--- >> include/hw/sysbus.h | 6 +++++ >> softmmu/physmem.c | 46 ++++++++++++++++++----------------- >> 3 files changed, 45 insertions(+), 26 deletions(-) >> >> diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h >> index d5c8cbd718..b31bd8dcf0 100644 >> --- a/include/exec/address-spaces.h >> +++ b/include/exec/address-spaces.h >> @@ -23,17 +23,28 @@ >> #ifndef CONFIG_USER_ONLY >> -/* Get the root memory region. This interface should only be used >> temporarily >> - * until a proper bus interface is available. >> +/** >> + * Get the root memory region. This is a legacy function, provided for >> + * compatibility. Prefer using SysBusState::system_memory directly. >> */ >> MemoryRegion *get_system_memory(void); > >> diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h >> index 5bb3b88501..516e9091dc 100644 >> --- a/include/hw/sysbus.h >> +++ b/include/hw/sysbus.h >> @@ -17,6 +17,12 @@ struct SysBusState { >> /*< private >*/ >> BusState parent_obj; >> /*< public >*/ >> + >> + MemoryRegion system_memory; >> + MemoryRegion system_io; >> + >> + AddressSpace address_space_io; >> + AddressSpace address_space_memory; > > Alternatively (renaming doc accordingly): > > struct { > MemoryRegion mr; > AddressSpace as; > } io, memory; Do we really need that? Isn't mr just the same as as.root so it would be enough to store as only? Or is caching mr and not going through as to get it saves time in accessing these? Now we'll go through SysBusState anyway instead of accessing globals so is there a performance impact? Regards, BALATON Zoltan >> }; >> #define TYPE_SYS_BUS_DEVICE "sys-bus-device" >> diff --git a/softmmu/physmem.c b/softmmu/physmem.c >> index 0ac920d446..07e9a9171c 100644 >> --- a/softmmu/physmem.c >> +++ b/softmmu/physmem.c >> @@ -86,12 +86,6 @@ >> */ >> RAMList ram_list = { .blocks = QLIST_HEAD_INITIALIZER(ram_list.blocks) }; >> -static MemoryRegion *system_memory; >> -static MemoryRegion *system_io; >> - >> -static AddressSpace address_space_io; >> -static AddressSpace address_space_memory; >> - >> static MemoryRegion io_mem_unassigned; >> typedef struct PhysPageEntry PhysPageEntry; >> @@ -146,7 +140,7 @@ typedef struct subpage_t { >> #define PHYS_SECTION_UNASSIGNED 0 >> static void io_mem_init(void); >> -static void memory_map_init(void); >> +static void memory_map_init(SysBusState *sysbus); >> static void tcg_log_global_after_sync(MemoryListener *listener); >> static void tcg_commit(MemoryListener *listener); >> @@ -2667,37 +2661,45 @@ static void tcg_commit(MemoryListener *listener) >> tlb_flush(cpuas->cpu); >> } >> -static void memory_map_init(void) >> +static void memory_map_init(SysBusState *sysbus) >> { > > No need to pass a singleton by argument. > > assert(current_machine); > > You can use get_system_memory() and get_system_io() in place :) > > LGTM otherwise, great! > >> - system_memory = g_malloc(sizeof(*system_memory)); >> + MemoryRegion *system_memory = &sysbus->system_memory; >> + MemoryRegion *system_io = &sysbus->system_io; >> memory_region_init(system_memory, NULL, "system", UINT64_MAX); >> - address_space_init(&address_space_memory, system_memory, "memory"); >> + address_space_init(&sysbus->address_space_memory, system_memory, >> "memory"); >> - system_io = g_malloc(sizeof(*system_io)); >> memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, >> "io", >> 65536); >> - address_space_init(&address_space_io, system_io, "I/O"); >> + address_space_init(&sysbus->address_space_io, system_io, "I/O"); >> } >> MemoryRegion *get_system_memory(void) >> { >> - return system_memory; >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.system_memory; >> } >> MemoryRegion *get_system_io(void) >> { >> - return system_io; >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.system_io; >> } >> AddressSpace *get_address_space_memory(void) >> { >> - return &address_space_memory; >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.address_space_memory; >> } >> AddressSpace *get_address_space_io(void) >> { >> - return &address_space_io; >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.address_space_io; >> } > > > --3866299591-1142243070-1663663801=:43449-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:02:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409234.652193 (Exim 4.92) (envelope-from ) id 1oaZ9S-0001Xw-ET; Tue, 20 Sep 2022 09:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409234.652193; Tue, 20 Sep 2022 09:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZ9S-0001Xp-Av; Tue, 20 Sep 2022 09:02:46 +0000 Received: by outflank-mailman (input) for mailman id 409234; Tue, 20 Sep 2022 09:02:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZ9Q-0001Xj-Tb for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:02:44 +0000 Received: from zero.eik.bme.hu (zero.eik.bme.hu [152.66.115.2]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc50774c-38c2-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 11:02:43 +0200 (CEST) Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id DD37E74633E; Tue, 20 Sep 2022 11:02:41 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 8F6AB74632B; Tue, 20 Sep 2022 11:02:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 8A79C746324; Tue, 20 Sep 2022 11:02:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc50774c-38c2-11ed-bad8-01ff208a15ba Date: Tue, 20 Sep 2022 11:02:41 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= cc: Bernhard Beschow , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-15?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-15?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-15?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 9/9] exec/address-spaces: Inline legacy functions In-Reply-To: Message-ID: <7411d60-2bc0-f927-752-56184958c790@eik.bme.hu> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-10-shentey@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1050215408-1663664561=:43449" X-Spam-Checker-Version: Sophos PMX: 6.4.8.2820816, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2022.9.20.85118, AntiVirus-Engine: 5.93.0, AntiVirus-Data: 2022.9.15.5930000 X-Spam-Flag: NO X-Spam-Probability: 9% X-Spam-Level: X-Spam-Status: No, score=9% required=50% This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1050215408-1663664561=:43449 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 20 Sep 2022, Philippe Mathieu-Daudé via wrote: > On 20/9/22 01:17, Bernhard Beschow wrote: >> The functions just access a global pointer and perform some pointer >> arithmetic on top. Allow the compiler to see through this by inlining. > > I thought about this while reviewing the previous patch, ... > >> Signed-off-by: Bernhard Beschow >> --- >> include/exec/address-spaces.h | 30 ++++++++++++++++++++++++++---- >> softmmu/physmem.c | 28 ---------------------------- >> 2 files changed, 26 insertions(+), 32 deletions(-) >> >> diff --git a/include/exec/address-spaces.h b/include/exec/address-spaces.h >> index b31bd8dcf0..182af27cad 100644 >> --- a/include/exec/address-spaces.h >> +++ b/include/exec/address-spaces.h >> @@ -23,29 +23,51 @@ >> #ifndef CONFIG_USER_ONLY >> +#include "hw/boards.h" > > ... but I'm not a fan of including this header here. It is restricted to > system emulation, but still... Let see what the others think. Had the same thought first if this would break user emulation but I don't know how that works (and this include is withing !CONFIG_USER_ONLY). I've checked in configure now and it seems that softmmu is enabled/disabled with system, which reminded me to a previous conversation where I've suggested renaming softmmu to sysemu as that better shows what it's really used for and maybe the real softmmu part should be split from it but I don't remember the details. If it still works with --enable-user --disable-system then maybe it's OK and only confusing because of misnaming sysemu as softmmu. Reagrds, BALATON Zoltan >> /** >> * Get the root memory region. This is a legacy function, provided for >> * compatibility. Prefer using SysBusState::system_memory directly. >> */ >> -MemoryRegion *get_system_memory(void); >> +inline MemoryRegion *get_system_memory(void) >> +{ >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.system_memory; >> +} >> /** >> * Get the root I/O port region. This is a legacy function, provided for >> * compatibility. Prefer using SysBusState::system_io directly. >> */ >> -MemoryRegion *get_system_io(void); >> +inline MemoryRegion *get_system_io(void) >> +{ >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.system_io; >> +} >> /** >> * Get the root memory address space. This is a legacy function, >> provided for >> * compatibility. Prefer using SysBusState::address_space_memory >> directly. >> */ >> -AddressSpace *get_address_space_memory(void); >> +inline AddressSpace *get_address_space_memory(void) >> +{ >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.address_space_memory; >> +} >> /** >> * Get the root I/O port address space. This is a legacy function, >> provided >> * for compatibility. Prefer using SysBusState::address_space_io >> directly. >> */ >> -AddressSpace *get_address_space_io(void); >> +inline AddressSpace *get_address_space_io(void) >> +{ >> + assert(current_machine); >> + >> + return ¤t_machine->main_system_bus.address_space_io; >> +} >> #endif >> diff --git a/softmmu/physmem.c b/softmmu/physmem.c >> index 07e9a9171c..dce088f55c 100644 >> --- a/softmmu/physmem.c >> +++ b/softmmu/physmem.c >> @@ -2674,34 +2674,6 @@ static void memory_map_init(SysBusState *sysbus) >> address_space_init(&sysbus->address_space_io, system_io, "I/O"); >> } >> -MemoryRegion *get_system_memory(void) >> -{ >> - assert(current_machine); >> - >> - return ¤t_machine->main_system_bus.system_memory; >> -} >> - >> -MemoryRegion *get_system_io(void) >> -{ >> - assert(current_machine); >> - >> - return ¤t_machine->main_system_bus.system_io; >> -} >> - >> -AddressSpace *get_address_space_memory(void) >> -{ >> - assert(current_machine); >> - >> - return ¤t_machine->main_system_bus.address_space_memory; >> -} >> - >> -AddressSpace *get_address_space_io(void) >> -{ >> - assert(current_machine); >> - >> - return ¤t_machine->main_system_bus.address_space_io; >> -} >> - >> static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, >> hwaddr length) >> { > > > --3866299591-1050215408-1663664561=:43449-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:07:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:07:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409241.652203 (Exim 4.92) (envelope-from ) id 1oaZDi-0002Ch-0P; Tue, 20 Sep 2022 09:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409241.652203; Tue, 20 Sep 2022 09:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZDh-0002Ca-U3; Tue, 20 Sep 2022 09:07:09 +0000 Received: by outflank-mailman (input) for mailman id 409241; Tue, 20 Sep 2022 09:07:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZDg-0002CU-In for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:07:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99c5bd9e-38c3-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 11:07:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8203.eurprd04.prod.outlook.com (2603:10a6:10:242::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:07:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 09:07:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99c5bd9e-38c3-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SuZ74EOo7YzVFADJLFGxSVuNa/c0ft1HXBVTslWIYoC6CeAdOD8r6TTmFYRQpLamsG6GSGY+gwfbS1LzAnDKTDVBVu2QeQvCFDvyO5FJRMOtfqxLyHO20TD2kWl0rBRrXy6bKwkwQgyGQJ4+Y6WIojQzuhBpDX6zyJkbFEm320CHOMEIZvKYMDTvtE8xJGO815IQvWD4TscLAs8pbkVDfc119KB8RU7k2d8+1yPR+muPJOSEc+CpZwV2sUolD8O/bVxygnwqHrdk24Ntu0QZQiFiPEf1jdTp9XW9N1P5WBCa7dxEstlYWmImXO3fW4Uqomp+mnlc9xvw9XyOGHJ5Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7qAbSEm/Qjj9jInCq6Is7HEVCi/CM2NsVKwGUyl4Gd4=; b=b38WTEUxrgNyz9R6pZuavjftw6plLYfVCBqyrnpCT+9ji6fdFU/8FNGrk0+w9yiwHEbEXJHL9N1LImigyctwINUs2a5uEFZQIvUVvv8I6v9LEqf1WkYhYx0/gKbwW/1qn6WXIfNI1LY3VpHDh1RG2FfKHrzJXUK+TLs11ZwcU0zG8BcGAYNEWB7TMChDaT/Mz/k44t0XBa8cFykJ61idXxgftYoJb7M7+YWUM2VipcnYmgeheaoB3nD+rS0DHzCs8kCtGxBn3FkCf3/S4pA1Qyt2ddGUckIkJu2LjmHAOoDfhCV64ByIzEQC/ekMcPf/OPP75JTJnNLXzqPXUBp/aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7qAbSEm/Qjj9jInCq6Is7HEVCi/CM2NsVKwGUyl4Gd4=; b=pVOxzn/E2EE7036WOub3H8ZxhYdQaragkEubS6QR3QC822ZOPGPj9okm2se1wRdKdhuC3O7N16x5YFATwSpdGqL2CRG6kxwK0dovLgS3sRo2ptey/U3K94B10H/3duSrbvIYM+IoM5VwHoV9bpXY+wlgkNqST/QFPNqDf3yNgu0KWDDyc0IjyFwiNwYPFv/fP4uCATrTLvBMPPVOoQJGXno5u0aZNRdvmBsmq5OSwmPngijILbLreev3oi1yk36K3QWL6lB+BWwZOsTSZHS7+H0Zc+5g95/ck8J9i94NLuN1V1Ae09vqhJR+Fhs8QbIk6ITKMhqdQVt/1OChS/2GzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 20 Sep 2022 11:06:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org References: <20220919150927.30081-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20220919150927.30081-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0639.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8203:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a47c5b9-7289-4f7b-35cd-08da9ae77cd3 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EvQg2w/6uh9ECFcRSSlE3uqdvztH+rassFrKUroh3534Rb5GL9jxTUbhz6riZr0JHX520DtDzs/8wL+/fxq5D/NgSnKcXMQ5jnupxMs9XbQ32jYH5QnymzOPbsw6tdHmtRpfoEwOCAUgRgod7bC2bo+RtUsmXr5K+CYDPIB2AOraepwMzvV4sC6TZqv7xeQsVGCsqt3K/BVgYcM2bJHiAKFzjU1fJenVENfCb/CssqnifhhiAWdBz/cLKU9mug/+ODS5/ExlZdvw3qdQjXEEs6Az5jOcrowMfiwbWkoIhmuRfD5qnH47//9yqlnhm/6apvapVdy+vCIgn2dmaT9zYLGqoC4vzXYNBnDC4hdTpzpfMvJi2XSbYCK8LzkuYLA5dCnxHR+rdPuJxtRV0Kd/sivULqsUH48gP1vzHGM9FhH53XxrGjVJEhjBHaRjWZGq8G5Ss8KpQLDH90U+yeMY1mg7hJ8MYpUthOlQERjViX0IlwY1UroTDL3kX4aXerjnmhLGAbBTOigpazlnOYKxSQbC2lUYDA1j/KiAwoHYFtg6B1rqtVFZCA+lWpBYFN5tjZfyZ/jJ4Z6EZ2uWUhKTui9RjUV7JsnjJjmh0mtjprzkTaNk80KpjNXkpDmGMSN8LavyinjWtl57xNGu8bPLMoXyn60OV6SwQd4c5rq6LxmiICg1Fa0aL/+cwqqWanhm1LNb5QK3yHWd6wkEURZLq0S0A2MsS03UpKnNSGoAZn0T8VWSUwG+TFs+SrX9lQ8wkddrXkUmgS0NIJ/KzxZuLX8q9y+hD2ID8oBsi/IK5rw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(39860400002)(376002)(136003)(451199015)(31686004)(36756003)(4744005)(2906002)(54906003)(316002)(66574015)(8676002)(38100700002)(4326008)(66476007)(5660300002)(66556008)(66946007)(31696002)(6916009)(8936002)(86362001)(186003)(478600001)(2616005)(26005)(6512007)(41300700001)(6666004)(6506007)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlFLRmxZNTlDMmdHUjRmVURBdjVaanJjckFSNEo3OU1qOGl1VmhhMkQvMzB1?= =?utf-8?B?ZHJZaFdWR21WWFFwRldZTTJqaFJRcW52eGJOVnRIeEtUeng4ZVhiVksreSsx?= =?utf-8?B?Nytva091NzdkdzRDRWwyNVVBNm1MVEZxWmNYSW1uczFuWTRWWlAzaHIvZXNU?= =?utf-8?B?czFEVHZBUVdSMzNOZXZUa01vNWowZ09yZGhzTlVBZk5sRGJNV2E0T09ucWdD?= =?utf-8?B?dXN4cTF4OE40YkFRRU1oWjN4ZlJ6M2wvb1RUNDVoQ2Fwck0xYWFyMUlxY0l2?= =?utf-8?B?eGdMUWtFS2dUeDlsTktFUlVxUm4yYUtHN1JUZkExS041R3F0RXdZcUZ4YWVB?= =?utf-8?B?WDg1YlZVU0h0U1NsVFFEbnMrKzNOLzFkb21uODVnRFZnTUlreVEra1doWUUz?= =?utf-8?B?U09peEsrQVNZVG9wSnUyMVJuZXRGVTc3MFV2Y1U2M3RUMXg0MjN1R0lFTFli?= =?utf-8?B?ZlM3dSs0SVBpRzA4cVpTNkhBNUVnWm5kT0djVkJJWkVNc1dIdjR0MWVTMDF5?= =?utf-8?B?NTJ5VVpTUGJMb1FudVViVnoyMVlJanNjY2JLZFZEZWFJbU5RRXU3ZUkxaEtF?= =?utf-8?B?cDlGcGRyOU1DUlY1anB4RkNqUWplazZYdTJoNUJ4V2xVd1A1NktyM3cvdGZW?= =?utf-8?B?OTdSQXNOR2RkejY5U0dzWEYrQi94WkpEUEVuQ3dkMnI4clRWQ01uRDdzWlFu?= =?utf-8?B?VWtJOTdoSWJuanBSdGpxZ2xKKzFxemcwblJGZEtzOE1TRmcrbEpNcEpKMmxq?= =?utf-8?B?NHhmMDRKOTByR0piSEltOVNDNnhkYzRmcEVlbjNxN2tuejIzYmoxNUV0cVZK?= =?utf-8?B?OWRuMFAxVVVwek1EVW1OUmk1RktrL3ExQTNVdHJ5YjE4L0hHVk83VjB1czBN?= =?utf-8?B?bnVwcnZSd1RDTVlXZ1N6eUdnSWVINGNsNnEzZ1hhb2FCaUMwaUZmZW9vWUJr?= =?utf-8?B?elQzNHdqS1YycnoxZ0lBU2phTEdQYy9UVUZ3d2ptaE1jZ2Z4Q0szQUJtV3JF?= =?utf-8?B?bUxLR3RUdVhYcmZ2Q3BOeDIycFJDU1dJZTJ5YVdJL204cnZsSjJZODk4MzJL?= =?utf-8?B?NUhJaWZnY2tET2dQcDh5S2VTRjVBVlJJUzg1WVovcHRUSHMycWE4MWl5RjNB?= =?utf-8?B?ZWlCaGFjbS9mVXE4dEJCc1E0TmR4aHZMYVFRSFoyMmplTFdxT0tnWkd6Y3JI?= =?utf-8?B?ang2ZGxaekh4NXJFaCt3RzlCckNjUXFGZjVpN3RabE1Kckp0LzEyMnhpOTNv?= =?utf-8?B?VG42OGY5VDRBbHhLbGh6STgxRmc3eXVLSVMxM0ptUXJ4dGI4d0dhc2g3TmU5?= =?utf-8?B?MGpEcm93ekFwYm1qd1V0QloyNmhKSDNSNE5IQUVHbmRXSFFmSzNiRE1SZ0Jl?= =?utf-8?B?UXRGTXR0c01seWJoc29kb3RMUjZtM3hnREM5WHRGSnM0MnoxNlBibTd4bHZv?= =?utf-8?B?U3hUTnBOM3Z5bGJmZndvTkk4aVR1VHRPa2tUSG5YQWFDbDZBRndtSkpCdnNY?= =?utf-8?B?ZjhiWkRianRSZVRVTDBuZzRhNytYUk5neDhDSng3UHRUbTZwd3ZXcllTS0E5?= =?utf-8?B?K1VrUyt0K2NtZ0h4S2RTZ3BDQm1lWDlFTGNJT0psNmREWU5lKzNMMHNBZ3VT?= =?utf-8?B?UmhpTXJ4dkZJVFc4aU81d2R4eE9jcWxNVXB3dFFBSUhSaXMrdVFoYVdDenVw?= =?utf-8?B?U0NiWDVaQlk4RTlmUTd5bzVyQWNzRnU3QWh0ZkNrRFNqU3NScHI3UjZ4WG8w?= =?utf-8?B?ZEpKaUExYmNZa3VESmxYUXZFRkdkTUFERXRIdlVJR1R4anN3Tlp1b1p1cUVr?= =?utf-8?B?b2lxZ0hRWjlZRU9yUDJBTHUweEU2VXNUV2RyeUM0amVibHRKY3BMbzBKWml2?= =?utf-8?B?S2tUWHV6NTBiUHlqWm5WT1AwNC9YVnBZelRrOGF5dlQwR082akhvRzIrVlI3?= =?utf-8?B?eEhtVkhxdFA0WE9Ja3A5VDZjSmNUZmNFbitKTmwwdVRDejN3bExuSFJnUEE1?= =?utf-8?B?dm1HYVdxd200Y25yblZlaDIyQ2duUUhtU2JqT09TdVpBNmdXWmVWM0VYdVhQ?= =?utf-8?B?NFFhWmRPcGF6YjJrajM5a2JmTHIva05oQUV3bndCVE01UjY4ZEwzbGJlckJI?= =?utf-8?Q?RDrVUSCvqfSeExcvcEm8gCD2p?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a47c5b9-7289-4f7b-35cd-08da9ae77cd3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:07:05.0560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +bmFd7TiMhHEZJMPMkTD4ykJ7Kj8jWI2lJZlJuaKATcvFnCpktPSWhG9DeYTgZLOHo46lIYoqcXEDPMrpkCgoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8203 On 19.09.2022 17:09, Marek Marczykowski-Górecki wrote: > --- a/xen/common/sched/credit2.c > +++ b/xen/common/sched/credit2.c > @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, unsigned int cpu) > * > * Otherwise, let's try to make sure that siblings stay in the > * same runqueue, pretty much under any cinrcumnstances. > + * > + * Furthermore, try to respect credit2_runqueue=all, as long as > + * max_cpus_runq isn't violated. This last part is questionable, partly because the command line doc is ambiguous as to which of the two options is intended to "win". I guess one needs to know the original intentions to resolve this. > */ > if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran != SCHED_GRAN_cpu || > - cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) ) > + cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) || > + opt_runqueue == OPT_RUNQUEUE_ALL) ) Indentation was already broken here. As you're touching it, may I ask that you correct that aspect? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:12:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:12:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409247.652226 (Exim 4.92) (envelope-from ) id 1oaZJE-0003rV-1S; Tue, 20 Sep 2022 09:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409247.652226; Tue, 20 Sep 2022 09:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJD-0003rO-Uc; Tue, 20 Sep 2022 09:12:51 +0000 Received: by outflank-mailman (input) for mailman id 409247; Tue, 20 Sep 2022 09:12:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJC-0003bf-MF for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:12:50 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2040.outbound.protection.outlook.com [40.107.105.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 655539cd-38c4-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 11:12:48 +0200 (CEST) Received: from DU2PR04CA0185.eurprd04.prod.outlook.com (2603:10a6:10:28d::10) by PA4PR08MB7433.eurprd08.prod.outlook.com (2603:10a6:102:2a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:46 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::ea) by DU2PR04CA0185.outlook.office365.com (2603:10a6:10:28d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 09:12:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:46 +0000 Received: ("Tessian outbound ee41cdb23966:v124"); Tue, 20 Sep 2022 09:12:46 +0000 Received: from 244930ccd1a4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1835DC30-937D-46C0-9630-9D41BD00306B.1; Tue, 20 Sep 2022 09:12:39 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 244930ccd1a4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:39 +0000 Received: from FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) by AS8PR08MB6424.eurprd08.prod.outlook.com (2603:10a6:20b:33e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:36 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a8:cafe::99) by FR0P281CA0114.outlook.office365.com (2603:10a6:d10:a8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 09:12:35 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:35 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:33 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:33 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 655539cd-38c4-11ed-bad8-01ff208a15ba ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IrTAPHQcAd5CQ4FF1illZ61LXDueAK0qmS2pulzx8B5dJy5jROR6pvYNkb0U1GZfIxBYrfmlKpEHvP/bpl/XVI+J+qkewwQBNntOpP7cVma6bq5ieGavoTliadmzAWhOxgqODBvfT7E9iRZ+YqgBMaffhTSd2wWZesqVDTm/lm7ud610AvIMhKeUGt42uPfYSqLPnKHBt9VGo+l2kN7WfyiruJC0GRRWONTLe3Y7+/Ergz+EE2QTyaodUiXAI2azG2teQF3quPxO2E7A9Rt6JU05iCPWVy6QktZB8XXDBuyHQHWAN0Uh31MM1vywpotAMOIf0EFkxCUwThyoEDyccw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0t10+tfC/hnKAURkjOBssSzDdn/WYZUVAtw/3h0wBe4=; b=A2ssQBg8p4QZZfYcMRnwlHnG7V0Ra0OV05ANs5RMuUBrxIdzI81O+fJ+LqcUPFGmbJ1/1uZeYLordES4x4iAWNPU0idjwRCbEzuK0GUX3m89FYoQXHPstpymQ7A3Ab/G1pPqq3ROAtPmY1aTNl1ZxmVvDaYWCnIem1VURQTqsDUsaiEwpJnWXD1bx2dj673GbwCGR/a2xersWLLpTX33gp/9Kis/ImZEm+mct5uD2PcyANq6G69F/PIhqARGcCzmR/T4OK6E6CoZFsxPaiD+/7mPCoYoJ3APYf7q6jzMER1ZB8PtyAhC82W3+urHKQg0jb6ow1YEBHZyr+Wk3POCmg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0t10+tfC/hnKAURkjOBssSzDdn/WYZUVAtw/3h0wBe4=; b=eSF1N13cvz5qYGEKqJHvdvYHo8ca8VSSU3k0DsQKUye5q6xWO2qO1RdC3Dvdylh3NXO/nUYaRGvOd9/YOZn1XK/P40LIw/BYELaRcieZ0RrP1BwU6Fjx4UqX+pQG4mRrO7hjXmwwe/aTMh5v8bmKwGW9BQL7ZtkVT044MmFMZm4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9d62e5de3abef816 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8+XAe3ip8R/yaxBVnGM3VJL03TcQ0aAnjCNZ3sMZ4GqLCSwHA08Uh9CJZ6pQvmIMj0ZWEYS36j2OED5FVwtaXcWpYtGxdGEyHPTkPuqRLf0azOjmlhdKKBg85NiysfYAj1HfPbGlEkpGiOx/6k46VjO5MPlc8v/mVSd8xDExQbeFmx7e3cNTg8DxPvK7xQZMiIPTF13i9/oGZLwwciMd8u0zusxOwCg1/LuL8fYFCFb0+10hND989T0n1UdF+5Um9bP5RmBJXbpeHh+N+6egr3o/FQk0Fgf69rOJ1759Ty8S2pfv4DUfVujIfZ19+hj2ZO/nWviz+UNk4xNmb0y/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0t10+tfC/hnKAURkjOBssSzDdn/WYZUVAtw/3h0wBe4=; b=ij/CWHRwkXE9OhA1ZVFlgx/97KfFyAHSyP+MQ6/Y0fEVfgzRELJ7gU1Wpw1EwW6cX9YENbJPODJFkM93aFnmuIW+bTtt9nA3B2AAbjdoHPk0pab9olqRRPYo0QO4sEQgQtQfuVaQuaLYzWatQh2g/cxS2RzhRCKrOld2QreQ1HjKfwGXEm267KFxO+RudCDWjQM/vlhFBeSwtocwQGsXfY857HTy0CWqchlpqVmZaFBx41N2d8T4IGBnBarnloj+tTsucxxfOhg9sQYjtPpXGU66tigSlZEGNLJEdK3f5W1MPI8GQ9v5YXbTQlg8O2K+W8T22tXKvLEJVh+YEmn1yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0t10+tfC/hnKAURkjOBssSzDdn/WYZUVAtw/3h0wBe4=; b=eSF1N13cvz5qYGEKqJHvdvYHo8ca8VSSU3k0DsQKUye5q6xWO2qO1RdC3Dvdylh3NXO/nUYaRGvOd9/YOZn1XK/P40LIw/BYELaRcieZ0RrP1BwU6Fjx4UqX+pQG4mRrO7hjXmwwe/aTMh5v8bmKwGW9BQL7ZtkVT044MmFMZm4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v5 1/6] xen/x86: Provide helpers for common code to access acpi_numa Date: Tue, 20 Sep 2022 17:12:13 +0800 Message-ID: <20220920091218.1208658-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920091218.1208658-1-wei.chen@arm.com> References: <20220920091218.1208658-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT052:EE_|AS8PR08MB6424:EE_|DBAEUR03FT055:EE_|PA4PR08MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: 52c8de36-b277-49f4-5e2e-08da9ae84844 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0RXJik4DxR/GELlw+dHTzcnYwuDU21h7UOR+juU0dq7K6cEZGixFJbNnGgKdgsKTaw0+E+r68AEP6+erF2FTDAt4cvyyV8u1p4rDR4JBXIdZo36xD/x3Gcbsj6FTulhrY1VB2tfB3wh9JUmhl2WvHm7ge8G//mq/nFZF3g29JemjIgoW2QfKUCEOL27RBYDOy1NN65tBDiIBPS8LIocrCArxq6phDg3IugCJEwvbw27fD3Jcy7BwPzAXI0Pf6Z5MlKkIpP6or7HKGpKkHso+sXd7YLu5IhH8pONbZjBbjjPsJOOniLbbr9s4g59YgI5UIcuImRzyQnHsM9h1YA+3Fx0VFVBlD/7j9QSELQkfri/vvmRdKR+HwKLlYLVq5V4+gFVMp2rBYP32mEC3XwYOKvNDVgoVqRNjOQN7gn37oE1CevjXyXz1lbulwg8Pn0MPZy79ysPX4MME8ONcGKrVHnCWuG9mpb7DDX1YTBtE4x69MbHo5oIp/LExef7Z9L2wGDeZj4tiSomNyIx7T8B7tfgxn9TCV8Vh+y0KlccLKvX0lAfdKf3b0nECF2H0uZJC0YvwGYfq/3mI7alvxISHiQK4icgUfbcvNCtst1fhlzEzHRNZp2lWCQvL008M41eyIEmLcFcmyi3FqkjTselVBOHRMuAainASeLzZ5LmBoP08QmTBiXJhMMguycVvPt792D3mSM0jnL7tPG4qEkuvlTlQvDpIuBc0IIBvfYf727cZcBnEHmbJ9pHQE0+JzCgnoOUBFMBUdJDbEo0BFi8BzcTtPodQhG2pFvsZZVlbe0RsfZsqxwF+9gjvMlQToZzK X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(2906002)(44832011)(36756003)(54906003)(316002)(426003)(36860700001)(8676002)(47076005)(82740400003)(4326008)(5660300002)(82310400005)(70206006)(70586007)(6916009)(8936002)(86362001)(336012)(1076003)(186003)(81166007)(478600001)(2616005)(26005)(356005)(41300700001)(6666004)(83380400001)(40460700003)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6424 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d1aca7f-1415-4bbc-8e9d-08da9ae841e0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lqbwGxiKHcxYISfWYnPKvuBEgbxCqiILS1oiLxXXyEEi8VlHYEtnQbClWhRNDT9eW6OlAi5lPrTY21rZhYSZbkDJzpZHU29z1ZKLtHCtpPlAu0xmCsdUTSD3Z7ixhKclIrgCofSkoNncktUgVAhjXgO4oTRjSxKfzBpg4fhiSeK/AZdFQpCqXjGPB+/y2dPspoJPc7BZ7hfCuDbhy1iKqRmo1UJfhdY5MdO9KWqmXzDNFvRS3VyRRarLzIB5XVQHA0a9MNetk05diuuxnqelm4vS2Clk/0FwebBwmdqyMiifrBrtHCY/uzkOIA5ZToM175Z/ZwBTNiooDsUfOeSNt7hfUVoTE7fT17e92xK1n0b68nl1ZIl9fcmbatof5XrGyVCEkpSVaHUTgTqkod7hw5Hgmvn9rcSPJgTsHW3KI2zbc8IL7WhSbum25mQpKnimuFiLucSSe/GLQHYMwDOWaXaZn4uqP28ZSDLSPxfPWYtlgmBQMkmvkiGnxU1CqVA3Pw+1p9MltOKw2XmimQyZpYBbB3fYRl0sQjqcMYtaGZPTPGkY3B7E6p+dKWI6KiXVz6ApdMY7DLkKjTaoE/shf0XYvVD1ieGV+13wApi3JHAwmdsFR8JTBnpvudpnFNVGj2yxjq9S4za8dQC2R0gKcfZrNCM8GYRSsieqqAobYgs6KKGUYQ3prCta0DeJPA6x/9eVVKkwOqX4g8bOkOJ2U8VMmH044HYhJDElE1pC2JzqUXZ9iMnGp7BVeHI4KHwtxhHvY9O8DdEaF6BAKGbgwQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(6666004)(44832011)(2906002)(5660300002)(8936002)(86362001)(4326008)(70206006)(40480700001)(8676002)(70586007)(81166007)(6916009)(54906003)(316002)(82310400005)(478600001)(336012)(47076005)(1076003)(41300700001)(40460700003)(7696005)(36756003)(82740400003)(186003)(426003)(83380400001)(26005)(2616005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:12:46.1720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52c8de36-b277-49f4-5e2e-08da9ae84844 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7433 acpi_numa is a specific NUMA switch for ACPI NUMA implementation. Other NUMA implementation may not need this switch. But this switch is not only used by ACPI code, it is also used directly in some general NUMA logic code. So far this hasn't caused any problem because Xen only has x86 implementing ACPI NUMA, but now Arm is implementing device tree based NUMA. Accesssing acpi_numa directly in some functions will be a block of reusing NUMA common code. It is also difficult for us to replace it with a new generic switch, because it is hard to prove that the new switch states can guarantee the original code will work correctly. So in this patch, we provide two helpers for common code to update and get states of acpi_numa. And other new NUMA implementations just need to provide the same helpers for common code. In this case, the generic NUMA logic code can be reused by all NUMA implementations. Signed-off-by: Wei Chen --- v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. v3 -> v4: 1. Drop parameter from arch_numa_disabled, the parameter will be introduced in later patch where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. v1 -> v2: 1. Remove fw_numa. 2. Use enumeration to replace numa_off and acpi_numa. 3. Correct return value of srat_disabled. 4. Introduce numa_enabled_with_firmware. --- xen/arch/x86/include/asm/numa.h | 5 +++-- xen/arch/x86/numa.c | 38 ++++++++++++++++++++++----------- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index c32ccffde3..529efadf93 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -32,8 +32,9 @@ extern void numa_add_cpu(int cpu); extern void numa_init_array(void); extern bool numa_off; - -extern int srat_disabled(void); +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_broken(void); +extern bool srat_disabled(void); extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 627ae8aa95..1ab37b9c19 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; bool numa_off; s8 acpi_numa = 0; -int srat_disabled(void) +int __init arch_numa_setup(const char *opt) { - return numa_off || acpi_numa < 0; +#ifdef CONFIG_ACPI_NUMA + if ( !strncmp(opt, "noacpi", 6) ) + { + numa_off = false; + acpi_numa = -1; + return 0; + } +#endif + + return -EINVAL; +} + +bool arch_numa_broken(void) +{ + return acpi_numa < 0; +} + +bool srat_disabled(void) +{ + return numa_off || arch_numa_broken(); } /* @@ -291,28 +310,21 @@ void numa_set_node(int cpu, nodeid_t node) /* [numa=off] */ static int __init cf_check numa_setup(const char *opt) { - if ( !strncmp(opt,"off",3) ) + if ( !strncmp(opt, "off", 3) ) numa_off = true; - else if ( !strncmp(opt,"on",2) ) + else if ( !strncmp(opt, "on", 2) ) numa_off = false; #ifdef CONFIG_NUMA_EMU else if ( !strncmp(opt, "fake=", 5) ) { numa_off = false; - numa_fake = simple_strtoul(opt+5,NULL,0); + numa_fake = simple_strtoul(opt + 5, NULL, 0); if ( numa_fake >= MAX_NUMNODES ) numa_fake = MAX_NUMNODES; } -#endif -#ifdef CONFIG_ACPI_NUMA - else if ( !strncmp(opt,"noacpi",6) ) - { - numa_off = false; - acpi_numa = -1; - } #endif else - return -EINVAL; + return arch_numa_setup(opt); return 0; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:12:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:12:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409246.652214 (Exim 4.92) (envelope-from ) id 1oaZJC-0003bn-Kk; Tue, 20 Sep 2022 09:12:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409246.652214; Tue, 20 Sep 2022 09:12:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJC-0003bg-Hy; Tue, 20 Sep 2022 09:12:50 +0000 Received: by outflank-mailman (input) for mailman id 409246; Tue, 20 Sep 2022 09:12:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJA-0003bZ-PR for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:12:48 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10043.outbound.protection.outlook.com [40.107.1.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63ecb0fb-38c4-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 11:12:46 +0200 (CEST) Received: from FR3P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::19) by DB9PR08MB8316.eurprd08.prod.outlook.com (2603:10a6:10:3dc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Tue, 20 Sep 2022 09:12:44 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1d:cafe::a9) by FR3P281CA0005.outlook.office365.com (2603:10a6:d10:1d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 09:12:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:43 +0000 Received: ("Tessian outbound 0a0431bdcdb4:v124"); Tue, 20 Sep 2022 09:12:43 +0000 Received: from c4d10218c58e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5EE85EC8-136C-48ED-8130-286F8D496A36.1; Tue, 20 Sep 2022 09:12:35 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c4d10218c58e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:35 +0000 Received: from FR0P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::9) by DB3PR08MB9134.eurprd08.prod.outlook.com (2603:10a6:10:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:32 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::a5) by FR0P281CA0148.outlook.office365.com (2603:10a6:d10:96::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 09:12:32 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:32 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:30 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63ecb0fb-38c4-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cMKmnyOp7n6qP9Sc7Xe0ANptQKkTbxAEu4N2PV6uTvICA8PvTXq48He+wrIM3P8IiiWSXdiWvr2gegTlXQsVlFI7D3PP+oZEzeEHrElUB3wEeYFUz6SEAizocLZRWlrYVEO8R91G+4m+1nnBA4i+A5utGqzcLnIxi2dcKT0ixtmRNU6pFnlFdKgw143sbDYsjQR5X2V3WZM+UBly3+UpaTxZfVi8mSX/6usw599fckNdIzhr0uqO8j2mwtUl3J+sJwdc0QZ3ZW9hmPmukznOEGd2+n2hpHwdnUCuEHeXIcDm5YJFzjakav6RIJh3yuzRSSPkVQJwxM0Irman6H6/rg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fz6gJyYDH2FKgfyLnRBJc6Pg7LGjMwC4R5POpxJ6VzY=; b=nhfF7var8lbBd8zupb34OIC7JAXC1EDdmdmLdJ0HeJ9veQlSd35Bn9fS9Ntc7yAPS/Cql+d2Qw6p/kDOYm46gyd/jkdAfhmsS93sCieLBuuVV8HLaJtLpcd7kHj/5eW3hkkQK7utg86+fCMLVP7OBtZD3bXApqkGhJUQ7d/pa08qrtm32wHVrHwF1rTzvkrvXaG0RFXE9dT0s9Xr4wbBsoRcXUzFKIJqydzFTbMtdhZuJlxixwNGyJrBBGzafRVR/TJISxtHXKAoRBah06oUeNYtbFPs2wCAqChP66dg3RYcyi3mpJbMhaXgYrTVdDT2VU861Kk4XWUDl/moHMIJoA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fz6gJyYDH2FKgfyLnRBJc6Pg7LGjMwC4R5POpxJ6VzY=; b=x+L+J7lCJ8WX6hRY6F3aJLTbIETWhtnLdza+RmaG9qKZr2Vtma4jHCW/qMnKavp7g+BOF6Oy0U+7wgevWnK/E1Z+yvcMAJT7VvvMWHlV2yGaow47PAXtUrBWAEMoptp37EZpn58PfdXI8gT1EBk11Q5Dp4Kp5t2aRLUV6eyjFtg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6994b95900535bbb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9WsJBKe3dS34qSRQEhrXls1hWIS8hgQUdCcgI1lS+IyVwcihsrzLDc/T3TVyQ0Ax94vUcOCcx668rHpQAyvZ1mI/2giBYlruZgS4h6Sti3vs/BFVwsO/tWNoGjgnv6iv8tshG4QuQaYs2+Zw+PzhBZDRqyU1GF8QcDA686hw7kdBbAgUfJPwrREQ/UwY74ioJWGwTmOx87Ai7F8z2R2sug8/CbA5Gyy8unCr4gKr0xmHjrkAn7e6jv2jPo77WhRx3Ls+5w3T6BEAtGi9t6hcCZ2knFnW9ozdDSvxI07bLIlbWFTYv0JbpHKNMPQo24w2JSrntUzShw/8B0pXbu//w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fz6gJyYDH2FKgfyLnRBJc6Pg7LGjMwC4R5POpxJ6VzY=; b=S34BCn2Ho35juyp4Jja1zxEOjy22Jkk/XjuwZrZRSIML7X4Cf+K9gutFoQCUKjVXX4u9ddznAfZ7gQqTEBTMnp4hPXQwifcYqk/xuDOYhARg6spXCxS+HByoiMBqddZVBtZanY6R14BXQbdBLN65HCL5mmVfQ0gCwOHDRlQw1uLqdxkQr6YVNW43ynzOjkxVS1R0K/ZCXO/rWsuqEm4jQMD5DA4C/sPDrAkPv4MZRrbC61bEag1mfyCeWrhwX7eRLBm08LwMpKV/oTyKu0ZM5Hw7/jeYYQZzW8Esi30Mrfn2ArQ/intrS2zaKXPreY+jpF9DNUViZjsJHcRE5jCDTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fz6gJyYDH2FKgfyLnRBJc6Pg7LGjMwC4R5POpxJ6VzY=; b=x+L+J7lCJ8WX6hRY6F3aJLTbIETWhtnLdza+RmaG9qKZr2Vtma4jHCW/qMnKavp7g+BOF6Oy0U+7wgevWnK/E1Z+yvcMAJT7VvvMWHlV2yGaow47PAXtUrBWAEMoptp37EZpn58PfdXI8gT1EBk11Q5Dp4Kp5t2aRLUV6eyjFtg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v5 0/6] Device tree based NUMA support for Arm - Part#2 Date: Tue, 20 Sep 2022 17:12:12 +0800 Message-ID: <20220920091218.1208658-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT049:EE_|DB3PR08MB9134:EE_|VE1EUR03FT064:EE_|DB9PR08MB8316:EE_ X-MS-Office365-Filtering-Correlation-Id: 743e3f97-0cdf-45ef-fa9d-08da9ae846bc x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sTHxk/Ki2LQ11GdPnA8t5/Ujtrd/s6k68SlG7u3oiznw45ojeRLE5dRm/nSb4wU3Ys2xAkjPduW+2S21tzcqjEZMXSIMO61NVooX8q+7lpCaYBXr3E9dv7grKUhGPyilp8Dx82qDCJPIyZ5v/kzOIAk172DoQ8NtHNLzZi6yaPhHdqoSEzrQZJSY5+v62ZS9ZPtJdmLyYHS3wLciZ8egHIoAxgqAghSvLGKCw8PwP1kqDAWaMUiSbN6xdMZbnyXjFHz6Lo8nbEdVYEmemJAZfaDXUdtDLHgr6fr3f97uABFHg31k8K1vS42k4oYZa2EOTO5gSyorTDNKGtkoznzV9UuYS0kfQaCDBNlZas2bNkYCj5z3Im0OLpgpm1hyU80ohLO7BoN1tC4Gaz9q4a+wWQxmgtc1be8BBLxVYBruzmYWwy5lC+oOWOi6ZkoTS+rxNA2OLOMSWQoTaFd3gmEby7K18rGaBJhmq/caLWUc5sNurxZ+SRtGAkMCDypkhj2OIUfQ04bLN7L7I2FdgPQzxej20YchSuWW1I/j4/5nMnbkzB2G6ny3uIWL8BYVU0RzW3wiPldmu288+1adMI2gvSnNF8UprqR4jLKVHNL301/sFgXH7qQMoNTVeqJbgqmtiwy7vNK3hI6nAJWBbV3t6fFdxht7jHe6THFrRh4DSmP+rIXY0WLnScJfyYKuwUzuumhVsA7irWjVvT0XeNDUXncdHtNpXRhxvY8h2RalH3nOCcrWIODlsyvA59KfITMqjNA77dlJGSn5hvox4ckZdDP90ocYINoBSiiTTk4huUGtZLpu/2GAulcwhuoZb6PqLmgWJ+Ge1lFGg6WWKh6hvcK+MJFB5cvJUNFje/SFCHCFDgO4+7E08pQ1R27w5CPL X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(82310400005)(26005)(81166007)(82740400003)(70586007)(40480700001)(6666004)(36860700001)(8676002)(4326008)(966005)(44832011)(2906002)(2616005)(54906003)(41300700001)(356005)(7696005)(186003)(47076005)(70206006)(5660300002)(36756003)(478600001)(86362001)(8936002)(316002)(6916009)(83380400001)(1076003)(40460700003)(426003)(336012)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9134 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 947da64e-3d16-4847-1955-08da9ae8400f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /W6u++J6ISSngSzsRhRXlFj2bpYQokBFeFZtJ9y1JGrOyfQ+tlr9CT5fmTKSVTEwt/pJ/2ZqBw/Sv4PG14Drw0dd+/8YoMTr5oLA3CLcXNKx/HmpJWHVwU5GgHjnW51hHlrXEG7cSOOTxSfjzzL+B6V5wuXJY80lTCNiwzyRc9TAvcENZP4vEI3zcx7NeQFGcCuTm7Ik/fwUwBvOq4DH376R5vcK3tab4MeMKlX4Eur+7ezq+/lm8gldmU3gJKdjaGpNpYtvg1yQDcKqZntTHKjhibxrSI/tU86HB5B9Mu8MSbx7zgby0YmXbTL9n2Zj2sN/vla/Wf2og6JdNJDoraAFuCeD1vo/cWYEexK5anttAk5v/HlP+Jt/4obzmyX0onbL2uZjQUmijDvxXT4k3kRE0qkGmIgGr0I/vyoFqage+tv62SAbw1l+RAlSKNbL1bxkiQ3J0ozGpONKxvUmQEVRKpIfrTH5KHUduO0KVv2/MYeZ6HuJYLUQhSHErKlucfzdKCyNaQpeotChidBuqEgXGvQmUbHfCvtpv9YOTlkVYxuYwYl/npcnFhYjjrQhJum8fcxtqaJqMx6cq5JVAknTkD/CEBimcyRfD6KR5jX/Z0rCZG0iGnDx4IcbIdsZLvOVElcRbQ8lPZ3UTWi/irdrFxJAMGoTDIoCs4od06AzeOARu4aLYUsAOO+LbIhyXVuAerJ5TC0Qg1nUxrO9Zml5A2T1IFicK42q1Xc0N79P7Nd5WqbkyQn3/xGiF2r9Er7t7Xb4PYsfek2rrdnJlzKWiJ8KvPE84uEd3QEn7yy53/eq3G05PX3OPBz5rJRfLQ1uBct4SLe6RXO+M2Fw8A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(81166007)(70206006)(8676002)(8936002)(86362001)(44832011)(70586007)(2906002)(336012)(2616005)(426003)(186003)(83380400001)(47076005)(26005)(6666004)(41300700001)(40460700003)(966005)(107886003)(316002)(7696005)(4326008)(478600001)(6916009)(54906003)(82740400003)(36860700001)(1076003)(40480700001)(5660300002)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:12:43.4664 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 743e3f97-0cdf-45ef-fa9d-08da9ae846bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8316 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - this series. 3. Add new code to support Arm. This series only contains the second part patches. As the whole NUMA series has been reviewed for 1 round in [2], so this series would be v5) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html --- v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. 2. Use nodeid_t instead of uint8_t for memnodemap. 3. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 4. Use __ro_after_init for numa_off. 5. Use pointer-to-const for proper function parameters. 6. Use unsigned int for variables that are not realy used for node ID. 7. Fix code comments code-style and adjust the length. 8. Fix code-styles. 9. Rename numa_scan_nodes to numa_process_nodes. 10. Defer introduce arch_numa_disabled for acpi_numa <= 0. And remove the paramter init_as_disable of arch_numa_disabled. 11. Fix typo "expandsion". 12. Fix Indentation for l1tf_safe_maddr. 13. Remove double blank lines. 14. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 15. Use bool for nodes_cover_memory return value. 16. Use a plain "int ret" to record compute_hash_shift return value. 17. Add a blank line before the function's main "return". 18. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Add init_as_disable as arch_numa_disabled parameter in the patche where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. 3. Restore compute_hash_shift's return value to int. 4. Remove unnecessary parentheses for macros. 5. Use unsigned int for proper variables. 6. Fix some code-style. 7. Move arch_get_ram_range function comment to header file. 8. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges. 10. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 11. Move mem_hotplug to a proper place in mm.h 12. Remove useless "size" in numa_scan_nodes. 13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch. 5. Remove acpi.h from common/numa.c. 6. Rename acpi_scan_nodes to numa_scan_nodes. 7. Replace u8 by uint8_t for memnodemap. 8. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 9. Use nodeid_t for nodeid and node numbers. 10. Use __read_mostly and __ro_after_init for appropriate variables. 11. Adjust the __read_mostly and __initdata location for some variables. 12. Convert from plain int to unsigned for cpuid and other proper 13. Remove unnecessary change items in history. 14. Rename arch_get_memory_map to arch_get_ram_range. 15. Use -ENOENT instead of -ENODEV to indicate end of memory map. 16. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. 17. Rename bad_srat to numa_fw_bad. 18. Rename node_to_pxm to numa_node_to_arch_nid. 19. Merge patch#7 and #8 into patch#6. 20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 22. Use 2-64 for node range. v1 -> v2: 1. Refine the commit messages of several patches. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa. 5. Correct return value of srat_disabled. 6. Introduce numa_enabled_with_firmware. 7. Refine the justification of using !node_data[nid].node_spanned_pages. 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 9. Adjust the conditional express for ASSERT. 10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 11. Use conditional macro to gate MAX_NUMNODES for other architectures. 12. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 13. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. 14. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 15. Merge this single patch instead of serval patches to move x86 SRAT code to common. 16. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 17. Change the code style to target file's Xen code-style. 18. Adjust some __init and __initdata for some functions and variables. 19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts. 20. Turn numa_scan_nodes to static. 21. Change NR_NUMA_NODES upper bound from 4095 to 255. Wei Chen (6): xen/x86: Provide helpers for common code to access acpi_numa xen/x86: move generically usable NUMA code from x86 to common xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid xen/x86: use arch_get_ram_range to get information from E820 map xen/x86: move NUMA scan nodes codes from x86 to common xen: introduce a Kconfig option to configure NUMA nodes number xen/arch/Kconfig | 11 + xen/arch/x86/include/asm/acpi.h | 2 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 61 +-- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 438 +---------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 311 ++---------- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/numa.c | 780 +++++++++++++++++++++++++++++++ xen/common/page_alloc.c | 2 + xen/drivers/acpi/Kconfig | 1 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 98 +++- 16 files changed, 943 insertions(+), 774 deletions(-) create mode 100644 xen/common/numa.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:12:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:12:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409248.652237 (Exim 4.92) (envelope-from ) id 1oaZJJ-0004Al-BG; Tue, 20 Sep 2022 09:12:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409248.652237; Tue, 20 Sep 2022 09:12:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJJ-0004Aa-6c; Tue, 20 Sep 2022 09:12:57 +0000 Received: by outflank-mailman (input) for mailman id 409248; Tue, 20 Sep 2022 09:12:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJH-0003bf-Kc for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:12:56 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68200bdd-38c4-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 11:12:53 +0200 (CEST) Received: from AS9PR06CA0463.eurprd06.prod.outlook.com (2603:10a6:20b:49a::14) by DBBPR08MB6202.eurprd08.prod.outlook.com (2603:10a6:10:209::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:49 +0000 Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::a) by AS9PR06CA0463.outlook.office365.com (2603:10a6:20b:49a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 09:12:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:49 +0000 Received: ("Tessian outbound 88978e6d60db:v124"); Tue, 20 Sep 2022 09:12:49 +0000 Received: from 4f26d7b3c6dd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ABBB8001-29BB-4FE5-8F44-555F8579C02B.1; Tue, 20 Sep 2022 09:12:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4f26d7b3c6dd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:42 +0000 Received: from FR0P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::8) by DU0PR08MB8640.eurprd08.prod.outlook.com (2603:10a6:10:400::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Tue, 20 Sep 2022 09:12:39 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a9:cafe::ef) by FR0P281CA0098.outlook.office365.com (2603:10a6:d10:a9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 09:12:39 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:38 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:37 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:36 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68200bdd-38c4-11ed-bad8-01ff208a15ba ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WikNt3T2D+1c8HGdKuuF+lmtDrzW9iJUduWjkz8KIPExHtkA3fmMj5eZOBA4Kd1dCzniWyC/Gaz1jZP99m7udPIZJOPorkPkoWcg/LqskDR+IUkI5CtJrXNUWAVABXum4kFAFuLZmtEhTfEnwZjRsiCPZLLc/kI16wlsauWc2amZ02s597yhYnWYMpMAHpQI9q5JgmFE3r1fZhbV+0cmWojDsNjBztwXVGGfWCHUk3QvJ34AeeZGMajo1HIwlGhidBJzn2c1sfBNOS5uYs2QJRyUQQtFRJsR/3SAzpAqHdWb9QT0ameA2WuWotCqVIs1+XVaP1Lp5uzqIAWfygbMfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y2r/TOMmMEno0c/Cxr26T3Lnpm0ZYT9VB9tKKopDfkc=; b=lNxjOeBrpikCkU2L9mots4Y1cx+xIIxL35Mq6ZjVvh0Kecs2UxhVAafBHyqxvo/pqU9Ym/68Pz5tOVuXmlJ0OmM6tdrgS0SKlcmGnSFLSA/iOMs8m4d2cuvmgvhjxnrC5w+FY/JO6AqOwCRgFjCurau8YR62BdTAmbNN9jtglSd38k92aHM0KXp9imU6+FopFEVCwNFXsRRV+NJnReZfulIFs3xNNWTMn1KB1htU+8xH8vyl9slrlEdxxC/zYTy4rRJBdR/g4N2dBvAwMX00IErz7oBgXtHuSYQ4G7/ml2/s9slgjFmD0ImNu4IbqxOnam3++Ngrs9+uij1oBlzRZw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y2r/TOMmMEno0c/Cxr26T3Lnpm0ZYT9VB9tKKopDfkc=; b=PFfNwME/EePSHDeHjiWngMG+GT9r+cpOjIPXu7RuckYYdtn0SbcLjAdpmFHR5ScDZH6iTCmaFc3566e3fyK9li2blSgY2SKXHdxCGwDFn18f2HpX4pMByLkrkr7X9JlvraMGu6gRVOMgR8LRmZjEDbDOhlywtuMyJnTNDWFkJnk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f0105f0c541f1eeb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LbJkBl5J9J98rNa/KPnZIzg4TBaSH6MoIKxzWaKDpqsXJdkq4UIn0FlSf1A9Y9OyuKLNQ24H/btnFNsKriStktTVGw8PhsF5wXclunKYItSNgzRQIFjkTPCW2T0b0eskfUyvxnT/gKaCqsDY1NIiqVFPMIaEFG9qUomrfj8vsbrWZ4S+H9APMxw43Gld2viKBTASrxALcqwLUDWyaAnNpooC25EISXv2u5DLToXzTyLBVcOh0SKl0sW+bpV+ma7kHstWrRFSS0DlvPZD7sfnpzwLrTdYgZ7N3gLPSuhWlstFpHHyTyx47egmuqPTEw+icvuI8v+agWsiQa4Q3hu3XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y2r/TOMmMEno0c/Cxr26T3Lnpm0ZYT9VB9tKKopDfkc=; b=CZZ4BvgIp4CpjLpx4a58VZuVXJoWLl0+tv+tMIYUFkH6Uh84oCyzpAEH0iYGpfMMInjX8zHP5MgAYij8aChshYilixW5zcpQ79aQ3rb65RgiBC394wBaMo5XYi4e5SFSzWVpUuwkNVamqRGsK0OTkrWn/hCIQFuvuigAA6pH5udb/2fwQBmJzMf9H6LXqASajfEtqveS0xo6Vz3EBpYFgxEcQWYfO1Z6yOoQyjHrUaNaGcVvr6lZ+9DlnXzTA01s+siHmfSnoXKUM2bmll00v3DUmETzvkOHfYFq00EDcTxNuosIXU9xcEBbLBwEe6zGIfgQVF8TcTRMt+VAXc8IzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y2r/TOMmMEno0c/Cxr26T3Lnpm0ZYT9VB9tKKopDfkc=; b=PFfNwME/EePSHDeHjiWngMG+GT9r+cpOjIPXu7RuckYYdtn0SbcLjAdpmFHR5ScDZH6iTCmaFc3566e3fyK9li2blSgY2SKXHdxCGwDFn18f2HpX4pMByLkrkr7X9JlvraMGu6gRVOMgR8LRmZjEDbDOhlywtuMyJnTNDWFkJnk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Date: Tue, 20 Sep 2022 17:12:14 +0800 Message-ID: <20220920091218.1208658-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920091218.1208658-1-wei.chen@arm.com> References: <20220920091218.1208658-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT016:EE_|DU0PR08MB8640:EE_|AM7EUR03FT030:EE_|DBBPR08MB6202:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b7b261f-3faa-4888-7d82-08da9ae84a3c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9TVz0ldV5jwnOX5ZXjIUf6sfc6f7wPZIIXCUMGnr7W1klig85P20HuUy/RUwjexkdhO7/zBAciiDmocPF9zCFXhfvIViEPtSh65TxmoKOIGqDU+3X/wjtqlfyqa1mts9sSLlCxyWfPOIjvclZxvWZTPZBphNGZGa9c5bZfh4N7Lytn2J3t2orKxl3s2a5sQ2xpPgxjiz30sddmxy+UpNT2KK0ST/KYVIktP/ukxyy9DVFKYSIi5uxS0VC5P/QCY8RMHyYZBYKE84AuSr7PphuZPW9mWL2TfXgQS8wRvIDbwrkw6kLUzfod7Bb/dDa49DXPVduNjiOhoU9ZoVGuw0dLR0Yz8PHV+j8VPidGVieELl/itbwvO+HTRP/VD58iUCa+rgNMeEynNVliZIj4J6yjw/Wza8KN+LX8FJkegRhRKhkdhBR8aXob9fGv8HJmvJxEtja8GPTvLzypysU3N+xXZa49R3bcuemqLGdMYOoyt2jCGrV+QtxZ6X4TKYeqfL1nqy29JzuAwtM8aQSKsOww5pWh43NVCYY1tGZ5I2RoiYRtM8Z/iyRUw6YwOkg3rYzur9Mf2N56af4zdbi1WLJolJ61UHOdxr5kSjDB1SmOILIziBTwvfP4uuF9d3F0QFnv6a0L8+2n5jFFTcJdu7a/6AbeEBs4VAA+SuQeIExVfrJV3Y2x15ibQr7eZbIKYgGpYtgmgdMtxwZygxnVG0ASH+62R0xFX0YWYhg42Y948acPkh0s5Ao5bg3+5U6KpSQB4b4YGgLDVYHn2dGKXeJHGjYqfFF32rBcJLgeQ6qVso+TF63SnHtlIqnpS6Apxx3oBHuHdTxsS0jTF2Y9PncQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(186003)(336012)(1076003)(2616005)(426003)(356005)(6916009)(316002)(478600001)(82740400003)(5660300002)(54906003)(86362001)(40460700003)(36756003)(40480700001)(81166007)(82310400005)(6666004)(26005)(7696005)(83380400001)(41300700001)(36860700001)(47076005)(4326008)(30864003)(70206006)(8676002)(2906002)(8936002)(70586007)(44832011)(21314003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8640 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0236ca6f-382c-43e3-3dfc-08da9ae843dc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tzgUdJETwuROY2xjZkjAQFTsbwlHiJEG0ZfOPsVFomE2XKWd38CT0fmUBIS8N9UVm8b9zfFpXqCIRMi+CRnmbDCX9zkc5UK2uNGD2nfTMnRxoFll07UAiuBwi5gKrpA+3d1rai5DLyJJk4oYymiZA42yej6+yzWPiv1gTmliVtpCi+TQ6aSM/GhMbgp7iWnkzNZ9F9d+HHAcGOwiJYnq1uqv8dYH80mA0BrvrpVK7FQitPjl0qjdHlfIPVy/vYZdzK/MCg916YejuqlQctU9hNmq4/TaJPcOVy4yT0x5b57uYCs1Wb7GPMEvdTmLWDRwvwii3UkkpY0OxZBq74PVZHw2tVbhMgcTOaKlgM2VHVspb0dJT6syaOd0Rggb4DS3wkb6ux5pu+dD/71tQvxh9716oim7MqdMeL0S2s5DRUBy8B+OoyTAyyf0JaICLyz9fm2q/+cd1zz1pcPYN47+mcjtxnncv+WkTjYBKPLyUAuqbuwJocQTZPsxAavQCVpxbkRGrs/fPs5kSpTnZ/vbyMoaSvjbNnkPjh+rFcgT12ndeOINmwwbQJsw5wrfGUOGJoT0Id99Yf8Kz9VkEwqxQp0etMbTH8MED82cHSQkd1vRAXykd/ng7VJ0ZgYhj2l0xITdKMQiqTfbtXb1+jDygAMPOHC+LzBS5mCml/AvUD3xdN2X43RAqGmHJJhlOB+n7nWYs1zJAN0VtamvELO93tdw3nC4zZPzdTgSk0F7E8zSVWmuzR6Ik6E+7McnBsnIarkqPKqjFPeCI8tiEBU4NC3wDVqLrrEhWteK2C7L5m4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(30864003)(44832011)(82740400003)(6666004)(47076005)(426003)(336012)(41300700001)(8936002)(54906003)(107886003)(2616005)(8676002)(1076003)(2906002)(36756003)(83380400001)(82310400005)(70206006)(70586007)(4326008)(316002)(6916009)(26005)(5660300002)(40460700003)(478600001)(7696005)(186003)(40480700001)(81166007)(86362001)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:12:49.4289 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7b261f-3faa-4888-7d82-08da9ae84a3c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6202 There are some codes in x86/numa.c can be shared by common architectures to implememnt NUMA support. Just like some variables and functions to check and store NUMA memory map. And some variables and functions to do NUMA initialization. In this patch, we move them to common/numa.c and xen/numa.h and use the CONFIG_NUMA to gate them for non-NUMA supported architectures. As the target header file is Xen-style, so we trim some spaces and replace tabs for the codes that has been moved to xen/numa.h at the same time. As acpi_scan_nodes has been used in a common function, it doesn't make sense to use acpi_xxx in common code, so we rename it to numa_scan_nodes in this patch too. After that if we still use CONFIG_ACPI_NUMA in to gate numa_scan_nodes in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA will be selected by CONFIG_ACPI_NUMA for x86. So, we replace CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_scan_nodes. As arch_numa_disabled has been implememnted for ACPI NUMA, we can rename srat_disabled to numa_disabled and move it to common code as well. Signed-off-by: Wei Chen --- v4 -> v5: 1. Use nodeid_t instead of uint8_t for memnodemap. 2. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 3. Use __ro_after_init for numa_off. 4. Use pointer-to-const for proper function parameters. 5. Use unsigned int for variables that are not realy used for node ID. 6. Fix code comments code-style and adjust the length. 7. Fix code-styles. 8. Rename numa_scan_nodes to numa_process_nodes. 9. Use a plain "int ret" to record compute_hash_shift return value. v3 -> v4: 1. Restore compute_hash_shift's return value to int. 2. Remove unnecessary parentheses for macros. 3. Use unsigned int for proper variables. 4. Fix some code-style. v2 -> v3: 1. Remove acpi.h from common/numa.c. 2. Rename acpi_scan_nodes to numa_scan_nodes. 3. Replace u8 by uint8_t for memnodemap. 4. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 5. Use nodeid_t for nodeid and node numbers. 6. Use __read_mostly and __ro_after_init for appropriate variables. 7. Adjust the __read_mostly and __initdata location for some variables. 8. convert from plain int to unsigned for cpuid and other proper variables. 9. Use __attribute_pure__ instead of __attribute__((pure)). 10. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA in numa_initmem_init. 11. Add const for some functions' parameters. 12. Move srat_disabled to common code with new name numa_disabled. 13. Fix some spaces code-style for numa_emulation. 14. Change from int to unsigned int for numa_fake. v1 -> v2: 1. New patch in v2. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/numa.h | 57 +--- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/numa.c | 430 +---------------------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 10 +- xen/common/Makefile | 1 + xen/common/numa.c | 460 +++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 67 +++++ 9 files changed, 536 insertions(+), 493 deletions(-) create mode 100644 xen/common/numa.c diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 9a9cc4c240..5c2dd5da2d 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 529efadf93..6c87942d43 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -9,72 +9,17 @@ typedef u8 nodeid_t; extern int srat_rev; -extern nodeid_t cpu_to_node[NR_CPUS]; -extern cpumask_t node_to_cpumask[]; - -#define cpu_to_node(cpu) (cpu_to_node[cpu]) -#define parent_node(node) (node) -#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) -#define node_to_cpumask(node) (node_to_cpumask[node]) - -struct node { - paddr_t start, end; -}; - -extern int compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids); extern nodeid_t pxm_to_node(unsigned int pxm); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) -#define VIRTUAL_BUG_ON(x) -extern void numa_add_cpu(int cpu); -extern void numa_init_array(void); -extern bool numa_off; - -extern int arch_numa_setup(const char *opt); -extern bool arch_numa_broken(void); -extern bool srat_disabled(void); -extern void numa_set_node(int cpu, nodeid_t node); +extern bool numa_disabled(void); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); -static inline void clear_node_cpumask(int cpu) -{ - cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -/* Simple perfect hash to map pdx to node numbers */ -extern int memnode_shift; -extern unsigned long memnodemapsize; -extern u8 *memnodemap; - -struct node_data { - unsigned long node_start_pfn; - unsigned long node_spanned_pages; -}; - -extern struct node_data node_data[]; - -static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) -{ - nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); - nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); - return nid; -} - -#define NODE_DATA(nid) (&(node_data[nid])) - -#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) -#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) -#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ - NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..ae470ea12f 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -20,7 +20,6 @@ void early_time_init(void); void set_nr_cpu_ids(unsigned int max_cpus); -void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); void arch_init_memory(void); void subarch_init_memory(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 1ab37b9c19..21efb1b1b3 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -4,20 +4,11 @@ * Adapted for Xen: Ryan Harper */ -#include -#include #include -#include +#include #include #include -#include -#include -#include -#include -#include #include -#include -#include #ifndef Dprintk #define Dprintk(x...) @@ -26,28 +17,13 @@ /* from proto.h */ #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1))) -struct node_data node_data[MAX_NUMNODES]; - -/* Mapping from pdx to node id */ -int memnode_shift; -static typeof(*memnodemap) _memnodemap[64]; -unsigned long memnodemapsize; -u8 *memnodemap; - -nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { - [0 ... NR_CPUS-1] = NUMA_NO_NODE -}; /* * Keep BIOS's CPU2node information, should not be used for memory allocaion */ nodeid_t apicid_to_node[MAX_LOCAL_APIC] = { [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE }; -cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; -nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; - -bool numa_off; s8 acpi_numa = 0; int __init arch_numa_setup(const char *opt) @@ -69,267 +45,6 @@ bool arch_numa_broken(void) return acpi_numa < 0; } -bool srat_disabled(void) -{ - return numa_off || arch_numa_broken(); -} - -/* - * Given a shift value, try to populate memnodemap[] - * Returns : - * 1 if OK - * 0 if memnodmap[] too small (of shift too small) - * -1 if node overlap or lost ram (shift too big) - */ -static int __init populate_memnodemap(const struct node *nodes, - int numnodes, int shift, nodeid_t *nodeids) -{ - unsigned long spdx, epdx; - int i, res = -1; - - memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - if ( (epdx >> shift) >= memnodemapsize ) - return 0; - do { - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) - return -1; - - if ( !nodeids ) - memnodemap[spdx >> shift] = i; - else - memnodemap[spdx >> shift] = nodeids[i]; - - spdx += (1UL << shift); - } while ( spdx < epdx ); - res = 1; - } - - return res; -} - -static int __init allocate_cachealigned_memnodemap(void) -{ - unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); - unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); - - memnodemap = mfn_to_virt(mfn); - mfn <<= PAGE_SHIFT; - size <<= PAGE_SHIFT; - printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", - mfn, mfn + size); - memnodemapsize = size / sizeof(*memnodemap); - - return 0; -} - -/* - * The LSB of all start and end addresses in the node map is the value of the - * maximum possible shift. - */ -static int __init extract_lsb_from_nodes(const struct node *nodes, - int numnodes) -{ - int i, nodes_used = 0; - unsigned long spdx, epdx; - unsigned long bitfield = 0, memtop = 0; - - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - bitfield |= spdx; - nodes_used++; - if ( epdx > memtop ) - memtop = epdx; - } - if ( nodes_used <= 1 ) - i = BITS_PER_LONG - 1; - else - i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = (memtop >> i) + 1; - return i; -} - -int __init compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids) -{ - int shift; - - shift = extract_lsb_from_nodes(nodes, numnodes); - if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) - memnodemap = _memnodemap; - else if ( allocate_cachealigned_memnodemap() ) - return -1; - printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); - - if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) - { - printk(KERN_INFO "Your memory is not aligned you need to " - "rebuild your hypervisor with a bigger NODEMAPSIZE " - "shift=%d\n", shift); - return -1; - } - - return shift; -} -/* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) -{ - unsigned long start_pfn = paddr_to_pfn(start); - unsigned long end_pfn = paddr_to_pfn(end); - - NODE_DATA(nodeid)->node_start_pfn = start_pfn; - NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; - - node_set_online(nodeid); -} - -void __init numa_init_array(void) -{ - int rr, i; - - /* There are unfortunately some poorly designed mainboards around - that only connect memory to a single CPU. This breaks the 1:1 cpu->node - mapping. To avoid this fill in the mapping for all possible - CPUs, as the number of CPUs is not known yet. - We round robin the existing nodes. */ - rr = first_node(node_online_map); - for ( i = 0; i < nr_cpu_ids; i++ ) - { - if ( cpu_to_node[i] != NUMA_NO_NODE ) - continue; - numa_set_node(i, rr); - rr = cycle_node(rr, node_online_map); - } -} - -#ifdef CONFIG_NUMA_EMU -static int numa_fake __initdata = 0; - -/* Numa emulation */ -static int __init numa_emulation(unsigned long start_pfn, - unsigned long end_pfn) -{ - int i; - struct node nodes[MAX_NUMNODES]; - uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; - - /* Kludge needed for the hash function */ - if ( hweight64(sz) > 1 ) - { - u64 x = 1; - while ( (x << 1) < sz ) - x <<= 1; - if ( x < sz/2 ) - printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); - sz = x; - } - - memset(&nodes,0,sizeof(nodes)); - for ( i = 0; i < numa_fake; i++ ) - { - nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; - if ( i == numa_fake - 1 ) - sz = pfn_to_paddr(end_pfn) - nodes[i].start; - nodes[i].end = nodes[i].start + sz; - printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", - i, - nodes[i].start, nodes[i].end, - (nodes[i].end - nodes[i].start) >> 20); - node_set_online(i); - } - memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); - if ( memnode_shift < 0 ) - { - memnode_shift = 0; - printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); - return -1; - } - for_each_online_node ( i ) - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - numa_init_array(); - - return 0; -} -#endif - -void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) -{ - int i; - paddr_t start = pfn_to_paddr(start_pfn); - paddr_t end = pfn_to_paddr(end_pfn); - -#ifdef CONFIG_NUMA_EMU - if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) - return; -#endif - -#ifdef CONFIG_ACPI_NUMA - if ( !numa_off && !acpi_scan_nodes(start, end) ) - return; -#endif - - printk(KERN_INFO "%s\n", - numa_off ? "NUMA turned off" : "No NUMA configuration found"); - - printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", - start, end); - /* setup dummy node covering all memory */ - memnode_shift = BITS_PER_LONG - 1; - memnodemap = _memnodemap; - /* Dummy node only uses 1 slot in reality */ - memnodemap[0] = 0; - memnodemapsize = 1; - - nodes_clear(node_online_map); - node_set_online(0); - for ( i = 0; i < nr_cpu_ids; i++ ) - numa_set_node(i, 0); - cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); - setup_node_bootmem(0, start, end); -} - -void numa_add_cpu(int cpu) -{ - cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -void numa_set_node(int cpu, nodeid_t node) -{ - cpu_to_node[cpu] = node; -} - -/* [numa=off] */ -static int __init cf_check numa_setup(const char *opt) -{ - if ( !strncmp(opt, "off", 3) ) - numa_off = true; - else if ( !strncmp(opt, "on", 2) ) - numa_off = false; -#ifdef CONFIG_NUMA_EMU - else if ( !strncmp(opt, "fake=", 5) ) - { - numa_off = false; - numa_fake = simple_strtoul(opt + 5, NULL, 0); - if ( numa_fake >= MAX_NUMNODES ) - numa_fake = MAX_NUMNODES; - } -#endif - else - return arch_numa_setup(opt); - - return 0; -} -custom_param("numa", numa_setup); - /* * Setup early cpu_to_node. * @@ -378,146 +93,3 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } - -static void cf_check dump_numa(unsigned char key) -{ - s_time_t now = NOW(); - unsigned int i, j, n; - struct domain *d; - struct page_info *page; - unsigned int page_num_node[MAX_NUMNODES]; - const struct vnuma_info *vnuma; - - printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, - now); - - for_each_online_node ( i ) - { - paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); - - printk("NODE%u start->%lu size->%lu free->%lu\n", - i, node_start_pfn(i), node_spanned_pages(i), - avail_node_heap_pages(i)); - /* sanity check phys_to_nid() */ - if ( phys_to_nid(pa) != i ) - printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", - pa, phys_to_nid(pa), i); - } - - j = cpumask_first(&cpu_online_map); - n = 0; - for_each_online_cpu ( i ) - { - if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) - { - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - j = i; - n = 1; - } - else - ++n; - } - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - - rcu_read_lock(&domlist_read_lock); - - printk("Memory location of each domain:\n"); - for_each_domain ( d ) - { - process_pending_softirqs(); - - printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); - - for_each_online_node ( i ) - page_num_node[i] = 0; - - spin_lock(&d->page_alloc_lock); - page_list_for_each(page, &d->page_list) - { - i = phys_to_nid(page_to_maddr(page)); - page_num_node[i]++; - } - spin_unlock(&d->page_alloc_lock); - - for_each_online_node ( i ) - printk(" Node %u: %u\n", i, page_num_node[i]); - - if ( !read_trylock(&d->vnuma_rwlock) ) - continue; - - if ( !d->vnuma ) - { - read_unlock(&d->vnuma_rwlock); - continue; - } - - vnuma = d->vnuma; - printk(" %u vnodes, %u vcpus, guest physical layout:\n", - vnuma->nr_vnodes, d->max_vcpus); - for ( i = 0; i < vnuma->nr_vnodes; i++ ) - { - unsigned int start_cpu = ~0U; - - if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) - printk(" %3u: pnode ???,", i); - else - printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); - - printk(" vcpus "); - - for ( j = 0; j < d->max_vcpus; j++ ) - { - if ( !(j & 0x3f) ) - process_pending_softirqs(); - - if ( vnuma->vcpu_to_vnode[j] == i ) - { - if ( start_cpu == ~0U ) - { - printk("%d", j); - start_cpu = j; - } - } - else if ( start_cpu != ~0U ) - { - if ( j - 1 != start_cpu ) - printk("-%d ", j - 1); - else - printk(" "); - start_cpu = ~0U; - } - } - - if ( start_cpu != ~0U && start_cpu != j - 1 ) - printk("-%d", j - 1); - - printk("\n"); - - for ( j = 0; j < vnuma->nr_vmemranges; j++ ) - { - if ( vnuma->vmemrange[j].nid == i ) - printk(" %016"PRIx64" - %016"PRIx64"\n", - vnuma->vmemrange[j].start, - vnuma->vmemrange[j].end); - } - } - - read_unlock(&d->vnuma_rwlock); - } - - rcu_read_unlock(&domlist_read_lock); -} - -static int __init cf_check register_numa_trigger(void) -{ - register_keyhandler('u', dump_numa, "dump NUMA info", 1); - return 0; -} -__initcall(register_numa_trigger); - diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b46fd9ab18..9df08e9366 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1350,7 +1350,7 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm) x86_acpiid_to_apicid[acpi_id] = apic_id; - if ( !srat_disabled() ) + if ( !numa_disabled() ) { nodeid_t node = setup_node(pxm); diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index b62a152911..0d4f7cccb9 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -238,7 +238,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { bad_srat(); @@ -274,7 +274,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { bad_srat(); @@ -313,7 +313,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) nodeid_t node; unsigned int i; - if (srat_disabled()) + if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { bad_srat(); @@ -519,8 +519,8 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(paddr_t start, paddr_t end) +/* Use discovered information to actually set up the nodes. */ +int __init numa_process_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; diff --git a/xen/common/Makefile b/xen/common/Makefile index 3baf83d527..9a3a12b12d 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o obj-y += multicall.o obj-y += notifier.o +obj-$(CONFIG_NUMA) += numa.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o diff --git a/xen/common/numa.c b/xen/common/numa.c new file mode 100644 index 0000000000..83f4c8cc94 --- /dev/null +++ b/xen/common/numa.c @@ -0,0 +1,460 @@ +/* + * Generic VM initialization for NUMA setups. + * Copyright 2002,2003 Andi Kleen, SuSE Labs. + * Adapted for Xen: Ryan Harper + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +struct node_data __ro_after_init node_data[MAX_NUMNODES]; + +/* Mapping from pdx to node id */ +unsigned int __ro_after_init memnode_shift; +unsigned long __ro_after_init memnodemapsize; +nodeid_t *__ro_after_init memnodemap; +static typeof(*memnodemap) __ro_after_init _memnodemap[64]; + +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { + [0 ... NR_CPUS-1] = NUMA_NO_NODE +}; + +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; + +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; + +bool __ro_after_init numa_off; + +bool numa_disabled(void) +{ + return numa_off || arch_numa_broken(); +} + +/* + * Given a shift value, try to populate memnodemap[] + * Returns : + * 1 if OK + * 0 if memnodmap[] too small (of shift too small) + * -1 if node overlap or lost ram (shift too big) + */ +static int __init populate_memnodemap(const struct node *nodes, + unsigned int numnodes, unsigned int shift, + const nodeid_t *nodeids) +{ + unsigned long spdx, epdx; + unsigned int i; + int res = -1; + + memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); + + for ( i = 0; i < numnodes; i++ ) + { + spdx = paddr_to_pdx(nodes[i].start); + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + + if ( spdx >= epdx ) + continue; + + if ( (epdx >> shift) >= memnodemapsize ) + return 0; + + do { + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) + return -1; + + if ( !nodeids ) + memnodemap[spdx >> shift] = i; + else + memnodemap[spdx >> shift] = nodeids[i]; + + spdx += (1UL << shift); + } while ( spdx < epdx ); + + res = 1; + } + + return res; +} + +static int __init allocate_cachealigned_memnodemap(void) +{ + unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); + unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); + + memnodemap = mfn_to_virt(mfn); + mfn <<= PAGE_SHIFT; + size <<= PAGE_SHIFT; + printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", + mfn, mfn + size); + memnodemapsize = size / sizeof(*memnodemap); + + return 0; +} + +/* + * The LSB of all start and end addresses in the node map is the value of the + * maximum possible shift. + */ +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, + nodeid_t numnodes) +{ + unsigned int i, nodes_used = 0; + unsigned long spdx, epdx; + unsigned long bitfield = 0, memtop = 0; + + for ( i = 0; i < numnodes; i++ ) + { + spdx = paddr_to_pdx(nodes[i].start); + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + + if ( spdx >= epdx ) + continue; + + bitfield |= spdx; + nodes_used++; + if ( epdx > memtop ) + memtop = epdx; + } + + if ( nodes_used <= 1 ) + i = BITS_PER_LONG - 1; + else + i = find_first_bit(&bitfield, sizeof(unsigned long) * 8); + + memnodemapsize = (memtop >> i) + 1; + + return i; +} + +int __init compute_hash_shift(const struct node *nodes, + unsigned int numnodes, const nodeid_t *nodeids) +{ + unsigned int shift = extract_lsb_from_nodes(nodes, numnodes); + + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) + memnodemap = _memnodemap; + else if ( allocate_cachealigned_memnodemap() ) + return -1; + + printk(KERN_DEBUG "NUMA: Using %u for the hash shift\n", shift); + + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) + { + printk(KERN_INFO "Your memory is not aligned you need to " + "rebuild your hypervisor with a bigger NODEMAPSIZE " + "shift=%u\n", shift); + return -1; + } + + return shift; +} + +/* Initialize NODE_DATA given nodeid and start/end */ +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); + + NODE_DATA(nodeid)->node_start_pfn = start_pfn; + NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; + + node_set_online(nodeid); +} + +void __init numa_init_array(void) +{ + unsigned int i; + nodeid_t rr; + + /* + * There are unfortunately some poorly designed mainboards + * around that only connect memory to a single CPU. This + * breaks the 1:1 cpu->node mapping. To avoid this fill in + * the mapping for all possible CPUs, as the number of CPUs + * is not known yet. We round robin the existing nodes. + */ + rr = first_node(node_online_map); + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] != NUMA_NO_NODE ) + continue; + numa_set_node(i, rr); + rr = cycle_node(rr, node_online_map); + } +} + +#ifdef CONFIG_NUMA_EMU +static unsigned int __initdata numa_fake; + +/* Numa emulation */ +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) +{ + int ret; + unsigned int i; + struct node nodes[MAX_NUMNODES]; + uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; + + /* Kludge needed for the hash function */ + if ( hweight64(sz) > 1 ) + { + uint64_t x = 1; + + while ( (x << 1) < sz ) + x <<= 1; + if ( x < sz / 2 ) + printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); + sz = x; + } + + memset(&nodes, 0, sizeof(nodes)); + for ( i = 0; i < numa_fake; i++ ) + { + nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; + + if ( i == numa_fake - 1 ) + sz = pfn_to_paddr(end_pfn) - nodes[i].start; + + nodes[i].end = nodes[i].start + sz; + printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", + i, nodes[i].start, nodes[i].end, + (nodes[i].end - nodes[i].start) >> 20); + node_set_online(i); + } + + ret = compute_hash_shift(nodes, numa_fake, NULL); + if ( ret < 0 ) + { + printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); + return -1; + } + memnode_shift = ret; + + for_each_online_node ( i ) + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + + numa_init_array(); + + return 0; +} +#endif + +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) +{ + unsigned int i; + paddr_t start = pfn_to_paddr(start_pfn); + paddr_t end = pfn_to_paddr(end_pfn); + +#ifdef CONFIG_NUMA_EMU + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) + return; +#endif + +#ifdef CONFIG_NUMA + if ( !numa_off && !numa_process_nodes(start, end) ) + return; +#endif + + printk(KERN_INFO "%s\n", + numa_off ? "NUMA turned off" : "No NUMA configuration found"); + + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", + start, end); + + /* Setup dummy node covering all memory */ + memnode_shift = BITS_PER_LONG - 1; + memnodemap = _memnodemap; + + /* Dummy node only uses 1 slot in reality */ + memnodemap[0] = 0; + memnodemapsize = 1; + + nodes_clear(node_online_map); + node_set_online(0); + for ( i = 0; i < nr_cpu_ids; i++ ) + numa_set_node(i, 0); + + cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); + setup_node_bootmem(0, start, end); +} + +void numa_add_cpu(unsigned int cpu) +{ + cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +void numa_set_node(unsigned int cpu, nodeid_t node) +{ + cpu_to_node[cpu] = node; +} + +/* [numa=off] */ +static int __init cf_check numa_setup(const char *opt) +{ + if ( !strncmp(opt, "off", 3) ) + numa_off = true; + else if ( !strncmp(opt, "on", 2) ) + numa_off = false; +#ifdef CONFIG_NUMA_EMU + else if ( !strncmp(opt, "fake=", 5) ) + { + numa_off = false; + numa_fake = simple_strtoul(opt + 5, NULL, 0); + if ( numa_fake >= MAX_NUMNODES ) + numa_fake = MAX_NUMNODES; + } +#endif + else + return arch_numa_setup(opt); + + return 0; +} +custom_param("numa", numa_setup); + +static void cf_check dump_numa(unsigned char key) +{ + s_time_t now = NOW(); + unsigned int i, j, n; + struct domain *d; + const struct page_info *page; + unsigned int page_num_node[MAX_NUMNODES]; + const struct vnuma_info *vnuma; + + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, + now); + + for_each_online_node ( i ) + { + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); + + printk("NODE%u start->%lu size->%lu free->%lu\n", + i, node_start_pfn(i), node_spanned_pages(i), + avail_node_heap_pages(i)); + /* Sanity check phys_to_nid() */ + if ( phys_to_nid(pa) != i ) + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", + pa, phys_to_nid(pa), i); + } + + j = cpumask_first(&cpu_online_map); + n = 0; + for_each_online_cpu ( i ) + { + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) + { + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + j = i; + n = 1; + } + else + ++n; + } + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + + rcu_read_lock(&domlist_read_lock); + + printk("Memory location of each domain:\n"); + for_each_domain ( d ) + { + process_pending_softirqs(); + + printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); + + for_each_online_node ( i ) + page_num_node[i] = 0; + + spin_lock(&d->page_alloc_lock); + page_list_for_each ( page, &d->page_list ) + { + i = phys_to_nid(page_to_maddr(page)); + page_num_node[i]++; + } + spin_unlock(&d->page_alloc_lock); + + for_each_online_node ( i ) + printk(" Node %u: %u\n", i, page_num_node[i]); + + if ( !read_trylock(&d->vnuma_rwlock) ) + continue; + + if ( !d->vnuma ) + { + read_unlock(&d->vnuma_rwlock); + continue; + } + + vnuma = d->vnuma; + printk(" %u vnodes, %u vcpus, guest physical layout:\n", + vnuma->nr_vnodes, d->max_vcpus); + for ( i = 0; i < vnuma->nr_vnodes; i++ ) + { + unsigned int start_cpu = ~0U; + + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) + printk(" %3u: pnode ???,", i); + else + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); + + printk(" vcpus "); + + for ( j = 0; j < d->max_vcpus; j++ ) + { + if ( !(j & 0x3f) ) + process_pending_softirqs(); + + if ( vnuma->vcpu_to_vnode[j] == i ) + { + if ( start_cpu == ~0U ) + { + printk("%d", j); + start_cpu = j; + } + } + else if ( start_cpu != ~0U ) + { + if ( j - 1 != start_cpu ) + printk("-%d ", j - 1); + else + printk(" "); + start_cpu = ~0U; + } + } + + if ( start_cpu != ~0U && start_cpu != j - 1 ) + printk("-%d", j - 1); + + printk("\n"); + + for ( j = 0; j < vnuma->nr_vmemranges; j++ ) + { + if ( vnuma->vmemrange[j].nid == i ) + printk(" %016"PRIx64" - %016"PRIx64"\n", + vnuma->vmemrange[j].start, + vnuma->vmemrange[j].end); + } + } + + read_unlock(&d->vnuma_rwlock); + } + + rcu_read_unlock(&domlist_read_lock); +} + +static int __init cf_check register_numa_trigger(void) +{ + register_keyhandler('u', dump_numa, "dump NUMA info", 1); + return 0; +} +__initcall(register_numa_trigger); diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 7aef1a88dc..d799078a7a 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -18,4 +18,71 @@ (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) +/* The following content can be used when NUMA feature is enabled */ +#ifdef CONFIG_NUMA + +extern nodeid_t cpu_to_node[NR_CPUS]; +extern cpumask_t node_to_cpumask[]; + +#define cpu_to_node(cpu) cpu_to_node[cpu] +#define parent_node(node) (node) +#define node_to_first_cpu(node) __ffs(node_to_cpumask[node]) +#define node_to_cpumask(node) node_to_cpumask[node] + +struct node { + paddr_t start, end; +}; + +extern int compute_hash_shift(const struct node *nodes, + unsigned int numnodes, const nodeid_t *nodeids); + +#define VIRTUAL_BUG_ON(x) + +extern bool numa_off; + +extern void numa_add_cpu(unsigned int cpu); +extern void numa_init_array(void); +extern void numa_set_node(unsigned int cpu, nodeid_t node); +extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); +extern int numa_process_nodes(paddr_t start, paddr_t end); + +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_broken(void); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); + +static inline void clear_node_cpumask(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +/* Simple perfect hash to map pdx to node numbers */ +extern unsigned int memnode_shift; +extern unsigned long memnodemapsize; +extern uint8_t *memnodemap; + +struct node_data { + unsigned long node_start_pfn; + unsigned long node_spanned_pages; +}; + +extern struct node_data node_data[]; + +static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) +{ + nodeid_t nid; + VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; + VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + return nid; +} + +#define NODE_DATA(nid) (&node_data[nid]) + +#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) +#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) +#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ + NODE_DATA(nid)->node_spanned_pages) + +#endif + #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:12:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:12:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409249.652248 (Exim 4.92) (envelope-from ) id 1oaZJL-0004Tk-NF; Tue, 20 Sep 2022 09:12:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409249.652248; Tue, 20 Sep 2022 09:12:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJL-0004Td-Jv; Tue, 20 Sep 2022 09:12:59 +0000 Received: by outflank-mailman (input) for mailman id 409249; Tue, 20 Sep 2022 09:12:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJJ-0003bZ-Vs for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:12:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60049.outbound.protection.outlook.com [40.107.6.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a368fe5-38c4-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 11:12:57 +0200 (CEST) Received: from AS9PR06CA0456.eurprd06.prod.outlook.com (2603:10a6:20b:49a::11) by AS2PR08MB8310.eurprd08.prod.outlook.com (2603:10a6:20b:555::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Tue, 20 Sep 2022 09:12:54 +0000 Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::5a) by AS9PR06CA0456.outlook.office365.com (2603:10a6:20b:49a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 09:12:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:54 +0000 Received: ("Tessian outbound 88978e6d60db:v124"); Tue, 20 Sep 2022 09:12:54 +0000 Received: from 6d011e1fd59d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91E0E803-15F5-4B8D-8110-3CB6643F3017.1; Tue, 20 Sep 2022 09:12:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6d011e1fd59d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:47 +0000 Received: from FR3P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::17) by AM7PR08MB5528.eurprd08.prod.outlook.com (2603:10a6:20b:dd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:45 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::12) by FR3P281CA0107.outlook.office365.com (2603:10a6:d10:a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 09:12:45 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:45 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:43 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a368fe5-38c4-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=guKK/ohUM3x19f7hSMWC+RPepCAvA+tJMcnR9AHCCHu26CcH5vGW4C2Fgt8T03aL5XIB87GAw6ZOjv2SuhJzphUZ8GDDAmi07LfuuWpPkhRs3Z28zP+UOj7ms78YiSeUFSzh0GpsCJyF5ZkjAxi1wPiEDM2edfcQ7v4wD7rdAv/crNNcCnQHW6EtBgREpuJ0GRugugCpM4xt/Rc4j70wA4t4xvh2ppjlf3mqsBr6GdNPFE4o/JRV8vQBbzrQFopirNl10s10cgsGdCfXRECwpDh+P8MXYtHTBOyFzRI+fgeFn4ijmjnjfmLYZ52XDH6iJWH5ZxqCPAp4qXNcqkHj9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JApE89GTHtWh+1dMIVWR6H3QB3coBzTIxLdWe7grbWM=; b=nN8K+Od/nx+mmdfIkXl8J+mDRxaW5jWksrNT/Vo3awrpo3dcySXm1JL8rymmdVtkGU7X8D375vz0Swmf9BP+OGdNYrPmUekvbzhXG0b+tNtvrLpzSx1QgtsHr4T3vw66zmqy55BJehv1C26sqO2g48PYKezokijqas54+mRJOSqcJa8TIfqlHCGd5BHbb4eGe8lSPksqGZPLAgj6pwYcwq0l7a+tG+qODjgyQSRn/o+sUvvToDMbVf9RYJ+l8Go7uvMLjUxEMrGkTAQigXG+6vbQ3FrI2/zsPq/LPAEQrt89bVrr1/JWODPvJKhgje9I7tLxNitzMPzy4XGfyy/jxQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JApE89GTHtWh+1dMIVWR6H3QB3coBzTIxLdWe7grbWM=; b=H+KGwsWGpZkoFfradaN6Wkm/8r/On98Tl4yLFYeomJJXjjJwJxWvHW/cyTK2D1jTGrYEgY6OdDqf+brdCeYJk/WcvNzqtnJRv6o7/T3d7ZUpCxNiPMKjyHDq99Um9gZUaDjTluAX0Hh3sAdg30vb//xvIbqLokvsOozGUTLc900= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: aa4b101283b19735 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1OFLWjAlrPZ+NBOzbvg2fTQAx/LS5XDwOAmzX1P7PqEwqLEJTtOtm45UgdKpFl148JQKSpzDxoSMgz2+2HgAKRrTvmZap9J8ecjKb+XeHMsJndaZRWNCDZTe75BlIw5IEMZ3YLRS0f04FNIZdLHOT0LGzjL5Icu4IjewboXfXj//2dQdWTePIyUMnILNPFdTqHHjbIDobherrqxyw4kZ9KycaYuw4Oe9bX36oTIpmbd1Cp26RNTr2Dll3LbSCQO8C371XeH4pIyKpL3Qetx23RMyFBYzrEYxePic120B2FsOQdqv85LDU7HlmxYW1jE96+LCEtiO1FVksenSGVVpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JApE89GTHtWh+1dMIVWR6H3QB3coBzTIxLdWe7grbWM=; b=iNYO0qwRQlpOseLKWNca3lMyw6SJqN6iI1Q75yZTK00P41W186dyvFHcuztA4Rwgum42BdJMQyk/0nA0t4uB+HAoAFk4a0JlAcq+oqab09gZk5jIF5RhJMZKa8jwimviR/uxRRO2oYsTsdp3/g26yKCt2vALLNJRNK3YrKo1V0dUj1kJqq72g29SXmbvxzlVBJjmkUhMpHaSEMg1q9u8yTM6yYiUZ4NIdFiMFbIiMxQp+d+ZUJOrfH52zaJkOrcLclbwJqmqHxvlLwMdcIpf8mOzR1RAwRDASZR4W8yOa+9BfdEFQEm2TgtjvG2t63inEja9+EdsjghMQcnlOQkPxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JApE89GTHtWh+1dMIVWR6H3QB3coBzTIxLdWe7grbWM=; b=H+KGwsWGpZkoFfradaN6Wkm/8r/On98Tl4yLFYeomJJXjjJwJxWvHW/cyTK2D1jTGrYEgY6OdDqf+brdCeYJk/WcvNzqtnJRv6o7/T3d7ZUpCxNiPMKjyHDq99Um9gZUaDjTluAX0Hh3sAdg30vb//xvIbqLokvsOozGUTLc900= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v5 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Date: Tue, 20 Sep 2022 17:12:16 +0800 Message-ID: <20220920091218.1208658-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920091218.1208658-1-wei.chen@arm.com> References: <20220920091218.1208658-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT012:EE_|AM7PR08MB5528:EE_|AM7EUR03FT030:EE_|AS2PR08MB8310:EE_ X-MS-Office365-Filtering-Correlation-Id: f1666468-01fa-42a4-236a-08da9ae84d3c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MyIAm9fK9dQtPIJ47s4xFQ3VJ+zkSNhTf9EHCa97/T6lLoXTutJHXOL6tSdJs3kcz4fBJ5L3j4wfwNzHTHitdEzk94brp4ERiMPPbikZEH1Ph6YYDtUu4cG98QXfFKZ9LJ5YQsB3G7Kw35Cl6J88ndGuwOTPjJK0JxkGsm/vooYziCq/j9txqRlko4daWRTOKS+KXeq0oCudcOWHphLaagFRAnPSGvAMEWSW1ZmSVMQgHeqzSykkI0VXNlk5a8IEmHwkmsLaMcqoi7R2AKvmqO7VkMzNG+nl/TjAQnnoz7C2Q2VJqEHUipS53GyGvtwghkcaCjFrLwsiT0dtOphqBHad29y9rcAiNhLRTgrkiuxFhNVeZ7qGnV8fZAqYXGPVC+b3dfAas3uAgxjv2kF8XPQKQhLjt+/mOX6rFUTAt3fQL4W/v8WlO3ryrN6HebyTHTvC9V9XcvX2kaRZtyj8/Tf7I3Z7NnLWqMNm7zYCeduKn+B/U2DvgMOaWB/Su32cwCl7bUrVN5iQCqO6hlxzSpUxeeEtFPTnvUwCoWadT9z3SIXIPrwEtAsvzb2dxk8yFMwPG9XjGJ/fE8D7BTi22JD5Vd4RxUMNywjk4xRr4/YOPEjl/BCvgocB4WxAtir1Ozje4ha8sGF4C2u1nFdWYH+CPgt/EX9/UfmE7xMeB/JSk4EMlpiR0PxHAmYiHavU7bVwsb7BBME/9VrDiu1+Add+TkReGlcIllgtech9XSEtIksqgNVJaCxcmBFEuZrKb7bx5II7jQGSvnT3PCOtUHQaLgd4RbqxPUSdJOe7QPP1dpii4EjSFZM/wdwMDzar X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(44832011)(40480700001)(82310400005)(36756003)(2906002)(54906003)(316002)(426003)(36860700001)(47076005)(8676002)(82740400003)(4326008)(5660300002)(70206006)(70586007)(6916009)(8936002)(86362001)(336012)(1076003)(186003)(478600001)(2616005)(356005)(81166007)(26005)(41300700001)(6666004)(83380400001)(40460700003)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5528 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ed78981-4bce-4eb7-b399-08da9ae847ce X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cgTVOb9QrxPjEq5P9DYtexRF0sylt6rmEdwdeU91goS68oA4kS+rlMZL1vKAoT6zqG9tnIZlpiK8EpeRThJr3PXf5c+b/Fg3LTOBdw7cV5B8cJlyLiqOo3R5/55G5Fw2aPMtjkuRBlSDFqc8OQN0ZZtbTc/p5Z/zaR5P1GXEsmCDn+vJmy7crid1ciaPKGtlO6pETullUJ/vrHlyle1CWipH1DRnTD4e/uCW4B+Lw/WVXBACflvzl/NZ5sF79jByd+ZYB2JRvRBb+DZLS3uLVRUgWhe7BD04COpU4kyXJ4EEpoAF2fiSX78JY9Aifwr64B1GpkZ6tUXfGdbQhZu5hv4E+bn6z7kU9vZ2XV0BPckMXlt91fQlcG+0anTq41DKzlQ5ZcgzQc4dq9yJpTgZj4wLMHAOK1DN7WNEHpqyYJZtvAlh9OHPyWDrvYwlHeZk1Y19Y0u6/RTvXvQEdMUa2mU+inHCHWkKOJxh5O5e1hKbGpZ1kKTKd++iHHbwDZN1AmSu8wcnoKXWmXAg8RONcB89jgo7QUfqZy8/3CccDwVjmthVm2RZ/WENH5jAR69vFRHDIaNpzozF0deOMtJ6jVEqMDnmL3zTuOMyCPvyEEtCOl66mqVqDjFTAMDsfqTcrbu3HwMGh/t1JmR/HjqVuNgid7r5P2M9JN8xQbKOmYh4Klywj/zahZxsH+0wdWdPfT0rsVEYAjxahXg1e9SXBDB5+frO9eq1kX7mYgYT8eXdpgDoDAphEuGYkAiP3WNEohJE+HMQTttqF3DkqKj1Tg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(40480700001)(336012)(4326008)(316002)(5660300002)(83380400001)(36756003)(54906003)(81166007)(6916009)(8676002)(7696005)(86362001)(82740400003)(70586007)(70206006)(41300700001)(2906002)(36860700001)(6666004)(82310400005)(186003)(478600001)(107886003)(1076003)(8936002)(2616005)(40460700003)(44832011)(47076005)(26005)(426003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:12:54.4754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1666468-01fa-42a4-236a-08da9ae84d3c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8310 The sanity check of nodes_cover_memory is also a requirement of other architectures that support NUMA. But now, the code of nodes_cover_memory is tied to the x86 E820. In this case, we introduce arch_get_ram_range to decouple architecture specific memory map from this function. This means, other architectures like Arm can also use it to check its node and memory coverage from bootmem info. Depends arch_get_ram_range, we make nodes_cover_memory become architecture independent. We also use neutral words to replace SRAT and E820 in the print message of this function. This will to make the massage seems more common. As arch_get_ram_range use unsigned int for index, we also adjust the index in nodes_cover_memory from int to unsigned int. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v4 -> v5: 1. Add Rb. 2. Adjust the code comments. v3 -> v4: 1. Move function comment to header file. 2. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 3. Use -ENODATA instead of -EINVAL for non-RAM type ranges. v2 -> v3: 1. Rename arch_get_memory_map to arch_get_ram_range. 2. Use -ENOENT instead of -ENODEV to indicate end of memory map. 3. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. v1 -> v2: 1. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 2. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. --- xen/arch/x86/numa.c | 15 +++++++++++++++ xen/arch/x86/srat.c | 30 ++++++++++++++++++------------ xen/include/xen/numa.h | 13 +++++++++++++ 3 files changed, 46 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 21efb1b1b3..6cf5c323af 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifndef Dprintk #define Dprintk(x...) @@ -93,3 +94,17 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } + +int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) +{ + if ( idx >= e820.nr_map ) + return -ENOENT; + + if ( e820.map[idx].type != E820_RAM ) + return -ENODATA; + + *start = e820.map[idx].addr; + *end = *start + e820.map[idx].size; + + return 0; +} diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 0d4f7cccb9..1603c415fd 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -428,37 +428,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) Make sure the PXMs cover all memory. */ static int __init nodes_cover_memory(void) { - int i; + unsigned int i; - for (i = 0; i < e820.nr_map; i++) { - int j, found; + for (i = 0; ; i++) { + int err; + unsigned int j; + bool found; paddr_t start, end; - if (e820.map[i].type != E820_RAM) { - continue; - } + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); - start = e820.map[i].addr; - end = e820.map[i].addr + e820.map[i].size; + /* Reached the end of the memory map? */ + if (err == -ENOENT) + break; + + /* Skip non-RAM entries. */ + if (err) + continue; do { - found = 0; + found = false; for_each_node_mask(j, memory_nodes_parsed) if (start < nodes[j].end && end > nodes[j].start) { if (start >= nodes[j].start) { start = nodes[j].end; - found = 1; + found = true; } if (end <= nodes[j].end) { end = nodes[j].start; - found = 1; + found = true; } } } while (found && start < end); if (start < end) { - printk(KERN_ERR "SRAT: No PXM for e820 range: " + printk(KERN_ERR "NUMA: No NODE for RAM range: " "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); return 0; } diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 538b283d95..5c7abdb050 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -81,6 +81,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +/* + * This function provides the ability for caller to get one RAM entry + * from architectural memory map by index. + * + * This function will return zero if it can return a proper RAM entry. + * Otherwise it will return -ENOENT for out of scope index, or other + * error codes, e.g. return -ENODATA for non-RAM type memory entry. + * + * Note: the range is exclusive at the end, e.g. [*start, *end). + */ +extern int arch_get_ram_range(unsigned int idx, + paddr_t *start, paddr_t *end); + #endif #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:13:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:13:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409251.652260 (Exim 4.92) (envelope-from ) id 1oaZJS-0004uy-4J; Tue, 20 Sep 2022 09:13:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409251.652260; Tue, 20 Sep 2022 09:13:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJR-0004ua-TG; Tue, 20 Sep 2022 09:13:05 +0000 Received: by outflank-mailman (input) for mailman id 409251; Tue, 20 Sep 2022 09:13:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJQ-0003bZ-Nj for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:13:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2084.outbound.protection.outlook.com [40.107.22.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6dc82d88-38c4-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 11:13:02 +0200 (CEST) Received: from AM5PR0201CA0022.eurprd02.prod.outlook.com (2603:10a6:203:3d::32) by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:59 +0000 Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::dd) by AM5PR0201CA0022.outlook.office365.com (2603:10a6:203:3d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 09:12:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:59 +0000 Received: ("Tessian outbound e2c58cd9a6bb:v124"); Tue, 20 Sep 2022 09:12:59 +0000 Received: from 86f48fc60ca1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 98B58C8C-9476-46E4-A7F6-04BA9459D56F.1; Tue, 20 Sep 2022 09:12:51 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 86f48fc60ca1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:51 +0000 Received: from AS4PR09CA0020.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::7) by AS1PR08MB7513.eurprd08.prod.outlook.com (2603:10a6:20b:480::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Tue, 20 Sep 2022 09:12:49 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d4:cafe::c6) by AS4PR09CA0020.outlook.office365.com (2603:10a6:20b:5d4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Tue, 20 Sep 2022 09:12:49 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:48 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:47 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dc82d88-38c4-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nq4YxcUPvqC9L9lbtC/sFjbC+8P/iYDAyDoq2vySjP19EL73YDQT0roWnMSPA8tMuup9lYNipAHx9Kik3OlIgXcnDWNDLBQtqjAxeWtNtcFklWZyJPBnTQ0Aq05Js+K+GDVBrBj8U0vZ6pwXuJzbrNCT9DPGXfYdrg3Mwhuke3DUYKioj0CO1t3VEdA4we8pX4POxlfEUi2OUavHh9LtntqIHYBVqh55xmm8xf4UD5KedU5kiecB1dbUCd76lpUkbnuLTPHwrVF+63setSRCSwZkEdfPPIa8jNqntFt2zn9+iJwJuX/9y7EbcrSEIoTIyv5Zy+iqDhBRJHaSIrPXrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJ9ttdNAWIlD5SlMp8AY0fSp90/hwL0jgfa+S1mSp7c=; b=cZjwldeEkNIycaXgJ6qQu5gdOndwqHotPJqLBdr9X9ZmtsMOjuaWhC43Bh/DyqxKcvm0+K1cOFFCb+DOz0oVj/PReznpiYdtaRXdrLI3zZ3tkS+HXWGA1coeJ7BwfUbvajUK1SKI8vDyUGv9Oc1IPI1e2ri/QwsGSN+7q0BSRvTSZ/gAQIKP2dA96hOXwozeJB7+m/BfZrRYNoAtXA+M+24jmaQakI4W+9On8xNXJ66aulMw+PQv4L3iHG5qgNnyUoYh5GzMsh+Brxc3WrMKd1hruZmvPnTP6kYI0xY7vbZF01gdF1t6jSbSgRmQYn1j3hVD4TKyUbmnFiJTOqan1A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJ9ttdNAWIlD5SlMp8AY0fSp90/hwL0jgfa+S1mSp7c=; b=H/CPQ9jGZ2Rwg7FDJIHJWII6jJwIFCWx0kYqVdFmXYFD1FErfSUR/dHEmR02XWCvv4K4BSmD9UzIEVaklOQUiJ8rai/ocNZOLpM3Q0X69zAhovglw7kovH/TBasKJ4sJBk49XDZgr7X7Aje5mbufmQezem+bPDk/VawnQdS+hYk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 232754b9b07e5599 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OObadKc35yJg0Q7VxTahQvRDmflQlrDPE/wmQVsqWEmTXcFmjn4rv25Qo3sYmMKlgK7Gm4zJ2wzzNExiI03CxBfzFNcOH+caD0kQnZ8+vhdt/JIO0W/m6/EylrJVvQkg7dpYRoTWkBCmdQA3x+CPjvD2Onxj21Sf2S1gnOkrS94QfBFl64PAFrOKO6eCFcttBBRUFkH8jIo7nMViEF480Id5wM1bsxGsLSj6kiC7ZfJ77K6lI2WxHTuQiRbrj04vafAjhU0ZOP2VywynEE0cS+qEJfDJro8BU+6ZF4RsAh/qLnoPqUG+nCNmsHtQEtYcZ491QnjhpKbULAJUsVYX4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJ9ttdNAWIlD5SlMp8AY0fSp90/hwL0jgfa+S1mSp7c=; b=E/j/B+T1r3347Hc9Yc9hDedFxGo6FtYfUJFbHmJrpfEqf1ZsmGSpkP0JwDxC67LkeH0Fc1oeGgGuXbLZ+Soe6YZKoszqVpjhxOPNg7wTIOcb9zvpQ1dm9Faj4VJtoxvd9oCzEXX2M29xBBxdag6K4DPj5T5NOLCqBCdNsg3wgFHTEmVIpYF71RU03trNjjHxPtZCp9hAYBAo5GrXmFkwdSGgC6PFm2sDrD4kWFZzxSqgC5y3+BI5U7hJZ5uaMcJ3LAzUdC12VHQhf/YtqyKJ7uF/oOg7tGl+RLFJIu1Jf4qXPb8RdqRNQCu3XedR5Ifu2ZSsYm4JunnfwkNFl9168w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJ9ttdNAWIlD5SlMp8AY0fSp90/hwL0jgfa+S1mSp7c=; b=H/CPQ9jGZ2Rwg7FDJIHJWII6jJwIFCWx0kYqVdFmXYFD1FErfSUR/dHEmR02XWCvv4K4BSmD9UzIEVaklOQUiJ8rai/ocNZOLpM3Q0X69zAhovglw7kovH/TBasKJ4sJBk49XDZgr7X7Aje5mbufmQezem+bPDk/VawnQdS+hYk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Date: Tue, 20 Sep 2022 17:12:17 +0800 Message-ID: <20220920091218.1208658-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920091218.1208658-1-wei.chen@arm.com> References: <20220920091218.1208658-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT006:EE_|AS1PR08MB7513:EE_|AM7EUR03FT012:EE_|PA4PR08MB6080:EE_ X-MS-Office365-Filtering-Correlation-Id: 496dd1d4-4cbe-4335-46b3-08da9ae85015 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: chqDDM2I4nuKLvQgEpw2qyP2gj5Oyt4hYq7dEhMd+SqLrDz6TJvlZxADoFsD4nKuj0RO4LZwnguy04dChzsVN6dxZyVLOTwYxwcTtnh980Ghy1QzcQl+jJpvzfoPIqIFkIfjSO5GNAPYjAWemHovAS4DWD/hMJtebVMhCK3fCMHE/Re0KuD2bmyO0d1w0Cdd9hcaVyyCN92zsCfCMl9cK6+NlGz/DH3uhPi84TCDQ6Gz3BEYw4dKGI/V9LnnWknWg85OAuOtDy6AIjsFrnQhq2SbE+epOCZka3xVjw5L9K3Kw2Rs3JIy4qLwLc9yqZIv3ETO6NmwLqi/jGX2hLdykOERM/oOLt4V71a1aAIkQZa9NYrASZMt+3Xo3+l4ZahH+6yHrrVOdcMtDko3uUlwIxZjCEkMk7hhYCdXuteUKjVR5VyApDfkZUz2JUQFTL7nd6hR+fK24ymMeOnjl9ATuhofeLEuQfM19qnhIG9jJUk70YJWzvyUCXwv7PGMtqkrgqS4pdiisFBT5JEmYsOGRF6XNLiM2jqkdk725zHLybQPhcj/8UMjX1+lBSvjVLtl4I6LYvA6F9xFDuEWZyF7cbkrSadU00Hl27PvV2RoRi7sEAO9haJc13Gd62sUSZRmyUBzsTs6X5RxpBxwhlqmerDde1NV479wGBxt4JyzduU6K6MBapaAaoJF4PcLhGykX5MekuAL5B9myRK+b0WhUPinc4baSpVFgBFLriQ8eoNL9jUOny0MoOvOHsPbeFFg32QyhteQ+GJ/VCiVNR5/+MlkDSYHmwzUjepps+9K6sRqUb/lOwTEPAB0o9qGpVM1 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(26005)(7696005)(2616005)(81166007)(30864003)(2906002)(82310400005)(478600001)(5660300002)(356005)(36860700001)(40460700003)(82740400003)(36756003)(86362001)(44832011)(426003)(336012)(1076003)(186003)(6666004)(47076005)(40480700001)(41300700001)(83380400001)(4326008)(70586007)(8936002)(6916009)(54906003)(70206006)(8676002)(316002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7513 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e2d9a43b-be2a-4a3c-f497-08da9ae849fa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JXP6B562PzOfzq6tHeXbngaUlhGfc034gDSrPQuPkT8oNxzEOFxlKtoW1thN9kXaHC5X7YX/KakJmbCbf+MP9nZQgxnq3uXxctGy7/luCJ5JxR5Oq8xNZnlE5klLnnsCchIfGrG6YZbJDmCK8GfGgkm1Lx/5eTLB7wnQvons0apKeeavI81XUiB9vvO0PIMMkSadev2P8I0n2Wfu2zkkbFJbJ+QRLBBRuL3uqrUXhZO/oXwPRlO2BXaaK8XMjW1fy/Pr7NMI4cRd8TP7WWR33O0wfdLc7NLWxFbX2vlqFD2i6mWoJULRcVoo9dDO0ar+nURuOMTQsZHyF7WM0u0Q2Ua0DFsU10UBQHmzuKQ2nQztsaNRZwLTFGhNtduyIpkpTPNNG1L3uSi8YWcynYaSePFSlXWoaH5Qouzzkja+MQ3c8s95IMslBZ8BD/Gyd0XlF0Ouvhd1q/TBCA7d0qdEeFqCnfeAApzsqyU/PpKlcgswGG5G1uT5hCJvHNWat7WU8CuQ66OEEfHYkVUKdOlrqTxJpZTOIg3g8ppog+92N2++PwE9JhIs4QN5wOjYo1bDenj8GtJ9U0q3T4q13V3DYrSrvQGE/ic2zq4i90PTc/GnGTdn3n0Pxd7NyITkVhSWWHP4upuQiXDKmZU0TWRrqp5A8hyJ1zo1RTsphJa8y6c/WZQCI+ULktfyctgJO3WYU9DTU96iQQQ5UBilhv/uym7BxFgMvYFVAmNdvUF6It5Q7Kuzzwe1jDLg9bx5NIjUt/QPPPx+aU9I4RxzBEUHRw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(6916009)(54906003)(336012)(83380400001)(426003)(81166007)(86362001)(2906002)(316002)(478600001)(36756003)(26005)(40480700001)(107886003)(7696005)(6666004)(36860700001)(41300700001)(1076003)(2616005)(186003)(47076005)(40460700003)(82310400005)(82740400003)(5660300002)(4326008)(44832011)(8936002)(70586007)(8676002)(30864003)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:12:59.2227 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 496dd1d4-4cbe-4335-46b3-08da9ae85015 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080 x86 has implemented a set of codes to scan NUMA nodes. These codes will parse NUMA memory and processor information from ACPI SRAT table. But except some ACPI specific codes, most of the scan codes like memory blocks validation, node memory range updates and some sanity check can be reused by other NUMA implementation. So in this patch, we move some variables and related functions for NUMA memory and processor to common as library. At the same time, numa_set_processor_nodes_parsed has been introduced for ACPI specific code to update processor parsing results. With this helper, we can reuse most of NUMA memory affinity init code from ACPI. As bad_srat and node_to_pxm functions have been used in common code to do architectural fallback and node to architectural node info translation. But it doesn't make sense to reuse the functions names in common code, we have rename them to neutral names as well. PXM is an ACPI specific item, we can't use it in common code directly. As an alternative, we extend the parameters of numa_update_node_memblks. The caller can pass the PXM as print messages' prefix or as architectural node id. And we introduced a CONFIG_HAS_NUMA_NODE_FWID to prevent print the mapping between node id and architectural node id for those architectures do not have architectural node id. In this case, we do not need to retain a lot of per-arch code but still can print architectural log messages for different NUMA implementations. mem_hotplug also has been accessing by common code, except x86, other architectures like Arm will also want to implement memory hotplug in future. We export mem_hotplug to common will not bring any harm for Arm and we also can reduce some per-arch helpers to access mem_hotplug. As asm/acpi.h has been removed from common/numa.c, we have to move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch as well. Signed-off-by: Wei Chen --- v4 -> v5: 1. Introduce arch_numa_disabled for acpi_numa <= 0 in this patch. 2. Remove the paramter init_as_disable of arch_numa_disabled. 3. Fix typo "expandsion". 4. Add const to proper varibales. 5. Fix Indentation for l1tf_safe_maddr. 6. Remove double blank lines. 7. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 8. Use bool for nodes_cover_memory return value. 9. Use a plain "int ret" to record compute_hash_shift return value. 10. Add a blank line before the function's main "return". 11. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 2. Move mem_hotplug to a proper place in mm.h 3. Remove useless "size" in numa_scan_nodes. 4. Use unsigned int or const for proper variables. 5. Fix code-style. 6. Add init_as_disable as arch_numa_disabled parameter. 7. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Add __ro_after_init to proper variables. 2. Rename bad_srat to numa_fw_bad. 3. Rename node_to_pxm to numa_node_to_arch_nid. 4. Merge patch#7 and #8 into this patch. 5. Correct int to unsigned int in proper places. 6. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 7. Drop helpers to access mem_hotplug, we export mem_hotplug from x86/mm.c to common/page_alloc.c v1 -> v2: 1. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 2. Merge this single patch instead of serval patches to move x86 SRAT code to common. 3. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 4. Change the code style to target file's Xen code-style. 5. Adjust some __init and __initdata for some functions and variables. 6. Merge two patches into this patch: 1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA. 2. replace "SRAT" texts. 7. Turn numa_scan_nodes to static. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 3 +- xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 5 + xen/arch/x86/srat.c | 311 +++--------------------------- xen/common/Kconfig | 3 + xen/common/numa.c | 322 +++++++++++++++++++++++++++++++- xen/common/page_alloc.c | 2 + xen/drivers/acpi/Kconfig | 1 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 11 +- 12 files changed, 368 insertions(+), 297 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 5c2dd5da2d..c453450a74 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -#define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; #define acpi_video_flags bootsym(video_flags) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index 0fc826de46..95ff71a83a 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -474,8 +474,6 @@ static inline int get_page_and_type(struct page_info *page, ASSERT(((_p)->count_info & PGC_count_mask) != 0); \ ASSERT(page_get_owner(_p) == (_d)) -extern paddr_t mem_hotplug; - /****************************************************************************** * With shadow pagetables, the different kinds of address start * to get get confusing. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 6c87942d43..2ca3475271 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -10,6 +10,7 @@ typedef u8 nodeid_t; extern int srat_rev; extern nodeid_t pxm_to_node(unsigned int pxm); +extern unsigned int numa_node_to_arch_nid(nodeid_t n); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) @@ -22,8 +23,6 @@ extern void init_cpu_to_node(void); #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); - void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index db1817b691..68f9989e1f 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -157,8 +157,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap_x[L1_PAGETABLE_ENTRIES]; -paddr_t __read_mostly mem_hotplug; - /* Frame table size in pages. */ unsigned long max_page; unsigned long total_pages; diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 6cf5c323af..d4448fc333 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -46,6 +46,11 @@ bool arch_numa_broken(void) return acpi_numa < 0; } +bool arch_numa_disabled(void) +{ + return acpi_numa <= 0; +} + /* * Setup early cpu_to_node. * diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 1603c415fd..26bf898d0b 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -24,10 +24,6 @@ static struct acpi_table_slit *__read_mostly acpi_slit; -static nodemask_t memory_nodes_parsed __initdata; -static nodemask_t processor_nodes_parsed __initdata; -static struct node nodes[MAX_NUMNODES] __initdata; - struct pxm2node { unsigned pxm; nodeid_t node; @@ -35,19 +31,6 @@ struct pxm2node { static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] = { [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} }; -static unsigned node_to_pxm(nodeid_t n); - -static int num_node_memblks; -static struct node node_memblk_range[NR_NODE_MEMBLKS]; -static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; -static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); - -enum conflicts { - NO_CONFLICT, - OVERLAP, - INTERLEAVE, -}; - static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm) return node; } -int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) -{ - int i; - - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - if (nd->start <= start && nd->end >= end && - memblk_nodeid[i] == node) - return 1; - } - - return 0; -} - -static -enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, - paddr_t end, paddr_t nd_start, - paddr_t nd_end, unsigned int *mblkid) -{ - unsigned int i; - - /* - * Scan all recorded nodes' memory blocks to check conflicts: - * Overlap or interleave. - */ - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - *mblkid = i; - - /* Skip 0 bytes node memory block. */ - if (nd->start == nd->end) - continue; - /* - * Use memblk range to check memblk overlaps, include the - * self-overlap case. As nd's range is non-empty, the special - * case "nd->end == end && nd->start == start" also can be covered. - */ - if (nd->end > start && nd->start < end) - return OVERLAP; - - /* - * Use node memory range to check whether new range contains - * memory from other nodes - interleave check. We just need - * to check full contains situation. Because overlaps have - * been checked above. - */ - if (nid != memblk_nodeid[i] && - nd->start >= nd_start && nd->end <= nd_end) - return INTERLEAVE; - } - - return NO_CONFLICT; -} - -static __init void cutoff_node(int i, paddr_t start, paddr_t end) -{ - struct node *nd = &nodes[i]; - if (nd->start < start) { - nd->start = start; - if (nd->end < nd->start) - nd->start = nd->end; - } - if (nd->end > end) { - nd->end = end; - if (nd->start > nd->end) - nd->start = nd->end; - } -} - -static __init void bad_srat(void) +void __init numa_fw_bad(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); @@ -241,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -254,12 +166,12 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) pxm = pa->proximity_domain; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -277,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -290,11 +202,11 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) } node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -306,32 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - struct node *nd; - paddr_t nd_start, nd_end; - paddr_t start, end; unsigned pxm; nodeid_t node; - unsigned int i; if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) return; - start = ma->base_address; - end = start + ma->length; /* Supplement the heuristics in l1tf_calculations(). */ - l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE)); + l1tf_safe_maddr = max(l1tf_safe_maddr, + ROUNDUP(ma->base_address + ma->length, + PAGE_SIZE)); - if (num_node_memblks >= NR_NODE_MEMBLKS) - { + if (!numa_memblks_available()) { dprintk(XENLOG_WARNING, - "Too many numa entry, try bigger NR_NODE_MEMBLKS \n"); - bad_srat(); + "Too many numa entries, try bigger NR_NODE_MEMBLKS!\n"); + numa_fw_bad(); return; } @@ -340,136 +247,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) pxm &= 0xff; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } - /* - * For the node that already has some memory blocks, we will - * expand the node memory range temporarily to check memory - * interleaves with other nodes. We will not use this node - * temp memory range to check overlaps, because it will mask - * the overlaps in same node. - * - * Node with 0 bytes memory doesn't need this expandsion. - */ - nd_start = start; - nd_end = end; - nd = &nodes[node]; - if (nd->start != nd->end) { - if (nd_start > nd->start) - nd_start = nd->start; - - if (nd_end < nd->end) - nd_end = nd->end; - } - - /* It is fine to add this area to the nodes data it will be used later*/ - switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) { - case OVERLAP: - if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & - ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, - end - 1, node_memblk_range[i].start, - node_memblk_range[i].end - 1); - if (mismatch) { - bad_srat(); - return; - } - break; - } - - printk(KERN_ERR - "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, - node_memblk_range[i].end - 1); - bad_srat(); - return; - - case INTERLEAVE: - printk(KERN_ERR - "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, node_memblk_range[i].end - 1); - bad_srat(); - return; - - case NO_CONFLICT: - break; - } - - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - node_set(node, memory_nodes_parsed); - nd->start = nd_start; - nd->end = nd_end; - } - - printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", - node, pxm, start, end - 1, - ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); - - node_memblk_range[num_node_memblks].start = start; - node_memblk_range[num_node_memblks].end = end; - memblk_nodeid[num_node_memblks] = node; - if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { - __set_bit(num_node_memblks, memblk_hotplug); - if (end > mem_hotplug) - mem_hotplug = end; - } - num_node_memblks++; -} - -/* Sanity check to catch more bad SRATs (they are amazingly common). - Make sure the PXMs cover all memory. */ -static int __init nodes_cover_memory(void) -{ - unsigned int i; - - for (i = 0; ; i++) { - int err; - unsigned int j; - bool found; - paddr_t start, end; - - /* Try to loop memory map from index 0 to end to get RAM ranges. */ - err = arch_get_ram_range(i, &start, &end); - - /* Reached the end of the memory map? */ - if (err == -ENOENT) - break; - - /* Skip non-RAM entries. */ - if (err) - continue; - - do { - found = false; - for_each_node_mask(j, memory_nodes_parsed) - if (start < nodes[j].end - && end > nodes[j].start) { - if (start >= nodes[j].start) { - start = nodes[j].end; - found = true; - } - if (end <= nodes[j].end) { - end = nodes[j].start; - found = true; - } - } - } while (found && start < end); - - if (start < end) { - printk(KERN_ERR "NUMA: No NODE for RAM range: " - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); - return 0; - } - } - return 1; + if (!numa_update_node_memblks(node, pxm, ma->base_address, + ma->length, "PXM", + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) + numa_fw_bad(); } void __init acpi_numa_arch_fixup(void) {} @@ -525,59 +310,9 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use discovered information to actually set up the nodes. */ -int __init numa_process_nodes(paddr_t start, paddr_t end) -{ - int i; - nodemask_t all_nodes_parsed; - - /* First clean up the node list */ - for (i = 0; i < MAX_NUMNODES; i++) - cutoff_node(i, start, end); - - if (acpi_numa <= 0) - return -1; - - if (!nodes_cover_memory()) { - bad_srat(); - return -1; - } - - memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, - memblk_nodeid); - - if (memnode_shift < 0) { - printk(KERN_ERR - "SRAT: No NUMA node hash function found. Contact maintainer\n"); - bad_srat(); - return -1; - } - - nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); - - /* Finally register nodes */ - for_each_node_mask(i, all_nodes_parsed) - { - uint64_t size = nodes[i].end - nodes[i].start; - - if ( size == 0 ) - printk(KERN_INFO "SRAT: node %u has no memory\n", i); - - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - } - for (i = 0; i < nr_cpu_ids; i++) { - if (cpu_to_node[i] == NUMA_NO_NODE) - continue; - if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed)) - numa_set_node(i, NUMA_NO_NODE); - } - numa_init_array(); - return 0; -} - -static unsigned node_to_pxm(nodeid_t n) +unsigned int numa_node_to_arch_nid(nodeid_t n) { - unsigned i; + unsigned int i; if ((n < ARRAY_SIZE(pxm2node)) && (pxm2node[n].node == n)) return pxm2node[n].pxm; @@ -594,8 +329,8 @@ u8 __node_distance(nodeid_t a, nodeid_t b) if (!acpi_slit) return a == b ? 10 : 20; - index = acpi_slit->locality_count * node_to_pxm(a); - slit_val = acpi_slit->entry[index + node_to_pxm(b)]; + index = acpi_slit->locality_count * numa_node_to_arch_nid(a); + slit_val = acpi_slit->entry[index + numa_node_to_arch_nid(b)]; /* ACPI defines 0xff as an unreachable node and 0-9 are undefined */ if ((slit_val == 0xff) || (slit_val <= 9)) diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8..d20129959c 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -49,6 +49,9 @@ config HAS_IOPORTS config HAS_KEXEC bool +config HAS_NUMA_NODE_FWID + bool + config HAS_PDX bool diff --git a/xen/common/numa.c b/xen/common/numa.c index 83f4c8cc94..5d9e1989c4 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -13,6 +13,21 @@ #include #include +static nodemask_t __initdata processor_nodes_parsed; +static nodemask_t __initdata memory_nodes_parsed; +static struct node __initdata nodes[MAX_NUMNODES]; + +static unsigned int __ro_after_init num_node_memblks; +static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS]; +static nodeid_t __ro_after_init memblk_nodeid[NR_NODE_MEMBLKS]; +static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); + +enum conflicts { + NO_CONFLICT, + OVERLAP, + INTERLEAVE, +}; + struct node_data __ro_after_init node_data[MAX_NUMNODES]; /* Mapping from pdx to node id */ @@ -36,6 +51,311 @@ bool numa_disabled(void) return numa_off || arch_numa_broken(); } +void __init numa_set_processor_nodes_parsed(nodeid_t node) +{ + node_set(node, processor_nodes_parsed); +} + +bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) +{ + unsigned int i; + + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + if ( nd->start <= start && nd->end >= end && + memblk_nodeid[i] == node ) + return true; + } + + return false; +} + +static enum conflicts __init conflicting_memblks( + nodeid_t nid, paddr_t start, paddr_t end, paddr_t nd_start, + paddr_t nd_end, unsigned int *mblkid) +{ + unsigned int i; + + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + *mblkid = i; + + /* Skip 0 bytes node memory block. */ + if ( nd->start == nd->end ) + continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. As nd's range is non-empty, the special + * case "nd->end == end && nd->start == start" also can be covered. + */ + if ( nd->end > start && nd->start < end ) + return OVERLAP; + + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if ( nid != memblk_nodeid[i] && + nd->start >= nd_start && nd->end <= nd_end ) + return INTERLEAVE; + } + + return NO_CONFLICT; +} + +static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end) +{ + struct node *nd = &nodes[i]; + + if ( nd->start < start ) + { + nd->start = start; + if ( nd->end < nd->start ) + nd->start = nd->end; + } + + if ( nd->end > end ) + { + nd->end = end; + if ( nd->start > nd->end ) + nd->start = nd->end; + } +} + +bool __init numa_memblks_available(void) +{ + return num_node_memblks < NR_NODE_MEMBLKS; +} + +/* + * This function will be called by NUMA memory affinity initialization to + * update NUMA node's memory range. In this function, we assume all memory + * regions belonging to a single node are in one chunk. Holes (or MMIO + * ranges) between them will be included in the node. + * + * So in numa_update_node_memblks, if there are multiple banks for each + * node, start and end are stretched to cover the holes between them, and + * it works as long as memory banks of different NUMA nodes don't interleave. + */ +bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, + const char *prefix, + bool hotplug) +{ + unsigned int i; + paddr_t end = start + size; + paddr_t nd_start = start; + paddr_t nd_end = end; + struct node *nd = &nodes[node]; + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expansion. + */ + if ( nd->start != nd->end ) + { + if ( nd_start > nd->start ) + nd_start = nd->start; + + if ( nd_end < nd->end ) + nd_end = nd->end; + } + + /* It is fine to add this area to the nodes data it will be used later */ + switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) ) + { + case OVERLAP: + if ( memblk_nodeid[i] == node ) + { + bool mismatch = !hotplug != !test_bit(i, memblk_hotplug); + + printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", + mismatch ? KERN_ERR : KERN_WARNING, prefix, + arch_nid, start, end - 1, + node_memblk_range[i].start, node_memblk_range[i].end - 1); + if ( mismatch ) + return false; + break; + } + + printk(KERN_ERR + "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n", + prefix, arch_nid, start, end - 1, prefix, + numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case INTERLEAVE: + printk(KERN_ERR + "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", + prefix, arch_nid, nd_start, nd_end - 1, + prefix, numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case NO_CONFLICT: + break; + } + + if ( !hotplug ) + { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; + } + + +#ifdef CONFIG_HAS_NUMA_NODE_FWID + printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, prefix, arch_nid, start, end - 1, + hotplug ? " (hotplug)" : ""); +#else + printk(KERN_INFO "NUMA: Node %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, start, end - 1, hotplug ? " (hotplug)" : ""); +#endif + + node_memblk_range[num_node_memblks].start = start; + node_memblk_range[num_node_memblks].end = end; + memblk_nodeid[num_node_memblks] = node; + if ( hotplug ) + { + __set_bit(num_node_memblks, memblk_hotplug); + if ( end > mem_hotplug ) + mem_hotplug = end; + } + num_node_memblks++; + + return true; +} + +/* + * Sanity check to catch more bad SRATs (they are amazingly common). + * Make sure the PXMs cover all memory. + */ +static bool __init nodes_cover_memory(void) +{ + unsigned int i; + + for ( i = 0; ; i++ ) + { + int err; + bool found; + unsigned int j; + paddr_t start, end; + + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); + + /* Reached the end of the memory map? */ + if ( err == -ENOENT ) + break; + + /* Skip non-RAM entries. */ + if ( err ) + continue; + + do { + found = false; + for_each_node_mask ( j, memory_nodes_parsed ) + if ( start < nodes[j].end + && end > nodes[j].start ) + { + if ( start >= nodes[j].start ) + { + start = nodes[j].end; + found = true; + } + + if ( end <= nodes[j].end ) + { + end = nodes[j].start; + found = true; + } + } + } while ( found && start < end ); + + if ( start < end ) + { + printk(KERN_ERR "NUMA: No node for RAM range: " + "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); + return false; + } + } + + return true; +} + +/* Use discovered information to actually set up the nodes. */ +static bool __init numa_process_nodes(paddr_t start, paddr_t end) +{ + int ret; + unsigned int i; + nodemask_t all_nodes_parsed; + + /* First clean up the node list */ + for ( i = 0; i < MAX_NUMNODES; i++ ) + cutoff_node(i, start, end); + + /* When numa is on and has data, we can start to process numa nodes. */ + if ( arch_numa_disabled() ) + return false; + + if ( !nodes_cover_memory() ) + { + numa_fw_bad(); + return false; + } + + ret = compute_hash_shift(node_memblk_range, num_node_memblks, + memblk_nodeid); + if ( ret < 0 ) + { + printk(KERN_ERR + "NUMA: No NUMA node hash function found. Contact maintainer\n"); + numa_fw_bad(); + return false; + } + memnode_shift = ret; + + nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); + + /* Finally register nodes */ + for_each_node_mask ( i, all_nodes_parsed ) + { + if ( nodes[i].end == nodes[i].start ) + printk(KERN_INFO "NUMA: node %u has no memory\n", i); + + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + } + + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] == NUMA_NO_NODE ) + continue; + if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) ) + numa_set_node(i, NUMA_NO_NODE); + } + + numa_init_array(); + + return true; +} + /* * Given a shift value, try to populate memnodemap[] * Returns : @@ -257,7 +577,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) #endif #ifdef CONFIG_NUMA - if ( !numa_off && !numa_process_nodes(start, end) ) + if ( !numa_off && numa_process_nodes(start, end) ) return; #endif diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 62afb07bc6..80447a341d 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -159,6 +159,8 @@ #define PGT_TYPE_INFO_INITIALIZER 0 #endif +paddr_t __read_mostly mem_hotplug; + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig index e3f3d8f4b1..6f33d1ad57 100644 --- a/xen/drivers/acpi/Kconfig +++ b/xen/drivers/acpi/Kconfig @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP config ACPI_NUMA bool + select HAS_NUMA_NODE_FWID select NUMA diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index a925028ab3..9d14aed74b 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -147,6 +147,8 @@ int assign_page( /* Dump info to serial console */ void arch_dump_shared_mem_info(void); +extern paddr_t mem_hotplug; + /* * Extra fault info types which are used to further describe * the source of an access violation. diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 5c7abdb050..a87cdc45b4 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -11,6 +11,7 @@ #define NUMA_NO_DISTANCE 0xFF #define MAX_NUMNODES (1 << NODES_SHIFT) +#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) @@ -42,10 +43,11 @@ extern void numa_add_cpu(unsigned int cpu); extern void numa_init_array(void); extern void numa_set_node(unsigned int cpu, nodeid_t node); extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); -extern int numa_process_nodes(paddr_t start, paddr_t end); +extern void numa_fw_bad(void); extern int arch_numa_setup(const char *opt); extern bool arch_numa_broken(void); +extern bool arch_numa_disabled(void); extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); static inline void clear_node_cpumask(unsigned int cpu) @@ -93,6 +95,13 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) */ extern int arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end); +extern bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); +extern bool numa_memblks_available(void); +extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, + const char *prefix, + bool hotplug); +extern void numa_set_processor_nodes_parsed(nodeid_t node); #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:13:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:13:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409253.652270 (Exim 4.92) (envelope-from ) id 1oaZJV-0005Nr-Cv; Tue, 20 Sep 2022 09:13:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409253.652270; Tue, 20 Sep 2022 09:13:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJV-0005Nh-98; Tue, 20 Sep 2022 09:13:09 +0000 Received: by outflank-mailman (input) for mailman id 409253; Tue, 20 Sep 2022 09:13:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJU-0003bZ-05 for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:13:08 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20058.outbound.protection.outlook.com [40.107.2.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 703d27ef-38c4-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 11:13:07 +0200 (CEST) Received: from AS8P189CA0017.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::12) by AS4PR08MB8118.eurprd08.prod.outlook.com (2603:10a6:20b:58a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:13:05 +0000 Received: from AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31f:cafe::8c) by AS8P189CA0017.outlook.office365.com (2603:10a6:20b:31f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 09:13:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT047.mail.protection.outlook.com (100.127.140.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:13:04 +0000 Received: ("Tessian outbound 3c27ae03f5ec:v124"); Tue, 20 Sep 2022 09:13:04 +0000 Received: from 9b23682e8610.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2C12A616-0F5E-4193-8A50-022FD27B38D1.1; Tue, 20 Sep 2022 09:12:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9b23682e8610.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:58 +0000 Received: from FR3P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::7) by DU0PR08MB9439.eurprd08.prod.outlook.com (2603:10a6:10:42d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:12:54 +0000 Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::12) by FR3P281CA0154.outlook.office365.com (2603:10a6:d10:a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 09:12:54 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:53 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:50 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 703d27ef-38c4-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BNAqS+oVdu6cKeoZSlV0ev5QJJPBOOzuuYtfg/iAIXORGv4Caxl0qzeUpBWqL5X+QuYFJHsscj7iE6aMbSvaqsVtZ1I3FEs7AM9vICPASp+ddOeVTO2rTxhtqglYORCHhJcJ2uXDfsDwCGZa1Wfp1A7yTva65EMZ6UR5TeiELtqjtEWAvByNilCzrjlxNicPKs0jV70ZIJUIjBj6qTjFFawL4SUIkDJ9P1QTb1eqU5FEnShqYhgwjrWzR2Ppi1VIzK6IaPzaNo6NjbOzVsV8h5bamDATMstrdYUMlXIvus8ennpySrsMEj98EXvTmebOjuKT1CZD2jMLbZfrRNs4Mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XFQSEiC1wVF3SghW0Tlnd8Ag25n68oQY6R+gL/4gByY=; b=lFU8WavDFj7DZPhiOBdIoEnZqRDHyM00lJDROrZT0wKIv/dAEpr+SwhItINLS/c9QjcLbgJHtgh/XwzloJi+9gQbQvi5bl/oCRfoSykd5zJeTLqMMYDaOn9e7pnQmovUuNzUWIxqYWRsSySHjMlmYPotQVlEAa97MtdCedFUyg9Gi8t9LXf+DD+7A5e00LnePLoWRAtVopTQpkTzZ5CRxXf/3MrA7s4dL7qGKk7AIchHW1AQMkffsx/Aoh9ZMMfgdRDJwqpNLw2uFQELZ5BBROW8hBbF9RIOWAGbFcGuFXHEjnUM3cr0a3mPrtbu0i3FfVAu66BTJEC4VLQnuzkC8A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFQSEiC1wVF3SghW0Tlnd8Ag25n68oQY6R+gL/4gByY=; b=f9CjWTpSqa1JJoD1N8w8Pw8tJw3p+GTXZWczW1UjKo48HiJikHvyfzjR4YAklu+18Pc0iAY8GiyZ8skDUgD88uaLPC1XJxaHMV1SfKVUA76993T9I5UFaReqFtwxhh+PAaf0n7Jgxcit53VXku2Zl9qtXRoMqZDqF8j8ReJY1ew= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0269bc582c795a1c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SFuMSDp0e4D0vJVbEaW/Bj9Nun2dIXHsz8bOeNQ5qX1KlBCWi57+zSfZLVLvH+iFCYgZQUbmdMzjc5ji3ceCTuuIHnxfl6gi2y+p67MlA2yEaFXpkduskRCWCC84RnfqsSm24j7SCRCd25Y/wZkId98/7CnP0KI17kSJbeix5IXfIPnDviajeDKChKe+xQKmcXK5UKeePWe/sW+eRqVNenBk5j7cVjKDokXeXx0Smjr+obDkYbuRRgmfzVsRkZjhbGNv6Hsu6+E+EkjdtMfjpD5Vuw0Dew5R4P1+z18KVZiIA6tuE7II2NXVH0mbuuv3D5qOYieuMYprv9jZLGt9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XFQSEiC1wVF3SghW0Tlnd8Ag25n68oQY6R+gL/4gByY=; b=ThRUpxkIZfzjMmehywjqtyiJGo+Y7B84n1n++CeSOx0jfHQw0XiQyCkeA+n4/HazMKv8WSEe/S2kUG7xTvENVp21it1sjsZaojsUQfSg2GuBjRPgztcg27GPRYjr9kEx7KbEb5jroH0/VQ3ttHb1YkMwzRYHT6ARin+OXmP/0dJS3EQwRBazpxxkoxcUJ0yU6ts3a6Zt7R6azMqYk0x3dG4AMLh2UQ6zuuIRhZ3pNmPrFZOBl4UPo0S+Y3XG1LPAmNI+1U7kGpw9oA45GHmxKZgl33HFcKWSN9VcKQLONR1MQTeA8uShZBF9E+Js7Y2dlefKov+Vq/5zcVCY+/47AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFQSEiC1wVF3SghW0Tlnd8Ag25n68oQY6R+gL/4gByY=; b=f9CjWTpSqa1JJoD1N8w8Pw8tJw3p+GTXZWczW1UjKo48HiJikHvyfzjR4YAklu+18Pc0iAY8GiyZ8skDUgD88uaLPC1XJxaHMV1SfKVUA76993T9I5UFaReqFtwxhh+PAaf0n7Jgxcit53VXku2Zl9qtXRoMqZDqF8j8ReJY1ew= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v5 6/6] xen: introduce a Kconfig option to configure NUMA nodes number Date: Tue, 20 Sep 2022 17:12:18 +0800 Message-ID: <20220920091218.1208658-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920091218.1208658-1-wei.chen@arm.com> References: <20220920091218.1208658-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT028:EE_|DU0PR08MB9439:EE_|AM7EUR03FT047:EE_|AS4PR08MB8118:EE_ X-MS-Office365-Filtering-Correlation-Id: 2212cf38-3720-46a0-b347-08da9ae85324 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: urH7mDjAbkrn4EL4iEgbWWoPyvPsknma3r3jsqIuZM4k7OAnMvPT/cYnqec1OHsxdZgNlNglVtu53nR4WR/pH45MtcsLzMh/DlAmhvIfvrUkDjgAKDmrH2ZsP+WtxFN4BJzWn//c3b0kACjmINBtFrC3uNPKe60MFpmsyiQhpufhjNOSEGIL+O42uIzqLAYoNtDvr9x8czwBZXy92vboTspNe2u5pDm7aPpkWbCNIDZVgqO4UAxuO19n2tYlM5Rg4KBS55F0G5gJdqd78CJY3q+2dlA0fIiizvnBVU0hV0dOGtGfNGFAiyU3LoRzRpHPqfnMNCJJR7EdXVdSFFWTh867kxt959zcxKwMQ7sVrovDtaFYWgFnFkg7SfXV88r3k+2uAqdGCmLQtloO7yLitIc1GqA72HouqV7nn399jMkmCzZBz4w/Bl9+PR9cRqWXg8kxc4LYKWM+IOVSWm0T/aoB6Al+Hcu8VL99RgKBQZmaNJ+nxFnlvXugv3QYt7A+vsd/4Ehm/lSS6tplrx6AQDAVz2fcLlg4uJZ0vxjUJitos0jKHgjiZtwl67drYuQZ9BtpxmMAvMoxpxEDyXMQ99Ak7/xK30n87gEasGfXEfCtrx57H7oEpb0ws7cNnpFu5gdCNmRyPNgqTq1/B4Oy8YCclhXAWQd1d8moDieRpJXdR1wGj9l1IDeL8CpEqUT9+mYgD6CUEZ5vtlX/pglHwNaoX8t/G7v1cjgqLlnxuFtfKnJZphI2RZx1ivqRw/kft2yz1kkQzalhgpoWXnOa+BGaxAAT1jVByI5Qun9fXLw= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(1076003)(5660300002)(40460700003)(336012)(82310400005)(2616005)(186003)(316002)(44832011)(47076005)(54906003)(6916009)(356005)(8936002)(86362001)(26005)(40480700001)(4326008)(7696005)(36756003)(2906002)(36860700001)(82740400003)(478600001)(426003)(83380400001)(70206006)(8676002)(70586007)(41300700001)(6666004)(81166007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9439 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 166e9532-e357-4c16-e3a4-08da9ae84d28 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d/q6MHh2HoE0qNw7J+F5cedxpbNMcuAPvqoyshO8DK3FJQ65g+MSDgg1ZNwcYhDh12eeWsvtQalV7I7FTElvrgFYoKkgMM4rfUklFTU5YbkgAvcMc8I+vM50R+BTyU2yHVjObBEkvZlLAXOSLK2txWBPsHz8Um68/OtNC4y/JX5IEjgtBYbLe9zi4DqNrxQYn5jF24Mt2nIL3zsJfgNz/1o7ftsQG6FAtkfRgBnKDiISQ1l6b25PEzZWh1SqFiS+MIMJPQ7nn1PbBECI0kf+YSrmSoHsag3YJ0kijnUJIVm3BlAxPcRXJzCRk8f2Oz4TIimJhDIgbSCDIFmtCcSywsjNms5CkcbpGqACNozo04p8NIx6R8Oy1TcG/7is+10S6quJ3DdVaGIKS+Jj+1QxZ+LcCEX4Tmeln/i54E1PcUpmLi+pnZGD5UfiNqsidq0rQqUMY3y8SXcqMtQR2nthDDlGF85lf1OeYAPVJJKCigY5HnfPcGM0jtFqWuy1eiQHbQmU6WKK+2bamYnGhLahnmiyvYh1cQaToL9p0/EqN3PyCt6CVfL/hfAgeWFV/tHMu2OIs3A+c/07QEg+G0yFBpHjBrZRORr7ryeG7uQVPZos5tZea1gYtklQ7dfFEhTAA1lUlEy6kBQbIQbSn38nnXi3g3jU1gAd1yb5EG7+Ilp9ecPje4wVpKTuNSj+ROg2lHLEcpZ9nzaOzRr+dxK+hWF4cw39ysFJWs0MNy0w0FtBFb/oiMqxEsOb5EojpvMsKDhNxtABI1EQlpFbGcm0Sw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(36756003)(81166007)(86362001)(82740400003)(336012)(47076005)(426003)(83380400001)(44832011)(5660300002)(8936002)(2906002)(186003)(2616005)(36860700001)(107886003)(7696005)(1076003)(40460700003)(6666004)(26005)(70206006)(41300700001)(316002)(8676002)(4326008)(70586007)(40480700001)(82310400005)(54906003)(6916009)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:13:04.3725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2212cf38-3720-46a0-b347-08da9ae85324 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8118 Currently the maximum number of NUMA nodes is a hardcoded value. This provides little flexibility unless changing the code. Introduce a new Kconfig option to change the maximum number of NUMA nodes conveniently. Also considering that not all architectures support NUMA, this Kconfig option is only visible on NUMA enabled architectures. Architectures not supporting NUMA still use 1 for MAX_NUMNODES. As NODES_SHIFT is currently unused, we're taking this opportunity to remove it. Signed-off-by: Wei Chen Acked-by: Jan Beulich --- v4 -> v5: 1. No change. v3 -> v4: 1. Update the commit log to follow Jan's suggestion. 2. Add Ack-by. v2 -> v3: 1. Fix indent. 2. Use 2-64 for node range. v1 -> v2: 1. Add NODES_SHIFT remove message in commit log 2. Change NR_NUMA_NODES upper bound from 4095 to 255. --- xen/arch/Kconfig | 11 +++++++++++ xen/arch/x86/include/asm/numa.h | 2 -- xen/include/xen/numa.h | 11 ++++++----- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..7028f7b74f 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,14 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_NUMA_NODES + int "Maximum number of NUMA nodes supported" + range 2 64 + default "64" + depends on NUMA + help + Controls the build-time size of various arrays and bitmaps + associated with multiple-nodes management. It is the upper bound of + the number of NUMA nodes that the scheduler, memory allocation and + other NUMA-aware components can handle. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 2ca3475271..7866afa408 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -3,8 +3,6 @@ #include -#define NODES_SHIFT 6 - typedef u8 nodeid_t; extern int srat_rev; diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index a87cdc45b4..cabe8571b3 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -3,14 +3,15 @@ #include -#ifndef NODES_SHIFT -#define NODES_SHIFT 0 -#endif - #define NUMA_NO_NODE 0xFF #define NUMA_NO_DISTANCE 0xFF -#define MAX_NUMNODES (1 << NODES_SHIFT) +#ifdef CONFIG_NR_NUMA_NODES +#define MAX_NUMNODES CONFIG_NR_NUMA_NODES +#else +#define MAX_NUMNODES 1 +#endif + #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:13:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:13:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409273.652281 (Exim 4.92) (envelope-from ) id 1oaZJq-0006jq-QM; Tue, 20 Sep 2022 09:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409273.652281; Tue, 20 Sep 2022 09:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJq-0006jf-MR; Tue, 20 Sep 2022 09:13:30 +0000 Received: by outflank-mailman (input) for mailman id 409273; Tue, 20 Sep 2022 09:13:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZJo-0003bf-Pg for xen-devel@lists.xen.org; Tue, 20 Sep 2022 09:13:29 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b5dfc75-38c4-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 11:13:27 +0200 (CEST) Received: from mail-bn8nam04lp2047.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Sep 2022 05:13:24 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN9PR03MB5962.namprd03.prod.outlook.com (2603:10b6:408:133::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 09:13:22 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5632.019; Tue, 20 Sep 2022 09:13:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b5dfc75-38c4-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663665207; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4YHFyNuqfTvwtt90VA7gPzi53dg5IfFg0G1iOCSvIqU=; b=UIbea7lo7Z4t/8nj7JTyRxPsrx6sPoKSbtbmflX/QnS09fJ1D/7r7oGX EE2nYoMIvnNXlzCrXyH3LP/QTakij1EbGgiIhZlEUM/jYt+vj9w7eU3Mh xcpx5EUbKD2xe3IDGk7MK0VVNrCQrMMOLO8e3yw0kaCfuBA0ggRoXPis/ E=; X-IronPort-RemoteIP: 104.47.74.47 X-IronPort-MID: 80891102 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AV61MSqxL6bO4XcjZ5Zl6t4n5zX3woTo+Zkaqj?= =?us-ascii?q?vDw7gybGU9jkrQqtRKur3SU3acG28CN/bdC0tmiH8aeK0I9ABMoUBUDFkQp0?= =?us-ascii?q?TuPRj6084WW7g6TtOVfilLI9t2LsSed3PuWywGNSbXSPedMwAv3/5wpVxrIt?= =?us-ascii?q?IRI+30NbWvdIrg0Lcyguj4d+LDcTCpjhukZyNvvE+MuDzMzTbL4bu+ozuKuC?= =?us-ascii?q?cH8fkxaGPJ97Kvf+L7KR12O8QIJxRUjEBG4T9cj9shrqUogTO8Zufk0WvtJZ?= =?us-ascii?q?2uH7SrD/0S2JSmvlPc2ZxyZuszWmAzF4In6G9Jyw/ZNtFjTk6YaOuw5OcqOs?= =?us-ascii?q?7FgHjCc+MNMeisagFD4Y8YHHQ03oNOgZNNFJQdTeuHjR+nZd9cXMJpp4FxaX?= =?us-ascii?q?Sh0X9m/dTAIsp+OD6LsXhyt+4iBWExU9sZqqoEhVgKShRcfouUrxsLWdV+4Y?= =?us-ascii?q?LNjeFW/ExdB3GszIymflhmZ/c/IJi9IDT/eD7ll235YtNUIe+c5vw1Kb3OGB?= =?us-ascii?q?JgrZFvYzsPNS7f4Huv8Gef10vReGGCV0ZWuaYbskrv4Ef3U3oUEABqMKDDv9?= =?us-ascii?q?S46SRu4zN/y0geGbTaP/az8QXYDz6fLfpL2+E857Q2uzpmhkV2Uj8bjR/yv/?= =?us-ascii?q?SllPF5cFo/DyBEibzg/9AjbCQZdUMc6wbMdaVWTNgROEjIog9bWxK40XDOxk?= =?us-ascii?q?U4VQZ8O51jnBfOLCdnDXrZHgNv3tRSwMGIGn6P8MsHLjB3E9ERUF1Yl45Xrl?= =?us-ascii?q?uxjEtLZotPUvxmkJkPMCTRAgDNlWU+uzX5rpC0wq+QOwmrs9v+ge2kI0A5Tp?= =?us-ascii?q?iiR12WTzolazV+UMnB3bMOd3yjeXrjkY0Wtg/9Ji7UoRw2uruIxgET5NrKM9?= =?us-ascii?q?FGn4lkWjk9eH0KgeNnxP6V31wcAetLwgVDw7Elfhmosc+VA4E0haTSsQ5ZEw?= =?us-ascii?q?O2/DbYMva4K+ThWpf/I9v/c8g0/V5qPosY1eFnQKZ9KPRZ5ri7spngUsFk0h?= =?us-ascii?q?i5OnXSkO+BZwaauWDjt0BX7Io4pm4CiUu/o5kxKidsZG3SZnuwPyxZ7rUH7k?= =?us-ascii?q?1IUYAh9fTwfk4j03WtrVaYat+QNIwGxCXeoL1/f0pAhSwtCCLqlpCbbl8u9c?= =?us-ascii?q?FpsNL2hIdJRcWq7X09MGLX4iyLM6DxD9Ldn26FbzWKNL/0rQz50sY++hGE1G?= =?us-ascii?q?cASWQoCDeneMTELAJB+DCCyFSrNE011vzCJ3agnPGk8W7tW+mhxBHdOmtDxY?= =?us-ascii?q?k4xK4K3CO7238E2ItacQX+bAH13K3UPapvJR4dlJE+3zcPlyeCaIROfwxzM9?= =?us-ascii?q?TARIMRA87gwxUpNz6aKcE3tuCJYLBjJbWjw6D9Qvg4HfSxy6S8RT3BV1e4EW?= =?us-ascii?q?Ks3j9/OnVHOIn6HJ7Y6X1ruI3KqXZkyCsdmLDfUPkD2WfrnbydBvu3zQRxIe?= =?us-ascii?q?3SwfJPLAr/tIvNmt4JNUQ/pI/FCm3AMRdi6VpGOojqru/KB+OedSKwOU+Qd0?= =?us-ascii?q?DDcwzN+OHDRxhVm44l6ouhf4t4R0pSLBgT01oOSsFT0fQbeKLDhJovHVlELp?= =?us-ascii?q?si/wzQbRIrq7KtCMCNMQMyjuyAkqbLlM2GPiBqzQ9BpBE4hUANpe/FNNu8mV?= =?us-ascii?q?HBxXsaC7RmIeol8ZS7eQDuatY9JQgzAxRj3ba4EdArAn76PyASllZ3p5tK0i?= =?us-ascii?q?+3SWTWgPq/BMBfLXu4ZsnD0gUeM0GyiI5jF4qAZWPuSXjZwHE0kqB6rAb+28?= =?us-ascii?q?2PZd2DWU862Ufe1jcE2hgIJE0t9CC6azxpK0sMuNeoPAOtLLlmby4XQHPlDa?= =?us-ascii?q?v8+QfAI/7Tzz76tfWvDRsihorijNCNzxY+iygZVn3S2YJ4zKBi8mhPyUrt25?= =?us-ascii?q?tn/NJp+mF6nXO4SN7RusYUucltIpzfNUtII1UazieB571Z7upPwNTKefabLo?= =?us-ascii?q?vFrb/fYl/m+fcVvvV5uUZl36WfM3eVHOFSCqHGt4aAnAcEfhqdzDyr/KnT9A?= =?us-ascii?q?QWxtClyqMiTBYQWnGw/o93EVf6QrYu68gWXuieuIDTZq7t3G3mEopiYnHZNR?= =?us-ascii?q?KoILXy/89PXtYnmkvf7K66awUb7RGhWJZxlJJ9RNQb1Ip2qCdi2kSha3dgUW?= =?us-ascii?q?3q2GpDA0BT/7AVI2pJoWgLYD97RywBrJY35sQPfdFCYBDz8tfroJitl6T9Jt?= =?us-ascii?q?1CaQo+OLAFF+azcQlqvsuOqNX61AVLje9vYTwDwplL7pQttA/EHiz67hefw2?= =?us-ascii?q?SfkECp1Tjqyb1KwCfarQspkvPKWtZbWQlD/DQKjLBBRJWyIvR4HFCjk2Vc7Y?= =?us-ascii?q?W+NTLFOmuXHh+0QSCb1BcIXHyVIQGhj5FpaGDeNzuwk?= X-IronPort-AV: E=Sophos;i="5.93,330,1654574400"; d="scan'208";a="80891102" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h50Pi9l9g+PoPScufzztxPXlUJa4NkSKs0rmuY8goOqt8jB5rhN30qkHpFrQ7R+sH22VgzPGpWbX4mgLu8O23PY6R+ybCPDPOOvsJDW9ZRV3EA7/84XTTCmpRu7jft+01zYgyqGnHlJ4+6iDJxlUm8kMH1BtXzfX7gAbpdd8zNQE+BWk7buSE/Ou1KuykcHmhzXVx//UdjIOPbmyNLa8ONvY991lExHHg4KMLglcVOLjS/60YoeiMJdrG/AE6cJzBPIFlsN7eU+fIzh9Z5IKpsyIrYLFZQDUMnk6PQz8kxnnUKLU09ogLgmr3749MILH+ykNPkqS2JI78z3rSsZKPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=diwGpH9k3jnMVvr7mPoh11vQ7FN5gn6CE0Gd0mSDnuc=; b=Mkr+nIYrxjoxPa2gPuZ1rFJKoaLfVWjB0GTWOElLn7jcaHS4bwPmJ1MZlFVkz32SnHhw2K6/ZSi968Oxf4kbKVyzCqmwb22X8ao4EhENfwRnAq+kHnEv+bRzJU7hccpmbeXyyTU1RsW0s0IkZ2EhcW1AyQl1dc+v/nGQHrmOp/kWMuvBFvbUwFQimHVvNnDvZsPJCFebVXRCFmAEUHieVKqt3+oXWrQ8iIQSzaWVGLqsRkTjTe26WRYQaLBOnFnEtLOzVm33Cnup2wohNS1wfp3E3v4aoRa0S923a58aArzreFoK2wKRFgtGC5JeHEzxeM4NQ8T1iifmlGYtCkiSpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=diwGpH9k3jnMVvr7mPoh11vQ7FN5gn6CE0Gd0mSDnuc=; b=rBM0e2IDNFmfjPWsjrrM5adGspBJyv6T27/ckX3Urr4FTFzkTb9jzd0k0qNKNdf9BDSTuEBqNxdKfUnHZnHB0BEcYmhf8+EVXp0v9/8T98/1xWvQEbdXn5KvdUcxPc5sYL4MXS6IGauNGienDwaLOQ+LZ4kEtzN1KMILGYBg5es= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 20 Sep 2022 11:13:13 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Adam Szewczyk Cc: xen-devel@lists.xen.org Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0104.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::8) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB5962:EE_ X-MS-Office365-Filtering-Correlation-Id: 0efcedcf-9ae8-4b21-3eae-08da9ae85d8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yqgcKz5p2/idZsu/pBsz2AwhazUYO29o/tJ5BOec/0SCEyDhtc0YaCf0I5kR/nCczzd0riRkiCbiCxcqkUC0gTJb9ejX6GgldCvkMi4hvxlhqu/4RG/JPREsJUldojxgBl3PETwurz2BHIyHMmMFbiB9rDEeoXwNaeMZWxW9Q4TunI5/Yh3aQOjgKgL1E7uxE5XW1oj00sKBf65fif0KH89pX3wGzP5AbdWmbasr5SY1sicP98adEXleMayB/+/6W9+9gNcdcxjBCZcT48R1QWOioUlqA8i822/8Mgs3oUcAh7asiq6Wo0I9xCcPtGcwRg1apj5Vl4YS7wZPOLAbigsDHtrcNaFLbSTjBx9ugaUVr8C9SqyEiNmluhiPQktRVRIXeZHcKepula4EE7KG5c7HR+kDfaQRLlebLhOc3vsw1WR+h5J33DQvP+FDzi3ui6qyVyHXRKbS2oFb9VpvTg0iTShZJ+NfIjYrIbGMXxs3FO32vVl2MzSIdyoGPiV+ItVCnwwi/gsqBiJByih3kwjlIG23S6TV6Z3ngulDbmHYNkDFO9Z+vzak7PXlSm2OAWB3Jk7Szl8u7v1c86PbfDC1N84OWCxwSc5PvDRHEQkJ1SeQQugfAeeOSmJbxsFlEap6+addIfOXYJBHGvnU/qQy0VXG7zOCbuMMciOZ3IihQm1/6dv8/rQ5hplilVB+kiOXpfJ5nyJM26q++h7sRNwL5ovXpNNK4h+IQqU5FKwz39rXPFq469HVegnypKPq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199015)(6666004)(6506007)(26005)(6512007)(9686003)(85182001)(8676002)(86362001)(66476007)(6916009)(66556008)(4326008)(41300700001)(66946007)(82960400001)(38100700002)(186003)(6486002)(478600001)(2906002)(316002)(5660300002)(8936002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVVEc2FCNi92aWVzc1FQRHBPMUR1NllCV01XNExqcWl3enhqTjJpSkFENFVF?= =?utf-8?B?WWJTTjd6NXNQaFhyTW1kdkZoa05zaGwwT0lBVmY5K3hzMjUwcGRFYytYNU05?= =?utf-8?B?aWJPSm9idTE0cW1lN1ZCM1FJY2JMN1RrSjdHS2lqcncxT2E0TmNzWmdkUzhK?= =?utf-8?B?emQybUhicHdyQ1hBOXd4dkF1dGJYVWttb0FDQjRYajk2OVZSaWduM09HdDBy?= =?utf-8?B?alRPdjIwTncrOVZrK2dwQS9PMXlyd0Z2RkZuWVRRR3Nqcys2dnRpWWZMZmZO?= =?utf-8?B?dEhhV2xCUHY5NC8wTG0xSGRURllsczlmL1N3RUx5TDZlalBLOStsV1BrMVZU?= =?utf-8?B?a1dPQjkva3ZBYldsbkhxeDFSNEQyNWlLdDd6OUh3Y2xZWklZMzVZeTlIc2lG?= =?utf-8?B?VEFhR1A3VUl0clBOSkJRWU5IcFBxUlpHVXFuVnNaaVdBWVBCeEVDdEpwd1B4?= =?utf-8?B?WFVSd2hvWXRrc1BOa1NMSGRsYnUva3FkMTdJa29qY3JQaHp6UnI4cnRDYWpx?= =?utf-8?B?UmI1RElkcDRXSFRqT2N1NTlXOUJ3KzNvQXdCOHltNDJvVXlidzRTTWtJVWFs?= =?utf-8?B?cDZzVUVkaEo4ZUV3aXBFaDFtbiszenB2cGpLWTNSL1NQSDU1czNoanNqckpS?= =?utf-8?B?MmpPUWRzZFZsbFFBT3g5VDhNTFZYbWVxODMwa01mb3BYdnJORE5NOU8vT2tw?= =?utf-8?B?TlYrRlR0N0VvaE1lSy91OFJuT2VUNUlLakc2a05rbEszQ2JVRVA5RWpaRnhF?= =?utf-8?B?eHdORHhTZFNva2kyZEZRVVJLdU9YbWNPdnpCNk9jVUgvL3ptSnVva3lkbE1p?= =?utf-8?B?LzVSZ1FTOEJpVTNqWVBsckh6VTJZcmNOMWoyNm5sUGN5SXlETzd1QjZIN3pT?= =?utf-8?B?Mm5YaFZZWDhLU1RQK0RrcWNEamJPSXNaQnQ1V2g4UTlCWnVXaExMMmRaZUgr?= =?utf-8?B?U0NMeDlmRC9rRzJ6Sk1uRkw0SzRydW9pV2RROCs2LzNSMWRtZmROWHN5YlZx?= =?utf-8?B?TDIrRDB5QmFudlljWTVDZDBkdUREUUg2V1YxazBDSDFWSDU4OHhqU0pZSXV3?= =?utf-8?B?QVM2NU1oVXU2akhyNWltRmE5b0MrWnh4OTU5VGNOT0Y3QVRkYklUeXFBTVNL?= =?utf-8?B?cndTMjMxR2JiV29VSmxrK0NQZGlVaDFmL3pNbWk1TkF1dGtmSXRibGQrUHFv?= =?utf-8?B?M2dGeDYvUktkOStjdjg2dVFad0ZsLytDUnJDV1laVElQUHVnRDRNaWdXNzBO?= =?utf-8?B?UTN2cnJXY2I2dVVZU2xaL01oR0dsc1B3VkZwN292SEVhM2IxTnk2S1NXRHlB?= =?utf-8?B?ZllxSGlPQW5MaFZEcmN4ZlpwV1dyUGFvQW8rTE1TdUZSTk9xa0FIOEpVUmZO?= =?utf-8?B?NGxlNjErY056cVEvQjc1SE16VzR4VjVEZHQ0bk5LWlg0ZnJxemxxVnIweXYx?= =?utf-8?B?eC9jMWYwdVZLRERyZGhhMWNnRkJFS2tQaWFkTVdWSkJSTDFWaUpOa1hqNDh5?= =?utf-8?B?bm9idWY1V2ZwMU8rUFMrVkY1dFJxT1d5Sk9tUDFleWxqRm5Rc09YZDc4SkNI?= =?utf-8?B?dTYxdk9NN3hMc2FydnBHckxvT1plbEZWQkYyVldtb1JSZXYzSU02czJnUjM0?= =?utf-8?B?RWo3UHV4aFR3YUlhY0d2OUoxai9hYktMNDlmN0RVbTBWZWVCdXNNNGNUaGJk?= =?utf-8?B?ZzN2bThlcHFHbHpOZFZONkxmcUFGNmdWS2kwRjhxWFNNQ0MwSkcxOWh0dUZv?= =?utf-8?B?aDJ3K1FVc1Q2bzY4dHdROTdZYkZTOVJvMWhYVVZMVkpkMTRYamNtbEJzcnNw?= =?utf-8?B?ak9UNHRQekNxSDBtMlNrZWFzREhWbTNaWHZZdkhCc0p5MFhEaUxDdGEyS2lL?= =?utf-8?B?OVBrZGVFUU4zQVZPZFgyd1ViTHQ0U0xUQXZvYVZST3dLVUtIcU93dUVOK09Y?= =?utf-8?B?bU5kUGZ6Qkt2Mk1Fa29NZ2N5ajc3MkFySkk5NUVZRU16RHJ0OVI1TGdmSklp?= =?utf-8?B?Um8yajNLQ09rbEFQUWJiTnoza1gveldPaUUrQ0RiMUdYR2ZFeld4WmRCYjA1?= =?utf-8?B?eGRXdmxETXcyU3BXdjNyUGpRYmZ3WGhzeERLWkdaTVI1b3phd2hOYVNTaVVG?= =?utf-8?Q?8seFE1WZRPj+fOYNPByXKNwSf?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0efcedcf-9ae8-4b21-3eae-08da9ae85d8a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:13:22.1590 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JyhZuLdXKIEKY8F9dVwWqGdjz/L5cV2FG+WtS9CvtLnlLoFTr37tqXs/YYtHTt1uejRJolaJVtkSak2MY45vgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5962 Please avoid top-posting. On Tue, Sep 20, 2022 at 09:41:48AM +0200, Adam Szewczyk wrote: > > (XEN) MSI 132 vec=d9 lowest edge assert log lowest dest=00000100 > > mask=0/ /? > > (XEN) IRQ: 132 vec:d9 PCI-MSI status=030 aff:{8}/{0-11} > > in-flight=0 d7:151(-M-) So this is the MSI vector assigned to the OpenBSD domain, and is indeed masked. > > openbsd-71 7 511 2 -b---- > > 63.0 > > openbsd-71-dm 8 144 1 -b---- > > 14.0 > > > > How I can enable install this debug hypervisor? I have problems finding > anything about it. You will have to ask QubesOS about how to do that. I have no experience with QubesOS, and don't know if or where they provide a debug build of Xen for you to boot. > I don't have logs with qemu in the name, instead I have gmp-proxy logs. But > their all looks empty. Right, QubesOS is also using stubdomains, so it's not clear to me where those logs are stored. For debugging purposes, is there a way that you could create the OpenBSD domain without a stubdomain, and just run QEMU in the control domain? That would also rule out whether the cause of the malfunction is due to the usage of stubdomains. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409299.652292 (Exim 4.92) (envelope-from ) id 1oaZNB-0007yD-Dd; Tue, 20 Sep 2022 09:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409299.652292; Tue, 20 Sep 2022 09:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZNB-0007y6-AQ; Tue, 20 Sep 2022 09:16:57 +0000 Received: by outflank-mailman (input) for mailman id 409299; Tue, 20 Sep 2022 09:16:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZNA-0007y0-8j for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:16:56 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2069.outbound.protection.outlook.com [40.107.105.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f83c3283-38c4-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 11:16:55 +0200 (CEST) Received: from AM6P195CA0017.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::30) by DBAPR08MB5624.eurprd08.prod.outlook.com (2603:10a6:10:1a8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 09:16:53 +0000 Received: from AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::a4) by AM6P195CA0017.outlook.office365.com (2603:10a6:209:81::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:16:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT064.mail.protection.outlook.com (100.127.140.127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:16:52 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Tue, 20 Sep 2022 09:16:52 +0000 Received: from 3d823101a763.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 795B08DD-2084-45BB-BA64-C40C6B644DC0.1; Tue, 20 Sep 2022 09:12:52 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3d823101a763.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 09:12:52 +0000 Received: from AS9PR06CA0707.eurprd06.prod.outlook.com (2603:10a6:20b:49f::27) by AM9PR08MB6690.eurprd08.prod.outlook.com (2603:10a6:20b:301::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 09:12:42 +0000 Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49f:cafe::90) by AS9PR06CA0707.outlook.office365.com (2603:10a6:20b:49f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 09:12:42 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 09:12:42 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 20 Sep 2022 09:12:40 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 20 Sep 2022 09:12:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f83c3283-38c4-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BWDAU5TPAaLR9ckzUs8/2uEfcEVyzKNColu2wBP12zM5WsQ1PyeVCnG2hap671iAttrDlLnjlT8Uo2gN74M6pfpni+pn/Mg79G9xzfJkbHbGhD5tMz1C1VIbqixL7VWAHQE3pQ1/WOa3AMWdGjO4C1L43BEK+fWGlNe5pDFzkl4Gg9zrXRhHfUsWWTvV9iARSnJT3VrhSA76ueL05DvL4G2wL6dyrl128G/xuSGTOVgN3Gg64n3359X6IrQUliCnr7Z/tLZ1318ErfPUa0+b6PyV5x9MnOfWqoq3JV5NoOjus1pH8ubPSuGpBFuv6lkxVFkzvjyiyA9FiB/te0xccg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6DaMcTmBvEOAxWIqm3dcdE2xbuzXaoqO5YyicuQ8bxo=; b=lVhhatIQ1pS/vlGAiqGqjXwc0W2LuR21yV6T1VuEyAaAcOd9UKx57x7NPiwM5w2rHYe+IsC17EsZzDf0877SIFwlzj2xIHvobFZP5u3MNkaa6uqusPhG0Sw0fNYfURHzCBpg8rYynCLqRxm7ZjPaQeVSaMmE1LkCaMddOk53Sn3uUD4OHuY34TfdKA/vwb1WGA8MDVjHHSmNS2kGhOGCZmKHNcDs1UrKzSaSkg2XmJ8ChbCVPm56ZVVKcxT4/TyNCLmCFq8la8tJLPnnx0uFas3y+rrTMlgrf6u7Lj3yze3o/vDV7af3g14P8mP35eD2woUpn77cvh9oKH9/Pi5gYg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DaMcTmBvEOAxWIqm3dcdE2xbuzXaoqO5YyicuQ8bxo=; b=RgM9cX+dC++EhRTik8CCsp8kT5sR6iFlOPjuHz7b5htyA8YGV0ejelljonRflGqwk5g8cXQXk34zV35Ps4F89ZP6pt5N4lX/UX6Bf4aHWDfnk8VzSsRGHcqnjaaPd5VY4x033PP6uLUL55Vc64DygZxhP0o0Qj3rj5fOnxRCY60= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 43dca8f344d9e2cc X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+PXDO/VoelDCejfWvdYh4TLXYHsd499FQPMA5h/kJ/blJQVRgEOxw4vyzM+mSyFLc0cYKUFXwoiIKx1Yd2VTpM/Pf8LdtnAkFTSKCo2GYm2dbqswCr5nHZVi66zYLLU1ZQMnjNeBHPiHgpb4J0WGSPBCcce/O0DVUiB1J3iUM7jOmk6H26neCNGkERZHjOmLJpgRKw42ms6vqUz8vsjUqMcuQibgbCPuB6zgBacy5++SWR7VUKr6hjDmWZWxglqcuBTTPITHwal8KscV3Ds6oekcj69kFr9TN0Pe48ZDrRKAIUtwQeE4shovT6gw+uS4fCJv87vIPGwd9SaKhhJjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6DaMcTmBvEOAxWIqm3dcdE2xbuzXaoqO5YyicuQ8bxo=; b=mcC8ZpByX19NgcnV/wUJjo/QbODtUleRpVdAvJX12RjQeO912gxB0takxSER9K3AlCuPFevdIK3anKnszsxgvHNm1aQ4gGEusyf0iwFplEB0W+9xmovxfyiBH6RGOdJfGBBmg+GPkzjNz9aT9u4x57UhQIkl/rg3uQkTbvmfHQErWCL78LVvx7WlRh4ncnF06QmDo3dACYYwP2b8R3zI825Dceqh67fHfJv+68giTDtiSuoMs9YPVBHCUoTyj0G+hEDHE0GzlCNATayzhHC2ah5NNvqjMNxcIRZs7X1hfrF1gsyaA/cQdizdaYse/ii2cGr+n/F3Qklzs8p8uWZb2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DaMcTmBvEOAxWIqm3dcdE2xbuzXaoqO5YyicuQ8bxo=; b=RgM9cX+dC++EhRTik8CCsp8kT5sR6iFlOPjuHz7b5htyA8YGV0ejelljonRflGqwk5g8cXQXk34zV35Ps4F89ZP6pt5N4lX/UX6Bf4aHWDfnk8VzSsRGHcqnjaaPd5VY4x033PP6uLUL55Vc64DygZxhP0o0Qj3rj5fOnxRCY60= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Jiamei Xie Subject: [PATCH v5 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Date: Tue, 20 Sep 2022 17:12:15 +0800 Message-ID: <20220920091218.1208658-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920091218.1208658-1-wei.chen@arm.com> References: <20220920091218.1208658-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VE1EUR03FT042:EE_|AM9PR08MB6690:EE_|AM7EUR03FT064:EE_|DBAPR08MB5624:EE_ X-MS-Office365-Filtering-Correlation-Id: 0250bd80-b067-4514-5b25-08da9ae8db34 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Y9EZAEsKIQfzJUOjncMeIrXgQbWXVU/pUEYrOGF/xUk1qQxG6HaxbAPdcvu77xtfLIwP/iuLBK/zomtmTQfmkaBHlwCn/LBDI6eGgiFBDO890cxvzryTA/Ora0Mfu5RzEUKwaL1wzTHw46P2Jk/nj+doLnfr2XXcwrPoKKeZ/Si/gyrt+fjnnOwsVgRmnZfG1QBKKQOL1opUlAz9lCrjJvs1mfC0pmlIquV1k2xmn13qmTQoD+9TvjnCKtfwcCixE8pxKLBd1dgGqE5jYPHqgVMZ/zsqjL2L9dzW73xXSeVdR/O0KJWskwTjzrghu6ClS8eW380+fAQRQseLzKdsl7iWrrp0Helb2G318pX62RrRyz6oZGJubJFPPZE+bSLUXm6tjq7cIZIa/YGpH6T7iuoT/x8K2vnEaAqQ6MZTuLeaxZkjzUy2RpbumWwPDl6RRpuzMkxEpQx901wu/eYOyoZrccBA8hc8xoygE2Sdx/HcEFhxfpnm+a5iERjqwRcg6KtsEsiqO9mOHmRsSPmrDposQXUEyi1A+4laDtugwIicPV9ow0R/grfK7yOedJPBzVaCI6kpGIzL57JEtg8n3gnxnuv+S3mp4aMpj9zeZP0JAynKQoR+IQ2x+0bgSFxXAvtSPVj8742zh/nvTKtQpdlaLxT8Us10q9RlSmyyq7I3y2eZ2ziDen0HyEAbZBTmyBdUgNUUeAMBHriIcqfAOvQL+OW4FKcdlJuNEiK4+Wf0qM4MvsNG9PatCkPga6PFsUViejOULD0ik06Cqq8e1Mo51qL6rap+7wJdbDFRFnrU3qk/j2+wXD4smTAuLwBV X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(40480700001)(36860700001)(82740400003)(8676002)(86362001)(81166007)(356005)(70586007)(4326008)(70206006)(41300700001)(54906003)(40460700003)(6916009)(82310400005)(316002)(5660300002)(8936002)(44832011)(336012)(2906002)(1076003)(186003)(426003)(47076005)(2616005)(83380400001)(478600001)(26005)(6666004)(36756003)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6690 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0d087843-b9d5-4b1d-2290-08da9ae845ff X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fjCpt7xoU3gBwfrQzJodfd/aFl1yx5Qy7rIDIOg4aG94UvKU2MIzUr6mptYxZlpVmbSpWjQsYLh0H/1cjFXUV0Qk8FFBC/hQJSgM1SZqSpHM+zs9dNRdLXcOltrITvUhVlJGYZy5RoNzdN8xo3He6XrLXa2jGQl4BFcHiyJJf68CHIzqRnnLdpGIsTCmSMP2sUnagZx7+GlA9bXTskgHZbWahDI0fcEb8ULZeDmEy4rmGD+5b+vnvPPkmdtwEhoVclTJs+AqFmrbbHncegGGUoOSE89GmF5FxVGbQkkQW9UbFKesigaJKtORhpOUf78RE7b4dyi8XiO9VGyIUB+2xKo/0uBdxghRWtcmF6fEOQd5vncVtfTENMTTdBJySXoQ2Ou38/5WlIu7xtELRipRGq1FwGDq9buFvIjHAR0G0HI4P/E0rU5V5PiFKsze9Uh4MVKzUEqbayN5RbNefkVuNOMVhJRfCCMEao/6gMXRqMfVzVEVBtBgKCVwc7KztxszYuXpslT5YlPHuSmzggLk+jyI3QfGo8YbibmwnbYW9d5FWld2Wxu1dlpx4QxZgwHk4958sq8c7l9TAB4zaXEwbclkJXif8s5SsBxgaiuddsN//ItwpaDOn/h7zNwZU4xZmGqWXBMI79ufymrgg78nqqqJe/obFWNftkRm9X+1kD8EYrmHOZy5FlAhQSRbPWn5UFv3keaK9oGDS9gTUanZqjMuy0u4petx9xvImdLA9NbKfLiB1ojkYk9Hfx0IFr3RCsr9wUJlcg982WePoR9T5w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(26005)(82740400003)(81166007)(40480700001)(6666004)(36860700001)(8676002)(4326008)(44832011)(54906003)(2906002)(2616005)(41300700001)(82310400005)(7696005)(186003)(47076005)(5660300002)(36756003)(478600001)(86362001)(8936002)(426003)(336012)(70206006)(70586007)(6916009)(83380400001)(1076003)(40460700003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:16:52.6453 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0250bd80-b067-4514-5b25-08da9ae8db34 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5624 VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This results in two lines of error-checking code in phys_to_nid that is not actually working and causing two compilation errors: 1. error: "MAX_NUMNODES" undeclared (first use in this function). This is because in the common header file, "MAX_NUMNODES" is defined after the common header file includes the ARCH header file, where phys_to_nid has attempted to use "MAX_NUMNODES". This error was resolved after we moved the phys_to_nid from x86 ARCH header file to common header file. 2. error: wrong type argument to unary exclamation mark. This is because, the error-checking code contains !node_data[nid]. But node_data is a data structure variable, it's not a pointer. So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to enable the two lines of error-checking code. And fix the left compilation errors by replacing !node_data[nid] to !node_data[nid].node_spanned_pages. Although NUMA allows one node can only have CPUs but without any memory. And node with 0 bytes of memory might have an entry in memnodemap[] theoretically. But that doesn't mean phys_to_nid can find any valid address from a node with 0 bytes memory. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Jan Beulich --- v4 -> v5: 1. No change. v3 -> v4: 1. No change. v2 -> v3: 1. Remove unnecessary change items in history. 2. Add Acked-by. v1 -> v2: 1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 2. Adjust the conditional express for ASSERT. 3. Refine the justification of using !node_data[nid].node_spanned_pages. --- xen/include/xen/numa.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index d799078a7a..538b283d95 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -36,8 +36,6 @@ struct node { extern int compute_hash_shift(const struct node *nodes, unsigned int numnodes, const nodeid_t *nodeids); -#define VIRTUAL_BUG_ON(x) - extern bool numa_off; extern void numa_add_cpu(unsigned int cpu); @@ -70,9 +68,9 @@ extern struct node_data node_data[]; static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) { nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize); nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages); return nid; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 09:56:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 09:56:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409313.652303 (Exim 4.92) (envelope-from ) id 1oaZyq-0003qK-GO; Tue, 20 Sep 2022 09:55:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409313.652303; Tue, 20 Sep 2022 09:55:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZyq-0003qD-DW; Tue, 20 Sep 2022 09:55:52 +0000 Received: by outflank-mailman (input) for mailman id 409313; Tue, 20 Sep 2022 09:55:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaZyo-0003oa-Tp for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 09:55:50 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67dbd79b-38ca-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 11:55:49 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id go34so4878528ejc.2 for ; Tue, 20 Sep 2022 02:55:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67dbd79b-38ca-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=MOHpKFoYlYyycfS9c46ICESvGULQBNymssneeKs799o=; b=quYFlnIJleuARwEhPjdTz1ToiR+OvGdDRZw0wCdlnOJ6MTQLsWsNk/r5mDr6XnAX31 Hwj1d7mMoZGkMAivnJ2J9OA8ZQ/aEG9aq2Y0P6e4Wu9l0ogP2si80dYknPFTqUq67bFn Xm8Wc5/TDj6+sKRKK3cwfKdSiiVQZAM+wkG1hTzjWA/gxyr377xjsFx1EDW7bYvLo1Xu bN5dAy2agecZU4e8CyZs4D9MTl7i4prTbe0AYlQ0hmgCrP2yZe58bj+hgNmk3fik2WQI YCH4MamgZK77XXUAxDmY6RQjMtha7B+/kchkih5CEdwvGX58X2okw2imIkQdZF7pfF6O s7qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=MOHpKFoYlYyycfS9c46ICESvGULQBNymssneeKs799o=; b=E9fudr2/ZGBneTJGlogOyzfjYyHvM/PbNaFXp4HPTQTVDxmX86lJndcuCruqDXazQO mAdHbEnji2FZucM78JteFp+d9y81dXwaKWhhA22xlhx4IEgoYs5VEspr1cZZ9asjG7LY 0oZ0zHLCGp3rGtYWabmtnU09r8b8otEqjbVVUpUL8F6DZ+/K7nYS2vQJmEcjqSbpOZIc NQjBVLan+1DvoUYlvAM8iFmIOySIntNIj8W554qtb1eBGmHiTHmRoW3QD7erVuLpF2ot gv+gRzy5q6BInZ94TlIzWOebt/KXDbhrgaOGUikyNjihzibmiD9yWQR6UTf+ArmlVz+i eZMQ== X-Gm-Message-State: ACrzQf3RVA9FT8HUdFmk7TjN6u9Qb0TNM1xoU44ToWY6COUrAq5qammS RKSmMO2zsK6vFyKMnz2vQvQFjfTAvtDDMUDfk7uDQQ== X-Google-Smtp-Source: AMsMyM4VRt9iN2Ys9FUPfBpfYY02peK2ICLg9+doecZ6zcnwoVeZC5tVrJoMYR6zFGBVnQfqk1brL6iSz7epg8D/0ao= X-Received: by 2002:a17:906:8a6b:b0:780:ab37:b63 with SMTP id hy11-20020a1709068a6b00b00780ab370b63mr14241916ejc.365.1663667749166; Tue, 20 Sep 2022 02:55:49 -0700 (PDT) MIME-Version: 1.0 References: <20220919231720.163121-1-shentey@gmail.com> In-Reply-To: <20220919231720.163121-1-shentey@gmail.com> From: Peter Maydell Date: Tue, 20 Sep 2022 10:55:37 +0100 Message-ID: Subject: Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al To: Bernhard Beschow Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Content-Type: text/plain; charset="UTF-8" On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: > > In address-spaces.h it can be read that get_system_memory() and > get_system_io() are temporary interfaces which "should only be used temporarily > until a proper bus interface is available". This statement certainly extends to > the address_space_memory and address_space_io singletons. This is a long standing "we never really completed a cleanup"... > This series attempts > to stop further proliferation of their use by turning TYPE_SYSTEM_BUS into an > object-oriented, "proper bus interface" inspired by PCIBus. > > While at it, also the main_system_bus singleton is turned into an attribute of > MachineState. Together, this resolves five singletons in total, making the > ownership relations much more obvious which helps comprehension. ...but I don't think this is the direction we want to go. Overall the reason that the "system memory" and "system IO" singletons are weird is that in theory they should not be necessary at all -- board code should create devices and map them into an entirely arbitrary MemoryRegion or set of MemoryRegions corresponding to address space(s) for the CPU and for DMA-capable devices. But we keep them around because (a) there is a ton of legacy code that assumes there's only one address space in the system and this is it (b) when modelling the kind of board where there really is only one address space, having the 'system memory' global makes the APIs for creating and connecting devices a lot simpler Retaining the whole-system singleton but shoving it into MachineState doesn't really change much, IMHO. More generally, sysbus is rather weird because it isn't really a bus. Every device in the system of TYPE_SYS_BUS_DEVICE is "on" the unique TYPE_SYSTEM_BUS bus, but that doesn't mean they're all in the same address space or that in real hardware they'd all be on the same bus. sysbus has essentially degraded into a hack for having devices get reset. I really really need to make some time to have another look at reset handling. If we get that right then I think it's probably possible to collapse the few things TYPE_SYS_BUS_DEVICE does that TYPE_DEVICE does not down into TYPE_DEVICE and get rid of sysbus altogether... thanks -- PMM From xen-devel-bounces@lists.xenproject.org Tue Sep 20 10:22:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 10:22:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409319.652313 (Exim 4.92) (envelope-from ) id 1oaaOn-0007GI-Lm; Tue, 20 Sep 2022 10:22:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409319.652313; Tue, 20 Sep 2022 10:22:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaaOn-0007GB-J4; Tue, 20 Sep 2022 10:22:41 +0000 Received: by outflank-mailman (input) for mailman id 409319; Tue, 20 Sep 2022 10:22:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaaOl-0007G2-EQ for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 10:22:39 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2514fbe3-38ce-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 12:22:37 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E6CC0320094D; Tue, 20 Sep 2022 06:22:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 20 Sep 2022 06:22:34 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Sep 2022 06:22:31 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2514fbe3-38ce-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663669353; x= 1663755753; bh=Zb2ttjexm25nSErrH1Qs0sc6fNpSSZGOJeMnkPS7Jz0=; b=v FZrQj8QMS6QBP/gRofwDrd+a+JmeUfiHL08M6jMVPSlrDhvMe3UgAlTB22AQfcBe okJRbj6vQTTIpCiqVaZnKoPGlbTBWS6h2FaoZ4C0J6sLzNx5J2e7U26iuu3GyyEM 95/HBal4GShzhbPDVMAWmjWfEP/4rY+H+u05F1ib8cQrAI8s1W9n6DOrCbKUW96k LuCeY+4mkIgQsiNz5lMaiILilU3gL8kKFFwlg+FfZl+EnF3IaTWPlmX889SKYo4x MsikhsYknwYDZywTLgvbVRpYMPIVs/GelIbY0XalCtyjYllGBPPv1M4LJYpf9wba tl3AHG1HcuGDibf/ijBqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663669353; x=1663755753; bh=Zb2ttjexm25nSErrH1Qs0sc6fNpS SZGOJeMnkPS7Jz0=; b=gjD6W6qXcW+3/CJdVTmRYPgy/FV+vPKLmX7hVprV8nKh ZZb2omV6lhhn8/OaJBLtpyUiPpGO8xdihoGq9rErwZbyC0FJjd0w+5A3CdZW0YFo dIaO/7DQszXrEUGo41cJiWtAVd4XFUT+9qOz9xHo+CSTlNcXTwpf2Lb28iZN1RIW ZQXchxm/pUWaQz+pvk8MUIHEfsJVnKsp9f2YWyZlPjScc3X+8avozq2uQTmOIDvS Wv+PiJC8AtCrLCHwM6v6x22nwIUvuIoZbzRApBV98r/j3+ONQEoH8FSOJNTsTOKS /aNGia22JHRU66OS4OcPEbcKya4zqISAKL+iRJ5TTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvledgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 20 Sep 2022 12:22:28 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Juergen Gross , Dario Faggioli , Andrew Cooper , xen-devel , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Message-ID: References: <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl> <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b3XNn2j6HW0jQyWK" Content-Disposition: inline In-Reply-To: --b3XNn2j6HW0jQyWK Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Sep 2022 12:22:28 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Juergen Gross , Dario Faggioli , Andrew Cooper , xen-devel , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer On Mon, Aug 22, 2022 at 12:00:27PM +0200, Marek Marczykowski-G=C3=B3recki w= rote: > On Mon, Aug 22, 2022 at 11:53:50AM +0200, Jan Beulich wrote: > > On 21.08.2022 18:14, Marek Marczykowski-G=C3=B3recki wrote: > > > On Sat, Oct 09, 2021 at 06:28:17PM +0200, Marek Marczykowski-G=C3=B3r= ecki wrote: > > >> On Sun, Jan 31, 2021 at 03:15:30AM +0100, Marek Marczykowski-G=C3=B3= recki wrote: > > >>> I'm resurrecting this thread as it was recently mentioned elsewhere= =2E I > > >>> can still reproduce the issue on the recent staging branch (9dc687f= 155). > > >>> > > >>> It fails after the first resume (not always, but frequent enough to > > >>> debug it). At least one guest needs to be running - with just (PV) = dom0 > > >>> the crash doesn't happen (at least for the ~8 times in a row I trie= d). > > >>> If the first resume works, the second (almost?) always will fail but > > >>> with a different symptoms - dom0 kernel lockups (at least some of i= ts > > >>> vcpus). I haven't debugged this one yet at all. > > >>> > > >>> Any help will be appreciated, I can apply some debug patches, change > > >>> configuration etc. > > >> > > >> This still happens on 4.14.3. Maybe it is related to freeing percpu > > >> areas, as it caused other issues with suspend too? Just a thought... > > >=20 > > > I have reproduced this on current staging(*). And I can reproduce it > > > reliably. And also, I got (I believe) closely related crash with cred= it1 > > > scheduler. > > >=20 > > > (*) It isn't plain staging, it's one with my xhci console patches on > > > top, including attempt to make it survive S3. I believe the only > > > relevant part there is sticking set_timer() into console resume path = (or > > > just having a timer with rather short delay registered). The actual t= ree > > > at https://github.com/marmarek/xen/tree/master-xue2-debug, including > > > quite a lot of debug prints and debug hacks. > > >=20 > > > Specific crash with credit2: >=20 > (XEN) Assertion 'c2rqd(sched_unit_master(unit)) =3D=3D svc->rqd' failed a= t common/sched/credit2.c:2274 > (XEN) ----[ Xen-4.17-unstable x86_64 debug=3Dy Tainted: C ]---- > (XEN) CPU: 10 > (XEN) RIP: e008:[] credit2.c#csched2_unit_wake+0x152= /0x154 > (XEN) RFLAGS: 0000000000010083 CONTEXT: hypervisor (d0v0) > (XEN) rax: ffff830251778230 rbx: ffff830251768cb0 rcx: 00000032111d60= 00 > (XEN) rdx: ffff8302515c1eb0 rsi: 0000000000000006 rdi: ffff8302517690= 00 > (XEN) rbp: ffff8302515cfd90 rsp: ffff8302515cfd70 r8: ffff8302517690= 00 > (XEN) r9: 0000000000000000 r10: 0000000000000000 r11: 00000000000000= 00 > (XEN) r12: ffff830251768dd0 r13: ffff8302515c1d00 r14: 00000000000000= 06 > (XEN) r15: ffff82d0405ddb40 cr0: 0000000080050033 cr4: 00000000003726= 60 > (XEN) cr3: 000000022f2a1000 cr2: ffff8881012738e0 > (XEN) fsb: 0000744bf6a0db80 gsb: ffff888255600000 gss: 00000000000000= 00 > (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: e010 cs: e008 > (XEN) Xen code around (credit2.c#csched2_unit_wake+0x1= 52/0x154): > (XEN) df e8 6f bf ff ff eb ad <0f> 0b f3 0f 1e fa 55 48 89 e5 41 57 41 5= 6 41 55 > (XEN) Xen stack trace from rsp=3Dffff8302515cfd70: > (XEN) ffff83025174b000 ffff830251768cb0 ffff830251778270 ffff82d0405c4= 298 > (XEN) ffff8302515cfdd8 ffff82d04024fcb8 0000000000000202 ffff830251778= 270 > (XEN) ffff83025174b000 0000000000000001 ffff830251769018 0000000000000= 000 > (XEN) 0000000000000000 ffff8302515cfe48 ffff82d04020a8c9 ffff8882556ae= dc0 > (XEN) 0000000000000003 00001910537e623e 0000000b988f78a6 0000000059d4a= 716 > (XEN) 00001901f30fa41e 0000000217f96af6 0000000000000000 ffff83025174b= 000 > (XEN) ffff830251756000 0000000000000002 0000000000000001 ffff8302515cf= e70 > (XEN) ffff82d0402f7968 ffff830251756000 ffff8302515cfef8 0000000000000= 018 > (XEN) ffff8302515cfee8 ffff82d0402ec6de 0000000000000000 ffffffff82f15= 7e0 > (XEN) 0000000000000000 0000000000000000 ffff8302515cfef8 0000000000000= 000 > (XEN) 0000000000000000 ffff8302515cffff ffff830251756000 0000000000000= 000 > (XEN) 0000000000000000 0000000000000000 0000000000000000 00007cfdaea30= 0e7 > (XEN) ffff82d0402012bd 0000000000000000 ffffffff82c51120 ffff88810036c= f00 > (XEN) 0000000000000002 000000000001e120 0000000000000002 0000000000000= 246 > (XEN) ffffffff82f157e0 0000000000000001 0000000000000000 0000000000000= 018 > (XEN) ffffffff81e4a30a 0000000000000000 0000000000000002 0000000000000= 001 > (XEN) 0000010000000000 ffffffff81e4a30a 000000000000e033 0000000000000= 246 > (XEN) ffffc9004aef7c18 000000000000e02b fb5ee398d214b10c eb5ef398c214a= 10c > (XEN) eb56f390c21ca104 ebd6f310c29ca184 0000e0100000000a ffff830251756= 000 > (XEN) 0000003211016000 0000000000372660 0000000000000000 80000002963e1= 002 > (XEN) Xen call trace: > (XEN) [] R credit2.c#csched2_unit_wake+0x152/0x154 > (XEN) [] F vcpu_wake+0xfd/0x267 > (XEN) [] F common_vcpu_op+0x178/0x5d1 > (XEN) [] F do_vcpu_op+0x69/0x226 > (XEN) [] F pv_hypercall+0x575/0x657 > (XEN) [] F lstar_enter+0x13d/0x150 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 10: > (XEN) Assertion 'c2rqd(sched_unit_master(unit)) =3D=3D svc->rqd' failed a= t common/sched/credit2.c:2274 > (XEN) **************************************** Ok, I think I figured it out! I added a function that verifies run queues of all the sched units, and called it basically every other line on the resume path. The debug function (if anybody is interested): void verify_sched_units(void) { =20 struct domain *d; const struct sched_unit *unit; =20 for_each_domain ( d ) { for_each_sched_unit ( d, unit ) { if ( c2rqd(sched_unit_master(unit)) !=3D csched2_unit(unit)= ->rqd ) { printk(XENLOG_WARNING "d%d sched unit %d: rq=3D%d, unit= master %d, rq=3D%d\n", d->domain_id, unit->unit_id, csched2_unit(unit)->rqd ? csched2_unit(unit)->r= qd->id : -1, sched_unit_master(unit), c2rqd(sched_unit_master(unit))->id); WARN_ON(1); } } } } It appears that restore_vcpu_affinity() is responsible, specifically this part: 1216 /* 1217 * Re-assign the initial processor as after resume we have no 1218 * guarantee the old processor has come back to life again. 1219 * 1220 * Therefore, here, before actually unpausing the domains, we = should 1221 * set v->processor of each of their vCPUs to something that w= ill 1222 * make sense for the scheduler of the cpupool in which they a= re in. 1223 */ =2E.. 1249 res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu))); 1250 sched_set_res(unit, res); 1251=20 1252 spin_unlock_irq(lock); 1253=20 1254 /* v->processor might have changed, so reacquire the lock. */ 1255 lock =3D unit_schedule_lock_irq(unit); 1256 res =3D sched_pick_resource(unit_scheduler(unit), unit); 1257 sched_set_res(unit, res); 1258 spin_unlock_irq(lock); 1259=20 1260 if ( old_cpu !=3D sched_unit_master(unit) ) 1261 sched_move_irqs(unit); It calls sched_set_res() directly, which assigns sched resources, but does _not_ adjust runqueues (if new pcpu happen to be assigned to another runqueue than the one from previous pcpu). I have two (non exclusive) ideas here: 1. If old_cpu is actually still available, do not move it at all. 2. Use sched_migrate() instead of sched_set_res(). Here is the patch that fixes it for me: ---8<--- diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 83455fbde1c8..dcf202d8b307 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1246,19 +1246,29 @@ void restore_vcpu_affinity(struct domain *d) } } =20 - res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu))); + /* Prefer old cpu if available. */ + if ( cpumask_test_cpu(old_cpu, cpumask_scratch_cpu(cpu)) ) + res =3D get_sched_res(old_cpu); + else + res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu))); sched_set_res(unit, res); =20 spin_unlock_irq(lock); =20 - /* v->processor might have changed, so reacquire the lock. */ - lock =3D unit_schedule_lock_irq(unit); - res =3D sched_pick_resource(unit_scheduler(unit), unit); - sched_set_res(unit, res); - spin_unlock_irq(lock); - + /* + * If different cpu was chosen, it was random, let scheduler do pr= oper + * decision. + */ if ( old_cpu !=3D sched_unit_master(unit) ) + { + /* v->processor might have changed, so reacquire the lock. */ + lock =3D unit_schedule_lock_irq(unit); + res =3D sched_pick_resource(unit_scheduler(unit), unit); + sched_migrate(unit_scheduler(unit), unit, res->master_cpu); + spin_unlock_irq(lock); + sched_move_irqs(unit); + } } =20 rcu_read_unlock(&sched_res_rculock); ---8<--- I have several doubts here: 1. If old_cpu is available, is sched_set_res() needed at all? 2. Should both calls be changed to sched_migrate()? Currently I changed only the second one, in case scheduler could be confused about old_cpu not being available anymore. 3. Are there any extra locking requirements for sched_migrate() at this stage? The long comment above sched_unit_migrate_start() suggests there might be, but I'm not sure if that's really the case during resume. 4. Related to the above - should thaw_domains() be modified to call restore_vcpu_affinity() for all domains first, and unpause only later? That could reduce locking requirements, I guess. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --b3XNn2j6HW0jQyWK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMplGQACgkQ24/THMrX 1yzZIwf/ROf+Sz9YEvVFsACaBzORoRP4mTK2GBogwElDdl7E4oqA3M34orL2P8Tn kfQfgBUEOXX6PYj/AbMo1VJ6BGSqQpdEC3jcEzhAcMlIff0il5HgzRLRINuwTapn vPOz/nfsMlmJ9U9elwlSgPUVL8+2Ww1AjSeQG/Ti74roMKudsOR4RJi7UYT3sUQc Wmq8x2QzV8Qy0BO2cOzG9EGgHCSQlx+O+m43CLpdWmtA62pVz8jRu0rmiOf/up7i WY5i8yaO6uyKQuRHOe6w8uxkpumzvK85yNMQfHP+/ujaYoYfavP47Uf+HkN7MkZo puQcqZkOtv9X8VmCNJFBuoaaKnmPcQ== =K/WN -----END PGP SIGNATURE----- --b3XNn2j6HW0jQyWK-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 10:29:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 10:29:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409329.652324 (Exim 4.92) (envelope-from ) id 1oaaVH-00081Z-Gc; Tue, 20 Sep 2022 10:29:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409329.652324; Tue, 20 Sep 2022 10:29:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaaVH-00081S-Du; Tue, 20 Sep 2022 10:29:23 +0000 Received: by outflank-mailman (input) for mailman id 409329; Tue, 20 Sep 2022 10:29:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaaVG-00081M-GO for xen-devel@lists.xen.org; Tue, 20 Sep 2022 10:29:22 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15a1f140-38cf-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 12:29:21 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id iw17so1953001plb.0 for ; Tue, 20 Sep 2022 03:29:20 -0700 (PDT) Received: from localhost ([122.171.20.238]) by smtp.gmail.com with ESMTPSA id f8-20020a170902684800b0016f057b88c9sm1077188pln.26.2022.09.20.03.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 03:29:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15a1f140-38cf-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=R2F5K+M5lfxWwev5z8FfAb4dF1wQLjukQ42j9gJfkOo=; b=HKHtV+gTLbDeJccbaxlaaffkX3FETGuIdbaf5PPJ3/7vKuEDZ1xo6cLZgLysejTNYJ CeCRf7QdwmEqR+GTfxVq2KH6rQ1g0rKmPPCHX3WhD5jy/rBbk4LncAuPnMoI3zJO3dMO RwseEcuS21oOhWH2W2NyyKWWIPX2xZUlGZb9rHecjzeplFUHzoUA7kYFkcxpgJoXDhYN Gle5EJHSN+GsCYfu/FBU6NO3oPw5C6XWxc6smAdSV9Mhe2meCY4GpTEZ0135cLefOQ2M 12ajyeV+8NUej8HXYGBaxnvC/4TmpLNWLCz42EA1yEb+z1akXqlJP/PU+e1lHDs9vywb jqVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=R2F5K+M5lfxWwev5z8FfAb4dF1wQLjukQ42j9gJfkOo=; b=g9vXNbLFmpw4DOWpAKb8DrxhIfEWluMH+ixcQViDy7/tmXa849B7QfAZr5m9+WqSBO JEri8f1xyWLu0wR3mKWzxNk9We5DIyw11Y6OjdWPlwkKTAZCV587Q02d/RsODfNaEQg1 0Qg297ZURv3STZ0srCvC6GPCtYvCE7Lg7qi0qGW/hv7baslIytsBrEnH8LctUGJMS+/E IpG5H4/PabW5LN7qIcTDQ7l0aRx9YHKZXY91yBu1asQJACbyasEXOshFJOqt/aPJ3xYJ GCrSio6tuI916gR6kgZYaYZmMpiFX8pfADe3FnXFcwEdjYkYXWTul2y5eiUosCWMQsSz fGwA== X-Gm-Message-State: ACrzQf1Wx59yh7GOky8Ts2lK/G4Vk4gyMHJVb6AZWtF52nK7TTOxezQf BeMj/MbydgP1bTQGd7zjIiN2rw== X-Google-Smtp-Source: AMsMyM7BjhJsu/8Vkx+rsCbT8u2E5hmzwqBdrUPztTbAbrROFs55YbWztCipWKHybEj1SlNDGqrIog== X-Received: by 2002:a17:90b:3504:b0:202:5d53:86c with SMTP id ls4-20020a17090b350400b002025d53086cmr3102037pjb.182.1663669758459; Tue, 20 Sep 2022 03:29:18 -0700 (PDT) Date: Tue, 20 Sep 2022 15:59:15 +0530 From: Viresh Kumar To: Anthony PERARD Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Message-ID: <20220920102915.p55lt4ee5hbxiun2@vireshk-i7> References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 09-09-22, 16:02, Anthony PERARD wrote: > On Fri, Sep 09, 2022 at 08:13:28PM +0530, Viresh Kumar wrote: > > The iommu node will be required for other virtio device types too, not > > just disk device. > > > > Move the call to make_xen_iommu_node(), out of the disk device specific > > block and rename "iommu_created" variable to "iommu_needed", and set it > > to true for virtio disk device. > > > > Signed-off-by: Viresh Kumar > > Reviewed-by: Anthony PERARD I don't see these patches being applied yet, do I need to ping someone for that ? -- viresh From xen-devel-bounces@lists.xenproject.org Tue Sep 20 11:37:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 11:37:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409338.652336 (Exim 4.92) (envelope-from ) id 1oabYo-0006gx-Al; Tue, 20 Sep 2022 11:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409338.652336; Tue, 20 Sep 2022 11:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oabYo-0006gq-7h; Tue, 20 Sep 2022 11:37:06 +0000 Received: by outflank-mailman (input) for mailman id 409338; Tue, 20 Sep 2022 11:37:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oabYn-0006gk-7D for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 11:37:05 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a4d1169-38d8-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 13:37:01 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-nyyOMpweMKOJOc5LnI28Bw-1; Tue, 20 Sep 2022 07:36:52 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C1DF3810D23; Tue, 20 Sep 2022 11:36:50 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF591112131E; Tue, 20 Sep 2022 11:36:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A0E0D21E6900; Tue, 20 Sep 2022 13:36:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a4d1169-38d8-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663673820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q9Kiy75k/GjyNcX5/jFVpAejSl+0Eo6vMfAUPlGa7+Q=; b=OYGbM+OxxxL6pY1TjKJz4gTVCrAaoOCVNRNh2pV3j1iBck0WQc+65xLk//npdeZjAVhr2H PZBizRXG16HzwhhLutLXWClNsaKaea862Q3JqHN/2AFETCnk81sG0QpTkb31ChHLTZdkWa Mkm3JOJ/NrQImSb2E9IBzN0OE6QxMxQ= X-MC-Unique: nyyOMpweMKOJOc5LnI28Bw-1 From: Markus Armbruster To: Alistair Francis , Bin Meng , Palmer Dabbelt Cc: Bernhard Beschow , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Christian Borntraeger , =?utf-8?Q?C=C3=A9dri?= =?utf-8?Q?c?= Le Goater , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?utf-8?Q?Herv=C3=A9?= Poussineau , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> Date: Tue, 20 Sep 2022 13:36:47 +0200 In-Reply-To: (Alistair Francis's message of "Tue, 20 Sep 2022 09:31:10 +1000") Message-ID: <87edw6xoog.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Alistair Francis writes: > On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >> >> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to >> inherit from TYPE_MACHINE. This is an inconsistency which can cause >> undefined behavior such as memory corruption. >> >> Change SiFiveEState to inherit from MachineState since it is registered >> as a machine. >> >> Signed-off-by: Bernhard Beschow > > Reviewed-by: Alistair Francis To the SiFive maintainers: since this is a bug fix, let's merge it right away. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 13:06:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 13:06:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409355.652347 (Exim 4.92) (envelope-from ) id 1oacxC-0007WF-W7; Tue, 20 Sep 2022 13:06:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409355.652347; Tue, 20 Sep 2022 13:06:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oacxC-0007W8-SX; Tue, 20 Sep 2022 13:06:22 +0000 Received: by outflank-mailman (input) for mailman id 409355; Tue, 20 Sep 2022 13:06:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oacxA-0007W2-RX for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 13:06:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 038c7a45-38e5-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 15:06:19 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Sep 2022 09:06:04 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA0PR03MB5419.namprd03.prod.outlook.com (2603:10b6:806:be::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 13:06:02 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5632.019; Tue, 20 Sep 2022 13:06:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 038c7a45-38e5-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663679179; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/uMVgHsXASXPT1h9zCwV72jW0ZB33h1BacZNO5yCuPU=; b=BMM7Ote6yOdAoUNebYL4V2Hn+EHfEfs72UoyOySuKFn91/1bws8/JY67 guAHWitqd3fXt6z0bZu7IycfxA3CvV8luHHPhAUh9sNWukGNq+KIJpZWL uV944DC53S9Ufes+j013pld7nY5hv62w7Yai7Wm5OLVhoa5YYF276XtCQ 4=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 80574233 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:wGa+0Kq4j2fMayizTX7Rq3c+Yk5eBmIKZBIvgKrLsJaIsI4StFCzt garIBmPPayJYmKneI0gOdjn/R5SuZbVn4dnQQpoqX9mEihG85uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WlA5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUl6N14EThz7 sAxAywzSDaeoeaX7IiSH7wEasQLdKEHPas5k1Q5lHTzK6ZjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/F4/NpsgA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4Wrdry3w3LSU9c/9cNwYJKWA+M5yvAe04HMIGiYXCFm1uObs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2 TehgNfBFTFp9rqPRhqgGqy8qDqzPW0fKz8EbCpdFA8duYC98cc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNtGuVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:eZyhlKgzOYJFPEDgIVicNMcTi3BQXz913DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCJSWa+eAcWSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AWV0gK1XYcNu/0KDwVeOEQbqBJbq Z0q/A30AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGg9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9MofyygwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmg3f4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQC/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKorzPKN MeQ/002cwmP29zNxvizyhSKZ2XLz8O9y69MwQ/Upf/6UkXoJh7p3Fot/D30E1wt67VcKM0lt gsAp4Y642mcfVmE56VJN1xNPdfWVa9NS7kASa1HWnNMp0hFjbkl6PXiY9FlN1CPqZ4hKcPpA == X-IronPort-AV: E=Sophos;i="5.93,330,1654574400"; d="scan'208";a="80574233" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NygG6Z/y+1VSnCB1fAO4ACEAWa4+1CunEHtUe/Nwv8eCIp0M7utBgVGqlnstsi2vXiX+e+Rcvk5JFhtmQBsm36PPoPIaVqJ+IIqHZZvZ+dyeMs+cC4OFht970/LZLjcHrRdDP7jVbheIJOZfDBmLI3OaVvt4zdxSosf+1ncXAinwXChitRHE5bC5ChD+kv8LyjTLydfkLMJ0HrBjITCzAe6sCYJu3Bqq5OOA3DDUsWrRdoXqJe8gUzoFMKJfn85iOOOOgM5Q8+fJKtEKpC38G+etpdFDH2zECtQZBHVochJ/jn1WVp379hPnv4UZBafGzho1ClrQaVy/osHOA/4WIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9W1XzhSuoJVOfakoBvWD0zz0EJUBbde6jdFgCAzHTQ=; b=M5u9svo9Lb9TsALncMAs+Kp+DdgKwBwVYVKLSvPyaPWxuCYriIZJ2m5KATfLAdD31oIiR+vJt+FzJS2GvKe2wmIoi0gnvycJGufVGtYREP5fEpyycqdxkxMcOF1lHB1gqvTfgojj8s+YdjLEe13tgW4agaXqJYsU0Rusqo52TDej1ulObqgAFBs2iDiDsnuSDJmTXdNdTBYbD3pYk0O0WfkBBhuYW8MrOWuulxCvuPc6wa2jkqzbyiIjBRqBiQ1LlaUVKPIi7PouZ7In2JaSFmnoPp834Fnryl3BmJYqKeOm3Fp+hKiJ8Bx3FzgwOevGUn4dwl4m36YpbiByZBV/4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9W1XzhSuoJVOfakoBvWD0zz0EJUBbde6jdFgCAzHTQ=; b=OYI6j88++WLzUdd+aVlDi3IpNrDlpiIb/x90iKR0HbfbsGNDfadyrsOuL/dW+/AAKb1eCQdMWT3g6h00a+tQEcRsBzeLlGKZhYRHSX2m/UFT93qoaH+ce40OhG56n858yAu4+hsaJ1GzqPKWGHiFkq+xDTQ2WA+0kWiLflCiP1E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 20 Sep 2022 15:05:47 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Jane Malalane Subject: Re: [PATCH] x86/PVH: restore VMX APIC assist for Dom0 Message-ID: References: <0e0b1859-e7f8-3f8d-2be8-e0069b116525@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0e0b1859-e7f8-3f8d-2be8-e0069b116525@suse.com> X-ClientProxiedBy: LO2P265CA0156.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::24) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5419:EE_ X-MS-Office365-Filtering-Correlation-Id: 50dfdee9-697b-4828-4a74-08da9b08d95e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8ZaUjzSPzPIz3SyeKgFJhL2wU+Xnz6LdM+epoVK0RzaZeeNlqDi9ss71Q3cG0iUnsMfILmOxrQ/Tub7lVTDNbyS/UjL+TIS/g+zr0J4lie5ES68JeN2Y4JDtRZAoFkOqHueZqqJ2PivZh+U4Ug668rGSBsFPparlm9IYeVFWHQlyPnnCDvFTWodP6mnye86kyYf7ALyYAbVmLNhFM3bWnJ2qFuzllva8l4D54gQSQpZpPqn9d0gcAhR6VkcKNtNPhXJsblIJMpW7Ul5tcM3tPGizOFpheqceDk4zSWSJpIkpQiZ1Li//F92wv1RW9F0fJQTQYQ291XdXKgoQby8mp5i2Lm1PzRFXG5ReLrKEUoih9FS29Fa61FfKm7bmCQrNNAZ6AvUHPIdS2sI9MjC82V4uP5N/H4oaOeSJGtQFbxS6ZJtl3wLSpnnjcA3MotWnMejA2bUd7OCZ/TU1M7S2h5BoMp1CsfjTuBZK20TRgqe6Dsde8o8tOM6LRcGOD7eLeg7bOsmNBP9ZamuyCq/oII7Xb7+joLxBg7JKTVb5WVBAuvdk0AzP6YoglpiNlCs022IAVw9uY9kZDswtCU1Q71PxjzY/24fm5iRlZP8cgkIUqtIfWdRVAkauqkr7vhdz0OG30pZsIhPauOO6mkPDXlanFlpFmq6m53sAiO6+r7d5+RkDWmMv6veUvAbjxkL27YMkJnjfxR7hKmoM3XHxvg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(366004)(396003)(39860400002)(451199015)(6666004)(86362001)(107886003)(478600001)(6486002)(8936002)(41300700001)(5660300002)(85182001)(8676002)(316002)(54906003)(6916009)(66556008)(66476007)(4326008)(66946007)(82960400001)(38100700002)(186003)(9686003)(6506007)(6512007)(26005)(83380400001)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFNUaHdEZWVHYkxvQ0l3YlR4eS9FKzFQc08xWXRSTlVOcmlLRXR2cUQ0Wi9w?= =?utf-8?B?OE04ZFJHc2VHRkR2ZTZGNkVFV1NBb3BwenJZdzlLQ0FpR1VhSllITU5NZnY2?= =?utf-8?B?dnNXNGg0OFplenlhY3VLU0tRNVQrS3RHbkhVTHV6eE9LakgzaVBVNFlzTE1I?= =?utf-8?B?SmxvTmdWUW1CWUE5SnRUUW9sTkZRTkNzbG13bWJXc0dtNWt1QlZ5WGk2RTd4?= =?utf-8?B?am1vQmxmTmxDelFRdGxJanhISm5Wb2JzL3FvTnpSbE96bmQ5R0V1Zkl4bWc3?= =?utf-8?B?SGlHYWxIaWNkVzI3LzE3b3lZdVQ1ZjM4dlUzeG9ab0dDQno2TG5DUlkvUC9k?= =?utf-8?B?WjlKVVlaR2NvbmI4OHF4blpESk4yNVRGUHdVdmRTTldpckNkQUJMSkZod3BU?= =?utf-8?B?U3VNd0J5RkFpY1lQVVhnTnZtSm54R1BzV1g2RS94alpaVDVMeWpjdlBBRG51?= =?utf-8?B?SlVJSFVrZTMrb0hwMmxDU1ZPN2FEaXRtcTZkaktXN1ZlWm9QTWs3RnlyUlhr?= =?utf-8?B?Y1hNQndpSjFGZlZLM2tZK0owd1U5RXhqODBYcnhqelBWMDNGb0RLZm8wUTJx?= =?utf-8?B?WVR1T0VOYTNqMFJaMkxWZW12SVp4OUhpMk1vNnpZYjNZVVMrL3FUWVB1b283?= =?utf-8?B?bWwrZWpOYlVmUW1lM1FFeG1hRjB0a3JPNXRIU29oOGdCd0NVWjBZS05ZS2dU?= =?utf-8?B?cVdJQ0p0bENZUzNsdTFBeURycm1HSnl4YVRSWWxMWVhUMkJuc1V0TDVOSlpP?= =?utf-8?B?M1l6a01lTUNpeitINUxKL1g2SXR6YnVWRGdxWW9jLzdtVW9jMFhVM3JYeCtD?= =?utf-8?B?L0dMVGJWRWZwbXk1RXdIdTFwWFZjZDVEYzRmdmNXUjVYYVBGcTZoRjY1aG0z?= =?utf-8?B?OFAzQVV4ZjR1MkdEQnpsQW83WlRhM2I3YjI0ZG5hUDJOa0gwVXJqNEdGeW1r?= =?utf-8?B?aFNIRU0xSVkxQVNBeG9aRXl0ekhMMit4bDRLbGNZWEt4c0RvNUhDRk5udm5o?= =?utf-8?B?TzgyWnA5YTFEejFIS28vRFordHdmMlhqeDAyd0ZHWHg0VmdpQVowMkNpQUtS?= =?utf-8?B?NkVHQzNPbWRua3A5ZzdJZ3FnamNWL3FwTlZUdGROVnY2TVFIOUJWVXhLR0lK?= =?utf-8?B?UjJhRGtwcHJabFp1U2c3emdjMTE4dDFLeHRsejQycHFYaVI4M2doRTBnZUJv?= =?utf-8?B?cmxzdXA0QmxmNFVSRXAwc3VKMnJTV1U2RUNxblhxSWV6TCtLOEdIK1UvOVEv?= =?utf-8?B?eW1nQkFNWDVnYnFuYStNMUJNWnNobTZKbS83S3pHdFhkWEs0VmladXlCcGFo?= =?utf-8?B?QzQ2M2QwZnYwdUVNOTdFeFNFbXpGeVJTWjBUcTZmWlpHSjMzdytzZHg0U0Yv?= =?utf-8?B?Y2VFUHFYM1JjVk1DclN2aThtQWJ2cm0zOHBkWW1DOWVDOFNQZGl1dUNWYlRS?= =?utf-8?B?ZjM1aEtzR2VJckxaOFZNSUprVGV6aHg4TW1oUTFJVXlpRmtaQ1FkQm5PR1Yv?= =?utf-8?B?OXhEeTk2WStIdjRUdUZTRlFpZDBsZE9wOEZtT3ZZcnloaWN2TzJRaGtaeDg2?= =?utf-8?B?VXpPR25DdlBmOFZrbmljajN1bWhXWWIzUndGM09VWFRMaTBLaEFaTnVNT2Rj?= =?utf-8?B?bHlHdEJ2YnFPNHJIYXhza2R5bFBNN3BuazNMR2NiWHZXR2d6UTlpd3U1LzMv?= =?utf-8?B?ZUFYa25ydzc2ZGMxbUxIclZ0cnB4enJUck9vUlNGNFUwMHlLQVZBVW83MWxs?= =?utf-8?B?dlh5Q0NkRld1SXpFakJGTGVWcHhqRzV1NHJ0bUlqcVY3dXEwNFVwN0FrbENV?= =?utf-8?B?SkQrQ1I5Y0FBZkZnRzZ0NWpPMFpZb3NRQTNyMy84UjIxdU1PdDRsRzR4bEVp?= =?utf-8?B?YlV1aXNrSXU4cTVTNDB6MHNsRkFraGcvUHJCRGJiRHBhZ1EzWXZaYktsM0J0?= =?utf-8?B?SDMwT1BickR5d2MxUUR2UVFsaXFHTnRxUHNEYXl0YWhJdUlqSHBzNS82N0dN?= =?utf-8?B?ejQ4Y0VHNmZwMlVPQlBNc3MrY0MxTldIZHN4dDRRM0NUQ1dLMlNnUTFWUXI5?= =?utf-8?B?NTB4bDhKVUtreEk2NUdLcWdOZEYwS05kR3crejI5WGtMQ0ZncVhZWGpaUzFa?= =?utf-8?B?U2prWVZXQ1VYR1k4TDlPaG5EeWlzTmJPMDJ2WjdwLytwVUF1eU9HZG5rbTQ1?= =?utf-8?B?OWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50dfdee9-697b-4828-4a74-08da9b08d95e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 13:06:01.2684 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K914dzOhVHGAK9ZY60S8yfYKiLnJjUZeGDbaTJ5jM2CK1AlFEt0oSNdLIXhnkRGkVe2dWBEpZkZW/GUGlAm1mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5419 On Tue, Aug 23, 2022 at 01:56:22PM +0200, Jan Beulich wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -55,6 +55,9 @@ > */ > #define HVM_VM86_TSS_SIZE 265 > > +bool __initdata opt_dom0_assisted_xapic = true; > +bool __initdata opt_dom0_assisted_x2apic = true; Defaulting those to true unconditionally is troublesome, as the check in arch_sanitise_domain_config() will fail if either assisted_x{2,}apic_available is not true, and dom0 domain creation will fail, so... > + > static unsigned int __initdata acpi_intr_overrides; > static struct acpi_madt_interrupt_override __initdata *intsrcovr; > > --- a/xen/arch/x86/include/asm/setup.h > +++ b/xen/arch/x86/include/asm/setup.h > @@ -68,6 +68,14 @@ extern bool opt_dom0_verbose; > extern bool opt_dom0_cpuid_faulting; > extern bool opt_dom0_msr_relaxed; > > +#ifdef CONFIG_HVM > +extern bool opt_dom0_assisted_xapic; > +extern bool opt_dom0_assisted_x2apic; > +#else > +#define opt_dom0_assisted_xapic false > +#define opt_dom0_assisted_x2apic false > +#endif > + > #define max_init_domid (0) > > #endif > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -784,6 +784,11 @@ static struct domain *__init create_dom0 > > dom0_cfg.arch.emulation_flags |= > XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI; > + > + if ( opt_dom0_assisted_xapic ) > + dom0_cfg.arch.misc_flags |= XEN_X86_ASSISTED_XAPIC; > + if ( opt_dom0_assisted_x2apic ) > + dom0_cfg.arch.misc_flags |= XEN_X86_ASSISTED_X2APIC; ...the values of assisted_x{2,}apic_available need to be taken into account here in order to avoid requesting an invalid configuration. I could swear I have checked PVH dom0 interaction when reviewing the original patch, but I clearly missed it. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 13:23:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 13:23:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409411.652393 (Exim 4.92) (envelope-from ) id 1oadE0-0003KZ-Eu; Tue, 20 Sep 2022 13:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409411.652393; Tue, 20 Sep 2022 13:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oadE0-0003KS-C8; Tue, 20 Sep 2022 13:23:44 +0000 Received: by outflank-mailman (input) for mailman id 409411; Tue, 20 Sep 2022 13:23:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oadDy-0003KE-Ss for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 13:23:43 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70c5c260-38e7-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 15:23:40 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7B0145C00EB; Tue, 20 Sep 2022 09:23:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 20 Sep 2022 09:23:39 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Sep 2022 09:23:37 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70c5c260-38e7-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663680219; x= 1663766619; bh=8FD6DUsqOAoaMqj2hffhF5MoQj24xK+dBODsmGYQboo=; b=Z BpIYmqCr3CeuBYpFCAt+FXA1ERwkCxI27FC9a962sxsLibHVU8CJfEY1Jm/1/FV0 RPZLlydKeHrcdMSAfh4UUUZYziMty6m6WD5lIEI1Dnznf8tOm1tu6YZlGTQbs7mv cUjIAk29rgE3DSsaRNT9wahxhtGjW3X9Y5WX1L56fzgPssD0411CUFdlSwM1Ste+ 5Ui6D2TWndTeu95oJsaozlPHn0+o49y7Csvtv4KL8OmburKpzc43NG+yNSYong3u 1DnSIUKD1TuK4d5VcBhaZpurQMFQf0lpKofhTNi/2LTrKUfn5lLaS9DJyaSGFhLS lJNHE1i7QgScmaLPQtfWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663680219; x=1663766619; bh=8FD6DUsqOAoaMqj2hffhF5MoQj24 xK+dBODsmGYQboo=; b=ZNqyVN6lIlgGSBPJr0mJnrRRZFHRWYpRR4Bl0q2P2reZ v3RpLwIcFuKGL8u8U0KYrYF1OKzdV/tPgGIottORZN2xwClBNSe3AftjN5W+esr6 eFK3BIu85XCBRmMvDHA0oRQlYTqCJFGn+Vjd6sh3Ud4b/7/AFGXu55lVIRVaOlhO 4O1/AxmLOLi9olmxOXQvPwPftqWanPuZc8k1WA6kHEFd3muDn2ZuopB4F7pz934e Fqld3iVyP9Lufu4mtIM1pPWHfmpZ5TMkIAJx4yd8PoPXgk12/N/hnP6z552bQHmb 9X5a1jI7PLfJ05klTllXV2z5cBBsVdlTrWvf7pfiMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvledgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 20 Sep 2022 15:23:34 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues Message-ID: References: <20220919150927.30081-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HzSivIJW2fTAiZJ+" Content-Disposition: inline In-Reply-To: --HzSivIJW2fTAiZJ+ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Sep 2022 15:23:34 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues On Tue, Sep 20, 2022 at 11:06:57AM +0200, Jan Beulich wrote: > On 19.09.2022 17:09, Marek Marczykowski-G=C3=B3recki wrote: > > --- a/xen/common/sched/credit2.c > > +++ b/xen/common/sched/credit2.c > > @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, u= nsigned int cpu) > > * > > * Otherwise, let's try to make sure that siblings stay in= the > > * same runqueue, pretty much under any cinrcumnstances. > > + * > > + * Furthermore, try to respect credit2_runqueue=3Dall, as = long as > > + * max_cpus_runq isn't violated. >=20 > This last part is questionable, partly because the command line doc is > ambiguous as to which of the two options is intended to "win". I guess > one needs to know the original intentions to resolve this. Right, I've chosen this approach, because you can still emulate the other by setting sufficiently large max_cpus_runq. I can add doc clarification in v2. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --HzSivIJW2fTAiZJ+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMpvtYACgkQ24/THMrX 1yyIGwf/XAC2AcooLCBQsEo/8D+VbsvPoSAsEM0jKeuqtGbiigRF8StDyZa1N7DF W5mDdjdIn4TcShBZ35YPgKpMmHYaMV32Ij2YhrZQKraD/wkExxJPW62k+RgycpOY uyL0FMmY2jVx/cmBOU1PkSDpH20l0N055YUHd0NQk5CNCv/M5fXt/WziRW8pVUy4 544oTgUApsEXLS6A8wxEx4jMDroxhN1kR5ByzF2kp72Tmz6MxzHnnNYIEIiMJdE3 4kJazJ8Lnv/yLo1YokEdgmr9LzCq1IbVge2aaFuxWfncoZ+ecEPi2M0SWnBt6K/4 CxlYq1iVwNBBODKg8e0THKP75yC90Q== =KM8p -----END PGP SIGNATURE----- --HzSivIJW2fTAiZJ+-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 14:27:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 14:27:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409465.652410 (Exim 4.92) (envelope-from ) id 1oaeD1-0001mG-6Z; Tue, 20 Sep 2022 14:26:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409465.652410; Tue, 20 Sep 2022 14:26:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaeD1-0001m9-3e; Tue, 20 Sep 2022 14:26:47 +0000 Received: by outflank-mailman (input) for mailman id 409465; Tue, 20 Sep 2022 14:26:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaeCz-0001m3-VI for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 14:26:46 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ec04898-38f0-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 16:26:43 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28KDXQZT003540; Tue, 20 Sep 2022 14:26:33 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jn688exan-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Sep 2022 14:26:32 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28KDlHNu022968; Tue, 20 Sep 2022 14:26:31 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2170.outbound.protection.outlook.com [104.47.56.170]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3jp39qm1he-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Sep 2022 14:26:31 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DS7PR10MB5390.namprd10.prod.outlook.com (2603:10b6:5:3a1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 14:26:29 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcc6:79b8:7480:2ecf]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcc6:79b8:7480:2ecf%3]) with mapi id 15.20.5654.014; Tue, 20 Sep 2022 14:26:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ec04898-38f0-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=OXKOkKMY4UdF9Ksdqo8CuHT57dJsmzm4vvl1rc4TCl0=; b=Fo/Fal7uS9jIbyB/8wZcJSNqIQYsMrTzlSh2fR++UVu5J0BwsU3phKq2XWjJOyELcxQQ lYU+83+jvF9PM8t6WI7MTWXaCMn7Z59DDRsQMduK0zg4MlsHnReL2fxXC4hwNTsn8YXw 90nde55buUrWKz/HCEsv5X4yV/FKsY9dx9OVqDQv7hQV/fA8COoVz9d46pKyiNOrO2a5 iOB4mnylEYzVfTwzIWLBuMNzD/SdKqO32Xc/KZr2+xDPZ5qFWKkmuNG15kUoaG0NiqMA 32xhgK+728RwlyzoGoLdkNeL+y95G9b6gp21DyPr6tkuVdkZxTUnO0+/lSOKqj4vTz02 RQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3N1NryndL86A9mPwLy+KiwhpDT+hJpFIN4WbJUgPW/4KYEm8iaYbZkRMM6ioHsihftJjOb8yyGAQVH48j+3iNJK8f1aQEOhEypSBxPCVIkxK+xQJuGRJVVKID9WWkZm6V3g6hz6tUIJU6MVyG1WuvtNP98m/jRgP8y/TDwRpMCnS0WQSlWRBvMokTpJcRfLF7K/d0eregOguVhvqQz4otZQbCIu92KL8xGu5oVb0gvf+9oOaCZ1Khos5K5fRuKAaxJg0are992O1D6b2jT5zPwQUrpXCLQW/i2FixqxJDKwJiPWQrQxjbx1GUZycNsDeGjP/s59F/96BC0zTYpALg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OXKOkKMY4UdF9Ksdqo8CuHT57dJsmzm4vvl1rc4TCl0=; b=SLjOaClct14qhVqFq0hljJwM9WgkPCiJUJuSHIT9pCFA6KOHuYZBvXVOWnKSuJbWKN6XKC56VZfkf6Bwb5K3bBGlI50JJbANpnDc9/FfeuZJQsZOKiz2wahrIDMVhcxgjlxALjwqJHjdpHUdEP3VR+V4NL3iyjhbp0SxfG4z/s7DHX3cNla72wRhoKjWa1I+J8FCuXt0peniiF+eXyg/oeo5BZmFclrz8gW1J7Irptx7b+po+mMKBjUf2hs5WN+ZcUmLpze4ZEnvo2bzYwrvmqXyHQovUiI7SJrnPHaEg4DXsAVYR3gYhNZGH7MYJJh2WNFZGHT1MrkjyOx28P5yGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXKOkKMY4UdF9Ksdqo8CuHT57dJsmzm4vvl1rc4TCl0=; b=Zf2+g/Dqw2IeTtPz3/u8Ylxd9FPuUWOcBdUEKfqtFiZA+6ajZugZj2Qdx/lC5UAhFdpxO+mvO2PwbkfF5fMkITCfpuAel03jUmoLxI8U4fq8tSYuNp9R7N7F/F+iLIWzG1r5ek9OzmqUhO7MI7PoaIk/4OqWyAPDqmO+OBxqCFc= Message-ID: <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> Date: Tue, 20 Sep 2022 10:26:18 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel , Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> From: Boris Ostrovsky Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load In-Reply-To: <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DS7P222CA0021.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::20) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|DS7PR10MB5390:EE_ X-MS-Office365-Filtering-Correlation-Id: 9990f081-3f4c-4163-de97-08da9b1417d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VGlOLctN/rhiCaLEcTUJ1r2WIO5lwA/dGygGOsAIg5vluX7aa12KqA2frpl/mAA+2xRF2V0Gw4b5nua3SJGuPE2QOq+kOO0ctEbICn41KirwbOzWE9kOOF9kIWfNNbbLZae9tbnSW7pGE4bUtPXtB8VUmRV8l67P0O6iCt4EAQXmtu5US6TpIjL2FQ2H/0xOb35HSngRWl7vLqUqMwdD78uPwg8T4KZqueBrIGdF9x52hgq2IpCEhopuHuGzEMCQfAEAt24uBblfBKlk0Yvqxtl9gnNrJyNi+KYx9EcT3H5of939ebHkJcWE6ZeTFtkmJy34G9MLnvCtuwez8C8jftkuDrNaBp0caGT+8AkAKbwWbx3+o1dSzlFb8msm5Rgx4jcJoTKoHFFHuiVKxZDXY04QZ4KOuXYVMRdH5kd4WluMn87v0ZLnnzSm6Ww9Cuo2u/zno/oQiAWSdYx2wHhl1bMR+Pxoi4xxvFO+fH4JagNb4L+GI8iQneSaFiavi/+hbcf68M1MoXd9jK1TQCVsjuPLesMRcJqxd71PHyAmubf1N9V97BZvvLyhyAExQ/ywV+l3EFYWzrlD76zRfx44+nc7NZjGRgz8ePtv6+l07ipgNG801XqVkT4FWcAGCnIJ2p4JWHnKy/I01dbh/h0C1lybWuMxaIAkdbX7NES96J4gGQ45zFZgEFLDlAPMRU5y6FAlMJ2vlnhHGfswr9ibbF1Y+SdjFVWtXn61CCK7gwDE9bx9y+alUJfdB0i7Va3NunRkBQVnnsxazHh4gs3rObZqC+/xxoaW6QAu9FFKR+U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(39860400002)(376002)(136003)(451199015)(44832011)(31686004)(36756003)(2906002)(6666004)(316002)(38100700002)(4326008)(8676002)(66556008)(5660300002)(66946007)(66476007)(6916009)(31696002)(54906003)(86362001)(186003)(478600001)(2616005)(26005)(6512007)(53546011)(8936002)(6506007)(6486002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlV5Y1Y3QlZkWklDTEYrQThzNmJTSERiMEwrVkJwMWlNYXVCdzF3ZmZ1MkN0?= =?utf-8?B?SE9wQzNFQmpIOXlsa3Q1YWZxeFdTMWJkUk9yOWY2clZvQW1uSjgzd0pvdVNY?= =?utf-8?B?NXh4LzJJVFhDOWJ4cWRXM0N2ZHhFOEpwUVhlaG84RDNBdmFHQk8zVEcybUhD?= =?utf-8?B?R0Y1c2VOT3EyQkxSOU11eE15SVMzdTVkblI3NythRG94Z202OXhPOXVDZHVi?= =?utf-8?B?MFYraXNIU1RqWjh6WkNhVkUyaXYyZEdncytESjBUcEhZeHh4OWNWQ1NLS01o?= =?utf-8?B?WlJsZVlKSjZJT2V0MytNOUYwTFlLbWpOanlzakFNNWlmQ25TaDgxUUdSUmY2?= =?utf-8?B?dDYza1NPZ0tPMnltNndiS0xwTDlURG1RSDdxbjgwUW1QbVRzYS9Ib0R3MUlX?= =?utf-8?B?ZWF5M1lQdGVGTm1qZ2N2WFB1YjRGTmRsc3RJbldEMG4rNG1YajhiWWxKb3Zw?= =?utf-8?B?S3FlVVJHZ1hSa0hFTlY4Z0xkdUVHdzVWeS92Qi8wV0p3VHJXUkl2empFZW1I?= =?utf-8?B?REUrMVVGRFlLYUY4cGw1VW1rYXY3NVJ2cS9ZRTkvN1ZNbU1CaTM0MUpxL2RT?= =?utf-8?B?ZHVCb3V6Ykg4b1hNbEdUL21JTktRdm0wN01ZekhkVWNRL0FDRTRydC9XT0VE?= =?utf-8?B?b041U0ExY1hVSG5FNjd5U2xOdXM4d0NRRm1zRDJPUjhhbEFnNDZDdEdseWI5?= =?utf-8?B?ZlRWQU9GTm9QbC84VTcyNG0vUThIQkZnd2hnZ1V4NitwZndnb2RtMjNhelYy?= =?utf-8?B?aFJ3K1hNeXdFVVdXdTMxQXZjQUR1ZHFxbUlxUE96UGhjdVpsalhwZXQvQS90?= =?utf-8?B?ZTFIOXZOMjhXTWFXcks4VWh6eE9yOTM2V3g5eFhLZEc5WHBSNXFRZDh5dnpj?= =?utf-8?B?VnlSWGcwQU5oY3o1R3p3Y01zRXhmOXpqMjcyZ0h1enU5bjBJWnhMZGs4TW9M?= =?utf-8?B?cXVZMW1DS1hkNUpoczhpZHdJMHVNUytyTFdkRWNkNllxbU95cFBFRHpEdEdo?= =?utf-8?B?NlIvUlVDWm1oZEdNemZleUNWZ1Q3TzFPRTYvYWZ5azJDaFEvWmJ0MVZsbnIw?= =?utf-8?B?ekV2T2JmRzNIaUozSkhPQnBTUlhCSzFmdktlQmlTTFMzL3B0NFZkS0FkbGVi?= =?utf-8?B?akdQSm01TDViUzlkd3VISS9GcHVqZ2NQa1pRQktoQktRNmJOQy95RWNTWFN0?= =?utf-8?B?OTFzcjhTSk9kd3NSM1hlOU5xVUIxbkwwQ0pQbGdnUWluTHFFTHd6amNnRWRs?= =?utf-8?B?Q0dtQm1nWGtqOWMvTGdVWUpaTFVDNGR5THlyZ3MxV2pWcUR4b0RQWWIyUTVV?= =?utf-8?B?N0hkSHl2SlZvOTFCREtCWU5JUXJXUzVsNnIrRUVBWllDcklpSzY2VzhGSElL?= =?utf-8?B?S3VJa25tQS81YW5sTHNxUUhROEppYzJnWWVGUkg5R3FzUXpnMEoyY2t5RWYv?= =?utf-8?B?MTFFZVZmMFlYNWtzM2tPWjFjYlpQcE96TUJJTWFnbGVvbjhnUm9Ta01uTHZn?= =?utf-8?B?ZFFnbFR2ZzgwNjZhMTI0bVNqZVI0Q0hFaGFNVy81bVhNSmNublBoRFlkZ09B?= =?utf-8?B?QTdjaG94clhCdFYxMTJYN0MzZ09Sbm44Y1hERW1ydnQvNHJDOXc5MmorN2Zp?= =?utf-8?B?dHh3RXZOMlZYcmZQN1ZvL2dnK3daWEFNbGVOWSs5Qy9ROWtkcGF3a0pkZkZJ?= =?utf-8?B?NVJjY3krSDhDSDB2VU0rTm52Sm56dWlEbmJMcUltOWMraTRXRUFwajFPZ0xB?= =?utf-8?B?S2lOc09uejllS2pQa3hCSGpNK2QvNWE5OS9JOEVEYVhrWkFxRkRqT0xVNU1P?= =?utf-8?B?bjQ3TlB6YWlWc3ZyQU90dytPSVB0UDFGTXBNay9WQUxyZEdhdWhRNjMxQnZv?= =?utf-8?B?RnZvL1IyTkZzbDhSQjlDRmFvT2pobDdGTVMrNUpkdDMvcDR4R0lBd3UwcTR2?= =?utf-8?B?NjNXVnpsQ3ErRkhJdys2Si85dmptWm1SaDVudXg3T3ZaWHRHU3I2dm40dXJm?= =?utf-8?B?RWZmYVphNk1BeTc0QUk3Q0RZdE1xQVRVRnJoYWkrT2JQbVo2ZnhuMFFEN3Rw?= =?utf-8?B?K0tyT0FGa3ViamJuR2o2YzlQT01HVnR1MzcyRlhuYU1McFhHVzlCdnF0ZS9I?= =?utf-8?B?UnlydDR3UmROZGVXZDVKNTdWKzROZ05xbCtYZVZHRXRqMFZHeUp5YmhJYllF?= =?utf-8?B?Unc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9990f081-3f4c-4163-de97-08da9b1417d3 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:26:22.9164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u+CMwe25+5wb31Yf7is0PczDHiKdXCWB0NXNCeiE7kjCWBEkG3Fiodn0jxi+t+ns24uvJ68Rwd7+3Oj0hzTJEOenlv+JficksCIt8IPHumU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5390 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-20_06,2022-09-20_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209200085 X-Proofpoint-GUID: X-FfGq7hWBW4Nk40Kv0PVn6l3s02rbdO X-Proofpoint-ORIG-GUID: X-FfGq7hWBW4Nk40Kv0PVn6l3s02rbdO On 9/20/22 4:01 AM, Jan Beulich wrote: > On 20.09.2022 00:42, Boris Ostrovsky wrote: >> >> It is saving vpmu data from current pcpu's MSRs for a remote vcpu so @v >> in vmx_find_msr() is not @current: >> >> vpmu_load() >> ... >> prev = per_cpu(last_vcpu, pcpu); >> vpmu_save_force(prev) >> core2_vpmu_save() >> __core2_vpmu_save() >> vmx_read_guest_msr() >> vmx_find_msr() >> >> >> The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder though whether >> this call is needed when code path above is executed (i.e. when we are saving >> remove vcpu) > > How could it not be needed? We need to obtain the guest value. The > thing I don't understand is why this forced saving is necessary, > when context_switch() unconditionally calls vpmu_switch_from(). IIRC the logic is: 1. vcpuA runs on pcpu0 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has not yet called vpmu_load() from pcpu1 3. vcpuB is ready to run on pcpu0, calls vpmu_load() 4. vcpuB discovers that pcpu0's MSRs are still holding values from vcpuA 5. vcpuB calls vpmu_force_save(vcpuA) which stashes pcpu0's MSRs into vcpuA's vpmu context. -boris From xen-devel-bounces@lists.xenproject.org Tue Sep 20 14:30:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 14:30:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409472.652421 (Exim 4.92) (envelope-from ) id 1oaeGu-0003Cq-SG; Tue, 20 Sep 2022 14:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409472.652421; Tue, 20 Sep 2022 14:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaeGu-0003Cj-NY; Tue, 20 Sep 2022 14:30:48 +0000 Received: by outflank-mailman (input) for mailman id 409472; Tue, 20 Sep 2022 14:30:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaeGs-0003Cb-MK for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 14:30:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfd6d07f-38f0-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 16:30:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8032.eurprd04.prod.outlook.com (2603:10a6:102:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 14:30:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 14:30:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfd6d07f-38f0-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxrtoG64rhNzTIKKV6O8lDocGmXcPvSRInrh8zWB6Be+6cj0BDVYpgtm4mdzju0n+H4V4kfnuvzT4FZ1EHo0FSCNlZvkqAliUt96oEhjDWX9YKl0rWZg+hp2ZxmHeYtV6wiFrwLXrI5NawHGBzS8HLzcaD5bPKnie2/X+01z7y373eK0dv6BZenQEV3fWAAaah3ZKMxjHgXs+P5IVOgx2OqWD1q8/oG19LXClbJgtlwiO9rQfHypiuLr9hSpRgXpbqInrOFukT+vusuGxldXfGtGXnfB+TR2QOpvuoc3bECXAWQ3QQpFGC/G12uTX8bmDpPPvyIDiSg+AL05KYeruQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hUWtHTQMBOfiSK/tDeGOWwDkYur51NulFMNRtcE1OJ4=; b=PaCQFiG/SNJYKAqcIp6JOQs1MJP31jTM0bDlpWo3am2tYKb6BCYm1F3VhRuBW3fmJyndJ9gwo5BaNvd7EEbbEairFjQzJ+vCbSpcWWDzmOqIrS1AjKZFJDP0WIeMyvOv4otFDqEF/Zrx+ghNBjq2mSnBGBt/AzetZj5qrpzz2IZ9955ZM0wkWgO9BG8KhtAEPVvV/x6JJSfVbbfyYOk+pgtlMRamGApbr8+fbDYTy2tiD/ISTBgsr+CafebEk4Oet1ff5+OslxSJsU+Sc9ftzReG3jDiaN6ENBvQjBiqSkkyOxxg/wXrAnN1YWOC4hujB8LxUALupBG+ffGpBbDfpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hUWtHTQMBOfiSK/tDeGOWwDkYur51NulFMNRtcE1OJ4=; b=WU7rjbuJtX63BB67zKZCeUhWYzgrOf1D5ENIf0k4SZLOfmUztHlEe0MuYKgPKwUM3NCBJWZkGK3i1I+XoVOUlO6MgAdOBd2NSAUu4cWoXOQCaNS6v0852OtEhgFjZ1cidYs9ssJb4k9eUx4oeazYGtTmItSP40llf4FH6OdS8f+FjSk6YVOUBxxhKhdNxlCeIAknTUFR3c4kjhxyY7NoslCCI2cwNtttUzTHqKS0LN7seoN/AxnQoUTL5YlKEInk1dGifdO00OD2ANRYds3daoxk/w9XWTBy41kHW/G/eHHlewPjA2kvYMk7FIBDC+bKYhP1IyG9yYaaqzDulnBU8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 20 Sep 2022 16:30:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Dario Faggioli , George Dunlap Cc: Andrew Cooper , xen-devel , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl> <20200929151627.GE1482@mail-itl> <20210131021526.GB6354@mail-itl> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0253.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8032:EE_ X-MS-Office365-Filtering-Correlation-Id: a778e3ba-f531-4299-f20a-08da9b14b292 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yiwSaHVsOAOI9a0+GU4pCP5ctoLbSdNYJqWOwGr7BD6iY1uYXgsGVqDYZwlDaB37xNa6Y+kvXdU7AiCWOcAYV/xTHXSwVhjWVTKyzYW7oJpW42roR/FPxJCeBkNRD2/Cp3OVD626YtGfm2GS3gVIxkh5HjbNpCvh3Rb1cafwB1BPgRgvb3bcM2dcWkQb9D9gN0LDKkmErVz7bmwEHTBXTeztW9XLA24tjYj63NetmNUZd4HLJJMz+Q3FJ2BITOMXKt+4rRORSjLj4TR+n5TanGepa7ag6P6YZZo+ZDF5xDbxae2d7vjnOJOFnxi2voLrKQXMqs9cfOeGb15qnPKM4NF1/Oh8SjN6FX31M3PeltQLgRq84Hj66y/Y7Npw7GMYollnODC/1pr/kTUDyynvxTxQxHExBamCdMxH3xVPZM6sZWtgE3XRhz4OtLqCSPMZwJndGzNZ1vJvpjcVlkXgwFwUst/wqI82PffMHked3XGNJ4p3Yf7LfaHxdHWaYMdHBgaQkWEPdBEkJbV21TN5nQ8l9f/BeTmTFpA+XUmfFrhRCS0J1IYBRw+VlCTi3tajyB+3fUOX4OswW6i6HGwEHernCXEGsESBRUESE8fLLAL1vi9mXRXySIPmInsGOaOUym4LhLc8uCULakcgOpDhf7v/eczhyiz0jZQynZVeL1bD+WrdZTsgeVhK3KJmbvYnql7zuXLfeHWDgknHoWa5zWlfhEwpBH1R4Gd+xrPGgWrbLGOJOIE22kdOf7Gz1c6oMckFfXXt0zfUT0jxlVLAaq3JCkAFBa+edBBRofnUMFPemGQn0XYR4i98VSghhvE4CKl6bieAV3ISGHYPPo/B7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(396003)(366004)(376002)(136003)(451199015)(36756003)(31696002)(86362001)(31686004)(66556008)(110136005)(54906003)(83380400001)(966005)(53546011)(316002)(8676002)(38100700002)(6506007)(478600001)(6486002)(6512007)(26005)(4326008)(66946007)(66476007)(41300700001)(107886003)(2616005)(8936002)(2906002)(186003)(5660300002)(66574015)(15650500001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzhjWGFOZXVhelQyNWpYQ0QyYTlhcWJXL2xpeXRxMmtkWWUwTnBhek1KSC96?= =?utf-8?B?MmdadGVCUnMzWGZQeS9sQjFGMGx6ZGY3S1ZNVUdkcG9ROFNPQWF3TDhEaGQ4?= =?utf-8?B?a1huTWdFa1duaXR5VDluYzFxNEFCVUV4b21KRXdGUFlybDJOazY5TXRNQTVj?= =?utf-8?B?ZjQwK25lMXVqcnN3RlRxYTNUUldrYmc1SzVYaktKRTBLT1h2TnVqKy9vdW1K?= =?utf-8?B?TERzYlpVNTlEbHJPcFF5Y0s1c1dQNm1ySDQ1aGFDRUlQajZGN0VBd0doVnl0?= =?utf-8?B?QWo2UDBKN0NCUXQyOEpIZlBzeHZGWW1MODJLWXZQYmpzNkJnVWZLU3pmT0lx?= =?utf-8?B?REhWY0FPK1hNTEp0SktFSnlTdUV3TXVVT2tCNnpaWUJHb25oazk4SkFncnU2?= =?utf-8?B?d2tnNHRMUzNrb3g3U2pPblE2dGgwL3BBSS9UWWZnVEsvSGszQitleG9mcTh4?= =?utf-8?B?ai9BQ003RmpWdE5GZU5yL2VzRnJacllZakZqOUtkeWFwL3ZIVXV1eVFvSWw4?= =?utf-8?B?RHJ5RzFxLzhMRitkVlhSTTRRejhBejl6K1BXQ0dpNy8rYmEzZXpRaVgwR0hL?= =?utf-8?B?N24vdkFsMmhwNjRyM1JYbHVWVjF6dE1QQms0TDJoYXRiWUFGQytSNGtpaW01?= =?utf-8?B?am9sRG0rcG1FVGJEQTU2WkxLb3pkcFNwc3kxTHpYUHhwclowV3l3V2l5aXJi?= =?utf-8?B?dGFoZnNHU1FMZHRFRmdsUjVpc25wckpvSC9FaHYwUWdTcVpicS9HeXN0Qm5Y?= =?utf-8?B?ZEM4b3owZjd5OER5UWFDWmFnQ1VwZmdObjlWNkVqS2loc1R2b1ZTeW5aT3JU?= =?utf-8?B?bnBzditJS3VUaTZJc2RRTXo5YnI0OW1GL1AwY3ZRWHVLbmNLQ1VLZWFxODFG?= =?utf-8?B?MmQzNit3eENLT0VmYWhKMWhXb244bzRxZHVYZHpVMmNRdklIMmNhTUhGUU8x?= =?utf-8?B?Q3hUdW9FcDZHczdqem9kc1o3N2JhVHQvZDl0MWhZQzc4VkZ4clA3UzFCWXFo?= =?utf-8?B?MnU0UlY3S2VXeTQ2SGpwa2lmRW42RHY3cVVmTWxsN3hRS0NjV3FUZmczbWJa?= =?utf-8?B?NFlRcXUwYWZFNWdQcW1wcFRlT2JseGlsTURnM09yMU1weTRhMnJhaWNaNml1?= =?utf-8?B?RkljZVVYRG4reFcydDhSV2xLaFBlOFBIQ3pza0l6bU1qL3IvaC9DNk0xN01S?= =?utf-8?B?MEZNeUN1SlpOUjVPZlA2OVRQNjlleVYyTTJsUERBc0FmRWRxa1BPeGhVZXFG?= =?utf-8?B?Q25nU21HK3RMSmQ0RlNxUG1CNGY5YWdkMjN2YzFDQVVNUXNLNi9udkhZa0J5?= =?utf-8?B?czZwdllWN0tBalpOZWhzL3NtU01xWHk4MUNyRUVGUGp2ZEprZDVMbnVIdVR5?= =?utf-8?B?Y3AvZlJGdlA5cnEwYzZqdzZQTnBBeU12SXhOZUl3bmxhN1dTVC9qYlVHdWhF?= =?utf-8?B?aTB5eGMzcTRob1Q5SDl2NXhBYkhJRjU4VEhKTExSQlVXWGNwL0RMS2lGWUh4?= =?utf-8?B?MHFZc3RkQUNJQmw4ejlJcFFVSlM4a3krSnVMbVg2S2ord0dNZURzRTk1U1Vo?= =?utf-8?B?VUpyampNRVpXWWxaaEliNG5oNzJ0WlZ2ZTJ5TWd3ZU9LQUhvZDBESzZHMTlm?= =?utf-8?B?M2pEWUdIc1pBSTVvbXR4ZzJ3WWx0YUFTemZaVXk2a0NPZUR2YW02QmlseWhF?= =?utf-8?B?WkQwRnVIbHphSUtUZVBHZ3I2WXdUUzlEekxSS1h6OFZJbGtPSmRJa3V6ejZw?= =?utf-8?B?c2FzOVR5S0ZjaHFXMUlnMG5Kc3d4VnZrR1V6QUNkWDBDaVc0c0Y3MWx1dldR?= =?utf-8?B?Q2tkaXJGd3hDMlFTZW1uOUNJNStyM1V4bytSY3JqVmRVK3hzdWhBZmxMUVcx?= =?utf-8?B?Zm92dmltbGFiQ251NkdET1BMMHdPVElIK0s2WDd3MHJCUEJqT09BMnhnZElq?= =?utf-8?B?b0h4cGRwYmhqUDhVTzVINVRRVnNQVXV1ajZXUXc2RldXMnV4MWpReHB4d1VG?= =?utf-8?B?ZUk4d2doekh2S3BNVGJtVVBjTXJiNFpaZFhNcjdreGh4b2swYWR2Y2NYai9O?= =?utf-8?B?aVE5cnV5dTkzWmVFNjk1dlZnV1F6U0UrdFF1T3I3TmlQdFBobWthUGJvNnRE?= =?utf-8?Q?bM7Z0tpHet+hJcMVBOOquxwMt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a778e3ba-f531-4299-f20a-08da9b14b292 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:30:42.5691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p6L8YOsU/V25eH5qWDPLcECeE1iBHFp14bwMJSCihJIyLxaNqb2s2g3jduCqYrVS+vyXzuTx02AkdYcOGQ2lPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8032 On 20.09.2022 12:22, Marek Marczykowski-Górecki wrote: > On Mon, Aug 22, 2022 at 12:00:27PM +0200, Marek Marczykowski-Górecki wrote: >> On Mon, Aug 22, 2022 at 11:53:50AM +0200, Jan Beulich wrote: >>> On 21.08.2022 18:14, Marek Marczykowski-Górecki wrote: >>>> On Sat, Oct 09, 2021 at 06:28:17PM +0200, Marek Marczykowski-Górecki wrote: >>>>> On Sun, Jan 31, 2021 at 03:15:30AM +0100, Marek Marczykowski-Górecki wrote: >>>>>> I'm resurrecting this thread as it was recently mentioned elsewhere. I >>>>>> can still reproduce the issue on the recent staging branch (9dc687f155). >>>>>> >>>>>> It fails after the first resume (not always, but frequent enough to >>>>>> debug it). At least one guest needs to be running - with just (PV) dom0 >>>>>> the crash doesn't happen (at least for the ~8 times in a row I tried). >>>>>> If the first resume works, the second (almost?) always will fail but >>>>>> with a different symptoms - dom0 kernel lockups (at least some of its >>>>>> vcpus). I haven't debugged this one yet at all. >>>>>> >>>>>> Any help will be appreciated, I can apply some debug patches, change >>>>>> configuration etc. >>>>> >>>>> This still happens on 4.14.3. Maybe it is related to freeing percpu >>>>> areas, as it caused other issues with suspend too? Just a thought... >>>> >>>> I have reproduced this on current staging(*). And I can reproduce it >>>> reliably. And also, I got (I believe) closely related crash with credit1 >>>> scheduler. >>>> >>>> (*) It isn't plain staging, it's one with my xhci console patches on >>>> top, including attempt to make it survive S3. I believe the only >>>> relevant part there is sticking set_timer() into console resume path (or >>>> just having a timer with rather short delay registered). The actual tree >>>> at https://github.com/marmarek/xen/tree/master-xue2-debug, including >>>> quite a lot of debug prints and debug hacks. >>>> >>>> Specific crash with credit2: >> >> (XEN) Assertion 'c2rqd(sched_unit_master(unit)) == svc->rqd' failed at common/sched/credit2.c:2274 >> (XEN) ----[ Xen-4.17-unstable x86_64 debug=y Tainted: C ]---- >> (XEN) CPU: 10 >> (XEN) RIP: e008:[] credit2.c#csched2_unit_wake+0x152/0x154 >> (XEN) RFLAGS: 0000000000010083 CONTEXT: hypervisor (d0v0) >> (XEN) rax: ffff830251778230 rbx: ffff830251768cb0 rcx: 00000032111d6000 >> (XEN) rdx: ffff8302515c1eb0 rsi: 0000000000000006 rdi: ffff830251769000 >> (XEN) rbp: ffff8302515cfd90 rsp: ffff8302515cfd70 r8: ffff830251769000 >> (XEN) r9: 0000000000000000 r10: 0000000000000000 r11: 0000000000000000 >> (XEN) r12: ffff830251768dd0 r13: ffff8302515c1d00 r14: 0000000000000006 >> (XEN) r15: ffff82d0405ddb40 cr0: 0000000080050033 cr4: 0000000000372660 >> (XEN) cr3: 000000022f2a1000 cr2: ffff8881012738e0 >> (XEN) fsb: 0000744bf6a0db80 gsb: ffff888255600000 gss: 0000000000000000 >> (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: e010 cs: e008 >> (XEN) Xen code around (credit2.c#csched2_unit_wake+0x152/0x154): >> (XEN) df e8 6f bf ff ff eb ad <0f> 0b f3 0f 1e fa 55 48 89 e5 41 57 41 56 41 55 >> (XEN) Xen stack trace from rsp=ffff8302515cfd70: >> (XEN) ffff83025174b000 ffff830251768cb0 ffff830251778270 ffff82d0405c4298 >> (XEN) ffff8302515cfdd8 ffff82d04024fcb8 0000000000000202 ffff830251778270 >> (XEN) ffff83025174b000 0000000000000001 ffff830251769018 0000000000000000 >> (XEN) 0000000000000000 ffff8302515cfe48 ffff82d04020a8c9 ffff8882556aedc0 >> (XEN) 0000000000000003 00001910537e623e 0000000b988f78a6 0000000059d4a716 >> (XEN) 00001901f30fa41e 0000000217f96af6 0000000000000000 ffff83025174b000 >> (XEN) ffff830251756000 0000000000000002 0000000000000001 ffff8302515cfe70 >> (XEN) ffff82d0402f7968 ffff830251756000 ffff8302515cfef8 0000000000000018 >> (XEN) ffff8302515cfee8 ffff82d0402ec6de 0000000000000000 ffffffff82f157e0 >> (XEN) 0000000000000000 0000000000000000 ffff8302515cfef8 0000000000000000 >> (XEN) 0000000000000000 ffff8302515cffff ffff830251756000 0000000000000000 >> (XEN) 0000000000000000 0000000000000000 0000000000000000 00007cfdaea300e7 >> (XEN) ffff82d0402012bd 0000000000000000 ffffffff82c51120 ffff88810036cf00 >> (XEN) 0000000000000002 000000000001e120 0000000000000002 0000000000000246 >> (XEN) ffffffff82f157e0 0000000000000001 0000000000000000 0000000000000018 >> (XEN) ffffffff81e4a30a 0000000000000000 0000000000000002 0000000000000001 >> (XEN) 0000010000000000 ffffffff81e4a30a 000000000000e033 0000000000000246 >> (XEN) ffffc9004aef7c18 000000000000e02b fb5ee398d214b10c eb5ef398c214a10c >> (XEN) eb56f390c21ca104 ebd6f310c29ca184 0000e0100000000a ffff830251756000 >> (XEN) 0000003211016000 0000000000372660 0000000000000000 80000002963e1002 >> (XEN) Xen call trace: >> (XEN) [] R credit2.c#csched2_unit_wake+0x152/0x154 >> (XEN) [] F vcpu_wake+0xfd/0x267 >> (XEN) [] F common_vcpu_op+0x178/0x5d1 >> (XEN) [] F do_vcpu_op+0x69/0x226 >> (XEN) [] F pv_hypercall+0x575/0x657 >> (XEN) [] F lstar_enter+0x13d/0x150 >> (XEN) >> (XEN) >> (XEN) **************************************** >> (XEN) Panic on CPU 10: >> (XEN) Assertion 'c2rqd(sched_unit_master(unit)) == svc->rqd' failed at common/sched/credit2.c:2274 >> (XEN) **************************************** > > Ok, I think I figured it out! > > I added a function that verifies run queues of all the sched units, and > called it basically every other line on the resume path. The debug > function (if anybody is interested): > > void verify_sched_units(void) > { > struct domain *d; > const struct sched_unit *unit; > > for_each_domain ( d ) > { > for_each_sched_unit ( d, unit ) > { > if ( c2rqd(sched_unit_master(unit)) != csched2_unit(unit)->rqd ) > { > printk(XENLOG_WARNING "d%d sched unit %d: rq=%d, unit master %d, rq=%d\n", > d->domain_id, unit->unit_id, > csched2_unit(unit)->rqd ? csched2_unit(unit)->rqd->id : -1, > sched_unit_master(unit), > c2rqd(sched_unit_master(unit))->id); > WARN_ON(1); > } > } > } > } > > It appears that restore_vcpu_affinity() is responsible, specifically > this part: > > 1216 /* > 1217 * Re-assign the initial processor as after resume we have no > 1218 * guarantee the old processor has come back to life again. > 1219 * > 1220 * Therefore, here, before actually unpausing the domains, we should > 1221 * set v->processor of each of their vCPUs to something that will > 1222 * make sense for the scheduler of the cpupool in which they are in. > 1223 */ > ... > 1249 res = get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu))); > 1250 sched_set_res(unit, res); > 1251 > 1252 spin_unlock_irq(lock); > 1253 > 1254 /* v->processor might have changed, so reacquire the lock. */ > 1255 lock = unit_schedule_lock_irq(unit); > 1256 res = sched_pick_resource(unit_scheduler(unit), unit); > 1257 sched_set_res(unit, res); > 1258 spin_unlock_irq(lock); > 1259 > 1260 if ( old_cpu != sched_unit_master(unit) ) > 1261 sched_move_irqs(unit); > > It calls sched_set_res() directly, which assigns sched resources, but > does _not_ adjust runqueues (if new pcpu happen to be assigned to > another runqueue than the one from previous pcpu). > > I have two (non exclusive) ideas here: > 1. If old_cpu is actually still available, do not move it at all. > 2. Use sched_migrate() instead of sched_set_res(). > > Here is the patch that fixes it for me: > ---8<--- > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index 83455fbde1c8..dcf202d8b307 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -1246,19 +1246,29 @@ void restore_vcpu_affinity(struct domain *d) > } > } > > - res = get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu))); > + /* Prefer old cpu if available. */ > + if ( cpumask_test_cpu(old_cpu, cpumask_scratch_cpu(cpu)) ) > + res = get_sched_res(old_cpu); > + else > + res = get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu))); > sched_set_res(unit, res); > > spin_unlock_irq(lock); > > - /* v->processor might have changed, so reacquire the lock. */ > - lock = unit_schedule_lock_irq(unit); > - res = sched_pick_resource(unit_scheduler(unit), unit); > - sched_set_res(unit, res); > - spin_unlock_irq(lock); > - > + /* > + * If different cpu was chosen, it was random, let scheduler do proper > + * decision. > + */ > if ( old_cpu != sched_unit_master(unit) ) > + { > + /* v->processor might have changed, so reacquire the lock. */ > + lock = unit_schedule_lock_irq(unit); > + res = sched_pick_resource(unit_scheduler(unit), unit); > + sched_migrate(unit_scheduler(unit), unit, res->master_cpu); > + spin_unlock_irq(lock); > + > sched_move_irqs(unit); > + } > } > > rcu_read_unlock(&sched_res_rculock); > ---8<--- > > I have several doubts here: > > 1. If old_cpu is available, is sched_set_res() needed at all? > 2. Should both calls be changed to sched_migrate()? Currently I changed > only the second one, in case scheduler could be confused about > old_cpu not being available anymore. > 3. Are there any extra locking requirements for sched_migrate() at this > stage? The long comment above sched_unit_migrate_start() suggests > there might be, but I'm not sure if that's really the case during > resume. > 4. Related to the above - should thaw_domains() be modified to call > restore_vcpu_affinity() for all domains first, and unpause only > later? That could reduce locking requirements, I guess. All questions primarily to the scheduler maintainers - forwarding accordingly. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 14:54:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 14:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409482.652432 (Exim 4.92) (envelope-from ) id 1oaedm-0005l5-N9; Tue, 20 Sep 2022 14:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409482.652432; Tue, 20 Sep 2022 14:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaedm-0005ky-KO; Tue, 20 Sep 2022 14:54:26 +0000 Received: by outflank-mailman (input) for mailman id 409482; Tue, 20 Sep 2022 14:54:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaedk-0005ks-Nn for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 14:54:24 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00075.outbound.protection.outlook.com [40.107.0.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cbf556c-38f4-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 16:54:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8877.eurprd04.prod.outlook.com (2603:10a6:102:20c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 14:54:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 14:54:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cbf556c-38f4-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FN6fe6fZgaoWMS+LJGKZq6J/biEArqyL91s5ZsFf5dRMGW3l9dfFf62CYyYkjo23RDfLCYBosDtWb2XoCsx0UOADZorB5Qb9w18BqThz5uhtj1v0InvkvhmQGkQXagGEna/v8LS5hSdM6/tcZEhQB9C8aXxLop7PaFd4qJ6BABzgBLZtciZMJH7HrkjNVOSMCyduzh2NlJC6JEYElwOM/ItnothEZbdX49kPiVpuKX3Em4IadRNuM2qpuU6xuXtZOpDujOF9RTQ2tBuCqoyoRw5kfQeZzd23k2OoFwcKkQGeKD32bGlBEEMBfItmfMVNWPV2T1V6ZoBHVXtzvheqcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6G3yEysKcWHvEt7Q1nMK+ZOn5DTuf/Y+ezBhyIf1GT8=; b=M3gJ41A18mvAquCflCmdSYGsnUUVXUkvAe+8MNHCduBSzbIBdJj2lrg8bscSvyQ2r5pr4xJvet/+nxLDSvp/ir7RsrTMCnT0LDyZ62LAisASIz3vMPhuVgno8kNq3hJwDU5PLzxJb/AE/DA+0Kt/PcKGIafK/zsrM8kosqmuk8PB8L27SZiLLWsTUuZgtYrIVqh/3Sz5pk1J9ebAFLWhHiH3V4LLiyk5rxRNSHfpAOuGKG8sWbUGUBMuVeUmulLzMg0qDiFhIpnMXOL1e6oaNnzyyZvjZh08Kc5KqZ6oOSt8lT3R+48MgoNpoXrSy4tsJ/WuBdRiNbSoG7vte2qvDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6G3yEysKcWHvEt7Q1nMK+ZOn5DTuf/Y+ezBhyIf1GT8=; b=JEku5JykSEzfphTWZ9S5trBo+9+WWr9fI2mIaMWnIHdgCUqM7W+LkKM5a3nPX/8cUtaEz0GVaZybdjK3nm2d0+ttMqPlRZKpq4RgCy38G0qf79agnN7kgraywRBi2Rrs0NIFuan2T+oKKTEpWbQUtvhHo1sepuWEcyRLu2dsQvdfV3KB8xUOSGLGDn2JQ58bTyLWshij+9GGdcTFrjgse/Ahv39sp41+kQV40UuU8RyrLj6jJY9CGEB+ah3gyHDdHLfkQ+HVxjfGjKhdnkTvwGy2W15oT0nbWmMsOl0nwoMWruSoM48w/M4P/SllfnymE1Co7zxeFfRA5M9QlGwJsA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 20 Sep 2022 16:54:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Boris Ostrovsky Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel , Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> From: Jan Beulich In-Reply-To: <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0254.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8877:EE_ X-MS-Office365-Filtering-Correlation-Id: 60e819a6-1460-471c-e34b-08da9b17ffc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BS7C8GUXzEQEKPY9JEhL9sNHr1aA4F5iB8watfR4+CyRlU3TjL1s8uPSkFqw5efa4IqM4DIR3p0GR623Dmjp+rN3llpgo2G9S+mTMko+YICpFwK0M897pXYggp9aF/r9egxoO2k8cLaPdjlnJ9KFJcjxuJKK3A98Yd6dnxFOF9i/I5HOpXi4qL+cefph4IXQWoWOmRToAt+m5ojcBg/qccWbs7hPm9Lem0FI/gYEd1l2TK1+qBHAMnj5Or5m/2OpV4LcN1w2cPJoYKXzmofAVIQnShmMrNj0AhjMN2FWZho2mGiNazIKrEKGclquTLKjMtOWFRc5FlaOGfvHgkpCdeHK8UE9KQZMVxNvSguYUZ2IPlpW8XOhbGL4hnOF48WeJ86P8lMJyGQV46+oIBUZHG25Pnc4CzsdvzheHURU7FI5KKHpG5XbcTDKLLMAu8jt6+3bwx32NGfEBZLDNt6f1nz8aXRepuN0k4qtHU37Jnkle4KxZls8Vq54O3I5nFbBG4SoQy1/51SJ+be/hSo24jrkLMog0RlXMu9/cO62MV1SV6yfMi+poyoSQrx0+imFIyr31FQDNURIqxQ5BVAQVc3CEo5xcdrkiwhhgN1xaFwPt4XtIcoFQpLFxm9LMnwC78GOnPA6XM9vb+qtuzvwMcNQ/ZeoK5XWommSqiRFF4QjwNtQ9kAx6AMk+FZ8kqIkd9oZkm0clbXHzOQF3ojifYt+c20N19Kn5WiKHoMPFin3zdioBNbUZAjpdtQPyRnDQ+DD4AUAvGWfgtdPr2ENZiLxrh/yQHypd0IVsOwsUzE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(366004)(136003)(39860400002)(451199015)(31686004)(36756003)(2906002)(54906003)(316002)(8676002)(38100700002)(4326008)(66476007)(5660300002)(66556008)(66946007)(31696002)(6916009)(8936002)(86362001)(186003)(478600001)(2616005)(26005)(6512007)(6506007)(41300700001)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjkwbXd4NTV2ZVN1aE5pQ29mVUQxa3JPWTg0OEpXY0h0a0hjRWdnUkpLcks1?= =?utf-8?B?dFkzdTBMbkZTSWsydjcrc3lwbktDVXpnV1ozRHc0RVRkOUR0aGMzMzh0TFdi?= =?utf-8?B?MXlPOXhLTjdJdEl2WFI1QUZiYUdJZHJxUnZGVFpBelVCQzRjRWFYNmJ0ak0v?= =?utf-8?B?SFRISGtXYklNOHZJRnM0S2tNMTY4WlNwWnBHZjhJN2Voa3Y5dEpJcTU1aFMw?= =?utf-8?B?K3RZSjQyVHI3VlJ1NVRZUWdhTHplVmJ4cEw1K2dRdjFxVk4yTG52K3VsbFUv?= =?utf-8?B?b29rOE9FQ2Y1azFQUVFqN1NkVTFmcStyaytLM2J1TzJIUWlsMmxQTmh4TVg1?= =?utf-8?B?czJ0enVRdG5XZEVsa05uQkVjVnRlc20rd1YyNWMzMUxzWmlGdkZPU0o4TGRP?= =?utf-8?B?TG9KTFBRMi9ZSDkvOWM2ZnpROTlZSFBmbzB1RVJSVFZ2QzdFL01HaUE5dHhh?= =?utf-8?B?OFhBSVNDR2xvbTl1QVJzTzNIWEZlNk9nK3B4VUgxWE1VMHFOWGlLd092bGdC?= =?utf-8?B?dVo0cjFoaG1LMnU5dWE3VXZHYlVNZ0ppTTNBekswOFpCODk1MDNsQ1NrZG1J?= =?utf-8?B?MEdkeGtobXgyclorekVzY3l2djRlOVQzVHFSR3pPTVh6dGZpTGs2d2VoWk1a?= =?utf-8?B?anBoVVJZSjZYamp2RTFubUZoakt3amRxL0dYTUJqUTVwUG9obUp4NktqR3Vr?= =?utf-8?B?bmlZKzJTWU5tOVVKZnVhTmh6T2MzNHZjUFdoK0RtQUlHNzdxc3FxY2E1YUJ4?= =?utf-8?B?b3NENk9IUThoTzFNdk5MRUdSOXprNjZ1b084NVlzS3lnaklaRVpsTHJ1bi84?= =?utf-8?B?elZkbWF5NjFwR0xjcExIYmJDTkh2VkFqVmZlNFRveGVpS3NHMVZ3aGdQdFlN?= =?utf-8?B?L3hUSTBSY2NUcFoyeWhxT1lHd1NVVC84VGpZdkVBR0VqeGJzTENDaVJvZmMz?= =?utf-8?B?dlVhbWpnSC9FcVM5QkFLVlUwazFGcy82Z0w2aTNwLzI5K3hmVVcyV1NsNXZ1?= =?utf-8?B?dTNkeEFMNTI2YWJXUHJyaHBkSnl2bTNCdy9EZHZITHI5Rjdab0txUnVQeTlk?= =?utf-8?B?b2RPTk9vbExueDBTdnV2cGkwaC9uV1Q0V1RJOGhhU1NYc1BVSUkyY0ZZM1pJ?= =?utf-8?B?MXd1b0JGSFFyQm5TS0xKM0p1R1d0cndVbi9QeHZmLzBPeTFZK01wTzR4clAy?= =?utf-8?B?Q3B4ajlpZVlXTzFhZUIzUjZoVndRV1UvOXRwVVhkN2Jmc3NNMmk3dWUyUWZm?= =?utf-8?B?MWxiMFVnQUFIOXZhWnl5am13RTNrcUdObVUxZXBPZW82SVFodE9YWlhFVDNT?= =?utf-8?B?VlVDbjdCb3oyWTFCekgvM3JKTlhEYzl6Mnd5ME5aR3NLaXdEdkQxTUVEQUMy?= =?utf-8?B?eU9FUkp0d3RneThzRnd1MDhKT2FqaEkvdlN1a0RhbHloamVUTEFUeTBJWXV3?= =?utf-8?B?WWJiWS9TaGIzQUlnRGx0Ykh3dUlpa0lodTVhamJ4SU5JcnlpY2FTZDllNmM2?= =?utf-8?B?WDhicXA1WkkvT01uVEhBVkNCa2J2T25aUmJmbVU4elBWN1c2YUhiTU1EY1V2?= =?utf-8?B?SGpZRzRFMXZLN01hUE5RRW50ZTRsSFdlMEEvVzczWGtQbWt6MEFTemtmNG9n?= =?utf-8?B?aWFBcnFnbHRSQ0NZeGJtUUw2cVdHRnM5YThmQUtUckFYYTZKYkJhc2RRUG01?= =?utf-8?B?a3huemVJcnJNNVh3WC85K3RZT3N6WEhtUXdadnF2ZE1yQ1NTRi9TVGY5Vklt?= =?utf-8?B?RXV1Z0pqTTRCdHFwRXU0MGtrM3lMdCtLYjZ6WUJaQ3JSUlNRc0JuMGRPQUFy?= =?utf-8?B?VWQ2bmhEWlNoTGF3REU3UEZFTkxzN2I1ZW5TMjV1akpodzM2WlpNM0xyWUVH?= =?utf-8?B?S2RPYVowUU1INTRGWExadWRkNkQwTU4rWXpqV3RMc0pxSmhRd3V5TDBNdk5E?= =?utf-8?B?T1hmVDY1dXdKLy9rbzN0NVJOTFI5SzlmNGYvRmEycE9hc2YybVFpT0x2K3JP?= =?utf-8?B?b1dBMzdJVWhVYXA2SW0rZmJmS0lwWSs2dkxCVGhVY1ZobjA5MGpVVXU1T3B2?= =?utf-8?B?NWdDUERyTUJzZ3hWb2xOVVRiTlQ5dWtJSytuc1o5aDVOYUIxVWhVbnNnTGRO?= =?utf-8?Q?fPB/30k6Es962hGYeLKvVsjRS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60e819a6-1460-471c-e34b-08da9b17ffc9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:54:20.5726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gPmatO2HdF/eOODYLvdSTjwyhMpUzhFO9oftHuCXurY59mQu0f6dGIcCqBJpqo0Hln0PsSJrBNuntr7EvnPHXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8877 On 20.09.2022 16:26, Boris Ostrovsky wrote: > On 9/20/22 4:01 AM, Jan Beulich wrote: >> On 20.09.2022 00:42, Boris Ostrovsky wrote: >>> It is saving vpmu data from current pcpu's MSRs for a remote vcpu so @v >>> in vmx_find_msr() is not @current: >>> >>> vpmu_load() >>> ... >>> prev = per_cpu(last_vcpu, pcpu); >>> vpmu_save_force(prev) >>> core2_vpmu_save() >>> __core2_vpmu_save() >>> vmx_read_guest_msr() >>> vmx_find_msr() >>> >>> >>> The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder though whether >>> this call is needed when code path above is executed (i.e. when we are saving >>> remove vcpu) >> >> How could it not be needed? We need to obtain the guest value. The >> thing I don't understand is why this forced saving is necessary, >> when context_switch() unconditionally calls vpmu_switch_from(). > > > IIRC the logic is: > > 1. vcpuA runs on pcpu0 > 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has not yet called vpmu_load() from pcpu1 The calling of vpmu_load() shouldn't matter here. What does matter is that vpmu_save() was necessarily called already. Therefore I'm having trouble seeing why ... > 3. vcpuB is ready to run on pcpu0, calls vpmu_load() > 4. vcpuB discovers that pcpu0's MSRs are still holding values from vcpuA > 5. vcpuB calls vpmu_force_save(vcpuA) which stashes pcpu0's MSRs into vcpuA's vpmu context. ... forced saving would be necessary here. What's necessary at this point is only the loading of vcpuB's MSR values. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 15:07:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 15:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409493.652443 (Exim 4.92) (envelope-from ) id 1oaeqS-0007TG-VS; Tue, 20 Sep 2022 15:07:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409493.652443; Tue, 20 Sep 2022 15:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaeqS-0007T9-SZ; Tue, 20 Sep 2022 15:07:32 +0000 Received: by outflank-mailman (input) for mailman id 409493; Tue, 20 Sep 2022 15:07:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaeqS-0007Sw-1p for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 15:07:32 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60040.outbound.protection.outlook.com [40.107.6.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2ecfc2c-38f5-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 17:07:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9275.eurprd04.prod.outlook.com (2603:10a6:10:356::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 15:07:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 15:07:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2ecfc2c-38f5-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcQJZ2nZGwIFja0/hZKWunTk7fDzpl0Q1Xy/PqbfdZrcfpJ0wR+Qhy26tsfP3esQkpN2SWJd62xL3/pHWSQ6xtsAMNbJSsZu9JzrRPdgm93+xWHlZWI7MKTweCwTLSZlbEGfdqceyDa8ePcf/WWogkPjmAqIzEbW6RBEOfgU4PBgZod8auxC3XNgnns4+DPJT/O+GCizK5+85pNiif4T2SyBFbhKSS4Dtk645bN7pcrxVbHhZ52pc/aTiA0LtKncAxMiwoP2uPPO84Gqt3VD3P28yzXny9KOYNFhCDSCLiHFL5fi6sRHS0NMT1r05LcZ0vBj7gLXFTGtdOoROt+ITw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FLQZ1v9tg6/y3zJlbU3z5OIg0nk4F3+Y+hEuVefgAtU=; b=Aoje1JYvo/FgzrvD3tr0THMIBRGGTOCDRcTH8lda8Mt4kc9mHKqbIlyNOv7I+kEHnflkx3isNUiqEFuw5M2mn4qDKH4Szc+u/5YYoIe1j5Qn0snZ2YMpI6phj9Fh9SgcoKO81ejWqmBNlc2VJNKmPMLkoysoTe+X0rssfZ+b4gWyhkvnlyzv+TGzeGentB3ZXE7zsCWO9rG0lwYjqk59dNcuQgcGzfZyWScNz9Jw0uMDC9ESQswErqkUI05hd32682+1IfEsnG7oXsJ/x7H1a9AgKWnuMX9b8fL1iulHQCMNS8Q9yf23l3XAG9Ipox7pbIcIGCO+NVm7udIJELPoGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLQZ1v9tg6/y3zJlbU3z5OIg0nk4F3+Y+hEuVefgAtU=; b=OCip7ltvMSfPImRapVVj3ISagnSOG1y/gX3YLAbD1wPkrg9We7Lc8F1xh7+UPDvADts6+Go+chJy2ehyGM5v19i0j2PH0EKvjW9EV11hBfbpIP6IFK+hhYSZHC7M7PJfw+f38gJ4szCE7y9CmERymB46todxK/nr597HIFJpnTkNmpOmbziNLoMWeXABcspWu4bu3k3uS2Zq5YgL4ZqMgpbR1nSi7SB3RkQTqKYfJ22in8mixyTjQN8E1m2m4nydf/Qa1spHsglwoYkJE8Xq08bNJ5r7tZoSHXjfxpWZIKfrMnmkqOn8C3OH4zNN/K2R0bTNsHjmDz63yp4J9LuzLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5d935f7e-deb5-6fe3-617e-b65c26a99bed@suse.com> Date: Tue, 20 Sep 2022 17:07:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 10/11] drivers/char: suspend handling in XHCI console driver Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <927d01aa54cf6f5291e506179e3d15dc32ebad40.1663383053.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <927d01aa54cf6f5291e506179e3d15dc32ebad40.1663383053.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0265.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9275:EE_ X-MS-Office365-Filtering-Correlation-Id: daf1215d-d64e-4db4-224b-08da9b19d63c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vGcE5nPtcF5Md7DPPR3WXlwiTdezA1gOaIWK5WSpMneLlmIRc5wE/DRqfmIzecHqaxBJq0qY1ueY1zza4bxJ5bbvpDbJgol4oDIqMnZAhG3QgQuvXuRsXW+0jehRYhIqjb36hVyo7EwXLwBbPIh5TfNOUQLUlEofQm5m15abNmOiPjYxOd4LQ1ZlpB2entv9fFYVQlI4jbNWxhCflM5YfDmJiMuvZH+zr4DxUwxM1q68KRjviPr+ptZEdFbjFO2seljp7htI08a2FJ6/Gt1lZwkTR3BahVpj3AxgOIVuWxdrJu7gX7YeIL8gQpkA1BZf+oXCitMuPXXu1V0G0X8cHqV+sT1OZ+xH5Wha7CqKTJfJw6g3oC/5hX7AGcfmaYM9+PUWMgZ1EO/r82Ym/uCF8UDGM1JpDG5ZS2cIcV5+hxgUvtctGdwYyfoio82YWqML+LKMi8HutkGlfC4vJf84B+ATfw5aI1L2UN0Alu2jUBehe8OJOsI6VjyEvdl4OL03F+w37FqzI3w7/zyMi74RYNq4k5BIW1iqbMsBNKsd58BNPWUeY2wi2uI7p4OAMDdzFM8yhrktCkRgEgEOJ59pKiUMr0q0mgWeCzxRRusBW2aO4Vh7kwlaLJLjToA0DJMmyWGDdyRvygbN0xrG3sBsEbFPC4IiCH+WCzNV/VnpIDRrH7oGSM0d1wmLPCIOnUZ7dJ3B0ka5CerAHD8nC15wTaRAtRDyZ6U679/o9ZiyAeS03HhYT7FRQKIfXBAU/8C2ncmIdciRd2Kmkvknqi5dajq+dlKuQ2wXUUFUNs6KmLA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(346002)(39850400004)(366004)(451199015)(6506007)(53546011)(31696002)(86362001)(41300700001)(4326008)(8676002)(8936002)(26005)(66476007)(66556008)(6486002)(478600001)(36756003)(66946007)(6916009)(54906003)(316002)(186003)(2906002)(15650500001)(2616005)(66574015)(5660300002)(6512007)(83380400001)(38100700002)(4744005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXN4YVRWUlFIc0lpOFJzYTJLaDRFRm8rVWdXblpYSHBzYXFRUFA5NE5XRVhz?= =?utf-8?B?VWQxMXQ5d0FSakl0TkJ5NElQalVRVnNRVUJpdEs2a0YxSXgxK012dDhzdXJF?= =?utf-8?B?V0VEbG5CZ2UrWlNIMUs1ZitIR2NadHd1VWUyUGJMaVVUWGNrWHRwWU9mdjNI?= =?utf-8?B?UXlsajV0ZWR3dG8yR2dzdlJmRENGOEdaT3VxR0N0UFp5L3NjZFJBM29ydTBt?= =?utf-8?B?WlREbWpMRmZBcG1jWUozbHd1SHNJRlJWSFptYmpLOWZRUEwxMzEzcUVuVTRU?= =?utf-8?B?czZ3RW5ESE9nVEtaeE84dHBiUDZtd1I1dnJkd0gwaUF2ZmdvUzZjVUdqZjI3?= =?utf-8?B?M0hIeEtEUitKZlB4eURkYlM3S29QektLUVIwdHJCejB4V2Yyb3NkcjJSNXJu?= =?utf-8?B?NzJicXR1UTBWVDIwcm03dXhOSW1UdmVzc3BNZE96Tm1PUVp4VURaMS9pSkpP?= =?utf-8?B?cTZxdjkzYlNDbUp5V2k0T2dxZmtiTDQyYTA0TVVBdUgzL25BamxVRGM4ZC9w?= =?utf-8?B?Um85dVBSUEZ5WHdBdXZ4YU5IMFZKQXpOa05vN2ZTckJrVVMrTVM4dzNqZkVo?= =?utf-8?B?QU02ZHh6dGNwQ2lHdzV1cmtBU1dBQ1Z3ZFpyMHJreFdwYzlBR0U4RHgyUFdV?= =?utf-8?B?c0huZExkYi9qY3RianJyeWRGTWxVVU53QzR2STEwNFByYS9DaU5lSEtRdTA0?= =?utf-8?B?VnoyL1hZVldqV01vdWo3Z2FiSkRDOWFjaEd0R1ZVbXBhaGF5U0ZFODJCdURu?= =?utf-8?B?ZVNKZEo1ejNLd3hyR3ZYWFNOOCs2NW5EN0pUOS8xMEM5cFJoTlMrek5uKzRy?= =?utf-8?B?ZzR0eDQ5cXR3ZDZkWjJZQ0o2TkhuRGg0RkN0MjE5Ly8ybmJoOVVEdFhGZjJo?= =?utf-8?B?YVU4dDZLSUd0QkQyc05ITktZWUlZZkJTbFh5d3BzWDlzejYvK29UOHFjcUs3?= =?utf-8?B?dk1XckFXczZDWDRaSUFXYTFPRXlCS2Y2WE5PQVhQVldEMTB1MUZlZkxBUjg4?= =?utf-8?B?ZWxnWlBRSzdhVXEyM3J5OU5WSFVpUjFYUmlRSTVZWkVBSFlpU1J1ZUdxeEZ0?= =?utf-8?B?Wis3U2FzbW1jeVBLMFM2VXdYeDdSOS9IcjVoaEtySDBnNEd1Nk9PdDV6SS9F?= =?utf-8?B?K2dNTi9yMFR3TDg4N2lWUjBqSHUxM0t0cmZZTkFLWTBuN1pzblRHTHJPNzhY?= =?utf-8?B?aTZiSzIrdDYrRnNpOThuclN6eElUUVQ0SzBhWVF0eis3NVpYWjVycW41THlz?= =?utf-8?B?WE5KN3c0MDk4SVRMY3A2a2w0THdQbDZHSElLbGhuTG1URFVkTjdYbVZDbXp5?= =?utf-8?B?OStmMko5UjNjdVAwb3Z1L3JLZ2ZZZkRKSGhNQnhKSUtVOGZqbDhEdWxLMlFT?= =?utf-8?B?NmcwcDU1SGRweVhMY2p0ekpGTUZLU3BQMDVGS1B4R0JrS2MzVXVQaU1RV2hn?= =?utf-8?B?dmtqWHdHN2k5RzhVTm5rQUpETTIvNkwvTEcxOWxZWm9hYjg2dDVCUHBjYUlG?= =?utf-8?B?Q2cxbDRnT0ErdisybSt5dnpzc1Vna2h6aWplSndvcC9veHFTSjZjNmZBNlJT?= =?utf-8?B?NFZRWGppUExUZmgvZ3lvOGV0SThoNzd4TzQ4ZFE0YzdBVkFlSEs3U0ZWcjNB?= =?utf-8?B?NlN3YVRpUDl3TFJyY0RxK3dHWk5jdWM2K3Q0VkxzQ1poNGIyUlZ5dkFsS3Vy?= =?utf-8?B?bUJrcFRmOXBqaHoyc3FNT0k0NHk3TlBwemZBcUFFTjJtZEpVWTJTTlBkZDJn?= =?utf-8?B?SWQwMTd1MnFkdHZhTFRXNkZMdXhtVG1hM3dUc3Z6dHNRNW5KMklPTHh6a0d0?= =?utf-8?B?YTc5MnJJQkI1a2h0VkpsYUZ2MzhsR1JxRXM2U05UY3NheklFZm5CRXBmR24y?= =?utf-8?B?WGRza1VyZ2lGenNlMklncFRwRklyQnl6VmlqZWtPSEFEamdDUVBUQ0FrQW12?= =?utf-8?B?VktVTlR6eGVoVDh6aE5nSHFjWkhHcXJlek9xcG9WckZPWVhiTWYzSkdoSFJh?= =?utf-8?B?OGpRQUphdGZFcHlvQzZveFlScUVOTmhlNGFxY3d3Ym5DRlA1ZDJkY04zMTMw?= =?utf-8?B?ZnRldmlTbHJXZTFURDc5T0RtMFhJMm9LMndkRzZTV041WGxXMXg1OVNLVVBE?= =?utf-8?Q?/jTOxK0ynJsNngWf134apS1X3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: daf1215d-d64e-4db4-224b-08da9b19d63c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 15:07:29.8661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WDj+c/lFvxWxZaZoj8rSXsBF4UdgIiD7dREd1DHxU2idrSBdMG1pQq9NrqtWFLZksEddUBmJstwf884TvLbSMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9275 On 17.09.2022 04:51, Marek Marczykowski-Górecki wrote: > @@ -259,6 +259,9 @@ struct dbc { > bool open; > enum xhci_share share; > unsigned int xhc_num; /* look for n-th xhc */ > + /* state saved across suspend */ > + bool suspended; > + uint16_t pci_cr; > }; While perhaps of limited relevance right here, may I nevertheless suggest to move the new boolean next to the other one in context. That's both to avoid setting a bad precedent (of not using available padding slots for data like this) and because imo the comment also isn't really applicable to this field (but just the other one you add). Preferably with that adjustment Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 15:30:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 15:30:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409499.652454 (Exim 4.92) (envelope-from ) id 1oafCV-0002IW-QT; Tue, 20 Sep 2022 15:30:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409499.652454; Tue, 20 Sep 2022 15:30:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafCV-0002IP-NQ; Tue, 20 Sep 2022 15:30:19 +0000 Received: by outflank-mailman (input) for mailman id 409499; Tue, 20 Sep 2022 15:30:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafCU-0002IJ-Lz for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 15:30:18 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2075b8f3-38f9-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 17:30:16 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF3E0624D3; Tue, 20 Sep 2022 15:30:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 2AFA4C433D7; Tue, 20 Sep 2022 15:30:15 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0DFD2C43141; Tue, 20 Sep 2022 15:30:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2075b8f3-38f9-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663687815; bh=u8b9rFag8HvBLkzSKSlnITX0Fthy1PSwDeevbk+7Ih4=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Wv2A3hCljL78Mn2NYzvIFrw9A4ehX3G7TfFkid/oqS+Rz+F5tVa6MCDXRJAiqhZSn CUAVHOZuMxQ3ntLTQhIRtdmtc8ZQ18hjMVxIUL83Dco9Xsv2XZ32GFMRZBkwVl8E5l VnhL9AU1S132vwPSvAP2kfEDHAvhyHyjGBmqqtJVWsrMJqZx4HvZ8S6I0WvzEZO7sT JmKw4kECqAVrYS1PcF2uRudroCQozcJJM2RzJ34/gfuOuUHTqAtFvt5geLFWRApGPb sQtZR+66TVKbk+0hPelpetqVUngXVHpdOBTJG+hKyK8KQoL5czx7U7hiaJngCvwOJV aeMk/7tlRlvmw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH -next] xen-netfront: make bounce_skb static From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166368781505.4996.17092116189421621484.git-patchwork-notify@kernel.org> Date: Tue, 20 Sep 2022 15:30:15 +0000 References: <20220914064339.49841-1-ruanjinjie@huawei.com> In-Reply-To: <20220914064339.49841-1-ruanjinjie@huawei.com> To: Ruan Jinjie Cc: jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 14 Sep 2022 14:43:39 +0800 you wrote: > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > ./drivers/net/xen-netfront.c:676:16: warning: symbol 'bounce_skb' was not declared. Should it be static? > > Signed-off-by: ruanjinjie > > [...] Here is the summary with links: - [-next] xen-netfront: make bounce_skb static https://git.kernel.org/netdev/net-next/c/53ff25170980 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Tue Sep 20 15:36:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 15:36:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409504.652465 (Exim 4.92) (envelope-from ) id 1oafIp-00030I-Hc; Tue, 20 Sep 2022 15:36:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409504.652465; Tue, 20 Sep 2022 15:36:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafIp-00030B-ED; Tue, 20 Sep 2022 15:36:51 +0000 Received: by outflank-mailman (input) for mailman id 409504; Tue, 20 Sep 2022 15:36:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafIn-000305-RF for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 15:36:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09d4a4e2-38fa-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 17:36:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 103C262343 for ; Tue, 20 Sep 2022 15:36:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74E80C4347C for ; Tue, 20 Sep 2022 15:36:46 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id p5so3426980ljc.13 for ; Tue, 20 Sep 2022 08:36:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09d4a4e2-38fa-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663688206; bh=D4fI20wsDZU6cBnEMfE+TOOp7Qrzm1qKp2H/6FoR1lw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RFTGMek09d+aDdEKwQI5h9B9rUkfk1jaIjyoKzeykvjmwn5OmC3Ab3M4BIHr+Zftn hwQQXrOg06GmITriVcjkYKVYtZ/wedGGgOzbCwzUDOpF8QCEs8oupwqCKtMnOvy10W GqCyYJ0iRjyJSk8IGuD5QNUBcXSYPHcjPuAtSVFCwmcX5XKtUjNe7lhNOx2HCyne2B q9P2brJEWnSui/jrnLDBiiOY0QcQAB+emVwJWzLOHjgN0rNE9ubiA3vT1tBSWjv3Db ktoHwtI+ZlmizOqxe4jujhPf9vXL8So3/bdagy34nv4Yb7UL+yrJXLZR+z3Tq8z3gN 9O0U98xNH7QPA== X-Gm-Message-State: ACrzQf07/6PSgravGSHWQb0JERYqMyO2kgJoLAcisxkt8eyeuvbgjYqd wwlNVbsrrR274I5z1AECZ2tccWmOFCVAQBz9WEM= X-Google-Smtp-Source: AMsMyM48yyP2Hqwk6bUrxTHAQc4fBFlYjN+MCHW44sVapUcWvHsLb4wIHHgjlbB4nlnT1A6045csLq04qR0dn0WWsCw= X-Received: by 2002:a2e:2d0a:0:b0:26c:a1c:cdf with SMTP id t10-20020a2e2d0a000000b0026c0a1c0cdfmr7905440ljt.352.1663688204337; Tue, 20 Sep 2022 08:36:44 -0700 (PDT) MIME-Version: 1.0 References: <20220919193257.2031-1-demi@invisiblethingslab.com> In-Reply-To: <20220919193257.2031-1-demi@invisiblethingslab.com> From: Ard Biesheuvel Date: Tue, 20 Sep 2022 17:36:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Hello Demi, On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour wrote: > > fwupd requires access to the EFI System Resource Table (ESRT) to > discover which firmware can be updated by the OS. Currently, Linux does > not expose the ESRT when running as a Xen dom0. Therefore, it is not > possible to use fwupd in a Xen dom0, which is a serious problem for e.g. > Qubes OS. > > Before Xen 4.16, this was not fixable due to hypervisor limitations. > The UEFI specification requires the ESRT to be in EfiBootServicesData > memory, which Xen will use for whatever purposes it likes. Therefore, > Linux cannot safely access the ESRT, as Xen may have overwritten it. > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData > memory, Xen allocates some memory of type EfiRuntimeServicesData, copies > the ESRT to it, and finally replaces the ESRT pointer with a pointer to > the copy. Since Xen will not clobber EfiRuntimeServicesData memory, > this ensures that the ESRT can safely be accessed by the OS. It is safe > to access the ESRT under Xen if, and only if, it is in memory of type > EfiRuntimeServicesData. > Thanks for the elaborate explanation. This is really helpful. So here, you are explaining that the only way for Xen to prevent itself from potentially clobbering the ESRT is by creating a completely new allocation? What about other assets that may be passed via EFI boot services data regions? So first of all, EfiRuntimeServicesData has a special purpose: it is used to carry data that is part of the EFI runtime service implementations themselves. Therefore, it has to be mapped into the EFI page tables by the OS kernel, and carved out of the linear map (to prevent inadvertent access with mismatched attributes). So unless you are writing the code that backs GetVariable() or SetVariable(), there are never good reasons to use EfiRuntimeServicesData. If you want to use a memory type that is suitable for firmware tables that are intended for consumption by the OS only (and not by the runtime services themselves), you might consider EfiAcpiReclaimMemory. TBH I still don't think this is a scalable approach. There are other configuration tables that may be passed in EFI boot services memory, and MS especially were pushing back in the UEFI forum on adding table types that were passed in anything other the EfiBootServicesData. > When running as a Xen dom0, check if the ESRT is in memory of type > EfiRuntimeServicesData, and if it is, parse it as if not running under > Xen. This allows programs such as fwupd which require the ESRT to run > under Xen, and so makes fwupd support in Qubes OS possible. > > Signed-off-by: Demi Marie Obenour > --- > Changes since v2: > > - Massively updated commit message. > - Fetch the ESRT inline in drivers/firmware/efi/esrt.c, instead of using > a single-use helper in drivers/xen/efi.c. > > Changes since v1: > > - Use a different type (struct xen_efi_mem_info) for memory information > provided by Xen, as Xen reports it in a different way than the > standard Linux functions do. > > drivers/firmware/efi/esrt.c | 71 ++++++++++++++++++++++++++++++------- > 1 file changed, 58 insertions(+), 13 deletions(-) > > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > index 2a2f52b017e736dd995c69e8aeb5fbd7761732e5..378bf2ea770ad3bd747345a89258216919eb21bb 100644 > --- a/drivers/firmware/efi/esrt.c > +++ b/drivers/firmware/efi/esrt.c > @@ -28,6 +28,11 @@ > #include > #include > > +#ifdef CONFIG_XEN_EFI > +#include > +#include > +#endif > + > struct efi_system_resource_entry_v1 { > efi_guid_t fw_class; > u32 fw_type; > @@ -243,27 +248,67 @@ void __init efi_esrt_init(void) > void *va; > struct efi_system_resource_table tmpesrt; > size_t size, max, entry_size, entries_size; > - efi_memory_desc_t md; > - int rc; > phys_addr_t end; > - > - if (!efi_enabled(EFI_MEMMAP)) > - return; > + uint32_t type; > > pr_debug("esrt-init: loading.\n"); > if (!esrt_table_exists()) > return; > > - rc = efi_mem_desc_lookup(efi.esrt, &md); > - if (rc < 0 || > - (!(md.attribute & EFI_MEMORY_RUNTIME) && > - md.type != EFI_BOOT_SERVICES_DATA && > - md.type != EFI_RUNTIME_SERVICES_DATA)) { > - pr_warn("ESRT header is not in the memory map.\n"); > + if (efi_enabled(EFI_MEMMAP)) { > + efi_memory_desc_t md; > + > + if (efi_mem_desc_lookup(efi.esrt, &md) < 0 || > + (!(md.attribute & EFI_MEMORY_RUNTIME) && > + md.type != EFI_BOOT_SERVICES_DATA && > + md.type != EFI_RUNTIME_SERVICES_DATA)) { > + pr_warn("ESRT header is not in the memory map.\n"); > + return; > + } > + > + type = md.type; > + max = efi_mem_desc_end(&md); > +#ifdef CONFIG_XEN_EFI > + } else if (efi_enabled(EFI_PARAVIRT)) { > + static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, > + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); > + > + struct xen_platform_op op = { > + .cmd = XENPF_firmware_info, > + .u.firmware_info = { > + .type = XEN_FW_EFI_INFO, > + .index = XEN_FW_EFI_MEM_INFO, > + .u.efi_info.mem.addr = efi.esrt, > + .u.efi_info.mem.size = ((u64)-1ULL) - efi.esrt, > + } > + }; > + union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info; > + int rc = HYPERVISOR_platform_op(&op); > + > + if (rc) { > + pr_warn("Failed to lookup ESRT header %lu in Xen memory map: error %d\n", > + efi.esrt, rc); > + return; > + } > + type = info->mem.type; > + max = info->mem.addr + info->mem.size; > + > + /* > + * Recent Xen versions relocate the ESRT to memory of type > + * EfiRuntimeServicesData, which Xen will not reuse. If the ESRT > + * is not in EfiRuntimeServicesData memory, it has not been reserved > + * by Xen and might be allocated to other guests, so it cannot > + * safely be used. > + */ > + if (type != EFI_RUNTIME_SERVICES_DATA) { > + pr_warn("Xen did not reserve ESRT, ignoring it\n"); > + return; > + } > +#endif I am really not happy with this. You are adding a special case specific to Xen to double check that it has violated the EFI spec as required. Even if some firmwares exist that do the same, codifying it like this on mainline Linux code is not something I am comfortable accepting. I take it that this also means that ESRT on dom0 is currently just broken, right? > + } else { > return; > } > > - max = efi_mem_desc_end(&md); > if (max < efi.esrt) { > pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n", > (void *)efi.esrt, (void *)max); > @@ -333,7 +378,7 @@ void __init efi_esrt_init(void) > > end = esrt_data + size; > pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end); > - if (md.type == EFI_BOOT_SERVICES_DATA) > + if (type == EFI_BOOT_SERVICES_DATA) > efi_mem_reserve(esrt_data, esrt_data_size); > > pr_debug("esrt-init: loaded.\n"); > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 20 15:37:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 15:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409508.652475 (Exim 4.92) (envelope-from ) id 1oafJP-0003WS-QM; Tue, 20 Sep 2022 15:37:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409508.652475; Tue, 20 Sep 2022 15:37:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafJP-0003WL-Nd; Tue, 20 Sep 2022 15:37:27 +0000 Received: by outflank-mailman (input) for mailman id 409508; Tue, 20 Sep 2022 15:37:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafJO-0003TC-7N for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 15:37:26 +0000 Received: from mail.ilande.co.uk (mail.ilande.co.uk [2001:41c9:1:41f::167]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f92ac71-38fa-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 17:37:25 +0200 (CEST) Received: from [2a00:23c4:8ba7:8700:f0a2:2ba9:489e:6915] by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oafGv-000Afu-Ct; Tue, 20 Sep 2022 16:34:53 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f92ac71-38fa-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:MIME-Version:Date:Message-ID:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DxUS2wc8S5XxDbYIITAjbCY/K9B97p0z/uIdsCi89f4=; b=q8dDxxpdwWDpHEVedTNp99huTl ieOauNOwBFfYBDnKcDBqCHjuV4ahcE1blChUCvnn1ld2RsCLwnoBIq1ubUWjGD1XG+OipNXhMHYV3 A5UVDUPeFztTSqKs6X7P+cnq84CeGwoY32GoPxxVEEcm4T6W++H/W2qq+IUbg08VbaPZn2PpQhA6G bLj5usr33B5oFZ1w1pzMsxXoWw5TqXPu+p5QK2QdWpGZxnhsfad6mIAO4emRZahrJpZli75qhfkPZ JidI8Md/95Pa4BTPf6Cssb8yEiTDu6oS0+mepXs9cZhYwKX0GB+Wh3jWanOFKnNugdGBTJ2negqZ5 kQ5zkM8I3F09Yqn2tNuiF62sq4HjlfBTtNVHH/wu5YepzmsU+yGEiv75Er59M/E1rO+t7vI3zdHhL K6EOXVatICRAGXSZ2pXGTOtCsdntXKmTpLa28j5QBqhUoCSVwaSj/dnxqdkPzCQwQsRXyL4b13OSS pTWzfSYUZ3XA1cZjpzVW7U3+3jDQGahsb6BDRM7yMzynJF79hN3JliPwomVGl3TlmAF9ZXbgB6v8x EdBv3RhbS9nnzMB0fMo8v8PRvu4ZQAqDHvVlI+IWDk4CDXNVEIO08YEfWVoJ8mVf99CP1R3I6tydJ Gl7iS5zTOghPdk9mRJyFsq8Jqasp4a0Y+B74kjNoY=; Message-ID: <49325e7d-5020-23f7-4bce-c53d8d988c95@ilande.co.uk> Date: Tue, 20 Sep 2022 16:36:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Peter Maydell , Bernhard Beschow Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> From: Mark Cave-Ayland In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a00:23c4:8ba7:8700:f0a2:2ba9:489e:6915 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.default.ilande.bv.iomart.io X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) On 20/09/2022 10:55, Peter Maydell wrote: > On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: >> >> In address-spaces.h it can be read that get_system_memory() and >> get_system_io() are temporary interfaces which "should only be used temporarily >> until a proper bus interface is available". This statement certainly extends to >> the address_space_memory and address_space_io singletons. > > This is a long standing "we never really completed a cleanup"... > >> This series attempts >> to stop further proliferation of their use by turning TYPE_SYSTEM_BUS into an >> object-oriented, "proper bus interface" inspired by PCIBus. >> >> While at it, also the main_system_bus singleton is turned into an attribute of >> MachineState. Together, this resolves five singletons in total, making the >> ownership relations much more obvious which helps comprehension. > > ...but I don't think this is the direction we want to go. > Overall the reason that the "system memory" and "system IO" > singletons are weird is that in theory they should not be necessary > at all -- board code should create devices and map them into an > entirely arbitrary MemoryRegion or set of MemoryRegions corresponding > to address space(s) for the CPU and for DMA-capable devices. But we > keep them around because > (a) there is a ton of legacy code that assumes there's only one > address space in the system and this is it > (b) when modelling the kind of board where there really is only > one address space, having the 'system memory' global makes > the APIs for creating and connecting devices a lot simpler > > Retaining the whole-system singleton but shoving it into MachineState > doesn't really change much, IMHO. > > More generally, sysbus is rather weird because it isn't really a > bus. Every device in the system of TYPE_SYS_BUS_DEVICE is "on" > the unique TYPE_SYSTEM_BUS bus, but that doesn't mean they're > all in the same address space or that in real hardware they'd > all be on the same bus. sysbus has essentially degraded into a > hack for having devices get reset. I really really need to make > some time to have another look at reset handling. If we get that > right then I think it's probably possible to collapse the few > things TYPE_SYS_BUS_DEVICE does that TYPE_DEVICE does not down > into TYPE_DEVICE and get rid of sysbus altogether... Following on from one of the discussion points from Alex's KVM Forum BoF session: I think longer term what we need to aim for is for QEMU machines to define their own address spaces, and then bind those address spaces containing memory-mapped devices to one or more CPUs. Once this in place, as Peter notes above it just remains to solve the reset problem and then it becomes possible to eliminate sysbus altogether as everything else can already be managed by qdev/QOM. ATB, Mark. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 15:55:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 15:55:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409519.652487 (Exim 4.92) (envelope-from ) id 1oafaJ-000630-EA; Tue, 20 Sep 2022 15:54:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409519.652487; Tue, 20 Sep 2022 15:54:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafaJ-00062t-A8; Tue, 20 Sep 2022 15:54:55 +0000 Received: by outflank-mailman (input) for mailman id 409519; Tue, 20 Sep 2022 15:54:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafaH-00062n-Qf for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 15:54:53 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9021c30e-38fc-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 17:54:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8251.eurprd04.prod.outlook.com (2603:10a6:10:24f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 15:54:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 15:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9021c30e-38fc-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGrB/c/q6xERibjOQPzcnwvP/OuzsWiW1Upj+j2MrhaDrvAts5ajO1n5eJ8dJKGlHs04/hRjwaSfXEF/J9k3mGHepyzitLkq9SJUhQBK959sd8WLxE8Zd8dydH6m31xVorHxV252BkySlzkjP5a6f7mX1hwdVzMKmxaoih4RLKneAGLYPg8l5b09//y2Dw8GhtSJFOHbapgX1P+clI9bGVKn7MsEkoM9L/m41zbDr8mxxoa9iKq3ZmBoky0t+hNQDIWxoeeHeGd2cnVbcOx5S80TaPPnTWQtjOyihQrd4mPZvEzHiwMrCHkXvuISjaBoJr16LJ27ENy8pGQe3wJhtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VYxFh3csbWKrYwY/oyUVWTvkUEBGLgZw9LoiVS9asAk=; b=CkdlwCG+tWvRcQAVaFnIxH7OdhU4ty2USpEKAMg4e/ystd5iM5oQrMf7GxhxzyD6PakuR7NbrhR8KaIKqrc95B2Qa/HIKm7QHyo4eA/5onpnlopmV/YcmqL00vGSP6HZH0WKVLcvffepJbJDZqv29d11jeZh2ZdheVg32JqIFP/ZOONDncF4jJpK78srd1NlXLonH9DKwjGJZtbrvnJyL20g0q8tk9e43EUmZRtZqUIDyEE9fGJ33SLBfgERzaXy0bnwdEJPwClY7lhv8bsZwsDhaPq2UPDfDHGBq7fVze6nnIz8C3otbPfrMqPuzqvOMns3QWLtlXnGCH18tjsWnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VYxFh3csbWKrYwY/oyUVWTvkUEBGLgZw9LoiVS9asAk=; b=zcP7KgnZ+SdGv9JgohBxIbeSoX/xuh7TGZv3UqH8pU6DDYqFVsjHgbSgdRsb+DG1xYmZ84IA3hK6dgfPv4Vwe0sdKcV49VTB5gv9RVMNIRBQRA3seZGW1WinoUqqxSj3rCmNEARVOwz7V3Z6XmeEUmsyw+wYMHnd/EMu+8qAiMttj4WMVQR+KIT5A5j5MCt0ITNlVYFbOXmVjPmlnKhgfN5G+7CR61cMqruHZsDTKRDTzAdtEWbpys87bO+gtg75+9FGs4M5H4hKoW2owwrnPKseYQ6KLMEsoZXaj1L/0BmpD7xpSbPeXhtJnUvoX6uXQh0VF3UUt9ait1zJEI5ztw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> Date: Tue, 20 Sep 2022 17:54:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Content-Language: en-US To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Demi Marie Obenour References: <20220919193257.2031-1-demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0143.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8251:EE_ X-MS-Office365-Filtering-Correlation-Id: d9b5fb8b-0798-444d-1672-08da9b2072a8 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Eg3ZR6vjg7q+RMbtDt/PYcNu6lltKHnpBKHPdpKu28GgFrzg0MS7N8lUkgptBnR6YiGPg0Pwr985MfrXRSibXPCNrSFsrtKeykidDTwPHGSqireUp2VJ8UVqkQKtf3lZ78Dy8UKqagUgfIjbXKZr/+PDyujvnqBlbqh2AUCPo0Hvm60A3CHEkiSwEQaXJM8ukM7lJOFxVtdbbrAN5PWEQC50aTUGDN2Drvd/p3dlQVsAmpfFUYZowm6SKg+1hFoKXLXwRKGbFpCfbFdjY0ONOsbnzA4swYH9DZf4CzjCuWCEH6zlUbcNItytWmJM6KYru22Cv7gcy4jONjd6XKwq3DCn2V+oqdqx962tOjnGVAg22Jhw9zUJjLN/68Yh7diWvqGV0me2OXXRF3AptkMXQ6mDE5lLEp57MEWl10iCDSQ/p1NjjROam6FmgW+zam2kj+BrR8faevMOKKLFaaKOUOvDrJ88+TXX7MhgbY2Qtt1ps0PXzqPIj6MaRLxKb6sbzJ351TtqOnbzixS6ckP6ZJ3iioRaZX3lHDGf4WrwemBhZOEcd84RGaWihrsj70WYhpcsHi+eHVy2FobHsrRjaa6r6rVgVk6g4DOHldKpi5/T3qSMA+pb6NI9Kqh/UitPgRJiNcjSkgx7SXgub1Jy5u1GF1JlebvgLUwJHedkXKZ90/vwf8tspxA9DBZ36tCw9xtm/yWXnWN5VxBm/7ChZjhP480KQzKVeTiakh1ElrnSy/7oNzBmSu41awa91DxwNBx1EekfJQiz8WpdQaTK9M+6g+p7u5TKXHbZ6qH+avQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(346002)(376002)(451199015)(66476007)(8676002)(2906002)(36756003)(2616005)(38100700002)(66946007)(83380400001)(8936002)(6666004)(41300700001)(54906003)(66556008)(478600001)(186003)(31696002)(6512007)(86362001)(316002)(4326008)(6486002)(6916009)(6506007)(31686004)(53546011)(5660300002)(26005)(66899012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NldpdHYvM0JWZnVmVFJLY2tOOWNtTk4wZ09jM2h3VEJudC9iQUY1bTJmNHFh?= =?utf-8?B?VWtjRlpTYkZwVDd1dUR3THhGOEFDSHRNRlZOczYzTDNxTFZ5QS9UWk1pZHgy?= =?utf-8?B?MDI4RXFxWU9NeWEyVXlYUkxFNFgrQ2ZLZGR4N0FTVmxISFdsdWY4ekNaNG1E?= =?utf-8?B?WHJmVDRDTkdNQmpPaFNFR2FGMlB2RUsySFVWUE1MSVBVdnlvZ2lyNG82UUVG?= =?utf-8?B?eDdUUWVaakhWVUVnRXZ5eGtZWU8zSkhQa2QvL08rMGUzUUZUTjd6RjIwWDdN?= =?utf-8?B?Tm0yTTByVHBQOHduUUtNa1JyVVFjM3lBWDZZejVOT0tlTHk1R1UvTFd5OGYw?= =?utf-8?B?RVFJWnJaZW5VSFY3cURneXgzRlU0bCsrNzBwZUh1cUNZYnlrZkNUNEZCY2g5?= =?utf-8?B?QTdrVVpsbHN0NzRUN2dqY3FFbGgxRWNqb3ZSVndvN2dDRlJ5TElucDdRbExt?= =?utf-8?B?NzFhbE03bEVqWHZGbC9QQTNlUVpGS3hqTm9vQXZpanE1aHYrVTFyd1VBMWJV?= =?utf-8?B?bDg2a1hyK1BQTU1oRk03ckV2ZmNKSmJmRUhLVUNzN2NpdnZxdTNJOW1DR0Jx?= =?utf-8?B?ajhkYUs2d3pXblJ2Q0ZjOVE1MHg3ZjV5TFR5VXBaZEVYVVg2NUZoTjVZN21m?= =?utf-8?B?ZFd1amRZZ1JnSjFPQWcyZTBMZlk5eUxJL2FmYk92Vk9Hd2ZNaWpVSktrNWZp?= =?utf-8?B?ajhzcUhNbnV6L0VITlpISVlwVWg5Rmt3aVZBZHRjdGl4T1hqQ011VnpiSk5H?= =?utf-8?B?Q1pyQzIxNWhzaDJ2Y2lZWmM3eThwOVd5R29QekNJQUozUk5mWVpMT3l4ODFE?= =?utf-8?B?bUZtbno3UHNoVm01VklsRHNpVExIakUzZVBWQUQ1YUMzc3VSa3RScVNWdDhs?= =?utf-8?B?MU1SRGZvY0EvS3Ztd3NPR3Raa0tLRlBoNDR3VGEzNzdWYk9SMUIxVmpWdjFU?= =?utf-8?B?M2VLZTlmRkJLSGo5bkNFRFA4VmZOZmxLQjB6Rmd2VzZwbGJkSWs5bk1FRWlL?= =?utf-8?B?UUhLMkhTK1ZzL09keTdMM0NQdm5VUExBejVzOG5nMlBaS0xnZUJWQmNOamxN?= =?utf-8?B?RHRXc2ZSY0pNSGl1WVppVEZLL1k1bDE4RXk3RUMrcFVZdmV1TktORFV4YWl2?= =?utf-8?B?aXdZd3hiQ1drL2YzbUlsL2xWRTcwTFpJd1ZPeWN5QlZGYy9weWtUejlFamwy?= =?utf-8?B?OWpDNFVUejQwelNrZkJhT3liSjhvQlNoaWZ6a0RzVEJhd3grRVZMaE8yNDJY?= =?utf-8?B?SmVhZmszeVJhZ0puSFlRdUtLUVV5c2F4RDdYNGh3TTlqcW1OVkU2N20xVTQv?= =?utf-8?B?eEZHZ0UrM3c5VW53clAxaGNaUWh3RUptY1lhSmtGdElnK2Nmb0N4SFVRZmh0?= =?utf-8?B?RFc5K1J2QndzSHJqU2pnZm9OakFENy96TmUrQW9RaEYzSWJrR2ZlSjhUVEkx?= =?utf-8?B?L0hTZUNmNktqWVlUU2VzQkVsYS9oYnZIZnJ5U0lDWXpvL2p0RWhzTVNNQitR?= =?utf-8?B?ajljdDJXa1ZRSFhQam5OakZzY0pWVlVOS0Y4MjZuVVMreG5mUmZYbXFBekw5?= =?utf-8?B?ZmpKOC9ORVIxbDU3MllYcWRCd1JTbW1qM2lLWDdBbWVNSUlvcG1jZ1pIbENx?= =?utf-8?B?b2ZjbW9RZnJwUFFPNEFsMkRuRXFqck9JSUdEWHM0QnhkNEI1dVdxUzVkV0VK?= =?utf-8?B?SVVVdXk0VUhxMzV1T3dwYWhJQVdMelc5VzRqR256M3RvVXM3SDZBaFFETkFF?= =?utf-8?B?bENTRGxjeUpIU3dqVWwvWFVCdllESDRWeVVmbVVwQVlHMkdhUlR1VEhpbENj?= =?utf-8?B?V25VOFVOOHJxZ2duRVBvb2FZK1dMeWdPejRMOFZwUThUT3loZ3JEUHBOZCtU?= =?utf-8?B?dG9nakJYc2kweXlTd2lyenhJWW1FU0ZGeUhIY3VuUWxEMXE2VzY3Rkt2QWl6?= =?utf-8?B?Z25MUEJCdE5UUkdvUkVjSkJjMy9lSWtRS2hoTlhma0pLam9QbFlrUWdyV01G?= =?utf-8?B?QXVEWVNEYXBCcGIraTFoOHpmMmNkUWhLSlVLNWExODBVWERWMjA2aDBld0Vw?= =?utf-8?B?Mm5vdjhYWGZFcjlXZUw0UFhMK2txbGFtZEVVcG9MWUx3OGg1MmFsdlN3bSt2?= =?utf-8?Q?j60YHg9NPN1J+L+Bqn76RG0LE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9b5fb8b-0798-444d-1672-08da9b2072a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 15:54:49.3098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9QkCkoQr6QyAG65OrTFgBSPbqTwMVrrqCMJXFHjPwcko1Old0W9k6f+s5Ke6GEgbslTUR2Zv95uCay1/cSY59g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8251 On 20.09.2022 17:36, Ard Biesheuvel wrote: > On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > wrote: >> >> fwupd requires access to the EFI System Resource Table (ESRT) to >> discover which firmware can be updated by the OS. Currently, Linux does >> not expose the ESRT when running as a Xen dom0. Therefore, it is not >> possible to use fwupd in a Xen dom0, which is a serious problem for e.g. >> Qubes OS. >> >> Before Xen 4.16, this was not fixable due to hypervisor limitations. >> The UEFI specification requires the ESRT to be in EfiBootServicesData >> memory, which Xen will use for whatever purposes it likes. Therefore, >> Linux cannot safely access the ESRT, as Xen may have overwritten it. >> >> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData >> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData >> memory, Xen allocates some memory of type EfiRuntimeServicesData, copies >> the ESRT to it, and finally replaces the ESRT pointer with a pointer to >> the copy. Since Xen will not clobber EfiRuntimeServicesData memory, >> this ensures that the ESRT can safely be accessed by the OS. It is safe >> to access the ESRT under Xen if, and only if, it is in memory of type >> EfiRuntimeServicesData. >> > > Thanks for the elaborate explanation. This is really helpful. > > So here, you are explaining that the only way for Xen to prevent > itself from potentially clobbering the ESRT is by creating a > completely new allocation? There are surely other ways, e.g. preserving BootServices* regions alongside RuntimeServices* ones. But as the maintainer of the EFI code in Xen I don't view this as a reasonable approach. > What about other assets that may be passed > via EFI boot services data regions? These would need handling similarly then. > So first of all, EfiRuntimeServicesData has a special purpose: it is > used to carry data that is part of the EFI runtime service > implementations themselves. Therefore, it has to be mapped into the > EFI page tables by the OS kernel, and carved out of the linear map (to > prevent inadvertent access with mismatched attributes). So unless you > are writing the code that backs GetVariable() or SetVariable(), there > are never good reasons to use EfiRuntimeServicesData. That's a rather strict interpretation of the spec. Even back when I started dealing with EFI, when it was still quite new, I know RuntimeServices* was already used for similar purposes. > If you want to use a memory type that is suitable for firmware tables > that are intended for consumption by the OS only (and not by the > runtime services themselves), you might consider EfiAcpiReclaimMemory. Personally I consider this type less appropriate than the one we currently use. It's intended to be used by ACPI, which doesn't come into play here. It comes quite close to using e.g. EfiUnusableMemory here ... We might be able to (ab)use EfiLoaderData for this, but that would again require special casing (inside Xen) when deciding whether the memory can be used as general-purpose memory. > TBH I still don't think this is a scalable approach. There are other > configuration tables that may be passed in EFI boot services memory, > and MS especially were pushing back in the UEFI forum on adding table > types that were passed in anything other the EfiBootServicesData. Within Xen we might abstract the approach currently implemented in case more such pieces of data appear. While I can easily believe MS might be advocating for this model, I view it as problematic not only for Xen. How would you pass on this information across kexec, for example, without introducing further producer-consumer dependencies requiring separate protocols to be followed? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 20 16:10:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 16:10:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409528.652497 (Exim 4.92) (envelope-from ) id 1oafp1-0000a2-Mn; Tue, 20 Sep 2022 16:10:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409528.652497; Tue, 20 Sep 2022 16:10:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafp1-0000Zv-KA; Tue, 20 Sep 2022 16:10:07 +0000 Received: by outflank-mailman (input) for mailman id 409528; Tue, 20 Sep 2022 16:10:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oafp0-0000VN-GD for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 16:10:06 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afdcf945-38fe-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 18:10:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6D8961F7D for ; Tue, 20 Sep 2022 16:10:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17A66C433D6 for ; Tue, 20 Sep 2022 16:10:03 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id p5so3543262ljc.13 for ; Tue, 20 Sep 2022 09:10:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afdcf945-38fe-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663690203; bh=ZNN6ncUcdAz2eSrp+5TLDtDbHWa6EBPbqOwU++0pIM8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dK+52DWq56dL/V2oG40eG/iPjZjgtnJnW0GukYXFh1UdHi3+77Kh4okbkDdGrGy5X aitMWU6ubzNPzFXz3eM/ZgfJPP5cSdjHLAC9hmzCH+kilPt5yOHJ4WMHL6Zf52ksq7 6a6OwmDTD7hkUOhWYOs3AisgAz3OXwQ/bfiDmIhfB6INiCiyY4Wv0uwULl/C704Fzg pc1Ga4/V6YIxD2EWDSXvV8BvQb3GY6qbBmRekTN6qPezGJ7nydgmzYVfHvw1fv9RBX SYymNSal905z5SAhJKTBjFJfyRMbY/NT4rXB/MCvJ3kPrhttHpWOnT73bwGUie7HiN Ijh5dQL7bbVqw== X-Gm-Message-State: ACrzQf3XbamNQ64Gk/JyofYsb6ON+ObRUjxWXhC+amlJjHgcS+F3e8Ub 53wVTCiBd9C2P90TOBp3E+lwzTuMqc3fwGrEgis= X-Google-Smtp-Source: AMsMyM7dTMlqxXVyh1AyPoQQR0QTi9dh4SPvuXEYjqfXORBnB1Nu4cVXsu8mIVxRHgGU3ZkCf49okUpRMugykIZnXig= X-Received: by 2002:a2e:7314:0:b0:26a:ca18:60eb with SMTP id o20-20020a2e7314000000b0026aca1860ebmr6723118ljc.69.1663690201047; Tue, 20 Sep 2022 09:10:01 -0700 (PDT) MIME-Version: 1.0 References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> In-Reply-To: <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> From: Ard Biesheuvel Date: Tue, 20 Sep 2022 18:09:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] Support ESRT in Xen dom0 To: Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Demi Marie Obenour Content-Type: text/plain; charset="UTF-8" On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: > > On 20.09.2022 17:36, Ard Biesheuvel wrote: > > On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > wrote: > >> > >> fwupd requires access to the EFI System Resource Table (ESRT) to > >> discover which firmware can be updated by the OS. Currently, Linux does > >> not expose the ESRT when running as a Xen dom0. Therefore, it is not > >> possible to use fwupd in a Xen dom0, which is a serious problem for e.g. > >> Qubes OS. > >> > >> Before Xen 4.16, this was not fixable due to hypervisor limitations. > >> The UEFI specification requires the ESRT to be in EfiBootServicesData > >> memory, which Xen will use for whatever purposes it likes. Therefore, > >> Linux cannot safely access the ESRT, as Xen may have overwritten it. > >> > >> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData > >> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData > >> memory, Xen allocates some memory of type EfiRuntimeServicesData, copies > >> the ESRT to it, and finally replaces the ESRT pointer with a pointer to > >> the copy. Since Xen will not clobber EfiRuntimeServicesData memory, > >> this ensures that the ESRT can safely be accessed by the OS. It is safe > >> to access the ESRT under Xen if, and only if, it is in memory of type > >> EfiRuntimeServicesData. > >> > > > > Thanks for the elaborate explanation. This is really helpful. > > > > So here, you are explaining that the only way for Xen to prevent > > itself from potentially clobbering the ESRT is by creating a > > completely new allocation? > > There are surely other ways, e.g. preserving BootServices* regions > alongside RuntimeServices* ones. But as the maintainer of the EFI > code in Xen I don't view this as a reasonable approach. > Why not? > > What about other assets that may be passed > > via EFI boot services data regions? > > These would need handling similarly then. > > > So first of all, EfiRuntimeServicesData has a special purpose: it is > > used to carry data that is part of the EFI runtime service > > implementations themselves. Therefore, it has to be mapped into the > > EFI page tables by the OS kernel, and carved out of the linear map (to > > prevent inadvertent access with mismatched attributes). So unless you > > are writing the code that backs GetVariable() or SetVariable(), there > > are never good reasons to use EfiRuntimeServicesData. > > That's a rather strict interpretation of the spec. Even back when > I started dealing with EFI, when it was still quite new, I know > RuntimeServices* was already used for similar purposes. > I'm not saying it is never used inappropriately. But using a memory type that gets mapped into the runtime services page tables every time a runtime service call is made is pointless, fragments both the EFI page tables as well as the kernel direct map for no reason. > > If you want to use a memory type that is suitable for firmware tables > > that are intended for consumption by the OS only (and not by the > > runtime services themselves), you might consider EfiAcpiReclaimMemory. > > Personally I consider this type less appropriate than the one we > currently use. It's intended to be used by ACPI, which doesn't > come into play here. In spite of the name, that is not really true. It is reclaimable memory, which means that the OS can use the memory as conventional memory after consuming its contents, or discarding them. > It comes quite close to using e.g. > EfiUnusableMemory here ... No, that is something completely different. Using unusable memory for anything would be silly. > We might be able to (ab)use > EfiLoaderData for this, but that would again require special > casing (inside Xen) when deciding whether the memory can be used > as general-purpose memory. > EFI loader data and EFI boot services data are the exact same thing from this POV. They have no significance to the runtime firmware, and can be used as ordinary available memory after ExitBootServices(). > > TBH I still don't think this is a scalable approach. There are other > > configuration tables that may be passed in EFI boot services memory, > > and MS especially were pushing back in the UEFI forum on adding table > > types that were passed in anything other the EfiBootServicesData. > > Within Xen we might abstract the approach currently implemented in > case more such pieces of data appear. > > While I can easily believe MS might be advocating for this model, > I view it as problematic not only for Xen. How would you pass on > this information across kexec, for example, without introducing > further producer-consumer dependencies requiring separate protocols > to be followed? > In this case, I don't think this is unreasonable for configuration tables, which only have a GUID and a base address. If the OS knows the GUID, and knows how to interpret the contents, it can decide for itself whether or not to preserve it. If it doesn't know the GUID, the memory is just treated as available memory [after EBS()] I personally think reclaimable memory is more suitable for these cases, which is why I am willing to consider that as well. Note that the EFI spec now also mandates device trees on ARM to be passed via EfiAcpiReclaimMemory, simply because it is the memory type suitable for firmware tables that only the OS consumes. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 17:22:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 17:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409539.652509 (Exim 4.92) (envelope-from ) id 1oagwL-0007tG-3Y; Tue, 20 Sep 2022 17:21:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409539.652509; Tue, 20 Sep 2022 17:21:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oagwK-0007t9-Vm; Tue, 20 Sep 2022 17:21:44 +0000 Received: by outflank-mailman (input) for mailman id 409539; Tue, 20 Sep 2022 17:21:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oagwK-0007sz-G3; Tue, 20 Sep 2022 17:21:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oagwK-0007nu-Ca; Tue, 20 Sep 2022 17:21:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oagwJ-0006LU-RZ; Tue, 20 Sep 2022 17:21:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oagwJ-0001r1-R3; Tue, 20 Sep 2022 17:21:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZDav3pB4NfP9TKkU9z+3p6h4kYppbL7NurnRbMlnlqc=; b=zyksN54gWUsdIOw1vbbiyEymaT 1jRaszEITXhrWF9U36W0Azt2VHSS5Pic7pCgdn6Pp7SN7W8Swd7EXb1YB3etqtJTv6Xc4LjTJGa+1 iQ4yXW1HYkc66D8UgCe+F4IyIZ3HsXaJH6a7OZTvJ1RU5zLqfXMebAiZcAvexE8EFXxY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173260: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9f02aa34e179d1b0185a27980dd5bafd0f2e6e59 X-Osstest-Versions-That: linux=7e17397001a93541ffefdef553a3d541f9c1c8f8 From: osstest service owner Date: Tue, 20 Sep 2022 17:21:43 +0000 flight 173260 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173260/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 14 guest-start fail like 173235 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 173248 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173251 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173251 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173251 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173251 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173251 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173251 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173251 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173251 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173251 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173251 test-armhf-armhf-xl-credit1 14 guest-start fail like 173251 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173251 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173251 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173251 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 9f02aa34e179d1b0185a27980dd5bafd0f2e6e59 baseline version: linux 7e17397001a93541ffefdef553a3d541f9c1c8f8 Last test of basis 173251 2022-09-17 17:43:01 Z 2 days Testing same since 173260 2022-09-20 10:44:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Arnd Bergmann Brian Norris Christoph Hellwig Dmitry Torokhov Enguerrand de Ribaucourt Even Xu Florian Fainelli Greg Kroah-Hartman Greg Tulli Guenter Roeck Hans de Goede Hu Xiaoying Jakub Kicinski Jann Horn Jason Wang Jiri Kosina Kai-Heng Feng Li Qiong Linux Kernel Functional Testing Mathew McBride Maurizio Lombardi Rob Clark Sasha Levin Srinivas Pandruvada Stefan Schmidt Steven Rostedt (Google) Sudip Mukherjee Will Deacon Yu Zhe jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 7e17397001a9..9f02aa34e179 9f02aa34e179d1b0185a27980dd5bafd0f2e6e59 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 18:12:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 18:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409548.652519 (Exim 4.92) (envelope-from ) id 1oahjG-0004x0-23; Tue, 20 Sep 2022 18:12:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409548.652519; Tue, 20 Sep 2022 18:12:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oahjF-0004wt-VA; Tue, 20 Sep 2022 18:12:17 +0000 Received: by outflank-mailman (input) for mailman id 409548; Tue, 20 Sep 2022 18:12:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oahjE-0004wn-NN for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 18:12:17 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bfe2d366-390f-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 20:12:13 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28KGJPVp004629; Tue, 20 Sep 2022 18:12:09 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jn688fkxd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Sep 2022 18:12:09 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28KHvveL035677; Tue, 20 Sep 2022 18:12:08 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jp3d2kv49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Sep 2022 18:12:08 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DS0PR10MB6053.namprd10.prod.outlook.com (2603:10b6:8:ce::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 20 Sep 2022 18:12:07 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcc6:79b8:7480:2ecf]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcc6:79b8:7480:2ecf%3]) with mapi id 15.20.5654.014; Tue, 20 Sep 2022 18:12:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfe2d366-390f-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=AJVWN+mBKnd/AQd+ChLS2BbZczDfBTifMW2OcL4paNw=; b=LmjHJFkjNEL0Lr2zuOR8mA72Cle5HsA/EUtiXo7/hvg60/tMj3VC489FgEDt0QKimlGR vDMVSpB5y3UjRERM6omvlJRmX4G43oghNrehbmNXxap0OL67eATZTuMFJuFLkYefHO6s 3zPRhGASPGzQR6FSW0Z9FzpfFLvSPZ5j/dqoNwduSebGJUUlM2vQktrSeEGnjPBegWAw 0J7AqRdAMxEwbuyXwopUnSrXId0niUktYXYyTXPGbBlFWMCPYbrOLz/i0XOqshpAFqJD rlNlI+T5d4U9KRsEvkWP+YH6MOQI63QxODlvgv1+xeJpBS8xBpzCGaGgVH680IVkeGaB hg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGL4wGVGssrMvaNfKGodvF1cHLoN+DbMAogwIU+FIMAWit2TH7WuqLGVwppWhim3MfnZgiaAac1Zgq3iv0m1dOkUNqbSRmiLFos68Fp1hQ0gdWLlzYsO9hJ+Gw7UMJJnBZsxzRMqtqCxd6oC0V2epLuv1PQqa8LFQOZ6WCA1Ymx3+aapUv8ctQTUX1K/f6DtPFjH5nyitvFDVMmththyApXzxE7EE4OMURLJWdVNRDTwa2SWpDfOXs6EuQ54J0J9p8f7W8ZGV/ttPnuGguUZpVmPk1mFA2b9BFmI0mS52gr3dAO1Tas5wWe7rTJOps4HBUJb8pnwPMUtb3Pp7pGlLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AJVWN+mBKnd/AQd+ChLS2BbZczDfBTifMW2OcL4paNw=; b=mP2+LEp/dejAuUgJlks/bdCI6bz2WcZxa0CsBXb8w+UBZf9O7NtSGk9/PunRuuulKdqXgKYRgObx/osfQFOcMz4pRs/8PRaKBHbUEJTg5Dd1y3tk+41ncGJz2GhfqsIxDeQcoH6wAi6ExKyaG2FQLN8Yi8GyuFmufZLdjBNf91dHqoRWcPOzhtfEvSTm1OL9xziLShBXae0GYLga9Q6FTZ3/fcFKlyH5pFeXxkn7gtphybhb8WOXz4DWRGJ4QSseTEtpOp+lQU8AjPXbHANEO0ohaGihNvnYD5bFKrRZYJ+4rj/j2wjkYKzzxQxABjJeNPVFQ75jU/i4/VTBlsY92Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AJVWN+mBKnd/AQd+ChLS2BbZczDfBTifMW2OcL4paNw=; b=LH+rXIWLj/R6iH5fMz3AB028GU0chUibyw12oqrdeUBSLwgvO5KxaLWHndNouV2vDsoyDoeevLiSIWQ2i3uDSdn/60abwYVj9y9iMCTPRph12Xp3OztWRWIABSzbbXOa5iOPpqxlRmfX14FDQSdeGxBHZjIAy3QrX+COy9XJVZk= Message-ID: <2c0e506a-e494-68d5-f4d0-1b54cca2b970@oracle.com> Date: Tue, 20 Sep 2022 14:12:02 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel , Tamas K Lengyel References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> From: Boris Ostrovsky Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR16CA0021.namprd16.prod.outlook.com (2603:10b6:a03:1a0::34) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|DS0PR10MB6053:EE_ X-MS-Office365-Filtering-Correlation-Id: 50522512-3af0-4909-867e-08da9b33a0ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iC6orTO+mSoen+ib52smhehCYIQMAief0e2XbgfhXS4BBYnO4o9SSDjiM4dNRPJDuUGZ66cZdccF7nPuK31Z1VLS8MxyMbyTA8AN3T5Am7tc93zYsN3blgWiszPZy5iqE8KJ8zn28bYY+yY35QQ5R2xwS0Gc/8Vdnoc/T1++gitjahDU4IqWSsx3r24YhjzMbAD6MU4ob6mZnLov1HAPCgfmqO8n5+OC3J1x2zu7BnzHPpkyL0FGoQWSn7jpG9EUyVusmAFLGjyYKiowQnxMBRZeTBqMa49xN6BiF9e08R0gZz+o2qnoH6XjmEuVqIXJg91SUqCKuj5TSjO6j88dirCAJo3woB0/x4IZsHOauEsetgrpj60K/OuoGQI29cj/1uIug66gOkyoHORs2z/BuvZpRzq0XJB60GLKeWEvwpp9bwZpC8qGL53a8HYSjuu3XN+2D08v0+ue59Ks+R2J15kRmLx87pTKE6DPjSHenqdzRKo2fbCVP6mQuJS1HAQYlKFZN1exJXsUdpX00JVFbBT97i2Gd/zbcGDvvtgH1SzHz+5Pdjja0hAP0UZiv0MQJEZ2BeJjpdtuVbD2whyaVdgILI5E5eAebTzTBtyrF49O0C/+ZtJMIQcSsRjc0UoFWZ1CiDbadEOKYDeeYKbwBCZ/OwR3lIWIa+uLFL3JLs0mKGhTYsGJORaik8Lxy6EQkzjhBZx87c6Ydn3+MhspPlOU82tixe+8Brt5w0E4ziMpKMHQLGLcekBEAjKSDCFHNDzvAcv2iPWTpzb9OWzXB250MemiWrZMrfEGZiOgXvc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(136003)(396003)(366004)(451199015)(36756003)(6506007)(2616005)(86362001)(31696002)(66476007)(8676002)(4326008)(66556008)(66946007)(26005)(31686004)(6512007)(41300700001)(2906002)(6486002)(478600001)(6666004)(53546011)(44832011)(5660300002)(186003)(316002)(38100700002)(8936002)(54906003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzIrSUpyOU5Ma0gvSGxucy9MOGdNa1ZxWGp1ejZqcXJ3ZnRyZXRCSVd6TitD?= =?utf-8?B?RUMrdmdsb3ZGblhqYkhsNUxIUlNzUDk3SnpTN21QMGYyUzZHWEk1dXdaVmNQ?= =?utf-8?B?Zld5aDNKRzNZT2xRU2RtTFo0a3BXUkU5dE9oTWFydDJNcEwyZjE5YmpWc0hZ?= =?utf-8?B?SmpSRCtnZXJsNjduVWFyYUNIeUMxcm5mOWpLcUVyZk8xS1B0VXdOSmFNM0VT?= =?utf-8?B?KzhOYWhpbVk3cHgxOFg0OHl4eG9mNmN6Lys0Z3JDNk1wTHNEQjdwL3VYZFdB?= =?utf-8?B?cHgzemFkYmI4MkJ2L2ZZMEx4ZkR1SjJqMGVrdjdxSDZ6ckFnRUJwczZ2Q1Fr?= =?utf-8?B?c0hvclRGWVJYU1pBSWpBUUxKQytZaG9nQ3FKL1ZUVDVRT1pUc29VcmpUNlpI?= =?utf-8?B?Z2YyR3RCYmxYOWhoazlVdVZtdEpCMm5aL0dzNUg0cGFsM3FmcnJMM29oemQz?= =?utf-8?B?SGp2TXpPU21Sd0Y1Um1Xdkh6aTVIZ1p4czBLMkt4dURMU0kzTTVaWUFPQnpo?= =?utf-8?B?dXloWDlpMFlaTVpJSTRMdk1DTjlkZmxDeVluUVJDZkU2aU1WYnM2aVcvQjN4?= =?utf-8?B?bUJKK09FN1RiM08vNFI5SEZaRkVDWElabncvbEN4QnNROGpOVVoxbXJRR2lk?= =?utf-8?B?OEpPSExnNzd5cDNuU2djQTM1bXE4Qlhad25pdjJNU1BhRGx5ZVBieTdwbmFw?= =?utf-8?B?TCtkZUxneWZram5uc0tuYjNPL2NyUHhOcHpjV2NMY3VkaFVUczFVUnd6LzFR?= =?utf-8?B?SlRKZnM3NmxMMHJKNnpjbkdTVzlvZDRSZnZiamc5RXIxc1ZxR1RZUTVCcnBF?= =?utf-8?B?eWpCNTR5dWtXZWZrOVZuNCtSV29oOTREMTRQQ3hvc3h2d1gvKzRvK3RKdGxC?= =?utf-8?B?NTZSUTh4OUlvNldJdUprbUNMZUpsZzNKSllEeWNIZ2wrU0NPRG1RYXVzRk1N?= =?utf-8?B?KzRJK2lDMUtnWW43OTNCRHViSE92akk3NmticDJ2MjRzTnZPNHNEdWdFdk12?= =?utf-8?B?ZWp5Zm83MjhubDJ0dDk5UUlDZGdjZUVyVHR1VUxNUDFCZlFiUUg4ZnJSNnVP?= =?utf-8?B?RWpwOXAvV3pSSjdYaHFwU1g1dTMrRURicGxWRVZNTnZDK1dGRVlmMEkvL0JP?= =?utf-8?B?Um9QcUloOTZMS1djSVU5K010ZjQ5Q3QxMTRJVXBqc0ZsOENiY0p1UnZCS0l2?= =?utf-8?B?NzVubW9SRWZpUWNCRmpMakVPdGZUUjJFNlJ2NkVEYXRTQVFrU1BOK3dpdEJo?= =?utf-8?B?QVRWOUFLVVloR0FCMkxsRWE2SXkwM0dydmoxeERHbnR5d3Nwb2ZkZEdIVHFj?= =?utf-8?B?ZTdSVGtIQ0xYN1pEdDgwNjNYaENXV3BnYnZ4L1ArL0ZybkZiUUo0M1JsRlU2?= =?utf-8?B?QVV1UmRpTno4M2Z1MjROZjYrSkNEcWIxQXdNMlpZd2wwd28zY1cvTDZxcXQ5?= =?utf-8?B?b2RBeDBYblBsdGljOEpaMVhFellydVViL3A1ci8yQllUN1E4VFRoVU8xWXhM?= =?utf-8?B?cGxURnFza2NBS25LTFRjYS8yZ25HbUZ1bmJTUDlMNmNlVFliUFFVSE4xTjVU?= =?utf-8?B?QW1YS1BQMGdQWkZ2cDNtdWJkQVgvUUZmbis1dklOUGowQmEzNkdKSVNqblB6?= =?utf-8?B?empSTk41R1ZXMzBYcmk2ZXJHNjhJSFpKNFJRV1dNTG1DSFBYUTd6TjJBNVVQ?= =?utf-8?B?aUx0ZUVpZERHMWdkbUMxMENZSkZ6MmZOOXlNbkFNM3hQaFVmY2dzV0dyY3Vv?= =?utf-8?B?d0J0eUNIN0NiSEtpR3BDSzBxcGh6TzAvQzVNejlyaEwxWW1zdGppN2w0RC9U?= =?utf-8?B?RVlZd1ZRbGMrRmhJNW05WE5NRFh0b212R1lTMjkzVldTNFBGbzlKNExzdWs2?= =?utf-8?B?TkpzZFdxR1ZVRTZleUxZcitaUWJrZnBzSkljZVMvMU56VEtlYXc1Snlqa3FG?= =?utf-8?B?RGlCcjYwN2JUK2hZcENZM0x3ZmNET0J1bC8xVWxWSEtZenVpRzhHVy9oRERo?= =?utf-8?B?SzJRcFRVdHNRN2s1WFkzeDJJMTRlODhlZE0vd1pMcjRUalVwTkp5RmVMVXdu?= =?utf-8?B?bnFiZ3FLbGxUVlB6WnQ3RHNGTFNsMzBPMzBFRGhtWW5iNFVrSlRaL3RsNjVV?= =?utf-8?B?U2hkcTF6bkRLSDM1ak1WQk9LQ2d5bUYzVlEzTFhXcGJiU2VjMVlpR0dYUExN?= =?utf-8?B?blE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50522512-3af0-4909-867e-08da9b33a0ad X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 18:12:06.9443 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9YfHPmg2tx3i0FaPpgdLDOKoqbNFD8F3hYN5fWSfbT1tWSLIMVvY5IvtJrLxRednbCuBZZwm5sqrAS6CGeAopcnEW/oGhG7S442G2wwCa+Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6053 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-20_08,2022-09-20_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209200109 X-Proofpoint-GUID: IIEeBTVdkdiphZbKjlxrL8JBgAt1cz6e X-Proofpoint-ORIG-GUID: IIEeBTVdkdiphZbKjlxrL8JBgAt1cz6e On 9/20/22 10:54 AM, Jan Beulich wrote: > On 20.09.2022 16:26, Boris Ostrovsky wrote: >> On 9/20/22 4:01 AM, Jan Beulich wrote: >>> On 20.09.2022 00:42, Boris Ostrovsky wrote: >>>> It is saving vpmu data from current pcpu's MSRs for a remote vcpu so @v >>>> in vmx_find_msr() is not @current: >>>> >>>> vpmu_load() >>>> ... >>>> prev = per_cpu(last_vcpu, pcpu); >>>> vpmu_save_force(prev) >>>> core2_vpmu_save() >>>> __core2_vpmu_save() >>>> vmx_read_guest_msr() >>>> vmx_find_msr() >>>> >>>> >>>> The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder though whether >>>> this call is needed when code path above is executed (i.e. when we are saving >>>> remove vcpu) >>> How could it not be needed? We need to obtain the guest value. The >>> thing I don't understand is why this forced saving is necessary, >>> when context_switch() unconditionally calls vpmu_switch_from(). >> >> IIRC the logic is: >> >> 1. vcpuA runs on pcpu0 >> 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has not yet called vpmu_load() from pcpu1 > The calling of vpmu_load() shouldn't matter here. What does matter is > that vpmu_save() was necessarily called already. I thought we don't always save MSRs on context switch because we optimize for case when the same vcpu gets scheduled again. But I am not sure I see this now that I am looking at the code. -boris > Therefore I'm having > trouble seeing why ... > >> 3. vcpuB is ready to run on pcpu0, calls vpmu_load() >> 4. vcpuB discovers that pcpu0's MSRs are still holding values from vcpuA >> 5. vcpuB calls vpmu_force_save(vcpuA) which stashes pcpu0's MSRs into vcpuA's vpmu context. > ... forced saving would be necessary here. What's necessary at this > point is only the loading of vcpuB's MSR values. From xen-devel-bounces@lists.xenproject.org Tue Sep 20 18:28:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 18:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409556.652531 (Exim 4.92) (envelope-from ) id 1oahyG-0006af-F4; Tue, 20 Sep 2022 18:27:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409556.652531; Tue, 20 Sep 2022 18:27:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oahyG-0006aY-AW; Tue, 20 Sep 2022 18:27:48 +0000 Received: by outflank-mailman (input) for mailman id 409556; Tue, 20 Sep 2022 18:27:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oahyE-0006aO-Ig for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 18:27:46 +0000 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [2607:f8b0:4864:20::112b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb83ac58-3911-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 20:27:45 +0200 (CEST) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-333a4a5d495so37113977b3.10 for ; Tue, 20 Sep 2022 11:27:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb83ac58-3911-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=dZ/p0pP7pAlxBAk0vf02AC0UOh0FnkUvXme5D2aPjwQ=; b=mCvPc5yJyjhMEluZQEERiVd6MYmKGQM6ACH7X3j1YvR+tGoqtYRg9HAyFH/PAmcodq Z9NXJBjXcr+7PyLm8NHT0t2xx1bmOHfx+oSBg9C1UB0h4cK3Mf8QvA/2WNCze0j4Qk8b SWV5zdwta5W3XKSFJ5/I4MUqq3BSHYd2LHNkTCfx38rXynZcnvoP0v+GhLY73jhSzjrX N6QC54oeuYzFlwJXopOVeCv+z8QZszpXYPl9eBhC5rg3p6aVrR3k64eJnLosVRvEsEKt kq8XIpI1VJ5iMwKQw6ThK59csUOFuPz7s09ldmEF8+iYemzHgsodtPtY2cTFBPCTfmce hSxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dZ/p0pP7pAlxBAk0vf02AC0UOh0FnkUvXme5D2aPjwQ=; b=dB+Ph2jTEK3BKCO3of7Cf0UC5uDw3HroNWTf3jqp7d14UXvio7P5vsZfidrtd2ejtx 3M56ocRRb9YlGKlCpfgaPIn8W8yomrCDuoOLk7MQqX2R+f7A0zrvKE+f69RiDA9HU1JV I+YlS9QYmoBkSjCQigeqoe2SIqEDm4+qtBtfwHVeOrJA/SHAnajd2wQXXEmhJA3SZ7Yf 4iCqoAoULarEdYEWFIugYBrn2YlcC2Ic9iy9g+9qJxhzyXfiOFfBEaQKnCpHa3b7YdsH T9dg7OuDLkHFhWfj0OWFYP4kRdyZCl3Vr3D+8OzaASyrKZN6e4/z2doq+qXwkimI0tck ohHw== X-Gm-Message-State: ACrzQf1RZUeLTmtIWByio3HFHBK7ggsg0MeG5ZT/w9UiOJzBu+vwNNDS tXm/0cI318GLpjxHncXD4ehnQkyTpDung7Lc9iY= X-Google-Smtp-Source: AMsMyM5GuZCsEut4gu0cJ947mnyj4cHdrO+GZFZGiFnSNXE0RG/0xYgPxS/DzUnrBtT1dmSns1DyyFJqXgWhenuvvmE= X-Received: by 2002:a81:6ed4:0:b0:345:2c35:a203 with SMTP id j203-20020a816ed4000000b003452c35a203mr21537293ywc.262.1663698464240; Tue, 20 Sep 2022 11:27:44 -0700 (PDT) MIME-Version: 1.0 References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> <2c0e506a-e494-68d5-f4d0-1b54cca2b970@oracle.com> In-Reply-To: <2c0e506a-e494-68d5-f4d0-1b54cca2b970@oracle.com> From: Tamas K Lengyel Date: Tue, 20 Sep 2022 14:27:08 -0400 Message-ID: Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load To: Boris Ostrovsky Cc: Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel Content-Type: multipart/alternative; boundary="000000000000f97bec05e91ffb61" --000000000000f97bec05e91ffb61 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 20, 2022 at 2:12 PM Boris Ostrovsky wrote: > > On 9/20/22 10:54 AM, Jan Beulich wrote: > > On 20.09.2022 16:26, Boris Ostrovsky wrote: > >> On 9/20/22 4:01 AM, Jan Beulich wrote: > >>> On 20.09.2022 00:42, Boris Ostrovsky wrote: > >>>> It is saving vpmu data from current pcpu's MSRs for a remote vcpu so > @v > >>>> in vmx_find_msr() is not @current: > >>>> > >>>> vpmu_load() > >>>> ... > >>>> prev = per_cpu(last_vcpu, pcpu); > >>>> vpmu_save_force(prev) > >>>> core2_vpmu_save() > >>>> __core2_vpmu_save() > >>>> vmx_read_guest_msr() > >>>> vmx_find_msr() > >>>> > >>>> > >>>> The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder > though whether > >>>> this call is needed when code path above is executed (i.e. when we > are saving > >>>> remove vcpu) > >>> How could it not be needed? We need to obtain the guest value. The > >>> thing I don't understand is why this forced saving is necessary, > >>> when context_switch() unconditionally calls vpmu_switch_from(). > >> > >> IIRC the logic is: > >> > >> 1. vcpuA runs on pcpu0 > >> 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has not > yet called vpmu_load() from pcpu1 > > The calling of vpmu_load() shouldn't matter here. What does matter is > > that vpmu_save() was necessarily called already. > > > I thought we don't always save MSRs on context switch because we optimize > for case when the same vcpu gets scheduled again. But I am not sure I see > this now that I am looking at the code. > I see context_switch calling vpmu_save_from before __context_switch, but if that did actually save the vPMU state it would have reset VPMU_CONTEXT_LOADED, so by the time vpmu_load calls vpmu_save_force it would have just bailed before hitting the ASSERT failure in vmx_find_msrs. The context must still be loaded at that point (I'm trying to verify right now by adding some printks). Tamas --000000000000f97bec05e91ffb61 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Sep 20, 2022 at 2:12 PM Boris= Ostrovsky <boris.ostrovsk= y@oracle.com> wrote:

On 9/20/22 10:54 AM, Jan Beulich wrote:
> On 20.09.2022 16:26, Boris Ostrovsky wrote:
>> On 9/20/22 4:01 AM, Jan Beulich wrote:
>>> On 20.09.2022 00:42, Boris Ostrovsky wrote:
>>>> It is saving vpmu data from current pcpu's MSRs for a = remote vcpu so @v
>>>> in vmx_find_msr() is not @current:
>>>>
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_load()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0prev =3D pe= r_cpu(last_vcpu, pcpu);
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_save_f= orce(prev)
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0core2_vpmu_save()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0__core2_vpmu_save()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vmx_read_guest_msr()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vmx_find_msr()
>>>>
>>>>
>>>> The call to vmx_find_msr() was introduced by 755087eb9b10c= . I wonder though whether
>>>> this call is needed when code path above is executed (i.e.= when we are saving
>>>> remove vcpu)
>>> How could it not be needed? We need to obtain the guest value.= The
>>> thing I don't understand is why this forced saving is nece= ssary,
>>> when context_switch() unconditionally calls vpmu_switch_from()= .
>>
>> IIRC the logic is:
>>
>> 1. vcpuA runs on pcpu0
>> 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has n= ot yet called vpmu_load() from pcpu1
> The calling of vpmu_load() shouldn't matter here. What does matter= is
> that vpmu_save() was necessarily called already.


I thought we don't always save MSRs on context switch because we optimi= ze for case when the same vcpu gets scheduled again. But I am not sure I se= e this now that I am looking at the code.

I see context_switch calling vpmu_save_from before __context_switch, but= if that did actually save the vPMU state it would have reset VPMU_CONTEXT_= LOADED, so by the time vpmu_load calls vpmu_save_force it would have just b= ailed before hitting the ASSERT failure in vmx_find_msrs. The context must = still be loaded at that point (I'm trying to verify right now by adding= some printks).

Tamas
--000000000000f97bec05e91ffb61-- From xen-devel-bounces@lists.xenproject.org Tue Sep 20 19:22:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 19:22:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409564.652542 (Exim 4.92) (envelope-from ) id 1oaiow-0004QW-HY; Tue, 20 Sep 2022 19:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409564.652542; Tue, 20 Sep 2022 19:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaiow-0004QP-Eq; Tue, 20 Sep 2022 19:22:14 +0000 Received: by outflank-mailman (input) for mailman id 409564; Tue, 20 Sep 2022 19:22:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaiou-0004QJ-Nc for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 19:22:12 +0000 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [2607:f8b0:4864:20::102f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85a2c9aa-3919-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 21:22:10 +0200 (CEST) Received: by mail-pj1-x102f.google.com with SMTP id fv3so4179847pjb.0 for ; Tue, 20 Sep 2022 12:22:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i62-20020a17090a3dc400b001facf455c91sm286910pjc.21.2022.09.20.12.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 12:22:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85a2c9aa-3919-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=mRkb49hJ/o7sUzNJw/zHfFKhjBVcyGD1caVksculA00=; b=PCUI69eggGWeXyBeTxep9IHUaH7o4uqq9Tn6NaYKT/NYgVgrpRX6+8DhNeX3ewe9ey clzFXuBXIjdIDBwAb0H1OJggBDLLvppduw51miVUkus5CCOXfCg6GLFkPmuoAUvBdVwx pWo63368x3lb04WlSCci+u5M/slQQLEVz5BeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=mRkb49hJ/o7sUzNJw/zHfFKhjBVcyGD1caVksculA00=; b=axC7ZFY9vKrSTrfNiDnHbTnEI3iaLxdxmHn0rruPKNk9vq4WalW7JKTzGBpZbEhY9M kywPWHnOc37TxfeJuTHZLmeEM7QUtLwxmKGSLsJjOLO3wtuMeQ4Z8m3s4uCafwxJRRq2 6gYcyxXAeWXT2agdhCnT+xM2n9MwMx9qhdB9ZOkBrzkSm9nXPs3bB3yAzkDzy3hUotFg Iigre5UEmtnxuimkxf+qxJlYMwVqPoPoCAp1jOmEUHIqSitpaMuJ2cnT+npROqiiZNJY viDbapFNXZXN4BxqsgOu0I0lpou1CuhAm5iHBtnFR3kVdlCA7aVD/qyHOQ9WL99Oa4mn kJDg== X-Gm-Message-State: ACrzQf1gVDDfI0XAhwOZSzaNQZQ9eRN40PjzPiEYlbszRSGjkiQuLhir 5ubcCAnOkqBCRzoiBXBMccN4KQ== X-Google-Smtp-Source: AMsMyM761d7Fl9dtnwBzIqTJhW7NDE0KfYgW2Z3zOf5cFMrONbSUwHk2/D83vjqkbY1Tqo6olp+d4w== X-Received: by 2002:a17:903:1248:b0:172:f3c7:97a6 with SMTP id u8-20020a170903124800b00172f3c797a6mr1097776plh.128.1663701729091; Tue, 20 Sep 2022 12:22:09 -0700 (PDT) From: Kees Cook To: linux-hardening@vger.kernel.org Cc: Kees Cook , Juergen Gross , Boris Ostrovsky , Nathan Chancellor , Nick Desaulniers , xen-devel@lists.xenproject.org, llvm@lists.linux.dev, Siddhesh Poyarekar , Arnd Bergmann , Tom Rix , Miguel Ojeda , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] x86/entry: Work around Clang __bdos() bug Date: Tue, 20 Sep 2022 12:21:59 -0700 Message-Id: <20220920192202.190793-2-keescook@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220920192202.190793-1-keescook@chromium.org> References: <20220920192202.190793-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1979; h=from:subject; bh=4MnVaPsx8mraEdez/1qUw/f+9P/3EjkrM/1wqdGlA2Y=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBjKhLZE7kAhe/OxfUVwh8eyd4pKAVAQvW03irD5DAW qRCvxvmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYyoS2QAKCRCJcvTf3G3AJuSWD/ 0YU5lJR6Qasvy4L3d9D2h5U5JWrfw5lBGb341IHXohJFP1UnzRH0CT/UnomvYDoLvjhR2joksvkjkn BNTSv7VoRq4RwprCdKG4kgHD8PGjx57z3qsj73lXyfUXt1MwvQB9y+YDpD/SE2IuUFQpf+4iZ2uEtn LvLw9kT0MNmAnaM2dSR5lA6wrcdt9dcqBf4C1O80RyWBKBnfJN2tT3TskZggBrAyk2Y4VxfAOg9UF2 vTENn7pVEn7EisxLJ6/wCFt835Ov9Op7ldWqez4GSVVxpyhYW3zjEzqFOZ1Jwto62iUKdM+V83O8ew rjJ/WRDJT6EN225b5IvYvTHVC742B3/OkrjefYwWsKruTy7sR4aGoXrx6gtHOCfsncloYhZnF1ayiE /BA9ncPIH958gJ01gz7eZndZ2kkOAFTm3BBIZ/Rm8ISXObKAWBd6rFb0MBYeVza2e4fbwvVJfgTG9H tv86FQuDi0OhoT1JbgJrNbf/GhLz8PegmQUKUoAhXk9LrWby/jti9NoGokj6bJKjjtuORb0ETDHUJU WM+b2N7anNSPw/Sovfcx5bkbvOrenXO1PW7ByUj5o5/nal3mnvLFtWS7g3Z17XB5ybO8nxngnjb9NG Fcmwv0P7fktHuuT0QNwTw4WG5vmaMeqDZTTYXOKsbqzpoOfwlI1qO6qXA0jQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit After expanding bounds checking to use __builtin_dynamic_object_size(), Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic offset. Work around this by using a direct assignment of an empty instance. Avoids this warning: ../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat tribute-warning] __write_overflow_field(p_size_field, size); ^ which was isolated to the memset() call in xen_load_idt(). Note that this looks very much like another bug that was worked around: https://github.com/ClangBuiltLinux/linux/issues/1592 Cc: Juergen Gross Cc: Boris Ostrovsky Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: xen-devel@lists.xenproject.org Cc: llvm@lists.linux.dev Signed-off-by: Kees Cook --- arch/x86/xen/enlighten_pv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 0ed2e487a693..9b1a58dda935 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -765,6 +765,7 @@ static void xen_load_idt(const struct desc_ptr *desc) { static DEFINE_SPINLOCK(lock); static struct trap_info traps[257]; + static const struct trap_info zero = { }; unsigned out; trace_xen_cpu_load_idt(desc); @@ -774,7 +775,7 @@ static void xen_load_idt(const struct desc_ptr *desc) memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc)); out = xen_convert_trap_info(desc, traps, false); - memset(&traps[out], 0, sizeof(traps[0])); + traps[out] = zero; xen_mc_flush(); if (HYPERVISOR_set_trap_table(traps)) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 22:51:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 22:51:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409577.652553 (Exim 4.92) (envelope-from ) id 1oam4x-0008Q0-Fr; Tue, 20 Sep 2022 22:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409577.652553; Tue, 20 Sep 2022 22:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oam4x-0008Pt-CE; Tue, 20 Sep 2022 22:50:59 +0000 Received: by outflank-mailman (input) for mailman id 409577; Tue, 20 Sep 2022 22:50:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oam4w-0008Pn-NQ for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 22:50:58 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0491c88-3936-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 00:50:56 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id 29so6066194edv.2 for ; Tue, 20 Sep 2022 15:50:56 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id w19-20020a170906185300b00781dbdb2917sm419441eje.208.2022.09.20.15.50.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 15:50:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0491c88-3936-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=QvFwsZxA6MHmqPpgPr1kmpEeALNsZz3EkiO3t151YWs=; b=ibNCByyuTGhFGP39XO+xweQozEi3tAqcBRhZ/WOmAMtm/9JZXAqTHeKDVMR3haUUku bX/KG2i8BLKYyZZ5r9zS7NpGgT5D6bwJNH/6EaOJaQxYpBu64mBI46gWkHJPUonkqqL5 uEs9gpr+y/TWGp+xV48d0PI7qu18qvMXd4eqt6zEm9WuFkfVSx7rwO4U1MQF3yaSFsY/ 5Jo9YA+0CW00j9RSccq2/MAvvNkxPNwQERMk4xSHlaFAE0ymgCLA5CQSoPJv8sXQ2J8b J45/4/j74hFU0Hj4c7mQT5wxM/yWl5q+XEBIfdHitK28VSjZ22xsRBuBV8AWfo2iUnYv RJfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=QvFwsZxA6MHmqPpgPr1kmpEeALNsZz3EkiO3t151YWs=; b=Fo3g3p/kkfl9e7PdVbGmaUiMNWdJthuzbcEbYqbeF7lLiMPnBcFnLs7A6fpj2lZioC 1NMxpQFtxyjY2H/caxyaTeEVGNTAbe4oYUxi0faP/M/lpjmf1SG7fJTgYQ0ni4BW/Jnj Viq5kGqnXoJL6yN9Al5YFIgjmKG5587qOMw3jtlq8QEK1SK4eE8J3SsyDNiaZ3trM+x2 I6LLsUkKiATFshSbeY4kyCG5SsDH9pFs5FN37duZm6xX/8GmLHQ/tZGPanlOmcGe2eBe STQRrG1jz6kdOw1t1ipUaxJ0TloCvjUEmFqK5ejzjee0b0OMD7O/Yu9NGEGem1UYS+gu HRHQ== X-Gm-Message-State: ACrzQf1MPR3UgUmVAmFvv0LaRHFw3O/Xklru373iKnCJ6S34nv3jIdet XpLz+VwOuc5mKgEJqjMmTTY= X-Google-Smtp-Source: AMsMyM67oSTOvXd574lZXg8CCJPXcxUdWt09EbcZYxRTm1trv1PkATVyBPnkcoMu+n0wqofhvURSSQ== X-Received: by 2002:a05:6402:1e8c:b0:44f:f70:e75e with SMTP id f12-20020a0564021e8c00b0044f0f70e75emr21468748edf.405.1663714256321; Tue, 20 Sep 2022 15:50:56 -0700 (PDT) Date: Tue, 20 Sep 2022 22:50:48 +0000 From: Bernhard Beschow To: Peter Maydell CC: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_0/9=5D_Deprecate_sysbus=5Fget=5Fd?= =?US-ASCII?Q?efault=28=29_and_get=5Fsystem=5Fmemory=28=29_et=2E_al?= In-Reply-To: References: <20220919231720.163121-1-shentey@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 09:55:37 UTC schrieb Peter Maydell : >On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wro= te: >> >> In address-spaces=2Eh it can be read that get_system_memory() and >> get_system_io() are temporary interfaces which "should only be used tem= porarily >> until a proper bus interface is available"=2E This statement certainly = extends to >> the address_space_memory and address_space_io singletons=2E > >This is a long standing "we never really completed a cleanup"=2E=2E=2E > >> This series attempts >> to stop further proliferation of their use by turning TYPE_SYSTEM_BUS i= nto an >> object-oriented, "proper bus interface" inspired by PCIBus=2E >> >> While at it, also the main_system_bus singleton is turned into an attri= bute of >> MachineState=2E Together, this resolves five singletons in total, makin= g the >> ownership relations much more obvious which helps comprehension=2E > >=2E=2E=2Ebut I don't think this is the direction we want to go=2E >Overall the reason that the "system memory" and "system IO" >singletons are weird is that in theory they should not be necessary >at all -- board code should create devices and map them into an >entirely arbitrary MemoryRegion or set of MemoryRegions corresponding >to address space(s) for the CPU and for DMA-capable devices=2E My intention was to allow exactly that: By turning sytem memory and system= IO into non-singletons, one could have many of them, thus allowing boards = to create arbitrary mappings of memory and IO=2E Since QEMU currently assum= es one set (memory and IO) of addresses, I for now instantiated the SysBus = once in the machine class to preserve behavior=2E >But we >keep them around because > (a) there is a ton of legacy code that assumes there's only one > address space in the system and this is it > (b) when modelling the kind of board where there really is only > one address space, having the 'system memory' global makes > the APIs for creating and connecting devices a lot simpler Indeed, the APIs may look simpler=2E The issue I see here though is that d= evices may make assumptions about these globals which makes the code hard t= o change in the long run=2E If devices are given their dependencies by the = framework, they must make less assumptions, putting the framework into cont= rol=2E This makes the code more homogenious and therefore easier to change= =2E >Retaining the whole-system singleton but shoving it into MachineState >doesn't really change much, IMHO=2E > >More generally, sysbus is rather weird because it isn't really a >bus=2E Every device in the system of TYPE_SYS_BUS_DEVICE is "on" >the unique TYPE_SYSTEM_BUS bus, but that doesn't mean they're >all in the same address space or that in real hardware they'd >all be on the same bus=2E Again, having multiple SysBuses may solve that issue=2E >sysbus has essentially degraded into a >hack for having devices get reset=2E I really really need to make >some time to have another look at reset handling=2E If we get that >right then I think it's probably possible to collapse the few >things TYPE_SYS_BUS_DEVICE does that TYPE_DEVICE does not down >into TYPE_DEVICE and get rid of sysbus altogether=2E=2E=2E There are many SysBusDevices which directly access the globals I intended = to deprecate=2E If those devices could be changed to use the SysBus equival= ents instead, this would put the boards in control of memory mappings=2E Best regards, Bernhard > >thanks >-- PMM From xen-devel-bounces@lists.xenproject.org Tue Sep 20 22:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 22:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409583.652564 (Exim 4.92) (envelope-from ) id 1oamDa-0000iV-BO; Tue, 20 Sep 2022 22:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409583.652564; Tue, 20 Sep 2022 22:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamDa-0000iO-84; Tue, 20 Sep 2022 22:59:54 +0000 Received: by outflank-mailman (input) for mailman id 409583; Tue, 20 Sep 2022 22:59:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamDZ-0000iF-0k for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 22:59:53 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef306d8b-3937-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 00:59:51 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id a26so9748468ejc.4 for ; Tue, 20 Sep 2022 15:59:51 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id kw9-20020a170907770900b00781d411a63csm466007ejc.151.2022.09.20.15.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 15:59:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef306d8b-3937-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=5zGDMClH44o9kBaZpfqB55k2zUqfrg9XV0PUDaOzJJI=; b=fLhdMY9oJXsreiLcZGR2iqMruYR+8+TCZiJyOzjDIshhi2bT8T6q+tOne1hiOdyqXO VTm+mfBfnxXUp/6y/e1nSyP1Dn84N9RSnK9nSVgTSpuwcpk871Gfn+3pte5bQrIhLcRl eGbrMzV5MZcAqPSa7RkI/rIP+ODd6Bso+zAhveSvEjr2iX7tCpsYpQOzGMxKRuBrqoWv +RHUpwX3uIOzr495dtL2pNiP6gCRKUw0kDX34CF8YVOy2VTong7eOTkVA+a7yHmD1cBV qeJNxDhMGv21t0c0x7Yap8LkRSR3ZyVHRzCNFWE0M/lla9o40AxvSWMHge7zOl/LWLNS ENnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=5zGDMClH44o9kBaZpfqB55k2zUqfrg9XV0PUDaOzJJI=; b=5mnSGUaYT6BxDpx1Xo2i1NllLnulL1AQrT37ZZou0Km4PuGe/XubbzlUeZX4cBuRaB Mu4/2nLnQHsf7KJP6FwbALE9cltGe8awPhHshxT+uyV1u5O4WMY0YISmETXQ6CNCgTBi xxLd2mNKP0qG7F2AvZUsZ1gWSb1+NMLlGH8vaVIKgKDHkQHXHZjsXnsDmqLCKGGXggPz zo/dLluns/hQFtWrgQu4iYUFwXx8cCj3tDsog7T1FpyOBpLP4LtNii5eaJmQYbjVYCjP UawnOq51NvTi3jAKzVfP9l0+tFqQYIwi8dPjgo7QGo7UXLorSqcCz2zmuVqohvJEw9RN ZGZA== X-Gm-Message-State: ACrzQf0ZP+UZnfXSvWSjtJaxMC/IoipgO8NqkJkTJ5Ch9y2+5s34Yu/M vw7ner8h+ac3/AaTjgggCFk= X-Google-Smtp-Source: AMsMyM68ho+SYOSTwNpH652r4SoJ1volg4FPzzUg+Xkd/7GxX6MGFhW5pQGNcXjCKdvhJIRWBodr2w== X-Received: by 2002:a17:906:8a53:b0:781:6ee9:db96 with SMTP id gx19-20020a1709068a5300b007816ee9db96mr7656219ejc.301.1663714791350; Tue, 20 Sep 2022 15:59:51 -0700 (PDT) Date: Tue, 20 Sep 2022 22:59:42 +0000 From: Bernhard Beschow To: Mark Cave-Ayland , Peter Maydell CC: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_0/9=5D_Deprecate_sysbus=5Fget=5Fd?= =?US-ASCII?Q?efault=28=29_and_get=5Fsystem=5Fmemory=28=29_et=2E_al?= In-Reply-To: <49325e7d-5020-23f7-4bce-c53d8d988c95@ilande.co.uk> References: <20220919231720.163121-1-shentey@gmail.com> <49325e7d-5020-23f7-4bce-c53d8d988c95@ilande.co.uk> Message-ID: <7DBD5114-15B2-42A7-AB97-35DBF9DDA825@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 15:36:26 UTC schrieb Mark Cave-Ayland : >On 20/09/2022 10:55, Peter Maydell wrote: > >> On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow w= rote: >>>=20 >>> In address-spaces=2Eh it can be read that get_system_memory() and >>> get_system_io() are temporary interfaces which "should only be used te= mporarily >>> until a proper bus interface is available"=2E This statement certainly= extends to >>> the address_space_memory and address_space_io singletons=2E >>=20 >> This is a long standing "we never really completed a cleanup"=2E=2E=2E >>=20 >>> This series attempts >>> to stop further proliferation of their use by turning TYPE_SYSTEM_BUS = into an >>> object-oriented, "proper bus interface" inspired by PCIBus=2E >>>=20 >>> While at it, also the main_system_bus singleton is turned into an attr= ibute of >>> MachineState=2E Together, this resolves five singletons in total, maki= ng the >>> ownership relations much more obvious which helps comprehension=2E >>=20 >> =2E=2E=2Ebut I don't think this is the direction we want to go=2E >> Overall the reason that the "system memory" and "system IO" >> singletons are weird is that in theory they should not be necessary >> at all -- board code should create devices and map them into an >> entirely arbitrary MemoryRegion or set of MemoryRegions corresponding >> to address space(s) for the CPU and for DMA-capable devices=2E But we >> keep them around because >> (a) there is a ton of legacy code that assumes there's only one >> address space in the system and this is it >> (b) when modelling the kind of board where there really is only >> one address space, having the 'system memory' global makes >> the APIs for creating and connecting devices a lot simpler >>=20 >> Retaining the whole-system singleton but shoving it into MachineState >> doesn't really change much, IMHO=2E >>=20 >> More generally, sysbus is rather weird because it isn't really a >> bus=2E Every device in the system of TYPE_SYS_BUS_DEVICE is "on" >> the unique TYPE_SYSTEM_BUS bus, but that doesn't mean they're >> all in the same address space or that in real hardware they'd >> all be on the same bus=2E sysbus has essentially degraded into a >> hack for having devices get reset=2E I really really need to make >> some time to have another look at reset handling=2E If we get that >> right then I think it's probably possible to collapse the few >> things TYPE_SYS_BUS_DEVICE does that TYPE_DEVICE does not down >> into TYPE_DEVICE and get rid of sysbus altogether=2E=2E=2E > >Following on from one of the discussion points from Alex's KVM Forum BoF = session: I think longer term what we need to aim for is for QEMU machines t= o define their own address spaces, and then bind those address spaces conta= ining memory-mapped devices to one or more CPUs=2E Isn't that more or less impossible with singletons? > >Once this in place, as Peter notes above it just remains to solve the res= et problem and then it becomes possible to eliminate sysbus altogether as e= verything else can already be managed by qdev/QOM=2E Also see my reply to Peter=2E Thanks, Bernhard > > >ATB, > >Mark=2E From xen-devel-bounces@lists.xenproject.org Tue Sep 20 23:04:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 23:04:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409589.652574 (Exim 4.92) (envelope-from ) id 1oamHY-00028l-RQ; Tue, 20 Sep 2022 23:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409589.652574; Tue, 20 Sep 2022 23:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamHY-00028e-OK; Tue, 20 Sep 2022 23:04:00 +0000 Received: by outflank-mailman (input) for mailman id 409589; Tue, 20 Sep 2022 23:03:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamHX-00028Y-5s for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 23:03:59 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 82017187-3938-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 01:03:58 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id bj12so9647594ejb.13 for ; Tue, 20 Sep 2022 16:03:58 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id x16-20020aa7dad0000000b004548dfb895asm662307eds.34.2022.09.20.16.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 16:03:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82017187-3938-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=PxKeXBgXDwhU6B1ik/sUia4kvwdWE2K6hWQ95wE2Drk=; b=HEjiVh9w/3uCTeKWv5xTLYFpaViWsk1vtcDV5uQGkSAxseV3doz8CMX3FWw2WdZCHR RcYX/eRukcl9SLItOd8D1rCIKwttT7lhGff2RwC7ww60l1XOfWWmLKzBYHGUeV7pPFsd P6QdGWOYlxu4X8tnvMr7B+LQXRg5qP3SnC1gIWLJ5g7+BYCYhv4PWiOReQpR2NqO04s6 ncY0vtK8AjDW/NwmHfxb2t82Lq8SPDtde4ij2gGlDjf5vewhZZg+mS1Wl6X2X+rTl900 QNyrUQhD4kT+8PNRDeXGczO8mxCYzv5qaZoZCd2YXXoBhhst+vNWlk3So56OtpqodqAY VXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=PxKeXBgXDwhU6B1ik/sUia4kvwdWE2K6hWQ95wE2Drk=; b=W9UKX4AqFpPJ8/Ljk1r9I/JIdYUXIJ0tfieTQHV9km+C1wOD5akFrSqatrEHISJHXb ERi+zgeHgNgoWPu9aS//SMGi4FySyl69HcreXCY4yF/Z4+cpfVtqvRCFIadXdqZRjE/f C5ljkWFLdgD/82NWAHXQ6EdbNYcmZ2+PPe6PrWdqAUguq7dY99e9GUgoFu8R6mSaS064 5EQ2PU74TrI0JZGbGBVDsQtzcaSPFBbzCuo0JvpB+T/7z+VMA86bLsr0hj8XZNVva7OK VZwxxs/LQjyRWFoBNWF1CMGW77sA14Ule4mh6MVjAUGbi8MrRzfnjePvLPVZptsBDKTj sXOQ== X-Gm-Message-State: ACrzQf1ruRegRl8orDaD061Jvw7DG9QciA46/C8J3fmVvPZnz1u2MEP6 Uwm/JYkendPTGwKZOzpxZAc= X-Google-Smtp-Source: AMsMyM6o2HZboVTIuCsGaPRZJv5x4LFAzYPhH4MOs0KGTsqesz3HK/dGZx2nOXDSIqcv/rFb4zYPxw== X-Received: by 2002:a17:906:6a14:b0:774:a998:d9a2 with SMTP id qw20-20020a1709066a1400b00774a998d9a2mr18208772ejc.496.1663715037704; Tue, 20 Sep 2022 16:03:57 -0700 (PDT) Date: Tue, 20 Sep 2022 23:03:49 +0000 From: Bernhard Beschow To: =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org CC: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 2/9] exec/hwaddr.h: Add missing include In-Reply-To: <3fcb707c-47c3-7696-86ec-62048e39bfe1@amsat.org> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-3-shentey@gmail.com> <3fcb707c-47c3-7696-86ec-62048e39bfe1@amsat.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 04:50:51 UTC schrieb "Philippe Mathieu-Daud=C3=A9" = : >On 20/9/22 01:17, Bernhard Beschow wrote: >> The next commit would not compile w/o the include directive=2E >>=20 >> Signed-off-by: Bernhard Beschow >> --- >> include/exec/hwaddr=2Eh | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/include/exec/hwaddr=2Eh b/include/exec/hwaddr=2Eh >> index 8f16d179a8=2E=2E616255317c 100644 >> --- a/include/exec/hwaddr=2Eh >> +++ b/include/exec/hwaddr=2Eh >> @@ -3,6 +3,7 @@ >> #ifndef HWADDR_H >> #define HWADDR_H >> +#include "qemu/osdep=2Eh" > >NAck: This is an anti-pattern=2E "qemu/osdep=2Eh" must not be included >in =2Eh, only in =2Ec=2E > >Isn't including "hw/qdev-core=2Eh" in "include/hw/boards=2Eh" enough in >the next patch? Yes, this works just fine indeed! This patch could be dropped if in the ne= xt iteration, if any=2E Thanks, Bernhard From xen-devel-bounces@lists.xenproject.org Tue Sep 20 23:13:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 23:13:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409595.652585 (Exim 4.92) (envelope-from ) id 1oamQV-0003fF-Nt; Tue, 20 Sep 2022 23:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409595.652585; Tue, 20 Sep 2022 23:13:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamQV-0003f8-L8; Tue, 20 Sep 2022 23:13:15 +0000 Received: by outflank-mailman (input) for mailman id 409595; Tue, 20 Sep 2022 23:13:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamQU-0003f1-5D for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 23:13:14 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cca45c61-3939-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 01:13:12 +0200 (CEST) Received: by mail-ed1-x532.google.com with SMTP id y8so6073352edc.10 for ; Tue, 20 Sep 2022 16:13:12 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id s4-20020aa7d784000000b0044838efb8f8sm662810edq.25.2022.09.20.16.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 16:13:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cca45c61-3939-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=bbUnGfY0T65vpw4i+PmIv1V+pOshk83ucIJf1T2aWdo=; b=ls5u4mWmzc7wWpojyA20Bt3CadigjecKwPHtS0ugar11GBW4QxG01c7I+FSv4aEXxx kfudSa+UgDRMWTzRygtowcdKEHXM5GhKSjDLK0f2PLRvZIHMbf+W1SzB1+XALNHvhjW7 4987PFAS9fT1/Z2mRZcalcGftAZQCRnM29/Lw4ihqN+YcRt7EqKea73SSK6H/ErlqRm+ eRN4LIy9KlwhU/fgPV+wWQmi561yMiUm42Ec5eZg1sQnL56KUGoSxeLemHtRlxrro7fZ ycbw7arvaIDn0R9vRYC3WYmTTuUO6i/iW6lP47ORjlIApektwFfB4gNxqCasGaZu8dlV DKMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=bbUnGfY0T65vpw4i+PmIv1V+pOshk83ucIJf1T2aWdo=; b=H0NoAayzvgscSrV4QcNxhG63BEwg21YctWzsQvA0EeTT/3zzZ8o7nw2giH1HwU4oGj fmzp5mfA39gibSPNJmAI+ptHNgEP2pEk7Fqh0WkugkUZ/BxBQORHokNrGClhgr/Qu9Aq PfgKKNUn09c7CAJmjt7CdSxjoblZeaKY/vgT79hPQruQS++PBX0EI1iz9JHl2v5GI6+J pgfzfBBruIXGvbBZvLDDlx+7H6n9O/2DJfXxMbDwEHHDgALNaW2BmceqFtzRk6s+n0vG LH5AYKBpBnbx6f79bwDJV5nFHD+/abdfUfRxutQwSCq80LnextQRuribYN3k9f52BmNC z9Wg== X-Gm-Message-State: ACrzQf1kLv5QMi6uaRELuBydmpon0LeH9yb0h+hU7OPRJDluo+PCMSr6 msPNebWxgSTyvj9M4VpxF+4= X-Google-Smtp-Source: AMsMyM5MIIf9aJBnS9EdzxA+J+yQnJxRSxuHpH9qx7oUct/GFhyGI64mHGWWOkudI6DPkfOPMpThSQ== X-Received: by 2002:a50:ff13:0:b0:43e:76d3:63e1 with SMTP id a19-20020a50ff13000000b0043e76d363e1mr22127037edu.271.1663715592403; Tue, 20 Sep 2022 16:13:12 -0700 (PDT) Date: Tue, 20 Sep 2022 23:13:04 +0000 From: Bernhard Beschow To: BALATON Zoltan , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_8/9=5D_softmmu/physmem=3A_Let_SysBusState_?= =?US-ASCII?Q?absorb_memory_region_and_address_space_singletons?= In-Reply-To: References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-9-shentey@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 08:50:01 UTC schrieb BALATON Zoltan : > > >On Tue, 20 Sep 2022, Philippe Mathieu-Daud=C3=A9 via wrote: > >> On 20/9/22 01:17, Bernhard Beschow wrote: >>> These singletons are actually properties of the system bus but so far = it >>> hasn't been modelled that way=2E Fix this to make this relationship ve= ry >>> obvious=2E >>>=20 >>> The idea of the patch is to restrain futher proliferation of the use o= f >>> get_system_memory() and get_system_io() which are "temprary interfaces= " >>=20 >> "further", "temporary" >>=20 >>> "until a proper bus interface is available"=2E This should now be the >>> case=2E >>>=20 >>> Note that the new attributes are values rather than a pointers=2E This >>> trades pointer dereferences for pointer arithmetic=2E The idea is to >>> reduce cache misses - a rule of thumb says that every pointer >>> dereference causes a cache miss while arithmetic is basically free=2E >>>=20 >>> Signed-off-by: Bernhard Beschow >>> --- >>> include/exec/address-spaces=2Eh | 19 ++++++++++++--- >>> include/hw/sysbus=2Eh | 6 +++++ >>> softmmu/physmem=2Ec | 46 ++++++++++++++++++-------------= ---- >>> 3 files changed, 45 insertions(+), 26 deletions(-) >>>=20 >>> diff --git a/include/exec/address-spaces=2Eh b/include/exec/address-sp= aces=2Eh >>> index d5c8cbd718=2E=2Eb31bd8dcf0 100644 >>> --- a/include/exec/address-spaces=2Eh >>> +++ b/include/exec/address-spaces=2Eh >>> @@ -23,17 +23,28 @@ >>> #ifndef CONFIG_USER_ONLY >>> -/* Get the root memory region=2E This interface should only be use= d temporarily >>> - * until a proper bus interface is available=2E >>> +/** >>> + * Get the root memory region=2E This is a legacy function, provided= for >>> + * compatibility=2E Prefer using SysBusState::system_memory directly= =2E >>> */ >>> MemoryRegion *get_system_memory(void); >>=20 >>> diff --git a/include/hw/sysbus=2Eh b/include/hw/sysbus=2Eh >>> index 5bb3b88501=2E=2E516e9091dc 100644 >>> --- a/include/hw/sysbus=2Eh >>> +++ b/include/hw/sysbus=2Eh >>> @@ -17,6 +17,12 @@ struct SysBusState { >>> /*< private >*/ >>> BusState parent_obj; >>> /*< public >*/ >>> + >>> + MemoryRegion system_memory; >>> + MemoryRegion system_io; >>> + >>> + AddressSpace address_space_io; >>> + AddressSpace address_space_memory; >>=20 >> Alternatively (renaming doc accordingly): >>=20 >> struct { >> MemoryRegion mr; >> AddressSpace as; >> } io, memory; > >Do we really need that? Isn't mr just the same as as=2Eroot so it would b= e enough to store as only? Or is caching mr and not going through as to get= it saves time in accessing these? as=2Eroot is just a pointer=2E That's why we need mr as a value as well=2E > Now we'll go through SysBusState anyway instead of accessing globals so = is there a performance impact? Good question=2E Since both attributes are now next to each another I'd ho= pe for an improvement ;-) That depends on on many things of course, such as= if they are located in the same cache line=2E As written in the commit mes= sages I tried to minimize pointer dereferences=2E Best regards, Bernhard > >Regards, >BALATON Zoltan > >>> }; >>> #define TYPE_SYS_BUS_DEVICE "sys-bus-device" >>> diff --git a/softmmu/physmem=2Ec b/softmmu/physmem=2Ec >>> index 0ac920d446=2E=2E07e9a9171c 100644 >>> --- a/softmmu/physmem=2Ec >>> +++ b/softmmu/physmem=2Ec >>> @@ -86,12 +86,6 @@ >>> */ >>> RAMList ram_list =3D { =2Eblocks =3D QLIST_HEAD_INITIALIZER(ram_list= =2Eblocks) }; >>> -static MemoryRegion *system_memory; >>> -static MemoryRegion *system_io; >>> - >>> -static AddressSpace address_space_io; >>> -static AddressSpace address_space_memory; >>> - >>> static MemoryRegion io_mem_unassigned; >>> typedef struct PhysPageEntry PhysPageEntry; >>> @@ -146,7 +140,7 @@ typedef struct subpage_t { >>> #define PHYS_SECTION_UNASSIGNED 0 >>> static void io_mem_init(void); >>> -static void memory_map_init(void); >>> +static void memory_map_init(SysBusState *sysbus); >>> static void tcg_log_global_after_sync(MemoryListener *listener); >>> static void tcg_commit(MemoryListener *listener); >>> @@ -2667,37 +2661,45 @@ static void tcg_commit(MemoryListener *liste= ner) >>> tlb_flush(cpuas->cpu); >>> } >>> -static void memory_map_init(void) >>> +static void memory_map_init(SysBusState *sysbus) >>> { >>=20 >> No need to pass a singleton by argument=2E >>=20 >> assert(current_machine); >>=20 >> You can use get_system_memory() and get_system_io() in place :) >>=20 >> LGTM otherwise, great! >>=20 >>> - system_memory =3D g_malloc(sizeof(*system_memory)); >>> + MemoryRegion *system_memory =3D &sysbus->system_memory; >>> + MemoryRegion *system_io =3D &sysbus->system_io; >>> memory_region_init(system_memory, NULL, "system", UINT64_MAX); >>> - address_space_init(&address_space_memory, system_memory, "memory"= ); >>> + address_space_init(&sysbus->address_space_memory, system_memory, = "memory"); >>> - system_io =3D g_malloc(sizeof(*system_io)); >>> memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL,= "io", >>> 65536); >>> - address_space_init(&address_space_io, system_io, "I/O"); >>> + address_space_init(&sysbus->address_space_io, system_io, "I/O"); >>> } >>> MemoryRegion *get_system_memory(void) >>> { >>> - return system_memory; >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Esystem_memory; >>> } >>> MemoryRegion *get_system_io(void) >>> { >>> - return system_io; >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Esystem_io; >>> } >>> AddressSpace *get_address_space_memory(void) >>> { >>> - return &address_space_memory; >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Eaddress_space_memory; >>> } >>> AddressSpace *get_address_space_io(void) >>> { >>> - return &address_space_io; >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Eaddress_space_io; >>> } >>=20 >>=20 >>=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 23:20:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 23:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409602.652596 (Exim 4.92) (envelope-from ) id 1oamXO-0005DS-Hv; Tue, 20 Sep 2022 23:20:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409602.652596; Tue, 20 Sep 2022 23:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamXO-0005DL-FG; Tue, 20 Sep 2022 23:20:22 +0000 Received: by outflank-mailman (input) for mailman id 409602; Tue, 20 Sep 2022 23:20:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamXN-0005DF-2z for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 23:20:21 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb08ac5d-393a-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 01:20:19 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id a26so9833673ejc.4 for ; Tue, 20 Sep 2022 16:20:19 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id er12-20020a056402448c00b0044ee91129f9sm629755edb.70.2022.09.20.16.20.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 16:20:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb08ac5d-393a-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=GtMxYIRvAVAlD5MIJW3CMU+hdQDh/A1FNoJWhhLH0qE=; b=pm+buGeFehD8BASPCqH113rGynSJwN6wxPzkq6dds4CXX+4p5I3dBJkJJS01RL+Tai jXH2C6g6rtblZqjB1SsUvwxyKHQi8PI5uw0Y+ftr+xqd8CxhaxojBqt0sbvWrNQ3QgwT HPi85aRbWX3nCZ/mx03/0M4ol+mefKDFl/abg2tUrRmQyeLI6HGQ8OT1RcyuobJttOxN tv9FNW7Rw6H99aA2h0obQ/oBQ2ZcBAUOcOrWNRg7zTAeetnuaOg44KKGVxIGps1+/op4 BKH/r6CYUtGxJTGZtHM13rOeRwpoBPxI5vWiYm45neZhCA9By3jialVV75S3lBm/f6Ct DOpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=GtMxYIRvAVAlD5MIJW3CMU+hdQDh/A1FNoJWhhLH0qE=; b=oin8XeziYvdGIKVJv3pWzVvwCIRi0TpZ7bZZhSeFuFHbS6khD6MZPYi5HiWjRgxwHr cx4kGHNvwrYKiUonMdkfp+MgYYDddIFauGh1QyzaNCsNjAjaEX44Frc0qXPYFdEAmH2f 0xz2+3omdJLUdZIfWicI8KPHmnewJmag0vVCar0G+bEuftBGauqGq6Vr8zHUKsQKD4ai fk5Dexv7+Uo8fiWi7MS/sYUZyrhRwtmGKRdiH6/TbfYz4JH4pNQ5MW9lnRCuM0nh0Vr7 7WFEeDqbHhgLvReeQgbGI7lTtt6dhM1DrbUZ4KUYt1WuKh4ecKgNnoHHer5+GWb+q6kL VKyA== X-Gm-Message-State: ACrzQf3vqYBEth8fmupHNtUvkoGke9TSmlUaTeoZhrVn6HbwMT7/o64T 0gw0MpuEZouCcF3F+aC5tGU= X-Google-Smtp-Source: AMsMyM6/qMtYXfOb9sMZlghUptjRyYcuSU6AakPT4+aCBhB0cHXdoKH/wQKSzUALkR93qIrs+7A3TQ== X-Received: by 2002:a17:907:1690:b0:77c:37be:2345 with SMTP id hc16-20020a170907169000b0077c37be2345mr18459194ejc.359.1663716019170; Tue, 20 Sep 2022 16:20:19 -0700 (PDT) Date: Tue, 20 Sep 2022 23:20:11 +0000 From: Bernhard Beschow To: BALATON Zoltan , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 9/9] exec/address-spaces: Inline legacy functions In-Reply-To: <7411d60-2bc0-f927-752-56184958c790@eik.bme.hu> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-10-shentey@gmail.com> <7411d60-2bc0-f927-752-56184958c790@eik.bme.hu> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 09:02:41 UTC schrieb BALATON Zoltan : > > >On Tue, 20 Sep 2022, Philippe Mathieu-Daud=C3=A9 via wrote: > >> On 20/9/22 01:17, Bernhard Beschow wrote: >>> The functions just access a global pointer and perform some pointer >>> arithmetic on top=2E Allow the compiler to see through this by inlinin= g=2E >>=20 >> I thought about this while reviewing the previous patch, =2E=2E=2E >>=20 >>> Signed-off-by: Bernhard Beschow >>> --- >>> include/exec/address-spaces=2Eh | 30 ++++++++++++++++++++++++++---- >>> softmmu/physmem=2Ec | 28 ---------------------------- >>> 2 files changed, 26 insertions(+), 32 deletions(-) >>>=20 >>> diff --git a/include/exec/address-spaces=2Eh b/include/exec/address-sp= aces=2Eh >>> index b31bd8dcf0=2E=2E182af27cad 100644 >>> --- a/include/exec/address-spaces=2Eh >>> +++ b/include/exec/address-spaces=2Eh >>> @@ -23,29 +23,51 @@ >>> #ifndef CONFIG_USER_ONLY >>> +#include "hw/boards=2Eh" >>=20 >> =2E=2E=2E but I'm not a fan of including this header here=2E It is rest= ricted to system emulation, but still=2E=2E=2E Let see what the others thin= k=2E > >Had the same thought first if this would break user emulation but I don't= know how that works (and this include is withing !CONFIG_USER_ONLY)=2E I'v= e checked in configure now and it seems that softmmu is enabled/disabled wi= th system, which reminded me to a previous conversation where I've suggeste= d renaming softmmu to sysemu as that better shows what it's really used for= and maybe the real softmmu part should be split from it but I don't rememb= er the details=2E If it still works with --enable-user --disable-system the= n maybe it's OK and only confusing because of misnaming sysemu as softmmu= =2E I've compiled all architectures w/o any --{enable,disable}-{user,system} f= lags and I had compile errors only when putting the include outside the gua= rd=2E So this in particular doesn't seem to be a problem=2E Best regards, Bernhard > >Reagrds, >BALATON Zoltan > >>> /** >>> * Get the root memory region=2E This is a legacy function, provide= d for >>> * compatibility=2E Prefer using SysBusState::system_memory directly= =2E >>> */ >>> -MemoryRegion *get_system_memory(void); >>> +inline MemoryRegion *get_system_memory(void) >>> +{ >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Esystem_memory; >>> +} >>> /** >>> * Get the root I/O port region=2E This is a legacy function, provi= ded for >>> * compatibility=2E Prefer using SysBusState::system_io directly=2E >>> */ >>> -MemoryRegion *get_system_io(void); >>> +inline MemoryRegion *get_system_io(void) >>> +{ >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Esystem_io; >>> +} >>> /** >>> * Get the root memory address space=2E This is a legacy function, = provided for >>> * compatibility=2E Prefer using SysBusState::address_space_memory d= irectly=2E >>> */ >>> -AddressSpace *get_address_space_memory(void); >>> +inline AddressSpace *get_address_space_memory(void) >>> +{ >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Eaddress_space_memory; >>> +} >>> /** >>> * Get the root I/O port address space=2E This is a legacy function= , provided >>> * for compatibility=2E Prefer using SysBusState::address_space_io d= irectly=2E >>> */ >>> -AddressSpace *get_address_space_io(void); >>> +inline AddressSpace *get_address_space_io(void) >>> +{ >>> + assert(current_machine); >>> + >>> + return ¤t_machine->main_system_bus=2Eaddress_space_io; >>> +} >>> #endif >>> diff --git a/softmmu/physmem=2Ec b/softmmu/physmem=2Ec >>> index 07e9a9171c=2E=2Edce088f55c 100644 >>> --- a/softmmu/physmem=2Ec >>> +++ b/softmmu/physmem=2Ec >>> @@ -2674,34 +2674,6 @@ static void memory_map_init(SysBusState *sysbus= ) >>> address_space_init(&sysbus->address_space_io, system_io, "I/O"); >>> } >>> -MemoryRegion *get_system_memory(void) >>> -{ >>> - assert(current_machine); >>> - >>> - return ¤t_machine->main_system_bus=2Esystem_memory; >>> -} >>> - >>> -MemoryRegion *get_system_io(void) >>> -{ >>> - assert(current_machine); >>> - >>> - return ¤t_machine->main_system_bus=2Esystem_io; >>> -} >>> - >>> -AddressSpace *get_address_space_memory(void) >>> -{ >>> - assert(current_machine); >>> - >>> - return ¤t_machine->main_system_bus=2Eaddress_space_memory; >>> -} >>> - >>> -AddressSpace *get_address_space_io(void) >>> -{ >>> - assert(current_machine); >>> - >>> - return ¤t_machine->main_system_bus=2Eaddress_space_io; >>> -} >>> - >>> static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, >>> hwaddr length) >>> { >>=20 >>=20 >>=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 20 23:24:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 20 Sep 2022 23:24:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409608.652607 (Exim 4.92) (envelope-from ) id 1oamav-0005r1-2O; Tue, 20 Sep 2022 23:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409608.652607; Tue, 20 Sep 2022 23:24:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamau-0005qu-Vw; Tue, 20 Sep 2022 23:24:00 +0000 Received: by outflank-mailman (input) for mailman id 409608; Tue, 20 Sep 2022 23:24:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oamau-0005qo-AZ for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 23:24:00 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4df637d3-393b-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 01:23:59 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id y17so9824693ejo.6 for ; Tue, 20 Sep 2022 16:23:59 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id j22-20020a508a96000000b0044ed7a75c33sm689265edj.6.2022.09.20.16.23.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 16:23:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4df637d3-393b-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=qKZPVG5iME12/xaovZM6A6+qsWvmHnon3GYaJNYHOS8=; b=fCK9HNlTrRewEDKb1ki/vTFY3BFU4vzCnR5/5SporYyj2K3I0iIme7NT7sFxvxSWk3 umbS7mgSQHCv4vemkhsUb7I8ViXwtdzvdECA7Hg1aPJOJHkBgajnUvnzOd15ofRxvKPW 2NmhmYzO4jI0zH5j583BH2fYOyCqRhQagr8KEfGrHxwOvw9vpW0RHacBcO/xfLZqnbG9 JGQYdHCVFxtkFHNb5If1sypH5E1lsaKJVmD0Bts992LCNZLkqOhf1P9RqHOcsUAWXlWu d4YWu7xGj+i6DW0je9gZb13SoS+moDDgWL9JmB1tDOJPynLYKJKZy8VNJloyV8FGfrcV cuNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=qKZPVG5iME12/xaovZM6A6+qsWvmHnon3GYaJNYHOS8=; b=0qEUS3okSv3QwqoyQA/5lKghi34dbS3gMZj81WArZ8W6iWH0h+Ue/1RdUcOZXj0J1Z KTV5ltnm/01lr9IR1r7E2tmRu5pE3VyW2u7OM92pQWcJlMoO1pGkI1pLyAVX2B1cuMSi IL03SzyceUA0F79QLo0eLrN8RzOp4oKwKpjlBySmYRxmLxR1rwrUhgT2tuVQpBZb3AZS UpumV2eh5/8RcqWTb0uDCK7ap4RH3o29J6CUfRqlbT5fDD6LGCf2FSEXfBCSUVruXdzk jgfv1QeGi32Z3oTLkmx37VPbl4tyL+RCUWt4nosD8lUcIeaJOputhAg/E49Nl/mf3j7Z lj9A== X-Gm-Message-State: ACrzQf0/1T8N92CdJSH+T1fNqIVJfQTGai6bFojUQWn4GjojPu+VMI+c mJ4sidNjHm9HWovDXA+MV+4= X-Google-Smtp-Source: AMsMyM5RM/OVc3EykNVPTfjHa4cDBJJ/DnJiA70xAhCb8RUZeIR5sVs3l/o+BP+JEU8fpdRpHUyjcA== X-Received: by 2002:a17:906:eec9:b0:73d:c369:690f with SMTP id wu9-20020a170906eec900b0073dc369690fmr19058158ejb.767.1663716238901; Tue, 20 Sep 2022 16:23:58 -0700 (PDT) Date: Tue, 20 Sep 2022 23:23:52 +0000 From: Bernhard Beschow To: Markus Armbruster , Alistair Francis , Bin Meng , Palmer Dabbelt CC: "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState In-Reply-To: <87edw6xoog.fsf@pond.sub.org> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> Message-ID: <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 20=2E September 2022 11:36:47 UTC schrieb Markus Armbruster : >Alistair Francis writes: > >> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow = wrote: >>> >>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it = to >>> inherit from TYPE_MACHINE=2E This is an inconsistency which can cause >>> undefined behavior such as memory corruption=2E >>> >>> Change SiFiveEState to inherit from MachineState since it is registere= d >>> as a machine=2E >>> >>> Signed-off-by: Bernhard Beschow >> >> Reviewed-by: Alistair Francis > >To the SiFive maintainers: since this is a bug fix, let's merge it right >away=2E I could repost this particular patch with the three new tags (incl=2E Fixe= s) if desired=2E Best regards, Bernhard > From xen-devel-bounces@lists.xenproject.org Wed Sep 21 00:07:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 00:07:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409615.652619 (Exim 4.92) (envelope-from ) id 1oanH9-0002aH-4U; Wed, 21 Sep 2022 00:07:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409615.652619; Wed, 21 Sep 2022 00:07:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oanH9-0002aA-1L; Wed, 21 Sep 2022 00:07:39 +0000 Received: by outflank-mailman (input) for mailman id 409615; Wed, 21 Sep 2022 00:07:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oanH6-0002a4-GB for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 00:07:37 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6322cdb0-3941-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 02:07:33 +0200 (CEST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28KLO6Fe019476; Wed, 21 Sep 2022 00:07:17 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jn68m8qsp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Sep 2022 00:07:17 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28KML2UQ010044; Wed, 21 Sep 2022 00:07:16 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2043.outbound.protection.outlook.com [104.47.74.43]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3jp3c9j8xv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Sep 2022 00:07:16 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by IA0PR10MB6891.namprd10.prod.outlook.com (2603:10b6:208:431::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Wed, 21 Sep 2022 00:07:13 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcc6:79b8:7480:2ecf]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcc6:79b8:7480:2ecf%3]) with mapi id 15.20.5654.014; Wed, 21 Sep 2022 00:07:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6322cdb0-3941-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=wxAj1dsooMLWYa9kQGpGQGYctB2FsJobVOJeISzzBiQ=; b=CABg12kTLUKg88/DYHAPt9wNl8vBmJe637wjpxgI6sUPVEuQPnyPsBL9VyZoxdS+qmW0 wyfXyVttVBmnjdDJsROQXGcG/XY822m+uAFk8CZpmBykTDEo0pKWpihgoZ8pmSkpeJuF EThMkjGRhtfIqRROis8/O7g0WyuqSVVzifiZ7hSRE/GFfxjisY35Ty+5YlRm5MNiMjAZ O166WQ9RP7RK+IflOu5gBosMUkXQzXUMF0ExMhdoLcpt0V0alLaw/h0lrl8yy91q5lYA MSR9UpeJbikwCXxHsyJuo5pVLP92GJ/UMD8b3JLH/Fmu60NPRZtoBkq1bNH22Ma9pLyn 4A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ENv2E60xm7mvnRSUw2Uwm9PEy+jTVG3Unpy6/EyXOuEM3AngvpqS81IG/iq9zNy22ohgZ1B7/+GcE+8SjaEMKjXJJ9b4Zz90Sifkp/egQeaP5EWCp7m+now+2lFCS2o1DnGfTM7HQvrfYtbzEo+aMSXE3Kjbk+OO0QQFK7muywoFd47vzjjlBh476D9tX9fT7VO1VipARW1IYaB5PRkCVKgSuTD7L3NfA1rWkOzEeeEDSP8PKFGcEe68jz2GLJuUInsI1cmYYg7jQlNKzgZGza4PMLM4VreWAP8lH4XSqC4LucipOGSdW5dCc5+FD/NpBlsv335Jt3gVCF4RWN/YZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wxAj1dsooMLWYa9kQGpGQGYctB2FsJobVOJeISzzBiQ=; b=AdqobtVAo90/oGD5DdrGx0EtNRrU3pz1Ya7umfZTphC7jWw2NynkXdMHT5UJUwTVaFY1LPVQp6ggJsUBMfO42us1kIruVYxOAzhJCTWwkMg0tnb+gxl44uFt9HGsKg38IKeGDdSykmcfPfXH39xKMF/VnKswPkLbnp0MYemgW/9caZHRn5MxtbhTPT/C9aezsqQsQJUkRthQArOZ5W5pI9oWtwRVaDJ9PyecJ1RUom/QVIRyBEdIPwFcQgX3eTc3E5jVN56na46sEZPzllInT1OZQ244O7h5y/TihprKW6n4amX8UklgbBwpbqhHGFM/Et2+sv6M7/kvov+q//9yzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wxAj1dsooMLWYa9kQGpGQGYctB2FsJobVOJeISzzBiQ=; b=HwlRHzmBM2ti7c5qUSR45PCmOAU/dXPS+Vl4eVYe7MIOq8ZC58yh4y/nmgeKOPVlXKiLDQecH87tF3R/kLZyVivRpyjhkpyXeF7X1IMxoXcKWGgUHaTodECKa5X9S83IGpkrj2dQ+dEewvqClTgnw4M2klWrmkoCP2ZPVlxkAPI= Message-ID: <41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com> Date: Tue, 20 Sep 2022 20:07:09 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/4] x86/entry: Work around Clang __bdos() bug Content-Language: en-US To: Kees Cook , linux-hardening@vger.kernel.org Cc: Juergen Gross , Nathan Chancellor , Nick Desaulniers , xen-devel@lists.xenproject.org, llvm@lists.linux.dev, Siddhesh Poyarekar , Arnd Bergmann , Tom Rix , Miguel Ojeda , linux-kernel@vger.kernel.org References: <20220920192202.190793-1-keescook@chromium.org> <20220920192202.190793-2-keescook@chromium.org> From: Boris Ostrovsky In-Reply-To: <20220920192202.190793-2-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR07CA0077.namprd07.prod.outlook.com (2603:10b6:4:ad::42) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|IA0PR10MB6891:EE_ X-MS-Office365-Filtering-Correlation-Id: 1786657e-a9db-43f6-6fc1-08da9b653c90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OQ3q2iMwh06Y/xszLhiFw4SqLGhS59p3u22PKIViQqyZJ2OtROWExE/K4CfJrUa3r/NbtBwTy12NXvmYiBEjifIHtQieHWKbpV/soK0WC4Ij0md6UGhEuicLA2ydXwg6fmcEoGpfWslhJINtHElxMFTDxS2kvX5Qbko3npnkmvWcWV8IHMf098Vh/NYd/5SLm64Yu9zDF9XID+ucdBZMmZa4ofKqBVCdMj7XFv6qAIVbCC/jD/jazk+0uv/w3db4Awinr7lAZa4yG97mZCf3Ssa9fYqPzkEHbrhkkGb/SJYXmTOwCr9iqyce9aoDTLK0kcfWYNWopKJsnrj0695Th6rvisg/2K4FruVJe4k08s9G1+k8JCM8u9QHOjSKL0YzFeLZG2SeCWS+y12hatOJUgXNCEOoAhIvdqzlfLNBgma0RdYOneeIo0nEkPFJNfiImmOExWrUF1GuwL3IgpOQ8lfkqp4pz2Y04atvCBzjt9GyiQTthTsFFZHujreDj79lHgqkxtu0I1WtBUeouSGKliJ0BRaSC3sXPEVfhHVBlPRBSJdw/HHIYiu0X7LmYBecz3CZNJaWkUSYeRvntJGUChNwYxuVgOkUpfoViWGpqb0sLvZwJUrgmBJweeuDb786VstkCluZJDsjKsfXfAIsDU2ltp9shxiONAGIFwes4nr4Vc5JygaSWqanEzdkLgk+Rf4uyugLdakdNeAfOx6lwlrhI9+2d2+52AbzmiBR7RTPWAoB5gclRc7cOwZyTOkukEysmDnbFQVmzPevWyb63cIFY6Sm9Q5rSabeOcDYK6lDluXtVuwljBxF8BOT5qTmXxzPOdQTiMCS/q5DCJTxPA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199015)(8676002)(38100700002)(6666004)(26005)(53546011)(478600001)(6512007)(54906003)(6506007)(6486002)(316002)(966005)(186003)(83380400001)(36756003)(5660300002)(2906002)(44832011)(41300700001)(66476007)(66946007)(4326008)(8936002)(7416002)(2616005)(66556008)(31696002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFhCbHJTQS94MUhVS0VTZzNrdEk3QTBPang4eE05MHdHRUJJSTJMSHJvMHAx?= =?utf-8?B?WFAxeThZeGhVcXd2ZHpaWG9XQkRieEMzVTg3bmNzVy94b3UvRExLRVpSdEpa?= =?utf-8?B?cjhyTlhKQUZOTXU3NFdpQUxSR0M0eU10WGdtWGNqQjJBM0czMHl2dlBrTDNN?= =?utf-8?B?YUNSSlZ0cjdma1JHTFQyeXFIVXRqdEF5Rm9SSFhWd25FTXprSFI4UTY0dTZC?= =?utf-8?B?UGRZUEtvL0lvVitLQ3pRWElRNnZtT2ZZUkxuY29lZUl0em5lWmJNNXlMZFk2?= =?utf-8?B?SHRiVUpNaWhwdzl3Z1B4QjNuWTF4Njl2SFgwWlhZbmloV2IyOUhEQXFVSm54?= =?utf-8?B?S0tGZXl0cGlzZFB5RGpveXhjSC84RHFxQnpLOEF2cG5CTUpHMkhpVG9Hbnhy?= =?utf-8?B?dXp1OGhkTVFBTXlrMi9pNTJFSGRSTVo4dlAza0t0SHMyTHNReG5oa1dkdlhy?= =?utf-8?B?amJYdXZZb3JldE1id0laVDFDME5NU0NlYk40cEVnT0tNUWZmY29McytyZFFp?= =?utf-8?B?TXcvcWpHa0hJeVpzcDVlMVlZVE4yS2V3TU1WSjVaMHNQY3JGQ2oxWmVaUldW?= =?utf-8?B?VVI4MW5OYU5lVlh2ZkpVQXJiaU9TbnFmNXJZWS9ObXpCclRkYWxPUTJGRXAr?= =?utf-8?B?YXZiZUlmRlgrVEtWYlJBQXhOZ1p6TkhoaExtYnY2WDVjOU1sZXBHUEl0UUpX?= =?utf-8?B?b0Z5VFBLeVh5VFlZQUcyR2owWUhRNitvWkZKY25GenVyMkpNa0VzSWtubWZl?= =?utf-8?B?YWpJWDFuYzdVU3ZqdUR0OEFIeGN6aUNzR1BINi9Gd1hQeWFxamJaanBsNk9Y?= =?utf-8?B?K2w0c3luUUhoVXYzK2tQOG9oMGUvYnpWa3p2T0x5bFpXNDFxd29WK3NLV0Zl?= =?utf-8?B?YlV2NHpzdmNYcDV2dWZuTnpTeVRPeDRvdmhVdklYeldZaEk4dnM3a3kzWkN4?= =?utf-8?B?YUpQd1V6L2FxOG12b0hjajVjZ0VZaWJLamVMUFczVG90U3NWQ1J6eWR3aHVM?= =?utf-8?B?RG5sVzVYOHdWbmlQaWd1QWVzd0FrKzQ4R3pQYnVPTFlhVS9iOFV3eHArRWVL?= =?utf-8?B?bW1mR2ZFa2FlcWNhUVZZeUttMHc3QkE4RDlGSlEweXRrTmNlRUlyaWlxOUpT?= =?utf-8?B?bmYrakNsUGpxOG9LbHZpZ1I1cVpDcy9MbzUrNXhqeWlRMER5SlNmSzRDRjJT?= =?utf-8?B?bUNjSXBnL29JM2VETVNaM3A1WW9naGtYaXFtSy9MVkczZDZjMUg0UmVlZml3?= =?utf-8?B?WklDd1hPU0lJVmdvUHYyRUg3T3FLNE1qQVVwaWJtMVE5N2tvS1UreEV3aUhB?= =?utf-8?B?cC9KclVsdS9DWTljNjVWQUladkZXdXptcE5NSE9tejdkb2ZOZ0VCRXNCU0pK?= =?utf-8?B?RjlyL0UySGdmUDlHRjVYdFQzS0NzdS9oRkZOQVRIRzVidGlqM1I5OWNQdXUv?= =?utf-8?B?V1Q4OStBb0tFenlvdGhaOTFqblhBWkpJeWFUUGJuNDZVK1pJT3VsZXhJOWs4?= =?utf-8?B?TzdOdDRhSHZDYnhpY0pHVkFBUzVCVUFKZnB6cjNQQTlKSGQzUHJSUFJ5K3My?= =?utf-8?B?QWZQazZoRTdTQzhwZHZYVTE0Mms3a095N0t6amZrNDA1NkZOeEsyMVVNanh4?= =?utf-8?B?UlU0M01ORHByRmZnb2FCZFlMT3I0cmR3MTNCMHU5T1U2TUNuR3ZvcEU3VzFO?= =?utf-8?B?YUN6ZEYxdmpWQ0xlcEFHdjNOVStzeS90dy9CRHdqQno3SE9mQnVUL1VkbVBo?= =?utf-8?B?ZTNQYjBVTHluYTFPUnFKZGl3R0t4UTYrQjBzL0JWYnNWSmkwbStveFViTTlv?= =?utf-8?B?aVlHMmYvVTlCc0RuYUlCcWFOK0w5VndJNitsc1VOV294YXN5azB3Q2puMGNi?= =?utf-8?B?QUkrZUlrWEl3d2xqU3R2SjJmaktjWjROWllLLzBLbitUK3ladUFEM2FTUDdW?= =?utf-8?B?Y3QxenRmUzk0Z0RMSmpFNXRZYlk4MmpvNzdYQlNuaWUwTmtXWENDWUxuRER4?= =?utf-8?B?MTZVY242Z005VnMzdm0xSWRtNWpNTHZCaDRGUmw4d2ZUM2RzN3ByR2lvWklN?= =?utf-8?B?azF1UmZvN1ROKy9CcjRhWEFQNW52M1pQcGJPUUtrVUlLVjZlT3dKdXYyYzd5?= =?utf-8?B?b25DUmEyWWhQdCttL2RHQVpGdVVhTFJjdncwMjl1TmtvR2FsTGhIYW1vZDJ1?= =?utf-8?B?M2c9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1786657e-a9db-43f6-6fc1-08da9b653c90 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 00:07:13.7852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JHSQ69TMww8xNJvDKiAbm2oUkIgIUDjTZjYQbHILRaXdQMVIQfkYuTPLnVwfgxkKOM3FH9C95dNclkCcEmNxu/HkOSdnDEmQBNKs1OYqP/0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6891 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-20_12,2022-09-20_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209200147 X-Proofpoint-ORIG-GUID: IbdjaRH1e6CGFm4opeqXs-DwiVPJV2R3 X-Proofpoint-GUID: IbdjaRH1e6CGFm4opeqXs-DwiVPJV2R3 On 9/20/22 3:21 PM, Kees Cook wrote: > After expanding bounds checking to use __builtin_dynamic_object_size(), > Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y > and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic > offset. Work around this by using a direct assignment of an empty > instance. Avoids this warning: > > ../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn > ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat > tribute-warning] > __write_overflow_field(p_size_field, size); > ^ > > which was isolated to the memset() call in xen_load_idt(). > > Note that this looks very much like another bug that was worked around: > https://github.com/ClangBuiltLinux/linux/issues/1592 > > Cc: Juergen Gross > Cc: Boris Ostrovsky > Cc: Nathan Chancellor > Cc: Nick Desaulniers > Cc: xen-devel@lists.xenproject.org > Cc: llvm@lists.linux.dev > Signed-off-by: Kees Cook Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Wed Sep 21 00:56:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 00:56:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409628.652630 (Exim 4.92) (envelope-from ) id 1oao2b-00081O-15; Wed, 21 Sep 2022 00:56:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409628.652630; Wed, 21 Sep 2022 00:56:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oao2a-00081H-US; Wed, 21 Sep 2022 00:56:40 +0000 Received: by outflank-mailman (input) for mailman id 409628; Wed, 21 Sep 2022 00:56:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oao2Z-000817-GK; Wed, 21 Sep 2022 00:56:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oao2Z-0000Al-CD; Wed, 21 Sep 2022 00:56:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oao2Y-00008a-Ow; Wed, 21 Sep 2022 00:56:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oao2Y-0003dU-OQ; Wed, 21 Sep 2022 00:56:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3/7QbCFfIqNx9xvwCLfc/fEaJv649DQRNSUm3D5ibq4=; b=50Ip2Qa9bC5xspqqqC+EDRrYr7 oYFnQMKAFuajamWhwAhgCXDpUHWdF8S6EWWwUV/a8DizuWjUtLjjGMtmMDVDKtAY0KpgGQDjq3/aI 27W72p4NhchZHthBxvd9NJOy/9DMPa9jhDkEOkYpLGqSUNEYgyG2owTnPYfb/Pr2AHUU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173261: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:host-ping-check-xen:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=60891ec99e141b74544d11e897a245ef06263052 X-Osstest-Versions-That: linux=521a547ced6477c54b4b0cc206000406c221b4d6 From: osstest service owner Date: Wed, 21 Sep 2022 00:56:38 +0000 flight 173261 linux-linus real [real] flight 173263 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173261/ http://logs.test-lab.xenproject.org/osstest/logs/173263/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 10 host-ping-check-xen fail pass in 173263-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173263 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173263 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173257 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173257 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173257 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173257 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173257 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173257 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173257 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173257 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 60891ec99e141b74544d11e897a245ef06263052 baseline version: linux 521a547ced6477c54b4b0cc206000406c221b4d6 Last test of basis 173257 2022-09-18 23:40:54 Z 2 days Testing same since 173261 2022-09-20 17:42:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Vagin Andrei Vagin Christian Brauner (Microsoft) David Sterba Filipe Manana Kees Cook Linus Torvalds Naohiro Aota Tetsuo Handa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 521a547ced64..60891ec99e14 60891ec99e141b74544d11e897a245ef06263052 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Sep 21 01:19:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 01:19:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409636.652641 (Exim 4.92) (envelope-from ) id 1oaoOu-0000Og-Sb; Wed, 21 Sep 2022 01:19:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409636.652641; Wed, 21 Sep 2022 01:19:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaoOu-0000OZ-Pf; Wed, 21 Sep 2022 01:19:44 +0000 Received: by outflank-mailman (input) for mailman id 409636; Wed, 21 Sep 2022 01:19:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaoOt-0000OT-CK for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 01:19:43 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2071.outbound.protection.outlook.com [40.107.220.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 768b2a97-394b-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 03:19:40 +0200 (CEST) Received: from DS7PR12MB6006.namprd12.prod.outlook.com (2603:10b6:8:7d::19) by MW3PR12MB4441.namprd12.prod.outlook.com (2603:10b6:303:59::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Wed, 21 Sep 2022 01:19:36 +0000 Received: from DS7PR12MB6006.namprd12.prod.outlook.com ([fe80::9471:931d:b1ef:d8a6]) by DS7PR12MB6006.namprd12.prod.outlook.com ([fe80::9471:931d:b1ef:d8a6%7]) with mapi id 15.20.5654.014; Wed, 21 Sep 2022 01:19:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 768b2a97-394b-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q9EiOL/7a6kpKMD6HExfdHOZgQudH1+mcPtUomtQ0l9X4MzRb8GBotpB3XMmWpOCr5ZtQdV4gJeRNyJhaiahZT+GHy2mJ0DaBoJzEUqUj9/haxFU6bVNItHvvPuxDn869i9iVhdY5vmTSmBAztqRfj7EdP/C9e+cZCQSm7tAp/bfiqech4OREpBh7BnDrpVJTvncvtf1v9Zhg9S/ePxqZRtpTOMR3olwq0Ar9uHPhSqyQKM358SNVZQT2atq8uSewcMtpK4mfkZPiK1cG2EVn76RqKp3yNr72KWVPY/i/0PMByPL6coboHTbhcfhATKuYZzpx4kWVIPuFFoUUqp7cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lQSCFEVGlbV6AIA31BdYy0G7kngG8aXhhIxABFsbBDg=; b=m/Rv5w70eBmHPu4MLsXrHBr/zRiexTja7Koms/22cpsUiGQtDe01K3GQlTtu3WV/BtEt5ANbgElS9GijjCo+HtRzuNY/XrN2TZKCDq1j3UGSgrEUvkSQqZTNePXDCremN05Aypdnno4TxE2eE8DR9JYkDDcZUVCvBWnzcs6jI6AIfZ6i2TvjDXZOgH4JdLohyF8UNmWbV02oTbQSjh9hHNbFaOmoKcfe3KuTCN11HK9kdfdDjj4bcmrtXP7jzCSmu5sKJF8CzAVde4p9/yXjQ8xPZbX3UA9nn084mHSUndrJbwNs5AnhWxBvLxnUoU76U/C5Li3gAlWi8+w82xYJUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lQSCFEVGlbV6AIA31BdYy0G7kngG8aXhhIxABFsbBDg=; b=DsokLX8GNGIzX/PT3pOrnGWXivjW004uJa80waafVCfLP8Mtdp5tBXgYEZV6hIihPrRQicKslqg4XQLkxUjwGRbdufdUqlwuuMawfpkOuyWIXNRIhwY7/a0Z0k6ndMlJTEIGDialGVuGerah4YsxH3rWbC8ss6BvUm6XIXOYhdo= From: "Ji, Ruili" To: Paul Durrant , "qemu-devel@nongnu.org" , "anthony.perard@citrix.com" CC: "Liu, Aaron" , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Topic: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device Thread-Index: AdjBw9S5XjagBB9xT0W01YXm2Fq4yQAkLQ9gATHwuGAAP0mxgAAB/V+QAU1c5pA= Date: Wed, 21 Sep 2022 01:19:36 +0000 Message-ID: References: <8be84a25-c31d-fd88-f913-c03c15046a55@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fe71ddb2-53de-4503-92e7-b763c759a0b3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-14T10:04:41Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR12MB6006:EE_|MW3PR12MB4441:EE_ x-ms-office365-filtering-correlation-id: 6f45cfa1-b083-4e66-9f13-08da9b6f5953 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LtsR/xlK4inUCksRty8K4uH2WdUNw8Sn2wI0RiSsH3+xSekqZduOfK+jShtRhhpeN9QLC6VhjucHNsDPD9s5DA3jNmuUALNrxrM5JilnZ32p2tT65uhzWTv2EMnEa2tyIjP4oq3SNs61r857MlvMz+0cRqc1GadTxcLuAibx5X1pMKaQqMCqwBXx7nVmHlDwIANHzkZAt12HbvEHpPvZGip6QRE3og9EmfN99vGrLVlE68hs6cvmAO9dZGykySv4F8YbTWNiPKqTSpU2mvq66sNhcX9zG42HtVhrlo8aAj3zxHFhhvjxJFzNYWqJQAMp/T7wB9cdIWasa08xbCFER+di6Wdh+XdV+P9Zh7fFDELSpq2ovBD39ZuuhBFkPMmAsOerCJ8Yhm90iVyY3RClvoGXBCc/TekmTaWg3y64mZCD/OngFhC8aM+9CZX0mFgMXjvwctz1Sq93tyuySK+o3i4koo5zHNJg+uAE3byRn2sxoD6SbjYZayhyRhFDoGMPZJWokmaAwrGUJygYLZ0YEdB0+Jp5zPkhEGGO5i5ogjcWZrQ+72YsIebzLsXvY4EzzY/7h4R5WbWI6p7/vDEfNXDB2s/NvvLGIFRiixuDBigi03I5K8DJ2H13M+ebYkyzA/teWs3ipvKVenr7MrfNw1qgK8vKl+7aaBUd4AdqRJCp3CUgAwH6VjoBaqLVvQCcEUIk1RawQiG4E5S10doGRugOU+BIGYjBwgy8nUHzVxQ99kXlzEB2C0m3xmbphcRRfVIUOnZXlsSqwatLFpwOMSO2GlrSSXGbdxmT6pIcqGuLY+288Q7syIGlwcOFk4NOAMAzl5crYQIgQNqA+a8nRw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB6006.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199015)(5660300002)(66899012)(2906002)(52536014)(71200400001)(186003)(6506007)(53546011)(8936002)(7696005)(9686003)(41300700001)(26005)(38100700002)(4326008)(33656002)(76116006)(66946007)(64756008)(66556008)(66476007)(66446008)(478600001)(122000001)(45080400002)(38070700005)(86362001)(8676002)(316002)(110136005)(966005)(54906003)(83380400001)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TEJaUXlmT1JQWW5ZS2VuRHNuZWFkU0pPM3pYbm43cXptYWNxK2pvUkFKdFJ4?= =?utf-8?B?djJXQy9Rd0NJR3R6cnlwU0RRMHVqZXl5Tk00OXV3aENzRldTemRUMmNKMWZT?= =?utf-8?B?YWVXV0NXa3BlNFoyeDY4cGRRK3dYYzA0alBjTWVOOTZxZWZLSTE0cDNrNW5K?= =?utf-8?B?T0J4VmJhMWtNZ1dPanpVWmZ6TlUyeU1HeHhxWkFuYW04d1Zld0UvRDNidU5V?= =?utf-8?B?YWx5SEhPMFRWQ0RUenEwTFN6TFNidjhhZ0Y4QWRMdUtER2NaUkxSNURkRzRk?= =?utf-8?B?anEzbFdLMDZnVlBXenBETkV5MFQ2M1h3cFI2aFJ1dEJnc1FWVHIwd2VCTFFZ?= =?utf-8?B?V2l5bDRxV0lmMStKVmVDVGRZOEhwMklMeEVTenpjYUJJWE9LaEp4NnpldDJH?= =?utf-8?B?cXd3bHVidFdlaW14amI0dndaRE92YkE4VlkzNTRpYmVYTm5MQTgzYm8rcFFT?= =?utf-8?B?QW5IU25qRGp5TWplZXpJR21lOUx5a2YwVHBqV2p3NDFKMHZVVWlic2R5VHZm?= =?utf-8?B?elcyNHBLeGZ5TW16SStqcmpGdDJMK0FLdVdVY2V5WUR5cXpxZ2M5RE8rZWl4?= =?utf-8?B?WjNGaFdVNnlQQ3VNOExBdkxUUlp2aWMzQ2tPV1dPeDZBZVFVanN5R2wySzBH?= =?utf-8?B?T2dndDR5NlgrNkFxb1dUNDdLZnlXNDFRVEd3QllrSVJBRkNwNmN6eXprbmVU?= =?utf-8?B?eTJLeWd6NmpYbFRSYnNLYlI2OS8xZGRUQlh3SERWdEhWL3JsWHN1K2V6ei9E?= =?utf-8?B?dEZvSVljTDE4ZUM0ajR4RldLM1A2MXJCcUNoQkVCM0o3aExYQytMM0RGQkdX?= =?utf-8?B?K25pSDEzek05TGxncEZXSkhJZVpXT25XWG0yUkwxNkJwOXZQTFlKeG1kLytD?= =?utf-8?B?Y1Q4aDN1NlVtdFY1T1R5SjJOckJLYUQ5cjNnTEd4cU85WktSVWVQZ1NxOW9X?= =?utf-8?B?SFZjTUlURFpsSjlSZkZ4NU5vckJwWUMvb1dLa0Y4RW9IL2dYSXYwdWV2S01r?= =?utf-8?B?b0FiRUJtdzE5V2VBalRqYjBSZHZIL0cxeUsvclRWYmswWEEyemw1WHgrN1hQ?= =?utf-8?B?djlMNFhvU0dEV2JEWTNnM09FTGVhbUVWSnFwT1E3Uk1UOHM2M3Z4RDhmNU5x?= =?utf-8?B?WVV3b09YMGxqN3Z6c1FSUll2Uk9kWVZBOGQrRGJHcFBwbnZONkxzbTBsMk9L?= =?utf-8?B?QTNyKzdoNUhaWHFmeTZrRXo1aUVQK1pRMDlQWnJrci9McHJDbjhpbThMcDdh?= =?utf-8?B?ejlzTk95L0YvMUpmM2M3SkUvK2xySVFaL0dkR0daUDQrbE1LcWNIK0YwOVJZ?= =?utf-8?B?TnlEVnVzOERuTDlwMlZKYStFOVhlZEs4YXhqL1l0NWNaTm5XYXBFZ3JIbGo5?= =?utf-8?B?NXVIdXJUemdwL25KeXNPcCthSy9TWTN0dXJpS3VYdnhQR05xM1NsTXFDOG03?= =?utf-8?B?VWYvOGFhZUdaODh6RXhYVzBwY2cyRkh0NUV3bjA3WDBOZWlxREVnVnJCMFp6?= =?utf-8?B?NUlwWnQwc3ZaTnVKd1pUbkRLR0NZTVFuSVU3cEs1NWNSMmc4V2VNMWV4TDU5?= =?utf-8?B?NHNIUm52UU93U2NBUXFmQ1dCeU9QMXRzcmM0V0RYY3dxc2dHZjhwTGZDbEZC?= =?utf-8?B?NGhmQ2pOeXZXdTNiT1pwbGIwajhTeVpJVUpFSnJJa1RqRlVaNFRMYlNuWnFY?= =?utf-8?B?RUVmV0xoMUsrNTVDV3dEd1ZrYUlZaHZ5Z2tKcy8yamRpNmhOekVFMkZFRjR3?= =?utf-8?B?STdqWTkrNEZJaHk1cXpSczJGVUd0QkJkUGxyK1gvbHFwK2l5b00vWnlMNkdN?= =?utf-8?B?bGdveFpFclZhRjdTY3JHYkh0dk9ub1FlakhLU2tFR0hoODViNVNRMHY5OWVF?= =?utf-8?B?OFQwNVJuMEo2OXdoTE43Q3pnR1BUOFJEdFRUVUV5aE8wZkF3U1lCZlZNd3pS?= =?utf-8?B?Vnp6QmJHOVY0TDEzRnRsTk5DMTZOMnA1NFBiaThxbCsrR2dIMXJwN3JIdElI?= =?utf-8?B?YUtqbjI4elZTKzFPOXUrRUwzM1Jrd01TYTdraTRLZkR5WHN6V24zVXdYMHhO?= =?utf-8?B?b3ZuL2hBdkp5K1ZhbVdKMGdLZWcwM0dGYkJLMk9GWlF5bUVrNktoRkJPMG5x?= =?utf-8?Q?ihi3Aq6RE7mH3hcXkhVSWmno/?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6006.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f45cfa1-b083-4e66-9f13-08da9b6f5953 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 01:19:36.8467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: icXRq8BS/s677MomlAFaeN0IF2eFcDH+IKBmD7Yc5Oo6omJDoa4X0KDRryjiDpqZpsGnZIFxI/idxwT40GCqEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4441 W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEdlbmVyYWxdDQoNCkhpIFBhdWwgYW5kIEFGQUlLOg0K DQpUaGFua3MgZm9yIHlvdXIgaGVscC4NCldoZW4gY291bGQgd2Ugc2VlIHRoaXMgcGF0Y2ggb24g dGhlIG1hc3RlciBicmFuY2g/IPCfmIoNCk91ciBwcm9qZWN0IHVyZ2VudGx5IG5lZWRzIHRoaXMg c29sdXRpb24uDQoNClRoYW5rcyENClJ1aWxpDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t DQpGcm9tOiBQYXVsIER1cnJhbnQNClN1YmplY3Q6IFJFOiBbUEFUQ0hdIGh3L3hlbjogc2V0IHBj aSBBdG9taWMgT3BzIHJlcXVlc3RzIGZvciBwYXNzdGhyb3VnaCBkZXZpY2UNCk9uIDE0LzA5LzIw MjIgMDM6MDcsIEppLCBSdWlsaSB3cm90ZToNCltBTUQgT2ZmaWNpYWwgVXNlIE9ubHkgLSBHZW5l cmFsXQ0KDQpIaSBQYXVsLA0KDQpUaGFuayB5b3UhDQpCdXQgaG93IGNvdWxkIHdlIG1lcmdlIHRo aXMgcGF0Y2ggPw0KDQoNCkFGQUlLIEFudGhvbnkgKGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20p IHN0aWxsIGRlYWxzIHdpdGggdGhpcy4NCg0KQ2hlZXJzLA0KDQogIFBhdWwNCg0KLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEppLCBSdWlsaQ0KU2VudDogMjAyMuW5tDnmnIgxNOaX pSAxODowOA0KVG86IFBhdWwgRHVycmFudCA8eGFkaW1nbmlrQGdtYWlsLmNvbT47IHFlbXUtZGV2 ZWxAbm9uZ251Lm9yZw0KQ2M6IExpdSwgQWFyb24gPEFhcm9uLkxpdUBhbWQuY29tPjsgeGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQpTdWJqZWN0OiBSRTogW1BBVENIXSBody94ZW46IHNl dCBwY2kgQXRvbWljIE9wcyByZXF1ZXN0cyBmb3IgcGFzc3Rocm91Z2ggZGV2aWNlDQoNCkhpIFBh dWwsDQoNClRoYW5rIHlvdSENCkJ1dCBob3cgY291bGQgd2UgbWVyZ2UgdGhpcyBwYXRjaCA/DQoN ClJ1aWxpDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogUGF1bCBEdXJyYW50IDx4 YWRpbWduaWtAZ21haWwuY29tPg0KU2VudDogMjAyMuW5tDnmnIgxNOaXpSAxNzowOA0KVG86IEpp LCBSdWlsaSA8UnVpbGkuSmlAYW1kLmNvbT47IHFlbXUtZGV2ZWxAbm9uZ251Lm9yZw0KQ2M6IExp dSwgQWFyb24gPEFhcm9uLkxpdUBhbWQuY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnDQpTdWJqZWN0OiBSZTogW1BBVENIXSBody94ZW46IHNldCBwY2kgQXRvbWljIE9wcyByZXF1 ZXN0cyBmb3IgcGFzc3Rocm91Z2ggZGV2aWNlDQoNCkNhdXRpb246IFRoaXMgbWVzc2FnZSBvcmln aW5hdGVkIGZyb20gYW4gRXh0ZXJuYWwgU291cmNlLiBVc2UgcHJvcGVyIGNhdXRpb24gd2hlbiBv cGVuaW5nIGF0dGFjaG1lbnRzLCBjbGlja2luZyBsaW5rcywgb3IgcmVzcG9uZGluZy4NCg0KDQpP biAxMy8wOS8yMDIyIDA0OjAyLCBKaSwgUnVpbGkgd3JvdGU6DQo+IFtBTUQgT2ZmaWNpYWwgVXNl IE9ubHkgLSBHZW5lcmFsXQ0KPg0KPg0KPiBIaSBQYXVsLA0KPg0KPiBDb3VsZCB5b3UgaGVscCB0 byByZXZpZXcgdGhpcyBwYXRjaD8NCj4NCg0KTEdUTS4gWW91IGNhbiBhZGQgbXkgUi1iIHRvIGl0 Lg0KDQogICBQYXVsDQoNCj4gVGhhbmtzDQo+DQo+ICpGcm9tOiogSmksIFJ1aWxpDQo+ICpTZW50 OiogMjAyMuW5tDnmnIg35pelIDk6MDQNCj4gKlRvOiogJ1BhdWwgRHVycmFudCcgPHBhdWxAeGVu Lm9yZz47ICdxZW11LWRldmVsQG5vbmdudS5vcmcnDQo+IDxxZW11LWRldmVsQG5vbmdudS5vcmc+ DQo+ICpDYzoqIExpdSwgQWFyb24gPEFhcm9uLkxpdUBhbWQuY29tPjsgJ3hlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZycNCj4gPHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4NCj4g KlN1YmplY3Q6KiBSRTogW1BBVENIXSBody94ZW46IHNldCBwY2kgQXRvbWljIE9wcyByZXF1ZXN0 cyBmb3INCj4gcGFzc3Rocm91Z2ggZGV2aWNlDQo+DQo+IEZZSQ0KPg0KPiAqRnJvbToqIEppLCBS dWlsaQ0KPiAqU2VudDoqIDIwMjLlubQ55pyINuaXpSAxNTo0MA0KPiAqVG86KiBxZW11LWRldmVs QG5vbmdudS5vcmcgPG1haWx0bzpxZW11LWRldmVsQG5vbmdudS5vcmc+DQo+ICpDYzoqIExpdSwg QWFyb24gPEFhcm9uLkxpdUBhbWQuY29tIDxtYWlsdG86QWFyb24uTGl1QGFtZC5jb20+Pg0KPiAq U3ViamVjdDoqIFtQQVRDSF0gaHcveGVuOiBzZXQgcGNpIEF0b21pYyBPcHMgcmVxdWVzdHMgZm9y IHBhc3N0aHJvdWdoDQo+IGRldmljZQ0KPg0KPiAgRnJvbSBjNTRlMDcxNGExZTFjYWM3ZGM0MTZi ZDg0M2I5ZWM3MTYyYmNmYzQ3IE1vbiBTZXAgMTcgMDA6MDA6MDANCj4gMjAwMQ0KPg0KPiBGcm9t OiBSdWlsaSBKaSBydWlsaS5qaUBhbWQuY29tIDxtYWlsdG86cnVpbGkuamlAYW1kLmNvbT4NCj4N Cj4gRGF0ZTogVHVlLCA2IFNlcCAyMDIyIDE0OjA5OjQxICswODAwDQo+DQo+IFN1YmplY3Q6IFtQ QVRDSF0gaHcveGVuOiBzZXQgcGNpIEF0b21pYyBPcHMgcmVxdWVzdHMgZm9yIHBhc3N0aHJvdWdo DQo+IGRldmljZQ0KPg0KPiBNYWtlIGd1ZXN0IG9zIGFjY2VzcyBwY2kgZGV2aWNlIGNvbnRyb2wg MiByZWcgZm9yIHBhc3N0aHJvdWdoIGRldmljZQ0KPg0KPiBhcyBzdHJ1Y3QgWGVuUFRSZWdJbmZv IGRlc2NyaWJlZCBpbiB0aGUgZmlsZSBody94ZW4veGVuX3B0LmguDQo+DQo+IC8qIHJlZyByZWFk IG9ubHkgZmllbGQgbWFzayAoT046Uk8vUk9TLCBPRkY6b3RoZXIpICovDQo+DQo+IHVpbnQzMl90 IHJvX21hc2s7DQo+DQo+IC8qIHJlZyBlbXVsYXRlIGZpZWxkIG1hc2sgKE9OOmVtdSwgT0ZGOnBh c3N0aHJvdWdoKSAqLw0KPg0KPiB1aW50MzJfdCBlbXVfbWFzazsNCj4NCj4gUmVzb2x2ZXM6DQo+ IGh0dHBzOi8vbmFtMTEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9vay5jb20vP3VybD1odHRw cyUzQSUyRiUyRmdpdGwNCj4gYWIuY29tJTJGcWVtdS1wcm9qZWN0JTJGcWVtdSUyRi0lMkZpc3N1 ZXMlMkYxMTk2JmFtcDtkYXRhPTA1JTdDMDElN0NSdQ0KPiBpbGkuSmklNDBhbWQuY29tJTdDYTVl MmMyMmE4MTU0NGZlYjZiYjQwOGRhOTYzMDk3MDIlN0MzZGQ4OTYxZmU0ODg0ZTYwDQo+IDhlMTFh ODJkOTk0ZTE4M2QlN0MwJTdDMCU3QzYzNzk4NzQzMjY4OTc0ODIxMiU3Q1Vua25vd24lN0NUV0Zw Ykdac2IzZDgNCj4gZXlKV0lqb2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJ azFoYVd3aUxDSlhWQ0k2TW4wJTNEJTdDMw0KPiAwMDAlN0MlN0MlN0MmYW1wO3NkYXRhPUpnODU4 OEZXa0laem1TRXl0NTBUWUNiY2syTnVvVkpkbTdaUDBaJTJGdEZHYyUzDQo+IEQmYW1wO3Jlc2Vy dmVkPTANCj4gPGh0dHBzOi8vbmFtMTEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9vay5jb20v P3VybD1odHRwcyUzQSUyRiUyRmdpdA0KPiBsYWIuY29tJTJGcWVtdS1wcm9qZWN0JTJGcWVtdSUy Ri0lMkZpc3N1ZXMlMkYxMTk2JmFtcDtkYXRhPTA1JTdDMDElN0NSDQo+IHVpbGkuSmklNDBhbWQu Y29tJTdDYTVlMmMyMmE4MTU0NGZlYjZiYjQwOGRhOTYzMDk3MDIlN0MzZGQ4OTYxZmU0ODg0ZTYN Cj4gMDhlMTFhODJkOTk0ZTE4M2QlN0MwJTdDMCU3QzYzNzk4NzQzMjY4OTc0ODIxMiU3Q1Vua25v d24lN0NUV0ZwYkdac2IzZA0KPiA4ZXlKV0lqb2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklp TENKQlRpSTZJazFoYVd3aUxDSlhWQ0k2TW4wJTNEJTdDDQo+IDMwMDAlN0MlN0MlN0MmYW1wO3Nk YXRhPUpnODU4OEZXa0laem1TRXl0NTBUWUNiY2syTnVvVkpkbTdaUDBaJTJGdEZHYyUNCj4gM0Qm YW1wO3Jlc2VydmVkPTA+DQo+DQo+IFNpZ25lZC1vZmYtYnk6IEFhcm9uLkxpdUBhbWQuY29tIDxt YWlsdG86QWFyb24uTGl1QGFtZC5jb20+DQo+DQo+IFNpZ25lZC1vZmYtYnk6IHJ1aWxpLmppQGFt ZC5jb20gPG1haWx0bzpydWlsaS5qaUBhbWQuY29tPg0KPg0KPiAtLS0NCj4NCj4gaHcveGVuL3hl bl9wdF9jb25maWdfaW5pdC5jIHwgNCArKy0tDQo+DQo+IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9ody94ZW4veGVuX3B0 X2NvbmZpZ19pbml0LmMgYi9ody94ZW4veGVuX3B0X2NvbmZpZ19pbml0LmMNCj4NCj4gaW5kZXgg YzVjNGU5NDNhOC4uYWRjNTY1YTAwYSAxMDA2NDQNCj4NCj4gLS0tIGEvaHcveGVuL3hlbl9wdF9j b25maWdfaW5pdC5jDQo+DQo+ICsrKyBiL2h3L3hlbi94ZW5fcHRfY29uZmlnX2luaXQuYw0KPg0K PiBAQCAtOTg1LDggKzk4NSw4IEBAIHN0YXRpYyBYZW5QVFJlZ0luZm8geGVuX3B0X2VtdV9yZWdf cGNpZVtdID0gew0KPg0KPiAgICAgICAgICAgLm9mZnNldCAgICAgPSAweDI4LA0KPg0KPiAgICAg ICAgICAgLnNpemUgICAgICAgPSAyLA0KPg0KPiAgICAgICAgICAgLmluaXRfdmFsICAgPSAweDAw MDAsDQo+DQo+IC0gICAgICAgIC5yb19tYXNrICAgID0gMHhGRkUwLA0KPg0KPiAtICAgICAgICAu ZW11X21hc2sgICA9IDB4RkZGRiwNCj4NCj4gKyAgICAgICAgLnJvX21hc2sgICAgPSAweEZGQTAs DQo+DQo+ICsgICAgICAgIC5lbXVfbWFzayAgID0gMHhGRkJGLA0KPg0KPiAgICAgICAgICAgLmlu aXQgICAgICAgPSB4ZW5fcHRfZGV2Y3RybDJfcmVnX2luaXQsDQo+DQo+ICAgICAgICAgICAudS53 LnJlYWQgICA9IHhlbl9wdF93b3JkX3JlZ19yZWFkLA0KPg0KPiAgICAgICAgICAgLnUudy53cml0 ZSAgPSB4ZW5fcHRfd29yZF9yZWdfd3JpdGUsDQo+DQo+IC0tDQo+DQo+IDIuMzQuMQ0KPg0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 21 02:16:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 02:16:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409645.652652 (Exim 4.92) (envelope-from ) id 1oapHo-0007CT-7d; Wed, 21 Sep 2022 02:16:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409645.652652; Wed, 21 Sep 2022 02:16:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oapHo-0007CL-1D; Wed, 21 Sep 2022 02:16:28 +0000 Received: by outflank-mailman (input) for mailman id 409645; Wed, 21 Sep 2022 02:16:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oapHm-0007CF-QP for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 02:16:26 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 642cc364-3953-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 04:16:25 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id s14-20020a17090a6e4e00b0020057c70943so12728457pjm.1 for ; Tue, 20 Sep 2022 19:16:25 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id y1-20020a623201000000b0053e9ecf58f0sm661954pfy.20.2022.09.20.19.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 19:16:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 642cc364-3953-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=GnHGtgHj033COJKahffZStPIaXE02OICjJM2Z9aEkfE=; b=ArRr74et4U1zLmXiJOghTrTMnedfdbF7K14oBBpNIc8qTkREGPO5v04fI1k1kbyrLx aE9AvyteVh2+qhO2Mdb8OF0GMzIxHqqYA7AHgEMHz8m3ZBG0PwqpaX4uoFIQTg10zUkz MwCcQnpBOkDxcL5Yt6/9QvFFjyx7CVdOExmelt+4nQuFpw3m7saN/EepKWFmT1xTW4Wv coNsRQJPCjqBxC2R2jbd/LOVOzubUoQ1Gm37yLcX/MfefYirEknZw/ktLHoEDM/P0J76 fX0JWbhPys/CYrKJKqNQ6liKGabibcgJBuAF6GH29Vno10Zq+ui/epuVMeLTYcPMphfm nFIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=GnHGtgHj033COJKahffZStPIaXE02OICjJM2Z9aEkfE=; b=2Okv56k4AU5aNiRCUQtAntEt/20qOz/5DzGmsIwHWE5zwhZyq9OZHF5SSvdo8cRNib dNGwMrH0491wt4+84mKwxZ1l9C7yL0BV7TrQpjudKOIsrMxt5o6AlyRr5wE56GJ+ekdZ LuTXqo0GJWq3e9pIGjl+F4eRY+xoSR++lPJd3bY5J8uEwWybk206Ln8ClZ9X3ly5wciv 6QGpE5uaMcZK7t3EdZZNQqDCt6SseCSNLlHVTHIUi/8xPUhdQfROgn6fqauJJ+JvLmnG C4yCTmlQpbDiFIG+u//OWAQ0r8A+e5VrI70IPF3FrJKjZOuIkogs/2x1LegdrSeTtbgp lB3g== X-Gm-Message-State: ACrzQf34Oc3oa7Xs0A3aVTqTqMKN6rOP6nTRVaYAkHKuYywTFdhrcxD4 cPoGCOPVEwiPJS4U+6X23GoapeOW9aQ= X-Google-Smtp-Source: AMsMyM7MRypGCQbUxoyrc6WNFpMb9PFhoALdU/NO7Lw8H72HCSj9ZvzMDFM2cHVsH6lG7m+CxkybYQ== X-Received: by 2002:a17:90a:8909:b0:203:ab27:a41 with SMTP id u9-20020a17090a890900b00203ab270a41mr7073542pjn.163.1663726584165; Tue, 20 Sep 2022 19:16:24 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: wei.liu@kernel.org Cc: paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] xen-netback: use kstrdup instead of open-coding it Date: Wed, 21 Sep 2022 02:16:17 +0000 Message-Id: <20220921021617.217784-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Minghao Chi use kstrdup instead of open-coding it. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/net/xen-netback/xenbus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index e85b3c5d4acc..c1ba4294f364 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -865,13 +865,12 @@ static int connect_data_rings(struct backend_info *be, * queue-N. */ if (num_queues == 1) { - xspath = kzalloc(strlen(dev->otherend) + 1, GFP_KERNEL); + xspath = kstrdup(dev->otherend, GFP_KERNEL); if (!xspath) { xenbus_dev_fatal(dev, -ENOMEM, "reading ring references"); return -ENOMEM; } - strcpy(xspath, dev->otherend); } else { xspathsize = strlen(dev->otherend) + xenstore_path_ext_size; xspath = kzalloc(xspathsize, GFP_KERNEL); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 21 04:55:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 04:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409654.652663 (Exim 4.92) (envelope-from ) id 1oarlT-0006gD-AU; Wed, 21 Sep 2022 04:55:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409654.652663; Wed, 21 Sep 2022 04:55:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oarlT-0006g6-7A; Wed, 21 Sep 2022 04:55:15 +0000 Received: by outflank-mailman (input) for mailman id 409654; Wed, 21 Sep 2022 04:55:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oarlS-0006g0-87 for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 04:55:14 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9325cb2e-3969-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 06:55:13 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-JDdO1-4NNtms04LwtNgKXw-1; Wed, 21 Sep 2022 00:55:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67BF02999B47; Wed, 21 Sep 2022 04:55:05 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFABE2024CC8; Wed, 21 Sep 2022 04:55:03 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C2B8221E6900; Wed, 21 Sep 2022 06:55:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9325cb2e-3969-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663736111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d0ewimBIuzA4pcXzNcXQGF6URaG5NO+EI7K2JWsTSM0=; b=BvmOz6rLkGiZWGUSJW3b2OY790xekYjtpHk9Y0+xJPAoG44NDocZBpxlJ+c7vVdNcF3+ki 7YQ/ylqOYuHdIqLUv1gjQCtgoQh8+gXVH/wzpbc/pZxASKHdvEKUPNHKNuHGbfv7/mn6M5 jU9BfET7q23RZSXJ2QRDijRktZCxkdw= X-MC-Unique: JDdO1-4NNtms04LwtNgKXw-1 From: Markus Armbruster To: Bernhard Beschow Cc: Alistair Francis , Bin Meng , Palmer Dabbelt , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Christian Borntraeger , =?utf-8?Q?C=C3=A9dric?= Le Goater , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?utf-8?Q?Herv=C3=A9?= Poussineau , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> Date: Wed, 21 Sep 2022 06:55:02 +0200 In-Reply-To: <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> (Bernhard Beschow's message of "Tue, 20 Sep 2022 23:23:52 +0000") Message-ID: <87a66tgwd5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Bernhard Beschow writes: > Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster : >>Alistair Francis writes: >> >>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >>>> >>>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to >>>> inherit from TYPE_MACHINE. This is an inconsistency which can cause >>>> undefined behavior such as memory corruption. >>>> >>>> Change SiFiveEState to inherit from MachineState since it is registered >>>> as a machine. >>>> >>>> Signed-off-by: Bernhard Beschow >>> >>> Reviewed-by: Alistair Francis >> >>To the SiFive maintainers: since this is a bug fix, let's merge it right >>away. > > I could repost this particular patch with the three new tags (incl. Fixes) if desired. Can't hurt, and could help the maintainers. From xen-devel-bounces@lists.xenproject.org Wed Sep 21 05:30:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 05:30:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409659.652674 (Exim 4.92) (envelope-from ) id 1oasJV-0002uE-UD; Wed, 21 Sep 2022 05:30:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409659.652674; Wed, 21 Sep 2022 05:30:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oasJV-0002u7-RF; Wed, 21 Sep 2022 05:30:25 +0000 Received: by outflank-mailman (input) for mailman id 409659; Wed, 21 Sep 2022 05:30:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oasJU-0002tx-Il; Wed, 21 Sep 2022 05:30:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oasJU-0004Tl-Ec; Wed, 21 Sep 2022 05:30:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oasJT-0004hL-Pk; Wed, 21 Sep 2022 05:30:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oasJT-0005Ni-PJ; Wed, 21 Sep 2022 05:30:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3ot1TXIWg5j984TVdvGG9JaVOgzeOHsNIRglesqK7Fw=; b=M9XmQoPgEz8x/RRuoAjhZCEF5S hlGQz/JFpGZlnh98vEkfM8+NGt1v+VeldZ3O4/qYMxjhbrrH3nLJ6diBLbArLapZhrqy6MCr/jTX6 37gUFdgdohqZDLZLCAdJR5vks43UY0NJDTknV9zHgsgq0BUimaymyYyUBYgyd0Wuz7KU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173262: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=832e9e33bc51f52fc3ea667d48912e95af3e28f3 X-Osstest-Versions-That: qemuu=d29201ff34a135cdfc197f4413c1c5047e4f58bb From: osstest service owner Date: Wed, 21 Sep 2022 05:30:23 +0000 flight 173262 qemu-mainline real [real] flight 173265 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173262/ http://logs.test-lab.xenproject.org/osstest/logs/173265/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 173265-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 173253 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173253 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173253 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173253 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173253 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173253 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173253 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 173253 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173253 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173253 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 832e9e33bc51f52fc3ea667d48912e95af3e28f3 baseline version: qemuu d29201ff34a135cdfc197f4413c1c5047e4f58bb Last test of basis 173253 2022-09-17 22:39:53 Z 3 days Testing same since 173262 2022-09-20 20:37:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Song Gao Stefan Hajnoczi Xiaojuan Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git d29201ff34..832e9e33bc 832e9e33bc51f52fc3ea667d48912e95af3e28f3 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Sep 21 07:13:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 07:13:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409675.652685 (Exim 4.92) (envelope-from ) id 1oatui-0004xI-A5; Wed, 21 Sep 2022 07:12:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409675.652685; Wed, 21 Sep 2022 07:12:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oatui-0004xB-7P; Wed, 21 Sep 2022 07:12:56 +0000 Received: by outflank-mailman (input) for mailman id 409675; Wed, 21 Sep 2022 07:12:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oatug-0004x5-U6 for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 07:12:55 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce7fda81-397c-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 09:12:52 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id y8so7234302edc.10 for ; Wed, 21 Sep 2022 00:12:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce7fda81-397c-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=1JiDs7V+4f98plIl3cAhkJt+w1xLDXvBJQw7S0oK/FE=; b=I1VF09mfcLUl7blx/POh4vUFo6kAMhyZoYVlM80m6pJ24kBivzN02nuhK/E3xGFiwJ TChWIgrhAJXZ4qkcAjZRVp6kYcwNjvb4rJ8wdszRoiKyxFN9JW24RXnqwxMR7NqFjMHu SUK629wL1bSq8EHaaFB98+TxO7AnkfFa29yys/7X2tqTslh7xl/Xu5CFJD+QojlyVBxQ Yh6yv748I+idH4lQABwKwqrtAbntseiXVZoybZgeBDb7p0yfn/wMnMnlkRDEK+MNHhaw ztN2UJ3rz1ldqVW8IBhVntz5G0DDWoAR+Yv8BWxLi3VhbcizX4mnipk/KIpfGnebW54K DEbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=1JiDs7V+4f98plIl3cAhkJt+w1xLDXvBJQw7S0oK/FE=; b=XMcqDUq0As9RpYde9GOl9kg+tAhI6NnH+ssfytRximzP0frE12Z/eu2x1ASnNxUPXS ytHzVUP/6YesFoZmz37FXp6eceTzijtaJW6BKziOvLyCWb4LSc5k1sYkiau+nEmbfsJ9 8RopUA37p5d2xkpCPOKHh3U21hYdFjlDq3Xh7xbbufzHwersMnWTXqoZvdWxxb+5dFdP TorkNa4hHdv/f8YmZQKPy9cW2uyGGveW3xhIxPNqxiCSTEMt3eP2OCOEYgBVg/gZLuQZ 20oWkS521BWTmF48ec1QqjhBCVnLD1kG+yB7P7iWbgIxGXyePZeFPTxmyu+yn+uZFaIv o33w== X-Gm-Message-State: ACrzQf2bhWnqEBy86m5REA8WOCBmhFYHe+KIeyCoUvD2LJT0hRY3wdyp jhq/4/8YffrgyOARdibhsM9QoAgSKhH15xxU88vnbWaNxPY= X-Google-Smtp-Source: AMsMyM7qS0f7wIYJgNev9UGsmYf5Cw7853tswfxpMkiiLGlY3Nr7uu72BzaU8IAR2XFoVul/OP3KCFOAkrdAwuk3KyM= X-Received: by 2002:aa7:c517:0:b0:453:99b0:49f9 with SMTP id o23-20020aa7c517000000b0045399b049f9mr18079359edq.70.1663744371653; Wed, 21 Sep 2022 00:12:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: A Sudheer Date: Wed, 21 Sep 2022 12:42:39 +0530 Message-ID: Subject: Re: USB-C 250GB SSD Passthrough fails to DomU Ubuntu To: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="00000000000045017305e92aac32" --00000000000045017305e92aac32 Content-Type: text/plain; charset="UTF-8" Hi All I tried in qemu-KVM and able to mount USBC 250GB SATA on to guest vm. Able to add the hardware to VM from virt-manager. In host, qemu_system_x86-6 4 is used. But i am not able to mount in DomU when tried in xen setup. In Dom0, qemu_system_i386 is used. Tried copying qemu-system-x86_64 to qemu_system_i386. Still issue observed. Anyone aware what could be missing in xen setup compared to KVM setup ? Thanks Sudheer On Wed, Sep 7, 2022 at 4:31 PM A Sudheer wrote: > Hi All, > > Is anyone aware if this a general limitation of DomU Or is there a way to > convince DomU to expose USB host controllers with streams support ? > > Thanks > Sudheer > > On Tue, Aug 30, 2022 at 1:34 PM A Sudheer wrote: > >> Few more logs >> >> From Dom0, did passthrough of two USB drives (32GB stick and 250GB USB >> SDD) >> In DomU, 32GB driver got mounted but 250GB SSD fails to mount. >> In DomU, "lsusb" shows both the drives but "usb-devices" shows only the >> 32GB drive. >> >> *Dom0 log:* >> amd@HOST:~$ sudo xl usb-list vm1 >> Devid Type BE state usb-ver ports >> 0 devicemodel 0 0 3 15 >> Port 1: Bus 003 Device 002 >> Port 2: Bus 005 Device 002 >> Port 3: >> Port 4: >> Port 5: >> Port 6: >> Port 7: >> Port 8: >> Port 9: >> Port 10: >> Port 11: >> Port 12: >> Port 13: >> Port 14: >> Port 15: >> HOST:~$ >> >> *DomU Log:* >> amd@VM1:~$ lsusb >> Bus 003 Device 003: ID 0781:558c SanDisk Corp. Extreme Portable SSD >> Bus 003 Device 002: ID 0781:5581 SanDisk Corp. Ultra >> Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub >> Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub >> Bus 001 Device 002: ID 0627:0001 Adomax Technology Co., Ltd QEMU USB >> Tablet >> Bus 001 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub >> amd@VM1:~$ >> >> *amd@VM1:~$ usb-devices* >> >> T: Bus=01 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=12 MxCh= 2 >> D: Ver= 1.10 Cls=09(hub ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >> P: Vendor=1d6b ProdID=0001 Rev=05.18 >> S: Manufacturer=Linux 5.18.0-4460-amd+ uhci_hcd >> S: Product=UHCI Host Controller >> S: SerialNumber=0000:00:01.2 >> C: #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=00 Driver=hub >> E: Ad=81(I) Atr=03(Int.) MxPS= 2 Ivl=255ms >> >> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs= 1 >> P: Vendor=0627 ProdID=0001 Rev=00.00 >> S: Manufacturer=QEMU >> S: Product=QEMU USB Tablet >> S: SerialNumber=42 >> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=100mA >> I: If#= 0 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid >> E: Ad=81(I) Atr=03(Int.) MxPS= 8 Ivl=10ms >> >> T: Bus=02 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=480 MxCh=15 >> D: Ver= 2.00 Cls=09(hub ) Sub=00 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=1d6b ProdID=0002 Rev=05.18 >> S: Manufacturer=Linux 5.18.0-4460-amd+ xhci-hcd >> S: Product=xHCI Host Controller >> S: SerialNumber=0000:00:04.0 >> C: #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=00 Driver=hub >> E: Ad=81(I) Atr=03(Int.) MxPS= 4 Ivl=256ms >> >> T: Bus=03 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=5000 MxCh=15 >> D: Ver= 3.00 Cls=09(hub ) Sub=00 Prot=03 MxPS= 9 #Cfgs= 1 >> P: Vendor=1d6b ProdID=0003 Rev=05.18 >> S: Manufacturer=Linux 5.18.0-4460-amd+ xhci-hcd >> S: Product=xHCI Host Controller >> S: SerialNumber=0000:00:04.0 >> C: #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=00 Driver=hub >> E: Ad=81(I) Atr=03(Int.) MxPS= 4 Ivl=256ms >> >> T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 >> D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1 >> P: Vendor=0781 ProdID=5581 Rev=01.00 >> S: Manufacturer= USB >> *S: Product= SanDisk 3.2Gen1* >> S: >> SerialNumber=040143504c9a3bd4596082500826a11868845df4396ebc5cb2e33dd3071e3fd5505f000000000000000000003ca6a60b000d7c18815581071b2a7c33 >> C: #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=896mA >> I: If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage >> E: Ad=02(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms >> E: Ad=81(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms >> amd@VM1:~$ >> >> *amd@VM1:~$ sudo dmesg * >> >> [ 247.071742] usb 3-2: new SuperSpeed USB device number 3 using xhci_hcd >> [ 247.097304] usb 3-2: New USB device found, idVendor=0781, >> idProduct=558c, bcdDevice=10.12 >> [ 247.097314] usb 3-2: New USB device strings: Mfr=2, Product=3, >> SerialNumber=1 >> [ 247.097318] usb 3-2: Product: Extreme SSD >> [ 247.097321] usb 3-2: Manufacturer: SanDisk >> [ 247.097323] usb 3-2: SerialNumber: 31393430475A343030363932 >> [ 247.101909] usb 3-2: USB controller 0000:00:04.0 does not support >> streams, which are required by the UAS driver. >> [ 247.101915] usb 3-2: Please try an other USB controller if you wish to >> use UAS. >> [ 247.101918] usb-storage 3-2:1.0: USB Mass Storage device detected >> [ 247.102710] scsi host3: usb-storage 3-2:1.0 >> [ 269.131522] usb 3-2: reset SuperSpeed USB device number 3 using >> xhci_hcd >> >> *DomU dmesg log while adding USB controller and USB 32GB disk* >> >> [ 94.494852] pci 0000:00:04.0: [1033:0194] type 00 class 0x0c0330 >> [ 94.496278] pci 0000:00:04.0: reg 0x10: [mem 0x00000000-0x00003fff >> 64bit] >> [ 94.502161] pci 0000:00:04.0: BAR 0: assigned [mem >> 0xf1800000-0xf1803fff 64bit] >> [ 94.502981] pci 0000:00:04.0: enabling device (0000 -> 0002) >> [ 94.504005] xen: --> pirq=24 -> irq=32 (gsi=32) >> [ 94.514634] xhci_hcd 0000:00:04.0: xHCI Host Controller >> [ 94.514650] xhci_hcd 0000:00:04.0: new USB bus registered, assigned >> bus number 2 >> [ 94.517840] xhci_hcd 0000:00:04.0: hcc params 0x00080001 hci version >> 0x100 quirks 0x0000000000000014 >> [ 94.523559] usb usb2: New USB device found, idVendor=1d6b, >> idProduct=0002, bcdDevice= 5.18 >> [ 94.523571] usb usb2: New USB device strings: Mfr=3, Product=2, >> SerialNumber=1 >> [ 94.523575] usb usb2: Product: xHCI Host Controller >> [ 94.523579] usb usb2: Manufacturer: Linux 5.18.0-4460-amd+ xhci-hcd >> [ 94.523581] usb usb2: SerialNumber: 0000:00:04.0 >> [ 94.523974] hub 2-0:1.0: USB hub found >> [ 94.524850] hub 2-0:1.0: 15 ports detected >> [ 94.529968] xhci_hcd 0000:00:04.0: xHCI Host Controller >> [ 94.529981] xhci_hcd 0000:00:04.0: new USB bus registered, assigned >> bus number 3 >> [ 94.529988] xhci_hcd 0000:00:04.0: Host supports USB 3.0 SuperSpeed >> [ 94.530354] usb usb3: We don't know the algorithms for LPM for this >> host, disabling LPM. >> [ 94.530400] usb usb3: New USB device found, idVendor=1d6b, >> idProduct=0003, bcdDevice= 5.18 >> [ 94.530404] usb usb3: New USB device strings: Mfr=3, Product=2, >> SerialNumber=1 >> [ 94.530407] usb usb3: Product: xHCI Host Controller >> [ 94.530410] usb usb3: Manufacturer: Linux 5.18.0-4460-amd+ xhci-hcd >> [ 94.530412] usb usb3: SerialNumber: 0000:00:04.0 >> [ 94.530653] hub 3-0:1.0: USB hub found >> [ 94.531482] hub 3-0:1.0: 15 ports detected >> [ 157.522609] usb 3-1: new SuperSpeed USB device number 2 using xhci_hcd >> [ 157.548225] usb 3-1: New USB device found, idVendor=0781, >> idProduct=5581, bcdDevice= 1.00 >> [ 157.548236] usb 3-1: New USB device strings: Mfr=1, Product=2, >> SerialNumber=3 >> [ 157.548239] usb 3-1: Product: SanDisk 3.2Gen1 >> [ 157.548242] usb 3-1: Manufacturer: USB >> [ 157.548244] usb 3-1: SerialNumber: >> 040143504c9a3bd4596082500826a11868845df4396ebc5cb2e33dd3071e3fd5505f000000000000000000003ca6a60b000d7c18815581071b2a7c33 >> [ 157.571419] usb-storage 3-1:1.0: USB Mass Storage device detected >> [ 157.571981] scsi host2: usb-storage 3-1:1.0 >> [ 157.572125] usbcore: registered new interface driver usb-storage >> [ 157.577381] usbcore: registered new interface driver uas >> [ 158.581138] scsi 2:0:0:0: Direct-Access USB SanDisk 3.2Gen1 >> 1.00 PQ: 0 ANSI: 6 >> [ 158.581550] sd 2:0:0:0: Attached scsi generic sg0 type 0 >> [ 158.584622] sd 2:0:0:0: [sda] 60088320 512-byte logical blocks: (30.8 >> GB/28.7 GiB) >> [ 158.590171] sd 2:0:0:0: [sda] Write Protect is off >> [ 158.590181] sd 2:0:0:0: [sda] Mode Sense: 43 00 00 00 >> [ 158.593387] sd 2:0:0:0: [sda] Write cache: disabled, read cache: >> enabled, doesn't support DPO or FUA >> [ 158.614589] sda: sda1 >> [ 158.627564] sd 2:0:0:0: [sda] Attached SCSI removable disk >> >> >> On Tue, Aug 30, 2022 at 11:12 AM A Sudheer wrote: >> >>> Hi All >>> >>> On XEN-4.16 with Ubuntu 22.04 Dom0 and HVM-DomU, I tried to do a USB >>> mass storage device passthrough to DomU. >>> I followed the PVUSB method mentioned in >>> https://wiki.xenproject.org/wiki/Xen_USB_Passthrough. >>> >>> I am able to do passthrough for USB 2.0 and 3.x version 32/64 GB mass >>> storage devices to DomU. >>> Passthrough failed for "SanDisk 250GB SSD USB-C, USB 3.1" with below >>> error. Able to access the SSD in Dom0. >>> Can someone help with what could be missing here. >>> >>> *Commands used:* >>> host$ sudo xl usbctrl-attach vm1 version=3 ports=6 >>> host$ sudo xl usbdev-attach vm1 hostbus=3 hostaddr=2 >>> >>> *Error Log in DomU* >>> VM1:~$ sudo dmesg >>> [ 152.841566] usb 2-1: new SuperSpeed USB device number 2 using xhci_hcd >>> [ 152.867164] usb 2-1: New USB device found, idVendor=0781, >>> idProduct=558c, bcdDevice=10.12 >>> [ 152.867173] usb 2-1: New USB device strings: Mfr=2, Product=3, >>> SerialNumber=1 >>> [ 152.867177] usb 2-1: Product: Extreme SSD >>> [ 152.867179] usb 2-1: Manufacturer: SanDisk >>> [ 152.867182] usb 2-1: SerialNumber: 31393430475A343030363932 >>> [ 152.899103] *usb 2-1: USB controller 0000:00:04.0 does not support >>> streams, which are required by the UAS driver.* >>> [ 152.899110] usb 2-1: Please try an other USB controller if you wish >>> to use UAS. >>> [ 152.899113] usb-storage 2-1:1.0: USB Mass Storage device detected >>> [ 152.902033] scsi host2: usb-storage 2-1:1.0 >>> [ 152.902174] usbcore: registered new interface driver usb-storage >>> [ 152.908928] usbcore: registered new interface driver uas >>> [ 174.933399] usb 2-1: reset SuperSpeed USB device number 2 using >>> xhci_hcd >>> >>> Thanks >>> Sudheer >>> >> --00000000000045017305e92aac32 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All

I tried in qemu-KVM and able to = mount USBC 250GB SATA on to guest vm. Able to add the hardware to VM from v= irt-manager.=C2=A0 In host, qemu_system_x86-6 4 is used.=C2=A0
But i am not able to mount in DomU when tried in xen setup. In= Dom0, qemu_system_i386 is used. Tried copying qemu-system-x86_64 to qemu_s= ystem_i386. Still issue observed.

Anyone aware wha= t could be missing in xen setup compared to KVM setup ?

Thanks
Sudheer

On Wed, Sep 7, 2022 at 4:31 PM A Sudhee= r <asr7247@gmail.com> wrote:=
Hi All,

Is anyone aware if this a general limitation of DomU Or i= s there a way to convince DomU to expose USB host controllers with streams = support ?

Thanks
Sudheer

On Tue, Aug 30, 2022 at 1:34 PM= A Sudheer <asr72= 47@gmail.com> wrote:
Few more logs

From Dom0, di= d passthrough of two USB drives (32GB stick and 250GB USB SDD)
In= DomU, 32GB driver got mounted but 250GB SSD fails to mount.
In D= omU, "lsusb" shows both the drives but "usb-devices"=C2= =A0shows only the 32GB drive.

Dom0 log:
amd@HOST:~$ sudo xl usb-list vm1
Devid =C2=A0Type =C2=A0 =C2=A0 = =C2=A0 =C2=A0 BE =C2=A0state usb-ver ports
0 =C2=A0 =C2=A0 =C2=A0devicem= odel =C2=A00 =C2=A0 0 =C2=A0 =C2=A0 3 =C2=A0 =C2=A0 =C2=A0 15
=C2=A0 Por= t 1: Bus 003 Device 002
=C2=A0 Port 2: Bus 005 Device 002
=C2=A0 Port= 3:
=C2=A0 Port 4:
=C2=A0 Port 5:
=C2=A0 Port 6:
=C2=A0 Port 7:=
=C2=A0 Port 8:
=C2=A0 Port 9:
=C2=A0 Port 10:
=C2=A0 Port 11:<= br>=C2=A0 Port 12:
=C2=A0 Port 13:
=C2=A0 Port 14:
=C2=A0 Port 15:=
HOST:~$

DomU Log:
= amd@VM1:~$ lsusb
Bus 003 Device 003: ID 0781:558c SanDisk Corp. Extreme = Portable SSD
Bus 003 Device 002: ID 0781:5581 SanDisk Corp. Ultra
Bus= 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 002 Devi= ce 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: I= D 0627:0001 Adomax Technology Co., Ltd QEMU USB Tablet
Bus 001 Device 00= 1: ID 1d6b:0001 Linux Foundation 1.1 root hub
amd@VM1:~$
<= br>
amd@VM1:~$ usb-devices

T: =C2=A0Bus=3D01 Lev=3D= 00 Prnt=3D00 Port=3D00 Cnt=3D00 Dev#=3D =C2=A01 Spd=3D12 =C2=A0MxCh=3D 2D: =C2=A0Ver=3D 1.10 Cls=3D09(hub =C2=A0) Sub=3D00 Prot=3D00 MxPS=3D64 #Cf= gs=3D =C2=A01
P: =C2=A0Vendor=3D1d6b ProdID=3D0001 Rev=3D05.18
S: =C2= =A0Manufacturer=3DLinux 5.18.0-4460-amd+ uhci_hcd
S: =C2=A0Product=3DUHC= I Host Controller
S: =C2=A0SerialNumber=3D0000:00:01.2
C: =C2=A0#Ifs= =3D 1 Cfg#=3D 1 Atr=3De0 MxPwr=3D0mA
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D = 1 Cls=3D09(hub =C2=A0) Sub=3D00 Prot=3D00 Driver=3Dhub
E: =C2=A0Ad=3D81(= I) Atr=3D03(Int.) MxPS=3D =C2=A0 2 Ivl=3D255ms

T: =C2=A0Bus=3D01 Lev= =3D01 Prnt=3D01 Port=3D00 Cnt=3D01 Dev#=3D =C2=A02 Spd=3D12 =C2=A0MxCh=3D 0=
D: =C2=A0Ver=3D 2.00 Cls=3D00(>ifc ) Sub=3D00 Prot=3D00 MxPS=3D 8 #C= fgs=3D =C2=A01
P: =C2=A0Vendor=3D0627 ProdID=3D0001 Rev=3D00.00
S: = =C2=A0Manufacturer=3DQEMU
S: =C2=A0Product=3DQEMU USB Tablet
S: =C2= =A0SerialNumber=3D42
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3Da0 MxPwr=3D100mA=
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 1 Cls=3D03(HID =C2=A0) Sub=3D00 Prot= =3D00 Driver=3Dusbhid
E: =C2=A0Ad=3D81(I) Atr=3D03(Int.) MxPS=3D =C2=A0 = 8 Ivl=3D10ms

T: =C2=A0Bus=3D02 Lev=3D00 Prnt=3D00 Port=3D00 Cnt=3D00= Dev#=3D =C2=A01 Spd=3D480 MxCh=3D15
D: =C2=A0Ver=3D 2.00 Cls=3D09(hub = =C2=A0) Sub=3D00 Prot=3D01 MxPS=3D64 #Cfgs=3D =C2=A01
P: =C2=A0Vendor=3D= 1d6b ProdID=3D0002 Rev=3D05.18
S: =C2=A0Manufacturer=3DLinux 5.18.0-4460= -amd+ xhci-hcd
S: =C2=A0Product=3DxHCI Host Controller
S: =C2=A0Seria= lNumber=3D0000:00:04.0
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3De0 MxPwr=3D0mA=
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 1 Cls=3D09(hub =C2=A0) Sub=3D00 Prot= =3D00 Driver=3Dhub
E: =C2=A0Ad=3D81(I) Atr=3D03(Int.) MxPS=3D =C2=A0 4 I= vl=3D256ms

T: =C2=A0Bus=3D03 Lev=3D00 Prnt=3D00 Port=3D00 Cnt=3D00 D= ev#=3D =C2=A01 Spd=3D5000 MxCh=3D15
D: =C2=A0Ver=3D 3.00 Cls=3D09(hub = =C2=A0) Sub=3D00 Prot=3D03 MxPS=3D 9 #Cfgs=3D =C2=A01
P: =C2=A0Vendor=3D= 1d6b ProdID=3D0003 Rev=3D05.18
S: =C2=A0Manufacturer=3DLinux 5.18.0-4460= -amd+ xhci-hcd
S: =C2=A0Product=3DxHCI Host Controller
S: =C2=A0Seria= lNumber=3D0000:00:04.0
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3De0 MxPwr=3D0mA=
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 1 Cls=3D09(hub =C2=A0) Sub=3D00 Prot= =3D00 Driver=3Dhub
E: =C2=A0Ad=3D81(I) Atr=3D03(Int.) MxPS=3D =C2=A0 4 I= vl=3D256ms

T: =C2=A0Bus=3D03 Lev=3D01 Prnt=3D01 Port=3D00 Cnt=3D01 D= ev#=3D =C2=A02 Spd=3D5000 MxCh=3D 0
D: =C2=A0Ver=3D 3.20 Cls=3D00(>if= c ) Sub=3D00 Prot=3D00 MxPS=3D 9 #Cfgs=3D =C2=A01
P: =C2=A0Vendor=3D0781= ProdID=3D5581 Rev=3D01.00
S: =C2=A0Manufacturer=3D USB
S: =C2=A0P= roduct=3D SanDisk 3.2Gen1
S: =C2=A0SerialNumber=3D040143504c9a3bd459= 6082500826a11868845df4396ebc5cb2e33dd3071e3fd5505f000000000000000000003ca6a= 60b000d7c18815581071b2a7c33
C: =C2=A0#Ifs=3D 1 Cfg#=3D 1 Atr=3D80 MxPwr= =3D896mA
I: =C2=A0If#=3D 0 Alt=3D 0 #EPs=3D 2 Cls=3D08(stor.) Sub=3D06 P= rot=3D50 Driver=3Dusb-storage
E: =C2=A0Ad=3D02(O) Atr=3D02(Bulk) MxPS=3D= 1024 Ivl=3D0ms
E: =C2=A0Ad=3D81(I) Atr=3D02(Bulk) MxPS=3D1024 Ivl=3D0ms<= br>amd@VM1:~$

amd@VM1:~$ sudo dmesg = <for 250GB USB-C SSD>

[ =C2=A0247.071742] usb 3-2: new Sup= erSpeed USB device number 3 using xhci_hcd
[ =C2=A0247.097304] usb 3-2: = New USB device found, idVendor=3D0781, idProduct=3D558c, bcdDevice=3D10.12<= br>[ =C2=A0247.097314] usb 3-2: New USB device strings: Mfr=3D2, Product=3D= 3, SerialNumber=3D1
[ =C2=A0247.097318] usb 3-2: Product: Extreme SSD[ =C2=A0247.097321] usb 3-2: Manufacturer: SanDisk
[ =C2=A0247.097323] = usb 3-2: SerialNumber: 31393430475A343030363932
[ =C2=A0247.101909] usb = 3-2: USB controller 0000:00:04.0 does not support streams, which are requir= ed by the UAS driver.
[ =C2=A0247.101915] usb 3-2: Please try an other U= SB controller if you wish to use UAS.
[ =C2=A0247.101918] usb-storage 3-= 2:1.0: USB Mass Storage device detected
[ =C2=A0247.102710] scsi host3: = usb-storage 3-2:1.0
[ =C2=A0269.131522] usb 3-2: reset SuperSpeed USB de= vice number 3 using xhci_hcd

DomU dmesg log= while adding USB controller and USB 32GB disk

[ =C2=A0 94.494852] pci 0000:00:04.0: [1033:0194] type 00 class 0x0= c0330
[ =C2=A0 94.496278] pci 0000:00:04.0: reg 0x10: [mem 0x00000000-0x= 00003fff 64bit]
[ =C2=A0 94.502161] pci 0000:00:04.0: BAR 0: assigned [m= em 0xf1800000-0xf1803fff 64bit]
[ =C2=A0 94.502981] pci 0000:00:04.0: en= abling device (0000 -> 0002)
[ =C2=A0 94.504005] xen: --> pirq=3D2= 4 -> irq=3D32 (gsi=3D32)
[ =C2=A0 94.514634] xhci_hcd 0000:00:04.0: x= HCI Host Controller
[ =C2=A0 94.514650] xhci_hcd 0000:00:04.0: new USB b= us registered, assigned bus number 2
[ =C2=A0 94.517840] xhci_hcd 0000:0= 0:04.0: hcc params 0x00080001 hci version 0x100 quirks 0x0000000000000014[ =C2=A0 94.523559] usb usb2: New USB device found, idVendor=3D1d6b, idPr= oduct=3D0002, bcdDevice=3D 5.18
[ =C2=A0 94.523571] usb usb2: New USB de= vice strings: Mfr=3D3, Product=3D2, SerialNumber=3D1
[ =C2=A0 94.523575]= usb usb2: Product: xHCI Host Controller
[ =C2=A0 94.523579] usb usb2: M= anufacturer: Linux 5.18.0-4460-amd+ xhci-hcd
[ =C2=A0 94.523581] usb usb= 2: SerialNumber: 0000:00:04.0
[ =C2=A0 94.523974] hub 2-0:1.0: USB hub f= ound
[ =C2=A0 94.524850] hub 2-0:1.0: 15 ports detected
[ =C2=A0 94.5= 29968] xhci_hcd 0000:00:04.0: xHCI Host Controller
[ =C2=A0 94.529981] x= hci_hcd 0000:00:04.0: new USB bus registered, assigned bus number 3
[ = =C2=A0 94.529988] xhci_hcd 0000:00:04.0: Host supports USB 3.0 SuperSpeed[ =C2=A0 94.530354] usb usb3: We don't know the algorithms for LPM fo= r this host, disabling LPM.
[ =C2=A0 94.530400] usb usb3: New USB device= found, idVendor=3D1d6b, idProduct=3D0003, bcdDevice=3D 5.18
[ =C2=A0 94= .530404] usb usb3: New USB device strings: Mfr=3D3, Product=3D2, SerialNumb= er=3D1
[ =C2=A0 94.530407] usb usb3: Product: xHCI Host Controller
[ = =C2=A0 94.530410] usb usb3: Manufacturer: Linux 5.18.0-4460-amd+ xhci-hcd[ =C2=A0 94.530412] usb usb3: SerialNumber: 0000:00:04.0
[ =C2=A0 94.5= 30653] hub 3-0:1.0: USB hub found
[ =C2=A0 94.531482] hub 3-0:1.0: 15 po= rts detected
[ =C2=A0157.522609] usb 3-1: new SuperSpeed USB device numb= er 2 using xhci_hcd
[ =C2=A0157.548225] usb 3-1: New USB device found, i= dVendor=3D0781, idProduct=3D5581, bcdDevice=3D 1.00
[ =C2=A0157.548236] = usb 3-1: New USB device strings: Mfr=3D1, Product=3D2, SerialNumber=3D3
= [ =C2=A0157.548239] usb 3-1: Product: =C2=A0SanDisk 3.2Gen1
[ =C2=A0157.= 548242] usb 3-1: Manufacturer: =C2=A0USB
[ =C2=A0157.548244] usb 3-1: Se= rialNumber: 040143504c9a3bd4596082500826a11868845df4396ebc5cb2e33dd3071e3fd= 5505f000000000000000000003ca6a60b000d7c18815581071b2a7c33
[ =C2=A0157.57= 1419] usb-storage 3-1:1.0: USB Mass Storage device detected
[ =C2=A0157.= 571981] scsi host2: usb-storage 3-1:1.0
[ =C2=A0157.572125] usbcore: reg= istered new interface driver usb-storage
[ =C2=A0157.577381] usbcore: re= gistered new interface driver uas
[ =C2=A0158.581138] scsi 2:0:0:0: Dire= ct-Access =C2=A0 =C2=A0 =C2=A0USB =C2=A0 =C2=A0 =C2=A0SanDisk 3.2Gen1 1.00 = PQ: 0 ANSI: 6
[ =C2=A0158.581550] sd 2:0:0:0: Attached scsi generic sg0 = type 0
[ =C2=A0158.584622] sd 2:0:0:0: [sda] 60088320 512-byte logical b= locks: (30.8 GB/28.7 GiB)
[ =C2=A0158.590171] sd 2:0:0:0: [sda] Write Pr= otect is off
[ =C2=A0158.590181] sd 2:0:0:0: [sda] Mode Sense: 43 00 00 = 00
[ =C2=A0158.593387] sd 2:0:0:0: [sda] Write cache: disabled, read cac= he: enabled, doesn't support DPO or FUA
[ =C2=A0158.614589] =C2=A0sd= a: sda1
[ =C2=A0158.627564] sd 2:0:0:0: [sda] Attached SCSI removable di= sk


On Tue, Aug 30, 2022 at 11:12 AM A Sudheer <<= a href=3D"mailto:asr7247@gmail.com" target=3D"_blank">asr7247@gmail.com= > wrote:
Hi All

On XEN-4.16 with Ubuntu 22.04 Dom0 and HVM-DomU,= I tried to do a USB mass storage device passthrough to DomU.
I followed= the PVUSB method mentioned in https://wiki.xenproject.org/wiki/Xen= _USB_Passthrough.

I am able to do passthrough for USB 2.0 and 3.= x version 32/64 GB mass storage devices to DomU.=C2=A0
Passthrough faile= d for "SanDisk 250GB SSD USB-C, USB 3.1" with below error. Able t= o access the SSD in Dom0.
Can someone help with what could be missing h= ere.

Commands=C2=A0used:
host$ sudo xl usbctrl-attach v= m1 version=3D3 ports=3D6
host$ sudo xl usbdev-attach vm1 hostb= us=3D3 hostaddr=3D2

<= /span>
Error Log in Do= mU
VM1:~$ sudo dmesg
[ =C2=A0152.841566] usb= 2-1: new SuperSpeed USB device number 2 using xhci_hcd
[ =C2=A0152.8671= 64] usb 2-1: New USB device found, idVendor=3D0781, idProduct=3D558c, bcdDe= vice=3D10.12
[ =C2=A0152.867173] usb 2-1: New USB device strings: Mfr=3D= 2, Product=3D3, SerialNumber=3D1
[ =C2=A0152.867177] usb 2-1: Product: E= xtreme SSD
[ =C2=A0152.867179] usb 2-1: Manufacturer: SanDisk
[ =C2= =A0152.867182] usb 2-1: SerialNumber: 31393430475A343030363932
[ =C2=A01= 52.899103] usb 2-1: USB controller 0000:00:04.0 does not support streams= , which are required by the UAS driver.
[ =C2=A0152.899110] usb 2-1:= Please try an other USB controller if you wish to use UAS.
[ =C2=A0152.= 899113] usb-storage 2-1:1.0: USB Mass Storage device detected
[ =C2=A015= 2.902033] scsi host2: usb-storage 2-1:1.0
[ =C2=A0152.902174] usbcore: r= egistered new interface driver usb-storage
[ =C2=A0152.908928] usbcore:= registered new interface driver uas
[ =C2=A0174.933399] usb = 2-1: reset SuperSpeed USB device number 2 using xhci_hcd

=
Thanks
Sudheer
--00000000000045017305e92aac32-- From xen-devel-bounces@lists.xenproject.org Wed Sep 21 08:59:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 08:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409688.652696 (Exim 4.92) (envelope-from ) id 1oavZQ-0007Ue-7L; Wed, 21 Sep 2022 08:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409688.652696; Wed, 21 Sep 2022 08:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oavZQ-0007UX-40; Wed, 21 Sep 2022 08:59:04 +0000 Received: by outflank-mailman (input) for mailman id 409688; Wed, 21 Sep 2022 08:59:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oavZO-0007UN-Ba; Wed, 21 Sep 2022 08:59:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oavZO-0000Yk-3L; Wed, 21 Sep 2022 08:59:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oavZN-00037b-HK; Wed, 21 Sep 2022 08:59:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oavZN-0001AJ-Gq; Wed, 21 Sep 2022 08:59:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gSUgxpwUwbIyvTQZbQyJV1O/N4I/bACzr+ImVOTcP2o=; b=GHBb26vXsP5OrEVK1TbnlT8i+o Kq8JNrWyTM6XZmMaUxNSkcl4c8r5NaV5JRXq07DS9UKZ+vI2f9KMlXMMY/jg1nh8keQKtCkzg3MxX GVQ1TLN3xzCJFlHRnjXFN5iqHUBtt/1Q3IrVjzKS77zoVzvqDW2Mr+uLjE+pkrahwWWI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173264: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Wed, 21 Sep 2022 08:59:01 +0000 flight 173264 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173264/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 7 xen-install fail pass in 173259 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173259 like 173258 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173259 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173259 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173259 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173259 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173259 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173259 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173259 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173259 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173259 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173259 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173259 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173259 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173264 2022-09-21 01:53:13 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Sep 21 08:59:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 08:59:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409696.652706 (Exim 4.92) (envelope-from ) id 1oavZx-0007zy-LG; Wed, 21 Sep 2022 08:59:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409696.652706; Wed, 21 Sep 2022 08:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oavZx-0007zr-IC; Wed, 21 Sep 2022 08:59:37 +0000 Received: by outflank-mailman (input) for mailman id 409696; Wed, 21 Sep 2022 08:59:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oavZw-0007ud-3A for xen-devel@lists.xen.org; Wed, 21 Sep 2022 08:59:36 +0000 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [2607:f8b0:4864:20::102a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b62ac232-398b-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 10:59:34 +0200 (CEST) Received: by mail-pj1-x102a.google.com with SMTP id d64-20020a17090a6f4600b00202ce056566so13534681pjk.4 for ; Wed, 21 Sep 2022 01:59:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b62ac232-398b-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=9Z2yBpq0sXAAozruTza1rF7bQHQ849JgXikaM2yKWig=; b=F/rKVX9hUPImDdfhn0bDf6AZbGoORkVC5+l6145MtAQtXEGLnQJceSM2HJ53MDmdgs 2EGNLLEvHYrPNOT8yBexIBXR+R6oMIAl7SJgURUnS5mmNPiQP3IKEqWHJF9VnUT8mvsK vXOiUcabSxwbna86uebcq7kh+Y7OrjApS3aACvHLEDjCUHVdUair5O1Pop5tLOIrkFbg hkRlPDBDB7B560N2fb32CedZmGwKy5S4NYhGN3ejkIVK20PMReHiATQurNQbV7ab0fDY qFT9SugEDU3Iu+AAFDkEp4pOKUzy7GagO2jx4FmOx6UQ/Y5zpuFQk2ZlhYq+YrxXpENC 8cfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=9Z2yBpq0sXAAozruTza1rF7bQHQ849JgXikaM2yKWig=; b=Es7AQuenr3ZKYKrH7Kxb++EzwY9ZntKU5U0USmYAlYHSc5Lujk2ARVMeg27+/l3VsN jUr30FcHJNLBFDugAwA79OO6kpUsiZsAVbCmusTUBPP/mI91dd7BEeYnLVqQlhF4G22V j4CJG1VNDc4tS6Ck0Mc77wxqzANPyaw/FD0+lbSgkr1nDQLHhqBGHV2XK+CQHNYACiaB hmGGwQwgBoAHODbOXH8wKcgVtWNiDNX6/QohQgw0CZ9GjvYWVIbyCsQUCoIgP1+P8clq 3y15zyAZ2Lc0VEE851P+kE8Bp277mwHFgbPba2joSZxu9RWkx9oEXR+YicBchtnz7Dvw voUQ== X-Gm-Message-State: ACrzQf0qlT7bDrqYApubH88yUmZCQg1nFylNc0RfQX6uuMi7WOHjpjNN 5A8D5sIO4+xN/lem+eEw39RamGUmr65yNbnx+Jes1cbb X-Google-Smtp-Source: AMsMyM5IXt65S78F1+5HIjq2skMmrEl/jiW8YfgSqdxm2oUGp16FfhYZ0EIO2C2nVN+8nfCp+waJiKs2127HdWDZYoQ= X-Received: by 2002:a17:902:d88b:b0:178:264b:5aa4 with SMTP id b11-20020a170902d88b00b00178264b5aa4mr3680434plz.44.1663750773806; Wed, 21 Sep 2022 01:59:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Szewczyk Date: Wed, 21 Sep 2022 10:59:21 +0200 Message-ID: Subject: Re: [BUG] problems with NICs pass through to OpenBSD guest To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000de1a2905e92c2933" --000000000000de1a2905e92c2933 Content-Type: text/plain; charset="UTF-8" Hi, I asked Marek about installing Debug Hypervisor, and creating VM without stubdomain. It looks like I have to build Xen for myself, and edit libvirt config (which according to Marek may not work). I will try both this things on weekend but since I'm more an user then dev/sysadmin don't know if I can handle that tasks (also it probably be better to mess with such things on some other installation then my daily driver). Will You have some other ideas? BR Adam --000000000000de1a2905e92c2933 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
I asked Marek about installing Deb= ug Hypervisor, and creating VM without stubdomain.

It looks like I have to build Xen for myself, and edit libvirt config (whi= ch according to Marek may not work). I will try both this things on weekend= but since I'm more an user then dev/sysadmin don't know if I can h= andle that tasks (also it probably be better to mess with such things on so= me other installation then my daily driver). Will You have some other ideas= ?

BR Adam
--000000000000de1a2905e92c2933-- From xen-devel-bounces@lists.xenproject.org Wed Sep 21 09:48:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 09:48:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409705.652718 (Exim 4.92) (envelope-from ) id 1oawKz-00058s-CL; Wed, 21 Sep 2022 09:48:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409705.652718; Wed, 21 Sep 2022 09:48:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawKz-00058l-9P; Wed, 21 Sep 2022 09:48:13 +0000 Received: by outflank-mailman (input) for mailman id 409705; Wed, 21 Sep 2022 09:48:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawKy-00058f-HO for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 09:48:12 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 806c61c3-3992-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 11:48:11 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id bj12so12242237ejb.13 for ; Wed, 21 Sep 2022 02:48:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 806c61c3-3992-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=zW5HyKzeuivew/B/xuG63OBJVZKZHySm5uewagUHgYw=; b=W0gXS6y2bMRF3jyfGKbHAJ3obFmZsrPdd8F24LXKd+lkBoXU71tcZ/8Rd6CBiOG5Gt /llLewMKLhpE1fQNCYWyNUKAbaSFN2uQB2l18sr/X93nrdV3mtGgAIGRp/6TgVSMzN2Y /w1fEeXGFjYnXxT23gFPn8XnRZH5aeFDoxQz9+VomJlB3nS5DQBO+52ijYrE6giLDSG/ 2KCpT4rp+gLvUOj6dxkghXRdjweFaTc4KxK/v/ZnZUMuCbBq69W0kFT14iOV1Wlsqup3 dNnSUoA2MHtiNM8+w3c7h0S8ulkEzZsQykPZzRe2GSS6+09iGKn6Gbsk3SsmOBhLic69 qeyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=zW5HyKzeuivew/B/xuG63OBJVZKZHySm5uewagUHgYw=; b=V3HjzpNiMHUDlDKx+5iDfUJglBZiY3joTi104cmtyWG2HXOmzyUm+S18zQDGg5xh/N rr+LXKwsTsBzk69aiAu4SLWKaOP0OVuMMgW0M/nkpZQ8+GfZIQVm4Hg0rQHaTa+DI1Fn i5q97l1X8lInnfM/05i3/4Ic95cJbq2aUgicJmPhxQoUT1Z5XMKfVLxqtTRNaSpJoKUT XDl5OADidmrt0vYzFEILWZg4ndFFC9qro1vCyDSbq+6iqdekZyzbA3OpxaxboO3//pj6 lhbq7E7DQl5hKp3ZhL0Xh34+Srtm8/QdP+33ig3qw14q73DU2ECLrShYbSpvdCNW7Fk+ BrrA== X-Gm-Message-State: ACrzQf1NE+2WaNifki5Pm8eBOxKzLjggAA4AHe5h4NwgXi3vm0JeS9zx vufh70oDAhV9mQzu2e+UZZ+l/A7GSWNeCzcPNYGJ1Q== X-Google-Smtp-Source: AMsMyM7XaE+m0i9UnpDDtPcon9xvHdJdJV7wVRhpBOJ+d6OIshyTTEiMluysyBi3pDZh60CQuxd4pQfbk7wQRmhLbco= X-Received: by 2002:a17:907:2bd5:b0:76f:591c:466b with SMTP id gv21-20020a1709072bd500b0076f591c466bmr19468493ejc.504.1663753689736; Wed, 21 Sep 2022 02:48:09 -0700 (PDT) MIME-Version: 1.0 References: <20220919231720.163121-1-shentey@gmail.com> In-Reply-To: From: Peter Maydell Date: Wed, 21 Sep 2022 10:47:58 +0100 Message-ID: Subject: Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al To: Bernhard Beschow Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Christian Borntraeger , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 20 Sept 2022 at 23:50, Bernhard Beschow wrote: > > Am 20. September 2022 09:55:37 UTC schrieb Peter Maydell : > >On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrot= e: > >> > >> In address-spaces.h it can be read that get_system_memory() and > >> get_system_io() are temporary interfaces which "should only be used te= mporarily > >> until a proper bus interface is available". This statement certainly e= xtends to > >> the address_space_memory and address_space_io singletons. > > > >This is a long standing "we never really completed a cleanup"... > > > >> This series attempts > >> to stop further proliferation of their use by turning TYPE_SYSTEM_BUS = into an > >> object-oriented, "proper bus interface" inspired by PCIBus. > >> > >> While at it, also the main_system_bus singleton is turned into an attr= ibute of > >> MachineState. Together, this resolves five singletons in total, making= the > >> ownership relations much more obvious which helps comprehension. > > > >...but I don't think this is the direction we want to go. > >Overall the reason that the "system memory" and "system IO" > >singletons are weird is that in theory they should not be necessary > >at all -- board code should create devices and map them into an > >entirely arbitrary MemoryRegion or set of MemoryRegions corresponding > >to address space(s) for the CPU and for DMA-capable devices. > > My intention was to allow exactly that: By turning sytem memory and syste= m IO into non-singletons, one could have many of them, thus allowing boards= to create arbitrary mappings of memory and IO. Since QEMU currently assume= s one set (memory and IO) of addresses, I for now instantiated the SysBus o= nce in the machine class to preserve behavior. You can already create arbitrary mappings of memory and IO (look at the virt board for an example). The existence of the legacy singleton system-memory and system-io doesn't prevent that, and stuffing the singletons into the MachineState doesn't do anything to change the code that is relying on the singletons. > >Retaining the whole-system singleton but shoving it into MachineState > >doesn't really change much, IMHO. > > > >More generally, sysbus is rather weird because it isn't really a > >bus. Every device in the system of TYPE_SYS_BUS_DEVICE is "on" > >the unique TYPE_SYSTEM_BUS bus, but that doesn't mean they're > >all in the same address space or that in real hardware they'd > >all be on the same bus. > > Again, having multiple SysBuses may solve that issue. We definitely don't want multiple sysbuses. thanks -- PMM From xen-devel-bounces@lists.xenproject.org Wed Sep 21 10:15:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 10:15:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409712.652729 (Exim 4.92) (envelope-from ) id 1oawkw-0000EK-Fn; Wed, 21 Sep 2022 10:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409712.652729; Wed, 21 Sep 2022 10:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawkw-0000ED-CB; Wed, 21 Sep 2022 10:15:02 +0000 Received: by outflank-mailman (input) for mailman id 409712; Wed, 21 Sep 2022 10:15:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawku-0000E3-RJ; Wed, 21 Sep 2022 10:15:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawku-00025Q-Nh; Wed, 21 Sep 2022 10:15:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawku-0004oJ-3D; Wed, 21 Sep 2022 10:15:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oawku-00011C-2o; Wed, 21 Sep 2022 10:15:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K2rDtJCzPub2UgtYNtBTC3osnA8AqGC6i4UUfa1UemI=; b=hq74jPEYS0kQzdyv7+rQjokM/5 ABWU8R5naY/Lq0UsfD5YY6Mnc98QvPS8IYCGI5TAZybZ++GJ/ZFwjO11xWL8fJs13UP+TA9lSunlS NtNP+4by3UN3o498Xuz+wXz3E+BGRDvU/cEjE1sI4Ymq9PPnZ6uCFMPLAGldiHllSgSA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173266: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=0eeb4a1775175328a7eb45fad73cd832472c70d9 X-Osstest-Versions-That: libvirt=c83c6e4e7a68767ba69159bc0316884fa81158c4 From: osstest service owner Date: Wed, 21 Sep 2022 10:15:00 +0000 flight 173266 libvirt real [real] flight 173267 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173266/ http://logs.test-lab.xenproject.org/osstest/logs/173267/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 173267-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173247 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173247 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173247 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 0eeb4a1775175328a7eb45fad73cd832472c70d9 baseline version: libvirt c83c6e4e7a68767ba69159bc0316884fa81158c4 Last test of basis 173247 2022-09-17 04:20:57 Z 4 days Testing same since 173266 2022-09-21 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Göran Uddeborg Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git c83c6e4e7a..0eeb4a1775 0eeb4a1775175328a7eb45fad73cd832472c70d9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Sep 21 10:22:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 10:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409722.652740 (Exim 4.92) (envelope-from ) id 1oawrd-0001hO-7m; Wed, 21 Sep 2022 10:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409722.652740; Wed, 21 Sep 2022 10:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawrd-0001hH-4a; Wed, 21 Sep 2022 10:21:57 +0000 Received: by outflank-mailman (input) for mailman id 409722; Wed, 21 Sep 2022 10:21:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oawrb-0001hB-R2 for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 10:21:56 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2043.outbound.protection.outlook.com [40.107.102.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 356e6599-3997-11ed-bad8-01ff208a15ba; Wed, 21 Sep 2022 12:21:53 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM6PR12MB4516.namprd12.prod.outlook.com (2603:10b6:5:2ac::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17; Wed, 21 Sep 2022 10:21:46 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 10:21:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 356e6599-3997-11ed-bad8-01ff208a15ba ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhMoL98Wlb3u4B+MzpyxFyyOA03XACEPALc2jDearKI/1J1+9SphB8hVu3M84rqEi6MtIkivxUoeLVUdWGvjsP7I5tne7KjqDcMtz/9eqcSRxaRQOGaz1agdk0OZ7Rmo8aq9achxwCiBGLGUYNCQneekQfD9dnlPljgqpEmnM+X9u7WPWE/ao3xULY73WrdlZcRmWhbWBxINLeW+N+VRh0z179d+ZoQ3S3CVCIJWkknRbmq7r9adV3CjE6rVvy3ZkGnse55csSiZZivwrE1S6Mzg/S1D1wAzgiFaDVWcXsbOh9LtVYNs0inUC9BA7fRXLUT5Q2v5B4dXi3SFzOplXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SCO3MdedIa3voLgQuiam0115avqtVdrQxWE5J/jD1QQ=; b=mptJHypJHm28EP9qwIBAPbUVc0mehW7VMHmXtEBYEuhTpGAOWfZFHiecx5aG6a2MI4ymcLgJ853qTmmMJujbFUUOhD2p9fo+E5Tp70mKNGVgaumkks7GQXFt8NnOEG5hBue6KjaYZOhYE3IBqAo0lZ9gsZYQDheHJoXOTXyNRQkzpSMIK+S3lfZNtxNVEO2gdlXGXb4cXr/65wIg58Q0SNx78bKnDpLWjgC0NrUUt89pDfxrNcuswSDCGkpapa35kESy+IuYaEt9hKBKgEtlrQcX5Xq2y4T2Ufy8LtvJXLzqgd0Lf3Uu8Q+jV+4B4fN3FOj8qkmMrpNwZDOeDRl1Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCO3MdedIa3voLgQuiam0115avqtVdrQxWE5J/jD1QQ=; b=hZatmS8DGWjuR6oPlFssYR1ZXWqibD7uKfXExzUoJn3AV7j0W4+JmipNih3oYfXsijNMwSimwyDg1kF1O6tL+KfrSczmSHoiebpqyjhHEdqJ3m5vXsN1izYNj8uLGjVpCwGpaBdB7nRxx4UCg3Avozghd3sh7NCGJxz2oZCkHN4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <8b200579-8118-25b5-3e36-87ce3f9f9891@amd.com> Date: Wed, 21 Sep 2022 11:21:40 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Ayan Kumar Halder Subject: Design session, "Progressing of pending patch series" To: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0022.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::34) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4516:EE_ X-MS-Office365-Filtering-Correlation-Id: 0027c084-e209-46d8-8f31-08da9bbb1611 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RinYpBfj8/ja53vRhjJ9E3FGLkIcZtWSwp6iP2qwkKYVJllyk78yO3P8zsaRMOrpbyuMUCV6X7bNzjS3t4+Un4Ka+uvRKTkyGxz9FcQ5PJC0amIQCd0ZfE3Mr3t272pqzz+PHMyAcVoIwJgkgfhm4iB1pU1bKqpa5uSoPYkFiUxeJoXDeKhBsmaBdXOiW0NjrOIboZmZK67eiMzgpUDa9rLhQpwPCEhOfV1914eIdXJFRwG4fs6yHgQ88FlIQtVuvmJtuQpB489a41BbEPnwpHZUkySXkOmEUBQFPjNG1zwN76PMmw1tOhMbKc8bsLzn7XssYhr+cZBORUZYrbRhkLCdN9kHEXXXKkxqDaKmfI7LkH8OwgMGZIrppnenpwO2/mX05iZoBFORI7ydrI+hntBqjHVkzbo6vLZ1NPc+zHFoRVIqUQ37KgXG34o9tU3xeuylog5JXS6yB89IrUYewsPXC6z8c2jRUhhhE/tRJXfLoExQ09fskhl+rZn7c/GVEyTVO4JlgZcemujgJUMXW5UexyCEfjiMgu+J/ujgqPUcJGGVxUc6w7oJWmUMPImp058YaBKrmneYDChXT2LWCi53Sm+xhbw6N/eT2/kqxLiBAmysu+onVIPZPgZRZHnK5RYG26gmr0B8FYVdpzve/KHa+qtSR38wRNafL8XvGOr0xA9n0otfHeiTCPXsDRT0j6kKNV1kfj3id/Cm8nA/Bth1W9eb0JUEahZggsCh3aPSKWSzWxVqVrKgvmFNl3fEgtprMXL13Z7A/YqO3K3MRtrxJq+3xlTGyQEgvxPoz8Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199015)(31686004)(478600001)(6666004)(31696002)(66946007)(66556008)(66476007)(6916009)(8676002)(83380400001)(38100700002)(36756003)(2906002)(6506007)(26005)(66899012)(5660300002)(6512007)(41300700001)(316002)(8936002)(2616005)(6486002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnUxbzBxK29UMFRzVEhucXZNV2hyeW1nWmJoVG52N1JYTVJZd0duVVZ5V25N?= =?utf-8?B?RDM4WmRLMkhKR1J3L3RWMGx5dFQvdGdCUUN5OVNEbEJPdGlaemUzL2tHNXJH?= =?utf-8?B?Mm5Rb3FmV3d4K1IvSDVlVjFYNDN4MEdtTlRFYlIrVVQ5d3FaYk5tNFdMeGt3?= =?utf-8?B?MTBEUVFMejJuRlNIeXZJcjRONDg4STRDL3pyc3hEdHJtaXlVcHYxMWhseTcx?= =?utf-8?B?akdJNFVNNFBOdklUUjRuT2cxb3ZpcU0ySDhOYzhmOGhwQnl5ZnZsOFBjODk5?= =?utf-8?B?T0ZCUUhBZjF6M0x6MEo4NWptbDRuU0c3NGxMWWppUTZ1MjRIaHpoRUpPb002?= =?utf-8?B?Y3hZK1JpVXJLOG4vN21xK003b0hUd1owdlMyK21MVTFZTzd2U3V5OS9SbDRh?= =?utf-8?B?NVJJSVNMcFJ5REQ4dWU2dWJNRjMzazBBNGF2bS93K0dSUzNncjVhWEZFNWNE?= =?utf-8?B?a0xwVFMrWjFuR2VJRkxUR0xReGRPUEorSGdxcVNEczdiWGFBSEp1WnBFWWla?= =?utf-8?B?MHVzMjBiNkIxRzVOMEZpY0FqYXY5MUlMVFhnd1A1RG92NVpqUllhK3NRYnJO?= =?utf-8?B?NXVaM0I3VjUzRnRhOWxMa1dVSFNIbE1haWNBOGFBY0FJN2xiUUptdXNSM3lY?= =?utf-8?B?UzdUdHNncFovK0pUT01kZGtnTXBJVUtTNWxFVDFEQ2FZMG9ER2hYRytVVkk5?= =?utf-8?B?bnZZTytPMTQ5WVMxTndNVHdBM0FCaGw5eTRIK2JhdGhHT1Z4UEthaHg5YXFj?= =?utf-8?B?dEhNcVhWKzZUSkNEMDRPTVNqb3ZUL2VUWVBpcWNrK3dlMzRHTUI0NFpCUkZT?= =?utf-8?B?UXdZTjJCcnBtSlFaa0JHL214dm1XZmw1aFhZWUhuODlCRWRYZWR1OGY3ZThI?= =?utf-8?B?UEloSFBwSkpTZ3RkR0pWbjdkWEdHa3BETXdSd2FDQ1o3UG9PM1BkekhaKzVT?= =?utf-8?B?ZmZQWmZzdkRxR3pNaFNzNTN5dVVZQjdrRklaRDhVUkRGeWU3V3VrajcxZmw4?= =?utf-8?B?bHJQSzRsd0wzK0szL1hJMTd2SXF2WFFDQ3N5VWxCSnpLT29pODM2QlErUXM3?= =?utf-8?B?U1BUT1ZPYXZLc1ZqTXk0OGRFM3hDL0pxdFNJSGthbVF1VHNMdUlaVmJzYVl3?= =?utf-8?B?TjI0V2hjclRZUUkzWjVNQnp4QjVFRTFHR3MrK1FtQjJ0ZDlpL05VQTRSd2d4?= =?utf-8?B?SEdlYzh4M3BsQm9TVXYwRXJZNmcxeFVPWEkyQnRnUlNoZ0tocnd2WDFpZzls?= =?utf-8?B?QmtOalBWeFFuRXBHek9iQUJJVWRmOTZqc2Z3U29nTjlHYWMvMjdSaElES2NP?= =?utf-8?B?V0l1QlMrbUFiYjA1Ym11QTdjYTYrNkl5bDlJc2FockVKRFBqdmhUbjA4STk2?= =?utf-8?B?azJmSjRFYWhzeFlBdVdyaUV1V0pOUXdrbCtxZkdBWktrcTZPTE1LTkpibUp4?= =?utf-8?B?VWZlY0wxdVBjMzFvWjdFZ1ZkMWVQS1IvaGUxdjg4cjRXWjFLT0RVTVIrVkVL?= =?utf-8?B?ZXdJOFVDRCtsd3FkUkVIMGhZSHpkMmkwOTNUWnBML0tZcW1SblN1NnN1S1dL?= =?utf-8?B?amNLQVJxc3dYaVF4TlB3d01sNG1nK1J1dkRUcXg3SFhTa1pCQ1FSd295V2U2?= =?utf-8?B?R1VTM0FtTTBPeW5OOHYwUngvUEw0Mi96Y2djZ3UrT2FKTWJHMU9QSWxkVG8v?= =?utf-8?B?YTFYSnU2N2pFRGlnWjRTMGhkMUFHVlBXWHlLeHBoSUdaYjFZeDVJaXl4dGxN?= =?utf-8?B?aHpkbXIvZ1kxNkZyRW5ZTCtodXJhNkkrZW1QdU9BT0tETkRrOWlJbWZsNEpi?= =?utf-8?B?ZWttbjJHQzNmeVpuZEhNTXRWb2tNOVhxMitZdmlaWG13UDJsM1Bjdk9MQVdo?= =?utf-8?B?NmJ5THZXN0ttU0dZdmE3YVAvRXIyN1N2anhiRDY0azAvSC9IVXlmSHE1R256?= =?utf-8?B?T3N4clNSdkFQWHNCRVJrRGx3a3ZBMlJXWVZLalEyQTEzOGNiWmpkQXdhRC9U?= =?utf-8?B?WUtFazBLRGYrcGxsMTg0L0pHcHM4M0pjcWRlcDFTWEZnZjIyYnhXRFdHWVVt?= =?utf-8?B?TUlhQ1FLU0locDkzZThadDFpMGIrS09hVFJrNkJkVkNvL0xjM2xPL1RXeXZH?= =?utf-8?Q?yid5eTF07NoCRNK4MSqiDPvr5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0027c084-e209-46d8-8f31-08da9bbb1611 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 10:21:45.9816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8jEyBcEjtsnVRYDAZ8wl5fuFhW7NkymfWrvixqgFF52PLM+xccDN8DLHWcLuO3w30gXyYempkp9UJHnMoH0MEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4516 Hi All, Please find the meeting notes as follows. Please feel free to correct anything. Problem - Patches are not looked in reasonable time. This is an unsatisfactory situation for contributors especially if it involves effort for creating patches. This is not a new problem. New experts and bandwidth will not appear suddenly. We want to collect thoughts about potential changes to the review process. Can we have a possible solution where some patches can be kept pending for months / years before it is eligible for review and  committing ? Bertrand - Situation improved in last few days, The maintainers can edit the commit message before committing instead of pushing back. It reduces the probability of further series. Now there is too much activity available on the mailing list. Should we clean up the patches on the mailing list to distinguish between the patches to be reviewed vs not to be reviewed ? George - Sometimes, there is not very actionable feedback or too little feedback. Lot of people are bypassing Andrew (unsure if the name is correct) for review. There are not enough reviewers. Sometime people unrelevant to the patch series are cc-ed. So the pipeline of a reviewer increases. How to encourage new people to review ? Diego - What is the bottleneck from Andrew’s perspective George - Andrew has taken time to review past patch series. Sometime security bugs are discovered quite late. Sometimes, reviewers are super busy , so they don’t review. We can have meetings with maintainers where people enjoy talking about review rather than writing. Then the reviewer can explain the bug. Roger has been stepping up as reviewer to offload Andrew. Bertrand - Eg In PCI passthrough, Roger was not available so everything was postponed. How to reduce bottlenecks? Can less experienced people review , but risks introducing bugs. Accept that some feature might go in with potential bugs (Feature marked unsupported), So end user can understand risk. Later the unsupported features can be marked supported when it is reviewed or tested. Jan - Some person can review without being an explicit maintainer. Bertrand - Some PCI passthrough issues are related to x86 . So we are blocked by the x86 review.  It is a case that Arm’s PCI passthrough feature cannot be upstreamed. George - Can there be a mentorship program , where new reviewers will be paired with maintainers. And improve the review timelines. Jan - Common code should be improved in all scenarios. What is in tree already should not deteriote. Some of the Arm's PCI passthrough changes introduces locking problem. Thus, we need to solve locking problem before Arm’s changes are introduced. Bertrand - In an unsupported, you have a first version. If too much dependency is added in the first instance, then nothing progress. Jurgen - Can we add experimental features with timeout. If no correction done on an experimental feature, then the feature can be removed Roger - Who is going to do cleanup Bertrand - All the new code is bounded by configuration. Xen code is modular. Easier to find what to remove. George - Refactoring other parts of code will make it difficult Jan - Some parts can still be scattered around. Can’t guard everything. Bertrand - If 99% percent of code is modular, then probability of bugs is reduced. Anthony - Makefile changes took lot of time. Bertrand - Differentiate between critical / non critical patches so we can make faster progress. Jan - When I rebase my tree, it took a day to solve problems introduced Makefile changes. Do not blindly merge. Anthony had to take time to make out of tree work. George - If we wait until a series is perfected, then there is a lower chance of bugs but lots of work/time. If we put things faster, then bugs may be introduced and breaks. Need to find a sweet mid spot. Jurgen - Working on the central boot process is hitting everyone. Working on specific feature, only affects a limited set. Makefile changes (by Anthony) affect everybody. On PCI issues, the locking issues need to be fixed first. If the locking is broken, then lot of side effects are introduced. Bertrand - Spent lot of time discussion. We have an internal git branch with lots of downstream patches. Now we are upstreaming the initial features. Then x86 request came. No body looked at downstream gitlab repo. Roger/Jan - No time to look at private gitlab repos. Bertrand - How do we then fix things iteratively? Shouldn’t require fixing everything in the first instance. Jan - Regarding checkin new features. There might be limitations , but bugs should not be checked in knowingly. FIXME should be used to fix severe bugs. Locking problem is a severe bug to be fixed before. No one had enough incentive to fix it. Unfortunate that Arm got affected. EPAM is trying to fix the locking issues. Agree with Bertrand that things moved slowly. Should not be bad bugs involved. Someone - How do we guys deal with scope creep ? When the scope of the initial work increases significantly George - The work of refactoring of existing patch seems a lot of work (sometime Arm guys don’t have x86 hardware/knowledge). Who is going to do this ? Jan - Ideally PCI should have been done with only Arm in mind. George - All issue related to review bottleneck. If I need to review something, ping me on irc. Sometime, things slip. If there was system to  assign a ticket to person for review (on gitlab). Other projects have this philosophy Jan - People shopuld be picking work, so they can do their best. George - If the code is common with 6 mantainers, then sometimes I take time and review. In the meantime someone else reviewes. Jan - Double review is good. Different issues can be seen by different person. Bertrand - After one reviewers reviews the patch, should we send v2 or wait for another reviewer to see v1. Can’t see the status of review on a patch. Jurgen - When I send a series for common code, Jan reviews , then I am confident that no one else will review. Sometimes, Jan takes few days. Jan - No problems with a v2 but it address all the open questions on v1. George - Have mentoring problem for reviewers. Maintainers can mentor reviewer. Have a quiz to ask who will pick up the review. Jurgen - Should I mention that I will do the review so that others will know. George - Know what I need to review from the mailing list. Then I will look it. Jurgen - Sometimes I review things which are related to linux. For other parts which I am not confident, I leave it to review. George - People learn by reviewing code. If they have a mentor, then reviewers can do. Jurgen - Reviewers may have a priority list for review. Bertrand - Huge history in the mailing list. A rule that if my patch is more than 2 months old, resend it George - Have a system which will track who is reviewing with what Jan - In my experience, pings do not work at all. If I don’t have initial feedback why to send v2. George - If a comment on v1 does not get addressed in 6 months, then what happens. You can check with maintainers to give feedback in due course of time. Send a mail, review check it in two months and do it. Sometime series get blocked on a single maintainer. Should not be that someone becomes a bootleneck. We should offload things from people who are busy. Jan - People should not be shy of looking at patches where maintainers have already commented. Objections should expire if they are not followed with concrete suggestion. So, other people can review and if others agree (without maintainers) , then commit it. Bertrand - New reviewers take time to have confidence for review. Jan - If I get review from new people, there is some level of mistrust if the patch series is intrusive. If the patch series is easy, then I can trust review from new people. If new people review frequently, then trust increases in due course of time. Also reviewers need to ask questions or spot problems on the patch. No blind review. Kind regards, Ayan From xen-devel-bounces@lists.xenproject.org Wed Sep 21 14:04:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 14:04:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409808.652774 (Exim 4.92) (envelope-from ) id 1ob0KS-0000TP-H3; Wed, 21 Sep 2022 14:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409808.652774; Wed, 21 Sep 2022 14:03:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob0KS-0000TI-EL; Wed, 21 Sep 2022 14:03:56 +0000 Received: by outflank-mailman (input) for mailman id 409808; Wed, 21 Sep 2022 14:03:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob0KQ-0000TA-Fi for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 14:03:54 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 384afc61-39b6-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 16:03:52 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DC5793200925 for ; Wed, 21 Sep 2022 10:03:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 21 Sep 2022 10:03:50 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 21 Sep 2022 10:03:41 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 384afc61-39b6-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1663769028; x=1663855428; bh=l3SK+JMa8Y qvrFWfls03AIC1l4XiU9REjGuvo6PkMvw=; b=wzdL2tDZ1fNTqqw7CVtF3X8lBz y4mIc3fY5rxhQREDO0PPNXj8UegpnMvUPAzZTOe2ffoFVUA6/kKRGwYuzN9sFo9h GEZleRHDYM0pX5vGqGR9r0jnzAMUkgJZMJESY1T3ozL/pTKXQlqXkrxfUojb4PSi ENr0PH+VdARYNKA3xbohQU6apduv8k5ICTv96lDfK9Hhs9RBI8IJE0F/3iPEQIPK o70qtXr1tZ0L09uD1uK+EsFrdakalCZLOY8cj1X5d/EA/hKVFp0UmDjEvqcVQGKS MptRwrguSFlH+UbqNWrT5eYFskw/L+uQ4hQ/oRYiJxpQ8caSEKOnKcWKIgXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663769028; x= 1663855428; bh=l3SK+JMa8YqvrFWfls03AIC1l4XiU9REjGuvo6PkMvw=; b=t BsqiJ5LMq9NXbJlkZwimuL16Pp8NxMxx+frOEi6tO2mwv26IaFOg+f/GnwoLuKRW DWcJrzYpw47wtgeveDn9DsXzjAOzXkquUt46C89VOM5ciyybvEiN9PYpxeIGotX4 /9iue14/0ikJK0v8jjtrMqL+xCfvAeLuA+4NTQcjdkpfgytdvxZkdLn/LQsUbyEz Cw6x6nGXun8QJqY06colcHPdMjKC/EtnGY33JGslyhIShqnbx37h8+Gvt6x5FX97 JVqcysx8/Q72QswjKAAHcF3LgQVlfgozDGot3NcInX3NtM82Rew16EYfNLx5pJ+G ju+tBHZyFsBPxKlxiJPFQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefuddgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnheptddugfetudevudeiveevgfetueejlefggffghffhhfehtdff feefgfduueegfefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 21 Sep 2022 16:03:38 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session "virtio" Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eysTC+rnx5O4Qpid" Content-Disposition: inline --eysTC+rnx5O4Qpid Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 21 Sep 2022 16:03:38 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session "virtio" Some sparse notes from the design session: Passing backend domid ideas: - via xenstore: good - can be done now; bad - requires xenstore even if only virtio devices are used - extend generic part of virtio spec: takes time, but otherwise preferred New "config" virtio device - for configuring backends Hotplug: - ACPI (for HVM at least) - xenstore ACTION: Start the virtio spec change. In the meantime, use xenstore(?) qemu parameters are device-specific - adding backend id needs to be done fo= r every device type - both at qemu side, and libxl side Device endpoint ID are currently allocated by qemu - for driver domains tha= t needs to be moved to the toolstack, to reserve space for devices running = in other backends. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --eysTC+rnx5O4Qpid Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMrGboACgkQ24/THMrX 1yxkSggAg98OlEhExodHHgkclwW3JsmStjnHwHTandD8X7dz5A1GxfRPvcE+J6jh fSixQp8yDFedXAUn3y4zhPCeysQolMaHmR7M3XCFIC4Lv1oyPnYjuL1Jw0VrXk8d FSW/m1b51BOqcjFZ6hQkvbLPo8nvdGMa8m+JqlKvyphY1p1z1QJn+vAJby+E0VdG h6KiPc99DcSMP0Ma7lc4nr9vffqrDmkI+ZZ0jU1TEl2EXXYO2nlUVQGMdr8Ki8Sj 5GzBGOC6Bwhjg0JHEZFy7vp6N8yl9Yld9Eh2DG0ifX3ihH6BDf2763yotXxV0UTZ vrfVl6z3xHmUSfnI+Poha7abzdEwrQ== =+PQS -----END PGP SIGNATURE----- --eysTC+rnx5O4Qpid-- From xen-devel-bounces@lists.xenproject.org Wed Sep 21 14:21:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 14:21:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409816.652785 (Exim 4.92) (envelope-from ) id 1ob0bn-00030I-0o; Wed, 21 Sep 2022 14:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409816.652785; Wed, 21 Sep 2022 14:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob0bm-00030B-UF; Wed, 21 Sep 2022 14:21:50 +0000 Received: by outflank-mailman (input) for mailman id 409816; Wed, 21 Sep 2022 14:21:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob0bl-000305-QH for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 14:21:49 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba4b09db-39b8-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 16:21:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AACE521AC2 for ; Wed, 21 Sep 2022 14:21:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 88EF013A00 for ; Wed, 21 Sep 2022 14:21:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JbeKH/sdK2NQUwAAMHmgww (envelope-from ) for ; Wed, 21 Sep 2022 14:21:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba4b09db-39b8-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663770107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=TWiNv0qhhYrbfIzk6dWaa/yIClGvWFZCCN1NbsLlVsE=; b=op8B4UqEFbhQvdPdSNiTNNhDieVFc3ieJM2E1QjZwQYSWdGZDbv0JIqXSfR/8Ffkw54ZlW lWVU3g8AEv2+wpk0/SULBiofG4yg+M6sMvKbD975QShhVtlrTtrP56ytpEmIDp6WBfAHv/ EOgXUbCSoOfLhSTWythmyC2JtwNuW4I= Message-ID: <41d5e47d-8b5b-6ba9-486f-3b294692880b@suse.com> Date: Wed, 21 Sep 2022 16:21:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" From: Juergen Gross Subject: Xen summit: x86 emulator design session Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yHFP5hfdPD6WcJQYDtGTtC5G" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yHFP5hfdPD6WcJQYDtGTtC5G Content-Type: multipart/mixed; boundary="------------XGIxOj9G5OXmLwz6s2Lmewbj"; protected-headers="v1" From: Juergen Gross To: "xen-devel@lists.xenproject.org" Message-ID: <41d5e47d-8b5b-6ba9-486f-3b294692880b@suse.com> Subject: Xen summit: x86 emulator design session --------------XGIxOj9G5OXmLwz6s2Lmewbj Content-Type: multipart/mixed; boundary="------------IUQ6EfIX8042jS4Rd2eyJtWz" --------------IUQ6EfIX8042jS4Rd2eyJtWz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 RGVzaWduOiBvbmUgbGFyZ2Ugc3dpdGNoIHN0YXRlbWVudCwgbWFpbnRhaW5hYmxlIGJ5IEFu ZHJldyBhbmQgSmFuLCBidXQgcHJvYmFibHkgDQpub3QgZm9yIHNvbWVvbmUgZWxzZS4gRXZl biBoYXJkIGZvciBKYW4gYXMgd29ya2luZyBvbmx5IHNvbWV0aW1lcyBvbiBpdC4NCkFkZGl0 aW9uYWwgcHJvYmxlbSBpcyB0aGUgbmVlZCBmb3IgcmV2aWV3cywgYXMgdGhlIGJhcnJpZXIg Zm9yIGRvaW5nIHJldmlld3MgaXMgDQpxdWl0ZSBoaWdoIChldmVuIGZvciBBbmRyZXcpLg0K DQpUaGlzIGlzIHByb2JsZW1hdGljIHJlZ2FyZGluZyB0byByZXdvcmsgdGhlIGVtdWxhdG9y IGFzIG5vYm9keSBpcyByZWFsbHkgbG9va2luZyANCmF0IHRoZSBwYXRjaGVzIChwZW5kaW5n IHNpbmNlIG1vcmUgdGhhbiAxIHllYXIpLiBXaG8gd2lsbCB0YWtlIG92ZXIgZnJvbSBKYW4g DQphZnRlciBoaXMgcmV0aXJlbWVudCAoaW4gMTEgeWVhcnMpLg0KDQpXaGF0IG5lZWRzIHRv IGJlIGRvbmUgdG8gdW5ibG9jayBKYW4ncyByZXdvcmsgYW5kIGZ1cnRoZXIgaW1wcm92ZW1l bnRzPw0KDQpHZW9yZ2U6IHNvbWV0aW1lcyByZXZpZXdpbmcgSmFuJ3MgcGF0Y2hlcy4gRW11 bGF0aW9uIGlzIGRvbmUgbm90IGJ5IHNpbXVsYXRpbmcgDQp0aGUgaW5zdHJ1Y3Rpb25zLCBi dXQgdG8gc2V0dXAgdGhlIGlucHV0IGRhdGEgYW5kIHRvIHRoZW4gZXhlY3V0ZSB0aGUgc2lu Z2xlIA0KaW5zdHJ1Y3Rpb25zLCBlbXVsYXRpbmcgb25seSB0aGUgbWVtb3J5IGFjY2Vzc2Vz Lg0KDQpNYXJlazogaG93IGRvZXMgdGVzdGluZyBsb29rIGxpa2U/DQoNCkphbi9HZW9yZ2U6 IGVtdWxhdG9yIGNhbiBiZSBjb21waWxlZCBpbnRvIHRoZSBoeXBlcnZpc29yIG9yIGludG8g dGhlIHRlc3QgY29kZSANCmFuZCB0aGVuIHRoZSB0ZXN0cyBhcmUgcnVuLCBlLmcuIEFGTCAo ZGV0ZWN0aW5nIGJhc2ljYWxseSB3cm9uZyBhc3NlcnRpb25zKS4gDQpUZXN0cyB3aWxsIGZp bmQgcmVncmVzc2lvbnMgd2hlbiBhZGRpbmcgbmV3IGluc3RydWN0aW9ucy4NCldoYXQgaXMg bWlzc2luZyBpcyBzb21lIGF1dG9tYXRpYyB2ZXJpZmljYXRpb24gYmV0d2VlbiBuYXRpdmUg YW5kIGVtdWxhdGVkIA0KaW5zdHJ1Y3Rpb25zIGFyZSBoYXZpbmcgdGhlIHNhbWUgcmVzdWx0 cy4NCg0KSmFuOiByZWZhY3RvcmluZyBpcyByZWFsbHkgbmVlZGVkLCBidXQgc3R1Y2sgZHVl IHRvIGFib3ZlIHJlYXNvbnMuDQoNCkp1ZXJnZW46IG5vIGluZGlyZWN0IGNhbGxzIHdhbnRl ZCwgd2hhdCBhYm91dCBnZW5lcmF0aW5nIHRoZSBjb2RlIGZyb20gYW4gDQppbml0aWFsIHRh YmxlLg0KDQpKYW46IHN0cnVjdHVyZSBpcyBjb21wbGljYXRlZCwgZS5nLiB1c2luZyBxdWl0 ZSBzb21lIGdvdG9zIHRvIGNvbW1vbiBjb2RlDQoNCkdlb3JnZTogd291bGQgbm90IGJlIGNl cnRpZnlhYmxlDQoNCkp1ZXJnZW46IGp1c3QgYSB3YXkgdG8gYXZvaWQgaW5kaXJlY3QgY2Fs bHMNCg0KSmFuOiBnb3RvcyBjb3VsZCBiZSByZXBsYWNlZCBieSBjYWxscyBnaXZlbiB0aGF0 IGFsbCBzdGF0ZSB3b3VsZCBiZSBwYXNzZWQgdmlhIA0KcGFyYW1zIG9yIGEgY29tbW9uIHN0 cnVjdC4NCg0KSnVlcmdlbjogSSBjb3VsZCBwcm9iYWJseSByZXZpZXcgc29tZSBwYXRjaGVz LCBidXQgSSdtIHJldGlyaW5nIHByb2JhYmx5IGFoZWFkIA0Kb2YgSmFuLg0KDQpNYXJlazog a25vd2luZyB0byBub3QgdXNlIHNvbWUgZmVhdHVyZXMsIGNhbiB3ZSBkaXNhYmxlIHRoZSBl bXVsYXRvcj8NCg0KSmFuOiBpZiB5b3UgYXJlIG5vdCB1c2luZyBzaGFkb3cgcGFnZSB0YWJs ZXMsIGVtdWxhdGVkIGdyYXBoaWNzLCBlbXVsYXRlZCBNTUlPLCANCmludHJvc3BlY3Rpb24s IC4uLg0KDQpHZW9yZ2U6IHdoYXQgYWJvdXQgdHJ5aW5nIHRvIHdyaXRlIHRoZSBuZXcgZW11 bGF0b3IgZnJvbSBzY3JhdGNoIGluIGEgY2xlYW4gd2F5IA0Kd2hpbGUgZG9jdW1lbnRpbmcv dW5kZXJzdGFuZGluZyBpdCBieSB0aGUgbmV3IG1haW50YWluZXI/DQoNCkphbjogcHJvYmxl bSBpcyBtYWlubHkgdGhlIHNwZWNpYWwgY2FzZSBoYW5kbGVkIGJhc2ljYWxseSB2aWEgdGhl IGdvdG9zIHRvZGF5IA0KKGV4Y2VwdGlvbnMsIC4uLikNCg0KR2VvcmdlOiBwcm9wZXIgdGVz dCBjYXNlcyB3b3VsZCBoZWxwIHRvIGRvIHRoYXQgZm9yIHZlcmlmaWNhdGlvbiBvZiBhIG5l dyBzdHJ1Y3R1cmUNCg0KSmFuLiBlLmcuIEFWWDUxMiBpbnN0cnVjdGlvbnMgYXJlIGNvdmVy ZWQgb25seSBmb3IgbWVtb3J5IGFjY2Vzc2VzDQoNCkdlb3JnZTogYW5vdGhlciBwcm9ibGVt IGFyZWEgaXMgaW50ZXJydXB0YWJpbGl0eSB0ZXN0aW5nDQoNCkdlb3JnZTogbWF5YmUgd2Ug bmVlZCB0byBmaW5kIHNvbWVvbmUgZG9pbmcgdGhlIHdvcmsgKGhpcmluZykgZm9yIGF1ZGl0 aW5nIHRoZSANCmVtdWxhdG9yIGNvZGUNCg0KSnVlcmdlbjogd2hhdCBhYm91dCBhc2tpbmcg ZS5nLiBBTUQ/DQoNCkphbi9HZW9yZ2U6IG1heWJlIHBlb3BsZSBhdCBBTUQgY2FwYWJsZSB0 byBkbyB0aGF0IGFyZSBub3QgaW50ZXJlc3RlZCBpbiBYZW4NCg0KTWFyZWs6IEtWTSB1c2Vz IHFlbXUgdG8gZW11bGF0ZWQgZS5nLiBlbXVsYXRlZCBWR0EgbWVtb3J5LiBXaGF0IGFib3V0 IGRvaW5nIHRoZSANCnNhbWUgaW4gWGVuPw0KDQpKYW46IG5vdCBlYXN5LCBidXQgbWF5YmUg cG9zc2libGUsIHJlbW92aW5nIHRoZSBuZWVkIHRvIGVtdWxhdGUgYWxsIHRoZSBTSU1EIA0K c3R1ZmYgZXRjLg0KDQpHZW9yZ2U6IHdoYXQgdG8gZG8gd2l0aCBKYW4ncyBjdXJyZW50IHBl bmRpbmcgcGF0Y2hlcz8NCg0KSmFuOiBqdXN0IHRha2UgbWlzc2luZyBOQUsgYXMgc2lsZW50 IGFncmVlbWVudCwgZ2l2ZW4gdGhhdCB0ZXN0aW5nIGhhcyBiZWVuIA0KcXVpdGUgZ29vZA0K DQpHZW9yZ2U6IHF1aXRlIGRhbmdlcm91cw0KDQpKYW46IGZvciByZXdvcmsgd2UnZCBuZWVk IHNvbWUgbW9yZSB0ZXN0cyBmb3IgYmVpbmcgc3VyZSBub3QgaGF2aW5nIGJyb2tlbiBzb21l dGhpbmcNCg0KR2VvcmdlOiBhZGQgYWRkaXRpb25hbCBBRkwgdGVzdHMgdGVzdGluZyBzdHVm ZiB3aGljaCBjYW4gdGhlbiBiZSB0ZXN0ZWQgb24gYmFyZSANCm1ldGFsIGFuZCBjb21wYXJl IHRoZSByZXN1bHRzIHRvIGJlIHRoZSBzYW1lLg0KDQpKdWVyZ2VuOiB3aGF0IGFib3V0IHVz aW5nIHNvbWUgZXhpc3Rpbmcgc2VsZnRlc3RzIChBTUQsIHFlbXUsIC4uLik/IExvb2tpbmcg DQplc3BlY2lhbGx5IGF0IHFlbXUgVENHIHRlc3RzIGNvdWxkIGJlIGEgZ29vZCB3YXkgdG8g aGFuZGxlIGl0Lg0KDQoNCkp1ZXJnZW4NCg== --------------IUQ6EfIX8042jS4Rd2eyJtWz Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------IUQ6EfIX8042jS4Rd2eyJtWz-- --------------XGIxOj9G5OXmLwz6s2Lmewbj-- --------------yHFP5hfdPD6WcJQYDtGTtC5G Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMrHfsFAwAAAAAACgkQsN6d1ii/Ey9c fQf+Pj5AvXY0qkIOoABKqaPeyoDyIwqqhsL1Fz2/NFlCD+216f/5Mc9z157pRi4wdKZy+mr8iw4R rcZoLf2r7rBa4R24NEi5V/l1wGMqZA/SHe4iYM6svIb0boKbeFil9s50+/ovDt5fz1wzB3jUhD3p 2ZSqAi50NAhJfjouuA/Hg3p96bbDFo3DVPTXRZNcJHUuMC7BUQ25TnaIj7YLtcTFL9UMXLXys520 W0hpf1gr4pANZyzHmRta89X4kGYRoPq/n8s281M+rFBW5Q97fKZWp4iE1ltJ2ipw3XgJhqMr9TNf rHkPT3TW/+aSYX23n7PR29ZFxv62GHvKyUPBIYJfcA== =iXHT -----END PGP SIGNATURE----- --------------yHFP5hfdPD6WcJQYDtGTtC5G-- From xen-devel-bounces@lists.xenproject.org Wed Sep 21 14:32:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 14:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409453.652796 (Exim 4.92) (envelope-from ) id 1ob0m3-0004a5-5g; Wed, 21 Sep 2022 14:32:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409453.652796; Wed, 21 Sep 2022 14:32:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob0m3-0004Zy-14; Wed, 21 Sep 2022 14:32:27 +0000 Received: by outflank-mailman (input) for mailman id 409453; Tue, 20 Sep 2022 14:01:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oadoI-0007yu-Bj for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 14:01:14 +0000 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [2607:f8b0:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af7323fd-38ec-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 16:01:13 +0200 (CEST) Received: by mail-ot1-x336.google.com with SMTP id br15-20020a056830390f00b0061c9d73b8bdso1770278otb.6 for ; Tue, 20 Sep 2022 07:01:13 -0700 (PDT) Received: from [192.168.10.102] ([191.193.2.69]) by smtp.gmail.com with ESMTPSA id y22-20020a056830071600b0065892f42157sm821295ots.75.2022.09.20.07.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 07:01:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af7323fd-38ec-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=obx72+8lj9qm2WhrMMX0CKsbEGig5oqUktdJe59wJ8c=; b=EYGsqsWfnaYLIUhNnwR+W3+HQV7e1PVwf2K+QWqXr8T8ik7uhUchYwfaPRXzwOSNdj Y/VehUxaTawGdfoqwV5K3tSuvfrPWqckFhn+PXkxZYghBOhI2+TO0xbTzdFFrdhpyh2x veDoWSvsPDca3I578Fy9amlMqEZxQtbHz3JbXHWjMiu5OfyH5uyFImUWMMUvuKamIuTS YG8Kte9lSMN+Y8mrfYFVvuA43odoGtzEhiO8+jo4NP0P6X2/MTgvqMcLEzX/vDtgsO9b Gwc7jwC79qXCaM1/HPNBUkVZGrFZS5xRrwr2Ne3iu0RW7Y6naElU5JeR1p5TlLLhSvzD 4tyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=obx72+8lj9qm2WhrMMX0CKsbEGig5oqUktdJe59wJ8c=; b=7R6JVd++CElh7aQ1JX7wioSxtbqvw6KzxH9fLUwd43RF6htwSHxGTpM0AelXimEGAp Pc8cbBgapJc7MUMMTHdihnL8VryzKFDUm6vy8/78U4hz0qMYeldCETqdjmOHptZGB3GI 6lHPCgoP5OBRPEFKxQ1leH0uc9UJQ4SHOD6BqffA94V/MOsWxHdqfdMUW/ZBQ3dYjIb2 n7APv3h49lBQDtEkD9E++YoyOr4rgnVdgzcygAGTYN8G9kkwzNoUh42aamrupXX6gqGN KwwFaWXYMnZm4W6YtwGdHiepvnMH0NEJEg1bE/QtTuqJA2NA84u0qH2v+BSTSWbvhj8i 1/dQ== X-Gm-Message-State: ACrzQf1OgjF2dM+gdxbgI56ysAyk3be4kI6ctUuT1pGTjowAH2YLelvW u7vX1zezCjh78XS763lXWUY= X-Google-Smtp-Source: AMsMyM7SJwY7Rzq8kp0hCW9RSDbUha/Eoq34TgM/6q2jfQ2yIYDABRMiwIOljIt9IFN/T/DE/u7ntw== X-Received: by 2002:a05:6830:18d8:b0:655:1f50:715f with SMTP id v24-20020a05683018d800b006551f50715fmr10392167ote.97.1663682472036; Tue, 20 Sep 2022 07:01:12 -0700 (PDT) Message-ID: <8906f236-dbfc-7d51-a87d-2c02e8c506b2@gmail.com> Date: Tue, 20 Sep 2022 11:00:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 4/9] hw/ppc/spapr: Fix code style problems reported by checkpatch To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-5-shentey@gmail.com> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <20220919231720.163121-5-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/19/22 20:17, Bernhard Beschow wrote: > Signed-off-by: Bernhard Beschow > --- Reviewed-by: Daniel Henrique Barboza And I've queued it in gitlab.com/danielhb/qemu/tree/ppc-next since it's not tied with the rest of the series. Thanks, Daniel > include/hw/ppc/spapr.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index 530d739b1d..04a95669ab 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -848,7 +848,8 @@ static inline uint64_t ppc64_phys_to_real(uint64_t addr) > > static inline uint32_t rtas_ld(target_ulong phys, int n) > { > - return ldl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n)); > + return ldl_be_phys(&address_space_memory, > + ppc64_phys_to_real(phys + 4 * n)); > } > > static inline uint64_t rtas_ldq(target_ulong phys, int n) > @@ -858,7 +859,7 @@ static inline uint64_t rtas_ldq(target_ulong phys, int n) > > static inline void rtas_st(target_ulong phys, int n, uint32_t val) > { > - stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n), val); > + stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), val); > } > > typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, SpaprMachineState *sm, From xen-devel-bounces@lists.xenproject.org Wed Sep 21 15:16:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 15:16:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409833.652807 (Exim 4.92) (envelope-from ) id 1ob1Sj-0000nQ-HL; Wed, 21 Sep 2022 15:16:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409833.652807; Wed, 21 Sep 2022 15:16:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1Sj-0000nJ-Cv; Wed, 21 Sep 2022 15:16:33 +0000 Received: by outflank-mailman (input) for mailman id 409833; Wed, 21 Sep 2022 15:16:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1Si-0000nD-IU for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 15:16:32 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ca88dcc-39c0-11ed-9374-c1cf23e5d27e; Wed, 21 Sep 2022 17:16:30 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 166377338234190.41874380517845; Wed, 21 Sep 2022 08:16:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ca88dcc-39c0-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; t=1663773385; cv=none; d=zohomail.com; s=zohoarc; b=BVT42Uz5FnrFyisddM56XrDdGxcxVksqaY9rB8dwvjn5MtzCun4/ujOSWqlhcCm6QA9UpUkYNBatnC4P4CILGX3qsiLDLeI15elFyWuLwkbJ0/80BquEQzgZPurf80VIseotRPkNcqkinCjlw2vlmjed1A2jK0s69blyupctJWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663773385; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=NDoK6DyexoYdIaow3/4JAZN25fIJLHqdzOzXM8IXl3o=; b=HmwmuD7LiUoYSwCAu+DPgrydrL0+BxUdcyLJOeLhRzbsCT/6VyLxC16Wkn+6UBT+tl4F8rKvFByklodGbvnvT6clIv7hQxE0KU0/OcAHwzec88O6D9fuFvDNHHyeUcyOMDCWP53a/8lTYmJb/xVMkFI5R0jX193oDjsmSt7fWHU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1663773385; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=NDoK6DyexoYdIaow3/4JAZN25fIJLHqdzOzXM8IXl3o=; b=OTIKK0g4TKU+VBESBzAlJqmGEG5nII6ja3EZnhn6ZOS/eBC9vyROzpu6xhNU01Mo yPitSUAAAo0FuEHw+cBxO+0cP8hVWAbjMZjB22AiOGQaG6fdSywJ4TCV+0mdENXC5uX FiWkfP1UpmmTUobVl/I0yhDW9N1ffiRF6fuJH1y8= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , jandryuk@gmail.com, Henry Wang Subject: [PATCH v2] xsm/flask: adjust print messages to use %pd Date: Wed, 21 Sep 2022 11:16:14 -0400 Message-Id: <20220921151614.9400-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Print messages from flask use an inconsistent format when printing the domain id. When referencing system domains, the domain id is printed which is not immediately identifiable. The %pd conversion specifier provides a consistent and clear way to format for the domain id. In addition this will assist in aligning FLASK with current hypervisor code practices. While addressing the domain id formating, two relatd issues were addressed. The first being that avc_printk() was not applying any conversion specifier validation. To address this, the printf annotation was added to avc_printk() to help ensure the correct types are passed to each conversion specifier. The second was concern that source and target domains were being appropriately reported for an AVC. This was addressed by simplifying the conditional logic. Signed-off-by: Daniel P. Smith Reviewed-by: Henry Wang --- Changes in v2: - Grossly simplified the conditional logic for printing source/target domids to address concerns raised by Jan. xen/xsm/flask/avc.c | 16 ++++++++-------- xen/xsm/flask/hooks.c | 3 +-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c index 4a75ec97e2..3d39e55cae 100644 --- a/xen/xsm/flask/avc.c +++ b/xen/xsm/flask/avc.c @@ -113,7 +113,8 @@ struct avc_dump_buf { u32 free; }; -static void avc_printk(struct avc_dump_buf *buf, const char *fmt, ...) +static void __attribute__ ((format (printf, 2, 3))) + avc_printk(struct avc_dump_buf *buf, const char *fmt, ...) { int i; va_list args; @@ -565,15 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, if ( a && (a->sdom || a->tdom) ) { - if ( a->sdom && a->tdom && a->sdom != a->tdom ) - avc_printk(&buf, "domid=%d target=%d ", a->sdom->domain_id, a->tdom->domain_id); - else if ( a->sdom ) - avc_printk(&buf, "domid=%d ", a->sdom->domain_id); - else - avc_printk(&buf, "target=%d ", a->tdom->domain_id); + if ( a->sdom ) + avc_printk(&buf, "source=%pd ", a->sdom); + if ( a->tdom && a->tdom != a->sdom ) + avc_printk(&buf, "target=%pd ", a->tdom); } else if ( cdom ) - avc_printk(&buf, "domid=%d ", cdom->domain_id); + avc_printk(&buf, "current=%pd ", cdom); + switch ( a ? a->type : 0 ) { case AVC_AUDIT_DATA_DEV: avc_printk(&buf, "device=%#lx ", a->device); diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 8bd56644ef..a79281bdb0 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -281,8 +281,7 @@ static int cf_check flask_evtchn_interdomain( rc = security_transition_sid(sid1, sid2, SECCLASS_EVENT, &newsid); if ( rc ) { - printk("security_transition_sid failed, rc=%d, Dom%d\n", - -rc, d2->domain_id); + printk("security_transition_sid failed, rc=%d, %pd\n", -rc, d2); return rc; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 21 15:32:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 15:32:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409840.652818 (Exim 4.92) (envelope-from ) id 1ob1iB-0003Gn-Sy; Wed, 21 Sep 2022 15:32:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409840.652818; Wed, 21 Sep 2022 15:32:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1iB-0003Gg-Q7; Wed, 21 Sep 2022 15:32:31 +0000 Received: by outflank-mailman (input) for mailman id 409840; Wed, 21 Sep 2022 15:32:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1iA-0003Ga-EN for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 15:32:30 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9997fe12-39c2-11ed-9374-c1cf23e5d27e; Wed, 21 Sep 2022 17:32:28 +0200 (CEST) Received: from AS8PR04CA0119.eurprd04.prod.outlook.com (2603:10a6:20b:31e::34) by PAXPR08MB7335.eurprd08.prod.outlook.com (2603:10a6:102:220::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 15:32:18 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::d1) by AS8PR04CA0119.outlook.office365.com (2603:10a6:20b:31e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16 via Frontend Transport; Wed, 21 Sep 2022 15:32:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 15:32:17 +0000 Received: ("Tessian outbound 0a0431bdcdb4:v124"); Wed, 21 Sep 2022 15:32:17 +0000 Received: from f2b5ca3ae22a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 48DCA39E-4BF2-4A68-9C4F-FB2787F54250.1; Wed, 21 Sep 2022 15:32:10 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2b5ca3ae22a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 21 Sep 2022 15:32:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB8642.eurprd08.prod.outlook.com (2603:10a6:150:83::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 15:32:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 15:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9997fe12-39c2-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Yfplw0K3rSiuC+qPz7xNDPvFHe2qt6GmrKnO1/R3HAubLkTReq2bTXoWc12xaVtNWcXHzau+Tul6CeXrs5yaQAl742CckWztYXAhxL8gI3iSeOlm3JhBXIsl6NYbUhNnjoSiWDFbwzZKczwZkIzVrS+zesx0eagKanNiz5qohdmIt4ueJLOdg6TnaSCVre5ETA6Sk9YZXvc/WdoYl+Q3ZBKvXhAsELQd2ev3LPnVpT/e95zcTDA/yLF9c6mrsKSwZmnqgeiL7AYI/36ZQ+n5/XRX+kmk2+J60sOFjOaMCUVhehbk11QdRlwb1amx5s09jemgS1/8HdLwh5OU8b0ykA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PRDo78G4PfJw+4DXqcUnT6xHLfTRuKR5iO8Bj15DWuk=; b=FNYHnRU542ztgF+Ek97HW33/vMuCelTnIF70/SFdQcJGrVJRhMUJKKTLyKZmpW471ccmAWyvE+/YLeL90vbWYXj59CnUv4CDx7/+cIaQZLOPeIrWBKucVOlz0x1KY1u2c+ouMNxHFWXHyFgbuWBg3lfbl4xdFV3cK/+NW/MYVp6qgpNN+tcOxKROozBMSlqP3CPpssFlcrKA9525z/Vqlmn1gyYuIwVXG5gq0buVD7LInVqW9pfZm7p9ILrEZIwJRlaQ7KJVzH/RmzFhWsFytpbyyeUY6vBJFoJyEdtuoXF37VZJT09PCW9NgTdwbnqlmWzUJOZzpOc75kS6TR85gw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PRDo78G4PfJw+4DXqcUnT6xHLfTRuKR5iO8Bj15DWuk=; b=6pFFFp4RJ0q3j5Icg0vdmFW1bGolg3I0bKRBpVIbtOf+I2+sdSZX1SQoMcpIwWSy41J8R2mm+i9zJyDmFt2DGjta8JMS+WZJtVp4J616BEXgLTHoIJNzGjEBoR+/T7iejtieMI0UIfte9TkE9nYi5EZ9P6+pAJ7zM7wGArpsKP8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dcad597ef16742b9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqp7PystVYa/ZKkestB3s5hzsdD7Vcf8QeNWjfWe9CHzyjo8AgBdZdh2eWPveulr9qDlDYMnGwmWC3XO8ysgbmRszB57akxYY4uHbhl9rdmWYneGlfpWN1NeyG39z1y4Ly/OusvkV9bG95C1M00zbKdzUratctLTV6NLGKwai4rz5UyKIyv87tBQtb1FzVAk6diA9z2wtr5pag+3dIyj01cWO2bvKrMgjco5NF+YmbmEnDBSfAMdVV9wCTygBC+s50GldBTo3HAUrnR4DugyJod/EXGk1S2SGwPoc4TIyYxFTZ/qQ5cLq4ykze1nZVNUFrAbSKZbC59CrGNSRl2yBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PRDo78G4PfJw+4DXqcUnT6xHLfTRuKR5iO8Bj15DWuk=; b=h0Cpb7BavVpCCiUFiDKShJeUEo3sLuIj4nazNEq/konrzOek8bsec+UGUmANbuDkmw8SSzNeg0CIKqD/kr5FXxDavo18ky9EKYoe77yJmB95hCGfqRdjf83MO3MYYmY5eseWU8kaLnyDPLFO4YVXry1+2gCZrhQGxHXEM3FRunDx6P1dHeXQHKjVHj+AqwpKgb9Tl2S++G5zc78iegiiDpkqTkmkZygzp2cq8g42WmBrAF3tJaKPYiPs4mX7zpRvQ51lloAcN+rLGUrKobSHeb22NrZXd0SeYvulkyAv8e1HzTcdVegrGqiKEGEodUkN3hS+Qm1rVd5nRWPDvaqVeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PRDo78G4PfJw+4DXqcUnT6xHLfTRuKR5iO8Bj15DWuk=; b=6pFFFp4RJ0q3j5Icg0vdmFW1bGolg3I0bKRBpVIbtOf+I2+sdSZX1SQoMcpIwWSy41J8R2mm+i9zJyDmFt2DGjta8JMS+WZJtVp4J616BEXgLTHoIJNzGjEBoR+/T7iejtieMI0UIfte9TkE9nYi5EZ9P6+pAJ7zM7wGArpsKP8= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard Subject: Re: [PATCH v2] build: correct cppcheck-misra make rule Thread-Topic: [PATCH v2] build: correct cppcheck-misra make rule Thread-Index: AQHYxnN181ZyqpP7MEOQ4AIPrjEu+K3qEbaA Date: Wed, 21 Sep 2022 15:32:07 +0000 Message-ID: <1ABAE409-7419-4F3F-AC7D-EE71AB0ACCD4@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV1PR08MB8642:EE_|VE1EUR03FT043:EE_|PAXPR08MB7335:EE_ X-MS-Office365-Filtering-Correlation-Id: eb68b2ef-a1ca-437d-88fa-08da9be67794 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zvJQyka/gL+Eduog0Fdz9VNaE78X3zvrM/T73JpEYb1HEdtJedlpipD9tXNDrpIeleV4N3GwDQcrm+LQbjokM+6f92O4lp0TAz8USs0Za93cUR8igXBvsslVq+N9NILJn02z3HQxyxd/w+XBepGpAWmFR+eZw3qN3Wum/V85JjD7eHCUMQtlwFo6zT25APD+s4qKj0ZZagf4217zXuqq9C/DF6bQ+Rm3qOnHkgywCd/RI+fT5qfx0wbFqCbcJ32WQ/xS4vPH/kEFiEpcfRKlNQGsZxK2eJaiSweWd20jHTnnx1Xz76uIjv/69CMaQHsFY8kNRLhc7sxCfHAW3IIcyjPZTG/ihvfP2ZvAhc4u/BfcvvafYYOoeyGaQ/OGYjrDI5s0IGkgIHWsyFWoqs9vuprJ7+5WjR2mAy5hKv0PKLTridgZXu2P/d/s5NlYtyjtMW6yjI1IUWM0mQZ9Oz4Zh14i7SwKvu8fY0876iKp9hkvEI3fTlzLKKzrOa609xMG7j/JQdIesF+L7byNp1O1B2+HDnYZLZxXBBOhC158SwLV7oiwzG3EOK4zdljbR2/gtjez24p6FbY2vSQlkI8o1MyybM4rRSLU+Hws/OsuXGkZGvc4vJWP712DCEuTKnjJZk0F0uowjVVPaxP6nZXSibgyhnnu2iILyDZ7OTJGiWmB8W80bXFZxRjvve59/8gb66unsBXaNlO8oyOx6zSfs0ijE4NcnX0yp2b4p5Cyufp9296rKQKcbPmPJqFV34ietU9quz0fudoAOTrQXMH/izNxpe9asRmPWwk3FpBSg6Q= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(2906002)(86362001)(38070700005)(122000001)(38100700002)(6486002)(478600001)(41300700001)(71200400001)(83380400001)(66446008)(54906003)(316002)(6916009)(91956017)(4326008)(8676002)(66476007)(64756008)(76116006)(66556008)(8936002)(66946007)(6512007)(26005)(53546011)(5660300002)(6506007)(2616005)(186003)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6C7E9814DC802A4DB16B28107899EB09@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8642 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e66e3f44-c155-4a7a-02c1-08da9be671a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fgqg6801M6vvfubXT4tE+ADoCwQT3KULoQ3nHDQgJ+gRE8tFJeCVLGou9KFKis40XURi8XgBmgIewu2cgLxWx1J5wsuynJHgdKZPxCiN/faTHS4w5oG6iEPu7LVCBNGxcOpJIc6GolcE85r+RZmnPTxCWunXtl8YLqJNzJ/cyJNLN6YOGMjFLfKA59tIPhWRVbHG6cqNJSwkka5z3X9glG7s1UyYyMbqXc09JIBk3iibzsWmHrp8WRekZbm35dTi7Z09UKLRbhH63v4fCyFWwcI3mNS6Zczd8utk4kR+i2UlBJ/Z06FxZPIveBxtCajiEfNNb6UNdluN0xdf6FgamYPj+mCFSoBhRXrW6wzGkRpb1lqnOuUuhyqA8+4MHKILfsnHISVq8kjZetdpu6TAHlCzCIiA/AYuGELfBoJF/3xcyMHyI2lNh21EGNHOBCB7n6Emu2G0v0rj/5mLzEiAmPzdiuw86Q+eqq2iIh2372DaZBdp/yPUQXLUFMD4IjkY6V/zmj0Aea+SxKMHSOesQhhWBvakPmXQ7x4/y12g63yFjc+LaFNZRpV0GyyaDvQWIsVu/p/fEKnAz5qUKadYoYUE63EMuIsNA2AsqqKdfHwzLJEFPpZhISdWDzxhXHsavujR+djdhhcpan8eDtLBLoLfcJCkse0a6QkFRGIKVHB6yKulLT4gka/E1cUZPz8GRHc/nrBcR0Hqld0T67iGz0Qf9JwwvcgJJ5lE/GI5Wm+b4aqZ73WnDA4qOvtbTHlUSbpXVtTltGFeEORyOSPNJQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(2906002)(6512007)(26005)(82740400003)(53546011)(40460700003)(86362001)(5660300002)(47076005)(8676002)(4326008)(316002)(70586007)(33656002)(186003)(36756003)(54906003)(70206006)(6862004)(8936002)(336012)(478600001)(6486002)(356005)(40480700001)(107886003)(6506007)(82310400005)(81166007)(41300700001)(2616005)(36860700001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 15:32:17.6274 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb68b2ef-a1ca-437d-88fa-08da9be67794 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7335 Hi Jan, > On 12 Sep 2022, at 07:46, Jan Beulich wrote: >=20 > Having cppcheck-misra.json depend on cppcheck-misra.txt does not > properly address the multiple targets problem. If cppcheck-misra.json > is deleted from the build tree but cppcheck-misra.txt is still there, > nothing will re-generate cppcheck-misra.json. >=20 > With GNU make 4.3 or newer we could use the &: grouped target separator, > but since we support older make as well we need to use some other > mechanism. Convert the rule to a pattern one (with "cppcheck" kind of > arbitrarily chosen as the stem), thus making known to make that both > files are created by a single command invocation. Since, as a result, > the JSON file is now "intermediate" from make's perspective, prevent it > being deleted again by making it a prereq of .PRECIOUS. >=20 > Fixes: 57caa5375321 ("xen: Add MISRA support to cppcheck make rule") > Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > v2: Add comment. Add Fixes: tag. > --- > It has been bothering me for a while that I made a bad suggestion during > review; I'm sorry for that. >=20 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -746,11 +746,12 @@ cppcheck-version: > # documentation file. Also generate a json file with the right arguments = for > # cppcheck in json format including the list of rules to ignore. > # > -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/co= nvert_misra_doc.py > - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j $(@:= .txt=3D.json) > - > -# convert_misra_doc is generating both files. > -cppcheck-misra.json: cppcheck-misra.txt > +# convert_misra_doc.py, producing both targets at the same time, should = be > +# executed only once. Utilize a pattern rule to achieve this effect, wit= h the > +# stem kind of arbitrarily chosen to be "cppcheck". > +.PRECIOUS: %-misra.json > +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/to= ols/convert_misra_doc.py > + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.t= xt -j $*-misra.json >=20 > # Put this in generated headers this way it is cleaned by include/Makefil= e > $(objtree)/include/generated/compiler-def.h: From xen-devel-bounces@lists.xenproject.org Wed Sep 21 15:38:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 15:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409847.652829 (Exim 4.92) (envelope-from ) id 1ob1nT-0003zJ-Gw; Wed, 21 Sep 2022 15:37:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409847.652829; Wed, 21 Sep 2022 15:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1nT-0003zC-DQ; Wed, 21 Sep 2022 15:37:59 +0000 Received: by outflank-mailman (input) for mailman id 409847; Wed, 21 Sep 2022 15:37:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1nR-0003z4-KV for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 15:37:58 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2077.outbound.protection.outlook.com [40.107.212.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5beb5f01-39c3-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 17:37:55 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH2PR12MB5018.namprd12.prod.outlook.com (2603:10b6:610:6e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17; Wed, 21 Sep 2022 15:37:52 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 15:37:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5beb5f01-39c3-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qe5LO/6JpaLKZVvh5LVm8+4EL4CjFe5dnnBjUYtuQPlMMU3re+VwveJAqBMN3Hksk8O80301dpZ28NYZNmPZh4ZblgItFoVd9ydZUhw6goeXd1eEBGXhuA5UysqROIXdko6hjRC+aqzWYWdMVcFXlLQ1eTR5rGlJKFRE8ojlOI50jRCvnKFl7Fax0b77ByADg0O8iO2NBKhNUJgFTu3S3BA4Cc++RRs5B8pjwYYvQSEYM4Tw/lpo1B1eqLONyMLIj7AAfITkSlIBJWco/agHYxFY/GGIB0pjCoi3fSv1TIWZOWWcJpJYZGiZqxPDt9tbP6/do/0NOeuaCPe6e1/5fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXlfI9hpCimOS0+PCSu7ySuBC3nN804dKKFN0UsrTP4=; b=hzlmGq3yjcbQzJzv2UdamTfawCQr6SAzxesEgcEFVfYtZ4XWFVO5hBzTq3/lbU3EY7Y/USrcfH+ItXSzpB3A9aby4gVveDn/i7yioeWA63Cim7QY8VzyoJOjlsXhZvw0TT7epkDr/QeJb1xigU581AZ8DTLjPhU2y9hJpjNYT2aflkmSMZ0EggWlgFG85gWWxFIks8S0FkEuLYTu4pk4X34h/TKS/MaeMRYAs1lBsjIrqmUKw2f/AMtA/bCHuxaGoUoB5BH30fChUCvikcRG9FdEvjoz82ZRmxVFekNxEerHcSObOcwUh50uXhd1AwG3MMJc5YXt4rlM2MSIY11SgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXlfI9hpCimOS0+PCSu7ySuBC3nN804dKKFN0UsrTP4=; b=lMXR87dYURErXWW6DZu4CsIrNPYzSHOB3nhPmMJ+ulwKfMMxmxO4QAx+C36K/0LmMG/QGcFDfyb1A9znpONsRlkBFXl9kbNMPWWQLiVAp7kvgl4HXGojGQn5UjJrSAFiX8wQxjM0jLmNlywHGogsNULufQiji0FfOmfG5Ajqh7s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Wed, 21 Sep 2022 16:37:44 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Ayan Kumar Halder Subject: Design Session: Resource allocation for Guests To: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0081.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::21) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH2PR12MB5018:EE_ X-MS-Office365-Filtering-Correlation-Id: 24a12b7e-5056-4df1-cf57-08da9be73e5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zb7dV2yE+DZNfrk+29tsxCg50HS/HSlQmNFwM0gT4UOtGmTEQc3JIozcPq0ctBlc6RYk7BFPC4ISXYXRIealgjX7bkq3oJzqg/nSkkxK459kyIk82LidEQ3s40TBwcEVO9f75b7Cul2YMT8T3Qq3hs7/3uB2K5UGCxkZA/2QLmwMLGmofGv0GEtRpD6jjI5/GAEzPYC+2oDjbB2cXxAPFDaclwArzEz+jUdvhInv8oq3W5n2m86a44gcY1UDGAlWmg5LBRquq2OtU4V7ycOitJFl3SRXA1JtrMH53XKeySU4dW2gie+NceH5RFf48ILez+9Hy+hr2KbtwhY/mN+UqawzibKPmyE+hUT0J/qf/5HJEus9vQSOcR9TGdogO4BKJ8eEZ70qNLVn55sgHOPwF9z9yIQtxSMQzEqwGSUTpa4VbUlOItcXuK8XTa1pQVSh46rM+x7Novo9iw0Ssv5J46fzaNBzadg5HsyqgW6Xs5bHaCo1+p2v2a2rDeDxepKApoCpR5YxyshTB28x0Prs53b3M3pnVHk+EmpXpwe2bikYYL2FGAIpf880h5nW07sEnZIxlfR1YJtk8+DSc6Z1u9hI7kWqaafQXbmYJRI63r7fprHvWEgGgtdQoep9TAt//UIzJPj0ehdo/fyg5LjCB/qrR7hg0+AStyEXwirQ5KGYDadZUxRtIbZiwA9x8+RFMwXfGathSZA/0Pg9Kzi8BQ6wWuWehr5R5BqWHPzzxrdou9BZ5GN7c2mrjt8vet79A5uqj2TMtcEbgelk18gJr3N2C9oJoLdT1X7cTd8+bhM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(451199015)(2906002)(36756003)(6916009)(316002)(5660300002)(31696002)(26005)(6512007)(41300700001)(66946007)(66476007)(66556008)(8676002)(38100700002)(8936002)(6506007)(478600001)(186003)(6486002)(2616005)(6666004)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekI5Uld0ckRKUitVV05qV1BVMTlUN1BzN215a2wraUFSM3JhSWU4RHpqQ1dG?= =?utf-8?B?c2JQek1iVEhGODRuT3N6Z2c2QWRrTjZOY3V2TVZHcDNxSXRJV0dPY1pSdHRk?= =?utf-8?B?bmMwLzhEa2FtN3RVRk42cTkxL1puUElDY1JwMXhqYS9LaW9udnkxNXBmbno4?= =?utf-8?B?N1BhcU1MaE14WGdqYjdWejRWbTZTcUx5OGZrYW9iVXJBd2FsNThqRFpYOEM0?= =?utf-8?B?Z0paRjlQWWZET3drcDNBQ21wUnVRelg5OGRyVXd5eThkMjhwUFJzb1JmMlUw?= =?utf-8?B?UCtzRjcyc253THlCTlZUYUUxSGpYM3RHYnREenBzVTVVbUc1VXF5RU05WmRi?= =?utf-8?B?bmQ2eE5hRHk0ODB0T3g1OG43RlFxV01PYlhJOVNBdkJVbFhxL21vaUVOSEhV?= =?utf-8?B?dVdkQkhmdEw3WDFDanZzbERVSjhXakxLNmlrbFM0cENyZzNrTy90aWU2OTg2?= =?utf-8?B?aWkwYzBHaERJaFJQbEZ5SEMwQVpDTVVtODFNRXhZenpNd2xKdmN4MngxRTYv?= =?utf-8?B?YWxrVGd5M2IrNEtXeGtlM2p5WWNPY0Y3ZFQwbTVmZWFkU0I2Z3pLNy94dkht?= =?utf-8?B?UklQUm9PSEhVOUI3cHpXVDRoYllHL3hYZUpWN0MrTGZnR3p3dXdDL2FYbEMz?= =?utf-8?B?QkVYWXl1dGZJTStEajlGQUJWaFlDN28veW1XWXR3cnhvKzJpTUc0UkdxN3VZ?= =?utf-8?B?WURqZUhQcC9vUFdxQmRLcmtLMHRuR2VHREVYN3VmM2ZPNGNSZ0pVVVBJbVNC?= =?utf-8?B?SHlRbW9FM0VKNW56blB1ZkRpb3JYcXRaOEExQlRXbjQydXNrTkNTZEo3bDVW?= =?utf-8?B?RDh0dzFocjVZTWJ2NHlrYW0rczZiaUlrUTNWOGxENE02RURFTWFiNXZsU0tN?= =?utf-8?B?L3BKdkpMdUNxNnVjYWxCN3JIbFlEcnN6bHRSVU1leWhOYWFORE5ST3dQa3FG?= =?utf-8?B?ZHFWOFhySnc2L29TazkxdTZQMFZPcnNNZEp3OUYwcGcwM2U2RnE5VnRuaDNF?= =?utf-8?B?N1A5SU8wMHFlMTJTeDd6Y1RmT1RnSGJ6RXMrTkVpaFpHTWxkVzgxL3BUNWtr?= =?utf-8?B?cXB3Y0xkYUFKZmV3Z2JOK0lXQkpUeGtvc2FFQitZaTZJZVdEK05UemZGLy9N?= =?utf-8?B?eWYwNnhCUEpBZkY2Y3BsdjBMS1hQUjVJTjIzaVdQcFpoMmsyQzNHeG5LWWZp?= =?utf-8?B?WERJVXVFQWY0TkRuR2xsNGM4NG1RaWpUTFgvenIycUd6UVF1bnhrYmx3ek1j?= =?utf-8?B?TGRFaG1zS08xTUxFeTUxaHcxbDNaYjRmZmJGanZVbHhadE9KSzZYdFQrVDl0?= =?utf-8?B?L1E4WW1TSkxjRzE4Q3pDOW8xT3I5Y2IzM3E3cHg0VFlQNXhhTkI2YUpMSjdk?= =?utf-8?B?OCt0Y0ovdjh3OWEvdzZYYlJ5K0o2KzVZUnpPbGNOS0xrOGYzU3pRbDBTTWNI?= =?utf-8?B?WmxhdG5jb3lVSStVUHRsbUQvVnRSR1h3MDRJdDY3WUdVUnNCRHZETnoxdFRL?= =?utf-8?B?TDBwdldDL2c1bklIRnljdTVDenN0YXVQN2JYVWRDRnJicitvZ2l0TE1jdjhq?= =?utf-8?B?WTlqNE9pYXBHY3Z3ODNnTjZlVHExZ2pybEF1ek5jelE4SWdneGgxdWNGS2o5?= =?utf-8?B?elRyVG13aW45R1FHK214TVFycmJJMExKY1lxWXJ0dnZtZ2lJWEU2SXFXS1VL?= =?utf-8?B?T0pvK1VXa2NkS2tqWWI0SHMrcC9ucVhISUZwMFVqYTBTdUw1Z2pLQWN1R3N0?= =?utf-8?B?RUppdW5Jb2FRWHhHbHBWOEh2d3FLNXRFanpHTjhtQktaMW1mVTdSMFlWZTVo?= =?utf-8?B?dWFIMzNaanR6aUNzbDA4eUVDSVIySjBKY0V3YWNJdUt6Q05pVm93M21YSktN?= =?utf-8?B?UDVYbDdhMGhzRUgwR2hLVm1lZmxiYVQxN2dNR08rOXIvblZqTWtaZXlGZDE2?= =?utf-8?B?bm5BWk9tSzJRNC9ZaTAwQVVsVURGanpaYWJqYXg2M3FmRWVVcklIMDBzYzZE?= =?utf-8?B?eEduRjBaeEIzb1dYTlJhTmVHb1ZtOWJuU0VNS1FzTytETjhxcHNzU3d0WmpD?= =?utf-8?B?ZFNPWm9uS0V3WUwrUXFNVlc5WlQ1OTBCRDE2OGhjVDVnNXUxRVBRZ3JBK1JS?= =?utf-8?Q?0RaHLdM/jWHiDc5lbekRQRXR+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24a12b7e-5056-4df1-cf57-08da9be73e5b X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 15:37:51.5269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wfQk26x2Y11mTvJXfaWq+Gwv2dIdzcWBV/dP2sFG8X0ivc8Q7F4z0KT8mqxk09PVVixGhWjHqEWe10eI6GH+vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5018 Hi All, Please find the meeting notes. Please feel free to correct anything. Jan - A patch series got stuck because revieres say contridactory things. Do we allocate all the resources when a guest is created ? Or do we can allocate resources on demand (so first time a guest asks for a resource, it may fail) ? Jan - The guest lives or gives a bug George - It is good to know ahead of time that guest will not fail. Jurgen - For Virtio, this allocation required a significant amount of memory. So do allocation on demand. The guest will know that it will allocate resource (grant). Why should the guest allocate extra resource in the beginning. It will be nice for the guest to say beforehand what memory is needed. Then hypervisor can adjust resources accordingly. Also tell hypervisor when it does not need a resource George - Ok. Memory allocated to the guest at boot. The guest can be ballooned up to add resources Jurgen - Guest can add to grant table. Jan - What we have in guest config file. Is the memory used by the guest. It is the memory used on behalf of the guest (eg event channels) George - We can’t do that now (would have been good if it were done before).XAPI does something to manage the resources for VM. Sometime, VM will fail. Jurgen - Why would it fail George - Xen can’t allocate the memory. The guest fails not during creation, but in its lifetime. One needs to have a way if the guest needs to use a feature, then it should be possible to free memory. Jurgen - Dynamic resource allocation, give resource to hypervisor Jan - Need an option in xl config Bertrand - For FUSA, we need to determine the memory size of the guest beforehand . George - How do we predict the memory need for a VM ? Jan - Extra memory for guest will come from the guest. George- Need a way to make sure that the guest has the memory it needs. Jan - If you have separate pools per domain, how do you associate each pool to domain. Andrew had introduced dmalloc(). Bertrand - On Arm guest, this is solved. We have separate pools of memory. The x86 issues don’t apply. Jan - Grant table / event channel in common code Bertrand - Not very sure when allocation happens for common code. Using memory for guest if you push to Xen, means unmapping the pages for guest. Then you may need page tables for Xen. The problem may increase. Jan - On x86, this might be a problem . map_domain_page() does not need a page table. Bertrand - Security concerns. Need to cleanly unmap the page when it is passed from guest to Xen. When you create a guest, you need how much memory you need. For ballooning system, the guest cannot do ballooning after some time. Ballooning systems will need two heaps for memory. Jan - Config file memory, guest sees as normal ram. It is under the control of guest. Guest can decide to use extra memory Jurgen/George - Guest may say I need more grants. How much more memory do I need? Xen tells you. Guest ballons up in domain heap. Bertrand - The system is not possible to know in advance the memory Jan - For grant table, this is possible. A new grant table, will give you a ratio of the memory for each entry. Jurgen - You can’t document. Bertrand - Upto the guest to give more memory. George - Guest fails until it gives all the memory. Jan - Add a new grant table so query grant table. Jurgen - Querying how much memory a guest needs. (If the free memory falls below 64K, then increase it to another 64 K. This is Linux approach). Jan - Indicate how much memory was missing for last allocation. Marek - Subsequent allocation need more pages. So you may need more retries. Jan - Error handling code George - I will make a guest with these params. Balloon the heap. Try if it works. Bertrand - The code becomes complex where the guest tells how much memory it needs in advance. George - Robust approach, is to to retry to get more memory . Bertrand - It is not FUSA safe. How much memory a guest needs (min heap), then a have ballooning system. This should work for x86 and Arm. Marek - Guest memory should be allocated upfront by tool stack (know what is the initial pool). Jurgen - Old kernel do not use ballooning system Bertrand - Add a new guest and it crashes. This is not acceptable. Jan - Provide the memory (for both the heaps) in xen config file. Bertrand - Keep this option as a Kconfig. Make the code generic enough. George - Set as an experimental feature. This may not work. New feature may gracefully handle memory failure. Jan - If a guest demands more memory (after converting grant table), then this need new configuration. George - Set the number of grants (instead of pool). Bertrand - Prove a debug console to say which guest is using which parameter. You need end up giving more memory. Jan - Xen should report what was used in the lifetime of guest. Bertrand - We cannot have a realistic view of the default memory for a guest. Jurgen - The sizes are limited at guest start. George - Permissive mode. Allocate first from private pool and then main pool. Like running SE linux in permissive mode. Jan - Could work for permissive mode. Roger - Why do we want to move the feature to tool stack ? Do not expose feature if the guest does not use it Jan - It should be the hypervisor to determine. Bert - If the user want to have a default value, store it in Xen. Jur - Required for Qemu stuff for special cases. Roger - If the guest exhausts memory, then what happens. Guest kernel does not use the pool George - If the heap runs out of memory, then it is a vulnerability. If a user can cause kernel to exhaust memory on Xen, it is possible now. Roger - The guest gets killed. Jurgen - One guest should not make the host unusable Bert - A guest can impact only itself not others (FUSA). The pool is preallocated on guest creation. George - How to send feedback from Xen to guest telling it does not have memory. Guest frees memory Roger - We need good ref counting for feature. Jurgen - The grant table may not be used all together at the same time. Expand grant table for this feature. Jan - As we do conversion between xmalloc and dmalloc, document everything to influence calculation. Roger - does not work for dynamic allocation Jan - By documenting the various need, avoid situation where guest runs out of pool George - Write tests to allocate all pages. We have an agreement to use per guest pool. Jan - Permissive option to fall back to main pool George - We should make a pool, set aside what is need. With permissive option, throw error Jan - Guest will log what is allocated from the pool. Maintain the max need of memory George - Guest will write down what memory it has allocated. Bertrand - Add a structure for the guest for counting. Some places need to hack Bertrand - At some point, every allocation should happen from guest. Not by Xen Jan - For PCI hot plug, allocate memory from Xen heap. This may be a problem when there is no dom0 Jan - Why would a dom0less system not see a new hot plug. May be dom0less does not detect hot plug. Dom0less with ACPI was never considered. Bertrand -  (DMALLOC) This has been done on Arm George - Until dmalloc is used, allocate upfront. Jan - Let’s not defer further allocation. Also, we are moving to per domain pool. Greorge - Dynamic allocation increases chance of failure. Jan - Replace runtime allocation to dmalloc().  Then switch over. Then convert static allocation can be converted to dmalloc(). Jurgen - Design interface to guest, so that linux can use it Jan - The only interface need is to indicate ballooning (private pool). How large the private pool is ? Jurgen - Easier for linux to buffer allocation memory and not retry every time. Performance is better. Bert - You need one more page Jan - Guest should report how many free pages. Kind regards, Ayan From xen-devel-bounces@lists.xenproject.org Wed Sep 21 15:40:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 15:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409855.652840 (Exim 4.92) (envelope-from ) id 1ob1pX-0005K8-0I; Wed, 21 Sep 2022 15:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409855.652840; Wed, 21 Sep 2022 15:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1pW-0005K1-TV; Wed, 21 Sep 2022 15:40:06 +0000 Received: by outflank-mailman (input) for mailman id 409855; Wed, 21 Sep 2022 15:40:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob1pW-0005Jv-7h for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 15:40:06 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9ff962f-39c3-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 17:40:05 +0200 (CEST) Received: by mail-ed1-x52e.google.com with SMTP id z2so9339495edi.1 for ; Wed, 21 Sep 2022 08:40:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9ff962f-39c3-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=UkE1Uvo2VLi/vi+llqYADgTt3/eHe/MMoRBjfkfB2+Y=; b=UEsr0+bVmuAeq6wuYevs2+ggkjHR1GOqipkjtipHHP4brlv7RFFPFahiFWIG+2+/KI vB6V4dy0qZ6LXMXObj7lUuibbfCmaMlG8+YwOKTpAfuj4nLDTn7SAzC8KN2oU8zwo9u7 SEsGeHRCuAkOtmlxzCalb+fJrJ2nBvzte7DkGSMUgw6yaBF2kyPFga0Xg45PQl5CX74d IOiWAJNku9Z5eZfctgvHsGL5RE0ft7xqzQdVMFO6rs1IuvzXfQoCNuyL7t6muJI80Oq+ ne+FS8BsrhELPCujaxoCR8xntjJPw1ZHUDMh90gVdoWkFl5XlcUvC7lr43lFi1xr46E0 wrwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=UkE1Uvo2VLi/vi+llqYADgTt3/eHe/MMoRBjfkfB2+Y=; b=y6FHZjYZMmfU63qxjDaLgnunZGKffXipmV2J1tZN9m1qN9e/pcfXWMWZhCB+ZUSJfO ftBrLr268zF72Hbe00uur4UMsNIxzTPT/RnKo55WAo3VESg18LkjVY5FdTprs6iw84Y9 CYNd2L9BORFoOSKoeGK71mPVZFtl3+vidHVYwCChUDI3XVuC8+XUCHbce73s3fJSjhWP ZrsO8qTqexYe4HFxycWe04w02bxZGGrxnIe0P4WZwZIqW9Y6iW1jDLwomZVK0mKnXqvn m/Ko9sI3jV4OWzf0Mu1yP8oNpkSHmZ0nhHIl7zDv0vaPK6GTCgnYq0W7BXvC/8wvAK8J YCkw== X-Gm-Message-State: ACrzQf1fMqlasP72W9RKhbFGuut45nCfhnn3+aTgEzw2mmrwmz3ADMsB puXHazkoUTXlxwxWTMmsM8bihOnWR+3w2zdftlw= X-Google-Smtp-Source: AMsMyM7a9nMacE6vu4e+rhswsuOOwCPBp1WSP8CIK+ekPKeWXuRhbha27Hj/r3a9CdWEYaEbFZRh9GG89q9NjNuSWvg= X-Received: by 2002:a05:6402:3223:b0:452:ce21:b1dd with SMTP id g35-20020a056402322300b00452ce21b1ddmr25760054eda.340.1663774804844; Wed, 21 Sep 2022 08:40:04 -0700 (PDT) MIME-Version: 1.0 References: <20220921151614.9400-1-dpsmith@apertussolutions.com> In-Reply-To: <20220921151614.9400-1-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Wed, 21 Sep 2022 11:39:52 -0400 Message-ID: Subject: Re: [PATCH v2] xsm/flask: adjust print messages to use %pd To: "Daniel P. Smith" Cc: xen-devel@lists.xenproject.org, Henry Wang Content-Type: text/plain; charset="UTF-8" On Wed, Sep 21, 2022 at 11:16 AM Daniel P. Smith wrote: > > Print messages from flask use an inconsistent format when printing the domain > id. When referencing system domains, the domain id is printed which is not > immediately identifiable. The %pd conversion specifier provides a consistent > and clear way to format for the domain id. In addition this will assist in > aligning FLASK with current hypervisor code practices. > > While addressing the domain id formating, two relatd issues were addressed. s/relatd/related/ > The first being that avc_printk() was not applying any conversion specifier > validation. To address this, the printf annotation was added to avc_printk() to > help ensure the correct types are passed to each conversion specifier. The second > was concern that source and target domains were being appropriately reported for > an AVC. This was addressed by simplifying the conditional logic. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Henry Wang Reviewed-by: Jason Andryuk Replacing domid=32767 with source=d[IDLE] seems more user friendly to me. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Wed Sep 21 15:53:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 15:53:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409860.652851 (Exim 4.92) (envelope-from ) id 1ob22J-00070f-4U; Wed, 21 Sep 2022 15:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409860.652851; Wed, 21 Sep 2022 15:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob22J-00070Y-1V; Wed, 21 Sep 2022 15:53:19 +0000 Received: by outflank-mailman (input) for mailman id 409860; Wed, 21 Sep 2022 15:53:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob22H-000709-Pp for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 15:53:18 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f72c8a8-39c5-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 17:53:15 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7CFC5320092E for ; Wed, 21 Sep 2022 11:53:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 21 Sep 2022 11:53:11 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 21 Sep 2022 11:53:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f72c8a8-39c5-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1663775591; x=1663861991; bh=uwrXo0INqm 9jN6ZIm6RJvUZkVVHPagZuuXSryAI6i/o=; b=LnQ40G7fuJl525ibcaoEs87XdX aobPchrUBbhvVTWJLocFjWbUAmYI4lQQ/RrMhZ5BEbH1Gzu+IDzCODnZmtYPf87q +zH6lTN4WA6WLoBGD5N8JcDO7ZfvG4kiWBgnNg/kqhsRjnKBhxyJ3M94Y+OFcCBb Dv+QLwVXIq8WIzvvClUDsa32n018SgpLs0+FD00JSsaZn99mmhnItQ435d3WHltL +bslr3Q3GQmk/1PWGaU2lerm6sTwR4LzW1bmjqc1J0QU8wWiUY5uzIs9i8HoHeSO kexl/mn8RtiZLsamAdd6WbCCBPLQaq4UwRy/101tnENL5S2Y1GS4gQtHnBUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663775591; x= 1663861991; bh=uwrXo0INqm9jN6ZIm6RJvUZkVVHPagZuuXSryAI6i/o=; b=W vabXcVDzhvvvcqsaYHuGz+oTMWZaUkBV4Ll803h9xJ+lAgP62Jmi8u8fPRWmADOM FUslE0iglQWeIyveSZ7ICBEsGg9Y7SHedF1y8Ij4jjWEHeT5nRy0+/pcF7ijsfjy NNEcXQx89YBLGJw/dcge7jvdN6fIbWHBeot7pxgAF+XpYUCMED03eD2zCcQ1IiDC Olvrxco4z99eb8MW3HSk4BKmBRUZi/gB3P0hM1OmpEG07IGwBgZrf0G2o3OFcYtE qafnyCqnBPj5g8TbdRWV3O5FEPyINCDBDNu6c8ANgSLxHqvjLh1Ifi6euynzMiC+ dhcKWLzMvH6FnYp7glg0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefuddgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnhepieffjeeuheeghfeutefftdeufefhieethfehveehteefgfeu udelffefffehledvnecuffhomhgrihhnpehgihhtlhgrsgdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 21 Sep 2022 17:53:07 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session PVH dom0 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ao6S49Ltxifgcs3i" Content-Disposition: inline --ao6S49Ltxifgcs3i Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 21 Sep 2022 17:53:07 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session PVH dom0 Session description (by Jan): In the course of working on an XSA I had to finally get PVH Dom0 work on at= least one of my systems, in a minimal fashion. This had turned up a number= of issues, some of which have since remained pending. Therefore I=E2=80=99= d like to gain understanding on whether there is any future to this mode of= Dom0 operation, and if so when it can be expected to be better than tech p= review or even just experimental. Open issues off the top of my head: - PCI pass-through / SR-IOV - passing o= f video settings to Dom0 kernel - serial console (at least when on a plug-i= n PCI card) J=C3=BCrgen: PVH dom0 would be nice, related to feature parity PV vs PVH (P= CI passthrough etc) George: gitlab has related tickets https://gitlab.com/groups/xen-project/-/epics/2 When completed, PV could be called "legacy" Stefano: dom0less could help with PV-less setup fully featured vPCI required Roger: still need to support HVM way of passthrough with qemu, otherwise so= me devices via vPCI and some emulated for the same guest Stefano: qemu is not certifiable, should be avoided in cerifiable configura= tions J=C3=BCrgen: use qemu for virtio Stefano: ioreq server needs to work together with vPCI George: move from just qemu to vPCI may move devices -> Windows BSOD Jan: no problem with qemu coexisting with vPCI Roger: some use cases still require qemu for passthrough (HVM), if some par= ts are special handling George: GVT-g(?) is such case Marek: actually, the ioreq server is in dom0 kernel, qemu only reserves slot Jan: host bridge, root complex emulation currently is ARM specific George: who is going to do the work? Jan: that's why this session, no progress, or even patch review Stefano: there was proposal from Julien about using platform hypercalls for= [???] George: track what's happening to related patches Stefano: PVH dom0 is useful Roger: EPAM already do vPCI for PVH dom0, minimal configuration for Q35 Stefano: what other gaps for PVH dom0? George: see gitlab epic Jan: hide serial cards - if dom0 doesn't enumerate it, something gets confu= sed (overlap check?) Jan: video information - for PV dom0 framebuffer info is in start_info, but= no equivalent for PVH J=C3=BCrgen: use Linux boot config protocol? Jan: Xen don't speak it Stefano: EFI services? Jan: dom0 doesn't have boot services access Stefano: that was video output on RPi Jan: do hypercall to obtain the info Roger: PVH is a thing on firecracker George: there are definitely more issues, but the big ones are the above J=C3=BCrgen: PVH dom0 performance? Roger: it's bad; mostly relevant is qemu interfaces George: only for safety certifications? performance penalty may be okay J=C3=BCrgen: hypercalls can be improved (virtual buffers?) Stefano: litte sense in performance optimization before feature complete Roger: limited capacity what we can work on Stefano: safety certification may motivate the effort George: sell it this way to AMD --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --ao6S49Ltxifgcs3i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMrM2MACgkQ24/THMrX 1yxjfwf/fI5zdBJ5aLgIKSJ2mfQRDSXbf16EuVcLUA9iMJMnt/KtiAWLeCe9eiAX RXsHBoUeTv2tYWUCzzaPzFt1dERv1z0FKzhM2SJFPcuCa1pJeOIlwQYqK9pvNTq/ a23DcwSvjC/Ajm+8WyWrYURc5CbBa0lfXt5bHX03dKGTB7Fa7aaPwICTcoKPl6ID 8dt4QhPRoIz1t+qHjaKRo62E1twolu1P9svCh5ID7XvBjqkjx9kcQdeCpqZHp/zx bh/akfvynSMt6LodHxpxJYQu6ZR03K+N7Rlvs7vdEkex+BFmod8AhKLtWt63z/+Y 5oz4NUojN8AShLGp4iBkJHG8f7hj6Q== =vA0t -----END PGP SIGNATURE----- --ao6S49Ltxifgcs3i-- From xen-devel-bounces@lists.xenproject.org Wed Sep 21 17:25:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 17:25:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409870.652862 (Exim 4.92) (envelope-from ) id 1ob3TC-0000El-L5; Wed, 21 Sep 2022 17:25:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409870.652862; Wed, 21 Sep 2022 17:25:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob3TC-0000Ee-Hy; Wed, 21 Sep 2022 17:25:10 +0000 Received: by outflank-mailman (input) for mailman id 409870; Wed, 21 Sep 2022 17:25:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob3TB-0000EY-IR for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 17:25:09 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5686373f-39d2-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 19:25:07 +0200 (CEST) Received: by mail-ed1-x533.google.com with SMTP id y8so9722017edc.10 for ; Wed, 21 Sep 2022 10:25:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5686373f-39d2-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=4EIU4Hy+tQ0GDed0xnb5Zti954ckG/5IBPdVDQ/JjaQ=; b=JPLjcQ+/q/woVokAwYy0bJjXAAy9+J2NbQg7rKeMMmjz+HocG17qbS0GmBsAaiCF9I rBIdsiFNZhFFdenY25Xxz2whvMHaihy0mKo0ygmLMUqvYG9wcV0iAFYlHjNxR5ae1CWM GohNGr2TTdC1lPCD7YjRElhrVMHK9gJDpeRnXaVkxQB+W3HlG4Io5QWWhrtAc3WeQe01 ti2PDuw1M5z2cNw4E7bpyM+Y/jPwIUAGFVZIOm0ii7qxXnO6KLXLxsHBzHckGjucwPqZ 4vg1lq3IDmtbGtooAy/f0f5taooh2R+5KQBxfzMuOoo+9L9nXcputOKlzg5A7gW0+N1/ sd1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=4EIU4Hy+tQ0GDed0xnb5Zti954ckG/5IBPdVDQ/JjaQ=; b=fQLAhhY8gIq9LrvVtGc14OYPqcNe++BfdNdRw+Fqo7yZoZMM/qNOSTi0AIdgqaA8MZ GZ54LH8r+Ll1CsTxevSlcA9IVdzS7fXn3oAvOlU9IOX76UlKWgJTaFBvbDaRnxogAHJL j0kWGZ1UKN2mWWdK0+zLLimKF1Cave4prqypK2JG3MQ3nJa4gieEwBK9+B1nX7VnF7A2 XGdRBdSnD0bb3URmTLLe7PkNyV8Xlpc3oH+tcc+Dh5Levu8rQvQRV/vrsZ5NYbp1aVOh MQ+/F96FEproXiiPVV+o0Zj7VeRx5BSIjK9ZFoSUiCYFdaBsuwflQ1c3Hlp7IAqNMGtO Uxzg== X-Gm-Message-State: ACrzQf14Ie2qKOixuJuNB/7k/Li7CL1u5vMBwX/MK0bKG5vlCzdEFlaO WA3Ee+hqFznjZQYg7A7z77LRnCVlrE3qtY4WeRjqWPm8 X-Google-Smtp-Source: AMsMyM5Z7E+saMNuzbVXY+5eMmtutOIUQtlA7+V3R4xxnIcswtWWvj8xds3RciE1H5vbtj5Q0uO2zrJj3gjG7mBQnhA= X-Received: by 2002:a05:6402:5188:b0:452:5395:a271 with SMTP id q8-20020a056402518800b004525395a271mr26230211edd.383.1663781106717; Wed, 21 Sep 2022 10:25:06 -0700 (PDT) MIME-Version: 1.0 From: Vipul Suneja Date: Wed, 21 Sep 2022 22:54:55 +0530 Message-ID: Subject: How to do display sharing between guests or bring up guests display To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis Content-Type: multipart/alternative; boundary="000000000000d9997205e9333978" --000000000000d9997205e9333978 Content-Type: text/plain; charset="UTF-8" Hi, Thanks! I am porting xen on raspberry pi 4B. I could build & port "xen-image-minimal" DOM0 on rpi4 & could port "xen-guest-image-minimal" as guest1(DOMU1). DOM0 & DOMU1 are working fine as consoles, even the network is also up. Now I have built a custom image with GUI & ported it as a guest2(DOMU2), guest2 came up as a console & couldn't see the GUI screen(Display screen connected to rpi4 via HDMI) coming up. Can you please guide me on display sharing or how to bring up guests display? Regards Vipul Kumar --000000000000d9997205e9333978 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Thanks!

I = am porting xen on raspberry pi=C2=A04B. I could build & port "xen-= image-minimal" DOM0 on rpi4 & could port "xen-guest-image-min= imal" as guest1(DOMU1). DOM0 & DOMU1 are working fine as consoles,= even the network is also up.

Now I have built a c= ustom image with GUI & ported it as a guest2(DOMU2), guest2 came up as = a console & couldn't see the GUI screen(Display screen connected to= rpi4 via HDMI) coming up.=C2=A0

Can you please gu= ide me on display sharing or how to bring up guests display?

=
Regards
Vipul Kumar
--000000000000d9997205e9333978-- From xen-devel-bounces@lists.xenproject.org Wed Sep 21 18:34:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 18:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409877.652873 (Exim 4.92) (envelope-from ) id 1ob4Xj-0007hn-Kr; Wed, 21 Sep 2022 18:33:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409877.652873; Wed, 21 Sep 2022 18:33:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob4Xj-0007hg-Gp; Wed, 21 Sep 2022 18:33:55 +0000 Received: by outflank-mailman (input) for mailman id 409877; Wed, 21 Sep 2022 18:33:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob4Xh-0007ha-VS for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 18:33:53 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef86fb44-39db-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 20:33:51 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 28LIWOn8002873 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 21 Sep 2022 14:33:33 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 28LIWOv1002872; Wed, 21 Sep 2022 11:32:24 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef86fb44-39db-11ed-9647-05401a9f4f97 Date: Wed, 21 Sep 2022 11:32:24 -0700 From: Elliott Mitchell To: Vipul Suneja Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: Re: How to do display sharing between guests or bring up guests display Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Wed, Sep 21, 2022 at 10:54:55PM +0530, Vipul Suneja wrote: > Now I have built a custom image with GUI & ported it as a guest2(DOMU2), > guest2 came up as a console & couldn't see the GUI screen(Display screen > connected to rpi4 via HDMI) coming up. > > Can you please guide me on display sharing or how to bring up guests > display? This has already been answered in several locations. The first place to ask for help with the RP4 is their own forums. Turns out the topic is well known: https://forums.raspberrypi.com/viewtopic.php?t=232323#p1775083 (huh, their forum moved to the raspberrypi.com domain; they really need an entry for Xen in their other OSes area) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Sep 21 20:19:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 20:19:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409886.652884 (Exim 4.92) (envelope-from ) id 1ob6Bi-0001aA-4L; Wed, 21 Sep 2022 20:19:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409886.652884; Wed, 21 Sep 2022 20:19:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob6Bi-0001a3-1k; Wed, 21 Sep 2022 20:19:18 +0000 Received: by outflank-mailman (input) for mailman id 409886; Wed, 21 Sep 2022 20:19:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob6Bf-0001Zs-NR for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 20:19:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a865969b-39ea-11ed-9374-c1cf23e5d27e; Wed, 21 Sep 2022 22:19:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7788.eurprd04.prod.outlook.com (2603:10a6:10:1e4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Wed, 21 Sep 2022 20:19:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 20:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a865969b-39ea-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GkdjXtIWCMEZTkRx8sQuqxlGAqq8QihihTCxUGwFltF3Wv+R2nxHBWOFyn/FMQsQ0jivI+I/VULkMbU49JAJuxRyqPjt1WbTDgaZsWGnu64U0dye7JzlsqXWL+PPCLVAXyJ7RKlpFNiTmspGn2TC/kf9Fh/i50isPU6EhoMp1Nszb6f37zO8T5PMLcAg6XyKj53v7Q55ntDilctCqxW/murRz2Ka+tDUOCs7ajCC2ZJMEbFMQk8VZ3gz5H4WYbwNFkp1iq+gOi7/Mx5Ws32d5e9Q6rtZtqLTQ6PcQIu53QYZGAuDp2ltVVavRrLl3y7fO1i/lKzhE9bqTfu2WwGZyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7JTEXtZ4eUxTaNfILWR9YdcZYL1ClHMAeGYP0olu6yI=; b=GyUQzDUQo4ETHQ7H+VfUavP4pPR/9I5yYb4QbbzLyLjAdIq4ro2369kwq3cj+Dx4ZidCHTEnNZs9wjZq7oirHYZHOG8PBMao/MF7W5IWHxnd6RXbSAo9HulttEYCgh2sq2lWIvpnviEn26x4ubZH6OO04vUrcSJ3grmjXO81ip6ETYNIpO8qhWbb3V8kacuDSt5FvoP/63tyQNdrjFPU9lRBKeYoFK1uWQ8K6iaUiSWgfF40L8yNv4u5CMKKfBNLkio4N0aVkcT5BeSa4lO0z7TMccrhmKUVa1uC2bsP9YXqZFX595S/AGsvW8rqT749AVhiCHZbZOfQBTG7zg4jhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7JTEXtZ4eUxTaNfILWR9YdcZYL1ClHMAeGYP0olu6yI=; b=xtWe7JURghnK3WdJUL2J2kjT/Q5h0MjVfa4NWTG4lpiuO0ThMUkTMx06QZD9n0u8csMsIWEuNlbPbFRsVowQUSLxEwCvmyO8bvyYaE4RoIK+aysNvfgW04PmVPfbvFWmpNy5LUn9SCHGO5BIiBdelXZzdenwCWO4VsJdGcGy4rtw4guH21rqFlr67bmHDvaigImEXnwHMhekt+5IqMA0LIclSKSL3eS8JPGq7KsRsqYO/zGLgMtNsRW0JwuDg6hObHqKBqiWbLLdsc/mHJ6B5VySbDqthWAUVL1NRSg5Y8mgvke85Ia1WhBYdUEcSg1sUSjcbaeEpbkrBAglCKUz/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <404f9f21-f5df-2994-76a7-c660ac8b3aec@suse.com> Date: Wed, 21 Sep 2022 22:19:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Design session "virtio" To: xen-devel References: Content-Language: en-US Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM0PR10CA0021.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bac184e-b832-4b77-285d-08da9c0e8b46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I2pDLl5/o0gq2q3CCStPTkhHsNaRBNHtxy7JxrpJlO/5oJJxlb8i+ElDGuPGLYbJJOJdoWV5V4aAhchSXIP4jbFzlFY8KY0QuFvv5OxvNkO+sdgFRt/YzVa69WlKffrdtiN0/Q5cZ9/3qoL0UFYVt+ilwRVyw7PmRIMzbcA+3SKzIdBi6oB36GviUTXhb5eVhwgu17pDIzACbun/8gVIbFnxnMGWfQg0llAHLz5HjhuLTBq511g+Y/w5+RD3rK6K8AtH5iI4CYGuemyWW5YAsmU3gh2XhLL9+KI0j3Q+Bbw09wZkEIOC/HJ9wbOLFDGLWnauQizIFS24SwFC9N2NRewlpWSmlbwOFTnDE405m4g8C2AP+SKioDh2fwFPHJgGkNxBDT0G97ADi6PmtETZABgD9CK39WY318eHbDpDIy5XuyELIb7JoWQmfgS2lvwxEhiD1TIlrDtlSnG2n7hIgFDT+kTAHE1ox9bg6F4PNCyaNxDreXh3HU4W8wtK2hrdWK+gSC+fSk5+pBAt2tC+/dBGKZWuBFFDQuh8hg0HBngiF9pyRgB9nmb+lvfgHAmPEyVY+FW4eDBzXIBw1Q3LwkgSfvGSDDdm8Fmtaq6viJGWoxbTtbF0Dh7jx8NnlKLCgCp7Q1RYjwIStFQ4K5/Hm77U28rWCpaYfjq4AUdojANQJym5W5xZexiCrpiYWTcTydv6s/6MbWvTMieH+0Kp3j209bbxyV4qgXvfVZi5JJkWAZ9LIeqiHl6qGQXdVnAPBFX84luBRbnL3XqChBBuw2Pc81UFrV5j3ogehNSwG2w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199015)(5660300002)(38100700002)(83380400001)(8936002)(2906002)(186003)(316002)(2616005)(8676002)(4326008)(36756003)(6486002)(478600001)(53546011)(6916009)(26005)(6512007)(31686004)(41300700001)(66476007)(66946007)(66556008)(86362001)(6506007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFRyY3BuSWlibDlZT0VyWFU3QnE5S2p3Njh5a2xvQmlObXhnZklpWlBMcEg0?= =?utf-8?B?S3hxbWxsZ1lQSEtnVjh5N0EwYkM0VXR0bUVCRnZobjVZMzFLdUs2NCs1aUpo?= =?utf-8?B?Vml0SXZEa3RCY0FGNHFKKzhjcnNheXhQci9Gcy9qSTNLVTZYTURyOS95Qmda?= =?utf-8?B?U3RkK1FZbzN0WVBkSkdnSWFPbDdEMWFydUUzdXJIOXdIVG9IWmYySHdwVXh3?= =?utf-8?B?OGxmSWFZclVyNUNSS2ZNR2RWT0pJbGFQb2FhRGVXZmF6b3ZFUUMwV0ZBd0dh?= =?utf-8?B?dW53NlVDdFZxUzR2bnFHYnRCSXp5bXg1L1kxcUhkdnlCZHRzMnFiU3AyYjlN?= =?utf-8?B?V0pMSzZVYTJTcUxJS1had1NQUTB6ZWNtNGd6bnV6eTFPQnpzYXBjaWNFQ29B?= =?utf-8?B?QXBSZ2VYTDNBQ0RoZTJBWlNhcmY0aG9NSkVtYmZwYVl1ZENJeHhyUTdNNUIr?= =?utf-8?B?OGJtM1pzS3FSK2VTaXBvR01RUXcybE5ML2h0THRtVStMeTZZeFN2M1NzZTVx?= =?utf-8?B?Z1hVWmE5NVFqQUQvakpyVEFhNXMyMUZDdzhneEMzd2Q4aDlEOVE1aVBtVUhU?= =?utf-8?B?cFdMcXQ2bmlmR05Ybi8wanFiN1dYUlVRMjduUUNGd2NQb2I3dWFGREp3WGZQ?= =?utf-8?B?eDdscXVhQjl0UjVRdFQ2RDZSTndxbVNCYlFrUWNSRWhuUlU2MURHN1QvODZK?= =?utf-8?B?NE83SUZWU1NjWmRseDBEU0IrQVNSYUpkTWxsUWhZNVZEMGlMZkpvVTBqam80?= =?utf-8?B?R2ZnN2FOOGxVZFpHWTltcnQrbDdDeXZ0TVN2Y282Vy9HVGZFdWN0RGpDZHBa?= =?utf-8?B?dUV4ZnBxYnRRckk1WnEwc1hBK2tFZ0E1L3ppYVFrdWlYaEk2YUsxOFB4T2tj?= =?utf-8?B?cGw4akdwNGlnNVBoU2NwdTZqekh2R20xSHFHK0grczBHSXJGTU5UckkycURk?= =?utf-8?B?TXE4dGlNbW14ZjNxTkVWemk3Z2pwand0VU5MQXhhZjU5OEFsdUY2MTAzZWU2?= =?utf-8?B?WHRRNWNxS3dqSlcyZHg2TStTSWdmeFpQTHl4Z2FVMzdqaTN0U3hCVXAxSVJK?= =?utf-8?B?cEtaQlpwMWxpaFUrUVdPSjQ5RlM2d0JxR3gxQU5BaU5IdEplQkhhNTd6ekJD?= =?utf-8?B?elpBNWxLNVRQbm9pSThHZG9uOER2R1FUbGNOekprM05mcURtS3QrbXc0YVkw?= =?utf-8?B?S3dKUncxZ1djZlJNaGx2NEY4NWF5U0pTMXQwVUYrenU0cVd3S245QW5wUXQ0?= =?utf-8?B?TjkvcDY2Ni9va3VIWEd0dWw3SXNpVVF0eVVWTXc0MFFkRXQ4QXhWR0xyaUFQ?= =?utf-8?B?T3l0YTVXcWRQT1FKTjFRSDd4R0tGcEo1ZFd5cElQNjlRcFFjMDJ0bUtxSTht?= =?utf-8?B?VlI3SFI2a3JoRGdYODl6WVJyT1FiNWNBd3NTVkZEVS93a3RITS9TQWExQ3hp?= =?utf-8?B?U2RPb2lWU1hObkcybVQ0TjhwdlBHK21hcmRjYVg1TUtNU3JMbG1FUVNOcGFq?= =?utf-8?B?b05NUnJzdVZOOVVlWitJN2dSeThGS09VQllYZi9xTmRSWFNvWGdOaVhHSG9s?= =?utf-8?B?Z3NKczh6d0UzTWkvTU5Ob0JJaFFSd3JxcFdMbit1cUc3Y0VzbGY1NGNTc3N2?= =?utf-8?B?WGtJU29mQmpUNVdFdE5zVnlIY1htQ3BYSEFtVVdKaUlWd3pUZlVHbWMvb08w?= =?utf-8?B?RlE5ZWZqaGRpUlpuS3JIMWlrdmg0Y0NDMit6cXNncitWSzBYZ3dLdU1CYnBW?= =?utf-8?B?dEZ4MVdCcUE5cThZTW5CcXpCM0h2TEtkNXYySUFRRlVQclBTSk1IQWdLTm43?= =?utf-8?B?bDEvNzZFOWxqSC9lcGxESVppREhGN1dkaVZtanhoTjM4SzNNRGhKRm44K3Qx?= =?utf-8?B?ak1KcTdnWXlZQlZJMk8yK1dYR1cvKzBaMzh5c2JSa2h3TDV5QjFlNXdSUU9z?= =?utf-8?B?OE5yK0d6TVJHcytzalcrS1BnUlp0SVhhR1VJb1NhTm56TDl5ZjB1TmhVWGNZ?= =?utf-8?B?elVmb2lqbWNxb2Q0b0J2SktVLzJFK3pUS3dIRDk5WW40MmlHQmk2OWZFejVV?= =?utf-8?B?ekNlU0RJNGZwcnNJTTI0OWtib1BJdElTVDA0Z1haV0xYcmtjNkFBMUwvOHpL?= =?utf-8?Q?MVVIGUORqj2juDynobRIp4Xxw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bac184e-b832-4b77-285d-08da9c0e8b46 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 20:19:10.8014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IbWWncWqbljziX1Tnp1x8TNF0FjDYevYvRw/vmbiTn05HtVlWVPM4qp6ZYSHomMf4VC54Ap4l5+uMT2V+fj4qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7788 On 21.09.2022 16:03, Marek Marczykowski-Górecki wrote: > Some sparse notes from the design session: > > Passing backend domid ideas: > - via xenstore: good - can be done now; bad - requires xenstore even if > only virtio devices are used > - extend generic part of virtio spec: takes time, but otherwise > preferred > > New "config" virtio device - for configuring backends > > Hotplug: > - ACPI (for HVM at least) > - xenstore > > > ACTION: Start the virtio spec change. > > In the meantime, use xenstore(?) > > qemu parameters are device-specific - adding backend id needs to be done for every device type - both at qemu side, and libxl side > > Device endpoint ID are currently allocated by qemu - for driver domains that needs to be moved to the toolstack, to reserve space for devices running in other backends. Thanks for the separate notes, which are certainly helpful on top of the ones I took. Plus I'll admit I was struggling some with typing and listening at the same time, so I surely missed pieces (besides likely also having screwed up here and there). Corrections and alike appreciated ... Jürgen - working: frontend/backend but no connecting - prototype using device tree - generic solution needed - ACPI (on x86 at least)? DT (dynamic)? Xenstore? - for frontends: limited but generic xs entries (central driver) Marek - Isn't there a virtio mechansim for figuring domid? Jürgen - would need extending virtio, also for hotplug - ACPI (for hotplug) not an option for PV guests George - concerns regarding the use of Xenstore - at least for static configs it would be nice to do without Jürgen - option: new virtio device type for passing config information Marek - Use PCI IDs or alike? Jürgen - potentially risky going forward (compatibility-wise) - (excurse to some KVM side aspects, which might also need e.g. such a config device for certain purposes) George - Is there a config device already which we could extend? Jürgen - No, new type needed. Roger - vPCI usable (for its config space)? Jürgen - needs extending the virtio spec, preferably for all devices to represent data consistently (which may take long) Roger - Use VPD? Jürgen - still in (global) config space, hence needs specifying George - Transitory alternative until virtio spec was updated? Jürgen - backend (ad ioreq server) params perhaps best over Xenstore - if PV, ioreq server would need hooking up (if to be used) George - PV requiring Xenstore? Jürgen - alternatives are (in theory) possible - Result: Aim at virtio spec change plus introduce config device - Intermediate: Xenstore? Anthony - Prototype? Jürgen - xl/libxl changes needed in addition George - 1) dom0-only + all grants (global), 2) xenstore (which would want to continue to work, once 3) config device is there) Anthony - allocation of PCI IDs currently in qemu, want to move to tools Marek - How to launch backend in drvdom? Jürgen - one config device per backend domain Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 21 20:34:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 20:34:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409894.652894 (Exim 4.92) (envelope-from ) id 1ob6Q8-00041p-GP; Wed, 21 Sep 2022 20:34:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409894.652894; Wed, 21 Sep 2022 20:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob6Q8-00041i-Dc; Wed, 21 Sep 2022 20:34:12 +0000 Received: by outflank-mailman (input) for mailman id 409894; Wed, 21 Sep 2022 20:34:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob6Q6-00041c-VJ for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 20:34:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be69336c-39ec-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 22:34:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8772.eurprd04.prod.outlook.com (2603:10a6:20b:42f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 20:34:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 20:34:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be69336c-39ec-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jG2aBLkuHhRFNtjfWnGtMcFiveh2BqS+QEg2imgRNrIpEUaDPerb50S8+k5qSWfXG3Ubt0dWQd45feXws/iR3wQhdDuNFmjebgMN0+S56mbHMN1Jaz4ZR2jiwjbqrIfQVNdpM76DQ+vpCVwYBovRMjtVzvKQD3IRa4o7p4CjLh3yyd0glLVOFqYd7Q8vm91UZge4tdmVVZdGL+ZUp5AOMGtQAAEyRnIN/AbI9p2wbJfgF1DJI70ZCEYNfDzFeGAm1KEbRf9v+yUiIaJMh9xM5yBbmj743RoxgbAfKlKGVxscV3Z6x4VSCTRKjTHyb8f3Ipe1oPG7JHy62PNDKNonUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tdxCv7mrQHXczZ8Wu54MQSZROOWZZozu5hVaJ4E5m38=; b=RbUYqbLQoeah0FY2vA6Hven5NF3/oZe9OdOLwoSnsE1PXnkJuQ2dCfgOj/KLdA/XgC1bskXvNv26RiLKbOeJTuXz5GTEV4zuwtIThIVNXneaVMKzbBorToLfg2ObAs2Yj1ie1T/l8E5oeB0lst3ldUp+mwivqFkPNhZSf2tpYHoMzc6Mr9xB5jPyjr2Gt368E4WZEwqPsfNkjthUoqlMPTe+fUo7dZltYr8x4LtrgIfNeRWwip7wpR10S1BoYPob7JbFmb0rrIc51OlIV7VI7AWAm0xRq5g/TsAggtLfCbtJw+1E4iumm2SzRNrsDE5zfoZhIdMCe77sJcSRKg/pkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdxCv7mrQHXczZ8Wu54MQSZROOWZZozu5hVaJ4E5m38=; b=D6m5KgPv4dU0Yoep/zNCq3cl8K4yDRIO9Hy8+BAcbdDrNJ6PasSmFoSPHmBPi7ulYnbYxnhpvqW2raQEhVG1xLE0uCh89eqLZCx18si3yl08NOq1HOC1UVDFOjao1bsUfjZy3kbb/+/oApXukTmKSISqmOdDwS+D8j1F00r7XVH5HMFYmooDAGRvEUTN+MD9eHarN6y09SyCAfAu/KZNTRJu2VdnoFXvQkiULDizXMVm3UVKlfldQZGRRvQ0A1WNAAnjOLB4WahYroT2nASDP9pRmbQ7OSSXhzYEVuec/q26ubpFvG1+eMWxBD5gBRcBqML+TNNWc47SdoqRBMSIKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> Date: Wed, 21 Sep 2022 22:34:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Content-Language: en-US To: Ard Biesheuvel , Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0295.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8772:EE_ X-MS-Office365-Filtering-Correlation-Id: 28fbc9fa-15a6-46f3-4173-08da9c10a0fb X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pWKjh2S0SuQ46oEPFuS6jrBNlsLwmt5sBwZzmKxkMGWcwGJAl6kTkiFxr0uUxxeXUl6o7i0kVj03mTsDsqFY76ysfsv4ED9tBr/HuoBXV/OE5y++CIcbbeLncoR8XmlQRfRScXn5PDh+0n4+lwU8G+Bo7lpktTx0OY7jbGWEUKTLwn8YXoD8EeaN2IaxHldtS7oyD1AnaTm5ORLND5mPLC2rZdG8mwTcieME3XjosPamIDy6/Q+wMhGs4FPq8/2rt9qNacLoSDbstdCjFi9weumHcP33JfCsdqHPngoec7yL33iU5FJQ9wu7scdm1iBZkmoo7ttoe1HoJ5lqwa0RgEF5uakMmlYnyDvjj2kj4DxKsxz/0SWT3xEYgDCkjRoAaHn2+NvFbCIQFhjmtNdduVcdxo5lh2XARTwqYo5/jDc2n/c+Q4gIZRZ/voN5MdM31zs6+LlBkxplWJOyYmES3NSNdlaAebMOhZv+Rew4BEfHAwXssjkZp+Ro5JWd6SE8MszblJ5WFmvIX8fkbNoims81Sl1lg6oXX8/lM/l9It86XKtUOchzz1CT2k48dOd/ApRWUL5fX7n06ZOXNMYhELwhef40T1NwafcZjkcfPnqJNQNAdgnTTgD+QdDXtQMu1Mz0a4PuR6X2svfyX4vKgbMFA/YlrhRWXVn28qXdd+lFWUq/a+VwJJOMEhIFLWJztegIZQviDpEZOILXOlcAAi/RKIbl8VuvxJffcCqyS0uWsgQ7v24EzRjxv72GYelFcaiS8mI3vRrlJBo0Vuzp2dFd1GDP4jxZXIp4dp3Iet0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199015)(186003)(54906003)(36756003)(110136005)(8936002)(31696002)(66556008)(86362001)(316002)(66476007)(8676002)(4326008)(66946007)(2616005)(83380400001)(5660300002)(6506007)(478600001)(6486002)(38100700002)(26005)(31686004)(41300700001)(6512007)(2906002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFFwczNZallNSDF1WmZVVTRENkdxcnNZYVIxR0dINFk0bDUxY01sZXpMN3Js?= =?utf-8?B?dlNhRk9lVkpLbmxiSFJ3Sko0THRjd1lLVlBOMjBmajBLcEE5TlN2S1EwcWZm?= =?utf-8?B?eVR4cC9nMUh5S2d4NFhreXpFMjdkSWM0UmRMK0VIVG9VVUhtRVVVYlhsRHZn?= =?utf-8?B?QnVoZ29FWkI2cXhwTDBibzlFd0NLQXI3NERaMDQ5Vyt2MERqNDlLVkJMNnN2?= =?utf-8?B?ZFFqdjFSNVNTYTJTZ2dKNVgwMnV1R09iS1E2ejM3UjNFbkkrQWUvQWdCZDZ0?= =?utf-8?B?YWh1SGN3V2RoWjhuTEFSSG54WEtCZUdpVHRRaUEvY0UwZlFsMVZkZmV4ZGZY?= =?utf-8?B?bzVDSFExWHBMSGpNMHpsOXI2NE1QQUpjRW1kRjByVUg5N2tWanJhdUtwR3ZG?= =?utf-8?B?MDVrNE0zZHp2TlZQZ0lxeHZtYVhqUExONmc4UDZWOStKbDBOV1lLall5cmR4?= =?utf-8?B?TjI4bWlkMGVXN2I2VFpPT0dVcVdIUWVRb0o4WlJzUEk2ZHZJY25Vem9uWHNU?= =?utf-8?B?TnVoR3FYRC9jYnJxM3VUb3FHcnlHZ1grVUZrNDJodEpENGdWYVZjK2lVVEpY?= =?utf-8?B?anVZdDF4RVFNYWF0TGp1S1VxMk5XT1A5a0ZKSlV5Z3drTkR0cjFUaEJhZDNs?= =?utf-8?B?NCs3cGVnMFIrS2h3YzFSNXZyMkM3TmcxZEkzR3JmVHJzNWw5cWkvdXIrTGpZ?= =?utf-8?B?MytUQ1ZGb0VSNlhleG9wb1YwcjgvYnhDcmk0SWtKWUdJK25tUWdtS2Y0TWJx?= =?utf-8?B?OGo1b0JWcWdiSDliTG80TER4RVV0Qm5RMkg3eDdSSTRETHh3Z1ZtN2doaWN3?= =?utf-8?B?VmRRSkNrSXIzUlFlVm9MSVVoZG5IMTBtYlBGdUtGbWRRQkthU3VIblZUbmFD?= =?utf-8?B?U0ZZL1BoVmNEWVNkS2M0Nmp4SFRmcDlKR2VwMlY3UVNSdEpYUGhvdmJ3ZWsw?= =?utf-8?B?N2VoSVBJc29ZV3ZDWWpjWjJTZktVVnNxbEtVOGhMSkF4SVZDaUg3MEdqMjlx?= =?utf-8?B?NE02Ynk0WkFXaUVpTkpuemN4Z2pDQWFrSkYvWWhNaWdaT0ZMVDY2eFB6UjV6?= =?utf-8?B?WSt5UXJGTUFZKzZLRVRVT3Z6M0FWRXNLdStJRlJubkZsMnlGVElKUlNyQSth?= =?utf-8?B?L0FuZjNkaHArUjVJR2tUUnJPU0hmeVdFeW8wT0h2b3QrSTJRNGZJUkh4MlBt?= =?utf-8?B?UnQvalV1NjZ6Y1FXdWpYMmtPV3NlYmlXUTV5RTh2UDZyelBmcUdIRXM4MHR4?= =?utf-8?B?U0w2OHJ6b2M3OURLQlJXa3lsd3U0MjIzWnVMaUFteXp0Z004RXFBK20rektH?= =?utf-8?B?eTRNc1hWMzF5UzF2V2JzSVkzcXoyQnV4UkViRUprdzJkUkliaW1HWlpMRFRO?= =?utf-8?B?UFVHSk1kNUt3UXUvcDlCcGpVUTFsRys1V1JYVmF2MFdjaEVkcW5TZENYYTFL?= =?utf-8?B?a2p4K3dNSURJY3dtVkx3K0xPRk4vSEVkUWlxS0RxUXlIeTFWVnNrenZtUnVm?= =?utf-8?B?MGlva1ArZGNtWXNnNDhHV0RKajZFb0JzbzFFVWQvOWxrdGMzMmk0Vkx2WHd4?= =?utf-8?B?OU5xY0RsUytYbWtMdTlEUVZkQmFnN0szU25YNE9aOFNUSHROU0ZrZkpmS25Z?= =?utf-8?B?Y2FxRTBaMDhtaEZaZ1dNeEJpUzRyMDgxZFhvYWFWb0lEK0dmN2Vqc2g1L3ZT?= =?utf-8?B?U3hlanlPQ1A4WHZRZGpRTHpQMmlVbXpDWFl0RXc1VHQ2d21raExuN1JGT1c0?= =?utf-8?B?cCttdUdZRTB5OFFpaldvSmhTK2Z6U0VnVVJOa2l5ejcyemNjNjI0Smpyc2NF?= =?utf-8?B?NmpZVWc1MTM4YUJZTU55MFZrbFBIWlR0d3VuYzZEdkFpWEdjUDB5dk5KKzZU?= =?utf-8?B?MUdtRGMyNU40dW1TR1VQWDZ3NUdKUXhNSkMxUXA0ZkhXL1piVzdvSHVLbnM5?= =?utf-8?B?RHdqLzlRUmRFQjRpNVBEMmVtWHRoMEpxMEpsekdZZTFubnNxZmtiOVZiT3Nw?= =?utf-8?B?SGROUXdPT1g0MEc2anh4OXBIVUZZa1BYZ3ZvaFl6VElDQ3hiRk9mRGhrTHBn?= =?utf-8?B?ODBsUW5lNGk3OG9CZmFsTElJaFA0UzZCMkFPWXFOYzBqelpsZHdWVUlXVXBT?= =?utf-8?Q?aohiGX6z41rnAGPW0ahtQlvnU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28fbc9fa-15a6-46f3-4173-08da9c10a0fb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 20:34:06.1827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X1tXUQsJ18lYf6rS4dBY9tBiyvhxzHnRE0uUEACRx7r14FHnSYV6L2vFin8+fQw7oJoXTe8S9gk6X62JrZPVWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8772 On 20.09.2022 18:09, Ard Biesheuvel wrote: > On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: >> >> On 20.09.2022 17:36, Ard Biesheuvel wrote: >>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour >>> wrote: >>>> >>>> fwupd requires access to the EFI System Resource Table (ESRT) to >>>> discover which firmware can be updated by the OS. Currently, Linux does >>>> not expose the ESRT when running as a Xen dom0. Therefore, it is not >>>> possible to use fwupd in a Xen dom0, which is a serious problem for e.g. >>>> Qubes OS. >>>> >>>> Before Xen 4.16, this was not fixable due to hypervisor limitations. >>>> The UEFI specification requires the ESRT to be in EfiBootServicesData >>>> memory, which Xen will use for whatever purposes it likes. Therefore, >>>> Linux cannot safely access the ESRT, as Xen may have overwritten it. >>>> >>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData >>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData >>>> memory, Xen allocates some memory of type EfiRuntimeServicesData, copies >>>> the ESRT to it, and finally replaces the ESRT pointer with a pointer to >>>> the copy. Since Xen will not clobber EfiRuntimeServicesData memory, >>>> this ensures that the ESRT can safely be accessed by the OS. It is safe >>>> to access the ESRT under Xen if, and only if, it is in memory of type >>>> EfiRuntimeServicesData. >>>> >>> >>> Thanks for the elaborate explanation. This is really helpful. >>> >>> So here, you are explaining that the only way for Xen to prevent >>> itself from potentially clobbering the ESRT is by creating a >>> completely new allocation? >> >> There are surely other ways, e.g. preserving BootServices* regions >> alongside RuntimeServices* ones. But as the maintainer of the EFI >> code in Xen I don't view this as a reasonable approach. > > Why not? Because it's against the intentions the EFI has (or at least had) for this memory type. Much more than EfiAcpiReclaimMemory this type is intended for use as ordinary RAM post-boot. >>> TBH I still don't think this is a scalable approach. There are other >>> configuration tables that may be passed in EFI boot services memory, >>> and MS especially were pushing back in the UEFI forum on adding table >>> types that were passed in anything other the EfiBootServicesData. >> >> Within Xen we might abstract the approach currently implemented in >> case more such pieces of data appear. >> >> While I can easily believe MS might be advocating for this model, >> I view it as problematic not only for Xen. How would you pass on >> this information across kexec, for example, without introducing >> further producer-consumer dependencies requiring separate protocols >> to be followed? >> > > In this case, I don't think this is unreasonable for configuration > tables, which only have a GUID and a base address. If the OS knows the > GUID, and knows how to interpret the contents, it can decide for > itself whether or not to preserve it. If it doesn't know the GUID, the > memory is just treated as available memory [after EBS()] > > I personally think reclaimable memory is more suitable for these > cases, which is why I am willing to consider that as well. Note that > the EFI spec now also mandates device trees on ARM to be passed via > EfiAcpiReclaimMemory, simply because it is the memory type suitable > for firmware tables that only the OS consumes. We do preserve EfiAcpiReclaimMemory, for the simple reason that with Xen "the OS" is ambiguous: Is that Xen or Dom0? Most of ACPI is handled by Dom0, so we can't very well discard the data before Dom0 starts. (This then also matters for what you've said in the earlier paragraph. In particular the sets of known GUIDs may be dissimilar for Xen and the Dom0 kernel. Considering your other remark about fragmentation you might agree that preserving in-place is not very desirable.) Especially with DT mandated to use EfiAcpiReclaimMemory I'm willing to consider using that type for the storing of ESRT (and whatever else may appear along these lines). Demi, you may want to check for both types in your Linux side patch ... Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 21 20:46:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 21 Sep 2022 20:46:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409900.652906 (Exim 4.92) (envelope-from ) id 1ob6c4-0005je-IY; Wed, 21 Sep 2022 20:46:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409900.652906; Wed, 21 Sep 2022 20:46:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob6c4-0005jX-FZ; Wed, 21 Sep 2022 20:46:32 +0000 Received: by outflank-mailman (input) for mailman id 409900; Wed, 21 Sep 2022 20:46:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob6c3-0005jR-DR for xen-devel@lists.xenproject.org; Wed, 21 Sep 2022 20:46:31 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 766cf24d-39ee-11ed-9647-05401a9f4f97; Wed, 21 Sep 2022 22:46:27 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Wed, 21 Sep 2022 20:46:24 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 20:46:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 766cf24d-39ee-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PsuEVRilTK7K86vxne0bcNlGXEsRex+NzDYNodySUVnjxsC8hfeWFPBbKBrlLMCizgSCO58cDCBwzgdyqj19iCxC0uvETyFVovyOBjiyItsCZY1NGpso/kq9t7fxLceHJemotdAcpR+/FyFvl6cURp0kOZkGxQ1/9y99TEEzhu/IWz2pCeTNCfOBj7cLHDvUBOUNyQM58fVliVq9WNVPMGE7LeRWbYVTeC6Fe/rjqMPBTYUDahTHF6gUuH++quBuJw202g/6utlNdi2gFoaKNsRo6YqYXbndHk320z9Zn/QMR25wfV6s/1BbqkHKvcb+Uk6zUZF0qzw9e9HqsKBpMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ynD5V0QXs3XnkGQ59qhCXXhfQJjPgt9lQ5Vxfq17bS0=; b=XqNOS1HjHgO9Kyj6KF2Ui6WyMERdhlXxeDkLK3YRq8RmdW8FqPhf+3ahotgyJ6/C7S3kaeWu4xK0Tdl6KYedTPEqfJkDonvw8Pa+doRd5+eiwSKtpPVrYCPa/e41wfSzphW4ksembwK9NuDlc/hEtYWVPMiz4RbJ+XRqzg8J6iaxuuE/X0svBC6OGQymRy5biU0sxiM7wwWiV+BFV0EXL0EL65H0KZKpL/HZLmUVzV6CgZOeruXmYiiETMSvfErm6ceopcdUt8GLWAPnW3U8Y4DaUw9ACilHd5CKr1GyzY3YCL4KslPhzokUgUQtgWCF2tnbBTAPISyixbBeHRhZDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynD5V0QXs3XnkGQ59qhCXXhfQJjPgt9lQ5Vxfq17bS0=; b=jpKhVCN4ifz3SIjZO9tWHSBWNLE4upYlwbNwoBf/WOpFctyXB4giyvEpG7HjT9RjT/LOBD038v5R5PvjCE/RixvF1dLuRSFzhYKJd7+CEMZ76ayioRGgfJ8ufloChYsktRchL5k871/yLuMK8HTDALQZG/ClALPOz9qS4YaWGn0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <9d86a231-7051-423c-457e-86286c37a6be@amd.com> Date: Wed, 21 Sep 2022 21:46:07 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Ayan Kumar Halder Subject: "Helping newcomers to step in to Xen project" To: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0449.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::29) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|LV2PR12MB5968:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d0d3120-caf7-42aa-de3b-08da9c12591a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /R4myjzpDKoqqdDIQKktnKxZURAjacFCB+qW+jBSBAC196wxG6uIqsK+Wm+ztQI/gjiErikvPv8GLHgHQJGYwCg3XVkZaBD+PktZ0TDisZD8vEKvF2r6LSvKLKZVQAj1lo+VH7qVi+uOXIqA8G9RkoewRKEqTuRtK30wvbPR9HEyCAF6eS0b9Ym/TCsGK9L6mHZy640V0rUjzP7Hpkcm+mcYUGTidtMo1WIdBMOUFkOeiOLx9Kh13OQKfHMCdTFOaSt/bhIWRMkXylx3R8aqPM+2hDsaNGxVZq4Y4gcNY9yf0iK4NyIr7lRz4fL5v1qc+9WQfhXrd3AYAH0VEr8Cz2244nwS5D12745n/4HBKS1MAFinhEAZ6HqXfXi3T5FbSUkB+3aYO5aVW0SSg+S+M9f3LS3BqaK+W2xPXFj20cUc/qIF0eUvzCrzTCiE1EeD0R8cwvGZTvUtm7RbL7shYPr7CnEOLt3pUwbjGeiOHn9OZZl6lff1gH9JV2GeamP4HyfjvIl65P4YtRElWQTWxv/o2DVjGQuvrLBjB2YnpZcQ+nbhth83Q1O9IhpwU+wPsSA9TFAXVT9nuDFIcjIXVIbAdBvOIb9TSZQBrG7QEExW/W9/NEjNdnhICmZIrCoD4bWhZ0uHN7M1RrPLXCcpnIDMwh0oB27JAuj93Sh0kwqE1UeOLqvMO6SSqyjvpRHb8ScRpApoiO6KYNuN8tPRvXemKjmDgVM/9G+tix7IIEzp3V3MXUt/kLEPb7MpqnTQdRTbsveWt6RJkKDYnrYsRgBzG6rsMQKVrCppi40PEftZQUAwjahHA5UAfW7BvBqqhohayMJOB0o3b2z6z+UkcD7Ys4pEZ1AyryybqkTsmbNnFbUV6oBgUaEbAVmBjb/mk2LtKIjeklPJoC4/5Bceiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(6512007)(41300700001)(31696002)(5660300002)(31686004)(8936002)(6916009)(2906002)(66556008)(66946007)(66476007)(8676002)(36756003)(186003)(316002)(38100700002)(83380400001)(6666004)(6506007)(26005)(478600001)(2616005)(6486002)(222603001)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UThFNXZOTFdaKys0VXlKSXl3ZmtTSDNqdWRWNEdzN3k0WDk3cFJJNVpQTFNH?= =?utf-8?B?WkRlcGhlRVFtWmsyT0hxZ3ZjdmlOL2IvMHAxYjNTZnBUUkVhcG51d2ZXdXds?= =?utf-8?B?c1dyb2ozMGRmL1hlTXV2N2JuZEdJTUJWQzJTaERvb1I2QWFFSFdMcDl0a3Jj?= =?utf-8?B?L2Z2OXBvNERkcjdVUVhleGwwcy9TZDZ5WWJORExFQ0FSSFhuZWU5aEsxMWdN?= =?utf-8?B?aVZUVXZwMkNPbEpuUURRQWdwalhoNGlFNm1VVkY5ZGUwMndUcnB0SlFUS1pa?= =?utf-8?B?bjBqNFJSZ1F6OFJXWEZyR0ozUkhBbmtpamxKUTE0QkpwQUNTWGZ2eW5Zc3RB?= =?utf-8?B?UTVCSjlSRDJHNGtKQ0RYRlpWaTZSZUxQeS9vSVB4d0N0Y1FSZDR3ZjRrWjdm?= =?utf-8?B?cWx0WmNGeTdCSnJOY1RzVFdRZE5GSHJjMlRySnZPWUNSNWN6MmRQR2Y2YXN1?= =?utf-8?B?Vmt6a3dxUVFYS09VdGthMS93TllYa0c3Mmd6MG5pUXA5SHBTeG0xVnVIeis2?= =?utf-8?B?M3Z5dXFtOFlzeDZ3bFhXV290S2ozenJjeG5rZy9oNGJVUy80TmljTnd1aU1Y?= =?utf-8?B?Tzg2WTF3cTJabllZWHc3bElQSDUra2llamFVMk01U1h5R29RS3B5amQ5Mm1k?= =?utf-8?B?di9Va1UyZGFmRW1JdXdSc1dDeDh1ZlpqSjRMczN0eU9PVFhaN0hJSjJKc00y?= =?utf-8?B?R2s0ZEhubUxzV1NHdEM5eFN0NEFxQ0JUemNzRUtUQU9VSm9LYXhkOGVlN3VM?= =?utf-8?B?TkZrWmZaaHFiZXRFSVNBQ3hWZWpZM0lMaG1zamVSeFFHR2NGWDM3RVowQ3dE?= =?utf-8?B?YWxVY2wwUUprZGZJYWZQWERwUmFPd0s4bXU3aVQrZmlQNmUzVk1iY1puQ0Qv?= =?utf-8?B?djBTYXkybzMzRXlXZEpSSlkzYlVmd1UyMFRJZmt5bXkwSDZuQUZhZnBBeTB3?= =?utf-8?B?NDZVU1JCNmFqSGZSQXVBQzh3SnZkOWhlN2htWm8wTlhqUElhdXgwbHBvNHZ2?= =?utf-8?B?aHBTZ0tIcTVHejRmWHJ2Q3hUNSszYjlsM043YWIyMEg2Zko3eVlsQmlGcG5M?= =?utf-8?B?OFhlY2RoRjJhcExGcE5tVzhkZkJoTXJRNC9nOTBUcVhydWpxaUQ0N3I1aVRw?= =?utf-8?B?QUpyU0o2NHhnQXdwUzg4TVAyTnoyYVY1eSs5VUdXbzV3T2pEUE03bHdrRGZr?= =?utf-8?B?ODY5RHEvdHFncmllODNOUEVuZk5GT1BiY0hxQmd3Y1kvVkFkNVBjREVJWWNJ?= =?utf-8?B?QU0yMU5GSWIycVJHbllFOFdnQVBibEJCR2hFMURaRUZDMTdEK2JCQ2JTZEdr?= =?utf-8?B?a2dIM2NzYUN0NTZLU2ptdjY3aGtkQXZYdEJHZEdpckRJNmNtK3Z0d1JkUTZ4?= =?utf-8?B?d3VHWVFhNFZjdDZYOGFSaDI1bFY2VXBZWmlvcWtTUnYrWmZVMzFiMnVLQ2RG?= =?utf-8?B?YXl1cEhrNEVTZENRWU9PWGZEdzlkRUc4Uy9KMERrUHZaQ2s3TDJJZWlZY0lt?= =?utf-8?B?cFJ2TjlacG43Wkl1ODNiRUc0eXlabldUbFhwWjVpTkN4YUMrOFJMN3ZpY2pl?= =?utf-8?B?N2F2OW1pQk9UcnRlOVN5V0RRdzZHZGpnRG12KzZGQ01LMmd3TlN4R2RDckFp?= =?utf-8?B?c05mRE13T0R6L0VmWXRzelVsOWJ3V3JrK3ZIK3lyMHBtcWZWMXpZYm44UklC?= =?utf-8?B?emphWWsrK00xZmFpZ0pTQS9Nd2N4WVMydFYxZ1JZOWZPRmxSRzdIQ1hTcmRw?= =?utf-8?B?clBUODlFRVBBUjN3UUcxb1VFRy9NdnBoOUc0SzFzWHpueVpScytGRnU5Rnpa?= =?utf-8?B?NXU3WDZCUWQza0ZDMXJJZDB2L1NhaUErd1M0QWFKSzhFYWVKUmtNL3hqM2R5?= =?utf-8?B?YzBWUG1qeUhFYXc0KzlNM1VhQ3BZcU5zUlFzNSt3ZDgzaEJhcnZvYWRhSzVO?= =?utf-8?B?YkFJd3dzcTJNOXF3SXY3T3dvUDBUeWxjUThha1l5MnVTZ0ZVR09PUUxMNWpx?= =?utf-8?B?dDd4dHZLNkNhRDNBNDJIeDFpcHh1L1lDS05jT2ZNeWVGODZ4Tys3TS9JOGgx?= =?utf-8?B?OUYrTDdKT0xvVTZDb280WnV3ZWRuS1hnczhGTEFuQ0pFR1Rqd01tNzc4V2RY?= =?utf-8?Q?7OoEWacwmFdGAvvFY9+PbPUQ8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d0d3120-caf7-42aa-de3b-08da9c12591a X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 20:46:24.6655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tbwlPb1btdiuncb4UH84HhFYog61Wb1STnUM3CTsxu3NumRfHh1WSBD5TBskQrG4PjEaTFTieEdJI7gD0OU3sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5968 Hi All, The meeting notes are as follows. Please feel free to correct anything. Yann - Collect ideas from people to improve things for newconmers Bertrand :- Is the wiki OK/not OK ? It is page to document things for new comers. However, it is not updated regularly. Also limited people can modify wiki. The wiki is not documented enough. Anthony - People can ask on IRC XXX - Different instructions on Wiki on how to get write access for Wiki. Yann - Is the wiki the best place to keep the information ? Bertrand - There is a doc inside git which needs to be in sync with code. The other doc is about how to set up Xen. We lack documentation for this. If you compare it to other distros. We need more people to write documentation. The current information is stale. How can have a better visibility for docs on google ? XXX - What google looks for keywords. It is done by SEO. Bertrand - In wiki, you can add flags to add subjects. One might be able to extract documentation from Xen codebase. Yann -  Should we have captcha for Wiki to avoid spamming by bots ? Bertrand - Even with captcha, Bots can generate spam information. Yann - This means we should move doc to git repository. Bertrand - Documentation on command line infiormation is there in Xen. But we lack information about Xen (how to set up) Yann - Doc should explain the evolution of code. We need documentation for users. Which version of Xen supports what features ? Ayan - Release notes should document this Yann/Bert/Anthony - There is not sufficient documentation available. XXX - Wiki should also be used for collaboration for on going development. XXX - Otherwise, we need to go through the mailing list. Bertrand - We need to organise wiki in a better way. Yann - The wiki for documentation needs to have correct info. So it should go through a review. XXX - Where can I find information related to virtio (a specific feature) ? Bertrand - Issue tracker (Gitlab epics) can provide the answer. Edwin - How does a new user create issue vs protect gitlab epics from spamming . This is account restricted. XXX - There  are multiple repositories. (Gitlab. GitHub, etc). How do we know where the main repo lies ? Bertrand - There are multiple downstream forks of Xen. Google may throw up any any Edwin - There should be information in code where canonical repo is. XXX - Move wiki to GitHub or gitlab. Yann - Gitlab protects against spams. So moving wiki to Github makes sense. Once a page is imported in GitHub, then the other wiki pages can be redirected. XXX - Wiki cannot be modified by non member of project. Bertrand - I doubt there are lot of people who want to contribute to wiki. XXX - Can we somehow track the good ideas discussed here ? There should be a difference between technical doc (on GitHub) or non technical doc for users (on Wiki). This can be discussed on community call. Bertrand - We need links in wiki to point to autogenerated documentation. Olivier - We could get historical information from the proposed new wiki. I could bootstrap and get more technical person to write specific stuff. Bertrand - If you find an incorrect info on wiki, send it on xen-devel mailing list. We did write on some wiki pages that the information is out of date. Olivier - Ask contractors from linux foundation to do redirection from old wiki pages. Anthony - The wiki page is not managed by linux foundation. Bertrand - Do not expect mantainers to do the porting of pages. They can help. And we need consensus. XXX - There is a wiki linux Foundation org. Bertrand - Moving pages to git repo, the issue is that formatting is a nightmare. Also, how do we sanity check the documentation Olivier - Need how to guides (eg Xen on RPI). Create pages explaining Xen project (history, architecture). How to install ? How to use (eg distros) ? Keep it separate from technical documentation. George might help us with people. Start with a small article and then populate it with more how to pages ? We should centralise the information somewhere. Bertrand - We should avoid duplicating contents from Xen project into new wiki. Olivier - Need to track this item about improving the document, just like any other technical item. XXX - Create an issue to document things. Also need to push for motivation. Olivier - For technical doc, where do we start ? XXX - We could not get the information about memory allocation flags.  We need to add documentation to APIs. Bertrand - The documentation should be in code. There was no consensus on that. XXX - Also the documentation has different formats. Bertrand - For some part of code, we make sure someone modifying the code is also updating the corresponding doc. It is not true for all the code. XXX - It is not clear whether to write a design doc or not. Bertrand - Sending a design doc to the mailing list is very useful. So we do not go into wrong direction. We should not commit design doc in code. Always send design doc to mailing list. Kind regards, Ayan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 00:18:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 00:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409911.652917 (Exim 4.92) (envelope-from ) id 1ob9uy-0002Yy-43; Thu, 22 Sep 2022 00:18:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409911.652917; Thu, 22 Sep 2022 00:18:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob9uy-0002Yr-19; Thu, 22 Sep 2022 00:18:16 +0000 Received: by outflank-mailman (input) for mailman id 409911; Thu, 22 Sep 2022 00:18:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob9uv-0002Yh-T3; Thu, 22 Sep 2022 00:18:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob9uv-0002GP-Qk; Thu, 22 Sep 2022 00:18:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob9uv-0007hg-7K; Thu, 22 Sep 2022 00:18:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ob9uv-0003Uk-6b; Thu, 22 Sep 2022 00:18:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pq4L34l2NTsRpvZANnUIPd+F12uplL2Pw49gt3D4im4=; b=dkRMcLH8LEyKuqi55W7z9bEnUM cE6tEDx3mUSobXq/KN84J2kKsFwxH7ZBc7ix6wJqKVHQNFBmwlJaor6bPAV/nv5vXpGWZF+chMFCN h9kCPPx1OHwqYIxzq1Hzrk6NOwbOCDLuQ0N0H2FvKXpddGDiBnwwmvVWIUUV86qHWBPk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173268: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=26c95642d419028db590ae0c511d9ddcdbc51746 X-Osstest-Versions-That: linux=60891ec99e141b74544d11e897a245ef06263052 From: osstest service owner Date: Thu, 22 Sep 2022 00:18:13 +0000 flight 173268 linux-linus real [real] flight 173270 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173268/ http://logs.test-lab.xenproject.org/osstest/logs/173270/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 173270-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173261 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173261 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173261 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173261 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173261 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173261 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173261 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173261 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 26c95642d419028db590ae0c511d9ddcdbc51746 baseline version: linux 60891ec99e141b74544d11e897a245ef06263052 Last test of basis 173261 2022-09-20 17:42:39 Z 1 days Testing same since 173268 2022-09-21 16:41:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Callum Osmotherly Daniel Houldsworth Harini Katakam huangwenhui Jaroslav Kysela Joerg Roedel Kai Vehmanen Keguang Zhang Liang He Linus Torvalds Lu Baolu Luke D. Jones Mohan Kumar Namjae Jeon Peter Ujfalusi Radhey Shyam Pandey Randy Dunlap Serge Semin Shravya Kumbham Sungjong Seo Swati Agarwal Takashi Iwai Thomas Bogendoerfer Ville Syrjälä Vinod Koul Yi Liu Yuezhang Mo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 60891ec99e14..26c95642d419 26c95642d419028db590ae0c511d9ddcdbc51746 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Sep 22 00:46:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 00:46:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409922.652928 (Exim 4.92) (envelope-from ) id 1obALj-0006Ao-EA; Thu, 22 Sep 2022 00:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409922.652928; Thu, 22 Sep 2022 00:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obALj-0006Ah-8X; Thu, 22 Sep 2022 00:45:55 +0000 Received: by outflank-mailman (input) for mailman id 409922; Thu, 22 Sep 2022 00:45:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obALi-0006AU-3g; Thu, 22 Sep 2022 00:45:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obALi-0002l7-1H; Thu, 22 Sep 2022 00:45:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obALh-0008MK-F0; Thu, 22 Sep 2022 00:45:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obALh-0002Fc-Ea; Thu, 22 Sep 2022 00:45:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JjF62x7BZQ/rU3Wh8bg4MMwaMwG4oyNUYiOFvxnYDgw=; b=f6I0cOi3NSNrsgcnlAUxN7bDC5 EP8llqECVMdVTWzxwwiciln77gnZlZKYtarpVvUsH4gJsIsZYt6C5hL/QlJjjrbaVPuAYF/UItStu PH7690ZmguURumAGwlyAuHtqJl2VqSWzAZtimf/+elV7mhYyAalo5NggS9qmT0otQrpU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173269: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2906f933dd1de6d94c54881cc16ea7390a6ba300 X-Osstest-Versions-That: qemuu=832e9e33bc51f52fc3ea667d48912e95af3e28f3 From: osstest service owner Date: Thu, 22 Sep 2022 00:45:53 +0000 flight 173269 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173269/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173262 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173262 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173262 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173262 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173262 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173262 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 173262 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173262 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173262 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 2906f933dd1de6d94c54881cc16ea7390a6ba300 baseline version: qemuu 832e9e33bc51f52fc3ea667d48912e95af3e28f3 Last test of basis 173262 2022-09-20 20:37:17 Z 1 days Testing same since 173269 2022-09-21 17:37:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bin Meng Bin Meng Brad Smith Claudio Fontana Juan Quintela Marc-André Lureau Mauro Matteo Cascella Paolo Bonzini Patrick Venture Ricky Zhou Stefan Hajnoczi Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 832e9e33bc..2906f933dd 2906f933dd1de6d94c54881cc16ea7390a6ba300 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Sep 22 01:09:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 01:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409931.652939 (Exim 4.92) (envelope-from ) id 1obAic-00074U-AC; Thu, 22 Sep 2022 01:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409931.652939; Thu, 22 Sep 2022 01:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obAic-00074N-5x; Thu, 22 Sep 2022 01:09:34 +0000 Received: by outflank-mailman (input) for mailman id 409931; Thu, 22 Sep 2022 01:09:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obAia-00074H-Vz for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 01:09:33 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 347e06de-3a13-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 03:09:30 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 51BAE5C00AD; Wed, 21 Sep 2022 21:09:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 21 Sep 2022 21:09:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Sep 2022 21:09:26 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 347e06de-3a13-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663808967; x= 1663895367; bh=htQy3Ooh2pcw6WQAzMWu1eJmwAJOudfKc06grWuOtqo=; b=J ppbHTkcAFfStvVNejhrKmL8Vjr+wtGhXXvgEhHIs8h9U3iLq8cx5s9mWdr6TfLQO 72OvoxnG7Lge1fbuasPFvIENf2zq2PfhF4/iNw2ckSTY9EExanmQymr/ch8KZRq9 TYJ0eXWbnPE6kD6aNJbNkxZfhOO8s2lObaHAmiGLmQOlYAtr6/fEwlgDNi7ONJA4 UGs7YPJK+kq5Pfpgb7wOooDeUOeiwNlS+VX84fxdb4q2aLhI3euEFrotcwhyjY5X XcMG4ABQFqiSepX79FlEg75lc5KMo7XsvoaVLAqzwA+3UPqAbMj6Tx+f/HsHNQ5t 6/MoM4wnh89Nxor6YHXVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663808967; x=1663895367; bh=htQy3Ooh2pcw6WQAzMWu1eJmwAJO udfKc06grWuOtqo=; b=fi2ORdOBN0I0CWaBP5fkIsaUCTcc8JskD/lUqsRzAxIe S3jXMZyJNYUiUaPM/K1aDNTKGY+YrgLIopl8gI2LaxIq8zwJCssFNEc7BhrE7TEt bnhpd3Dr3SmZz47P6cML9w6JAekP6t5ejVHFGyXToDzF0JfR2Tqlfr590MP1vNL1 gG1srjL58zA2VpbVbWKkqS353Mgk4i6NkcYmcbx8qaKIFIaVSVDnzs1tXRTFsg/s 04su869qXdoiobHdKV+mXbbwR80uAH5afElVhwliNJtwONEpUha95e1Bmf8obN6z lN9BUQdHTcE0h0LA9fbprTV4wCqMBeNy8ymsDCL7wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefvddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 21 Sep 2022 21:09:21 -0400 From: Demi Marie Obenour To: Jan Beulich , Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Message-ID: References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h6mSater0Rbyeym3" Content-Disposition: inline In-Reply-To: <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> --h6mSater0Rbyeym3 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 21 Sep 2022 21:09:21 -0400 From: Demi Marie Obenour To: Jan Beulich , Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3] Support ESRT in Xen dom0 On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > On 20.09.2022 18:09, Ard Biesheuvel wrote: > > On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: > >> > >> On 20.09.2022 17:36, Ard Biesheuvel wrote: > >>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > >>> wrote: > >>>> > >>>> fwupd requires access to the EFI System Resource Table (ESRT) to > >>>> discover which firmware can be updated by the OS. Currently, Linux = does > >>>> not expose the ESRT when running as a Xen dom0. Therefore, it is not > >>>> possible to use fwupd in a Xen dom0, which is a serious problem for = e.g. > >>>> Qubes OS. > >>>> > >>>> Before Xen 4.16, this was not fixable due to hypervisor limitations. > >>>> The UEFI specification requires the ESRT to be in EfiBootServicesData > >>>> memory, which Xen will use for whatever purposes it likes. Therefor= e, > >>>> Linux cannot safely access the ESRT, as Xen may have overwritten it. > >>>> > >>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServices= Data > >>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServices= Data > >>>> memory, Xen allocates some memory of type EfiRuntimeServicesData, co= pies > >>>> the ESRT to it, and finally replaces the ESRT pointer with a pointer= to > >>>> the copy. Since Xen will not clobber EfiRuntimeServicesData memory, > >>>> this ensures that the ESRT can safely be accessed by the OS. It is = safe > >>>> to access the ESRT under Xen if, and only if, it is in memory of type > >>>> EfiRuntimeServicesData. > >>>> > >>> > >>> Thanks for the elaborate explanation. This is really helpful. > >>> > >>> So here, you are explaining that the only way for Xen to prevent > >>> itself from potentially clobbering the ESRT is by creating a > >>> completely new allocation? > >> > >> There are surely other ways, e.g. preserving BootServices* regions > >> alongside RuntimeServices* ones. But as the maintainer of the EFI > >> code in Xen I don't view this as a reasonable approach. > >=20 > > Why not? >=20 > Because it's against the intentions the EFI has (or at least had) > for this memory type. Much more than EfiAcpiReclaimMemory this > type is intended for use as ordinary RAM post-boot. What about giving that memory to dom0? dom0=E2=80=99s balloon driver will = give anything dom0 doesn=E2=80=99t wind up using back to Xen. > >>> TBH I still don't think this is a scalable approach. There are other > >>> configuration tables that may be passed in EFI boot services memory, > >>> and MS especially were pushing back in the UEFI forum on adding table > >>> types that were passed in anything other the EfiBootServicesData. > >> > >> Within Xen we might abstract the approach currently implemented in > >> case more such pieces of data appear. > >> > >> While I can easily believe MS might be advocating for this model, > >> I view it as problematic not only for Xen. How would you pass on > >> this information across kexec, for example, without introducing > >> further producer-consumer dependencies requiring separate protocols > >> to be followed? > >> > >=20 > > In this case, I don't think this is unreasonable for configuration > > tables, which only have a GUID and a base address. If the OS knows the > > GUID, and knows how to interpret the contents, it can decide for > > itself whether or not to preserve it. If it doesn't know the GUID, the > > memory is just treated as available memory [after EBS()] > >=20 > > I personally think reclaimable memory is more suitable for these > > cases, which is why I am willing to consider that as well. Note that > > the EFI spec now also mandates device trees on ARM to be passed via > > EfiAcpiReclaimMemory, simply because it is the memory type suitable > > for firmware tables that only the OS consumes. >=20 > We do preserve EfiAcpiReclaimMemory, for the simple reason that with > Xen "the OS" is ambiguous: Is that Xen or Dom0? Most of ACPI is > handled by Dom0, so we can't very well discard the data before Dom0 > starts. (This then also matters for what you've said in the earlier > paragraph. In particular the sets of known GUIDs may be dissimilar > for Xen and the Dom0 kernel. Considering your other remark about > fragmentation you might agree that preserving in-place is not very > desirable.) >=20 > Especially with DT mandated to use EfiAcpiReclaimMemory I'm willing > to consider using that type for the storing of ESRT (and whatever > else may appear along these lines). Demi, you may want to check for > both types in your Linux side patch ... EfiAcpiReclaimMemory does seem like a better choice. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --h6mSater0Rbyeym3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMrtcMACgkQsoi1X/+c IsF4ShAAoQ8npwnu+o4G9Co3qQBtUWUNxsL4Q0H1H63aMfkgzDXCdlhT5VMrfvBE Sjao2soGkDlHVDwDIjefkpjUz96lrnwPODeVAKZQYNRodi4R3XYUemgJKlclWQ93 sHxvtqvwEPISD586PUeoQZwHl0qtZOd8A/IT+JzGRwoNkhL+2xoNzEvyFflNlSGy hzyTirzRW1v5CDbqG7uy6V6vmFMe8jbbLzm6WlST0IWZijg+hinjuKCzN5G12HAn PmSTodvi/pPoYLO8dEZz8/UnFgNy2LnProNaLhaeY4ZBpNOOcdCSTW2Ai6CayRTs hNwMrXbuv+JDBXsqlp60payK0QCRTgsIho/HRENHybsJtKHK1jPBjBJAkzGTPazn J2czQOf6uyDXzF4nZmB52Tn7YN+FIPa7UPHcjw9EWJYX/gL++Kc53Hd7uIfunogD ZCeoXDj8XtZKoGeywKSnqYy3wjCxdCpyaEogKrjFfGNaaDs/NXyoXasF2odiAy5j VoSN2p1TTPQNCup8ubzEYKxS36rtJ+FR2R4pxRHydcWXhNnIMairy2acnlSamGv5 EaV4efRS3lAYi7PphAuNA3yGtaDL6hXl11sIEdE8re80Y1aG1NHUjTzJus8bWojk lBNNTSXBAosaTrOMvNowF9yYvQMkIjPMEfDeN1s9toalzvpQa38= =DzpQ -----END PGP SIGNATURE----- --h6mSater0Rbyeym3-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 01:54:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 01:54:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409940.652950 (Exim 4.92) (envelope-from ) id 1obBQ3-00047Z-Mf; Thu, 22 Sep 2022 01:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409940.652950; Thu, 22 Sep 2022 01:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obBQ3-00047S-Ji; Thu, 22 Sep 2022 01:54:27 +0000 Received: by outflank-mailman (input) for mailman id 409940; Thu, 22 Sep 2022 01:54:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obBQ2-00047M-PU for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 01:54:26 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b5f4012-3a19-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 03:54:25 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4808B5C00BB; Wed, 21 Sep 2022 21:54:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 21 Sep 2022 21:54:23 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Sep 2022 21:54:22 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b5f4012-3a19-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663811663; x= 1663898063; bh=m6GkpIVXRWxbqQje5T7MQLuORENRyeMk/BRQajKA+yU=; b=e +t8Ws5tYc7yEGRZyMWpUL1hxuYiS+x7F2acMwVX7AYyRVaR5EAMP34EO3VVOu5er kL6QdRjcmIJNOHq8wZXN0zL1l1Zjjl+BTXWgGPE+E5SexMjV3mr93Wp1Tuv0PYf+ XiUF6FL2xy/sRkM2tFto50/TwymoaTtMZ8fQ+pvZnJyfmpPKIaCOR/I7ccYC4Juy QdUybFmGAuC5O2vfK3nmNX7cvcFo6fldDb9lRQWiWVzNpdksC2pqBtsqK0B4+Ny5 zcmLBekrkIBa0b+CUVsimo2bYMoFQcPYRXWuUlaNo1wLdnK7/SsNR+ccGujWCMB9 czHAFLSs7gI9PaOlj/ctQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663811663; x=1663898063; bh=m6GkpIVXRWxbqQje5T7MQLuORENR yeMk/BRQajKA+yU=; b=XiCOhhnuDN7uxs3IlRF6TuEIqmkNUn9nwv4aYq0tdo+w KErcVnxBh4KErOpVOCQWLChFskCLeBhcikbebcr25Lw5AHtg2z0Plx6Z55qACXHr sXGJq21WX57ZdGI94zr+m+XIc7iAr605FURKpfcs5KVNMEpI7YC2UzbxFJX7pO2D 6Gh8xnl5FCQiZyxfX7k1nhOXVa1/mVoUwTlcpyaN/GOu5m8Bnc3OZuualxlS1ORA lVVbS7VOxS1zh1h/0FvEwf8J38Nj4t4YfPs3t3P7dnCtbUDXD7EbrrUufWk7ILOI BoPksSmexvl+HaW/YsQB5Hgg+SNPa8z+MFyfG6Ji8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefvddgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 21 Sep 2022 21:53:47 -0400 From: Demi Marie Obenour To: Ard Biesheuvel , Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Message-ID: References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="05nNIFABQReCPqy0" Content-Disposition: inline In-Reply-To: --05nNIFABQReCPqy0 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 21 Sep 2022 21:53:47 -0400 From: Demi Marie Obenour To: Ard Biesheuvel , Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] Support ESRT in Xen dom0 On Tue, Sep 20, 2022 at 06:09:49PM +0200, Ard Biesheuvel wrote: > On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: > > > > On 20.09.2022 17:36, Ard Biesheuvel wrote: > > > On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > > wrote: > > >> > > >> fwupd requires access to the EFI System Resource Table (ESRT) to > > >> discover which firmware can be updated by the OS. Currently, Linux = does > > >> not expose the ESRT when running as a Xen dom0. Therefore, it is not > > >> possible to use fwupd in a Xen dom0, which is a serious problem for = e.g. > > >> Qubes OS. > > >> > > >> Before Xen 4.16, this was not fixable due to hypervisor limitations. > > >> The UEFI specification requires the ESRT to be in EfiBootServicesData > > >> memory, which Xen will use for whatever purposes it likes. Therefor= e, > > >> Linux cannot safely access the ESRT, as Xen may have overwritten it. > > >> > > >> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServices= Data > > >> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServices= Data > > >> memory, Xen allocates some memory of type EfiRuntimeServicesData, co= pies > > >> the ESRT to it, and finally replaces the ESRT pointer with a pointer= to > > >> the copy. Since Xen will not clobber EfiRuntimeServicesData memory, > > >> this ensures that the ESRT can safely be accessed by the OS. It is = safe > > >> to access the ESRT under Xen if, and only if, it is in memory of type > > >> EfiRuntimeServicesData. > > >> > > > TBH I still don't think this is a scalable approach. There are other > > > configuration tables that may be passed in EFI boot services memory, > > > and MS especially were pushing back in the UEFI forum on adding table > > > types that were passed in anything other the EfiBootServicesData. > > > > Within Xen we might abstract the approach currently implemented in > > case more such pieces of data appear. > > > > While I can easily believe MS might be advocating for this model, > > I view it as problematic not only for Xen. How would you pass on > > this information across kexec, for example, without introducing > > further producer-consumer dependencies requiring separate protocols > > to be followed? > > >=20 > In this case, I don't think this is unreasonable for configuration > tables, which only have a GUID and a base address. If the OS knows the > GUID, and knows how to interpret the contents, it can decide for > itself whether or not to preserve it. If it doesn't know the GUID, the > memory is just treated as available memory [after EBS()] Should an OS uninstall any configuration tables that it does not preserve if it ever plans to kexec()? Does Linux do this? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --05nNIFABQReCPqy0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMrwEsACgkQsoi1X/+c IsETXhAAjr/+MWrA8eEVIEoYZ4PVctW84sTRXfBslltf7TZULl9zyWi/RSuYwj5K a+a4Os05PC9xpu/GvyWO/6QTr1PwCIFIBkvi2eyfjem3KDbDdDA+qrLsoya/LD6C 1rnDabmZzzPcQsh19Mzc6ngipdbX7bLYjJkxwFpJ4KFKZi1ug4x2URa5VASYFuIv i0I6imccxH5+92DXTaQBmSg2wHxG6zBkNYlEmbY16SgYV5mfWLpqw/85d2TMOOkt uCohyxjC6uj7wyJ+QZ4fofo+yEl0Al4evWCve0Om5CknYJt+43Q2P89XJzmkxnJ8 T8x+BraQZ287kph/PCCzS/kLAt2dqjgS8XjZeP4g9AYF9H85FMa0g0lNFzhtkiEp OvYedpSzFMR/XREw1yV9YBqMakfoI7VE2Kv3yqDXVfByFyDUMfBmGWyrGbr/ZtjE 9lhCgStB+qWnhYJluP6VyI7/gF/Q3MBuz9emMk+dDryMKTmMyo3ae2ADKgol4ASw iF6pZD6y4JRYxIgpo5RT8mnkcEzGIoOAK5tPLb0XXzsJXUScskxE5Aoizvlf7HDQ GukOXADUe0g+KyVhCDidy6bZK5a1FFyMLiJhe8hcU/PgRJDQ6R7/WDl5DmNX1eyv acqYpMno6laktT9yopfjGGdZ9YanM3oN8DskXXD2L/u9ClNIQv4= =l07Z -----END PGP SIGNATURE----- --05nNIFABQReCPqy0-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 06:12:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 06:12:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409959.652961 (Exim 4.92) (envelope-from ) id 1obFRf-0006hO-8M; Thu, 22 Sep 2022 06:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409959.652961; Thu, 22 Sep 2022 06:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obFRf-0006hH-5C; Thu, 22 Sep 2022 06:12:23 +0000 Received: by outflank-mailman (input) for mailman id 409959; Thu, 22 Sep 2022 06:12:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obFRd-0006hB-Ax for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 06:12:21 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2087.outbound.protection.outlook.com [40.107.105.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 82ea24c0-3a3d-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 08:12:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9211.eurprd04.prod.outlook.com (2603:10a6:10:2fa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Thu, 22 Sep 2022 06:12:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 06:12:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82ea24c0-3a3d-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QH4R5pE22SQBtZ+8Sd0Isy9wFtcvniXleZCUbOnyJwBtEuSRFyoqrCf57Fux1+nwvosUXsOoZUnKIl4/7rawrItBT42pyGYO7BuAJ9FvCuewmcNM+BRxlbFd9XYNp09dPjAWZ83ccykNDFrbkyDIr4wmQElhz0M6bUcdu+EI7s8SLkX4G8HGt8j5sSS0gya/u5M7hJaolFjlGCmpHpd17MYq0EkszIS/+qlb+eZDSLV3xcLeoiViRlQVKL7CcxXt2yBj6LNlMYZmTX+Ehg+nq9C8SDQOUiPZtwmQ2vZPokJrwdrT4zfAhbh/Erz36opoBDi+E2ve0SBsrMXVJR8H4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/WOUVXNLFDX+WoE27T33pXzOWdL2eC2PH3pSXbEjyGc=; b=eFx1bV+DFc63eP/OIuThfA6YuYQWYHe7QrOGJLuDI7pqGrGBYHMnynQf6FE49IH7IG4twob1j5nSPPp0EyNYrBeFLDqbGGcskuWOos+n+lKX2wIdLMOrM9o9Hgip1NUNue7TR0nXMpc6y3GXHmka7YafnX4b85abSKSMoVZA6z3xRC+PyOPfu62Ie5oYZir8rOetb2LQXNlqLqFPEFEb8oxPxfjtUCWgnFM+DnJWOYMfg0PLJWvbyRHndtIF+deq5VMTjbAUgU+3j1A2nLEiexRz9XRylK/7bx20Ae3Q6CmP5izvz+HYjTjrWp2KpUyl+E8/ery1VUxgZpUXgQyoUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/WOUVXNLFDX+WoE27T33pXzOWdL2eC2PH3pSXbEjyGc=; b=5W3IfmBRT94noBjldJd+UXIt5hnEX3ZSnwU+UUoOiou2BxEZSlnup2jkyfSsLu60F8+FLaNYbI7nSIMIITPFJRcJ9ssMhJsuyjCPm+/lu563D5dq3owJVus/AbpCIKRt9zHK/pUq8vzI4Dro0watBwNzDAp44LGxiyRohKct/DIASHHOjgjZJ6eqhYSszaS9Lcy6eOYC6ci/O4/PXKEVAvFC7vnEnKkNw1mwcJiQiDmHg4cXMGZiElrqu9ONTgU8PUUkSQz9VM+dE/y5yhmb9TsT7+Hof6TTesVjuLZY8K3N4kR4n3Hw/uCUyBo/vfmUGsRTibSlQPBIGTQqMwzRRg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> Date: Thu, 22 Sep 2022 08:12:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Content-Language: en-US To: Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Ard Biesheuvel References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0059.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9211:EE_ X-MS-Office365-Filtering-Correlation-Id: 179652b7-3cef-462c-d480-08da9c616608 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: In0VVcVyhDGBjrQpfjJAQyLSU4kshi+Zvu0SMXAwGudG2etDyNT4Eyw/3fW2UeyIt+/1Nz/hzwaCmsCmqQkkfXnl5K99rC0QAS2jmu7t3CpgMw8QLNUQQWq3gtbZLNXqDZ+FxwlWGmOllMZ4lvjXrvYNKXE2OlSg26r6xBwQN6OQ5YlrxyhxZlLLkTMBk/dIerpbrKooSDjun0/Xg57cfie6tQVGOfxiqSE9OPPeml+5w13Eqx2OesRaEOiDS/PXrDLOGTjhvHofdpnIzGUdKWl2Z1j62qCsd0R38j65Nk00EgTdeeqDOTEGIIMYZCo7ddjJdQo9mZ9wAKkHgQ74XHwACawdD4fBaea+yzhQyaQwO/5I2aR8+gbc0TDtTE+DGw4DUnUPQjRBkuR2/E/PK70n6CywzDoSY0+cAd7WpYTdo6WufHu9eTkzJ7wLFfUEEegvko6qS+qnKYY8wLBR48NZmXLD22VUicU1XfCK+KES0WyYyIaokWz0Y8vfyujiZVKK46I37FZRwBdvVmRDKh9Oa0mZlt3JOlvXKOU/g4yCw4FVNhjSco9txALjeUhlg637One9OpIdPCGHsar7OfLNOb9zZaMWa+7GudFxpKUe0ldR4mjiWW7wdra+I5ZIcvQ2iNPRmPmoEv1RcYC3X13J1HNpDO6dFasExU6/jMJ36r17aAYjKIsNd7KP5Kh8JfprvFqCsPCz8kS5NWV99TEVGReXTbHDQ9a2OPXJc0LNIuR+IBDKk0LM/6PYAvHkKOlBOeSOdTAStQjvnKaoRJJNQIM5RV8Y+mpMXPeSZIU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199015)(26005)(6512007)(53546011)(316002)(6916009)(54906003)(6486002)(478600001)(186003)(2616005)(83380400001)(31696002)(86362001)(38100700002)(6506007)(31686004)(5660300002)(2906002)(4326008)(66556008)(66946007)(41300700001)(66476007)(8936002)(8676002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTA3N2FYWEZ5dGJ2T01UMWEwd0EvU1VNbk5mQmlRNTRIRlpLMHdudEhWVmlx?= =?utf-8?B?TUVWVkpEbG9EOEhzSFJOdnQraUdPd3MwZkpWMVYva2ttS0E1QklVUmxld3R4?= =?utf-8?B?TENwcmdNdnR6Y3ZvSkVsRzlnY3ZFWXZPc01nTVlwVDA0d2I1eFN5VE0xSWV5?= =?utf-8?B?ZDVEWjROdGF6Qm91dlRiZS9yMjM5eVVmNGluWlVzYUxXOGRXQXZVQTBsa2hS?= =?utf-8?B?Ui81anlzdFUxc3pzYVZpZDJxbnB2VndNeWFJYTJSdmw0NXdQM3dwZ3hlOVFi?= =?utf-8?B?M1VOb0JSSmxJSklTWnNCSHIyZnEvWnNUby9pVjYrMXJHb2ZJQkw2MlVxWDdr?= =?utf-8?B?blNzZzlWeHc1L05tOTNqVXJ3aVBPN2dBMDJ5N3BiQUhIeGRXcExadzl6dU9C?= =?utf-8?B?aFIvTlpFcUJZOFlwdlk4ZGdIRzJMbDZBSXN2Rm1mWS9hUXk2dkZaeGhRVXRX?= =?utf-8?B?emhsalIyQUhhRk5POWNBU0N3QVpLRHArWjMxZDFkZHFPRFZXOEN5b2lmeWtp?= =?utf-8?B?alJWZDFqdHN6dEJVQktzZ0JUa3VZbXBnWTJqMUcrRVpJanFYMUM5V3lMaVlD?= =?utf-8?B?UjJXdWxLN2IwcVBGWUIzZll0VGoyUVlUOHZ1alEzTTZpOEdKRGIxVi90STZm?= =?utf-8?B?VXVSZXBUOE4yOHc3WlNiU1lEdWxUWnRnS0FyU0l5dmdHa2xSS05LTmRlYnVz?= =?utf-8?B?U2JaVkEzOXc1UW9leFRmSXN0L0pUd0trQU9TUkFKeHlFWk9sVEJYSFBndXFj?= =?utf-8?B?WkhJa2FLR0ZEczA4TnJuWEVvRk93QjhXWGVySzhrQVovRUttSThRcVB4ZVkr?= =?utf-8?B?dEpCN3hldWUyclF6TzRpVTY0RU5lV3pUbkNpb01jNmoyaFhBbHpHZDRodE51?= =?utf-8?B?VXlDekRSVjQzQnJjM3g4SGwwZ0s2NGZqa2c0cXBlRzN4OWFGbTFRRjdyY3Ru?= =?utf-8?B?bDcvdHJUajNxd2wxclplMmRKaDF3SmZHT1M2eVJvakEyT1UvbWpmNmxXdGRr?= =?utf-8?B?U1IrQUxYRm5YUHZZelZDb1B0ZE9aanpBeDE0YmFyUFFIQVc5UDZzVkR5eHpi?= =?utf-8?B?dmdJK2tzNG0vY1ZtUDZzcjB3c3JpRTY5VUFNT0IxdytKbVJ2Q2x0RkZWclVJ?= =?utf-8?B?c0J2Z0ZPcDR6R0U2NXAyb2lMVHdEWkEvZXNXTG96L1RhR2FaQXdlSVFyUGln?= =?utf-8?B?SDBHZTVmUklJcjVjTHpwcVFFNncwL1lpdmRqK3hNWGs0ZGV4NlpJbGhQMGY0?= =?utf-8?B?K1VVV29YVG1sMVZqU2Z0SUJtZzU3aWJtMkJrN1puczY1QkZPMlZScThXSmht?= =?utf-8?B?UTlGdkFnU3FrUFBWdGFFZFZ3c1FvK0RDMFBJOXJqWHJnOWZyZGhrZE5QV21r?= =?utf-8?B?YmkzQm14UXJZTmI3VW9uQUh3bjVnT1B2clNFZHg1VjM0MVUxZXRkKzFmTnFi?= =?utf-8?B?dlNaUUxJRlZnU0VZM2VSTnN3MWpNVmUwdlVrZGw2SDdrYUhxVm5LSDZ4aUxN?= =?utf-8?B?UkoyeWRuSmFUZG1lRFN6ZWFWU0NTMmJKYWdQQ0NuV0F5YTNETGlpVGJJTmJZ?= =?utf-8?B?Rm11c2R6cENIWkVuUS9ZRVhldEpoT1lUbENVV3dSaWhtZVVJVmtQaUNIY3F2?= =?utf-8?B?QTFXZGFBNG9oUzRaMi9iUXFnZ0c2elkrMmNRdXMzSGV1SU1HOXlBUWFFVVVW?= =?utf-8?B?RmNxU3hBOHduaHBqMmhWM0g4YTZjc0QyZDRYczlHRDd5SE1WK1lrN0RrVkZE?= =?utf-8?B?YzhtUEJhRjNLWUZqeW9EcFh1VHhBYldlcWpHOEFsRnJFa2Y2VEZwSGFNeU83?= =?utf-8?B?ZXJWTlRtT1BPS3VLdjBYb0NmbUhmcE5vbG5WZE9EMnlBRmF1NTFCY2h2UU13?= =?utf-8?B?VitsUW5YcVlxK1BUSnlQaEE1a2xmZFFQZ0VXZ3VydHpSY3dJbFhjbUliWEtU?= =?utf-8?B?Tm0wK3FCZVpxS01wR0RjRitNaVBzVENxU0JOWWtGVmhyQXlMWU16R2FHbG9Z?= =?utf-8?B?RWZERHludU5UekhLMU9DRkZLeXR6QkhNUW9YbDJjbTEraTZJdnpYVCtYVXJu?= =?utf-8?B?Y1J4Lzd3ZElsczkzMHUrak4xTG9zMHVZUUI3VUhrVmt4UUh0NUx3S0R0L2No?= =?utf-8?Q?2ydeilN12m/CpRDHJtw9pLWfd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 179652b7-3cef-462c-d480-08da9c616608 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 06:12:16.5211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R257653LUGO8Lm7f9D0BhbDoQviJci2HabRsUUNyXdBbgr3xl5N345XHiHEkCiusWvA4SZNw0H+SoREszMmeoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9211 On 22.09.2022 03:09, Demi Marie Obenour wrote: > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: >> On 20.09.2022 18:09, Ard Biesheuvel wrote: >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: >>>> >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour >>>>> wrote: >>>>>> >>>>>> fwupd requires access to the EFI System Resource Table (ESRT) to >>>>>> discover which firmware can be updated by the OS. Currently, Linux does >>>>>> not expose the ESRT when running as a Xen dom0. Therefore, it is not >>>>>> possible to use fwupd in a Xen dom0, which is a serious problem for e.g. >>>>>> Qubes OS. >>>>>> >>>>>> Before Xen 4.16, this was not fixable due to hypervisor limitations. >>>>>> The UEFI specification requires the ESRT to be in EfiBootServicesData >>>>>> memory, which Xen will use for whatever purposes it likes. Therefore, >>>>>> Linux cannot safely access the ESRT, as Xen may have overwritten it. >>>>>> >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData >>>>>> memory, Xen allocates some memory of type EfiRuntimeServicesData, copies >>>>>> the ESRT to it, and finally replaces the ESRT pointer with a pointer to >>>>>> the copy. Since Xen will not clobber EfiRuntimeServicesData memory, >>>>>> this ensures that the ESRT can safely be accessed by the OS. It is safe >>>>>> to access the ESRT under Xen if, and only if, it is in memory of type >>>>>> EfiRuntimeServicesData. >>>>>> >>>>> >>>>> Thanks for the elaborate explanation. This is really helpful. >>>>> >>>>> So here, you are explaining that the only way for Xen to prevent >>>>> itself from potentially clobbering the ESRT is by creating a >>>>> completely new allocation? >>>> >>>> There are surely other ways, e.g. preserving BootServices* regions >>>> alongside RuntimeServices* ones. But as the maintainer of the EFI >>>> code in Xen I don't view this as a reasonable approach. >>> >>> Why not? >> >> Because it's against the intentions the EFI has (or at least had) >> for this memory type. Much more than EfiAcpiReclaimMemory this >> type is intended for use as ordinary RAM post-boot. > > What about giving that memory to dom0? dom0’s balloon driver will give > anything dom0 doesn’t wind up using back to Xen. While perhaps in principle possible, this would require special casing in Xen. Except for the memory the initrd comes in, we don't directly hand memory to Dom0. Instead everything goes through the page allocator first. Plus if we really were convinced boot services memory needed retaining, then it would also need retaining across kexec (and hence shouldn't be left to Dom0 to decide what to do with it). Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 06:30:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 06:30:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409965.652972 (Exim 4.92) (envelope-from ) id 1obFij-0008SF-OD; Thu, 22 Sep 2022 06:30:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409965.652972; Thu, 22 Sep 2022 06:30:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obFij-0008Rs-Jp; Thu, 22 Sep 2022 06:30:01 +0000 Received: by outflank-mailman (input) for mailman id 409965; Thu, 22 Sep 2022 06:30:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obFii-0008Rg-2d for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 06:30:00 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20053.outbound.protection.outlook.com [40.107.2.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fad97ed8-3a3f-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 08:29:58 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8361.eurprd04.prod.outlook.com (2603:10a6:10:24d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 06:29:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 06:29:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fad97ed8-3a3f-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FR2DOa9Yk25QWyKRrpIuHh4XU8uQa/t2+2m7m7evkPdjo7UZk3tGntPnpZjlyyOKdMUn8KNwaY2Zh25emRmbJUdv9eEx8qMIN/FdDtIzkngTY3/IhnguQDe3KmhM7luD/kdjmZSE50bm74yyUENADSPYYtBLEE2xJGWWaJZLuXubUoGtgEnMKH9bktXunXBdExzfplhJ2su69/E5ry5xnudxhuWMztctVBtpb6k2JTa/VKv1I7UsiIYADuY/Gb7blZ/En6kpIWE/DmnPQkDoqSLof77wolAjXIEb3WN8Eyb6jXnTvP98fhOpknML2Lzd61FR2UVSzy+DxRkgX5irTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xx33f59HE4qsKi5XbvBgAzXBkgYjUtuyAaD64JbbLT8=; b=fpB4GnO32JmTXWYr2P8DW6qO58ImYkonfVH7QTwzsZ90J3Fh1+3CytVdKPvweceNjQhxxnS9BYPTs+eN/h/OTQzBECwYokvuGdlWTTtW/cvqbP2lv5/UH201e+mgN30PUdjTUzMVVR++Ef8vzsLwh7ZUiXCrn5mV1B/9sb1z4BF/IOfPuHWzQ2IPsYASU5cj+2ZSu9FECd5K0bpIQHWoTmxdmaemWR0aIkWuOrnuYhe5Zv3Gsh+cDaCX+4gjEe4SJxkBV/XIFeynuYkjU5+/xbRTRp6+q56S3zkuLdLQ7OqryaADDzIuzb+tUENem+AvElNdK/GgmDr/tskg6oBubw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xx33f59HE4qsKi5XbvBgAzXBkgYjUtuyAaD64JbbLT8=; b=Uk5f/smdXiewWOphMQGqBWLxSLNpssQAJpINwKLVq/W9W+RBMKgDTIN505/ygONIbVG5droacXC8eNMEC3K7Ug8HKNVRteH+mELCYRqhoV7IRtBoOQJf+tmDN4/nrbs7KI1bCDK3FjzUvmtopBBOlkTKfIPRy7y+yEcZSzAKNLk+29kz3vaZ9bNsf1r2QJ7OvJsFg8hltzTb/r8iPOVfpJoo+bmHpbeD9q+FvQcEW4HR3hioMl8K7vPgs7JqQzdX1jligQIkwl3VgqvxJKKgFsLKILm54DZLr5UoHuOjlCjIWmD28wYbTRcrCSYtcKgsbP+l9fYUgLE06z9vPzNUDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3394db68-6569-50fc-a3f9-95b9756a0d89@suse.com> Date: Thu, 22 Sep 2022 08:29:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/4] tools: remove xenstore entries on vchan server closure Content-Language: en-US To: Anthony PERARD Cc: Oleksandr Andrushchenko , Wei Liu , Dmytro Semenets , Juergen Gross , dmitry.semenets@gmail.com, xen-devel@lists.xenproject.org References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> <336cfa84-2f32-286a-394b-fc596b2ce03e@suse.com> From: Jan Beulich In-Reply-To: <336cfa84-2f32-286a-394b-fc596b2ce03e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0185.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8361:EE_ X-MS-Office365-Filtering-Correlation-Id: e5f20f74-6838-40b0-f3a1-08da9c63dcd0 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Her9xEebZawsgbl0GqtPlnPrS5PE1/F9BOM0/huTDRXeTuVoE7fDOpR54j3sF5cgY0nvZwTprUgDP3k+hY3MgmDfVY/GR96W5sBO4qvm7WxuFZWGV87WLlexdAG+izXUo9TzqVEbSPnutPEngzbwY3qjuWLKVsx8dCQCUwRs2dTkxojKeH4gpuro8EMdnXo44AtZKkvcKKLgPxiFF6NlGcfetaBH6Xc3H7l/nBVBTqHHhG2JNL1yjz5T+V7X7v8v040gXHWyiJCuRLc+K2jqf/GNY9iMD6zeA/RCdDxmSg7lyZv6AsIyN/S5otyPSPdj6xL5H70fUggzCNw2V+g1BXJ1AKRydt77ThpDDscjqAiPUusGIpwPn6HHf7yJpceyZfAH/BacdvBnmJ0TZzJNe7HQvMzXepK1UWPPsIA9JGoZAAM/JWNmLN6TzUQyWYTh1TCghDrKWaxJWn7eYVAE73gsnx/tWZaGR+C1M/aHSseZZH3st5rC6DreSiLNtSPHztBzoLTncmNNSJ8kRFNHP3Y7FeYkZCmqxOTxOKmEve79IewmtIUViv3gyZdk5xo8ju02RlW5mfbGQnCvV55WtsvFrWs6fdEvEGNZ2aUvmCcp0AxpkK3BCGh96GpjPrQrgh2axZImZ9A1RgA4ZntGIgZ2H6Cm67qF2iOJh//VF43OQFLSKxs23rUxNeXMi9LdY9/6QLa6oDgNSKJqa8IMhxqN8OdiViufGFrTYjORst8M8PTX77eRgleLTDAyTBbVwhXJvMrxXoTQ/HhN/zjyLjLEDbwkGeIRCxW+gn52tF4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(2616005)(38100700002)(8676002)(186003)(31686004)(26005)(8936002)(6512007)(6506007)(4326008)(53546011)(36756003)(5660300002)(6916009)(2906002)(316002)(66946007)(41300700001)(54906003)(4744005)(66476007)(478600001)(6486002)(66556008)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzR5eTlsbUdsNWo2QTdvMlorMy9aNlV6OFZmc1hNUDlTYS95bUZSVXlPamtt?= =?utf-8?B?ck0rOUhJRllDT2x4Y1AxNHNlTFNBZUdFZXlVZ1VVRjZtZGNPT3RXQWozNzRk?= =?utf-8?B?YWh5bndEdGYzZEUwaWpuZGNtcGl6N0o1M2ZhdmdWMWZCZG1IL2hJR3VzN29l?= =?utf-8?B?eDlVYmcrN3M5N01OSzdDenJha1ZzazFLdlR4ZDNaNVJaQ0RUajh0N0FMRUVL?= =?utf-8?B?aHlCbmJ1SzhZM09lRGpSRzc3WktETWNab2NkZWJqUTVvZWtNd28zQ3krVlpS?= =?utf-8?B?MFNSbTFma0JaTjlKc1ZJWGUrNmpqOU5rVitaSEh1MVJIMjhhVkZSOEJjSS9j?= =?utf-8?B?Qi9XOHNDY3loL1ZTNkxGSk5EU0dDNUlEK0svRmpIbzRRUWlxUHQvSk53Vysz?= =?utf-8?B?M05zYzB1RWFYQXJ0eGhtakF3MTdYV3VwYnVBRHFBQ0RhTFdCdk1zWWdHNDRk?= =?utf-8?B?NmJ0SWVSSG5HMm1GSUFxZzdFQW5qYlNKb2I4R1lNWCtiUm12WTcwcnFvMWdH?= =?utf-8?B?YnpEYzlnUEkydEJGM1NzbU1PNmFZVWx1Y2NzeEZaeWNEcS80VE9sOG8xQUtU?= =?utf-8?B?c1NjK0kzQUcvS3JQSW9yVWRVOFlOYXZZS2g2NUFYQjh0d1haak9COUxhSmFr?= =?utf-8?B?WFhsYTBqNjJtaG1JVDNiTUdqTEplejNRSGlHcTMwSk9OTTFqT0JlU3NTcnk5?= =?utf-8?B?ak9wVllIeG1PNWZUc2U3UmFTaklyNjNmWFUwUHZmd2tqVnoyREJLS0laM3V5?= =?utf-8?B?aXlvNHcyMEw0cXpONUN4V0VIK01hRHRaMVZqZGkvdHlNZ0NzalJrSFhnWXhF?= =?utf-8?B?VXVNOHM1NCtwc2hSb3pUN2NTUUZGMDN1NklYM1dxWktLYklrNStzRUx3Tncr?= =?utf-8?B?ZmxJUHVzaWNjWkdkYXhEWEwvSExDeU9RcFFTNVhCWk9DekEzc2dyWC9VYUlF?= =?utf-8?B?NC9uOHl1MjlUeWg0M3krK1ptN0JBUW9yYnAzUWdYRmRUTjdaMjg4Nnl0SFY0?= =?utf-8?B?RTgvUlVMTHNMTVZlMlFlbjd2anJMVXBuTU9wSHJPUEZRL0w5OW5aR2o3TUZQ?= =?utf-8?B?ZHpNdUZYS0RMaTIvTEg0MlRYQnNBUEFSc2dnNU5DVnFFOU1SY3JqWEVVRFF6?= =?utf-8?B?dXhPdXhkdXU5ZUlLWVdibXJIT3FBWjhpeHp6L2xyb29QRzlNcTZnVW1XMnFO?= =?utf-8?B?T2V5SEpPbk9VWUhhNEU0ZlFPenY5ZmtQRnhqK09kV09KbE55Si8xL1JEZFc1?= =?utf-8?B?T2ZyQW45T1ZKNW91WktPOFcyTThyWm5jZnpFUk5OYVMvWk5FTktsdGFIdXdC?= =?utf-8?B?T1o3blM0OFAvK2FvN1p5bGE0SkdKQlBZTXF5RlV6TTUxQ2JsWVdrNXNpZnlu?= =?utf-8?B?bG91bEFuNHhpdmlrSHBHOU5GYnkvMTF4VEJnbW9VbzU0NTdGWDBieUVMZUI1?= =?utf-8?B?MkthbFIzbU54YVFXOWZQaWE5YlRDU084VVFDNjdxSWxiMzhReDNlT3Mvb2tH?= =?utf-8?B?NjcyMzJFOHJpdlNKbllqT1lzN3BqMTZwOHk3ZlBoQ3M5TTJrQXE0ZXdlUDYx?= =?utf-8?B?cU80WExCeHVBeDZDb0FCcmhKbVJ5ODdiWDRoQ1F0L0RxWExzejdLT2g1b1lv?= =?utf-8?B?dHM1WWVGL3BqanNIbDhhMWl6MU9Oem4rQTFOL3NJN1hha0RFcHU0OGxkc2pH?= =?utf-8?B?ZkhhRXZxVTBEVG8yRERNY2xLaTZ3OWswczZHSHYvSmtoTzR0dStoZVJxblRy?= =?utf-8?B?RW0rdGljVllLcWdGeGJyL3JHRnZoek93YnRRNThTSEhqaXlKM3lWUEFVUFQ2?= =?utf-8?B?NEYyTVNYYVZ0b0R1SmppVm9KUU1Ha1V0Vjc1Y2dDSU1haHM5czkrSTN1cTFj?= =?utf-8?B?bmhWRGtSa041bXlwWVI0bG9MRWRMYnl3a25XWG91N3JrUDVwbm5iN0pvazg4?= =?utf-8?B?TW1qMFNzTFFTTTQxL3hoMURTVmNQcVowVFJlN0Y0UzMvN3hHZWo5RGVsTmV2?= =?utf-8?B?V2lja3hEdjhaWjNBM2dENGY1NExMbmQ0UnoySGhLajdoWkV6QUQxK2hBYmRi?= =?utf-8?B?eEhqRnhnKzlLRCtBM2FvU2dvWTBTOUplK3JReDlDV1ZoYVJ6bDE3R2dHVTQy?= =?utf-8?Q?bl1qgeJIxdsudCJEAd0kkkEgH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5f20f74-6838-40b0-f3a1-08da9c63dcd0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 06:29:54.8285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FXDOo7ojQQ/ZKr03VnFjcLtmmDydJp/YBTuHqPRa5sQbRPtk4kI3oBMfaIge+Jqih3JA++FEj4NPQzkhPqFR8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8361 On 01.08.2022 10:57, Juergen Gross wrote: > On 13.07.22 17:03, dmitry.semenets@gmail.com wrote: >> From: Oleksandr Andrushchenko >> >> vchan server creates XenStore entries to advertise its event channel and >> ring, but those are not removed after the server quits. >> Add additional cleanup step, so those are removed, so clients do not try >> to connect to a non-existing server. >> >> Signed-off-by: Oleksandr Andrushchenko >> Signed-off-by: Dmytro Semenets > > Reviewed-by: Juergen Gross Anthony - any chance of getting an ack for at least this first patch? The others are more like feature additions, so perhaps aren't to go in anymore before 4.18 opens ... Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 07:55:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 07:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.409995.652995 (Exim 4.92) (envelope-from ) id 1obH37-0001SV-4P; Thu, 22 Sep 2022 07:55:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409995.652995; Thu, 22 Sep 2022 07:55:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obH37-0001SO-1Y; Thu, 22 Sep 2022 07:55:09 +0000 Received: by outflank-mailman (input) for mailman id 409995; Thu, 22 Sep 2022 07:55:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obH35-0001SH-HG for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 07:55:07 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df4cbadd-3a4b-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 09:55:06 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id lh5so19112666ejb.10 for ; Thu, 22 Sep 2022 00:55:06 -0700 (PDT) Received: from [127.0.0.1] (dynamic-077-191-214-084.77.191.pool.telefonica.de. [77.191.214.84]) by smtp.gmail.com with ESMTPSA id u17-20020a056402065100b0045081dc93dfsm3166610edx.78.2022.09.22.00.55.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2022 00:55:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df4cbadd-3a4b-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=XAn7c1pwQ/FfM7vHKOqOcGKKPoVtNy6cXXuDPbbsEMg=; b=KdwbP3Bc87qLjlpjsnO2AH1hFtCVaiTGJp44vkAjCHEyi2BVqdUN8ix+ddbhHaPK1r EqWJ5pPbZsCjVFS9e+dTsVJ0Foj6V+KoT4fRyJlz7QqnJ/8hVqxrc1Ho7ZLeIspC87hS EwLwWL/B0irPWwT9KoGor+fge4WF8zkBMONJ36LmRsHQ1cCTfxd9d0oVkt47Fb8ho6Yq vGRDgumcb7zLXHHzBCfP5aDStxiv4J7vmNbl/fZPXSp3qCOfLbaEdK0wuuYY9KcWK55E P9+VDLqy0HdpS4ndwVtZP2lM2k+QoDCxBOx6WyXF/QkqHcfEpOC7COF2TxEu7OhFiih6 yxPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=XAn7c1pwQ/FfM7vHKOqOcGKKPoVtNy6cXXuDPbbsEMg=; b=eij2bUdXUlVqZuq1jKWYm7LPtLl54CA5JXZ3/9Km98uublB1ejZctnmYQAlqLsWO7x 6RjdT2311a6O4PWdLcnU6OcZ22azP/dqCV2ir6yfmJHiiLM+7M31rQUjUb9TTlvYHcP+ tyxf/RtKC1ncZF12+82Nt4XBWuQcDu9GSUN7oFZG+ox3yQKfVLymQjO2JpOwbw2AXTBe yR2LmQpUPLgfCE1oEqqVa2CBQyRvG26rm038FYChEjyVtHltxlcVkEfVzkmLrvJKMh9v 7YAB1mKKJG+9zFk1WtpwVekpMSE+TiR93mWseXXdCcuSjWvRkZq3FCC0Lg16RtN/A2qy cbDw== X-Gm-Message-State: ACrzQf2nnE3tkPvcoGQ7aLNs1iqoYZR+W31fKGQil8/0iQuL0pWdXdgM aEQ4JbGhjcGL1JCxEkBCs2w= X-Google-Smtp-Source: AMsMyM4vh+kpWsvDAV6UjWoPXkkUVHDYB2adjnMzVWEdRb430ELqUeGucGcmkbkYyJGj0Q/DyqUmmQ== X-Received: by 2002:a17:906:9b93:b0:780:3b58:93e1 with SMTP id dd19-20020a1709069b9300b007803b5893e1mr1620475ejc.698.1663833305755; Thu, 22 Sep 2022 00:55:05 -0700 (PDT) Date: Thu, 22 Sep 2022 07:55:01 +0000 From: B To: Markus Armbruster CC: Alistair Francis , Bin Meng , Palmer Dabbelt , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState In-Reply-To: <87a66tgwd5.fsf@pond.sub.org> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> <87a66tgwd5.fsf@pond.sub.org> Message-ID: <58A6CCCB-7426-41A2-9D3A-0683FBC51F47@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 21=2E September 2022 04:55:02 UTC schrieb Markus Armbruster : >Bernhard Beschow writes: > >> Am 20=2E September 2022 11:36:47 UTC schrieb Markus Armbruster : >>>Alistair Francis writes: >>> >>>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >>>>> >>>>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims i= t to >>>>> inherit from TYPE_MACHINE=2E This is an inconsistency which can caus= e >>>>> undefined behavior such as memory corruption=2E >>>>> >>>>> Change SiFiveEState to inherit from MachineState since it is registe= red >>>>> as a machine=2E >>>>> >>>>> Signed-off-by: Bernhard Beschow >>>> >>>> Reviewed-by: Alistair Francis >>> >>>To the SiFive maintainers: since this is a bug fix, let's merge it righ= t >>>away=2E >> >> I could repost this particular patch with the three new tags (incl=2E F= ixes) if desired=2E > >Can't hurt, and could help the maintainers=2E [X] Done=2E Best regards, Bernhard From xen-devel-bounces@lists.xenproject.org Thu Sep 22 09:29:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 09:29:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410048.653024 (Exim 4.92) (envelope-from ) id 1obIWP-0004Nk-RO; Thu, 22 Sep 2022 09:29:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410048.653024; Thu, 22 Sep 2022 09:29:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obIWP-0004Nd-OI; Thu, 22 Sep 2022 09:29:29 +0000 Received: by outflank-mailman (input) for mailman id 410048; Thu, 22 Sep 2022 09:29:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obIWO-0004NE-2q for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 09:29:28 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02f14c69-3a59-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 11:29:11 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 25F7232008C3; Thu, 22 Sep 2022 05:29:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 22 Sep 2022 05:29:22 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 05:29:20 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02f14c69-3a59-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663838961; x= 1663925361; bh=kMMryYpmoWdMuTknZDtMqJzGyKhvqSBRnwLGeAnUXCM=; b=l hjXKUglNEaqOsVOpgCfzf+TNIwB1VjC0rdLNPzCIKPJdQBwm6itxQCdPj28SDFtj 0CjtHH6cwhWgbOoZAhaalBojFAZpTZfocx4CFel7CteLMlleVSU81h9ig86wCAxU ggTXnxfXIUDjxUu5RO0QIA/dZoYctP2UUA6FRiP6b0IZVHdAhafnDl6PAHEv/9TK 7tujb4txMaCWQJxbjAOTZoc3WssBVwlPANVlmhfDz3qlqAa+5mR1JfZHZlZp02/E 6gn7iGDbPT+OUAJDnGcsPkjzozm3oOq+5mpQsMaQYgVwvdCcZm6m7yCqqRXeUqH5 opSc3CVuwZri/L3MR6dGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663838961; x=1663925361; bh=kMMryYpmoWdMuTknZDtMqJzGyKhv qSBRnwLGeAnUXCM=; b=rxOjfUaL9hl7vsdMvYStuCMpaCveMHUcfcaUXkadM5Bv OQ7oxXhIPadc3YajxjdaE+RvWwAETx0RpGm+HzB4hkxm9zDOTmhPBUcexdyQ5WcD eYuXzPMGpNIOVx+6lroQVminLpw2OMYxbV6GnQGmCtr9Ene6M9E7eRLoQaNp4yHh lyX5lxEnESnpqQZ/g5bJMX8tU2Q4ggBOzKF3k/WLBYMC0HIUB6m1gYO4YjYxPxVx ofskCRCEQlwM1W62/QRqqRgkdWDv6VpbIlOUk5LFToDZXz1hW3t+JyPXO9HbCFAm /YJ2qbLwulg6/j8xzYJu+7u3Bb0vyRNPYLs/va7yjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeffedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 22 Sep 2022 11:29:17 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Kevin Tian Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Message-ID: References: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="shlZlOXdfY6WjTED" Content-Disposition: inline In-Reply-To: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> --shlZlOXdfY6WjTED Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Sep 2022 11:29:17 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Kevin Tian Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API On Sat, Sep 17, 2022 at 04:51:27AM +0200, Marek Marczykowski-G=C3=B3recki w= rote: > Re-use rmrr=3D parameter handling code to handle common device reserved > memory. >=20 > Signed-off-by: Marek Marczykowski-G=C3=B3recki Kevin, can you please review this patch? It's unchanged since v3, and pending review for some moths already. > --- > Changes in v3: > - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR > --- > xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- > 1 file changed, 119 insertions(+), 82 deletions(-) >=20 > diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough= /vtd/dmar.c > index 367304c8739c..3df5f6b69719 100644 > --- a/xen/drivers/passthrough/vtd/dmar.c > +++ b/xen/drivers/passthrough/vtd/dmar.c > @@ -861,111 +861,139 @@ static struct user_rmrr __initdata user_rmrrs[MAX= _USER_RMRR]; > =20 > /* Macro for RMRR inclusive range formatting. */ > #define ERMRRU_FMT "[%lx-%lx]" > -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn > +#define ERMRRU_ARG base_pfn, end_pfn > + > +static int __init add_one_user_rmrr(unsigned long base_pfn, > + unsigned long end_pfn, > + unsigned int dev_count, > + uint32_t *sbdf); > =20 > static int __init add_user_rmrr(void) > { > + unsigned int i; > + int ret; > + > + for ( i =3D 0; i < nr_rmrr; i++ ) > + { > + ret =3D add_one_user_rmrr(user_rmrrs[i].base_pfn, > + user_rmrrs[i].end_pfn, > + user_rmrrs[i].dev_count, > + user_rmrrs[i].sbdf); > + if ( ret < 0 ) > + return ret; > + } > + return 0; > +} > + > +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ > +static int __init add_one_user_rmrr(unsigned long base_pfn, > + unsigned long end_pfn, > + unsigned int dev_count, > + uint32_t *sbdf) > +{ > struct acpi_rmrr_unit *rmrr, *rmrru; > - unsigned int idx, seg, i; > - unsigned long base, end; > + unsigned int idx, seg; > + unsigned long base_iter; > bool overlap; > =20 > - for ( i =3D 0; i < nr_rmrr; i++ ) > + if ( iommu_verbose ) > + printk(XENLOG_DEBUG VTDPREFIX > + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\= n", > + dev_count, sbdf[0], ERMRRU_ARG); > + > + if ( base_pfn > end_pfn ) > { > - base =3D user_rmrrs[i].base_pfn; > - end =3D user_rmrrs[i].end_pfn; > + printk(XENLOG_ERR VTDPREFIX > + "Invalid RMRR Range "ERMRRU_FMT"\n", > + ERMRRU_ARG); > + return 0; > + } > =20 > - if ( base > end ) > + overlap =3D false; > + list_for_each_entry(rmrru, &acpi_rmrr_units, list) > + { > + if ( pfn_to_paddr(base_pfn) <=3D rmrru->end_address && > + rmrru->base_address <=3D pfn_to_paddr(end_pfn) ) > { > printk(XENLOG_ERR VTDPREFIX > - "Invalid RMRR Range "ERMRRU_FMT"\n", > - ERMRRU_ARG(user_rmrrs[i])); > - continue; > + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", > + ERMRRU_ARG, > + paddr_to_pfn(rmrru->base_address), > + paddr_to_pfn(rmrru->end_address)); > + overlap =3D true; > + break; > } > + } > + /* Don't add overlapping RMRR. */ > + if ( overlap ) > + return 0; > =20 > - if ( (end - base) >=3D MAX_USER_RMRR_PAGES ) > + base_iter =3D base_pfn; > + do > + { > + if ( !mfn_valid(_mfn(base_iter)) ) > { > printk(XENLOG_ERR VTDPREFIX > - "RMRR range "ERMRRU_FMT" exceeds "\ > - __stringify(MAX_USER_RMRR_PAGES)" pages\n", > - ERMRRU_ARG(user_rmrrs[i])); > - continue; > + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", > + ERMRRU_ARG); > + break; > } > + } while ( base_iter++ < end_pfn ); > =20 > - overlap =3D false; > - list_for_each_entry(rmrru, &acpi_rmrr_units, list) > - { > - if ( pfn_to_paddr(base) <=3D rmrru->end_address && > - rmrru->base_address <=3D pfn_to_paddr(end) ) > - { > - printk(XENLOG_ERR VTDPREFIX > - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", > - ERMRRU_ARG(user_rmrrs[i]), > - paddr_to_pfn(rmrru->base_address), > - paddr_to_pfn(rmrru->end_address)); > - overlap =3D true; > - break; > - } > - } > - /* Don't add overlapping RMRR. */ > - if ( overlap ) > - continue; > + /* Invalid pfn in range as the loop ended before end_pfn was reached= =2E */ > + if ( base_iter <=3D end_pfn ) > + return 0; > =20 > - do > - { > - if ( !mfn_valid(_mfn(base)) ) > - { > - printk(XENLOG_ERR VTDPREFIX > - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", > - ERMRRU_ARG(user_rmrrs[i])); > - break; > - } > - } while ( base++ < end ); > + rmrr =3D xzalloc(struct acpi_rmrr_unit); > + if ( !rmrr ) > + return -ENOMEM; > =20 > - /* Invalid pfn in range as the loop ended before end_pfn was rea= ched. */ > - if ( base <=3D end ) > - continue; > + rmrr->scope.devices =3D xmalloc_array(u16, dev_count); > + if ( !rmrr->scope.devices ) > + { > + xfree(rmrr); > + return -ENOMEM; > + } > =20 > - rmrr =3D xzalloc(struct acpi_rmrr_unit); > - if ( !rmrr ) > - return -ENOMEM; > + seg =3D 0; > + for ( idx =3D 0; idx < dev_count; idx++ ) > + { > + rmrr->scope.devices[idx] =3D sbdf[idx]; > + seg |=3D PCI_SEG(sbdf[idx]); > + } > + if ( seg !=3D PCI_SEG(sbdf[0]) ) > + { > + printk(XENLOG_ERR VTDPREFIX > + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", > + ERMRRU_ARG); > + scope_devices_free(&rmrr->scope); > + xfree(rmrr); > + return 0; > + } > =20 > - rmrr->scope.devices =3D xmalloc_array(u16, user_rmrrs[i].dev_cou= nt); > - if ( !rmrr->scope.devices ) > - { > - xfree(rmrr); > - return -ENOMEM; > - } > + rmrr->segment =3D seg; > + rmrr->base_address =3D pfn_to_paddr(base_pfn); > + /* Align the end_address to the end of the page */ > + rmrr->end_address =3D pfn_to_paddr(end_pfn) | ~PAGE_MASK; > + rmrr->scope.devices_cnt =3D dev_count; > =20 > - seg =3D 0; > - for ( idx =3D 0; idx < user_rmrrs[i].dev_count; idx++ ) > - { > - rmrr->scope.devices[idx] =3D user_rmrrs[i].sbdf[idx]; > - seg |=3D PCI_SEG(user_rmrrs[i].sbdf[idx]); > - } > - if ( seg !=3D PCI_SEG(user_rmrrs[i].sbdf[0]) ) > - { > - printk(XENLOG_ERR VTDPREFIX > - "Segments are not equal for RMRR range "ERMRRU_FMT"\n= ", > - ERMRRU_ARG(user_rmrrs[i])); > - scope_devices_free(&rmrr->scope); > - xfree(rmrr); > - continue; > - } > + if ( register_one_rmrr(rmrr) ) > + printk(XENLOG_ERR VTDPREFIX > + "Could not register RMMR range "ERMRRU_FMT"\n", > + ERMRRU_ARG); > =20 > - rmrr->segment =3D seg; > - rmrr->base_address =3D pfn_to_paddr(user_rmrrs[i].base_pfn); > - /* Align the end_address to the end of the page */ > - rmrr->end_address =3D pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAG= E_MASK; > - rmrr->scope.devices_cnt =3D user_rmrrs[i].dev_count; > + return 1; > +} > =20 > - if ( register_one_rmrr(rmrr) ) > - printk(XENLOG_ERR VTDPREFIX > - "Could not register RMMR range "ERMRRU_FMT"\n", > - ERMRRU_ARG(user_rmrrs[i])); > - } > +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong= _t nr, u32 id, void *ctxt) > +{ > + u32 sbdf_array[] =3D { id }; > + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); > +} > =20 > - return 0; > +static int __init add_extra_rmrr(void) > +{ > + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NU= LL); > } > =20 > #include > @@ -1010,7 +1038,7 @@ int __init acpi_dmar_init(void) > { > iommu_init_ops =3D &intel_iommu_init_ops; > =20 > - return add_user_rmrr(); > + return add_user_rmrr() || add_extra_rmrr(); > } > =20 > return ret; > @@ -1108,6 +1136,15 @@ static int __init cf_check parse_rmrr_param(const = char *str) > else > end =3D start; > =20 > + if ( (end - start) >=3D MAX_USER_RMRR_PAGES ) > + { > + printk(XENLOG_ERR VTDPREFIX > + "RMRR range "ERMRRU_FMT" exceeds "\ > + __stringify(MAX_USER_RMRR_PAGES)" pages\n", > + start, end); > + return -E2BIG; > + } > + > user_rmrrs[nr_rmrr].base_pfn =3D start; > user_rmrrs[nr_rmrr].end_pfn =3D end; > =20 > --=20 > git-series 0.9.1 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --shlZlOXdfY6WjTED Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMsKu0ACgkQ24/THMrX 1ywnSwgAjymJRdQCI+4xzo4Y6tG8znXJ1zAqfbtcQ+JLRBoNfBhQ/8FHhCa03v0T ZKb1nKJPd4YFu44LCwkDi60Gpm5Xknu6bIJYHw/SGnohnXvrFmOI8SUZQmuD6sMq gs6GAWnQZZZKzOLDMIFlLRw+HDMRnHonwUPUGUVbt3jbmGtZe19WfpR4j0JXeFkA GyL/zdKtpfTFyqS3SHtBo1lfupqHmFDmkFJWWlP0APyTtwu8cs7tVILEVsiOzZrW tyMszNGwumhFqLNYkGw6j59eC9YRS6ZzsMCE3PTuXMS/sJ33ZuHMO6BNUwKMSQk2 juDaaOeB6YEAZ4zvJUtXLKbcTZL4Pw== =PUUv -----END PGP SIGNATURE----- --shlZlOXdfY6WjTED-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 09:37:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 09:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410055.653035 (Exim 4.92) (envelope-from ) id 1obIe0-0005wE-KS; Thu, 22 Sep 2022 09:37:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410055.653035; Thu, 22 Sep 2022 09:37:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obIe0-0005w7-Hp; Thu, 22 Sep 2022 09:37:20 +0000 Received: by outflank-mailman (input) for mailman id 410055; Thu, 22 Sep 2022 09:37:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obIdy-0005w1-OR for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 09:37:19 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061.outbound.protection.outlook.com [40.107.92.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1cc79c16-3a5a-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 11:37:03 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH2PR12MB4310.namprd12.prod.outlook.com (2603:10b6:610:a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 09:37:14 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.019; Thu, 22 Sep 2022 09:37:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cc79c16-3a5a-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3UFUrauKFflgzQA7JbA6vWZTB8lPG7JPtG0HWlDts9kEHDCoMEuvHU2ZROPEDd1Pn5CVY5XgrY0H+EGZNSpf5TPJ13TRzk5H/9H1TnXZRVBh9tzB8VaB+F+FVIO2FLU6KJpdxr0OzQXgggFFR1I/Yj9UiutMD5IfEnqV4a1QjJZ9AbBAkw7NX8LdfoVEKQq6plCu7dCNQGBQpiNivSCTai+vY3tW3Qr4b97ryPfEZcijF8ItnhnmThvknKfTjQEppgYbvAJQTRkzKtp1pzX/ktBBIn6WlTe2QyLrZqI2zOue9OgOQAUukyoQCEvY7GV7XKxHx21uWj47s1P3Ix+0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MUMi/Rn9XydsAH+mfogIjYI3FWVVY4P88+IiOvCrgFA=; b=Q+xhiSUigOrDoH3D9neXW3tuTnuw67qpsY7R/XzsOm6UPM67jm4KaXIRp/EcvMDreSOLrpouWcPi/fWFOYldhqZbi1TNYmkGYWoE/G0hXJ8UJNt0sPMLG9Yfzc3SVbBVU2CyEL0xvH7mB669MV2H0qk+AbHP2lPD/PY6a4LtBHqN8k7z4laCY3WjoVh4LYI7JOzM4VxELa1dwhJZx3pCOprtfpuXw1if6aPRkaE72r9ADnhVuufQXzcDhJnvE36F93gajrOqFIj7fpEPKkPV9GqW7LXaTP35NlGFT7H/bbQo/FJ03Y0HHbyAYKjMTPMQbea23879W9RN5/bui7HBTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MUMi/Rn9XydsAH+mfogIjYI3FWVVY4P88+IiOvCrgFA=; b=TtZnBb5Pj95TXzVpto9/jIQfbK6T1YpSMPKwlmQAL3HTGnDbLlt5M6KWvxJZ4TRyqsK4YA7E31Hl9rCzV6S0JX8L09liSqkHraUety7cVyGpAUvRvA2UC/41PGIAAzpsOyfUCs06L1IPICFDXJ5pI3fPPa3fT5PBxBxLdZX+gFE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <8b210398-9db9-1279-85fc-40a7cd2403b7@amd.com> Date: Thu, 22 Sep 2022 10:37:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Ayan Kumar Halder To: "xen-devel@lists.xenproject.org" Subject: "Address space isolation" - meeting notes Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0118.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::15) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH2PR12MB4310:EE_ X-MS-Office365-Filtering-Correlation-Id: c32fe3ee-39b0-4229-7074-08da9c7e05f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3EtlAG1J3pT4TNDiviZ1RBRdj7p07REJ6gSV7McKoCSiAJeWXc6VFysFswax0bz2y9lU67sQlEhrB4HdDIXoMB9JBFedoUEBgkFK28bsRFnxCm6Yrxcuw+iC4jT3Q1QmZ1BtoAxcUklP0dY2Qfh79eiLLTGPoM+GWgb6Wx5btvBweknFaa6j/ENSItxUQP7PypKNNt+dT8IBa7i0of+nDbVWvEG9LZ7Gt6+BIeiZDevzCCALd+SPm7I7aph+YKfqkjSTJfu7Wj2/Jj5cvzi9W0T+jgkh+XKmHtYjQ2+BbCn9RG4dBDvVxKTcky5MTU8+TYod+SRNYGaE8+EN1TxuFjCaVQMb/tVwNxKGXItQ6yCw2TOgW4kAOzl69fOpghmPpFOr0Oj8qXWzwqqMiag6XHVbzD/TEvo4f3GoBbxl1bXWBvLHsMzY2Gafu8KOdVMrkC1w0nzV9gq5Kmcf+jrEguIU4Vr4f7JDm/uO+OumZT5zs5DJdHDvY4rd8WbAAw3Dv1qZsRdJCUzr5E8JQP+JK2mMas40W31WGQxo9dZMc0BkA52zIYA560qoMMlQkMmby0EfJfR5yYK/64yPG5NM/IGjloPwti+M6jlk1xV9GSjVjdhf5YcjyKx/f7ig2qc6LW9uWHk85QWE5SWAE/plgry1elT29GM+QBY283zaLzR3MPeqL6bkS5QCPMxQkSAcoOLNmSp2Ev0xGmcAuaNoY6TDXnRsWQcP9HhBI0YgMFa4rw7u+g1oGrzHLfyGbYLLtKRWQarGZKm36GuVl5Y9Stw6C8q710lbIGEu9KekipU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199015)(8676002)(5660300002)(2906002)(31686004)(41300700001)(6666004)(6512007)(26005)(6506007)(38100700002)(66476007)(66946007)(66556008)(8936002)(45080400002)(316002)(6916009)(31696002)(478600001)(6486002)(36756003)(83380400001)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEZMWjdmc3BoN3NJSlkzZ2dRckVwdEJtTDJ4T1hNdTZaTGJjZDNhc1c5ZDU2?= =?utf-8?B?TS9CbGNKYm5DbkhsVWRlR3oyUTZ6R3JnUzA3SjZWUERQM0FTVk9mMXptL0Zh?= =?utf-8?B?bkVDMlREMm5UblFJZTQ2eHRLRU9pR3Zic0ZDb0tGZm1QUk43bGpDVG94Ui9R?= =?utf-8?B?N0s0U2Jjd0tCeFE0cGJtdUwvSTJFbTVmQTlxMFA1bDUrcUY3NXVERjl5a1NO?= =?utf-8?B?N3lvNFRSb1Z0R05MNXZzTjRSMnhMNFhSWVdrZGg4c0RuaHRvK1FxQ21CVmRK?= =?utf-8?B?QVkwVnNkTnZwdktxTzAzS1gxVFlDam1qR0VjNjg5TXpHdmMvVDF1MXpGZ1RT?= =?utf-8?B?d1NhdGM0VUVTSTd0YVdsTzBtMlZOdFVJeFNWY1NiSzZaVWF1aFlrSlNOUVFi?= =?utf-8?B?REZuUUE3a3FxSXZRTXZoakt3MTBTV01taG16TTl5bTFpTiszZXdWK3RMK0ZI?= =?utf-8?B?K2lVWW5RNHJzY3RYS1lKbmZsVWVJWGpBZTJ0WHppTzRvSzZ3LzVVL0FEZzJP?= =?utf-8?B?NGlaOG1mVWRkK2NSTWRhOE5vNFJRWmN6WWQvN0VJZ09zY1ViOXpVVGhKc2Y0?= =?utf-8?B?RFZlVTRYb1RMN0RzMWd4Y1M1Wm0xUHhOZlI3cWFNWDBuTkNPUndQbVV0cXlj?= =?utf-8?B?dVJOYm1yc0VISCthbnZzV1ZVUTdUWkZYQlFkN2hHWkcwRzRrVVdZcmVUV3ZU?= =?utf-8?B?UGxxV29DaEdWU0tvWFNabnFuS0VpUmVUcXdYM2tWanBiMVVhYzlkMmJLL3lL?= =?utf-8?B?RXNQT3NMNjV5Q2NYalYwWVp4b2E2Ymc1K2lFTmdhQmFIb1AvUEFzcWZzbU1B?= =?utf-8?B?eVZFdnM3WG5GZWdzWjU2Zm5jYjBUcTZMWk4rL1F4ZWY4U3FLdUR4aDIrYTIx?= =?utf-8?B?VTZHV1dXWTJBeW92TUtDRWpzUUlHOXpkckZyb2NRZkpMNmZralVrOUo5ZWRv?= =?utf-8?B?M0V2cHd5dHRIYThCaDRhNnVCMnFDbkxGSC9rVzFTWmlHY2tDTlNsaDhSNVlT?= =?utf-8?B?U0Z6azM5dWFTZldzdWhkVUNzYm11R2Rld3lWdG1YaWFJNUV0RFVnSVhoRy9t?= =?utf-8?B?VXNJQ05NQnhHdjFmYlE3RHdhWEVzT0ZzemdpT0lIbE5aaitFWFk1bEEraUJB?= =?utf-8?B?WUV0Wnh1QSttMHVjU245dlBCaUFyRmZWc2VsakR5eVh2N2pUd0pTS0RUWk1k?= =?utf-8?B?TnBHbHA1ZytFOFJQVXBUd3JOSDZkYlI0Z01DbURjenh5ckVFSCtpK1c2YkZE?= =?utf-8?B?YVdZU1lyM25rZkNGYUtsZVV2bDJvc0lUTk1lRmpYeFl0ZW9RYXpuNmY1VlZ6?= =?utf-8?B?Vzg1a0hTV05peDlVYnlsbWVIeVFGQSt1anIvZkk4QVFtUzVhTEhmNXlJbGRk?= =?utf-8?B?UzNwRkFsbUVlK1NPZStkZ1pHamtBYVJXeDAybndWd2dEQ2lqS055ZWFLbVZC?= =?utf-8?B?Q1FvSDRKTUpwSHl3SFN1aHE3bmZJeUd1QmthYmtmSzVWY3NydzRYZlVGc0Uw?= =?utf-8?B?TmlWR25GUjVjV3Z3R2V4WTBWVDlmV2pKRncxRjVRUjZrT3VhbHFCK3cvMmN3?= =?utf-8?B?N1p6bzNCVzVscW1iT0ZCUDJ5UDFPM2VGcFF1R3BaalBJajJvYUx5bTNOSlpq?= =?utf-8?B?Wk9xalkwb2RHUlJaUitucjhqNDhXSmFSWmp1WExwc3o3UVNlODRSam1xNFFl?= =?utf-8?B?MlRaTGg2QXZERm1SREJTOFdSMm5OSHNlMjF6NFdobStuVlJhVy9lWitrWllH?= =?utf-8?B?aG9hWW1XOTBZblkzZERIL1JUMG43c3JEaG1JWFJwZnNrUjBJT0pQSTJOTmhz?= =?utf-8?B?NFpIaElySCttcjJIUXBpa0Zzbmt4ay84V01KTmhhZTZyNkZaS0dsVHNFQWJL?= =?utf-8?B?VEFEeVB4OVRMY3k3VzRVMlNNQ2dsOEJyRVZTbXFHaE9DalpYUWhOZFZMVFAy?= =?utf-8?B?Z2hxQzlMa002cXFjVDNrZk12RFJKeTJDWkZEQ0N6b0wzRlZsbUNOaytYSFA5?= =?utf-8?B?blpUeS9ZTllWM1gxQ1FFVFVvZnFOblZuSHB0dllBSW50WGdWaDNmWTNQbDNa?= =?utf-8?B?dFZSOThDOGZWMGwwaFFKb2o1MGlUaXEwNkR4NWRUVytGZmpIdjdYbURyNXds?= =?utf-8?Q?vabUatg9ROVuwu2oJjlhR6EHj?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c32fe3ee-39b0-4229-7074-08da9c7e05f3 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 09:37:10.7873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qYzK/OFahpJsAqqHS4SxnEROzLmCER6i2t3n/pxbgMOq89npZAJdNAruMHSD3fXh5otkuDzSWp9b6PY8CbPgPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4310 Hi All, PFA the notes (credit - Samuel) as below. Kind regards, Ayan Problem :- Bugs in HW speculative execution on modern processors. Leak info from one guest to another, from hyp to malicious guest. Some mitigation taken in Xen, but have performance penalty. There is also core scheduling in Xen. We run Xen on VM exit. Xen try to map minimum information in page tables. If some point, Xen needs to access sensitive info, it switches to new set of page tables which maps all memory. It should use aggressive techniques for security. The approach inspired by the linux kernel. Paths used from guests are a limited set of what the hypervisor can access. Minimal pagetables for guests, with less mitigations needed thanks to this (why?). Bertrand - Introduce Kernel page table isolation (KPTI) is already in Xen Jurgen - AWS has submitted some patches in Xen in this regard. It applies to x86, may applies to Arm. Not sure of the current state of series. Andrei - Does it related to KVM ? They published some set of patches. Jurgen - Kernel page table isolation is different to Xen. Andrei - Split the info into globally confidential, not confidential. There are some hooks triggered by this transition. KVM patches may be adapted by Xen. Don’t know Amazion patches. Jurgen - Who was driving at Amazon ? Bertrand - Mapping the whole memory in Xen was a concern at Arm. KVM security patches need to be interesting, but attack surface differs between Xen and KVM. We should not repeat what is done by KVM Jurgen - Need to show the mitigation is better than current approach. Mappin all the memory might be interesting. But sometimes we don not have enough VA space. Roger - posted a linked from Microsoft research explaining the work had been done. “Rethinking isolation in the age of speculation”. With KVM and Microsoft’s work, it may be interesting. Bertrand - Should find a way not to map everything in Xen. No one opposes that in Xen community. Andrei - Check first the ongoing work in Xen community. Bertrand - Should do the patches with x86 and Arm in mind. Jurgen - Agreed. We should do for both architectures. Hypervisor resources needed for guest should be kept in mind. Per guest mapping should help here. Bertrand - If we know what memory is mapped for each guest, it should help. Andrei - Is it a Arm feature ? Bertrand - Most of the data is stored in guest. A guest should not starve Xen so other guests are not affected. All the data pertaining to a guest should reside in the guest (not in Xen). Andrei - Permissive mode should help ? Bertrand - Per guest heap should make security easier. If we have guest heap mapped and Xen heap mapped, that should be preliminary work. Jurgen - For sys call in linux kernel, map little stuff in the beginning and map things in page table on demands. It is still is a idea phase, don’t know performance impacts. This was discussed in 2018 in Intel summit. Andrei - We should gather this techniques in a series of patches Bertrand - If on Arm when mapping on demand, it will generate exception and passes control to Xen. Jurgen - This should be common across all arch. Exception handler should be handled in virtual mode. The idea is to map all the code initially, and this will reduce complexity. Need sys call handler spec and page table Bertrand - You will generate exception , then it can generate Spectre / Meltdown issues Jurgen - Need to consider flushing buffers in and out of exception. Mapping buffers will add penalty. Bertrand - Spectre / Meltdown mitigation made system slower Jurgen - On x86, a simple solution is to run without cache. Bertrand - There are some hooks in ATF. The hyp may call the firmware. Some CPU have specific info to flush cache. Like turn on off in MMU, and it impacts performance. In some CPU, the mitigation is done in hardware. In Arm, the mitigation techniques differ from CPU to CPU. Mitigation (mapping + page exception) will make Xen complex. Like we need to flush TLB when going to gu8est. Jurgen - in x86, when one core enters hyp mode, other core should also enter. Need IPIs. Bertrand - Need to underatdn how mitigation applies to Xen. Our surface attack in smaller. I don’t know if the mitigation techniques solve anything Jurgen - Mitigation is a nice conceptual project, but don’t practical. Bertrand - This should be research project in a uni. No immediate requirement. Andrei - What happens on KVM ? Does mitigation lead to better performance ? Bertrand - Security issues are not discussed widely in Arm Jurgen - Should be able to find a KVM engineer to give us performance data. Bertrand - Sometime performance impact may be case specific Jurgen - We do thorough performance measurement. In one patch series, our performance engineers have analysed thoroughly Olivier - We have to continue to investigate in community. We should create a epic for this. Bertrand - Epic 1 - Reduce the system memory mapped in Xen. All agreed (Jurgen - the patch series by Amazon is floating). We need to prioritise this and do it across Arm and x86 Epic 2 - Per guest resource mapping. Understand performance impact. This concept applies when core scheduling is applicable. Isolate guest on specific code, then some issues may decrease Jurgen - Core scheduling depends on cache hierarchy. It is configurable in theory. Has a performance impact, Bertrand - On Arm, the impact may be CPU pipeline dependent. There is no easy answer. Sometimes some core are not affected. There is a NUMA series on Arm sent by Wei. Question to Wei - If the core (which core on same socket/platform) topology is available on Xen now or after NUMA series ? Wei - On NUMA support, we have a way to determine which core belongs to which resource. We cannot distinguish on hyperscalar. Can’t distinguish between logical / physical core. Bertrand - There is only one core with hyperscaliong available (A65). We should check this. Jurgen - Let’s see how the ongoing project gets done. We need to invest some work to measure the upsides and downsides. The approach looks promising but needs to be tested. It's a very nice project but this *might* be a waste of time - and we don't know by advance. Bertrand - It is quite some work to be done cleanly. From xen-devel-bounces@lists.xenproject.org Thu Sep 22 09:49:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 09:49:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410063.653045 (Exim 4.92) (envelope-from ) id 1obIpN-0007ay-QO; Thu, 22 Sep 2022 09:49:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410063.653045; Thu, 22 Sep 2022 09:49:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obIpN-0007ar-NI; Thu, 22 Sep 2022 09:49:05 +0000 Received: by outflank-mailman (input) for mailman id 410063; Thu, 22 Sep 2022 09:49:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obIpM-0007al-UU for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 09:49:04 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c9315948-3a5b-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 11:49:02 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 09:48:59 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.019; Thu, 22 Sep 2022 09:48:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9315948-3a5b-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WMBIw5BDxQWPq4FucLTcjG2J66qUBVcL3b6+cyDC/LvxwF2cy053F8zWY6QncPENTruzJZzsw1QkoydR4I/CQKJd0/DjGI7vVH7qUBI/kfQR0ACWiRGiofGXHRvt9s7VcHu5YBrzU4TB7rdChedxoqCHC8OxxATZpQk0W6ubJFnJDlvwKHIjRHmGCGpqSXz/HngelGNPuEtMYR/Rj8Gyy0IjP2YHF2MwwXE9B5JkaC8kJf02KEZQLruRkJs4OrssUUb90SBqmZr7BmVZv+f+hvtLkGnoE88S/TRiFR1gHHq8B3P1jmsbQKd5OK38EkgB4frys7MPmx9QhAaasaIqPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wW5M5FQbI2JEbOjFtRzhDqx08LEuavkzzBCA1+dCRPU=; b=i4ihtD+QlNJQDWZWR3j73T0GtFId/bTM9yI3zaCUfMwKudm+txrWK89Vmm0ufuwTS5QQw28LBtOljPQj+MJ5S5wwuzzkfEge/+86O7Zvu5yDCeMXocrO+fyfiA6BoebmRZRJatum6BoLGsLvT+sU/dRvgN3BdAKiKn7c5Z+hMCf9YqZ8WcZ4wQAA0CLezdlMxdJFaSef/vR9wo7zk9YX4zoBgsd84DztKdlZCgedx79/eUdLXQ7OlPWPhOdjsDuLMCwZ6L4ANmAhXFps9Oc2sqE4PkIjge4TY8AtNr4H5g98hVe/y9Lmbq7oHhCPxqZejDrgM9JAvclE5i6QVtjO4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wW5M5FQbI2JEbOjFtRzhDqx08LEuavkzzBCA1+dCRPU=; b=GGvKlv09bBbeDhMTQ4A9fqGWyzMFmNjk6f6qYBsEYvF5sOQRs//O215k+oAVuoJWCdy+emqZ4OXVRxu+sD3OXMMlsEVKL5Qqhu6dt2EI/xsKswKN06GfblJS1vS58bSbwRrlmAgfeReynv73bz1LUhZBtI9BWil1ZYDPzVRsBMs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <77218c19-0aeb-a0ca-fdb9-072a498542e6@amd.com> Date: Thu, 22 Sep 2022 10:48:54 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 To: "xen-devel@lists.xenproject.org" From: Ayan Kumar Halder Subject: "IOMMU modes of operation" - meeting notes Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0065.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::16) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: 0cb64222-ef54-4154-77e6-08da9c7fabf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2TBGKXXNgNxsFWh03N/jyCMGsBFE++l3EsMYthS5E4aHbSl9tK3GXf5cURzY8uv9SN3PrvrLkvO7/X890x85MKthMLd2BXUUSHmhdO2Oi/idAtyeMiQ9NnykhaxjyH3a9xZyaxQ2uZS21+KA49KJ3X+uid8UYKvv7r1yE4KaItmKY/6B2EWcqQvsKvt2BBhz9k2ZQtHijUmWSm7mc9aJEREpOTa1BX0CiZcj2S5+iezGQ18aeXn/Ro2HQ6wOH3j2EbPTTGj99rbIsK3QvkcgsvcWoAiIVapGrzGP20X7ASUi++sMfFntp9z5KmjGmVUg4VSrJalAX94qM0EqHZZS2hMDYl86ouPoWoqwiMeeRVG5BJt5vCAZE507ODLwKMVVL5AAsXKHoEebdragnB/zdLgC2LPjvwmz3n7Aj4X6Cdde6EXwWFXnbDUjUc+bbZKjjUEHdhVmDMwxaHywKBQ39Qwi3MJg4gTtIJc/PR47DsC1IFu1IMuG1QjF6M6qbmHKHf+Ay0hRKVU9YBe+9oKndx5w/EUGfTgS51XUttsn9TMefjkYaEoagGBCzl9v3AzTK+SRTJalq6XlNEj9xmv9fBwEBgIenDGbtjaPAMIV0uoTdzDf+QM/zUeWJI+N8EgunGvQdfAZMgZ+sPzNTK5qpHAN/sJjaw9zFhz8OtWI5Qq24ObyF6SbsqATFrLGVhQSgoS/Ulr61JUcDnkF9257UyehV4AQ9MZYcWUh+cAsAwzsS7WFFIlE5WhUlXloe9cxDKEHAB5BpeN+1SaQNDRd0gwf+EFtBqc+DkQSTcNFpR6qldq7gwj/Yrr5kQUROyVQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(451199015)(6506007)(316002)(66946007)(66476007)(41300700001)(6916009)(26005)(2616005)(6512007)(6666004)(36756003)(8676002)(66556008)(186003)(2906002)(5660300002)(38100700002)(31696002)(8936002)(31686004)(478600001)(6486002)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmJqUmtYc1N4QnBlMDBBVmpHOGxXWVNsUG15VmRZeElvelRKYTdQU1JCbmRm?= =?utf-8?B?WGtJWlRkSllPR3o5SzF2YnY2UWZCbUtNOThCOXBkbFZRenZHdldETFNsbEVt?= =?utf-8?B?QWIwMVEzMllTV0hlaTB2SWdWQ3NacnAyMkhCcTVPYXFKSExxZWZuNldna1dq?= =?utf-8?B?V3czK201RjhUTGdnQ04vU01OYTBYYWdQVXk3L0w2L0xvZVJvMVdXK1RTeDRD?= =?utf-8?B?bGVzVHBWRWl6cWJjV25oNXZoMHlGZGtCRklVVmxsNGpIZVk2dG9qcGpyWmVD?= =?utf-8?B?VGFWcklyby9ZUXo2Q09LazRhakYreHo5bUlRSENwRnhLN1dUekV3VVZTVUZU?= =?utf-8?B?WHkxRHZGRmQwK2tudGtWd21aM1RiaEFMUjhvMGJMQ3UwdFFVYU9xM2Y5ZmVT?= =?utf-8?B?TjI1cjZSeFl4TWRMTDdMcHUzU2pzUGZKSHl1cGtZclpyd2hOMjF0ZnpIRS9V?= =?utf-8?B?clJHLytxSFpJU0Q3Uzk3Zkh3WkZhME9qaU9CRWIrbVNsdmxpZ0lwV3l1NGRl?= =?utf-8?B?ektvVENVamtEMkJyQ25lWnNwMExkQWt4NFhLL0J1UklkeEFTWmZmVGxNMVpU?= =?utf-8?B?SHRCZkg1YlQwY21BVEdhemhoT3JzZ3ZoWjZlT05HSkREbXBaOVlWdjBja2xE?= =?utf-8?B?bGJlV0RyNGRqemdPMGVEUG5Jd3dTTTRXeGI3N3M3eloraitNTHdPWW54VG9p?= =?utf-8?B?NVloay85enRIQXlQQlJWUmIwVzdneTBSbUJJWkJUWTAzSE1SdUxNTWVBME9G?= =?utf-8?B?Tlh5VWRrTWFnVDh1N1pFZGpONlpSMUdvL0VYbWd1N3dUYVF2d2ZEYmtrdU10?= =?utf-8?B?THg2RDE3V3p6ZDBWRWV3NlRWaC93VG1GY2I4MExpYXE3cElBUDJ6MjgvS0ZD?= =?utf-8?B?ZTlSc241WXB5NllheW9jbk9iaVlRMW0zUmlsU0V2MHBKVmJ4Zmo3ME5HMGs2?= =?utf-8?B?VjZ2T1BNLzVSbnNFNjhyb0ZUNGdkVWl2NVRieThwR1BZZE5VbEZTNUpmcVNk?= =?utf-8?B?SlQzSkpveGJ3UzdoMDl5alZ4NnBPODR2TTdIMmY3S2krR0dCT296UWlOelh5?= =?utf-8?B?TEdRYS9JS2M1YnRsNVk4VzM2SGg2Nm92R202ekFhZTFaQXdseXNWVkxBRWRX?= =?utf-8?B?TmxrRW5SV3E4UDRKZW96dlJjYzI0UDM3M0t6T1NzcVFRd2hEa29NbnBKMDNW?= =?utf-8?B?UVBvdGY5aTJhQk5na3ZUTG9KMkNlY2Nzb2lWTnRJbTRDSTRyeWRFRjdHNTVm?= =?utf-8?B?VnF3ZG9OMHljOU44Qm9QeDlqbHR4M1Z4MldMbWpxOUtOSE5xVVBSdStTTWsv?= =?utf-8?B?TDFZTmFYQ0kvTXlHSjh0a0NuSWNnTlE1WVJMdGpkQ05QNzZYSmxDOUZLVC9m?= =?utf-8?B?TTFId3lrVVlMczFCUEVSOHVkQytZVFFjRG96MmFTQ3gzenIrWjdCQUx3cysr?= =?utf-8?B?Q0VTSHA5eHFJV2FNUjNmNmV6MktLMGRtNGhxdkFZTGtyTmRlRjNaVVIrSit5?= =?utf-8?B?WW9iSWFlVEJMRmdtWitYV1pjUmcvL01oKzdlVDNBcVdvZ3hMNGdkUG4wV0xG?= =?utf-8?B?bXQ4ejNrdlpOL21HS21lUGRybXRQSlFOcDNoVElOMUdSWHEveUZrM2JIa2ha?= =?utf-8?B?azBaNnRpeG9LNmwrdzVtd0pKcmxtSjBTblQrWk1pSlI3VHNoZ2hKTUs4OUhk?= =?utf-8?B?YkxTeG52K1d3YUxkUGl4aHJVM0c0dCtWWG85QzAyS25xL29aYy9HWHp6T0dm?= =?utf-8?B?M2l6VTJNYWNJUkNTYUZaWnBvc1g5NFJ6RjRMS08rUE1TQ3MvUktLMVZvMUJX?= =?utf-8?B?L3hVQkFXZXdTLzBxQXkrM3lzZ1YwcGx4dG05MlZzUStRZmRGYzN5NzZjUExC?= =?utf-8?B?cnJqRldWalBZZ0hxOGRSZDhKc0xKaTVwUHVhb0F5NkRpZ0k1ZVRJQ2ZFM1RI?= =?utf-8?B?UmR5VFQ2eUk0WmdxUmVUdnU3cnRGQWlMUFJUT0dXeEJQbkhVOTg0OUphWG9w?= =?utf-8?B?elVTYkRNMUJpM1VwTlEvMURCZkx0T0szZjZPNVNiU2QrSnltQ3lLajFIOFk0?= =?utf-8?B?dGQzRGx6MWdHT2NjZVNHODBTaXpWTGt3a0dlbytxNnFqenVrZTFzemJENWlh?= =?utf-8?Q?+uQ0m0s+zTu0rXaH2uyiJaCvm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cb64222-ef54-4154-77e6-08da9c7fabf5 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 09:48:58.8616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4DtzWtHFTSy+WTWDddgImUhhQomEoGNYdaVDY+5qAl4sGbSh19FQ5KqWSuXftp7fZ2xF21A3zM8yQFJIhOgcfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 Hi All, PFA the meeting notes as follows. Kind regards, Ayan The way how IOMMU works is not best. Do we change it ? Means people using command line will be impacts. On Inten, IOMMU does dma and interrupt translation. Can it be done independently. For passthrough we need dma translation. IRQ translation can be done different. Disagreement in community. We need to resolve the disagreement in command line option Iommu=off “ in CMD means everything off iommu_remap=off means IRQ remapping off and DMA remapping is on Do we need to an option to do IRQ mapping and not DMA mapping. Bertrand - Is the option applicable to both X86 and Arm applicable ? Jan - Yes, this should impact all architecture. Bertrand - Linux option “”iommu=off” do ? Jan - It varies. Sometime means interrupt remapping is ON. On Arm, IRQ remapping differs from X86. There is no remapping register. Rahul - In Arm, IRQ remapping is done by mapping one door bell register. Then everything is done by hw. Bertrand - This applies to only MSI. Interupt remapping has no meaning on Arm. Jan - In such an environment, this is an x86 specific option that irq remapping is on. Bertrand - The interrupt remapping problem does not exist on Arm. So keep the current option and have the necessary feature for x86. Jan - Split option have no meaning. So IRQ off and DMA off applies only on X86.  The split option (irc remapping) should be unavailable for Arm. Have people using X86 for chasing it ? XXX - iommu = off should switch off everything (DMA + IRQ). Then have specific option. Jan - IRQ on and DMA off is useful. To boot with extra requirement. There is a confusion whether irq remapping is off or dma remapping is off. On passthrough system you don’t need iommu (except for irq remapping). The address space is 1-1 mapping. Intrusive / Extrusive mode. Jan - PV Dom0 case, this is applicable as translation is done Roger - No need to discuss more. Jan - We need to clear of a semantic change when “iommu=off”. We should change variable from iommu_enable to iommu_dma_map and iommu_entry_map. Roger - No need for a separate top level irq remapping. Jan - iommu=dma_remap=off Roger - Global option off and irq option is on. iommu=off will make dma and irc off Iommu=dma_remap=off, irq_remap=on  (We will introduce the split option) Jan - iommu is a top level option with many sub options. IRQ remapping option will not be exposed to Arm. DMA_remap will be used in the everyone. “iommu=enabled” is ambiguous. Bertrand - RISCV is similar to Arm. So this should be x86 specific iommu option. Jan - The common code should explicitly specify dma remapping or irq remapping . The other architecture should say whether dma remapping or irq remapping is apllicable, Bertrand - This change will impact Arm code, Jan - If the severe code changes in Arm, then we will reconsider. Jurgen - Common code should be architecture agnostic. XXX - We could add defines in x86 code. Jurgen/Jan - In common code, we should be very explicit. No ambiguous check anywhere. Bertrand - iommu.c should be renamed to iommu_dma.c ?? Jan - We could do that, there is no bad behaviour when keeping the name. We will prevent irq mapping  is added in common code. However, the common variable should not be ambiguous. Kind regards, Ayan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 10:34:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 10:34:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410069.653057 (Exim 4.92) (envelope-from ) id 1obJWq-0004iT-5B; Thu, 22 Sep 2022 10:34:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410069.653057; Thu, 22 Sep 2022 10:34:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJWq-0004iM-2E; Thu, 22 Sep 2022 10:34:00 +0000 Received: by outflank-mailman (input) for mailman id 410069; Thu, 22 Sep 2022 10:33:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJWo-0004iA-CR; Thu, 22 Sep 2022 10:33:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJWo-00050N-95; Thu, 22 Sep 2022 10:33:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJWn-0005Ew-La; Thu, 22 Sep 2022 10:33:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obJWn-0007qH-LB; Thu, 22 Sep 2022 10:33:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yx3vfVsMXK0/H95OD9u1OHKhQdrrQC16/IxDU1USGb8=; b=s2aJe8hj1Kh/Ja+dZiax5kf5Fe 511ky31m+0blZ8jfhrzEK/dblRy/LVXurXglM80hWJ/xzwUtfzRJ0mNaS9wJkMIJ3tQf4ppqk6tf7 XuJZyPrJvUAGJ67yHyZbwKaB1wnU36AnTbPz9AZBhAV1d3bEKKzOuiMq+vI09wCURN7E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173271: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=dc164f4fb00a0abebdfff132f8bc7291a28f5401 X-Osstest-Versions-That: linux=26c95642d419028db590ae0c511d9ddcdbc51746 From: osstest service owner Date: Thu, 22 Sep 2022 10:33:57 +0000 flight 173271 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173271/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173268 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173268 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173268 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173268 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173268 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173268 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173268 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173268 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173268 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux dc164f4fb00a0abebdfff132f8bc7291a28f5401 baseline version: linux 26c95642d419028db590ae0c511d9ddcdbc51746 Last test of basis 173268 2022-09-21 16:41:22 Z 0 days Testing same since 173271 2022-09-22 00:41:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lamparter David Gow Linus Torvalds Lukas Straub Randy Dunlap # build-tested Richard Weinberger Vincent Whitchurch jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 26c95642d419..dc164f4fb00a dc164f4fb00a0abebdfff132f8bc7291a28f5401 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Sep 22 10:40:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 10:40:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410080.653071 (Exim 4.92) (envelope-from ) id 1obJdP-0006Ke-2U; Thu, 22 Sep 2022 10:40:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410080.653071; Thu, 22 Sep 2022 10:40:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJdO-0006KX-Vy; Thu, 22 Sep 2022 10:40:46 +0000 Received: by outflank-mailman (input) for mailman id 410080; Thu, 22 Sep 2022 10:40:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJdM-0006KN-Uy; Thu, 22 Sep 2022 10:40:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJdM-00058Q-SH; Thu, 22 Sep 2022 10:40:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obJdM-0005O9-EO; Thu, 22 Sep 2022 10:40:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obJdM-0000y1-Dw; Thu, 22 Sep 2022 10:40:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+LzFBxuqmra1NlS3rT+k65GHPjHo3V4HdlyG424D+GY=; b=ghtV7m9fAa1tttXIyRbvsZDFC1 m4Xpb8P0kn8Hw48c0gK9rssi6e4p2vgYnQvyCjGlnyNHQgboamNStk306rUI5JB2cXO58CBbVdh4R LtSxiGOApWYTfBvwzULK5YYYcWwxVNayI/yreAemuntBBzjDygVzQkJWEZi1j6PprqO8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173273: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Thu, 22 Sep 2022 10:40:44 +0000 flight 173273 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173273/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 173264 Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 7 xen-install fail in 173264 pass in 173273 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 173264 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173264 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173264 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173264 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 173264 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173264 never pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail like 173258 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173264 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173264 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173264 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173264 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173264 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173264 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173264 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173264 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173264 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173264 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173264 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173264 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173273 2022-09-22 01:54:09 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Sep 22 11:47:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 11:47:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410088.653082 (Exim 4.92) (envelope-from ) id 1obKfT-0004ot-W4; Thu, 22 Sep 2022 11:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410088.653082; Thu, 22 Sep 2022 11:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obKfT-0004om-SW; Thu, 22 Sep 2022 11:46:59 +0000 Received: by outflank-mailman (input) for mailman id 410088; Thu, 22 Sep 2022 11:46:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obKfS-0004of-9N for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 11:46:58 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 379ac922-3a6c-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 13:46:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0B9373200914 for ; Thu, 22 Sep 2022 07:46:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 22 Sep 2022 07:46:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 22 Sep 2022 07:46:49 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 379ac922-3a6c-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1663847210; x=1663933610; bh=UdQjItpIHW lMSVdHdQtLelbMYvWZwKKLdVGjygAUq4s=; b=gk52S+0pPNB2o3A8PHPT3JLwLV FbWCBxWHC1Xp06jay4BjxKWUeg0bnRt2Xtd8s/0AtIIaehRViFSMjOg/C+K2So6a 1JjMzO+v8F2k16Ro2+GK7nCSVZqze8w+IwTiO0UbcinozMMPovLgixFlBWacKWQ6 cdHlmLqqzsT2/gmfc7fDQyDfeHRrKsNVo3zvFjAjRkQiY1pXYBGWtpsZDlYwfM0M EH+/ErsjYZ2F7T+Vp9FjpAsrMiMQC+fsl0Xcu5Iu2fo3DVJukC92m9Iwv0qPmtZS a+YpKMhvq18+6G+aDye7DEGXDN0RZsmgIdzSWPv4Sk57kCwlNJMUy7iVVVAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663847210; x= 1663933610; bh=UdQjItpIHWlMSVdHdQtLelbMYvWZwKKLdVGjygAUq4s=; b=1 pLltwLMB8KMSg//P5HywmeGMNJzQVUCe1+nZPjj/BHEOz78nmzgwcoRrtB5jKCAR 9M1hqvVT9WfFrRzYI+/UYyf4Palr1d831vD3Uua3G7u0ahKJMCML/VGf80BGnzE5 xYWishAlyh7E8/GawNSVoilvc+JsT6Ks4FMJQe8lWSuPy4RaKEQvtvhvY6AMZwR7 gjl6iPJmhnbAANCNmVCtXiF5Y14PMCcMFjdO7mRrsaOdsZfCufws8oSuu0/Sh9hY oPqsSkYKgaAnXf8efPQP4GxgPamBdZQIr3XEXvuIn/7LigjBQkD4Padz/CvlFuYo /tKkVUvP71+d1oA03Xe9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeffedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnheptddugfetudevudeiveevgfetueejlefggffghffhhfehtdff feefgfduueegfefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 22 Sep 2022 13:46:45 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session "AMD SEV" Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QYwk5ZkAjPM1TjwK" Content-Disposition: inline --QYwk5ZkAjPM1TjwK Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Sep 2022 13:46:45 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session "AMD SEV" Notes from the session: Andrei: is there ongoing work? J=C3=BCrgen: similar to Intel TDX Andrei: guest memory encrypted, unavailable to the hypervisor; useful in cl= oud market; some similar feature on ARM too there was a session in April(?); possibly some funds will be availa= ble; several related features, can be done in stages; Andrew: first step: run XTF as minimal guest, PoC; then PVH guest Andrei: implemented by AMD PSP (pltform security processor), visible as sep= arate PCI device; run the driver inside Xen hypervisor; QEMU already supports it, but cannot be reused in Xen there will be impact for Xen ABI, like passing hypercall parameters maybe possible to share effort with other architectures (ARM, Intel= TDX) George: using physical addresses in hypercalls might be a good idea anyway,= but the change is painful start with policy for new hypercalls only Jan: flag at hypercall entry if physical or virtual addresses (bit in hy= percall number?) alternatively, mark buffer addresses in some high bit J=C3=BCrgen: when adding SEV on Xen to Linux, it automatically will be supp= orted for non-SEV too Jan: may be easier for hypercall callers to switch not all at once; for = example /dev/xen/privcmd may be harder J=C3=BCrgen: can dom0 run as SEV? Andrei: in principle yes, at some point; can also encrypt hypervisor memory Jan: dmop is a way to avoid privcmd with virtual addresses J=C3=BCrgen: PVH dom0 wants physical addresses anyway grant tables needs to set unencrypted bit; alternatively bounce buf= fers (KVM way?) virtio may be easier, as KVM already supports SEV (with qemu-based = backends) Marek: how to share PSP between Xen and dom0? Jan: interface coordinated by Xen Andrei: we ask community to help the efforts George: create epic, with specific tasks, some are shared with other goals some may be delegated to GSoc or similar efforts Roger: minimal PSP driver in Xen can be tested without rest of SEV support Jan: ^ especially when dom0 needs to access the interface anyway J=C3=BCrgen: coordinate Linux work with me incremental work, starting with design review George: does anybody work on physical addresses in hypercalls? J=C3=BCrgen: there was a design session about that before Jan: design in some people's heads J=C3=BCrgen: will look how hard it would be to switch all at once per domai= n; uuuh, it could be hard, because domain may boot via grub George: lets write down those concerns --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --QYwk5ZkAjPM1TjwK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMsSyYACgkQ24/THMrX 1yxarAgAgHG373W9pzggohn/xOUoEV/UAht6ldC1AQk7DMiJalQ5tyOcT1rFDGen bv1k6ulUGS/fSdmRho/Udw2ZZ/k17rsH/ZuO/zBUzLUWGcXxDuQMO9HTzHq+54h9 YI+3KqjRgpqhH34jbD4oPIzdo0jswMO0PcmT1SuuhEvun0TzuztkexmgaNB7gggJ fFR4H2VSYXtmZNLkdgRLr9dxtEfEc/BeZxuAIDnohFxanWiO3foMNKpx4H8IMHh9 Qz5nEqS7fFciwJWuMM10RlgXobkXfEHJpIZZSBbu7MrS69ywHs+T/MCnyh+66FMs eAxkyH/JkRtfuNLVsou9k8CXAX50/A== =ac5k -----END PGP SIGNATURE----- --QYwk5ZkAjPM1TjwK-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 12:05:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 12:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410096.653093 (Exim 4.92) (envelope-from ) id 1obKwp-0007YT-Um; Thu, 22 Sep 2022 12:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410096.653093; Thu, 22 Sep 2022 12:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obKwp-0007YM-QP; Thu, 22 Sep 2022 12:04:55 +0000 Received: by outflank-mailman (input) for mailman id 410096; Thu, 22 Sep 2022 11:55:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obKnU-0006Qt-Ck for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 11:55:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a3ea137-3a6d-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 13:55:14 +0200 (CEST) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Sep 2022 07:55:11 -0400 Received: from DM6PR03MB4138.namprd03.prod.outlook.com (2603:10b6:5:58::12) by SJ0PR03MB6439.namprd03.prod.outlook.com (2603:10b6:a03:38d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 11:55:07 +0000 Received: from DM6PR03MB4138.namprd03.prod.outlook.com ([fe80::653a:87b4:8096:8bf]) by DM6PR03MB4138.namprd03.prod.outlook.com ([fe80::653a:87b4:8096:8bf%7]) with mapi id 15.20.5654.014; Thu, 22 Sep 2022 11:55:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a3ea137-3a6d-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663847714; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=0yB3CWTwn7miff6WKQfg4NNooeTmqdpZdK27Pwgqt2w=; b=SEIz+pdUq9HEgKwU+dfl1Rfb/Ihq/akcxOl047/tCDTdGUWu0okSwxYz 656G0grg1C85b15aKgkWugURjRCxoszys5PmV5fan2503YiHCnAYOwMBq pGKzhK/9wISzF/Er88cBIYoccnDK5KSl5Wa0On0fRnUotbDOW1ZiZYbnc 4=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 80247868 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mB0bPqCZt/mahRVW/1Xiw5YqxClBgxIJ4kV8jS/XYbTApDlw3zBVy WoZCjiOb//bMWv0fohxOY22/E5VvZODmoQwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFsfjb8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW3rxhNdNPkoXBqwzy9kuIVlv9 MMaOAlYO3hvh8ruqF66Ys9Fo516aeXOYsYYsHwmyizFB/E7R5yFW7/N+dJTwDY3gIZJAOraY M0aLzFoaXwsYTUWYgtRVM14wbju3yevG9FbgAv9Sa4f+2HOihd43r/rLPLee8CQRNUTlUGdz o7D1zShWE1FZILPodaD2kqp1+/FnR3/ZIwTFe210aR13FKS3EVGXXX6UnP++5FVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe9DW8ymIw6vQpgqcWG4NS2cYbMR87ZFmAzs3y lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs5jEpMVkcG wy3kRU= IronPort-HdrOrdr: A9a23:B1FPlKCNhN2Cd03lHegcsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+VAssOlJo6HJBEDyewKkyXcT2/hbAV7CZniuhILMFu1fBOTZslnd8kHFl9K1tp 0QOZSWaueAamSS5PySiGbXLz9K+qjlzEncv5a6854bd3AJV0gP1WdEIzfeNnczaBhNBJI/Gp bZzNFAvSCcdXMeadn+LmUZXsDYzue72K7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFqQrk/a+u2svLhSM0llWjoai+quGRiuerN/b8yfT97Q+cyDpAUb4RGoFqegpF5d1Hpmxa1O Uk6C1QR/ibo0mhBV1d5yGdljUImQxelkMLgzWj8AHeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfGf9dQnGlqr1vitR5z+JiGtnlfRWg21UUIMYZrMUpYsD/FlNGJNFGC7h8ogoHO RnEcmZvZ9tACWnRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39F/pMgTJtP4f jCL81T5cZzZ95Tabg4CPYKQMOxBGCISRXQMHiKKVCiD60DM2Klke+F3Fz03pDbRHUl9upNpH 2aaiIliYcbQTOQNeSemJtW7xvKXGKxGTzw18A23ekJhoHB X-IronPort-AV: E=Sophos;i="5.93,335,1654574400"; d="scan'208";a="80247868" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfV2+422gCjp1eiZnJMB35amlqGaMZ+KmtV2rPG03rhfLDaJ6CmN/ZvpxSUbj08tsXX4VrgGGck54HHdGMyAkKw80xFkoF1UPU6bgcPtwHlL/RWnHLpvf4GKyu9x6QWEpUZf1BYv6OwS4LwxU2f0M4eKdKpkD5w8hM13vW75ckVJfj9QNsUG2qFTWq2ynzY1BGE1Pe6/e30b3Mwjb2E1eDwu33j3Lkjq389slcdW192MS27loXFmpPU6r/QHLEIHccXwWgncwrb+L6/rSa3IIXP7BlLVrHJqU7CIw+3Kcm2V8XQ8Zv7Zsi0iwIcDKYdIUA5bLZg2Qis4HORpLJarIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0yB3CWTwn7miff6WKQfg4NNooeTmqdpZdK27Pwgqt2w=; b=bsrLlsI5jZ8AUaG+UcXTqErfz+6DYgwAUHUbEZW+q53a/+qVuQOrcuDZI6l6+kaNTY02PrRz2+4EZdO5XOJvwhMw58VxSIOieT22CuKJhIFaO7X37vXiSqleyPKR6hmUd8T76y2H28AevQsnNO9bfhQ0dXr7F5RnA8S9zYbdHRaC8m78Qiggqc4emBlwhTddxtKHet7BpL7KNOMs3qXyxXurIbfNJ+qrxAzUgxecpuWepKNc5UC8JXY6+MtVDTJ5duB7SCysHzDFKEJsqf1J4rMXKLTR9xuzaLdKB4uJIvpbOfeZr0rBi1miyg41VU7maH5vbmgu18elq9V/hCFhTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yB3CWTwn7miff6WKQfg4NNooeTmqdpZdK27Pwgqt2w=; b=kztstzL6OrdCjY5+fcR0oCpS9ycHwEiOFYfjctvciQyR8fpJFZhwrQ5G0GA8wbi67Ic8X5yHTdFB3Jh381J6zAijOvVV7ykzJrZ2C6nTsNeuY+v/tvt8FRodqVwoA7qxtJLE+3/5QpXk1LsmYbpWwTGtAwnwS4LRhrCoAWqq0AI= From: Pau Ruiz Safont To: "xen-devel@lists.xenproject.org" , =?utf-8?B?WGlodWFuIFlhbmcg77yI5p2o5Zac5qyi77yJ?= , =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , Edwin Torok , "\"samuel.verschelde@vates.ft yann.dirson\"@vates.fr" <"samuel.verschelde@vates.ft yann.dirson"@vates.fr>, Anthony Perard Subject: Notes about "A common codebase for guest utilities, defined and shared with Xen downstreams" Thread-Topic: Notes about "A common codebase for guest utilities, defined and shared with Xen downstreams" Thread-Index: AQHYznooUVfpDzfZVEOAf1uhZf8yng== Date: Thu, 22 Sep 2022 11:55:07 +0000 Message-ID: <067a94bc-b167-02c1-c654-27f2903f42c4@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4138:EE_|SJ0PR03MB6439:EE_ x-ms-office365-filtering-correlation-id: d9e96b66-8f11-4a06-bcf4-08da9c914b37 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8kIRhzj0Tm/icoD5Dg/rew+sEdO6rTqbXBasZdTO/33k4c5SDT70IDkPUvDnq54FEdckTRrUPlslCCUrpbsMjWx4MnZbUrnav+y78Y3vPl4HJLNuQelgaWylFNXEi0FzWu6RsQJwkNnanOwxYnPB9y6S35lKycpE/DYgFJcLnaZXqEp/nL3SdtXnH4lQirPtmIqnQAZhA8X603uS5hyo5GwubIjaqBbumCZIeYB/W8hvI3pHWjcoDKfcOkpYhol286oYTfsHlYl0XeVWyUSUog347waTq1Q/Znr6Bipvu0ZIFS0ipYHu2/J784FqTtKABfb/qT8LGUqY0NNxECdJYUmjmFjBl5QuzrnuDFIcf86rcNKqx2k8kVtZiUpNhHsoHdlpJ4RndnS3f+VloaVkcqX9YlvelX6F+BwlJj92FGT98hgrZCWDZAoVm6LbIPJziDu8yHjXDQusErumedI9n3wKmh5180Q6b9KQryRl8Y6nx8eKX3EF9dso+CAHGH4lsnttplb66Z/kwQDFt+MgblGOnc/XlIzTVoQfikFYLbBnwp2KMrK1QEIdJxAO8KeQwMehKQ9QriCWGAVFEhtTmBtTpletfNzWlqmSKcXovAQ8sQobIVs+V8jmlKTOzPRbehz5JuRwH/okM+bogI3wPTK28mbfoMn/mPFfGBo6zS9RnmwOO5u08YAsgzmcg7q4+PD+YcwK8ySswCjyeBJzprea265E4ziKkIUCEYLKhvuTI1y3heOm6FYDIolCUKOKxtJEC0N9xtAv1UvjlaSaQWfuGmW/+PnUTPoQfSF0SQyes76ugghoUyS8Cnph/vayoYeRFcJYOmxhsJl/1QbHYKmRfl/o5Naqyc4n2m/Sp4M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4138.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(451199015)(8936002)(71200400001)(91956017)(76116006)(66946007)(6636002)(64756008)(66556008)(66446008)(66476007)(5660300002)(186003)(2906002)(110136005)(6512007)(26005)(2616005)(83380400001)(316002)(31696002)(8676002)(36756003)(86362001)(6506007)(478600001)(122000001)(38100700002)(966005)(38070700005)(6486002)(41300700001)(31686004)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QnVxUEtFY2dIdElGNmhWV3JiYTQ2WlVGblRuek40TzRmVmxFajFOU0FZKzI2?= =?utf-8?B?ZTQrb1oyVnk4VzVyb3RkOGczUFJJUnZTTW5LZDRtSzBuNFgxZjhVY0VucHZn?= =?utf-8?B?UEcyTG41N0RZTUVPMkNLaUV0OG1yQ3FEV2E2ZTJmK3cxQmFGT1NwMFg2cWdV?= =?utf-8?B?UkpOY2lIWlVpRnkyZGdtc3lEOE12L1JzQ2I2TEtudVgzM0dHNjhIQXBOdWR0?= =?utf-8?B?TVV6dnhmQndidGp3bTVacUozMm9iOU5JN2txeERzV0c1NzJkS0dQZE0zNXVw?= =?utf-8?B?dzBkaTJpY1Z1L044OFNMeDZZR0MxWC85WEh2MUo4UWVja2ZtakQ5dTZ1cUhV?= =?utf-8?B?andycGxzVEZWL2lDUW5SMkl1T3BKcklRTjlaRE84Z1d6Y3BwS2Z2MStmNVhO?= =?utf-8?B?a3J3S1FqS3JJMkkrTFF2cjNsT24vRmlLKzJxV0xuRHB1V1JQTkpHYVF3cG5a?= =?utf-8?B?RzIyME1wc1dsK3BmeHBBTDJyRUZ3cWNMcnhzMHh1QTd4U0x3Q2FDaHk3Vk04?= =?utf-8?B?QWVZRXBXcFA2U2JYS1dQc1ZmVGMxK1BWNFU4RkVrdWFrMkYvR2JuZ2t6OWQy?= =?utf-8?B?MWZURWlmVnpNYVJKaktuaVVDbjR2MTRJYVh6M0lkbGlxVjZBNFB0SkQ2VjRQ?= =?utf-8?B?ZGloenFWcU9IOVdRM084RFB3U0M1ekViQ3ZWTFNxa3dtLzNjT0d1alUyTGM3?= =?utf-8?B?ZXZJOVhJYTlCQ0MxTWRNb3VHOVZ3dENXakNEYVBEbmRTSHEvS201emM1cUhC?= =?utf-8?B?RUFVcExBZEFGQnFMVjE0cCsxc3VuVE5ZOHJzcTJTazBqR2RlNEE0ZHQ4OHlq?= =?utf-8?B?S0h5ZjI0anNRc2JaOE5leEdwaXY1Sis5eFU1My95cGdPVjdGNC91NXVEVTcy?= =?utf-8?B?YVJWY3RLUkltcnEwT05BdUI3emVjaVBaQTFncjBXZWtTZTdvb1pQUXJTQTNv?= =?utf-8?B?TG5TaTYrTUxBbzdMWHhzUEhJaWRIOVZUTysrVTBFNzdpNzJIU3k5MkxOaVJl?= =?utf-8?B?RVprdFdneUlkZVlmc3J5UzVaSmxrUmpJOUVEWW9GZ1BzODZuWThZNE1XWStu?= =?utf-8?B?VXJRUnpmOXp3d2ZraDIvNTNZb0Z6QlA0VjB5bzlObkgrZEtwWDBLTTRWUTEw?= =?utf-8?B?dkZvWXNlTkRkMlRYNm02V0s3Ri9CV2tBUDJ2NktmN3VBL0hXTTkyNVUzM2po?= =?utf-8?B?eEFsTGRHbEFkSG5uTUVXZEp4T2JBTUtFN1d3Sjk0cU9FaFkwR3NQV2phbGx5?= =?utf-8?B?b0MxY0FnODdOTE9yY3prRzM5ZGp1Nk5UajBZT1VSRHIzeGN3L3VaVk5heGYz?= =?utf-8?B?SVp3US80UVErcGZ0YmJaNTFFMmk2MG1DQVIzSHd6SVh5YkxhQ1JNVlh0UmxV?= =?utf-8?B?WEU0MVg1dDMyMDE2c0Z5S1g3ei9kSFNVcHIxSUt6L1J0dDZmS0sxYTVDMkVD?= =?utf-8?B?NzVWdnEyR3dYWVVaOHMxTU00T09hZG84Y1dOUlhFWXEyUHhmSUVPamp2eDdn?= =?utf-8?B?b3JWQmtUK2JpeVVsTytYaitzVFMzMHVOSlV0NVNUODIyait5eEJnUDk3MVo2?= =?utf-8?B?Zk01RlJnUXVWQnFXMk16NFBFUHNWWGlYK1dIMGRVQkZNbUN5TWR3OXkxN3RJ?= =?utf-8?B?eUJtNzJDSkpTeGtyMWQxb3JuL1BnZkNMV3FKb05DTzB4eEVJRDdvcnZWMUha?= =?utf-8?B?NEZ1TlZ3YTRTeUJoYUxhUGpNdTRVTWJxTFZNNXhQQi9GV3BpanFCU2ZGclNv?= =?utf-8?B?RDZmZk9OeWtMY1ZVc21qTTJWOWhreEszd1htZTlPTmQrQXViL21HemhIeWZo?= =?utf-8?B?MGpRZDVNNFJyK1p6TmJ1dUZYV2xIVGtCeGx3Z0JWbFFxOVZaTmYwcTFldU5J?= =?utf-8?B?cmRzTndYQ1pDRmZsbWhQeTZvRDhWTENMNUsrMDZHa1lrYTVNM05rWUg0Mm1B?= =?utf-8?B?OStZRTFWWHlYbFM1d2NoME0rSTNIWGl2c2YrUHoyTUVacjhmSmQrOEpWSDBC?= =?utf-8?B?ZGd4Y3RzclByeUdwSElYcC8xN2krUjE5YUZPWk1udmdsM1FoME9tRVJ4NlVh?= =?utf-8?B?WTZzNUNJQ0ZwZGJQbTdzaU1RQk9FVng1alJBYmJ0TkpQS0ZWRExNdUl3SWRu?= =?utf-8?Q?42Y4DDHbQWgo3Qc1jWClotr7N?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4138.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9e96b66-8f11-4a06-bcf4-08da9c914b37 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 11:55:07.2012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lz2K9QZVGduHIAuaTlhLCGAn5dqmQRnwxjAkYFmsw06F+wbYM9/Jb/3IyzlLzJNyvBb0yl7+kyhKd3oJeoKnhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6439 c2E6IFNhbXVlbA0KZWQ6IEVkd2luDQp4aTogWGlodWFuDQphbjogQW50aG9ueQ0KeWE6IFlhbm4N CnBhOiBQYXUNCg0KDQpzYTogYWdlbnQgcnVubmluZyBpbiBhIHZtIGNvbW11bmljYXRpb24gd2l0 aCB0aGUgaG9zdCB2aWEgeGVuc3RvcmUsIA0KdGhlcmUncyBubyBjb21tb24gY29kZSBiZXR3ZWVu IHZlbmRvcnMuDQpsaW51eCB2ZW5kb3JzIGRvIG5vdCBrbm93IHdoYXQgdmVyc2lvbiB0byBwYWNr YWdlLg0KDQp3ZSB0ZWxsIGN1c3RvbWVycyB0byBkb3dubG9hZCB0aGUgY2l0cml4IHRvb2xzLg0K DQpjdXJyZW50IGltcGxlbWVudGF0aW9uIGluIGdvDQoNCkZyZWVic2QgZGlkbid0IHBhY2thZ2Ug dGhlbQ0KDQplZDogd2hhdCdzIHRoZSBtaW5pbWFsIGZlYXR1cmVzIHRoYXQgYXJlIG5lZWRlZD8g QW5kIHdoYXQgYXJlIHRoZSBhZGRlZCANCmZlYXR1cmVzIHRoYXQgYXJlIG5lZWRlZD8NCg0KeWE6 IHN1c3BlbmQgcmVzdW1lIGhhbmRsZWQgYnkgdGhlIGd1ZXN0IGtlcm5lbA0KDQpxdWJlcyBoYXZl IHRoZWlyIG93biBpbmZyYXN0cnVjdHVyZQ0KDQpzYTogdGhlcmUncyBhbiBlbXB0eSBnaXQgcmVw byBsaXN0aW5nIGZlYXR1cmVzIGluIA0KaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3hl bi1ndWVzdC1hZ2VudA0KVGhlcmUgYXJlIGRpZmZlcmVuY2VzIGJldHdlZW4gdGhlIG1ldHJpY3Mg aW4gcXViZXMgYW5kIHhlbnNlcnZlcg0KDQp5YTogaW5zdGVhZCBvZiBwdXNoaW5nIGluZm9ybWF0 aW9uLCBvbmx5IHB1Ymxpc2ggdGhlIGluZm8gdG8geGVuc3RvcmUgb24gDQpkZW1hbmQuDQoNCkRp ZmZlcmVudCBhZ2VudHMgcmVwb3J0IHRoZSBtZW1vcnkgc3RhdHMgaW4gZGlmZmVyZW50IHhlbnN0 b3JlIGxvY2F0aW9ucw0KDQplZDogYWZ0ZXIgcmVzdW1pbmcsIHRoZSBndWVzdCBhZ2VudCByZWZy ZXNoZXMgeGVuc3RvcmUga2V5cywgY291bGQgYmUgDQpkb25lIGJ5IHVkZXYNCg0KeWE6IGdvIGFn ZW50IGRvbid0IGRvIGl0LCBtYXliZSBrZXJuZWwgZHJpdmVycyBkbw0KDQplZDogdGhlcmUncyBh IGNvbW1pdCBmcm9tIDIwMTYgZml4aW5nIGl0DQoNCmN1cnJlbnRseSB3ZSBoYXZlIHRvIHN1cHBv cnQgY3VycmVudCBwcm90b2NvbCwgYW5kIHRoZSBjdXJyZW50IHByb3RvY29sLg0KDQpTaWduYWwg dGhyb3VnaCB4ZW5zdG9yZSwgdXNlIGEgbmV3IGludGVyZmFjZSBpbnN0ZWFkLiBUaGUgbmV3IGlu dGVyZmFjZSANCndhcyBwcm9wb3NlZCB5ZWFycyBhZ28sIHRvIGV4cG9zZSBtZXRyaWNzIGZyb20g dGhlIGd1ZXN0cywgZGlkIGl0IGdldCANCmltcGxlbWVudGVkPw0KDQp5YTogYSBtb3JlIGVmZmlj aWVudCB4ZW5zdG9yZT8NCg0KZWQ6IGlzIGl0IGV2ZW4gdGhlIGNvcnJlY3QgaW50ZXJmYWNlPyBi dXQgdGhlcmUgYXJlIHRvbyBtYW55IGd1ZXN0cyANCnVzaW5nIGl0IHRvIHJlbW92ZSBpdC4NCg0K c2E6IG1heWJlIGd1ZXN0cyBjb3VsZCByZWx5IG9uIHhlbnN0b3JlJ3MgcGFja2FnZSBmcm9tIHRo ZSBkaXN0cmlidXRpb24/DQoNCmVkOiB0aGUgYWdlbnQgcHJvYmFibHkgbmVlZCByb290IGFjY2Vz cywgY3VycmVudGx5IGdvIGFnZW50IHJlaW1wbGVtZW50cyANCnhlbnN0b3JlLCBidXQgaXQncyBp bmNvbXBhdGlibGUgd2l0aCBkaXN0cm8ncyBwYWNrYWdlDQoNCmlmIHRoZXJlJ3MgYWxyZWFkeSBh IHhlbnN0b3JlIGxpYnJhcnkgYXZhaWxhYmxlLCB0aGUgYWdlbnQgc2hvdWxkIGp1c3QgDQp1c2Ug dGhhdA0KDQpzYTogdGhlIGluaXRpYWwgY29yZW9zIGlzc3VlcyBtYXkgbm90IHN0aWxsIGhvbGQs IHRoZXJlJ3Mgbm93IGZlZG9yYSBjb3Jlb3MNCg0KUG9DIHdhcyB0YXNrZWQgdG8gWWFubiB0byBn ZmV0Y2ggdGhlIElQIGFkZHJlc3MgYW5kIG90aGVyIGVhc3kgbWV0cmljcywgDQp3ZSB3aWxsIHNo YXJlIG9uY2Ugd2UgaGF2ZSBhIG1pbmltYWwgc2V0IG9mIGZlYXR1cmUgdG8gZ2F0aGVyIGZlZWRi YWNrLg0KDQplZDogYXJlIHlvdSB1c2luZyB0aGUgZGlzdHJvIHBhY2thZ2VzIGZvciB4ZW5zdG9y ZT8NCg0Kc2E6IGlmIGl0J3MgYXZhaWxhYmxlIHllcywgYW5kIG90aGVyd2lzZSB3ZSBtYWtlIHRo ZSBwYWNrYWdlIG91cnNlbGZ2ZXMuIA0KT24gZ2l0bGFiIHdlIHdvbid0IGluY2x1ZGUgdGhpcyBw YWNrYWdlcywgb25seSB0aGUgYWdlbnQgY29kZS4NCg0KZWQ6IHRoZSBvbmUgaW5zdGFsbGVkIGlu IGRvbTAgaGFzIGRpZmZlcmVudCBwYXJhbWV0ZXJzIGZyb20gdGhlIG9uZXMgaW4gDQp0aGUgZ3Vl c3RzLCBpdCdzIHByb2JhYmx5IG5vdCBpbnRlbnRpb25hbA0KDQpzYTogd2UnbGwgbWFrZSB0aGVt IGNvbXBhdGlibGUgd2l0aCB0aGUgdXBzdHJlYW0gcHJvdmlkZWQNCg0Kd2h5IGNyZWF0ZSBhIG5l dyBwcm9qZWN0PyBkbyBub3QgZGVwZW5kIG9uIHhlbnNlcnZlciwgYnV0IGJlIGluIHhlbiBzbyAN CmRpc3RybyBwYWNrYWdlcnMga25vdyB0byB0YWtlIHRoYXQgY29kZSB0byBidWlsZCBwYWNrYWdl cy4gV2UgbXVzdCByZWFjaCANCnF1YmVzIHRvIGZvbGxvdyB0aGlzLCBhcyB3ZWxsIGFzIEFtYXpv biwgbWF5YmUgb3RoZXIgZG93bnN0cmVhbXM/DQoNCnJlYWRpbmcgL2V0Yy9yZWxlYXNlIHdhcyBt YWpvciBpbXByb3ZlbWVudCB0aGF0IHVzZXJzIGNvbnRyaWJ1dGVkLCBiYXNlZCANCm9uIGEgZGVz aWduIHdlIHdyb3RlDQoNCmRpc3RybyBkZXRlY3Rpb24gdG9vbCBjYW4gbWFzc2l2ZWx5IHNpbXBs aWZ5DQoNCmVkOiB3aGF0IGFib3V0IGJzZD8gaXMgdGhlcmUgYW55IGludGVyZXN0Pw0KDQpzYTog d2UgZG9uJ3QgcHJvdmlkZSBwYWNrYWdlIHRoYXQgY2FuIGJlIGluc3RhbGxlZCwgaW5zdGVhZCBp dCB3aWxsIA0KZmV0Y2ggdXNlci1jb250cmlidXRlZCByZXBvcyB0aGF0IGhhdmUgYW4gb2xkIHZl cnNpb24gdGhhdCB3b3Jrcw0KDQplZDogYXZvaWRpbmcgbGludXgtc3BlY2lmaWMgZGVwZW5kZW5j aWVzIHdvdWxkIGJlIGdvb2QuDQoNCnhpOiB0aGUgcmVwbyBpcyBlbXB0eQ0KDQpzYTogdGhlIHJl cG8gd2lsbCBiZSBlbXB0eSB1bnRpbCB3ZSBoYXZlIGEgcHJvb2Ygb2YgY29uY2VwdCB2YXRlcyBj YW4gc2hhcmUNCg0KZWQ6IGRvZXMgdGhpcyBuZWVkIHRvIGJlIGFuIHJwbT8gQSBsb3Qgb2YgY29t cGxleGl0eSBpbiBDaXRyaXggaXMgaW4gdGhlIA0KcGlwZWxpbmUNCg0Kc2E6IGl0IG1heSBiZSBh IG5vYXJjaCBycG0sIHdpdGhvdXQgYnVpbGRpbmcgYW55dGhpbmcNCg0KZWQ6IGlmIHRoZSBycG1z IG5lZWQgdG8gYmUgYnVpbGQgZm9yIGd1ZXN0IGlzIHZlcnkgY29tcGxleA0KDQpzYTogaG93IHRv IHByb3ZpZGUgcGFja2FnZXMgZm9yIGRpc3Ryb3MgdGhhdCBkb24ndCBwcm92aWRlIHRoZW0uIElu IG91ciANCmJidWlsZCBzeXN0ZW0gdGhlcmUncyBibGFjayBtYWdpYy4gSW4ga29qaSB0aGUgZ28g cHJvZ3JhbSBpcyBkb25lLCB0aGVuIA0KYnVpbGQgdGhlIHJwbSBhbmQgdGFyLmd6IGlzIGJ1aWx0 LCBiZWNhdXNlIGl0J3Mgc3RhdGljYWxseSBsaW5rZWQNCg0KZWQ6IHdpdGhvdXQgYmluYXJpZXMg d291bGQgYmUgZXZlbiBzaW1wbGVyDQoNCnlhOiBkZXBlbmRpbmcgb24gZGlzdHJvIHRoZSBjb25m aWcgZmlsZXMgYXJlIG9uIGRpZmZlcmVudCBwbGFjZXMNCg0Kc2E6IGxvY2F0aW9uIHNob3VsZCBi ZSBkZWZpbmVkIGluIHRoZSBwYWNrYWdlIG1ldGFkYXRhLCBub3QgaW4gdGhlIHVzZXIgDQpyZXBv IGJ1aWxkDQp1cHN0cmVhbSBkaXN0cm9zIHNob3VsZCBidWlsZCBtb3N0IG9mIHRoZSBwYWNrYWdl cw0KDQp3ZSBidWlsZCBvbmx5IGZvciBzb21lIGRpc3RyaWJ1dGlvbnMgd2hpY2ggZG9uJ3QgcmVs ZWFzZSB0aGUgdXAtdG8tZGF0ZSANCmd1ZXN0IHV0aWxzDQoNCndlIG9mZmVyIHVzZXJzIGluIG91 ciB3ZWJwYWdlIHRoZSBvcHRpb24gdG8gcGljaw0KDQpwYTogd2hhdCBsYW5ndWFnZSBpcyB0aGUg UG9DPw0KDQp5YTogd2UgaGF2ZW4ndCBzdGFydGVkIQ0KDQpzYTogd2UncmUgdHJ5aW5nIHRvIHVz ZSB3aXRob3V0IGFueSBsYW5ndWFnZXMsIHVzaW5nIHVkZXYuIFdlIGhhdmVuJ3QgDQpkaXNjdXNz ZWQgd2hhdCBsYW5ndWFnZSB3b3VsZCBiZSBhcHByb3ByaWF0ZQ0KRm9yIGxpbnV4IGl0IHNob3Vs ZCBiZSB2ZXJ5IHNpbXBsZSB0byBidWlsZA0KU3RhdGljIGxpbmtpbmcgaXMgdmVyeSBjb252ZW5p ZW50IGZvciB2YXRlcw0KDQpwYTogdGhlcmUncyBhbiBvY2FtbCBwcm9qZWN0IHVzaW5nIGNvc21v cG9saXRhbiBsaWJjIGFsbG93cyB0byBydW4gDQpzdGF0aWMgYmluYXJpZXMgb24gd2luZG93cywg bGludXggYW5kIGZyZWVic2QNCg0KeWE6IHNlZW1zIHZlcnkgc3BlY2lmaWMsIHJ1bnMgcmlzayBv ZiBub3QgYmVpbmcgYWNjZXB0ZWQsIGl0IHNob3VsZCBiZSANCnNpbXBsZSB0byBjb2RlDQoNCmFu OiBjb21wYXRpYmlsaXR5IGluIHB5dGhvbiBpcyBub3QgZ29vZA0KDQpzYTogbm90IGFsbCBkaXN0 cm9zIHdpbGwgaGF2ZSBweXRob24NCg0KZWQ6IG1heWJlIGEga2VybmVsIGRyaXZlcj8NCg0KcGE6 IGl0J3MgbGludXgtc3BlY2lmaWMsIHRob3VnaA0KDQplZDogd2hhdCBkbyBvdGhlciBoeXBlcnZp c29yIGRvPyBrdm0gYWdlbnRzPyBxZW11IGFnZW50Pw0KDQphbjogbmV2ZXIgc2VlbiBhIHFlbXUg YWdlbnQNCg0KeWE6IHRoZXJlJ3MgYSBoZWxwZXIgZm9yIGJldHRlciBtb3VzZSBpbnRlcmFjdGlv biB0aHJvdWdoIHFlbXUNCg0KZWQ6IHdoYXQgbGFuZ3VhZ2UsIGhvdyBhcmUgdGhleSBkaXN0cmli dXRlZD8NCg0KYW46IG1heWJlIHRoZSBzb3VyY2UgaXMgaW4gcWVtdQ0KDQp5YTogdGhlcmUgbWF5 IGJlIGEgZHJpdmVyIGlzbywgY2FuJ3QgcmVtZW1iZXINCg0KYW46IGh0dHBzOi8vd3d3LnFlbXUu b3JnL2RvY3MvbWFzdGVyL2ludGVyb3AvcWVtdS1nYS5odG1sDQoNCnNhOiBjb3B5IGFuZCBwYXN0 ZS4uLiBzdXJwcmlzaW5nIHRvIHNlZSB0aGVyZSB3YXMgbm8gZWFzeSB3YXkgdG8gc2hhcmUgDQpj bGlwYm9hcmQNCg0KYW46IHhlbnNlcnZlciBoYXMNCg0Kc2E6IGJ1dCBvbmx5IGZvciB3aW5kb3dz LCB3aXRoIGEgdm5jIGNvbnNvbGUgZm9yIGxpbnV4LCB0aGVyZSdzIG5vIHN1Y2ggDQp0aGluZy4g TWF5YmUgaXQncyBlYXN5IHRvIGFjdGl2YXRlIGJ1dCB3ZSBkb24ndCBrbm93IHRoZSB3YXkNCg0K ZWQ6IHZuYyBzaG91bGQgaGF2ZSB0aGF0DQoNCihub2JvZHkgaW4gdGhlIHJvb20ga25vd3MpDQoN CnlhOiBpbiBxdWJlcyBoYXMgaXQncyBvd24gcnBjIGluZnJhc3RydWN0dXJlIHRvIGNvbnRyb2wg YWNjZXNzIHRvIA0KY2xpcGJvYXJkIGFjY2VzcyB0aHJvdWdoIHZjaGFuIFRoZXJlIGFyZSBzaG9y dGN1dHMgdG8gc2hhcmUgZ3Vlc3QgDQpjbGlwYm9hcmQgdG8gdGhlIGdsb2JhbCBvbmUgYW5kIGJh Y2sgY3RybGMgY3RybHNoaWZ0YyBldGMsIGl0J3MgYSANCnNwZWNpZmljIG1lY2hhbmlzbQ0KDQpl ZDogd2UgY291bGQgcmV1c2UgdGhhdCwgbWF5YmUNCg0KeWE6IGl0J3Mgbm90IHZlcnkgYWR2YW5j ZWQsIG9ubHkgdGV4dC4gTWF5YmUgcGF0Y2hlcyBuZWVkZWQhDQoNCnNhOiBsZXQncyB3cmFwIHVw DQoNCnRoYW5rcyBmb3Igam9pbmluZyBldmVyeWJvZHksIHdlJ2xsIHNoYXJlIHRoZSBub3Rlcw0K From xen-devel-bounces@lists.xenproject.org Thu Sep 22 12:52:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 12:52:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410116.653103 (Exim 4.92) (envelope-from ) id 1obLgN-0004qD-Dy; Thu, 22 Sep 2022 12:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410116.653103; Thu, 22 Sep 2022 12:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLgN-0004q6-BF; Thu, 22 Sep 2022 12:51:59 +0000 Received: by outflank-mailman (input) for mailman id 410116; Thu, 22 Sep 2022 12:51:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLgM-0004q0-8C for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 12:51:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 554cc748-3a75-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 14:51:55 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Sep 2022 08:51:52 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by DS7PR03MB5654.namprd03.prod.outlook.com (2603:10b6:5:2c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 12:51:49 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::4dc1:6b11:9f99:1eec]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::4dc1:6b11:9f99:1eec%7]) with mapi id 15.20.5654.019; Thu, 22 Sep 2022 12:51:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 554cc748-3a75-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663851115; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=wkTGiVYnFDDPSIafd98ivdGUO522mdE50dFq4hr0Gws=; b=RqMPe0kWwyX4goQvI6d85qPTGpQVY4vxVFQWoNeXl6M+pl6vwZ/3JDxq xf7iuTsOp43iEsC2sRXVJzP10sqIr5mZSATGKsA1ofsSdprWcNErzwBh3 ef7DxsAZ9pxdCgXs8T/9OgHsfeOopjd4Zp9wy7S0qIuGaZf2EbNVLWpwN A=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 81102334 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zUOv6Kve3Tni77HLYBZ1UUhy7ufnVClfMUV32f8akzHdYApBsoF/q tZmKTyOM6mKYmP2c9B+ati+908HsZTQzYAxTVRk+yA8HysS+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4mlA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYMe5ct1GTFtz L8ndmwqShOIm72PzpvuH4GAhux7RCXqFKU2nyg6iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q/T/PVui4TQ5FUZPLzFPdbLe9rMWcJPmUWwr WPa5WXpRBodMbRzzBLVqyv03LSUwUsXXqpKKpKnrM5Eh2bD31IyAzhIfnW7oMSQ3xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsSzdAbJkssp8wTDlzj FuRxYq2XHporaGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi8EDSW517YRY36piG IronPort-HdrOrdr: A9a23:Y3w9/akNioCTkOCpjKwGpc8J0ajpDfOcimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7Sc+9qeu1z+883WBjB8baYOCAghriEGgC1/qq/9SEIUHDH4FmpM NdmsRFaeEYbmIKx/oSgjPIdOrIqePvmM/HuQ609QYPcegeUdAE0+4PMHf4LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpDWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1+cJi+EzSvBkuPJlagkEuTzYJ7iJnIfy/gzdldvfqWrCVu O85ivIcf4Dr085NVvF2ScFkzOQqwrGrUWShGNwyEGT3PDRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw6BgUd7DzJmtXf2eP0AgfeNQo/glieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsaqRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGdZA8aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu168HLzou WwbLp1jx9NR6u1M7zz4HRiyGGzfEytGTLw18pZ+591/rXhWbuDC1zzdGwT X-IronPort-AV: E=Sophos;i="5.93,335,1654574400"; d="scan'208";a="81102334" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eU+DLPf7TUePc+5cpApbpE6DgWiEVJsdT+6oNAuBCeqK3xbVelRkrNemJK06G1flSCC1o3BnOKQFqlXVRv+Nvm7AQc+Z1eWdvFy6hnNm6hnbxsI2rM2p/qsYgccAlr1dpWMntlOtczesrLDxCGehEQr2Wc3qMi7OdnqM5+t39upUzEiNj9q1YJvJKA++wi1U2cFAZfHMAW2eDlHIHy6BhRdvaKYGz5dirT6jWxhK7zo8iL9F8tRLvEwhUpBsBMKuD2lkrECEvuYkFw1mSMQpMOHyq7A5t4wDRAGpeUqwFOVK8an34Yhk8BbAibKwL+eOppM986x6WNB1dLXU5QC19Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EGfyu/UkZ7YBCwCZuNIYtIwDxlbwfmJsJou5ZhQvv/M=; b=gQ0jWibZbMTdNyhJUfNleyPCyaz0C/7iKtgOmWCTwZKTgGIDQtWVryZgy/QSxEoMO5GJYMkBYZapFjT+jLfAuoailUjY8RjMtrXdZFchB5h1AHESFMSNjzFgqoHog9aIU1RyRShNmdlv+kAK2aWeaQtORUTwJ35nG5mXpk7bsDqNuy/npR05aAYe22jDHEyvMcq3woIPKoiwlFBJ+lahj75yKSFYqUHjcsJIJsA+w+scLjne9sbO2l7UCCYA7YmaBxTYqdb72G2mevy66qHQZYV3A/8KKkGPjTyFYOIsBjCTskLgJSlzouEx9bfOUsyJbP0kQ0DgDBzBGEEyKvcEaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGfyu/UkZ7YBCwCZuNIYtIwDxlbwfmJsJou5ZhQvv/M=; b=om75dUp6zmRUWLvaDrfVqqru9sS3kL7F5dNukAitMUtqQD/yWFwKoI5ztKXw4Vpalf7VWMxodVHJveRspzqmIgryFUt+ikQblrpWbLBuZh1VdeVtMe26lOMa7MxRv3scDCkhhX4wmRRl6ZsCKP6TG+o8JjPZfD58pVhLP1LnFsA= From: Edwin Torok To: Xen-devel Subject: Design Session notes: tool chain (and other) dependencies of our build and runtime system Thread-Topic: Design Session notes: tool chain (and other) dependencies of our build and runtime system Thread-Index: AQHYzoIUneM8XWvFi0qNsSgpxIUjbA== Date: Thu, 22 Sep 2022 12:51:48 +0000 Message-ID: <0229EE64-884E-4F03-8476-7F210FD8A8C3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|DS7PR03MB5654:EE_ x-ms-office365-filtering-correlation-id: 516bbc0f-0983-474e-1901-08da9c9936c2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GJNbi/MEySIsTNmHnvYt65qqwYAZjytxkRBN+KwOqseVea4aph3IGZngrA3I1YQKd5AMGGPnpXUI0SIwtWVRA4DdfiLDpw7YSVWUMG9yFjvI54AxSRtEevPSeqy3qBgfZDCaP44h6vB5QHoJ5cr9T0UGWkq69yLvg2rcq00z588+biwiM6KBlc7L5wKRNZcs0btl4mKLIZRxpQSrFvrXzkbHq0mnCmGQi6XIYJiyu6rrPAeCNwe00hAzs4ukDwFeAdz6xwFm01nIYWPiQsT+YyXqUm1pKbaLn0sHAgt6bejYrxcbw5ayHx1NSaOHc047qaPiyWOMnugEVoFDqqLeLfMWvuk4oeBP6/f5Yxv6m6Q1HKuFdvfFhl7RYhFD9D3oU1hZnmEEO/P+7KgZ6N0WTlfp9/iUtBIREyNPztCuikDc4YB6VyoUSPengwptDwmhOxun5Duov7Sw0vXaC6gqfQCvBPIk/sblhE46SJD6fTZVdPTxwePRYjOTSEsj3mhQC9aDvSxs5Z9GsEyrtd0sDyysSCSXW6bXPuGzkMlFYnu0NgeE9S5fCTUdcS0SUCNC//0RHIiNW6yE1VeQA0h+u1915haNuGXik8roLkCB1SIlX1PPXCkjC8HT1BCfk0LkGSNjC+zsXsEAJ4Da1ClQVOq1bRLF5tVciUJWKNBAVdjiz8LGzbC9PK5OELPpS7Z7hTMiGgmq+vrki6L6sWS6JXyjiL6T2wNEXg9Wo9T3VzFnIEKEr6FHZM9EmQSjVIy2YKFDBLUgs8ymBNe3N/RWuicFvLLdNQ00TnK8Klri11GQecrhcnA/gdEkbCmGTStRCfD2vGkqj4VvTuXV+rBl6w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199015)(478600001)(6916009)(316002)(91956017)(6486002)(8676002)(71200400001)(6512007)(122000001)(966005)(5660300002)(6506007)(26005)(36756003)(2906002)(76116006)(66946007)(66556008)(66476007)(66446008)(2616005)(64756008)(38100700002)(41300700001)(8936002)(186003)(83380400001)(33656002)(86362001)(82960400001)(38070700005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?67SHXHc/PRi6icmIFcW/BP0eoWjQKX7SCO8AVQ9/5lDsq0i0rSlID4MNlKCT?= =?us-ascii?Q?GDxjoxJKS8BIe50XJTZr3LVmmK+Rvcnoy1ipeRPVHJS9xegNtZ79WC+IeP0y?= =?us-ascii?Q?zg4gf5x2Z3Uh5XpbW/snKHTy7Ku4S2J5dzzNfVVbE1NGASPraM05JIVAKoMi?= =?us-ascii?Q?ggZeMLYChob4nwB19wKwfrOf66GEUFMObHFQF+H0aF4TEo3QvAfFKhqE5MZO?= =?us-ascii?Q?H7rXQ0Fy50XC63jRXazgmn80xiIrpdZs100ephSrJeCPh+8LDrDiadzMaKEd?= =?us-ascii?Q?lPCMcf4IiDNx7JCJrriInEtIM7aG7RmFESYBbye0tvOwcH6P1EgWs0yKqZ1Q?= =?us-ascii?Q?maW9YT0R9qwwit8zf04dk+ssCiuufTlwiqv9gRBvnJe1YZ14CUOBLtaaozpM?= =?us-ascii?Q?4Q1IIAdttUzBq1f1ABXCYUfQQkgCItbsypYs3g5Qz9oSURcZqC3j8ZAEsCWG?= =?us-ascii?Q?2L3dLWxN3nhhx+PMAnEe97DZtHBYHSt33RPLjYFpaIvYzP72hDl4FY8Pc2jN?= =?us-ascii?Q?8rn05/4Zu0wNya8azWzIKdMWcD5cj4n3CkGNUsBDQkEuKvdxtV5/ELdE75Qq?= =?us-ascii?Q?xwptUdA8q37AzSuPraMw6B/YLf47t4i4LdLIu6he8N+CPY803V49THmSU+xh?= =?us-ascii?Q?kD/L9TS+ycyIv9ysuqdmjlDzeqQObttnPWpMPWTNaSLw5nsy527x1aZImKc/?= =?us-ascii?Q?zkWGmm3yP/RZD6iiD79DllUrP4IS2kZL3OfQbqxl8Lc5cqzyS53gSHl5Rpzp?= =?us-ascii?Q?EyXOkk1BWecPdcJ8xdncliW75lVV8DfkZnQygIHJ2YmbeMy6gXXB0CO+uE93?= =?us-ascii?Q?PNDA9KdT1FQotIg8wJFH/aNN+yYQu9RFuVjXz7fTdv8ilD2WpHYTG2bIHh7P?= =?us-ascii?Q?PgbiQIsLd7Y26lPgnLLei++jLAnEzC/ojzhNtkpYMfYIfPejnHrclLcez2lk?= =?us-ascii?Q?o9WOCuSkgkzFBo2ADdjQlA3/rcG20ecd8OJUy8RtRH9uPXkd108LVtjq9jCW?= =?us-ascii?Q?d/G1mK4q77Cy5vfvlZin9+cHABbV4hhkE3MKw3yWRqWNpJWQq2LhHTIX48Pr?= =?us-ascii?Q?9ijE1h2A1EnIWHFiBewEZcMSie5Rzhi2MWGYBu4jnkzqVuiHQ98/vrWVvuY1?= =?us-ascii?Q?SOr1w/3pqsJA8IjkrKd6FIQcmvfInuVLsLGljKnSAZaQ42b+XjGLdmEq58KJ?= =?us-ascii?Q?EdHVi/4zvLBpxk0/ba/SM3/ujtqUHYBZKzaD7F0DhGNjIT8tTcfMbHgRB9xl?= =?us-ascii?Q?5C5FiTzzeFmjtbv4tH6tvoaa9HH6OD/ackbhUrvdRPKzrVn8oX50z7CmqpGJ?= =?us-ascii?Q?j5canJoY2iq9mdziAu1SXHKUqcFhHYxDZliC4grB/jHnWGV0FAcFuZtiQtWg?= =?us-ascii?Q?+/8Ju069kwfV/7qglHHiCn/HR/6Vrvub/IT474vOJ2xDnE2vDn8ij+BlgHwg?= =?us-ascii?Q?ZmOdOYfzHAMOZQY+KK6kJtcIxbMZu9uNC/Ev56vR+PGndFwllyb/FwqBOPwY?= =?us-ascii?Q?NbFcj04i3nEHMVCDpvjuVmuSkpoaeppWhh6g967nDTc1VUgu/fqKvFXgd1oO?= =?us-ascii?Q?fBewam55ZOXxC5iCiHkjpyRCwbe9bVHdK134o2zYfqfj+vYU5PBoEWWMrqJ8?= =?us-ascii?Q?hA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <4F3E0EB939B2E14D98FABB50DBBAE6E3@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 516bbc0f-0983-474e-1901-08da9c9936c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 12:51:48.8653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EnOVa7sd1W6C3ogA0Z7tOohvWVEW7CFF5GA1CfHrpBUk/EZdXP36yfKmtK0Agw1PO85W/g97rHDQWR1ndGvicQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5654 Hi, These are the raw notes for this design session from the Xen Summit: https:= //design-sessions.xenproject.org/uid/discussion/disc_JEWVIhuv2TRAo2AXAZnP/v= iew Dependencies haven't been updated in quite some time: * Toolchain * system libraries, and other runtime deps E.g. when to drop Python2. Testing on old hardware might need it. Old hardware is difficult to keep ru= nning, e.g. older than N years. Vendors may not support it anymore, but that is a separate discussion. What distros for newest versions of Xen, as minimum? Minor releases keep working. Next release can make another choice. Not necessarily actively break, but s= upport might be best-effort. Support old guests of course, but what about build? Might limit testing on old hardware, if it is difficult to get new distros = running on it. E.g. after announcing new release, announce set of distros for master. Update list at least once in release cycle. make change for 4.18. Accept nominations of distros from community for consideration, and then ta= ke decision. Or perhaps use backport (e.g. EPEL). Distros which have support policy (i.e. they say how long a particular rele= ase is supported). Can't test everything on all distros, might be package version based. E.g. = GCC >=3D version CI testing vs do we want to fix the breakage or not even if we can't detect= in CI Informal survey on xen-users, resend patch on xen-devel (perhaps survey if = lots of concerns raised) Distro packages, even if not available by default. Might be helpful: repology.org for checking versions= From xen-devel-bounces@lists.xenproject.org Thu Sep 22 12:58:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 12:58:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410129.653115 (Exim 4.92) (envelope-from ) id 1obLmL-0005hB-7Q; Thu, 22 Sep 2022 12:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410129.653115; Thu, 22 Sep 2022 12:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLmL-0005h4-4d; Thu, 22 Sep 2022 12:58:09 +0000 Received: by outflank-mailman (input) for mailman id 410129; Thu, 22 Sep 2022 12:58:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLmJ-0005gu-V4; Thu, 22 Sep 2022 12:58:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLmJ-0007hN-R0; Thu, 22 Sep 2022 12:58:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLmJ-0000FK-6O; Thu, 22 Sep 2022 12:58:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obLmJ-0002NT-5v; Thu, 22 Sep 2022 12:58:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yJkshksDvwP62Jiph0OtHB+lXfDAK9XxA6017O88caU=; b=R1d5uvC9o2bgJezpF/Q05bE2jz 21n9TUfAUyHgakgRJhnZBzRfcIe/GDjSVXAskaqAnBSqKh6UJt923kTp2IiPKg53Eb7NF5qZJ0dgB u8FuiTSMiNmGW+8abwQbNpW+UMbshNGpvBIEozbQHfRte0l2TEx4aAvVr23munwC1JOo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173272: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6338c30111d596d955e6bc933a82184a0b910c43 X-Osstest-Versions-That: qemuu=2906f933dd1de6d94c54881cc16ea7390a6ba300 From: osstest service owner Date: Thu, 22 Sep 2022 12:58:07 +0000 flight 173272 qemu-mainline real [real] flight 173276 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173272/ http://logs.test-lab.xenproject.org/osstest/logs/173276/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 173276-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173269 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173269 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173269 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173269 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173269 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173269 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 173269 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173269 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173269 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 6338c30111d596d955e6bc933a82184a0b910c43 baseline version: qemuu 2906f933dd1de6d94c54881cc16ea7390a6ba300 Last test of basis 173269 2022-09-21 17:37:25 Z 0 days Testing same since 173272 2022-09-22 01:08:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Bernhard Beschow Bin Meng Daniel Henrique Barboza Laurent Vivier Mark Cave-Ayland Richard Henderson Stefan Hajnoczi Thomas Huth Víctor Colombo Xuzhou Cheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 2906f933dd..6338c30111 6338c30111d596d955e6bc933a82184a0b910c43 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:08:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:08:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410137.653125 (Exim 4.92) (envelope-from ) id 1obLwg-0007L0-6f; Thu, 22 Sep 2022 13:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410137.653125; Thu, 22 Sep 2022 13:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLwg-0007Kt-45; Thu, 22 Sep 2022 13:08:50 +0000 Received: by outflank-mailman (input) for mailman id 410137; Thu, 22 Sep 2022 13:08:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLwe-0007Kj-Pz; Thu, 22 Sep 2022 13:08:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLwe-0007tm-LC; Thu, 22 Sep 2022 13:08:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obLwe-0000Ui-86; Thu, 22 Sep 2022 13:08:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obLwe-0002QL-7b; Thu, 22 Sep 2022 13:08:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5G3cJkQQfEiZ1hiSHptZQj6QgZe5fSn5ugAvzE9XCPQ=; b=PTO56t5ztA3BtfBvA2iXl4cRyo y/dJAJdkKGSUJPRegfrGGDjcQuTMs/cwytSaSgfHGszcP11ybGsjFkXHp5SDUxcvTLhNFo8eimsZE QBPqC7Tq01g5YO+XwTB1dZROQ7kDyTmjtyY/ItFE5jPu+aMQEoUgboJH2XZy89smj9Zo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173274: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start.2:fail:heisenbug libvirt:test-arm64-arm64-libvirt-qcow2:debian-di-install:fail:heisenbug libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=8496880866415a5673715ffa0e4720efb4274c22 X-Osstest-Versions-That: libvirt=0eeb4a1775175328a7eb45fad73cd832472c70d9 From: osstest service owner Date: Thu, 22 Sep 2022 13:08:48 +0000 flight 173274 libvirt real [real] flight 173277 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173274/ http://logs.test-lab.xenproject.org/osstest/logs/173277/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 19 guest-start.2 fail pass in 173277-retest test-arm64-arm64-libvirt-qcow2 12 debian-di-install fail pass in 173277-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail in 173277 never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail in 173277 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173266 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173266 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173266 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 8496880866415a5673715ffa0e4720efb4274c22 baseline version: libvirt 0eeb4a1775175328a7eb45fad73cd832472c70d9 Last test of basis 173266 2022-09-21 04:18:49 Z 1 days Testing same since 173274 2022-09-22 04:20:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 0eeb4a1775..8496880866 8496880866415a5673715ffa0e4720efb4274c22 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:36:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:36:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410144.653137 (Exim 4.92) (envelope-from ) id 1obMMr-0002YX-Bz; Thu, 22 Sep 2022 13:35:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410144.653137; Thu, 22 Sep 2022 13:35:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMMr-0002YQ-8v; Thu, 22 Sep 2022 13:35:53 +0000 Received: by outflank-mailman (input) for mailman id 410144; Thu, 22 Sep 2022 13:35:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMMp-0002XY-Vs for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:35:52 +0000 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [2607:f8b0:4864:20::112d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78bdcbf7-3a7b-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 15:35:50 +0200 (CEST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-3450a7358baso98547197b3.13 for ; Thu, 22 Sep 2022 06:35:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78bdcbf7-3a7b-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=z30lOYnst2tpbJr59CCMps8P2Smk1vfNrNzHWtQ5szU=; b=bnM9aAgpAyEH2qr6w45j6+Zmkk7DPwjEU7z/mrU/HhuHyhmGnioCROydWrehDAV86g +AHZ1J4qrKSAojXpkqeVgQvR/P9JTMks/HFpWsEfza2wKLh1b3nlHgVeNjick7LZnWso TuVuXovPCE+M0wyDa9Rm4tvLmHixzlWLC2zq3n9toJ1aWeygfDaimOFRhiwx9ALF2Vy8 3obprZj9F6InCEhr2cggR0VR5ojwu4cuCf5IIaiVbbd1d+jG9P4IlI8TKEKl1X3LN3QL Eq90vjub2tMxGXyCHtK2/Ez+IB5DMS9CiH6DhL+zSNaJwESOLd3TqdkKPJ+Ny2nT/ve6 dplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=z30lOYnst2tpbJr59CCMps8P2Smk1vfNrNzHWtQ5szU=; b=dd9mKu+2CgdkIo7jsa+rUPqh6ex+MwNkBwDkDSo8HLgwHSraNKbAHaBZzi2lSo8a9Z 5eCABD7Ixxt7D2lwhYzXqY0lhPJHG81/WNs7OkbbtcgQUOjMTESEc4GHhhdHE+4q7/0X WMqwJEJw4qllmSRXtrXnzlGkHI9Q6/kPVR9ii6CTD2rMylIva3HqyRJ2tNOpqli+4tAq WvtSteXVMnwMKU0y7ank4ltVa8OTxwfDkJ52XZh4Zeemx5CpfAtXF+5/acZSMphiTbln zEuYXO+zfbumTTKhCmK3j+CBcwSzs8ebQkLTCXA86FOoq0YaLmjGH0WgAwL9aCaS7ugz 5Q3g== X-Gm-Message-State: ACrzQf1SCq+z5vChF8T5nxKZ4bby0gA0UWYG0zf9vetQvBU1Ltv0yL+b BcnyaSsikFrtAsLvBeFED4jgdZk5flVfWq3Vm0o= X-Google-Smtp-Source: AMsMyM5zGbssEQGhBCN6Wd0+hmoYSfak4yL+WQzH+dgWY1VPUMiLMVNWd2z8ChBeTADwRqdJnNGmQ/hd/BKG05UzB1I= X-Received: by 2002:a81:c02:0:b0:34d:829a:20f3 with SMTP id 2-20020a810c02000000b0034d829a20f3mr2576953ywm.168.1663853749438; Thu, 22 Sep 2022 06:35:49 -0700 (PDT) MIME-Version: 1.0 References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> <2c0e506a-e494-68d5-f4d0-1b54cca2b970@oracle.com> In-Reply-To: From: Tamas K Lengyel Date: Thu, 22 Sep 2022 09:35:13 -0400 Message-ID: Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load To: Boris Ostrovsky Cc: Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel Content-Type: multipart/alternative; boundary="000000000000b1903e05e94423a8" --000000000000b1903e05e94423a8 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 20, 2022 at 2:27 PM Tamas K Lengyel wrote: > > > On Tue, Sep 20, 2022 at 2:12 PM Boris Ostrovsky < > boris.ostrovsky@oracle.com> wrote: > >> >> On 9/20/22 10:54 AM, Jan Beulich wrote: >> > On 20.09.2022 16:26, Boris Ostrovsky wrote: >> >> On 9/20/22 4:01 AM, Jan Beulich wrote: >> >>> On 20.09.2022 00:42, Boris Ostrovsky wrote: >> >>>> It is saving vpmu data from current pcpu's MSRs for a remote vcpu so >> @v >> >>>> in vmx_find_msr() is not @current: >> >>>> >> >>>> vpmu_load() >> >>>> ... >> >>>> prev = per_cpu(last_vcpu, pcpu); >> >>>> vpmu_save_force(prev) >> >>>> core2_vpmu_save() >> >>>> __core2_vpmu_save() >> >>>> vmx_read_guest_msr() >> >>>> vmx_find_msr() >> >>>> >> >>>> >> >>>> The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder >> though whether >> >>>> this call is needed when code path above is executed (i.e. when we >> are saving >> >>>> remove vcpu) >> >>> How could it not be needed? We need to obtain the guest value. The >> >>> thing I don't understand is why this forced saving is necessary, >> >>> when context_switch() unconditionally calls vpmu_switch_from(). >> >> >> >> IIRC the logic is: >> >> >> >> 1. vcpuA runs on pcpu0 >> >> 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has not >> yet called vpmu_load() from pcpu1 >> > The calling of vpmu_load() shouldn't matter here. What does matter is >> > that vpmu_save() was necessarily called already. >> >> >> I thought we don't always save MSRs on context switch because we optimize >> for case when the same vcpu gets scheduled again. But I am not sure I see >> this now that I am looking at the code. >> > > I see context_switch calling vpmu_save_from before __context_switch, but > if that did actually save the vPMU state it would have reset > VPMU_CONTEXT_LOADED, so by the time vpmu_load calls vpmu_save_force it > would have just bailed before hitting the ASSERT failure in vmx_find_msrs. > The context must still be loaded at that point (I'm trying to verify right > now by adding some printks). > OK, Boris was correct above, MSRs are not saved on context switch automatically because of that optimization. VPMU_CONTEXT_SAVE isn't set, so the only thing vpmu_switch_from does is set global control to 0 in case it was a PV vCPU (see core2_vpmu_save checks for both VPMU_CONTEXT_SAVE and VPMU_CONTEXT_LOADED) and vpmu_switch_from doesn't set VPMU_CONTEXT_SAVE. So for HVM vCPUs it does nothing, that's why we still see the context still loaded when we get to vpmu_load. It would be a simple enough change to make vpmu_switch_from always save the context and then we could get rid of vpmu_load trying to do it later and getting into that ASSERT failure. Thoughts? Tamas --000000000000b1903e05e94423a8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Sep 20, 2022 at 2:27 PM Tamas= K Lengyel <tamas.k.lengyel= @gmail.com> wrote:


On Tue, Sep 20, 2022 at 2:= 12 PM Boris Ostrovsky <boris.ostrovsky@oracle.com> wrote:

On 9/20/22 10:54 AM, Jan Beulich wrote:
> On 20.09.2022 16:26, Boris Ostrovsky wrote:
>> On 9/20/22 4:01 AM, Jan Beulich wrote:
>>> On 20.09.2022 00:42, Boris Ostrovsky wrote:
>>>> It is saving vpmu data from current pcpu's MSRs for a = remote vcpu so @v
>>>> in vmx_find_msr() is not @current:
>>>>
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_load()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0prev =3D pe= r_cpu(last_vcpu, pcpu);
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_save_f= orce(prev)
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0core2_vpmu_save()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0__core2_vpmu_save()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vmx_read_guest_msr()
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vmx_find_msr()
>>>>
>>>>
>>>> The call to vmx_find_msr() was introduced by 755087eb9b10c= . I wonder though whether
>>>> this call is needed when code path above is executed (i.e.= when we are saving
>>>> remove vcpu)
>>> How could it not be needed? We need to obtain the guest value.= The
>>> thing I don't understand is why this forced saving is nece= ssary,
>>> when context_switch() unconditionally calls vpmu_switch_from()= .
>>
>> IIRC the logic is:
>>
>> 1. vcpuA runs on pcpu0
>> 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has n= ot yet called vpmu_load() from pcpu1
> The calling of vpmu_load() shouldn't matter here. What does matter= is
> that vpmu_save() was necessarily called already.


I thought we don't always save MSRs on context switch because we optimi= ze for case when the same vcpu gets scheduled again. But I am not sure I se= e this now that I am looking at the code.

I see context_switch calling vpmu_save_from before __context_switch, but= if that did actually save the vPMU state it would have reset VPMU_CONTEXT_= LOADED, so by the time vpmu_load calls vpmu_save_force it would have just b= ailed before hitting the ASSERT failure in vmx_find_msrs. The context must = still be loaded at that point (I'm trying to verify right now by adding= some printks).

OK, Boris= was correct above, MSRs are not saved on context switch automatically beca= use of that optimization. VPMU_CONTEXT_SAVE isn't set, so the only thin= g vpmu_switch_from does is set global control to 0 in case it was a PV vCPU= (see core2_vpmu_save checks for both VPMU_CONTEXT_SAVE and VPMU_CONTEXT_LO= ADED) and vpmu_switch_from doesn't set VPMU_CONTEXT_SAVE. So for HVM vC= PUs it does nothing, that's why we still see the context still loaded w= hen we get to vpmu_load.

It would be a simple enou= gh change to make vpmu_switch_from always save the context and then we coul= d get rid of vpmu_load trying to do it later and getting into that ASSERT f= ailure. Thoughts?

Tamas
--000000000000b1903e05e94423a8-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410152.653159 (Exim 4.92) (envelope-from ) id 1obMS7-0004HP-AB; Thu, 22 Sep 2022 13:41:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410152.653159; Thu, 22 Sep 2022 13:41:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS7-0004HH-7L; Thu, 22 Sep 2022 13:41:19 +0000 Received: by outflank-mailman (input) for mailman id 410152; Thu, 22 Sep 2022 13:41:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS6-0004DO-5f for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:18 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2051.outbound.protection.outlook.com [40.107.94.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39d70b37-3a7c-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 15:41:15 +0200 (CEST) Received: from DS7PR03CA0166.namprd03.prod.outlook.com (2603:10b6:5:3b2::21) by BL1PR12MB5064.namprd12.prod.outlook.com (2603:10b6:208:30a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 13:41:11 +0000 Received: from DM6NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::44) by DS7PR03CA0166.outlook.office365.com (2603:10b6:5:3b2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17 via Frontend Transport; Thu, 22 Sep 2022 13:41:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT056.mail.protection.outlook.com (10.13.173.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:11 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:10 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:10 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:09 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39d70b37-3a7c-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iwa1zCoCSHOwTVbXHPxXFwsVXM8OKiLWulRTxQ7FdZc4r0HSvKOZZmygmOT1KtoeX27Tnpujj8nuEXU/25WhUqu88HU5KgfYMs6Vi9JQtSdO8JbjackV8ve5RvUd51lrDbs3Kq+3K0tWguHUhIgS/jTqRb+OrBsuHSrKdY3ZRjj+/SHXLQR+hJzkD5Pl0KKz7nhRljO6yIL3qh3ygWJItSmBy6Bs8QbnPbzuTBDIm1y2e3VD8a+KN4VP+TKk35LfcsG8BFpxU28ZgkT0SB9BrGYv+1T7ftPBOc8jDxOo1zYBZYoyyZQaZ62200deq/0Ltrxc3r9hV436D3cv+BRbwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9TCf2AxGrtdVWLFPiW0EV7Q/lCaLP6Fex+1tR1yXPw=; b=TqzCMkrHSeRYrz/EWeUxX3EgTjumKbtXpmQ9pLLE6BG4A25MyDN6Ihmx0771OSP41dpBe0XX2DRFDQUXWXXtwmIpk+g1OAGgHQtWMGbsdu4Oabe3lNxZjz54XDXobBWx0Uq3u7J2Hr2DXZjlbN3CHsRPLTXC5i947YiCp8tcLvlWpUe1P5sRWnGWppTMhR9U5ZUu+eZypRFK3Sf/d0QfyM1wJzL3M+KQlhSt3elS6ENspirx+wEZTWUp5spMN4dpmusHiTnppPDPFFSPQsGrDicJWP28BGfMBLHdXutjlTbakb//gLNWh+JchYFV/yISiSpGrWi/KODyDIwY86bTmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9TCf2AxGrtdVWLFPiW0EV7Q/lCaLP6Fex+1tR1yXPw=; b=2tQmDPr1T9DMDBuL1Vk27CTB9hjkI6DLBOgy5eFwk1n2223WnUTPhr7ov8IZSpeirukjLNdmufYRq1qKD3niUen0nYgfQwDM9vrrk9Tpm4TgFDzzc17Kneebv6bbBSk8HXvwExSR96Ew/XykCkN/nV5Y2FQijRbGPBtTLdOifDc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 1/9] automation: Use custom build jobs when extra config options are needed Date: Thu, 22 Sep 2022 15:40:50 +0200 Message-ID: <20220922134058.1410-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT056:EE_|BL1PR12MB5064:EE_ X-MS-Office365-Filtering-Correlation-Id: c6cbeff9-316a-4c6b-84b8-08da9ca01c81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7nePnWmnlLlFLfKH3MlRMEAaPogyHi16cv+SDVYHkCO7YDJ1qxt3rHVPezAMVFG1cMzEWj82ZSZiYGDms7vJBn1Btydtl9xYpOf513K16M+8aFpWsxxyXLHkh05ORx2uEpntWG+asHxmpD9DRlMHRobTdCnsYZb3/7jhmkr9d46NaacTql+lOpXGkJpkO6yOZ3CcOgDwnBavGqLPldpSxdnAb+vYIX/sT12Uq+5qGvA/1ZL4SGeaKB43YnMqwgfdscVYLq2PGnVbXqZukDg81Z+7/DvwrdlTXLcNcWpKET+eOWwbii6oFg1BqmAQ+Si85BpezW1vAg/EL89DDVslZbhdPGgFYIhWROy6kbKSlmvxGwK1qEGSO6hEA2DocpQzBozI4MoJCWI9gG8iA0kMIwhIIdbso9VmG6lTHJRUgx7TVfw7H7Gyg8G/9c4DqGw1srrwx50BDK1Cw8ENw0pXKp43/TJZvgoYBOyLepCqDqEMZLNxZrhuT4xd/IURzgMQFd7R1W8Y8IRbcYWJpqQ44Qwk+qVp8aLsmpKUHO4W1x0gFAvzpLMxDTOVjY5yl49TuZO4aKRoEgrSjuPbruPiMKbkDHG3EpHehEOclRYm7NBEX2AX39v62LXxjguGXBVd8ETCYDygDbywcHRfENZT7VfjF9xUEA4kvuh96jlmRuWUKmOlJQ/bOP5J+fssgzpDXEV+tbKHgnYGm3XgA7hqaB7vlq/R56kwW7dovVLVgU67ojlVcprZW2RKHNhlFUB+B7N9B77wEiejZB8+aB6am0O9QClNHOhvxeJHAiChaKS+3RlmeNyhhxo4EfDZ1IGy X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(40470700004)(46966006)(36840700001)(356005)(82310400005)(2906002)(81166007)(86362001)(40460700003)(82740400003)(36860700001)(6666004)(41300700001)(26005)(6916009)(4326008)(54906003)(2616005)(478600001)(426003)(5660300002)(316002)(44832011)(8936002)(47076005)(186003)(8676002)(1076003)(40480700001)(336012)(83380400001)(70206006)(70586007)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:11.2359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6cbeff9-316a-4c6b-84b8-08da9ca01c81 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5064 Currently, all the arm64 defconfig build jobs, regardless of the container used, end up building Xen with the extra config options specified in the main build script (e.g. CONFIG_EXPERT, CONFIG_STATIC_MEMORY). Because these options are only needed for specific test jobs, the current behavior of the CI is incorrect as we add the extra options to all the defconfig builds. This means that on arm64 there is not a single job performing proper defconfig build. To fix this issue, add custom build jobs each time there is a need for building Xen with additional config options. Introduce EXTRA_XEN_CONFIG variable to be used by these jobs to store the required options. This variable will be then read by the main build script to modify the .config file. This will also help users to understand what is needed to run specific test. Signed-off-by: Michal Orzel --- This patch could actually be consider to be taken for 4.17 release. The reason why is because currently our CI for arm64 does not even peform clean defconfig build which is quite crucial target to be tested. Performing builds always with EXPERT and UNSUPPORTED is not something so beneficial for release tests. This is up to the release manager. --- automation/gitlab-ci/build.yaml | 15 +++++++++++++++ automation/gitlab-ci/test.yaml | 4 ++-- automation/scripts/build | 8 ++------ 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 720ce6e07ba0..a39ed72aac6d 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: variables: CONTAINER: alpine:3.12-arm64v8 +alpine-3.12-gcc-arm64-staticmem: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + +alpine-3.12-gcc-arm64-boot-cpupools: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_BOOT_TIME_CPUPOOLS=y ## Test artifacts common diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index d899b3bdbf7a..4f96e6e322de 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: script: - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - - alpine-3.12-gcc-arm64 + - alpine-3.12-gcc-arm64-staticmem - alpine-3.12-arm64-rootfs-export - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: script: - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - - alpine-3.12-gcc-arm64 + - alpine-3.12-gcc-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export diff --git a/automation/scripts/build b/automation/scripts/build index 2f15ab3198e6..7d441cedb4ae 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig hypervisor_only="y" else - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then - echo " -CONFIG_EXPERT=y -CONFIG_UNSUPPORTED=y -CONFIG_STATIC_MEMORY=y -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config + if [ -n "${EXTRA_XEN_CONFIG}" ]; then + echo "${EXTRA_XEN_CONFIG}" > xen/.config make -j$(nproc) -C xen olddefconfig else make -j$(nproc) -C xen defconfig -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410151.653148 (Exim 4.92) (envelope-from ) id 1obMS5-00041a-2p; Thu, 22 Sep 2022 13:41:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410151.653148; Thu, 22 Sep 2022 13:41:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS4-00041T-Vs; Thu, 22 Sep 2022 13:41:16 +0000 Received: by outflank-mailman (input) for mailman id 410151; Thu, 22 Sep 2022 13:41:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS2-00041N-Uo for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:15 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36f141c6-3a7c-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 15:41:09 +0200 (CEST) Received: from BN0PR08CA0016.namprd08.prod.outlook.com (2603:10b6:408:142::35) by MN0PR12MB5835.namprd12.prod.outlook.com (2603:10b6:208:37a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.17; Thu, 22 Sep 2022 13:41:10 +0000 Received: from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:408:142:cafe::f9) by BN0PR08CA0016.outlook.office365.com (2603:10b6:408:142::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18 via Frontend Transport; Thu, 22 Sep 2022 13:41:10 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:09 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:09 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:09 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:08 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36f141c6-3a7c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qf8UInUFkFmz86Dh6WSyuRFs+lOmcFz9DD2ahht6V/opJ9sY0Ng95R/crWSSrgjkQpAohFVwG6dg0A2mMonrhK0deJRJDNDtV3nxdh0Yi+XvKXjZDmtffUpJ53R7n/mdDsLTBJqlaDk/liOGiI8lx70y+iBHaMnOEEQ0493s9ikRjCVDxMQel2Nh6Md4cIu8sApw+C1V5ynmvO7dYaf0eUPcqy3NrOmYZjzl3lwhTH6mTGJB3EKLDIoeesTOw13VPjO+Ydt4rK3TNrDDQbjaGJc5/Pu1Mp35Y302eWqT7JwWZm4lPr9SqM+4wzytALUERe+bhPwOKjl+qZHP7u9GjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eFd5gtYuyRgdB3UriWvj7k5JYO7DhSPqJ01SrsP14FU=; b=AgDhbQQjYGxam7fOz42M87syfgdwrbOf2mkUE/swE+O1eSyj83jiv1bq/HQ/6gO/vM0+6TL39RA0D9WWte/MkKn8tPJL2nDCuSil7Sx9z9PwjAAQoPaPX/Nrz0MRvkUw/i6Eom2rAEVsmfk42N2PN5lQ3DzwKwm9VW/Kn5qxA+J2VQfPnSRvjs54hpsAw43hpAJ7Mi0fHjAf6L9YpaUnVBnhY2gXEeDSkWhmnUKA8snsKVpZLI7yy5gkCKwP0SebRQRGHOKpEHZgLqrRwCZ67NxYUIYxf33fuqtUZ0jA4y4vV2bOn59VVGBoIb5ZBM+TToLmWPXSPnmpEqDkBz6ztQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFd5gtYuyRgdB3UriWvj7k5JYO7DhSPqJ01SrsP14FU=; b=jhC3sYkUNGVag5imYeP5G30TbfeY3QwAmBFXI5vN9bOJmZDyLRdWyEeSRAKlACzJVfCoIre/umltDmXJLfNfNPXJDqG+mGuYQ47TyLjwRm+mstwSex/PaIXSKcItuXt8U4EJNZOmo9E06zTaCCCgXSg3jFM0RqUAIZoviv16cec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 0/9] GitLab CI cleanup & improvements for Arm Date: Thu, 22 Sep 2022 15:40:49 +0200 Message-ID: <20220922134058.1410-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT013:EE_|MN0PR12MB5835:EE_ X-MS-Office365-Filtering-Correlation-Id: 85b6bce6-fa0f-47f5-ce80-08da9ca01ba8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ASM88PlnmzkmxM+DDJ6kinykIEWtvlL8KECacYZNE/o4YT+KzgNC6wzfOFJYgBL730JsDYO0/5/TfG+Z/sl2U+x6Kh1i6Lym2FM8R7YFgeKFHhSR1HCFTQ7dA5qm4G9r4/l/3u6XONRPK6x3D3In7L0qhkfVbjM3eHqpOh45h/wjpkwiN0O619hI6DFYfZrZ56r96Y13y0NprHmI68lM8MTrUoln6zSWjPWfCKvFFgD0HF1XKWnVX/efyzsBZ8rCjOjh55aw2CJsH/PDHdARDmf102/ggPRF3tuyclBBjzY9o+JY1EEl+QHbRbmtxPaJA1ooEuHR6hpDS8Cv48Ak3WlL2ajk7eGAqG83Uh8Ge0ph5iccOcndBW0fFgl9wim3SzXUm7Pt3IRv9KjbMvDGlWixO+j3uMbafH0ghBf9hkDCQiWbbAy3cvw0hKCiOucUsm/C85sUXRjXX9DKrBPdvM2YA4l52Psc6d21y9+cqL1kInhp/gFZ/bp00Cuvu7sKAjzrekazmYeI0AgaNfoRype2MReisHH4+o8J+qBp44yMd7mLl6bgI4RiO6a8pUJqzdn8l027NHe+DV69CEmSBfYfROnWUNM1M7CfP0Rh0n1GEc25HmHdtskTxV0DFT1qV02ulgG+Nj3IdhJA9FpaSfE1Zp9X+82wNOAz6wMGxSTX7bCOU7RpbJLjo4O8TEgJaBgmdapHM7KvH/D7aSLpza3SBCNibd719BmmYTyLK5PjXFcouJ8Pg4zTNpAKJUMvzEutAmdYuzfOWn2BMu50HG0RWTSi1DxRN63/jIQiFifgeGJ9ibO5H7Smi+6i9USt X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(81166007)(86362001)(83380400001)(356005)(36756003)(36860700001)(70586007)(41300700001)(70206006)(2616005)(82310400005)(40460700003)(2906002)(40480700001)(82740400003)(336012)(186003)(47076005)(26005)(426003)(478600001)(6666004)(1076003)(8936002)(316002)(44832011)(54906003)(6916009)(4326008)(8676002)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:09.8469 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85b6bce6-fa0f-47f5-ce80-08da9ca01ba8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5835 This patch series performs necessary cleanup and improvements in our GitLab CI automation for Arm. This is crucial so that in the future we can focus on adding new tests instead of spending time to fix issues, making the behavior consistent, removing ambiguity, etc. With the increased interest in gitlab-ci and using it locally, there is still some work to do mainly to improve documentation. This however, will be handled in the future series. Michal Orzel (9): automation: Use custom build jobs when extra config options are needed automation: Add randconfig build jobs for arm64 alpine container automation: Add debug versions of Arm tests automation: Add Arm containers to containerize script automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder automation: qemu-alpine-arm64: Cleanup and fixes automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh automation/gitlab-ci/build.yaml | 43 +++++++ automation/gitlab-ci/test.yaml | 117 ++++++++++++++++-- automation/scripts/build | 8 +- automation/scripts/containerize | 3 + ...moke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 57 ++++----- ...pine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 14 +-- ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 6 +- 7 files changed, 190 insertions(+), 58 deletions(-) rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (55%) rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (88%) rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (97%) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410153.653170 (Exim 4.92) (envelope-from ) id 1obMS8-0004YD-JQ; Thu, 22 Sep 2022 13:41:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410153.653170; Thu, 22 Sep 2022 13:41:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS8-0004Y2-GV; Thu, 22 Sep 2022 13:41:20 +0000 Received: by outflank-mailman (input) for mailman id 410153; Thu, 22 Sep 2022 13:41:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS6-0004DO-VC for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:19 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a9c37be-3a7c-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 15:41:16 +0200 (CEST) Received: from BN0PR04CA0208.namprd04.prod.outlook.com (2603:10b6:408:e9::33) by SA1PR12MB7320.namprd12.prod.outlook.com (2603:10b6:806:2b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Thu, 22 Sep 2022 13:41:13 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::39) by BN0PR04CA0208.outlook.office365.com (2603:10b6:408:e9::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17 via Frontend Transport; Thu, 22 Sep 2022 13:41:12 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:12 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:11 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:11 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:10 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a9c37be-3a7c-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d92zhKA5ig8lgUzp0ymzxSwK//oBrB5dQv603cJk8hDRLUyTDJPNc9yAobOTsqZ+EwilmWpCoF+8827jJiujDLxJk/lHEuto3YyLRVVeYCVW2XP8OJJIad8deYKV802CZvd1SXB5kiD2JVSUor0MkWsOHcXflAi1fEVrPltlYUtumvh0qHRTr6GWYPw6pAfcO7ZUY7rofqYJLdk2XzUaC9zTWpaEKAiLTJboZ4ymWUqYTdrsDtZ01nbi+JL/rWjUcOvW70b3C7/2Ri9V4D4cQeks+UFppHVjnjbewF+9tkvAzGH1VQEWeWNjTyGRYW49lygveJ9AUT07sdhSG2eznw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTulcGwMKiw1fmEMFmWPsSd4FimqEq/BzeQ6wBAjlF8=; b=cInYbZnxRm8OELQadNrZdV6H6wPwPPlKublQG7nY0/R2LzpJaeG43vnSXXFMGc8Z6m3NpTVBoFMIldL+zbkmjgtTr3WEZ5HhdYzck+4Z5uykc5deHfXkUO0fi9c2/YtBcjzsS3hC5fJhq/JthWtdij3weO0YMRKZv2mNzCeQVRNkGGnmcnOVOvk4CCcSAbGpoX2ruZsOLeanywcKOtIWyI4O6KP2aSj41xA/vc6SXMSS+XOf2hpNg8JVGtU7YcFt53bj6fNfl0ipvfQesqn5z1nspULFBRJ4Lc0T3YctxLdnE30wq/nKaLRehV1Vy4lT8tzwyP8u8YA9q6F2n8p6tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTulcGwMKiw1fmEMFmWPsSd4FimqEq/BzeQ6wBAjlF8=; b=D+wUJwnhVNxu4U/+cNFQ+i71LwlbdY+RyNAb9V5iSfYeG3HOuxgtmTDF4rswzHLPOLT22MXiKadrqUP2lnlzH3IPJHGxhDVCHJS0zw5Aj3UUgsyBTXdsCagX2RjoUT+JACR/17g4s16yq+XraV3tB0JsiVfAbw4+p3btqCN081s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 2/9] automation: Add randconfig build jobs for arm64 alpine container Date: Thu, 22 Sep 2022 15:40:51 +0200 Message-ID: <20220922134058.1410-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|SA1PR12MB7320:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f5a9331-dcc2-4914-d30b-08da9ca01d4f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +7ExJfXVLT92z+hYukkpkbiC0FDyowAWmcWgewpFga7kvN9hcUBL9Jbpr/+8xKSFx/3fMivNwQN7PGAa7EaWS4gRzzgUV9JG23Un+si0hfcY4NDT/PVPLPHya91zG6t/eGdRklKB+SNmA/BEtBcSkdC/Ge8rHfyrF5QFAjn0Bdgq8eLOQIKw1kMk8Bxd0FiemsAGL487aqljCXKIGcO42JIDYx/NPv2m4x86cgbc3o1eq3tsnfytK0EZ7ypaWgoMQGeyJW+zXW86x/CY3KnjaGW730EEdICArrgqjm/myp9pcEce0SEnLEt1RsRUImEFKUnyNOmACIHGvMZmkaAK5aXWfBICVuBXElgCrSZ6ByiuiApOTva54/Tcrz4zVio+s+OILIGK33vjPMAYy3fnxZbafoA9X6M8jVUcgym0TOnkrx51BURHfcJLYjv1TuziZvCMESU7w1vQPpn4xO9qbj5AVLOaxmpuqf5gsKiWPURCX18kI0r1eh2kFxqyqgW66zg383iDDWdoTsIzaApmK1aeqiEUg8wMh+piV9sJxPyF16tbZLysU1+Cp3ETG7htzzZ7SXzBE2P0wKLnnVfYsiO5KRMcrpBwlEHtGMBAjF3/gekDomwq181x2gGmxSsBTGGGp8TPPEa1AT3XvnB62KmT8shgo4LbQDK90ukSB39m7WuWpy5CIWkdNuwIkhR2uwjC01gsRd2/bveoSnhuGd1mcP1QsoKhSeN4ifwM+pvFipcqRwIl/6WYoqNVJcyjlpIEzbEjqcjGXO5RmNQOsuYosFzDISiyPacboBTumVzWTIY9L62d8QBfutfS+BsM X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(8936002)(82740400003)(356005)(81166007)(36860700001)(336012)(2616005)(6666004)(2906002)(426003)(47076005)(1076003)(26005)(5660300002)(186003)(478600001)(54906003)(316002)(86362001)(70586007)(44832011)(70206006)(41300700001)(4326008)(8676002)(6916009)(40460700003)(82310400005)(40480700001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:12.5723 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f5a9331-dcc2-4914-d30b-08da9ca01d4f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7320 For arm64 we perform builds using debian and alpine containers. We are missing the randconfig build jobs for the latter, so add them. This way for each container we have 4 fundamental build jobs: - defconfig non-debug/debug - randconfig non-debug/debug Signed-off-by: Michal Orzel --- automation/gitlab-ci/build.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a39ed72aac6d..d931441b910a 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -566,6 +566,18 @@ alpine-3.12-gcc-debug-arm64: variables: CONTAINER: alpine:3.12-arm64v8 +alpine-3.12-gcc-arm64-randconfig: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + RANDCONFIG: y + +alpine-3.12-gcc-debug-arm64-randconfig: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + RANDCONFIG: y + alpine-3.12-gcc-arm64-staticmem: extends: .gcc-arm64-build variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410154.653181 (Exim 4.92) (envelope-from ) id 1obMSA-0004pd-1F; Thu, 22 Sep 2022 13:41:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410154.653181; Thu, 22 Sep 2022 13:41:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS9-0004pR-TY; Thu, 22 Sep 2022 13:41:21 +0000 Received: by outflank-mailman (input) for mailman id 410154; Thu, 22 Sep 2022 13:41:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS7-0004DO-VU for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:20 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2078.outbound.protection.outlook.com [40.107.92.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3af48310-3a7c-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 15:41:16 +0200 (CEST) Received: from DS7PR03CA0217.namprd03.prod.outlook.com (2603:10b6:5:3ba::12) by DM4PR12MB5231.namprd12.prod.outlook.com (2603:10b6:5:39b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 13:41:14 +0000 Received: from DM6NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ba:cafe::d5) by DS7PR03CA0217.outlook.office365.com (2603:10b6:5:3ba::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19 via Frontend Transport; Thu, 22 Sep 2022 13:41:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT045.mail.protection.outlook.com (10.13.173.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:13 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:13 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:12 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:11 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3af48310-3a7c-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxxq3/G/+eaGEXQKi9kXlOn3HbCnDIzgD1ijoOkFXm2WOc1+FercXLkpPt4zDYuZvKr0/GJwKTgcDfpiy4y2bjudr2zuLYhLbjAlLigBWIS0jcX2b1QTOVKSIUgLcHbhvDQmyYzs5zcliyU4ZHHj7x/pN3+Z9LhuFy4M9MEZ4Ntm1Avoiw5iZ7WfQZVq505PMXiKzug/z1CXqIoz1a1rXujpLHO1TfjhqjrHyocMmP0enomp4wDQIUPypC4K5IOfj9/SbFJ1oJMs/h2n94oIdHpuLFk/QV99YHh9DIFcxpn/8SB0Il36r1GewRiJ3on2aUr2DKrHhAkN/79pTF9rBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CObcfLEMvCRWZoj8ShK1q6RkPuWESR5Ohvzwl8WyaUc=; b=n6dj76W3fv3w1jqBb1AWxE2SlCuLylLyv0LhaXnT3O3O0aR6aUy5nIiZ+EmtRKgWtvDivfiwCqU8WI7pKCgKf7oBp3mGwAP85hWdu0q0YU3K/xQPov1xqTi6YEu4lC5rQyTla67Ufls6t++Bqd4pems9zJizgFA/ar2rP8wZWIdzVuHhESybKXLHSHQGfekqL5m73G91S1dHboeY/iARGXH5FWSI5CoXjHYFRLveu6mxG9gylB7Y9BGcrYENm6GKmIcKJZ+KcI2mvcAWlBwJESl1xY+fmHQvw8gQqHSGWW2dnxoWNNiS6gUQYSCDoWxITkTrJ7Bmrpj4gzpYOXdu6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CObcfLEMvCRWZoj8ShK1q6RkPuWESR5Ohvzwl8WyaUc=; b=ox4zR/eZbvjmkLTnts0aJz3/u4t74WmgbcO+1/TixkbSqZZer1w1waBuOSFdZgM2K+mTgGJkv4BXLUgjVZtzF8ksNngyaJmjAc6i+AvDBZfS6Qau0sdGTqTwYNXKsGfWZCnQ/T/KWwX554LxyP18W1aYGlBf+IfU6BPYdgByL+Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 3/9] automation: Add debug versions of Arm tests Date: Thu, 22 Sep 2022 15:40:52 +0200 Message-ID: <20220922134058.1410-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT045:EE_|DM4PR12MB5231:EE_ X-MS-Office365-Filtering-Correlation-Id: 099d2bec-58b5-4b46-2865-08da9ca01dff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y9OC22kHakLaZMKKbDA/9QVEz3m8Ah2W5VQH42GO05iX9rMn2Z8FnHbHdfXbBYd2D7eih/dl7FMg4qcPOsKq0DMnGppn+CjrTUqP49jriBBNE1oSvkhqK+xEa9QG+1uCJRKOzmCbX55QAI1kHptoFwAqngxAlN2lX8l97lZeGdq/eytXeEctuHOWszuZLUa8Zcm6fMl6S9jeuRy1HlPCCUR+VW+4suODj3rRTb6HgNIQMsRieGhXp3MxnwLukAlH0tAFotWHM0E6UDAK54LYbflQ/zgq+M/Ys0dc0/6s4KJHv7SulTLGrolQoXbOFIwzbNFxMCdfmCcb+TVcHXZV0El669mJL8YmXtpwSvXIdwlBFmYSPjbK0zoJSNgqGDu8hu5x1uIYmAwLaH3l5y7pe4bdsqtJ9xcrA6n01DP9vi+TtT/qv/L6tup5XLsyAKoMmP0A0/vV5VvrZOf09AbYTZIOs0z59DqEUuc1AbNqsd4WH/pT3saCaQFAHlLwM279h2ju/tko1AzLs6YNxPyEu+HS8cprfjIpMfC+D1/9raZVXso/yZMYshcO+tzU376VI9sE2V+gE154VfVGZlbVHR7SM2wEm/Hj3M0LdvGU8p60f6A6LyCcG5GYOpK2ll70z2hQLzI8V5QsNulDiDI37K0O1LMJZg1Xj4vpr03uFkOtdVVIilYB/6KDxAd8s/P32zDUePXjAMIhGPWKoiq7EKhiuSYVcaxussHkvy9qVwnICSjqJnzgPuipf/DWZ/jV6NmN7YOOEOCZSBIDOh1+FVNRcFB0/DakNMzSy9i5dW6OhiPj/zxJpYSr1MIP81mE8cD5VttjAQyXZuWLxrULkTZ7bZ9k/eUbx95y0VXP7Oo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(478600001)(316002)(54906003)(8676002)(6916009)(44832011)(40460700003)(966005)(5660300002)(26005)(36756003)(336012)(2906002)(426003)(70586007)(70206006)(2616005)(4326008)(1076003)(6666004)(41300700001)(8936002)(186003)(47076005)(36860700001)(83380400001)(86362001)(82740400003)(40480700001)(356005)(81166007)(82310400005)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:13.7370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 099d2bec-58b5-4b46-2865-08da9ca01dff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5231 At the moment, all the tests are executed on non-debug Xen builds. To improve the coverage (e.g. we might catch some asserts), add new test jobs using debug Xen builds. Take the opportunity to increase RAM size for QEMU from 1GB to 2GB in qemu-smoke-arm64.sh as the debug builds take more space and we might end up in a situation when there is not enough free space (especially during a static memory test that reserves some region in the middle). Signed-off-by: Michal Orzel --- automation/gitlab-ci/build.yaml | 16 +++++ automation/gitlab-ci/test.yaml | 93 ++++++++++++++++++++++++++ automation/scripts/qemu-smoke-arm64.sh | 6 +- 3 files changed, 112 insertions(+), 3 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index d931441b910a..6ce92531f61f 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y +alpine-3.12-gcc-debug-arm64-staticmem: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + alpine-3.12-gcc-arm64-boot-cpupools: extends: .gcc-arm64-build variables: @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: EXTRA_XEN_CONFIG: | CONFIG_BOOT_TIME_CPUPOOLS=y +alpine-3.12-gcc-debug-arm64-boot-cpupools: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_BOOT_TIME_CPUPOOLS=y + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 4f96e6e322de..1b51030c6175 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: tags: - arm64 +qemu-alpine-arm64-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-alpine-x86_64-gcc: extends: .test-jobs-common variables: @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: tags: - arm64 +qemu-smoke-arm64-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm64-gcc-staticmem: extends: .test-jobs-common variables: @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 +qemu-smoke-arm64-gcc-debug-staticmem: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64-staticmem + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm64-gcc-boot-cpupools: extends: .test-jobs-common variables: @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: tags: - arm64 +qemu-smoke-arm64-gcc-debug-boot-cpupools: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64-boot-cpupools + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: tags: - arm64 +qemu-smoke-arm32-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + needs: + - debian-unstable-gcc-arm32-debug + - qemu-system-aarch64-6.0.0-arm32-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-x86-64-gcc: extends: .test-jobs-common variables: diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index f803835779f4..dea26c6c0a8f 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -52,7 +52,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -smp 2 -display none \ + -m 2048 -smp 2 -display none \ -machine dumpdtb=binaries/virt-gicv2.dtb # XXX disable pl061 to avoid Linux crash @@ -117,7 +117,7 @@ cd .. # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt-gicv2.dtb" XEN="xen" @@ -158,7 +158,7 @@ timeout -k 1 240 \ ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -monitor none -serial stdio \ + -m 2048 -monitor none -serial stdio \ -smp 2 \ -no-reboot \ -device virtio-net-pci,netdev=n0 \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410155.653192 (Exim 4.92) (envelope-from ) id 1obMSB-00056z-AJ; Thu, 22 Sep 2022 13:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410155.653192; Thu, 22 Sep 2022 13:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSB-00056q-5x; Thu, 22 Sep 2022 13:41:23 +0000 Received: by outflank-mailman (input) for mailman id 410155; Thu, 22 Sep 2022 13:41:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS8-0004DO-Vq for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:21 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2045.outbound.protection.outlook.com [40.107.220.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c14dbd5-3a7c-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 15:41:19 +0200 (CEST) Received: from BN9PR03CA0190.namprd03.prod.outlook.com (2603:10b6:408:f9::15) by CY5PR12MB6225.namprd12.prod.outlook.com (2603:10b6:930:23::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Thu, 22 Sep 2022 13:41:15 +0000 Received: from BN8NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f9:cafe::65) by BN9PR03CA0190.outlook.office365.com (2603:10b6:408:f9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18 via Frontend Transport; Thu, 22 Sep 2022 13:41:15 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT088.mail.protection.outlook.com (10.13.177.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:14 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:14 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:14 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c14dbd5-3a7c-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNpkkAz/BiqTXZsPbfiJ1Lj5EHooMz9h2Faw3mliwvKogbBO6pUlPtSORo6nM5RXZXeBbZn8alBPrA63ksrCX0mwpMwDr2E7WkfdJpoEeK1SlKU1jvXkQqS//Q3gkBhAJuFIBG+gmGnuajLvmRzjcQf1pRzZefujUDERuA+LtN4oM1HrFMTAq6y9+h3YDV4lkcZSWhleCGKLG4recWkV6GNGQe8Ul5BO2PXZX4qaqfcGX9y1ZTAeNP7ed927BNZ+bE0Dw5zJxH/tPjn2uecQs8hEkJv5vVUIXWWZRhen0NGdgJmnr2XaWzG87OMXgR84P24EalUDRm+wDyRIc07x8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4r2IqG5noer3R27Px3k/yK/ec0pnYo0SQkuP5is3Mt4=; b=X7KGUkr7avVzl6qe2wGWCbcZMCU9DIhbeRXff2syhi5hqVKsQQOBl7I0OHmJob4R6a08cruQ/DZy99I21UKFYy1kp95Q+KL0ayaOUlpZFb0gPsErshvdQLk+s0xMHPISsVAp7LnLqKp1ZBSbi1BnlKtX9SaLylfHLQO/DyHOYdiFZa47ZZpoInZZQ6Jq4ZNzzIZFWMk1BJgzjxxGYJ/wJcKiosceax9sebMc2nPCF39xTMZlEJbrfej2ujhOj3ZCCzcAQQWyJB+OYVBx1lGsSS+He8DcJZoBfvzrw+ljkybHjLMky4bv+FUSId/ACcPkFDfnQl1eV3LWjQKxxFsRkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4r2IqG5noer3R27Px3k/yK/ec0pnYo0SQkuP5is3Mt4=; b=Q5D+HyiRXhgKhYTjqrVYBLriiG9UtWP64IIUzTFJ4kYIOYL8066iKaLRRP55ZLJIUV59+I9jn+NJyOmpIIZfhsmpCA8oZsQh6aRcVUecDokgL2KYq/gS1pzlHAx0aUjxqpMI5V7srvDDcrTtDtNNTdBOgZpQ6f9AqqNcf9FQ/XI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 4/9] automation: Add Arm containers to containerize script Date: Thu, 22 Sep 2022 15:40:53 +0200 Message-ID: <20220922134058.1410-5-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT088:EE_|CY5PR12MB6225:EE_ X-MS-Office365-Filtering-Correlation-Id: ada0dd3b-f784-4ab6-7bd5-08da9ca01eb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: azcwZdwOPJYc5TPdwawEdEdb1tDuLeRDvywFi8pzc9eue2rbAfDcxPUIyB06pwLG4uhDYm/uIuZf2f8JshBQRadPEKR68Jz9h98dCFSzpyQfAB1oeZ0/r5M0aolF2BUVbE9DAudZxXfqpXGViBdMxu9WDkknNhYpmbLnE7V3DDCUsNHKTM+wY2KhtlHfQgZuExDcNnSmSvu7pGSU3UI+n1iwclN8iCVCDq/w3qntZ9xuJNMAyHrR5TP7XA6w3iIgPBFRBxSs5LfQs4mNknN3BuJyO9dRSO+btEWIeX6IdWA4oWEZ1vhFRO5pmkVVZGOd2IhV54bmbYvyjTuZJPWD1IMdLbGPdN1Bdoting5TiiUkyzfEGJirsWJ60eVziBlTxyK1nKgorxZwfbKItOgNlJuzqzyuHFOW2pzQr9ob8ED5njeehPKrImTgRNUxsueRg2dpBooXOO+fZ+4TfkPudJhpzU+7R9SlS9v7fRJlMJdNXIe4xYotM+r9g5qlINAbAO4sDiInJPMq/XkE2wz3SKGp8NWG4rpDcTjOD9+t1dNUbLNp1byChBBHdkJYP84b6vDYh4NtQNU8HX6Uig0tBLpKyiNlhEdrAz5bOxTQ3LbPjuoMVIjlCac4giP8nHDRL/if6fXj1DeTPirikpycHUho1TZ5D27n/gVDGOkCfYoyTm6ZztMzK3RH5UetSjkSgSJeO/afdx0Z3ZbIqTpm8kywx2cdVrPainwjEFDSrYD0zniBD6Gi58gy3d4GqQY/Z2jZ1P2kqUjzHSok2gGWcf1T3sUp9usG3G6azubweZYI0YRzteCAhlbEMk8W7Z0X X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(44832011)(186003)(1076003)(82740400003)(54906003)(26005)(47076005)(6916009)(81166007)(356005)(82310400005)(2616005)(426003)(336012)(5660300002)(86362001)(40480700001)(8936002)(4326008)(8676002)(6666004)(41300700001)(70586007)(2906002)(36756003)(316002)(478600001)(40460700003)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:14.9632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ada0dd3b-f784-4ab6-7bd5-08da9ca01eb5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6225 Script automation/scripts/containerize makes it easy to build Xen within predefined containers from gitlab container registry. However, it is currently not possible to use it with Arm containers because they are not listed in the script. Populate the necessary entries. Signed-off-by: Michal Orzel --- automation/scripts/containerize | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 9d4beca4fa4b..0f4645c4cccb 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -25,6 +25,7 @@ die() { BASE="registry.gitlab.com/xen-project/xen" case "_${CONTAINER}" in _alpine) CONTAINER="${BASE}/alpine:3.12" ;; + _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;; _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;; _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;; _centos7) CONTAINER="${BASE}/centos:7" ;; @@ -35,6 +36,8 @@ case "_${CONTAINER}" in _stretch|_) CONTAINER="${BASE}/debian:stretch" ;; _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;; _unstable|_) CONTAINER="${BASE}/debian:unstable" ;; + _unstable-arm32-gcc) CONTAINER="${BASE}/debian:unstable-arm32-gcc" ;; + _unstable-arm64v8) CONTAINER="${BASE}/debian:unstable-arm64v8" ;; _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;; _xenial) CONTAINER="${BASE}/ubuntu:xenial" ;; _opensuse-leap|_leap) CONTAINER="${BASE}/suse:opensuse-leap" ;; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410156.653198 (Exim 4.92) (envelope-from ) id 1obMSB-0005Be-Ok; Thu, 22 Sep 2022 13:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410156.653198; Thu, 22 Sep 2022 13:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSB-0005BB-Jl; Thu, 22 Sep 2022 13:41:23 +0000 Received: by outflank-mailman (input) for mailman id 410156; Thu, 22 Sep 2022 13:41:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS9-00041N-6j for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:21 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b0d72e9-3a7c-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 15:41:16 +0200 (CEST) Received: from DM6PR06CA0089.namprd06.prod.outlook.com (2603:10b6:5:336::22) by BY5PR12MB4260.namprd12.prod.outlook.com (2603:10b6:a03:206::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 13:41:16 +0000 Received: from DM6NAM11FT083.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::c2) by DM6PR06CA0089.outlook.office365.com (2603:10b6:5:336::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19 via Frontend Transport; Thu, 22 Sep 2022 13:41:16 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT083.mail.protection.outlook.com (10.13.173.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:16 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:15 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:15 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:14 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b0d72e9-3a7c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXwFV9b7jm53IhavgXFoJe2v/MUicrXSzR/XjI2blRyas2vxUTByBZuLq+5pgFNroxQoQ8c9KSVRcuhBqheJaCCWOMQFPUf8qYhFxJV89hnGxj17ClFBitxsYh70cPVhQ29wizYUcSgYipsLG4k/01ixq08ZMatv+Mt4SgCvhFw48chsZV4cLEZP7ttYtYwm0uKCe7IYvTfg+Jtp9Dhj2pTwbChIEZOZPiH+5U0KIGmnBuh+CWjoXn4P7NYI9pM1mFjI8Ndpo3jNi0ssGYXHbVWzG3xW9jt1nCWYsCF8hymUQeWlmmMeOASa00rSsgtXDJpO7766gkK0AoijfCh1Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oAgJkBVaGriE7CRBKSX6qVx0MliKnRqb2WGUchdghAU=; b=TrK5YAY03xPYc2cEKC0I74WYCnKYf/oWYOKirpzW/foT+aHurkkeUdyuitzQY89G8XruKpGZalx2vSK0g6893FMeND9mKlyBI5B7MYEitHMoeLokdsYmffVR0CvOiVOSs8lpFKM+/uRjn6Tzn7zQyjizAEKmMMfPxi/19rFDCKo6F4LeLnMC8qH73kUQEb3R5cOdqsnEW5blpLeSeSMjFUznvUa/C0uaM8CWTwZiZ2Sx0NkDXtnik3nvIb62FwXSa4xmtNoJEoAQu6SCtOl0ajD/RjVZAthyZrL/j+GcAkS3qRpd43xuq39zQcVjPMl/w7fnAYCIYfLRUpNMcrnTtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oAgJkBVaGriE7CRBKSX6qVx0MliKnRqb2WGUchdghAU=; b=1H5+Y/I6n8uVxu6jQNnR70u8rvb8EY/3JIe4HMxfGfOPW11Y4bPEOwWMFndWQiF8pQ+CPd4ZVArp/kJj9bC4hjZLcdbdwtvJwSmmjDOEVfExlYfrEvWcorMB1lG3E4bZRbTU+U+oFjnP2d7/LdNZi1qPx/5/w5q3bhwBW2pFb4w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 5/9] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Date: Thu, 22 Sep 2022 15:40:54 +0200 Message-ID: <20220922134058.1410-6-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT083:EE_|BY5PR12MB4260:EE_ X-MS-Office365-Filtering-Correlation-Id: bb365dbb-009e-4372-9218-08da9ca01f93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x3HvvWdB2uyQRM8YsDrSsGWFAVMJJX+pJxeq/9pH1tsrJh3ip/sMwPugjam9WCwK+UPPtQ3KsKJ1uvFuy/xHlKFv6p1FiUDbGdNGGt+Wmd9l88c3RGzi7mNV+8/ggTnoVuaWVO5N4WdBTgTQOdMgFScHy50PZqr0BIOwx7c+zu8HTkQ3eEjgjN9Ap+Zk4wOzDEfnGwHhMyPPkniey0sVvPWGrCsKT33ZuookznlUy2PLkQgWl6LcfZjkElCHTkNfRsOtkQUhrVwm5AG5sE29DPUJOMJJa6R/85LsOFXxLExBnbUp5+UUQRmFRl18zHjavVOEQjuJqWYUrMbP6zB9zlqK/fEyRCkDji50M+9txel4sSj8h3ldOG8G5TP0AzxISHZ/ChkPfljj90R0JsqOa9qdgfA3Zly9QXkIQwfusnq+92MeJczBpoLdICWI3nU0YhBdDh6K6HIMc1i/kFamEUhVfB2ZAS8RrcRY82abGtVtHdCCSUX3ZPAsyZ1DunWhlPTHRsqujJp5xOJD9i843QJ3aoNxrpOaRkJ8awCtG86eNLdFUjB1HPjsU9LS/mJleteUoEzECS6lXU1kKzmM3/v+SJBhRvQNvlmqjXdxU02jJoibLA+9Zqf7F/pOVAGQZDeTYxVc4wtWOawLbrKSMU0LOeWxQtGWTwlFF+sdD8M9+4EGtPvolHi2a4rFEB/dLIHIqlEnE9k7uEtmCaXcgyq/Rpt564P57V4fEK1s6MYpoX+zNz5mCeQXfFN2evseeOqj25OpYhCAvN664UMmtqvXJGGXo+y0MhEVrawq5HCckpvK/B0/6RAD1FxUdRLtb9YyMwNOgFHFwYSIYJYJCotpMsIHJ8rfnRp+i3OB6G3U5Qlv83IlcZWh3fY73mC3ncB6OEayEVeZswN38We7rSGyesYH7Tu9DTH/+Xg7CcU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(26005)(4326008)(8676002)(70586007)(36756003)(44832011)(86362001)(41300700001)(426003)(82310400005)(6916009)(54906003)(5660300002)(2906002)(316002)(8936002)(47076005)(356005)(478600001)(40460700003)(966005)(6666004)(81166007)(82740400003)(186003)(70206006)(1076003)(2616005)(336012)(83380400001)(40480700001)(36860700001)(21314003)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:16.3718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb365dbb-009e-4372-9218-08da9ca01f93 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT083.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4260 Take an example from arm64 qemu test scripts and use ImageBuilder to generate u-boot script automatically. Calculating the addresses manually is quite error prone and also we will be able to benefit from using ImageBuilder when adding domUs to this test in the future. Install and use u-boot from the debian package. Modify the script so that binaries are loaded from u-boot via tftp. Signed-off-by: Michal Orzel --- automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh index 530f3892fdd3..765facbe4d66 100755 --- a/automation/scripts/qemu-smoke-arm32.sh +++ b/automation/scripts/qemu-smoke-arm32.sh @@ -4,7 +4,9 @@ set -ex export DEBIAN_FRONTENT=noninteractive apt-get -qy update -apt-get -qy install --no-install-recommends device-tree-compiler \ +apt-get -qy install --no-install-recommends u-boot-qemu \ + u-boot-tools \ + device-tree-compiler \ curl \ cpio @@ -20,10 +22,6 @@ tar xvzf ../initrd.tar.gz find . | cpio -H newc -o | gzip > ../initrd.gz cd .. -kernel=`stat -L --printf="%s" vmlinuz` -initrd=`stat -L --printf="%s" initrd.gz` - -# For Xen, we need a couple of more node. Dump the DT from QEMU and add them # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./qemu-system-arm \ @@ -36,31 +34,31 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -display none \ -machine dumpdtb=virt.dtb -dtc -I dtb -O dts virt.dtb > virt.dts +# ImageBuilder +echo 'MEMORY_START="0x40000000" +MEMORY_END="0x80000000" + +DEVICE_TREE="virt.dtb" +XEN="xen" +DOM0_KERNEL="vmlinuz" +DOM0_RAMDISK="initrd.gz" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" + +NUM_DOMUS=0 + +LOAD_CMD="tftpb" +BOOT_CMD="bootm" +UBOOT_SOURCE="boot.source" +UBOOT_SCRIPT="boot.scr"' > config -cat >> virt.dts << EOF -/ { - chosen { - #address-cells = <0x2>; - #size-cells = <0x2>; - stdout-path = "/pl011@9000000"; - xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0"; - xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh"; - dom0 { - compatible = "xen,linux-zimage", "xen,multiboot-module"; - reg = <0x0 0x1000000 0x0 $kernel>; - }; - dom0-ramdisk { - compatible = "xen,linux-initrd", "xen,multiboot-module"; - reg = <0x0 0x3200000 0x0 $initrd>; - }; - }; -}; -EOF -dtc -I dts -O dtb virt.dts > virt.dtb +rm -rf imagebuilder +git clone https://gitlab.com/ViryaOS/imagebuilder +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config rm -f smoke.serial set +e +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ timeout -k 1 240 \ ./qemu-system-arm \ -machine virt \ @@ -70,11 +68,10 @@ timeout -k 1 240 \ -serial stdio \ -monitor none \ -display none \ - -dtb virt.dtb \ -no-reboot \ - -kernel ./xen \ - -device loader,file=./vmlinuz,addr=0x1000000 \ - -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=./ \ + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial set -e (grep -q "^/ #" smoke.serial) || exit 1 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410157.653205 (Exim 4.92) (envelope-from ) id 1obMSC-0005NZ-Di; Thu, 22 Sep 2022 13:41:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410157.653205; Thu, 22 Sep 2022 13:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSC-0005Kx-7k; Thu, 22 Sep 2022 13:41:24 +0000 Received: by outflank-mailman (input) for mailman id 410157; Thu, 22 Sep 2022 13:41:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMS9-0004DO-W7 for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:22 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2061.outbound.protection.outlook.com [40.107.212.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ce1f13a-3a7c-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 15:41:19 +0200 (CEST) Received: from BN9PR03CA0189.namprd03.prod.outlook.com (2603:10b6:408:f9::14) by BL3PR12MB6474.namprd12.prod.outlook.com (2603:10b6:208:3ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Thu, 22 Sep 2022 13:41:17 +0000 Received: from BN8NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f9:cafe::e4) by BN9PR03CA0189.outlook.office365.com (2603:10b6:408:f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19 via Frontend Transport; Thu, 22 Sep 2022 13:41:17 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT088.mail.protection.outlook.com (10.13.177.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:17 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:17 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 06:41:16 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:15 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ce1f13a-3a7c-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vt4KOlHJAS9iaDkANyHSTnKDH6+L0usSGCNRJiwo+nJaIDnqe9D1qDQM8/SpXMJeU7Dc3EOG5OHhsqsX1PImpcTKtDMNHtxI9w6geCdTCOIiYpmbOeeky+PioW3kXqsTfNFLHuLu2emtppXIKtqHHfqKrdLOIknVIUolT+bn0QldtXeRNEq8nZ2vjw2Wfk0o1t/IRRFVS54GzjSIhIn0l6Ycbn3xjDEefnghCQxioOgRmi2Bn0GZZpFipuOcYIJbeyRgm4bse9N7PxTttKl/+ep21pLDPqk8H5uWr1FZ/32grFqeuPVGo5ovVDfrJavssLO3hgKZPmaJ6fJJTLbEBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oj0Jye2TY14wGofloU/Wk7Zk6VQgePIK69TIoc4uMt4=; b=AiOV4U8lEi0x4qYGlInNKZ+LC5bcYe+DmmlrEHZuZCsHN3LG+cnf63TpQ4Y+KMLCGa0VQVSjR1GefYf1rcA/HFWkSK06CWdqbH7o63G33khH9ce0w9gysB6uufSZLr5+yiWGqOa+8xyOdlqKK1Jq/c8ufrvXbXwVNOhkok/C/WPHudohmOqAsNusiOLJUKKUbiBTOL4y7LEyqKeUD0+ip5PT3NcSJ7kDsvWTDPPUFHJu+DJrzL46BN/V4ccOjBKP02Tdk0sJDfC3XDb4alYLUhzL7B9EDj9wA8sFSOOL5l4pXqzBajTMZMEvbud2BdHSKekew3Q1X8020U/iSkuGmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oj0Jye2TY14wGofloU/Wk7Zk6VQgePIK69TIoc4uMt4=; b=qGOqMD8q3oP4w9iDEh1zv2z33B77R7Yo3nlN9ZEgSpS1f8RrP6NJVCq9pr8nfxH8i7wSC+UXgv/zs07f3/BF0TOY+2FjBetuCduAnv0kG5Xe1oRLXRiBS/N+1PdbKU8YKft2O//O7K+sFxLCdpR+aHhwAHMzrIr8E7ea0PaMBXg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 6/9] automation: qemu-alpine-arm64: Cleanup and fixes Date: Thu, 22 Sep 2022 15:40:55 +0200 Message-ID: <20220922134058.1410-7-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT088:EE_|BL3PR12MB6474:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c2ffa87-a8b1-442d-b167-08da9ca02037 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FuMNJ0vtmgrfYOieFi0CHMg+t2HEcA5Sa/Gf4TjLp0k5geelq9TT3wxbBl35aN57GgcVNkJqD5DN6pZC0jEI/KvGVcwkqeTap25iQettNYuJAgngSSazqzYDAG7Ub9k0wnjvBQ/yDiVYvD56V8QOb+L+KcDZhyI7e6ZF0nNNr5KIuOui0vf+U13CwWLPeyMHlyHhg7l1EW5ZqpLM/6s/KQd3gh33ZAsww0TuLp0j6bZvQD6OCLfeEvrKlnjcxDBMY9r6V3NTtdkLbO6+xOR5vTm9o8ihOZLXkV9LA9LrgISje/q4yoc5c3pX+WdodFMGlVyE418KTuLtVEexvledr68mMXnV6weAmEPZI0/hwap2IrVPfQhqULOnABw8yBJNi0Ba5M2YDjIPMBKMuEYbNsYjbZ5Cv8KUAi8y70CMt6QFFkzC3FcSpx4kZsGJprZKdusvi6h82ix2M4pq6lOHfBjGSABknSCF0K8EGZjRr0AH34o0FoNN/+j/mQ3/ys1K3VxsVvhqUaNgkhC8U0LBtPcqXWNGmyXc8DlsVfA7u0t+FuZ/V+TfUUl11GMdrkZjf8IhoGjurRAe5dn5aWNobjI6L8FOnuS3D0T5zZyC9024sx22SCUXBDztjXoNmHd97mxgteP3JRPb5cN04qg1o5xFerVz/KRrR3BCdMFL7WwBuXv974qMGpbRSP5trFtaioE8XOVMJJNLyRSMlyACNjCoYwreufG2DSPSXDoxhaZbM6qmBhz/hMxWABD3f+8Gkm9GlOKQ99jt/sVr9baDh11D45OcBtUKVM2gKqvtBWnyJK9RHY6Py7Oj5o96bhXDzqbaW6o6i0oF4EQb83H6aIqHzBnytIsAkr3ERofh7gA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(36840700001)(46966006)(40470700004)(2616005)(26005)(5660300002)(81166007)(966005)(478600001)(44832011)(2906002)(356005)(36860700001)(40460700003)(82310400005)(86362001)(8936002)(6666004)(336012)(426003)(83380400001)(47076005)(1076003)(41300700001)(40480700001)(6916009)(82740400003)(186003)(316002)(70586007)(70206006)(4326008)(54906003)(36756003)(8676002)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:17.4942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c2ffa87-a8b1-442d-b167-08da9ca02037 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6474 Perform the following cleanup: - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version used in this test is v2, - use fdtput to perform modifications on the dtb, - use DEBIAN_FRONTENT=noninteractive to prevent interactive prompt being stuck waiting for answer other than "yes", - fix the number of cpus in the device tree because currently we generate it with a single cpu and try to run QEMU with two, - fix the memory size we pass when generating QEMU device tree as it does not match the memory size with what we run QEMU. Signed-off-by: Michal Orzel --- automation/scripts/qemu-alpine-arm64.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-alpine-arm64.sh index f4ac2d856fa0..7b52d77d3c84 100755 --- a/automation/scripts/qemu-alpine-arm64.sh +++ b/automation/scripts/qemu-alpine-arm64.sh @@ -2,6 +2,7 @@ set -ex +export DEBIAN_FRONTENT=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ u-boot-tools \ @@ -73,18 +74,17 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -display none \ - -machine dumpdtb=binaries/virt-gicv3.dtb + -m 2048 -smp 2 -display none \ + -machine dumpdtb=binaries/virt-gicv2.dtb + # XXX disable pl061 to avoid Linux crash -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" -DEVICE_TREE="virt-gicv3.dtb" +DEVICE_TREE="virt-gicv2.dtb" XEN="xen" DOM0_KERNEL="Image" DOM0_RAMDISK="xen-rootfs.cpio.gz" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410158.653213 (Exim 4.92) (envelope-from ) id 1obMSD-0005Wd-2V; Thu, 22 Sep 2022 13:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410158.653213; Thu, 22 Sep 2022 13:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSC-0005V0-PN; Thu, 22 Sep 2022 13:41:24 +0000 Received: by outflank-mailman (input) for mailman id 410158; Thu, 22 Sep 2022 13:41:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSB-00041N-F8 for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:23 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c627172-3a7c-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 15:41:19 +0200 (CEST) Received: from DS7PR05CA0035.namprd05.prod.outlook.com (2603:10b6:8:2f::18) by CH0PR12MB5123.namprd12.prod.outlook.com (2603:10b6:610:be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 13:41:19 +0000 Received: from DM6NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::a8) by DS7PR05CA0035.outlook.office365.com (2603:10b6:8:2f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.7 via Frontend Transport; Thu, 22 Sep 2022 13:41:19 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT049.mail.protection.outlook.com (10.13.172.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:18 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:18 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:18 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:17 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c627172-3a7c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nj1bYLM4cL7qGRtuz7ajqF39O6V+PQn5H59rRVoNF3/ePaY4egyDZH4n5RsuKL7YZLT2NYOWNfbqRzwW8EctU8QNkIGJAVaUXYOtDj8CidSKz/10Dnw/iIzlAUFMxDhiqYZm+uc6ArIyN+ZLuK33hq8P75ejkwPD3CHZPSVsEc5iZCKTn5o6O0WBjcTh6p5oB80vo1vnAegcqJqOSmPZBHZgM5iJ+xuuFi3BSTvBn35g6btrOpcoxuwWBkTVrpNjiIfTn8ZzbqfUU2ztTKFPGEOT/HPQoMKRvU5C/rMB0HcoOQT7s1oKpLIWCL8hqsJJD+ICtuouEyESLMcOidIxMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FKNU8RodtxiS9iEytnYZZrKwRk5SeAtglDgJxAkPQy0=; b=ltY3hsrIbDZll8M9dXH37YgQM1t0g7ydd5Ub0is793MIzLIPyO+tAUWx/FV6jaAY+wvytcEniZzzKTuk6sh8+yK0x0Rkp/BTLwooPGqzyf/QxbdBWrs0oshJOVNjpDU9XKx7OWgD4cY337xEabMKgCfHZRpItPgXGukLKKs4rQr/ZdhQvcVHLbTm+Ug/b+sF2ioJ2GxbWOVg8k0FW948qIxyxzJESRT3OvRKKe13l2Se1ECKHaym1LC9lKvyq79FJTaVkhnFjCDWLsSF1MZDbu7PAMCTJP+RNmUv0sAt8ncjNupYZi5JshBIOoN9DD3X4ymvfl/vSU16wnGyodhsKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKNU8RodtxiS9iEytnYZZrKwRk5SeAtglDgJxAkPQy0=; b=BavXqMm0hTdJNfbTprtQp6kcNlZ6QeNk7oEyLYZTLKf7SkbosBJJwZNEZdyaUeUuLYeg++R/EEOtg5HmpMYmlnDSoXZilUWPOFacLp+PA51QZjMGb1LXH+m13fIdmcDcrHrpn6pl+aUMQ0+Q1Def2g1nX18u8xIuruCIOuiTQIw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 7/9] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Date: Thu, 22 Sep 2022 15:40:56 +0200 Message-ID: <20220922134058.1410-8-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT049:EE_|CH0PR12MB5123:EE_ X-MS-Office365-Filtering-Correlation-Id: 110b979b-dd79-481b-2a92-08da9ca02118 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ziSjeD10SDEkBH7Gf9m0sGpWF18Ih09pFO/RkWSyD62K2exE9Ak33pjWWS0X80sLN/7uPW3M+N/DRA4sp9dGHO0G5BkP7zXRzh2iV5ok07GkzcTAyug9TO7Uork32xKUQfqbUBZg2A4hUHmnVUyvYrFWq5qkVE1w0FChGTWJuUfvHgb//JurffZKJEG+lh/nC8DJjiIi4Lq1oFM/zevhHZMGbhtr84XTumZsDv7/Qa3v6VAflsbzg6OfydwYTqZ9xypBkjNZbDj/d5UTmG2LSSejNk2zFqbdOJPOs1e6cLzjpqXGT8btdxVX8WA6EpG6rx81Z0gl0yr2IRBxz0Pn314XePNmcqFMupphISYhA0PWU2dT8u+TySMtmL3kJDrJzqNyqa/6AIfejyBu2BWx1VJO/ja8prK5AKFn4LDpROZ/2rFxMyWxJ+4JWgt2DbtSljJF/li8gXeS3lB+zlYVKSS76VbAkPM16iQG7PL218S9pdeovzSZEOWrCPY/cBWVPyVBmYnz8H0hCVQt1o97ffgoCFDRDsv0Lj/Efiuqb+sKSkpZJOCgE3cBoJlU5u1FskKH0IeOMfUQhuZadTkK+0NM1UPxa1BAaEtrJxN0ExHILIwsWmlA9TjVM8qTOUOeyTd1zDdMIJR1nZB42/sViemTaRfNERotpWgxPrPBNQgO8cxPsCnq66R1WUi1rA5dlohM0Jv8vn5Gknm+ziSCkkjI1IGlGe9NWmxUYL7ySoNKtV3QWyW71FgZTO7xKYJfHm1anlwXjK/hoZyXGEUjZRfazfbI0PCpGjmdIiNWNwDTVLC/zW+8/sw5uu+9KS2x X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(478600001)(36756003)(5660300002)(6666004)(54906003)(2616005)(316002)(40480700001)(26005)(8936002)(36860700001)(41300700001)(40460700003)(86362001)(8676002)(82740400003)(6916009)(2906002)(186003)(356005)(47076005)(83380400001)(44832011)(1076003)(336012)(426003)(81166007)(82310400005)(70206006)(70586007)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:18.9341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 110b979b-dd79-481b-2a92-08da9ca02118 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5123 Testing arm64 is done using the qemu-alpine-arm64.sh and qemu-smoke-arm64.sh scripts. These scripts are executed with exactly the same artifacts (container, rootfs, kernel, qemu) and the only difference is that the former is used to perform dom0 based testing and the latter - dom0less based testing. Because the current naming is quite umbiguous, rename qemu-smoke-arm64.sh script to qemu-smoke-dom0less-arm64.sh to reflect its usage. qemu-alpine-arm64.sh will be renamed in the follow-up patch. Signed-off-by: Michal Orzel --- automation/gitlab-ci/test.yaml | 24 +++++++++---------- ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 0 2 files changed, 12 insertions(+), 12 deletions(-) rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 1b51030c6175..f620622671f8 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -81,12 +81,12 @@ qemu-alpine-x86_64-gcc: tags: - x86_64 -qemu-smoke-arm64-gcc: +qemu-smoke-dom0less-arm64-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export @@ -100,12 +100,12 @@ qemu-smoke-arm64-gcc: tags: - arm64 -qemu-smoke-arm64-gcc-debug: +qemu-smoke-dom0less-arm64-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64 - alpine-3.12-arm64-rootfs-export @@ -119,12 +119,12 @@ qemu-smoke-arm64-gcc-debug: tags: - arm64 -qemu-smoke-arm64-gcc-staticmem: +qemu-smoke-dom0less-arm64-gcc-staticmem: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64-staticmem - alpine-3.12-arm64-rootfs-export @@ -138,12 +138,12 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 -qemu-smoke-arm64-gcc-debug-staticmem: +qemu-smoke-dom0less-arm64-gcc-debug-staticmem: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64-staticmem - alpine-3.12-arm64-rootfs-export @@ -157,12 +157,12 @@ qemu-smoke-arm64-gcc-debug-staticmem: tags: - arm64 -qemu-smoke-arm64-gcc-boot-cpupools: +qemu-smoke-dom0less-arm64-gcc-boot-cpupools: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export @@ -176,12 +176,12 @@ qemu-smoke-arm64-gcc-boot-cpupools: tags: - arm64 -qemu-smoke-arm64-gcc-debug-boot-cpupools: +qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh similarity index 100% rename from automation/scripts/qemu-smoke-arm64.sh rename to automation/scripts/qemu-smoke-dom0less-arm64.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410159.653236 (Exim 4.92) (envelope-from ) id 1obMSG-0006KY-BX; Thu, 22 Sep 2022 13:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410159.653236; Thu, 22 Sep 2022 13:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSG-0006KD-8A; Thu, 22 Sep 2022 13:41:28 +0000 Received: by outflank-mailman (input) for mailman id 410159; Thu, 22 Sep 2022 13:41:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSE-00041N-6V for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:26 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3dfca9ae-3a7c-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 15:41:22 +0200 (CEST) Received: from BN9PR03CA0522.namprd03.prod.outlook.com (2603:10b6:408:131::17) by MN0PR12MB5953.namprd12.prod.outlook.com (2603:10b6:208:37c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Thu, 22 Sep 2022 13:41:21 +0000 Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:408:131:cafe::c3) by BN9PR03CA0522.outlook.office365.com (2603:10b6:408:131::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19 via Frontend Transport; Thu, 22 Sep 2022 13:41:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:21 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:20 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 06:41:20 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dfca9ae-3a7c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bimp4zBtzmivG4cQ/xKrNV99iVEuasxhu2Tul4Ew56tnzVUMC20l6uQ+gS9ukmV8RE3F77DsBDS87f+H433CYZk5eVxcHJiQVr8DhG3A9mgHeX4WIX0EduQAQD+WNIiEl3NSFj0mnElrg/twy65jvmJ+Sm4uKZUQ8FK4grUehA6G6zloYa2SH1Zyl+HR5bgknnzvOpVYKTipsGNfBPp11RHbnMu3SZIeAOhNyl+T3dchlAIvpTUfED0dG49mjfGfmbm5TabPzqjDc6xN/uoAfbiz64XzO/TQdiGgFVTxfGZLm4vB0V9CyBJ34YXFv2/It1qZXFORxGEtQqK5xVXiWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=USlAysPSixVlzaMaeXTCZzefvXfPQQ4YYGx5V3R9wz0=; b=WXk9j6JlW5SNaBWzno4z4pBhcMsL3aKe626TsX3pEzimA6a/e/NNYGxpp0JcqqZjBf8VtSOlZUKLlf2uiDhpr5kqrvmN11L9MXZp52tAXTVUFwtWKt+jrxXe8V18q+mQ6y73PnMOmCiVpnyn+cGGbk9PjJY1+UubVVfyCAWHPCAWQegmHFr7pLcKqPmCtNcypy7SzIiovM8WpzJOGI+PTknZvNiepJjvlf/RIzd3pUI5wdLGaeMPZ3XgPHDDB2yga4pOO0CXjVqZcOd2up12xNUnV+YZwgFB+npubQUUDKB7wCSOHL2tkNaWGWF3297S+g9Kbaj+pwqnECMq/ZGhFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=USlAysPSixVlzaMaeXTCZzefvXfPQQ4YYGx5V3R9wz0=; b=D9nu4h+isNkPLIARpdOarmCgtKiQ1i3XWf/C5spPSkMgTWaSCJF7T0VQ50iGA/a5Iv1LGUVwXBCwcJmT6GgxVctcFGdQRDKWQT5j3AjNab9qAQ8DoKt+RgdPQrwlscnPIc+fDSNtW4J4icr+PVYS+kGszU8I9vkWz/JJ0dxkIHs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 9/9] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh Date: Thu, 22 Sep 2022 15:40:58 +0200 Message-ID: <20220922134058.1410-10-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT022:EE_|MN0PR12MB5953:EE_ X-MS-Office365-Filtering-Correlation-Id: c627175e-5963-4af9-9651-08da9ca0228d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 57pzt8Z+e/2EYa1nBLAs4PFNNx1i1yszAzDHKgR6XPAhRZZSje1q3x3laF7eEvvEPuNg1q+3t2DJ9VSPxn+3/q5fn6R+uqaViJwsB0440kfMeeMMAZAPSKel0UTUNSOcEI9wutxP+xo1kmI9VURsp8tWJPQpMrtihwzoImaloIejACyXoVemJsiQY9H+i1D3F82cYLipE3oqHjVK4S/yMnt4Jrb8663HsR68Vsjt/8lOX3aIdifa/tG4hGLyY6t2x7T8e8L3gj7vuvqfRns50R+GgVemWstDdWARpycGgOjmnbOVSQJ0weVRWHF3mC6K910Sdya/buHL+YKuqZbNx00/MpIyJDQ7A6lBXdSRgvvUMkBp5DYOdQvNe+mg7fumw9cC2+taP7htsK42augG7cF8s/QzSnV3Dlv5jDWxt2qtQUY/eruTXLJhqM16TvNm9TgWrN+JZlyNkRqcg//oVDJ1HlYyB9EJkAgmHYPYvNwC/bfe7p816fYD2pJ7SD96RHz+twTQSCG0ev3pOSAp+4dyk9rruIoasNO+sQkLLOYIF4leCRRAuWOf0V70u42hD2NCgR93BtMPVhe3Hd253cnfoSOHx4YtHSZy7AMZn11P8fMjxCh6FXX/gWqdSvYMbWZJZaf8L1dLBwac4nMKLsGVDhydEPVUgxCHQjxF02XI1ijWelIUz3Hdt8iiLTTmXVamTmjBj1Hrl6Lwtiaa0zeLtjZfVYF4A4OeHCkXntYTa7QLkJRXCVZHgZha91FByQyrISEQxQT8BM1zZ1xbF2b/bBW8awS5iTI3Ob/21ENpj0B9VOAaWXCYEHkAJbWp X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(41300700001)(316002)(82310400005)(47076005)(426003)(83380400001)(44832011)(40460700003)(8676002)(36756003)(70206006)(70586007)(86362001)(2906002)(4326008)(356005)(82740400003)(81166007)(478600001)(26005)(40480700001)(54906003)(6916009)(336012)(186003)(2616005)(1076003)(5660300002)(8936002)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:21.4126 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c627175e-5963-4af9-9651-08da9ca0228d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5953 After qemu arm64 test scripts had been renamed to reflect their usage, do the same for the qemu arm32 test script. Currently it only boots dom0, so we can assume that this script will be used to perform dom0 based testing. In the future we will be able to create corresponding script qemu-smoke-dom0less-arm32.sh to perform dom0less based testing. This is the last step to get rid of ambiguity with regards to naming of Arm test scripts. Signed-off-by: Michal Orzel --- automation/gitlab-ci/test.yaml | 8 ++++---- .../{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 3b147c88ab08..92e0a1f7c510 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -195,12 +195,12 @@ qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: tags: - arm64 -qemu-smoke-arm32-gcc: +qemu-smoke-dom0-arm32-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log needs: - debian-unstable-gcc-arm32 - qemu-system-aarch64-6.0.0-arm32-export @@ -212,12 +212,12 @@ qemu-smoke-arm32-gcc: tags: - arm64 -qemu-smoke-arm32-gcc-debug: +qemu-smoke-dom0-arm32-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log needs: - debian-unstable-gcc-arm32-debug - qemu-system-aarch64-6.0.0-arm32-export diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh similarity index 100% rename from automation/scripts/qemu-smoke-arm32.sh rename to automation/scripts/qemu-smoke-dom0-arm32.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:41:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410160.653247 (Exim 4.92) (envelope-from ) id 1obMSJ-0006id-5Z; Thu, 22 Sep 2022 13:41:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410160.653247; Thu, 22 Sep 2022 13:41:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSI-0006iL-Vo; Thu, 22 Sep 2022 13:41:30 +0000 Received: by outflank-mailman (input) for mailman id 410160; Thu, 22 Sep 2022 13:41:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMSH-00041N-FM for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:41:29 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2071.outbound.protection.outlook.com [40.107.237.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 402eff95-3a7c-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 15:41:25 +0200 (CEST) Received: from DS7PR03CA0346.namprd03.prod.outlook.com (2603:10b6:8:55::9) by MN2PR12MB4079.namprd12.prod.outlook.com (2603:10b6:208:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 13:41:20 +0000 Received: from DM6NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:8:55:cafe::15) by DS7PR03CA0346.outlook.office365.com (2603:10b6:8:55::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT010.mail.protection.outlook.com (10.13.172.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 13:41:20 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 08:41:19 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 06:41:19 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 22 Sep 2022 08:41:18 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 402eff95-3a7c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwdRX1cfYFqyB9Gc32o2mp4EKUOHxv7jLjxJGGVfnBsnvJibMaQtrctT9tGzVY8xlYyOURC73SDRDp23jeXer2kT1tdrLTBtXa12PSdQbHkHCjDy+JmB6fKuaF5yMEJ8n9BfuKW6TCaAf9oLCN9PvIj+kuL8MZ8uNf9VAo2OYo/nS2cyyqeCIgc84IevL19T76PBiQhV4BIFG/FvuGhxJ1EhLP69zFw+XuxbcAVkCyOYu1Vxw8gn0Nr5lILfqQPdJs3vN23XdGwtvyNW8SWo2WtL+n/PSGjp0nmJ66+OQKLcZow9EkeYXEYUnkYoEmEU8I1IvMXmdvDbG+qwHa8qfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lv2zvsIlsdyRqUjNOYL9flTtB4Uvfcd/mKIDBHTXVwY=; b=O8rt0iYU6TSja2TSRcW0xCKkSKv/C0nda/DICaakU7nVo54GyXt/QTV7vrQtUen2RP8MwdMR8xjt+OWypyx+KfkoaEmwBXYG6WI+bXSwD7iFjkqI8ChnKY8bgQzP++CKePvyimdKxpBHloiuT6+WGeklS9uJBLbKbKomYm7nFMH7/LHBA7AwOWQA/FXK2mrmQitPu9wnJ0/AMwxv5nanxRI6dccarC7iK9VGHK3gweZg07L0qTVWeOEaKYMUaJ8odhcfc2qzstyF+MauaQRDa6vNVQmWwp8iCuyu9kcsBB0zh72AbddOeNMQM8HBT6ikpknNj+ajRoHf+x4NbhrX8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lv2zvsIlsdyRqUjNOYL9flTtB4Uvfcd/mKIDBHTXVwY=; b=uq1XEbQy6DU3ANJNqLlIZHdEXGLsUx0gx1eG1+fGozE0QD5ZgZmU9/MJ3x6tfaY9TY9GWx1SgjG5kZqARAk3CPgxvcFsba0Eb5BFMTVPwHSFp2JNtuMEdjzq2wtrgfz8W385VC/RryZ6XwrZEwuXa+O7mgVPF7vDtHiMDfZ5esA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 8/9] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh Date: Thu, 22 Sep 2022 15:40:57 +0200 Message-ID: <20220922134058.1410-9-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220922134058.1410-1-michal.orzel@amd.com> References: <20220922134058.1410-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT010:EE_|MN2PR12MB4079:EE_ X-MS-Office365-Filtering-Correlation-Id: 23f703d4-d38f-47a9-e1f5-08da9ca021dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o4uLTELCsPvIF/8nsUQw61FDCkzyVO/GZl/PEoiOqVTQWvU15M4P4XGjshoDAuzxj1C7mlnryHUWJSnP8Qy2QzZWcRBgvO50P5Zc2xk2UZlSJE/kYt+5YF8eJrotI8E7rwio4r6FYXSbKmTMEaddDLnX4iNwinqpe+pNFx+IPIGm2vGKH2/9wLgg+RzYNo7r5dIONYhMt1tYSLN+1GOznc7iRHJrkzXD/Fzz88wEqr57iKaMhKfDSVEUY+2lqKE+/Hws2tt9Qs6WI32cjZZ/J6BqTwduDjXOaGnk6dvY+L30SqptZdNxJWLYBIpMufVwD64FivJZBE9wlxxwC2qwA8vf7qsSKOhvL5DCqpiKu/ALR/5CLDRP8oJfcAHSNvQ8ccDKGUDHSXxKmrmv4N5hyEBtDCWKg6KxzK/601UYgt6y3UME1WjPa1f6G6Rm7fP7zhUuCiEcp1Tsd7qm2v96GgyVGGnRtx0UuafNxf/k8xXPOxX+rLpEmbmikkYc7/BeNy/zGv2e9eQW5o0WaJE3tG2D2iu3q9QfjAjjq3qEv53l6NAlEPj2Y5qgXDkeXVpuhQ2dW6FiBiBVe9IM2jjekYIZa6sX0Ruw91fozLRaLgXIC3obfHvwFqfSqJTe5lZXbPqG3IpVk5iHsbwlf9c1BkANci9U0kIj2/4FEn3MToE34pv3byo3Ws19UVFShN4GG6yiJM/vujfii0pzOVcytdJBN65rBg8MRlPdptzm01d7K4MmpYvK44PJlNEPNRxvu65YW2qtl7qPhaUHE3pzjRfx1Tc/9217Ucirt3OzK9/ybvJALTsWzAg9JLMt2hHm X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(478600001)(41300700001)(2616005)(1076003)(336012)(186003)(6666004)(40480700001)(40460700003)(36756003)(26005)(82310400005)(8676002)(83380400001)(70206006)(70586007)(4326008)(5660300002)(2906002)(44832011)(8936002)(316002)(54906003)(6916009)(81166007)(356005)(82740400003)(36860700001)(86362001)(426003)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:41:20.2077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23f703d4-d38f-47a9-e1f5-08da9ca021dc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4079 qemu-alpine-arm64.sh script is used to perform dom0 based testing. Rename this script to qemu-smoke-dom0-arm64.sh to reflect its usage. Also rename the corresponding test jobs. Signed-off-by: Michal Orzel --- automation/gitlab-ci/test.yaml | 8 ++++---- .../{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index f620622671f8..3b147c88ab08 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -25,12 +25,12 @@ build-each-commit-gcc: tags: - x86_64 -qemu-alpine-arm64-gcc: +qemu-smoke-dom0-arm64-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export @@ -44,12 +44,12 @@ qemu-alpine-arm64-gcc: tags: - arm64 -qemu-alpine-arm64-gcc-debug: +qemu-smoke-dom0-arm64-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64 - alpine-3.12-arm64-rootfs-export diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh similarity index 100% rename from automation/scripts/qemu-alpine-arm64.sh rename to automation/scripts/qemu-smoke-dom0-arm64.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 13:45:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 13:45:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410204.653258 (Exim 4.92) (envelope-from ) id 1obMVv-0001bi-NN; Thu, 22 Sep 2022 13:45:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410204.653258; Thu, 22 Sep 2022 13:45:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMVv-0001bb-J6; Thu, 22 Sep 2022 13:45:15 +0000 Received: by outflank-mailman (input) for mailman id 410204; Thu, 22 Sep 2022 13:45:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obMTK-0004DO-9o for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 13:42:34 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66da100a-3a7c-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 15:42:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7FCA15C00D8 for ; Thu, 22 Sep 2022 09:42:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 22 Sep 2022 09:42:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 22 Sep 2022 09:42:28 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66da100a-3a7c-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1663854149; x=1663940549; bh=1exnffNnck ocGFlvR2gG+KOq54oxSFUg2c0Ocjxgo9c=; b=e4+dzMT54kQrITQ9+ooWr1jlyd SgM0k5erFZW2U5vKwQbHL/kyCVHF1mSfVZgGUV0RX7c41nleBvAYDuYTfY6Gdjsv CcB57n+PTlv0U804Kt1CHiEEqvmYuWFx0w1S50kkcC6qt/0k26eYHmcZQt1uXCEt 8751ikWktuZZ0ltawLiLgP49+wF85+96UMe7sXi7+CdBkC04twbMZxCKZvo6BJ+i /8891lwOirSaLxO4AYUB/8hUGvo9AyYgn9vmBKEHv6FtP+KwVU4oXSRY8Asf3/t6 zMOOf1Dp3pp5Pup1b4QiRaKsDx07GCYzzUYHLLKBQCXGwUvO5SY3xzYzVLCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663854149; x= 1663940549; bh=1exnffNnckocGFlvR2gG+KOq54oxSFUg2c0Ocjxgo9c=; b=B Q88WU7BLPpmBeAIw9Ih02ExcccSU+gXqWN7FJIyMouW22E9j3tIteSovKUH1rsJO 6npd4M4GWX+C572UvnZRiXuYbX7OytqYne6wQS3ptOgzPSfb2wk0cIDgHBWyVLg4 ZWFz806mNDoROWa/dfdfgVEUYQkKb3D1udk7qIZS5vqhGsDMecGR7n+aYgRHO8y4 7br/Z1TfDUf6TCnMzbfjQSqKIaqrESd0bjiUzY/mKCtorE1whHV+CHLDeYYZwkpy /lFWzdBFnVZstiOfXCVFlCo5fUFyeJop6IYRCwCfQQ+A+Mvq7bprV9xXGFD3hxOD /kcCu1RIrzk3LblCxJkZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnheptddugfetudevudeiveevgfetueejlefggffghffhhfehtdff feefgfduueegfefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 22 Sep 2022 15:42:25 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session "grant v3" Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/PqyDgNKiSkARGk5" Content-Disposition: inline --/PqyDgNKiSkARGk5 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Sep 2022 15:42:25 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Design session "grant v3" J=C3=BCrgen: today two grants formats, v1 supports only up to 16TB addresses v2 solves 16TB issue, introduces several more features^Wbugs v2 is 16 bytes per entry, v1 is 8 bytes per entry, v2 more complica= ted interface to the hypervisor virtio could use per-device grant table, currently virtio iommu dev= ice, slow interface v3 could be a grants tree (like iommu page tables), not flat array,= separate trees for each grantee could support sharing large pages too easier to have more grants, continuous grant numbers etc two options to distingush trees (from HV PoV): - sharing guest ensure distinct grant ids between (multiple) trees - hv tells guest index under tree got registered v3 can be addition to v1/v2, old used for simpler cases where tree = is an overkill hypervisor needs extra memory to keep refcounts - resource allocati= on discussion hv could have TLB to speedup mapping issue with v1/v2 - granter cannot revoke pages from uncooperating b= ackend tree could have special page for revoking grants (redirect to that = page) special domids, local to the guest, toolstack restaring backend cou= ld request to keep the same virtual domid Marek: that requires stateless (or recoverable) protocol, reusing domid cu= rrently causes issues Andrei: how revoking could work J=C3=BCrgen: there needs to be hypercall, replacing and invalidating mappin= g (scan page tables?), possibly adjusting IOMMU etc; may fail, problematic = for PV Yann: can backend refuse revoking? J=C3=BCrgen: it shouldn't be this way, but revoke could be controlled by fe= ature flag; revoke could pass scratch page per revoke call (more flexible c= ontrol) Marek: what about unmap notification? J=C3=BCrgen: revoke could even be async; ring page for unmap notifications Marek: downgrading mappings (rw -> ro) J=C3=BCrgen: must be careful, to not allow crashing backend J=C3=BCrgen: we should consider interface to mapping large pages ("map this= area as a large page if backend shared it as large page") Edwin: what happens when shattering that large page? J=C3=BCrgen: on live migration pages are rebuilt anyway, can reconstruct la= rge pages --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --/PqyDgNKiSkARGk5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMsZkIACgkQ24/THMrX 1yxyJAf+LgthiM6u3KSBdakLy/fvfO++QMQ2Looxzko/w9+npr9p3atAEnXqkbLf yjfarMHKdD9ygxA1iuC0cdEWG58TN9yLME1BuQowUDJwEWe3sSrmHAFEYntxhR9A 2ItnEWmnD6x69IsmuX/VBnpjHfGe0FU05rIQmSKaYmkncJ16xPOtes1O0EmauwaT AyygmV15vUsbIXH1nj/HVxUZtEg3HH/uTB28TKv/UZ+Fm/8F8pnsgLc7dgO/4IAJ LGWJ2JEN+61CcwT0EpRUT+0n39uu3bctE7BI2E4Ddx98zouqGLoX5QXet0fFnOS6 2MSQx0suTNYMg7KnY9u8/h/QrP97zg== =t9y2 -----END PGP SIGNATURE----- --/PqyDgNKiSkARGk5-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 14:56:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 14:56:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410221.653269 (Exim 4.92) (envelope-from ) id 1obNcf-00018q-TG; Thu, 22 Sep 2022 14:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410221.653269; Thu, 22 Sep 2022 14:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNcf-00018j-Pn; Thu, 22 Sep 2022 14:56:17 +0000 Received: by outflank-mailman (input) for mailman id 410221; Thu, 22 Sep 2022 14:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNce-00018d-9P for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 14:56:16 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b15b48df-3a86-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 16:56:10 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id B3AB63200124; Thu, 22 Sep 2022 10:56:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 22 Sep 2022 10:56:11 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 10:56:09 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b15b48df-3a86-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663858570; x= 1663944970; bh=zkbm06ADn/Z0FztsvCeHV5g6JLx4lp21pgu9fNEq2/I=; b=j ngIEaLE28Aml2WqeTX1u+TmlmoRdpw86O/8Ni4qYngg/B7qzA9y6kryrFgIfBxwu jhLzGTA3vPWOftDXIPXrJuSl6uqgsqOmbmsW44+1MwXqLguumUY+brtCNVtQ5F4W FtLL9GnLknCIxdlWsnMChlGEktvh2Jkcvz5pkF+Ks6uFLaMfLHpRzZz6sTV33h2/ v6KFvvB/OHhE6E3yXfIEpRQfozLycwka8rCFDH08pnsbat0bu6qhCUpTHchXt44f RyKP4zqVWrx3PqiIC8y005N85eYb09UQohTS/aABXm2R7eDWsQPPRWhc1Z+Gp49J zxxDVuvvCZl2d32xicFXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663858570; x=1663944970; bh=zkbm06ADn/Z0FztsvCeHV5g6JLx4 lp21pgu9fNEq2/I=; b=tUywip4W7b9b4sYdV6KEMIRYgWGRaUI48i6JEhIEd1kd YawxkarPA67Sbiei4uy6W62UFCiXY33+hjd6xyhK5mANDPHhAgBNVqiE+/p2M3p+ cRgcHGB8UEA4itvNHT1/5+vysAaW2RmGvsDqp9U2u5tHDMDUqBvuA1SOnzCOCjhn dfZ4RgnqZF19TU0TwhFROz4aEAB1cFVUUcRzP4DkxRYChadANHt0CoCCmy0fvzq6 n/4muytoiycONrnek2CRpgrcehcxv35+C9OnzngM/dDSOM0W/sosWzmfsV36nCZb 9g7zgZINwrXAlcjA7qrfeDaHR0KrivMiso6SDFwC7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 22 Sep 2022 10:55:40 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Ard Biesheuvel Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Message-ID: References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GpPEXFLkdw7UWuLD" Content-Disposition: inline In-Reply-To: <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> --GpPEXFLkdw7UWuLD Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Sep 2022 10:55:40 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Ard Biesheuvel Subject: Re: [PATCH v3] Support ESRT in Xen dom0 On Thu, Sep 22, 2022 at 08:12:14AM +0200, Jan Beulich wrote: > On 22.09.2022 03:09, Demi Marie Obenour wrote: > > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > >> On 20.09.2022 18:09, Ard Biesheuvel wrote: > >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: > >>>> > >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: > >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > >>>>> wrote: > >>>>>> > >>>>>> fwupd requires access to the EFI System Resource Table (ESRT) to > >>>>>> discover which firmware can be updated by the OS. Currently, Linu= x does > >>>>>> not expose the ESRT when running as a Xen dom0. Therefore, it is = not > >>>>>> possible to use fwupd in a Xen dom0, which is a serious problem fo= r e.g. > >>>>>> Qubes OS. > >>>>>> > >>>>>> Before Xen 4.16, this was not fixable due to hypervisor limitation= s. > >>>>>> The UEFI specification requires the ESRT to be in EfiBootServicesD= ata > >>>>>> memory, which Xen will use for whatever purposes it likes. Theref= ore, > >>>>>> Linux cannot safely access the ESRT, as Xen may have overwritten i= t. > >>>>>> > >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServic= esData > >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServic= esData > >>>>>> memory, Xen allocates some memory of type EfiRuntimeServicesData, = copies > >>>>>> the ESRT to it, and finally replaces the ESRT pointer with a point= er to > >>>>>> the copy. Since Xen will not clobber EfiRuntimeServicesData memor= y, > >>>>>> this ensures that the ESRT can safely be accessed by the OS. It i= s safe > >>>>>> to access the ESRT under Xen if, and only if, it is in memory of t= ype > >>>>>> EfiRuntimeServicesData. > >>>>>> > >>>>> > >>>>> Thanks for the elaborate explanation. This is really helpful. > >>>>> > >>>>> So here, you are explaining that the only way for Xen to prevent > >>>>> itself from potentially clobbering the ESRT is by creating a > >>>>> completely new allocation? > >>>> > >>>> There are surely other ways, e.g. preserving BootServices* regions > >>>> alongside RuntimeServices* ones. But as the maintainer of the EFI > >>>> code in Xen I don't view this as a reasonable approach. > >>> > >>> Why not? > >> > >> Because it's against the intentions the EFI has (or at least had) > >> for this memory type. Much more than EfiAcpiReclaimMemory this > >> type is intended for use as ordinary RAM post-boot. > >=20 > > What about giving that memory to dom0? dom0=E2=80=99s balloon driver w= ill give > > anything dom0 doesn=E2=80=99t wind up using back to Xen. >=20 > While perhaps in principle possible, this would require special casing > in Xen. Except for the memory the initrd comes in, we don't directly > hand memory to Dom0. Instead everything goes through the page allocator > first. Plus if we really were convinced boot services memory needed > retaining, then it would also need retaining across kexec (and hence > shouldn't be left to Dom0 to decide what to do with it). So how should dom0 handle the various EFI tables other than the ESRT? Right now most uses of these tables in Linux are not guarded by any checks for efi_enabled(EFI_MEMMAP) or similar. If some of them are in EfiBootServicesData memory, they might be corrupted before Linux gets them. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --GpPEXFLkdw7UWuLD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMsd4cACgkQsoi1X/+c IsEBoA//b/usaepDm+lyniu3r0moNjjY3zaQmtdSXTMeHqFzBrABiAz5AZyBFCtr wzSdmzo4rlrvNR2/et8taDq0qOcjGouCgWLLS4p5pbW+PkV/0RzLPVCQaanRm+g5 ZKeQbIFHeClEw7c4AWgY1mmlhiSdPYPCpXDdL4NCKeZgSTRykBp4J+Rg6rjwWKHD NAcWWs5MP6S4uVPVyZJQW4Blp087xPx3y/dFe5Fj3SeV37FDE9mvALy2+eJkDwnb 7EPnOmczl7BSHg6L0xxClF1AFedsP7Ao/ANIs+kAR3EhbKnvczvLgANTMBRo+JUk Z6JST57bnRNtR4nSs8txTfjA4OqBy6RgJAwzN2lgd9zjZJnUgRVaungMKi0hmanS QMDtB6EGnCj8m6TaJiISxNjNeK8TQRh11GyNCcFgsUnfi7KlYbybeMnoOOWg3Hwz n5xXPsO9YSplCPsJ+aqfKp5yhUoE7ePskiGzyRThLBzx5HMgM/qFnXvtvi2/cY+G XEfQo9fWiss6Or47D3ekcw0FtYrU2EKUVsVEmRR0f8aRSJl4phCSu9mbU6aikQzK ADdLyxZ/Cle6oGy44fVcevif3qp/gO5/u3AxegTqBL9Xu9mtz3RyZrDxAaZoLUEh b6UgO0JZhueI7F9B48R4cKAfOzJ/+9srYZyIZHLQZYPzMDzOaV4= =tj0J -----END PGP SIGNATURE----- --GpPEXFLkdw7UWuLD-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 15:02:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 15:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410227.653279 (Exim 4.92) (envelope-from ) id 1obNiS-0002ag-Hr; Thu, 22 Sep 2022 15:02:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410227.653279; Thu, 22 Sep 2022 15:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNiS-0002aZ-En; Thu, 22 Sep 2022 15:02:16 +0000 Received: by outflank-mailman (input) for mailman id 410227; Thu, 22 Sep 2022 15:02:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNiR-0002aP-Vj; Thu, 22 Sep 2022 15:02:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNiR-0001hh-Ty; Thu, 22 Sep 2022 15:02:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNiR-0003A2-Lh; Thu, 22 Sep 2022 15:02:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obNiR-0004rB-LF; Thu, 22 Sep 2022 15:02:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OOh6cf8//7oSa8sOBZU6qtZD1NSjmDMRZI9PjJQh+6g=; b=rnSPuYZ1Awe4nH1zPEJxolu7F1 1liQn1zZC1Hbx+suCC2QSkFZbW6n7P5XbA7dKCmtohLSG5nzcwpL5fHOeuGR26awOl0P8Yfrkx0fQ 46h0ZKg68Hn1PDpYvB9jocADvisPPEHtMFlVBxnnd4e6khnEPNmSlGbsW/RLpGTImf/M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173278: all pass - PUSHED X-Osstest-Versions-This: ovmf=62f00dad22bc657290780dc65c6f1b8ac6e88f9b X-Osstest-Versions-That: ovmf=2c17d676e402d75a3a674499342f7ddaccf387bd From: osstest service owner Date: Thu, 22 Sep 2022 15:02:15 +0000 flight 173278 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173278/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 62f00dad22bc657290780dc65c6f1b8ac6e88f9b baseline version: ovmf 2c17d676e402d75a3a674499342f7ddaccf387bd Last test of basis 173243 2022-09-16 22:11:50 Z 5 days Testing same since 173278 2022-09-22 12:40:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kun Qin Sean Brogan jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2c17d676e4..62f00dad22 62f00dad22bc657290780dc65c6f1b8ac6e88f9b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Sep 22 15:06:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 15:06:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410236.653291 (Exim 4.92) (envelope-from ) id 1obNmB-0003P2-7d; Thu, 22 Sep 2022 15:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410236.653291; Thu, 22 Sep 2022 15:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNmB-0003Ov-2z; Thu, 22 Sep 2022 15:06:07 +0000 Received: by outflank-mailman (input) for mailman id 410236; Thu, 22 Sep 2022 15:06:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNmA-0003Op-7Y for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 15:06:06 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 132067ef-3a88-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 17:06:04 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id F186ECE2253 for ; Thu, 22 Sep 2022 15:05:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41D7FC433D7 for ; Thu, 22 Sep 2022 15:05:56 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id c7so11321141ljm.12 for ; Thu, 22 Sep 2022 08:05:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 132067ef-3a88-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663859156; bh=1uM16sAEsFRpmXqJh3o8KDbSU5Vn6VywW/jmOdA6aNc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=R5Xni3kApssHFwBpX23u9FqbIoOrfFW9Eh+DXpawBWt83eJ2txweva4gjv1WcnATf 7IEz087ER/3ndPQ9bonJoS2RZV28gl54xgcODjILPpOuh7MG6GjSGBjsd3hdzL+bZI /TQTj13hizyHTFlb5cTaOPaJmzPGme2l93biRkvnNEpZRc98RBilPbaEIN/wsE1icU X0wh/90FYlcTObNdAHcpm+fouiLSO/Ef1uhXv5X/ox6u4OyXBR2ZOvsv1mvenvHdeF i9NO19Wutl6RrOaY1MvHKbo84tVMreipSnQOyYUxfRqAMrqmzFar/xsPAyqbFwiHcc 0LZ7VF4CZzVSA== X-Gm-Message-State: ACrzQf2IoMUeeEWYZdjrfh5za2hQ1uflz6N5rscwx8/J977/AdtANFyo dW5oCEJHxoA8bz6zA+ychLvUwyS39qnSdy7Wn/M= X-Google-Smtp-Source: AMsMyM4SN/XP/Ju64WkB2EIWy6dKCCftvHdMN498Tlfzs6TU3Iv+ia7oWel8dcPZRPgNVsqFNV7TsgyKzSOdBFgMzXk= X-Received: by 2002:a2e:9115:0:b0:26a:c086:5138 with SMTP id m21-20020a2e9115000000b0026ac0865138mr1173829ljg.189.1663859154235; Thu, 22 Sep 2022 08:05:54 -0700 (PDT) MIME-Version: 1.0 References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> In-Reply-To: From: Ard Biesheuvel Date: Thu, 22 Sep 2022 17:05:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 22 Sept 2022 at 16:56, Demi Marie Obenour wrote: > > On Thu, Sep 22, 2022 at 08:12:14AM +0200, Jan Beulich wrote: > > On 22.09.2022 03:09, Demi Marie Obenour wrote: > > > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > > >> On 20.09.2022 18:09, Ard Biesheuvel wrote: > > >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrot= e: > > >>>> > > >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: > > >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > >>>>> wrote: > > >>>>>> > > >>>>>> fwupd requires access to the EFI System Resource Table (ESRT) to > > >>>>>> discover which firmware can be updated by the OS. Currently, Li= nux does > > >>>>>> not expose the ESRT when running as a Xen dom0. Therefore, it i= s not > > >>>>>> possible to use fwupd in a Xen dom0, which is a serious problem = for e.g. > > >>>>>> Qubes OS. > > >>>>>> > > >>>>>> Before Xen 4.16, this was not fixable due to hypervisor limitati= ons. > > >>>>>> The UEFI specification requires the ESRT to be in EfiBootService= sData > > >>>>>> memory, which Xen will use for whatever purposes it likes. Ther= efore, > > >>>>>> Linux cannot safely access the ESRT, as Xen may have overwritten= it. > > >>>>>> > > >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServ= icesData > > >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServ= icesData > > >>>>>> memory, Xen allocates some memory of type EfiRuntimeServicesData= , copies > > >>>>>> the ESRT to it, and finally replaces the ESRT pointer with a poi= nter to > > >>>>>> the copy. Since Xen will not clobber EfiRuntimeServicesData mem= ory, > > >>>>>> this ensures that the ESRT can safely be accessed by the OS. It= is safe > > >>>>>> to access the ESRT under Xen if, and only if, it is in memory of= type > > >>>>>> EfiRuntimeServicesData. > > >>>>>> > > >>>>> > > >>>>> Thanks for the elaborate explanation. This is really helpful. > > >>>>> > > >>>>> So here, you are explaining that the only way for Xen to prevent > > >>>>> itself from potentially clobbering the ESRT is by creating a > > >>>>> completely new allocation? > > >>>> > > >>>> There are surely other ways, e.g. preserving BootServices* regions > > >>>> alongside RuntimeServices* ones. But as the maintainer of the EFI > > >>>> code in Xen I don't view this as a reasonable approach. > > >>> > > >>> Why not? > > >> > > >> Because it's against the intentions the EFI has (or at least had) > > >> for this memory type. Much more than EfiAcpiReclaimMemory this > > >> type is intended for use as ordinary RAM post-boot. > > > > > > What about giving that memory to dom0? dom0=E2=80=99s balloon driver= will give > > > anything dom0 doesn=E2=80=99t wind up using back to Xen. > > > > While perhaps in principle possible, this would require special casing > > in Xen. Except for the memory the initrd comes in, we don't directly > > hand memory to Dom0. Instead everything goes through the page allocator > > first. Plus if we really were convinced boot services memory needed > > retaining, then it would also need retaining across kexec (and hence > > shouldn't be left to Dom0 to decide what to do with it). > > So how should dom0 handle the various EFI tables other than the ESRT? > Right now most uses of these tables in Linux are not guarded by any > checks for efi_enabled(EFI_MEMMAP) or similar. If some of them are in > EfiBootServicesData memory, they might be corrupted before Linux gets > them. Yes, this is an annoying oversight of the EFI design: the config tables are tuples, and the size of the table is specific to each table type. So without knowing the GUID, there is no way you can reserve the right size. Perhaps you could implement something like a hypercall in efi_arch_mem_reserve(), which is called by the EFI code to reserve regions that are in boot services memory but need to remain reserved? This is used for all config tables that it knows or cares about. From xen-devel-bounces@lists.xenproject.org Thu Sep 22 16:05:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 16:05:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410326.653349 (Exim 4.92) (envelope-from ) id 1obOhw-0004YV-Hw; Thu, 22 Sep 2022 16:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410326.653349; Thu, 22 Sep 2022 16:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obOhw-0004YM-ET; Thu, 22 Sep 2022 16:05:48 +0000 Received: by outflank-mailman (input) for mailman id 410326; Thu, 22 Sep 2022 16:05:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obOhu-0004Xa-Pa for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 16:05:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65b226f8-3a90-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 18:05:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65b226f8-3a90-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663862744; h=date:from:to:cc:subject:message-id:mime-version: content-transfer-encoding; bh=SVAiD7YKyxL7SV+rU9d5Js2kd29w7GVAQLzAiCndMQg=; b=C4YR4l3scqSWbS7jj8ZfvPLqYHVFXKWR7qvq6FLJOrpp/8AejH4IETk2 sJBRnbdXYJlFd+YVeKi3WLNLW1Cd7p5r5omoLz7vwhHDdiTxDVyGJx0z+ M8+3HxxPMCryZGNtdDfzCvxAzSLTIVtHVQYJj7Oson9Zyssw/6r5/ihAs Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80275683 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:fG+jeqz0xApMAPcx3bB6t+dJxirEfRIJ4+MujC+fZmUNrF6WrkUFm DFJCm+DOveJM2qgf9B+bIS0/UhSuMOHn4AwTwBkrCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Uk15K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1uNUAaO6oi9d0wEGQe7 cc7M3MBdhWM0rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzJZQFPPVEGToozhu6yilH0ciFCqULTrq0yi4TW5FwpiuewboqOEjCMbeRbpFm1t mudxFnGWB4FLcLCmQKv1n3504cjmgukAdlPRdVU7MVCglee22gSAx0+TkagrL+yjUvWc9dWM Ukd4Ccthak06k2wT9P5UgG4oXiLpRoVUZxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRSXKa9ECzHsO3O9HXrZHZTfTRqiTI4oRUt4+DijIcUtB30CcdmQLaOrca2FSn1z GXfxMQhvIn/nfLnxo3iow6c02nz9siYJuImzl6JBzz4t2uVcKbgPtX1sgaDsJ6sOa7DFjG8U G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPnqgKulmS3G8zbq45lcbBO Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+S4+6Bq2PM4UWP8EZmOq7EMZGOiatM53FyhBwwcnTx 7/CGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+iOL2WZJgYe1aWLd4RrxmsfjsTcS82 4o3CvZmPD0GCLChOnaOqN5PRb3IRFBiba3LRwVsXrbrCmJb9KsJUJc9HZtJl1RZoplo IronPort-HdrOrdr: A9a23:kQDcBqBrgTKNHHblHemm55DYdb4zR+YMi2TC1yhKJyC9Vvbo8v xG+85rsSMc6QxhOk3I9ursBEDtex/hHP1OkOos1NWZPDUO0VHAROoJ0WKL+UyGJ8SUzI9gPM lbHJRDNA== X-IronPort-AV: E=Sophos;i="5.93,335,1654574400"; d="scan'208";a="80275683" Date: Thu, 22 Sep 2022 17:05:18 +0100 From: Anthony PERARD To: CC: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Jan Beulich , "George Dunlap" , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Design session "MSI-X support with Linux stubdomain" notes Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit WARNING: Notes missing at the beginning of the meeting. session description: > Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn’t > support MSI-X. For the device to (partially) work, Qemu needs a patch masking > MSI-X from the PCI config space. Some drivers are not happy about that, which > is understandable (device natively supports MSI-X, so fallback path are > rarely tested). > > This is mostly (?) about qemu accessing /dev/mem directly (here: > https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) - lets > discuss alternative interface that stubdomain could use. when qemu forward interrupt, for correct mask bit, it read physical mask bit. an hypercall would make sense. -> benefit, mask bit in hardware will be what hypervisor desire, and device model desire. from guest point of view, interrupt should be unmask. interrupt request are first forwarded to qemu, so xen have to do some post processing once request comes back from qemu. it's weird.. someone should have a look, and rationalize this weird path. Xen tries to not forward everything to qemu. why don't we do that in xen. there's already code in xen for that. Issue: having QEMU open /dev/mem within stubdom isn't working. We could look at removing the need for /dev/mem by improving support for qemu-depriv. hypervisor configuration interface was intended for one domain. having stubdom in the middle makes thing difficult. See QEMU's code https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579 fd = open("/dev/mem", O_RDWR); TODO: step1: Find out why qemu wants that mask? step2: identify what is missing in the PV interface. QEMU use this to read the Pending Bit Array (PBA), and read entry in table comments at L465 (of xen_pt_msi.c) doesn't makes sense Xen could do more fixup passing value from hardware?? can't pass vector to the guest, xen overwrite mask bit. (or something) Did MSI-X worked in qemu-trad in stubdom? No one in the room could remember. MSI-X is required for pci express, not that thing are implemented correctly. TODO: - get rid of opening /dev/mem in qemu Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 22 16:05:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 16:05:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410325.653338 (Exim 4.92) (envelope-from ) id 1obOhr-0004IT-9s; Thu, 22 Sep 2022 16:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410325.653338; Thu, 22 Sep 2022 16:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obOhr-0004IM-6b; Thu, 22 Sep 2022 16:05:43 +0000 Received: by outflank-mailman (input) for mailman id 410325; Thu, 22 Sep 2022 16:05:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obOhq-0004IG-1R for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 16:05:42 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65b896c5-3a90-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 18:05:39 +0200 (CEST) Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Sep 2022 12:05:31 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5540.namprd03.prod.outlook.com (2603:10b6:208:296::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 16:05:29 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.019; Thu, 22 Sep 2022 16:05:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65b896c5-3a90-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663862738; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=CqY9WEJXIFF0yrlMiPz8gd/m+wLzRdwVXl7D8IeD4ec=; b=RcilGweO5T6rGW3R35K6M6Pf3mBaIrudR1loPMgorjJdoLjM9XN2nJvx dmxdzhh7xv/nwp6pVK6df/VcMSmAEOJQ3Zxo9owR0JXYtfXlXst7Xm9KJ Z6Jgrb98Zlo6QP9aIps0SmsqXvCx2JTEdFKbMcLxPAjBkM5nHp1JvGxi/ 8=; X-IronPort-RemoteIP: 104.47.70.104 X-IronPort-MID: 80800937 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gE1MVa5RZUiThttvugkkvgxRtALGchMFZxGqfqrLsTDasY5as4F+v jRKDWDQafbfYWTzc9t3b4vi9R5T6p/Vn9cyQQc/qn9kHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ks+5q6q4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJFMqHIcZxMxGOnBh/ KI0ChooaQq7if3jldpXSsE07igiBO/CGdpH/1tGknTeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LGUe8QrJzUY0yzG7IAhZyr/iPcCTYtWXbc5UglyZt iTN+GGR7hQyZITPkWLUqS3EaunntCbHdIwiLqWE7N1PhAOz1kFLGCIfSg7uyRW+ogvkMz5FE GQE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4qje7hudB2MEZiVcc9Fgv8gzLRQ10 neZktWvAiZg2JWXVHac+7G8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXI9SrYx jmLqG00geoVhMtSj6Gjpwmf33Sru4TDSRMz6kPPRGW54whlZYmjIYu19Vzc6vUGJ4GcJrWcg EU5dwGlxLhmJfmweOalGY3hwJnBCy65DQDh IronPort-HdrOrdr: A9a23:yXIQQa4qCpgyVslJCQPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A== X-IronPort-AV: E=Sophos;i="5.93,335,1654574400"; d="scan'208";a="80800937" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJUgu2uz3cWtVrgkBACbDHApZr5VRfRROi342ut+0ka+qws3Cyw6p0QSvvL8Okp7sVF7UrHZGdGZ5m6G6x4IDlsy2nPvv1itwv/Ku/kBv9oUDVYjle8TcXEK/+nCMK/ntvHmBSz/8ojHFf/SpzUoYyWpjRmZYENtoUMmtwJYWg5P2/dblTh7X+xDC3iwJEnD0ivqNOAC65GwMS7VKzjt4uxEW6gc/w7B7sh4lHwuUHAi0riITqUALASCWsdTc3xhYWb2kAXjnntA0zZz+E4Jcz9Aj8yQhWOq49+sR7oAT6B3n1Jocx2QgPIIEpoIuUfL3uMmC9AtkP5y0iIiB3tNqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEY/skUulMhqe3KZ9qY/Gi9Gi3W1WPOcX5qKjCaqIwI=; b=LPgvO4a2I0IAjA1z5mjhwWQDhCBg2I7yB+ORk5KIv9ubL6pvUU/vDKvqRZb3hzzAMeictMO7GaxGO4CActQJq5tANfs5bI86/sPF62uwhXw00IzHSNNWJYbqXOs8hVaoLSvmaRWNwOxh26Y313CKafdZvQhBzxh5bUtyPZAi3IJmIcbadaWghs0mTorVFBw4fxRydAFxAeiOCoLAt9U43GxM4tJqWpgS56bok9gBWCc67BLNQsWHMkpHSO3Q1hej2p7B2RqQ00HIB2Bx2ekXk9oC+V5Adujk6FtNP7Sq68p3+phDsQsR5GEh5JbZiJjygoa22EDn75l4PMfMpU/MnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yEY/skUulMhqe3KZ9qY/Gi9Gi3W1WPOcX5qKjCaqIwI=; b=oFfReno5vTPsJ96VZ2izdnb+BrB9nct5HxvLGFYffO9QVdXGp4gd3xmwdTRFaB3ihqEeH50umTxHGm1mttNAj9Vy/XbmIhjJxs8MQvPJj29h6Eo6H1WkK+SV9yeiuU/KIT9PkHC0oEn01CFecb+CrOQqXHd8sw74PG4DpjJVjJk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH] x86/ept: limit calls to memory_type_changed() Date: Thu, 22 Sep 2022 18:05:16 +0200 Message-Id: <20220922160516.5929-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0501.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::8) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5540:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c838484-bb9c-4727-6b98-08da9cb44432 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gvQSsFi5H8qAIuHrlj6+ZQApscJHYVguDbzZH0uQ/8fi1PgpVXO/TN2k2w65fgkac/1KG8osjAXiENH73gae8Z75u+h0JuC3WC1jXQZR+aeY19SkLMhoLEzHU0at/KmZqYWwXAJS9pCehqkls+rvJuOjMp4vWxWZU6W4Qpi86+LK5zZ3lQn+yKFLMnTDv2RSBRJxjrCVINIgkOvIRRQMOvhral3e6oKZo1H8fGan6lqaDKS2h8HwoVboin6hNLwZ/9OrWJDnguRwr9ImSA8NUs4uBDXb/p/RmW9m2u5BqkaSjbfBPg64UUPLJwjF/4ZC604Z3S6RYktptEf7kwZamboOBBZwuEQC83iF3uICyLmRCbH7a6DgFYnMzXB+6Uq2DY0UFCtrFSimU2mRQhgOz1wIVOrQT30yNL6J0QlHLcYPxe8m4AINSQPomaLDkNJm/BFOdtiZxCJGmNzuWM9FIpNL4WIH01wEmBqlxD27giJy6UYozUHbEipgI+HG5rSk+dxbrrx7PdqUybh0IhXST3xtNFLn+5fKX9MzLabW1FskvZBbXR/w4q79CykvojQRvCvhl+rD4tjvPHT3mXgC1MLwjT2iQCZjZ8GGxzfUI1ukmo4rQjn4gG/8OsU95sFQBWOpJhoSvT7ALtIOAvZiZR2aV2qkWliEW0Qem5voAd/3DOyRNs1bpJBmj0+OEB16GweP6smOHmO2dQHV0lEs1g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199015)(66946007)(66556008)(66476007)(54906003)(316002)(186003)(8676002)(6916009)(5660300002)(2906002)(41300700001)(1076003)(4326008)(86362001)(8936002)(82960400001)(2616005)(38100700002)(478600001)(26005)(6506007)(83380400001)(6486002)(6512007)(6666004)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejgrNEd4TlV1dUFiQk9MVVo5WFhGdkNqR0x5TFk0Yko4dllmR2F2MC9xMHVx?= =?utf-8?B?MmRjK29uVjNreVR6VUNXTEdJVStIQ25EU0FKay9jQ291RFRmam4yWUxiVmd2?= =?utf-8?B?QzVMdlRmZHMrdDdRbXhaOFpQNHBTdmJ1SXc3Qk9wb2VXYTNOa1IxZE11WGVQ?= =?utf-8?B?U2pEb3Z3WHRGRE1TQ3JSS0pYbDdaZ2QwUmJnalB2QnFaTThxbXViVUFxRTRQ?= =?utf-8?B?anhxbmZWTDdGbmZ0NCtIblhibnl2V2FwNkMrYkRGUkxiWTRsSTRGblIwTkUr?= =?utf-8?B?WldjcTc5NFFvc0pmQVFuWUlGa1BQOXh5WkRHaENFWUxYQ2pCN0VrWXRDUjZP?= =?utf-8?B?a2NJb2g2ZTgrNC9vUFBxQUliTlZpcVowTHNCMm5tYnl1a1BBSkhibW5CWGVE?= =?utf-8?B?eFBBYm1zclg1RFQ0YW1GdmxaSnJlOTBOeDJqampHKzdqbGdvR0NMUUVGQ3hj?= =?utf-8?B?alZCSG9pY3pkazlkMEhYeFpFZXVyU3pybWhhaEdudVo4UDl2ay9wbWJRck1v?= =?utf-8?B?TmZxeGtiZVFVWjZQRFcvVm9nWDF1STdkMFpFaTFlRm80R1hydmswRFZDNXlJ?= =?utf-8?B?MTZ1SjRjcjNWQ293SUpDNXFESUhpY1NGVXJyMTk4OW9YaVc3RXpKLzBqaE1E?= =?utf-8?B?Z2NnZWJ0QWlZZ1JySE1LLzBNMXAySFFyZWtlS2QyNE51a1BVOUJ1Vm1YM1VX?= =?utf-8?B?K2hsRXBLSjZNQmJ6YTdVUkdoa0sxZ2dyNFhEWXgzS0pNWlRpUTRyaWhtd282?= =?utf-8?B?Ulk2enowWDdxVWFnTy9TeXpIMHArWGVCZnFIQkk4U2hTeG5jb28xNk4zYXVQ?= =?utf-8?B?Sy9LNTBhY0RuM01mS2JqV2xNdkdaSXFma2V2Q1NTQWUyVCtCa05pRnhELzhs?= =?utf-8?B?VWdBRDRSRGJ5UnJkZ0dQRVp0Mm85Rjh5TU9wSHk3eG5MdWFSUVkyL0F0RHUr?= =?utf-8?B?dUhVeGt2TVNFTlAwVXpQR25meHIvZ2N3YTc3ZmxvQ0F5VnNzaFBkRkQ3dnlw?= =?utf-8?B?WnNWWWd1cEloU2RZYVdNQ3N5eHV2OHlyaFdtblhWcEJMVjBoVlZSTy96czg0?= =?utf-8?B?YytEcUljM0w4U01ZTnhMQlN5UEljMjNXUUFCdzM2ZWFFbVpoWVRFY1IvL1Nh?= =?utf-8?B?Q1R1YzdqK0NTUjJoL1F2MnRqV2hIVnFXYmw0N3VHRzh1dGNYb0dRWmx4M1RJ?= =?utf-8?B?WENZMmxObU5NYjFYb3hCYTM5R1lpamxRY3hKV0lmWm9PUkdtazdzNzBKVmQv?= =?utf-8?B?Y2dzQWx1bktKdk5EMjE5Z3NGNXJkQThmSzN5dlNqVC9adm8rTi9nZWJvbmQ1?= =?utf-8?B?SXVGdmhDdkppZmpMeDJxQVpxQkVIcWlXajl1K3ZidnBRUmVlUllKejBMVmgy?= =?utf-8?B?ZE5zalhWbXNWZnlsTUNHV1NlM2x4QjByc1Q1TEZtZHVCNEQ2c1Z6eUFUQlRt?= =?utf-8?B?Nk0xTTRlanA3ZlRFNVRvS09iQW5HUzJSbHZZM09CNlg5SVRMSW5yenZuM2x0?= =?utf-8?B?Y2NZeFJQTzFkWVFBd24xQkE4WGYxeFhmdUJWYTFCa25pUm53WFhEU0puYkxu?= =?utf-8?B?dnBBb09Cb0NGem5vOUlHYXo3TEF4Ym9JMGdJUTR6MVdiRzFpT08rWm9VVXJn?= =?utf-8?B?c1ZsRk5aeVlFWk03cU8wUW0wR0IyZExjVytFWkRocTd2WmJ3N2tIK3ZUTDd0?= =?utf-8?B?UFZKZU15Z3ZhLzMvMk1ROFZ3QnlOcXB6Uk04SC9YRXB6bmRLOUhLOHcxbWoy?= =?utf-8?B?ZlJnVXUwZ0RMQXBFVHVPOVc3cDlwRkxjWkFIUHdJRnRyU2srODk3ZTJpRkJy?= =?utf-8?B?OEVqc1JLdk1uNEltYkdxcGhMaU9mNWhEU3BTZk10dzhuT3V4UXdTTHdtNzNj?= =?utf-8?B?RkFxY1REQU04all2cjB3UXpwd0o5OUt2aGM0TUxlL2ozbHp6MnBjcW9ZVE9p?= =?utf-8?B?RUJHRjREczI3R1ZiSjAxSlh0SWhrbHNtN0NweTRpRndQbkphZmdBd0tmYVhH?= =?utf-8?B?R3RWWHg3RlRQaVJBZTBwbGZYNmNFbjVTb2JJNy9QM2E3dGltc0t4bnBQSDB1?= =?utf-8?B?c2FGM0p2aWM4Q0xTN2RucnFXdW4wOFlFMGxYSUpITUZyRlhCakVYeFQyWi9I?= =?utf-8?Q?a2+NKmxX7Odw77vHaC8iQzlqk?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c838484-bb9c-4727-6b98-08da9cb44432 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 16:05:29.1375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xSTvnWMlePH9zlcfAc5BxZ9330PdQDVLiROnnP5J+7r/udNkHrWsm33dWN8TVDLthFsQZ2YYbYjXtkZM6i7sTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5540 memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges are only relevant for EMT calculations if the IOMMU is not enabled, and the call has resulted in a change to the return value of cache_flush_permitted(). Signed-off-by: Roger Pau Monné --- I feel it's a bit weird to have calls to memory_type_changed() in common domctl code - for once the domctl that trigger the call doesn't change memory types, just adds or removes ranges from iomem_caps (which in turn affects the behaviour of epte_get_entry_emt()). --- xen/arch/x86/domctl.c | 18 ++++++++++++++++-- xen/common/domctl.c | 11 ++++++++--- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 020df615bd..f1150dffa5 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -222,6 +222,7 @@ long arch_do_domctl( unsigned int fp = domctl->u.ioport_permission.first_port; unsigned int np = domctl->u.ioport_permission.nr_ports; int allow = domctl->u.ioport_permission.allow_access; + bool flush_permitted = cache_flush_permitted(d); if ( (fp + np) <= fp || (fp + np) > MAX_IOPORTS ) ret = -EINVAL; @@ -232,7 +233,13 @@ long arch_do_domctl( ret = ioports_permit_access(d, fp, fp + np - 1); else ret = ioports_deny_access(d, fp, fp + np - 1); - if ( !ret ) + if ( !ret && !is_iommu_enabled(d) && + flush_permitted != cache_flush_permitted(d) ) + /* + * Only flush if the output of cache_flush_permitted() changes and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for EMT calculation purposes. + */ memory_type_changed(d); break; } @@ -586,6 +593,7 @@ long arch_do_domctl( struct hvm_domain *hvm; struct g2m_ioport *g2m_ioport; int found = 0; + bool flush_permitted = cache_flush_permitted(d); ret = -EOPNOTSUPP; if ( !is_hvm_domain(d) ) @@ -666,7 +674,13 @@ long arch_do_domctl( "ioport_map: error %ld denying dom%d access to [%x,%x]\n", ret, d->domain_id, fmp, fmp + np - 1); } - if ( !ret ) + if ( !ret && !is_iommu_enabled(d) && + flush_permitted != cache_flush_permitted(d) ) + /* + * Only flush if the output of cache_flush_permitted() changes and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for EMT calculation purposes. + */ memory_type_changed(d); break; } diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 452266710a..1f2f2dfcc2 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -703,6 +703,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) unsigned long mfn = op->u.iomem_permission.first_mfn; unsigned long nr_mfns = op->u.iomem_permission.nr_mfns; int allow = op->u.iomem_permission.allow_access; + bool flush_permitted = cache_flush_permitted(d); ret = -EINVAL; if ( (mfn + nr_mfns - 1) < mfn ) /* wrap? */ @@ -716,7 +717,13 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) ret = iomem_permit_access(d, mfn, mfn + nr_mfns - 1); else ret = iomem_deny_access(d, mfn, mfn + nr_mfns - 1); - if ( !ret ) + if ( !ret && !is_iommu_enabled(d) && + flush_permitted != cache_flush_permitted(d) ) + /* + * Only flush if the output of cache_flush_permitted() changes and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for effective cache attribute calculation purposes. + */ memory_type_changed(d); break; } @@ -778,8 +785,6 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) "memory_map: error %ld removing dom%d access to [%lx,%lx]\n", ret, d->domain_id, mfn, mfn_end); } - /* Do this unconditionally to cover errors on above failure paths. */ - memory_type_changed(d); break; } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 18:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 18:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410425.653396 (Exim 4.92) (envelope-from ) id 1obQUa-000363-EO; Thu, 22 Sep 2022 18:00:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410425.653396; Thu, 22 Sep 2022 18:00:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obQUa-00035w-BO; Thu, 22 Sep 2022 18:00:08 +0000 Received: by outflank-mailman (input) for mailman id 410425; Thu, 22 Sep 2022 18:00:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obQUY-00031O-EI for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 18:00:06 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150088.outbound.protection.outlook.com [40.107.15.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62d1a23d-3aa0-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 20:00:05 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6822.eurprd04.prod.outlook.com (2603:10a6:20b:108::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Thu, 22 Sep 2022 18:00:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 18:00:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62d1a23d-3aa0-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KC+mHbrzWii3ebYyNjTR2HnKUqSYEvuiS6Tkh8/OYofO6fvQ7eTNwlVW5a67n6f+3K9Zx8jym/dt24mAMNnVcAOjpuc6LzNl2Y2CAi1H/8zNnrn2V59MKGsniWTyqpyA2JdpIjD/F4m4jc+fwdw91DN080AVyCYCrbndKUxGsr5PkTe6pbaFZ2n9kn1warjfDuY9KEuCvHmDrwrh93B1Tc+Am0v590Pv+tHegzjit3eejyft8x3pCiil3d3RBai/tIeX8MmndMySMS26XpvhC9+gz7WGnGubvqhGX/7I0vuxEmAg3l3fg0dmZTNPSceJv6/KKQAiL2Om85Y5mPxOQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xi5rwIE4lCmJseog6Mrv9gQQht4AW38k0otLebEJPMI=; b=Qm+3ur6YGLV5FCqGzlz3chr7b3jfk/kY74Up+qH5zrR/1RjxIn5X+yO8YxkR4C5e/y7Np8QXhAn/EusVMtzcXdttANt0Q+yei8+aRV/+TQQkzok49Hd6vHirO2HDZVFiiT6tnZd0nAKrdgx1vxQeh7r0co6hpT7UegIKx6g3GD8V/sNKuuiQnWSe3RtJrreXT4YklM9vhlB6tgjejz22rg3XdOmVAnhUFx/wOk/4mshlm4OhKAfwCprvXLf9ZAwoHKD1ZCPMkzbrEqjtus5phr8wpsT35jkrOTWlljD1qYjYz3ui0uQt76bxXbkoCt03aVraBUjlFTWndMFTh0P3dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xi5rwIE4lCmJseog6Mrv9gQQht4AW38k0otLebEJPMI=; b=OA4MJghVI3yiESr598Dm+0F2lHKZPp0Do7F7DyGwYMr54yn5iIL8fl+7Q9KHvYjnay1heh3HS8uQCKgtfuch2hna2IBkdYJhDf3qX6Ka1jV58+aX45HB2JrXnl7+cNLjBr28vK0w0QU+mxQlq1PzkoAEsdrHoeDeKhqm5qEC/VICmJND+xp6ACjdyNXUw1Xu1ttVsDrvs/e4mzO9bSq1CkcrMMvtL+kwEqRL/17PUiVQHMkONa+ly58bNOluURXgjW92DvoFg2mJtTg86PpxGr23Imupub6F4IcMQMDm1vRre5LyY4Ztu+ub108/LZARtb5e6e9pCjpjtspFjJXXRg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 22 Sep 2022 20:00:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Design session "MSI-X support with Linux stubdomain" notes To: xen-devel@lists.xenproject.org Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD References: Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0166.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6822:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e568f2a-8946-41f9-671d-08da9cc445b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PY7dtbvfrfomCuoOJo4L8b9YoX2RcCe1T8CJR+qpg5Cw3dDkiecRp/nlsPXwhhNpeNgCorfPlGtfLaqVkWvAIxxsAo4Fzts8oQLuP0U25TuGEXbwwOZ6zWnICwQSRP4epeuyLRQNTHM/+0pAfn9QVE8EZ3MBt1tnq/VTrp82oFv7zOXHb69dYDuLWiQrfVzFE/y3yyLgNHkzjy9VKkGViKWo3G2r5FsQLzklPzvGVHbz/f8EIW7kP8Jnew81dPmQVu0AZ2X0D9suPAYYv+k7nZROlT5F7tzLNaR8EPKv64gvEPPQJcLE19StSaSosEcttaIcItoE9G7q+xTUjJWNrflfVTLsn4GBCz0fVSCSAxIBIL9e6jasMMbcoc1mrKN4yEfiEUdjIoMbLvnjCVHr90ryK57WggfUObb4oljRqnQLnV41uN1tG82xsnB2zjJIYeWv+IwloYew/cshUFT3knbxskgI1gJEFoOV56YJDzbgKn/txrZr3driZTs21K2++Y/U5n+BGzPafzj5+04ogf1zdhOvya8HRVEm8fUhX1QPkG9owbVDO6OLIN62Fps/9dssUq1rChdZ4OYgH4BdFrS3MTibXM9S6SHBwEgiQ0f5K3pEw8X9EFsJnErOPM6Z/2QGvUFUUAmXU+4Biy33j8xZMrFIlJQxIVhGOBAnlAf1ypL5bo8xZjPPHp/mC0r/5DqKl7CS2z5JuiT8fF7Cbd/0se5ETheJF7DwQRagqOpLze/ZcejyzD5eF1hhGaKy16uLm/1GEGDGtPQZnhDilXYGEjEAd5UhienDsoQbjiE3aIfO4vYttDDPDBwt8OmB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199015)(31686004)(83380400001)(2616005)(186003)(38100700002)(8936002)(5660300002)(41300700001)(6512007)(26005)(966005)(478600001)(6486002)(6506007)(31696002)(86362001)(66946007)(8676002)(316002)(66556008)(66476007)(4326008)(53546011)(54906003)(2906002)(6916009)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVd2OVJkMHFaZlczYzFFbkY0cHVGQ1ZQYXRzMCsxL01Ma2pCWGZrRC91U05q?= =?utf-8?B?bVNYaWVvUEJlbHE4SDhhSi94UWhLUTVaVGg3U1JwcHZQK0ljaEN3WGpKY21E?= =?utf-8?B?QndvWm9Cc1JxNFY5d3NrVjZyVTFWbGNuYzVnUVJNcUxCMlNTNEZJQ2JuYzh3?= =?utf-8?B?MWtRa1JVUk5uUEFqM3IvSUlzTFBVUnE2LzZFZyt3R1N1L2p0Ung3dWdta3g5?= =?utf-8?B?M0pkUmt3b1I1ZHEyU1N2TWVyRXBIcGRpYzJpL2dkekxZYWp2ZWtLMTM5VGNZ?= =?utf-8?B?NlR5RFRubjErSWF3UExNVFpFSWRlTFZVTklKTitOc2ZtbmdwRGNSQ1VRYlF3?= =?utf-8?B?aFRJbDJUcFpJcWwxV3ZhLzNyQ1lZZE1LaE82QVk2RmJ3eDc2VHp6U3dlVStv?= =?utf-8?B?QmJjYWpnWmxRbGN6ODlCTEpEb3dLUDRKcHJJYXE0dnlUckFVYnE1MmhVOWRr?= =?utf-8?B?ZUFqYzRLY0IrbXNyM3g0bGFkZU9sT0VRU2FOZ1lWaTgvdWkzM3c0dFJPRWlM?= =?utf-8?B?S3dMWFl0Yno3aHUxc0JMU1prR1VneFFxZ3lkWUdkbEdvRGZuODhFTTNYRTdR?= =?utf-8?B?NnN1MjB5TGpldzhTOUFkQmYrUERFUDdMaFFFYXJjeGxIRnZKZ2orLzEwMEJK?= =?utf-8?B?dUtrQVBvM0VacEFDcFJ6VncxZXVUdmVGalA2RFZrRFJLNEh0QUY2ZjlUWTJC?= =?utf-8?B?OENSYnQrK3VNSXFhRW9CYmFtT3dHZ090NDRuVTFUbHZjcTVXZysyR05rM3Bw?= =?utf-8?B?WnlkbnRQVWQ5K0VpbStwNWRma2pOaWxaVUlmYW1ZbmxZSFY2RHBSQ3dKd2NR?= =?utf-8?B?b1dKUU1aNHltb0Z0eFVML0JJb0NTWE5uWEc0N2pVem5qbFFoQTZ6Z2JRWWJw?= =?utf-8?B?ek8yenJId3A3ZGdRaTE4L2hWNXVlQUhicGFGMEhZN1NPRlE5R2g5WmVXN2Q4?= =?utf-8?B?NTFILzRzclp1cEVldnRmQU1sZ1l0THRGQUZZNlprNkw3SG1hY3B2VytwZmdr?= =?utf-8?B?Y3R0SksreVVuNndFUTArZTk0NmNIUTh1bjk4VUIyY3JjWFNzcFlhbStTb3lD?= =?utf-8?B?THNjS1VCVzN6Y05IT1dHeEVIZlIvdFlGQzJvaUNwN2FGYmtOUldPUnhEZVBs?= =?utf-8?B?eUg2dkY0YWkwaENjQy9oRmFaUVVhQWd4cFViTXBLMGlJbEtQU2RTOXVFcUVJ?= =?utf-8?B?dkN2N1NPT0w5ODcyRGpUOXk0ZVA3YUhZc2w1SDJUUEJrK2c5c0FBZzB2WDhL?= =?utf-8?B?SDZrNFhxWnBQYXg1ako2dDkzayt1UFJwNGRkakMvbEpBS1B3TlJhUmVFSG00?= =?utf-8?B?L3crc1VBaTUvOHhXeGcwVTBTSTBKajVyUVpURVJ2TWF5ajFyVENya0k5aUs5?= =?utf-8?B?QjFxU0UwVHZ6aGdVL09LK29xUnNwNllJQmV6c0V5YS9IUXFzTjFGcE9taGtP?= =?utf-8?B?cVRkL24wbGllblNtTmttUkcvQkl2czNEUzJTVUlCNjVMbTFvYS9rWGgxQnpt?= =?utf-8?B?R2VSRVpMNUR5VnVoK0x4QlRLSGRnNnE0dG9kMlR5ZUlNRXM5VTRvUkZvSTNs?= =?utf-8?B?WThuMEM0ZU1YRHJaRHh1Z0RWWXRCb2tLK3Z6VURaVURIdVdsQ3F3VmJGaGlH?= =?utf-8?B?aVJzcmUycGVzMlRycDJSakUvN2xESzZjRGFnVkdySERRRUNUVmhqSm9PS0JR?= =?utf-8?B?UDJIcUFNZnJNMWw0L08wZi9IOUhyUGo0VDFORnlZZGErTHg1NnZUSVRxVDg0?= =?utf-8?B?VVgxMWpaUWhTL1U1bDMzanE4c2w5MHZBR0ZrTzhZYTBoT2VRbkMySmJhQW5D?= =?utf-8?B?dXJ3YW94djZVTEZROGdDZHB1OEtlWlYyWEtNV1Y3ZXR4RnFzcmJGR2k4UEwz?= =?utf-8?B?WFZEMWpHbmc1VXBhemJoVnJlMGwvaEJDV3dmN0JacFVUTEtIUGlZNmkyc29V?= =?utf-8?B?NVYrbW45bUk0QldTcldwNnEwYk15anFiUlVwN0NOSitaMy8vVi9icXBISFpq?= =?utf-8?B?NitIdXZZcVkrOWY4WDkwR3E2cjJwaXVZTzFLNk5TZXJVQndwd2d5dlVIZFE4?= =?utf-8?B?YVZJZFJaV1VFVXFjSUVpdHMrbUg3U29aMFFCWXdOaVAxVStzN2ZuMFovTFpr?= =?utf-8?Q?/p5j9LQljf4nbTd3As5NfoSG1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e568f2a-8946-41f9-671d-08da9cc445b7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 18:00:02.9141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JADjBqixK+UgUbgDlt8jdXGAPzMkiXhYSN4QhhYFP5tz0SEjOydQKDfzjEPtKHhmovFFn0d9/PUuoinpMENYFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6822 On 22.09.2022 18:05, Anthony PERARD wrote: > WARNING: Notes missing at the beginning of the meeting. > > session description: >> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn’t >> support MSI-X. For the device to (partially) work, Qemu needs a patch masking >> MSI-X from the PCI config space. Some drivers are not happy about that, which >> is understandable (device natively supports MSI-X, so fallback path are >> rarely tested). >> >> This is mostly (?) about qemu accessing /dev/mem directly (here: >> https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) - lets >> discuss alternative interface that stubdomain could use. > > > > when qemu forward interrupt, > for correct mask bit, it read physical mask bit. > an hypercall would make sense. > -> benefit, mask bit in hardware will be what hypervisor desire, and device model desire. > from guest point of view, interrupt should be unmask. > > interrupt request are first forwarded to qemu, so xen have to do some post processing once request comes back from qemu. > it's weird.. > > someone should have a look, and rationalize this weird path. > > Xen tries to not forward everything to qemu. > > why don't we do that in xen. > there's already code in xen for that. So what I didn't pay enough attention to when talking was that the completion logic in Xen is for writes only. Maybe something similar can be had for reads as well, but that's to be checked ... Jan > Issue: having QEMU open /dev/mem within stubdom isn't working. > > We could look at removing the need for /dev/mem by improving support for qemu-depriv. > > hypervisor configuration interface was intended for one domain. having stubdom in > the middle makes thing difficult. > > See QEMU's code > https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579 > fd = open("/dev/mem", O_RDWR); > > TODO: > step1: Find out why qemu wants that mask? > step2: identify what is missing in the PV interface. > > QEMU use this to read the Pending Bit Array (PBA), and read entry in table > > comments at L465 (of xen_pt_msi.c) doesn't makes sense > > Xen could do more fixup > > passing value from hardware?? > can't pass vector to the guest, > xen overwrite mask bit. (or something) > > Did MSI-X worked in qemu-trad in stubdom? > No one in the room could remember. > > MSI-X is required for pci express, not that thing are implemented correctly. > > TODO: > - get rid of opening /dev/mem in qemu > > > Cheers, > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 18:12:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 18:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410430.653407 (Exim 4.92) (envelope-from ) id 1obQgT-0004kQ-G2; Thu, 22 Sep 2022 18:12:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410430.653407; Thu, 22 Sep 2022 18:12:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obQgT-0004kJ-DH; Thu, 22 Sep 2022 18:12:25 +0000 Received: by outflank-mailman (input) for mailman id 410430; Thu, 22 Sep 2022 18:12:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obQgS-0004kD-Kt for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 18:12:25 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 199d2f62-3aa2-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 20:12:22 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3FB3E5C006A; Thu, 22 Sep 2022 14:12:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 22 Sep 2022 14:12:20 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 14:12:19 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 199d2f62-3aa2-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663870340; x= 1663956740; bh=5KUg0reqSIZKpByEeHPV1qhH2O4YtqXBthpOj14pdLk=; b=i AIvZ8ch/KvS+h2V6IRSMMbdAaTdFShUkMWKtI6sdzk+Wxj1rZvNqABiakXCl673f AhCKfbARYpMBVv4gbeELuo2563w3zjO70Ia0n2PbFD85OL93LmfHm5h4d5eyeCn8 9nRqw4SUL4kwN7YNPQg0gF7h86lcs0ujFnmpm8pDr5u1iMQrmVdw+7u4pOnVzHsq XJhO6CFveVXX9jdcPaPcRkxSPG2VnhjuDguvifvNdHSwYmmahks2bCagSrnrujKe TK8Z2iB0biDfMQOJguAMEoKOk484LygrUMIClZowHwbnE21OH1E0rL5R7U9+Arbt rTonQ7HYCMMzLWmbf7kOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663870340; x=1663956740; bh=5KUg0reqSIZKpByEeHPV1qhH2O4Y tqXBthpOj14pdLk=; b=kFYcX0w0ENEotdONkAlUOhTVGrqLEx29hOmVYq4Ua/Nz +YYFWHWI8ZWACFsm2To8q6rKGTekzhNONxqOVdqnuM4vYza211t0z4jRIpUqSQou M7V8XFA4e3222jLI1+Rcu0kKaC7qB8B6Py/anhtXmpecu+PRSGpoyhAcQ966LryF P1aBHhYBrrx/njkRjMHYnSIJ4oAUHqELrQs0XmoBbIMxWQ2wNLI7DoEQRTwyOcfy C30R6C+DwKASQnabmyhd1n2f2F8ZrhkwBa/YcsfNjx81RQZF7DAEtOzvU2TWVg4e N3O9Qj8JYWwJgNKWxjLGlSuas3AbpjMR6XjfFKp2Kg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 22 Sep 2022 14:11:51 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Message-ID: References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SFzkhd+vEYb5WUsk" Content-Disposition: inline In-Reply-To: --SFzkhd+vEYb5WUsk Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Sep 2022 14:11:51 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3] Support ESRT in Xen dom0 On Thu, Sep 22, 2022 at 05:05:43PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Sept 2022 at 16:56, Demi Marie Obenour > wrote: > > > > On Thu, Sep 22, 2022 at 08:12:14AM +0200, Jan Beulich wrote: > > > On 22.09.2022 03:09, Demi Marie Obenour wrote: > > > > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > > > >> On 20.09.2022 18:09, Ard Biesheuvel wrote: > > > >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich wr= ote: > > > >>>> > > > >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: > > > >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > > >>>>> wrote: > > > >>>>>> > > > >>>>>> fwupd requires access to the EFI System Resource Table (ESRT) = to > > > >>>>>> discover which firmware can be updated by the OS. Currently, = Linux does > > > >>>>>> not expose the ESRT when running as a Xen dom0. Therefore, it= is not > > > >>>>>> possible to use fwupd in a Xen dom0, which is a serious proble= m for e.g. > > > >>>>>> Qubes OS. > > > >>>>>> > > > >>>>>> Before Xen 4.16, this was not fixable due to hypervisor limita= tions. > > > >>>>>> The UEFI specification requires the ESRT to be in EfiBootServi= cesData > > > >>>>>> memory, which Xen will use for whatever purposes it likes. Th= erefore, > > > >>>>>> Linux cannot safely access the ESRT, as Xen may have overwritt= en it. > > > >>>>>> > > > >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootSe= rvicesData > > > >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBootSe= rvicesData > > > >>>>>> memory, Xen allocates some memory of type EfiRuntimeServicesDa= ta, copies > > > >>>>>> the ESRT to it, and finally replaces the ESRT pointer with a p= ointer to > > > >>>>>> the copy. Since Xen will not clobber EfiRuntimeServicesData m= emory, > > > >>>>>> this ensures that the ESRT can safely be accessed by the OS. = It is safe > > > >>>>>> to access the ESRT under Xen if, and only if, it is in memory = of type > > > >>>>>> EfiRuntimeServicesData. > > > >>>>>> > > > >>>>> > > > >>>>> Thanks for the elaborate explanation. This is really helpful. > > > >>>>> > > > >>>>> So here, you are explaining that the only way for Xen to prevent > > > >>>>> itself from potentially clobbering the ESRT is by creating a > > > >>>>> completely new allocation? > > > >>>> > > > >>>> There are surely other ways, e.g. preserving BootServices* regio= ns > > > >>>> alongside RuntimeServices* ones. But as the maintainer of the EFI > > > >>>> code in Xen I don't view this as a reasonable approach. > > > >>> > > > >>> Why not? > > > >> > > > >> Because it's against the intentions the EFI has (or at least had) > > > >> for this memory type. Much more than EfiAcpiReclaimMemory this > > > >> type is intended for use as ordinary RAM post-boot. > > > > > > > > What about giving that memory to dom0? dom0=E2=80=99s balloon driv= er will give > > > > anything dom0 doesn=E2=80=99t wind up using back to Xen. > > > > > > While perhaps in principle possible, this would require special casing > > > in Xen. Except for the memory the initrd comes in, we don't directly > > > hand memory to Dom0. Instead everything goes through the page allocat= or > > > first. Plus if we really were convinced boot services memory needed > > > retaining, then it would also need retaining across kexec (and hence > > > shouldn't be left to Dom0 to decide what to do with it). > > > > So how should dom0 handle the various EFI tables other than the ESRT? > > Right now most uses of these tables in Linux are not guarded by any > > checks for efi_enabled(EFI_MEMMAP) or similar. If some of them are in > > EfiBootServicesData memory, they might be corrupted before Linux gets > > them. >=20 > Yes, this is an annoying oversight of the EFI design: the config > tables are tuples, and the size of the table is > specific to each table type. So without knowing the GUID, there is no > way you can reserve the right size. >=20 > Perhaps you could implement something like a hypercall in > efi_arch_mem_reserve(), which is called by the EFI code to reserve > regions that are in boot services memory but need to remain reserved? > This is used for all config tables that it knows or cares about. On versions of Xen that support spawning multiple domains at boot (instead of just dom0) this will be racy. What about refusing to use tables in EfiBootServicesData when running under Xen unless a hypercall indicates that Xen has reserved all EfiBootServicesData memory? Where could such a check be placed? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --SFzkhd+vEYb5WUsk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMspYEACgkQsoi1X/+c IsGXXhAAnE/hgx+C/LQQqtCsCSnYzvqC77o9FiGo+5shysRLPz4yFrb77xJYmcsb yYpJKT6kafAc+ZRVysENbxgE2+uMlpyfBmFJOiJeQ84opYex4a+qbKAQB8G0SigY yjBVgKBphFvBQWL+u1ZJwBBMfdWeMWZsyxbD/9PNiNaimNaJlAKN6LsmvSCQSCtf oPT4Y6a/ZPptfDOM/1edls66ulNsJDGTguWKN0Eb6Jn7XT072Tx34JY7K/WiOxkC XMZoHXpp34SC0Sugd58VRZKdikz2S5oGSYHaFrzlj32t9Hf7cu4nL1GzELK7h921 lmpnT5KH877qUi97HRZavrcu2ioJ+esTlyu63L59TxQCtoxUeE4a3vyfL/opnS/6 +1ys1NVAd69cA13tPhDwNH660LEIkZ9cCfxJncMmcLJ2At8xLqZkwCq7FekSV8ZL wgsMozH8yjvBPbAlWJ98eXoBUfwIhnfal/t9IE3OAX0fuso1RIdmLNAZ9dlOXoPM 92R8KL4i6CcEdKD/G0ZNkjzkmIxEBC16yL2ViaKbJ6MTFs/NX4tkBWGWex/KZMjY oOe9u4Ux+LUV5Jesj+q2K1g9f9Bb1uTdSbPdWXyDDsIfDZAgGXmc6qkiy3DDypk+ uhc5O20D+OJbttUg38B1CIs2T4JeL3Yky9w/rFzl2lrtkG74RSc= =BTrF -----END PGP SIGNATURE----- --SFzkhd+vEYb5WUsk-- From xen-devel-bounces@lists.xenproject.org Thu Sep 22 18:43:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 18:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410437.653417 (Exim 4.92) (envelope-from ) id 1obRAp-0008QK-PG; Thu, 22 Sep 2022 18:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410437.653417; Thu, 22 Sep 2022 18:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obRAp-0008QD-MZ; Thu, 22 Sep 2022 18:43:47 +0000 Received: by outflank-mailman (input) for mailman id 410437; Thu, 22 Sep 2022 18:43:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obRAo-0008Q6-J5 for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 18:43:46 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70047.outbound.protection.outlook.com [40.107.7.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c80a05b-3aa6-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 20:43:44 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7106.eurprd04.prod.outlook.com (2603:10a6:208:191::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Thu, 22 Sep 2022 18:43:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 18:43:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c80a05b-3aa6-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gsDb2jZArLOM3KzVZNnl4lX2/pVmOJg+3WR1R2TVZsT1rZp8mpkDe0y2g2CYUlMLfNYau4jy/oqIfslWkOKo+XZgxIbU//ImSYnNE71H2ka/g5HDHwEdlWYX+gJX8WD01JR5a+BRtpU4OcM5TJSb2ElFfMkfTE0c7riuw7GB8qrE6ftAFtPl1I04+0PCZcLqjS1Q/rnZMq8AF1m6p7zyDZ9JALoYNiNtYCFvXq+mbLjmp65bNaU2fsMUpUumAPlKcUxqWLWAtQiLYsVIvLJK0T/+a6Crql2Ry0VzdjzSM8M82gohgLMEmOSdn9d5D+KkfJhcGevfl3rbjTUi/9TSdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0AC7OTum4+IlzTQHZ8yDfylRjVI1NYmALQgd1LJyReo=; b=WkAzDxwYzz/wEKvUCg3WM2qKfP13xv99ANDH6xzGXustTULB2vCSRaYFtLA1A506fupPEPrVUgnqXrbJZr4CLCgdZgoH6Lpg9rW3k36k/LcPQdC9P7tNp0n/pK1G7xSxi7ospoR4Uh/rU2RJVoY0axNHtezmXQt0cmsrwQcwfCmvepVUttt38kqItgSWbzsRa2LbpFqIcOGyji3FJHOg/FpNcN23bQmfOPULoyclCJ+vkjFdF4THQtZSb35DoqGrgsefJjFgRpqU/rGVIp4erp4P9s1CUG1TYEUUNuDmcyVoM63VMpE8x9fl83tBxocMnzLzZoEPy62TnXQsxCAGsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0AC7OTum4+IlzTQHZ8yDfylRjVI1NYmALQgd1LJyReo=; b=opkZF9Ksde+XpJnkyq8CV0IGIeO0FBtUhGAgV/D/EwdrvotznERHl/zTm6zJeIa4QzJPKfn8aNxmBXTxMlOU9wM9pn7O2bBkrHKWwMYs44bx6Fg3P7/xk8jbcR7pYksAivLWkfVxM6ZbORnd3vJ5be/u+RBnsAHTB75eyHYsgY4bZwWnLNOr5Wis9RtVk5A6cctaRrR55rLnuCgeUI+EgFrbYUZBWTUWqRu7bwbZ+xBKomBJJH99R7e4E2sFc+Np1UvOSoELyDNLK+C6CVejL1zNSc6MpK7qSRxnES+citfEWF5Zkih9EKCKtZx5sSx5k1aWTdg673bPPqUUdtzjDg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 22 Sep 2022 20:43:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Design session "grant v3" Content-Language: en-US To: Juergen Gross References: Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM3PR07CA0111.eurprd07.prod.outlook.com (2603:10a6:207:7::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7106:EE_ X-MS-Office365-Filtering-Correlation-Id: d9193c85-1efc-4cc8-6f12-08da9cca5f6f X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XLyQi+C+VDNn2sFt1DhLS+b3NAIFMVol5GcptQXYTsj9YiMPYC1CX6+lRn3FGoN1dJyM9rwcTrZdfHPcWqk3PvUdAWMVlUflCRzxgt9dVj3V+4DtSydln6yLslaDVCj5n2XzLP/BFVadcEJ33/HxL9qLzvwgXpoKYDR1hhUVJOOPaFV34+iHWj7ysmRZ73/wiqabaiw8/6saPUBRqbMO+LYlNYV9JGXecjcSzEiS2yf3FZaCXOPErT6o0FgsnqjjwYsTygBL2g0jurBQ/8sd/klHsZe+ixxVHZMIBoNnXr8/MUdqPHC93RechUdg6k/C/3TUxgqiQLR5eTWmQWkO0+ywlIviChaiPl1XslBXSXZUbKizjnGpqWQPVKjZegli+JrfNGK50Z5K2g9h1q0G6nghOVT/bZxtwke+NrgiThu3FQPh82KFTezgfhxAppLE5I7Fcg7RHEOEtBMcs0CPv2NJcvMz5EeR5BKjwFICeb4YbMAXtYZFQrLEMXNvuy4kaZJYsgv9aYVj508P2JvX7RBSMsAjto5YbUtRftygVCjTXUO0uG5ygR0v6u0KRsYDK6fFOgdiGwbFy3SoriCIlkttmBls+9VhFwjY9c+4HFsPxRpZaH73ftWzv3qt+EU2mbIPr0Uqn7z2eE2BfVO7VP6uAw1IQz3GWSDCwCvfLoRiJMWGMm3gZ6zQMY4V6NgHWKeMhIYFCijtI6OkkwIcO4PVZ0ZL9d2q2X1vhKO3AwaHm6UWBMgUtt0w3LGg1YKepvtIhnGOQxQ9kBoscp+Dej0VOX9o9ACocJNGZ+K+oWc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(136003)(39860400002)(396003)(376002)(451199015)(478600001)(41300700001)(36756003)(6486002)(31696002)(4326008)(316002)(5660300002)(6862004)(66946007)(8936002)(6636002)(37006003)(66556008)(66476007)(8676002)(54906003)(38100700002)(26005)(6512007)(186003)(2616005)(53546011)(6506007)(83380400001)(66574015)(2906002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGM4bnRUQlYyckNnQVduYklXK0wwS3FaakJtbU9Oc3kzVFJhYldGYmNFZVRB?= =?utf-8?B?dU1ZeTFTSjZab0xUbVNNbmduSFVjL0dhbWZYNkZvbGtGNVNVNFE2b095YmNm?= =?utf-8?B?cWZRVDdPNU54UmNlY0t5RkdLYko4RlNud1BJOUk0NWU1SytjK21WOU85MW1p?= =?utf-8?B?KzhLWkhYZzYzQ1YxTlYwOENvYmFBQ1VyWXlhR0k4SmljRjBRRHJSN2N5MjQw?= =?utf-8?B?MHkzYWlPdmk3YmFZaE9SZlpQeTk4YlhYYlZkVlBvUlp6V0dOOFIydmxGUi9h?= =?utf-8?B?ZnNWRzFCZURJVEJ6MHF4TVRHOFdqT0ErL2liSlBMVGNmRXprY2NVYk13d0Uy?= =?utf-8?B?TGI4NzFoNGJmTTNJQjZPakI1V1ZpZ0xNdVNzSWlOMGR0U0NTUFNmb09TNHFI?= =?utf-8?B?T0RIcXFHaEhMeGl0bjlPc0kzaHg0eXJaSkJYcW9QR1ZxMmxrYWUyN2cvaEhh?= =?utf-8?B?WGhncjJRdVNkTzZ0KzdkQTBmbVdEVzBWSVQ1TmVaNm1IVmsrTmZRdGlXbFU1?= =?utf-8?B?KzkrcjZYL2ptenRmZ3owZ3B0VjI1c01kNnUzV2lmMVpmM29La2I5RVZMdExk?= =?utf-8?B?RWM0Sm1SODNXTWloZDRVMEV0S21sWWd6Z1MwRWFWOWVVNGVvWm1SV3VqOFl5?= =?utf-8?B?Qkg2eWJFR3ZPWkFoaEk1WkxCa0pqcGFGZXdlNTlOZWgzeWJUR1RDS3Iwb2Uy?= =?utf-8?B?T1puektjMWxoYWMvL1NMY1gvUEVKSm1QcmtWaCttOTY4YktBQVA1ZVc5d1VO?= =?utf-8?B?WHR3cVExYzdXdlZDL044b2pIWXRTSGdhWUphYTUzK3VFTlNSbnRGbVoyRjRX?= =?utf-8?B?QndSUXpsbzM5ckx6ekZwakR3VFNZM2tNRU1ucG1PdmhGbFdNWDNRQTZsT2l2?= =?utf-8?B?OHZtNml0NWE1dG1LMk1sZ3BkNWREQ0lBdHZ5OTREOUJaV2NFM1BPVldNcHMr?= =?utf-8?B?NnpmOG85aTgrK3U1WWNPc1VCWE5oNmtSRXNJMThXMmx6OXlzRTR0WDZiSGlL?= =?utf-8?B?UXppR1M1dkVsUGFwcHdtOW1Mbmh5RFdybmtEcUZQMUNOYzZhc2RGT1BYcG5j?= =?utf-8?B?cVEwT1pTaVZueUZsRFk4Nm4xVjNhcmxCMXRWVGphRm9nTGcxbWYyVnYyUFhl?= =?utf-8?B?dzZRZmxvNUw3SHRrOTlxbUZCTmpLSUJnLzdSK1VQSm04ckxVMktpNXVwOUV0?= =?utf-8?B?RFNwTDkzS0VnQlkzMHVndUlrQ3greStGMlY0c1c3VzlNZ0p3NnBrYWJWWDBp?= =?utf-8?B?VzlIT0JObFRSVG5CcXFXUkJreGRXYUVva2NnUjBodzg0U004K3lNT1NPUUxQ?= =?utf-8?B?d25HSkpSOXNLU2wzQVlNKzV6Qng3SDJ3VHNQbDZjT2lzOVA5YldtL2dYYldm?= =?utf-8?B?NG4rbXE5b2ZjRDM1OC94ZmpjaEdrTFh0aWxtRGdQNUNWWDhBdGdmQUlVQ0hr?= =?utf-8?B?VVdQOW9rMVdGcG13ZVpCTkxBQmxrdHpDV0ZSZHpUQk5FTzEwS3BzQjlMMkhT?= =?utf-8?B?bm5GVUVGQVhsWTJOaWRMTVNrdmpSaEhjbU5KTWtJZklBcVpFTnlRNGZiSnRp?= =?utf-8?B?RUFtYnVFMEVaQ0pyTmN5YklrakxmYkZLTmJLS2FKajAzOEYrczdpWTZmK2xM?= =?utf-8?B?L2xiZ3dkbWdQcTlUaXdKWG9rRzhjekZjWGp0dktSTUhuN3l4UkFyekQweGx1?= =?utf-8?B?VzYreXN5VG5MbHhUbEFwaUNTSFVMcXdFVElNOXJDek5CeS9IMXZpT2VoUHlo?= =?utf-8?B?SDhFcERaY0c0LzAzQXdvRUQ1OGFDUC8vS0RlQWZXQjQ2WGlTV0RIYUZTLzB5?= =?utf-8?B?QllMeXJmRHFoemV1Q2ZxY2FMNUtaeDFucXVHMDVVay9UVEpiWDFvV3NlVXNE?= =?utf-8?B?UkRPNUdYVEN2S2paeXlLTTNyNDZDeG5QUzY2eUI0RVJ6YkQwN2VWSTNPZWIw?= =?utf-8?B?Zi9vK2lUdGM1VVROdnM3OVB0aXpjZEVCdFpHRGl2L0xMWjI0Z25ZdkVCZ0Vy?= =?utf-8?B?cU8wbHcrVENBUGJ5N1cxNkZIbUt4Q2NCb0JDdzNyZ0pQZ1hzVFNqNXVFelRt?= =?utf-8?B?dEorVWJhb0RYYjBMaXlHV2hSeFdpeGtBZ1VaL2hGZUp3V2c3Wnd5ZUp6bzI2?= =?utf-8?Q?k1FZMtkIZcurTOn22lbNpMBfM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9193c85-1efc-4cc8-6f12-08da9cca5f6f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 18:43:42.6217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zy5CmuIP2mNI0+xFVGUMPe9oleMTrdLLgIEGBOPp7AiqcAZsIwCAN5cD02fYys5fD9l9G0pr1XD4Lnfr/DVqNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7106 On 22.09.2022 15:42, Marek Marczykowski-Górecki wrote: > Jürgen: today two grants formats, v1 supports only up to 16TB addresses > v2 solves 16TB issue, introduces several more features^Wbugs > v2 is 16 bytes per entry, v1 is 8 bytes per entry, v2 more complicated interface to the hypervisor > virtio could use per-device grant table, currently virtio iommu device, slow interface > v3 could be a grants tree (like iommu page tables), not flat array, separate trees for each grantee > could support sharing large pages too > easier to have more grants, continuous grant numbers etc > two options to distingush trees (from HV PoV): > - sharing guest ensure distinct grant ids between (multiple) trees > - hv tells guest index under tree got registered > v3 can be addition to v1/v2, old used for simpler cases where tree is an overkill > hypervisor needs extra memory to keep refcounts - resource allocation discussion How would refcounts be different from today? Perhaps I don't have a clear enough picture yet how you envision the tree-like structure(s) to be used. > hv could have TLB to speedup mapping > issue with v1/v2 - granter cannot revoke pages from uncooperating backend > tree could have special page for revoking grants (redirect to that page) > special domids, local to the guest, toolstack restaring backend could request to keep the same virtual domid > Marek: that requires stateless (or recoverable) protocol, reusing domid currently causes issues > Andrei: how revoking could work > Jürgen: there needs to be hypercall, replacing and invalidating mapping (scan page tables?), possibly adjusting IOMMU etc; may fail, problematic for PV Why would this be problematic for PV only? In principle any number of mappings of a grant are possible also for PVH/HVM. So all of them would need finding and replacing. Because of the multiple mappings, the M2P is of no use here. While thinking about this I started wondering in how far things are actually working correctly right now for backends in PVH/HVM: Any mapping of a grant is handed to p2m_add_page(), which insists on there being exactly one mapping of any particular MFN, unless the page is a foreign one. But how does that allow a domain to map its own grants, e.g. when block-attaching a device locally in Dom0? Afaict the grant-map would succeed, but the page would be unmapped from its original GFN. > Yann: can backend refuse revoking? > Jürgen: it shouldn't be this way, but revoke could be controlled by feature flag; revoke could pass scratch page per revoke call (more flexible control) A single scratch page comes with the risk of data corruption, as all I/O would be directed there. A sink page (for memory writes) would likely be okay, but device writes (memory reads) can't be done from a surrogate page. > Marek: what about unmap notification? > Jürgen: revoke could even be async; ring page for unmap notifications > > Marek: downgrading mappings (rw -> ro) > Jürgen: must be careful, to not allow crashing backend > > Jürgen: we should consider interface to mapping large pages ("map this area as a large page if backend shared it as large page") s/backend/frontend/ I guess? > Edwin: what happens when shattering that large page? > Jürgen: on live migration pages are rebuilt anyway, can reconstruct large pages If only we did already rebuild large pages ... Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 19:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 19:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410445.653429 (Exim 4.92) (envelope-from ) id 1obRUw-0002kY-K9; Thu, 22 Sep 2022 19:04:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410445.653429; Thu, 22 Sep 2022 19:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obRUw-0002kR-HJ; Thu, 22 Sep 2022 19:04:34 +0000 Received: by outflank-mailman (input) for mailman id 410445; Thu, 22 Sep 2022 19:04:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obRUv-0002kL-AN for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 19:04:33 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150080.outbound.protection.outlook.com [40.107.15.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6373864e-3aa9-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 21:04:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8356.eurprd04.prod.outlook.com (2603:10a6:20b:3b4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 19:04:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 19:04:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6373864e-3aa9-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NRgA3DxGaHcHWPfTMDXNJaWAdZRfPXqdoJsiyVdKqMSdKQ2Q5dz46nM6+cE+lBcJ99TReZtormqdsf/5rAOIFmBI90HS23GaMbIBFml7e66XECjJJ6PybuwIAmJZP4N/FkK0wU0a9P/GLHC1vFbf2AFvQaujMJANBAla1mzVtnMCsLqz0cWd2m7J6KvAo5ZppiPUSRSeVZLX3okbEc1lQOTnGS0w1OEY5fvEuox/Y3V4kh0OdLxn81B/vO+oWO6VbzNbV+mMB4d0PvMY61f04fhQ77KD0mRlbT5oLHrsCIS3vMtPqkfXc0g5smUdB/1oyjqdTNIe/U4Zb6PjNHErdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a7BfsUw+a5lOMLH2sO+hvWRdQWp1CO3DAftSk/q1PBY=; b=V5OR1Q5z/0DZyPcIEKmfvgIpoJG9eWywZKcNRZlIl1kEIyHJtEFpRemowPXrgnFw6Qg+7Z1ot9ezK+laXBwo7upsd8/RzShaFvMG689cM9XGt9QAFUOQ1cZ2FPvsU4Tiwg4McUvP/8hom7Q0P9npQd44akQfqwFJSvwXCPzdWoZv3CVnTjNQtxPm+aQt3AEND0Ak8ksFbj1hBzoe7i1IO42YBLgGQRHXm3V2DqrONppDNU8G4clrwD4gz3IcFJlP4sct4kALY3TllV32o/R3yc3EfSBC3liR0sxJHm3g/Z9hfq1hzTxrQyN6TWxqAKCVvjVhYR6Oyif98Kl8hCvATw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a7BfsUw+a5lOMLH2sO+hvWRdQWp1CO3DAftSk/q1PBY=; b=pSRDx7EfUO0oETPpSK8monZKQgqB5IYXPxTYZ5SmLbzwsHkKoo6QsxgXQ5dpNl0+an5LqbmqBkFdexN1EexgxDMLIFSceSUFRrOvwnM+Ck1FES1AP39b4OCFI3taFm/8P8WDBnsx3uCpF9xk8niYUaeer/yGfjtw8DyplHDu2l4jbWRR1lyCrLPcj4VJ7EzH3W4mhXPKnXrAqIZjZgZaNIchmanXkHR2AM811Oki5PRHTkljMIwGxD5KueyKF+4yxPc7+m0Ycgt7z6/0xAw5Yd+qrmqF1ZDz7gcfgdaoWjdge7scvUIPSkJ51lhV6wPfxzrUi4JXbO4PVeWze8Nljw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 22 Sep 2022 21:04:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/vpmu: fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Tamas K Lengyel , Boris Ostrovsky References: <8294476a707d7f20799a40479cc0bf9a1cf07673.1663249988.git.tamas.lengyel@intel.com> <9fa4a72f-8b38-fbf0-40c7-8fcd6b34cf10@suse.com> <9e79155f-0836-1b18-b648-b6e5422e89c8@oracle.com> <737386d2-ceeb-ad97-39a1-42585b913b9d@suse.com> <29d29f64-b799-d56c-1292-661fb5127728@suse.com> <406b7f6e-d092-fb6a-d0dd-60a9743027f6@suse.com> <5d1b06f0-fc20-585e-9da0-fb24c5931ad3@suse.com> <8c0c9e20-f3d5-86fc-647f-ee89d63f2118@suse.com> <4d317c1e-3481-6d9e-c5ab-dfd9c559d89d@oracle.com> <2c0e506a-e494-68d5-f4d0-1b54cca2b970@oracle.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0216.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::36) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8356:EE_ X-MS-Office365-Filtering-Correlation-Id: ca28658b-7a3a-4fa3-afd1-08da9ccd4644 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BbTmQECdVkXoP+6IvCxXA2seALwKnCjP927yABsUEzIZO4nmK3rYso27pjoxrin0UJH1NKUWJWAQ91cSLf+VWp9wocZcmav5krehrpLSHQBrIDpQZ1n+3SUQfRlNC3aJGOGNMPd7wdxMNVVbPOlW1c6jrN1sajsYUm2/b4x/9mX+Pa99IjaOeqPsxjmBlaQwiBCZoNduKU48qGkn6Am9/Q81vGdhYel6mKBtFjQTqWLjMxAm9aayv4WZ3jsNGNcjP+UNR/3c7cREuFA5vWpSUkG+V9GHY1XIGgsYZEeI/xAD1hx7sEyDGEhhMfzihC6WMscEPDZEAVtJGuXUpkFIM5gm/18LkG8aPOfPjEFpVDQ61ASULfM11iAfDR1amRLIb3je5IFbAcC3gUi2DDTi8l1/7SC9OPVFy35SubnnGx6ixjS76oWwm6spBdotRNMMElMMzwFPaIDmy+SVQ9TrNT+f3vOVALIojcnMhSHTBc3WcUm28I/E9w4tm6a6Y5HuqRjw3zSHMkU1uNOo+bjICEo4MmJtsMJuNeAnn5aC5FjZYyNmjeQITqx3aot8Wn1yAh3OdS4R437Hvh8PyNPQ/AKtDc+eOLwew6j2mXLW86J2PjlXMBbmkrMF4LU6dagT0ne7iX9NMn0y6y0gfziz5YNnsQkE15QH+0hnGFtaJBzb8iNyuxaXVItCzMfLBXqpxp210GajUDhaiFy+JMlnmFSnQaTG57O591ASyPiPfkve13QIXb9gWiAcDSq/+EoB4VrNHgGGXYsfAfNglyayjnlS25mr31Rb0CAgkSJaexQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(346002)(136003)(396003)(451199015)(2906002)(6666004)(41300700001)(31686004)(186003)(26005)(5660300002)(53546011)(83380400001)(6506007)(2616005)(36756003)(6486002)(54906003)(6916009)(316002)(8936002)(8676002)(4326008)(6512007)(38100700002)(478600001)(86362001)(66476007)(66946007)(31696002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmpnSjV0WEJCdDltSGltUzBPemFXOXhSSndjbjN1WWJTZDZLenFnT05iamsx?= =?utf-8?B?Y2t1eDhtMFp5Q1pac3hhWURoTEhqMjVyN2g2empIZkdVYkNCQUUzSkcrQ3Ns?= =?utf-8?B?dWhrMXQrRG1OejBWcFVkdVVhSXM5SWRTQ2lqWlI0QWlPRllMV1pOZXVWb2lN?= =?utf-8?B?ZUZVeTZnc0kvS1NMRUdWNVJhZnhRNmtKV2Z4R3NoQ1FZSUxOdjE3SnM2dys4?= =?utf-8?B?UWY5Znk3QUxXNXVFVXdRU0pMZnBJOVNyZERaY3FiT2JpOW9RRGx5eURTREVN?= =?utf-8?B?VzNJTlhnNHhXMElhbXA3RlBmNGpNYi9jbXFHUUtiM09QS1ViMFYrL2duY2Vj?= =?utf-8?B?Rk9sajlKWmpNdE93a29FZlpPQ2JON1c3aE1Nb1dhcW1Vd2hnbVV0czRDcDcz?= =?utf-8?B?OCsxWnhaZXQ1TzRCVm81R1VYWTMrdEpqSTNzMVZQZkJ5U09GakN4NHpickFG?= =?utf-8?B?aW5sSkFrbDIrUXZmVE40bWFXTkdnTlVtUGtISjNjSlhXcU9KQWczLzJocWpz?= =?utf-8?B?L2FWN1BGNGwwVTVrNkpseEU3ZTZHb3o1ZFc5NGlOYWYxMG56WHNkbmttZWRY?= =?utf-8?B?K0VXb1JvY0RRcUlMUEhQVmZ0ZWhpMmN5T25nV0FGeGtXL2d1YUhvOUxOc0dT?= =?utf-8?B?clp0b3V2a2FJelh0R0tJSmx0NjNTdXpKTEdoZHZSWm1TOFpXNERmdVFNRnZW?= =?utf-8?B?TFZIKzQrdGx6TlN4bTIvL1JtakZyeVlxYWU4TEFTUjRoUmRweWR6Ui9NeHMw?= =?utf-8?B?ZkhCM0tZbWtIODJxWmtHeWxCbnM1WVhwa1hhTWNMZmdVQXdtZWdWRU01Nkpp?= =?utf-8?B?T0RGUmNEdlN4N2Zadm9vV2h6ckdMaDh2bUFvdlZ5N3NQczhuV3FSaStYVVJV?= =?utf-8?B?Y01yYUNydzBwSlpJM3lSL2RsalpNUmZsRDlYajg1MndYbzZod1FOUEVMZ2ZN?= =?utf-8?B?c0lBV1Z4dHM5VjJHS2pLNXd0OU04MGs3RTRKMk40a01Ja3FIUGF3NWp0K2dS?= =?utf-8?B?czJiSUNXd0tlNVVId0tKNE9hNlRZU2ZuVG5pdGtHSzg4K1Y4NXlpR3k4YTVO?= =?utf-8?B?TWJxeTE3RVVoQUtEdVBTMUoxaTlvOERpZUtxNVhyelZ1b1hySVIzekluOVVo?= =?utf-8?B?RmpSWEttUktRY2txOWhkNW1BenMxdnpzS0NDNWlsUnpxa3I5S2F2YUtFMmJ1?= =?utf-8?B?NkNOQkVPWk4yQ0dBRit5T010K3FScTBkTDBmUnlBMVVjQit5YlZuNitrMTNr?= =?utf-8?B?czhuTVoxcXNHWkFSZHNKSWl4VDZLbVFWS1hnVlVFSXp2NUV2OWVIaEJXUUxO?= =?utf-8?B?RWNETzd5eGhCNWJSYVBJeU9FVm9TK1EvS2FTa2d4WnhBS200R0ZYQ0VvRVhE?= =?utf-8?B?YXlqZTJ6YUxHcDFhU0VaNWFENkVFOGh0N3VXNllmODJwUTNMeFNEN01sc1Nn?= =?utf-8?B?VXZzNnRkemkyOUQveXQ2cHZXem5Lb0FuRTF6bjg5d3dQUkFBVWtVNDJHaUc1?= =?utf-8?B?bjBGQlgyWVBZN0ZnQUU3Nk5vUVZ4NEx0TVU3Z09jUm8yWWtnY1NadENPZ0pO?= =?utf-8?B?T01rOS92N2M1ODNSbHZCQVBOQ3JyQUl1ZnkxOWpBOFRtUE4wdzZ0LzBlTzFP?= =?utf-8?B?K294V0g2c0F1UkhlRFZweWlJTGx2NWR6SENKZnBJc2JRQWcwd3U2WUFzdUcy?= =?utf-8?B?Ty9pMFZhZ0tDNFRTSWM1U0s1MGV6bmE5SCt4SnRjUEFPU1FsdDc1SmtLT0Yz?= =?utf-8?B?Q2RBejdYc1ZYZ3R2dXo5SERFazRqb0RSMlpjQjFYRzJzbWFOd09NSVJRdGcv?= =?utf-8?B?RkVGMnJaaldxZGdJTk1HM3FHQ0FYekpXNVVLQ3V4SXkyb1hZUE1rNUh4elNF?= =?utf-8?B?cHFENVhTaEN3ZWRsSXA4WGUxczF4VnI0eGpPTXlLMlhhODRnckdzYzc0RElR?= =?utf-8?B?TWJuaW5iRllvdytkaGFtUXhrU3JUcXN1dWJONWQ3SHNHY2poZnBmY1NNS3BL?= =?utf-8?B?T0ZWUlJvcHI3TmJOQWthazExcGRtNkJZQmJUaE9LRXAzc01TdGhabG9JTUJU?= =?utf-8?B?bjFzRG8ycXk5ckpTLzU0N3FVT3doNGRDUWN0VEExeElmNlZqcE1yVEdpbHE0?= =?utf-8?Q?vbMIrr6DtXRFond+iG+K1tqOU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca28658b-7a3a-4fa3-afd1-08da9ccd4644 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 19:04:28.9200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b8LVgBpUtYjWJgsPlcw1CtbBRG0H2yyPZin5yapEalsJj++LWR4c0bCrIf7af+cRzL2BnRjzrtIJYunpa4TOCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8356 On 22.09.2022 15:35, Tamas K Lengyel wrote: > On Tue, Sep 20, 2022 at 2:27 PM Tamas K Lengyel > wrote: > >> >> >> On Tue, Sep 20, 2022 at 2:12 PM Boris Ostrovsky < >> boris.ostrovsky@oracle.com> wrote: >> >>> >>> On 9/20/22 10:54 AM, Jan Beulich wrote: >>>> On 20.09.2022 16:26, Boris Ostrovsky wrote: >>>>> On 9/20/22 4:01 AM, Jan Beulich wrote: >>>>>> On 20.09.2022 00:42, Boris Ostrovsky wrote: >>>>>>> It is saving vpmu data from current pcpu's MSRs for a remote vcpu so >>> @v >>>>>>> in vmx_find_msr() is not @current: >>>>>>> >>>>>>> vpmu_load() >>>>>>> ... >>>>>>> prev = per_cpu(last_vcpu, pcpu); >>>>>>> vpmu_save_force(prev) >>>>>>> core2_vpmu_save() >>>>>>> __core2_vpmu_save() >>>>>>> vmx_read_guest_msr() >>>>>>> vmx_find_msr() >>>>>>> >>>>>>> >>>>>>> The call to vmx_find_msr() was introduced by 755087eb9b10c. I wonder >>> though whether >>>>>>> this call is needed when code path above is executed (i.e. when we >>> are saving >>>>>>> remove vcpu) >>>>>> How could it not be needed? We need to obtain the guest value. The >>>>>> thing I don't understand is why this forced saving is necessary, >>>>>> when context_switch() unconditionally calls vpmu_switch_from(). >>>>> >>>>> IIRC the logic is: >>>>> >>>>> 1. vcpuA runs on pcpu0 >>>>> 2. vcpuA is de-scheduled and is selected to run on pcpu1. It has not >>> yet called vpmu_load() from pcpu1 >>>> The calling of vpmu_load() shouldn't matter here. What does matter is >>>> that vpmu_save() was necessarily called already. >>> >>> >>> I thought we don't always save MSRs on context switch because we optimize >>> for case when the same vcpu gets scheduled again. But I am not sure I see >>> this now that I am looking at the code. >>> >> >> I see context_switch calling vpmu_save_from before __context_switch, but >> if that did actually save the vPMU state it would have reset >> VPMU_CONTEXT_LOADED, so by the time vpmu_load calls vpmu_save_force it >> would have just bailed before hitting the ASSERT failure in vmx_find_msrs. >> The context must still be loaded at that point (I'm trying to verify right >> now by adding some printks). >> > > OK, Boris was correct above, MSRs are not saved on context switch > automatically because of that optimization. VPMU_CONTEXT_SAVE isn't set, so > the only thing vpmu_switch_from does is set global control to 0 in case it > was a PV vCPU (see core2_vpmu_save checks for both VPMU_CONTEXT_SAVE and > VPMU_CONTEXT_LOADED) and vpmu_switch_from doesn't set VPMU_CONTEXT_SAVE. So > for HVM vCPUs it does nothing, that's why we still see the context still > loaded when we get to vpmu_load. > > It would be a simple enough change to make vpmu_switch_from always save the > context and then we could get rid of vpmu_load trying to do it later and > getting into that ASSERT failure. Thoughts? I'd much prefer that over e.g. the vCPU-pausing approach. I also think vpmu_save() is misnamed if it might not really save anything. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 19:22:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 19:22:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410450.653440 (Exim 4.92) (envelope-from ) id 1obRlv-0005Nl-1u; Thu, 22 Sep 2022 19:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410450.653440; Thu, 22 Sep 2022 19:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obRlu-0005Ne-VG; Thu, 22 Sep 2022 19:22:06 +0000 Received: by outflank-mailman (input) for mailman id 410450; Thu, 22 Sep 2022 19:22:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obRlt-0005NY-O1 for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 19:22:05 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130045.outbound.protection.outlook.com [40.107.13.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6660c85-3aab-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 21:22:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6802.eurprd04.prod.outlook.com (2603:10a6:208:184::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 19:22:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 19:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6660c85-3aab-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9b3EuY3RU2vIMp8jtEPxO0YkT64p2gETVTXxbsk9uztCLlvoWM1pXGN31mhQ8mVL7XJN1rrEQagq5fXYIUuFqNJrk0aN7bQhPLD42JQ16rf26erMcgpkgWDgoBEIWu3pJNw87zGkhpJBSBhP28vjFBn02iF+sk7PyTp3i3T+H6bOpHz4jNXZRjcKZEX14YedR7KiHJHxGpirBPKV2jjYTa/noBX7ncGci4x4nGfEuzQY/1YQc0Lsx0EdL0nj7N5EUVB0q9ygNhMbnN/hsZusnqdfKxITlKOqB0BHqyoLrpHELNy+L8bzjC2ESn2WZJUPgtyw+epcK9AI7les4LRHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RyZNMrj8cvt+y2w2yr3PUS/ScdXrCb9S/TOIQmJ/6jc=; b=Cr54wxPN19AxAs0VS9dqMWufzRj1scgiCWqq4tLA9a8S0meBCOhtDewfGfOz5jMHsAOvmBWysT073R0ZyDt2lBBbN0RR1qbgswNhqmJ1l8vRWnWAmQB5VDkaKZLBioMZ8Sry/4AbXV5QGRnyQOb3faFlsYBMD8a3o7izSn/gd3rTjt4BLxFKTHZQyGaRo+iSyPZmf40Lu3W0m1zwKvyrIK6pEVBNCHaLAnazR8rYW9yKPPbqfVwES0wq+REEr/pQ+IeFRqunyh9Eau1/1F8btRR+4wKDJ2lOEZVFd+mmjXWg+QlKoHqMoxSjuvOif6KpIY8rjpFQ9voCmPQtT68Ogw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RyZNMrj8cvt+y2w2yr3PUS/ScdXrCb9S/TOIQmJ/6jc=; b=lotIu3PwfMpJlmpNRlRd3Kn2FEGv3wiQGloIQl3++Xkul4qrLUjJG70xvB2kG2hQSxIRExPY63cwV2tNCVmZayJphBpoPlBVLb3veXjEwyDV9tgkds4GGTyFc7JsQlbBnbOgsd3XDKsOOqwAqCsgQve2wr3sS4kW+jn8xEOeC3xEKU2lsZY3aa95ZcEoOCXGEdA/Lglq6uE8gLIssif7NMtLZEE7QaP7MlSYnPVwJApW8zvGdPTx+WLZ2z07KLU9zKFKqiF3oIE5oLJWAIEtpgWgvDCIwx3j5XMoUnJ81/N91Ijg/wT1oWt0mdCN8lQxvtdRqnjzk1qN3fm0zSjzMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 22 Sep 2022 21:21:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220922160516.5929-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220922160516.5929-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM4PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:205:1::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6802:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c06fa34-88e2-4231-6be7-08da9ccfb966 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EQHaBH6bn+sUSCYZMGyXINn2d7f9wu6V0Fb7eE6EaG+kV6rwT8b/PXEj2DpJ07YdDJeIYvwE6bLxciw0W+t5ZipBSEHEFeI0cN+gmzRwToS7SzdYoF29vysBeTJnjMtP+LDrTmPagNwb/qvHMqcOp3XbUg0s+ghv3Q831TY3bWtZJD9JaZAUGIOm2naGPRwuiJGUSLFkTZDXmcYVo7CEgF4zktmu07LITGCYANFzZQMGd2Xcw6bfU/EHR7lkx9FFZKUBXmSI+xSJ0SLyBnVe4enJuK+5U5Twbk6iaQjpLeqTshJBNK8XVxCYraXWH1SMkV9VkK32QE2FPGss/xACf+Z00FNkHnKUSySG9Yj9NiQzyrh3e6UAzUvO1nocm9WZ6HKzevOpjv1LUDypalZCsqA5ocseB7ay74TBqGW3cOphixxWr4c1MHcGBygnvfWOV01sh6RMitw2Wi+slt6gETHuuI5U7xausBqy0dhZaOxEn/kDK2DAuYru8WOB++hnMKjTi5OlPpqgU6gBzZH7EPcBO5BOuvQZcrY6gbJgiWdb9C+EKRGFeGD9JESfnHG7x0K6T8qCwM5Dt9W858E+9Mo33lEXDTXIrQZ55P2uQfREuWV3bB02mtRIB0lWXL4KpiRM49yONA8ZOJUQowG4uBo8vgzzYBdSZtI62yef8/coabzwRTbfIGPbQtzpHiZhymTSa7rxJsgJqJk8xbDjm7Lm6OKes40vWbY+T/wk3RJD2xDb6Gq/PMOdu8Ef1kt4LvoO290NpETisIs+A6v9r/JzpFdd/Xwb635qHqmYMP8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(346002)(136003)(39860400002)(366004)(451199015)(66556008)(8936002)(31686004)(2906002)(5660300002)(316002)(54906003)(6486002)(36756003)(66946007)(478600001)(8676002)(4326008)(41300700001)(6916009)(6506007)(53546011)(31696002)(2616005)(86362001)(26005)(66476007)(6512007)(38100700002)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmpDMkt2U2J4RnFTT1NHMmJQM0pZQ2EyM20zbVhWZnd6bDVXSWFSWGRTaXU3?= =?utf-8?B?WXAza1pQZ0prK1J0ZXlMTVE3WEZVRHVxemlWakZvZWxFcWJpVjdtcVdxMk5w?= =?utf-8?B?V0lnbWZKTzRFTytOYlV3MHl5Zm04ZWtMVktnY1FZZnR1N3hXT0FMcGM3U1pB?= =?utf-8?B?MGl3dFkyZWxMZ1hlNmQ0L0xVVStOYktkWEc2QmNPeUR3UVIrdTgxaVd0WERm?= =?utf-8?B?MHFUUjY3TGN4Tm5JbG9ZUDVMUlJnQnhRNk01VEx1Ukkyb0pzdGtwWnN3ajhs?= =?utf-8?B?TEs1RGFGY1Ewc2pTWW5hTEJ0YnlUalBVOGhlUEo1WUN6dm5UbUgrYis0ZGt0?= =?utf-8?B?b1ZzNkxscmRrK1RrRnZrT0VSbEh2QUZwenVwa3ErbWpYdGpHcktTYWp2M3ZI?= =?utf-8?B?MzV0TEl1cXYyQXpsR25uZjJqcU5PK2oxMWNtUjJQT0hJQUdPRkZHOUI3M2pI?= =?utf-8?B?VUNibDBNdDhtZVYwN0JESnEyS0NpZTJOaUhtbUFzT0FQT2tKT3V4UE4xbXo1?= =?utf-8?B?R01NSnc4eVdkMnJFck5UVHRaSkpKcERRUW1icWQ0WmdmajhYbmNLU2F5cks5?= =?utf-8?B?cVZ3VzhsWmw5U0lUNE5NSEludlRpOENBRGlzYnRIbHNCdU16NUdSeEorVjAv?= =?utf-8?B?K2VtSXBEWlI2RHM3Z1c3MmRKNUlvanFwQ0Vxa0JpS0p3dXJGSE9kRDc0UERV?= =?utf-8?B?QnpGZkRrQnNidWdjMktGcjJNOWdrZlIvWjJNdnJmR21YZGRWRVFoWHBwS1J0?= =?utf-8?B?T2xNKytLbys1L00vRVlIK0N5WTJJMjR0VkVGVkorTHpkcDZXNGs4U25kc2Yw?= =?utf-8?B?b2dsMlFhbWk3MTRFUVZhQ3A3c1AwT2V6MmNjd1hjQnVKekcyUzg3M1BwaFpy?= =?utf-8?B?WXpzbFhsekdiZVFwdmU1OHBqOEJLY2tyc2dTUnFtTjdBYlc0TG1oSDRiRkx2?= =?utf-8?B?M1BSVGRCS2xRUklPZ04wWWZRZkpQY0pIN00weVQ1NGRVM2FRcWJ4TW5PRmd5?= =?utf-8?B?NzdrdnBwOEhGR2REeDdKdFBMTjl1QXVvT2w1a0gyaGdtRzlyemp3Q0NqeW90?= =?utf-8?B?L2JzcnZsK2NTL2pqWUVGQkhiNEFyOFg3d2E3TERpTTV1VFBmOFVmQUtBb2FF?= =?utf-8?B?Mk1WWW5tcnBwNEF3ekRrZDJRRlVnZlFGeFp5cVRQRU9YNWN4Vm81NjhlU2R0?= =?utf-8?B?RUNjLzB5WXdRb0w0cHJGRlJKd0ZRT0JEMzVyRldWanRrOXdqUE03WUpwNXYx?= =?utf-8?B?SU83UGY4SkU1T0w3Nm8xUDlvUFVDYWFOZDZiQ2lxZHQrbjJaNlJoeXBWT1ZS?= =?utf-8?B?dlZ5dENEbXh4RGIzRkRoVUM5VFBIUWxhN1FvNU5DS3U0cmc5N2lxRTQ2WlI2?= =?utf-8?B?NkExRlErT1pGa2NGQ1hvVmdmZll3L3grUTFyL3N1ZHI4Z0hBRTVIRitNSUZk?= =?utf-8?B?Vk5nK1NrQytxdzFQNjZhajViYU1mOTZKeXVBbFdPYzdRd0NuZXJkVVV2Wi9y?= =?utf-8?B?ZmYzWjRteEYrY0E1dmIwYzBTY0NTUERsNThSS2NoNG9wWUxDazhnMFZZNTkr?= =?utf-8?B?S1JidW40QnlzSUlRRm5qVHZabURyNEFsMllub3hqTTN5clV6RzhlQ2l1SkNG?= =?utf-8?B?RitKZitBcXFLWXZmb0V5YTIwZkJhVVpjYkxWMSs4MWZvSGhlVkpZL3NJa3dK?= =?utf-8?B?Qnl3WFlKeHlNUURwOFRIOW1TUDJBVHI1VEUyL0N4aGtxbUUzN2JkUzhRY2gw?= =?utf-8?B?VGx1QXIzOVh6cDF3eFIreXQvVThJZlRxTnhPK0hiSHhkem9FQUFkYWxENU5q?= =?utf-8?B?ZjZ4YnY5NU96Y0lnUWJ2NFp5eDRCSHNKRS8rbDUvQ01pcGQ3VU5LblBMYmhv?= =?utf-8?B?WFhMRjVncTB3VE51TFJZQmcrY3lTTFByVC9DdmNPYmlIMERzUk1LV0VwVTRm?= =?utf-8?B?VEg1Y0Y5b3d6TE9rOGgwTTBMeEQ2Z1BVdWExK2Y1NVlmSlp0YVQ1eXRRcFND?= =?utf-8?B?Z0JuWDlzN2F5N083bXQrWnhyWXEvaXlGWnd0TUJ0Q2ptWUxQSUNFRFNnNFFz?= =?utf-8?B?QWo4ZXgwRlRVZDA1Z043TlFPanFEUFZiR21QZzNMcGQycmF6VXUxbUpycm9U?= =?utf-8?Q?qPeN4jNDFG7qhIxWkgf2FDu58?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c06fa34-88e2-4231-6be7-08da9ccfb966 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 19:22:01.0413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v3sgb39K9B2kjpGPYWg/YKZqI2a0JTrGRs1cn0gHyH6KTQkpKdOk85k5tBy1JFXT3RqUZMtrOomv/4X6N/imkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6802 On 22.09.2022 18:05, Roger Pau Monne wrote: > memory_type_changed() is currently only implemented for Intel EPT, and > results in the invalidation of EMT attributes on all the entries in > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > when the guest tries to access any gfns for the first time, which > results in the recalculation of the EMT for the accessed page. The > vmexit and the recalculations are expensive, and as such should be > avoided when possible. > > Remove the call to memory_type_changed() from > XEN_DOMCTL_memory_mapping: there are no modifications of the > iomem_caps ranges anymore that could alter the return of > cache_flush_permitted() from that domctl. I certainly agree - this was an oversight when the two aspects were split. One might argue this is a (performance) fix to the earlier commit, and hence might want to go on its own with a Fixes: tag. > Calls to memory_type_changed() resulting from changes to the domain > iomem_caps or ioport_caps ranges are only relevant for EMT > calculations if the IOMMU is not enabled, and the call has resulted in > a change to the return value of cache_flush_permitted(). I'm less certain here: These shouldn't be frequent operations, so their impact on the guest should be limited? And if we were to restrict the calls, I think we need to clearly tie together the various places which need updating together in case e.g. the condition in epte_get_entry_emt() is changed. Minimally by way of comments, but maybe by way of a small helper function (for which I can't seem to be able to think of a good name) sitting next to epte_get_entry_emt(). > Signed-off-by: Roger Pau Monné > --- > I feel it's a bit weird to have calls to memory_type_changed() in > common domctl code - for once the domctl that trigger the call doesn't > change memory types, just adds or removes ranges from iomem_caps > (which in turn affects the behaviour of epte_get_entry_emt()). Do you have a better suggestion? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 22 20:48:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 20:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410455.653451 (Exim 4.92) (envelope-from ) id 1obT7c-000678-7c; Thu, 22 Sep 2022 20:48:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410455.653451; Thu, 22 Sep 2022 20:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obT7c-000671-4t; Thu, 22 Sep 2022 20:48:36 +0000 Received: by outflank-mailman (input) for mailman id 410455; Thu, 22 Sep 2022 20:48:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obT7b-00066v-3i for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 20:48:35 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9e1c964-3ab7-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 22:48:31 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 13:48:20 -0700 Received: from denhamka-mobl.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.212.34.17]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 13:48:19 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9e1c964-3ab7-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663879711; x=1695415711; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/oOaixrqmiYHuetWlbNHMDz+rF28ogSafa/whKFQpVo=; b=ayrHetsEs0BWXtiFF1Kp/qDtW/GrUymKjPP5edWcgkyWwmVbfKhov/Zl d5m8jvie9jBw9vJBSsGmx/5ms0lNuB6rRJgY7HgJoqkCd00LKUGT3ugjA RVi6w1nA4FtP5N1pzr+wBU4GT+6ifnMJJO04W95sk1B/fwk6/+Npz4+lh J7BK/ZtED1ZlDDOEBH6oGTbHI5IzUx/pMF7rGZSek5AuWo69eXZrSn6kn fcUTm6y4S6v2Q371SM28Zzge/qlpdcebvTxbkg4w64I3q1lxebVYgz654 lH5EBqv+HYtfd2nTVeG9qnAFbBX//DesS22gPzx4JOO8pFTPEylYX/QX0 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="299150643" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="299150643" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="865030832" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load Date: Thu, 22 Sep 2022 16:48:14 -0400 Message-Id: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The vPMU code-bases attempts to perform an optimization on saving/reloading the PMU context by keeping track of what vCPU ran on each pCPU. When a pCPU is getting scheduled, checks if the previous vCPU isn't the current one. If so, attempts a call to vpmu_save_force. Unfortunately if the previous vCPU is already getting scheduled to run on another pCPU its state will be already runnable, which results in an ASSERT failure. Fix this by always performing a pmu context save in vpmu_save when called from vpmu_switch_from, and do a vpmu_load when called from vpmu_switch_to. While this presents a minimal overhead in case the same vCPU is getting rescheduled on the same pCPU, the ASSERT failure is avoided and the code is a lot easier to reason about. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/cpu/vpmu.c | 43 +++++------------------------------------ 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index cacc24a30f..64cdbfc48c 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) vpmu->last_pcpu = pcpu; per_cpu(last_vcpu, pcpu) = v; + vpmu_set(vpmu, VPMU_CONTEXT_SAVE); + if ( alternative_call(vpmu_ops.arch_vpmu_save, v, 0) ) vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); + vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); + apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); } int vpmu_load(struct vcpu *v, bool_t from_guest) { struct vpmu_struct *vpmu = vcpu_vpmu(v); - int pcpu = smp_processor_id(), ret; - struct vcpu *prev = NULL; + int ret; if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) return 0; - /* First time this VCPU is running here */ - if ( vpmu->last_pcpu != pcpu ) - { - /* - * Get the context from last pcpu that we ran on. Note that if another - * VCPU is running there it must have saved this VPCU's context before - * startig to run (see below). - * There should be no race since remote pcpu will disable interrupts - * before saving the context. - */ - if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) - { - on_selected_cpus(cpumask_of(vpmu->last_pcpu), - vpmu_save_force, (void *)v, 1); - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); - } - } - - /* Prevent forced context save from remote CPU */ - local_irq_disable(); - - prev = per_cpu(last_vcpu, pcpu); - - if ( prev != v && prev ) - { - vpmu = vcpu_vpmu(prev); - - /* Someone ran here before us */ - vpmu_save_force(prev); - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); - - vpmu = vcpu_vpmu(v); - } - - local_irq_enable(); - /* Only when PMU is counting, we load PMU context immediately. */ if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || (!has_vlapic(vpmu_vcpu(vpmu)->domain) && -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 22 21:40:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 21:40:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410463.653461 (Exim 4.92) (envelope-from ) id 1obTvV-0004Qt-6p; Thu, 22 Sep 2022 21:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410463.653461; Thu, 22 Sep 2022 21:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obTvV-0004Qm-41; Thu, 22 Sep 2022 21:40:09 +0000 Received: by outflank-mailman (input) for mailman id 410463; Thu, 22 Sep 2022 21:40:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obTvT-0004Qg-H7 for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 21:40:07 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f14fd83-3abf-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 23:40:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5ADE3B836A8; Thu, 22 Sep 2022 21:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D04C3C433D7; Thu, 22 Sep 2022 21:40:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f14fd83-3abf-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663882803; bh=UuZcNTNs6dbUC1YMEHqSabZ94xlf7nYzpPH+eXNCmSY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=N3I1dp8xgr/arS/figinCMiIn7iHALOHfUPJm0XYnfATlvtvcnLyyr+Y/7JkPNZsp YCwz0cPIJaFMkTv2fWc2s8iG1k1GNm+eic1veJ8Of2e8qMRwASQD5eTt7GszJgQ7L5 FkHC+8bHsLqKOZfmKwy3Gyr37Tfab0bhsKc4MNQOW5zEC6w+1JLjLQh/Dl8PAZvUqT fGp7ODDucsPEapBX250sfoldz2D0SzlDHJrdkpobSIDoGxl6OPFBMFm0HUmasWVv3O 5hlQ7BdBSjPegncbwKyOrUm2U2Dg4UQsjT9BVRdFOcYRJvnWuxqBLIVmNxycpQMLN+ 348t0RnAzU9Hg== Date: Thu, 22 Sep 2022 14:40:01 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Henry.Wang@arm.com Subject: Re: [PATCH 1/9] automation: Use custom build jobs when extra config options are needed In-Reply-To: <20220922134058.1410-2-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > Currently, all the arm64 defconfig build jobs, regardless of the > container used, end up building Xen with the extra config options > specified in the main build script (e.g. CONFIG_EXPERT, > CONFIG_STATIC_MEMORY). Because these options are only needed for > specific test jobs, the current behavior of the CI is incorrect > as we add the extra options to all the defconfig builds. This means > that on arm64 there is not a single job performing proper defconfig build. > > To fix this issue, add custom build jobs each time there is a need for > building Xen with additional config options. Introduce EXTRA_XEN_CONFIG > variable to be used by these jobs to store the required options. This > variable will be then read by the main build script to modify the .config > file. This will also help users to understand what is needed to run specific > test. > > Signed-off-by: Michal Orzel > --- > This patch could actually be consider to be taken for 4.17 release. > The reason why is because currently our CI for arm64 does not even > peform clean defconfig build which is quite crucial target to be tested. > Performing builds always with EXPERT and UNSUPPORTED is not something so > beneficial for release tests. This is up to the release manager. + Henry I agree this should go in 4.17, so that gitlab-ci can test non-DEBUG builds on ARM. > --- > automation/gitlab-ci/build.yaml | 15 +++++++++++++++ > automation/gitlab-ci/test.yaml | 4 ++-- > automation/scripts/build | 8 ++------ > 3 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 720ce6e07ba0..a39ed72aac6d 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: > variables: > CONTAINER: alpine:3.12-arm64v8 > > +alpine-3.12-gcc-arm64-staticmem: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | Why the "|" ? I was trying to look for its documentation in the gitlab yaml docs but couldn't find it. > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > +alpine-3.12-gcc-arm64-boot-cpupools: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_BOOT_TIME_CPUPOOLS=y > > ## Test artifacts common > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index d899b3bdbf7a..4f96e6e322de 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: > script: > - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > needs: > - - alpine-3.12-gcc-arm64 > + - alpine-3.12-gcc-arm64-staticmem > - alpine-3.12-arm64-rootfs-export > - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: > script: > - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > needs: > - - alpine-3.12-gcc-arm64 > + - alpine-3.12-gcc-arm64-boot-cpupools > - alpine-3.12-arm64-rootfs-export > - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > diff --git a/automation/scripts/build b/automation/scripts/build > index 2f15ab3198e6..7d441cedb4ae 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > hypervisor_only="y" > else > - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then > - echo " > -CONFIG_EXPERT=y > -CONFIG_UNSUPPORTED=y > -CONFIG_STATIC_MEMORY=y > -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config > + if [ -n "${EXTRA_XEN_CONFIG}" ]; then NIT: for uniformity with rest of the file use if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then > + echo "${EXTRA_XEN_CONFIG}" > xen/.config > make -j$(nproc) -C xen olddefconfig > else > make -j$(nproc) -C xen defconfig > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 21:43:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 21:43:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410469.653473 (Exim 4.92) (envelope-from ) id 1obTyL-00052Y-Kc; Thu, 22 Sep 2022 21:43:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410469.653473; Thu, 22 Sep 2022 21:43:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obTyL-00052R-HS; Thu, 22 Sep 2022 21:43:05 +0000 Received: by outflank-mailman (input) for mailman id 410469; Thu, 22 Sep 2022 21:43:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obTyJ-00052L-Qj for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 21:43:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88d2ec11-3abf-11ed-9647-05401a9f4f97; Thu, 22 Sep 2022 23:43:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 633B2B815BA; Thu, 22 Sep 2022 21:43:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 770F3C433C1; Thu, 22 Sep 2022 21:43:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88d2ec11-3abf-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663882981; bh=x4jc0wnmwdJAwHaAgRT6iZPLBKuNELOVbUIBBE1eVQI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ouTWk6vdD/xbEfyuS7mDTRMTJpT3SHwaAxFAdgnbTnh6cRv2ag5GyjzIT2sBqQDdI 7OnyFKHhZNF5FUcWKQu5wwjQMrozXY0sD6owZo/G02GD3a612b2kahOiAXCx7Fh4Mr cC7dkZm67BBiR7AWh1NdER9dlXO0dMyEKNPWPu/ZnUhIybm3KGcq3oAYezTFghV0sh j/K4fpDW9+a2ttlXHCXgLfBzY5KJdfbBPilZ6FFp8gbgOLluJ1HCaN89Gns0OkUsDD ytmDqmRAvr6ZLArbR5mC8dT0ZCP3lv6MW1ldPi06azRe1IBfhz1DuP6KuxrTVOUaVm ZJsiCAE/IWvqQ== Date: Thu, 22 Sep 2022 14:42:59 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 2/9] automation: Add randconfig build jobs for arm64 alpine container In-Reply-To: <20220922134058.1410-3-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > For arm64 we perform builds using debian and alpine containers. > We are missing the randconfig build jobs for the latter, so add them. > This way for each container we have 4 fundamental build jobs: > - defconfig non-debug/debug > - randconfig non-debug/debug Should we have them also for Debian? The patch below looks fine. > Signed-off-by: Michal Orzel > --- > automation/gitlab-ci/build.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index a39ed72aac6d..d931441b910a 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -566,6 +566,18 @@ alpine-3.12-gcc-debug-arm64: > variables: > CONTAINER: alpine:3.12-arm64v8 > > +alpine-3.12-gcc-arm64-randconfig: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + RANDCONFIG: y > + > +alpine-3.12-gcc-debug-arm64-randconfig: > + extends: .gcc-arm64-build-debug > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + RANDCONFIG: y > + > alpine-3.12-gcc-arm64-staticmem: > extends: .gcc-arm64-build > variables: > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 21:54:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 21:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410475.653484 (Exim 4.92) (envelope-from ) id 1obU8h-0006fn-KN; Thu, 22 Sep 2022 21:53:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410475.653484; Thu, 22 Sep 2022 21:53:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obU8h-0006fg-Hh; Thu, 22 Sep 2022 21:53:47 +0000 Received: by outflank-mailman (input) for mailman id 410475; Thu, 22 Sep 2022 21:53:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obU8g-0006fX-Ch for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 21:53:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 066c042a-3ac1-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 23:53:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B814611C8; Thu, 22 Sep 2022 21:53:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13217C433D6; Thu, 22 Sep 2022 21:53:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 066c042a-3ac1-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663883621; bh=iL8KBH6SVIwOFlDViXYb7tdRg/YT1BPcXLmadJsby7c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SVjpFKn7/KrFWxc2W3lzqd7ilf+1r0d2XmLp9yWfnHFojyqXhJwmBXwkO/qg7bQwG BoCCDK6VNjZxgVFqD3YgrwxOhO4js59truesI2fa4/MqKkARsA7YqMj/a3hDEObyMr aEIfCtui3JxnIsMr4yjBoipUq7L2nByTfCnnV9UuJ8ls05YkKUM+tJ3rkoYA5Z+0Bt GbgYsCAqM5pOCOnLXkSpXXvbMsbFhSBDrUW9TrKrkWrsItQGAzAxJEOXWtnSCyRYx6 8eB5rYHBUg1p8aWIl7uiBX5uPSPcghVX60McEjfPCoavRAqZHNICahLomQ32WXD3oN 4QqYo3pMuCOgQ== Date: Thu, 22 Sep 2022 14:53:39 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 3/9] automation: Add debug versions of Arm tests In-Reply-To: <20220922134058.1410-4-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > At the moment, all the tests are executed on non-debug Xen builds. > To improve the coverage (e.g. we might catch some asserts), add new > test jobs using debug Xen builds. This is interesting. On one hand, I agree it is good to test DEBUG and non-DEBUG builds in runtime tests too, on the other hand I am worried about our test capacity. I take you have tried a few pipelines -- are the additional tests causing the pipeline to take longer? Do we still have "room" because x86 is slower? What's your thinking? One idea would be to only do: - qemu-alpine-arm64-gcc-debug - qemu-smoke-arm64-gcc-debug and not the others > Take the opportunity to increase RAM size for QEMU from 1GB to 2GB > in qemu-smoke-arm64.sh as the debug builds take more space and we might > end up in a situation when there is not enough free space (especially > during a static memory test that reserves some region in the middle). > > Signed-off-by: Michal Orzel > --- > automation/gitlab-ci/build.yaml | 16 +++++ > automation/gitlab-ci/test.yaml | 93 ++++++++++++++++++++++++++ > automation/scripts/qemu-smoke-arm64.sh | 6 +- > 3 files changed, 112 insertions(+), 3 deletions(-) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index d931441b910a..6ce92531f61f 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: > CONFIG_UNSUPPORTED=y > CONFIG_STATIC_MEMORY=y > > +alpine-3.12-gcc-debug-arm64-staticmem: > + extends: .gcc-arm64-build-debug > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > alpine-3.12-gcc-arm64-boot-cpupools: > extends: .gcc-arm64-build > variables: > @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: > EXTRA_XEN_CONFIG: | > CONFIG_BOOT_TIME_CPUPOOLS=y > > +alpine-3.12-gcc-debug-arm64-boot-cpupools: > + extends: .gcc-arm64-build-debug > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_BOOT_TIME_CPUPOOLS=y > + > ## Test artifacts common > > .test-jobs-artifact-common: > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 4f96e6e322de..1b51030c6175 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: > tags: > - arm64 > > +qemu-alpine-arm64-gcc-debug: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64 > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-alpine-x86_64-gcc: > extends: .test-jobs-common > variables: > @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-debug: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64 > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm64-gcc-staticmem: > extends: .test-jobs-common > variables: > @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-debug-staticmem: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64-staticmem > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm64-gcc-boot-cpupools: > extends: .test-jobs-common > variables: > @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-debug-boot-cpupools: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64-boot-cpupools > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm32-gcc: > extends: .test-jobs-common > variables: > @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: > tags: > - arm64 > > +qemu-smoke-arm32-gcc-debug: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > + needs: > + - debian-unstable-gcc-arm32-debug > + - qemu-system-aarch64-6.0.0-arm32-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-x86-64-gcc: > extends: .test-jobs-common > variables: > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index f803835779f4..dea26c6c0a8f 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -52,7 +52,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -smp 2 -display none \ > + -m 2048 -smp 2 -display none \ > -machine dumpdtb=binaries/virt-gicv2.dtb > > # XXX disable pl061 to avoid Linux crash > @@ -117,7 +117,7 @@ cd .. > > # ImageBuilder > echo 'MEMORY_START="0x40000000" > -MEMORY_END="0x80000000" > +MEMORY_END="0xC0000000" > > DEVICE_TREE="virt-gicv2.dtb" > XEN="xen" > @@ -158,7 +158,7 @@ timeout -k 1 240 \ > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -monitor none -serial stdio \ > + -m 2048 -monitor none -serial stdio \ > -smp 2 \ > -no-reboot \ > -device virtio-net-pci,netdev=n0 \ The changes to qemu-smoke-arm64.sh make sense, but could you move them to a separate patch in case we need to do any backports? Also I would change MEMORY_END to 0xC0000000 in qemu-alpine-arm64.sh too for uniformity. From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:04:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:04:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410481.653495 (Exim 4.92) (envelope-from ) id 1obUIW-0008JG-Kd; Thu, 22 Sep 2022 22:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410481.653495; Thu, 22 Sep 2022 22:03:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUIW-0008J9-GY; Thu, 22 Sep 2022 22:03:56 +0000 Received: by outflank-mailman (input) for mailman id 410481; Thu, 22 Sep 2022 22:03:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUIU-0008J3-Vn for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:03:54 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7262a24c-3ac2-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 00:03:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BFFA7B837BC; Thu, 22 Sep 2022 22:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E080DC433C1; Thu, 22 Sep 2022 22:03:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7262a24c-3ac2-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663884231; bh=jp1er+xOHNqKQ40+sgixSqwla1WuL0oJ4UZWRqZp80E=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pP36H8jeD7hSDDieybUXA0df90FuvrSv455kjAeRIYWCKKw1J6q/VOV747D+aA7vg xUM6rvlbA0r63JkGAKXm+3zAtZ2a0ofIP4iUwwAQg86nEsRX/6pu8SbBBnuMJG0u4J 0TCi+d4G2CBsxiYsJ3s+H+rbSX5jWaLvf+xlPLvLQkwq+iY9wRZ576N9MWL/sCmcrL K8GOHhY5X3i03wE90AMBgmjx/ppofHHc0ZEcskNxxIypPtHgqDbFUcUVWCyJwz/B/B tn3/HyGbHzdl9XISUPVrKhLILDdlzSdG5JvMtVclLWYdUONTpF/Lzc5vf5im0Tti8c DcP5vtVVLYLTQ== Date: Thu, 22 Sep 2022 15:03:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 4/9] automation: Add Arm containers to containerize script In-Reply-To: <20220922134058.1410-5-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-5-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > Script automation/scripts/containerize makes it easy to build Xen within > predefined containers from gitlab container registry. However, it is > currently not possible to use it with Arm containers because they are not > listed in the script. Populate the necessary entries. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > automation/scripts/containerize | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/automation/scripts/containerize b/automation/scripts/containerize > index 9d4beca4fa4b..0f4645c4cccb 100755 > --- a/automation/scripts/containerize > +++ b/automation/scripts/containerize > @@ -25,6 +25,7 @@ die() { > BASE="registry.gitlab.com/xen-project/xen" > case "_${CONTAINER}" in > _alpine) CONTAINER="${BASE}/alpine:3.12" ;; > + _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;; > _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;; > _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;; > _centos7) CONTAINER="${BASE}/centos:7" ;; > @@ -35,6 +36,8 @@ case "_${CONTAINER}" in > _stretch|_) CONTAINER="${BASE}/debian:stretch" ;; > _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;; > _unstable|_) CONTAINER="${BASE}/debian:unstable" ;; > + _unstable-arm32-gcc) CONTAINER="${BASE}/debian:unstable-arm32-gcc" ;; > + _unstable-arm64v8) CONTAINER="${BASE}/debian:unstable-arm64v8" ;; > _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;; > _xenial) CONTAINER="${BASE}/ubuntu:xenial" ;; > _opensuse-leap|_leap) CONTAINER="${BASE}/suse:opensuse-leap" ;; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:13:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:13:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410485.653506 (Exim 4.92) (envelope-from ) id 1obURW-0001Um-G6; Thu, 22 Sep 2022 22:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410485.653506; Thu, 22 Sep 2022 22:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obURW-0001Uf-DR; Thu, 22 Sep 2022 22:13:14 +0000 Received: by outflank-mailman (input) for mailman id 410485; Thu, 22 Sep 2022 22:13:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obURU-0001UZ-NP for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:13:12 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bef4dd9a-3ac3-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 00:13:11 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAC9EB80E0B; Thu, 22 Sep 2022 22:13:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24084C433D6; Thu, 22 Sep 2022 22:13:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bef4dd9a-3ac3-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663884789; bh=a59HD7ooUmHzgVMLvCpbzyPtmhyKk90E1bJPycu/YDc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ss6WLUdkALm7h5nPHhj9fnAKia3bHuxeFXqxbzBx72DtliNclKQpbYBoI6RtAvaya frHUWJ1BUrhvT0MoXvkRSCa4wtsF8gtgGttsZFt3epBah5UNUHnheZ0Vj5YX0Cs2Lv jhyg4SEi9BaXgqEvZeLf207oy4tshbUvAs7qtB1gL4FF0EcmPOvwVG8sLYf34qEJHl oD80RHa2sBaKFNrwxY5pzS/IaHmNCkaPP4+rnzIUA7z+y1s4Qh8wpSiQegJTp7xr7I gXGqM5otdhhfgWfwLVrm0PFzn6zdI+kj2gFZc2pY91uUryaLPymn9pE+nWwRubOEBl O5FcOABp7ccaA== Date: Thu, 22 Sep 2022 15:13:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 5/9] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder In-Reply-To: <20220922134058.1410-6-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-6-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > Take an example from arm64 qemu test scripts and use ImageBuilder > to generate u-boot script automatically. Calculating the addresses > manually is quite error prone and also we will be able to benefit > from using ImageBuilder when adding domUs to this test in the future. > > Install and use u-boot from the debian package. > Modify the script so that binaries are loaded from u-boot via tftp. Great patch! It makes the test a lot better! > Signed-off-by: Michal Orzel > --- > automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- > 1 file changed, 27 insertions(+), 30 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh > index 530f3892fdd3..765facbe4d66 100755 > --- a/automation/scripts/qemu-smoke-arm32.sh > +++ b/automation/scripts/qemu-smoke-arm32.sh > @@ -4,7 +4,9 @@ set -ex > > export DEBIAN_FRONTENT=noninteractive > apt-get -qy update > -apt-get -qy install --no-install-recommends device-tree-compiler \ > +apt-get -qy install --no-install-recommends u-boot-qemu \ > + u-boot-tools \ > + device-tree-compiler \ > curl \ > cpio > > @@ -20,10 +22,6 @@ tar xvzf ../initrd.tar.gz > find . | cpio -H newc -o | gzip > ../initrd.gz > cd .. > > -kernel=`stat -L --printf="%s" vmlinuz` > -initrd=`stat -L --printf="%s" initrd.gz` > - > -# For Xen, we need a couple of more node. Dump the DT from QEMU and add them > # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./qemu-system-arm \ > @@ -36,31 +34,31 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > -display none \ > -machine dumpdtb=virt.dtb > > -dtc -I dtb -O dts virt.dtb > virt.dts > +# ImageBuilder > +echo 'MEMORY_START="0x40000000" > +MEMORY_END="0x80000000" > + > +DEVICE_TREE="virt.dtb" > +XEN="xen" > +DOM0_KERNEL="vmlinuz" > +DOM0_RAMDISK="initrd.gz" > +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" > +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" This is missing dtuart=/pl011@9000000 compared to the original > +NUM_DOMUS=0 > + > +LOAD_CMD="tftpb" > +BOOT_CMD="bootm" "bootm" because "booti" is not available on arm32, right? > +UBOOT_SOURCE="boot.source" > +UBOOT_SCRIPT="boot.scr"' > config > > -cat >> virt.dts << EOF > -/ { > - chosen { > - #address-cells = <0x2>; > - #size-cells = <0x2>; > - stdout-path = "/pl011@9000000"; > - xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0"; > - xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh"; > - dom0 { > - compatible = "xen,linux-zimage", "xen,multiboot-module"; > - reg = <0x0 0x1000000 0x0 $kernel>; > - }; > - dom0-ramdisk { > - compatible = "xen,linux-initrd", "xen,multiboot-module"; > - reg = <0x0 0x3200000 0x0 $initrd>; > - }; > - }; > -}; > -EOF > -dtc -I dts -O dtb virt.dts > virt.dtb > +rm -rf imagebuilder > +git clone https://gitlab.com/ViryaOS/imagebuilder > +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > > rm -f smoke.serial > set +e > +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ > timeout -k 1 240 \ > ./qemu-system-arm \ > -machine virt \ > @@ -70,11 +68,10 @@ timeout -k 1 240 \ > -serial stdio \ > -monitor none \ > -display none \ > - -dtb virt.dtb \ > -no-reboot \ > - -kernel ./xen \ > - -device loader,file=./vmlinuz,addr=0x1000000 \ > - -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial > + -device virtio-net-pci,netdev=n0 \ > + -netdev user,id=n0,tftp=./ \ > + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial > > set -e > (grep -q "^/ #" smoke.serial) || exit 1 > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:15:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:15:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410492.653517 (Exim 4.92) (envelope-from ) id 1obUTM-0002Gq-0Y; Thu, 22 Sep 2022 22:15:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410492.653517; Thu, 22 Sep 2022 22:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUTL-0002Gj-U0; Thu, 22 Sep 2022 22:15:07 +0000 Received: by outflank-mailman (input) for mailman id 410492; Thu, 22 Sep 2022 22:15:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUTL-0002Gb-4q for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:15:07 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 026658f5-3ac4-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 00:15:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3FC8C612D6 for ; Thu, 22 Sep 2022 22:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0CB5C4347C for ; Thu, 22 Sep 2022 22:15:03 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id a2so16935834lfb.6 for ; Thu, 22 Sep 2022 15:15:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 026658f5-3ac4-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663884903; bh=enQD/zJTjwNlqp2Kps1H9U/gVwFrhJsHaI7xyxomm88=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VUxVen8B3vFQHSxnlIHQMYgPjn5A15xa9vq8wbrZTX2jpf45g+QDYKoZ1xuQoWQzz dnNKMsswfnJl93csDCFcECUVkFYP2SXgQ/jPbFtZUAig4ikaLTIvj7kRyjEI0yXih7 /hueWQPdX7Tq13N2gqpMe5l/QdR9stjDsOcBJduIQyIFwBjoLzmA1MqvbautO7iiRG FhMiSE+MS8xWN07bTH9G1uIrS7f92RC9z7RmoqrunZYNAtREVPKi2xkx8U6IMySPyg Zs2YZl70Lw5KBKF/WH2veTaGGxBFam1yIn9+J4hxWA0TvCNK8gVxuaXoJiDLyBNG6N fvmAJfy+r2gkg== X-Gm-Message-State: ACrzQf0QuxdHjtis6DOutHuW0PyxQxHV2uAdpghslfXK63e/b4RaPU4J MmJ3qt1TxSKOnRUsQMzUtKx8KqejE1RKpHYsQOI= X-Google-Smtp-Source: AMsMyM6eDXsgm4HjV+uHSWsEP62fe865KcxhHP8kMPKgV25TUM1eqiFLKDq88d/iJ2b51J9wFvj7IN+nQYIqA9XD0BA= X-Received: by 2002:a05:6512:c0f:b0:49b:1e8c:59fd with SMTP id z15-20020a0565120c0f00b0049b1e8c59fdmr1946566lfu.426.1663884901602; Thu, 22 Sep 2022 15:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20220919193257.2031-1-demi@invisiblethingslab.com> <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 23 Sep 2022 00:14:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 22 Sept 2022 at 20:12, Demi Marie Obenour wrote: > > On Thu, Sep 22, 2022 at 05:05:43PM +0200, Ard Biesheuvel wrote: > > On Thu, 22 Sept 2022 at 16:56, Demi Marie Obenour > > wrote: > > > > > > On Thu, Sep 22, 2022 at 08:12:14AM +0200, Jan Beulich wrote: > > > > On 22.09.2022 03:09, Demi Marie Obenour wrote: > > > > > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > > > > >> On 20.09.2022 18:09, Ard Biesheuvel wrote: > > > > >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich = wrote: > > > > >>>> > > > > >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: > > > > >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > > > >>>>> wrote: > > > > >>>>>> > > > > >>>>>> fwupd requires access to the EFI System Resource Table (ESRT= ) to > > > > >>>>>> discover which firmware can be updated by the OS. Currently= , Linux does > > > > >>>>>> not expose the ESRT when running as a Xen dom0. Therefore, = it is not > > > > >>>>>> possible to use fwupd in a Xen dom0, which is a serious prob= lem for e.g. > > > > >>>>>> Qubes OS. > > > > >>>>>> > > > > >>>>>> Before Xen 4.16, this was not fixable due to hypervisor limi= tations. > > > > >>>>>> The UEFI specification requires the ESRT to be in EfiBootSer= vicesData > > > > >>>>>> memory, which Xen will use for whatever purposes it likes. = Therefore, > > > > >>>>>> Linux cannot safely access the ESRT, as Xen may have overwri= tten it. > > > > >>>>>> > > > > >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBoot= ServicesData > > > > >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBoot= ServicesData > > > > >>>>>> memory, Xen allocates some memory of type EfiRuntimeServices= Data, copies > > > > >>>>>> the ESRT to it, and finally replaces the ESRT pointer with a= pointer to > > > > >>>>>> the copy. Since Xen will not clobber EfiRuntimeServicesData= memory, > > > > >>>>>> this ensures that the ESRT can safely be accessed by the OS.= It is safe > > > > >>>>>> to access the ESRT under Xen if, and only if, it is in memor= y of type > > > > >>>>>> EfiRuntimeServicesData. > > > > >>>>>> > > > > >>>>> > > > > >>>>> Thanks for the elaborate explanation. This is really helpful. > > > > >>>>> > > > > >>>>> So here, you are explaining that the only way for Xen to prev= ent > > > > >>>>> itself from potentially clobbering the ESRT is by creating a > > > > >>>>> completely new allocation? > > > > >>>> > > > > >>>> There are surely other ways, e.g. preserving BootServices* reg= ions > > > > >>>> alongside RuntimeServices* ones. But as the maintainer of the = EFI > > > > >>>> code in Xen I don't view this as a reasonable approach. > > > > >>> > > > > >>> Why not? > > > > >> > > > > >> Because it's against the intentions the EFI has (or at least had= ) > > > > >> for this memory type. Much more than EfiAcpiReclaimMemory this > > > > >> type is intended for use as ordinary RAM post-boot. > > > > > > > > > > What about giving that memory to dom0? dom0=E2=80=99s balloon dr= iver will give > > > > > anything dom0 doesn=E2=80=99t wind up using back to Xen. > > > > > > > > While perhaps in principle possible, this would require special cas= ing > > > > in Xen. Except for the memory the initrd comes in, we don't directl= y > > > > hand memory to Dom0. Instead everything goes through the page alloc= ator > > > > first. Plus if we really were convinced boot services memory needed > > > > retaining, then it would also need retaining across kexec (and henc= e > > > > shouldn't be left to Dom0 to decide what to do with it). > > > > > > So how should dom0 handle the various EFI tables other than the ESRT? > > > Right now most uses of these tables in Linux are not guarded by any > > > checks for efi_enabled(EFI_MEMMAP) or similar. If some of them are i= n > > > EfiBootServicesData memory, they might be corrupted before Linux gets > > > them. > > > > Yes, this is an annoying oversight of the EFI design: the config > > tables are tuples, and the size of the table is > > specific to each table type. So without knowing the GUID, there is no > > way you can reserve the right size. > > > > Perhaps you could implement something like a hypercall in > > efi_arch_mem_reserve(), which is called by the EFI code to reserve > > regions that are in boot services memory but need to remain reserved? > > This is used for all config tables that it knows or cares about. > > On versions of Xen that support spawning multiple domains at boot > (instead of just dom0) this will be racy. What about refusing to use > tables in EfiBootServicesData when running under Xen unless a hypercall > indicates that Xen has reserved all EfiBootServicesData memory? Where > could such a check be placed? You could stick a check inside the for loop in efi_config_parse_tables() to cross reference every table address against the memory map when running on Xen, and disregard it if it doesn't meet your criteria. I take it the issue is not limited to x86? From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:17:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410498.653528 (Exim 4.92) (envelope-from ) id 1obUVL-0002tS-EK; Thu, 22 Sep 2022 22:17:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410498.653528; Thu, 22 Sep 2022 22:17:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUVL-0002tL-A5; Thu, 22 Sep 2022 22:17:11 +0000 Received: by outflank-mailman (input) for mailman id 410498; Thu, 22 Sep 2022 22:17:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUVK-0002tD-Ph for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:17:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ce4497b-3ac4-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 00:17:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A4E8B80DFF; Thu, 22 Sep 2022 22:17:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F0ABC433D6; Thu, 22 Sep 2022 22:17:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ce4497b-3ac4-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663885028; bh=s5uT+JUCb3kcH+WXkLo+IVTTPypd9jxZYm4UzkJ4HMY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Zv269zCOYmHWSdTKant3rDSBxXw2Lq1IAY3oRn2U34joNOC1FPJxvJp+G+P2fXyD1 Utq69j1uRiNR82fSllPgjhS+eqyRGV7DwmjLszzCaIUwCkxLzzd1X5G2AeM5rS7Npz rUWri33EgTbjbPbQddPJuoLUd8/1ur43xsbh1qoRRoKVcf8inC/R1M9r5nh0nsDDLM 4QBwpBiiWo9MPLgAVCRm0Flr6nIMEFA7oWujq9MuQhgsDVYRQWuDUcmpshemGYH84c zVm24GpeE0PG2UnnwDp1eEG4C+UmENdgFoebCc1jt5tBMnxOpMho9dzUZkBtQwb4U1 eamWKhgBFKIVQ== Date: Thu, 22 Sep 2022 15:17:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 6/9] automation: qemu-alpine-arm64: Cleanup and fixes In-Reply-To: <20220922134058.1410-7-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-7-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > Perform the following cleanup: > - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version > used in this test is v2, > - use fdtput to perform modifications on the dtb, > - use DEBIAN_FRONTENT=noninteractive to prevent interactive prompt being > stuck waiting for answer other than "yes", > - fix the number of cpus in the device tree because currently we generate > it with a single cpu and try to run QEMU with two, > - fix the memory size we pass when generating QEMU device tree as it does > not match the memory size with what we run QEMU. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > automation/scripts/qemu-alpine-arm64.sh | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-alpine-arm64.sh > index f4ac2d856fa0..7b52d77d3c84 100755 > --- a/automation/scripts/qemu-alpine-arm64.sh > +++ b/automation/scripts/qemu-alpine-arm64.sh > @@ -2,6 +2,7 @@ > > set -ex > > +export DEBIAN_FRONTENT=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends u-boot-qemu \ > u-boot-tools \ > @@ -73,18 +74,17 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -display none \ > - -machine dumpdtb=binaries/virt-gicv3.dtb > + -m 2048 -smp 2 -display none \ > + -machine dumpdtb=binaries/virt-gicv2.dtb > + > # XXX disable pl061 to avoid Linux crash > -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts > -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts > -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb > +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled > > # ImageBuilder > echo 'MEMORY_START="0x40000000" > -MEMORY_END="0x80000000" > +MEMORY_END="0xC0000000" > > -DEVICE_TREE="virt-gicv3.dtb" > +DEVICE_TREE="virt-gicv2.dtb" > XEN="xen" > DOM0_KERNEL="Image" > DOM0_RAMDISK="xen-rootfs.cpio.gz" > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:18:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410502.653539 (Exim 4.92) (envelope-from ) id 1obUWJ-0003Tu-MH; Thu, 22 Sep 2022 22:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410502.653539; Thu, 22 Sep 2022 22:18:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUWJ-0003Tn-Jb; Thu, 22 Sep 2022 22:18:11 +0000 Received: by outflank-mailman (input) for mailman id 410502; Thu, 22 Sep 2022 22:18:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUWI-0003TW-8a for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:18:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 705bc9f8-3ac4-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 00:18:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EA7AEB80DBA; Thu, 22 Sep 2022 22:18:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2734CC433C1; Thu, 22 Sep 2022 22:18:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 705bc9f8-3ac4-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663885087; bh=JIZPGRbIdrHvpam4Jr+pvhp6AxW+mkuh3Gw2sShRzxI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=G6RO83Hy7uArWz7tfbQ/gkkYdXYe8MtKvsRnn9zuX2Z+lArcybTtbgdWpQbsuB4Eb aAzFe7XYYEkIj8W8Ipmitzwr2n3jzXMf0y8VUS4oVW3xYs07YMs2Oaqpu2ajZoY+uV scAdSZ8Y8/umEcVqJZNP2PGN9merR285HOtcoQpa5T/pf5dynUxlsBeZZuO/gnSwKg pJJPR6R4LVSoGOe3TN336liPToRFN8YWIzBJlWjQCleBjB4JCknVqncOEvrCYqSjng NH8wFECJ/1ixoOv6p1H+8qi+w6j7+o1LR9JjQMA6WeQoCB1vyzItqJUVz7mmIqk84p hn3RZPZb8TTvg== Date: Thu, 22 Sep 2022 15:18:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 7/9] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh In-Reply-To: <20220922134058.1410-8-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-8-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > Testing arm64 is done using the qemu-alpine-arm64.sh and > qemu-smoke-arm64.sh scripts. These scripts are executed with exactly > the same artifacts (container, rootfs, kernel, qemu) and the only > difference is that the former is used to perform dom0 based testing > and the latter - dom0less based testing. > > Because the current naming is quite umbiguous, rename qemu-smoke-arm64.sh > script to qemu-smoke-dom0less-arm64.sh to reflect its usage. > > qemu-alpine-arm64.sh will be renamed in the follow-up patch. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > automation/gitlab-ci/test.yaml | 24 +++++++++---------- > ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 0 > 2 files changed, 12 insertions(+), 12 deletions(-) > rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (100%) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 1b51030c6175..f620622671f8 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -81,12 +81,12 @@ qemu-alpine-x86_64-gcc: > tags: > - x86_64 > > -qemu-smoke-arm64-gcc: > +qemu-smoke-dom0less-arm64-gcc: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-arm64 > - alpine-3.12-arm64-rootfs-export > @@ -100,12 +100,12 @@ qemu-smoke-arm64-gcc: > tags: > - arm64 > > -qemu-smoke-arm64-gcc-debug: > +qemu-smoke-dom0less-arm64-gcc-debug: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-debug-arm64 > - alpine-3.12-arm64-rootfs-export > @@ -119,12 +119,12 @@ qemu-smoke-arm64-gcc-debug: > tags: > - arm64 > > -qemu-smoke-arm64-gcc-staticmem: > +qemu-smoke-dom0less-arm64-gcc-staticmem: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-arm64-staticmem > - alpine-3.12-arm64-rootfs-export > @@ -138,12 +138,12 @@ qemu-smoke-arm64-gcc-staticmem: > tags: > - arm64 > > -qemu-smoke-arm64-gcc-debug-staticmem: > +qemu-smoke-dom0less-arm64-gcc-debug-staticmem: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-debug-arm64-staticmem > - alpine-3.12-arm64-rootfs-export > @@ -157,12 +157,12 @@ qemu-smoke-arm64-gcc-debug-staticmem: > tags: > - arm64 > > -qemu-smoke-arm64-gcc-boot-cpupools: > +qemu-smoke-dom0less-arm64-gcc-boot-cpupools: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-arm64-boot-cpupools > - alpine-3.12-arm64-rootfs-export > @@ -176,12 +176,12 @@ qemu-smoke-arm64-gcc-boot-cpupools: > tags: > - arm64 > > -qemu-smoke-arm64-gcc-debug-boot-cpupools: > +qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-debug-arm64-boot-cpupools > - alpine-3.12-arm64-rootfs-export > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh > similarity index 100% > rename from automation/scripts/qemu-smoke-arm64.sh > rename to automation/scripts/qemu-smoke-dom0less-arm64.sh > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:18:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:18:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410506.653550 (Exim 4.92) (envelope-from ) id 1obUWg-0003y6-UV; Thu, 22 Sep 2022 22:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410506.653550; Thu, 22 Sep 2022 22:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUWg-0003xz-Rp; Thu, 22 Sep 2022 22:18:34 +0000 Received: by outflank-mailman (input) for mailman id 410506; Thu, 22 Sep 2022 22:18:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUWf-0003nz-51 for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:18:33 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7dec8fe5-3ac4-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 00:18:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87B7BB80DBA; Thu, 22 Sep 2022 22:18:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B7C1C433D7; Thu, 22 Sep 2022 22:18:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dec8fe5-3ac4-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663885110; bh=WIK4Gh6i42n8O29OOR6jw11N6uvROORiLVlXlF2mn6c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=nlpuPJvs3PcvYYwVFRAnOc5EpEr4j3MPciChtqzexaajM3c8VfzpkXhuXTO/bx9X3 hG31KzXjRJs0WQuu2RlBSoqB+ZLeFgSDGF+BJ1AV/UququzID1PBRGHr3tEJxG8UTH Pyua+cp6JrMsIosRJZGozAMQr3wjZDU4hHe+pLuh86BJX7wtd/wVeh6oZpCOVPq/ip 9mNgnHuWJ9GQyCeAV5w1i/t8Z5VraTmkXSfRaWBVo6vdgqJFOYu3FtkPgsPJuvNRv8 KGrJQXFN0PUlVx9fZITVhqzB7Ke1sZlpiY7RPUy2pYk/B2dxy+HdXKyQFRUR9jND7D 3slDpi3xcifIA== Date: Thu, 22 Sep 2022 15:18:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 8/9] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh In-Reply-To: <20220922134058.1410-9-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-9-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > qemu-alpine-arm64.sh script is used to perform dom0 based testing. > Rename this script to qemu-smoke-dom0-arm64.sh to reflect its usage. > Also rename the corresponding test jobs. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > automation/gitlab-ci/test.yaml | 8 ++++---- > .../{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 0 > 2 files changed, 4 insertions(+), 4 deletions(-) > rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (100%) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index f620622671f8..3b147c88ab08 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -25,12 +25,12 @@ build-each-commit-gcc: > tags: > - x86_64 > > -qemu-alpine-arm64-gcc: > +qemu-smoke-dom0-arm64-gcc: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-arm64 > - alpine-3.12-arm64-rootfs-export > @@ -44,12 +44,12 @@ qemu-alpine-arm64-gcc: > tags: > - arm64 > > -qemu-alpine-arm64-gcc-debug: > +qemu-smoke-dom0-arm64-gcc-debug: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > needs: > - alpine-3.12-gcc-debug-arm64 > - alpine-3.12-arm64-rootfs-export > diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh > similarity index 100% > rename from automation/scripts/qemu-alpine-arm64.sh > rename to automation/scripts/qemu-smoke-dom0-arm64.sh > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410510.653561 (Exim 4.92) (envelope-from ) id 1obUX3-0004Uu-76; Thu, 22 Sep 2022 22:18:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410510.653561; Thu, 22 Sep 2022 22:18:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUX3-0004Un-4A; Thu, 22 Sep 2022 22:18:57 +0000 Received: by outflank-mailman (input) for mailman id 410510; Thu, 22 Sep 2022 22:18:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUX1-0003nz-Tv for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 22:18:55 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b3ef223-3ac4-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 00:18:55 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECF8C61B79; Thu, 22 Sep 2022 22:18:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4137C433D6; Thu, 22 Sep 2022 22:18:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b3ef223-3ac4-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663885133; bh=Kh6d14hn8XlW3sbe80RX6+n0J+Cdwx4dXkmKqLwdXhc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZgPtx5/QJPt0VhZUBHhosoXawYWiEUzESzz3IDkEaESBPDR7Zd+oNAC0URAcS/aeV ktQOoWYPu9kbMBxD5U/EwfWm9PDkAj5ujRhqSldVgDFabxuG5NsHMS9nP7wWaUdObw Yy3KCyXE/C5YXPeC1vnq4s/c41iu/WUwLDz2yxS/uE8zCH5M7DXA/F9e0iwnWxU2HL lEY1vtPHy2ABgHmqUhUqT7q1s5ze1PUg4EGWh3aca034OZLa5mybFIWsGiZ5k3tdWX HeDxqI24njFdJbs1mnWZ/BS/ME8Honyq59uOlx0bLrDDwhTK/30imw1YuO4gIXilsm zdPKvEo/sO/tg== Date: Thu, 22 Sep 2022 15:18:51 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 9/9] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh In-Reply-To: <20220922134058.1410-10-michal.orzel@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-10-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 22 Sep 2022, Michal Orzel wrote: > After qemu arm64 test scripts had been renamed to reflect their > usage, do the same for the qemu arm32 test script. Currently it only > boots dom0, so we can assume that this script will be used to perform > dom0 based testing. In the future we will be able to create corresponding > script qemu-smoke-dom0less-arm32.sh to perform dom0less based testing. > This is the last step to get rid of ambiguity with regards to naming > of Arm test scripts. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > automation/gitlab-ci/test.yaml | 8 ++++---- > .../{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 0 > 2 files changed, 4 insertions(+), 4 deletions(-) > rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (100%) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 3b147c88ab08..92e0a1f7c510 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -195,12 +195,12 @@ qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: > tags: > - arm64 > > -qemu-smoke-arm32-gcc: > +qemu-smoke-dom0-arm32-gcc: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > needs: > - debian-unstable-gcc-arm32 > - qemu-system-aarch64-6.0.0-arm32-export > @@ -212,12 +212,12 @@ qemu-smoke-arm32-gcc: > tags: > - arm64 > > -qemu-smoke-arm32-gcc-debug: > +qemu-smoke-dom0-arm32-gcc-debug: > extends: .test-jobs-common > variables: > CONTAINER: debian:unstable-arm64v8 > script: > - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > needs: > - debian-unstable-gcc-arm32-debug > - qemu-system-aarch64-6.0.0-arm32-export > diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh > similarity index 100% > rename from automation/scripts/qemu-smoke-arm32.sh > rename to automation/scripts/qemu-smoke-dom0-arm32.sh > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 22 22:31:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 22:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410524.653572 (Exim 4.92) (envelope-from ) id 1obUiq-0007AL-E8; Thu, 22 Sep 2022 22:31:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410524.653572; Thu, 22 Sep 2022 22:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUiq-0007AE-BP; Thu, 22 Sep 2022 22:31:08 +0000 Received: by outflank-mailman (input) for mailman id 410524; Thu, 22 Sep 2022 22:31:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUip-0007A4-1T; Thu, 22 Sep 2022 22:31:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUio-0002KX-UV; Thu, 22 Sep 2022 22:31:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obUio-0002yV-I3; Thu, 22 Sep 2022 22:31:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obUio-0001RZ-HZ; Thu, 22 Sep 2022 22:31:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=icPgQmObSDke0/W3OTOC5Np9+TIA8plAwqiI9ESxrCg=; b=GUpfoZqmw3OQt+25bmW0f1BN33 k6u+0mSP/QXOPzaofL8SHK9n4hQFGf72UR/roNIJrDU8Slgspn9Q7MykWchP7NcgY0/C67GOCxzFJ TWoC6hwmVUgYuVpjd2ZICZYUuBPEi2eYQQJwDW7tHRn+hVWOFZnD/Iv3ph3mjFLOYQrg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173281: all pass - PUSHED X-Osstest-Versions-This: ovmf=dd1e20b3c281940c5b5783151b24cf6ceeb31ca3 X-Osstest-Versions-That: ovmf=62f00dad22bc657290780dc65c6f1b8ac6e88f9b From: osstest service owner Date: Thu, 22 Sep 2022 22:31:06 +0000 flight 173281 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173281/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf dd1e20b3c281940c5b5783151b24cf6ceeb31ca3 baseline version: ovmf 62f00dad22bc657290780dc65c6f1b8ac6e88f9b Last test of basis 173278 2022-09-22 12:40:26 Z 0 days Testing same since 173281 2022-09-22 19:41:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 62f00dad22..dd1e20b3c2 dd1e20b3c281940c5b5783151b24cf6ceeb31ca3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Sep 22 23:27:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 22 Sep 2022 23:27:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410531.653583 (Exim 4.92) (envelope-from ) id 1obVbQ-0004sk-LK; Thu, 22 Sep 2022 23:27:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410531.653583; Thu, 22 Sep 2022 23:27:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obVbQ-0004sd-Hb; Thu, 22 Sep 2022 23:27:32 +0000 Received: by outflank-mailman (input) for mailman id 410531; Thu, 22 Sep 2022 23:27:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obVbO-0004sX-KX for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 23:27:31 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d58c64a-3ace-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 01:27:27 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6DA355C009E; Thu, 22 Sep 2022 19:27:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 22 Sep 2022 19:27:24 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 19:27:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d58c64a-3ace-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663889244; x= 1663975644; bh=NATz2eZd4ruDPDhqkThpsKKoxTGUAMa5GGSs6QDuXBM=; b=k M0+o2rmNRaO8Mzt5yuSVbbU3gVbZMLMe+o2BRK7d6nkWMApDczUi8bReVTTHjp/3 8jmAAmfEMaKBoBr7xpaG110ZWvf+vIUZu+12MPQii/wMtp6ccsG4KrHmdNZdCSXu kcIxa89ai2MZ9k+W5rKkVB2d4gVM3p01zbYEjU1odt/vUs8/nyCmBadO43xKfs/K Vq2/SlJSAyBpI9TIyQH5JPRHzIkwgFFkgZiO1UWVQJ9R08yDPsIqDXXwlTwB94bX BjEbnqFAIUk7O97JELpzRNkh9dencuaGWyKt4arvdFJ1I0GiKs/XKo7KKVsCSdvk rSHitjkVb9cpqYCqbOaWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663889244; x=1663975644; bh=NATz2eZd4ruDPDhqkThpsKKoxTGU AMa5GGSs6QDuXBM=; b=GJS2pqK3vOu+LYXtm2bNPC1WyCBSzfiafb3ggDbTdmfG YefNCO1IaWxCeOHqDDAbwMzWYjExEZ5IUO9FigiZ1VfXq6O9fnTiMP2nMii8VIdN K/1AJLCjd22SGD5SNGlOyoo5jbLt4D2tklCLAItQESe7yO83sxU3J8rfS38A1nP/ stqiFV2Ff6yEfRJrEtRSNvRs7LdMCwLHaB3oPWewc+A8wdQXuizA/WNe3idEk82w yxLRyKBoeoXQbHqWot7mhLF2orGdkz3v7so+T0h/LUO6A5uX/4NsMaKq9SGFVwaB oZLXb4V4AOIoHzptRPaMdy4oswZTdfokGvL9ip6mCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefhedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 22 Sep 2022 19:25:32 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3] Support ESRT in Xen dom0 Message-ID: References: <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GRcGP6sBkPbgCb0x" Content-Disposition: inline In-Reply-To: --GRcGP6sBkPbgCb0x Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Sep 2022 19:25:32 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3] Support ESRT in Xen dom0 On Fri, Sep 23, 2022 at 12:14:50AM +0200, Ard Biesheuvel wrote: > On Thu, 22 Sept 2022 at 20:12, Demi Marie Obenour > wrote: > > > > On Thu, Sep 22, 2022 at 05:05:43PM +0200, Ard Biesheuvel wrote: > > > On Thu, 22 Sept 2022 at 16:56, Demi Marie Obenour > > > wrote: > > > > > > > > On Thu, Sep 22, 2022 at 08:12:14AM +0200, Jan Beulich wrote: > > > > > On 22.09.2022 03:09, Demi Marie Obenour wrote: > > > > > > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > > > > > >> On 20.09.2022 18:09, Ard Biesheuvel wrote: > > > > > >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: > > > > > >>>> > > > > > >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: > > > > > >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > > > > >>>>> wrote: > > > > > >>>>>> > > > > > >>>>>> fwupd requires access to the EFI System Resource Table (ES= RT) to > > > > > >>>>>> discover which firmware can be updated by the OS. Current= ly, Linux does > > > > > >>>>>> not expose the ESRT when running as a Xen dom0. Therefore= , it is not > > > > > >>>>>> possible to use fwupd in a Xen dom0, which is a serious pr= oblem for e.g. > > > > > >>>>>> Qubes OS. > > > > > >>>>>> > > > > > >>>>>> Before Xen 4.16, this was not fixable due to hypervisor li= mitations. > > > > > >>>>>> The UEFI specification requires the ESRT to be in EfiBootS= ervicesData > > > > > >>>>>> memory, which Xen will use for whatever purposes it likes.= Therefore, > > > > > >>>>>> Linux cannot safely access the ESRT, as Xen may have overw= ritten it. > > > > > >>>>>> > > > > > >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in EfiBo= otServicesData > > > > > >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in EfiBo= otServicesData > > > > > >>>>>> memory, Xen allocates some memory of type EfiRuntimeServic= esData, copies > > > > > >>>>>> the ESRT to it, and finally replaces the ESRT pointer with= a pointer to > > > > > >>>>>> the copy. Since Xen will not clobber EfiRuntimeServicesDa= ta memory, > > > > > >>>>>> this ensures that the ESRT can safely be accessed by the O= S. It is safe > > > > > >>>>>> to access the ESRT under Xen if, and only if, it is in mem= ory of type > > > > > >>>>>> EfiRuntimeServicesData. > > > > > >>>>>> > > > > > >>>>> > > > > > >>>>> Thanks for the elaborate explanation. This is really helpfu= l. > > > > > >>>>> > > > > > >>>>> So here, you are explaining that the only way for Xen to pr= event > > > > > >>>>> itself from potentially clobbering the ESRT is by creating a > > > > > >>>>> completely new allocation? > > > > > >>>> > > > > > >>>> There are surely other ways, e.g. preserving BootServices* r= egions > > > > > >>>> alongside RuntimeServices* ones. But as the maintainer of th= e EFI > > > > > >>>> code in Xen I don't view this as a reasonable approach. > > > > > >>> > > > > > >>> Why not? > > > > > >> > > > > > >> Because it's against the intentions the EFI has (or at least h= ad) > > > > > >> for this memory type. Much more than EfiAcpiReclaimMemory this > > > > > >> type is intended for use as ordinary RAM post-boot. > > > > > > > > > > > > What about giving that memory to dom0? dom0=E2=80=99s balloon = driver will give > > > > > > anything dom0 doesn=E2=80=99t wind up using back to Xen. > > > > > > > > > > While perhaps in principle possible, this would require special c= asing > > > > > in Xen. Except for the memory the initrd comes in, we don't direc= tly > > > > > hand memory to Dom0. Instead everything goes through the page all= ocator > > > > > first. Plus if we really were convinced boot services memory need= ed > > > > > retaining, then it would also need retaining across kexec (and he= nce > > > > > shouldn't be left to Dom0 to decide what to do with it). > > > > > > > > So how should dom0 handle the various EFI tables other than the ESR= T? > > > > Right now most uses of these tables in Linux are not guarded by any > > > > checks for efi_enabled(EFI_MEMMAP) or similar. If some of them are= in > > > > EfiBootServicesData memory, they might be corrupted before Linux ge= ts > > > > them. > > > > > > Yes, this is an annoying oversight of the EFI design: the config > > > tables are tuples, and the size of the table is > > > specific to each table type. So without knowing the GUID, there is no > > > way you can reserve the right size. > > > > > > Perhaps you could implement something like a hypercall in > > > efi_arch_mem_reserve(), which is called by the EFI code to reserve > > > regions that are in boot services memory but need to remain reserved? > > > This is used for all config tables that it knows or cares about. > > > > On versions of Xen that support spawning multiple domains at boot > > (instead of just dom0) this will be racy. What about refusing to use > > tables in EfiBootServicesData when running under Xen unless a hypercall > > indicates that Xen has reserved all EfiBootServicesData memory? Where > > could such a check be placed? >=20 > You could stick a check inside the for loop in > efi_config_parse_tables() to cross reference every table address > against the memory map when running on Xen, and disregard it if it > doesn't meet your criteria. >=20 > I take it the issue is not limited to x86? Indeed the issue is cross-platform. For Qubes OS, I wonder if a safer approach would be to reserve all EfiBootServicesData memory by default. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --GRcGP6sBkPbgCb0x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmMs71kACgkQsoi1X/+c IsGs/g//UTu+abXay03rXZ2nW5p6CsJQWGwF+Es58U0c1hJHgmp+nLyZdttBRgnt 49nGc43rbHCNODqXZu/R9TyK6gef1ZqaAiZyV2vHFitnhrbLz2VZFMNUwmpz6zbi MA1SGQjYmfbIU5wU/6Nym8sF51CridQs8+UqVh9h3dbog6RWw9qvYYiz4xEe9cCi w7alXoYFT2JdorwNX+heUDX2/TkaYtrzsVRUMJ+bOedGPOgqtw1f6AhicUJV1KZ/ ztszH/HxcdTO4c8rdYaIH6CKN8LIdQex6V/WNmio+dMq6fD5tDSVB9OBRqXZUbzk sbEdnsJSL1/lwab5C6f/kP4+GDILJBU1747758MbviUtZ9zXaAj3G9o3ymYtnUuN NcK2nneVI5Thz2Obmt3RRA7zWjJt827fzxQzIAl6bsSgiUHtg8eD5TUx7yxJIXgL 3F3J1ieo54ARic4+q4+9Bj7CIWFV+nN6CQgDpf5z16f2utgG+Y7Bi9iZ8z0j+TjE uuaMqZpTMA5MYhaJZc0V12PEkSxj4mOSDm5MWH8mDWthOMp4qiRvuFOUKc2ok0Dq joZl/hFN/zVa77+T687aPewkfPNc2m5ldag/04aZnyXC+jhP0dl9QRCotZyq+FYT lQnxoN7KeQpBQn5D+qkNyHZtm1z4Wo7llrNFYVayXN+tQTSz6sQ= =El6T -----END PGP SIGNATURE----- --GRcGP6sBkPbgCb0x-- From xen-devel-bounces@lists.xenproject.org Fri Sep 23 00:47:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 00:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410537.653594 (Exim 4.92) (envelope-from ) id 1obWqA-00061L-0x; Fri, 23 Sep 2022 00:46:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410537.653594; Fri, 23 Sep 2022 00:46:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obWq9-00061E-TD; Fri, 23 Sep 2022 00:46:49 +0000 Received: by outflank-mailman (input) for mailman id 410537; Fri, 23 Sep 2022 00:46:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obWq9-000613-4U; Fri, 23 Sep 2022 00:46:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obWq9-0005NV-0H; Fri, 23 Sep 2022 00:46:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obWq8-0000H0-A3; Fri, 23 Sep 2022 00:46:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obWq8-0007x4-9a; Fri, 23 Sep 2022 00:46:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YQzxDN1flCVWRvlQJ6Lb/X5KRiVRpKFXRtCJKezOrxk=; b=aVVUstISZk0s6K+8nFQRdF92o2 9xfZzRmjnoAWhCut1b2NKA0r184QNONdyVKygH1bsaOT6OGvWF49DGKj9fosbwBx0viioruFcpdnp 1/D5j4uuYyzQfDTdR+HLy2TK4LnDt21a0UFACOezt9SOaPrbb85wA1PpNtJqbAhNLhTM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173279: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c69cf88cda5faca0e411babb67ac0d8bfd8b4646 X-Osstest-Versions-That: linux=dc164f4fb00a0abebdfff132f8bc7291a28f5401 From: osstest service owner Date: Fri, 23 Sep 2022 00:46:48 +0000 flight 173279 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173279/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173271 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173271 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173271 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173271 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173271 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173271 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173271 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173271 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux c69cf88cda5faca0e411babb67ac0d8bfd8b4646 baseline version: linux dc164f4fb00a0abebdfff132f8bc7291a28f5401 Last test of basis 173271 2022-09-22 00:41:19 Z 1 days Testing same since 173279 2022-09-22 18:41:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Ford Adrian Hunter Alex Elder Alexander Stein Andrii Staikov Andy Shevchenko Ard Biesheuvel Arnaldo Carvalho de Melo Arnd Bergmann Arpana Arland (A Contingent worker at Intel) Arınç ÜNAL Bartosz Golaszewski Benjamin Poirier Bharathi Sreenivas Bhupesh Sharma Brett Creeley Brian Norris Claudiu Beznea Cong Wang Cristian Marussi Daniel Dao Dave Ertman David Leadbeater David S. Miller David Thompson Ding Hui Dongliang Mu Edward Cree Emmanuel Grumbach Fabio Estevam Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Wunderlich Geert Uytterhoeven Guilherme G. Piccoli Gurucharan (A Contingent worker at Intel) Haimin Zhang Haimin Zhang Haiyang Zhang Hangbin Liu Hangyu Hua Heiko Stuebner Helena Anna Dubel Horatiu Vultur Ido Schimmel Igor Ryzhov Ioana Ciornei Jagan Teki Jakub Kicinski Jason A. Donenfeld Jay Vosburgh Jeroen de Borst Jianglei Nie Jie2x Zhou Jonathan Toppins Kalle Valo Konrad Jankowski Krzysztof Kozlowski Larysa Zaremba Leo Yan Liang He Lieven Hey Linus Torvalds Linus Walleij Lorenzo Bianconi Lu Wei Lucas Stach Ludovic Cintrat Luiz Augusto von Dentz Marc Kleine-Budde Marc Zyngier Marcel Ziswiler Marco Felsch Marek Vasut Mateusz Palczewski Matthieu Baerts Meng Li Miaoqian Lin Michael Riesch Michael Walle Michal Jaron Michal Swiatkowski Namhyung Kim Nicolas Frattaroli Norbert Zulinski Oleksandr Mazur Pablo Neira Ayuso Paolo Abeni Peilin Ye Peng Fan Peter Geis Petr Oros Philippe Schenker Rakesh Sankaranarayanan Roberto Ricci Sean Anderson Sergei Antonov Sergio Paracuellos Shailend Chand Shawn Guo Shigeru Yoshida Simon Wunderlich Sudeep Holla Sven Eckelmann Sylwester Dziedziuch syzbot Tetsuo Handa Thorsten Scherer Tim Harvey Toke Høiland-Jørgensen Tony Nguyen Vadim Fedorenko Vinod Koul Vladimir Oltean Wen Gu zain wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git dc164f4fb00a..c69cf88cda5f c69cf88cda5faca0e411babb67ac0d8bfd8b4646 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Sep 23 01:27:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 01:27:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410547.653604 (Exim 4.92) (envelope-from ) id 1obXTW-0000jn-5R; Fri, 23 Sep 2022 01:27:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410547.653604; Fri, 23 Sep 2022 01:27:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obXTW-0000jg-2e; Fri, 23 Sep 2022 01:27:30 +0000 Received: by outflank-mailman (input) for mailman id 410547; Fri, 23 Sep 2022 01:27:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obXTU-0000ja-Sr for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 01:27:29 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140051.outbound.protection.outlook.com [40.107.14.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1c74d81-3ade-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 03:27:26 +0200 (CEST) Received: from FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::8) by DBBPR08MB6121.eurprd08.prod.outlook.com (2603:10a6:10:204::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Fri, 23 Sep 2022 01:27:20 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a8:cafe::b2) by FR0P281CA0108.outlook.office365.com (2603:10a6:d10:a8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.7 via Frontend Transport; Fri, 23 Sep 2022 01:27:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 01:27:19 +0000 Received: ("Tessian outbound 3c27ae03f5ec:v124"); Fri, 23 Sep 2022 01:27:18 +0000 Received: from 0e4e8aa097fa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 423C1DD1-32C3-4483-B0B7-5B77306861D9.1; Fri, 23 Sep 2022 01:27:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0e4e8aa097fa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Sep 2022 01:27:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB8475.eurprd08.prod.outlook.com (2603:10a6:150:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Fri, 23 Sep 2022 01:27:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5654.018; Fri, 23 Sep 2022 01:27:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1c74d81-3ade-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BssfqdsUVGiUdV1hiJgl57qA4sRAWfRBLlu34cibvWD3Fz/WFUVaUwH8N656K9bdgtzZmNNI2Srdzifrj+XdinS+ylbUtJtLazs9mZNJwHnTaKbbVdZLm9HyIEX8YON8HJGEY888RxzrSEeBhaAjz1rnhXJ4QQvwXoKYk1gEJcBSuWGkwE5uu/fP56zkLdgWixPIolkl8YSFdy+Bp1h8+8+S9v6HH98WxtwM9pNWXgIeX4O1GDoUCfif3hUnbBF58M+DrwmW+7z8ROHcVBpsgiKmQp8/JsvKNSq4r6E7+s7srVUvcl2bB4NBhaxgQq7QTINH7wkT/+92cmAsoXt7Ow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PVBCT6sl+qiI7wxRTwf3Npb6ltJvjmU82zh4C/SMI1Y=; b=WnG2aL4IpD7OES2eDWqge9uitGomZe28/7L8xflrH+rjR165PcNQ3+oDi0Fhoj6pGXWs6Eoh1pbh8gFeuQKx9SMoQXDSuQHRoQBMzp76NjDKydPwka1eU5JZEIjSbM/7mcb2TAp5wARqgcgn7e8R1tGilkGwLT4mNGsoScayFZFeuzB5YDLEarCLeYq9MogTvzSR2dYq+CxXsC3WbDM90PZeLqMXEdUjqIeYxkDNxeRs6nqUVlXsxoBL80twfF3h2KjE+cXg3Za5GEtAtVBXBh3ignCwbtGyRx0AdcjaGXfkKLYbSia8eKmGzAlpzzjOxo+MqQ6gIeDapXAthZOi7g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PVBCT6sl+qiI7wxRTwf3Npb6ltJvjmU82zh4C/SMI1Y=; b=5xnsvyBm5WTTPgZ1V/2ejvJLVY4BPNMtcqhW3C5uLWh0oNdQuAjy6DaSBwVbnvcn7d6XgsWbKE70AP59+dRz9Hzrrcjsp/uvfNdbBJ66ko6EjzkxV+4ObNnbpSB8EtJnoXRyq09zTy7TZU+ZquctsqNEOJFU8T4uUN5JWT6H+Lo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lj/wouapa+0AU3vrlxHczgfAr9H5p2xm6GhMWgINYbctO3ac41HY4+BKKQGDdwtdubRr1y4cSDKNKw+AhAHNQud15A0QuR6q9kMkSJpnC6kZhJrr6Vs/VhTceAjzE9+t9muLzEhxGIDPn0acBvV7SMTCBb5yXZSStkRzV5abJ2CRsMyMOikGcH6i6eYjx5uRop+SBoWNs5IJQCuggPnJf3jgYB6DBwRl+lr8MnHob0yzH10vEfPyvr78KS5GWvUR9o8vihyX06MxKDCJ5OVhdNY1HLHkQGT/eNlK65n25N40tQxTvSnkEjcbSAPv5y4srTFIuaWlckjPBRQwXwKZew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PVBCT6sl+qiI7wxRTwf3Npb6ltJvjmU82zh4C/SMI1Y=; b=KECQjoO7U3SBGexXxrhqmvb41VUwnxqS9JTv3XbXUJnVKJAsL7UNp5WlqXaEUQYxZn/uC4PA5nSOD1o0cO1PXFcXhnBAYhRxVca7Dcx1frF3VuvaewI1JRzTe0arn3Tbrhl7B5fLnMJnkUzjtLAE4ba9IvU3zAz+QJZp16TT7p4sOs0FDJyDU+qNB0knvK6rcV6ZdvyhXI00/wiypkFrWqcVkKOblfKlIA45bUzwaFZxxfobbxtCWLM67PvF0Zwcq4KKlGoZkTLYHQ5bjl0YTUhwQvQK5+K53arNmSffeMk28rCMRHJ4hXcs1cdds6foKTTJt5Z0g5nIWSeVT3bR1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PVBCT6sl+qiI7wxRTwf3Npb6ltJvjmU82zh4C/SMI1Y=; b=5xnsvyBm5WTTPgZ1V/2ejvJLVY4BPNMtcqhW3C5uLWh0oNdQuAjy6DaSBwVbnvcn7d6XgsWbKE70AP59+dRz9Hzrrcjsp/uvfNdbBJ66ko6EjzkxV+4ObNnbpSB8EtJnoXRyq09zTy7TZU+ZquctsqNEOJFU8T4uUN5JWT6H+Lo= From: Henry Wang To: Stefano Stabellini , Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: RE: [PATCH 1/9] automation: Use custom build jobs when extra config options are needed Thread-Topic: [PATCH 1/9] automation: Use custom build jobs when extra config options are needed Thread-Index: AQHYzokNujrks6NSW0iEIqimdlIitq3r+qqAgAA/LlA= Date: Fri, 23 Sep 2022 01:27:10 +0000 Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-2-michal.orzel@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DF59CA58D09105428EC47F7F765E0560.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GV1PR08MB8475:EE_|VE1EUR03FT043:EE_|DBBPR08MB6121:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c597e4b-07c4-40fe-dc41-08da9d02c1d9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QCfgOeUvlPKHEyAaTzRskkRbIy8DuVLAGNPKOx8QJR8wxMoS3AChJyKnxak699QvMQEUxiqUaYSDP46brtxkV0z0YSYJQ0Z5fn76wXKvcppwH2yC52cm5VgEv56uTxKBG9o91s1hk+S6m06v84YE8O4lPcH7aTIa7TFEjezGl9CT7Y6zf6T26a2BI4em2fkS3XviaXWOejYZ65djZtat0nhMM3dSR0pLZvGM8U4kgpesyxlPzrpp3fOF4Uw0xNN2HWjaKJehj52VTXvlgLovhp0fl72ef4MzpB02qeDKY87Unh5pKHozc7DGrC97cZNq79r7kv6RKrBPTofwW77ilwPD8r32eExxkSt2MFFRm2una6l5nF/TnnBL238vtJGQUm5++af36FptH7YRpJpEqaZiNx6V5rgoZeWtFCV2yx7Bbbt4rMTJna9Y12K+oAjuzeJHgxfC/oHy+vVmVPwPY5MIT1DYa/uq0WCV/o9ub3jLN0lIxMPkABaMKhd9FEmMwqPHYz77jzbv03G2lCkYd6EIbKy87CfVD/5S+C/inQRudBPYGMthcSYrKc/+YVygjnfN22TyqBL24VsMuT9glUlj+1klNLcEzaduQGd8uU9G+ipqa8nhmAgWx5YKs6+iEF/OvqMboSPCo3AdOOtBqvpNqlPoel9/27rkY7vargtrFvy62xM6K4l9uKu4ufoVBLILrpXoCqyCtlBTvTW6r2Iy9i5HBFIpnfQNZnBEVU9koa7d9tBDLZx6Rumlmoo4WS4pcw3pFLAvc7a9sQpxmA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(52536014)(2906002)(5660300002)(66556008)(66946007)(64756008)(8936002)(4326008)(8676002)(66476007)(66446008)(38100700002)(41300700001)(55016003)(122000001)(86362001)(478600001)(6506007)(26005)(7696005)(9686003)(76116006)(54906003)(38070700005)(110136005)(71200400001)(33656002)(316002)(186003)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8475 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f3b36577-a452-44b3-e218-08da9d02bcd4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gCoclhsgZQmB6DNTFBGk+uc6Tyf1x++GZdZSnqdrfsQdOlemoVr15Vi7/ZPtsxbY2nuI5NvMSZqiC8WJDEfyv4t0vvvL0BEUhuHQjio6aTqNwRWi7AptD72uk27P2GkcsJLFh7pOJ4g24BWaUfnATU74j+F3nuXoj26q1U/+Ggcq3SI15TDdA/ZBfOQAqque9jitJKgPEEJefOGHZC9MJHIKRKpP1ipzyhHBvrz3gNHe1Ffxpj4xe8z0p2zX1m+QzoBNi4N8h+OgwRCYqpaY/W1S/19yDZgPrOPKG9S34Ltr2hEe4zcVBAu3Y7p57tHJ+nhPEVNqPjYdCQm39AGY2JM3AUMXGEr5/9tGDtrP4Lz/9TI0Mxwd0VPxgvHhI+WznvlvK8mYPnrx9jJ+RPzT5+co4CRJHUtaOJJdHkj5jIr+UijFrkomnyWMqpZ4IxovxELnTsCLis1rpNensBEAhtqeCN+ZaK6Zun1q4dYeFY6Gr4Au4qT/x1cfGWk9qS2SeKYok7EjKIXyFTnPArgPVXQjD0ASdsxMBJM5nhO3gv4J6K03P9WWbBl50TK7wFdikgJysZvSX8pAnq42TdiOyBEu2xw7xWSlgInIn6OwaYvynaMsE2nsV1g6McxiO3w2HukeXWRoPF56tf/WpDQYPAjU6IyrzSdxgnQt0IO26aHPaiot9U/nX+Mazmfv60Q4mGpKbemPQY9PYH2HI4X2qDekGkU6SbJpO7TNfV1PbtfWhcG0kADwmX+yVHmJnRc7TqxOGTZqYx1faR52OY3UDQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(107886003)(33656002)(478600001)(4326008)(8676002)(7696005)(40480700001)(70206006)(6506007)(55016003)(70586007)(110136005)(316002)(54906003)(82740400003)(36860700001)(81166007)(356005)(40460700003)(186003)(9686003)(83380400001)(336012)(86362001)(26005)(47076005)(82310400005)(8936002)(52536014)(5660300002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 01:27:19.2899 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c597e4b-07c4-40fe-dc41-08da9d02c1d9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6121 Hi Stefano, > -----Original Message----- > From: Stefano Stabellini > Subject: Re: [PATCH 1/9] automation: Use custom build jobs when extra > config options are needed >=20 > On Thu, 22 Sep 2022, Michal Orzel wrote: > > Currently, all the arm64 defconfig build jobs, regardless of the > > container used, end up building Xen with the extra config options > > specified in the main build script (e.g. CONFIG_EXPERT, > > CONFIG_STATIC_MEMORY). Because these options are only needed for > > specific test jobs, the current behavior of the CI is incorrect > > as we add the extra options to all the defconfig builds. This means > > that on arm64 there is not a single job performing proper defconfig bui= ld. > > > > To fix this issue, add custom build jobs each time there is a need for > > building Xen with additional config options. Introduce EXTRA_XEN_CONFIG > > variable to be used by these jobs to store the required options. This > > variable will be then read by the main build script to modify the .conf= ig > > file. This will also help users to understand what is needed to run spe= cific > > test. > > > > Signed-off-by: Michal Orzel > > --- > > This patch could actually be consider to be taken for 4.17 release. > > The reason why is because currently our CI for arm64 does not even > > peform clean defconfig build which is quite crucial target to be tested= . > > Performing builds always with EXPERT and UNSUPPORTED is not something > so > > beneficial for release tests. This is up to the release manager. >=20 > + Henry >=20 > I agree this should go in 4.17, so that gitlab-ci can test non-DEBUG > builds on ARM. Yes sure, I agree once this series is properly reviewed, this can be merged to 4.17. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Sep 23 01:49:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 01:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410552.653616 (Exim 4.92) (envelope-from ) id 1obXoT-0003QV-S8; Fri, 23 Sep 2022 01:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410552.653616; Fri, 23 Sep 2022 01:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obXoT-0003QO-O4; Fri, 23 Sep 2022 01:49:09 +0000 Received: by outflank-mailman (input) for mailman id 410552; Fri, 23 Sep 2022 01:49:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obXoR-0003QH-NK for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 01:49:08 +0000 Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com [2a0c:5a00:149::26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e76047f6-3ae1-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 03:49:04 +0200 (CEST) Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1obXoM-002cCW-5n; Fri, 23 Sep 2022 03:49:02 +0200 Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1obXoL-0003T8-BT; Fri, 23 Sep 2022 03:49:01 +0200 Received: by submission01.runbox with esmtpsa [Authenticated ID (536975)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1obXoI-0001g4-Ni; Fri, 23 Sep 2022 03:48:58 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e76047f6-3ae1-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References :Cc:To:Subject:From:MIME-Version:Date:Message-ID; bh=Zb+Ndi6hr3zgnjOrbLIzoHacaBvMqQUP3vkITYGJe5I=; b=Ewm7OpFGDPfREfqbSPGkFZa853 MyMbGYi1Plb5bUsXOAxS3pnhGcDNyUSN6qSiQ6OhJdqZKDfuHm9LnEhpYrRlV9Jyzao6E8ZZMsjPa Qqa5bGRHKYlxWTxo0JxIYNxrN3eZfWap8f0sJNyQryFWZGPBqAb9nn1gd/myzmZ5BHYPAQSMA6TA4 H7C3DbyGAeYg9/W5RfsOmA5zFrCItMibjd1t8JxX58pvqMLr6bE6pBKguLH3pn2aZWiOlkDJEB9Mr w8DzYQghq8/aKi9N93COsgZmoM7rO0jvaBF8yu+luFEVFLkkOhH+EzWOJ5cUkFnsSWEI0dyN94DJ+ /H1TsaaA==; Message-ID: <1bc60f1c-2aa7-2d4a-a6a2-c8592ed83486@runbox.com> Date: Thu, 22 Sep 2022 21:48:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 From: "M. Vefa Bicakci" Subject: Re: [PATCH 1/2] xen/gntdev: Prevent leaking grants To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour , Gerd Hoffmann References: <20220912040002.198191-1-m.v.b@runbox.com> <20220912040002.198191-2-m.v.b@runbox.com> Content-Language: en-CA In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2022-09-19 05:52, Juergen Gross wrote: > On 12.09.22 06:00, M. Vefa Bicakci wrote: >> Prior to this commit, if a grant mapping operation failed partially, >> some of the entries in the map_ops array would be invalid, whereas all >> of the entries in the kmap_ops array would be valid. This in turn would >> cause the following logic in gntdev_map_grant_pages to become invalid: >> >>    for (i = 0; i < map->count; i++) { >>      if (map->map_ops[i].status == GNTST_okay) { >>        map->unmap_ops[i].handle = map->map_ops[i].handle; >>        if (!use_ptemod) >>          alloced++; >>      } >>      if (use_ptemod) { >>        if (map->kmap_ops[i].status == GNTST_okay) { >>          if (map->map_ops[i].status == GNTST_okay) >>            alloced++; >>          map->kunmap_ops[i].handle = map->kmap_ops[i].handle; >>        } >>      } >>    } >>    ... >>    atomic_add(alloced, &map->live_grants); >> >> Assume that use_ptemod is true (i.e., the domain mapping the granted >> pages is a paravirtualized domain). In the code excerpt above, note that >> the "alloced" variable is only incremented when both kmap_ops[i].status >> and map_ops[i].status are set to GNTST_okay (i.e., both mapping >> operations are successful).  However, as also noted above, there are >> cases where a grant mapping operation fails partially, breaking the >> assumption of the code excerpt above. >> >> The aforementioned causes map->live_grants to be incorrectly set. In >> some cases, all of the map_ops mappings fail, but all of the kmap_ops >> mappings succeed, meaning that live_grants may remain zero. This in turn >> makes it impossible to unmap the successfully grant-mapped pages pointed >> to by kmap_ops, because unmap_grant_pages has the following snippet of >> code at its beginning: >> >>    if (atomic_read(&map->live_grants) == 0) >>      return; /* Nothing to do */ >> >> In other cases where only some of the map_ops mappings fail but all >> kmap_ops mappings succeed, live_grants is made positive, but when the >> user requests unmapping the grant-mapped pages, __unmap_grant_pages_done >> will then make map->live_grants negative, because the latter function >> does not check if all of the pages that were requested to be unmapped >> were actually unmapped, and the same function unconditionally subtracts >> "data->count" (i.e., a value that can be greater than map->live_grants) >> from map->live_grants. The side effects of a negative live_grants value >> have not been studied. >> >> The net effect of all of this is that grant references are leaked in one >> of the above conditions. In Qubes OS v4.1 (which uses Xen's grant >> mechanism extensively for X11 GUI isolation), this issue manifests >> itself with warning messages like the following to be printed out by the >> Linux kernel in the VM that had granted pages (that contain X11 GUI >> window data) to dom0: "g.e. 0x1234 still pending", especially after the >> user rapidly resizes GUI VM windows (causing some grant-mapping >> operations to partially or completely fail, due to the fact that the VM >> unshares some of the pages as part of the window resizing, making the >> pages impossible to grant-map from dom0). >> >> The fix for this issue involves counting all successful map_ops and >> kmap_ops mappings separately, and then adding the sum to live_grants. >> During unmapping, only the number of successfully unmapped grants is >> subtracted from live_grants. To determine which grants were successfully >> unmapped, their status fields are set to an arbitrary positive number >> (1), as was done in commit ebee0eab0859 ("Xen/gntdev: correct error >> checking in gntdev_map_grant_pages()"). The code is also modified to >> check for negative live_grants values after the subtraction and warn the >> user. >> >> Link: https://github.com/QubesOS/qubes-issues/issues/7631 >> Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") >> Cc: stable@vger.kernel.org >> Signed-off-by: M. Vefa Bicakci >> --- >>   drivers/xen/gntdev.c | 32 +++++++++++++++++++++++++++----- >>   1 file changed, 27 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c >> index 84b143eef395..485fa9c630aa 100644 >> --- a/drivers/xen/gntdev.c >> +++ b/drivers/xen/gntdev.c >> @@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) >>       for (i = 0; i < map->count; i++) { >>           if (map->map_ops[i].status == GNTST_okay) { >>               map->unmap_ops[i].handle = map->map_ops[i].handle; >> -            if (!use_ptemod) >> -                alloced++; >> +            alloced++; >>           } else if (!err) >>               err = -EINVAL; >> @@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) >>           if (use_ptemod) { >>               if (map->kmap_ops[i].status == GNTST_okay) { >> -                if (map->map_ops[i].status == GNTST_okay) >> -                    alloced++; >> +                alloced++; >>                   map->kunmap_ops[i].handle = map->kmap_ops[i].handle; >>               } else if (!err) >>                   err = -EINVAL; >> @@ -394,8 +392,13 @@ static void __unmap_grant_pages_done(int result, >>       unsigned int i; >>       struct gntdev_grant_map *map = data->data; >>       unsigned int offset = data->unmap_ops - map->unmap_ops; >> +    int successful_unmaps = 0; >> +    int live_grants; >>       for (i = 0; i < data->count; i++) { >> +        if (map->unmap_ops[offset + i].status == GNTST_okay) >> +            successful_unmaps++; > Hi, Sorry for the delay, and thank you for reviewing my patches! > Shouldn't this test include "&& handle != INVALID_GRANT_HANDLE" ? > > This should enable you to drop setting status to 1 below. I had not thought of the approach you suggested. Just now, I applied your suggestion to my local kernel tree, and I am building a new kernel for testing now. I hope to publish a newer version of this patch set over the weekend. Thanks again, Vefa > >> + >>           WARN_ON(map->unmap_ops[offset + i].status != GNTST_okay && >>               map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); >>           pr_debug("unmap handle=%d st=%d\n", >> @@ -403,6 +406,9 @@ static void __unmap_grant_pages_done(int result, >>               map->unmap_ops[offset+i].status); >>           map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; >>           if (use_ptemod) { >> +            if (map->kunmap_ops[offset + i].status == GNTST_okay) >> +                successful_unmaps++; >> + >>               WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay && >>                   map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); >>               pr_debug("kunmap handle=%u st=%d\n", >> @@ -411,11 +417,15 @@ static void __unmap_grant_pages_done(int result, >>               map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; >>           } >>       } >> + >>       /* >>        * Decrease the live-grant counter.  This must happen after the loop to >>        * prevent premature reuse of the grants by gnttab_mmap(). >>        */ >> -    atomic_sub(data->count, &map->live_grants); >> +    live_grants = atomic_sub_return(successful_unmaps, &map->live_grants); >> +    if (WARN_ON(live_grants < 0)) >> +        pr_err("%s: live_grants became negative (%d) after unmapping %d pages!\n", >> +               __func__, live_grants, successful_unmaps); >>       /* Release reference taken by __unmap_grant_pages */ >>       gntdev_put_map(NULL, map); >> @@ -424,6 +434,8 @@ static void __unmap_grant_pages_done(int result, >>   static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, >>                      int pages) >>   { >> +    int idx; >> + >>       if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { >>           int pgno = (map->notify.addr >> PAGE_SHIFT); >> @@ -436,6 +448,16 @@ static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, >>           } >>       } >> +    /* Set all unmap/kunmap status fields to an arbitrary positive value, >> +     * so that it is possible to determine which grants were successfully >> +     * unmapped by inspecting the status fields. >> +     */ >> +    for (idx = offset; idx < offset + pages; idx++) { >> +        map->unmap_ops[idx].status = 1; >> +        if (use_ptemod) >> +            map->kunmap_ops[idx].status = 1; >> +    } >> + >>       map->unmap_data.unmap_ops = map->unmap_ops + offset; >>       map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; >>       map->unmap_data.pages = map->pages + offset; > > Juergen From xen-devel-bounces@lists.xenproject.org Fri Sep 23 02:56:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 02:56:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410558.653627 (Exim 4.92) (envelope-from ) id 1obYr3-0003IX-MJ; Fri, 23 Sep 2022 02:55:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410558.653627; Fri, 23 Sep 2022 02:55:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYr3-0003IQ-JR; Fri, 23 Sep 2022 02:55:53 +0000 Received: by outflank-mailman (input) for mailman id 410558; Fri, 23 Sep 2022 02:55:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYr2-0003IG-Pr; Fri, 23 Sep 2022 02:55:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYr2-0006UA-OA; Fri, 23 Sep 2022 02:55:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYr2-0003p0-ES; Fri, 23 Sep 2022 02:55:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obYr2-0000aU-DI; Fri, 23 Sep 2022 02:55:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FF13V5OoApDqq0ta85x1S9Zn9tWOD4AtcIDayJqY4tY=; b=WI+y2R6Edu/9ZKlsj0N5ONNgkL tNXbbaD+Lsrj05R5npY+m6iO2EGZx4OPS1cmjOZ+wiU1Jw18dn6KWc/2Bcmoh6kglvThQiVyHyIWK p+UweKmuJ4XFalRQuJ1wKSkppsuQxWCjteoX82Qm9dUXsd3vGmc78cFRqwr8hb2j361g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173282: all pass - PUSHED X-Osstest-Versions-This: ovmf=6f340acfb10992af914ed5e17127cc786e0a7f7b X-Osstest-Versions-That: ovmf=dd1e20b3c281940c5b5783151b24cf6ceeb31ca3 From: osstest service owner Date: Fri, 23 Sep 2022 02:55:52 +0000 flight 173282 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173282/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6f340acfb10992af914ed5e17127cc786e0a7f7b baseline version: ovmf dd1e20b3c281940c5b5783151b24cf6ceeb31ca3 Last test of basis 173281 2022-09-22 19:41:14 Z 0 days Testing same since 173282 2022-09-23 00:41:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Wenyi Xie jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git dd1e20b3c2..6f340acfb1 6f340acfb10992af914ed5e17127cc786e0a7f7b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 03:02:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 03:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410568.653638 (Exim 4.92) (envelope-from ) id 1obYxj-0004qj-KY; Fri, 23 Sep 2022 03:02:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410568.653638; Fri, 23 Sep 2022 03:02:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYxj-0004qb-Fq; Fri, 23 Sep 2022 03:02:47 +0000 Received: by outflank-mailman (input) for mailman id 410568; Fri, 23 Sep 2022 03:02:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYxh-0004qL-O4; Fri, 23 Sep 2022 03:02:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYxh-0006cX-Lb; Fri, 23 Sep 2022 03:02:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obYxh-000468-5p; Fri, 23 Sep 2022 03:02:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obYxh-0004L5-53; Fri, 23 Sep 2022 03:02:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SglT8erVACgE0dr5YnoSEAOFaUz9UxZ9NvHm3M3FlWU=; b=lye3sQGsI14LXFQ0U6n/k5FMVn 8H509FwPMh5QOhIP3KS7VNL/LgDnHM7QQkGc+RQ+ylQZD70e+J063xBbWnmgGH0Y07Om1oPTBFvzU crZn8v4CrnkuYCaSgDgJRNxcAdcq4Xyo0fE1XSebCEa+zvmXuvINBfGSTMLXMyAmcbEw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173280: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-pvshim:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6160d8ff81fb9fba70f5dad88d43ffd0fa44984c X-Osstest-Versions-That: qemuu=6338c30111d596d955e6bc933a82184a0b910c43 From: osstest service owner Date: Fri, 23 Sep 2022 03:02:45 +0000 flight 173280 qemu-mainline real [real] flight 173285 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173280/ http://logs.test-lab.xenproject.org/osstest/logs/173285/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvshim 20 guest-localmigrate/x10 fail pass in 173285-retest test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail pass in 173285-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 22 guest-start.2 fail blocked in 173272 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173272 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173272 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173272 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173272 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173272 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173272 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173272 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173272 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: qemuu 6160d8ff81fb9fba70f5dad88d43ffd0fa44984c baseline version: qemuu 6338c30111d596d955e6bc933a82184a0b910c43 Last test of basis 173272 2022-09-22 01:08:24 Z 1 days Testing same since 173280 2022-09-22 19:39:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Edgar E. Iglesias Jason A. Donenfeld Matheus Tavares Bernardino Stefan Hajnoczi Taylor Simpson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim fail test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6338c30111..6160d8ff81 6160d8ff81fb9fba70f5dad88d43ffd0fa44984c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Sep 23 05:10:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 05:10:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410219.653648 (Exim 4.92) (envelope-from ) id 1obawc-00021o-Mz; Fri, 23 Sep 2022 05:09:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410219.653648; Fri, 23 Sep 2022 05:09:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obawc-00021h-KJ; Fri, 23 Sep 2022 05:09:46 +0000 Received: by outflank-mailman (input) for mailman id 410219; Thu, 22 Sep 2022 14:26:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obNAF-0006TE-KD for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 14:26:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 961ac911-3a82-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 16:26:49 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Sep 2022 10:00:44 -0400 Received: from DM6PR03MB4138.namprd03.prod.outlook.com (2603:10b6:5:58::12) by CH0PR03MB6129.namprd03.prod.outlook.com (2603:10b6:610:b8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 14:00:35 +0000 Received: from DM6PR03MB4138.namprd03.prod.outlook.com ([fe80::653a:87b4:8096:8bf]) by DM6PR03MB4138.namprd03.prod.outlook.com ([fe80::653a:87b4:8096:8bf%7]) with mapi id 15.20.5654.014; Thu, 22 Sep 2022 14:00:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 961ac911-3a82-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663856812; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=0yB3CWTwn7miff6WKQfg4NNooeTmqdpZdK27Pwgqt2w=; b=ONJLUXM1B27xXjluG22Mlz1KTWe4e3uHvI9zUIcQ+Y3HT98EVgMK4BoG PQLEiuAheYkG7qnC1hYY6Vxs3E9349Vk5a/Sn0MOpVgLb5DT3jWg5GjZJ oia3yY/qUF8kTEde5sKZkV8Bvyxo5bqLWrX67n/AD87RaZG7GjfntX4Me M=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 80784651 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:b48NU6oGhvKtxlmG/vZ61N0QZs9eBmIzZBIvgKrLsJaIsI4StFCzt garIBmHOq2NMGWmLYwkaoWx9UgPscSAn4UySVRp+ShnRCpE8puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WlC5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVBqt13LWhgx 8AiFz8DLUnY3f71+omCH7wEasQLdKEHPas5k1Q5l3T1KKhjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/E4/NouQA/zyQouFTpGMLcZ5qRTMtSmFqwr WPa5WXpRBodMbRzzBLVqi382rGSxEsXXqoqHbCaqOdTkWfMz0NQITcLSmr4nPK23xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xHWEBUzNFLsIrrtQ9RTEu2 lKhgdr1CCcpvqf9YWOU8LHSoTKoIi8TBXELeSIfCwUfi+QPu6k2hxPLC9pmTqi8i4SvHSmqm m/Q6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHb5 yRb8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:sHky/6NbSNpo+8BcT23155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8Ar4wBkb6Jq90dq7MAjhHPlOkMQs1NaZLULbUQ6TQL2KgrGSpwEIdxeeygcZ79 YYT0EcMqy9MbEZt7ec3ODQKb9Jr7e6GeKT9IHjJhxWPGJXgtRbnmJE43GgYy9LrWd9ZaYRJd 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njBsRqYrJrBVzSI1BYXVD1ChZ0493 LergD/7qK/99mm1x7n0XPJ5Zg+oqqh9jIDPr3NtiEmEESvtu+aXvUlZ1REhkFwnAib0idorD ALmWZmAy080QKWQoj/m2qW5+Cp6kdS15al8y7WvZKrm72HeNpxYfAx+b5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa4HZcjEBS5dL7tUYvJrc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFkgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCPefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve4PcV T6ISFlXEIJCjLT4Je1reN2Gzj2MRSAdCWozN1C7J5kvbC5TKb3MES4OSMTr/c= X-IronPort-AV: E=Sophos;i="5.93,335,1654574400"; d="scan'208";a="80784651" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JpCv3qPz44qq1S3cqUdJyHCeAWrTBniTgdCVCfupgpUb4V7kmcc9H4XRh+Rz1RSYJTrpNfIRn0wMmuKI55WLNzxhRsj3zBV98dfvocT8/EljI54r/tVuM9Pn9THpqQpgZukR+XTBDLy5yFNfC0nec+2cHYyN/NwOyxhmE2dMtjTK7/S0acRj2PWsIDZasJ5vLlZ6m5uwaFjzilK7ZoWEp/zCmG5CNESYkUMlXHgLfkuOwq/AbXhs9escdo2DcMNauKFxL2tzCq2s/manKY6n7i15+pt4Ct7ZIO0GKoJak35bDVqwNRAlwAOSeWlApEHHaByV9Fym3XjziB7f3rfEPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0yB3CWTwn7miff6WKQfg4NNooeTmqdpZdK27Pwgqt2w=; b=HXda+t1UfT7TSW68zIBxUAq3POIlPgNSvTt+8Ax2ZjUU54npF2hXP0OJY0rDisculUvKouqrhgbdg0KxXzV8EKtwuAnd77Szi4kcxufa8IA8v5C/pkWb9yfhllDgbScIuoIDD/fZStK7ZMrxS2PsceD3rX+A64FDWYO+oZdQ5lXma6h677NJC+X7119y4KURaDbV4Q09LB7da3lKXWK7qw+7sVawd9kc4R5hSWSyaggY4jlD6bcw3eHP01b3uqzXDMxKhR2VqFuzHIK0rvS4q6LNqTP+2YNNhFQ1hm0g3AboEm0XpHYZ1TxWO0gbMekhUxUhm9V4E/uBOJ4kqdKUEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yB3CWTwn7miff6WKQfg4NNooeTmqdpZdK27Pwgqt2w=; b=FzdF/Q/t2OlSl+3srr0zS0sBFqKlRU/0mGd+1JDx4lvKMFFbvlz4OVUChOEetIEBXnV6PqkKe5omzm4brlTA2hM5eTvn7ZVRm8OdJhUxQEwU2+HHI1MaSjlupuE8HlXDvKYYkEuP6TcET6ChySQWodIy47/sNzcBV+nUabLTQmM= From: Pau Ruiz Safont To: "xen-devel@lists.xenproject.org" , =?utf-8?B?WGlodWFuIFlhbmcg77yI5p2o5Zac5qyi77yJ?= , =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , Edwin Torok , "samuel.verschelde@vates.fr" , "yann.dirson@vates.fr" , Anthony Perard Subject: Notes about "A common codebase for guest utilities, defined and shared with Xen downstreams" Thread-Topic: Notes about "A common codebase for guest utilities, defined and shared with Xen downstreams" Thread-Index: AQHYznooQP0DCtQ2a0Sdfczhui1HGK3remkA Date: Thu, 22 Sep 2022 14:00:34 +0000 Message-ID: <81b18e59-8fcf-6c69-eafc-74947ca00522@citrix.com> References: <067a94bc-b167-02c1-c654-27f2903f42c4@citrix.com> In-Reply-To: <067a94bc-b167-02c1-c654-27f2903f42c4@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4138:EE_|CH0PR03MB6129:EE_ x-ms-office365-filtering-correlation-id: c364120f-35b0-4fde-1141-08da9ca2d219 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: biy6e4NMD43i9HWSJW1MNNbwc8M9QExNpZqvF2UTHVzpvkegQWMA6uGdQqNHEKRmYlwi472HeCG5Bm0k2o5Sh1Zj+rLE0S7ibIGjxabWFiJpkCnvrF57HPWTeZOUGukWKlC9Ixzzx/a5oRPoc4dnxrBHiABGiPWQYF+70Wy4AlNJLru2RNUZKKwvdkfQY84fYo+ZfaUeGssSxzFy15kj/Y3BBwWZdGWIIEDwFmI5LMeiV8Z9Tb+/w/4Blkb4KpHZ2T9uK+A9nLmjM9qg0AHeAHVV+vOOEv0z+BqXSM10sD4WX4kV3OjH2eqpY60n2cPmtZ04cgy/70CE4FR7Ir76kBDpTGx3XixwuuPQ4bOm9UeoHVMSE49jyI0yAgm5S5BiilzZk2jrbYncDL2FX4bm3tub98NepxuYM5TjjJQmMATs5AmLUSOdEGPPKxaaKPaln8YEXXo6bz1Wt78vV8EqcPJNZeloKRBvooh2R7pTY4iloN9J/VJ789wGBweO1iZfx484I9n5myyV3oejDBhSnNSoq4lmed0x91mWuvsBBrzeEjjJf01cl2nVQqFA67zcywxXAye59XiDFgY/xVXCjpWWfOHOR8X2wapmUMx+fxgD5VHDWCCvb4MMu6S784ZIIKxlvpBxX7XpBIAodWELHODto4C0V3llePk0nK2/2k7RqEOMlpjC+/HYXchQwd1XtPlwP07E3aStVBxrGUnC8+DquN2q4LgnZobXa9aI/uxqrmCJEF5dRtyCG8c+j4aloMVg7uf6HbRz0QxjTtdpUWnsXsIY6cgPJ71cNCXat1xZWtZfvnu7lG59+isPo7DiXThnU2K24RSYFqCp5IjkRYGFIraJTErBMFLpgSAu4h8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4138.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(366004)(136003)(451199015)(83380400001)(2616005)(8676002)(31686004)(186003)(71200400001)(966005)(6506007)(91956017)(6512007)(316002)(86362001)(36756003)(31696002)(6486002)(5660300002)(26005)(66446008)(64756008)(122000001)(38100700002)(76116006)(82960400001)(66556008)(66476007)(2906002)(66946007)(110136005)(6636002)(41300700001)(8936002)(478600001)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U0swYy9pNSsxTkhTYWVvY0dYRnUrbmhWY2hab2w5UzYvSnpSR0M2eERmR2hq?= =?utf-8?B?UHR0TkhkRFBTRkYvUjQzdU1VQTJ0Sk1WQmIvU200NkJPSEQ2eERtaG0zN3Uv?= =?utf-8?B?ZURTU2ZQcnZiemI5bVpoTUthcmdJRVZKMk9SelRRSFBjWkVRTWNTempabWdC?= =?utf-8?B?WEk0NzJsVWFrQmp0OXlidi8rV0hrWmtSdUJsclRxTFhqUVlINkpOUTJQNUp3?= =?utf-8?B?ekZNcFN3dXpnOFBuU2pjY2pXZlhudU95UVppbWhGYnhRQ0xROWZQNFJiTzQr?= =?utf-8?B?Rk1ldWZtbGZsUmI1bUNESG5kTUNWb1dpVnB4am5FMjVtZFVmL1k3bEJyRXla?= =?utf-8?B?YWFBQ3RQMmttdnFGeWxucDFjcHJ4M0dCeUlGMnQxMFRyU0FXSkcrQ2JWeHhj?= =?utf-8?B?WnBMQ1hqUmxiNUsxRDR6RTV0NVc2T09md3YwUytZRG1VUlZrYVBIdnNpNVUw?= =?utf-8?B?cXliMUEzZFNYZEYwT2Z2K1BsR2tWNVR1Sk42dlZzNDNXYWJYU0xpd2xQU05U?= =?utf-8?B?K3N1Z2t5cDhlY2lkZEJZTjdtTFFjak5rWCtRdVN3V1NyN2ZodGMzSXJKYTU1?= =?utf-8?B?UHF5cXNUZ1NtUmd3ZzlQbnpJTnR3Q3ZKYk10ZS9wSVcrVmFyQW9BYWhTTnhz?= =?utf-8?B?d2ZnbmNQcEhyQUkwaExmTy9RY25CK1hmd2cyUEdzaWo0SzFyT2FPbHFzVjVK?= =?utf-8?B?MkVJN0tJQWc3ekVjN0FMOFdxQS9QV2ZZMDN4MmdRa0cvcFhJMnZweEFUOUNW?= =?utf-8?B?bXY2a3k5TGwxdElCaXhTUU4rajZZalNMeHo0QlB4dmxhNFowaFlIUGJuNU05?= =?utf-8?B?UkZhV3VTbjdScE9rNTBTY2twNXpSSjdSZ0Z2L1BBUnI4TWJsRjRWY3FFNnE4?= =?utf-8?B?L1U4Um5HdWlEazZ0L3FHMjcyQmZycGt4OEFNTnp0akZvNkFXcFFpbkFud2M5?= =?utf-8?B?b0NuMjFnTWRZdEVRNGZmYUhLcTdZU2lUQmErSWVEb2szRjVWUnlhelQyQVhG?= =?utf-8?B?RHg3TTEwbzlrU3pLZFhxWlFCbCtnZ0ZqbS8rZXRyQjlqRWRSVkpwTWxCTHA1?= =?utf-8?B?YnEydFQ1RW9JTUtoZG1FKzcrRW9qZ0F6b04xRmVFSmZndHdCUEp5VDkyQUNk?= =?utf-8?B?NFRMYnlZbzkvbE5oUDVBbzJKQ1AyaXdNRERrcjl2Qk1ZUldwY3p0RU83SDhZ?= =?utf-8?B?YVY4MFI1aVNYSmxmTEgwYlhzb0o0S2cxTFc5RXExb3lvUUhaNndCUjZYUFcv?= =?utf-8?B?ZVFpKzA2cDVRVVRXVUhOWk44TDJtUWhuQ2VuVGk2akE2UzNIV2FNaEwzcUJR?= =?utf-8?B?NndwWURUMllieDU1eXBXQjhjZkVMZGgyNVVQK2VDeXNOK0J1Q0Nqb0J1cVBD?= =?utf-8?B?ekZKRDk0TEo2NTdGWHM0Zk91UGk5M1Y4dDFQWkFJTkcwWjNGVG5VVkhNMDMv?= =?utf-8?B?YU5Sb2RWUG1JckxTT3JpWFUzaGl0QXM0SkhOR1Z4a1lPWklTTlRreXptRFk0?= =?utf-8?B?aFRwdTBLajIzVUxUZ1hxeU9VUDBCOHZ4djgzRUFPMFhVaExGOU5LYnpEQTBw?= =?utf-8?B?eisvTjFSLzRVK2lBNlRIem5SWUt2OUhSY3kvQmJnUXpsT25yYmhPZGhabkg5?= =?utf-8?B?M1NqVEtzVk9DMGRZUStnRW5HMzlyQjJ4b2tuK1VEeU1VbFN5NHBPeWZ3WlRV?= =?utf-8?B?cUxqcmFuQ1d3YlpybTB1dHpRQmsvNWZsai93ZTlXUDlUMCtJbi9SWFZLWVdJ?= =?utf-8?B?VHlwV3BScXNhNEpydXpRRGNCSXVQVllZSGduUDhPTndJVGNhNXNhNkJyVjBZ?= =?utf-8?B?Z0ViOUp1UUZNVXA5ekMzWGljOUJBSjBWOGNWOGlMajIwWU9TK3JMRVRYajMw?= =?utf-8?B?YkJBOEpNaGt3TTQ3b3VGWU1pcDlEbVp5ZGppYkg1MjQzOWs4SFMzNzVnMWNY?= =?utf-8?B?R1Q1MUx1bjRyL0Y4SUVNaUlubDlScnNlT0tvYmVTTDNoR09EMnM2ZUZEcy9D?= =?utf-8?B?aUpscXAxdDNtMWt3cUEyS0daRWNSaGE2YTE3MmxYUWg1d3piRlEvSTlkWmdI?= =?utf-8?B?K1dJOFMzdWMwbTZQa2hTaXlLdG9uRTBJdDMxWENrUFo3MHlRdnB2b2czOGUy?= =?utf-8?Q?BcM8fMyI+aiR0zpu+2KC0WgKO?= Content-Type: text/plain; charset="utf-8" Content-ID: <300F402B93D6F44F99CC334A699CCCA4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4138.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c364120f-35b0-4fde-1141-08da9ca2d219 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 14:00:34.9370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vNTF52J2kDfsBGos1KqoohUdPzbSfFbdtE81nVsv4bIENyiDN24xme7dM5+wS29XKVwF/UEqMSTu+veTY0/mBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6129 c2E6IFNhbXVlbA0KZWQ6IEVkd2luDQp4aTogWGlodWFuDQphbjogQW50aG9ueQ0KeWE6IFlhbm4N CnBhOiBQYXUNCg0KDQpzYTogYWdlbnQgcnVubmluZyBpbiBhIHZtIGNvbW11bmljYXRpb24gd2l0 aCB0aGUgaG9zdCB2aWEgeGVuc3RvcmUsIA0KdGhlcmUncyBubyBjb21tb24gY29kZSBiZXR3ZWVu IHZlbmRvcnMuDQpsaW51eCB2ZW5kb3JzIGRvIG5vdCBrbm93IHdoYXQgdmVyc2lvbiB0byBwYWNr YWdlLg0KDQp3ZSB0ZWxsIGN1c3RvbWVycyB0byBkb3dubG9hZCB0aGUgY2l0cml4IHRvb2xzLg0K DQpjdXJyZW50IGltcGxlbWVudGF0aW9uIGluIGdvDQoNCkZyZWVic2QgZGlkbid0IHBhY2thZ2Ug dGhlbQ0KDQplZDogd2hhdCdzIHRoZSBtaW5pbWFsIGZlYXR1cmVzIHRoYXQgYXJlIG5lZWRlZD8g QW5kIHdoYXQgYXJlIHRoZSBhZGRlZCANCmZlYXR1cmVzIHRoYXQgYXJlIG5lZWRlZD8NCg0KeWE6 IHN1c3BlbmQgcmVzdW1lIGhhbmRsZWQgYnkgdGhlIGd1ZXN0IGtlcm5lbA0KDQpxdWJlcyBoYXZl IHRoZWlyIG93biBpbmZyYXN0cnVjdHVyZQ0KDQpzYTogdGhlcmUncyBhbiBlbXB0eSBnaXQgcmVw byBsaXN0aW5nIGZlYXR1cmVzIGluIA0KaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3hl bi1ndWVzdC1hZ2VudA0KVGhlcmUgYXJlIGRpZmZlcmVuY2VzIGJldHdlZW4gdGhlIG1ldHJpY3Mg aW4gcXViZXMgYW5kIHhlbnNlcnZlcg0KDQp5YTogaW5zdGVhZCBvZiBwdXNoaW5nIGluZm9ybWF0 aW9uLCBvbmx5IHB1Ymxpc2ggdGhlIGluZm8gdG8geGVuc3RvcmUgb24gDQpkZW1hbmQuDQoNCkRp ZmZlcmVudCBhZ2VudHMgcmVwb3J0IHRoZSBtZW1vcnkgc3RhdHMgaW4gZGlmZmVyZW50IHhlbnN0 b3JlIGxvY2F0aW9ucw0KDQplZDogYWZ0ZXIgcmVzdW1pbmcsIHRoZSBndWVzdCBhZ2VudCByZWZy ZXNoZXMgeGVuc3RvcmUga2V5cywgY291bGQgYmUgDQpkb25lIGJ5IHVkZXYNCg0KeWE6IGdvIGFn ZW50IGRvbid0IGRvIGl0LCBtYXliZSBrZXJuZWwgZHJpdmVycyBkbw0KDQplZDogdGhlcmUncyBh IGNvbW1pdCBmcm9tIDIwMTYgZml4aW5nIGl0DQoNCmN1cnJlbnRseSB3ZSBoYXZlIHRvIHN1cHBv cnQgY3VycmVudCBwcm90b2NvbCwgYW5kIHRoZSBjdXJyZW50IHByb3RvY29sLg0KDQpTaWduYWwg dGhyb3VnaCB4ZW5zdG9yZSwgdXNlIGEgbmV3IGludGVyZmFjZSBpbnN0ZWFkLiBUaGUgbmV3IGlu dGVyZmFjZSANCndhcyBwcm9wb3NlZCB5ZWFycyBhZ28sIHRvIGV4cG9zZSBtZXRyaWNzIGZyb20g dGhlIGd1ZXN0cywgZGlkIGl0IGdldCANCmltcGxlbWVudGVkPw0KDQp5YTogYSBtb3JlIGVmZmlj aWVudCB4ZW5zdG9yZT8NCg0KZWQ6IGlzIGl0IGV2ZW4gdGhlIGNvcnJlY3QgaW50ZXJmYWNlPyBi dXQgdGhlcmUgYXJlIHRvbyBtYW55IGd1ZXN0cyANCnVzaW5nIGl0IHRvIHJlbW92ZSBpdC4NCg0K c2E6IG1heWJlIGd1ZXN0cyBjb3VsZCByZWx5IG9uIHhlbnN0b3JlJ3MgcGFja2FnZSBmcm9tIHRo ZSBkaXN0cmlidXRpb24/DQoNCmVkOiB0aGUgYWdlbnQgcHJvYmFibHkgbmVlZCByb290IGFjY2Vz cywgY3VycmVudGx5IGdvIGFnZW50IHJlaW1wbGVtZW50cyANCnhlbnN0b3JlLCBidXQgaXQncyBp bmNvbXBhdGlibGUgd2l0aCBkaXN0cm8ncyBwYWNrYWdlDQoNCmlmIHRoZXJlJ3MgYWxyZWFkeSBh IHhlbnN0b3JlIGxpYnJhcnkgYXZhaWxhYmxlLCB0aGUgYWdlbnQgc2hvdWxkIGp1c3QgDQp1c2Ug dGhhdA0KDQpzYTogdGhlIGluaXRpYWwgY29yZW9zIGlzc3VlcyBtYXkgbm90IHN0aWxsIGhvbGQs IHRoZXJlJ3Mgbm93IGZlZG9yYSBjb3Jlb3MNCg0KUG9DIHdhcyB0YXNrZWQgdG8gWWFubiB0byBn ZmV0Y2ggdGhlIElQIGFkZHJlc3MgYW5kIG90aGVyIGVhc3kgbWV0cmljcywgDQp3ZSB3aWxsIHNo YXJlIG9uY2Ugd2UgaGF2ZSBhIG1pbmltYWwgc2V0IG9mIGZlYXR1cmUgdG8gZ2F0aGVyIGZlZWRi YWNrLg0KDQplZDogYXJlIHlvdSB1c2luZyB0aGUgZGlzdHJvIHBhY2thZ2VzIGZvciB4ZW5zdG9y ZT8NCg0Kc2E6IGlmIGl0J3MgYXZhaWxhYmxlIHllcywgYW5kIG90aGVyd2lzZSB3ZSBtYWtlIHRo ZSBwYWNrYWdlIG91cnNlbGZ2ZXMuIA0KT24gZ2l0bGFiIHdlIHdvbid0IGluY2x1ZGUgdGhpcyBw YWNrYWdlcywgb25seSB0aGUgYWdlbnQgY29kZS4NCg0KZWQ6IHRoZSBvbmUgaW5zdGFsbGVkIGlu IGRvbTAgaGFzIGRpZmZlcmVudCBwYXJhbWV0ZXJzIGZyb20gdGhlIG9uZXMgaW4gDQp0aGUgZ3Vl c3RzLCBpdCdzIHByb2JhYmx5IG5vdCBpbnRlbnRpb25hbA0KDQpzYTogd2UnbGwgbWFrZSB0aGVt IGNvbXBhdGlibGUgd2l0aCB0aGUgdXBzdHJlYW0gcHJvdmlkZWQNCg0Kd2h5IGNyZWF0ZSBhIG5l dyBwcm9qZWN0PyBkbyBub3QgZGVwZW5kIG9uIHhlbnNlcnZlciwgYnV0IGJlIGluIHhlbiBzbyAN CmRpc3RybyBwYWNrYWdlcnMga25vdyB0byB0YWtlIHRoYXQgY29kZSB0byBidWlsZCBwYWNrYWdl cy4gV2UgbXVzdCByZWFjaCANCnF1YmVzIHRvIGZvbGxvdyB0aGlzLCBhcyB3ZWxsIGFzIEFtYXpv biwgbWF5YmUgb3RoZXIgZG93bnN0cmVhbXM/DQoNCnJlYWRpbmcgL2V0Yy9yZWxlYXNlIHdhcyBt YWpvciBpbXByb3ZlbWVudCB0aGF0IHVzZXJzIGNvbnRyaWJ1dGVkLCBiYXNlZCANCm9uIGEgZGVz aWduIHdlIHdyb3RlDQoNCmRpc3RybyBkZXRlY3Rpb24gdG9vbCBjYW4gbWFzc2l2ZWx5IHNpbXBs aWZ5DQoNCmVkOiB3aGF0IGFib3V0IGJzZD8gaXMgdGhlcmUgYW55IGludGVyZXN0Pw0KDQpzYTog d2UgZG9uJ3QgcHJvdmlkZSBwYWNrYWdlIHRoYXQgY2FuIGJlIGluc3RhbGxlZCwgaW5zdGVhZCBp dCB3aWxsIA0KZmV0Y2ggdXNlci1jb250cmlidXRlZCByZXBvcyB0aGF0IGhhdmUgYW4gb2xkIHZl cnNpb24gdGhhdCB3b3Jrcw0KDQplZDogYXZvaWRpbmcgbGludXgtc3BlY2lmaWMgZGVwZW5kZW5j aWVzIHdvdWxkIGJlIGdvb2QuDQoNCnhpOiB0aGUgcmVwbyBpcyBlbXB0eQ0KDQpzYTogdGhlIHJl cG8gd2lsbCBiZSBlbXB0eSB1bnRpbCB3ZSBoYXZlIGEgcHJvb2Ygb2YgY29uY2VwdCB2YXRlcyBj YW4gc2hhcmUNCg0KZWQ6IGRvZXMgdGhpcyBuZWVkIHRvIGJlIGFuIHJwbT8gQSBsb3Qgb2YgY29t cGxleGl0eSBpbiBDaXRyaXggaXMgaW4gdGhlIA0KcGlwZWxpbmUNCg0Kc2E6IGl0IG1heSBiZSBh IG5vYXJjaCBycG0sIHdpdGhvdXQgYnVpbGRpbmcgYW55dGhpbmcNCg0KZWQ6IGlmIHRoZSBycG1z IG5lZWQgdG8gYmUgYnVpbGQgZm9yIGd1ZXN0IGlzIHZlcnkgY29tcGxleA0KDQpzYTogaG93IHRv IHByb3ZpZGUgcGFja2FnZXMgZm9yIGRpc3Ryb3MgdGhhdCBkb24ndCBwcm92aWRlIHRoZW0uIElu IG91ciANCmJidWlsZCBzeXN0ZW0gdGhlcmUncyBibGFjayBtYWdpYy4gSW4ga29qaSB0aGUgZ28g cHJvZ3JhbSBpcyBkb25lLCB0aGVuIA0KYnVpbGQgdGhlIHJwbSBhbmQgdGFyLmd6IGlzIGJ1aWx0 LCBiZWNhdXNlIGl0J3Mgc3RhdGljYWxseSBsaW5rZWQNCg0KZWQ6IHdpdGhvdXQgYmluYXJpZXMg d291bGQgYmUgZXZlbiBzaW1wbGVyDQoNCnlhOiBkZXBlbmRpbmcgb24gZGlzdHJvIHRoZSBjb25m aWcgZmlsZXMgYXJlIG9uIGRpZmZlcmVudCBwbGFjZXMNCg0Kc2E6IGxvY2F0aW9uIHNob3VsZCBi ZSBkZWZpbmVkIGluIHRoZSBwYWNrYWdlIG1ldGFkYXRhLCBub3QgaW4gdGhlIHVzZXIgDQpyZXBv IGJ1aWxkDQp1cHN0cmVhbSBkaXN0cm9zIHNob3VsZCBidWlsZCBtb3N0IG9mIHRoZSBwYWNrYWdl cw0KDQp3ZSBidWlsZCBvbmx5IGZvciBzb21lIGRpc3RyaWJ1dGlvbnMgd2hpY2ggZG9uJ3QgcmVs ZWFzZSB0aGUgdXAtdG8tZGF0ZSANCmd1ZXN0IHV0aWxzDQoNCndlIG9mZmVyIHVzZXJzIGluIG91 ciB3ZWJwYWdlIHRoZSBvcHRpb24gdG8gcGljaw0KDQpwYTogd2hhdCBsYW5ndWFnZSBpcyB0aGUg UG9DPw0KDQp5YTogd2UgaGF2ZW4ndCBzdGFydGVkIQ0KDQpzYTogd2UncmUgdHJ5aW5nIHRvIHVz ZSB3aXRob3V0IGFueSBsYW5ndWFnZXMsIHVzaW5nIHVkZXYuIFdlIGhhdmVuJ3QgDQpkaXNjdXNz ZWQgd2hhdCBsYW5ndWFnZSB3b3VsZCBiZSBhcHByb3ByaWF0ZQ0KRm9yIGxpbnV4IGl0IHNob3Vs ZCBiZSB2ZXJ5IHNpbXBsZSB0byBidWlsZA0KU3RhdGljIGxpbmtpbmcgaXMgdmVyeSBjb252ZW5p ZW50IGZvciB2YXRlcw0KDQpwYTogdGhlcmUncyBhbiBvY2FtbCBwcm9qZWN0IHVzaW5nIGNvc21v cG9saXRhbiBsaWJjIGFsbG93cyB0byBydW4gDQpzdGF0aWMgYmluYXJpZXMgb24gd2luZG93cywg bGludXggYW5kIGZyZWVic2QNCg0KeWE6IHNlZW1zIHZlcnkgc3BlY2lmaWMsIHJ1bnMgcmlzayBv ZiBub3QgYmVpbmcgYWNjZXB0ZWQsIGl0IHNob3VsZCBiZSANCnNpbXBsZSB0byBjb2RlDQoNCmFu OiBjb21wYXRpYmlsaXR5IGluIHB5dGhvbiBpcyBub3QgZ29vZA0KDQpzYTogbm90IGFsbCBkaXN0 cm9zIHdpbGwgaGF2ZSBweXRob24NCg0KZWQ6IG1heWJlIGEga2VybmVsIGRyaXZlcj8NCg0KcGE6 IGl0J3MgbGludXgtc3BlY2lmaWMsIHRob3VnaA0KDQplZDogd2hhdCBkbyBvdGhlciBoeXBlcnZp c29yIGRvPyBrdm0gYWdlbnRzPyBxZW11IGFnZW50Pw0KDQphbjogbmV2ZXIgc2VlbiBhIHFlbXUg YWdlbnQNCg0KeWE6IHRoZXJlJ3MgYSBoZWxwZXIgZm9yIGJldHRlciBtb3VzZSBpbnRlcmFjdGlv biB0aHJvdWdoIHFlbXUNCg0KZWQ6IHdoYXQgbGFuZ3VhZ2UsIGhvdyBhcmUgdGhleSBkaXN0cmli dXRlZD8NCg0KYW46IG1heWJlIHRoZSBzb3VyY2UgaXMgaW4gcWVtdQ0KDQp5YTogdGhlcmUgbWF5 IGJlIGEgZHJpdmVyIGlzbywgY2FuJ3QgcmVtZW1iZXINCg0KYW46IGh0dHBzOi8vd3d3LnFlbXUu b3JnL2RvY3MvbWFzdGVyL2ludGVyb3AvcWVtdS1nYS5odG1sDQoNCnNhOiBjb3B5IGFuZCBwYXN0 ZS4uLiBzdXJwcmlzaW5nIHRvIHNlZSB0aGVyZSB3YXMgbm8gZWFzeSB3YXkgdG8gc2hhcmUgDQpj bGlwYm9hcmQNCg0KYW46IHhlbnNlcnZlciBoYXMNCg0Kc2E6IGJ1dCBvbmx5IGZvciB3aW5kb3dz LCB3aXRoIGEgdm5jIGNvbnNvbGUgZm9yIGxpbnV4LCB0aGVyZSdzIG5vIHN1Y2ggDQp0aGluZy4g TWF5YmUgaXQncyBlYXN5IHRvIGFjdGl2YXRlIGJ1dCB3ZSBkb24ndCBrbm93IHRoZSB3YXkNCg0K ZWQ6IHZuYyBzaG91bGQgaGF2ZSB0aGF0DQoNCihub2JvZHkgaW4gdGhlIHJvb20ga25vd3MpDQoN CnlhOiBpbiBxdWJlcyBoYXMgaXQncyBvd24gcnBjIGluZnJhc3RydWN0dXJlIHRvIGNvbnRyb2wg YWNjZXNzIHRvIA0KY2xpcGJvYXJkIGFjY2VzcyB0aHJvdWdoIHZjaGFuIFRoZXJlIGFyZSBzaG9y dGN1dHMgdG8gc2hhcmUgZ3Vlc3QgDQpjbGlwYm9hcmQgdG8gdGhlIGdsb2JhbCBvbmUgYW5kIGJh Y2sgY3RybGMgY3RybHNoaWZ0YyBldGMsIGl0J3MgYSANCnNwZWNpZmljIG1lY2hhbmlzbQ0KDQpl ZDogd2UgY291bGQgcmV1c2UgdGhhdCwgbWF5YmUNCg0KeWE6IGl0J3Mgbm90IHZlcnkgYWR2YW5j ZWQsIG9ubHkgdGV4dC4gTWF5YmUgcGF0Y2hlcyBuZWVkZWQhDQoNCnNhOiBsZXQncyB3cmFwIHVw DQoNCnRoYW5rcyBmb3Igam9pbmluZyBldmVyeWJvZHksIHdlJ2xsIHNoYXJlIHRoZSBub3Rlcw0K From xen-devel-bounces@lists.xenproject.org Fri Sep 23 06:46:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 06:46:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410591.653660 (Exim 4.92) (envelope-from ) id 1obcRY-0004oe-WC; Fri, 23 Sep 2022 06:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410591.653660; Fri, 23 Sep 2022 06:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obcRY-0004oX-Rr; Fri, 23 Sep 2022 06:45:48 +0000 Received: by outflank-mailman (input) for mailman id 410591; Fri, 23 Sep 2022 06:45:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obcRX-0004oR-Cr for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 06:45:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 589b6c21-3b0b-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 08:45:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D85861745 for ; Fri, 23 Sep 2022 06:45:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC6BCC433D7 for ; Fri, 23 Sep 2022 06:45:42 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id k10so18309611lfm.4 for ; Thu, 22 Sep 2022 23:45:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 589b6c21-3b0b-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663915542; bh=1dqZG9KYhb+QJsNASHj0txSg1wAN7+87wEVN0W2xa4o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u4aTG+IwaZFLv4dqMFB/IAkYpRnuCC8PHqngiMx8FYghze128xymvlOteCf9x7M1P UpDCGPgRbNceRJKdJptnomKSWyGfGE7LcAh2ZiJdtSuABZtlWOcX73FyToVCKV+H03 NrPHSQ1Qhiwv9LORapYBsDw0RwMaJJOwo5CEda/ypT3y/0x6qIYsndd1pYm4BuPN16 xxQ305nb9o3A7uvgRS8VtP8DbpiGJjLP9uK0FI85VrcEVBPS47yNbdZG3WakWTmJd/ 4JdblpmHM/tWEbrGfptTTBJUmPCwbOgSofUUXR2bGNu+eAuKbHmco4xYj9q1vXN9+r 8evp6LQAx2j8Q== X-Gm-Message-State: ACrzQf2ByeA92ubwVlH3WIeMvlVptRC93Uu5ly1iidlY0k6Vpa2WR+HS Bh/OtmdtKmarK3LJb3t6A5Q+wD8wsXBj1O6wGOM= X-Google-Smtp-Source: AMsMyM78S5LN/Ep/pE9ZbilPh7sjmo2qhKCGXkW0ImTuZuoSv9XDnU5+BTGcCYKD2/Iuyj6SlOcMP7957FRDWgnzsog= X-Received: by 2002:a05:6512:13a1:b0:48d:f14:9059 with SMTP id p33-20020a05651213a100b0048d0f149059mr2881953lfa.110.1663915540743; Thu, 22 Sep 2022 23:45:40 -0700 (PDT) MIME-Version: 1.0 References: <7930b617-d473-94dd-c7e4-33ffa19da13e@suse.com> <3671fd52-6034-7149-ebe4-f7560c0dc6b0@suse.com> <6f42a382-c5aa-ba16-f330-69a07476e2aa@suse.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 23 Sep 2022 08:45:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Jan Beulich , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 23 Sept 2022 at 01:27, Demi Marie Obenour wrote: > > On Fri, Sep 23, 2022 at 12:14:50AM +0200, Ard Biesheuvel wrote: > > On Thu, 22 Sept 2022 at 20:12, Demi Marie Obenour > > wrote: > > > > > > On Thu, Sep 22, 2022 at 05:05:43PM +0200, Ard Biesheuvel wrote: > > > > On Thu, 22 Sept 2022 at 16:56, Demi Marie Obenour > > > > wrote: > > > > > > > > > > On Thu, Sep 22, 2022 at 08:12:14AM +0200, Jan Beulich wrote: > > > > > > On 22.09.2022 03:09, Demi Marie Obenour wrote: > > > > > > > On Wed, Sep 21, 2022 at 10:34:04PM +0200, Jan Beulich wrote: > > > > > > >> On 20.09.2022 18:09, Ard Biesheuvel wrote: > > > > > > >>> On Tue, 20 Sept 2022 at 17:54, Jan Beulich wrote: > > > > > > >>>> > > > > > > >>>> On 20.09.2022 17:36, Ard Biesheuvel wrote: > > > > > > >>>>> On Mon, 19 Sept 2022 at 21:33, Demi Marie Obenour > > > > > > >>>>> wrote: > > > > > > >>>>>> > > > > > > >>>>>> fwupd requires access to the EFI System Resource Table (= ESRT) to > > > > > > >>>>>> discover which firmware can be updated by the OS. Curre= ntly, Linux does > > > > > > >>>>>> not expose the ESRT when running as a Xen dom0. Therefo= re, it is not > > > > > > >>>>>> possible to use fwupd in a Xen dom0, which is a serious = problem for e.g. > > > > > > >>>>>> Qubes OS. > > > > > > >>>>>> > > > > > > >>>>>> Before Xen 4.16, this was not fixable due to hypervisor = limitations. > > > > > > >>>>>> The UEFI specification requires the ESRT to be in EfiBoo= tServicesData > > > > > > >>>>>> memory, which Xen will use for whatever purposes it like= s. Therefore, > > > > > > >>>>>> Linux cannot safely access the ESRT, as Xen may have ove= rwritten it. > > > > > > >>>>>> > > > > > > >>>>>> Starting with Xen 4.17, Xen checks if the ESRT is in Efi= BootServicesData > > > > > > >>>>>> or EfiRuntimeServicesData memory. If the ESRT is in Efi= BootServicesData > > > > > > >>>>>> memory, Xen allocates some memory of type EfiRuntimeServ= icesData, copies > > > > > > >>>>>> the ESRT to it, and finally replaces the ESRT pointer wi= th a pointer to > > > > > > >>>>>> the copy. Since Xen will not clobber EfiRuntimeServices= Data memory, > > > > > > >>>>>> this ensures that the ESRT can safely be accessed by the= OS. It is safe > > > > > > >>>>>> to access the ESRT under Xen if, and only if, it is in m= emory of type > > > > > > >>>>>> EfiRuntimeServicesData. > > > > > > >>>>>> > > > > > > >>>>> > > > > > > >>>>> Thanks for the elaborate explanation. This is really help= ful. > > > > > > >>>>> > > > > > > >>>>> So here, you are explaining that the only way for Xen to = prevent > > > > > > >>>>> itself from potentially clobbering the ESRT is by creatin= g a > > > > > > >>>>> completely new allocation? > > > > > > >>>> > > > > > > >>>> There are surely other ways, e.g. preserving BootServices*= regions > > > > > > >>>> alongside RuntimeServices* ones. But as the maintainer of = the EFI > > > > > > >>>> code in Xen I don't view this as a reasonable approach. > > > > > > >>> > > > > > > >>> Why not? > > > > > > >> > > > > > > >> Because it's against the intentions the EFI has (or at least= had) > > > > > > >> for this memory type. Much more than EfiAcpiReclaimMemory th= is > > > > > > >> type is intended for use as ordinary RAM post-boot. > > > > > > > > > > > > > > What about giving that memory to dom0? dom0=E2=80=99s balloo= n driver will give > > > > > > > anything dom0 doesn=E2=80=99t wind up using back to Xen. > > > > > > > > > > > > While perhaps in principle possible, this would require special= casing > > > > > > in Xen. Except for the memory the initrd comes in, we don't dir= ectly > > > > > > hand memory to Dom0. Instead everything goes through the page a= llocator > > > > > > first. Plus if we really were convinced boot services memory ne= eded > > > > > > retaining, then it would also need retaining across kexec (and = hence > > > > > > shouldn't be left to Dom0 to decide what to do with it). > > > > > > > > > > So how should dom0 handle the various EFI tables other than the E= SRT? > > > > > Right now most uses of these tables in Linux are not guarded by a= ny > > > > > checks for efi_enabled(EFI_MEMMAP) or similar. If some of them a= re in > > > > > EfiBootServicesData memory, they might be corrupted before Linux = gets > > > > > them. > > > > > > > > Yes, this is an annoying oversight of the EFI design: the config > > > > tables are tuples, and the size of the table is > > > > specific to each table type. So without knowing the GUID, there is = no > > > > way you can reserve the right size. > > > > > > > > Perhaps you could implement something like a hypercall in > > > > efi_arch_mem_reserve(), which is called by the EFI code to reserve > > > > regions that are in boot services memory but need to remain reserve= d? > > > > This is used for all config tables that it knows or cares about. > > > > > > On versions of Xen that support spawning multiple domains at boot > > > (instead of just dom0) this will be racy. What about refusing to use > > > tables in EfiBootServicesData when running under Xen unless a hyperca= ll > > > indicates that Xen has reserved all EfiBootServicesData memory? Wher= e > > > could such a check be placed? > > > > You could stick a check inside the for loop in > > efi_config_parse_tables() to cross reference every table address > > against the memory map when running on Xen, and disregard it if it > > doesn't meet your criteria. > > > > I take it the issue is not limited to x86? > > Indeed the issue is cross-platform. For Qubes OS, I wonder if a safer > approach would be to reserve all EfiBootServicesData memory by default. You only need to reserve the ones that have configuration tables pointing into them. From xen-devel-bounces@lists.xenproject.org Fri Sep 23 07:12:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 07:12:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410596.653671 (Exim 4.92) (envelope-from ) id 1obcrX-0008Pf-2K; Fri, 23 Sep 2022 07:12:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410596.653671; Fri, 23 Sep 2022 07:12:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obcrW-0008PY-Uu; Fri, 23 Sep 2022 07:12:38 +0000 Received: by outflank-mailman (input) for mailman id 410596; Fri, 23 Sep 2022 07:12:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obcrW-0008PO-5W; Fri, 23 Sep 2022 07:12:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obcrW-0003SD-2m; Fri, 23 Sep 2022 07:12:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obcrV-0004Eu-M9; Fri, 23 Sep 2022 07:12:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obcrV-0007wl-Li; Fri, 23 Sep 2022 07:12:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jHUmIKf/1E/lf+XHE5sLS3ZFGrPVNZQ+L9NWFujD3kU=; b=vVTrbK5D0jsknfWH1u7y7G4HeP qdkyyzSS8g540WhQyKKtZ1QzF9+QCDtlWICy0jYwF5QxjHQvsN4KcDMZJEkN6uyoySnbwoDdcSR2f M2XOY1PZyGH+bPs/JyiBzo+VJ42sw4HxnYiblFDl2i/0ryII+NV8PB/honcBXhDV3mqg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173283: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=bf682942cd26ce9cd5e87f73ae099b383041e782 X-Osstest-Versions-That: linux=c69cf88cda5faca0e411babb67ac0d8bfd8b4646 From: osstest service owner Date: Fri, 23 Sep 2022 07:12:37 +0000 flight 173283 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173283/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 173279 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173279 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173279 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173279 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173279 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173279 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173279 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173279 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173279 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux bf682942cd26ce9cd5e87f73ae099b383041e782 baseline version: linux c69cf88cda5faca0e411babb67ac0d8bfd8b4646 Last test of basis 173279 2022-09-22 18:41:27 Z 0 days Testing same since 173283 2022-09-23 01:11:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chao Yu David Rientjes Feng Tang Letu Ren Linus Torvalds Martin K. Petersen Maurizio Lombardi Peter Collingbourne Rafael Mendonca Saurav Kashyap Sreekanth Reddy Vlastimil Babka Wende Tan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git c69cf88cda5f..bf682942cd26 bf682942cd26ce9cd5e87f73ae099b383041e782 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Sep 23 07:21:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 07:21:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410603.653682 (Exim 4.92) (envelope-from ) id 1obczn-0001c4-TO; Fri, 23 Sep 2022 07:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410603.653682; Fri, 23 Sep 2022 07:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obczn-0001bx-Qf; Fri, 23 Sep 2022 07:21:11 +0000 Received: by outflank-mailman (input) for mailman id 410603; Fri, 23 Sep 2022 07:21:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obczm-0001bn-9t; Fri, 23 Sep 2022 07:21:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obczm-0003fA-24; Fri, 23 Sep 2022 07:21:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obczl-0004ZC-Oc; Fri, 23 Sep 2022 07:21:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obczl-0001TC-O6; Fri, 23 Sep 2022 07:21:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=83Y1wIi2B66CTlbFo5z48wGihevd0PD/9ViA5VbGw4A=; b=dazz5XV5ghyzP1TtaqAVLbVry3 M2KiJbbYJOOcqx9bY0xBZM0JRFHXxQlx5YP9zssfRm2fCmrargP4/YaNgb+lTN7lV8YQXCiwP80X0 V7r2apU8xwAUgtOMr+Yn7IE1gH9nYLf3jfMqbHpMqG4LTVTcS5XzyKvsV0Ht3DtNv8CQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173286: all pass - PUSHED X-Osstest-Versions-This: ovmf=238f5f95448c0cbffab5532b21bc4d5f27cf1cee X-Osstest-Versions-That: ovmf=6f340acfb10992af914ed5e17127cc786e0a7f7b From: osstest service owner Date: Fri, 23 Sep 2022 07:21:09 +0000 flight 173286 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173286/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 238f5f95448c0cbffab5532b21bc4d5f27cf1cee baseline version: ovmf 6f340acfb10992af914ed5e17127cc786e0a7f7b Last test of basis 173282 2022-09-23 00:41:56 Z 0 days Testing same since 173286 2022-09-23 02:58:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Nickle Wang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6f340acfb1..238f5f9544 238f5f95448c0cbffab5532b21bc4d5f27cf1cee -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 07:21:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 07:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410610.653692 (Exim 4.92) (envelope-from ) id 1obd0J-0002Ae-AG; Fri, 23 Sep 2022 07:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410610.653692; Fri, 23 Sep 2022 07:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obd0J-0002AX-7b; Fri, 23 Sep 2022 07:21:43 +0000 Received: by outflank-mailman (input) for mailman id 410610; Fri, 23 Sep 2022 07:21:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obd0I-00029y-4H for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 07:21:42 +0000 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a9a7056-3b10-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 09:21:37 +0200 (CEST) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 00:21:34 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 23 Sep 2022 00:21:33 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 00:21:33 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 00:21:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 23 Sep 2022 00:21:33 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 23 Sep 2022 00:21:32 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by MW3PR11MB4619.namprd11.prod.outlook.com (2603:10b6:303:5b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 07:21:05 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::a435:3eff:aa83:73d7]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::a435:3eff:aa83:73d7%6]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 07:21:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a9a7056-3b10-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663917698; x=1695453698; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Bj80AYRRNEOWdMv2f+ZnFW1gv/B54IFr4mvLYGnfNNo=; b=IckNBXxAJp8Oo0e4R+AYstj33NGc5UHxnQ4ldPZnLSiuhW0zk09wAqWN zEndzVbHMIWT+JXIDUUstz3MqOJ39Z4LVeRIrZ1EK3aVCfSq9Q4ykjj3v WQ1elP/SiwK0EKD3FuJqRNSwRCnQm6Wolb2f118KeERr/Koz3WLgmXTsw ZA3CFrlxthEwoFa95FbFazPZcLZDJdtJajd3H4cgBApQ/3xWpG09IHRbk PSGKdLkrXSc+dNqmZoUVD+kP72gPJa5hPaRkdDpfjISXteuT5YZr55K+m u/Az4drcWSgkYAjL8p8JFwkmOcOQ6VT3MITr6bHPcy546ZLRkulykBsSC g==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="301976196" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="301976196" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="597776750" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KwKHoO2Mlt3yCb5nVvkb6F+PsfT+rQtXotXDEnKa3AbTQhTrB3tZbQC0Ntc8kVz03q0PZ8HkLI9qFfR+Em/bq/KavKPoOjeRS5/UO1OF6XZLkZiqYss6/eRyhOyYfFF1o18hnbdeZxfo2Vwtc2BNX3xPqpQp/7FfV3m2d3QmRW/1JSQO0RiFtt/eOeSHdRinv9AzsCSTlK9wJRJ8ucRKfwwXN5uTrdqTDaaO6U/7tZq8RIjZGZK1Z3TmTkRoE7LA4VEcNq29QWay/7vwKsPUzL+O8RfPiRclT71U6YASTeBE7j7rfbJJ+YBpM4S9vW2rVFLUhrGp/qpv+uZiAlEV1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bj80AYRRNEOWdMv2f+ZnFW1gv/B54IFr4mvLYGnfNNo=; b=epLPZvFYAJ4b2oufY9PkwYrXl/7+1/xwdq1x8BEq5Jc6Lxn6U39dl6+v4GEfI1ln7y1pVRrZECm2dMIpxjXK5UD4HAbChgwGvpV7CfcwZQVUT01560EOQ7wyYiH3ykxOBooHKPi3PBfgVxKBq3Sys8U95FC5ICktoYAC3Ed+wkwcg/k/TtwdtaV6UG3IOclExHVX3cd/i+XXpgrk99H4IP88F5i25Tle9IjXFMcav4kvyOjJR6/CapBM7DaY6Jgm2ADpc76nFnBJfGdPXw+ffQNeXoSnkpDO/YIR2xSwlzKiPvyjw53siEn/U8WsOywTnlcJbhlQp16TdYeBiWFhIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Marczykowski, Marek" , "xen-devel@lists.xenproject.org" CC: "Marczykowski, Marek" Subject: RE: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Thread-Topic: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Thread-Index: AQHYykB/Pv1Ek/NIGEWzHFZweNfBzq3so7bg Date: Fri, 23 Sep 2022 07:21:04 +0000 Message-ID: References: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> In-Reply-To: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|MW3PR11MB4619:EE_ x-ms-office365-filtering-correlation-id: 6b4c6116-9e36-4ec9-3173-08da9d342d29 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NafVXhkJN4fVCZcEQJjA6VrEfKetBV8KwTl+TqScPj9vB++wyWGdX2e0DzwtHVf1eFGvFqwwd5/fR/H937sSC4qzeZxLVBJPleaRjOVgtqogq1YQSMZpBC9EqOcP9Aa9Lhc3MnvpNi+Uh91gu/KEuWl4/Qt8n06kXEM9OHTSVS+XA/ADzYCS9ADApCdFSqoOF4TKpD0okwr4h5e83WXk4GVfexRM7s2K9qZ6wpAHOkHld9b3HjwrSQEC4m/8W9EK8UwKBkA6x9aImJaI9ZbA4FPN/JKtPpYtBTn2GF2iUBYV6YShXToHEFNzfvL1T6sp922H8rZPt4jIqjxZgdJ0gBmQketuXl7YBcHPZmVqKq8YsdmzUYMjh7/Kwe4jonhNag1IpbD3H2u61LWfn2nIDtunDfzaPY6fkQ/wZt9+f+5r36IgueZ6qzcofGqEywrGiCL0nS6nerElsGL5O5RPdKWVRN9CU8g5kqdgd6t0uN8xn9uDkfoHCLyGYzqq6isXm2c7fS068GAzlDWS3PkLZ9OQnEOBglTO9ETM4+GT/mZSjnyAHwiKRMi7iFsZbgSUTlwkc3Q+GwrwJbtZgUZBOAyZqq/CVVG/rf7xnsjXHtDBV02HlA22Wg0x0f+oby4Vq8E30QESoJXRAe1ikrZaTD+cxfmmoq1AE1FeAy11Vvu67cqbvJjj0cSUHLxYps7OpKkzH7nUxOyiNvt8apy2uAmS5MkGHqIERP3+LIitiNoEsa3jnzg/Bhs05giPoIufQ76aPGQ2e1lpwFY5RfPZng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199015)(110136005)(478600001)(316002)(71200400001)(122000001)(83380400001)(38100700002)(82960400001)(41300700001)(55016003)(7696005)(186003)(33656002)(9686003)(38070700005)(6506007)(26005)(2906002)(8676002)(52536014)(8936002)(66556008)(66476007)(64756008)(76116006)(66446008)(86362001)(4326008)(5660300002)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YlhQVC8xSjRnMm51VHV4RGVoaEVpMlp5RG16ZUNIb2FPSVZoR3JGYy9hWlQ0?= =?utf-8?B?d1htVDR0eFQzQVdSOFRSWHdIUkppRFRtbFQ0YnlodDhpZlFPckY3Ky9DbzFm?= =?utf-8?B?NW85ZXRsU3ZWU3RVSit4czVHc0VlYjhFd3kvQ2c2VGRVb203dCsrUE1rdFVw?= =?utf-8?B?TVRDcjdMMVliaEJTQ0hIN1JSOFhZMmhOSjJPWkkyblB0WGdQL3ZXdlU2YUNh?= =?utf-8?B?RCtxcmNyVm9vVTNydEp3bFRWbjRCTVVxVStFZThZZEJxWmJIbzhWeHdJaGtM?= =?utf-8?B?U3JaS2k0WGxtdGdaWU0vODVJelFaTi9qb29taEtJS1FXTnRhU0ZzTmtEQVgv?= =?utf-8?B?d3Y4cFpVUnZvU3VHeWlLdnJJd1ppSVJ3dlRQOC9mNmlFN3BHdElRM2w3Qng3?= =?utf-8?B?QmpaUjVzRG84amt0RE9BaS9oUjhQSVNZZ1ZqUHRvUXBNVkNyQkdLRXdDTDRk?= =?utf-8?B?dGRUTU1mV1h2WFl1dlZ0eEZQWkVhc3lYcmVmUnNPYzhFcGZxVjR3RzVvZ3Bu?= =?utf-8?B?MG1QTmthcG9nRzdycmFocUNPSytXcEJlcnFpMDZ4UHVSejJaTktWWUVMMkpV?= =?utf-8?B?NVZzamVWMkVvdlhkM1BrODhuZG5Qc1E0YTUxRmtFemcvRUxmWXU1NzhVYUhO?= =?utf-8?B?SWNGWThMSENic0tvLzE3QVFLaVg2NXVJMmh1K1NtU1VRYnBXRTBFZG9CMGtr?= =?utf-8?B?dFhtbERYTWF0UzQwUWNMNzVrOHZna252TkRTOVJrb29oeG5WSGZWZ3JQdzh4?= =?utf-8?B?UmVBM0tTK2sxdnRBbENZTXBZaWp4S1lWN0lNN0tyeUFLMTJsZkhlSXJSODlo?= =?utf-8?B?NUxxYlp3cFdOZlFVWlVWZlZuMllqTUhyQmJ3UTZRaVZ0enhjSU4za1U2RGdV?= =?utf-8?B?OU85V0gvR0lLMDNQQ2YrcFE1OTJ2SkZMc3NDOWNYQk15YlBhSTZPOWtmUVFw?= =?utf-8?B?M0RYamRmNFJTMFJmYWl2T1h5enA5aHF2dmpHTk9GUXFZcjhUVzhENzdRcjRk?= =?utf-8?B?N3BMcDZwUTc5MGY4MFBxYWZ4M21tVjhONmx0dCsvaUNESjNJMkRDK2dwL3ZR?= =?utf-8?B?VVRsRW0rVDVMMnJvTGtWT3lmRVRWWi9PSWp5L2NrZFZ3bDJEUE04M2ZTaWYx?= =?utf-8?B?NG1kTjROMGhyZEhaaU5iQU5qZUhmWE5Da2FDdURHUFQxc0tVb280SWE2Ui9x?= =?utf-8?B?T1ZwRnhtMTNxbzk4N0xxNVlzZkw1TS8ySUU3NzlYY01vQnFpa2VVZFprSUtD?= =?utf-8?B?WDF6endGL2h0bnZURWdFSkFuSmpFT2VLcWtOQnp6SFpjdVhpaXVUb01pWVZu?= =?utf-8?B?d0F3OVVaa0IxZjVlQ1RjLy9KVm5QM2xjdWFaVzcxeThoZXhzUVVrNEtGL2xh?= =?utf-8?B?b2lYbk1iZGhHRnZTQ241eVBwVTVJSlZQSE5Cdkl2R2V3VVZrYWl0NU1yQjZQ?= =?utf-8?B?dWVXa1RYYlViWFJPYmpRUlBycG80cERRVlh3LzExaHdWNVpZcVB1dldJY2JQ?= =?utf-8?B?RExUemo3Zk1obmdMUXkxRU0zamplbjFDdy9STnFYUUt5ZEJBT3NDZHI3blkz?= =?utf-8?B?TFVsM1dvR2NTallkRE8rWW9UU2UyNHJGQ2RPdUF5K3E2QzJXQmYyZ2NhdUht?= =?utf-8?B?L09pR0hpeTduMlExNzNMTEsyQnVnbnQ1cVRXZ2g1RDNCek9RVU9BTDV6V1Vy?= =?utf-8?B?T04vMlhWZWJFeUMySUJiOTM3V0tVL0dNT2hNVlFVMzJmV3ZVVnFRZmtKZWov?= =?utf-8?B?d0VLMGxFY09tTEpmcHluaHo1cWx0S2plbTRiQ2ZsVFkwNXZUbHo4SnJ1NWRv?= =?utf-8?B?YVdsMitVeTkxU25VeE1UZGZhVldiRWxoYlVhMjdrdjA4MEhZcFFNa1hxQUtV?= =?utf-8?B?ZmFRbWZNMmpUNXVRbHFVL1htVzBQaUsweGhJelllN0FXNEtMcndZVXZ0RFZI?= =?utf-8?B?MUk1bWl1RE5LMXFyYXYvZkRIVUZkTzU4Y29DNCtJY2NXZVorWlQ3dnVBZzMy?= =?utf-8?B?OVdDUTVsQWtDYlZGenkyTnRvVkhaeUE2cXhMbjVPbys3OHJubDVsa1FIR3lE?= =?utf-8?B?ZTg5cE9JbytFN2Q5YnBOcWZLMS9oMHpyL3I5YWQxcDNFZnhPd0VTNXFFTW04?= =?utf-8?Q?X/EoTJ80dLAIl/4Qn5SUJD+i2?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b4c6116-9e36-4ec9-3173-08da9d342d29 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 07:21:04.7724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LakxsItTN2ABIeaVWMpwpxoLMPDEn4IpwO1JvTqIj7Usx9ZD/TCpm1S49dyCfcrIwJgjpZp+jcJiTapnNFQ0EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4619 X-OriginatorOrg: intel.com PiBGcm9tOiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kNCj4gU2VudDogU2F0dXJkYXksIFNl cHRlbWJlciAxNywgMjAyMiAxMDo1MSBBTQ0KPiANCj4gUmUtdXNlIHJtcnI9IHBhcmFtZXRlciBo YW5kbGluZyBjb2RlIHRvIGhhbmRsZSBjb21tb24gZGV2aWNlIHJlc2VydmVkDQo+IG1lbW9yeS4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraQ0KPiA8bWFy bWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCj4gLS0tDQo+IENoYW5nZXMgaW4gdjM6DQo+ IC0gbWFrZSBNQVhfVVNFUl9STVJSX1BBR0VTIGFwcGxpY2FibGUgb25seSB0byB1c2VyLWNvbmZp Z3VyZWQgUk1SUg0KPiAtLS0NCj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFyLmMg fCAyMDEgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwg MTE5IGluc2VydGlvbnMoKyksIDgyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hl bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFyLmMNCj4gYi94ZW4vZHJpdmVycy9wYXNzdGhy b3VnaC92dGQvZG1hci5jDQo+IGluZGV4IDM2NzMwNGM4NzM5Yy4uM2RmNWY2YjY5NzE5IDEwMDY0 NA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZG1hci5jDQo+ICsrKyBiL3hl bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFyLmMNCj4gQEAgLTg2MSwxMTEgKzg2MSwxMzkg QEAgc3RhdGljIHN0cnVjdCB1c2VyX3JtcnIgX19pbml0ZGF0YQ0KPiB1c2VyX3JtcnJzW01BWF9V U0VSX1JNUlJdOw0KPiANCj4gIC8qIE1hY3JvIGZvciBSTVJSIGluY2x1c2l2ZSByYW5nZSBmb3Jt YXR0aW5nLiAqLw0KPiAgI2RlZmluZSBFUk1SUlVfRk1UICJbJWx4LSVseF0iDQo+IC0jZGVmaW5l IEVSTVJSVV9BUkcoZXJ1KSBlcnUuYmFzZV9wZm4sIGVydS5lbmRfcGZuDQo+ICsjZGVmaW5lIEVS TVJSVV9BUkcgYmFzZV9wZm4sIGVuZF9wZm4NCj4gKw0KPiArc3RhdGljIGludCBfX2luaXQgYWRk X29uZV91c2VyX3JtcnIodW5zaWduZWQgbG9uZyBiYXNlX3BmbiwNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZW5kX3BmbiwNCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBkZXZfY291bnQsDQo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCAqc2JkZik7DQoNCkp1 c3QgbW92ZSB0aGUgZnVuY3Rpb24gaGVyZSB0aGVuIG5vIG5lZWQgb2YgYSBkZWNsYXJhdGlvbi4N Cg0KPiANCj4gIHN0YXRpYyBpbnQgX19pbml0IGFkZF91c2VyX3JtcnIodm9pZCkNCj4gIHsNCj4g KyAgICB1bnNpZ25lZCBpbnQgaTsNCj4gKyAgICBpbnQgcmV0Ow0KPiArDQo+ICsgICAgZm9yICgg aSA9IDA7IGkgPCBucl9ybXJyOyBpKysgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcmV0ID0gYWRk X29uZV91c2VyX3JtcnIodXNlcl9ybXJyc1tpXS5iYXNlX3BmbiwNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdXNlcl9ybXJyc1tpXS5lbmRfcGZuLA0KPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1c2VyX3JtcnJzW2ldLmRldl9jb3VudCwNCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdXNlcl9ybXJyc1tpXS5zYmRmKTsNCj4gKyAgICAgICAg aWYgKCByZXQgPCAwICkNCj4gKyAgICAgICAgICAgIHJldHVybiByZXQ7DQo+ICsgICAgfQ0KPiAr ICAgIHJldHVybiAwOw0KPiArfQ0KPiArDQo+ICsvKiBSZXR1cm5zIDEgb24gc3VjY2VzcywgMCB3 aGVuIGlnbm9yaW5nIGFuZCA8IDAgb24gZXJyb3IuICovDQoNCkknbSBub3Qgc3VyZSB0aGUgcG9p bnQgb2YgJ2lnbm9yaW5nJy4gSWYgdXNlciBzcGVjaWZpZXMgYSB3cm9uZyBSTVJSDQpyYW5nZSAo b3ZlcmxhcCwgbWZuIGludmFsaWQsIGV0Yy4pIGp1c3QgcmV0dXJuIGFuIGVycm9yIHNpbWlsYXIg dG8NCi1FTk9NRU0uIElnbm9yaW5nIGEgdXNlci1zcGVjaWZpZWQgcmFuZ2UgaW1wbGllcyB0aGF0 IHNvbWV0aGluZw0Kd291bGQgcG90ZW50aWFsbHkgZ2V0IGJyb2tlbiBoZW5jZSBiZXR0ZXIgZmFp bCBpdCBlYXJseS4NCg0KPiArc3RhdGljIGludCBfX2luaXQgYWRkX29uZV91c2VyX3JtcnIodW5z aWduZWQgbG9uZyBiYXNlX3BmbiwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGxvbmcgZW5kX3BmbiwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBkZXZfY291bnQsDQo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1aW50MzJfdCAqc2JkZikNCj4gK3sNCj4gICAgICBzdHJ1Y3QgYWNw aV9ybXJyX3VuaXQgKnJtcnIsICpybXJydTsNCj4gLSAgICB1bnNpZ25lZCBpbnQgaWR4LCBzZWcs IGk7DQo+IC0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCBlbmQ7DQo+ICsgICAgdW5zaWduZWQgaW50 IGlkeCwgc2VnOw0KPiArICAgIHVuc2lnbmVkIGxvbmcgYmFzZV9pdGVyOw0KPiAgICAgIGJvb2wg b3ZlcmxhcDsNCj4gDQo+IC0gICAgZm9yICggaSA9IDA7IGkgPCBucl9ybXJyOyBpKysgKQ0KPiAr ICAgIGlmICggaW9tbXVfdmVyYm9zZSApDQo+ICsgICAgICAgIHByaW50ayhYRU5MT0dfREVCVUcg VlREUFJFRklYDQo+ICsgICAgICAgICAgICAgICAiQWRkaW5nIFJNUlIgZm9yICVkIGRldmljZSAo WzBdOiAlI3gpIHJhbmdlICJFUk1SUlVfRk1UIlxuIiwNCj4gKyAgICAgICAgICAgICAgIGRldl9j b3VudCwgc2JkZlswXSwgRVJNUlJVX0FSRyk7DQo+ICsNCj4gKyAgICBpZiAoIGJhc2VfcGZuID4g ZW5kX3BmbiApDQo+ICAgICAgew0KPiAtICAgICAgICBiYXNlID0gdXNlcl9ybXJyc1tpXS5iYXNl X3BmbjsNCj4gLSAgICAgICAgZW5kID0gdXNlcl9ybXJyc1tpXS5lbmRfcGZuOw0KPiArICAgICAg ICBwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgNCj4gKyAgICAgICAgICAgICAgICJJbnZhbGlk IFJNUlIgUmFuZ2UgIkVSTVJSVV9GTVQiXG4iLA0KPiArICAgICAgICAgICAgICAgRVJNUlJVX0FS Ryk7DQo+ICsgICAgICAgIHJldHVybiAwOw0KPiArICAgIH0NCj4gDQo+IC0gICAgICAgIGlmICgg YmFzZSA+IGVuZCApDQo+ICsgICAgb3ZlcmxhcCA9IGZhbHNlOw0KPiArICAgIGxpc3RfZm9yX2Vh Y2hfZW50cnkocm1ycnUsICZhY3BpX3JtcnJfdW5pdHMsIGxpc3QpDQo+ICsgICAgew0KPiArICAg ICAgICBpZiAoIHBmbl90b19wYWRkcihiYXNlX3BmbikgPD0gcm1ycnUtPmVuZF9hZGRyZXNzICYm DQo+ICsgICAgICAgICAgICAgcm1ycnUtPmJhc2VfYWRkcmVzcyA8PSBwZm5fdG9fcGFkZHIoZW5k X3BmbikgKQ0KPiAgICAgICAgICB7DQo+ICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUiBW VERQUkVGSVgNCj4gLSAgICAgICAgICAgICAgICAgICAiSW52YWxpZCBSTVJSIFJhbmdlICJFUk1S UlVfRk1UIlxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICBFUk1SUlVfQVJHKHVzZXJfcm1ycnNb aV0pKTsNCj4gLSAgICAgICAgICAgIGNvbnRpbnVlOw0KPiArICAgICAgICAgICAgICAgICAgICJP dmVybGFwcGluZyBSTVJSczogIkVSTVJSVV9GTVQiIGFuZCBbJWx4LSVseF1cbiIsDQo+ICsgICAg ICAgICAgICAgICAgICAgRVJNUlJVX0FSRywNCj4gKyAgICAgICAgICAgICAgICAgICBwYWRkcl90 b19wZm4ocm1ycnUtPmJhc2VfYWRkcmVzcyksDQo+ICsgICAgICAgICAgICAgICAgICAgcGFkZHJf dG9fcGZuKHJtcnJ1LT5lbmRfYWRkcmVzcykpOw0KPiArICAgICAgICAgICAgb3ZlcmxhcCA9IHRy dWU7DQo+ICsgICAgICAgICAgICBicmVhazsNCj4gICAgICAgICAgfQ0KPiArICAgIH0NCj4gKyAg ICAvKiBEb24ndCBhZGQgb3ZlcmxhcHBpbmcgUk1SUi4gKi8NCj4gKyAgICBpZiAoIG92ZXJsYXAg KQ0KPiArICAgICAgICByZXR1cm4gMDsNCj4gDQo+IC0gICAgICAgIGlmICggKGVuZCAtIGJhc2Up ID49IE1BWF9VU0VSX1JNUlJfUEFHRVMgKQ0KPiArICAgIGJhc2VfaXRlciA9IGJhc2VfcGZuOw0K PiArICAgIGRvDQo+ICsgICAgew0KPiArICAgICAgICBpZiAoICFtZm5fdmFsaWQoX21mbihiYXNl X2l0ZXIpKSApDQo+ICAgICAgICAgIHsNCj4gICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJS IFZURFBSRUZJWA0KPiAtICAgICAgICAgICAgICAgICAgICJSTVJSIHJhbmdlICJFUk1SUlVfRk1U IiBleGNlZWRzICJcDQo+IC0gICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnkoTUFYX1VTRVJf Uk1SUl9QQUdFUykiIHBhZ2VzXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgIEVSTVJSVV9BUkco dXNlcl9ybXJyc1tpXSkpOw0KPiAtICAgICAgICAgICAgY29udGludWU7DQo+ICsgICAgICAgICAg ICAgICAgICAgIkludmFsaWQgcGZuIGluIFJNUlIgcmFuZ2UgIkVSTVJSVV9GTVQiXG4iLA0KPiAr ICAgICAgICAgICAgICAgICAgIEVSTVJSVV9BUkcpOw0KPiArICAgICAgICAgICAgYnJlYWs7DQo+ ICAgICAgICAgIH0NCj4gKyAgICB9IHdoaWxlICggYmFzZV9pdGVyKysgPCBlbmRfcGZuICk7DQo+ IA0KPiAtICAgICAgICBvdmVybGFwID0gZmFsc2U7DQo+IC0gICAgICAgIGxpc3RfZm9yX2VhY2hf ZW50cnkocm1ycnUsICZhY3BpX3JtcnJfdW5pdHMsIGxpc3QpDQo+IC0gICAgICAgIHsNCj4gLSAg ICAgICAgICAgIGlmICggcGZuX3RvX3BhZGRyKGJhc2UpIDw9IHJtcnJ1LT5lbmRfYWRkcmVzcyAm Jg0KPiAtICAgICAgICAgICAgICAgICBybXJydS0+YmFzZV9hZGRyZXNzIDw9IHBmbl90b19wYWRk cihlbmQpICkNCj4gLSAgICAgICAgICAgIHsNCj4gLSAgICAgICAgICAgICAgICBwcmludGsoWEVO TE9HX0VSUiBWVERQUkVGSVgNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgIk92ZXJsYXBwaW5n IFJNUlJzOiAiRVJNUlJVX0ZNVCIgYW5kIFslbHgtJWx4XVxuIiwNCj4gLSAgICAgICAgICAgICAg ICAgICAgICAgRVJNUlJVX0FSRyh1c2VyX3JtcnJzW2ldKSwNCj4gLSAgICAgICAgICAgICAgICAg ICAgICAgcGFkZHJfdG9fcGZuKHJtcnJ1LT5iYXNlX2FkZHJlc3MpLA0KPiAtICAgICAgICAgICAg ICAgICAgICAgICBwYWRkcl90b19wZm4ocm1ycnUtPmVuZF9hZGRyZXNzKSk7DQo+IC0gICAgICAg ICAgICAgICAgb3ZlcmxhcCA9IHRydWU7DQo+IC0gICAgICAgICAgICAgICAgYnJlYWs7DQo+IC0g ICAgICAgICAgICB9DQo+IC0gICAgICAgIH0NCj4gLSAgICAgICAgLyogRG9uJ3QgYWRkIG92ZXJs YXBwaW5nIFJNUlIuICovDQo+IC0gICAgICAgIGlmICggb3ZlcmxhcCApDQo+IC0gICAgICAgICAg ICBjb250aW51ZTsNCj4gKyAgICAvKiBJbnZhbGlkIHBmbiBpbiByYW5nZSBhcyB0aGUgbG9vcCBl bmRlZCBiZWZvcmUgZW5kX3BmbiB3YXMgcmVhY2hlZC4gKi8NCj4gKyAgICBpZiAoIGJhc2VfaXRl ciA8PSBlbmRfcGZuICkNCj4gKyAgICAgICAgcmV0dXJuIDA7DQo+IA0KPiAtICAgICAgICBkbw0K PiAtICAgICAgICB7DQo+IC0gICAgICAgICAgICBpZiAoICFtZm5fdmFsaWQoX21mbihiYXNlKSkg KQ0KPiAtICAgICAgICAgICAgew0KPiAtICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJS IFZURFBSRUZJWA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAiSW52YWxpZCBwZm4gaW4gUk1S UiByYW5nZSAiRVJNUlJVX0ZNVCJcbiIsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgIEVSTVJS VV9BUkcodXNlcl9ybXJyc1tpXSkpOw0KPiAtICAgICAgICAgICAgICAgIGJyZWFrOw0KPiAtICAg ICAgICAgICAgfQ0KPiAtICAgICAgICB9IHdoaWxlICggYmFzZSsrIDwgZW5kICk7DQo+ICsgICAg cm1yciA9IHh6YWxsb2Moc3RydWN0IGFjcGlfcm1ycl91bml0KTsNCj4gKyAgICBpZiAoICFybXJy ICkNCj4gKyAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+IA0KPiAtICAgICAgICAvKiBJbnZhbGlk IHBmbiBpbiByYW5nZSBhcyB0aGUgbG9vcCBlbmRlZCBiZWZvcmUgZW5kX3BmbiB3YXMgcmVhY2hl ZC4NCj4gKi8NCj4gLSAgICAgICAgaWYgKCBiYXNlIDw9IGVuZCApDQo+IC0gICAgICAgICAgICBj b250aW51ZTsNCj4gKyAgICBybXJyLT5zY29wZS5kZXZpY2VzID0geG1hbGxvY19hcnJheSh1MTYs IGRldl9jb3VudCk7DQo+ICsgICAgaWYgKCAhcm1yci0+c2NvcGUuZGV2aWNlcyApDQo+ICsgICAg ew0KPiArICAgICAgICB4ZnJlZShybXJyKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ ICsgICAgfQ0KPiANCj4gLSAgICAgICAgcm1yciA9IHh6YWxsb2Moc3RydWN0IGFjcGlfcm1ycl91 bml0KTsNCj4gLSAgICAgICAgaWYgKCAhcm1yciApDQo+IC0gICAgICAgICAgICByZXR1cm4gLUVO T01FTTsNCj4gKyAgICBzZWcgPSAwOw0KPiArICAgIGZvciAoIGlkeCA9IDA7IGlkeCA8IGRldl9j b3VudDsgaWR4KysgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcm1yci0+c2NvcGUuZGV2aWNlc1tp ZHhdID0gc2JkZltpZHhdOw0KPiArICAgICAgICBzZWcgfD0gUENJX1NFRyhzYmRmW2lkeF0pOw0K PiArICAgIH0NCj4gKyAgICBpZiAoIHNlZyAhPSBQQ0lfU0VHKHNiZGZbMF0pICkNCj4gKyAgICB7 DQo+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWA0KPiArICAgICAgICAgICAg ICAgIlNlZ21lbnRzIGFyZSBub3QgZXF1YWwgZm9yIFJNUlIgcmFuZ2UgIkVSTVJSVV9GTVQiXG4i LA0KPiArICAgICAgICAgICAgICAgRVJNUlJVX0FSRyk7DQo+ICsgICAgICAgIHNjb3BlX2Rldmlj ZXNfZnJlZSgmcm1yci0+c2NvcGUpOw0KPiArICAgICAgICB4ZnJlZShybXJyKTsNCj4gKyAgICAg ICAgcmV0dXJuIDA7DQo+ICsgICAgfQ0KPiANCj4gLSAgICAgICAgcm1yci0+c2NvcGUuZGV2aWNl cyA9IHhtYWxsb2NfYXJyYXkodTE2LCB1c2VyX3JtcnJzW2ldLmRldl9jb3VudCk7DQo+IC0gICAg ICAgIGlmICggIXJtcnItPnNjb3BlLmRldmljZXMgKQ0KPiAtICAgICAgICB7DQo+IC0gICAgICAg ICAgICB4ZnJlZShybXJyKTsNCj4gLSAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPiAtICAg ICAgICB9DQo+ICsgICAgcm1yci0+c2VnbWVudCA9IHNlZzsNCj4gKyAgICBybXJyLT5iYXNlX2Fk ZHJlc3MgPSBwZm5fdG9fcGFkZHIoYmFzZV9wZm4pOw0KPiArICAgIC8qIEFsaWduIHRoZSBlbmRf YWRkcmVzcyB0byB0aGUgZW5kIG9mIHRoZSBwYWdlICovDQo+ICsgICAgcm1yci0+ZW5kX2FkZHJl c3MgPSBwZm5fdG9fcGFkZHIoZW5kX3BmbikgfCB+UEFHRV9NQVNLOw0KPiArICAgIHJtcnItPnNj b3BlLmRldmljZXNfY250ID0gZGV2X2NvdW50Ow0KPiANCj4gLSAgICAgICAgc2VnID0gMDsNCj4g LSAgICAgICAgZm9yICggaWR4ID0gMDsgaWR4IDwgdXNlcl9ybXJyc1tpXS5kZXZfY291bnQ7IGlk eCsrICkNCj4gLSAgICAgICAgew0KPiAtICAgICAgICAgICAgcm1yci0+c2NvcGUuZGV2aWNlc1tp ZHhdID0gdXNlcl9ybXJyc1tpXS5zYmRmW2lkeF07DQo+IC0gICAgICAgICAgICBzZWcgfD0gUENJ X1NFRyh1c2VyX3JtcnJzW2ldLnNiZGZbaWR4XSk7DQo+IC0gICAgICAgIH0NCj4gLSAgICAgICAg aWYgKCBzZWcgIT0gUENJX1NFRyh1c2VyX3JtcnJzW2ldLnNiZGZbMF0pICkNCj4gLSAgICAgICAg ew0KPiAtICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYDQo+IC0gICAgICAg ICAgICAgICAgICAgIlNlZ21lbnRzIGFyZSBub3QgZXF1YWwgZm9yIFJNUlIgcmFuZ2UgIkVSTVJS VV9GTVQiXG4iLA0KPiAtICAgICAgICAgICAgICAgICAgIEVSTVJSVV9BUkcodXNlcl9ybXJyc1tp XSkpOw0KPiAtICAgICAgICAgICAgc2NvcGVfZGV2aWNlc19mcmVlKCZybXJyLT5zY29wZSk7DQo+ IC0gICAgICAgICAgICB4ZnJlZShybXJyKTsNCj4gLSAgICAgICAgICAgIGNvbnRpbnVlOw0KPiAt ICAgICAgICB9DQo+ICsgICAgaWYgKCByZWdpc3Rlcl9vbmVfcm1ycihybXJyKSApDQo+ICsgICAg ICAgIHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWA0KPiArICAgICAgICAgICAgICAgIkNvdWxk IG5vdCByZWdpc3RlciBSTU1SIHJhbmdlICJFUk1SUlVfRk1UIlxuIiwNCj4gKyAgICAgICAgICAg ICAgIEVSTVJSVV9BUkcpOw0KPiANCj4gLSAgICAgICAgcm1yci0+c2VnbWVudCA9IHNlZzsNCj4g LSAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzID0gcGZuX3RvX3BhZGRyKHVzZXJfcm1ycnNbaV0u YmFzZV9wZm4pOw0KPiAtICAgICAgICAvKiBBbGlnbiB0aGUgZW5kX2FkZHJlc3MgdG8gdGhlIGVu ZCBvZiB0aGUgcGFnZSAqLw0KPiAtICAgICAgICBybXJyLT5lbmRfYWRkcmVzcyA9IHBmbl90b19w YWRkcih1c2VyX3JtcnJzW2ldLmVuZF9wZm4pIHwNCj4gflBBR0VfTUFTSzsNCj4gLSAgICAgICAg cm1yci0+c2NvcGUuZGV2aWNlc19jbnQgPSB1c2VyX3JtcnJzW2ldLmRldl9jb3VudDsNCj4gKyAg ICByZXR1cm4gMTsNCj4gK30NCj4gDQo+IC0gICAgICAgIGlmICggcmVnaXN0ZXJfb25lX3JtcnIo cm1ycikgKQ0KPiAtICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYDQo+IC0g ICAgICAgICAgICAgICAgICAgIkNvdWxkIG5vdCByZWdpc3RlciBSTU1SIHJhbmdlICJFUk1SUlVf Rk1UIlxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICBFUk1SUlVfQVJHKHVzZXJfcm1ycnNbaV0p KTsNCj4gLSAgICB9DQo+ICtzdGF0aWMgaW50IF9faW5pdCBjZl9jaGVjayBhZGRfb25lX2V4dHJh X3JtcnIoeGVuX3Bmbl90IHN0YXJ0LCB4ZW5fdWxvbmdfdA0KPiBuciwgdTMyIGlkLCB2b2lkICpj dHh0KQ0KPiArew0KPiArICAgIHUzMiBzYmRmX2FycmF5W10gPSB7IGlkIH07DQo+ICsgICAgcmV0 dXJuIGFkZF9vbmVfdXNlcl9ybXJyKHN0YXJ0LCBzdGFydCtuciwgMSwgc2JkZl9hcnJheSk7DQo+ ICt9DQo+IA0KPiAtICAgIHJldHVybiAwOw0KPiArc3RhdGljIGludCBfX2luaXQgYWRkX2V4dHJh X3JtcnIodm9pZCkNCj4gK3sNCj4gKyAgICByZXR1cm4gaW9tbXVfZ2V0X2V4dHJhX3Jlc2VydmVk X2RldmljZV9tZW1vcnkoYWRkX29uZV9leHRyYV9ybXJyLA0KPiBOVUxMKTsNCj4gIH0NCj4gDQo+ ICAjaW5jbHVkZSA8YXNtL3Rib290Lmg+DQo+IEBAIC0xMDEwLDcgKzEwMzgsNyBAQCBpbnQgX19p bml0IGFjcGlfZG1hcl9pbml0KHZvaWQpDQo+ICAgICAgew0KPiAgICAgICAgICBpb21tdV9pbml0 X29wcyA9ICZpbnRlbF9pb21tdV9pbml0X29wczsNCj4gDQo+IC0gICAgICAgIHJldHVybiBhZGRf dXNlcl9ybXJyKCk7DQo+ICsgICAgICAgIHJldHVybiBhZGRfdXNlcl9ybXJyKCkgfHwgYWRkX2V4 dHJhX3JtcnIoKTsNCj4gICAgICB9DQo+IA0KPiAgICAgIHJldHVybiByZXQ7DQo+IEBAIC0xMTA4 LDYgKzExMzYsMTUgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sgcGFyc2Vfcm1ycl9wYXJh bShjb25zdA0KPiBjaGFyICpzdHIpDQo+ICAgICAgICAgIGVsc2UNCj4gICAgICAgICAgICAgIGVu ZCA9IHN0YXJ0Ow0KPiANCj4gKyAgICAgICAgaWYgKCAoZW5kIC0gc3RhcnQpID49IE1BWF9VU0VS X1JNUlJfUEFHRVMgKQ0KPiArICAgICAgICB7DQo+ICsgICAgICAgICAgICBwcmludGsoWEVOTE9H X0VSUiBWVERQUkVGSVgNCj4gKyAgICAgICAgICAgICAgICAgICAgIlJNUlIgcmFuZ2UgIkVSTVJS VV9GTVQiIGV4Y2VlZHMgIlwNCj4gKyAgICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnkoTUFY X1VTRVJfUk1SUl9QQUdFUykiIHBhZ2VzXG4iLA0KPiArICAgICAgICAgICAgICAgICAgICBzdGFy dCwgZW5kKTsNCj4gKyAgICAgICAgICAgIHJldHVybiAtRTJCSUc7DQo+ICsgICAgICAgIH0NCj4g Kw0KDQp3aHkgbW92aW5nIHRoaXMgZXJyb3IgY2hlY2sgb3V0IG9mIGFkZF9vbmVfdXNlcl9ybXJy KCk/IEkgZGlkbid0DQpnZXQgd2h5IGl0J3Mgc3BlY2lhbCBmcm9tIG90aGVyIGNoZWNrcyB0aGVy ZSwgZS5nLiBoYXZpbmcgYmFzZT5lbmQuLi4NCg0KPiAgICAgICAgICB1c2VyX3JtcnJzW25yX3Jt cnJdLmJhc2VfcGZuID0gc3RhcnQ7DQo+ICAgICAgICAgIHVzZXJfcm1ycnNbbnJfcm1ycl0uZW5k X3BmbiA9IGVuZDsNCj4gDQo+IC0tDQo+IGdpdC1zZXJpZXMgMC45LjENCg0K From xen-devel-bounces@lists.xenproject.org Fri Sep 23 07:28:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 07:28:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410618.653704 (Exim 4.92) (envelope-from ) id 1obd6m-000339-1j; Fri, 23 Sep 2022 07:28:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410618.653704; Fri, 23 Sep 2022 07:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obd6l-000332-Uc; Fri, 23 Sep 2022 07:28:23 +0000 Received: by outflank-mailman (input) for mailman id 410618; Fri, 23 Sep 2022 07:28:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obd6k-00032w-LD for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 07:28:22 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2080.outbound.protection.outlook.com [40.107.243.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c093153-3b11-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 09:28:20 +0200 (CEST) Received: from BN9PR03CA0155.namprd03.prod.outlook.com (2603:10b6:408:f4::10) by CH2PR12MB4873.namprd12.prod.outlook.com (2603:10b6:610:63::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 07:28:17 +0000 Received: from BN8NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f4:cafe::b0) by BN9PR03CA0155.outlook.office365.com (2603:10b6:408:f4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 07:28:17 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT016.mail.protection.outlook.com (10.13.176.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 07:28:17 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 02:28:15 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 00:28:15 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 23 Sep 2022 02:28:14 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c093153-3b11-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUcRyXw1y8inGBOLfpKFvh2+qGdEMtvPKv9fd19VocyVOY0VHk0ZCrbEHzjo2k7KRAX6CbFQVnTSyxUvszkZGb1zspb9PCBuBQBg5Jr5MELFNpsiMXpmh8B6xuKPDoeMjRE74EQ1ja5IuCZ8nxrK4OI6PvCpP9n3Q707ZK4Cv50+QhMMN69Mu8pV2Sn8nC7V2F1PMMRIsOkoeD0PhCk5W4Tc14hJ2ulpKc4MXkh3hhkb2mJ3VDtKpIocbFYYi7MCETeQRaG45BYEfCcSdtlgStuptEcHJBTepI0RgRmC/CO7FogLVeOey+NDsjQ0usEEmAGKR3Zbzo18HrWYtwdysg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWWDTpR9fV6b1ululcNbVcQjv7vwh4lAstAjc0J6pjc=; b=hQCmkT9Hj1ziNuTbndaE/l8L+G11aHPj8uESH1W2qVt7cyKVOsMvGrOWMnXSjv6KItferp93BKOm2ciCOinvtnftyR+GUg4B/SXkyDruIMgtmbaMWubdxbZRR0m2scEdgPH1N9W+lAkuBvCxaYX6KMrWnCsWQL3y0+rCCaq4bCTlTdvizZCv+IHR8kMCh9KNInU+iV2vz1nrrOcmDHcjCA6yUJki1QCNGpU5qpyOE0Cs2yOtXarnj38MEgMVOU1B32mYn/zS5OqB2JgduH3hpIyFxeKTmXiGYkWepQV1qOkHgpCO8yro5KTImJbelMwHwUqPnD+LAKPYpGWYm6RUaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWWDTpR9fV6b1ululcNbVcQjv7vwh4lAstAjc0J6pjc=; b=cvI646cLoK5INW5+gWY+WlbV291hyAZigphCIPipCiUOGMDPhtoOOTxS+DtpJeoNm3qFMdbKOHNlVnum9ppm4rEvL9RQnoLPKS5ke1tFbZskjPaW1XHDP0jmJU7FRNJ49V5IRQZ29YsLDDrSat4dKm/04Vd8GTlKjih1hrC9Pxk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 23 Sep 2022 09:28:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/9] automation: Use custom build jobs when extra config options are needed To: Stefano Stabellini CC: , Doug Goldstein , References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-2-michal.orzel@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT016:EE_|CH2PR12MB4873:EE_ X-MS-Office365-Filtering-Correlation-Id: c304ce70-5c82-4f9d-7eb1-08da9d352f03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3aW0uzFc9Cbrq8+O8XJsuxhL7Ixz4FcRL6FuhCAYM0NlEyLXvbYN8YR99Plsij72A78LnuXVzwxzhRWF9RWH0pYMHRb5BX4mgL/csBkO1ipQzn8fiWem/YSU3Q5Vz4YzpPjChJY976qt69LgBw9SJbFX6R2i1sMLpUYd5J67aINCtrhazE1Fon2f1dygQZEyi8XVzC+/xdtRJ1TwUsFKN5JVTrnY3Beib6WMNwi20SOq08WcDStzO3YdFMLOrZw8Yi1Jexz8At3WHqXKcgSzNH+Q+akgxYBMSoEBTTUcrTmTXQGT40VRXFjFJYuDqwT5vivEFLOBzU6ExRae0Q+3DVmN8i//RF7anQFcYtA97xTvhzI7MzWNW9o2YN8KmH6mduMBdyVUIYERDvvzVjepLGPO/ilFW2vPRMrvLVFI3e4n2S7Ur0IMjzWJeRe/DMDxbbpI7gKThcdF2gABnJoaQ96yfEKDoLUGnVpWgzK8td3AfIm5Zg1w7AQroz+nj8Vme5uprtr1i346a2Neaexz8ZYeWAb/DxrlOACc4hU61MoXlBbsh5+70G9lo+cL281CP+TvIkp43ylIW4MWVPQzQ9a5m58LNGw7mz3kA3hjH93bWrcq7EdMZ+k+tK5VFWPIWNNqiLEQhPGghq9ezQOPWPK9Hi9qLwltm2aTeyJkp/G9o+PFItKADZH7Q+5E8vS0bPNlB+GVCwD2AnLXAzWzTvXkS/8c2iFbn6eTtjKc06Sx7HzrxqkmkOw4fOaXf1i1fskzOp0UsJfBzycMPi2pIPKF5swDAm7AzF/jXP0gFeaQd5u8ho8uKVZr9sjL6gpB3FqBN02783SHDMZ5CdnfAdnm8RUTADEf9aIeWIRoy6I= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(26005)(36860700001)(31686004)(8676002)(4326008)(16576012)(316002)(70586007)(70206006)(36756003)(40460700003)(41300700001)(31696002)(86362001)(8936002)(5660300002)(356005)(40480700001)(53546011)(82310400005)(83380400001)(336012)(82740400003)(44832011)(81166007)(186003)(2616005)(478600001)(54906003)(6916009)(966005)(426003)(47076005)(2906002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 07:28:17.3307 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c304ce70-5c82-4f9d-7eb1-08da9d352f03 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4873 Hi Stefano, On 22/09/2022 23:40, Stefano Stabellini wrote: > > > On Thu, 22 Sep 2022, Michal Orzel wrote: >> Currently, all the arm64 defconfig build jobs, regardless of the >> container used, end up building Xen with the extra config options >> specified in the main build script (e.g. CONFIG_EXPERT, >> CONFIG_STATIC_MEMORY). Because these options are only needed for >> specific test jobs, the current behavior of the CI is incorrect >> as we add the extra options to all the defconfig builds. This means >> that on arm64 there is not a single job performing proper defconfig build. >> >> To fix this issue, add custom build jobs each time there is a need for >> building Xen with additional config options. Introduce EXTRA_XEN_CONFIG >> variable to be used by these jobs to store the required options. This >> variable will be then read by the main build script to modify the .config >> file. This will also help users to understand what is needed to run specific >> test. >> >> Signed-off-by: Michal Orzel >> --- >> This patch could actually be consider to be taken for 4.17 release. >> The reason why is because currently our CI for arm64 does not even >> peform clean defconfig build which is quite crucial target to be tested. >> Performing builds always with EXPERT and UNSUPPORTED is not something so >> beneficial for release tests. This is up to the release manager. > > + Henry > > I agree this should go in 4.17, so that gitlab-ci can test non-DEBUG > builds on ARM. > Do you mean the whole series should go in? I'm ok with that, even though I only marked this patch as the one that should go in as it can be seen as a fix. But I can also see the benefits of merging the whole series. > >> --- >> automation/gitlab-ci/build.yaml | 15 +++++++++++++++ >> automation/gitlab-ci/test.yaml | 4 ++-- >> automation/scripts/build | 8 ++------ >> 3 files changed, 19 insertions(+), 8 deletions(-) >> >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml >> index 720ce6e07ba0..a39ed72aac6d 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation/gitlab-ci/build.yaml >> @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: >> variables: >> CONTAINER: alpine:3.12-arm64v8 >> >> +alpine-3.12-gcc-arm64-staticmem: >> + extends: .gcc-arm64-build >> + variables: >> + CONTAINER: alpine:3.12-arm64v8 >> + EXTRA_XEN_CONFIG: | > > Why the "|" ? > > I was trying to look for its documentation in the gitlab yaml docs but > couldn't find it. > By default gitlab variables are one liners so that they can store one key:value pair. If you want to define a variable storing multiple values (in this case we want to store multi-line string because of .config format) you need to use |. You can check [1]. > >> + CONFIG_EXPERT=y >> + CONFIG_UNSUPPORTED=y >> + CONFIG_STATIC_MEMORY=y >> + >> +alpine-3.12-gcc-arm64-boot-cpupools: >> + extends: .gcc-arm64-build >> + variables: >> + CONTAINER: alpine:3.12-arm64v8 >> + EXTRA_XEN_CONFIG: | >> + CONFIG_BOOT_TIME_CPUPOOLS=y >> >> ## Test artifacts common >> >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >> index d899b3bdbf7a..4f96e6e322de 100644 >> --- a/automation/gitlab-ci/test.yaml >> +++ b/automation/gitlab-ci/test.yaml >> @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: >> script: >> - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log >> needs: >> - - alpine-3.12-gcc-arm64 >> + - alpine-3.12-gcc-arm64-staticmem >> - alpine-3.12-arm64-rootfs-export >> - kernel-5.19-arm64-export >> - qemu-system-aarch64-6.0.0-arm64-export >> @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: >> script: >> - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log >> needs: >> - - alpine-3.12-gcc-arm64 >> + - alpine-3.12-gcc-arm64-boot-cpupools >> - alpine-3.12-arm64-rootfs-export >> - kernel-5.19-arm64-export >> - qemu-system-aarch64-6.0.0-arm64-export >> diff --git a/automation/scripts/build b/automation/scripts/build >> index 2f15ab3198e6..7d441cedb4ae 100755 >> --- a/automation/scripts/build >> +++ b/automation/scripts/build >> @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then >> make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig >> hypervisor_only="y" >> else >> - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then >> - echo " >> -CONFIG_EXPERT=y >> -CONFIG_UNSUPPORTED=y >> -CONFIG_STATIC_MEMORY=y >> -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config >> + if [ -n "${EXTRA_XEN_CONFIG}" ]; then > > NIT: for uniformity with rest of the file use > > if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then > Ok, will do in v2. > >> + echo "${EXTRA_XEN_CONFIG}" > xen/.config >> make -j$(nproc) -C xen olddefconfig >> else >> make -j$(nproc) -C xen defconfig >> -- >> 2.25.1 >> ~Michal [1] https://docs.gitlab.com/ee/ci/variables/#store-multiple-values-in-one-variable From xen-devel-bounces@lists.xenproject.org Fri Sep 23 07:33:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 07:33:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410625.653715 (Exim 4.92) (envelope-from ) id 1obdC4-0004WL-ND; Fri, 23 Sep 2022 07:33:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410625.653715; Fri, 23 Sep 2022 07:33:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdC4-0004WE-KY; Fri, 23 Sep 2022 07:33:52 +0000 Received: by outflank-mailman (input) for mailman id 410625; Fri, 23 Sep 2022 07:33:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdC3-0004W8-Fu for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 07:33:51 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 106beefd-3b12-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 09:33:49 +0200 (CEST) Received: from BN9PR03CA0940.namprd03.prod.outlook.com (2603:10b6:408:108::15) by DM4PR12MB6160.namprd12.prod.outlook.com (2603:10b6:8:a7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Fri, 23 Sep 2022 07:33:47 +0000 Received: from BL02EPF0000C402.namprd05.prod.outlook.com (2603:10b6:408:108:cafe::ab) by BN9PR03CA0940.outlook.office365.com (2603:10b6:408:108::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 07:33:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000C402.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.11 via Frontend Transport; Fri, 23 Sep 2022 07:33:46 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 02:33:45 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 23 Sep 2022 02:33:45 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 106beefd-3b12-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0AuZgYVdRWmn4NYpVR3SPBmpJCXRo5o4Hs+WVOCUzM0S70L2PJ9FKU/CfayzlLIIm+QuiDROqJxWK41IQ/FROvyHfliVhB0IWgjUbQkmVaMATxe5S2aOmmP4CZ4s/pRfeG4yYCD+yM2OEbP+31/9vsXi2DqU2okExdQGeARVtK0P70sZmWX4tTnZLGMr+yYORM3ga9b4XmHft3pL/6MclJEUi06M+fP+AyKgmw/As/Aq54RlEtXztzGuCZUnycmkK6naLR2DObozJD7PonzQwkhqxA94KhRNIYbRoYqvAM3d4sDhvyUMGzTMG2458aJST1gb+VEtapMKNRXZdAV+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vyfWqoV7mW5UHT94u3tkjCszZ5FWTHuxyDk3LaMCiE4=; b=C/dgG1J+JTrIzI9zRGYwgi7O5PWsGmWpqOazGiSLLfrPueHlATocfyHgl6KoETqrZiPsBnbv7hsqPmfCdvWMBm78NjvI8hG9NtREqdes2ZEgV/xs4eJXa6So3cxPU7u7OLdrapQhDiyOVmxu087kBr7ROvj5FbcrWQk6rtkn8s1Zvk1QwNdKNKSgeHHSwBsOE9P6w+obJEECnTIN7BI0HhTWRtroSmpECz1IsBCjAydwpmesa2RDPDOJn6Wx8W89++CmbgVcQbF2051gahPVn/ns75+wJhMFK3uMyufeM+0rpLwxkKM8Ri2ymbJawZRLJOs2O7mvm4sqSGohL2l3mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vyfWqoV7mW5UHT94u3tkjCszZ5FWTHuxyDk3LaMCiE4=; b=JrROYhEmtN1yGIB0DI8Dqo1qIiidz7AEYP6IEdk5U9XsCLrBZYOes/mh3KsD2iqhHZC+VNjpnlrPSz4WytK5M9UWl86poUv120bHo5lIGXHOct1K8QhsqPzoGdXgRSrlSI3SSIOQZ3Aw5QfeJav+hUTEWQjz6VMS78ONhxngt8I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <12139bc0-57cd-e0a1-d487-40e61ebc0c96@amd.com> Date: Fri, 23 Sep 2022 09:33:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/9] automation: Add randconfig build jobs for arm64 alpine container Content-Language: en-US To: Stefano Stabellini CC: , Doug Goldstein References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-3-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000C402:EE_|DM4PR12MB6160:EE_ X-MS-Office365-Filtering-Correlation-Id: b34c9370-c171-4b00-5ff8-08da9d35f36c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0gO+SB3rMnH+Irrebsov+WwctB+mK14W62DiI/w2pV9d8JvTy/np3EKCjUtUViN8M85u9DHOyhAEnOOMISepCJP6bg59mntXwt1DxyFI6i29AHhQj0tl7p3TXwYMotrhp5uFtAsM2138ICKHoITF8yLi0D0C2A7uOUIP/ia2YQ7t8gj3DwcyQF6FVsrezG363WwY9vHnoIgulu66fKYvLFXF0Jj0HOvxv+eLgUvRWsVKPwrDpObb8SXk2ljlHTjMJDy4Uzs68v6ZqXTZD3dZWpJ1hsQYPEmqfPxSm9MJD0mlk7SLuxpvKVqxaE/pNB7CsMoKsMayb+mWhDbxiFSB+zxKbHTbb8ctGmjV5nf8iGdNh8lJzUXZAcjCFomRV+UOvECBowQl5mCaYAUtnFSqYBF3OkLNtwBlp1NxqHKkQ2CVUmxFgEoMVElciitBYBpxyhXyhxv2wOtNuJ2mdfYXF6VyvlO81y1kRPznXnv86Z6/U5I5HGyi2fr1dqEsehrZRDIu41eiUomSMkjT4QzP9Gi0hbdm7H6xhdEUTbfxLRdcFkLDE5Dk44BDt8DYUmyz6L69TsLW3cyyTEHq6svhD8QBztNw6xi4VaLACERGwNtRo+/rWaFrSP/h2JusK2iRL5S2bn5t/egGqr2RgPKqFHGHYr0f+YRBRAINGzDWWoosNwfH2+cesi5CZsEYiNRF3xMYYPAVGhnRk+jJ1luWajd1ezBL6TkeUduHU4D02SS/8tM5oOk8MlkCOV+8n5HA9mWmX64ZYqrNx4etnAKVzVIwrW1Ubol/FPcRXwMy3mmyC843ATNnVLMv1RjSCvOI0GRBPjTik1M8SDbK7G3xMg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(36840700001)(40470700004)(46966006)(47076005)(53546011)(2616005)(426003)(2906002)(4326008)(8676002)(36756003)(186003)(41300700001)(82740400003)(5660300002)(6666004)(8936002)(26005)(40460700003)(86362001)(82310400005)(356005)(40480700001)(81166007)(44832011)(31696002)(36860700001)(336012)(6916009)(31686004)(16576012)(54906003)(316002)(70586007)(478600001)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 07:33:46.8513 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b34c9370-c171-4b00-5ff8-08da9d35f36c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000C402.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6160 Hi Stefano, On 22/09/2022 23:42, Stefano Stabellini wrote: > > > On Thu, 22 Sep 2022, Michal Orzel wrote: >> For arm64 we perform builds using debian and alpine containers. >> We are missing the randconfig build jobs for the latter, so add them. >> This way for each container we have 4 fundamental build jobs: >> - defconfig non-debug/debug >> - randconfig non-debug/debug > > Should we have them also for Debian? The patch below looks fine. > We already have them for Debian. We were missing only the ones for Alpine. That is why I wrote that after this patch for each container we have 4 fundamental build jobs: DEBIAN: debian-unstable-gcc-arm64 debian-unstable-gcc-debug-arm64 debian-unstable-gcc-arm64-randconfig debian-unstable-gcc-debug-arm64-randconfig ALPINE: alpine-3.12-gcc-arm64 alpine-3.12-gcc-debug-arm64 alpine-3.12-gcc-arm64-randconfig alpine-3.12-gcc-debug-arm64-randconfig > >> Signed-off-by: Michal Orzel >> --- >> automation/gitlab-ci/build.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml >> index a39ed72aac6d..d931441b910a 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation/gitlab-ci/build.yaml >> @@ -566,6 +566,18 @@ alpine-3.12-gcc-debug-arm64: >> variables: >> CONTAINER: alpine:3.12-arm64v8 >> >> +alpine-3.12-gcc-arm64-randconfig: >> + extends: .gcc-arm64-build >> + variables: >> + CONTAINER: alpine:3.12-arm64v8 >> + RANDCONFIG: y >> + >> +alpine-3.12-gcc-debug-arm64-randconfig: >> + extends: .gcc-arm64-build-debug >> + variables: >> + CONTAINER: alpine:3.12-arm64v8 >> + RANDCONFIG: y >> + >> alpine-3.12-gcc-arm64-staticmem: >> extends: .gcc-arm64-build >> variables: >> -- >> 2.25.1 >> ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 23 07:44:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 07:44:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410638.653730 (Exim 4.92) (envelope-from ) id 1obdMJ-0006Dd-OI; Fri, 23 Sep 2022 07:44:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410638.653730; Fri, 23 Sep 2022 07:44:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdMJ-0006DW-KX; Fri, 23 Sep 2022 07:44:27 +0000 Received: by outflank-mailman (input) for mailman id 410638; Fri, 23 Sep 2022 07:44:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdMI-0006DQ-BO for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 07:44:26 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ad0c297-3b13-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 09:44:24 +0200 (CEST) Received: from DM6PR14CA0065.namprd14.prod.outlook.com (2603:10b6:5:18f::42) by DS7PR12MB5886.namprd12.prod.outlook.com (2603:10b6:8:79::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17; Fri, 23 Sep 2022 07:44:21 +0000 Received: from DM6NAM11FT109.eop-nam11.prod.protection.outlook.com (2603:10b6:5:18f:cafe::46) by DM6PR14CA0065.outlook.office365.com (2603:10b6:5:18f::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 07:44:21 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT109.mail.protection.outlook.com (10.13.173.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 07:44:21 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 02:44:20 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 23 Sep 2022 02:44:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ad0c297-3b13-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUK8NTrI7t6w8Hwu7TCAq96rA7L405hy3MlmFmHe59eFnQ4wnM0qX+RxBeYNoixrAGbUBR3gAPrD/Rg51tgMX4XF6IDDMVxJFwgSCS68Ji3Cctu3Ebr0R75TFrpr9g+h39HACKgmTEWW2ml/E0weVqumVsQhKpb6Eb/Kg+up5NvQF7Oq9yorKMitMULRPur/Vbimq+w8URP45Bt7cFhMSvvUoJGq7lpCRFXBIaue3uyaMiCCLrQ1KJozCPRhJv3lQ1rGjXiV4JWW9apE7NZogLezsi9+z1RFdhBc3qpuucbh8FZYE7aFYFrHMeUWSkztsR6m7i93VUVTbXfrDG3Pvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Os2vQ3DTgGcdZs4Q12QVtYakO9kEEaDsgBLkmsjjjwY=; b=Zj0m+IFf7fx3bYkf9KEhsDWZtZjSlJDB93Eel7+DLhJ6TIgWodLD3fr2HOsiytxlPKgztIqCqSugregWrQBLci4HG1gjR2NimOXBlMInCcVO3TYopamjJ1KlF+tVEgpwwMuddZEH2M6d9MHGejZnABO1RGDHny7jnGph8b8gqtSYFnqL+Zc6b/SW8ppNFigmyD5sJGo0d9JYKc/Q3gyFgtkwhC1G69U37L+/kN1zqxBayUPXDBqjpDCghJDBDaZ5wZo3LiorZbUgzej1Quy2n8gKKb+tstEwjcaK136v9Ksacs9+uElwsAhnYgu+G8mThChb/uef+CEKbbm7/xZaYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Os2vQ3DTgGcdZs4Q12QVtYakO9kEEaDsgBLkmsjjjwY=; b=E+5OMfyUXfqgvnR0xQvvBWc4YFH5aBgv2Xxr4vv+jkBasBNfUflkFBKYbjOhPTwtf3tGTUmDBv34skccZ/Cv4N7gTbA+r4aFGsCxYY4JuDNxiP8AcdrVnt87GvNXHEmRkooZ0716G6I9Pk8k59uGmMHQyi3HpmDc95fyPc3qSVc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <2ca7482d-65a9-8ac4-c6ad-2157a5d4f6b6@amd.com> Date: Fri, 23 Sep 2022 09:44:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 3/9] automation: Add debug versions of Arm tests Content-Language: en-US To: Stefano Stabellini CC: , Doug Goldstein References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-4-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT109:EE_|DS7PR12MB5886:EE_ X-MS-Office365-Filtering-Correlation-Id: 443f480d-6d13-4cdb-41a5-08da9d376dc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LCKDmqdxJWe4zvrp3K7ZHH7ZDBkI0xbFOH/HCtfkSnzsjri32Cl+Yc594BJbg6rsGKkt037N1ZaseH0u3J2u8n15iKtqoe3C2GG+OeI+Lh0aMo1MbVrwsv+d7aFIT0Qllh1KZjHnK5BBKfXytTmlQP3hQ7w/LRqkAKDaqiqZ2BNG4PF8ph5k2n6DfYhnIQjIfxzKINX6DRUu1HnUB5vAaZU5qEoTNf2Dzz4WMHryWNdChQ3JfNlxsC2xeiPU/xtgnVJoJTM2i8uvV76ghfEPjtoJDfwgwpSF0hrbHstddy7yOh3nEbunkbnVaKaJ+9BqwQs6BVb8h4DB/s00b3OiyQIhT/oR+65qkcLnO/ULKanpQBA4aHYGm8pi+JvxRwEv4sq7SMfdvwjkbwmTdIDwdkwj3F89qKN0P67H1l6I60HMTcQYa32RNFS/Nz/O0FG376XaRiy04xoj2z29sTd3iKePReV3alve0mMes4VY4s1Q0Q99IDMrWhZStQG2vhQbuQ6qH6k+qvW6bbMi/TS7UftPp0ClFj39qJn2v+B7Hp0o2A7gLud9BRByDD7vU28OLvcOxtKUZlroPD65HIbOkAjgO2OWNe1XwqZlAgqgAik+Gx40a6Wy+JyVboAa3F/i8cIATRfb2ykMTEv3Lu+SAarJ8Lyv6FPjr+s8tr/FuNChILQ61jVidZ9HmM2mvfww6uaNJFLmHDwZcaljWKRg8igh3cVmFJlvLxIZ9TMFg+sA4CtDXNWR8PKcxR2B2j6RcFgbh94fiVKA1Lv4RegFeRfrA29cqopuq7WfN10/xAI3N3JMmZXUFjYgaQIegR1VeACaHvu7ueKWFGDMf+gXYRUwAwKpNGhPBLYxApGyLPWqQA1MOJk4x1f3ifCdxvbals3gif0wdlN3aFVee9W45g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(316002)(31686004)(40480700001)(36860700001)(45080400002)(478600001)(356005)(54906003)(31696002)(4326008)(86362001)(8676002)(83380400001)(82740400003)(426003)(47076005)(36756003)(44832011)(70586007)(6916009)(966005)(26005)(41300700001)(81166007)(5660300002)(336012)(2906002)(8936002)(40460700003)(82310400005)(70206006)(2616005)(16576012)(53546011)(186003)(21314003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 07:44:21.5462 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 443f480d-6d13-4cdb-41a5-08da9d376dc2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT109.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5886 Hi Stefano, On 22/09/2022 23:53, Stefano Stabellini wrote: > > > On Thu, 22 Sep 2022, Michal Orzel wrote: >> At the moment, all the tests are executed on non-debug Xen builds. >> To improve the coverage (e.g. we might catch some asserts), add new >> test jobs using debug Xen builds. > > This is interesting. On one hand, I agree it is good to test DEBUG and > non-DEBUG builds in runtime tests too, on the other hand I am worried > about our test capacity. We still have plenty of capacity. We can add many more Arm tests because Arm machine is very powerful. I reckon that adding more x86 tests would have a performance impact but not the other way around. See below. > > I take you have tried a few pipelines -- are the additional tests > causing the pipeline to take longer? Do we still have "room" because x86 > is slower? What's your thinking? > With the additional tests introduced by this patch one cannot observe any impact for the performance. I ran several tests and the pipeline finishes in the same time or faster. Performance comparison: current master: 92 jobs (82 minutes, 19 seconds) master + my series: 103 jobs (79 minutes, 40 seconds) That said, let's improve the coverage and add these non-debug tests for Arm. > One idea would be to only do: > - qemu-alpine-arm64-gcc-debug > - qemu-smoke-arm64-gcc-debug > > and not the others > > >> Take the opportunity to increase RAM size for QEMU from 1GB to 2GB >> in qemu-smoke-arm64.sh as the debug builds take more space and we might >> end up in a situation when there is not enough free space (especially >> during a static memory test that reserves some region in the middle). >> >> Signed-off-by: Michal Orzel >> --- >> automation/gitlab-ci/build.yaml | 16 +++++ >> automation/gitlab-ci/test.yaml | 93 ++++++++++++++++++++++++++ >> automation/scripts/qemu-smoke-arm64.sh | 6 +- >> 3 files changed, 112 insertions(+), 3 deletions(-) >> >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml >> index d931441b910a..6ce92531f61f 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation/gitlab-ci/build.yaml >> @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: >> CONFIG_UNSUPPORTED=y >> CONFIG_STATIC_MEMORY=y >> >> +alpine-3.12-gcc-debug-arm64-staticmem: >> + extends: .gcc-arm64-build-debug >> + variables: >> + CONTAINER: alpine:3.12-arm64v8 >> + EXTRA_XEN_CONFIG: | >> + CONFIG_EXPERT=y >> + CONFIG_UNSUPPORTED=y >> + CONFIG_STATIC_MEMORY=y >> + >> alpine-3.12-gcc-arm64-boot-cpupools: >> extends: .gcc-arm64-build >> variables: >> @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: >> EXTRA_XEN_CONFIG: | >> CONFIG_BOOT_TIME_CPUPOOLS=y >> >> +alpine-3.12-gcc-debug-arm64-boot-cpupools: >> + extends: .gcc-arm64-build-debug >> + variables: >> + CONTAINER: alpine:3.12-arm64v8 >> + EXTRA_XEN_CONFIG: | >> + CONFIG_BOOT_TIME_CPUPOOLS=y >> + >> ## Test artifacts common >> >> .test-jobs-artifact-common: >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >> index 4f96e6e322de..1b51030c6175 100644 >> --- a/automation/gitlab-ci/test.yaml >> +++ b/automation/gitlab-ci/test.yaml >> @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: >> tags: >> - arm64 >> >> +qemu-alpine-arm64-gcc-debug: >> + extends: .test-jobs-common >> + variables: >> + CONTAINER: debian:unstable-arm64v8 >> + script: >> + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log >> + needs: >> + - alpine-3.12-gcc-debug-arm64 >> + - alpine-3.12-arm64-rootfs-export >> + - kernel-5.19-arm64-export >> + - qemu-system-aarch64-6.0.0-arm64-export >> + artifacts: >> + paths: >> + - smoke.serial >> + - '*.log' >> + when: always >> + tags: >> + - arm64 >> + >> qemu-alpine-x86_64-gcc: >> extends: .test-jobs-common >> variables: >> @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: >> tags: >> - arm64 >> >> +qemu-smoke-arm64-gcc-debug: >> + extends: .test-jobs-common >> + variables: >> + CONTAINER: debian:unstable-arm64v8 >> + script: >> + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log >> + needs: >> + - alpine-3.12-gcc-debug-arm64 >> + - alpine-3.12-arm64-rootfs-export >> + - kernel-5.19-arm64-export >> + - qemu-system-aarch64-6.0.0-arm64-export >> + artifacts: >> + paths: >> + - smoke.serial >> + - '*.log' >> + when: always >> + tags: >> + - arm64 >> + >> qemu-smoke-arm64-gcc-staticmem: >> extends: .test-jobs-common >> variables: >> @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: >> tags: >> - arm64 >> >> +qemu-smoke-arm64-gcc-debug-staticmem: >> + extends: .test-jobs-common >> + variables: >> + CONTAINER: debian:unstable-arm64v8 >> + script: >> + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log >> + needs: >> + - alpine-3.12-gcc-debug-arm64-staticmem >> + - alpine-3.12-arm64-rootfs-export >> + - kernel-5.19-arm64-export >> + - qemu-system-aarch64-6.0.0-arm64-export >> + artifacts: >> + paths: >> + - smoke.serial >> + - '*.log' >> + when: always >> + tags: >> + - arm64 >> + >> qemu-smoke-arm64-gcc-boot-cpupools: >> extends: .test-jobs-common >> variables: >> @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: >> tags: >> - arm64 >> >> +qemu-smoke-arm64-gcc-debug-boot-cpupools: >> + extends: .test-jobs-common >> + variables: >> + CONTAINER: debian:unstable-arm64v8 >> + script: >> + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log >> + needs: >> + - alpine-3.12-gcc-debug-arm64-boot-cpupools >> + - alpine-3.12-arm64-rootfs-export >> + - kernel-5.19-arm64-export >> + - qemu-system-aarch64-6.0.0-arm64-export >> + artifacts: >> + paths: >> + - smoke.serial >> + - '*.log' >> + when: always >> + tags: >> + - arm64 >> + >> qemu-smoke-arm32-gcc: >> extends: .test-jobs-common >> variables: >> @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: >> tags: >> - arm64 >> >> +qemu-smoke-arm32-gcc-debug: >> + extends: .test-jobs-common >> + variables: >> + CONTAINER: debian:unstable-arm64v8 >> + script: >> + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log >> + needs: >> + - debian-unstable-gcc-arm32-debug >> + - qemu-system-aarch64-6.0.0-arm32-export >> + artifacts: >> + paths: >> + - smoke.serial >> + - '*.log' >> + when: always >> + tags: >> + - arm64 >> + >> qemu-smoke-x86-64-gcc: >> extends: .test-jobs-common >> variables: >> diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh >> index f803835779f4..dea26c6c0a8f 100755 >> --- a/automation/scripts/qemu-smoke-arm64.sh >> +++ b/automation/scripts/qemu-smoke-arm64.sh >> @@ -52,7 +52,7 @@ curl -fsSLO https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fraw%2Fv5.2.0%2Fpc-bios%2Fefi-virtio.rom&data=05%7C01%7Cmichal.orzel%40amd.com%7Cf6b0b8fabb02478b009c08da9ce4eac9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994804254367719%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jgGdO93kLoieg6UqajFWYAsufvvv5mZVYHD%2B7fUW7ME%3D&reserved=0 >> ./binaries/qemu-system-aarch64 \ >> -machine virtualization=true \ >> -cpu cortex-a57 -machine type=virt \ >> - -m 1024 -smp 2 -display none \ >> + -m 2048 -smp 2 -display none \ >> -machine dumpdtb=binaries/virt-gicv2.dtb >> >> # XXX disable pl061 to avoid Linux crash >> @@ -117,7 +117,7 @@ cd .. >> >> # ImageBuilder >> echo 'MEMORY_START="0x40000000" >> -MEMORY_END="0x80000000" >> +MEMORY_END="0xC0000000" >> >> DEVICE_TREE="virt-gicv2.dtb" >> XEN="xen" >> @@ -158,7 +158,7 @@ timeout -k 1 240 \ >> ./binaries/qemu-system-aarch64 \ >> -machine virtualization=true \ >> -cpu cortex-a57 -machine type=virt \ >> - -m 1024 -monitor none -serial stdio \ >> + -m 2048 -monitor none -serial stdio \ >> -smp 2 \ >> -no-reboot \ >> -device virtio-net-pci,netdev=n0 \ > > The changes to qemu-smoke-arm64.sh make sense, but could you move them > to a separate patch in case we need to do any backports? Ok, I will do a prerequisite patch for that one. > > Also I would change MEMORY_END to 0xC0000000 in qemu-alpine-arm64.sh too > for uniformity. I already did that in patch [6/9] automation: qemu-alpine-arm64: Cleanup and fixes. ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 23 08:04:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 08:04:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410652.653741 (Exim 4.92) (envelope-from ) id 1obdfr-00013q-QL; Fri, 23 Sep 2022 08:04:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410652.653741; Fri, 23 Sep 2022 08:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdfr-00013j-Nm; Fri, 23 Sep 2022 08:04:39 +0000 Received: by outflank-mailman (input) for mailman id 410652; Fri, 23 Sep 2022 08:04:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdfq-00013d-Rs for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 08:04:38 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2074.outbound.protection.outlook.com [40.107.102.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d46cfa5-3b16-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 10:04:37 +0200 (CEST) Received: from DS7PR03CA0149.namprd03.prod.outlook.com (2603:10b6:5:3b4::34) by BL1PR12MB5109.namprd12.prod.outlook.com (2603:10b6:208:309::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 08:04:33 +0000 Received: from DM6NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b4:cafe::3b) by DS7PR03CA0149.outlook.office365.com (2603:10b6:5:3b4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 08:04:33 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT115.mail.protection.outlook.com (10.13.173.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 08:04:33 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 03:04:32 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 01:04:27 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 23 Sep 2022 03:04:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d46cfa5-3b16-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UMOnkmCIScaytb+ppBSjLWwOMwyQuEosvikM2Yoxdh7Q3H2FoAy2kDMkJOaFOZ9IRqz4RHVTwRppfLoyzAzJ7xb0nDeaUJaUreETlk7m9nIwYX/wUkUi9eCoB9zkdXBPWySChxDW6J0P+mJYrUJjgActZbwjsstsvV/+Z9Byif2NpV0zpSqao2SbpiteUlpULuUk+UtleQwyQTyY6FiMpcnflW7OZoRXRhJCExX8Gvl2PhtoxBlI4K5iaBT6rMKNY8Iku19Gyi5w970tK/lhNFTzswr5Kz0xOYd5Ywm0LOST1PFeMWu5tAJJFgGqwCLJUUWukB25wzT4usl7OldD3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=elVgYMLkUcavZyiFvELPr6QVQ/0eeYdOyU1DIRPP6BI=; b=B4mR/F7bsLzlL3hg03b1rGDliAoSh9snDnkm96tW51Q7T4Q6Js4E3IkK+YVZk0Y1ad/Vk6BYfnjUZEBV3zJDzH9wjfk1cBMATl9XZp+Fx6euadfwd7o6234F5hz90DRTM1DTel6j8HoIWVLWrflNsWXuf3A92wHxo6YAaS8kR5AEsmr+oy8ZbVXKCtypcuhDJ0wsjeddQLpQanZxOq6Eckb+8Ye9Y6nEMIfDs5kdG35zrHB2FZum3uJkMQDepgGwrAXPZ7fYr3ou8WrXntADiz/rsG4O1jKV8YJGW2JUYpgdb1Ov1GfUzfCJc19/+JeJED/KbsrYuvpfPOJzZCyylQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=elVgYMLkUcavZyiFvELPr6QVQ/0eeYdOyU1DIRPP6BI=; b=nJdr4fYk3LxREaajFyT1CIqSlzfx7ornfn8tGgb16UNuUwzQGlksUrrD1xTz0s7xbMUyjM34SzsfZBNmN4h/SXbiO9vASxvWF6LxBS9MFi1W38s8qK4eS0cZ+LOSwe4inFt8kpweXqy2Ha4uNt/Ghhh1yJ+Csj+JhgHGr9qRyY4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <69d8193b-12e2-459e-6921-e84f0f3775d7@amd.com> Date: Fri, 23 Sep 2022 10:04:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 5/9] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Content-Language: en-US To: Stefano Stabellini CC: , Doug Goldstein References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-6-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT115:EE_|BL1PR12MB5109:EE_ X-MS-Office365-Filtering-Correlation-Id: 648427ab-e212-4bd0-c383-08da9d3a4016 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K041UHhtVzdSSWRZM1FDVnhOa1QrT2w0ckp5dVpMUUd4T1JIaWQ0RjRLMUpJ?= =?utf-8?B?TzN0ejZ4dGJjalFveUpBc2VBMmYyWnl5ckZXRXF2SVNOT3RJdkVJdjJsdk5p?= =?utf-8?B?Zi9ncUE1MUVZRnc5bHoyVTFHVk5LNW0wY3dJUmlaMGZlNGNmRlRSS0NBb1Vx?= =?utf-8?B?T005dmNNVW1TRUp2cDBPOWlEUEpFUC9yUGwzekpmS1p2WmJlNERXSXZlemE3?= =?utf-8?B?SEppTklaNEZ2VEc5KzF6dDg0a0xmM2RGWGg3L2RpTW5BeWxqeEpWVGpZOGVx?= =?utf-8?B?TmxjdUtCUG5NMjlNTG94RFBJSCtPSHpCeGxuaFZyazFkcUlQVDNuVElJZW9N?= =?utf-8?B?NldCSHpjaE5XRFFLaHd3Y1pCLzhEUm11YndqbEYvNG8raEpzdHg3M2RvL3dR?= =?utf-8?B?VklOOVlubnVjT3g3R0c4eEkwcFRONDlqVGFmK2JFc0RxL0RWTmlFZ0x3eFA3?= =?utf-8?B?dE1IekxIakxOWHJSV2ZVaWZySWpNa3dXNW1jS3lxU2FxdmlLcjlsaFIyUHlx?= =?utf-8?B?UE9oRFJ5RDB6MVE3NTQyME9tazNnZjI5ZG5hQlhONFgxYUpENFgybUtlcjAr?= =?utf-8?B?TVdkV2FuZ09kUTQxS0RWL0N3VklQOGRwVFB5ZXJLOHJjMUJBSEhTTXFwd1dN?= =?utf-8?B?Q3VrTVBIV2NjMytkUUJZdXJ1SmgxTEJJeXVBcWlnZ0hFRkovd08raVJjQmd0?= =?utf-8?B?MDEyaUp4OVJzMGp0NGNmYjVhMDBnc0hIWUt1dnNMV2g1ajBxcGh5UlV0RWJ5?= =?utf-8?B?ZUEvNmIvVEhWa2k2NUE1Z1JKdEFmZU5NWEUvQm44Vyt3K2ZHcjlEQUpTUzFN?= =?utf-8?B?VlFWQWlCK3lyYmlUaG9xcElEdnZtc29KeUxUdzFzR2lSR2RFY2NIMGtVWFBK?= =?utf-8?B?c1dIcERCYWxXNm11UG5zUDNocE9hMmhLY0dYSC9lTTdNSXZPUDVnZElMUWg4?= =?utf-8?B?NUJDMjlub1oyTXRxK0hEU0pWaTlkM2lmUW5wb3VaaWxpa0ZqbFgrTXNnK0tp?= =?utf-8?B?cGk5YlJ6dFBiVU9ZSWNLWmhrUGk2V3pQTzZoUUZQQTFCZGRYVWZRdkZ3M3pK?= =?utf-8?B?dm10dmpQazludjJCb3o0ME1LaytycHpoeElFQ0M1MTZrbmQ3SHBtc203ZFEx?= =?utf-8?B?ZlRvc2I3Wks1eFNlQ2ZWdE9jdzZEbi9sSzNtRGlCL1RselRLbXFnSFNUYnkv?= =?utf-8?B?WUV4dkMxZ1AyNlFKUnpxSGdFVlB3bnlQNDVnR3pxUFcwVkNrUDN3NEFJYVFj?= =?utf-8?B?RVVmREtXTm5zR1kwSk5xY1dacmFhbWFEZlNsTmVMMDc1NzNVUT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(44832011)(2906002)(82310400005)(4326008)(8676002)(70206006)(8936002)(70586007)(41300700001)(5660300002)(966005)(16576012)(6916009)(36860700001)(186003)(40460700003)(54906003)(478600001)(2616005)(356005)(81166007)(45080400002)(316002)(53546011)(26005)(36756003)(83380400001)(31696002)(31686004)(82740400003)(86362001)(47076005)(336012)(426003)(40480700001)(21314003)(36900700001)(43740500002)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 08:04:33.4306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 648427ab-e212-4bd0-c383-08da9d3a4016 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5109 Hi Stefano, On 23/09/2022 00:13, Stefano Stabellini wrote: > > > On Thu, 22 Sep 2022, Michal Orzel wrote: >> Take an example from arm64 qemu test scripts and use ImageBuilder >> to generate u-boot script automatically. Calculating the addresses >> manually is quite error prone and also we will be able to benefit >> from using ImageBuilder when adding domUs to this test in the future. >> >> Install and use u-boot from the debian package. >> Modify the script so that binaries are loaded from u-boot via tftp. > > Great patch! It makes the test a lot better! > > >> Signed-off-by: Michal Orzel >> --- >> automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- >> 1 file changed, 27 insertions(+), 30 deletions(-) >> >> diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh >> index 530f3892fdd3..765facbe4d66 100755 >> --- a/automation/scripts/qemu-smoke-arm32.sh >> +++ b/automation/scripts/qemu-smoke-arm32.sh >> @@ -4,7 +4,9 @@ set -ex >> >> export DEBIAN_FRONTENT=noninteractive >> apt-get -qy update >> -apt-get -qy install --no-install-recommends device-tree-compiler \ >> +apt-get -qy install --no-install-recommends u-boot-qemu \ >> + u-boot-tools \ >> + device-tree-compiler \ >> curl \ >> cpio >> >> @@ -20,10 +22,6 @@ tar xvzf ../initrd.tar.gz >> find . | cpio -H newc -o | gzip > ../initrd.gz >> cd .. >> >> -kernel=`stat -L --printf="%s" vmlinuz` >> -initrd=`stat -L --printf="%s" initrd.gz` >> - >> -# For Xen, we need a couple of more node. Dump the DT from QEMU and add them >> # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded >> curl -fsSLO https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fraw%2Fv5.2.0%2Fpc-bios%2Fefi-virtio.rom&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd33d5c4c08934fac0cc208da9ce7a3fb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994815957091528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JuEapfYVLj5P3S5yY%2BAa47Nk4zgbdymjjsiUTmoTmyk%3D&reserved=0 >> ./qemu-system-arm \ >> @@ -36,31 +34,31 @@ curl -fsSLO https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fraw%2Fv5.2.0%2Fpc-bios%2Fefi-virtio.rom&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd33d5c4c08934fac0cc208da9ce7a3fb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994815957091528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JuEapfYVLj5P3S5yY%2BAa47Nk4zgbdymjjsiUTmoTmyk%3D&reserved=0 >> -display none \ >> -machine dumpdtb=virt.dtb >> >> -dtc -I dtb -O dts virt.dtb > virt.dts >> +# ImageBuilder >> +echo 'MEMORY_START="0x40000000" >> +MEMORY_END="0x80000000" >> + >> +DEVICE_TREE="virt.dtb" >> +XEN="xen" >> +DOM0_KERNEL="vmlinuz" >> +DOM0_RAMDISK="initrd.gz" >> +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" >> +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" > > This is missing dtuart=/pl011@9000000 compared to the original Actually this is not needed because we always have stdout-path defined in chosen to point to /pl011@... but I can add this. > > >> +NUM_DOMUS=0 >> + >> +LOAD_CMD="tftpb" >> +BOOT_CMD="bootm" > > "bootm" because "booti" is not available on arm32, right? Exactly. > > >> +UBOOT_SOURCE="boot.source" >> +UBOOT_SCRIPT="boot.scr"' > config >> >> -cat >> virt.dts << EOF >> -/ { >> - chosen { >> - #address-cells = <0x2>; >> - #size-cells = <0x2>; >> - stdout-path = "/pl011@9000000"; >> - xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0"; >> - xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh"; >> - dom0 { >> - compatible = "xen,linux-zimage", "xen,multiboot-module"; >> - reg = <0x0 0x1000000 0x0 $kernel>; >> - }; >> - dom0-ramdisk { >> - compatible = "xen,linux-initrd", "xen,multiboot-module"; >> - reg = <0x0 0x3200000 0x0 $initrd>; >> - }; >> - }; >> -}; >> -EOF >> -dtc -I dts -O dtb virt.dts > virt.dtb >> +rm -rf imagebuilder >> +git clone https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2FViryaOS%2Fimagebuilder&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd33d5c4c08934fac0cc208da9ce7a3fb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994815957091528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=i5N8DXMjn%2F80mdXtc%2FwDGJw6ImUrUAjOg0SJp9CkRdQ%3D&reserved=0 >> +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config >> >> rm -f smoke.serial >> set +e >> +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ >> timeout -k 1 240 \ >> ./qemu-system-arm \ >> -machine virt \ >> @@ -70,11 +68,10 @@ timeout -k 1 240 \ >> -serial stdio \ >> -monitor none \ >> -display none \ >> - -dtb virt.dtb \ >> -no-reboot \ >> - -kernel ./xen \ >> - -device loader,file=./vmlinuz,addr=0x1000000 \ >> - -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial >> + -device virtio-net-pci,netdev=n0 \ >> + -netdev user,id=n0,tftp=./ \ >> + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial >> >> set -e >> (grep -q "^/ #" smoke.serial) || exit 1 >> -- >> 2.25.1 >> ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 23 08:20:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 08:20:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410659.653752 (Exim 4.92) (envelope-from ) id 1obdvQ-0003lX-5b; Fri, 23 Sep 2022 08:20:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410659.653752; Fri, 23 Sep 2022 08:20:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdvQ-0003lQ-2t; Fri, 23 Sep 2022 08:20:44 +0000 Received: by outflank-mailman (input) for mailman id 410659; Fri, 23 Sep 2022 08:20:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obdvO-0003l4-Rx for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 08:20:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9cb7f47e-3b18-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 10:20:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 084851F86C; Fri, 23 Sep 2022 08:20:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E448713AA5; Fri, 23 Sep 2022 08:20:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DZVFNlhsLWP9BgAAMHmgww (envelope-from ); Fri, 23 Sep 2022 08:20:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cb7f47e-3b18-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663921241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n4AdOxgRV+RTXVRLhvM56GZZ0gqGziqhG/M4w1trrCg=; b=X+Qzs2iXkyw7W3M6vvUuTU33okiuol4W3U4G94B9EHBbu+0pNEG7sLz/shT0UJQJPZhDrT F1hQVyvKSm7xrGrdSfbA2kWVMmO9Xv2S88EI++16A0w43wcV96QBbj0iV3+TBSMkSLwkLb xlxkfLfBavXRHWQz3xtns9ypqPvygV0= Message-ID: Date: Fri, 23 Sep 2022 10:20:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: From: Juergen Gross Subject: Re: Design session PVH dom0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------QjsC1YmJi4Vl1R091dRCQYM1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------QjsC1YmJi4Vl1R091dRCQYM1 Content-Type: multipart/mixed; boundary="------------Prsalu08F1pm8DGmDmZqo87R"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: Subject: Re: Design session PVH dom0 References: In-Reply-To: --------------Prsalu08F1pm8DGmDmZqo87R Content-Type: multipart/mixed; boundary="------------CtbXZEJR33n7y0QryO006Pb0" --------------CtbXZEJR33n7y0QryO006Pb0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMDkuMjIgMTc6NTMsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN Cj4gU2Vzc2lvbiBkZXNjcmlwdGlvbiAoYnkgSmFuKToNCj4gSW4gdGhlIGNvdXJzZSBvZiB3 b3JraW5nIG9uIGFuIFhTQSBJIGhhZCB0byBmaW5hbGx5IGdldCBQVkggRG9tMCB3b3JrIG9u IGF0IGxlYXN0IG9uZSBvZiBteSBzeXN0ZW1zLCBpbiBhIG1pbmltYWwgZmFzaGlvbi4gVGhp cyBoYWQgdHVybmVkIHVwIGEgbnVtYmVyIG9mIGlzc3Vlcywgc29tZSBvZiB3aGljaCBoYXZl IHNpbmNlIHJlbWFpbmVkIHBlbmRpbmcuIFRoZXJlZm9yZSBJ4oCZZCBsaWtlIHRvIGdhaW4g dW5kZXJzdGFuZGluZyBvbiB3aGV0aGVyIHRoZXJlIGlzIGFueSBmdXR1cmUgdG8gdGhpcyBt b2RlIG9mIERvbTAgb3BlcmF0aW9uLCBhbmQgaWYgc28gd2hlbiBpdCBjYW4gYmUgZXhwZWN0 ZWQgdG8gYmUgYmV0dGVyIHRoYW4gdGVjaCBwcmV2aWV3IG9yIGV2ZW4ganVzdCBleHBlcmlt ZW50YWwuDQoNCi4uLg0KDQo+IErDvHJnZW46IFBWSCBkb20wIHBlcmZvcm1hbmNlPw0KPiAN Cj4gUm9nZXI6IGl0J3MgYmFkOyBtb3N0bHkgcmVsZXZhbnQgaXMgcWVtdSBpbnRlcmZhY2Vz DQo+IA0KPiBHZW9yZ2U6IG9ubHkgZm9yIHNhZmV0eSBjZXJ0aWZpY2F0aW9ucz8gcGVyZm9y bWFuY2UgcGVuYWx0eSBtYXkgYmUgb2theQ0KPiANCj4gSsO8cmdlbjogaHlwZXJjYWxscyBj YW4gYmUgaW1wcm92ZWQgKHZpcnR1YWwgYnVmZmVycz8pDQoNClNvbWUgbW9yZSB0aG91Z2h0 cyBvbiB0aGlzIHRvcGljOiBIYXZpbmcgaHlwZXJjYWxsIHZhcmlhbnRzIHdpdGggcGh5c2lj YWxseQ0KYWRkcmVzc2VkIGJ1ZmZlcnMgd2lsbCBoZWxwLCBidXQgdGhlcmUgaXMgYW4gYWRk aXRpb25hbCBjb21wbGV4aXR5OiB3aGF0DQphYm91dCBoeXBlcmNhbGxzIHdpdGggcmVhbGx5 IGxhcmdlIGJ1ZmZlcnMgKGUuZy4gdGhlIGJpdG1hcCBmb3IgbW9kaWZpZWQNCnBhZ2VzIGZv ciBndWVzdCBtaWdyYXRpb24pLiBJbiBvcmRlciB0byBhdm9pZCBoYXZpbmcgdG8gYWxsb2Nh dGUgaHVnZQ0KcGh5c2ljYWxseSBjb250aWd1b3VzIGJ1ZmZlcnMgZm9yIHRob3NlIHB1cnBv c2VzIHdlJ2QgcHJvYmFibHkgbmVlZA0Kc29tZXRoaW5nIGxpa2Ugc2NhdHRlci9nYXRoZXIg bGlzdHMgZm9yIGh5cGVyY2FsbCBidWZmZXJzLiBBbmQgdGhvc2UgbWlnaHQNCndhbnQgdG8g YmUgc3VwcG9ydGVkIGluIGEgZ2VuZXJpYyB3YXkuIEFkZGl0aW9uYWxseTogd2hhdCBpZiBz dWNoIGEgU0ctbGlzdA0Kd291bGQgZXhjZWVkIHRoZSBzaXplIG9mIGEgcGFnZT8gVGhlIGRp cnR5IGJpdG1hcCBvZiBhIGd1ZXN0IHdpdGggNjQgR0Igb2YNClJBTSB3b3VsZCBhbHJlYWR5 IG5lZWQgNTEyIHBhZ2VzLCBzbyB0aGUgU0ctbGlzdCBmb3IgdGhhdCBiaXRtYXAgd291bGQg YWxyZWFkeQ0KZmlsbCBhIGNvbXBsZXRlIHBhZ2UgYXNzdW1pbmcgb25seSA4IGJ5dGUgZm9y IG9uZSBTRy1lbnRyeSAod2hpY2ggd291bGQgbGltaXQNCnRoZSBnZW5lcmFsIHVzYWJpbGl0 eSBhbHJlYWR5KS4NCg0KTXkgZmF2b3JpdGUgc29sdXRpb24gd291bGQgYmUgc29tZSBraW5k IG9mIGJ1ZmZlciBhZGRyZXNzIHF1YWxpZmllciBmb3IgZWFjaA0KYnVmZmVyIChlLmcuIHZp cnR1YWwsIHBoeXNpY2FsLCBTRy1saXN0LCBtYXliZSBuZXN0ZWQgU0ctbGlzdCkuIFNvIHRo ZSBuZXcNCmh5cGVyY2FsbHMgd291bGQgbm90IG1lYW4gInBoeXNpY2FsIGJ1ZmZlciBhZGRy ZXNzZXMiLCBidXQgInF1YWxpZmllZCBidWZmZXINCmFkZHJlc3NlcyIuIEJ5IHJlcXVpcmlu ZyBhIG1pbmltdW0gb2YgNC1ieXRlIGFsaWdubWVudCBmb3IgZWFjaCBidWZmZXIgKGNhbiB3 ZQ0KZG8gdGhhdCwgYXQgbGVhc3QgZm9yIHRoZSBuZXcgaHlwZXJjYWxscz8pIHRoaXMgd291 bGQgbGVhdmUgdGhlIDIgbG93ZXN0IGJpdHMNCm9mIGEgYnVmZmVyIGFkZHJlc3MgZm9yIHRo ZSBuZXcgcXVhbGlmaWVyLiBJZiBieSBhbnkgbWVhbnMgYW4gdW5hbGlnbmVkIGJ1ZmZlcg0K aXMgbmVlZGVkIHNvbWV0aW1lcywgaXQgY291bGQgc3RpbGwgYmUgYWNoaWV2ZWQgdmlhIGEg c2luZ2xlLWVudHJ5IFNHLWxpc3QuDQoNCg0KSnVlcmdlbg0K --------------CtbXZEJR33n7y0QryO006Pb0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------CtbXZEJR33n7y0QryO006Pb0-- --------------Prsalu08F1pm8DGmDmZqo87R-- --------------QjsC1YmJi4Vl1R091dRCQYM1 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMtbFgFAwAAAAAACgkQsN6d1ii/Ey+1 awf/VYVH9gjCdTXVUhMnAewBRmi9gNPdLmpmuUnPMsJqJkdEjvLgg2MGHt3N0ONOjE207su1nu8p 1PVrCcCURcgJdcytZGp/ZGMlGx2ezUjuHBbZn+ma2mk2DSTaDnCU8m2xifo1Ts158hIL2BJkPpqm x3LpkdtN/hRrq/GzO/6ywyQu2apBVl1XbFO0YDfYWRu042lnuPYweqI8vqse1vRhiKVcIhK6TXES PB6SEwYJZbpFeyCVIQWZnzQ+paGNCOcZ2VMN5DzkqrsvjrKv3eFuvOTHP2+Sc2en2GzZvEYvyost hT9RZ/zsNS20Vz2pUsQaObIb9jmPcQtWHdJ2On0dLg== =aClv -----END PGP SIGNATURE----- --------------QjsC1YmJi4Vl1R091dRCQYM1-- From xen-devel-bounces@lists.xenproject.org Fri Sep 23 08:35:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 08:35:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410664.653762 (Exim 4.92) (envelope-from ) id 1obe9c-0005cZ-DX; Fri, 23 Sep 2022 08:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410664.653762; Fri, 23 Sep 2022 08:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obe9c-0005cS-Ay; Fri, 23 Sep 2022 08:35:24 +0000 Received: by outflank-mailman (input) for mailman id 410664; Fri, 23 Sep 2022 08:35:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obe9a-0005cM-Ns for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 08:35:22 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7fff4f1-3b1a-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 10:35:21 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Sep 2022 04:35:17 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5584.namprd03.prod.outlook.com (2603:10b6:a03:278::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 08:35:14 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.019; Fri, 23 Sep 2022 08:35:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7fff4f1-3b1a-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663922121; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=J6VzEWar2+vf4N6QfUJDG1PMjlsp1y2eNuU5dusljzY=; b=P0okAEL3eJchR8gZBlbc4Zyc0kGhZUIDi33KGL+h4UcYtf8BnT4sPSla S64G1XdrDggdkAAoGCFYxdS6XyT5qXhGvbXKj+2LPqBj8xgfnZ+/HWvMO l0nFtAGH1u38fo/s6hU9/ao1FhDP5K1DgqBNgx0iKrHyI4jaT2aPks27t I=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 81198973 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A7QUr9K9bOUaKmuVRkeURDrVtTnXE43xwBUUsX?= =?us-ascii?q?f1CW+u19neyolnKptwKyRlVrF5Zr7ATAcN/5KyuV8teGgRPYd6hq9398Xa1/?= =?us-ascii?q?0de1qSRicyJiLY5MfPlc5BIijHeKQ7a1hNCHo06NyRhVaM0AxRsi6XJydNRN?= =?us-ascii?q?0mtvJXySpaf4zP8F3A9I83Sh2xirToWCCTql0YQlFONVbp+yoH0Vrmub8fsN?= =?us-ascii?q?Ea9uVBIliZUpEWsGLCxk8UXKf8Dl0rHd51wgsC2mtODlPrly8mOVlEDknaU5?= =?us-ascii?q?f4myV/5Ak/n9sFtYfoXNtfQLycVlcOK4ZR5Iu1kcs1J/HQEwSbEJVOZsoD5K?= =?us-ascii?q?Qs33x5/dxXuM0L8N2dhGRpCgtlY2k2B+0DzCm2bZMaha7YsZ/aGg5c6sMFxc?= =?us-ascii?q?UTlCZc7VY08pn56fK4hGwv4tSpbbH5bQ0U++DW2fUMJwiFhyTytbLQNTnUJV?= =?us-ascii?q?fR16rKvv+HNJBmlcIrW5gsozbTNgrHI8lrzdxlkqtrUHFUemrTsdWqv2QvG/?= =?us-ascii?q?EG8QVjjcFloL4ZcuGYxsg+DuZx2b9MCOSP774abO7sIb2w73R0pufPQ+Nk26?= =?us-ascii?q?2MTxxdWaZprjwPGuAVWVSHjmvPGMW2/VXqA+DVix2YZG0q8YIKMbztnS8t3C?= =?us-ascii?q?DKFN3kaLmvIl0+H0IE5GT6a5/SiPELwwTAzcIWS43OMl/LJ9aO+q/YClV8Rd?= =?us-ascii?q?5dM9tKw41hrCqIqumlx63wzysPCWg1kumWK49Y5/SSjPoXSV8pPQ2q4UgPO7?= =?us-ascii?q?AWkJ2fmcYkKZGqCohyGgUd2cZvetcB5+yZosu8SsvYj+VaxNcLyvhB6EaIBa?= =?us-ascii?q?BeSUVXEkcRCBuewPG6yYj0qbwF2bKNVoY0tePIWqVtDrqGKJXH43Oj6XtKHg?= =?us-ascii?q?irXW13j8Pyq2Aa3GoUqKVTNKdZ4O3gj4FKFBKi1yYFxz7w2d1oMmMwG9CzIU?= =?us-ascii?q?o5DfiYMe0zR0OdcTevvDHjXHuRZcQhxxYsxxIkXgGFntkeX0RxYVg1PYYgfA?= =?us-ascii?q?Tb02i/cV4anlbCB9iA0FQWseWdpegR90cNYEqVUWV2j7bGO8KRrNecCMYFno?= =?us-ascii?q?oADzVUKjOlwNAuA6YrjG8aRJtHA4uu/tPfjxXBZxDrOlNEC1DYHtCZUxdzqU?= =?us-ascii?q?Wvemq/vk+xjhG9RETsepyTrQevNHHAFCHHYBn8AL1o651Fp/woOW8ETT97xh?= =?us-ascii?q?+4LtVrcebrQVmYlMfJQsMohR7GGXzXKYtQKM8UWXTEfpZzbnPap/rSC+149r?= =?us-ascii?q?VkG3gGOn/kU9IU0T1mhzfg+o6g76I5NorFW3l9jQJ6LCc8RWBL3zMMFobzk4?= =?us-ascii?q?iYC+F9Q/zwqrTHqKHusZAs/Ls+W1fr+7IQ2xA2gypdxo2a12dmekJIdLa5D8?= =?us-ascii?q?/JAkItKjmKaA8uaqTdpnInM4wzcoIS0ea/e46DSZxU1o5EgtFJjy1/jEcvjd?= =?us-ascii?q?U8VhEohX4pkBUBboivxkic5hAb+hZOMVMtTSChEx5/vrOGTyikKiFrM47A4G?= =?us-ascii?q?3MkF5FmHDMJI7IejWbdDl6C/jX3q5UMtXkd+PPeysnXadpwDzLtpINbtlL6G?= =?us-ascii?q?tnqriH2SfryQAkkd//V7wtvNRoUFAAf36iC593ndC1TgcRcHGRssOh5Id3pV?= =?us-ascii?q?FzAs/MeASQx5pkodj0r9+ZPWvjCy2L3eSnEkWY/6tApOwPXJ9PAJ7cfYPo4l?= =?us-ascii?q?gVe/InOMCIpLW3aKc6CH1NnlDMcG5YiO5bEqOuqejVDnnIB7RUOqqf293rxl?= =?us-ascii?q?7GmaO2FkibCZvfnukfcgdZPBA8SVFuUHN4E8uo6sesiIrlLjgXiqDGDIFbt7?= =?us-ascii?q?G69bPaKcLYLz4Jhd9SyDSw2z/+lXOmEc7v3wo/hIttz1JGCnPCr3iqWxy11E?= =?us-ascii?q?/OkAtsQ1DShE/ZQwm91H0HvcIce0bMin27QzqypAvAmgQb/vF/yVUPyWzI82?= =?us-ascii?q?2hH8aXkjrwd9VSicvvppNIe+pm830HZiiGe+vAhLDJ6eWe386lJtOQij8kzL?= =?us-ascii?q?lGd1bmPLSkCZ6SdLSuNT4ZKo/Ut2JnE5EenhlLkENdCtwVXp+qvsVjoqkwWc?= =?us-ascii?q?XgAv7Uyfk6Gibg7yZ/+P1DOayUl95QaBj9/xY1w3DIVP6x45JapsJBzvD9/e?= =?us-ascii?q?kDhuzOzrZ+LjEjMk477r0F2G6lv5++ULETJqDpGLldxFOSe0UsZsCkmXZmic?= =?us-ascii?q?KWq0DTjZawc58AP607mkIOmRDaslTBaVDw3znalK1+HQ/7ODqFu8mbD5iC0/?= =?us-ascii?q?MTeI2AJMFoaM6jEMpU0pZjMxHWNSQWpIwrLH8+WoyGYMXF95QnsbQynHuPk3?= =?us-ascii?q?WU0bdS15xG0hvqK1CL61Cj4ynH7CA9OlGsrzRhR8tdQxAoDtGN7amvK/pQOY?= =?us-ascii?q?Vvt+wIatXtRigeG6IM2oiKkKUVtWvc+olcXpQ1v033crmODxiCEp4RAKmTEf?= =?us-ascii?q?Uz8w6DRz3Qa1Hm37Jxou51Sd+pkxwN5M7KWXlSd0Uk2+cWJZbiYgeFgtJO1i?= =?us-ascii?q?Ai6UTwXtODQ+RRk8DvPf6JQg89Y9EIwU5T8ICF/TCDjaNM=3D?= X-IronPort-AV: E=Sophos;i="5.93,337,1654574400"; d="scan'208";a="81198973" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nUnRetdsv+VxtVFyZ4g5k2nXLewzSb+LwP9e0DgXPr8gF8pixLneQsJwyDZlLpIP0gYRVdJP9fUqArlEaft4liYf+WwRVweomZMv3JdoBroc4+tm7laEERgUZ04cKA4upVfxmIBwoMlMMOFiG+Z5fkg1TIu61ziGQPVJpJHP9Rdggcj+6LfLWD0YhxO4ILjRdjwQYQGza797SMvlTz8HXbfFt84TQeUQ2Xwy6Uih2UqtoB8MYUnbTWcEOZgmjiqJqMpSxzipvquFIE/tnJmlLxz9fYr1cmwFuxxjcW1I9+tocFu5j+ol7wbfLTc785ogLU6IBRdfzTYGw85IawQOsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kwPzf9yV1YlzC3age3SnMv40zKY7mzhu3g1z2TAeF7c=; b=gl8QoksCHTCj6DD0EGVrqPNc6pJOCj7fmsfjUF2dLfAjcsIPbvrMURI+L/3L09mqx6vdlJmxO2C8GsCqkBrnuE8jxxv0fSe/amqMXxBIDcO49mosPxWnLOZq5ceXnc0u5d5iGNRDnjhblLaol4aGdoP2vCh2GSO7+bBiJKEPGukrrPqpwgD1E2ah9xUteWH735GCobP3pZDVFYfAYr6mOKjWKpGZnsMOOLLdW0PvngwxqwNLrdL01C4O+mypHhGLipGO8C8Qj1Ve41vJZEFp7NEiAcGcwsEXqeP2Ovz8yCnOTll0J5TK0G+z0Fa2wV2Akr5+q8wuZcf+kFRX0ggPOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kwPzf9yV1YlzC3age3SnMv40zKY7mzhu3g1z2TAeF7c=; b=oeD1YsSgKsPLCTowVhg8kqL04OADrWQUCozOqI3hc3gvMRildRcneP6uOqQf8GcDzBdYehkdtT4Ht9JFXmqZJpcSKEFwcfnQbzGGLUxrgjTk5TLyZAmCSRCVnmwGrYkEAh0jaLjgflxy3qZAhzw0viXpNJOXzwLZSSkTW75QRlI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 23 Sep 2022 10:35:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220922160516.5929-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0060.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::24) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5584:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c9c6721-3a3c-48be-e33d-08da9d3e890e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oZ55/0jLJlbdXfkdn3vwaxl8Wa8QYuWg+rey78xBqFl3qUMpJgI6dZJUaB735Yc7MFAJ9yEpFoJsAUraeCLZPT69SQBJlhUkcEs+vgUgsRGpk3wTxHM0xl5doFxrssltY5Cf0Z7zqEgxrz6uGFKLKfXJMJUI7o1/BKPalNaafw6z+8QqgGmIWRjfzkQuj/9hnqdnJ69/hSBLasRLcXByqya9r8EkbGGewNmM1MLfIjuXv7fLM+jzMeUOxsK5gdK6jXNrJA6aCJvNmXKgZ6KVvSFtSYLHgRxGQVXG5F15rbz7wX+MZ+SPX6f9Y+74ZLee6uJHfrzkeJ0O2N6QcokHthR6JWMLr4lFNw8J4UmANbSKEKsafzx4YjhvInayQf0cJYuLrcmRQZu9qJ4bU/bNiN+Ip1K5McHIPyyhAcAsb1AqRX6ymylupB2EQcXeylooj6Z6eMB3qjJ3IZP4jKFC5+IlqaqeYdxqf5qD01z5ZuoeFeULJlaf89AmbfD2GgWuOOkvYKR9DPapE4YYzjr+f/wWY2wopICOJ2vpmDtdxQ4xesO2CMPXWsZWQqtb4snunhjKE5VH2rW4NL9mX6RcnkBJjdKyDiEgx7+J8N2tQd7Oti3UIEL6/78UKQwc7gM0cU0ED48lWyfZlbrohYqpzZSRRILRu/LAMPN6IYpB457azpOZ1BUsC9MGaRULE3QXed//AiICwlmOpNcWrvRXkw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(54906003)(6916009)(53546011)(6506007)(2906002)(66476007)(316002)(83380400001)(66556008)(66946007)(186003)(38100700002)(41300700001)(4326008)(8676002)(6666004)(86362001)(6486002)(5660300002)(85182001)(478600001)(6512007)(26005)(9686003)(82960400001)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm1tcjVtTWdmVXIvQVdZL3ZRaExJdWpVV3IyZXVwOFpSa0dUWnY4K0dEUXJa?= =?utf-8?B?UGp6VThXZE9HcnBuM3JqSkhRNmt3N2kyQmlBZklDdTRnUjNyMlNGVnA4Vm1U?= =?utf-8?B?Z2xpRlNTcGFCN0s5dDd0SHBNb2tQNnlqU0F5L1hCL0hxdWN2aExXK054UlJE?= =?utf-8?B?UmlqL2R0QXI1b2JrYlBoSjdhMlFZT2lyT0h0WHloNm9NYjNRWHNDVDRFSlZH?= =?utf-8?B?NW9oQXRVTXZRcVJKdHBxM0poQk5CaFl0UEhBRjJjWnFDczVSY2F3TEFQZ2xa?= =?utf-8?B?SnovakpvajJxSklNSmZFVlhiMVhhZmtLSUVJazZ0UTdKWnVEM1I4cVRTNE9P?= =?utf-8?B?d3VSQXQwWGdYR21MWFpZeW4zL2YwalVBb3FEY0tFYnliQnJqM0tQMVllazRn?= =?utf-8?B?YmROOUtMRkdxbmlDQjkrd1dxR0RaeGhYTlFxQkk4RlJWbTROR1ZEV3NueEVp?= =?utf-8?B?VVhhYmtYWXVCSmNEYUxSVzZoUU5Pbk1TZ0ZJdFdwdWxWTFVRZGU0QUNYQ1hx?= =?utf-8?B?WmdGU3IwOWRMcFhWamdzQ1FYU3dSeEVZdmtieDY0NGxwSjNvcm9LaEFsZmVG?= =?utf-8?B?ejF4cUVPSlphbGpGaGNYYzZiQklkaFh0bnlWdGk1VjVaMkZjT3FmbHZUdkxX?= =?utf-8?B?UHpZZ0ZWalZVVUlIYk96M1FvMHV4bGdpWWRNZ3F6TGJyemZmSGRJM3ZsNENj?= =?utf-8?B?LzV0MG5EeEJGQXZhWndYUW4xTW1qU05HakV1RGJmNy8vZXpCcXlrbTZQQzV2?= =?utf-8?B?YjB0VjdOZlk4WXNmdWFtWGtPKzkxdEJIS0FHck04Uy9aKyt1Vis4bXcxNjFF?= =?utf-8?B?YmRxRHp1TjhWMlBOeDJzRzhmTkphWitvMHQ2N3RUd0hyOW9PbkNERkt1aE52?= =?utf-8?B?ZEtMcHdIMXZtbm94MDNaNUU1RVZmenYwbWp0RVB0VldVdTlnb3MvU3dFVktQ?= =?utf-8?B?TzFDMFRZQ0h3Z1VQSzZUSnJYZHZvQndzOHlRaTc0bllhUVhaSzU0SlFObVhU?= =?utf-8?B?bWlDK3lYZFMvSUd4Zm9UejdkL0VUaUhXQXhtaHZmNlY4QTkxY3hoRi9TVGJ0?= =?utf-8?B?ZTU5djRDRUwraitzS2JsdEYvSXptYU9MM0F0ZEl3bVJtT2Rkcm9mSjV2UHhH?= =?utf-8?B?ZzNHa1cwNUdjVUg0WFpsSy93NGxma0Y5WXRwZHQ5dnBBQU5uNUJMNXhidU5H?= =?utf-8?B?c1dSN0E4K2JPOU5TYTcxN1IwdndFT2ZGZ3BTZitNdXZWbnA4ZmJNQVBHQ2xj?= =?utf-8?B?ZUpvdldrUVJzaysrbmFnemJId2s5ZWZzeStscUdYVTRXMTg5QldGM21jS0I0?= =?utf-8?B?VENDcDJMaDdnTFgrdUJDcUFpQlNKZytNbzRCUFBrWU8rblNIUmNZKzFpbERr?= =?utf-8?B?RFRRREhNMS8xRVpaVkZGbjAxUDJZTHZYeHROazhadUVhMXNDWjhYcEVCdklY?= =?utf-8?B?YlJjUktzQXp1a1NhSjJXOTVxVmlNUUZ2aUNSNHQrTG1BUk0yMXpXd3VQNFRE?= =?utf-8?B?eE16ZmdxcGYzbVJWRDhTSFhxdjFpUUFEOVM0MldBelFQYThGK1Q4VzN6T2xx?= =?utf-8?B?WkpHOVhTSHhWb3d6ejVNSlVhc0hVQnN1OVRrL0FSTHR2Mk14aTRvVFVGc0tX?= =?utf-8?B?R2xEc2JhSzBmRFZEZTQ1N24wTXRiYlR2aHdiSU9FNGdlVVcxazR0eHBpUTJ2?= =?utf-8?B?blVMZWN0S2NJNnhZZlFhazI0Q3ZEMGROdmU0VElnVlV4NE90YmNScUgyZTM3?= =?utf-8?B?ZmxsOXNNYlBjU1NudW5STGRtWlVGSUJaNDRCeEd3aTFiSDRYNnRLTVJVeFdn?= =?utf-8?B?bHd1dldlODdjeHVZMHI2TW1wcjRFaE5Ua0oxLysvM09Zb1Bpd09tK1VveTNw?= =?utf-8?B?bklWZHRrR3FzdFVxQjNtZlZvOEZMWDF0ZkphQTBXbHVHbTNwU0VoTU5tUGhn?= =?utf-8?B?RHhFeURxdk5aWnZtRVpNNWh4MWxGVWxUMjZJdjdZWktTU2ZPMktvamdyRkhy?= =?utf-8?B?MnNvaFRwUUVydEpkcjZxUVpMOVNGbnIvVkdTajRXdDRWeXgwYm51bE0zdWN4?= =?utf-8?B?N0pla05WMTZySUhKWFNGZ29GSVNuOG52U0p1TE5PbzNqUS8rbVBKdmZ0V0J5?= =?utf-8?B?VFBKekJmenEyTDJaSFM3V1Q3QlZhOUZCc0d5THZSUmpjZUk1OXNDS2ZnQlU2?= =?utf-8?B?bkE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9c6721-3a3c-48be-e33d-08da9d3e890e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 08:35:14.7412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H0wCe5z2rZhmq4MRibEtLqgnN0u0ZGfgtEUvxpe5dMBDPXzJB4WWroCmkm2/Xaq/jBb6C6w7QnzDKJjzUUqcSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5584 On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > On 22.09.2022 18:05, Roger Pau Monne wrote: > > memory_type_changed() is currently only implemented for Intel EPT, and > > results in the invalidation of EMT attributes on all the entries in > > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > > when the guest tries to access any gfns for the first time, which > > results in the recalculation of the EMT for the accessed page. The > > vmexit and the recalculations are expensive, and as such should be > > avoided when possible. > > > > Remove the call to memory_type_changed() from > > XEN_DOMCTL_memory_mapping: there are no modifications of the > > iomem_caps ranges anymore that could alter the return of > > cache_flush_permitted() from that domctl. > > I certainly agree - this was an oversight when the two aspects were > split. One might argue this is a (performance) fix to the earlier > commit, and hence might want to go on its own with a Fixes: tag. Was wondering myself, didn't add the 'Fixes:' tag because of the extra content. > > Calls to memory_type_changed() resulting from changes to the domain > > iomem_caps or ioport_caps ranges are only relevant for EMT > > calculations if the IOMMU is not enabled, and the call has resulted in > > a change to the return value of cache_flush_permitted(). > > I'm less certain here: These shouldn't be frequent operations, so > their impact on the guest should be limited? Citrix has an use case for vGPU where IOMMU regions are added and removed during guest runtime. Such functionality makes uses of both XEN_DOMCTL_iomem_permission and XEN_DOMCTL_memory_mapping. While the memory_type_changed() call in XEN_DOMCTL_memory_mapping seems to be the most problematic performance wise, I though it was nice to try to avoid memory_type_changed() as much as possible, as those tax the guest quite heavily with EPT_MISCONFIG faults and the recalculation logic. > And if we were to restrict the calls, I think we need to clearly > tie together the various places which need updating together in > case e.g. the condition in epte_get_entry_emt() is changed. > Minimally by way of comments, but maybe by way of a small helper > function (for which I can't seem to be able to think of a good > name) sitting next to epte_get_entry_emt(). Such helper function is also kind of problematic, as it would have to live in p2m-ept.c but be used in domctl.c and x86/domctl.c? It would have to go through the p2m_domain indirection structure. Do you have any suggestions about how the function should look like? I'm afraid the fact it needs the previous cache_flush_permitted() value makes it kind of weird to encapsulate. I've attempted to add comments to make it clear why the new checks are added, but I would also need to add a comment to epte_get_entry_emt() to notice changes in the condition need to be propagated to call sites of memory_type_changed(). > > Signed-off-by: Roger Pau Monné > > --- > > I feel it's a bit weird to have calls to memory_type_changed() in > > common domctl code - for once the domctl that trigger the call doesn't > > change memory types, just adds or removes ranges from iomem_caps > > (which in turn affects the behaviour of epte_get_entry_emt()). > > Do you have a better suggestion? No, not really, because we need the return value of cache_flush_permitted() before and after the changes, so it's not as easy as introducing a single helper sadly. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 23 08:40:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 08:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410670.653774 (Exim 4.92) (envelope-from ) id 1obeED-00072N-TP; Fri, 23 Sep 2022 08:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410670.653774; Fri, 23 Sep 2022 08:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obeED-00072G-QW; Fri, 23 Sep 2022 08:40:09 +0000 Received: by outflank-mailman (input) for mailman id 410670; Fri, 23 Sep 2022 08:40:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obeED-00072A-9e for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 08:40:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51d5564f-3b1b-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 10:40:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA0F61F8F8; Fri, 23 Sep 2022 08:40:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 87BE413AA5; Fri, 23 Sep 2022 08:40:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WKTDH+dwLWOFDwAAMHmgww (envelope-from ); Fri, 23 Sep 2022 08:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51d5564f-3b1b-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663922407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=rHriJ3NiytpyFePfxwPTupKD7kpksa8DfqgHNohg5XY=; b=qBhdPuZMJvpGdI1lyEB4pOocaOy1Ou/vvUOqh3djGykOdY5oW8WV0vNbdP0/UW3Zonnf+s 06GdKAKed1rqO3QguSUqrgm61XairkzRS9PSIOYj4OBTt6WeSpJfekCXVU7A7T7k5A3yFX 8GgZtsqQBDX67HThGEspy/dci6Y6Nm8= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v6.0-rc7 Date: Fri, 23 Sep 2022 10:40:07 +0200 Message-Id: <20220923084007.22001-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc7-tag xen: branch for v6.0-rc7 It contains only a single fix for an issue in the xenbus driver (initialization of multi-page rings for Xen PV devices). Thanks. Juergen drivers/xen/xenbus/xenbus_client.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Juergen Gross (1): xen/xenbus: fix xenbus_setup_ring() From xen-devel-bounces@lists.xenproject.org Fri Sep 23 09:27:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 09:27:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410678.653785 (Exim 4.92) (envelope-from ) id 1obey5-0003q6-Ir; Fri, 23 Sep 2022 09:27:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410678.653785; Fri, 23 Sep 2022 09:27:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obey5-0003pz-GD; Fri, 23 Sep 2022 09:27:33 +0000 Received: by outflank-mailman (input) for mailman id 410678; Fri, 23 Sep 2022 09:27:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obey4-0003pp-IA; Fri, 23 Sep 2022 09:27:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obey4-0006iq-Fz; Fri, 23 Sep 2022 09:27:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obey4-0008SV-4u; Fri, 23 Sep 2022 09:27:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obey4-0004RM-4T; Fri, 23 Sep 2022 09:27:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eYXOB++OVxjvSZGqolmShyPZ4WkUqBbw36GM8Z3qMb4=; b=b5weyxxC39i7Q6FHXZeX5FijeF O1YcEUIMYZ5MwUqKzg7KHzA/hpRmdLlI5yYt0Gij7FDXP969kElp74Haln9XXNr9TRZPfYL57y7Vj wz72VNYLF26la4XdnulOLRvBs5XrCAu5wpRIykIAw7KZOdANEF+21j2LKkmbZi+eXr+c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173288: all pass - PUSHED X-Osstest-Versions-This: ovmf=b19793a2ec6466c04e5e3506fbe82038fb0a885f X-Osstest-Versions-That: ovmf=238f5f95448c0cbffab5532b21bc4d5f27cf1cee From: osstest service owner Date: Fri, 23 Sep 2022 09:27:32 +0000 flight 173288 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173288/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b19793a2ec6466c04e5e3506fbe82038fb0a885f baseline version: ovmf 238f5f95448c0cbffab5532b21bc4d5f27cf1cee Last test of basis 173286 2022-09-23 02:58:06 Z 0 days Testing same since 173288 2022-09-23 07:43:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Qi Zhang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 238f5f9544..b19793a2ec b19793a2ec6466c04e5e3506fbe82038fb0a885f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 09:31:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 09:31:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410685.653796 (Exim 4.92) (envelope-from ) id 1obf2D-0005FA-3m; Fri, 23 Sep 2022 09:31:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410685.653796; Fri, 23 Sep 2022 09:31:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obf2D-0005F3-15; Fri, 23 Sep 2022 09:31:49 +0000 Received: by outflank-mailman (input) for mailman id 410685; Fri, 23 Sep 2022 09:31:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obf2C-0005Ex-0X for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 09:31:48 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ae3e87b-3b22-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 11:31:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0DE2421A8D; Fri, 23 Sep 2022 09:31:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D7CE913A00; Fri, 23 Sep 2022 09:31:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pyweMwF9LWNzJgAAMHmgww (envelope-from ); Fri, 23 Sep 2022 09:31:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ae3e87b-3b22-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663925506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O8FY9JqAfn68IbNwMJt/N2gsC3g3p4YRW9JkJYPZXLU=; b=V/ReSIcyTicu7Ci4E5f0XUDUd+PLIpXSXTWrYmd3yTfrNevvoXDZzP4Z/RJbNJVQTFXXRQ bID/Syja8xMjxpcwdK9Zi0zqyl/dYRcYnid49rvKxWmMEIAq6aamH8DW/nroHimDPmAWIJ T+/yeJYlMRPDy4nq0RmLrpZTilIi73A= Message-ID: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> Date: Fri, 23 Sep 2022 11:31:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: From: Juergen Gross Subject: Re: Design session "grant v3" In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------7LmrTJdUnPE94qJcLK9cj0y0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------7LmrTJdUnPE94qJcLK9cj0y0 Content-Type: multipart/mixed; boundary="------------0lzFpw34me55u2J4Qms0uoJI"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> Subject: Re: Design session "grant v3" References: In-Reply-To: --------------0lzFpw34me55u2J4Qms0uoJI Content-Type: multipart/mixed; boundary="------------ufNZuJ0QPnEutYhAwmBg0O6M" --------------ufNZuJ0QPnEutYhAwmBg0O6M Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjIuMDkuMjIgMjA6NDMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMi4wOS4yMDIy IDE1OjQyLCBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+PiBKw7xyZ2Vu OiB0b2RheSB0d28gZ3JhbnRzIGZvcm1hdHMsIHYxIHN1cHBvcnRzIG9ubHkgdXAgdG8gMTZU QiBhZGRyZXNzZXMNCj4+ICAgICAgICAgIHYyIHNvbHZlcyAxNlRCIGlzc3VlLCBpbnRyb2R1 Y2VzIHNldmVyYWwgbW9yZSBmZWF0dXJlc15XYnVncw0KPj4gICAgICAgICAgdjIgaXMgMTYg Ynl0ZXMgcGVyIGVudHJ5LCB2MSBpcyA4IGJ5dGVzIHBlciBlbnRyeSwgdjIgbW9yZSBjb21w bGljYXRlZCBpbnRlcmZhY2UgdG8gdGhlIGh5cGVydmlzb3INCj4+ICAgICAgICAgIHZpcnRp byBjb3VsZCB1c2UgcGVyLWRldmljZSBncmFudCB0YWJsZSwgY3VycmVudGx5IHZpcnRpbyBp b21tdSBkZXZpY2UsIHNsb3cgaW50ZXJmYWNlDQo+PiAgICAgICAgICB2MyBjb3VsZCBiZSBh IGdyYW50cyB0cmVlIChsaWtlIGlvbW11IHBhZ2UgdGFibGVzKSwgbm90IGZsYXQgYXJyYXks IHNlcGFyYXRlIHRyZWVzIGZvciBlYWNoIGdyYW50ZWUNCj4+ICAgICAgICAgIGNvdWxkIHN1 cHBvcnQgc2hhcmluZyBsYXJnZSBwYWdlcyB0b28NCj4+ICAgICAgICAgIGVhc2llciB0byBo YXZlIG1vcmUgZ3JhbnRzLCBjb250aW51b3VzIGdyYW50IG51bWJlcnMgZXRjDQo+PiAgICAg ICAgICB0d28gb3B0aW9ucyB0byBkaXN0aW5ndXNoIHRyZWVzIChmcm9tIEhWIFBvVik6DQo+ PiAgICAgICAgICAtIHNoYXJpbmcgZ3Vlc3QgZW5zdXJlIGRpc3RpbmN0IGdyYW50IGlkcyBi ZXR3ZWVuIChtdWx0aXBsZSkgdHJlZXMNCj4+ICAgICAgICAgIC0gaHYgdGVsbHMgZ3Vlc3Qg aW5kZXggdW5kZXIgdHJlZSBnb3QgcmVnaXN0ZXJlZA0KPj4gICAgICAgICAgdjMgY2FuIGJl IGFkZGl0aW9uIHRvIHYxL3YyLCBvbGQgdXNlZCBmb3Igc2ltcGxlciBjYXNlcyB3aGVyZSB0 cmVlIGlzIGFuIG92ZXJraWxsDQo+PiAgICAgICAgICBoeXBlcnZpc29yIG5lZWRzIGV4dHJh IG1lbW9yeSB0byBrZWVwIHJlZmNvdW50cyAtIHJlc291cmNlIGFsbG9jYXRpb24gZGlzY3Vz c2lvbg0KPiANCj4gSG93IHdvdWxkIHJlZmNvdW50cyBiZSBkaWZmZXJlbnQgZnJvbSB0b2Rh eT8gUGVyaGFwcyBJIGRvbid0IGhhdmUgYSBjbGVhcg0KPiBlbm91Z2ggcGljdHVyZSB5ZXQg aG93IHlvdSBlbnZpc2lvbiB0aGUgdHJlZS1saWtlIHN0cnVjdHVyZShzKSB0byBiZSB1c2Vk Lg0KDQpXaGF0IHdhcyBtZWFudCBoZXJlIGFyZSB0aGUgYWRkaXRpb25hbCByZXNvdXJjZXMg dGhlIGh5cGVydmlzb3Igd2lsbCBuZWVkIGZvcg0KaGlnaGVyIGdyYW50IGNvdW50cyBvZiBh IGd1ZXN0LiBXaXRoIHRoZSB0cmVlIGFwcHJvYWNoIHRoZSBudW1iZXIgb2YgZ3JhbnQNCmZy YW1lcyB3aWxsIGJlIGJhc2ljYWxseSBjb250cm9sbGVkIGJ5IHRoZSBndWVzdCBhbmQgaW1w b3NpbmcgYSBsaW1pdCBsaWtlDQp0b2RheSB3b3VsZG4ndCB3b3JrIHZlcnkgd2VsbCAoZXNw ZWNpYWxseSB3aXRoIHRoZSBjdXJyZW50IGRlZmF1bHQgb2Ygb25seQ0KNjQgZ3JhbnQgZnJh bWVzKS4NCg0KPiANCj4+ICAgICAgICAgIGh2IGNvdWxkIGhhdmUgVExCIHRvIHNwZWVkdXAg bWFwcGluZw0KPj4gICAgICAgICAgaXNzdWUgd2l0aCB2MS92MiAtIGdyYW50ZXIgY2Fubm90 IHJldm9rZSBwYWdlcyBmcm9tIHVuY29vcGVyYXRpbmcgYmFja2VuZA0KPj4gICAgICAgICAg dHJlZSBjb3VsZCBoYXZlIHNwZWNpYWwgcGFnZSBmb3IgcmV2b2tpbmcgZ3JhbnRzIChyZWRp cmVjdCB0byB0aGF0IHBhZ2UpDQo+PiAgICAgICAgICBzcGVjaWFsIGRvbWlkcywgbG9jYWwg dG8gdGhlIGd1ZXN0LCB0b29sc3RhY2sgcmVzdGFyaW5nIGJhY2tlbmQgY291bGQgcmVxdWVz dCB0byBrZWVwIHRoZSBzYW1lIHZpcnR1YWwgZG9taWQNCj4+IE1hcmVrOiAgdGhhdCByZXF1 aXJlcyBzdGF0ZWxlc3MgKG9yIHJlY292ZXJhYmxlKSBwcm90b2NvbCwgcmV1c2luZyBkb21p ZCBjdXJyZW50bHkgY2F1c2VzIGlzc3Vlcw0KPj4gQW5kcmVpOiBob3cgcmV2b2tpbmcgY291 bGQgd29yaw0KPj4gSsO8cmdlbjogdGhlcmUgbmVlZHMgdG8gYmUgaHlwZXJjYWxsLCByZXBs YWNpbmcgYW5kIGludmFsaWRhdGluZyBtYXBwaW5nIChzY2FuIHBhZ2UgdGFibGVzPyksIHBv c3NpYmx5IGFkanVzdGluZyBJT01NVSBldGM7IG1heSBmYWlsLCBwcm9ibGVtYXRpYyBmb3Ig UFYNCj4gDQo+IFdoeSB3b3VsZCB0aGlzIGJlIHByb2JsZW1hdGljIGZvciBQViBvbmx5PyBJ biBwcmluY2lwbGUgYW55DQo+IG51bWJlciBvZiBtYXBwaW5ncyBvZiBhIGdyYW50IGFyZSBw b3NzaWJsZSBhbHNvIGZvciBQVkgvSFZNLiBTbw0KPiBhbGwgb2YgdGhlbSB3b3VsZCBuZWVk IGZpbmRpbmcgYW5kIHJlcGxhY2luZy4gQmVjYXVzZSBvZiB0aGUNCj4gbXVsdGlwbGUgbWFw cGluZ3MsIHRoZSBNMlAgaXMgb2Ygbm8gdXNlIGhlcmUuDQoNCkl0IGlzIGFuIGFkZGl0aW9u YWwgbGF5ZXIgaW4gdGhlIFBWIGNhc2U6IGV2ZW4gd2hlbiBtYXBwaW5nIGEgZm9yZWlnbg0K cGFnZSB0byBvbmx5IGEgc2luZ2xlIGxvY2FsIFBGTiB0aGVyZSBjb3VsZCBiZSBtdWx0aXBs ZSBQVEVzIHJlZmVyZW5jaW5nDQppdC4NCg0KSSBkaWRuJ3QgdGhpbmsgb2YgdGhlIHByb2Js ZW0gZG9pbmcgbXVsdGlwbGUgbWFwcGluZ3Mgb2YgdGhlIHNhbWUgZ3JhbnQuDQpJIHdpbGwg bG9vayBpbnRvIHRoYXQuDQoNCj4gV2hpbGUgdGhpbmtpbmcgYWJvdXQgdGhpcyBJIHN0YXJ0 ZWQgd29uZGVyaW5nIGluIGhvdyBmYXIgdGhpbmdzDQo+IGFyZSBhY3R1YWxseSB3b3JraW5n IGNvcnJlY3RseSByaWdodCBub3cgZm9yIGJhY2tlbmRzIGluIFBWSC9IVk06DQo+IEFueSBt YXBwaW5nIG9mIGEgZ3JhbnQgaXMgaGFuZGVkIHRvIHAybV9hZGRfcGFnZSgpLCB3aGljaCBp bnNpc3RzDQo+IG9uIHRoZXJlIGJlaW5nIGV4YWN0bHkgb25lIG1hcHBpbmcgb2YgYW55IHBh cnRpY3VsYXIgTUZOLCB1bmxlc3MNCj4gdGhlIHBhZ2UgaXMgYSBmb3JlaWduIG9uZS4gQnV0 IGhvdyBkb2VzIHRoYXQgYWxsb3cgYSBkb21haW4gdG8NCj4gbWFwIGl0cyBvd24gZ3JhbnRz LCBlLmcuIHdoZW4gYmxvY2stYXR0YWNoaW5nIGEgZGV2aWNlIGxvY2FsbHkgaW4NCj4gRG9t MD8gQWZhaWN0IHRoZSBncmFudC1tYXAgd291bGQgc3VjY2VlZCwgYnV0IHRoZSBwYWdlIHdv dWxkIGJlDQo+IHVubWFwcGVkIGZyb20gaXRzIG9yaWdpbmFsIEdGTi4NCj4gDQo+PiBZYW5u OiAgIGNhbiBiYWNrZW5kIHJlZnVzZSByZXZva2luZz8NCj4+IErDvHJnZW46IGl0IHNob3Vs ZG4ndCBiZSB0aGlzIHdheSwgYnV0IHJldm9rZSBjb3VsZCBiZSBjb250cm9sbGVkIGJ5IGZl YXR1cmUgZmxhZzsgcmV2b2tlIGNvdWxkIHBhc3Mgc2NyYXRjaCBwYWdlIHBlciByZXZva2Ug Y2FsbCAobW9yZSBmbGV4aWJsZSBjb250cm9sKQ0KPiANCj4gQSBzaW5nbGUgc2NyYXRjaCBw YWdlIGNvbWVzIHdpdGggdGhlIHJpc2sgb2YgZGF0YSBjb3JydXB0aW9uLCBhcyBhbGwNCj4g SS9PIHdvdWxkIGJlIGRpcmVjdGVkIHRoZXJlLiBBIHNpbmsgcGFnZSAoZm9yIG1lbW9yeSB3 cml0ZXMpIHdvdWxkDQo+IGxpa2VseSBiZSBva2F5LCBidXQgZGV2aWNlIHdyaXRlcyAobWVt b3J5IHJlYWRzKSBjYW4ndCBiZSBkb25lIGZyb20NCj4gYSBzdXJyb2dhdGUgcGFnZS4NCg0K SSBkb24ndCBzZWUgdGhhdCBwcm9ibGVtLg0KDQpJbiBjYXNlIHRoZSBncmFudCBpcyByZXZv a2VkIGR1ZSB0byBhIG1hbGljaW91cy9idWdneSBiYWNrZW5kLCB5b3UgY2FuJ3QNCnRydXN0 IHRoZSBJL08gZGF0YSBhbnl3YXkuDQoNCkFuZCBpbiBjYXNlIHRoZSBmcm9udGVuZCBpcyBy ZXZva2luZyB0aGUgZ3JhbnQgYmVjYXVzZSB0aGUgZnJvbnRlbmQgaXMNCm1hbGljaW91cywg dGhpcyBpc24ndCBhbiBpc3N1ZSBlaXRoZXIuDQoNCj4gDQo+PiBNYXJlazogIHdoYXQgYWJv dXQgdW5tYXAgbm90aWZpY2F0aW9uPw0KPj4gSsO8cmdlbjogcmV2b2tlIGNvdWxkIGV2ZW4g YmUgYXN5bmM7IHJpbmcgcGFnZSBmb3IgdW5tYXAgbm90aWZpY2F0aW9ucw0KPj4NCj4+IE1h cmVrOiAgZG93bmdyYWRpbmcgbWFwcGluZ3MgKHJ3IC0+IHJvKQ0KPj4gSsO8cmdlbjogbXVz dCBiZSBjYXJlZnVsLCB0byBub3QgYWxsb3cgY3Jhc2hpbmcgYmFja2VuZA0KPj4NCj4+IErD vHJnZW46IHdlIHNob3VsZCBjb25zaWRlciBpbnRlcmZhY2UgdG8gbWFwcGluZyBsYXJnZSBw YWdlcyAoIm1hcCB0aGlzIGFyZWEgYXMgYSBsYXJnZSBwYWdlIGlmIGJhY2tlbmQgc2hhcmVk IGl0IGFzIGxhcmdlIHBhZ2UiKQ0KPiANCj4gcy9iYWNrZW5kL2Zyb250ZW5kLyBJIGd1ZXNz Pw0KDQpZZXMuDQoNCkJ1dCBsYXJnZSBwYWdlcyBoYXZlIGFub3RoZXIgZG93bnNpZGU6IFRo ZSBiYWNrZW5kIG5lZWRzIHRvIGtub3cgaXQgaXMgYSBsYXJnZQ0KcGFnZSwgb3RoZXJ3aXNl IGl0IG1pZ2h0IGdldCBjb25mdXNlZC4gU28gd2hpbGUgdGhpcyBzb3VuZHMgbGlrZSBhIG5p Y2UgaWRlYSwgaXQNCmlzIGN1bWJlcnNvbWUgaW4gcHJhY3RpY2UuIEJ1dCBtYXliZSBzb21l b25lIGlzIGNvbWluZyB1cCB3aXRoIGEgbmljZSBpZGVhIGhvdw0KdG8gc29sdmUgdGhhdC4N Cg0KPiANCj4+IEVkd2luOiAgd2hhdCBoYXBwZW5zIHdoZW4gc2hhdHRlcmluZyB0aGF0IGxh cmdlIHBhZ2U/DQo+PiBKw7xyZ2VuOiBvbiBsaXZlIG1pZ3JhdGlvbiBwYWdlcyBhcmUgcmVi dWlsdCBhbnl3YXksIGNhbiByZWNvbnN0cnVjdCBsYXJnZSBwYWdlcw0KPiANCj4gSWYgb25s eSB3ZSBkaWQgYWxyZWFkeSByZWJ1aWxkIGxhcmdlIHBhZ2VzIC4uLg0KDQpJbmRlZWQuIEJ1 dCBPVE9IIHNoYXR0ZXJpbmcgc2hvdWxkbid0IGJlIGEgcHJvYmxlbSBhdCBsZWFzdCBmb3Ig UFZIL0hWTSBndWVzdHMsDQphcyB3ZSBhcmUgc3BlYWtpbmcgb2YgZ2ZucyBoZXJlLiBBbmQg UFYgZ3Vlc3RzIGRvbid0IGhhdmUgbGFyZ2UgcGFnZXMgYW55d2F5Lg0KDQoNCkp1ZXJnZW4N Cg== --------------ufNZuJ0QPnEutYhAwmBg0O6M Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ufNZuJ0QPnEutYhAwmBg0O6M-- --------------0lzFpw34me55u2J4Qms0uoJI-- --------------7LmrTJdUnPE94qJcLK9cj0y0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMtfQEFAwAAAAAACgkQsN6d1ii/Ey8g bQf/a5Rq/T/B/EBb1lrfWqRsXx2/Zxfjvl1togUAJRki9H426iuS0BPUZBY0r8RdfIOYDyTQ3uuZ CuoIXnnY7tVnzFlIpeRvaT68lnWrMZ+7SZR2Oil17eDyHmTF4va1idZLo/ScMZaQ/V/M+JaqiTIk PDlwLjMu2kUjg+47UHuqA+YA3FCmD0YdGN/ruff09pM7pzaLaUhw2zeyV8sNh8kI+43uWnbcjS0k 4lLMMylHbzydPlEghEtaWXx/lgNe0HmTEDS6vXxALmTcvM3Tg7slzZMRuCyuv77LykDvNuEZ1odj ClibRN7J2WlfuDftPfiHZA0iW8S1+l5P1tRvmar7EA== =nDqZ -----END PGP SIGNATURE----- --------------7LmrTJdUnPE94qJcLK9cj0y0-- From xen-devel-bounces@lists.xenproject.org Fri Sep 23 10:38:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 10:38:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410690.653807 (Exim 4.92) (envelope-from ) id 1obg4W-00046O-0a; Fri, 23 Sep 2022 10:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410690.653807; Fri, 23 Sep 2022 10:38:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obg4V-00046H-Tg; Fri, 23 Sep 2022 10:38:15 +0000 Received: by outflank-mailman (input) for mailman id 410690; Fri, 23 Sep 2022 10:38:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obg4U-000467-Cx; Fri, 23 Sep 2022 10:38:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obg4U-00083G-9Q; Fri, 23 Sep 2022 10:38:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obg4T-0001ml-SP; Fri, 23 Sep 2022 10:38:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obg4T-00027y-Rt; Fri, 23 Sep 2022 10:38:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Bd23bYkoweOyjO6iFwX9ArZNnVSzSsoYJjpb79FE3BY=; b=tFgN2CqLvbecnGXMeN+fAmkqAp nJRX81U1B2RJ/6hcis5yGrigmp2GrnL4J8qHoAt2EpZBSdN1Nypj2qAh3Q/wcykdk06O3MSGJS507 bVm2vSzMSKNTSJzuuv3mlp9bTebQPed3ytaBfSoo8jQ3OCoshXv966CHmV8MmT+NTrVw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173284: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Fri, 23 Sep 2022 10:38:13 +0000 flight 173284 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173284/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173259 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173273 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173273 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173273 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173273 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173273 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173273 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173273 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173273 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173273 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173273 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173273 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173273 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173284 2022-09-23 01:52:06 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Sep 23 10:47:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 10:47:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410699.653818 (Exim 4.92) (envelope-from ) id 1obgD4-0005n2-3w; Fri, 23 Sep 2022 10:47:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410699.653818; Fri, 23 Sep 2022 10:47:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgD3-0005mv-VB; Fri, 23 Sep 2022 10:47:05 +0000 Received: by outflank-mailman (input) for mailman id 410699; Fri, 23 Sep 2022 10:47:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgD2-0005mp-UK for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 10:47:04 +0000 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d170dfb-3b2d-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 12:47:00 +0200 (CEST) Received: by mail-wm1-f50.google.com with SMTP id r3-20020a05600c35c300b003b4b5f6c6bdso2957181wmq.2 for ; Fri, 23 Sep 2022 03:47:03 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id fc15-20020a05600c524f00b003a5537bb2besm2381730wmb.25.2022.09.23.03.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 03:47:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d170dfb-3b2d-11ed-9374-c1cf23e5d27e X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=C9Ixt7ZPmjv3wabGBTiF81Yt9jGnlGxSuwbQ49syOEg=; b=GTMjdgjfYygypxuBHA5ml07/mFk6rpPRYjvrqeklPTFWx6HnEWuvxFSQ7DgSetn6eL 5xRh+2gI0/pDLOnWihkhBYwu5EiM2gPzXYzwvh7WWK7viC+A823O4c3BAMDvFSglONRT 8PMv93Rg7jrfHl967H9ZNM2FkzV2yN+kvcy7QIWdvYpEXzaMjxMhnfNhKEWBYxPxl0FB kxV1nVUPp2J1iIgsN8Q08PJFFfxQZVAXvkD6dUU214Z+BUme7NwXbW6Vvz5WuwZgq6Xw MQ4CgSKKJnrJizcngwwVnuNR/AlEq8p/y2uMGMzG7ENbIjmemXa5WvB2hU+/FDSk08N/ SoSg== X-Gm-Message-State: ACrzQf339ZWDCE5GBeHII5KnoldzrlUa6zch4XMKOJQYJSfDLSOxeUUI SF388f5/H7jVnhkQJCqS8M0= X-Google-Smtp-Source: AMsMyM58sinn3dOD8Ey7/0k7+hRpfbrgHSF5AozbhZNVJTKa3qZA7sr92yRjb4LPdGvjsnF2Q7YodA== X-Received: by 2002:a05:600c:35c5:b0:3b4:bf50:f84a with SMTP id r5-20020a05600c35c500b003b4bf50f84amr5289326wmq.22.1663930023269; Fri, 23 Sep 2022 03:47:03 -0700 (PDT) Date: Fri, 23 Sep 2022 10:47:00 +0000 From: Wei Liu To: cgel.zte@gmail.com Cc: wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: Re: [PATCH] xen-netback: use kstrdup instead of open-coding it Message-ID: References: <20220921021617.217784-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220921021617.217784-1-chi.minghao@zte.com.cn> On Wed, Sep 21, 2022 at 02:16:17AM +0000, cgel.zte@gmail.com wrote: > From: Minghao Chi > > use kstrdup instead of open-coding it. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi Acked-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Fri Sep 23 10:51:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 10:51:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410705.653829 (Exim 4.92) (envelope-from ) id 1obgH6-0007Ba-KJ; Fri, 23 Sep 2022 10:51:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410705.653829; Fri, 23 Sep 2022 10:51:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgH6-0007BT-Gw; Fri, 23 Sep 2022 10:51:16 +0000 Received: by outflank-mailman (input) for mailman id 410705; Fri, 23 Sep 2022 10:51:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgH5-0007BN-GT for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 10:51:15 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a276ed89-3b2d-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 12:51:10 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id g3so19750383wrq.13 for ; Fri, 23 Sep 2022 03:51:14 -0700 (PDT) Received: from horizon ([2a01:e0a:19f:35f0:dde5:d55a:20f5:7ef5]) by smtp.gmail.com with ESMTPSA id o41-20020a05600c512900b003a5c244fc13sm2284917wms.2.2022.09.23.03.51.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 03:51:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a276ed89-3b2d-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date; bh=ePAqBWVCbNIh2fW7ZvyICalrFQoKNjGDm/4R3uj8Qbs=; b=IUO3AQRwDtsUYvHOB7m7YWA00NaXtnYRAewsB8wJGFYfCHm9P7GtS9JU7PuRCgQWeC xsj7EFPCUSGvZzl5Y5YgTZUsaaYW5kbDzwSbEZhZDnL589jaih2uhPPIWeYxJFxV4jxu CDOPyD0vBmDUfucYmZH4mMw1uzbk694OEqKTz9ZqlQPQJqsHRQ6GP+4yWxCIghRUfxM3 hFgv890lgo4EYTEK5xvxTaxBRliYZRKV6hmlSkRXl9NKYVhPqwnAWlKpVrpe3HCdhdx5 UEO0LebD15Kyj9714LdwDzZkpG+ZFV8w5+WfVmibOpiuOPsH3JmB3iIRBNsVaC7qWLwr vgFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=ePAqBWVCbNIh2fW7ZvyICalrFQoKNjGDm/4R3uj8Qbs=; b=7ej8/VgRkLnaaFtlLoHWflY2crHLzq3hHRjr1l/qh2YoqLghC0HqldqCD03XZwSBZz y+VQi3Rj38aLafOJ7jF4nzDJ+qP62aF/ub/BhUCTtY44dZbhx2R0w70+NobDKxGT7Uf1 CsqS9T+5UDrupNxF8EFZ/QzwUFcmmAH3nkTxZxQvZjirCPvMNOSgV7zMhIkQRZYGFLWI klzCILIjYz1b8KjwqJp8Tv7ybiEhIj9HDwd6oFwkiJ/WywiDGYxbBQDhwr7rlKSYS7u0 SSNH3G/K8TdNhAiS0W3dztVDIBMk58hbvhHjUVFg0mrEl/HYRwWVb1qyL8VElU9/CViH 5Trg== X-Gm-Message-State: ACrzQf0mejGpUeMEe9HQXHhKHutQdptJAhJ0CQTva/Z/z3RPwrreoWqJ KPSSXohNH3Yg9unfSidUYckGtyxWiDYGKYML X-Google-Smtp-Source: AMsMyM5hD/vhhdM7DveEBMtckkoBllUgQ4Qpj+hVpK72YTUJl8FcqJi/z8WX+uhqw8RegXRp9UqZZA== X-Received: by 2002:a05:6000:887:b0:21e:24a0:f302 with SMTP id ca7-20020a056000088700b0021e24a0f302mr4622829wrb.466.1663930273445; Fri, 23 Sep 2022 03:51:13 -0700 (PDT) Date: Fri, 23 Sep 2022 12:51:11 +0200 From: Matias Ezequiel Vara Larsen To: xen-devel@lists.xenproject.org Subject: Design session "Using the new VCPU counters in XAPI" Message-ID: <20220923105111.GA647305@horizon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Participants: Pau, Edwin, Matias - the semantics of the new interface for querying registers is now async, this would require a initialization phase in xcp-rrdd before query the counters. - why this https://github.com/xenserver/xen.pg/blob/XS-8.2.x/master/mixed-domain-runstates.patch is not up-streamed? - we need to implement a protocol to ensure consistency between producer(hypervisor) and consumer(user-space) - we can get inspiration from in xen/arch/x86/time.c:__update_vcpu_system_time(). This relies on version_update_begin() and version_update_end() - get inspiration from the comment at public/xen.h in the struct vcpu_time_info{} in which a version number is used - get inspiration from arch/x86/time.c:read_xen_timer() - we need something in user-space that relies on the same mechanism, i.e., get a consistent value if version number is the same before and after reading the structure. - add bindings for acquiere resource see https://github.com/xapi-project/xen-api/blob/master/ocaml/xenopsd/c_stubs/xenctrlext_stubs.c#L460) - also get inspiration from 2529c85 - we cannot find where is the implementation of this protocol in user-space. Xenctrl should implement it somewhere From xen-devel-bounces@lists.xenproject.org Fri Sep 23 10:52:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 10:52:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410710.653840 (Exim 4.92) (envelope-from ) id 1obgI9-0007jP-TW; Fri, 23 Sep 2022 10:52:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410710.653840; Fri, 23 Sep 2022 10:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgI9-0007jI-Qe; Fri, 23 Sep 2022 10:52:21 +0000 Received: by outflank-mailman (input) for mailman id 410710; Fri, 23 Sep 2022 10:52:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgI8-0007j6-NX; Fri, 23 Sep 2022 10:52:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgI8-0008LJ-D9; Fri, 23 Sep 2022 10:52:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgI8-00026o-2f; Fri, 23 Sep 2022 10:52:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obgI8-0007X9-2D; Fri, 23 Sep 2022 10:52:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gN/R1PLjmW1kn+8LfMLs2IbcNa8rONRDb35uI+MIvBI=; b=DkWdoZGs2KHms62h9qp1jdAHfW 98prOw6YN6/5v1xIREPPjOoSo0R8IHUzta0c5M673IzUv8Yy+RIeGdOVLUaKRZZDe8NgYQliUIYsL 2b80DnR8pPNLd3M/1M8gPFiHTWbgI3Aaes+AtMdXpAtB017+wN9Hn3iMzvcL1Ab4Czas=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173287: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=68e93e3180ad4e51bf9f86850dc86d8f528d6564 X-Osstest-Versions-That: libvirt=8496880866415a5673715ffa0e4720efb4274c22 From: osstest service owner Date: Fri, 23 Sep 2022 10:52:20 +0000 flight 173287 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173287/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail blocked in 173274 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173274 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173274 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173274 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: libvirt 68e93e3180ad4e51bf9f86850dc86d8f528d6564 baseline version: libvirt 8496880866415a5673715ffa0e4720efb4274c22 Last test of basis 173274 2022-09-22 04:20:17 Z 1 days Testing same since 173287 2022-09-23 04:22:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 8496880866..68e93e3180 68e93e3180ad4e51bf9f86850dc86d8f528d6564 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 10:57:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 10:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410718.653851 (Exim 4.92) (envelope-from ) id 1obgMl-00008i-Fo; Fri, 23 Sep 2022 10:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410718.653851; Fri, 23 Sep 2022 10:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgMl-00008b-Cm; Fri, 23 Sep 2022 10:57:07 +0000 Received: by outflank-mailman (input) for mailman id 410718; Fri, 23 Sep 2022 10:57:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgMk-00008V-8U for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 10:57:06 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 713a8128-3b2e-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 12:56:59 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Sep 2022 06:57:00 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6865.namprd03.prod.outlook.com (2603:10b6:303:1b5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Fri, 23 Sep 2022 10:56:58 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.022; Fri, 23 Sep 2022 10:56:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 713a8128-3b2e-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663930623; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=azB7uA7BlYQBKFYyY0T4fUkuZL+s1HPnWMTwc7kcd+c=; b=cAENZIQMYNSdh60kfp2OhDaTUN8T9JaUP/fl2UZ4Cu10UYISb12+In5P 8rCYZ62p2gHU7Dk8ZKl9z1Iufj//xKhtp0F7oalZngrgO2G2nVMPJYalw dPR5JXHJKNu8ghgyW9co/Sb6DHdig2FLCen7TWTWI7jWsBHOy6noubMx6 k=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 81630643 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:h48JaKxnjH4TJCdi79R6t+f2xyrEfRIJ4+MujC+fZmUNrF6WrkUDy GsaUTiDMqmCYTagKtx+Oo7g8R4C6MfVm9AyGVNtrSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Uk05K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1MKlEWErQo+NwnOnBKr NsoKh8GazKq0rfeLLKTEoGAh+wFBeyyZsY6hSslyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCehNWEFwL6WjfNfD2z71gt+3aKrKNPIUteLWd9UjgCTo WeuE2HRUkhEb4TBlWHtHnSEgs2RtiL/Wq0oKqzkxs9G3F694GgsB0hDPbe8ibzj4qKkYPpPJ kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwAOQzOzS6gWQBGkBRxZAbsArsIk9QjlC/ lyEgdLvQyBuubu9SHSB+7PSpjS3UQAXJ2IfYS4PTSMe/sLu5oo0i3rnUdJLAKOzyNrvFlnNL yuiqSE/g/AWkpQN3qDip1Tf2Wrw+97OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lR9lFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:Fc6o6qzEH5O4Vk+VTtd9KrPxyuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhOZICOgqTM6ftWzd1FdAQ7sSibcKrweBJ8SczJ8h6U 4fSdkYNDSYNzET46fHCWGDYqwdKbK8gcWVbInlvhRQpVYAUdAa0+41MHftLqUwLzM2dKYRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv4EvoxKhNN6Ws2N 60TZiA7Is+KPP+TZgNcdvpEvHHflDlcFbrDF+4B2jBOeUuB0/twqSHkIndotvaMKA18A== X-IronPort-AV: E=Sophos;i="5.93,339,1654574400"; d="scan'208";a="81630643" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vkm30OQAaYK7L9W8ahCWPTC0gbc03Yz/ccPvoo8lwYGeT4Din71CQ49NZtYljuTDw6HjGhd+QDYZcSGStiRJXaSl3Pcn93jduYbswxruanZIU1VxdJCHz5Wmxf73Mn5Ls5CAXQys+LrVSGitwBMYrDUI9L61cJes3rkxNwmInXCt63lhFszyOeIylD4of/Fu9ST/Ui8HckXKmK+eVTyqrRSYU8yghhu5bkOxTswbGmam6hEYLPHcD+1eIrGnpawidkuasPKL23uKDwlZ9xtxve3aTFcwNZCMuZWy320NDCcthUSManpa0YeszKXzVceLWiCmaqeIEwzfWlkQESjh1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7fAJBf7y+p80xGCoM1HkmotHKEEUd2bdFx1zNnIlwxM=; b=SYs270M6XGeOMAjHhYcwg6w2eXPZRgiPxHDu/L2xzMu737Wfqbsh10y+MUmSMcjK0ypjTkiFqZQ4t2ux/tXzLhdokVDqmhfFiyf82GdUPySyye+a8l5bt9Yrd+3GsheWkLhmi2A0UItKy2kFjzNw5duuWCGZfJGyCCisnlBxB8TVl2seBDjuq0iGmB3S8K0P3dI7K/SEqkYJSQ4OU6p8nXiXNgl1jq1ZfFVh3PBwtoFeeNJW1fEBDbDCgBGbz4ZLwxIXh/RCx40l2bmoaNTnwi/SdpDQbgFL+o2Ev3J+NydhHnUbE1DJiA2KJkAEV/f6NVatQe1UcKDSesmi6n+m7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7fAJBf7y+p80xGCoM1HkmotHKEEUd2bdFx1zNnIlwxM=; b=GfZgpFdFpUMP+BgEw0JbRFpfyBxOq1pp78/Yc6AmQAljScT6mcd3lR+uIiXGz8cXD3CRc4EDm6RbAHHCwWBE8IQGDa8OIQ85+fvpOg+A0/tNHoPFUmRYulwxuZqBbBd7/uqWNuBR34/juZmLMAdY4Qm35vISaXk9UQynpxbQJKQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , George Dunlap , Wei Liu Subject: [PATCH] x86/ept: simplify detection of special pages for EMT calculation Date: Fri, 23 Sep 2022 12:56:48 +0200 Message-Id: <20220923105648.12587-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0415.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6865:EE_ X-MS-Office365-Filtering-Correlation-Id: 25a2deee-5dc9-4e73-7eb9-08da9d525597 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ws9umJc1OZa0fUUw1dh0oHSp4ZOY3G9R+dMtiF6ZhF0tWyFwCHvmiBRqOZLxTv6+izFBkHY5lMZr63qt3jaIV2urgmSXCmJvq52Cu5KtFYqVobF8C9JQI0UR3CP83xD1aoIKpRFWBohIVpSRALmNd6vsRVWKp3CCbf3SNWKHkS3BfVGeaPfPKjAr89aZ8w8jhP7JV+znclOJAUq2L32eYQJWxNx+42C1tXqHNSm78e1P+Sxjo+nwz+JTgis6st/uEQiSI7YUZE2GmRO+eJys5pM9/MIbrDsdJRROc6OfFZySyXlQ4XGg+JOwyZkj/qplWPw7b1QSsPujOwuJ8z21FcOAShA5lLHaM+5VOptgmuB5M1qZeqxv2FhcYMetg+E764bQmxLLgcrs6MJ9VYqEhMCixenMej/sqxWWvzquPXbXRQhKvzm3KNP8W98WUBg57ViKS+7FhTS0UOlBCEYwIopB7spXZS7munSu7yXnw4ye9wJWxZPrX7JmO6hLtxxkgE05SvhofO40Hswsh6bAu3YEoJmbm5AaIAdzzpUeB9wgo5xMFz45McyI9DT1avvYiFfXv6UzjMoQV/eP1uK5wnMEUyxREKHnzXybO8pmEdhuqH3Z+x5yzLijeIMYDvt5oEFyNGTqmIbzx+DjMmcDE83IUdTgbaxAr+g7MKWgh2XcpZISqi+Yz9gm1KGa18g07zKgm43QvcAycIxVEihiIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199015)(38100700002)(66476007)(5660300002)(83380400001)(82960400001)(6666004)(54906003)(66946007)(86362001)(6916009)(316002)(478600001)(4326008)(6512007)(1076003)(6506007)(26005)(186003)(66556008)(2616005)(6486002)(8676002)(36756003)(2906002)(41300700001)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFVXUUhFSW05OGNKRTlqcVg1Zll3UGRvL1Vzb1lLQ1pSTkh2MnNvTktuYmJ2?= =?utf-8?B?ZVBENk16L1lJSFZ0TXArQ1FVblBiWTZPanJVRVpyR2x0WHN3VVNEYmV2S2F2?= =?utf-8?B?ZGpXY2pJZVVGbW9SMGhqNUFjUjNaSzlCUVlCR0lHVVo5L2M1a2xva2J4ZFBm?= =?utf-8?B?d0xqbmVhZnJuVCtlVjZCS2gzT1V0VktSOUpCL25SaDZVUGZjVzhLeHp6bG1z?= =?utf-8?B?SklYUHUvck1zUk1vazQ0eHNwdmZWVDJTWE9kVVhGNzU1aHAxcHdYRTFEWG1x?= =?utf-8?B?T1NmRE5iei9YMDdXa284R3NIVHdVQjJoN2pSWWR5VmptdFJNMkdsWkdpa2Qz?= =?utf-8?B?REpTZkFFRzRiaVlnS0tSVndPZkFjRVNpYXhoVVAwS0RMSHdoWWVSa2FvZHYy?= =?utf-8?B?a1dBZGVsWFpjak9xL3hwcnE4bERRczlyci9ReTM0dDk4cnZCTnFqQUNIZ0gy?= =?utf-8?B?bE1VSDVoN2ZMbWtWRXVyRG5vMEdpTTlHNUFKaVhVejBtSVROelltUjZkaDBH?= =?utf-8?B?T2p6YlpCQWVLeUFQcGc4dFBac042V0IwalJreVRuUTFGMkxlbUk1OER2Qjdq?= =?utf-8?B?aWhCY1d3UmI0T3hQSUR3bG5uQ0dwMUZjWm5zU284SHhQVlRMQjBLQlpraW9X?= =?utf-8?B?K3loV1MrVkZSUmhxdWdVdVNrWTd6ZzNNV3hUay8yY2x2OVlCT1JvZ2o5aElI?= =?utf-8?B?b0dycjBUWVd2NUlLMnBFdGgwZW5laDArZzNOb0M1WHJ5NmlMekdJZGQ2NTBJ?= =?utf-8?B?dmFHcjJIRFlhbUZyZnpqNjJrMVFlZHdMTDFjYmJYV2g4WFlDUXl2b2FVSXUy?= =?utf-8?B?NjdUTDQxVm43Ry9LVHMvOXkrdFBFNzAxcE85Tk1KSTFqa2wxYXEwNlcrbElH?= =?utf-8?B?bFZJL1R1bXZnbHRFbzRQa2Z5cG9wNXRYbDdlNG9QcHNqK2N2L1YwYlp3MS9v?= =?utf-8?B?aHNOZm0wam1rSWtRRG9lSDBYNEhCNGo0dXdOZW11MUk2RjNxVm0xVHdWaWZr?= =?utf-8?B?NWpVeXhHVzR1V21JOGxVQzJwWitMSi9FeVBlN3pxS2k3TUFWRkZpaWJEV3Z6?= =?utf-8?B?Z3BlNG5aMGJHcUFVNkhVSFRlVXhmb05PeVpJWHpZemZqeTA5RmxmWEQ3OTNi?= =?utf-8?B?bVVqejdKZkRYcGVMQlZqdVRReTZkSHY0TUpUYjhYSGFGTEpVeFlwZ2hJa01l?= =?utf-8?B?Y0lMUkpWY1o2ajZLR2hBUkVRM0cycnRNR0JwbnlQaTE3STZPYUJHYUhmMXZ5?= =?utf-8?B?NXdLU3BsMDMwNjdlTm8vOU9qM0hIamI0SW02U3hIZTgxL0RXb0xXMnIyYzZX?= =?utf-8?B?SERKekVxVjNZMzY2enJLdFVtaXBONDgxYjZrSDdlS24xbldTS0VaOUFyNUla?= =?utf-8?B?RVNyREhYWEJ0NGlzN1U4aEdmVjBFaU15RnFxd0I1aEdBYmV5bzFYaWo5Nkwv?= =?utf-8?B?VnEwQjJ5T1JJY3ZTWHdlWFU2dGhGaG5VbVlKbERCOUpsN1FGbm0vTGN5Wmcz?= =?utf-8?B?Qngxa2s0bXdkL1Z0eFpuWkY1VllOTkFZZXQzOEdJK3FqMm5XUzRaQ3MrZWdi?= =?utf-8?B?YXdiYVhGdWpCRGlTQktTek8rVHlHc0g3T3NqK3ZuK2RpREc5WjhadFBkWFVh?= =?utf-8?B?a0FnNVJ0WWpadmtRNjZyNWFZcEFBaElPMUgzQnMwTTdHZ3BiQVg3RUZ4TFVI?= =?utf-8?B?THpLdFhXVVd6TEJmRjRZYUd6OHVWKzZ2MTVDdTNJbStmRys0NHJDY2xZTzNZ?= =?utf-8?B?NGZhODg4S0FQOUhXdGFjSDVURHdxQlZ6TUZ0SGFQSjhHRVZVMitTM2lDN3VF?= =?utf-8?B?UG44Y3ZnVkIzOVJkMW5xOWNVbkY5L0tNNHc4MWtjVDNKbjQ5WTdjQ0NVc2g2?= =?utf-8?B?ellDY1FWbHUxcXMwS2c4YTJEYXBacElKVTJHc2FOSVZwUGVGd0FZZDdXNlRF?= =?utf-8?B?blRiZVJ2WkFPbThDeWhCWkJ0R1c1ZUlTNW4yRFNtd3ZMMk9wUGtOZzNJRUtx?= =?utf-8?B?allRVWMwcTNlNE1tQWUzSVRMd2VpaXU2VGtMWDZkcTR2TnFuMFhLeWs0R25N?= =?utf-8?B?TEZWNmV4clJCajF5TDZ2OUZqNWZRZVUwZmg2cko1a04yT0pScUdLT2JCeG9j?= =?utf-8?B?d2JERlJuVzBwYUZVVTZKaG1oc25iajE0VFJDdWtYS3VXMEp4eUhjUDM5ZkZV?= =?utf-8?B?dGc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25a2deee-5dc9-4e73-7eb9-08da9d525597 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 10:56:58.0206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: taNVh6fxlDsDqBiWNY7Y+6KsIuorocAY8/eC5HtgbfLsrWE4S8zkM26uZ0JGaA77wOaez9HZQ9L8J/OBTCivmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6865 The current way to detect whether a page handled to epte_get_entry_emt() is special and needs a forced write-back cache attribute involves iterating over all the smaller 4K pages for superpages. Such loop consumes a high amount of CPU time for 1GiB pages (order 18): on a Xeon® Silver 4216 (Cascade Lake) at 2GHz this takes an average amount of time of 1.5ms. Note that this figure just accounts for the is_special_page() loop, and not the whole code of epte_get_entry_emt(). Also the resolve_misconfig() operation that calls into epte_get_entry_emt() is done while holding the p2m lock in write (exclusive) mode, which blocks concurrent EPT_MISCONFIG faults and prevents most guest hypercalls for progressing due to the need to take the p2m lock in read mode to access any guest provided hypercall buffers. Simplify the checking in epte_get_entry_emt() and remove the loop, assuming that there won't be superpages being only partially special. So far we have no special superpages added to the guest p2m, and in any case the forcing of the write-back cache attribute is a courtesy to the guest to avoid such ranges being accessed as uncached when not really needed. It's not acceptable for such assistance to tax the system so badly. Fixes: 60d1adfa18 ('x86/ept: fix shattering of special pages') Fixes: ca24b2ffdb ('x86/hvm: set 'ipat' in EPT for special pages') Signed-off-by: Roger Pau Monné --- xen/arch/x86/mm/p2m-ept.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b4919bad51..d0e1c31612 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -491,7 +491,6 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, { int gmtrr_mtype, hmtrr_mtype; struct vcpu *v = current; - unsigned long i, special_pgs; *ipat = false; @@ -518,26 +517,19 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, return MTRR_TYPE_UNCACHABLE; } - if ( type != p2m_mmio_direct && !is_iommu_enabled(d) && - !cache_flush_permitted(d) ) + if ( (type != p2m_mmio_direct && !is_iommu_enabled(d) && + !cache_flush_permitted(d)) || + /* + * Assume the whole page to be special if the first 4K chunk is: + * iterating over all possible 4K sub-pages for higher order pages is + * too expensive. + */ + is_special_page(mfn_to_page(mfn)) ) { *ipat = true; return MTRR_TYPE_WRBACK; } - for ( special_pgs = i = 0; i < (1ul << order); i++ ) - if ( is_special_page(mfn_to_page(mfn_add(mfn, i))) ) - special_pgs++; - - if ( special_pgs ) - { - if ( special_pgs != (1ul << order) ) - return -1; - - *ipat = true; - return MTRR_TYPE_WRBACK; - } - switch ( type ) { case p2m_mmio_direct: -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 11:02:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 11:02:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410726.653862 (Exim 4.92) (envelope-from ) id 1obgS3-0001hB-93; Fri, 23 Sep 2022 11:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410726.653862; Fri, 23 Sep 2022 11:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgS3-0001h4-57; Fri, 23 Sep 2022 11:02:35 +0000 Received: by outflank-mailman (input) for mailman id 410726; Fri, 23 Sep 2022 11:02:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgS1-0001gy-Qw for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 11:02:33 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 3824c2c3-3b2f-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 13:02:32 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1462F139F; Fri, 23 Sep 2022 04:02:37 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 427953F73D; Fri, 23 Sep 2022 04:02:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3824c2c3-3b2f-11ed-9647-05401a9f4f97 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/2] xen/arm: static event channel Date: Fri, 23 Sep 2022 12:02:16 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series fix issues related to static event channel series. Rahul Singh (2): xen: Add static event channel in SUPPORT.md on ARM xen/arm: fix booting ACPI based system after static evtchn series SUPPORT.md | 7 +++++++ xen/arch/arm/setup.c | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 11:03:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 11:03:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410731.653872 (Exim 4.92) (envelope-from ) id 1obgSY-0002Bf-HM; Fri, 23 Sep 2022 11:03:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410731.653872; Fri, 23 Sep 2022 11:03:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgSY-0002BY-ER; Fri, 23 Sep 2022 11:03:06 +0000 Received: by outflank-mailman (input) for mailman id 410731; Fri, 23 Sep 2022 11:03:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgSY-0001gy-0J for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 11:03:06 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4c1fb3b8-3b2f-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 13:03:04 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7ABF139F; Fri, 23 Sep 2022 04:03:10 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 308523F73D; Fri, 23 Sep 2022 04:03:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c1fb3b8-3b2f-11ed-9647-05401a9f4f97 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/2] xen: Add static event channel in SUPPORT.md on ARM Date: Fri, 23 Sep 2022 12:02:17 +0100 Message-Id: <02a4499694dec9fd48791a2d0c24a0d450b907ac.1663928523.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Static event channel support is tech preview, which shall be documented in SUPPORT.md Signed-off-by: Rahul Singh --- SUPPORT.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 8ebd63ad82..29f74ac506 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -922,6 +922,13 @@ bootscrub=off are passed as Xen command line parameters. (Memory should be scrubbed with bootscrub=idle.) No XSAs will be issues due to unscrubbed memory. +## Static Event Channel + +Allow to setup the static event channel on dom0less system, enabling domains +to send/receive notifications. + + Status, ARM: Tech Preview + # Format and definitions This file contains prose, and machine-readable fragments. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 11:03:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 11:03:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410736.653884 (Exim 4.92) (envelope-from ) id 1obgSz-0002hh-Qd; Fri, 23 Sep 2022 11:03:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410736.653884; Fri, 23 Sep 2022 11:03:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgSz-0002ha-NT; Fri, 23 Sep 2022 11:03:33 +0000 Received: by outflank-mailman (input) for mailman id 410736; Fri, 23 Sep 2022 11:03:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgSy-0001gy-Ro for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 11:03:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5c6eeda0-3b2f-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 13:03:32 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E8D2139F; Fri, 23 Sep 2022 04:03:38 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B09033F73D; Fri, 23 Sep 2022 04:03:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c6eeda0-3b2f-11ed-9647-05401a9f4f97 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series Date: Fri, 23 Sep 2022 12:02:18 +0100 Message-Id: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When ACPI is enabled and the system booted with ACPI, BUG() is observed after merging the static event channel series. As there is not DT when booted with ACPI there will be no chosen node because of that "BUG_ON(chosen == NULL)" will be hit. (XEN) Xen BUG at arch/arm/domain_build.c:3578 Move call to alloc_static_evtchn() under acpi_disabled check to fix the issue. Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property) Signed-off-by: Rahul Singh --- xen/arch/arm/setup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 61b4f258a0..4395640019 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset, printk(XENLOG_INFO "Xen dom0less mode detected\n"); if ( acpi_disabled ) + { create_domUs(); - - alloc_static_evtchn(); + alloc_static_evtchn(); + } /* * This needs to be called **before** heap_init_late() so modules -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 11:10:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 11:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410746.653895 (Exim 4.92) (envelope-from ) id 1obgZc-0004RI-FU; Fri, 23 Sep 2022 11:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410746.653895; Fri, 23 Sep 2022 11:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgZc-0004RB-Cx; Fri, 23 Sep 2022 11:10:24 +0000 Received: by outflank-mailman (input) for mailman id 410746; Fri, 23 Sep 2022 11:10:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obgZa-0004R5-Tg for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 11:10:22 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50572671-3b30-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 13:10:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 456EAB82E67; Fri, 23 Sep 2022 11:10:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 757BFC43140; Fri, 23 Sep 2022 11:10:18 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 5A4AEE50D6E; Fri, 23 Sep 2022 11:10:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50572671-3b30-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663931418; bh=NqnuDVIMt1oSUij9cX7Jo76nv6rsncgNTT8nqoi6nWY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=QR6bWB+LLqQ7e7liox14c+xnJGt7kLml6Su/A9Z6wrxPV1EJLysPATe5NN1ZOPKG3 aK3uNeuDSCn6QFBbVz1FEnbQsiWZnXjlQPoFuVGKOdHozOF3aRRbhcDL+DK9GxUp2Z 8C8JQ+gqlP5H5Ur0T1f3cFnY+CIcXrBQZwAWkkEPe2CiBkd9LwPnBof15mQHd4v3ZC ox5KpLE97gtLO1mM8k9Wl6O8Jhi4TwO4sCe/+XQ9O9aWBc9oTQ4Wre9Lckqs0g0Rt/ pusFfkmlJAB0/jj7xWfBiMWtbI6xn2JhTGciCJ9Bb+HCRgWtTuhOEX9sdlDKQ3WFf1 qAiZ8cbu8jR0g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] xen-netback: use kstrdup instead of open-coding it From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166393141836.14679.4668814171587024778.git-patchwork-notify@kernel.org> Date: Fri, 23 Sep 2022 11:10:18 +0000 References: <20220921021617.217784-1-chi.minghao@zte.com.cn> In-Reply-To: <20220921021617.217784-1-chi.minghao@zte.com.cn> To: CGEL Cc: wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chi.minghao@zte.com.cn, zealci@zte.com.cn Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 21 Sep 2022 02:16:17 +0000 you wrote: > From: Minghao Chi > > use kstrdup instead of open-coding it. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > > [...] Here is the summary with links: - xen-netback: use kstrdup instead of open-coding it https://git.kernel.org/netdev/net-next/c/f948ac231333 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Fri Sep 23 12:03:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 12:03:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410764.653905 (Exim 4.92) (envelope-from ) id 1obhP8-0002Fd-Jk; Fri, 23 Sep 2022 12:03:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410764.653905; Fri, 23 Sep 2022 12:03:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obhP8-0002FW-H8; Fri, 23 Sep 2022 12:03:38 +0000 Received: by outflank-mailman (input) for mailman id 410764; Fri, 23 Sep 2022 12:03:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obhP7-0002FM-5O; Fri, 23 Sep 2022 12:03:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obhP7-0001Dy-3g; Fri, 23 Sep 2022 12:03:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obhP6-0003lN-Nl; Fri, 23 Sep 2022 12:03:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obhP6-0007fD-NM; Fri, 23 Sep 2022 12:03:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YLshj5wRn9Q7aDis+TicFSYWBeAodeBcFE71b3ljhA8=; b=tjosbdQAArOM21EMpmuALxtgl0 4+8modZgIz4Ju35ZTkpo3RWzJcCgP5mAWAKKPwBkUyBiJNwDLVQQmWatcRe1xxcVzXFjndlW5eTRx DYJxC3YhWIlJBgKlNkNgChqRljScUjRX0kkcnbHYtvs7dh8Rq/uOyhgCn6cM0S7yd9ws=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173289: all pass - PUSHED X-Osstest-Versions-This: ovmf=5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 X-Osstest-Versions-That: ovmf=b19793a2ec6466c04e5e3506fbe82038fb0a885f From: osstest service owner Date: Fri, 23 Sep 2022 12:03:36 +0000 flight 173289 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173289/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 baseline version: ovmf b19793a2ec6466c04e5e3506fbe82038fb0a885f Last test of basis 173288 2022-09-23 07:43:17 Z 0 days Testing same since 173289 2022-09-23 09:41:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Qi Zhang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b19793a2ec..5f403cdc6a 5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 12:10:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 12:10:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410772.653916 (Exim 4.92) (envelope-from ) id 1obhVl-0003qZ-9F; Fri, 23 Sep 2022 12:10:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410772.653916; Fri, 23 Sep 2022 12:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obhVl-0003qS-6c; Fri, 23 Sep 2022 12:10:29 +0000 Received: by outflank-mailman (input) for mailman id 410772; Fri, 23 Sep 2022 12:10:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obhVk-0003qM-6f for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 12:10:28 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2087.outbound.protection.outlook.com [40.107.93.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b41d9497-3b38-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 14:10:25 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by PH0PR12MB7094.namprd12.prod.outlook.com (2603:10b6:510:21d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.22; Fri, 23 Sep 2022 12:10:23 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 12:10:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b41d9497-3b38-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egwba4Y8M7d9MLa73h+44+AfeOdzwzhTL5OC+JeZt1WKTkzaWk+64S5jDTgYt+tFkuEt+AFtnGIkCqbjAfRWX4gKfpwuaKcf5kwAsj23UXC4j4rMkcvclWthmdyZPOB1gWazmQ/5sIqR4dpFxNoL2HuwgnxttS7HwZhctbi37ZHWSVsw/0vhZXAu9YqgdSJnGQ6uijgpDrjibg2ujTg0Xyj1jgWgraBjSHTlpbRmV3x1iXuxCY5FOP2Kn1dx5cjryjb9aAbg2w0pBAW+9nfxapNC+pnbgHlSaOWv2bIWrAo9+KdR9wTIrzzj2Opqa+eQkP44pACyyd0dffJPzWu+/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FzURtjbh1BMXeIbIvlhHYOSGR+CZp5qngLInO6UfwOc=; b=cGBidgL2qVsYaXnTQC3v5wur2oMztwjNiffJ8Z6qH3DkjSJZEtxleCJ5uVEdU06iC3RYkiCbCQ/tZZhFzoFvhazutXcx6/GfDRJj3dRTc3DIFC0V1i+bpDwHjX+dzIT4jLKHxOG6fMqdeWUAghP5NNnprhncrqap6DAYi6St2znDds+UPWqHzQJPNGDeVRVn1xAPehMPKNUCFz7DKAXzavwNrcWq7i6UNQZOKKp2AMlkD4N4eOd0eAa8Lg+Wry7puKyj+/zzQ3IjyYEjeiinE88uZnQltbhi0woyRZcpzLJjetvqJFpBYriDu3ZAMd3jqLW9Enm4CtRk+21f898D8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FzURtjbh1BMXeIbIvlhHYOSGR+CZp5qngLInO6UfwOc=; b=3CSgR6w7aL+26Zx36/c8jb1g/06ZAwt/Cqb1Ak3P0fdLoqmHggqTcs+oq9sc4OxTgAP+sj9LJEG+a3QR/TbVxk4oImEodcnAjY9icHbYieZSDLhW1qfY5GZd9g0NOiL8ADbrk0/R9PasJ6KaXtTudDfdsSSEGqK3paFFib4NsDo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <000f22e5-1628-a937-0871-44ed498e1b26@amd.com> Date: Fri, 23 Sep 2022 13:10:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> From: Ayan Kumar Halder In-Reply-To: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::32) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|PH0PR12MB7094:EE_ X-MS-Office365-Filtering-Correlation-Id: 1dbb71c2-5866-46bc-bae3-08da9d5c974b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pc43/E1KAogFk62UjzSW+pUIfFN64V8CZ00r2lq0KxSs1cbPw2wytVIXda94cYL97Q03MeJhDM1P7erai8av+OKgbDkhRUyvEA0slcKXnz+ChHT98oF73IeytYUGfCK9ZbMQyvSZOVTP/clZ8lUw0cMY4sFIfCll4OwvhAQ8rJ0cw/iw1gAcmE/kVRD7x3s1JZnG+BnApOi2UmncGuDBVLx1QMM96eGDyFaogrXAVXRMJPFbnwQL7FR7Yrv1po3qBuZliezUA6hqc8rHsqRWGQAh4ro3CTYIMSbfcOvF/nwktWec9aNryLjvsQnrV0odS6lMbzQbTreCOyOmYmfdxJP4cYzm93cjbAYL1exAaae1Q4eUQUT8tQdct83hpeqevXIXhEsH+cnHRcqTK0M8GPtwRLjF2rfNk6QZFCfqL/tyFjaSeGAX7srAjHs7BaIHWR/Ps277bXssGfUC7ntjyLp9a4tF0hCKwbrery56nX31v4I8B9Wq7Brfxrz4Tm+Kh/TefnbghmjIoO0Hp3MS5fWOaF04JDmEddxePdRkaLwKKYWlTJyC884e/PEqVIIdQujdYWM5VAKxH7MqEe399pF5tU9/uoqESWOV5iLBUJEtE3dTr/UakEb7aNDecyfAW4OrVtq5Y7fvHr9raU8dNPRFABLqd7wdC9VRbu4eVPJgKUkP2M6/yWK22CXTklDct9B3Icn6vIHjtTky0i/pT0tokfkYOyDrRV0IvZtdWJTEy9BPpt78mJcxiQlgY4oQSv+gqxc52bOuSfaK67GWqn0kl2XVFD8c4V2fwCgMvFw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199015)(38100700002)(54906003)(316002)(478600001)(41300700001)(6486002)(2906002)(8936002)(5660300002)(66946007)(66476007)(8676002)(4326008)(66556008)(6512007)(36756003)(2616005)(26005)(6666004)(6506007)(53546011)(186003)(83380400001)(31686004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjZDSXdZME5XSEU1N2t1enZVaVpHeEhxNEZwZ1hwSlhhQkIwYVIwWlhqK1VL?= =?utf-8?B?UkJFZXRselZIQVNONithNWF3Y045eGZVYmQ4MFJ3V3IybGgrTzdQS1N4djc1?= =?utf-8?B?M3BwODJHNGZuSkxLU3dNU3I4ZXVpanpqcWgzc1NBdjNvMGtUNXhVR0FpcWta?= =?utf-8?B?WTJWSXdTWE4wYXJSeU1KZEp5L0FJbnh5UFZQVWg3dFMzT2VHdEQvS1lTV2RH?= =?utf-8?B?MFd5S2kxVlpPRlhQM1ZUNXR4TXA3d016ckJ6TDl6MXJQVUdsbGN4UGprL09W?= =?utf-8?B?c2ZxK2p5RmdDM3lpMUxINzBSZXl1Rm5aVm8vQlZabXpySkdPV29DZUlsc010?= =?utf-8?B?MWJ4bnZkUDJ5amVPaFlVRHEvY0ZoVjBJWnlBNC96dlNVaEt6dS82cWZSTElI?= =?utf-8?B?YlBwM3UrRHFweGg4Y0x3UitrRlQxL1J3YmYwTFp2SUd3UFBaaThDSjJoV1ds?= =?utf-8?B?NmZlQVh5bmJCcGF6TmhiaHNCSFRVSFR6cHd2UXp1aVU1OXYrREpSYnZjTklI?= =?utf-8?B?cGZ5OTVzUlBETjdBSk1ZTmV4dkZnYUM2U1hWQjRYZThnWUMyeFIwMkYweVlZ?= =?utf-8?B?OFpPeWhmS0lXdUZaRlduMkh2NWlRUlE1bEk1MmJiKzFUMnpMTFFJa2NqcUlU?= =?utf-8?B?alo2S0E5Q3BJRXFjSHorc1VkS3I5dXVhVGp6LzQrcDU3TWZNUzNaQWwwbnNj?= =?utf-8?B?M3U4bGo5TFluYldPR0xjZE9WSU84bFNUQzZxc2ZGS1hSWWQwaUhuUkliNlU4?= =?utf-8?B?NXVtd2JxQXdsSTl0WExSQ1lPNnR5RTI0cWIrTW5RVHZGT0llWGl3Sk9lckc2?= =?utf-8?B?WlUzMnc5b01XVlQ1OVNTOEVqZnhCeVlnZE5jL1g2bUNLSEdHNjNTZW82N2JL?= =?utf-8?B?ZjIrcEUyQWxCN0M2NVNxdjRPK0RqZ1lUaExGanR3WW9iZmtzNlhmNUN2UlUx?= =?utf-8?B?bDA5bE5XK1AvVnJYSVE0WGlpRzN4dkdzZlA4ZDZZNjNvWlFxa01BeXIvSHdR?= =?utf-8?B?dWhFQktCWjk3NnJwNjNIK2s1a0EvY3Vac0UzcjBVOUFGL0RiaEpIYityeWRu?= =?utf-8?B?TjhhL3JJSlp3U1N3VkpmU1FsVElyd1Rvbk0yMmFuMjVyQVpuZWlkbzF3ZnRr?= =?utf-8?B?dFRiQnBBK2VyUWJEV0c4ZFVUbTBKNW9IMHJpOVYwTTBFbitLK1hISklGcEwv?= =?utf-8?B?QlhpelZ2TUI5Q3U4aTduNkQxNmd6Ui9rb0dSZkNtVDJZc09Nd05YQVo3ckNC?= =?utf-8?B?MDF1OGlGcUJaQk85K0VaTE5sajNMZjdtWlNsdTZ2TlVyNnRXWVRmZ2JXQ2l4?= =?utf-8?B?SWpjWHJqRTNUSG5JNE5SbUxUV0F6bzhuU01CWEl6VXk0ak03NkhEYVd2QkN5?= =?utf-8?B?NVBsUEdhQjJMeTZKVTFLYzl1QURXQXRlUzloOVp5SmV0cU9pallTRkg2RTdi?= =?utf-8?B?ZTRtbnI1WXl2c041bmxQUDBDS3ZNRWRJWHVGZ1NaRGFkYm82M1hVSGk0eCtu?= =?utf-8?B?YmMxSEZySmp5ZXlUalNEcXFKUHp6NDVYZUxYRm9WWEEzbnFIQmtZWGE5R0o3?= =?utf-8?B?Q0VwUW5TY1lOQ3lCa3VDQjBoY2I0STdSeG5IMmk0bnhSdnErdFBLUXJKVW5z?= =?utf-8?B?VHBNdW1rZ0toR3BoY1NhUmNxU0tKN0NDamVubzdtSmd6QTU1V3Q3algxWjQw?= =?utf-8?B?bTBXb0V6Y3E5V3hwSGlSaVZPaGt2UWZCd1EyS3dpU3FLYnBTM1RQN1lEUkYz?= =?utf-8?B?WHY4aWNEZzFqZFlMa0p6OGFISmpQSE1vOE40ck0zVlRXN3plQlB5VmpId0h4?= =?utf-8?B?cFN6SVdtc3ZBdldETENwdTNJRjJqaFdqa2xVRFdEZi9vOERCQVd6Z3paK0dW?= =?utf-8?B?TzRuNVdtWFVRQmJOWThwaGFPVVM4NHJoN3FiVTAyRzhQREVoTGdZVlFZcmVL?= =?utf-8?B?UC9LSnlYbWJ1emJBczFRR0Y5Rkd4T2hqdHVhendxaWFmd2M0Z1oxUElKRXZn?= =?utf-8?B?UjRNN3NZeGNVM2pYUnZBeEFUV2IxTkFsN2t0YmpaRU40VUNNVGc4M0xaa2lS?= =?utf-8?B?dkllYjlIcU1TbkVCSC9zZGthUGRLdmVJMVEwQS8vNFhicUJ3ODk0c0QxdFl2?= =?utf-8?Q?XUlYVEztNIjCJ8fPdIhx6VLGe?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dbb71c2-5866-46bc-bae3-08da9d5c974b X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 12:10:22.9252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3O09BJZoAYIdkDK+4ZReSM0NM4jOW48cAtnBiEepr+TfGKZ38jhh9820n9gM6e9yOx7l+AWtuQ0iqdrXKA0V+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7094 Hi Rahul, On 23/09/2022 12:02, Rahul Singh wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > When ACPI is enabled and the system booted with ACPI, BUG() is observed > after merging the static event channel series. As there is not DT when [NIT] : s/not/no > booted with ACPI there will be no chosen node because of that > "BUG_ON(chosen == NULL)" will be hit. > > (XEN) Xen BUG at arch/arm/domain_build.c:3578 Is the bug seen on the gitlab ci ? > > Move call to alloc_static_evtchn() under acpi_disabled check to fix the > issue. > > Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property) > Signed-off-by: Rahul Singh > --- > xen/arch/arm/setup.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 61b4f258a0..4395640019 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset, > printk(XENLOG_INFO "Xen dom0less mode detected\n"); > > if ( acpi_disabled ) > + { > create_domUs(); > - > - alloc_static_evtchn(); > + alloc_static_evtchn(); Can the code in alloc_static_evtchn() be guarded with "#ifndef CONFIG_ACPI ... endif" ? - Ayan > + } > > /* > * This needs to be called **before** heap_init_late() so modules > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Fri Sep 23 13:56:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 13:56:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410779.653928 (Exim 4.92) (envelope-from ) id 1objAX-000726-S1; Fri, 23 Sep 2022 13:56:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410779.653928; Fri, 23 Sep 2022 13:56:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objAX-00071z-PM; Fri, 23 Sep 2022 13:56:41 +0000 Received: by outflank-mailman (input) for mailman id 410779; Fri, 23 Sep 2022 13:56:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objAW-00071t-B9 for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 13:56:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89dcbcc4-3b47-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 15:56:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89dcbcc4-3b47-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1663941398; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dkzt/96Dvt7NoHWsx4TQSh2RpTZK8WHZ5IawgFJDZFk=; b=b/WJ7zNjmbXjP24NKTK1E1idM0S2A5YkPWYzf3p/8PfGCWpFBTnYb6Qg SU91M0QEBzHdz+MmUgQOxOtvUaXTa6XGHN+Zj+qMdDyYHVq9l2xequlHA ZjJSXiSX2IntcSANnHx90GyNM24vfv4x0Ust2dqZJrQ6puWXDis2pxnhD Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81223703 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A8KOx7K5KiIMDKvAA3qJQgQxR2vbMJQDmSyYv2?= =?us-ascii?q?9bI7kJr3hzvcnyo9D/mcekdWBpeNJDhPy5nfkyN4CH03zbIScnTgcgFr2mXj?= =?us-ascii?q?YNR34oRyMGovQ3zzpCkE4M3NKU6iubEXqXl6WyUbWMFX1baI4wvZ3+S/ub5n?= =?us-ascii?q?98x+0Lafm8/6RU6zp/A1hntKSXYcerdyAcpTd9gunxOPcF+ugIuiA/38FGri?= =?us-ascii?q?uE9dUcNnTB7FEL/0hFxmAQ+Ao4elIf39/jCkfio76MZTReCBisJZVtA9o3G6?= =?us-ascii?q?0Ks1uIbSW1xAQHueHxggzOTDo+it1ljv/z49qCrKz4jEdQ6PNucDZKNMeGsb?= =?us-ascii?q?U2fRe9QvrsMzUVQY2nPriEw+hMVw20QI2jl3AD3AnX29yp8ORbedvHY3Yit/?= =?us-ascii?q?5y6c/j6HiZyOEgKMrop/hZXlxROwgKjOpGO6cfqathKwT9Vvl1Zl8sQ1ffmU?= =?us-ascii?q?qSHyaiNwFdHKCU42VaPhSiNRf+agO5Npe1RXhNzeajvDtfJ8T5nDRRNpIX8n?= =?us-ascii?q?dm5QNyzohJFNeaTJAbJFTBr5G6LCP6MAjG95H3v7YDtNVYCBtQes5y8kLx6S?= =?us-ascii?q?Vzl9+1SN5QlwwZZq4m+JCUP0eyvTNZ8m1ldjDWiLfXl1gvKri3A1kg4TSS/E?= =?us-ascii?q?qrJyab2QRlDMrOpPd3/z2w7IN0nLJ2Z0rMNp+kBlFGPWnmVxQSIRP2m083DQ?= =?us-ascii?q?YWIA78aIhRvdpA/wVAUrTTN6mFYsIGQH8eju8h3cmyCfJOO/chQbA2MG+cya?= =?us-ascii?q?hGkKbHzH++L+JdJ6yC0aEO0TkpyQC/63GTVHFSFkkKESRLdhg45ymorpAu8w?= =?us-ascii?q?OiYgYgHdWkWR4qe/UEAJ1gvcgGZ6FwvVSuYBMumTwcWN90IzR+ufXgVkcXbs?= =?us-ascii?q?sVjADP3ihWgIeD8rziW9KTeEYNaV9jeoUWHgPAqHOSeFq9PUAmrgLEn/+0Mh?= =?us-ascii?q?4kzdna32zUCFAGHQEfig7PngTAS7+CCYDP1F5v/6tTID+/ruiKuPyTNxuMX8?= =?us-ascii?q?u7LG8UwVMl4QDyMlx0Ws2UjV2kSyHOmDj/6tjGUTSh35Lj/cyrL7Xx0++OPF?= =?us-ascii?q?0hB1Rn4mEoc9ApkfBHhdoS0x2LkFCmyzXYF/5+kdYXwHJQSC3XfAMK04B3f2?= =?us-ascii?q?tD71rMGMqtc4HYOg9jjlCbU2cz2akg7JjCuMRU3miKAzfWMmyU8p+xMPIpKv?= =?us-ascii?q?ZlUHX/aYN76RRU4Um+FFkBVzTppt1rpEeIGQmQE0oMehqyNq5cmFIb01WNzg?= =?us-ascii?q?+tJ2hTGmoCnhOH4SCO3YiAFiQpxglSqEe5MImZgVXReDlxLyqfLTf9lOrxWd?= =?us-ascii?q?xNI+8nVLTJnFdufUKCv9UE04DI9B42TXLaWqG64XFKooaBuBR/XDC5jihbjs?= =?us-ascii?q?h3CLk5DyXBc5T3tedPjZLfKUxvlBhDb5lXBN+EE33NIVcTQ25MKSqjC2GObt?= =?us-ascii?q?Tsxcz0oiGJui+bToWE9WDncPgzUfhMR94VyjWjSyRKAHM3SGM3rswrCC+1G9?= =?us-ascii?q?9yn6RljhZJ8rvIRJNeg71faJlW5sZ1EY7Mn0YjGGh6J02VJWq6E22muydfWq?= =?us-ascii?q?pnOXK6ZutUUvoAeKClTrqzFxR6CUYEUNNXVRFNMoSSCoLMxCo7YRH4wQeo41?= =?us-ascii?q?H3DiPg/EpsSC32vof0iHI8rYXj44uyb9CLn5L79skoKGh5mOGUToNBge4228?= =?us-ascii?q?G9B5rKmgiM5XgETPNDPjriZGqtLI7AkXILBSQOzIREDNrLas6to2Pkoz+rEE?= =?us-ascii?q?ntl6KszrF4F3T0bhJQdmbQNCrr6fYf4i82JfN2ozsBNU2fi9neim8S5Y2G56?= =?us-ascii?q?UjAAz2WXh9uVqJHP8xXOXWpwmuyB0iTXiHBWPM6H1s/JnB1DkKecLOr1RiDM?= =?us-ascii?q?lexIFr/N0eJUCrH4k4UDGFb2Fq0tYWnHT2VHYoeRqQGKWE4qT/0kqMEaULaK?= =?us-ascii?q?aD79mYOPqeIZNppbBcee/gXSTh7Hr/dvfuTBTDp6iodUncFnLRcRV0lCl/Mt?= =?us-ascii?q?ZWCjyh7PfWeba6PyzymS3Utpyf4x1lyxFL19VPPPLs8bPhsbX9ENoXgjLcHY?= =?us-ascii?q?cTyIcnf48cUYvsDZ7V4RjkMTYn2/UXYLn7bEhK9vWoZHYyEeyPGLohTc5uiA?= =?us-ascii?q?EnokoHdDO5iU6DKzOxzbBgxxTGS7hklTULhIhNKeyROhHGabMS3DPgvIIcNi?= =?us-ascii?q?PEu1sUri0EL23ZBYQ+Vzr3BT9vAPs3oVeaqherOqV5Im0JS2TYpUgZEwJekP?= =?us-ascii?q?qDa4PKZwssgabNz6muXod1qgUEqoloo6GT4xk5dMag4XkyT+DoBtp8NMqCtd?= =?us-ascii?q?sgXbwH8uQTkLTlBzG1aMCDurlqtuph7+OYi28X9UFWd1bGhNqW932ddgzJMZ?= =?us-ascii?q?FlEYh7sGDoTM6AKjNj3/gE4WU9qol73quB4flNoP4nophMZsF3GRFzoANh5e?= =?us-ascii?q?9nYhloHGMyyl/CMGL0DwMPKmCNPpEus0eBPjoYMl0Z+a/aANXqbOhV4bjON6?= =?us-ascii?q?AZ5vFWkjDtoIsLcTGgBbvbYQoRX16UeH01TqKK93Tr0LEKIE81xdooKAkmvC?= =?us-ascii?q?h6HH7zaookBoOw4OMxJJHY4+cI/Sjo+OSCMJX02/g2I8fyOUaajaK3iz1gFR?= =?us-ascii?q?RoglfrhYPBwMYKHJCtcXZqgbt/XrUkVExf3AxyElmMFMe+3SR5XaLG/dtwCA?= =?us-ascii?q?Sfjig9HpRQOuF50twQS6UvA2sK6Pjtlk54bYkqtSOF+Gg52n/U+5b0QK0rJh?= =?us-ascii?q?2hHgFAAHSFpvKQLtapIY52WM3IIcJB0pxAPDUEngHNXxHY2fSoIcJIsTOhNk?= =?us-ascii?q?1Gw7MIBYXko5hSsJZjxvAaOW2tZGSVI6UxHhBUFJvsYTxWrUcYPhTe/jUFiZ?= =?us-ascii?q?LvRVMWLu3888I+n0roRYjLrWG8bN0hA?= X-IronPort-AV: E=Sophos;i="5.93,339,1654574400"; d="scan'208";a="81223703" Date: Fri, 23 Sep 2022 14:56:31 +0100 From: Anthony PERARD To: Michal Orzel CC: , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 4/9] automation: Add Arm containers to containerize script Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-5-michal.orzel@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220922134058.1410-5-michal.orzel@amd.com> On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote: > Script automation/scripts/containerize makes it easy to build Xen within > predefined containers from gitlab container registry. However, it is > currently not possible to use it with Arm containers because they are not > listed in the script. Populate the necessary entries. FYI, those entry are just helper/shortcut/aliases, you can use any arbitrary container with the script, it just more annoying. Your patch here allows to write: CONTAINER=unstable-arm64v8 automation/scripts/containerize but you could write the following instead, for the same result: CONTAINER=registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 automation/scripts/containerize I wonder if the script could select the right container base on the architecture of the host, because "alpine" and "alpine-arm64v8" will not both work on the same machine. It might be nice to just choose "alpine" and the script would select the x86 or arm container automagically. Just an idea, no need to do anything about it. (patch is fine otherwise, just the patch description is a bit misleading) Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 23 14:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 14:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410788.653939 (Exim 4.92) (envelope-from ) id 1objYa-0002LA-UA; Fri, 23 Sep 2022 14:21:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410788.653939; Fri, 23 Sep 2022 14:21:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objYa-0002L3-Ra; Fri, 23 Sep 2022 14:21:32 +0000 Received: by outflank-mailman (input) for mailman id 410788; Fri, 23 Sep 2022 14:21:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objYa-0002Kt-6t; Fri, 23 Sep 2022 14:21:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objYa-0003oB-3X; Fri, 23 Sep 2022 14:21:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objYZ-0006rb-M5; Fri, 23 Sep 2022 14:21:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1objYZ-0003kj-Ld; Fri, 23 Sep 2022 14:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DJMf4QnlggaMcIr2aCwfGXtt4tiXUsljlbHjoiNoBHY=; b=bzXA2zHy4qz9gpPX0fi63SHb1J VwDQ33JZi7xSArW6k7Yc8AQNEaViYdqXv9XrVAo8yq4eWeo9cB4Rx/zjASZQRlkxdybaEqjlNXbmf JPFig/dcIygM2VbWx18fuDNq6P9RR9mR4CWAdsZh48WkQjfZt/TooTV9/yFJTYkJiJJQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173290: regressions - FAIL X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression X-Osstest-Versions-This: ovmf=a8e8c43a0ef25af133dc5ef1021befd897f71b12 X-Osstest-Versions-That: ovmf=5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 From: osstest service owner Date: Fri, 23 Sep 2022 14:21:31 +0000 flight 173290 ovmf real [real] flight 173291 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173290/ http://logs.test-lab.xenproject.org/osstest/logs/173291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 173289 version targeted for testing: ovmf a8e8c43a0ef25af133dc5ef1021befd897f71b12 baseline version: ovmf 5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 Last test of basis 173289 2022-09-23 09:41:41 Z 0 days Testing same since 173290 2022-09-23 12:13:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christopher Zurcher Christopher Zurcher Yi Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit a8e8c43a0ef25af133dc5ef1021befd897f71b12 Author: Christopher Zurcher Date: Thu Sep 22 04:25:41 2022 +0800 CryptoPkg/OpensslLib: Update generated files for native X64 Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Christopher Zurcher Reviewed-by: Jiewen Yao commit 4102950a21dc726239505b8f7b8e017b6e9175ec Author: Christopher Zurcher Date: Thu Sep 22 04:25:40 2022 +0800 CryptoPkg/OpensslLib: Commit the auto-generated assembly files for IA32 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3654 Adding the auto-generated assembly files for IA32 architectures. Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Christopher Zurcher Reviewed-by: Jiewen Yao commit 03f708090b9da25909935e556c351a4d9445fd3f Author: Christopher Zurcher Date: Thu Sep 22 04:25:39 2022 +0800 CryptoPkg/OpensslLib: Add native instruction support for IA32 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3654 Adding native instruction support for accelerated OpenSSL features for IA32 architecture, following the pattern set by the previous commits for X64 native support. Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Christopher Zurcher Reviewed-by: Jiewen Yao commit 0c9d4ad788e90b96b0dbe2bf7e2f8ee38c6ab4b5 Author: Yi Li Date: Thu May 12 17:10:16 2022 +0800 CryptoPkg/Test: Add unit test for CryptoBn Add unit test for CryptoBn. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li Reviewed-by: Jiewen Yao commit 42951543ddc56e98d413a73ecb57618f01ef20ec Author: Yi Li Date: Wed Sep 7 16:14:35 2022 +0800 CryptoPkg: Add BigNum API to DXE and protocol REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 The implementation provides CryptBn library functions for EFI Driver and EFI BaseCrypt Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li Reviewed-by: Jiewen Yao commit fd0ad0c3469fbc6faca2d1c6ddb13dd5f10acd28 Author: Yi Li Date: Wed Sep 7 16:12:00 2022 +0800 CryptoPkg: Add BigNum support REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 This patch is used to add CryptBn library, which is wrapped over OpenSSL. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li Reviewed-by: Jiewen Yao From xen-devel-bounces@lists.xenproject.org Fri Sep 23 14:46:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 14:46:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410798.653952 (Exim 4.92) (envelope-from ) id 1objwR-0005M9-0q; Fri, 23 Sep 2022 14:46:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410798.653952; Fri, 23 Sep 2022 14:46:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objwQ-0005M2-UR; Fri, 23 Sep 2022 14:46:10 +0000 Received: by outflank-mailman (input) for mailman id 410798; Fri, 23 Sep 2022 14:46:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1objwP-0005Lw-FH for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 14:46:09 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 757fa0c5-3b4e-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 16:46:08 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id z6so389514wrq.1 for ; Fri, 23 Sep 2022 07:46:08 -0700 (PDT) Received: from [192.168.18.134] (54-240-197-239.amazon.com. [54.240.197.239]) by smtp.gmail.com with ESMTPSA id bn20-20020a056000061400b00228d7078c4esm7802940wrb.4.2022.09.23.07.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 07:46:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 757fa0c5-3b4e-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=5dKyLNAFPtIfqdPRxJaoTYKZE22uPEk/oKvtZ7XZNlw=; b=aHUmLESOnd6l5fs1LbJ7b58jWIGTGrZl1zlxag2mItvwsAPmb2fI82iPWXjJssLr5x DFeqNib4sBFuDCdHwnwzYPM/ih4K4da1t7mRHYOstLV4GzuLchrsbcx5jaU+lESyWkX8 GuisRZErGcTLprnN9X1svgif8XRgaVRaek+sOySR7PABgDBVLzxBc/UhGxRjNiqvm7k5 JyDGSgi0Al6X1EswaPKjGFHbD5qYen4TNBGxHaeiWmV+oATxlKGyI6nppJBK0SEGNq1F ZjbgAbef9oEI4ifu3yEemaEo3muQhmFjz4cHUt9EIqo7+jNVbonThkJ0hjwdKNkWG8Sr daNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=5dKyLNAFPtIfqdPRxJaoTYKZE22uPEk/oKvtZ7XZNlw=; b=ez7LKPhIHYMmkseE3iHnKENksTbv6ACfFb2b3y+xQSs1YxneblIo5S8ICfBxQ6oPME 7scCq28kMZ0lRVc8djcM6XeatpO5zk4JNGMW7dbsXdSNkywXhVfmeAXBguFl+fQYOQkf BYKZqvarK0mh7nRWAmi45lPvCEL1J7bXzeYPh6zCueVAIJx9GGJ68lwpX2iOlcbebuHA y3HT1MJ4AyEnvzv0pf0q3sIX2PI9ljhWFyMsTL7tu/JwyBZzWIpnONiATOpReUizJZ2v S3AqZgPjsi/ipqivkJR0hONvWnfj4/5zz0DDo1l01q6obF7Nu4xyKBXnMSA5WLougPfk /YcA== X-Gm-Message-State: ACrzQf1XZ7s0f7JxWMzrj/RrGvA2MlP3jVOaYK4eZSSHOn36W4hp7XmB TGxhXU3QmKZLMWoZ6xPUcjHPDKGRWFxivQ== X-Google-Smtp-Source: AMsMyM644IWpNcCUyKNNjeR1BeZbOK+8PjEujJrEDKRnHF6/c7RyzMJjqy6Btsawj0Q+mEyuBilvoA== X-Received: by 2002:a5d:5591:0:b0:22a:e401:2052 with SMTP id i17-20020a5d5591000000b0022ae4012052mr5586519wrv.435.1663944367742; Fri, 23 Sep 2022 07:46:07 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: Date: Fri, 23 Sep 2022 15:46:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device To: "Ji, Ruili" , "qemu-devel@nongnu.org" , "anthony.perard@citrix.com" Cc: "Liu, Aaron" , "xen-devel@lists.xenproject.org" References: <8be84a25-c31d-fd88-f913-c03c15046a55@xen.org> Content-Language: en-US Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/09/2022 02:19, Ji, Ruili wrote: > [AMD Official Use Only - General] > > Hi Paul and AFAIK: ^^^ you mean Anthony :-) > > Thanks for your help. > When could we see this patch on the master branch? 😊 > Our project urgently needs this solution. > Anthony? Ping? Paul From xen-devel-bounces@lists.xenproject.org Fri Sep 23 15:43:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 15:43:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410861.653997 (Exim 4.92) (envelope-from ) id 1obkpd-0004Kk-IQ; Fri, 23 Sep 2022 15:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410861.653997; Fri, 23 Sep 2022 15:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obkpd-0004Kd-FN; Fri, 23 Sep 2022 15:43:13 +0000 Received: by outflank-mailman (input) for mailman id 410861; Fri, 23 Sep 2022 15:43:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obkpc-0004KX-62 for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 15:43:12 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130050.outbound.protection.outlook.com [40.107.13.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6cbd64a9-3b56-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 17:43:09 +0200 (CEST) Received: from AM6P194CA0090.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::31) by AS8PR08MB7337.eurprd08.prod.outlook.com (2603:10a6:20b:444::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Fri, 23 Sep 2022 15:43:06 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::d6) by AM6P194CA0090.outlook.office365.com (2603:10a6:209:8f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 15:43:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 15:43:05 +0000 Received: ("Tessian outbound 9236804a5e9b:v124"); Fri, 23 Sep 2022 15:43:05 +0000 Received: from f3fc23c10e67.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A9FE9C4D-9092-4DA5-A709-35B9CE9424E2.1; Fri, 23 Sep 2022 15:42:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f3fc23c10e67.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Sep 2022 15:42:54 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DB3PR08MB9111.eurprd08.prod.outlook.com (2603:10a6:10:43c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Fri, 23 Sep 2022 15:42:52 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::3475:c78d:9d75:6137]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::3475:c78d:9d75:6137%3]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 15:42:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cbd64a9-3b56-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jePM00MneEfZ5IM7n/OjIO0xyig9bx+chJG8G3S+jlhvV3vyPP5RCAowrqQqNE4o5yeiG6GKwzchp5JiZcgArbasbNRPkAlKPO74yqEquNwGdapc3PKJT2TcZsE6coV/DQDE1KAeDI0IadUPgfGY8sM/9osG60UJHLchkB6f1a8t9aKm883CJN9RykeTFY9fV0NIhfgA2s05ugBlsDV79AMcGGhxd/cDUzgAohqW4dNXYIl5GwKZKxDDzibYNhWjGYaAnQCcDC/09NTkxh8RV3SVNnE2EoxoqLSeF75l0HFlR2kkd4pfeg2g/zJrIcyBUEq+JMnynjbDsGyGSqCetA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+jU8+ToR2i5jp0usVgH7Lokh2KuQEXfN0JTZgDdlRU=; b=PFUHkzPo3hUpoFXheliJnV/gEq0TZoNbIRRn168ctCtFX9dRblbdpG3WFMZOAquA/iFe2RjEwbq6PNyQf8Ok9iEGW7zD9hp+GbaHkY+4fK+Trq6IVdUDbY6Vz2hSFWEv8MW1Wk1kzfcD06+lP0/yvNinhkxySxCiQdIHbkzLiqsqDVOF+6Pi9OrMiXPuIbp5vRT2xwJW4UvXbu359QgdA/x5xPfhfaIGMC4A0zwGGPbCA1Pxh3bFDG0KguaHJ5k7lyp6y9zlzwYOsBoINbAIT+goMF/7TJLKZdbPR2nTI4Y6XCtPq4fPm0Q9QcD4qCzt2dEoYQN4Cl5JRWiUO1cyLA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+jU8+ToR2i5jp0usVgH7Lokh2KuQEXfN0JTZgDdlRU=; b=Mi9mdacy619XrEcALM5RS4GKSWgsuh3MzSvOLWj3FlWBeWGUhVcRlZGwsoP1ZSu63aSI23qyz5VxXa2mcMwL3dtgt7hfW3wPqXyZOWUZdMVKwNVZWaPot6mJ79c6+AXiXWqeg1IEIB9QeDm5o24I5NFElEfnkDdgQpbLvQOCLh4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3577572f0199be4d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjDkYCysTXhL61HkBkdxE7BJ6oF6/XW4SWgoNtXQ5kzqhu+OEfLP6xNfIMsyVhwM/7ePdQSsmFPkY7b6TimItznzBNeYBKaTKPrAFgeki+uMGZGijnb/4Nf4Q6XJ9/6dlA6QC1g5Xk/dYUMBfrQyIZ9lP1SKV63lDMWV+mG+7fiuF4p1Rd5pPgLAAPZLFTUoueDShhTApVnLSE4zNmCb4Ny8KK2u3UiY06pmG/2+u3uL4LBh1U8rxXWDq4pDp6+0qaudsOcxnlrG9IIOTzxsXZrateCOHqvySc8dUHpPlmzuIGY7yEHHtvGMyk2tTipbda6rHv0NCFqp4xaPJitkvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+jU8+ToR2i5jp0usVgH7Lokh2KuQEXfN0JTZgDdlRU=; b=RY7yc8Ky0XVui+NzUR2+91q+kzzp9yppyQMNiexDw7XiQw0VeG3/BEjN4ZWmegKoaguKVaErczS+BJ4n6gbCDA3hw1GvVEP6ooJpQSnDkeYRGciMh3ppE8hmnnzW7j7VRaROZYlN1hW/f1dY3RH6u4NaStRRtyHDoMrrszB0MUQmqki+jhK5J1RHUWLKBRk7JgNLuFLhcqA6ggznoUlFYh4ilC/mqgt+Clu3z/9OZOkkV7CqqQA55xyXfG6KwHGayuYH65i/ZVnC0DZxwp0J4h8xdtLRrNwSkLkqmLO/tDpvgdfdQfHXilwHh+1YYHuGA0TgqFwtSIodMX5Fx7O1zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+jU8+ToR2i5jp0usVgH7Lokh2KuQEXfN0JTZgDdlRU=; b=Mi9mdacy619XrEcALM5RS4GKSWgsuh3MzSvOLWj3FlWBeWGUhVcRlZGwsoP1ZSu63aSI23qyz5VxXa2mcMwL3dtgt7hfW3wPqXyZOWUZdMVKwNVZWaPot6mJ79c6+AXiXWqeg1IEIB9QeDm5o24I5NFElEfnkDdgQpbLvQOCLh4= From: Rahul Singh To: Ayan Kumar Halder CC: xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series Thread-Topic: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series Thread-Index: AQHYzzwtnQ0btLDO4Eq57Exdd2Iqca3s7GqAgAA7ZIA= Date: Fri, 23 Sep 2022 15:42:52 +0000 Message-ID: <510F20E8-B6B9-447B-A40A-9947D9A49D95@arm.com> References: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> <000f22e5-1628-a937-0871-44ed498e1b26@amd.com> In-Reply-To: <000f22e5-1628-a937-0871-44ed498e1b26@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|DB3PR08MB9111:EE_|VE1EUR03FT006:EE_|AS8PR08MB7337:EE_ X-MS-Office365-Filtering-Correlation-Id: 61eaca7a-98c3-40c4-03a3-08da9d7a4ecd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Yo5b5xv7DkAECFevi+05iXzekcMslHL3mcBcSdPvR4eUX5eQOyHBS48CcG4ynNmDI1V3DOsQGvk18qtFHhIHiZfC0sNAd4VTJVmkLBaaiy48ARQ9RPqyUPZbzihK/5aVlSFcUCWtavlGshpI25sUj+XHvOBBPym2aIZnyhny7UeJ4MHuiSkrhxFFodJdGxC5Yn6YanvCOv/tifDphFZ+FmGkv3UPNJp/XnGLeqaqG0xkPT+E9rAVoLVfpBi7Nk7VTWsc/rjkYQHKSIhxr5lJqma6v1INFOdZw4pVStBxcVU+hz7aZVEqmcrSmilKcWeubuFh5Imojz1N3C00KP6ZAong8jVru21q+PcKo387jMyI5A8PUrz+RolTeZblJCPtEZf+bx00JF2Mfz/W5GJ3RtF6BA2dwF13zhlKj1iuQGZWPI/F539BuJS/r8sNsrmCQ0cqD/rdJSEC2iAC7G4291wK9eCfvnHVos5gAkMH8ifwHF5e6n7pszksuCDbTBZiRSXKgHnIXMffAVF+HPm6yBz+5jpT+6zm5zu+cMxB+WuQWyZOIt3Q3h3DSv5nxjds+LENjNrJvR7te2NiOXjh7AEw1kEFozO7x4EPQSF7oZzkOKJuyPcu5+Sc9PyUl4mxVUxNLnqpQyhvSEcvpIhl2vPfx83u1aj9mfu613hOVgYhcNzLyih/N6RhXoFy6rJRWXg7RIeGMdHPgyOa5C25VrYZOBSK29Q8hjRUEa5b29j51YJY8yrcE7CeEYyxz94DVQXCWNMRP2ciZiHqevGW97fKyGBNavbuEZaYuofyvGo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(346002)(39860400002)(396003)(376002)(451199015)(478600001)(6486002)(71200400001)(36756003)(41300700001)(5660300002)(316002)(66946007)(76116006)(4326008)(8936002)(66556008)(91956017)(33656002)(54906003)(8676002)(66446008)(64756008)(66476007)(53546011)(38100700002)(26005)(122000001)(6916009)(186003)(38070700005)(6512007)(6506007)(83380400001)(2616005)(86362001)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <927829C62FED14468D35CEB63D4832D5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9111 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a10a4a39-11fd-48c9-5d1f-08da9d7a4695 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9/0/edZ2TdP5p5AEYPtlNuD8Rl0tUb6fQyhbdz/ne9dMrkwi+6fbisSO3EkrmVKzov7KZqgYgjA4EAEw5phNtiuqI+wz49O+fEea9JSItY8Ow9wjonnGCnUTI7KS4MlBjJe5NJVpzF+ZCtrKwLAY678GSHfqJuRAUHH2gqLNrDH3tqfAIyGhwvZTGU4OIqYX7f/D3MpQreiTaF8XCebq21f5PnN4X3ZHVMDYMwyClXC+uRocqXGqw4fsbLYhSjone+09E/uPF9eo75WE0x67gI8K/9DrZxOOT74Fu8Dv0E41uHLm/dTeTLjoQqoyeG68UyEFDaPpnZP8pxIXiuyYTCsAvz5faYDO//HdQ9J0+Q0wkF0lk5zYv8e9aLv5jY8F49MRcMBxOUcxx+r3/zQZMn8gYLazfxGZ3w0pND8udW+cBnmdJnDUyjFX8pux+O4w7mYHR9tyNeJpkhuUag9xksKzvoLQfAYFISkRsv4NibFa4u5P5SqZOV+GC8OG6eIwZsfCSZYe0Cl7qLkz3hKF8gNENFRl3SrO/d5GXogCJavmDq8hChrW2NripKJLVKM+ci9K4VyfhfOuT+zKYP7HV5PkScHLhJt2ELoyUhLy3Mbk199cocUUkIxi4w2oSsgVRsK+h/QEFzYpG325QvG8akz48Fr8sqsRBUiNM8NMvK6NTPgYrhkwoKETsU2DeC0j+tWY2A07YZ5wXl13uQWp5T37/WofNt/EqklEgbg6JEHMa6v91j4gcVB0laXYW8NMm4j8F8011eYxnuprkv6IPA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(26005)(6862004)(5660300002)(6486002)(41300700001)(8936002)(82740400003)(356005)(6506007)(33656002)(81166007)(40460700003)(82310400005)(53546011)(86362001)(40480700001)(54906003)(316002)(70206006)(186003)(6512007)(8676002)(70586007)(36860700001)(107886003)(478600001)(2906002)(4326008)(2616005)(83380400001)(36756003)(47076005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 15:43:05.8882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61eaca7a-98c3-40c4-03a3-08da9d7a4ecd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7337 Hi Ayan, =20 > On 23 Sep 2022, at 1:10 pm, Ayan Kumar Halder wrote: >=20 > Hi Rahul, >=20 > On 23/09/2022 12:02, Rahul Singh wrote: >> CAUTION: This message has originated from an External Source. Please use= proper judgment and caution when opening attachments, clicking links, or r= esponding to this email. >>=20 >>=20 >> When ACPI is enabled and the system booted with ACPI, BUG() is observed >> after merging the static event channel series. As there is not DT when > [NIT] : s/not/no Ack.=20 >> booted with ACPI there will be no chosen node because of that >> "BUG_ON(chosen =3D=3D NULL)" will be hit. >>=20 >> (XEN) Xen BUG at arch/arm/domain_build.c:3578 > Is the bug seen on the gitlab ci ? No, I found the issue while testing the ACPI boot. But going forward we wil= l add this in our internal ci. >>=20 >> Move call to alloc_static_evtchn() under acpi_disabled check to fix the >> issue. >>=20 >> Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property) >> Signed-off-by: Rahul Singh >> --- >> xen/arch/arm/setup.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >>=20 >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index 61b4f258a0..4395640019 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_off= set, >> printk(XENLOG_INFO "Xen dom0less mode detected\n"); >>=20 >> if ( acpi_disabled ) >> + { >> create_domUs(); >> - >> - alloc_static_evtchn(); >> + alloc_static_evtchn(); >=20 > Can the code in alloc_static_evtchn() be guarded with "#ifndef CONFIG_ACP= I ... endif" ? Not required as acpi_disabled will take care of that. acpi_disabled variabl= e is used to avoid the CONFIG_ACPI. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:26:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410873.654009 (Exim 4.92) (envelope-from ) id 1oblV4-0001Ym-OW; Fri, 23 Sep 2022 16:26:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410873.654009; Fri, 23 Sep 2022 16:26:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblV4-0001Yf-LW; Fri, 23 Sep 2022 16:26:02 +0000 Received: by outflank-mailman (input) for mailman id 410873; Fri, 23 Sep 2022 16:26:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblV4-0001YZ-1M for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:26:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 687ce1e0-3b5c-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 18:26:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E6D1662879; Fri, 23 Sep 2022 16:25:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 566B5C433D6; Fri, 23 Sep 2022 16:25:58 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3D3B1E4D03A; Fri, 23 Sep 2022 16:25:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 687ce1e0-3b5c-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663950358; bh=6/yGaslh/dWxXVkqzgI2Ad98VykwZ0oCykFFp4Op0dU=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=mwkx+tZTkiJZ751ZhEz9dTJAbsuX1oEKXQ9ePnGwk+CGKv07L7UHhJA1eTbyY1/2U egmkaxwaMvTyZvJeq686QPAoeXk0MlSR0axayui2VfHeRBGw55xZwSE0gx5MBMbK8N mTtffgToBjAuuV71nw2dHE/GKK3ZwtU0HJTP4UVvEyugk78tlcqBZUu+dWBo4JdbKV ztzwLCxupIszpIW071AHdcWLqc4NJTALEgHDkinmZXfU+zIemamGNAbJcMkbgqjcK6 QFz/cRay04/8BDwZDmR5NbLEuNURjR3ek2IRTY4OVo1RIyE4659WdUeqmPqqQ+ppBI OqQ1wEZ2V3C9w== Subject: Re: [GIT PULL] xen: branch for v6.0-rc7 From: pr-tracker-bot@kernel.org In-Reply-To: <20220923084007.22001-1-jgross@suse.com> References: <20220923084007.22001-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20220923084007.22001-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc7-tag X-PR-Tracked-Commit-Id: ce6b8ccdef959ba86b2711e090e84a987a000bf7 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 526e8262856027cea38c45a5ff45fbe4204aed04 Message-Id: <166395035824.8411.4093321633967293739.pr-tracker-bot@kernel.org> Date: Fri, 23 Sep 2022 16:25:58 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Fri, 23 Sep 2022 10:40:07 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc7-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/526e8262856027cea38c45a5ff45fbe4204aed04 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:40:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:40:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410880.654037 (Exim 4.92) (envelope-from ) id 1oblj0-0004N3-MI; Fri, 23 Sep 2022 16:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410880.654037; Fri, 23 Sep 2022 16:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblj0-0004LJ-Hw; Fri, 23 Sep 2022 16:40:26 +0000 Received: by outflank-mailman (input) for mailman id 410880; Fri, 23 Sep 2022 16:40:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obliz-0003zv-SV for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:40:25 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c54ea6f-3b5e-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 18:40:25 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id cc5so834031wrb.6 for ; Fri, 23 Sep 2022 09:40:25 -0700 (PDT) Received: from 127.0.0.1localhost (188.28.201.74.threembb.co.uk. [188.28.201.74]) by smtp.gmail.com with ESMTPSA id x13-20020a5d60cd000000b0022af6c93340sm7717399wrt.17.2022.09.23.09.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 09:40:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c54ea6f-3b5e-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=NLIYqCB5GFGbnjqA6dYmmqdLI8BuNFTVxSCPXONSBRc=; b=owDxYda7B4frXz3u0Fwc1/mPY0PkIoc9YEt4hkPPANfeq4CAFBjXeUytt806Zgzrh2 Oflmk3RWPGkL3H4Kqr+rh0g6ue3kNa5qh9EG2VFQ5SqjrD782ppbdaoa2zK8ufjpi3tg YpW05bXLXbqTGO0ZMSAueq+peDDRvbo8UVlb48ZmGp0vWAJpfOl00oTe17PDhCBXTmcj 4LkSJcqD4FNFtW3MKLedobmMatlst3bdPyImM5Y1cg33OA2+GGukbR5y3KFMrsGkoqPe QYLUipMNRbiIvHjo0pc7wNIYe7Hj0Xd06Y+WNBvXMB+pfT+4vyFvrFYbZ+73u9ePpxWd LFHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=NLIYqCB5GFGbnjqA6dYmmqdLI8BuNFTVxSCPXONSBRc=; b=iSbJMo/KAePsC/dh/1kVu9SXfES9G0luB/nUJ99DVtTCXMA4z9DKTmUBhE+QlXKLZN CQM9xBZ6/v17xFedEB7mTiC3kna6y86op+C0cneIyo8LFgkajuQtW17mQb/5QbGKfu6T KwU7o4XlyVXXjdr2GaumqiWIEz4nSv+aKy2d7LSzQIQZS6rwZBywHmDiR5U2QjFpN3la 2Wg/D4q310O9xKCHOEDr8AajZDdgeL0yYDb9bPRavmPccMAmiTXDouds/P1WUiC1pgi9 TT4LUAyq2r3nWsnWe9Jry03xP4u2uEu0VUPWCJU6R/d/UhH3XCV8ZG3SJsa5n+A2PGlh lbeA== X-Gm-Message-State: ACrzQf1U7631u93MIg+6nXEKbIzS25Qjlex+r3D3BPtG9valHbrJ8wKY a3XLQLQIpugoB3xMrJ5W9LM= X-Google-Smtp-Source: AMsMyM5HMaxWgOxUGbCzg/XjKD/kmOOlcN0KKz9OmaE/RAZn/7aZ8z59Qz72lGSep1WOF16x4j6q2w== X-Received: by 2002:a5d:5c06:0:b0:22a:7b52:cda6 with SMTP id cc6-20020a5d5c06000000b0022a7b52cda6mr5635717wrb.485.1663951224622; Fri, 23 Sep 2022 09:40:24 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang , Pavel Begunkov Subject: [PATCH net-next 2/4] xen/netback: use struct ubuf_info_msgzc Date: Fri, 23 Sep 2022 17:39:02 +0100 Message-Id: <5e00bc6d4d8c3fdcf3ed02549ba8a36d5552e56c.1663892211.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit struct ubuf_info will be changed, use ubuf_info_msgzc instead. Signed-off-by: Pavel Begunkov --- drivers/net/xen-netback/common.h | 2 +- drivers/net/xen-netback/interface.c | 4 ++-- drivers/net/xen-netback/netback.c | 7 ++++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 8174d7b2966c..1545cbee77a4 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -62,7 +62,7 @@ struct pending_tx_info { * ubuf_to_vif is a helper which finds the struct xenvif from a pointer * to this field. */ - struct ubuf_info callback_struct; + struct ubuf_info_msgzc callback_struct; }; #define XEN_NETIF_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, XEN_PAGE_SIZE) diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index fb32ae82d9b0..e579ecd40b74 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -591,8 +591,8 @@ int xenvif_init_queue(struct xenvif_queue *queue) } for (i = 0; i < MAX_PENDING_REQS; i++) { - queue->pending_tx_info[i].callback_struct = (struct ubuf_info) - { .callback = xenvif_zerocopy_callback, + queue->pending_tx_info[i].callback_struct = (struct ubuf_info_msgzc) + { { .callback = xenvif_zerocopy_callback }, { { .ctx = NULL, .desc = i } } }; queue->grant_tx_handle[i] = NETBACK_INVALID_HANDLE; diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index a256695fc89e..3d2081bbbc86 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -133,7 +133,7 @@ static inline unsigned long idx_to_kaddr(struct xenvif_queue *queue, /* Find the containing VIF's structure from a pointer in pending_tx_info array */ -static inline struct xenvif_queue *ubuf_to_queue(const struct ubuf_info *ubuf) +static inline struct xenvif_queue *ubuf_to_queue(const struct ubuf_info_msgzc *ubuf) { u16 pending_idx = ubuf->desc; struct pending_tx_info *temp = @@ -1228,11 +1228,12 @@ static int xenvif_tx_submit(struct xenvif_queue *queue) return work_done; } -void xenvif_zerocopy_callback(struct sk_buff *skb, struct ubuf_info *ubuf, +void xenvif_zerocopy_callback(struct sk_buff *skb, struct ubuf_info *ubuf_base, bool zerocopy_success) { unsigned long flags; pending_ring_idx_t index; + struct ubuf_info_msgzc *ubuf = uarg_to_msgzc(ubuf_base); struct xenvif_queue *queue = ubuf_to_queue(ubuf); /* This is the only place where we grab this lock, to protect callbacks @@ -1241,7 +1242,7 @@ void xenvif_zerocopy_callback(struct sk_buff *skb, struct ubuf_info *ubuf, spin_lock_irqsave(&queue->callback_lock, flags); do { u16 pending_idx = ubuf->desc; - ubuf = (struct ubuf_info *) ubuf->ctx; + ubuf = (struct ubuf_info_msgzc *) ubuf->ctx; BUG_ON(queue->dealloc_prod - queue->dealloc_cons >= MAX_PENDING_REQS); index = pending_index(queue->dealloc_prod); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:40:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:40:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410879.654031 (Exim 4.92) (envelope-from ) id 1oblj0-0004Fl-7p; Fri, 23 Sep 2022 16:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410879.654031; Fri, 23 Sep 2022 16:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblj0-0004Fd-5F; Fri, 23 Sep 2022 16:40:26 +0000 Received: by outflank-mailman (input) for mailman id 410879; Fri, 23 Sep 2022 16:40:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obliy-0003zv-9l for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:40:24 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b7673d7-3b5e-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 18:40:23 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id e18so582025wmq.3 for ; Fri, 23 Sep 2022 09:40:23 -0700 (PDT) Received: from 127.0.0.1localhost (188.28.201.74.threembb.co.uk. [188.28.201.74]) by smtp.gmail.com with ESMTPSA id x13-20020a5d60cd000000b0022af6c93340sm7717399wrt.17.2022.09.23.09.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 09:40:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b7673d7-3b5e-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=uIbjcfAGyfInoLm/OvWITyB0RrSdYYX1RircUBZVOuM=; b=CKI/w9qlPppvR3tyBdHeNFUn52RNE+MeZLNbpK6WQHJMNQ7f3vkWFTdLCCcM+xWq3t 88EF5j5pTqPAB2s3p0pS1p4UUk241RhmRK9VMkOzQijAnB5okJgircXsRKhYPwGleM3N de//MuiWg86ofbLfaub6s67iv1uESid4nF14NOWOT5jY3SBRpR7/H12eiO/oxBSXm0/P ILfCI77hYYZ+7YxxAz7yP8DxSO8h0V/lXa2Gih0fct6VL2AJNREKCz2Xt1ycpc+sJE2Y VHG/A+GqTB4qZ5Cxq9oyDzh1hyfFvfD0o3F+uWIc7yGHB2I5tBiyMFhHzB0o6nFg5XwE pLlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uIbjcfAGyfInoLm/OvWITyB0RrSdYYX1RircUBZVOuM=; b=QiqFvgBoN22BiAb9rl9XqFF8gSLp95y00aPnhiXM4TL6QdUGzVOzKyXXyfi8JIuCEK G5WtbXKkTv8xQlTeOHbiBLlCTZBKK6oPA7dODH/ZYx4pn5368B+8ddjUnYElziQJrKYr SLuwIsLpWHX8fGSI2j8AgBErrH4pdCw6ousUX+KM9cX5t7pfgsjrwmqHH3NID+iJzWid OMvZy0iBl5lVLFak1vNg5yUBvoQCmzU4jE4i2j/PzRDcLzD9Ky6vhzKRCQwK0v+wg+ja /YIyJ6e+cDFq+baYThN84WhsCPizOlhf+P42N4MXdId4mvSZgFPo7ljsbKnJ14Q2fKbG fYvg== X-Gm-Message-State: ACrzQf0s13VVGGQnbT5kRbddcpEvEIGINxL2yynEuVOs+gzE9D8GDDpy JkRo1LM/RlwXvJkmjUxK5S8= X-Google-Smtp-Source: AMsMyM4CW6l8pZR3BmCcj39hcl6rGI9MDfbfk8pAVz7vOj4J8jOaapYhvNsZhT0FZMIxSSMOhL5SAw== X-Received: by 2002:a05:600c:3d86:b0:3b4:b65f:a393 with SMTP id bi6-20020a05600c3d8600b003b4b65fa393mr6744885wmb.0.1663951223070; Fri, 23 Sep 2022 09:40:23 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang , Pavel Begunkov Subject: [PATCH net-next 1/4] net: introduce struct ubuf_info_msgzc Date: Fri, 23 Sep 2022 17:39:01 +0100 Message-Id: <641bb6844e67e639a9403b8eab96c3fa34659e2a.1663892211.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We're going to split struct ubuf_info and leave there only mandatory fields. Users are free to extend it. Add struct ubuf_info_msgzc, which will be an extended version for MSG_ZEROCOPY and some other users. It duplicates of struct ubuf_info for now and will be removed in a couple of patches. Signed-off-by: Pavel Begunkov --- include/linux/skbuff.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index f15d5b62539b..fd7dcb977fdf 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -554,7 +554,28 @@ struct ubuf_info { } mmp; }; +struct ubuf_info_msgzc { + struct ubuf_info ubuf; + + union { + struct { + unsigned long desc; + void *ctx; + }; + struct { + u32 id; + u16 len; + u16 zerocopy:1; + u32 bytelen; + }; + }; + + struct mmpin mmp; +}; + #define skb_uarg(SKB) ((struct ubuf_info *)(skb_shinfo(SKB)->destructor_arg)) +#define uarg_to_msgzc(ubuf_ptr) container_of((ubuf_ptr), struct ubuf_info_msgzc, \ + ubuf) int mm_account_pinned_pages(struct mmpin *mmp, size_t size); void mm_unaccount_pinned_pages(struct mmpin *mmp); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:40:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:40:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410878.654020 (Exim 4.92) (envelope-from ) id 1obliy-000408-0t; Fri, 23 Sep 2022 16:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410878.654020; Fri, 23 Sep 2022 16:40:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblix-000401-UC; Fri, 23 Sep 2022 16:40:23 +0000 Received: by outflank-mailman (input) for mailman id 410878; Fri, 23 Sep 2022 16:40:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obliw-0003zv-St for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:40:22 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a71f7df-3b5e-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 18:40:21 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id n40-20020a05600c3ba800b003b49aefc35fso303407wms.5 for ; Fri, 23 Sep 2022 09:40:21 -0700 (PDT) Received: from 127.0.0.1localhost (188.28.201.74.threembb.co.uk. [188.28.201.74]) by smtp.gmail.com with ESMTPSA id x13-20020a5d60cd000000b0022af6c93340sm7717399wrt.17.2022.09.23.09.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 09:40:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a71f7df-3b5e-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=ztanNduUnGSd7dD7GDwGomWb/rDw7QbXu95GTvi4NF0=; b=Dhj86Nu8sys2qFmqK/V06KlGFM2Xk5QRqvHqBbWESeHJK9IBEpXdsYMqurS6oqL8sh BCTS7yoYRCIOdEjH+HTth7f3xzp+tPFJMKJrZyfMTCwEe1xcXyHNGSlDHVZnY+FKP+2m jTA5CspELwx9Zv2Wi4x2gjsEAscYjvZZkNMx2OqKEsIRXgRxAA94lCgWqyO22rNYSFKN QfOhOg05PssrfrtXTvYS+CM0qNdZNrzBccmM/798kaCfBPfgbAsGyHs9/gg98+tbhByt p5Y4WKhyD05rBc2YBOQOA0iDfLR24IG7sBHDko59ezP0BaeeJm/r8uUkUePTM869Q0fs WSew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=ztanNduUnGSd7dD7GDwGomWb/rDw7QbXu95GTvi4NF0=; b=abuYRcWRBG0AMlmc2gOGQFHMSIekU5YZwa/wv/GLD05KckJSje63w4Ta6i627gTUDm nP4Mzk4A18bRbTX2pc0uVqVvoeDFvLW2b4OYSsV/spG5F7acm01DBFLIJW2X/gjO3zZQ +7G1skx5fGNZoENi2iOe6oN26Ug4cNprM32pTsSznPwVqgJuZ/vHrnAvOTpY7HTIZQYU k+zL/p5MG8/B4FdkggYGHoloAvHYKkmTtwPIms8ev93bNYjlmodEPeTwQd2Jbkfot07B 2WFwADErprpPp08ZUUZnVOrEGKjthfQ2bXW0Eexp5S9Zv24MQvDq1OI912NEGfOWufdv h+Qw== X-Gm-Message-State: ACrzQf1w7ipMlU9pWVHiwvzjQDq1vXr8eUXlu9tsrNdaInalDG6MTPtw N56KtT1TIOh7tD8uqNUkQWU= X-Google-Smtp-Source: AMsMyM4C/qvRMCrjlrQA/eLAYcbH57QXfOy2gaKCJNxGZjqOxXCGU/x4mo6mBgMbZcqI31K1kHtZHw== X-Received: by 2002:a1c:7716:0:b0:3b4:b2ba:d190 with SMTP id t22-20020a1c7716000000b003b4b2bad190mr6595467wmi.35.1663951221338; Fri, 23 Sep 2022 09:40:21 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang , Pavel Begunkov Subject: [PATCH net-next 0/4] shrink struct ubuf_info Date: Fri, 23 Sep 2022 17:39:00 +0100 Message-Id: X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit struct ubuf_info is large but not all fields are needed for all cases. We have limited space in io_uring for it and large ubuf_info prevents some struct embedding, even though we use only a subset of the fields. It's also not very clean trying to use this typeless extra space. Shrink struct ubuf_info to only necessary fields used in generic paths, namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And make MSG_ZEROCOPY and some other users to embed it into a larger struct ubuf_info_msgzc mimicking the former ubuf_info. Note, xen/vhost may also have some cleaning on top by creating new structs containing ubuf_info but with proper types. Pavel Begunkov (4): net: introduce struct ubuf_info_msgzc xen/netback: use struct ubuf_info_msgzc vhost/net: use struct ubuf_info_msgzc net: shrink struct ubuf_info drivers/net/xen-netback/common.h | 2 +- drivers/net/xen-netback/interface.c | 4 +-- drivers/net/xen-netback/netback.c | 7 +++--- drivers/vhost/net.c | 15 ++++++------ include/linux/skbuff.h | 11 +++++++-- net/core/skbuff.c | 38 ++++++++++++++++------------- net/ipv4/ip_output.c | 2 +- net/ipv4/tcp.c | 2 +- net/ipv6/ip6_output.c | 2 +- 9 files changed, 48 insertions(+), 35 deletions(-) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:40:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:40:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410881.654053 (Exim 4.92) (envelope-from ) id 1oblj3-0004o3-1N; Fri, 23 Sep 2022 16:40:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410881.654053; Fri, 23 Sep 2022 16:40:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblj2-0004ni-Ug; Fri, 23 Sep 2022 16:40:28 +0000 Received: by outflank-mailman (input) for mailman id 410881; Fri, 23 Sep 2022 16:40:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblj1-0003zv-CO for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:40:27 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d4c0e39-3b5e-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 18:40:26 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id c11so791791wrp.11 for ; Fri, 23 Sep 2022 09:40:26 -0700 (PDT) Received: from 127.0.0.1localhost (188.28.201.74.threembb.co.uk. [188.28.201.74]) by smtp.gmail.com with ESMTPSA id x13-20020a5d60cd000000b0022af6c93340sm7717399wrt.17.2022.09.23.09.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 09:40:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d4c0e39-3b5e-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=FG3Mj1csJ7FbeoY2zgdLrFVr7w1D2Zs//acRgBf+TRE=; b=eE5aVrZKg1v/P9UeaHNz1t9u6KrDObJzPuHWUbsNB0CGvL2ozT6QO6y8RV3J4TvApK gPGLloFmul/9NycdPQzEdBinJ0njxpLdx/5DMi9pkPqxHexWAitmYT7B+590/zvfROM9 CIVg8YVhNarmc9WM95AOuXgoiDJPoZLmdOExh3cWbH26mGW6YjwixTE3hbClVdbEUOis 9uTUExsQwAPYQ75waTv9Um9hLpemVfJuIj+0GaxnBaIvAP3G5baJmEnOoa51UmzPE0/V 9wc+Ze+zqXKhGHGQroVMuqM6b/rlyf5FCzbF0pKQAhzaxGDoxQxA7E7iIWwRmyyPXktb EuHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=FG3Mj1csJ7FbeoY2zgdLrFVr7w1D2Zs//acRgBf+TRE=; b=PDUYkJvS55E7jbewHmaOR3gV/rGFlIPaB4COQizkHgTt6FELRhZZpzJjOjMbagFWGK Hhwo8d08/MsFT1jaNo6eKabQRZ7GhPlB0GxqfrCYLnXJNa9pL19vF7fxSE11P3sKw3tg xkSP2KF5AMqRIWGdHVHBZ076GXijHYVlhfy8zy9TRRqZc2VZY1H7X+jmPXZ9mEshfHtF prCPIFT387Kshds6qjUV9DyoJ2X+Assueldi7qbDTXz6g/zJiUIxb+fEtgSgVjYGzaVO zWLsRPdtYfnHkprvk9MkJTpo3cD70lpCeHvfWbwFPRh5NJrYVIlUEH35pwciuzCBuRgk Q7Kg== X-Gm-Message-State: ACrzQf3mTZzh5r3sRLPVqZSBK/3ZMMx51YFYbFHlWJHTEh+Aiq1+v1lW LLeckuWS2fM7NgB15javKvY= X-Google-Smtp-Source: AMsMyM7kN8lNHyV1w1d1RL8dD6evo1RUYO8Wx/UWQQUl5cn81n4HQTVjecLZI9rI0Uh/wzPOiMq83A== X-Received: by 2002:a5d:5452:0:b0:228:d6f0:dbeb with SMTP id w18-20020a5d5452000000b00228d6f0dbebmr5883466wrv.84.1663951226140; Fri, 23 Sep 2022 09:40:26 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang , Pavel Begunkov Subject: [PATCH net-next 3/4] vhost/net: use struct ubuf_info_msgzc Date: Fri, 23 Sep 2022 17:39:03 +0100 Message-Id: <126df081c74ecf06de383b4fdaad5080346f93dd.1663892211.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit struct ubuf_info will be changed, use ubuf_info_msgzc instead. Signed-off-by: Pavel Begunkov --- drivers/vhost/net.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 68e4ecd1cc0e..d7a04d573988 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -118,7 +118,7 @@ struct vhost_net_virtqueue { /* Number of XDP frames batched */ int batched_xdp; /* an array of userspace buffers info */ - struct ubuf_info *ubuf_info; + struct ubuf_info_msgzc *ubuf_info; /* Reference counting for outstanding ubufs. * Protected by vq mutex. Writers must also take device mutex. */ struct vhost_net_ubuf_ref *ubufs; @@ -382,8 +382,9 @@ static void vhost_zerocopy_signal_used(struct vhost_net *net, } static void vhost_zerocopy_callback(struct sk_buff *skb, - struct ubuf_info *ubuf, bool success) + struct ubuf_info *ubuf_base, bool success) { + struct ubuf_info_msgzc *ubuf = uarg_to_msgzc(ubuf_base); struct vhost_net_ubuf_ref *ubufs = ubuf->ctx; struct vhost_virtqueue *vq = ubufs->vq; int cnt; @@ -871,7 +872,7 @@ static void handle_tx_zerocopy(struct vhost_net *net, struct socket *sock) size_t len, total_len = 0; int err; struct vhost_net_ubuf_ref *ubufs; - struct ubuf_info *ubuf; + struct ubuf_info_msgzc *ubuf; bool zcopy_used; int sent_pkts = 0; @@ -907,14 +908,14 @@ static void handle_tx_zerocopy(struct vhost_net *net, struct socket *sock) ubuf = nvq->ubuf_info + nvq->upend_idx; vq->heads[nvq->upend_idx].id = cpu_to_vhost32(vq, head); vq->heads[nvq->upend_idx].len = VHOST_DMA_IN_PROGRESS; - ubuf->callback = vhost_zerocopy_callback; ubuf->ctx = nvq->ubufs; ubuf->desc = nvq->upend_idx; - ubuf->flags = SKBFL_ZEROCOPY_FRAG; - refcount_set(&ubuf->refcnt, 1); + ubuf->ubuf.callback = vhost_zerocopy_callback; + ubuf->ubuf.flags = SKBFL_ZEROCOPY_FRAG; + refcount_set(&ubuf->ubuf.refcnt, 1); msg.msg_control = &ctl; ctl.type = TUN_MSG_UBUF; - ctl.ptr = ubuf; + ctl.ptr = &ubuf->ubuf; msg.msg_controllen = sizeof(ctl); ubufs = nvq->ubufs; atomic_inc(&ubufs->refcount); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:40:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:40:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410882.654064 (Exim 4.92) (envelope-from ) id 1oblj5-00057m-DV; Fri, 23 Sep 2022 16:40:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410882.654064; Fri, 23 Sep 2022 16:40:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblj5-00057K-9G; Fri, 23 Sep 2022 16:40:31 +0000 Received: by outflank-mailman (input) for mailman id 410882; Fri, 23 Sep 2022 16:40:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblj4-00050m-6L for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:40:30 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e5a3d3a-3b5e-11ed-9374-c1cf23e5d27e; Fri, 23 Sep 2022 18:40:29 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id r3-20020a05600c35c300b003b4b5f6c6bdso324930wmq.2 for ; Fri, 23 Sep 2022 09:40:28 -0700 (PDT) Received: from 127.0.0.1localhost (188.28.201.74.threembb.co.uk. [188.28.201.74]) by smtp.gmail.com with ESMTPSA id x13-20020a5d60cd000000b0022af6c93340sm7717399wrt.17.2022.09.23.09.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 09:40:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e5a3d3a-3b5e-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=9VVplsCxvC3CPJyNAguid6PlNyGw4lN66t6t3nf9Zaw=; b=YX4cbnzVIadel+pT1A6WodnDs0MR3NSCVsnHE38CJKF7XkI7KvaIQ4X6UmO2SfaMby 3VG63f3bamCi8YVL8ww08dism3Nm3ZvPgDMvFHyrKNRzINXMBssaysY/QDsZovrtNXWO gddHNXxGWa8BakVKjQ5YbFO8g393XpvaAu125LTZaJ3U/JaL0wKZvINwFV4DLmKgHz7T Xw7f7SfpPz9S5UhKJqbPOz8SYQZLUnnVbiqzammFHsqMEzmYr/Jf/7M227Gu2RTGDhGm G+jXB2dWbPryASB1xMe7LrokxjofXsZVvU+X/L2122P0YwcjI8IYTMdbFPhAAa4OkK00 foRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=9VVplsCxvC3CPJyNAguid6PlNyGw4lN66t6t3nf9Zaw=; b=sxQ6eYdaoa3DLNW6sVz6PvN/FXaOHsyEncH7LBA9j18S2zp3gZi3KCorsBKDainLGT 9xxdmCOT2bTzWKbNtU/i5XN++Hu5LSME9fJIWURyoSLn7rKsDE89S/qEwah/21F0Gqd2 BL2tiu0VLK2kZ89ppRNb6oFGbjaC6mQ1lOJrLw7wOwf1+iExe6OF9QaCiinlbYhivJGb msFdwKy19c8WahNo0ojt1G5yX1M8IoFE1rdGbWyg8UDSJmYYvIEiBHGv58bJedbB7auf S8VgKr5o5JLavvhpMDu8XcaOXf0oDyOPGFxW0U2ub/wbzgFLR9CZR4Jet/A10oAkRjDT Uy9g== X-Gm-Message-State: ACrzQf1NZpeOYxdCkVpks0zKM51ywXQb5TyBRIB4n20tg9KLS6ZsPo9m fH+fel9K0pNqYNtCKcRaE40= X-Google-Smtp-Source: AMsMyM6Fs/pfy41Rfyr/MfeH4GoV13INTvx0st23vngXOgKxULEpbfBhZr8VAlVXwkSzQowWksWZFQ== X-Received: by 2002:a05:600c:1989:b0:3b4:b6b6:737 with SMTP id t9-20020a05600c198900b003b4b6b60737mr6550166wmq.79.1663951227773; Fri, 23 Sep 2022 09:40:27 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang , Pavel Begunkov Subject: [PATCH net-next 4/4] net: shrink struct ubuf_info Date: Fri, 23 Sep 2022 17:39:04 +0100 Message-Id: X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We can benefit from a smaller struct ubuf_info, so leave only mandatory fields and let users to decide how they want to extend it. Convert MSG_ZEROCOPY to struct ubuf_info_msgzc and remove duplicated fields. This reduces the size from 48 bytes to just 16. Signed-off-by: Pavel Begunkov --- include/linux/skbuff.h | 22 ++++------------------ net/core/skbuff.c | 38 +++++++++++++++++++++----------------- net/ipv4/ip_output.c | 2 +- net/ipv4/tcp.c | 2 +- net/ipv6/ip6_output.c | 2 +- 5 files changed, 28 insertions(+), 38 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index fd7dcb977fdf..920eb6413fee 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -533,25 +533,8 @@ enum { struct ubuf_info { void (*callback)(struct sk_buff *, struct ubuf_info *, bool zerocopy_success); - union { - struct { - unsigned long desc; - void *ctx; - }; - struct { - u32 id; - u16 len; - u16 zerocopy:1; - u32 bytelen; - }; - }; refcount_t refcnt; u8 flags; - - struct mmpin { - struct user_struct *user; - unsigned int num_pg; - } mmp; }; struct ubuf_info_msgzc { @@ -570,7 +553,10 @@ struct ubuf_info_msgzc { }; }; - struct mmpin mmp; + struct mmpin { + struct user_struct *user; + unsigned int num_pg; + } mmp; }; #define skb_uarg(SKB) ((struct ubuf_info *)(skb_shinfo(SKB)->destructor_arg)) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index f1b8b20fc20b..bbcfb1c7f59e 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1188,7 +1188,7 @@ EXPORT_SYMBOL_GPL(mm_unaccount_pinned_pages); static struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size) { - struct ubuf_info *uarg; + struct ubuf_info_msgzc *uarg; struct sk_buff *skb; WARN_ON_ONCE(!in_task()); @@ -1206,19 +1206,19 @@ static struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size) return NULL; } - uarg->callback = msg_zerocopy_callback; + uarg->ubuf.callback = msg_zerocopy_callback; uarg->id = ((u32)atomic_inc_return(&sk->sk_zckey)) - 1; uarg->len = 1; uarg->bytelen = size; uarg->zerocopy = 1; - uarg->flags = SKBFL_ZEROCOPY_FRAG | SKBFL_DONT_ORPHAN; - refcount_set(&uarg->refcnt, 1); + uarg->ubuf.flags = SKBFL_ZEROCOPY_FRAG | SKBFL_DONT_ORPHAN; + refcount_set(&uarg->ubuf.refcnt, 1); sock_hold(sk); - return uarg; + return &uarg->ubuf; } -static inline struct sk_buff *skb_from_uarg(struct ubuf_info *uarg) +static inline struct sk_buff *skb_from_uarg(struct ubuf_info_msgzc *uarg) { return container_of((void *)uarg, struct sk_buff, cb); } @@ -1227,6 +1227,7 @@ struct ubuf_info *msg_zerocopy_realloc(struct sock *sk, size_t size, struct ubuf_info *uarg) { if (uarg) { + struct ubuf_info_msgzc *uarg_zc; const u32 byte_limit = 1 << 19; /* limit to a few TSO */ u32 bytelen, next; @@ -1242,8 +1243,9 @@ struct ubuf_info *msg_zerocopy_realloc(struct sock *sk, size_t size, return NULL; } - bytelen = uarg->bytelen + size; - if (uarg->len == USHRT_MAX - 1 || bytelen > byte_limit) { + uarg_zc = uarg_to_msgzc(uarg); + bytelen = uarg_zc->bytelen + size; + if (uarg_zc->len == USHRT_MAX - 1 || bytelen > byte_limit) { /* TCP can create new skb to attach new uarg */ if (sk->sk_type == SOCK_STREAM) goto new_alloc; @@ -1251,11 +1253,11 @@ struct ubuf_info *msg_zerocopy_realloc(struct sock *sk, size_t size, } next = (u32)atomic_read(&sk->sk_zckey); - if ((u32)(uarg->id + uarg->len) == next) { - if (mm_account_pinned_pages(&uarg->mmp, size)) + if ((u32)(uarg_zc->id + uarg_zc->len) == next) { + if (mm_account_pinned_pages(&uarg_zc->mmp, size)) return NULL; - uarg->len++; - uarg->bytelen = bytelen; + uarg_zc->len++; + uarg_zc->bytelen = bytelen; atomic_set(&sk->sk_zckey, ++next); /* no extra ref when appending to datagram (MSG_MORE) */ @@ -1291,7 +1293,7 @@ static bool skb_zerocopy_notify_extend(struct sk_buff *skb, u32 lo, u16 len) return true; } -static void __msg_zerocopy_callback(struct ubuf_info *uarg) +static void __msg_zerocopy_callback(struct ubuf_info_msgzc *uarg) { struct sk_buff *tail, *skb = skb_from_uarg(uarg); struct sock_exterr_skb *serr; @@ -1344,19 +1346,21 @@ static void __msg_zerocopy_callback(struct ubuf_info *uarg) void msg_zerocopy_callback(struct sk_buff *skb, struct ubuf_info *uarg, bool success) { - uarg->zerocopy = uarg->zerocopy & success; + struct ubuf_info_msgzc *uarg_zc = uarg_to_msgzc(uarg); + + uarg_zc->zerocopy = uarg_zc->zerocopy & success; if (refcount_dec_and_test(&uarg->refcnt)) - __msg_zerocopy_callback(uarg); + __msg_zerocopy_callback(uarg_zc); } EXPORT_SYMBOL_GPL(msg_zerocopy_callback); void msg_zerocopy_put_abort(struct ubuf_info *uarg, bool have_uref) { - struct sock *sk = skb_from_uarg(uarg)->sk; + struct sock *sk = skb_from_uarg(uarg_to_msgzc(uarg))->sk; atomic_dec(&sk->sk_zckey); - uarg->len--; + uarg_to_msgzc(uarg)->len--; if (have_uref) msg_zerocopy_callback(NULL, uarg, true); diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 8201cd423ff9..1ae83ad629b2 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -1043,7 +1043,7 @@ static int __ip_append_data(struct sock *sk, paged = true; zc = true; } else { - uarg->zerocopy = 0; + uarg_to_msgzc(uarg)->zerocopy = 0; skb_zcopy_set(skb, uarg, &extra_uref); } } diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 829beee3fa32..34fd52c07534 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -1239,7 +1239,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size) } zc = sk->sk_route_caps & NETIF_F_SG; if (!zc) - uarg->zerocopy = 0; + uarg_to_msgzc(uarg)->zerocopy = 0; } } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index e3dbb32b70dc..2f279cbd2648 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1569,7 +1569,7 @@ static int __ip6_append_data(struct sock *sk, paged = true; zc = true; } else { - uarg->zerocopy = 0; + uarg_to_msgzc(uarg)->zerocopy = 0; skb_zcopy_set(skb, uarg, &extra_uref); } } -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410909.654075 (Exim 4.92) (envelope-from ) id 1oblwB-00084f-KD; Fri, 23 Sep 2022 16:54:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410909.654075; Fri, 23 Sep 2022 16:54:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblwB-00084Y-Go; Fri, 23 Sep 2022 16:54:03 +0000 Received: by outflank-mailman (input) for mailman id 410909; Fri, 23 Sep 2022 16:54:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblwA-00084O-0w; Fri, 23 Sep 2022 16:54:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblw9-0007kn-Ld; Fri, 23 Sep 2022 16:54:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblw9-0001sd-B5; Fri, 23 Sep 2022 16:54:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oblw9-0001jc-Ad; Fri, 23 Sep 2022 16:54:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+dwptf/aU5sJIYMLr6i1xbaLMS4oZ8mgX+6uMWz98h8=; b=GCo2wHZOzliv6T0eVHn3b1zi7C /8iiC/aenUQjGA3+E2+AvjoJ5P54dvpNViY5bxok2138DUAw4Mc7eawBLBT0/xOT+j989fvXa63tv ygQDfDNj9wGXTG3XqFkamfVgmYEZf/2Bu3IAo9WKw/2YD0AKZM5uzzq/GTMAdDDJXlBo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173293: all pass - PUSHED X-Osstest-Versions-This: ovmf=953438e4665c5993dfe5652c43ad43f963075b64 X-Osstest-Versions-That: ovmf=5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 From: osstest service owner Date: Fri, 23 Sep 2022 16:54:01 +0000 flight 173293 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173293/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 953438e4665c5993dfe5652c43ad43f963075b64 baseline version: ovmf 5f403cdc6a367d8aad70f25e4286cb3785f2a1a2 Last test of basis 173289 2022-09-23 09:41:41 Z 0 days Failing since 173290 2022-09-23 12:13:11 Z 0 days 2 attempts Testing same since 173293 2022-09-23 14:42:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Christopher Zurcher Christopher Zurcher Leif Lindholm Minh Nguyen Nhi Pham Yi Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5f403cdc6a..953438e466 953438e4665c5993dfe5652c43ad43f963075b64 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 16:54:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 16:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410913.654086 (Exim 4.92) (envelope-from ) id 1oblwb-0008VV-Tb; Fri, 23 Sep 2022 16:54:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410913.654086; Fri, 23 Sep 2022 16:54:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblwb-0008VO-QS; Fri, 23 Sep 2022 16:54:29 +0000 Received: by outflank-mailman (input) for mailman id 410913; Fri, 23 Sep 2022 16:54:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oblwb-0008Tx-1v for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 16:54:29 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6189a1fc-3b60-11ed-9647-05401a9f4f97; Fri, 23 Sep 2022 18:54:26 +0200 (CEST) Received: from DS7PR03CA0104.namprd03.prod.outlook.com (2603:10b6:5:3b7::19) by MW4PR12MB7381.namprd12.prod.outlook.com (2603:10b6:303:219::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 16:54:23 +0000 Received: from DM6NAM11FT093.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::a3) by DS7PR03CA0104.outlook.office365.com (2603:10b6:5:3b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 16:54:23 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT093.mail.protection.outlook.com (10.13.172.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 16:54:23 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 11:54:23 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 23 Sep 2022 09:54:22 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 23 Sep 2022 11:54:21 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6189a1fc-3b60-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8v1/a5MQxb6ogjPBdle/gCsiDoviw+B9ZIQPcHNbovsfqtFT3vVk+Z9xISBwYjaSaglaRfvu0HF13WzV9GbzY6vTy1wCpmn/nIWDCCNnsuf5zLTsIF7IX7/NUcMpL12i/E/bNdZulk/glVDnUxYqfrq+ZRrUIVedopqmRTsovx2ctw2CR6iObvJS8znFE7q/YGL0PasAdC6IUZWCG/u86G0MaMjEURXoDbQDFQWv9vyLn+072xlv3NhdtY+yxuZYoysmi4y9b01sDVRdMivLxkHnjKFMatTJo0VJgNpNxIJ3cPp8wdip3oKstZbGzh89z+6iUpGPULEfE/EBcLDKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/84mrTy8Gz/O+FbO4cOOrEwPyqAT29gEBaIaLH50kY0=; b=mGF65qb6CVrurOLlM9kdDYXd/PfiSnkqwTefNCrUWntRRsY+8amkS7Qqbz7ZNqBVKZscL5iCH+kjY/aD0x+fkgu/ypu5LC5dfWpXAn1DRFQPS0kjef9EFRduzeVxXYNM5TDSBtNWMhQ0N8gf5PemG0Cu9BE9PVeJt0KMQErDWlu0hHmWmr5FIoi/TOiT2+61r838EwHSvfL9oh1Xw3roo8zvjei+oEGWcbP1gR4AXFPdSmuTXNqqCjyjCEUBRk5oUr+eQzMJEerOhS2Ri3K+EbcSixaTDjdkJ6cZWBz8OkVG97+DRnPl0LP87zZUsvwKlPgd5zMiGlBeOGrJyWyKzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/84mrTy8Gz/O+FbO4cOOrEwPyqAT29gEBaIaLH50kY0=; b=q07jdqvGaoRDOhWs64s1TPZfcf927e9hn6KwZKJGDI95azg5N/JsCWIEYV4ZBIdSBmif9kKcHyVkVohA8uKTpHtK0/c3C9cjz/JqiK+tIAhm1wFj1tVr+JaOM0le6CEUzhzhn+gLMTqObyXheRvog9sQAYOv18ozSV/Lkv64dNw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <52a75038-7aa0-fb2e-6f4a-1cb749e886a6@amd.com> Date: Fri, 23 Sep 2022 18:54:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 4/9] automation: Add Arm containers to containerize script To: Anthony PERARD CC: , Doug Goldstein , Stefano Stabellini References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-5-michal.orzel@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT093:EE_|MW4PR12MB7381:EE_ X-MS-Office365-Filtering-Correlation-Id: 910b77c2-0b91-4a27-eb39-08da9d844485 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wshsVP7x0OXif4wyBxGZD1jAxT23gdhbnxqhBIA4sYC+DuUgU5zPKOWqFSsEsXrH+Xm+3vxh6wa8Dh/wAXdX89vbIcikmvXKOQEusGOB7D846Q37KoWTfUAsNrPHgTt2a0lO8L+jhUVJJG7jlmrnxueZLofXmTfjr+kZygVEbKqp20ZD9bi6TpXZLcxqPCHnsUJtEQSEnkdFgvS/mm2HQiJFN4JotG7wjPw/J2vF2N2QovWxOcAbD4iMPYHVCkitTRhbRg6TVciH0JQeRvgIKSeKyxnuWMiiAa826DCZSnLJGt5EUgVPZrfSywHvdNzOilZwG4PO5w1bRlDI59d+yDbn+SXeNGgJxSo7PN3H0c75xPiKVk02hcdmTf8MPVgaVcbUxvR5i4VqSidQYFKY9JOm4MgwrDvcoh7yIOOIgPEmjLAnErK4DWeUIZNgtSZ0j2otBZ8dIOcZUXIGD7KgkkLz9DEm/6e3XRPZzi62acE2970RQEUZ/2Z8lsHHfWbVNiOohtFFmqMr9iQqGcMc9YN/NIE+zuoyqL3FwLCNbxEwDvhD77l8Esd+FFTHWEO3NwxxpwKiQvfRisDUPuILhycSx/sCqxFamaA+kQU8Ctk6LQlCFs+p3KIvz2z1d1Dy5xl853BVybc4SRu8Lb+huZHmNWdoV534WGs3XgrrSPhMc3lt5JC7Z9sVTJS00wYwl/XMm/I0VOfU5ae4SwkTl1bOJN9CM4gak2Vmk4YCTCWYOsYKJ5/QJfQcrlaVryJzzR5kPhdXV/HiUcXN4mp9SgeUZkSF/uZp1CiP1G215P6v0+EsYGwDIaPM8xi322Hu761hYSTkwYonN9RXBR+GQ1aqfMWdb2fsoAJillYWoqM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(5660300002)(81166007)(84970400001)(44832011)(86362001)(54906003)(316002)(31696002)(16576012)(41300700001)(6916009)(53546011)(82310400005)(966005)(4326008)(478600001)(36756003)(186003)(336012)(8936002)(82740400003)(426003)(70206006)(70586007)(8676002)(26005)(2616005)(40480700001)(40460700003)(36860700001)(31686004)(356005)(2906002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:54:23.6280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 910b77c2-0b91-4a27-eb39-08da9d844485 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT093.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7381 Hi Anthony, On 23/09/2022 15:56, Anthony PERARD wrote: > > > On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote: >> Script automation/scripts/containerize makes it easy to build Xen within >> predefined containers from gitlab container registry. However, it is >> currently not possible to use it with Arm containers because they are not >> listed in the script. Populate the necessary entries. > > FYI, those entry are just helper/shortcut/aliases, you can use any > arbitrary container with the script, it just more annoying. > > Your patch here allows to write: > CONTAINER=unstable-arm64v8 automation/scripts/containerize > but you could write the following instead, for the same result: > CONTAINER=registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 automation/scripts/containerize > > I wonder if the script could select the right container base on the > architecture of the host, because "alpine" and "alpine-arm64v8" will not > both work on the same machine. It might be nice to just choose "alpine" > and the script would select the x86 or arm container automagically. Just > an idea, no need to do anything about it. I'm not in favor of adding the automatic selection based on the host. The reason is that on x86 you can run both x86 and e.g. Arm containers. You just need to use register qemu-user-static [1] to perform emulation. This is something widely used and I use that to test Arm images/containers on x86 host. So you can run both alpine and alpine-arm64v8 on the same machine. > > (patch is fine otherwise, just the patch description is a bit > misleading) > > Cheers, > > -- > Anthony PERARD ~Michal [1] https://github.com/multiarch/qemu-user-static From xen-devel-bounces@lists.xenproject.org Fri Sep 23 19:46:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 19:46:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410928.654099 (Exim 4.92) (envelope-from ) id 1obocu-0002mI-AW; Fri, 23 Sep 2022 19:46:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410928.654099; Fri, 23 Sep 2022 19:46:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obocu-0002mB-7O; Fri, 23 Sep 2022 19:46:20 +0000 Received: by outflank-mailman (input) for mailman id 410928; Fri, 23 Sep 2022 19:46:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obocs-0002m1-Vn; Fri, 23 Sep 2022 19:46:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obocs-0002fD-TP; Fri, 23 Sep 2022 19:46:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obocs-0000zi-Ix; Fri, 23 Sep 2022 19:46:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obocs-0002PM-IW; Fri, 23 Sep 2022 19:46:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H84jiw6cWR9uarHP+C7kY3L9DkCpAqzONrSUJMxx9vU=; b=GdZ8EnRcP2BGABJko6pEgZA67l tYm1DQBNwuLldxKkqWqEsTJpOiuxk4iNBKo51S4QeDsr9XvRBOyJvHaxAmpWDfa9QoFk39cO7KBpG JbsX2JbNDFtD4TyfNvfGGJCGTMO2pO9PP8zVzDzd3qbtIbul2oFuagho3ooH5RdwnsAM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173297: all pass - PUSHED X-Osstest-Versions-This: ovmf=2500ce101178e55ed29cd18931ab8a73d0ca6e4d X-Osstest-Versions-That: ovmf=953438e4665c5993dfe5652c43ad43f963075b64 From: osstest service owner Date: Fri, 23 Sep 2022 19:46:18 +0000 flight 173297 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173297/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2500ce101178e55ed29cd18931ab8a73d0ca6e4d baseline version: ovmf 953438e4665c5993dfe5652c43ad43f963075b64 Last test of basis 173293 2022-09-23 14:42:58 Z 0 days Testing same since 173297 2022-09-23 17:43:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jeff Brasen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 953438e466..2500ce1011 2500ce101178e55ed29cd18931ab8a73d0ca6e4d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 22:11:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 22:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410945.654111 (Exim 4.92) (envelope-from ) id 1obqsj-0002ZU-3k; Fri, 23 Sep 2022 22:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410945.654111; Fri, 23 Sep 2022 22:10:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obqsj-0002ZN-0c; Fri, 23 Sep 2022 22:10:49 +0000 Received: by outflank-mailman (input) for mailman id 410945; Fri, 23 Sep 2022 22:10:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obqsh-0002ZG-5j for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 22:10:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9114aff0-3b8c-11ed-9374-c1cf23e5d27e; Sat, 24 Sep 2022 00:10:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E19F061E0D; Fri, 23 Sep 2022 22:10:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68484C433D6; Fri, 23 Sep 2022 22:10:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9114aff0-3b8c-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663971042; bh=aRPszHBUEhM651GgpjnI0fH6rUnyJMrswFVK7JirL4Y=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IfL+W9hxJcJD2q9nkkN1Bx6U3f77Ak4f+467NNlbuUxqB7hzZyHbscCM6Idb5kCkb Vvg1Lxs7JIYdKdrknLBQo+KWCddTcen7o+OUHYL9zs2/HlM1VrcFNWcyrT4uL1uC+1 5NPLxTkKuiXdOjuhfbogHzYn8K9qaFdDtLK/1n7J2L5ml3dnmHaNKzUfYjteGE6elt TK55T0Mx+QsgrI2eoNChQ20LQd1UX1FiONrNwcY46W2jFlmsphoTWOFIFGUKPCugSY 6ZIqYHsW21Ko8hQ+pjPid0RI4bZTNyjwuMHreiE8nYxjkR3E8EY81PXHOq1GQsGTZm VYRUZsP1ktBnA== Date: Fri, 23 Sep 2022 15:10:39 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Doug Goldstein , Henry.Wang@arm.com Subject: Re: [PATCH 1/9] automation: Use custom build jobs when extra config options are needed In-Reply-To: Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 23 Sep 2022, Michal Orzel wrote: > Hi Stefano, > > On 22/09/2022 23:40, Stefano Stabellini wrote: > > > > > > On Thu, 22 Sep 2022, Michal Orzel wrote: > >> Currently, all the arm64 defconfig build jobs, regardless of the > >> container used, end up building Xen with the extra config options > >> specified in the main build script (e.g. CONFIG_EXPERT, > >> CONFIG_STATIC_MEMORY). Because these options are only needed for > >> specific test jobs, the current behavior of the CI is incorrect > >> as we add the extra options to all the defconfig builds. This means > >> that on arm64 there is not a single job performing proper defconfig build. > >> > >> To fix this issue, add custom build jobs each time there is a need for > >> building Xen with additional config options. Introduce EXTRA_XEN_CONFIG > >> variable to be used by these jobs to store the required options. This > >> variable will be then read by the main build script to modify the .config > >> file. This will also help users to understand what is needed to run specific > >> test. > >> > >> Signed-off-by: Michal Orzel > >> --- > >> This patch could actually be consider to be taken for 4.17 release. > >> The reason why is because currently our CI for arm64 does not even > >> peform clean defconfig build which is quite crucial target to be tested. > >> Performing builds always with EXPERT and UNSUPPORTED is not something so > >> beneficial for release tests. This is up to the release manager. > > > > + Henry > > > > I agree this should go in 4.17, so that gitlab-ci can test non-DEBUG > > builds on ARM. > > > Do you mean the whole series should go in? > I'm ok with that, even though I only marked this patch as the one that should go in > as it can be seen as a fix. But I can also see the benefits of merging the whole series. I think only this patch should go in. I like this series but it is best to stay on the safe side and push to staging the rest of the series later after the release. > >> --- > >> automation/gitlab-ci/build.yaml | 15 +++++++++++++++ > >> automation/gitlab-ci/test.yaml | 4 ++-- > >> automation/scripts/build | 8 ++------ > >> 3 files changed, 19 insertions(+), 8 deletions(-) > >> > >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > >> index 720ce6e07ba0..a39ed72aac6d 100644 > >> --- a/automation/gitlab-ci/build.yaml > >> +++ b/automation/gitlab-ci/build.yaml > >> @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: > >> variables: > >> CONTAINER: alpine:3.12-arm64v8 > >> > >> +alpine-3.12-gcc-arm64-staticmem: > >> + extends: .gcc-arm64-build > >> + variables: > >> + CONTAINER: alpine:3.12-arm64v8 > >> + EXTRA_XEN_CONFIG: | > > > > Why the "|" ? > > > > I was trying to look for its documentation in the gitlab yaml docs but > > couldn't find it. > > > By default gitlab variables are one liners so that they can store one key:value pair. > If you want to define a variable storing multiple values (in this case we want to > store multi-line string because of .config format) you need to use |. You can check [1]. OK > > > >> + CONFIG_EXPERT=y > >> + CONFIG_UNSUPPORTED=y > >> + CONFIG_STATIC_MEMORY=y > >> + > >> +alpine-3.12-gcc-arm64-boot-cpupools: > >> + extends: .gcc-arm64-build > >> + variables: > >> + CONTAINER: alpine:3.12-arm64v8 > >> + EXTRA_XEN_CONFIG: | > >> + CONFIG_BOOT_TIME_CPUPOOLS=y > >> > >> ## Test artifacts common > >> > >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > >> index d899b3bdbf7a..4f96e6e322de 100644 > >> --- a/automation/gitlab-ci/test.yaml > >> +++ b/automation/gitlab-ci/test.yaml > >> @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: > >> script: > >> - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > >> needs: > >> - - alpine-3.12-gcc-arm64 > >> + - alpine-3.12-gcc-arm64-staticmem > >> - alpine-3.12-arm64-rootfs-export > >> - kernel-5.19-arm64-export > >> - qemu-system-aarch64-6.0.0-arm64-export > >> @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: > >> script: > >> - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > >> needs: > >> - - alpine-3.12-gcc-arm64 > >> + - alpine-3.12-gcc-arm64-boot-cpupools > >> - alpine-3.12-arm64-rootfs-export > >> - kernel-5.19-arm64-export > >> - qemu-system-aarch64-6.0.0-arm64-export > >> diff --git a/automation/scripts/build b/automation/scripts/build > >> index 2f15ab3198e6..7d441cedb4ae 100755 > >> --- a/automation/scripts/build > >> +++ b/automation/scripts/build > >> @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then > >> make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > >> hypervisor_only="y" > >> else > >> - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then > >> - echo " > >> -CONFIG_EXPERT=y > >> -CONFIG_UNSUPPORTED=y > >> -CONFIG_STATIC_MEMORY=y > >> -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config > >> + if [ -n "${EXTRA_XEN_CONFIG}" ]; then > > > > NIT: for uniformity with rest of the file use > > > > if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then > > > Ok, will do in v2. > > > > >> + echo "${EXTRA_XEN_CONFIG}" > xen/.config > >> make -j$(nproc) -C xen olddefconfig > >> else > >> make -j$(nproc) -C xen defconfig > >> -- > >> 2.25.1 > >> > > ~Michal > > [1] https://docs.gitlab.com/ee/ci/variables/#store-multiple-values-in-one-variable > From xen-devel-bounces@lists.xenproject.org Fri Sep 23 22:12:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 22:12:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410949.654121 (Exim 4.92) (envelope-from ) id 1obqtv-00037Y-Df; Fri, 23 Sep 2022 22:12:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410949.654121; Fri, 23 Sep 2022 22:12:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obqtv-00037R-Ad; Fri, 23 Sep 2022 22:12:03 +0000 Received: by outflank-mailman (input) for mailman id 410949; Fri, 23 Sep 2022 22:12:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obqtu-000356-KJ for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 22:12:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id becb9674-3b8c-11ed-9647-05401a9f4f97; Sat, 24 Sep 2022 00:12:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C4B8760FEE; Fri, 23 Sep 2022 22:11:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9787EC433D6; Fri, 23 Sep 2022 22:11:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: becb9674-3b8c-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663971119; bh=O+/jfqgMbs6IbNhItwGyUJuRn1/lHjc2KMA9oEe7BqA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jsodTRrCp1Q2c4K1Mjt9r0vCxoI7okjQDdKJgO4PpKI09+jfaLUEMQnJR3bOBcE2G mAa2pGPdizh6aVotaGqArDFXyUHkF0vtvJEgLkNxPTtvNeVbMfzkLQVelD1tzvq3cL 2+T5z2HvayxRGu8yp0WJsINLtWBbGKjcWorCQg+i0lIUwcqjLnwgUJbIQ7G4zeL/Ld KspDT8+RvoZjUKSvB5EXk6q7wkU6MrVXkF0kxevuI1OLEfiHu7TVDOjeOOChdqb6fm OWf92a2xCT8AXuEnJ01Wef/YMqOM/SaETCPovr+bhkRlQf5gQ4SibWgrJgncHPt4iB taLkW4gSyVaVg== Date: Fri, 23 Sep 2022 15:11:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Doug Goldstein Subject: Re: [PATCH 3/9] automation: Add debug versions of Arm tests In-Reply-To: <2ca7482d-65a9-8ac4-c6ad-2157a5d4f6b6@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-4-michal.orzel@amd.com> <2ca7482d-65a9-8ac4-c6ad-2157a5d4f6b6@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 23 Sep 2022, Michal Orzel wrote: > Hi Stefano, > > On 22/09/2022 23:53, Stefano Stabellini wrote: > > > > > > On Thu, 22 Sep 2022, Michal Orzel wrote: > >> At the moment, all the tests are executed on non-debug Xen builds. > >> To improve the coverage (e.g. we might catch some asserts), add new > >> test jobs using debug Xen builds. > > > > This is interesting. On one hand, I agree it is good to test DEBUG and > > non-DEBUG builds in runtime tests too, on the other hand I am worried > > about our test capacity. > > We still have plenty of capacity. We can add many more Arm tests because > Arm machine is very powerful. I reckon that adding more x86 tests would > have a performance impact but not the other way around. See below. > > > > > I take you have tried a few pipelines -- are the additional tests > > causing the pipeline to take longer? Do we still have "room" because x86 > > is slower? What's your thinking? > > > > With the additional tests introduced by this patch one cannot observe any > impact for the performance. I ran several tests and the pipeline finishes > in the same time or faster. > > Performance comparison: > current master: 92 jobs (82 minutes, 19 seconds) > master + my series: 103 jobs (79 minutes, 40 seconds) > > That said, let's improve the coverage and add these non-debug tests for Arm. ahah WOW OK then > > One idea would be to only do: > > - qemu-alpine-arm64-gcc-debug > > - qemu-smoke-arm64-gcc-debug > > > > and not the others > > > > > >> Take the opportunity to increase RAM size for QEMU from 1GB to 2GB > >> in qemu-smoke-arm64.sh as the debug builds take more space and we might > >> end up in a situation when there is not enough free space (especially > >> during a static memory test that reserves some region in the middle). > >> > >> Signed-off-by: Michal Orzel > >> --- > >> automation/gitlab-ci/build.yaml | 16 +++++ > >> automation/gitlab-ci/test.yaml | 93 ++++++++++++++++++++++++++ > >> automation/scripts/qemu-smoke-arm64.sh | 6 +- > >> 3 files changed, 112 insertions(+), 3 deletions(-) > >> > >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > >> index d931441b910a..6ce92531f61f 100644 > >> --- a/automation/gitlab-ci/build.yaml > >> +++ b/automation/gitlab-ci/build.yaml > >> @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: > >> CONFIG_UNSUPPORTED=y > >> CONFIG_STATIC_MEMORY=y > >> > >> +alpine-3.12-gcc-debug-arm64-staticmem: > >> + extends: .gcc-arm64-build-debug > >> + variables: > >> + CONTAINER: alpine:3.12-arm64v8 > >> + EXTRA_XEN_CONFIG: | > >> + CONFIG_EXPERT=y > >> + CONFIG_UNSUPPORTED=y > >> + CONFIG_STATIC_MEMORY=y > >> + > >> alpine-3.12-gcc-arm64-boot-cpupools: > >> extends: .gcc-arm64-build > >> variables: > >> @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: > >> EXTRA_XEN_CONFIG: | > >> CONFIG_BOOT_TIME_CPUPOOLS=y > >> > >> +alpine-3.12-gcc-debug-arm64-boot-cpupools: > >> + extends: .gcc-arm64-build-debug > >> + variables: > >> + CONTAINER: alpine:3.12-arm64v8 > >> + EXTRA_XEN_CONFIG: | > >> + CONFIG_BOOT_TIME_CPUPOOLS=y > >> + > >> ## Test artifacts common > >> > >> .test-jobs-artifact-common: > >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > >> index 4f96e6e322de..1b51030c6175 100644 > >> --- a/automation/gitlab-ci/test.yaml > >> +++ b/automation/gitlab-ci/test.yaml > >> @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: > >> tags: > >> - arm64 > >> > >> +qemu-alpine-arm64-gcc-debug: > >> + extends: .test-jobs-common > >> + variables: > >> + CONTAINER: debian:unstable-arm64v8 > >> + script: > >> + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > >> + needs: > >> + - alpine-3.12-gcc-debug-arm64 > >> + - alpine-3.12-arm64-rootfs-export > >> + - kernel-5.19-arm64-export > >> + - qemu-system-aarch64-6.0.0-arm64-export > >> + artifacts: > >> + paths: > >> + - smoke.serial > >> + - '*.log' > >> + when: always > >> + tags: > >> + - arm64 > >> + > >> qemu-alpine-x86_64-gcc: > >> extends: .test-jobs-common > >> variables: > >> @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: > >> tags: > >> - arm64 > >> > >> +qemu-smoke-arm64-gcc-debug: > >> + extends: .test-jobs-common > >> + variables: > >> + CONTAINER: debian:unstable-arm64v8 > >> + script: > >> + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > >> + needs: > >> + - alpine-3.12-gcc-debug-arm64 > >> + - alpine-3.12-arm64-rootfs-export > >> + - kernel-5.19-arm64-export > >> + - qemu-system-aarch64-6.0.0-arm64-export > >> + artifacts: > >> + paths: > >> + - smoke.serial > >> + - '*.log' > >> + when: always > >> + tags: > >> + - arm64 > >> + > >> qemu-smoke-arm64-gcc-staticmem: > >> extends: .test-jobs-common > >> variables: > >> @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: > >> tags: > >> - arm64 > >> > >> +qemu-smoke-arm64-gcc-debug-staticmem: > >> + extends: .test-jobs-common > >> + variables: > >> + CONTAINER: debian:unstable-arm64v8 > >> + script: > >> + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > >> + needs: > >> + - alpine-3.12-gcc-debug-arm64-staticmem > >> + - alpine-3.12-arm64-rootfs-export > >> + - kernel-5.19-arm64-export > >> + - qemu-system-aarch64-6.0.0-arm64-export > >> + artifacts: > >> + paths: > >> + - smoke.serial > >> + - '*.log' > >> + when: always > >> + tags: > >> + - arm64 > >> + > >> qemu-smoke-arm64-gcc-boot-cpupools: > >> extends: .test-jobs-common > >> variables: > >> @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: > >> tags: > >> - arm64 > >> > >> +qemu-smoke-arm64-gcc-debug-boot-cpupools: > >> + extends: .test-jobs-common > >> + variables: > >> + CONTAINER: debian:unstable-arm64v8 > >> + script: > >> + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > >> + needs: > >> + - alpine-3.12-gcc-debug-arm64-boot-cpupools > >> + - alpine-3.12-arm64-rootfs-export > >> + - kernel-5.19-arm64-export > >> + - qemu-system-aarch64-6.0.0-arm64-export > >> + artifacts: > >> + paths: > >> + - smoke.serial > >> + - '*.log' > >> + when: always > >> + tags: > >> + - arm64 > >> + > >> qemu-smoke-arm32-gcc: > >> extends: .test-jobs-common > >> variables: > >> @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: > >> tags: > >> - arm64 > >> > >> +qemu-smoke-arm32-gcc-debug: > >> + extends: .test-jobs-common > >> + variables: > >> + CONTAINER: debian:unstable-arm64v8 > >> + script: > >> + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > >> + needs: > >> + - debian-unstable-gcc-arm32-debug > >> + - qemu-system-aarch64-6.0.0-arm32-export > >> + artifacts: > >> + paths: > >> + - smoke.serial > >> + - '*.log' > >> + when: always > >> + tags: > >> + - arm64 > >> + > >> qemu-smoke-x86-64-gcc: > >> extends: .test-jobs-common > >> variables: > >> diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > >> index f803835779f4..dea26c6c0a8f 100755 > >> --- a/automation/scripts/qemu-smoke-arm64.sh > >> +++ b/automation/scripts/qemu-smoke-arm64.sh > >> @@ -52,7 +52,7 @@ curl -fsSLO https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fraw%2Fv5.2.0%2Fpc-bios%2Fefi-virtio.rom&data=05%7C01%7Cmichal.orzel%40amd.com%7Cf6b0b8fabb02478b009c08da9ce4eac9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994804254367719%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jgGdO93kLoieg6UqajFWYAsufvvv5mZVYHD%2B7fUW7ME%3D&reserved=0 > >> ./binaries/qemu-system-aarch64 \ > >> -machine virtualization=true \ > >> -cpu cortex-a57 -machine type=virt \ > >> - -m 1024 -smp 2 -display none \ > >> + -m 2048 -smp 2 -display none \ > >> -machine dumpdtb=binaries/virt-gicv2.dtb > >> > >> # XXX disable pl061 to avoid Linux crash > >> @@ -117,7 +117,7 @@ cd .. > >> > >> # ImageBuilder > >> echo 'MEMORY_START="0x40000000" > >> -MEMORY_END="0x80000000" > >> +MEMORY_END="0xC0000000" > >> > >> DEVICE_TREE="virt-gicv2.dtb" > >> XEN="xen" > >> @@ -158,7 +158,7 @@ timeout -k 1 240 \ > >> ./binaries/qemu-system-aarch64 \ > >> -machine virtualization=true \ > >> -cpu cortex-a57 -machine type=virt \ > >> - -m 1024 -monitor none -serial stdio \ > >> + -m 2048 -monitor none -serial stdio \ > >> -smp 2 \ > >> -no-reboot \ > >> -device virtio-net-pci,netdev=n0 \ > > > > The changes to qemu-smoke-arm64.sh make sense, but could you move them > > to a separate patch in case we need to do any backports? > > Ok, I will do a prerequisite patch for that one. > > > > > Also I would change MEMORY_END to 0xC0000000 in qemu-alpine-arm64.sh too > > for uniformity. > > I already did that in patch [6/9] automation: qemu-alpine-arm64: Cleanup and fixes. > > ~Michal > From xen-devel-bounces@lists.xenproject.org Fri Sep 23 22:12:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 22:12:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410954.654133 (Exim 4.92) (envelope-from ) id 1obquk-0003h9-ND; Fri, 23 Sep 2022 22:12:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410954.654133; Fri, 23 Sep 2022 22:12:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obquk-0003h2-KO; Fri, 23 Sep 2022 22:12:54 +0000 Received: by outflank-mailman (input) for mailman id 410954; Fri, 23 Sep 2022 22:12:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obquj-0003fu-6N for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 22:12:53 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ddbfb770-3b8c-11ed-9374-c1cf23e5d27e; Sat, 24 Sep 2022 00:12:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 72C3EB82398; Fri, 23 Sep 2022 22:12:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E50C433D6; Fri, 23 Sep 2022 22:12:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddbfb770-3b8c-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663971170; bh=4OzxfWs995lq7cEiFbubZ3KzTx0HQxvLVGhqZkgINdU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=QaaKZoXU4rgOMZTzcIP1wLNE5gxkKzQmlPbxu5r03aFzy3i4MZqdIgmUjTmW8vT1b 4O0sBnzwFeuAy92KmVdWRtLkfXX/CepB8nMBHKJOmkKB9otWJRM1pOFxD4Xq8frt+V Nsoaj5uQEWq1UFYM38JbI5c28Ij4KPztIlDs4IqbDyDvTsTsgj6VnNE9DxlrZkGagC bq2tRtkd8zqJ3aVv9KJkt5qoMmgGCiuoJhyvfbz5tdzePB5nAhrfjQm3QBd0Odi6Uc hGKjoqKX4TAbMNlnXflMQX8y0J5zFd6wISqhVOdUfCzmyLYUXvxnj6JgN+w6ryyf9a jQpO1UNFqni7g== Date: Fri, 23 Sep 2022 15:12:48 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Doug Goldstein Subject: Re: [PATCH 5/9] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder In-Reply-To: <69d8193b-12e2-459e-6921-e84f0f3775d7@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-6-michal.orzel@amd.com> <69d8193b-12e2-459e-6921-e84f0f3775d7@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 23 Sep 2022, Michal Orzel wrote: > Hi Stefano, > > On 23/09/2022 00:13, Stefano Stabellini wrote: > > > > > > On Thu, 22 Sep 2022, Michal Orzel wrote: > >> Take an example from arm64 qemu test scripts and use ImageBuilder > >> to generate u-boot script automatically. Calculating the addresses > >> manually is quite error prone and also we will be able to benefit > >> from using ImageBuilder when adding domUs to this test in the future. > >> > >> Install and use u-boot from the debian package. > >> Modify the script so that binaries are loaded from u-boot via tftp. > > > > Great patch! It makes the test a lot better! > > > > > >> Signed-off-by: Michal Orzel > >> --- > >> automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- > >> 1 file changed, 27 insertions(+), 30 deletions(-) > >> > >> diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh > >> index 530f3892fdd3..765facbe4d66 100755 > >> --- a/automation/scripts/qemu-smoke-arm32.sh > >> +++ b/automation/scripts/qemu-smoke-arm32.sh > >> @@ -4,7 +4,9 @@ set -ex > >> > >> export DEBIAN_FRONTENT=noninteractive > >> apt-get -qy update > >> -apt-get -qy install --no-install-recommends device-tree-compiler \ > >> +apt-get -qy install --no-install-recommends u-boot-qemu \ > >> + u-boot-tools \ > >> + device-tree-compiler \ > >> curl \ > >> cpio > >> > >> @@ -20,10 +22,6 @@ tar xvzf ../initrd.tar.gz > >> find . | cpio -H newc -o | gzip > ../initrd.gz > >> cd .. > >> > >> -kernel=`stat -L --printf="%s" vmlinuz` > >> -initrd=`stat -L --printf="%s" initrd.gz` > >> - > >> -# For Xen, we need a couple of more node. Dump the DT from QEMU and add them > >> # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > >> curl -fsSLO https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fraw%2Fv5.2.0%2Fpc-bios%2Fefi-virtio.rom&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd33d5c4c08934fac0cc208da9ce7a3fb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994815957091528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JuEapfYVLj5P3S5yY%2BAa47Nk4zgbdymjjsiUTmoTmyk%3D&reserved=0 > >> ./qemu-system-arm \ > >> @@ -36,31 +34,31 @@ curl -fsSLO https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fraw%2Fv5.2.0%2Fpc-bios%2Fefi-virtio.rom&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd33d5c4c08934fac0cc208da9ce7a3fb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994815957091528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JuEapfYVLj5P3S5yY%2BAa47Nk4zgbdymjjsiUTmoTmyk%3D&reserved=0 > >> -display none \ > >> -machine dumpdtb=virt.dtb > >> > >> -dtc -I dtb -O dts virt.dtb > virt.dts > >> +# ImageBuilder > >> +echo 'MEMORY_START="0x40000000" > >> +MEMORY_END="0x80000000" > >> + > >> +DEVICE_TREE="virt.dtb" > >> +XEN="xen" > >> +DOM0_KERNEL="vmlinuz" > >> +DOM0_RAMDISK="initrd.gz" > >> +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" > >> +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" > > > > This is missing dtuart=/pl011@9000000 compared to the original > > Actually this is not needed because we always have stdout-path defined in chosen to point to /pl011@... Ah OK, in that case just add a note to the commit message > but I can add this. no need > > > > > >> +NUM_DOMUS=0 > >> + > >> +LOAD_CMD="tftpb" > >> +BOOT_CMD="bootm" > > > > "bootm" because "booti" is not available on arm32, right? > > Exactly. > > > > > >> +UBOOT_SOURCE="boot.source" > >> +UBOOT_SCRIPT="boot.scr"' > config > >> > >> -cat >> virt.dts << EOF > >> -/ { > >> - chosen { > >> - #address-cells = <0x2>; > >> - #size-cells = <0x2>; > >> - stdout-path = "/pl011@9000000"; > >> - xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0"; > >> - xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh"; > >> - dom0 { > >> - compatible = "xen,linux-zimage", "xen,multiboot-module"; > >> - reg = <0x0 0x1000000 0x0 $kernel>; > >> - }; > >> - dom0-ramdisk { > >> - compatible = "xen,linux-initrd", "xen,multiboot-module"; > >> - reg = <0x0 0x3200000 0x0 $initrd>; > >> - }; > >> - }; > >> -}; > >> -EOF > >> -dtc -I dts -O dtb virt.dts > virt.dtb > >> +rm -rf imagebuilder > >> +git clone https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2FViryaOS%2Fimagebuilder&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd33d5c4c08934fac0cc208da9ce7a3fb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994815957091528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=i5N8DXMjn%2F80mdXtc%2FwDGJw6ImUrUAjOg0SJp9CkRdQ%3D&reserved=0 > >> +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > >> > >> rm -f smoke.serial > >> set +e > >> +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ > >> timeout -k 1 240 \ > >> ./qemu-system-arm \ > >> -machine virt \ > >> @@ -70,11 +68,10 @@ timeout -k 1 240 \ > >> -serial stdio \ > >> -monitor none \ > >> -display none \ > >> - -dtb virt.dtb \ > >> -no-reboot \ > >> - -kernel ./xen \ > >> - -device loader,file=./vmlinuz,addr=0x1000000 \ > >> - -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial > >> + -device virtio-net-pci,netdev=n0 \ > >> + -netdev user,id=n0,tftp=./ \ > >> + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial > >> > >> set -e > >> (grep -q "^/ #" smoke.serial) || exit 1 > >> -- > >> 2.25.1 > >> > > ~Michal > From xen-devel-bounces@lists.xenproject.org Fri Sep 23 22:21:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 22:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410963.654144 (Exim 4.92) (envelope-from ) id 1obr37-0005Sg-L1; Fri, 23 Sep 2022 22:21:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410963.654144; Fri, 23 Sep 2022 22:21:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obr37-0005SZ-IT; Fri, 23 Sep 2022 22:21:33 +0000 Received: by outflank-mailman (input) for mailman id 410963; Fri, 23 Sep 2022 22:21:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obr36-0005SP-KI; Fri, 23 Sep 2022 22:21:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obr36-0005YR-JG; Fri, 23 Sep 2022 22:21:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obr35-0005Jh-Vu; Fri, 23 Sep 2022 22:21:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obr35-0003r2-VS; Fri, 23 Sep 2022 22:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ObZSNOpc8yPHSV15thgzRZB2Y0diAO1cO7afP+6GeTQ=; b=LLp/9TFWgk76C6w7faPigq/lSA lGgzkK+Foh3NQj9QoNQwtCLRsXnnVi70YrO9+PxjKEUdGNWrkFOR/bnG2psJLYFDsyjmCk1ceyvfG OTjaIeHnrmwPP2UhHeOu/SacISHnBpuPPCC68Fr19/PdjlzLnE6YT89NUfBkKYmpz3uQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173298: all pass - PUSHED X-Osstest-Versions-This: ovmf=ef9974b298583037a1686f08ee02798110a20ded X-Osstest-Versions-That: ovmf=2500ce101178e55ed29cd18931ab8a73d0ca6e4d From: osstest service owner Date: Fri, 23 Sep 2022 22:21:31 +0000 flight 173298 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173298/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ef9974b298583037a1686f08ee02798110a20ded baseline version: ovmf 2500ce101178e55ed29cd18931ab8a73d0ca6e4d Last test of basis 173297 2022-09-23 17:43:16 Z 0 days Testing same since 173298 2022-09-23 20:13:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jeff Brasen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2500ce1011..ef9974b298 ef9974b298583037a1686f08ee02798110a20ded -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 23 22:23:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 22:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410970.654155 (Exim 4.92) (envelope-from ) id 1obr56-00061o-0T; Fri, 23 Sep 2022 22:23:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410970.654155; Fri, 23 Sep 2022 22:23:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obr55-00061h-Tq; Fri, 23 Sep 2022 22:23:35 +0000 Received: by outflank-mailman (input) for mailman id 410970; Fri, 23 Sep 2022 22:23:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obr54-00061b-Me for xen-devel@lists.xenproject.org; Fri, 23 Sep 2022 22:23:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b91e344-3b8e-11ed-9647-05401a9f4f97; Sat, 24 Sep 2022 00:23:33 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23A8161597; Fri, 23 Sep 2022 22:23:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFCC4C433D6; Fri, 23 Sep 2022 22:23:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b91e344-3b8e-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663971811; bh=E6GXCu7YEWMcFMxVMAB9cXCkBEFihTlj/oscOH+8+/o=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=RRD0zENM0Fc6AfHrt30s4TXCpfBeLvM8Wj7Jbw3AkJCNK5Kobeh2u5GAkeoFG2gO0 qME8de1L3DscwkMv7+gIjQiItAZckYhPCVJwRTZFZS1bU6BTSGEqMZRIXt1SuxI4We iLs4a+ndsOFdSxSbLgMgRL9w6OUWsfBAOfXx1m8ISlqocd0E8A3aR7FUDaTINn0miw lHTO8P2cYbf8bAoGDJwmyW8fK4WLnWgxKCRp+OqYRWe8Dqunne7tCHXOkoqr5yWkyn V3hlkL5K8DpkVvP1oHkDoQqIp6ufoEQMm7H0xu92DXVyHPFdJPk1sE+fKXgFPeypHq k+lNRBY9w/gBw== Date: Fri, 23 Sep 2022 15:23:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Anthony PERARD , xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 4/9] automation: Add Arm containers to containerize script In-Reply-To: <52a75038-7aa0-fb2e-6f4a-1cb749e886a6@amd.com> Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-5-michal.orzel@amd.com> <52a75038-7aa0-fb2e-6f4a-1cb749e886a6@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 23 Sep 2022, Michal Orzel wrote: > Hi Anthony, > > On 23/09/2022 15:56, Anthony PERARD wrote: > > > > > > On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote: > >> Script automation/scripts/containerize makes it easy to build Xen within > >> predefined containers from gitlab container registry. However, it is > >> currently not possible to use it with Arm containers because they are not > >> listed in the script. Populate the necessary entries. > > > > FYI, those entry are just helper/shortcut/aliases, you can use any > > arbitrary container with the script, it just more annoying. > > > > Your patch here allows to write: > > CONTAINER=unstable-arm64v8 automation/scripts/containerize > > but you could write the following instead, for the same result: > > CONTAINER=registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 automation/scripts/containerize > > > > I wonder if the script could select the right container base on the > > architecture of the host, because "alpine" and "alpine-arm64v8" will not > > both work on the same machine. It might be nice to just choose "alpine" > > and the script would select the x86 or arm container automagically. Just > > an idea, no need to do anything about it. > I'm not in favor of adding the automatic selection based on the host. > The reason is that on x86 you can run both x86 and e.g. Arm containers. > You just need to use register qemu-user-static [1] to perform emulation. > This is something widely used and I use that to test Arm images/containers on x86 host. > So you can run both alpine and alpine-arm64v8 on the same machine. Yeah and modern Docker sets up qemu-user-static automatically without the user having to do anything. Anthony, you can try it yourself: you should be able to just: docker run -it registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 on your x86 host if you have a docker new enough From xen-devel-bounces@lists.xenproject.org Fri Sep 23 23:47:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 23 Sep 2022 23:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.410978.654166 (Exim 4.92) (envelope-from ) id 1obsOC-0007AL-RK; Fri, 23 Sep 2022 23:47:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 410978.654166; Fri, 23 Sep 2022 23:47:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obsOC-0007AE-Og; Fri, 23 Sep 2022 23:47:24 +0000 Received: by outflank-mailman (input) for mailman id 410978; Fri, 23 Sep 2022 23:47:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obsOB-0007A4-1p; Fri, 23 Sep 2022 23:47:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obsOA-00075e-UP; Fri, 23 Sep 2022 23:47:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obsOA-0007FH-Fw; Fri, 23 Sep 2022 23:47:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obsOA-0006Qa-FW; Fri, 23 Sep 2022 23:47:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q6wzEz5hVnXECV1YR85idVojyinF70vmGlQoMqczBUc=; b=Ec6Sq9ZdYUKmmvv+76Sff9d+kF N7DMS1CU9er8NsukQbZilvfQvPXVG+pw+/vZmd+22LVa4SYQYes64YI8RH07Q/230UzKgfXxJOkoF uz7/rQ6bxm0b4thTyqGBOQjel1Nb0tIjLzFXRRe6daCwfcIyksUAUMJlkYJQDDmdSOY4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173296: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1707c39ae309bf91965aa6f04d63816a090d90a1 X-Osstest-Versions-That: linux=bf682942cd26ce9cd5e87f73ae099b383041e782 From: osstest service owner Date: Fri, 23 Sep 2022 23:47:22 +0000 flight 173296 linux-linus real [real] flight 173299 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173296/ http://logs.test-lab.xenproject.org/osstest/logs/173299/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 8 xen-boot fail pass in 173299-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail in 173299 like 173283 test-armhf-armhf-libvirt 15 migrate-support-check fail in 173299 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173283 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173283 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173283 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173283 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173283 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173283 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173283 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173283 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 1707c39ae309bf91965aa6f04d63816a090d90a1 baseline version: linux bf682942cd26ce9cd5e87f73ae099b383041e782 Last test of basis 173283 2022-09-23 01:11:09 Z 0 days Testing same since 173296 2022-09-23 16:41:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Alan Stern Alex Deucher Allen-KH Cheng Alvin Lee Andi Shyti AngeloGioacchino Del Regno Carl Yin Carl Yin(殷张成) Catalin Marinas Charlene Liu Chen-Yu Tsai Chris Park Chris Wilson Christian Borntraeger Chun-Kuang Hu Conor Dooley Cruise Hung Daniel Miess Daniel Wheeler Dave Airlie Dmytro Laktyushkin Dr. David Alan Gilbert Evan Quan Fabio Estevam George Shen Gil Fine Greg Kroah-Hartman Guchun Chen Heikki Krogerus Heiko Schocher Heiko Stuebner Hsin-Yi Wang Hugo Hu Janis Schoetterl-Glausch Janosch Frank Janusz Krzysztofik Javier Martinez Canillas jerry meng Jinrong Liang Johan Hovold Juergen Gross Leo Li Linus Torvalds Marc Zyngier Marek Vasut Matthew Rosato Maíra Canal Meenakshikumar Somasundaram Miaohe Lin Michael Strauss Mickaël Salaün Mika Westerberg Mukul Joshi Nathan Chancellor Nicholas Kazlauskas Nico Boehr Nícolas F. R. A. Prado Palmer Dabbelt Paolo Bonzini Phil Auld Randy Dunlap Ren Zhijie Rodrigo Vivi Sean Christopherson Thomas Zimmermann Wang Yugui Wayne Lin William Wu Yifan Zhang Yongqiang Niu Yury Norov Zenghui Yu zhikzhai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git bf682942cd26..1707c39ae309 1707c39ae309bf91965aa6f04d63816a090d90a1 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Sep 24 05:32:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 24 Sep 2022 05:32:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411190.654177 (Exim 4.92) (envelope-from ) id 1obxlu-0000CZ-7G; Sat, 24 Sep 2022 05:32:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411190.654177; Sat, 24 Sep 2022 05:32:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obxlu-0000CR-1q; Sat, 24 Sep 2022 05:32:14 +0000 Received: by outflank-mailman (input) for mailman id 411190; Sat, 24 Sep 2022 05:32:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obxls-0000CH-GJ; Sat, 24 Sep 2022 05:32:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obxls-0004z3-C6; Sat, 24 Sep 2022 05:32:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obxlr-0007kY-JU; Sat, 24 Sep 2022 05:32:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obxlr-0001Kq-HN; Sat, 24 Sep 2022 05:32:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CdhrCH/G1wtzJfNBMMu1sbV2iBhRIWjGtxXr7jU4uCM=; b=gu3mz9vJi33r8aDhlqd3UWKzhS x4mChaEvu83ZaTtunZK3EJkr9eJOMnxLEm7ge+VO4csy+oK2cuIQGNq8VylX/1aY2M9cWCpRkJ6eY vi++4rEtX5NBtp8XtRrOAHQfWDELbtbl8fk313wgoJ/agbn8hh08jF2rNIc8wo7keabk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173300: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a63f2e7cb1107ab124f80407e5eb8579c04eb7a9 X-Osstest-Versions-That: linux=1707c39ae309bf91965aa6f04d63816a090d90a1 From: osstest service owner Date: Sat, 24 Sep 2022 05:32:11 +0000 flight 173300 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173300/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 173296 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 173296 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173296 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173296 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173296 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173296 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173296 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173296 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173296 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173296 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux a63f2e7cb1107ab124f80407e5eb8579c04eb7a9 baseline version: linux 1707c39ae309bf91965aa6f04d63816a090d90a1 Last test of basis 173296 2022-09-23 16:41:26 Z 0 days Testing same since 173300 2022-09-24 00:10:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ilkka Koskinen Linus Torvalds Mark Rutland Sergey Shtylyov Will Deacon jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 1707c39ae309..a63f2e7cb110 a63f2e7cb1107ab124f80407e5eb8579c04eb7a9 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Sep 24 06:00:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 24 Sep 2022 06:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411198.654188 (Exim 4.92) (envelope-from ) id 1obyDE-0003cS-CP; Sat, 24 Sep 2022 06:00:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411198.654188; Sat, 24 Sep 2022 06:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obyDE-0003cL-80; Sat, 24 Sep 2022 06:00:28 +0000 Received: by outflank-mailman (input) for mailman id 411198; Sat, 24 Sep 2022 06:00:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obyDD-0003cB-0r; Sat, 24 Sep 2022 06:00:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obyDC-0005bC-Un; Sat, 24 Sep 2022 06:00:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obyDC-000196-KN; Sat, 24 Sep 2022 06:00:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1obyDC-00083b-Jr; Sat, 24 Sep 2022 06:00:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IqLY+HqYepjsHsqh546eXTfG+9o1mrmI1NyPAMbO5Ek=; b=FHNzQhqMh81gmUEwad5EcQPF2s hS29GX9JicnAOwEmv07depLplEekzSFoGIob04TAV9MrZ+Z+N4QpdFHzc0TzFUbar4/ub0CJchcTH 0V8buCauiofseRtxa36SOtWyR4Vg0OxxxL98wd85ZqWG64MjJVWlEt/PTH8vQob6HPYw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173302: all pass - PUSHED X-Osstest-Versions-This: ovmf=582a7c9995a8fd036a3583ba485467f5a0316cca X-Osstest-Versions-That: ovmf=ef9974b298583037a1686f08ee02798110a20ded From: osstest service owner Date: Sat, 24 Sep 2022 06:00:26 +0000 flight 173302 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173302/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 582a7c9995a8fd036a3583ba485467f5a0316cca baseline version: ovmf ef9974b298583037a1686f08ee02798110a20ded Last test of basis 173298 2022-09-23 20:13:06 Z 0 days Testing same since 173302 2022-09-24 03:12:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ef9974b298..582a7c9995 582a7c9995a8fd036a3583ba485467f5a0316cca -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Sep 24 09:36:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 24 Sep 2022 09:36:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411217.654199 (Exim 4.92) (envelope-from ) id 1oc1Zr-0007ZL-6X; Sat, 24 Sep 2022 09:36:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411217.654199; Sat, 24 Sep 2022 09:36:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc1Zr-0007ZE-3W; Sat, 24 Sep 2022 09:36:03 +0000 Received: by outflank-mailman (input) for mailman id 411217; Sat, 24 Sep 2022 09:36:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc1Zp-0007Z4-U6; Sat, 24 Sep 2022 09:36:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc1Zp-0001Ws-PC; Sat, 24 Sep 2022 09:36:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc1Zp-00088F-6y; Sat, 24 Sep 2022 09:36:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oc1Zp-0000Uj-6Y; Sat, 24 Sep 2022 09:36:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GlMnEWS9L8Sjqco1WkRFKKY3vPqRi80fVWvIuZNsQuA=; b=1nqFmmd9CJijrMHwtHKUyOtTh0 +GKoiAH2Yxky32pX0wGjSaiNWJZq9aRZL40879kq+jij9OWARNGCzxAcbkORsB1uaqH+Qq+a2t6YZ ur1NXxx+BvqwKqp88WtanPJbn5YrlppMsK1sVbmeCEiYNfUi9i754FFIwDkHv6cYXBqY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173301: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Sat, 24 Sep 2022 09:36:01 +0000 flight 173301 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173301/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173284 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173284 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173284 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173284 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173284 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173284 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173284 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173284 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173284 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173284 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173284 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173284 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173284 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173301 2022-09-24 01:52:16 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Sep 24 10:28:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 24 Sep 2022 10:28:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411231.654210 (Exim 4.92) (envelope-from ) id 1oc2OW-0004YN-B0; Sat, 24 Sep 2022 10:28:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411231.654210; Sat, 24 Sep 2022 10:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc2OW-0004YG-85; Sat, 24 Sep 2022 10:28:24 +0000 Received: by outflank-mailman (input) for mailman id 411231; Sat, 24 Sep 2022 10:28:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc2OV-0004Y6-Ck; Sat, 24 Sep 2022 10:28:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc2OV-0002Yc-9H; Sat, 24 Sep 2022 10:28:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oc2OU-0000vq-TC; Sat, 24 Sep 2022 10:28:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oc2OU-0003ID-Sj; Sat, 24 Sep 2022 10:28:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bStfzj2V2lbwlvFGaAvdd9FLWCBiCl+t3C+rDyD/1Ws=; b=UL+YUJEp624pcdEBbGoWM2mMyH g9iDERv0Ho5VSxj6qy6q8xIDBwqOMHA9CIq23d1CcgXK+WJ+l1LcRAEHNGjjYzHMwD1lp2mUoJ1Kr b1PIFquy3wB/Ox4yz8tLw4zgF1XZaspKM/DWYhB/20fjWro01N6P3QWEhNXfTgAa4how=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173303: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=0377177c7856bb87a9d8aa1324b54f5fbe9f1e5b X-Osstest-Versions-That: libvirt=68e93e3180ad4e51bf9f86850dc86d8f528d6564 From: osstest service owner Date: Sat, 24 Sep 2022 10:28:22 +0000 flight 173303 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173303/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail like 173287 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173287 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173287 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173287 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: libvirt 0377177c7856bb87a9d8aa1324b54f5fbe9f1e5b baseline version: libvirt 68e93e3180ad4e51bf9f86850dc86d8f528d6564 Last test of basis 173287 2022-09-23 04:22:21 Z 1 days Testing same since 173303 2022-09-24 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 68e93e3180..0377177c78 0377177c7856bb87a9d8aa1324b54f5fbe9f1e5b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Sep 24 20:49:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 24 Sep 2022 20:49:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411274.654220 (Exim 4.92) (envelope-from ) id 1ocC50-0004et-4O; Sat, 24 Sep 2022 20:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411274.654220; Sat, 24 Sep 2022 20:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocC50-0004em-1h; Sat, 24 Sep 2022 20:48:54 +0000 Received: by outflank-mailman (input) for mailman id 411274; Sat, 24 Sep 2022 20:48:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocC4z-0004ec-27; Sat, 24 Sep 2022 20:48:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocC4y-0005py-P2; Sat, 24 Sep 2022 20:48:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocC4y-0001xv-9q; Sat, 24 Sep 2022 20:48:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocC4y-0004ZK-9P; Sat, 24 Sep 2022 20:48:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lbQglXA//CXkRjTliaTkCcSWOc32eEPlCHza6JECSp8=; b=f8p7Hc97r48VRaBjKhN1kuqrMC ZkC7rF3sYFQOLOhlJI8tIoURLMxx9YP/AER+m9NIsXi9WpNXxjYFwZgOYHVV1Ymroffu3JQdojJWM wvQJr93L0C/aVPD4Apr3nCP2rV7ySvfIL7MEzzcedS7h+TM4tUR17HxUORFj5qMhmxJs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173304: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3db61221f4e8f18d1dd6e45dbe9e3702ff2d67ab X-Osstest-Versions-That: linux=a63f2e7cb1107ab124f80407e5eb8579c04eb7a9 From: osstest service owner Date: Sat, 24 Sep 2022 20:48:52 +0000 flight 173304 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173304/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173300 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173300 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173300 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173300 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173300 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173300 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173300 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173300 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173300 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3db61221f4e8f18d1dd6e45dbe9e3702ff2d67ab baseline version: linux a63f2e7cb1107ab124f80407e5eb8579c04eb7a9 Last test of basis 173300 2022-09-24 00:10:52 Z 0 days Testing same since 173304 2022-09-24 15:42:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christoph Hellwig Jens Axboe Linus Torvalds Stefan Haberland jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git a63f2e7cb110..3db61221f4e8 3db61221f4e8f18d1dd6e45dbe9e3702ff2d67ab -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Sep 25 05:06:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 25 Sep 2022 05:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411297.654232 (Exim 4.92) (envelope-from ) id 1ocJpt-0000wm-4a; Sun, 25 Sep 2022 05:05:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411297.654232; Sun, 25 Sep 2022 05:05:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocJps-0000we-VR; Sun, 25 Sep 2022 05:05:48 +0000 Received: by outflank-mailman (input) for mailman id 411297; Sun, 25 Sep 2022 05:05:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocJps-0000wU-IV; Sun, 25 Sep 2022 05:05:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocJps-0006OH-F3; Sun, 25 Sep 2022 05:05:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocJpr-00073h-TA; Sun, 25 Sep 2022 05:05:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocJpr-0003vW-Sh; Sun, 25 Sep 2022 05:05:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YnFeHNbEVt6XSl8dfZo1vFWHMlEUaosYAz8ZpIU7Fmc=; b=GBnhipalqIl7ZVp0vV2Be6Nr7L 10itHW/WxPyG7eBNvoweWDXh8pWjlS/g1+xAyc6U8VusfbGODVPB2F4gTQaWcxdoq5wm2SIb0xfpN siwatP033bQO/4tVixpGHuPQ27Zc65en1b9RHM5y10mhHbPWv1WEK+Tv1dzkAjBPHvRg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173305: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1a61b828566fba088d3baa0dc3e440b51fdf9ce2 X-Osstest-Versions-That: linux=3db61221f4e8f18d1dd6e45dbe9e3702ff2d67ab From: osstest service owner Date: Sun, 25 Sep 2022 05:05:47 +0000 flight 173305 linux-linus real [real] flight 173307 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173305/ http://logs.test-lab.xenproject.org/osstest/logs/173307/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 8 xen-boot fail pass in 173307-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173307 like 173304 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173307 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173304 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173304 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173304 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173304 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173304 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173304 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173304 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173304 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 1a61b828566fba088d3baa0dc3e440b51fdf9ce2 baseline version: linux 3db61221f4e8f18d1dd6e45dbe9e3702ff2d67ab Last test of basis 173304 2022-09-24 15:42:57 Z 0 days Testing same since 173305 2022-09-24 21:12:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Greg Kroah-Hartman Ilpo Järvinen Linus Torvalds Lukas Wunner Matthias Schiffer Ming Lei Mukesh Ojha Olof Johansson Pali Rohár Palmer Dabbelt Russ Weight Shinichiro Kawasaki Tejun Heo Tetsuo Handa Vinod Koul William Breathitt Gray Xu Yilun jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 3db61221f4e8..1a61b828566f 1a61b828566fba088d3baa0dc3e440b51fdf9ce2 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Sep 25 08:57:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 25 Sep 2022 08:57:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411318.654243 (Exim 4.92) (envelope-from ) id 1ocNRs-0006gn-Ed; Sun, 25 Sep 2022 08:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411318.654243; Sun, 25 Sep 2022 08:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocNRs-0006gg-C0; Sun, 25 Sep 2022 08:57:16 +0000 Received: by outflank-mailman (input) for mailman id 411318; Sun, 25 Sep 2022 08:57:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocNRq-0006gG-TO; Sun, 25 Sep 2022 08:57:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocNRq-0002UX-OB; Sun, 25 Sep 2022 08:57:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocNRq-0000KL-AW; Sun, 25 Sep 2022 08:57:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocNRq-000753-A0; Sun, 25 Sep 2022 08:57:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c0MTlqF41KmPr5drVFcAqJffAv/jDaUNRywUuGcAf24=; b=PJqv+FMvdXnfUHtMPXfOffUDlu o839IoH5IZV9+rJDFVRhT0ohUyQSy3OhiaScO0JHJbrLLVC3nG651X1vUt0NSQo2nVP1ieJEf7Y56 oBtIxOZm+S3k/3op7CNEgXaV7A8RZ64Utz0bg4p3+u1fHR7+Tc1cv/iUtxWxcWOtrFxs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173306: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Sun, 25 Sep 2022 08:57:14 +0000 flight 173306 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173306/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-examine-uefi 6 xen-install fail pass in 173301 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173301 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173301 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173301 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173301 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173301 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173301 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173301 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173301 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173301 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173301 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173301 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173301 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173301 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173306 2022-09-25 01:53:17 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Sep 25 11:59:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 25 Sep 2022 11:59:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411332.654254 (Exim 4.92) (envelope-from ) id 1ocQHd-0007Ad-6f; Sun, 25 Sep 2022 11:58:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411332.654254; Sun, 25 Sep 2022 11:58:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocQHd-0007AW-2C; Sun, 25 Sep 2022 11:58:53 +0000 Received: by outflank-mailman (input) for mailman id 411332; Sun, 25 Sep 2022 11:58:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocQHa-0007AM-Uw; Sun, 25 Sep 2022 11:58:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocQHa-0005bI-SP; Sun, 25 Sep 2022 11:58:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocQHa-0004nb-9f; Sun, 25 Sep 2022 11:58:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocQHa-0000g2-9A; Sun, 25 Sep 2022 11:58:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gQFjxFaBztvHLclg+L4YBII5K9gAYVsrBDOGlUeq9WM=; b=ugsaEDv1JTL276krwpe6/KlNqj JAuZxx3qKsHiiBxEsalhX3p6c+bG7jaF83E7TLfT8Ml9rabw6P/Wu6BcVum0U6bupF1DRTY4tE8pc BRQyKh+vNfY+n5Mj4gVsgBhYpm4DJdl/op5OcLGjSeyY2KjS4lWYinaehApA/VpGI+qc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173308: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=105a36f3694edc680f3e9318cdd3c03722e42554 X-Osstest-Versions-That: linux=1a61b828566fba088d3baa0dc3e440b51fdf9ce2 From: osstest service owner Date: Sun, 25 Sep 2022 11:58:50 +0000 flight 173308 linux-linus real [real] flight 173309 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173308/ http://logs.test-lab.xenproject.org/osstest/logs/173309/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl 8 xen-boot fail pass in 173309-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173305 test-armhf-armhf-xl 15 migrate-support-check fail in 173309 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 173309 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173305 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173305 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173305 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173305 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173305 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173305 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173305 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 105a36f3694edc680f3e9318cdd3c03722e42554 baseline version: linux 1a61b828566fba088d3baa0dc3e440b51fdf9ce2 Last test of basis 173305 2022-09-24 21:12:17 Z 0 days Testing same since 173308 2022-09-25 05:08:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Borowski Christophe JAILLET Halil Pasic Linus Torvalds Masahiro Yamada Nick Desaulniers Rafael J. Wysocki Rob Herring Tony Krowiak Vasily Gorbik Viresh Kumar yangxingwu Zeng Heng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 1a61b828566f..105a36f3694e 105a36f3694edc680f3e9318cdd3c03722e42554 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Sep 25 22:10:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 25 Sep 2022 22:10:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411361.654265 (Exim 4.92) (envelope-from ) id 1ocZok-0005jt-Fq; Sun, 25 Sep 2022 22:09:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411361.654265; Sun, 25 Sep 2022 22:09:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocZok-0005jm-Bx; Sun, 25 Sep 2022 22:09:42 +0000 Received: by outflank-mailman (input) for mailman id 411361; Sun, 25 Sep 2022 22:09:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocZoj-0005jc-Vf; Sun, 25 Sep 2022 22:09:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocZoj-0008Tc-Sz; Sun, 25 Sep 2022 22:09:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocZoj-0005mz-AI; Sun, 25 Sep 2022 22:09:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocZoj-0000TM-9o; Sun, 25 Sep 2022 22:09:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HCtvwyydpFErwcEafP/eAz8/u8pWQKZUyOPMg0Hm/Ok=; b=ifM6dMtjWkK5WwdL4q4uGK8Iwq WYz63SJDRFJfOSrZfN6eS7A45rm/Yz+ONEssWUSqOAmiWYmNAQHO9IdTqvCFS0CxPz95cGXx+PpQh bSjLzP2Ilkp45IHkB2mwErWztRPVTnEZK6Qihcr3Nc2fZphJ1JzCqomMio+sTsw/HecI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173310: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5e049663f678938dd56812ba870a471060f8ce28 X-Osstest-Versions-That: linux=105a36f3694edc680f3e9318cdd3c03722e42554 From: osstest service owner Date: Sun, 25 Sep 2022 22:09:41 +0000 flight 173310 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173310/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173308 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173308 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173308 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173308 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173308 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173308 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173308 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173308 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 5e049663f678938dd56812ba870a471060f8ce28 baseline version: linux 105a36f3694edc680f3e9318cdd3c03722e42554 Last test of basis 173308 2022-09-25 05:08:44 Z 0 days Testing same since 173310 2022-09-25 16:10:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Shevchenko Asmaa Mnebhi Dan Carpenter Dan Williams Jan Kara Jane Chu Li Jinlin Linus Torvalds Luca Ceresoli Luís Henriques Ojaswin Mujoo Oleksij Rempel Peter Rosin Ricardo Sandoval Torres Shivaprasad G Bhat Stefan Wahren Theodore Ts'o Uwe Kleine-König Wolfram Sang Wolfram Sang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 105a36f3694e..5e049663f678 5e049663f678938dd56812ba870a471060f8ce28 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Sep 26 03:22:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 03:22:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411370.654276 (Exim 4.92) (envelope-from ) id 1ocehH-0001VI-B1; Mon, 26 Sep 2022 03:22:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411370.654276; Mon, 26 Sep 2022 03:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocehH-0001Us-4b; Mon, 26 Sep 2022 03:22:19 +0000 Received: by outflank-mailman (input) for mailman id 411370; Mon, 26 Sep 2022 03:22:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocehF-0001Ui-I6; Mon, 26 Sep 2022 03:22:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocehF-0005OS-Fj; Mon, 26 Sep 2022 03:22:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocehE-0000NO-VK; Mon, 26 Sep 2022 03:22:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocehE-0000bh-Uv; Mon, 26 Sep 2022 03:22:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Xp3pVgovdcN8Dic2Yjo727KbQa9UFFxVTB4dhVfU8fA=; b=DtMckj21ws9Y/DZVT080r9q2MG Km3ruDqNTDqUsOigDKUX8dOYDKgOAdjw3Yf/uEdbH38302c6CRaTc0ZwaIG2qPwiUr1ok0g4EMG9N CieST2m6RZMbSv/YNTnfIJQtlGf93vEa1Uc1m9/avkBi83zywvRkTmzh7TRRWkU3IzL8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173312: all pass - PUSHED X-Osstest-Versions-This: ovmf=0e7aa6bf9e0a7a91136353a3d6fe6a90d2047fc0 X-Osstest-Versions-That: ovmf=582a7c9995a8fd036a3583ba485467f5a0316cca From: osstest service owner Date: Mon, 26 Sep 2022 03:22:16 +0000 flight 173312 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173312/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0e7aa6bf9e0a7a91136353a3d6fe6a90d2047fc0 baseline version: ovmf 582a7c9995a8fd036a3583ba485467f5a0316cca Last test of basis 173302 2022-09-24 03:12:01 Z 2 days Testing same since 173312 2022-09-26 01:41:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yi Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 582a7c9995..0e7aa6bf9e 0e7aa6bf9e0a7a91136353a3d6fe6a90d2047fc0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Sep 26 03:41:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 03:41:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411379.654287 (Exim 4.92) (envelope-from ) id 1ocezO-0003t6-RJ; Mon, 26 Sep 2022 03:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411379.654287; Mon, 26 Sep 2022 03:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocezO-0003sz-NQ; Mon, 26 Sep 2022 03:41:02 +0000 Received: by outflank-mailman (input) for mailman id 411379; Mon, 26 Sep 2022 03:41:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocezO-0003sq-Ds; Mon, 26 Sep 2022 03:41:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocezO-0005k2-B5; Mon, 26 Sep 2022 03:41:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocezN-0001cZ-Ke; Mon, 26 Sep 2022 03:41:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocezN-00045i-KG; Mon, 26 Sep 2022 03:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WM8lRRgyHFso2EovlgGiJlLXaJaRT2nSyGaxHs7WDGM=; b=EVYt5VpCq3z4nDAQG4K/uVNqrr op9CdLYc/m/2X2sy3XBAjmGmQ2YfYruqu+cO2ui38Qjx5W5/ZzHQohxQ50i1+sNAjNdOF3ADkyjy0 lw1juqC1OtHdko5hr5LHcqkhvMo7wgJq7NKAxAIPJwa/b52V7QMARiIKFRCfzmgnUnss=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173311: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f76349cf41451c5c42a99f18a9163377e4b364ff X-Osstest-Versions-That: linux=5e049663f678938dd56812ba870a471060f8ce28 From: osstest service owner Date: Mon, 26 Sep 2022 03:41:01 +0000 flight 173311 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173311/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173310 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173310 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173310 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173310 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173310 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173310 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173310 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173310 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux f76349cf41451c5c42a99f18a9163377e4b364ff baseline version: linux 5e049663f678938dd56812ba870a471060f8ce28 Last test of basis 173310 2022-09-25 16:10:55 Z 0 days Testing same since 173311 2022-09-25 22:42:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 5e049663f678..f76349cf4145 f76349cf41451c5c42a99f18a9163377e4b364ff -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Sep 26 06:21:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 06:21:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411391.654298 (Exim 4.92) (envelope-from ) id 1ochUR-00033D-E1; Mon, 26 Sep 2022 06:21:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411391.654298; Mon, 26 Sep 2022 06:21:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ochUR-000336-BB; Mon, 26 Sep 2022 06:21:15 +0000 Received: by outflank-mailman (input) for mailman id 411391; Mon, 26 Sep 2022 06:21:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ochUP-000330-Vj for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 06:21:14 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150082.outbound.protection.outlook.com [40.107.15.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 693d48ee-3d63-11ed-9647-05401a9f4f97; Mon, 26 Sep 2022 08:21:10 +0200 (CEST) Received: from FR0P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::22) by GV2PR08MB8320.eurprd08.prod.outlook.com (2603:10a6:150:b5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 06:21:05 +0000 Received: from VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::e3) by FR0P281CA0039.outlook.office365.com (2603:10a6:d10:48::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.14 via Frontend Transport; Mon, 26 Sep 2022 06:21:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT062.mail.protection.outlook.com (10.152.18.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 06:21:04 +0000 Received: ("Tessian outbound 0a0431bdcdb4:v124"); Mon, 26 Sep 2022 06:21:03 +0000 Received: from b18c6d6e9b20.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9203547F-9024-4A9D-A552-28A72D28A0BB.1; Mon, 26 Sep 2022 06:20:57 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b18c6d6e9b20.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 06:20:57 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB4PR08MB9312.eurprd08.prod.outlook.com (2603:10a6:10:3f4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 06:20:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::f997:4dac:eff8:93d6]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::f997:4dac:eff8:93d6%4]) with mapi id 15.20.5654.024; Mon, 26 Sep 2022 06:20:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 693d48ee-3d63-11ed-9647-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UK/Ia14reBIRtBP6VHiP2OMKXoJXniWR+x10wdyG3LvG7dSQVQNe2wVCUQy3mcJ/gsZIJ7iOrHq50Eaykd7kNo00CN8GesSObZ6UNzC9jWgihN5NF68ogtEUWvF5LjnEcJnahZn/QEEZZ8y4xOeL1+EYALKsLtTbMIS2w+8fwPJNHrSslPFS7aRyD0FqiBe7Y7x+qzs+1m/Zht+Wn/iWE0kQWYTOn8EC413SX4gUV5RcVFtNfwZ7IukzTy4XA81Dey3IVbBnt5Jd8KvPR1pkgpbOghEtOx+/9qUzCVJCwwT/u7VrHsXk7CrsknRD3bJcFgGN7r4T+TTxajvLsT+gkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+j9g1eef5Mhx82JSWbsdv3g6wgmZV5MHnTvk0yfFkYs=; b=jCjXtGwazcWp+3D1XkhRKXtDvXl8Ioj988HWKhvEvIJPPe/BJ8bB8w4ObNxAkuuw/XJr4v7C2pYE8BGA4QIylvkxmRhkcG4flQav1nNbXWFVs9GDfPmWRk9Vr/DY8L/0kRBOhddxp32G6dvfVW25XttXrFGAMW2nwvK+N+Qa5I6Ui/Xt5dqLIitqnMUHMzI5BbGkdL+nc12no/2WvoSSm/sDIjbXo5S7lq1bagVcgSkTQ7Z1VvyafXAcEiYATUeoOMYQ6Bj4653xoncKstd0tEh+Sm6qK3A+AbxOqiit+XMyJXVd3mQI1aE+mahtQPaflEXEB7CPopN11UbtgLnNPA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j9g1eef5Mhx82JSWbsdv3g6wgmZV5MHnTvk0yfFkYs=; b=9J8utZ6EdR+GmFF94xIsAJMQimVTATBMkdHSNfVr1CTMFyw8bXI90N9LxdzEhLhI7/y9nHB7j+3MAag4m0kSVTo5ETMzs2FhPhJzbnA/ASrpfQp6C/0hYpex1JbH44d5XD442u7vG9CwBj6dmMBRq5qXWFzMy6sVtR33PKpWZXk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 97a8715d04f7b124 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hKlL+YtEB5lJBfyclcLH1pE6wEqZI9Q2lbTK7GNUahf/huZYcG7846/0I5kgGdphaX5KR5anA8b3KNLSCEIr7IZbndEMoM1wLQ4KbqpDYcPj+aPfaJ3xSGO+aIs6UOSZMDQAlpbWLo3qs+qjUil+qOKdOi/4vvlmhvRDqGdUZLrBkl3C7Q8be+Dk/WP6DZDeNoiwyTnqBdLMKeOfmMbBdYbrX1Db9jKXiULOpHkGpeErxak8rsdltWglS2avkAu6PIoUs6HBc4zobpGb8EJStQdTtTrWjfh58P0FUCbwK7/QvOsM24JKRM2H41H4I93DCMPB9Gm7Z4JxD1U6MKppgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+j9g1eef5Mhx82JSWbsdv3g6wgmZV5MHnTvk0yfFkYs=; b=QxYoQAmvYSt++xTG8tmCcA0bba1oPlpZdTcS8UxZd1WiMPAJZlXHw3Jie6e2UHvPporq3P0vHeilbEcFmHGY32CVUzKfNncoFAyH0bwxc58MNunDN/twbenQ/iWsLLkxalquJ7LQ5W4bOANbkdeaCc/vHGYpWCLklQIkdLoKTcvDx0oQFI6XvhUshSD4s8kTPA6N+zZSRSCGV95XTQMlHTJ6H2KG7mooJKJ5VBztJLYFW0Isu0BQDH0u+IdlsH/uwMbwuMdCim9rx0iFlMNXD+vklcDZJHG7Bj8yDWehDQ71VMxgJOCRtEKqjVrqI5PfvGzbhV9ejBRX5/B8+51HJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j9g1eef5Mhx82JSWbsdv3g6wgmZV5MHnTvk0yfFkYs=; b=9J8utZ6EdR+GmFF94xIsAJMQimVTATBMkdHSNfVr1CTMFyw8bXI90N9LxdzEhLhI7/y9nHB7j+3MAag4m0kSVTo5ETMzs2FhPhJzbnA/ASrpfQp6C/0hYpex1JbH44d5XD442u7vG9CwBj6dmMBRq5qXWFzMy6sVtR33PKpWZXk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <1369a435-ad92-3bbd-60e4-27c1e49c1bc9@arm.com> Date: Mon, 26 Sep 2022 14:20:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 01/12] xen/arm: add cache coloring initialization Content-Language: en-US To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-2-carlo.nonato@minervasys.tech> From: Wei Chen In-Reply-To: <20220826125111.152261-2-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|DB4PR08MB9312:EE_|VE1EUR03FT062:EE_|GV2PR08MB8320:EE_ X-MS-Office365-Filtering-Correlation-Id: 7851bdd8-e2b6-4b25-aa36-08da9f874a7a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3fTDWgm1lNmcgPJPjy/J4LnVJUpKB2zaue4NFFZG8USjlu1E6yIwIsFePJuDLEVJoV0D6VK4am9pI8DewRiOjYvX/aDHEBWwwSnei+nK9IGKA+p0SgmhqszDv0GOX3BbDSL2SEreWte5wTm+s6B56irAmm6lSODhXZ2vpTR7iYkj5XNZscSmu+NyZt4dDAbJe6T5OnuDFJ6zqSbjMpPKdIXD9dJ2ufk8H4JemEOyqLjphgHp/4ZXj8JSFiGFQiPCz0G11weM6DLX23/TdOmAMrtmL8+EyT8xRYaUdUzR6CFD0CGVlAVDwfZIF3Yx3jOl1kdkX8dxZv0epZSVyFXud1f5l4lrULijKxPl8UO9DiDjPxr2ff9o9MJVj+20Oem9cFX+kTqxemdaQCBxH2LmGLqjUx1MTpIhjK0gtgApit4pKhijMBVAyfbX6/wquT7Rt6/71oDYd+VuU2yrWMv+3HOmNBfNxgkbOWOm9b15j8hlmnlfc6KsH8kqAlJq8ZNcArgIw9utcEudPMLMgpkaJrRncN/AYit+HKIqqM6QoSBXS4Zhls5R17y23UYAaOo4J4F6UBzujvxdMqNm8u1HGW3tFkXay5CjhMIteh4MyGaOGwFK4Q1ILy5V8bM98abOeiL+gqQuwsvdrHc8B92SdHF4WwcYeuHNIr0Lz+ySdC7SxKqI4+y2C6cEybg5o6ltRJ4TukUZ5heDXoH76vIHYiPzEux/p/Yau2UVHF0iOc+Vv4QbIDj8xgum6bG1GlJQNQ8CHiVssVnBpiWjqCX6MROmYoR3KsoaWJVugZuyWp0pbw2s0CRIrAmMf5tHWCg3F0kIEeY+GPIZ8lL/P4B5sg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(39850400004)(396003)(376002)(451199015)(36756003)(31696002)(86362001)(66946007)(66476007)(66556008)(6486002)(316002)(478600001)(38100700002)(41300700001)(6666004)(8676002)(31686004)(4326008)(5660300002)(7416002)(6512007)(26005)(2616005)(2906002)(30864003)(186003)(83380400001)(8936002)(6506007)(53546011)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9312 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 53089b39-be50-414d-8e81-08da9f8743d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6qn0t+i4TG5gLu+PV3frdtuZff7BxJAqbRMPT/HZGtXJl0VwxErhkUsIZU9t2o2xywH/kw+dQYzP1UdyYufhJO/2tFs2wMYasNvalJylgfK8Ugn2I+w5nS6ipt8r510itvCDFiike50xLVC5iR8pN2uODwVbFFG3Ijz/MBcuByMOlxqnPXFIMXgK0/46S09gW2/XR7n6C9Uk4BebRYfDAks+Hy4xbkwTSWZFGIDdXHc/dp44sQfjOSQXiiOC9hwN3rC+tgz6l1GuJGQ5Rzt3ilHfYwoqiW2UUy2peQTH7UAFFGXCSsxVHBEhcANh/jjemA3mqCOAyghNAMlKsccfDOjClRUqK7mYuw/bg9baO9UWCF1qUV9CHhQJZQWwoWo0BV5y2SFc8pmO41AcBlAT/MjM6WswdGVWMdy6y+6IXyHmHT2wVG3sS/MHaCnedZss9jgbF+vOV2w30hdHVxcLyk5IyIu/TWhT9GHsrBs5CNQdA5OYb2uqIFhOnwMInpSPc3EsbV+ntkMWCjlfyQReqPsyylsvvcJTd3pSS9LLA4xV14j8cdydJamC+Uz3WT/gi1+1JHgadFxLTyPSbSA2b5/r4EWJlMeiRrqL2a++KbvhUcRI5FEcuti5vkypkAJJpDYf8iR3oBq7EW4IA0yMkhlIWz3b1ScwB+EbVbfMeczAOT2vXCu0hmzzQCzNf3dOOJFXiPuyublxsDRl/wpPUPPkSRLHWYHD6NbzsKCcCbjDaIsZUZOTdueQF9UTjQNECHacqIg4UspkpJqr1dxuKAK+iZsuRbUafJRri7YFoMnQDbwbQ1V1gSHn0nic0j6hiKrL8R9c5iaJQoFRthynp+d/8+qXBfXJqk8Ak02Nauw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(36860700001)(30864003)(5660300002)(8936002)(40460700003)(31696002)(26005)(53546011)(6512007)(40480700001)(478600001)(82310400005)(6486002)(83380400001)(6506007)(41300700001)(107886003)(6666004)(316002)(70206006)(4326008)(36756003)(336012)(186003)(70586007)(2616005)(47076005)(8676002)(31686004)(86362001)(82740400003)(81166007)(2906002)(356005)(2004002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 06:21:04.3713 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7851bdd8-e2b6-4b25-aa36-08da9f874a7a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8320 Hi Carlo, On 2022/8/26 20:51, Carlo Nonato wrote: > This commit adds the cache coloring support initialization, Kconfig options, > command line parameters and the initial documentation. > The initialization consists of an auto probing of the cache layout > necessary to retrieve the LLC way size which is used to compute the > number of available colors. The Dom0 colors are then initialized with default > colors (all available ones) if not provided from the command line, and > they are checked for bad configuration. > > It also adds a debug-key to dump general cache coloring info. > This includes LLC way size, total available colors and the mask used to > extract colors from physical addresses. > > Signed-off-by: Carlo Nonato > Signed-off-by: Marco Solieri > --- > docs/misc/arm/cache-coloring.rst | 112 ++++++++++++++ > docs/misc/xen-command-line.pandoc | 22 +++ > xen/arch/arm/Kconfig | 16 ++ > xen/arch/arm/Makefile | 1 + > xen/arch/arm/coloring.c | 222 +++++++++++++++++++++++++++ > xen/arch/arm/include/asm/coloring.h | 31 ++++ > xen/arch/arm/include/asm/processor.h | 16 ++ > xen/arch/arm/setup.c | 8 + > 8 files changed, 428 insertions(+) > create mode 100644 docs/misc/arm/cache-coloring.rst > create mode 100644 xen/arch/arm/coloring.c > create mode 100644 xen/arch/arm/include/asm/coloring.h > > diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst > new file mode 100644 > index 0000000000..c7adcb0f1f > --- /dev/null > +++ b/docs/misc/arm/cache-coloring.rst > @@ -0,0 +1,112 @@ > +Xen cache coloring user guide > +============================= > + > +The cache coloring support in Xen allows to reserve Last Level Cache (LLC) > +partition for Dom0, DomUs and Xen itself. Currently only ARM64 is supported. > + > +In order to enable and use it, few steps are needed. > + > +- Enable cache coloring in Xen configuration file. > + > + CONFIG_CACHE_COLORING=y > +- If needed, change the maximum number of colors in Xen configuration file > + (refer to menuconfig help for value meaning and when it should be changed). > + > + CONFIG_MAX_CACHE_COLORS= > +- Assign colors to Dom0 using the `Color selection format`_ (see > + `Coloring parameters`_ for more documentation pointers). > + > +Background > +********** > + > +Cache hierarchy of a modern multi-core CPU typically has first levels dedicated > +to each core (hence using multiple cache units), while the last level is shared > +among all of them. Such configuration implies that memory operations on one > +core (e.g. running a DomU) are able to generate interference on another core > +(e.g .hosting another DomU). Cache coloring allows eliminating this > +mutual interference, and thus guaranteeing higher and more predictable > +performances for memory accesses. > +The key concept underlying cache coloring is a fragmentation of the memory > +space into a set of sub-spaces called colors that are mapped to disjoint cache > +partitions. Technically, the whole memory space is first divided into a number > +of subsequent regions. Then each region is in turn divided into a number of > +subsequent sub-colors. The generic i-th color is then obtained by all the > +i-th sub-colors in each region. > + > +.. raw:: html > + > + 
> +                            Region j            Region j+1
> +                .....................   ............
> +                .                     . .
> +                .                       .
> +            _ _ _______________ _ _____________________ _ _
> +                |     |     |     |     |     |     |
> +                | c_0 | c_1 |     | c_n | c_0 | c_1 |
> +           _ _ _|_____|_____|_ _ _|_____|_____|_____|_ _ _
> +                    :                       :
> +                    :                       :...         ... .
> +                    :                            color 0
> +                    :...........................         ... .
> +                                                :
> +          . . ..................................:
> +
> + > +There are two pragmatic lesson to be learnt. > + > +1. If one wants to avoid cache interference between two domains, different > + colors needs to be used for their memory. > + > +2. Color assignment must privilege contiguity in the partitioning. E.g., > + assigning colors (0,1) to domain I and (2,3) to domain J is better than > + assigning colors (0,2) to I and (1,3) to J. > + > +How to compute the number of colors > +*********************************** > + > +To compute the number of available colors for a specific platform, the size of > +a LLC way and the page size used by Xen must be known. The first parameter can > +be found in the processor manual or can be also computed dividing the total > +cache size by the number of its ways. The second parameter is the minimum amount > +of memory that can be mapped by the hypervisor, thus dividing the way size by > +the page size, the number of total cache partitions is found. So for example, > +an Arm Cortex-A53 with a 16-ways associative 1 MiB LLC, can isolate up to 16 > +colors when pages are 4 KiB in size. > + > +Cache layout is probed automatically by Xen itself, but a possibility to > +manually set the way size it's left to the user to overcome failing situations > +or for debugging/testing purposes. See `Coloring parameters`_ section for more > +information on that. > + > +Colors selection format > +*********************** > + > +Regardless of the memory pool that has to be colored (Xen, Dom0/DomUs), > +the color selection can be expressed using the same syntax. In particular a > +comma-separated list of colors or ranges of colors is used. > +Ranges are hyphen-separated intervals (such as `0-4`) and are inclusive on both > +sides. > + > +Note that: > + - no spaces are allowed between values. > + - no overlapping ranges or duplicated colors are allowed. > + - values must be written in ascending order. > + > +Examples: > + > ++---------------------+-----------------------------------+ > +|**Configuration** |**Actual selection** | > ++---------------------+-----------------------------------+ > +| 1-2,5-8 | [1, 2, 5, 6, 7, 8] | > ++---------------------+-----------------------------------+ > +| 4-8,10,11,12 | [4, 5, 6, 7, 8, 10, 11, 12] | > ++---------------------+-----------------------------------+ > +| 0 | [0] | > ++---------------------+-----------------------------------+ > + > +Coloring parameters > +******************* > + > +LLC way size (as previously discussed) and Dom0 colors can be set using the > +appropriate command line parameters. See the relevant documentation in > +"docs/misc/xen-command-line.pandoc". > \ No newline at end of file > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index 9a79385a37..910ebeb2eb 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -889,6 +889,14 @@ Controls for the dom0 IOMMU setup. > > Incorrect use of this option may result in a malfunctioning system. > > +### dom0-colors (arm64) > +> `= List of [ | - ]` > + > +> Default: `All available colors` > + > +Specify dom0 color configuration. If the parameter is not set, all available > +colors are chosen and the user is warned on Xen's serial console. > + > ### dom0_ioports_disable (x86) > > `= List of -` > > @@ -1631,6 +1639,20 @@ This option is intended for debugging purposes only. Enable MSR_DEBUGCTL.LBR > in hypervisor context to be able to dump the Last Interrupt/Exception To/From > record with other registers. > > +### llc-way-size (arm64) > +> `= ` > + > +> Default: `Obtained from the hardware` > + > +Specify the way size of the Last Level Cache. This parameter is only useful with > +cache coloring support enabled. It is an optional, expert-only parameter and it > +is used to calculate the number of available colors on the platform. It can be > +obtained by dividing the total LLC size by the number of its associative ways. > +By default, the value is automatically computed by probing the hardware, but in > +case of specific needs, it can be manually set. Those include failing probing > +and debugging/testing purposes so that it's possibile to emulate platforms with > +different number of supported colors. > + > ### loglvl > > `= [/]` where level is `none | error | warning | info | debug | all` > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 33e004d702..8acff9682c 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -131,6 +131,22 @@ config ARM64_BTI > Branch Target Identification support. > This feature is not supported in Xen. > > +config CACHE_COLORING > + bool "Last Level Cache (LLC) coloring" if EXPERT > + default n > + depends on ARM_64 > + > +config MAX_CACHE_COLORS > + int "Maximum number of cache colors" > + default 128 > + range 0 65536 Just curious. Why select 128 as default vaule here? Is it a classic implmenntation for Arm64 cache? And the same question for the upper bound 65536. > + depends on CACHE_COLORING > + help > + This config value is an upper bound for the actual number of cache colors > + supported by the architecture. Xen preallocates this amount of cache > + colors at boot. Note that if, at any time, a color configuration with more > + colors than the maximum will be employed an error will be produced. > + > config TEE > bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED > default n > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 4d076b278b..12940ba761 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -67,6 +67,7 @@ obj-$(CONFIG_SBSA_VUART_CONSOLE) += vpl011.o > obj-y += vsmc.o > obj-y += vpsci.o > obj-y += vuart.o > +obj-$(CONFIG_CACHE_COLORING) += coloring.o > > extra-y += xen.lds > > diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c > new file mode 100644 > index 0000000000..c010ebc01b > --- /dev/null > +++ b/xen/arch/arm/coloring.c > @@ -0,0 +1,222 @@ > +/* > + * xen/arch/arm/coloring.c > + * > + * Coloring support for ARM > + * > + * Copyright (C) 2019 Xilinx Inc. > + * > + * Authors: > + * Luca Miccio > + * Carlo Nonato > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > + > +/* Size of a LLC way */ > +static unsigned int llc_way_size; > +/* Number of colors available in the LLC */ > +static unsigned int max_colors; > +/* Mask to retrieve coloring relevant bits */ > +static uint64_t addr_col_mask; > + Maybe above variables can use __ro_after_init? > +#define addr_to_color(addr) (((addr) & addr_col_mask) >> PAGE_SHIFT) > +#define addr_set_color(addr, color) (((addr) & ~addr_col_mask) \ > + | ((color) << PAGE_SHIFT)) > + > +static unsigned int dom0_colors[CONFIG_MAX_CACHE_COLORS]; > +static unsigned int dom0_num_colors; > + > +/* > + * Parse the coloring configuration given in the buf string, following the > + * syntax below. > + * > + * COLOR_CONFIGURATION ::= COLOR | RANGE,...,COLOR | RANGE > + * RANGE ::= COLOR-COLOR > + * > + * Example: "0,2-6,15-16" represents the set of colors: 0,2,3,4,5,6,15,16. > + */ > +static int parse_color_config(const char *buf, unsigned int *colors, > + unsigned int *num_colors) > +{ > + const char *s = buf; > + > + if ( !colors || !num_colors ) > + return -EINVAL; > + > + while ( *s != '\0' ) > + { > + if ( *s != ',' ) > + { > + unsigned int color, start, end; > + > + start = simple_strtoul(s, &s, 0); > + > + if ( *s == '-' ) /* Range */ > + { > + s++; > + end = simple_strtoul(s, &s, 0); > + } > + else /* Single value */ > + end = start; > + > + if ( start > end || > + *num_colors + end - start >= CONFIG_MAX_CACHE_COLORS ) > + return -EINVAL; > + for ( color = start; color <= end; color++ ) > + colors[(*num_colors)++] = color; > + } > + else > + s++; > + } > + > + return *s ? -EINVAL : 0; > +} > + > +size_param("llc-way-size", llc_way_size); > + > +static int __init parse_dom0_colors(const char *s) > +{ > + return parse_color_config(s, dom0_colors, &dom0_num_colors); > +} > +custom_param("dom0-colors", parse_dom0_colors); > + > +/* Return the LLC way size by probing the hardware */ > +static unsigned int get_llc_way_size(void) > +{ > + register_t ccsidr_el1; > + register_t clidr_el1 = READ_SYSREG(CLIDR_EL1); > + register_t csselr_el1 = READ_SYSREG(CSSELR_EL1); > + register_t id_aa64mmfr2_el1 = READ_SYSREG(ID_AA64MMFR2_EL1); > + uint32_t ccsidr_numsets_shift = CCSIDR_NUMSETS_SHIFT; > + uint32_t ccsidr_numsets_mask = CCSIDR_NUMSETS_MASK; > + unsigned int n, line_size, num_sets; > + > + for ( n = CLIDR_CTYPEn_LEVELS; > + n != 0 && !((clidr_el1 >> CLIDR_CTYPEn_SHIFT(n)) & CLIDR_CTYPEn_MASK); > + n-- ); > + > + if ( n == 0 ) > + return 0; > + > + WRITE_SYSREG(((n - 1) & CCSELR_LEVEL_MASK) << CCSELR_LEVEL_SHIFT, > + CSSELR_EL1); > + isb(); > + > + ccsidr_el1 = READ_SYSREG(CCSIDR_EL1); > + > + /* Arm ARM: (Log2(Number of bytes in cache line)) - 4 */ > + line_size = 1 << ((ccsidr_el1 & CCSIDR_LINESIZE_MASK) + 4); > + > + /* If FEAT_CCIDX is enabled, CCSIDR_EL1 has a different bit layout */ > + if ( (id_aa64mmfr2_el1 >> ID_AA64MMFR2_CCIDX_SHIFT) & 0x7 ) > + { > + ccsidr_numsets_shift = CCSIDR_NUMSETS_SHIFT_FEAT_CCIDX; > + ccsidr_numsets_mask = CCSIDR_NUMSETS_MASK_FEAT_CCIDX; > + } > + /* Arm ARM: (Number of sets in cache) - 1 */ > + num_sets = ((ccsidr_el1 >> ccsidr_numsets_shift) & ccsidr_numsets_mask) + 1; > + > + printk(XENLOG_INFO "LLC found: L%u (line size: %u bytes, sets num: %u)\n", > + n, line_size, num_sets); > + > + /* Restore value in CSSELR_EL1 */ > + WRITE_SYSREG(csselr_el1, CSSELR_EL1); > + isb(); > + > + return line_size * num_sets; > +} > + > +static bool check_colors(unsigned int *colors, unsigned int num_colors) > +{ > + int i; Can this one be unsigned int? just as you have done in set_default_domain_colors. > + > + if ( num_colors > max_colors ) > + return false; > + > + for ( i = 0; i < num_colors; i++ ) > + if ( colors[i] >= max_colors ) > + return false; > + > + return true; > +} > + > +static unsigned int set_default_domain_colors(unsigned int *colors) > +{ > + unsigned int i; > + > + if ( !colors ) > + return 0; > + > + for ( i = 0; i < max_colors; i++ ) > + colors[i] = i; > + return max_colors; > +} > + > +static void dump_coloring_info(unsigned char key) > +{ > + printk("'%c' pressed -> dumping coloring general info\n", key); > + printk("LLC way size: %u KiB\n", llc_way_size >> 10); > + printk("Number of LLC colors supported: %u\n", max_colors); > + printk("Address color mask: 0x%lx\n", addr_col_mask); > +} > + > +bool __init coloring_init(void) > +{ > + if ( !llc_way_size && !(llc_way_size = get_llc_way_size()) ) > + { > + printk(XENLOG_ERR > + "Probed LLC way size is 0 and no custom value provided\n"); > + return false; > + } > + > + max_colors = llc_way_size / PAGE_SIZE; > + /* The maximum number of colors must be a power of 2 in order to correctly > + map colors to bits of an address. */ The style of this comment might need to be adjusted. > + ASSERT((max_colors & (max_colors - 1)) == 0); > + addr_col_mask = (max_colors - 1) << PAGE_SHIFT; > + > + if ( !dom0_num_colors ) > + { > + printk(XENLOG_WARNING > + "Dom0 color config not found. Using default (all colors)\n"); > + dom0_num_colors = set_default_domain_colors(dom0_colors); > + } > + > + if ( !check_colors(dom0_colors, dom0_num_colors) ) > + { > + printk(XENLOG_ERR "Bad color config for Dom0\n"); > + return false; > + } > + > + register_keyhandler('K', dump_coloring_info, "dump coloring info", 1); > + > + return true; > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h > new file mode 100644 > index 0000000000..dd7eff5f07 > --- /dev/null > +++ b/xen/arch/arm/include/asm/coloring.h > @@ -0,0 +1,31 @@ > +/* > + * xen/arm/include/asm/coloring.h > + * > + * Coloring support for ARM > + * > + * Copyright (C) 2019 Xilinx Inc. > + * > + * Authors: > + * Luca Miccio > + * Carlo Nonato > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > +#ifndef __ASM_ARM_COLORING_H__ > +#define __ASM_ARM_COLORING_H__ > + > +#include > + > +bool __init coloring_init(void); > + > +#endif /* !__ASM_ARM_COLORING_H__ */ > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h > index 1dd81d7d52..85ff0caf1e 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -18,6 +18,22 @@ > #define CTR_IDC_SHIFT 28 > #define CTR_DIC_SHIFT 29 > > +/* CCSIDR Current Cache Size ID Register */ > +#define CCSIDR_LINESIZE_MASK 0x7 > +#define CCSIDR_NUMSETS_SHIFT 13 > +#define CCSIDR_NUMSETS_MASK 0x3FFF > +#define CCSIDR_NUMSETS_SHIFT_FEAT_CCIDX 32 > +#define CCSIDR_NUMSETS_MASK_FEAT_CCIDX 0xFFFFFF > + > +/* CCSELR Cache Size Selection Register */ > +#define CCSELR_LEVEL_MASK 0x7 > +#define CCSELR_LEVEL_SHIFT 1 > + > +/* CLIDR Cache Level ID Register */ > +#define CLIDR_CTYPEn_SHIFT(n) (3 * (n - 1)) > +#define CLIDR_CTYPEn_MASK 0x7 > +#define CLIDR_CTYPEn_LEVELS 7 > + > #define ICACHE_POLICY_VPIPT 0 > #define ICACHE_POLICY_AIVIVT 1 > #define ICACHE_POLICY_VIPT 2 > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 500307edc0..c02f21c0e6 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -53,6 +53,9 @@ > #include > #include > #include > +#ifdef CONFIG_CACHE_COLORING > +#include > +#endif > > struct bootinfo __initdata bootinfo; > > @@ -930,6 +933,11 @@ void __init start_xen(unsigned long boot_phys_offset, > printk("Command line: %s\n", cmdline); > cmdline_parse(cmdline); > > +#ifdef CONFIG_CACHE_COLORING > + if ( !coloring_init() ) > + panic("Xen Coloring support: setup failed\n"); > +#endif > + > setup_mm(); > > /* Parse the ACPI tables for possible boot-time configuration */ From xen-devel-bounces@lists.xenproject.org Mon Sep 26 06:39:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 06:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411400.654309 (Exim 4.92) (envelope-from ) id 1ochm7-0004ib-2H; Mon, 26 Sep 2022 06:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411400.654309; Mon, 26 Sep 2022 06:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ochm6-0004iU-Vq; Mon, 26 Sep 2022 06:39:30 +0000 Received: by outflank-mailman (input) for mailman id 411400; Mon, 26 Sep 2022 06:39:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ochm5-0004iO-Qp for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 06:39:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f76de1b4-3d65-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 08:39:28 +0200 (CEST) Received: from AM6P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::37) by GV1PR08MB8129.eurprd08.prod.outlook.com (2603:10a6:150:93::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 06:39:22 +0000 Received: from AM7EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::fa) by AM6P194CA0024.outlook.office365.com (2603:10a6:209:90::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 06:39:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT054.mail.protection.outlook.com (100.127.140.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 06:39:22 +0000 Received: ("Tessian outbound 88978e6d60db:v124"); Mon, 26 Sep 2022 06:39:22 +0000 Received: from ebe73f583f05.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8E7DAF9E-6226-449D-A9CE-99D1814166E6.1; Mon, 26 Sep 2022 06:39:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ebe73f583f05.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 06:39:15 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV2PR08MB8701.eurprd08.prod.outlook.com (2603:10a6:150:b9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 06:39:13 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::f997:4dac:eff8:93d6]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::f997:4dac:eff8:93d6%4]) with mapi id 15.20.5654.024; Mon, 26 Sep 2022 06:39:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f76de1b4-3d65-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IlHR22JijCCRq72yn3HyRwbEjE+5FOMTXOwOIb8NXnmurPnG6zfMfnZGP78IcLZC+vpB/z3/a4d3vV8/oijFMFTVQvAP/130OA9hOnZCuDLhQ6QB+vXykJ6uiMI+WY0BFiwaJk6hOa98EnbDM/FJJrTvjtGfHYaOjZLGdjZCgP6b4IIEK9ejn1fUtz5Hlk+rVrVOEENlWjFGG6cRrEJAJE5Us5qbILZ6bYmMPONcdSTRxKOezF+xnjWcVpGqITz2+uZWUDC8RXM83UIpeC7Hh6c5HLU+HD9t0pvSBdcEi9NUnkup0OPvqnjaZx0i7fOTtEcEU1imNEpade1dyHDmuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BfiWPa+UevVocIUkK0nyGiHTHbfQeqneBMuaFytqSLY=; b=MVscca1HlomSRR8Ej6kehgXwNrin10bN6RneXSDZ1loU4sYoOmQ1TLRtODxv8C6eiYGUJpTiFqIXGGcFxIgoetFlA1Wv8VrcDHcWFqvwW+qL31+ys5samq96+fMstaVoLcpgC1GSyXp2Nx2lxcrWeLzWDweI6hAGNs3tY/hOh9lrJymtfz5KHRQWAgqpUlu+r5zsjXBsH+XmIJLqog0RGkkZS1crdb16MOA3NUDldAVQIGHQ+v6OIwp7pu8HCnyrY1dnQ2PFC2Bi0JZdh3yXStMkw7fC/xPaj5Kq0f6AMHRKbuevARPTH4DQlyUSrzE7Jy+FNJW7O8nwfYfyQ8auOQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BfiWPa+UevVocIUkK0nyGiHTHbfQeqneBMuaFytqSLY=; b=rI6do98pwQBoNNiMZSqi44vnRwh27jja4PEfQGySSKyHogfy2pSXnAishl9luSNUg0e3fLR1Zr1KhLI1Oo269NhHR3vFWobU29x9F6cisrJ8cnLAim8fPA1YKZkLqPvNW/tuzc45eiYgHWyEtrqEajKIQGuNot/KM4o4uVW/bz4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c1647a4f588a136d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZt0uxV+FV1KjgIzs9ZM+xmSFUu/qR7QHLfFmkNoC/WRAOZ/Pwr75MC2/cg/oltVatG5luMqNxvSsOKN6KUiDfaLXndCB1eVPHsNl9vyZKV9xIhuVZevEn071opdGA4RlAnQ+LzcTUQkcChD3jpKTo1xZbhBW990sg4VokicSU5kQ/Wdzj3t/7sO0/kJS4/onGwceTsdd97GNDpzRIQf/clJRp7zK3J2MkAAUxNrBKDh6wZt4VNJ5gv37AaeyVP2WjDgwTVa9DnvGAuEFrTpvah9py66ev9jc6HZRVAp9b5DADZSVvGZcFnRaJZm/zITRTDW4T6xFmC+APyPjwUrPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BfiWPa+UevVocIUkK0nyGiHTHbfQeqneBMuaFytqSLY=; b=bFvKCKWelGj/3DHLQCu/qGlm08afueT9oXsa8t+0bV/wyGazgY9bm3n/J35ZPwsoogvJ/phwZlGaFMN029keF0lD3EeQ7iVPrhycfwL2pC25eETbLE4PN54rjF+sdFGbBFbr9zqSCRAxsUXyfQ9PuU1m56imCIJujFHDOW1dWPz1sUnY0yyCCPHenY7hASf+NCbYQzzuBZXbwNeiriOrcu+4VZ10U9PblpRmKkHl8mW2WDYxKuuwJ6/RlX6N/UEK2IAMwZPTowOVQpXNmQo8ZWC5a9tBUzGv71YrpJVWaoUN8UnMr+w2TGGxzxFLSY0fHwtUgR2GNpuGQQYqF+Z+8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BfiWPa+UevVocIUkK0nyGiHTHbfQeqneBMuaFytqSLY=; b=rI6do98pwQBoNNiMZSqi44vnRwh27jja4PEfQGySSKyHogfy2pSXnAishl9luSNUg0e3fLR1Zr1KhLI1Oo269NhHR3vFWobU29x9F6cisrJ8cnLAim8fPA1YKZkLqPvNW/tuzc45eiYgHWyEtrqEajKIQGuNot/KM4o4uVW/bz4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Mon, 26 Sep 2022 14:39:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains Content-Language: en-US To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-3-carlo.nonato@minervasys.tech> From: Wei Chen In-Reply-To: <20220826125111.152261-3-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0035.apcprd02.prod.outlook.com (2603:1096:3:18::23) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|GV2PR08MB8701:EE_|AM7EUR03FT054:EE_|GV1PR08MB8129:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f401ba9-a4ae-4e00-a8da-08da9f89d8dd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lN5MtFcbLJe9CeX0T2N75CrAd2eh2IBj+7EUE/1XlU6l39c+kRyTA5+3bxZpgBZ6HDALqo/dYIZzb5t8His4ocSPUllvl5JhQg1ocrqB8dmREDnWMQT5NYKM32e347XzyQ/ZNjNCFVHkg06iTRiYhPGtrVhsKUQdZXXVYljrC/e2yv1D23GfemKOzyK6OSGz4tHHImwtq6qWrjEIxHdpzvE6IS8UqW7FHNl1leQn3qOdvGWai8q/21URbfn2lf1yBuz5zTE0ZLeUuN1GW7WCMBk72TW3u0TylkP3d1hDKJpA2Exq3xg94LozwQdUC/vH8ywIEWbUIxy3tMJc3PcN0invhZ6QDbCbZwCFEOoYji2nNG+au/AfqWHT3sL4NVrc3P+MMdrPMffFex6/lxtm/72TAFOQX7yaegvnShyGZkPwsGBpAgAJhK0vKpZPgenTWutyLOZqR+24AGh7H5dGQ+buzNVoALmbAczADWduCVR2P0oBuF4PGwsndIhPAlYj5zal70v+9evCve+LNLavW66M+lW4son0iPjC2VEGhmMcbRfGa0fbERT3IJsv2sp70kqK5dPAR+/287xLrB8Njz957dxNMl9LwbjbVaoMaZ1+jN9sjZRtd9JCbRZMvScN/lvrA2hgrZUEEN/+2iY8fcgABmvCdPKsk7mOarv+XP782VfMG44hASg8QVexdnaOJHf2cFMaLHCid//cBDWdlpgBYfZKZxTey8vCxyJmOJXSXlTuI9526+dNh7R4sKBZjutUtnIcBilfDmTzU5DFKoovzJ73WovHTHeAjWjvBk/afrYvio61qu52MK+trFJ7 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199015)(186003)(2616005)(7416002)(5660300002)(8936002)(6486002)(31696002)(8676002)(66946007)(4326008)(66556008)(38100700002)(66476007)(316002)(6506007)(41300700001)(2906002)(86362001)(26005)(6512007)(53546011)(36756003)(31686004)(6666004)(83380400001)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8701 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05a16cce-7f62-4dd7-8bde-08da9f89d2f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e0XLhzxZrg2n0nm5jq3V13abk/1RWnBivQF0bNi1eyJemHFry866XWEXmyh4PmovgKP7D/In5wCq9bXnb6mCFzCY9Rv58RApxujupr9NWQ+TSZElGyMIpr4WIFrn+DtLAmTcmUrken8DZVjTie+PhpcwXPoHGhowAlif6kf8IGnRaER/5VL5fl/uRGxJrR8wO8OyI4PAm8lqYvCA86LJv9cG983I0RQ1q98IfJM7s+hkYqDKbPdI//rc2QVpynbjBmfscLVgWFw8Xt5jNI8coaIBnbrIHa543vxZuP6ee3fc9XqAsljjJKE/JgZBhWOss28NIMxOOo5p97S2pds1LhnyMhfsv203n+y3us9k6D7vf8YcJ3+78ONFr5cQ67H0TqQyVL+NneghnB/6B90hltAOcRG7CgoQNT9U8k4eKo++UlxYjH+Diph3r1UpOdqYyKJl7J8ttReMFKLvubISqO0wddpTLbcANm2HJnPFVN6DtDSJLTqZtPwfOERjguAurv1518oEGtNXCX5TaZMm+cvAwWVie3jMh3/laJUgF/fOXN20uYHghBGXU+VwOOwKxvLeW0xO26MaOPYRT/qj4VK0XLewANxZFtWC4bc4n6Vqt9Lt0Hn/OhexAj/dcz0gLwdgxa/MPZX1RvRirxaes+o+mlmcNBsudO2Lx+ME5wGtvCMdqNawypdN3Hv7EFl2XBi0WIEIoUi3tjnM4yYd8nJyLUImW2vbfUjyLph0UidYg50IUgCXIWaTk12WGuG5H53ZpuwZ+cC/Odm/IGBnH++rwPD6fPTO+KJQ16JjKdUnuc4IJKy4a0OiWCC8oAy5oBdNnqHYSAvUKMGdeuutbg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(83380400001)(31686004)(31696002)(86362001)(356005)(36756003)(40460700003)(81166007)(82740400003)(4326008)(8676002)(70206006)(70586007)(2906002)(6512007)(8936002)(5660300002)(40480700001)(6506007)(47076005)(316002)(36860700001)(2616005)(186003)(336012)(26005)(53546011)(6486002)(478600001)(41300700001)(107886003)(6666004)(82310400005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 06:39:22.3306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f401ba9-a4ae-4e00-a8da-08da9f89d8dd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8129 On 2022/8/26 20:51, Carlo Nonato wrote: > This commit adds array pointers to domains as well as to the hypercall > and configuration structure employed in domain creation. The latter is used > both by the toolstack and by Xen itself to pass configuration data to the > domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be > able to access guest memory in the first case. This implies special care for > the copy of the configuration data into the domain data, meaning that a > discrimination variable for the two possible code paths (coming from Xen or > from the toolstack) is needed. > > The initialization and free functions for colored domains are also added. > The former is responsible for allocating and populating the color array > of the domain and it also checks for configuration issues. One of those > issues is enabling both coloring and directmap for the domain because they > contradicts one another. Since that, Dom0 must not be created with the > directmap flag. > The latter instead frees allocated memory. > > Signed-off-by: Carlo Nonato > Signed-off-by: Marco Solieri > --- > docs/misc/arm/cache-coloring.rst | 7 ++-- > xen/arch/arm/coloring.c | 56 +++++++++++++++++++++++++++++ > xen/arch/arm/domain.c | 11 ++++++ > xen/arch/arm/domain_build.c | 13 +++++-- > xen/arch/arm/include/asm/coloring.h | 7 ++++ > xen/arch/arm/include/asm/domain.h | 4 +++ > xen/include/public/arch-arm.h | 8 +++++ > 7 files changed, 102 insertions(+), 4 deletions(-) > > diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst > index c7adcb0f1f..345d97cb56 100644 > --- a/docs/misc/arm/cache-coloring.rst > +++ b/docs/misc/arm/cache-coloring.rst > @@ -13,7 +13,7 @@ In order to enable and use it, few steps are needed. > (refer to menuconfig help for value meaning and when it should be changed). > > CONFIG_MAX_CACHE_COLORS= > -- Assign colors to Dom0 using the `Color selection format`_ (see > +- Assign colors to domains using the `Color selection format`_ (see > `Coloring parameters`_ for more documentation pointers). > > Background > @@ -109,4 +109,7 @@ Coloring parameters > > LLC way size (as previously discussed) and Dom0 colors can be set using the > appropriate command line parameters. See the relevant documentation in > -"docs/misc/xen-command-line.pandoc". > \ No newline at end of file > +"docs/misc/xen-command-line.pandoc". > + > +Note that if no color configuration is provided for domains, they fallback to > +the default one, which corresponds simply to all available colors. > \ No newline at end of file > diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c > index c010ebc01b..2b37cda067 100644 > --- a/xen/arch/arm/coloring.c > +++ b/xen/arch/arm/coloring.c > @@ -22,6 +22,7 @@ > * along with this program. If not, see . > */ > #include > +#include > #include > #include > #include > @@ -211,6 +212,61 @@ bool __init coloring_init(void) > return true; > } > > +int domain_coloring_init(struct domain *d, > + const struct xen_arch_domainconfig *config) > +{ > + if ( is_domain_direct_mapped(d) ) > + { > + printk(XENLOG_ERR > + "Can't enable coloring and directmap at the same time for %pd\n", > + d); > + return -EINVAL; > + } > + > + if ( is_hardware_domain(d) ) > + { > + d->arch.colors = dom0_colors; > + d->arch.num_colors = dom0_num_colors; > + } > + else if ( config->num_colors == 0 ) > + { > + printk(XENLOG_WARNING > + "Color config not found for %pd. Using default\n", d); > + d->arch.colors = xzalloc_array(unsigned int, max_colors); > + d->arch.num_colors = set_default_domain_colors(d->arch.colors); > + } > + else > + { > + d->arch.colors = xzalloc_array(unsigned int, config->num_colors); > + d->arch.num_colors = config->num_colors; > + if ( config->from_guest ) > + copy_from_guest(d->arch.colors, config->colors, config->num_colors); > + else > + memcpy(d->arch.colors, config->colors.p, > + sizeof(unsigned int) * config->num_colors); > + } > + > + if ( !d->arch.colors ) > + { > + printk(XENLOG_ERR "Colors allocation failed for %pd\n", d); > + return -ENOMEM; > + } > + > + if ( !check_colors(d->arch.colors, d->arch.num_colors) ) > + { If we add xfree(d->arch.colors) here for non-hw domains, is it possible to make this function have a complete fallback process? And I know currently, this is handled in domain_coloring_free. Cheers, Wei Chen > + printk(XENLOG_ERR "Bad color config for %pd\n", d); > + return -EINVAL; > + } > + > + return 0; > +} > + > +void domain_coloring_free(struct domain *d) > +{ > + if ( !is_hardware_domain(d) ) > + xfree(d->arch.colors); > +} > + > /* > * Local variables: > * mode: C > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 2d6253181a..c6fa8adc99 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -23,6 +23,9 @@ > #include > > #include > +#ifdef CONFIG_CACHE_COLORING > +#include > +#endif > #include > #include > #include > @@ -712,6 +715,11 @@ int arch_domain_create(struct domain *d, > ioreq_domain_init(d); > #endif > > +#ifdef CONFIG_CACHE_COLORING > + if ( (rc = domain_coloring_init(d, &config->arch)) ) > + goto fail; > +#endif > + > /* p2m_init relies on some value initialized by the IOMMU subsystem */ > if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) > goto fail; > @@ -807,6 +815,9 @@ void arch_domain_destroy(struct domain *d) > get_order_from_bytes(d->arch.efi_acpi_len)); > #endif > domain_io_free(d); > +#ifdef CONFIG_CACHE_COLORING > + domain_coloring_free(d); > +#endif > } > > void arch_domain_shutdown(struct domain *d) > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..4d4cb692fc 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -33,6 +33,12 @@ > #include > #include > > +#ifdef CONFIG_CACHE_COLORING > +#define XEN_DOM0_CREATE_FLAGS CDF_privileged > +#else > +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap > +#endif > + > static unsigned int __initdata opt_dom0_max_vcpus; > integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); > > @@ -3399,7 +3405,10 @@ static int __init construct_dom0(struct domain *d) > /* type must be set before allocate_memory */ > d->arch.type = kinfo.type; > #endif > - allocate_memory_11(d, &kinfo); > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > + allocate_memory(d, &kinfo); > + else > + allocate_memory_11(d, &kinfo); > find_gnttab_region(d, &kinfo); > > /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ > @@ -3455,7 +3464,7 @@ void __init create_dom0(void) > if ( iommu_enabled ) > dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > > - dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap); > + dom0 = domain_create(0, &dom0_cfg, XEN_DOM0_CREATE_FLAGS); > if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) > panic("Error creating domain 0\n"); > > diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h > index dd7eff5f07..60c8b1f079 100644 > --- a/xen/arch/arm/include/asm/coloring.h > +++ b/xen/arch/arm/include/asm/coloring.h > @@ -25,7 +25,14 @@ > #define __ASM_ARM_COLORING_H__ > > #include > +#include > + > +#include > > bool __init coloring_init(void); > > +int domain_coloring_init(struct domain *d, > + const struct xen_arch_domainconfig *config); > +void domain_coloring_free(struct domain *d); > + > #endif /* !__ASM_ARM_COLORING_H__ */ > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > index 26a8348eed..291f7c375d 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -58,6 +58,10 @@ struct arch_domain > #ifdef CONFIG_ARM_64 > enum domain_type type; > #endif > +#ifdef CONFIG_CACHE_COLORING > + unsigned int *colors; > + unsigned int num_colors; > +#endif > > /* Virtual MMU */ > struct p2m_domain p2m; > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index c8b6058d3a..adf843a7a1 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > #define XEN_DOMCTL_CONFIG_TEE_NONE 0 > #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 > > +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int); > + > struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > @@ -335,6 +337,12 @@ struct xen_arch_domainconfig { > * > */ > uint32_t clock_frequency; > + /* IN */ > + uint8_t from_guest; > + /* IN */ > + uint16_t num_colors; > + /* IN */ > + XEN_GUEST_HANDLE(color_t) colors; > }; > #endif /* __XEN__ || __XEN_TOOLS__ */ > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 06:57:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 06:57:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411406.654319 (Exim 4.92) (envelope-from ) id 1oci3s-000779-Hz; Mon, 26 Sep 2022 06:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411406.654319; Mon, 26 Sep 2022 06:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oci3s-000772-FN; Mon, 26 Sep 2022 06:57:52 +0000 Received: by outflank-mailman (input) for mailman id 411406; Mon, 26 Sep 2022 06:57:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oci3r-00076t-2s for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 06:57:51 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80083.outbound.protection.outlook.com [40.107.8.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8809c7a4-3d68-11ed-9647-05401a9f4f97; Mon, 26 Sep 2022 08:57:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9146.eurprd04.prod.outlook.com (2603:10a6:10:2f5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.23; Mon, 26 Sep 2022 06:57:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 06:57:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8809c7a4-3d68-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G8fmdhMt2L0YZw6zGSbUjkQRww9mRPljTjg1KkVWtczugbI3+Hl5yW3apeFJsMR+rA8juzvoHd/JVR5kZ9wrdEkvxDwFW2ZnQzH/8P66ZBDdlWNXWWh3wJYsLGHmk07DgeVYnQD9wBVNE9huEOgyDa2mQ/s1dIkqfvb2f7mcyn/relsXhaO+zzuejzm+S5mKQxufuSHW8VmKTfJ59pZq2+USFXLg/XU/udI0Hdpz1X1nYXVqP0Z5mCaYENsT1vVD0ezCo0gTsIivAPJTcutMgpeaP7ZXTB/c5eYI2aeROROQT3WI158zXaQmWFX7bOPLLh4H02mno2BlMmclNCdkjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYf2tP+ZpnmF19YH10EKsbxLjZfVuIssD9txRvQgDGM=; b=LWE3CVzyxikx9iexD6moF8DuZyH5HMRkA5i2VB1IJHUI4pTbo7qknFLZG/M54HWXIWDCbQr8xNRT+nOZp4mwuL3Is+m/ylYQVzPgbak7QWpvUGAXnvUYPfo9puqooBTm/dr0Uanpqfus1ER2L1lSmori4bY9mMJW4iTC3UlPOGEpw5Ue8LdXOjN7ywyHQaBtX55SizGrZ+KLX0wAslvyHCHRu7gEA/i2s+TQZN1m3mO4ucGgDJE3TkYe5R7FiNTca+GRgXjuaph3J6Fx3MoRnvmDcX3yW6hme2vKDDRkVs8rUgo8lXQMLetUYlzGoHEbJi5mG2o+4V5E7fytjEEiUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYf2tP+ZpnmF19YH10EKsbxLjZfVuIssD9txRvQgDGM=; b=NgT0qHVKv8j5qfgqlJgFRri04smUA0eUmCsG3Trp3+obeEYKJqlsrBUDIZwBWRUcxa3IMzebvKRFje7hC2mdTzmD945OP/e7+IltZ6iSPSCE/lPKn2aFV8TIDMGrXv/1ngpQ8IE7enZH34yaYC5feXRhvnt2nwJpGsWI72jXhu6umiO5P4cJggFVHRZDTJTJ5vwY90ElfQUMGp8wD1JIPn6mcc0oeCUedJoIMXz+Rq6zlmXmB6KOovmNE8sdGm51uBdlY/6+Yjz38QGpf7/H/Iq2oY8D2r+roEHFme1aHXlB+XeVGCl7+EX/fSLgVtANJ2bCs7umPCqGZ2uBkfAkLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> Date: Mon, 26 Sep 2022 08:57:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session "grant v3" To: Juergen Gross Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9146:EE_ X-MS-Office365-Filtering-Correlation-Id: aa76a2f2-17c5-4a85-7b53-08da9f8c6a94 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4UU4lfxg8It3QM6xUsmJxt7p+FOBBPZh59B9uuv4n3t3hxTV1h19zN2nwTkMq1YnZjbKcnYJwWs5XxynaNPAQTcA1JNyWW+FoJVock1O5Xi9+SOn4heXrIDPp7RSLUJQnp/DoTaqxv3Xay0GgsCHRYjScMnjOAv+jlbp3rp7r9YZY+qG1ZHSPMlU0jYorLKJ/8ivY7spFy4e0JIobjXpcL7zWjzWbG09dGRv5zsFKNcZatjxgYmuGDQbAQvw13peQcuKKTTA4Azaa8FQ+s9XD9m5LBy97n5EZMUp2iSPY6idHMbn0EV54KawIo+FLC6Uer/MPVDB/tvD0Uyihk3u9mE5eMKhWyUJWD7OcxGn6WlmxQO1JmojwFwIu802+YRpYjDuRIUsljKTjRpPOR+pAH0ZbTsx7Ba9CoTeAHQhdjRer+ICnHehpfuk2+l/ujiG+4ufQpEfUuJ/UvZ8LiETNbIh/Anww8zcnFuLkNJWpOWaCe0TvTuCnQQ1d4Xe3BfIM8dljG0ydKrewyfoJve4333OrzSyvj4JhXE2t8Agzi9Lt1Umvk9WeFtF+N1IXxhPoxCYSknvOcAxQIJFvt9/sYAyYd0nYSraSl6gVRibqHAIkFk/QskpPFJZ9DmxQUKFKSG1eSM8cBSA9JQ6wGOU0joXuUdEmXNC+9PmTBjcytJZAX3GrW83IeMIOMIRSneRnuOGCUYceSTPZUdFAINnht4Eq4cj3StOYAnjzgTJ+mLNQUyxSu4QdwcI/23Td4tsjPobP2I0o5ZyOVxFhREciwlEmHeU/Nb9acOQhRGhaFw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199015)(83380400001)(66574015)(186003)(38100700002)(36756003)(86362001)(31696002)(66556008)(316002)(66476007)(66946007)(31686004)(41300700001)(478600001)(6486002)(54906003)(6636002)(37006003)(26005)(8936002)(6512007)(6862004)(6506007)(53546011)(2616005)(2906002)(5660300002)(6666004)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2dILzFkckFheGFpSlMycDVOYmhJcnNkeWg1Q2g3NVFtdnFMZ3A3K0Nxc2xW?= =?utf-8?B?elBEQWhoMUxyYkdLNitBSnRoMjZqemIyaGc2U0I3cU12LzIvSVZGeFc5QzBt?= =?utf-8?B?RDY2bEh2a05EUTBodFErMHhjb3RJbHFkcGEraUU2cVV4UWJ1bVVBdkpod0FK?= =?utf-8?B?WHpxSmVPWWo1Mm5sYVdCNXVlWkNBNWtCeXhocldpMS9FMy8zMTB6dVE2OFhU?= =?utf-8?B?NWxoUS9wV0gzUW1aNlVVWUhlRjZSa25xMm9FS2M3SkQ3dW1iZ1JzUXZjTTkr?= =?utf-8?B?T1l3NEQ2c3VkQ3BmYzlTb0Y3TmlhakJObERqQThZWW5qNVcvZU5xamFSeUZC?= =?utf-8?B?czlJMHJMRjNLclFHTG1LeWFaRXAvYXoxVWZLTnNTbEJyVnk3Y3NubndFaXNp?= =?utf-8?B?c0dDKy81VDA5NnlpL2NKQlBvU3RoS1BUMEE1T3Z1QWJUZllKbStjUm13ZlMw?= =?utf-8?B?NDRnaHRMNFFBMjR0K3MzTGtmRFRsSVFzQjBrdlFLZ3ViMlF3akgvN2xSekhM?= =?utf-8?B?OGo2Yko0Y05FZndoRnh0V2IzQm1iQ1YvWi9tcEU2S0Yra01JRmNRNEF3cFBD?= =?utf-8?B?b2tRVEJ0MlFRZ0VuOHI5NG80THhLUlFXMnhrQWRqdHIva1dvemhMZ0hZYWpp?= =?utf-8?B?MkgvNXNKZjJhb2tvYlBOajlleTBUM1hmWU96bzNQOVczMFBpK1dMTUpDVGtv?= =?utf-8?B?SGk2cTJMTXZZQWxnNEtrS1RRbDhJdzM2cDhlMlVWS1BJdEZTSE01MWhESDNO?= =?utf-8?B?b2tubmdCYTBkVVJOT0VLT1pOQXM2SmU4NkM5TEN0eWVHZzZMY1pJUnNZLzYx?= =?utf-8?B?VHZ5UTN6bS9rRW5DMU1Cc2dncTk5czJZTWhsRFpYU2lscjlXL3dkdW1XTnpp?= =?utf-8?B?Y1I0MjBBS1hBd0RFU1NLQUpLM2gvSjcrZkVueWhhZ0dvd21xYUhBRlpXbk4z?= =?utf-8?B?VUY3dGgyZnNsRGErdUV4U1RHaTF6Y1grZzNvWE9sS3FQS08xL2l0L29TNjJu?= =?utf-8?B?ZDBSZG4wUWhiUGNWcUNnS1VnZnRaN1ppeUJUemoxTi81RU5GOVZ0ajBUdHpR?= =?utf-8?B?TGN2d3Z3SEpsQXBJekR2OTVjR0dCWVRoTXZ1MHZENjhzUlg4RjU2N25qYTBZ?= =?utf-8?B?YTBTaWt1N1JIVFZHMThkWGhTeXNLeVZ2ejB3clZrd2phUHVOcGlmM0Qxdjk2?= =?utf-8?B?M2ZVQy9GcVo0aE1uZlRtUmJqNHRNaXh4elpBbnYya1RsOHNDTHY2RGFxaHNn?= =?utf-8?B?ZUdCbUN2Qk5wV0hwY2pDMTk3R3RrUlg3YWEvOUNsdTlQeFpFSEdtNnV3bnJR?= =?utf-8?B?eUM2SlcrTzR4Yk45aVJ1Y2poWG1BekFiMW1pTm8xTGtTNnBoUk1HbnErV2tR?= =?utf-8?B?b1lqNkF6c0NUVmF4SHAyWlVRazdscGR1d0xUNkVVNXdGSUhtNGVjN3hGcWZT?= =?utf-8?B?bUpTZXlqc1BaTjlHb1hUcmZGMVhIb0lVc0JhaWF1eFVBTDMyWHh2Zm5SVkNm?= =?utf-8?B?ZkorMjRxWHZPcGZVM1prOHNHSzNwcVZQT0FRT0REQkZJa3o2eGhzZFRrQkkr?= =?utf-8?B?aU0wdURVcml2bEhBc3VCM0VmYytFRFlyYTBRejlFdmVxL3ZIWVV5T1Rmc0x4?= =?utf-8?B?TXRuNHVRRk9nMm9PaE9hUEVoVEVsTU9pQTJKQnpIcjFIeHJnOUlqeWVRNFNP?= =?utf-8?B?RGIybUlpbTE1OFJKV1VybVB5SDdRZkpWZUtBbjBSRGVyTDlCdUZraThQTHZV?= =?utf-8?B?OGp0SzVqQXF1YiszZW4zdUlhUzExMlYzTllod0lYek5SdnE3WElEUE0rL3E3?= =?utf-8?B?WE5oRStrVHFVVGczSGx4UklkM1QvRmlEa0l4QXlzekNycTVsN0VNSU9icHZT?= =?utf-8?B?Uk1WeHRYMnEwbmtadDQ4cTdLckJtb0pxNngxbXVIVlp0cThsdTRCNFNwSlZk?= =?utf-8?B?NE5CR0krWTFCUTZud3RXUGxSSWdlbFdDMW5hdE9JdUdZUlMwK0VieGE1V1hR?= =?utf-8?B?U1lkb2RTeXd4amJiV0pQY1hMY0tNYmFETS9NOWNwdGhaL1o2THd5Z3FjYTZk?= =?utf-8?B?RkdPVEZIVk9pV3oxOTdZQ3p6V2NZVmVxcE1Gb0R1MnZId25rSWVRVmxxd0p5?= =?utf-8?Q?YPl//eS1jRL3euw5dLDbhybb/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa76a2f2-17c5-4a85-7b53-08da9f8c6a94 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 06:57:46.0106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CSDBOZb1HO3Wz7jhsqDamjE3W4yXKbtdCtHYjXQDR6045UjxfFXyMNxZY8rJE8lwJ1I5HeXgmOF7543of8F5aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9146 On 23.09.2022 11:31, Juergen Gross wrote: > On 22.09.22 20:43, Jan Beulich wrote: >> On 22.09.2022 15:42, Marek Marczykowski-Górecki wrote: >>> Yann: can backend refuse revoking? >>> Jürgen: it shouldn't be this way, but revoke could be controlled by feature flag; revoke could pass scratch page per revoke call (more flexible control) >> >> A single scratch page comes with the risk of data corruption, as all >> I/O would be directed there. A sink page (for memory writes) would >> likely be okay, but device writes (memory reads) can't be done from >> a surrogate page. > > I don't see that problem. > > In case the grant is revoked due to a malicious/buggy backend, you can't > trust the I/O data anyway. I agree for the malicious case, but I'm less certain when is come to buggy backends. Some bugs (like not unmapping a grant) aren't putting the data at risk. >>> Jürgen: we should consider interface to mapping large pages ("map this area as a large page if backend shared it as large page") >> >> s/backend/frontend/ I guess? > > Yes. > > But large pages have another downside: The backend needs to know it is a large > page, otherwise it might get confused. So while this sounds like a nice idea, it > is cumbersome in practice. But maybe someone is coming up with a nice idea how > to solve that. Couldn't that simply be a new GTF_superpage flag, with the size encoded along the lines of AMD IOMMUs encode superpages (setting all but the top-most of the bits not used for the actual frame address) in the address part of the entry? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 07:04:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 07:04:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411414.654331 (Exim 4.92) (envelope-from ) id 1ociAi-0000DW-Cl; Mon, 26 Sep 2022 07:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411414.654331; Mon, 26 Sep 2022 07:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ociAi-0000DP-9W; Mon, 26 Sep 2022 07:04:56 +0000 Received: by outflank-mailman (input) for mailman id 411414; Mon, 26 Sep 2022 07:04:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ociAh-0000DJ-AL for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 07:04:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 856363f8-3d69-11ed-9647-05401a9f4f97; Mon, 26 Sep 2022 09:04:54 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 582B721FDF; Mon, 26 Sep 2022 07:04:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3885E139BD; Mon, 26 Sep 2022 07:04:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dWknDBVPMWPFLgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 07:04:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 856363f8-3d69-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664175893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=383tKbIORzI1H9zfDGWRtd+RfgH59qGXSaCnMCQVsig=; b=HW1FmQtjfNh1AKXFUPC4XCg+i0x9ipItddYrBDAOKF94ukMIWCFmpYO4QM6Hxr+TJQ6nWL 6w7jnmVLnpbBUwCuNDSN65HQL1nJ6Cu1BtVdzvU2F6QX5ryT1A6ZFax9CG3zNpRUKeZFbC wkJfSwOKHZMvxoqYMe5KQkGnYFlA+Os= Message-ID: <12ef0abb-2158-faf7-76d7-61e165060d0c@suse.com> Date: Mon, 26 Sep 2022 09:04:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> From: Juergen Gross Subject: Re: Design session "grant v3" In-Reply-To: <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PfxmkzBrU7vcsAkgFckMCu8H" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PfxmkzBrU7vcsAkgFckMCu8H Content-Type: multipart/mixed; boundary="------------AFg0d5zVGksTmmsatDsYIh67"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: <12ef0abb-2158-faf7-76d7-61e165060d0c@suse.com> Subject: Re: Design session "grant v3" References: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> In-Reply-To: <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> --------------AFg0d5zVGksTmmsatDsYIh67 Content-Type: multipart/mixed; boundary="------------r7sMqSS8ZqNi1Ty98nvfm00l" --------------r7sMqSS8ZqNi1Ty98nvfm00l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMDg6NTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMy4wOS4yMDIy IDExOjMxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjIuMDkuMjIgMjA6NDMsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIyLjA5LjIwMjIgMTU6NDIsIE1hcmVrIE1hcmN6 eWtvd3NraS1Hw7NyZWNraSB3cm90ZToNCj4+Pj4gWWFubjogICBjYW4gYmFja2VuZCByZWZ1 c2UgcmV2b2tpbmc/DQo+Pj4+IErDvHJnZW46IGl0IHNob3VsZG4ndCBiZSB0aGlzIHdheSwg YnV0IHJldm9rZSBjb3VsZCBiZSBjb250cm9sbGVkIGJ5IGZlYXR1cmUgZmxhZzsgcmV2b2tl IGNvdWxkIHBhc3Mgc2NyYXRjaCBwYWdlIHBlciByZXZva2UgY2FsbCAobW9yZSBmbGV4aWJs ZSBjb250cm9sKQ0KPj4+DQo+Pj4gQSBzaW5nbGUgc2NyYXRjaCBwYWdlIGNvbWVzIHdpdGgg dGhlIHJpc2sgb2YgZGF0YSBjb3JydXB0aW9uLCBhcyBhbGwNCj4+PiBJL08gd291bGQgYmUg ZGlyZWN0ZWQgdGhlcmUuIEEgc2luayBwYWdlIChmb3IgbWVtb3J5IHdyaXRlcykgd291bGQN Cj4+PiBsaWtlbHkgYmUgb2theSwgYnV0IGRldmljZSB3cml0ZXMgKG1lbW9yeSByZWFkcykg Y2FuJ3QgYmUgZG9uZSBmcm9tDQo+Pj4gYSBzdXJyb2dhdGUgcGFnZS4NCj4+DQo+PiBJIGRv bid0IHNlZSB0aGF0IHByb2JsZW0uDQo+Pg0KPj4gSW4gY2FzZSB0aGUgZ3JhbnQgaXMgcmV2 b2tlZCBkdWUgdG8gYSBtYWxpY2lvdXMvYnVnZ3kgYmFja2VuZCwgeW91IGNhbid0DQo+PiB0 cnVzdCB0aGUgSS9PIGRhdGEgYW55d2F5Lg0KPiANCj4gSSBhZ3JlZSBmb3IgdGhlIG1hbGlj aW91cyBjYXNlLCBidXQgSSdtIGxlc3MgY2VydGFpbiB3aGVuIGlzIGNvbWUgdG8NCj4gYnVn Z3kgYmFja2VuZHMuIFNvbWUgYnVncyAobGlrZSBub3QgdW5tYXBwaW5nIGEgZ3JhbnQpIGFy ZW4ndCBwdXR0aW5nDQo+IHRoZSBkYXRhIGF0IHJpc2suDQoNCkluIGNhc2UgdGhlIGRhdGEg cGFnZSBjYW4ndCBiZSB1c2VkIGZvciBhbnl0aGluZyBlbHNlLCB3aGF0IHdvdWxkIGJlIHRo ZQ0KcG9pbnQgb2YgcmV2b2tpbmcgdGhlIGdyYW50PyBUaGUgcGFnZSB3b3VsZCBsZWFrIGlu IGJvdGggY2FzZXMgKHJldm9raW5nDQpvciBub3QpLg0KDQo+IA0KPj4+PiBKw7xyZ2VuOiB3 ZSBzaG91bGQgY29uc2lkZXIgaW50ZXJmYWNlIHRvIG1hcHBpbmcgbGFyZ2UgcGFnZXMgKCJt YXAgdGhpcyBhcmVhIGFzIGEgbGFyZ2UgcGFnZSBpZiBiYWNrZW5kIHNoYXJlZCBpdCBhcyBs YXJnZSBwYWdlIikNCj4+Pg0KPj4+IHMvYmFja2VuZC9mcm9udGVuZC8gSSBndWVzcz8NCj4+ DQo+PiBZZXMuDQo+Pg0KPj4gQnV0IGxhcmdlIHBhZ2VzIGhhdmUgYW5vdGhlciBkb3duc2lk ZTogVGhlIGJhY2tlbmQgbmVlZHMgdG8ga25vdyBpdCBpcyBhIGxhcmdlDQo+PiBwYWdlLCBv dGhlcndpc2UgaXQgbWlnaHQgZ2V0IGNvbmZ1c2VkLiBTbyB3aGlsZSB0aGlzIHNvdW5kcyBs aWtlIGEgbmljZSBpZGVhLCBpdA0KPj4gaXMgY3VtYmVyc29tZSBpbiBwcmFjdGljZS4gQnV0 IG1heWJlIHNvbWVvbmUgaXMgY29taW5nIHVwIHdpdGggYSBuaWNlIGlkZWEgaG93DQo+PiB0 byBzb2x2ZSB0aGF0Lg0KPiANCj4gQ291bGRuJ3QgdGhhdCBzaW1wbHkgYmUgYSBuZXcgR1RG X3N1cGVycGFnZSBmbGFnLCB3aXRoIHRoZSBzaXplDQo+IGVuY29kZWQgYWxvbmcgdGhlIGxp bmVzIG9mIEFNRCBJT01NVXMgZW5jb2RlIHN1cGVycGFnZXMgKHNldHRpbmcgYWxsDQo+IGJ1 dCB0aGUgdG9wLW1vc3Qgb2YgdGhlIGJpdHMgbm90IHVzZWQgZm9yIHRoZSBhY3R1YWwgZnJh bWUgYWRkcmVzcykNCj4gaW4gdGhlIGFkZHJlc3MgcGFydCBvZiB0aGUgZW50cnk/DQoNCk9m IGNvdXJzZSB0aGF0IHdvdWxkIGJlIHBvc3NpYmxlLCBidXQgdXNpbmcgdGhlIGZlYXR1cmUg d291bGQgYmUgbGltaXRlZA0KdG8gYmFja2VuZHMgaGF2aW5nIGJlZW4gbW9kaWZpZWQgdG8g dGVzdCB0aGF0IG5ldyBmbGFnLiBJbiB0aGUgZW5kIGJvdGgNCnNpZGVzIHdvdWxkIG5lZWQg dG8gbmVnb3RpYXRlIHRoZSBmZWF0dXJlIHVzYWJpbGl0eS4NCg0KDQpKdWVyZ2VuDQo= --------------r7sMqSS8ZqNi1Ty98nvfm00l Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------r7sMqSS8ZqNi1Ty98nvfm00l-- --------------AFg0d5zVGksTmmsatDsYIh67-- --------------PfxmkzBrU7vcsAkgFckMCu8H Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMxTxQFAwAAAAAACgkQsN6d1ii/Ey/K eAf/Sg79JT0uieERNcD20EFLKz5YWp156BsJDnqVtJtHEnTyyR+U7Y6acinVReCyge7JDZrllNeB 7IAaAZc2158eJcrtF6NqA/96A2Xze7tV5xwQSWqlYE9K1WHm3J79IbEXocHjqRO57oDOEraYnjuv xuqU5PAMY/zKdVFuGDqmBgg6JTo5Etl3IwaSegY3j5dGnVzOapM/o2Dc3TW5ISwLmxYmkv9AkZVJ YXw9yq+6B0LfMHvf2afA8QgHi47/DSKJWTHxfMIytUaYNRWFN8QWjcJEq2s4SYKNxHpEr5w87g9A pN7oc/EPmOLhstYrXHrGLRyXAzXllNBinUY+jr/bBQ== =F7gi -----END PGP SIGNATURE----- --------------PfxmkzBrU7vcsAkgFckMCu8H-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 07:24:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 07:24:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411422.654342 (Exim 4.92) (envelope-from ) id 1ociT4-0002eJ-UB; Mon, 26 Sep 2022 07:23:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411422.654342; Mon, 26 Sep 2022 07:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ociT4-0002eC-RP; Mon, 26 Sep 2022 07:23:54 +0000 Received: by outflank-mailman (input) for mailman id 411422; Mon, 26 Sep 2022 07:23:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ociT3-0002e6-5V for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 07:23:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ad93b74-3d6c-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 09:23:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8209.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 07:23:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 07:23:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ad93b74-3d6c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jGJWT5U0Donpj9lIieDH8NW8DfKu6JAZbXnP782bTU2YFUrpNy6UDFLUbbPghX/QOmnArhHyiFSW9j6lExss+6K9HaRRIkUdDhIQbfn2kWvUs6Lg59Qm4YRk9FIRj+0uoO9gLrKkt5nTKmws8Sfxwz4DwCzB616uITfsdar9rUdPEMam1J3y7Poz67NE9EWY+QOiIEXscCdCON4BtMczIXtVoX3tZcqsMaCXciOA64uqHvwMtUkyy80vMdr1+xykYqktF7TTtd83p7/YFMi63Ttyk+FPfskqOov/boSkWJvssmZe548hEgaPH8vyWSUKFu0RcqL+KLxWdJ7fJR6O9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2mbHJwnSnW+enGqsvXm/WdU8Os6gkhLRXZQyKs93iA8=; b=RvnvJTL0I6Hx2xshJupp4dnD1+03z6yHBglITNNqe1HGQMAU+pkLVSSkUs682B4IukDIIzzf8g62DkKIEDq1ab+uumtbHZXZFSoq3Mpigq6PLCl5xN+aQz4uT4B/2kcZtCmRPPMfbYU268AYnsOKhzAA/ZhNFy1CEjSgl0Cn6IbmTj8r6OqtOFC6mj8M8kayabnqXi1QOHJxmZhBH/uWDqCVSCNXI0CwZpSoagaR4hrkMyQr37PMxggXTHv4bYRdd8yGXumyuFDCU2B3rjUvCJdt3ReaHNTlNxl1TGgn2EdbZ4AJ047Fvez4xGYCWeY9pphOYHi58qiUa/JFbSqfig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mbHJwnSnW+enGqsvXm/WdU8Os6gkhLRXZQyKs93iA8=; b=gjV9ICk8nvaMzQJX0HQX7i7OuMNg8xsSThgk5omUbmcJ2Q+QEyJItcFNRqrirpRIJWqmkxHNw49etVceV3sS+dYvoU65rt7jQ5rG+hQwzAsihUbBCoSbSl/LlC3sf75U9wgGpF1Ncl4zVuPA15PygL+ySuBQSl0M50oyAXzySPiK6cpseNtGG2VL+iGike8usv8pQ5JSurUw1oZgiQolEBm8ETw43x0N01s+0VALa4GF07QfFSJ42QE8WzpO1ey1fjYOlY1FjS6hbPpC6Slx3vgwR0BLeA/xXlhBNpx5ZG34xvYsFjucK/+672ojTQ8fedHm+4lMNTPzOdJ0TbOUyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 09:23:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session "grant v3" Content-Language: en-US To: Juergen Gross Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> <12ef0abb-2158-faf7-76d7-61e165060d0c@suse.com> From: Jan Beulich In-Reply-To: <12ef0abb-2158-faf7-76d7-61e165060d0c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8209:EE_ X-MS-Office365-Filtering-Correlation-Id: ea49b183-9d73-4322-c54e-08da9f900def X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oKMXtAaT4+qOOJgLAfsUU14Nsou43Ht9HrMjLuVMEQ4ZMJi5oeQwAkvA2CZXOUa2C9NBNs/suNYk2qugGvy0Sd0dze2yRxezLAr8bo9Ev8rT7cLKgu8Z6sxRZX4ZKyBhdFILleeb/iDuYfZJ8YqhWHtuMJr0b6rT6djno9mf3DkQHfMqhhnIlXNQV137ug/oxSnPs1oeNtu/yN8IRlZcABwnTh7aZ6e6Uf3iBcNwehZiTKKu6f9lzk/+Av1b6JNmlupOFobrS21SzAegS+thJiecc9vbRpHliV73WHKFbS+iFHFnkC25RoO815+F0KPECPTzkg+zB5CbS/6s8RLbs6wXYaRNyDRVoZ8ym/29KzNT5H2fp+9mtvZPbi4Me3JuMuQlZY8vzBWrS6+Vh8J8vHyKzHPPkioxkZxxoNo1XJhvDNHRWVxKVjrQMtAVnZpSxukf87NPJV2svTPmdWqTt4fFxAlW12+BDGqkcA3Ljzqg0cBzoS8LNzHIs6tUafqPRgKnPtojNXXblnfHWjxQs4x/rMaOqBdw9IzR/i9eGbYXBaU+RE6NN49xPE5dKsnLSaCb4NyCNHiGQye9CDv5T6PRG7uLHKR0HcZA5lQTUiOhwbx0uU3Fl1uT8xsv3RSjvjW3aPaL2oepSDo9C40AUvNQzYK5uwuPEl5RXcT04BMHlXNq/GJcJkrG8arh9CYI6IJx/j2QqOqGgLRL5U3W5xm24hPn5/w0HkQQiiL4nfz5b/ngznPF0Mn2Ru1r1WMZ36re/2KoXcRASN7vqD/OueNumdyyPCHSjQ9B4rpcGoc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199015)(6666004)(41300700001)(53546011)(6506007)(8936002)(6862004)(26005)(6512007)(5660300002)(83380400001)(36756003)(66574015)(38100700002)(2906002)(186003)(2616005)(478600001)(6636002)(54906003)(37006003)(31686004)(66899012)(316002)(86362001)(6486002)(8676002)(31696002)(4326008)(66556008)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXdUOEVkVU93Y3pTdjJ6ekt4cm92c3hYbmlIMklzWWRtOFJ4Um9rZ2EzOFYz?= =?utf-8?B?YVZwMmxSTndJZnRBY0hEWnZtVElCNkxQT25LUlJOTTB1d0pXbmJYcGNScGxE?= =?utf-8?B?dkhpSmlKRmloaVptdjdyZm1HaWZGN3QwbkhueXU2MEVCSk82ajk2a0wxbjJX?= =?utf-8?B?NS9mTHRVSDU2YVd2MUtBSnFTSkp5TTAyT0NING1VUUpyTHc0Z3BSOVR2aDhT?= =?utf-8?B?OFBOaEtnWGRHQ1VqVUYzTkEvcGJyOE5xbC9qMHV3bWlWODhGQStDUjJoYkk0?= =?utf-8?B?NFNQWmZqMUJxRGlQelNxOC9qZnowSlVCWDAvMGNNWkdJUkJGWW4rZVZYejdJ?= =?utf-8?B?Q1hSb0NSUDdTVmIralZibWd6aHlHUngyaEIzTXo0dFJJVnhFTXF5UWxJV0FO?= =?utf-8?B?NXlqN2lxb0tyakE3UVZtK1plL2FyS2l4cHVCT1A5Q3IrQnBDck5TdDlSenUy?= =?utf-8?B?b0p0Wnc5YmFQcWVpQUlvdFpWOExkSVRId2ppTjl5QnBUWS9vN0xyU2QvL2Ez?= =?utf-8?B?ZlFOVHRyNGx5QitkbkFHUDZjNnZkRGl6OS9ZQzFORHd6Z0U5ZjFHRXY3dlhy?= =?utf-8?B?eTNKKzBwK0VKV09iNitpR2JUWEVBMk1LcWprMFJqby9LR3VqZGZieFZSbnU0?= =?utf-8?B?Q0tuS2tOSjhzSmtYMnpZY1BZbmFocFpOOThNMUVsbG90UmRJLzlrYU4rdm1Z?= =?utf-8?B?c2M0cm8xNHVDKy9zWTZPWGpBKzFhWlk0OHBqMnJEMGJtaGpuenVDSFplMm15?= =?utf-8?B?WlluQjE1dmM4enBRUTJzWXhnZUFoL1RvWDBIekh3RW1TOElLMkRKbUQrNTJv?= =?utf-8?B?aitJK2NxbDRsTWcwcFR1bTdvTys4S0NJS0wxS0RLTUFvck82dU1lRXNvWTJr?= =?utf-8?B?SnVoT3NrQlNDSklsMlQxaDd2Qm1XOG42dkpSZG1qY3JVUHF2WEg3SG42WkhZ?= =?utf-8?B?UmdIWm5qMEZBeFFKVHJ2M051eGpYMFpTazJjYzI2clI2eEsrQ1p2SXdlRkxY?= =?utf-8?B?TjIyOXQvY2duaTMxQXgwVGhyaGdEbktacTdrdzl5S2cvcldBRk1mN0wzbDc4?= =?utf-8?B?WTVBN1VpMyt5U2UzVnROblpNK3h1M1NVNDUxZjBDcGRFRmtzdHhraU9oOW8w?= =?utf-8?B?cUtkQ1VBMENzZnRsSW9rQ09IMmw2cUw4dXd5UWc1V3ZnWHlsWGEvM2ppb1g4?= =?utf-8?B?K2hXUnJnTmNQWm0wcDdWMWpHTnhSWE10aDhiSGNqS2w1a0JLV29VUGNGcks0?= =?utf-8?B?VVJ3Vjk5NGJzL3NiSkU1WUd4NS9IcURKS3psRnlwRi9jbGZiUjhibFdEUG5I?= =?utf-8?B?bFIzUHplVWltNUZCWUxmUE05Zlk3VWhZSDA3QUZRWnhtTGFPRC9GakZHYmRM?= =?utf-8?B?QkowWk1OdWlPUHRUbHZGdVJZc1MyUGRHeWc2T3VyZ3VtYjFjalFvU2xFNWZQ?= =?utf-8?B?bGEvT3FUclBFLzBndnBYZVEzNnhEUWE1eEdIdi8zb2EvaEYwMk1mdjRZRWNa?= =?utf-8?B?SnRPVnMzQ3JjT3k4R1dOeGRSbUIwYW9FbE5PTlFhZU5nVmkxVkZieEtXSG01?= =?utf-8?B?TGxGTzFOeWpScVgySGhPOFk5emI3Q3VkRDF1dW5BWlJvR2wwZFNuaGFheFhP?= =?utf-8?B?QlQ1RTVXZytLWWNNelQvSWdtY2NtMnJtUFlOR1owSmRtV2tFOFRmdzZGaTJ1?= =?utf-8?B?b1BKOVQ4M1JjR3c1aWdidDNKVHFBaGZic2k4MzU4ZUpJa0c3UmI4WGpKZk45?= =?utf-8?B?KzBHUlVJa0RzdU1PUjVldmZNbFkzY1B6Mnh2aUU4SVFNem5rZkZaWS9ZQ2pj?= =?utf-8?B?SVpnYklTNkdVTnRDbCtpTHVBK1NTTzF2QWFEUmtKSTF3SGtTRERTeGNvOTVa?= =?utf-8?B?UWRmcjdmeHlkNE1GVi96YUlwUC9XSytxcGc3ZU9IVzZHSnJXc0tlVE9DcHN2?= =?utf-8?B?Mm9VM1pCV2poVkk5d01JVU1KMDk5N2RjemE0UkM2VXlHdjVBT3l1YkVLamNH?= =?utf-8?B?Q3VGZXMzTDFqaEdUcXJibThHZDhVN0FZTUJpTERRaFVSeDR5WlRvTStQU1lO?= =?utf-8?B?OFdTMXZFbitldzRkNXYydnB3U2R6aytsME5DWUtJMVV4Sm9zY2R6VFJTaXNX?= =?utf-8?Q?2qvcCb0HW8SoGJxrA9i/0mWLS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea49b183-9d73-4322-c54e-08da9f900def X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 07:23:48.5520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NAqJzn/GGimuLqj2RyUsquhmE7K/BppgpyM1Qb5BEwjWFKQewcYPc6EZIpU/BtrytAmMCF3sVDNmzyxoF1oEgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8209 On 26.09.2022 09:04, Juergen Gross wrote: > On 26.09.22 08:57, Jan Beulich wrote: >> On 23.09.2022 11:31, Juergen Gross wrote: >>> On 22.09.22 20:43, Jan Beulich wrote: >>>> On 22.09.2022 15:42, Marek Marczykowski-Górecki wrote: >>>>> Yann: can backend refuse revoking? >>>>> Jürgen: it shouldn't be this way, but revoke could be controlled by feature flag; revoke could pass scratch page per revoke call (more flexible control) >>>> >>>> A single scratch page comes with the risk of data corruption, as all >>>> I/O would be directed there. A sink page (for memory writes) would >>>> likely be okay, but device writes (memory reads) can't be done from >>>> a surrogate page. >>> >>> I don't see that problem. >>> >>> In case the grant is revoked due to a malicious/buggy backend, you can't >>> trust the I/O data anyway. >> >> I agree for the malicious case, but I'm less certain when is come to >> buggy backends. Some bugs (like not unmapping a grant) aren't putting >> the data at risk. > > In case the data page can't be used for anything else, what would be the > point of revoking the grant? The page would leak in both cases (revoking > or not). Sure, but don't you agree it would be better for the guest to have a way to cleanly shut down in case it notices a misbehaving backend, rather than having its data corrupted in the process? Of course a guest won't be able to tell malicious from buggy, but what to do in such a case ought to be a guest policy, not behavior forced upon it from the outside. Then again I guess "pass scratch page per revoke call" is meant to cover that already, i.e. leaving it to the guest how to actually deal with a failed revoke. >>>>> Jürgen: we should consider interface to mapping large pages ("map this area as a large page if backend shared it as large page") >>>> >>>> s/backend/frontend/ I guess? >>> >>> Yes. >>> >>> But large pages have another downside: The backend needs to know it is a large >>> page, otherwise it might get confused. So while this sounds like a nice idea, it >>> is cumbersome in practice. But maybe someone is coming up with a nice idea how >>> to solve that. >> >> Couldn't that simply be a new GTF_superpage flag, with the size >> encoded along the lines of AMD IOMMUs encode superpages (setting all >> but the top-most of the bits not used for the actual frame address) >> in the address part of the entry? > > Of course that would be possible, but using the feature would be limited > to backends having been modified to test that new flag. In the end both > sides would need to negotiate the feature usability. Isn't it to be expected that this might need negotiating? Strictly speaking it might not need to be: The backend's map request (for a sufficiently large number of grants all in one go) could be checked for being all contiguous in the applicably address spaces. That wouldn't require the frontend to advertise anything. But an unaware frontend wouldn't be very likely to produce suitable I/O requests in the first place, I suspect. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 07:33:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 07:33:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411428.654353 (Exim 4.92) (envelope-from ) id 1ocic3-00048e-QC; Mon, 26 Sep 2022 07:33:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411428.654353; Mon, 26 Sep 2022 07:33:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocic3-00048X-NF; Mon, 26 Sep 2022 07:33:11 +0000 Received: by outflank-mailman (input) for mailman id 411428; Mon, 26 Sep 2022 07:33:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocic2-00048R-3K for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 07:33:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77a60d29-3d6d-11ed-9647-05401a9f4f97; Mon, 26 Sep 2022 09:33:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6811.eurprd04.prod.outlook.com (2603:10a6:10:fa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17; Mon, 26 Sep 2022 07:33:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 07:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77a60d29-3d6d-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9h+Qlr1bPwoi9Xs/kYniLYCg1B++A1p4b7z/JNcFyaPyA5KLw0o3hq4DItK6zy/LAcWQOCLfuIWYx76wHnd5KCmOC8qMGIGol91WgV+/drBddnBrdb+f3CBoaDX+LSe5xtys/KYUdGOmS+2Z1BQ0ZDYewHWfnSpLz1oT+avdOCej/xGoCq2vHdV0KGBooh3p59SOe5yJulHPaWVTpbqzG4cA/M6gEIhLVU9Lcu5P47JQIdfx51l8EQVseGFcGfYr7y4PHQ5G2BHiyt9uHbkKihiaRchefg/2MWcGflbMave1eb1r0jnF/NvDqX8Rk+qaHLG2wxii4ZklE2soAS8+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VWcXbLBlrUdJsiomgj1tfYqTibopzRmvio1yIqp9zkI=; b=BSQseq+F8waYyC5kB8RSUO7LQqea/4AhG9d3vncN6AHU/QyF8FG2scD8B9I5gTYOEY4efdBowyLmL0my66JDLboAVIlXF9hHK4JJ/MxSZeOq+WXwCQppS2Xgu1SVNDgnoN6HVS4Ca+L2HYhZGx+Mm8HftkPrX4zF2AcXQi4/g4785isUXT6Fl82ZEmdcXETbMJFo2op/VxBENyR78ZYHV+/sJEd2IMiFZuq8lGzTXG7GZ0tcr8JzVXFFh8lP8DWTgIRoWy8ecIXtH9wlhpkuDNvQ4aENHiXLPx413fnZhxVv0diYnl0SPljej81rssSBevXm+mj2rjHANEzuyLq/dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWcXbLBlrUdJsiomgj1tfYqTibopzRmvio1yIqp9zkI=; b=z737yYUSZw4tbl/AeohwubkwHjxRuCuVVOG8BoxeafkHTEFhbBG7MwLqWjWiRhZK/xA0q71S0ZGmyQ5IFtbhT/33DtN6XhfNzN2jYRsROoT0nTeP7fgTzhJGNKPh/8QZ64Ku+3mEmbeAhkuuo//nianYuAaW5autc/lr+M/j+HRdb5dnIvnQY0iGhTIUoLs6o1IsQLB3Vc88S7nKHkzL2snlZxJjoX1t+LbK1rwaG3NsoBip9BSBHc04odax97iEgXp/2Zh3PvsXW4UG2DACPxV4js9JzmmlSPpK8IPHvPg3qTigO7I0maoESmgXiFCSjtQ2y1CbzsoMZn/3jSXAtA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> Date: Mon, 26 Sep 2022 09:33:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220922160516.5929-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR08CA0030.eurprd08.prod.outlook.com (2603:10a6:20b:c0::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6811:EE_ X-MS-Office365-Filtering-Correlation-Id: 361e5284-71c4-4d2d-fc7a-08da9f9159f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j5KhOvdj6xsvWF7mAG/SBFq5bHoKVD0h4rh6ZNWxXAtCU3WJo6toPmJUolZhPuPnYUoML78zPN4q7vTN1kSdOihuKs8liY1Zzj6Q3A1BYhDkPrPxrMIf8vj+jLqpAza2OGChmRh2bOQMmsw/bcaJK+qj0ebeib+pBWEZ6VUyTSyagiqV4cMqVovjMuG1mBITKq6D3Lm7VfIX7ng9PsrPfV+giNiIYprqpm9uK4F0iTqgh5pYmbHE4ilDhudZDuU62sTKoRgXNJDRnEHkegABAq5ScJ7nX9pSlhi5edRtuJ6QRRoXg7gAX/Xs/h7AFzuca83cM3jWN1RuWRXnQnIFzENRAuoWQ/Lv2fmOziM7dj8VSM4s/ts/X3TTSMWot5gkURFYiHtI00rEM5iLFXyept6rXG450MlgkLsuQ0tpEFBfVtiK4YTsslkaNXnodLnLHrzeQjxoiI2gFAgS8PCEUwdBjCZw3VF78cNKkqwleec5Uyv7jWfLBBrOuWYaFz6UN5QRcvjRQ3c32j+HNfYi8U0vO3igWW0v0t95wWyyCCLZCTvm4lxiBaJD/6t8Ec+GUwOyBrJd/J1m9QxqfeFufVLedP68qMCv9nOiFj4iRFhb4e+Gs3g2qcpf7LsnJxdw4GeWuyGVEnZYZtn7zafsqy4iS43kJ+OrMPLTXCoXl2KzoYEaeVfbNwSLZK47CIpirvpKhsnwvFpa4/QCDl+f1pPM2v3j+K5Esgo2nyCpkIi5OxFBLgorgM5osYqzVsX8Q3zVfkkR+MdPnmFPsAXFIYXm+HsmKE7YtYzSBQBSIto= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199015)(31686004)(53546011)(41300700001)(2616005)(186003)(6666004)(8676002)(8936002)(38100700002)(6486002)(5660300002)(6506007)(83380400001)(66556008)(26005)(86362001)(4326008)(2906002)(478600001)(6916009)(66946007)(66476007)(31696002)(6512007)(36756003)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1VsdnpJZUpxR2pZMHo4YmtLRk9qbmNNd0g0Q011QXJISDNGWW9WQ3pqeitQ?= =?utf-8?B?MklSQkVicml0ZWJ0aDBQMExjclB4Vm44L3RPRmlTQ001SUlXY3k5RW1kaHJl?= =?utf-8?B?MnFqVVdUZGphSWFIaFRpYzltUk5hZlQzMHdQT2k5ZW9IalNReXVhK1ZGUHpK?= =?utf-8?B?dTNOSzNCeDFsZkFHdzdhNWU0NjVmS0VIN2IrbndGZFdZcTY0ZFlGekcwcEhj?= =?utf-8?B?NmVYS3NMWjdoTDlwNVE2VnVhTW1SWldvdlNiYzZWd05zRzlUb0g5Z0xBUC84?= =?utf-8?B?d010ZUNLTEkvcExPOUJzc05YMDY5d3hDSzZvSUdRQTlnTHZaMGhpd2VHdXFM?= =?utf-8?B?YTVXY29ON2pkbXIwNTVHdndVZngva1ZKRFdMQkwrWHBSd0J5WCt6cm90QU1Y?= =?utf-8?B?T010a1RCeFM1YkxZQjg2YlZoYk8rc0grZEJQL3hyUTRxYUtaL3V3dXRyR3F6?= =?utf-8?B?a2wrbHhnTzFTaW1mMGJZc1dMby9uT2Y0YU1oZHVidkw3eUFmemkvODVoWE1k?= =?utf-8?B?bjNyeDJxb0pha3JHbVRmdlZoUHpON3Q3SHVsVzBiTk5ab1FJb1BkN2lMU0Uy?= =?utf-8?B?MG9JOEM5MGhkUUxLejVra2ZZVDZJTW5Lc1NqYXpvUSsxRjBCcE1DTnNyaXZG?= =?utf-8?B?dVUxMGwwWnpjZkwwK2N1VTVXRTh6VUMxR2lFMnA0TWV3R3ZRdFhqVXBDY0Z6?= =?utf-8?B?Vk1MREVjNkl6STFpT2U4azBENFFUeTRwVG12ejU5L1ZndE9GekxlYWZuQVdB?= =?utf-8?B?Sk5HdDRUSXY3SWt0bU1yQnE0ZFhZUFl4VmF5NHNzdmdJTHZTTkdhaFZMSGlP?= =?utf-8?B?eDZnTTVERHozcDlaS1RDMzhwdTMrYWc2c2JNTDZUZE9yNFRJd0F5b2g3ei9K?= =?utf-8?B?RWQraFNTVllXZm1YZGlYbElycGpwdWtuRDJoMXBwWnhTUVhxTVJwU1IzTFlu?= =?utf-8?B?cVFYUUZpRVQrQVlrRS9XcXVEeE9oWTlvVisvSDlEOE1qSFVBTFM5a1hkNGFa?= =?utf-8?B?Ym9EK0puWDhHKzgwaHNJK01qL0luTnlnN3JhNXdOZUIrRGx1VERMNm5GdUNt?= =?utf-8?B?WFR1L0Jqc3g4eDRWR3dQSnJvMWJFSWxKS2xNaDVMTHFiZFpTbVlTc2NRNXRh?= =?utf-8?B?MU1WU1Q2NUFTZkswVE5nSTQ2TVZHdE5jS1JrZVN3ejhoay9EdlQ2Rnc3am13?= =?utf-8?B?WEp4M2t5WDZsbUNrYVJ4dHIzektGdjBRd0txaVZINkVUZEpjK3JkUHd5WkVG?= =?utf-8?B?Mmd5YTQwS2dxOXAzK2hsR0RNQWNDdFN5cUF1KzlnRW4vZnpDM0VhUlZsMTY2?= =?utf-8?B?eE9BNWdKSitOMTMrK2ZFYVdDb3VJSVh3WWxpSzUrZ21KOXRnRitKanpYU2sx?= =?utf-8?B?KzFQT2RxSExhT3JYeG1wK3VQY1p6SGFKM3NUV2xtRlBOdFRVYkdlS29SM1Rm?= =?utf-8?B?WG54YkVwNy91RmlGZ3lWQ3h5RnYxcFA0NldOblpnS3RRZk9hSlcxN2NGK0hS?= =?utf-8?B?VUpNTzRBU2M5SEJ1MEFRcFEwWWJQWkU0ZFp5ZUlSRHo1cVV4cXNZOVlzMzNy?= =?utf-8?B?N1U2OXVScW9UTTA1bDc3MFZvWjhEbDRiZ2pKUTVIclJXdkpBWUduc3ZDTFpZ?= =?utf-8?B?VVFoYlBkT0tBc013ZXRnZFVyNVpDdWRaOWs1amJCWnF2eXpvdXV6cDRLdHNI?= =?utf-8?B?NGlLQVRKS0V6a00vbTRjNnA2NnNLSk8xUGRHWklaUFdoTzNBZnF2WEFSY1Nk?= =?utf-8?B?OEkzb2V2TkRvYmo2WjBacUxuZ3FJWFhNZ3pXcEovblRtd3hYdG4zZW4xaXJL?= =?utf-8?B?R1BzcmJjLy9JYUc4VEloM0lvR0tQdkE4ODlsVk1vQ3FXVDlyZjRnQUNtVGJR?= =?utf-8?B?YnZIMU5kL25JUTd5cFlpVVUyNzZtbVVhWGZOUFljR0w4SXk0d2t4ODlkbHNL?= =?utf-8?B?WWxwRWd4ZWtmNE5GS1V5Z2Q3WUsrTVlRMWpZcFVKUEFhaEY2cDYva1RBR1Qz?= =?utf-8?B?b2JpMVlselpwZHFRRisxNFluR0liamN4T1RKZWpjSWJlWTdCaTdJSDZxUGlx?= =?utf-8?B?M3p1T2xabFFoMURQU0RlckhQK2FsOTdlVnZlQ25FMlNtaXhlYVJsRWtlWEFY?= =?utf-8?Q?SLU4Aq9uzZ7RtGNKV9G9D73nK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 361e5284-71c4-4d2d-fc7a-08da9f9159f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 07:33:05.5948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mDc6W09b1O2ZSFCAujXwTHfU/wDiWGt4ppfRIKLogYudUhIvxqCKxD0u1e2ro77Y4NRrXXX/JfOURY2pg65d4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6811 On 23.09.2022 10:35, Roger Pau Monné wrote: > On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: >> On 22.09.2022 18:05, Roger Pau Monne wrote: >>> memory_type_changed() is currently only implemented for Intel EPT, and >>> results in the invalidation of EMT attributes on all the entries in >>> the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits >>> when the guest tries to access any gfns for the first time, which >>> results in the recalculation of the EMT for the accessed page. The >>> vmexit and the recalculations are expensive, and as such should be >>> avoided when possible. >>> >>> Remove the call to memory_type_changed() from >>> XEN_DOMCTL_memory_mapping: there are no modifications of the >>> iomem_caps ranges anymore that could alter the return of >>> cache_flush_permitted() from that domctl. >> >> I certainly agree - this was an oversight when the two aspects were >> split. One might argue this is a (performance) fix to the earlier >> commit, and hence might want to go on its own with a Fixes: tag. > > Was wondering myself, didn't add the 'Fixes:' tag because of the extra > content. > >>> Calls to memory_type_changed() resulting from changes to the domain >>> iomem_caps or ioport_caps ranges are only relevant for EMT >>> calculations if the IOMMU is not enabled, and the call has resulted in >>> a change to the return value of cache_flush_permitted(). >> >> I'm less certain here: These shouldn't be frequent operations, so >> their impact on the guest should be limited? > > Citrix has an use case for vGPU where IOMMU regions are added and > removed during guest runtime. Such functionality makes uses of both > XEN_DOMCTL_iomem_permission and XEN_DOMCTL_memory_mapping. I see. Maybe this would want saying in the description, to express that there's little expected benefit for upstream. > While the memory_type_changed() call in XEN_DOMCTL_memory_mapping > seems to be the most problematic performance wise, I though it was > nice to try to avoid memory_type_changed() as much as possible, as > those tax the guest quite heavily with EPT_MISCONFIG faults and the > recalculation logic. Trying to avoid this is certainly desirable, I agree. But we need to make sure that it's not "easy" to break things by touching one place but leaving others alone which really would need keeping in sync. Therefore I'd see such added logic as acceptable only if the risk towards future changes is sufficiently low. >> And if we were to restrict the calls, I think we need to clearly >> tie together the various places which need updating together in >> case e.g. the condition in epte_get_entry_emt() is changed. >> Minimally by way of comments, but maybe by way of a small helper >> function (for which I can't seem to be able to think of a good >> name) sitting next to epte_get_entry_emt(). > > Such helper function is also kind of problematic, as it would have to > live in p2m-ept.c but be used in domctl.c and x86/domctl.c? It would > have to go through the p2m_domain indirection structure. It would need abstraction at the arch level as well as for !HVM configs on x86. I'm not sure the indirection layer would actually be needed, as the contents of the function - despite wanting placing in p2m-ept.c - isn't really vendor dependent. (If AMD/SVM gained a need for a similar helper, things would nee re-evaluating.) > Do you have any suggestions about how the function should look like? > I'm afraid the fact it needs the previous cache_flush_permitted() > value makes it kind of weird to encapsulate. Indeed. > I've attempted to add comments to make it clear why the new checks are > added, but I would also need to add a comment to epte_get_entry_emt() > to notice changes in the condition need to be propagated to call sites > of memory_type_changed(). Right - it may suffice to have one more extensive comment, but _all_ involved parties will need to have at least a cross reference such that one can easily find all pieces of code needing to be kept in sync. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 07:38:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 07:38:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411437.654363 (Exim 4.92) (envelope-from ) id 1ocih6-0004ra-Iv; Mon, 26 Sep 2022 07:38:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411437.654363; Mon, 26 Sep 2022 07:38:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocih6-0004rT-G7; Mon, 26 Sep 2022 07:38:24 +0000 Received: by outflank-mailman (input) for mailman id 411437; Mon, 26 Sep 2022 07:38:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocih5-0004rN-Se for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 07:38:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 325576e1-3d6e-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 09:38:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8137.eurprd04.prod.outlook.com (2603:10a6:10:244::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 07:38:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 07:38:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 325576e1-3d6e-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mb4DuymP5xSxAyNZouH16gzyZKhvFmTf15jYnuEhQd2IRQs5Ub+l85DVgqSw2IGRaoLJch56tp+33XK2uwv83UgQS/iPl9TGR97JxoLCNzDxxY29v2VIKF9LrfyIfmtmGYietXjuZRz/1E5HbTOdrQDFyThlcqS+8rgRy2IrIdUQGer5L7kp1DjAocXkJcQVQi74o0yo62ZSZjjzX/LoegMRbIV9ELDpc+rEkU3p8gJaiiDaATTKoNTnJXkJK5MxwhMNxXqZNL6OooP2WNcuZLQx8sRb2H5sYIBpHuUauVYXq+mj96B4kfT4mVwOKyGhQz0OKKN8yQc3iNV/pq0qIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+sPYd1N0tcc6nXClerFhbPKDko76+vUqNtqyBEH4eU=; b=A5xreRt9WYCrRhca0ztN42GvJBAIJzUCWuadzyFcE6AL8wiklPIU3X4rAX78Cstse9jDL+Rjcr+bQgNL6mwKHVnfGAY6z6jzwae1hyPDG399Svzpo/82T0kP+VMAHbe75e4IlzcB/bVmqkdNy1CIVT59J4y4ovsNZ8cqZ4KzNWMO/75wXZ5niuGldXE5qO8n0jlXEbh5IHE6m6wE7E4Z6F91Kva9rsCPanwDyNT/4BBuaR536n22GIQd2bXqLyb+TMpxp6GmYNxVlSm15ffxeTofJgjtCFjjGi5lTPg/PzBCZvPmVB2hDjBQR2fQT1lJukb9kxcSztuT2Onoynxsmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+sPYd1N0tcc6nXClerFhbPKDko76+vUqNtqyBEH4eU=; b=z0JOe/SGcplidqymniDbHExcalBf73HemSaNjl94OfXqpIOvr+aTdRY0rcKWzWkYTcPsdgesitoyxPfI5C+BdgBwTaEHWdhXVBBZhOs2PERAf62pbKn/Oovp9sOGuo/Dbj7PkVLHENJn7yE0/FoCtftpCfZlAgaqqbQpgeVDDG3n2omIPxlHbDJtsIxTxjOL2rv0Zo0ekbrU6cPKOq49uejbK5iz8w55tW8IX55iaNBqtZIPTfWv1nCgQDGPl9rlCcEorybTwrxkCTpQNxu1XE11yFMK2NwvZaDEGSRduaIkd3rIb/KFpBCjUrpcf/n8pRmIU2LP8wSx0SrZw/t4Ow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <63b9a66f-6ee5-819a-5e37-33eaa8418986@suse.com> Date: Mon, 26 Sep 2022 09:38:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series Content-Language: en-US To: Ayan Kumar Halder Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Rahul Singh , xen-devel@lists.xenproject.org References: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> <000f22e5-1628-a937-0871-44ed498e1b26@amd.com> From: Jan Beulich In-Reply-To: <000f22e5-1628-a937-0871-44ed498e1b26@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0007.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8137:EE_ X-MS-Office365-Filtering-Correlation-Id: 4930464d-6555-435c-5581-08da9f9215e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9dyPjSk5kBFnQj4FAFEF9nNeUZHF7H/CCEoo6vI19MeSjBxIsChwkEpb/9HoYy5YirUCldoONYNy/d5mKA6hihzgqE1HU/TBsjYZPYhVxVND+4r3kg/3aPm2RKhO+wJhBYUg5wRzBfQmdLqZ3eGZ/CfwztocuPOI997+Ly5awJpnkeEsv032mwQwtLTIj9KvpL40eIkmFgb352MLUSUf+9TyYbK3NMXTeYIV5fHAttw3AN3QCV576pFLGS5a9769YpfNbd36XhrjAhDzujZBzXXqHhFxAsb2bPM0gdGrDv1USmoKDIkmHvFA99JtVQ2xWmsc0jTan5Duc6gVrfOS2E8wYfyQ8g44+5CxSOajTHpC+0f5BHYQhYYTvqizPdeogOvo04Z4+ZQawMJcZPWWauyrdJnqq7VCl75Io/IUEZUN3y45hW76BDNNGwlKU/DRqkY5BK2pw6Jlna90X1dRghtjmxHZtUzxAVbjioQMpXe4rcHdhYOAgHIfiQTes92LdCsGGnAyswgxvjHO6UHqzRkr2ZD3SUlj5dZDV7bRw4yFCWy3o/gHtDNrnqrmyLHdhjtLs8uYNsqtAKbU3c00CFi09XmVnHthkSyh39yA3loJdrseYbzGZU2YS1ajJd2jE0t0w361XQoloXgz6XWr7FMh9sZ4VTjxA4KeVFm+mLNyMH6IAWxY+sj3jjkXgVcL0zR1wNK/bcolXbGsmB3M5LBhkWEyAzVNb9Cf2UtNmT5pT7aHo0JYdQLlxIWNOzC3CM0yyRhfUAPhafEBGexOTsX8cV0dIWLk33EvLV+qY0Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(316002)(6486002)(478600001)(66476007)(4326008)(31686004)(66556008)(66946007)(8676002)(26005)(5660300002)(6512007)(6506007)(8936002)(53546011)(186003)(2616005)(36756003)(2906002)(41300700001)(54906003)(6916009)(31696002)(4744005)(38100700002)(83380400001)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUN4eGJZTVhQQktpb0JEL0d3dEhFLzhKMXRPMG5LRVhxd1JDNk83Ukh1T09u?= =?utf-8?B?TXJVeWhQYUJEMVA0LzUxcWw0WHcvaGw3Z0VkMGR3QUFmbjFSTG4weWlkN0RP?= =?utf-8?B?dkFTYUlQaWZRdXRqVDdzRU1lOFk1U0M5TzFXTkpOYzl0bXdKYWkwMDhPaHI1?= =?utf-8?B?NDR4c3ZESVRpYkFsQU1hU0Z0T3VNZVRZMGdRQ21ZYnh0bE9DbXEvUmo0YnFW?= =?utf-8?B?ZFZmU2szd1pjVzFJa1FTRlBCWXZ2UUQ2MVlrUUozNnI1SklsRFVjNzBZOVE3?= =?utf-8?B?QmlNVHJGVlFRUkIvVUdYUzg3TzRneFVUVlAvT0x1ZVVBeFZINld4TzVaRzBC?= =?utf-8?B?eDIwT0VxV0FCWU5ENXFYMFA0elVLQmJSbVh1RldPVGFMdU1lQkpscEw3LzlI?= =?utf-8?B?eWZDaFNsdXhXaVBUNEhkU3NQMzVmR2xkQi9WN0I5M095VEN1cnp6UlFZWU1n?= =?utf-8?B?VkN5SlVWQXU0TFZNZW1IKzRVL29BWDV1MzZ2UCs5cUt0V0kyNmlCV0tJK3A2?= =?utf-8?B?bHcrRjBlUjU5WUV2emkrdVlFSkI5NXNzK2hOb2hNUS9FODd2Si9ZdW1XRXcr?= =?utf-8?B?SjhFbTNuTExLWGdFRlY1dFB3N0d6eDJuRVRVaFI2ODlJMWNvYnkwR3FKdjM5?= =?utf-8?B?ZnlBU0NXbHF5dFMxNEpPTklwZUF1QmlpS1dyZHFRQUsyVVVQOUc5YlAzN0dW?= =?utf-8?B?bEhtbk9iemZmeE93SzN1WGdWOW1qZ3E3QlNMUk9oelk2YktUNnhEMGplcGRn?= =?utf-8?B?YWJDbUJvUkI0UVVJcS9NTEFnQ0l0Ty9lOUd3VU5QcTFPZnNMaHV5U0RiY2dB?= =?utf-8?B?WVo3L0JpT2NXaGtBUjlwOFZVbDdCblZubGEvSi9lVU9CODZVWHR4NnRDNVlo?= =?utf-8?B?cWw3L3o1K3NYL05tUUVRMEkzd1JpeTNJbWZ6anNxSVlMR3BreTcxakdQU3Ny?= =?utf-8?B?WmJHQWV4djdTM3BUZWFENEhQbXNuT0xYSDBoT3ZUanJVMlhMaXR5TU1nQ0V2?= =?utf-8?B?OUVxZTlPczJMTlhLcVhpRGNWZUlqMFc1K2EyVHpaVWdJclZXdThNb1A3OElK?= =?utf-8?B?MHVYak1KY0FORDIyNWpVU2FCekRNTXNCWnRuRnVWM2N2UENiZTRoRksrbE5j?= =?utf-8?B?WCtFZ2tMZHl3OG5MZHoxN1d1L216MUhFeVZiUWxkanpVZWFJV2I0bzNmbGI5?= =?utf-8?B?WDdRTnJvTTJLNXptNnN2Q2RVdDJQa0hOTXUveFU5VDdFU0dYTEtaOExOMGtW?= =?utf-8?B?V1ZrTVRhN2tCTUZRMTBqUG9LVkVGUG02N0p1QjFwemlpdmVIWGVXOHV6eXps?= =?utf-8?B?eWhoMU5qc01TNXlDQlFWUkVUOERwU0RXQWpVV3A3Z0QydEFBb0VGR1VhMVdK?= =?utf-8?B?K1ZRR1c5WjROTHhFeTFuZGlsNGtPSWF6Q1h2ZkxoR0JqcjRIeGF0c2dFTmJn?= =?utf-8?B?c1NUNWx0SE05Qi9STkM0OXVIV0VnY01hU2tBa3ZNMUd3bkk3THJvakhHS2Q5?= =?utf-8?B?VVdXWFhUdm8ra1RTakpUU2RObm9EeE1ZM052L0tEQzg2Ums4MjE2VG9VYTY4?= =?utf-8?B?QnR6QW8wWnBJdjBLdnRiS1I3aFhSeDJJY09VOU1YQ24yTS90cXdXbGRIdVFr?= =?utf-8?B?NW91VHVuN1dMcE81Y3FGUmlkUVVNUWhVZUZNWHVOVWdFS3R4bkdJZ0ZieFBi?= =?utf-8?B?dnd6OFd5UHQwUlAxK3U2cjZta09rdDgxRnd4dHJzTzQ1Z3ZrN2xYNmRhNGpC?= =?utf-8?B?bFpFT3dFc1hmL0Ywck1FRU5MQU5ZeklyL3hjQndsaWVpcTVkOTg2L2hMWldC?= =?utf-8?B?RHdCUzRVRElNZkpSQmZQUGlvYSs5dXFOSTNMZzg3QWFNd0htVUNMOVpKdzl2?= =?utf-8?B?bi9NRndZTHp0QzFTREV5aHZ2VVVuTjZSUUxtcy8rcGx0dG9MakluMmt4YUdi?= =?utf-8?B?TVdlNXFkODQxWHlaRlJrZElIekVGWjMwT0RBQTZQUlFyR1Y1L01PcW1mQnd0?= =?utf-8?B?ZWIxZlBnQ2RwUkdhTWpGem5zbERmbkdhQjF5UGFoeWFKSStITkNHY1V2S0la?= =?utf-8?B?bTNtWkJXa3FBSEZsS29LYjBTNkNzL0hJUDUwZ0E1Mis2Nk5wS0N5VFpFOHl6?= =?utf-8?Q?OvtFJTmXcyF4/kok7zWsaRPee?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4930464d-6555-435c-5581-08da9f9215e8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 07:38:20.9185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TvwIhSxjp29KN7+3ehIfXjoDd5tgA9PKRYbRoCrZNmcMs8wmI/rios+rJEzy83tef9Mv6eBneFKlVtvXm4YO5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8137 On 23.09.2022 14:10, Ayan Kumar Halder wrote: > On 23/09/2022 12:02, Rahul Singh wrote: >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset, >> printk(XENLOG_INFO "Xen dom0less mode detected\n"); >> >> if ( acpi_disabled ) >> + { >> create_domUs(); >> - >> - alloc_static_evtchn(); >> + alloc_static_evtchn(); > > Can the code in alloc_static_evtchn() be guarded with "#ifndef > CONFIG_ACPI ... endif" ? This wouldn't help the issue, but at best code size when !CONFIG_ACPI. When CONFIG_ACPI=y, acpi_disabled might still be true, and hence the function may still need skipping. Apart from this I'd also consider it odd to have a non-ACPI function have such an #ifdef ... Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 07:42:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 07:42:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411444.654375 (Exim 4.92) (envelope-from ) id 1ocilH-0006GT-3V; Mon, 26 Sep 2022 07:42:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411444.654375; Mon, 26 Sep 2022 07:42:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocilH-0006GM-0U; Mon, 26 Sep 2022 07:42:43 +0000 Received: by outflank-mailman (input) for mailman id 411444; Mon, 26 Sep 2022 07:42:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocilF-0006GG-Lf for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 07:42:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2051.outbound.protection.outlook.com [40.107.21.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc14c3d5-3d6e-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 09:42:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7007.eurprd04.prod.outlook.com (2603:10a6:803:13e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 07:42:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 07:42:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc14c3d5-3d6e-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c28lD02pMYbIKtwDFqpdYlccudgLKmaTYqMY6UDXagr5YBSL1tcHJYt89IEyLAkYtliu1J4Vuo54qHUzkZRoip7Dr8TsYBCS1SjbRexRGCBCMV9UM46OAao90S/YO/IhWuygeNS4Ec67SeD5wSw6k+MrVHOJzMxXQ0kFe/zahEhH+wJivCDdP8Isd5Gf4nw7bKcfYMXv4uCdrXho7CH8mfvp8O6/mHVnYWMJHlCwLZj466uCABbxxbFflL7+60dCzJtXzRzHD/kNR8hl8hCjebu/cbMSD9G7BVs+2Tz66VmtHrdCAZg4uDANkWJnEAijG1bLb/UlFUI7pva59uicAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrl+0t4HVCxfUUCLQFD4YZwU3HuGZkCOs0gxsxWPuI8=; b=EkuniNpaJaRC8VRBQQQv8fOLY2RJ2PcinLZ7+tLVaKi4LTXla7Ne3esnKWcT46SlVumUtMGrQcAuYm4v+0b4xJbpR8EOEEyTV8ScQQhOWWK1LzXl9gT+QeCj5KJs99KUq8CzbHvLVkaQNKhTITn4j1hVD+zFbdvDwouz7LIsSbUJxpPUlDCA/qyZPeX4UtDvtlGxGY0vLzDZsalQ9PJhGSYHG5GqHg5lrHLCTCrvsuSLi3KSeZNB3nd9lsyc6DFbsFk6MG3pyfILjKK53cm8wYY/4QlA/ZlBBdJa4M0MoFZ0varS9sAx6bu2P03Xh2TNDyEmjHdijNti/DvQtE/TLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xrl+0t4HVCxfUUCLQFD4YZwU3HuGZkCOs0gxsxWPuI8=; b=ArPE6y/9ynT3CM0bDCJP7gFfweA7HMUZLTA9fMCLqFVOM2FujOPuXQxRBEV5+CnS1MVMrNOZipTh0BT9stCQqZs8z917z5dLYFKckQPdrunREphezwyUAkxjBEkeCmdOlSvlD0SsdqX906mfUm9RyzrzqpTZJ9HTuIv902uT+X3mt2eeLb16FjAJlzvNXvTOLxEz9nTE+C2LxapUo/RquEsfbo5odG+cnuVGJbMRT8Yu0VhFPgF7Z1V2G77ARFe3gHffTdYNJKx30FDBSwfmPLMzVsJ2VjLGGo5tie8GzMi2nK6EhJ0PswBHME3L21d0cm+lAuHGRFORD1kIidmEUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <467b204a-1aed-4cd7-b401-8ff01b8d343a@suse.com> Date: Mon, 26 Sep 2022 09:42:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 01/12] xen/arm: add cache coloring initialization Content-Language: en-US To: Wei Chen , Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , xen-devel@lists.xenproject.org References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-2-carlo.nonato@minervasys.tech> <1369a435-ad92-3bbd-60e4-27c1e49c1bc9@arm.com> From: Jan Beulich In-Reply-To: <1369a435-ad92-3bbd-60e4-27c1e49c1bc9@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0160.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7007:EE_ X-MS-Office365-Filtering-Correlation-Id: 5949fdce-819c-444a-412b-08da9f92af04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v7SQvpVLN0EIiWDEy4jqqbcWsaYtaszzq1nJ1YgMW82lJJG9gYeVPip77KXNRtFUp3KNjNaLKYc8iOCHQYhGf/yJWxT0xLL3V5NwrL0YVdFIY7IuQXe90z9g2HJ8zkwNGptHfJ3dyu6ASpBElYGeJ/8c3ZldCqz/oJ2xYaLHc29AZphf69Yjmt4/fKKVFYRTMGNKmLNpkYle1ntk/a6Feumq4XRBqY1dpXvoKZLGYNZnthhiSig9n09mskQcboL7ZjDLpEt5g+zg8kWO5v0juVpiOzO/9j5n64dSDOXuH9ib1PBt7LQ1FId4pVQDKnJcw/tuIPZbMfrChP2URQ3xQW2vebWEJjFtXmNTM037uNep+08kj+dolBub4On2XpAZZrpz92Jcy/m2EJGrQ7tO0H+0cVQ6YP5MWgsBOL4v/CjbXlw0PsOtgwNo7v/DZbKYDXRQI9SR3XvI7DnMdiGGMDqdmPhN069OA6/o/gyFKEIjqrfVqrlhwhHVCCoUp62fSXxlpU2PHvpWrTpjKvmxkgMEebOKHFX/5yE9GhYVDiY432tgFVTOdRbzyBh4A560ED8ya1HT3XS9JmIOAydW2O6yGT2+ni/RiToz2gFA96Dr55REIJi47yzGVnF5paNoYBM/IOTvuokqveGmSY6xaOdNRo1o7SOiPXcagkIHW4tYx4Yi2xPSR5wSSNF3RjgoSiV79mZMPsLSmHJGVOVAFeH4tWVEW4lR1qabhzF/k9hVeT0WagyF9M57vy/dnP1Hssnl1lJpXX1Qo8I9cslnzuipI2ESUEvUjA3T00J4r5Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(366004)(396003)(346002)(136003)(376002)(451199015)(31686004)(110136005)(2616005)(36756003)(31696002)(2906002)(186003)(86362001)(4744005)(5660300002)(8936002)(7416002)(6512007)(66476007)(66556008)(41300700001)(26005)(4326008)(8676002)(66946007)(316002)(6506007)(53546011)(6666004)(478600001)(6486002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qk5mYkFTcXBJN2loa0dmQUc0VEp2L09ZQzRrMElncUgxeUEybll5cXhSb0sr?= =?utf-8?B?STJHZHpRU1FraGFCLzRsODZMZEpjaXZXWCt6WXRaOVNFVnF6WmRZME83eXB1?= =?utf-8?B?UDRUZUNiM2Q1ZFZ2QkFrMGxEY2ZSQ0o2ZFNUdW9VdFZZRngzNlNNbmxHSjVS?= =?utf-8?B?R25tMjJvbWJtd2pnYTRYcGt6TmlKeG5NMUVibHVPa0dRaWxCVmR1allXRDNI?= =?utf-8?B?QkNBazNObVB6Z2ZQMlF3VGJUU0lPcFk1VHI5ZnB2QUgyTHVvWTh6NEVSVGNm?= =?utf-8?B?d3VtbU85NVdheDcydkZZaTBsZnpxOWN6ZUNRZXB5Zk1zSEdOVlFyQVVPcDRG?= =?utf-8?B?UjJqZTU1c3FLWDBvU1BuRWJHclhUcSthRjEwNHQ3WjNjV2hRVmlFd0Y1bzd2?= =?utf-8?B?TkZPclFUZHNmYUpqS0lrd3g4Y280YktFaVBaQW4zOUhDWGZVcW5jNDBSZHBE?= =?utf-8?B?c21NQmNxODFmUkwvUWZZRlM5Q3lYMzdTVlBkTHpjUkxCVlFVM3JpcVJCdzc4?= =?utf-8?B?eVFRQUttUUNobDFYRVd4a0JrbXRvVFdTdmFSdEJEODd4TW42cjNTL0xXQWVF?= =?utf-8?B?djFCT1lwb2pZRU80WmdoWlgrU09QajNEY1ZyQ2ltRjQ4Z1dBNUJEd3M5KzZt?= =?utf-8?B?NWJpOURyQU9mL09SVnBBWWRiako5aGxVZ2Jqb2hzOEJvMzVrWGRLNnEyYnlS?= =?utf-8?B?WldzVlJ2VmM4UHhvUVgyZDVOQVBmYmtScERLQkVaV3gvQU9uS3ZicFNMOFh5?= =?utf-8?B?SjYxbzhYWDNQREtHeXg2YWRsVTJJYTh5STV3YUxacTJIbjhGQW1HbXRFdWVs?= =?utf-8?B?UnJSdWNycTZIa1FYVUtZbC95T0VuOFJZWW5GejRVWjRSVDB6eDRJdDAraXRB?= =?utf-8?B?MjdMVDVFeFRzVjhEYkJCN3RvMHEwbERFUGpsdDlFZ081TmRCY1B3THdhMEVK?= =?utf-8?B?WE44UW9tSWowT21CMkhTMnYvV0FnSDh5OEtyQUZsRzREZHM4eCsrSzd3a3ZF?= =?utf-8?B?RWcwclZyd1N6bnkvUnF3OE14K2FNaFRnOTNHQTZOVlAvZC9CTjhwN1lDa1hD?= =?utf-8?B?UnV6THlBampWK1pjcGEzbE12S3orT3ozUmsxWktIOG1Dbjd4bHFUZ0Rsek5x?= =?utf-8?B?VEtxN0ZSaGszR2RtcHAxSDZjK2tyaFRDVUplRmREWWd3V1IybG82bS9NWm1G?= =?utf-8?B?cDg5d1hFTC9oYjNLc2xIYm0yUGVYaGxRMWRlSEo5S0QrQ2Y0RjA1eVNJb1JE?= =?utf-8?B?ZTNCV2dNSkw0Y2RaTXRhYVhqQzY0dDNFT2tZVWl6Tk1kclh3eTNnUnJRSkQv?= =?utf-8?B?dnJLV2FocTBTRW1ZUHVOLzVVL21QNUNSTnl2MTYzSGZlR1RVTUk5RlNlTEVJ?= =?utf-8?B?M203aks3dXQxaUxxRDBPYklZR0tlUE4rVFdWR3hRd1ZtRk53WCs4U2FudElk?= =?utf-8?B?TWlmV2xLMkRGM1VxRW5Xd3ZCOEVkcWpYamc3Q2UvZy9DZUYvRndzY0NQN2J4?= =?utf-8?B?UUhiUC9yZDdEM0IvQW1KUDdVbUJxQzV1MWUrMytZVWM0ZTNRRk9VMWFzUlor?= =?utf-8?B?enY3UFB5Rys1T29TSVRRWDMwamRIV0x4WWtoYW45My9pUEhJUVkwd3g5VE1p?= =?utf-8?B?MUt0Yzdib3FXYUUzZldjZ1c1RFlFL0VYS2trVzdZMkJTTkx4YW9JNWtHZ3ow?= =?utf-8?B?eWF5UGRYV0RRRWI4V1ErNmFoWVV6U3Y0ODlscTZ3elpGVmtOK1hWK0lMMzBv?= =?utf-8?B?bHBOcGNyV1MvWmUwZFVDZUpaRGVGSS9rQ3gyOVpjZlFiRnJGakdoREkxSTU4?= =?utf-8?B?MXptcy93b1l5aEs4RjNrMkJQcVVqbDhpQW5LaS9iRVBoMklqUnZGa1RJb1FO?= =?utf-8?B?TzZIdkpEOWhsMzRwdFFrT2xybkxqWUt3aThLYm40SVJYQXRWdjB3d1g0dG9F?= =?utf-8?B?eGJOV3NrYk9leUg2dzJEb2dFRHRzdWpzc3RlcGQ1MFJabHl4SnVyb0c0VDgy?= =?utf-8?B?b3h6dVV6bkw4UXpGMzdjc0FybXlvR1g3cnNmSC92QjB1OEYxbXNNTFJuVi9m?= =?utf-8?B?WGxCMUhhZWpoYTJ4Z1VGcms3Vm9ON1hpRG1ETlphSE1GL3lQQnRJSEtqVWZn?= =?utf-8?Q?y+s25zeHeONh7wK0UseKfraVs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5949fdce-819c-444a-412b-08da9f92af04 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 07:42:37.7773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wf1rqrOgnu0buPQGS25BRXKflYmsJke3qW3/IICCqeH3JZpGUEsGOIufEsuOAF52dhXNDXSq0iKfQ8/trRBiKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7007 On 26.09.2022 08:20, Wei Chen wrote: > On 2022/8/26 20:51, Carlo Nonato wrote: >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -131,6 +131,22 @@ config ARM64_BTI >> Branch Target Identification support. >> This feature is not supported in Xen. >> >> +config CACHE_COLORING >> + bool "Last Level Cache (LLC) coloring" if EXPERT >> + default n No need for this line, btw. >> + depends on ARM_64 >> + >> +config MAX_CACHE_COLORS >> + int "Maximum number of cache colors" >> + default 128 >> + range 0 65536 > > Just curious. Why select 128 as default vaule here? Is it a classic > implmenntation for Arm64 cache? And the same question for the upper > bound 65536. Going beyond that: What is the meaning of the user picking 0 here? And isn't 1 merely mapping to the allocator we have, i.e. the CACHE_COLORING=n case? IOW shouldn't the lowe bound of the range be (at least) 2? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 07:53:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 07:53:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411450.654386 (Exim 4.92) (envelope-from ) id 1ocivv-0007mP-20; Mon, 26 Sep 2022 07:53:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411450.654386; Mon, 26 Sep 2022 07:53:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocivu-0007mI-VT; Mon, 26 Sep 2022 07:53:42 +0000 Received: by outflank-mailman (input) for mailman id 411450; Mon, 26 Sep 2022 07:53:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocivu-0007mC-0Q for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 07:53:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55df8309-3d70-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 09:53:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7697.eurprd04.prod.outlook.com (2603:10a6:20b:2d6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 07:53:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 07:53:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55df8309-3d70-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJAtT5SoD9oYPQI7n1C2OSnKeR8l2yRpHEKM7xkCQDlktfKy3H5n6OiMFo8FxWos1IzoRX0e7SaiLbYZI+eKEdysE3rOoIkC9KXXfK3Wy3zy/4h2C2jngX6rJyzwKciR58vl4XJIk8faObM1Ra+Tx3yUJHCQm1COZgGJB76u0Fz/Zi4r3voD6+VYJt5uBiKZSs96gmfwBuBEN53sZN17q+G1ky30lXtdJj9f1CdofV54OJmtB2mp5/oNu6pwoVvh0QvrFq8WoHCtMy/rI0NtVXjFiC7YbuWO0HECtKalhtAjDTOZnc1NHvOA0Wbmu043/Gn3y8Wo/yUoiSzSqwVkCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k62p6jkfsfC26hBs62SH/S2bFQ0x7b7VQkMJ0Tz02ZU=; b=OlnRVNWH2XVMzLdDNGySYQY5Cvuu1ksHOo/AhLdO5BD+aY3M9oMuQkRsDS6wiLN3Tjry/KP0L/NZaGxDfS1P70QysIfAjj4KRSg0S5NOvk3bqMJwvlt4gG24zFreGqMdnBvoBw8TLYlO948mfQ11utoSrAw66bTs122/QvkeP6Juq8NYKwsZdkVREt8sX1wk2Fnw6H27wBrL2C0XKgQkSpKTkCvKiB+3HHhIcPCPH4tuJGZSmbmDOkJi7C6vKKc/eqcWg0r/N70hB3U29VZYt4oxqTSJZRRnY+HBMmlOz48be3lRexdJFHdIvNpf7MZhgtIKm4ssqxewnXgzlUsw9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k62p6jkfsfC26hBs62SH/S2bFQ0x7b7VQkMJ0Tz02ZU=; b=1KPkJCcyHrNsGlkR25DS89VxLvguNMdD8xi4lybJYgj13IJUSu/fOtY0Kjn9U1O6QQDh9uU9/G74sNXbkq9VTt2jy56dxBXO8ppC+OgsdRtVdX+8+7OvUYSvb7MMcOerwTszv2cH2jMqU3hGftIjHW+qh0lt56V4E7rUWrEk3eY84rfec3mqOVfFH4x/yv1qMm5ZrBmPACVJCUgeEe5C26da6JqtCb/b9VYrj0ElvA/7ZAluCbJqjuT1bMASkvgs7dnP+J8bu59784HZ6Kh9IncDPUxaxRRNj3UtHN8MJRFJu5RPVzSX8nwh9w01B56Kwnk20IC5SIhSI/KLCRFYVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 09:53:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session PVH dom0 Content-Language: en-US To: Juergen Gross References: From: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7697:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e37afc7-6ea2-4ef5-0ea5-08da9f943917 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: woudAyEdQEZzHOK4uy8WLxJtx1zw1C3zJKM1L++oZqr434t/5UQCSYbp7PsK8VTVLtMifRndn/zh4uSvwbHZMkkqNeFw9lmudJNeerPZjOgs8/pM3460SYlV2299xwszB8n2GQ5saklUXEj7Y6ADzG/7jUseYTOpTBQ8cAVbywHcCP4uTXtVg2n5AWyk4LF9i9hK4VMQo997hoC0MjNPAbF6NWLfpESrGg35QmzEgnIJJ3MLfMvpb+pBQ++Tl8S64vh1kpUaFtasyWL887a/W3KUfWkbqjdmoqE7Rhksq03jNTlc2Onusq0UeaY+zn5GbZf2vfX8MhMZ+dNAf/0eKqiPtvL1W8IQ2J4tFRKGv4naVzbwHyHqDeqlCiGzsuClF9wRo5gHzDq6U8f+3IQVSBPPyxamLa2LETmN94Pd9Ok/a/sLwro6lC5pARwxr2Uie51CeO5yO9bjXeB0Wun9V2UR0Ozi+nMKNlPzX2CsNsXPYZOCSkCzL5LcZZjoqMTyJvbwuzDHCgguWmsu69qSU43cP4IL+Gg6o6rzYsKDa76sIvR1QC8CSKNlK+RNJC5FGJYth6ylHZd6qY2Ips/adKsHSs7XWbd2xymWWxYXuYjuSmrwmV1tW+bxPfvJxBMRLbiy/ogi8GGL74ivx1WDujSUqj71vIVa3RP2mxdpWv4teUA3VViPoWsuz9SNl4kX7+VLPoH9UO+oJLaN6Cja2K0vsyhpHonjWMeF4a6AORyz8KyvIVpDKl/uIoD8KBu78FjC3PH13ELLfne/aW/EQtW3qtUmMfnlBTS9rB9u9Xo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199015)(2616005)(66574015)(186003)(38100700002)(86362001)(31696002)(5660300002)(83380400001)(66556008)(66476007)(66946007)(6862004)(4326008)(8676002)(2906002)(41300700001)(26005)(6512007)(6506007)(6666004)(37006003)(54906003)(53546011)(316002)(6636002)(8936002)(478600001)(6486002)(36756003)(66899012)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFJYbVJiVjFTRjlpM2lzeXV3Z0tlNHVYVEtDZ0EybWR3bVcxTDd1ZXo1UDhQ?= =?utf-8?B?dzFSV0RpcTdYcDFEWStrNU9LUjZDOXZmTVR1V3lGSnNzbjdIOENGTjREZGly?= =?utf-8?B?V3ZPWkNhWG8xL2NXTUR1V1ZnRURxSHBuRklhSnhjV2ZTQlB0WlVZTFZ0c01O?= =?utf-8?B?UFd3YUdySXFtdUVHSlI4WlVESHhpSC9wVzdaMlk2bFRsUnh1YjVxOHI0Mm43?= =?utf-8?B?Uk5BUW40V0VDMk9ac2lTUmxnaC9ZdzRZUTBBN0pmbThQUmtyOGJka01TNVA3?= =?utf-8?B?ampZd1BhVldkS2MwS0ExYVNuSFBIL2d6cHdYaHExd0ppdGc5SHZ3aUZSOHlM?= =?utf-8?B?UWkyNWdaQUt5UCtocm5zeHhIalhXYXFETlJ2dDhlNkFpYWV0UXFySU5sVW9v?= =?utf-8?B?SGtpWFFVdExWQ1ZLRW5OK3BpME9lU1ptV1hKZTlnSWVQSmpvZVUvb2dtSGZF?= =?utf-8?B?ZU1ZR0txbFEwVHJMUnJIWFZGZ1pIM08renJBSFVRRlc3RVdIbUMwYmZuSTZl?= =?utf-8?B?ZUhpZWJFYkwyeXY0SXQ3bjlLUzRuZUQrcSt4dXF5QTRzQWtBS3hMend5Ym04?= =?utf-8?B?Q09GNHVUZ1NDVHJyNWN6QVlCZWJaRmV2Yjh4dkl3OHJ6QmwydE0zRzhiZ0Zn?= =?utf-8?B?UWE0Y29YdFo4LzRkL0ZJSm5ZY21ST0VyNm1hTTk3bXdVNzdUOHd4Mi9CM2VY?= =?utf-8?B?bnNVTnVzOUJXb056akg1QWdyVVVhY3dhTlVLamdCUmt3Q29kdngyN1B2ZW1I?= =?utf-8?B?a0MyWWRBQWJSOUFVcVpmeU0vOXZVeVl0OEJHZFRpZWNaTUhhUVdxWDg2VGdo?= =?utf-8?B?L2pzd3l6TDM3RVpUbklXUGRScFc4SFIwdGdBTk1wdFVnTTZobVpLbWpzNTR2?= =?utf-8?B?ZnUyd056V2Qva2NOeFZOM0cyVkFZNEhia0plMDc4ZWVOLzlSOUZkcTNiOWpp?= =?utf-8?B?YU05aGduS2tod3NVZTduZmVrVWJ5SVY5eDNVTFNkb3NJYzFjVFRFS0FMVzVO?= =?utf-8?B?ajhNbndxcXRtck02T0M0QnBrcTdBcWdsRmppU1QrR2hPYmdCMEJYOFZYcE1x?= =?utf-8?B?eGE1UlZsdFZGSG1HS2J1Nk85TFQ0Q0VPaEJjZi9YQXVIZk9qayt6Q3F0SGdu?= =?utf-8?B?M3p3Z3Y2OGQzNEdWZ2RVRVBTRkp2OEFoOTlieHVBRnZEZHJmd2Z4ZFJUMndV?= =?utf-8?B?SGo2b0lRZGgrVXMwRlJpYmlFbk1hS09FUW1GWmdCWlZBaGRvb0hIYXg0MnRW?= =?utf-8?B?R092bDFsRTU1M3M5WUV3OTdnY3hRQ3hCaGZCL3pHZnpUV2thaU0wb0dMWXk4?= =?utf-8?B?N3JVQ3hzSmxyRktGcVRNV0lnSmdVZFFpYVYyUHZ3dXpYS2piSGNIRDBTZ1lu?= =?utf-8?B?TEY2OUpXbTlrT253NUh1a2t4NlhzcVZ2TG9LVmRJcGhpM0JTMEJETTVhcUZs?= =?utf-8?B?cWFURFRWdzZUcVFXY3BaNld2M2VxWnlhTHBkRU8rMTVmTXJkNnZGZnBVQXNP?= =?utf-8?B?ZWtkaEtoRlZzdzNqeDM2TDZadmVLTmhvMTlIbDA4SkJZVFVNaFo5WlFSY1o3?= =?utf-8?B?QXhSNE1YWHdCSng5bVI4amFzaHJrTzdKUDZIV05FZncvSkhubkMzMHFKcEg0?= =?utf-8?B?K1JJejFnMHQ4Y1o5ZzNhM0lCS1AzTy9ndkU5ekhkbDJTUWZBQ1NzeXFWOUNz?= =?utf-8?B?RDIxVDg3Nnl4bTNrZSs2bEVkWXE1RC9wNTFEVXdRMEpiS0I0azJCckxRYUJy?= =?utf-8?B?Rkg0eFB5bW1qbnNVMnlyWHRiaUxlZHBTSzh4Skx6VmYwcmcrcGFQV1UrMXVR?= =?utf-8?B?aFVQdFJZRlRzMGhvYVBkSEVVRkpINHhEMStkdmJldFJSd1lmVDB2ZXlLSkF4?= =?utf-8?B?T1hHYzFjV056Z3FuUTlKN1FLWkZkdVphdUFRMnpBOGtwa3ZSZGM3c1Z0YUlx?= =?utf-8?B?akNoS2JvT3lLVC80Qm83RExhOXhhNXhTV0pZV2NkekFoZWw4ZUtsTThRazJq?= =?utf-8?B?VGYwWDJDcFZMdjhBdG5ISGtSeDVzUUkvNndZZkM3VlpUY245SGtpTTdMc1BP?= =?utf-8?B?ZFhacEZTVUgzVElYbHVvMWx6WWFIZXB6MVBJWmo0NjNlNnE0T2FCMnpER0Nw?= =?utf-8?Q?E400Cwf35smt5wAhIuqaGaiqw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e37afc7-6ea2-4ef5-0ea5-08da9f943917 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 07:53:38.9228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bXcoOcTC5gvVIb3A504voBto3HS4DXlwDJhv/guJhcvpVyf2iobH1JEb1aP6rV7cmXSC71rRSym8UX4wZ2a6cA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7697 On 23.09.2022 10:20, Juergen Gross wrote: > On 21.09.22 17:53, Marek Marczykowski-Górecki wrote: >> Session description (by Jan): >> In the course of working on an XSA I had to finally get PVH Dom0 work on at least one of my systems, in a minimal fashion. This had turned up a number of issues, some of which have since remained pending. Therefore I’d like to gain understanding on whether there is any future to this mode of Dom0 operation, and if so when it can be expected to be better than tech preview or even just experimental. > > ... > >> Jürgen: PVH dom0 performance? >> >> Roger: it's bad; mostly relevant is qemu interfaces >> >> George: only for safety certifications? performance penalty may be okay >> >> Jürgen: hypercalls can be improved (virtual buffers?) > > Some more thoughts on this topic: Having hypercall variants with physically > addressed buffers will help, but there is an additional complexity: what > about hypercalls with really large buffers (e.g. the bitmap for modified > pages for guest migration). In order to avoid having to allocate huge > physically contiguous buffers for those purposes we'd probably need > something like scatter/gather lists for hypercall buffers. Not sure. I'd rather see us add new (sub)hypercalls for such non-standard cases. E.g. the bitmap example you give would be amended by a new flavor having the caller pass in an array of GFNs (perhaps, as you say, with further indirection to deal with that array also growing large). I'd really like to keep the common case simple. > And those might > want to be supported in a generic way. Additionally: what if such a SG-list > would exceed the size of a page? The dirty bitmap of a guest with 64 GB of > RAM would already need 512 pages, so the SG-list for that bitmap would already > fill a complete page assuming only 8 byte for one SG-entry (which would limit > the general usability already). > > My favorite solution would be some kind of buffer address qualifier for each > buffer (e.g. virtual, physical, SG-list, maybe nested SG-list). So the new > hypercalls would not mean "physical buffer addresses", but "qualified buffer > addresses". By requiring a minimum of 4-byte alignment for each buffer (can we > do that, at least for the new hypercalls?) this would leave the 2 lowest bits > of a buffer address for the new qualifier. If by any means an unaligned buffer > is needed sometimes, it could still be achieved via a single-entry SG-list. While this might be an option, I'm not sure I'd be really happy with such re-use of the low address bits, nor with the implied further restriction on buffer alignment (most struct-s we use are 4-byte aligned at least, but I don't think it's all of them, plus we also have guest handles to e.g. arrays of char). Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:33:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:33:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411477.654405 (Exim 4.92) (envelope-from ) id 1ocjYe-0004QU-FO; Mon, 26 Sep 2022 08:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411477.654405; Mon, 26 Sep 2022 08:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjYe-0004QN-CU; Mon, 26 Sep 2022 08:33:44 +0000 Received: by outflank-mailman (input) for mailman id 411477; Mon, 26 Sep 2022 08:33:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjYd-0004QH-06 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 08:33:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed1c22ec-3d75-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 10:33:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3C1F022001; Mon, 26 Sep 2022 08:33:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C66713486; Mon, 26 Sep 2022 08:33:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bzQGBeVjMWNWWgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 08:33:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed1c22ec-3d75-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664181221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y6rP0yXpgcrrq7vSubzt3KTL5aYMu8qIC94GTh73U0k=; b=HsMqsfSC2i5kH9q+R7WNu5UaHovVO+XHWWi1ZAmsNe5sSOKfS+aKGWks4X7R6jQaVMZL8U uvZnlkd8kFja/ozLionREtWKlQLbB9inGIOJ51h5UOoRYxGFqjcb+TdZiMA1bPT0ubFk2G au7IaRQsME1HSAi02L0s+hLC4v/BmxA= Message-ID: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> Date: Mon, 26 Sep 2022 10:33:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: From: Juergen Gross Subject: Re: Design session PVH dom0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8wznQtuFLUDfP7ZKCaEBwT8C" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8wznQtuFLUDfP7ZKCaEBwT8C Content-Type: multipart/mixed; boundary="------------2l9jkCod0Tzd9bRIm3dbVX0I"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> Subject: Re: Design session PVH dom0 References: In-Reply-To: --------------2l9jkCod0Tzd9bRIm3dbVX0I Content-Type: multipart/mixed; boundary="------------uPP5skHFGdm6JveACLpENDp4" --------------uPP5skHFGdm6JveACLpENDp4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMDk6NTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMy4wOS4yMDIy IDEwOjIwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjEuMDkuMjIgMTc6NTMsIE1h cmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToNCj4+PiBTZXNzaW9uIGRlc2NyaXB0 aW9uIChieSBKYW4pOg0KPj4+IEluIHRoZSBjb3Vyc2Ugb2Ygd29ya2luZyBvbiBhbiBYU0Eg SSBoYWQgdG8gZmluYWxseSBnZXQgUFZIIERvbTAgd29yayBvbiBhdCBsZWFzdCBvbmUgb2Yg bXkgc3lzdGVtcywgaW4gYSBtaW5pbWFsIGZhc2hpb24uIFRoaXMgaGFkIHR1cm5lZCB1cCBh IG51bWJlciBvZiBpc3N1ZXMsIHNvbWUgb2Ygd2hpY2ggaGF2ZSBzaW5jZSByZW1haW5lZCBw ZW5kaW5nLiBUaGVyZWZvcmUgSeKAmWQgbGlrZSB0byBnYWluIHVuZGVyc3RhbmRpbmcgb24g d2hldGhlciB0aGVyZSBpcyBhbnkgZnV0dXJlIHRvIHRoaXMgbW9kZSBvZiBEb20wIG9wZXJh dGlvbiwgYW5kIGlmIHNvIHdoZW4gaXQgY2FuIGJlIGV4cGVjdGVkIHRvIGJlIGJldHRlciB0 aGFuIHRlY2ggcHJldmlldyBvciBldmVuIGp1c3QgZXhwZXJpbWVudGFsLg0KPj4NCj4+IC4u Lg0KPj4NCj4+PiBKw7xyZ2VuOiBQVkggZG9tMCBwZXJmb3JtYW5jZT8NCj4+Pg0KPj4+IFJv Z2VyOiBpdCdzIGJhZDsgbW9zdGx5IHJlbGV2YW50IGlzIHFlbXUgaW50ZXJmYWNlcw0KPj4+ DQo+Pj4gR2VvcmdlOiBvbmx5IGZvciBzYWZldHkgY2VydGlmaWNhdGlvbnM/IHBlcmZvcm1h bmNlIHBlbmFsdHkgbWF5IGJlIG9rYXkNCj4+Pg0KPj4+IErDvHJnZW46IGh5cGVyY2FsbHMg Y2FuIGJlIGltcHJvdmVkICh2aXJ0dWFsIGJ1ZmZlcnM/KQ0KPj4NCj4+IFNvbWUgbW9yZSB0 aG91Z2h0cyBvbiB0aGlzIHRvcGljOiBIYXZpbmcgaHlwZXJjYWxsIHZhcmlhbnRzIHdpdGgg cGh5c2ljYWxseQ0KPj4gYWRkcmVzc2VkIGJ1ZmZlcnMgd2lsbCBoZWxwLCBidXQgdGhlcmUg aXMgYW4gYWRkaXRpb25hbCBjb21wbGV4aXR5OiB3aGF0DQo+PiBhYm91dCBoeXBlcmNhbGxz IHdpdGggcmVhbGx5IGxhcmdlIGJ1ZmZlcnMgKGUuZy4gdGhlIGJpdG1hcCBmb3IgbW9kaWZp ZWQNCj4+IHBhZ2VzIGZvciBndWVzdCBtaWdyYXRpb24pLiBJbiBvcmRlciB0byBhdm9pZCBo YXZpbmcgdG8gYWxsb2NhdGUgaHVnZQ0KPj4gcGh5c2ljYWxseSBjb250aWd1b3VzIGJ1ZmZl cnMgZm9yIHRob3NlIHB1cnBvc2VzIHdlJ2QgcHJvYmFibHkgbmVlZA0KPj4gc29tZXRoaW5n IGxpa2Ugc2NhdHRlci9nYXRoZXIgbGlzdHMgZm9yIGh5cGVyY2FsbCBidWZmZXJzLg0KPiAN Cj4gTm90IHN1cmUuIEknZCByYXRoZXIgc2VlIHVzIGFkZCBuZXcgKHN1YiloeXBlcmNhbGxz IGZvciBzdWNoIG5vbi1zdGFuZGFyZA0KPiBjYXNlcy4gRS5nLiB0aGUgYml0bWFwIGV4YW1w bGUgeW91IGdpdmUgd291bGQgYmUgYW1lbmRlZCBieSBhIG5ldyBmbGF2b3INCj4gaGF2aW5n IHRoZSBjYWxsZXIgcGFzcyBpbiBhbiBhcnJheSBvZiBHRk5zIChwZXJoYXBzLCBhcyB5b3Ug c2F5LCB3aXRoDQo+IGZ1cnRoZXIgaW5kaXJlY3Rpb24gdG8gZGVhbCB3aXRoIHRoYXQgYXJy YXkgYWxzbyBncm93aW5nIGxhcmdlKS4gSSdkDQo+IHJlYWxseSBsaWtlIHRvIGtlZXAgdGhl IGNvbW1vbiBjYXNlIHNpbXBsZS4NCg0KVGhlIHF1ZXN0aW9uIGlzIGhvdyBtYW55IGh5cGVy Y2FsbHMgd291bGQgYmUgaGl0IGJ5IHRoZSBub3QgY29tbW9uIGNhc2UuDQoNClRha2luZyBh IHF1aWNrIGdsYW5jZSBJIHNwb3R0ZWQ6DQoNCi0gZ3JhbnRfdGFibGVfb3AgKHN1Ym9wcyBz ZXR1cF90YWJsZSBhbmQgZ2V0X3N0YXR1c19mcmFtZXMpDQotIG1lbW9yeV9vcCAoc2V2ZXJh bCBzdWItb3BzKQ0KLSBtdWx0aWNhbGwgKG1haW4gbGlzdCBvZiBjYWxscykNCi0gY29uc29s ZV9pbyAoY29uc29sZSBkYXRhKQ0KLSBtbXVleHRfb3AgKHNvbWUgb3BzIGFsbG93IGxpc3Rz KQ0KLSB4c21fb3AgKG5vdCBzdXJlIGEgYnVmZmVyIGNhbiBzcGFuIHBhZ2VzLCBidXQgaW50 ZXJmYWNlIHdvdWxkIGFsbG93IGl0KQ0KLSBwaHlzZGV2X29wIChzdWJvcCBzZXRfaW9iaXRt YXApDQotIGh2bV9vcCAoYWx0cDJtIGhhbmRsaW5nKQ0KLSBzeXNjdGwgKG11bHRpcGxlIHN1 Yi1vcHMpDQotIGRvbWN0bCAobXVsdGlwbGUgc3ViLW9wcykNCi0gaHlwZnMgKG5vZGUgZGF0 YSBjYW4gZXhjZWVkIHBhZ2Ugc2l6ZSkNCg0KRG8gd2UgcmVhbGx5IHdhbnQgdG8gc3BlY2lh bCBjYXNlIGFsbCBvZiB0aG9zZT8NCg0KPj4gQW5kIHRob3NlIG1pZ2h0DQo+PiB3YW50IHRv IGJlIHN1cHBvcnRlZCBpbiBhIGdlbmVyaWMgd2F5LiBBZGRpdGlvbmFsbHk6IHdoYXQgaWYg c3VjaCBhIFNHLWxpc3QNCj4+IHdvdWxkIGV4Y2VlZCB0aGUgc2l6ZSBvZiBhIHBhZ2U/IFRo ZSBkaXJ0eSBiaXRtYXAgb2YgYSBndWVzdCB3aXRoIDY0IEdCIG9mDQo+PiBSQU0gd291bGQg YWxyZWFkeSBuZWVkIDUxMiBwYWdlcywgc28gdGhlIFNHLWxpc3QgZm9yIHRoYXQgYml0bWFw IHdvdWxkIGFscmVhZHkNCj4+IGZpbGwgYSBjb21wbGV0ZSBwYWdlIGFzc3VtaW5nIG9ubHkg OCBieXRlIGZvciBvbmUgU0ctZW50cnkgKHdoaWNoIHdvdWxkIGxpbWl0DQo+PiB0aGUgZ2Vu ZXJhbCB1c2FiaWxpdHkgYWxyZWFkeSkuDQo+Pg0KPj4gTXkgZmF2b3JpdGUgc29sdXRpb24g d291bGQgYmUgc29tZSBraW5kIG9mIGJ1ZmZlciBhZGRyZXNzIHF1YWxpZmllciBmb3IgZWFj aA0KPj4gYnVmZmVyIChlLmcuIHZpcnR1YWwsIHBoeXNpY2FsLCBTRy1saXN0LCBtYXliZSBu ZXN0ZWQgU0ctbGlzdCkuIFNvIHRoZSBuZXcNCj4+IGh5cGVyY2FsbHMgd291bGQgbm90IG1l YW4gInBoeXNpY2FsIGJ1ZmZlciBhZGRyZXNzZXMiLCBidXQgInF1YWxpZmllZCBidWZmZXIN Cj4+IGFkZHJlc3NlcyIuIEJ5IHJlcXVpcmluZyBhIG1pbmltdW0gb2YgNC1ieXRlIGFsaWdu bWVudCBmb3IgZWFjaCBidWZmZXIgKGNhbiB3ZQ0KPj4gZG8gdGhhdCwgYXQgbGVhc3QgZm9y IHRoZSBuZXcgaHlwZXJjYWxscz8pIHRoaXMgd291bGQgbGVhdmUgdGhlIDIgbG93ZXN0IGJp dHMNCj4+IG9mIGEgYnVmZmVyIGFkZHJlc3MgZm9yIHRoZSBuZXcgcXVhbGlmaWVyLiBJZiBi eSBhbnkgbWVhbnMgYW4gdW5hbGlnbmVkIGJ1ZmZlcg0KPj4gaXMgbmVlZGVkIHNvbWV0aW1l cywgaXQgY291bGQgc3RpbGwgYmUgYWNoaWV2ZWQgdmlhIGEgc2luZ2xlLWVudHJ5IFNHLWxp c3QuDQo+IA0KPiBXaGlsZSB0aGlzIG1pZ2h0IGJlIGFuIG9wdGlvbiwgSSdtIG5vdCBzdXJl IEknZCBiZSByZWFsbHkgaGFwcHkgd2l0aCBzdWNoDQo+IHJlLXVzZSBvZiB0aGUgbG93IGFk ZHJlc3MgYml0cywgbm9yIHdpdGggdGhlIGltcGxpZWQgZnVydGhlciByZXN0cmljdGlvbg0K PiBvbiBidWZmZXIgYWxpZ25tZW50IChtb3N0IHN0cnVjdC1zIHdlIHVzZSBhcmUgNC1ieXRl IGFsaWduZWQgYXQgbGVhc3QsDQo+IGJ1dCBJIGRvbid0IHRoaW5rIGl0J3MgYWxsIG9mIHRo ZW0sIHBsdXMgd2UgYWxzbyBoYXZlIGd1ZXN0IGhhbmRsZXMgdG8NCj4gZS5nLiBhcnJheXMg b2YgY2hhcikuDQoNClRoZSB1bmFsaWduZWQgY2FzZXMgY291bGQgYmUgaGFuZGxlZCBkeW5h bWljYWxseSB2aWEgdGhlIHNpbmdsZS1lbnRyeQ0KU0ctbGlzdC4NCg0KDQpKdWVyZ2VuDQo= --------------uPP5skHFGdm6JveACLpENDp4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------uPP5skHFGdm6JveACLpENDp4-- --------------2l9jkCod0Tzd9bRIm3dbVX0I-- --------------8wznQtuFLUDfP7ZKCaEBwT8C Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMxY+QFAwAAAAAACgkQsN6d1ii/Ey8y mQf/VHPRvIJg/xrDuS+UaKeh0cuwxRY4izKaINM6p1k/krWlOFc2w5+h1fevvjutPAR5Nm42Zq1G 2xAskPF8fS8MCPcZVPeXw2ohrQ5W1z+2Y3otr1jN4eynS1fr+wARfw12OkZ+JGoP9oKxdBoxZdtz 5QWtfRjDrBhD9tWrIJ7hp4MHOBkPw1C1nmZpABSCrNQ+5eAfhtUBC3YANMvO27fq4nhpJleQvinF GKgL8DLVYd1gv97x5B2OWe5k6VBeI/phfy7dMhWlABbDbehB2u6JbbF5mD26We+LWhnhWjK+wDEJ hZut00mXLwiETTIxbHCa6eEP+/7yppKDWaXpV+i6cA== =t2bc -----END PGP SIGNATURE----- --------------8wznQtuFLUDfP7ZKCaEBwT8C-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:38:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:38:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411483.654416 (Exim 4.92) (envelope-from ) id 1ocjdQ-00055H-0s; Mon, 26 Sep 2022 08:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411483.654416; Mon, 26 Sep 2022 08:38:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjdP-00055A-UP; Mon, 26 Sep 2022 08:38:39 +0000 Received: by outflank-mailman (input) for mailman id 411483; Mon, 26 Sep 2022 08:38:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjdO-000554-JQ for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 08:38:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150040.outbound.protection.outlook.com [40.107.15.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c94a5e0-3d76-11ed-9647-05401a9f4f97; Mon, 26 Sep 2022 10:38:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8248.eurprd04.prod.outlook.com (2603:10a6:20b:3fd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 08:38:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 08:38:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c94a5e0-3d76-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VuNLff+fyeulQkHSajmKkQcun0+enQJYq3qT+q8yFibY6o9Pr8I8F3Bz+FzvReqK5bTSilv+TOd6EgrOThKZMZRoog8kHuJpX17T2jmRYPl/Y2dlcHzuUvGTxfmFvMU83lY1ekORE7f1B3gSysO1FXNBvBl519EwbLPpa5vEy6qTn32i2u4ZQJk6BnAhVKKNyGNCHgj5zRBoHRsxtI/dC6p66g1DHyV2y8nviGeVXoZcJSo7ZZPi+57apLjTEHdVVRFynCtH+rJJD5Ws7lZGYKAx2FWN/UzZ5EX7A+OyMg1Uo0YQjfB1YvWLnI29RmnnUwDAgPRP9Py/u6jhYi8eyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8L4m36y35zpCO6zDxpAOEsE3tVCWNopsMi11EoMNLHc=; b=idTnMKD6bylfO0xsvt+CudZogPmf5Zyohu90ENYfMKwLZwiQcKdVyNddD50ltdmn08QzdIflMU0QfwAYHyKQiOatuwjp6H9PdE3R81BpOMcvwN1RV1n6T3ReERysPVrnh1ejifwWHP5Sf2qCA/NBOwjqMKqZE53OsEFzxikoovTzKJonRrF2DS4DeTkSjZX2x3q3bu6pkX5JQAQhGJSyg/EwAKtFvj5Ub1FSDHqZtvlHVVLQtEDoL90o1dUL+tdTniwUq/ggkMffJs1Jm51QUQ/ppXJDN759Jc4j8PtNbBraUkr4t/8P9GOtt0EbU1IFvjQb+tGKyEzzIkyODtJOug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8L4m36y35zpCO6zDxpAOEsE3tVCWNopsMi11EoMNLHc=; b=Gs/5pjwrG+oddNeA4OhsDLCj2/cYAq0dZ8Ia0JCenBoR8ee3RN3G3fCqvrBTWAcNzENC7oIFuZqpOsQK/1kIpTLKYDdSZLbMcFp4vi3/CoAp49EKjVMFfQQV0/XIBDrHZNlTzFV2egp6ZwQEr+o9HYgo3bQpvgGI7XWsDNWxiuA/doXmCuovAxzFH6+DE9xj3rT9RgAK/MzbdwEOKsIgMEuWEofIA6KloPB660C0GuSjYugxbWkOA9EJj5dvMcucAZ6p9cp7sm2H0J5l9T7xkxnbIWSZhmJq8paBlq6Q2VQc/8/s2ynmAsMxA4lICcOgTs4uEgob+7whRsskPnHBzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 10:38:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/ept: simplify detection of special pages for EMT calculation Content-Language: en-US To: Roger Pau Monne Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220923105648.12587-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220923105648.12587-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8248:EE_ X-MS-Office365-Filtering-Correlation-Id: fe9c43f1-5cf9-4ac5-13da-08da9f9a8014 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mCxyDfniH80K3GV3tySk85p7LNJ4lpYKyZ2NReV7G3UpCNXMeioa/lO1F5L81XQS0E8qF7qoVhSxuut2NSP5xlYoGoFLhfbRP7b/KkHrd5fdettKgpU+iRhoeS9uyZEqhjl7Vb0C81C2dtC1gPDMUiv3pYMvXfSivnPUUI72XsaXiv/jqvg7yAmnkgu3imIRC3u8ZSPAsxvo80GSPZ6sTOwzgjKN4t0YMqPHyZsHPm6TgREqYIX2Q3IRR1Mj3kuMPg9sEnWVJkBLoabj5fVELKpgFk0aspBr8mcndTP/4nyxV9v0zTGfidutnYcVFx9dPqyVaLWmA/ldAeZCfvb7TaSvYrYhPZYQRmCS1cs1H4j/TqHRkr6pHS82dGeM3rgY/Cf9mrdOEx9viMWc8c79JVzewl3wUdVRlcBLe63IDvrBlnIw7jkhcfWwWuUjvquZ+HgODgevMCOql27mTKiu5PvoXusGJScBAagDH09nW+1cyCBgNLk0y0P+RWiEQLEJS1uk67di2dpeOJG267ikzMZtPbwj1pXIQLgfLuvEQ2NZh51zpeU11OQCBe5Kbvh/8xJ8rpjYAvt8jlWx8u/LoHpiR5JER91+zAOQTHScoGM17aZdtWc3az8OfBDIVBhtG0tWVm/QUFMblkt5Nwn33Z90Bo9kmzI3rGGFeae3dX+D/4Bkw+aZ7e+5ERqVSD0HnbfROB+Kg+npix2eieUSaERjQycYw8027yzSVnWPo9bKduocjsmoKgPARj2bwdaKleRYZB8T0BpfP1ymA+wTwUDRTiRmxMragjnscWxuitw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199015)(2616005)(5660300002)(53546011)(6506007)(41300700001)(86362001)(6666004)(8936002)(66946007)(4326008)(2906002)(31696002)(316002)(6916009)(54906003)(31686004)(6486002)(478600001)(26005)(186003)(6512007)(36756003)(83380400001)(38100700002)(66556008)(66476007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmRveEg2dzJoZzFaMW5mL21NQUFTSVUvK2pqcnFaUzlyYVJoamVGUzB1TGN3?= =?utf-8?B?QldOalVkdGRxeFgvVi9zNzlZcHpDTlFtYUR4WnpyRFlZTFhndnQ4S2MvM2lm?= =?utf-8?B?ZWRnS2s1QnhIMHhobUdaTEVUTzF3ODJxcEJPVm83T3ZxaCtha2N3Z0huVzBN?= =?utf-8?B?NmxZMkltQkpTL3l3c05HYi93ajZJcDloWEd2ZVlwM2FNRUE3MDBCVEtpUENy?= =?utf-8?B?U2VVU3YzZXg1MjluRG1lVFhmLzU4R2hwSjYwSzBWNnpIcmRWNzJmVlB4anlS?= =?utf-8?B?c1JvU3J6b3JaektMYXBRYlRpRnUxZFYrVDJkbnJRalN2amV0OUE3UnN0WWFz?= =?utf-8?B?ems0L3B5VzhOaWxYRk4wSW03MmhUWlZESnQ1N2FkN25rRkdzbVpGWHBlZU5k?= =?utf-8?B?QnJiN1BPUHhMRmloMlpkTXBwLzZkWWZBaWJ5UDJRdTlxR0dJVnJOSUJjN3U0?= =?utf-8?B?U3kra2VyMnlIa0xCOHVublRWamFZR0JuMDgyUmNOWExmMnNyWGVSVGt0ejU2?= =?utf-8?B?K0lkZTRJVnVqQ3hMUHE5TERpZGllaDJ5RUlzTVRoM2hNWDdva3ZwdHFiTzJN?= =?utf-8?B?eUpQNnhPRlVGcyt6ZnYyRGlFeWpIUFVBc0JMdkhVQVQ2ZGFvSVpNL0xIampz?= =?utf-8?B?OEwrcExhbkZGNzNQR0cwZmNRNS84UkZCNGRpUzBkS0JSZWp6VXB2c2NIb2FC?= =?utf-8?B?Mk1iVEs3enFNOU9pU2lDclB5a3FZYmJCMHFhRU44VFdRblhBTHp1RklUUFFG?= =?utf-8?B?ek1kL1JlLzZGTUlYSWFMTUlUTkZRRVFnSFZSeURYSlBLNHpaSDdHQy9wcGJp?= =?utf-8?B?RHp3WWx0NUxLMUdGWnVYNUMxRFhCRURwalVRTEJjRURpT2dvUFJ6cDdzeHFS?= =?utf-8?B?cUlzUFo2OEZQMGdqL3REUkE3L25qZVg1akwyRUkva2lFWTFGekUwdVdkc1FR?= =?utf-8?B?NmRsWkFrZmdyZTlqb3dTb3F5YnNSU2c0TjFEbnlaa1BUSGhTVjZDMWhNSFZ2?= =?utf-8?B?YnVyakRibDBzU0xOTFlKcGhpZy83VW5qazdCaFhGdDZ4WE1ydmoxM0JHUjFD?= =?utf-8?B?S2duS2RHaGx1aXBYQmc2dkszVnlLK05CUzNPS01paWNRek40elNlLzNFVEdG?= =?utf-8?B?NDRkeHBWOVd4Uk00aldaeVJaMXF2U01BYzFDYjRjYUJpdi9raHR4SUE5QlZQ?= =?utf-8?B?L2ZEcXRDdnZ0WmI0cVkvTStEUExuWWdlVzhmcXptZ05ieCtxaFlOSmY1djhn?= =?utf-8?B?Mnl4M2dyZytkR0E1TStLVGROSUFKZ1IwOUFUQlR0cGZUS25IOFA1dkxoaHNp?= =?utf-8?B?emJKbEdwWUNMTFNHWFdzZ0pRZ2hRZlZWaWQxdjJBNGFMejdrWnlYZGs0Vndq?= =?utf-8?B?Nkxwcit0WGNVTFgwb1JHazBpditpc1h0ZzlZckFFM25YbjE3Q0w2VXNEY3dP?= =?utf-8?B?dHFKTEwvUU9weUk1RnpWN3V6cGUraDhVVjF0MXJRbHlxSjJUUnJueEF6RFRu?= =?utf-8?B?bE9Wb3g1dDJueCt2K3hOQlRGRFdzb05sOU1LdGFDYXRFR1JiN29NRVkzN3pn?= =?utf-8?B?RjVrUUFQZ2Fqd1F5RVNDMXFpNFJ0QlJBZXpCbEpZaGYrd1F2V1B6ak9kbWI4?= =?utf-8?B?ZHdRaUdSMUc2ZUh3OFJqcVlZMHk0aUt3MHY5UGVzRm9vRnl3QUZMMFhUeW9p?= =?utf-8?B?cTdHU0dvTWhEeURQQkVaNVFrY3BRZjBlc1UzOUJZWGQ1blBPMEk1L2N5d0pO?= =?utf-8?B?U1VZSEtHSGVCT1Vqa2ZUVHRhYVJmWlNTczRnYkZPTndOTGk0VmV1NWtsQ1NN?= =?utf-8?B?SjRWRk9CVFJlSEZ0Si94OGNBdUdkQVg2cVhYdjdsOFlMSWFXVnJHOXA0TnU5?= =?utf-8?B?RHNDZldWTVhuU0k3Yi9Wem0rRFluQ1dSbkdwTThmRHNtTURkM3dCdDBJb2Q2?= =?utf-8?B?SkpYQVpHVnpuQ0tWS2ZianNhYnc3djJrQndrWW5kUzJYdW5SV2dwRHJDZTRr?= =?utf-8?B?SCtrT0lqTUgwamN0MmtBQklIZVhjbjRpQTZiYjMvT3F2Zk1KV3BLelNSMy9B?= =?utf-8?B?OFlyRVV6VW5jdC9ZNTJKNVF5WGJmZmFodjhPQ1pXNjFmNERBNVNtSVNiRDlW?= =?utf-8?Q?xvYNSeig/A1arZ/S7cAp66OMb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe9c43f1-5cf9-4ac5-13da-08da9f9a8014 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 08:38:35.0019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WsFkt2NaQZIrblCR+GC9Coj1Snjvp2DJBOmZMItH7uMcrCIkdN0fzkQaw5V7saWN3Q59UguqhGxhCpgcNTAZ9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8248 On 23.09.2022 12:56, Roger Pau Monne wrote: > The current way to detect whether a page handled to > epte_get_entry_emt() is special and needs a forced write-back cache > attribute involves iterating over all the smaller 4K pages for > superpages. > > Such loop consumes a high amount of CPU time for 1GiB pages (order > 18): on a Xeon® Silver 4216 (Cascade Lake) at 2GHz this takes an > average amount of time of 1.5ms. Note that this figure just accounts > for the is_special_page() loop, and not the whole code of > epte_get_entry_emt(). Also the resolve_misconfig() operation that > calls into epte_get_entry_emt() is done while holding the p2m lock in > write (exclusive) mode, which blocks concurrent EPT_MISCONFIG faults > and prevents most guest hypercalls for progressing due to the need to > take the p2m lock in read mode to access any guest provided hypercall > buffers. > > Simplify the checking in epte_get_entry_emt() and remove the loop, > assuming that there won't be superpages being only partially special. > > So far we have no special superpages added to the guest p2m, We may not be adding them as superpages, but what a guest makes of the pages it is given access to for e.g. grant handling, or what Dom0 makes of e.g. the (per-CPU) trace buffers is unknown. And I guess Dom0 ending up with a non-WB mapping of the trace buffers might impact tracing quite a bit. I don't think we can build on guests not making any such the subject of a large-range mapping attempt, which might end up suitable for a superpage mapping (recall that rather sooner than later we ought to finally re-combine suitable ranges of contiguous 4k mappings into 2M ones, just like we [now] do in IOMMU code). Since for data structures like the ones named above 2M mappings might be enough (i.e. there might be little "risk" of even needing to go to 1G ones), could we maybe take a "middle" approach and check all pages when order == 9, but use your approach for higher orders? The to-be-added re-coalescing would then need to by taught to refuse re- coalescing of such ranges to larger than 2M mappings, while still at least allowing for 2M ones. (Special casing at that boundary is going to be necessary also for shadow code, at the very least.) But see also below as to caveats. > and in > any case the forcing of the write-back cache attribute is a courtesy > to the guest to avoid such ranges being accessed as uncached when not > really needed. It's not acceptable for such assistance to tax the > system so badly. I agree we would better improve the situation, but I don't think we can do so by ... > @@ -518,26 +517,19 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, > return MTRR_TYPE_UNCACHABLE; > } > > - if ( type != p2m_mmio_direct && !is_iommu_enabled(d) && > - !cache_flush_permitted(d) ) > + if ( (type != p2m_mmio_direct && !is_iommu_enabled(d) && > + !cache_flush_permitted(d)) || > + /* > + * Assume the whole page to be special if the first 4K chunk is: > + * iterating over all possible 4K sub-pages for higher order pages is > + * too expensive. > + */ > + is_special_page(mfn_to_page(mfn)) ) ... building in assumptions like this one. The more that here you may also produce too weak a memory type (think of a later page in the range requiring a stronger-ordered memory type). While it may not help much, ... > { > *ipat = true; > return MTRR_TYPE_WRBACK; > } > > - for ( special_pgs = i = 0; i < (1ul << order); i++ ) > - if ( is_special_page(mfn_to_page(mfn_add(mfn, i))) ) > - special_pgs++; > - > - if ( special_pgs ) > - { > - if ( special_pgs != (1ul << order) ) > - return -1; > - > - *ipat = true; > - return MTRR_TYPE_WRBACK; > - } ... this logic could be improved to at least bail from the loop once it's clear that the "-1" return path will be taken. Improvements beyond that would likely involve adding some data structure (rangeset?) to track special pages. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:40:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411487.654427 (Exim 4.92) (envelope-from ) id 1ocjfO-0006QR-ES; Mon, 26 Sep 2022 08:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411487.654427; Mon, 26 Sep 2022 08:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjfO-0006QK-BO; Mon, 26 Sep 2022 08:40:42 +0000 Received: by outflank-mailman (input) for mailman id 411487; Mon, 26 Sep 2022 08:40:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjfN-0006QE-9Y for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 08:40:41 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e573ca00-3d76-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 10:40:39 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CO6PR12MB5441.namprd12.prod.outlook.com (2603:10b6:303:13b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 08:40:36 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 08:40:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e573ca00-3d76-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyKA7S9l3p+Jvj6hdpV9KJjaKiMH+WXABQAt/+0cfOFp7xY8QKqABO08Pmo5nfH5SdjduyMAqZcsz7oPFh/xo5V+o1McawejbwQH6rvKzLP1bBj8opj/EtR5C/Qw91HzKLwnrj2pfb1XowY7DuCu1xNzlBY5lPTiwIF/1oI4IFUA43vYRJGu/AxArgjoc2BIH4YYZjYk6PzBZ1pof5JbQ1bo1C7AfjOLiUxI4M7oFkbY38/2++C1psLqVocJW0bpofMrCOPzOqnkA+rQ+yMWwP7YHp1otwRFZ1Jf1H54E+tSiHQIC1mN5UmnMKoWJgjLq3LvFt4nWXlKAPNsDcE1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/6oxB1QN6CCqPGKi84u4N+pEruVVtZFmB1mmYLrlZP0=; b=bQoOhB7j4zu2ZgsxqgCGiuhqODbNsOTHvvkyMxg2GIhEZwwYxBp7WONTEm8TMnlGJY8IFsKicvOuj5FQozol8iQX9G2j1rfK1E40Tz+uCOJ78ZzjxhEQ1/lh4N+0QrL8+UlmXY+XvehUDsEV1wTiXEcWh0usOyBdTM9lYKuoNT5uP76TkhrvdlVHcDqQUHCuMV0Gc0sl3fdvLgZxk6b0dg484J/qxUnNrbL7pMx1q+7z6TL1ewJCJjoqu7IprrCQAYhGPPFRLiijZS8/CJUB2CLruV7iZwYy9107UBDibuEbtW4xQuQ15920GaqMCmlxXdtpL2JYMrfo0yEqDbViUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/6oxB1QN6CCqPGKi84u4N+pEruVVtZFmB1mmYLrlZP0=; b=cqbjuFDlyOcNvT//oNEEaPL+PAXZtnFtKfwoJcmv6NDLUfeqOiOF9yAohbJ4LNuDe2iGhw1eGBS80IXjCpDUucB7skl+KBoY140sCv04qUEtl3ts5aSj5RSBzwHIsXII18/wJHgn0x+EekuaajipxSbx16cVyoXBu7y8AdhDloQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Mon, 26 Sep 2022 09:40:29 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Rahul Singh , xen-devel@lists.xenproject.org References: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> <000f22e5-1628-a937-0871-44ed498e1b26@amd.com> <63b9a66f-6ee5-819a-5e37-33eaa8418986@suse.com> From: Ayan Kumar Halder In-Reply-To: <63b9a66f-6ee5-819a-5e37-33eaa8418986@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0303.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::20) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CO6PR12MB5441:EE_ X-MS-Office365-Filtering-Correlation-Id: 94ffc70f-b8f6-468b-6253-08da9f9ac80e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qy9NZcnXlNme8LOSS+Qc0NO6ZIj9zrOFdlCsm9B8RVvregIy+mB6aPn2MOEKPUZlFzTxVYOIFV858ARzc7m0Y+FIYXmfOoT8thFzYqD+8DPvNnl3xqNqnJlRyGSLwRBpU1EJhC9JjowZXiWoryCaIzTc5lARKlGlpR0AcsGNmGyYxNsyT8LMdzxLFR38cZ4vU+u2QfeoV4dZ0OKUKVrvvTe97X2Y/oK134c2q55XAvGpocfqKq1E3QvNAyc8wVWpze462Rp+H9Rt2S0dl2WSljhC8NdrGKKmYT4VWQrG53+QGSluCAxCZTDpGpCvIHptGfTFEBQAMyzsBndQ/ZJLbj6Hh2NSO+wiS3xknQC83yYAxM+/qvXYGmEHG9m16p4zhnHC4ISyrnSBtB/aEBr9wp7G30r5KDtOfcBov5iFYrgD568SiU3lMAhbcwFN0O5ayZvaKA/c1E1DUJ1G6nClBGqMJbg7Ypl2aOss45M3DvRO8HnAyv694KlmxCO4NXgv2ixsktEP2lVfoKDF3Yzl084sy1tjmr/LpjejcZDbAxCgnfL4GIq8hXMrszxKbOsAk6mTHWWpcRWwDTHQK8tg/0Jr/35mYxHsSRnbbGWZ1jliUJvkiAxWrL0YmtyUjeCTnz+GxGL+fKYFaBLxf/GPq2TkR1WtVg0wbJ+UAF7PlxGzlg9wSlDYd/Qkgg2g7KI+5LSdgNqyM4ZxeyisNXiuEgrUDiJyZ8Kr5eHB4vfvXMwyTd7cfg77hsIDvXm5x0bVEFL5ycp+h3syxnzdZxh6p/hFeLZ06WkC/12HGocnjrY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(2616005)(83380400001)(186003)(38100700002)(5660300002)(6506007)(2906002)(8936002)(53546011)(478600001)(6486002)(41300700001)(26005)(6666004)(6512007)(4326008)(66556008)(8676002)(66946007)(316002)(66476007)(4744005)(6916009)(54906003)(36756003)(31686004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cCtWc2hXSnVIS3VHejVOaEdMTUw2aFR5RHZSNmZZcTZnVldhNHlqYkE2K0RM?= =?utf-8?B?Z05EMXVPZ3lXRVBLbEFMYklzQXdGY1p4UE9OTWRjdEwrSU1BSlhjVVQyMnA2?= =?utf-8?B?SU4rRXorS3pvN01IbWtvM3FlR1RDU0tCMXVUaGNOSkxHckFQVFUySnQ4Yllm?= =?utf-8?B?VzE1MkZZSFNleWVPNGo3dnBpdmlkZFk0aCtJYVA5R2NHdEFoNXRVNENHSXFk?= =?utf-8?B?VG56N21VaDRsazNOaXkzVjlqZUtBbndtZm9hOEVqTHYveldmd1gvcVorOVVI?= =?utf-8?B?WUNtRGlVRjkwRHBTOWRxNmFDTDhLNTVNVjhORlRNSXBuS0VuWnJzK2hJdGRw?= =?utf-8?B?SzN5citRK0NqOFUvRWVqMVY1a2p3UDN4K2Z0UEVTdHo4b0hWdlJsT0hOeHJp?= =?utf-8?B?dHg4TlB4dWwzckkxUThUSHJjVHluOGZ1VS95M25wck9XQ21taXNydkttdHF4?= =?utf-8?B?ZnNodnpNaVBTckxvVUoxbmFzU1MrdWpNb0VKcHdVb3JoTkd2Y1M5Z1I4RDZu?= =?utf-8?B?ZG1sTHlDUzJqOXNGODMxNWl5LzVHR2haVnFJSmZablcrVlF4NWlKb3UvdkVz?= =?utf-8?B?M2N4b29HbCtCWTdhNmh0aVJ2OEhRTTlRb0FkOEVsbTQvTlY2QWVzbFY5cmtD?= =?utf-8?B?NVVSa3dNUUdvY1lLay9YQTdtTUhzcGMvSE02OVRPdVZXQnltZjRLY3dFanBB?= =?utf-8?B?WGNURndQQi9vdlBsb0lFc2kzdjR6WXN2TEZzZ0VOSzIxNG5saHIyMmFvdnRY?= =?utf-8?B?a1N1M3ZOTGJTcEdlRmNvU1ZqVkw1WFZIakt0SVFUdkVNWjAxaDdOMTVrMUdu?= =?utf-8?B?YlpWckNvVWdLamVmbTJrQk1YOTE2MXVBNlllVWdreTdoaEFXek14NWhtQ3Vn?= =?utf-8?B?SmVrRHRXRTVVbFd2N3JRY28vTXlwWXhkSWRSSGdySFIvaEo3UFlPQ25JS3BM?= =?utf-8?B?S2hMZys5a29lWHdmcWxJeHNhTzJ0L0FEVDNsOU9USFJ5NzBTS0VQa1NzOXpa?= =?utf-8?B?UnZSV2tDZlBEZDFtblpPREIyRlNoU0JyMUpIeU56RjlEVUpzSHluTzdLWDVF?= =?utf-8?B?UmtpNHNHS3IzOXBBQnFIdUNxb2NqN283elIrRTl5bS95Q0pHYWt6bEZWZWIy?= =?utf-8?B?bFd3aVg3MkZtYXQvM052c2F3eHRHUGFYM1lnenZtMmFETWZvMjQwVldoU3JI?= =?utf-8?B?SUhkTW9lekhORHZTYWZsNUNhTmhjQ08wNlB4TXdZSU5uTlA3eTlCblA5aUhi?= =?utf-8?B?TlZKZHZZSXphb0o0amw3NHhrZE42YmJWVkFiY1VOLzArSzllQ0RuN2I3aTJH?= =?utf-8?B?ajR2Z2I4dFhQbUpBTnJ0UkFUNFpYSm5DYy9NcE1FaVFmRzFqcHlzYlVCUEdP?= =?utf-8?B?ZWpDWnpubzdaa2hCKzFCUWZybTBmSGJ4NE1uR0VzZDljeE83bUdHNThNbTRT?= =?utf-8?B?eUJEdlBSQ1BFOVJhVDNuUnZsc2RrYnFURlVrMm1UMEVYc1BhNE01Z0J3WHUv?= =?utf-8?B?bVh2dkRRajdSVWpTYVRKeVVGYXZ0b1B3RTZSZE8vQ08ramVJNnE0YnlFaG51?= =?utf-8?B?ZUpOOGNJYVJqVEtMWEM3UitURkt4MkhNdGVDTXprQ2c5L0NnWXM4QVdyd2hp?= =?utf-8?B?cG4vRldNY01ROFVrc1pzOHNPTUVhS0lPalhubFc4OVhoUUpKZHJ1dXJyVTFu?= =?utf-8?B?NjNiMS9qYnVsQUNWNVM3MkRZMWlneW1pWWlFam1WVktjZFlKOUpMR0lJU0VD?= =?utf-8?B?SjBZL3hldTVxQWNxaXBmd0Q3L0NZdC9FaTVTcURRV2ZncXhLdWR2b1NFUkhQ?= =?utf-8?B?VnVoekl6SXY2Q0czZUxpbHdtMkFpUjJlZjNFTHRzcWw3TWw5a2dJbTByUm0r?= =?utf-8?B?V2NNM244Ymlqbm9XOWlVcHVOQk4vSXE2MUo2NXVMRzFMS09ISFpwbUI1RHox?= =?utf-8?B?cFhoUzVGanJYb05yOUdRZnFmT3FUN3Z4cjh3VGV1R3FYRlNFdmlDbkdvMHJw?= =?utf-8?B?bHFiNXBXUER3cTg3UEpjdDU5WUUrekkxZFVPQm5GSHE2TEhNeDYvUUlkQ0Mw?= =?utf-8?B?SFZPUEJXSWNBOXJ3Y2Y3YWFTQlBuOXcydi9uZHZnNVlkZlhZYTBhQi9sSGhM?= =?utf-8?Q?KNlJ9wehNFTQw3yoQSjky6iBC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94ffc70f-b8f6-468b-6253-08da9f9ac80e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 08:40:35.8543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NXDgUV2dUdsSPP/okyr70ZUQ3a91IWxeFUQpdt8Smuke6qt8M4qx41jRjufDybB777gaIKaVPrcRNLlDogm9lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5441 On 26/09/2022 08:38, Jan Beulich wrote: > On 23.09.2022 14:10, Ayan Kumar Halder wrote: >> On 23/09/2022 12:02, Rahul Singh wrote: >>> --- a/xen/arch/arm/setup.c >>> +++ b/xen/arch/arm/setup.c >>> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset, >>> printk(XENLOG_INFO "Xen dom0less mode detected\n"); >>> >>> if ( acpi_disabled ) >>> + { >>> create_domUs(); >>> - >>> - alloc_static_evtchn(); >>> + alloc_static_evtchn(); >> Can the code in alloc_static_evtchn() be guarded with "#ifndef >> CONFIG_ACPI ... endif" ? > This wouldn't help the issue, but at best code size when !CONFIG_ACPI. When > CONFIG_ACPI=y, acpi_disabled might still be true, and hence the function > may still need skipping. Apart from this I'd also consider it odd to have > a non-ACPI function have such an #ifdef ... I think this makes sense. Also Rahul's previous comments looks reasonable to me. Reviewed-by: Ayan Kumar Halder > > Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:41:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:41:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411494.654438 (Exim 4.92) (envelope-from ) id 1ocjgZ-00074k-SJ; Mon, 26 Sep 2022 08:41:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411494.654438; Mon, 26 Sep 2022 08:41:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjgZ-00074b-PQ; Mon, 26 Sep 2022 08:41:55 +0000 Received: by outflank-mailman (input) for mailman id 411494; Mon, 26 Sep 2022 08:41:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjgY-00074V-Pm for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 08:41:54 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11aa3af1-3d77-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 10:41:53 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CO6PR12MB5441.namprd12.prod.outlook.com (2603:10b6:303:13b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 08:41:49 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 08:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11aa3af1-3d77-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SX5eax7kLne2lvsqUE07e10zMehzayLVe3mUgglgISEKR6ueyAVwAy/6ya+9PoB/08QUodjjfCMknLGzZZN6cGxxZTBGLl37Mpf1ADWzJ2JWwGekjFJJxxlstQWg4c200Gzz4kpT9Umk6hdGtPskuRsDZB3GYFwCVY6QMCu7ygzCzZc0lL45H32WUxavx4BkVbXFjDIK7qz/npNU72gHvPpf65S+oV3K4P1GexAGE+Pl4FlixiQiLcNuRuq1+FokicApTbVE1+7MHdQ3P64gdUr9Y+iY7Amv86ODO68Pc4Hbexkrt0xnC2R5fY0l/GNznZWF/4zjyyGGi3XmS5OZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CmnPbBvRwJJ0v6/KydytTfPjn46lb/PXbnpqMrg2H10=; b=knDEEIAnDIio9WIPdu3qwtCWSgSp1Ug8a+QR9xhpW5keigEYCAsAXf4j5X3TH7+nztWwxqIUM9iAiHFHvniyY7WRZGHw4XlwFuXqoaXzx5y5fz5w7iePBYVSa4K4C3SqJkX4aOxGYx+kzfqkDwCWIm+2mWu2fCaI3zgbTG5cKTmU+soRxr0ck3q5hZManVcjk0hDY35jWzixC+gKHpQKPL3hnC/gI7qLXoy/uwYl5WRkAUvqJq0tUEBbtHswEYyYhMg/ELbWuNQwHwNE/wuXT8mcJX/T8M6FA9r0CFbASlDHVcE0ksjpuOBduTgi12/czln3adgxQwXx+IbuqC4TiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CmnPbBvRwJJ0v6/KydytTfPjn46lb/PXbnpqMrg2H10=; b=ZrUbgIN2WK1YYY1ASs3rp25wRssGW+6B2Hpo0oH05WqK3xFuWaQIuOBhlDkxHb/Y8wF1sE9AwwhdtzN/A/6gwmjTwlrO5G+ye+xeB3ySQRNkWO7Yo2HcmLg3mTUoUIfgoNbf7BTehf6Pe3RzRGS+9PG9F16k1FWj0ldKioaYlfA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <93fe747d-b2ce-4d8f-b574-ad773f3dc9f9@amd.com> Date: Mon, 26 Sep 2022 09:41:44 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] xen: Add static event channel in SUPPORT.md on ARM To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <02a4499694dec9fd48791a2d0c24a0d450b907ac.1663928523.git.rahul.singh@arm.com> From: Ayan Kumar Halder In-Reply-To: <02a4499694dec9fd48791a2d0c24a0d450b907ac.1663928523.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0299.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::16) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CO6PR12MB5441:EE_ X-MS-Office365-Filtering-Correlation-Id: 8060ac9d-0a3c-4e79-de84-08da9f9af40e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g4OzeOfwOn7FNFhKGIt6/ySbSVDYKg8ltVPqEYNdfkU0JVXh0Df0ThXgxkDQLMHlkgVaEQlyEh5YKXhLzirCYCZtj6FLkHDq/lXuvnOgLeTti6S33hm8zl1b6lIiE2BPyz1h43l/Fma3+LJ+OPsmHc7cw5dB+iupZvds3S22gxSu4TLpb3Aoz+zI0iLNPPCXWfsLOMHlifgWLstLy8k4rlK5mKrKujGfsqmJjtdCICLJWVXtXjpo60/zuRqRTKmUSrySTX5NzE37jwsMt1hD5/SAYjJDjLB99LvmtEVJ6tr5uQxosEniCm42IP4WGwyvBDHVFIyrHW0yg8aG6gvhOaR9QNYp6UOgTsaKOc2KnGqUfPHLMbokCgkXT1zuyCx8m2rL67i3H1+ujEwGQkVvGD91UWSzeoTALb9VzjUfbRrXhwuEyrk0Dor2deoO1HnozQjjEuQRpFwqsYCkg84wwnKKwBSclsmDtoBDouJg9NYXIQ8ysBTZ94OGuksgc09Bf95anaJ2SoNusqxwswhxQnvwm0qGzNo+0VfUtfw7pc6qJyMPy6iPtLxx2Th9H3RPLW0baWJTQrmtWNQsiam6O2NT71F81gdK0Py7a5DP0yCXJNdMO9ILrTRZMM2UQ8/P/RpLyacc1nTF/G/e+F+XpD/Wok2aQmwt7wNWkvlyjF3NPK9Z8rX9tYjloLLNTfrdwxwcP2NNwROieXvCqIfUQByymcS5rL2I7Qov8P0SYEEYpd7AuugHTq/Q6uDNXDI9yU1wK2UsMarwUieqdWPMCcNN9bhDJpsYjjumG1FLg3w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(2616005)(83380400001)(186003)(38100700002)(5660300002)(6506007)(2906002)(8936002)(53546011)(478600001)(6486002)(41300700001)(26005)(6666004)(6512007)(4326008)(66556008)(8676002)(66946007)(316002)(66476007)(54906003)(36756003)(31686004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG9GRGtwd1dQcGw3aGhrM1VReWoyNHRENURqU0J1aDgvaEZvRTFCUjhHTGtY?= =?utf-8?B?ZVdOWUJoSjBkYm9IUHNuZWJFakEzZjNnRmJsOFQzRDN2SXlmNmxRNXMvTElr?= =?utf-8?B?OCtPWWtNaDNOUHZnTnpUck9aMys3dWt4dmNyQUdSeFV6cHVpZXRlTm83NHRQ?= =?utf-8?B?WW1IUUF6emlNb0thaVh6VC8va0hqVDJINVNOSzBEUnkyT3ovTWJrVlhWZFg0?= =?utf-8?B?Sm1TSHVaQ2pvMFNXSld5R2E1cXZwZU9yaVAvNWVRR3JZOUVhbWZta1IxS3Q4?= =?utf-8?B?YTBpdG5uRUdOdHBWZmtwQi9oUzNHbEJiOHc0MVhPQnpNZVowTklXSGhKTTZ5?= =?utf-8?B?UHllRVB1eVpjTDNYdnF3aCtkLysrR2VTSHh2ZDZnNGhjOTdRZ2dRN0JtVHdC?= =?utf-8?B?VlZDMi9GYlNmWVpTcXZTbkVKUjVMWldSbmdkRjJaUFZPd1hpOGtWTGNUWEM3?= =?utf-8?B?WWp1bTlPRHZDWS9iYi9NMFNzZVp4TUMwbElZbEVlcGZoZVhTUlZZSW5zbkcr?= =?utf-8?B?Qlpaa0VPR2xxV2x2TDM1QjRaZ1IrRVM3ZGZ2emE1RW04Rlg3cXFIak1HSjc5?= =?utf-8?B?UXVMTGw3OEhjeXNnY3JGV1ZoajNzOWp3Ny9yQXlCblk1VUkxd0VBTzBLOHZ3?= =?utf-8?B?NTllMnQybVpSWkxsVzFqVndoMmY1dm1mUTVnckNlSUNYWTNkZXJ3VEZ1S2ZT?= =?utf-8?B?QTV1K1JDYUMyeFowNjAxLzhmY2xtc0F6NWNLYWhzTG9JeE0rYmQ1amdRTnRU?= =?utf-8?B?SlNlQ05QQTE3a2Z0R1JQanhZcER4UXJmM1F2M01pSk5ocm10Vk80NlhVbXU5?= =?utf-8?B?OUVibTBkU05jYytEZThWYk1ZbHFLY3JDTTQyWXdLUkRYYkdnVGpSN3NkTi9I?= =?utf-8?B?c1ZVRTRab0ZycFBUS1dTdi9rNGJrSlIxUHhtMHpGRkhVbzFwVUJqTEV0V0Iz?= =?utf-8?B?dG9mVHJUeUpzWk0yejFjbDNRK2xJQXJEMFFSM3Bpb1BqNmNJaVlwNjFDbDJG?= =?utf-8?B?dFRjVk5xRGRGZlJ0RE9BenZIKzRJMTZ1VFBLWXgvc3l1TE1KMkNPQ0tCY2hQ?= =?utf-8?B?VTFGZ1pHelpOdUtualJEYWFqWGNybm5YTVNtWXRxSW9rcVhSdUZzT0V3YkdQ?= =?utf-8?B?aHZJRUJGdmV4QzBoa2dqbTdxcEtDOFpiN3VDM1VuZGQvUHU4dngyd0pXQTZM?= =?utf-8?B?OHU2bDJvQldkTVQxUUFJbGY1L0VPNGk3bWZ1aElqdlYxRVpMTVBGRUt6cWt3?= =?utf-8?B?QmhScUtaY21jWGdtY0t6QnBCU3YyRHY2Mkw5eEZNb1lNakJ0SDhoclR5QjR6?= =?utf-8?B?V3drcitkdUNieG9mdmp4NDR2UnFTbW10bmxZQjFqa3RyeHhZVWxpZlQzUjZB?= =?utf-8?B?RFdicG5oRTJUZkRxQXpPYnZUYStkVGJjU1JIUDRjUHoxYjR3TlF5MzZ3dS80?= =?utf-8?B?bWlpNmQ5aGRLNVZIRHE0OVZSZkVTU0lGQzJBbGFkZVd1Q0JjRTAreWptbEg5?= =?utf-8?B?NitvYkRyenNaeXRLTUJ3NGdNK01ZOEpOQ1RyQXlRWng1MmhLaC9YUStXTHRR?= =?utf-8?B?ZkV4MU5jMG8wK2lRekZxaWp4cFdmZFl5YXpkNG5IdVpzeFNFL0Q3dFRST0Zm?= =?utf-8?B?cklGdC9PWnhWTGJCT0RNTENKY0NjbnJzcmVVQm5BUjZERmVNVDd1ajE4cE0x?= =?utf-8?B?VFZKaWp5cDNURllaeVQya0s0RWEzZDcyWWN5dkFuN1lJSmgxZmpOdzZTK1pR?= =?utf-8?B?T0t1cVJQODFuempBL2V2RDBXMzJNZmwrQmtDNml6NkwrSDYzMnFYSDYvQ3Nu?= =?utf-8?B?S2hWOWs5cThkNGVXWkdxa0toWmhEZ2dCS01NVk5nN3dJSGJoKy8wZG9CcU12?= =?utf-8?B?TXpvSHVmMEZheSt3bjBMb2tLVnlRWkR1SkJQTVBhV2ZUQ04zVVNBOXdyb3Nu?= =?utf-8?B?bGZuSC80UW5FWlBhQzYzVm9sRkluVmVKZjBpRm9DZTE0YUsra3VwaCtWT1N1?= =?utf-8?B?S3p5OE50UFJRTXMxM0tIaVpLN1JIaEM4WlFvcjZBZ3p2SEduME0zMEIzY2ND?= =?utf-8?B?NjkvL1BIZ2haWHVqZGg3RHhHb2RqQ25xWTlieFVLK0pMOVhTMmxhdG5FaFJu?= =?utf-8?Q?zbFD8xqBLOtMDipS5Mm5rCFFk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8060ac9d-0a3c-4e79-de84-08da9f9af40e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 08:41:49.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0CAimJ84EoOXuzFV+XcWL9XXPpNtwyGuJXf5tRQzc5FrmN4+4oNGMCdfuZJZR2Ow1+gUxXojNnQs6RlKvkmAyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5441 On 23/09/2022 12:02, Rahul Singh wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > Static event channel support is tech preview, which shall be documented > in SUPPORT.md > > Signed-off-by: Rahul Singh Reviewed-by: Ayan Kumar Halder > --- > SUPPORT.md | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/SUPPORT.md b/SUPPORT.md > index 8ebd63ad82..29f74ac506 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -922,6 +922,13 @@ bootscrub=off are passed as Xen command line parameters. (Memory should > be scrubbed with bootscrub=idle.) No XSAs will be issues due to > unscrubbed memory. > > +## Static Event Channel > + > +Allow to setup the static event channel on dom0less system, enabling domains > +to send/receive notifications. > + > + Status, ARM: Tech Preview > + > # Format and definitions > > This file contains prose, and machine-readable fragments. > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:50:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411509.654448 (Exim 4.92) (envelope-from ) id 1ocjp9-00008L-NE; Mon, 26 Sep 2022 08:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411509.654448; Mon, 26 Sep 2022 08:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjp9-00008E-K8; Mon, 26 Sep 2022 08:50:47 +0000 Received: by outflank-mailman (input) for mailman id 411509; Mon, 26 Sep 2022 08:50:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjp8-000088-6j for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 08:50:46 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47debb80-3d78-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 10:50:33 +0200 (CEST) Received: by mail-ej1-x62a.google.com with SMTP id z13so12535940ejp.6 for ; Mon, 26 Sep 2022 01:50:44 -0700 (PDT) Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75]) by smtp.gmail.com with ESMTPSA id bp24-20020a170907919800b0073c74bee6eesm7741593ejb.201.2022.09.26.01.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:50:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47debb80-3d78-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=A0qgMDFYsoa78aA3RsU1HvtNp2lW2GL4Em7N6j4qBc4=; b=X0QK+lUFovTPaojtKjqx5bk6BFUz//9pOxKjK1AHurcZNPBVop/odOew3rKj7XSwkJ SQml1FB6JVmSeypmp1LLp66+cDodVmrK13J3N9VkcA4J9O/43ATOPM9b8du8IzHPtSJ9 Dibyhz0GXizUPt2KxZg0IcCXykKY27YwnQqNedSiXajbwrGqJCX2yuN6/Ofayq71Z6FP 3k9FybM4OoGQuF8QTVnUnEXrEtaimorqOysbQCzSA3bA71JFOk96pxowE0qw60UiB8C7 CT7r+wmkCC8d8SnUspAx0XNNaYFQ+mcmm0uqBliaWoUvpOOfJ8xOcgpSxfiPFGCdZ2Pz vzBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=A0qgMDFYsoa78aA3RsU1HvtNp2lW2GL4Em7N6j4qBc4=; b=fLKIOKZJY93x4/8HaHewaL4e9dCyDoTRAdYzxd1WA/xehxQ7699jjWqSF2rL007nJs ApN5bnQ9hWX1jxtjutyjI/ij83Wl1U7Br433PIi5404YHnGlU6Ib8sg5a2ZCHFdQLvjx Kef2e0/ISeKrL8GdN3j7TXd6KJU9uu80i9fdy45zdgxElBgSRxQAQUOdtiWynvftgTCs OwQHdyhngHZBlNTDy8a6AWJaMJrGbLTRCr4vt2bariaeU7nPluoVmFSA/axz00K9t/OG /wqvzD98zL6PrlyyyMjOI5G5C+qMx3h5Hl4PYv5+FaRwmQ+FUXksDlvFXC8F/PDFc/HP ut9w== X-Gm-Message-State: ACrzQf0HBHsqldlBH+uyr/mzt0VnPA4X64sVK92xXwoz4/kaXRsDb13P NSSqfIQJHWewE+zvFJFvxb+Zt5oyrqk= X-Google-Smtp-Source: AMsMyM4JCj0OnnfH1fU1gRqo5WR8xr4Bpfpd8DOHSyzQ/hTJobMdtWcAoz1SWVQ0rDYuGZ1xk/hscg== X-Received: by 2002:a17:907:7245:b0:782:331b:60f4 with SMTP id ds5-20020a170907724500b00782331b60f4mr17724303ejc.594.1664182243719; Mon, 26 Sep 2022 01:50:43 -0700 (PDT) Message-ID: <12c95841-027b-ae02-1945-b0d232ffb17d@gmail.com> Date: Mon, 26 Sep 2022 11:50:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Roberto Bagnara , Stefano Stabellini Cc: Bertrand Marquis , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Roberto, On 9/18/22 16:02, Roberto Bagnara wrote: > On 03/09/22 02:52, Stefano Stabellini wrote: >> +Roberto >> >> I think we need Roberto's advice on Rule 20.7. (Full thread below.) > > Hi there, sorry for the delay: I missed this message. > Please see below, where I took the freedom of rearranging the > cases. > >> The question is on the interpretation of Rule 20.7. Are parenthesis >> required by Rule 20.7 in the following cases: >> >> - macro parameters used as function arguments > > [...] > > - macro parameter used as lhs in assignment > > You can obtain different semantics depending on whether parentheses > are or are not used (in the macro call and/or macro expansion > depending on the case): > > > #include > > void g(int v) { >   printf("%d\n", v); > } > > #define m1(x, y, ...) g(y) > > void f1(int x, int y, ...) { >   g(y); > } > > #define p 0, 1 > > void test1() { >   m1(p, 2); >   f1(p, 2); > } > In the example above something bothers me. Let me explain. Running the above example gives: 2 1 The results differ mainly because m1() is substituted before p. Thus, adding parentheses around the macro parameter 'y' of m1() i.e #define m1(x, y, ...) g((y)) has no impact. If the example is changed into the following: #include void g(int v) { printf("%d\n", v); } #define m1(y, ...) g(y) void f1(int y, ...) { g(y); } #define p 0, 1 void test1() { m1(p, 2); f1(p, 2); } if no parentheses are added around 'y' in the definition of m1(), the compiler complains with "too many arguments to function g". If parentheses are added around 'y', the compiler does not complain but the behavior will still differ and the result will be 1 0 This happens because in the case of m1(), p is interpreted as an expression (due to the parentheses added there) and the comma is evaluated as a comma operator, while in f1(), p is interpreted as a list of expressions and the comma is evaluated as a comma separator. Hence, in my opinion, parentheses should not be added around macro parameters used as function arguments because they can hide a bug due to missing parentheses around the entire macro definition. Since macro 'p' is supposed to represent an expression, and the semantics of the comma token are those of a comma operator and not a comma separator, then parentheses need to be placed around the entire macro definition i.e #define p (0, 1) AFAIK, there is no requirement in MISRA C guidelines to add parentheses around the entire macro definition when it is used as an expression and this is something I cannot understand. Unless I got it all wrong I guess ... > #define m4(x) x = 4 > > void f4(int &x) { >   x = 4; > } > > > void test4() { >   int y; >   int z; >   z = 3; >   m4(y = z); >   printf("%d\n", z); >   z = 3; >   f4(y = z); >   printf("%d\n", z); > } > > int main() { >   test1(); >   test4(); > } > >> - macro parameters used as macro arguments > > Please note that Rule 20.7 depends on the final expansion: > so whether parentheses are or are not used in a certain > macro body is irrelevant, the point being that, at the > end of all expansions, expressions resulting from the > expansion of macro parameters are enclosed in parentheses. > >> - macro parameter used as array index > > This is safe today, but my understanding is that in C++23 > the [] operator will accept more than one expression. > A similar change might (who knows?) be considered for C26 > or even offered before (intentionally or by mistake) by some > C compiler. > Can a deviation being added in the basis of C99 standard since according to the standard, E1[E2] is identical to (*((E1)+(E2))), and therefore, macro parameters used as subscript expressions are implicitly parenthesized and can be exempted from the rule. >> Some of these cases are interesting because they should function >> correctly even without parenthesis, hence the discussion. In particular >> parenthesis don't seem necessary at least for the function argument >> case. > > This is not the right spirit for MISRA compliance: why would you want > splitting hairs when inserting a pair of parentheses is so easy? > C and C++ are very complex languages, and the MISRA coding standards > are the result of a (very difficult!) compromise between simplicity > and effectiveness: rules that are exactly targeted to all and only all > the problematic instances would be very difficult to express and to > remember. > So, yes: in many cases you might spend time to demonstrate that a > particular > (real) MISRA violation does not imply the existence of a real issue, > but this time is not well spent.  Critical code must be boring and > obviously > right, in the sense that whomever is reading the code should not be > distracted by thoughts like "there are no parentheses here: am I sure > nothing bad can happen?" > >> Regardless of the MISRA C interpretation, Xenia noticed that Eclair >> reports violations on these cases (cppcheck does not, I don't know other >> checkers). > > I am not aware of any false positives (or flse negatives) for the > current version of ECLAIR on Rule 20.7.  Nonetheless, ECLAIR can > be configured to selectively deviate on each of the cases mentioned > above by means of checker configuration.  However, as I said, > it only makes sense deviating the rule in the cases where you are > not allowed to add the parentheses (e.g., because both the macro > definition and the macro invocations are in legacy code you are > not allowed to touch). > > In contrast, cppcheck is no more than a toy when MISRA compliance > is concerned.  It claims to support 153 out of 175 MISRA C:2012 guidelines. > For 103 of those 153 it has a significant number of false negatives (FN) > and false positives (FP).  I recently participated to an evaluation > of cppcheck 2.8 and here is a summary I can disclose: > > Rule 1.3               FP > Rule 2.1               FN > Rule 2.2               FN+FP > Rule 2.4               FN+FP > Rule 2.5               FP > Rule 2.7               FP > Rule 3.2               FN > Rule 4.2               FN > Rule 5.1               FP > Rule 5.3               FN > Rule 5.6               FN+FP > Rule 5.7               FN+FP > Rule 5.8               FN+FP > Rule 5.9               FN+FP > Rule 6.1               FN+FP > Rule 7.1               FN > Rule 7.3               FN > Rule 7.4               FN+FP > Rule 8.1               FN > Rule 8.2               FN+FP > Rule 8.3               FN > Rule 8.4               FP > Rule 8.5               FN+FP > Rule 8.6               FP > Rule 8.7               FN > Rule 8.8               FN > Rule 8.9               FN > Rule 8.10              FN > Rule 8.13              FN > Rule 8.14              FP > Rule 9.1               FN+FP > Rule 9.3               FN > Rule 10.1              FN > Rule 10.2              FN > Rule 10.3              FN+FP > Rule 10.4              FP > Rule 10.5              FN+FP > Rule 10.6              FP > Rule 10.7              FN+FP > Rule 10.8              FP > Rule 11.1              FN+FP > Rule 11.2              FN > Rule 11.3              FN+FP > Rule 11.4              FP > Rule 11.5              FP > Rule 11.7              FN > Rule 11.8              FN+FP > Rule 11.9              FN > Rule 12.1              FN > Rule 12.2              FP > Rule 12.3              FP > Rule 13.1              FN > Rule 13.2              FN > Rule 13.4              FP > Rule 13.5              FN > Rule 13.6              FP > Rule 14.2              FN > Rule 14.3              FN > Rule 15.5              FN+FP > Rule 15.6              FN+FP > Rule 16.1              FN > Rule 16.3              FN > Rule 16.6              FP > Rule 16.7              FP > Rule 17.1              FP > Rule 17.2              FN+FP > Rule 17.4              FN > Rule 17.5              FN > Rule 17.7              FP > Rule 18.1              FN > Rule 18.3              FN > Rule 18.4              FP > Rule 19.1              FN > Rule 19.2              FP > Rule 20.2              FN > Rule 20.4              FP > Rule 20.5              FN > Rule 20.7              FP > Rule 20.9              FN > Rule 20.10             FP > Rule 20.12             FP > Rule 21.1              FN+FP > Rule 21.2              FN > Rule 21.3              FP > Rule 21.6              FP > Rule 21.8              FN+FP > Rule 21.12             FN > Rule 21.13             FP > Rule 21.14             FN > Rule 21.15             FN > Rule 21.16             FN+FP > Rule 21.17             FN > Rule 21.18             FN > Rule 21.19             FN > Rule 21.20             FN > Rule 22.1              FP > Rule 22.2              FN+FP > Rule 22.5              FN > Rule 22.6              FN > Rule 22.7              FN > Rule 22.8              FN+FP > Rule 22.9              FN+FP > Rule 22.10             FP > > These results are clearly relative to the testsuite employed: > while very large, it cannot of course reach 100% coverage. > For instance, if you noticed Rule 20.7 reports given by > ECLAIR and not by cppcheck, then maybe line > > Rule 20.7              FP > > should be > > Rule 20.7              FN+FP > > If you can let me have an indication of the code that > ECLAIR is flagging for Rule 20.7 and cppcheck does not > flag, I will be happy to double-check. ECLAIR flags as violations of Rule 20.7 the cases where unparenthesized macro parameters are used as (1) function arguments or (2) array indexes, while cppcheck does not. For instance: (1) in xen/arch/arm/include/asm/atomic.h #define read_atomic(p) ({ \ union { typeof(*(p)) val; char c[0]; } x_; \ read_atomic_size(p, x_.c, sizeof(*(p))); \ x_.val; \ }) ECLAIR flags as violations missing parentheses around 'p', when used as an argument of read_atomic_size(). (2) in xen/arch/arm/arm64/cpufeature.c #define SANITIZE_REG(field, num, reg) \ sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ #reg, ftr_##reg) ECLAIR flags as violations missing parentheses around 'num'. > > While the sheer amount of false negatives of cppcheck 2.8 precludes > its use for safety-related development, the many false positives > are also a big problem: people will waste time investigating > them and, unless they have been properly trained on the > MISRA guidelines so as to be able to recognize false positives, > they might be tempted to change the code when there is no > reason to do so.  When the latter thing happens, code quality > will typically decrease. > > Kind regards, > >    Roberto > >> On Fri, 2 Sep 2022, Xenia Ragiadakou wrote: >>> On 9/2/22 05:07, Stefano Stabellini wrote: >>>> On Thu, 1 Sep 2022, Bertrand Marquis wrote: >>>>> Hi Xenia, >>>>> >>>>>> On 1 Sep 2022, at 10:27, Xenia Ragiadakou >>>>>> wrote: >>>>>> >>>>>> >>>>>> On 9/1/22 01:35, Stefano Stabellini wrote: >>>>>>> Patches 1, 4, and 6 are already committed. I plan to commit >>>>>>> patches 2, >>>>>>> 3 >>>>>>> and 5 in the next couple of days. >>>>>>> Patch 7 needs further discussions and it is best addressed during >>>>>>> the >>>>>>> next MISRA C sync-up. >>>>>> >>>>>> I would like to share here, before the next MISRA C sync, my >>>>>> understandings that will hopefully resolve a wrong impression of >>>>>> mine, >>>>>> that I may have spread around, regarding this rule. >>>>>> There was a misunderstanding regarding the rule 20.7 from my part >>>>>> and I >>>>>> think that Jan is absolutely right that parenthesizing macro >>>>>> parameters >>>>>> used as function arguments is not required by the rule. >>>>>> >>>>>> The rule 20.7 states "Expressions resulting from the expansion of >>>>>> macro >>>>>> parameters shall be enclosed in parentheses" and in the rationale >>>>>> of the >>>>>> rule states "If a macro parameter is not being used as an expression >>>>>> then the parentheses are not necessary because no operators are >>>>>> involved.". >>>>>> >>>>>> Initially, based on the title, my understanding was that it >>>>>> requires for >>>>>> the expression resulting from the expansion of the macro to be >>>>>> enclosed >>>>>> in parentheses. Then, based on the rule explanation and the examples >>>>>> given,  my understanding was that it requires the macro parameters >>>>>> that >>>>>> are used as expressions to be enclosed in parentheses. >>>>>> But, after re-thinking about it, the most probable and what makes >>>>>> more >>>>>> sense, is that it require parentheses around the macro parameters >>>>>> that >>>>>> are part of an expression and not around those that are used as >>>>>> expressions. >>>>>> >>>>>> Therefore, macro parameters being used as function arguments are not >>>>>> required to be enclosed in parentheses, because the function >>>>>> arguments >>>>>> are part of an expression list, not of an expression (comma is >>>>>> evaluated >>>>>> as separator, not as operator). >>>>>> While, macro parameters used as rhs and lhs expressions of the >>>>>> assignment operator are required to be enclosed in parentheses >>>>>> because >>>>>> they are part of an assignment expression. >>>>>> >>>>>> I verified that the violation reported by cppcheck is not due to >>>>>> missing >>>>>> parentheses around the function argument (though still I have not >>>>>> understood the origin of the warning). Also, Eclair does not >>>>>> report it. >>>>>> >>>>>> Hence, it was a misunderstanding of mine and there is no >>>>>> inconsistency, >>>>>> with respect to this rule, in adding parentheses around macro >>>>>> parameters >>>>>> used as rhs of assignments. The rule does not require adding >>>>>> parentheses >>>>>> around macro parameters used as function arguments and neither >>>>>> cppcheck >>>>>> nor Eclair report violation for missing parentheses around macro >>>>>> parameters used as function arguments. >>>>> >>>>> >>>>> Thanks a lot for the detailed explanation :-) >>>>> >>>>> What you say does make sense and I agree with your analysis here, only >>>>> protect when part of an expression and not use as a subsequent >>>>> parameter >>>>> (for a function or an other macro). >>>> >>>> Yeah I also agree with your analysis, and many thanks for >>>> double-checking the cppcheck and Eclair's reports. >>> >>> Unfortunately in the specific case that I checked, it was not >>> reported because >>> it was actually an argument to a macro, not a function. >>> Eclair does report as violations of Rule 20.7 the macro parameters >>> that are >>> used as function arguments and are not enclosed in parentheses. >>> >>> So, one tool reports it as violation and the other one not. >>> >>> The same goes, also, for the case where a macro parameter is used as >>> index to >>> an array. Eclair reports it as violation while cppcheck does not. >> -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:52:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:52:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411517.654460 (Exim 4.92) (envelope-from ) id 1ocjqo-0000oI-5Q; Mon, 26 Sep 2022 08:52:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411517.654460; Mon, 26 Sep 2022 08:52:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjqo-0000oB-2S; Mon, 26 Sep 2022 08:52:30 +0000 Received: by outflank-mailman (input) for mailman id 411517; Mon, 26 Sep 2022 08:52:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjqn-0000o1-DT; Mon, 26 Sep 2022 08:52:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjqn-00042P-7d; Mon, 26 Sep 2022 08:52:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjqm-0006yk-LZ; Mon, 26 Sep 2022 08:52:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocjqm-0003mU-L5; Mon, 26 Sep 2022 08:52:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kBoagssPyAEZ8xwgCPtVdV0HwLWFMpbmlk+KZV9u37M=; b=M0Gq8Q+rScvoWym5pOM83XF+ky 4dcgtdr1gUIHNumEvc85ps6eRadMrcnzCWTK68hAtG6u53EZfuwGox3UOlBMTEbOiv5rowU1I4icO lGWMaDjdrmFN6gBeHaMAojepWSMpKYKcO1e0M88dCh4+FIJI365KFVzLm8nl32ytTZQ0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173313: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Mon, 26 Sep 2022 08:52:28 +0000 flight 173313 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173313/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail pass in 173306 test-amd64-i386-examine 6 xen-install fail pass in 173306 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173306 like 173301 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 173258 test-amd64-i386-examine-uefi 6 xen-install fail like 173306 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173306 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173306 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173306 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173306 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173306 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173306 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173306 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173306 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173306 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173306 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173306 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173306 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173313 2022-09-26 01:51:56 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Sep 26 08:56:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 08:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411527.654471 (Exim 4.92) (envelope-from ) id 1ocjuf-0001UI-P4; Mon, 26 Sep 2022 08:56:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411527.654471; Mon, 26 Sep 2022 08:56:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjuf-0001UB-Kq; Mon, 26 Sep 2022 08:56:29 +0000 Received: by outflank-mailman (input) for mailman id 411527; Mon, 26 Sep 2022 08:56:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocjue-0001U5-7z for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 08:56:28 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13fff8bd-3d79-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 10:56:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8743.eurprd04.prod.outlook.com (2603:10a6:10:2e1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 08:56:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 08:56:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13fff8bd-3d79-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZJR+h0m2hD8k4KAElssSa6hVBiiOQIwpt4LBUpmSOmsW4LRab16WM9lHfmpz+mGl97bzBRIgKD0NOvqs1sDloX0I8slRSPRtu+8xIjjZusV63RpskI/+O40r6reBNsDmvzU/2LTfQjO6Z+kb8SMKgPdo6FT/6b7rRYy8PhMaxXlvPaTFTrx/vq0IV50+lJFKy9UYbUMWQi+5mpelD9LpFcEWWJsG1eDDLDVzEP4uYg4eBoE/My7H/zn2kfPOmFOUJWiyxOPdd62f0vvtMSmgOPiaJ+isDA2gmbRY8bGQdjx8BjATuO77dsKloiTnhXOtn3bBbANfA7f1RDmuW2c3Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mAlKn9fcp3xl0kb4wQpOlyezl8sjILZZ7pZ0Ptr6wzM=; b=M+e0yRg19cPKsYNNJ5rl1KPxHr219P0VoHmKEwmPx9SH4znUFqDtr8tHeiIlmnaLsHwVH32Ej5fhWDAly6+rz6zq+anzC53XkaWOznM3vZlvUjjY29hM5kVbQvJW9i2+u3k+q2GfqArSX3jWwWjfKJo88Wcfizqj1wD5FfxZO0o/r4rimZw4DMbOPGdcQ+OONe4POn12hT27+lW3yrbJsst+cRtkyUuYXE7HvYhC+8kOnPkDABPLIjWrNUIwfJ+QtSFaU2JDoJL7r0okRuXg8TAc+2WMqfnzKlGczJqKSIGI9ceydxfL2UuFHmkndL93ZpqaMf4TBeM8imbOSnIsHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mAlKn9fcp3xl0kb4wQpOlyezl8sjILZZ7pZ0Ptr6wzM=; b=JsIyhKEaAK/RJnO6B5hCJN6RAMNSoTF/qwTocZeppSdF8FWxE+QBhGkPw3EREKftZFkpZZ/H0qxutUMHcvuBueDpflzXyyEmrO89fqOGQWaQi0HDseOmjcSbqPvtkR6oE7Zl4CIYzm+gzxTf4U+Rs68sipJo9bAOFQxqsup7Qs44du9U1PJ8CfC9fVYMimsfF5VK1QZkGTprWNWaivIn3fa71rdKWsOZDMB0VsvZV6ZCLY50xYS6Fy+zDzElUaH0k7jAf6XZ7qD5QbJpHmM6V25E/3JqboB/R9VbjsTt20MabQfTSuxTTFv49aVUU2lGhRmMqXCped3R87rOLEazJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <021abdc2-2bd6-6220-1202-12fffe090a77@suse.com> Date: Mon, 26 Sep 2022 10:56:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates Content-Language: en-US To: Nathan Studer Cc: Stewart Hildebrand , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jeff Kubascik , Robbie VanVossen , xen-devel@dornerworks.com, Stewart Hildebrand , xen-devel@lists.xenproject.org References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> <20220919021002.2193665-1-stewart@stew.dk> From: Jan Beulich In-Reply-To: <20220919021002.2193665-1-stewart@stew.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8743:EE_ X-MS-Office365-Filtering-Correlation-Id: aa7bebb1-45d8-46a0-9953-08da9f9cfdc7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AQMaUkG7gRY9uC+gASDW8rWIcga9i8MU3F+Vkr5IO5PSq8SJBcoyI7e6VXGeWk3hAIvWOU4MoQYg8N9V+C+nULl8j5ZxNp15VVdXV9YaA+W4ET0rBAC+UTiMD/bBA9fq2qUNvSKGuNMGq/7hUvGeDupEHiIVCMKdPy9VjQCv5VU8ZjY+ubPag9iLtGnHDwtBj4FuCijTAibNq4F+40xbzHc98J5qKsTKvwtozRbBYFHH+Avkjogc1Z3WF+53xrJbMgb4YbxkFDT97W1ZJ5frbF7K5F21xtElmGIqlYKVHzu5oAfsURqW1Y9sgEwVPbzBnD+fy15FSdVgQByk0EU9eQhbLfFfFYYL0dHpGZgXNRNDqaK41hKN70o3G1owkhwoa8nxu0sodaGmM2+K5yuIrKel9rTfLbCrImEY0gzE7kvds+Mv7MW8xuPzRyLCfVy8KKy7MrCiZNs3ir6DIa7Zv9xPMkmpMPw8YlPOb2vr4qKHlhX9WRWFbLGN1g7wHzVVGD1xhDEMObOKc4zb9y7V1Lsy2bEiuofX9O8dyLEeP4h2wl/IGRGILkjZKXFg1CfsOJ9hYT9xgJzbes4iQFmtMt587ioM3aIKVeS5cW98hvJHJ7kFalk9uCA/gKMj5FLNA8fOziRAO6itlJiDsqsrQCY4JE1Z9xqnHiQCwTzfamtVaBlGcIGEycxta6gFqCeE4PmVpj5ygiVUeUe9/8i7lpiO8GmBQvL6M5LPasmN1eVVyYYrul5w67rhZvHJpRQ+dwF3U1C+Fo0pA0CaOkZXblLH5MBZElAV16lLhzoqNP4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199015)(2906002)(186003)(83380400001)(2616005)(38100700002)(86362001)(36756003)(31696002)(66556008)(66476007)(66946007)(8676002)(316002)(478600001)(54906003)(6916009)(6486002)(4326008)(53546011)(8936002)(6506007)(26005)(6512007)(5660300002)(7416002)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjJyRWtENW9sc1dZUXFjOEhlUDlYTGFidXQxczl6MnVVQ3VSWGl5dEsrZnRB?= =?utf-8?B?bks2WFdUQVlSRVBrcUpYLzNPbGdZTGRvUkd2SkNiMSs4Q0ZvWDJ2OHdCdkha?= =?utf-8?B?ODg4S1hYQm5ZZmhoM0dNWUt0VHFLdmhzMjJFSGRtNnNYM2ExT2liYjZkT3hI?= =?utf-8?B?NVVBeHE5bjdQZjkzbC8xUUZqM1NhdG5ub25nWUJzMGpMSzY1cTNpWGNkejlN?= =?utf-8?B?ZnA3QnFPdFRDeFd1L3dUWVZWdGZNQTZlZVpuSXVhVUl5TGM5MTBXbTd1Ynhq?= =?utf-8?B?bUU2VEJ6akJSYzFlRG94T2dPK3lkd3NwTHR1ejNrTVlOK0Q4QXdWaTMrYmpP?= =?utf-8?B?Tm1xdVJtSFVjanVseW50VnRXYTBaQm11K1p3S0ZEaHBxV3dKOC9MaVZOUTE5?= =?utf-8?B?eXg3cnVPZ0R0d1B6dFlvTFErUnVvTWVrd2dFUjlnWUZhQjFRTWI3YXJURWtz?= =?utf-8?B?RGcvWFBZT3o0OFdlUHFmaERoVSt0REJidDFYNnk5YjNiR0p3aVExMWJIdHlj?= =?utf-8?B?NkhjalovcjVhRDJxajEyL0Y5Uk1wek9yT0V6cDVEKzFWTitQYVg0czN0bHNn?= =?utf-8?B?TmJUaEhtaklqSjg3STJMdVdLdEtTTkU0VWhJSzRGZi95RHRNUEpWNEtTMS9k?= =?utf-8?B?R1dDK3Q2ZU1reDNZSkpKYngvZFVaWnFxekFLVmdxRnN3aGxJdzcwV0F4WUlC?= =?utf-8?B?MnZLUm1aOUZKWWVkWWY4NGt5Y0pGS1NEMDFPcnhVTHkvL3lWTGpMdUd6Y0ht?= =?utf-8?B?S3N5Z1JuRDlUQjZ4UTk1YnZaTjBuZm12a1M4NlZUNW5yVjNmbmhMTDdBVUtK?= =?utf-8?B?YXFueDZISGNMdEkwaEFUVlB3Vk9kWCtObndzWWlTN3c3WHdWWU9DeVUyVmRR?= =?utf-8?B?RHlkaStwb3NpOGpIeDFtZyt4UkF0V1RVdkpGa1g4RktxZUNDMzI3K1FFYXVq?= =?utf-8?B?T1VHaVFBd0lMUy9BYVVoMExkUVB1NC81amZXUWRTM2JLT3R1aW0vdWFrSDhY?= =?utf-8?B?NGlKbUN4NTdmOXBBTWxxTGE5YkNMZ2JsYTNzVSszWTFKVVVBS2xaUkU0L1VH?= =?utf-8?B?Q20rZ3JVbzFqc3JnNW1ueXBSVFB1OUNGcEtpdmZuRmJUZEpBTXpLZFhlVHpC?= =?utf-8?B?ampUaUt5eFl1WjBwamw2bkpGNDl3WWNEUE9rTmpmY0YzeHNEYzRmbzczeGlO?= =?utf-8?B?cldPRjBDUllnRGwzSW02aFErSEpnT0t5WGU0djgvd1FBWkMwZFV0MUZZL2hB?= =?utf-8?B?WDl6QmpYd0dQUFZ0c2FiY3JFQys4WW1hT3JPQ1dUODNtY3QzWnhkTFRjbysy?= =?utf-8?B?RzhYZWpHNTZud0JydkxUaUhsQysvRjJmWlhxQmpKdnBPa0VYOXNBR3lkdncr?= =?utf-8?B?TEdHVEw2Q3d4emFFRkZobldmQmQzb2EyV0YzTzdpZG5iZkhWQW5mWWhIdUxF?= =?utf-8?B?clZMRUtxOExlR2Y5dHdzMXRqTEFRaXF0alNlTkxlWnhTcHhISkxoWDNwTHNI?= =?utf-8?B?MHRiVFBPY05KMjlOM01LTXFveEw0VEJsdjdMN3FEMEpoUUtncmNka25obEY0?= =?utf-8?B?NVRYK2RFZ0hDUlZLdG9Kdm0yMDNxcDhMY2t3ajlPSlhsVWRBQzJTbHhEVE9k?= =?utf-8?B?dnBJV0F6M3R2R25OelovM2llRTZ0Z1pnZ2QvcW1HMml3TG5jRmYwVnJRaFZR?= =?utf-8?B?SWVkdmRaQWJuZkJ4OU9aSERvZ3pHb09GVGxCVjFDcTNvY3IvN1VIQlJKSFlv?= =?utf-8?B?UmZyODduVDloclRvVjAwcTgyRUxYTmN6dEZrWE90elBZaGNOcTF1cDFBL1Bl?= =?utf-8?B?OWIxdzErNzROc2YzdENnWDRLT2dsRjFGQlgxV01nazRPRGZxRTJNenlEMndo?= =?utf-8?B?aE40cGhScEY5WHBNOTZSY1QvcXAvQ3NLU2JWQXIvUjFNY1dGdU9XczV4MlZN?= =?utf-8?B?Nkg5N01lWklvQkRQV3g2bHpLa3RiY1VzRFQ4enJYMlVCVmhMKzNUU2xpaGVw?= =?utf-8?B?TU12S0pGZmxEMjdacHBUbFV5VjVKcFdITVQzVWZVMHJIL0IyTWdHYVRhQnR3?= =?utf-8?B?RkJEa3J3RVI4aGVhZTRJZ2VXRTdNSkZzY0YvdmN4VjhKMmJhWEFDOThSdHU2?= =?utf-8?Q?yBgcN7WFcE2oFpGW3nMaEbX8i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa7bebb1-45d8-46a0-9953-08da9f9cfdc7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 08:56:24.9652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Phm6pvZOVM2tuBKj77sEHcxHqWKeRrb+Iai7YWR7atgO8FzMbK/KVj810RjI6wE9VAEG063kZUM8eqqsgYDCMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8743 On 19.09.2022 04:10, Stewart Hildebrand wrote: > From: Stewart Hildebrand > > Add Nathan Studer as co-maintainer. > > I am departing DornerWorks. I will still be working with Xen in my next > role, and I still have an interest in co-maintaining the ARINC 653 > scheduler, so change to my personal email address. > > Signed-off-by: Stewart Hildebrand > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e12c499a28..816656950a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -221,7 +221,8 @@ F: xen/include/xen/argo.h > F: xen/common/argo.c > > ARINC653 SCHEDULER > -M: Stewart Hildebrand > +M: Nathan Studer > +M: Stewart Hildebrand > S: Supported > L: xen-devel@dornerworks.com > F: xen/common/sched/arinc653.c Nathan, may I please ask that you supply an ack here, indicating your acceptance of this role (or otherwise reply to state the contrary)? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 09:09:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 09:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411536.654482 (Exim 4.92) (envelope-from ) id 1ock7P-00037D-2w; Mon, 26 Sep 2022 09:09:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411536.654482; Mon, 26 Sep 2022 09:09:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ock7P-000376-0L; Mon, 26 Sep 2022 09:09:39 +0000 Received: by outflank-mailman (input) for mailman id 411536; Mon, 26 Sep 2022 09:09:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ock7N-00036w-RJ; Mon, 26 Sep 2022 09:09:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ock7N-0004LI-Ov; Mon, 26 Sep 2022 09:09:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ock7N-0007R7-Ac; Mon, 26 Sep 2022 09:09:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ock7N-0007L9-A8; Mon, 26 Sep 2022 09:09:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6bWCt0TFaw5p46d8q8caJy1ZiUqvni5QPa5wxMu5+Vo=; b=UKDzU+4uD5K/BNqrYZSJsatDaH TgsX6LFErrgVTVyglyOJMG4AblIgOFwoTMfZJ7FW254xnHUEyccN0pBnC194AiPy9wYSnPQCepjeK WqsxIKkQfe5FXbZfyVgdyE/5Ho+m5nBQmJnWh+y0KW5QNuARJjoUdCkSXyIxgJACJf8o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173314: all pass - PUSHED X-Osstest-Versions-This: ovmf=d97ee3244d806d324a22ea530215a9f10d2b23e2 X-Osstest-Versions-That: ovmf=0e7aa6bf9e0a7a91136353a3d6fe6a90d2047fc0 From: osstest service owner Date: Mon, 26 Sep 2022 09:09:37 +0000 flight 173314 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173314/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d97ee3244d806d324a22ea530215a9f10d2b23e2 baseline version: ovmf 0e7aa6bf9e0a7a91136353a3d6fe6a90d2047fc0 Last test of basis 173312 2022-09-26 01:41:53 Z 0 days Testing same since 173314 2022-09-26 07:13:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yi Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0e7aa6bf9e..d97ee3244d d97ee3244d806d324a22ea530215a9f10d2b23e2 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Sep 26 09:19:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 09:19:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411545.654493 (Exim 4.92) (envelope-from ) id 1ockH4-0004cx-1v; Mon, 26 Sep 2022 09:19:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411545.654493; Mon, 26 Sep 2022 09:19:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ockH3-0004cq-Ve; Mon, 26 Sep 2022 09:19:37 +0000 Received: by outflank-mailman (input) for mailman id 411545; Mon, 26 Sep 2022 09:19:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ockH2-0004ck-0v for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 09:19:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5604e7a8-3d7c-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 11:19:34 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 545062210A; Mon, 26 Sep 2022 09:19:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 353B8139BD; Mon, 26 Sep 2022 09:19:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 63VOC6ZuMWPdcAAAMHmgww (envelope-from ); Mon, 26 Sep 2022 09:19:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5604e7a8-3d7c-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664183974; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MLXxIPG8Gh6ps8xY2agspRgVOvO5rxBk83aobXiB0mQ=; b=uZaVAgVWSm4OHe3wE/B6ziWsxAlE8Dmxs7Zl6LJ1Pdi8vvATjZ1QB5niZkKsP1Y6k4p158 i+fvqfxyJv+xAKfzX0DQH7JKkHNXaNXWHE54ihycaMf/X4APbhAHgFxlEB4noyFuMatGzP Wz1LzAck7svGlnPhoXDbpbkuZGfjR/g= Message-ID: <98f14fa6-4b5e-fde8-fceb-d37cf82ca00f@suse.com> Date: Mon, 26 Sep 2022 11:19:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Design session "grant v3" Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> <12ef0abb-2158-faf7-76d7-61e165060d0c@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4hkbPGnoFs54dmpMRE6LXgbW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4hkbPGnoFs54dmpMRE6LXgbW Content-Type: multipart/mixed; boundary="------------2OZ4U2IU8w4SOcz0oWBVCssH"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: <98f14fa6-4b5e-fde8-fceb-d37cf82ca00f@suse.com> Subject: Re: Design session "grant v3" References: <767eeb85-40ab-70f6-2d0f-f81af0a65f6e@suse.com> <192f76e1-4f5a-34e7-84e7-a78da531607a@suse.com> <12ef0abb-2158-faf7-76d7-61e165060d0c@suse.com> In-Reply-To: --------------2OZ4U2IU8w4SOcz0oWBVCssH Content-Type: multipart/mixed; boundary="------------xXUDwe8VtxLeQeHayrFAxqWy" --------------xXUDwe8VtxLeQeHayrFAxqWy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMDk6MjMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNi4wOS4yMDIy IDA5OjA0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjYuMDkuMjIgMDg6NTcsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIzLjA5LjIwMjIgMTE6MzEsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IE9uIDIyLjA5LjIyIDIwOjQzLCBKYW4gQmV1bGljaCB3cm90ZToN Cj4+Pj4+IE9uIDIyLjA5LjIwMjIgMTU6NDIsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNr aSB3cm90ZToNCj4+Pj4+PiBZYW5uOiAgIGNhbiBiYWNrZW5kIHJlZnVzZSByZXZva2luZz8N Cj4+Pj4+PiBKw7xyZ2VuOiBpdCBzaG91bGRuJ3QgYmUgdGhpcyB3YXksIGJ1dCByZXZva2Ug Y291bGQgYmUgY29udHJvbGxlZCBieSBmZWF0dXJlIGZsYWc7IHJldm9rZSBjb3VsZCBwYXNz IHNjcmF0Y2ggcGFnZSBwZXIgcmV2b2tlIGNhbGwgKG1vcmUgZmxleGlibGUgY29udHJvbCkN Cj4+Pj4+DQo+Pj4+PiBBIHNpbmdsZSBzY3JhdGNoIHBhZ2UgY29tZXMgd2l0aCB0aGUgcmlz ayBvZiBkYXRhIGNvcnJ1cHRpb24sIGFzIGFsbA0KPj4+Pj4gSS9PIHdvdWxkIGJlIGRpcmVj dGVkIHRoZXJlLiBBIHNpbmsgcGFnZSAoZm9yIG1lbW9yeSB3cml0ZXMpIHdvdWxkDQo+Pj4+ PiBsaWtlbHkgYmUgb2theSwgYnV0IGRldmljZSB3cml0ZXMgKG1lbW9yeSByZWFkcykgY2Fu J3QgYmUgZG9uZSBmcm9tDQo+Pj4+PiBhIHN1cnJvZ2F0ZSBwYWdlLg0KPj4+Pg0KPj4+PiBJ IGRvbid0IHNlZSB0aGF0IHByb2JsZW0uDQo+Pj4+DQo+Pj4+IEluIGNhc2UgdGhlIGdyYW50 IGlzIHJldm9rZWQgZHVlIHRvIGEgbWFsaWNpb3VzL2J1Z2d5IGJhY2tlbmQsIHlvdSBjYW4n dA0KPj4+PiB0cnVzdCB0aGUgSS9PIGRhdGEgYW55d2F5Lg0KPj4+DQo+Pj4gSSBhZ3JlZSBm b3IgdGhlIG1hbGljaW91cyBjYXNlLCBidXQgSSdtIGxlc3MgY2VydGFpbiB3aGVuIGlzIGNv bWUgdG8NCj4+PiBidWdneSBiYWNrZW5kcy4gU29tZSBidWdzIChsaWtlIG5vdCB1bm1hcHBp bmcgYSBncmFudCkgYXJlbid0IHB1dHRpbmcNCj4+PiB0aGUgZGF0YSBhdCByaXNrLg0KPj4N Cj4+IEluIGNhc2UgdGhlIGRhdGEgcGFnZSBjYW4ndCBiZSB1c2VkIGZvciBhbnl0aGluZyBl bHNlLCB3aGF0IHdvdWxkIGJlIHRoZQ0KPj4gcG9pbnQgb2YgcmV2b2tpbmcgdGhlIGdyYW50 PyBUaGUgcGFnZSB3b3VsZCBsZWFrIGluIGJvdGggY2FzZXMgKHJldm9raW5nDQo+PiBvciBu b3QpLg0KPiANCj4gU3VyZSwgYnV0IGRvbid0IHlvdSBhZ3JlZSBpdCB3b3VsZCBiZSBiZXR0 ZXIgZm9yIHRoZSBndWVzdCB0byBoYXZlIGEgd2F5DQo+IHRvIGNsZWFubHkgc2h1dCBkb3du IGluIGNhc2UgaXQgbm90aWNlcyBhIG1pc2JlaGF2aW5nIGJhY2tlbmQsIHJhdGhlcg0KPiB0 aGFuIGhhdmluZyBpdHMgZGF0YSBjb3JydXB0ZWQgaW4gdGhlIHByb2Nlc3M/IE9mIGNvdXJz ZSBhIGd1ZXN0IHdvbid0DQo+IGJlIGFibGUgdG8gdGVsbCBtYWxpY2lvdXMgZnJvbSBidWdn eSwgYnV0IHdoYXQgdG8gZG8gaW4gc3VjaCBhIGNhc2UNCj4gb3VnaHQgdG8gYmUgYSBndWVz dCBwb2xpY3ksIG5vdCBiZWhhdmlvciBmb3JjZWQgdXBvbiBpdCBmcm9tIHRoZSBvdXRzaWRl Lg0KDQpJdCBjb3VsZCAoYmFzZWQgb24gaXRzIHBvbGljeSkgZWl0aGVyIHJldm9rZSBvciBu b3QuDQoNCj4gVGhlbiBhZ2FpbiBJIGd1ZXNzICJwYXNzIHNjcmF0Y2ggcGFnZSBwZXIgcmV2 b2tlIGNhbGwiIGlzIG1lYW50IHRvIGNvdmVyDQo+IHRoYXQgYWxyZWFkeSwgaS5lLiBsZWF2 aW5nIGl0IHRvIHRoZSBndWVzdCBob3cgdG8gYWN0dWFsbHkgZGVhbCB3aXRoIGENCj4gZmFp bGVkIHJldm9rZS4NCg0KQ29ycmVjdC4NCg0KPiANCj4+Pj4+PiBKw7xyZ2VuOiB3ZSBzaG91 bGQgY29uc2lkZXIgaW50ZXJmYWNlIHRvIG1hcHBpbmcgbGFyZ2UgcGFnZXMgKCJtYXAgdGhp cyBhcmVhIGFzIGEgbGFyZ2UgcGFnZSBpZiBiYWNrZW5kIHNoYXJlZCBpdCBhcyBsYXJnZSBw YWdlIikNCj4+Pj4+DQo+Pj4+PiBzL2JhY2tlbmQvZnJvbnRlbmQvIEkgZ3Vlc3M/DQo+Pj4+ DQo+Pj4+IFllcy4NCj4+Pj4NCj4+Pj4gQnV0IGxhcmdlIHBhZ2VzIGhhdmUgYW5vdGhlciBk b3duc2lkZTogVGhlIGJhY2tlbmQgbmVlZHMgdG8ga25vdyBpdCBpcyBhIGxhcmdlDQo+Pj4+ IHBhZ2UsIG90aGVyd2lzZSBpdCBtaWdodCBnZXQgY29uZnVzZWQuIFNvIHdoaWxlIHRoaXMg c291bmRzIGxpa2UgYSBuaWNlIGlkZWEsIGl0DQo+Pj4+IGlzIGN1bWJlcnNvbWUgaW4gcHJh Y3RpY2UuIEJ1dCBtYXliZSBzb21lb25lIGlzIGNvbWluZyB1cCB3aXRoIGEgbmljZSBpZGVh IGhvdw0KPj4+PiB0byBzb2x2ZSB0aGF0Lg0KPj4+DQo+Pj4gQ291bGRuJ3QgdGhhdCBzaW1w bHkgYmUgYSBuZXcgR1RGX3N1cGVycGFnZSBmbGFnLCB3aXRoIHRoZSBzaXplDQo+Pj4gZW5j b2RlZCBhbG9uZyB0aGUgbGluZXMgb2YgQU1EIElPTU1VcyBlbmNvZGUgc3VwZXJwYWdlcyAo c2V0dGluZyBhbGwNCj4+PiBidXQgdGhlIHRvcC1tb3N0IG9mIHRoZSBiaXRzIG5vdCB1c2Vk IGZvciB0aGUgYWN0dWFsIGZyYW1lIGFkZHJlc3MpDQo+Pj4gaW4gdGhlIGFkZHJlc3MgcGFy dCBvZiB0aGUgZW50cnk/DQo+Pg0KPj4gT2YgY291cnNlIHRoYXQgd291bGQgYmUgcG9zc2li bGUsIGJ1dCB1c2luZyB0aGUgZmVhdHVyZSB3b3VsZCBiZSBsaW1pdGVkDQo+PiB0byBiYWNr ZW5kcyBoYXZpbmcgYmVlbiBtb2RpZmllZCB0byB0ZXN0IHRoYXQgbmV3IGZsYWcuIEluIHRo ZSBlbmQgYm90aA0KPj4gc2lkZXMgd291bGQgbmVlZCB0byBuZWdvdGlhdGUgdGhlIGZlYXR1 cmUgdXNhYmlsaXR5Lg0KPiANCj4gSXNuJ3QgaXQgdG8gYmUgZXhwZWN0ZWQgdGhhdCB0aGlz IG1pZ2h0IG5lZWQgbmVnb3RpYXRpbmc/IFN0cmljdGx5IHNwZWFraW5nDQo+IGl0IG1pZ2h0 IG5vdCBuZWVkIHRvIGJlOiBUaGUgYmFja2VuZCdzIG1hcCByZXF1ZXN0IChmb3IgYSBzdWZm aWNpZW50bHkNCj4gbGFyZ2UgbnVtYmVyIG9mIGdyYW50cyBhbGwgaW4gb25lIGdvKSBjb3Vs ZCBiZSBjaGVja2VkIGZvciBiZWluZyBhbGwNCj4gY29udGlndW91cyBpbiB0aGUgYXBwbGlj YWJseSBhZGRyZXNzIHNwYWNlcy4gVGhhdCB3b3VsZG4ndCByZXF1aXJlIHRoZQ0KPiBmcm9u dGVuZCB0byBhZHZlcnRpc2UgYW55dGhpbmcuIEJ1dCBhbiB1bmF3YXJlIGZyb250ZW5kIHdv dWxkbid0IGJlIHZlcnkNCj4gbGlrZWx5IHRvIHByb2R1Y2Ugc3VpdGFibGUgSS9PIHJlcXVl c3RzIGluIHRoZSBmaXJzdCBwbGFjZSwgSSBzdXNwZWN0Lg0KDQpZZXMuIEFuZCBhbiB1bmF3 YXJlIGJhY2tlbmQgd291bGRuJ3QgYmUgdmVyeSBsaWtlbHkgdG8gbWFwIDUxMiBncmFudHMg aW4gb25lDQpnbyBmb3IgbWFraW5nIHVzZSBvZiB0aGUgbGFyZ2UgcGFnZSB3aXRob3V0IGlu dGVuZGluZyB0byBkbyBzby4NCg0KDQpKdWVyZ2VuDQo= --------------xXUDwe8VtxLeQeHayrFAxqWy Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------xXUDwe8VtxLeQeHayrFAxqWy-- --------------2OZ4U2IU8w4SOcz0oWBVCssH-- --------------4hkbPGnoFs54dmpMRE6LXgbW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMxbqUFAwAAAAAACgkQsN6d1ii/Ey8z ZggAi1zw/GYL/zxVLqDcdWKtfGnxJ7aaFVYKhiJiFbj63gALtCiVrRrHCiybB8XsPZypNSvmggup 4a5B1sxHNVTt7NTHb1ccvlnzgs67AMSGIAgGEZxR/NjLgohHpbtpX5mm/Bq8td1ANtt0OBjTolVV b4Ld2+Surxi7VR5fwLVyvkwyAv/gYjCZzuSAHmtM9N+RRSQfNB/R/tKeB1ncEUiDq/Ump7TEma+z x86L/JzDdaZwZ3nI+N3UwcJ1fzhkyurzk3b8iK/wfoSNmmCpwPA26YuG0EfyhFz/WFdUuccv0ixv 4yudNIbJnLYqsKjkKY9yLXVvkDHjvMSYg6vaikILjw== =5VUe -----END PGP SIGNATURE----- --------------4hkbPGnoFs54dmpMRE6LXgbW-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 09:30:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 09:30:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411575.654548 (Exim 4.92) (envelope-from ) id 1ockRq-0007Rz-KS; Mon, 26 Sep 2022 09:30:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411575.654548; Mon, 26 Sep 2022 09:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ockRq-0007Rs-Hg; Mon, 26 Sep 2022 09:30:46 +0000 Received: by outflank-mailman (input) for mailman id 411575; Mon, 26 Sep 2022 09:30:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ockRo-0007Rm-OS for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 09:30:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2075.outbound.protection.outlook.com [40.107.21.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4b26b5b-3d7d-11ed-9647-05401a9f4f97; Mon, 26 Sep 2022 11:30:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8384.eurprd04.prod.outlook.com (2603:10a6:20b:3e8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 09:30:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 09:30:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4b26b5b-3d7d-11ed-9647-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EyqlxPK5QqNxzYovsaI7oHssxUTcfj5OvTRXltZXDewLNDwIoFLRH+Hp4NqVBH9HlYZAckCsAHMsb78WMwm3VfP1bbcip+6/p+MWMirPjECEInrse9yWwPubmkqgxyMMoKzCZcFRbnXH0ia7tENgA/83UujHvHqn/XT3xjoaZYjsXdCmANiaNnpYR4KLR9kEit7L1Uk8DLbmUmK4MBqUXznT7GcTZPLiJvEtkg+NEnetKUmu7KVssfHuVZc0YBNtib2iNEbKell3QQ+lUZyv8+BYm50OgL8bmvR/qWEEoJqaQxFYTq0Gek6AUvXw1d4W5ATfLzToGui6SMj32rsbOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=36aA06mf3eqFMteeQaZDhocyqplfnDuQ1lntQKtwgmk=; b=eDh8UPnE2Wp6ByYDXB5V1AsgMWbJg4RJcIC1sAVnnyhaGObxefflbRtqtjM0T1zyCHDTW62GSTgizT1PhYw+wHx9F4uYYSFFmTp72GuS8YtolaENT7FlbCOVK+VvvfWp6hxq/NGf8oc2AT9p6B67QDovVJ0ZwQ6IoYolos9ZJS/ZuziBufUAL3JV1BUtErzxJWpL674+puOlzhZjzN84vZuYG8Ylm9DPEblYS9PseRYpEP3MhnZd6xMcfJYrAwJli/yUkRS0p+9nOZlrBm9bMGFll0/bR3Aoen3fTyn7D95oU4H92zizQI/2iplCDuLENgUYra8J/s5AE+qScBz1lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36aA06mf3eqFMteeQaZDhocyqplfnDuQ1lntQKtwgmk=; b=zp03Mw06x7faG39/oldN8g0bPMKstq3r1eIcvfcFyxVM0VcMMQ/02iaz6cfW2MhrhO35sSkFCUJX9q7zHl6pEfWMtsNH0ALoa/ZvZV+FNNP8OTe1/6agAbJB38tnKzdds6zp5PDeIzGISc1ZBX6wYW2NDKluaJAuBqcw7FPjWIQlUm/nUlqIWWy7Q7Bio5vJyOi8H/oxkLN8FoNMnn9j3dfUH9QqROhHbpaLRm1Vfj1pYhqUxMfB/43HNPNroo1AC+MpB/6D76a+K4tjUMRA1xcXS/JlsSQc+1pBy6H/VmAd9Sy6gdoZwWPXaGC8iMJA2djuRY+2UvUgfmg3LWJlDg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <065ff8d4-2f8a-a771-e3a1-6853bb332b3c@suse.com> Date: Mon, 26 Sep 2022 11:30:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session PVH dom0 Content-Language: en-US To: Juergen Gross Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> From: Jan Beulich In-Reply-To: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8384:EE_ X-MS-Office365-Filtering-Correlation-Id: 931cac15-5e2f-4fc9-991c-08da9fa1c708 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0KyZQw+IONyLT30xahyaHji3aizzjhqb0MsTJm4H6eB23Qp482pGLndHYibwcnFqG2If/3KZPHAraiFHrKH6q4+gf8InS/wNQgiPnKM+uL5ncggLKNwBCoR+7f4SJJL7GQNhHLw/djQmkg5SjF1dT1NeFVkeviibjNzGpOUMtAEppQY0iMHBWflnRwZbpL/TjigAF3Z0yW1p64sofbzfpXy/Rm2oi9Zkce/nrD8o3cuVZcYKsU1MYbcOmQvBZMR/4/Y3qj+iH5QKYPQBCuOh/O/dpmzk73Wn1L4YQVq8efiXm958bnpJJws47sy4Dtka4ZHabju/DXgfX1VLVVo8pmNXH+ABwg4sxqzU4bz8FSeuQe9LINtdWlEyDyXqKLQYvYjrffcuZzkZ+ivmGOPteK5r9kzAGF+8+rIWLjY+oRynJyGjfnpn5ij0yrjKWSMOatRM4dKV31Yhbhv5J3vWw2lWhQ7lrB+BzThtyM02xH+fsVg1+Q+71VPEYfyO5B3HTkXd/YM18cqjijv0LWpozSznBGWPizChX/7yEXj8+CkSlSJtD5/QVonJ4hUVje4118K5YzGyzzhLwLlK3tN0sU4UC4EKFgmeSHc5nd0Ge9l0HU7H0uhfKdjVwUo1DKrcMZ8srW6uIOSCzP8C75qurJQlkXZFTcnldbgbxKCJwcRzFJ+LwMarEn4qvxxOke39eVuAWeLtyevj+BzkglXTHYVSzrdEy6zqaFQmgTVEaWrgOpYmKkvRMkXjWyWG03lygPnU2of6X90IPYiJEhE81/438Nmw6Nmd8Dx/Wvxghvc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199015)(186003)(2906002)(66574015)(83380400001)(2616005)(38100700002)(36756003)(86362001)(31696002)(53546011)(66476007)(66556008)(66946007)(478600001)(8676002)(6636002)(66899012)(54906003)(37006003)(316002)(6486002)(4326008)(6862004)(8936002)(6506007)(26005)(6512007)(5660300002)(41300700001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUdidndKL1hLWU5wR3B5YlFFUXRVa042RW54NDJzQTdJOXlQcWh6d2l1amNa?= =?utf-8?B?Y2J6S2FoWllIM2M5VU50Um92bDJJVFljZGhGbkJ1L1pDenZnSjhzc0p0K3g1?= =?utf-8?B?WDFVdTdLZ3RBeG1BYndWTnROT3FTTHl2MU9SSk1ZanRXL2xnUFBDSFg4VGF1?= =?utf-8?B?dFBYRTkrRGNnY0o1Q3cxZXRIMzBybDFIdkR5aXZyN2F1L2lmdTczZjdYUFBY?= =?utf-8?B?K2xpUG9PSjlDcjNnM0ZXSEhZc0xsYjJMS0xwYjgzUTZ1N3Y5emR2djJhSTY2?= =?utf-8?B?aGs3eVZSbDlhTVdjMEM0d29XRGk0d2ZtS0ZYV2hManVYTzN6L3RlczJSYjI2?= =?utf-8?B?TVNFRExyRTZDWXhMS2Z4OWNWWWFrMlA0NmFYdDg2cEY0bTA0OWRIWVlGbGkz?= =?utf-8?B?bUF5a3BtNURSbnR6YmplZGtsaXRSRjBDcFQvRDhDMUwvMUJhcFBmUHNjZThG?= =?utf-8?B?cHRvQ2xwWDJkd1BITUNqMlFWMXR6bWFjaEh5eWEvMnhTbHpNM200amRMUEdB?= =?utf-8?B?YmJScHZGbGVnTEVIeTBpbzNFZ3JoaWJlU0tWa1R6Ym1KRUYvRUV0SjNORDcr?= =?utf-8?B?VTRkRmRpMEVZTCtsTll3KzFkMGR4REJpRnpDOEt2UGZOZFJSTTBQdTV0WUtm?= =?utf-8?B?bExnKzQ3OWdpd2ZzMGUrVWcwVHArSFBGdFZkdGpMK3crY3g2NDEzY2hFZmlt?= =?utf-8?B?citpOEdxQmpIZjBVbW11aG1kcm91aENvSjBJYXBRbmFvVXh5NXlWRHIvc3g3?= =?utf-8?B?aVA0dmJuSWlweFhkc291RS9RY0FZWjhsQmR2Y3I5MEE1bHpiUUR4Tkdld1Ux?= =?utf-8?B?Qmx5d3hPTEtsdEZaVG04Z09JMUV0czVrKzFnTVV2bnZKNktqR3I2NVUxMkZ3?= =?utf-8?B?WEQxOElYZjV3L2hJTy9jSG1MaGU3SjNMUWgwQkRPRVcyaWRnQXNSTlk3aDAz?= =?utf-8?B?UWFDbVk5SS9XQ2x3ejRsQVRxcFZZRVMyQlVhYXVVY2Jxa1BjWjlud3ZCZFI5?= =?utf-8?B?QTZhaWV3UktGYnhET3A2QU9MT2VPbEZOVk8rUnFVTTQvNjJZN2NqellPcjVR?= =?utf-8?B?NERtK2pZdmdBZGNTL0t5ZFN2VnUvaFNHcG9iVE1MYXRKZ3JOSGRMSVJURm02?= =?utf-8?B?SmNaV1NyZ1h0QXpHV0FrWHZSMlNoSzJYdGc0S3NwTkpudzdCWmtCK0pEOG9C?= =?utf-8?B?ZDRaWCtwYnp3OW5Md09pV2J2ZWFMMnpxbHZSTXhCKzFOb2R4TU1xTnB4SVVp?= =?utf-8?B?WVlLdTFmU1VKbTJ6eHVxamsyeDkxS2FyNkp2dVRzTzBYMjRVODZtZzVqdE1R?= =?utf-8?B?T0NDeDV4NFNOcllYMjM5cXdPNTNpZWN2Y2RuTGczakkxSFBMYnh5WFNBZmNU?= =?utf-8?B?NDNLbklWUXVvbTlOMDduTU5mQkdhYVRCQVdyVHZJbTl5Qy9xT2NWUDdaQ1cr?= =?utf-8?B?MFFJTnpvMWFGWmRyODhrTFVVSzB6QXZFK0VjdWdQakJqSVg1N0hkZWd6TnY3?= =?utf-8?B?c1hTd1gzV2RqTUQrOTdyVkdDejNiUThIeTdMaTgzWFI5a1dmWlQydE5DSk5r?= =?utf-8?B?c1pYQktJeG0wUmRWZGtqRWV5M0dJYVpES1h4RE00dExmdGNTVVdOZnNqaE1U?= =?utf-8?B?WW9wUzFlbEI5aDBrM2huMXhwWWorZmt2WnAzMlNWOUpFZGZhWktCcER4SXhl?= =?utf-8?B?TnZJdHJZckp0WjcySEtvWDUza3NEdTNRb0VsQUdXb1dIS3p5ODdHNTh6a0o3?= =?utf-8?B?QXZaN1RzcjdzZ1IycTVjM2hCeDVVQmFxNXBjQWp1akdSMDlrY2pIR2FPWG51?= =?utf-8?B?SWRpbXFVMHFlOEhlMFpsL2dMUUZkUExleDVZc3R2T2lzc3ozU3FXUEd5Rno5?= =?utf-8?B?dHlRZ1FWeU1XUllTUUlrRVJFUWhEVmVOQXdJQ2liTU9ocEFjdXdlV0RoTjhp?= =?utf-8?B?S1lTZ3AzeWZ3U2E5NGQ4UFhsS09RWWJPRU80OUJrN29JUENSSFFnZ3dMcmps?= =?utf-8?B?NzRkZUZRclA3M0hXL0syYU55RE5ERElHZnVxUGpabUFGL2tPMFA5RnNIbzli?= =?utf-8?B?V2dBRFk5aXdFZm5DZllEVkVZMUcyeUVCSWduOHhBZi9XdnM1dnVnQjRiWWUy?= =?utf-8?Q?c8KBxRkVSkzAvJToa5436J+Oq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 931cac15-5e2f-4fc9-991c-08da9fa1c708 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 09:30:40.5845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xtoAadFzmEdwwEbipscocJe6fhFjoynNdSOEBHj+zZPgXzLJa02zZT1KpMy9cchHdluMRDG+S19XLKYroD5AEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8384 On 26.09.2022 10:33, Juergen Gross wrote: > On 26.09.22 09:53, Jan Beulich wrote: >> On 23.09.2022 10:20, Juergen Gross wrote: >>> On 21.09.22 17:53, Marek Marczykowski-Górecki wrote: >>>> Session description (by Jan): >>>> In the course of working on an XSA I had to finally get PVH Dom0 work on at least one of my systems, in a minimal fashion. This had turned up a number of issues, some of which have since remained pending. Therefore I’d like to gain understanding on whether there is any future to this mode of Dom0 operation, and if so when it can be expected to be better than tech preview or even just experimental. >>> >>> ... >>> >>>> Jürgen: PVH dom0 performance? >>>> >>>> Roger: it's bad; mostly relevant is qemu interfaces >>>> >>>> George: only for safety certifications? performance penalty may be okay >>>> >>>> Jürgen: hypercalls can be improved (virtual buffers?) >>> >>> Some more thoughts on this topic: Having hypercall variants with physically >>> addressed buffers will help, but there is an additional complexity: what >>> about hypercalls with really large buffers (e.g. the bitmap for modified >>> pages for guest migration). In order to avoid having to allocate huge >>> physically contiguous buffers for those purposes we'd probably need >>> something like scatter/gather lists for hypercall buffers. >> >> Not sure. I'd rather see us add new (sub)hypercalls for such non-standard >> cases. E.g. the bitmap example you give would be amended by a new flavor >> having the caller pass in an array of GFNs (perhaps, as you say, with >> further indirection to deal with that array also growing large). I'd >> really like to keep the common case simple. > > The question is how many hypercalls would be hit by the not common case. > > Taking a quick glance I spotted: > > - grant_table_op (subops setup_table and get_status_frames) > - memory_op (several sub-ops) > - multicall (main list of calls) > - console_io (console data) > - mmuext_op (some ops allow lists) > - xsm_op (not sure a buffer can span pages, but interface would allow it) > - physdev_op (subop set_iobitmap) > - hvm_op (altp2m handling) > - sysctl (multiple sub-ops) > - domctl (multiple sub-ops) > - hypfs (node data can exceed page size) > > Do we really want to special case all of those? Looking at the Linux uses of several of the ones covered by the top three entries in your list I find they all use contiguous buffers already, to a fair part because of limiting maximum number of entries. Therefore I don't really think all of these would need special casing, until a reasonable use case is demonstrated where such large lists are actually needed. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 09:58:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 09:58:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411601.654566 (Exim 4.92) (envelope-from ) id 1ockss-0001rN-3H; Mon, 26 Sep 2022 09:58:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411601.654566; Mon, 26 Sep 2022 09:58:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ockss-0001rG-0i; Mon, 26 Sep 2022 09:58:42 +0000 Received: by outflank-mailman (input) for mailman id 411601; Mon, 26 Sep 2022 09:58:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocksp-0001r7-Ss for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 09:58:40 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60073.outbound.protection.outlook.com [40.107.6.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cad988c3-3d81-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 11:58:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9326.eurprd04.prod.outlook.com (2603:10a6:102:2b8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 09:58:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 09:58:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cad988c3-3d81-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAhhpU49CiiEA/hpGbGYkjPjuYIWVKo67mcNGy8azsGBlEWvpG7WEqLbeS6oD9xXQmUSVgNEJwJAfg1oIiuKOFJnZfeWlQXds//GsUHqIDOyMGdeJ0600kGLut9oPV8sN7Enw+ts/ExaIW79JFd6l4CDToCHypAasDC8ekt1yyJmxFv+kT8tMRGCg7wWqLzDb7HgAjsv8tvm1FAW9aHbndxTScmUTuFPq1o5exKFyp2BORvdaPq0/foWWV9iOuFlAO6F47MKuAbwmZ+zaIGi+il0dGU9xdQEeDM9gVxscDQUO1XE0mzPGsNR9FbhQ1wjWRmRyzRr7sIPGM7L7vHISw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pG1kP516La+OAzARTQ5ACya5NLlvwv/VYaKgNln1Ry0=; b=Jpf7fVMYQlQ2EFTTFGTnGzoKSqwM5QueEKNgB/OI7bP9gyhhrjL5gLx5tbtmzxIMTyySJYhCw7uLJ9Mui3qb1YA+P/QXYzdeDOsmR1SxLqvyhD68CJ21brtFXABzRfk13whSOazoAMJsTw2d/bzuZTAWwtCsW7ki+qb5WmV5m9FwhYwYySegmcNxsjnCGUbXPnxSn6dvhijLbfeanEpNGpUUu46hG+7KkurwcN2QGCLXkGMWwBdNAxKi3uK9EqJP1YqJARA+x0Yg7N0RcH8ONZHNKW6yqXwTOK1FLnRvB7B3pXLxefQRuJxDF/LGBr1PKjbE4dkTMR0IS+6Y8J1CCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pG1kP516La+OAzARTQ5ACya5NLlvwv/VYaKgNln1Ry0=; b=kC7yu82RR0d8j/5Erq80CHqxR9Q/NtYY2D+CT9VSzQqLkXImwv0h9cTb3d9fvQdqmywVROD3EZR+jzRtN9ymuD3maEd+DiF3dK9KpzpuQuXHyH90M/vdCRhGBAakMLJy/9c4Sgob93FbmqM+GwaAdshGI4zC9BC+mbbGuwR9n+7qUo5vz0XL97mf0T3eHiqdq+W+KyMMhaMn5xQqR97HyrzXPGqtBG5/Gsbjbx0NS6q1Dinx/auJ4UgnZXBDTNpUaekUk735yB34LsHPT4COj7RIxAM8SHNDb+AWgla2LbeDxq9vEjJUtRY/p4uoBNWOtbE5U9U8DYadtvXRtiQ1eQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <59767cf0-8b1b-4418-db31-6b711518c044@suse.com> Date: Mon, 26 Sep 2022 11:58:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 From: Jan Beulich Subject: [PATCH v2] x86/PVH: restore VMX APIC assist for Dom0 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jane Malalane Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9326:EE_ X-MS-Office365-Filtering-Correlation-Id: a0c4ff8d-0948-484a-f8b0-08da9fa5ade0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EkyetDn9/OzktpsBAzxxBzsZcUyVzrtuisCfUzPBnhvDcJfNb3zz/z3tpQnSAI+x1yts+0oO4wzRlSLmKvxsgxwWE8OU4AkXrZ2VPdx3U+8HlQxv7cWHX40IkqDUB/OWRRclMHy+8jTns3Ud/Y2QDddcDi3w8mUg0wKxntiRXdArT8Um4yDnj/QpzC4Efd20dazzlcf0LYz7bHoD7kktC9DGRqLSenNswDKprWI4BdS6PgzzY6KkAADEbXUlFzaM1krbBsy3NnOQCBX+KCKfFEvQsnqqqNELOrJqQzHOGUDgSAVxN3qUmzSYDj0FYxMg0bZmkxh/55Y+IZ/htLVbvB6TrvBWcKg9Fnlz/1bIHe+wb2FamtSYcgo9/p25LhuLaQFH50PITma6wiR0q/fJ/8WycgEv7PRN+8joN8rbAItuEu625Dj2zj9iVUehnjOS1y3Y/0QMMrDUo+wz7DYm8c6r7OvoyXYkco5fBb++yeNThqLb7iAKloFqnt+E0+kQ6TLEoSqPHfKnavWlJuqLFe+r6ith8L7PbaplZvsG5tvsZRqtGQ5GR9xOAnl9oKp0kqfNoXZi3aERqZ+dWpi161mhp9uBVAIg8Zu4aLAgVwG1mPx2DEKF6uzgvqfuIPXA/mjVKMqRpdYSHqA+cqfLh2B8keEKi7kelM3wPuZU4EtQS3pkK81oeXUCDrhNDZid1bHczHNFTrZd+gYL/zpZtjvSMOAA0MClsLqlcevKercCQe3teJ3vK02ywjP/aWkJdDcOvbmCfHqphPXe79WEKonM11T7BuPGe4BYGm8j8z4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(478600001)(6506007)(6486002)(41300700001)(83380400001)(2616005)(186003)(26005)(5660300002)(2906002)(6512007)(6916009)(54906003)(66476007)(8936002)(66946007)(66556008)(4326008)(8676002)(316002)(66899012)(38100700002)(86362001)(31696002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnNDUmFJS3RWN0k2RTlURjNEMTBBOTBHVStGdngxRGg0eDNMb1F0UHZVY3Nj?= =?utf-8?B?a2ExV1psb2JBNHk1eUozWTBick90ZThUMG5LZEM5bnBKY1E0K0laUTNWZ0ZG?= =?utf-8?B?bEZyVC91b0hsa2RqMGVYOWRnYU1tMFhydEMrNnIvc0tlbnFJL2tBTmVrOGVW?= =?utf-8?B?V1p6TFhjYUIrendwRkpCN2NKVnBXc3AwbVpsWUVSdjl3ZUQ0RFlPRTFFSGg1?= =?utf-8?B?b20rQi9NWTA2ZUNsek44dC96SjhBWmYzV0t6UnR1TXNRcnVDeGRzcFVIL0pJ?= =?utf-8?B?clFKYUJSMEVVZFF6U0tWRngwTVphcXZVMkxMODA5WmtOYWNYUFFHQkZ4Mk1R?= =?utf-8?B?UTFOcXJLN1hVVTdpQUZ5VTcvL0RtN2Y5aGcvd3BuWlFQSnM5V2JkZCtnSG81?= =?utf-8?B?dEFzQWlVbkdTL0IrSGUvT0Z1cVVSbGF0LzEyUlFxakVRYUlTTEU3NW9YN2dr?= =?utf-8?B?bTBUOTB3bi8zU3FDVCs3MXhkUitzTHFkWnNkRFJvTHU4TWdqY2d4QjFhRHR5?= =?utf-8?B?dHBCdEFNeDl1NTBwcktpb202ZFQ5ZWloZDUyb0hidWx4VTJhS280Y2ZBK3Qr?= =?utf-8?B?dlVielNDSms4dU5Pd1VWUjlidUR6cjB3MGZja0ZUcUJ3QUFUMW9IVzdhM3NW?= =?utf-8?B?aTZrYTA5RTNkTnNGeTRTL1IxeERWeWpXeWx2Wm1VT1ZYTkR1azNKanIrMkpG?= =?utf-8?B?c09tTG5pYWdDV0JqSnpzcmNMeW4rZXlUcksveGJmbVZ6ZWt0L05BaTRNTG05?= =?utf-8?B?OGpYaDlPV3Y2bFBRcS9IZHpYR0xWbmJXNnFHdmVNaFVtU1ZPTHNJWHhXMlIx?= =?utf-8?B?SitCVDY2WUFmTHMyNGRVN1R2T2VZWVhHeG5nSTlXUUVVMmxXWHg5K1QyVDFw?= =?utf-8?B?UjdTYUplc3hOZWZ0UnhXVmxlMkduTHRocTIzbDJoNHM5elpNVGRYSDd1ZVZC?= =?utf-8?B?ektHNnBnRXN4S2hQb3h0dlpVaTFoMUpyZ052UHRUQ1dLTUt2b0g5MWpKQTR3?= =?utf-8?B?SUFYQkp0c0trVmNETHVTeHlXRytVN2g1QU51WlNRL2FpYmVzeVE1dHJ6R1o4?= =?utf-8?B?djRTWDhsVGJmaWcxSDVsZDFoQWY2N3hLSmpMVjdiNHB0TFg4R281R09scGI3?= =?utf-8?B?eUlQTlZJYVYydXE2eTgrc3UxWW1FRHJST3RiWGxiYU9Md2FaUFVtaUdUVFhl?= =?utf-8?B?eTEvSlhNcTV3ZFB0emtSbjBhbm9iWHI3UXU1azR5eDBIbjdIQ2IrZ2dLc0VF?= =?utf-8?B?anNLVWtFYVdXbE0wMTZKUjVLSVlTcTdXQjBKOWdzUXhnMFhOYVFhUFdQeVdi?= =?utf-8?B?TzdQMlovOE9objd0UXZVak83c0JDMnpGT010QWpCa1B4UTF0dTFWNmpHTHpz?= =?utf-8?B?eWNJdnU0cUpjbkJreFVOYTRORWZhRUpEd3JEeC9VZVQrU1hyd081eEFWTzNM?= =?utf-8?B?dkRuN24wNGFHOTJlc0MyT2EvWG5Rck1KRnMreFY2MTFhSGZBbjB5SnZqRndm?= =?utf-8?B?b0JwR0dUZzR1U2hoWndzczA1L05hT3FiZStualg5bTNVTWhWYTRMUzNNTlRR?= =?utf-8?B?aFhlZzlSYlRWMHJnNTBXNG90blE1WndJTklVNFBEVmFZTktHMXh2RXpyQ3JD?= =?utf-8?B?OEZ6N1VwWmUrQlo1U0Z6TC80cVJrVmlleGJUUVFCN3RjSkdVZHloTzF0MWZm?= =?utf-8?B?N0E5cHBHN2U5a09GVkV3NjZHZVdZd2tVR1UrSEVDV2RyUzIvOEQyVHhHSTFN?= =?utf-8?B?c3ZpTDlobjhxaGJHZUFLYUpBSzBPV1hEMDkvL29JYnJ0MkMrdklMei90NG9U?= =?utf-8?B?NGwxcnd2R0cyS2w2dHJ3YUliZjNsZlc3Z0UvSW5vVUZwUk9GcFhxY2xvN280?= =?utf-8?B?VUxqbUhmaUVoOHhROVJWNDVIWSsrbFJxUTkrL09RbFh4aTRQczBDaFZvbnFk?= =?utf-8?B?clBTT2JDa0dSVDd5YXVDdWdtanhCZFJiV2VrQytSclFFNHltYWNoT01hTjZl?= =?utf-8?B?R25PajhJNU40K3RvcEFTK3YrWG1zWllPdEtpVXFqZWt1VXhuMDBMOWNURG9m?= =?utf-8?B?VzZkQk1aVGFSdCtucWkvTnIrSXNJUzNmS0lPYm5VcDg2cENYTGg2aWtKYUFU?= =?utf-8?Q?V/WgUSx1jT1sWofjQt+B7UBUO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0c4ff8d-0948-484a-f8b0-08da9fa5ade0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 09:58:36.3218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ryBjusqwl14WXCDigurlHChDcNbMWagNWB1JYoruxAc+FfVqw0vRltqK/YKTqR1lXlu/X+cHQeMISzbK4KB/ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9326 I don't expect it was intended to default PVH Dom0 to "no assist" mode. Introduce command line (sub-)options allowing to suppress enabling of the assists, paralleling the guest config settings for DomU, but restore the defaulting to "enabled". Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Signed-off-by: Jan Beulich --- v2: Guard the setting of XEN_X86_ASSISTED_X{,2}APIC by assists actually being available. --- Besides the issue caused here (the manifestation of which appears to correlate with the other fallout Andrew is trying to deal with) I'm observing further warnings, but I guess these have been there for some time (perhaps forever): When parsing AML and encountering the objects describing the CPUs, Linux would find entries with the original APIC IDs. If those don't match the ones we assign in pvh_setup_acpi_madt(), the kernel will wrongly consider the entries to describe further CPUs, which it therefore would deem hot-pluggable. This again results in warnings, this time "NR_CPUS/possible_cpus limit of ... reached". --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -767,7 +767,8 @@ Specify the bit width of the DMA heap. ### dom0 = List of [ pv | pvh, shadow=, verbose=, - cpuid-faulting=, msr-relaxed= ] + cpuid-faulting=, msr-relaxed=, + assisted-xapic=, assisted-x2apic= ] Applicability: x86 @@ -828,6 +829,10 @@ Controls for how dom0 is constructed on If using this option is necessary to fix an issue, please report a bug. +* The `assisted-xapic` and `assisted-x2apic` options, defaulting to true, + allow disabling of the respective hardware assists. These are applicable + to PVH Dom0 only, and their effect is limited to VT-x. + ### dom0-cpuid = List of comma separated booleans --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -293,6 +293,12 @@ static int __init cf_check parse_dom0_pa opt_dom0_cpuid_faulting = val; else if ( (val = parse_boolean("msr-relaxed", s, ss)) >= 0 ) opt_dom0_msr_relaxed = val; +#ifdef CONFIG_HVM + else if ( (val = parse_boolean("assisted-xapic", s, ss)) >= 0 ) + opt_dom0_assisted_xapic = val; + else if ( (val = parse_boolean("assisted-x2apic", s, ss)) >= 0 ) + opt_dom0_assisted_x2apic = val; +#endif else rc = -EINVAL; --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -55,6 +55,9 @@ */ #define HVM_VM86_TSS_SIZE 265 +bool __initdata opt_dom0_assisted_xapic = true; +bool __initdata opt_dom0_assisted_x2apic = true; + static unsigned int __initdata acpi_intr_overrides; static struct acpi_madt_interrupt_override __initdata *intsrcovr; --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -68,6 +68,14 @@ extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; extern bool opt_dom0_msr_relaxed; +#ifdef CONFIG_HVM +extern bool opt_dom0_assisted_xapic; +extern bool opt_dom0_assisted_x2apic; +#else +#define opt_dom0_assisted_xapic false +#define opt_dom0_assisted_x2apic false +#endif + #define max_init_domid (0) #endif --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -784,6 +784,11 @@ static struct domain *__init create_dom0 dom0_cfg.arch.emulation_flags |= XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI; + + if ( assisted_xapic_available && opt_dom0_assisted_xapic ) + dom0_cfg.arch.misc_flags |= XEN_X86_ASSISTED_XAPIC; + if ( assisted_x2apic_available && opt_dom0_assisted_x2apic ) + dom0_cfg.arch.misc_flags |= XEN_X86_ASSISTED_X2APIC; } if ( iommu_enabled ) From xen-devel-bounces@lists.xenproject.org Mon Sep 26 10:14:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 10:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411608.654578 (Exim 4.92) (envelope-from ) id 1ocl8E-0004Hi-FW; Mon, 26 Sep 2022 10:14:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411608.654578; Mon, 26 Sep 2022 10:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocl8E-0004Hb-BU; Mon, 26 Sep 2022 10:14:34 +0000 Received: by outflank-mailman (input) for mailman id 411608; Mon, 26 Sep 2022 10:14:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocl8D-0004HV-JF for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 10:14:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 035b8b77-3d84-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 12:14:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B53982208F; Mon, 26 Sep 2022 10:14:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9529C139BD; Mon, 26 Sep 2022 10:14:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DeeGIod7MWP5DgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 10:14:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 035b8b77-3d84-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664187271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7PjyGWDL7Egnvvl4GyOrzeb8Uhxg+k4GQVEGhECWzhw=; b=EtI3F5Bc1zGYys9Y7UPsACfg3h0ycda8qrgDjhaea+sWztIEt137Ppo9I/A0NEmIqaYt4J 3wgjD9mdzk2Ge/3jexNw69q86NyPdUCi2CpungcKsPHVVb1U6UPGzKlqoH3H9gbH89bUIZ 2Y0bp8rkOqBf/f1DOPzPVTlXK0MlAC4= Message-ID: Date: Mon, 26 Sep 2022 12:14:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> <065ff8d4-2f8a-a771-e3a1-6853bb332b3c@suse.com> From: Juergen Gross Subject: Re: Design session PVH dom0 In-Reply-To: <065ff8d4-2f8a-a771-e3a1-6853bb332b3c@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------rJx9uWaYWlntyfTYj9fQPLQO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rJx9uWaYWlntyfTYj9fQPLQO Content-Type: multipart/mixed; boundary="------------53x0PcWNttmXfliWw1OjjfKo"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: Subject: Re: Design session PVH dom0 References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> <065ff8d4-2f8a-a771-e3a1-6853bb332b3c@suse.com> In-Reply-To: <065ff8d4-2f8a-a771-e3a1-6853bb332b3c@suse.com> --------------53x0PcWNttmXfliWw1OjjfKo Content-Type: multipart/mixed; boundary="------------4AbDxf7Tvk6DUwUBhZ8zcBPl" --------------4AbDxf7Tvk6DUwUBhZ8zcBPl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMTE6MzAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNi4wOS4yMDIy IDEwOjMzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjYuMDkuMjIgMDk6NTMsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIzLjA5LjIwMjIgMTA6MjAsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IE9uIDIxLjA5LjIyIDE3OjUzLCBNYXJlayBNYXJjenlrb3dza2kt R8OzcmVja2kgd3JvdGU6DQo+Pj4+PiBTZXNzaW9uIGRlc2NyaXB0aW9uIChieSBKYW4pOg0K Pj4+Pj4gSW4gdGhlIGNvdXJzZSBvZiB3b3JraW5nIG9uIGFuIFhTQSBJIGhhZCB0byBmaW5h bGx5IGdldCBQVkggRG9tMCB3b3JrIG9uIGF0IGxlYXN0IG9uZSBvZiBteSBzeXN0ZW1zLCBp biBhIG1pbmltYWwgZmFzaGlvbi4gVGhpcyBoYWQgdHVybmVkIHVwIGEgbnVtYmVyIG9mIGlz c3Vlcywgc29tZSBvZiB3aGljaCBoYXZlIHNpbmNlIHJlbWFpbmVkIHBlbmRpbmcuIFRoZXJl Zm9yZSBJ4oCZZCBsaWtlIHRvIGdhaW4gdW5kZXJzdGFuZGluZyBvbiB3aGV0aGVyIHRoZXJl IGlzIGFueSBmdXR1cmUgdG8gdGhpcyBtb2RlIG9mIERvbTAgb3BlcmF0aW9uLCBhbmQgaWYg c28gd2hlbiBpdCBjYW4gYmUgZXhwZWN0ZWQgdG8gYmUgYmV0dGVyIHRoYW4gdGVjaCBwcmV2 aWV3IG9yIGV2ZW4ganVzdCBleHBlcmltZW50YWwuDQo+Pj4+DQo+Pj4+IC4uLg0KPj4+Pg0K Pj4+Pj4gSsO8cmdlbjogUFZIIGRvbTAgcGVyZm9ybWFuY2U/DQo+Pj4+Pg0KPj4+Pj4gUm9n ZXI6IGl0J3MgYmFkOyBtb3N0bHkgcmVsZXZhbnQgaXMgcWVtdSBpbnRlcmZhY2VzDQo+Pj4+ Pg0KPj4+Pj4gR2VvcmdlOiBvbmx5IGZvciBzYWZldHkgY2VydGlmaWNhdGlvbnM/IHBlcmZv cm1hbmNlIHBlbmFsdHkgbWF5IGJlIG9rYXkNCj4+Pj4+DQo+Pj4+PiBKw7xyZ2VuOiBoeXBl cmNhbGxzIGNhbiBiZSBpbXByb3ZlZCAodmlydHVhbCBidWZmZXJzPykNCj4+Pj4NCj4+Pj4g U29tZSBtb3JlIHRob3VnaHRzIG9uIHRoaXMgdG9waWM6IEhhdmluZyBoeXBlcmNhbGwgdmFy aWFudHMgd2l0aCBwaHlzaWNhbGx5DQo+Pj4+IGFkZHJlc3NlZCBidWZmZXJzIHdpbGwgaGVs cCwgYnV0IHRoZXJlIGlzIGFuIGFkZGl0aW9uYWwgY29tcGxleGl0eTogd2hhdA0KPj4+PiBh Ym91dCBoeXBlcmNhbGxzIHdpdGggcmVhbGx5IGxhcmdlIGJ1ZmZlcnMgKGUuZy4gdGhlIGJp dG1hcCBmb3IgbW9kaWZpZWQNCj4+Pj4gcGFnZXMgZm9yIGd1ZXN0IG1pZ3JhdGlvbikuIElu IG9yZGVyIHRvIGF2b2lkIGhhdmluZyB0byBhbGxvY2F0ZSBodWdlDQo+Pj4+IHBoeXNpY2Fs bHkgY29udGlndW91cyBidWZmZXJzIGZvciB0aG9zZSBwdXJwb3NlcyB3ZSdkIHByb2JhYmx5 IG5lZWQNCj4+Pj4gc29tZXRoaW5nIGxpa2Ugc2NhdHRlci9nYXRoZXIgbGlzdHMgZm9yIGh5 cGVyY2FsbCBidWZmZXJzLg0KPj4+DQo+Pj4gTm90IHN1cmUuIEknZCByYXRoZXIgc2VlIHVz IGFkZCBuZXcgKHN1YiloeXBlcmNhbGxzIGZvciBzdWNoIG5vbi1zdGFuZGFyZA0KPj4+IGNh c2VzLiBFLmcuIHRoZSBiaXRtYXAgZXhhbXBsZSB5b3UgZ2l2ZSB3b3VsZCBiZSBhbWVuZGVk IGJ5IGEgbmV3IGZsYXZvcg0KPj4+IGhhdmluZyB0aGUgY2FsbGVyIHBhc3MgaW4gYW4gYXJy YXkgb2YgR0ZOcyAocGVyaGFwcywgYXMgeW91IHNheSwgd2l0aA0KPj4+IGZ1cnRoZXIgaW5k aXJlY3Rpb24gdG8gZGVhbCB3aXRoIHRoYXQgYXJyYXkgYWxzbyBncm93aW5nIGxhcmdlKS4g SSdkDQo+Pj4gcmVhbGx5IGxpa2UgdG8ga2VlcCB0aGUgY29tbW9uIGNhc2Ugc2ltcGxlLg0K Pj4NCj4+IFRoZSBxdWVzdGlvbiBpcyBob3cgbWFueSBoeXBlcmNhbGxzIHdvdWxkIGJlIGhp dCBieSB0aGUgbm90IGNvbW1vbiBjYXNlLg0KPj4NCj4+IFRha2luZyBhIHF1aWNrIGdsYW5j ZSBJIHNwb3R0ZWQ6DQo+Pg0KPj4gLSBncmFudF90YWJsZV9vcCAoc3Vib3BzIHNldHVwX3Rh YmxlIGFuZCBnZXRfc3RhdHVzX2ZyYW1lcykNCj4+IC0gbWVtb3J5X29wIChzZXZlcmFsIHN1 Yi1vcHMpDQo+PiAtIG11bHRpY2FsbCAobWFpbiBsaXN0IG9mIGNhbGxzKQ0KPj4gLSBjb25z b2xlX2lvIChjb25zb2xlIGRhdGEpDQo+PiAtIG1tdWV4dF9vcCAoc29tZSBvcHMgYWxsb3cg bGlzdHMpDQo+PiAtIHhzbV9vcCAobm90IHN1cmUgYSBidWZmZXIgY2FuIHNwYW4gcGFnZXMs IGJ1dCBpbnRlcmZhY2Ugd291bGQgYWxsb3cgaXQpDQo+PiAtIHBoeXNkZXZfb3AgKHN1Ym9w IHNldF9pb2JpdG1hcCkNCj4+IC0gaHZtX29wIChhbHRwMm0gaGFuZGxpbmcpDQo+PiAtIHN5 c2N0bCAobXVsdGlwbGUgc3ViLW9wcykNCj4+IC0gZG9tY3RsIChtdWx0aXBsZSBzdWItb3Bz KQ0KPj4gLSBoeXBmcyAobm9kZSBkYXRhIGNhbiBleGNlZWQgcGFnZSBzaXplKQ0KPj4NCj4+ IERvIHdlIHJlYWxseSB3YW50IHRvIHNwZWNpYWwgY2FzZSBhbGwgb2YgdGhvc2U/DQo+IA0K PiBMb29raW5nIGF0IHRoZSBMaW51eCB1c2VzIG9mIHNldmVyYWwgb2YgdGhlIG9uZXMgY292 ZXJlZCBieSB0aGUgdG9wIHRocmVlDQo+IGVudHJpZXMgaW4geW91ciBsaXN0IEkgZmluZCB0 aGV5IGFsbCB1c2UgY29udGlndW91cyBidWZmZXJzIGFscmVhZHksIHRvIGENCj4gZmFpciBw YXJ0IGJlY2F1c2Ugb2YgbGltaXRpbmcgbWF4aW11bSBudW1iZXIgb2YgZW50cmllcy4gVGhl cmVmb3JlIEkgZG9uJ3QNCj4gcmVhbGx5IHRoaW5rIGFsbCBvZiB0aGVzZSB3b3VsZCBuZWVk IHNwZWNpYWwgY2FzaW5nLCB1bnRpbCBhIHJlYXNvbmFibGUNCj4gdXNlIGNhc2UgaXMgZGVt b25zdHJhdGVkIHdoZXJlIHN1Y2ggbGFyZ2UgbGlzdHMgYXJlIGFjdHVhbGx5IG5lZWRlZC4N Cg0KLi4uIGFuZCB0aGVuIHRoZXJlIGFyZSB0aGUgdXNlIGNhc2VzIG9mIFhlbiB0b29scyB2 aWEgdGhlIHByaXZjbWQgZHJpdmVyLg0KDQpFc3BlY2lhbGx5IHRoZSB0b29scyBzaWRlIHVz ZSBjYXNlcyBtaWdodCBiZSBhYmxlIHRvIGJlIHVzYWJsZSB2aWEgYSBnZW5lcmljDQpmcmFt ZXdvcmsgaW4gY2FzZSB3ZSBtYWtlIHRoZSBidWZmZXIgcXVhbGlmaWNhdGlvbiBnZW5lcmlj IGluc3RlYWQgb2Ygc3BlY2lhbA0KY2FzaW5nIGl0IGZvciB0aGUgZGlmZmVyZW50IGh5cGVy Y2FsbHMuDQoNCg0KSnVlcmdlbg0K --------------4AbDxf7Tvk6DUwUBhZ8zcBPl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4AbDxf7Tvk6DUwUBhZ8zcBPl-- --------------53x0PcWNttmXfliWw1OjjfKo-- --------------rJx9uWaYWlntyfTYj9fQPLQO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMxe4cFAwAAAAAACgkQsN6d1ii/Ey+h 5gf/Q2paBMBZk3K/fN0Sh1O4tDa30TOoa3tl47bdMdvKG2zCZd00+05pYWNF1L7+NFwJQXNKHUus eegw8/VZO+Jf/B+MVyl++Yfr4/1Ui7FhjObj/H1pvnR9t+mJaXT5n2X7h5XKKXBM44rEFA65fxNT eSrh1eRNkm5PIfDxsFbW8jfhi+EB1zRPD1CgD4V6hcxqwBnQgTKqwjlqTD37+ItNNg4MU+C4AxZy A2Ix0Ur4cNF1gVA25uNX+9SISo+dXPRWkg8gbtgmthiBwPNebULIYC1/l2B/eBiGJ5ZXGrcfOcio jfJ3EARQU02QYXKzl/WyqwqL/5/fy7A18I2fvf/YgA== =SqEW -----END PGP SIGNATURE----- --------------rJx9uWaYWlntyfTYj9fQPLQO-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411616.654589 (Exim 4.92) (envelope-from ) id 1oclug-00019t-5H; Mon, 26 Sep 2022 11:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411616.654589; Mon, 26 Sep 2022 11:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclug-00019m-2A; Mon, 26 Sep 2022 11:04:38 +0000 Received: by outflank-mailman (input) for mailman id 411616; Mon, 26 Sep 2022 11:04:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclue-00019b-BT for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:04:36 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00707dab-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:04:34 +0200 (CEST) Received: from BN9PR03CA0060.namprd03.prod.outlook.com (2603:10b6:408:fb::35) by SA1PR12MB6776.namprd12.prod.outlook.com (2603:10b6:806:25b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 11:04:31 +0000 Received: from BN8NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fb:cafe::d1) by BN9PR03CA0060.outlook.office365.com (2603:10b6:408:fb::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 11:04:31 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT034.mail.protection.outlook.com (10.13.176.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:04:30 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 04:04:26 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:25 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00707dab-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWebEt+yomU+3OM5Leo7hWsPfAvz4mpAWLEnOg6XA5SbnCVTtq/HOTmenWOmxE+LscmJ3FT69X6eUZkL+PUO6LDzyb1dTexiRQQGLUo9B1nzATYah2VV3T5hpUXfTbJZXiIKCnzrOQvqijK++YmJIkDYiNu7Wx9vFV4v3bg2ZqPdfETU0S7s68Dg+czdPKYqRz0wo+1hUNRgRDpLrJeEHgg9lCzWgPtPZfeYWnWbg4L+7pmF7YVhWnzp+5FwN3bviaaULCivfbdrVmWfbKhvjBtmlF984s796yHg3LcFGGA1ZvbN7wM97eFU0Yd46qvCBGq53VdmCsyROwMKNiIhCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qYAjMu2SklZg1CLoLXnmRewVuZrNSTpNxiz/94OvhE=; b=ncQqtDGdFpzpGn1Q8xQVTISJPtbwXsl4IFawj3iUjE0D/s+us43j6tGDu56JDfJcmRoSHWcenEUgHZzBQ3tjWUQxPR3bXcty4oGavS69/KnUVR+TFk5Lrtsb6D2Miwcm3/ihrYiHg2VJPeUrXXIpNheV7jnzG+PCKz3RAX5GBwgkOWaU9TDh0rsW/npiGITfN1Wr6Kx6XsI+jfionVuMiUSRhCAtDUzZJue03XgI9q7koPzOfzMtZCFOSBuT+zCJI7gS8UOxsFyVrHncDxe6Bcg4AuTCA/+fgSnjdopgu42NYXqTyrbkmGQVXf6AnL9UPVqvIW1PLfj1de+ysgEVBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qYAjMu2SklZg1CLoLXnmRewVuZrNSTpNxiz/94OvhE=; b=jrtTsHC6jBLiRj2UvAXSc2xqHMcTTss1wvXkmXKt+xXnrJzKIXEcVSL9/TYzzWpxGGxzQZ2IF5LOGQ6SjTDEReFhg/UWb6gS6aKkoDKwu/wZfdvmqr3+ODM/Y2JnN9JLgj1IwS9jLBrJe1tRYmIowcbPo0BFq5jorGSBm72uid0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 00/10] GitLab CI cleanup & improvements for Arm Date: Mon, 26 Sep 2022 13:04:13 +0200 Message-ID: <20220926110423.26030-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT034:EE_|SA1PR12MB6776:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e4a17dc-43fb-4f9a-60a4-08da9faee305 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JaO0xUHiAA9ZSx1gDQ4rzYjtjV5x+SBBYFTrpUp30Unpkpl21Dd7xIEgINPWoaWGYyWUyeKiITp7mMuhTmCwH9dVdVgrgjNMHpabwAf7r3x7JSgqP8+lD+SO3ZSll5V+NHkXWQ5OTzH7ZIJxDYy8LE8ep8fxnLRZQT+5u4wVfIZ6XsjdvCW6f5GRUKSUexLf0n54ib0AQYXoUElDbEuJmPIbpTYT7TsucfZNWFbVdoSZmw9J0/6eXXpI3geO0gkQkCEqlUVD1IbqdneYQ0+TFs6L6IEg2QiqFYWE5OheiYp2MG0jMEt/uipfROjzkJ1kZe8vF6yYJqk29+ywJw79npfPlVpSD1QigYXhMQ6AP28se2ChU+0F9QvqJ6W1S4tbB4dTKa/ELdqfT1yB8iZ4XHhyj03wQoLNV5CGw4ME0auPGc6dTN7uEg9EgDyu1oS4AhimIUN6X8mI9j/YomJFvVg48KylS8Tv1wuZmWKaGYC7IGDOcComGhIBb7aQnfqRp5g+rPPdkc1Yc8O3levSmB9sHjT6c0iR18G/Y1If5P6CITBRGXx/AhpU3QogOHLs82XZ4fw/0VeASFxEOYhUgLYC+J2CIBvWzYK+juzEoNZhYM4m8nacDVui8efGkuJ1jcmcwtG8fA/sHenBD5a9k5KIjJ19aW9ZhkD96DWuvyDr0tQjQ0oPM4S/XMoCf9TRwvwUAx74tB3eUGJct6gGCu4Zzbo3LEcLy9MxRJbJsz/kB1fiIfBZxILxPMbZL2fQBa/gmysNsEEkGW/PD9Lo3UTtOlYnE5oij1NeplQJhsJnBWpZy7GS3oDUHB8+I54J X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(82740400003)(86362001)(81166007)(36756003)(356005)(36860700001)(2906002)(336012)(1076003)(186003)(2616005)(82310400005)(40460700003)(40480700001)(5660300002)(44832011)(6666004)(478600001)(41300700001)(26005)(83380400001)(47076005)(426003)(6916009)(54906003)(316002)(8676002)(4326008)(8936002)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:04:30.7627 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4a17dc-43fb-4f9a-60a4-08da9faee305 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6776 This patch series performs necessary cleanup and improvements in our GitLab CI automation for Arm. This is crucial so that in the future we can focus on adding new tests instead of spending time to fix issues, making the behavior consistent, removing ambiguity, etc. With the increased interest in gitlab-ci and using it locally, there is still some work to do mainly to improve documentation. This however, will be handled in the future series. Michal Orzel (10): automation: Use custom build jobs when extra config options are needed automation: Add randconfig build jobs for arm64 alpine container automation: qemu-smoke-arm64.sh: Increase RAM size automation: Add debug versions of Arm tests automation: Add Arm containers to containerize script automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder automation: qemu-alpine-arm64: Cleanup and fixes automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh automation/gitlab-ci/build.yaml | 43 +++++++ automation/gitlab-ci/test.yaml | 117 ++++++++++++++++-- automation/scripts/build | 8 +- automation/scripts/containerize | 3 + ...moke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 57 ++++----- ...pine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 14 +-- ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 6 +- 7 files changed, 190 insertions(+), 58 deletions(-) rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (55%) rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (88%) rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (97%) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411620.654633 (Exim 4.92) (envelope-from ) id 1ocluj-0002AF-DB; Mon, 26 Sep 2022 11:04:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411620.654633; Mon, 26 Sep 2022 11:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocluj-0002A7-9w; Mon, 26 Sep 2022 11:04:41 +0000 Received: by outflank-mailman (input) for mailman id 411620; Mon, 26 Sep 2022 11:04:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocluh-00019b-JU for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:04:39 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2084.outbound.protection.outlook.com [40.107.94.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01f854ad-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:04:37 +0200 (CEST) Received: from BN9PR03CA0059.namprd03.prod.outlook.com (2603:10b6:408:fb::34) by BL1PR12MB5351.namprd12.prod.outlook.com (2603:10b6:208:317::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 11:04:31 +0000 Received: from BN8NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fb:cafe::6) by BN9PR03CA0059.outlook.office365.com (2603:10b6:408:fb::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 11:04:31 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT034.mail.protection.outlook.com (10.13.176.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:04:31 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:30 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:29 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01f854ad-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPWotNZqldA204miG2KMgcabAzWqAfh9VmuNcFasGdyWMnT2uKoJxeGtJFJgdVCJXUs08s3fBsJ1+euPjeyCpVKcooffraFmtFm0GDbHdqWCu/yrsw6JgwR21D3RKELzY9MCqAv4LeuRYMRUfthdrKXvDfvshT0h9Q1WXXxNsEzHiQtIlAHPxdVm2yoCX4mlTL5Z4Wecp0ajTRJf9lwRxMCUkb/KCAjNl0MO/m/VqKj7dfzwAIOt0vWB+J05ZGU1pnd8SmOL8r+F5GbCnGp/D8Oi7xbBk5oePUaC4zHVEeAedzc5I7rmCeyAXqsjckejohNwbE5Y1bwZMyQhX+5azw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhykJUo9YFworA8q6pNfA9PuivCZjxRRVKJJQTCPJoI=; b=PGZClx1V0u8wxsIE0z6HXWHniIacSDTUD+OztuMglCYYfcqX6VJSn+SGIous0Izsg4/oVzN6KDBXBFP0/i8SsPF732If5Djb7haFAXZXFBW/mOLFCIUWIt6O1OHzfJqjaL1cCabA3Nfi0ZWwE3giuRry+RDK9Cm8zr4t3NcCOGLaAxXbe5wCDBaUzLROjNdLbm0Wi1LO5oMqW2f4ckw79O12EPkUZE/I3J7gFlMnwMCMxK81zbitvwGvjYz1Y3yaoh6FUV0sgtHMcAwgXO5BIdLY3VLED9u188J53vRaJ50q6SkxWNVFaxkNlVpIN1v91vOc2Ly2HztlOlDosW+2Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhykJUo9YFworA8q6pNfA9PuivCZjxRRVKJJQTCPJoI=; b=mUPgaM6TDP7okXCbHeZ34SWCuAySQyYSRo4S9Oe8F2wvwjwUMhqZ39m9YMX1tAqVcRFsANJLucmiw4fVuqOjZUsmUG3o861t3ljTBi4p6SNTHQHbNfCbVuTjb55+hfiQYWaohKGNl8zU21lLO433Bi3Q0sAcaSqM9kmJfk93wBQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size Date: Mon, 26 Sep 2022 13:04:16 +0200 Message-ID: <20220926110423.26030-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT034:EE_|BL1PR12MB5351:EE_ X-MS-Office365-Filtering-Correlation-Id: c27f0036-780d-433e-7f2b-08da9faee388 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nmPVktz8wTV7Lsz5ZSGfXtG2sFT7zugObt9sxjzMjWcD2AK2Llzk+82km9qXTWGZAFQSiYiLGAfJie+wOWUN0EgcExxurItF0tDziJ4kzkggKBCpKXiGz6juOTLusjwxeIBN3G4B917W4rPoYt8XWNKXXpFAShwmTTxGSfw1ueXSc8frr8Z65RzljzFDWRepIkXyZI4Qw95plpZMeHJz6x+nYzYV7wodn1tKy2mQc+zpDbHREP1Cdrl5mVgynGFtwsPQ2THHnSnPjZlopOcjWj/2zkluhoWJKBtnqG0lTv3DAzAOH1c5q5BoZLEmsF9AYEy3uUmvVdoJMeRynDT5y0IHT4xShaLLV0mtH6GbWgmFF0U/FA9XkQaKxnM7+d/rMjnYxcpvVi5pWqZ9RktY+ZTfQwdBD7xMGWoMmPU2P2/PCUIj1fP8U8y9YZJCXShwRy7sqE3oJi/pcKXTVBBsg4PfPb+bkwmwcR4Zqa3355SZwtCM1mVYLDd3mAfo20CrPKwqXwe6A32LQHf9WvLRmp8ksYMXQpuewvluvylGxSg3Y/lcsnWoIMuoGOG6jfzxB7CVJ6PsrTl3OI2cOXyw8UCpqdLjaPQCTcQ2/0ZOzNSpFJ844bpgwMHWKXXfYA2BMe64pS36GOLGAZOTfuB6t6aWGjLmoIA50STX9LfJSEwBNH+0lGtvsAF1W/mNEQbgLq1CqFhGbP6e3twmkbX8dv5KorykrBkoV5tlK4apM4IVd/jG4Sxc22CUBteaf+utIjhP9NGIv1UOl3BRCaMKdMt30GBh+H2RB8gP9H4I357Tt96vJN2Hq8hsv+1Siz/V9y6zF9tCvXV/Uxq4r7HV4lz73E3718rtbSAmfGztjRY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(6666004)(41300700001)(26005)(478600001)(966005)(5660300002)(44832011)(2906002)(40460700003)(82310400005)(40480700001)(36756003)(86362001)(54906003)(6916009)(316002)(8936002)(4326008)(8676002)(70586007)(70206006)(47076005)(81166007)(356005)(2616005)(1076003)(82740400003)(36860700001)(83380400001)(426003)(336012)(186003)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:04:31.6064 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c27f0036-780d-433e-7f2b-08da9faee388 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5351 In the follow-up patch we will add new jobs using debug Xen builds. Because the debug builds take more space and we might end up in a situation when there is not enough free space (especially during a static memory test that reserves some region in the middle), increase RAM size for QEMU from 1GB to 2GB. Signed-off-by: Michal Orzel --- Changes in v2: - new patch carved out from previous v1 [3/9] patch --- automation/scripts/qemu-smoke-arm64.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index f803835779f4..dea26c6c0a8f 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -52,7 +52,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -smp 2 -display none \ + -m 2048 -smp 2 -display none \ -machine dumpdtb=binaries/virt-gicv2.dtb # XXX disable pl061 to avoid Linux crash @@ -117,7 +117,7 @@ cd .. # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt-gicv2.dtb" XEN="xen" @@ -158,7 +158,7 @@ timeout -k 1 240 \ ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -monitor none -serial stdio \ + -m 2048 -monitor none -serial stdio \ -smp 2 \ -no-reboot \ -device virtio-net-pci,netdev=n0 \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411619.654616 (Exim 4.92) (envelope-from ) id 1oclui-0001i1-6o; Mon, 26 Sep 2022 11:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411619.654616; Mon, 26 Sep 2022 11:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclui-0001hX-2P; Mon, 26 Sep 2022 11:04:40 +0000 Received: by outflank-mailman (input) for mailman id 411619; Mon, 26 Sep 2022 11:04:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclug-00019b-Nm for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:04:38 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060.outbound.protection.outlook.com [40.107.93.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01fcdded-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:04:37 +0200 (CEST) Received: from BN9PR03CA0044.namprd03.prod.outlook.com (2603:10b6:408:fb::19) by IA1PR12MB6044.namprd12.prod.outlook.com (2603:10b6:208:3d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 11:04:32 +0000 Received: from BN8NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fb:cafe::3a) by BN9PR03CA0044.outlook.office365.com (2603:10b6:408:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Mon, 26 Sep 2022 11:04:32 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT034.mail.protection.outlook.com (10.13.176.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:04:31 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:27 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:26 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01fcdded-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=huYSwbO/Up1yeGBU6QHEigeA9Om0mjWp+mwZvSX5pkcxlcokyN92sJ9ZzABztkifxcznDRkhxMTumbMpctFiba06n2NXBHQgyqPfPrbYm6LdezJBNw2B00NpYFud+gP2ZJoEtTo3qimb8vwvuu3FBAw8iZ16a4MgZ4ECRuWF4cHakRBiTgFHv9kzEIyrZPWLn+HfNoyetr/6co9+DH05Q/Itqd4553QejJzUeB4vcANZQaylgAazsYXAjA0y4wTcp5sYxjLlou4PkD3TsdLrJc035pUUK5O1ToNp8itLW4JYPuQ97GW6AWCUi7wn/7I57D2s4XzVW2gMx6jvh1WSmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=at1Tt/XQ9b3STVOqJM76Aoj7GeN5AMiBivYZKaCUdFE=; b=Nuq4hGM7lZb9mbis1g9RPCpV4vv2jO0Df7v/2gEh0I9XgwFvD8yrP2/tlaUUZuHx5DYm2aBWlu5Rg6CqR5lcQtFHnJ1x0kRkAbC0fuxi6VEODV8N8NsA9j93flVPY/iINZBv5tMU2Fixm2t/xk9erhvKY+NVqqpRNrFJpSi74rRVdTt/Tu0hTsM97bcQ/hpSe148bqAy/6hWRUK7UiMt9Ym0gh3/ccZnGFz5O26gCATrN9lPAjVMzAPvlM9u7xTVelhmRRioE2sDayEvOl6tYW3/vM0BzQr/O8bo2SOB6LlFTknnnghiHbHZROTP90ccoZwuPAeXqucHLFZj/dlPeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=at1Tt/XQ9b3STVOqJM76Aoj7GeN5AMiBivYZKaCUdFE=; b=joOm6EHaCDXxbxneow8Tc7PMOB47ol3gwMnXPuCc9vYskSNtEncGkcJk9dEXQkSHpo6I4r/JKCS65UmNTBY+S6qHts/sAina5muuZP37XCt8PoFjhupgZXMOQYpQPClyxvElGcPR754x42vkP/1JMDJVev+o034A8yIoOYlijtY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed Date: Mon, 26 Sep 2022 13:04:14 +0200 Message-ID: <20220926110423.26030-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT034:EE_|IA1PR12MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a6ef89e-0ade-4e1c-6892-08da9faee3b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NztyCu+/48sBFXREylwTXH5yXcxLzujaqasCUWOGPFGG2zgY+v05KlKrbTTP+Lc9XZ3zoif52ptDXye3DbVoRs/p1N8aICHKpMSEWoTEuR8CD+TWJw9HH76EFvGp+MfLaZj+Kw01vWIQW4x3Wk1oFqP2+lOOjUPUPZLZu4VF9z57EJsirpIrMSk+IBu+I03DKcey2poOIwCTEFMhQwDQlvn51l7GhzUFmYCjkxfTPKDPAzqSjbR88ie//0TqjpaSRAzPscp2YqLvP8Gxvj52uOe9tUVlFqgwy5Q3fvx8oJe9a3X+s5F2yTDDcro4E6VvFrNY1xhECxU2kxjTMvQhzVDgEjD/uDUfbBtdF4BZEvrS6HiNdb+JP51+tLqWuILn7cbdiXbL59pxebyXW7AkrXrf569vMgeJgDuDFSm9CMCQCAtwDbd6up88zYPK3i6AbYPLG62m3vfXhwZ9MkjnumLh74ksaF61yX+iStxVgXsqusDPSFXblegvwMixda1zQYoNk4/5RogbL7fsgVnU7ZWyw1pX3cVbithH+ZBS3HruoChjtrlj5iJr29f0CcHRIVGzjGbFzMOxsF9VExohvqkZx+P3FMXpB9H9qXBwrp0q6MJXF8lhrSrV2ER2tgULjL+5gmyX1qN86rH6HCuc2o1d9OJZfvZBy0DUQuYbx16zcW7o3JbYIRZSqQCyPbpFnVbqkowbkiT21Lc5bAoBiyV75zoVyIj+l9dkkS3d8g/JPdmIhv17oTlPetRNR+9sQRsTDMS3l8AzlBirIqrc9VC0IXzHTisiY4PA0itaZDZe2LYaC+EJFAIc4k1K4tlg X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(8936002)(5660300002)(2616005)(1076003)(336012)(186003)(426003)(36756003)(44832011)(316002)(6916009)(54906003)(86362001)(2906002)(82310400005)(478600001)(26005)(6666004)(40480700001)(83380400001)(47076005)(82740400003)(356005)(81166007)(70206006)(70586007)(8676002)(4326008)(36860700001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:04:31.9033 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6ef89e-0ade-4e1c-6892-08da9faee3b3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6044 Currently, all the arm64 defconfig build jobs, regardless of the container used, end up building Xen with the extra config options specified in the main build script (e.g. CONFIG_EXPERT, CONFIG_STATIC_MEMORY). Because these options are only needed for specific test jobs, the current behavior of the CI is incorrect as we add the extra options to all the defconfig builds. This means that on arm64 there is not a single job performing proper defconfig build. To fix this issue, add custom build jobs each time there is a need for building Xen with additional config options. Introduce EXTRA_XEN_CONFIG variable to be used by these jobs to store the required options. This variable will be then read by the main build script to modify the .config file. This will also help users to understand what is needed to run specific test. Signed-off-by: Michal Orzel --- This patch is supposed to be merged for 4.17. The release manager agreed on that. Changes in v2: - replace [ with [[ to be consistent with other ifs in build script --- automation/gitlab-ci/build.yaml | 15 +++++++++++++++ automation/gitlab-ci/test.yaml | 4 ++-- automation/scripts/build | 8 ++------ 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 720ce6e07ba0..a39ed72aac6d 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: variables: CONTAINER: alpine:3.12-arm64v8 +alpine-3.12-gcc-arm64-staticmem: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + +alpine-3.12-gcc-arm64-boot-cpupools: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_BOOT_TIME_CPUPOOLS=y ## Test artifacts common diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index d899b3bdbf7a..4f96e6e322de 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: script: - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - - alpine-3.12-gcc-arm64 + - alpine-3.12-gcc-arm64-staticmem - alpine-3.12-arm64-rootfs-export - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: script: - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - - alpine-3.12-gcc-arm64 + - alpine-3.12-gcc-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export diff --git a/automation/scripts/build b/automation/scripts/build index 2f15ab3198e6..bcfa6838f0bb 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig hypervisor_only="y" else - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then - echo " -CONFIG_EXPERT=y -CONFIG_UNSUPPORTED=y -CONFIG_STATIC_MEMORY=y -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config + if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then + echo "${EXTRA_XEN_CONFIG}" > xen/.config make -j$(nproc) -C xen olddefconfig else make -j$(nproc) -C xen defconfig -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411621.654641 (Exim 4.92) (envelope-from ) id 1ocluk-0002Hr-0y; Mon, 26 Sep 2022 11:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411621.654641; Mon, 26 Sep 2022 11:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocluj-0002Ff-Py; Mon, 26 Sep 2022 11:04:41 +0000 Received: by outflank-mailman (input) for mailman id 411621; Mon, 26 Sep 2022 11:04:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclui-00019b-Ja for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:04:40 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0217ed46-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:04:37 +0200 (CEST) Received: from MW4PR03CA0189.namprd03.prod.outlook.com (2603:10b6:303:b8::14) by SJ0PR12MB7005.namprd12.prod.outlook.com (2603:10b6:a03:486::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 11:04:32 +0000 Received: from CO1NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::93) by MW4PR03CA0189.outlook.office365.com (2603:10b6:303:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Mon, 26 Sep 2022 11:04:32 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT086.mail.protection.outlook.com (10.13.175.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:04:32 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:31 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:30 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0217ed46-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MhvdR0h/R41oByteBayC1Rh/YEvrlugnHVoUFNvIJUQd05EL4m/m8Xba8TsmG6kdUwjbJNxedfpRDEbYlYu/8pVM6WBaMNRfAL3KiQ7EJV+2g6VTRUBsvUasA5OvV9TegZjmxoO8+OFBNYA07oa4+eaWV6kdaP1UUjx/rAwnNsQTJBRL2HS38HTcwh8HS35Hk6bkuRPUjd39ZL4ITrPkuQglmhwFjCJVfG+G567wCtkUF5lnUXUFMcSL7wRwC0r7WXHuOPV530KgQLfs0IofjjeEW0663zknKe6b+paJtS6QzUpUvoyyEF5NCu1YKzYNOC/r+25BPvzfS8gpvJ5+TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KWCaDZXLfwxQLLRp12PA1vsdtwQFknk6o5olLX6kvjc=; b=UvxZ6m5Qgs9X8l9rwbYW1mSYoz228O1KiRSp4PeHSPyzXsR2RvfziGKaS1rmknGApt/Sqmj8JexkJvhC9SMIhHiGH6RLFxDZ6K93gImri/VWRUYY3ZLpAp4Cbw1W3nqoYy2YDYb4MqgDOGzlfDS36pX1nQi65zVVYgoBlBR7dbcHU+npXJj94s6u9X3Lgxsc8btUTiU4umpFHV3UHfUvFy9ujMnGNKMT9toLs6ndz1nM/7X0yXydyhsLDOQ7K1RnbhzSS5Q/sT7b6qhwQAVJo0hR4wKEfoI8XeentMM/KY6wB2Acw3wweUHara9O9VJi0JjESFanVCKkuxe6b4C/4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KWCaDZXLfwxQLLRp12PA1vsdtwQFknk6o5olLX6kvjc=; b=xrAZ8hnm6iSqxiEzyG+izFOYLn33rfPfOYP+qjLitHPOVsvN3iScIYMU0D55INRgNXLTfKmv9CLQsy7Miy/ipI09OKNHjHM+LCHXXNBvQvJNzFkwNM8vNAKg0gGKfS+COU7mhHCnK7RA0ZZBCG6lTHvZaFBxQm5Hklerqjno7no= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 04/10] automation: Add debug versions of Arm tests Date: Mon, 26 Sep 2022 13:04:17 +0200 Message-ID: <20220926110423.26030-5-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT086:EE_|SJ0PR12MB7005:EE_ X-MS-Office365-Filtering-Correlation-Id: b4dac79b-8a6f-4ce9-8f2b-08da9faee427 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LJoWH/bAv7Rx6+bXdaj94CerovCt36CTED1bhWO8GZWrrlSzsdhdgOXbypMsaWb3dxBVpM1WvGU6nI2iviKLm4MsUHaHMrHk3d0+ttqlHL7n9NLvijWdKP9caE82Osy1ThkFvsyt+stBuMsaMES3+l5Yxu6KVCs+3FdrdVMCQz9Chzw9qxYz/dHOAYgeQM7urC2cDtGs9X1yIqWqXeJs9GBuM3LtUv0fx6jf8GmyLEkhHBzR3mF+ARmG4N15eDzQ6IufP8+GugknMNODA/ZTw0IEadjwlooEK9vQUy1vpz37h8W9X4Bi+H4a3EfNYjd2xk4lUC/HboRHOXuxOozgRg+C1/retMz8Hi39iZl/acnZlCBSchuzF3+nLqNy1TYVKcAnD1tm1qIMrz2bbxqY/LqZWt45oB/d3e5vSPRRsJcXoE5I70XARKUx3FGlsCybHSrq6EWInz6M3lotHw41NyYtPjUSyVV862pyOpgjDW8gg2OoUsxJuTeZzSKk9yVDHgLWjXN++6RKNg6ukp6vNVyv3M58rN0lzQaZGb9dFH1T/bWhFRG+cy44vIpxHGydB/ncWrPSm/dlqSpBTk35Fti6I/ucWYU0rqrT5MFwPvsnzJ2lAJKT0JGUJhhsdKIcMDmUqsQcHq+QFHCvQ6FMeGRqep22aiOpQylICdaaQYRKPNSZ63FHcXDSGN27vo15WOy0d01pyf58cYx9NrsMp06+hicWOKqsAJh/sZxCv0C4kDB/sohjXC4w0QkWp5iYudr+kPrkmvbK+h2HKhSakSNtL/OebBSXUDqDicv6T578hgBuu2G+LdGWg8SUac7f X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(36756003)(40480700001)(86362001)(186003)(336012)(1076003)(40460700003)(426003)(36860700001)(82740400003)(2616005)(82310400005)(356005)(81166007)(8676002)(4326008)(70586007)(70206006)(54906003)(478600001)(6916009)(316002)(26005)(5660300002)(2906002)(44832011)(41300700001)(8936002)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:04:32.5395 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4dac79b-8a6f-4ce9-8f2b-08da9faee427 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7005 At the moment, all the tests are executed on non-debug Xen builds. To improve the coverage (e.g. we might catch some asserts), add new test jobs using debug Xen builds. Signed-off-by: Michal Orzel --- Changes in v2: - carve out the RAM size change to a separate patch [v2 03/10] --- automation/gitlab-ci/build.yaml | 16 ++++++ automation/gitlab-ci/test.yaml | 93 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index d931441b910a..6ce92531f61f 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y +alpine-3.12-gcc-debug-arm64-staticmem: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + alpine-3.12-gcc-arm64-boot-cpupools: extends: .gcc-arm64-build variables: @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: EXTRA_XEN_CONFIG: | CONFIG_BOOT_TIME_CPUPOOLS=y +alpine-3.12-gcc-debug-arm64-boot-cpupools: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_BOOT_TIME_CPUPOOLS=y + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 4f96e6e322de..1b51030c6175 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: tags: - arm64 +qemu-alpine-arm64-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-alpine-x86_64-gcc: extends: .test-jobs-common variables: @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: tags: - arm64 +qemu-smoke-arm64-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm64-gcc-staticmem: extends: .test-jobs-common variables: @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 +qemu-smoke-arm64-gcc-debug-staticmem: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64-staticmem + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm64-gcc-boot-cpupools: extends: .test-jobs-common variables: @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: tags: - arm64 +qemu-smoke-arm64-gcc-debug-boot-cpupools: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64-boot-cpupools + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: tags: - arm64 +qemu-smoke-arm32-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + needs: + - debian-unstable-gcc-arm32-debug + - qemu-system-aarch64-6.0.0-arm32-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-x86-64-gcc: extends: .test-jobs-common variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411618.654611 (Exim 4.92) (envelope-from ) id 1ocluh-0001eo-V4; Mon, 26 Sep 2022 11:04:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411618.654611; Mon, 26 Sep 2022 11:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocluh-0001eh-Pj; Mon, 26 Sep 2022 11:04:39 +0000 Received: by outflank-mailman (input) for mailman id 411618; Mon, 26 Sep 2022 11:04:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclug-00019b-6t for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:04:38 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01cf9f92-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:04:37 +0200 (CEST) Received: from MW4PR03CA0189.namprd03.prod.outlook.com (2603:10b6:303:b8::14) by DM4PR12MB7669.namprd12.prod.outlook.com (2603:10b6:8:106::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 11:04:33 +0000 Received: from CO1NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::8f) by MW4PR03CA0189.outlook.office365.com (2603:10b6:303:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Mon, 26 Sep 2022 11:04:33 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT086.mail.protection.outlook.com (10.13.175.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:04:33 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:32 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:31 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01cf9f92-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0YNg4e+aMJMRWBjQKaGc3NI/fTKBZ4O/4OUvO8G8iUOB7XMciy2l0+bQBRNd7dwXWxO+JJYmetHVVpdv73V372FTsVd8SB5Z/hw8nmxcEmv8arEC6mIRrYsnzPhKi9zfvjwFJ7OVD0UwCUvR2j2eW2FZC3OkAVMRENAHvmx3txf9bP36Za7rn6l16OdqqmvL5Co7xpmzp5d9XOXVwvs++Ase93wqemQis44H27FFU9lsNuFm09K+4o3h5rTG5wM/ETz8es1i17benRZ5wyxt6yctljXX9XyPZgPd8mhtFY1Smv5zw0n6/V/kCDoexkhqibTqqUVx95Tsg9jXwjO7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XNgqClqMiM51F2XPe1n6tn6T8qkG5GsnlFend6N3M50=; b=aXHFK/KawR/VVCguBsseHEI9NXS/1VyjYFawEi3/pVCefGDGayI5W21dyMsf1JyilF9Q7uD7XEhDPnMVJYYTQgB2gjsjaV2ILi1SG2VN6AnjhTXvSyg9JPPynzA/wE82SnAMZjuCTUAoFh4l1QpOYnY17hq0l16W+eTfwuvkd9VwwPzyib5ofTLRkXVpJVwbHG2kRnMXA0WqEkxD8TpYynw8kwldTwQ31oI2T80E+DVB/+LOcvS3w05kZmj/m6mQlqmL9N66ny/Fy4z9647rKYRQ2uaR1MJI35hJC5j+PeRyPCheITKHX82FmElvloQRNVyAGmbUJxAhd/BXPM3KtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XNgqClqMiM51F2XPe1n6tn6T8qkG5GsnlFend6N3M50=; b=nDP4JByeE5W4p5BaIG9MF+ToefnE8EMNwhI+uZ7f9USV20qD+f72Q8ZEPTu8xrcVxbKDvKWkoqIJqoSt0mhMgBqDdr+hLw14Ue0yXbdkNxLniBle+tIWSALXsGdPYvZSuon1xntMi2DvcRt01UpQKcnX1rbpZ9K32voAcvBIFGw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 05/10] automation: Add Arm containers to containerize script Date: Mon, 26 Sep 2022 13:04:18 +0200 Message-ID: <20220926110423.26030-6-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT086:EE_|DM4PR12MB7669:EE_ X-MS-Office365-Filtering-Correlation-Id: 7666bf9b-b8ef-46f4-eb58-08da9faee486 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AQeLAsifxt/OmEZ4xc14CGlAKKi/U83cO3zVNY6xI33/mh+ONFmLMOQ8F1Yu0ahYW/d198Urv0aVrGxCG7AAYFFkordJE75Ed9rPMI3mce493QpDp3hTC07CHMigjxBJ3TZuKxmBmW2TiswAB99F5H1SacL30Q25wItSyOrY8jYktao1ncJWhCWkyzXwXGY4GJGAo673QjdCWe5DNFLfZaprd+Rg2dFL9vDlu5h04VeZWx3eOJprtPbTxvkJMUASd7y8jXh+1RBcAHxaOVPrTl2OvRy9nYs00g7xigjMZskqTWGSTzLIODjpdNQL7tAKB66Fu+yXJ7bji6dhIe4WLGATFCPaZFWbcO4/kbTvO/x4GE8ZQxSJFhFYgAV/WuCFN+N94R3ySlusy2H/W4d0ZodnusswHDunEvdOrlmZXB7kPqGFKpCrKQq6Q0ql7o1HoH5lokWP2+bFNRz4S0l2th2cH1S8evT1kJeN4fli6DFLaWg4/HTKEbyUjlwtwe4m5aEjy0peL1kaKiguqockaIdibvKQKbIe1FTKIkq5fgYCEcUAAJJDn/r18/krcAWINJJeAzJ21ZugcgTJaKGf2i01M2cs/1PXll2nTGkeX9dRg+eBu3P3PffJrQyyTr6OEJmDzi3ssc8y93cKvzRwqRe1/XWWHYhAjikHgRP0G9UN8ZErrt/PTJbWXM70et1eQ9d4IkUsL4+7/uBTQf+ZmfsjPAzAPRyfjsjtRS0yMdphb6vgBlm/HREuZta1LXZFJ7FtNisVl1o99EbdxRIK8RJNFjDyntDaWwgxQ6blRrAkdpVBq4l0DE58jhrAW/3M X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(81166007)(356005)(336012)(186003)(426003)(36860700001)(2616005)(82740400003)(1076003)(26005)(478600001)(6666004)(41300700001)(8936002)(47076005)(70206006)(4326008)(70586007)(8676002)(2906002)(82310400005)(40460700003)(44832011)(5660300002)(6916009)(54906003)(316002)(86362001)(36756003)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:04:33.1644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7666bf9b-b8ef-46f4-eb58-08da9faee486 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7669 Script automation/scripts/containerize makes it easy to build Xen within predefined containers from gitlab container registry. This script is currently missing the helpers to select Arm containers, so populate the necessary entries. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v2: - modify commit msg to reflect that we are missing helpers but in reality it could be possible to use Arm containers by specifying the full path to gitlab container registry. However, such usage is annoying. --- automation/scripts/containerize | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 9d4beca4fa4b..0f4645c4cccb 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -25,6 +25,7 @@ die() { BASE="registry.gitlab.com/xen-project/xen" case "_${CONTAINER}" in _alpine) CONTAINER="${BASE}/alpine:3.12" ;; + _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;; _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;; _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;; _centos7) CONTAINER="${BASE}/centos:7" ;; @@ -35,6 +36,8 @@ case "_${CONTAINER}" in _stretch|_) CONTAINER="${BASE}/debian:stretch" ;; _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;; _unstable|_) CONTAINER="${BASE}/debian:unstable" ;; + _unstable-arm32-gcc) CONTAINER="${BASE}/debian:unstable-arm32-gcc" ;; + _unstable-arm64v8) CONTAINER="${BASE}/debian:unstable-arm64v8" ;; _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;; _xenial) CONTAINER="${BASE}/ubuntu:xenial" ;; _opensuse-leap|_leap) CONTAINER="${BASE}/suse:opensuse-leap" ;; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411617.654595 (Exim 4.92) (envelope-from ) id 1oclug-0001DP-Hb; Mon, 26 Sep 2022 11:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411617.654595; Mon, 26 Sep 2022 11:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclug-0001C6-9w; Mon, 26 Sep 2022 11:04:38 +0000 Received: by outflank-mailman (input) for mailman id 411617; Mon, 26 Sep 2022 11:04:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocluf-00019b-1O for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:04:37 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0011e77a-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:04:33 +0200 (CEST) Received: from MW4PR03CA0210.namprd03.prod.outlook.com (2603:10b6:303:b8::35) by MN2PR12MB4224.namprd12.prod.outlook.com (2603:10b6:208:1dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 11:04:30 +0000 Received: from CO1NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::e) by MW4PR03CA0210.outlook.office365.com (2603:10b6:303:b8::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Mon, 26 Sep 2022 11:04:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT086.mail.protection.outlook.com (10.13.175.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:04:29 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:29 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:04:28 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0011e77a-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zk4XcQcMWbviSrvndo3NjrZ5h53lXYtKIrc11ydOw1bMmSfB9KZcF75DsSDjAQ0wFdKRf/WqiJ+0mA4LNr0i7c5n9/cMGbTcB2ZRJctuman5ubWUDkbHyKyJsTnd+YrfyWVmb629JbL+uRv7I9vMx6lng2iG3EQs8gpLGpKxmbGy+5UD/DrN8URKm6k3uAieGFbENtZHauTwIVJikKSnrofV5tguni1WaYwIS96oBAPvFXiRu7WrkHwdBZi1o1VbYTpLnqo8YvpFNurGPPTvFqEVD+qIXVlFXbG22qzC/tGBSi/ucXLwmAP9Cn3Ar+YhwzBh3g6SlJ7h+Xd3j1o3Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UpOdCBVw2/Uk5sfAz8C2OIxTFfIf2yMq4g3IemE/uFA=; b=L9PE1PffxfWL9/3un0kFK9HDWPJslc3gHfUW5Sjk5Dq2zjCiitJ9fin9f2sP/QexSoivyrJa6xZsxcGWD3f+xhOJs/R/+eZg9QoAHUqbDw5F1BSNg8X3otKlJne5QdceSUxM7hvZtV08hlkQ+UM5uax6nnZa8WehBX826HxJ2QyVf9eDpYMrFWBnh/W50OU/9DCmRqgUrPcRwKNT+TK62MaCb2pX5qIR8gZLWccqYNPpbVGBkWgBxk08AmVQKu1Fj4biL+ayayIiUI2/HYNt3mS1TLgrKr82mviBu0+zhMTS30qQWgNlLvKpzflHf13AQ7DlrPkPhhybtBlvJ5+OTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UpOdCBVw2/Uk5sfAz8C2OIxTFfIf2yMq4g3IemE/uFA=; b=JHwC9qGzZk4iNs5RzoLjsUHCqgzUZCpBBJjSAS2g2N8j4LhfdRV7f9k22mCzoguvhSICylMXiV1x2Oi8elwqFXcdUlx3BGLxszNWRsVr2p/wDOhe1ILvSO2DWo1D0SFP83VQw0IQmiDbXsfQ13izzmV82KsUd1husYXP+mFpeoc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container Date: Mon, 26 Sep 2022 13:04:15 +0200 Message-ID: <20220926110423.26030-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT086:EE_|MN2PR12MB4224:EE_ X-MS-Office365-Filtering-Correlation-Id: 850e27ad-4899-427d-32c4-08da9faee29e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5rPmFXHXHgtub/lJdHITzrX/tHFybkxqJkIcP/1Y1Jd8P7gr+8UhwLJM7K1vHNXb0128hd/XdF9CTe/czRyTVc0ltsEZzxgslJpDs9v/qJ4mV4MQw1QeddYYWqb8E3pWg7Bmc4ZCBI1pY81mCohjiFiwji9hSI4tMj3VezysuKLwIinNNmkZ13VhoNCyoEUD/tbcpF6t12k6YXkQ/cQUEjWPsd3upn9FeRWrVF1zsZe9YuaoS62eLmkMB10082IbhTw7vVvcsVvJ58NsZ1irVezdz+/WMfwbZeecAWxe3YnCGYOr6KT5NO5kzx1q5GcLkFLSQOINsa3GpS8T3XtS1U1GGutAq4VdRbaf5qLXh7mnx5jBnkOjaZV7AOaZEBkU2c9eB6woHv7RGl44/ceRnBqb9rHxcuYyLVUwj+bvjB6CoX7I4ku5JaBVPlxXdQx4q8itmfYnRrJxqULCiUNQ9yg2ahQV9gvbnTHL6CcZ/sezW8gUw5GBsf8YJulbs9VpHHAy5+hJoVKRcSzOT0c1mwgiixqAjnkwPnwn77beSbWo7mgZ4dr8G+iHFULAjGU4vgyJsM6rNuQ+fswOqYlsrsCr+IWyuV/2c34kEopfa+Qc0C46EuBUkorx0wcfiBIwQe3lbZzSu6huTaxZTlyiVgMHWDAseO3O+p9juqy9jS3l8ADfNaRlB4VYklFQCvyucYszjQjayqNfJ0uPyEP0yxWhJ9VLSk0Hs9icJ1xEYJeNfUQNmgLw1hJmmhIuRnFsVuDJfgI+yP83hB0PRDOd5DTkZ4r4qiOxoOQh5kjMLluIznVEgTCEM6hgRQtDpZap X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(426003)(41300700001)(81166007)(8676002)(4326008)(70586007)(70206006)(356005)(26005)(40480700001)(2906002)(44832011)(86362001)(1076003)(186003)(36756003)(2616005)(336012)(8936002)(5660300002)(478600001)(6666004)(36860700001)(82310400005)(316002)(82740400003)(40460700003)(54906003)(6916009)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:04:29.9616 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 850e27ad-4899-427d-32c4-08da9faee29e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4224 For arm64 we perform builds using debian and alpine containers. We are missing the randconfig build jobs for the latter, so add them. This way for each container we have 4 fundamental build jobs: - defconfig non-debug/debug - randconfig non-debug/debug Signed-off-by: Michal Orzel --- Changes in v2: - none --- automation/gitlab-ci/build.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a39ed72aac6d..d931441b910a 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -566,6 +566,18 @@ alpine-3.12-gcc-debug-arm64: variables: CONTAINER: alpine:3.12-arm64v8 +alpine-3.12-gcc-arm64-randconfig: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + RANDCONFIG: y + +alpine-3.12-gcc-debug-arm64-randconfig: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + RANDCONFIG: y + alpine-3.12-gcc-arm64-staticmem: extends: .gcc-arm64-build variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:06:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:06:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411643.654655 (Exim 4.92) (envelope-from ) id 1oclw9-0004Xf-Aq; Mon, 26 Sep 2022 11:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411643.654655; Mon, 26 Sep 2022 11:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclw9-0004XY-8F; Mon, 26 Sep 2022 11:06:09 +0000 Received: by outflank-mailman (input) for mailman id 411643; Mon, 26 Sep 2022 11:06:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclw8-0004X6-I7 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:06:08 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2048.outbound.protection.outlook.com [40.107.94.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35b3f7a9-3d8b-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 13:06:05 +0200 (CEST) Received: from BN9PR03CA0058.namprd03.prod.outlook.com (2603:10b6:408:fb::33) by PH7PR12MB7308.namprd12.prod.outlook.com (2603:10b6:510:20c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 11:06:01 +0000 Received: from BN8NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fb:cafe::a4) by BN9PR03CA0058.outlook.office365.com (2603:10b6:408:fb::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Mon, 26 Sep 2022 11:06:01 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT028.mail.protection.outlook.com (10.13.176.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:06:00 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:05:28 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:05:27 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35b3f7a9-3d8b-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GpR3qIUqEnvab4Q4jS7aFNbjd09dWNfzw98TA7r+jYqNRJizKU4mMldvUaFDbuHn2F0/wNTe9D4I/TN4wxkL7dLUn/AetHJpbuJaiElqEY3Q1AEUlcn3VGaJuHDqBEG8IwPOLKV6WcfvOfnLpJfW2XRgl7AGTTHwAPBtAvI/2gGfOPI8wxn36hMHvw8yHODLJjiXw86LB8ZlXkkVHdnckT+S7hBoe8pJgUQiiillKXGQeVV5gUtVwyejT8tTtRVtOVZzzVsvmQKhKN6YUc13U0tDAnD++FLXAH+BMF7yXNkVMJ/hVN8TjvrkeflC5Hc0zv7i75CjUwdNgkPzkYyMUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nm2GB71Av9Lfb7OcaO5zjKxQmHNj/cnStyksFxhKYP0=; b=iiV3yTKhtSmaswn0zZV72XJDNqk6cmZW0+Ta0ChDTUUUZ1F1srvR8c4EeURu9/5mkvDA2oeEKn1USSmzyQbF/3oll6DABdmko+4MY8dsisB5fpnMabiYeboXRmBkgLecfisHE/0ml6KUTivPeXEhyAoFV6Bl3hiuKqnxGf9Zhn2q9h/DFxk2yisdYEItBo6Kxt2vj4D49MseEjM1iLlEfKU/pniFeRKWdShSt4vZoOa5VgFeAQ7RvwKCurso8gAEWEXLZVut8k9WlcKBtEQQwW4w6vpa7gwpuxmSnuia8DHtTFZF6upUZlcWY2aMLjOTueXqXDh6xW/m+Ro1ftx7iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nm2GB71Av9Lfb7OcaO5zjKxQmHNj/cnStyksFxhKYP0=; b=41CP7794EaWlR2JNzbM8OdXiepWtiJNP17xdNpKNpL5GETShCVQIGIjBJ02XRhFnYiGDKabAEz2F5woEBApEqvwaWxL9rwHjXOX4pRGVuPQ34VtGSG/WMlE1DR2cV70L8KqNd1uT/6tHRtTE1tYk0NMLcuR/VF3qGxvEVWn6IXo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 10/10] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh Date: Mon, 26 Sep 2022 13:04:23 +0200 Message-ID: <20220926110423.26030-11-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT028:EE_|PH7PR12MB7308:EE_ X-MS-Office365-Filtering-Correlation-Id: 70640995-7621-4cdc-e943-08da9faf18b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0nGaKP+YZ7UB2c56B1ITZGDtifEmYrxvF16UI1OGDrIHBsybAwSURRxrP9v5UBHfX7/GRWAckpPGuHo2lNH9PLk+9nnGa2hJX+ivlW+OUX0lYkI+3A2mVrsKztV3fOVZ4QRhOrZWaZ4nPavyJWv6Js4mWpuyq2hJT9zKgIYV/i2KPioJgQsOiHkP3mDaJEPiqSZjjpKkyrWyAzqWJXYO0Cip/S4pMykF/6/VImSlwIW8Yjm65k9RCpJMNmnNDpemFZiVwPc+0xy3Ef+EJ0+dg1Y7wsACGfHE6lC8YmimWArHboyPXHxfoBZX26r6VtujmnV/2Nm2/ykbRX5jFj5rp08+bGY63uFpKEmseUb3iBX76w6Dhqr6UplhPvt/U1CumNj5Hj6IZQ3A+t+s78ZLzrdBQm5wFcquGKt0gDaH53OYREZhlQexUGfKfoILLC+j6P5qhZw+BhPFvU96XMuhj/gqJ0SVdUr8zSKiiNYLL1Jx3GJ74AKv/bU5wb+5/XYHrDXfxB5W1QUqVq2zeP78kPwlkJ67P8O6A69nXB54FUPFLYDFrFCnqLvCx+9OevnUn/IN5FHG9/LEsJyg2DHfb+gSO/rgzQcpVjPKXmbXUoaSyRdL2wJTRpUuwTSdAxV4P0pTn+gmU+nyHHcqpuDu/0FqKcRgCk2rRDMAysTVmKmhDlSzdwqEFQJHTVlpz9KLLrfi9AW4NrRKH15M4rHlYk/yQ3bd0V+nPVU/6sl7eSexbSWLE43XPMlnD+S7/z1TI4OomgvYPGTlBaNowLmfY6GjgBNNK2tf/ORa8trqEpjYBPEFWmscz4lOwB6qTPIQ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(2616005)(26005)(44832011)(41300700001)(6666004)(36756003)(2906002)(316002)(82740400003)(8676002)(70586007)(40480700001)(336012)(8936002)(70206006)(47076005)(4326008)(82310400005)(426003)(83380400001)(5660300002)(81166007)(478600001)(54906003)(1076003)(186003)(86362001)(6916009)(356005)(40460700003)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:06:00.8389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70640995-7621-4cdc-e943-08da9faf18b5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7308 After qemu arm64 test scripts had been renamed to reflect their usage, do the same for the qemu arm32 test script. Currently it only boots dom0, so we can assume that this script will be used to perform dom0 based testing. In the future we will be able to create corresponding script qemu-smoke-dom0less-arm32.sh to perform dom0less based testing. This is the last step to get rid of ambiguity with regards to naming of Arm test scripts. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v2: - none --- automation/gitlab-ci/test.yaml | 8 ++++---- .../{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 3b147c88ab08..92e0a1f7c510 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -195,12 +195,12 @@ qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: tags: - arm64 -qemu-smoke-arm32-gcc: +qemu-smoke-dom0-arm32-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log needs: - debian-unstable-gcc-arm32 - qemu-system-aarch64-6.0.0-arm32-export @@ -212,12 +212,12 @@ qemu-smoke-arm32-gcc: tags: - arm64 -qemu-smoke-arm32-gcc-debug: +qemu-smoke-dom0-arm32-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log needs: - debian-unstable-gcc-arm32-debug - qemu-system-aarch64-6.0.0-arm32-export diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh similarity index 100% rename from automation/scripts/qemu-smoke-arm32.sh rename to automation/scripts/qemu-smoke-dom0-arm32.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:06:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:06:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411644.654666 (Exim 4.92) (envelope-from ) id 1oclwA-0004ne-JB; Mon, 26 Sep 2022 11:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411644.654666; Mon, 26 Sep 2022 11:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclwA-0004nT-Fl; Mon, 26 Sep 2022 11:06:10 +0000 Received: by outflank-mailman (input) for mailman id 411644; Mon, 26 Sep 2022 11:06:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclw9-0004X6-BG for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:06:09 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 359ceca6-3d8b-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 13:06:03 +0200 (CEST) Received: from BN9PR03CA0578.namprd03.prod.outlook.com (2603:10b6:408:10d::13) by MW5PR12MB5651.namprd12.prod.outlook.com (2603:10b6:303:19f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 11:06:01 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10d:cafe::7e) by BN9PR03CA0578.outlook.office365.com (2603:10b6:408:10d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Mon, 26 Sep 2022 11:06:00 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:06:00 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:05:27 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:05:26 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 359ceca6-3d8b-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lL19f6g1ObKP2PJF/gYVT4PmeZZliqsCrX1AxwSVvpPK1Ufy2I89J73OiYDoJhIhcylM0oLvdSILeOk0WL9TNUqoJSa8rEjmjQZRXTZDEPAg5B8mfYau5S87mN+397DA/k+/+uLgSKnqxnSgXocC1g1qDxS+XAFZHI1lbzr9amJRGFLQoSgrG0JYkQ8x9YT/pznYeGbbRFa63nkxkmA3S2RZuK9s8uxq5z3mOACuW/3F1nwevUMjg/K3AQGY8WU8E5bQtlrmbQFez9CxDdufWXeO/H8chRTGpG0NmydDfxkemXNj7JNo9u0iabKK91CdWsS9GwGCoRn6QLnq/bvmVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6mXPXve5ULvv7mPC7ImSugKKpHJU0dvJobrOhPi4FXU=; b=UTDZEWrYEvGoEuAVsvPSYsjNCQEUvhG/ttQm76SX9nWX33HKOolnvm1O6jnIbcQ+2Goorc8hcKUg0ZpxfIWjIOl7Mhmk+H5oT3W9U5T9bwuYP+RHIlaD13ydOMoO6GtszEd+Xnpj2l5VQl7ltv4+aHG4svLkif4br1Tis24dMezBxvkzGQH//yvSrfmT5e0SwY02969HkmGKBF2oZZuiv1xRoXQcdS9XxDaSnh7Zv3M3Wo4JF5sLh3uO2KCruHdcdmtwsTN0agY/2+OiW0KRlGE/5nNQ/iiSn+ixTSb3HxSrBt0pcZGALD8hBsN5bPXxqpU02LMylOdeqpg7xrrwbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6mXPXve5ULvv7mPC7ImSugKKpHJU0dvJobrOhPi4FXU=; b=V0M8QaGOSR9lYedRKL+Ng4W4dbId5IoN2gG/z1avHY//Uu3hZOLBWVjFjsGVVdPD0XItUJ2HV6Z/Hs2FZKw82QmKnO45BjuEg3VbsAuVya/CcC7MG+7k7d5fp6ZiHogZ/MjAaGW0RXens77xT0hFVfEqgzAfpf8oc9yNP4ZQnk8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 09/10] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh Date: Mon, 26 Sep 2022 13:04:22 +0200 Message-ID: <20220926110423.26030-10-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT025:EE_|MW5PR12MB5651:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d6724f4-2097-4dfe-38fa-08da9faf1857 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wPd3NaXl5bQuc/jp1HxDmV07XxrqCPFP73NqN09t4XN7wtVHpMpnW4Pb2ySp+yYbDT6HGjRWvDEiteEPKuNNxL6DnW2gVVehwPETJhuz+w909vF/Jx9kJGoUNmC8zMZUCF4p473hMM1AmvXoOiH5fRhKji92rL7TTgdrrN3N/xWi9NxXaKaAEcFAXvZP3EcEnz+g9PYMpxVMcT3bWiebUFKDbJci+xxHjFC/HNLELs21QgLINrMg8Nk7ECVhvCZeIQF8t9eAniUgpMhnbDXkXQsda319FTNkIs9ocDpdcmDgnvHMkimMB/BHiiihH3chhbcjR8fdC3AFGgbEBWA7ByyD2oLisH+gz0vuGjdOdfnYdTPK3dYcfRtq5pJtCrwo1Mdtu0+vzWQX9qESbwG/U9YU45ToZkzuFbILjb/lUI/HPe/Y+s3TNFfrQD5pbGfI2L643wzWNq0n69v0Lzjb7S/4AfhvOG1iH3NlGhQxOugLjwbItrcFW8Sr/u8O3tMTI54p/u/iZ3+zffsm3zCWurq24Hpup1a/2Gjqt2eU6h2MavuHZZ9XwsR+hqQGGABg5Fq4Ud3J5j8XTWEUU1U7Z6b+FyE1azF2Rj1GLVmPN5zcC+w7x67qdZk1J/8PCzYr5oSO2KAa7C0/Fpoz1TRyS3hI0lPX8IubJ4g9WYrAHeERDMn52r1P2KpxyrLneuO5S5KdpmutM6li09wD1LQW/8TPyV5uZsR8E5sBqGhvPOAPx3kkOg0OTYRUMiTFnPtwsCNMKWDVc3nHMhQR8ppvmw3GIRbTrdvV9gXCt87qkDQrb3ZTAKlG2xegycAwaWM/ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(186003)(2906002)(2616005)(336012)(47076005)(1076003)(83380400001)(426003)(26005)(40480700001)(36860700001)(70586007)(4326008)(8676002)(70206006)(36756003)(8936002)(6666004)(81166007)(86362001)(356005)(44832011)(41300700001)(82740400003)(54906003)(6916009)(82310400005)(316002)(478600001)(5660300002)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:06:00.2027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d6724f4-2097-4dfe-38fa-08da9faf1857 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5651 qemu-alpine-arm64.sh script is used to perform dom0 based testing. Rename this script to qemu-smoke-dom0-arm64.sh to reflect its usage. Also rename the corresponding test jobs. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v2: - none --- automation/gitlab-ci/test.yaml | 8 ++++---- .../{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index f620622671f8..3b147c88ab08 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -25,12 +25,12 @@ build-each-commit-gcc: tags: - x86_64 -qemu-alpine-arm64-gcc: +qemu-smoke-dom0-arm64-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export @@ -44,12 +44,12 @@ qemu-alpine-arm64-gcc: tags: - arm64 -qemu-alpine-arm64-gcc-debug: +qemu-smoke-dom0-arm64-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64 - alpine-3.12-arm64-rootfs-export diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh similarity index 100% rename from automation/scripts/qemu-alpine-arm64.sh rename to automation/scripts/qemu-smoke-dom0-arm64.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:06:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:06:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411645.654677 (Exim 4.92) (envelope-from ) id 1oclwC-000557-2J; Mon, 26 Sep 2022 11:06:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411645.654677; Mon, 26 Sep 2022 11:06:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclwB-00054y-UM; Mon, 26 Sep 2022 11:06:11 +0000 Received: by outflank-mailman (input) for mailman id 411645; Mon, 26 Sep 2022 11:06:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclwA-0004X6-BT for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:06:10 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 350254da-3d8b-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 13:06:02 +0200 (CEST) Received: from BN9PR03CA0799.namprd03.prod.outlook.com (2603:10b6:408:13f::24) by PH7PR12MB7377.namprd12.prod.outlook.com (2603:10b6:510:20c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 11:05:59 +0000 Received: from BN8NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13f:cafe::e2) by BN9PR03CA0799.outlook.office365.com (2603:10b6:408:13f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 11:05:59 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT088.mail.protection.outlook.com (10.13.177.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:05:59 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:05:25 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:05:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 350254da-3d8b-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mhdt0DPx2hVrLkrDlnl19Dq7u3wsevucKM2T+jLHpJa2L55mJDbGD30Hqo633oNzXufx2dJN01Q6duwtq5Kcg+9OepR3HX7oqcwlxYJBZicItPPykYuxmj3aRCPUKNLnvC3r3L93jLuMZ2KUxBO3noxIC1ggGu9RwyvHii+v2KwmpwFcLZk938Il9qe1GvavmxkMPM1Se3mnFJk0fFEKCj3yydJkWcUW4b915kehr3oGYwl80I6+OUW1DKJYXk+u4rJyLcFSuoX6sXL7WNQyr/AdpGTcj9OozFji7mHevekBDbEE49diP1yZBDsoSNyTdyljV2rQr4IhjbUKevGf1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBbxrf3OGmi5kmC0blOEMBhohXAO6yhvPt8yeU+u8o8=; b=UDRBGs4un3+jZGoOAU95l2CsUh60EEyWLYIO1NavgQp7d1ZUmahtO43VROax0i6KCJbZncQsjAARJjeF3UaLRbk29eeBigXGqnAPUAkHth5qH+8nIKhxNMbV291/0g8RT7+TTvCqUCqF0sAe5YL3v/TOutR5Z7NryEeMFghf4Q9iAMmTwWI1CIll3YlhjMgvqSPpSmXuYRM1po3GZt03GQ1V8OHeNipR4rWqAMvGR6LIDVew/f+StGne/uSC8rAPR+U8TimDydSkG/67gWLfx6l71WGIJKEMN4gFGOwpLCifLatqQv406GqcT6pTB/MmVowfOLRMRQiKmk7Q8IjnOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qBbxrf3OGmi5kmC0blOEMBhohXAO6yhvPt8yeU+u8o8=; b=QXuX+5GQW5ECPBXeE+ToUaNEKJ2pBKwiyEuH8YLdNf5YS1jpafMhxN5fG8TLOH1z4iefb1YmGP0TWMwraDSLd9SbYCmSFNnSBM1Te00Vs7zPFaMYVBcQA6mhTKlVi7rnjZhK5mABGSIILC5szyf9IKhLHsQczR1jmQztU2JeAOo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Date: Mon, 26 Sep 2022 13:04:21 +0200 Message-ID: <20220926110423.26030-9-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT088:EE_|PH7PR12MB7377:EE_ X-MS-Office365-Filtering-Correlation-Id: ba530dc5-3b39-4828-6c06-08da9faf17b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ndkkxzio2O8LjIqyPX7dWnja58+0qv1QpG9UgG/EFJwhhHu5fdUgKdHCIGwo9N9oL1/hyPLBzBcdMUFizbbx2MQNTCrubtjM+Qwq6VVmsOSy6GSeM25HTQC0HqBXhsuvXT1dvHAQXreWJDwfSQht5zNUnOP/oxUNTfcO8UR9V4QOH0cN2CyLqjXSOL81ch4JyEKxFmY/cnjRVVjxdqa3osXyomJu+lNhsZ1fX3vqZCXw7sF54bv0UB9S+yjro1+Dgc0gPs44ZZnSkW2VbmHgDNtzJEzsUiDpHRbdnzlXHkxQRtBLupguGvSS/gOdNbJC/Rs5gmAXSMTj96WABOQ0XFAyub7dFP664CJeEN+a2xRJaxQJVoUTPnj+kbCMVPF5HSLH5mxXdG6z35X483pKUalZ92np1UG4IdcC9kYgffK6BmbyiikJVo3aZpxprE7MNjgJpA8OIckBNP3mL8pwx8+dD0Cp7yQEgcX52F2hTU2XlzyqTAEQZFZkTDze1MHyE1eEdVtYcRDFU4Eo2nDz1I6isWQ4rCa7hi+VarTi0DfwN29PUEv9WxH/sEj5E7Nx7gmQYaXVLQMIvBXuCgLnHOrwce1p1A6K0I/wEFYpHj+0RJvap+pCv+8IxaGANFmlET7G/J5vtbp3MIDJn1nk5/A4YGNgYzMQuRqSqIK1T2YoM1WeHtoU004P/WeWCj8cvmkwmQvlIGZO+Nl09TDPlNGg1urO67jfbYtGE5nJOx1rWY+JqOIPY5Lta92AthlPHRtP+aDlAueExtZF/C4mYCjfwl+EeCKUgn+TUSSRfAtUvEWczPSub/NnNocx/SFi X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(86362001)(81166007)(36756003)(356005)(36860700001)(2906002)(336012)(1076003)(186003)(5660300002)(26005)(40460700003)(82310400005)(40480700001)(44832011)(6666004)(41300700001)(478600001)(47076005)(83380400001)(426003)(2616005)(316002)(54906003)(6916009)(8676002)(4326008)(8936002)(70206006)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:05:59.1842 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba530dc5-3b39-4828-6c06-08da9faf17b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7377 Testing arm64 is done using the qemu-alpine-arm64.sh and qemu-smoke-arm64.sh scripts. These scripts are executed with exactly the same artifacts (container, rootfs, kernel, qemu) and the only difference is that the former is used to perform dom0 based testing and the latter - dom0less based testing. Because the current naming is quite umbiguous, rename qemu-smoke-arm64.sh script to qemu-smoke-dom0less-arm64.sh to reflect its usage. qemu-alpine-arm64.sh will be renamed in the follow-up patch. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v2: - none --- automation/gitlab-ci/test.yaml | 24 +++++++++---------- ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 0 2 files changed, 12 insertions(+), 12 deletions(-) rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 1b51030c6175..f620622671f8 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -81,12 +81,12 @@ qemu-alpine-x86_64-gcc: tags: - x86_64 -qemu-smoke-arm64-gcc: +qemu-smoke-dom0less-arm64-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export @@ -100,12 +100,12 @@ qemu-smoke-arm64-gcc: tags: - arm64 -qemu-smoke-arm64-gcc-debug: +qemu-smoke-dom0less-arm64-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64 - alpine-3.12-arm64-rootfs-export @@ -119,12 +119,12 @@ qemu-smoke-arm64-gcc-debug: tags: - arm64 -qemu-smoke-arm64-gcc-staticmem: +qemu-smoke-dom0less-arm64-gcc-staticmem: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64-staticmem - alpine-3.12-arm64-rootfs-export @@ -138,12 +138,12 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 -qemu-smoke-arm64-gcc-debug-staticmem: +qemu-smoke-dom0less-arm64-gcc-debug-staticmem: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64-staticmem - alpine-3.12-arm64-rootfs-export @@ -157,12 +157,12 @@ qemu-smoke-arm64-gcc-debug-staticmem: tags: - arm64 -qemu-smoke-arm64-gcc-boot-cpupools: +qemu-smoke-dom0less-arm64-gcc-boot-cpupools: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export @@ -176,12 +176,12 @@ qemu-smoke-arm64-gcc-boot-cpupools: tags: - arm64 -qemu-smoke-arm64-gcc-debug-boot-cpupools: +qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh similarity index 100% rename from automation/scripts/qemu-smoke-arm64.sh rename to automation/scripts/qemu-smoke-dom0less-arm64.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:06:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:06:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411652.654688 (Exim 4.92) (envelope-from ) id 1oclwW-00060X-Bq; Mon, 26 Sep 2022 11:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411652.654688; Mon, 26 Sep 2022 11:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclwW-00060M-93; Mon, 26 Sep 2022 11:06:32 +0000 Received: by outflank-mailman (input) for mailman id 411652; Mon, 26 Sep 2022 11:06:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclwV-0004X6-9u for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:06:31 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44494ba1-3d8b-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 13:06:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44494ba1-3d8b-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664190389; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=A69e8qCkoQP+7VHX14D5jJMCbKo+87SB5WfxZWudyP8=; b=KGoslosMgyImpmeHo9FU/PMsBaiB9bJq1oGPY7JspNWlvCYwfyqBKJaz 6mySz1j1iIW6Z1dl6Zihp3pNWo2d5KAKbkbcMa4gIZJrXPNSEWo4H0j0g bA89AlnJh7o0NhPwz/LF8gurx2gNEZlYncXuimO6jaJNfwNNqKeerJcOq E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80472748 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:lGQLpaMT1Ow3xszvrR2Dl8FynXyQoLVcMsEvi/4bfWQNrUpw3mBUx 2ZOXWqHaKvbamD3KN9zPomxox4CucPWzIJgTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMuvje8EkHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFP8gNtPHRAmB7QU0edvMCJK3 9IVbzQkO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyziLkFMrj+S9WDbTUuSOGcQKz1ibn zjf8XWmOhEQE8aR1jXQpxpAgceQxHimCer+DoaQ8/dwhVSJy287CRsIVEC6q/20lk6/Xd1EL 0UevCEpqMAa1EGtVMi7YBS+r1aNpBtaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLR5FvaCRSHmd3qyJtj70Mi8QRVLufgddE1FDuYO65thu0FSfFb6PDZJZkPXlWh/R0 mGalhEyrLQLvI0P/Yu2ulTu1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEADf4 SFsd9y2qblXUMrTzHDlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCH17ZiHCgUxfOdjZ5yEWIU/IS7zYugj8NIYmX3SIXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyhGUP8/nWLnHL5BuVPO+szZ7TK7eHwG507/jer2iIC9EN/pz2dinshmtfjZ8W05A v5UNteQygU3bdASlhL/qNdLRW3m2FBhWvgaXeQLKbPYSuencUl9Y8LsLUQJINU7wvQIyb2Sp hlQmCZwkTLCuJEOEi3SAlgLVV8ldcoXQa4TVcD0AWuV5g== IronPort-HdrOrdr: A9a23:mopHzq5tKVT1+uMEqQPXwMbXdLJyesId70hD6qhwISY1TiX+rb HJoB17726StN9/YgBCpTntAsa9qBDnhPpICOsqTNWftWDd0QPCRuwP0WKL+UyYJ8SUzI5gPM lbHZSWcOeAaGRHsQ== X-IronPort-AV: E=Sophos;i="5.93,345,1654574400"; d="scan'208";a="80472748" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Henry Wang Subject: [PATCH] drivers/char: Fix build when CET-IBT is enabled Date: Mon, 26 Sep 2022 12:05:47 +0100 Message-ID: <20220926110547.21287-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 Signed-off-by: Andrew Cooper Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and dbgp=ehci") --- CC: Jan Beulich CC: Marek Marczykowski-Górecki CC: Henry Wang --- xen/drivers/char/ehci-dbgp.c | 2 +- xen/drivers/char/xhci-dbc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c index 8a0b95850609..bb9d3198d9f2 100644 --- a/xen/drivers/char/ehci-dbgp.c +++ b/xen/drivers/char/ehci-dbgp.c @@ -1465,7 +1465,7 @@ static struct ehci_dbgp ehci_dbgp = { .state = dbgp_unsafe, .phys_port = 1 }; static char __initdata opt_dbgp[30]; -static int __init parse_ehci_dbgp(const char *opt) +static int __init cf_check parse_ehci_dbgp(const char *opt) { if ( strncmp(opt, "ehci", 4) ) return 0; diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 5f92234a9594..43ed64a004e2 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -1282,7 +1282,7 @@ struct dbc_dma_bufs { static struct dbc_dma_bufs __section(".bss.page_aligned") __aligned(PAGE_SIZE) dbc_dma_bufs; -static int __init xhci_parse_dbgp(const char *opt_dbgp) +static int __init cf_check xhci_parse_dbgp(const char *opt_dbgp) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:14:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:14:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411683.654699 (Exim 4.92) (envelope-from ) id 1ocm4G-00080O-8k; Mon, 26 Sep 2022 11:14:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411683.654699; Mon, 26 Sep 2022 11:14:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocm4G-00080H-4e; Mon, 26 Sep 2022 11:14:32 +0000 Received: by outflank-mailman (input) for mailman id 411683; Mon, 26 Sep 2022 11:14:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocm4E-0007zs-Ir for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:14:30 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62765f69-3d8c-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 13:14:28 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 07:14:26 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6390.namprd03.prod.outlook.com (2603:10b6:a03:396::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Mon, 26 Sep 2022 11:14:22 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 11:14:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62765f69-3d8c-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664190868; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=QCdtDN2pQBs5V5dBUrzXQaVfraSamPBUiVlbDjCvmZU=; b=f1Tzvtg99Q1GjKBhat6j83R3BJoQ7m2ZIagStzEVz3WCfOuHrvwUXIV/ xvenJlp8XQe/U/C3g5VFFhamFpLZ/Pfwck3weSBQqmLvR3cBCHf4aZq4O kANLsh5lXDPxZV120fIs4VJUkrJpUt618ajOa+yKW4PH1xZ3oSUqM86N5 8=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 80473139 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9XBrlai3lMMZvxs6+dGnflidX161oBEKZh0ujC45NGQN5FlHY01je htvWW+FafeNZGGme95/btmz8B5QuJLRzN5gQFBqpCg3EH8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaQr414rZ8Ek15KWo5WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4efr023PllI1h12 9cbDhApMB2GoP2z3+fuIgVsrpxLwMjDGqo64ygl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTM+vZfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2iL02rCUxHiqMG4UPP6q7KEyona+/y9NFUJRTFuigqKVhHfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAmZDNcbN0ttOctWCcnk FSOmrvBADV1tbSPRHG197GKrCizMywYMW8DYyAfSQIPpdLkpekbrh/JVMclL6ezgfX8AzS2y DePxBXSnJ0WhM8Pkqm+o1bOhmv1ooCTF1FpoALKQmii8wV1Ipa/YJCl4kTa6vAGK5uFSl6Gv z4PnM32AP0yMKxhXRelGI0ldIxFLd7cWNEAqTaDx6Ucygk= IronPort-HdrOrdr: A9a23:+4DvjqwWxfJg5AEahHl5KrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4= X-IronPort-AV: E=Sophos;i="5.93,345,1654574400"; d="scan'208";a="80473139" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLsLG0x2x2VPmEdczTHlW8nTCiRo3UsGhN7WRfX8/CVUpsFGg+j4h9LnZgpdnyQ25o7Q+y0XyiTcf3ZvgnwHFW6+wpBCZFOFW2qOXfXg4wCR973te+BtSA++4eTpaptl7zIWo4Avk11rMp08UC61G4Sm/M0uxbhik+qmAvGjSs+f4dISSe2oM8XJCek8VMdqG8QKAaFlBkoqENHoU4tHn/zt6cXf1xXtl5qFqItd/W0h9ZlJzbGbwoyp7Ebs0CBumHjICGvez3kwV4KWMElh56t0e6yAH9DmvYBj9sm3vJLL06h/vWXqVI4j55MUJwY/DX35Ar+uZIgbHheKHa04Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QCdtDN2pQBs5V5dBUrzXQaVfraSamPBUiVlbDjCvmZU=; b=D9AamGwz3DGqCpIff99JW3J23fVcJ0bidJt62Ick9AwZAp/rm5OoRvxKDHlDyfF9Ney3wPlzHdaY8vYLpVXKXjuQQ6XMMiX4WVVdUNHm3olcVLD9WBq1msSq/l+K04+6iI9YS8a9D8GsAXeJb85BG+/rcTQ878V3i06JC0iZKYzcVRldZfNUIpwutAu5AmbPo7uAA/qgf2MDsHfEMrmrlbPJjkj/uZcT/DIXcY7np6XYdLVnno36eYrx7pVU+mu8l7czh6dCi1HrTw9APjgyaBPdHMjszjcjVew08sf3D0z8tkS6Qps1YeDytGDPRu15wHUWMWPot1DjgVN7f2tJfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QCdtDN2pQBs5V5dBUrzXQaVfraSamPBUiVlbDjCvmZU=; b=izjQo1wJqdKTa6xGR0hGybYUDb7TyX09rzNZQm6QRTkfHttMXxA8zk2zPwNiF/tH5YtwHs95mRYWl1dBaa7p64IEv/mtEv7+mcgMSUBHbnriYxJHvXC2/4npCOTi4uOu8xkaqQd84w0/akBzp4tiThCXleU/43c6vSv8Yr650TA= From: Andrew Cooper To: Xen-devel CC: Jan Beulich , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Henry Wang Subject: [For 4.17] Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Topic: [For 4.17] Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Index: AQHY0ZgJqCa/HgBJ80OfcMoFcfGuLq3xjxEA Date: Mon, 26 Sep 2022 11:14:22 +0000 Message-ID: <603e39a8-965a-7869-d1f6-072bb29d103b@citrix.com> References: <20220926110547.21287-1-andrew.cooper3@citrix.com> In-Reply-To: <20220926110547.21287-1-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6390:EE_ x-ms-office365-filtering-correlation-id: be5c327b-1737-4141-2ef9-08da9fb043b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qJZwsULNXYTk0EqN5OoDt0nSpEMyJqpbOtEP90E8mfvaLmbRs7kR+xQfkvVGRT2lO47QQdZv0Q8AP3VFqdOLj6i+zco3z5feJSUfE0PFyN9qtMZLwv3dpHGfLSqmZ8yv2HdhWUWrwvz6iLygGMMeIyFijoUKPq9VsEuPcHryiFdmudFP00965BDxw0IfT3CCKF0Z1zzwshkoIX4YLIWZbcPfz+p6a+hvZLoZXKMqLOCFqkqi0xd+Cxkw+q1ZBY/3C9wCigOk1H5M6QpNMO476EF5xMpcu2+EqP80aei9Mk9h/W1vwow3fRypG+gFUVhOPGNzUMZlweQ7ZmRQ4xk91C2ENwttJpYGEVR/sgyTRS+++hdbJRdMNH4MSLYjBQVXyoETkmKC9DtIfCmN/QHOiBDNQT0j4ihf/O7NE8Lg3B2LFIZBiwvaONEdBkFOgfpFTx3PCJuMNqBsbt1VF1kHnoWmcRQ+QdiqUbdlnjDtCyFUKAg0P344eb8Hv4ot869cLRx+cv4A3CuZCOypmVno+px+D3Ts2wjk58EJDxPJZDOx89lvxktseuTZxI+UeuOOHXihZ7Hd1Y0ocVR52rASHVzesK/faD6ZvH9dW+5BSV9MLq8acCREM+pzgeBKTnSsDrOA+0ZDmTTHKmT8m2tfqhCL05oHXmb1HvlcbZReUg0lkGdNuXAQhMHSstN71ptPRDw+euo8LVK62kFRxMb4jFQeLFlQTdlQqxlrYJY/QoTCeE0ARUmNr2S6fyFSofdhyWhBsuHtX/AstrWHt2XTQCXuDU5062dq7HUMkCJIiSBg3g03Ym25HnBBA0seHUK8wE097s1YJChh6oAZOfrxNToA+3+E/n/Lvr/eW0I9p6w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(451199015)(966005)(6486002)(8936002)(6916009)(54906003)(71200400001)(64756008)(66556008)(4326008)(8676002)(76116006)(26005)(66946007)(41300700001)(66476007)(316002)(53546011)(91956017)(6506007)(66446008)(478600001)(38070700005)(31696002)(38100700002)(82960400001)(86362001)(2616005)(5660300002)(6512007)(2906002)(186003)(83380400001)(31686004)(36756003)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L3RaZDhhMHJOeUh0R0dlUTA5UDJhdXZlK0txYUUxWS9YQ1Z6OGhSUjZNUENu?= =?utf-8?B?djdNQXMraEZPcUJ5SE8yODNaWUlDRy9LcXF6cGlNL1FTMFB3NzVBSVdUeTha?= =?utf-8?B?TnExMEp3VkdMakk0YXg1NXBVMGNiT0k0OGdpZ05sbnpGWEZHZzhkVDRlVFR5?= =?utf-8?B?UFl6RnJEQzd0VDJYZXBtbnhiUEVqWVdEbzEwWWtlM0hlVEN1WGR5OFVFWUJN?= =?utf-8?B?KzlVSjE4K2N3aXVGTndjUDhXb0JFUU1oMWhZaS9KVHN4bnkwb05XZ0RDcXp0?= =?utf-8?B?LytFL0VBWCtnQXhERzU1WkYxbG4wY2ZUd0NobWZaeE1oM2xIU1I4YXNZYjZP?= =?utf-8?B?YzlzZG54a0pXbGxheTUzekJtNnNaaFRVZkthVUNGVzA5S3B4aWhkTGh3NjZo?= =?utf-8?B?b2xYcEVRQ2w4SkRKUXMxdENKTy9SYmFEcTdkMXJaYnFaRUZyYU1aclpjSEZl?= =?utf-8?B?R3ZSNVV6aUdhdDZRa0o0Qlp4QjVJTTJtWDlJQk41VTBpTVg4a2Ywa3kvVjRP?= =?utf-8?B?NlQvMkI4a2NCUi9ZU1N2SFJpWHFmMzhZNzQ4ZkRIODd1aStQWEVGYy9la09h?= =?utf-8?B?aEh0ZTl1M0hMV2NmbXdMUE45UmNueUhpNkw4VDBqMklJMUtqblJCNnBSTEdQ?= =?utf-8?B?SzQxZXRsWWJQY3RNN01kMndZbGFOd2IxRytOWnYxajlmVEIzWlduYkwycGpM?= =?utf-8?B?NkJNUVlPWmRERE9CQUIxR1o5MVhNUEh4UWIwblY0ZktSeU5oWC9YQlM1UXpS?= =?utf-8?B?Ym1NNEtGc3RseFcvQS9wSndlMXk5ZUZhM2xzcFpVTVYzNEVCNnZqVEVxRUc0?= =?utf-8?B?SlNXdHNXd0Y4ME9McUpuVENpT0pyeUNQejNkTnNPWTd3dU1XdGJBeEJJZTV3?= =?utf-8?B?Y203MC9OZ3F2SnlSV0F0Y1ZvbDJCOEVGZm5FakZPTHllZHQwYlp0RXhiM08z?= =?utf-8?B?NXBIa3FnaFFPR0I3MjcxK2JEd2g5OXVUQlk5UVI3dExNd056VkhKOEJ2SUZi?= =?utf-8?B?b0FmMmh0NkFNVG9rTU9YaWZrN1NvMUdTdHkrclBjK1pqT2dVNDhtVnROSzIw?= =?utf-8?B?NC9pYk5XRm1NcXIwcGJMWWhYaHlnQ0pBMHhIWnhGWkNwZTliMkI5enQ1YXV6?= =?utf-8?B?eG9yQnk3OTZ5QW5iRkhXUTFjTlExb3ZuOFpOaGI3NGZqRGpETThyUjBtUDRh?= =?utf-8?B?Wnk0YlJXUVRIYktJc28vVEU0OThNZFNmRVNnNnBpYkI2TkJGKzJDZi9HTEFk?= =?utf-8?B?Tkt6SkpGL2NPdVBxZTNXc1Q0UHh3MHBWSW9aenVqMFpjTVZ6aFBGc3BGRmZ5?= =?utf-8?B?eTkrS0pnZE5kQUR1MmtITGxkVVlqNzF2S3VGNlRDSk9OVDFhOUVhYlpDOEdK?= =?utf-8?B?eVJYeUgwaHJzNWE2QkVXMHFIaUE0Y2ZHNHpQNE9MUUJUNXRJMUozekNRSnVU?= =?utf-8?B?VG1KZUkwc24zZk1ZL2RvNkVXTFZmZVhtSFpQY3F0bTF3Rlp2di9YcUlVOWFK?= =?utf-8?B?S2ZUTWZxR2F3RGc0T281bUYwa1M3RTBYRndDUS9qY1FkVlpJZHB0VGNVdUJU?= =?utf-8?B?eFkvalBrYkw4YlU4M2VrRTU0TVFHQnlWb1RqVG5JdkF2QUJpOTZFQ1J3dVpY?= =?utf-8?B?SElSZU1RTjdhUHBrWXZML3I1cXNHL3I5RE9abGlsUk82VFlzYWM0VE1DYmc5?= =?utf-8?B?eHFMNG5rMElUODNSdXBXUnM4VFkzYzVvTk1VM3lYSFA1Z3RLL2ZpVU4xUzkw?= =?utf-8?B?TjgwdTNtcDdaU1ZRTHhpMDZ6dkhVUzBhL1MyTjZTU2F4K0dZWUpqWWY5cHNQ?= =?utf-8?B?VzAyVHVDa1E0OXVyeHk3VEZaSU1zY0VHTUVIalRXZFVBVlpVOXdMTFhaWWZN?= =?utf-8?B?aFlia1dGOGp4eTI1cXNWeVFDRDFSckY3ZWF3Lzl3TEVuSjg4RFRoMlFkRnMr?= =?utf-8?B?aGNXaDJvU2FNNDZjakJCUmswb2FTZmoya1dNbW9lOExRYWRnQnFuRlpmTm1j?= =?utf-8?B?YlBOL3p4SGtFWVk3MnpXbHdSbEErN3REWmZnWFY0NlRZVklhWjNiWFpPVXdn?= =?utf-8?B?c245NzlXQnBVelhpa25CMGxXVFhmdHFSV1B1M3RXTm82YkU4RXpWU1lJODhW?= =?utf-8?Q?MSq8N1uzIM2NUFjDVvR3Ob1Zg?= Content-Type: text/plain; charset="utf-8" Content-ID: <7C5945DA1CF169498FCFE0A9D610B97A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be5c327b-1737-4141-2ef9-08da9fb043b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 11:14:22.4860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tvCopp/dIsqi8xnuWBtgxm7CcWPwkkAqRCSLVgTh0ilsz+N35qdQQnilgy19qG+0+cFPvJev9Zqoq+gITJwMW6A5OiVxSrrStqGzhnZ5H+E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6390 T24gMjYvMDkvMjAyMiAxMjowNSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gaHR0cHM6Ly9naXRs YWIuY29tL3hlbi1wcm9qZWN0L3hlbi8tL2pvYnMvMzA4MzA2ODk1MCNMMTc2Mw0KPg0KPiBTaWdu ZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBG aXhlczogMDIyZTQwZWRkNGRjICgiZHJpdmVycy9jaGFyOiBhbGxvdyB1c2luZyBib3RoIGRiZ3A9 eGhjaSBhbmQgZGJncD1laGNpIikNCj4gLS0tDQo+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hA c3VzZS5jb20+DQo+IENDOiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgPG1hcm1hcmVrQGlu dmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+IENDOiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5j b20+DQoNClNvcnJ5IC0gZm9yZ290IHRvIHRhZyBGb3ItNC4xNyBpbiB0aGUgc3ViamVjdC4NCg0K fkFuZHJldw0KDQo+IC0tLQ0KPiAgeGVuL2RyaXZlcnMvY2hhci9laGNpLWRiZ3AuYyB8IDIgKy0N Cj4gIHhlbi9kcml2ZXJzL2NoYXIveGhjaS1kYmMuYyAgfCAyICstDQo+ICAyIGZpbGVzIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL3hl bi9kcml2ZXJzL2NoYXIvZWhjaS1kYmdwLmMgYi94ZW4vZHJpdmVycy9jaGFyL2VoY2ktZGJncC5j DQo+IGluZGV4IDhhMGI5NTg1MDYwOS4uYmI5ZDMxOThkOWYyIDEwMDY0NA0KPiAtLS0gYS94ZW4v ZHJpdmVycy9jaGFyL2VoY2ktZGJncC5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL2NoYXIvZWhjaS1k YmdwLmMNCj4gQEAgLTE0NjUsNyArMTQ2NSw3IEBAIHN0YXRpYyBzdHJ1Y3QgZWhjaV9kYmdwIGVo Y2lfZGJncCA9IHsgLnN0YXRlID0gZGJncF91bnNhZmUsIC5waHlzX3BvcnQgPSAxIH07DQo+ICAN Cj4gIHN0YXRpYyBjaGFyIF9faW5pdGRhdGEgb3B0X2RiZ3BbMzBdOw0KPiAgDQo+IC1zdGF0aWMg aW50IF9faW5pdCBwYXJzZV9laGNpX2RiZ3AoY29uc3QgY2hhciAqb3B0KQ0KPiArc3RhdGljIGlu dCBfX2luaXQgY2ZfY2hlY2sgcGFyc2VfZWhjaV9kYmdwKGNvbnN0IGNoYXIgKm9wdCkNCj4gIHsN Cj4gICAgICBpZiAoIHN0cm5jbXAob3B0LCAiZWhjaSIsIDQpICkNCj4gICAgICAgICAgcmV0dXJu IDA7DQo+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9jaGFyL3hoY2ktZGJjLmMgYi94ZW4vZHJp dmVycy9jaGFyL3hoY2ktZGJjLmMNCj4gaW5kZXggNWY5MjIzNGE5NTk0Li40M2VkNjRhMDA0ZTIg MTAwNjQ0DQo+IC0tLSBhL3hlbi9kcml2ZXJzL2NoYXIveGhjaS1kYmMuYw0KPiArKysgYi94ZW4v ZHJpdmVycy9jaGFyL3hoY2ktZGJjLmMNCj4gQEAgLTEyODIsNyArMTI4Miw3IEBAIHN0cnVjdCBk YmNfZG1hX2J1ZnMgew0KPiAgc3RhdGljIHN0cnVjdCBkYmNfZG1hX2J1ZnMgX19zZWN0aW9uKCIu YnNzLnBhZ2VfYWxpZ25lZCIpIF9fYWxpZ25lZChQQUdFX1NJWkUpDQo+ICAgICAgZGJjX2RtYV9i dWZzOw0KPiAgDQo+IC1zdGF0aWMgaW50IF9faW5pdCB4aGNpX3BhcnNlX2RiZ3AoY29uc3QgY2hh ciAqb3B0X2RiZ3ApDQo+ICtzdGF0aWMgaW50IF9faW5pdCBjZl9jaGVjayB4aGNpX3BhcnNlX2Ri Z3AoY29uc3QgY2hhciAqb3B0X2RiZ3ApDQo+ICB7DQo+ICAgICAgc3RydWN0IGRiY191YXJ0ICp1 YXJ0ID0gJmRiY191YXJ0Ow0KPiAgICAgIHN0cnVjdCBkYmMgKmRiYyA9ICZ1YXJ0LT5kYmM7DQoN Cg== From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:15:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411687.654710 (Exim 4.92) (envelope-from ) id 1ocm4j-00006V-KJ; Mon, 26 Sep 2022 11:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411687.654710; Mon, 26 Sep 2022 11:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocm4j-00006O-G5; Mon, 26 Sep 2022 11:15:01 +0000 Received: by outflank-mailman (input) for mailman id 411687; Mon, 26 Sep 2022 11:14:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclvY-00019b-HL for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:05:32 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2089.outbound.protection.outlook.com [40.107.94.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22044c17-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:05:31 +0200 (CEST) Received: from MW4PR04CA0310.namprd04.prod.outlook.com (2603:10b6:303:82::15) by SJ1PR12MB6217.namprd12.prod.outlook.com (2603:10b6:a03:458::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 11:05:27 +0000 Received: from CO1NAM11FT093.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::cd) by MW4PR04CA0310.outlook.office365.com (2603:10b6:303:82::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 11:05:27 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT093.mail.protection.outlook.com (10.13.175.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:05:27 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:05:24 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 04:04:56 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22044c17-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2pyr5uWWlI01m43QVlqsCOonS/Y1Bu2i8sTeXed9jFG4w2tzIBNOOAY1b28BeM2lqeqsjKUiKHzW+V7+7dQl6n0XQI1X4xqf8/BLBpWJ0wCyPSc0+x/A1UBrawiDuhAcvqkmdSoF4xsagYl11CZ/XRm4iTO+b9eVjZz5PAEUhxWVjbZma0dd5NTkaT21VAfb85QyEYKLt+0oKNhA0e8RXTDsaorg3KQ4s8irK2H327zx6pUDSt7PgpJjjbJMJIXjJUXUGc1WXbdTId0jy5aVtK1c4SAh/u21OFU2zohHy6P6p9C8FHvAV+hPEiwx7Ax2rw7QkAy7Hi250Lio+uYgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4vDkMoPV9kVsd1zqn5FqV9gc7xGiXRW41PFaT+D57pk=; b=ChHetdq2Rj5gn068n0RCG3vG34+UtYFuOvTe8inEimK8vHbR9mGRKRVEmzY+s5evDuHSLbhD0GKbS2OSgH4SakVCiPDUtppBqF020df4BVqB4cqIj61iSFIeZhEzoFOD2lmdFbOP38Mo4RImYSOLysv2R1StmnT5DUQBq4EzGZPVAgKrn7rnFXMHMZDFSH3Mazs0y16DSx1UohvXxpdElmSMIhTaayP9Zn4E+9ZzQ4t89svl5/Nloj/0piPgKVC+URzX/zoH1JyjCPOrFE9719sAQFmtY5g+g0aKs90szE248HzgH4gkBi8+R7gDz2u4xSArSHgzPwydId89ipip1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4vDkMoPV9kVsd1zqn5FqV9gc7xGiXRW41PFaT+D57pk=; b=X1sDxpsSXXa1JyO0zf+4A1itMhWIwiMbS/GDbr4NrsgVHCwjGClvzqIdSw9+bkAZkf93k420/sWCbgzs9S9NUYpGXe2qEYOvUPp4xbaC2Aj0tBpPmYlwEOPI4cJR8pdiOmhX3SuhVNTnl3IdkKcewU0klkU5OZEmQM9gwY0eSLI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Date: Mon, 26 Sep 2022 13:04:19 +0200 Message-ID: <20220926110423.26030-7-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT093:EE_|SJ1PR12MB6217:EE_ X-MS-Office365-Filtering-Correlation-Id: bd03a3ac-ec7e-455b-b8ea-08da9faf04fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WeQGSqP3E3j/3LKgaZai6DJypHpI5dFPRze7SLPg2SvW+XCT0tg12p9jR7Acf3ftl/cyBHXhoQRxgXUYoFEyoStUO8laOHIlBLNYHYBv0cwiFQ7LqZSxNM5Ww0D4IL4s39UQ86L8P6A931hv3QravYjUlNU4urQ/3u4yzpEv71D9r8roaKrZ7PELfSnFM6rPvCOSptMeFTyKLJx6ghbBn9GBfxx5tVRpi4FYUE0OboWA+/MB/UWbQnucIt2NRVK0ALyHaAM7fPj2oFAsxu4/SJz55vq02U7wqmzji8g0NRsHEN8Naf3UWZ/sUkCPFK/Yr11oS0znwddUXBx9swrpfMTJqSYiUQVPjvHk+QyjEZtvMVgyCiaqPUBQsXD8WK3Ah46tnnG3ZOpQYeHgpwGptG2dj5cm5onQ0zdYUpPG0OHMACwwKFFMwFHeRbN+32gsqUQ0XUXSzgHy5nkyTc/DaF2VhjlcdCd4nFibdfj0RYtgpKXIMDjS1TJdj0cbqAtbTck3AetpS7tOLzx8xF9bu60UwIaiUxphS8CzJZMxXxFL9SpiEEKLjeTiGE5FNZD+i4diErVF57358FQPw8PKSXOek2vRopTUdTlGBq/eMi6YHqe68spnczYR+ss4bcQcGIRd2G/+D4cy6SaM19pZl9irw7EBj4NCHr2Oa1XFiekxUO/WJBXIP4w2KTsnvYaejF6QWSKylxC+lJR2DsvLpPlhYaAOpHsci2wt2L9xmJB/F/i7mcEz1cyq7A9f4sNwUmiWo1yNX8rdxDBlGaczy7mpWNeGthD0hNx7NQIHuBJ9x1qPDZJ8cL4M9+hTlyDJ9UcUlIVHL/epBFZNJwMrFDvNbfDZfJQjxFlLQJ0h9RMxkyzVq+69/qjEI8T1/nTqBj3XIz8lMGToJXD/XTn9HmY59t0vNPEYlvurlDDsZ/U= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(8676002)(82310400005)(36860700001)(40460700003)(81166007)(356005)(40480700001)(82740400003)(70586007)(70206006)(36756003)(4326008)(41300700001)(44832011)(5660300002)(966005)(478600001)(26005)(6666004)(316002)(6916009)(54906003)(86362001)(1076003)(2616005)(426003)(186003)(336012)(47076005)(83380400001)(2906002)(8936002)(21314003)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:05:27.6367 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd03a3ac-ec7e-455b-b8ea-08da9faf04fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT093.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6217 Take an example from arm64 qemu test scripts and use ImageBuilder to generate u-boot script automatically. Calculating the addresses manually is quite error prone and also we will be able to benefit from using ImageBuilder when adding domUs to this test in the future. Install and use u-boot from the debian package. Modify the script so that binaries are loaded from u-boot via tftp. Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always set to pl011 node path. Signed-off-by: Michal Orzel --- Changes in v2: - add explanation in commit msg why we remove dtuart path --- automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh index 530f3892fdd3..765facbe4d66 100755 --- a/automation/scripts/qemu-smoke-arm32.sh +++ b/automation/scripts/qemu-smoke-arm32.sh @@ -4,7 +4,9 @@ set -ex export DEBIAN_FRONTENT=noninteractive apt-get -qy update -apt-get -qy install --no-install-recommends device-tree-compiler \ +apt-get -qy install --no-install-recommends u-boot-qemu \ + u-boot-tools \ + device-tree-compiler \ curl \ cpio @@ -20,10 +22,6 @@ tar xvzf ../initrd.tar.gz find . | cpio -H newc -o | gzip > ../initrd.gz cd .. -kernel=`stat -L --printf="%s" vmlinuz` -initrd=`stat -L --printf="%s" initrd.gz` - -# For Xen, we need a couple of more node. Dump the DT from QEMU and add them # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./qemu-system-arm \ @@ -36,31 +34,31 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -display none \ -machine dumpdtb=virt.dtb -dtc -I dtb -O dts virt.dtb > virt.dts +# ImageBuilder +echo 'MEMORY_START="0x40000000" +MEMORY_END="0x80000000" + +DEVICE_TREE="virt.dtb" +XEN="xen" +DOM0_KERNEL="vmlinuz" +DOM0_RAMDISK="initrd.gz" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" + +NUM_DOMUS=0 + +LOAD_CMD="tftpb" +BOOT_CMD="bootm" +UBOOT_SOURCE="boot.source" +UBOOT_SCRIPT="boot.scr"' > config -cat >> virt.dts << EOF -/ { - chosen { - #address-cells = <0x2>; - #size-cells = <0x2>; - stdout-path = "/pl011@9000000"; - xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0"; - xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh"; - dom0 { - compatible = "xen,linux-zimage", "xen,multiboot-module"; - reg = <0x0 0x1000000 0x0 $kernel>; - }; - dom0-ramdisk { - compatible = "xen,linux-initrd", "xen,multiboot-module"; - reg = <0x0 0x3200000 0x0 $initrd>; - }; - }; -}; -EOF -dtc -I dts -O dtb virt.dts > virt.dtb +rm -rf imagebuilder +git clone https://gitlab.com/ViryaOS/imagebuilder +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config rm -f smoke.serial set +e +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ timeout -k 1 240 \ ./qemu-system-arm \ -machine virt \ @@ -70,11 +68,10 @@ timeout -k 1 240 \ -serial stdio \ -monitor none \ -display none \ - -dtb virt.dtb \ -no-reboot \ - -kernel ./xen \ - -device loader,file=./vmlinuz,addr=0x1000000 \ - -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=./ \ + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial set -e (grep -q "^/ #" smoke.serial) || exit 1 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 11:15:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 11:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411688.654716 (Exim 4.92) (envelope-from ) id 1ocm4k-0000Ak-3D; Mon, 26 Sep 2022 11:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411688.654716; Mon, 26 Sep 2022 11:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocm4j-0000AY-QL; Mon, 26 Sep 2022 11:15:01 +0000 Received: by outflank-mailman (input) for mailman id 411688; Mon, 26 Sep 2022 11:15:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oclva-00019b-7D for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 11:05:34 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2058.outbound.protection.outlook.com [40.107.223.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 233857fe-3d8b-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 13:05:33 +0200 (CEST) Received: from BN9PR03CA0526.namprd03.prod.outlook.com (2603:10b6:408:131::21) by MW4PR12MB6684.namprd12.prod.outlook.com (2603:10b6:303:1ee::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 11:05:29 +0000 Received: from BN8NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:408:131:cafe::4a) by BN9PR03CA0526.outlook.office365.com (2603:10b6:408:131::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 11:05:29 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT078.mail.protection.outlook.com (10.13.176.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 11:05:28 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 06:05:25 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 04:04:57 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 06:04:56 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 233857fe-3d8b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwHG0Uw/YE/yIMCCE5Alr31ht846VmICjyZwcpHIpCCC+Yn55avaLQtJsujAKbdzR8ssyAUGIurigHUOydB/OK2Puub+dWtCjBX8aZL09DeVHn6GMh4s5tGDpVrf2FJYV1X7Y7f43O5X43zVQ4+NPbEOawHjaJxw+bI4gwpygr8nY/zJY94l9bpBqscuUrVu8H4sbCVY+xecgG+8CbMOS1ut44uFhknkcVYdz9jqMLmIUBxbuM7Qf/NVqpPGxGyrDmWWmCAnxpYGjiQn0w5N+p4di9ZMzx/BaYzGIxTRtoM7pBvxpGS37iEEl5ifX7s7AYRsLkQAvHHsHz6herwi6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qx4EC4KMsyhRnGE2453GEGKH2mT41/PmpiSKyiT7+AI=; b=b6ZaRJQSky7T11KAQPqAgsi8UcXEtAn7g6/AbdSANHRK4QQy/mqjnrdsoTrNQAGu5/iSZ47d9unfTVLP5U7pcP6kbR2HfhW03fEcn+Rnk58umZISL8xcZS0YFp5xFHYyiy2qLaL6JfIG8jK4tjI4PhayKNGccXCygS3sDHyOVjyNRNpzrHiSUnM2c1vbnj2SW6t1WO3MjlixJu7029JYX1ASjwC06xwgeAw/5gnKgIHFe51VZHLNxj2bfcl5dV3x2qR0DZAhkP25qLRvWfaSB/4D04L0AcSlY1TeZm1aO9Xtu4/ZqxEiYEjUuMqM2NvRdk7OwxDbQ6pKF8Cx/KZvjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qx4EC4KMsyhRnGE2453GEGKH2mT41/PmpiSKyiT7+AI=; b=pi0RQkFDspIRz0hdXd9sE1XjTZCjKnv7QqxthQe59dKl9wtv0O7bGyfakY8CKI3gsAWRCdDDI3kqW+Yf73H64Or05I9gZKoOyC6ONSd+HLMCL04ryVAueF5v41TaRoB4k30vB8RYatNkz8FrT4Fv6KjUYaz84GMZIyAjo1Dxnm4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 07/10] automation: qemu-alpine-arm64: Cleanup and fixes Date: Mon, 26 Sep 2022 13:04:20 +0200 Message-ID: <20220926110423.26030-8-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926110423.26030-1-michal.orzel@amd.com> References: <20220926110423.26030-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT078:EE_|MW4PR12MB6684:EE_ X-MS-Office365-Filtering-Correlation-Id: aaeddd57-f6ee-455c-50ab-08da9faf05ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IqQiqwIwZoQsoqYW6qhoFQtS+Gmx3JyIUd3rZyPuwX/yeZBYbI27udJmvp9s0EvOb4wPESk8O+22lme1zxBoDZEgD6ay9aYfLvP7LTkznUDLCN54QZMxSWUVtb1CVRNOL9X50HPWPp012XVGpScUrF++c4MBt9lvgnaFaFldb3zF7SnkaQCCVE7B/yPEyFjO2W/zAExJavuLk71xk6qozG3vNJlG+0/qBPM8PJ2jnNHMBPqDo0G5MPScw3N/6G9xogzfZUsUP+R7AGzCAevWqbNmfWN/rcrUAJGI+GbmC5bMrT8Xo+OouLWKOBKI409Xgvwh9CnYsEfc2ZxmTrZvV79aQ3jsilIeXyjsmYQHYXEOzWfWbZiM9lBPMFQRYGl26zZJgiskhbgBCo7F7bPU19QtXvJ1KZCG/pB/KaVKeWZL9K7l7KaCFzMBnNUlzCSFzEndv1Eh6ocG8+hZeMKEqxi7cfCRJortthwofQeHPSC2xHOSvNouO5qN7FVvqosM8/lY5R79QhKMPK6/xs2FWM7QVTTHHPN/FM3stBMeRFUF4jt9m0twJQVNc75UIG2N2UdrOXFrMWalPT4uvvGAZt/fXxBwKjG5WcPPtefuivq0Ht0TwPOT7ZKm/NE8bh5ygxOcVNEBEMLRpIj6K7twOfUdhXdeTz+1h8OoqK+08XWgXsF5swaMHps7wU01iy57j4bGVj60qucAHqhMpYA7OnnBh6GvgcOlSZ3tBtT3Shqustgb7lccrRmXtAlQf++KvuflJXFcppC3k++fAgtos4Xcw4My/ehIzS5RA4RUWLh69Du3PcRqpf7q8hjCslJByd0BOC4Pfavi364HQB+Xb+mhA3E9ErrzPFH9tjS9yPY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(966005)(6916009)(54906003)(83380400001)(478600001)(316002)(6666004)(70586007)(70206006)(8676002)(4326008)(41300700001)(5660300002)(2906002)(8936002)(36756003)(2616005)(26005)(44832011)(336012)(186003)(1076003)(36860700001)(47076005)(426003)(356005)(40460700003)(82310400005)(81166007)(82740400003)(86362001)(40480700001)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 11:05:28.8993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aaeddd57-f6ee-455c-50ab-08da9faf05ac X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6684 Perform the following cleanup: - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version used in this test is v2, - use fdtput to perform modifications on the dtb, - use DEBIAN_FRONTENT=noninteractive to prevent interactive prompt being stuck waiting for answer other than "yes", - fix the number of cpus in the device tree because currently we generate it with a single cpu and try to run QEMU with two, - fix the memory size we pass when generating QEMU device tree as it does not match the memory size with what we run QEMU. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v2: - none --- automation/scripts/qemu-alpine-arm64.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-alpine-arm64.sh index f4ac2d856fa0..7b52d77d3c84 100755 --- a/automation/scripts/qemu-alpine-arm64.sh +++ b/automation/scripts/qemu-alpine-arm64.sh @@ -2,6 +2,7 @@ set -ex +export DEBIAN_FRONTENT=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ u-boot-tools \ @@ -73,18 +74,17 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -display none \ - -machine dumpdtb=binaries/virt-gicv3.dtb + -m 2048 -smp 2 -display none \ + -machine dumpdtb=binaries/virt-gicv2.dtb + # XXX disable pl061 to avoid Linux crash -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" -DEVICE_TREE="virt-gicv3.dtb" +DEVICE_TREE="virt-gicv2.dtb" XEN="xen" DOM0_KERNEL="Image" DOM0_RAMDISK="xen-rootfs.cpio.gz" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:00:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411709.654732 (Exim 4.92) (envelope-from ) id 1ocmmV-0006Ax-Es; Mon, 26 Sep 2022 12:00:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411709.654732; Mon, 26 Sep 2022 12:00:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmmV-0006Aq-C1; Mon, 26 Sep 2022 12:00:15 +0000 Received: by outflank-mailman (input) for mailman id 411709; Mon, 26 Sep 2022 12:00:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmmU-0006Ai-IZ for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:00:14 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10072.outbound.protection.outlook.com [40.107.1.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c63092e4-3d92-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 14:00:12 +0200 (CEST) Received: from DB6PR0402CA0017.eurprd04.prod.outlook.com (2603:10a6:4:91::27) by DB9PR08MB6489.eurprd08.prod.outlook.com (2603:10a6:10:256::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.23; Mon, 26 Sep 2022 12:00:10 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::c8) by DB6PR0402CA0017.outlook.office365.com (2603:10a6:4:91::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 12:00:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:00:09 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Mon, 26 Sep 2022 12:00:09 +0000 Received: from 6d2b922dded2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 88758C60-8D92-4807-BCC5-D74D154AF47B.1; Mon, 26 Sep 2022 12:00:02 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6d2b922dded2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:00:02 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by GV1PR08MB7684.eurprd08.prod.outlook.com (2603:10a6:150:63::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:00:00 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 12:00:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c63092e4-3d92-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=afAZgqfyEaSArx6O1teB/HFKUtaKao4SIXdaRoygYcSGHO21kQdTYdGaR2y+BCdOYLD8AwWomdXce8WGml1PuHA7XlmBRV2xdTtuKxHPNr88lBpyVVGlZVndxoRqmFaJwWbE4FPvujsSnhi6LmjcHo67uHwCoCKDBCWE7loDK2lGfjEWCqw0quwkdBI0y4zo2QEcl04IlaMIgpieQQXZBAFEgEiJdCaHaUEJKgdYnybvSsloG0y5qoAvjWk3OgdHj1/OmHUlfbJJvt+jSyHc4f5gW1H2qMsyWdU8LCZzt0iub1WLeByM9yPGBhtzxBndv/NRTkbLrpykkGMc05KzRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/lrE8DZxr3MNuyq/7XX8TSYx8fwwJPYEDbnZexAW1iI=; b=jv97ke9zwRvFc/ZAJtidNyvng+VhNY1wIt1e2OkGuOjj089d+ubP9ZE+WZKuj89BUOTqHpjDbzHAzhSlHnux7d3Y4TLv4zIAm9DkB8j47hSmVXgQKmAMWkIg2dI8GKb6JXv6CH5UZ10OYmfpIv5sm4aLhS8J8q/ZLOspTvq+GCYTnsNxHhSBW4U0yHflHi6CJAungbzQJxxEbyYrZ4v6BfzH5ics4qG4FdbZti4KkX5+rSm1Ju1LUJB2nvlDrRYHH7xGegHgMSZm3IJlRfQfFnAJ7DB/V3EfyC2hvvan2kd79SNXVlYrb4VqzGyRKNV22byLWFrpPsGTGPJW6+V+ng== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/lrE8DZxr3MNuyq/7XX8TSYx8fwwJPYEDbnZexAW1iI=; b=ySrvwzpTxtEChuuRtnaLUg6trIFPWRG3ctCACvhqAQo3rn2JNfSYIyn5DgycRDhAisDAvuY87B/jkCgvsMKCq/no8WWKEd1KEBNkwkfDB0ErW0pX0EFO0hrL16kAif6H/h57FBl0/V1GhABhUxDse84rPG1bDQjA3oyPHCF7YKs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8738a677bf7b120a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZqbIxbzeuqLgq0cC/UWkKZ+FYwkOITfMcbUhPUqXRv9FtA4IXmzwRW7UMIuN1pUmAHMijOduuPXrYeBgSSmNye9ZxD3ZGPyBh3rbIVQu2kYvj0+rdz+X8ataUrO6t151+4Mt8zN779GBWEnSh8VjNjXeHmofO/DUwiopr6icJolje6Klza1eGuq1zg+1RBvBJxh23CnKHHO6qCht55ZRkJe0R5Pk4Rr1S8yH6lMBvBPQk2/cAkAAarF82SbqaQVA3gg5Xq80ULXbz9wWU3F94YnjKZfV6mlk2U9j8ZhXPwqP3oVFfsruWvFim8C2SgC3FAzpg00ymYFb7+wcV8Enw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/lrE8DZxr3MNuyq/7XX8TSYx8fwwJPYEDbnZexAW1iI=; b=iKztfLKWBjtI55gjnfGJlNAS/NgCx4m4dKcTnr/ndxDHjtV0Gk0reqmMpT7bv/55Otxt4xJXWSGJWPFeJ0XHP0NED1Dq2wZ1MkdfhCZDtium055FX4gQWsrFFMpATN7Rj4XnOhg1WeJTyFhr6gVaRTSOedKnse6GgAbepetKpu3uo83Ku7Ddd+erU62Xvc2k57lo7cqw46p7H0z+J12C6ZrUeEtUjr6Pmu7a/+c21C3dDB5xW3Qww02af4sFQLpd8PFPA82KOAwbO4JwmSYCq0NkFZ69NWtn3b8RXjJM9aO+3fKF75IgePfzubgkOYL4DycPnaM0qsosq792ckpL9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/lrE8DZxr3MNuyq/7XX8TSYx8fwwJPYEDbnZexAW1iI=; b=ySrvwzpTxtEChuuRtnaLUg6trIFPWRG3ctCACvhqAQo3rn2JNfSYIyn5DgycRDhAisDAvuY87B/jkCgvsMKCq/no8WWKEd1KEBNkwkfDB0ErW0pX0EFO0hrL16kAif6H/h57FBl0/V1GhABhUxDse84rPG1bDQjA3oyPHCF7YKs= From: Luca Fancellu To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container Thread-Topic: [PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container Thread-Index: AQHY0ZfZXzMlSEHhuEq/DKetD0ah9a3xm9CA Date: Mon, 26 Sep 2022 12:00:00 +0000 Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-3-michal.orzel@amd.com> In-Reply-To: <20220926110423.26030-3-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|GV1PR08MB7684:EE_|DBAEUR03FT050:EE_|DB9PR08MB6489:EE_ X-MS-Office365-Filtering-Correlation-Id: 57276585-00b7-41cd-2248-08da9fb6a92a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dy14HL7oT9zy+lB94dk4vLn3X7gcmehkF5ckcHs6rYCe5/7DoRiaSMZYIBQUxy68DuNBdLiSpJhUQpNgDjnRKI9y7LFtE8FFFOgU9vxMy5wh0kBffM4Gvud/FG70tXnBGrbvlnMGE/6uLmXtza6HVGaCf3IUyXebrIjwBDTuxe9rq9SOGd0jKnbvtfgGAbu/9yjIxgK7i0Vf/0tTlaRiZ1nEVFt0LbwM1bgl8d9wZspqMw76lMCBo01+ACcLTWuiMSXthWM7w8U1MSIkEupf3bVShBR4kIw+/L3Bgqn0mdKSSwgzCNgx5w91q0xQ9ql8kebQRC2kS8HIoDCyrXc7lXsNjdJzpp7xWMF/3WPsG2TDvCtrjJiM0f/ZAOZJ7hhUKMgQjFr/xIrWhHMW1Flwbghyuqb/aXO2X/8XH5GR9cbscRO+bNUZejVb6tRNq90/N5Vd4IOuYr2SS8oRs/BRFYPGfGMwRwWsOLWaf6MM/xZJjxZDx3O8YTn7tWM42Wal2CcMfDTO2ScFIPAjt/GcLpxNlFmz6Cp6OuvkEkUdnNv7bI7fsPNoY179t8KOLy8nQ88USuAlFg92E5ScPPC6MfxjhrtQdaIKaGkqaazR8YL7I8Egyz95FZYLoYfc2bnGSxqvR7vaJK+bQpE1JG53x1g6ZG5xulddn6tMvwS178KkOn2p/fL1DnS4SYe2pYOLDKhLx77iMqHjQVHeZEyUWBBavZv+N/5tt5i1A1XuvEwOksRFRNwU1SUnpNCRS2I9m4reWmO6ZLVfQpJzrveHzXMq3cN7pBsYmGWEO0UKNec= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199015)(122000001)(2906002)(86362001)(71200400001)(186003)(6512007)(38070700005)(26005)(6506007)(41300700001)(6486002)(2616005)(53546011)(36756003)(8936002)(5660300002)(38100700002)(4744005)(316002)(6916009)(54906003)(478600001)(64756008)(66446008)(8676002)(66476007)(4326008)(91956017)(66556008)(76116006)(66946007)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <29512FE34749474193DD7680E3393107@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7684 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5057a859-454d-4318-925d-08da9fb6a3b3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v2pplrxL279VehEMrTkJNMz0xdm82Y+Xop6eqjiTzHd/rFtImHq6p/8g2tYYv46cqdIbIBKzY8xVBBdbADpCLLGZmKkw0WAu3tBd8Y82bdm3tdNsoOPJ56o4OE9c55J7V4+rFlmicNtnZAnBiday6FEU7PP0J61T2rgFTZrqfd9qJp5n502YYCHvQlQXBFee5idS/idPWzBJdEMRi8+5QAVEBqpwoiO2xb50Y1AzFDEnpb90fQScKLe6RqORFg/r4r/9/ymCHF+0fu5vpAFi60Wph19MthRFVH7UO3iBxjgnUpob1BvlCLrBOKdBALDvIgkKDRGK/Scu/sMhYMWpkkiKSiCaxLncQ6Gj9WhZgfDQBj6tmfWTAFPnSCwlEjsNvOWVOGyqs+vwVgZuhaVCA0GhdXzX6nM1MKFkFJK5AH2T0IpMYWAasadA2mbrn2H7lteibOqNoLs0s0sfJO1KCbc3YLD/NJ2uXrYs5xQtAV5Tbr9gdfNPCg0i7xNDBv1qa+GjJRXigVqx1Jl6yr8BfefV6ANAADWbyDt/ek5ze2/vq6FajHMbrWs+ZBoWfgwq8LiZq0MbRtRc62rmsJHsG6JZdrNEcQgDDvZIk9yIwE9VlA1NDLxMIpdh+droGHA3OPF+/iIXtKtVl1icR3OF3sBgZwLHTRTGrDANp6ujWCG2A0daGCXvamuCEBe05I648ERAx5uwqxCJewMqd4wSwgrSSf6tJeVvOGkW/ErooaTz3M4qEaL3joKXwGJ++FHwJlISn0cY9nAixEOgyU3ujQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(86362001)(70586007)(70206006)(8936002)(6862004)(6486002)(478600001)(4326008)(54906003)(8676002)(316002)(40460700003)(2906002)(36756003)(82310400005)(33656002)(4744005)(40480700001)(5660300002)(36860700001)(336012)(81166007)(356005)(82740400003)(2616005)(186003)(107886003)(53546011)(6512007)(26005)(41300700001)(47076005)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:00:09.7165 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57276585-00b7-41cd-2248-08da9fb6a92a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6489 > On 26 Sep 2022, at 12:04, Michal Orzel wrote: >=20 > For arm64 we perform builds using debian and alpine containers. > We are missing the randconfig build jobs for the latter, so add them. > This way for each container we have 4 fundamental build jobs: > - defconfig non-debug/debug > - randconfig non-debug/debug >=20 > Signed-off-by: Michal Orzel Hi Michal, This looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:02:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411716.654743 (Exim 4.92) (envelope-from ) id 1ocmow-0006p6-RF; Mon, 26 Sep 2022 12:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411716.654743; Mon, 26 Sep 2022 12:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmow-0006oz-OR; Mon, 26 Sep 2022 12:02:46 +0000 Received: by outflank-mailman (input) for mailman id 411716; Mon, 26 Sep 2022 12:02:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmov-0006or-Km for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:02:45 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70051.outbound.protection.outlook.com [40.107.7.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 213833f9-3d93-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 14:02:44 +0200 (CEST) Received: from AS8P189CA0056.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::33) by PAXPR08MB7382.eurprd08.prod.outlook.com (2603:10a6:102:22d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:02:43 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:458:cafe::b) by AS8P189CA0056.outlook.office365.com (2603:10a6:20b:458::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 12:02:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:02:42 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Mon, 26 Sep 2022 12:02:42 +0000 Received: from 3accd779a705.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1C3FF296-2195-4B74-99D2-E76C99E98C83.1; Mon, 26 Sep 2022 12:02:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3accd779a705.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:02:35 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS8PR08MB6133.eurprd08.prod.outlook.com (2603:10a6:20b:298::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:02:34 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 12:02:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 213833f9-3d93-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mcOGjrwBFuwBfvvQmAMAWTnLIQesICIlb3x4mPjefVEPUbvoTqhBpHQ+fFbS/cWAH7AQQRiVjcm7sMwlP0RexsoTIwOiKonro5eq6pjqXIEw65FAvyVLNuTY/ANiww0/vK2+S773JjL4NV4j1sGWKltgeA0k8THN3xhZrjnTixD7F6Nd6giFxKK9nooTxbwVW2hxIMUR37sit2THUjKlf4cVzdeaz5ljjWCPvGAkA/zQxTeY/MjEkfFnKZ/Z6IuwLBpU0M2DEDzwyjVZyOr/wcAnY0TrOnnm0qvdJvtq/3RFB+k0WAgTguaKEmA3vRR+3l1kOOQGI7SpjCyOjmsAug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KasLfE/X0LhDELQ0X2bfKouKx3VzTwYshly2bC4Aelo=; b=mDza+feByzeFzRv0XXZBDKcBsSJCCbgw9F0hAOpv01QwsVdue4RKKKMq6ilQOjD6YlvIEg2BVbqhXxFcJhvuzzrITZDt8A11IjXw/xr0Y072qlOikOStCESibCEw0282AT7rFQtd1CexAF1ODZ5bQFo5jD2sTd1wnXHY+RbGnwbLyD054EUmcZptyJLBYjxDSuM7NFqP/03gaoBElxuDl1T5b+OHplgnuS4noDpZUwXlrKfNn3Elw2IbER0GPQc+JsFe2E0TWfGGwQYkhBU7yVJ4FamY5GbrV3/KbjTR0ADCFZ0XXW6HqOPBAAySkJ4evmz9GiUjHfJzrrZ942ga6w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KasLfE/X0LhDELQ0X2bfKouKx3VzTwYshly2bC4Aelo=; b=1EdbL+kzrsupTdSJIef+buyl/cyOnAZhTwAo1ECWtz+eHtGZI7qqet+IJr6CyEyAdooXAb9FSiIVPZ5+PyaQD+dXSOxi81QE2s9LsZnecQjNQF7yqjXbIcAsBQGZtxfqkcor0raY70rZG5s6j/a2UPK7dcsNvhyqUNbaM7Cy44I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e14c49fc4586f81e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ExWEtDEB36+q59UWMPLTP7qaHGSWKQDrOWT89qosRIy8FQI5lc3a5bHWiyvzlDn2HUSG+RtyPx06ZYS94V9+qr8WJ1M9vEzL9lHTUzirTwojr3rpanQNWq/e/KPFws2MYEhaabM3BdkQD94Xu+M3NnnGSLape8BOGMS1GTWr71sCvHWOEcQEslxcVYTI2YdnLiJvXlygBo+UrxMcUf+DmyrTZoheWxJVAt9iSbA+BAblNU9iyR9zuuKGtAQZgmEAs0bWG8BBJjnJSq1AycdFTtpeN7kUFYEq/kht+jgDC/xdrjRl41LApq1zh2HsOwj6UbK5DqxhNQODsFj5CbL71w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KasLfE/X0LhDELQ0X2bfKouKx3VzTwYshly2bC4Aelo=; b=nn7GhqQSokEjeotJGdccthO8RZNhMASj6OEgr7AkgKy8j0lUamZIQFKVrzXcC+7aozUizuwpLCSUlEisGGjtxGNpUlEO+RKuBflLZbmT+J5puaND5Lu/JiW8C0Q9fjNPAVeNvZxSNJ6s/u1HZCL85b3S5AM59VBuqGikxYic9hSvvHa6gvolKS54gV50NwC6k8CBffl0QJRhDoal7vuz2ozNaMbVAWqud8kIojny0rSbryjgPDN20G0pgTpo6pAjsMNq6NazXI9FRfVwHjwKxjP6JV4YhnNK+hrpZQ0nRaCEip9xiw4pJ5askUAPd/6Bwatsj68jTs48lQnxi8L1nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KasLfE/X0LhDELQ0X2bfKouKx3VzTwYshly2bC4Aelo=; b=1EdbL+kzrsupTdSJIef+buyl/cyOnAZhTwAo1ECWtz+eHtGZI7qqet+IJr6CyEyAdooXAb9FSiIVPZ5+PyaQD+dXSOxi81QE2s9LsZnecQjNQF7yqjXbIcAsBQGZtxfqkcor0raY70rZG5s6j/a2UPK7dcsNvhyqUNbaM7Cy44I= From: Luca Fancellu To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size Thread-Topic: [PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size Thread-Index: AQHY0ZfSoOTmkXvu7EK7d+66XPqkYK3xnIiA Date: Mon, 26 Sep 2022 12:02:34 +0000 Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-4-michal.orzel@amd.com> In-Reply-To: <20220926110423.26030-4-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AS8PR08MB6133:EE_|AM7EUR03FT041:EE_|PAXPR08MB7382:EE_ X-MS-Office365-Filtering-Correlation-Id: ddf28a53-573b-4035-77f2-08da9fb7044a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PLCngetpR/5BAPVdeiIXfvnG/+Sa59KC5HINrq4pN1rwA3KKIl5nAW3eCO/A+mZ5MvT5ngowekcSiz81uSYWepNW8bc6BhZU3gjSnApFbXOzowXWJ14nOwrWVKO5cqePf67XA/mjdkH5af3noYBfVmtO6NOuXPBov6MVdR6NWC99J4YPREuEGYVYc74upvE/uqIqZzThC6xZebPxSqGyWDxRQiOqfRlLqFmKIyyBhNK9N+pqZ2rxNxPExEIUcCLCSg4Rjd6uAf0moj6V2A4qlhre6adOvxVjmdJMpTtLWBxgYycjG3NNN7+beHc5xdpJ1SGemWXMq1BjC6cx30xhEIjhPs3BYeNKjExOaZ64tCy0UE4VBdqoEviDEE2hkFc8i5itQ8mNC7KxfyJQsUqNX0gcGou0jRud+BCEO9g/s2Pcg1gpPJhZc8MJYwBxiQh6UO1nFKwThF7mzAy74+JYwQrrMfL6dJa60dwb0Q3vZ0mTQt2cu3XTKLQ68bWacwaabzvsBJJ3mUfvw5AfSjBQIb7ebD+D8TVL2zaoGZMiyUk8AoejV+IHN2Ep7R/lAep2JyjD15suuvd5K6UpNKce63fCTR5mK/DhdyPGgVrpeOIQF9ZMhdeP9sE5CZDknYlpVtfDIGXF4BvkKvLTPlI4jFwevodVztfx0y+4s88vz3af9TCsF6JT5uJzzUPIM0oa95CREZeVyqwWNdZiv6OxCl8tVnecLzhFCZQ5EcaPoySGJClbi4AEgCBVb4K3rieVCfbupdiTdMOKV5zOJ1SKljux9tIMmmxtM+U/LlgBHBo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(71200400001)(186003)(8676002)(2616005)(316002)(38100700002)(8936002)(4744005)(26005)(53546011)(6512007)(6506007)(86362001)(91956017)(5660300002)(2906002)(38070700005)(478600001)(66556008)(64756008)(66476007)(66446008)(76116006)(54906003)(66946007)(6916009)(122000001)(4326008)(36756003)(33656002)(41300700001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <312EF131A665C64CB093F90185AE159A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6133 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cecbfa04-c8da-41e6-6659-08da9fb6ff6e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z1JZZPYCHp0IwIV+SbppwYV9rDmwu7wPSzjSfRMrVOVjK+ksxyOFN7VY1Q5j7eqWnVGcQB+X1cxC9RPIHAElVnXaCVhgIc8egK5qS3FKUchsFVp/AV79YkpLWXa5tO83D//xAn5jKPJguwDZ/5DqfC+/SKySbuKl5grX1ESxfFSZhH9AOEqi4iUn2U1zVAOdW881yRJaq6IR7cFthJ1hvmpIZAP6ANjPhfQB2CoQc+Z27OT+eaaIlqoqp8SR8RCNNeWmj7qOLnhrwqTMEn5iOuRvw5EcqmtIrgynGGYtaYY9EEpT/JG6xVontGtrHhgw1+ynPrxmGxFWciX8URVyxfex3apKmJKEYvhWbx/YH5idfSRXUihA0KCVwJcSrDXLp25FK1b1etmsaktGPLGQM2LAXOTF+1BwEgFfYNKeNe9LVl4cHkixbtByqzMw14PBkBQh5B4e65tZXrGJSS32H+DoWvG/Miz3R0PrLBz/GSybXrj4QEeCE72MzZgF+sYMXfZQcM1AhPiMx6/7ZneOtl937oAsr7cqJ5LLDE/Rk1Nl4S3j9NR/0lKHSRdY1je1yT8D0bNzK4OWIN2i+LE9bdRnrb7F2B0zStB3RfC8okyK3Jt+nCrB7dlzmF63mRbMtlYir1GLqg3RHdNL8hTR5JVlFVszYzv7EKCHz86oo4muGazCZnTKBKC3rPwxQGW7+ydvDjfjAxOYQnY6GlvEgxmw4ph89bT7hrsH2htusbZCcBENv9qbMPMk+9cVk7YAF9zTBuMO0TLN1r66GDpuuA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(47076005)(40460700003)(36756003)(33656002)(356005)(2906002)(81166007)(86362001)(70586007)(82740400003)(4744005)(70206006)(5660300002)(6862004)(8936002)(8676002)(4326008)(6512007)(54906003)(36860700001)(316002)(40480700001)(82310400005)(26005)(478600001)(2616005)(53546011)(6506007)(186003)(336012)(107886003)(41300700001)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:02:42.5698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ddf28a53-573b-4035-77f2-08da9fb7044a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7382 > On 26 Sep 2022, at 12:04, Michal Orzel wrote: >=20 > In the follow-up patch we will add new jobs using debug Xen builds. > Because the debug builds take more space and we might end up in > a situation when there is not enough free space (especially during > a static memory test that reserves some region in the middle), increase > RAM size for QEMU from 1GB to 2GB. >=20 > Signed-off-by: Michal Orzel Hi Michal, This looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:03:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:03:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411720.654754 (Exim 4.92) (envelope-from ) id 1ocmpS-0007IS-4W; Mon, 26 Sep 2022 12:03:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411720.654754; Mon, 26 Sep 2022 12:03:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmpS-0007IL-1W; Mon, 26 Sep 2022 12:03:18 +0000 Received: by outflank-mailman (input) for mailman id 411720; Mon, 26 Sep 2022 12:03:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmpQ-0007Gn-SA for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:03:16 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50044.outbound.protection.outlook.com [40.107.5.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33a2f13a-3d93-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 14:03:15 +0200 (CEST) Received: from DB6PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:4:29::11) by AS2PR08MB9714.eurprd08.prod.outlook.com (2603:10a6:20b:606::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:03:13 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::38) by DB6PR0202CA0001.outlook.office365.com (2603:10a6:4:29::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 12:03:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:03:13 +0000 Received: ("Tessian outbound 3c27ae03f5ec:v124"); Mon, 26 Sep 2022 12:03:13 +0000 Received: from 2b25109b6a7e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C1FEB1C5-7798-440C-B1F0-333A6954517C.1; Mon, 26 Sep 2022 12:03:06 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b25109b6a7e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:03:06 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS8PR08MB6133.eurprd08.prod.outlook.com (2603:10a6:20b:298::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:03:05 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 12:03:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33a2f13a-3d93-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JjAQS/0vNYzna107O28Jsl6sjYrRMEo/xkHFgMMYK6mAyDm35WgY11l7LeOs1iUI+SpFS2QdmAd71mhGG65B/cK35Md5+XPWnVnFeyl+cC/7F8p57QyPZCDDYYIE0WxFw0WRqWAQ+M/2bSshdh78sqvKM6bKDlzqbgWET5Sk6xv3msSOR/xcYbWOJXXIAsm2qfNctxmsmI0ZK5Xu5OSXi8XJF7J9Vq9eFN8CJyHMkTH9eLq7jS33NQgxQlVH+vBf6a/0uYoga/43E4N5WRiPphzEqqpAl1uThGKaisZzk5PQSwkgnVBNcgvqLkgDI/2OhjC8s+RjIZyFLTEC2chIGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jzYwX7vb1KK1OgAAwpa2Jya2o8+y4mTZsYXv3yDt33Q=; b=DmGR7ur6InIwVqZAPn4aFEds6CPyy3NT3Z3IJ5ejMWfiDdgfFH7HiH1JVZy7S0JPVb94c/cvgDB9OOpsuU1OqPdAq/DCeMvtcsILErhKUp4jCLS7NyJJwigiP74wjq0HJwByhvOv6zSbaOesQ7ODV3pzdh9m63pXLNeVsJCr+XtU9mJylNaHHqI6VSln6PTx2FnKkRSxe/GbZK/OhRG6+08l1DJfuxYalCZ3TD5VKctBcZ2YvjcA2o22Jgo1Xg6K0glrfp+Hc72Efvy0t+V9Nvjiam90a4hcL8pM+gUVQmfPw14whfCjIgjUULq1CgyhAepeeqn7htC8HPxqmfIgBA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jzYwX7vb1KK1OgAAwpa2Jya2o8+y4mTZsYXv3yDt33Q=; b=z8IHs/BN/yfhTI5v+UIeCX8s/Gy/z8mjWkM5UhaYsPF+/dCRI653nvyNxafJnolJYmV64OXxMi83nr9/2PrcmaHio96H9Flqowi27B1/ugp1aA2XKVyjVz+Su18wlB0XxjU3sRAnC/38zZdefrlmm+mUdnT+zoga35Ejopam+UM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 69146f1d6f72bd97 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gtNiEpul1Osd2b3apko042lrG4HVgTXihqKLy9m1YGt9G8aC8+O6gzsvfyiqMgB37wW8FNwf+YG8YOUhBT23wZziSbGtoEk8n4qDN3yayzONtqBE1PSxaF6yDDEykNg0VIJn9tb+X3Bq4nwEI6ikYEwR0TgSn3xnvmmK/bJMFYb9+3OUcrb4qhALc75mLLYX7Eyi0RuGUCr9fFxlMhWMid+Ad92hAQJ5vIXURWSAYHazmR1mClBOazPyx/LJypjvM2PuwBPCgbqhPf2NyNseGv1bIaHm4QEq1A3IgNGd8OrIm18OOAdwSxx8p7UjGNza3S22h8FNzcfjfPPm546/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jzYwX7vb1KK1OgAAwpa2Jya2o8+y4mTZsYXv3yDt33Q=; b=RgWQ/vlrlilp7o/dPxe9icbX9Qc+G3u3DI1D4uXg1IYKdUptFzDcze2h8rV1ql9km9kKC5TEAmZdiRQI8xBto65EXw0FM1EHFCnNTnMG4OApCC4inH4Z0ZrgAkBwQY2Wj4JYzeOR/WCeitDCwPQwvIqYxGbOsqC/ZvRgP8QW2uWI3rH64+6bklvymhxTN0Scymd/FzM5GQZKsIO9dtA0yvykDlhZdaEpvxDyOTNx5alKOGw676/takTnzQ6kOiO2CyvnssdXmT+Dou1ncqziPySMvKhR6fyF2Ji6akfjihyyfsEgJ6qyqDvvxmkU9HCjncsglQWDOyFv0BPQvNMyTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jzYwX7vb1KK1OgAAwpa2Jya2o8+y4mTZsYXv3yDt33Q=; b=z8IHs/BN/yfhTI5v+UIeCX8s/Gy/z8mjWkM5UhaYsPF+/dCRI653nvyNxafJnolJYmV64OXxMi83nr9/2PrcmaHio96H9Flqowi27B1/ugp1aA2XKVyjVz+Su18wlB0XxjU3sRAnC/38zZdefrlmm+mUdnT+zoga35Ejopam+UM= From: Luca Fancellu To: Michal Orzel CC: Xen development discussion , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Thread-Topic: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Thread-Index: AQHY0ZlPuMCVGNTPOE2yAZ2LVPw1i63xnKoA Date: Mon, 26 Sep 2022 12:03:05 +0000 Message-ID: <2DAF4A07-AE3D-450B-A440-1B03769AE57E@arm.com> References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-7-michal.orzel@amd.com> In-Reply-To: <20220926110423.26030-7-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AS8PR08MB6133:EE_|DBAEUR03FT051:EE_|AS2PR08MB9714:EE_ X-MS-Office365-Filtering-Correlation-Id: b9505f20-25c1-4845-00b3-08da9fb71674 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tKINFJu5LMt9nskBjVCIXu8Gq22U50zbcFYOn/eDRvliy9IKPhklJ9OmIcvP7GQmklnbdb99SBdv3VOEeB67T42nMQTgFIFFynVyUKfv1+7whVg0mRjARTAV0seosqP5fiGOouLOgJ7U9PX5ri559VbqzyIx/3DrivyGikpKVfuD34+PegXjr8bokuNaksscpJ5A6Ot7gFi83WhAwQANxRH4YoVfYr++MENh1/aNDuj4w5OGU55zjTjDlBKSOQZ/dHeX0IbFfc9nOATkMxjT4i8KqtrFgyJ1VwESGGIW22ekjHM4CKjFCnXrC89It3yeZKYHQlwaQdXRBRqXgTp1XeyVkMlM1/NeX75m9Xx/8YFCi66ajCbYcBj9w2THV2XeZIHMZvv8tZly7NzPF9jP2Dc9zDcYxx50GMxP4EDWBFuwkwpTcJprBoBqVw7UizEwqNcp/brP1E1Ce51d1RhxMpTxxELP9/gZEfxXy0ndBtslmoeJL1ghikC6cDbR0KGdI7lgwm48rgFn1iOtXZOB+BpuRBxZE2lFWfXCs8hIpLe71spmpCSVvWY7SC+VB1y2Ki1Pj6GG8YnG1hU820Q+dqtWQroNSuHP0Zz51W7o93EZqedLZfK6ce3Y8T/hM9xuV0pfZ7j1U0zpcjtj6LvHfWEwTVWvaqIqTTjHxYXqFt6kGNDrfha/j8UQFdzrVBReNLBF5WFUd/oB1aaRbPZ9gKUBO2m4FteqQ21YtK4IRL4BdJa1bYmXei29caRPLhmj0WhGKhleRBjcNcPkYIUzPzuDf9TU6lkcUvWREZ4bTfk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(71200400001)(186003)(8676002)(2616005)(316002)(38100700002)(8936002)(4744005)(26005)(53546011)(6512007)(6506007)(86362001)(91956017)(5660300002)(2906002)(38070700005)(478600001)(66556008)(64756008)(66476007)(66446008)(76116006)(54906003)(66946007)(6916009)(122000001)(4326008)(36756003)(33656002)(41300700001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1FA584E5C2BB0543B8CE91DEABC441EF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6133 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 14fcf782-2513-48d2-69e0-08da9fb711fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e0doYlyMKKP7lYEVW2BR/q7+POeBAXy9DJA925t+YR4qdP8E1LpfIj0FN7eERFenQx7cc1g4nGNmvvtuXx+fk2v1r9bglhwxnYsZF8ZswDl+XgK6bYTnowbdomI6eeyaRZK5dbrDgKuiexF1QhBXQub+F3aa/FjxwCUs7VKeFO9YR7tQArsCsRalq+uhPYzyMUa9G9aHkqf7xxMWEZK4dsfBP9A3kt5jIInJKDjf6iQLTZNS9bhIq/j2rJGhqOTmYCmZD9LOaeXut5MnUr7NzE0R4j57vWuaR60SDbPKJt0J2fd8jwwy8z8zxJSqfbnqpOInXQq/ArQJNeQHSqKY05/8dywWFc+afyPHJNstZLXegklFUQ6YITWaNdaKG2QJ43FTDmhC++nraKZ8ey95nX+64WMiFJ7Ywy5Dp2+pw3jkKhQd0jayPNLRG+AQqCYdVrkunw16/tNUknIotygepGsF5AK2///1zTg514u2iwxECodg6EMRjumTDZzFQAJFWBxhMkap8HgNZ30dwN9iQ2h8trWo8QgNdInVhmu0eDkfc1YdTx4hovjjIW0M0MhF2fC+YhZvag/COVJCf1TNezgbdsBjzxdQoAH8QL0O7IAypL5BkLmuPNr20SsQ+cXqbYUPGKCGKMetAH7hIMG5gswFZNk/BqBdExMWM9HGKEUKKW71BAn0cE1YZTTpYGGaRJY2MJFz0F0G77LIfZOKvKkyyDY3980HTNTZ2Xvn+YnJrI7ABH8xTv91PQq9Iejs1kwA89Tpc98MmNcNsWi1Fw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(54906003)(316002)(6486002)(478600001)(70586007)(70206006)(8676002)(4326008)(107886003)(41300700001)(6506007)(36756003)(5660300002)(53546011)(6512007)(26005)(4744005)(6862004)(2906002)(2616005)(8936002)(33656002)(186003)(336012)(36860700001)(47076005)(356005)(40460700003)(82310400005)(81166007)(82740400003)(40480700001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:03:13.0722 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9505f20-25c1-4845-00b3-08da9fb71674 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9714 > On 26 Sep 2022, at 12:04, Michal Orzel wrote: >=20 > Take an example from arm64 qemu test scripts and use ImageBuilder > to generate u-boot script automatically. Calculating the addresses > manually is quite error prone and also we will be able to benefit > from using ImageBuilder when adding domUs to this test in the future. >=20 > Install and use u-boot from the debian package. > Modify the script so that binaries are loaded from u-boot via tftp. > Remove dtuart=3D/pl011@9000000 because stdout-path in QEMU dtb is always > set to pl011 node path. >=20 > Signed-off-by: Michal Orzel > --- > Changes in v2: > - add explanation in commit msg why we remove dtuart path > --- Hi Michal, This looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:03:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:03:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411724.654764 (Exim 4.92) (envelope-from ) id 1ocmpw-0007q1-G6; Mon, 26 Sep 2022 12:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411724.654764; Mon, 26 Sep 2022 12:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmpw-0007pq-DV; Mon, 26 Sep 2022 12:03:48 +0000 Received: by outflank-mailman (input) for mailman id 411724; Mon, 26 Sep 2022 12:03:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmpv-0007pc-MA for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:03:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4611b49b-3d93-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 14:03:46 +0200 (CEST) Received: from DB6P193CA0011.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::21) by PAVPR08MB9748.eurprd08.prod.outlook.com (2603:10a6:102:31f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:03:44 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::59) by DB6P193CA0011.outlook.office365.com (2603:10a6:6:29::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 12:03:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:03:44 +0000 Received: ("Tessian outbound 3c27ae03f5ec:v124"); Mon, 26 Sep 2022 12:03:44 +0000 Received: from 966f48981c78.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E762EEC-5D88-4DB0-90E9-4613BD3AFFA7.1; Mon, 26 Sep 2022 12:03:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 966f48981c78.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:03:38 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS8PR08MB6133.eurprd08.prod.outlook.com (2603:10a6:20b:298::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:03:37 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 12:03:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4611b49b-3d93-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=moGg1uJruGLb7ZUfQaETGJljtmskuUjfE1dYwek8xMq3wy0c9qq6YE01KhCmtv56c4NLTP25VKog+MSdEv4Vi5q/n7rKsTVHBcqlrM9xs0ci9k/oAfb2q7BXcQwvYg1rc2aYFZON22ITlryWTHVuxzZx3vv9JjZL4VLyE0GFUTesOBLX5IgzbTUz0tDMHkVvibbBTgeZ4dmSb4ye1WYgGv1bVA5fFuWtIHpHS8n1K1WiFI3fsHPtuEh8aD4ksuPRGyBDuuyzNnUifPHTur5zGGDyQ2H17ALYBzyN6Q+nIHtsX+vM1XJ1+ludXyv8iI/Pt2YCrwBr5Y+JfjywTbnSlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z353RQmBsJZvD+7Y24OQQ3dFENhjfSi0Baxvw3VHwJs=; b=C1tAalE/xTV1wtXXehLQncn/p3iUj7zuHUHjFxt0N9QsdWuP74vQO0nMXxxkB80Sc98P9myZDmW1sBY8RrVYzJKtRTj8RjryhIf2Vre2CJr33uBirUpfk9SgU5+mzh+SovmP+bFx5XF2HFUEpq7VEfUyqjEVZgZa8Ee1kM4CbxCJVaQMCPoChI4YD+nlxQhWaCG3TzaZcutXD242lBDCGZXZhaXs+mdNAIksNTN0b8cjm7NTHEIZnFauc12DZjvOzl0zSsrTerdtW5ApckHbiKCBghkwNCOpPSY+7v0RFYP2U+RmopJhImyZBKlg9+XfyVWl3NfCGKVTtiwa6WDePw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z353RQmBsJZvD+7Y24OQQ3dFENhjfSi0Baxvw3VHwJs=; b=AnbNLtEcwWsqkOZmuN/DUZMf8UVopzxGcx8M0u9aIrsERuCK/BQ3P/Y9XuLsUuy1zaT92Hauo+nM8n4rip2ntvpKOi2OzIf9npUMxkJy4a7HJDpCBTwXY0pJJ6mqJ6poCLR/x4bjUnvs3C//r6iIRyIYz3Z4ErwPtluPvHMTrSk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7abb6dc3ae3078a4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bvg+3NhRFE0ym9jBO2gaRsXuOeR60Wnvp/Jhbnd3h45m2EN/T/tLrD8Koix7FFQI8MPobPDLrndmLLHZckvW7iRF12Lp+FMoWHepdJt8QD7bya83jdpThTc4FrqKQELV9DCKyMHUM6/ow86I42ENEIsBGCRzCqviR13pTV2lsGX1XAr2VYGd0t+ugwRjYlQ+FI/BMybq7QtxJHDGQxLzVyGDr2VOhJfvEHlbM5YB4lobG+EjRiNRxiRTkXXm5sMLjkBYopPJqEjZK0/7rq9Zgzlm7y4e8jdLAvaFLFaV/D2CBNGHu/+8tbQDbvQP35X4wRR4SKI9gZ3d2eyIl4Zhqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z353RQmBsJZvD+7Y24OQQ3dFENhjfSi0Baxvw3VHwJs=; b=hpPhbGUoEjO26EcCtMgk/7R19yqmmY4FBJBFMpdu1IoS3R0P8T5ymroyGlQAmAkJwAtRf0upsrLEW1LIos9L632K2xwxMhFZh0RbslK1EEpn0r/QKBpw2S9ETIJ6KTewxLVJ3m23Ep1RQWdYZNVtLQKaAew9PZE/q4k0XOyI9tw/x8OlsLAnG9FVEvIwk0GB/+7TvB4K7Q5q0WUN+CYXDXfPL2qemTEqIROJKRvtElNtnL16K/QFRdtFIlpRcZfsWqPavceFkvRbHDEhX8NY7eSaYT2ykYYbLRCz6DEn/XhwqkfNM8iGf+qW68T052niJ1O+WTHqEbN6q+O8YIICqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z353RQmBsJZvD+7Y24OQQ3dFENhjfSi0Baxvw3VHwJs=; b=AnbNLtEcwWsqkOZmuN/DUZMf8UVopzxGcx8M0u9aIrsERuCK/BQ3P/Y9XuLsUuy1zaT92Hauo+nM8n4rip2ntvpKOi2OzIf9npUMxkJy4a7HJDpCBTwXY0pJJ6mqJ6poCLR/x4bjUnvs3C//r6iIRyIYz3Z4ErwPtluPvHMTrSk= From: Luca Fancellu To: Michal Orzel CC: Xen development discussion , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed Thread-Topic: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed Thread-Index: AQHY0ZfkIABcS0GbDEawZdF7FSr8n63xnNMA Date: Mon, 26 Sep 2022 12:03:37 +0000 Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-2-michal.orzel@amd.com> In-Reply-To: <20220926110423.26030-2-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AS8PR08MB6133:EE_|DBAEUR03FT021:EE_|PAVPR08MB9748:EE_ X-MS-Office365-Filtering-Correlation-Id: 2125490b-80a2-44ca-a62f-08da9fb72914 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 96WEP3LlZ0QxQDciSGNb2cVDf+l4ntsIyyTLNNQ2qZSOWOMqn6kS8S2HW8/6R+IBmnNiXF2yTUST9+NB0OXCYzBU5lePCaOaWsAs3ASxAJaA/z6Tg+5BOnrQcih97o0NwW6Mk6EMTACV46FJ/qoTfrU0NWtMwMJeDoOlF+UxkqTQzCnBPD2sY7kxvDHjF5fsdzpH7axchRSQ+0FqHENXITdhGUYFbazyG7a8Tr7Er2efybnyW8JbBldhH8j3RH+/txlXT8NwiYP2UgBxm1OTSYPgM7vnqUoH6YbIluIaurnxljM51CmRN4G7rwhEtWrqFQYfOxbHpNATdBVCdNpw74FXdxsqvVm5B50CCMXC+ebReyuD6C8NTsb7Qap2QtgqLpk8+CtM86/3yPzi5U4Qe4Id8ggY6H2qZrFgVZZ0huQshXJuf76yxBrLQrhwfqd8bnK1NdqhXZKhKHhX82bOrIHG5uEl83llqbtIu8gJQzZjMPWVuesSde7kQaCxLDpeSITY44VOehihCsgkHdlP6fFoTkbe+YbxNH2DT+fVqHw7IchM7HIl9G10JOKFTk0H+oiKj4yB5y6FFer5e/rkXV+avi0Geso5axmfib3AQ0lfP72ZADQcCnfVg56PyUJv2nD/ta8JN1znSuGShKHnne8ybuCuv0dkKOaQF6A9Vu6nihzhN9SRvNtaqtg1iFocS3aZiUp+AY+pipzU3Uz+2vkZdNpTtEga6BIOQZFIZySnXYDl21RNAGEmh686lTOBCAvhx0sF5YgIpzKlezx9g1x2tBgz9IWgG+l3TK2d5ak= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(71200400001)(186003)(8676002)(2616005)(316002)(38100700002)(8936002)(26005)(53546011)(6512007)(6506007)(86362001)(91956017)(5660300002)(2906002)(38070700005)(478600001)(66556008)(64756008)(66476007)(66446008)(76116006)(54906003)(66946007)(6916009)(122000001)(4326008)(36756003)(33656002)(41300700001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6133 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 20b19723-8e92-43dd-cbf8-08da9fb724c8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A5pgx8u8D7kMHSO5i1RCim1yGXNURCVEifOgBjwUhlsnrI1/G9AKAEW34JvmwflhyQBsQy5yFv878ECt45AnYwp/kRriIgTkgAXF6x9DAn8y64N4LO/IDXsK1KX8Y4Hz7+KUMKpqKcgz0IGsZsRebpx268KWVQvR77q/NrCJLWnp9RMPYaamb/zRGReJwG2HRoo9fVrVQM0Eghc46sc4Y3MwtfjPvrqZFb7bSl4forHjubCaXbt0OfhRz2QjPJZpK26PDk2LWkP5n/tzavVJ2Ruz4lZHWspipAmPjlwsc4OU9eMkesNDIXQc6z4ymYwA72JHsQT1LgPwWhvPPvVVSAe2CpuyxedYwNJZmQ7darpv3H9sTDhXVU8Q85OMxAcjnYw+jrpoWeGQSJQkuJxrf64JDJT42eGUisxnKiTy0K11FCFIT5DNly5nIK1Fso5/DLZUk3wAvLzgMcX/7B/Fh7CQWanmD+sLjgPJ5+tOHSkXu/wAWZyeQYsEcZfvFMf1eN6oc2/YXIF0KsXEsps8X4ueQU+KxRpC43h5TafM8ZooTBofEie8dVJI3/F6QPd8k/za9BizwZjmFiuhMb/mMNlIjJbsA2WnrqA5xUM5dU32Pd4SKMi93TxMWs1fzOVKqHkot2ZwIqOUjQrN8wHnnBtNFlZrIz7+zzcedPEYQwQS+pJQXbj9JFtok5POWenAXKftSfWe3Rjf29sfFxYhfO4UoJ8V0/rRVPpa3DXVb3U14hQnsxiwRocRdQ0Uht0hHoKcjlZbY6jRQFPSQMV/Bw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(82740400003)(86362001)(81166007)(33656002)(36756003)(356005)(36860700001)(2906002)(336012)(186003)(2616005)(82310400005)(40460700003)(40480700001)(5660300002)(6512007)(478600001)(41300700001)(6486002)(6506007)(53546011)(107886003)(26005)(47076005)(54906003)(316002)(8676002)(4326008)(8936002)(6862004)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:03:44.3240 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2125490b-80a2-44ca-a62f-08da9fb72914 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9748 > On 26 Sep 2022, at 12:04, Michal Orzel wrote: >=20 > Currently, all the arm64 defconfig build jobs, regardless of the > container used, end up building Xen with the extra config options > specified in the main build script (e.g. CONFIG_EXPERT, > CONFIG_STATIC_MEMORY). Because these options are only needed for > specific test jobs, the current behavior of the CI is incorrect > as we add the extra options to all the defconfig builds. This means > that on arm64 there is not a single job performing proper defconfig build= . >=20 > To fix this issue, add custom build jobs each time there is a need for > building Xen with additional config options. Introduce EXTRA_XEN_CONFIG > variable to be used by these jobs to store the required options. This > variable will be then read by the main build script to modify the .config > file. This will also help users to understand what is needed to run speci= fic > test. >=20 > Signed-off-by: Michal Orzel > --- > This patch is supposed to be merged for 4.17. The release manager agreed > on that. >=20 > Changes in v2: > - replace [ with [[ to be consistent with other ifs in build script > --- Hi Michal, This looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:06:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:06:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411738.654776 (Exim 4.92) (envelope-from ) id 1ocmsk-0000IV-U8; Mon, 26 Sep 2022 12:06:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411738.654776; Mon, 26 Sep 2022 12:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmsk-0000IO-RY; Mon, 26 Sep 2022 12:06:42 +0000 Received: by outflank-mailman (input) for mailman id 411738; Mon, 26 Sep 2022 12:06:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmsj-0000II-RR for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:06:42 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad1f7393-3d93-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 14:06:39 +0200 (CEST) Received: from FR3P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::16) by PAXPR08MB6622.eurprd08.prod.outlook.com (2603:10a6:102:153::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:06:37 +0000 Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::76) by FR3P281CA0106.outlook.office365.com (2603:10a6:d10:a3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.14 via Frontend Transport; Mon, 26 Sep 2022 12:06:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:06:36 +0000 Received: ("Tessian outbound 8ec96648b960:v124"); Mon, 26 Sep 2022 12:06:36 +0000 Received: from 4879ed8f2f2e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 921D22AF-9D33-43C7-80B9-6BA8135D346D.1; Mon, 26 Sep 2022 12:06:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4879ed8f2f2e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:06:29 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by PAWPR08MB9447.eurprd08.prod.outlook.com (2603:10a6:102:2e5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:06:27 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 12:06:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad1f7393-3d93-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oORGdSySH9+twairRVwwGwD2AOIx6N1533QaaOuOukGjKbGObZr48Lx0ZCMLxdE3GuzjEV4R30JT6D9iM1qt3XJ2fZbRA7rWkPnaJBuyQVzgh+It1Rb/wsDuaegkWFQ4mes0mf9Y0FZq8e3IJcvyh7qqEMKMTJdpCTzDFX9toCpSamZXFZU2r5JzSV1B8w7eZoRVaTZDaCYFYgXDaECi4dYZHzYysncxO4DdkNTqxSoWr5J5VgdI9EVLH1Fm8eohBx+15s2SFREfxPE4hR7ThU4F/2pnM3zP7mBc5qaMNmSPeL4UMSKZEMpdJ+VI7TCfV2sQZE+1gnX4SKZ6AuhgsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWyUp9NBQRFH0tIBIClPXx/d6LVUNAPcafCedkiMilU=; b=QcEz/72aNvq00wpDbOvGAEdBN0s8fT2PCvz83dmEXv+5XuRJ5YzbGEYXmd4upejNdkzJstGpaHL61WKFYbsWhhYj1QUokfODNrJPT3PUJRNBnmrdFj2WZhXU1GGHyuQbtxoZTNpawM77d0QNcgUIO/vl5mGaDI11k2//kUdjKBT/lWupZAQqb6X08n/X7YM60DDPuXZrPtiXSPXk+KqJH0NP0zIHBRahfwJgLO8FZOUu9bAa62v64zCtKwetJy7CZH/HdrvF2JRb4akIV7lTM3aXjukUaNx2bBqQeW+5NvvIWRGW5gOpm0od/hH7ZppApICC7wDcg0juv3guAOaKBQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWyUp9NBQRFH0tIBIClPXx/d6LVUNAPcafCedkiMilU=; b=xrMFe7hx3OSdG2Z/MFrRjPs3aWtP3Q54XnCvgq6vXAFjOghuYpePZP9RmDVYD4Rh+dAjrWL4Jmm7N2YsudSzAhrzVULo3mrhNHvSjhIayiRv9HRSTquC+q8OpUXOk6yxYSiapBePSUWGnbgQyGpm2nZEK4CfVbJFKRJvZkV/aY0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 438ed99659add482 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YaOqkZsnn2V3Q7fa/z4yp0nMkIVWvlo8rIt4Ap8Ta0orD2BCwAK6kChGi8nTJ20p0G6AhWSnoUIKjbQi4HsUMDuGt6nzA2R5UQQotIFMAdrJd9hQlZVF77GoKGrzHu88cdwpG1u038wKhc/xhaUF9+GXHCWPDnPfw66e8H1JvfjSXdb2De4hBF9xklGPhT27djd0SWZ080bFHntR8r9S5sxBP8ELCdxLOL/yLoiLKbL3qlhxRcOOhtYJkv8IbF7xC7tixzF+vt34/DXYuqhJrZmUDv5smGT8poCty3/CxSRRDbYkOV9HlpO7HqQWdLpFgB6NS1d7IEsw8sjeETOwww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWyUp9NBQRFH0tIBIClPXx/d6LVUNAPcafCedkiMilU=; b=UeeruQY/uIBc9bi31GrC1FymcqxJZ6nX8Fjg3W3t2QRL4g7tm3oAqHxDSszPUyhakxfgQkBAjtXfmm59B9sw3fM6KGuMDsUkpyWOfhHSC082NnMGo/wdSxjhQzBmVvTK2IG1KGa5x6L34vhtBJOAtVlssKlVL1Vw0zKNQ3IwzvMMGpC3YG8PAFxIzfM4lZhzTD0QeT8QhhQZwV4aXeoa4ELHWdc/nknkb9MJN32jWAh3G92QzF6RTj7unQiNNL+Q3W3otcqomwjMPg4HHg1k9GXsnijboZZglwdRQlpDfV6lQP1QEAzeC/pfr6Kd00CBtuLiG+/tqZ7V1Gu4U66Xrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWyUp9NBQRFH0tIBIClPXx/d6LVUNAPcafCedkiMilU=; b=xrMFe7hx3OSdG2Z/MFrRjPs3aWtP3Q54XnCvgq6vXAFjOghuYpePZP9RmDVYD4Rh+dAjrWL4Jmm7N2YsudSzAhrzVULo3mrhNHvSjhIayiRv9HRSTquC+q8OpUXOk6yxYSiapBePSUWGnbgQyGpm2nZEK4CfVbJFKRJvZkV/aY0= From: Luca Fancellu To: Michal Orzel CC: Xen development discussion , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 04/10] automation: Add debug versions of Arm tests Thread-Topic: [PATCH v2 04/10] automation: Add debug versions of Arm tests Thread-Index: AQHY0ZfhXfy/h7Ly8UecudvuOTMapK3xnZ4A Date: Mon, 26 Sep 2022 12:06:27 +0000 Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-5-michal.orzel@amd.com> In-Reply-To: <20220926110423.26030-5-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|PAWPR08MB9447:EE_|VE1EUR03FT007:EE_|PAXPR08MB6622:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b75e358-1211-4212-bbd9-08da9fb78fec x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XJkQCcD1OTWMSn80mBwbckF5RR71tBcdoDPZylT0AxvfXxDBrAUoEgTPS1ibWW7ulqXll3/0orC+H8qWSRMXoz78QnbW7j0YSljTVtpzyljhg2qAqrkL2S59zV0tCLeTgJN6xgwNle3fG3w2uJaNHb1d4hov9vJso+1hYlm7mVoV9+hAw/yy8TRFDslFcKVWNc2Ps1Lo8SD/lny+WlMoch1tpKo9pKn3PLJ5srp3jq3dkY4V9mBXPk0mTjUvIXEYxFQKpjMjoRFxatrPAjrGcbRwA1/bQuGUQln//5tEWVNdBV5qttgIbiyDAv67xT68L4YhvjgXRtmubZ7Le4hOXYLP1lejVtbohcBPMHXl7iikmDoQCJqD+RGM/5Qf6BIs8Dn6su+QHyYYofpPL3FLIn/2WO0DsWzYcIYjs06Dz9VolRDyxHe9rSpbK0aZXTQULeQnRWk/uN4pbJ5i1IkoS8a6vmr9n/EhG9tg0W+ktnNYJMpYjsRThopCEpKUtzK/VdOBGzijhmtJQENS9pkqsp2jMHLhp4ZgQZR9TX6hcp/m/RULvSLi+Y+/96Dw5Wz4Pe+e1AjhZSqDtK5SPawTd76pgM9XEKQteDOd65qsvg9Ys8yfU/GamvpyYgTGI7QaMEct+JiW3HF4WbsPzJkEQKBNY3yF71DuaTcq6dlZz/FzTvb7G00Jo6gCH7uCnARfB+z2tsTHKiIjS0ALvtne9Qzq930FATHdUw0CACOed/mcFZ+lTtJN7cHXny99K0un3xXb3F/vGfbbgJQAbK7L9uDrbEd9FVg3GmtEsgNRA/c= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199015)(36756003)(33656002)(38070700005)(38100700002)(2906002)(122000001)(86362001)(4744005)(66946007)(5660300002)(66556008)(66446008)(66476007)(8936002)(8676002)(76116006)(4326008)(91956017)(64756008)(6512007)(54906003)(6916009)(316002)(26005)(478600001)(2616005)(53546011)(6506007)(186003)(71200400001)(41300700001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9447 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5ef3c019-882d-4637-b489-08da9fb78a62 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BlB78I8whZfZOmH/rPjbhV3dS0MIYhscEpimwbtaGqJFB3WAOEYW74Km+BeJyYRcAUX8AbXuQQghaIp4tv/iQQFNa3VcYyE3X+7xTxuAf7hNGjNfGSwhCfWhr8MAJAPNlExtU/BndFZS1HEIloKIlqb/5RbgcMOjBsTN6FnqDp1/a8FLr3vPpYewbi9/akN6yqTzY/9JhPyAeIIqZFLN+HzTRXl2XGBDaTeh/wSmYPhuLlCv8DnH+akakIDkxl2I26fQAo0p1T1bKfcN854MbmT41biUcA0x/UiIJ5pgfup5QFPGlzrjNIETB7JSa1Xy554oNlijp2N+CWC6t/6i/XWK9Tr9zun14/m1e6XwktkjpgP/MMxNa5+glL8RAfGIbByOZZ1zi8KvyEF8hcFizlZaP5wbUOk3WEcxP3z40L+31c9uu4+A3jY8n8uxACIMnLNy83za7bRfdlEMpOBbLBzW2UraHwpn2qRXYCCqsho5vr/uwgN+B2thdH4IMf1IEZanVYM212wjLc2wJMETLtHAPyIlMYU8bO2++ddk6q/svaVzxKGG0LpxEwO6yXtizMlXusYw2Coc25IBo7LnBTeaSnZ04g449tivlFiS2pSjJpqV2DLZexOB81qM9WkTv5L1BJf9Hz187uj9sNh7hX7l7x39XYIpnHKsKLOguqmnW73BzXqM9jMY2Y0M2lL2OOdM2VFqAfx4VXl97w6oatSts7z0R5GctcN+sUT2TNG/wroZ3sU7uvm67cDXjDRwNWYu9AlmDGFe/HxVOpY1Rw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(316002)(5660300002)(26005)(6512007)(70206006)(70586007)(478600001)(8676002)(6506007)(6862004)(8936002)(53546011)(41300700001)(6486002)(107886003)(4744005)(33656002)(40460700003)(82740400003)(2906002)(81166007)(356005)(47076005)(336012)(2616005)(186003)(54906003)(86362001)(36756003)(36860700001)(4326008)(82310400005)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:06:36.7711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b75e358-1211-4212-bbd9-08da9fb78fec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6622 > On 26 Sep 2022, at 12:04, Michal Orzel wrote: >=20 > At the moment, all the tests are executed on non-debug Xen builds. > To improve the coverage (e.g. we might catch some asserts), add new > test jobs using debug Xen builds. >=20 > Signed-off-by: Michal Orzel > --- > Changes in v2: > - carve out the RAM size change to a separate patch [v2 03/10] > --- Hi Michal, This looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:09:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:09:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411744.654786 (Exim 4.92) (envelope-from ) id 1ocmvo-0000tf-CP; Mon, 26 Sep 2022 12:09:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411744.654786; Mon, 26 Sep 2022 12:09:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmvo-0000tY-9c; Mon, 26 Sep 2022 12:09:52 +0000 Received: by outflank-mailman (input) for mailman id 411744; Mon, 26 Sep 2022 12:09:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmvn-0000tS-Ji for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:09:51 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150075.outbound.protection.outlook.com [40.107.15.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ee436e3-3d94-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 14:09:50 +0200 (CEST) Received: from AS9PR06CA0589.eurprd06.prod.outlook.com (2603:10a6:20b:486::27) by AM9PR08MB6257.eurprd08.prod.outlook.com (2603:10a6:20b:2d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:09:45 +0000 Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:486:cafe::3c) by AS9PR06CA0589.outlook.office365.com (2603:10a6:20b:486::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 12:09:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:09:44 +0000 Received: ("Tessian outbound ee41cdb23966:v124"); Mon, 26 Sep 2022 12:09:44 +0000 Received: from cad1c9f1bea6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52E1779D-C91D-459F-A12B-48B84F1C08CB.1; Mon, 26 Sep 2022 12:09:38 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cad1c9f1bea6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:09:38 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB9PR08MB6522.eurprd08.prod.outlook.com (2603:10a6:10:250::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:09:37 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 12:09:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ee436e3-3d94-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=H7gslB03J++KTUk5upAAmvZsVPQF861n+CmEBvMV/QAgzpE7lth3pkqnU/3wW2RfHDYzSf7TowOc+RvklTNXnwDkqh1qf5qvneSTUn8/hKQPLoIOGiRV9/tWyhBxJ8e+5vpcF/0i0I5rs+qkWuk0w5TsePKcdWJaB9fjmhQhbVvaMy+4jN+46WhteqHiN9GbmjefORQcOtILFNYlrIZmjTKgV8TOYeHOI7/DkFTfHtFW8uCKyJ0QYbKF0TtleqRgOY+FBcrQZnXzgwFNyokkBVNdtpRKFLkXq6VLiIH6NmQO6MEdjyMb6vhKHf9k6tA0clLJ+SEGco+bkn8WrWG0nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/wGHFrT9aA3vW2ycND7quldL++YUjWFbQ9rGp8dlFs=; b=nt8xr1r0OJOzuajs+Ga6WCh/1t/jbArReGkO3ir2Py9XpEPBszG3HmC2NyEIeUFifRpMlp6yNzDqS2cu6L+eGiJeLFzFPmI4R/6wHZGobMgdAwlGy8N0FoZ16BVF6zuzOlOpKECkFUfJBGVO7lf8fL7MKnr8h1s+GJEunTYxrnvLR0LKBS1xDwyYeSaTPT2//Zmgt+Gy3UJaGKmTfgUXYc+DudRMiIGZbiE92J+o0lMkXhZuoC6FkMF1Vf++tFG8SlpYDqsS0tJS6TMbyOJlGRyYAUHt5xUenHl74iKoMyP/FGIpeLLhk2Rsi+ylbBV9/yHorQ0OKhZPfuAKNluidg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/wGHFrT9aA3vW2ycND7quldL++YUjWFbQ9rGp8dlFs=; b=XItrGh0YjnVoZbHqbsU/55GkRi2mHL7wj9D9qX1SjPjbdEKjpo2+0k5z8zttKkOFEx0RlphF0yjOJNeScKJI5z1xkY6DjhC8ahaqhRXeiZXhZbkDMTdaAR4P/00gTGjakRDZdShcLLyV9JdwlIokQDOiyNTdl7C08147MCZPW/w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cc0f3583df04a715 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtKyfFDV2oLOdaZvpioRtAb2adYriIpzWFD8jPu4A6X7XJd9vI0T3N6flYWwjUreIZ/fzO/XASSRmFaHHW5Pppxr1Io6X6wEnjYgmnMEHRZ4tVKhADe13TEe/RhBILwXJD4qGClM4uKvB7AF4Aco3Ozx498/AhAaXJl4ttcF+Oi3gu5psX/g7U2XHDhumNkd9xJ85gD2JZgU1nsxSICd23jEaQGcqbV+g7obu++baoyFI2i3bxAlk0yCv4+3dN9Hf0Kkz3GVPHoGQR7MNqQxWcj5bdPxXyyD3oTuciOhpT/jYRAeVIzR96w38lGt/6HTNgLFxsENG2abCUraEYmIPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/wGHFrT9aA3vW2ycND7quldL++YUjWFbQ9rGp8dlFs=; b=AGEmJhPJAp2OcaZKiJhKv35QlRiv5fhhjOm5WdThO8I+Qx2iGTGj5Q01NHkzb9KqfUj03FCfezgAyGuMPlFsjlLUPt1fMTj8b5HW+qYr7uTwPsYDUmOdstp7+9EA5lhBnQTnbeZoUIzmIawaSrZAQ6ZaS/8zNy3O2xDLQcMQTaHVQ2Om71U5dxSJEbjJmiKImC37l8IlJulTofQhuYzDCEFrcLDD7VfkJrOcfESrrt/WUXWmzlveTiEE3wjnH64yR/HvS6BCGUIpJgl5W6O6j5+PutCnHAHETdbRZsnvUxhrdFEWew3ICDd5BdgJ4DdClIN4Qpc62xEet0D4SiQ7tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/wGHFrT9aA3vW2ycND7quldL++YUjWFbQ9rGp8dlFs=; b=XItrGh0YjnVoZbHqbsU/55GkRi2mHL7wj9D9qX1SjPjbdEKjpo2+0k5z8zttKkOFEx0RlphF0yjOJNeScKJI5z1xkY6DjhC8ahaqhRXeiZXhZbkDMTdaAR4P/00gTGjakRDZdShcLLyV9JdwlIokQDOiyNTdl7C08147MCZPW/w= From: Luca Fancellu To: Andrew Cooper CC: Xen-devel , Jan Beulich , =?iso-8859-1?Q?Marek_Marczykowski-G=F3recki?= , Henry Wang Subject: Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Topic: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Index: AQHY0ZgVj9mKo7NWfUiNnbEhwgR5qq3xnoAA Date: Mon, 26 Sep 2022 12:09:37 +0000 Message-ID: <6E84757B-2CE2-4C48-AA20-C5D172E4848A@arm.com> References: <20220926110547.21287-1-andrew.cooper3@citrix.com> In-Reply-To: <20220926110547.21287-1-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|DB9PR08MB6522:EE_|VE1EUR03FT014:EE_|AM9PR08MB6257:EE_ X-MS-Office365-Filtering-Correlation-Id: 02a38e15-5a60-4f1a-fb0b-08da9fb80007 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8KKHQMjliMdP+Ly1Fcy+m8mP8Ea3K1NH8Qt6tXbG+W4JAX29skk83ksqL0ku2l262xGNn0tHEbDS8j2YMAS3GMJPCG9bm3ypE3+pDqINNpY2qMLVrAbJqYu6XlSt9QlUdUNs8WtowrAg3K99Whda1fZKuh2fdxoVl5gflQCXtN+izXo1dRszee7+YANl+xcwgTI4j0psztdiuWR6Q98C5vJzQoRl2kkKg+mKndIzGivvkDWZPoU9gFsTeFBtQOcm5ZgoNqcpshM0ZfmzlC0oxxl9TqhM9afCaAXis54OnPSp43N6IEQEUbjOTmJ0673rZS8+zHSTxxJlUTudcOBGckdQob3G/I1382YDqepgctFpcKAYltpBVwNfFm/ipCxq0hv6Wg5xg17TOQnOa1DcRH7NSNe6eYUHkc//AqYFfvZj+2MJt5YFBbB5ik/iQJ8YxJmUiihyUxcVkazM8NH66ACDloBuFRBgi+sywxflbR9Ux4f5SgknTwTP4qCmWqxivjhWCVICluawctDLLPfbTKwL9wMHElJXg5GyGpUkcQVDG2hssxp0+aseps1dcHObMan/5nGdjAX2t9AEr1LASsUwz5sp43ceEDEAazM3oe1McCTAMDew8FQMV1AAQFR3X40ewgmHmknAVo7F1nSgv+aJ5KRJ13+1QrAn5fuk2nQWRM0YSyiut525j85PA4ZH14vN57HAhaSRbviPDht36FTS3hVduFhLOpVFQXMuG6QVJ2jFUIACT5C+1a4Bh/UtTZz8moFytbzr70g5JhHjR4EGNdP9Mi06wUMC3hodufa76diCWQy23UKPQBd1X04av52Bv3boV6KY3VkQYET2Vg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(451199015)(5660300002)(6506007)(53546011)(86362001)(41300700001)(66946007)(8936002)(4326008)(76116006)(91956017)(558084003)(2906002)(316002)(6916009)(54906003)(71200400001)(2616005)(26005)(6486002)(966005)(33656002)(478600001)(6512007)(186003)(122000001)(36756003)(83380400001)(38070700005)(38100700002)(66446008)(64756008)(66476007)(66556008)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <9D9B326813DEFE4D9DC81DB32D0CE8E1@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6522 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1d1cb659-fe54-4a70-0fa0-08da9fb7fb84 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8u6ip+sXds3Txz5bdSuZK2V9dQn7ZX5xLkQNo75Qe1yUApzI7toVwp/wIcMegIMnw2/zPfP51mfEDK6MiKV6oSuPt0XlhGl+prO4obS8RzFNAv5r02I1MTtXkAinTmzMIYDOTEFxv/d0S13Zht15jYJcpR0mpj5QicgOQHbcPiE7DF3PBkCb7g7a1W2Qg82yMI45sElgPXJbsZY+XKWzshdzwdx7csOpxNBRq3v5Ryx/zOUB+QdvBqKEG0So80LsNpFFlc/OO+7k6rmG0O6tyuYCvpt84BLZVwVfkeG3sCPUI8q02bz2gEYHe8PHaAstKinKk7mWxvrQMuyryiLdQKXpKvmeyWD0vOnWsVyWDHxCEmIlIMWdDjE2Gm1v3fxGebAwcZ7OPGkiIICzGqWi6mtQ2aVAConpy8sBiRijIbnRnxFWKONpZrX/7BwjgpCbgp5S/+fwp+afLYbqsMWrX5phPu9fexRLr3ajuL3oIh8FaUopt7cC4sKwUqnby/NF5Go2WtJjhiwJoeksZYKXfCcylhfZnzV7ftK8YXmDkjzAglz+oxft4jS4sCvx4aiNVSCi9kGcgAg/JAL5lXFQo4DYzOgQSrqKs2Fda5AZZz+fADNLL2s70y6rA+NjXnnztIukzylqJp9RRtT7feSObuZYsw5hv8AtR/JuHHvI/FsUliV6hzznyN8Iux5t7USshNggFCqQddwhDO7rIUoSpZRRiNj12HZETCyEHXiYaXv1EHeq9iD4nFpLnCKOKa/DvRW6wArqDxbNOrwQ0g5GvwF0ImMO601uoO5Kdm4X7Q8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(70586007)(70206006)(82740400003)(8936002)(6862004)(5660300002)(36756003)(40460700003)(33656002)(558084003)(86362001)(81166007)(2906002)(356005)(966005)(6506007)(53546011)(2616005)(336012)(6486002)(41300700001)(40480700001)(186003)(478600001)(82310400005)(26005)(83380400001)(8676002)(4326008)(316002)(36860700001)(54906003)(6512007)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:09:44.8574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02a38e15-5a60-4f1a-fb0b-08da9fb80007 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6257 > On 26 Sep 2022, at 12:05, Andrew Cooper wrote= : >=20 > https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 Is this link permanent? Otherwise I think we should put just the reason of = failure as commit message. Cheers, Luca From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:12:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:12:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411753.654798 (Exim 4.92) (envelope-from ) id 1ocmyk-0002MD-0X; Mon, 26 Sep 2022 12:12:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411753.654798; Mon, 26 Sep 2022 12:12:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmyj-0002M6-T7; Mon, 26 Sep 2022 12:12:53 +0000 Received: by outflank-mailman (input) for mailman id 411753; Mon, 26 Sep 2022 12:12:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocmyi-0002Lt-KN for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:12:52 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b0f7c09-3d94-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 14:12:51 +0200 (CEST) Received: from DB6PR0601CA0044.eurprd06.prod.outlook.com (2603:10a6:4:17::30) by AM9PR08MB6257.eurprd08.prod.outlook.com (2603:10a6:20b:2d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:12:43 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:17:cafe::8) by DB6PR0601CA0044.outlook.office365.com (2603:10a6:4:17::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 12:12:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 12:12:42 +0000 Received: ("Tessian outbound ee41cdb23966:v124"); Mon, 26 Sep 2022 12:12:42 +0000 Received: from 46e3470fa324.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9646A717-E492-4F38-9194-E183D423BD61.1; Mon, 26 Sep 2022 12:12:31 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 46e3470fa324.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Sep 2022 12:12:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB8201.eurprd08.prod.outlook.com (2603:10a6:10:39c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 12:12:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 12:12:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b0f7c09-3d94-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y+fMK/uOBNje0gfOClfLMq9uN2VAdgXkq1Oj20JjpCpRc2kAuuNmc1Sn84Ob5JElSb7AfmCDct32IRgEJsyJ6UWh6JUkO8LJSE/Ee98OMR+RJplGQHVr/+aC4ZH75OzDioMMjwqVzY9k94VPWmuNlR62vxIDFa/oQO2P0bpH4FFY40srLkmCur0vhskN2mNfw3TH99/ZLO+8jVt//7ADQ2gzhGZqKTfAI7Dl7rz1IPQRQjO8hWV6LrFpjZ5FcIZrk8Z2HxYu1bH86LYhLHjZBCNGnKLz00JTSMfdlaRY+zfnhfyzdrr9DJjUs1yH0QPf0PvLQ86Y0NRanYvyZnYQxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pu7NPzDEEYinXa/mgVb2p4/OWTKtJG28ZFAZmKmc0Po=; b=EKYSA6+4I7ni2Cy7wrMlOJK0aYCD1vu5vXa+qWJqnF/q4aSYLVptpMRDcpFNKwqCjgQtaPWv6jmSKJaOTPNNKi9mgmzK1zJw+4qGw6Vu4VJPBwbNqyzvUazqXxZ26tdxr3TDnxU+RBCO08Bm+lhz1Vd7Cg5BJOz6ECuDKBb5T1qopuWXMpaJf/OPdf3CKAvt8A8Bwy1sTTBHeUzXbCSvkDtx1VO7ypnLXn7B/xwceqhRmVR7Llgf5UBt2/vhysu45rPjhGq+xyjFIWKlqx5UFNfwbT2rcyfdy9agVHOgTbMsoWkV7Dm4V0AjzUjAK42KovajRjBMZtOqTc0cuhn12g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pu7NPzDEEYinXa/mgVb2p4/OWTKtJG28ZFAZmKmc0Po=; b=TDg4gcjxxkj8ZRrW5boWmuZCUL3E6u0PdXb/YDmNJ7dNGAGNJNu3zjgN+aF9CoY3ecX805BWife3V8+sU2TEhK4q3FmdWBpHKHtVFYPFpzG1DyTdtsFByhR4qMuxlMoNM8AiuAfKbfx95IkiMCOkWbSSWSqJJWUWMwzcrxIyXtc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6a02ecd64d728cc1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k+C9xe+8ITUA2c6TgQj7/m7Yzng6ugWlTF/z3+kph4zWSMfvdGBWiUwzmwWY3Vfu5c3gKWB4C6JLFZgtNcn9b5Ka0XWLBrHvDzqsFWcZIwcJRCLiSqwfD38LXy/dEYDbDho4avPgRO5WiMA7vQub4cfriQmrqkxBpiV7oz05oYBlYRHCQ9gpHiqbnV46NNI3nwNVF5s/nSUGnyzANW4GG22Viv/RqJO6iKrHSsHrp2LjmG2E2Wad3OZrAdgfjtmDOotN6tHLoIx9NAtzQa20o0bLFdMuptJVB8K2BZJp3Dsft94hqnwcJqkjZewdRgBEpE47VVsfA+adkzElfg0/kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pu7NPzDEEYinXa/mgVb2p4/OWTKtJG28ZFAZmKmc0Po=; b=bfzaUn7DbIKEZqNegiurkgmTuXQyytLV4c5oPxOzxdk+hYPRjKF9ukLX/1Ruyi00+vxseotfeQQLUwKHYfyDOfjblDA5Ru2U+DwXsXFtw+1Ee665DG+JaVBpBEuWPBHa9EBKphJNtzY4lGaJggFSoHr/I2M4NTI8KnDj6CFhl2pOXIGiyd38DrOoTVF2JG43rsJAGMllTDg1UoFCHoe/b5O8B5uds8oktrQoucCbe8ARjsRdwqlzJN6Ztsk/+IJHtA9LFoKmj4KaSi06Jg+1IShn3PBDlJDj7rHhx/nOjJwGoPbXJUhh6eUM0NAJZ3gStCr1rtxeTOCQHyDnIvnbUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pu7NPzDEEYinXa/mgVb2p4/OWTKtJG28ZFAZmKmc0Po=; b=TDg4gcjxxkj8ZRrW5boWmuZCUL3E6u0PdXb/YDmNJ7dNGAGNJNu3zjgN+aF9CoY3ecX805BWife3V8+sU2TEhK4q3FmdWBpHKHtVFYPFpzG1DyTdtsFByhR4qMuxlMoNM8AiuAfKbfx95IkiMCOkWbSSWSqJJWUWMwzcrxIyXtc= From: Bertrand Marquis To: Rahul Singh CC: Xen developer discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Henry Wang Subject: Re: [PATCH 0/2] xen/arm: static event channel Thread-Topic: [PATCH 0/2] xen/arm: static event channel Thread-Index: AQHYzzv/z5KfzY5FpEi922tCq9+On63xpAUA Date: Mon, 26 Sep 2022 12:12:28 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB8201:EE_|DBAEUR03FT038:EE_|AM9PR08MB6257:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d8fdf44-b63c-4274-b495-08da9fb86a1c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +LRUQ/RNpH1AkGsPwKdsMqGRAHNDqLNe+1q6ZBfIBtt84grUrpzfN5Mij0JeYbTo1vXnHbmBnwXyWhKICQ3ugeEfV70VTK31piSf/48RcTl+cCWxDydSdyCVKg5Nm5D+IvEcFBMehVgTqr/qKLcxqI9BWiBvq7jH5Z1050MKvb6k4twn7sO06B/MhSX/WP9BKuGCBL/y7u/l54EJuJmXT+HeLuLnW2KhOyaYZ4lGLbHM3IRL1lTez4sBW+rrwaefJtTEfGkqB3Uu2YKddDjMX6TUDXJfY15d1ZNSlEWAwDAB6GRUDXV1VMv846nneDS1+F66TWwdWhECy588q1VTBLZfRDcY+yBQ/z5HhEIsrn4oO2agTIwvSN6YLq8u9h7ge7EBm9BHVATb++PbaEYo3XYXxS6HRUAREl3BXulqG9t6XVlwzTr8tFbBRUEG3Ar4085yfO2xkmx7KyT6G9NvIXrKiWH2HG+H/41Irl+ycUHRg6t0xueQmdrxrJCvlPB5ZYgxQrWU3EHphTrla+YFUHc/hxmEbiBpjR3y+ZKD1yPc0t7Ppj15LziXo00rgqIl14AlbsqcxnKQmfRcGjyq2zuNzyuuoZRN8NLlXYm0E4Le6C9QTnll9+eUsE5GhVlINhNmeYyiPFEiEUiZg4VVLG/ySol8eLzgz8iOmDSABBWGROr6fFprH3Kn7bdYDxXfRJVEoRyBzl9w/ZYNTpZ097kuz5XTgaz/dQxdxGMOGt1EE+M0N2vYTYRUhptJ9F3sS4M/33KXkCzUha9uqjIEGAh+eLakyGkC3AVXkhf3Tq4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199015)(33656002)(478600001)(6486002)(36756003)(83380400001)(122000001)(2616005)(186003)(5660300002)(86362001)(38070700005)(38100700002)(26005)(41300700001)(71200400001)(6506007)(6512007)(6636002)(316002)(53546011)(37006003)(54906003)(6862004)(66446008)(8676002)(4326008)(76116006)(4744005)(66556008)(66946007)(66476007)(64756008)(2906002)(91956017)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <99049ABD367CDC4CBF25FA76348B4BB2@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8201 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bea426ba-0ff2-4f18-58c7-08da9fb861bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A+0oqQNN6W8cQOKj1PlR68DzhkjzFdr6v1EywHNtAbP0AsXPZt7T81JBaO+NmswAK7OasdVAi0EfwLz9x29nAlck3pHqYCR8i4ZlR2NNMUgbCiJVBE0Gky0mo27gZk02OYZrQl6xPhjoBhYx+YFYlPyuSBzVAIknjUd2S6uPa5Cm7OGd7CW5DI6Du/Fc14XXYiBkFXQyR7vwOO3BUEzV0Jh8mNUm0cz9KwotKjJNU+gdXifQqbqI88mkNBT/x5ax661NVJfv762t8/pdHUrLhHIMUh9wbAXN8P+eCRPgL55S6ELYJVTK5iF34RBziT4jR4qKFwptW9B4sdYH+JXDw2R7fQlhuq9gfOJnu/vxZ/cuxdZCvceHUo/A7HQDPxVg+zU/5/XAhmSqRI5Kgwskv3pJh25V6JNOSeNJCepzARxbszHWb6zeHxS7EmQCq79PVu3FK32uylOthjV2p/mRsLQAyoyHUENwGZmLf86fl5p9KpsuVsvwUvjc+21sRJCb/feCKasLavt/cj/Ceb6nzBGWTveecJ/7ZB843eoVOLJ/S98N+0IKFZXNYiPMVRlom0vUQmL4tkS47O4f+a0uDq7YCgJuC3yaMS9wxWlxELhSCkbhN5mbQJiCcHyOIta0jwM1xF8cwqP8+9iWDyjWJjDHhIOZ6g8TBe2sCgQ5XeMa95HapugLm83bO8GBHbZ5bFzvF4BPaLvmK8S3CE4cOLUZ6F8dA+zEgWrADLsPgLN+uDyfwC9zPowB5zlUbPSoDkfsUYaDaYK1FdZPdbnqBg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(4744005)(70586007)(70206006)(82740400003)(8936002)(6862004)(5660300002)(36756003)(40460700003)(33656002)(86362001)(81166007)(2906002)(356005)(6506007)(53546011)(2616005)(6636002)(336012)(6486002)(41300700001)(40480700001)(186003)(478600001)(82310400005)(26005)(83380400001)(8676002)(4326008)(316002)(36860700001)(37006003)(54906003)(6512007)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:12:42.9255 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d8fdf44-b63c-4274-b495-08da9fb86a1c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6257 Hi Rahul, Please give the necessary justification for inclusion in 4.17: - severity of the bug fixed - probability and impact of potential issues that the patch could add. thanks Bertrand > On 23 Sep 2022, at 13:02, Rahul Singh wrote: >=20 > This patch series fix issues related to static event channel series. >=20 > Rahul Singh (2): > xen: Add static event channel in SUPPORT.md on ARM > xen/arm: fix booting ACPI based system after static evtchn series >=20 > SUPPORT.md | 7 +++++++ > xen/arch/arm/setup.c | 5 +++-- > 2 files changed, 10 insertions(+), 2 deletions(-) >=20 > --=20 > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:22:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:22:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411761.654809 (Exim 4.92) (envelope-from ) id 1ocn7y-0003sW-SD; Mon, 26 Sep 2022 12:22:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411761.654809; Mon, 26 Sep 2022 12:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocn7y-0003sP-PL; Mon, 26 Sep 2022 12:22:26 +0000 Received: by outflank-mailman (input) for mailman id 411761; Mon, 26 Sep 2022 12:22:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocn7w-0003sJ-Uh for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:22:25 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfb3a65c-3d95-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 14:22:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7824.eurprd04.prod.outlook.com (2603:10a6:102:cd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:22:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 12:22:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfb3a65c-3d95-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MKqMYz4mbe2rPfLpFuX65uIFMHcbnnmtwdfP6SGdRuI0V00IChK00rv7EQmYP0q87RPWV5mrbzvYgCoky8JUzEyNwhxi0AdaXQHnLp9i/Y7ppvQabQveiDcMoiU36LUDDKCEaUF49LOsq1JMRZbQSKt9Z5fxfy2oix/Sw+qdCNy4Fq89NOXZgKc7GwmQ6aCjXpofzcDWA3GFC/rKt2HhyTFrsJAApZbSpaP4+LB7KJazgWLg0dwO+quT4EBrkv6s3bUAAsFOjqLe5ZNPwstB/JLUIrGYaXm+uo1L8Pi0+TkqMsAUqA8lIja4iwclXF+DuKng8oUc/rTEkfrsv5tz6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yNifXSZfcJy6HhuQWlAFfZBqNhPJYZnfAF6RhQX7XHQ=; b=gSXQNt3OzpxYk6LuSWaFL/5I8kfPAq1tzsZjfaecf+UROtIdCMJ1U7Smm8mTjmjkCKm33W5uBfbhBdIoQQ6z/4jPjcumdwAMOI+yh72VUWlbgsjvsqxg3seBxIXsDyN4IEoteBHQLjhkzlBV4u9DOqg03cDLCHtsSQa6WchsNLWDP5otw+nsmVUs0tJ6bmwBRvrQY8EB2SZIBuyOf5k64vJGtdOz4iKBVaqUjfVDRJLHVmQLctxxi0CmL4m5uy/mrwDp9aPkVP4EA5Pn7wVdeeoY2PoJPtL2+chcHYPcMT8mTp3TUyiOb8TSS7bSsQYKNxS+6UtrMkUnMRmT2Kwiug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yNifXSZfcJy6HhuQWlAFfZBqNhPJYZnfAF6RhQX7XHQ=; b=EEEs2fZbvDLe2vfJZpo9SCus2jG/7fcDYkcdLlJMhlmyfpn8cQB7ktzXwkkguHpigdePIU3MKdWCiy0O6bjXwzvuvQgHhx8MeTgFBlozO7OsvJHTQnf0RTNk/pdqMpDMkan2je0ujZxWtjnn/IeH5QNq6if1682e8M42fu1XSdB5eixr0gdea9QV6GARlQmnIJgEiSUQ4Ca36dC6XsghStSdlV8F5+x0ry0/oVIHykGOoXVJOYfNdP08uX53omcHgRoRQciLMEfT6lmKyiXR5jarY2C12WoB26xqUDolMYNXFRNraEkGeeSkoTMDVsf0ngZatYLC+z1MYG4z+ST58w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 14:22:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Henry Wang , Xen-devel References: <20220926110547.21287-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220926110547.21287-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7824:EE_ X-MS-Office365-Filtering-Correlation-Id: d1b4c070-ceaf-41f0-8474-08da9fb9c2bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FoOmT6Ih1dK9HwnPjJrTkkQln8QxgatyJItJOnHPBwrIp2sV97Mn8x0fjEaV/0KHZgCPiP8ZXvejIyEDqxnY9zdhR629pB9VCyQgow5FM+rv/kXFPN3iCABs2DTyREKwfcwt/waNdXLyboDbQiX0X27RfqLXeNkXXf6AfemWhDvUpngBUdQM6kbFTc6yVAxrwjKMgMnR65K9eCpzVWioNaOzU5ItNSkV4vJ+GwYYwRcUeiZ3ybBL+dKvthNjj3Y5m5V42lQDmQGIVD/6h79/rQ1NDMIUnYsHRzCCyNjiYV2O2UGb1KwcGkRWBXYDbxqp9wT8VMYu12MiphAy0J6WKj37nfnyJX+MnaSVkJ0dq8P+k9yBaNARXnIwZrjzPYvjdE+2alLvs3ogT725CBEGNkDV0k1Xus6z2ladQsrW6mJyutPzwGrG/YF+lqruz5u3GKLTrCyWzH6hIEwInOlFTM3ORfQ+nFZ20tunHA8MjnCZ4wtZiG8VrvX27sQET71rkmC9Jo4jh9bqzQ4apvBH9B53m3Uack2ljfNn1ao8ZCMDnTavIpXz+h6OTQbYHML1cSmF3n+C/KdxHQLjYRSdgY841SDHRTgCDCxF70UpNz0gx5gBfn781C6655ZEUdcSrCVKMEOR9aWrj1TpQUzqSsICiqo+w/NklDq6mTAyEq5gzLX75RHzvnUchVyosyVqAnabqqlIkd8mioUskevM67T4yrcDpG6SKc/u8OyohBzqQGPX80zjeNvrGwIQakBtfIcIgpZuXsacs+yv5kd29+op/k9/eqppwDVZCA0ZHc1RKwJr2MEMSd4SFkDtXQ6yUEne2hAk7vu3RJPi+qlA9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(136003)(366004)(396003)(451199015)(4326008)(5660300002)(966005)(478600001)(31696002)(8676002)(86362001)(6486002)(66476007)(66946007)(36756003)(66556008)(41300700001)(316002)(4744005)(54906003)(6916009)(8936002)(38100700002)(186003)(2616005)(53546011)(6506007)(26005)(6512007)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OURzbngrS28xTGF2Y2o0NkhnZkN0UU9TeFRwNkRRWnRkU1lzMFlicGMxbGNh?= =?utf-8?B?Sm1pandJOFJadzc1ZnJYVzFLcFhvMEdJeFNVaTB3c1EzbC9nUDhlaEFYVU0w?= =?utf-8?B?YzdEQ3FoRE9ZRU5WY2Mza3BHUVlUNU90eDdxN3RyYWhCMzV6ZG5RUVE4RnJ4?= =?utf-8?B?SlhDNklTV0Q1NFk2UGVsRXdPenNhbzF4dDVCY2hFMy9pRGxLWlZOODM0WTB0?= =?utf-8?B?dklzVkdjMHRCbW9kYytGRzJ4c0tmOUNnT0o1bmxBZCtteXp3N3hVR3ZVUS9F?= =?utf-8?B?dWpaK1JGMHVtS1JkekUrRThDaytla0hrWWRCcVpITHJFNVBpNmNFN3dUZVNS?= =?utf-8?B?VUxMMGx6dXZRSGNvQlFobXVkYUFQcTFiQ3JvYXRkMW5GWE9oU3JjZElUU2FX?= =?utf-8?B?bjFWNTZMcEkzS21BdVVReW8xSVliMFpVdHRZSHZRWVhyc3lzSGFyeHByNmM4?= =?utf-8?B?b2Vlamxxc3RwRThtNU9zVjhnVWVnOWR5SmVpSUZNZ08rWlNrQ0JUV3htNHhm?= =?utf-8?B?TVQ3d0dlL1c4bGZXK0Y2VFltWEZNa3dlNlNlTEdQbHpvQlR4Y0xuWW1xQnFs?= =?utf-8?B?Y1ExRVhYNlI2TTd4UEJjWjg3MkJLQWRVdU9NQ0w3Q2k0bWFEUERncHUwdFVh?= =?utf-8?B?SmJmNDNXQ2YrUDAzYjFTUWtPd3F3bUdSSVl4Q3oxZWhjV0J0cHljVVIxZE0w?= =?utf-8?B?ZlBWY1lmYW54Q0hRUm54aUNhRDFuSTNuRG41K25IbkR1ZnJtWUJCVHNqb25s?= =?utf-8?B?WGZHZ01nZ1NxQnZDS2F5WmpKT1l1NGhva0VUdWVVZTZ1bWJPNUNDaUJLN3hD?= =?utf-8?B?R0xNRWN2RmNQMnRBRC9KazdUODZkOU83MFliREhuRXIxNldLb3RPbVM1b0Q4?= =?utf-8?B?S0VVOEJTeGV3Z2tlSjFaZ1dLbi9OekJ6OWl1ZHBDbGlmTlVXOG9LTDhYQ3pJ?= =?utf-8?B?OG1CWEtHMDA5Y3N0RmRUL3VOc2czSXVDZ0Z3cWxsakdlZ2FuQldxK1hNM0h0?= =?utf-8?B?elNUTi9Pa3VBNkZLdjFHcXk5TEhhMDVweERwd0l5VzdNdjlFK3BHdytucjlu?= =?utf-8?B?QXkwMDZWcmdhSzk0M0k4NjI5WXROSHBzQjR5cmpQSnEvQS9iKzdpN1RZNTJz?= =?utf-8?B?Q2tibXNiUHl6STVKbmtaN0kyRnBDMEJONVVuMlV1V2NGY2p0bG10YnRLNm9m?= =?utf-8?B?K2I4SmY4VjBKTC83TzRDd1hTNng5UTZZdlBKSTQ3TFVaRWR3Sk45SVJyWXNZ?= =?utf-8?B?bksxVkw5ZjBKdm5qVGxBK2FRUTI3bEVoM1RIVTBQbzY1Ymd0YzBPeC9nT0dC?= =?utf-8?B?MWkwSngxYldCR25PYWpuU1FYMTZYWmlMWjNHbkNMdWQwMzIrYmFvZGRueElM?= =?utf-8?B?bEVTMU9tV1FCUHMraG5wNHRmbzFCcDcwc2FOTWMyL3ZheHNnUGZKK2VYOE5K?= =?utf-8?B?clhJVnpRZGtTNllSNTZKR2pEMWFNZnBvcUNnVjRJTklMTzVwRWlxNFBFK1g0?= =?utf-8?B?NTJDbnNoNDhUMjlabDVINjdVbStIblZrMXNDSEhDRHpidk9PTlRneldnSVMv?= =?utf-8?B?dW9DL1Q2NEc5dlk4N2Z5NHpQb1lTMjE0a2R1a2NzT1duM0ZzY25wQm8xZTNa?= =?utf-8?B?eFF5UTVmRFZFNzcyQ3g4U1lXNjV1MklPTURyOFl5NlpnSnNmU3FiMEVibENO?= =?utf-8?B?anZad0RwZkZpRjc4Q2hjeHFxSWpYRE5zN01jWEo1YWVnY1VnUVN2S0g0cWJ5?= =?utf-8?B?WE9ZZ05xZGFvcmFpUFlLcVF6YllMbTdyamY5RytkMENyVHpiTExUZUk0T1li?= =?utf-8?B?Rk5mQWozOUE1MzVwNzRGM2t4MkorOHZHZGtmelc1MjFyaWk3dDAraEFrWGl6?= =?utf-8?B?OWtUOUVaMi85WDN2NWNTY0Y1TE1hNEpnbmpyUFRHb0NhUHdsWjFqNE1SVnJa?= =?utf-8?B?TTBRUnFyb3BXWFcvb2VTWXRqbXB3ZHQxa2hGWE1pcm01QjNyaFJXWUQ4ei9G?= =?utf-8?B?KzkyckpVRHRlbE8zYUx3alFrQjQxcVJOSTV4c0tNeTFUdHVRemx2ZFRsRG5u?= =?utf-8?B?c25raGhSOFNnaFhvMTZEOUZzdnEvNlN5MGQ4ZjlyNWJqMFZqSDVITUZ5b2cr?= =?utf-8?Q?vfxt3YTqEhMmkfkQkKEOjM71U?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1b4c070-ceaf-41f0-8474-08da9fb9c2bb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:22:21.2744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +9vHArCayhMvqubBKgjW+CJZjRRFjJwWbBjt3T/hMkma+MSKhu4B40aIL1+MRz6OM4UNXZdfDCOzaRkIrPMkfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7824 On 26.09.2022 13:05, Andrew Cooper wrote: > https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 > > Signed-off-by: Andrew Cooper > Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and dbgp=ehci") Reviewed-by: Jan Beulich I'm sorry for having missed this during review - we were well aware this is likely to be happening (and I'm quite certain it'll happen again). Any news on the status of the compiler side patch? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:43:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:43:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411768.654820 (Exim 4.92) (envelope-from ) id 1ocnSH-0006Me-Iy; Mon, 26 Sep 2022 12:43:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411768.654820; Mon, 26 Sep 2022 12:43:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnSH-0006MX-GD; Mon, 26 Sep 2022 12:43:25 +0000 Received: by outflank-mailman (input) for mailman id 411768; Mon, 26 Sep 2022 12:43:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnSG-0006MR-OY for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:43:25 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cdbc55b3-3d98-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 14:43:22 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 10D375C015E; Mon, 26 Sep 2022 08:43:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Sep 2022 08:43:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 08:43:19 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdbc55b3-3d98-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664196201; x= 1664282601; bh=KIR5QYmEwy2lMpE/E+p51faebZ9xP7wCKJJXb56V4n0=; b=j whfoUwcIlpgg5BPeu2tEd7tFzXwRnyvji8IAerC7nQOMQjOtmvMIW/xwIMt6JNlZ 8HUstie9biBiBJxOoYBy4kuTFpaZRwVZ5fqNG/V2GAQZMcRSg0aHqjE72S3DAahn lrEHsA/YV1zI4sMikOOiI1Ce0p3FI3PDUmAQoC7BFQ2w6WEHhK28KnvufW0UxImE w+us0xLE77APDL7HTODvOcLqq33hXfH7G9KAI04pxdvDOCStyesI4fOEwA4b0VUa EEg5+u6rofGOhQVVijRpSOgrzlbV6YvIs0YbjHOf/L5TRzhz3OW63j5Wuj4+DhCk WoSSgZdTVLM2U6z26s2GQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664196201; x=1664282601; bh=KIR5QYmEwy2lMpE/E+p51faebZ9x P7wCKJJXb56V4n0=; b=MtSZBYNvUP090PlxGQQJRrAhvr3YMAr8X0ahl7BKwL26 Rmu2hTQatf/E75SiBK0cFfg3kXqwCeg6IHrwFF0u6JvjX2MVxcnpMsktL6xe7B3U rf5lYI8m7AjO/qOg3FK5nVkznzbGDgoqCvV26KJ4+T1kpAEceim7S+NjPRpfpWxj 4Cv3yuRBcLUterxqU2jMJK/RENcOhVyFuMgYxm56qxHCrEWxhXl7SsLqDjduA4qa D2aWa9ccvVudD3555ksskwQm+JADHx4flkEYzKI416vga5OSQxDG0EWchHdQsIe1 ABATKVIMxoaL60ZMWkOAJm+R7svI8m6XtQpvg1l+Zg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegvddgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 26 Sep 2022 14:43:15 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, George Dunlap , Roger Pau =?utf-8?B?TW9ubsOp?= , Anthony PERARD Subject: Re: Design session "MSI-X support with Linux stubdomain" notes Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tblz3W1c0w5A16Ov" Content-Disposition: inline In-Reply-To: --tblz3W1c0w5A16Ov Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 26 Sep 2022 14:43:15 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, George Dunlap , Roger Pau =?utf-8?B?TW9ubsOp?= , Anthony PERARD Subject: Re: Design session "MSI-X support with Linux stubdomain" notes On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: > On 22.09.2022 18:05, Anthony PERARD wrote: > > WARNING: Notes missing at the beginning of the meeting. > >=20 > > session description: > >> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn= =E2=80=99t > >> support MSI-X. For the device to (partially) work, Qemu needs a patch = masking > >> MSI-X from the PCI config space. Some drivers are not happy about that= , which > >> is understandable (device natively supports MSI-X, so fallback path are > >> rarely tested). > >> > >> This is mostly (?) about qemu accessing /dev/mem directly (here: > >> https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) - l= ets > >> discuss alternative interface that stubdomain could use. > >=20 > >=20 > >=20 > > when qemu forward interrupt, > > for correct mask bit, it read physical mask bit. > > an hypercall would make sense. > > -> benefit, mask bit in hardware will be what hypervisor desire, an= d device model desire. > > from guest point of view, interrupt should be unmask. > >=20 > > interrupt request are first forwarded to qemu, so xen have to do some p= ost processing once request comes back from qemu. > > it's weird.. > >=20 > > someone should have a look, and rationalize this weird path. > >=20 > > Xen tries to not forward everything to qemu. > >=20 > > why don't we do that in xen. > > there's already code in xen for that. >=20 > So what I didn't pay enough attention to when talking was that the > completion logic in Xen is for writes only. Maybe something similar > can be had for reads as well, but that's to be checked ... I spent some time trying to follow that part of qemu, and I think it reads vector control only on the write path, to keep some bits unchanged, and also detect whether Xen masked it behind qemu's back. My understanding is, since 484d7c852e "x86/MSI-X: track host and guest mask-all requests separately" it is unnecessary, because Xen will remember guest's intention, so qemu can simply use its own internal state and act on that (guest writes will go through qemu, so it should have up to date view from guest's point of view). As for PBA access, it is read by qemu only to pass it to the guest. I'm not sure whether qemu should use hypercall to retrieve it, or maybe Xen should fixup value itself on the read path. I did some preliminary patch here: https://github.com/marmarek/qubes-vmm-xen-stubdom-linux/commit/80cf769f3659= aa0d7f2b5598bf862d83da28807e but it does not work yet. It seems I haven't undo MSI-X hiding enough (lspci inside the guest doesn't report MSI-X at all). This I will figure out, but I'd appreciate comments about how to handle PBA best. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --tblz3W1c0w5A16Ov Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMxnmQACgkQ24/THMrX 1yzJJgf/a8eiO9zWA4rh/jv88D6INjYJb0prUTxlHbKyaxsw2iAE6YNkHNZE6atQ wnVbW2r+PAPVH6DUC8NeIYPG1p0UpXHrayOddtqfd0GqPTxpMMFG9B3zLGgUnA6k 1h9aaC7mD1vg60t9V1nbNJUfklogEoR+TsI+O3xWafMiRQQDV2rgmtLq3HsFwkpX zSEh1d5cIpdz7+gFojgNC9t7iTYuTmDrUfjGiH704boBN6Px6xh4LLooXY/YjOIy UvscA2ymOdJdB/d8usiBIOxUIsys0olk/2yIPQc/EFiGuY6rISvf7PTD5zq0/sDj nfWsMRIimtTPr+Q2s0735yo/uLASdg== =fXUO -----END PGP SIGNATURE----- --tblz3W1c0w5A16Ov-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 12:48:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 12:48:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411777.654831 (Exim 4.92) (envelope-from ) id 1ocnWl-00077A-9Q; Mon, 26 Sep 2022 12:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411777.654831; Mon, 26 Sep 2022 12:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnWl-000773-4f; Mon, 26 Sep 2022 12:48:03 +0000 Received: by outflank-mailman (input) for mailman id 411777; Mon, 26 Sep 2022 12:48:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnWj-00076x-Dr for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 12:48:01 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20081.outbound.protection.outlook.com [40.107.2.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73b4e7ee-3d99-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 14:48:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6958.eurprd04.prod.outlook.com (2603:10a6:803:137::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.22; Mon, 26 Sep 2022 12:47:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 12:47:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73b4e7ee-3d99-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5sXKifrxpHMkM5kfoM4P+ZyUy7zlcWqatMU27lszJ7xFghUQRMGqVZljxpaAm+DzEWrik+izXHcT0e9vzVjbKbMAC8FMD45l23fySrf/SH00mncrJfd8D7WEy5TcAtHQnlJ8u5sk0gE+CWY/CpYqSiTJ5wiNcJEJxVkHgY5GXkRy62TkrB/O8FSjgmOcLY/qwlyflxco34COcp0bTLlB4Xzo3GhSn9BZSFDDkV0czqAAl5DIXAtnQDqdxkf+OqEhOrJk0jNXs2lVw329f09xZdad/TeB/a4Mu+cuKNSy8sVHWyxpOLHGpmv6RJOhmuTyrvXsQoDdusejGGgG64kXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GF5cs8X+2vlzNrJM/nI/jpzWosjyRdbH7wYIscY976g=; b=IH/LYZi79tHo9x7OM5U5E2MQjSfqcSm6g/WbqsnEEla3AZpkc6EwyEdEA1uO48DegxHjZATFE6RPiFTUwfgTLVaLlNw4YLbaZa9U4LDt0TXXKflwNZ51reX2YBnamBt8iciyDL5D2KsaCB7uTb+WnmlDIPwZJfPkmS5JNTXKKeK0dxTFzCN0xdwCUGZS8P1ZxBtd3Ob59qKNr3Qu9BOUbIere3t5BgcTAxLODDm1sTKsjFN0bk+X0/zM1p7vMp6E2FJjNa5n/o6PZM3bOM0XXgFyeIVINvQCF+rmMwqCfgjG8CtmLTuzCTE2+vGz0vhOTExOB+4HqP6VxteWBE4E7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GF5cs8X+2vlzNrJM/nI/jpzWosjyRdbH7wYIscY976g=; b=I8KQzNW1SsD0oc5/Tt9nYBSEmzUNxaQ4b40F2pS+aahyj8fSSicjdeV+iE33SdCqQim4+qKF2U/OO1hVCiXXngfpwHYdeisOOyy7sr5TxE4yMNSG17ZWWH5EQ6D5KrKlU25zcq3I4V/l1QMjKF0oVDkWIi6VJvOKeviAu24nigcXdd+6aZ7CkFC4BenQAJ4kxL0bm1GXcTldMM2xsckNXQkfBsAxd2IXNwKZ9UUuFX2fVmpueXct6oaJ9fO/I04P1LjJTi6CK3VEZGUcrNAudn1wzAXe+AiBr6FfO0tAZXJCXAqtbkSos2EYl0yJt8rkJ0KCdCpYCuAVpkigvNlDAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 14:47:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session "MSI-X support with Linux stubdomain" notes Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel@lists.xenproject.org, George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P193CA0115.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6958:EE_ X-MS-Office365-Filtering-Correlation-Id: 849a9265-b886-4473-f807-08da9fbd5622 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oogTJYjFzCSYDvH/NPxdVXANWRvkcEDRaKvSoTZS49F+lVZfry4nAKId/r260/1HfyZi1/MQ696+3C+3StRLb7VR3rI7EM8vSldXgjGmlANpAyqIm26o8LKGafnDkrfEDX+erxksm/DfwYZqDetAzSwLntKFTnWFLpNOifQrmJFePg4cBTn23PwuDSlsDEuRLPovvevqQdKX/CBi/CsUrSId+bvcMte807+sdorsQe+KFLLQBp2uTgB2IPk9cMCDN5dmfSJXPmz5TCLd04aHeXFJQkmdy22Rv40SOrbi1gEwTxSGiXSOC03ngSAaduDLFE63M2CT88Oa5YMcBQ0yvp4j3HQyRP9QTpDNsDS1eY2tx/248pUGoiuAhkr4MjXk4w7dXqwwsGhP6sfFKoM1xknEtzI5sOtjwCXyGl9ESdf8QW37cNCR9b1SW8SP9EbbHzc92yoAlrXbrVdsaDUjCF25WS0yy8jiNtWIeZQzmtrLyWOS8LWQvHPyIPN92BZcLvsbsJijScvnDeGOJic7/3Dxaik8wYpSPyMRCujZv4EBR3Zz9vIWlUjSCGutxoo/UKI7SbrC9sDZfY7AWHZY+84EuYaIjB8rVJF/VzZdkc6/aVreTXjdV3h8Ik8IsSEpHPhvecRfELRjjFL5FSyL+rZaEgiB5TgNnXcV0WwOcYF1POnwsaG6Xqen+yZPbxkTzQasjBYjraWCT9G8Fmh6KFBGAUk81Gym3rm/AAlSVgow9UjgrtQbrVYqFcqPhMIFM/iCbKtcLH8SN29vHHP2kDKMV8C+c2Y/I8wo/19fPdeWraW3tMpjHw0qNFdpmRYEzZDPwuZaQ9uPdzuULPmOyF7ShMXWi+CNcmeEDRSp4sVPpel+LxRHXW9RmyL6K+Jb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(346002)(39850400004)(376002)(451199015)(31686004)(41300700001)(8936002)(2906002)(26005)(186003)(66946007)(66476007)(66556008)(38100700002)(66574015)(966005)(478600001)(6512007)(6486002)(2616005)(316002)(4326008)(8676002)(31696002)(83380400001)(86362001)(36756003)(53546011)(6506007)(54906003)(5660300002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFY2Tjk3dG1Dd3UwUmtVZFViSFdTVkU5YS9XY0sxMjNwbUlJUExSM3RBTC9Y?= =?utf-8?B?OEw5MHZGMFl5SSszRXcvUmtGT2tPbjJQbVM1cUwwSm5ibklQWHRSSnUvOXU0?= =?utf-8?B?bDdQVE9wWm9seHBoaVFrajlYRHhraElyZGFDSmJXVVFucnVGQUtGaUJmK1Vj?= =?utf-8?B?cTREaDhSTE1aMFM0MGVBdXBuY2JFNnBUKzVEdGY4MDJTamx2bUNrdEZ1blM1?= =?utf-8?B?cFppNTlaWTNBMkVIdXZ1bjBiVjM4TnJBT2prNlUvaHNBcFZFcU9lM2VFcnRV?= =?utf-8?B?cU5oTkxIbEVOMEtlSjZMcUphNDZHQ3p0R29KZzZzWkxwOEhDYlNVMUZianFq?= =?utf-8?B?N3VKWHpxMlZ5M0Uvejd3aVhtc1dBNzNHMG00NkhWdEkwZUhUU2lMUnlYamNX?= =?utf-8?B?NkpZZkFHNkpPNFZuZlU4SXlINEd0NGtqWDlTNm5zMTd1ZUpuVERzUVFhK0Jm?= =?utf-8?B?d0EyK1FSbVpDRmNibEN4SXJlZVR4TGZOVjIyT3ZmbHptdEw5cHAzdHFWbk9T?= =?utf-8?B?WlZCUko3VEVrTGxQQ3BGY3ZtK0VPWSsxOUdhU0VseEtPZUgyMWNvdlhqdXB3?= =?utf-8?B?K3cyMzdUTjlqTGtyZkJrWlZ0S2tSbFhuNURpR2gvUzR5RXJhYzJlcnRaOVBI?= =?utf-8?B?YTQvV2NzTlM5TStFTHYweCtoWTYwN2tsWVM0NDZ4V2ZOREVJYTVIVHVuV3Jp?= =?utf-8?B?SFhpSm1PWDQzZzh2ejMxLzVJTnVOMVRiTE8ybVJ1Sk4rQnVqaGdtY3pWSzNp?= =?utf-8?B?RFRBWERXWmpaaW5hRzMyOTJHNWpnTkhTcmZtdHF6bVdCRkdRb1RrNStZblJz?= =?utf-8?B?UFN2K1hFSUxwcjltbXZwMm5CWWtBVWJNUE85cnc3UHEzQjhRMC9hdDZrQTZE?= =?utf-8?B?YThDZVpXeUMwMVZpclFlU1h6ZW0yb1VtMTZ1djRydkZJYy85eU5NUWNCRnlk?= =?utf-8?B?TzM1ZjhoUHJQL052dC9ncnVMYTFHc0UybjJCdlA1V2ppQ1pFL2Y0bWZuUnFM?= =?utf-8?B?emdFanl0RWxrZG1NWU9KVXdGcWNnWitYaldTTmhpMGlUMlZXN3pPd3ltZTVl?= =?utf-8?B?R08vNFNKc1BVT05ObFFxbDBlU0JWOVNtZ29hR2xRc0c4SkpFWVdmaFAzVStZ?= =?utf-8?B?cmdDcStOQkg3TTJSQS8zOU5md3I5SUtlY05RdUpQREY0c3hkQ0thalozYnhv?= =?utf-8?B?cnJIU0FVRkF4VkNEK2xjQ1ErWTN0d1A3cG1TS1M3WUhFSXpTMStxRHNDZFZC?= =?utf-8?B?cTdDcW81YTBvMHppUWlOb2ttaWw3Ry83aEJQT04rbWtZekxRYUJRTDE2WTBm?= =?utf-8?B?U3RYN0ZPbU9zQ1VDWWlTR2tQa0JEVHpqdjVvWEpNcW9acllSaEJURmRTdTFz?= =?utf-8?B?TTNjWlQ1OWZxdDc5V3hVTGJhV09jU25pYkdiOG14VWUzVmlQdDZLRWp4OGVR?= =?utf-8?B?S2tvMDJ2Z3JjSWRoSDdVM2kzWGhjZXBtRTQvamZ5RVJHWDJFdVJwWktjTUU5?= =?utf-8?B?dGRZUGw0UEx4TGF5emRhU0ZDd0ZxR0hiU3lqSFEzU0R0eE0vQWxaYjc1bVg0?= =?utf-8?B?OTFKZnFwbGZmTzY3UFhoVnRkVXdZZy9pZXAzbU5NL2VzQ0wySzlsVnhNdFNV?= =?utf-8?B?VUsxMENkY2Y1WUNCT0ZzVEx4WE9zZDRnSHh4SldJQzIvbEtSeWNKbzgzVlBu?= =?utf-8?B?NUUzMHZCVjBvS29FRXUrZVVsdzFialVhNTkyVW5QZ1htN0dKMitoM3NuY1Zi?= =?utf-8?B?b0F5b1RDTnl1Qk9SeFp5VXB6UEpQWGlPKzdvUU9hejVDWk5JWHVJWUZLSzBj?= =?utf-8?B?byt4SkhqaHNLWlJTOEp1eDFCRk1lTC9CTW5nVkRzR1Y1c1paK1Z4cVFwMjhu?= =?utf-8?B?c1dKRXlFYTFOTkVINmdNQ1MzMllkNnRHUUxGUy9XUHBITEJYdjBFOVpHRkVl?= =?utf-8?B?dTlZcHZMMmJ6SjdLMTdldGxqdmt5Smk0R0RielRYekthbG9KcUlNU0pIeWZP?= =?utf-8?B?NDA0UUZ0RGVjb3JYdDlXL1M4MnBEamNkc0NGYzM2M3I1Y2FOY3JHdkZhSGNN?= =?utf-8?B?S0JONmRuL1g5emJCN0g3V3ZWT3BWNi9sYm1QYW9jSUh3UVROR1lhbC9jN09R?= =?utf-8?Q?ILW19r2uqsABwSddn7mhrKQuL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 849a9265-b886-4473-f807-08da9fbd5622 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:47:57.2707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O7rOqU3TozzoR9lgG+7CAls5gSXI1/+2cTSo7if+dFtFPnVXsMVr4a+wPPWCr4qW3nB3s7ZqU2T/5LuzkPup/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6958 On 26.09.2022 14:43, Marek Marczykowski-Górecki wrote: > On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: >> On 22.09.2022 18:05, Anthony PERARD wrote: >>> WARNING: Notes missing at the beginning of the meeting. >>> >>> session description: >>>> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn’t >>>> support MSI-X. For the device to (partially) work, Qemu needs a patch masking >>>> MSI-X from the PCI config space. Some drivers are not happy about that, which >>>> is understandable (device natively supports MSI-X, so fallback path are >>>> rarely tested). >>>> >>>> This is mostly (?) about qemu accessing /dev/mem directly (here: >>>> https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) - lets >>>> discuss alternative interface that stubdomain could use. >>> >>> >>> >>> when qemu forward interrupt, >>> for correct mask bit, it read physical mask bit. >>> an hypercall would make sense. >>> -> benefit, mask bit in hardware will be what hypervisor desire, and device model desire. >>> from guest point of view, interrupt should be unmask. >>> >>> interrupt request are first forwarded to qemu, so xen have to do some post processing once request comes back from qemu. >>> it's weird.. >>> >>> someone should have a look, and rationalize this weird path. >>> >>> Xen tries to not forward everything to qemu. >>> >>> why don't we do that in xen. >>> there's already code in xen for that. >> >> So what I didn't pay enough attention to when talking was that the >> completion logic in Xen is for writes only. Maybe something similar >> can be had for reads as well, but that's to be checked ... > > I spent some time trying to follow that part of qemu, and I think it > reads vector control only on the write path, to keep some bits > unchanged, and also detect whether Xen masked it behind qemu's back. > My understanding is, since 484d7c852e "x86/MSI-X: track host and guest > mask-all requests separately" it is unnecessary, because Xen will > remember guest's intention, so qemu can simply use its own internal > state and act on that (guest writes will go through qemu, so it should > have up to date view from guest's point of view). > > As for PBA access, it is read by qemu only to pass it to the guest. I'm > not sure whether qemu should use hypercall to retrieve it, or maybe > Xen should fixup value itself on the read path. Forwarding the access to qemu just for qemu to use a hypercall to obtain the value needed seems backwards to me. If we need new code in Xen, we can as well handle the read directly I think, without involving qemu. Jan > I did some preliminary patch here: > https://github.com/marmarek/qubes-vmm-xen-stubdom-linux/commit/80cf769f3659aa0d7f2b5598bf862d83da28807e > > but it does not work yet. It seems I haven't undo MSI-X hiding enough > (lspci inside the guest doesn't report MSI-X at all). This I will figure > out, but I'd appreciate comments about how to handle PBA best. > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:02:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411785.654842 (Exim 4.92) (envelope-from ) id 1ocnl5-00018K-Hc; Mon, 26 Sep 2022 13:02:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411785.654842; Mon, 26 Sep 2022 13:02:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnl5-00018D-EN; Mon, 26 Sep 2022 13:02:51 +0000 Received: by outflank-mailman (input) for mailman id 411785; Mon, 26 Sep 2022 13:02:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnl4-000181-0L for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 13:02:50 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82313282-3d9b-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 15:02:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82313282-3d9b-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664197367; h=from:to:cc:subject:date:message-id:mime-version; bh=Do6s0Sm6WFnRlQuns40ddUOSbUFlwDXEjhDaub+jsZ8=; b=I1U0AsxYe9T0Rk2uVfGDkIvJa+vDmYdOiURizeJ8+s8Hfoh3y164Kp1E Exxxc7ykS2CtRmmanEWMDw4tgginAiNWeuugehJ/tQYsN8H9b1EvhvhEL XEBiOZpUp1kMqSMenSIH0QTMTaBLrD468zuAj9E9kl3aEFst5SZbyk4Tj c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81335397 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qAZKdq8b+6M2lYPF9BgBDrUDnH6TJUtcMsCJ2f8bNWPcYEJGY0x3n GYWCz3VMvuOYGakf40gO9u/oUMC7JXVy9FjG1Bp+C08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gFaYDkpOs/jZ8EI14qyr0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGAks2AKgV4eVMJHBF8 7sfdyIALTekiLfjqF67YrEEasULKcDqOMUUu216zCGfBvEjKXzBa/yUv5kChm52350QW6aFD yYaQWMHgBDoShtDIFoITrk5m/+lnCLXeDxEslOF46Ew5gA/ySQhieO2bYGEJbRmQ+1Vm0yxi nz7oFjXAzMCN+XFzhin2VGF07qncSTTB9tJSezQGuRRqEaI2mUZBRkSVF26ifq0kEizX5RYM UN80gojq7IjsnOiSNbVVge95nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neClsnlAjFHu7SPRXWQsLyTqFuP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLHqS1s/j4AjLL5 iGBqm852Kcezuks2PDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl D1dwpXFsrhSZX2YvHbVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX KMxkVkLjHOwFCHwBUOSX25WI5pC8EQYPY65Ps04l/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY MnFLZ/3VSdCWP8+kFJaotvxNpd6rh3SOEuJHcyrp/hZ+eP2iIGppUctbwLVM7FRAFKsqwTJ6 ddPX/a3J+FkeLSnOkHqHXs7dw9iwY4TWc+r8KS6t4erfmJbJY3WI6KLkOJ8KtI1wMy4VI7gp xmAZ6OR83Kn7VWvFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:jB3gHK16D1QveuFyagvEJwqjBKQkLtp133Aq2lEZdPRUGvb3qy nOpoV96faaslYssR0b9exoW5PwJU80l6QFgrX5VI3KNGKN1VdARLsSiLcKqAeAJ8SRzIFgPN 9bAspDNOE= X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81335397" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Date: Mon, 26 Sep 2022 14:02:13 +0100 Message-ID: <20220926130213.28274-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch which is relevant to CONFIG_XEN_IBT in 4.17 and later. Force it on, rather than having 50% of the jobs not testing what they're supposed to be testing. Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible") Signed-off-by: Andrew Cooper --- CC: Doug Goldstein CC: Stefano Stabellini CC: Henry Wang For 4.17: This is bugfix to CI only, to avoid it producing a false negative. Currently, the test intermittently fails to spot the error it was intended to identify. It is very low risk as far as the 4.17 release goes. https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/3084774561#L373 for proof that CONFIG_XEN_IBT=y is being fed into allrandom.config --- automation/gitlab-ci/build.yaml | 2 ++ automation/scripts/build | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 720ce6e07ba0..65e06c858ef3 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -299,6 +299,8 @@ debian-buster-gcc-ibt: variables: CONTAINER: debian:buster-gcc-ibt RANDCONFIG: y + EXTRA_FIXED_RANDCONFIG: | + CONFIG_XEN_IBT=y debian-unstable-clang: extends: .clang-x86-64-build diff --git a/automation/scripts/build b/automation/scripts/build index 2f15ab3198e6..2d9dd86df904 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -12,6 +12,11 @@ cc-ver() # random config or default config if [[ "${RANDCONFIG}" == "y" ]]; then + + # Append job-specific fixed configuration + [[ -n "${EXTRA_FIXED_RANDCONFIG}" ]] && + echo "${EXTRA_FIXED_RANDCONFIG}" >> xen/tools/kconfig/allrandom.config + make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig hypervisor_only="y" else -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:13:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411792.654853 (Exim 4.92) (envelope-from ) id 1ocnup-0002ei-Er; Mon, 26 Sep 2022 13:12:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411792.654853; Mon, 26 Sep 2022 13:12:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnup-0002eb-CF; Mon, 26 Sep 2022 13:12:55 +0000 Received: by outflank-mailman (input) for mailman id 411792; Mon, 26 Sep 2022 13:12:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocnun-0002eV-JL for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 13:12:53 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0069.outbound.protection.office365.us [23.103.209.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea09a3a1-3d9c-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 15:12:48 +0200 (CEST) Received: from BN0P110MB1627.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:187::12) by BN0P110MB1609.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:184::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 13:12:43 +0000 Received: from BN0P110MB1627.NAMP110.PROD.OUTLOOK.COM ([fe80::e45f:2ab7:859:30a]) by BN0P110MB1627.NAMP110.PROD.OUTLOOK.COM ([fe80::e45f:2ab7:859:30a%3]) with mapi id 15.20.5654.024; Mon, 26 Sep 2022 13:12:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea09a3a1-3d9c-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=rLTW4EPVr9IF6YljZdD95tp7UiBB6tnRkJ+Qqh5zHFhWp7qa9h9qzSOwfOdPwi6f2woWropQrDsM0VkBO1piiNkrwfxzsPRkFUVskdvq78MC9w8jQFzyn0aVmUTZiuAFwSs+DCvA+2qzzk4baasMn9t1RgTN3tEx37NkRH08uPhI7lRFSG/gYm2vrdyR64tgpLZochypXoCZTfTzETNl0/sencecDHDy0Hv9gUC5gvhMfkg5Yn55I4LpjXEpt2jJgqpwu9woZE1TnYx9N4PXEXzhXkfbdxjTuL5iAoGjlVsZ25Y5yhwhBhReQW1pOsYYDvOKPUxyS2YSEBb/CvOrfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5fOdMcuyym5knRQCoRqNW4v2KEJiYU5TE4XBXvADcLI=; b=YOkotQEBUmbcEi6zNCnyvakpzlS7mq6L/KIlD7W/fkxCMAXPMQuYRm6qe1eWgfxeDAGt2Jc7rA5EZUTP1Gtr26pQydlte83LgGJTcs4GQnswCbZUqi246hqlgMfZPqtMt+tLKiOvwf6/M9wnyMc06hOTpM5DPtPNrmMGs1NNcqZUsX1EKeRa5BgZtJAziK5wmrp/+/smsFKJBnF/P88mJZp0oZ37knn8R0T7Yj02b02ot8Wrs2RVDgXn4ppEZbGYxp4hVoVWSytr8BS0LtDOxYEVMhKLQzCReSRHMM/uR5UT/zpb8wwZ+wonkCg5ayMdFrs2nj53OAaM4MeiM4zf0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dornerworks.com; dmarc=pass action=none header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dornerworks.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5fOdMcuyym5knRQCoRqNW4v2KEJiYU5TE4XBXvADcLI=; b=gg81i5+WVCqGA7UUgTU68zSeFJ2SGZXFZXixWVcLXHwqu80mrRjxKxQtox1ks6wXJ7FQIdIDXJ0o3YdJB2hSat3tMYYjR89Epkred3Ogfy8CWc7UjTTkkxxGnKnXeXT7TZy7tNgCKowskzYe0au5NunOAMxd7cIln02n0T/w8S52YSucDpOgsx1dYyRj4AU+B/957FoJZWeTk4yzI4S9LEPZmxmFtnosIFY0q1VqaXzvFX2jPzZa5/HofK+7UpJvGoqAfH04+iQIwmieiCNYGzBZrSnDIgx2dzfjEDOs0zfXn+J+xsqD3wamzgjKOTfsdYrj4nn5TD29aSH+LvNwfQ== From: Nathan Studer To: Jan Beulich CC: Stewart Hildebrand , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jeff Kubascik , Robert VanVossen , xen-devel , Stewart Hildebrand , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates Thread-Topic: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates Thread-Index: AQHYy828nsRUzF6SLE2+f4pUs1OUNq3xdBmAgABF0mA= Date: Mon, 26 Sep 2022 13:12:43 +0000 Message-ID: References: <20220915193027.3166-1-stewart.hildebrand@dornerworks.com> <20220919021002.2193665-1-stewart@stew.dk> <021abdc2-2bd6-6220-1202-12fffe090a77@suse.com> In-Reply-To: <021abdc2-2bd6-6220-1202-12fffe090a77@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=dornerworks.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN0P110MB1627:EE_|BN0P110MB1609:EE_ x-ms-office365-filtering-correlation-id: 083dd147-0fde-4016-ebd7-08da9fc0cc3e x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cCH36Y3l4yeex+pARuUQy7XiFk38JEpv2Qu0SrA6fB5HZb6nHfYm0Hwd3+AOJQ83Y6eKyzGJYMTJQlk2Mb+zlp23gHmNA+MNLugkC0oWdiON2CRD07IVLWchv7PeEcZ5ph16FqvF+U51aOOmE51hgsjErzL3FgfTSKz1ymwv7/FeMMD4YDhwHb5frmJXYvVGUuVQab0bDijXeiD4SVkjgaR7m+K5/5Ut8Ec9mWxUAMW+f0JXI0B4lwk0lhDwF19yt5BH4R9oBlY8IaczkjJBgJOSxSh+UpaGbqFY6OIcouLnYzwytfqyoGHtMzyt9eb8mGwdRrjok2r2uDwZAOh3zQmbeKR7SJZa/UL7Nymo0wQ/mnpgJ3FcwJKLHJjnNZ68uLjqhosrRzozwpHkuPKS1prlgvs1u1JC/y4TYNoY2INwob/6X+EaezqHSmtzo55Vkhg4bTg+QtURIgMXUteYhNfeC6cV+qY/j4u5Ap6X+RCF+8KdcIj+4kKUz3j13ogRgkRIcu+8U44UWgWJ6JeT/rF1QHU3NA5uFQiyno9B3wkg7DPb8WGOlmwBudXt3CkCA6OrNVnsPxj8cHIpIu5rG4tpF3Edds7+Dq5XmWkSZ7Ic9S0D2uqRzcKe6pSwl55lcMemtj7bakrRPXgNTfedDTWeAIKweMb24otpvUTag38= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1627.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39830400003)(136003)(451199015)(71200400001)(55016003)(86362001)(41320700001)(54906003)(6916009)(7696005)(2906002)(6506007)(53546011)(26005)(9686003)(8936002)(33656002)(52536014)(66556008)(76116006)(4326008)(83380400001)(66946007)(8676002)(66446008)(64756008)(38070700005)(66476007)(508600001)(186003)(41300700001)(5660300002)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Yu+z5P6NWiuUeSNGQofxf5ojaC9RAt43+gCwl0GARhXSN6t8Bsc54AgBEqpjQbXBNvSkqH538wB9aTS6M+k/+Zbb2YTFuJuxgaGxUPFGlGMUsF+GyxTrfSV+x1Ia6SI2GGQsEfNjIsVM7CsV6EF+TDBlX0Yd2/J5J/NoHu9hGIgpcJWtgDJAB/1DndUIK/YOeNgIhPbvE4LywtAvgIZKEDHd9Q/NYxsqIBvNt73b6uLz/TOdIX8W6WHS4h4LhmCqBlAjxJVamQZR2mz9jAFg+fQzksLiRyWsaOs2VhAUvVf44kP98c64SrbUezVyd8yqiOGqbbmxw+rDz2XCnTi2QPgHGTCskMsMgOxlNZgTzJN2i3JST3qc+QP6sgtI9jzzz27PUGWPDuHHHt22JVB6S2FXBkyaxcLiZVacioqdpSg= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: dornerworks.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1627.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 083dd147-0fde-4016-ebd7-08da9fc0cc3e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 13:12:43.5089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 097cf9aa-db69-4b12-aeab-ab5f513dbff9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1609 PiBPbiAxOS4wOS4yMDIyIDA0OjEwLCBTdGV3YXJ0IEhpbGRlYnJhbmQgd3JvdGU6DQo+ID4gRnJv bTogU3Rld2FydCBIaWxkZWJyYW5kIDxzdGV3YXJ0LmhpbGRlYnJhbmRAZG9ybmVyd29ya3MuY29t Pg0KPiA+DQo+ID4gQWRkIE5hdGhhbiBTdHVkZXIgYXMgY28tbWFpbnRhaW5lci4NCj4gPg0KPiA+ IEkgYW0gZGVwYXJ0aW5nIERvcm5lcldvcmtzLiBJIHdpbGwgc3RpbGwgYmUgd29ya2luZyB3aXRo IFhlbiBpbiBteSBuZXh0DQo+ID4gcm9sZSwgYW5kIEkgc3RpbGwgaGF2ZSBhbiBpbnRlcmVzdCBp biBjby1tYWludGFpbmluZyB0aGUgQVJJTkMgNjUzDQo+ID4gc2NoZWR1bGVyLCBzbyBjaGFuZ2Ug dG8gbXkgcGVyc29uYWwgZW1haWwgYWRkcmVzcy4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFN0 ZXdhcnQgSGlsZGVicmFuZCA8c3Rld2FydC5oaWxkZWJyYW5kQGRvcm5lcndvcmtzLmNvbT4NCj4g PiAtLS0NCj4gPiAgTUFJTlRBSU5FUlMgfCAzICsrLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvTUFJTlRB SU5FUlMgYi9NQUlOVEFJTkVSUw0KPiA+IGluZGV4IGUxMmM0OTlhMjguLjgxNjY1Njk1MGEgMTAw NjQ0DQo+ID4gLS0tIGEvTUFJTlRBSU5FUlMNCj4gPiArKysgYi9NQUlOVEFJTkVSUw0KPiA+IEBA IC0yMjEsNyArMjIxLDggQEAgRjogICAgICAgIHhlbi9pbmNsdWRlL3hlbi9hcmdvLmgNCj4gPiAg RjogICB4ZW4vY29tbW9uL2FyZ28uYw0KPiA+DQo+ID4gIEFSSU5DNjUzIFNDSEVEVUxFUg0KPiA+ IC1NOiAgIFN0ZXdhcnQgSGlsZGVicmFuZCA8c3Rld2FydC5oaWxkZWJyYW5kQGRvcm5lcndvcmtz LmNvbT4NCj4gPiArTTogICBOYXRoYW4gU3R1ZGVyIDxuYXRoYW4uc3R1ZGVyQGRvcm5lcndvcmtz LmNvbT4NCj4gPiArTTogICBTdGV3YXJ0IEhpbGRlYnJhbmQgPHN0ZXdhcnRAc3Rldy5kaz4NCj4g PiAgUzogICBTdXBwb3J0ZWQNCj4gPiAgTDogICB4ZW4tZGV2ZWxAZG9ybmVyd29ya3MuY29tDQo+ ID4gIEY6ICAgeGVuL2NvbW1vbi9zY2hlZC9hcmluYzY1My5jDQo+IA0KPiBOYXRoYW4sDQo+IA0K PiBtYXkgSSBwbGVhc2UgYXNrIHRoYXQgeW91IHN1cHBseSBhbiBhY2sgaGVyZSwgaW5kaWNhdGlu ZyB5b3VyIGFjY2VwdGFuY2UNCj4gb2YgdGhpcyByb2xlIChvciBvdGhlcndpc2UgcmVwbHkgdG8g c3RhdGUgdGhlIGNvbnRyYXJ5KT8NCj4gDQo+IFRoYW5rcywgSmFuDQoNCk9mIGNvdXJzZS4NCg0K QWNrZWQtYnk6IE5hdGhhbiBTdHVkZXIgPG5hdGhhbi5zdHVkZXJAZG9ybmVyd29ya3MuY29tPg0K DQogICBOYXRlDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:19:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:19:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411799.654863 (Exim 4.92) (envelope-from ) id 1oco0y-0003M0-3e; Mon, 26 Sep 2022 13:19:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411799.654863; Mon, 26 Sep 2022 13:19:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco0y-0003Lt-19; Mon, 26 Sep 2022 13:19:16 +0000 Received: by outflank-mailman (input) for mailman id 411799; Mon, 26 Sep 2022 13:19:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco0x-0003Ln-Kb for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 13:19:15 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfc037d4-3d9d-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 15:19:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AA2165C0129; Mon, 26 Sep 2022 09:19:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Sep 2022 09:19:12 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 09:19:11 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfc037d4-3d9d-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664198352; x= 1664284752; bh=sPBLOFIkGQvztxe4BRzooD8nSugrb0zHKtg4O8Ots8g=; b=a gnmJhaDghaRrRNQyB25SnbDn2va70PHs9o3Q8YVP/Aet+BKdpshPAymMXj5k/MM6 +a2TK80Y9WWJaA/V/zuoUD2lFPcHO5/cVNBTvHUX/RVTGu4VvNolsr/6BGtJB7+h 2Cl60OBBjIysPirX6vtdhjodaywjbpRKokcOpT/NT1aRUjLPUVdQLan2EOcPnNXj pndx1P73MOjSSUAmbOV+P8XY70Yl81+EZhmutFaKuvrBC3dGi+emrg8/nhzKoc6Y xD3lOTpCrVaEz570TuZIoacmGQ1QDbaBOB9D5UZU/L0S/+EXNdzVvKE86PBISjoC fFd7uhJLOztd+k5nR2r0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664198352; x=1664284752; bh=sPBLOFIkGQvztxe4BRzooD8nSugr b0zHKtg4O8Ots8g=; b=jnrw14nMfJPfn5SMHmJE5q9XNZz5x6FRRMthUYl1Irmj eLHPrDKYJPYdnKtR/whBsz7UTiw6S9y+dvP71B6V4qB2VsR3ut9SKBjL4r5LUzoP QaycIVAWqmsBJlMvw111lBfixLiKJNbdU/x9+wrkuLUYPXG6rBuT7nLHcTfP1ILe APD87BpxblK8Kevyemx9xpZxb1Dv14zf4NxB/Lud4BvscwvortWIBmQuuhcWSs0+ hOSdZTwhqqhfabJoJyhYJL/qZFbTwz96vyHIrnC4owZswQn+kw68OsD9Vn/HN6Dh 6Yqyp56QlBM4qx1qUWAi26FRkXs/c6vFXDt7+HYCXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegvddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepveeu jeetgeelleetudeuvefhtefgffejvedtvdfgieevheetheelgeeuledvjeevnecuffhomh grihhnpehgihhtlhgrsgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 26 Sep 2022 15:19:07 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Message-ID: References: <20220926130213.28274-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/5s/iqeUDXZK6d0Y" Content-Disposition: inline In-Reply-To: <20220926130213.28274-1-andrew.cooper3@citrix.com> --/5s/iqeUDXZK6d0Y Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 26 Sep 2022 15:19:07 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test On Mon, Sep 26, 2022 at 02:02:13PM +0100, Andrew Cooper wrote: > buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler p= atch > which is relevant to CONFIG_XEN_IBT in 4.17 and later. >=20 > Force it on, rather than having 50% of the jobs not testing what they're > supposed to be testing. Shouldn't this job be with a static (or rather: all yes) config? > Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible") > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Henry Wang >=20 > For 4.17: This is bugfix to CI only, to avoid it producing a false negati= ve. > Currently, the test intermittently fails to spot the error it was intende= d to > identify. It is very low risk as far as the 4.17 release goes. >=20 > https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/3084774561#L373 = for > proof that CONFIG_XEN_IBT=3Dy is being fed into allrandom.config > --- > automation/gitlab-ci/build.yaml | 2 ++ > automation/scripts/build | 5 +++++ > 2 files changed, 7 insertions(+) >=20 > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build= =2Eyaml > index 720ce6e07ba0..65e06c858ef3 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -299,6 +299,8 @@ debian-buster-gcc-ibt: > variables: > CONTAINER: debian:buster-gcc-ibt > RANDCONFIG: y > + EXTRA_FIXED_RANDCONFIG: | > + CONFIG_XEN_IBT=3Dy > =20 > debian-unstable-clang: > extends: .clang-x86-64-build > diff --git a/automation/scripts/build b/automation/scripts/build > index 2f15ab3198e6..2d9dd86df904 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -12,6 +12,11 @@ cc-ver() > =20 > # random config or default config > if [[ "${RANDCONFIG}" =3D=3D "y" ]]; then > + > + # Append job-specific fixed configuration > + [[ -n "${EXTRA_FIXED_RANDCONFIG}" ]] && > + echo "${EXTRA_FIXED_RANDCONFIG}" >> xen/tools/kconfig/allrandom.= config > + > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=3Dtools/kconfig/allrandom.c= onfig randconfig > hypervisor_only=3D"y" > else > --=20 > 2.11.0 >=20 >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --/5s/iqeUDXZK6d0Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMxpswACgkQ24/THMrX 1yy8MQf8DDHXnZXaO7X33RfsqJaEkaiuU+lrmmAKRHKcdWK77Fl4W0nNdaxXBsKF jC9wSRjo5vX5wn2ThsjgbaCcEgeauvRw9gXt2WljmeodkpZ84lYLLE80DlyWD8OT zGJdjbPqauNgbchJwnbIgLEhOVGd4uuGxUjKPV0hhn8m+MfbfB62a1VoKDQML43+ BRnr45Jn3m2KFOqcUZvV1WwcGVcLWhZk7QcQg8ura+Rwyo6vhiP6d3AC7vQD3jR+ T2lUf2gtIe5M8bC6w+eSy+CaZltWehUo00TkO8Mo1nDh8jB26sh7EBgxsfnhMeVP uN/kxLCTmg1rob41pUmljkRe5bhGuw== =LwEb -----END PGP SIGNATURE----- --/5s/iqeUDXZK6d0Y-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:20:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411806.654875 (Exim 4.92) (envelope-from ) id 1oco29-0004my-H7; Mon, 26 Sep 2022 13:20:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411806.654875; Mon, 26 Sep 2022 13:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco29-0004mr-EU; Mon, 26 Sep 2022 13:20:29 +0000 Received: by outflank-mailman (input) for mailman id 411806; Mon, 26 Sep 2022 13:20:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco28-0004mh-JC; Mon, 26 Sep 2022 13:20:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco28-0000WR-Gp; Mon, 26 Sep 2022 13:20:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco28-0004aZ-3Z; Mon, 26 Sep 2022 13:20:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oco28-0005GA-3C; Mon, 26 Sep 2022 13:20:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xMBtXdt1yJdsSDammPx90PCTRBGifIGObD/82Lrdtj0=; b=VvRxBEh4GqxYb70Jfmc9cYNmcC 8FSS74G0hhQHPRTOhbWz02IUyuFEvyl1nbwVi/tEc10szWjXvUGQ9uACtN3h6KNcIPAcTal69F8Zx MltO9tctQ6x5fV5w59Nj7DX0bWtuVPuq9O0njtKxoXDxuDrNsPPmWOY85Z/K2llXFUWc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173315: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bfd3e9945d1bc551ad11272c7fa752ff3d060149 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Mon, 26 Sep 2022 13:20:28 +0000 flight 173315 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173315/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bfd3e9945d1bc551ad11272c7fa752ff3d060149 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173192 2022-09-14 14:03:20 Z 11 days Testing same since 173315 2022-09-26 10:01:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Daniel P. Smith Jan Beulich Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3007efadf7..bfd3e9945d bfd3e9945d1bc551ad11272c7fa752ff3d060149 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:25:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411817.654886 (Exim 4.92) (envelope-from ) id 1oco6l-0005Wt-3l; Mon, 26 Sep 2022 13:25:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411817.654886; Mon, 26 Sep 2022 13:25:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco6l-0005Wm-0o; Mon, 26 Sep 2022 13:25:15 +0000 Received: by outflank-mailman (input) for mailman id 411817; Mon, 26 Sep 2022 13:25:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oco6k-0005Wg-1c for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 13:25:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a588a5d7-3d9e-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 15:25:12 +0200 (CEST) Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 09:25:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6037.namprd03.prod.outlook.com (2603:10b6:208:309::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 13:25:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 13:25:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a588a5d7-3d9e-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664198712; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oYoR9NwcASW8Pc3uqcFjQ2l8rMY6K4LBLAjMpYzHSJI=; b=g9X82gOFFC2dalDovd1du/mzdhoncSF6TE7cIBLhwmIlViw5wHMYFo83 g6LLtouBAMc6terGasx5sZhyCOR5aMTK7fOfnHaa5QgS5wPJdbW4iTzia ZXr2NKJU/zbhCpCImhLvL9D6Q7wH3lE6Hb/5Z0oKmjXfMkBXQnptQdCvb Q=; X-IronPort-RemoteIP: 104.47.73.168 X-IronPort-MID: 80482944 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2z+QAqJAOq0PC/yIFE+RCZQlxSXFcZb7ZxGr2PjKsXjdYENS0zYDy 2UZXGCCOvqLZmDzct4jO4vl9xlQ75HWzdcyQFdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/PZ9ks21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEyst8KUQ2GpQk2LxyX2gUz L87dR9WR0XW7w626OrTpuhEoO0GdJWuGbxF/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H33T+mLW0wRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIzHlWrfoy7w7gPJtR6mUaQPSZuAz6Epnn2eyEY9GFoVcHLu9JFVjWb7AbqzM Xc8/yM0qKEo+U+DT9/jXga5qnqJoh4dXdVLF+QwrgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqW/62Yqj6aMiEPIWgPIyQDSGMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiijCU4naRVsscN2I2y51WBiDWpzqUlVSYw7wTTG2e6tAVwYdb5Y5TysAaLq/FdMIyeU1+N+ mAenNST5/wPCpfLkzGRROIKH/ei4PPt3CDgvGOD1qIJr1yFk0NPt6gLiN2iDC+F6vo5RAI= IronPort-HdrOrdr: A9a23:iZAgg61/tCT2yEqLQDqKqgqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY fABK5r X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="80482944" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HoFejPLJTtd9fT7ySkQc3Xqu8u7aWleLMa3hDlWOZaC3uwMW+TjJjuy2wpzFKE3fCMtq52b5qA68xRNQ6csNtyOxQPm+3tRoALQzVW1953iIXj9q9JKBG4yVsMrGWrQ6iNSDgezNBg84/ZW6q+f5H8k5g9eN4abSQcZmZG3HKDOrdt9msgFktmQ+1B+/C50rn5aYfBi42Zf37Ij8ywSwOd0ZUFC62RaLRUW+GYdOsVkZaOANUBRVgxJprUD53qbbxxHFDNEl26o7mWW7+Dzmy4zhMrBVE744B3nEKyJb2UkRJv8NTdTrxzcb3Yr/B6U5Vwyxp7W6wt1yfI3wnlTJ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oYoR9NwcASW8Pc3uqcFjQ2l8rMY6K4LBLAjMpYzHSJI=; b=YojzotGn5tiZ+FcgZ7VYr42ZY+RNeQC8eIlVCYSmQBKC4vjpWfWEfUstsyeUwVXj7oobGU+f46zFGhjMYOomMhhqdMpfKQB6lY6ETQEugkaNE+ZTO1PSis83E8AjLK5BY6ok5AqUdOmI2VliV0cwoq3zLc5zUfRh0/hhaXBcD1sVX4EDowxWdKCkXenPYyJwHt7VqAH1Rks0+JNUaEcmxDAGGbOuiLRXKu9Xp5vJqD9VY+7r5VXy9wGSKZ/iG/ul+/Zq10aJMMhoacyOkpU7rhygy4CfLTXYrKeXEKjxzHJrPV4zyTZ/ccdjPbCyBkWPHiutaZUpIdmWrfyzOFN18Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYoR9NwcASW8Pc3uqcFjQ2l8rMY6K4LBLAjMpYzHSJI=; b=SeEXXY3TFkLEgryUkwdf4vnibARy2TNoLr935Trh0kOHI+jd9Hp+dqUYCvYVlCmm54msSkRH4LBz3SpUlry32vLB9y2m5uqIYcwrOi1zzHMtYlgcClNcoEZny7pLlJ0BzO+Gf9IblA6kQRB0DHSaVn4OX2vNh3iIY+j1QKSwBf8= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: Xen-devel , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Thread-Topic: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Thread-Index: AQHY0ahGyNiffGBomUWUhynqT69//63xscyAgAABqQA= Date: Mon, 26 Sep 2022 13:25:04 +0000 Message-ID: <409b5866-5063-53b2-6a36-771e5c726987@citrix.com> References: <20220926130213.28274-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB6037:EE_ x-ms-office365-filtering-correlation-id: c5944001-b3db-41e8-a983-08da9fc285f7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T/5nGPy8sTUG1JsHHNziKXh0aSZM3S+E0MXBA3SH49l0ZWVWaJDJV76NOC+kLd7kQkyi7qLXp5QyKhqatSjxA3z+xVCj8mhwGVVt+2v3Ixe8+ILcjSu2+sAGxumRxI2RsZiJKYgJ8+QWD+RID+5fIWHEgJYWoOoRZWj2pe9zp2QZVbZXLW/iqs4RZ/PvzWghWih+J8LwmrSRgHnYf6+hLmqaAJGXtJbj3OXsymXgWws9E5fRhOsPe2JzO+fRL7hYOUXhTx8HnZY7CaIzk8bUnlU/ON1TycOVXrespYargUHSBnpE+OMqs5OA5s/ysLo1+JHxvNeGzJK+JFhHnLKUhNNYl7AaIU9bv4s2j6kx3KnCrOMok82U0P82QnM/CrOmeHfdCRfOxAzcR4/nL2ygn2bHeRzM+WWmrortmDa1k3jNMcbPTdGkOnXZ3sczV+10Z0h8WItxSRd1tepZumNdVMrPiB4SNfXamVZvvsaAN2vMv9S6DN8nMbGObcgkc852L2r2JeIUW1wjFUWYhL7fljZ+D22nHq9mEMUZyGNCHB/TMgQICSpFwiwx2y/qHGpXkotcLcxj9RoJ1L6Lh4I0nPAIB2m2mLR9cWXMjsWYTb7DeK5zJv0Y4QebKWEIoDrM3TVMh0aRR2YyGCtwRUUEC0DLuSs3aR8PddQCZiMHFvrE3tRf0ALDiGfrEWNw2ZMZeck0wEVSKycwhgnrn4ie3YVYa0f16RmIQh2p6oYt6zZoMawDcAloj6ER1NOmND49cD67MBI6BE6K+jkqEt7Q+UKdAp/qSR78wY6Wl8yQXKHO2QX+sSyJXwK6ifd87zg/qlvLW5VOAMlBsQjr2iHigQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(86362001)(31696002)(54906003)(8936002)(66446008)(6916009)(316002)(66476007)(4744005)(66556008)(64756008)(8676002)(66946007)(76116006)(91956017)(83380400001)(4326008)(82960400001)(66574015)(38100700002)(122000001)(41300700001)(53546011)(6506007)(71200400001)(6486002)(2616005)(186003)(6512007)(478600001)(5660300002)(31686004)(26005)(2906002)(38070700005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZHJwQ1VlM0hzenJiUW5nTG9HNkxaelIzRjdwdWZ4NWNpV05jclVVTlA2dmlL?= =?utf-8?B?bnEwVmliUnRBcGl2aExIbTRueDlOT3J2K0F2eWEwelNURkZMVk5LZk9sNXV3?= =?utf-8?B?NCs1SkdVSHY0R0dhMGN6YXF6cDllSlpnRmhBMnR6UTlxUHpCM1hYaThqU2Jv?= =?utf-8?B?cFBrT0tXb0pvUmJjd2drRlk1LzU1WldSRER5QlBBZXVXMzBBWTc2N1RNMlVt?= =?utf-8?B?M3JmbHJnVlo0Y3lDTmdUR1pYalJEbnZOaVF2aDc3RHdubXRvdTFZWDRsUi9r?= =?utf-8?B?cklVV3paeThVam1FT3IwT3ArUGsvbERMci83Z2lrK3NUazl0L3pxdEdOQ0VH?= =?utf-8?B?ait5UkIwVnZ5bHBRaXBRcHFWRnhBVy9nRFVBL3NPMmVZUEx6blo5T2tvczZl?= =?utf-8?B?VDh3cGl2VFM2bTMwOFBMSXNiREtGWXNCWmZBR25QQTdQeDZQVEdTaGdpL0R3?= =?utf-8?B?dVFGeVRjQkNjcTJBTGlCdjVsVk9oSWpWZWZhU2FDQmpXeUlkZWVPOGdCZWR6?= =?utf-8?B?dW53VmJhRXdGSFVhVUlMOXFrbk9FTEROaFU4M25zL09mWUNRdHRKRVc0ZWwx?= =?utf-8?B?TWdnbzhSUU8wV2d4UXNHdUhyaTFUaUFJMXVmYjBtc0t5Z1Nkd0N3R0tRbDdC?= =?utf-8?B?R00rTmF0YXkyc2NTYzFabG5wVzl3cmdVRWhFbVFXbkpQL0NCR1M1NEN1U0Vi?= =?utf-8?B?Zk0rUUVmWnBqYzVKaUMzV1dSZTRmWHNrQVFGNnNnVjBFUnhhZVBWUkRReFdV?= =?utf-8?B?ZnVzVVhwRFdQS05BQkZmUi9od1AzWWxBUWREcmM1V29nSnhmWE81elNJaEZT?= =?utf-8?B?N1FJZHFoYlZUZ2k0Y1pIM1hhTFIwNzNLenhZOWdyUlI1ZEhtOUxsRmVlUVcx?= =?utf-8?B?MnowM250ZmJ5YklyUS9QV0hUaG10TmlxYzFnZ2VwaFBzeGxSY3EveTdKQWd4?= =?utf-8?B?eTNHTExCYkNWMkY2akk5RjVzOEMvSGRoaERndHN1eHo1SlcrU3VhTFZHVWZH?= =?utf-8?B?UHRrSzNJVXZlRXhMOWliU2xobVA3VEN0TU82YkE0MGE0T2hxWUZuWUJDeFhC?= =?utf-8?B?dU5zS2o1ZmJsdDVjSytlSFhDalRRMktnTDlhM3dKVytpcGtiUkdPOGlCdCsy?= =?utf-8?B?M2dXMGlYWVYrRFZJU3U5dnpNdHU1eWs0bWN1TjEwbTlXMnpFbWJ4YXJ4VDQ5?= =?utf-8?B?UDlOa3FMVm5oQ2xGOTVkZU10TlJ0TzM5WkU5RFVOTGIxS0lhTTkwSTI1Y2FD?= =?utf-8?B?VEYzYllJdGJYQTA2RDEvQlQ2RXFMcWZpM2JtdDh5V0V1dC9FQlVocEVGSFR6?= =?utf-8?B?QlN6Yzc4V2ZZb29ROVdKdkRlYUdscXM0MzlqMGl0Zjd4NE51TU9KYVJDSUpj?= =?utf-8?B?bVhMaGY5cjlIeGttK3NoTGwrditubFJXd1hHVzhnajh5Z2loR0s5bm16UmVF?= =?utf-8?B?SDZIR0tIMzdFZkpwdjJ4RVYrMDBzSVVYc3pjVCtQcE5aRkxxZ0dhSWZPank4?= =?utf-8?B?Q0Z3Y1QwWWduQXZnK2kxaWtCNW9hTkQySlpOd3lvUUZiZkpVbDRIL2FpZHlT?= =?utf-8?B?YXkwUW91VTF0SGU4YjYyNVpUTGlUY0t3K25aYTdweGdYaWRmK1VPNlJyTS9s?= =?utf-8?B?R1FQRVJDNjJXa0hUT2tvVHFhRnlyWkVvMHovenpCOG9icjBUdTIzTmpST1l0?= =?utf-8?B?aXd0YlpiQWhPcmM1MXNtNzVsYlprY244Z3ZVd0JTdGU0Q2k0eHQzTURUaUls?= =?utf-8?B?OWl2YjFTYUxaVmUva2dzemRWcmgwKzllKzdPU1NHd05ybWJ5azFzdGJXRy9N?= =?utf-8?B?TDRjUEtGQStZZzRJTGVIVGtlTi8velduZGx1dXYzZG1DQUMrQ1lqM2xmWmFp?= =?utf-8?B?NG5zaW1BSUVrRmZ3N2ltY2JYZzREU2UxTXlHVmplRGpCU21OTHh3Y0xjMGpN?= =?utf-8?B?a2MrYjhjd3dkTTh1NzFtV3RPNDViU3lOb0RMaE5LTE5wdnlxS3liODVXSVRB?= =?utf-8?B?eTRuWXlHamljWS9TS0RoZm9hQmFwRlVuWnN2ZlN4dExXVGg1aWR2NVR4cUg2?= =?utf-8?B?YUVwYlR3WmZ0Q0NHTW9NdDMxL2JueG9aeTEvYk1obW03TmNzM2FHa3N4OWZE?= =?utf-8?Q?pEIDX8UwnzPjpMGyDOD2tpndy?= Content-Type: text/plain; charset="utf-8" Content-ID: <0DF87CD49EF9F145985C734F4A554481@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5944001-b3db-41e8-a983-08da9fc285f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 13:25:04.5793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LqsNQ6vGzB65Vop1iTFRvAgXiMSYwHZi5GH+twIot4mHCKDy0bDHAztHEuTPYkUOLNPiRM1IZ4L12BfFgHrrzIl5/bcCp6wONKNaiKUcEd4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6037 T24gMjYvMDkvMjAyMiAxNDoxOSwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K PiBPbiBNb24sIFNlcCAyNiwgMjAyMiBhdCAwMjowMjoxM1BNICswMTAwLCBBbmRyZXcgQ29vcGVy IHdyb3RlOg0KPj4gYnVzdGVyLWdjYy1pYnQgaXMgYSBkZWRpY2F0ZWQgdGVzdCB0byBydW4gYSBu b3QteWV0LXVwc3RyZWFtZWQgY29tcGlsZXIgcGF0Y2gNCj4+IHdoaWNoIGlzIHJlbGV2YW50IHRv IENPTkZJR19YRU5fSUJUIGluIDQuMTcgYW5kIGxhdGVyLg0KPj4NCj4+IEZvcmNlIGl0IG9uLCBy YXRoZXIgdGhhbiBoYXZpbmcgNTAlIG9mIHRoZSBqb2JzIG5vdCB0ZXN0aW5nIHdoYXQgdGhleSdy ZQ0KPj4gc3VwcG9zZWQgdG8gYmUgdGVzdGluZy4NCj4gU2hvdWxkbid0IHRoaXMgam9iIGJlIHdp dGggYSBzdGF0aWMgKG9yIHJhdGhlcjogYWxsIHllcykgY29uZmlnPw0KDQpUaGF0J3MgYSBzZXBh cmF0ZSB0aGluZyBuZWVkaW5nIGEgcmV2ZXJzaW9uLi4uIEN1cnJlbnRseSBtYWtlDQphbGx5ZXNj b25maWcgZGlzYWJsZWQgQ09ORklHX0hWTS4NCg0KQnV0IG1vcmUgZ2VuZXJhbGx5LCB3ZSBoYXZl IGEgcGlsZSBvZiBjYXNlcyB3aGVyZSBkaWZmZXJlbnQgY29uZmlnDQpvcHRpb25zIHByb2R1Y2Vz IGRpZmZlcmVuY2VzIGluIHdoaWNoIGFuZC9vciB3aGV0aGVyIGEgZnVuY3Rpb24gcG9pbnRlcg0K Z2V0cyB1c2VkLCBzbyBhIHNpbmdsZSBsYXJnZWx5LXN0YXRpYyBjYXNlIGRvZXNuJ3QgZmluZCBh bnkgb2YgdGhlDQppbnRlcmVzdGluZyBjb3JuZXIgY2FzZXMuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:33:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:33:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411823.654897 (Exim 4.92) (envelope-from ) id 1ocoF5-0006yq-UU; Mon, 26 Sep 2022 13:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411823.654897; Mon, 26 Sep 2022 13:33:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocoF5-0006yj-Rf; Mon, 26 Sep 2022 13:33:51 +0000 Received: by outflank-mailman (input) for mailman id 411823; Mon, 26 Sep 2022 13:33:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocoF4-0006yd-MH for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 13:33:50 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d93f48dc-3d9f-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 15:33:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d93f48dc-3d9f-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664199228; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+iWJh2teJfYo5bZzC6wUGDe2pUONmfdEHqMUy5eWPPQ=; b=MLdfO8UORZTgjlJejL8ZJGKgefSs186eF8tplsXwZ9ayTPIKlQ2BvfsB 26+tPzGdBLR1rqNvlkw+iVS4rV5/50yYjXmEy1PM+93eJ7mDLZHnfpK6K PLg30k5RX3NVIA65+baolk4XxnXoHjQ0Y6G7ShVlpd+jAg84JP97XCmDb 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81008815 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Gc/vPK/j4x5rCqb0bqI0DrUDnn6TJUtcMsCJ2f8bNWPcYEJGY0x3m mseXm2COvneamemett2boqzoxgHvZTTnNY1SVA5pSA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gFaYDkpOs/jZ8EI14qyr0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGU083GbA8pMpLPkZD1 uIVGAA3ZSiGvrfjqF67YrEEasULKcDqOMUUu216zCGfBvEjKXzBa/yUv5kChm52350QW6aFD yYaQWMHgBDoahtTOlARGdQmkf2hnHXXeDxEslOF46Ew5gA/ySQhieC1YIqMJ7RmQ+1prByfl lr31li+PQ42GcTclwW57H2j07qncSTTB9tJSezQGuRRqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDRdDnUxq1iHWNpBIbVpxbFOhSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ lqIlNPgAXpoqq+YTVqU87vSpjS3URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDobqgNzRJBWu7 wy1iyUdmbgjvfQA76CCqAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bct/HEwDpU Gws3pHHsbtQVc3leDmlGr1lIV2/2xqS3NQwa3ZLFoJpyTmi8mXLkWt4sGAnfxcB3irplFbUj K7vVeF5vsU70JiCN/Ufj2eN5yMCk8Dd+SzNDKy8Uza3SsEZmPW71C9vf1WM+GvmjVIhl6oyU b/CL5jwVC1CWPw2l2PqLwv47VPM7nFW+I8ubcqjk0TPPUS2PRZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9iizpNbWO3CPmbP/2HhQchDX87iq9JEMHgNCSyI6cFwc5wj5nOlwKtE0wfQK/goKl 1nkMnJlJJPErSWvAW23hrpLMdsDgb4XQaoHABER IronPort-HdrOrdr: A9a23:vGVAaqtRohzbWMjPCpHNk+3w7skDdtV00zEX/kB9WHVpmszxra 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IObuEYZmIasS+V2maFL+o= X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81008815" Date: Mon, 26 Sep 2022 14:33:38 +0100 From: Anthony PERARD To: Stefano Stabellini CC: Michal Orzel , , Doug Goldstein Subject: Re: [PATCH 4/9] automation: Add Arm containers to containerize script Message-ID: References: <20220922134058.1410-1-michal.orzel@amd.com> <20220922134058.1410-5-michal.orzel@amd.com> <52a75038-7aa0-fb2e-6f4a-1cb749e886a6@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Fri, Sep 23, 2022 at 03:23:26PM -0700, Stefano Stabellini wrote: > On Fri, 23 Sep 2022, Michal Orzel wrote: > > Hi Anthony, > > > > On 23/09/2022 15:56, Anthony PERARD wrote: > > > > > > > > > On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote: > > >> Script automation/scripts/containerize makes it easy to build Xen within > > >> predefined containers from gitlab container registry. However, it is > > >> currently not possible to use it with Arm containers because they are not > > >> listed in the script. Populate the necessary entries. > > > > > > FYI, those entry are just helper/shortcut/aliases, you can use any > > > arbitrary container with the script, it just more annoying. > > > > > > Your patch here allows to write: > > > CONTAINER=unstable-arm64v8 automation/scripts/containerize > > > but you could write the following instead, for the same result: > > > CONTAINER=registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 automation/scripts/containerize > > > > > > I wonder if the script could select the right container base on the > > > architecture of the host, because "alpine" and "alpine-arm64v8" will not > > > both work on the same machine. It might be nice to just choose "alpine" > > > and the script would select the x86 or arm container automagically. Just > > > an idea, no need to do anything about it. > > I'm not in favor of adding the automatic selection based on the host. > > The reason is that on x86 you can run both x86 and e.g. Arm containers. > > You just need to use register qemu-user-static [1] to perform emulation. > > This is something widely used and I use that to test Arm images/containers on x86 host. > > So you can run both alpine and alpine-arm64v8 on the same machine. > > Yeah and modern Docker sets up qemu-user-static automatically without > the user having to do anything. Anthony, you can try it yourself: you > should be able to just: > > docker run -it registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 > > on your x86 host if you have a docker new enough No, it isn't so easy, there is at least one step that might be needed, actually having qemu-user-static on the machine. But thanks to both of you, I've learned about qemu-user-static, and that it isn't necessarily complicated to setup. It is actually very easy to setup once we know what to look for, I've just had to install a packaged called "qemu-user-static" and that's all that was needed for the above command line to work. Installing that package worked on two different Linux distribution for me (on a derivative of Debian stable and on Arch Linux) so it's likely to work in many cases, at least on x86. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 26 13:59:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 13:59:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411829.654907 (Exim 4.92) (envelope-from ) id 1ocodT-0001AZ-Ur; Mon, 26 Sep 2022 13:59:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411829.654907; Mon, 26 Sep 2022 13:59:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocodT-0001AS-Ry; Mon, 26 Sep 2022 13:59:03 +0000 Received: by outflank-mailman (input) for mailman id 411829; Mon, 26 Sep 2022 13:59:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocodS-0001AM-D2 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 13:59:02 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e3ff980-3da3-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 15:59:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e3ff980-3da3-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664200740; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=igOAg8Km36khMPOK3G+/c3ee4TmVBbxeCHM60FnwBcE=; b=FnVL3S4j9AZfnaJIR9xwYY6KVsVNfLnli3hw4Nj7OG2yTOPlBUnDkqQs 0gaXhqX/SFs4AtemJfSCZ4+AjyuZoIGNIT4+SLL26A30Du6faNVjD0D4M /p6V/xrRihzNyqmijXWZ8HMQV7v3jKz4bgRfM/YpXz+3lnyFo29AM+OUM U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81782061 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5lInTaJh59MZ+BBRFE+R+5UlxSXFcZb7ZxGr2PjKsXjdYENSgzQAy TQcWTiCP/iIZDameN5waInnoEhXvJCGyNQwSQJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/PZ9ks21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEzKktPkI8I4ki+vtWHjBX+ L8SGjxUR0XW7w626OrTpuhEg80iKI/gPZ8Fu2EmxjbcZRokacmdGeOQv4YehWpuwJAVdRrdT 5NxhT5HZRLcYxpJKxEPBYg3huuAjXjjaTxI7lmSoMLb5kCDlVMhiuCzabI5fPTTHtlqg0OG/ 1vh1H3IBRMBLvCmwDmspyfEaujnwnqgBdN6+KeD3t5nhkeCgFMaDhI+XEG+5/K+jyaWUNtFJ 0sZ0iEnt6Q1+QqgSdyVdxi5q36NulgbQchdF8Uz7Q3Lwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qyPsTq4NCwRLGkDTSwJVw0I55/kuo5bs/7UZo89Sujv1ISzQGyuh WDRxMQju1kNpcFXlJe4907DuTKxh4eYVwN27DfbB0vwu2uVe7WZT4Cv7FHa69NJI4CYUkSNs RA4piSO0AwdJcrTzXLQGY3hCJnsvq/Ya2OE3TaDCrF7r1yQF2ifkZe8Cd2UDGNgKY46dDDge yc/UisBtcYIbBNGgUKaCr9d6vjGL4C6T7wJtdiONLKih6SdkyfZlByCnWbKgwjQfLEEyMnTw 6uzf8e2Fmo9Aq961jewTOp1+eZ1mHxnnjuCHcGglkjPPV+iiJm9GN843KamNLhlvMtoXi2Mm zqgCyd640oGC7CvCsUm2YUSMUoLPRAGOHwCkOQOL7brH+aTMDt+YxMn6e9+JtcNcmU8vrugw 0xRrWcFkguu2CyZeVrih7IKQOqHYKuTZEkTZUQEVWtEEVB5CWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:zocl+KjlVRXJOOCA5ggImTGH43BQX1B13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftWjdySOVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNykwsS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Lk1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoOOCXMsLlbFtzfsHfoWG1TYczDgNnzmpDt1L8eqq iDn/7nBbUw15qeRBDxnfKn4Xic7N9n0Q6f9bbfuwqonSWxfkNEN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3am+a/hGrDvAnZMZq59ms1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgn/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9MKOM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaCqDgDKFC66 gpfGkoxVLaIXied/Fm9Kc7gyzwfA== X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81782061" From: Anthony PERARD To: CC: Stefano Stabellini , Michal Orzel , Henry Wang , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH] automation: Information about running containers for a different arch Date: Mon, 26 Sep 2022 14:58:38 +0100 Message-ID: <20220926135838.47330-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD --- automation/build/README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/automation/build/README.md b/automation/build/README.md index 00305eed03..5d4734bc77 100644 --- a/automation/build/README.md +++ b/automation/build/README.md @@ -102,3 +102,14 @@ make -C automation/build suse/opensuse-tumbleweed PUSH=1 [registry]: https://gitlab.com/xen-project/xen/container_registry [registry help]: https://gitlab.com/help/user/project/container_registry + + +Running container for a different architecture +---------------------------------------------- + +To run for example an Arm container on an x86 machine, simply install the +package `qemu-user-static`, and that it. Then you can start an Arm container on +x86 host like you would start an x86 container. + +If that doesn't work, you might find some information on +[multiarch/qemu-user-static](https://github.com/multiarch/qemu-user-static). -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:12:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:12:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411838.654919 (Exim 4.92) (envelope-from ) id 1ocoq1-0003gI-8F; Mon, 26 Sep 2022 14:12:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411838.654919; Mon, 26 Sep 2022 14:12:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocoq1-0003gB-5A; Mon, 26 Sep 2022 14:12:01 +0000 Received: by outflank-mailman (input) for mailman id 411838; Mon, 26 Sep 2022 14:11:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocopz-0003g5-Qo for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:11:59 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2080.outbound.protection.outlook.com [40.107.95.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2dfaaa0b-3da5-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 16:11:58 +0200 (CEST) Received: from DS7PR05CA0093.namprd05.prod.outlook.com (2603:10b6:8:56::17) by PH7PR12MB6954.namprd12.prod.outlook.com (2603:10b6:510:1b7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 14:11:54 +0000 Received: from DM6NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:8:56:cafe::17) by DS7PR05CA0093.outlook.office365.com (2603:10b6:8:56::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.14 via Frontend Transport; Mon, 26 Sep 2022 14:11:54 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT096.mail.protection.outlook.com (10.13.173.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 14:11:54 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 09:11:52 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 07:11:51 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 09:11:50 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dfaaa0b-3da5-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZfv5WvdUoEXBpw8fgb0AC5X0zcqnSIqupHIqvDp2qYPUkAqbQYTHmV+EObQ44EqmL5lj4qJVweo8vOdkJ7T6FYMRjXp2vRAJCPdQgWtqkp1DE5EVDaob9Aumz6uQzCltD6i8TAhVkWqyyN5SkrwOrCHBcnL074A14vuQT3CL0iZlNPOj98Sz2nsmynPB/MoRJkwS8srulIfYL6p4FATj0+UecZ6h6yw6r+qSFdMdRWO6CNJSIY+31vsJb4HB15kw/qDXNNElcQltLaym8z1EbUlCJ/R0KTJuYbo4BHehJuPNOm2j1FFq7idx1vp2xeaWz3xtt7XTK4y/j+PUKI/uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aCa7RgRCiHaQKLpAtV0Bhm/P6jTdXlqnwn1Nce48kS8=; b=XJO/Mh5USe17wziN2c3ENSG8nIWhPYCfW5MM2MBxr0tzO54E5eMILfvnqXG4poWY0xcP0dnk8ZQNMiMnF+n1xae0fiZ6+MI6BYgtFK9Isigil5eyvKh+KcU/62hgoLGWiUr5mUdfiO99hRPCwiav/pCBSlPMsF84AZagPw6hDUJWEVO/LHfIUnKL9qDViKzwfSBdnVpPO2zk1Vk0SUc0BItT25sT1K/UiREBnNx66AYMRRAb6WR/FiYsRKFor/230t0iUJ35+A8VuDaJ23/jw8nYhjVSkvUev1insQ++Nbgo2q20WmFh0I1+Z9XegARBCQbZLYIZfZ58EZPKMM75Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aCa7RgRCiHaQKLpAtV0Bhm/P6jTdXlqnwn1Nce48kS8=; b=MFevuEtc6ErQKfMSXU94uXH8sFbLtE55NFcAvLaeurgFtdPsz7lJu9S8nt1C9s1jCPpRlnq7gZ3y2wvl7mDFPrWstkvwJK0bvWoo3gLTQYh3vKCWl9DWA6o6ItdyJ7iknEu/JmFQoby+Io0Op4sgHME4v1ETCAoTyCOiGgWDKLw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <1370699b-f625-7d73-3e4d-104567660599@amd.com> Date: Mon, 26 Sep 2022 16:11:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [XEN PATCH] automation: Information about running containers for a different arch Content-Language: en-US To: Anthony PERARD , CC: Stefano Stabellini , Henry Wang , Doug Goldstein References: <20220926135838.47330-1-anthony.perard@citrix.com> From: Michal Orzel In-Reply-To: <20220926135838.47330-1-anthony.perard@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT096:EE_|PH7PR12MB6954:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b472f28-e7c4-44fc-3bb1-08da9fc910d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o6WirtcHbgeEFtHIcExqjnpq/bl4Ugiol0qYWk9rZ7V/7xudVLTcv515yzGkedSL/V7i/9DVs8qZtoJtNPuKNtHEPi0MucYR6edLvEywJV+ZqBSNY6e0MqV528wlBSk0aHxt5tGee2s44Hy4sffnKeUp3xx+0fnVxN8FimYe989aRlPUGlDsNnzzezlbXq0dRQIcoHm9O1TFoi3zUm/gzf4k10D81zyzemD5IvpUIdjjLi+CR+5UAwUG1v1fwCcSgqtmvrRl8E658ER9D9mRJELABPfSVU3ye8pk4a09bJbV1kACOY/cZn5zCzP5frJxHOiHq3TvkxpC+DOhf/S76BLoZKqMoqg6SiKNQ6JZaE40NJEvJ0Hh5DVgikBw7P9LkGmKEH9gsXfUbhscrbGJ5LY4nHMSpgJqVQ4AKC6i3nz6d38yB6dHHtO7tVEVv2rlppsMz2cicKOEJyWjSrz6k9a+hJSX5nT18F4TUWrgOeiZNUOYqC99caREdpaZV/QM91K/8IuEUXMkiSAqqelIJRaj1lHwVJQZe+O5mFqC/m2wPcCmlOl6Fa9JCFRWsLNb2nK7IYYbOzHnuJCpvhK9F6jpQBoHFAfpKtaeoyxvKalNLU/VKqTKspx8xr7NlALm0xGWprc7WPoCAYXL+Idy42h7giU44al1kobpnw/Syaz+BsdeTr5Ne+oI0mFxMl/BiCLer+pPN8Rhu/ZKjq21AtuqEopX3vk+lC4bJocmDhW+9jTJQmU9ENCjoXL23st5dwBtjwCvQ/gDx+G17KuKv7cd0FLYoqtol7tTIC0ewXvU/kzgoK+9gW4nIC2l/pgN4Jn3f9H7fjVNiZKbhE1ioiFsax41XoVt7Pkh9ObXydzBeIhklYFDuBNyLXW5Yb5nOmUpmFi8e+LoUyytB1X93Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(40470700004)(36840700001)(46966006)(26005)(2616005)(2906002)(5660300002)(44832011)(53546011)(47076005)(186003)(83380400001)(8936002)(426003)(81166007)(36756003)(31696002)(40480700001)(86362001)(36860700001)(40460700003)(966005)(70206006)(70586007)(82310400005)(356005)(336012)(31686004)(478600001)(54906003)(110136005)(16576012)(4326008)(316002)(8676002)(82740400003)(41300700001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:11:54.4905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b472f28-e7c4-44fc-3bb1-08da9fc910d5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6954 Hi Anthony, On 26/09/2022 15:58, Anthony PERARD wrote: > > > Adding pointer to 'qemu-user-static'. > > Signed-off-by: Anthony PERARD > --- > automation/build/README.md | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/automation/build/README.md b/automation/build/README.md > index 00305eed03..5d4734bc77 100644 > --- a/automation/build/README.md > +++ b/automation/build/README.md > @@ -102,3 +102,14 @@ make -C automation/build suse/opensuse-tumbleweed PUSH=1 > > [registry]: https://gitlab.com/xen-project/xen/container_registry > [registry help]: https://gitlab.com/help/user/project/container_registry > + > + > +Running container for a different architecture We need qemu-user-static also when building a container for a different architecture. So this should be "Building/Running a container for a different architecture". > +---------------------------------------------- > + > +To run for example an Arm container on an x86 machine, simply install the > +package `qemu-user-static`, and that it. Then you can start an Arm container on s/that/that's/ > +x86 host like you would start an x86 container. > + > +If that doesn't work, you might find some information on > +[multiarch/qemu-user-static](https://github.com/multiarch/qemu-user-static). This is also missing quite important information that QEMU emulation using qemu-user-static only works for x86_64 host machines. This means that you cannot build/run e.g. x86 containers on an Arm host. > -- > Anthony PERARD > ~Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:12:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:12:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411839.654930 (Exim 4.92) (envelope-from ) id 1ocoqB-0003yI-Gc; Mon, 26 Sep 2022 14:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411839.654930; Mon, 26 Sep 2022 14:12:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocoqB-0003yB-Dj; Mon, 26 Sep 2022 14:12:11 +0000 Received: by outflank-mailman (input) for mailman id 411839; Mon, 26 Sep 2022 14:12:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocoqA-0003g5-0U for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:12:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60079.outbound.protection.outlook.com [40.107.6.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 352ece01-3da5-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 16:12:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8606.eurprd04.prod.outlook.com (2603:10a6:102:219::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 14:12:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 14:12:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 352ece01-3da5-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SGjedAt5LvOUbUoZZWL1nrjqk1q/xovloSOD3YVRp/eVa64ydm0p8S+Z5SrVDvQLLaNndV+EsI12LntULKzJ9aSdUPvkgLp1RjjBUG5d0Vm/5S12bgMC5M2bSgJjWC0rcOtUzoiD57sMqdTFRhEJntCqrKKV/FeOz42VBZ2kjTwLg4J8L42gC1Q8WrQoh7npX+mv9IyXYN8Ozks+hSJZX7fyBkPXTit8+I51fKjD8e8Spauk1vXdLS6NiZjmrl4QFcawdRuBLyrAQyqcyrv4robe7XRtmZWyG/+CTZLLHReCaxKg1FOibuTjlzebq982OVSCk3uuj+Nlm02qwfGdyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DSRAV75Y5wCa+r/oerAKcadQ7Kh0D2ALzJ5y9/KYUlY=; b=Pl4RpAOzn2ZYcQSDfuWGE8BxtHLAT2nwxHAL/Qwt2mDaHvUI08VEeFvY0vhoLZhC58S6L4P7JFNTaMgwSiyFG4qUwJXm+yh9WAzkgajH/ylBo7S45amlWsv5v5JrV7nn+/TA+5tNCX7avuCnr7l7uYhOTH9D5eGN1I0CWnOlJhU0fZ0N29zeYKkxChhJTMe7jwQy+3K8yjTvZ+WGoliNXJblJd8CrL1v4pYipmhEZCujDP1XprF+L20Rav/uPzKu9ObYAjYLS/rLw0YczE2ZynRXHeH+adBDineiRQoyztJl34vHSyLTUaiaSyuATM7wnSBmgeSygcvAN73TUu3Zhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DSRAV75Y5wCa+r/oerAKcadQ7Kh0D2ALzJ5y9/KYUlY=; b=19ldJhXOTT3VaFXigtrbJZyMUa6XTe/n8/GGVzG7TV0e9y6LFU62w4a8ikBloV+O6KG0gsKxBZEwP38K9Pf5yY+wtNroK6Ohd5TOiOSlvgmC/1SRl5PydYwkdz37sy5WQfxnSHWMe4XqYTRKm1R/vq98qIiHOhRpt6WRPnGWpJ0JiXlHm660VaHMdYIZXacaLfj4ysfxI0dylnq+PWM38QJtjKhjFDvGtqxKarIkyCXGZX5db84H54/pMVROOZnmPUYxLY1clIj2JhNVIgdXQhbWL4sQ0BZcH3jhc+4mwYpxQLl4OhMqFXdwgNfLktuVhx3rwMrHO616b0IeT5LUCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7a469ef7-5ad7-5abf-2c1f-fa29496fa2a5@suse.com> Date: Mon, 26 Sep 2022 16:12:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Boris Ostrovsky References: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> From: Jan Beulich In-Reply-To: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0158.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8606:EE_ X-MS-Office365-Filtering-Correlation-Id: c940f4fc-7e9c-4253-2a1c-08da9fc91847 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wUo5C84Uqx3UvZv6tY+E+7ukbcdOgEmjhtkMgILmSBLkOcaJkGgkoE5TajhFs428l39er9o+F44lRUHdDM+01Oxzff8pZW/xBx4Y76QgyLwGuaNxUioLxWQmMaYJJp2/2oRl6dagTKmvcsbpZoOzl/YMonfsehQ/GH+JhTTiPmBYpXfpqmFuk6DED98Ai8xPKhjrv1hyAN+R0cgOkHMkI5mWfvM/WicjG8N/F54thVgbcgpzbb/zU+Zq1z27gwk2oLn/7gyEExoFuvT5Xbxk/uxziWgttNBSevJgB6XiCux55r4A/U9YDfeT2hWqW08Dshu1cc0DEOQ1Kyv/0NgFyvoe3CeiF9Xvtm7rDKIYb9JVMs8wRYTRqxdnqi6p9Wo2oLpSyaIkHkaoqOsDCWrZb97gpCwGfdvThx04Ayd9cjTgrJisX65YfjQ/xAdj0YflqZwvGqQRp9SNK2I82m5jlJuIZtA1LCYEDw395vBhxgU+Wjx1QeXX8PFgery/5S7WwDKhzVftkrlFMvQP2nqHTxWiJgVMtSeurR5WPod7qK7Xy5d5z2KSj94rHTevtqs0TCCckUxkqYpKgVVcBfEbvRb9j8HyWqMZTw440svuBnXtUb6wxqxQ8NeQPK3xy+SzEul4PdngB6mlU16/Ee7ER2ft8Dz+da1xH3tvV62EiqpVAmUJeA+saE2qlBsTL+ywrBxWzO5YwM25KWiBgKL7MJF+eWWuYxTjIi6sbf5+rgyHKJ6FOR9589vEdEzFQz5h27D0nrtF7Rct6RpBErQ/icVvLu7nVbkKyuUBAi3nQa4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199015)(2616005)(5660300002)(478600001)(66476007)(2906002)(4326008)(8936002)(66946007)(36756003)(83380400001)(66556008)(186003)(8676002)(86362001)(38100700002)(6506007)(53546011)(6512007)(26005)(31696002)(31686004)(6486002)(6916009)(54906003)(316002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1ZabG9mYzFVVm5aaitaQU9MYnpyUHJ2NFlUZmVOaG44bjdjNEd3WFRnemlD?= =?utf-8?B?c0dqaWptWk5uMkhRcWp0RHBmNityWEtSWmU5b2srcHhXYXBXd2REQ1JWbFdX?= =?utf-8?B?VFQ3MGxRYmZLSHBPZ3hsZTRkSVViSVYxVk44bmdNUDUzWk56bnFaZXRzUDNW?= =?utf-8?B?Q1FOaHp1MEpZTWJNL3BldFFUcnhTeEw3Y3JrckdlVEE3ZnJjckc1Y01XYmVy?= =?utf-8?B?OTRrZEo1N3NrZTNDR2JqYnVaaS8rU0VYaS9xTnRoanNhakV4RnlkY01rdkJB?= =?utf-8?B?d1paVkd0TVA2UHVKOG9ObjBnMU91ZTRucmZ5QzJqeEwyNUdqenNqRi81dGNx?= =?utf-8?B?emxLa2NnSDJOdXhVV1UvTU5ZM2lLMkdrdlArb0lISjhLbjdZZXUzbDNaVEtM?= =?utf-8?B?UW9pUDNNUGIrb0w3TnZWK1lVY2V0WjVjRzVJZE1OanlVVG5hRFM4V292emtV?= =?utf-8?B?ak45Uy8waXhFZU9yZ0tDSGMyMnNYQzJ2c3I4b3RMcTBHVkdSL2NXVk5JM3JH?= =?utf-8?B?enVNVUs2ZThlS1liN0hGcWp3SE5nVjBFOFRyK3BaSTkrZEpxZlVZNEhKd3Uz?= =?utf-8?B?MGZUdE9GcXNBWTdqWFlpRndzNUVmWWIwNmpSejNWVjVVdlYzMTJvRmRMSkor?= =?utf-8?B?MmNIOFI1OHNHZmxGd2R3bVQxLzB6dkJ2MnRPNjZUaWpXbjRpUHJuSHJ3SmI2?= =?utf-8?B?Ym0wa2tTSjFyVTFWYU9TVlNqV0FKUytXMkdkWjV6aDR2UlV1akxrT1lEL0Ey?= =?utf-8?B?OXpwK0lCVDZiTVhWbU9sdVNRZy92WncwaEZKNGJmL3haRjVMQVhNSFh1eDN3?= =?utf-8?B?enNlcEo2dDM2Z093V2F6K0orQVVuVWp5VlpOOGVxUXFCRXRkQmxqTTBBTllq?= =?utf-8?B?QXhENFY1QllCay9WL1VjTlZzYTExRTlLRk5nWStTeCtXNzFmQ2ViblZobVNa?= =?utf-8?B?TnZGdTJsbHBwSVpEV2Rja3lja25mLzlYVXc3dGFGTi9IZHRpaGVsQjVnRUla?= =?utf-8?B?Z2hxckNOTk53OWNsOGRnVUxnMGxJenZBZi96eG9nUFpleWlMSi9BT1EwZ2Nv?= =?utf-8?B?K3FZTmRaemphMGg2ZHZlSUVXdm1aQzE5cHd5NGgvODdVWElZNkY0ZDZleEMr?= =?utf-8?B?NFBjSmNXdXJ2dWpGQkt6SFJLVGp1WHFwZFE4L3pmYm90K3hkTndZUzFtZXRM?= =?utf-8?B?T3RjZGZRUkxzRlIzTXFFMDhRdWxmdGtackUvck5PVWtkUDd5ekJDdXorZGZ6?= =?utf-8?B?VklqU1Z1Z24reUpURllHNXBxb0F1QjZickVCcFFrS3ZMZnFIK1ZnT0pCaG9j?= =?utf-8?B?SCtIV0lURzIvbGdUL0tBc0kvZEZtbVpyNkZIc1hKWG9vN1RuZVFwcFBpeU9X?= =?utf-8?B?YVZaNTJ4YldyK1hSaXgvTG9qOVg3SzdVVXBZZTYrMHI1UWlKcDNWWmhQS1Rm?= =?utf-8?B?cFpGL1VDNzJHSXJMczllYkZXR2tiZytqNmdoK3RzRDdSWUlGQStxdVduWEJ4?= =?utf-8?B?UEEyZmp2NHJqQi8yMUNaYnBrQUh2c1ZJc3ZzMExCRkJMK0NKNWV0dWIxdUJy?= =?utf-8?B?QjNMNmJMWmswUHFrNUFWMEJ2UG5EVU4xNDJtZGVUank5b054L3llRndFcVBI?= =?utf-8?B?d3o2emZlY1dwckdycWNvRDFycStHNGtoNkN5cnY4UldWTUowaXowWExjZEpM?= =?utf-8?B?NmNyaFlVTFlvRUlaK2dRYVc1R0E0eFhXZWdaazNYK0xwWXMxT0NtTFRRb2Yw?= =?utf-8?B?N2p6K3Vaa2ptZFowVlZPdFdocm9EekYzYWRvWCtJNDFxc3ljLzFKOXBKQ3JF?= =?utf-8?B?aVpMdmYxRGZlSjVGRWVXRjNPeTAzOWc3ckNyS2JVUXpZRnozZ0NrUElpOWJK?= =?utf-8?B?eVlQaHRtVHBwR2hsVGtoUnRLaWp2WTdCYTdOM0prdVczMzIwZ1FMZDRSQTd1?= =?utf-8?B?V0hGQTRycXA1bTFBWDkvT3FPd015ODFaVXlOSFRKQzF4a2dHRStaWHdpZWxs?= =?utf-8?B?VVdhMUJDK0hNT2RjWGM4SW81YTliQkUxR0YyR3Y4ZzNoYjdud1RweWl4cmZP?= =?utf-8?B?bzlXK0g2U2d0VnVsWkVFU2xDU2c2bzVtaTlkK0kvQXhkV2ppdjZoOFV0bU41?= =?utf-8?Q?zRPKGAQH8NKjvIkAhCqH1EYqg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c940f4fc-7e9c-4253-2a1c-08da9fc91847 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:12:07.2156 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MjqyatdaPz8+aEHcXEm+/v1LqYGai2Z2rBpn+Q7Ndm35qjrwqLa7n4HJlv3+tu+BFaqiIQ/0qJx3dx2RzNhm/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8606 On 22.09.2022 22:48, Tamas K Lengyel wrote: > --- a/xen/arch/x86/cpu/vpmu.c > +++ b/xen/arch/x86/cpu/vpmu.c > @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) > vpmu->last_pcpu = pcpu; > per_cpu(last_vcpu, pcpu) = v; > > + vpmu_set(vpmu, VPMU_CONTEXT_SAVE); > + > if ( alternative_call(vpmu_ops.arch_vpmu_save, v, 0) ) > vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > > + vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); > + > apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); > } > > int vpmu_load(struct vcpu *v, bool_t from_guest) > { > struct vpmu_struct *vpmu = vcpu_vpmu(v); > - int pcpu = smp_processor_id(), ret; > - struct vcpu *prev = NULL; > + int ret; > > if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) > return 0; > > - /* First time this VCPU is running here */ > - if ( vpmu->last_pcpu != pcpu ) > - { > - /* > - * Get the context from last pcpu that we ran on. Note that if another > - * VCPU is running there it must have saved this VPCU's context before > - * startig to run (see below). > - * There should be no race since remote pcpu will disable interrupts > - * before saving the context. > - */ > - if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) > - { > - on_selected_cpus(cpumask_of(vpmu->last_pcpu), > - vpmu_save_force, (void *)v, 1); > - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > - } > - } > - > - /* Prevent forced context save from remote CPU */ > - local_irq_disable(); > - > - prev = per_cpu(last_vcpu, pcpu); > - > - if ( prev != v && prev ) > - { > - vpmu = vcpu_vpmu(prev); > - > - /* Someone ran here before us */ > - vpmu_save_force(prev); > - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > - > - vpmu = vcpu_vpmu(v); > - } > - > - local_irq_enable(); > - > /* Only when PMU is counting, we load PMU context immediately. */ > if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || > (!has_vlapic(vpmu_vcpu(vpmu)->domain) && What about the other two uses of vpmu_save_force() in this file? I looks to me as if only the use in mem_sharing.c needs to be retained. Also, going forward, please Cc Boris right on new iterations of this fix (if any; I'm not going to exclude I'm wrong with the above and all is fine with this version). Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:19:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411854.654963 (Exim 4.92) (envelope-from ) id 1ocows-0005We-Pq; Mon, 26 Sep 2022 14:19:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411854.654963; Mon, 26 Sep 2022 14:19:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocows-0005WT-MY; Mon, 26 Sep 2022 14:19:06 +0000 Received: by outflank-mailman (input) for mailman id 411854; Mon, 26 Sep 2022 14:19:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocows-0005DG-1C for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:19:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d256888-3da6-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 16:19:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1F7321AA9; Mon, 26 Sep 2022 14:19:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8BECF139BD; Mon, 26 Sep 2022 14:19:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NfvmINi0MWOZBgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 14:19:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d256888-3da6-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664201944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2WIgyc8oeY+zl5KU1xJK3+56bjqBOzQeuZ/l6BD6ls=; b=qY8RvPXiIpmNppBtHhVvR/lcYb5+KrHTOtwch6dvTPWN8X/VLj6Cw/YIS2IJ+d1ByhjLv6 J/em/IezcFP+FLxo0JYsBoM3a1BAcvDVDlg27PUngju+UZucwdMDwAW0kSQx57aTdV54Yt FjdIzmNYyktbjc3IVUg5Yiuu9DvK60Y= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 2/3] xen/pv: refactor msr access functions to support safe and unsafe accesses Date: Mon, 26 Sep 2022 16:18:48 +0200 Message-Id: <20220926141849.21805-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220926141849.21805-1-jgross@suse.com> References: <20220926141849.21805-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor and rename xen_read_msr_safe() and xen_write_msr_safe() to support both cases of MSR accesses, safe ones and potentially GP-fault generating ones. This will prepare to no longer swallow GPs silently in xen_read_msr() and xen_write_msr(). Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pv.c | 73 ++++++++++++++++++++++++++++--------- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 0ed2e487a693..4e68e047df94 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -916,14 +916,18 @@ static void xen_write_cr4(unsigned long cr4) native_write_cr4(cr4); } -static u64 xen_read_msr_safe(unsigned int msr, int *err) +static u64 xen_do_read_msr(unsigned int msr, int *err) { u64 val; if (pmu_msr_read(msr, &val, err)) return val; - val = native_read_msr_safe(msr, err); + if (err) + val = native_read_msr_safe(msr, err); + else + val = native_read_msr(msr); + switch (msr) { case MSR_IA32_APICBASE: val &= ~X2APIC_ENABLE; @@ -932,23 +936,39 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err) return val; } -static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high) +static void set_seg(unsigned int which, unsigned int low, unsigned int high, + int *err) { - int ret; - unsigned int which; - u64 base; + u64 base = ((u64)high << 32) | low; + + if (HYPERVISOR_set_segment_base(which, base) == 0) + return; - ret = 0; + if (err) + *err = -EIO; + else + WARN(1, "Xen set_segment_base(%u, %llx) failed\n", which, base); +} +/* + * Support write_msr_safe() and write_msr() semantics. + * With err == NULL write_msr() semantics are selected. + * Supplying an err pointer requires err to be pre-initialized with 0. + */ +static void xen_do_write_msr(unsigned int msr, unsigned int low, + unsigned int high, int *err) +{ switch (msr) { - case MSR_FS_BASE: which = SEGBASE_FS; goto set; - case MSR_KERNEL_GS_BASE: which = SEGBASE_GS_USER; goto set; - case MSR_GS_BASE: which = SEGBASE_GS_KERNEL; goto set; - - set: - base = ((u64)high << 32) | low; - if (HYPERVISOR_set_segment_base(which, base) != 0) - ret = -EIO; + case MSR_FS_BASE: + set_seg(SEGBASE_FS, low, high, err); + break; + + case MSR_KERNEL_GS_BASE: + set_seg(SEGBASE_GS_USER, low, high, err); + break; + + case MSR_GS_BASE: + set_seg(SEGBASE_GS_KERNEL, low, high, err); break; case MSR_STAR: @@ -964,11 +984,28 @@ static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high) break; default: - if (!pmu_msr_write(msr, low, high, &ret)) - ret = native_write_msr_safe(msr, low, high); + if (!pmu_msr_write(msr, low, high, err)) { + if (err) + *err = native_write_msr_safe(msr, low, high); + else + native_write_msr(msr, low, high); + } } +} + +static u64 xen_read_msr_safe(unsigned int msr, int *err) +{ + return xen_do_read_msr(msr, err); +} + +static int xen_write_msr_safe(unsigned int msr, unsigned int low, + unsigned int high) +{ + int err = 0; + + xen_do_write_msr(msr, low, high, &err); - return ret; + return err; } static u64 xen_read_msr(unsigned int msr) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:19:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411853.654952 (Exim 4.92) (envelope-from ) id 1ocowp-0005EB-F5; Mon, 26 Sep 2022 14:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411853.654952; Mon, 26 Sep 2022 14:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocowp-0005E4-AD; Mon, 26 Sep 2022 14:19:03 +0000 Received: by outflank-mailman (input) for mailman id 411853; Mon, 26 Sep 2022 14:19:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocown-0005DG-Tk for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:19:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29bfadcf-3da6-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 16:18:59 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 26E0A1F461; Mon, 26 Sep 2022 14:18:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CFCE7139BD; Mon, 26 Sep 2022 14:18:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id L1Z8MdK0MWORBgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 14:18:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29bfadcf-3da6-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664201939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2HK44ajp1lbC5d5j3eVVMNpf685PGwbChjA5LVUn8U=; b=ri7oOJT3IepK3v9cmd+MT8FhkKA76sA90fa4F+C13EL0MykPKpTmwIbx9q/WgvfWRSURNr V9zK8rJK98uspTICV60Ydt/PN3znvEIiAdXmfC6Q8OOFBd3GZEYxdNsivznfEPDS0O6ZB2 5+es+r5FUNJU+VLRINnrUt5B2l0xrmU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP Date: Mon, 26 Sep 2022 16:18:47 +0200 Message-Id: <20220926141849.21805-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220926141849.21805-1-jgross@suse.com> References: <20220926141849.21805-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants of read/write MSR in case the MSR access isn't emulated via Xen. Allow the caller to select the potentially faulting variant by passing NULL for the error pointer. Remove one level of indentation by restructuring the code a little bit. Signed-off-by: Juergen Gross --- arch/x86/xen/pmu.c | 44 ++++++++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c index 21ecbe754cb2..34b4144f6041 100644 --- a/arch/x86/xen/pmu.c +++ b/arch/x86/xen/pmu.c @@ -293,22 +293,24 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read) bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err) { if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) { - if (is_amd_pmu_msr(msr)) { - if (!xen_amd_pmu_emulate(msr, val, 1)) - *val = native_read_msr_safe(msr, err); - return true; + if (!is_amd_pmu_msr(msr)) + return false; + if (!xen_amd_pmu_emulate(msr, val, 1)) { + *val = err ? native_read_msr_safe(msr, err) + : native_read_msr(msr); } + return true; } else { int type, index; - if (is_intel_pmu_msr(msr, &type, &index)) { - if (!xen_intel_pmu_emulate(msr, val, type, index, 1)) - *val = native_read_msr_safe(msr, err); - return true; + if (!is_intel_pmu_msr(msr, &type, &index)) + return false; + if (!xen_intel_pmu_emulate(msr, val, type, index, 1)) { + *val = err ? native_read_msr_safe(msr, err) + : native_read_msr(msr); } + return true; } - - return false; } bool pmu_msr_write(unsigned int msr, uint32_t low, uint32_t high, int *err) @@ -316,22 +318,28 @@ bool pmu_msr_write(unsigned int msr, uint32_t low, uint32_t high, int *err) uint64_t val = ((uint64_t)high << 32) | low; if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) { - if (is_amd_pmu_msr(msr)) { - if (!xen_amd_pmu_emulate(msr, &val, 0)) + if (!is_amd_pmu_msr(msr)) + return false; + if (!xen_amd_pmu_emulate(msr, &val, 0)) { + if (err) *err = native_write_msr_safe(msr, low, high); - return true; + else + native_write_msr(msr, low, high); } + return true; } else { int type, index; - if (is_intel_pmu_msr(msr, &type, &index)) { - if (!xen_intel_pmu_emulate(msr, &val, type, index, 0)) + if (!is_intel_pmu_msr(msr, &type, &index)) + return false; + if (!xen_intel_pmu_emulate(msr, &val, type, index, 0)) { + if (err) *err = native_write_msr_safe(msr, low, high); - return true; + else + native_write_msr(msr, low, high); } + return true; } - - return false; } static unsigned long long xen_amd_read_pmc(int counter) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:19:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411852.654941 (Exim 4.92) (envelope-from ) id 1ocowj-0004xk-5Q; Mon, 26 Sep 2022 14:18:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411852.654941; Mon, 26 Sep 2022 14:18:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocowj-0004xd-2y; Mon, 26 Sep 2022 14:18:57 +0000 Received: by outflank-mailman (input) for mailman id 411852; Mon, 26 Sep 2022 14:18:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocowh-0004xX-4v for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:18:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26422587-3da6-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 16:18:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 322F31F37C; Mon, 26 Sep 2022 14:18:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CC7D6139BD; Mon, 26 Sep 2022 14:18:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qBw/MMy0MWN/BgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 14:18:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26422587-3da6-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664201933; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=IJOwLXU5t8JM8hMm9HW6Yq2/D7SfLk9zyZ5L9cgxtWU=; b=JGtbcNXpGA40iBntCL6y1LJnluPYXxk3hzbip2fUXMIhzCg1Xn8jmfj2iOPpA9x6KAs9NW YFuKaG8NHm486HGNuT/bNwlh+6lojOUffG9Q/iTOc+B+uVsGcwYiAlYTbp+wKKlU1tnWOf b9Ixakc+U1inpqhbv2Gcq6mLZpRVhWI= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Jonathan Corbet Subject: [PATCH 0/3] xen/pv: sanitize xen pv guest msr accesses Date: Mon, 26 Sep 2022 16:18:46 +0200 Message-Id: <20220926141849.21805-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Historically when running as Xen PV guest all MSR accesses have been silently swallowing any GP faults, even when the kernel was using not the *msr_safe() access functions. Change that by making the behavior controllable via kernel config and via a boot parameter. This will help finding paths where MSRs are being accessed under Xen which are not emulated by the hypervisor. Juergen Gross (3): xen/pv: allow pmu msr accesses to cause GP xen/pv: refactor msr access functions to support safe and unsafe accesses xen/pv: support selecting safe/unsafe msr accesses .../admin-guide/kernel-parameters.txt | 6 ++ arch/x86/xen/Kconfig | 9 ++ arch/x86/xen/enlighten_pv.c | 97 +++++++++++++------ arch/x86/xen/pmu.c | 44 +++++---- 4 files changed, 110 insertions(+), 46 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:19:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:19:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411855.654974 (Exim 4.92) (envelope-from ) id 1ocowz-0005tV-2y; Mon, 26 Sep 2022 14:19:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411855.654974; Mon, 26 Sep 2022 14:19:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocowy-0005tO-VO; Mon, 26 Sep 2022 14:19:12 +0000 Received: by outflank-mailman (input) for mailman id 411855; Mon, 26 Sep 2022 14:19:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocowx-0005DG-Ne for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:19:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30a5c8d3-3da6-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 16:19:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8CD4D21ED4; Mon, 26 Sep 2022 14:19:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D18F139BD; Mon, 26 Sep 2022 14:19:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BwGjDd60MWOiBgAAMHmgww (envelope-from ); Mon, 26 Sep 2022 14:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30a5c8d3-3da6-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664201950; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=acJkGEJzQvXK3ntpRB7CEDesvJKyVtqSHHdOsYKLzIg=; b=i1dwUiOyCBw7IR7aEH1PBRg4a9gQzwDV01bgDjlihYYT+NCz760Ilh718xzjV+CMcd+1gU Ysl9/VyM6OsgmljS7s7h0UDr+PBJX3FQhki4eIpF0+Av66TnrmdN/ZlEiCcnlBWkWVVSNE WoPIKXRUUFnLgAouJlYWO//iNsY5ADU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jonathan Corbet , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses Date: Mon, 26 Sep 2022 16:18:49 +0200 Message-Id: <20220926141849.21805-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220926141849.21805-1-jgross@suse.com> References: <20220926141849.21805-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of always doing the safe variants for reading and writing MSRs in Xen PV guests, make the behavior controllable via Kconfig option and a boot parameter. The default will be the current behavior, which is to always use the safe variant. Signed-off-by: Juergen Gross --- .../admin-guide/kernel-parameters.txt | 6 +++++ arch/x86/xen/Kconfig | 9 +++++++ arch/x86/xen/enlighten_pv.c | 24 +++++++++++-------- 3 files changed, 29 insertions(+), 10 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 426fa892d311..1bda9cf18fae 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -6836,6 +6836,12 @@ Crash from Xen panic notifier, without executing late panic() code such as dumping handler. + xen_msr_safe= [X86,XEN] + Format: + Select whether to always use non-faulting (safe) MSR + access functions when running as Xen PV guest. The + default value is controlled by CONFIG_XEN_PV_MSR_SAFE. + xen_nopvspin [X86,XEN] Disables the qspinlock slowpath using Xen PV optimizations. This parameter is obsoleted by "nopvspin" parameter, which diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 85246dd9faa1..9b1ec5d8c99c 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -92,3 +92,12 @@ config XEN_DOM0 select X86_X2APIC if XEN_PVH && X86_64 help Support running as a Xen Dom0 guest. + +config XEN_PV_MSR_SAFE + bool "Always use safe MSR accesses in PV guests" + default y + depends on XEN_PV + help + Use safe (not faulting) MSR access functions even if the MSR access + should not fault anyway. + The default can be changed by using the "xen_msr_safe" boot parameter. diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 4e68e047df94..6b0e5d4c485a 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -108,6 +108,16 @@ struct tls_descs { */ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc); +static __read_mostly bool xen_msr_safe = IS_ENABLED(CONFIG_XEN_PV_MSR_SAFE); + +static int __init parse_xen_msr_safe(char *str) +{ + if (str) + return strtobool(str, &xen_msr_safe); + return -EINVAL; +} +early_param("xen_msr_safe", parse_xen_msr_safe); + static void __init xen_pv_init_platform(void) { /* PV guests can't operate virtio devices without grants. */ @@ -1010,22 +1020,16 @@ static int xen_write_msr_safe(unsigned int msr, unsigned int low, static u64 xen_read_msr(unsigned int msr) { - /* - * This will silently swallow a #GP from RDMSR. It may be worth - * changing that. - */ int err; - return xen_read_msr_safe(msr, &err); + return xen_do_read_msr(msr, xen_msr_safe ? &err : NULL); } static void xen_write_msr(unsigned int msr, unsigned low, unsigned high) { - /* - * This will silently swallow a #GP from WRMSR. It may be worth - * changing that. - */ - xen_write_msr_safe(msr, low, high); + int err; + + xen_do_write_msr(msr, low, high, xen_msr_safe ? &err : NULL); } /* This is called once we have the cpu_possible_mask */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:22:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:22:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411880.654985 (Exim 4.92) (envelope-from ) id 1ocp0V-00088K-JS; Mon, 26 Sep 2022 14:22:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411880.654985; Mon, 26 Sep 2022 14:22:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocp0V-00088D-Gt; Mon, 26 Sep 2022 14:22:51 +0000 Received: by outflank-mailman (input) for mailman id 411880; Mon, 26 Sep 2022 14:22:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocp0T-000881-Ot for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:22:49 +0000 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [2607:f8b0:4864:20::b32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b21da079-3da6-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 16:22:48 +0200 (CEST) Received: by mail-yb1-xb32.google.com with SMTP id e81so8524216ybb.13 for ; Mon, 26 Sep 2022 07:22:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b21da079-3da6-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=KLXz7tSfev0iNxajMi2a+v851ogylcLP5u+KTavsJco=; b=bqlLKMo+1A2k1ba6REzI3SBcd96YxnZ+uQVoIjwConT3WSKjXXhZYbfWd2xTbhxLrU ki+NJn6sHp2YnmVqj7a1GzBqEiMnkiYhgmHGRCFza5Ss2JY8KWysidElb4Sjx5dFSVv9 +SDhaznIDxneiAuV+kBkau0yqgPGfoJ/WzW8JBomTdeYfnOsAMwrQvxDH1Ez7gZY4PAg tiCG6vj7I6Npo4qnOUwGN4fzsGiZbkEaWvy0Qi2o5oe4tEJGPb3HTZKm/hm9auCGdxMq qxf9KfphyBQAO28aUbfga72pysxZeEYBAQ+RfFlfNUzSz29vHxOJJCM7PtgpE2lWuRG2 TDVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=KLXz7tSfev0iNxajMi2a+v851ogylcLP5u+KTavsJco=; b=vHbktyUVoVZ2Syh9hIMJyrgpvutV94zKkRRbAvJyIZNZmHYQf4AH9D/uzJ6dsTTdhR TAvtcaVqUpy3Tr7GuDwJ/FITQirOArf0Vpmc+IbzC3cF/9J2oa3z6wXHhNY5R+PRa4Hn w7boMeZi+8dN5w6dqmpP/hAcp9F9Wwpa4jiNmeTzYfTbyz+t5v2IQwxjb020kByUx5pQ VcAxJcFnT4SlWlhW56nEPglsbZe9tQuKUTp0lTLu/+WjR3C4p2OWOfhqRtCH9KdrMspH IXClNRpvzlA9oBa0fdxmnImJu9Kt2pAqj0khNV0cRTs3oLAeavfeuFovzhtF88hwiO3S 7ncw== X-Gm-Message-State: ACrzQf0pi8DEAPjUrZ6vNCeoTLze9D7SfU9bCiK6Z0rh/3nZd4AgKb/F 8dTjcXZQz1D7+xreRLoQCr7aKrpphCoYfJWUb+c= X-Google-Smtp-Source: AMsMyM7eswUFhza7ZAObu6Hd58ICESBa7G4K0UG5RQ1OJBLH6Ak154zWQhqI8MfBPyVtHo0NmXOYIzkbhv61vwW6MZo= X-Received: by 2002:a25:2441:0:b0:6ae:bb37:3db3 with SMTP id k62-20020a252441000000b006aebb373db3mr22590096ybk.213.1664202167590; Mon, 26 Sep 2022 07:22:47 -0700 (PDT) MIME-Version: 1.0 References: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> <7a469ef7-5ad7-5abf-2c1f-fa29496fa2a5@suse.com> In-Reply-To: <7a469ef7-5ad7-5abf-2c1f-fa29496fa2a5@suse.com> From: Tamas K Lengyel Date: Mon, 26 Sep 2022 10:22:10 -0400 Message-ID: Subject: Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load To: Jan Beulich Cc: Tamas K Lengyel , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Boris Ostrovsky Content-Type: multipart/alternative; boundary="00000000000008a77d05e99543d6" --00000000000008a77d05e99543d6 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 26, 2022 at 10:12 AM Jan Beulich wrote: > On 22.09.2022 22:48, Tamas K Lengyel wrote: > > --- a/xen/arch/x86/cpu/vpmu.c > > +++ b/xen/arch/x86/cpu/vpmu.c > > @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) > > vpmu->last_pcpu = pcpu; > > per_cpu(last_vcpu, pcpu) = v; > > > > + vpmu_set(vpmu, VPMU_CONTEXT_SAVE); > > + > > if ( alternative_call(vpmu_ops.arch_vpmu_save, v, 0) ) > > vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > > > > + vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); > > + > > apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); > > } > > > > int vpmu_load(struct vcpu *v, bool_t from_guest) > > { > > struct vpmu_struct *vpmu = vcpu_vpmu(v); > > - int pcpu = smp_processor_id(), ret; > > - struct vcpu *prev = NULL; > > + int ret; > > > > if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) > > return 0; > > > > - /* First time this VCPU is running here */ > > - if ( vpmu->last_pcpu != pcpu ) > > - { > > - /* > > - * Get the context from last pcpu that we ran on. Note that if > another > > - * VCPU is running there it must have saved this VPCU's context > before > > - * startig to run (see below). > > - * There should be no race since remote pcpu will disable > interrupts > > - * before saving the context. > > - */ > > - if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) > > - { > > - on_selected_cpus(cpumask_of(vpmu->last_pcpu), > > - vpmu_save_force, (void *)v, 1); > > - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > > - } > > - } > > - > > - /* Prevent forced context save from remote CPU */ > > - local_irq_disable(); > > - > > - prev = per_cpu(last_vcpu, pcpu); > > - > > - if ( prev != v && prev ) > > - { > > - vpmu = vcpu_vpmu(prev); > > - > > - /* Someone ran here before us */ > > - vpmu_save_force(prev); > > - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > > - > > - vpmu = vcpu_vpmu(v); > > - } > > - > > - local_irq_enable(); > > - > > /* Only when PMU is counting, we load PMU context immediately. */ > > if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || > > (!has_vlapic(vpmu_vcpu(vpmu)->domain) && > > What about the other two uses of vpmu_save_force() in this file? I looks > to me as if only the use in mem_sharing.c needs to be retained. > I don't know, maybe. I rather focus this patch only on the issue and its fix as I don't want to introduce unintended side effects by doing a cleanup/consolidation at other code-paths when not strictly necessary. Tamas --00000000000008a77d05e99543d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Sep 26, 2022 at 10:12 AM Jan = Beulich <jbeulich@suse.com> = wrote:
On 22.09.= 2022 22:48, Tamas K Lengyel wrote:
> --- a/xen/arch/x86/cpu/vpmu.c
> +++ b/xen/arch/x86/cpu/vpmu.c
> @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v)
>=C2=A0 =C2=A0 =C2=A0 vpmu->last_pcpu =3D pcpu;
>=C2=A0 =C2=A0 =C2=A0 per_cpu(last_vcpu, pcpu) =3D v;
>=C2=A0
> +=C2=A0 =C2=A0 vpmu_set(vpmu, VPMU_CONTEXT_SAVE);
> +
>=C2=A0 =C2=A0 =C2=A0 if ( alternative_call(vpmu_ops.arch_vpmu_save, v, = 0) )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTEXT_LOADED= );
>=C2=A0
> +=C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTEXT_SAVE);
> +
>=C2=A0 =C2=A0 =C2=A0 apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_= MASKED);
>=C2=A0 }
>=C2=A0
>=C2=A0 int vpmu_load(struct vcpu *v, bool_t from_guest)
>=C2=A0 {
>=C2=A0 =C2=A0 =C2=A0 struct vpmu_struct *vpmu =3D vcpu_vpmu(v);
> -=C2=A0 =C2=A0 int pcpu =3D smp_processor_id(), ret;
> -=C2=A0 =C2=A0 struct vcpu *prev =3D NULL;
> +=C2=A0 =C2=A0 int ret;
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) )<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return 0;
>=C2=A0
> -=C2=A0 =C2=A0 /* First time this VCPU is running here */
> -=C2=A0 =C2=A0 if ( vpmu->last_pcpu !=3D pcpu )
> -=C2=A0 =C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 /*
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* Get the context from last pcpu th= at we ran on. Note that if another
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* VCPU is running there it must hav= e saved this VPCU's context before
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* startig to run (see below).
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* There should be no race since rem= ote pcpu will disable interrupts
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* before saving the context.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADE= D) )
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 on_selected_cpus(cpumask_of= (vpmu->last_pcpu),
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_save_force, (void *)v, 1);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTE= XT_LOADED);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
> -=C2=A0 =C2=A0 }
> -
> -=C2=A0 =C2=A0 /* Prevent forced context save from remote CPU */
> -=C2=A0 =C2=A0 local_irq_disable();
> -
> -=C2=A0 =C2=A0 prev =3D per_cpu(last_vcpu, pcpu);
> -
> -=C2=A0 =C2=A0 if ( prev !=3D v && prev )
> -=C2=A0 =C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu =3D vcpu_vpmu(prev);
> -
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Someone ran here before us */
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_save_force(prev);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > -
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu =3D vcpu_vpmu(v);
> -=C2=A0 =C2=A0 }
> -
> -=C2=A0 =C2=A0 local_irq_enable();
> -
>=C2=A0 =C2=A0 =C2=A0 /* Only when PMU is counting, we load PMU context = immediately. */
>=C2=A0 =C2=A0 =C2=A0 if ( !vpmu_is_set(vpmu, VPMU_RUNNING) ||
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(!has_vlapic(vpmu_vcpu(vpmu)-&= gt;domain) &&

What about the other two uses of vpmu_save_force() in this file? I looks to me as if only the use in mem_sharing.c needs to be retained.

I don't know, maybe. I rather focus this patch= only on the issue and its fix as I don't want to introduce unintended = side effects by doing a cleanup/consolidation at other code-paths when not = strictly necessary.

Tamas
--00000000000008a77d05e99543d6-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:28:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411887.654996 (Exim 4.92) (envelope-from ) id 1ocp5T-0000Q3-6O; Mon, 26 Sep 2022 14:27:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411887.654996; Mon, 26 Sep 2022 14:27:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocp5T-0000Pw-2k; Mon, 26 Sep 2022 14:27:59 +0000 Received: by outflank-mailman (input) for mailman id 411887; Mon, 26 Sep 2022 14:27:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocp5Q-0000Pn-NO for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:27:57 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67c56b90-3da7-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 16:27:54 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 10:27:36 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6569.namprd03.prod.outlook.com (2603:10b6:303:128::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 14:27:34 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 14:27:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67c56b90-3da7-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664202474; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=R3HmAR1G2vcQLnFWdrPAU6rV4hgv/5JeajMddG/RiAw=; b=EeOudmmmN37sQzbDXhZNcpAe6Wq+/Lolqrlyss+C9mbZpZtm4IAfb3na 2u1saBtFLlBgWsLJ4TeJ3vTbXYjXLKfn+d+cL3GMznCb5ADJiEzMfsLRf tcUeuOdiFOI50k9pATuwDOz/GGQm2je9yuOeDRGJDIzxFQV3czXmXbj5A Q=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 83871695 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qn7p16qEIsgjQ/sszxg3otznbuJeBmLbZBIvgKrLsJaIsI4StFCzt garIBmPM/iNY2Skc49+O423/RkBsJSHmtBhTQVk+CtmFn4XpJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WlG5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVfo+grO1xO/ MUGB2wCVhmai+yEyaq0H7wEasQLdKEHPas5k1Q5l3T1KKhjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/E4/NouAA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4Wreoi312L6S9c/9cKADSqGd9KRSuwyS6G1LAz8EW16GuObs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c9hNFas84QKEyKvR6i6YAHQJSnhKb9lOnMw7Wz0sk EOIltXBBDpzvbnTQnWYnp+LqRuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+8VWZhTup/8LNVlRsuV6RWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGSD6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:cbMKsqzzAEVBzLMfVPBlKrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvoRZxRBf7LdUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K12DDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2O XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LjEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNPqWsqd 60d5iAr4s+PvP+XZgNetvpfvHHe1AlYSi8R156cm6XYp0vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw== X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="83871695" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dembMj2+1gE7zS+lYqAcJcNQefhMLdxXXXKDN88j8pSoN/vtR6DS3pDSrVVkN4azsuF7WDVGnkKTtkGkJGefHdhBtXLVLRARkeiw2hFT37+bsbcckhMFizrXbhO0/PombaZGSdJ0if3gC66wTxOtTdWnBR1lyXX9RchSV6++TqgShPoFbilIzFkC1vZh+MIRvwGHzKhqyPABBPL+mmkew7+AKD9WDV32dg75vvsxUFOWbG7fuPqQT7YxuBcHoE4S46fHbom3hMdHJVAmbNqw5bwxrO6a0ou6QYniC2bufTSJYEfRTs5LC9lgoB8K1nXGszqodXFmhKj0+x4Xh5SgVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RU0sTQncLwtSnqNm1sz3NZyzrxReA0bmFTj0hr0dDr8=; b=IpfvToORarrBJchbDGgqVYYiNWFlrmmkCm8pt+U3GUD7hkrZb+revbkfNMF9MVdBrJylsYt/PZkBfz8pYYmqaoZfq2FVKcZG2guhYSFJ8rriiAssGePx+j2aCFOpwcYBX7Hvgj1KMyeIR0hxtYYPkhd423gnGG3DNsZsGT/DuZdkPlY+hquMZXXmcJiOsnVLMKr8YJmRMds4sOK7zi7pX0EWJ3TCvmvUL51E+xoumy56OovgZ90NFb/EWvIQNSFZ2yHRJkP6rbf6HvsnxY9uZnkbJIjuJbvmfWmFhJr15DyG92aO6sUSUd0d4H96X6Fchomr4n/ekM0HM6NRmysfIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RU0sTQncLwtSnqNm1sz3NZyzrxReA0bmFTj0hr0dDr8=; b=nkV1/xCJKXfI2KP7lbiA4LAsNVaID8KCpl/JU4DlOiL+RomD75REtSI3cLxo4HtX9l2gUovWwb1fhBQvrVS8CQI3qFGxQYrTuBBHUSqMZeTrf7wH5rnKtZEnQoT+e7VyIJKnAGQ1apFtvZnIfBaAxHPGNteMFLeZKPJAiiRRaZY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 26 Sep 2022 16:27:27 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ept: simplify detection of special pages for EMT calculation Message-ID: References: <20220923105648.12587-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0093.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::8) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6569:EE_ X-MS-Office365-Filtering-Correlation-Id: 99a7d096-9617-4c8d-d0b9-08da9fcb402c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x3o+jmB0pNdN+lE70OlQejQIe4NjBp+OPjWq+Ffwn/YLc+Y5HIJF5mfkU69aBS0ig+ZmckbiOs1sRv9Fs2McL5OpO2U2ieJeaV8l306Q9ICJ8P7OBSBB6WmGP6T5aVrdUyGsrU+Ohx6p1rNS7c/Gmfneg5zRyraRtfH2c+2PJDqFT5fUQfxcrYTtt1BM3WVw4QL3OkuxDWM8XadTnv0AAynEHQAADpzgc7oiP2+PyrHd8ThO287ctLQI4XwKx0mufiDyXm+Ts6lJpV6b8KeNjqjXIaX5UwRFy7ylJZLY51M3Hkh4NbxTXlGzRqvswsNQCzVlnuq/lluqgXVT/2SjSuiR1rzwy4E3KTRw2lBbp/tYEJ/3H/SxuK953kKRPDZgVPPmzphgW/Ghi5H5ZnGy0/Fn9cWVLY6P2LiSDrcOWDI8g3SFgsKHoEBEPmC0kIqPSjMVMmQOgH9dnO25ILNX+rW1hl32KyJesPixdCWfDmfTPK9XlKcaajF+f2O8DOzI0AomZ3z+tvarF+djXAdmw9p4Ul8VU+1vH3OJfvcXfRWNU//7Ts/h0q3IvVdyOdVTgzODsv11LAStI7NQZAfE5CCED2gsV+eRNbz07y48kswkq4ijmx4EgFOJXTPzU47ws987LOEbwQePPcV4+xM/TyP3sGCT9AFhDfUpNouRdDhymgp7Ojs9ysthqwzn/3TLtadzvYXM+5dPd3CxrL2T/A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(451199015)(38100700002)(26005)(6666004)(6512007)(6506007)(82960400001)(83380400001)(186003)(53546011)(9686003)(478600001)(6486002)(8936002)(6916009)(316002)(54906003)(85182001)(2906002)(86362001)(5660300002)(8676002)(4326008)(66476007)(66556008)(66946007)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVpYZHpWVUxCVjhFKzZ2ZmlYcWUxSS9OQVhJZzlVTzkwWHJVT0tRbDd5UG14?= =?utf-8?B?ZWhBUVFPa0J1UDJRajNBRnQ2UVF5blNXa2pSYmpYa0krTEhBR0VUOERTV1BE?= =?utf-8?B?dVZUUnhwTkFOWUtqNkxmU3Nza0tzcUxqREY5UWoyQWszcGo1RklTbGRFWGs4?= =?utf-8?B?ZHZGL1NhQ3ByZHlNMzVCYUVLd0UzZGVBTkdQYmtkb3lvM2gvUTV3Y3phQnlO?= =?utf-8?B?TXc1WExHb0tBSmg1QjFET3RNaFoyQjNWd09mWE5CdUpVSm9hZG1ROWdqRnpN?= =?utf-8?B?aUtPOUtXeVNXbWdYbzFBMnBhVXkzRm9MZXdHaFBaL1hXZkFVemFZaENQZzFm?= =?utf-8?B?NldoTHNEMjZKcENUMzJlOCtsY21QSDZua2ZWUzJtdE8vV2ZIdzUxc0txZGpw?= =?utf-8?B?U0VaaXZFSERJdEhnUzBuL1Vtd1NtNSsyWnBOaDBmYjA2TW1hOHAxTGVPZGJh?= =?utf-8?B?bVJJNVdQcmZtTjBTSTF5V1NZL1FLaS8vVXZpZ0xBSm0rK0pRY3dwWUdtS1l4?= =?utf-8?B?S3JvbGNULzlyZjlsMTFMeC90aGRibkgxQUZzbjgzYVR3Z1FzSmZETGptZVdN?= =?utf-8?B?aXpQNjRCU25Zek5RMEkxOHE4YXdzUGppQ0lSZTZhcUY2WUFOcFdqMkQvamN4?= =?utf-8?B?elprVzFNak8xeC9maEtmQUtOc0lrUWgyU3RUN1V4NTFRR0FUaXdXYlRIMmQ1?= =?utf-8?B?M2NvRVNHdFlzOVRWOUFmNGVncERrNm9uU2hkbVExRmlRZHJ4anczeWRoZ2NC?= =?utf-8?B?R0kvR2o1blgrRmEvVTk1b0g5Uzc5KzlPSXFlcFB0MC9TNjBjQ3p5cUQyZ0Zl?= =?utf-8?B?SUNNMExRaFhnWEwzcDhhQW5EMzF4M1I4MFFrL20zWlFhVmNSSmgrem9WUGNt?= =?utf-8?B?eVBIK0x2UW5uVm1pUnFrYlFZMzlDbXFBZ2I5QjBxeVp3aGVQcHFLTCtnTW95?= =?utf-8?B?eVdFZVN6UVNVUUNxN3FsMEFQRm0rV1FXWng0WlRsQS9qSlVnZEVhN1daMEl0?= =?utf-8?B?d3RoeThlWCtNck55TlRUL00yM1FnUXZkMXZqbmRvd0tkazFhcG9LSGNISlUx?= =?utf-8?B?WGFHNzIyT2x3QzlKcmRDRFpUdVZYQUsvOURxcmphdlhvMkg2NlJ5clRlY2RI?= =?utf-8?B?QjZCb0F6U3FIeTduRy91OURDVDlEdmdwOTNya0IrZXBZZlFZMVRBTVMyMG9l?= =?utf-8?B?RVQ1Y0hXaFBvMHFlY1VCT1NHNU9xWWxjakRCaDhFUlZGK2RrekpPVXFETWo1?= =?utf-8?B?VkxUL1Q5ZDZYYkc1RnRHWFNBRnQ0WlJKeG15SmpISnNDTWdaVE5YNlpvZGkx?= =?utf-8?B?QWxQdTc3L01RL1VTanNpODNCODlvVkw2cDJuSlBBWEIxS0RxL0FrK3h3UVpR?= =?utf-8?B?T0pQRXlabkxzWGQzNGFIYitnMWpjVlhEMW5Cc25tZlFMVlpSYmdvVkFWbERq?= =?utf-8?B?MFlSZUR4bWJJdEpjN2NQbm16Z3RxdVQzc2wvc2l3WVk4MU8wQlgrdkN6NWs1?= =?utf-8?B?T3RpOWo1dW1PN3YzeFE2L1FvU2JoNEltcEI2SHVDbDJQV2tDUVl3cS9VS2tI?= =?utf-8?B?K0dGZElEbFRSS0dHaHYwZTJoeUh2dndPTHhQUWgxZWxmbDlFOFlCbzMrQkZV?= =?utf-8?B?WVZCVXRwTlNBZUhHaGlXSHBTS2lLdFFmWXArK0EzUEZJTWp2N0Uwc2MwdzNu?= =?utf-8?B?Y1FoeGppZWQvenJrQktPTC9jdEpJb1djc3JXNDAyZTRhelQzZXNiZWd2NXNQ?= =?utf-8?B?RFdneTFFUVRFUDZMK2JVcGhEZXlCbElrbzBBZFdMSzJZa3IxcHRMRXQwQ2VX?= =?utf-8?B?MWdpeXZid3FHTG5hbHp1RytGL0F3UXl1ZjBPUFpnRDBnN0dPbm9UNTNUaGFu?= =?utf-8?B?eGVrby9iNFh5S2o5czlvRnlzVnRUYjNjVWg0Si9UbFdPQ0JmR2Mza0RQeFJU?= =?utf-8?B?MDNkaTJ4Yy9uUXBoRDBsTU1oY1VPV05ZZmRvSTZoUVJ6MmlhYU5SYTBIb2gy?= =?utf-8?B?QVFlUmNyWFIxZlg3M0xpN2ttVENlMFVtYWZJclRnbUtXcFNDb3V3TEdOVDZG?= =?utf-8?B?NWRRSE5WMmF2ZkZwOGFFV3dXaDNZTmtzdVV2OXU3TzlkVGtJYVJPWEJ4R25J?= =?utf-8?B?bVdhTUhKSGQyUllGc1YzNThpS1JnMmtPQWp5L3dzU2cyZWNNaGRwUzU5Z0tz?= =?utf-8?B?aEE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99a7d096-9617-4c8d-d0b9-08da9fcb402c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:27:33.5998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AxdxoXkADZ+yzcfSXKQngeJzlJuYFNGCvlspPDo+H0ViiAqypZJyGIAFpS/YfYEDke3BuHZIfusiBamgOwxxZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6569 On Mon, Sep 26, 2022 at 10:38:40AM +0200, Jan Beulich wrote: > On 23.09.2022 12:56, Roger Pau Monne wrote: > > The current way to detect whether a page handled to > > epte_get_entry_emt() is special and needs a forced write-back cache > > attribute involves iterating over all the smaller 4K pages for > > superpages. > > > > Such loop consumes a high amount of CPU time for 1GiB pages (order > > 18): on a Xeon® Silver 4216 (Cascade Lake) at 2GHz this takes an > > average amount of time of 1.5ms. Note that this figure just accounts > > for the is_special_page() loop, and not the whole code of > > epte_get_entry_emt(). Also the resolve_misconfig() operation that > > calls into epte_get_entry_emt() is done while holding the p2m lock in > > write (exclusive) mode, which blocks concurrent EPT_MISCONFIG faults > > and prevents most guest hypercalls for progressing due to the need to > > take the p2m lock in read mode to access any guest provided hypercall > > buffers. > > > > Simplify the checking in epte_get_entry_emt() and remove the loop, > > assuming that there won't be superpages being only partially special. > > > > So far we have no special superpages added to the guest p2m, > > We may not be adding them as superpages, but what a guest makes of > the pages it is given access to for e.g. grant handling, or what Dom0 > makes of e.g. the (per-CPU) trace buffers is unknown. And I guess > Dom0 ending up with a non-WB mapping of the trace buffers might > impact tracing quite a bit. I don't think we can build on guests not > making any such the subject of a large-range mapping attempt, which > might end up suitable for a superpage mapping (recall that rather > sooner than later we ought to finally re-combine suitable ranges of > contiguous 4k mappings into 2M ones, just like we [now] do in IOMMU > code). Hm, doesn't pages used for grant handling (XENMAPSPACE_grant_table) cause them to be mapped as 4K entries in the p2m page tables. The code in xenmem_add_to_physmap_one() seems to remove and re-add them with order 0. Same with the trace buffers, they are added as order 0 to the p2m. Note that when coalescing we would need to be careful then to not coalesce special pages. Might not be the best model because I'm not sure why we require XENMAPSPACE_grant_table to force entries to not be mapped as part of a super page in the guest p2m. > Since for data structures like the ones named above 2M mappings > might be enough (i.e. there might be little "risk" of even needing to > go to 1G ones), could we maybe take a "middle" approach and check all > pages when order == 9, but use your approach for higher orders? The > to-be-added re-coalescing would then need to by taught to refuse re- > coalescing of such ranges to larger than 2M mappings, while still > at least allowing for 2M ones. (Special casing at that boundary is > going to be necessary also for shadow code, at the very least.) But > see also below as to caveats. I guess a rangeset would be more future proof than anything else. > > and in > > any case the forcing of the write-back cache attribute is a courtesy > > to the guest to avoid such ranges being accessed as uncached when not > > really needed. It's not acceptable for such assistance to tax the > > system so badly. > > I agree we would better improve the situation, but I don't think we > can do so by ... > > > @@ -518,26 +517,19 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, > > return MTRR_TYPE_UNCACHABLE; > > } > > > > - if ( type != p2m_mmio_direct && !is_iommu_enabled(d) && > > - !cache_flush_permitted(d) ) > > + if ( (type != p2m_mmio_direct && !is_iommu_enabled(d) && > > + !cache_flush_permitted(d)) || > > + /* > > + * Assume the whole page to be special if the first 4K chunk is: > > + * iterating over all possible 4K sub-pages for higher order pages is > > + * too expensive. > > + */ > > + is_special_page(mfn_to_page(mfn)) ) > > ... building in assumptions like this one. The more that here you may > also produce too weak a memory type (think of a later page in the range > requiring a stronger-ordered memory type). > > While it may not help much, ... > > > { > > *ipat = true; > > return MTRR_TYPE_WRBACK; > > } > > > > - for ( special_pgs = i = 0; i < (1ul << order); i++ ) > > - if ( is_special_page(mfn_to_page(mfn_add(mfn, i))) ) > > - special_pgs++; > > - > > - if ( special_pgs ) > > - { > > - if ( special_pgs != (1ul << order) ) > > - return -1; > > - > > - *ipat = true; > > - return MTRR_TYPE_WRBACK; > > - } > > ... this logic could be improved to at least bail from the loop once it's > clear that the "-1" return path will be taken. Improvements beyond that > would likely involve adding some data structure (rangeset?) to track > special pages. For the guest I was running the loop didn't find any special pages in order 18 mappings, which are the most troublesome to handle in the loop. I'm not sure bailing early would make that much of a difference in practice TBH. I did also consider using a rangeset, but that would use more per-domain memory and also require coordination to add special pages to it. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:43:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:43:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411895.655006 (Exim 4.92) (envelope-from ) id 1ocpKA-0002qV-Gx; Mon, 26 Sep 2022 14:43:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411895.655006; Mon, 26 Sep 2022 14:43:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpKA-0002qO-EL; Mon, 26 Sep 2022 14:43:10 +0000 Received: by outflank-mailman (input) for mailman id 411895; Mon, 26 Sep 2022 14:43:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpK9-0002qI-Jk for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:43:09 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2049.outbound.protection.outlook.com [40.107.93.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88748ad7-3da9-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 16:43:07 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MW4PR12MB6826.namprd12.prod.outlook.com (2603:10b6:303:20c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 14:43:02 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::d085:e792:380d:ca4f%7]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 14:43:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88748ad7-3da9-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gscYOrx5QE02p9GOMftJ3A/Ns56RnA5y32xmdVQsp6ZB6ZhPgiedjS1qfTf79qs7e7RTPRZJAvPWAESioATBNYUtfpHsXxzdd5bY3lpIEMHXUBbo28pwTfVvsZvLLVubIqc9qewmjldEc0P4lEsZyiaOiJpunlEYAlBUj+hsAXrvcxIzmc1elYpIYg/A5k3O5Gd1f1XneWzwf49zgvLZNNmP8rd7Bp8Qkz2k7cdo4kprQK/NJGKqx/4pU3M3qmVHSiTKBJpakxIVUDVHr1bkPajvpFm/innBakFDNQCogu3xZ2o8h45YqDGiuOhwEVu3M/QqoJDb3rWgorbShgKOaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ZMY5OwHwl2FddXGTHXtDteiRYwUkwfAWOIZsQT0Vok=; b=WQ0rQL3TW3oY+PBMbxKezgpSUgQezzXm7JjsKrDn/ZY6TYTL6jn68Waec03BtQn5QpJH2KD0Lt34xfEbyuELTMcSHX8QsJJpR3IzMXbrQGW/1dfv0UsZCsDCOB2mP6s/Vj/rx8YtJg7+JhHF2nkZF577aNeJ1DDIXxB/DAkcfOC5stp3jU8pfnxsE7ggaC4gczhU1sSBcethLpljZlfW7DBC70B1/G8PE8emp4dUaxA/SgTtW1rZb8r7tYGk8j9TY4ayPhxjgFMfsn8NS5cWg3yHXu4SnI/yN+X6eUdbyi9aJLNlG29SAB+v46ElARKrb7F7UOHjKa9RY0HhwME9cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ZMY5OwHwl2FddXGTHXtDteiRYwUkwfAWOIZsQT0Vok=; b=fcctp8lZhvKL43Q2ohUODkZzx8wghFugo0XjZXUYSXoQr56mqB/P86M6HfHYdTk/Kn/6YAStlhUC/cDLNd0e8F43hHn6iJyYCxv2nJlFWVly08S0wBVGnoEBtqBVedr9XLoavCngYS2xbIUaBVWz41w12zqKWu/61QLnV7zDk5s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <40b8dc01-333a-1fd7-088c-6af481c6cde3@amd.com> Date: Mon, 26 Sep 2022 15:42:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed To: xen-devel@lists.xenproject.org References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-2-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20220926110423.26030-2-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0016.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::21) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MW4PR12MB6826:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a9cee9d-e528-4303-b97f-08da9fcd69d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: InKowcXTi3XTA3L439C5Z0CoB1pHLbjUbwLzfNrKi6DR3k898/HQC/b3HO2cV0PLcNEF0BZJh8oK3JCPBqQ0ED0f4GtgSGQ4udpCCvdipBSqQcV9OCWRaOMyTWlew83PBcaEwiSBorNqCYCIMTp3hvLstI85UhNZrdVTX02aCctlRx3CU+XTshXvgUOUBnMt4PwPN7yB0WzTm56MzGiIW5dCf7DAbpnqGLcohpSNNOpDTRO8hZtH2xHxuM2cyG0L/FWOMKuaP98jnoC9YhK9b5pGK1cV3ZZam65SanbDTau0xYdb8+j5lgcy+2fROy0Xy5kps4HD181wWteL2kP48hWsq6lV4M6OHSDbsGMULfQVXaZUOCg+uMFHsFMKLTEdUxwG+D7vLoyUCYS3h7FMabBvDniQV75yqN/MCBL1FymSQXrziVKBtljwyrLVCvg9QnapNu+kGvSy1J/KrEcf/+fVuecse7fB/i3FCruDYy5E3F0oroqqr7OY1cVx5bCq6QiH4u+IDMa2uCa+F+VAOUji3Pcyg46nP70jN5M5Sop6M708jFRbxZjInepCNdPAIF2BE2q0HtWh1Ne4lYhQBzkgihR1pKn42HWSnatFoXeESu+e6vZF6ynWatJ2CCTTBWuiFqxnfptFtRlDpRDsoDfhOdQpQOs235Mvc4wroOk8ERpd+W7KGVtF/p+CW65zK4To7SXQl9dBB1fmrBFGnaGtM1FJ9jHGjC61EQkAPbcB9uz+CWE3qv/m4cpTez5BUvmTKVJiWWiUw8BJXDGi+/HV4RQktUgrin9WoJ3Uc8g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(8676002)(66476007)(186003)(66556008)(53546011)(6512007)(26005)(6666004)(6916009)(6506007)(316002)(2616005)(36756003)(2906002)(5660300002)(83380400001)(38100700002)(41300700001)(31696002)(8936002)(66946007)(31686004)(478600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjBSZnBBZGNuQWJmYWpONzl0TnZ4WkFTaVVUaGxxTTRjbVdUM2IwbVBxS0xQ?= =?utf-8?B?QkZkeDlnaEw1VXpCWkY1UVBxcWFZY3B4NG1PNHVFR0JlYmdxMThZMUY3S293?= =?utf-8?B?Q1N4aWFERnAwMmlucTNhaFFYRWhzQ3ZCZ3Z1dGx2b3RTYTlHVG1tUjE2QUFw?= =?utf-8?B?VlZZYVFYWE94NTViN01Gb25vNVBnMHp2ckRlbDZNWitWUTJ4V2M2MkdRNE5X?= =?utf-8?B?OUozd2oyUzdWYVRDQW80L1lpR1F6N3ozS1k5NmJQekFWZ2lhdnhlWWJENEEr?= =?utf-8?B?TWM1YjJwdWZNSTdhOGZyVHBGbGNPcEg3K1ZPMU9keVJTY1E1SmRDTVE4bTNN?= =?utf-8?B?M0pvWTVlNGEwZW9ZLzJUeHBrNWtiaGNpVlBHb0NydE1hdzJycFQ2cjBsbGtT?= =?utf-8?B?UFhIYnY3a2xjS1l2QllQc1pBYXpsdHVoYzVrMzJBT3djUzkyZVZ1UTY0QUpy?= =?utf-8?B?dmZHc0RtMnVOMC9idGNmTzhsZjN3cHM4V2VlT09oelUvRFBZSWUxTmdSMmJL?= =?utf-8?B?cjFMK2ZKcHFybmpnQzFXQlp1WGRFT3l6K3AzdndVZk1nZHRpT29CYnBqMDJO?= =?utf-8?B?dFFrakEzUjlUL2pnbkdTZldkaW9vbGFDL2htUGFSczhzWEt4SHFxR2d1ZFZj?= =?utf-8?B?VjVFYmoxcy82TGdzS1RlenFzUGpWbU5zWGRzdTdsQTdodWh2TmRwaWJzSllU?= =?utf-8?B?M2xRcFE3bjdxRy8zejNLV3hUZ0UwVnpISWpvdldZd3RIYzdhK05sclJlQktt?= =?utf-8?B?TEhiRGlDc0V3R0Z4MlZwWkhJYk9SbUFoUHl5ak1qZ0NCWGdSZ1o5N3VmdHlN?= =?utf-8?B?cEJlak9PS0tEdnh4VEd1U3Y2R01BVU5rL0tNc0k2OHFVTU9PKzkybVU4cmRK?= =?utf-8?B?OFdSSWtTMHZHcDE0SkpIRzZMaXp6VzdvdHUxd1MzVDIyK25FZzBrdVQ3QndW?= =?utf-8?B?V3A1dlA5L2FvSHFqcmZuemZTcXNVLzFvYytTZlZTZ3R5bHRNNFowbktWRGRt?= =?utf-8?B?WGxESjZ6cy9JUGpPY0Z5ODUxNHVyK0pHTmlMMDNjN2RMSnMzN0VpZjlxby9o?= =?utf-8?B?cFdPVFhVZWRNWWg2R1lGS3B2UnlkZHB4U1QxUlhaRHJKMWdrY0dIVjdCVzMr?= =?utf-8?B?V0h2YWpCSkNIQjN0Z2xiUkhCbmxjWnR3dXdlM0h3N0VxUlozT3JISWxRM1I5?= =?utf-8?B?UGk3ZUNQY0k5U1RrUDlscXNNQ0xOMXNOeTdDdlBXOE0wTS9XRHQvL1RMSlhl?= =?utf-8?B?bVgza1ZoYXBIV0tHVEhpcThvZHBlK0x1WlVHYjZ2VDhyVnBySlpzNkhzb1VZ?= =?utf-8?B?WHlVSEs3VTlrZGp6K0hwazIxZG1WZ1ZkRXBjdG9ON3VsQ3lncW9aaGQ5L3kx?= =?utf-8?B?U214aS93ck8veWhTakFmQ2pBd0tscVJYRERNUlVlTG1uQXU3dGg1NDd5NkRi?= =?utf-8?B?bEtrRFZIOVBsdTlhaUVzRmd3YldPOFhDaUJ2cEJDUFpZakt3VkhEUXVGRmFp?= =?utf-8?B?cUhWa1dSbGY5U0xNaHA4cjRBSmt3RTJqNG53QTZxNDRXNXQ3KzB6eG4ramtE?= =?utf-8?B?ME8wOWNUZnRMdFRTTXJKbEdScEh4MkxON3MzdlpJUHRBMi8xaWUxSE9ZUCsv?= =?utf-8?B?N29aZ3czakFpOHBmN1lmTVFCL21VYWxwdyszOENiUW15bHNOMkxNRTJDK3J4?= =?utf-8?B?MDJPU25GbkJJWjhORXgyZi9jSmV1RVZqTFpZTW5QYjc3WklBNzRzbjMrQmRE?= =?utf-8?B?Wm5TWWw5M0IzT2MvdWtSZzBGS2hMYWdhcDJpTXdKVVM5d05hditucHhLWm1i?= =?utf-8?B?Y0g3ZWc1OUFCNkxQWjZQVjh4WXlSWjBOQnJFVUt5ZjhyN2ZMNzFzanRZcitw?= =?utf-8?B?NkkrTmdJVy9ROFVqdEVxbUcrSHRXSUZhSEJkT1dIdGljK3NhdW9zYXZrZjB5?= =?utf-8?B?REpJR2JrVmJrNkt4VE0yWnhEZTlLZitEeGJIZ2NBRkRlR2QrTWxOY2JQWGJy?= =?utf-8?B?TTh3LytMbGExZ3d3SzNYYkhZcWxMT2NxV3B6a1VaUlVUcHJRL1MvRnNSeTlq?= =?utf-8?B?ZnZ2Qm84aTVsVVZaMm9NYzZpSERZYjQ0dGRuSXpuWEowc3BNVk9BVWtEZTVO?= =?utf-8?Q?M7GgTbgNM5HcmVjXTqRAlCvOG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9cee9d-e528-4303-b97f-08da9fcd69d7 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:43:02.2172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hapgNpLHX/TplXwm2cnLE2be3lSj+debKgitNWXuj2Vf0hg2suwc/JvHRxwukxmJIiTVeMjlJ47ip7nq60AAjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6826 On 26/09/2022 12:04, Michal Orzel wrote: > Currently, all the arm64 defconfig build jobs, regardless of the > container used, end up building Xen with the extra config options > specified in the main build script (e.g. CONFIG_EXPERT, > CONFIG_STATIC_MEMORY). Because these options are only needed for > specific test jobs, the current behavior of the CI is incorrect > as we add the extra options to all the defconfig builds. This means > that on arm64 there is not a single job performing proper defconfig build. > > To fix this issue, add custom build jobs each time there is a need for > building Xen with additional config options. Introduce EXTRA_XEN_CONFIG > variable to be used by these jobs to store the required options. This > variable will be then read by the main build script to modify the .config > file. This will also help users to understand what is needed to run specific > test. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar halder > --- > This patch is supposed to be merged for 4.17. The release manager agreed > on that. > > Changes in v2: > - replace [ with [[ to be consistent with other ifs in build script > --- > automation/gitlab-ci/build.yaml | 15 +++++++++++++++ > automation/gitlab-ci/test.yaml | 4 ++-- > automation/scripts/build | 8 ++------ > 3 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 720ce6e07ba0..a39ed72aac6d 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: > variables: > CONTAINER: alpine:3.12-arm64v8 > > +alpine-3.12-gcc-arm64-staticmem: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > +alpine-3.12-gcc-arm64-boot-cpupools: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_BOOT_TIME_CPUPOOLS=y > > ## Test artifacts common > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index d899b3bdbf7a..4f96e6e322de 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: > script: > - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > needs: > - - alpine-3.12-gcc-arm64 > + - alpine-3.12-gcc-arm64-staticmem > - alpine-3.12-arm64-rootfs-export > - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: > script: > - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > needs: > - - alpine-3.12-gcc-arm64 > + - alpine-3.12-gcc-arm64-boot-cpupools > - alpine-3.12-arm64-rootfs-export > - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > diff --git a/automation/scripts/build b/automation/scripts/build > index 2f15ab3198e6..bcfa6838f0bb 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > hypervisor_only="y" > else > - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then > - echo " > -CONFIG_EXPERT=y > -CONFIG_UNSUPPORTED=y > -CONFIG_STATIC_MEMORY=y > -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config > + if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then > + echo "${EXTRA_XEN_CONFIG}" > xen/.config > make -j$(nproc) -C xen olddefconfig > else > make -j$(nproc) -C xen defconfig From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:46:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:46:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411900.655017 (Exim 4.92) (envelope-from ) id 1ocpNJ-0003Wm-W0; Mon, 26 Sep 2022 14:46:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411900.655017; Mon, 26 Sep 2022 14:46:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpNJ-0003Wf-TS; Mon, 26 Sep 2022 14:46:25 +0000 Received: by outflank-mailman (input) for mailman id 411900; Mon, 26 Sep 2022 14:46:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpNI-0003WU-Qm for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:46:24 +0000 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [2607:f8b0:4864:20::830]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fcd69f82-3da9-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 16:46:22 +0200 (CEST) Received: by mail-qt1-x830.google.com with SMTP id w2so4203214qtv.9 for ; Mon, 26 Sep 2022 07:46:22 -0700 (PDT) Received: from ?IPV6:2001:db8::621d:2a77:62f3:847e? ([2607:fb91:1108:ae0:6e73:b13c:9e3e:3750]) by smtp.gmail.com with ESMTPSA id k8-20020ac86048000000b00338ae1f5421sm10885314qtm.0.2022.09.26.07.46.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 07:46:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcd69f82-3da9-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stew.dk; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Mon3F4fJzwfLL3aoRJ+rccUzL4cSbAkkiJ94n9wG960=; b=QbBv3/uUd7XzT5D6rQrj1kz0NhOCCeLQ6xblAOUnyCeijfim2lxWv1uVSdtXMMKxV9 xK7joTujrn/pD5lRFPg21JANxJBaBKp1ECqQGq+gMuGoPpaxES9vh7UrwQon0UxX7ywZ CDEO/0s/q+7/WDeiDrdvmsbE6actEtUH5PCPY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Mon3F4fJzwfLL3aoRJ+rccUzL4cSbAkkiJ94n9wG960=; b=d4y9QLDI1vUvJ0QFO2bG/txPM+yAGTb1MNi0cNf2/oBN5Vh5cefL+HgBtLGecwFgIt VJzkGExWE5mu8O2+v2F1UcN9o1TfkU/1NPca3JXu5Vbllr7gy9WdRTio1OgZbXgHfwv1 EBpQYsvPGPoqq6NLd1mP1F7sF9gGb2fA5vOwVM6moEuW085cfitTFsgzpt7vjpbOTKBh uD3hs6quX5aGJ8Jb9IWmJHkdeG/JA/sQf1WEhyl6a2Xe9PBrzt7tg7OYy2rzOCwzuXPS 5jJJLLpmB4JnW+ToOkcAI/bgS9Zu9pPxCgPGwRrtXNE7DdvdSc8qzmX/SUhS36JEUXv0 v6Ag== X-Gm-Message-State: ACrzQf23Hp8FzkUNbwt2rr3nuzySOUOrH4iCyccptR9WTT/ygKf2LpPO 6CWlrNqVcTc7Ez9DQbgbT4aJ9Q== X-Google-Smtp-Source: AMsMyM74LsZNx5JIEs0m6fH0zQ9qg+B1oP0duQbR05Yq0vXfIj272xdiOmDC+glyVHSdfLMmG0UONA== X-Received: by 2002:a05:622a:12:b0:35d:10be:c459 with SMTP id x18-20020a05622a001200b0035d10bec459mr17923699qtw.43.1664203581382; Mon, 26 Sep 2022 07:46:21 -0700 (PDT) Message-ID: <2abd4de9-5382-3ca3-5d2e-81ddc79d3b95@stew.dk> Date: Mon, 26 Sep 2022 10:46:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-7-michal.orzel@amd.com> From: Stewart Hildebrand In-Reply-To: <20220926110423.26030-7-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/26/22 07:04, Michal Orzel wrote: > Take an example from arm64 qemu test scripts and use ImageBuilder > to generate u-boot script automatically. Calculating the addresses > manually is quite error prone and also we will be able to benefit > from using ImageBuilder when adding domUs to this test in the future. > > Install and use u-boot from the debian package. > Modify the script so that binaries are loaded from u-boot via tftp. > Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always > set to pl011 node path. > > Signed-off-by: Michal Orzel > --- > Changes in v2: > - add explanation in commit msg why we remove dtuart path > --- > automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- > 1 file changed, 27 insertions(+), 30 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh > index 530f3892fdd3..765facbe4d66 100755 > --- a/automation/scripts/qemu-smoke-arm32.sh > +++ b/automation/scripts/qemu-smoke-arm32.sh > @@ -4,7 +4,9 @@ set -ex > > export DEBIAN_FRONTENT=noninteractive While you are here, there's a typo. s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/ From xen-devel-bounces@lists.xenproject.org Mon Sep 26 14:50:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 14:50:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411907.655029 (Exim 4.92) (envelope-from ) id 1ocpRP-0004uc-GQ; Mon, 26 Sep 2022 14:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411907.655029; Mon, 26 Sep 2022 14:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpRP-0004uV-DV; Mon, 26 Sep 2022 14:50:39 +0000 Received: by outflank-mailman (input) for mailman id 411907; Mon, 26 Sep 2022 14:50:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpRO-0004uP-2N for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:50:38 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 92debeae-3daa-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 16:50:36 +0200 (CEST) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 10:50:32 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB5990.namprd03.prod.outlook.com (2603:10b6:208:313::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 14:50:27 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 14:50:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92debeae-3daa-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664203836; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=AaylrN5BoaowwtMky8IzH77XcswefpIc26+dsCWWb9c=; b=VEaun/BS/k5/WkBv963ZLG4XsKWYeBgUqjyZQsAvpF2f+DDYNKLJeFnb qgJDsH/vCS1QF6p0gRpRgd1yIbtAb5HhQ1VitHvva/lEwIRlT7KbP+VWG FCW2859619URAlmCSSmOJ4Y5geFGuFeaLqZ83IqtJ5cf1i1Pl2hGiw9lj s=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 81346167 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OWU7OKxJ2J0bFmkramt6t+cNxyrEfRIJ4+MujC+fZmUNrF6WrkUCy WtMWmuObKqCYWWnKdt2YI3gpB5TsZLRy4QxSlFk+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Ukx5K2aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1kJXw8EtIiqtpHW19rq MA4bxo/Xz+c0rfeLLKTEoGAh+wFBeyyZMY6hSslyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCSiNWQA+Dp5poJui4TX5BZ237X3dsLcZ/SBRNlPn1ber WXDl4j8KkFDb4DBkGTamp6qrvfmhx/rY4wpLbm59aJKmQbUxWsUDgJDADNXptH80CZSQel3K UYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJSwAOQzqvZ5S6JC25CSSROAPQ9r9M/TzEu0 l6PnvvqCCZpvbnTTmiSnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPqTdkgbwW1JYPz//ipQCBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHblrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:1rCCdK7epsAC1tSxNgPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81346167" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=guc7J/dVB+zFPQyraEqfK/nfj5zpq++A2ajFtekzjMcmuMY8HZYqZqJpI4NSWEUF77k+A67pG0Pb5zOskRysDQu2Mk7nHpzwTAzQUFHu64/ZUW1iqNaL7Q3ALneruwuuGmBEG8jykwPZ/68+AhLtFoBEd1gQvEE5T0i++LQgeO66DHyv44Q52Bap6KbGyaFiLRFQkYZ8isRWghrmdviTYVVgnLLJPrrKvkn02QLe3kbbvah1Rj+7zUgoWXLUtW5bF1jxXVwaK140u1ftbBLcWVt/+xfDNRHC0kueR9tUt61m7BWXu0QtStjKt3RC8PwK8WWwFyWWTJQ5WiDq2fWE6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vXZKiHA38wFhvsgghw7D4q99CP64GtYB6wVvvv+kDVY=; b=ThzfVmcKCM2W5gZEeRKXfPJGG8BNFgxPl5vx+6dG2fQO5JNGa8T1PY9ojbdiTKaOtG3FXZbNJ8pWjkjifycRzfDCX1fO2+DFN79WvZ0rRwhXSouPjCsgtSm6OKJfH68LQB7jatu2XoFUNzDnigRpRLb60K5eZ7KbkH2hpibFIU8cCscuA3wXD3gqaVcwaVwBowPbOHGHcG8gwnuz0t+GJvtPvfiYQ+Z6PkT5MSu4hmc1/+uYTPMZ75uQc0XczKQjyXohSXOMVwVHWWrJc7ayz2wSUiHZiHi3K528d10785NgVuTYq5P7z1zuKyKlNkVBkqC8Ntso3y8Rm0zkXLvXqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vXZKiHA38wFhvsgghw7D4q99CP64GtYB6wVvvv+kDVY=; b=pYjrYQ8AR9Js+BvKnGxQAbivOwzD1Bmu/rFzwWBnnW1ZLPLHcKRLhulJ9vGp8HW4zil6udTN7SoLl3X06Rt+mkpGcom4SF+S/hqu1N2nMxiDnPMQMbr6yjyavgu1N3upK9ZydMYsoxg7W+wrOV8hcmZ7ziaA+2dp77rumEnG6Cw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 26 Sep 2022 16:50:22 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220922160516.5929-1-roger.pau@citrix.com> <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> X-ClientProxiedBy: LO2P265CA0408.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::36) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB5990:EE_ X-MS-Office365-Filtering-Correlation-Id: fb39643d-9f01-47d9-17a4-08da9fce72f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vghvFZyglUmpxVFpvfv/OLTg0EI/2Wn6A0TQrIatbJQf6rEtVop6BVq173sHvCD/l4yO4RvG/s83Ox9xzxIkPSCz4fxMN5QX69Q3J9MqyDsXA2cogtg3HeapaVqQvVygPdvm8N3t4v2exIWJft6HC78rpzhwQnhtKgTOG/wpRdnhnn1/UwJ+4j7JMBnEBDIp7xjZ8Bz6UY13dJcgjBOtmavPlVrEIEj1yjWlyLy4WlcIVFB2EaDmb7T4od+RJaqLTbWcEJrnJSZWspJPOyjHVM9UQBIv57yI+5uQuFOJrcnc4WtCnOdu7fVw4Z6GRAEkqypiSKC+H4vpVRxT0TKyC+lsUCdLXqDjN6exY1dSEiMhWbYO0tegRctKbSrZfyOQT5f8Rdq2TIE3hgG9+NBn0lFnRMLGfUFT3M1c/x24eK/pqF0RUOGe8P/z3uBxxOoL5VVKw/+g7qdFpdJCh4X+orHpJsVeDO45r6lHlqKxALufTjMpTO+ShAoYKHI7q1RVfxzpm/bAjywOP+63B6jsWsTtnsM9+18895+A0jD0gLfjkygXdW+MNxUci19PFT1zLhiyJa6DOMXClM9QM9elBJBhGb7j70ajEknK0LP6NffPIyJGe6R6U3O1XkoqzC5C9F8VzlkLBIMkRwlu8Zy0a8E/KsRkv3jQuC8l+TFv7iA14PLMBbsJG7P1kaDCrLgS/A7Vd+8yke9yCCK5gapTDw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(451199015)(54906003)(6916009)(6486002)(316002)(478600001)(83380400001)(66946007)(66556008)(66476007)(8676002)(4326008)(41300700001)(6666004)(6506007)(85182001)(5660300002)(53546011)(26005)(6512007)(9686003)(2906002)(8936002)(186003)(82960400001)(38100700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0VOcklJVThjdkM5blVnYzV2VjlJaUtwQmdYWlFOOG1adWZ1WkRXYjBMY2Nm?= =?utf-8?B?dDNtaGszM29XSGs2bElFUzU3Y1J5blQvbG9VL2kvamt6OGYxSDUraXYzM2oy?= =?utf-8?B?Z2ExTTZNdnJXbWVjSEZnNkIzNE83YU1Hdld1WTFZeEhMOVJnbFpyb0NJQllp?= =?utf-8?B?SkYvZ1JJbm80eEpSS3RxV05aWVd4eHhWK0hmc2dzMjRTKzZ4eWxFV0NvNHJr?= =?utf-8?B?WDN2aFpDYmlkWURQMks1ODNpNGpFcXplRDJkamV2ZXBtUG45NGl6ZGhSSFc5?= =?utf-8?B?MytFV0VaY28zeGRTb3FoQzlHNllEcDBEWXlta1JRWVUrVXU5NXdNWm5DWlRh?= =?utf-8?B?M201eVBvWVNZbDZOZVVjUkEyY29wcjhPYmhod1RjOVV1L2MxeWd6Vkpsa21p?= =?utf-8?B?WlJ2NnlUNmlMa01DdTJjQ2U0Qkw5L2ZiL2d1VEV0T1NLQWN0cnZ0aEVHU0xl?= =?utf-8?B?cTNwaVBwc1R1WC83QWZMOXJLeUxBcDBzdjJmTGhmcVlDWUV6Z250SmxPREhp?= =?utf-8?B?N2tEbkhnSi9aNU52MFJ5R2NiZWN0ZEc5RWNudTB6SkNneVFqUXkwNjdTcllN?= =?utf-8?B?ZkhiRXordS9yMjRVdkVQdDR6WGFQT1NQZTFoQjlVdW5nUXdaSW1OVXhNUmY3?= =?utf-8?B?RGI3azBCN0tBNDNZNDBjNk1aVGFJM2RESjFoWG9aSko3RUFTN1JtL1hlNXdY?= =?utf-8?B?TnFOOVhLUm44U3gra1oydmFVUWlXNmdWOEg4bno3d1YzcTNRdzFLd2pFVWV0?= =?utf-8?B?TWNyQk5ENUFkVlZ4Z2JLWGNRaXJoK1NSdXZDcE0wZXVJR1FaUXJMOGhhYU1V?= =?utf-8?B?cEFsU1Z1NG5CQkhCN0dIYWVDbmJ3dU1nUUV5YzZlVzFjTmdDdXFEQUh2Uno5?= =?utf-8?B?dTNuNFZVQjVKUk90WVlKSEc3SWFVL1g0VVNFeG5HN3ZSNTg5VHIxMXJJWXor?= =?utf-8?B?N3VNOUt1OTM2aEFRMGQyMDhnakVpbjRTSGJDeHo2YmxBUTRORFZWamhHMnE4?= =?utf-8?B?ZzMrK2xXdHJNTGhQWThPTC9iTmJoeEZUU1lIV0lnS0IxdG96ZnNYRGhEKzl4?= =?utf-8?B?a3BxT25zMjAwb1REektrN0RpMVpiMHQ3V0FPMi9CdnhKV2RCeUUrcTUwVy8w?= =?utf-8?B?M2UwV3Y2QUVpMHp4SkJzbFF4RVhMNUltb0lRQ3BRNWxXRXZvM3ZtLzFKOHE1?= =?utf-8?B?emUwSit5TXNHQ0RQSFNiOFpPYVVhNks5Y29BZWE3UU1XV1g2aXFVcGcxNUJI?= =?utf-8?B?TnJHenlxVVNXN2pBc1VNd1ZiUWNpa2xvSjlSZVR4S3NzNkxaTkRBVHFXS1Fy?= =?utf-8?B?Tnc0bHEyZ2FGL3VMZ05aMWpIQkhpeVRWU2t0amJQYTlkZVpuczB6S1NHQTda?= =?utf-8?B?OHpVdWcyVWN6SUdMbW9lSU1vM3NxUFFlNXFxWHV4NlZsUC9PWHNRbjdPL3lS?= =?utf-8?B?K2pNaUlEbGFWanF3OEg3WDg1VHoyaFNSS3JiN21ISHBUV1ZMZFJOWGRwaDky?= =?utf-8?B?Q3MyUEkwa08rTnpRUmpxWDFkUVhrSmN4NHYrMjJhdUtZMDAvTCtEQ3Y2d0dR?= =?utf-8?B?YUZPTHp1c2VKZ0YzL2Z5NkN3bnROYTFYbVdoV2IzWERkOXJEamFrcVYwSGJu?= =?utf-8?B?VVdPakROZ2ZIb2ZJVUdZUXNKdlk3dVdHYm53VlBYOUtNMVV1WXVSUnRTZ1A1?= =?utf-8?B?NHpkQTZ0YzA1Vjd5WVJIYzRYS2hKb1VQMHZxTVBjK0VyLzlXZ25GRFhKRUhl?= =?utf-8?B?UndyaG1uYTliSVU3OTNpVDFBNUJpZUNOVTdCZC83WHBNOFFBSFloY3BYNTRM?= =?utf-8?B?WWdMTTJWRHFDWXZrcjhBbFoxNUMra2htZlpiK1BkSU0vSXFzakFjYzF3MlVZ?= =?utf-8?B?eElkdVVVN3VraG8rc3Z6Vlh3K0ROdjhGV0RPOW9pY2VNMVcvWHRPQ0tpeDJx?= =?utf-8?B?ZGNLQys1akI4emZuVmM1czFWZVNVUXZ4NzgySXJVQ3FWa1NmY2RNVmxUSkQ1?= =?utf-8?B?TG9TNGQ1dVJIVUtOMUh2WFFuelBoK3RidDM0UWZ1T1JkWHV0NnhvZDJtelNG?= =?utf-8?B?NDRFQnRCT1dtZTVwY05rbUFPei9UUzd0ckxZOUI3NWtTYmQ2MmxBNlJDYTJ0?= =?utf-8?B?SitsUnBBODQ4T01IRWwwUFYyMGthR0dYd0ZSdkZ4Qzkzb2tvcWR0UnBGVlM3?= =?utf-8?B?aGc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb39643d-9f01-47d9-17a4-08da9fce72f5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:50:27.0059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iLILTDEWcT2+mEg1hFEOLXZc1ng0k4QEAcZt51GsHX3oBo2G+iZtGbVxKNQ/fHvHhI4nCMq1TxldCS3l/j9A8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5990 On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: > On 23.09.2022 10:35, Roger Pau Monné wrote: > > On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > >> On 22.09.2022 18:05, Roger Pau Monne wrote: > >>> memory_type_changed() is currently only implemented for Intel EPT, and > >>> results in the invalidation of EMT attributes on all the entries in > >>> the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > >>> when the guest tries to access any gfns for the first time, which > >>> results in the recalculation of the EMT for the accessed page. The > >>> vmexit and the recalculations are expensive, and as such should be > >>> avoided when possible. > >>> > >>> Remove the call to memory_type_changed() from > >>> XEN_DOMCTL_memory_mapping: there are no modifications of the > >>> iomem_caps ranges anymore that could alter the return of > >>> cache_flush_permitted() from that domctl. > >> > >> I certainly agree - this was an oversight when the two aspects were > >> split. One might argue this is a (performance) fix to the earlier > >> commit, and hence might want to go on its own with a Fixes: tag. > > > > Was wondering myself, didn't add the 'Fixes:' tag because of the extra > > content. > > > >>> Calls to memory_type_changed() resulting from changes to the domain > >>> iomem_caps or ioport_caps ranges are only relevant for EMT > >>> calculations if the IOMMU is not enabled, and the call has resulted in > >>> a change to the return value of cache_flush_permitted(). > >> > >> I'm less certain here: These shouldn't be frequent operations, so > >> their impact on the guest should be limited? > > > > Citrix has an use case for vGPU where IOMMU regions are added and > > removed during guest runtime. Such functionality makes uses of both > > XEN_DOMCTL_iomem_permission and XEN_DOMCTL_memory_mapping. > > I see. Maybe this would want saying in the description, to express > that there's little expected benefit for upstream. I guess any OS that moves BARs around will also trigger such code paths, but that might not be very common. I can add something to the description. > > While the memory_type_changed() call in XEN_DOMCTL_memory_mapping > > seems to be the most problematic performance wise, I though it was > > nice to try to avoid memory_type_changed() as much as possible, as > > those tax the guest quite heavily with EPT_MISCONFIG faults and the > > recalculation logic. > > Trying to avoid this is certainly desirable, I agree. But we need > to make sure that it's not "easy" to break things by touching one > place but leaving others alone which really would need keeping in > sync. Therefore I'd see such added logic as acceptable only if the > risk towards future changes is sufficiently low. > > >> And if we were to restrict the calls, I think we need to clearly > >> tie together the various places which need updating together in > >> case e.g. the condition in epte_get_entry_emt() is changed. > >> Minimally by way of comments, but maybe by way of a small helper > >> function (for which I can't seem to be able to think of a good > >> name) sitting next to epte_get_entry_emt(). > > > > Such helper function is also kind of problematic, as it would have to > > live in p2m-ept.c but be used in domctl.c and x86/domctl.c? It would > > have to go through the p2m_domain indirection structure. > > It would need abstraction at the arch level as well as for !HVM configs > on x86. I'm not sure the indirection layer would actually be needed, as > the contents of the function - despite wanting placing in p2m-ept.c - > isn't really vendor dependent. (If AMD/SVM gained a need for a similar > helper, things would nee re-evaluating.) Maybe it would be better to add the calls to memory_type_changed() directly in iomem_{permit,deny}_access() and ioports_{permit,deny}_access itself? That would also allow to remove the noop Arm memory_type_changed() halper. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:00:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411915.655040 (Exim 4.92) (envelope-from ) id 1ocpaM-0005jb-FC; Mon, 26 Sep 2022 14:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411915.655040; Mon, 26 Sep 2022 14:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpaM-0005jU-CQ; Mon, 26 Sep 2022 14:59:54 +0000 Received: by outflank-mailman (input) for mailman id 411915; Mon, 26 Sep 2022 14:59:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpaL-0005jO-Ff for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 14:59:53 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dee9a16b-3dab-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 16:59:51 +0200 (CEST) Received: from MW4PR03CA0070.namprd03.prod.outlook.com (2603:10b6:303:b6::15) by BL1PR12MB5160.namprd12.prod.outlook.com (2603:10b6:208:311::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 14:59:46 +0000 Received: from CO1NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::79) by MW4PR03CA0070.outlook.office365.com (2603:10b6:303:b6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Mon, 26 Sep 2022 14:59:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT065.mail.protection.outlook.com (10.13.174.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Mon, 26 Sep 2022 14:59:46 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 09:59:41 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 26 Sep 2022 09:59:36 -0500 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 26 Sep 2022 09:59:36 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dee9a16b-3dab-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kp+TEQsgNc4E8wW8t+bWEXPr7EqS2YCObHIjksipaX8CNmmDL7iM45vcCnjQGbgdbr1se56qEginHq/4+5slK84W9ZpcLBNZ2xveaQakcl6S+BKH05Xl26qJUbIy71XJQarYMpStUGYlNx3UbATS62rc/XVouLkuWf+G6cREjNswdV0O1K492/+9UOtTF+70L5t7w+4Sc5v3OcUtbS80b3T6rK5/r2lS2UBEjvdopt+i9MFf2B8rmSEy8h5nyS26aYKEco5400PPyP0+nWrPQ9xukBX0LrR6WADzYKIYKlu9CqCukCu6RqLoX6pzoYjgjdFyyoCPhiCy+qBpuGKO6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tpsHDvobjZSN/NAv9lqO/Wf0Q9sPdxa6UxR8kDW8pmw=; b=Ds0zdj3oaMnUdkjWwtk+ZoctftexLEpoht0pdV1HBpEcoSQGApQ6hIDkZ8JB/Lhaz2tITYc2TGXOCxE6AplNBau2/qA/QA/U+p9ilpUkwjYiGxpiUAfTMTXUTRDnTUYw7fsYuvBLwzJDhCiBj1lkrNkFcZmWVgruzlN+sq+O8MjQboXnqpf2NE1/T47QuC1NvOa+uF+oWXhwUIBmJI960WHqu1JbOfO395fb+2xzRzGzzBOddy19yVKrDtNZqLtwTMJjKWYQYyw3Dax0ouOo5BD9hli25kZNWWXuhsACP6YRTo2de5SGgKF6ndDlIVrkJb2Xt0JUhWsLjS2CwEC6tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=stew.dk smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tpsHDvobjZSN/NAv9lqO/Wf0Q9sPdxa6UxR8kDW8pmw=; b=x1JFxZWEeeLofGzosJ1OYcMcZ9ZgE16JkahGmZIib0lwHwMnDT4mjbvFFPNaQcjJFpStyMYO5MLPIaryLubq+TL9zazss2vBZA8jX4OdshHaAv77nZG+XI1oN3VRImxsAZ6grlWacSSdJ61wLjhQJ4Q0Hq8YqF7inLMZ49/aNN0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <495c6147-17ac-ab4e-27ec-1cab394c57c3@amd.com> Date: Mon, 26 Sep 2022 16:59:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Content-Language: en-US To: Stewart Hildebrand , CC: Doug Goldstein , Stefano Stabellini References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-7-michal.orzel@amd.com> <2abd4de9-5382-3ca3-5d2e-81ddc79d3b95@stew.dk> From: Michal Orzel In-Reply-To: <2abd4de9-5382-3ca3-5d2e-81ddc79d3b95@stew.dk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT065:EE_|BL1PR12MB5160:EE_ X-MS-Office365-Filtering-Correlation-Id: bcf3456a-d106-41f7-3fab-08da9fcfc079 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CuMAkc6vzZ/a1eGUTAARlGBzH0vvM3tfG4D89pF1KJSUKUsKt/Myhd8fJMGiBV4oRcLywOgdyPhlAgmWZI0hITdV1c6vkb2jafpBl3E75X2Oea6I2gB4H4E5/IAdcy8fgVS9tOt511lRUuCaz89vgibWHYfaExA821odQibAdngo5sGDH2ktN3UFgEj5B0csrGYCgAoeyCmhzisppI5aRJ6WQh+BVuaecqSdYReSUxuVcRdlk/Flmx0ajbb5oOTra7btcezcceoBYb5WGM855H18eUil8cmKLItNzOMWFQTiA3qJpKZnBUvtJr/yHtY7BQ519beyt+jmAH3n8+yv8ziDJXCd1GQoH/tNWUmUAs9M7ObovekuUM4BR709OeRg3stp0uVVC9WAiDKJ7Qaheb4H/CcbjU3D91VeUSBbh9A7XD7986jo38Gg8t7KKWL+AYZBvNJ5pJ69N4yPD3Pqd9p2ZxvRD9+XZyzr5tFCfPVyzggdzH3SthKUtJ8GoZ1iICo9iPtDjgP0GzBbXmaLsiSlIQ0UgYnMAjeedwwyHtujqgK0umA0JHzzABgjKCi2dj7reYMPfqb0w51aPlQZqRIx5fvnclRPTqZ2A7aIVTyWhqno0H3Po+LUKxQZLwdnDHs1KDtOjZW2VtPN4TbTSBmnnAnZpOLpTNCGFkgvocTaBJv4s2Ar7DA8aW38Sd/aF0rbCHrLBAQ5et6B6Ek/R0F2G0Ro7tzfs+/HvsAMWQKVx7aystuUZ1Su9MMbQ6j6hHvzVMeQUxka4YRvWxeobLGuv1M9UwabizAq1wJxWHW52oW5HgGY5OzNbei0265zuPuZDsr4Tv/BlstrhVdsCg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(316002)(16576012)(31686004)(110136005)(54906003)(4326008)(70586007)(31696002)(70206006)(40480700001)(8676002)(86362001)(53546011)(26005)(36756003)(83380400001)(36860700001)(47076005)(44832011)(5660300002)(82310400005)(8936002)(41300700001)(40460700003)(336012)(426003)(2616005)(82740400003)(478600001)(186003)(2906002)(81166007)(356005)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:59:46.0689 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcf3456a-d106-41f7-3fab-08da9fcfc079 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5160 Hi Stewart, On 26/09/2022 16:46, Stewart Hildebrand wrote: > > > On 9/26/22 07:04, Michal Orzel wrote: >> Take an example from arm64 qemu test scripts and use ImageBuilder >> to generate u-boot script automatically. Calculating the addresses >> manually is quite error prone and also we will be able to benefit >> from using ImageBuilder when adding domUs to this test in the future. >> >> Install and use u-boot from the debian package. >> Modify the script so that binaries are loaded from u-boot via tftp. >> Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always >> set to pl011 node path. >> >> Signed-off-by: Michal Orzel >> --- >> Changes in v2: >> - add explanation in commit msg why we remove dtuart path >> --- >> automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- >> 1 file changed, 27 insertions(+), 30 deletions(-) >> >> diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh >> index 530f3892fdd3..765facbe4d66 100755 >> --- a/automation/scripts/qemu-smoke-arm32.sh >> +++ b/automation/scripts/qemu-smoke-arm32.sh >> @@ -4,7 +4,9 @@ set -ex >> >> export DEBIAN_FRONTENT=noninteractive > > While you are here, there's a typo. s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/ This is a good catch. Thanks! It looks like all the Arm scripts use FRONTENT instead of FRONTEND. This is clearly incorrect. I will need to fix all the occurrences as part of this cleanup series. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:03:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411922.655051 (Exim 4.92) (envelope-from ) id 1ocpeJ-00079z-01; Mon, 26 Sep 2022 15:03:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411922.655051; Mon, 26 Sep 2022 15:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpeI-00079s-TL; Mon, 26 Sep 2022 15:03:58 +0000 Received: by outflank-mailman (input) for mailman id 411922; Mon, 26 Sep 2022 15:03:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpeI-00079m-D9 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:03:58 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6efed4e8-3dac-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 17:03:54 +0200 (CEST) Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 11:03:50 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5125.namprd03.prod.outlook.com (2603:10b6:a03:1ea::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 15:03:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 15:03:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6efed4e8-3dac-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664204634; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5SSxavPw4xWYJetbat/VS+AdMCPlzzJjW644APJlZMw=; b=euy97bLjzwYMjY5YiqVHK3AGqOx9zPLVWAq83DkQaDhWAyepr4OHSidv Jb7zzAP6BYe2S3LI2HjHepqYSHo0jjn0Z0F4JQIaLt7+n93dc36I2gBMk DSVxtFLVQPcNPZzQY+ef+4w98woHs7jrxUmvlCFauA5/w5utEjcR0UPs2 M=; X-IronPort-RemoteIP: 104.47.70.101 X-IronPort-MID: 81789166 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ADJIRK+Hzdp2U+XeLP7XDrUDQH+TJUtcMsCJ2f8bNWPcYEJGY0x3n zAbUG2DO62DN2X1ed9yad+18UlUvsLVmIdrQFRprC88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gFaYDkpOs/jZ8EI14qyr0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGHEcVL64q6u9OHkZc5 6MnbzI8SQ+PrrfjqF67YrEEasULCuDOZdtakFc/iDbTALAhXIzJRLjM6ZlAxjAsi8tSHPHYI c0EdT5oaxeGaBpKUrsVIMtmwKH02T+gK3sB8Av9SakfugA/yCRY1rT3PcWTUduNXchPxW6Tp 37c/nS/CRYfXDCa4WrcrSL937GR9c/9cLMOFIeY599Nu2ew+Cs3DDkpdgOUj/bs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c99ZCegz8gyO4qvS/QeCB2IAQyJBadopr8s/T3oh0 Vrht/PkAyZ+9oKcT321/62R6zi1PEA9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q w1mtwA7jrQXyMQNiKOy+Amfhyr2/8CQCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnwjxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:TFEmMqG23eKMyO8ppLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81789166" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lczosvXNm0f2zVXBNTohLAsEMG3eA8MkW3qwvjPUaoALmT8THuIL4Xo5gnimh3R1yBQII2+crW1MMgvK94Xjd6nxO0BlqksfvXLRlOCYQEMwYUHKpNZBt7ogW4ZndBcFVAy8011Dk5DX0+S/uPta14c3rzx1ZuM+BYaGyzh0ts9ICasfBJ9KZ66Fslmq9Q7kIhDCxpBU/jUS+SAEeS15fJ7xkx/CUr2LDueBn0PiRmTbIAUvcbii1P4gTSmJ1ovkoqQP+r1KkDiJPcRGu93EUQM3i3LFrps2jlGUAGPf7FRzO7Pb1F0yKBgzbUF6agQBXjIpCn2zYYj3YFdVFNBY3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5SSxavPw4xWYJetbat/VS+AdMCPlzzJjW644APJlZMw=; b=af521yfhI/kip2i4Edt2KRLpSTl2+kUYCExvzPhLXa/34Y/9WmlZYzfKfGg5w0CqjcTxAPPxI6FwVeavdpLG0tZTkyl4BkSa5/GqH+J9BGBo4jTXaoXVEVLqP+Lvri4FSB7+7VWV1ZvXtVT6/xCYCaMThdQPCRIj0qy84dl5kds8MT3ZGNE8vhjHSHEG1YaeBK/WmZc55C9fsyN1GunMZmhZqgANG5c3Vp5g4q1WsHx3hw+kmXIFSvGYjl0eVjJOug9PshwnMRBrUcYwtKnUTJIflh+i7cpS/uc0MUox14NnZVvfItTfTb0TBYhboBFGL+AtYpCqqV75Uuu8PtSSSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5SSxavPw4xWYJetbat/VS+AdMCPlzzJjW644APJlZMw=; b=FXFk0YYaUeD1qbxLnFGCNARk/c363mgW2JwFpphPiyyfR7Ju6Edb+Gdaj54I1Q9ZewWxs5zKsp7+IwtYsHLyV76qC3nQMaHLRwDjenHiFFHKXPv6qzroHm8hDJslP29+XTgJ1DQNQPJNScZ1c8fs9Yf7XwRfFWUJXyXGbjNaJUE= From: Andrew Cooper To: Jan Beulich CC: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Henry Wang , Xen-devel Subject: Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Topic: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Index: AQHY0ZgJqCa/HgBJ80OfcMoFcfGuLq3xog2AgAAtHYA= Date: Mon, 26 Sep 2022 15:03:48 +0000 Message-ID: <838577ad-dc00-d440-ce96-56a85ff7cb83@citrix.com> References: <20220926110547.21287-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BY5PR03MB5125:EE_ x-ms-office365-filtering-correlation-id: 198d4c66-52f5-40e3-27ba-08da9fd050e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mAfQ0FMahnA3PK39BNhdSgfRW/IGulRaidyooNgeSBieIUIxgMTFv7FR9Pef2DWCtFYkrMi5WMUZjKkJ+c7/ynQdWsak8+TZfmBsovTHCPk/R1jfwwViS28G0aRR7yQhRMc4nNQ6g/Nr/nr3kbUKbGLc+ZOREwHqi9hwPuiPoDaq4fIvLs7BiS8vFE0hLE560VQqWYZg1ermV/U9uSvb0/v5JkzdpOpuPUxHub3Jf2GEpqXjzGoSbrsKSGxlTNOK7WQMkSP3YAhlEEFqUd+FJchfBSII9Lmvkw2DHqcoi/OZ4QKB/jo33lcE+8rDBp+2tHU4CKlkZdKm0H1yg47GeQEQKWKU7JL33l9Bl3XnHVdNjz43HUtutykR2ZauJtpzKAjVd18hiD172OH73oA3MdhhPEi7YGT4o6v0UlwKclXVVPSJFDvnUjrTQsNFXktVWiuZSZYr0GBrn2D3a9KGaxqPy5IqUxwWFvW8gew/AGOM82vBedGa3x0y3HayLmYk4ZMdBCWVatHMlKJricUKEEcHpMCNSX8isIhXiM5wcgVkd5wQ4Y4gLicNkmpmnAmmp+T7SRmhEoxhSvvXippS9h42zFr+JpFRSir6IWANEPJu9LPiv+f+ZmIJRv4kt4qPrHY4nKKb140du9cB8K9PIEuwKWrlkv2jgKZAvrfQZ35DxAQH6yXM7I5dRJ1QH0Pts1zCbPp6mdppA6btvQgaQQvHPiuES19yhHfUHhBzqLy0XSbMnniMMuwlFm3FrlpAjRDFaSAG7r3N7U5h23Nce5e2ty0hqPHOlviHQ6cLO7w2RI5n68vlPyPBMpICcsXsBcXe335C9Tgxex19djh95qEjOjUA981d8mYQpQXfpMY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(136003)(346002)(39850400004)(451199015)(36756003)(38070700005)(82960400001)(31696002)(86362001)(38100700002)(122000001)(2906002)(5660300002)(4744005)(6486002)(478600001)(71200400001)(91956017)(4326008)(66446008)(8676002)(76116006)(64756008)(66946007)(66476007)(66556008)(6916009)(54906003)(316002)(8936002)(186003)(83380400001)(41300700001)(966005)(2616005)(6506007)(26005)(6512007)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q0ZJVjU2T2p4ckhmbHVWbXBXa2ZxNVRDTDcreUpIMlNrU2NVVjBmSTRSbVdG?= =?utf-8?B?cWExdXE0Q05NeFRnTTY3Z0hTa1hhdk1sc0VvRTBNMFhuUk93dmxoMFBtKzZh?= =?utf-8?B?YkpNNUE5OUlOQUdnaTdZSm9TckJYNmJyR1ZLSStjRnFlZW14WUlYcURnZlFI?= =?utf-8?B?R1QxdEFoVVJTTVRick4wK2xvblNWdWY2eXh4NVN0cnNWY05qQndNWUUrMytq?= =?utf-8?B?dzFkbWcycklUYVBKVHAyQlZaQU9La0hRS0c0blVjZEpZNi9ZUEN6ZmxraXpi?= =?utf-8?B?NUNQOUJpdzRlcUxHcWJKNThGS3d5NXBsZ0V4eXBTczBPN1RaQVVWQjZtUnZo?= =?utf-8?B?UUxKZ2R6T1JEVHFkM3poK2xTNVdtaS96QXl1NEhDS1IwM0x3QnFKdmxtNFN3?= =?utf-8?B?c0QyUkJDYVJZWXRrTEw0YkNQWVhYWjRFVkU5Z0RWR1VSRmNNNGc1ZGMybmhP?= =?utf-8?B?MzZ4UkxrQU1oT3NPWUZDRTBFd0QybUIzdEYzRnBJRzJBTmp4QXVvUkYvOUVB?= =?utf-8?B?RGJRUGZkcDdKQlBSRDZhSlk4ZG9MbjNxT3M4WVl2VytYZW5xeDBzbnpaaHVR?= =?utf-8?B?cndzS2x0K0FKd3VDTVQ2Slp5T1F4TTdjekVzdzJWZUltSGtoM0FJb3MrL1Az?= =?utf-8?B?UUlXV1lhditoWXZHNTZPUW1YS0wrYlc5Z3Fwb056K2p6RE1zWDNabW4vc2tI?= =?utf-8?B?VFNodkgrekVkZzJtaHNYRWw1OFdKWlpWWHRKZi9Od1dUMmVkZEZsR25nT05H?= =?utf-8?B?VVptNE41YWdEWThGbGtQbFBJVkcySXU0Q3J6OWI4L3NzUEhjOFdiQ1RycmtC?= =?utf-8?B?YUZCTXA2VldxMWlRMEF5a1BueTdOeFdMajltUDNBcmJFenQ5TjFBNXFvNlgv?= =?utf-8?B?aGRvT09yaVNrZlNDdHFFeUpVTVFtYXdta1o0NmRxazhGaVZ5ODFISEhrRTVj?= =?utf-8?B?RFVQRzJpSVdhZTN3L1dlS09ZRzcwaGhrOEV2Z05mV2pqVDZ0RFpiaXU2MWlv?= =?utf-8?B?aGtyRXUvNGtHNlRRRG9RaGExL1B6U0ZvK2JoTkg5bXZVQk9oM0NZSTNLUmo1?= =?utf-8?B?TmZyRTlDSlpvdHBHZjF5ZWt5cXJ4VkNyVU9aQ3lESlpCWFl5UlZ6a0I3TTEy?= =?utf-8?B?MlRsTWJJRkRVWFhObTI5YlQ5ZWQ3YUdvT0V3bjJlTDRVcHREVHpNeVYrcWZ3?= =?utf-8?B?Sk5iRG0yZUZRckg4RDhvVGNTYUwyTU9Bbkw1eG5YM1hSMVQzb1dkNjIwK0J6?= =?utf-8?B?QVN5aTN6NytleUZDNHc0OUk2cVZPeWJBNGJoQlk0M2YrRTVJYWg1dGxaaHRk?= =?utf-8?B?RTAvTDZEWVArT2U2cGpxUk5rV1NoeVpiR21PcWNqVXdKN29WcTU1TUVtUWRT?= =?utf-8?B?aElER1NmY2t2aSsvdEU5VGRKS3d2eHRlVUhvVGU3SWJScSs1eXhBNEN0djZq?= =?utf-8?B?UUZhRTJtTmV4TGhuM2VaaURnR252SDByK21BTmdwZmpGckFZeXZCM2g1Q28r?= =?utf-8?B?dEh3MDJpYTIyeURyZzVPMUVpbU9FbXd2Q256VEpJMk1Ed0NPWEtERHphK1dK?= =?utf-8?B?UFNnMTNIK21FbC9pWE9EVmk3NGlXZ1B6WDVwYko1T0U0czhFU0dOcitiVzRT?= =?utf-8?B?VlJ2VkVVOU1yYms5SjZhSjlpcUZHYVFoUlBaRVV5UENldXcwZUZxU2w1Y0lh?= =?utf-8?B?VVhCNXhHTFplOUlUSFZxUURkNjM5Q2UrQ245ZitLdndWeHMrdklJdXNLc3Zn?= =?utf-8?B?YkRLQlJld0o1VkkrQXRRUTltMFhqbS9WZUhVaEVESi9JeEM3T3NyMjJsd2xH?= =?utf-8?B?TldQWVRIMy81SVBHcVNBb3g5V05VY1BKT1FYNlk1b01zSWUwSDhrR3NXVjVt?= =?utf-8?B?WHRyMTRJeU1nQ0o5cUZlWFY4aGh5WkVlanRVdjNlM3RVV3BVMGRHdWVYUGJa?= =?utf-8?B?ZEs0ZVQ1ZVc4WHVCbUd6VnNiQXhOT3psM2hBeTRPZ1RDaUYzOHFMdlpRTkZQ?= =?utf-8?B?ZGtpMnUrTWZNckhNYVdrcFBiNS84eGFZWUVHa2JKdXJ5emlINUlRN3NTS3Q2?= =?utf-8?B?azQ1K3Fadkk2YnRzWGxkY0RpOHNzWmtDNGp3R214cUVMUUtRVUZMMnZhMTgx?= =?utf-8?Q?kZDEQOMCgxqllEsyS7OXN0yOn?= Content-Type: text/plain; charset="utf-8" Content-ID: <1D68412884DA84438DBF460152607E70@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 198d4c66-52f5-40e3-27ba-08da9fd050e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 15:03:48.4799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IS0vtDDtl5lRWpJcc0NlQkefC+utGbhkGZdEtkR9dHgJpHaB9YnabFRw9fjc1EXs/oCO9to9aM48OVELkr6cx52p8tLyolji3Ylku9ER980= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5125 T24gMjYvMDkvMjAyMiAxMzoyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjA5LjIwMjIg MTM6MDUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBodHRwczovL2dpdGxhYi5jb20veGVuLXBy b2plY3QveGVuLy0vam9icy8zMDgzMDY4OTUwI0wxNzYzDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTog QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4+IEZpeGVzOiAwMjJl NDBlZGQ0ZGMgKCJkcml2ZXJzL2NoYXI6IGFsbG93IHVzaW5nIGJvdGggZGJncD14aGNpIGFuZCBk YmdwPWVoY2kiKQ0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t Pg0KDQpUaGFua3MuDQoNCj4NCj4gSSdtIHNvcnJ5IGZvciBoYXZpbmcgbWlzc2VkIHRoaXMgZHVy aW5nIHJldmlldyAtIHdlIHdlcmUgd2VsbCBhd2FyZSB0aGlzDQo+IGlzIGxpa2VseSB0byBiZSBo YXBwZW5pbmcgKGFuZCBJJ20gcXVpdGUgY2VydGFpbiBpdCdsbCBoYXBwZW4gYWdhaW4pLg0KPiBB bnkgbmV3cyBvbiB0aGUgc3RhdHVzIG9mIHRoZSBjb21waWxlciBzaWRlIHBhdGNoPw0KDQpOb3Ro aW5nIHlldC7CoCBUaGVyZSBhcmUgb3RoZXIgbW9yZSB1cmdlbnQgZml4ZXMsIGFuZCBvdXRzdGFu ZGluZyBpc3N1ZXMNCndpdGggdGhpcyBvbmUgKGhhcyBmYWxzZSBuZWdhdGl2ZXMgdGhyb3VnaCBm dW5jdGlvbiBwb2ludGVyIGNhc3RzKSwgYW5kDQphbGwgYm91bmRlZCBieSBubyB0aW1lLg0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:07:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411929.655062 (Exim 4.92) (envelope-from ) id 1ocphf-0007qz-Et; Mon, 26 Sep 2022 15:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411929.655062; Mon, 26 Sep 2022 15:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocphf-0007qs-C2; Mon, 26 Sep 2022 15:07:27 +0000 Received: by outflank-mailman (input) for mailman id 411929; Mon, 26 Sep 2022 15:07:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocphd-0007qm-Ro for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:07:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec6f9b89-3dac-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:07:24 +0200 (CEST) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 11:07:16 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5029.namprd03.prod.outlook.com (2603:10b6:a03:1e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 15:07:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 15:07:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec6f9b89-3dac-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664204844; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=d/TUs7nhFi9e6U9lHfFx63WCFDYA++mTFdSPxCHi0lg=; b=GxeFUBfrVCqiQhRC8XBGiFolgthLoU4gPYzAEO6RD4q18PS3m5FT/R5s 8uEu3F+oASVjyAvTfc78ji5OxGqEhpfQTNuyUC4fHOrN69MaQOR2UFYYS KeB29ebKHgU8ZHp69i3OptH0fq8RlOl57w1oQQh9KKdVm34DLdH87Moic A=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 81017798 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iK1P8KJZIbATWyL9FE+RCJQlxSXFcZb7ZxGr2PjKsXjdYENShGBRx zYcWDuDbPmDY2T8KYokPI+29kkD7JOEmIRgHFdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/PZ9ks21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEmeRrM3EHBtQj99lKA3kVr NgCCTcsV0XW7w626OrTpuhEoO0GdZGuEKZB/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H11j+mK2UwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIzGkWParSP87gPJtS/xYYkLN7iFzeE0mQK44kBQEwAYD2Lu9JFVjWb7AbqzM Xc83jclpO4c/UqgQ935QjWxunvCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht/HDCCFrsbaVYWmA7brSpjS3UQAQJHUHbDUJTiME5cfiu4A5ih/TTtdlH7Wxh9ezEjb1q xiqoS4klvMshMgE/6yh+BbMhDfEm3TSZgs85wGSUmf76Ap8Pdahf9bxsQCd6utcJoGESFXHp GIDh8WV8OEJC9eKiTCJR+IOWrqu4p5pLQHhvLKmJLF5nxzFxpJpVds4DO1WTKuxDvs5RA== IronPort-HdrOrdr: A9a23:mCuSnak99XUjk8lU0doJxwArJ4vpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81017798" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWZdoRaT491vAVoQK9DZwWVynJj/NxC7LitUfhQs+GP8luLIDs3DxF2NowBRaXPXdu3fDrzbO/X4MZuZo7efkoB7CPmgfSFJtq/dD1N72o8dKy9/9yIt9lnsdH97r3UVyeil/2hZzHV6Rl6qxKQC/yi+P6f193yRZaV7vrP8Nbjl5IRqsBIRFGJOk/2VlQm9ZGMipWS3PU3Sml6HKRj6y5O/Ml6wAp+1UL2If0MGKV6uZV/ZeenH7Gvnc9W6Y4wQXBI+rFZx537qTgajmEQK4uLpgXu7RWXQ9NFXwACnYg1pEMFc+V7L6YpTfbApliQGA/UKc4TZWZWL+nSiNEefOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d/TUs7nhFi9e6U9lHfFx63WCFDYA++mTFdSPxCHi0lg=; b=Ka1BHyXcoeQcVJh9Ls2uxoP5WJXDxrYRhu0z3AVx4fKkRqFb8NvxyqJuWLV3NvgZyv1ZZz37WGLdKbPwlOXQXOAo8E1TS4isz5M4z059/XK1wuArMEuLxvbqyjHISIa+28U7mrDYFU7ReKYcpPLSRgI5Qo15EUMPLLGASJetQVgwSmaY2hexkrWny+E6rroOyzvQfRh23fZLIv/qpQLLOa5xKXzzJ9qDhCSR3tcrvBJxOTRKFOD2zfTpuYQ1ik+qstqW9GDWK8R8Y8aQ6BdYKO1plGImzM2YIWqpIieLZC0XaMf0u8dkPpaWOpiJfeFm8r3+kYLzmlE0/6/OIuETiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d/TUs7nhFi9e6U9lHfFx63WCFDYA++mTFdSPxCHi0lg=; b=vRzCA+XTkxo3ODWB2742QLczAjSSv4XZslIXkj6fLVKm2ZVSrOpdnW9kqkJ7zOygdR2wscTs228+shRt65p/ROwizfJkmlXdFDlYNaqtGoV98eMquShXxtEk0FapPWjuKwi/eF3GAhPf5JgNqHbBb+gVsLuhEoj1fK6Htn+sxVc= From: Andrew Cooper To: Luca Fancellu CC: Xen-devel , Jan Beulich , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Henry Wang Subject: Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Topic: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Index: AQHY0ZgJqCa/HgBJ80OfcMoFcfGuLq3xnoGAgAAxnYA= Date: Mon, 26 Sep 2022 15:07:11 +0000 Message-ID: References: <20220926110547.21287-1-andrew.cooper3@citrix.com> <6E84757B-2CE2-4C48-AA20-C5D172E4848A@arm.com> In-Reply-To: <6E84757B-2CE2-4C48-AA20-C5D172E4848A@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BY5PR03MB5029:EE_ x-ms-office365-filtering-correlation-id: 5c0860c1-dcfb-448a-5654-08da9fd0c9f3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1vnJ9IAW4QuN0WXWvw7eQ+56X1UkNKkmxjMnJKXDecBsWXPk2o21WWOiutLBubl8tf0CCZHwtQ+wtN7YiOCKGByFVEZfKoRVtU5MCHVQ7pg9HajV98z4pQRbaqAmyxE26tI4fsDts0OB5PU4uhzDRn9ba+RPEh4Y/mL1E4gqQudyf3GdmB+Z+9TP1sRn7zoHCTjfrH6tahfYrMWUE0B7vWdQQx7hdYymQIwg1tHsEXEjW4kmg5CFq5gjTPU6wolMYdC78o/sHr4DLmID0/HN8D3fH1GeMXYgEmMOouon1WByMcxMtiYa/oLcAeoP56c+zSfCqsUnmfDlBeer2yvC9C5EUmKJVCAaMJq4dcOVCqQEFEvKd+mtRHfd67G44bIG4j3f3BPcsUQHuFjLlxiuYaoDPvP2DGw31DCZ2zmqGSTFtpGXA3ogMZDbU9S/awwmTzCk2mAUybikXZqvDwYHLFgH8WQLnHVR8VThGs9MQv0a+cSsyiCI6QX0aaPdLPluSxYrsxc/mCSItzJzbrBIhA8ZOt3PAkS7JjNM11k9156eLPPbuyGjyaWUsje2zwaNiKbryWcLP0a8FnxLYQyfSxrMbYkm5H4oXyHBOWTC2iqm4XK+W+j76WbD0SBsZvzFu2zi6GvLhdW1vsKAulTI79BYiIk+7S3rWxJoZxCtopEJYrSUjgdLiYP4MtXxrQDWu4lVH3fOPKJA8Ux54UsWXnyuGHAhVwzl9YYzxPwWXyJexB59FDOzH3EE4HXtrjRilyppvO4dbeW3bH6F1WEeOlQfT9IE3L5BsGm9Ln+H3vCyRmdXPUexh7Utc+ixcdR+fmPyXwIdvVSvMyOwKRWtQWkfFTSuGxdvk1mUbBjwE1M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(366004)(346002)(39850400004)(451199015)(558084003)(36756003)(38070700005)(31696002)(86362001)(38100700002)(122000001)(82960400001)(2906002)(5660300002)(478600001)(6486002)(71200400001)(91956017)(4326008)(8676002)(76116006)(66446008)(64756008)(66946007)(66476007)(66556008)(54906003)(316002)(8936002)(6916009)(186003)(83380400001)(41300700001)(966005)(2616005)(6512007)(6506007)(26005)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?amdKeTNHMThYaWVhMGhHTW5hSlZhbGVsRUFVa3FSQkcxWVJPc3ZQUGxUMjVZ?= =?utf-8?B?SGZ4SW9HeCs3YnplcC9ybjF6dWtESzc4QVhyUC8yL0xvZnhib1ZhVmtqWWcr?= =?utf-8?B?Snd1TkhaZW1IMUFXV2FJdzZyc040VmZIRm8yUDhqelBVTnhsTFFSTENEaEc1?= =?utf-8?B?aXJKT2ZHMUhiWjR2N2ZucWVybVo0Zkg2SWU5eElPcVpkM2dEamlxQmxhbytq?= =?utf-8?B?aHp5U3hmcE4yQU90Vy91MkkxNXpXNVUzaG5WUHlhbE5sN2pEbUdlK2hpdVE3?= =?utf-8?B?clJtTDd2aWdZVDVnZzdYbHRRdjV6bCtDNjhHZXlybWM1S1VPRzdsUmFJMUIv?= =?utf-8?B?dkhrcXR2dW9sbmllajlvT2p3anIzVW00eWVMSzBuOGdlSVl4SzF2ZW1Gbk04?= =?utf-8?B?TlhVYktvalR0WU1RSHlObFhES2N1UWsvTEc2NHhNcDJHcit1OGkrQXVxQlkz?= =?utf-8?B?dDhVaEFlTUVvbkhxTGJYb25oYmI5bmRocytKR3VZakd0TlpLZGtKY0FDTDVF?= =?utf-8?B?K2ZUdXVnQUtiZHRveUVaUHBKb0ZWa0FMcHgyS0c2V2VaczYxTTE4VUJsYW9s?= =?utf-8?B?Wjk4a3llUVlzeWU4Wm1BeDZGdzZVbEMxdldEeTJkWWJtRXBGQWlINiswUHNE?= =?utf-8?B?ZytqNkhmZUpkeWkyb0lwa1F4WWt3NWZRR3djUi9VL0lCSGhYY20rMGNYZkxB?= =?utf-8?B?ZmZhRHMwOEtoL3U1eDZsUE04UGRFbWE4ZHhUOGVNTjNXeEtjdlNmYjQ4L2Zm?= =?utf-8?B?K0d6Rk10ZW9QWnA5QUR5VHY2dUxJWnpkVmU5Y0swYXVBNnZmQ2Q1OG9aMkJ1?= =?utf-8?B?V1J4RWhIT1dXSlJhakttQjJpYmkzOFhyQXVhNjJrWHVmWVFSTjJWWDNVQXJi?= =?utf-8?B?K0EzREkwZDBVeGs5M0Juc1lSOWYva0k1SVpWbmo0VkdMcmRLaFBKWGEvS1FC?= =?utf-8?B?K1g0MEFBMHMyNTEzc3ZHRlFHakkxMlVudHgzN0pMemNnbVE0cG14eEl5RjVH?= =?utf-8?B?dUxCZ2RBNENYN3UrL3gyTnA3cE5NNjQ3c1dsMVJxaUFUL0w0blJScXh3MnJl?= =?utf-8?B?ZHBLMHJMNkpBWFd2U3h6RytGcVpwYWM3eEVSd3FnYTZ2aGlzMjV4d04rTi9n?= =?utf-8?B?YXBLTDZ2NmFzRHBZbTIvbS9nMm9BSlZ6WGIvK3lEUzRkZ0NMNk1rYnRqUUkr?= =?utf-8?B?SEZJc2pYOERnajRqSUdOS0x4QkxNS0Zmd1lzdHBtSE40bjBGNStvMFVBQ1A2?= =?utf-8?B?YzA2RzZabGxaV011QmsxaWFYTjJWaVY0TjBHby9vTWRFNnlIcGxOWFdRcUZq?= =?utf-8?B?aFFWOFlCSUExUERZVldMSTNUb3VoUjJxVU05dDFCU1NaRGtNYkVaM3Q5QjdR?= =?utf-8?B?RUdGek1qdmg0WFhaSVpGeG9EUFBXRFdJNFozWW9yWTBQMlVLTWp3QURNWlIv?= =?utf-8?B?V3B5czFBZ2hBR2Z3K2J2ZnhjSUdZcUVRa0pyVFdmakVIVE9PbjhITGVNMFFT?= =?utf-8?B?Q2tyanhwSzZibVF5clRYdXhvZkd6Yk96ZC9BWGt6b0ZBcjA3NTlaTk1pOWI0?= =?utf-8?B?Z3Y5djYwUExtdk5VYjFNdWdGVE43dW9yTjdrNlBVQVl2bjV1YkEwcEdiUjZz?= =?utf-8?B?eW5nU2NVOW1DZnFDbDljd0c0c21mbjZFL0xndTl3bWZtcCtPbHJiMHZ1Z29l?= =?utf-8?B?UFB6cmFPWm1jSkkzdWRhV3dUV0piWTY4aUs0MWN4cVJqYXhUYnQyT1JGK2lv?= =?utf-8?B?WUF5L2Y5YzhLVmoxYVV3K0pPTUo3d1VpemJVMnN2aFpRa0xZczJZdHl4K0Ez?= =?utf-8?B?RzVRTnZVakFMQ3pSbDdiZzN4QU9UbFpDV3NTRGpuZndDL1owaDdiVzV0eWVP?= =?utf-8?B?UHVTU2ZCbHpRMXhyelFlaW0xQmt5bTVNQ1I5dk9Mbzc3d2NRSy9nV2w4WUJl?= =?utf-8?B?aWplWG9mSXU3a3J4VmxCc0FTRkhlMWFVQXV5UmR1K2h6cDZkbGR1Zy9xamZ6?= =?utf-8?B?SDRQMVNRZzdad1NablhJcGJKZUZPZjZrcXJNQ3V1UzA3S2tLOVkyR1psa1Ir?= =?utf-8?B?cFBrWHdTWTZ1M1JBOXNyM0g1RzBCTWNhU0hEakMrU3p2OU5GYzUrbE9EdDNy?= =?utf-8?Q?FqEJ7JfuwtBytlF+snGdgN0vb?= Content-Type: text/plain; charset="utf-8" Content-ID: <9C4A16131DB1DF428FEA2C1F68988E98@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c0860c1-dcfb-448a-5654-08da9fd0c9f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 15:07:11.6215 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E+1uaKQ8c7K7KHvZP7vFtJGZhXkHYBesao/+j6h1pZFeJaz2equb+xOdMsf5ho+HUwYMDmE52VBmYrXHPryDY9AutZwe3bEjZF8LL+N1mmA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5029 T24gMjYvMDkvMjAyMiAxMzowOSwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4NCj4+IE9uIDI2IFNl cCAyMDIyLCBhdCAxMjowNSwgQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4gd3JvdGU6DQo+Pg0KPj4gaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3hlbi8tL2pv YnMvMzA4MzA2ODk1MCNMMTc2Mw0KPiBJcyB0aGlzIGxpbmsgcGVybWFuZW50PyBPdGhlcndpc2Ug SSB0aGluayB3ZSBzaG91bGQgcHV0IGp1c3QgdGhlIHJlYXNvbiBvZiBmYWlsdXJlDQo+IGFzIGNv bW1pdCBtZXNzYWdlLg0KDQpUaGUgbGluayBpcyBzdGFibGUsIHllcy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:12:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:12:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411938.655073 (Exim 4.92) (envelope-from ) id 1ocpmL-0000uM-6e; Mon, 26 Sep 2022 15:12:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411938.655073; Mon, 26 Sep 2022 15:12:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpmL-0000uF-3G; Mon, 26 Sep 2022 15:12:17 +0000 Received: by outflank-mailman (input) for mailman id 411938; Mon, 26 Sep 2022 15:12:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpmJ-0000u9-NE for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:12:15 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9961ba2d-3dad-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:12:14 +0200 (CEST) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 11:12:11 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM8PR03MB6261.namprd03.prod.outlook.com (2603:10b6:8:3d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 15:12:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 15:12:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9961ba2d-3dad-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664205134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=r/6lsm+ycUp/fVvijzyUDPJMWsfL6EVhyLfAS9mGOpU=; b=Jf3CHdsQkkEVX9tB+5ByTX1qQZdPgfw8OjSNVoUu1/a2bThKs0PRQZ92 t2fooLzkdsQhEzQfJrC6oz/+nFsl6XrFQ75lAvU7PcPKjp9rShz9eDcWa Vyqnui5cJpBFLpRPSlbKkY+yRfcPysdfdD4bO5Zn69APFQuSSPTRuQkPx o=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 81018546 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:WHY4/60+/tFf08XFTfbD5etwkn2cJEfYwER7XKvMYLTBsI5bpzxTn DMbWj3UPP+CYDakct5xbt+x9x4PvJHdnYRlTQI9pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8k035ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj67JjUVBqMKMaxt52O2tFy 8IlGABSdynW0opawJrjIgVtruIKCZCxeaYg4DRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2Ce5L2IwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIzGkWPVry7y7gPJtTrhfrg4H+CZzKFvoBqImVEMUEcoC3Lu9JFVjWb7AbqzM Xc8/yslraE2skuxXNT5dxS9rDiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2 TehlNrzCTtimLacU36a+/GfqjbaETMOMWYIaCsATA0Ey9ruuoc+ilTIVNkLLUKuptj8GDW1x i/QqiE73u8XlZRTi/r9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcvlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:hfF/QqOwe/1IV8BcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81018546" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mjYjrSi7gKIh6BJDwPHfaFp+t6uhFFSuu0in2wslSTokZqy0K+UZuyVk5lawuxOEKrdEeR9y6VeZoY+6sK8hVPLEvHdYT8AmOyO89OVDyhJJ1sLZaW8nYzAxgD7M96tfoYBcmzfLXY1wWZHdIHYxBNQthlhwY9zSVHsaRRZrun3DzsE5hZP7SYvKzuyzhiSFf7JRZ+EZXlKYv17yyr64nvxZDk2GqG2bM0qSupi3T/dxWfz5bMxChyHiOSBgXPDrlP9Jc5pKtZthGb3L+88sLdnhqkraEsgFBBUpydIjTMaPpNVbvgeDnG0NnSi25ZaZGkS73QUyax5kzbxZxan9cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/6lsm+ycUp/fVvijzyUDPJMWsfL6EVhyLfAS9mGOpU=; b=JLuEn3hMCBpYZeDDLpzhNd4xiV2Y3PBwIm9umsTFfQghiTh3wN/jkC4Lcyp3miGScEkZvr0uwzpsIRxUAC802MfPgUN6pc4wVZyUEvmk3KtJ/Yp+P+RE+/Oyh0zz0JRSAzuHc/MsIeUFT+48fYjO+dGvHkwueOrF0RZVFwbR9Cdww8fnypqzDxq0qtmop+xXiPESZE6GXSrBCLK46ko2GK8jfx898CBqX05n8GvQb0ZCxbkyP6CijpZEav/H6qRWnZdDz7GBJTXmVJqow3LqtMcOtQsm77+GFheJ5lCyTwiVrfQpnOBxcnLonnC3gMn9FYXhoHgmCQAZ9vSKCFrPMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/6lsm+ycUp/fVvijzyUDPJMWsfL6EVhyLfAS9mGOpU=; b=KU9U0DnZCjQUanogemCcccpc5tXZqy6xY+4blR7oIHDhny4RmWEgKyUofDx3t+mqtNaTb/YBnP+p+AVC7xipRFBmIKXDpjcyoasPLKJ3bjmxibos9dPohxq9ffZM1sMIWIDnjNU2V6Uqfo2NKX2rhO6+Lp9kAzGXYZE4q/321+I= From: Andrew Cooper To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Thread-Topic: [PATCH v2 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Thread-Index: AQHY0ZgHzFeq4zmfAECTr0SKFTbr863x0YGA Date: Mon, 26 Sep 2022 15:12:09 +0000 Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-9-michal.orzel@amd.com> In-Reply-To: <20220926110423.26030-9-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM8PR03MB6261:EE_ x-ms-office365-filtering-correlation-id: 022fab89-86fe-4678-5497-08da9fd17bc1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kkNZAuz863Uz9M+U3MHX5IIxHkQTUGiTqNDRytrSMUkL7dwRD6EsWlWuR9/GrfTgJynMiS/NW0HvvkISpSTZXCyZOIs45cCvmfUH0tZvEySDmfTKQxcKD31Xww07z/yag3RGLB2dsIRpCzsyQpNsLctAwHsW80QnNX3XQ//yzrNxUvqcrKdBXVP0heXy5Cn27Z1LdFVePEht42DnqHIMjycESI8XtCXutaJ2Gds/cZjfd2KVKV9R6uqL27owagTggVnke2Sq3wkdy5X7S8bsRMVHRnkv5PXUJVGW8Xfi8iTn/6V2fD6nHsU1K89wjHVfHIYrWByd7sfsQ6besKchybOXnp38rOQFUOv4cXyxd4iPUEHLTjpaqrFQchi0FHP0T09oOYpwYJ8/WohV8PslYKs4XpQSfk9Q7U7r/sVew3VwdIqZbAVjpkZb6jErdbspNl+rLFkYzyO+abUxWt8nM1TV4RGxe6QHzQC5nKpLGJa4PCkaZo3CCEEP4YQ9c+t9856knJYjOFGW0oUBxvYGjt1ySEvSWrXYKad8dMZHSUuBOK3Q1ctRkR3we8gwliXq74jReoHbTaM8R5X8AjOLmiuyru0LWp3zRubTfVM0jFHsj/eUSZ/fddeb2su3vOmiYGSEuRwui8kY+MGrdSTrUxRQOXkmA8Ls7phqCAl7RmehB5QN2ZJJPjj+KELdvakolk3oRCo4psenYuczhxxRXp+OyS/lHWrw4JWQpVI+x2Aq1hHAFAu2lJ+UmfZbr7A+J7FZozCe58LSE9/+JMn/sO2v6meUJn1O3c5riH8t75MxM/kYcIanYYHc7e9ZcAAgrMI2Gu/FKFyzEp5TaJAQNA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199015)(4744005)(26005)(6512007)(53546011)(36756003)(5660300002)(2616005)(8936002)(2906002)(38070700005)(66446008)(66476007)(66556008)(66946007)(64756008)(91956017)(8676002)(4326008)(76116006)(6506007)(41300700001)(122000001)(38100700002)(31696002)(86362001)(186003)(82960400001)(54906003)(110136005)(71200400001)(316002)(31686004)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S01hc3JDaXlHaVBOTHBoMGhIS0cwdXhUUkRtVTRxVkU2RURJTjZhYzRYakd2?= =?utf-8?B?SXFTYjNFZ29ITC9NWnlDNEtWa2JXSjdTWFRlTk9nYnA5NkRSdTlxZlNrK2JS?= =?utf-8?B?Ky95bFNFWEVHMkRoVE9lU1VqeEtnUnAzWS9oZ1J1ai8rRGxuYjM2ZHQ0akdC?= =?utf-8?B?djdnc2RyQVprc1FSdnZ5ZERmT2V0TWhKTmJSenFxMW5iSEsvWDZMRERUaGli?= =?utf-8?B?RnZ6OENqc3lVU01TNXhoYzlubUthSnorQWhmcHZ2Z3N3d0lPWVF5MTJiTlM3?= =?utf-8?B?VTZCNzZ3bmozaTVrNEZCVmJKajJVNVdWM1FFeFgzb0RnclFNUDNqZ01HR09U?= =?utf-8?B?UVhkVXhZMW9sL2FjRGVYUGdkSlhiclYydG5QclFiV2JJeUJsSmVCa2x1N0d1?= =?utf-8?B?aEdlUkVpczJWbnBmMmxRRUVyZjkvVTd4SXgxejQrU2FpWFlJZ3IvbzRaR0NJ?= =?utf-8?B?dHdHVG92ZFp4dDJNYTdyOTFzVC9JV04yR0VEdWs1UVZaSFFscXFDVmJJWnc2?= =?utf-8?B?czFrMDZCTFVIRFFJcmtQZk1NR1F3NXdkNkR0elJleThpbnp2WS9LUmczM0xM?= =?utf-8?B?QmFWK3JHMVVGMWFEbW5aMUw5V1R3WXF0SVpGSWxnSlBxWm1ZaEIyK01aMnV1?= =?utf-8?B?alhjOVlCSUc1dEFCbWZLejBUR01SR3VrWjhOSDhJM3NsOGwwM2pHRWw2Tkov?= =?utf-8?B?ZjVyeEZ3aDJQWE1NZkVETUdNUjA3TGpuZHJRUkhxNU1VOUZYSnM0QnNYNnk2?= =?utf-8?B?cFJzOWNLbjdDaHJkR2s5TC9PZXFLalhBcDdEcWdiQndpQUVLcjd6amhTNVE0?= =?utf-8?B?Q0JVcFpNbGxrM1lxUjZKdlgrTGdYamNnRmtyYmlNMFR2L3Fua1V6ejcyRDVz?= =?utf-8?B?VWx3UjhFN1l2c3lUVXRDZkszZHNlcmx4NytmdFl6eGE2MXdoSFZzMVVWcy8w?= =?utf-8?B?WmYrb2lvL0ZDTlNqeTYyQW8wN1p3bFFyb1RISFNRdGpNdkNLMjJTRjlUZCtF?= =?utf-8?B?SzV3RkRGK3Z2eGhJMTZzNjVhVWFwdnJQTHh0a1JTSDhBVmlBeE5WczJieEV1?= =?utf-8?B?V0JkOXRDVXp3Y0FGdkZJUnNJdS9TelRIQW1kSGVVTXlTVWR6REhyOTllZjhR?= =?utf-8?B?a0liTTMybmQxRzUzcjVETHhZZm5YeWlPMktxZzNOeEpuRGVwQ0w5RVhDZWFZ?= =?utf-8?B?WEE5THErZi9oNTUwbkN0cHlHeUFDQktvdVdCampDVS9wcXUzU1FHWHNIWGEv?= =?utf-8?B?aENNVzh5SDFheEtOV0hDRTJFbzdPSEg4MmlPTnh0TGZ4bS9vL0d2aW4wL0JP?= =?utf-8?B?eVVOdmpyNVpzWnRwdXhZUGxURmJMd2U2TURZQTlMeWtJNUZJSW81VDJPcjNl?= =?utf-8?B?OWgxN2wzR0tQaW9ZMFFqMWxHR1BoV1MzaFNWb2hOVk8rVk5uK3ptNzFxM3VQ?= =?utf-8?B?a0dNMjVxOG1nMVlPUjY1ejZXbWl4bnF1dHcvYnUwcnhjbm1QNGZtZnltODJa?= =?utf-8?B?a0thQ25JSmdLbnZiWFBrbWdOZjVURE03WTNWVzFPcUxtUG1DeTUxYTNRM2hW?= =?utf-8?B?TGxwQnZURCtLSWtBZEtDR3N2V0Z6Uk5jYlQ0TG9xWXlzMjJoVlh4bW5KN3R5?= =?utf-8?B?YU43NHQrMFVJbkNOK2dqdnFaYUd6ZTUxQVV5ZHdVUm8yTy8yUm5Xb084b1BQ?= =?utf-8?B?MnN3YW9CZ2Flb0UvN0hxMHcvbkxJclFpb2orM2JRc3czV3N3ZVdxTzBuazRP?= =?utf-8?B?MXJqODFvaTJ6MWlEU284K3FWSnlFeGlocU93SWp4WmU2NkIxY3IvSDRPT3or?= =?utf-8?B?ODNPWXBWaFloMWFKd3RGRG9ENlV0NkRYV2hvdGNXSTNzcW1wOVRORmdGUGp0?= =?utf-8?B?U0NKZlRlNVFPWGlGbWZtOExGNkw0SDBJUzk2RC9BVi8zQVIzS3JwUitKMlEr?= =?utf-8?B?Qm8vVDVhNlRtKzdXN2ZhWlpIQnE3VXZKeWtFNnlIUW1lZWo5WThDRkEyMmE2?= =?utf-8?B?UGROckRFQy9MbWZDVkhZcEg4K2NxN1gzL3NUYWs1dFZHTm9TVGdmdXhYTkZn?= =?utf-8?B?NEo1SkhuY0crcThXejNkNVFiN2UyS1piUDd4bWN4azZIUFZDUEVNYU1IVUUx?= =?utf-8?Q?iiOFgTzLZIgfUHyJzglG4FA0w?= Content-Type: text/plain; charset="utf-8" Content-ID: <110AABA9246FF74C9CF7236EAC29E0E2@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 022fab89-86fe-4678-5497-08da9fd17bc1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 15:12:09.9126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hf1NT72AdRf3rRSL5gxRwzPWFW4JxGvXwQumaiin/d8xl7znrn0GFy3HLWnmxw6/w4MeQQZC4PcqsNvA+aYn48kxW0/219d+HDbbIQsDepU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6261 T24gMjYvMDkvMjAyMiAxMjowNCwgTWljaGFsIE9yemVsIHdyb3RlOg0KPiBUZXN0aW5nIGFybTY0 IGlzIGRvbmUgdXNpbmcgdGhlIHFlbXUtYWxwaW5lLWFybTY0LnNoIGFuZA0KPiBxZW11LXNtb2tl LWFybTY0LnNoIHNjcmlwdHMuIFRoZXNlIHNjcmlwdHMgYXJlIGV4ZWN1dGVkIHdpdGggZXhhY3Rs eQ0KPiB0aGUgc2FtZSBhcnRpZmFjdHMgKGNvbnRhaW5lciwgcm9vdGZzLCBrZXJuZWwsIHFlbXUp IGFuZCB0aGUgb25seQ0KPiBkaWZmZXJlbmNlIGlzIHRoYXQgdGhlIGZvcm1lciBpcyB1c2VkIHRv IHBlcmZvcm0gZG9tMCBiYXNlZCB0ZXN0aW5nDQo+IGFuZCB0aGUgbGF0dGVyIC0gZG9tMGxlc3Mg YmFzZWQgdGVzdGluZy4NCj4NCj4gQmVjYXVzZSB0aGUgY3VycmVudCBuYW1pbmcgaXMgcXVpdGUg dW1iaWd1b3VzLCByZW5hbWUgcWVtdS1zbW9rZS1hcm02NC5zaA0KDQoiYW1iaWd1b3VzIg0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:23:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:23:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411945.655084 (Exim 4.92) (envelope-from ) id 1ocpxI-0002St-6c; Mon, 26 Sep 2022 15:23:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411945.655084; Mon, 26 Sep 2022 15:23:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpxI-0002Sm-3n; Mon, 26 Sep 2022 15:23:36 +0000 Received: by outflank-mailman (input) for mailman id 411945; Mon, 26 Sep 2022 15:23:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpxG-0002SQ-M9 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:23:34 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2068.outbound.protection.outlook.com [40.107.249.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e3944fa-3daf-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:23:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8743.eurprd04.prod.outlook.com (2603:10a6:10:2e1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 15:23:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 15:23:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e3944fa-3daf-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvGMWBGzys6WGgGw/3PTlTuRm5hM3ZDiBcQjWezLVpulYNDEwxXz5rNeJpLFAsdxFJMXs4bP0FE8k+i9iyj+lBaaTcI63Gy/DtAevnW2hB7k+iHHZhP/+ZPE5vesQfjIZdU7QhaZpwjsbx+bLbC/qmeQDvYNRSkkC9AvxwuB8aRT/7utM/Au9Uo57cdh/0msexKSIruBsoCleZpYQP2HLi88erWQB6sZgQjjzoob6CEEVMe9MA3N/mkiy+LPzYi2SO0wncwRHLPihuD9AZl5U+DNFH68Ah0EcyBaIrvs+lXiF8XZ0WSUsqHiYEFvEi5g7QRjO7cE0YrUzkmefUPn6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aJJhoMOxaU4i/GNzKhMMmRVhdWHqmy7FcW5ttvMCuUs=; b=oPqsYLRgjzBE+mkqoFC7IM4oHk9spsKyeVKrjY63baVa4dbSRbHQdGaMO1EuPdeBQEPjUBJvxjz7qjebbOWmhdrg/ci3KEqQz014ZU47Vh1gSM0s1+/RVzU+gOn+aeCpbFyF7s0x+w2ysyZ8hJ2c3z23yf2G3Mekbq9gVAdMiBN7sP3l7A4BF8h/4OAI3P4kgIQKc3YTEdVy/72M4s752osr4HrCQQLNIypLyIHZp+CwWJOb1uibrxqDzKtVRGXqtRvp1S8kVL3vET/DJUKjuq8QEPFx44PmgfPtOJzpNOdIJ/dICfAyXyXAIS8E0FuKlYPA+47HbfvRSCGuvUuyew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJJhoMOxaU4i/GNzKhMMmRVhdWHqmy7FcW5ttvMCuUs=; b=cguDe3E6UDrKxNe6bNMtlbbNwuqw9gQxw3RMXg1XN0H5N5hkjkQTPMgs9CfemZ16tvRtiRNMAUL3FiayYKD3g3YNb+Bp8dQC9FH1vK6fHzDvAyq/Q17dfHzGrM45O2Llx/nFDL5bilNNHhT+1qyqBozfDoeEsqR+czZsOtj4MIvzX9/9l5NE1ExKpGGWQNRyq+Cimjx3N+sr+aia+cG3g930iO3fIK35uJRKxx2+XQMa1RZ8d83ZWGtXOE5yTcI/7CKCIJPjUelaerYnXOgiNB70U15QvquLayRxbhYopsmn9BApnZqMTltz5DlSqVVe3ixWGkbPigq1X8x6P7WdkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 17:23:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses Content-Language: en-US To: Juergen Gross Cc: Jonathan Corbet , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-4-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220926141849.21805-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8743:EE_ X-MS-Office365-Filtering-Correlation-Id: 12924017-37c4-4d0c-0484-08da9fd31124 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QpgGP/eAiXHpw7TSAsCqKAnZfR7FR2l9X2kiMsgudDiD8Mpz4MO+warrMAoI7whHbKIsDmaa6cxlXHY7dY9l1TJTX16SFgG5xbN/4FcR6Dfxkh7aP8CkhqOQnhppzLdgJI22GhSGf3GTiOWWdEp92r1tp+Za3RHEJfmPtrZJ5vqhnqC+vtnqRMhJRzaH7w1demwioRYZ4b9q42vUaifgN+oSxKfIJNP5YFVRO0xCDBxN0upe43bxtIEBt7PznQ9P8uKxKvTo8icNsmVvYKMhkoyG3XM8VB8OqcoEiqouVK5QKB+tSggtXBHr9g8edOSDYXwYjuAC4VSmvz6sMZVr+DA2u1harIyb7DUnLJwhYZGjgPs/HoZ5wHKGzyIQ+Hc0Uv2viGzBrUa2Ltq1q6ygkHDCHLvR/XS1JFTmjDEkxoJvztNmUC6PsX3ZOQDXhaWBWzrQseBAD5wtHQmAuSPCjOwIe81IYUXHqBmFDc/KUIK9IrJQHv7jdc1M5IOMJiFv+oNoHOhpPLawU9Drpmw674NjF0n3AnxSio749M4VOyanFEtMKt9clJyGAFynOwA0AY1am/v3vG9ShBQaRPSEA6PplVJo3pXt4FeNiKf7l1SK/N4tJc6Qado2v4x5Wt2FFlH646xhf9c8QbKjUS/fYRBEA+JMMLIGblYX4sTq4unEJ9Eo5rKwiN8ubrxbKYL40UttiXv+qhMpEn3giDERJ3WMyatrODQvp4mJoX4WbceCMdNXmGL6TczqOTsxcgMqAqgoqoXeiP8mPoCfQXuUqtAN0iB0GLcSzg4MJl6KOiI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199015)(2906002)(186003)(83380400001)(2616005)(38100700002)(86362001)(36756003)(31696002)(66556008)(66476007)(66946007)(8676002)(316002)(478600001)(6636002)(54906003)(37006003)(6486002)(4326008)(6862004)(8936002)(53546011)(6506007)(26005)(6512007)(5660300002)(7416002)(6666004)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0JGRVJhamdKMlQrUEQ5OHdSc252NDcrNm50NFc4K2VnQXZtTTFBSjBpS3p2?= =?utf-8?B?QXNDTTNldTB2dWlybGNLVVhEbFAzR3RrQmVON3ZSdlhYaGpLNXZRc09iajdr?= =?utf-8?B?eUQ3R2ZSNk10Y3RRdHR2ajcxVjU4N0MxUEVrY3pISDY1N2JYUldJWjVFTnNF?= =?utf-8?B?ZERNLzBlWDZZMzl5SzcyeGZpeVJyeHBXdDFGTmJOaHpmSGpFd0hlb0NNOVln?= =?utf-8?B?ZHBsUENxNU0xUm01WmVVblVDSC9HbFZtMVhtUG5iWE9pWWhJU0lNL1psQW1z?= =?utf-8?B?M3BsWGZOdXQwQ21seTA0VGJPd0lzdEsyK1Z3d1QxWkx4U2FzMmJnanJFUmEv?= =?utf-8?B?L0lUeHhRM2IxZzhsemdIZFYzQ1UzNkRKcmdLVDBINGhRUnlUc2RiRGZhV2lH?= =?utf-8?B?K2xpYzZka0dYL0NpTmN0Y3g1b2dST25YTzRBcUFHSEpoWXVsQTF2andvN2lZ?= =?utf-8?B?UWJBR2QwelhtbGlHV0VmVXQ2YU1WY25HWU4xTFN0SUc4NzhVMi9qNlZYRDNR?= =?utf-8?B?eWVIME9HclEyQVR2WEN3U0hPeUVIQWFKVXFrL1FLOEs4RVdXRkZXcGtvalpW?= =?utf-8?B?MTVOc3RZMDV5SlI5MDVHeWxvTnNoRmEyZ25uYzY1KzU2MWgrUmtDS2xNOG9Y?= =?utf-8?B?Rk1qMVBZdVpaS2p5Mit1STlsQURDbFZrRUY2Um9LN0hxdVA2a3IxK1BWbGFJ?= =?utf-8?B?YUFMeEY1TDBSYUYvTFRLU1FDaTdBSWdXMXZQS1Y2azQ5OVFKNCs1S0FicU9k?= =?utf-8?B?a1pZS3VnN21SNXZ0VE0vSXRTaTE2MklsRXpDdlNFNDNaVVdpMXpHVVphTjRj?= =?utf-8?B?YnhXVDdLSUppSUltYjVRbVBCaWVXSE12UU4rSHdrbjlrK01uS1FCTXczZDV4?= =?utf-8?B?a0t2SEl5RXBRRS9Td0tkRnlFbStFVzNzYktPUlE1TzVtV3JRelM1VXhJT0w1?= =?utf-8?B?Ym5ESkh5Y1RCLytibDRaNUtxN1B6dUZzSlM0YTAwaXlmK0o3blNJRnBxUk9i?= =?utf-8?B?UVNDSWVNT254eWEwUUxoNHlqNHBadlhVckN1N2RJbHRpcDZsZU9DbUtYVllt?= =?utf-8?B?amk2c0NuSFZyTHZVOVhoWUo3OUR4S2VmYW5VNTlLSlMxMVhkMWV5VDhYNWdv?= =?utf-8?B?RWYvaTVuSEZ5VWkrU0MyN2ZQYTM1UzZLVEZyM0FHVU96V0w3emdKNDVJSm1q?= =?utf-8?B?THV4NENCc1psREU2WU9uOE4ramNSOUt6N0EvSEJETDZnQklBNzdxNitYY1NF?= =?utf-8?B?WVQ2QXRsVDNWNFpXNmR6UWlhM2t4QXZxQ0FtQ29xUnNuVTJabjBDbk1VWk9o?= =?utf-8?B?RDkvL3lQTlE5QlBxZU9mQ0NZdk85dnIwMzlBL080MWFqdjN2cEpMVk13L1Rl?= =?utf-8?B?dFJDQXJBMEQyY2dhamhyRDRWVVUxSU9lQ3pYYWxpUDd2Ujdlc2NNK3hSU29w?= =?utf-8?B?cy9UNVRkQitIMFJTQ1NKNDhDam1wR0ZuUTRIelRFQUlMaFByNzZwMU5nOU9D?= =?utf-8?B?RS9nV2JxV3JtTFdoZ3A0N2o4NVJUOE56RWlkLy9FekFsRzlqSTh3eVY5aVZ0?= =?utf-8?B?K3l0SklUWVd6WkFoSFZnOCtxTzJuU0VWSVpmNkREcDBBYTlPeU9DV0c0V3VK?= =?utf-8?B?MEZpUEpHT1FGMXQ0U1M2Nm5oS2swZmpER0F3ZGtoU2Z4ODM1Y1Ird3dHeE9t?= =?utf-8?B?eWp0bGhIOU12QWx0RTdDNTlabTBma1JSRmJ2NElUMTFWdVlRTDRXYm1JcCtI?= =?utf-8?B?NE9sYmFRNmxGVS9zZlF3MGx0QWE4VHNWbWZjZUJBcFlxOHZKd1J1NGl4RlNY?= =?utf-8?B?ZFcxTzU0VzBVZFYxd1hOTnNKUHhNRHlXekRkOGpZc2xWQzdvQ2g2YmM1cTdW?= =?utf-8?B?dmdSdW1oNkdCazJxL25iMko2eFRRbG1GVy9oMUUxQVNGQ0Ewbncwb3R1ek14?= =?utf-8?B?a28vMzQ2YmVEZ09xbFFBcEcwMVJYbHFVWHpGZGdQNHVLcmsxT2J2RnpkK3dS?= =?utf-8?B?SmxmYlJueTd6aU5ybDVadjhQVHhWVThYOTZtRGVPMUNHRnNvYzBWQ3o2elc4?= =?utf-8?B?Qld4aHFJRlNtUUI0VTRwT0VZYXFxL2E1WnloaDZSS0FMR0JhV0o2OStQRk1F?= =?utf-8?Q?aMZq6VU2pz0a+tpXzTCtX+TIo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12924017-37c4-4d0c-0484-08da9fd31124 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:23:30.1929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rRmoEEsKe+hTYRjiM1xJ86epAN5DiKDMhl8Tn9EtkjbEiECj0eF+fvp407vFAfsB744OzwWhHjYQpG5ftQ53fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8743 On 26.09.2022 16:18, Juergen Gross wrote: > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -92,3 +92,12 @@ config XEN_DOM0 > select X86_X2APIC if XEN_PVH && X86_64 > help > Support running as a Xen Dom0 guest. > + > +config XEN_PV_MSR_SAFE > + bool "Always use safe MSR accesses in PV guests" > + default y Is there any time line when this default will change, perhaps first to DEBUG and later to N? > @@ -1010,22 +1020,16 @@ static int xen_write_msr_safe(unsigned int msr, unsigned int low, > > static u64 xen_read_msr(unsigned int msr) > { > - /* > - * This will silently swallow a #GP from RDMSR. It may be worth > - * changing that. > - */ > int err; > > - return xen_read_msr_safe(msr, &err); > + return xen_do_read_msr(msr, xen_msr_safe ? &err : NULL); > } When we were talking at the session, I think I said that at least there is no uninitialized value being passed back. But I did look at xen_read_msr_safe() only, which indeed is okay. Whereas native_read_msr_safe() isn't (nor is native_read_msr() afaict), so I think part of this series should be to also eliminate the undefined- ness from this code path (possible now only when xen_msr_safe is true, but as per above that'll be the default at least for some time), where the caller has no way to know that it shouldn't look at the value. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:25:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:25:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411952.655095 (Exim 4.92) (envelope-from ) id 1ocpzS-00036x-KO; Mon, 26 Sep 2022 15:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411952.655095; Mon, 26 Sep 2022 15:25:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpzS-00036q-Hi; Mon, 26 Sep 2022 15:25:50 +0000 Received: by outflank-mailman (input) for mailman id 411952; Mon, 26 Sep 2022 15:25:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocpzR-00036h-3V for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:25:49 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e166a69-3daf-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:25:47 +0200 (CEST) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 11:25:44 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6356.namprd03.prod.outlook.com (2603:10b6:806:1b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 15:25:41 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 15:25:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e166a69-3daf-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664205947; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=bmFuzDKtt4P5elToqE7wMR0a1iWWoYrpzRp6TdpvKsY=; b=PAat7X1yC+kD06ssqXsaj9esUA9qlqtSIrtoKBrYgtWFAZLrGDmclgo6 1d13tx55zJQaKUg9824OnkyHxzxr1JJ2qbcgvI8WPhSNtBFtFR8pOFE5l cpFOXZHOwfwG2nuyMrpes9yfCkbccK2Iw+hclfENKvk9x8tehFG/m2cLl A=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 81019734 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nSdkZKCrVn6i0BVW/xPiw5YqxClBgxIJ4kV8jS/XYbTApGt23j0Ez 2sfDDvUM6mCMTT9KIx/aY+2p0IP7ZfczYM1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFsfzb8XuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW3jLz/hJVGo8BoE/xvpxEXwJ/ /wZKC9YO3hvh8ruqF66Ys9Fo516aeLMZcYYsHwmyizFB/E7R5yFW7/N+dJTwDY3gIZJAOraY M0aLzFoaXwsYTUWYgtRVM14wbnu3yeuG9FbgAv9Sa4f+W/cwRY3yLHwGNHUZsaLVYNemUPwS mfurz2hW0BFb4D3JTytyjWsi7+Iu3nCSYMyF+fj2fxYuGLL/zlGYPERfR7hyRWjsWa8Ud9CL 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJ4EfA+6QyL4rrZ5UCeHGdsZiVadNUsucsyRDor/ lyEhdXkAXpoqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWdi9T0HXT7x GmMpS1n3rEL15dVhuO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComVvlhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:+RBnhahFA6rvNnX3fX7EIchhUXBQX0F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nGPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SuV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A7eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1whq7VBaM0pd gsCZ4Y5I2mfvVmE56VO91xMPdfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q 6xG29liQ== X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="81019734" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzXd7B4i7ZXcF75aUjOwAUj2faB5t3m4ccbAp/DFrj15UjHc5Uw2k8j56n+2nJbOy3kGgVbdBY7QEeJwtNZYoVE9JC3B6LdsemHV3mDCkRLAAVFUttxA9NZa4GoSg5II8lv02of3fNLelqb9a8jqiPoxpiFJ/2mntM6b/y1TnJNC6FkIZr6COIP3bB1Hnrb4DzuxVu/QMTIoa0T/F7fOLVnSM4nAw9wO5jTsIibODRE7+c2xmAr4biV+ShWeEl5XUQ3am6k2j1WE0OYuCP3sV0grNny2JnQEByEHUZnASxnWvIDwSjQDpCwhkSWBmqirrlEk/PS3IYxnTJBW3gt7PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ARH08HiEFmVD7NCXgJKkWl4jAjE/EKEh6gR9WFHS78M=; b=faPA+rpfawczj+UlgNHPFr5nG6Qxar670s76HyoDDUR9I/1BoQrpnAAUNjtvL4qlQFUGXAtaEKxyGV1fAcuLs22A1p4hQ02XTDwvsBETO4QK98+KaebVR71O94d8VXwWg26un16IOMAxgdDPOxFbdFZguJ+zE0VkBsCKIUoBRaLu2rZzVJptSQUr//5q8Xlnz/7O7w5AmgouDKEb8QvoehxaVO4dyQQQ9rjeCx0BgU+KeTZ/W4fF+/2jjM2FrVhyxLzCCSkrX942u2tZ9UzwFANDfnwvTQXZxPiA/tfhQz50Hy78rzpGYoJmbZ1ZyX16wyY71kT5bgYJTeqdpcAClw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ARH08HiEFmVD7NCXgJKkWl4jAjE/EKEh6gR9WFHS78M=; b=jlizKvnsZmXouXY1gMBQccSokoT/UolWrM4p2yXv4Radhx4oedp/W6a3mMldqZe/eOHZKJnh6zyXVrdrB6bkXNTCP1En0MjhZqVr+fCsIpNe25qp4AoNLe/LXFSPFYGKq9nFxUYOyHaNzPy6v2MZF3My9Pk/V8HpB/WbdY7OYFo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 26 Sep 2022 17:25:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220922160516.5929-1-roger.pau@citrix.com> <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BN9PR03CA0769.namprd03.prod.outlook.com (2603:10b6:408:13a::24) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6356:EE_ X-MS-Office365-Filtering-Correlation-Id: 2002deaf-7ca3-406c-12fa-08da9fd35ed9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IZcvBaluyoTsedCxLMIs5KJnP0Zh4Ug9oeO0Z9LTJdL3r34KfT3GGL2Z+7YBGyGaV6odHxHb98Qjn8hJahKnf0iRWiSWSSgxbhG5B/NbECpgAV17wnODttE+6GWpuuuLEeJcVxtQcU+KHpwDuvLRfOnJJhJxNTEMnpRE38zYXOQiYj+SWBIygn0yP4CGFPZ6SZOwQLDFwb7pBc/AoaLLVUpNBBrZn6A3GPENUxVCXau+JMui8IKv6Z7eF66MvooIB5CrOshgJDeebgiKPirFk7PSTZQbIsY9synOUepUkUu1OhnIU9Eurjl8aS4o0us949kZv1/zEiXpaU8RlNnysIO/uK8egZ8IZoq/5W3sHK4nV3bFh0t6cEBtgIDpPsJn27KyVLZkfzCG+kGB0P+qxvl5cVQJ+n7PxonsgiXJ5WREhmeEvEopazuke7A4uZhSqFoUtJhGebf7oKn8JPkjxoWKqsRuMWQqv306svFDoX69te8lWXO6QqijQx3MTeWmjMCA+iVEw+D35bcp042jWG9tZVvTfawd/O+f6sHIfWQ6Di4eJKz5jbaJd6EOVEDsDLyH3De0o0QQ5Hg6RDa/MiQ1WOqM9OW7Rj4VjpdDJ0B9YPAsE57NZA7DMXpDRXpMM0hRNFHQxBfN473YwcDJPg7i+Y0T4dqcPnNyf2SqEVqeWO2q0Cv1cqTBxG5xf5k7vSFy9E0I2YWc/Uq97sjqnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199015)(6512007)(9686003)(53546011)(85182001)(5660300002)(26005)(2906002)(6862004)(66556008)(66946007)(66476007)(4326008)(8676002)(6506007)(8936002)(41300700001)(6666004)(38100700002)(86362001)(6200100001)(186003)(82960400001)(54906003)(83380400001)(316002)(478600001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REIxU3lyMXNldmhVbHFnSXZnbWtxMks3Vkg3V0hnRFNWY1FCck1zeHd0aUJO?= =?utf-8?B?dUQ5QUtBWiszMEUwTTdFT2NNZ3VqbFdJam5RNlVIRXdoWUZqR252eDlTeENS?= =?utf-8?B?MThldXVvNDlLL2RNUmhJRE0xQU84d3MxQVNoOGlRMjRCeGlzanhyYUI5Unll?= =?utf-8?B?WmNOVjZaSGZkMlBITXM2OU5ndGlSYysrZWFFeFJIZDB4YW1WYzRVb0psU3Zq?= =?utf-8?B?U09HL3R2MFFyWFBOZ1ZTUVdmRlNBd1NoblMyT3NMbXhYNFJUbVB0d1d4dFRz?= =?utf-8?B?aFA1NENZSUE0cmtBZjNFeVljRzBObmZUM3N0bVpMOU5wWGxIQTNxNFNUaC9a?= =?utf-8?B?L2Zra29lUXFMTURYaGtSWGI1ZE02cGpNU0NVQ05UOHpHNXBXS3BXTDlMWVpD?= =?utf-8?B?MDFEWW9ScHdRRExISTBubldHL2JiWnVjRXA1eU1DQzE0bFlwa2hvdjBIbDZP?= =?utf-8?B?bHlOSVpTcEZGaUc5WWNPWHRKd3lqVFBwWmpyZjIyREZ6V1U0V2cxWDNJakFa?= =?utf-8?B?aFl5cFlkc0ZmUWVyRDhJcUtyL3lQVVFUSzRwUTEzK1pCME84eDBnMUtJMmRP?= =?utf-8?B?VklOL003ekNSdW9Ba3VaWXJ4RFNBN0tpc0dBcWM4bkZyTHBXQkp1ell5Uk9G?= =?utf-8?B?TTllQW8rRjQxMTQzbzdKYStyREFSN0kyNldSWU5Ecm1BclltZ2gxTk9BQjZF?= =?utf-8?B?ek42Tkcza2dyRG13eHNKTmczSHgzbkVHczhHMjNXdlc1Y3A5L0dFRFJ5dERK?= =?utf-8?B?VG9BaHA0WThvYjVoRkN2SEFDRmcwUVFyWUxSN1YzNWpFa2xRcDgvTnRTRCtQ?= =?utf-8?B?UktxWXd5R21TTjFGWm0xMUQzYkxpWmZOSDUveml6Zi9yVGFyaFAzMjM5TlIz?= =?utf-8?B?Q1g4eUhwZVM2TUNTbjFFdmFWMkE3VDJRNnovbzFGenpJUUxYa3BxZEJOeHFY?= =?utf-8?B?TFdYcnNQbXBxWGN6b2FRbTAzLzB4dTRrT3hJZWNPLzJNU1RjWU1vYzFTeVAw?= =?utf-8?B?WmtNdndZUEdBS3lWTnVjcnI4dkxnMTZKVDRkaGd4bVBXV0luSUNBZEtsanYx?= =?utf-8?B?NGRsQnFVWThhMkNEZGxhd3F4amFsOUlwTXJrV3RVcloyMzFXTFkzUlRJaVRn?= =?utf-8?B?bEljdEhJQzNRQ2lUZFZUUHYwQjE4K3BtNkdNSFpNOTlvUFhmSXcxNklTaStQ?= =?utf-8?B?REo3K2hia1MvTzNSd1E3eWxTUEtqNkNtdUlPSWl1d3lsRzV5Q0JLNGFTTGZL?= =?utf-8?B?MXhGeHVzQllQOGxEenhhMWZZbWxncUduTkQweGpQeDlmTHNXcGVqaktYR2ds?= =?utf-8?B?ZlE5U0UxL0lkRUVWRHhQSkJjcUFMdHpJZi93TVpoUytRb2tsTVUzRzFzR2FU?= =?utf-8?B?WExySFRPTnV3V29DcHFMc1JMZGpPc0xxY3BCUDl1RVRmQk9ya3Q2dmE4akZV?= =?utf-8?B?Zis2V1dCS3R6aFRZdVNNUDNkV2t1akhOSEFhWlJuQmE2eXRkZGRFT2NQaFpa?= =?utf-8?B?UW5FUThsY0JJR2lMZEY3MCt2U2hGbnQ4S0RSYTl5MzJFa3lQbS9tUVF4b1FL?= =?utf-8?B?MHpudmNCb1ljYldYa09ZWjhySmRLR3BEOHNUeTRjRmJIcUNlTmQ1cGh1MGww?= =?utf-8?B?QW4vR01JM1l2bTlodlVZdXYvU1FlRkZsQldVemJaU0hXbUpPN0UzRGNvOHJX?= =?utf-8?B?VXRadG85VmhmQVdBWnp1dlRyUWdQZkkrYVFYaDBwNE5kUmVEOGxBcG5aN2RM?= =?utf-8?B?Mi9QUU04WmpkUzVpcHVSMHBocmtMQ0VCWUUrbGhoaVZ6dTBmTUc5RlBORlY5?= =?utf-8?B?UEZxN3dMU0hQWHE3dTYrK1dZS2FLN0xWZ3VhYzIrRG5lU1dkVmxCTnVLUWov?= =?utf-8?B?d3ZwSldNQlo0M1pjM0l4cUlvN0NhYzFJRFRsME1KYnBvVVBBa3drM2ZRKzM1?= =?utf-8?B?TEd5VTNRRytyRlU4TlhsUmJrNU9GYUFFa3dCUjJoSVNtWHEvWlVxQ3FEWEoz?= =?utf-8?B?WUpaSHFwMldzRHBaMTNrckFQRmZNQjBJQmFESmJXUzRIRHA4cW5pbEN1eERR?= =?utf-8?B?UGlzdmdCNkF5NTFrazZFa3RLeFVTTmY3OE8wT1U2N0VJenRxRHdTRUMxNy9t?= =?utf-8?B?dFZXOThEVzlSK241RE9VcmlHQ25USlN6Sm5SWkJMZllaSHRhbWlHeE1IREdD?= =?utf-8?B?bFE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2002deaf-7ca3-406c-12fa-08da9fd35ed9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:25:40.8296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RR56+XcGB37INdy6v9Z1/Ubseq8rQiJbpEY9hl7GAMErBCu2tehKYdyCqZQGdjQ7jmbsX/cKBd4zTqG2S4lxGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6356 On Mon, Sep 26, 2022 at 04:50:22PM +0200, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: > > On 23.09.2022 10:35, Roger Pau Monné wrote: > > > On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > > >> On 22.09.2022 18:05, Roger Pau Monne wrote: > > >>> memory_type_changed() is currently only implemented for Intel EPT, and > > >>> results in the invalidation of EMT attributes on all the entries in > > >>> the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > > >>> when the guest tries to access any gfns for the first time, which > > >>> results in the recalculation of the EMT for the accessed page. The > > >>> vmexit and the recalculations are expensive, and as such should be > > >>> avoided when possible. > > >>> > > >>> Remove the call to memory_type_changed() from > > >>> XEN_DOMCTL_memory_mapping: there are no modifications of the > > >>> iomem_caps ranges anymore that could alter the return of > > >>> cache_flush_permitted() from that domctl. > > >> > > >> I certainly agree - this was an oversight when the two aspects were > > >> split. One might argue this is a (performance) fix to the earlier > > >> commit, and hence might want to go on its own with a Fixes: tag. > > > > > > Was wondering myself, didn't add the 'Fixes:' tag because of the extra > > > content. > > > > > >>> Calls to memory_type_changed() resulting from changes to the domain > > >>> iomem_caps or ioport_caps ranges are only relevant for EMT > > >>> calculations if the IOMMU is not enabled, and the call has resulted in > > >>> a change to the return value of cache_flush_permitted(). > > >> > > >> I'm less certain here: These shouldn't be frequent operations, so > > >> their impact on the guest should be limited? > > > > > > Citrix has an use case for vGPU where IOMMU regions are added and > > > removed during guest runtime. Such functionality makes uses of both > > > XEN_DOMCTL_iomem_permission and XEN_DOMCTL_memory_mapping. > > > > I see. Maybe this would want saying in the description, to express > > that there's little expected benefit for upstream. > > I guess any OS that moves BARs around will also trigger such code > paths, but that might not be very common. I can add something to the > description. > > > > While the memory_type_changed() call in XEN_DOMCTL_memory_mapping > > > seems to be the most problematic performance wise, I though it was > > > nice to try to avoid memory_type_changed() as much as possible, as > > > those tax the guest quite heavily with EPT_MISCONFIG faults and the > > > recalculation logic. > > > > Trying to avoid this is certainly desirable, I agree. But we need > > to make sure that it's not "easy" to break things by touching one > > place but leaving others alone which really would need keeping in > > sync. Therefore I'd see such added logic as acceptable only if the > > risk towards future changes is sufficiently low. > > > > >> And if we were to restrict the calls, I think we need to clearly > > >> tie together the various places which need updating together in > > >> case e.g. the condition in epte_get_entry_emt() is changed. > > >> Minimally by way of comments, but maybe by way of a small helper > > >> function (for which I can't seem to be able to think of a good > > >> name) sitting next to epte_get_entry_emt(). > > > > > > Such helper function is also kind of problematic, as it would have to > > > live in p2m-ept.c but be used in domctl.c and x86/domctl.c? It would > > > have to go through the p2m_domain indirection structure. > > > > It would need abstraction at the arch level as well as for !HVM configs > > on x86. I'm not sure the indirection layer would actually be needed, as > > the contents of the function - despite wanting placing in p2m-ept.c - > > isn't really vendor dependent. (If AMD/SVM gained a need for a similar > > helper, things would nee re-evaluating.) > > Maybe it would be better to add the calls to memory_type_changed() > directly in iomem_{permit,deny}_access() and > ioports_{permit,deny}_access itself? > > That would also allow to remove the noop Arm memory_type_changed() > halper. Correction: the Arm memory_type_changed() needs to stay, as iomem_{permit,deny}_access() is common code. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:29:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:29:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411962.655106 (Exim 4.92) (envelope-from ) id 1ocq39-0003ov-7a; Mon, 26 Sep 2022 15:29:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411962.655106; Mon, 26 Sep 2022 15:29:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocq39-0003oo-4h; Mon, 26 Sep 2022 15:29:39 +0000 Received: by outflank-mailman (input) for mailman id 411962; Mon, 26 Sep 2022 15:29:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocq37-0003oi-VY for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:29:37 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 073445ab-3db0-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 17:29:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8743.eurprd04.prod.outlook.com (2603:10a6:10:2e1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 15:29:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 15:29:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 073445ab-3db0-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jx40fp2TjTvmwnsQfkkBSJnHWYCX2fA/LVM2UvbKY+HNwbuMF3zQTv5bjpo0iSO0rUJcdce5Okw6CsDwCWAERPcGqk1ZB2M/NeLyTnc8Y/C1fKN4m9F7a1WUQHhHuuVw3oa/6a/3Yjc9/6JDn7uAM7jjbXHubP9UcbTj8Tjs4kBhjeayOqB2U2FcPKYlWKlG8dUYGWT7LtghLRg6GsUMkz2ELHFeEs7JiFyr2mSbN9J561yBol0qXRM910e5QXK2Kh3tFw2fv0b9j49afMK/DMf1xBRAOaL0dh1RCqEovU1d+8teJUuk8LgybuO5zT3AErFfQKiXtSIMqANZgrhJsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9HY0O8rOWHJgE2ypf8yinz4Uk0wsWLwEPUUlPrIlZH4=; b=COUzUNS4rLD1+8MSy5iC3R7tSAR2VDbrAWJWEHlVxM60uHyz7gR7IFXRLhilphVIlpvb2xl7SgFWoZuyVbJa2pEEiTT129xp54jy+7H4xYkxyNt0UR6GufFfgy8HFrE9/6IRAPGehIl7AZmibKlkK2W/wR9+foRVREXUXGcn/DvowT+2EXm/iarxubGB/ebW7QOLVbGdTcpquXtBsgTBLfzBb/1V2rlhCRjjk4wIHCWoNBSVDIammcveSG+ValpGCyKOmUbCMynyQ7YRiCx5FWlDwbhE5Ulj5xDa1MO4crog8jyJ56kPCxAqbowEweoCHcyyeKJnsZpZzNvHr+RZtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9HY0O8rOWHJgE2ypf8yinz4Uk0wsWLwEPUUlPrIlZH4=; b=PSEwpFpQqRboTWF0Ecyb46HJjW8eFdK8fIJnKn7ZzbZOcSARHIKSctu2ezQypMGJkgKlunFmg1AG6iGEQoWkxZ5AubymfZqOoINu/jXb9CvqBlIA9CuS1gyu1SvqnjlEK6aMGHqYnN8rDtP83jRiY6865RaqMrqj+Nn6L5iNXLX4WwXIqrq0Y28F5wbyyT/zd08yJa8GvsRNvUPe8LFym/MF4cQx5x6Xji4U1JkeiIHRNVXAZ0tduxvoXmAs+zfa7x9c/tcNKV7uRxg7dlvYjQ0oBoSmuE7VyfMMOw2mn+6UoetuIEqPyLtKzCg6d3ZdAwGNpQjEu/VibJG/N+WCJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 17:29:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP Content-Language: en-US To: Juergen Gross Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-2-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220926141849.21805-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8743:EE_ X-MS-Office365-Filtering-Correlation-Id: 24786e85-a242-426a-b506-08da9fd3e9f2 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wlLCAs5VVeYDuqeFud2ptCIAlpaZ4gFPwqtDZgXW9WP4VmnXsXUmkfDNChmh30/D94I82jjnxAQIG+wU4hRRHuqWRqPliMh4a+kTy8RkAh81sS7WAy0j7lOfQtqzksYDrylSHN/5cJYAcPHxIj6X7b3GeCChtkwn5sGcAS3p8/Zg3PnMyKYisO3H2msy+CupuWHWE64ZIf08G1DWdh+clvgKKaUbYg80iXg/+wNSALMzfPY6tX5w5TI73IWIo5FxzP6tchhSxZ70pSPeE1ztyi9ATLnFi4Mlfrn3MxzmQwVMHrM8wbu8u3fXXXOjrDT2bMcbfGO9zbbvSO3USFcM1xG6gnv4ZPtojCAEzBJZGLtEV65xwwDLQke4SqQxwpwuwLx1tpIPtLqhnw0Eqew60apEK3R/5g6ADVLKDsm6CqipeVOE5bOObnCpiqPXZZYXRCELxVEorkxgf0aZB+qNsN1oQUdRHXtnNz4R6f72xmOIEAaBZB0IjHg8m1tOKw4Jdw7ZYqtLlLXVA0yx7FeT/5oMV4NFEobDxFE4VoCyImTfYILybyQxW+FPc4lwz/iwshge/jsiSUrcsCq45B/wR7vSICbt3B3lEsEPCMNkN8/l3SBNL+c7aHDAyRSstMBSyrKgTBUv8gIvsIkMjTcssZL+ho/mKYZMNTTOe0Kb+lb+w0p5o82ZscCikjOsgc3U0d2/oL7nBityfkBHOEpVNj1wko7RAf8wImFitc1WksbTE31UtOBdKerzNxhQZj13Hq1mWI5jBokIN0rjjvJnNzN8DEu0GqFaYgyzhOrcpRA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199015)(6636002)(37006003)(54906003)(4326008)(6486002)(66946007)(66476007)(66556008)(478600001)(8676002)(316002)(5660300002)(31686004)(41300700001)(8936002)(6862004)(53546011)(6512007)(26005)(6506007)(2616005)(83380400001)(38100700002)(2906002)(186003)(31696002)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RStFcGJFaHNrbUNOSEJteklEMGZoVkkvY3BiaVlxdnY5eDBFdmhZd0ppU2Rr?= =?utf-8?B?a3RsZkt6OGUxMTBIMitqNG8xTWJDU1BJdzZNVnVHbFFsUVlHNTYvcEJpWEZi?= =?utf-8?B?YkUwMFRBQlFPdVdYdDFkK2JCTnFxdjVjZVA5aEZENmowWUZDUklZRDIybGNw?= =?utf-8?B?eitSRHYwUzJaZUhGVDFLK3hNZldRbVVPMmo0NmJ1ZXg4ZnhHdmdpVzhpb0E4?= =?utf-8?B?VGhucC9aYzlNNHZiYXZ1bzgxZUM2SzlKVis1WXVJaklZOW9lU010ZVFESVRo?= =?utf-8?B?bjNvWExod3JpUExGWm5zNTBxQVNySFVNS2NSUWIrY0VlR3NZWHVaV2dqVGsx?= =?utf-8?B?K1VDQlZyKzZ6WHBiNDlYT2Q5RDRKU1FBY1QzZCtYeDhpYitTN1VDMlhweHJK?= =?utf-8?B?Uk4rS2d0eldLeXh3c3Y5alVoRm9aSDRMSjBxQWRKNHJvSXhUVWZSbUowdm9R?= =?utf-8?B?dEFiTy8xVU5kNk5xb3BNZ2dQUlRpa1JqMmlIaUxBMTAyZ2V1MTY3dzhWNzdJ?= =?utf-8?B?WkZXeGl3V3RxYlNFZEQ1WEE0cUJ6SWQ3Um96RWI1STl1Vjd2NWxZNWtkbFF3?= =?utf-8?B?dnQrNWJ2bFB3ejVhOEwvcUVnL2lQVGxMcUh1NGloZzhzblRtQmYwU2NiMTNq?= =?utf-8?B?aHh4WnVHc2grNWtGZElZcDVaWmxtdVc4OWVPNktISWVEU0thTlErNktvRFQw?= =?utf-8?B?SHpwNy84ZmZldTY0WWc1bnl6Tzc4d2pLV0FtcG1YRVExb0hXUXNwc1RiSWFk?= =?utf-8?B?dHcwYm5OVklDZ2F1TmVvdk5tL0dUZFJUZTZYNm8wQk4vcEtuck9ZUnBwektz?= =?utf-8?B?eDI4eHMyUFB0bWpXWEhBa2d3bkZnSjJvR081bUkrdU1tekNHZ1pNTENZdG9z?= =?utf-8?B?eFR1ZE8vU25qZ0JsTGsvREtYMmcxaFA3QzRvaFhRdUdhdEc5eFN5Nm5nWGZa?= =?utf-8?B?RUUrUHRoWThnTktOVzhnMVpXejNnN0p0cFNaWnRmL3R0cVh3ZWZ2RHBRMmRT?= =?utf-8?B?QUdPN0ZQR240dFRhNldscUNGejhNYy9qSjhDd1EyWnJEbkRiK2t5M1N2eXRC?= =?utf-8?B?dFg0Mm1DNXQyUlV6TFQ1eUVWa1g2WExESml2c2NCYUhtblJTSEwrdUU3OGN6?= =?utf-8?B?VGRJQVZ2Ym94S1pFYVdFczR2c29nZkpWcm1hd2hzM2NLeGNBdGJ5WUl5djIx?= =?utf-8?B?cENqZnhYRHNCNEo1VkJoZFg4NXhqcXA2Qi9ydEN4RjhES3RnR2ZsVWsyQ2tr?= =?utf-8?B?Nm42L21xSXNVa2RCZ0xhSUN0WHNZWEVReHVHOFB3SmNwanMyMFMzQ3FNcGRl?= =?utf-8?B?QkpITUJtdEhSblBGY05EWkxqSXJGMjdSQ1hOeCthM2lJU2d2QUNFUHNiQm9z?= =?utf-8?B?dW45ZGdIY3FNZzh6RTNTQmVIMytkVVhMNVhGL2c4QlIrM2lEbGw2bTNWQ1Vu?= =?utf-8?B?RFFNTW9nQ3BsZGp3d2tNNXRoaDFhSDNWRDBLU1RnZnRsWG9jdERVcGU4Z2dG?= =?utf-8?B?dkYycGVjbS9xQXFheHZkNHpDMC95OWtzSjRrSzRRRHRHU0xiU0tydGJrYk1R?= =?utf-8?B?ZjB3em52dFdTZmpiU0tQUGg1MDdmWi9WTHR0VDFyWEZEQ1hwdkh6OGtuZ0ti?= =?utf-8?B?K1JNaWcvbVl2cFVQMncrcGUvVkxlc0JPQk9LSmRvQW0ycG5VV2J1MGwrbm1V?= =?utf-8?B?VitjQXBscmZWNE96QkFKYnJnbmh4aUE0cVd4VHdwd3lXckphaHZ5cHZqcDNK?= =?utf-8?B?MXRXWEI0OHJ0cmtUeEtzUFk4VENSYkNmNDJrYTluRlQ0ODFoVWt6WjJyVzZl?= =?utf-8?B?WTRPK3FuYVpBOHdJSW5uR2FFaFNmaTlJMCtRNW1zeGxXQkRPbGVTUElpaXlo?= =?utf-8?B?WjFLNkxOVFo3azEyb1FSUmhlQnZPQm1SS1VWU1hMZWNEZVZUb0U3ZFd1Q1Js?= =?utf-8?B?TGpZNmcrMk5rcHhpYlVQLzZyVFJGR29Qa2g2K2NzQ0JyK1J2WEVEV0pNVy9W?= =?utf-8?B?VlZ1ZUFMMjdqdkQ5eFVyeDNzRVlMbE9RdjdYUndnUm0xMm04bGM5aTFoSmYy?= =?utf-8?B?L0xoYUpYS3FlYTZsZER0ZTU1TmNnNHZWZnBBUzI5ZTBjcWlITmJ6dlF3WElt?= =?utf-8?Q?rHoHkPQEhdXF+XS5gNnrCBBYV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24786e85-a242-426a-b506-08da9fd3e9f2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:29:33.9353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HW/+la+40AhrjEQnNfIrNfZGQDx8hVu9xqt4l7TWgaNvKeBoaLVbLjbtkwHjgZ7szNmG3b1kQAH7zFLaGyaQtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8743 On 26.09.2022 16:18, Juergen Gross wrote: > Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants > of read/write MSR in case the MSR access isn't emulated via Xen. Allow > the caller to select the potentially faulting variant by passing NULL > for the error pointer. Maybe make this "the sole caller" or some such? Because if there were multiple, they might easily disagree on what the best meaning of passing NULL is. > --- a/arch/x86/xen/pmu.c > +++ b/arch/x86/xen/pmu.c > @@ -293,22 +293,24 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read) > bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err) > { > if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) { > - if (is_amd_pmu_msr(msr)) { > - if (!xen_amd_pmu_emulate(msr, val, 1)) > - *val = native_read_msr_safe(msr, err); > - return true; > + if (!is_amd_pmu_msr(msr)) > + return false; > + if (!xen_amd_pmu_emulate(msr, val, 1)) { > + *val = err ? native_read_msr_safe(msr, err) > + : native_read_msr(msr); > } > + return true; Minor remark: Fold this and ... > } else { > int type, index; > > - if (is_intel_pmu_msr(msr, &type, &index)) { > - if (!xen_intel_pmu_emulate(msr, val, type, index, 1)) > - *val = native_read_msr_safe(msr, err); > - return true; > + if (!is_intel_pmu_msr(msr, &type, &index)) > + return false; > + if (!xen_intel_pmu_emulate(msr, val, type, index, 1)) { > + *val = err ? native_read_msr_safe(msr, err) > + : native_read_msr(msr); > } > + return true; ... this by moving them ... > } > - > - return false; > } ... above here? You might even de-duplicate the native_read_msr{,_safe}() invocations by moving them out of the if/else ... Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:33:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:33:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411970.655116 (Exim 4.92) (envelope-from ) id 1ocq6f-0005DM-MV; Mon, 26 Sep 2022 15:33:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411970.655116; Mon, 26 Sep 2022 15:33:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocq6f-0005DF-Jn; Mon, 26 Sep 2022 15:33:17 +0000 Received: by outflank-mailman (input) for mailman id 411970; Mon, 26 Sep 2022 15:33:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocq6d-0005D9-OY for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:33:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8938fe3d-3db0-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 17:33:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35F2021EC9; Mon, 26 Sep 2022 15:33:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DC6E2139BD; Mon, 26 Sep 2022 15:33:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K0lCNDnGMWMIJwAAMHmgww (envelope-from ); Mon, 26 Sep 2022 15:33:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8938fe3d-3db0-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664206394; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9WS2sEins4xVwRVYY8gCnqmOJ+eRJm5JiCaS2wCiNCk=; b=mDSOIoguJRZ7ksZ0ix5HY3FAHSQ3O4e0IqF5KPoXa3usKT1ch9TMQoPIB6LINwZue+325l S4LJkx4IPxyPEYm7DKPOPf8z5nvkdaYx6outmiEuG202yHmsW3QpqhUXpdIfN8CUdB8aRD NZ8mmlPKmam1wCYazOQOGQaqp49BsEI= Message-ID: <3f69b45d-d8c3-1e23-7fc9-87ffb436ad29@suse.com> Date: Mon, 26 Sep 2022 17:33:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP Content-Language: en-US To: Jan Beulich Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-2-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PJ4Udd0XK2Rtt0I3S2SvuWIB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PJ4Udd0XK2Rtt0I3S2SvuWIB Content-Type: multipart/mixed; boundary="------------r3nF5HDYlE0AGuY25mLAcUj2"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Message-ID: <3f69b45d-d8c3-1e23-7fc9-87ffb436ad29@suse.com> Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-2-jgross@suse.com> In-Reply-To: --------------r3nF5HDYlE0AGuY25mLAcUj2 Content-Type: multipart/mixed; boundary="------------AHBNTk7j2H0z0YTVyqy04fL6" --------------AHBNTk7j2H0z0YTVyqy04fL6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMTc6MjksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNi4wOS4yMDIy IDE2OjE4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgcG11X21zcl9yZWFkKCkg YW5kIHBtdV9tc3Jfd3JpdGUoKSBmYWxsIGJhY2sgdG8gdGhlIHNhZmUgdmFyaWFudHMNCj4+ IG9mIHJlYWQvd3JpdGUgTVNSIGluIGNhc2UgdGhlIE1TUiBhY2Nlc3MgaXNuJ3QgZW11bGF0 ZWQgdmlhIFhlbi4gQWxsb3cNCj4+IHRoZSBjYWxsZXIgdG8gc2VsZWN0IHRoZSBwb3RlbnRp YWxseSBmYXVsdGluZyB2YXJpYW50IGJ5IHBhc3NpbmcgTlVMTA0KPj4gZm9yIHRoZSBlcnJv ciBwb2ludGVyLg0KPiANCj4gTWF5YmUgbWFrZSB0aGlzICJ0aGUgc29sZSBjYWxsZXIiIG9y IHNvbWUgc3VjaD8gQmVjYXVzZSBpZiB0aGVyZSB3ZXJlDQo+IG11bHRpcGxlLCB0aGV5IG1p Z2h0IGVhc2lseSBkaXNhZ3JlZSBvbiB3aGF0IHRoZSBiZXN0IG1lYW5pbmcgb2YgcGFzc2lu Zw0KPiBOVUxMIGlzLg0KDQpPa2F5Lg0KDQo+IA0KPj4gLS0tIGEvYXJjaC94ODYveGVuL3Bt dS5jDQo+PiArKysgYi9hcmNoL3g4Ni94ZW4vcG11LmMNCj4+IEBAIC0yOTMsMjIgKzI5Mywy NCBAQCBzdGF0aWMgYm9vbCB4ZW5fYW1kX3BtdV9lbXVsYXRlKHVuc2lnbmVkIGludCBtc3Is IHU2NCAqdmFsLCBib29sIGlzX3JlYWQpDQo+PiAgIGJvb2wgcG11X21zcl9yZWFkKHVuc2ln bmVkIGludCBtc3IsIHVpbnQ2NF90ICp2YWwsIGludCAqZXJyKQ0KPj4gICB7DQo+PiAgIAlp ZiAoYm9vdF9jcHVfZGF0YS54ODZfdmVuZG9yICE9IFg4Nl9WRU5ET1JfSU5URUwpIHsNCj4+ IC0JCWlmIChpc19hbWRfcG11X21zcihtc3IpKSB7DQo+PiAtCQkJaWYgKCF4ZW5fYW1kX3Bt dV9lbXVsYXRlKG1zciwgdmFsLCAxKSkNCj4+IC0JCQkJKnZhbCA9IG5hdGl2ZV9yZWFkX21z cl9zYWZlKG1zciwgZXJyKTsNCj4+IC0JCQlyZXR1cm4gdHJ1ZTsNCj4+ICsJCWlmICghaXNf YW1kX3BtdV9tc3IobXNyKSkNCj4+ICsJCQlyZXR1cm4gZmFsc2U7DQo+PiArCQlpZiAoIXhl bl9hbWRfcG11X2VtdWxhdGUobXNyLCB2YWwsIDEpKSB7DQo+PiArCQkJKnZhbCA9IGVyciA/ IG5hdGl2ZV9yZWFkX21zcl9zYWZlKG1zciwgZXJyKQ0KPj4gKwkJCQkgICA6IG5hdGl2ZV9y ZWFkX21zcihtc3IpOw0KPj4gICAJCX0NCj4+ICsJCXJldHVybiB0cnVlOw0KPiANCj4gTWlu b3IgcmVtYXJrOiBGb2xkIHRoaXMgYW5kIC4uLg0KPiANCj4+ICAgCX0gZWxzZSB7DQo+PiAg IAkJaW50IHR5cGUsIGluZGV4Ow0KPj4gICANCj4+IC0JCWlmIChpc19pbnRlbF9wbXVfbXNy KG1zciwgJnR5cGUsICZpbmRleCkpIHsNCj4+IC0JCQlpZiAoIXhlbl9pbnRlbF9wbXVfZW11 bGF0ZShtc3IsIHZhbCwgdHlwZSwgaW5kZXgsIDEpKQ0KPj4gLQkJCQkqdmFsID0gbmF0aXZl X3JlYWRfbXNyX3NhZmUobXNyLCBlcnIpOw0KPj4gLQkJCXJldHVybiB0cnVlOw0KPj4gKwkJ aWYgKCFpc19pbnRlbF9wbXVfbXNyKG1zciwgJnR5cGUsICZpbmRleCkpDQo+PiArCQkJcmV0 dXJuIGZhbHNlOw0KPj4gKwkJaWYgKCF4ZW5faW50ZWxfcG11X2VtdWxhdGUobXNyLCB2YWws IHR5cGUsIGluZGV4LCAxKSkgew0KPj4gKwkJCSp2YWwgPSBlcnIgPyBuYXRpdmVfcmVhZF9t c3Jfc2FmZShtc3IsIGVycikNCj4+ICsJCQkJICAgOiBuYXRpdmVfcmVhZF9tc3IobXNyKTsN Cj4+ICAgCQl9DQo+PiArCQlyZXR1cm4gdHJ1ZTsNCj4gDQo+IC4uLiB0aGlzIGJ5IG1vdmlu ZyB0aGVtIC4uLg0KPiANCj4+ICAgCX0NCj4+IC0NCj4+IC0JcmV0dXJuIGZhbHNlOw0KPj4g ICB9DQo+IA0KPiAuLi4gYWJvdmUgaGVyZT8gWW91IG1pZ2h0IGV2ZW4gZGUtZHVwbGljYXRl IHRoZSBuYXRpdmVfcmVhZF9tc3J7LF9zYWZlfSgpDQo+IGludm9jYXRpb25zIGJ5IG1vdmlu ZyB0aGVtIG91dCBvZiB0aGUgaWYvZWxzZSAuLi4NCg0KT2gsIG5pY2UgaWRlYSENCg0KDQpK dWVyZ2VuDQoNCg== --------------AHBNTk7j2H0z0YTVyqy04fL6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AHBNTk7j2H0z0YTVyqy04fL6-- --------------r3nF5HDYlE0AGuY25mLAcUj2-- --------------PJ4Udd0XK2Rtt0I3S2SvuWIB Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMxxjkFAwAAAAAACgkQsN6d1ii/Ey+M 2Af+JVi2ilT/dU3IByPm+d8h6sSVZBiyiEc4zAaGKpDrcIG/o1LTGfd59vWAzw4lev/CnCdB7yu6 CSZK2r20WK8Nu4+f9s/Ka5CfnJEkyXJ4ffSOpU2+f04SSuLDNqq/5EMNV+9Hnd5NhiilJtBR+Xf+ HGecH3vNKBLS3HACAuw/9W8AOG8ihlzYL3biRqB9e5k9etZA+jjr3QjG7qVFtqAIWbDVAvebUDny xU/jS3+zqZ4Oqzjwx5Vu+eVCCn/IXo5YaPWyoln1smH/+Wod90g4+BTqZ+MY2u2DBb9RSMjyEXgZ 6qqYA88SXFCkHdY7OEMIUhiTUxZZ65RlVgqObZeu5g== =17Wf -----END PGP SIGNATURE----- --------------PJ4Udd0XK2Rtt0I3S2SvuWIB-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:36:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411982.655128 (Exim 4.92) (envelope-from ) id 1ocq9Q-0005v0-4z; Mon, 26 Sep 2022 15:36:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411982.655128; Mon, 26 Sep 2022 15:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocq9Q-0005ut-1m; Mon, 26 Sep 2022 15:36:08 +0000 Received: by outflank-mailman (input) for mailman id 411982; Mon, 26 Sep 2022 15:36:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocq9O-0005ug-FJ for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:36:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eef1d36d-3db0-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:36:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B785721EF3; Mon, 26 Sep 2022 15:36:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D01A139BD; Mon, 26 Sep 2022 15:36:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ph1fGeTGMWMqKAAAMHmgww (envelope-from ); Mon, 26 Sep 2022 15:36:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eef1d36d-3db0-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664206564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9WOVGWfEzL7vU7Bj+g2o5y92Z7T6KVmygK/v8vociYw=; b=qOwRVOfMklLWP1ajTpkk8MNF2cv/9TiwDwz0NWsu6fdRglmK9u+miAHvx7cdkFzyExm6pf 7kBwfrJCngo/AA3p3xHmNz9k66TzGdrKW7RmaInjRph+l08F8icItH4A5s3cSOqYbQCxj2 /TVvkNkDvr+y8NLzqYnu6KfWeIpmSKA= Message-ID: <7477c714-4aa3-5fea-47db-01ccf91f3d6e@suse.com> Date: Mon, 26 Sep 2022 17:36:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses Content-Language: en-US To: Jan Beulich Cc: Jonathan Corbet , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-4-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1MXODAaqPWPZ0uy8iXtWpCDv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1MXODAaqPWPZ0uy8iXtWpCDv Content-Type: multipart/mixed; boundary="------------Kgf54Q0ZcCQxSVy0QutR0C3S"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Jonathan Corbet , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <7477c714-4aa3-5fea-47db-01ccf91f3d6e@suse.com> Subject: Re: [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-4-jgross@suse.com> In-Reply-To: --------------Kgf54Q0ZcCQxSVy0QutR0C3S Content-Type: multipart/mixed; boundary="------------ErEI6mST0vA9KC03NyB6XuvU" --------------ErEI6mST0vA9KC03NyB6XuvU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMTc6MjMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNi4wOS4yMDIy IDE2OjE4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEvYXJjaC94ODYveGVuL0tj b25maWcNCj4+ICsrKyBiL2FyY2gveDg2L3hlbi9LY29uZmlnDQo+PiBAQCAtOTIsMyArOTIs MTIgQEAgY29uZmlnIFhFTl9ET00wDQo+PiAgIAlzZWxlY3QgWDg2X1gyQVBJQyBpZiBYRU5f UFZIICYmIFg4Nl82NA0KPj4gICAJaGVscA0KPj4gICAJICBTdXBwb3J0IHJ1bm5pbmcgYXMg YSBYZW4gRG9tMCBndWVzdC4NCj4+ICsNCj4+ICtjb25maWcgWEVOX1BWX01TUl9TQUZFDQo+ PiArCWJvb2wgIkFsd2F5cyB1c2Ugc2FmZSBNU1IgYWNjZXNzZXMgaW4gUFYgZ3Vlc3RzIg0K Pj4gKwlkZWZhdWx0IHkNCj4gDQo+IElzIHRoZXJlIGFueSB0aW1lIGxpbmUgd2hlbiB0aGlz IGRlZmF1bHQgd2lsbCBjaGFuZ2UsIHBlcmhhcHMgZmlyc3QgdG8NCj4gREVCVUcgYW5kIGxh dGVyIHRvIE4/DQoNCkknbSBub3Qgc3VyZS4gSSBkaWQgYW4gaW5pdGlhbCB0ZXN0IHdpdGgg dGhlIHNhZmUgdmFyaWFudHMgZGlzYWJsZWQgaW4gZG9tMA0KYW5kIGl0IGp1c3Qgd29ya2Vk Lg0KDQpJJ20gbm90IHN1cmUgd2Ugd2FudCBhbiBpbnRlcm1lZGlhdGUgc3RlcCwgYXMgaW4g Y3JpdGljYWwgY2FzZXMgdGhlIHVzZXIgY2FuDQpzdGlsbCB1c2UgdGhlIGJvb3QgcGFyYW1l dGVyLg0KDQo+IA0KPj4gQEAgLTEwMTAsMjIgKzEwMjAsMTYgQEAgc3RhdGljIGludCB4ZW5f d3JpdGVfbXNyX3NhZmUodW5zaWduZWQgaW50IG1zciwgdW5zaWduZWQgaW50IGxvdywNCj4+ ICAgDQo+PiAgIHN0YXRpYyB1NjQgeGVuX3JlYWRfbXNyKHVuc2lnbmVkIGludCBtc3IpDQo+ PiAgIHsNCj4+IC0JLyoNCj4+IC0JICogVGhpcyB3aWxsIHNpbGVudGx5IHN3YWxsb3cgYSAj R1AgZnJvbSBSRE1TUi4gIEl0IG1heSBiZSB3b3J0aA0KPj4gLQkgKiBjaGFuZ2luZyB0aGF0 Lg0KPj4gLQkgKi8NCj4+ICAgCWludCBlcnI7DQo+PiAgIA0KPj4gLQlyZXR1cm4geGVuX3Jl YWRfbXNyX3NhZmUobXNyLCAmZXJyKTsNCj4+ICsJcmV0dXJuIHhlbl9kb19yZWFkX21zciht c3IsIHhlbl9tc3Jfc2FmZSA/ICZlcnIgOiBOVUxMKTsNCj4+ICAgfQ0KPiANCj4gV2hlbiB3 ZSB3ZXJlIHRhbGtpbmcgYXQgdGhlIHNlc3Npb24sIEkgdGhpbmsgSSBzYWlkIHRoYXQgYXQg bGVhc3QgdGhlcmUNCj4gaXMgbm8gdW5pbml0aWFsaXplZCB2YWx1ZSBiZWluZyBwYXNzZWQg YmFjay4gQnV0IEkgZGlkIGxvb2sgYXQNCj4geGVuX3JlYWRfbXNyX3NhZmUoKSBvbmx5LCB3 aGljaCBpbmRlZWQgaXMgb2theS4gV2hlcmVhcw0KPiBuYXRpdmVfcmVhZF9tc3Jfc2FmZSgp IGlzbid0IChub3IgaXMgbmF0aXZlX3JlYWRfbXNyKCkgYWZhaWN0KSwgc28gSQ0KPiB0aGlu ayBwYXJ0IG9mIHRoaXMgc2VyaWVzIHNob3VsZCBiZSB0byBhbHNvIGVsaW1pbmF0ZSB0aGUg dW5kZWZpbmVkLQ0KPiBuZXNzIGZyb20gdGhpcyBjb2RlIHBhdGggKHBvc3NpYmxlIG5vdyBv bmx5IHdoZW4geGVuX21zcl9zYWZlIGlzIHRydWUsDQo+IGJ1dCBhcyBwZXIgYWJvdmUgdGhh dCdsbCBiZSB0aGUgZGVmYXVsdCBhdCBsZWFzdCBmb3Igc29tZSB0aW1lKSwgd2hlcmUNCj4g dGhlIGNhbGxlciBoYXMgbm8gd2F5IHRvIGtub3cgdGhhdCBpdCBzaG91bGRuJ3QgbG9vayBh dCB0aGUgdmFsdWUuDQoNCkkgY2FuIGFkZCB0aGF0Lg0KDQoNCkp1ZXJnZW4NCg== --------------ErEI6mST0vA9KC03NyB6XuvU Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ErEI6mST0vA9KC03NyB6XuvU-- --------------Kgf54Q0ZcCQxSVy0QutR0C3S-- --------------1MXODAaqPWPZ0uy8iXtWpCDv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMxxuQFAwAAAAAACgkQsN6d1ii/Ey/P xAf+NyM7Tlvoo4n3JMLN0ocKeidnbN9wh2U0Iae2Kcj7T2rL81rDc2+KXC/YcXBN9hXVRlG7CO8J JEu6hKs++g9wXO1UokttV9HaFowPvKMJQAq/NISINinlTwx7O11KN3DpUdrFtk2NEc0Fea7SxP/k dRhn2ACOmhctLzmgUYFI/OrzRrwwxjpb5Jw7LY0h0dyvVfJQezGHxsIm82ZWd5hFnUlV+oQ9iJwW K0+Dvp2l3Xrk1zw1SegCe7PKBANLf75mP40gXeoqIihpOMZmEaMoi6BnYE/vE9u+AxB7y+18GEXw ATrc7dFLwQQzOL47+AYs7re4Xanb3hzkX6LEwo3M2g== =zd9Z -----END PGP SIGNATURE----- --------------1MXODAaqPWPZ0uy8iXtWpCDv-- From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:36:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411986.655139 (Exim 4.92) (envelope-from ) id 1ocqA2-0006Ou-GT; Mon, 26 Sep 2022 15:36:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411986.655139; Mon, 26 Sep 2022 15:36:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqA2-0006Ol-Dl; Mon, 26 Sep 2022 15:36:46 +0000 Received: by outflank-mailman (input) for mailman id 411986; Mon, 26 Sep 2022 15:36:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqA1-0006LX-Kp for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:36:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06678123-3db1-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 17:36:44 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7033.eurprd04.prod.outlook.com (2603:10a6:10:125::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Mon, 26 Sep 2022 15:36:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 15:36:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06678123-3db1-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmtQ7ebnfaPlrVPL+vMi61szgYsXIvOpBts1FIAN2tpOIJEvh6TshlR+/dqFPiQgc+v0SErl8qImhnJpd5F9IZrBx+VdDc7OB7YBNjLatx+NT2qsyqmn83vpmW50sGuUvdhpt3XTjF9Natk6dPiPDhVxM4/Esbn9EQVd09LQ3atuE5wQ8/oZdu8fgZGmm5NbgGXCwWEWJOtI5w73Dvlj+UncMP+W+Mv0Ueal3FWqHeOnJaMp1IhAFv2lXSw74OS8pBvpFfclZF03jixbHspnPcKNwEXXpYK/epJPHL9vnlM8YnevI6EH6R6NTmIxzH7c0tlTzssCc5o6mMT4x3lw+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XiRO1fbiMz0K0BF4WVdahsc51lQbrzcFmA4oYs8BhU8=; b=e2/eQVC451wQVaEMEhp4M/6vc642FMP2G3Uexo4V8OPnywUhNQkY1AcIrYuiirZocLQZVqpeALKD+kC3sKjksT8utKsfoKySgri7ZBGkYqt/29PGZo+Ja2YMnYHIzl2HgE72ru7keqNHsKTwdeF+xcklJfJWqlmTOLQIA5YSUHuII5u0iUC5zmXn5gYJP7PJ5pvca7+dbBZVV2ZpEzMV1WdPBWitmVjIib47n0TUS+o1NzZQMNBFYMH4U6esKYVNK1g9Red1NyQPKfwIjRPqnscXqSb8OIYP3HduSzEmFHj+cwiCaAWxurSVCesXn6en7dyo+9BXM0MxSr5K+JAYCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XiRO1fbiMz0K0BF4WVdahsc51lQbrzcFmA4oYs8BhU8=; b=NQzi6UGwqL6L/wPDCSHpFxszTNJp/a3DdpN3soAAWJKV7tGD4EOnZNO97RzecjbR4WDBSy6bQXexM+n/DWhaPbkGrLf671j3bzT8EPFLcYpqPh2KFBYZLXaGes3mpwyaak0yO3aXBmZYiodHXxVnSfkJwNVx3Jc5SUFUylWwjTDUp3SDw09uurZHQCgEMC2wM65nHSWAsCh8BP9Hr/Oqmfgk9ZDOGdbkSE/EWMbOCzVm2T/fxAd+pfijWUQAxBt4bvKe6Ua8/UHeuka9261dZ9Nrh0cyPw993CO4pGTvlTDXoUMhOQvsEQcy7I9i3No0h+dPMMqLV3MfjX1HH2OxxA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 17:36:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220922160516.5929-1-roger.pau@citrix.com> <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7033:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e87e328-329c-4aa6-f9db-08da9fd4e9bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jKDHb5ZObglI4TE/3CpXUZS3a+5A4rhhTJrD9eoxT/L++rCECWk8704IbXSoS907XRpHc4IckpPzOOLIbtbM0eaF5goim+jpG1VFXUS9lbJp7bOL0moWW3aKagPszImZmW9KlIsNaOXv/ARvKKPqlfiBGkz5zhSpfEcNyPdMaZMrqeX1jAXHC7+tockqLST3Yp5892M3ErNMscU18mv4BcXnEXmtidbjZirSJcfEutnn+TuOErywahUm4IJfg0Ex0WQIIROW9lRsTcxUgjA+Fy9S9vxM/VFllQ5de54yfRxvdebWXqGmqQP14ZF4ATFOmvpsiCyd2YF5IrCpp2i6WXTGBBfppq8+85w2LfnT0v64UgCO7nTvqXH3YoA1LGQs/VhmQxygDhTuDdgWGiomzJWWA+UOyE7jAe/MXCUnJ7T7M5CAsNWrdLuTqVYtDln/Xgkf8p9IhI73TXaYAuiYlCe2BdbRn62hOVKreNvta1ozyGrYa54iqIf1Zdts1OYETx6KPpX3VWTTA9cwW8HDjQz6lMcRwwE4HPtgX4lrXd9Aa36KB0rJ+EtEBobPzFoPBbWmWISTYdiDNhypAExelwuA6E+tmixvE3tcAs5nYBxnvNQcNNGckDtPC8o8t3pmft/KK91+4Ik3QnPg6Cm3xgvyH2hur9IM4aQw5WZoUL/DchPq7PIngc2D1tkVfZEoFm7Ji5V1/eLV0xAMIvocS8lvwd4f21UP7AyYN6n8Zvvgn6di7yXqfWweetDwrJVYtccOjbvc56FJqDbUu9fdYoA6u67cUXcLw+JKReMHrRs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(38100700002)(36756003)(316002)(478600001)(2906002)(8676002)(6486002)(66476007)(8936002)(54906003)(5660300002)(66946007)(66556008)(6916009)(86362001)(26005)(6512007)(53546011)(6506007)(4326008)(41300700001)(2616005)(31696002)(83380400001)(186003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2Z1YUJlb2dCOUR2ZzVqYUdqTGppeExBeUtBYnJoY0pXQTNBTTdwMi9GYzBZ?= =?utf-8?B?ZDhReGd5YmYycVBrcnI4VnRtc2JLZGhzV3RIOVZjUDd4Mlo0dkhpT0ZlRVA0?= =?utf-8?B?cUx6VGs5Um9WdjF5WG5lTG91ZmtGcnljdmxSK1g3bC9lTlZOd2RZTjIyWm4z?= =?utf-8?B?T0ZuZ3dHN0F1ekhpNmU0YWJRVjlucWpCeStFcGxIR2tLZEM2Z1lKbnB6Ri83?= =?utf-8?B?Mm0zaDkyT0ZGY1NKM0syb25tdmhrbnhXRjFGbllER3pramtpN2htNzFlalQ4?= =?utf-8?B?NW9ydTJOY2o2OE9ZZ3dka3ZzVWdVZFZiTWJrb2d3d1gyOFo5RGxuaDE0bWdK?= =?utf-8?B?bkpTMHRUUVIra0hCZ0NPYWZPZDVHTGdHYkVoOGxWNUVDSFJEVXpXb3A5MDho?= =?utf-8?B?S2tseVRTZFlHcHlRNHE5SXU4VFU3Szl0SDZyaXBmZlNTNVJoalFVOWg0elVi?= =?utf-8?B?bHJKQmt1bWNDVXk2Q0lxM1UxZUtGQ2VoUmpzaEFSMmFQQlNONUVJODRkQWxK?= =?utf-8?B?U216L1FwckhNOW02dUwxMjE2YXVIRmdSdGQxS2U5bnEzaGpQR3FzUCtIWkpl?= =?utf-8?B?cVJLVjFSWTREckZsTUh0RG1BYmJuWjFIVFFUMGRhL0M5QUhVaFhzZG9Gelp0?= =?utf-8?B?RlE4OGhTWnZLS05tNHExQVhBOXVkdVo5MHNGZi9FM0hucUx1YVJNQ1lsUkgw?= =?utf-8?B?djl5eHROc244bEtyUlpIZnJLVHU1aXpmOGFEM25wOEx5amxYRHR0QlRQbTJ3?= =?utf-8?B?cW1iN3Z6eHNHYnpsOHZlS1h2VVZVYS9iZWhENG1EbnBkM3hVb0ZGZU11Q1hk?= =?utf-8?B?S09LN2RHbkYra1dXcmZvOUhTOTc2UHJ0cElWM2lVcUJoc0E0R1VTRVhma3k4?= =?utf-8?B?L3krM1hsaVNrUXZCRWh4ZmZGdndoWmNQQ1JhL2hTWmZGOTUxWWFYRjlNbmtT?= =?utf-8?B?YmNYclNNSy9kZDlCMEtCVmFaZFlkazZjRmU4cGVlVDhYQ1Z4TS82aWlZQXZ2?= =?utf-8?B?RWJyS1JDdktDUDg2ckdKUDBsem1ubXYzYjVsTWJOVHVzUjZLVzBJWkNzYjhi?= =?utf-8?B?YnRXY0lJc2Zxd0xRMEVrMUdIT2ZySktPeTN1VEg1VEpjSERVNmZOZFVSemNz?= =?utf-8?B?MERNbkkrdE5qS0ROaDcwMlZzVUE5UjZYLy8vMmpEUktuSTlKdE9SU1F2Ym5T?= =?utf-8?B?aFkwbk5MVWVkWk1rZ1JMWk5obkoyWFhRTTNSdzFpYmM2cEVtc0ZNVi9KaFgr?= =?utf-8?B?M1YyT2Z0dXZHL1B5cTFMalBKM0dqRnZ0TXJjWVBzdWNBVkN2ZHpuNmd0bWQ2?= =?utf-8?B?NWZxY1VNZUNiajUrMUc0akVxZ05PdmVUVjJEVnlGRVpIWUI2Wi9YWEZPb0h6?= =?utf-8?B?MDYzNktDZHlGT2RiY2MveklMVXJYR3lkUWl5QVlOMW1nK1NscU5JSXhmY2lk?= =?utf-8?B?WVg1aFcxaVhpNXNFU1B5dHdWeDFqZGpUSDNrVHBGMytsTGZCUWNKeVZPUjFm?= =?utf-8?B?Z0FWMldjN1hrQlduUG8yZWN2Qi9TbGVQaU1UaDVFejFzcE1kSU52UldUdkJF?= =?utf-8?B?WmJha2VxOGtzd2lMR25mQWFWY1RnRThDYmRRbUlMZDlQVkkwZ2JnV0l0Z202?= =?utf-8?B?Y1RGbytxZUh2c0Vja3MycldvKzJUUWt3QlVFSHp3a0QxV29Rc2RMWmxCZDNJ?= =?utf-8?B?U3J0eUFHOXFPdmwxbjdkQzg3aGtjbjVNNHIxa2VXY3hCYnU2T2VZYTdDUDBy?= =?utf-8?B?OGFUUFNyN1hxMUp1QmpOZEg4NlF5Y25mZVNncFY5bGpPdTlGZzRtSFRsWk80?= =?utf-8?B?UmNab0o4Y3FraFVxaU9hUnd5eGxZUzRtRzgrai9QSU9NNGZGUWRScW80ZTBG?= =?utf-8?B?TjNNRm1JT3VoanR4MUVybHl0OXVTZThKNW9vUXFHUVd1c1c1cjZUeEN0M3Ax?= =?utf-8?B?L1FzOTFBNENGYUhTb2pvM1hmelJTWkRrSHdWMitDeDZGZ0twZ3pBVU81NTNK?= =?utf-8?B?OS9CWkZlSDN1SXNZREJnekNQQllSYVg5bDAybjFna2NBRy9SM0ZiZkFscllj?= =?utf-8?B?U1VMT2ZVcmwzem1OZlVlSXloakN3RlpOQjhDQytRWndJeEpVL0V6Snhza2Z4?= =?utf-8?Q?J0wapn/Qc5+Qx2eoiK7oxKyPc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e87e328-329c-4aa6-f9db-08da9fd4e9bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:36:43.0955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nQ0Nkf2SdW0lfBZo+i/zQWTk699UEA5yPNi73GaAEXBN/uQ0NhmVFMq6VJfGQio8Y+VQjjj7/sCt2HAg9Wp4EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7033 On 26.09.2022 17:25, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 04:50:22PM +0200, Roger Pau Monné wrote: >> On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: >>> On 23.09.2022 10:35, Roger Pau Monné wrote: >>>> On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: >>>>> On 22.09.2022 18:05, Roger Pau Monne wrote: >>>>> And if we were to restrict the calls, I think we need to clearly >>>>> tie together the various places which need updating together in >>>>> case e.g. the condition in epte_get_entry_emt() is changed. >>>>> Minimally by way of comments, but maybe by way of a small helper >>>>> function (for which I can't seem to be able to think of a good >>>>> name) sitting next to epte_get_entry_emt(). >>>> >>>> Such helper function is also kind of problematic, as it would have to >>>> live in p2m-ept.c but be used in domctl.c and x86/domctl.c? It would >>>> have to go through the p2m_domain indirection structure. >>> >>> It would need abstraction at the arch level as well as for !HVM configs >>> on x86. I'm not sure the indirection layer would actually be needed, as >>> the contents of the function - despite wanting placing in p2m-ept.c - >>> isn't really vendor dependent. (If AMD/SVM gained a need for a similar >>> helper, things would nee re-evaluating.) >> >> Maybe it would be better to add the calls to memory_type_changed() >> directly in iomem_{permit,deny}_access() and >> ioports_{permit,deny}_access itself? I'm of two minds - on one hand that would nicely take the call "out of sight", but otoh this would feel like a layering violation. Yet then maybe it's a layering violation no matter where that call lives. >> That would also allow to remove the noop Arm memory_type_changed() >> halper. > > Correction: the Arm memory_type_changed() needs to stay, as > iomem_{permit,deny}_access() is common code. Right, or we'd need some other arch abstraction. (I wonder whether long term Arm can actually get away without this. Even on the AMD side of x86 I don't think it's quite right that adding/removing of MMIO ranges has no effect on the memory type of accesses.) Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:43:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:43:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.411995.655150 (Exim 4.92) (envelope-from ) id 1ocqGH-0007y6-5r; Mon, 26 Sep 2022 15:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 411995.655150; Mon, 26 Sep 2022 15:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqGH-0007xz-2V; Mon, 26 Sep 2022 15:43:13 +0000 Received: by outflank-mailman (input) for mailman id 411995; Mon, 26 Sep 2022 15:43:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqGG-0007xt-6y for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:43:12 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2053.outbound.protection.outlook.com [40.107.104.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec78cc33-3db1-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:43:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7823.eurprd04.prod.outlook.com (2603:10a6:102:c1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 15:43:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 15:43:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec78cc33-3db1-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CdwIO187jJ06U/9c6GPFEHStikVx1/wfhW4C1ZJkW2BXPJ/YBnsMnU9rVVbEwS1CgM7yqjkxjVgjtA51p0GMDl0W/eQh1bBgZlXBOEULKAh60tAStxqomWy+F3A6mIAcyeCcYgd9MlY0RWqvKq3E6Y7kCwz1aRugxBqg9LT7/NXD1vgCi7NYQ7igL1aJ1a7gU/zbcvfzS7smQrYd4Lbt4mGGPVX5QppIQs/2XoFi+58k6k7KggJ5LDKaTJQoTdOZ2dfjERbF2i7Qv4+9G+ByKJpXs/S0IERNKGxhs+j+rdAz5LQ0jCI1qxamaBabtOY+NPKc942pMJ0nY3kbKEgCng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/wLw02V4JwhQCt/QO7yeGhhN/aqVFrk/+3J/uoGXdoE=; b=DYLQrMlfxbjcs91uMcsgwpNJvCSg8BT7S2/QZcxXh4lLYuKyCpv86EEQJbZ6m0aNvSTO7826W1ZH1p6diodb5rbOyosiA4MqRhTgZj5omVCciawofnwdByXve7Bi1evyqcy7+4kN+ZO8rJd83TMB7Rzd/Rb9dQ6C8FGZP/PtQLhnfsZA7DB344PCJ6yW9DJ7e8CxWTyTWG3Av9YSEKcu2RkBlRy+CpjRidM/2H7TToNkc1XUTb+Tta5bituSEUgacDMWJALUopc4L3fJWkQOqwv+Mgi7YRjEwN6kXjEimXOdrKr13xyxbXXvP5fQ2spghF7kU2bpI2O3JLjWVqDwCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/wLw02V4JwhQCt/QO7yeGhhN/aqVFrk/+3J/uoGXdoE=; b=bJ5/Gsk5QWkQp2pNl5IW3D0Y+lUykmOI6OfyRNZEjFtM/0eXea9goPmEwI4jeYDasziRv4Iv0xl54ho91KEYAa4eGDThboTPry3MT18ztKnR9ofnfWAINP42Ah4w/qit8eVFDUniRVyUIcAsJYQliNwNpTpAS9BaezdMVAkU11J+kH2Syn/B2gxLZieL6TQc4d0QhcQVuQHZ5xfbRYGJwR+cypf4ppU6ccKCdUt0isXmAdgPrRUj0nIExL5I5IuaDK8iPuNZo1a59U+KYUvaLDZsK+1YNhv3Mp6TSayg88jEllpBGS/yYIQWHob53uYoESSKoQjdWljLsBCqGYLQDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <81ce102f-3c60-5ccb-e641-03e6522e10bb@suse.com> Date: Mon, 26 Sep 2022 17:43:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/ept: simplify detection of special pages for EMT calculation Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220923105648.12587-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR0101CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7823:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ab88a20-72a0-41c4-452d-08da9fd5cfd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v6LF2og9+jyabpTy6ucksrW2rBIiovejJeStrf9S6gAjMCXDAo9lx5S3SJmH+QrupCkdTEN7yJyRMc9y9KXduzR97TUb4sbO6+VYXMUf+CfxEQTpbF5RdHGX2lw/zzB5aPwvlW+RM5D7k35HYPO3h3aGT/EMuFD8WoBsM8jaG0qqfwo2bKgnxWqmFFJfczBgHj283FM/DW1zGW6vxxO84trTi2IvaS/PJrziYcCDPK3/P0CCUBM9DPsLVEIoFYn5L1f3kSTFyEBTCcRtku9d0/zpfxR4Gd3GR89UDF37Oe89OH1g7iz0fLAQ1KO2cQm9wso2XZgIxITaIVQcUsZnKNX5emTa1LFYAqMFEV96+5d+0/cR2T7Emd7EDj9Gv/R9ecZPQOKtpwZJQ0VLn8iJjhHIlg3kGMSztIk7hlLq5kAnHrYyLWS54Thy1M7mxH9UYB34gHddd5QDYOqFfcvjpCAcds7ZMbxARsCiF2stp7/SrAmsDWK5IZd7jk65YVrqQvODTvAnMZ5L4emYHP2VYsJFdeN8tEzoohs15sFN9JyWN0lH3oOq7khQ8fl82K3RXtwvSDYWI77mQGRVT4w0MRoxgyjsnRXT0yjkGw75242C/N3/LUSthoX83HrkM+IpkRFcGa30Hl4fGEdPcFCtyt5Jbna6GlR9yn5fePhuOMg77e8qvqAM67J0H9/Yn9PBpDHwqxIHCtvL1auJZsTGzkm/a9is6C1ABkJgoxLcOW8G9Pb5ksTUqvB5QlD98MR/Qh8urSeyx4xSvYXFRYjlZfCmXiIUabVER4OcjaETrDc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(39860400002)(366004)(346002)(451199015)(5660300002)(6506007)(2906002)(478600001)(53546011)(26005)(6512007)(316002)(38100700002)(8936002)(6916009)(86362001)(36756003)(41300700001)(6486002)(66556008)(31696002)(66476007)(4326008)(54906003)(66946007)(8676002)(6666004)(2616005)(186003)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHJQaUMrL24zWjJEelRSVjM3ZWVKN0lJU0JiVG8wTTBtcE91SnFmT0hmOWwv?= =?utf-8?B?bW5GOGNoTXdDTWdpcCt5YzBobmlwb1FjTi9Za2FWV0t0MlladmRTU3ExaWZR?= =?utf-8?B?SHp4cFVZZDU3djFpVmM3ei81ZWxoTkc3aFZEWTljWFlkSEVpa1l5SWR5cUpR?= =?utf-8?B?SElqanNiazNuL254UElOSDB0Wk55ZXJzcnNBN1NvYzNhU3A3SzRQc0JCUmZL?= =?utf-8?B?RERzNlRKMHU1VG9YUjVMT1ZNZ1p5WHU5WVJMbzFrL29EejFQM2FSY2QyQUo1?= =?utf-8?B?UW1KRzFpdDh0Mk8xaTFxajlhSUZHbDdyZkxRb3FyZEIzeHhvblA2NUVvZ0s3?= =?utf-8?B?UjdzTFBVUytERTkvcHE4cXRPTGhsNjZTMUIvQzd0SXUwdmE0a1BQUk00TjhZ?= =?utf-8?B?Uy9ETHU0ajRCdlVTakM0Zyt3ZkxoLzN2NmRyVldLbzRGKzlCRHpsbVdPVU12?= =?utf-8?B?OCt1VGx3c3dIdnlYZGlnUnV6NStNYVBQMUlDYkJxbnk0eU1IZmtqWHVyS2NU?= =?utf-8?B?aUt6QnZWQUIzSllYcTVQNDVoNVpJUTN1M2QvcnB2aXhYWXFVaDlvNDkrQy9M?= =?utf-8?B?YmJtU1MrMjFHU2xZbDRjZzlSQks5azdKTDVqY2t4ZDFVUVFsbzRrZWRuWVYy?= =?utf-8?B?OWwvNGVqSm5MVVJuMzVQN0pkRFBDQ2tycnJhMno0bG9YRzYxQnB3YTlBRlpG?= =?utf-8?B?eHl3RXpIOENoSkF4Wm9DM3JnMllCTjVBVE8rbkc0MTFiWnFjNUhNVWRocHgv?= =?utf-8?B?Nkh1SFhFa0FyRkhieGU0disyNnltQVFUL2tpbzJxUU5kSUpFL2Z5QnJKSXpB?= =?utf-8?B?ZzRFWmxuZGtRQ24wRlFaMEdDNG0xb0xXRitDaU05WmoyVHgrK0lvTCtjeU9h?= =?utf-8?B?eGF3V0lDVXdZT1dFRGtIQnl6SnpKTkJHYmtna3ZuVXVSQTlkVGRkalp3VnEy?= =?utf-8?B?RDY3NERialEzZm1yMmFBU3F2bDZjbVAyUEFUQlU5Vk1zSlNXdGFjbEdMVGFL?= =?utf-8?B?Y3g2NGRoNjBoMW5jdDdKTGtqVG1DK1RWNi9sUnFvbGxQeUZvbVYxUTFVRjhQ?= =?utf-8?B?T1F1VUNqaXFjakg2dWJiQmpXdU5PRlFDT3RGa0owRjZoVDFUeHJreDZybUxZ?= =?utf-8?B?MDh3ZHpqczlhQkg2TXY3Mm9XejdjSmEwelZieTFnM1hVWUpIUyt5MUM3Q2gv?= =?utf-8?B?djVJOTdMdXNGaGVucGtzWWpDWUo1bEoxZU02OXpUOCtuZm1vVDdBeVZjSnBB?= =?utf-8?B?TCtGbzBJZ2pheld6aUV6VzBrSko0T3ZEeXU4YVltcW0ySDVZYWJKZWNVYnBD?= =?utf-8?B?UkRwS3VGQVhwL1M1azJ0Um1wNjI1dzU4cmg0Qm9rMEpuZkVzR2cwR0prZkkz?= =?utf-8?B?c2dxeWZkc1E0c1l3Y1RTZWkzbUZaMWEvQzNUdnFPUmFHYmlGYlFzejNWb3ZN?= =?utf-8?B?TkdwbzRUZWQ5bWxJT0Y4Y1NpOHY4TStkbDNXRW1YRnBObU9qdldiYWhxREow?= =?utf-8?B?ZStKL2ZSUmNUc0tObm9GT2VNZHJienNNK1hhT3ZEQnVtSlRNbEJnRkhaRmxi?= =?utf-8?B?TGVsdUVKRk50WGVnaGV2ZGpXMExENWFsNXFkbGlFMnRaNDRmWjZaRUlUUHBC?= =?utf-8?B?bG5nWmlNdFJPTkNZWHdZbjU0bWxRWEhWbm04TVRoV0x1UXg5NnBzUFk0N2th?= =?utf-8?B?VVArS1JxMVRsaE4zcTM1UkpWd3VZbWdUWXpTUWtsZmZENWsxcUVTVmwzbndZ?= =?utf-8?B?ZHVvSmpzdHVxY2FnazNJcm9razBYZ0VmLzRuTUxKczRZS2l6SU9ZRGpweVp4?= =?utf-8?B?Z1BCMHlzVWhtb1IzQTYyUU9GaStTS0dRODF6U0JsQ0liZFFhQVNPeS9HWnpD?= =?utf-8?B?UkZEUWZwcXFONTZibGFyeE91Q0pGUzd2TzhabWdRTXR5Mkl5VGMySDZNeWNO?= =?utf-8?B?UlJFUGtXTnQzdzNid1Vhd2JGNnIzdmZ3bDViTlhlT2VEc25NV3M4ZittaEx6?= =?utf-8?B?VzZZSEJzRk11dWhONjlnSENVeGNaakQxVnQzMHh1MlZ1UHBhNFFOZ1BZdDFh?= =?utf-8?B?elh1dEtsUlZpWlhTQ1dRSzl3ODFVVENjcm5WZ0lwYVprK2VoZlp1ZEhjNTVp?= =?utf-8?Q?nGRk/YlrzPx5gImTussW71eZd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ab88a20-72a0-41c4-452d-08da9fd5cfd3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:43:09.1176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zcmcnsWcw+6qa5sAu7730x4Q8v6yNJCBzzxXx5dZXirHqmwOd0GZ4/8qNsGIBhqG8GYAs/urbgQCfmQVkiNyKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7823 On 26.09.2022 16:27, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 10:38:40AM +0200, Jan Beulich wrote: >> On 23.09.2022 12:56, Roger Pau Monne wrote: >>> The current way to detect whether a page handled to >>> epte_get_entry_emt() is special and needs a forced write-back cache >>> attribute involves iterating over all the smaller 4K pages for >>> superpages. >>> >>> Such loop consumes a high amount of CPU time for 1GiB pages (order >>> 18): on a Xeon® Silver 4216 (Cascade Lake) at 2GHz this takes an >>> average amount of time of 1.5ms. Note that this figure just accounts >>> for the is_special_page() loop, and not the whole code of >>> epte_get_entry_emt(). Also the resolve_misconfig() operation that >>> calls into epte_get_entry_emt() is done while holding the p2m lock in >>> write (exclusive) mode, which blocks concurrent EPT_MISCONFIG faults >>> and prevents most guest hypercalls for progressing due to the need to >>> take the p2m lock in read mode to access any guest provided hypercall >>> buffers. >>> >>> Simplify the checking in epte_get_entry_emt() and remove the loop, >>> assuming that there won't be superpages being only partially special. >>> >>> So far we have no special superpages added to the guest p2m, >> >> We may not be adding them as superpages, but what a guest makes of >> the pages it is given access to for e.g. grant handling, or what Dom0 >> makes of e.g. the (per-CPU) trace buffers is unknown. And I guess >> Dom0 ending up with a non-WB mapping of the trace buffers might >> impact tracing quite a bit. I don't think we can build on guests not >> making any such the subject of a large-range mapping attempt, which >> might end up suitable for a superpage mapping (recall that rather >> sooner than later we ought to finally re-combine suitable ranges of >> contiguous 4k mappings into 2M ones, just like we [now] do in IOMMU >> code). > > Hm, doesn't pages used for grant handling (XENMAPSPACE_grant_table) > cause them to be mapped as 4K entries in the p2m page tables. The > code in xenmem_add_to_physmap_one() seems to remove and re-add them > with order 0. Same with the trace buffers, they are added as order 0 > to the p2m. Indeed. I was half way through writing the earlier response when recalling that aspect; I may not have succeeded in adjusting the text to properly convey that the concern is applicable only to future code, not what we have right now. > Note that when coalescing we would need to be careful then to not > coalesce special pages. Well, no, ... > Might not be the best model because I'm not sure why we require > XENMAPSPACE_grant_table to force entries to not be mapped as part of a > super page in the guest p2m. ... as you say here, there may actually be benefits from allowing such (re-)coalescing. >> Since for data structures like the ones named above 2M mappings >> might be enough (i.e. there might be little "risk" of even needing to >> go to 1G ones), could we maybe take a "middle" approach and check all >> pages when order == 9, but use your approach for higher orders? The >> to-be-added re-coalescing would then need to by taught to refuse re- >> coalescing of such ranges to larger than 2M mappings, while still >> at least allowing for 2M ones. (Special casing at that boundary is >> going to be necessary also for shadow code, at the very least.) But >> see also below as to caveats. > > I guess a rangeset would be more future proof than anything else. > >>> and in >>> any case the forcing of the write-back cache attribute is a courtesy >>> to the guest to avoid such ranges being accessed as uncached when not >>> really needed. It's not acceptable for such assistance to tax the >>> system so badly. >> >> I agree we would better improve the situation, but I don't think we >> can do so by ... >> >>> @@ -518,26 +517,19 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, >>> return MTRR_TYPE_UNCACHABLE; >>> } >>> >>> - if ( type != p2m_mmio_direct && !is_iommu_enabled(d) && >>> - !cache_flush_permitted(d) ) >>> + if ( (type != p2m_mmio_direct && !is_iommu_enabled(d) && >>> + !cache_flush_permitted(d)) || >>> + /* >>> + * Assume the whole page to be special if the first 4K chunk is: >>> + * iterating over all possible 4K sub-pages for higher order pages is >>> + * too expensive. >>> + */ >>> + is_special_page(mfn_to_page(mfn)) ) >> >> ... building in assumptions like this one. The more that here you may >> also produce too weak a memory type (think of a later page in the range >> requiring a stronger-ordered memory type). >> >> While it may not help much, ... >> >>> { >>> *ipat = true; >>> return MTRR_TYPE_WRBACK; >>> } >>> >>> - for ( special_pgs = i = 0; i < (1ul << order); i++ ) >>> - if ( is_special_page(mfn_to_page(mfn_add(mfn, i))) ) >>> - special_pgs++; >>> - >>> - if ( special_pgs ) >>> - { >>> - if ( special_pgs != (1ul << order) ) >>> - return -1; >>> - >>> - *ipat = true; >>> - return MTRR_TYPE_WRBACK; >>> - } >> >> ... this logic could be improved to at least bail from the loop once it's >> clear that the "-1" return path will be taken. Improvements beyond that >> would likely involve adding some data structure (rangeset?) to track >> special pages. > > For the guest I was running the loop didn't find any special pages in > order 18 mappings, which are the most troublesome to handle in the > loop. I'm not sure bailing early would make that much of a difference > in practice TBH. As said - it may not help much. > I did also consider using a rangeset, but that would use more > per-domain memory and also require coordination to add special pages > to it. "Special" is a global property, so I don't think this would need to be a per-domain data structure. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:52:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:52:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412007.655161 (Exim 4.92) (envelope-from ) id 1ocqPR-00016Z-1w; Mon, 26 Sep 2022 15:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412007.655161; Mon, 26 Sep 2022 15:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqPQ-00016S-Vc; Mon, 26 Sep 2022 15:52:40 +0000 Received: by outflank-mailman (input) for mailman id 412007; Mon, 26 Sep 2022 15:52:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqPP-00016J-9d for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:52:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ec4e9e7-3db3-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 17:52:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9296.eurprd04.prod.outlook.com (2603:10a6:102:2a7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 15:52:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 15:52:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ec4e9e7-3db3-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9Nx7g1UpWeVsmV7CQtjtGpr58dbWKfk+StEu8ZCkYHzGP+R4EdJZwW/1VgTJn0+p72PLnwTm3TfmYmNfalq9OSdLIfiN1Td85OGfdxSyWFIVfMA6BYU/8mqKgWcgOjDnI3Xr647Y1UTeJM6Tg0FSHxwGnYw64eRZd8XxqlKiKauIdlcYGF0WzWIPUfbCuIwvkLQEE4dWaDnFAluRmo2F6xrdaXnTOLkqPpsYMTdIdcIA0DX5+3o0rtGpBRrpD+bvu+D6An2PgbqaK+/LpwUKHTDdDr8LaWsDCXeegDQ1sE88cZ+6ExmhOFFaaCokYjreEu0CNCbCvulH34e1pc6bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V4Q5j4CgqRlyXplvwGKGlv+opU2Bw+QbT6FnbH3OG+I=; b=EixAqlbGbHS2x2f1j5MbiYBoxHAmN6cicD6qyZ9tB2LrDps1zYXGdU82j7VGe1VFHv+mD3UxqtagpwZ1CjW7W65qva/DPOLY3/JzTdDi7VupOxd2Z5WSP+lISnFIKftVW1Hsoofd7ZD+UOoK/qiFfNy83aY2sfnUaOnt5F37+JrvJZblLBueU59LcgqiVySSD6oMSYY632uzy0CrRzd6GwwFsSZlvIA3OpPZPErKGB1+0qSnVmyEhxPm6YDalmkUuiHkAicwFFsGADm/3LgjrZYJgzQrRi2sd58wI1HypkEUovflBdaS/gxjjPlyAlCm6FYFbCRTeEasTZpjTnDzRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V4Q5j4CgqRlyXplvwGKGlv+opU2Bw+QbT6FnbH3OG+I=; b=juFbANwsuPGGUWRZSjBn5AxIKMwE2Qg3ChdUQdSEHVn8V/ndYphg1E/5AwI6TXgJxWBCy4wjvKwEq3UkvTaLgaPQp5Q4JemH5GxC1z4Q1yUQ6UxXafYJbAmO18rKb+53azF105HWRbgEDFljcA99W5aJjNyBHPzgkL0Uzw3qdlQySUYXRrmNK9xAvKwurKfmJfx6f37bhnxrqcI3KhEOKs+LoIO8ENVBCYj506DFr8eyVMtdYU3Vawxz8oRgn9xU9volX74+XZ9TmzP3GjG9QYzXX9eMtmnTWJRrntvkz7EzP5B1FGY2MI0VIrLlDpWOPzcWL8GEhp+pc3MGGunSAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 26 Sep 2022 17:52:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session PVH dom0 Content-Language: en-US To: Juergen Gross Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> From: Jan Beulich In-Reply-To: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0262.eurprd06.prod.outlook.com (2603:10a6:20b:45f::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9296:EE_ X-MS-Office365-Filtering-Correlation-Id: 693abcb4-c693-4653-c7ee-08da9fd721f2 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D+TW8odJu/382t+RxE6pb/pDGdAWO7r3SGEu80p0FZ0Fc1hFeImhCehF8jiYECTNbTm7q23w5hxXIX0Q5j4PmEE4fPLYVv32JZiKqpscg1xMlxPRc95ZUCNRgXDpY2VfE9a3hHDm2CtnGRGGADbQ2DKHIRn5A6zetiwxXPTOw1UYPSQTF6yhC/1K1k02CuBRvdfYFlBOdflu1UWKF2oLH2yreGJby9lZEBgM5zRayHGbvDsBNEPHVWAInQHupdkP/TDOxLCnmSrWmMSE//iSbZ+GTZ7v9s6a3NhK8ma+Vq6c/1xg0+KT/mUctc2aKQurrPPef6B3b66Y/rvtrO4rf1Q2PKD77esnPKW5SZm75WbZXemYCV+dWqbufGTXxzmliunlYcQdWEB6B2x1WsjyAyx0VNbna7myHFlf3KuwgPw4bnBi3wzQNNQf9PTS1EaGACMZWdsrKvf5yiKFtgM9XgiOTZvmWcb32QL5H5FB05Ym+QeKeCxBLNiqqcjcOy+FqXgtNWLjx0bwVYmCP87dReTgvSqk6aJfN9K2NUfCBt3XxUPEnLmZagh8qhIXpMF//O9x0CrBSDd5Kia8A1PJY6T3reEfoQ2ksssxUu3GUtHXxPPGUkNzK/gZFt+uX1n3kfbh82UyzS63mOwHGpVCe9DlqtudwCYqQz/hocOWnR8IY5/cUOg8hcoXePZ+1Azis2Mo8jqKTNhIf1SYVvnaAo6DuwllsrNkF9LfCr4rVhU6DDnTGPn95z76A7LSICiyn+uY7coWa8g/EME4A8/MHbHsukbzYSDLe9paDIMfdgI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(39860400002)(136003)(376002)(366004)(451199015)(31696002)(86362001)(38100700002)(36756003)(31686004)(2906002)(186003)(26005)(5660300002)(6512007)(6486002)(53546011)(41300700001)(478600001)(6506007)(2616005)(316002)(6636002)(54906003)(37006003)(8676002)(4326008)(8936002)(66476007)(66946007)(6862004)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkRCMVA0dUxSQTRxOHJrd1lvTVRPeCtaUXhHWVdodmdYZWViRUJzcG5jbERZ?= =?utf-8?B?TG9WS0hqSlF0MmJyNXVHZTFRQXhJUlBpKzNXMFBSSngrc0Q4Wm5oOTJQNHdk?= =?utf-8?B?dDNVMFVBMmRCOG84MjYrdkd3RFZYTWQwcGFJZUc2cFNHdUJ5OTJjdis1c01Q?= =?utf-8?B?SDh6NXBYSG5BTGhoLzdnamZKTURVdUpPa1JyRzY0U2FveWVyMCsvRnpwZ1dZ?= =?utf-8?B?NjVyMWx2UFRpUlphT2NISEFYbHB6OERDempQbmtWUE9iSUdFVzVLaCtaUmJM?= =?utf-8?B?aHBUdlZVL0RHejJoY3psUzJ6SXpRQmRVSzBoV0l1L0tsT0k2U0VIenFYdjli?= =?utf-8?B?WkREeCthZ0F2WmxrME45dG1BcE9zZXFtRTF3K3lDdmFKZHNPelQxdDZMVnl6?= =?utf-8?B?ZEl5aG1ZZG43MjFLR05TQ240T2haRU1TczRFVDdiMTlmRXI3NlVoWnpwT3Zi?= =?utf-8?B?VmlPbVhmYTVMN2pxZFJZaTZManlNeVUxZDVzQnNCYjE1ak1Wd0hzbW1ScWRo?= =?utf-8?B?T21ScDAvSkxtcUJ5MHRDM3Nza1B2b2czU2dFSDk4YmFCU0hqTTNYK044SVFN?= =?utf-8?B?K01YNzZlME5DckpjekxyN3dHdGRZcW5zWjRRMmljWDIrcEI0NHYyMzMvMisv?= =?utf-8?B?SEFKc1oxRHMvQ3dybVNBdW5Ob0VVNU1wckhLT1VOT3BjN2YvcnNzb3NEKy9J?= =?utf-8?B?MEFQODc0WTV1N2h3T1dhTm1vYktqYWVkY3dWaVljYXNVNzJ4b1JhZW11SnFI?= =?utf-8?B?Y3l4S3NjbkZTSnQ4RHBGcWZkU3dqbHgycW1ZSE0ySXcycWRVK016NEI1b0FZ?= =?utf-8?B?blBGcjJLVkVwS3dDTmp3R1FiNHdKVFVGRXhPM1J3Q01WbDJTNXRhRXdXTnBr?= =?utf-8?B?VExWRW9BeStFYUNxY3ozSDUyRVZ3NGozWlY4QWhONDZrYlloRlZOODlmOHVn?= =?utf-8?B?ekhNUFNDamJhV0drMW5yVDRkVUsxTDFjK21xS3RQbVpreFdDa2o2OU1NRVdj?= =?utf-8?B?a0tabnBnb1lBTGhHY0dEOFl5TlFzdHJTNHJqT0NsZmhlS1F3bWoxOWN1MXhr?= =?utf-8?B?ejZNRmpFMFhZbXlBdnp3dUh0Q1BxaVVhQnRtYnF0dmRrODZ5UVE5U2NPNUxX?= =?utf-8?B?VHFDczZ6djFBUHFSdlpHNkRFRHVNdWVOb3EveDhPa1h2ZTZYVGZBMHZzUUQz?= =?utf-8?B?MEpBTXgwWTlnYVZvWVlRMmhEWWlBd2FCOTk0TXRlc2hNL0ROV2ZKRytOUHUw?= =?utf-8?B?Mm8rN01oY3oyWkovaHY3VHhYdTgycnZSUll4bDBuV1JTTE5waXExVVh2WDBZ?= =?utf-8?B?NFE3cWIwbWlFNW1Ya1AwOFdINW00QllIczM5S1FuMFozb0ttVW80bGM0RHZB?= =?utf-8?B?SUtSQlNBOFYyN2h0SDFOaloxcDlHNzhaQVRRT2gxWUpOeUFNTVFzb3JTcUdE?= =?utf-8?B?em1Ta1BDb01BMjF3NDRJUlFkZmMvT3NsbXR2WUpHWkVvUlFRbUM4bi9DSnZM?= =?utf-8?B?amFQQ1VLVGdKMGlNTVNPZTl1Ny9KTzdQUW9pOWZORDhDbXRKWGNqTm9ZYVRU?= =?utf-8?B?WUJBL0VOMzZTanNIQVFZMjNKd3VwU25KRTdVdVJOUU1RTzBPcll3SS95QWli?= =?utf-8?B?QTZsWVRGZVQ4VHRiVnhWYldOYmRkTmxPS2pqdUhhY0JHdmxqUUVSR1NjSXVI?= =?utf-8?B?d1FpM0w1MnhiTDR3dEY0UWN4RU8wVkhhNDhIblc2REVEVFd3cE44djloUHNo?= =?utf-8?B?L0JCbktyKzh0ZlYyN1c1Ry9UY1diU0tCQ0tWVHNDS1J0REVqQWtPWTE1UkM3?= =?utf-8?B?a0ZRMGx6S0M2a0ZUZk9RRjR0S1ZkcGppVXU4SjRaMmlrWnV5SXhQaDFVT21h?= =?utf-8?B?a2NwRG14NitHQXlRM0xmVWVQNFVTdWFmVlNhdDZGMXRrNGpwWVFWNllManpY?= =?utf-8?B?RC9kVDE1cDc4RFJ5Ry95YldNUFRXTktpd2RHd0hBbVI0eVNkekdhY2s1dVhy?= =?utf-8?B?ZXNLaXFvVjJvTWdqU1RLVDdrbHdiUkZCYnlFbkdIUjN1bXd0bzI1TXJPOUN6?= =?utf-8?B?OGRNQ1lGRk82SWQrajNESnVwQ0dKbmR3b1diTFJaT2h3dGFjZ0FNWk16WkZ6?= =?utf-8?Q?qEpR3iWPE8qbWmIX3iBoXV2hW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 693abcb4-c693-4653-c7ee-08da9fd721f2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:52:36.4565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vCtyOqnDTXHwDEpn5JQIdFymBPXNCOmoIdO6oZ3xLCDb5fbsjaIdD+ftXPZqa6K1c0WgFBmeZHDOhRQJHIN9XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9296 On 26.09.2022 10:33, Juergen Gross wrote: > On 26.09.22 09:53, Jan Beulich wrote: >> On 23.09.2022 10:20, Juergen Gross wrote: >>> My favorite solution would be some kind of buffer address qualifier for each >>> buffer (e.g. virtual, physical, SG-list, maybe nested SG-list). So the new >>> hypercalls would not mean "physical buffer addresses", but "qualified buffer >>> addresses". By requiring a minimum of 4-byte alignment for each buffer (can we >>> do that, at least for the new hypercalls?) this would leave the 2 lowest bits >>> of a buffer address for the new qualifier. If by any means an unaligned buffer >>> is needed sometimes, it could still be achieved via a single-entry SG-list. >> >> While this might be an option, I'm not sure I'd be really happy with such >> re-use of the low address bits, nor with the implied further restriction >> on buffer alignment (most struct-s we use are 4-byte aligned at least, >> but I don't think it's all of them, plus we also have guest handles to >> e.g. arrays of char). > > The unaligned cases could be handled dynamically via the single-entry > SG-list. Can they? The first example you gave, the bitmap passed to collect the output of XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, comes as a handle-of-uint8, i.e. generally large but not necessarily aligned (even if in practice the caller likely will pass a page aligned buffer of multiple pages in size). If we introduced physical-address bases replacement sub-ops, I think we would make the buffer described by an array of GFNs, not even allowing sub-page alignment or size. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 26 15:58:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 15:58:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412015.655172 (Exim 4.92) (envelope-from ) id 1ocqUv-0001sf-Pl; Mon, 26 Sep 2022 15:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412015.655172; Mon, 26 Sep 2022 15:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqUv-0001sY-NB; Mon, 26 Sep 2022 15:58:21 +0000 Received: by outflank-mailman (input) for mailman id 412015; Mon, 26 Sep 2022 15:58:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocqUt-0001sS-Lp for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 15:58:19 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06fcfad4-3db4-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 17:58:15 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 11:58:10 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BY5PR03MB5079.namprd03.prod.outlook.com (2603:10b6:a03:1f2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 15:58:09 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 15:58:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06fcfad4-3db4-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664207895; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=4T+ETCK3Y9cSojC8T71GKiPKgJxTlydvdhOA88PfrF0=; b=ZuNebobBOCiWuNlRFWnxziGQ/aD9fVAq+JoYHQoAov71YCnsE/VQP1xS ZoAfVSyLAR8Cm5B1w8H2KYabJQpaoSow4hz7oEEfU3MLiMr35KgUEQOsr W87SphpY6nb23OqVbdzmE7VBGdQHm6w1lQ/1YpNWHmFCtOolEOuV/IpMa g=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 83880384 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NhnYYKAZotNE7xVW/xPiw5YqxClBgxIJ4kV8jS/XYbTApDxxhjxVz mMeUW2Bb/rcMzCkL9l0Odjg8E8FuZCDnddrQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFsfzb8XuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJWyL15Kw3JVgqBpQj9OV0IUZC6 PVIBglYO3hvh8ruqF66Ys9Fo517aeXOYsYYsHwmyizFB/E7R5yFW7/N+dJTwDY3gIZJAOraY M0aLzFoaXwsYTUWYgtRVM14wbfu3yGkG9FbgAv9Sa4f+W/cwRY3yLHwGNHUZsaLVYNemUPwS mfurz+pUklBZID3JTytriKet+yWghjHQ9xRSLmK7thVrgOC7zlGYPERfR7hyRWjsWa8Ud9CL 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJ4EfA+6QyL4rrZ5UCeHGdsZiVadNUsucsyRDor/ lyEhdXkAXpoqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWdi9T0HXT8x m6MpS1n37EL15dTjOO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComV/lhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:1G3TI6yNmv9KSzG6tnA5KrPxt+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIG/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF9nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvGOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1sop5PzuN+d3B+3Z W1Dk1ZrsAxciYoV9MNOA4ge7rCNoWfe2O6DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK j8 X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="83880384" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exwXJntPFRqmi3gGk/KKFwJRujL9vG9aJSu/T9yRnkVJ3vqHfF21d22k1AZhXdzHE0VIdbzoOJB0iuwW6BGPGao1lC81qolA1TaVX/QUBW5gAgYs7m0+A9JQkRdhrWecC1XeKgy9V7DtI7ob1jINF/AfoHEIYQqFv/aexcb3LZZP6GLnRGeAmFlB2zYBspgLBAbf0omI20RtrgG2JaK0GpuqhXYgd90cblsXUPdRtZ7qTVgyC+jNcQSjgoOZkiLdZorat6vhjylDpe/I8QnThr+DHNw06XM7XSraFg0+LkwmM09pGpbpVR5KN6B0Jc+SzaHAvrZDRa7ExOjuxK/EmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HFkGVCZHAGo1wdrcRmiPXjKOM1e/WcvhQd2kqO6ZyWc=; b=W88L4NC0K4ez8eFFlr1AHfkL6cKkjM7xX1OurmG/tic2r1X51tmPDDRGlRqVjDAt9/TjF98UBlb3fvQiWwiFMMPWZMTQQ5zdLAu0ll02M4KU0yZj173vqHgVMuBt9cmvlYisf7+P5QqB8qZJpFtJVeb+014F2nWDpF+gtCVuJTYa1nmQyKM+cl9nSOd7JrhdEoBCVuMqXAIuRk65DfLC4qb/0QX/0t/nB+h3oJLc7GgCeD1XImOqQE/LCRajNfXS9PGYFJA0HE6Gqb6Vt+AFhxF+EFMsXwhzMQ02iiHNRg8iEW3WHaapEmpiqMd0U0PBKAN17VNwXWjEnh0gQ6d1/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HFkGVCZHAGo1wdrcRmiPXjKOM1e/WcvhQd2kqO6ZyWc=; b=g9UIuYRq0+4x/pyf0TeJAmWW/KpKDiCWdrOygC7AFmMtOT0eZT9aJ7/riMXo7BDDIEoosBiH3SlNyEwXB0xe+1z+iFHDvNmy8qSSmd3i68a/3XjYSiEsTPyznhzO7gCUiTZQwg+EuhKKm3B6iSD7n6ldkUVDm5kpkHuTWLTeXuo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 26 Sep 2022 17:58:04 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220922160516.5929-1-roger.pau@citrix.com> <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BN9PR03CA0314.namprd03.prod.outlook.com (2603:10b6:408:112::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5079:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f64a554-3e38-4eb9-2e04-08da9fd7e7f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3AvFTBGP2eK1hCQAOLLO1Ido4ZN3l64mL8igbH4eJ6Jo/9UCBvX5TgTCXEWYOLWi0KK7KWDpaJZlG/5fmI672h7XVQz2eJ0XnsqjxpWySYs9ljgNXMmTY871e3EZwEtAWsSfpHAf9xiWJn68oAYtaZcnc5Wb6AyiOJ0lzta85QzuPJltMDiVW6ttojg+FCegGyHmDn5VMZqzw+pGi87T/0XWFh28CDSJdaJ0vM3hfs6Fh/1E4ZpxIEfB/YDHPjd7Kp9AWeRt9jrQLfVAoeeI2RF0L4Ct46Ps+ziHGsw3l9HAJOfabK8Cjc3t7/ZU2/qHVOYg2NVoE3v7Nz21xl0rpDrIFkJgSC9HS9g0HQyVfnBAYR8wCYOlOTLONfzkeR3/wJHiIr3/3sqgqCn1v6gPcAWo6YA1aM/M96bA+xOmpsqTNTHIn6N4mUbI+cxchJpMZN4mYadOiJ/Dpa8zYsyF7zSuJF4PL0fpI9xHA2FG6bfH842J++BWY69mxUicTCQ9omXIwd/uBLktE83ah+2AppLTda557lr0aB5enkCHRRuxxiIzhmyJbqjDq4P1vcxwMzEnYjxoTuV9gX6BNY7494NuW23sNHRjsgqDkIGID7oxcBJ7iB54OpWnQo1UWWQLw2VXPoiWfRGuzYhBYcKvl/lSj4vMevWPuM1acJ1CPLFD9l0iOftmLxRMeyv8u3Wc2qZeInTlu1P1xdwqchRmoBpOm+q/sEKkDMQmuQEAmAv+A20LObhd6AV4f5E9bH7v X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199015)(8936002)(41300700001)(5660300002)(9686003)(186003)(85182001)(6916009)(54906003)(316002)(2906002)(6486002)(478600001)(26005)(6506007)(6512007)(53546011)(6666004)(82960400001)(83380400001)(66556008)(8676002)(66476007)(66946007)(86362001)(4326008)(38100700002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnBwcFJxN0hId2E3YnVNZjZ3WkpnY1IvVG5oUW5nNzBUTlRSQWtVQ1dFdStG?= =?utf-8?B?OFVZOWJYa0VjZ1E3UFovMU5UNkVwa2MxMm91N2psVmJMNmtMQjJjN0k1eFZ3?= =?utf-8?B?Mm1FUFNaNTNRVFQ0M3RLU3BmSlNqQnozdzhJQWJFVGxpNWVTOHZab05nc0RP?= =?utf-8?B?NkhmYnRPNmtBbTIwSGZlaklNN3k1MkM5N01JRnBTaDFvWXNZenAvalBMZUt2?= =?utf-8?B?NnV0WTRRT3BqaS9najhubTBiVDZHM0dnU0RPL01HcFlPczl0bzBJUk5hL3Zw?= =?utf-8?B?OW1rZVhaT3VXRWVBa2NYWmFMa3F2VEIxZ1ovUHQrMjYxRytOdm9lZDZKV1VG?= =?utf-8?B?c2JxWHF3NFRVQy9TZVVHbGNRZDkwNnZUZEhBalRZRU94SHJUYUxaeGNZWnA3?= =?utf-8?B?aFJyRUpObW9UZ09Fd1lkSHpSZGZ2dDA4ZzRBS1lmT1VxckhSSDNiQW9leFpy?= =?utf-8?B?SmgvdXVEYWxyNjJpaVprRFZBWlZrd1VTcGRTUFVTTklORjNPRUVvUkI0bnVz?= =?utf-8?B?QVN1dU1rcE80bXBEcVQ0Rys3b0lKYTVRdGVLNTd0UzNZSjBsWDRSZCtWNXdN?= =?utf-8?B?V1dERmJqd3NLZXBrNTB0UjJwWGFkZTNFMVRwQ0FNdGFXMmxZd1dSdVVOQnUy?= =?utf-8?B?eVlKRklWMllxQ3RGZEtzSkZ4NFNreHhNcGF1K01oa2tZakNFblYrVkRlYTVO?= =?utf-8?B?S0tCWGIzbG1hMGNKODVVYmNITVd0Zko1NjJpV0ZrSFRVQVNzaUhCZzN5Tmph?= =?utf-8?B?dFlwSmJ1Vy9Bc2JlQitjVlZha1p2Yy91bHFkSEFjOFBNa044c3RoQWRNa2Fz?= =?utf-8?B?RzkxV2N6d3Blc2NlSERvTmhFdlN4UVU0eEk0a3JWTmhPc2YzUDFjWmlkQlRj?= =?utf-8?B?RldBZzdpWkwwT2xJQlZydmxPdUxHK0V3RSt6ZlpJT2dIOWRJMWZVY0puWlVy?= =?utf-8?B?TUNEQ2d5S3FwVnkyb0lGODl1STJVaUYvN0FXUXk4MzZMeDF6OFJYR1FPRjI1?= =?utf-8?B?UlJMSks2K0FsVWNjSjdFeVZlaFluNnZqL3lTclF6TWxjcUp4L1dOQjdEdWNj?= =?utf-8?B?VlJReFkvQUI1ME1EQk1mRThpWlk5S0xRamtsWFhvYlVhZENiSnV2eHZWbWZ5?= =?utf-8?B?UjRXQzluNlNmUXU5TzhOeG1JYnlwWE15V3Nub2xHWEJxSEwxTVZVbVhSL3ln?= =?utf-8?B?cHJsa2toN3JnNU5lNjVaL0VEZ0crT011bUlEb0c3ak4rc0FMc2xrRk10aGJa?= =?utf-8?B?QUF4VnVJbnp5d1FPN1o3OFhFS3JSZkQ3eEM0QW9NaUluRGtXYlhLMDBUOHd1?= =?utf-8?B?YjBqMDlDVlVpWSt5MUhsQkcrTXdkVUZTTnQzemZZUGVNQXNpK1IvNXVnbkNF?= =?utf-8?B?OVZ4aHpRUldPbitQNlo4V09pbng1WlFWbVBwNnlJZEZGTkFoTU5iNTZSOGZh?= =?utf-8?B?aGJjcUFZQzJjOTNua2FUVmhpT1ZQSWJuVFNScVp1SXEwQlp0cDFQZFlsSjFP?= =?utf-8?B?ZlhBQ3FUYkNPSmQ1UmM4TSt5Y01vc3pPcEdNblFya2pKVlpkbVZGUWZEYkg0?= =?utf-8?B?SDNuVEdwRWhpWk54bUYwTC9jb3ZEU0hVZWlFaThrN3paSVpnRHAvL1ZiemVo?= =?utf-8?B?TVJqSDB3aG9VUHZnVkRUYkc5T2grZmNUUzlKaGlDbHJoUGFmb2ZEcFA4NG1Y?= =?utf-8?B?akRUdkMvVTRINCtjQkZQa21XcVdEL294QUx0YzJFV0hiUWNtREpyN2d3aVY2?= =?utf-8?B?RGkwYVMvT0YwSFBMOU9QVEg3R2ZldG4yTHZ3Q0ppSjl6US94K0NKeGpZMFdy?= =?utf-8?B?SE8ySEpGSnNpWFJiajBmMk1IN1Fac29OZ0tPdDNHekUydDRlYi9yVWljK1FU?= =?utf-8?B?ZWJjTXExbklHOE5LaTRhRHk0UlBFdFVGKzR3WGRkZUVrL3l1VVdCWnRaUEJB?= =?utf-8?B?V0x0WFBQYUtvT1lSTlNRcVVRdS9rK2gxNVpCZ00wYkFxVUI3VkZiOTV2a3pz?= =?utf-8?B?VTRieVV4V0VNZzdUeTAySEZXZUVBNytDTStTRWZabDFaU2JwUy9Db1ZLSkMz?= =?utf-8?B?SFM1WkJYaWJDVFZwTkdjK0ZwazBKVFFmTUJFMGNZaGkzbncxTnQrVnpuMkRC?= =?utf-8?B?MXlBQjhDYVdJWlc1Uk94cmRkUEowbnNiV01TSis3bTR1dHlXWTB5SFg4OTFy?= =?utf-8?B?T3c9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f64a554-3e38-4eb9-2e04-08da9fd7e7f9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 15:58:08.8613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iMT1UgEtsRLZFZajb7Un07BFdXN98nqrzyFD+g+Cbhe1MX4H3s9ySEClp7/c6/vqwkGV/aNiZDxoHCZSnvBu8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5079 On Mon, Sep 26, 2022 at 05:36:41PM +0200, Jan Beulich wrote: > On 26.09.2022 17:25, Roger Pau Monné wrote: > > On Mon, Sep 26, 2022 at 04:50:22PM +0200, Roger Pau Monné wrote: > >> On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: > >>> On 23.09.2022 10:35, Roger Pau Monné wrote: > >>>> On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > >>>>> On 22.09.2022 18:05, Roger Pau Monne wrote: > >>>>> And if we were to restrict the calls, I think we need to clearly > >>>>> tie together the various places which need updating together in > >>>>> case e.g. the condition in epte_get_entry_emt() is changed. > >>>>> Minimally by way of comments, but maybe by way of a small helper > >>>>> function (for which I can't seem to be able to think of a good > >>>>> name) sitting next to epte_get_entry_emt(). > >>>> > >>>> Such helper function is also kind of problematic, as it would have to > >>>> live in p2m-ept.c but be used in domctl.c and x86/domctl.c? It would > >>>> have to go through the p2m_domain indirection structure. > >>> > >>> It would need abstraction at the arch level as well as for !HVM configs > >>> on x86. I'm not sure the indirection layer would actually be needed, as > >>> the contents of the function - despite wanting placing in p2m-ept.c - > >>> isn't really vendor dependent. (If AMD/SVM gained a need for a similar > >>> helper, things would nee re-evaluating.) > >> > >> Maybe it would be better to add the calls to memory_type_changed() > >> directly in iomem_{permit,deny}_access() and > >> ioports_{permit,deny}_access itself? > > I'm of two minds - on one hand that would nicely take the call "out of > sight", but otoh this would feel like a layering violation. Yet then > maybe it's a layering violation no matter where that call lives. Kind of, I think it's slightly better than having the callers take care of calling memory_type_changed(), and prevents new users of {iomem,ioports}_{permit,deny}_access() missing the calls to memory_type_changed(). Let me post what I have with this approach. > >> That would also allow to remove the noop Arm memory_type_changed() > >> halper. > > > > Correction: the Arm memory_type_changed() needs to stay, as > > iomem_{permit,deny}_access() is common code. > > Right, or we'd need some other arch abstraction. (I wonder whether > long term Arm can actually get away without this. Even on the AMD side > of x86 I don't think it's quite right that adding/removing of MMIO > ranges has no effect on the memory type of accesses.) IIRC there's no way for the hypervisor to infer cache attributes on AMD SVM for NPT entries, but maybe I'm missing something. Guest MTRRs settings are completely ignored for AMD guests. I'm not able ATM however to find in the AMD PM how effective cache attributes are calculated when using NPT however. I would guess host MTRR + guest PAT? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Sep 26 18:03:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 18:03:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412034.655183 (Exim 4.92) (envelope-from ) id 1ocsSD-0007Ds-QU; Mon, 26 Sep 2022 18:03:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412034.655183; Mon, 26 Sep 2022 18:03:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocsSD-0007Dl-Ma; Mon, 26 Sep 2022 18:03:41 +0000 Received: by outflank-mailman (input) for mailman id 412034; Mon, 26 Sep 2022 18:03:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocsSC-0007Df-Ho for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 18:03:40 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b1c373f-3dc5-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 20:03:38 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Sep 2022 14:03:29 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6034.namprd03.prod.outlook.com (2603:10b6:610:bd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 18:03:24 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 18:03:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b1c373f-3dc5-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664215418; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pXW/vj+YwTiqrobAJ7BbUg1GgTQPb1zjGrdTbyLZBDQ=; b=MfQsRP7xEvUnAMyxjkhRdMhETYDappb00GTDOm3hDge/EatsPtVpmolc CoAHICwCV/HWZpCNW+bLHjz1XxS/QpnJn1wOwt61GEQgO7qP8bPjQ2X87 lODHf7/Mp62+95neESv0jJH7r6WfHoCkIzeAjVv5bQLsTa6THIYdCiAW8 I=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 83891107 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:BlFtmazSCW25jvAw1SN6t+f2xyrEfRIJ4+MujC+fZmUNrF6WrkUCm 2YXXWvTM/jYMzD9c4p2bI+18RxVsZDTxt9hHQtrryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Ukx5K2aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN10BkQGFosAx9pnCDBt8 OQSOS8xZxKc0rfeLLKTEoGAh+wFBeyyZsYzny8lyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCSuNWQG+Dp5poJui4TX5CV33KLgL5z+fduSSN8Otk2Zu njH7yLyBRRy2Nm3mWHVoyv13rCncSXTeaApJrKSzfNWuESX4lUYVho8eUOSvqzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv neWm/v5CDopt6eaIVqf67OVoDWaKSUTa2gYakcsVhAZ6tPupIUyiBPnTdt5FqOxyNrvFlnNL yuiqSE/g/AfiJAN3qDip1Tf2Wvy9t7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lR9lFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:bQH34q6xqNOpCchuCgPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO X-IronPort-AV: E=Sophos;i="5.93,346,1654574400"; d="scan'208";a="83891107" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1w1nky5XQR+QdD2+zxwLp1tKI8vBLZOgZ52CVIHd9chzpTqWw5hjGYSl+qyx+MNZIgBvQ6Lp4M0Qe4TfClG2S6ZDr0NK9nHmW3u18HjmXOEq0SDwUrksNpZ2KZZuxeMV16fjbatYLyp9nJJ5VwYg773sGfKBrQFrzdgC0tMhzGbxXKZxaqHz89jq0Ootb1OSGSYKgm25KkVFvF96alvR3AaTb6hAXk87XhVbTzGMM6/z+lrKrbvk5WbP8uxx20W5Ds4tlSgGqWF9fpA5tpFo8+BIwO48uFrvjXY6N8WVN58MFqLSAUoJO0jOBWderbrRE9XXnkF3RCC+uz4/Kv1iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXW/vj+YwTiqrobAJ7BbUg1GgTQPb1zjGrdTbyLZBDQ=; b=gUyBkKXPA57KigJspkunI7TIFA9DjRJYfXbLDFYyRjCPr4VIKq7wtQu68u3/iw6aqHpQLNRimcec2u0esqcGG/+ZayYu7Kd9JO1UdffIs9pFdLGoJnV5TxCvjCl1FDU9PsVMQQWecoYeS4Io3BF4pmhA6Se7PVHwjHbl2xBO367SQXKT9CLCP7hJYe6Z1ItsxBCtmCPU9G7za2lnt0unINWxrOXGR857K59QIyMkIYpNAQbRAfWJRZnERsLG6pB1RsviTIlkSIJGlR3VUGzwQtiia6oGYa+Mwpg9f1sGHLNsXX3QGTNhtK5sUKX1ZVWBpTf5qOrKjWYSKfYFKUXQiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXW/vj+YwTiqrobAJ7BbUg1GgTQPb1zjGrdTbyLZBDQ=; b=umOINkg39jPq9Ti7JNWQT42a8ULyItRwuFdA4sr2DI9Ja4+iRV7a6raPMrDsAJbYXO7KfZKmkwlehUbF/z/YYd1wo5hReUO/8D6OcTNF6sy5kzOZyW7GiOx7lnlFdRzuwdCChKazOEZ7fDu4baYcX6F86Hpfy6ndK/+hXI8ScW4= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Thread-Topic: [PATCH] x86/ept: limit calls to memory_type_changed() Thread-Index: AQHYzp0jOSXqM10oEkmgUDyRmTrHkK3yB08A Date: Mon, 26 Sep 2022 18:03:24 +0000 Message-ID: <3ab6e33c-58a4-8db7-93d2-631b60e9772e@citrix.com> References: <20220922160516.5929-1-roger.pau@citrix.com> In-Reply-To: <20220922160516.5929-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH0PR03MB6034:EE_ x-ms-office365-filtering-correlation-id: eede0fae-8939-4948-0ac3-08da9fe967d0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zuRBk4FyTqDwntikFmCJaFJQYUmx3UX+jaRt5tPswvOHib0qbblJBBpTEnJlGHPVhNV1ymvHr++AQjFzp6/F6a/7qNPj1/z/IhFQ7kNu/Wc0lzwxIkw5Cidgt9/h5OYXtRcZcqIFFD2lQ60++XqkNsQtoD95F3ZbH0d38jDiK4g2VvMDhL4txF56P1ANCRfDFGb8MZTf5/8BgJ2YxAVHbXhcROqPYhqqWwx8iZnO3QZ4OOCc3R5KgqPODAgO7Kn0Z77oix6ffaToajVhJMnbRZsOQhyzpyGXlFVRJV4CTc3Yyl/YrbsiSpR4U01XMX/yjAvQnDruv7JOiO9+bY9SBg92Ip4N5nzX+bssPAY2XGjBd3zhxP0Kyqlh/SQuSDwqeaPzSnbaTAx/K2v9GuXtEQsd2Xkb1qzlErr9azo+gau5UIYvhG3sL3L4KEqhpBP5mU4dcEs5GjbosnCPMUm0sRRA4FaPCk0jvCjJMbDZ1ZUVUkTuVnlEDezmTbdPkhFzSHvoE7U8YPolCBG1jyeIpa2oS/kb6JP9RSUcqk6jh2Q3f9zDp6y99CVHZs1+oLzb/GleTyMNfeVTt0rRLnYPeSJb8IfzYNPnLmeiofUgX0EjfSomEMedX6f4IKQFyMtXP0WomOygRf4Rqpv9EWlXFCSxOgANiMsUSEL/huADp9nAkmQ/ER0bwhJFrWu31hVXbXhDVmTo7lVnAYvRO+8kkYIJdh0q2pWFminSfbY61Dm3Ic02hOrMTSlnYRhgIbea7SQV/Lx/oNC4uDPURwXUw4sCfXGlP5VXLwubksrsT2olXtYx8rYTaGS53CPPDzIHmcACl0HYJVNq9tR1msCRLg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(36756003)(110136005)(31686004)(86362001)(31696002)(5660300002)(38070700005)(82960400001)(2616005)(54906003)(122000001)(38100700002)(83380400001)(186003)(76116006)(53546011)(6506007)(26005)(41300700001)(6486002)(316002)(91956017)(4326008)(66946007)(71200400001)(66476007)(66556008)(64756008)(8676002)(66446008)(6512007)(478600001)(8936002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ajZYNnM2Uk1mS3VuRU1od2hjcjYzZDFrMUQ0RUZpMmsvWjBhV0hrbWlnNkZr?= =?utf-8?B?NjZHNHYvNWliOUZOU1IwQ3lpTkJzdDI0WlBFZjlHcktRSmNFRkVaUFkwOW14?= =?utf-8?B?bWMvSHdXR1VEYTRTSFRMZHlPLzFqcXJ5b2ZpYVFqR2xuQjJ0UGg0bHh5dVlp?= =?utf-8?B?N05CT1lXNzZKK2VaYmpNYnpkbENhRXkvTGV1c1BRSjhoQTNwUFpvLzNOempq?= =?utf-8?B?UmRkdTV0b3FHTE5VemI1a1ZveUNWeGlVZFFqK3Q0TGlDRWJ6LzJWaHIvL29D?= =?utf-8?B?c0VLOWNaSmNnR2daeDdkSmFoOUUvWStxMTBwQlFqRjVvU3JyWFVJVEtaeStm?= =?utf-8?B?ZDJobTZtZzVRSUZLYjlITzB5amNtMk1mai9DanJ1eGEyMjBJdUNod2hLNjNK?= =?utf-8?B?V2IxVEIrWWQ4K3RYbVhobVBLZ0tiTXBldnlJZnVkYUZYQkFWcm1MekJvZy92?= =?utf-8?B?UU1Wc1pxUFNIaEJvMlJyM3FtTzZzb2h6cmNVOUNybDN2M01KbjdHbUpkdm04?= =?utf-8?B?YklaNDNUQzN6UURKZFN4UkxVK0tJSElqUXBUT2h5UlpjQVczTTR6cGR5SWZQ?= =?utf-8?B?c3hFNXQ1aWVHMkh0S1h1MjlTeWNYTnVWSGlrY21mVkxqSzdhcmNkTTZadWo5?= =?utf-8?B?RzJxYlJhaHBhbllGUzlkSUlIcjdqbFMwVE1ZQUJrdUVxY3lvUVl4L05zZStl?= =?utf-8?B?MEVvM0Ewa3hHci9oMGFvTmJyZ0VYQm5UMUdhNmZGdmtZbm13SlMxTnJXZFlD?= =?utf-8?B?YXNXR05aeHcyamVyOUdvU1Q1WU1GQ3Y5MHJlVFpPWk9RR01kam03eEVCNVB5?= =?utf-8?B?bCtOSGsrL0xxdWJGbjZqREszc1Z3MFdySE42SmtlWE9YZFFLM1BLajZrUmZU?= =?utf-8?B?b3hKOUY3dVVtV2hiWEtKa2ZYcHpVS2l3Q21WU1cxdkJoZ2FYK0ZSaEw1SjZn?= =?utf-8?B?elJqUzQ0T2swdEttRWFYS2o1VDhMZnp3VUxmNnRMMDF1WllpVmFDcE5PVlRK?= =?utf-8?B?M2JuRDZ1cVdKcmdkdStvZ3lBZHE0NldDNUNwNEVrcnFCVVB0M0JuL0dEYjFE?= =?utf-8?B?WFQ1Q1hneDJWR2krWFlHNHhDd21GM29NK3I3VzdVNUU0Nm1wMDB2cGlpQ3pC?= =?utf-8?B?bXE3MllzY200TkpMN3puVnE5ZXB3S2dicEtwU0hoazYyRjdJRUlGYkF5SFhx?= =?utf-8?B?SlNrbHJCdjZRRHd0eXlRWWt4OXVWVE8vcDdmay9rcmU4TWJGVnhpQW9WNStC?= =?utf-8?B?Y1Rkb2NZVk5Eb2JJSDhBVTVXbVRnTGsxbStPV2NDNlNmM1QzWDlhTGxNUVVJ?= =?utf-8?B?UEhWd3lMb1NuMHJRSzV5OWdFQjRoOEdvdVcxVHZkUjF1bm13SmtWaGtXUTJP?= =?utf-8?B?cWt2RUxTVm1OUnRBM3pPK2d5OEVkNTd2dWE3Yml4TFhxdnRDcHV2UmN4Zkcz?= =?utf-8?B?elBGczkxNkZjWElRUVRFNnlheG4yNWxPMUQ4QWxPaGRBcFpOclJHQUVzRnFM?= =?utf-8?B?WFV0L2QyNUFZNGx5VFdiQ0RKYU9lMW9BQmlISk8yVnIyT2s3MnhRRDlYaTJ6?= =?utf-8?B?cnlONVdadXJYTlRYYWFwRWYrNWtObElwRDBVbkphQW9GelZoQ1JGTjMyc2FG?= =?utf-8?B?TGxobjRiY20rQ1B1RWFXaXVyWDh6L2c1REJBZHo2RlJzWStudHRjZXZBRkpM?= =?utf-8?B?Q0YrNURUYWxOa3RZWVM5bjZObmtQcm1oZFFkQk1sZ3RFUFVRWWk0SGs2eGZ2?= =?utf-8?B?YUR1YUVpbitVTlkrRmY4M2dUN3I5c1gvTU1JYUp3QjNlUWFHR2tPb2xnSSs3?= =?utf-8?B?MGg3UjFBQ3NWUDY5YVNxSHg3cm9ERkNadUtLQVp4VEFtNnRpamNRK2tTb2VM?= =?utf-8?B?L1dPVk1hckVLcUViQVR5QWt0UXUvNG5mSDE2c3JGSE11d2NJWXA4aWtremI1?= =?utf-8?B?SDh4RjF5Vmw3WTUvcVNqSnExeGZQaVFXaE5pdmptZmwwbU8xUjhManBPaUx1?= =?utf-8?B?MEZzUyswL095UDFzOUxkVkpCUGEyUko2R1orTGhVOTk3ME5WQk9SZWs5Vkc2?= =?utf-8?B?c293Q1pDcUlhMVNienVpUHY4b2dYMHRGNW5GMUQxMmFnNXNtWVUxdjZCcmo1?= =?utf-8?Q?qz51X5mkoQsmCSaLqZtbYNMlo?= Content-Type: text/plain; charset="utf-8" Content-ID: <5EFF2CB15AB32443878C456819EB1D7C@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eede0fae-8939-4948-0ac3-08da9fe967d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 18:03:24.3917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pZGCKcsHC5yBhBkXUdae9Na+6YHs8xEmBMJq0nw5HKMp69oWTn72ZHRQ4Xp06QU5IRMmsCiYbQbhzc7v0nwqzeBk6tRamDzuAeQknAOpt2A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6034 T24gMjIvMDkvMjAyMiAxNzowNSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBtZW1vcnlfdHlw ZV9jaGFuZ2VkKCkgaXMgY3VycmVudGx5IG9ubHkgaW1wbGVtZW50ZWQgZm9yIEludGVsIEVQVCwg YW5kDQo+IHJlc3VsdHMgaW4gdGhlIGludmFsaWRhdGlvbiBvZiBFTVQgYXR0cmlidXRlcyBvbiBh bGwgdGhlIGVudHJpZXMgaW4NCj4gdGhlIEVQVCBwYWdlIHRhYmxlcy4gIFN1Y2ggaW52YWxpZGF0 aW9uIGNhdXNlcyBFUFRfTUlTQ09ORklHIHZtZXhpdHMNCj4gd2hlbiB0aGUgZ3Vlc3QgdHJpZXMg dG8gYWNjZXNzIGFueSBnZm5zIGZvciB0aGUgZmlyc3QgdGltZSwgd2hpY2gNCj4gcmVzdWx0cyBp biB0aGUgcmVjYWxjdWxhdGlvbiBvZiB0aGUgRU1UIGZvciB0aGUgYWNjZXNzZWQgcGFnZS4gIFRo ZQ0KPiB2bWV4aXQgYW5kIHRoZSByZWNhbGN1bGF0aW9ucyBhcmUgZXhwZW5zaXZlLCBhbmQgYXMg c3VjaCBzaG91bGQgYmUNCj4gYXZvaWRlZCB3aGVuIHBvc3NpYmxlLg0KPg0KPiBSZW1vdmUgdGhl IGNhbGwgdG8gbWVtb3J5X3R5cGVfY2hhbmdlZCgpIGZyb20NCj4gWEVOX0RPTUNUTF9tZW1vcnlf bWFwcGluZzogdGhlcmUgYXJlIG5vIG1vZGlmaWNhdGlvbnMgb2YgdGhlDQo+IGlvbWVtX2NhcHMg cmFuZ2VzIGFueW1vcmUgdGhhdCBjb3VsZCBhbHRlciB0aGUgcmV0dXJuIG9mDQo+IGNhY2hlX2Zs dXNoX3Blcm1pdHRlZCgpIGZyb20gdGhhdCBkb21jdGwuDQo+DQo+IENhbGxzIHRvIG1lbW9yeV90 eXBlX2NoYW5nZWQoKSByZXN1bHRpbmcgZnJvbSBjaGFuZ2VzIHRvIHRoZSBkb21haW4NCj4gaW9t ZW1fY2FwcyBvciBpb3BvcnRfY2FwcyByYW5nZXMgYXJlIG9ubHkgcmVsZXZhbnQgZm9yIEVNVA0K PiBjYWxjdWxhdGlvbnMgaWYgdGhlIElPTU1VIGlzIG5vdCBlbmFibGVkLCBhbmQgdGhlIGNhbGwg aGFzIHJlc3VsdGVkIGluDQo+IGEgY2hhbmdlIHRvIHRoZSByZXR1cm4gdmFsdWUgb2YgY2FjaGVf Zmx1c2hfcGVybWl0dGVkKCkuDQoNClRoaXMsIGFuZCB0aGUgcGVyZiBwcm9ibGVtIENpdHJpeCBo YXZlIGZvdW5kLCBpcyBjYXVzZWQgYnkgYSBtb3JlDQpmdW5kYW1lbnRhbCBidWcgd2hpY2ggSSBp ZGVudGlmaWVkIGR1cmluZyBYU0EtNDAyLg0KDQpYZW4gaXMgd3JpdHRlbiB3aXRoIGFzc3VtcHRp b24gdGhhdCBjYWNoZWFiaWxpdHkgb3RoZXIgdGhhbiBXQiBpcw0KZGVwZW5kZW50IG9uIGhhdmlu ZyBkZXZpY2VzLsKgIFdoaWxlIHRoaXMgaXMgcGVyaGFwcyB0cnVlIG9mIGN1cnJlbnQNCmNvbmZp Z3VyYXRpb25zIGF2YWlsYWJsZSwgaXQgaXMgYSBsYXllcmluZyB2aW9sYXRpb24sIGFuZCB3aWxs IGNlYXNlDQpiZWluZyB0cnVlIGluIG9yZGVyIHRvIHN1cHBvcnQgZW5jcnlwdGVkIFJBTSAoYW5k IGJ5IGV4dGVuc2lvbiwNCmVuY3J5cHRlZCBWTXMpLg0KDQpBdCB0aGUgbW9tZW50LCB3ZSBrbm93 IHRoZSBJT01NVS1uZXNzIG9mIGEgZG9tYWluIHJpZ2h0IGZyb20gdGhlIG91dHNldCwNCmJ1dCB0 aGUgY2FjaGVhYmlsaXR5IHBlcm1pdHMgYXJlIGR5bmFtaWMsIGJhc2VkIG9uIHRoZSBub24tZW1w dHluZXNzIG9mDQp0aGUgZG9tYWluJ3MgZGV2aWNlIGxpc3QsIGlvcG9ydCBsaXN0LCBhbmQgdmFy aW91cyBvdGhlcnMuDQoNCkFsbCB0aGUgbWVtb3J5X3R5cGVfY2hhbmdlZCgpIGNhbGxzIGhlcmUg YXJlIHRvIGNvdmVyIHRoZSBmYWN0IHRoYXQgdGhlDQpvcmlnaW5hbCBkZXNpZ24gd2FzIGJ1Z2d5 IGJ5IG5vdCBoYXZpbmcgdGhlIGNhY2hlYWJpbGl0eS1uZXNzIHBhcnQgb2YNCmRvbWFpbiBjcmVh dGUgaW4gdGhlIGZpcnN0IHBsYWNlLg0KDQpUaGUgYXBwcm9wcmlhdGUgZml4LCBidXQgZGVmaW5p dGVseSA0LjE4IHdvcmsgYXQgdGhpcyBwb2ludCwgaXMgdG8gaGF2ZQ0KYSBuZXcgQ0RGIGZsYWcg d2hpY2ggcGVybWl0cyB0aGUgdXNlIG9mIG5vbi1XQiBjYWNoZWFiaWxpdHkuDQoNCkZvciB0ZXN0 aW5nIHB1cnBvc2VzIGFsb25lLCB0dXJuaW5nIGl0IG9uIG9uIGFuIG90aGVyd2lzZSAicGxhaW4g Vk0iIGlzDQp1c2VmdWwgKGl0cyBob3cgSSBhY3R1YWxseSBkZWJ1Z2dlZCBYU0EtNDAyLCBhbmQg dGhlIG9ubHkgc2FuZSB3YXkgdG8gZ28NCmFib3V0IGludmVzdGlnYXRpbmcgdGhlIE1UUlIgcGVy IGRpc2FzdGVycyBmb3IgVkdQVSBWTXNbMV0pLCBidXQgZm9yDQpyZWd1bGFyIHVzZWNhc2VzLCBp dCB3YW50cyBjcm9zcy1jaGVja2luZyB3aXRoIHRoZSBJT01NVSBmbGFnIChhbmQNCmVuY3J5cHRl ZCBWTSBmbGFnIGluIHRoZSBmdXR1cmUpLCBhbmQgZm9yIGFsbCBkeW5hbWljIGxpc3QgY2hlY2tz IHRvDQp0dXJuIGludG8gYSBzaW1wbGUgJ2QtPmNvbmZpZyAmIENERl9mdWxsX2NhY2hlYWJpbGl0 eScuDQoNClRoaXMgd2F5LCB3ZSBkZWxldGUgYWxsIGNhbGxzIHRvIG1lbW9yeV90eXBlX2NoYW5n ZWQoKSB3aGljaCBhcmUgdHJ5aW5nDQp0byBjb3ZlciB0aGUgdmFyaW91cyBkeW5hbWljIGxpc3Rz IGJlY29taW5nIGVtcHR5L25vbi1lbXB0eSwgYW5kIHdlDQpyZW1vdmUgc2V2ZXJhbCBvcmRlcmlu Zy1vZi1oeXBlcmNhbGxzIGJ1Z3Mgd2hlcmUgbm9uLWNhY2hlYWJsZSBtYXBwaW5ncw0KY2FuJ3Qg YWN0dWFsbHkgYmUgY3JlYXRlZCBvbiBhIFZNIGRlY2xhcmVkIHRvIGhhdmUgYW4gSU9NTVUgdW50 aWwgYQ0KZGV2aWNlIGhhcyBhY3R1YWxseSBiZWVuIGFzc2lnbmVkIHRvIHN0YXJ0IHdpdGguDQoN Cn5BbmRyZXcNCg0KWzFdIE1UUlIgaGFuZGxpbmcgaXMgYWxzbyBidWdneSB3aXRoIHJlZHVjZWQg Y2FjaGVhYmlsaXR5LCBjYXVzaW5nIHNvbWUNCmFyZWFzIG9mIFJBTSB0byBiZSB1c2VkIFVDOyBu b3RhYmx5IHRoZSBncmFudCB0YWJsZS7CoCBUaGlzIG1hbmlmZXN0cyBhcw0KUFYgZGV2aWNlIHBl cmYgYmVpbmcgd29yc2UgdGhhbiBxZW11LWVtdWxhdGVkIGRldmljZSBwZXJmLCBvbmx5IHdoZW4g YQ0KR1BVIGlzIGFkZGVkIHRvIGEgVk1bMl0uwqAgSW5zdGVhZCBvZiBmaXhpbmcgdGhpcyBwcm9w ZXJseSwgaXQgd2FzIGhhY2tlZA0KYXJvdW5kIGJ5IGZvcmNpbmcgSVBBVD0xIGZvciBYZW5oZWFw IHBhZ2VzLCB3aGljaCBvbmx5ICJmaXhlZCIgdGhlDQpwcm9ibGVtIG9uIEludGVsIChBTUQgaGFz IG5vIGVxdWl2YWxlbnQgbWVjaGFuaXNtKSwgYW5kIG5lZWRzIHJldmVydGluZw0KYW5kIGZpeGlu ZyBwcm9wZXJseSAoaS5lLiBnZXQgdGhlIHZNVFJSIGxheW91dCB3b3JraW5nIGNvcnJlY3RseSkg dG8NCnN1cHBvcnQgVk1zIHdpdGggZW5jcnlwdGVkIFJBTS4NCg0KWzJdIFRoZXJlJ3MgYSBzZWNv bmQgYnVnIHdpdGggbWVtb3J5X3R5cGVfY2hhbmdlZCgpIGluIHRoYXQgaXQgY2F1c2VzDQpkcmVh ZGZ1bCBzeXN0ZW0gcGVyZm9ybWFuY2UgZHVyaW5nIFZNIG1pZ3JhdGlvbiwgd2hpY2ggaXMgc29t ZXRoaW5nIHRvDQpkbyB3aXRoIHRoZSBpbnRlcmFjdGlvbiBvZiByZXN0b3Jpbmcgdk1UUlJzIGZv ciBhIFZNIHRoYXQgaGFzIGEgZGV2aWNlDQpidXQgaXNuJ3QgcnVubmluZyB5ZXQuwqAgVGhpcyBz dGlsbCBuZWVkcyBpbnZlc3RpZ2F0aW5nLCBhbmQgSSBzdXNwZWN0DQppdCdzIGdvdCBhIHNpbWls YXIgcm9vdCBjYXVzZS4NCg== From xen-devel-bounces@lists.xenproject.org Mon Sep 26 18:40:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 18:40:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412043.655194 (Exim 4.92) (envelope-from ) id 1oct2B-0003JA-LL; Mon, 26 Sep 2022 18:40:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412043.655194; Mon, 26 Sep 2022 18:40:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oct2B-0003J3-HM; Mon, 26 Sep 2022 18:40:51 +0000 Received: by outflank-mailman (input) for mailman id 412043; Mon, 26 Sep 2022 18:40:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oct27-0003IC-Dt for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 18:40:50 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb1b8daa-3dca-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 20:40:45 +0200 (CEST) Received: from zn.tnic (p200300ea9733e74d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e74d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6B1511EC059D; Mon, 26 Sep 2022 20:40:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb1b8daa-3dca-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664217640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UV5G03i0J4ZmYbbzPbEHCNnZgOVKlnCjwA4cScXyt1s=; b=CBzVjLPvs9Eewc7z3KLHoPORsEoDeJAqHqS/Kz75vg3KYyXNHMSTOMzaMeXc8RciECdqhh m7Ew6CupPbe/0o5sFSxIJUobbHC2pcffJ9X6idC0Md8NPm1QQ+VncGgDjYll43QHZBJ6DU doPafGRxQGkmnWuTGfFYcedmwt0iBQ0= Date: Mon, 26 Sep 2022 20:40:34 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init() Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-8-jgross@suse.com> On Thu, Sep 08, 2022 at 10:49:11AM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c > index 9609a0d235f8..956838bb4481 100644 > --- a/arch/x86/kernel/cpu/mtrr/mtrr.c > +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c > @@ -761,13 +761,10 @@ void __init mtrr_bp_init(void) > mtrr_enabled = get_mtrr_state(); > > if (mtrr_enabled) { > - mtrr_bp_pat_init(); > cache_generic |= CACHE_GENERIC_MTRR | > CACHE_GENERIC_PAT; > - } > - > - if (mtrr_cleanup(phys_addr)) { > - changed_by_mtrr_cleanup = 1; > + changed_by_mtrr_cleanup = > + mtrr_cleanup(phys_addr); Just let those lines stick out. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Sep 26 18:58:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 18:58:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412069.655248 (Exim 4.92) (envelope-from ) id 1octJU-0005Xy-KI; Mon, 26 Sep 2022 18:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412069.655248; Mon, 26 Sep 2022 18:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1octJU-0005Xr-HM; Mon, 26 Sep 2022 18:58:44 +0000 Received: by outflank-mailman (input) for mailman id 412069; Mon, 26 Sep 2022 18:58:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1octJT-0005Xh-FJ; Mon, 26 Sep 2022 18:58:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1octJT-0007Zt-Ch; Mon, 26 Sep 2022 18:58:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1octJS-0002pG-U5; Mon, 26 Sep 2022 18:58:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1octJS-0003dr-TY; Mon, 26 Sep 2022 18:58:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/fkAfI9o6O7DtRMNmsgEF9Zcf9Ru6dQ7CShnJOYTvqM=; b=JEDarkVRsCwVAJtTIBhUfGD558 /diM4TvHXsUDj3friz8Fb97yrSPXp9DxJP+WKuqNxdrGqa2OISiVaYpxVR1DDJai4u6hZ4kOOpeYB HwGnpI32C3LeNvyCa/52fyOewcZvHw1Vi4nnuFzmsA3n/5IzMW8T+Ro6premOval7QYw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173316: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bfd3e9945d1bc551ad11272c7fa752ff3d060149 X-Osstest-Versions-That: xen=3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 From: osstest service owner Date: Mon, 26 Sep 2022 18:58:42 +0000 flight 173316 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173316/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 173273 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173306 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173313 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173313 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173313 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173313 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173313 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173313 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173313 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173313 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173313 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173313 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173313 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173313 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen bfd3e9945d1bc551ad11272c7fa752ff3d060149 baseline version: xen 3007efadf74d6146a1c0ff1c2fbbae6b53ce7898 Last test of basis 173313 2022-09-26 01:51:56 Z 0 days Testing same since 173316 2022-09-26 13:36:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Daniel P. Smith Jan Beulich Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3007efadf7..bfd3e9945d bfd3e9945d1bc551ad11272c7fa752ff3d060149 -> master From xen-devel-bounces@lists.xenproject.org Mon Sep 26 20:10:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 20:10:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412085.655260 (Exim 4.92) (envelope-from ) id 1ocuQR-0004iZ-R0; Mon, 26 Sep 2022 20:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412085.655260; Mon, 26 Sep 2022 20:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocuQR-0004iS-Nl; Mon, 26 Sep 2022 20:09:59 +0000 Received: by outflank-mailman (input) for mailman id 412085; Mon, 26 Sep 2022 20:09:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocuQQ-0004iM-79 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 20:09:58 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e90fcba-3dd7-11ed-9374-c1cf23e5d27e; Mon, 26 Sep 2022 22:09:53 +0200 (CEST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28QHXxEn022227; Mon, 26 Sep 2022 20:09:22 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jssrwcspj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Sep 2022 20:09:22 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 28QK08YO019670; Mon, 26 Sep 2022 20:09:21 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jtpu9347t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Sep 2022 20:09:21 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MW4PR10MB6462.namprd10.prod.outlook.com (2603:10b6:303:213::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 20:09:19 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::2b18:d3d0:c806:401f]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::2b18:d3d0:c806:401f%7]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 20:09:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e90fcba-3dd7-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=hRnBlewc2lAS7P5loXEiLEevIB2bbEGGk7sp/0MSKeI=; b=l+WCs9nhS4anq0hS0c9uRXm6z/ro0un41I/cx1ejH0xx6scl1JRMVZwtPSMiKBlg7ZOU WKlP/9iO5pnPJE6EiQ44PVXimhokHjriKMwMwnJ4XOFAy5WbJ0LvTySJ9svo9J/RZ5Uc +be6DnlL+B3CD+F+ftC4CdyrTd+YXmW0zm8ve+H1Dc32WNTimFUHYYoQUH2k8HuQR7ft xzrnxUVM7Mw5wvi+EiUBEgdpfaOb7ejBvqR2cKNsUzdm1BKJUkzClB26iw1qnzxtl3gw TvPCpD86w4FIfa3VDqvXrLnTyeM5FbE+bM39MZCiRw1tzctVzDWiEminz7ZEx8Cd2/Xi cw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JqLDVqFCOlmTGkfb0rPdETFnx+4XRXSXSxA68i86ElvZjerV6rqeqcjMKuJHx2+9V0S6PLlfcmO4eJ3aw9O1wJ5g8sUGZAPPQ62cnsfjSHARLHLzfeuQ+MwsDUbJe1LWehdo1oaT4giXCv6GUetIniFSD1cSwkDcTOGJq/JFYDAAIkr5yw7jXou/DWZsLvFxM8ogDtKeygYAfksMV0tUmhwuss/Rbav5clodPwW93KdUuMdjAYzGc2w3HA7vkenVCXpsvJKdCI4+gNbOhFLc+Yn7TfkbCZ08QF+v723v8SIcRTCpyKcoYckAZRdycxREHXQcZpf832yY+AtgFkJvjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRnBlewc2lAS7P5loXEiLEevIB2bbEGGk7sp/0MSKeI=; b=EaLP/HttTQETQOF/dKczsursKRhTkjSKqd7x/euQq/5ABVgZrEai4UudN9qa6BnL+MqbxDKzqcgCT+vewaMTuN1H5rkdWuNfDGAmkMo2o04h2tm90HEQ68j8C7KoZbpr4apDTJgxuFFDwvcWRsbWxHGFt5j9PS9jOpuWD2YO4g4q/hOpZacOqyOBEB2Ib25SebuU0WRasgnsdU6j7dQf+piKOK9euN0gQSZQNy3Vgeb/h6MaEQ2Fww46sH0kAfaRp6W2TCn5z7s0vhtrUG8zfDBIg9uLsoCIYLs8RNYxT9w5qoSHzdtpyzDTym8i/M2Hj18Nlpe6eYVLpfw9UxcbWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hRnBlewc2lAS7P5loXEiLEevIB2bbEGGk7sp/0MSKeI=; b=k9Lcecn2hlHQrh+0mLHrQS7N1lc+4rL/zkZty7qVWd/FtR/7Y68KTETFHAteMN2ZRyF5beE4NKu7hQlYU9L531uVf08EuCLUEE+/AU1EtVvX+ET1d8VcDMxX3gwQZ3kJXpb4yH1w0Vz+jpRQ5poOQWn8BFI35Bb+5+qvG1SnZ74= Message-ID: Date: Mon, 26 Sep 2022 16:09:15 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-2-jgross@suse.com> From: Boris Ostrovsky In-Reply-To: <20220926141849.21805-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR08CA0021.namprd08.prod.outlook.com (2603:10b6:5:80::34) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|MW4PR10MB6462:EE_ X-MS-Office365-Filtering-Correlation-Id: a1511a3c-115f-41bd-7a1f-08da9ffafe96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s2fyhE9XxNme5YJFLySZtutoV16dBO1USjeIa3rQoDHdgoGXHRivzkdonCLFMSRjWTTua70qGjcHqbuHjeiq1bE9RFyXoOqNxZzsJqGy3Y/vdXNs89ulpiYpsM6C3RVQIpM2a9ZMGDBA/Kaa37EDII98J/Mi3UHhHqJELKJ2usalPEkTvMOuO/IFeABHQRx9nVdmvTtrvknD6rzQE8R4OwNytJExXpJELZFdRpskG7od6AHWKimDxvgsZnn/A6ZA1+PUcElh9T9uC6Cbd/PK4Ye6dYZOP+Q3XGhZNr5vloYNikLE5I+kiLBYRddw1SWAyyZfxuqZYUnhsc1CbXOz2tDd8/Qe7QzDXSSmBgrcAf0FvaccvECQlgKBvGMBt0cUw9GLC+RFIAdMivm7RGS93yAROXLAU+EBo6mFBgUIgOd3gsoaIFLDorVouwgiRCSzdkkVHCLjHObRv/MdpeQI2U6h2YyBQZjfAmKMEHfqftG9O3jn1AUtDgoxKMk+A+N1Zrz9fJzpT4FqN6V+csv0zvnM7J02mPAexwuBzXMNAqHTbDAMQKQXZxUeDVrXpOs6YoqosFiSzeg4ypusbtfV/MlUJyfNENo8xgZA72K6R25tBn+Ql0AnvxXoSeaRKITIk/9MN0n7jw4z9+La0secShN2xgNXfAmPG1EMLkrl11ehkNBju8mHexVZrAFGTAS84Y+oD2awz4cLQFwqrPztabzsH9uMEwIoRJxxbe2Vu752Gly+zXqdum+/nP6nehJb+BsPJGpAqYwt2OzHII9FvlZ633AlL/VBJGqWD6x0wsE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199015)(5660300002)(8936002)(8676002)(4326008)(66476007)(66556008)(53546011)(6506007)(66946007)(31686004)(38100700002)(478600001)(54906003)(186003)(2616005)(6486002)(316002)(36756003)(2906002)(44832011)(41300700001)(6512007)(6666004)(26005)(4744005)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3Npc0t4YXllbm5VUk82eUZlTHQ4bWFidXEyenQ3VUtXUnR4V2FvYUhUMWxn?= =?utf-8?B?SURYZ3lXTStFRlpxUmpYa29wT2xxemczUE1Gb0lXM0xzb1MyNSs5K3lVU1kv?= =?utf-8?B?Q3ZJb3N0bm84b3hzSnpnall4ZkFIYmNiUVdnQVIyeGdTa2hTQXlHRUxPSG8w?= =?utf-8?B?SytMZm9PR1MyWDZtelI0eDRmakswVG9IVWFuTCtPNGErWGdHWG4xdmI2RWFl?= =?utf-8?B?bkRtK3F1VHpseWdyVm5wQ3MyK0U5ZXVGbU5zMitxWElLVjludWZVbU5qejVC?= =?utf-8?B?LzIvaEhTekMwYmRzUVExUklONklBV3E3aStrSXRwQ2w1enN1TW4wYW5hdUNK?= =?utf-8?B?aForTGc4N0ZDZUMrSi9ocmt3RThIS1dJOFZtelFENGNHUkkrNDcrTmthY3NR?= =?utf-8?B?NVZVNXJMT0pnT3ZzSmdCejB6UVE3cG9Rd09NUWhqT1pwbThOdy9LRmFHbGxz?= =?utf-8?B?aitabTBxa2VuNzdPb25CdmJhR2s2UlNsbnNWM3BkTmNKNmlPMm1aU1pYUWpG?= =?utf-8?B?REdiMmJ3bEJEN0tSNkNVVm16S1haREhuMjBJNzRiaXREcEJNWndMVlVsSTg3?= =?utf-8?B?RWFvRlgxNndYK3VwUFVtRzFkNmRYR05SM0cxblFDbnRkdVQ2d2tIYkhZdUZN?= =?utf-8?B?Qk4yMVBOZ2h5WHNsaDFhVlZiMTNoOGpIZjJ4RGFCcjR2WWFFUGlvNmhmSk40?= =?utf-8?B?b3lvMjkvRG8xVVlXYlhzeVNlYzhraVRBOGVwRzFPb3VNNHN5QkxzSWp5WHA1?= =?utf-8?B?MWRTMmI3aTZnTGQvSlJXaFBaSjZjbUJOYzlHdmswZkxxR3B4NnJiaFNJVVRu?= =?utf-8?B?STM2bG9iQVdDQVBlKzFkVCs3RDc5Sk9JOVVmaGk3cWJSdmNSeHc5dWg5VGt0?= =?utf-8?B?ZlcxaHB2OUs3WHBFWHFIczNIWnBTc3BBT09Ka2lUbHZxUWl0ZHZSd1hqOXdS?= =?utf-8?B?bjE0allaMWFmL0Mzb3RkOFdJTVJkNnpET2Jqb1ZsMHRvYTZWeHM2YSt3bjdy?= =?utf-8?B?ODUxRzhTTmIyOVFwUDM0WEFoR1BqajRzMlFDSS9tRmkvNnFVbzNBNWZlcGY4?= =?utf-8?B?eGJ5SW00bnVMY2c3NlpJZU85bXE0WDl2cGRLaUtQS1hPNkZRNi9CYzdmREtm?= =?utf-8?B?dVFtdENkN2hxY0c1ZklBZyt2UVJMZ3hhNXpheEw4dG9sT0xQU2hjZTdEb1Jq?= =?utf-8?B?b01VSldJRlJRUmFZajVuamtmYlQrcFJLMzgvZDVMMWlDNUY5V0tVdWtEbXcz?= =?utf-8?B?bU9EU0h1OTVSVGRhVGczS0FjZjJiSmZGRnlGcnN0Z2plMDZnRFIvME9lTkFs?= =?utf-8?B?VVgzRjFINU16M3BiVTY3WDMxQyt6NFRwa2NibWxNd0RZdC9ZNGcyWU44dzdO?= =?utf-8?B?NTduWmZrL3dVYkxELzhRRWhzOW5GYm82d2REOFNxSnlzb2pFL08rMkNrL2RH?= =?utf-8?B?Wkd6RmVQTDZWa21OM3hBL3VhYWIyOVZWeVRvYm8vM1duSWJVYjRaTlFrMVdx?= =?utf-8?B?ckhaOTRwb1FUVmkxcHZpTE5vY0VjWmxBa3h2WURIVEovNlJYTjNFeGI2cWVa?= =?utf-8?B?TzN5SWFURnZPWVU2RVFZWlUrRE9YNllJVkdqNzlIQU5VQzBSci9jbWY5Yk1V?= =?utf-8?B?MWxkZGpJb3JDTFl4OFZDczZJc2V4Z1dSTy95QzRGWXhBMk9LVmtXak56TGZt?= =?utf-8?B?VllNdmc5VDFtdlI5aUUyZnRkQ0tlSHVjZE1vMS9keTNHV0VVVlBiY09KMU9Q?= =?utf-8?B?OXdpYlJxTHVqUFcya0QzNGtNUUhGb2RsSUlPQVZUMHZqZHprTEsvZTdlYld4?= =?utf-8?B?WWQ5cmF0bFI1NVhEMlI4ejVCdzhzZTlIbjlKcEV5WDg2cDlWNGsyQk9FdGVm?= =?utf-8?B?ZXRMTENtd0E5NURrUEJWUzk4TTVxVVZwa0F1Qk5NRDZoaTdpWFMwVU5RZjBp?= =?utf-8?B?L3pjc0IzZE4vRGE1UFY5WlIwcThISW41OWwwaHFXdWRpb0NRdUhWdDhNbmlq?= =?utf-8?B?YkhPYnpYNFVlUHEwcEpWbmt0OGFTaGJ4OWh5bFgzazlwWjQ5YzVTZER1R0c1?= =?utf-8?B?WWxKY3pGS0RVMVZFdXJMYzh4c0pEbGxhbUdXV04ramdpUlo2S0gvNXlZVEJ1?= =?utf-8?B?MlNoRFhwcUk0OXBDRVVtaDhPTUZJOFo4V24zL2RDR3U5NjRoUmxNTUZYR1ZX?= =?utf-8?B?U3c9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1511a3c-115f-41bd-7a1f-08da9ffafe96 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 20:09:19.0448 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FQbpNOpWCmxEqm2iYTIV6E5IbfQ6SR816+Fmax/tSThRv6TMC+3PhcSvb+4fQlU/LpULXgsoiaQ45/ne+YNErDxhnPJGqMCHNYFmyTEUeOg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6462 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-26_09,2022-09-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209260125 X-Proofpoint-ORIG-GUID: J-4FRXr1-B5beVWRpZTOUl-Z3TKOjLtg X-Proofpoint-GUID: J-4FRXr1-B5beVWRpZTOUl-Z3TKOjLtg On 9/26/22 10:18 AM, Juergen Gross wrote: > bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err) > { > if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) { > - if (is_amd_pmu_msr(msr)) { > - if (!xen_amd_pmu_emulate(msr, val, 1)) > - *val = native_read_msr_safe(msr, err); > - return true; > + if (!is_amd_pmu_msr(msr)) You should be able to move vendor check inside is__pmu_msr(). -boris > + return false; > + if (!xen_amd_pmu_emulate(msr, val, 1)) { > + *val = err ? native_read_msr_safe(msr, err) > + : native_read_msr(msr); > } > + return true; > } else { From xen-devel-bounces@lists.xenproject.org Mon Sep 26 21:11:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 21:11:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412099.655270 (Exim 4.92) (envelope-from ) id 1ocvO9-0003eG-D0; Mon, 26 Sep 2022 21:11:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412099.655270; Mon, 26 Sep 2022 21:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocvO9-0003e9-9w; Mon, 26 Sep 2022 21:11:41 +0000 Received: by outflank-mailman (input) for mailman id 412099; Mon, 26 Sep 2022 21:11:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocvO8-0003e3-08 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 21:11:40 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd29504a-3ddf-11ed-9648-05401a9f4f97; Mon, 26 Sep 2022 23:11:38 +0200 (CEST) Received: from zn.tnic (p200300ea9733e74d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e74d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 15B201EC026E; Mon, 26 Sep 2022 23:11:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd29504a-3ddf-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664226690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=O4LMN3S2OFxEuL98rqNj8vUSOAZXBDFs/bg9a/ub9fA=; b=o4RF8pFNgH5nnML9hM8RFzrcIG5JMloUgd20rtKM9fXBuE6dF57S+p/C5y9y7J0qRj2c0j v1FwO+5n9Q0EBALFCLkpQ9Teoaw84m5E/UWZ3O05GZUkTYo4HfOi856UZIqW5aX54olvan TCm5vkNRC8OUBdzCAR0eJ21WpIqdra4= Date: Mon, 26 Sep 2022 23:11:26 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-9-jgross@suse.com> On Thu, Sep 08, 2022 at 10:49:12AM +0200, Juergen Gross wrote: > -void set_mtrr_aps_delayed_init(void) > -{ > - if (!cache_generic) > - return; > - > - mtrr_aps_delayed_init = true; > -} > - Except that you've removed the accessors and made that bool global. Which is less pretty than it was before... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Sep 26 22:50:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 22:50:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412108.655293 (Exim 4.92) (envelope-from ) id 1ocwvi-0005rh-Ft; Mon, 26 Sep 2022 22:50:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412108.655293; Mon, 26 Sep 2022 22:50:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocwvi-0005ra-C0; Mon, 26 Sep 2022 22:50:26 +0000 Received: by outflank-mailman (input) for mailman id 412108; Mon, 26 Sep 2022 22:50:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocwvh-0005r0-2g for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 22:50:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a20dbcd-3ded-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 00:50:23 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97F8860FB8; Mon, 26 Sep 2022 22:50:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C58CC433D6; Mon, 26 Sep 2022 22:50:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a20dbcd-3ded-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664232621; bh=f8EOT+6lj8f9RgA8vK5kdML1Sa0vspbm95sB52x8MPk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lESM0fizcEbS0GBCHPRzOF/nIrOhLn45nQk0bWCAiNLyxL6KnDwdJaTvtkuX3qt/O bG2M8AMm/V0r6iVikJ+8OEbsrSa8/Q2VaCymYFg0HHwFVQZ4tZsle6RaD7y8VLHQqE pd2qHECb35NgjtN4mQWt7Vd794ewTRkJJKmIqMI/lGJABpq0L7IA7CvS2O0nphOhM4 6UXfpFFGFqxvSQjsrdMVYKniUZL6yvjv4YgCRrGjkcXghbhhUCrR6PPkfRxT8su0DZ /UXUOL0QATr2wk4BbhzLcAl9khGaxQKnAf+mjSdXLl1wCnf2D8Ug83/PLEi+NBIOHt F5D8LJc7NpAJg== Date: Mon, 26 Sep 2022 15:50:18 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size In-Reply-To: <20220926110423.26030-4-michal.orzel@amd.com> Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 26 Sep 2022, Michal Orzel wrote: > In the follow-up patch we will add new jobs using debug Xen builds. > Because the debug builds take more space and we might end up in > a situation when there is not enough free space (especially during > a static memory test that reserves some region in the middle), increase > RAM size for QEMU from 1GB to 2GB. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - new patch carved out from previous v1 [3/9] patch > --- > automation/scripts/qemu-smoke-arm64.sh | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index f803835779f4..dea26c6c0a8f 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -52,7 +52,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -smp 2 -display none \ > + -m 2048 -smp 2 -display none \ > -machine dumpdtb=binaries/virt-gicv2.dtb > > # XXX disable pl061 to avoid Linux crash > @@ -117,7 +117,7 @@ cd .. > > # ImageBuilder > echo 'MEMORY_START="0x40000000" > -MEMORY_END="0x80000000" > +MEMORY_END="0xC0000000" > > DEVICE_TREE="virt-gicv2.dtb" > XEN="xen" > @@ -158,7 +158,7 @@ timeout -k 1 240 \ > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -monitor none -serial stdio \ > + -m 2048 -monitor none -serial stdio \ > -smp 2 \ > -no-reboot \ > -device virtio-net-pci,netdev=n0 \ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 22:50:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 22:50:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412107.655282 (Exim 4.92) (envelope-from ) id 1ocwva-0005bK-8c; Mon, 26 Sep 2022 22:50:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412107.655282; Mon, 26 Sep 2022 22:50:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocwva-0005bD-5H; Mon, 26 Sep 2022 22:50:18 +0000 Received: by outflank-mailman (input) for mailman id 412107; Mon, 26 Sep 2022 22:50:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocwvY-0005b7-BI for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 22:50:16 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 950097bc-3ded-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 00:50:13 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DA79B81598; Mon, 26 Sep 2022 22:50:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D9D3C433D6; Mon, 26 Sep 2022 22:50:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 950097bc-3ded-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664232611; bh=NZH//ZhmyRzkqcR7Vfm/ILuF8is8Qf4IrYi4B2cbzuQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=k1k9sZ4z0Oz5HV9ynVKfbiXqxomR5qmVbq0DIPH7/plr+pXd0Q9x/5gTAg3DVt0og 2jpcUgc1cS4aZ5sRMLjNgAwLRIR1FabCJd+SWLwN3kvfeol3OwSIqwEcVwGJj3gpn9 aMf4i9acVJobjDzJXPmqZEJn9ofkq0VFdNVkk443kXcejx9NLbZ3pI1e6P5A+1YMNR 4b0Wbi1AUv+qEcwcISve9jL5c2CAQxKcgAd6ni2EhK4pQmP0dk8L/4KQs3lT9I4iBQ u/mdY12682RjN9vjct5ifrpKq2U7xTZO9MD4ezS8YhfssrZtD6go3jl9g3l0gmay/i s1HerrZ+m+u7A== Date: Mon, 26 Sep 2022 15:50:09 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container In-Reply-To: <20220926110423.26030-3-michal.orzel@amd.com> Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 26 Sep 2022, Michal Orzel wrote: > For arm64 we perform builds using debian and alpine containers. > We are missing the randconfig build jobs for the latter, so add them. > This way for each container we have 4 fundamental build jobs: > - defconfig non-debug/debug > - randconfig non-debug/debug > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - none > --- > automation/gitlab-ci/build.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index a39ed72aac6d..d931441b910a 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -566,6 +566,18 @@ alpine-3.12-gcc-debug-arm64: > variables: > CONTAINER: alpine:3.12-arm64v8 > > +alpine-3.12-gcc-arm64-randconfig: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + RANDCONFIG: y > + > +alpine-3.12-gcc-debug-arm64-randconfig: > + extends: .gcc-arm64-build-debug > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + RANDCONFIG: y > + > alpine-3.12-gcc-arm64-staticmem: > extends: .gcc-arm64-build > variables: > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 22:50:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 22:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412113.655303 (Exim 4.92) (envelope-from ) id 1ocww9-0006Vk-Ni; Mon, 26 Sep 2022 22:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412113.655303; Mon, 26 Sep 2022 22:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocww9-0006Vb-L5; Mon, 26 Sep 2022 22:50:53 +0000 Received: by outflank-mailman (input) for mailman id 412113; Mon, 26 Sep 2022 22:50:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocww8-0005b7-BC for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 22:50:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aacf0bc9-3ded-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 00:50:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABE2E60E06; Mon, 26 Sep 2022 22:50:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78F76C433D6; Mon, 26 Sep 2022 22:50:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aacf0bc9-3ded-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664232649; bh=K8ChHpUFnjXjB5frJd8/GeVJ+zkM+67jca2mQVqIhkY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fQpBYujyRLzDo8VgpBLr48wtKWJNf865vjvVabCzgn/+uPB6PdFCtbFeAfu96i1rK QY8vntx6i9Vdj52+oyLdWzC2yvBj2RidF2wk7yYIQ45W7DfafqxLe8keiwEB2abLND TkciDxTNAGbEA6WVF3nZZDC4aRbYVnXwGdkmemD+lwg4TTKadb4jeH/xD+4w29KMYx jNjmTZd+2JB63j3EAChYrPYAcBHnkJZsTiNmORkQMAjDvI/+nZYfgoYB2392zG6jDN r9H+XaSqkQHgxAGkE6RYy1IJ73zU3aEZzqT0JmOzqbV8t1KxbE8vMzWNFxczl2KKP3 da/m/SMQo/t2g== Date: Mon, 26 Sep 2022 15:50:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 04/10] automation: Add debug versions of Arm tests In-Reply-To: <20220926110423.26030-5-michal.orzel@amd.com> Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-5-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 26 Sep 2022, Michal Orzel wrote: > At the moment, all the tests are executed on non-debug Xen builds. > To improve the coverage (e.g. we might catch some asserts), add new > test jobs using debug Xen builds. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - carve out the RAM size change to a separate patch [v2 03/10] > --- > automation/gitlab-ci/build.yaml | 16 ++++++ > automation/gitlab-ci/test.yaml | 93 +++++++++++++++++++++++++++++++++ > 2 files changed, 109 insertions(+) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index d931441b910a..6ce92531f61f 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: > CONFIG_UNSUPPORTED=y > CONFIG_STATIC_MEMORY=y > > +alpine-3.12-gcc-debug-arm64-staticmem: > + extends: .gcc-arm64-build-debug > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > alpine-3.12-gcc-arm64-boot-cpupools: > extends: .gcc-arm64-build > variables: > @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: > EXTRA_XEN_CONFIG: | > CONFIG_BOOT_TIME_CPUPOOLS=y > > +alpine-3.12-gcc-debug-arm64-boot-cpupools: > + extends: .gcc-arm64-build-debug > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_BOOT_TIME_CPUPOOLS=y > + > ## Test artifacts common > > .test-jobs-artifact-common: > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 4f96e6e322de..1b51030c6175 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: > tags: > - arm64 > > +qemu-alpine-arm64-gcc-debug: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64 > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-alpine-x86_64-gcc: > extends: .test-jobs-common > variables: > @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-debug: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64 > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm64-gcc-staticmem: > extends: .test-jobs-common > variables: > @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-debug-staticmem: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64-staticmem > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm64-gcc-boot-cpupools: > extends: .test-jobs-common > variables: > @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-debug-boot-cpupools: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - alpine-3.12-gcc-debug-arm64-boot-cpupools > + - alpine-3.12-arm64-rootfs-export > + - kernel-5.19-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm32-gcc: > extends: .test-jobs-common > variables: > @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: > tags: > - arm64 > > +qemu-smoke-arm32-gcc-debug: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log > + needs: > + - debian-unstable-gcc-arm32-debug > + - qemu-system-aarch64-6.0.0-arm32-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-x86-64-gcc: > extends: .test-jobs-common > variables: > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 22:52:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 22:52:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412122.655315 (Exim 4.92) (envelope-from ) id 1ocwxw-0007IQ-3G; Mon, 26 Sep 2022 22:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412122.655315; Mon, 26 Sep 2022 22:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocwxw-0007IJ-0e; Mon, 26 Sep 2022 22:52:44 +0000 Received: by outflank-mailman (input) for mailman id 412122; Mon, 26 Sep 2022 22:52:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocwxu-0007ID-P7 for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 22:52:42 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecc90cca-3ded-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 00:52:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7603B614B9; Mon, 26 Sep 2022 22:52:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85BA4C433C1; Mon, 26 Sep 2022 22:52:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecc90cca-3ded-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664232760; bh=fPSz+eZ0UgnDmnf4P+rdq9P6v7OG2OJ2ZRH5P0e8sHE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=O9ZJuq3P8La+nNg42cELNEV8j5GLDMa7gaR9B54BPCyj+OR1QGRdxt5lEXLWFgzrQ omTj5ed7BgiGDWxqinVEjcCXO288HFMBOL//R/rEZWSmx4U0hiv7FiF7l3xcSbG/pI S+MMl+k3VasjLX4chNAz0vi1mZHXS+BIRcf0YnCD1udpinxRh3VrCd+0hIqCdCTcx9 WmzQ+/+P843aIZOQUE32HJLjrMYhRH3FkiKO2ladb3L0pNs0m/pDruxtsd4X84YHzh v0yTJg8oNhRXv72DBHA6AKVVcrEqDz/7eDZtIguEgLNj0WP/I+tOlSL31pkf+9gY0o hIYJq9PJp2HSA== Date: Mon, 26 Sep 2022 15:52:37 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stewart Hildebrand , xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder In-Reply-To: <495c6147-17ac-ab4e-27ec-1cab394c57c3@amd.com> Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-7-michal.orzel@amd.com> <2abd4de9-5382-3ca3-5d2e-81ddc79d3b95@stew.dk> <495c6147-17ac-ab4e-27ec-1cab394c57c3@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 26 Sep 2022, Michal Orzel wrote: > Hi Stewart, > > On 26/09/2022 16:46, Stewart Hildebrand wrote: > > > > > > On 9/26/22 07:04, Michal Orzel wrote: > >> Take an example from arm64 qemu test scripts and use ImageBuilder > >> to generate u-boot script automatically. Calculating the addresses > >> manually is quite error prone and also we will be able to benefit > >> from using ImageBuilder when adding domUs to this test in the future. > >> > >> Install and use u-boot from the debian package. > >> Modify the script so that binaries are loaded from u-boot via tftp. > >> Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always > >> set to pl011 node path. > >> > >> Signed-off-by: Michal Orzel > >> --- > >> Changes in v2: > >> - add explanation in commit msg why we remove dtuart path > >> --- > >> automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- > >> 1 file changed, 27 insertions(+), 30 deletions(-) > >> > >> diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh > >> index 530f3892fdd3..765facbe4d66 100755 > >> --- a/automation/scripts/qemu-smoke-arm32.sh > >> +++ b/automation/scripts/qemu-smoke-arm32.sh > >> @@ -4,7 +4,9 @@ set -ex > >> > >> export DEBIAN_FRONTENT=noninteractive > > > > While you are here, there's a typo. s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/ > > This is a good catch. Thanks! > It looks like all the Arm scripts use FRONTENT instead of FRONTEND. This is clearly incorrect. > I will need to fix all the occurrences as part of this cleanup series. For this specific patch, given that it is not changing DEBIAN_FRONTENT: Reviewed-by: Stefano Stabellini Please send a separate patch to address the DEBIAN_FRONTENT issue, and I think that should target 4.17 (so it should be the first patch of the series next time.) From xen-devel-bounces@lists.xenproject.org Mon Sep 26 22:55:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 22:55:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412132.655326 (Exim 4.92) (envelope-from ) id 1ocx0D-00081e-HX; Mon, 26 Sep 2022 22:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412132.655326; Mon, 26 Sep 2022 22:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocx0D-00081X-Dv; Mon, 26 Sep 2022 22:55:05 +0000 Received: by outflank-mailman (input) for mailman id 412132; Mon, 26 Sep 2022 22:55:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocx0B-00081R-Kz for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 22:55:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41127b23-3dee-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 00:55:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C68F8B81598; Mon, 26 Sep 2022 22:55:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC61CC433D7; Mon, 26 Sep 2022 22:54:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41127b23-3dee-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664232900; bh=2tUWJ1lbrbqMp/H6esk0YLWPfE+04rCnqz7dDPmLzWg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=o9LOcITiUC4dMkIBj7s0qNAAa1F9MGaxChxQsJ0RdrD+ztGRf2Kyg/ubx1dS4vhKh p0AUQJIwHpNyUFQwpqbAVSHu03F62w39NuPBJtaPV8mpYtuAkPsVFGENtrT6db5U66 fwD8t+b6iH/C/vlhRK2oiJMvsDgiB2QwJzpdIq6vCYBts9JYg44To6/8PZLBxo6pyV JUxLh94xWkBW6jK3jShnNAhN5xfVoLgUWnAcMaAFE6xgZuaYZOi3vYV6HcRlnijD8Q mEMc5L7X+Uj6EV4p28ASWjFqkOoOAZpC5vaAXIUWVLgj00oyRL67stPcgNBSMPa7aL OsopG4OJ8SgQQ== Date: Mon, 26 Sep 2022 15:54:58 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed In-Reply-To: <20220926110423.26030-2-michal.orzel@amd.com> Message-ID: References: <20220926110423.26030-1-michal.orzel@amd.com> <20220926110423.26030-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 26 Sep 2022, Michal Orzel wrote: > Currently, all the arm64 defconfig build jobs, regardless of the > container used, end up building Xen with the extra config options > specified in the main build script (e.g. CONFIG_EXPERT, > CONFIG_STATIC_MEMORY). Because these options are only needed for > specific test jobs, the current behavior of the CI is incorrect > as we add the extra options to all the defconfig builds. This means > that on arm64 there is not a single job performing proper defconfig build. > > To fix this issue, add custom build jobs each time there is a need for > building Xen with additional config options. Introduce EXTRA_XEN_CONFIG > variable to be used by these jobs to store the required options. This > variable will be then read by the main build script to modify the .config > file. This will also help users to understand what is needed to run specific > test. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini and committed to staging given Henry's previous ack. > --- > This patch is supposed to be merged for 4.17. The release manager agreed > on that. > > Changes in v2: > - replace [ with [[ to be consistent with other ifs in build script > --- > automation/gitlab-ci/build.yaml | 15 +++++++++++++++ > automation/gitlab-ci/test.yaml | 4 ++-- > automation/scripts/build | 8 ++------ > 3 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 720ce6e07ba0..a39ed72aac6d 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -566,6 +566,21 @@ alpine-3.12-gcc-debug-arm64: > variables: > CONTAINER: alpine:3.12-arm64v8 > > +alpine-3.12-gcc-arm64-staticmem: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > +alpine-3.12-gcc-arm64-boot-cpupools: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: alpine:3.12-arm64v8 > + EXTRA_XEN_CONFIG: | > + CONFIG_BOOT_TIME_CPUPOOLS=y > > ## Test artifacts common > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index d899b3bdbf7a..4f96e6e322de 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -88,7 +88,7 @@ qemu-smoke-arm64-gcc-staticmem: > script: > - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > needs: > - - alpine-3.12-gcc-arm64 > + - alpine-3.12-gcc-arm64-staticmem > - alpine-3.12-arm64-rootfs-export > - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > @@ -107,7 +107,7 @@ qemu-smoke-arm64-gcc-boot-cpupools: > script: > - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log > needs: > - - alpine-3.12-gcc-arm64 > + - alpine-3.12-gcc-arm64-boot-cpupools > - alpine-3.12-arm64-rootfs-export > - kernel-5.19-arm64-export > - qemu-system-aarch64-6.0.0-arm64-export > diff --git a/automation/scripts/build b/automation/scripts/build > index 2f15ab3198e6..bcfa6838f0bb 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -15,12 +15,8 @@ if [[ "${RANDCONFIG}" == "y" ]]; then > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > hypervisor_only="y" > else > - if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then > - echo " > -CONFIG_EXPERT=y > -CONFIG_UNSUPPORTED=y > -CONFIG_STATIC_MEMORY=y > -CONFIG_BOOT_TIME_CPUPOOLS=y" > xen/.config > + if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then > + echo "${EXTRA_XEN_CONFIG}" > xen/.config > make -j$(nproc) -C xen olddefconfig > else > make -j$(nproc) -C xen defconfig > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Sep 26 22:56:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 22:56:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412140.655336 (Exim 4.92) (envelope-from ) id 1ocx1j-0000Gf-Vu; Mon, 26 Sep 2022 22:56:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412140.655336; Mon, 26 Sep 2022 22:56:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocx1j-0000GY-Sy; Mon, 26 Sep 2022 22:56:39 +0000 Received: by outflank-mailman (input) for mailman id 412140; Mon, 26 Sep 2022 22:56:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocx1h-0000G5-Vv; Mon, 26 Sep 2022 22:56:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocx1h-0003Rc-SX; Mon, 26 Sep 2022 22:56:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocx1h-0002uI-Bu; Mon, 26 Sep 2022 22:56:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ocx1h-00007e-BR; Mon, 26 Sep 2022 22:56:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=h5OVyx5W0yGuUlQOPjAvUt8zctFpXqD32f3U35H2QjE=; b=e4VJRHKj8fV4AthzPXUIwaAlHM h4e2aLvhDkbvO961mbpP883c10qfWLcBp5Nhnl34fWXmkB04+3ye1QcdQ+jHjH29qgMtKM06BajnD qmZH449CyPA0NeSNL6pjTTZ/VEEyaFmRyJey60ff79MXlsbQhmOfREdpS3WgUo+ZG8s0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173318: all pass - PUSHED X-Osstest-Versions-This: ovmf=96f3efbd991db83c608909c1c861a77fe26982f1 X-Osstest-Versions-That: ovmf=d97ee3244d806d324a22ea530215a9f10d2b23e2 From: osstest service owner Date: Mon, 26 Sep 2022 22:56:37 +0000 flight 173318 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173318/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 96f3efbd991db83c608909c1c861a77fe26982f1 baseline version: ovmf d97ee3244d806d324a22ea530215a9f10d2b23e2 Last test of basis 173314 2022-09-26 07:13:14 Z 0 days Testing same since 173318 2022-09-26 20:40:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d97ee3244d..96f3efbd99 96f3efbd991db83c608909c1c861a77fe26982f1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Sep 26 23:54:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 26 Sep 2022 23:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412154.655351 (Exim 4.92) (envelope-from ) id 1ocxvZ-0006ju-8U; Mon, 26 Sep 2022 23:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412154.655351; Mon, 26 Sep 2022 23:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocxvZ-0006jn-5s; Mon, 26 Sep 2022 23:54:21 +0000 Received: by outflank-mailman (input) for mailman id 412154; Mon, 26 Sep 2022 23:54:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ocxvY-0006jc-2I for xen-devel@lists.xenproject.org; Mon, 26 Sep 2022 23:54:20 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8536f1c3-3df6-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 01:54:14 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 153C05C0186; Mon, 26 Sep 2022 19:54:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 26 Sep 2022 19:54:12 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 19:54:11 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8536f1c3-3df6-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664236452; x= 1664322852; bh=rI4Zzljhb9I8csRzwFT6lBUjwWRvAyKkyg0m0/7yD4I=; b=c ZngvjOdxUauV5s7GJOu7bY+PCnGYgShdqUnb4VZjf6A0R+WUjHFTcTnCOcQ01CGr 9sse9WDX2lbgCWAEdNaBShrY7wRisP1MpWs6YvMp/vOGIJxjHvhT9IcI5KbqsUwR zXFNQMQSQpGpQYvqVdqp8GFY9Zh4x6RqPXUezdkPiEgpz2+Eur5THB+54i+/InSS cl06pB4wZxL9Hv5F0CZhayfjJ3xVKUMsvsARUUpplGpfFDCLjc1PbYv11wySC1QH g6/05tOtGm1DxY9Zen1Qi+lVPhyBZpI5ioA1/Z+Uetsu1TrTNgUSjU7g323ZO2LA /VdAlDW1eV18dZKC6Ubxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664236452; x=1664322852; bh=rI4Zzljhb9I8csRzwFT6lBUjwWRv AyKkyg0m0/7yD4I=; b=X3UMD8kibhgCoWaKBg/4+KjHSxq5yhSBsk/a9B95e6/y YuO0Lq0UKDSB6JaLBtcQNX/UFliB7cx/kZVwpxG5211LfJc3kRBk/GDjOJ6U1PNk Bc0CLfbou64HEZdd5TFu+URCEvIPqoSR7khz/729qjrB/KxitqFIpYgphJERTr6q qbvxnrtMdlAjaQ8smKdAkZnkSJn1FiiWhsUigY5PV5fxzokTN1lB62GVCiRKqXRb XNziCqA715RMUXrxUGBC6LneN1DrDTNlaPhfcFX8Vid+sGVDWymr7NMxQcQf58I1 //seyaOvy+YXLja9q7wDotDFNkWqYLExMNBYMW0QRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepfdforghr tgiihihkohifshhkihdpucforghrvghkfdcuoehmrghrmhgrrhgvkhesihhnvhhishhisg hlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehvdeghfevhfeg tdeggefhgeejueelleehtedvteehueejudejkeegudfggeekhfenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhi shhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 27 Sep 2022 01:54:09 +0200 From: "Marczykowski, Marek" To: "Tian, Kevin" Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Message-ID: References: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rw6gy4PFkqsk85l7" Content-Disposition: inline In-Reply-To: --rw6gy4PFkqsk85l7 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Sep 2022 01:54:09 +0200 From: "Marczykowski, Marek" To: "Tian, Kevin" Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API On Fri, Sep 23, 2022 at 07:21:04AM +0000, Tian, Kevin wrote: > > From: Marek Marczykowski-G=C3=B3recki > > Sent: Saturday, September 17, 2022 10:51 AM > >=20 > > Re-use rmrr=3D parameter handling code to handle common device reserved > > memory. > >=20 > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > > > --- > > Changes in v3: > > - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR > > --- > > xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- > > 1 file changed, 119 insertions(+), 82 deletions(-) > >=20 > > diff --git a/xen/drivers/passthrough/vtd/dmar.c > > b/xen/drivers/passthrough/vtd/dmar.c > > index 367304c8739c..3df5f6b69719 100644 > > --- a/xen/drivers/passthrough/vtd/dmar.c > > +++ b/xen/drivers/passthrough/vtd/dmar.c > > @@ -861,111 +861,139 @@ static struct user_rmrr __initdata > > user_rmrrs[MAX_USER_RMRR]; > >=20 > > /* Macro for RMRR inclusive range formatting. */ > > #define ERMRRU_FMT "[%lx-%lx]" > > -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn > > +#define ERMRRU_ARG base_pfn, end_pfn > > + > > +static int __init add_one_user_rmrr(unsigned long base_pfn, > > + unsigned long end_pfn, > > + unsigned int dev_count, > > + uint32_t *sbdf); >=20 > Just move the function here then no need of a declaration. Ok. > >=20 > > static int __init add_user_rmrr(void) > > { > > + unsigned int i; > > + int ret; > > + > > + for ( i =3D 0; i < nr_rmrr; i++ ) > > + { > > + ret =3D add_one_user_rmrr(user_rmrrs[i].base_pfn, > > + user_rmrrs[i].end_pfn, > > + user_rmrrs[i].dev_count, > > + user_rmrrs[i].sbdf); > > + if ( ret < 0 ) > > + return ret; > > + } > > + return 0; > > +} > > + > > +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ >=20 > I'm not sure the point of 'ignoring'. If user specifies a wrong RMRR > range (overlap, mfn invalid, etc.) just return an error similar to > -ENOMEM. Ignoring a user-specified range implies that something > would potentially get broken hence better fail it early. That's the behaviour that was here before, I simply added a comment about it explicitly (previously it used 'continue' heavily, now it's a separate function so it's a return value). While I agree in principle, I don't think such change should be part of this patch. (...) > > @@ -1108,6 +1136,15 @@ static int __init cf_check parse_rmrr_param(const > > char *str) > > else > > end =3D start; > >=20 > > + if ( (end - start) >=3D MAX_USER_RMRR_PAGES ) > > + { > > + printk(XENLOG_ERR VTDPREFIX > > + "RMRR range "ERMRRU_FMT" exceeds "\ > > + __stringify(MAX_USER_RMRR_PAGES)" pages\n", > > + start, end); > > + return -E2BIG; > > + } > > + >=20 > why moving this error check out of add_one_user_rmrr()? I didn't > get why it's special from other checks there, e.g. having base>end... To allow internal callers bypass MAX_USER_RMRR_PAGES, and make it apply really only to user-provided ranges. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --rw6gy4PFkqsk85l7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMyO6EACgkQ24/THMrX 1yxiKgf/Z/789eaBVhyZTX683sbeRVuTAAJd0rDl0hGShSZaRHh8HJLDQmVFZpVC SBVDy6NVDT1dV+41RLVmGdkDhCip5jzR1PnczvRTPYo+tmoeR9ir6iNchEuGXMfj QVgoKkMYLwNQNQ6j7hezUe0Q+WV3dNl8yh8UAgSxjRSQ2Y5KywcE2ijMm6Uy5GvF sF9Cf3T5C43LObF3EHbMmciBjPzYVL7bPTf2I7te4DbU2eH6yfAgnFBjIjqFO6TX tJ2hpT9aUZfIls6isiOKxC14fqpXyr/Iboec0WcjsL5f+OKIr+fG7o9IWJ+37yI3 JUZgmMhGb5mcllih41bYom8NiS6kkg== =HDAI -----END PGP SIGNATURE----- --rw6gy4PFkqsk85l7-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 01:46:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 01:46:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412164.655363 (Exim 4.92) (envelope-from ) id 1oczfi-0000Qf-Ko; Tue, 27 Sep 2022 01:46:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412164.655363; Tue, 27 Sep 2022 01:46:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oczfi-0000QY-Gk; Tue, 27 Sep 2022 01:46:06 +0000 Received: by outflank-mailman (input) for mailman id 412164; Tue, 27 Sep 2022 01:46:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oczfg-0000QS-MG for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 01:46:04 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140049.outbound.protection.outlook.com [40.107.14.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2354321a-3e06-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 03:46:00 +0200 (CEST) Received: from AM5P194CA0017.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::27) by DBAPR08MB5558.eurprd08.prod.outlook.com (2603:10a6:10:1b3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 01:45:58 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::ae) by AM5P194CA0017.outlook.office365.com (2603:10a6:203:8f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Tue, 27 Sep 2022 01:45:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 01:45:58 +0000 Received: ("Tessian outbound 3c27ae03f5ec:v124"); Tue, 27 Sep 2022 01:45:57 +0000 Received: from efe72351294a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3EE40F3E-6F28-49A1-81C9-98CBEE5DF170.1; Tue, 27 Sep 2022 01:45:52 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id efe72351294a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 01:45:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GVXPR08MB7872.eurprd08.prod.outlook.com (2603:10a6:150:16::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 01:45:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 01:45:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2354321a-3e06-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FzhDMaqmYkec3KtXxG62x5eOD2c1YcVzihKmITLtFA5oQ50CL99wQ6TGN9tee+eDZ3TqQEP2/VFY1G/cX6abHWVYoV3QeB9MjbLXrd3ncqtBVk4ZNNhf9vfpXplq2LJpbKlbohN8RYgfBEJPBu7rhY0Q/QDZJiVyTkFArLZ4+qIQlzglMCm36KL+Kp9lw30iEsH3kRXIaRgaWAHlSIS95C7te8831XGUnvc67RP+C7zTTaYiXdvt0Cn3eI97qUZd0lTpf/zzXa3mZRd4KBwf8IVgbAlGJUyf84Fww7sy+1Nr41MwZ3wSL8cWcOP7nZQv/kBFFZ2W3fsgujVWQBhNAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1jhMw68qTGiVfUuYk86XxcYXY6cZhVZIKwaFt5Cmo/Y=; b=ONnOC81dpO0WKub5VnyvWP4LmH5B90PXGtnsmqe4fJBYhb4SC1lKZz/TAaHbXL3Gcj6vh+roZoOxVF7AYHhM4ln9A2VqoHJzZkzKDDepOnCEXKK+YVeh4h/YhGyyusdbMq34B9V9LHBVuBOD7MfQLNck7QIbOkpG1iNwFH0Z5xG/9hONmj0PiHXxsUin7W6ziI7VB4X3WE7dVihwMBriNROj3vdry7YP08hbaCG089HpFKjYdfzcWTq1PdPSgDjggOb3FoW5qAO4MVXCZOP/4gau14AT+VwmpuyruvkskaqYO6wUUgaAps0SFh6iYxuUw2qejFt6oxQCIw2zg0ZGQA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1jhMw68qTGiVfUuYk86XxcYXY6cZhVZIKwaFt5Cmo/Y=; b=En/DRlTzyglQF/CCkku9pVCCD3gamBFXBWC41cZ4TXrFkJmYOKRkUmjljR7EOa+ib7KN9mAAzIH2fVpfgGntEbpnis22lpFlVY8L6C1xWh4Zg1mwiIAiX+c7GHdWF95MGFB753ua566SY4rpNAne022OcnHW3Zjo7bN8GEBh4UQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1uaw78JbcVzDLiD8B1eXWbLTCynt4Wx8mw5kSqwFHhZMHcPt6YVUHbz8Rs/nNgpcD5+ybmImfVb5sqyNFOL/38ZeA5K+yGfWzoQdqRGME0zaS4yQgXURruC85gXjR5JwHbY7niXqCE7WK22Y+37tUxYElGMculsfEsqpZ2uzjSV9caIFJVUdYSd9KQTULoPu23X14EaJ3qlHJiAnOSF5718401DanqFBZPsdwWD4gITjW20lpUHAIyV7G06kmu/9GiMEpVPCExuARXPOwOl30kIcYY9wZXGCjU5y5Csh3X6Gv0BNcsBauG/t1n2TL5rnIadOtXPCV43Pg/VCadoJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1jhMw68qTGiVfUuYk86XxcYXY6cZhVZIKwaFt5Cmo/Y=; b=APRI6pdQ6Cu3WjednTzf+r+c2tkDeH45LKUX8LdGdM7Av2OLVU/3Qkva11pxdiWS/WGlrASESMF9oz/j9ToushKaJeUzID9cw3PTHHbgxadd117hjM6g/s9yGPXuSy9lO3zbFxe73E4k0Ie8t9UWC/ccfBXZInEEnd60pEYwPxh/o3bfl1YmSx8vRUJR6TEyPmkX82qVWNgcrDopYuh7b0Eef2vRTIbkWzXbdGiErEdqYaVK2jeNBk/olN00HPHE+ExzHToWJZeoQN9qBQuScQJIww3AQ6ZPuzNPwOL5vEa8JbJQ5UwUFPLwymuodWZVsxPXLfY/Hnodn1sW7uTEag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1jhMw68qTGiVfUuYk86XxcYXY6cZhVZIKwaFt5Cmo/Y=; b=En/DRlTzyglQF/CCkku9pVCCD3gamBFXBWC41cZ4TXrFkJmYOKRkUmjljR7EOa+ib7KN9mAAzIH2fVpfgGntEbpnis22lpFlVY8L6C1xWh4Zg1mwiIAiX+c7GHdWF95MGFB753ua566SY4rpNAne022OcnHW3Zjo7bN8GEBh4UQ= From: Henry Wang To: Andrew Cooper , Jan Beulich CC: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Xen-devel Subject: RE: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Topic: [PATCH] drivers/char: Fix build when CET-IBT is enabled Thread-Index: AQHY0ZgHSdurloJVeEibjbWpif9Ypq3xog2AgAAtHwCAALLXUA== Date: Tue, 27 Sep 2022 01:45:49 +0000 Message-ID: References: <20220926110547.21287-1-andrew.cooper3@citrix.com> <838577ad-dc00-d440-ce96-56a85ff7cb83@citrix.com> In-Reply-To: <838577ad-dc00-d440-ce96-56a85ff7cb83@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 497C27302E406846B760B9B6B8B6E83C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GVXPR08MB7872:EE_|AM7EUR03FT023:EE_|DBAPR08MB5558:EE_ X-MS-Office365-Filtering-Correlation-Id: 11fb90d4-5a03-4b6f-ff32-08daa02a0664 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9gthOIguchYbuqrJSXhyQezuM5Fb6Lm2+8O/fZFWDjVHNRmEZGQTExzgABfuPBFD00fSFwtdPjrXDFxbi71wfsD20HccKMWK+YaGJ5fymfS7KWifXs6xrjlyE9ta8pT4CZizrDhYN9ScN5RZMDRvQu/nYt7cFF1aZ9N3X566qUZpI/MY4Jw+nmhfEHF8gm6eQ44D3QHOvxMOxug6X1xXqMp753Pd+nKWdyJGL42kdcsglPXKubKlpDxgVho78KG0SStOLe1BRosjQ7zmk9gQx12Fgg7agHc5KZkdf7nnsy7gKYr36IqtK48Gn6uZ+J/R3TlnbjplTmG1tl60kkpTme+XPpI3rRvSql4spUFi6z8v6/S5M74u+D9xbA0/JYzlKsJMSEiV6EGmxxWHgf4VlplVdXmxOZOz2QHuA8P4H3cZ7cTUoD0X1yJDOOjHVXcbn2yjRhLwJ8resgpum1HRHdBM8++ISWsSx1AkKrrIPgUiA6qtfwT/aRzx8m6Fi1PN+173eV4TpgmDQ0hfVN7AFIpnjTpHtuAndZI3IdAb1T4WHpZEFAj4WaMLE+5ovg9gCW+tfOu7VM54rtj058a1itzj0cRjyA8Q/mrQvB/9nzNGzq/V0A1XEP/MsRZb68sEojRHrG6Gyv39tJV54TunYlrqy3Ux7xnSaXLSP9wKz8YjOm05vZXVqdaeA95L2A2kCAWjsWMdTGBCQH4cLoNKgi2np7e3h/+L04mw1c1uwOSxdq5lZ9jDfbT3w96TAY6whDjaBt10BaOWrfvrb8yrHd9dkQzM7dZGS+meUpaViQE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199015)(83380400001)(55016003)(110136005)(86362001)(38100700002)(33656002)(52536014)(9686003)(76116006)(66476007)(38070700005)(66556008)(4744005)(2906002)(64756008)(8936002)(122000001)(66946007)(5660300002)(4326008)(8676002)(66446008)(6506007)(316002)(26005)(54906003)(7696005)(53546011)(186003)(71200400001)(478600001)(41300700001)(966005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7872 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57bbab1e-6d91-4134-1eb8-08daa02a0153 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kuy9r9jpjtmq0aWkb8FRtY4o/0v6mE7XTtMF0dq2kBBkMw7w+lilEMZ4vYKs0vBFdIL5cyx7FRDtYhXCITMV/cdUxvwyA2cChEuyL4B3CpUsiyt3wcF9wClQ41cfAFOr5Ip+kTQ3VUI7AQx7usokqChO/GNsfycVSYl7NrlhZFaPOkNvsT3IhRAXhObszwdN0y1i/rBSFahK5kju6TBsfQRQh5XnW9ok/7avMIflaFE3jFQyplcJT0MGhvoggpSrB/5g8DU6+MtXkqEYcc1/RIPXk6eTjBz53dtrr0YPDt8WLgzbG9oepofCTxuZSv1BaLj/8OBPJ3r/5+3DTRViFOu0zyBhtQOEcYo0S58iYMhBojv5vINp0wfaFthb/NNozck0YC8MPzU9pKKJsfDCiwc+RpGsGLOI0Fu6s45yD90SLmB44KybrA9DKsFaiccI46aQnzgqT4kIB0MuhtkB2H5m0fAILWQ+bSiI6eWb1SctHTrUDZWEAlzaDgrl+yDiyFyXYi1IMuABGFAKCmGRrUUkjk1HP4uLLKNLMRjTbzRcw+bMJOglxSh1NcxJqMeK8GTM/xyMC4Sfow5HXYtzRzGp0hGdsV0yuE6YazUDqXa4caEo+fn6RIiSY6YtGiVDGDsrRbuTELjaRUON43H6dhV02Epj/zQ2maln0JYD62lroQHdtXMpB/ygeDUdC4b08r7DD24QzInhoTPqKPo0oaNtqtzW65UeXbtxfGi54Yuw/xQjdcVEWZaaIyR/MYP/ojJNllEWR5uicE/v7CWyk6eCyK49pfal12D9FxT9N6c= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(52536014)(2906002)(5660300002)(4744005)(8936002)(478600001)(81166007)(356005)(40460700003)(41300700001)(33656002)(82310400005)(47076005)(6506007)(7696005)(82740400003)(70586007)(966005)(4326008)(53546011)(8676002)(70206006)(55016003)(40480700001)(26005)(54906003)(110136005)(9686003)(86362001)(83380400001)(336012)(36860700001)(316002)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 01:45:58.2074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11fb90d4-5a03-4b6f-ff32-08daa02a0664 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5558 SGkgSmFuIGFuZCBBbmRyZXcsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJv bTogQW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU3ViamVjdDog UmU6IFtQQVRDSF0gZHJpdmVycy9jaGFyOiBGaXggYnVpbGQgd2hlbiBDRVQtSUJUIGlzIGVuYWJs ZWQNCj4gDQo+IE9uIDI2LzA5LzIwMjIgMTM6MjIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+IE9u IDI2LjA5LjIwMjIgMTM6MDUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+ID4+IGh0dHBzOi8vZ2l0 bGFiLmNvbS94ZW4tcHJvamVjdC94ZW4vLS9qb2JzLzMwODMwNjg5NTAjTDE3NjMNCj4gPj4NCj4g Pj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4NCj4gPj4gRml4ZXM6IDAyMmU0MGVkZDRkYyAoImRyaXZlcnMvY2hhcjogYWxsb3cgdXNpbmcg Ym90aCBkYmdwPXhoY2kgYW5kDQo+IGRiZ3A9ZWhjaSIpDQo+ID4gUmV2aWV3ZWQtYnk6IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IFRoYW5rcy4NCg0KSSB0aGluayB0aGlz IHBhdGNoIHNob3VsZCBkZWZpbml0ZWx5IGJlIG1lcmdlZCBpbiA0LjE3LCBkbyB5b3UgYWdyZWU/ DQoNCkFueXdheSwgaW4gY2FzZSB0aGUgcmVsZWFzZSBhY2sgdGFnIGlzIG5lZWRlZDoNClJlbGVh c2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdh cmRzLA0KSGVucnkNCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 27 01:49:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 01:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412169.655373 (Exim 4.92) (envelope-from ) id 1oczjQ-00010N-2f; Tue, 27 Sep 2022 01:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412169.655373; Tue, 27 Sep 2022 01:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oczjQ-00010G-07; Tue, 27 Sep 2022 01:49:56 +0000 Received: by outflank-mailman (input) for mailman id 412169; Tue, 27 Sep 2022 01:49:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oczjP-00010A-1v for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 01:49:55 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10081.outbound.protection.outlook.com [40.107.1.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae31be35-3e06-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 03:49:53 +0200 (CEST) Received: from AS8PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:20b:310::20) by AS8PR08MB8223.eurprd08.prod.outlook.com (2603:10a6:20b:52b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 01:49:51 +0000 Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::fd) by AS8PR04CA0015.outlook.office365.com (2603:10a6:20b:310::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Tue, 27 Sep 2022 01:49:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 01:49:51 +0000 Received: ("Tessian outbound 8ec96648b960:v124"); Tue, 27 Sep 2022 01:49:50 +0000 Received: from f9298ada8ef8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A9A4E8E-43D3-4D83-9A71-D3F081C97B00.1; Tue, 27 Sep 2022 01:49:45 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f9298ada8ef8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 01:49:45 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GVXPR08MB7872.eurprd08.prod.outlook.com (2603:10a6:150:16::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 01:49:43 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 01:49:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae31be35-3e06-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NWC2olTO/iyM7lWUWz4w3PC1GaGJ/HEXPBWSyCieavFP/AKcG5YlKuY4BDNtjLUOELvGzfGhbHr2NIjgLZhSN4LAlwywfU1Iv3Y4f1+/gxxNaEdgc1W4+icUTo4PFpzhp2pB6CaLpBSuRLQIisLWnqnHebIQAKxNSVitBWMeqXIe2Uu7Mbse8AZyA49kWx37VZQB/UspfBoKpLPhnxk5Ru++lR2jjxyORjUAfChlO0ro7+MXn1zNsRbotKcFli5ANpmTjmvT1PBAfYyO9HGR/ME4I+lxX+fGof8+gpZ2ULgcFFKlk/JX/CwSiRHfrVPiMGPvYteG3+IRnOe+Ydhpqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3wjqcNDCIcJvgOZcpLcs6HABF3QSqYH4aT6aCpftUc=; b=PMxgB7jOLAd2h9dTGUehSLzS0AFD6hNSSztKxiNOwdFgEhAq9S+QDJ86gPucCcpr+EO+Pc/7D2/WHG7haXtGPjNBFgyOQrlDaqYKDm4BKTS67MPfDG0dL+sE8Y2tKL3K6PVYvRkkugaptI67m8I7aRGkZIPCYrax7KHUcDjluho6EHQ4ujd69qHYduKi5GE7GVoZ/b+okMgO+1ZXAsuvPNnyrivjKKn5F12OEO51pJIYrkOY6Q7jPWSxVOV3KMW2rY20ftmdGXLRJ3ev8tys0zhcqoGyOcCGIU7dHcay5fthGcFWoqjj1HqRPgyCZ76sAbsxq5chlR0PIc7Q7blKeQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3wjqcNDCIcJvgOZcpLcs6HABF3QSqYH4aT6aCpftUc=; b=pQnoU92EQQjhZNvC/V2q3sdRNIzbkFeYma9iCqnHkv63CA2pKV/wMZ6cOloD9iJepLSeZKL7l2gDOEFdwkQcBEg4k4aIsOrv/4SrFvbOgMd+BfoNPvVpwrLWgkufrBuWxh/4VXm4mZH84hfxU3OWfAhfYM0UD4rlQpPkr7WrgHY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4jhjOHhJcARcD6MhnnX+X30v4BmzKBzgViKU3rDEsHY75nCW1QA8Xr5UrtmQwJwc9RwFBCDoFMhYCgBhFecMFmz2b3UCTr0wI6kPlgqkZmCoAY7UXC+kB2UMidT0pH44VIWqEJGCGl/rELEKUC8dNGIpJhWKed8uQfgT5bD9dI2LtSANVyjLsYCYqvMXT9fVr3Ct4dTEmk84il6BWCQ0SBg8BwKyKZ4q6UGmD7BkLCm1g7beVJS0PeW6GsSQHMrh1lKQhOXaEhTw3esHQS05x9HZw54aTlA9k1ZeCfVDKrtRe8gyoe/KvJS+8zNd409gU71gDR1pokcA07RnH8JoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3wjqcNDCIcJvgOZcpLcs6HABF3QSqYH4aT6aCpftUc=; b=epKsWuoofdnJ4bsiGeUzDKVBdICGQw/NkHaVEx1Qs0FFMXlWF8PGTP6BKu+ibZj33zN3hAD6YGVPpViha/qvMwrXtXDiKLzjzk2ffPuV8QZ3DYtkfrqe7/Dtv1Dr24Q0+IFTwm2nR4yo2SWKoWlIyk38LY2s56Uc3U7ICZwcQ7YVYbpfPpWVxhg3775Iv4AFW1L4vXdaVdSqQ4CKgJGJB6TwTtGbRioZlfSMBQdpPrtkQL0IIqmqHnSXtB5kDmEgZGUGEgJCj9AHQ/8lvOm4gw/LSmYCSHC/htKcOc4bi4r06wTYhnFx8XM2fnGXGIXkF1UAACguJdmFVi9kjDnabQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3wjqcNDCIcJvgOZcpLcs6HABF3QSqYH4aT6aCpftUc=; b=pQnoU92EQQjhZNvC/V2q3sdRNIzbkFeYma9iCqnHkv63CA2pKV/wMZ6cOloD9iJepLSeZKL7l2gDOEFdwkQcBEg4k4aIsOrv/4SrFvbOgMd+BfoNPvVpwrLWgkufrBuWxh/4VXm4mZH84hfxU3OWfAhfYM0UD4rlQpPkr7WrgHY= From: Henry Wang To: Andrew Cooper , Xen-devel CC: Doug Goldstein , Stefano Stabellini Subject: RE: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Thread-Topic: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Thread-Index: AQHY0ahd1Yel1Id/NEGTK5JNVyLiZa3ygvuw Date: Tue, 27 Sep 2022 01:49:42 +0000 Message-ID: References: <20220926130213.28274-1-andrew.cooper3@citrix.com> In-Reply-To: <20220926130213.28274-1-andrew.cooper3@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 39DB677A3199D944B37E1F3AE36FC184.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GVXPR08MB7872:EE_|VE1EUR03FT025:EE_|AS8PR08MB8223:EE_ X-MS-Office365-Filtering-Correlation-Id: cdc68ce2-ec2f-44d9-9e47-08daa02a915d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1oPbBrW6s4TsXuULldVFTCB0+QvVu/YRe6XAw+WsY0I0XjmJKMsh3wSaPVtlbfrNhnQxVmLNnQVaHO9eJGwcmwbBo+2ylDKMhxsg6yMahN3+5S81JJtKPaD2ExjGAoYv/LDcfanuXoNqQufEzPmfFSrQh6M3Y9z5+JnBdjoTKq+qMWEOGpM+P6joPO4Fb4WmI4CxtvueK3SsRqflAOCWJEyW5k8jtXgArXmcMGXRM5HYa/osWi6TQFbvhrqIKc3RI/kXajip4rAHpq8qlv9too04LECgRObHRCNVjD5y4tUm1sGtbre8Hsahk8mfzbPK6m8kfl4iuvdm+Uvx8AH+PmLKtpbpZRBaafI51z8JEGOWqA8dswYQEXdZy/YIIBDpT42ypWi4jXWyH8yhyrQSZmW5DpqxnsINugRX/5tAOezL8g/x5U6PoENX+8s9IvyMWldK12SIwZJEpeUWyT13VEQcMwuCkxCmShPW29Ia4QKxk1EbibgVcdjgjmjF4qxBD0fbnls+C443huzM+v0ilcP1MICwwjtR5FMCtdH7eQ0Ab+6ldfi2DTT/V5XW/nWWRXFtXxPDgf6MgtNdmKiQwXWjMnACe7Cj/dY5R1HVPke98JEBdkqi06fkGm440lZdPnyrjpNQdxW4JyJXJr8OQD86k897jzHzdFT4wUaJXgMEd1pyvTKvWi5iypW1Sw5GWYbtPSGWg1rvDGmnyg93iaK8z4Rq5oHTSCFdD7aYG8WapGoUUlgkwnEbXimadChz3fFKwjlM2BDMkf94OYLom5HAGk7oMuqpjCASJks+v/w= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199015)(83380400001)(55016003)(110136005)(86362001)(38100700002)(33656002)(52536014)(9686003)(76116006)(66476007)(38070700005)(66556008)(2906002)(64756008)(8936002)(122000001)(66946007)(5660300002)(4326008)(8676002)(66446008)(6506007)(316002)(26005)(54906003)(7696005)(186003)(71200400001)(478600001)(41300700001)(966005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7872 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 73082b8d-1690-4017-45ab-08daa02a8c4f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uJjy1kJssBZncingO19caHZJVNO90T1n99xXyl0hdF5Tq4/e5poKIaCGbdgJJotcR0s2AOfF8PO0+8Qs6aqRS9aT7DlcIJyPH/YeIA8aPo8QrJU2FkqoxqwyicJsoGKpR8nkRL1y5dGtEEOYX/OoGCN59ZfVRxL/vivdGFW5vLUXsypu6xe9fIK+sHiQCn8hjGokLnvg/6obyyWqioCb8lkY6FnacRpznU/yhYg9Sx9iz/2cu2U7TWY3hRkPvFwcBLQ4D9Tezq8iX8Mkph/q9jdLeaDMnmEVqWn8Mm0sDzpVJ7oS7Wua7nqXMvYLRCSSoi7z1zDDP8FViRfzElczG4BFLb4L/+F1lECqMZxxVwR6+4YYAiz9c7igm83QvLbkMgthXgzRjy6y19FShb+p6CsncSZxzMIZ6KWaD21720RXC/3IN72b99odZV88TAKsPy6yH31hBRLaMi7dkQgDq6msy4lZ4z+xSAyXr35cs/gNtL3ktWUouccFkOYYleL80+7/zl+82mQTsMtcnqMBeEzeL0e5VlsGDj/9VjzRrSIeJzdjzlqRpjyTqUW2bAOsykZpwiQrfDeNshx1x4PkpEL47bxwLNttzYZtBMVFGFKxEyiPJXl+yYhZ2bMEbNNXhTIbmZ+Sax1iMQBV/FMruwtCpfhS9mSEUUWj27zZMtFf944XVNCb8b8a6imqztHlpXS6kMaXaYV/ZZ+vcmRKdYkDERu4P48zHXhrb2kzVzEuhVWVEhupXUGzdQGX6xfJcPMYFAzmB141eqgT2hggrJyc8Rzp5OnnCWm0ZN7Hk5A= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(52536014)(8936002)(33656002)(70586007)(70206006)(966005)(478600001)(8676002)(4326008)(107886003)(41300700001)(36860700001)(40460700003)(110136005)(54906003)(316002)(55016003)(40480700001)(6506007)(7696005)(82310400005)(86362001)(81166007)(26005)(9686003)(83380400001)(2906002)(186003)(47076005)(82740400003)(336012)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 01:49:51.3155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cdc68ce2-ec2f-44d9-9e47-08daa02a915d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8223 Hi Andrew, > -----Original Message----- > From: Andrew Cooper > Subject: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt = test >=20 > buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler p= atch > which is relevant to CONFIG_XEN_IBT in 4.17 and later. >=20 > Force it on, rather than having 50% of the jobs not testing what they're > supposed to be testing. >=20 > Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible") > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Henry Wang >=20 > For 4.17: This is bugfix to CI only, to avoid it producing a false negati= ve. > Currently, the test intermittently fails to spot the error it was intende= d to > identify. It is very low risk as far as the 4.17 release goes. >=20 > https://gitlab.com/xen-project/people/andyhhp/xen/- > /jobs/3084774561#L373 for > proof that CONFIG_XEN_IBT=3Dy is being fed into allrandom.config Thanks for sending this patch! I agree that considering this patch to 4.17 is low risk, and as long as this patch is properly reviewed by CI maintainers, you can have my: Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Tue Sep 27 02:16:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 02:16:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412178.655385 (Exim 4.92) (envelope-from ) id 1od096-0004uC-Ar; Tue, 27 Sep 2022 02:16:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412178.655385; Tue, 27 Sep 2022 02:16:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od096-0004u5-6l; Tue, 27 Sep 2022 02:16:28 +0000 Received: by outflank-mailman (input) for mailman id 412178; Tue, 27 Sep 2022 02:16:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od094-0004tv-M5; Tue, 27 Sep 2022 02:16:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od094-0006MC-L3; Tue, 27 Sep 2022 02:16:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od094-0005IG-5S; Tue, 27 Sep 2022 02:16:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1od094-0002If-3h; Tue, 27 Sep 2022 02:16:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fr4w21pqDuw6k//FRqk8yh737R1pX968w4RndeZLZug=; b=x8myAazwihnOpfc+4GX1I0/bC1 5qkZE3lwatmdu7opBrQVTggYfFjqDd8DoN5TgBpZN1D21fvlSo5y4wHDS+eP5T9av4XYWYyXZh4on mEDwuCKNcVWsK2l7aJit43dCrodflbcX6EFVeIIvqRJ1B+XIcXwiDFVkxgMBckym4Bws=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173320: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bd68a5f397537eb7ba6223546c1f4d47f078d3b2 X-Osstest-Versions-That: xen=bfd3e9945d1bc551ad11272c7fa752ff3d060149 From: osstest service owner Date: Tue, 27 Sep 2022 02:16:26 +0000 flight 173320 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173320/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bd68a5f397537eb7ba6223546c1f4d47f078d3b2 baseline version: xen bfd3e9945d1bc551ad11272c7fa752ff3d060149 Last test of basis 173315 2022-09-26 10:01:54 Z 0 days Testing same since 173320 2022-09-26 23:01:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bfd3e9945d..bd68a5f397 bd68a5f397537eb7ba6223546c1f4d47f078d3b2 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 27 02:36:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 02:36:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412186.655396 (Exim 4.92) (envelope-from ) id 1od0SR-0007Vh-V2; Tue, 27 Sep 2022 02:36:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412186.655396; Tue, 27 Sep 2022 02:36:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0SR-0007Va-Rr; Tue, 27 Sep 2022 02:36:27 +0000 Received: by outflank-mailman (input) for mailman id 412186; Tue, 27 Sep 2022 02:36:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0SQ-0007VQ-Uv; Tue, 27 Sep 2022 02:36:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0SQ-0006hB-QT; Tue, 27 Sep 2022 02:36:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0SQ-0005oB-9R; Tue, 27 Sep 2022 02:36:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1od0SQ-0005DO-95; Tue, 27 Sep 2022 02:36:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zFYS0oDTL0WRTBoBWg+ywJNPehgPXYJwUwLKJzQaVEU=; b=S48Q8qmOhE8QniVFyhwInCPVJQ GhLOsvzCjv0HweWOGepZ4IISWZNiEJ6b8PvCetMlnHdhktSLsnw2taKvA4l10ivBeQGd7njPwRNDs /zPprslMj/juknCIoKFoqSuxXAb7x+TLS5FBD2e3We1Vb8HH7oqIs976YgcT9MgmuLUg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173317: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=99d6b11b5b44d7dd64f4cb1973184e40a4a174f8 X-Osstest-Versions-That: qemuu=6160d8ff81fb9fba70f5dad88d43ffd0fa44984c From: osstest service owner Date: Tue, 27 Sep 2022 02:36:26 +0000 flight 173317 qemu-mainline real [real] flight 173321 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173317/ http://logs.test-lab.xenproject.org/osstest/logs/173321/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 13 guest-start fail pass in 173321-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 173321-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173321 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173321 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173280 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173280 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173280 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173280 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173280 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173280 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173280 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173280 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu 99d6b11b5b44d7dd64f4cb1973184e40a4a174f8 baseline version: qemuu 6160d8ff81fb9fba70f5dad88d43ffd0fa44984c Last test of basis 173280 2022-09-22 19:39:03 Z 4 days Testing same since 173317 2022-09-26 19:39:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anton Kochkov Clément Chigot David Gibson Jason Wang Keqian Zhu Lucas Dietrich Peter Maydell Philippe Mathieu-Daudé Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6160d8ff81..99d6b11b5b 99d6b11b5b44d7dd64f4cb1973184e40a4a174f8 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Sep 27 03:04:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 03:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412200.655461 (Exim 4.92) (envelope-from ) id 1od0tQ-0003rX-NH; Tue, 27 Sep 2022 03:04:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412200.655461; Tue, 27 Sep 2022 03:04:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tQ-0003r4-Jp; Tue, 27 Sep 2022 03:04:20 +0000 Received: by outflank-mailman (input) for mailman id 412200; Tue, 27 Sep 2022 03:04:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tP-0002Wn-62 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 03:04:19 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 133b6b87-3e11-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 05:04:18 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6AB235C018F; Mon, 26 Sep 2022 23:04:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Sep 2022 23:04:17 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 23:04:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 133b6b87-3e11-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664247857; x=1664334257; bh=e866Y8JCmjNsNcx13FdeVQqHWG+JkkDT0Yl HuT4uoZM=; b=LDOyqebkTTqgORPbNfdQxFqwHefTI26vgpX2JbSvVp6oxxZcXH7 FA1Uq4cdVMW7py8Cygm7b7hP9Jscj5KJeV8ZJ+2MzdhLsGcoTkvzcQwv7FFw3e0L CM3ZFAaPjQpRGi985FU8Rv9fkR9DMIIA+UeF7APBCH3Thb3Keu/DSSWV3QbLclM5 xl05QOFkITWf+d62nsBv0RzHvof8HPw08iOef8T0qW+gYMsQpnfusySVPm7uZVIN qkkUF+3JF/tLfNBbW+1ndubolrsS3IyWAenERZjMWWAS8YyKCfJTKplsh7mh3Gyd f69+wxpatDOBU7NkAQJusPBZXREhY6XtnOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664247857; x=1664334257; bh=e866Y8JCmjNsN cx13FdeVQqHWG+JkkDT0YlHuT4uoZM=; b=XU7Mdz1v/AlV79K/VMFk+HzFX3eDl NK+/Ps0miTvN2XhIrBk9EitGPHkoOruLNPCNFS4hz7eJBi/04FSgjFJvDM9SeDVg cxKnMsXN9FkVqdDR4JJRLKLt9Gb+EZutrdoiGCDyyOHpaSdOepudB7/knba2D2DC ddoNvHY0eAYe1o3bXBYohFqFnbtOSdBpyaNjpLJHWILvResv4azSDNfSHDdul4U5 SW1Vs2thjpDJARivepKf2jAAsmMeXlc8pWn9KTHPrpb33Onq1tvJGED76a2Tt7U8 T85YOmESSd7CuHv53gNvfEdUiTCXRIWwm0OOv2jSF1lpE5qPtv/tIW0ZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 5/5] libxl: Add additional domain suspend/resume logs Date: Mon, 26 Sep 2022 23:04:01 -0400 Message-Id: <39c0faac0978315e0c79b9a25bb83dc0f951fed9.1664236600.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This was useful when debugging, but is not required. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 20 ++++++++++++++++++-- tools/libs/light/libxl_domain.c | 1 + 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index 42c0e0a152e04fab34152d711564ffe148f24a4c..55a172a46f8703661e696971bee07dce93117411 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -321,9 +321,11 @@ static void domain_suspend_common_pvcontrol_suspending(libxl__egc *egc, STATE_AO_GC(dsps->ao); xs_transaction_t t = 0; - if (!rc && !domain_suspend_pvcontrol_acked(state)) + if (!rc && !domain_suspend_pvcontrol_acked(state)) { /* keep waiting */ + LOGD(DEBUG, dsps->domid, "PV control callback without ack"); return; + } libxl__xswait_stop(gc, &dsps->pvcontrol); @@ -405,7 +407,10 @@ static void domain_suspend_common_wait_guest(libxl__egc *egc, static void suspend_common_wait_guest_watch(libxl__egc *egc, libxl__ev_xswatch *xsw, const char *watch_path, const char *event_path) { + EGC_GC; libxl__domain_suspend_state *dsps = CONTAINER_OF(xsw, *dsps, guest_watch); + + LOGD(DEBUG, dsps->domid, "@releaseDomain watch fired, checking guest status"); suspend_common_wait_guest_check(egc, dsps); } @@ -440,9 +445,11 @@ static bool suspend_common_wait_guest_check(libxl__egc *egc, if (check_guest_status(gc, domid, &info, "suspending")) goto err; - if (!(info.flags & XEN_DOMINF_shutdown)) + if (!(info.flags & XEN_DOMINF_shutdown)) { + LOGD(DEBUG, domid, "guest we were suspending has not shut down yet"); /* keep waiting */ return false; + } shutdown_reason = (info.flags >> XEN_DOMINF_shutdownshift) & XEN_DOMINF_shutdownmask; @@ -469,11 +476,14 @@ static void suspend_common_wait_guest_timeout(libxl__egc *egc, { libxl__domain_suspend_state *dsps = CONTAINER_OF(ev, *dsps, guest_timeout); STATE_AO_GC(dsps->ao); + LOGD(DEBUG, dsps->domid, "Timeout callback triggered"); if (suspend_common_wait_guest_check(egc, dsps)) return; if (rc == ERROR_TIMEDOUT) { LOGD(ERROR, dsps->domid, "guest did not suspend, timed out"); rc = ERROR_GUEST_TIMEDOUT; + } else { + LOGD(ERROR, dsps->domid, "error in timeout handler (code %d)", rc); } domain_suspend_common_done(egc, dsps, rc); } @@ -628,6 +638,8 @@ void libxl__dm_resume(libxl__egc *egc, libxl_domid domid = dmrs->domid; libxl__ev_qmp *qmp = &dmrs->qmp; + LOGD(DEBUG, domid, "Resuming device model"); + dm_resume_init(dmrs); rc = libxl__ev_time_register_rel(dmrs->ao, @@ -640,6 +652,7 @@ void libxl__dm_resume(libxl__egc *egc, case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL: { const char *path, *state; + LOGD(DEBUG, domid, "Resuming legacy device model: stubdomain ID %" PRIu32, dm_domid); path = DEVICE_MODEL_XS_PATH(gc, dm_domid, domid, "/state"); rc = libxl__xs_read_checked(gc, XBT_NULL, path, &state); if (rc) goto out; @@ -706,6 +719,7 @@ void libxl__dm_resume(libxl__egc *egc, goto out; } default: + LOGD(ERROR, domid, "Invalid device model type, cannot resume"); rc = ERROR_INVAL; goto out; } @@ -782,6 +796,8 @@ void libxl__domain_resume(libxl__egc *egc, int rc = 0; libxl_domain_type type = libxl__domain_type(gc, dmrs->domid); + LOGD(DEBUG, dmrs->domid, "Resuming domain"); + if (type == LIBXL_DOMAIN_TYPE_INVALID) { rc = ERROR_FAIL; goto out; diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index a6b0b509cc04379e9d596a38644e3db5963011ea..e8e0894c8617a36f6fc13af73daa1ed290a466ce 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -566,6 +566,7 @@ int libxl_domain_suspend_only(libxl_ctx *ctx, uint32_t domid, dsps->ao = ao; dsps->domid = domid; dsps->type = type; + LOGD(DEBUG, domid, "Received request to suspend domain"); rc = libxl__domain_suspend_init(egc, dsps, type); if (rc < 0) goto out_err; dsps->callback_common_done = domain_suspend_empty_cb; -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 27 03:04:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 03:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412198.655440 (Exim 4.92) (envelope-from ) id 1od0tN-0003IJ-PO; Tue, 27 Sep 2022 03:04:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412198.655440; Tue, 27 Sep 2022 03:04:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tN-0003IA-MP; Tue, 27 Sep 2022 03:04:17 +0000 Received: by outflank-mailman (input) for mailman id 412198; Tue, 27 Sep 2022 03:04:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tM-0002Wn-AB for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 03:04:16 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11511f31-3e11-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 05:04:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3A0A25C0197; Mon, 26 Sep 2022 23:04:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 26 Sep 2022 23:04:14 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 23:04:13 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11511f31-3e11-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1664247854; x=1664334254; bh=rfEB4qq1us gnZZFHzDZCUIOiVtuMjqLlDvfmQ2Nupnk=; b=b4L0AAU5yoKuVvM9hbud7Jan6f QZzf5HHlM1Y7GOBhUDjEJsKcFBbOywnOHsZHqg7T0x7wDU+r19dK2ozH8Mr3pdpD i46TaXr0b+0RDvvpOMreancL/h8dbybFPb2haz68zwPWZAq6j1Dwe/krRYrdRfc5 Sfky5udi49camu4MEsGHoiV9jaeioyzQlzbUd4D4fMXdILdcKFVZ9xlshiKHqqrB kYb1K3HB4VcTlUbgToP/8F7CE7IqCUVfDwHFOUbwh8hZcadxYN0EWJ7LDXSCXD8j yta/7aqX86/jeOR9mVlxBaRcOQXyhmOnYbQJP0RsFB2+MPSrMcucOgMxwdcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664247854; x= 1664334254; bh=rfEB4qq1usgnZZFHzDZCUIOiVtuMjqLlDvfmQ2Nupnk=; b=N RN+tstDGAIb10rEkDvX99cdTa3dE9c9cM2HNuxqXu/puRrCGRwYkZjakYa0Ybo7F 6SxuqvJqUibtSEzDdf4nHi+/ygV/NHaHy+RLC0bxo9W6Ctesr01pMyLbeVuTwKPu 6GCdydSqJLpTBXtuBCFlQJiLJAlZTTwQKzYo8qzQesj/WxnExHVDuCkDkUhNXqwR +hxKRy62+fKgefX2+PxyVKOFW2atLVrR/CMbrEYvZssg+o7oe/jULwdJV5EkXmmy scu9s33QoO9KWFKlvsQlWdcxic6Xzqxbjcd/HtuhiAtGJoV8CGzPTNGno4UHDMpn NSIZ7VDMbEwMgWCt212ZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvuefggfekffduhedtffeuffff tddtfeeihffggfejtddutdfguefftedvudehgfenucffohhmrghinhepghhithhhuhgsrd gtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Juergen Gross , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH 3/5] libxl: Properly suspend stubdomains Date: Mon, 26 Sep 2022 23:03:59 -0400 Message-Id: <558648f541d1ae827493fe13ff12ba363bad2392.1664236600.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, libxl neither pauses nor suspends a stubdomain when suspending the domain it serves. Qubes OS has an out-of-tree patch that just pauses the stubdomain, but that is also insufficient: sys-net (an HVM with an attached PCI device) does not properly resume from suspend on some systems, and the stubdomain considers the TSC clocksource to be unstable after resume. This patch properly suspends the stubdomain. Doing so requires creating a nested libxl__domain_suspend_state structure and freeing it when necessary. Additionally, a new callback function is added that runs when the stubdomain has been suspended. libxl__qmp_suspend_save() is called by this new callback. Saving the state doesn't work on Qubes for two reasons: - save/restore consoles are not enabled (as requiring qemu in dom0) - avoid using QMP Link: https://github.com/QubesOS/qubes-issues/issues/7404 Co-authored-by: Marek Marczykowski-Górecki Signed-off-by: Marek Marczykowski-Górecki Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 171 ++++++++++++++++++++++++++++---- tools/libs/light/libxl_internal.h | 1 + 2 files changed, 150 insertions(+), 22 deletions(-) diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index d2a88ea34efb115a8f2b861daf5884d95f39e81d..d276b3c17e70105c19c82e9da570a24297d039f5 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -19,9 +19,9 @@ /*====================== Domain suspend =======================*/ -int libxl__domain_suspend_init(libxl__egc *egc, - libxl__domain_suspend_state *dsps, - libxl_domain_type type) +static int libxl__domain_suspend_init_inner(libxl__egc *egc, + libxl__domain_suspend_state *dsps, + libxl_domain_type type) { STATE_AO_GC(dsps->ao); int rc = ERROR_FAIL; @@ -35,6 +35,7 @@ int libxl__domain_suspend_init(libxl__egc *egc, libxl__ev_xswatch_init(&dsps->guest_watch); libxl__ev_time_init(&dsps->guest_timeout); libxl__ev_qmp_init(&dsps->qmp); + dsps->dm_dsps = dsps->parent_dsps = NULL; if (type == LIBXL_DOMAIN_TYPE_INVALID) goto out; dsps->type = type; @@ -67,18 +68,95 @@ out: return rc; } +static void domain_suspend_device_model_domain_callback(libxl__egc *egc, + libxl__domain_suspend_state *dsps, + int rc); + +int libxl__domain_suspend_init(libxl__egc *egc, + libxl__domain_suspend_state *dsps, + libxl_domain_type type) +{ + STATE_AO_GC(dsps->ao); + uint32_t const domid = dsps->domid; + int rc = libxl__domain_suspend_init_inner(egc, dsps, type); + + LOGD(DEBUG, domid, "Initialized suspend state"); + if (type != LIBXL_DOMAIN_TYPE_HVM || + !libxl__stubdomain_is_linux_running(gc, domid)) + return rc; + + LOGD(DEBUG, domid, "Need to suspend stubdomain too"); + /* need to suspend the stubdomain too */ + uint32_t const dm_domid = libxl_get_stubdom_id(CTX, domid); + if (rc == 0 && dm_domid != 0) { + libxl__domain_suspend_state *dm_dsps; + + GCNEW(dm_dsps); + dm_dsps->domid = dm_domid; + dm_dsps->ao = dsps->ao; + + dm_dsps->type = libxl__domain_type(gc, dm_domid); + if (dm_dsps->type == LIBXL_DOMAIN_TYPE_PV || + dm_dsps->type == LIBXL_DOMAIN_TYPE_PVH) { + rc = libxl__domain_suspend_init_inner(egc, dm_dsps, dm_dsps->type); + } else { + LOGD(ERROR, domid, "Stubdomain %" PRIu32 " detected as neither PV " + "nor PVH (got %d), cannot suspend", dm_domid, dm_dsps->type); + rc = ERROR_FAIL; + } + if (rc) + libxl__domain_suspend_dispose(gc, dsps); + else { + dm_dsps->callback_common_done = domain_suspend_device_model_domain_callback; + dsps->dm_dsps = dm_dsps; + dm_dsps->parent_dsps = dsps; + } + } + return rc; +} + void libxl__domain_suspend_dispose(libxl__gc *gc, libxl__domain_suspend_state *dsps) { - libxl__xswait_stop(gc, &dsps->pvcontrol); - libxl__ev_evtchn_cancel(gc, &dsps->guest_evtchn); - libxl__ev_xswatch_deregister(gc, &dsps->guest_watch); - libxl__ev_time_deregister(gc, &dsps->guest_timeout); - libxl__ev_qmp_dispose(gc, &dsps->qmp); + for (;;) { + libxl__xswait_stop(gc, &dsps->pvcontrol); + libxl__ev_evtchn_cancel(gc, &dsps->guest_evtchn); + libxl__ev_xswatch_deregister(gc, &dsps->guest_watch); + libxl__ev_time_deregister(gc, &dsps->guest_timeout); + libxl__ev_qmp_dispose(gc, &dsps->qmp); + if (dsps->dm_dsps == NULL) + break; + assert(dsps->parent_dsps == NULL); + assert(dsps->dm_dsps->parent_dsps == dsps); + dsps = dsps->dm_dsps; + assert(dsps->dm_dsps == NULL); + } } /*----- callbacks, called by xc_domain_save -----*/ +static void domain_suspend_device_model_domain_callback(libxl__egc *egc, + libxl__domain_suspend_state *dm_dsps, + int rc) +{ + STATE_AO_GC(dm_dsps->ao); + libxl__domain_suspend_state *dsps = dm_dsps->parent_dsps; + assert(dm_dsps->dm_dsps == NULL); + assert(dsps); + assert(dsps->dm_dsps == dm_dsps); + if (rc) { + LOGD(ERROR, dsps->domid, + "failed to suspend device model (stubdom id %d), rc=%d", dm_dsps->domid, rc); + } else { + LOGD(DEBUG, dsps->domid, + "Successfully suspended stubdomain (stubdom id %d)", dm_dsps->domid); + } + dsps->callback_device_model_done(egc, dsps, rc); /* must be last */ +} + +static void domain_suspend_callback_common(libxl__egc *egc, + libxl__domain_suspend_state *dsps); + void libxl__domain_suspend_device_model(libxl__egc *egc, libxl__domain_suspend_state *dsps) { @@ -86,6 +164,7 @@ void libxl__domain_suspend_device_model(libxl__egc *egc, int rc = 0; uint32_t const domid = dsps->domid; const char *const filename = dsps->dm_savefile; + libxl__domain_suspend_state *dm_dsps = dsps->dm_dsps; switch (libxl__device_model_version_running(gc, domid)) { case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL: { @@ -95,15 +174,24 @@ void libxl__domain_suspend_device_model(libxl__egc *egc, break; } case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN: - /* calls dsps->callback_device_model_done when done */ - libxl__qmp_suspend_save(egc, dsps); /* must be last */ + if (dm_dsps) { + assert(dm_dsps->type == LIBXL_DOMAIN_TYPE_PVH || + dm_dsps->type == LIBXL_DOMAIN_TYPE_PV); + LOGD(DEBUG, domid, "Suspending stubdomain (domid %" PRIu32 ")", + dm_dsps->domid); + /* calls dm_dsps->callback_common_done when done */ + domain_suspend_callback_common(egc, dm_dsps); /* must be last */ + } else { + LOGD(DEBUG, domid, "Stubdomain not in use"); + /* calls dsps->callback_device_model_done when done */ + libxl__qmp_suspend_save(egc, dsps); /* must be last */ + } return; default: rc = ERROR_INVAL; - goto out; + break; } -out: if (rc) LOGD(ERROR, dsps->domid, "failed to suspend device model, rc=%d", rc); @@ -130,8 +218,6 @@ static void domain_suspend_common_done(libxl__egc *egc, libxl__domain_suspend_state *dsps, int rc); -static void domain_suspend_callback_common(libxl__egc *egc, - libxl__domain_suspend_state *dsps); static void domain_suspend_callback_common_done(libxl__egc *egc, libxl__domain_suspend_state *dsps, int rc); @@ -308,6 +394,7 @@ static void domain_suspend_common_wait_guest(libxl__egc *egc, suspend_common_wait_guest_timeout, 60*1000); if (rc) goto err; + return; err: @@ -528,6 +615,7 @@ void libxl__dm_resume(libxl__egc *egc, { STATE_AO_GC(dmrs->ao); int rc = 0; + uint32_t dm_domid = libxl_get_stubdom_id(CTX, dmrs->domid); /* Convenience aliases */ libxl_domid domid = dmrs->domid; @@ -543,7 +631,6 @@ void libxl__dm_resume(libxl__egc *egc, switch (libxl__device_model_version_running(gc, domid)) { case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL: { - uint32_t dm_domid = libxl_get_stubdom_id(CTX, domid); const char *path, *state; path = DEVICE_MODEL_XS_PATH(gc, dm_domid, domid, "/state"); @@ -563,14 +650,54 @@ void libxl__dm_resume(libxl__egc *egc, if (rc) goto out; break; } - case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN: - qmp->ao = dmrs->ao; - qmp->domid = domid; - qmp->callback = dm_resume_qmp_done; - qmp->payload_fd = -1; - rc = libxl__ev_qmp_send(egc, qmp, "cont", NULL); + case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN: { + xc_domaininfo_t dm_info; + + if (dm_domid == 0 /* || !libxl__stubdomain_is_linux_running() */) { + LOGD(DEBUG, domid, "Resuming dom0 device model using QMP"); + qmp->ao = dmrs->ao; + qmp->domid = domid; + qmp->callback = dm_resume_qmp_done; + qmp->payload_fd = -1; + rc = libxl__ev_qmp_send(egc, qmp, "cont", NULL); + if (rc) goto out; + return; + } + + LOGD(DEBUG, domid, "Resuming modern stubdomain: ID %" PRIu32, dm_domid); + + rc = check_guest_status(gc, dm_domid, &dm_info, "resuming"); if (rc) goto out; - break; + + if ((dm_info.flags & XEN_DOMINF_paused)) { + rc = xc_domain_unpause(CTX->xch, dm_domid); + if (rc < 0) { + LOGED(ERROR, domid, + "xc_domain_unpause failed for stubdomain %" PRIu32, + dm_domid); + goto out; + } + LOGD(DEBUG, domid, + "xc_domain_unpause succeeded for stubdomain %" PRIu32, + dm_domid); + } + + if ((dm_info.flags & XEN_DOMINF_shutdown)) { + int shutdown_reason = + (dm_info.flags >> XEN_DOMINF_shutdownshift) + & XEN_DOMINF_shutdownmask; + if (shutdown_reason != SHUTDOWN_suspend) { + LOGD(ERROR, domid, "stubdomain %d being resumed shut down" + " with unexpected reason code %d", + dm_domid, shutdown_reason); + rc = ERROR_FAIL; + goto out; + } + + rc = domain_resume_raw(gc, dm_domid, dmrs->suspend_cancel); + } + goto out; + } default: rc = ERROR_INVAL; goto out; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 34063baf81c4eae81790e2f25cc37f5cf58eb196..37e5c98f63472e66100b6301d78ac0178cbf987e 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -3615,6 +3615,7 @@ struct libxl__domain_suspend_state { struct libxl__domain_suspend_state*, int rc); void (*callback_common_done)(libxl__egc*, struct libxl__domain_suspend_state*, int ok); + struct libxl__domain_suspend_state *dm_dsps, *parent_dsps; }; int libxl__domain_suspend_init(libxl__egc *egc, libxl__domain_suspend_state *dsps, -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 27 03:04:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 03:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412195.655407 (Exim 4.92) (envelope-from ) id 1od0tJ-0002Wv-Ue; Tue, 27 Sep 2022 03:04:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412195.655407; Tue, 27 Sep 2022 03:04:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tJ-0002Wo-RD; Tue, 27 Sep 2022 03:04:13 +0000 Received: by outflank-mailman (input) for mailman id 412195; Tue, 27 Sep 2022 03:04:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tI-0002Wh-PX for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 03:04:13 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d942d05-3e11-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 05:04:10 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C5FE15C0184; Mon, 26 Sep 2022 23:04:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Sep 2022 23:04:07 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 23:04:06 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d942d05-3e11-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664247847; x=1664334247; bh=4JBZUH33o80SQ6EzWzmNbNdJlNaQRG2DHCp 2h8NCN1E=; b=HoK+K0rYsM7JujYZvrdkZrM8PLlqf/Bhpkd3FdsEo5YSs9cS4tm C8l44Co2N+5jRwpI+0G0aGwoLNJS7cy60wYwYPLV0ed4QRme58r3U4j+fBi5Sjr+ cbJ0tb+vAvIImeXfNbGxfNcvX6mW03EqWaiG0O8s+dtVslvp5kAQ/ggRAWIN0r3v r7uWfC6u/5Ld5X+tB8cENXsZywm4dFiBAXT0LDjst5JPMOzvS1wm1r173Vc6jKZl vvS/AWow5TWN4avYplR8aF5Cs37Ps52zQim9iwRna/hPkm6suyO8/xwBSrFqmLkx bNyF9Pc1rpPbZhoDyz1FI0GdKycoaKNcMeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664247847; x=1664334247; bh=4JBZUH33o80SQ 6EzWzmNbNdJlNaQRG2DHCp2h8NCN1E=; b=EKZCLZq3LOSIJEFlSNUPqRVHbe3bH No6N1JFJdc59Vn7h2QjB9crumLLB5ilXDmveBrJFUC5OsZvZnyvgIV1W1m7S2MOH xY8gssMIqqa4LLsutLAgXF6AbcmxdJFFMLs+M46jyzrYSYCveI0C+GwGNIbCKvuT M/hewWTG2dfcGZKuB4lcXhjWSiRNjNub/z+eXyc43e16+wfXANSQnKFvB+f7QIdu mTJO8knuljnW9wR5YpTVKZ7ENGPM3ccbG5SHzeNX6DmtON0NegawSss+3L5MrD0F cGrl9/hoDVI7gdC/B4YZeiBjLMmAvPP4WyPturr6s2ni0hVsjZwwM6iWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhgefgieeitdeijeeguddtkefgteeg heehgeetkeevhfefgfduhedtveelgeeugeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 0/5] Suspend and resume stubdomains Date: Mon, 26 Sep 2022 23:03:56 -0400 Message-Id: X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, libxl neither pauses nor suspends a stubdomain when suspending the domain it serves. Qubes OS has an out-of-tree patch that just pauses the stubdomain, but that is also insufficient: sys-net (an HVM with an attached PCI device) does not properly resume from suspend on some systems, and the stubdomain considers the TSC clocksource to be unstable after resume. The first two patches add utility functions that will be used later. The third patch is the one that actually suspends the stubdomain. The fourth patch makes suspending slow-to-respond domains more robust, and the fifth patch adds extra logging. Demi Marie Obenour (5): libxl: Add a utility function for domain resume libxl: Add utility function to check guest status libxl: Properly suspend stubdomains libxl: Fix race condition in domain suspension libxl: Add additional domain suspend/resume logs tools/libxl/libxl_dom_suspend.c | 276 +++++++++++++++++++++++++------- tools/libxl/libxl_domain.c | 1 + tools/libxl/libxl_internal.h | 1 + 3 files changed, 218 insertions(+), 60 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 27 03:04:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 03:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412196.655417 (Exim 4.92) (envelope-from ) id 1od0tL-0002ma-8v; Tue, 27 Sep 2022 03:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412196.655417; Tue, 27 Sep 2022 03:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tL-0002mT-6A; Tue, 27 Sep 2022 03:04:15 +0000 Received: by outflank-mailman (input) for mailman id 412196; Tue, 27 Sep 2022 03:04:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tK-0002Wn-2U for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 03:04:14 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fb06a2b-3e11-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 05:04:12 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7CDC15C0193; Mon, 26 Sep 2022 23:04:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 26 Sep 2022 23:04:11 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 23:04:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fb06a2b-3e11-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664247851; x=1664334251; bh=jh+Frhwmh5e9JCT1Ke46iLV+JdKVkMGqf4f rllkpN/Q=; b=16v6Q6OYYkHyRXIFYk3fIXCc5kxp/x8ZzzFI9kCroshhXUCyFJG U9kAtnvUVBp3uyiBdEjQ7fJRo0HwH5XsPwynrwQoK1gFtB52fgeeOpkCN6ZUwI1n Ne4N1I2yJjieq3BgLyF10ziJP+Piktqug3ZRa0eyA8GkQl2giu4AoB/tHApDTiY4 KP40jNX07ugI1zo/XX4SqOal3opBFrMW8VAkpo3ytDn72vwtDSnIWWAmQ4SyGFVX l8Jx46yJ5OhgRluDWPbF/ssOwqZbIKQA7qrANksfuiwA4LTj2R8h9b350N3Iz0py MmKDcTldHKKTHI8zrOE7XkwI4p5IQgv26NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664247851; x=1664334251; bh=jh+Frhwmh5e9J CT1Ke46iLV+JdKVkMGqf4frllkpN/Q=; b=gZ4D83zX/uTM0NwvNsn/VTSvBwumz U1AFa+B9CcmlkwonHsDLRJBKlGavhiTuJ7waSOzO0cWA9kaKSEQTfHLd7ZdOWfId Egx9aCN1UNhoua89qzl9dpkYkCc6/qMY30c4tmlL3KQtDh1XuFNpGw5v4rkUDJGJ n95n8CUIlXAsFe0DI42y16Qk3HtgySRuklGSg2Lrckso9bDS0fFSf2Kt6x5q8wcr iVWwJWhyP58ce5a/ctlEFb5dhZOXt9E8R/hz19y555NKJ+KOIX6TCQCn9KPyc5oP UsEkmvMBIqOcocX1QwnEM6aOd5mK6ivaxXUpF80O44ufXUDe0OW2JQlag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 1/5] libxl: Add a utility function for domain resume Date: Mon, 26 Sep 2022 23:03:57 -0400 Message-Id: <6fcc32dc0747a081eb4b182dae1a483c6d1258f4.1664236600.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It is necessary to all xs_resume_domain after any successful call to xc_domain_resume, so that XenStore is notified of the resumption. However, it is also very easy to forget to call this. This took me several days to debug. Fix this by adding a utility function to resume a domain and then notify XenStore of the resumption. This function does not resume any device model, so it is still internal to libxl, but it makes future changes to libxl much less error-prone. It also makes libxl itself smaller. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 41 +++++++++++++++------------------ 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index 4fa22bb7391049f2ea4ac32f21660212053bd4bc..fa50e8801f35d173a99ae5dd19eb941649e14019 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -451,6 +451,22 @@ int libxl__domain_resume_device_model_deprecated(libxl__gc *gc, uint32_t domid) return 0; } +/* Just resumes the domain. The device model must have been resumed already. */ +static int domain_resume_raw(libxl__gc *gc, uint32_t domid, int suspend_cancel) +{ + if (xc_domain_resume(CTX->xch, domid, suspend_cancel)) { + LOGED(ERROR, domid, "xc_domain_resume failed"); + return ERROR_FAIL; + } + + if (!xs_resume_domain(CTX->xsh, domid)) { + LOGED(ERROR, domid, "xs_resume_domain failed"); + return ERROR_FAIL; + } + + return 0; +} + int libxl__domain_resume_deprecated(libxl__gc *gc, uint32_t domid, int suspend_cancel) { int rc = 0; @@ -469,16 +485,7 @@ int libxl__domain_resume_deprecated(libxl__gc *gc, uint32_t domid, int suspend_c } } - if (xc_domain_resume(CTX->xch, domid, suspend_cancel)) { - LOGED(ERROR, domid, "xc_domain_resume failed"); - rc = ERROR_FAIL; - goto out; - } - - if (!xs_resume_domain(CTX->xsh, domid)) { - LOGED(ERROR, domid, "xs_resume_domain failed"); - rc = ERROR_FAIL; - } + rc = domain_resume_raw(gc, domid, suspend_cancel); out: return rc; } @@ -660,19 +667,9 @@ static void domain_resume_done(libxl__egc *egc, /* Convenience aliases */ libxl_domid domid = dmrs->domid; - if (rc) goto out; - - if (xc_domain_resume(CTX->xch, domid, dmrs->suspend_cancel)) { - LOGED(ERROR, domid, "xc_domain_resume failed"); - rc = ERROR_FAIL; - goto out; - } + if (!rc) + rc = domain_resume_raw(gc, domid, dmrs->suspend_cancel); - if (!xs_resume_domain(CTX->xsh, domid)) { - LOGED(ERROR, domid, "xs_resume_domain failed"); - rc = ERROR_FAIL; - } -out: dmrs->callback(egc, dmrs, rc); } -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 27 03:04:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 03:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412199.655451 (Exim 4.92) (envelope-from ) id 1od0tP-0003Zw-Ag; Tue, 27 Sep 2022 03:04:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412199.655451; Tue, 27 Sep 2022 03:04:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tP-0003Zn-7k; Tue, 27 Sep 2022 03:04:19 +0000 Received: by outflank-mailman (input) for mailman id 412199; Tue, 27 Sep 2022 03:04:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tN-0002Wn-N3 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 03:04:17 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 126bfb2c-3e11-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 05:04:16 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 16DCB5C0194; Mon, 26 Sep 2022 23:04:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Sep 2022 23:04:16 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 23:04:15 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 126bfb2c-3e11-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664247856; x=1664334256; bh=bVEPwgLcbq+BZ1Wl7+Gkkocayb9AhcjX3Ls ejAExFkI=; b=l6pbj9Ojnwg8wA/IiuSwALGS1l2xZ96b9R4dZqI0hqOuZ/5OY0g kTlBJQYsnb+cxSvycEQ17gAu1FgbAdYqUamg6htQEGYbsAh8AR8rTNoKdRzMBRNv +0QUGyjcFZiqxOUlZWWHHbuSCbD93kPoDegn48lISK9pB16bFhiLaB3S3UlCF8Yu 0HPsB+PDaAsfzkG0Jzlpsqv/VqNWdw1mFleGfIV8iXesOh/SiRipJ4qmV29DO0Pa QqR4Fw459OOPbRKWyGAPHm+K91VB9Tz+ez73AhHS+6q3CL8v7y0qVIZoTst91RcF z+sGiQzMo8wJpz9QvWIiimER20QdGq7Z5Ig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664247856; x=1664334256; bh=bVEPwgLcbq+BZ 1Wl7+Gkkocayb9AhcjX3LsejAExFkI=; b=ZmdooMZN0BCcdS/rDTwwrNLYEIBCV 0lTv4hGq2wWwci8x0r2+eVV7S/+Um2jMRxBJDwaseF+KWXqz5hod6u2wpnrBoZ/W DDlczt0ztAp7Q8iRdfZhH+T4meVjgOihkZrPC2CmAbPLfnrcLX5FXyjx+a5yYFUq eivnM2evkO1wAdSzAS8RaINXWYlXfs694urDS1MVdDdhV1NHBeIqouALQUqd2GTT tEBrFIxstOS23ilk/TAMNmXYzETbPyQwVfLFPBeidoXtGX4ux+FtCEKWjc2DECRm 7cVq3PwOAlUCnQZECEeuYbAyOBUuZXN9URGIcYELXY9QVkRVLpPdOS9fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 4/5] libxl: Fix race condition in domain suspension Date: Mon, 26 Sep 2022 23:04:00 -0400 Message-Id: X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check if the domain has suspended after setting the XenStore watch to prevent race conditions. Also check if a guest has suspended when the timeout handler is called, and do not consider this to be a timeout. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index d276b3c17e70105c19c82e9da570a24297d039f5..42c0e0a152e04fab34152d711564ffe148f24a4c 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -209,7 +209,8 @@ static void domain_suspend_common_wait_guest_evtchn(libxl__egc *egc, libxl__ev_evtchn *evev); static void suspend_common_wait_guest_watch(libxl__egc *egc, libxl__ev_xswatch *xsw, const char *watch_path, const char *event_path); -static void suspend_common_wait_guest_check(libxl__egc *egc, +/* Returns true if a callback was called, false otherwise */ +static bool suspend_common_wait_guest_check(libxl__egc *egc, libxl__domain_suspend_state *dsps); static void suspend_common_wait_guest_timeout(libxl__egc *egc, libxl__ev_time *ev, const struct timeval *requested_abs, int rc); @@ -426,7 +427,7 @@ static int check_guest_status(libxl__gc *gc, const uint32_t domid, return 0; } -static void suspend_common_wait_guest_check(libxl__egc *egc, +static bool suspend_common_wait_guest_check(libxl__egc *egc, libxl__domain_suspend_state *dsps) { STATE_AO_GC(dsps->ao); @@ -441,7 +442,7 @@ static void suspend_common_wait_guest_check(libxl__egc *egc, if (!(info.flags & XEN_DOMINF_shutdown)) /* keep waiting */ - return; + return false; shutdown_reason = (info.flags >> XEN_DOMINF_shutdownshift) & XEN_DOMINF_shutdownmask; @@ -452,11 +453,15 @@ static void suspend_common_wait_guest_check(libxl__egc *egc, } LOGD(DEBUG, domid, "guest has suspended"); + dsps->guest_responded = 1; + libxl__xswait_stop(gc, &dsps->pvcontrol); domain_suspend_common_guest_suspended(egc, dsps); - return; + return true; err: + libxl__xswait_stop(gc, &dsps->pvcontrol); domain_suspend_common_done(egc, dsps, ERROR_FAIL); + return true; } static void suspend_common_wait_guest_timeout(libxl__egc *egc, @@ -464,6 +469,8 @@ static void suspend_common_wait_guest_timeout(libxl__egc *egc, { libxl__domain_suspend_state *dsps = CONTAINER_OF(ev, *dsps, guest_timeout); STATE_AO_GC(dsps->ao); + if (suspend_common_wait_guest_check(egc, dsps)) + return; if (rc == ERROR_TIMEDOUT) { LOGD(ERROR, dsps->domid, "guest did not suspend, timed out"); rc = ERROR_GUEST_TIMEDOUT; -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 27 03:04:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 03:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412197.655429 (Exim 4.92) (envelope-from ) id 1od0tM-000322-Hs; Tue, 27 Sep 2022 03:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412197.655429; Tue, 27 Sep 2022 03:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tM-00031v-Es; Tue, 27 Sep 2022 03:04:16 +0000 Received: by outflank-mailman (input) for mailman id 412197; Tue, 27 Sep 2022 03:04:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od0tK-0002Wn-Qx for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 03:04:14 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 108669a6-3e11-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 05:04:13 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DEFB95C0198; Mon, 26 Sep 2022 23:04:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 26 Sep 2022 23:04:12 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 23:04:12 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 108669a6-3e11-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664247852; x=1664334252; bh=f6ZPHLSgD7XKJHqHB/XRr1A+xgGqvvyVHfV 9tK3yBF8=; b=stP9n8OLysaRZAgI0hVUO5K5vvWrV3KynONeqKpOch8rKi2SGrM L8eJ2uKOWuK+29by+PEMGNMXhYhekWoT2P8brAIA3lEC04h09EnEFdI960dykbxW CeBK130vOgnOiKt32buiQaq6aA06eebe5d6wziEZq1aw0W9Jamd32a8lsKLPG5vQ A+NREmBzLlc60raErznpkvrzxRU3y916X+Z1oaLYH+tNNWsr25LQLUeRamxhojxi paNdyueOV9DmyG0NajCQPEQKczfworoYUTGvuAjTyYEqtIEvr3+Qr9d1CHU1o09b IBJfo/hATUdgCKKPdPJ3S+Ln7IfX/KhaS5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664247852; x=1664334252; bh=f6ZPHLSgD7XKJ HqHB/XRr1A+xgGqvvyVHfV9tK3yBF8=; b=L5QjJcMZbB5LyxexrgJcOojGggW8d gR9NOT3QqReStJ3u53F6k24dtHVd/DOQhX/PxaahaQ7dluPEDYRJIBCHSHtDOSJS z3T7B4I+x3+QydGnxdPlWwPL38RYnd6HPnk6WykynYj+XeYhLDNflG4985PsLomI 9z2zoKXEDCia+nnQtzRj9SGoSWTyOQQGTyuA+IBenTXM3yPFbnAPplBlAfyM0/Sf AJv4Sfa9sxZOCYpMBMQuayjs6GUWKWhXrYQq9esdDVaWu5ttPKl+UNyxA1SKJbtG UVLnBte6QmPa0oEL9AoPfpkl8wbDF9vq2BYE81ZWCwTDohoX3UQBtOdyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 2/5] libxl: Add utility function to check guest status Date: Mon, 26 Sep 2022 23:03:58 -0400 Message-Id: <3bbc7f9038049815bc2af1e4d901347160e09f7b.1664236600.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is used to check that a guest has not been destroyed and to obtain information about it. It will be used in subsequent patches. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index fa50e8801f35d173a99ae5dd19eb941649e14019..d2a88ea34efb115a8f2b861daf5884d95f39e81d 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -321,27 +321,36 @@ static void suspend_common_wait_guest_watch(libxl__egc *egc, suspend_common_wait_guest_check(egc, dsps); } +static int check_guest_status(libxl__gc *gc, const uint32_t domid, + xc_domaininfo_t *info, const char *what) +{ + int ret = xc_domain_getinfolist(CTX->xch, domid, 1, info); + + if (ret < 0) { + LOGED(ERROR, domid, "unable to check for status of guest"); + return ERROR_FAIL; + } + + if (!(ret == 1 && info->domain == domid)) { + LOGED(ERROR, domid, "guest we were %s has been destroyed", what); + return ERROR_FAIL; + } + + return 0; +} + static void suspend_common_wait_guest_check(libxl__egc *egc, libxl__domain_suspend_state *dsps) { STATE_AO_GC(dsps->ao); xc_domaininfo_t info; - int ret; int shutdown_reason; /* Convenience aliases */ const uint32_t domid = dsps->domid; - ret = xc_domain_getinfolist(CTX->xch, domid, 1, &info); - if (ret < 0) { - LOGED(ERROR, domid, "unable to check for status of guest"); + if (check_guest_status(gc, domid, &info, "suspending")) goto err; - } - - if (!(ret == 1 && info.domain == domid)) { - LOGED(ERROR, domid, "guest we were suspending has been destroyed"); - goto err; - } if (!(info.flags & XEN_DOMINF_shutdown)) /* keep waiting */ -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Sep 27 05:37:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 05:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412244.655472 (Exim 4.92) (envelope-from ) id 1od3HJ-0004rs-5v; Tue, 27 Sep 2022 05:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412244.655472; Tue, 27 Sep 2022 05:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3HJ-0004rl-39; Tue, 27 Sep 2022 05:37:09 +0000 Received: by outflank-mailman (input) for mailman id 412244; Tue, 27 Sep 2022 05:37:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3HH-0004qP-Af; Tue, 27 Sep 2022 05:37:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3HH-0001zX-8q; Tue, 27 Sep 2022 05:37:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3HF-00081M-Ss; Tue, 27 Sep 2022 05:37:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1od3HF-0001DS-SN; Tue, 27 Sep 2022 05:37:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sYy9ZupRSksp9zerEAInUKyrh5sphGtDcW0A32mGWKs=; b=PDqwnS9brL9HCE7Rws+Ba0Bkq2 BSA0vpEBdLkTH29N8SuLJvQXgI6vK2dyJ6/7xTnRIXHF/SLKBCtv8HVTNRGSr9TTNhNJMlwgTLYnJ N9JyIiHmNs44gdW5XhvdpvZy7G1G5/A80JGqZww46VuLHGP4WM9nKXGQ0qOLRRenPiyM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173323: all pass - PUSHED X-Osstest-Versions-This: ovmf=b3dd9cb836e2aed68198aa79a1ca6afdb25adf80 X-Osstest-Versions-That: ovmf=96f3efbd991db83c608909c1c861a77fe26982f1 From: osstest service owner Date: Tue, 27 Sep 2022 05:37:05 +0000 flight 173323 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173323/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b3dd9cb836e2aed68198aa79a1ca6afdb25adf80 baseline version: ovmf 96f3efbd991db83c608909c1c861a77fe26982f1 Last test of basis 173318 2022-09-26 20:40:22 Z 0 days Testing same since 173323 2022-09-27 03:13:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: jdzhang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 96f3efbd99..b3dd9cb836 b3dd9cb836e2aed68198aa79a1ca6afdb25adf80 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Sep 27 05:42:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 05:42:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412252.655484 (Exim 4.92) (envelope-from ) id 1od3Mh-0006HP-QV; Tue, 27 Sep 2022 05:42:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412252.655484; Tue, 27 Sep 2022 05:42:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3Mh-0006Gz-No; Tue, 27 Sep 2022 05:42:43 +0000 Received: by outflank-mailman (input) for mailman id 412252; Tue, 27 Sep 2022 05:42:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3Mg-0006Gq-7f for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 05:42:42 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31626c7a-3e27-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 07:42:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C05B721E15; Tue, 27 Sep 2022 05:42:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 771A613486; Tue, 27 Sep 2022 05:42:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 80J4G0yNMmMBTwAAMHmgww (envelope-from ); Tue, 27 Sep 2022 05:42:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31626c7a-3e27-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664257356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PoGypo9wabagz5Ez5shORs5Ik4cT/A/oGecV3TXkpDY=; b=i0ZtE1nhM6kQ+65pq0bYIZGDaHGCzqg9o50wkaLMz+4JgeJnutZclydSChYW8cRB41l4KV XUuB7yLFmJQOwOuvZKaXZAzqIgefxC9IN3oECiJxZNTBmcyZvmaB6CWufml16IML/OFOnf W1TBPrGDAs/x/EGhnbY3MSVf8RPO+N0= Message-ID: <3dba20a4-20d0-6cff-68be-25e9ca365764@suse.com> Date: Tue, 27 Sep 2022 07:42:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP Content-Language: en-US To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-2-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EwXwm3Tkt105kt7C7sMEZbTc" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EwXwm3Tkt105kt7C7sMEZbTc Content-Type: multipart/mixed; boundary="------------vKayfY0gx8rXGtDotio2W0Vl"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Message-ID: <3dba20a4-20d0-6cff-68be-25e9ca365764@suse.com> Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP References: <20220926141849.21805-1-jgross@suse.com> <20220926141849.21805-2-jgross@suse.com> In-Reply-To: --------------vKayfY0gx8rXGtDotio2W0Vl Content-Type: multipart/mixed; boundary="------------C4t0bHUmD704yIDltWCwzrMq" --------------C4t0bHUmD704yIDltWCwzrMq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMjI6MDksIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDkv MjYvMjIgMTA6MTggQU0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiDCoCBib29sIHBtdV9t c3JfcmVhZCh1bnNpZ25lZCBpbnQgbXNyLCB1aW50NjRfdCAqdmFsLCBpbnQgKmVycikNCj4+ IMKgIHsNCj4+IMKgwqDCoMKgwqAgaWYgKGJvb3RfY3B1X2RhdGEueDg2X3ZlbmRvciAhPSBY ODZfVkVORE9SX0lOVEVMKSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgaWYgKGlzX2FtZF9wbXVf bXNyKG1zcikpIHsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICgheGVuX2FtZF9w bXVfZW11bGF0ZShtc3IsIHZhbCwgMSkpDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgICp2YWwgPSBuYXRpdmVfcmVhZF9tc3Jfc2FmZShtc3IsIGVycik7DQo+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gdHJ1ZTsNCj4+ICvCoMKgwqDCoMKgwqDCoCBp ZiAoIWlzX2FtZF9wbXVfbXNyKG1zcikpDQo+IA0KPiANCj4gWW91IHNob3VsZCBiZSBhYmxl IHRvIG1vdmUgdmVuZG9yIGNoZWNrIGluc2lkZSBpc188dmVuZG9yPl9wbXVfbXNyKCkuDQoN CkkgbGlrZSB0aGF0LiBUb2dldGhlciB3aXRoIEphbidzIHN1Z2dlc3Rpb24gdGhpcyBtYWtl cyB0aGUgY29kZSBtdWNoDQptb3JlIHJlYWRhYmxlIQ0KDQoNCkp1ZXJnZW4NCg0K --------------C4t0bHUmD704yIDltWCwzrMq Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C4t0bHUmD704yIDltWCwzrMq-- --------------vKayfY0gx8rXGtDotio2W0Vl-- --------------EwXwm3Tkt105kt7C7sMEZbTc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMyjUwFAwAAAAAACgkQsN6d1ii/Ey/V Jgf/VHdlpbEEF9O3+AACXavw9TkrLv1+EcWudH/OH55CttV6npJ66vC4uNQEeq0DGmhBJqsRYdmZ kNhnYbvRYxPbMWo/4KvWIGeGYhElxEXkN9QGF3hPxFvWIX8Jy6UDOiaQcUmHDcyfAyeKLA2W+XPF zwzqgJCWtgf8cfXjTJHL7Lw83UpeYyTATThzdmA1esrXLVy7N5Sjg766uw27BRbe+FRV53LAxU4D w87avl+FQF1TjHJRD9iA/Z6KLFytWyfjlQG52e3mD0C8SIYSa+Jv9X7tBBaXUkSyaHHmWEWPC+ap +OJzh0fMZ5ErdYjCVbGa4GhhtpwcD0Pu8Idj/ChOSA== =K9Zs -----END PGP SIGNATURE----- --------------EwXwm3Tkt105kt7C7sMEZbTc-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 05:42:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 05:42:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412253.655494 (Exim 4.92) (envelope-from ) id 1od3Mw-0006ge-63; Tue, 27 Sep 2022 05:42:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412253.655494; Tue, 27 Sep 2022 05:42:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3Mw-0006gX-2w; Tue, 27 Sep 2022 05:42:58 +0000 Received: by outflank-mailman (input) for mailman id 412253; Tue, 27 Sep 2022 05:42:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3Mu-0006dN-Mv; Tue, 27 Sep 2022 05:42:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3Mu-00025O-Ku; Tue, 27 Sep 2022 05:42:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od3Mu-0008Tl-2Y; Tue, 27 Sep 2022 05:42:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1od3Mu-0000ue-1r; Tue, 27 Sep 2022 05:42:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zYsHcqCriw/arL8+iV7rlTfOCG5I3d+vzy+7tWGYCo8=; b=CVPErfHEflPbYvb9zZlHC7Pbtd bbQ8koSULGKXknJC5hMYavW4WsrxgmaNJ/qHbHID3odjMW5IGXY+NeHS52PDeuNtHK8AuWBMrA9Hq 1YqcifYk1J3vYqefsvXgIFsUz1pYHVZaR7JQuVVDnRIPeG6gzgtFaojnltex2P+VqWwA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173319: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:host-ping-check-xen:fail:heisenbug linux-linus:test-armhf-armhf-xl-arndale:host-ping-check-xen:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3800a713b6070d4f03fb43613a7b7d536a99b2b7 X-Osstest-Versions-That: linux=f76349cf41451c5c42a99f18a9163377e4b364ff From: osstest service owner Date: Tue, 27 Sep 2022 05:42:56 +0000 flight 173319 linux-linus real [real] flight 173324 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173319/ http://logs.test-lab.xenproject.org/osstest/logs/173324/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 10 host-ping-check-xen fail pass in 173324-retest test-armhf-armhf-xl-arndale 10 host-ping-check-xen fail pass in 173324-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail in 173324 like 173311 test-armhf-armhf-libvirt 15 migrate-support-check fail in 173324 never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173324 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173324 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173311 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173311 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173311 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173311 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173311 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173311 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173311 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3800a713b6070d4f03fb43613a7b7d536a99b2b7 baseline version: linux f76349cf41451c5c42a99f18a9163377e4b364ff Last test of basis 173311 2022-09-25 22:42:04 Z 1 days Testing same since 173319 2022-09-26 21:41:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Popple Andrew Morton Binyi Han ChenXiaoSong Christoph Hellwig Dan Williams David Hildenbrand Doug Berger Florian Lehner Greg Kroah-Hartman Jan Kara Kees Cook Kirill A. Shutemov Linus Torvalds Liu Shixin Matthew Wilcox (Oracle) Maurizio Lombardi Mel Gorman Michal Hocko Minchan Kim Naohiro Aota Naoya Horiguchi Peter Xu Peter Zijlstra (Intel) SeongJae Park Sergei Antonov Shuai Xue Theodore Ts'o Yang Shi Zi Yan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git f76349cf4145..3800a713b607 3800a713b6070d4f03fb43613a7b7d536a99b2b7 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Sep 27 06:35:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 06:35:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412269.655506 (Exim 4.92) (envelope-from ) id 1od4Bj-0004Gp-0G; Tue, 27 Sep 2022 06:35:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412269.655506; Tue, 27 Sep 2022 06:35:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od4Bi-0004Gi-Ta; Tue, 27 Sep 2022 06:35:26 +0000 Received: by outflank-mailman (input) for mailman id 412269; Tue, 27 Sep 2022 06:35:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od4Bi-0004Gc-0w for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 06:35:26 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90c5dfb5-3e2e-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 08:35:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7677.eurprd04.prod.outlook.com (2603:10a6:102:eb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 06:35:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 06:35:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90c5dfb5-3e2e-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lYD49ReDlBsiO4TWWgHf/kbnNqYHZnjwwMvl+iJgdg99dvsBK4cHsr5ScHApRf+v/FC0TmyDkFFpA2BeE4spNyKtVnuELrdYLQMQWynsQ5Fu6RHqrx5n9/vK4oHgIHItAGX5OrIy1lRjZiz/jyqpAKYNGyHJM2jDGSn/iHXNb0X1JK8z40WuAgUHUfbGFdx4ah7mnVo5anFkbwu1cYkOQRIGzt4dj40NrqwNk7HQcjNeR8lcEXhM/E89V0QamqhkNxPsa68QC38ehTp5J+Rhe+Akplu8kmZG1zQONrs1w6hYRBlLv/UPHcMvdPtmcdVRZoNRG9ffVTPVDo+V1qXG3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iIr6NuGjff+Po5IsD9ItbZh4rwNiw03g7QwP09PZqyk=; b=XB9fE16yRNxlbtgABJ/wMRKFYnmlD/TXZ7dmWrF9yk7nfaBl57MzHFr7VyZ164dCvx/2/AD8uwG5vqcCo6dHrIMgJtTr6U3+yD4UXeudjioT3Rpq8DEoyGmnCM0DBZqrqAvgEP7qBlopZ57+KEzrd9d+JMzm3nJpMruhjSmv6jcyqK+otqX+FxRtDWeWreTjhO+t5z411SuosAmSJjPbX3oHF+cdWeJdwBxh+wma6SoKuYP/wUhNE4VcAvsDkmjeeAoCtZ8+yn27srSuUZBiSQ8/XAkvX+Bs5/IL91Hgb54h7oDbMiS/2ORZSZHH1gBFcvBiYtyQvoaYemIpoY39sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iIr6NuGjff+Po5IsD9ItbZh4rwNiw03g7QwP09PZqyk=; b=ZYAEvAXsDOCyrps4AhB92SHUY0w5BEjkomMvGHXWBcNmNwzNrCYnI8JP4BiAW+9pqRJYJaeBlArQfB/1+uCMhbr03K3mtT23sU1bb/fbvSqWmiFjowcyNlosZmlzfB2J7XAHBsHZiE8SuvdPYCT1g/SaJz42fYrLQrrM0sMnMHeAE3eMEk04Rt3nRUd3h8hDkIfOJJjydjdVRfdzoCyo+ms/g7NJ49PXIBPDGLVc3cgNWJq+5mNAvf0SXsoRe2MXFOegFKqD4OnkGRbiS8miWDD2aYMm9m1MWfy58Ppfup6s98IYPqVpNLjmD/xJmeLrMnOPnITgcY4e3Bab3lXusg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <82fb70ca-25cf-6e06-968d-416798f65f79@suse.com> Date: Tue, 27 Sep 2022 08:35:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220922160516.5929-1-roger.pau@citrix.com> <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7677:EE_ X-MS-Office365-Filtering-Correlation-Id: f839abbc-b933-4963-06b3-08daa052741e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TsUipo7hJhzj2aQQusnLnpnL+n9oWeUInyl1tQptMHTQ58H3RsEOYShVWOXBdOIGgyGLb/LGkUCVvLHI5fRrcxrxBpXYDmvop/Tijx80AAF1HO1RFib3pyvb6s3J4aqkjAGhp3mz95rnOh/SqrKr9WYndL82VYLw6kMyiI/jPmR/zE/BRcmcJ/lwqSFvRfMQ/EeAVmvBhhDKZ//OJoV0Ka4BCdRASHs5DIkeLFsKy0iKTzhLqc+TEJ/OwO6PnBjHbMf/ip+QK5FBbQxrsa0esUYtVQfl2pvDBWDkSAp/xjnmxib1PuJQu/sbwHhP4EP4SCBIovYmpBLg/BS3fmOaQ1//gbPbT0LoX828Azvgf2FRw5bU4y6Izjyb0aH+Yld1i77CQ7CN9ZW8LEmU/mCyavX2SuUXWyFtQvoORbsemMNHUviCLgE3yRHpnwV9ICI+/V8KxHi3m8faT4/Uc4g3sNouWQvh3oR5dZT0xcKZ626mF2uPUXom96FzWOkbxpdFgvxQVeVpMYEW/BE/X989V+p6c0XvUbbcxX/F+IlkzlBowXbJKY4hAacgSOP9s/qEY4MADpTpmY0FnHG47MmUNITGSSIsimHrbk7lrEypPaluy+EtttRNpW3PeFFIkovRMF1P5lT2y4m+bn2Qi94Fr9k/NOAE1O3Gout553FDHpt2BBu6oYlbqhDWmCqCByYaKq11++M/d/0aEIrCdHQADW5oC429JnzzgxaiovGuPI7vB0OTwwgHNURB61CVjmxmCcHdt4gg4MtF9AhhcYl9d3NlZPbwzn8BRWmis/Yrpb8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199015)(83380400001)(8936002)(53546011)(186003)(6506007)(478600001)(316002)(26005)(31696002)(36756003)(86362001)(2616005)(6916009)(54906003)(4326008)(8676002)(66946007)(2906002)(66556008)(66476007)(6512007)(6486002)(5660300002)(31686004)(38100700002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkFzSVR2cE9SbkNLRVJnMHM3ZmNHQU5sZTdXWHBQRWpJb1ZXSEpPR3hSY09m?= =?utf-8?B?TnF3UHVNNVoyVSs5NnpqQkNZSXB5L3BkV1JxUTBwNVZCYTRnSTVnbSthVVVw?= =?utf-8?B?bWx1ZTl6c0RhYzRyVTlxdHZldmdwTGFwZk8reVJVN3FxUmc0eXl4L1NWNzNF?= =?utf-8?B?Q001RDMyaGJBNXB1MTlnbzhmeFhETCt4em1nWFdwZGZvL2V0c2tIcnV5UmM4?= =?utf-8?B?Y0pybEs4MXpZemJvQWYxVFBnK29JQ0d4ZHdXaTFxRCtzcmlpbXJsRWdNRGVL?= =?utf-8?B?ZGZPOEtIMEFlN096bGRzRDY1V1BzdlBaWS94dE9EbUp4OGFzd3hqZHFGZldl?= =?utf-8?B?ZWN3UnlUSHJwTkpPRUlnQ0U1MktkQjBjZzZ3Mmxxd3NTOEtydHU3SmwwcnNH?= =?utf-8?B?Sy9tbHVGaVBhSjV2TWk3cjhBTGx5VTZwMlRMZ1FDQjVRaTRxbE00RkxNelFK?= =?utf-8?B?Sy9aZXYra1BXTVF1V0pFamlrQ2tXNFhhbjdUMGdnUzBMTmNQbXVjUXZOaTB3?= =?utf-8?B?ZVpYczRyRndTTkdlaWdBOUtVOVdISTN6Y2xzZEs3RDRhZ1JCVE1kYWJWWm1q?= =?utf-8?B?QitOQlRocEVMZ0Z4QUpQTmRwcnIvbFRTR2NIVmVGMk5PNkZnR0R1REVpT2la?= =?utf-8?B?cmYrSlpQUmEwcXlNbncxVER4VnFQT1NuTHlONEF5aERzQm9neUxGV2w5em1z?= =?utf-8?B?bnhYNkR5TnpMcjVRcjVldlMySjZDeUs1VTJsOW5BeVhLb3pMY0p6SkhzSHNU?= =?utf-8?B?N0tzNUk4dTUzN1NlRno4ZXFkQ3JCeVd2dEdrMisvdS9WV1lvem1ya3ZNY2Jw?= =?utf-8?B?VzZVMVg0RnVlcmJRaHc3eXlrMytJUXFueHJxTXRsaW1iYWFtT1BMVDhvLzBy?= =?utf-8?B?M3h5OVJ6SHNxVWpBeXliS3hNSlBOdU9zQlozZmRrNWpRcEd2aVZ3WG9wbXpI?= =?utf-8?B?aFUwUmsvTW5Yd3E1VG4zejMvYWVVOGwwQmNqQ0t6MFhkZmI1V0xLVVNPcEdQ?= =?utf-8?B?bUp4RXpSNmRrZzV0eGx2Z1h1dE90MTUrdmJHNVhpWktpQWxuU1kzMGUwSXdG?= =?utf-8?B?YnZwbkc3R25SRkphcEN2a1JXMXdWakdQaXk5S2hUa2l0ZlBRY00zank3T2Q4?= =?utf-8?B?aHR3c2Q2dTZwTkNYV1c4QkhxMVRRZVpsL0djdlhYdW80eGFRU3N0NUZOekFw?= =?utf-8?B?SEhYYXBacGFwV3U0OFJucldpOXdvaWJONS83c3ZaOFR0b2JmOWIzVElsei9a?= =?utf-8?B?WUtWTUUzL2lRNUhWcVc5ZHN6RkM1dTdaZHhoL0JobHpaTlJjOXRoQ3E1c0ph?= =?utf-8?B?WlhWYnoyc1I3TERVejlubTdMM0FmR2ZJSWtjZG1mRUpyRzdESkRxcnBTUmFD?= =?utf-8?B?NXJsU29MdVRSeVpiQXpPazgrN1phMDU2YVpocExRWTFYaUV0UzY5OVJQeFdh?= =?utf-8?B?cjl0eG1pK1BUaWQ3NFp0TkdvektNM015cUN4Q0VBTklJZm9OTHY3VENJOUVM?= =?utf-8?B?Nmd5U3k0TlFmc1BpL0lPUFRWa29JVkJkbWtZU3JndEN4Y2FIRTFmTHBacmpr?= =?utf-8?B?Z2NJckdOME5JTXd3VXYyUHZwYUJZYWpRQ2lORUNBYS9CYndreWFHVUFZU0wv?= =?utf-8?B?TWpUcmcwRVR0a0dDL3J2bVVnZmdkQ3IwaytleEtJSzhBdjlNSHZ0eWVNRjQ1?= =?utf-8?B?N293ZFJwUE02NHpHYVdlOW5jTHlZMkNPUWJPcUtmRzYzQ2RPZEJYbUIzRTZk?= =?utf-8?B?TVZtTzUrZXNTbjFRV29PRmRzVmc2djNPYWxtR0lVYlp4b3BBR05pMzZPM0VY?= =?utf-8?B?M05KcTFGOXU2azlwanhWcFcxTklSeUdmQXN3a3lxYXBJZ1dpdVR6OGFteXpj?= =?utf-8?B?V3Z2dmR3bFgvN0YvMDRYYlM1UTk0VTFwR3l6MnErWVBRRFo1bzRXdGdjcmxB?= =?utf-8?B?RUFFN2orbnpKT1czbzUwTVowK1hFZmp6bnc3OWlxb3BaaFJoSk9GdGNvVWdH?= =?utf-8?B?OU1Obld0bnZlYTkwSXZFMVpHNlVoeGVNalUwdFI2VnpqYm5SN1F1L0wzMG1y?= =?utf-8?B?cVFsUEg0UlBzWk13WlV4azc4T1o2Y1RWZVZEUjJzMlBTZi9hSzk3SFNoTWpU?= =?utf-8?Q?xS/kxqH9++LzAv6DIjQq7DeNy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f839abbc-b933-4963-06b3-08daa052741e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 06:35:22.3014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lH8xlrb8nniy2RDTYHelf2clU5lScCna6ps3x4TWQYOXzxPoSvXtIRIc7gbrL+ymjiX+tKJVUSUI4JZNQIfYNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7677 On 26.09.2022 17:58, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 05:36:41PM +0200, Jan Beulich wrote: >> On 26.09.2022 17:25, Roger Pau Monné wrote: >>> Correction: the Arm memory_type_changed() needs to stay, as >>> iomem_{permit,deny}_access() is common code. >> >> Right, or we'd need some other arch abstraction. (I wonder whether >> long term Arm can actually get away without this. Even on the AMD side >> of x86 I don't think it's quite right that adding/removing of MMIO >> ranges has no effect on the memory type of accesses.) > > IIRC there's no way for the hypervisor to infer cache attributes on > AMD SVM for NPT entries, but maybe I'm missing something. Guest MTRRs > settings are completely ignored for AMD guests. Right, as documented: "Note that there is no hardware support for guest MTRRs; the VMM can simulate their effect by altering the memory types in the nested page tables." That's something we imo should do, but which I don't think we actually do (see p2m_type_to_flags()). We respect the PAT bit when splitting large pages, but I don't think we ever set the bit when making new / updated entries. > I'm not able ATM > however to find in the AMD PM how effective cache attributes are > calculated when using NPT however. I would guess host MTRR + guest > PAT? First guest and host PAT are combined, then the result is combined with (host) MTRR. See the tables in the "Nested Paging" sub-section "Combining Memory Types, MTRRs". Of course things are quite a bit more limited (but also simpler) in shadow mode. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 07:03:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 07:03:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412278.655516 (Exim 4.92) (envelope-from ) id 1od4cG-0007pQ-8p; Tue, 27 Sep 2022 07:02:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412278.655516; Tue, 27 Sep 2022 07:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od4cG-0007pJ-5L; Tue, 27 Sep 2022 07:02:52 +0000 Received: by outflank-mailman (input) for mailman id 412278; Tue, 27 Sep 2022 07:02:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od4cE-0007p7-HX for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 07:02:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 655578ab-3e32-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 09:02:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 95A531FCDB; Tue, 27 Sep 2022 07:02:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7685B139BE; Tue, 27 Sep 2022 07:02:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jQl8GxigMmNkbgAAMHmgww (envelope-from ); Tue, 27 Sep 2022 07:02:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 655578ab-3e32-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664262168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uq0Is0Sw0BisMCZPTteoAuarp+3efwf96ydoTTnd3oo=; b=kpt+FVcLNd1AsTejUsMQT6F8jln7VkcgqTvbEHYcy4+7MmqOIYhj6wwrakbOFgqZXeWz/C /dU9cFF+nC9b6c5AgGE8PnI8ghYzxMIG7W4RO+bu6IUoA8RgutdYaTQzBk6z6HJoP65fb/ GSY1FkU/b9Qdduv3UI6Lz3ssKUpc1ps= Message-ID: Date: Tue, 27 Sep 2022 09:02:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Design session PVH dom0 Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------geCXZkosMFoLeRx1cCvbE6Mh" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------geCXZkosMFoLeRx1cCvbE6Mh Content-Type: multipart/mixed; boundary="------------50QPqsKRNyKFHS0s0fCdvSFN"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Message-ID: Subject: Re: Design session PVH dom0 References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> In-Reply-To: --------------50QPqsKRNyKFHS0s0fCdvSFN Content-Type: multipart/mixed; boundary="------------dlrtoZK0xUTHQdi9nVeNiu4n" --------------dlrtoZK0xUTHQdi9nVeNiu4n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMTc6NTIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNi4wOS4yMDIy IDEwOjMzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjYuMDkuMjIgMDk6NTMsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIzLjA5LjIwMjIgMTA6MjAsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IE15IGZhdm9yaXRlIHNvbHV0aW9uIHdvdWxkIGJlIHNvbWUga2lu ZCBvZiBidWZmZXIgYWRkcmVzcyBxdWFsaWZpZXIgZm9yIGVhY2gNCj4+Pj4gYnVmZmVyIChl LmcuIHZpcnR1YWwsIHBoeXNpY2FsLCBTRy1saXN0LCBtYXliZSBuZXN0ZWQgU0ctbGlzdCku IFNvIHRoZSBuZXcNCj4+Pj4gaHlwZXJjYWxscyB3b3VsZCBub3QgbWVhbiAicGh5c2ljYWwg YnVmZmVyIGFkZHJlc3NlcyIsIGJ1dCAicXVhbGlmaWVkIGJ1ZmZlcg0KPj4+PiBhZGRyZXNz ZXMiLiBCeSByZXF1aXJpbmcgYSBtaW5pbXVtIG9mIDQtYnl0ZSBhbGlnbm1lbnQgZm9yIGVh Y2ggYnVmZmVyIChjYW4gd2UNCj4+Pj4gZG8gdGhhdCwgYXQgbGVhc3QgZm9yIHRoZSBuZXcg aHlwZXJjYWxscz8pIHRoaXMgd291bGQgbGVhdmUgdGhlIDIgbG93ZXN0IGJpdHMNCj4+Pj4g b2YgYSBidWZmZXIgYWRkcmVzcyBmb3IgdGhlIG5ldyBxdWFsaWZpZXIuIElmIGJ5IGFueSBt ZWFucyBhbiB1bmFsaWduZWQgYnVmZmVyDQo+Pj4+IGlzIG5lZWRlZCBzb21ldGltZXMsIGl0 IGNvdWxkIHN0aWxsIGJlIGFjaGlldmVkIHZpYSBhIHNpbmdsZS1lbnRyeSBTRy1saXN0Lg0K Pj4+DQo+Pj4gV2hpbGUgdGhpcyBtaWdodCBiZSBhbiBvcHRpb24sIEknbSBub3Qgc3VyZSBJ J2QgYmUgcmVhbGx5IGhhcHB5IHdpdGggc3VjaA0KPj4+IHJlLXVzZSBvZiB0aGUgbG93IGFk ZHJlc3MgYml0cywgbm9yIHdpdGggdGhlIGltcGxpZWQgZnVydGhlciByZXN0cmljdGlvbg0K Pj4+IG9uIGJ1ZmZlciBhbGlnbm1lbnQgKG1vc3Qgc3RydWN0LXMgd2UgdXNlIGFyZSA0LWJ5 dGUgYWxpZ25lZCBhdCBsZWFzdCwNCj4+PiBidXQgSSBkb24ndCB0aGluayBpdCdzIGFsbCBv ZiB0aGVtLCBwbHVzIHdlIGFsc28gaGF2ZSBndWVzdCBoYW5kbGVzIHRvDQo+Pj4gZS5nLiBh cnJheXMgb2YgY2hhcikuDQo+Pg0KPj4gVGhlIHVuYWxpZ25lZCBjYXNlcyBjb3VsZCBiZSBo YW5kbGVkIGR5bmFtaWNhbGx5IHZpYSB0aGUgc2luZ2xlLWVudHJ5DQo+PiBTRy1saXN0Lg0K PiANCj4gQ2FuIHRoZXk/IFRoZSBmaXJzdCBleGFtcGxlIHlvdSBnYXZlLCB0aGUgYml0bWFw IHBhc3NlZCB0byBjb2xsZWN0IHRoZQ0KPiBvdXRwdXQgb2YgWEVOX0RPTUNUTF9TSEFET1df T1Bfe0NMRUFOLFBFRUt9LCBjb21lcyBhcyBhIGhhbmRsZS1vZi11aW50OCwNCj4gaS5lLiBn ZW5lcmFsbHkgbGFyZ2UgYnV0IG5vdCBuZWNlc3NhcmlseSBhbGlnbmVkIChldmVuIGlmIGlu IHByYWN0aWNlDQo+IHRoZSBjYWxsZXIgbGlrZWx5IHdpbGwgcGFzcyBhIHBhZ2UgYWxpZ25l ZCBidWZmZXIgb2YgbXVsdGlwbGUgcGFnZXMgaW4NCj4gc2l6ZSkuIElmIHdlIGludHJvZHVj ZWQgcGh5c2ljYWwtYWRkcmVzcyBiYXNlcyByZXBsYWNlbWVudCBzdWItb3BzLCBJDQo+IHRo aW5rIHdlIHdvdWxkIG1ha2UgdGhlIGJ1ZmZlciBkZXNjcmliZWQgYnkgYW4gYXJyYXkgb2Yg R0ZOcywgbm90IGV2ZW4NCj4gYWxsb3dpbmcgc3ViLXBhZ2UgYWxpZ25tZW50IG9yIHNpemUu DQoNCkluIGNhc2UgdGhlIGJ1ZmZlciBpcyBjcm9zc2luZyBwYWdlIGJvdW5kYXJpZXMsIHRo ZSBTRy1saXN0IHdvdWxkIG5lZWQgdG8NCmhhdmUgbW9yZSB0aGFuIG9uZSBlbnRyeSwgb2Yg Y291cnNlIChhc3N1bWluZyB0aGUgU0ctbGlzdCB2YXJpYW50IGlzIGNob3NlbikuDQoNCg0K SnVlcmdlbg0K --------------dlrtoZK0xUTHQdi9nVeNiu4n Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------dlrtoZK0xUTHQdi9nVeNiu4n-- --------------50QPqsKRNyKFHS0s0fCdvSFN-- --------------geCXZkosMFoLeRx1cCvbE6Mh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMyoBgFAwAAAAAACgkQsN6d1ii/Ey/b xQgAiiDe76aoLdMXWMj8CliF6JNDDwZp7fzkIGhcIuEwSdcjxkDw9/IasZLaDHPbf+qSVUE1yqeY bapTsk47ZVytPz8pHrhAVM+a5YdG8dCLypl42l+52ZhPqwbtonOAsG0qBfw9BHjXcz0nuwFfZkPZ 0nu/XxZ+LNoYYWorC2UWzgU9ZZfaoQad+tWpSBGuG66ncuTo1hKuW8XiNsewzKHxLUWWxbi/3QHs 9007sSFE+/m5AJg8yoerY7cg37DLnNoupDUnbZOdUwhQMkLIFrmEtNvionyX0t/vuQMox3S6mKr1 vmqIzcPYkEPwHeIb1r5jlZ/GrhRQ6pOZtkrb5fRaZg== =npl3 -----END PGP SIGNATURE----- --------------geCXZkosMFoLeRx1cCvbE6Mh-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 07:37:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 07:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412284.655528 (Exim 4.92) (envelope-from ) id 1od59h-0003CW-T0; Tue, 27 Sep 2022 07:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412284.655528; Tue, 27 Sep 2022 07:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od59h-0003CP-Q2; Tue, 27 Sep 2022 07:37:25 +0000 Received: by outflank-mailman (input) for mailman id 412284; Tue, 27 Sep 2022 07:37:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od59f-0003CJ-Jn for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 07:37:23 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2044.outbound.protection.outlook.com [40.107.104.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37d5230b-3e37-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 09:37:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7668.eurprd04.prod.outlook.com (2603:10a6:20b:2dd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 07:37:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 07:37:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37d5230b-3e37-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqkMELclt0njwv8ap4vHRHf8iAviIFIaGYU4MEvCmzksEo4JDu5hOxhOJ/3UG/TyiTSvnhScg4Dzb9K0KJXI7uYrQI2NjO1E95F3oZ3BCGeX55keoP8KfYSA7NWQAfJekL15CmVN0fRy264A3hr6je2zAwnTphBEPSKIKIIi/0SsSrXRwWaFi0YQkZ631AJ2yMrx5buKMuKrAelt75Veg1zN5knHf/rWzPHvjArPAf6D5RTdtivL08BC9YXkiJJTkpvGPl1evRKIuDtTZXw6cT299q+mmsrklLLbY17wdtyr4tm5/93FCDJmRwkafb15BwySulomEGRqJqj+TvLxvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eHU4h0ZZTwlKDYTi2tVdKM39Nq25dJ6x/TLnolSi+6U=; b=fafalCZkb7JNk7rbfvJ133B2aO/+0SMZLhEhnALMmPAXQKGi7A74fts0ctOjrf1Vmxoo/cBJFdsMIR/wLd1+JbJ3Ew/mxtZ9eD20l4mKF7baX/sgcTyMxVFzvDi1AX6uLGea5+b9Apy0TNPFwUfXA1x2VTVAspCFBKsbygB/cPtNvn+UoQPEEYl5LJThBa8VSpdZxec3PPTDsp1bvkHngmiRFaO7YW65muFSiPVm9PswiXjZNfZ46VEmmW2EH6bj6zHhKpoPb2Su2LENjNvacYc2533tqK7o1CPKPcwUvAYP63estINOfQaeJ8rJKua6Z8xUIFSijzPNNpdbTcC2rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHU4h0ZZTwlKDYTi2tVdKM39Nq25dJ6x/TLnolSi+6U=; b=3j7UhX4XGa7egwamAaB2omIXOnmjS1Ue0A27bmogGRYbYCjY3sDE3YoNhDmalS9d/qiA0ThABcW8gHAXDLKGNOknFprpklc20VDABqMQstQ2otcq0ZEEqtpJYBrv43PwB0y3qAJa2MwOcnUmD+H7YKekO9+RI96acO4N78wmONa058PHlOyCGigrwh2AdyR+vCX2ZKkEBAUwEk1KmDZ9NkuDQEhoLJXR+AT+RVWIZyPYnIhyJ1dVyX/piZE/qr1jlv5PCW8QoTfrVQ1dYWMXJvsPoYLQPOXf3oVWBKOYTfmPJ9d62YbTLTHSQd5lVxR9f/ih473wfzOzeYBeW4rTeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5547335f-9e01-d461-f866-c0f823aa2814@suse.com> Date: Tue, 27 Sep 2022 09:37:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 1/6] xen/x86: Provide helpers for common code to access acpi_numa Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-2-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220920091218.1208658-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0058.eurprd04.prod.outlook.com (2603:10a6:20b:46a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7668:EE_ X-MS-Office365-Filtering-Correlation-Id: ef9e4016-1192-4545-2c11-08daa05b1a0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yaFp/vlIc/SCg58p3NuOo06jXlUWyMaUdeJGURS5ummDjLy7noO7ZMkWMmIvIEShaChA7Byat6T0h5ugAu2lej+zpHbpZCbEAzM/jW5b0eYSMmxjpOt6P1jdqhHbp9BsWP9M6URWLR2VI8AilpLVHPu4Rda8yPLT0G15CoNZ+laIr/Sr9NBJG6WSi5nWdAOplWIQP4udHh8BFFDn7Eid86ecUWHE2le43g6ITwAnG+RJYrivf9ldWpZ0coaXQp7gmBrJ3idqXF3PI89syqa6ArAHFzb5/EA5BQirDpS3/Zj/pSu4KHoG25Lguz90kk2CPXONvghPzMk+oMexbvh2tdzrxptCiE2qYSlv1wydp30AiOzeSYr6LBWJSeH1SMx6AAZWUgZN3OIHaUYiKMylEzJRUpVBY1eO1odeWCYmrQTJTQTAd4JCo19bUp2WqJYp29FzRxPIGV/w+uafSnCCCudKZzdamP+ZmTRh4Sl1SKWqMNg2SOmqveTUDkHp54MmtsXnoruEdkJYDQd5VCeJIh3XrIMfvP1j1TCF2te86W6Gl5t8K0ZgAaTSGrLYMU//qk53oHH2e3UPwXtwYn5f36zzVRyOIuVzbssW74kkk6dNSqQGY+QsQ8fLOgUCx6XQ3pjl1z10yVsuzla3hqbt8rusyC2MNh/eFdetMnEOiSjyoPulec0wltFGTv4C2DfACmqC5nVwfxxtHomTXFU37KEfGFCKXZmd3RWenet3bO/8sSRkgea6ljp5YRvxDS2lD7ZG0CvacJOi4etLi3shk4DvKw0/BJsPf06AYHwlqmE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199015)(38100700002)(31686004)(31696002)(478600001)(6486002)(54906003)(6916009)(2906002)(6506007)(8936002)(8676002)(2616005)(53546011)(6512007)(26005)(186003)(5660300002)(86362001)(316002)(41300700001)(36756003)(83380400001)(4326008)(66476007)(66556008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1RGamdmSk9WK0Zya1Z4dW9QbW9pcUJmdjdTY0lSc0ZDZXpEd1pJTXY5OUVB?= =?utf-8?B?cjZIeWNoQjB1RVExUklTeTV5VEhWc2xnb3h5RVlnZnk1VG81ZW9hWjBYdkIx?= =?utf-8?B?OFEvRHljMHNYdnI0dFZiU3M1enF3YkxOYjlCOVJKR1M1cFdxUFRETkdiT2hN?= =?utf-8?B?dEVqdVJBZzErdktDUlo4d205dkNSWmRpVlBYN0xzOG9HZ1JKTVdkOXBPOFdD?= =?utf-8?B?QjhtK3lUZWhOc1FFNzF0SCtoUm05a3ZYVndkbTFPS1BBdUJmRkpLc3Ztbmtj?= =?utf-8?B?ekJpOVlEUHBqVHY3ZUJ6dS9YZHVPSlBmM1BlbUs3U3VtdzM2WXNIMXh3N3E1?= =?utf-8?B?ZlVuRFNuZkd2aEFQb1pjRFRjRU0wU0RxNmtPdWtIS3ROeEdtd1lvdHU0V29W?= =?utf-8?B?UVVITkhBZm0wYUZ1TXJTem5tZDFKZjNONDhYUGFMa1gwL1psWmF3bDdyc1U4?= =?utf-8?B?QjdYeFNQRHR1SXJmbURIWGxRU0Uxa3V0VUdGbUlhaFRTbXNkbFNHK3k0OUZh?= =?utf-8?B?OUc0Ymh0VG1EM2R0SWV2ME5vYlhmY0Y5amZ3WUpZbU52WG53bjhqOGljQWg1?= =?utf-8?B?eFo0WVVkaDZ5bm5nNXgzMjJ4T0pYUHc4UmpqZVl2NGJGc2lMblJ6ZDZmYXg5?= =?utf-8?B?MmZDeFRDRkZ6V2w5UHRjZ2VDMUJlcmMwck0wdzV2Yi8vb2hHZWQ2ZVV2OEVZ?= =?utf-8?B?dDd0a1RSaDhRZE1SSGhGa0x4REw5RkN6WUEwRThPaVcvYnlQaC81V3BWSVZv?= =?utf-8?B?QjJFZmo2VXd1dWVpR3Izb2tMMnl4YUVubmNORDVZYWpaN0wydG1Wd1pHL3ND?= =?utf-8?B?eEx1d3JvUXZhVVV1TjNzREUxRXpsZzZaeXA3YTFUTHVlMlkwL0ptNmdpWkJI?= =?utf-8?B?M1ZSVGZFeG9DS3JkMzdBMkhnU21zQjc5eGY1bWdCdVR5QW01MDBnbXpuTW13?= =?utf-8?B?eFBUQU51UmhrcHV1TzZWSjlJVWJTdzd6WlF2TTZHTGdGa3l6RGJWWW9oNE9t?= =?utf-8?B?VnhtQUQySGUyOUQ1QXJncTEwdjhMYStqdGRlRFJmK29OVEtFeFJPZzFid1Vx?= =?utf-8?B?KzJ1cmtENlIxTzhSdGdmZkJXcitKc211VHRxck5ETXlIYnVXMWY2eWJmS2x5?= =?utf-8?B?TG1sWUJIYzlnSDJSci8rOHpLMnVySjdzdHU5cW9MTXhhRWVNMFBKSXhBbVMr?= =?utf-8?B?cDREaFhYS29vMHZ2MHE4WDdqRnFIQXF1KzdWcVpUOXFsRHdsVnZjQVd0VlNL?= =?utf-8?B?UnFjanp4NWFXV1d3SnAvU295cjFQL21uV0lKZEdNMVJMUHZXeWhCMUd4OC9K?= =?utf-8?B?OEVxUHRoemRZd29qL2VUSUVieEQwZm12M25JRmZOWmZiVXNZblZiQk5FRHpr?= =?utf-8?B?Mm54Nkk3R3lZZWIrMGRvL3B2RDVnUjFOUkZVOTVyeWhPV3FIaE1JK1plRHpw?= =?utf-8?B?bGUzeC9UckkvdmhXMHdhUjc1azh5RnJycGlkMlRJM0dHWS9ZMzBKZWRza0w3?= =?utf-8?B?RXZncGNJN1dkUVFzSHJXSjllYkRJRkg1cE9aVXhORGdvMXVURGFWVGZoOVNT?= =?utf-8?B?allTaGxqTlpXMEpIWGRyMkp2WU1veDNveERrdWVzUTBFNHlIajd3WWdIcVFB?= =?utf-8?B?eVRpM1BSQjRCWjVvSy8zZjUvdGZ4MG5Wcy8yL1RxeTBVZktkRC83a1pwazFz?= =?utf-8?B?em9ZL01vRGtUcHdpN3NseTEvQ3pqaHJCb25vYlJmZXdpeUdqRW1wOUFNNU5R?= =?utf-8?B?MC9SanY5dTJ3ekliOVdxVkQ2d0wyUkttMUZiZ3FxbE5aZ2VOTzBEMWFDK1JB?= =?utf-8?B?SDlucHZ4OHlLdjJFT0xYV1dTK2NJZ2toOU9lTXFMajFQSGhvYit1dWhIVEVa?= =?utf-8?B?aE8yMERGTzVaZFNRZ0tIb0llVlZzQjkyZGZwczdXQkRWandPeVhUaHBFSDQr?= =?utf-8?B?dkZlT1NPUnpmWklkUzE2WjI0RVZBb2VYYWpuTzFsM1FMOW9Zd3pzREFOcVJM?= =?utf-8?B?WWIvcllXUVphTFZPRC9RV2svc0wxL0VzZEo0ZFZPSys4enZpdzdlTWNBM1VQ?= =?utf-8?B?and2dEhzWWtFNWNSRExSb1cxdUZsdlNxdy9xZG9kWFhjem5zNk0rSDl1cjdI?= =?utf-8?Q?9nvBzuoTYT/3YV1Qrm5XuRV67?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef9e4016-1192-4545-2c11-08daa05b1a0c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 07:37:16.7226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Joa11ySRG+nx1Q8l++/LufloF/WgjoL1xm8roDRV8wyl6aLHzH6gpCbQ30Rgsd0/afM9blk8B+yL+gqka3f3JQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7668 On 20.09.2022 11:12, Wei Chen wrote: > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; > bool numa_off; > s8 acpi_numa = 0; > > -int srat_disabled(void) > +int __init arch_numa_setup(const char *opt) > { > - return numa_off || acpi_numa < 0; > +#ifdef CONFIG_ACPI_NUMA > + if ( !strncmp(opt, "noacpi", 6) ) > + { > + numa_off = false; > + acpi_numa = -1; When making the v5 changes, did you go over the results to check they are actually consistent? I'm afraid they still aren't, because of the line above: Here we disable NUMA, but that doesn't mean there's broken firmware. Therefore I guess I need to ask for another round of renaming of the two helper functions; I'm sorry for that. What you introduce ... > + return 0; > + } > +#endif > + > + return -EINVAL; > +} > + > +bool arch_numa_broken(void) > +{ > + return acpi_numa < 0; > +} ... here wants to be arch_numa_disabled(), whereas the function currently named this way (in patch 5) wants to be e.g. arch_numa_unavailable() (or, using inverted sense, arch_numa_available()). Of course I'll be happy to see other naming suggestions for both functions, as long as they reflect the respective purposes. Alternatively, to retain the current naming, the assignments to acpi_numa would need revising. But I think that would be the more fragile approach. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 07:38:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 07:38:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412289.655539 (Exim 4.92) (envelope-from ) id 1od5Ab-0003hW-6F; Tue, 27 Sep 2022 07:38:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412289.655539; Tue, 27 Sep 2022 07:38:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5Ab-0003hP-3L; Tue, 27 Sep 2022 07:38:21 +0000 Received: by outflank-mailman (input) for mailman id 412289; Tue, 27 Sep 2022 07:38:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5Aa-0003gn-8l for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 07:38:20 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5aac91ba-3e37-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 09:38:19 +0200 (CEST) Received: from FR0P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::15) by AM7PR08MB5416.eurprd08.prod.outlook.com (2603:10a6:20b:10e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 07:38:14 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::ed) by FR0P281CA0142.outlook.office365.com (2603:10a6:d10:96::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15 via Frontend Transport; Tue, 27 Sep 2022 07:38:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 07:38:14 +0000 Received: ("Tessian outbound 88978e6d60db:v124"); Tue, 27 Sep 2022 07:38:13 +0000 Received: from 425fed93396e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B07F808-6306-4788-8540-DCD43CDE2541.1; Tue, 27 Sep 2022 07:38:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 425fed93396e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 07:38:08 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB8061.eurprd08.prod.outlook.com (2603:10a6:20b:54a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 07:38:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 07:38:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5aac91ba-3e37-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TsTtju7eGcpFykBJ5Q5gFecDg4U+SewgWiSGv6Nf7vOzXXuD3VqHEurabX3Hiz/Vo6kxnUe+wp/4v2D/PJ+nDFGb0AxZDkZJ6l7pNrMNPZuhjA3zfjSksy8SbIrJ0eXRGLHa8oEky+TM49kBTr5OSmBdIhotyD/tZV+P3fRjqUHGb3olTdc7MCuzc07GMW6TkqXmgoAju7yzG9voCVCQFoACGKD8z9vPc+e4sEkMVeH642dRQPOfEmtnN2P8oZAWw68dnQ/5N8bcB/hyvsToBkdlkR/BY86LOY+ui4HBvNWN7qa5jmEaob9BqsgenUacOV8eDX4Q23kRxr5VDZSHvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ht4I+0YeiDPP0phOBIYrPc5ciYwDby1Kk4WiJzg+0og=; b=a0TtyYT2nuGhDZjGCnhlgxIo4/Z0GHsDwEghmI6BwZCRoYhNWuBMBBHwNxQ4xwUKq1erFgE9dnHlXNdVl4XkGmUKXtej5FJajH3JOYHTPvaqzkD7GyNemrqSb7p5z1G8UBg7xTIWPLHdmrJXjZ+uQGCuPpqtMbjgDcZP62yDLVmVSMYjGOAsdesNelMvksGTXRQsRplJnh+XHG+bF78hz4hNKwgKFccqgog0rJZLsxkT9zBG/Q3KO8WjxcLsDUxofDbz/5QyWXFJKevCnb+s6JhfSEYVqWKQMgfuRyONYGXq0z0jDYEAaa9iDQEgzeVXotmhI04gxvpEartxYVk/lA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ht4I+0YeiDPP0phOBIYrPc5ciYwDby1Kk4WiJzg+0og=; b=KfQM6rm42QKeHzcLnXdkcXY3I6Mm4DFcmv1xxDYOkDLkwuQxJ85DI5XmO422GJ6vz8cViexobr9i6Fn37ZXk6cqfh6Xh6ehBXjwkcdnpYpaL53sPpBMyPkdxgltzTgt3Qf2fyG1Foy19HmGQhD5QykkPZwGeQaVpBuMC/7e+z3Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jg/NnedCeHB6+P6rjkd3rAUn6U2KHa2Eif6fxoejogIwOr3U5rnRs3qFyZ5kgk4GsRWByCGxp+Dh79vczWzVswZzQurCdxI9ZDuIv8buTtiqNXSohUmEWSJkRaC2rV50xZ4iqF1hJqIdNcSeGgJhTIFr3MNp+Jfr+2EQC09yInNug+XLwxqK0gqVv9O44XvDn1q3Va7es2Gj9NV0ADhNAEeAnCCVGmHm97mjm2zJZWq0vvz3siLFkaSBesP2xImsQbnxLtM7OHxEHzaSznBGrYmKnFgKUf1T59de/LNoo0Fjso4dkolqiqirQ0AVIiszFKtH+3scKJK/sF01CYuMRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ht4I+0YeiDPP0phOBIYrPc5ciYwDby1Kk4WiJzg+0og=; b=n8zz4y1qjqFefBLL1+ObXiNJm6eVVrkGwaLkmBz1i2HVlcNKSvZzFLJr9Fx1ppYld3BFWbEwaPMmYwOxcgCUnhk8wgDP6VPV3YRYDtsSBoSLIltZJjTila8jChsOFj2qusl1HF+NtIvL6z5tcJnlKNtYltGhWKcMHzuo39S5NcmnWBcyjbjgzjTqzP3pcEwmnoErPydvcYYMfMDmi9RaovSDD1TNWkc5z/hTu3bcMgN3vh+smyBYXB4G7kiBja5iKwx9ojZUcC5lPBNaJTx1IKjk86ADx3z4DCXy814pRqqjJvd9kjO2iWDpH3Iwmp0Z3VA9H5zABGr5CJjGJ5Q1oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ht4I+0YeiDPP0phOBIYrPc5ciYwDby1Kk4WiJzg+0og=; b=KfQM6rm42QKeHzcLnXdkcXY3I6Mm4DFcmv1xxDYOkDLkwuQxJ85DI5XmO422GJ6vz8cViexobr9i6Fn37ZXk6cqfh6Xh6ehBXjwkcdnpYpaL53sPpBMyPkdxgltzTgt3Qf2fyG1Foy19HmGQhD5QykkPZwGeQaVpBuMC/7e+z3Y= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [for-4.17 v2] xen/arm: domain_build: Always print the static shared memory region Thread-Topic: [for-4.17 v2] xen/arm: domain_build: Always print the static shared memory region Thread-Index: AQHYzFcKT/X2LltF0EuIADJGc5zC763y7yBg Date: Tue, 27 Sep 2022 07:38:06 +0000 Message-ID: References: <20220919183737.14067-1-michal.orzel@amd.com> In-Reply-To: <20220919183737.14067-1-michal.orzel@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D9304B1C3367F44BB4DD03AED5985DD3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB8061:EE_|VE1EUR03FT009:EE_|AM7PR08MB5416:EE_ X-MS-Office365-Filtering-Correlation-Id: 33ced3e5-a5bd-43fd-ffde-08daa05b3c5f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: llFFmXZJN0EIrODkI7kj9dUYK2RYJ+rQulSMIWrR0Zz9f0LU2qEkJQlxab2nwIdo1dV0qFuu6J2NbFbyyiEEolUeaipcc/h1wAW8O87xZG4sUKb57I0G9IKpLEl/yqoB/3GIZ8MpFyoe6/zVPKC/e21n2dUNMOcTB0nLQZrS16fo8FxMlxqNDwAdknqiYjiyLxKt8iulb9SHzb6IJfeP2HC8fkfMr79qinovb1rpy7Uzzc+CTFz/4dW6qGOWAZv+yuoKR5yQrZYkGRJTO4+P4LgPUN1SgTTDMuk5BGP18Lc/0xx7MXHhqC2s9+oxh2MFdShebuHcZp92ww+cyaUdNRuo9OKDt9LzJihRv4FaOPKBLUofqwkrxpH3YmK8ZCCQZ/1KWzq4PA15x/YIdg40aRxF266ukU2rwVg+8Wwr3FAAFUfQge5K0S3gPMygeLxToHB2YNm+i04Sdg8N1sdAu17DPCl8qlfJcRs4jD5W7r8OBY6OwyhAjOLy+iznzwzYgdLJcFh+K+KvusEVGcqgeQ1ZfNeJCyloead+MK2SKFdj5TQNT8b/bwJ6mOtorChhQvXHk+nfOU4qgZbRjM5h4BnzRbsO7Rx3jMv2ck2cyh+KdOa8lsCtttL1AaWL4v/NbPC8V9zK/+WC7hGZnwLZfRMR+Ri6YpnmbxZroLhU4mNponXzzQ4l8jcxU6EB30OZjazzqF1aIEJGY0WS0DsbmwtPRJnIaPZDyOki2h/SK77mcQa6mhEuCfBtZNklqlb3PFyilDeyhzYS9GuDAzi9zA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(366004)(39860400002)(136003)(451199015)(33656002)(71200400001)(38070700005)(2906002)(478600001)(86362001)(110136005)(64756008)(186003)(54906003)(316002)(4326008)(41300700001)(66556008)(8676002)(76116006)(66476007)(66446008)(55016003)(66946007)(8936002)(52536014)(6506007)(122000001)(9686003)(7696005)(5660300002)(83380400001)(38100700002)(26005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8061 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 65fe047e-7c1c-41bc-0545-08daa05b3793 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /3/mavm1mW+gLcJopDDtXxgQYKphBkNNUBx0I8qHttoK2bMWW/smf732fIbY83vdGhe5/3iOTx9arqsVYMJmY0VINJe/uTpTm9yOsATyKTwurP34CbUvjvtM1V7567wnSmUcbYtPUt/aIWxdWNGTKix9ZwdtfEqFIN6cNsJ0leXep+1UwTGAUx1e71oe/VliYJ+BI/SeG6G/qESD966zlSm7uLQC4Pm0TWVE49j63I2l9YtoHj23Ulusv26JLhjiwIYQhbWimDW9Ar0MKSns1K3ow+ZVSwmAdkwI6/ae16YCkBabc5YIB56LhvJ9ZMjNfTv4y8Nw835HTsPFrp3Z9oCWy7R0B61cB3EyYg0Xm3857LFbnX2ep+cchVTfJ6iJuxDrM5H1IIH7vo+1wMwLjHlG6kQCShHBOF38/Ke7TkvwmuxEV+TXHKMgQkz/6QVzYci7IkMjL2S6iu86fmw3l227J2bWSCxnC+4HqpKWV+CE8Q5cGi74qjfxfat5i6qGZrM/ZQvywQrLvhrLuPmFcX9oyYhWB2VgPhOCinMT8Ce6lRikld5RZN9RaLoJCOjj2c2Y9ICNbbUO5ifAJ1DvgYL80evXOhEk/vr4YdkohcPsTsR6cupU6D3ll0Tn1bFR1FRn23e3xRD9K4dUq7NP9hPBmxvoxf4hviZoLoBB8wWalFF6WG9JrqwUuW0id/V05SFKYVc++o7DAOKobPXOzAGWta9ALAblUIzHUH1fXt7ANS6t5YEwPvT78d1oVmUrUc6ldv5bmIq8jHfZcMDe+A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(47076005)(336012)(9686003)(26005)(82740400003)(107886003)(8676002)(4326008)(83380400001)(70586007)(54906003)(110136005)(81166007)(6506007)(7696005)(33656002)(41300700001)(356005)(40460700003)(70206006)(478600001)(86362001)(316002)(36860700001)(2906002)(186003)(82310400005)(52536014)(5660300002)(55016003)(40480700001)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 07:38:14.0645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33ced3e5-a5bd-43fd-ffde-08daa05b3c5f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5416 Hi Michal, > -----Original Message----- > Subject: [for-4.17 v2] xen/arm: domain_build: Always print the static sha= red > memory region >=20 > At the moment, the information about allocating static shared memory > region is only printed during the debug build. This information can also > be helpful for the end user (which may not be the same as the person > building the package), so switch to printk(). Also drop XENLOG_INFO to be > consistent with other printk() used to print the domain information. >=20 > Signed-off-by: Michal Orzel > --- > The other motivation for this patch is to be consistent with regards > to the format of the informative logs. We do not really use dprintk with > XENLOG_INFO unconditionally as it results in printing additionally filena= me > and line number which may be misleading for someone reading the boot log. > Such extra information is helpful on error conditions to make the process > of debugging easier. >=20 > Rationale for taking this patch for 4.17: > Useful information printed always instead of only during the debug build. Sorry for the late response. Release-acked-by: Henry Wang Kind regards, Henry >=20 > Changes in v2: > - use different argumentation > - drop XENLOG_INFO > --- > xen/arch/arm/domain_build.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) From xen-devel-bounces@lists.xenproject.org Tue Sep 27 08:08:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 08:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412303.655550 (Exim 4.92) (envelope-from ) id 1od5dP-00080B-Rf; Tue, 27 Sep 2022 08:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412303.655550; Tue, 27 Sep 2022 08:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5dP-000804-OD; Tue, 27 Sep 2022 08:08:07 +0000 Received: by outflank-mailman (input) for mailman id 412303; Tue, 27 Sep 2022 08:08:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5dO-0007zu-1h; Tue, 27 Sep 2022 08:08:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5dN-0005Oy-Kz; Tue, 27 Sep 2022 08:08:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5dN-0008FP-6d; Tue, 27 Sep 2022 08:08:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1od5dN-0000GL-6A; Tue, 27 Sep 2022 08:08:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=h7DlsGJ3LFMlUFzb9q7Ge8CJTxJy1//B3WWf7whnrkg=; b=Tonqcp5s9hPEHAufIZjYAgJ+D+ Xu9yNrjWoIqHYMSwCNI5wNh5GMrvapmktdsGp7CxHR32RApchLWlFcDbMPRyOFzt7boG9mFrC7t/l 6f0P9ulOWP8hyguEOLBlPsokXRg9tDCGH2Fvh6SqQzWczr9jpsM9V9i/uVSjy4/W6NDc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173322: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bfd3e9945d1bc551ad11272c7fa752ff3d060149 X-Osstest-Versions-That: xen=bfd3e9945d1bc551ad11272c7fa752ff3d060149 From: osstest service owner Date: Tue, 27 Sep 2022 08:08:05 +0000 flight 173322 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173322/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 173316 pass in 173322 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173316 pass in 173322 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 173316 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 173316 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173316 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173316 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173316 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173316 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173316 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173316 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173316 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173316 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173316 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173316 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173316 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173316 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen bfd3e9945d1bc551ad11272c7fa752ff3d060149 baseline version: xen bfd3e9945d1bc551ad11272c7fa752ff3d060149 Last test of basis 173322 2022-09-27 01:53:14 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Sep 27 08:19:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 08:19:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412312.655561 (Exim 4.92) (envelope-from ) id 1od5ob-0001B9-SS; Tue, 27 Sep 2022 08:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412312.655561; Tue, 27 Sep 2022 08:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5ob-0001B2-Pl; Tue, 27 Sep 2022 08:19:41 +0000 Received: by outflank-mailman (input) for mailman id 412312; Tue, 27 Sep 2022 08:19:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od5oZ-0001Aw-VF for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 08:19:40 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140084.outbound.protection.outlook.com [40.107.14.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 208e6d3e-3e3d-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 10:19:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7798.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 08:19:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 08:19:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 208e6d3e-3e3d-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PeoXYerb3GnX++VCOmuPLmbwjOxBZLy/prI0844fc034yGTC+zeEE9iFwY8h6TuJrwXe5wUxpgEsM8eUB+n5s/dQdKl+pYBk2MTbys4PIoF0Za+8M6uSWU2IkyVAaNLFNHP6RrKLR334P/JOYmEEA86rOxAdtTogOGfOjkarV0e0KxusJ6oG8+EFyLCgabdFQ/9hOLp9pUstgDnhqJLCaEqOmf8liWv7cxF4ttr70wanpByBnOpqHCpbrO8/DMhM+gfCTaJvNtMwWk6M4c58qGpGvBchGLKuJyGolY0MziEPtGowg8GIbLdX8Fy0b/u6fHDIWvR+pyyUogcvYtlgUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yAzkf1MsGwcWu9aN2ZBcnYe91RZZv8KzWyU2D+Ok9aU=; b=ZOprF2vt9J67FFI4iRXPaOghBKmebM20zttb+nQl4ySm3ABQtYBvtz5ZZIR6CUQP0OYPEUZlgRvHOxK9bAEqQljzM3TI9kC9WJ6HizndmLXS8oNrzndMkleNXW3EbAwLRklRcnFXMy0odkWqix3twtSvlXajh1SWUc+tDIdf9BzIA9OOnYSZGsqEJYPDoSD8pZoUJSWEspziFc9gnr3JuTzUU1D0l9Z0GhPcj/vHEW09oTnFsrK4mk3AmjeLBYadttAuWiysddU7Psar0z3qlxz3cvygfOf3Wej32sYsdxmjS0dsbbulz44QpdBkXZhc6lTJZ1UJ8QH3RZzyxg8mPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAzkf1MsGwcWu9aN2ZBcnYe91RZZv8KzWyU2D+Ok9aU=; b=n0bSmyxvlnQEOttZgnl0jp5kKOXooyXqYPRc1ohkyc5Rl9SfVcyKx29/aBqItwvtlc9s8ReXCqYTND9MpHVARJKpJ6cnj6qUa0hckczaqqwlBD62twXnyac8sUQ2iVmR5YVj41zxMgiTbijbikhFvqgWe2POUYD19l8Lp2X0gqK85tOcrZB+ySnRisf8RYkUiyDO7Y/fHQsBdb+4KDWuSV5vVrmgtCL0RaVw7S9jl93fSD3TMBEipEcq/WY15Z99wKizP0UbRsVmMk/pcCoID260Al2p6XhPT9hHHeqEFoYS/E2/kYGKo9jZ5DYgPg6tFKDl8FOTJGYsUs9TfB9ICg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> Date: Tue, 27 Sep 2022 10:19:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220920091218.1208658-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0044.eurprd07.prod.outlook.com (2603:10a6:20b:46b::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7798:EE_ X-MS-Office365-Filtering-Correlation-Id: d21902ca-a4d3-45e0-cd5e-08daa06102be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ys/FRjrIPmVQIWAo0PyYQc4Y553Q1Wq6I/GsNTYwkl+1w+F0Suq+d+5PDcciBI3aKZXWoO80DsRVgVFAnjTF6RT/gvxhO2L5dKUlPmiwptiGHfjWNfihyf8NqptXiNB6J/49ANhjbsH/7Td8BgSKtHIKVeXxi/EL/jcvuufWjNWs6VYrGacWngtVlwpcHDCc3JSZyecHMQE58eUv7c9GEK3WKb2hmrt785GyjtflQnvBgNPbkT0JMEZJ3iQ7PiUWqpIR8i41xrU/J3dQvmXFRV9ktCTxEGv1omCBtMc+jwyksyZ1miPfGhOU2wLqDiRt7gu71UTdxMioLUUo/PAcafXz2C2gJCdFJaxhR79/8FA6CgYNZFZB3tNpJjN2amQFCrre7+pqarLL5CbyHo8851fcLMbV2Rp+68kYPhohL7jZwCzG4xFK84Dh39REOPrt2EaO6uco8XLsgXQJG4mZ/wBp+Br1BneYoHPgrhu1eMX5ceZRAdskAd5H8yOgp0PB6QVyLY5a807fThd5VTJ0/5I4tHaKgXonKZt1F/QgHw+8RtAPp72ztEe+K2sfEEDBsUk1DEwDjMkRuylSTKcULA0ZcbaOCRSmYdVWbarJyUXzNViHc97vefxkN/bRwW4Uec3JalsJNhKQ6S/os9NngqsM5d0Q/k+q36aMD1EZIeT07aZCWiyxtI0x/ga018e8XAcK/sUcZcLoSNdzw+yy4AOPUnwLaIGaMRTVyKZInsdtCNDNdm93TpjNGGp6DsdNEYZOsc3bG1+3G0MwFqZlKdiK3oohN34LwN8P7i76i5cziWUeRsQz9uX6ZzTi9Qvx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199015)(6916009)(54906003)(316002)(38100700002)(5660300002)(36756003)(86362001)(31696002)(8936002)(4326008)(66556008)(66476007)(66946007)(8676002)(26005)(6512007)(2906002)(2616005)(83380400001)(186003)(478600001)(41300700001)(53546011)(6506007)(6486002)(31686004)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXhlUG92ZjV4b3lFWnBzYVdza0RXR3d0bzJvbnNHYVI5WHlEU3VMZm9QYmpT?= =?utf-8?B?TG1pYVUweFlxdHRYSE1xNWJqQ2c2WmFWUzZtRkM1VUdxSUJaRnlOQ05BU01y?= =?utf-8?B?ekdyZGZCaThtNHkrZkdMRkw5TEZneWZDVE9Rbkw2Y2lIRDhDOFJkR1VjYnlB?= =?utf-8?B?M3czVGUzaDlwUEduQTR5cmZSeW0rR1hiTWlnMG1veFQ1YTM4VU8wSXQzb3Zr?= =?utf-8?B?TXBGc2dGZUh6Vi8xb21sbG5ZQllDbFRQNkh1ZU9wWE9KRklYa1VTS2dsbmQy?= =?utf-8?B?ekVpS1VueFBDcDVvNXVQNkI1ZXlsN3ZQRVFidXJSdVd6S2xUbUgyNHE5Q2lB?= =?utf-8?B?MFpwQXVFZHpmR2s4RGtxUTVZTEY1UHc1bVNBcjZOb1FsbXFkMFk2L3g5Yk8z?= =?utf-8?B?cjBqbVU2T1JWd0N5MEhYMGxDUngzb3l5OSswZlRvY3pETjBVOEhWaWRNOG11?= =?utf-8?B?TVBqRXRKSHdWd0xQSzhzQ1dyTEw1a2lhdm5NSjFodjMxMXhzcVpra0FFcU9U?= =?utf-8?B?ZkZ3NFBnKzl1YW1Ec2JNOGZlZDNtYlZ5WG9SS1JreUZYU1hUb1BLUmhRMEd1?= =?utf-8?B?eWFvN2tKcE5xc0NmRHlYV0hqaWZiaitwSE9saGtpVmhFTDc5MVVMMHlrdGhK?= =?utf-8?B?bmdPejduSk14ZGpNRXgxZWVYeDlaTlRNZ1lNaW96S05lREJLTC9EMlZ1eW8v?= =?utf-8?B?Vno0NTRGaGJvQ25FdlhSSnc0aW8yRnd0eFRRSmZpcHpIbE53eWpJT3Z0OGQv?= =?utf-8?B?UE00RklwUlhOVFhRSGwvUkYvNm5IM1locU9DVXhZdW5nY0ZYeVkrV3NIa1Rl?= =?utf-8?B?WDJtcGw1b295UzlobWJNYTB3NDloYXhzQ2t1NGVkdysyNDB1Qml5TFVrcTJq?= =?utf-8?B?UUJIM09Oek55anFEa28ybGRGYlZXLzJjTVY4Zis4dHRhdVJwd0dYMTZQNllY?= =?utf-8?B?dTlTVGFYZys5cHBWRlllTjdFY3o5UTZxaVN3Um5YVC8rSldBZ1JXOWNmVWZs?= =?utf-8?B?TFBHNmg5YXo5dHBJNUJSdE55YnJTdUZkempmTGJ0YldaT1lkNEZUbXBYUTd6?= =?utf-8?B?UWhteGJBZUMxYmZGZFN2ZU5QRGhtWXhvTTFkU2ZIRE0vbTNBOTJxOWg5b0c0?= =?utf-8?B?U0ZVTDFoSTVpanB4UGpwMHZyQWU3RXN3MFlQN3JMMk80YUdPVmZDWWJrSFpV?= =?utf-8?B?QzJnaXVZRldnc3FrNmhpZDdRYVM3cnFpbDFMOVJlNWNxdDdISWdveEVETUtN?= =?utf-8?B?RjRXUTRUU3oxMjh2eENLV3ZmeiszbStuUVkrQWtQUG1ka3NaUkJZRmEwWXgv?= =?utf-8?B?SkdhZlBlbWlLSVhML28xWUNNN2Q2bWxFSVl0L2ZtVDhQb2F5aE1ZVEZwcFN4?= =?utf-8?B?eUMyZ0s4ZThwdENYWkJsQXppeXNzeU92UUticGpMZW9tSzlXU0dWeUR1Zlh3?= =?utf-8?B?Mm1SUnlaUllocGs5NkRHcjYzS1diejZFaWpIa296aWo1WEkyVGJsZWg3VDR4?= =?utf-8?B?NURORUVCUEhXdjNlOVlISnU1Q0daL1BiOWxMWlVpdzJrTENPQ2laTGdZYkdv?= =?utf-8?B?ZXZEZjJ1QXhyWVRnYXhZSW5ybUN4VWhPWU83NHBCREdjZ2k0cFQycGdMeHha?= =?utf-8?B?NFZBM0NWWGc2Q0J2cFZtN2Z0YWRBNWduRE01S1Z4NGNVNU95VzQzeVpkY2FN?= =?utf-8?B?T0NPZVdENUJoRG1rdzdDalNuYk5BM3Z5Vy9TLzIvWitIMjhObXRZUGN0bmJx?= =?utf-8?B?MHNaVzFHTXNqeG1wczJRTEJvRS9WS1JleUFQY2xQaXlleVcwYzNVekIzMG5R?= =?utf-8?B?N3ZRaDVPNkVLQ3pvQ0xtY2NXZ0hoeENKVlU5RXFzb1dBeU54YXkwTC9EK2ND?= =?utf-8?B?U0Q3NFAvU01ObWk4R1RaN25hUlJRbmZRNlN1MVpXdXVac2FkaEhIZWlSNlNr?= =?utf-8?B?cDA3MU8zSmlDd24vcGRWL1gyemtmS1EraUFadFltdnZSbzlHMXQ1UGxoZGI3?= =?utf-8?B?djdCWS8yWFhnQlU1RGY3ZnlURE1ZL3VkWDBwOWpSd1NUbGUrdHQyU21mVUI2?= =?utf-8?B?R2x4QitkRjhta0t2SzNKMjFJcnBsOS9YU1N1bGw1enpJRHNUOWUzdVY2NlJT?= =?utf-8?Q?uOeKRAFW/a9Co/tMz7nnCbD/Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d21902ca-a4d3-45e0-cd5e-08daa06102be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 08:19:34.6239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IASMdiOBKAMA/16F2cgrOjzI6nrCiWhO/1+s3amOq+ztteMbTrxAdaGNKuW6YKvZiKh0u3ZCY0CBhsGfuPrLYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7798 On 20.09.2022 11:12, Wei Chen wrote: > There are some codes in x86/numa.c can be shared by common > architectures to implememnt NUMA support. Just like some > variables and functions to check and store NUMA memory map. > And some variables and functions to do NUMA initialization. > > In this patch, we move them to common/numa.c and xen/numa.h > and use the CONFIG_NUMA to gate them for non-NUMA supported > architectures. As the target header file is Xen-style, so > we trim some spaces and replace tabs for the codes that has > been moved to xen/numa.h at the same time. > > As acpi_scan_nodes has been used in a common function, it > doesn't make sense to use acpi_xxx in common code, so we > rename it to numa_scan_nodes in this patch too. After that numa_process_nodes() now? > if we still use CONFIG_ACPI_NUMA in to gate numa_scan_nodes > in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA > will be selected by CONFIG_ACPI_NUMA for x86. So, we replace > CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_scan_nodes. > > As arch_numa_disabled has been implememnted for ACPI NUMA, > we can rename srat_disabled to numa_disabled and move it > to common code as well. Please update the description: arch_numa_disabled() appears in patch 5 only. Of course if you follow the comments to patch 2, the wording here would be correct again. > +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, > + nodeid_t numnodes) > +{ > + unsigned int i, nodes_used = 0; > + unsigned long spdx, epdx; > + unsigned long bitfield = 0, memtop = 0; > + > + for ( i = 0; i < numnodes; i++ ) > + { > + spdx = paddr_to_pdx(nodes[i].start); > + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; > + > + if ( spdx >= epdx ) > + continue; > + > + bitfield |= spdx; Perhaps to be taken care of in a separate patch: We accumulate only the bits from the start addresses here, contrary to what the comment ahead of the function says (and I think it is the comment which is putting things correctly). > + nodes_used++; > + if ( epdx > memtop ) > + memtop = epdx; > + } > + > + if ( nodes_used <= 1 ) > + i = BITS_PER_LONG - 1; Is this actually going to be correct for all architectures? Aiui Arm64 has only up to 48 physical address bits, but what about an architecture allowing the use of all 64 bits? I think at the very least we want BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG) here. > + else > + i = find_first_bit(&bitfield, sizeof(unsigned long) * 8); > + > + memnodemapsize = (memtop >> i) + 1; Again perhaps the subject of a separate patch: Isn't there an off-by-1 mistake here? memtop is the maximum of all epdx-es, which are calculated to be the first PDX following the region. Hence I'd expect memnodemapsize = ((memtop - 1) >> i) + 1; here. I guess I'll make patches for both issues, which you may then need to re-base over. > +static int __init cf_check numa_setup(const char *opt) > +{ > + if ( !strncmp(opt, "off", 3) ) > + numa_off = true; > + else if ( !strncmp(opt, "on", 2) ) > + numa_off = false; > +#ifdef CONFIG_NUMA_EMU > + else if ( !strncmp(opt, "fake=", 5) ) > + { > + numa_off = false; > + numa_fake = simple_strtoul(opt + 5, NULL, 0); > + if ( numa_fake >= MAX_NUMNODES ) > + numa_fake = MAX_NUMNODES; > + } > +#endif > + else > + return arch_numa_setup(opt); > + > + return 0; > +} > +custom_param("numa", numa_setup); Note that with this moved here at some point during your work (when allowing NUMA=y for Arm) you'll need to update the command line doc. > +static void cf_check dump_numa(unsigned char key) > +{ > + s_time_t now = NOW(); > + unsigned int i, j, n; > + struct domain *d; > + const struct page_info *page; > + unsigned int page_num_node[MAX_NUMNODES]; > + const struct vnuma_info *vnuma; > + > + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, > + now); > + > + for_each_online_node ( i ) > + { > + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); > + > + printk("NODE%u start->%lu size->%lu free->%lu\n", > + i, node_start_pfn(i), node_spanned_pages(i), > + avail_node_heap_pages(i)); > + /* Sanity check phys_to_nid() */ > + if ( phys_to_nid(pa) != i ) > + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", > + pa, phys_to_nid(pa), i); > + } > + > + j = cpumask_first(&cpu_online_map); > + n = 0; > + for_each_online_cpu ( i ) > + { > + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) > + { > + if ( n > 1 ) > + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); > + else > + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); > + j = i; > + n = 1; > + } > + else > + ++n; > + } > + if ( n > 1 ) > + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); > + else > + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); > + > + rcu_read_lock(&domlist_read_lock); > + > + printk("Memory location of each domain:\n"); > + for_each_domain ( d ) > + { > + process_pending_softirqs(); > + > + printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); > + > + for_each_online_node ( i ) > + page_num_node[i] = 0; I'd be inclined to suggest to use memset() here, but I won't insist on you doing this "on the fly". Along with this would likely go the request to limit the scope of page_num_node[] (and then perhaps also vnuma and page). > + spin_lock(&d->page_alloc_lock); > + page_list_for_each ( page, &d->page_list ) > + { > + i = phys_to_nid(page_to_maddr(page)); > + page_num_node[i]++; > + } > + spin_unlock(&d->page_alloc_lock); > + > + for_each_online_node ( i ) > + printk(" Node %u: %u\n", i, page_num_node[i]); > + > + if ( !read_trylock(&d->vnuma_rwlock) ) > + continue; > + > + if ( !d->vnuma ) > + { > + read_unlock(&d->vnuma_rwlock); > + continue; > + } > + > + vnuma = d->vnuma; > + printk(" %u vnodes, %u vcpus, guest physical layout:\n", > + vnuma->nr_vnodes, d->max_vcpus); > + for ( i = 0; i < vnuma->nr_vnodes; i++ ) > + { > + unsigned int start_cpu = ~0U; > + > + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) > + printk(" %3u: pnode ???,", i); > + else > + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); > + > + printk(" vcpus "); > + > + for ( j = 0; j < d->max_vcpus; j++ ) > + { > + if ( !(j & 0x3f) ) > + process_pending_softirqs(); > + > + if ( vnuma->vcpu_to_vnode[j] == i ) > + { > + if ( start_cpu == ~0U ) > + { > + printk("%d", j); j being "unsigned int", would you mind switching to %u here and below? > --- a/xen/include/xen/numa.h > +++ b/xen/include/xen/numa.h > @@ -18,4 +18,71 @@ > (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ > ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) > > +/* The following content can be used when NUMA feature is enabled */ > +#ifdef CONFIG_NUMA > + > +extern nodeid_t cpu_to_node[NR_CPUS]; > +extern cpumask_t node_to_cpumask[]; > + > +#define cpu_to_node(cpu) cpu_to_node[cpu] > +#define parent_node(node) (node) > +#define node_to_first_cpu(node) __ffs(node_to_cpumask[node]) I can't spot a use of this - perhaps better drop than generalize (if done right here then along with mentioning this in the description)? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 08:41:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 08:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412321.655572 (Exim 4.92) (envelope-from ) id 1od69D-0004f8-Nq; Tue, 27 Sep 2022 08:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412321.655572; Tue, 27 Sep 2022 08:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od69D-0004f1-L2; Tue, 27 Sep 2022 08:40:59 +0000 Received: by outflank-mailman (input) for mailman id 412321; Tue, 27 Sep 2022 08:40:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od69C-0004ev-IQ for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 08:40:58 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 198bf316-3e40-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 10:40:56 +0200 (CEST) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 04:40:49 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CH0PR03MB6161.namprd03.prod.outlook.com (2603:10b6:610:d0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 08:40:47 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 08:40:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 198bf316-3e40-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664268056; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=zY0kJnEPNnF+LxAXTh4qx2FE7upB327UOUb7LTGa6pc=; b=eg5OahqpjrA+YhDTGTakExQeFXD+WlNMmk1s0RsRFtVJljS/qEVzb2js WMeTK8+AbGNwtcPp74F0S0abE/H2vJr36kRySTyXj0TJN70vcHGcQTw3f 0ydO8FLz3c9r5s79CyypOPJj0hyRMlwXyd7JnuXCRdMq4Y/THQrkOdSRB w=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 83932930 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ijRasK2GQIE+Su5hB/bD5RBwkn2cJEfYwER7XKvMYLTBsI5bpzMBn GsYWm2OOK2LY2SkedwiOdvk8EkBupPcm9FqSwtlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WlH5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUJ1t5pWj9Dy MZbEx41QBKxldiK2IikH7wEasQLdKEHPas5k1Q5lXT8MqxjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NvvgA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4Wreoyn217SX9c/9cKUOL52n99tguWewx0cwNR86b1SD/fbs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8VUO/037keK0KW8ywSEAmkJSBZRZdpgs9U5LRQxz UOAld7tAT1psZWWRGib+7PSqim9UQAFIGlHaSIaQA8t59j4vJp1nh/JVsxkEqO+kpvyAz6Y/ tyRhC03hrFWiNFR0ay+pAjDm2j1/sWPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOjBCyqtWNEEvWNSIg== IronPort-HdrOrdr: A9a23:m87UTqlNk9ZuPM8bt7NqCxrodi3pDfO3imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC D4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR8Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqXneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3GlpT1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfYzhDc5tAB2nhk3izyhSKITGZAVyIv7GeDlJhiWt6UkYoJgjpHFoh/D2nR87heAAotd/lq b5259T5cFzp/8tHNxA7dg6MLqK40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd L6IRhliVI= X-IronPort-AV: E=Sophos;i="5.93,348,1654574400"; d="scan'208";a="83932930" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GyjHC4v+P76LQgddVtRbD2oteMZwGWOnK82SRgJKwhSH4mseeKczISUQ63aipEaxOzrkIn2PtQhI3Zv/2UHl8CS7TO/kLb5qFyRdF+fJ85R2TM14ODxvLO4kWQ5lwH2QDmCJFHsByQsTJgOwrDXk0tgVa0Kb4MAdA31dmMT5ISx2g0pF9NZvNUWp+QEAiwRY0ZED1AZbdxplu0M7+rtUVerRSZNdX3HII9SKftuRFCYyTybQkrnjm1zCTsIAjbRsV8JQKav/W7cg4kvlIrz+vHzRWkVhheOht4IQXBoA2SB8VgvRblQzpIXPjRaouA1+h4WjvBaHYh2AaX+zeh2Iww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrXc5pGA7NhHOUZaCl5GAaR0WyhyFfALLRJZrswc+1g=; b=kpJ4QImhAh54u+w8x1lKHzeKa7bEXsuCXVoHt9uGV7DU1DAslacHft8u2gxoD29id06e3LoblmE84uHAnF8WxCK5TzHETK6oXvScjnCSWunjYHBYBmXZJ4cAgJcCkNCaot7Kg/x93KI4Psd21/x2aIu4SFs9WKubStBeEKGyUZohljDnJit/RDkhWaf8aQsJ9FW1KJNWPGzOcaM/QGTOIfsWFB3nzEk3zHEkwQ33eA9mUi1xAqHodRgBePbKbIrJ7ipZmHgl3B8UW0dPX0F9QBaCz191v9DW3YCs1UUPrYgyg/UM4J+hM9d9SHEWGJBi6YOVQ9RbdmB5wyOOK8UIMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrXc5pGA7NhHOUZaCl5GAaR0WyhyFfALLRJZrswc+1g=; b=hwzz+hFZjHkFNzefGtgC3Rtn2x9EGng+DnyDn1u0YlVFgmzWA+9Re4ixPyD2Jw+hqMxboe4Z3jCaVgKKRu36i+sn+4Kvlhr01ZGgqzvDU8kwsAcUAuDc0qxkuuoKTRdv8kR3mUcQhXw0ChgrfMumNP5UguUModzbK/y+CUts8ZA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 27 Sep 2022 10:40:41 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220922160516.5929-1-roger.pau@citrix.com> <489b2308-8ab8-c1c0-1471-04aa1c4bf0dc@suse.com> <82fb70ca-25cf-6e06-968d-416798f65f79@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <82fb70ca-25cf-6e06-968d-416798f65f79@suse.com> X-ClientProxiedBy: LO3P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CH0PR03MB6161:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ec9a8bc-8305-4717-07de-08daa063f90b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UnGxvprvG+IA4IX1JNMRsm3JOhpXpdsc9Q8F+vSSgK1lc+JR46MAhlGMKGu7hh4WK71pwbbvr21mNjB6g9S1EoYKZy7oyDX+1xjbWsvBhTQyQQQCOyNPdGt00C2s9czpBm6nJSkDeMQFX848cGFQYGpT+h+Z05GVxyrs6QfKk7sl/LzN1D5OFSs/f66ep+6797LDlPpo0DQpu+CeZLx7/bvzSSNjAhGgBgV3e3R/BQ2WHV6/q5CO98Lmqo1431D9YjvlQ3rQoaxQHhyTC4Cqk3/4oGmnBDiP2Gq2ApA1yyZc6sPEbauGUDoZN2fjJwcjkvzwCsUy75Q+q62j2j9JHM1+hBU3i/0kKj5EIyQ3uB2nuno0BB3vazCQJkFsOusmczHveQoSmGVHdGeQQKSi5+o9Xb0IXUvHN7kTKzgCS+gKKN6q3TLTV2KH9Whb8MoiEZ8l9nMouRs6lVw8/VsHn80aolIoyE4OB2Eforld0eqIImXyBoDvF+qfRCuMgBs+iJrm3rX47M9gv5XPEjRxLjgQqHlKWyDXZ1ysYBMt+CDyD3egbYS8nRlGx6yiIpG0/QMgnbpijfkCE3uv7KfLjVNd3rh87OgEUtFp3Aj/Fe88YMf5AMC/+vEl2iP5W/HFx48S1tLMBFQDpsEKCxLDxymG6MIiOfrNMJmfzxuXU7cyEfKyrUBlEoYcot1JM1iVr5mvRpgRJOU8XZyfRxHTXBeqOH3XFv+WcIL6TDudHnM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(39860400002)(376002)(396003)(451199015)(53546011)(26005)(6512007)(9686003)(6506007)(38100700002)(86362001)(2906002)(82960400001)(6486002)(5660300002)(478600001)(85182001)(83380400001)(186003)(41300700001)(966005)(4326008)(66476007)(66946007)(8936002)(316002)(66556008)(6916009)(54906003)(8676002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjRQbFI4dmI4YnpKNFNtWFNueGpERUoxUG0vb2N6RmdRVkFWZUFicEx2a0FP?= =?utf-8?B?NTRHY3FRRG1ibktnQkRlb1I0UnB0WGRUbzdjQk5MZzVIRVdRb3l6ZXV3a3U2?= =?utf-8?B?RXo1R0YzandmcjkwOEdQa2oycHlVVGVMUmJaL2FQWkZGcDZEM1ZQa2s1ZkEz?= =?utf-8?B?SmwwWEcvZEpxdFVmcTNmMzFZbThNMm1wSGFPY0dHTXBQMUdhbS9uczBlUFdz?= =?utf-8?B?SllzTVpqaTd2TU9tcDRJTFdzYW1tWlN1aGNIaGxZdWd6cGZMM1ZIekt0N1BK?= =?utf-8?B?N0FrSVdUT3VsSnBma0hJQThUa2h2elJoYnI2V3RoUWFZUmh3dmVsZVdTb25U?= =?utf-8?B?dnV0VjdZRUtVbWlQK3V0Si9zQW9YS1lENnUwMTdwbklaZzFISWoxanhxVVgw?= =?utf-8?B?SnVoeHIzWmN1dVY4ZlBBQ3FLcE84dmtFN3h4bHJIRFpsaHh4ZmRKZERWbEFW?= =?utf-8?B?S2QwbG5pTW1VenpCV00wbzEwTE5ZbGhQUkRENXZROTVIYThjMTVxQU9zSXVn?= =?utf-8?B?TDFzbzBESGllSm1JMlVTM1M4UHRQNnNid3dpYlpQVnV5VEhyV3Nyc0lKUmpT?= =?utf-8?B?Y3c3MHlLVXVvWm4xVmwxdFkzTEgzZC9lTy9lbXd5cUNuVWRvZ2Q2UDRta1Fi?= =?utf-8?B?YjE3aVpZSHFmaGFIdTMvZWRHcG4rQ0lxNVlFQ3pPNlVmOWJFVC9oSUtobURT?= =?utf-8?B?UzlCakd4a1ZTRTRSQWoyeVIwdGJMbG1YaldvTnRBMUN6MU85dFV4d2czNVdh?= =?utf-8?B?LzBvVWNxMGFNRmhRS1I3ZEhPNUthK3kxaFBTdi9zTWNUYysxUXhPWXBiT1RH?= =?utf-8?B?eTFzZ3c0WlNreWJvckwyTU5VRXJHREFFa1ZDWnBoeHJvNmtqb2xFQy9NRmxr?= =?utf-8?B?L1dnYXpzOFA4YUFldE9DTXE4bTVua0Qrcm1hZ21oTUJjTjNhaFRIeklHR0sy?= =?utf-8?B?MmJpRjBIV3c2VXpkcHdZSjlaSjRDOWNNeXNLRW45VlJBWk9IZjhRL1ExNjNI?= =?utf-8?B?ZXZHZGR4Tjg2eWpiYmhjZ3VTUFl5alRrRVl2anhTbUs4MC9wOTg5NnpmblU5?= =?utf-8?B?OW0xV1pheXdJK0JXaXhacS8xa3pkVThXMk5uL3A2Y3pwdm42L00zZ0hZc3pq?= =?utf-8?B?TjlnNXFSRzNscUV6aThSOVBZekpWYlQ5YVBqRGZoNXk1a3lXY2lpbHVYUytk?= =?utf-8?B?Tnh0MEpQY1VCOXBpMHhFNHU0OElJczFOcXJXdHpTUDJWc21sMEk1RmthQTBl?= =?utf-8?B?UDY1cTlKcmp4UFVYalh0d0t5N2h0eDFlNEc0bVl2b1pLWmRKalBqZTJLRGQz?= =?utf-8?B?dlBSS080bkZwQ1JLM1JyOElXMHVWak5pVmlmdDNhbFFSTDZWMVRreFVwSDJ5?= =?utf-8?B?cXBNamZGaFV3ZjlPbzBucGx3ZmtKZWY1L2ZDYUMwaEN0ZCsybVdIZXZuTXJR?= =?utf-8?B?QnJZZDMxeHhLS3BpVk9PK0p6MHlMNTczbmNkWGJpeTgxWldpTHl0OFgrbVlZ?= =?utf-8?B?aVVrKzZ0L3JDc21JKzFtWU90bzJsVDNUL25tbC9oOSs0NTQrMnZmOFdZZ3dm?= =?utf-8?B?N0t6NTZEYkRNblBvNDlXOUJPamZFNmNKN2pwS0pHckZ4NjJPb0Ivd2hmcDVO?= =?utf-8?B?SG9qUHp5NEI1Z0lHZmJSRDFMS3lYS1NFeEIxcEhsSkZhTURMZFVMSmJqbVhr?= =?utf-8?B?S3FDV21KNWw4empYYzRCSCtBZWViak43V2VycE1mb0FqTVNzSk1KYVJJaG93?= =?utf-8?B?WGFudlZYcmJpcytCN1hxcHFTRW9JdGptSzB4Tll2RVJaVzFha21GL0VRWk5n?= =?utf-8?B?YlpyTy9SS2QvbHE1MEFCWUxDcTk1Mng3d0hLZHlkK2MrSk8xamkzc2JPanNz?= =?utf-8?B?REFVZGxiSTFrRnhwbVFlVCtOR2RWTW1TeGsvdDZWcHhTZGJscnhZc011SDVk?= =?utf-8?B?cTdvWTdlRmxabGZGWkdYS09CTC9ydmFVeHh0YWhCTy9sa0VyTlZqZVFEUEph?= =?utf-8?B?QUh2ZFllUUNxbjF2RURhcnNEcEN5SGh4dzNScEo0K0ZUeTIvaURiQ3lITVRO?= =?utf-8?B?TFA5T2hMZW9qV2dFSk4xanR0SDJWdXlZeHlROVNEdnViUytkdTF1RkgrVS94?= =?utf-8?B?UGhpeDkvaWphM0lpcjhCUW40dWVVU3pKZzlMeU9DSEQ1OE5vZHFSU1pjQVYx?= =?utf-8?B?ZGc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ec9a8bc-8305-4717-07de-08daa063f90b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 08:40:47.3364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yYzzg9T8Ui1LRHVFCwVlpodgfm9IwmUyAj+T01m1BAwf8BVwmbaYJ2MFgqmZ3M48KnAqKDvPO1jsDYH1gT1jAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6161 On Tue, Sep 27, 2022 at 08:35:20AM +0200, Jan Beulich wrote: > On 26.09.2022 17:58, Roger Pau Monné wrote: > > On Mon, Sep 26, 2022 at 05:36:41PM +0200, Jan Beulich wrote: > >> On 26.09.2022 17:25, Roger Pau Monné wrote: > >>> Correction: the Arm memory_type_changed() needs to stay, as > >>> iomem_{permit,deny}_access() is common code. > >> > >> Right, or we'd need some other arch abstraction. (I wonder whether > >> long term Arm can actually get away without this. Even on the AMD side > >> of x86 I don't think it's quite right that adding/removing of MMIO > >> ranges has no effect on the memory type of accesses.) > > > > IIRC there's no way for the hypervisor to infer cache attributes on > > AMD SVM for NPT entries, but maybe I'm missing something. Guest MTRRs > > settings are completely ignored for AMD guests. > > Right, as documented: "Note that there is no hardware support for guest > MTRRs; the VMM can simulate their effect by altering the memory types > in the nested page tables." That's something we imo should do, but which > I don't think we actually do (see p2m_type_to_flags()). We respect the > PAT bit when splitting large pages, but I don't think we ever set the > bit when making new / updated entries. > > > I'm not able ATM > > however to find in the AMD PM how effective cache attributes are > > calculated when using NPT however. I would guess host MTRR + guest > > PAT? > > First guest and host PAT are combined, then the result is combined with > (host) MTRR. See the tables in the "Nested Paging" sub-section "Combining > Memory Types, MTRRs". Of course things are quite a bit more limited (but > also simpler) in shadow mode. Thanks, so we could indeed do something similar as to what we do for Intel and set a cache attribute in the nested page tables, at which point we would need epte_get_entry_emt() to be not EPT specific anymore. I've created: https://gitlab.com/xen-project/xen/-/issues/88 To have some reminder of this pending work, or else I would forget. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 27 08:41:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 08:41:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412324.655583 (Exim 4.92) (envelope-from ) id 1od69f-000546-W7; Tue, 27 Sep 2022 08:41:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412324.655583; Tue, 27 Sep 2022 08:41:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od69f-00053z-T4; Tue, 27 Sep 2022 08:41:27 +0000 Received: by outflank-mailman (input) for mailman id 412324; Tue, 27 Sep 2022 08:41:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od69e-0004ev-Pr for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 08:41:27 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50066.outbound.protection.outlook.com [40.107.5.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b45cdaa-3e40-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 10:41:24 +0200 (CEST) Received: from AS9PR06CA0219.eurprd06.prod.outlook.com (2603:10a6:20b:45e::10) by GV1PR08MB7345.eurprd08.prod.outlook.com (2603:10a6:150:20::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Tue, 27 Sep 2022 08:41:21 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::7d) by AS9PR06CA0219.outlook.office365.com (2603:10a6:20b:45e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15 via Frontend Transport; Tue, 27 Sep 2022 08:41:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 08:41:20 +0000 Received: ("Tessian outbound 0a0431bdcdb4:v124"); Tue, 27 Sep 2022 08:41:19 +0000 Received: from f9fefae8df3d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7A2F8718-0989-4263-ACC6-9B4B2852ABFE.1; Tue, 27 Sep 2022 08:41:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f9fefae8df3d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 08:41:09 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by VE1PR08MB5792.eurprd08.prod.outlook.com (2603:10a6:800:1a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 08:41:05 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::3475:c78d:9d75:6137]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::3475:c78d:9d75:6137%3]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 08:41:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b45cdaa-3e40-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bLRdE401+Pb4tjBGLp16vtz3vA7LhynKsVm/A9tztPOawLS/xy3jgdSn9OwFeEvE5fLqcGP6U8PyshpqcRwKu5sjZT4s+9z4dWNs3n4cMgkpHq/SMnIJhlISF7bbcTTpJ+jqGyOVtQCUyG25ATv1Ixa4dwQ9rk+RUnSDvC/Nz5ZhApH/40zM6HPhNHGyWlFYfnxn/sWrfM9jodjbPYNFix0VzJD3L3nxkBGl0XKdvDmnV1Hu9qFK7my3LmFnbWKDZd+q7UiHXEFZCzlrcaCvoW1qbEYGwiOeWZyw9VVMnbrpoTu/9xo+n3JZX9XuzUxbpedkqR4pVWFkQziHgBbDOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/75M5JAtxEaTU4YCeAgolPxjRP7dH5hp0xl3CdEzXu0=; b=TJrRZ/YCuttKpCQRl9zKxFBn5sPuaWm2x+0+e/RXXmRLIe6B1Fid4yUN68XN8oy63it8CrHLTRPB9Nkaf+0iKh2+kh7lRh5Q9cTTty+RDoEKhmNyr9Mq2UUCkdBRp4lyOxCq/LlY/OKMSPzQGH1sF5WHM1OJDlVgCAj72jpx2akqKTTgeCP7nNjh1e/+iyPR+c6otryDxPzav6nADdC7sjTr1rRgsN2UuOgKaU/BZhAeujTqMrJfb7/DmqcwoxFGL3JiOW7M9C/MfrLt7UKEx5AHmPLUBm+U8/F1T7S105c0BKPqouldt09PMD2d1P7XF5YVjrwBtvJydLMIVdIfeg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/75M5JAtxEaTU4YCeAgolPxjRP7dH5hp0xl3CdEzXu0=; b=VZSJOZWvxr+YolINuHX0ndneWf9wYhi8KzqGMZzn3+28fDHAHb0Fy3P1taZ8YEjbdO1ZhN9uXdqV9oOkyzB6pCJm9opQ0aQesVqaXb96evetHm72UQ+KRb7wQN3kKm8AxVLmrC10MNIymsG6qvOQhiwiIGxypV8it49/d4AjLMc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6fcec51f874cfbb6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PaG0PyajqBLz157c3JREz/snGDA2nTj4XCZrpp2M5XvCzLIav//4zb+fJmHqHoSeMjk1j8momfNVVVJEgIsq8dRC1t7yy0HUhSsd1fKd8CL7o7QbEDzn00liaGZNqXp7gjQBiT1BxyIlAZq8mfjx1nkYGLw7jyIE5KNlXhkZmVMFj7GwBxHuXSAv81NT1TVnzWNis488sqOtTVXi+BdgBzSaAC63NbBrLZq32jkOvZkCMMJIrOHU4LtDrlLHvfEki+xyKQwuuGhyQvywkh8nC/PmqGkGfmHoGKpsLdrLkBFCvcZ5dmMcZN2lRrQ1cCCdtXiUg5vy3d50VcrrHsu7vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/75M5JAtxEaTU4YCeAgolPxjRP7dH5hp0xl3CdEzXu0=; b=nkBFR/XShsRzA+tOsAd4E6GH6Rr7JVg9VB1qieeNdW4ui/He9y/Ccir0RTmxWgIThmNsdCbkN+0V0siYUzkcQFxJ6vwLMI8tsuKyAAQFBYJ6xN5YQGeFNZj5cT8eKpQ3DXtkYiVuCFFIxFNNnSFOaBg1tu86+lEHQgNFIYZUvMlYIHlbkXXwnW/Xe/DSmEBjA4UtWR6AdHH5n9oPBgc5C8vrJAGuTr0q5sW1InCE591l2dkVOqdPgb1XfBkM8VlzJzKXwwbRm0OI6GBPFSXqaidLN8j2LeqtXT7mf9QrDmf1HrrULe7YNaVCzPVF7Wrllj/xAHgBwZgWDhLRP+KFrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/75M5JAtxEaTU4YCeAgolPxjRP7dH5hp0xl3CdEzXu0=; b=VZSJOZWvxr+YolINuHX0ndneWf9wYhi8KzqGMZzn3+28fDHAHb0Fy3P1taZ8YEjbdO1ZhN9uXdqV9oOkyzB6pCJm9opQ0aQesVqaXb96evetHm72UQ+KRb7wQN3kKm8AxVLmrC10MNIymsG6qvOQhiwiIGxypV8it49/d4AjLMc= From: Rahul Singh To: Bertrand Marquis CC: Xen developer discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Henry Wang Subject: Re: [PATCH 0/2] xen/arm: static event channel Thread-Topic: [PATCH 0/2] xen/arm: static event channel Thread-Index: AQHYzzvwz5KfzY5FpEi922tCq9+On63xpAUAgAFXRAA= Date: Tue, 27 Sep 2022 08:41:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|VE1PR08MB5792:EE_|VE1EUR03FT043:EE_|GV1PR08MB7345:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cdd0fc5-eb03-4db3-c7f1-08daa0640d4e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g6DZlUXe5YS5FEUIDXOge4GjNEMYkTWuRADm8JsiliOxlSCMQ84cybl9UVd1mKw/7OBChbY4/cbrGFc8y5OZ+TzsaLKlbN1bAngmuxzMTW/zjU9NTa+Y0aBMqG3lcUwjB2zGG9t3fxJK5FpT1YkOfoTXC+z5h37rG1p9urfSKUbV3AAY49kQJFBqZ1bSvWeVrUTGNMoa+ovM3SGPsAo7d6Nw3OsdHuGsrgTAKNQ17uWbVNWQqhBUwT2IVM6opZyfSE1DqqgS+UdHyF7aAcwUXMr6QG9uYkbN5FsdW1CtZA1IvezLFeX8wQnVZVB1eiUD9CpoIXuk2ZJJ1NupEsC6vyrxKmhgk3nl+APVi6JuDsx/U/B+0NQUGlVAEdE3nfuwQtRx6G939CoTsqOYsQDWAqZnh/14I+a+2CNJiF+gKuTeSi3RFg5tb70I8A/ZmLh7OOQ94Yxcv9f6k6LmjpiiVPayzG8t37irCILATgJsHgj/i/mYx4mSTwCaXGxLzhbEmWOb9o9Tb8SXyY4YeNkQLGx+4xE8RjkAmGriXQoOu5s0cJknb8EqxwMWouej7VlIotwQYFITerJfjhfLx7hvgvOheK3W0P6cdnh64XfmWtq6akdyxq2yqVMOZJUZ0TARI/CGkGgWhEcan7MPPIPAjfZQ+HB+gswA3zzv4HWa46GsAm40y6Xu8DZADPAFNbXGLli6P0KytOOSoYGClu6fxti59YN4bcZRRSr9zZTDhTrRSq2ugSY2pbbD1Ad13EHNyCmy9cBDrnEZesg5736ZKiDyyGPihvMWXn+gwM7S3jA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199015)(38100700002)(122000001)(86362001)(33656002)(36756003)(38070700005)(6506007)(186003)(5660300002)(83380400001)(2616005)(4744005)(2906002)(478600001)(41300700001)(53546011)(6486002)(26005)(6512007)(37006003)(4326008)(6636002)(54906003)(66446008)(316002)(8676002)(66946007)(76116006)(6862004)(91956017)(8936002)(71200400001)(64756008)(66476007)(66556008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6BDBE3FCC2E2054CBA0BDB62AEB79D9E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5792 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 95c6e3b4-d4f5-4cc9-f370-08daa0640428 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jzyUUbQUhZrU+eqps59lTkjg78PGxQtUW2PIS9HJ7zc5iBbngPpIYT6tvhY1eD+NuB5j/LPplO19hqif/NxHGZBSN7rIs1xbG3ROibviSF3mk9LwBBFbN6nkwNol9duhUk+1AtBG6XzSQXzfx9EjKGq1ApoRW2cM6mybxc8Pg7igFt4i7jg7T7/Xioj6MgnL9/YYS5TLd2w2XrwmSDdJt5n5htq5cwwMcaNkUTlTWqXBiJrMNMvJkAAUXE2R6HcmahHjGA2WjTUO8MSlYNY3167R58tLpcltHToFRN67FWpjhwp1LdJo7hzlt8ffCMg/6EUZbMPe8pTlwTcIvXOXYC/wffcJUnRPnms4NJ/UFjc/tU80xp/IU5vSAOgdtKOMMpnjk8Qmc1cJLzhCs4gPAPZBfl0Vex5w3qDPhtcN2MTM/4WDQiawIoMtyOswL4Y8f+UO3r/Wk/SRFyNq4Gffs8UojXk3EfePUqsDt4OF6AxXUIDTD5trmLPt+E60xMnYAhK1IGtm0bi1TRqvKc5VCT7dJqU90qq719nnXOQwTo26goQ6XOO41LHjF6cbtFptbZ57gu9hER097QBsh2QPpAlrS68gH1ALV8mwAbqAqUbW1NEOsU8+s0N85JxpzT/DYRrys83HCl10+TK0ZF3PfqDrA/unbKGr0LxF2FBPbTbohME09DIH+q0mKRFvTRFd1ykLLelkCR4QbaeqSJWhWHqiR2+ri77kac792pIDOSrggRTZuM6Fl+obM6B0tIC4z7vGBgbOLf3+xsllvhOZBw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(4744005)(36860700001)(6862004)(8936002)(4326008)(5660300002)(2906002)(8676002)(41300700001)(37006003)(6636002)(82310400005)(70586007)(70206006)(36756003)(26005)(82740400003)(6506007)(47076005)(6512007)(356005)(478600001)(83380400001)(86362001)(186003)(6486002)(40460700003)(2616005)(33656002)(54906003)(40480700001)(53546011)(336012)(81166007)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 08:41:20.5599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdd0fc5-eb03-4db3-c7f1-08daa0640d4e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7345 Hi All, > On 26 Sep 2022, at 1:12 pm, Bertrand Marquis w= rote: >=20 > Hi Rahul, >=20 > Please give the necessary justification for inclusion in 4.17: > - severity of the bug fixed The severity of the bug is high as without this fixed system with ACPI supp= ort will fail to boot. > - probability and impact of potential issues that the patch could add. As we are not supporting the static event channel for ACPI, it is okay to m= ove alloc_static_evtchn() under acpi_disabled check. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Tue Sep 27 08:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 08:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412335.655594 (Exim 4.92) (envelope-from ) id 1od6KL-0006pX-17; Tue, 27 Sep 2022 08:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412335.655594; Tue, 27 Sep 2022 08:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od6KK-0006pQ-Tv; Tue, 27 Sep 2022 08:52:28 +0000 Received: by outflank-mailman (input) for mailman id 412335; Tue, 27 Sep 2022 08:52:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od6KK-0006pK-0X for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 08:52:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5943e49-3e41-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 10:52:26 +0200 (CEST) Received: from DB8P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::19) by AS8PR08MB6071.eurprd08.prod.outlook.com (2603:10a6:20b:29f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 08:52:23 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::50) by DB8P191CA0009.outlook.office365.com (2603:10a6:10:130::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 08:52:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 08:52:23 +0000 Received: ("Tessian outbound 0a0431bdcdb4:v124"); Tue, 27 Sep 2022 08:52:22 +0000 Received: from c7669fac352e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AD7783BE-F834-411E-9CC4-FACCAD1271C7.1; Tue, 27 Sep 2022 08:52:16 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7669fac352e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 08:52:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GVXPR08MB8236.eurprd08.prod.outlook.com (2603:10a6:150::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.23; Tue, 27 Sep 2022 08:52:10 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 08:52:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5943e49-3e41-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GAh3nrUQPRvLFIgdF/GjEdzamB/gzm3LfPKRSQjabysbK7+edGrhhxOZC7Nf2JKPN40HRld2LRnWTI42lw5aKJ7Wf1Wu6/IcPfWV9bd84dgVHNowlgjl3xfLwEzBNBZtzlPA/l6B9GzfphzGA4zrkvrimOouy8bCy2yJWjZxlP3//m1gZrGVHhBd0AzAWVOVBs82JFxF9ApKe9K0MgoU+JOFXt4e1DIDW4J7hG3XeS5IU4szZE18FuWv/QaNbuSdWN75J/y2tA5Jy8CAxuQZlvbO75/ZcpfDaZT7SKmAbu6EgxwF8sVdX8Esl0SFLlvKXmnnYAahYYRT5RKprMln5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr5ei3TBMtd3oBXoxDlUTfqMslleIbEDMj91zGmSkQQ=; b=oNtpuQ97yE0hgAA0j/GwRoeFgh1W+e5P6YQeLxvoTQlGXUztTSHhTG6q1k8EgII3XKITN7qsT3yMGJWnHwbyWX3o0egQ3jwHDhL65NGSixg3u4wNj4Qxe7zQyChCV3hawmaCSsvsSvBJbE0lkbTEslZ5LEt4dsrCzlcsRy2aBXZGjLSdblooGfKXrQV9PJbfeAugp0CIXVCd6rIXF7rRfYSna4DP3uu4SLG1kl+Aji/hQieRcmG9pqxSqzPXOjPDRxuNzoG39JaV8V1ftNF6pgdyrxeoxreJ++Oj4iq9QFSx//y9fK5xaZB5QlNqM9AyP9pcdt4LQtx2pUCz2KFT2Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yr5ei3TBMtd3oBXoxDlUTfqMslleIbEDMj91zGmSkQQ=; b=m0Wfk9VMaaAnY9res6N0JibacR4bvqDYCLmtsgUgDghZELDjzzEMeYEidJQxXXUeumpBYC2P3HJjQbe02TDMzDRhP0AfFWlGGcbl8y8w+/t4qkdddC5PaMMXOUq6/gur6RdzW9b68jIQapBqKkJzDiopK6Iz3arc7roOTRoWNkc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gAbdnKrkTaVFODg8iTEcpgr+xjmh2PU7NzLNd1szympFTbElQV6od2ont5lCBIhy9njFJ3HN52Scc11E/xBdlY/bQOD7ZkrYlvNkMSvgOZA1zrppp/bGPd8+bo9fG20Y4VxisKeEh0XuayEfjZojhIyQwKBlNj80JPfuCv5GnmvoivzzNmKMyn7wj9fXiwMxnGN3dN27nPfjZl4nzSAkY+ctV+b4/LY2gpWB70LLPw6+sqWe5wWRfAxh5S8fxkJMscD00NJeExqI3XW42OXvI7TGdvH1svb47Fv2tvkEosTezoGLgH0e9VJA5l5dv1uj7wZXquODX8rx+7HNYd2fhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr5ei3TBMtd3oBXoxDlUTfqMslleIbEDMj91zGmSkQQ=; b=aKBy7Jp8ocyC3ohBHbKGiYdS2JoNPfEm4TdbRGlUEYF2Hulod7jFljDcHpQEMCclRbTVbNKcbN1M02w3b5j9rdEltZwYpqf56p3tc+Zm0CVO2cBOrhTOSyayGj8aqMiVrdFTMzuOeDtsPG2Hv5dq04O0qHJTfRzrZteT1yVKjLuP36qwEZvEWJXZEv1paBJEqbjjO5AFfz2agwyOG70u1ZmfkZRlP6yr6F+agbdtDj7IuZ6zv3pJkKfBRqaWIi4gGGsMxRj21N742PnDa9Xjv2Z2jkiFB/8XkfOXemp2+sLOeP+zcj6kYmDnTuowGwhmvwlfLbJfcdGUXXBRV/WDXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yr5ei3TBMtd3oBXoxDlUTfqMslleIbEDMj91zGmSkQQ=; b=m0Wfk9VMaaAnY9res6N0JibacR4bvqDYCLmtsgUgDghZELDjzzEMeYEidJQxXXUeumpBYC2P3HJjQbe02TDMzDRhP0AfFWlGGcbl8y8w+/t4qkdddC5PaMMXOUq6/gur6RdzW9b68jIQapBqKkJzDiopK6Iz3arc7roOTRoWNkc= From: Henry Wang To: Rahul Singh , Bertrand Marquis CC: Xen developer discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: RE: [PATCH 0/2] xen/arm: static event channel Thread-Topic: [PATCH 0/2] xen/arm: static event channel Thread-Index: AQHYzzwI4ibs40y+fkGVR4ez/jLiha3xpAUAgAFXRYCAAABYwA== Date: Tue, 27 Sep 2022 08:52:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 65B197C43C20FE4C88E63AD5EDB67589.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GVXPR08MB8236:EE_|DBAEUR03FT010:EE_|AS8PR08MB6071:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e31594e-f762-4f8a-2442-08daa065983a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mhbnBYikFPv37DJeyO/IfGJYLzUeZ75dJ5G3axVxGsBtl504KHtvUZoqUp5MVefIy2VO801hHJ/CFrFivQMKIZYc9BrKY43L4EIEyR0ojWV3cAH5x3f6iQ0mJWoJxQn9S+dBGn1oUfBYUyrM6hHLxSLS5ejsiIh0pfeU43GRF6dRGl8/v6uQefVNmyfQYlL+RmU34SQ8vQ2WdpT+fpMX+FADdR8ti2UlwYI0lT/H6yvMWC/Zh8LvjOI04qhhBfKlygJ7ANMsMtNOhTLRoyIGba8G7BTes0kdHO7OVMF4ZD7VxrfP5g7rl8ixk1lLcDXGEz0AseEXqv/PcE/gxsj13SqXN8CZZXzdtnCb/Cm9NYxFk8CrAUvcvtW3ERw4HntPklUp9hajAGtbnUlMHedGdUp4NEXJ47t89tEvf2qCrtpC+zxnv9zWd11z9Kvf9Bk1is2xrcRAjdIMdr0fbyNg5CNyW2nRPG32PNAJwcXwZxRAFc5XkM4+lvgtiULyG2eMdBbyDFJWwFuzTAfR7xGgyMI01qgSP/jKWTlG+6BgfbQfpvKkVQ51/dknVOJgynDNOuXNCBrwIYOL2zjVkEEbXxEIkKBY5b/xVpO7OxJEloWNCZQvaN63AcH+ohoihbVaJHcYJDU6gUQKzfc7cLQhIAr+wH4llv101SexwZGBLpZ199RGifl8haz07zGD3CeRnPlqtWWR8j3TTccNFPyzjWnpsmjQ/dXmMh1lWMqJLyB+32axcga90yhTPgHR1CREpGwSN67fDUNQtesrW/RgrA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(451199015)(5660300002)(38070700005)(52536014)(316002)(33656002)(76116006)(41300700001)(8936002)(66556008)(2906002)(4326008)(64756008)(86362001)(66446008)(6506007)(7696005)(53546011)(83380400001)(66946007)(66476007)(8676002)(54906003)(9686003)(26005)(122000001)(186003)(110136005)(6636002)(38100700002)(71200400001)(478600001)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB8236 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e2ecfb23-eb26-4470-ab3e-08daa0659044 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i/S4Ioz/7UVFe34/NLXXh4LiCW9c6jfwBw+8a+rG7duoTQqJ4Dx94b/INqiNHrxiriNlshmee1XXZQ70lRRLYB4o/RX4OnMx0nFrUnzvGguqj3p3nfWc5x7VhX/+OAxGzOBn/qT6BIfS20+r0KgoCdv6bQjx65pt1GWLd1My+p/DgDw+h/micw6Yfhvk2oaBioLRPSJ9GUal3uRuTPx0F/mmTCF05fjOkjuMfqdV/1hmUvpia2GV1B+My4jkfH8CTLYxc3D0aPIKtIdhuEOatSSXOQ7QPraCTJLpEMPpYde2Y8Ny1FmHgI5jQDDrzMUt44hKEo4N/u7ixaj4aRJ2dQHCnynTnsbZYyQQEWNGpZ/oU337rw3DOsEYiqJTfWHA4Ux/CYJRU67zINjoKdVQ2YO9hin90zsCfNgQ8t7e4XNNzsVSSBpPwqDV7Dsr9ykA2Pps+2WQDJ1rj+wp1h4mlbnq/YDIOlpdTDXDqZbEPZPplW9udaURgOrJDgjH5/kECVlFY0/qddgdQumGBM1nHVxSeFPgxdqOCbVRBuqcSW2TTwmffUF6ZeNBL1PBGlmNd6LVC9jZ5EZ8OReICGRYTymWXSV8nzy2tzsha2hUe28867pU2vkZKIqEp4oUYa8bHVZIKtqH/aY/wSJ2HqUb1hEfu5adnUCUe399u2orfZh0yjgDioSWi1QBqnWH68hnJtZ7pb/DfdDSq2DeWyw+7WeQP0D0HcEPSXcVJim8i6VvDfSPCC8PF6856ZYROaFIMTTr9gWTZPQVArlW8RjtLA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(107886003)(53546011)(6506007)(7696005)(478600001)(9686003)(26005)(2906002)(5660300002)(8936002)(52536014)(55016003)(33656002)(40460700003)(82310400005)(40480700001)(54906003)(86362001)(110136005)(316002)(6636002)(70586007)(41300700001)(4326008)(70206006)(8676002)(83380400001)(81166007)(36860700001)(82740400003)(356005)(47076005)(186003)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 08:52:23.2434 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e31594e-f762-4f8a-2442-08daa065983a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6071 Hi Rahul and all, > -----Original Message----- > From: Rahul Singh > Subject: Re: [PATCH 0/2] xen/arm: static event channel >=20 > Hi All, > > On 26 Sep 2022, at 1:12 pm, Bertrand Marquis > wrote: > > Hi Rahul, > > > > Please give the necessary justification for inclusion in 4.17: > > - severity of the bug fixed > The severity of the bug is high as without this fixed system with ACPI su= pport > will fail to boot. I agree on that, dom0 boot from ACPI on Arm is what we currently supported. So I think we need to fix the current issue for 4.17. Besides the bugfix patch, the other patch in this series is a pure doc chan= ge so it should be safe. I think we still need Arm maintainers' R-b or ack for this series, and as l= ong as This series is properly reviewed: Release-acked-by: Henry Wang >=20 > > - probability and impact of potential issues that the patch could add. >=20 > As we are not supporting the static event channel for ACPI, it is okay to= move > alloc_static_evtchn() under acpi_disabled check. Agreed. Kind regards, Henry >=20 > Regards, > Rahul >=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 08:57:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 08:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412343.655604 (Exim 4.92) (envelope-from ) id 1od6PN-0007dn-NW; Tue, 27 Sep 2022 08:57:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412343.655604; Tue, 27 Sep 2022 08:57:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od6PN-0007dg-Kl; Tue, 27 Sep 2022 08:57:41 +0000 Received: by outflank-mailman (input) for mailman id 412343; Tue, 27 Sep 2022 08:57:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od6PL-0007dX-JW for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 08:57:39 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6fc23ad9-3e42-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 10:57:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E5F8F1F999; Tue, 27 Sep 2022 08:57:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A2543139BE; Tue, 27 Sep 2022 08:57:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OGo1JgG7MmOvJgAAMHmgww (envelope-from ); Tue, 27 Sep 2022 08:57:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fc23ad9-3e42-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664269057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5aHiD4rZbP/VHCDDbsZS6HtaQz2jtnZB5/EX4LRiKc=; b=dRpWNwpOnnK8mVkTRo+xhlF0Vkfjj3xIipCxOz9xtapCSVZJtJNdelOv9m2A2WhGyq0YuM e/57kid22xPmOXn+Dls3imbcVJdIoSDs/BxC5wwphUjtAhJFj2ddtHQT2z//nZezqPYL7r b4Df8ktj1m/Vpov2mvFMbx+/Jj2sYwg= Message-ID: Date: Tue, 27 Sep 2022 10:57:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0omw3ZfM27TVCp1IFTspqxRw" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0omw3ZfM27TVCp1IFTspqxRw Content-Type: multipart/mixed; boundary="------------iOwbv5oefZcAe4yIQj1pJUSW"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> In-Reply-To: --------------iOwbv5oefZcAe4yIQj1pJUSW Content-Type: multipart/mixed; boundary="------------VF8nyolFe3q90VxADFU1RzkZ" --------------VF8nyolFe3q90VxADFU1RzkZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDkuMjIgMjM6MTEsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVGh1LCBT ZXAgMDgsIDIwMjIgYXQgMTA6NDk6MTJBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IC12b2lkIHNldF9tdHJyX2Fwc19kZWxheWVkX2luaXQodm9pZCkNCj4+IC17DQo+PiAt CWlmICghY2FjaGVfZ2VuZXJpYykNCj4+IC0JCXJldHVybjsNCj4+IC0NCj4+IC0JbXRycl9h cHNfZGVsYXllZF9pbml0ID0gdHJ1ZTsNCj4+IC19DQo+PiAtDQo+IA0KPiBFeGNlcHQgdGhh dCB5b3UndmUgcmVtb3ZlZCB0aGUgYWNjZXNzb3JzIGFuZCBtYWRlIHRoYXQgYm9vbCBnbG9i YWwuDQo+IFdoaWNoIGlzIGxlc3MgcHJldHR5IHRoYW4gaXQgd2FzIGJlZm9yZS4uLg0KPiAN Cg0KVGhlIGFjY2Vzc29yIHdvdWxkIG5vdyBvbmx5IG5lZWQgdG8gc2V0IHRoZSBib29sLCB3 aGlsZSBpdCBoYWQgYXQgbGVhc3QNCnNvbWUgbG9naWMgYmVmb3JlLg0KDQpUQkggSSBkb24n dCBzZWUgdGhlIHBvaW50IG9mIGhhdmluZyBhbiBhY2Nlc3NvciB3aGljaCBpcyBqdXN0IHNl dHRpbmcgYQ0KdmFyaWFibGUgdG8gInRydWUiLiBCdXQgaWYgeW91IGxpa2UgaXQgYmV0dGVy LCBJIGNhbiBrZWVwIGl0Lg0KDQpBbm90aGVyIHBvc3NpYmlsaXR5IHdvdWxkIGJlIHRvIG1v dmUgdGhlIGFyY2hfdGhhd19zZWNvbmRhcnlfY3B1c19iZWdpbigpDQphbmQgYXJjaF90aGF3 X3NlY29uZGFyeV9jcHVzX2VuZCgpIGZ1bmN0aW9ucyB0byBjYWNoZWluZm8uYywgcmVzdWx0 aW5nDQppbiBvbmx5IGEgc2luZ2xlIHBsYWNlIG91dHNpZGUgb2YgY2FjaGVpbmZvLmMgc2V0 dGluZyB0aGUgdmFyaWFibGUgKGluDQp0aGVvcnkgdGhlIGFyY2hfdGhhd19zZWNvbmRhcnlf Y3B1c18qKCkgZnVuY3Rpb25zIGNvdWxkIGp1c3QgYmUgcmVkZWZpbmVkDQp0byB0aGUgYWNj ZXNzb3IgYW5kIGNhY2hlX2Fwc19pbml0KCksIGJ1dCB0aGlzIHdvdWxkIGJlIHJhdGhlciBo YWNreSBJTU8pLg0KDQoNCkp1ZXJnZW4NCg== --------------VF8nyolFe3q90VxADFU1RzkZ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------VF8nyolFe3q90VxADFU1RzkZ-- --------------iOwbv5oefZcAe4yIQj1pJUSW-- --------------0omw3ZfM27TVCp1IFTspqxRw Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMyuwEFAwAAAAAACgkQsN6d1ii/Ey8g hAf/ffuLvYbtvTozZxPD7F3rv26Okz0If7EaJkiWS7vKU/LKQGAITr3GxMcbrKg6F/MGE8sXfq1I BekA8owLDMvhqqKbFg68rikW8Coy9h67lJsWMzOqkctEUsGXBTD2IW9Yqfd4UvqCcT1YwfEQWgtl QmM/ID6E/krI7ee6dk/gs5dDze0kTwKCnHCG7L1slL+tHPQ0K6lyeFoxGLPNvq+tar5IhjEu8aJP +PkcmyzCUspxl8mLtk13eixPWYjfPxZb0nO29io3zUO4uuyms74or6Wx3o5gt76/wInoJGLa3bSl w7wUNAD8k2d8KfXLLhS8XTbvqDGGXng/bl1NfmeEiA== =B+dC -----END PGP SIGNATURE----- --------------0omw3ZfM27TVCp1IFTspqxRw-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:34:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:34:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412350.655616 (Exim 4.92) (envelope-from ) id 1od6yV-0003kL-It; Tue, 27 Sep 2022 09:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412350.655616; Tue, 27 Sep 2022 09:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od6yV-0003kE-G7; Tue, 27 Sep 2022 09:33:59 +0000 Received: by outflank-mailman (input) for mailman id 412350; Tue, 27 Sep 2022 09:33:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od6yU-0003k6-Q2 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:33:58 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80fce7fc-3e47-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:33:56 +0200 (CEST) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 05:33:49 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6526.namprd03.prod.outlook.com (2603:10b6:510:b6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:33:46 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 09:33:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80fce7fc-3e47-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664271236; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=toQ6I/inDovFB0X4AiCcei2Ke6x8JuxVKp4hoMqKFrM=; b=HHO9uW02rX16CjiNZQ1d0rPyFEp0z+gaKwL7xIV7ATi9IWRDmSQD8rbM Ps9JURfnxibTMEktJX/bMQZgmRmB/h53FNff8O8W+UurtO7pN3of0YBxZ mLaxaEPKq7ewN9y9YT6gbYcOGs0MU+60Jdn0eSwfeaT0oC/hOaZk7jGRH w=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 83935897 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sgWQyqCAdmcShRVW/+riw5YqxClBgxIJ4kV8jS/XYbTApGl31DFRz 2NJWWiDMv6PYzOmed9xPYvl9EgDv5DUm9JlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37a6t4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kYY5QU9bdbAFh8r 8cKJA0NSU+SieOPlefTpulE3qzPLeHNFaZG4DRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAJ7gvL9MLb4ECKpOB1+KLqP9fPPMSDWO1en1qCp 3KA9GP8av0fHIzEmGHYoiPz7gPJtT/HY9wpT7+fz8NnhnyYxXRUIjAJT2Lu9JFVjWb7AbqzM Xc86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLW6QuEAmkPThZadccr8sQxQFQCy Vuhj97vQzt1v9W9S2+Z97qShSO/P24SN2BqTTQfUQIP7t3noYcyphHCVNBuFOiylNKdJN3r6 zWDrSx7i7BNi8cOjv+/5Qqe3WPqoYXVRAko4AmRRnii8g5yeI+iYcqv9ETf6vFDao2eSzFto UQ5piRX18hWZbnlqcBHaLxl8G2BjxpdDADhvA== IronPort-HdrOrdr: A9a23:D2mirK6Yr8MmKQ5VRgPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="83935897" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a90wsQFSMtoIcjdH4LA8NwcmmtVrQPBbBzxL6ucDC+YyA/N1sgr1OwEBbRaqFAlTKZdng+K6quEZ3yanmXcUBCcN7jF4nE0FBjSLtNhHybOsXLsKPZ3rRVbAUg0ozxhMqTEzKH2+m1ACRX09KsSUXsu4QAB+tlS72Wq/StWm5QNZEqVEtf2auBSZvPyscuLHJM49DF+J2tTZg5+kZgnBzsnACux+szRu/LMaZX0c58pwaYIxH52mE/Eh8NRSXos+203UadUVHysuu+p1XYqLBQ9SAQu7G2QgAG0SXljlWd81PL8KAgHy7yHUVnlEx688eq0uGoqSI+3tGwvzQzgqsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p4w2sn6T2auAzZEl+2AzSpCcJnJlNsEBPwgwER5SX5k=; b=SFDfFRjRcU2B6EPLjnjoVYty8+RPFvL9HXTReUj3skSVSHtfTOsfxOsauVKV3y+J6xZ5LKJzXj77w9g0aRC6v/UcOGsUwN8f4nM4ej82ThKJrUcUW6wD3bbehXFvKQ8rfv8MFVgwXtKxxqY8hczmuilf+0WmMVDhUpTEjMnXvEOCUMFXuNf7pBeMw1TzoASo0E4o7yDDNrpVjxG7JJuQ2WIPtpgaAfLA/yKFlJMd6gjc3zBO4Mlj/0yFt2zj7/B+uw56J3YZQWiQbNo61GvnPINZBYZHkYf++cs7lytjOmPmIK5VNmO6kyx1b0mqm7bI++ku00ZkofmNE9ZJBBBhdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4w2sn6T2auAzZEl+2AzSpCcJnJlNsEBPwgwER5SX5k=; b=JDkjKtQojdS7bE1nBoduc46l70FepVFjYgNYJuc2/8wLNurjxj1oEZz2Q1gzRYMMyuX1ZgXC55sG8YGUH9DqwElifoV7YY0zgH4T0Ha68ay4KdSYqQ2wTbF5owKKwr1/4T9SCOXzq2GtCzbbt+rSOl5dS7t+9k/0UpH9rkWyqK8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 27 Sep 2022 11:33:40 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220922160516.5929-1-roger.pau@citrix.com> <3ab6e33c-58a4-8db7-93d2-631b60e9772e@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3ab6e33c-58a4-8db7-93d2-631b60e9772e@citrix.com> X-ClientProxiedBy: LO2P265CA0237.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::33) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6526:EE_ X-MS-Office365-Filtering-Correlation-Id: 273e8f71-a2fa-4a4a-2fff-08daa06b5fee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AcTnSduOoi3f+8IF7Mzir7z6wAMgDCTNgT5Lk6DUoO/6/oSvbubQZCXyPEZpV+zO8Ueljr9AHGpu4q4EkJ8Fs72bOlJm23xR6YfJFYsdtSoF6Vt+fqcYi5GkxJR7CU0/LW70QuFpe068kwkJd+y12lkeiRAcMhEGc0fhsSCOTs7iBigBH3lJ0bQUOY+h0t+ISKs+gYAQkJFWjcRUZrLR4YcICI0R+UzSu2+WXFAimcSh1UZYUXzB/kwQnZgJYuN2Tl4md90JbNTOHe/S5VKn2+pZJ83GFl9ekQpoektUC3TM+9k322EGHV7gxToZq0+RyjNZOtSAUQcGqrDtIA2DolfT00VYDvjy7naou9MPauSeaQKCUk9Uz2MqYLQdVKvA242R7Gd+2Fg30bI1VEnLgxjoadKGbqHMM3Tn9ViyDwugsxX1L6b5pI+GMwGFVYvzO09CM1EKIW/J2bUIVGJY3tZrHzLvJ5Pv9F1VMNlR9jvWFS+ksatOj+AjBG2FJAhtLpGSbfAD0vG7RT3ckU5HrrLTPtSITSeXv9jShSxVzU51noKn0/9RrvpQRCRjgEqygmEfPKb/BtD7wpWZh4pzXO0IK+06PCxc1QeVbLy1CvzQF9zLoeBD0OPfGpC1v5JAcMN6QS5AqzFyoyayOy25dXVQuTD7Be9fHZQ+RyFnY07aHLEcFF5yDKuPBpIiPLOIemYRrpIVit4qCH5V2lSlx20mxnCd7LpOONTlJzXiSHOFKhGNvg8phsw5wMcoWO+4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(451199015)(6486002)(53546011)(6506007)(478600001)(41300700001)(5660300002)(966005)(83380400001)(6666004)(9686003)(186003)(2906002)(26005)(6512007)(54906003)(6636002)(6862004)(66556008)(66946007)(66476007)(8676002)(8936002)(316002)(4326008)(82960400001)(86362001)(38100700002)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTNNZTJXbTZTQjUvQmVmWFJTb2gwY1IxZXk2VVNkSEJoOHltbmhtZWx6c3B2?= =?utf-8?B?eDVQVHpoQWtNMnB5c0E5elhWdU9LT09jZkpGRStKYlpLL2c5c2p1bThCNEtT?= =?utf-8?B?ZE0vVVBKVEhMWGJWa29sdVd1M0VSSkxPZmVQOU56aWIzcmt2V1lvVHlNT2Ur?= =?utf-8?B?cldnMU8rcXo1cUt6dHIvclNTNkRnM3ZUdG1uTS9jNUl6ZVFLL3NBdXlCd0pk?= =?utf-8?B?Yi90eUpxZWo2cEx6YStYOG5kQlZiNUEvSGQwS2FLQnRSRGxEZzZXSkM2dm9o?= =?utf-8?B?Uyt0VmtraXJmOHMyTTlJeG5TUW1jSmZQL0M2RHAwc24wd0UwSzFMYVhWUVZZ?= =?utf-8?B?V3lRTTdYdmxyVjJOOERLTFZvQUJ3N1d3MkNnQmhlcGtMRkgyVWJCYXhqc0xX?= =?utf-8?B?UVFzWXpzUVpMSDlPS3pNWUdPM2UzeTdjTnNVeXV3R3JNQWM0ZkFnYXhNbkpW?= =?utf-8?B?anVQaHVwMElRZlVXaUptKy9Md1RPWjU3NHJJSXZoV0RvWFMvcHpjUHk4TzAx?= =?utf-8?B?TUhoaHgrdzFjaVVhTHBvcm0vVXFMRG5lVDd3ZWFGTFBqaCtCS3F4SUpFYkFt?= =?utf-8?B?WDhrZjZZbzFGTG5RQjM5NTgxdDVmYmN3MXA4V1JaMUwybDZ0TVpla1ZaQXNB?= =?utf-8?B?YjFWQ01ocnNSM3grajJxZ3NNMlZ5ZG5GdG9mUTRlRG5NMEVjRGVLMStUSExM?= =?utf-8?B?VnJxamowRFh6MGRyaU9JU3VPcllSdm96L2dqT2R5T05NbUUrTzdQVkp4TlJW?= =?utf-8?B?UWlORzJZL0RteE53RTI0dnVtQVl5eE10YkhRR1BBejdWZ0NESXo4SzdXeWxK?= =?utf-8?B?SDRPZFY2c2FSb0l6Mk9ZSkhVL3RBVDFhaVR0ZHNRM2dUSEJhNUNyRUtjb0Vj?= =?utf-8?B?dCtSZUp1ZU5vdGlHbXByMU5teGpacm0xUkQvNkpNb3o4M2hhWTdCSWRPNGE3?= =?utf-8?B?U3BZMlFxcndZTGNJRUFxZ2RNbGJYakc5RG5UN1MzeEdaSmRiNlJGeHJLeXNM?= =?utf-8?B?NXRIWDVQMm5FbWVjNkNaMUhDWnpTM2JsMDFvVzcxZDl3MkhHOHcyYm42OU0x?= =?utf-8?B?cEpYK2xqTU1Yakc2WnNPeVVudFlaOTVGTXc1cjJSYXB0bldUUU5xVHlUZGhk?= =?utf-8?B?cCtmaXMxZ2ZVMDVoRE0wTlk0M3R5ZzFiKzhGUHI3UlhaMzJGZ25KTHNJcHIw?= =?utf-8?B?UnJIc1VOajZPSjU2SFVYdHl4TDlrZVFIL2NJWDl1QVlXbGNzbVJpNnFwYkk0?= =?utf-8?B?b3hTcllGVVRIYXhaZENrU2I1UnZZTG1aKzBXUzgwb2ZVUXVzQWdUdXQzVWNx?= =?utf-8?B?ZEJvWHRGTDVKUXZLdWp3eHBwL0p1ZnNDUXA3SDhVVi9mdjAweUg2NUdjcHor?= =?utf-8?B?VjVsRklraWF3QVR2b0NOZ0d4NHlBeGsycWo5SVR3US92ZnM3N1VQdmU1VGt4?= =?utf-8?B?VFY1bGJHOHBYMEh2NzdDWkVvYVRnK1Fkbkd0S1A5VTJHVjJXZDFmWnFKYisx?= =?utf-8?B?eE8rWFRKQllUWXYzdUhpZ3gxM05rcVRienNSSVYraFA5WjJWR0hkSi8xUkRS?= =?utf-8?B?NVpra0YzVFBvVzR3MkFUSkhCY3FmbzkxRHJWU3NvRjQ0WWRxbUZzQjhWUmtE?= =?utf-8?B?TjFlUzJzREhaSlU2STJqUHV1bXBtVkFmbzdhekJCaDJuMC8yeXpLdW1jdEx5?= =?utf-8?B?YmV0bkoycmpQTm40THh5YXpvblNwcUlURGpYeDBTRnFvTUxUVm9CS01nQjlR?= =?utf-8?B?UGZEQ2V4NHRLMXhLcXVXd2ZqMGlJRC9BeGJzV05oZm9UdkFqM01lT0ZRVlg3?= =?utf-8?B?S3NRbVFHZzlKNStyYVZaWTNrODh2ZFZNQkxoaVVLSUNIL2o5Ylp4TmM2b0lS?= =?utf-8?B?UldveW93Y0l1ek9BTHRUOWVnNGdhTm56dnNEelQvMlp3VWNlNEFhQWpuK0gy?= =?utf-8?B?RU52N2IxQ3NGZCs3Q1ZQbzlONFY5QmV3OUNsRGlBTkZWbmJwR29pTW94TXM1?= =?utf-8?B?Ny96cmNnU0JXWWU3TkwwNW9pWTdKazl0cmcrZkRBdTdpcGZmNXlGeEg4aFBq?= =?utf-8?B?Z041amlhaU5TSGxuMFd4K0Z4M0NtcHYwQzVxTFdUcUQvUGZkTE41T1RPeHhM?= =?utf-8?B?R1M4dEZ0a1dSbWtWN01venJvTzV4eDZCdlkyNHhIN2FiOHZkRG9iV0FlL2o2?= =?utf-8?B?Tmc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 273e8f71-a2fa-4a4a-2fff-08daa06b5fee X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:33:46.0561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Uta2FUuJkIED6Wrjk9Ka3bKbLRHH6q9LLBkKVonV7mqX5t1yY/789xGApermm32igvf23gGdoCaSvUcG2O8/yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6526 On Mon, Sep 26, 2022 at 06:03:24PM +0000, Andrew Cooper wrote: > On 22/09/2022 17:05, Roger Pau Monne wrote: > > memory_type_changed() is currently only implemented for Intel EPT, and > > results in the invalidation of EMT attributes on all the entries in > > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > > when the guest tries to access any gfns for the first time, which > > results in the recalculation of the EMT for the accessed page. The > > vmexit and the recalculations are expensive, and as such should be > > avoided when possible. > > > > Remove the call to memory_type_changed() from > > XEN_DOMCTL_memory_mapping: there are no modifications of the > > iomem_caps ranges anymore that could alter the return of > > cache_flush_permitted() from that domctl. > > > > Calls to memory_type_changed() resulting from changes to the domain > > iomem_caps or ioport_caps ranges are only relevant for EMT > > calculations if the IOMMU is not enabled, and the call has resulted in > > a change to the return value of cache_flush_permitted(). > > This, and the perf problem Citrix have found, is caused by a more > fundamental bug which I identified during XSA-402. > > Xen is written with assumption that cacheability other than WB is > dependent on having devices.  While this is perhaps true of current > configurations available, it is a layering violation, and will cease > being true in order to support encrypted RAM (and by extension, > encrypted VMs). I assumed this was done as a performance improvement (or hack). > At the moment, we know the IOMMU-ness of a domain right from the outset, > but the cacheability permits are dynamic, based on the non-emptyness of > the domain's device list, ioport list, and various others. Well, as long as there's an IOMMU assigned cacheability will be calculated taking into account the guest MTRR values, and won't be forced to WB, regardless of the emptiness of the device or IO ports/memory capability lists. Just setting `passthrough=1` on the guest config file without any devices actually passed through should prevent the forcing WB. The use case of allowing io memory or ports to be assigned to an HVM guest without an IOMMU has always confused me, but I guess if it's there it's because it's used by someone. > All the memory_type_changed() calls here are to cover the fact that the > original design was buggy by not having the cacheability-ness part of > domain create in the first place. > > The appropriate fix, but definitely 4.18 work at this point, is to have > a new CDF flag which permits the use of non-WB cacheability. > > For testing purposes alone, turning it on on an otherwise "plain VM" is > useful (its how I actually debugged XSA-402, and the only sane way to go > about investigating the MTRR per disasters for VGPU VMs[1]), Wasn't it enough to set `passthrough=1` in order to enable cacheability for debugging purposes? (not that I oppose to adding the flag, just curious why enabling the IOMMU wasn't enough). > but for > regular usecases, it wants cross-checking with the IOMMU flag (and > encrypted VM flag in the future), and for all dynamic list checks to > turn into a simple 'd->config & CDF_full_cacheability'. > > This way, we delete all calls to memory_type_changed() which are trying > to cover the various dynamic lists becoming empty/non-empty, and we > remove several ordering-of-hypercalls bugs where non-cacheable mappings > can't actually be created on a VM declared to have an IOMMU until a > device has actually been assigned to start with. It should be possible with current code to create non-cacheable mappings on a VM as long as the IOMMU is enabled, regardless of whether no devices are assigned to the VM. > ~Andrew > > [1] MTRR handling is also buggy with reduced cacheability, causing some > areas of RAM to be used UC; notably the grant table.  This manifests as > PV device perf being worse than qemu-emulated device perf, only when a > GPU is added to a VM[2].  Instead of fixing this properly, it was hacked > around by forcing IPAT=1 for Xenheap pages, which only "fixed" the > problem on Intel (AMD has no equivalent mechanism), and needs reverting > and fixing properly (i.e. get the vMTRR layout working correctly) to > support VMs with encrypted RAM. My understanding of the original problem was slightly different: we place the grant table in a BAR region of the xenpci device, and hence the gMTRRs are set to UC by the guest. The workaround in Xen is to cope with existing Windows guest drivers not setting the gMTRR values for the grant table frames to WB. Even if we calculate all the cache attributes correctly we would still need the 'hack'. > > [2] There's a second bug with memory_type_changed() in that it causes > dreadful system performance during VM migration, which is something to > do with the interaction of restoring vMTRRs for a VM that has a device > but isn't running yet.  This still needs investigating, and I suspect > it's got a similar root cause. XenServer seems to have a custom patch for this: https://github.com/xenserver/xen.pg/blob/XS-8.3.x/patches/0001-x86-HVM-Avoid-cache-flush-operations-during-hvm_load.patch But we could likely avoid the flush completely if the VM hasn't been started yet. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:40:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:40:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412356.655627 (Exim 4.92) (envelope-from ) id 1od74J-0004V9-8D; Tue, 27 Sep 2022 09:39:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412356.655627; Tue, 27 Sep 2022 09:39:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od74J-0004V2-4o; Tue, 27 Sep 2022 09:39:59 +0000 Received: by outflank-mailman (input) for mailman id 412356; Tue, 27 Sep 2022 09:39:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od74H-0004Uw-Ro for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:39:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58a0be4a-3e48-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:39:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8111.eurprd04.prod.outlook.com (2603:10a6:102:1c7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:39:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 09:39:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58a0be4a-3e48-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=if0Bnx5+f/efCn+a1maG3bCPzDFPFCpXlNRAP7e27Hzy+Isbz1yvbIL95iHOdrDLUmXHDGdCs2LWrl4QOoPnUGXVmw1pKAM3XdMcwSkQ3OgHiYGlLFQBgjpQGr5kF6TpnpaFHTdDcNtz46vk+9tST5VuxgIRak6sLQU4dJw2Q+H+foNXYdu7Zut8RgOJviPp3Z6qA19jpYffqVaB8fNCCxa14OBlfpz14yn4qkIVFdFPJZrQHot0vk+tGl2S6FNBozr+MWw4qohokjT0KetERxIxbnYPO0Uya00FWm2vk6myjOkjEnDiFoSPDenkAQTuoUFhibfoQCEJfCLvSpkq2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9kFhuTcFtVZ1SWWyJmIBrW3Qdox9i1MyNKA5SDvbRw=; b=Yk3Ty4wIUx04YQXLGAKhTaHpROsH9+xomBDj4nfo/HWcv5Rhnz3bykJIkNY8Eqbiqh4rNM09RiL6wzH3b//CpU7StpZ7typxi1eneMtBCz98V+0W2RElEPSjE1x27+TS1naAHhXBo54KYN7+H6GsS6cxdHQSC5v8rdF2QEEyOYxBvL0TgGf0CI/XO2hplcnKL9HhYkT1VLFkC6nkkM5VDNJW6S9NicyIOFacAm82RjuJbjfB/H8mtv3Lti2MPu2pvlp0O7HiWXsyJeX0B3X7s5/kBcuUk1fWzcgpVREqJbYShU7vPxLAKaYXICU0HT6bi410LjYimCmdO+HX9PERaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9kFhuTcFtVZ1SWWyJmIBrW3Qdox9i1MyNKA5SDvbRw=; b=i0SumFZLDA/ZWwg2fSOg8Wd3yHuHMi4XdIZxWtHPfpz5fw/XpKRaNV7gs9n7iY6W7A9NpCuJ+mEI/vbcH/0VnbBAX8tPTTkPsRMJX9YVbRncq8t/88d67KQRWCD3EqW3s4isFgE/+M2uppXU/eGFieEGkdbr+t+E1DIuPm36LDolLV63PQoerREAiDyCR9LgD27K7IxkbnrqJLnxyaj2hfyqTI8q8kKy/0EeAA2yfg/wQTb1m761DcQJFjXuTsjLc217Es9l592WFSPxfYSz99tV44tHZlr9Z4sNTi9W8qtPaOad8gB4FzWOJ8ZD8azJdaKPDz9mgKDR8LJFbpgsEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <504534ec-32bf-0bab-7a61-86d75b6e1f71@suse.com> Date: Tue, 27 Sep 2022 11:39:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US From: Jan Beulich To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-3-wei.chen@arm.com> <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> In-Reply-To: <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8111:EE_ X-MS-Office365-Filtering-Correlation-Id: bb9e242b-3a5a-43a8-a92a-08daa06c3b73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ceXxCP6j674oXpv92qKB/RHVvQRXiFT35cPiSfE/k4F8C0cThU3ZZTZw355WN3gDqDLKI2kbbN4tNYZv56Lghd1svnW12YqaF9eueeQjAagmCGRLg7a1F1QGnXUP0gV3NaZgD0cIJyVHBQ78/v4BKa6JFwvzmP/BRMpkcDQiudFSg3pxmfXfdHlj7E4sp/sK90qeOBC06mddclo+pIZFlRhE4DmqeWjuv4wFTV8KwxpXQs3HEuB0TLBo/MxvRf9cHXPQYpKROKEwqqQT/gJ5VkTIaAxNjUiqBPeJpHrk+NamtH/OWnE6xvvFYN6aZPtRdmwuzDfOj6hp6mxpEVry9YBXfjs5w0qmN0WTiPo+TB9liCYmjFFbS76Dg7RZMYnkRHVa+gBRFVt4WM60DhJ4Qah+wyxQyyhJMMZLa/cMd+ji9GNNG7yG+4qMuA5fYLtEm29JIQLQIhjv8CMLfPk/k91dDEG0/LWYB6Z3APXuxZNcw/7L8aSMRvhlDoFhbf6xoFBZNTLeVDPidb+hJP6rpxGOzUh2jrrn+ojtg0e5YY46BdKrEVlmzwYQzM2xW0cbx/NmQVlFTGCkyYnsZrmbPRdjYpSwKqYiR8yojclqBZnZIxzHqpRygSgtKSeg4E9hpoJdcoN8hmsTZUEXDicf94Z7uIBwDSSCcJzQz/engkbnOxVRLvzFOWSqv72sEGxHIq6MndIXBPgRX8wzW+IMOHVN2N/CJ3XlRQceNLmmkzdcbVvmnanmZOOwNwmrZ40+g6N4FocsqEVMMBPG0KAnaZImVvmW6Y2wPHoI0+7q2Lc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199015)(316002)(478600001)(6486002)(4326008)(66476007)(66556008)(66946007)(31686004)(8676002)(26005)(5660300002)(6512007)(6506007)(8936002)(53546011)(186003)(36756003)(2616005)(2906002)(41300700001)(38100700002)(31696002)(54906003)(83380400001)(6916009)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2ZUNXVDMmsrb2tVZFpxNUY5cnVObjNMYmZwSDcrU2I0ZkcrVW1QalJaZWJ1?= =?utf-8?B?MkJEWmtzTUxEVmFjSzlNZXlEb0NTYTNVZUhiTmhqMzg2WGd4T2pNR1lSanVG?= =?utf-8?B?aytPeG9NdXB0TkVPWU1QWEt0MmFiKzMreUJQK2ZOL0c1R2pyNE4weTN4OGZC?= =?utf-8?B?MjBpSVB5RlNNaUZlVmd2dDNGT3FzYjBlWEZML0lLbmVsTXNHTXk3am95YnBa?= =?utf-8?B?c0c5RXQ5cWo1RTkzS2tXbGNzRFNxU21ZK0JtUWZsTXdJdlZ3N0ZSRzZhVGNI?= =?utf-8?B?SE5BQnlBWkxaQm5sUVNxVmtWa3I5eUJiYWxtb1hyYWpJbUVuY2E5N3JhRXNh?= =?utf-8?B?Sm1DZU1Tb2pWZ3JRaCsxczQxQmloVG9lQklUNldralBRbnhNR2ZUS2NqRkFI?= =?utf-8?B?dVZNUVlndG1oclJhbGUySStHTDBVcWNHQnRneUYxSTFnMjIxOUZ3WXIwaU5u?= =?utf-8?B?V1czOFNBK04zQksxRnRkbDZwT1ZvbjNhZ3RZRGpwVDJ6RnBJLzBJMTNsMWxt?= =?utf-8?B?aXU5RUg5Si8yQ2RDcE1kWHBHcTkzWm5EaXJLdGxuZHRxdGZnWXRpWXliLzVl?= =?utf-8?B?bW9oalNGUEEzdlNRNHNVRllrWXV0ZGROSVdZempFaDh1NmNUL2p6RUdBNDVz?= =?utf-8?B?S3dGNS9oWXFKN2dEMUxXOHZGZ0UvZDZEWllPeHRtalhBUVA3U1l0MnNqUG9D?= =?utf-8?B?NXd4bE1xRGhxQUs0VkpYQW1ST3FkZG5penhIbWJmN3lVWm5UKzJ0aEJLVE5P?= =?utf-8?B?YW03ZGtLN1M2RTdVTEh1SXMzN0lMS2I4dGR2NDRKekVhUVBabUlYTGUwdEhX?= =?utf-8?B?cXhzcnBCVmZIMW5KNWZ3dnZEa2xjbi9MVXVyd3lycGIzWlVCeXpxZjRlZEw4?= =?utf-8?B?WUxkbXc2SVBKQ3haajdhUFFCZ2d3L2Jnck43VFBIajZHcG91R1NtMk9uUUoz?= =?utf-8?B?RWhVakdXR0Qxc3A5TWhOemRHOHp6T0FidVRqOStKbDB1ZjBtU1NXWjhrL2ZV?= =?utf-8?B?UXNXMUlldmpBVHpyY092R0RPaUZZcWx0TS8wWTYvcjNMWnp2R3J0MTFqd3pZ?= =?utf-8?B?YVJDTWFRcFQxWmRnbnBEbFdHeXc1R2ljdlYydEV0OVBsUHpDT2Q0SzB1R21j?= =?utf-8?B?bDZnK0F1aFIxeVRGNnRkZTdhNkFKRTlPUTVUZFJPdWZDYm82b3VnTVo4MWtQ?= =?utf-8?B?OUl6ZEVKRm5XQ0xYc1UvbWRjcFllcmRQNGlyRXpKUjJlV0JpZ2p6SWJ1c0tC?= =?utf-8?B?d3BBWGpFMVZWVW1idjJsVjdxWmlXYjJKTVlIemEyc0QwVlpHejc2cUNXcWR0?= =?utf-8?B?Vit1ZmljY0lTaTdCbWZqN0hTNkFBKzlvWVhlM0gvcHhpZUQrRENxck5vRExj?= =?utf-8?B?TWFrcTRyUExCbnVzdGNYZVROeDlnbXd2QXBBMERQTFNxLzI1TlFVampaVnhJ?= =?utf-8?B?bnk2Z1BTeUNIWEZEcXBBS1NURlZTdURWOGpOcjdlU01NMTVzYXV3ZzVPUXI2?= =?utf-8?B?d3Y3OVZhYm1EeDJ5MDhMb1hFM1NZbVcweDYwVldGL0c1cCszd1RNRmd4M05Z?= =?utf-8?B?WGlnMVpuQTd5UGhiRElsUG1VaU84dFJUVGtNQUhpYnQwM2YvQUFXaVNFbGtz?= =?utf-8?B?U05WdDR6VlBzdWpmUTlmcmtKSUxXOWdjcmp1Tjg0NWlYejA5d2xCSmJrQytK?= =?utf-8?B?SFlGWjBOSFIxOFp2RFA5RVVOcVhGZ0JseUVUTFZuMTFCbDNsNkw4dzdCMzdu?= =?utf-8?B?VUF1L3BqZGtGbzh1SmlnSkFMdkVXOWNjRGVSeC9DYjE2Qks2OTdqT3p5VnBF?= =?utf-8?B?ZXV1WUd6SVpFdDlQYXR3N3dleUdjN0hXbGdnM2d0QnB1eFVzVWVoR0R3Q2Z6?= =?utf-8?B?M1F5NEVNYi9UNXlETlpYUjBibHB0dHh1UFo3UXhidEZyK0tsVGRuMCtwK3hV?= =?utf-8?B?WnRPckllMUlYM1Y4U1VnMitGR1ozSjNjQ2JCYTFXRUlJWVdDN0VkVktXY1dF?= =?utf-8?B?cDdtM0RHeENVMzhtd0RmK0F3MnB3eWxqOUJ0UHQ2S1A1ZjVsMlBBTHhISmx5?= =?utf-8?B?Z0FTUWlEWEVONXpmdGJQM2dtZGZzU1N2cnhoNFlsRzZzMXh0VEtObmU3RlRp?= =?utf-8?Q?c4q1PGL8vS4+NY87McwOVUo1V?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb9e242b-3a5a-43a8-a92a-08daa06c3b73 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:39:54.1944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FfqH92CXBKKvoNXivtAY9ANUbOzwhpEtOQdarTF8/hzBIKgHh6GCatIm4Cszko/7V6kgW32xT7cENS66NeNkKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8111 On 27.09.2022 10:19, Jan Beulich wrote: > On 20.09.2022 11:12, Wei Chen wrote: >> +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, >> + nodeid_t numnodes) >> +{ >> + unsigned int i, nodes_used = 0; >> + unsigned long spdx, epdx; >> + unsigned long bitfield = 0, memtop = 0; >> + >> + for ( i = 0; i < numnodes; i++ ) >> + { >> + spdx = paddr_to_pdx(nodes[i].start); >> + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; >> + >> + if ( spdx >= epdx ) >> + continue; >> + >> + bitfield |= spdx; > > Perhaps to be taken care of in a separate patch: We accumulate only > the bits from the start addresses here, contrary to what the comment > ahead of the function says (and I think it is the comment which is > putting things correctly). It's the comment which is wrong - it wasn't updated in Linux commit 54413927f022 ("x86-64: x86_64-make-the-numa-hash-function-nodemap-allocation fix fix"). Our code was cloned from Linux'es. In fact when memory is not contiguous, too small a shift value might be determined. This in particular also may matter for the lowest range covered by any node: On x86 this will always start at zero (and hence won't influence the final calculation), but iirc on Arm memory may (and typically will) start at non-zero addresses. In such a case the first node's start address should be ignored, as it's fine to (kind of) associate all lower addresses (where no memory is) with this same node. But that's now indeed something which will want taking care of while making the code usable for other architectures. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412366.655643 (Exim 4.92) (envelope-from ) id 1od7Bp-00065D-GY; Tue, 27 Sep 2022 09:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412366.655643; Tue, 27 Sep 2022 09:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bp-000648-Ao; Tue, 27 Sep 2022 09:47:45 +0000 Received: by outflank-mailman (input) for mailman id 412366; Tue, 27 Sep 2022 09:47:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bo-00061O-Mr for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:44 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2045.outbound.protection.outlook.com [40.107.244.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e73fb65-3e49-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:47:42 +0200 (CEST) Received: from BN0PR03CA0024.namprd03.prod.outlook.com (2603:10b6:408:e6::29) by CO6PR12MB5393.namprd12.prod.outlook.com (2603:10b6:5:356::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Tue, 27 Sep 2022 09:47:36 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e6:cafe::5d) by BN0PR03CA0024.outlook.office365.com (2603:10b6:408:e6::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 09:47:36 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:36 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:35 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:34 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e73fb65-3e49-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fasb06A/PZTFUZNfItDs3GAg6X5niKPL/WKfuuDVPVjGcwl9Ey5xGYQetwwTnXDiQ7GWMTuhBE605BpvYsDL90CWwLX8K4oCWcEGsow21LWXbYhrfWgQm9f5k292A8iQt1Xvf3AKzrvt3gfiKKDgPeT3Mz4H4sJY6pg+6eoj9BsD0RE6rq2zx7zJPb/oKn+2ESLRElhiqE9EJ19Dgy0W/XKphPJ1ZRtE31/oaffc0MgSrepLo6q/HgfaHgSs5Ud1PwZnn7SA/+ix1uehwb/G4X3siFfoFCfuMwYWmgLufpypVQ7/2nZS+TB8TvdW81lMOG0Xt3xI6rdvEorSneMLuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DMRTS94bP5mzTyp0C3TVUX3OC0p29wzVci5VOZBrKaU=; b=BUU+cet6U020TPLzgUzpTImJiszwaWHPGTHvrL/CpdAANvFc1qMpwF0MjpDuMQxGoO5lG/0z1O6Th29SiZnzFnMlr2ulTv1M0/sManDN7fhIBoWXACN5MPOgvgdWYQ2h0zUaon9apmthTkr2pgSIH2N5XQ7u1aYrteUocftkAgpM1a9NmIfc9xZaUyKxMOZP7ZWPuJcYjgwFq201kQv/ydbyyDUlksYA5MP/+XF0gSrSxhxKw7x49ogvVNDyDHGIaL029nEAKptfHZGi5/7svCY9VTdh7m+pLa/MHEJOpjfxSxcd+1xDYkEYzm6Q0QNHjdi5A4QjiepXLSjwttLRsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DMRTS94bP5mzTyp0C3TVUX3OC0p29wzVci5VOZBrKaU=; b=WmnHfXxewfXz1KLHRO5UqEVneMgRhgYgiBb3/GcGISBAYv69cu2Wm8zU2UAhxyV5HGcb4rFSco/zOCyeks/EbyQ1BuvfPepodYedk4UPUwUh8uvELBkQ7JpKxHqatP5z5IMMMyUs1uCTTkuHYxdIENAwmJxhJE5xsQPBFxThTzU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 00/10] GitLab CI cleanup & improvements for Arm Date: Tue, 27 Sep 2022 11:47:17 +0200 Message-ID: <20220927094727.12762-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|CO6PR12MB5393:EE_ X-MS-Office365-Filtering-Correlation-Id: 3985efc7-e83f-4ccf-456a-08daa06d4f05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZETgDIUOiBhzjRSSjhMOwrdJeJ99ZG0xLZrgfWzmIQuidX9HZMfXmIaJGc1sD7GaHIYyRBHpeH1VRIit18f5cXsYyz7aThJsOy1t4exDMDWB2EU6erChj6qLEV8uusgNAClE5OjpDdItTPB02gS9grxRT75olaL5yYVW6kxGNKmPeOLXxFnyIVIvIFheHgk7RfibDRM7BMvaB0h4Xa2Xh4QdXm6mHMOQXUTbyT2vcgQppx4Paj/9joVx25n1CDKXw02CT5ADSI/biGjqZwOJ3Og4wDzQ4FyQv7YLqmEiWrAAYvL9vj7VNo3TsnAjZotcuSU0XJY7tRZlm2+z8fHrNcokvYMxRKXOBHgHxGW4XTEzfK1Zx7S9GWELGPhejL5VKirdUqctgzt9KgjuCcyeeR+0wS6INsICpZAYRtMdiJPwXh4T0AsKi32Nq0Wj0NVGCl7hEEfzHX0ceUBe5TEm+nWMPVHWhWJQmyNq/+fIuAMyEvKuMtjPnQEf86k1+Qe33c0T6xXVRtQxkojhCP7PJ4SNAMh8uDi3f8DoxD7G7Ghds2gI0/6lIpsAyiB+aIRQnxPwiYdel1UTogr1i/gS5WP5HmMLrw2NZwVAgZZ15HH3Ocqo89HPUrrlX2khKRTUXh35HQoRU+zoNMOF+uIkcdNe/lBWfD1MEeWmRuuVGwDHD/uu4/bXQvtXhR3VGpeqkQ7JIgu4AhbQt6R2FC9r3lcpgkQ0cz0I3b4huhRXvlw39QiWlcDz/GQ4uXKJ8A3/CKF71UenuxPtPT/Bar8XPrskOySqvT1f8TfDZCqORqN8LZH2fw6jWZa8lQgwgXny X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(5660300002)(47076005)(426003)(8936002)(83380400001)(70586007)(70206006)(4326008)(8676002)(54906003)(40460700003)(478600001)(316002)(86362001)(40480700001)(6916009)(36756003)(6666004)(356005)(82310400005)(81166007)(41300700001)(82740400003)(1076003)(186003)(44832011)(26005)(2616005)(2906002)(336012)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:36.3346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3985efc7-e83f-4ccf-456a-08daa06d4f05 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5393 This patch series performs necessary cleanup and improvements in our GitLab CI automation for Arm. This is crucial so that in the future we can focus on adding new tests instead of spending time to fix issues, making the behavior consistent, removing ambiguity, etc. With the increased interest in gitlab-ci and using it locally, there is still some work to do mainly to improve documentation. This however, will be handled in the future series. Michal Orzel (10): automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT automation: Add randconfig build jobs for arm64 alpine container automation: qemu-smoke-arm64.sh: Increase RAM size automation: Add debug versions of Arm tests automation: Add Arm containers to containerize script automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder automation: qemu-alpine-arm64: Cleanup and fixes automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh automation/gitlab-ci/build.yaml | 28 +++++ automation/gitlab-ci/test.yaml | 113 ++++++++++++++++-- automation/scripts/containerize | 3 + ...moke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 59 +++++---- ...pine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 14 +-- ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 8 +- 6 files changed, 173 insertions(+), 52 deletions(-) rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (54%) rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (88%) rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (96%) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412368.655665 (Exim 4.92) (envelope-from ) id 1od7Br-0006ZX-2M; Tue, 27 Sep 2022 09:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412368.655665; Tue, 27 Sep 2022 09:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bq-0006Yh-TR; Tue, 27 Sep 2022 09:47:46 +0000 Received: by outflank-mailman (input) for mailman id 412368; Tue, 27 Sep 2022 09:47:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bp-00061I-Qf for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:45 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062.outbound.protection.outlook.com [40.107.93.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f4eed5d-3e49-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:47:44 +0200 (CEST) Received: from BN9PR03CA0718.namprd03.prod.outlook.com (2603:10b6:408:ef::33) by DM6PR12MB4202.namprd12.prod.outlook.com (2603:10b6:5:219::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:47:42 +0000 Received: from BN8NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ef:cafe::5) by BN9PR03CA0718.outlook.office365.com (2603:10b6:408:ef::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.27 via Frontend Transport; Tue, 27 Sep 2022 09:47:42 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT048.mail.protection.outlook.com (10.13.177.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:41 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:40 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 02:47:40 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:39 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f4eed5d-3e49-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ql16UGpPEA3xyGtwRFmtmbmCJqfgcBgKUVX5q+5/YHUSi74a0ny5dMWIErzMhc1/NnQY8zeoxaRlusygXC79MIWBfbqevqvIAfiW2NSahQcB14bWdVetIN79vJxXIWvkojs2WEjlNBY1X2rMDguX4XtevzM/eET1srBy/guIKYTL3Cz37pn5XKAsy+JJwzv59ct1fdmsWJh3gRwB/P1EXPRtoTx6Mq2MUeUO2A/5lK2xlXHhBBBIatb96u6LfwAs+1UuDRjInxMnrrLnPRchn6JRmCYDyRYLl5xQKyn+kYnirP+pF0X1AsnXnZjPQ6y7MnqGoXSHXU6ezAy8WFeVWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fY5JlIKf+ph5S89SuUOmRzi2nm3ceC5eVYCGsXFJMeo=; b=bnI+N7MdzMDifH8u5/4XO8gI3V6tIQDrEVWESFX+/YPDn0pqyOZgcWF1iuIj95J0JdK0L4nafN7XnfmgZth/ip4NBNSoWfiUKeVOWSta8D+akVgGs1TpBDAy0IV3H62zaMdR5Phg8mHIFQbe5RrDlqgbqNpsoIjrCH0h2rntRElIYLFwACJsetDKWGEqxWCJUK5aE5lq6vW9RoLnr2eL2G57JgwJ0RRr2hHY/VW7gFSZklsX4MhbHFvqOjU5PbSUuQ5lsGJoiE2CT0TCTvBZpEBKGPqVwyAXAr2qcw4T8uiwApotUCGaerNAZLVYKk9j52nhFHCzf/fJiwj5Qn3vsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fY5JlIKf+ph5S89SuUOmRzi2nm3ceC5eVYCGsXFJMeo=; b=XIVCjx0z7b8jz5V3ANAaECA1c5TaJoheHFGOlcyyDSCnGy4TvvAAKbn6f7Cj7NCYl/cNhvizgkj26zWAVd43GJXzI/1Y29QzwmG7p3QiAzl3yPBAoBiFSC0zEUIXIRVY56RXIzrSTIIYnyKYG07iAJw878n9qV9mmULgJfklS6g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Luca Fancellu Subject: [PATCH v3 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size Date: Tue, 27 Sep 2022 11:47:20 +0200 Message-ID: <20220927094727.12762-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT048:EE_|DM6PR12MB4202:EE_ X-MS-Office365-Filtering-Correlation-Id: 17234022-4544-45cc-193f-08daa06d5244 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vS07UslcptDDVnrgl9V/BBPAq9w6O+aD6su/2zIodvsXQnacfJDVcqYVi4BcbqfTT3rjvy+pjfV9vveh2HdJw42kUPCm33Dl5As04EVyaecCtdTwCsbADVBheQfeotwgYKdebEqoqGYcILRK7xG4YOwn/hGjm++pVLFmu7SebOQnZ2Jw9F8MXHcKQ1Rpqb2uvBEw4DaLofqJoRCaLt3Yq7eSo82KPTuPBJ7GBlGZM3ulNjH7iUttVIK1NZVr0e9x4d+BzTsWZAAa+KE8qb+s7qkb8ATeUcx6349q+xt7GxcaVydB4OTqyvEAWaNGOA7c3yeh+o2/Makcbw7WgwWUV9iPjTLO5UtGymCmv5vZZtj0eHbmIKFws3WoVRomlpIQVh/Ygv67C33ngNupwIrE9HUAK02X7nUTsV0sMgYKDziaEdzGvkQMn1X2B4iD5cZxgktfzFBCuVYYsGxInHAUmoL1cG3/4748RfERTlfXHRyyq8eZoYD5WxVYYrua1xqtWx+KhcDNFYf5iy8PoQnEF2QwffuRi9uJtSz5gCpvukfMvD0bcdJTYBkmNMTvUb+a9ffhT0jmybjqHYFOqcvZqEoS2DNJ8PTKQ6NvGB+JKJM17JfXdCIRJ18Nr657ontfvH+fMeB+AoXI1ywz5a5eiwcr5mqVQWsQi5apg05kd9vCO4drQu6c2EUlGcwcYd2iA6zvYG0LWIWYr0weo+DxyvAdXvnifS/FlP94FhDSpxYGB+qrjkz31MU7M8+/ZVoMmHJq1RFWURzw/8uLyna2s+Fsdwd5ZlksZ4rzy+FCQpQLQthBq3VLb0OKlTZG0RMcQCHsjZ9QlWU6r3MgmqdGOtPgjouFYnOX+qBe//4/iz4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(82740400003)(70586007)(70206006)(8936002)(5660300002)(40460700003)(81166007)(36756003)(86362001)(44832011)(2906002)(356005)(8676002)(2616005)(336012)(186003)(478600001)(41300700001)(1076003)(26005)(6666004)(83380400001)(426003)(54906003)(4326008)(316002)(82310400005)(40480700001)(36860700001)(6916009)(966005)(47076005)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:41.7639 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17234022-4544-45cc-193f-08daa06d5244 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4202 In the follow-up patch we will add new jobs using debug Xen builds. Because the debug builds take more space and we might end up in a situation when there is not enough free space (especially during a static memory test that reserves some region in the middle), increase RAM size for QEMU from 1GB to 2GB. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini Reviewed-by: Luca Fancellu --- Changes in v3: - none Changes in v2: - new patch carved out from previous v1 [3/9] patch --- automation/scripts/qemu-smoke-arm64.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 5b566072f72a..933209e2e01e 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -52,7 +52,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -smp 2 -display none \ + -m 2048 -smp 2 -display none \ -machine dumpdtb=binaries/virt-gicv2.dtb # XXX disable pl061 to avoid Linux crash @@ -117,7 +117,7 @@ cd .. # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt-gicv2.dtb" XEN="xen" @@ -158,7 +158,7 @@ timeout -k 1 240 \ ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -monitor none -serial stdio \ + -m 2048 -monitor none -serial stdio \ -smp 2 \ -no-reboot \ -device virtio-net-pci,netdev=n0 \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412367.655659 (Exim 4.92) (envelope-from ) id 1od7Bq-0006Wr-O1; Tue, 27 Sep 2022 09:47:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412367.655659; Tue, 27 Sep 2022 09:47:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bq-0006Wi-LM; Tue, 27 Sep 2022 09:47:46 +0000 Received: by outflank-mailman (input) for mailman id 412367; Tue, 27 Sep 2022 09:47:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bp-00061I-9Y for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:45 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2078.outbound.protection.outlook.com [40.107.92.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ef4f21a-3e49-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:47:44 +0200 (CEST) Received: from DM6PR11CA0072.namprd11.prod.outlook.com (2603:10b6:5:14c::49) by BY5PR12MB4212.namprd12.prod.outlook.com (2603:10b6:a03:202::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 09:47:40 +0000 Received: from DM6NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::be) by DM6PR11CA0072.outlook.office365.com (2603:10b6:5:14c::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 09:47:40 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT085.mail.protection.outlook.com (10.13.172.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:39 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:39 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 02:47:38 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:37 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ef4f21a-3e49-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmgIT6NSWnCLUnHTaAHWo23x/WYkLeSHRCuGGae5AYqG/VJWw5YFuGF78fRof5/0NN4JGEuqA7kbOPnWciOrRxzo4LNcmhb0qjwrBId4yZ84HqU5EFQq32xZRJc+OrEO3f+80XHeqr4CYbnOmvCDXoGY3SwYxF807vipth/SBjWMtCTHuCiGqC7Xq4+GBUCqOraKbcureBDslSGLngNYKDHlkQ3SGJXTCK+M0dZRC+prou4LN/kmDsah/zqVV7xEFs+jP3pH2R6GRUPG5RmQatc75wjsvCC+sKuGbLj7VMTGOckNrA7qpSsnxO3QYPWWwqQ7mZpUlRNxM7UtmfNhfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JQbVPFIY/NyyF4wKIhFPxHeyMQW/G5sZuOSae7Gxd0k=; b=PJf+obH4jF3rHuVcaQhy5gcNyWsn6h4XRtv7tfKcMzozoFAkWUyXIJ30Hnf8VaRG1vpUrIauzzKpbKwftjlr54OhnV+Os1rFenP7GuTjAQUeJnxYjeC9798kkk2SXfGZfj/nAk7L6Q7zEDIDpIxJyYp4jlIS1bOPn8XoQ3B6EXbvQrOcI/wL3z8+zDw95QVgLV1uTf779mBFGJjxBvLteV/bOd3Gi77dcjMEWqWoHSyTR5glgvuRa/aOD+vMIS2qq5Y2aws5iy+uUqfQBGspk+U2bzZSa0A6zsGZpPRwbXD/PJUc2YiqQgAu0CAg8dScNiKyGBb8sUuuK5pVf8iXwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQbVPFIY/NyyF4wKIhFPxHeyMQW/G5sZuOSae7Gxd0k=; b=zcqFbcm9NupXzSRmJ+hU07XcdOQ0ZhmhjY7EDi06EOxlSui9HUQcrypJxKTR0MlhXCT4cm0XHljgBpN2+aA7U7hlxhQuOT7hhj4p/x+wg7qqajNsCiVIsKBxGwSjMInOvFzNEQZnBDJ3LyjdZhv/+aRmy/fe82C7YGQZpBhkYsA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Luca Fancellu Subject: [PATCH v3 02/10] automation: Add randconfig build jobs for arm64 alpine container Date: Tue, 27 Sep 2022 11:47:19 +0200 Message-ID: <20220927094727.12762-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT085:EE_|BY5PR12MB4212:EE_ X-MS-Office365-Filtering-Correlation-Id: 552d782b-f1fc-4eb2-186d-08daa06d50fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4+80iuSCP8lXly94fE4HeGd88BY2RmWrD1lR2EAaBG+OTVSKbxS1XGBcREPGQysjvrHg20hYXB7KSyuBSs1RTBsCajtDwUW6pkviROFSM/ctfKTRR9LBqHjTv3/0esnSbu1tTVU1vBLfKOq6xjgQuzwJmrHIaYDXckuUAbPQ50zvqQhXPwTABajV9Rs8cKrbOJHFf4SIlG0/r68dRrfSiXU/1SKIGYduNRybgoIHxk+YUb232cMGeFpQh0e2ShLFOJm69/db9KZkZvf2i5HPGL19i/x4Pp05w3L5Q7lm1UgzPTHcnKrgtdQEUHhsryzPAY8XZS6yxgvP5w96aII1pCTO9WCcDKqBg98vSOeOHu9sffw22mS318KvrrJv1BiPiSOkhgglgOTbDYafxVQNtKuaOU8NmztRm5V7tLfEnHD9SVCZ6AD9BzFA3YJLHcpb7yzgK//8lXfVUft5rJB77udEtIEpWYQJdIgboHEQ8PpDRlo5PGbt0+U/03G/yme7K5gk1r+bOUh0S1qgCik7M5B1kWqSVZxrdNCezwCKceSjaBbvrxRHfryj5/8hqUCJofOGYW/ceZ+CSMHO4kB7bwfbHFxCCu+dbX5qXw9cSvuHByFclbvQ4omen0VAtt2UN2zdRvfu6pzdqHMq+Am7odvB+Y0VR1NnxnqOBEcXwJ0jy+VA65SpghaSBQjIbihpZjHv1NjPafJooHUPBWtCoKFZXPcbFP1wQoNwWyFS/t88N52zzSu3ks/1bP7jr30Y5FEHj71yHefZBK1SiAfDnVxIsiIWXAwow5Bdv7nk6SJ2ROryNm4dfnglR9I/s8c4 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(54906003)(316002)(81166007)(6916009)(40480700001)(82740400003)(356005)(40460700003)(8936002)(36756003)(5660300002)(86362001)(70586007)(4326008)(70206006)(8676002)(41300700001)(2906002)(26005)(2616005)(336012)(44832011)(47076005)(186003)(82310400005)(426003)(478600001)(6666004)(1076003)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:39.5830 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 552d782b-f1fc-4eb2-186d-08daa06d50fc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4212 For arm64 we perform builds using debian and alpine containers. We are missing the randconfig build jobs for the latter, so add them. This way for each container we have 4 fundamental build jobs: - defconfig non-debug/debug - randconfig non-debug/debug Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini Reviewed-by: Luca Fancellu --- Changes in v3: - none Changes in v2: - none --- automation/gitlab-ci/build.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a39ed72aac6d..d931441b910a 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -566,6 +566,18 @@ alpine-3.12-gcc-debug-arm64: variables: CONTAINER: alpine:3.12-arm64v8 +alpine-3.12-gcc-arm64-randconfig: + extends: .gcc-arm64-build + variables: + CONTAINER: alpine:3.12-arm64v8 + RANDCONFIG: y + +alpine-3.12-gcc-debug-arm64-randconfig: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + RANDCONFIG: y + alpine-3.12-gcc-arm64-staticmem: extends: .gcc-arm64-build variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412365.655638 (Exim 4.92) (envelope-from ) id 1od7Bp-00061b-5a; Tue, 27 Sep 2022 09:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412365.655638; Tue, 27 Sep 2022 09:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bp-00061U-2k; Tue, 27 Sep 2022 09:47:45 +0000 Received: by outflank-mailman (input) for mailman id 412365; Tue, 27 Sep 2022 09:47:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bn-00061I-Et for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:43 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d5ece49-3e49-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:47:41 +0200 (CEST) Received: from BN8PR04CA0032.namprd04.prod.outlook.com (2603:10b6:408:70::45) by DM4PR12MB5940.namprd12.prod.outlook.com (2603:10b6:8:6b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:47:38 +0000 Received: from BN8NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::f9) by BN8PR04CA0032.outlook.office365.com (2603:10b6:408:70::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Tue, 27 Sep 2022 09:47:38 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT115.mail.protection.outlook.com (10.13.177.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:38 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:37 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 02:47:37 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:36 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d5ece49-3e49-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ebn6BkBmOuFfpg5WEtLL+Koz0Gcl8H0yZJfQw0g/nBcH2Sbid8DULn3ihwo30ZlE0qVELFZOwsIYCHNATet25pipIhGdulhutOTmVxTG/CbTTdS2aTH0DNXiJIiSjamOWCTU3vOrPG0Ov9Vt5Y7be+qsrZyRKQN4OIOqb5Kyvs3jpK4XjcL+s7r3iDXPbgIIVQtCCl1QsrQgPtDl0uqcwWKbWuCj6TBTvPR3mtw+wU1+lc+er6U6PEEiiJXefvOysj6NxLfxiFOQ3myq8k09RhdW/lLKtU3wSnZdDEl2EFm3x2ukYptVI40XX8D7GDkQBQyHkw+QGr2NrPDoGMRw2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62JB3de8FPX7JJGSCy3DTcwAGOHx6Y0JArP/iptZGcc=; b=byvIGWodI7s34W50JdzFiDteAakBdWwIJbffso25vo7oT4mnBk+5TZcdLw3H8z44XX4gqKNfcskpIYDddhr3Xkn/WrrYdjDvkyJoGp/KbfH99qgSFIeKhwNPNmhWVj/6w5aPElNjCq5h/tazboLDdmhWULW3bDRbWzQKAK8MPUgvN+bxs/hmYw7HRTI+0sU6V+sbO6PI/+5/m7Iq9bnaVKVdizvraVXh6e+FeozYvVy5NvAlEmLZt48uCelM7qUeXPXcbzUOv+KBK5zC+u+Z+rXcO5PtJKgUipd6MHNTT+1HReMjpcuNnI0NJ1rOAu5H5dpfiMiwPiSaTytV6LzkqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62JB3de8FPX7JJGSCy3DTcwAGOHx6Y0JArP/iptZGcc=; b=kUALXBuAMA2PXfGv6igWawRHObyrXAh9DmM1yqJlyTZ9QZrLc0qTzqYdmjvGqXCODQ+1JkGhUJit6OYJ+2q7orkasTYvQ5dDhD5Q/lUa2/tlQuaXh2tqdc2J4q07M5F3h21FGMGyaLAY3V2/UWpTq6Hmdi7GwZr/JsKpN9prUFU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT Date: Tue, 27 Sep 2022 11:47:18 +0200 Message-ID: <20220927094727.12762-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT115:EE_|DM4PR12MB5940:EE_ X-MS-Office365-Filtering-Correlation-Id: d0fdd18c-61c6-4e1c-4c9e-08daa06d5006 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QPNifa2KJmnPRFyRrvkLfO4L90T7jD3ykAU4MjdtXfotJNr5RnljyS4RFjD8tWuBS78K2zNAWqLHN8SotzftnKJ2KAGNu8JF1AmBLUd3+3HmUXdTMUxdvQJh6zofIe6mQ9pGyPlaUOvXYvKYkpFyXWzPBvErIF/Sw7kUYVWwUD9d6XkCUyb3kfClj2198BGi4xUR57VrX2PyI8tzcyBsO18qNXUIPrx+l+R10YxXso3t4JLQfWo7KDC9kO2FdYRCfQZ54XKBhtZNZQOcLE4ZudAeQrEBmwUVBw5GNaTjxFkKs0OAl/rhgr2Z7qU5YQCfNot6dsJBPXtx7dcNomkpZFZ5m2LUHKArdAOkCT1uASGd/5W7F8WO+9pzutVlOSMy+2qkmg9IjjdfrGez7vpQV+8olt2J+/CCoj+GkeySTBQSrFvNBE5YjrqexUpxi+I9PFqHE7s9yeBYb/m69KPL56rYhtuUPYuqTBCwFArJTdmoWWYPdljSSW7ArdKYfOBbMXS8HC9/cBUlq/csbtfKN7LOfh4lmuYoBbouslGc/RuGZ7zX+7l3r7wJZYfTqReutd8xSw/gpmwSLST1AuPIBr45C/K6KyizhpY9w7iuUFEuzLmCpVgK2KjQsgX8OBy0i3Pmwqtard+ADSNJXJ02oYdJ9Wu0msd+vavTO3dixLBcSOcWCSm1JjUMkYV2LjOlqCi1poz4cdgrDHk3UtqNRfne/YjS2sPT4X/i1B26Aa36xSMMHzRJZ0pkAKxAyx4blNRGHW1Y48v4sBYAegFu6UgT+6Ojk9TI58n+ezhZZ+TZo+cOYNBUoPzv6aHdfJ1F X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(44832011)(5660300002)(26005)(8936002)(6666004)(40460700003)(83380400001)(41300700001)(82740400003)(36860700001)(1076003)(36756003)(2616005)(186003)(2906002)(82310400005)(81166007)(336012)(426003)(47076005)(356005)(6916009)(54906003)(70586007)(70206006)(40480700001)(4326008)(86362001)(316002)(8676002)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:38.0034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0fdd18c-61c6-4e1c-4c9e-08daa06d5006 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5940 The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. Signed-off-by: Michal Orzel --- CC: Henry Wang Rationale for taking this patch for 4.17: Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interaction while installing/upgrading the system via apt-get. It accepts the default answer to all the questions (using apt-get -y only works for "yes"/"no" prompts). With the typo not fixed, we might get stuck in CI jobs. The risk is very low as we perform pre-push testing using GitLab CI to make sure the changes will not break the pipeline. Changes in v3: - new patch --- automation/scripts/qemu-smoke-arm32.sh | 2 +- automation/scripts/qemu-smoke-arm64.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh index 530f3892fdd3..c8ae0bfb9b1c 100755 --- a/automation/scripts/qemu-smoke-arm32.sh +++ b/automation/scripts/qemu-smoke-arm32.sh @@ -2,7 +2,7 @@ set -ex -export DEBIAN_FRONTENT=noninteractive +export DEBIAN_FRONTEND=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends device-tree-compiler \ curl \ diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index f803835779f4..5b566072f72a 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -38,7 +38,7 @@ fi " fi -export DEBIAN_FRONTENT=noninteractive +export DEBIAN_FRONTEND=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ u-boot-tools \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412369.655682 (Exim 4.92) (envelope-from ) id 1od7Bt-00075i-GD; Tue, 27 Sep 2022 09:47:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412369.655682; Tue, 27 Sep 2022 09:47:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bt-000759-BA; Tue, 27 Sep 2022 09:47:49 +0000 Received: by outflank-mailman (input) for mailman id 412369; Tue, 27 Sep 2022 09:47:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Br-00061O-5x for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:47 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2074.outbound.protection.outlook.com [40.107.93.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 700e7a1c-3e49-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:47:46 +0200 (CEST) Received: from DS7PR03CA0280.namprd03.prod.outlook.com (2603:10b6:5:3ad::15) by IA0PR12MB7604.namprd12.prod.outlook.com (2603:10b6:208:438::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:47:43 +0000 Received: from DM6NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::2b) by DS7PR03CA0280.outlook.office365.com (2603:10b6:5:3ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Tue, 27 Sep 2022 09:47:42 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT022.mail.protection.outlook.com (10.13.172.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:42 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:41 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 02:47:41 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:40 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 700e7a1c-3e49-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UCesbBtIKwbUfv3yM9BXTbMfvhL5GZO5HGbjeoe9NtqJfT+96Te9GwCnzXOhEMFlpfU5SlCV5Ooq7j7CeLzHTahswCA4EQIZY98EgG9B0uYG+U0qidiiY9DRz/53+MwuRXlp6ptd5BOhz2K+p9Zmy3jlaNg29FfOqyF+oFXwzPf7p6VyHegzWmOdqUhhXz/KjSQgeYVkg2fbIQd4cvAZUUUtlgiBT3Tb0f86LqRVkSvMM5kmkDg9jhbOvIXIra5H0MlMLRJaUrniJWWM/bO1JUNQ1D5M7rIcleTC2Q0ruCfiBMlj2bTi3jBNHnyUonRJIy/O29eEEgN5aDoO/XwMTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZuKLKY8idf1qklY9xgs/6+QEWyLsQvNEVKQ/F/9igT0=; b=Ngv5ChdfLulrUaxr28yThzZsEvZPYIpxYEzXo/xf3UDeQormrUg/BxRjUfa0rEeg/MtJWk5MpkhzqsLT0K5mk7QRkN7YxrdyB/gSKF0a/cspQ+UosnLpX+z8uQKU0R6+/9c8rMU9B5S3jF/yfgA2ioSHWj8STurXn930EjmGIFJ763ED0e/ojjhUac/4GKE28HxFXYaCi2x4CdBSJff1OjAb5ppgnugPC3gp/6Xu5IJkwnRtxmfbtd+45nZ6cWnJG8zNqgHjbvQ9hhZGrX0WQsVrqSSe6UUBTfX7NoQ5oR+71+l0hd88fOEjMqEVmf3A2KkoX993Ii3fvdXSm17uoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZuKLKY8idf1qklY9xgs/6+QEWyLsQvNEVKQ/F/9igT0=; b=alSlFh8jOr9+8/y587Me2q5p+HQLjmNhu807tkYogCtO4oQb/gw/Xm5eC6KZLBquhOnXMQUaSbsMfTc3dEfw9qpXeNBdKfCQD4AzsYTElgCYOF7QdVlGX3YTfDSLCP8aQcZ4XLUBrbA5XDDjYHsK5ES97mAjH5Jzqo+bfo8SxzE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Luca Fancellu Subject: [PATCH v3 04/10] automation: Add debug versions of Arm tests Date: Tue, 27 Sep 2022 11:47:21 +0200 Message-ID: <20220927094727.12762-5-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT022:EE_|IA0PR12MB7604:EE_ X-MS-Office365-Filtering-Correlation-Id: 00b1cf62-caa6-4e3b-a27e-08daa06d52b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zDp5ldLUMi+Uw9GNAcSObcIc0cr//D/4vDMsJ276PN+TtINyMVGRRHzbLmipdSXgygwQXNoInU0qnoAXYdvmHf4tDF9LQE//xE7IE1LGMFh4EUNjcqAp277G0zxFdhaSwqjhG7cOmWimIThQXf/rB4DngColACvlUOnPmpfl16qHnl7McQ2djib4mpNPuZ3gi1xOzKsIDopAHciEtYSEs+2Q2SXbVnklqjVXJwK/bpXLiT23v4d07yCIOKboTwc4dTf1EBCeNklZpQEup4/K01T2bWHaSMdYMAFHFjSAcB96dVMJwMsnHkmPKM9BMeakwrFhlf6TSfHIeEJDoZlVHKQ+RrcAIRI3QeDfngyMRZ0dWzi2SxwWlt7KNAnsRSTX2QTsGj5YAWaV22WeZUWSCGfFExXuELfo3gWhnHCG4LwcboASX+SIgpnYTEicy/5V6Aj0+IOdWvZVEkLR0eEVX0wUX2sbXR90xihj5rMr/+HIIf647cQunb+7QYbPHZ1QDysHXIXn0varFPArlyAyQ1Vy9W8wGpuBgaTh0+SVSxrhRmiVMgIR+AycoRVWRCJiCwZHbGMBz4ERJE922VgR0Ovlvezqpetktf2fPeNhgbSghquzeWm5QU2wzR2fPQ7R52I18J6FZl1x8neoTh5L4fSG70ca4fa8p7NrKYepCbwnRx+Ch7/gD0q9EGngP27rzwZLC0MBfLpR1tgagGXcGUjbahoAokOPsOndK/n6uCCrDJv2KHsl+CcRxJt/DandXFIHhwoa2ZTQZQ0/LiTg/hbF8PtezYxLvlS26CH5m+Pm8EYu5tO+nQmdlqkS/uea X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(316002)(6666004)(70206006)(426003)(54906003)(86362001)(336012)(6916009)(2616005)(186003)(1076003)(36756003)(47076005)(40480700001)(70586007)(4326008)(8676002)(41300700001)(478600001)(40460700003)(2906002)(356005)(8936002)(82310400005)(82740400003)(81166007)(26005)(44832011)(36860700001)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:42.4964 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00b1cf62-caa6-4e3b-a27e-08daa06d52b8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7604 At the moment, all the tests are executed on non-debug Xen builds. To improve the coverage (e.g. we might catch some asserts), add new test jobs using debug Xen builds. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini Reviewed-by: Luca Fancellu --- Changes in v3: - none Changes in v2: - carve out the RAM size change to a separate patch [v2 03/10] --- automation/gitlab-ci/build.yaml | 16 ++++++ automation/gitlab-ci/test.yaml | 93 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index d931441b910a..6ce92531f61f 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -587,6 +587,15 @@ alpine-3.12-gcc-arm64-staticmem: CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y +alpine-3.12-gcc-debug-arm64-staticmem: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + alpine-3.12-gcc-arm64-boot-cpupools: extends: .gcc-arm64-build variables: @@ -594,6 +603,13 @@ alpine-3.12-gcc-arm64-boot-cpupools: EXTRA_XEN_CONFIG: | CONFIG_BOOT_TIME_CPUPOOLS=y +alpine-3.12-gcc-debug-arm64-boot-cpupools: + extends: .gcc-arm64-build-debug + variables: + CONTAINER: alpine:3.12-arm64v8 + EXTRA_XEN_CONFIG: | + CONFIG_BOOT_TIME_CPUPOOLS=y + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 4f96e6e322de..1b51030c6175 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -44,6 +44,25 @@ qemu-alpine-arm64-gcc: tags: - arm64 +qemu-alpine-arm64-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-alpine-x86_64-gcc: extends: .test-jobs-common variables: @@ -81,6 +100,25 @@ qemu-smoke-arm64-gcc: tags: - arm64 +qemu-smoke-arm64-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64 + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm64-gcc-staticmem: extends: .test-jobs-common variables: @@ -100,6 +138,25 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 +qemu-smoke-arm64-gcc-debug-staticmem: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64-staticmem + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm64-gcc-boot-cpupools: extends: .test-jobs-common variables: @@ -119,6 +176,25 @@ qemu-smoke-arm64-gcc-boot-cpupools: tags: - arm64 +qemu-smoke-arm64-gcc-debug-boot-cpupools: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + needs: + - alpine-3.12-gcc-debug-arm64-boot-cpupools + - alpine-3.12-arm64-rootfs-export + - kernel-5.19-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: @@ -136,6 +212,23 @@ qemu-smoke-arm32-gcc: tags: - arm64 +qemu-smoke-arm32-gcc-debug: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + needs: + - debian-unstable-gcc-arm32-debug + - qemu-system-aarch64-6.0.0-arm32-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-x86-64-gcc: extends: .test-jobs-common variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412370.655688 (Exim 4.92) (envelope-from ) id 1od7Bt-0007A2-Ug; Tue, 27 Sep 2022 09:47:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412370.655688; Tue, 27 Sep 2022 09:47:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bt-00077v-Nl; Tue, 27 Sep 2022 09:47:49 +0000 Received: by outflank-mailman (input) for mailman id 412370; Tue, 27 Sep 2022 09:47:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bs-00061I-Jk for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:48 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71673bab-3e49-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:47:47 +0200 (CEST) Received: from BN8PR04CA0027.namprd04.prod.outlook.com (2603:10b6:408:70::40) by DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:47:43 +0000 Received: from BN8NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::42) by BN8PR04CA0027.outlook.office365.com (2603:10b6:408:70::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Tue, 27 Sep 2022 09:47:43 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT115.mail.protection.outlook.com (10.13.177.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:43 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:43 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 02:47:42 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:42 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71673bab-3e49-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMx5q/lqhdCAS8ZRijwOq0zCeodJTTq/v/jQ6Jd4pKhfWZrkGVHvOU4U2ODMPSx0ahyfp55z4Y8JRwRHqQJL4MByZV2DlVsjOD+GUNUwrVPQLvcmxTC4McAqxLfuFH3ox6TjXNllhQrUinlUamFvwUR61QKGUBJ8/mnpgq9M4/M4RQ4bYp6f5F8CrhU6oUQ0+4c9dOevWdpQJHeLg3SwQmyf78xxwUKix3GholrnBQnJtBOtNDiKYh0HWvXtgS/dEuluxqslC4IITJzLAX4NE7XvXfYkR8fzvh3EZEFUh7rfsVSNwFNVqAdIVwBbv6c+WylZLxb86mrXkCVoCSxR5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/BkCI5sMztbbLhSxOHrHUT2n0YV/0QwpHvM7jmt3qWU=; b=YuPYKli1mudy3rg9WBzoYOXoBfKh/QwYetV7G1swc2xO032VOhg5TaOMMA9cfMgit3V4dhu+c75SCL9cGneOjxH0iCjafbNas6Rk62wNRDytjbgVKOE79VNL+85ukB2Jwj45iMXaRPKPoJPNKdNPHCA9D2aC/Jfpb/0XJqcMVLBT0fPFugDmE7Tp9d2078WJStWrQScQO5OoA8tXB4g1GPZxYEQc9Pu5CZhnO/uv0TEuD1qcd8xG+EU7dHlVBcj5i/pm/VezKIk21FE325ql/tAw2Gw1NkwcNuQKSKzYj6IFcJstsLTJnR8ZJyeRcXDO7KVVk2XEY1VYm00h8r1Y/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/BkCI5sMztbbLhSxOHrHUT2n0YV/0QwpHvM7jmt3qWU=; b=vSvKfzIEu4hAwClk1VSmduKCsCuY3MNrKyjcxcg2RtJVxMxd5UhFAzP8d/ABgDQrY0vajCpa62gVbcXyHxkfXkX1gv3fkMLxiSXGtiLkpXrDZqgwwusJn4D4ICQzrF81HufuagCTUnlUu1/IjQn2cIE4cbh4WidzZg7WknDob7I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 05/10] automation: Add Arm containers to containerize script Date: Tue, 27 Sep 2022 11:47:22 +0200 Message-ID: <20220927094727.12762-6-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT115:EE_|DM6PR12MB4337:EE_ X-MS-Office365-Filtering-Correlation-Id: ca7045fe-602b-4aa5-1436-08daa06d536a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x0BjoSJ7ylrumMcyvnHR6tNmzvtq9/1nBtZxbeDf69Yc7WPvsgYtLOmlVdM5YAtxNdy/2JPRblTcKY10pht3xbOZ0qDLeR7Qj8mtpnC4IWywEYjHETHIIaEHu8XGxkWzEaC0uqmBa0pfyf2BHu90BQ+gcwkSjnfKmNRaubipBaovFnD9glTovE7tXqm0GTQ5lPDupTqa+/5R9i705UgIPwB6XPJw5/LXcSzB7XhL+QToekiaC2o2JUHtsO3EFFa5EBQhZE/KOdBuxudDntF2KJdTxGtDfoxutECGU6D0Owa+T7sxrFzSD9y4powhWi8RAOoSEutnFf3v+L0xqynlNDoVsxF174RGRM8UvGlIMKsvuMFSuPe4P3HOx+3tqLKJ8d93cFPcJD99d0DifRb9pyIV4owWWJ/2gA2iTSKFqqbywHlzO9V+cvZxl3bT3Bv2xtA9e4k7Vle69gF01x3vXpM6eMQD7luWXeNxCVRaOx7VjevW1dYe2tkuQDZS0RIY06xmoENeOAKALr1yCzrbBJina42Jcb4b4/o7h374xB4EFzgTQBqket0SVtdFazvX3EDx9x4TlhqiMEqDAmkdBV32Mjz/weuFFc8h4RcauIRIpl8qGn4XnY30GpPdUqOJiibWL0naCltBxcedzYovGDHVnwmdEmettA+2rS/G5oWLw+ynAZe9OTvi+lLVMWbuKjlXBlCVkgTcxC0FYVDE8jjU1z2KK1HQL/bV06AaE6R7E7loUEHFJrgfopmvyahh8CCbxYND6g2kugO/nLJgEdtABA4JEA0YGGSyATZ/wPjTkNWJW/XnZktz2Gtb4mZJ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(41300700001)(47076005)(478600001)(426003)(5660300002)(6666004)(40460700003)(186003)(336012)(2906002)(82310400005)(1076003)(26005)(40480700001)(44832011)(54906003)(2616005)(6916009)(8936002)(70586007)(8676002)(70206006)(316002)(4326008)(82740400003)(81166007)(86362001)(356005)(36860700001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:43.6905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca7045fe-602b-4aa5-1436-08daa06d536a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4337 Script automation/scripts/containerize makes it easy to build Xen within predefined containers from gitlab container registry. This script is currently missing the helpers to select Arm containers, so populate the necessary entries. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v3: - none Changes in v2: - modify commit msg to reflect that we are missing helpers but in reality it could be possible to use Arm containers by specifying the full path to gitlab container registry. However, such usage is annoying. --- automation/scripts/containerize | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 9d4beca4fa4b..0f4645c4cccb 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -25,6 +25,7 @@ die() { BASE="registry.gitlab.com/xen-project/xen" case "_${CONTAINER}" in _alpine) CONTAINER="${BASE}/alpine:3.12" ;; + _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;; _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;; _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;; _centos7) CONTAINER="${BASE}/centos:7" ;; @@ -35,6 +36,8 @@ case "_${CONTAINER}" in _stretch|_) CONTAINER="${BASE}/debian:stretch" ;; _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;; _unstable|_) CONTAINER="${BASE}/debian:unstable" ;; + _unstable-arm32-gcc) CONTAINER="${BASE}/debian:unstable-arm32-gcc" ;; + _unstable-arm64v8) CONTAINER="${BASE}/debian:unstable-arm64v8" ;; _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;; _xenial) CONTAINER="${BASE}/ubuntu:xenial" ;; _opensuse-leap|_leap) CONTAINER="${BASE}/suse:opensuse-leap" ;; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412371.655703 (Exim 4.92) (envelope-from ) id 1od7Bv-0007ZK-E5; Tue, 27 Sep 2022 09:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412371.655703; Tue, 27 Sep 2022 09:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bv-0007YI-50; Tue, 27 Sep 2022 09:47:51 +0000 Received: by outflank-mailman (input) for mailman id 412371; Tue, 27 Sep 2022 09:47:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bt-00061O-C4 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:49 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2081.outbound.protection.outlook.com [40.107.102.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71d0adcd-3e49-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:47:48 +0200 (CEST) Received: from BN9P221CA0021.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::15) by SN7PR12MB6911.namprd12.prod.outlook.com (2603:10b6:806:261::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 09:47:45 +0000 Received: from BN8NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::a2) by BN9P221CA0021.outlook.office365.com (2603:10b6:408:10a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15 via Frontend Transport; Tue, 27 Sep 2022 09:47:45 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT007.mail.protection.outlook.com (10.13.177.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:44 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:44 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:43 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71d0adcd-3e49-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqBQ9EEvk3tft/KMnO5CZvplcC2/Jd5zXCoKqWLVQvIShjAQ1emym2xpykJukdK/YWuCyROCMh93VfSi7971yvNipj3LSUe7UNCOEoaXV6gG+hwjt6Xcnr7vyFNwb1qCE624nklHTrcYEI7knfyKAXdl3QTdNaoep46gtoXLZ9FFT8bIdXqmvZ2WfPcc3JnBzxars1n7Cy2piEoXqqg+brAR+9UUdrH7dyXN/myCw7T66T5QcMNUCr06Lhp2DmyFTQvmGYpm/IvoxCcLBjZJZitqczsAsJE6oxuLnIE1s8+IikrFpO3Fb0QpZK4gy2wvrDVUQyg4vwSZG+3VCzg1Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ax5+F8w1fPqztC0E47oipxuAnLpuQqKzKyegV6Abe7s=; b=kV7u/2HtlUrERhaBjJcVIZEsgVSFWGIumJ7wkcUnAmaIithGfyPnefXHYyJRvT6XgWzWOc2ZJn7jUWzzy5qYgP1QHvGDPb6Tzf6QMTurmUDJInKbnQ5VXwgoEvYzTA36YJm/Gk6K8ISi93IwiJKNPDlGIA2AWDstrm3L89ANEwMloyAOI8Pd4+kPT+3Wuw9WaCMtOdT60naGxOvV+xuKZCdtTaFHmsKoItA2QsQe8jHQa79RQlHFhbX6pqg3jXBZ2PhZnY6ZmrmskqW/BEyrWbsZXfwqj1Ec5jWyB3NlgJ+0+YdfgRSDndwODula2QCFND5Tgd0w2Dds8HEZ5O4tFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ax5+F8w1fPqztC0E47oipxuAnLpuQqKzKyegV6Abe7s=; b=Kt8sECp1nJgqOouRYs+n7wndk/J/aEth6B4PF+YK4r86mFxpiD2lDdaUXPo2aItA0Z1u0zvSKlEKD+3X8/XjAfxWmjhWaB/fxLhkXyPm3PrIeHfLRCnCsTRS9g6WS4i55wKiz9qN+9BbpE56DkSIAq3+VDmlMiQzAxa7YWhHmXs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Luca Fancellu Subject: [PATCH v3 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Date: Tue, 27 Sep 2022 11:47:23 +0200 Message-ID: <20220927094727.12762-7-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT007:EE_|SN7PR12MB6911:EE_ X-MS-Office365-Filtering-Correlation-Id: db75d599-92b5-4539-1983-08daa06d5428 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6uWk+GoJxrnyWZcMvQPfCkYIQlUMoUEOPi595HlVrZrbvjeyWiey5itYu7HfIrwXEvl408gpF5qRpjPu3Krigcg4x9ekB2vCFO9XorS5UweG74a9Hqc1o1XqEFXwj9Nw9oorC3p1vNxY07fzoIW/SYGIq0cadOzGPayEEtZwAgmfQi6mUn4VemTxOhep/2DiwXo2gs7f3OtoLfxQaA7cSxmlqEXxrlSMacEuOUIysdgF/Wry3eGAs8+38IvrcVUFmhUm4OQKbhQGvXMdv/HCSjHeud/Ft7WlrWcXWi0H9SBbk/rfr5XWoEqhGPht0obHb1AZ1N2hfjJlTHSpSqHmOmPgRZPuNRL391/zRpwJ2HnI3fYN9M2mQ5ZPuOmRA/P5T2fERkRYiayOcTY2uFId8fpOnlMUnKpYMJJyvfEMla17+yLAdexIBT4Jt9P91WIFLbgOBoe7W9HoSC8MRB6indL0Lby3PiLndzp5760D1y2dATTDE4Ur8usfbXbysCqyghaeNNdqLqeaqV96K7o4L0Aotmrwel1YdMD3PSrTgW7E9VwSODyxS34yMnrIvHNdY2rAf+rE1OFGQOQlNQ8/oqWw+hEs0U0tPoGEwIQHPP2/+iGwXNGJDXCNe1R3ZOQoLsBO5F3iJengg79KrBfw1beXCasEP81qMERFm/Qs/13Ll6Q5hVbSmTJnI203oYxBzgYbEzI2radPhtXqoEeQ6TDjZzt7IeJuUrvZPjOHZkRdznO+JkF5Jj2mr5C9fD9uSv0Ucs2jgdyaGORHKIydY7iYVuz2qh3BATw/dx758/f/jzvuvXptTeBipccNs3uQ27P5AnIBypyVMDXTBUXqHSFffebm3xXGaEQpqiJ46wbTrVGrwnO0DzeNrZTABVui8sGYgQvBvPSOxkUTxIbRM+FDhfzGrx0E/jHp3gla1Qo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(36756003)(40480700001)(82310400005)(966005)(426003)(47076005)(26005)(336012)(83380400001)(44832011)(8936002)(40460700003)(2906002)(1076003)(86362001)(5660300002)(54906003)(6916009)(186003)(82740400003)(316002)(36860700001)(81166007)(70206006)(2616005)(478600001)(6666004)(70586007)(41300700001)(4326008)(8676002)(356005)(21314003)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:44.9514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db75d599-92b5-4539-1983-08daa06d5428 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6911 Take an example from arm64 qemu test scripts and use ImageBuilder to generate u-boot script automatically. Calculating the addresses manually is quite error prone and also we will be able to benefit from using ImageBuilder when adding domUs to this test in the future. Install and use u-boot from the debian package. Modify the script so that binaries are loaded from u-boot via tftp. Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always set to pl011 node path. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v3: - none Changes in v2: - add explanation in commit msg why we remove dtuart path --- automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++-------------- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh index c8ae0bfb9b1c..ef19b988c2c4 100755 --- a/automation/scripts/qemu-smoke-arm32.sh +++ b/automation/scripts/qemu-smoke-arm32.sh @@ -4,7 +4,9 @@ set -ex export DEBIAN_FRONTEND=noninteractive apt-get -qy update -apt-get -qy install --no-install-recommends device-tree-compiler \ +apt-get -qy install --no-install-recommends u-boot-qemu \ + u-boot-tools \ + device-tree-compiler \ curl \ cpio @@ -20,10 +22,6 @@ tar xvzf ../initrd.tar.gz find . | cpio -H newc -o | gzip > ../initrd.gz cd .. -kernel=`stat -L --printf="%s" vmlinuz` -initrd=`stat -L --printf="%s" initrd.gz` - -# For Xen, we need a couple of more node. Dump the DT from QEMU and add them # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./qemu-system-arm \ @@ -36,31 +34,31 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -display none \ -machine dumpdtb=virt.dtb -dtc -I dtb -O dts virt.dtb > virt.dts +# ImageBuilder +echo 'MEMORY_START="0x40000000" +MEMORY_END="0x80000000" + +DEVICE_TREE="virt.dtb" +XEN="xen" +DOM0_KERNEL="vmlinuz" +DOM0_RAMDISK="initrd.gz" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" + +NUM_DOMUS=0 + +LOAD_CMD="tftpb" +BOOT_CMD="bootm" +UBOOT_SOURCE="boot.source" +UBOOT_SCRIPT="boot.scr"' > config -cat >> virt.dts << EOF -/ { - chosen { - #address-cells = <0x2>; - #size-cells = <0x2>; - stdout-path = "/pl011@9000000"; - xen,xen-bootargs = "console=dtuart dtuart=/pl011@9000000 dom0_mem=512M bootscrub=0"; - xen,dom0-bootargs = "console=tty0 console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh"; - dom0 { - compatible = "xen,linux-zimage", "xen,multiboot-module"; - reg = <0x0 0x1000000 0x0 $kernel>; - }; - dom0-ramdisk { - compatible = "xen,linux-initrd", "xen,multiboot-module"; - reg = <0x0 0x3200000 0x0 $initrd>; - }; - }; -}; -EOF -dtc -I dts -O dtb virt.dts > virt.dtb +rm -rf imagebuilder +git clone https://gitlab.com/ViryaOS/imagebuilder +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config rm -f smoke.serial set +e +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ timeout -k 1 240 \ ./qemu-system-arm \ -machine virt \ @@ -70,11 +68,10 @@ timeout -k 1 240 \ -serial stdio \ -monitor none \ -display none \ - -dtb virt.dtb \ -no-reboot \ - -kernel ./xen \ - -device loader,file=./vmlinuz,addr=0x1000000 \ - -device loader,file=./initrd.gz,addr=0x3200000 |& tee smoke.serial + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=./ \ + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial set -e (grep -q "^/ #" smoke.serial) || exit 1 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412372.655711 (Exim 4.92) (envelope-from ) id 1od7Bw-0007lh-6w; Tue, 27 Sep 2022 09:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412372.655711; Tue, 27 Sep 2022 09:47:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bv-0007jg-UD; Tue, 27 Sep 2022 09:47:51 +0000 Received: by outflank-mailman (input) for mailman id 412372; Tue, 27 Sep 2022 09:47:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bu-00061O-Ki for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:50 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2056.outbound.protection.outlook.com [40.107.95.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7213fbee-3e49-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:47:49 +0200 (CEST) Received: from BN0PR07CA0012.namprd07.prod.outlook.com (2603:10b6:408:141::34) by CY5PR12MB6131.namprd12.prod.outlook.com (2603:10b6:930:25::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:47:47 +0000 Received: from BN8NAM11FT104.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::76) by BN0PR07CA0012.outlook.office365.com (2603:10b6:408:141::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 09:47:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT104.mail.protection.outlook.com (10.13.177.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:46 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:45 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:44 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7213fbee-3e49-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ik9zJ0NoiGfb2tDzREuIyXheKA+g+EE7LkOGUpQoS6xnMioLXTedlxajwlR7tSwjdRyMfpQzd13nlcFIKqdI7ce4Hn9vICFQerD+js3/GTN5qSwcqIYqAYC71lnh+lqDwL8LRUMu7CWOb4eTyAMFYg1pmDBhOXwOmQjeNKzc+oN4G3P2aUyuf8x/VlJBtFdyzThU/1lU76QTbB9mi5Ff/qHmsx1ESzP3LRVRWqOF/UTBpujWSsXmWkOcR7yAI8Nj5PgX4DiN8avGeiQueeJh2qYX5GcriR1GX+vevgh45F6R5PHm6uJWSUxpySJLoqVgEQfXwOyaob1+sSGqsdgFCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l0I9iQFSNIdWL0CuOjrMUz2Rkr4kshuH4vfebOra2RQ=; b=OFy3iW3e+0iBqiRlfqIzdU5tFurdQYW/NAamNBrGUDVodAsVZRgTyeLNHMO0i17KPXbsfXXLmYRYx4jjD0r8TBAV2oqqEhcDqTGf7ZvUR5dZk7qlwMNCxtoUirFADxF9OsAreu0V1yo1JaJliUI7wz0fbCwgpeFdExaD6DvLlfB4T9FRMfU0CAcJerpOjmW+VLTQ520e840Lz84YCcYfRX6IYvu98+tcbGttXu7y2v/fthuZ+sRqO5cDyQzm3GtQ5wt04CpXfKG36QevbveW+kXGtgNJz1pz951eNCoY1FY0Se5YJQ0qx0ck6diD6RqUe54m8kpfPHusrNlbRCoE3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0I9iQFSNIdWL0CuOjrMUz2Rkr4kshuH4vfebOra2RQ=; b=Vm/Sg9nrnn7XPINCJpNTHhMvmqZCnTDpYmBkbzxpxGpOCcvSl8ihdcp5cXF41Q9eijNHuQXDvQtVsn6oxL687hBwea1ah5H2kfc18dNB3YV6E/Zn+JsOyWEKgNODj3MBFWCOiPcs+BqcrKKGZHAaTkvP3MmGRKXrSvb88iejS4M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 07/10] automation: qemu-alpine-arm64: Cleanup and fixes Date: Tue, 27 Sep 2022 11:47:24 +0200 Message-ID: <20220927094727.12762-8-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT104:EE_|CY5PR12MB6131:EE_ X-MS-Office365-Filtering-Correlation-Id: 37b799ca-d58f-4e9a-8854-08daa06d54f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /qu75F1WalrHFrx4eMfjudBLas2V0NKI5FMohVGzqBDK1hcpXRRxBK2EnAQp/czaTYt2QAV+0OEwD6zpBGWEiwTxGEkHPvoAvxfipY703P4pEtJkxGPvxKkJwHRXpyRUS97c55klgK85hxdmDrwCu7+fsqlcss908TsaYa5A9vtqvbUleJ6M4OovH3eKlpkSUx8vDB9TSkfluGRMjRncEXHWjHDvyuVYFXwNZ5GM3ZBwII2kqvSkdrnfKtUDZh7RnYvfcamueTvO475U+n7Cj6gRd2T6iTl5/t/yCc4bKT7AdTnq4eyoXZa33qFGZ2phP6xWJwEQ0Wbmi7VvZfz4tUwMaP+1X20+C2vP9QOSFYsHkhvtM1SYlHnZncf82MFs9rr5QdFz8fvQHHGyzl1dp3Dsq9fKOC0RIatmD/Tm4C0LpAJ5Xgdmz7KNrWZSEGzGJfEQhc+9+H3C8LegzNMgd8gAF3SL+Gyua5k0pgzH4TllduinKgkTlKhSqp7S7h7GSC78VOUiJtNt+R76ZZFWGmnWAGTbXcLLyeozb11ZQydSiIlTPwMHwBNrXZM/ONRl3weiO1E1LBYGwr6ZINO12PrMwq+2UyiYuKP2uBjaRairD2hDH8wd3VQvJfXIiPMBzhvDins3EMa18WtXcrQckydIS0CzbObDZlc2Cd4waP1TDf9RDSrneiPcISaBiENLYK8XkDke2OWqxry6DtyxruaILohpytgvSuS77jb02luBL8Y29WqliKqv83wVuaGlx37+s0knJv/fFLbUlamzihUUq2XB2AiYrEC+Jw3NyipP/KrM54tLTEm3KTmPdnZEcCeWWeEWwZhd/bCPAeE2e8yNjCAqRvs4EDrzKDvreuU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(44832011)(26005)(5660300002)(8936002)(6666004)(40460700003)(83380400001)(41300700001)(82740400003)(36860700001)(1076003)(36756003)(2616005)(186003)(2906002)(82310400005)(81166007)(336012)(426003)(47076005)(356005)(6916009)(54906003)(40480700001)(4326008)(70206006)(70586007)(86362001)(478600001)(8676002)(316002)(966005)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:46.2912 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37b799ca-d58f-4e9a-8854-08daa06d54f4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT104.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6131 Perform the following cleanup: - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version used in this test is v2, - use fdtput to perform modifications on the dtb, - use DEBIAN_FRONTEND=noninteractive to prevent interactive prompt being stuck waiting for answer other than "yes", - fix the number of cpus in the device tree because currently we generate it with a single cpu and try to run QEMU with two, - fix the memory size we pass when generating QEMU device tree as it does not match the memory size with what we run QEMU. Signed-off-by: Michal Orzel --- Changes in v3: - s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/, drop Ack Changes in v2: - none --- automation/scripts/qemu-alpine-arm64.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-alpine-arm64.sh index f4ac2d856fa0..9004c537e325 100755 --- a/automation/scripts/qemu-alpine-arm64.sh +++ b/automation/scripts/qemu-alpine-arm64.sh @@ -2,6 +2,7 @@ set -ex +export DEBIAN_FRONTEND=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ u-boot-tools \ @@ -73,18 +74,17 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -display none \ - -machine dumpdtb=binaries/virt-gicv3.dtb + -m 2048 -smp 2 -display none \ + -machine dumpdtb=binaries/virt-gicv2.dtb + # XXX disable pl061 to avoid Linux crash -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" -DEVICE_TREE="virt-gicv3.dtb" +DEVICE_TREE="virt-gicv2.dtb" XEN="xen" DOM0_KERNEL="Image" DOM0_RAMDISK="xen-rootfs.cpio.gz" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412373.655726 (Exim 4.92) (envelope-from ) id 1od7Bz-0008MI-Bk; Tue, 27 Sep 2022 09:47:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412373.655726; Tue, 27 Sep 2022 09:47:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bz-0008Ly-7T; Tue, 27 Sep 2022 09:47:55 +0000 Received: by outflank-mailman (input) for mailman id 412373; Tue, 27 Sep 2022 09:47:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Bx-00061I-UE for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:54 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2058.outbound.protection.outlook.com [40.107.223.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74035e37-3e49-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:47:53 +0200 (CEST) Received: from BN8PR12CA0029.namprd12.prod.outlook.com (2603:10b6:408:60::42) by BY5PR12MB4952.namprd12.prod.outlook.com (2603:10b6:a03:1d8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 09:47:49 +0000 Received: from BN8NAM11FT003.eop-nam11.prod.protection.outlook.com (2603:10b6:408:60:cafe::aa) by BN8PR12CA0029.outlook.office365.com (2603:10b6:408:60::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 09:47:49 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT003.mail.protection.outlook.com (10.13.177.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:48 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:48 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:47 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74035e37-3e49-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TT6o+LJsS6dwgM6LG0gxJ0Ej5ZfilijKPH7Kp/q7Fe53uF4ZYc2xMt7IGt3cIVU8ejMsmhXqTYSSnD/0/Oh6ob1/1fDnFN2lidHp9spy9L9HVUgSMBQ5LHLABiBH7EucmByntXJfICww2Rg8eMH2L6ixlv4VMsFBHKSPbSTDRLpOcwgNqXDIdF3ypVgOksMx3OG+5C1zJa16ip8CrRIyT8CQQbSpsF0UfZU2kDGE9CM4UZsSRLULkiuR0k27R5o0EK/d6D0EwA5K8UQ65TLuZndROCnZWbwJBWY+5ZjQAcfiIu1TXdbKSULCOs6+j1GDAXTAUc4ZOeI45PmXjw3D/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qu1BpDynY88ojjM0e+raIHRg5HgHBs7rQp1cxTsj2bI=; b=heUhV9u5PHXPsrua/niLnEKwcVdFfYaFWxxS8ihlg2oJPYrtitREpJ2P2Q43OD9QNmxm1LfGXwVHUvS6PO548TxWIS78kAbdtiA362NjVTUIkvIjzfLaHhb9yCFjcLecEILGqOuOzXN9RG6RYc4zLeR4mBfgjIgz6Ivw7nk9pO9qqQC0qU0M3d2MFR0Kk3vGDOObJNt2vz9JKl41VXLhvlGeWEwJeDgiryfqowtVkkTsqTlhfkxYNxNqWpkmuU1MK8J56xWODZ+94Vf78hUynYcRKD1X46Nn28pq9dnFeuZMkM/1dAgVvtkvA3vCu2tkXFK63SuMZor0nl3pa5Homg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qu1BpDynY88ojjM0e+raIHRg5HgHBs7rQp1cxTsj2bI=; b=D7rJK3eY8A4CetfUY4RjIdhRO9euges4BLMmA0JPW1p2W8TJjby4x4pZyG6JYSGu0agnUtjicI2UNbunRtSv0VTc3g2AIt1G4x1Osr1m6bXVrnH3RcLkOeTIm/Ix9fDZstOQMZpd6xXPfOB3t1pfQoRJPMc+cr6f962oVzv/Ocs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 09/10] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh Date: Tue, 27 Sep 2022 11:47:26 +0200 Message-ID: <20220927094727.12762-10-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT003:EE_|BY5PR12MB4952:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ea4b70e-a898-411e-8bdb-08daa06d5683 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EdKFDPKVqOhHQjIar8fsHgATpJdjii6cM+ogBCUHi8ds5hpQvc90h4BEnZ9HIDGbYjTi3JF+x29Ef6MHASXgUfCL1PTSco02vAzsteZ+UNCW2S5jtCuBeCVKrzcMwjKn81WLmLSrOVBRxjsnO/WK7NoIsom9blXccqsS6TEjQxUNdROwYdWyPMl1RYLC3Nl4VmOOpO569vb3HCIH/ID5N411KocvJT3wZCMj3VidLELxEnALQi7B5z9KjnhjX+Ld1XryXoMtVUM2iCqebvKDtwEBmzRsPpjJ4cz8CFIZLHAsvEwlLmrZ7/EAaj4YdXCoW/TAOBxiGFunVNEl91gzfedZNLWaxQGs7sPCJQKFaA8lORtXarlUg/qpfqE2Jc6vc1Q5V2RIWogRZrnPOp/z/d75YFJfeuNMePJdp1PbofSH8l+0o5RRFNK+kiZPOIuBCl/3h+TWBQPQcxubdOLyWqb5PxfVcuBayTtGUJyHco8Wsl8uQeIns0uXcwT+aG7RG9LSxUvFFm2Dcv4Hqygn7KJJwp1zn0JTqHvP6Ples0OnxEK1YTyIXqDlNT3DqnZrBSFPW7pecD2q/ByOC10BcWb9FymDHw83lhm2O5DRor+sslm3vhH84tM1hL5J96jbvJxXHK6NVgVbhW6o541Smxxw30h58xuNLeV25K86DH71Ylo0yR+lzQrIoowrDABm1pmrL2mnQ+RQpT307LW/N+ncyGaJPniei7zy47qUyFE8OPnFf2WpZSke6wa1wR6wi8e8lD/JUol3HejCcPHDWdxL1gtbzlMn325VGgKCCiZ0wfpN6sI9PQIVp3qe/wVA X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(81166007)(356005)(82310400005)(70586007)(8676002)(70206006)(86362001)(82740400003)(8936002)(41300700001)(36756003)(40460700003)(478600001)(40480700001)(316002)(6916009)(54906003)(26005)(44832011)(83380400001)(5660300002)(36860700001)(186003)(1076003)(47076005)(336012)(426003)(2906002)(6666004)(2616005)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:48.9062 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ea4b70e-a898-411e-8bdb-08daa06d5683 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT003.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4952 qemu-alpine-arm64.sh script is used to perform dom0 based testing. Rename this script to qemu-smoke-dom0-arm64.sh to reflect its usage. Also rename the corresponding test jobs. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v3: - none Changes in v2: - none --- automation/gitlab-ci/test.yaml | 8 ++++---- .../{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename automation/scripts/{qemu-alpine-arm64.sh => qemu-smoke-dom0-arm64.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index f620622671f8..3b147c88ab08 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -25,12 +25,12 @@ build-each-commit-gcc: tags: - x86_64 -qemu-alpine-arm64-gcc: +qemu-smoke-dom0-arm64-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export @@ -44,12 +44,12 @@ qemu-alpine-arm64-gcc: tags: - arm64 -qemu-alpine-arm64-gcc-debug: +qemu-smoke-dom0-arm64-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64 - alpine-3.12-arm64-rootfs-export diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh similarity index 100% rename from automation/scripts/qemu-alpine-arm64.sh rename to automation/scripts/qemu-smoke-dom0-arm64.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412374.655736 (Exim 4.92) (envelope-from ) id 1od7C0-0000F4-R5; Tue, 27 Sep 2022 09:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412374.655736; Tue, 27 Sep 2022 09:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7C0-0000Dd-LZ; Tue, 27 Sep 2022 09:47:56 +0000 Received: by outflank-mailman (input) for mailman id 412374; Tue, 27 Sep 2022 09:47:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7By-00061I-U7 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:55 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2065.outbound.protection.outlook.com [40.107.93.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 745c243d-3e49-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:47:53 +0200 (CEST) Received: from BN9PR03CA0473.namprd03.prod.outlook.com (2603:10b6:408:139::28) by SJ1PR12MB6362.namprd12.prod.outlook.com (2603:10b6:a03:454::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:47:48 +0000 Received: from BN8NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:408:139:cafe::6b) by BN9PR03CA0473.outlook.office365.com (2603:10b6:408:139::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Tue, 27 Sep 2022 09:47:47 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT086.mail.protection.outlook.com (10.13.176.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:47 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:47 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:46 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 745c243d-3e49-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nR6JZypfQIHZO9kIEbO+ju/uktDkfpMsh+wn2w7feCJu9eRWp9m5rS3t0nD6M7NeJUeso0hLYBKatswZicKpyKfRFr50WBmyJtuJqJppwuIeDyx1TUD1yRb2nS/6j/8DIEiUo3ua1Z1moV9DCp1Ll97JGmdfi0CltOKM2iuG7YQPqYY914wzCVS2cFj53JG48knRu8bfbjvWGhAwVBkvKag+fGPyLFf/Bxg9LmECE+MqFgbk17eYqtyX89W2+al4MmOQsV6oWrPP//Kx/caUtFmF0R7t8CteCZ4dK4q/JoLvzrxanDgPJ8FfsAh400fgbTPAzx+T3CvpIPOpB29JZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T2EPOBm4fZ6viSD0xpr1lnHb5byGce7/kHznjulrx2U=; b=VFVarXiP7aey29T1z7K3pP/LabPWcwRN30cLwhY542byzKjEbQIfi1Oq0kpScglw/03g10xfeKebHXqi7VjHMX4x/dxoQFR33CUg9GrsoVBicK43iCbXyQnm2MK3LMCJUf1jkSj+0pqfG+TBUiE0m/hrHsj6+A+fdzJdTMmGpf5yvR2M1Kd9JGnPCZQsBBx1tjva3nDA9BUkJO945BQIV/ubjavHxjL0pAybU06biVSDJg3lDzMFQy0lf5qu6bekNwmaxUR2ARj5IYX2GMYPHbTqtzB2lQyqyPW8/eWmfE/2SZr3Xwoj3DUnqMO41FhWfaUp+Ys7FWeTghG42pK6PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T2EPOBm4fZ6viSD0xpr1lnHb5byGce7/kHznjulrx2U=; b=ah7FSZP5frM/MbR/U9jt6AWbBg53IUsRBkvNDv3n8svcuuu8/qDAcZA9yX0M+p2DDQQAPIapOD+1IuiytJ2KoFwqVQ3Negxad21R+1pMisGqf0YL2tn6KdnERBn7tVHl1yAg+Hb3llK5kfnGv+RxwSnpfOQeiEHCRHywJkpKLdk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Date: Tue, 27 Sep 2022 11:47:25 +0200 Message-ID: <20220927094727.12762-9-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT086:EE_|SJ1PR12MB6362:EE_ X-MS-Office365-Filtering-Correlation-Id: 104c7605-9fdd-42d4-7e29-08daa06d55bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vYWm78kANCmajEzzCnoKiUa2UOFJy9hXpty1GZcSDmj93a9q1EC7Sy+ir6MKzUraLsk7Jc7mewONJZ9Lfxa5eN4wXJWbSqTncOrWNlVGjDFxecpK4uAi4Na1kD0fj6Prqx/4LYTX48x3CJKGXYdMReCN4f6DdJZ0S9REl+fkWAsxKfwjWyn7vgy89SlHAsqZenSjXDsHZoUnmBRT+mBkwgkja2x7CWEtUPnikuuzPJalVr9wnu51WE7YuMQkGf7ct/IyRzKSfL30BEDhlj5HbyhLvtrxT0+aXgCDtX9d2nTXJkuKzgW9dzrm6+wdEY+zvEZC8dTN/5Lsom6wyjo43P2RKwN9Dr1UG8wYPjFaSpYSP0auomkG0EgAzoYjmc8QIhL7HyPh4oa4xSF0EX/hoRNH7cEtjFXtDeEIrUk6vMEImwB93mHLvGMbMNQ72JVTNvinqLOXA5xcN4Dv/eBIth/IUMwYycrEXrB3xx0rpuM9ouD9pfzlRoD1PV0u2wpObqnZ3CVYSFXVSfDe/OjqjTJXM/MIucZ+eMn2M38JBcrQtqlRa+J6DtyTwZJZXVR1m5RcNd7Y1wigkIDqoTaeI1HeHXl8bn1bWOzAGtNZP042dd8ZXGEbUb5B5UAWNbsgvaweM26mo77ga51E+tUnozoWU53AxBB07o7U2xwlSqLVIpiup9DZVPZiolivETbY2+n4xSjiSYxvCk2ACFf6RoY8fZ0U3bNKWuxbu8Hk0s2dshnzFTlFdGAz6HHU3I8I3q2a3POrGC0qApuVVuWQWcLF4i5cYQ7D9FLS1tyXLazRAqYgwPVcfq2vF3w7W/PD X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(40470700004)(36840700001)(46966006)(1076003)(336012)(356005)(82740400003)(426003)(2616005)(186003)(86362001)(40480700001)(81166007)(83380400001)(47076005)(36860700001)(5660300002)(70206006)(70586007)(44832011)(41300700001)(4326008)(8676002)(82310400005)(2906002)(26005)(6916009)(6666004)(40460700003)(316002)(8936002)(54906003)(478600001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:47.5795 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 104c7605-9fdd-42d4-7e29-08daa06d55bb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6362 Testing arm64 is done using the qemu-alpine-arm64.sh and qemu-smoke-arm64.sh scripts. These scripts are executed with exactly the same artifacts (container, rootfs, kernel, qemu) and the only difference is that the former is used to perform dom0 based testing and the latter - dom0less based testing. Because the current naming is quite ambiguous, rename qemu-smoke-arm64.sh script to qemu-smoke-dom0less-arm64.sh to reflect its usage. qemu-alpine-arm64.sh will be renamed in the follow-up patch. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v3: - commit msg: s/umbiguous/ambiguous/ Changes in v2: - none --- automation/gitlab-ci/test.yaml | 24 +++++++++---------- ...-arm64.sh => qemu-smoke-dom0less-arm64.sh} | 0 2 files changed, 12 insertions(+), 12 deletions(-) rename automation/scripts/{qemu-smoke-arm64.sh => qemu-smoke-dom0less-arm64.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 1b51030c6175..f620622671f8 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -81,12 +81,12 @@ qemu-alpine-x86_64-gcc: tags: - x86_64 -qemu-smoke-arm64-gcc: +qemu-smoke-dom0less-arm64-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export @@ -100,12 +100,12 @@ qemu-smoke-arm64-gcc: tags: - arm64 -qemu-smoke-arm64-gcc-debug: +qemu-smoke-dom0less-arm64-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64 - alpine-3.12-arm64-rootfs-export @@ -119,12 +119,12 @@ qemu-smoke-arm64-gcc-debug: tags: - arm64 -qemu-smoke-arm64-gcc-staticmem: +qemu-smoke-dom0less-arm64-gcc-staticmem: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64-staticmem - alpine-3.12-arm64-rootfs-export @@ -138,12 +138,12 @@ qemu-smoke-arm64-gcc-staticmem: tags: - arm64 -qemu-smoke-arm64-gcc-debug-staticmem: +qemu-smoke-dom0less-arm64-gcc-debug-staticmem: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64-staticmem - alpine-3.12-arm64-rootfs-export @@ -157,12 +157,12 @@ qemu-smoke-arm64-gcc-debug-staticmem: tags: - arm64 -qemu-smoke-arm64-gcc-boot-cpupools: +qemu-smoke-dom0less-arm64-gcc-boot-cpupools: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export @@ -176,12 +176,12 @@ qemu-smoke-arm64-gcc-boot-cpupools: tags: - arm64 -qemu-smoke-arm64-gcc-debug-boot-cpupools: +qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log needs: - alpine-3.12-gcc-debug-arm64-boot-cpupools - alpine-3.12-arm64-rootfs-export diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh similarity index 100% rename from automation/scripts/qemu-smoke-arm64.sh rename to automation/scripts/qemu-smoke-dom0less-arm64.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:47:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:47:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412375.655747 (Exim 4.92) (envelope-from ) id 1od7C2-0000gZ-Ky; Tue, 27 Sep 2022 09:47:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412375.655747; Tue, 27 Sep 2022 09:47:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7C2-0000g0-GB; Tue, 27 Sep 2022 09:47:58 +0000 Received: by outflank-mailman (input) for mailman id 412375; Tue, 27 Sep 2022 09:47:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7C0-00061O-CQ for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:47:56 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2040.outbound.protection.outlook.com [40.107.101.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75560815-3e49-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:47:55 +0200 (CEST) Received: from BN8PR12CA0034.namprd12.prod.outlook.com (2603:10b6:408:60::47) by MN0PR12MB6320.namprd12.prod.outlook.com (2603:10b6:208:3d3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.22; Tue, 27 Sep 2022 09:47:51 +0000 Received: from BN8NAM11FT003.eop-nam11.prod.protection.outlook.com (2603:10b6:408:60:cafe::b3) by BN8PR12CA0034.outlook.office365.com (2603:10b6:408:60::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 09:47:50 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT003.mail.protection.outlook.com (10.13.177.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:47:49 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 27 Sep 2022 04:47:49 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 27 Sep 2022 04:47:48 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75560815-3e49-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1Z5liq/7VWbBcW2hNjwfk3+3lfk4W4x6KQIJGSkX+/OqJO4yklNwrqQ5pLS4/yASjF6y4iHlsZ8OkgP4OWfVYkGVsHwOSarv3JQzt6FVChbG8w+Gi/ZCpNLt2oDzvr9KdC8RK61zWmXGcdK6gIqyIt7BO9/Fr8YJPYWesKPMtm6GgEh7ehnrc6cxYzxsPXl9g5z5F7EhjPjBhNPLx5jeLeBeHnoofrGy6IZheIyidgchtqGTBZbnMSBMiIbQdSkI3f/7QlAmFnReXRKXgQCD7A97+WAa85rXVbcpRBQGqsfEadLxeLjt5dS6RBDDYx8VGH8EE2Qwvg62eNBvOyh9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EiwOv4leuSuV4GNiEJBaf6zeLa68ftsFudM5NmbMmNo=; b=dyaA4wMIZF4VxG8gT1v9pyQsb8pranRNPcBpxqYw8mibMWOIrMq3cPaOJ/odPc13nl6msoLFFfahfcPT4aVWyH8LURScpvHOzTuPyyHLOdWwV2ySWc/Q97gfA+V2m4TOAATyUPI5dvrqQYPgQSH4Bx+0MBJN4tmwisXHUGTMcNf8HPC3NBodzKdcbJnMo7f6vyAl/D0iWbi7fiOjWy0gRmAgWZmMBhZa4fmvT630sy7z8/A0Zu46p7exu0pKAgoHYuAPHQJA3FxcAtgdOSdzqnT/QIzUrwcFcGjGKvoe93ywK7nQNQpcriB80caItjeem3MNfsqYG+it/hpcsUQVdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EiwOv4leuSuV4GNiEJBaf6zeLa68ftsFudM5NmbMmNo=; b=a7vZUUFJ9ystvw+IZzVZsvMPGVvuCswrsoHsjZg2xpfadwg2OZt7r7qXYUrXSomJStesnLFX29DQ/hWXjefCGrFR+zCajNt2HWmkD0Dqv/Q+Bw8nJgQx8w/BdFHItOuGFN7KSmf9lRKywNUHYYee0ktGIAAPqdr7op7hWsE3uoE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 10/10] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh Date: Tue, 27 Sep 2022 11:47:27 +0200 Message-ID: <20220927094727.12762-11-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220927094727.12762-1-michal.orzel@amd.com> References: <20220927094727.12762-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT003:EE_|MN0PR12MB6320:EE_ X-MS-Office365-Filtering-Correlation-Id: bc4017af-bdb1-44a6-d046-08daa06d572c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iPk47i0YlYi2b5MGdhFjwpU30pyRRn6E/4pfn0ufXjcaOROkOvVyyjrfDDf2sQdfv07NKG1f4OZSEnoaebYZ3fYfNzsoi+9paize0ycCqdPxiHbKvHoViL4GlV0ajPnGhOjfILh3sBzmbgemcyDDfWk8gVtz15iKK5F2QB1HvPn2g5XwKV1cwS/vYFr+GZYHkY1JX5rpZ7jhAbdExeuAJ1nTOhLbKcW+8uGZi3A4r3U4WCZTDbrpQt3cghbiYggqpxF+3LGz17dH7ZV3WKNkSP8cbo6wcnFcj+LbjuZ+eGV1dt4UblNGXVhFscEXXeexkc7ti0BOJsHBRaSKahP3DN9E8Tz5bmJ7tmlT0LJfzE7XA+MPPgUlyS8pgkSZg6BMKXqVGFhA+3Y8vJ/bCSnG3+nptfopEaiTfo8MOluFOdh1UxN+JOuiYFBqoKPz/4xvOmQifaHWGNORfoq8VRHKhManD7MM8KZr6oK3l7dyb2Or6dIVxxNFDZust8rsyj5t3xh4m3rDJtMJhSY6l8o4u2tjlSETGa7x3sYYlLOFDFi1Doz7O1uyMxdFFCi4VKAjzqxDAS+4NQiOVf4peULP9ph/2tYhbZSPUT39UOZLgEcbympxO8CAn09IdxHyh29JOaN1VNiro/FihWeJFlV0mmsS3pmK1TOuqDOrhOZhm2G+ZoepmInkVLwQFG7KfkBXwCPvmboSB7eDRfR6Pih9Bhdy9UCqsgrz9OsbrEmjLJTXL+qczp1McLqub8lUeBYS7WTv0v5quuFsxMEfPOTEWTI/Sg+PywIvKMiEonkrOyCfAZcuFPYaUkSjNKPsxAB+ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(316002)(36860700001)(8936002)(44832011)(41300700001)(4326008)(5660300002)(86362001)(70206006)(478600001)(54906003)(6666004)(26005)(1076003)(426003)(83380400001)(70586007)(336012)(186003)(8676002)(6916009)(40460700003)(2616005)(47076005)(356005)(82310400005)(82740400003)(36756003)(40480700001)(81166007)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:47:49.9999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc4017af-bdb1-44a6-d046-08daa06d572c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT003.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6320 After qemu arm64 test scripts had been renamed to reflect their usage, do the same for the qemu arm32 test script. Currently it only boots dom0, so we can assume that this script will be used to perform dom0 based testing. In the future we will be able to create corresponding script qemu-smoke-dom0less-arm32.sh to perform dom0less based testing. This is the last step to get rid of ambiguity with regards to naming of Arm test scripts. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v3: - none Changes in v2: - none --- automation/gitlab-ci/test.yaml | 8 ++++---- .../{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename automation/scripts/{qemu-smoke-arm32.sh => qemu-smoke-dom0-arm32.sh} (100%) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 3b147c88ab08..92e0a1f7c510 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -195,12 +195,12 @@ qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: tags: - arm64 -qemu-smoke-arm32-gcc: +qemu-smoke-dom0-arm32-gcc: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log needs: - debian-unstable-gcc-arm32 - qemu-system-aarch64-6.0.0-arm32-export @@ -212,12 +212,12 @@ qemu-smoke-arm32-gcc: tags: - arm64 -qemu-smoke-arm32-gcc-debug: +qemu-smoke-dom0-arm32-gcc-debug: extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: - - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log + - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log needs: - debian-unstable-gcc-arm32-debug - qemu-system-aarch64-6.0.0-arm32-export diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh similarity index 100% rename from automation/scripts/qemu-smoke-arm32.sh rename to automation/scripts/qemu-smoke-dom0-arm32.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:49:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412416.655758 (Exim 4.92) (envelope-from ) id 1od7Du-0003x0-91; Tue, 27 Sep 2022 09:49:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412416.655758; Tue, 27 Sep 2022 09:49:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Du-0003wt-62; Tue, 27 Sep 2022 09:49:54 +0000 Received: by outflank-mailman (input) for mailman id 412416; Tue, 27 Sep 2022 09:49:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Ds-0003wS-Te; Tue, 27 Sep 2022 09:49:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Ds-0007FM-OK; Tue, 27 Sep 2022 09:49:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Ds-0002cV-5A; Tue, 27 Sep 2022 09:49:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1od7Ds-0002R0-4i; Tue, 27 Sep 2022 09:49:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g+aF6pLT/kMg/WFVdu3V/t9cM6lXyVcQ+PwiT75uODM=; b=TOx1Jzu6Nwx44RR0KQViGd03hA ymbQubQG2VS6QOoyfJXKYUp0PCBxGgJp/CAVCgfkPesg2V9FAcxBNpEGTZ1Vn9TB0T4P31Incs1lm 5/Z7X2YLwVnRCmVEbOH7r5lRVPGvIKpXIeNbiUVAxOe9lxNG+ULe/AwRwg3Es3FtsQUw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173325: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=fa2a7f888c1466f2cbd6b349540c5ad5e1d54a04 X-Osstest-Versions-That: libvirt=0377177c7856bb87a9d8aa1324b54f5fbe9f1e5b From: osstest service owner Date: Tue, 27 Sep 2022 09:49:52 +0000 flight 173325 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173325/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173303 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173303 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173303 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: libvirt fa2a7f888c1466f2cbd6b349540c5ad5e1d54a04 baseline version: libvirt 0377177c7856bb87a9d8aa1324b54f5fbe9f1e5b Last test of basis 173303 2022-09-24 04:18:58 Z 3 days Testing same since 173325 2022-09-27 04:20:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Göran Uddeborg Ján Tomko Kristina Hanicova Martin Kletzander zhanchun li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 0377177c78..fa2a7f888c fa2a7f888c1466f2cbd6b349540c5ad5e1d54a04 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:53:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:53:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412435.655770 (Exim 4.92) (envelope-from ) id 1od7Gp-0005T0-Nw; Tue, 27 Sep 2022 09:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412435.655770; Tue, 27 Sep 2022 09:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Gp-0005St-Ks; Tue, 27 Sep 2022 09:52:55 +0000 Received: by outflank-mailman (input) for mailman id 412435; Tue, 27 Sep 2022 09:52:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Go-0005Sn-H4 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:52:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2068.outbound.protection.outlook.com [40.107.20.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27077972-3e4a-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 11:52:52 +0200 (CEST) Received: from AS8PR07CA0022.eurprd07.prod.outlook.com (2603:10a6:20b:451::17) by DB9PR08MB6620.eurprd08.prod.outlook.com (2603:10a6:10:256::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 09:52:50 +0000 Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:451:cafe::33) by AS8PR07CA0022.outlook.office365.com (2603:10a6:20b:451::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.14 via Frontend Transport; Tue, 27 Sep 2022 09:52:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:52:50 +0000 Received: ("Tessian outbound 99ee3885c6d5:v128"); Tue, 27 Sep 2022 09:52:49 +0000 Received: from 58cb7bc26f62.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 250A2EC2-9752-4978-8940-69E629EA59BC.1; Tue, 27 Sep 2022 09:52:43 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 58cb7bc26f62.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 09:52:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB9PR08MB6331.eurprd08.prod.outlook.com (2603:10a6:10:251::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:52:40 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 09:52:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27077972-3e4a-11ed-9648-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JbT5AoMNrXZdhj4mUtIR1cSzZ66m+fKgYl/lMds8iGqEiI0kV8B3UaDyEfACPfJtcN9GcPcT/SfOPncPdvn5QR+DoKWYdzOjNUrp0M15XVvqgPdbHN9RvvSd5Oe5G375JwQPTdDqXv4hFU15Is3o9eaiuIlY3JR2QxrScwrpyGtP5YpoC9jqPykQ4sKHV0QNiy1UcdyqryypHe9t4fO9C2pN4biOy6eDSE9HisXX9X/hW9WhDrfTe+0duXi26DaMhiBGhnuaFRlTt/lDJ9y3xeHVxH546ArGoisEKnjS6J2v0CLUgejxHzDNsms0i1S8Vr6tc5oW7krCPdVFuQbsCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x5T4xcs+fgl0o6ntK/Xq1p7Zxc2rJPIJe5eMydf0Nu0=; b=Q74VlkQ1FPyvvdXT7uVYuSHgJxqxKZ3UNaiQlHG3eItBH6YwTq93xsmjcbG3MoFEN2J5T+hZ99SBdkngLrN98wprDYT0j+AYkIo2Y1725vui9xd27Tc1thIl6ruIjXVrJ6js9oTeq5cXFeHyncuOafUFRH9SlbdhjRaCDdUvhpUZkA1hBivh2TLhsz2UFiftb9VoaWJDKhCaw4LEfVnpVQsQ81ew4x1fdKc+8F0DEmoYablYXTaGV5HrDIWintYwaRAMMF78kxYd3J4pJKFNpIGCINYuq6yWee7hp1Nx4+UJgcEGSNEl9cHqmeChmj3ahBvvzpRWVHJWRCGBCeE2UA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5T4xcs+fgl0o6ntK/Xq1p7Zxc2rJPIJe5eMydf0Nu0=; b=OD93kzjmgbZfBzSbsRxtxmG4igStDS2y8WeoWal3m1bn0N0bQvbzy+1eP6iCTJGniGhbCTkD1cInRS/fYQx/CBQPe5tyOPZhMmh8l1f2k3eR0JLe+XZMYmNzKqIkxJ9KBTDFjlGV4sp6HB+QjFlnQF73kjl1gXaUryhbNmza3a8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5744ed7afb5fb337 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAngEPmcTkpD8RRJCPdr/kNMB3KSTIjO9RVFPut+v8Z9zl1vmSegwJrHj9tbAX2sZRpIonsgCxBQkIgDFAazPCKdLahEaS3SFyHdFFkpVloKQJPfRLrlI5AtEB3/E27DW3n3pVGwkbncDhzpFnsQU9oXW/MmWn6agDzyaFhpuLYyoBEoEq5a8kea0tG/T0uzm1sKxji/epdbDtSgpYrdxjJAf2bpU5AjENClHhA2btUQU5QjliRFRWSLfy/aRaRMPsVrE2PwPHapTKd9TqnJvozTdJOfmvMm2HkPESE7ca1ySEdNZ9SIUwnydpXMTJ3cWpCE82APZSU0UenYDwD/hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x5T4xcs+fgl0o6ntK/Xq1p7Zxc2rJPIJe5eMydf0Nu0=; b=Pi8N28f/zXFZmVCkK28EVG32eSdE6iLb5RroHC2DGTjHEzy39TDYgV6r7NFrFoU4S5H4+BNW/1kksQZJQEPc8W8eEwWosyclpSZv+3mOSwuUcS6occovS1FvCyyflLwMGogwB3VEqSq2HjycskmaEdefmEzrrsvbN9+IdKr3ZWhHUnZUiDnP7SU9dv8QTwQwNsP5jgoiMq6M9vyOD6i31ckkDWTM53seCrHR541v40OjhTBQrdBSpkK5qeuKgMHIQ7o00ipRUuHjtcGOVYTPmwy22IX8b0WWt3iRXwKwC79Gc2DQ7pbjg2OmvvfOtTmVY7IwIo1WrAzvwH8dSZ2omw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5T4xcs+fgl0o6ntK/Xq1p7Zxc2rJPIJe5eMydf0Nu0=; b=OD93kzjmgbZfBzSbsRxtxmG4igStDS2y8WeoWal3m1bn0N0bQvbzy+1eP6iCTJGniGhbCTkD1cInRS/fYQx/CBQPe5tyOPZhMmh8l1f2k3eR0JLe+XZMYmNzKqIkxJ9KBTDFjlGV4sp6HB+QjFlnQF73kjl1gXaUryhbNmza3a8= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v3 07/10] automation: qemu-alpine-arm64: Cleanup and fixes Thread-Topic: [PATCH v3 07/10] automation: qemu-alpine-arm64: Cleanup and fixes Thread-Index: AQHY0lZEIc8FFBrysEKfGaXgho1gHK3zCRKA Date: Tue, 27 Sep 2022 09:52:39 +0000 Message-ID: References: <20220927094727.12762-1-michal.orzel@amd.com> <20220927094727.12762-8-michal.orzel@amd.com> In-Reply-To: <20220927094727.12762-8-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|DB9PR08MB6331:EE_|VE1EUR03FT036:EE_|DB9PR08MB6620:EE_ X-MS-Office365-Filtering-Correlation-Id: f78f884a-9672-45e1-d959-08daa06e0a0b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ty7L+dDH1zAeriMV1/G/O2+F6tkypSrGHX8jHB9z34FLlKVgT8G+d/dXZxrU/+MUEPm/JnMP6GIGfoGtN1bUqFpVHQu/cE6Gtg13yp8z9Nh6l3Nq7WeWLCnbiPmWfn3KcXjKEqt0miRRmHhWoK5X+7+41Y4Wgqp/+dXc7vrY3E3MVr1SLdPYl1DhQvWATEd7MeeqSIw975si7TumtudIbHnLBKlLhlVde9uk8LH9UruVA7hEtYOEZYHlIW9ZqXn6hdapa9pxi0yVieD9j+bN0ydobhNO3N3QSrtXsUbDjbk2Gorr2IL37fGZ3FFzjcYbgq7ox6xMbtN6RerJmXdm9tcgktKWyW8H/VfmSBqGsocR766uuGSvr/sfGr4f4Vw3P0FSkPHptdOBKcESHRngl8oO7x1idpSfhtaA0L2tDuorYcTAwEDjkRkd7nN32NzSNVHwDKyVUpQmFVRabZZiNepimtcRGc3/U2ykm6qeK2JJ4+ux0p9T6AEXu6A9wDMbN3MF0AQYoYM/i7TIBMtTOD4wMR7z+TsFKrexzdcEpLKLh+Tu3eLOPBK9fIwAc3HQbUWb2V9Woxdi8O7MzKNAWX7PTpvErqtUwsQ1yOG1YBIeWLD5cglwjaqByDsEwr/nIO/nQ74Byl3gNnyMUvALZgUO8SIr2THRWgyuxFUJfGAnxd/z6czoEwaI6nb+6HdidyoLqf8mT67wAQopb1FX7Iw+6lcOxXQgbBjvHYaa47HF+fF36HTjV956th4zvPAbYm0Tn/Qog0o+APeYc3yQ/oavGGC2CNp1Z8To8J9oEVo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(451199015)(8936002)(38070700005)(5660300002)(2906002)(4744005)(86362001)(71200400001)(41300700001)(26005)(186003)(6512007)(6486002)(478600001)(91956017)(2616005)(6916009)(6506007)(53546011)(4326008)(76116006)(66946007)(66446008)(316002)(66476007)(122000001)(8676002)(64756008)(66556008)(54906003)(38100700002)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6331 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dbc7de6f-d52c-4982-ba2c-08daa06e0386 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zu/Pp7lFQ1UYNJPZpZ+dYTT5WQwqbrkp3Og6e0Uyg6x8aQAIfequtC/dnV4NjN7/NxQGeWs14RmMr6cxvcqWmrPLs1/lfzetSCUKlRytu+2QPwJdPt0Bh/x/C3Me+o3RhAbhOOzkeJfxJAfPIqot9bOYraSsWD4XTCKOKe+U69KBunXgYott5ABEBDgrOglgMREJOdPAjK16WwXF8q26wUwauRZBDvqT/6aVF1OBjlKJLSTL1N/RouYtKN0hHb4LDOqfJfu/I+x6aUzq4Ffj+SiX7JvsvmshWZJ39mIGrpJQQpAVBTmFCWfPhmvPriGcHDNgqu0IC5evYDChl0sa1Lcjg79kXE0ZRnsnlzf6rorpaXkM05gTNtJEHbIrE5KmMf3SVR6f+wt5dDKa9KUwk3g7rtWyh6zRnIhw7nDwu0Sa1VHyEJiPnZvxIe/2qioPQhjyKe6xvWPvS+19LrnYTd5uEeO7OIQWVUn1lHTzkarc/Vp2HIP0RCJxvUMW2Gmz+5erPrmOlo1gWMPfQscJNnO9lsj3DeZgEg3K20udqp3egsnkw04O61r82C9LZMQw2Il22CiGu4pJ9FbNwvuhJO2wVNeXlBzNhORaHLnmVJculG5SjVzNkC4g48hb/HMiPVv1vGJ8GKwK4jtZId3SLXCelyqwiZ+EQwH9ksuBxSbmcOUB10KcovimPGi67DEYzpy7jVOMiN3kW6YUP/PVc36aHrNFyJS58S+yhhvTzdL3Yb1598nfn/yBS1TFErc0+dmBSv0fr40SCm0S5HZa4Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(81166007)(356005)(82310400005)(70586007)(8676002)(70206006)(86362001)(82740400003)(8936002)(6862004)(53546011)(6506007)(41300700001)(6486002)(33656002)(36756003)(40460700003)(478600001)(4744005)(40480700001)(316002)(54906003)(26005)(6512007)(5660300002)(36860700001)(186003)(47076005)(336012)(2906002)(107886003)(2616005)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:52:50.0648 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f78f884a-9672-45e1-d959-08daa06e0a0b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6620 > On 27 Sep 2022, at 10:47, Michal Orzel wrote: >=20 > Perform the following cleanup: > - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version > used in this test is v2, > - use fdtput to perform modifications on the dtb, > - use DEBIAN_FRONTEND=3Dnoninteractive to prevent interactive prompt bein= g > stuck waiting for answer other than "yes", > - fix the number of cpus in the device tree because currently we generate > it with a single cpu and try to run QEMU with two, > - fix the memory size we pass when generating QEMU device tree as it does > not match the memory size with what we run QEMU. >=20 > Signed-off-by: Michal Orzel > --- > Changes in v3: > - s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/, drop Ack > Changes in v2: > - none > --- Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Tue Sep 27 09:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 09:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412443.655780 (Exim 4.92) (envelope-from ) id 1od7If-00066B-74; Tue, 27 Sep 2022 09:54:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412443.655780; Tue, 27 Sep 2022 09:54:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7If-000664-4S; Tue, 27 Sep 2022 09:54:49 +0000 Received: by outflank-mailman (input) for mailman id 412443; Tue, 27 Sep 2022 09:54:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Ie-00065y-1l for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 09:54:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6aba7514-3e4a-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 11:54:46 +0200 (CEST) Received: from AM6PR10CA0012.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::25) by PAVPR08MB9402.eurprd08.prod.outlook.com (2603:10a6:102:301::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 09:54:43 +0000 Received: from AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::69) by AM6PR10CA0012.outlook.office365.com (2603:10a6:209:89::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 09:54:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT017.mail.protection.outlook.com (100.127.140.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 09:54:43 +0000 Received: ("Tessian outbound ce981123c49d:v128"); Tue, 27 Sep 2022 09:54:43 +0000 Received: from 48459654104b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E9BB8834-52DB-4859-B015-57645A67F56F.1; Tue, 27 Sep 2022 09:54:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 48459654104b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 09:54:37 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS4PR08MB7950.eurprd08.prod.outlook.com (2603:10a6:20b:576::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Tue, 27 Sep 2022 09:54:36 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 09:54:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6aba7514-3e4a-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fyQql/WFU/EYVD6D6TTgLA0nsrjn/SxQkt/87TaYzFHr1cj01lTAmqHUu8khlGHgMCVO9igwjAImo2W8SL8NB3UjxtKyQ+RmBrRnaWJt6hkjkaZ1GubeXLcirL0YI72uaChpJ/RZQ2weAR/SACZdWubBsCUA9Tvwdu1uuWIk1rlRGo1tuHuUAhuH5k45mbBaWytVPNg8XmkdOmeKe1mD8PhxItJIhr3Vgh4LJEuHvPUtYrDSo0IKWfHZIHoYd6mXBUG3hrrMv9p08m3Dm5yKNOKxl8aI/5++cuMAquFonbYw4t4ptASM3AN59fG5R3FRhvwqDo6HJ3b/Rz2MmPrEHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fNj5LyPGTgP8nBL4M5hDYfG2hHYT5Bypq+EWPXCJFvI=; b=IegX0mAjaO1/HzckbKxHBHhuX6vA0dz+tv2VutTCr5pa737LX/r024SBo98HIM4UCzrDlpnjfr7hUjW08GAvmcrqILFNTP10JiHjDcuVasDgOR75aSLYs9cVhFM+wLPClTFerMD0MWpr7nhXQQ9kr+X0xYyks8II4V0nuzWGyvsDE9tD/GuD17BrEgxphdasBkayMvToc80sVEcnqEUuYENrNr6LL+1zyRruYfmYvN3ePULvbmAiyOKgvoQXvOMB9RnHBGerm7Hg0c/McPnqU+6b34LzdRu7DWjCGqDc90kM/GNnn4Khi8o/Gj9IuoegdMwGocmQIod/3z3b29hEzQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNj5LyPGTgP8nBL4M5hDYfG2hHYT5Bypq+EWPXCJFvI=; b=R3mLjo3pmxeawaeL1S3ydSnkzWv8dDVlQdbY1yveYySyo4o0gwy3pfGl6Tc+I/tvG3ArgGb1IFQhaWLar73v26XgkzynkVLBlSPYTDZW+FX2jj4hZmYHFmXk6g2LMiTx73XyWqC3FwTpHnrlhG5geVQznJBx5WY7EEQYbw7aWgI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a1919941bf762562 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GAk7DL/eGCNgEG9hVUOak4X6pDN0dUoKSUVY2QH8GZwvjK9+GBmj2mmmFZeVYuN575fOOxx1dW9g/sBuRCOAfHn0D6jAqzdqxL8s6OVhVmzSgnRJiKHAsNZW/eZHcSWJNHR7+ZyotQH6y/NdZiY66eJDnI8CacoTbkuh0itgZBR9YqeMrma3BelXHwVq9uzCIBYt9VszP4/KIqTjyTG1KXOuDvZb4JiRzla9WNv37lS2At4YqUHpCAn5BIXHPE2sqadi7FUZytuyPxrReQ1OSw+/OuZ4biWBRHDVUVHWwt7z0nQUlCyiKcMpm+uodkfRQuUcrmkt2UtnGLEjgY56fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fNj5LyPGTgP8nBL4M5hDYfG2hHYT5Bypq+EWPXCJFvI=; b=Eiyr9mR7w2s4ZW73gx4cA4cvNM7TLziBS4aWufPcV0XAI8I6reFR36VyNyrTrjaXpUHQT95PXW129+ioODhUJiHgmw2lill3utaR08Ixd6POG42Z4d5rzMJ5W1Y/j0fJH6WyXJ2kOZrdBfS2MbuRboTPE03BixqhL8idQSD7gvr61J8C8F7RfBkWBq1mgrkQ8zryJEyxgsdsGSKUkK3ukv+DFDd2gUB2ETtB2pCWePPfJzH5DOQO4pDJGMkiOnW4+YbEuUmFaBjBfu9A3EQWsRf3ad9akKKOAVventQtSsD+K3AFgIrCoKKr+xFO9TCn1DGd+RNN7At828gQkxUHIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNj5LyPGTgP8nBL4M5hDYfG2hHYT5Bypq+EWPXCJFvI=; b=R3mLjo3pmxeawaeL1S3ydSnkzWv8dDVlQdbY1yveYySyo4o0gwy3pfGl6Tc+I/tvG3ArgGb1IFQhaWLar73v26XgkzynkVLBlSPYTDZW+FX2jj4hZmYHFmXk6g2LMiTx73XyWqC3FwTpHnrlhG5geVQznJBx5WY7EEQYbw7aWgI= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: Re: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT Thread-Topic: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT Thread-Index: AQHY0lZOQ7+DCxc2Tka27Nur8gXCgK3zCZ4A Date: Tue, 27 Sep 2022 09:54:35 +0000 Message-ID: <94635988-CF1B-46FD-9E82-03675E59B62B@arm.com> References: <20220927094727.12762-1-michal.orzel@amd.com> <20220927094727.12762-2-michal.orzel@amd.com> In-Reply-To: <20220927094727.12762-2-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AS4PR08MB7950:EE_|AM7EUR03FT017:EE_|PAVPR08MB9402:EE_ X-MS-Office365-Filtering-Correlation-Id: 62465daf-d145-466c-fc5b-08daa06e4da6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: v28lA7OqZFjhU1wm4f4r6X+bhYnEFhksA81IjS5cif8plyY8q+CRcwltREWxo26U7pjYhJxYn7k9idrbk3UYpU4cDnKXyJjKcnDmgqtNLnS8UAFQNBPXk5WzafZd/YE7/v501s145JaS7C6mkKopa//80V/ZbW9/+/j3ETmNZeUWTIy2NEtH2vcJHBhkaU/ss7RQ6tfrV5ChZicnZRu0zWeEMJf/bTLXWuZoqKpaq2bwBHq8kBt92kjxInKrVn/XW85fyKRt8rLhPc6fFBSrjAbIJMc7IpFKjeWigIOBB7lktV6EdWAlNzvjw1hJTmSvrCABH7oNLCg2HEh6TErRoG2/6RjMDMDjRfMipnMYSHyXFBswhvVlYY/CcR6qK48ixZ8ijaskKVaMmVoEKHXa8SwG6IFENnj1+ss8kE9TVXMNYQVIIP4keGWZTGX/XIx5tzqGV2yivDLBPEncjf0/aGVfAnRajHb9rGBYieCVGgIN1LD//5ViZqwBnseJNzS4E2S0LQLE6GpMkCTZwwPqtbIvywf1FyuOC5AYfNt178rVhA2gxsFWgulED5X4fKUpsQZdXWO/GTYfHvghqRYIfwdXSldlmKHhlTTX6ErAJVbQTtJmTWWBC23rIFQ/A8DFGE2s35HuwIrAJUYCI5ocVAcaYjTuYqfS0USq6cQR/k9XlU+IItBBdrUNfIiPqjs1zfJcWJtwJrprDGamacY6N4RN8lmEofgjtAaIJZxipddGbWtQgahHPmPUjNNk25vrCfSRfhrN1dykJMn1UDx0kgrAusdGSWDgBXz+XhvH+xk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(186003)(2906002)(38070700005)(478600001)(2616005)(6486002)(54906003)(122000001)(38100700002)(36756003)(316002)(6916009)(86362001)(41300700001)(26005)(33656002)(91956017)(6512007)(8936002)(64756008)(66556008)(5660300002)(8676002)(4326008)(76116006)(66446008)(6506007)(66476007)(66946007)(53546011)(4744005)(71200400001)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7950 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1efbf6fe-a08d-4130-15c7-08daa06e4921 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CFbSBwZy7lq4eHztGLIdS6iamDj/yz9bYA3GGpHzXpHWnLKNupHxI79tT+U4g9FcTFcNxz2NAAd1AjpXskCr74O0Uu/wbcAadlvLcelIs1ed6Vz4oCIa3TVBgWlSq2iHBVEjGTjy6UeZLHUKYbdICGrYGXia0mc/0YJvoOyeF4jHxi4xmLTVz4SZRnoXn1nZAn9qj0Z55/ZFu+X+oq7X8WDloIJhsVnDRGBqwwQpcOpL+SK2r1V1uZeeZbdZeEpJ6Y12T/WCpjKpC9ElfXHD2bmz8+HCojUlk2Yty0y2FTHwaVO9wByxIUX8Wu075AHu6NoGpRUJXW9eON3CpsBS1+GaZvqMmBYpgKocyDDgI4UblrBEQUcD3wj1moZgWVUzaNbGSD2iYE6CsE+9Z95wq2aOAKAmsBXBmSrRgLMnpZfK78QDROkdwAADkNZAZp3Hu1JimnqKFlmpUe3VpWuBK9yE6oyI92t6bdohbTOrmBD5G1DKAI5vLHwWN/SXk3J9ghcNuQfwhHpaJtfhg9erhb2goOG7NXYy03YJSXMHMbyC4qBIyOoWX6h37rUjlgg9DFPzD6xAQvBQMppj3aZdlxACjdL05kZly8rLafY30gGVZFv2KTrEuxPDDgai7Gz05tDdvoSgWWd6JLmCONWWvrdt1bHY/lxh0qyZ+zHgClh7vcbiBuAbFH+DCkaLtdrce/99W4Qcd10phj62dFdNV9lNK8HOwdfeB9LAmjHJ7e2TuD9q5FoXHX7oKi/cJRHCVrw5aXGvicOVEqa5nwPDHA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(186003)(54906003)(86362001)(6512007)(70586007)(70206006)(316002)(40460700003)(8676002)(41300700001)(4326008)(478600001)(6486002)(47076005)(36756003)(82740400003)(83380400001)(26005)(36860700001)(40480700001)(4744005)(53546011)(8936002)(6862004)(6506007)(5660300002)(81166007)(356005)(82310400005)(2906002)(2616005)(33656002)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 09:54:43.5357 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62465daf-d145-466c-fc5b-08daa06e4da6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9402 > On 27 Sep 2022, at 10:47, Michal Orzel wrote: >=20 > The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. >=20 > Signed-off-by: Michal Orzel > --- > CC: Henry Wang >=20 > Rationale for taking this patch for 4.17: > Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interac= tion > while installing/upgrading the system via apt-get. It accepts the default > answer to all the questions (using apt-get -y only works for "yes"/"no" > prompts). With the typo not fixed, we might get stuck in CI jobs. > The risk is very low as we perform pre-push testing using GitLab CI to ma= ke > sure the changes will not break the pipeline. >=20 > Changes in v3: > - new patch > --- Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Tue Sep 27 10:07:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 10:07:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412466.655792 (Exim 4.92) (envelope-from ) id 1od7Ua-0007om-AH; Tue, 27 Sep 2022 10:07:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412466.655792; Tue, 27 Sep 2022 10:07:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7Ua-0007of-7a; Tue, 27 Sep 2022 10:07:08 +0000 Received: by outflank-mailman (input) for mailman id 412466; Tue, 27 Sep 2022 10:07:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7UY-0007oY-LL for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 10:07:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2360344f-3e4c-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 12:07:05 +0200 (CEST) Received: from FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::23) by DB9PR08MB6474.eurprd08.prod.outlook.com (2603:10a6:10:255::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 10:07:02 +0000 Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::47) by FR3P281CA0072.outlook.office365.com (2603:10a6:d10:4b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15 via Frontend Transport; Tue, 27 Sep 2022 10:07:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 10:07:01 +0000 Received: ("Tessian outbound 7e4a920b87c0:v128"); Tue, 27 Sep 2022 10:07:01 +0000 Received: from f3b91cef4d80.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2D6A9716-8E51-41E9-BEC2-F01D9148CDCC.1; Tue, 27 Sep 2022 10:06:55 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f3b91cef4d80.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 10:06:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB9693.eurprd08.prod.outlook.com (2603:10a6:20b:617::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 09:51:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 09:51:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2360344f-3e4c-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CCW/8NlgE5GasuyNJ7//NH/bj0ObbyyDqRpnlFQB6XAr5Du547DULeZyRu2FsN24waHLkKp+AIwEWzxZ5kBY2uh6jtmodoiH3B9QKYze2VXeW9eXA+MaeCmqwkC9io2RvnexUbMHXMicMwaTQBHfbvA3s3x31Mb8J50Nx1rfWJVo0r4f0htzdm709g6nbOpXco5SOAs2YyyLMARHiXrY1HbOz7/uuaA+5MmYEvPqkC3AdJN/cm5JrxV9ttOj3upinyNvde7/cgx/oGTR/ZK3NLQBvJBgV5AIQGyMbq+l+5ysobdFH3oDb1nd5+ewjw6dBL+f38UHcyK+YQ3SdybUmg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Go3MPMRwpXFKHo+ehy+CQzA0SeVKJ6rqZoPaAo0mcU0=; b=dXmtUlIkrNWWRRbPAxDY/L1RIJhrPhfGAFioqMJC8pGUvVien7r7pVcZDmF8jOGUaS6oA9zjfbji/rbyxgm+Fyui7js8Qzv8qLq48CDwrORVv5Dc2/lEsq8VYnSPodGF7AB4Xv1A5V9rxD/iH5K4EIJBd80d1IFfW3VwyeRfPDnxnPKw9i/PLt+qaWcsIVY4uszP7sMlvIhAob7FoAt4Q6883mijQEnkn+0uNqE4SVvWQFFstquEm891sqi6RQrHIUBXxrRFnzWl63JfX1yWThMI59tsqdUoH6C4E+KhcEEa1SdvZ5+Uytnm3XGykGv3LdMvhtm6VBKxcihjlop1Zg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Go3MPMRwpXFKHo+ehy+CQzA0SeVKJ6rqZoPaAo0mcU0=; b=KFfGj+zgCcBmc6bkXMUbuW/Yw5i8p7lSKocW3h/6r1vbTy+zMtdVsL9csnBsSAKsUYir+oqrpo7atT2sMX8qzUPdVicqW7h6MwDffEJOWkbaUfCFrhmmRi8TIu124Z6Kn1VjwFMtdK0K6He2zJKf0r4FxaJMgdHPN0YVKKnWC3g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fa4N6CWF7UybnPdHVKKiiXXpX3WZOh1zXjoMNZzUAOPczEgdWD/bkdex7Ga5d6JXhv4VwYQmkgKjrXF/c8M79eX3TJS/tvaK/Zbn3p0q5CO7b2Te8iXUamE9KDjmjSvH0IX1CU+BMGw6UI4e4bLupTKciwXlCTS0FSrSdajtJScLx8Go7Ya4x9w2QqLH0JP2po+0G5J/tJolJZr8Nu/zOx7rjyBagDjfqZjK+aDIgE7fenTOi81KNEqTwGGcgzQm9jhPoqyluRVcmxJSGETQw670AFdsJozC8ggFRrnJBls2+xhfYNwZKA44HE56h7VqJSavzF9irTpXPuQB9K3T5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Go3MPMRwpXFKHo+ehy+CQzA0SeVKJ6rqZoPaAo0mcU0=; b=n2DYbQRahc7iY3cyPQIzfqshUdAsHQVCkpow1LNCyYmdDdNhRKAE1MRL5e2KyIWGNwmk58xpFCDfoXgyfTMCGUoQFwwbDKez8McbMN41LIH/skKt5T2qTOX5FgKloshReP/fykKQ3trOZHqZG5MTLXWM4paggN31j2hyQs76Li/bxG9skyafDE2uTdcviagkPU/o0K/U6jmii18Glb1j4UzUaWBJhAiLtmBlUUAlEdu4OOs+bMiqTMNB7KwxDM+TTK9um6Es0KarpyJUGLbLqF/8TOuQNUg24mojf331XrXbhVDFEkWwqSXF1pR15ES3bGu7lDj+U8k4ROWelbyAkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Go3MPMRwpXFKHo+ehy+CQzA0SeVKJ6rqZoPaAo0mcU0=; b=KFfGj+zgCcBmc6bkXMUbuW/Yw5i8p7lSKocW3h/6r1vbTy+zMtdVsL9csnBsSAKsUYir+oqrpo7atT2sMX8qzUPdVicqW7h6MwDffEJOWkbaUfCFrhmmRi8TIu124Z6Kn1VjwFMtdK0K6He2zJKf0r4FxaJMgdHPN0YVKKnWC3g= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Doug Goldstein , Stefano Stabellini Subject: RE: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT Thread-Topic: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT Thread-Index: AQHY0lY1F0Uwk2EhR0quzgKaLW4epa3zCDUw Date: Tue, 27 Sep 2022 09:51:02 +0000 Message-ID: References: <20220927094727.12762-1-michal.orzel@amd.com> <20220927094727.12762-2-michal.orzel@amd.com> In-Reply-To: <20220927094727.12762-2-michal.orzel@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7346AABF8DDDCE4FAF8850D6EC0C550F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB9693:EE_|VE1EUR03FT056:EE_|DB9PR08MB6474:EE_ X-MS-Office365-Filtering-Correlation-Id: bcdc5a52-2274-4124-947b-08daa07005c8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +4Y2ep9OHHS6zRlWAqS1h/P6Q1NzyPC7zElBWcLcZJ/FQnDknYzp02RT+/RHsjEnwIVmgPPM/EgtJQMazGMBbchFdcJ+1wd6wkBZaELIha2sxiG80QPZhxP9OI1bBwhFUUYpdMcylwbhEbhZzMT7nypNsZsnGxSoEV6+vGk2f10xTcU5NfXeiITCfs0QxpHB3Q1LYf6U3gpTlPFf7sPPVwpwaJbReLBv+HNLO2QFP4tlIzvLPMF0s/0rVJcH7ThXPXhhGr/iq8JtTcQ1Ueyj+fMcnh5PWQNmgArxgWHuuwAK83uI4kOCFepWftUFjxTvZFHLEgGAw5xvwQy0JByPZnY8Q5b5VLMfnRv0fCQLZvWOYZORZ1dald6yC75J0NHK7UWKX0rLyMj06UamuByL6nfMjTpH6fJQIXxi76Ak7cPEDPvPwyciS3hyu6iGA+O63x27npU040sP3Zv9pFLzit/jXdTNzMbDQQRItFNX1NKdZbY5wSB7rlxiOLeQhOKEbTAN438wuKz4whbJS884rqh/cxnK0JobCkyuH3hrfCY5Z+H8A4cHj2zvFwEW2LOJKGPcE8/zlo4bxSHGJJWwoLk1unQWhQzWvGZIHGLTSqqYQVJdq5oYlIztzvXIhbBMqq7EnTZucndln3MkjB3J3+LmrjdBTLW+14rUeWGEBvicfQ3YZZCamZxHeo3NXEX/bwHb0l18m26aaP2GdUpXZLinMsNG62wmdluIezJuo7Px6EXaCJanyc75UAIE8QXeRq99h/GvPaQFsvA5bpLR/g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(66446008)(86362001)(64756008)(66476007)(66556008)(52536014)(5660300002)(8936002)(33656002)(41300700001)(2906002)(4744005)(76116006)(8676002)(4326008)(66946007)(110136005)(54906003)(38070700005)(316002)(55016003)(122000001)(83380400001)(38100700002)(9686003)(26005)(71200400001)(7696005)(6506007)(478600001)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9693 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 50014deb-bb89-4261-dee1-08daa06dca1f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HmdD/subbuvxwyY5A2Oo+Qkjvbg6/FjmaVWHot4MRH7odzwEs8pEkd0fUHUOKlj3gBz4slgV5GmzHcZfOsvPaluwMz9jdkj3FQKd1ambFzTLHbZ016p97t13EGSvjzAo2AQHs5valilalm82LJAdW3gCJQeOYEi6dOhF+0Yp2HcDuVSKU4XaGp8hwlbtkyxr1xo5F7b+wJnNseNsCNqC0455zi6neirZ4Cvi5sg84Jq06AnANmwLMWgdwKGllg+t9NmZrTVJS92koBzfXNLA50Z4Bos5oyNfw4h43Sa7eUPQadS/YwH9n54awrvxdEKtffgSn0FOvXpRomt090/7X5iNf8qKxtGH7NE0s13FiT5TALoiefLD9nWwAZZh3O+0vIulgjjjFHKn7TGSG3bOoM3ndkXC5pfrLJ7sBSCv1y2deMLIYrE6IGG+Zq1+ACj3lwQ2qJ6tPuGQevFPAAvaxX2tXgI833fSA6RT+yfvn1nbyHH9K/+kls4TJ+2esPXFurEdaqumvqk5XaYY4DmgqNZVBaEZiT4cm58Kb3vOmbq3XU1/V4s6UZAZrYKpJUF3ymnnIEoDW+xsrcRrIU4CtJIErA9qlwnH7koUaHF0qQMW9q1pahKI26varK8EpQPYyUOVjITzhTjnbJkmtaeb/YccZxrHzEdB0f5hs7Vjm8Kn/B+1I/f6kXCPi2BF203rOtYLWHBA+eguW50Hv0O2UIcupDTrhEdOFbyGD6kWHz5ML2Y+zxbuk2jK/Mv1UgfLXVIgoBWWkeDgxrEHxyGHQQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(70586007)(186003)(6506007)(4326008)(70206006)(8676002)(336012)(47076005)(107886003)(26005)(54906003)(110136005)(82740400003)(33656002)(316002)(5660300002)(356005)(7696005)(9686003)(2906002)(4744005)(55016003)(81166007)(8936002)(41300700001)(86362001)(40460700003)(40480700001)(52536014)(36860700001)(83380400001)(82310400005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 10:07:01.9065 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcdc5a52-2274-4124-947b-08daa07005c8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6474 Hi Michal, > -----Original Message----- > From: Michal Orzel > Subject: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: > Fix typo in DEBIAN_FRONTENT >=20 > The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. >=20 > Signed-off-by: Michal Orzel > --- > CC: Henry Wang >=20 > Rationale for taking this patch for 4.17: > Setting DEBIAN_FRONTEND to noninteractive menas that we need zero > interaction > while installing/upgrading the system via apt-get. It accepts the default > answer to all the questions (using apt-get -y only works for "yes"/"no" > prompts). With the typo not fixed, we might get stuck in CI jobs. > The risk is very low as we perform pre-push testing using GitLab CI to ma= ke > sure the changes will not break the pipeline. I have no objection to take this patch for 4.17, so as long as you have the R-b or ack from CI maintainers, you can have my release ack. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Tue Sep 27 10:11:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 10:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412472.655803 (Exim 4.92) (envelope-from ) id 1od7YL-0000pp-SH; Tue, 27 Sep 2022 10:11:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412472.655803; Tue, 27 Sep 2022 10:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7YL-0000pi-O0; Tue, 27 Sep 2022 10:11:01 +0000 Received: by outflank-mailman (input) for mailman id 412472; Tue, 27 Sep 2022 10:11:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7YL-0000pc-Bv for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 10:11:01 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af5b7ad2-3e4c-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 12:11:00 +0200 (CEST) Received: from zn.tnic (p200300ea9733e757329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e757:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1D02F1EC058A; Tue, 27 Sep 2022 12:10:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af5b7ad2-3e4c-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664273455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=/v55aZP64ds0qEf5pSfgJzfEvm/TVqPTvdeXcoCxATk=; b=qu2RiuVPERrby2mkgKedt4K0HJeWBVi/JHFjJNAc5f+jUrlxgvuAiF6WYpcagYOuPbVCMF yiIBLQZBX+B6DyPwmygD2M5WJVllVwddXLfF7Dz96FohO12c8NyLokHpoJ/UfW5B2+DrC+ +4LvUK6UoVRNkuc1YZU1iTArutJgUa8= Date: Tue, 27 Sep 2022 12:10:50 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Sep 27, 2022 at 10:57:37AM +0200, Juergen Gross wrote: > TBH I don't see the point of having an accessor which is just setting a > variable to "true". But if you like it better, I can keep it. Accessors are always better, no matter how silly. :) But, in trying to grok your next patch - you really should split those more complex ones because they're a pain to review - I'm starting to wonder whether we could even remove mtrr_aps_delayed_init and make the delayed init the default. Because, AFAICT, set_mtrr_aps_delayed_init() is called by default by native_smp_prepare_cpus(). Which is called by hyperv and arch/x86/xen/smp_hvm.c. The only one that's not calling it is arch/x86/xen/smp_pv.c but that thing doesn't support MTRRs in the first place, right? Which means, it doesn't need delayed MTRR init anyway. Which would then mean that this would simplify this ugly logic even more. Or am I missing an angle? It is possible in this nuts code. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Sep 27 10:14:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 10:14:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412482.655814 (Exim 4.92) (envelope-from ) id 1od7by-0001Uk-GI; Tue, 27 Sep 2022 10:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412482.655814; Tue, 27 Sep 2022 10:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7by-0001Ud-DB; Tue, 27 Sep 2022 10:14:46 +0000 Received: by outflank-mailman (input) for mailman id 412482; Tue, 27 Sep 2022 10:14:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od7bx-0001UX-60 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 10:14:45 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34be8922-3e4d-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 12:14:43 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4FFFB1F889; Tue, 27 Sep 2022 10:14:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12FEB139B3; Tue, 27 Sep 2022 10:14:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n1tWAxPNMmPMSAAAMHmgww (envelope-from ); Tue, 27 Sep 2022 10:14:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34be8922-3e4d-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664273683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=azbsoYkT0nr+gfgwtblGuP0Br8jabje/N29/Y2mlgXM=; b=nvU5qKiA7aq6P+RwThovfCWJJFKdo/wI5HysxWBudaq7I6Byo8TURdSBxXCJED6aryUzwn D/NL3tqQTkOQK+Hiyak+mQuPxNyhQpi2QPm/p669Yo0AC4aFHczY3vSmaqAGKU09nEX32z 9EEUl6Q2wuYZRopRtEPL+0uQfUa6fE4= Message-ID: Date: Tue, 27 Sep 2022 12:14:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------g4zPUaP42ub5sZKf9GZVZKaU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------g4zPUaP42ub5sZKf9GZVZKaU Content-Type: multipart/mixed; boundary="------------NAwU7mueCQZjm0bbNAQSgXHr"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> In-Reply-To: --------------NAwU7mueCQZjm0bbNAQSgXHr Content-Type: multipart/mixed; boundary="------------QIMdqdxhoc6eaoR26OZpwXFP" --------------QIMdqdxhoc6eaoR26OZpwXFP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDkuMjIgMTI6MTAsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVHVlLCBT ZXAgMjcsIDIwMjIgYXQgMTA6NTc6MzdBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFRCSCBJIGRvbid0IHNlZSB0aGUgcG9pbnQgb2YgaGF2aW5nIGFuIGFjY2Vzc29yIHdo aWNoIGlzIGp1c3Qgc2V0dGluZyBhDQo+PiB2YXJpYWJsZSB0byAidHJ1ZSIuIEJ1dCBpZiB5 b3UgbGlrZSBpdCBiZXR0ZXIsIEkgY2FuIGtlZXAgaXQuDQo+IA0KPiBBY2Nlc3NvcnMgYXJl IGFsd2F5cyBiZXR0ZXIsIG5vIG1hdHRlciBob3cgc2lsbHkuIDopDQoNCk9rYXksIHRoZW4g SSdsbCBrZWVwIGl0Lg0KDQo+IEJ1dCwgaW4gdHJ5aW5nIHRvIGdyb2sgeW91ciBuZXh0IHBh dGNoIC0geW91IHJlYWxseSBzaG91bGQgc3BsaXQgdGhvc2UNCj4gbW9yZSBjb21wbGV4IG9u ZXMgYmVjYXVzZSB0aGV5J3JlIGEgcGFpbiB0byByZXZpZXcgLSBJJ20gc3RhcnRpbmcgdG8N Cj4gd29uZGVyIHdoZXRoZXIgd2UgY291bGQgZXZlbiByZW1vdmUgbXRycl9hcHNfZGVsYXll ZF9pbml0IGFuZCBtYWtlIHRoZQ0KPiBkZWxheWVkIGluaXQgdGhlIGRlZmF1bHQuDQo+IA0K PiBCZWNhdXNlLCBBRkFJQ1QsIHNldF9tdHJyX2Fwc19kZWxheWVkX2luaXQoKSBpcyBjYWxs ZWQgYnkgZGVmYXVsdA0KPiBieSBuYXRpdmVfc21wX3ByZXBhcmVfY3B1cygpLiBXaGljaCBp cyBjYWxsZWQgYnkgaHlwZXJ2IGFuZA0KPiBhcmNoL3g4Ni94ZW4vc21wX2h2bS5jLg0KPiAN Cj4gVGhlIG9ubHkgb25lIHRoYXQncyBub3QgY2FsbGluZyBpdCBpcyBhcmNoL3g4Ni94ZW4v c21wX3B2LmMgYnV0IHRoYXQNCj4gdGhpbmcgZG9lc24ndCBzdXBwb3J0IE1UUlJzIGluIHRo ZSBmaXJzdCBwbGFjZSwgcmlnaHQ/DQoNCkNvcnJlY3QuDQoNCj4gV2hpY2ggbWVhbnMsIGl0 IGRvZXNuJ3QgbmVlZCBkZWxheWVkIE1UUlIgaW5pdCBhbnl3YXkuDQo+IA0KPiBXaGljaCB3 b3VsZCB0aGVuIG1lYW4gdGhhdCB0aGlzIHdvdWxkIHNpbXBsaWZ5IHRoaXMgdWdseSBsb2dp YyBldmVuIG1vcmUuDQo+IA0KPiBPciBhbSBJIG1pc3NpbmcgYW4gYW5nbGU/DQoNClllczog Y3B1IGhvdHBsdWcuDQoNCg0KSnVlcmdlbg0K --------------QIMdqdxhoc6eaoR26OZpwXFP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------QIMdqdxhoc6eaoR26OZpwXFP-- --------------NAwU7mueCQZjm0bbNAQSgXHr-- --------------g4zPUaP42ub5sZKf9GZVZKaU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMyzRIFAwAAAAAACgkQsN6d1ii/Ey91 DQf+NKU30kayLU8o3/EyM8meTT/5wW0H5PhkarzslPfRDl0x1X9Rm6/y61s80LK9tEImIUe9eXae klpynQVpYHn2BMpbpAs1XzzESquyCRHdNUpuEnrt7bBnA6v0iHQZdCkd0ZyMveuo3BWlp8QDMPDt rPKv3gcTRpTFJsI2EZowJBrmbmkYCcmRE5jNCj1cYV0cWPpzVTHtH3gRkomgevdCN9voUiyLEFNs nwXz6gKOuA8L1dXGjHnokH3/5OAadXJ8MPeHK+TXbazMfDxEjNHdsxDu4CQ0hv+DJBNMdvXGjuMF tnw737lk707pkj8gwKKO5Zdg4o+aTBHNVN+mX3Enxw== =u8Td -----END PGP SIGNATURE----- --------------g4zPUaP42ub5sZKf9GZVZKaU-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:15:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:15:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412489.655825 (Exim 4.92) (envelope-from ) id 1od8Yl-0007ai-TI; Tue, 27 Sep 2022 11:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412489.655825; Tue, 27 Sep 2022 11:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yl-0007ab-Pz; Tue, 27 Sep 2022 11:15:31 +0000 Received: by outflank-mailman (input) for mailman id 412489; Tue, 27 Sep 2022 11:15:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yj-0007aQ-PX for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:15:29 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aeff83d9-3e55-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 13:15:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aeff83d9-3e55-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664277327; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eZ7SrsaIyeoFLsZJrY7oMN8LSSpDsPO9Cf8rssILgDI=; b=Txo65V2A3D+7Y2Xo2XHgKfR+fEoCtqs3mQklECOfCqFpfp1YQOdB6YQK d9yshQHAjM4Q4JM4JaPIfmvj/dA7PvWGcirC2Zz/vjroq7Gq9HsPh7hD9 OnCWZaXPrca0fmUjrXwk+PVIL+DdPURoQ7tNuqiCMqMkW/PWlJ0rIvl5O k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81413301 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:d9we8q1riDJlIyTXlfbD5axxkn2cJEfYwER7XKvMYLTBsI5bpzUOy zEZXT2EPfeKZmD9f9hxOdnl8xgCvZ7TyNZqTgU+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WlH5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVEy8BqMU4N7 MY2FypKUSKapPuUzYCSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8aBIw/mqG0gWP4cBVTqU6PpLpx6G/WpOB0+Oi0bIOOIYTTLSlTtlyIg kTj+mb3OQ81M4bB1xie1C6pu+CayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRhkegVvpFJ kcT+y5oqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj wLX2YOybdByjFGLYS6s0KqkgnCrAwYqNyg9VzYnVCkI0fC29enfkSnzZtpkFae0iPj8Fjfx3 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWG2TaD/LF7rVxBHkJPmqgPiAyS3G8zbq45lcbBO Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+S4i/D6+JP4ofOskZmOq7EMZGOiatM53FyhBwwcnTx 7/CGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+iOL2WZJgYe1aWLd4RrxmsfjsTcS82 4o3CvZmPD0ECbWiP3WKreb+7zkidBAGOHw/kOQPHsbrH+asMD1J5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:BF3GSqq63cgtHVHkoJU4qU4aV5oneYIsimQD101hICG8cqSj+f xG+85rsiMc6QxhPE3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakvDH4VmtJ uIHZIQNDSJNykZsfrH X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81413301" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v2 0/5] tools/ocaml: build/compatibility fixes with OCaml 5.0 for Xen 4.17 Date: Tue, 27 Sep 2022 12:14:56 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Changes to previous series: * removed Dune patches from this series for now (that requires more work to work with osstest on Debian oldstable that won't be ready in time for 4.17) * also updated xenctrl to work with no naked pointers mode (the only mode in OCaml 5.0) * changed alloc_custom to use '0' and '1' instead of '1' and '128' for values that are singletons anyway This can be tested with OCaml <5.0 (e.g. 4.13 or 4.14) with --enable-naked-pointer-checker to find instances where naked pointers are used or by code review. (Note that OCaml 5.0 won't have support for naked pointers at all, and thus it doesn't have the checker either) It would be good to get this included in Xen 4.17, especially that it changes the internal ABI of xenctrl bindings. Edwin Török (5): tools/ocaml/Makefile.rules: do not run ocamldep on distclean tools/ocaml/Makefile.rules: hide -include on *clean tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat tools/ocaml/libs/xc: OCaml 5.0 compatibility tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper tools/ocaml/Makefile.rules | 4 +-- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++++++++++++++-- tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- tools/ocaml/libs/xb/xs_ring_stubs.c | 2 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 11 +++---- 5 files changed, 37 insertions(+), 11 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:15:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:15:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412490.655829 (Exim 4.92) (envelope-from ) id 1od8Ym-0007e7-6k; Tue, 27 Sep 2022 11:15:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412490.655829; Tue, 27 Sep 2022 11:15:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Ym-0007dA-26; Tue, 27 Sep 2022 11:15:32 +0000 Received: by outflank-mailman (input) for mailman id 412490; Tue, 27 Sep 2022 11:15:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yk-0007aQ-BB for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:15:30 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b14c2f06-3e55-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 13:15:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b14c2f06-3e55-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664277329; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PA8SwB/EvHlNCm3CPVr6Dv8QaMWrEqHTBibfZeLpZrQ=; b=bg2v8w06Z0DCpgbYABuDdrN5x8S35H3y3z/ndKp6nVIPSuEQ0asw2hB3 5wO/N6SvYh/XWoNB6sTZfJ8OLwJ7ZvC5FjURV09AGLcrlpXgcnpmKq+Cz VslvjNtkxbBA6eBHybwcDAz9pNeRjqNhAZPwhJBW8/+8wvnm+iVqrMLou E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81413305 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:9abglqpLPTlzFuHWH9Dlo4pqBOheBmJnZRIvgKrLsJaIsI4StFCzt garIBmGOPqMajH0f94kbd/kox4BvJPTy4U2TVNorS49H3gQoJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 8BfeAxObjW6u/Owy7KwE+BqtM8xFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAi3XhcjsetFWPoqkf6GnP1g1hlrPqNbI5f/TaHJkMxR3A+ woq+UyhPxUxKO7DzgOE81f83eTvuz3jQqsrQejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 0Ad5CcGt6U5802vCN7nUHWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3PLaXhRzi AXPxYmwQ2Uy7vvFEhpx64t4sxusBW9FESwCQBY4XA0O49K6qYcBhQD2G4ML/LGOsvX5HjT5w javpSc4hqkOgcNj65hX7WwrkBr3+MGXE1ddChH/Gzv8s1gnPNLNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJrWzFF52LJ9o4DNRCyKBBba45lcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIQSOMEuKV7XrXk/DaJ144wKuBdErE3CE c3DLZbE4YgyUMyLMwZat89CiOR2l0jSNEvYRIzhzgTP7IdykEW9EO5dWGZim8hjs8toVi2Jr IsEXyZLoj0DONDDjt7/qtdLcQ1WcCRT6FKfg5U/S9Nv6zFOQAkJY8I9C5t4E2C5t8y5Ttv1w 0w= IronPort-HdrOrdr: A9a23:vuTbzqMvuyJ0fcBcTvujsMiBIKoaSvp037Eqv3oRdfUzSL3hqy nOpoVj6faaskdzZJhNo7+90ey7MBfhHP1OkO8s1NWZLWvbUQKTRekIh+aP/9SjIVyYygc079 YaT0EUMr3N5DZB4/oSmDPIduod/A== X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81413305" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v2 5/5] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper Date: Tue, 27 Sep 2022 12:15:01 +0100 Message-ID: <58b6cb7c02d8b06d90dd419727572abb0cd41d75.1664276827.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is not strictly necessary since it is essentially a no-op currently: a cast to void* and value*, even in OCaml 5.0. However it does make it clearer that what we have here is not a regular OCaml value, but one allocated with Abstract_tag or Custom_tag, and follows the example from the manual more closely: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head It also makes it clearer that these modules have been reviewed for compat with OCaml 5.0. No functional change. Signed-off-by: Edwin Török --- tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- tools/ocaml/libs/xb/xs_ring_stubs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/mmap/xenmmap_stubs.c b/tools/ocaml/libs/mmap/xenmmap_stubs.c index e2ce088e25..141dedb78c 100644 --- a/tools/ocaml/libs/mmap/xenmmap_stubs.c +++ b/tools/ocaml/libs/mmap/xenmmap_stubs.c @@ -28,7 +28,7 @@ #include #include -#define Intf_val(a) ((struct mmap_interface *) a) +#define Intf_val(a) ((struct mmap_interface *) Data_abstract_val(a)) static int mmap_interface_init(struct mmap_interface *intf, int fd, int pflag, int mflag, diff --git a/tools/ocaml/libs/xb/xs_ring_stubs.c b/tools/ocaml/libs/xb/xs_ring_stubs.c index 7a91fdee75..cc9114029f 100644 --- a/tools/ocaml/libs/xb/xs_ring_stubs.c +++ b/tools/ocaml/libs/xb/xs_ring_stubs.c @@ -35,7 +35,7 @@ #include #include "mmap_stubs.h" -#define GET_C_STRUCT(a) ((struct mmap_interface *) a) +#define GET_C_STRUCT(a) ((struct mmap_interface *) Data_abstract_val(a)) /* * Bytes_val has been introduced by Ocaml 4.06.1. So define our own version -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:15:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:15:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412491.655847 (Exim 4.92) (envelope-from ) id 1od8Yz-0008Cf-E2; Tue, 27 Sep 2022 11:15:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412491.655847; Tue, 27 Sep 2022 11:15:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yz-0008CY-BA; Tue, 27 Sep 2022 11:15:45 +0000 Received: by outflank-mailman (input) for mailman id 412491; Tue, 27 Sep 2022 11:15:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yy-0008Aw-Dw for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:15:44 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b895e39a-3e55-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 13:15:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b895e39a-3e55-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664277342; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FDvDgX7AxBcpgWMVzYo5l6lVSFhVUQDnFTbkDG8AAP4=; b=VfzeFkjrp58JMhRmLOKVq1oOdeYS1HPmeik4NCDGNQYoYbECgkH0sAG4 VvzOkTS6VZUF8/Hm2OnvO4DBU7jD/oUIZxhbDNDzS8R07OaD6+H6dY0Fe N1FzxTPmoxfkyq0HT5aPrGTqdLYdKjIkD5WrlgKWB9HfXwH8aoSb2JcM1 M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83941730 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:OuIcr643ljqtc0Opum9JfQxRtEfHchMFZxGqfqrLsTDasY5as4F+v jRKXWzQP/uOMzPzLt53YYu2o0tT7ZODzNUwQVFr+yg9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPYwP9TlK6q4mlA7wZhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5FCkNSz 9xBdwwuLQq7vaWd7KmKVc9V05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLozkPmpgD/jdCdfq3qepLYt4niVxwt0uFToGIqOK4DTGp4N9qqej m7d7Vb9GzsYD4W86nmitWuvnv6VvyyuDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWV9tBJ mQO9yEprKx081akJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2w02FGIdZ6D3oWfjy+IGXFKEUxBfxc+CiAp+Oj8hrhm23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1R/HNFBz3oRZPmLy8BxkhTHqFyu5eJVfUj Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CKyON4UTM8ggLF7vEMRSiam4gAjQfLUEy/lja f93j+71ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjG8vhT6pLHPSb9dFvwGAHRBgzPxP/b/V69H hc2H5fi9iizp8WlO3GLrNJOcTjn7xETXPjLliCeTcbbSiIOJY3rI6W5LW8JE2C9o5loqw== IronPort-HdrOrdr: A9a23:Up+ZiK/jWUvzldOMOFtuk+DiI+orL9Y04lQ7vn2YSXRuE/Bw8P re5MjztCWE8Qr5N0tQ+uxoVJPufZqYz+8Q3WBzB8bFYOCFghrLEGgK1+KLqFeMdxEWtNQtsp uIG5IOc+EYZmIbsS+V2meF+q4bsby6zJw= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="83941730" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v2 3/5] tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat Date: Tue, 27 Sep 2022 12:14:59 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add a finalizer on the event channel value, so that it calls `xenevtchn_close` when the value would be GCed. In practice oxenstored seems to be the only user of this, and it creates a single global event channel only, but freeing this could still be useful when run with OCAMLRUNPARAM=c The code was previously casting a C pointer to an OCaml value, which should be avoided: OCaml 5.0 won't support it. (all "naked" C pointers must be wrapped inside an OCaml value, either an Abstract tag, or Nativeint, see the manual https://ocaml.org/manual/intfc.html#ss:c-outside-head) Signed-off-by: Edwin Török Acked-by: Christian Lindig --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index f889a7a2e4..67af116377 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -33,7 +33,30 @@ #include #include -#define _H(__h) ((xenevtchn_handle *)(__h)) +/* We want to close the event channel when it is no longer in use, + which can only be done safely with a finalizer. + Event channels are typically long lived, so we don't need tighter control over resource deallocation. + Use a custom block +*/ + +/* Access the xenevtchn_t* part of the OCaml custom block */ +#define _H(__h) (*((xenevtchn_handle**)Data_custom_val(__h))) + +static void stub_evtchn_finalize(value v) +{ + /* docs say to not use any CAMLparam* macros here */ + xenevtchn_close(_H(v)); +} + +static struct custom_operations xenevtchn_ops = { + "xenevtchn", + stub_evtchn_finalize, + custom_compare_default, /* raises Failure, cannot compare */ + custom_hash_default, /* ignored */ + custom_serialize_default, /* raises Failure, can't serialize */ + custom_deserialize_default, /* raises Failure, can't deserialize */ + custom_compare_ext_default /* raises Failure */ +}; CAMLprim value stub_eventchn_init(void) { @@ -48,7 +71,9 @@ CAMLprim value stub_eventchn_init(void) if (xce == NULL) caml_failwith("open failed"); - result = (value)xce; + /* contains file descriptors, trigger full GC at least every 128 allocations */ + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + _H(result) = xce; CAMLreturn(result); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:15:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412492.655858 (Exim 4.92) (envelope-from ) id 1od8Z0-0008UU-Nm; Tue, 27 Sep 2022 11:15:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412492.655858; Tue, 27 Sep 2022 11:15:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Z0-0008UN-K8; Tue, 27 Sep 2022 11:15:46 +0000 Received: by outflank-mailman (input) for mailman id 412492; Tue, 27 Sep 2022 11:15:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yy-0008Aw-VC for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:15:44 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba0b8664-3e55-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 13:15:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba0b8664-3e55-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664277343; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=i9j+DS3NCVDB/s2QnXaos+vP3Fy3tX4CBUXsBsSBVAM=; b=HBO9s75+laZrXv27uVVi1ge38CVQaNrjuB6O82F7/0FOVov7pHRTQ6ak eBZA2OtEdZhHGVOgAZDk14emjf5UilVdiXifM4MJTe+8N5y0hDamxb9t7 22YZc1JMv/h2+dEP9H/GNGa3pMTyxdkxXkKcwvRGlp5OJI6SsUp2lcD0u Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83941731 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:8CpxNKhq1oOJ9R5TrLC4RYibX161HxAKZh0ujC45NGQN5FlHY01je htvXmiDbP+CYTake98jPNuy9R9TsJ/WyddrSwduqH1nRCkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UgHUMja4mtC5ARvP68T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KURE+ f8ALi0KUhG43tm62Y2DEPRKxf12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tOqkmHj5NSFfslWWjaE2/3LS3Ep6172F3N/9KofbGZwKxR/wS mTuzXrSRTolbvGkyxG4+1Osp77yxCz/YddHfFG/3qEz2wDCroAJMzUJUXOrrP//jVSxM/pTI lIZ0jAjpq8z8AqsVNaVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QbWNQeHGJwk AXTxpWwWGIp4Ob9pW+hGqm8iDm+OjATMGg+ZBRddgcc3OG5vadwt0eaJjp8K5KdgtrwEDD25 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8N5n9hO0yT5FWy13N2ZDBgBDyr8UWW1C HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66KMoAXPcUgJF7frUmCgHJ8OEiy+HXAbIllY cvLGSpSJS9y5VtbIMqeGL5GjO5DKtEWzmLPX5HrpymaPU6lTCfMEd843K6mNL9RAFWs/FqIq L6y9qKil31ibQEJSnKOqdJOcQ1WRZX5bLivw/Fqmie4ClIOMAkc5zX5m9vNp6QNc3xpq9r1 IronPort-HdrOrdr: A9a23:/1VZrqpYxodFXY5py2WofDAaV5oTeYIsimQD101hICG8cqSj+f xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="83941731" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v2 2/5] tools/ocaml/Makefile.rules: hide -include on *clean Date: Tue, 27 Sep 2022 12:14:58 +0100 Message-ID: <074e66ae5f53522361ff0fdae105a3b7f70de0d4.1664276827.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Edwin Török --- tools/ocaml/Makefile.rules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules index e0b9de34e4..39ac260a4d 100644 --- a/tools/ocaml/Makefile.rules +++ b/tools/ocaml/Makefile.rules @@ -44,10 +44,8 @@ META: META.in ALL_OCAML_OBJ_SOURCES=$(addsuffix .ml, $(ALL_OCAML_OBJS)) -ifeq (,$(findstring clean,$(MAKECMDGOALS))) .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(OCAML_TOPLEVEL)/Makefile.rules $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli $o,MLDEP,) -endif clean: $(CLEAN_HOOKS) $(Q)rm -f .*.d *.o *.so *.a *.cmo *.cmi *.cma *.cmx *.cmxa *.annot *.spot *.spit $(LIBS) $(PROGRAMS) $(GENERATED_FILES) .ocamldep.make META @@ -94,7 +92,9 @@ define C_PROGRAM_template $(call quiet-command, $(CC) $(LDFLAGS) -o $$@ $$+,BIN,$$@) endef +ifeq (,$(findstring clean,$(MAKECMDGOALS))) -include .ocamldep.make +endif $(foreach lib,$(OCAML_LIBRARY),$(eval $(call OCAML_LIBRARY_template,$(lib)))) $(foreach lib,$(OCAML_NOC_LIBRARY),$(eval $(call OCAML_NOC_LIBRARY_template,$(lib)))) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412493.655862 (Exim 4.92) (envelope-from ) id 1od8Z1-00005R-3J; Tue, 27 Sep 2022 11:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412493.655862; Tue, 27 Sep 2022 11:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Z0-0008WS-SR; Tue, 27 Sep 2022 11:15:46 +0000 Received: by outflank-mailman (input) for mailman id 412493; Tue, 27 Sep 2022 11:15:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Yz-0008Aw-Jp for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:15:45 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9793d31-3e55-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 13:15:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9793d31-3e55-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664277343; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FqKJptP8xI/gmJSM9NBmTiySQIrCF/7zJnDRHUkHENk=; b=Xh0EI/pzQxXFO2fd9vtR1wkPdePf/aZv5ZblcUfEiqxy7QgGgN2jyhOL pZINNqoCHNBYNerd1br7FS1GDffQqESDgJ68Y1oLOWZBNVW3iv0NI7vFO Q4Y8MvasytlBAc9eWu5oF5zYx6GHgAaqQV2AUrAzPA/DaFgeeOQ9QgpVw k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80557651 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:p5GegKhmwqdAvJVQN7shVlGpX161HxAKZh0ujC45NGQN5FlHY01je htvUGGDPq6PNGuheN0kbI7i/UoG68XXx4c2HAFoq3hgEC0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UgHUMja4mtC5ARvP68T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUBxp M0WFC4yVDKOm72Y0KyQV+1voP12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tOqkmHj5NSFfslWWjaE2/3LS3Ep6172F3N/9KoTXGJoLwx/wS mTu3z/TBEAYDuOl2AXe4HW02M7mwXKhcddHfFG/3qEz2wDCroAJMzUJUXOrrP//jVSxM/pTI lIZ0jAjpq8z8AqsVNaVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QbWNQeHGJwk AXTxpWwWGIp4Ob9pW+hGqm8jAzjCCYpM1A4RyIYEiUV/fL+pIIVt0eaJjp8K5KdgtrwEDD25 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8N5n9hO0yT5FWy13N2ZDBgBDyr8UWW1C HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66KMoAXPcUgJF7frUmCgHJ8OEiy+HXAbIllY cvLGSpSJS9y5VtbIMqeGL5GjO5DKtEWzmLPX5HrpymaPU6lTCfMEd843K6mNL9RAFWs/FqIq L6y9qKil31ibQEJSnKOqdJOcQ1WRZX5bLivw/Fqmie4ClIOMAkc5zX5mNvNp6QNc3xpq9r1 IronPort-HdrOrdr: A9a23:hQSZ8KEbDG6WbLAOpLqE0seALOsnbusQ8zAXP0AYc31om6uj5r iTdZUgpGbJYVkqKRIdcLy7V5VoBEmskaKdgrNhW4tKPjOW2ldARbsKheCJrlHd8m/Fh4lgPM 9bAtND4bbLbWSS4/yV3ODBKadE/OW6 X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="80557651" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v2 1/5] tools/ocaml/Makefile.rules: do not run ocamldep on distclean Date: Tue, 27 Sep 2022 12:14:57 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Edwin Török --- tools/ocaml/Makefile.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules index 0d3c6ac839..e0b9de34e4 100644 --- a/tools/ocaml/Makefile.rules +++ b/tools/ocaml/Makefile.rules @@ -44,7 +44,7 @@ META: META.in ALL_OCAML_OBJ_SOURCES=$(addsuffix .ml, $(ALL_OCAML_OBJS)) -ifneq ($(MAKECMDGOALS),clean) +ifeq (,$(findstring clean,$(MAKECMDGOALS))) .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(OCAML_TOPLEVEL)/Makefile.rules $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli $o,MLDEP,) endif -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412494.655868 (Exim 4.92) (envelope-from ) id 1od8Z1-0000IT-IP; Tue, 27 Sep 2022 11:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412494.655868; Tue, 27 Sep 2022 11:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Z1-0000FD-E1; Tue, 27 Sep 2022 11:15:47 +0000 Received: by outflank-mailman (input) for mailman id 412494; Tue, 27 Sep 2022 11:15:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8Z0-0008Aw-Jz for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:15:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9910872-3e55-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 13:15:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9910872-3e55-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664277344; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EI190skp2HLPj9zpnRLco5ZASbbq/qUufYWOpErCNvM=; b=GVNIQf3I0LM+eqNrps+byviqavEBSGaZtrP0knvd7hutPQmjHELU5OjK UKDdMxydmLrmyjKbQLfIvucP6R4XrGCRzEyVpayA/2TFYKBpiykVKyRmf RDdTfT/sHK2mv080DNDV429XjXDE1WAIFIfJU8zgKZDCxLtRQh7yv1Agn 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81083781 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:36/VN6y4nGSVEvk/mE96t+dIxirEfRIJ4+MujC+fZmUNrF6WrkUBy GsbD2/UbqmLMGD0eohyboiwpEwE6JKBz941HQRp+CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFsMpvlDs15K6o4GJC4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw48FwDDxR1 94jAjFKV0Czh+asz7XqVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/BZ4gneHumn7ldD5wo1OJv6snpWPUyWSd1ZC9aYKFIYPaHK25mG6qr 3jIpGnyXisAC/GN7B2D+WCHoO7AyHaTtIU6S+Tjq68CbEeo7nMXIA0bUx28u/bRokK3Rd93M UEf/Ssq668o+ySDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/R/6pVwH2Zzk AbUwZW5XlSDrYF5V1qE0bCZ8CyQGxM/LCg7NR8ESREK5Ij89dRbYg30cv5vF6u8j9vQED72w iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZRPtbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N/02wYH83oJrW7FF5ufkWd4v1lDyL9BaJpsRNMQS Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4q5DKmLM4seM8AgHONiwM2JTRH44owQuBJ0zfFX1 WmzKK5A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eK0XOy+PiOPGDEN5vJ9fbzNimMhls/7fyOgUm v4DX/a3J+J3C7SmPnSLrNJ7wJJjBSFTOK0aYvd/LoarSjeK0kl7YxMN6dvNo7BYopk= IronPort-HdrOrdr: A9a23://nxoaiO/RlwLrJne6wMXW2sEnBQXuIji2hC6mlwRA09TySZ// rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81083781" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Date: Tue, 27 Sep 2022 12:15:00 +0100 Message-ID: <7b88cbda20e068bbce1c5dfb0a18af3f4e4b6865.1664276827.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Follow the manual to avoid naked pointers: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head No functional change, except on OCaml 5.0 where it is a bugfix. Signed-off-by: Edwin Török --- tools/ocaml/libs/xc/xenctrl_stubs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 19335bdf45..7ff4e00314 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -37,7 +37,7 @@ #include "mmap_stubs.h" -#define _H(__h) ((xc_interface *)(__h)) +#define _H(__h) *((xc_interface **) Data_abstract_val(__h)) #define _D(__d) ((uint32_t)Int_val(__d)) #ifndef Val_none @@ -70,14 +70,15 @@ static void Noreturn failwith_xc(xc_interface *xch) CAMLprim value stub_xc_interface_open(void) { CAMLparam0(); - xc_interface *xch; + CAMLlocal1(result); + result = caml_alloc(1, Abstract_tag); /* Don't assert XC_OPENFLAG_NON_REENTRANT because these bindings * do not prevent re-entrancy to libxc */ - xch = xc_interface_open(NULL, NULL, 0); - if (xch == NULL) + _H(result) = xc_interface_open(NULL, NULL, 0); + if (_H(result) == NULL) failwith_xc(NULL); - CAMLreturn((value)xch); + CAMLreturn(result); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:19:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412528.655891 (Exim 4.92) (envelope-from ) id 1od8ct-0002i5-4r; Tue, 27 Sep 2022 11:19:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412528.655891; Tue, 27 Sep 2022 11:19:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8ct-0002hy-1g; Tue, 27 Sep 2022 11:19:47 +0000 Received: by outflank-mailman (input) for mailman id 412528; Tue, 27 Sep 2022 11:19:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8cr-0002hs-OX for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:19:45 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49732cfc-3e56-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 13:19:44 +0200 (CEST) Received: from zn.tnic (p200300ea9733e757329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e757:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B70F61EC058B; Tue, 27 Sep 2022 13:19:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49732cfc-3e56-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664277579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sh92KicTDh4caqpKkqA808K5SVahDD/Q8fFa9qaLWr4=; b=NgY0WzvQkkzu5MW68ZDDIcuV4ZDbsPWHe6Ea6G6DMmWyYU9vEc9VIxat/9KrpbSzohoO4T I890t20ZAuG8NWX0e5bK82z7sN0jhVlFGhMPVsNeuLbkOhNcCTcI1IH2WjJPtBVx56jzmL C+FFp+HdbIyl//i7IKrn1bjLTVyW1Gc= Date: Tue, 27 Sep 2022 13:19:36 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Sep 27, 2022 at 12:14:42PM +0200, Juergen Gross wrote: > Yes: cpu hotplug. You might need to elaborate here. Because I see mtrr_ap_init() on the AP hotplug path: native_cpu_up-> do_boot_cpu-> start_secondary-> smp_callin-> smp_store_cpu_info-> identify_secondary_cpu-> mtrr_ap_init Which then means that we could check in mtrr_ap_init() if we're on the hotplug path and still get rid of that stupid bool... Close? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Sep 27 11:25:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 11:25:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412539.655902 (Exim 4.92) (envelope-from ) id 1od8ik-00049N-Pc; Tue, 27 Sep 2022 11:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412539.655902; Tue, 27 Sep 2022 11:25:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8ik-00049G-Mo; Tue, 27 Sep 2022 11:25:50 +0000 Received: by outflank-mailman (input) for mailman id 412539; Tue, 27 Sep 2022 11:25:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od8ij-00049A-Ll for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 11:25:49 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22b04a5b-3e57-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 13:25:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F2B2921EBB; Tue, 27 Sep 2022 11:25:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B65C2139BE; Tue, 27 Sep 2022 11:25:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j2u3KrvdMmPFaQAAMHmgww (envelope-from ); Tue, 27 Sep 2022 11:25:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22b04a5b-3e57-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664277948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CLdUTJgB2rz6NNwqcGWdVzBdOEiEiTP+cBziZBhqujo=; b=cH5dv9AAU9AooBEJn/AjJupS7KVpvPnp7Tjp3FSuSxAyjO23RXWoDcY8FgrcTMPf/THsE6 A9COLRUmRpOdVJ5HkCWD3hEbDpSShs1Vwry0+0vmM2cAucsFxBfuOaEVhLTwxyjpzqLrUa 2a5Epjp3Zcls0CVUjhA9VZ47U6rXmf0= Message-ID: Date: Tue, 27 Sep 2022 13:25:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------rHSWBkO02lpZL9e2SytxzLgG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rHSWBkO02lpZL9e2SytxzLgG Content-Type: multipart/mixed; boundary="------------ilVo6L043vcUtxWg781LDkzZ"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> In-Reply-To: --------------ilVo6L043vcUtxWg781LDkzZ Content-Type: multipart/mixed; boundary="------------1Qbc7N2y7imkPKepymKipfTL" --------------1Qbc7N2y7imkPKepymKipfTL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDkuMjIgMTM6MTksIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVHVlLCBT ZXAgMjcsIDIwMjIgYXQgMTI6MTQ6NDJQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFllczogY3B1IGhvdHBsdWcuDQo+IA0KPiBZb3UgbWlnaHQgbmVlZCB0byBlbGFib3Jh dGUgaGVyZS4NCj4gDQo+IEJlY2F1c2UgSSBzZWUgbXRycl9hcF9pbml0KCkgb24gdGhlIEFQ IGhvdHBsdWcgcGF0aDoNCj4gDQo+IG5hdGl2ZV9jcHVfdXAtPg0KPiBkb19ib290X2NwdS0+ DQo+IHN0YXJ0X3NlY29uZGFyeS0+DQo+IHNtcF9jYWxsaW4tPg0KPiBzbXBfc3RvcmVfY3B1 X2luZm8tPg0KPiBpZGVudGlmeV9zZWNvbmRhcnlfY3B1LT4NCj4gbXRycl9hcF9pbml0DQo+ IA0KPiBXaGljaCB0aGVuIG1lYW5zIHRoYXQgd2UgY291bGQgY2hlY2sgaW4gbXRycl9hcF9p bml0KCkgaWYgd2UncmUgb24gdGhlDQo+IGhvdHBsdWcgcGF0aCBhbmQgc3RpbGwgZ2V0IHJp ZCBvZiB0aGF0IHN0dXBpZCBib29sLi4uDQo+IA0KPiBDbG9zZT8NCj4gDQoNCllvdSBtZWFu IGJ5IHJlcGxhY2luZyBpdCB3aXRoICIoc3lzdGVtX3N0YXRlICE9IFNZU1RFTV9SVU5OSU5H KSIgPw0KDQoNCkp1ZXJnZW4NCg== --------------1Qbc7N2y7imkPKepymKipfTL Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1Qbc7N2y7imkPKepymKipfTL-- --------------ilVo6L043vcUtxWg781LDkzZ-- --------------rHSWBkO02lpZL9e2SytxzLgG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMy3bsFAwAAAAAACgkQsN6d1ii/Ey++ mwf8DqSDf9Hp8o4Aq2cHVCDHlbY/K6LYOjdyuKammEQK141fnweYFhLI+/3b4b5BsW6qcpPrCjIU JoAMXTG1Fz8GlC0D3sl6UxEeMnCEY/uBhW/qiCUG9VHklNUi2LDYKcmYeXatvE+fRcm3ml3hvk69 +Rjlq/FrOH9Mgaq49syein2GCy9XXIeREXmeRRA7GtbIiIAmvgbZ8fi/wKkOryV/1J8HB0ZGOOLz NAjTdWp7O+vEBSkYkjVvraXdDMzYZWe6v85V+b8X0Kd9dx9U0IejDVbVS9BsVZnS5UX7yDKW6Mk8 7aJ8YFxGXrX2H/yPri481WP1H7ZCKmGYuVL+WcxaHA== =vLGq -----END PGP SIGNATURE----- --------------rHSWBkO02lpZL9e2SytxzLgG-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 12:14:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 12:14:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412548.655913 (Exim 4.92) (envelope-from ) id 1od9TG-0000sg-I3; Tue, 27 Sep 2022 12:13:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412548.655913; Tue, 27 Sep 2022 12:13:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od9TG-0000sZ-FI; Tue, 27 Sep 2022 12:13:54 +0000 Received: by outflank-mailman (input) for mailman id 412548; Tue, 27 Sep 2022 12:13:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od9TF-0000sT-Lo for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 12:13:53 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9119d62-3e5d-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 14:13:52 +0200 (CEST) Received: from zn.tnic (p200300ea9733e757329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e757:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E2EF31EC059D; Tue, 27 Sep 2022 14:13:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9119d62-3e5d-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664280827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Ah2YylUqJ6ePHReTwtNwsklHRpA9yYcUn3VnDUrl9G8=; b=faXXp2C2YqbilpcwkRScIXZgbOjDpTReMjQkNlUZfceUKISvMlNsTGBbvNetCJw93XSF6c l3A/svhkj02teNBCzB10lRJuCpR/yiPAb9ZOyj5I8lDCRy1pDbcoT7AqAffW62FOzejYjF I81SOtQYZk4iBObhVgbTldjiWT88jBM= Date: Tue, 27 Sep 2022 14:13:40 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Sep 27, 2022 at 01:25:47PM +0200, Juergen Gross wrote: > You mean by replacing it with "(system_state != SYSTEM_RUNNING)" ? Right, or maybe even something more elegant. I've been meaning to ask tglx about it as I needed it for the microcode loader too. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Sep 27 12:21:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 12:21:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412553.655923 (Exim 4.92) (envelope-from ) id 1od9aT-0002K3-9m; Tue, 27 Sep 2022 12:21:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412553.655923; Tue, 27 Sep 2022 12:21:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od9aT-0002Jw-6q; Tue, 27 Sep 2022 12:21:21 +0000 Received: by outflank-mailman (input) for mailman id 412553; Tue, 27 Sep 2022 12:21:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1od9aR-0002Jq-Lw for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 12:21:19 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e362b505-3e5e-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 14:21:18 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C00D81FA91; Tue, 27 Sep 2022 12:21:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 82518139B3; Tue, 27 Sep 2022 12:21:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CIoaHr3qMmMmBQAAMHmgww (envelope-from ); Tue, 27 Sep 2022 12:21:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e362b505-3e5e-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664281277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WKy3/moRIdFAMGNhek51h7yqMFijHHtClPF21SoHMKs=; b=a58T2mSXRLCVNqcJ36AU2wUVXLjUtH/1/cyaf/STlSzuTqHdH//6202Qw+PKVDoxYKSgZl x9/cCeoZByLSjVJQgn+BfH8MkfAtYm0THS70kZJ+gSLDbGxgSiRsTeGG31+8j6rK6VsjJ7 py1g6JOiYJ0dk3ClnhX7qTxMRDMICxk= Message-ID: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> Date: Tue, 27 Sep 2022 14:21:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yYCrDFoMk0gOvmlfzVAQh1tI" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yYCrDFoMk0gOvmlfzVAQh1tI Content-Type: multipart/mixed; boundary="------------NR0JWcGWJyz81n5HDCe0mI11"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> In-Reply-To: --------------NR0JWcGWJyz81n5HDCe0mI11 Content-Type: multipart/mixed; boundary="------------6QxzthD9fEp8A1HWmnFw8r2u" --------------6QxzthD9fEp8A1HWmnFw8r2u Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDkuMjIgMTQ6MTMsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVHVlLCBT ZXAgMjcsIDIwMjIgYXQgMDE6MjU6NDdQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFlvdSBtZWFuIGJ5IHJlcGxhY2luZyBpdCB3aXRoICIoc3lzdGVtX3N0YXRlICE9IFNZ U1RFTV9SVU5OSU5HKSIgPw0KPiANCj4gUmlnaHQsIG9yIG1heWJlIGV2ZW4gc29tZXRoaW5n IG1vcmUgZWxlZ2FudC4gSSd2ZSBiZWVuIG1lYW5pbmcgdG8gYXNrDQo+IHRnbHggYWJvdXQg aXQgYXMgSSBuZWVkZWQgaXQgZm9yIHRoZSBtaWNyb2NvZGUgbG9hZGVyIHRvby4NCg0KU28g cmVwbGFjaW5nIHRoZSBib29sIHdpdGggIihzeXN0ZW1fc3RhdGUgIT0gU1lTVEVNX1JVTk5J TkcpIiBpcyBmaW5lDQp3aXRoIHlvdSByaWdodCBub3c/IFdlIGNhbiBsYXRlciBzd2l0Y2gg dGhhdCB0byB0aGUgIm1vcmUgZWxlZ2FudCINCnNvbHV0aW9uIHdoZW4gaXQgc2hvd3MgdXAu DQoNCg0KSnVlcmdlbg0KDQo= --------------6QxzthD9fEp8A1HWmnFw8r2u Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6QxzthD9fEp8A1HWmnFw8r2u-- --------------NR0JWcGWJyz81n5HDCe0mI11-- --------------yYCrDFoMk0gOvmlfzVAQh1tI Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMy6r0FAwAAAAAACgkQsN6d1ii/Ey/P lAf9GthN38mAfTvZKcMI3RiXtTERbG/QBGU61+A3H0u30HfnLF6XZRTWxdbIDm7lLxIVSLRn7E8D RXw+AUaweXh8hGR8FDvX/lfbm0o2FctODWDcZKWWfcbWuxPQDvX5/4tag/+ux3jAn/QAg6l7hlvg o8nd5HZ/de1eA+b6fMTm0Oemwk6hYOStfyA0jdtIdEj3myvGB33sSC7ThFPeTaYS1kHkjK+02llY AH9EnJr+7d3HvGVsMH7gr3l2i4Cjp5LgjrJhIcvyxmrXRd6iDxLVyhDvH1y9GTzLiKiXB2j//Lp8 ErxoYPbnkaQ6dBunPGP3n+Ornqz+A9EKONAw7BLOsw== =A11H -----END PGP SIGNATURE----- --------------yYCrDFoMk0gOvmlfzVAQh1tI-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 13:15:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 13:15:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412562.655939 (Exim 4.92) (envelope-from ) id 1odAQu-0007U3-BJ; Tue, 27 Sep 2022 13:15:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412562.655939; Tue, 27 Sep 2022 13:15:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAQu-0007Tw-8Z; Tue, 27 Sep 2022 13:15:32 +0000 Received: by outflank-mailman (input) for mailman id 412562; Tue, 27 Sep 2022 13:15:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAQs-0007Tq-Dp for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 13:15:30 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 753ce9d5-3e66-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 15:15:29 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id r18so20571396eja.11 for ; Tue, 27 Sep 2022 06:15:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 753ce9d5-3e66-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=9veZoOWQRZ+PH+Nkd5KG1hCn+KNodqzcpmqxxFh+XYQ=; b=V5IqUljfDK/x48H7ZVpwrZhZ9w69zyONo2K4GfuOfDlaQZ6FlAlFlC16ayBmKvzSxV CV0Ag9P+8y4+wad5UYteIb+4jfqTGGmp3S25mwyS2ofNByFK2p3m3hz+E4P82d0rTsQ3 zK5PKLOVntGJmxLbmQhrziTpWYPdGjZ+dnmVwKcXkE7IEte5QIH+ZdjRtstaX8BNQNhT kkIeacpMTmATCS+6pSjwFssL68xYiVtpC2dd+bDKfV689F4xORjxlJA7VlQ5Q83/ajFV CAemEa7Bmpznn+mofXVX8Jev0LOfsMwstvxC+g4n0/m2TDPbGkNHPA4Q4e4JLYf6e8z4 qMmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=9veZoOWQRZ+PH+Nkd5KG1hCn+KNodqzcpmqxxFh+XYQ=; b=UkqBCrTN/coR7XlYwxhyD/5/S0AycOZEaFZvEeodRzi17k5skq2ejrHL4TvKPJNa+8 pvDscSeGFy2DKMExL9PBOPUm+Os4izMThyDSYmVV/782RXcP57p6EOfoAks+u6BPv03u TC6nl7c2kJu1VBjKngXnTCg2bo3xbns8Hl30LE8KK60HUL+SIpk/8fxKBq8jJC5/O2Xk HcM6Pbktu8oI5ne15P2TPtOEbB7egd9FR0Z8PiXs4sAzfiVjJsjObt5AvecQSKnKQCTS iEjr3xNZHa9HjH2aDnuju+nXcLxdvT4SJ7Poht12pfJRSr6eFtZLJ/fgU6U0OKWZqjA5 hZng== X-Gm-Message-State: ACrzQf0qrE6yh2d7RKdZi2UIFnmCY6jMRUBh4v9oNdPEr4oEvkaIrb+7 P36vJfWHHPFnGiMQKPrH8nZaWWHfhS7aWQCXEOA= X-Google-Smtp-Source: AMsMyM4Tkkfx88Q5Bz6ENmEJrN8n6eocl5Jf2H5SZGnxaeXXVbN9FHKMwg9O+fGO7KCn9lnFpIuN6qOyaflncDtvnU0= X-Received: by 2002:a17:907:e9e:b0:783:1a8c:9198 with SMTP id ho30-20020a1709070e9e00b007831a8c9198mr12647561ejc.202.1664284528942; Tue, 27 Sep 2022 06:15:28 -0700 (PDT) MIME-Version: 1.0 References: <20220905135019.3749982-1-marmarek@invisiblethingslab.com> <20220905135019.3749982-2-marmarek@invisiblethingslab.com> In-Reply-To: From: Jason Andryuk Date: Tue, 27 Sep 2022 09:15:16 -0400 Message-ID: Subject: Re: [PATCH 2/2] tools/libxl: enable in-band reconnect marker for stubdom QMP proxy To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: xen-devel , Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 6, 2022 at 8:45 AM Jason Andryuk wrote: > > On Mon, Sep 5, 2022 at 9:50 AM Marek Marczykowski-G=C3=B3recki > wrote: > > > > This enables stubdom reliably detect when it needs to reconnect QMP > > socket. It is critical, as otherwise QEMU will not send its handshake, > > and so libxl will timeout while waiting on one. When it happens during > > domain startup, it can result in error like this: > > > > libxl: libxl_pci.c:1772:device_pci_add_done: Domain 3:libxl__device_pci= _add failed for PCI device 0:0:14.0 (rc -9) > > libxl: libxl_create.c:1904:domcreate_attach_devices: Domain 3:unable to= add pci devices > > > > See vchan-socket-proxy commit message for details about this reconnect > > corner case. > > > > Stubdomain side needs to use --reconnect-marker=3D1 option too. > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > Reviewed-by: Jason Andryuk Also Tested-by: Jason Andryuk From xen-devel-bounces@lists.xenproject.org Tue Sep 27 13:39:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 13:39:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412607.655967 (Exim 4.92) (envelope-from ) id 1odAoI-0002eX-LX; Tue, 27 Sep 2022 13:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412607.655967; Tue, 27 Sep 2022 13:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAoI-0002eQ-Is; Tue, 27 Sep 2022 13:39:42 +0000 Received: by outflank-mailman (input) for mailman id 412607; Tue, 27 Sep 2022 13:39:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAoH-0002eE-Ia; Tue, 27 Sep 2022 13:39:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAoH-00039v-FG; Tue, 27 Sep 2022 13:39:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAoG-0005xH-Se; Tue, 27 Sep 2022 13:39:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odAoG-0005en-SG; Tue, 27 Sep 2022 13:39:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0N1DCffmD97xQ0tJYpof3KM+/NhiIkc6FO0NyOsPEUU=; b=qupVtpKKcC+KvVuO6DOfQpKQQ2 x3gAKoLMkJfoKPs/D5pnycwTDe4cAEPYAzDTj01hJM6gMzs5zzkeEezjISMkF7UMgou+LVBg++/O3 U1V2p9IuqFLvg67cLnd9RjclHlzp9hn6WbSMVtT0lGWAjbSjUCE0IkXIflqXzMYGetgc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173326: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:debian-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a1375562c0a87f0fa2eaf3e8ce15824696d4170a X-Osstest-Versions-That: linux=3800a713b6070d4f03fb43613a7b7d536a99b2b7 From: osstest service owner Date: Tue, 27 Sep 2022 13:39:40 +0000 flight 173326 linux-linus real [real] flight 173329 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173326/ http://logs.test-lab.xenproject.org/osstest/logs/173329/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 12 debian-install fail pass in 173329-retest Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 173319 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 173319 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173329 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173329 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173319 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173319 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173319 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173319 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173319 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173319 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173319 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux a1375562c0a87f0fa2eaf3e8ce15824696d4170a baseline version: linux 3800a713b6070d4f03fb43613a7b7d536a99b2b7 Last test of basis 173319 2022-09-26 21:41:47 Z 0 days Testing same since 173326 2022-09-27 05:45:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dave Hansen Dave Hansen Haitao Huang Jarkko Sakkinen K Prateek Nayak Linus Torvalds Tony Luck Vijay Dhanraj jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 3800a713b607..a1375562c0a8 a1375562c0a87f0fa2eaf3e8ce15824696d4170a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Sep 27 13:50:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 13:50:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412618.655978 (Exim 4.92) (envelope-from ) id 1odAyO-00056E-PS; Tue, 27 Sep 2022 13:50:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412618.655978; Tue, 27 Sep 2022 13:50:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAyO-000567-Mh; Tue, 27 Sep 2022 13:50:08 +0000 Received: by outflank-mailman (input) for mailman id 412618; Tue, 27 Sep 2022 13:50:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odAyM-00051Z-QQ for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 13:50:07 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a3d4018-3e6b-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 15:50:05 +0200 (CEST) Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-397-JoYQex5rOxO2psl2rxXfSg-1; Tue, 27 Sep 2022 09:50:01 -0400 Received: by mail-qk1-f197.google.com with SMTP id u20-20020a05620a455400b006ce5151968dso7295195qkp.11 for ; Tue, 27 Sep 2022 06:50:00 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-104-40.dyn.eolo.it. [146.241.104.40]) by smtp.gmail.com with ESMTPSA id s16-20020a05620a255000b006b98315c6fbsm1038185qko.1.2022.09.27.06.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 06:49:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a3d4018-3e6b-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664286604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ofqCX7PnDwCH2641aVSgoebhxmiEcI1UVFpct2yGqJc=; b=UmquJ5A2/35hG57PVNEdyls9H6Cg96CW65GmkeOHRHckPOpsZRMbku4mntOie7WMxPBz3u dL/TTTuWNy3HJCV5FaOG6wYZgXAwDjFW8bf9jB37bzn1qTzx9ub5EEHHCbOL/zd27ZsBtU F8otFkZ5ZwklCD/oSU+NlUfvQvBpDeU= X-MC-Unique: JoYQex5rOxO2psl2rxXfSg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=ofqCX7PnDwCH2641aVSgoebhxmiEcI1UVFpct2yGqJc=; b=yNc6P2wIB3ytKQqQWrmCEibKOw1hKY4T/V+YkaAf8u9TXEVd9N3ul2Znjl6LKZgy/g CSCxmNu+RV9U1JTtw45IXBGwbqLGm5Tkm7ph/Y/kRhGY8luT62E7I7j9kRbi5cPKbnDE FX1Na5Kcy9wwmYW7U21cByKkWhXNao8qqje+B6nVln2CfJ0uAtSL+OtlviCiXPbLITPb abpNt5K1/ttlgVbe+fTJjMgO2sZmdbqHFd+UHV0ofwQd4xdx/XCyECjqE4Q0ifTAObtQ 4JKpN52fDUYcCVk0jd+nO+cdWE5v7lWDDhQVNsPipETq9quihSiBJteai0eJP9PEm89c uPDQ== X-Gm-Message-State: ACrzQf1Fv3itandykI4Srd1rD6q0vEThdTnFUXa0u62t5HvRWdq1YatW uzYFcN2ZO4o3gL3TDxHSkl8nuCn9o2k1m7g8bgOGi+cwaQMej2dr7SmcsVVWMYYtb8TsGz7Yb5h mBl/5lRuRzfBGK41l+N7vCGUcam8= X-Received: by 2002:ac8:7dc7:0:b0:35c:c050:16aa with SMTP id c7-20020ac87dc7000000b0035cc05016aamr22041922qte.455.1664286600563; Tue, 27 Sep 2022 06:50:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7c0Ohy85DoU6iQp5X+btljELCKn/uXSAjNiHTKbhnRxjc5Y3nT0n3WTDb8R9S/7JggYSEMwg== X-Received: by 2002:ac8:7dc7:0:b0:35c:c050:16aa with SMTP id c7-20020ac87dc7000000b0035cc05016aamr22041898qte.455.1664286600331; Tue, 27 Sep 2022 06:50:00 -0700 (PDT) Message-ID: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info From: Paolo Abeni To: Pavel Begunkov , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang Date: Tue, 27 Sep 2022 15:49:55 +0200 In-Reply-To: References: User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello, On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: > struct ubuf_info is large but not all fields are needed for all > cases. We have limited space in io_uring for it and large ubuf_info > prevents some struct embedding, even though we use only a subset > of the fields. It's also not very clean trying to use this typeless > extra space. > > Shrink struct ubuf_info to only necessary fields used in generic paths, > namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And > make MSG_ZEROCOPY and some other users to embed it into a larger struct > ubuf_info_msgzc mimicking the former ubuf_info. > > Note, xen/vhost may also have some cleaning on top by creating > new structs containing ubuf_info but with proper types. That sounds a bit scaring to me. If I read correctly, every uarg user should check 'uarg->callback == msg_zerocopy_callback' before accessing any 'extend' fields. AFAICS the current code sometimes don't do the explicit test because the condition is somewhat implied, which in turn is quite hard to track.  clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected before this series, and after will trigger an oops.. There is some noise due to uarg -> uarg_zc renaming which make the series harder to review. Have you considered instead keeping the old name and introducing a smaller 'struct ubuf_info_common'? the overall code should be mostly the same, but it will avoid the above mentioned noise. Thanks! Paolo From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:14:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:14:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412626.655991 (Exim 4.92) (envelope-from ) id 1odBLY-0007bK-Mx; Tue, 27 Sep 2022 14:14:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412626.655991; Tue, 27 Sep 2022 14:14:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBLY-0007bD-I1; Tue, 27 Sep 2022 14:14:04 +0000 Received: by outflank-mailman (input) for mailman id 412626; Tue, 27 Sep 2022 14:14:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBLX-0007b7-Lw for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:14:03 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130049.outbound.protection.outlook.com [40.107.13.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a31db5e0-3e6e-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:14:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9515.eurprd04.prod.outlook.com (2603:10a6:150:24::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 14:14:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:14:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a31db5e0-3e6e-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C5O/9Ld5XvMqhhS7Aky6V5V/3rEtLCZRRmKWK4sWZUbqH/vCXVsxpO2i7/NyUjuWrM5eRJs8JhjeKKx/fRPbk5u9yX0FExONmgXOFEFZo1oBRnjWT/DceIiIHcy29TSEqwdJh9junW0qArYmXzr2GxIdpZbSig+RPmrXQKyevDh0FaM7pCKFukB/F2hLVZ4rVw9XuS3UJ399jkQB/RuLlLQ2uq4/edRS3ousiyHG7RKrrAEShgpIfsq/ut7bQdOk3ZOXRcvyzyHRc5ftony5IV77xPqF2Zx8smw+KscRYXhhnKNFvJ7MqV+YUwc3PcvhmgXaE2QTDMntYrZHAX04HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KBwtU4JRJ9juidOk2OLyGM7RoZQpHcQkjF5H2maw6Qc=; b=PjoSQhmfI2PhhbN4JT/bFZYz9ep7I0o4kMkjtun8/8gVmQs//YaShcjb1q2G4vFlv6gpttHnb4w+r2x3RDGHr7KbaIvRLvlBiQA+eWJape6FG1FkeuY0XpdggkGnjn0mRVs2EDv8EePvs1OrFHjeu5YOtRilcrYAz0pZi9GyKG2CI3EQrfH0jM+h3k/THrSmWQl+1hP/CYuB7TXbzDif5gA5kETzLnlWd+ieT32WRRvqRHXYtPhB2VWqLscEfefBpFiIY/jmo4ivbN/Tq+d1ari+4lM4XcHyjQFjQUMuNQUeqzIjQ2HVcLrWYKwDoF9vQKq8ov8aZDLIPN5qlyOIyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KBwtU4JRJ9juidOk2OLyGM7RoZQpHcQkjF5H2maw6Qc=; b=SWvR+KDmUtZIT9NSmRxJEy6dSDDFB5mB/8W6mxwwVp9oOUGGyFizLyq1FJ2iheXHlWEzPi9EL4FWz6RTs4kRIr5+0WXNAI8ca4IF17rl0D0ct8OWKgZJ1x5XXR8u1Kgv4ajV6c1JmfkJngsCG0Lu4n1WzVLNjJa9I1QVP1QmIFKUUuCFfGh0znpsTMRR6xndcV3swO8dLl7kcJ0MEQDeftaeTUHd/xr7EDOKK+JJhuAyLd0SUW0z7SAfy/NZm+3bLRgvY7blMv6a/ExoQFM8OOfc4i19THtTPYRsY6soxOrv1+obt32Awz0paPEhbQrbqYaKz63B9HAYPV3Z9wOAtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1c668e16-bfb7-971b-8c95-be63792dee16@suse.com> Date: Tue, 27 Sep 2022 16:13:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] x86/NUMA: correct off-by-1 in node map size calculation Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9515:EE_ X-MS-Office365-Filtering-Correlation-Id: 09e49820-ee14-419e-4f35-08daa0928674 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXsysI/5+yJ51YyKJ1UptNB6syBrSzbywJHQLOkRs97cYoWePt0m/lqsPgPB8M6Q+nnijcTbawV3B8rAYsa7heoZzhd3YKg/t0LWWdBvhyb7AhHR1EJj8TU59pZOV+MvvNRau9d6IAaSQu08iXyDHdouVYc/987xUWXFb+9536n4GMadCqrFQZqO9NofApCJ2J+/gMPhfIkDFpijapRMYQ5L0To3HpbK7lq+Q2BgJ7zgt+9oNfccd/Sb3WKt46Tn2ARci9obuo0QnmbZOnhIyfGRJaRNFEBHP2Pw5Hz/aOrcUEpiW7BO+DDyguQsbDOfst33kRVRlVSgGjaSdWeOS3Z9sJC5kyA6NXX96OHFpXxmVnLFiXDju4j64AYUD6PtFc0PTGeUa/6TYbDdcgrHRsuhDkNrO+qseU2NxADKx7oTb5U88VaBSzaMV1l7vmQDSLrNN1XDqhjPDzUVzik9A0dblU4CrhsGT/U8aaNGV5P9yyKJuu8zo+ZGpO4zaEraa7jfgxZ1evjihhLlQ0eabwDuf5/8U9Unz7Jvn/2GW0VF0V1fHdVhO+tSlQMd+HUgu4BMiGIN06YOheZdAzEQUa5vGnTBJiZUWU/eobxsf05sT2yZkHcpQcjylPQOPx8HCyRD59DjHPzjBCRvYUec6f1vmaHSE4QjF7Mv6w1NDiQKJcrra+V9HhO9mjGOzcJ6bIym42R86ffn2etFcsrcC6qkHUjJ+5tR2K0pcQZhqRCaKEKBiIqqGXZ80lUHveR+kwfPQQaQ/HvjNmIcB4qAPx7jZ8sx75bBZBp3vjyHT6I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(26005)(6512007)(5660300002)(41300700001)(8936002)(38100700002)(83380400001)(2616005)(36756003)(186003)(6506007)(2906002)(6916009)(31686004)(478600001)(86362001)(31696002)(66946007)(66556008)(316002)(6486002)(66476007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UURrVGZadU1HMjlBTUNMMlVpOFlab0wyLzMvQTNFUUZVeWkrTmM2Tnh5L2Nz?= =?utf-8?B?Y1QwcjFaWStXbkRDUjV2L0VMWlZZOWpjbnUxenBGcVpPRE40YnVvaWsrRVpO?= =?utf-8?B?YzNwbzJ0SHpVYTlPNk1zWG1la3VWOXlQbTBwV2lKbVYzVjVyWk4xSWxLQjUz?= =?utf-8?B?KzVNWUFPVTBaWHR0NWtaQk9jYzFwbVg0aFJJbVArakNBb0lPOGIzY3c2ME02?= =?utf-8?B?WnlTRlY1OTBpVUdEcGhiUE5yWEFsc0o5ZkJTVXFJQlBYQms3YnAvNGFsRGxY?= =?utf-8?B?M1ZZVzdSMjVjVGJqcFAxb21xVzJyMVpqcTlDR1A3WEpud21DbzRORitCM2pu?= =?utf-8?B?NFlpZDFXMXVSMXBvWTB0Mjg4MnFENlU2WCswVDRjdWRqVHpyb0NWM0M0YTZ0?= =?utf-8?B?bTYzZW12RXpqdDdjUHBtRVowaWFzcy9WdnJoOC9xUkpPNWRDaXM5TnpqaFUw?= =?utf-8?B?dkFKNk5OOW1PK2FiWFpES0tzbmY1YnB2WVVTTHk2bFlZT0dheExrNjAwKzdp?= =?utf-8?B?aVlrMDlsdTNyT1lNQmF5L01pbFlXa2xoeWt6YTk2bXQ4N0E5Z3JBWUZBSGZh?= =?utf-8?B?SW1iMmFsVm9rT25hcGhRMVVDSXFuMEpTVnVJQzZLT0ZGZ0VtbjhodE9mK3Nl?= =?utf-8?B?Z3hBMDhuUk8wM0ZQSHdVYnlSY2h2cUNLQVZzVzUrR21tN2xoNElxYWkyMEJ0?= =?utf-8?B?ZUVvOE03VHBNVjR1aVMyL1FvL0tXYmR6OVBmMHBMSHVxMThRU1VDd3dKQmd1?= =?utf-8?B?VU9DVE5vTXBHVmNVOXFJOUFTbEtXL25UcnI4M0lScWpmUHhUaTFMc0tFNWtz?= =?utf-8?B?WWZLQnV6Zm1tUDBuUVFST1Q1M0tJMFFReUxaTW1HbnFRMTllN1FBMk1kUGNX?= =?utf-8?B?K3F5TTc2cXU2NmZnN0J0RVRET1BVM1JNc0FKTEFjYzRCd2VGcTlKZlJPU25B?= =?utf-8?B?cjZvMW9xWVJFdzFDL1lpdlR0RWJ2dnFPangrYnFhM0FwaGdGdDIxeU9VQmY2?= =?utf-8?B?Umc3U0pTUEJEWW5Jd0ZyK1d3UkVQbmg2ZmtSZzRaQXhiK0U0QmNBY1RqTTAv?= =?utf-8?B?UzRscllIUEJjOThtVS9FY3pPdDNpb1hJM2p4V3BUeUJqWlhpcXEzaHJZZUF1?= =?utf-8?B?cFFVVzFHWUFLaUJ1SmNWazA3dzh0UHYzZDA2ZU5TSDRzMTd3bjh3K0NYWUR6?= =?utf-8?B?T2VBR0p3VnpBTXlGT1BETFhPMzFyYU0vYlBKQ1I0WjFRS3RGV296L1hoTTFL?= =?utf-8?B?VG0wcXM5VEpGUHpKQVRwUVdyckVIT21DUkUxVmNXa09JZHpJSXAzSkxnL2h1?= =?utf-8?B?bW5NbzZFZ3BZU3hHRjJ3Vm1TbEhWUmJLUGxsUE5EMGdzTlNrUWxFY1JuQjRI?= =?utf-8?B?dlp5MHRyMTVGUDdpcGtCVnVWTDJvSjdYbFZOVlQ3d3RJazQ0N2JVaDdLMmp5?= =?utf-8?B?U2dUTTUyclpKU0FJaTE5ODRnOUhtRjZnaXpqamtTS0d3bldWTTZaeExNajIr?= =?utf-8?B?N2ZOaEdpVDdCTkx3bmpzU0EreXFmU1NiaFVJQkJTQ1hNbmNyYzRGYW5SYlhz?= =?utf-8?B?SW9Hc0hsa2ZmeGxDTnR4YWtCMkVHRFM5bGJKSjdpdHdxYTFyaGprSFhFd292?= =?utf-8?B?MzZsV2dvRDkyS1I0REJZdDl5RDBvODRiMzFsRFR2VUpFWWxBbXRWdmkvc0NP?= =?utf-8?B?S1VJaHUwbk5yZEs0SVJ3MjJtSGZHU0daVDFwNEdORm5qV3JXYmFlM2VVeU15?= =?utf-8?B?RVdNTVdUemVRTjRUNlU0d21CUTFtaURrbTRWWlJ3dHdSQWs0OEpOR3dpT0M5?= =?utf-8?B?YzJXQlNNVXptTkYvcnlKKzVjeE53N1l1dGNLTlN3aisxWU9tbHVLdFVuOU0w?= =?utf-8?B?U2s2T05HM05ReDRaTkUvanJsdU5rY2xVRjFnRmprZ3FMdlFJVE8yckZtZzZv?= =?utf-8?B?TnhLa2J5djRQbkNDZVVydk1BUnR5dm5pN1M0VXRzOXE3N1l0dWd0U0lHaHZW?= =?utf-8?B?c3YxOWh5RzREYlpuMFhoWWQ2UVIyVlhMZG1NMXNaekVSSjU3VE5kUkZZWU15?= =?utf-8?B?UW1pOVdaZ2t1TThKbFNUNjdjUDAyMks3NmpDM0Y3RS9kdGl1TVFzWC9aWTRJ?= =?utf-8?Q?NGass3rJh0NfiCO1XokW8RO8X?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09e49820-ee14-419e-4f35-08daa0928674 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:14:00.9035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WqecTQE1/R/eE6YkkoZSOFzFWeWU9k5Ou43fM78LipOwkTrnOYBTZGokO9JKrqgml1DVRTwDhjIWnauYYG7K8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9515 extract_lsb_from_nodes() accumulates "memtop" from all PDXes one past the covered ranges. Hence the maximum address which can validly by used to index the node map is one below this value, and we may currently set up a node map with an unused (and never initialized) trailing entry. In boundary cases this may also mean we dynamically allocate a page when the static (64-entry) map would suffice. While there also correct the comment ahead of the function, for it to match the actual code: Linux commit 54413927f022 ("x86-64: x86_64-make-the-numa-hash-function-nodemap-allocation fix fix") removed the ORing in of the end address before we actually cloned their code. Signed-off-by: Jan Beulich --- Really the shift value may end up needlessly small when there's discontiguous memory. Within a gap, any address can be taken for the node boundary, and hence neither the end of the lower range nor the start of the higher range necessarily is the best address to use. For example with these two node ranges (numbers are frame addresses) [10000,17fff] [28000,2ffff] we'd calculate the shift as 15 when 16 or even 17 (because the start of the 1st range can also be ignored) would do. I haven't tried to properly prove it yet, but it looks to me as if the top bit of the XOR of lower range (inclusive) end and higher range start would be what would want accumulating (of course requiring the entries to be sorted, or to be processed in address order). This would then "naturally" exclude lowest range start and highest range end. --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -110,7 +110,7 @@ static int __init allocate_cachealigned_ } /* - * The LSB of all start and end addresses in the node map is the value of the + * The LSB of all start addresses in the node map is the value of the * maximum possible shift. */ static int __init extract_lsb_from_nodes(const struct node *nodes, @@ -135,7 +135,7 @@ static int __init extract_lsb_from_nodes i = BITS_PER_LONG - 1; else i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = (memtop >> i) + 1; + memnodemapsize = ((memtop - 1) >> i) + 1; return i; } From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:14:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412627.656001 (Exim 4.92) (envelope-from ) id 1odBLn-0007uf-Up; Tue, 27 Sep 2022 14:14:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412627.656001; Tue, 27 Sep 2022 14:14:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBLn-0007uW-RN; Tue, 27 Sep 2022 14:14:19 +0000 Received: by outflank-mailman (input) for mailman id 412627; Tue, 27 Sep 2022 14:14:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBLl-0007ty-VP for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:14:18 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9d6a0f4-3e6e-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 16:14:15 +0200 (CEST) Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 10:14:11 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DS7PR03MB5575.namprd03.prod.outlook.com (2603:10b6:5:2cd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Tue, 27 Sep 2022 14:14:10 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:14:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9d6a0f4-3e6e-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664288055; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=IZcz498bLrjIMkDpiCPfRH/sPYvb3fCCDuZ8DjGofhY=; b=Zf3v92hBHLeQ/Iay4tZNz+eJ8RzP88dt/ewaKRFfEpY9gwX+c8GMLOTn ccQvQ93IE4GLvDtRx1R6HUvM2M9NgXfoGtVjf2CVFiyB7YMb+k5gNMzTP rKvdPszURAr1hZ2DqG/zPsVyazJBGIZ5ii5xwC1zeRDdjt36XbrBOqar6 0=; X-IronPort-RemoteIP: 104.47.56.170 X-IronPort-MID: 81869574 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7R6BuKo0wihAWGPvbtAZVPnr0LNeBmLhZBIvgKrLsJaIsI4StFCzt garIBnVbKyCNGLzedp1OYvloxgEvJeHmt5jSgdqqXwxRigTpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx +ImNyAKbBS6ps2/z+3iadhlucUkI5y+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+CF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efxHOlCd9NSNVU8NZxm03CwzZMCyELXEuQndyWphW4C+5Qf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx750NisoM27S+7ErwiTumrZjUTSY4/gzSGGmi62tRboO/e5ah71Sd6P9aNZuYVXGIp n1CkM+bhN3iFrmInS2JBe4KRbeg4q/cNCWG2AE3WZ486z6q5nivO5hK5y1zL1toNcBCfiL1Z EjUukVa45o70GaWUJKbqrmZU6wCpZUM3/y8PhwIRrKiuqRMSTI= IronPort-HdrOrdr: A9a23:0LfQZ6rCkZGb8F8+0pqX9rEaV5vOL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN xdmstFeaHN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMD2CAJsQizuRZDzrcHGfE2J9dOAE/d enl716jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr14jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKsu/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kdd11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtdqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWjHAbgcYa ZT5fznlbhrmQvwVQGZgoAv+q3mYp0LJGbLfqBY0fblkwS/nxhCvjglLYIk7zQ9HakGOuh5Dt T/Q9tVfY51P7ErhIJGdZI8qJiMexjwaCOJFl6uCnLaM4xCE07xivfMkcUIDaeRCdQ18Kc= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81869574" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HAUHeCSq2M5lb/75KjH4KyQRwEcLvsyEIAZoNNfBGVG5bID023tgScZENYuck60eu0YgNoubh6ufiBETAQoDXTUpEzdXGF2G/kwGrF+Ah1n5nk2wxS+G1dOfH+cS7mG6M+Gl84GeL6ht0d0zjFMeVhKDi0GVDPlBvHSqxQvQrLCFosBVMaB6fCPRKRB83Zx4IYLPsN2oQHFJe3htWI0eOix1MonYrMaBi0IxL/DkDSRkOEyzTAmLcNUKt88jHRp3yi1DdoMGr4s+nJ7F0EoekrBJhGMuTF+4LbhRtSPebAlbERSMdBzzuq4VML0PAdJa3iiyQ56CMa/0VDbIzcrWpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhFclLHlJ8aO6Adc36BHxpSHTDhTgU5ZmcsHGfWLQmo=; b=hgL3ePMzhDkpZs1i30CNlA1P50oE8wPO5Kz5lxp7Ijvc+KxGgBWFc+Rl01VdhAUmgY9OmAa6h9vwLEhUViGYjnLVUZ27i65huzut7w4VpxVf6S786i079FO5XgDmCdjY6nfjcNfY5qiTeYusuortP6kW71h/5FkD6DSk8MilayrRljstdzHZ9RUG9VqTp93dSA1Hn5DBXvBOnwwL+/4xOBPIMYwTlZMRH26O9NcIk5QfplkVpX22ODZzTXEQK2MXEaFrqmBq5s8BWRJ1wMTsrfyFkc375IGFrQ6bloBjZCrwkmfo8nvvvPkrNlwBTjod2yKNyH9EhMfnW9Iv4//unQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhFclLHlJ8aO6Adc36BHxpSHTDhTgU5ZmcsHGfWLQmo=; b=QrH6anRyRwdC2xcboQsBMIX+SNTQIrdVNQ7yO5Nz7A8+KGyfcPd4H9Ft2T74w6Rcgd8lT+Y24JuHHhWRd0ka9w7CrsPGel65AB2OB0HWp29dgoAjseIDUOUzaASiUuQ65EvyDEjP6RY4nGCL0KF9vEMc8KTbzoDhs5KOIDGRUYM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 27 Sep 2022 16:14:05 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BN9PR03CA0899.namprd03.prod.outlook.com (2603:10b6:408:13c::34) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DS7PR03MB5575:EE_ X-MS-Office365-Filtering-Correlation-Id: 484719ee-17ce-4ff6-fd4e-08daa0928b91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 20TH5So/YPlf3XXay1Kvj6CpBnLfOnhguK30SzE264tMM1frOTs5ZFWwbLiG5zZ4lSlpGOhkNZyJlRt9bAqfwge+WtX9sz5imDqF3nQ1pTZVYGjJpexkTH1OxW+1mmdVHFbKV3wJF4wiVBESkGqIdFvHGIWkIG+N25CcABC2R2zbLMVXnZjBgbDsl5dNYXfjGinykAdoWmo8GXpXxd/AEzcIsREO/tqQbR4m6vYmIQ6ydr7jodT6fghDERP6NCMYdAuBhwdtb9Lerk0QFiTXmFNOnMP+XtPnwDbN1mIPM4sXL9UDESoL84wNCMZERoAKZGl4uc42MvHsvG3cVtBmh4Lt0MKUACCEL7c3f8QRXgDTvUmsTlCc2OJcNumO+j4eoquK+0jai9t6KXLrXyylWfmzTVIQ/iCUIcN7OGNYlFcwc8ZoSH3JyDdS5QiKF9JBYGVwGBnFC2+lBRNS5QumOi1pbnINUtAAFltZwZqTu2qnMXtS7cOV9+s3oOAbZIBoSeXD5XAok/304pceOFHmXXBZUiIVbFF7zpH+d6JdcM11gC1ZHmhDsWhXlGkpGHvQUf0g8NdSxZ/wqufExEML6/dt4KRd7Z0orlryRa9zSaNgWcZCuGSyoHnupllnS1chIxLq1yRE7Xoxq53ABYVPbVgOWM30fEwaogb5hW8TFcEUZMJIN1kM0K4HDLuKjX7fw4Dj6ZwPsT4xymXGn1oMLfi5BThrXkRHLec1oa7Zy56ayn0fOXuoZTWXYJqEcXvG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199015)(6486002)(478600001)(6666004)(107886003)(5660300002)(9686003)(6512007)(8936002)(26005)(86362001)(316002)(6506007)(82960400001)(6916009)(186003)(85182001)(54906003)(66946007)(66476007)(4326008)(38100700002)(66556008)(41300700001)(2906002)(8676002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1VUWDdhdCtjaTVSREFKMVkyUCs1N3VkZlJpaGhOSkJHa1ZBakVoOTFTYVFQ?= =?utf-8?B?WlF1c1NLTkM0Vnp4ZVFLRFhtcWZOMVp1WXpVeG1yeVQzTXhabS9EbStuWWZX?= =?utf-8?B?ZzNGZ1dMbDVvNUdMK1ZsTWFIY0dXeXBhWGU4Vng1U0NYSFZjSXFyc2dWMmh0?= =?utf-8?B?SDlNbU52V2RIeW9vK1lNaXFIMnZHK3lyRFRoS3FMWHZ5enJCOGxYYWtHRDho?= =?utf-8?B?WjdENFdiQjhwL05aQzM0ZFZqL0ppb1dlaDdERkp3bkswbHJJZ0UrYXA0WXRh?= =?utf-8?B?SndYZWhQeFVERnpUQlFRZUVIUTdEdEJBRWNkYWhtK0VKMlJSQzcvVnJ3eDJ5?= =?utf-8?B?M2hXeGgwK0RiRGJpUklaQTFGVkZvVmcrTkhQaEZxVEp2anVWUXp3cXlMa3NU?= =?utf-8?B?WUN1TGEwL0hjRU9qRWhrQis0SG9aTS9RN0FlMzJWQlphTW53NTJFa2IyVjVJ?= =?utf-8?B?c1lHREJ0UHB0UnJNRC9Gd2t2VFhReWtCZXRneHEyWGhvWVZ2WVh3elZ6bVdJ?= =?utf-8?B?aWZZc2RNNGg2cWMyZ01tS2NwQ0hiUzk0TFUyN2FwcDJRMU1Ncy9WbmRTZThX?= =?utf-8?B?Y1NJM2k1RVJveDlWQVFJWWJzS1N4RUtlZXB0ZTU2cGEyUVkraG5JTkZhV0dH?= =?utf-8?B?bDUyeTR3VlVFZEpZOVJ3TVVpTG1HMG1EWTY4UUxGQm5BSU1XcTRNZk4yOUNJ?= =?utf-8?B?di9ndkVuMkw0S0d2MmdUTTRYOVo1M0ZLYzh4RzU3YnZVckV2ZHYwN2pnYXd6?= =?utf-8?B?dW51NE9qSG5UdE1tc1FUQkNmQUxVWFNPS3JBVTJPeE03ck1SUlQwRGRQM0Rw?= =?utf-8?B?NzFPcjE0MWJzWlVYcXpnZ3I0ZjZhSjB5MlhrY0tqZzg1aVAybHdOU2RhYnRH?= =?utf-8?B?a0todlhSSnhJSEJaSmY3Q3BobkFpdU85eVBKN2hqVFlrYzlWcFUrS2JDK2cw?= =?utf-8?B?ZG1vUjFlbUNvMmUreTh1bUlKSGxnamJGS2tmdVE2VUprYnUyaEp4YWJGTWFT?= =?utf-8?B?MFpja3Q5eFJLeDUvNFlGaWVwTmw5eGx6bnZIWWhMMk9US0tSTE5JU2U3TkN3?= =?utf-8?B?SmcybDhqSXMydXpYZ1JXaFNlZnBjTUwwa0xXblRGeTYzcHhSSnE0SjFjUVZv?= =?utf-8?B?ekhSM3FaaHpEaC9TUjZtaWN5bUYrRi9uTEFwM2JHTzM0TTJLS2NPdnovSG9C?= =?utf-8?B?R0Y4UnkwSXhUUzVGZlBrMDZDSkVodkN4bDVCVnZxNFVXaTNiUTFPUkhvOC9n?= =?utf-8?B?UlRtL2hpalRNdzgzN2RHbUI2MGdMRUpRMVFVbUJlRXVOR0JORDB4MGx4dUFw?= =?utf-8?B?c25oS0FySEV1K0FqakJVZDRkMHI3NGR4N0MzbVpRcGxNWEpxcXNtcUVBUWhy?= =?utf-8?B?RUFkU2ljbUZuSUlzRFd5aU1oTjVIOGdUMi9KM3UwUWJrVElBSnlqRmVISTIz?= =?utf-8?B?UnVVTU9RR01mTmY4VUN6bUR3T1RrY2dTQks0V0w2Y2NVdndqemFZTzdZcEJ2?= =?utf-8?B?NDZaMFNHUGZlR2NheFJmTmtHSURtOHpia1BwbWhyRmtNSXhCNUpHUi9jL05i?= =?utf-8?B?d0hRakNnM3BibU8wYW1aODArRmY0Wjd2bjVIYkp6RlR1MmRKZHNucVYrMk01?= =?utf-8?B?Ujk3VHdwWlhuYmxtYnI5R2g1eXBGc1pTSDFJMVRGak5UU0h2ZGR3cGw4cW9H?= =?utf-8?B?eUJEbWFhU2l1QmRRTExwTGxvVGUwRU9Cai9JZHlnaUloUFo5aS9UcWlMOVd2?= =?utf-8?B?WHRnbXNxWWp2TDVDSVhjbjNmMWJlM0FrWnFpcGNpZy8raW1rb29LQ0ZFRUFr?= =?utf-8?B?ZnVGbS90OWxIU0lHNFI5eVZIaUQzRFdqa0RPOG16bHhianE3MHlscm9QaFpm?= =?utf-8?B?L0JCY3p2Qm1pdFdiMHBiVHR0STM0T2o1Rm93Qk9hMzBuNjIvTnVwZ2ZuaE5s?= =?utf-8?B?ay8xbkVpWlc5RkowejBpMEdTVWtnNHd2eWM5WTdHWkNINlIyTGtTOHovTlVm?= =?utf-8?B?UXBDTWtGRDZPcmh1Y2Fob1ZMZzdDN0NJODRnRkpCM0pUYWE0ZkJHdCtoTU1M?= =?utf-8?B?eWt6K3craDMrbnkwYVk3U1ZRSFB6Q0tlMlJYU05FQmxvdmNBNHkrU3ZjZmF3?= =?utf-8?Q?4PW+eGDSRkJMvLUZo1uxGtMo5?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 484719ee-17ce-4ff6-fd4e-08daa0928b91 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:14:09.8161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nc5xwjvCgmjlEcy7Mx6jidifhj97s507jCZ9/zcTxYLgYg2FK/ZVZUgGlR0Edm0v1U4dhcTgzJ6IBGmfnvuozQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5575 On Fri, Sep 09, 2022 at 09:22:52AM +0200, Jan Beulich wrote: > While I was suspicious of the compiler issuing a diagnostic about an > unused linking-only option when not doing any linking, I did check this > with a couple of gcc versions only, but not with Clang. (Oddly enough at > least older Clang versions complain about the use of '-nopie' now that > we actually use '-no-pie'.) Filter out the problematic option in all > cases where the variable is consumed for compilation only (which right > now is everywhere). > > Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") > Reported-by: Stefano Stabellini > Signed-off-by: Jan Beulich > --- > Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for > compiling, the option could be omitted from that variable right away. > But if any compile-and-link-in-one-go use appeared, there would be an > issue. Is it feasible to have compile-and-link-in-one-go in one use feasible with what we consider embedded (firmware or kernel like binaries). I would expect those to always require a linker script and a separate linking step. > > --- a/tools/firmware/Rules.mk > +++ b/tools/firmware/Rules.mk > @@ -13,7 +13,7 @@ endif > > CFLAGS += -Werror > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > > $(call cc-option-add,CFLAGS,CC,-fcf-protection=none) > > --- a/tools/tests/x86_emulator/testcase.mk > +++ b/tools/tests/x86_emulator/testcase.mk > @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. > CFLAGS := > include $(XEN_ROOT)/tools/Rules.mk > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) Is the x86 emulator harness correct in using EMBEDDED_EXTRA_CFLAGS? TBH I'm not sure the naming and usage of the variable is very helpful, maybe it would better be STANDALONE_EXTRA_CFLAGS, and drop it's usage from the x86 emulator test harness, open code the needed flags for that use-case. Thanks, Roger. > > CFLAGS += -fno-builtin -g0 $($(TESTCASE)-cflags) > > --- a/xen/arch/arm/arch.mk > +++ b/xen/arch/arm/arch.mk > @@ -1,7 +1,7 @@ > ######################################## > # arm-specific definitions > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > $(call cc-option-add,CFLAGS,CC,-Wnested-externs) > > # Prevent floating-point variables from creeping into Xen. > --- a/xen/arch/x86/arch.mk > +++ b/xen/arch/x86/arch.mk > @@ -10,7 +10,7 @@ CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFF > # Prevent floating-point variables from creeping into Xen. > CFLAGS += -msoft-float > > -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > $(call cc-option-add,CFLAGS,CC,-Wnested-externs) > $(call as-option-add,CFLAGS,CC,"vmcall",-DHAVE_AS_VMX) > $(call as-option-add,CFLAGS,CC,"crc32 %eax$$(comma)%eax",-DHAVE_AS_SSE4_2) > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -12,7 +12,7 @@ endif > $(obj)/head.o: $(head-bin-objs:.o=.bin) > > CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS)) > -$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-options-add,CFLAGS_x86_32,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float > ifdef building_out_of_srctree > CFLAGS_x86_32 += -I$(objtree)/include From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:14:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:14:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412628.656012 (Exim 4.92) (envelope-from ) id 1odBLt-0008F0-Bd; Tue, 27 Sep 2022 14:14:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412628.656012; Tue, 27 Sep 2022 14:14:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBLt-0008Eq-6w; Tue, 27 Sep 2022 14:14:25 +0000 Received: by outflank-mailman (input) for mailman id 412628; Tue, 27 Sep 2022 14:14:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBLs-0007b7-IB for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:14:24 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130051.outbound.protection.outlook.com [40.107.13.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afdcfa91-3e6e-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:14:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9515.eurprd04.prod.outlook.com (2603:10a6:150:24::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 14:14:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:14:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afdcfa91-3e6e-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R2fTe/QbNofTKSWwc7Sz2g6zz0DfcIujJdxsjYR6Icf8h8MT7v0hd6FdXY8WsJB2lU6byhTmFUs1U5r4UOXI0IXJJtRq8P/Z+W1lXDF1iiGGAX6nv5mFxsLVgiZBrSGSVK4xN29jB3zJ4gw47hwf4MDX8R5iSEKZ6byWz5LbEFQH3nZmWuACmWPlh1Wca1kE50+PKCbaaXIBuF4BrR5PgKfRCZuXd2T0b/Ju/aVxvveeacKxH5HOvkwQ8W5/dmxshUVv3Yrw/+ja0pfRNnrDPqjIzg3DLSNs4OlgBkT9uR7/GYZTdHvygZhVBjI5mGpjQZcQxgICiZwTm07fbJFsaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KBwtU4JRJ9juidOk2OLyGM7RoZQpHcQkjF5H2maw6Qc=; b=dL4CGeqqMuB7RcApM/H6CklxZKkhA4gaD4S3OxVoPTAmlH66xTvaMbYkL40884jicZHGEVI5dmb+kOac0J619OTDKTf7zje6OvxwPfgIFi6DRUeiWWAU38WCpY+cdPRLxcNx8eX0r+T+ieApcBVYGUc6Hn+ljm750cOMyXF8aVvXvFRIhyfDdYisharWe2tieS/SqBynzboz2PFkkYfrqr24lpm1kQ7oss01nJ1Pj+gFlF/W3KP/+XZ6sBDJ/HKcBuM3hK3k11eYjtlvkuXDEYCx3gSJJMYOzrcM5mkwyNTV3YaiLUGTHxjyRRzW88ONjTfvas5G70YAKX5g28oX1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KBwtU4JRJ9juidOk2OLyGM7RoZQpHcQkjF5H2maw6Qc=; b=oVzaH6eBwGmFYqYVC6rxQkFRCPjLYT9w3A5XpkDDbo6Gpm0zIvqsHJYMTZowMEHN741y9r2coudxjpncG3jlS7FbR8e359kUP0WeNodixzCSiPqEi6hwlvGhHUzH/R17+Q2V2fxaFKi7L4gVqrnaQInvEY9BxsoQ30rzet37WNKdoYDtm48hrVmIl6OmN5oElCCklDA3zfK1xbXyFiVisLVQS2B73nh8zK8XsW6uJYxFaxM5oakRvosk/3eI71CZ4qSk8ggzP+4ROwIFKaEK5BDehXyzJ6slg3lS7EYCbJwDxQ5CkFDQXI9+AwlbA/fv0A1Cc/NgVPSXLjABQZqTQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 16:14:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 From: Jan Beulich Subject: [PATCH] x86/NUMA: correct off-by-1 in node map size calculation To: "xen-devel@lists.xenproject.org" Content-Language: en-US Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9515:EE_ X-MS-Office365-Filtering-Correlation-Id: 7215f65e-06bc-491c-835c-08daa092932a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RgKrgwDaT1alXZwWNlfwrNVnt1Kll+fx5Qc6VIteku16aiEyksy0m5Gl3fwuH6KKxAWOywgvw3YiTe3+qE0JET6/KmP2dMrTvQSiD0MDQjdw0gf9VltAQwGn9qzMm3ldBU5JIk1iqzrqoliBejwsfeLxZ+pSZ338fUq6oaSDis96gPZ1wiaqBzL0bGZkPDltqYx5BpZhQpAdMuSh5UgbNeYLhc7HD8cwqL2/BZzIfG7RPTRy2uAwpokISHUliAaYLMY3Muu5A5WPpafG2se2SAfajxkylXCSY8Ez+TtygePUcDnNf9vTbQTFNNUD2XXfIUYXrAksjewMRPy8V+bbtfJ92Pn8yRN0s63hMZSeh9WVAjvRlBTnpjkaWl4f8oEfqrokyrkan90GGlfcTRO7lO4khOwdqIlpU2ofhhx11/oI8n0vuurcOn2ItxuiMDPqBcXWeOhEYu+nmS/d2Stg6YAVJF+xLzsOJkEwzEEpOdSzxTaRoI80u7r2bFFrCWBIzVTobkcgGogLlpen8eWmv9ReW0oeAmBmHheE99PueKTEBKK08vaHdIYDOaKCAfYyZ7WrVGY56NKdAl3p3L77NGXmzNQ+sMftV0h8W/B7WFomzfk2E9LuBIziuSEqAoTd8/9NXdvliKBcZNPU++3AbmuFWD9Y4P8yIuoIrgmR8FtrF8eS8Sf5LCl4EDvw3Kx4RY5//oexjfqoIHS0UJ5Dz2qkz4euBsT3PYa2fek0QuDYv5Iqt6Lz4iVokzimqwD8Dl7n7+HxE8CH/MPJqwHQD4UmndVYRxWIa2RuVxMzbCE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(26005)(6512007)(5660300002)(41300700001)(8936002)(38100700002)(83380400001)(2616005)(36756003)(186003)(6506007)(2906002)(54906003)(6916009)(31686004)(478600001)(86362001)(31696002)(66946007)(66556008)(4326008)(316002)(6486002)(66476007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNBekRVaHQ4SElyT1VFS2JpbkhuUzF5eUhTOUxhSWRBdVVmT1dicW02VStY?= =?utf-8?B?OTZ4a2VoVERQM0VFMVdwR0E4NlV6ektMcHRMRklqK3A2TU9Md0VjS1gyaVdC?= =?utf-8?B?ZzNza2h3dEV3QjRFbEVLK3UwMGQ5aEJPNEVEOVc3Ny92THBKcFUyK1dzN20z?= =?utf-8?B?QUhUdnJJdkU4NUZNcmV0ZTMzWUFhVHhSSERKQ3N1eTFWN0tvaWZGY2dHb2lE?= =?utf-8?B?VWdMZ2E1MEx0VHJKU0dPQ2ZhRTFIS1k0MHd0UjRXdmFpaGx3bEI0blpmUm05?= =?utf-8?B?ODFvb3ZBaFV6b2lSTXUzVkp1UkhHRWZGc1lHaFJUWDg0dW9YOGduYmtScHFj?= =?utf-8?B?Z1VxQTVyZUVCNnltaC8weUE1S0tMYTN4QWNNaWFRZ1VwenNLZnRzbURrY2VO?= =?utf-8?B?K21LdmlnYTVxOXZxMW4wNlpCTElIdWFGRzFjMlhUSTlEeEtYdk1pV0p0TnJO?= =?utf-8?B?QWEwTVVNU3J3UVplcDlGbGo0dEhadFl5L3FOK1gvbEZsa1FpUXlmcDNhL0N6?= =?utf-8?B?NkN1eldJK0dJQVJiMlljRldDYVBoR3VScHJDSWF6Vk01dG03Y3p1L1pYSEZ3?= =?utf-8?B?RGNHbWJyL1ZQN0dPMG4zTHJSQ0NrM0F1YytVcHJ6NDg3UFQ1NmwyS0ZXVHZh?= =?utf-8?B?N2Qra1dEWXIwMW9Zc2ZZK0JFM1o2NWZ1OWhtcFlicnFtRzVaREVrR3RxQTBG?= =?utf-8?B?V1UvUXgwM3Zvcy9SaS9iR2U0R0NiV3RNRTdXUEJmUk1lVkZFVHd1UUtMSUsx?= =?utf-8?B?ZytXblFQNnRoelA4NGIrZWhjZ0h4QklmYUw0SWNNWHljd0JVcDhRanBxV3hF?= =?utf-8?B?OXlXL3lZcXFyem55c251S3ZoVVY3WVpIOEhmbm9oeFhoamxISmlNMmVtVkpM?= =?utf-8?B?UWtPSUNpemI1dUUvaXhXQW1mOFhxSzJ5YStMNFdKQXJpRWxvdm0reFVaRDFh?= =?utf-8?B?cXRpZlR3dUQzZ3VQWnhWODVVR011eGwrTlkvenNUSk93aFV6ejd6VWJpam9k?= =?utf-8?B?SnFVcTM4ZDF6YWwvRG03NkVpckFKa1dFcTEwR1gvS082bnpzWHpPMWdyT1VK?= =?utf-8?B?aDEwcHZON2g2UVdxU1VtaHpQT3Z0QkZSeDIvQXJ1Z214QTFpVVpqZjZabmQv?= =?utf-8?B?Tksvb1AzS0J0bmtobkc4cHZpcHFUaXhPMGp0YUNhSmRnR1FNUkhWUExRbG1p?= =?utf-8?B?eGZwRFAzQzRwRWN1cW1nQlVKU2xkRzR4WWRIR280dnI2cjA1bmZDMFVFSC9W?= =?utf-8?B?TThMenVTNnNYQzNqbVFacDB4ZXU5d0R5SVVLTlFwdnUyZy9tVXNMVFVGOGQw?= =?utf-8?B?U1c2OWtmS2RoYXplMVl5RHVoUDZPOE56YVhLMDVhRUdIZDhveEFzQS9kc1ps?= =?utf-8?B?WUM2MGJ2STVmZkhBNlV1Z3FkcTZWYW44UUdQMFJUcjd0Zk5jT2xZcFFSSUlF?= =?utf-8?B?TkNQYUkxSnZJSVluQkNMdVgvY2JpanZKOTcrNmkxUnBoOU93cExRdWl4VVNQ?= =?utf-8?B?UmVwV1JWWHVnbEprSmJEVVh0VjBHeWpvYStMRzgwckhmV2RJUk9JbW5sanJq?= =?utf-8?B?S25GYTFVc1pWd2VHanJjV2VteklndlFlOFRKeWVsbkhFb2VRMEViOXpQcXo4?= =?utf-8?B?K2YvZ1pGWVI4TlRneG8zN0l6ekkvaDBna2Vub1Q2dFpvdFdwcjRIaExyNUJS?= =?utf-8?B?UjArQjZENDdHT0s5OTgxOXFEVEladHZuZnY1dFBHWTB5MDJTVEZBV1ZqdUIr?= =?utf-8?B?SG0rUHlrcFY5dnM5RnBZOUJXbXVwNWJibXMrekNEazBjNWNJckZ4cHNPemtB?= =?utf-8?B?dE5Ra1ZJQUlISVN3M1dybnRhY2tobHRINjFPYTJwTm01K2pKbTZhcFFrYmRK?= =?utf-8?B?b1M1RTdEdEtpM1ZJSWdXQmhMYVhHbFJXeVpTYzZ5WnM1eFBhUWkzSTU5dEVq?= =?utf-8?B?cXBsT0htZDY2Mmd2WkFyUDhJWFRHN0NUUE5id05pMkhVbTQyNXFDT0dDSFJT?= =?utf-8?B?OVFPaEUzZlJUVEpVclljdmNhRnYxSVRGaWwrdDJvbEVLQzRtM1d3M05OaFMy?= =?utf-8?B?cWFCaEZFSURNT3ZmS1o4Q1EwSXo3ZTZFZ2ozQ05zWkVGQzBtS1lDZWVKNDNV?= =?utf-8?Q?I+kIeC/8QQJlejd0SP+c9eDfj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7215f65e-06bc-491c-835c-08daa092932a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:14:22.3396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2XfmAjAof3JOkBZ2LQ5ZDantaJQ/9MKkQpaA5sflPCti+XZ6VIG1W8MNKAkbochBU4k1S+5pM61mlUtwS9wo2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9515 extract_lsb_from_nodes() accumulates "memtop" from all PDXes one past the covered ranges. Hence the maximum address which can validly by used to index the node map is one below this value, and we may currently set up a node map with an unused (and never initialized) trailing entry. In boundary cases this may also mean we dynamically allocate a page when the static (64-entry) map would suffice. While there also correct the comment ahead of the function, for it to match the actual code: Linux commit 54413927f022 ("x86-64: x86_64-make-the-numa-hash-function-nodemap-allocation fix fix") removed the ORing in of the end address before we actually cloned their code. Signed-off-by: Jan Beulich --- Really the shift value may end up needlessly small when there's discontiguous memory. Within a gap, any address can be taken for the node boundary, and hence neither the end of the lower range nor the start of the higher range necessarily is the best address to use. For example with these two node ranges (numbers are frame addresses) [10000,17fff] [28000,2ffff] we'd calculate the shift as 15 when 16 or even 17 (because the start of the 1st range can also be ignored) would do. I haven't tried to properly prove it yet, but it looks to me as if the top bit of the XOR of lower range (inclusive) end and higher range start would be what would want accumulating (of course requiring the entries to be sorted, or to be processed in address order). This would then "naturally" exclude lowest range start and highest range end. --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -110,7 +110,7 @@ static int __init allocate_cachealigned_ } /* - * The LSB of all start and end addresses in the node map is the value of the + * The LSB of all start addresses in the node map is the value of the * maximum possible shift. */ static int __init extract_lsb_from_nodes(const struct node *nodes, @@ -135,7 +135,7 @@ static int __init extract_lsb_from_nodes i = BITS_PER_LONG - 1; else i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = (memtop >> i) + 1; + memnodemapsize = ((memtop - 1) >> i) + 1; return i; } From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:15:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:15:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412642.656023 (Exim 4.92) (envelope-from ) id 1odBMp-0000rp-Jx; Tue, 27 Sep 2022 14:15:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412642.656023; Tue, 27 Sep 2022 14:15:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBMp-0000ri-HJ; Tue, 27 Sep 2022 14:15:23 +0000 Received: by outflank-mailman (input) for mailman id 412642; Tue, 27 Sep 2022 14:15:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBMo-0007b7-Px for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:15:22 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2127ee6-3e6e-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:15:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9515.eurprd04.prod.outlook.com (2603:10a6:150:24::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 14:15:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:15:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2127ee6-3e6e-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SFAuDTNHCAU4kpA7oHUtk1zFyevbiUupXqAvXxK5EZSnw/JFe+7Teqvl+lIfEfa7cdghXrlAqkv8lpHbSam+kcTUfB+rQuyAHy5rlv9Fwr2fRXSDeW22PF5einMfvsZvPJM3XwcEHxDLH6tfskn3U9rBDtYSyygRH/sBpdYjxG0OmWPYFALc4K7JKy/r8LWM7S6xVekHJD1Y/sAMkgq4ur3D8J0r7je1YXMl740V3/3NoFxLYbffzx9jOirGKXaU0X7IWVsLY4CvqXh2KrwGGbMQvICBGqO/YgSN10nA0b3gWt5xos5n9j4s8Ykc6Aqux7O8rvryIrq9EozRw3HXfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RTLi2iGdZYIlnjw1ZxuuWrnZlomFDGrRKcaedNt44lI=; b=dglA1ohTX+vXfgSXETHXWfr+BvpuRXAUE1p7umDZ5XFp4AHWrSRGoPLF6DOWGyp7XUss1sb8h9ubISULbt2wZqaDYvlQfbUNz10Iy/b9N1e1GMrs4m4DeAzXq3wIlOfVSwndNH2oX/wVG32VjqUBlOrI9hmGPSXiviZ2QKeTkezIGaVV3+NWR2ZvAvgp5necV8RilRnNcZCbH70IlDlL3F/1TYuJE6CW7u6rlPxRwCJl+8Yxsds8jp6B4f25cR5SznH+AhkkVPwipE3AkPcb1AVx5KcQhMguvgBptGgvr+7lJdhXG5lAhxBaTmj/wesP/GnX6CQUFxLz3flSekhK2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTLi2iGdZYIlnjw1ZxuuWrnZlomFDGrRKcaedNt44lI=; b=XynfCbrbzZPt5OVXF98i1Xz3bMxFR9GDUjW+R9zRQZj8BYtw5+AaKrSG4ZHHKKynRwmuVB4vdV9ebyEv+krxBaAeVfsp+54ek030msV/dAHbQgiapzVOtm+7+31os6eNi7CYFdf5ZJEAX4Jo4H3yh/EZ/VUWJfsElu9aPLRHjDmIdyAtP8BsNh27juSCcCZtTbbNQHxTlRRyTSSdIcu0MMbDvNzItU3hS2FGfB38PGl763HgejhcYftpa/ulMFrG4XlBqWf7Szvy3a0KxSk0p2g3VMyk0p3hdn23i/omUPNBhntpARKfzfmSuYNt2+OMKkVQDvRI2PInCX72pRqalg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> Date: Tue, 27 Sep 2022 16:15:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9515:EE_ X-MS-Office365-Filtering-Correlation-Id: e54f7ba8-e4ed-45fc-916e-08daa092b5e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OuWF8QXhwc50lcVWfgudKAHuS9flmQqehBJ1RTCSmfdk7rsaAc7Ko073Qg/j3uW/Xd75nNR1XcKDJMcLdoqys9c7fcAJFCNUK/SuwnxIF4oceeRixscftTPIT+BlIUMQPXhD8jbTr3YVltaUXukQTp4C237aCVqegMBku05pxxvkPZhZdzfFr+R2Fn64iJzMMgk0qpddpHN7f3eqUNM4f6vGBM+2ZhkbECRUOKKcgatpdlJ52vFegvB2hN6jfI1Y3PkxjxJhMuVZmhfhYZe/eU7qiMkItmQXvZopb/EqrwWKwltMt0J20JIs3vk6dTLUv/1kC2tHLFsDUlOb1PVIUgwYjuaXCJlHtoKoqE42A2JP1y9/r+hpBwmghWokBWO1JFGhw4rSjpC0xO++W960ZaXOGBttwgHRD2vrfF9T13v6nGziDRhix6FnAkMtx6bPvuOOOI5gh9TvIjTG9F+PYMOl+iuPARyHy9ylmRoioUmZMBGeoRI08RhbfLi/9KITFoM8Ps8GDFZ/0Vcr+EBpd/1JgcDOka5SZW0LKGrcOqJZNQeJBzwb/huR9Zjf4xr2m5/r1kfuprzl7pYM+2kCGJBV0hL/MCSEkl10iBhWaTe2RCdydRBgRAeXtxd395Gdw4S/dNS7gvnAc8BgCNzQZvtOEXCzy+//tSIP8jhsXeyygChAt+nNIFp6VR1u7vgCYUsT525t8lu0RlHX82hKZVK7ePnXh1myQssQLSm2sSdXdTjiGyLin9ijanoZmdwuYKyc48Z2f4YUH0eIo8XF2bwTwDBMEWtreofoy3ErL28= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(26005)(6512007)(5660300002)(41300700001)(8936002)(38100700002)(83380400001)(2616005)(36756003)(186003)(6506007)(2906002)(54906003)(6916009)(31686004)(478600001)(86362001)(31696002)(66946007)(66556008)(4326008)(316002)(6486002)(66476007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXNOeW9NbklxYjR3cGlwVHRNMDY4VVI4TFpJRStkdklVTzhCNTZHSEl6c1Ru?= =?utf-8?B?VmpndDhlaFFUVk5uRlhEbFllUzJBUG51MXpnOGdrSjBDQlo2YjRVSTFoRG16?= =?utf-8?B?c0M4ZC90dVJtdW52MXN0UE5nQytkWW1JK01Pd1FJczBVTGZpQnp6NVNnZ3lV?= =?utf-8?B?UnpvT3BuWnljMURUQ0NhRHZSL0NWVFlxdlZiZHpOWXlhRk84VnFGaGN3TmRU?= =?utf-8?B?MGpPM3N4cXZHaUVVVXdJVVV0M0NTNWtYTGRQMXhxR0dZQ2RLdWIxVTZCZlRJ?= =?utf-8?B?UGRUKzVuSmQ1WGl0Q0hVOXlKUDRMOFd1SzBQY3dhVmF4SG9iWUdSNmJLRzhH?= =?utf-8?B?LzBJTlJodm9DY2I1STZvN3ZnekFwbWkyTXozVDRHcEJnQWJEMWFWOFJ3RUg2?= =?utf-8?B?WXNOYTZCaHB0SEp2WDJYaGtMb3J5VUNlNG1vaXRzSmF3QVo5TVdKeUlObklE?= =?utf-8?B?ZVZXTy9DaXhlcEJ2TitsaFpaYlNIR1cwbFB1ck5CYU1jRnJZY3YwSHdCNHNR?= =?utf-8?B?ZkFZOHV4bExxeG1lWHFOS2FmbmhTMWxJREJ2NnVleDNlK1lOOTRoeUQ0S0ZU?= =?utf-8?B?akN3QnBlRDh0VXdMai9XVVo0c3BneG1teXE2YnpkcDZ5WHBOV0xKdUVkaU5L?= =?utf-8?B?M2xydlNDZ1lZenNhU0c3VFNINndXYXBhRlNRK1krWFlxT2MwenM0S1NLaXhO?= =?utf-8?B?WXZaL2VlK1NDWXBDTXBiNlRNNTBMT01aSlpaalJEMjZIMlRlbVdoYy82a1k1?= =?utf-8?B?cE8yZ1ZhamFwQVFzNS9pWmhOMWZEQzV2NGlPckxrVVVkUVlRUjN1R2pPQVZz?= =?utf-8?B?Y2RjS0dNWU5wNDV0QzRTQmdxNjVnSXNNT1JMa3poUHZ6VHF0V2xpRTdGdlFI?= =?utf-8?B?eHBzZWh3WmhOY3lFTVF0NlJKM0I4WVcyWE1qS0hETnVYblJYNEdFMHU5Vk1H?= =?utf-8?B?bmpZWHJ5b1VwRnZiZXlYSzZtcTB4b3V0Z3c5ZzVRU1V6V01jWFBKS213OWJW?= =?utf-8?B?d0p6THVSYk1MT0I4QzZ4RzZBcnp3OFhnMU44RVdDVGZJd3FoR3RzdUhZa21t?= =?utf-8?B?NHpiU3lGTUhpWS9XYVJaZzNSYVUwb0RyTjl5UTVpY2ZuTnhWeUk3bEZaN21y?= =?utf-8?B?dTI5M3V0cEtqc0x5VHZoMHhXRHBFTTJzSXFQeGp0aU1LZ1ExbzluK2RoL2xD?= =?utf-8?B?N1ZIV2VGWFhsWjJwQ2FGUXhlUnpGcis1N3JESEFIYWtzWFRCVTJaRHRIWlpH?= =?utf-8?B?TVNwb2VaRHdaKzA5dUNtM3F2bGxIWnRZSHY2UjhuK3NtSTVJRWRMRnFIS3ZP?= =?utf-8?B?elVUVVdFUEZoaDE4d242YVhlbUcraEtGUmlJeGQyYUxiWGJ0WXcxZHMzQnRy?= =?utf-8?B?RGMyZlB6aUR2NjBuelpoTnRMQ3JnUkJZMmtlcTA5a2tNNTBOcG1jaWpvYnFm?= =?utf-8?B?TUlZeERsL1BRczI4YVVCbElqS2J6VnAzWmxKOWVrUStzbmF4M0FhRDRlSTVm?= =?utf-8?B?bldiZzBMRGViMnVQWkF6WmdQSjR1SGg4OVVYbjd3ckpxUE43bDlaRHFVQ0No?= =?utf-8?B?RzV4Wm9IaXh2VWlrcmdLTC9FUE1YYXVyZVNlMW9UWEJ6Y2FBN2VrRWFuNVpS?= =?utf-8?B?YlFoMEJadVE1UnFUN3F3Ym1ZVWh5VHRORlduMlAzTGE1cElHYk1VUHh3YkRa?= =?utf-8?B?TnBJUkgwTUtGOE9uamducGxxNUNiMWh3N3BDbVI3VmZJVjBhNnlqZjBZVjVN?= =?utf-8?B?eVdNL2R1UTJmUnlYK0JBeGxOK1h5SEVmM1B2R3RDYXhyYzdiUmZYZTNIRWMz?= =?utf-8?B?c3dlbVpZZzhYYmtUY3Bhb0J6SnVqdlRnUjZpTElSTmdCbTJMVU5Vcks2Z1NT?= =?utf-8?B?aXMxNEZTTU8vcHo3cTZpbStNT3Bva0ozeGE3c25XaUsxa2dVUmhUN2JTbm5D?= =?utf-8?B?RXIzL25JeHFjcEtwTm96QS91Wm1Ua2pBY0lwbzZibTZEczFHS2YzK0pQWW1j?= =?utf-8?B?OWRocWVYMWZRNHF4VTVrMkVKS3FpRHdwdWNkeThUOHhVenNXNTNGcmF2aHJv?= =?utf-8?B?MGF2dnl0TnJnQTVVSnlPMDJma1ZlVE9HQ1BJU2ZqSFhlME5tWWdhd0hNdE5I?= =?utf-8?Q?XZ35YCGDBSgD80UcL03pNl6Wv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e54f7ba8-e4ed-45fc-916e-08daa092b5e4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:15:20.5390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RiZ879+ML0SSRcZ5OrQDhtvOdu3+WtFKmdbMn9RuKWCzU7vGLvROaQXcFqmdlz2KcRDDSRrHqow/Escel881lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9515 SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich --- On my Skylake system this changes memnodemapsize from 17 to 1 (and the shift from 20 to 63). --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -78,7 +78,8 @@ static int __init populate_memnodemap(co if ( (epdx >> shift) >= memnodemapsize ) return 0; do { - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && + (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) return -1; if ( !nodeids ) @@ -114,7 +115,7 @@ static int __init allocate_cachealigned_ * maximum possible shift. */ static int __init extract_lsb_from_nodes(const struct node *nodes, - int numnodes) + int numnodes, const nodeid_t *nodeids) { int i, nodes_used = 0; unsigned long spdx, epdx; @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes if ( spdx >= epdx ) continue; bitfield |= spdx; - nodes_used++; + nodes_used += i == 0 || !nodeids || nodeids[i - 1] != nodeids[i]; if ( epdx > memtop ) memtop = epdx; } @@ -144,7 +145,7 @@ int __init compute_hash_shift(struct nod { int shift; - shift = extract_lsb_from_nodes(nodes, numnodes); + shift = extract_lsb_from_nodes(nodes, numnodes, nodeids); if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) memnodemap = _memnodemap; else if ( allocate_cachealigned_memnodemap() ) From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:29:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412656.656034 (Exim 4.92) (envelope-from ) id 1odBah-0002WB-RQ; Tue, 27 Sep 2022 14:29:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412656.656034; Tue, 27 Sep 2022 14:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBah-0002W4-Ny; Tue, 27 Sep 2022 14:29:43 +0000 Received: by outflank-mailman (input) for mailman id 412656; Tue, 27 Sep 2022 14:29:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBag-0002Vy-Dx for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:29:42 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d13e75fa-3e70-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 16:29:40 +0200 (CEST) Received: from mail-bn1nam07lp2044.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 10:29:37 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5416.namprd03.prod.outlook.com (2603:10b6:5:2c7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 14:29:35 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.027; Tue, 27 Sep 2022 14:29:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d13e75fa-3e70-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664288980; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=RdKa9YppLrZ/GksXmmNlTC4WrT092sYpChMVJNDGWMk=; b=gImTs+vMaPa4j3wMFcQ5LjlxxYDqmshMUhHW73Gde5oPoiu38M9JQZM+ PW11CHe4YaXVwkuc1BBUsTAZg8bO6nvwcAl8r+jco9nTKAmYfM/OD517z gf+UqmO/ydoyVhSFXIzrb9Oba6rZCi1HMjySXX/MZ2CDdHJIAQKXJ+sYT g=; X-IronPort-RemoteIP: 104.47.51.44 X-IronPort-MID: 81871296 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UTLpKaoDPG+GWr1TTrhdsn3h849eBmKdZBIvgKrLsJaIsI4StFCzt garIBmHa/iOamryeNlwao2/8h9TvZTdy9QwSQQ9rC82HiIa9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx PtEGSIxXiK5qe+974yJUeg9vdQGM5y+VG8fkikIITDxK98DGcqGaYOToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OlUotjNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCNtCS+Tip6ACbFu7xUIPCzE2DkGHgOCFjFyvQtx6G 0oL5X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRUcAeCsFQA0t89Tl5oYpgXrnVc1/GaS4itn0HzDYw D2QqiU6wbIJgqYjyaK/+lzWhiO2kZLARAU1+wb/U3qs60VyY4vNT4al80TB5PBMaoOQVECcv WMsktKbqusJCPmweDelRewMGPSj4a+DOTiE3lp3RcF9q3Kq5mKpep1W7HdmPkB1P80YeDjvJ kjOpQdW45wVN3yvBUNqX7+M5w0R5fCIPbzYujr8NbKivrAZmNe7wRxT IronPort-HdrOrdr: A9a23:1uaICqERehGfCodfpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81871296" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jmCFxFqJwvB3JqcAfVR6MbByxnN2fLRxGsVGVTG5esQmosZOYlmlL7NVENOHuFWxyEXzFgRl14jO4QGqSamh7ZJSJwmYA9JOomGEGV8XmD0zkxJDGO918IyYQmxvVwiDA/VJUtwc2YF+P0m4L082k23R5CQWpgNhGtAUnJ7skIlqM/YQHGRsXH6aOahXitnJmGg6vFXnSwNB0rWJAJtUFKDAZ8z9xfSWBcUhk6sRPYie/qjKfnFNWKBKnSU+Gw+zit8evfX5PBZYNv0XLSvvFygtB9GG/f5KWidjlKh/mQgiLmcLnl/6wL+tT1MbKe5Do/OLciiZUuUa+suEKjM1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RdKa9YppLrZ/GksXmmNlTC4WrT092sYpChMVJNDGWMk=; b=PDvlcv9BESkuVXzQBUy4o+90uwyNVQcs6OlXsQnUC555bhtfxauVXN9PlbGM1XXcKl0dyjjF9iL6yyPbAam+tkpUzYfWD93+sJxsBuYk9v8dE7ZgS4aSBF1+mE8qEPhHz4tvemrdbyYJz9kiDT5e0S1SPN6qt3yzieIjlTk9SebN1tFzVVQLKYvfZO+NJ21ppdpQlGg031f3FDoW5C3ZuS67bff1A3khR0EyklT/dJX9FIOdhfOGIXbabbH1EZyhhhBM8oQAmOMaALE4O5/aUtEMdLb+LEiOaM4mpyUsF8FLtuok/2EasmDlkXh6SUMvi+KTOckau65SB8zUPDA+/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RdKa9YppLrZ/GksXmmNlTC4WrT092sYpChMVJNDGWMk=; b=A4CHVWOWE4H5QK5A7eaFiEGwrIPF6mA2Lnw3yow1oxIEbdi07znf408QlyQ/vFuGbtW0jQdNn+aqFzrAd4iv8HBBHu9J0wq6YqTz1BXgSQDcgu2k9i0B3y9QhxMp1SLUCSbWyAQY/coiWFEW1w7WTVKAgfWL9OAjeMJ6tNhwIhQ= From: Andrew Cooper To: Roger Pau Monne , Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Thread-Topic: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Thread-Index: AQHYxBz9vXThIyLw8kuRIj7v9n8AEK3zbpOAgAAEUwA= Date: Tue, 27 Sep 2022 14:29:34 +0000 Message-ID: <7eab9645-0c7e-e171-870b-814c330fac08@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5416:EE_ x-ms-office365-filtering-correlation-id: 997ec622-d1c2-4990-0c23-08daa094b317 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4NFX7nJpxFgxU417oIN2wqG311akvk2Q7b/oyLW5g5NxPY/OA8ZqNPk60+bGTmZHT0/w5kxbEX5cki8Qf6338SztOX3lkdsTAu1hKH4HNzg/KbaW5lXRTlv1w6WBE+hC6mvjVSSOaldABk5lB5QZkd1HVrWi1OJNOL8pEloJqwWHxVrcuxynXlJSJxGhQI+CidpNfVKp2Dsr9jmXNPupjLPdOCC4tiwxb+hQXZL2p6tvV2pOQoTDLaUQlNiCWZ7Bx0E7OZFznJCTfDCCvpzGyXkrJOILbSAsbzWegKVY/OQ2PZkBcRXRUaEy4KI1K/C99LHGhL1Hkzi0yLz8xeLt/nQE/V6FS0qX2pvoE8CAUfr4NX1bSknoJfoDRHziT5PzZ36kBu+Pv0T2suZtF8SKdiyRSTujbQehIGHkXgBKVWw/q8P7RiGc2TY97tuCB3ERkfC/Q2E4gp71linuYoM/DTaw9MoYrMP3gy8ivaS6K9rf/j72b6YWAM53MAN4pf0odkHaTT9zxsST4TN8rXHrrGzOigMHBdcewtdOYPYeetoYdSb1v8ANibxjO0C6jCfkkb1vjZWKefCgvdgnEvIYNt5c7YLKB4fdwIAxTJeJL+ELHs6yAo4BeMoLDjm4WG1uVG2Yh9qkLTT/O7WoHlPFIQcrVWB8eaDvHDAgIvPc00IkZPL7wdsN87PYV1UUpeDBNQyNugDhphu0oV08kNP5zi1rBHqIS2PQgs+67PquCpInpSnoaARRwDzaZzvPAap06TKWfnV8E8rkO6IzlhSji3qKuqZlKk8UXQlfzkB95E0KaUh3z+WMD3FXXCo/UaWWXFIx/vHPQ09G14Ug5gXrOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(396003)(136003)(346002)(451199015)(107886003)(122000001)(38100700002)(38070700005)(82960400001)(91956017)(76116006)(66946007)(4326008)(8676002)(66446008)(64756008)(66476007)(66556008)(54906003)(110136005)(5660300002)(2906002)(8936002)(186003)(2616005)(478600001)(83380400001)(71200400001)(6486002)(6506007)(53546011)(316002)(6512007)(41300700001)(26005)(31686004)(36756003)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d1hNUDhya2xjRGdrbnBNVmhMdExKUmYydjd4anVoNUNDVHNrL29vYWE4TVdT?= =?utf-8?B?WmZjVHZVbkt0SzVZVFNLaTIvbnYxd0duWkluTzFaTzdkUjdIVlRmZ3ZtYUpQ?= =?utf-8?B?bmM0VFNVaEpMblhNdnd4OVVkcXBDdXNqSjF3RncvRGlhV3VXTVFsNzdHSmRa?= =?utf-8?B?c0Y4MW8xU3lPZDFYSVYyRk85bTIwbUdwV3NyclpCY2N4dDNzcW8vaEpLMDE3?= =?utf-8?B?MUlQckdHT3lYRXVhMXlkb3E5R0graDA4aFF1MWVOUzZmRENocnZyck1CYU1I?= =?utf-8?B?N1dZZmlNTUluK3FJSDFxaDEvaWFTWG9mRzNGL0R2Rm5seGNNUHQrdXhIemxT?= =?utf-8?B?UDExMVJxbFhmRHZMc1U5OUU0NTROL1FMVEk1dlVQOHNaaEJNUmd4czFJcGFu?= =?utf-8?B?Vm5RSjRHWUwzRUFFbndGbGZ0ZXVjWEN0S1pDSS8zeWhwRTQzVE1CK3dOR2pU?= =?utf-8?B?NmtsdG5Cb1NQOTFzNysveUl4cDlWQ1YrSFgvekpIOTZ1bkk4bndjUHhGSEFq?= =?utf-8?B?OW5Pa2MrdUZjZG10cUIwNzlHQTFoaUtOa1pFTjhqd2hZNFhPTE90MS96U1pW?= =?utf-8?B?dnlsVm5wd3k5VnBOemlBYmJaUVFkemU2N1FVUEtXZlRPY1NjYmxadXd0eEhz?= =?utf-8?B?WkV6aVdONXFqNENYbjNQL25xdG9DTTVzUVNZM3VYYVQ3azFCZGN1QUdQQWpj?= =?utf-8?B?MWt1M0QrRWlxd2lmazBjZDZvM0g2Si9jZlVmVW5yZVJGSXRSQkRuU1JnSURK?= =?utf-8?B?dWtoYkY4emhPVXErTGR4KzFOZFBPckZyKzdYV3JLaHhtZDFpNkxxb3lUVkhs?= =?utf-8?B?enJLS2xHakhvSnVOVEEzN3R1UTFyOHZOMHpzVFIvT2d6TlhKczdUOUtodWps?= =?utf-8?B?ZEhOUnRDRFRvNzdZYnVneG9lQ0NjOFU2bUVOdk9JM1V6TWQwQmxacVIzL05J?= =?utf-8?B?SzlGZmY3NlA2ZklHN1BxVW9ma3FpaGhKR2lJY1dWWEdtVHdjN0dVUDRsQzhl?= =?utf-8?B?K1Y3SE1QS21ueVdDWFRxQjRhRWtwVDJHRDNXSXMrWGx5V0RtV3dXOUhlL0F5?= =?utf-8?B?ZHhHaGhPMzRKRytkRGxTVTk4bTZQZEpGQUNCV2NlOEQ0Y3BaQ2w0N21nWWpL?= =?utf-8?B?Vi9LNHdXUWlENUVEUWtIbVFZU3QyTTduc1VjUHE4ZXE5eVBrbzFPbzd4RXZS?= =?utf-8?B?ckJ5dWkzMGJmUWhWR0h6VEM2bUFPSUZJNUVXY2QzSE15aU5kbC9ET21ZOHF1?= =?utf-8?B?YWZ6TUZqMWxjckY3anEzRUNvR21ZNHpHa25Rd1ZPYTdzV2UwYndGUEZPR3lO?= =?utf-8?B?ZUtWREFQbjcreWNQOTZsRkw5Z1NoZFY3c2JwdENWdHRHam5xQ0RTcnIwdC9Y?= =?utf-8?B?NlVUUlEvUHlYeVVBdFVKMmpTZHN6aDFDaHZZQkFkdjFoQ1o0aW5RMVBDRTBD?= =?utf-8?B?WnFENlBOdTFva0Y0bzFMZ2NJUDFiUkpTY1ZBN1FKWml3eER2azZpc1Z4NkFj?= =?utf-8?B?eEFzU3RMRjhtdklidm5nTHEydXE2NDVUN2JRM0c5WkFMWFpuTk5nbTFhbXV0?= =?utf-8?B?b3FUVkcyR00zUGFxeW5ESUE1blVURGJINW1iMjVGcGRxa2lXSGJZa0QyVlJp?= =?utf-8?B?TGkySHpGQi94dFVjNjlocnRHV1g2MzVXWlpkRW9MblBkeHJCRzBCSm95T28x?= =?utf-8?B?SWMya3YyNFJkNG1EcE1naHhFVTFYb3dhY3JSZUh0MmtuU1Y0a0VlU1BvRk1F?= =?utf-8?B?QnJSVWUxUDJFWk9ZMGljZHVtWU5laXNYZ0RSbHVxbGFxaUZkdUdDTTZkb1hL?= =?utf-8?B?U09Ec1FqWWZQeFMwM0FIRW1ZRVcrVXFLNWg1ZEdWOEZQaThnUHRCQWNVRHhH?= =?utf-8?B?NCtENzVmZThRR0ZFZVVjTkYvNTI2ZVMydTM4Z2I4ZzdHY09UZVpJajdwOU4z?= =?utf-8?B?OWJnWVlFeXBqMVJHQUZRU3FTc3VialZObWRSdDg2MnArT0xaamNZUmdKMDhr?= =?utf-8?B?WTdSR1JkSVpYdFowdjEwRmZVTUxxMWd3QzNEazhOckJkQUtGeWdMQ0ljcjFn?= =?utf-8?B?UjMyd29xTGxEbnBHNnpYc2FSMUZxcnVVTnpweG04Y2g5a2pWZU8xb29VZzlE?= =?utf-8?Q?91rW62N1VZqnGwLqzgiOXeAsU?= Content-Type: text/plain; charset="utf-8" Content-ID: <37227DF63CAEB44F919FCA6E694E4C25@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 997ec622-d1c2-4990-0c23-08daa094b317 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 14:29:34.6113 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bk6lIq2buOeXZ+dw2NyLf1vINgEmQJ85h0aNdwpxkn0se246cvbiAG9lDuv554+6LrMkB07jSlybBIC57TcC4lOJTOGnjlMJJ37++CinaB8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5416 T24gMjcvMDkvMjAyMiAxNToxNCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBGcmksIFNl cCAwOSwgMjAyMiBhdCAwOToyMjo1MkFNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IFdo aWxlIEkgd2FzIHN1c3BpY2lvdXMgb2YgdGhlIGNvbXBpbGVyIGlzc3VpbmcgYSBkaWFnbm9zdGlj IGFib3V0IGFuDQo+PiB1bnVzZWQgbGlua2luZy1vbmx5IG9wdGlvbiB3aGVuIG5vdCBkb2luZyBh bnkgbGlua2luZywgSSBkaWQgY2hlY2sgdGhpcw0KPj4gd2l0aCBhIGNvdXBsZSBvZiBnY2MgdmVy c2lvbnMgb25seSwgYnV0IG5vdCB3aXRoIENsYW5nLiAoT2RkbHkgZW5vdWdoIGF0DQo+PiBsZWFz dCBvbGRlciBDbGFuZyB2ZXJzaW9ucyBjb21wbGFpbiBhYm91dCB0aGUgdXNlIG9mICctbm9waWUn IG5vdyB0aGF0DQo+PiB3ZSBhY3R1YWxseSB1c2UgJy1uby1waWUnLikgRmlsdGVyIG91dCB0aGUg cHJvYmxlbWF0aWMgb3B0aW9uIGluIGFsbA0KPj4gY2FzZXMgd2hlcmUgdGhlIHZhcmlhYmxlIGlz IGNvbnN1bWVkIGZvciBjb21waWxhdGlvbiBvbmx5ICh3aGljaCByaWdodA0KPj4gbm93IGlzIGV2 ZXJ5d2hlcmUpLg0KPj4NCj4+IEZpeGVzOiBlY2Q2Yjk3NTk5MTkgKCJDb25maWcubWs6IGNvcnJl Y3QgUElFLXJlbGF0ZWQgb3B0aW9uKHMpIGluIEVNQkVEREVEX0VYVFJBX0NGTEFHUyIpDQo+PiBS ZXBvcnRlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0K Pj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gLS0t DQo+PiBBcmd1YWJseSB3aXRoIGFsbCB1c2VycyBvZiBFTUJFRERFRF9FWFRSQV9DRkxBR1MgdXNp bmcgdGhlc2UganVzdCBmb3INCj4+IGNvbXBpbGluZywgdGhlIG9wdGlvbiBjb3VsZCBiZSBvbWl0 dGVkIGZyb20gdGhhdCB2YXJpYWJsZSByaWdodCBhd2F5Lg0KPj4gQnV0IGlmIGFueSBjb21waWxl LWFuZC1saW5rLWluLW9uZS1nbyB1c2UgYXBwZWFyZWQsIHRoZXJlIHdvdWxkIGJlIGFuDQo+PiBp c3N1ZS4NCj4gSXMgaXQgZmVhc2libGUgdG8gaGF2ZSBjb21waWxlLWFuZC1saW5rLWluLW9uZS1n byBpbiBvbmUgdXNlIGZlYXNpYmxlDQo+IHdpdGggd2hhdCB3ZSBjb25zaWRlciBlbWJlZGRlZCAo ZmlybXdhcmUgb3Iga2VybmVsIGxpa2UgYmluYXJpZXMpLiAgSQ0KPiB3b3VsZCBleHBlY3QgdGhv c2UgdG8gYWx3YXlzIHJlcXVpcmUgYSBsaW5rZXIgc2NyaXB0IGFuZCBhIHNlcGFyYXRlDQo+IGxp bmtpbmcgc3RlcC4NCg0KQXMgSSd2ZSBleHByZXNzZWQgc2V2ZXJhbCB0aW1lcyBwcmV2aW91c2x5 LCB0aGUgZW50aXJlIHZhcmlhYmxlIGlzIGJvZ3VzLg0KDQpKdXN0IGJlY2F1c2Ugd2UgZG8gaGF2 ZSBzZXZlcmFsIHRoaW5ncyB3aGljaCBhcmUgYnVpbHQgYXMNCm5vbi1mcmVlc3RhbmRpbmcsIGRv ZXNuJ3QgbWVhbiB0aGV5IHNoYXJlIGEgY29tbW9uIENMRkxBR1MgZW52aXJvbm1lbnQuDQoNClBJ RSBpcyB2ZXJ5IHNwZWNpZmljIHRvIHRoZSBpbnRlbmRlZCB1c2UsIGFuZCBibGluZGx5IGRpc2Fi bGluZyB0aGUNCnN0YWNrIHByb3RlY3RvciBpc24ndCBzYWZlIGVpdGhlci7CoCBJdCBvbmx5IHdv cmtzIGJlY2F1c2Ugbm9uZSBvZiBvdXINCmZyZWVzdGFuZGluZyBlbnZpcm9ubWVudHMgaGF2ZSBn b25lIHRvIHRoZSBlZmZvcnQgb2YgYWRkaW5nIHN0YWNrDQpwcm90ZWN0b3Igc3VwcG9ydC4NCg0K LWZuby1leGNlcHRpb25zIGlzIGZ1cnRoZXJtb3JlIGJvZ3VzIGluIENMRkxBR1MsIGFzIGl0cyBh IENYWEZMQUcgb25seS4NCg0KQW5kIG5vLCB0aGlzIG1lc3MgY2FuJ3QgcGxhdXNpYmx5IGJlIHVz ZWQgZm9yIGEgY29tcGlsZSBhbmQgbGluayBpbiBvbmUNCmdvLsKgIEZpbHRlcmluZyBvdXQgYSBu b24tQ0ZMQUcgZnJvbSB0aGUgY29sbGVjdGlvbiBhdCBldmVyeSBjYWxsIHNpdGUgaXMNCm5vbnNl bnNlLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:30:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412659.656045 (Exim 4.92) (envelope-from ) id 1odBbD-0003n0-69; Tue, 27 Sep 2022 14:30:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412659.656045; Tue, 27 Sep 2022 14:30:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBbD-0003mt-3P; Tue, 27 Sep 2022 14:30:15 +0000 Received: by outflank-mailman (input) for mailman id 412659; Tue, 27 Sep 2022 14:30:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBbB-0003lE-Cv for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:30:13 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4d071f9-3e70-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:30:11 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id n10so15247246wrw.12 for ; Tue, 27 Sep 2022 07:30:12 -0700 (PDT) Received: from [192.168.8.100] (94.196.228.157.threembb.co.uk. [94.196.228.157]) by smtp.gmail.com with ESMTPSA id a5-20020a05600c224500b003b4fac020c8sm14022447wmm.16.2022.09.27.07.30.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:30:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4d071f9-3e70-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=4qLPtvUWN+AfrLhyVfZ91N3yZnBEIddv2rouQHzCYLA=; b=LSvdUNSjYwsgaB1ny7A29I06dZuPVvZasJ53PSj2IRqPVKq1ohmeHh9Z6CkkhwtJQf 85O+gH6Z/IdRrelbEU0k1mMXu+6fxxn2WMN9doOp+loYLAuRiKZyPsNuFdcRNJn8dsQ8 lRGEVEdnN3VzNzjA7sb4HgBPlDNeuOXWP9VvdICO7KXryKqpFA3ehg94nCKxwk0Gpl0X I+5MDhB4PGTBCY6571kzJwU8c1BDIDcYu4PmD8hWvxk6btQMMwVeIkdHwp1kUu0xXGSI v+WsS2ry+SxZHb8HRxtcqqy322vcXEZOmSjORm3FjfTCAcEhB2XwEz0Q5vPUPRONX/Nv BdwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4qLPtvUWN+AfrLhyVfZ91N3yZnBEIddv2rouQHzCYLA=; b=yKbPaVmI3ra8alejMA823aPQ0GoyAy+fW4kgd1y+MbwOgFvSX7Jaker6hl9nlH4/z+ i6L+U8TaqJ09rmQSx2WkedvMN4ovLoJctEPGJTCFBzDbjGNS4hr25ZB3QO1uiz6IEmax VCbe0CvqE3h+kyp/fdeJKfcdTRVErK53Y/rYcg5AvFGEhpDT55ks//fgiOFO2UWRHH0g dqhFoRmh+8+39ki1P4von0wz4zGOuMgmSy/xLQtQGTfOPWg4t63K1QnWDYWJJvb5/aMR +TCYdLmfg4pd/ke33XwVD+pfy5z4F6ub8U5b4djJ8ThBlD66ArjEV4bBxPexHC9Fm9X0 5X6w== X-Gm-Message-State: ACrzQf3434KnLZpYDPQZ0qPfkgle62jqWJ/bMgNe/1oABtuc9a0xiHuo 2HhdNiJF9OsucapBGjsAgBkZbl+m8Zw= X-Google-Smtp-Source: AMsMyM7wIF7Q/yLHfL4qpto23LFzYlOodjB18WlyAhMXTZyo5ET7oeG7w+FroLjnnh5vWx2LP52ZzQ== X-Received: by 2002:adf:f347:0:b0:22c:be39:4e38 with SMTP id e7-20020adff347000000b0022cbe394e38mr2077945wrp.151.1664289011650; Tue, 27 Sep 2022 07:30:11 -0700 (PDT) Message-ID: <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> Date: Tue, 27 Sep 2022 15:28:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info Content-Language: en-US To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> From: Pavel Begunkov In-Reply-To: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Paolo, On 9/27/22 14:49, Paolo Abeni wrote: > Hello, > > On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: >> struct ubuf_info is large but not all fields are needed for all >> cases. We have limited space in io_uring for it and large ubuf_info >> prevents some struct embedding, even though we use only a subset >> of the fields. It's also not very clean trying to use this typeless >> extra space. >> >> Shrink struct ubuf_info to only necessary fields used in generic paths, >> namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And >> make MSG_ZEROCOPY and some other users to embed it into a larger struct >> ubuf_info_msgzc mimicking the former ubuf_info. >> >> Note, xen/vhost may also have some cleaning on top by creating >> new structs containing ubuf_info but with proper types. > > That sounds a bit scaring to me. If I read correctly, every uarg user > should check 'uarg->callback == msg_zerocopy_callback' before accessing > any 'extend' fields. Providers of ubuf_info access those fields via callbacks and so already know the actual structure used. The net core, on the opposite, should keep it encapsulated and not touch them at all. The series lists all places where we use extended fields just on the merit of stripping the structure of those fields and successfully building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which again uses callbacks. Sounds like the right direction for me. There is a couple of places where it might get type safer, i.e. adding types instead of void* in for struct tun_msg_ctl and getting rid of one macro hiding types in xen. But seems more like TODO for later. > AFAICS the current code sometimes don't do the > explicit test because the condition is somewhat implied, which in turn > is quite hard to track. > > clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected > before this series, and after will trigger an oops.. And now we don't have this field at all to access, considering that nobody blindly casts it. > There is some noise due to uarg -> uarg_zc renaming which make the > series harder to review. Have you considered instead keeping the old > name and introducing a smaller 'struct ubuf_info_common'? the overall > code should be mostly the same, but it will avoid the above mentioned > noise. I don't think there will be less noise this way, but let me try and see if I can get rid of some churn. -- Pavel Begunkov From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:31:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412667.656056 (Exim 4.92) (envelope-from ) id 1odBcQ-0004Uj-Im; Tue, 27 Sep 2022 14:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412667.656056; Tue, 27 Sep 2022 14:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBcQ-0004UZ-Dy; Tue, 27 Sep 2022 14:31:30 +0000 Received: by outflank-mailman (input) for mailman id 412667; Tue, 27 Sep 2022 14:31:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBcO-0004UQ-IS for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:31:28 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 118e6246-3e71-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 16:31:26 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id z13so21130231ejp.6 for ; Tue, 27 Sep 2022 07:31:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 118e6246-3e71-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=USA12OvBqFFCug9e6pk0NZ0mYiTxVTCqTe5Cokwlj8Q=; b=DgxxJIp0Ui+06Gdr05DgPM8araftPMFAWUPfRWhpipYyc8g/mVq+jMf9JuHnWrXbwD Hwz2lTBs426Z+oRfum4leJiye8V/veDeoTjxrgGnfsoRmTW3Cvt8l5VlJgTPR5v21lDv H2oA02TuXB4oPkkaeQAKbOQcb6MC2dkAx1uBcxjxplYz/ejLhE1OY7wbSXDDnvGYVvaD yRHM8uwNXTdr6Irluj+yqvSqLsmZHJtJj8UXSyOtaWGXzYwC57XrzqQtwbFRYzCIKe28 fkolafbXId6dBTs/vq9Jfz6AUguKJ/ota+IrkvlGV+NvjEw0yGeFB9i4wESoc+YKoQ0B PL1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=USA12OvBqFFCug9e6pk0NZ0mYiTxVTCqTe5Cokwlj8Q=; b=Xs11C2vjf6Whw3GwzHNu+RJKTHf3uJnu2cPH5RDY4XujuJjltGUHdabZrzQLC6mrAi fbw6Qq3H5/qpFUSFdXnj2ngM+q+qP0BeV7AgLzgAAloPW0/gI9yMX708AXH1KjpET4pn d/e3l57Kc3VzkF+b7YApjqA4Mv+V2wzHOexH8FjkFAHu5LjR2BLRkEPXSUdpbdaZCfUH h2JtJOFIcnZlZyI0BTewnEwmdsXHgi/99TBEYX+ExDoW1xZIGW2xakOGN4Mv2QR6DPCm QorR0Byf93DhWaxMM5iBDtbBFpu2aaTDd9520/KV3nNYqIxgye6HHDXZre8ETwMFgxxg CF+A== X-Gm-Message-State: ACrzQf3g+QiTVh1W0icM5m2zsBCx2TUGGTUHvuMRw3/4nwgREU5aktPP zKDDLrnGOHvMQJ6u+rLoxd86r6ptRl5AU9Ppih2ULQ== X-Google-Smtp-Source: AMsMyM4qPsnXgcfncnTEY5XpyE/BkKuc9LmQ718moFpYzsHHdyLxV5RHv6NB+RkEdx89hBEdLidyIUBHiPds0PgWJB8= X-Received: by 2002:a17:907:2d8e:b0:783:8d26:645 with SMTP id gt14-20020a1709072d8e00b007838d260645mr8466512ejc.535.1664289086480; Tue, 27 Sep 2022 07:31:26 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-2-carlo.nonato@minervasys.tech> <1369a435-ad92-3bbd-60e4-27c1e49c1bc9@arm.com> <467b204a-1aed-4cd7-b401-8ff01b8d343a@suse.com> In-Reply-To: <467b204a-1aed-4cd7-b401-8ff01b8d343a@suse.com> From: Carlo Nonato Date: Tue, 27 Sep 2022 16:31:13 +0200 Message-ID: Subject: Re: [PATCH 01/12] xen/arm: add cache coloring initialization To: Jan Beulich , Wei Chen , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Jan, Wei On Mon, Sep 26, 2022 at 9:42 AM Jan Beulich wrote: > > On 26.09.2022 08:20, Wei Chen wrote: > > On 2022/8/26 20:51, Carlo Nonato wrote: > >> --- a/xen/arch/arm/Kconfig > >> +++ b/xen/arch/arm/Kconfig > >> @@ -131,6 +131,22 @@ config ARM64_BTI > >> Branch Target Identification support. > >> This feature is not supported in Xen. > >> > >> +config CACHE_COLORING > >> + bool "Last Level Cache (LLC) coloring" if EXPERT > >> + default n > > No need for this line, btw. > > >> + depends on ARM_64 > >> + > >> +config MAX_CACHE_COLORS > >> + int "Maximum number of cache colors" > >> + default 128 > >> + range 0 65536 > > > > Just curious. Why select 128 as default vaule here? Is it a classic > > implmenntation for Arm64 cache? And the same question for the upper > > bound 65536. > > Going beyond that: What is the meaning of the user picking 0 here? > And isn't 1 merely mapping to the allocator we have, i.e. the > CACHE_COLORING=n case? IOW shouldn't the lowe bound of the range > be (at least) 2? To answer both: I used "range" for two reasons: - to forbid negative numbers. - struct xen_arch_domainconfig can't be modified freely since it must respect some static build assertions on its size, which means that I'm bound to uint16_t for the "num_colors" field (see patch #2). Also, looking again at this, the range should end at 65535. 0 and 1 maximum colors aren't really meaningful as Jan said. 65536 is just a "big enough" number that shouldn't be possible to ever reach (it corresponds, in "common conditions", to 4 GiB of cache. See docs or below for the formula). 128 is also a high value since using 4 KiB pages and 16-ways cache, it implies a 128 * 4 KiB * 16 = 8 MiB Last Level Cache. Remember that this isn't the actual number of colors of the platform. It just needs to be >= the actual value (which is computed from the probed LLC way size or the command line provided one). > Jan Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:31:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:31:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412669.656067 (Exim 4.92) (envelope-from ) id 1odBcY-0004nK-Pm; Tue, 27 Sep 2022 14:31:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412669.656067; Tue, 27 Sep 2022 14:31:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBcY-0004nD-MA; Tue, 27 Sep 2022 14:31:38 +0000 Received: by outflank-mailman (input) for mailman id 412669; Tue, 27 Sep 2022 14:31:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBcX-0004UQ-OI for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:31:37 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1784c17c-3e71-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 16:31:36 +0200 (CEST) Received: by mail-ej1-x633.google.com with SMTP id r18so21068195eja.11 for ; Tue, 27 Sep 2022 07:31:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1784c17c-3e71-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=dZ56z9a8FzgaIJUBYRwqk8uPrh9dSpVkrxk/aa13/Ic=; b=xaYDpM6WnqNW4yy2LytLppAhl5HzVN2cGsJdqYg4+DB+G0FP2iqs6/htNpnul5d/4y IViPVsq9JWfQRwVM20CKVCqPt/GAenxtt37gpp4zFQsxz2aJp+JTCFi6JMLsAE8LnMk5 9ifcDprk82QIXoE7GMR67IBCTRxh8gFIFIzZz4iuXScUILhJU2Dc8FlKAc1DqrQCEp+9 uJ7eFftL4L2k+86Gq5RgYoM7KchnComCkkObn1zjDJROsfX73H7Cobgma4lDx4CbnoCe fDRkCuZBEUEeAxM93nkev5EsAzyqVuZAKL/wELe91L5esrcV+y0VY0x20mcFYfHQy2qa RkRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dZ56z9a8FzgaIJUBYRwqk8uPrh9dSpVkrxk/aa13/Ic=; b=06+Tg3eDq6bA8PJTB+iKKobj/axBtLSdtu4MKm+ctpggycnEJIXXlyf54vFxIc2jGc Vmyt8fUfCSn7jLDsbtXB3ZHgQoni9o8by0sE0NFuBN4RA60xiRjVrlOjkbRGHrvvFwS9 Ozt4EwAz5eK2OVgLKQ5Yjt15NRdstAtOvTVk2HJ3aAU2uHzOESj5XY0SUG2s0LJyohQU QiEUN0mqcVpDQgn240Dzcd11uaxrOPb/fQm7ljiMR98sZ4HOWnSwt7a0v/DbnZpXgZrz jle0KCtu3zRXcT9XeFiIO9WpPmWr7hZe/8ktOq7VNOzk3QAA1jmlmdOkbRZ/aDU9YMfS SV+A== X-Gm-Message-State: ACrzQf3y3TYn9+0JYSVBR+/O6J15GC2bgnS9sOBDZL05r4ZA9Ius4Xye WDBSiWlFbxMujpYiV5Z63a/iCxbh8OZsrFyiGtqZ3w== X-Google-Smtp-Source: AMsMyM67WLR/RBOYrtX9tTm2CbU91KPw5Nn33glQYdd1MYYd5bTz+3mSiaA3Ptg/4w2i43F2n9B7vNcCj0dH/kNbrUc= X-Received: by 2002:a17:907:9605:b0:6f5:c66:7c13 with SMTP id gb5-20020a170907960500b006f50c667c13mr23456389ejc.66.1664289096627; Tue, 27 Sep 2022 07:31:36 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-3-carlo.nonato@minervasys.tech> In-Reply-To: From: Carlo Nonato Date: Tue, 27 Sep 2022 16:31:25 +0200 Message-ID: Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains To: Wei Chen , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Wei, On Mon, Sep 26, 2022 at 8:39 AM Wei Chen wrote: > On 2022/8/26 20:51, Carlo Nonato wrote: > > +int domain_coloring_init(struct domain *d, > > + const struct xen_arch_domainconfig *config) > > +{ > > + if ( is_domain_direct_mapped(d) ) > > + { > > + printk(XENLOG_ERR > > + "Can't enable coloring and directmap at the same time for %pd\n", > > + d); > > + return -EINVAL; > > + } > > + > > + if ( is_hardware_domain(d) ) > > + { > > + d->arch.colors = dom0_colors; > > + d->arch.num_colors = dom0_num_colors; > > + } > > + else if ( config->num_colors == 0 ) > > + { > > + printk(XENLOG_WARNING > > + "Color config not found for %pd. Using default\n", d); > > + d->arch.colors = xzalloc_array(unsigned int, max_colors); > > + d->arch.num_colors = set_default_domain_colors(d->arch.colors); > > + } > > + else > > + { > > + d->arch.colors = xzalloc_array(unsigned int, config->num_colors); > > + d->arch.num_colors = config->num_colors; > > + if ( config->from_guest ) > > + copy_from_guest(d->arch.colors, config->colors, config->num_colors); > > + else > > + memcpy(d->arch.colors, config->colors.p, > > + sizeof(unsigned int) * config->num_colors); > > + } > > + > > + if ( !d->arch.colors ) > > + { > > + printk(XENLOG_ERR "Colors allocation failed for %pd\n", d); > > + return -ENOMEM; > > + } > > + > > + if ( !check_colors(d->arch.colors, d->arch.num_colors) ) > > + { > > If we add xfree(d->arch.colors) here for non-hw domains, is it possible > to make this function have a complete fallback process? And I know > currently, this is handled in domain_coloring_free. Yes, you're right. Added. > Cheers, > Wei Chen Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:32:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:32:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412674.656078 (Exim 4.92) (envelope-from ) id 1odBcu-0005ON-1R; Tue, 27 Sep 2022 14:32:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412674.656078; Tue, 27 Sep 2022 14:32:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBct-0005OG-UM; Tue, 27 Sep 2022 14:31:59 +0000 Received: by outflank-mailman (input) for mailman id 412674; Tue, 27 Sep 2022 14:31:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBct-00058c-0B for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:31:59 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23f216da-3e71-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:31:57 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id y8so13460138edc.10 for ; Tue, 27 Sep 2022 07:31:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23f216da-3e71-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=00DvuJmWFLPLFHdJ5ZJ+TGf+5xWCHP9wfe9z49M2FpU=; b=vF6Gi35qrnfDePTtXu2iQlFSb9B64+6/0qq6HDEdBpKW2wciCLjFh59f386Pji87cn 5RAPt5NFSL+N/tFvCddWau30INsn/4L3G7o4ItoVndU4cIHQYWtK7fxwbzxCsTUp/GT6 lgFcp4J+GeHBrMk/Hb5+XjgEj92N8VXYmdElAlYpD6U/sLdTKxVuGCwe1BWMjQHEzH8X 1j0vcM48UIiLs7lvh3NIh6pSbit44evq+W6MGbbAVoLnGSaykjDFkTSAvgZov9YygF37 P3lDvwR4NqrJDylX9XWvcj5Mv4xNiNd8Z4YxsxBz7JVi6z+L2rW9tih9edGCj/k5vt2s 6jhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=00DvuJmWFLPLFHdJ5ZJ+TGf+5xWCHP9wfe9z49M2FpU=; b=tHM/KXGyuPfDzYW3IgTHED+HtM68spQwwtTcSN1HMteoklnnlHAITy4RwuZs2kmhAV yzh4O7cbwIt1tsUyI6+Z5oS4e5+8iyivwGf1eendIxggNuM+COVaf1CLqScwTzgmfZrG wlwEx6DrzQAbkUIcgeZqDdp3bhc+Ak7XdijU52XgDybqFtVbdty0Lb6G1PcgMs/uSAQ8 U2fwkrnyzDa2b/c7Yep4nzrZpu9Q+pYHNeoFz2i0FHeTFw6YIVn0KwmBx6f7X43w0p+Y oxmz19jpmQ8AwLnGccfw8r5/lstmYvarY4wb6nuWFAyBwN2W+5/rEuOGySbbIOf1rqEb pPqA== X-Gm-Message-State: ACrzQf1Irlu91hVTf8ODKBYuH+8jp+xUkHNe5k3TFtxs+X1Bxt1+biM/ rI2a0Nu17uh1XJBa3G0Az43kDfzQJzSvycxfGIO1zw== X-Google-Smtp-Source: AMsMyM4wUJ6LYBYgv1FWXqehgQuJ4PXMZKY5f4v6aOYxr0Wv8nQIt8BH6gy5U4+c+VqXBPwYZI5bDSt8/Jwz9ZGsteU= X-Received: by 2002:a05:6402:2751:b0:443:d90a:43d4 with SMTP id z17-20020a056402275100b00443d90a43d4mr28379608edd.368.1664289117843; Tue, 27 Sep 2022 07:31:57 -0700 (PDT) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> <93471d92-bc61-56fd-5b52-413303d35da1@suse.com> <8ba1ede9-cd8c-01ec-939c-e0915d7c18b4@suse.com> In-Reply-To: <8ba1ede9-cd8c-01ec-939c-e0915d7c18b4@suse.com> From: Carlo Nonato Date: Tue, 27 Sep 2022 16:31:45 +0200 Message-ID: Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen To: Jan Beulich Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Hi Jan, On Mon, Sep 19, 2022 at 10:38 AM Jan Beulich wrote: > > On 16.09.2022 18:07, Carlo Nonato wrote: > > On Thu, Sep 15, 2022 at 3:25 PM Jan Beulich wrote: > >> On 26.08.2022 14:51, Carlo Nonato wrote: > >>> @@ -218,6 +221,28 @@ void *__vmap(const mfn_t *mfn, unsigned int granularity, > >>> return va; > >>> } > >>> > >>> +#ifdef CONFIG_CACHE_COLORING > >>> +void * __vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, > >>> + unsigned int flags, enum vmap_region type) > >>> +{ > >>> + void *va = vm_alloc(nr, align, type); > >>> + unsigned long cur = (unsigned long)va; > >>> + paddr_t pa = mfn_to_maddr(*mfn); > >>> + > >>> + for ( ; va && nr-- ; cur += PAGE_SIZE ) > >>> + { > >>> + pa = next_xen_colored(pa); > >> > >> This may alter the address, yet the caller expects that the original > >> address be mapped. I must be missing something? > > > > If the original address color is assigned to Xen, then next_xen_colored() > > simply returns that address. If this isn't the case, then you're right: the > > address changes to the correct, colored, one. The caller should expect > > this behavior since this is the colored version of vmap, the one that takes > > into account the Xen coloring configuration. > > That's (to me at least) very surprising behavior, and hence needs > properly calling out in a code comment at the least. > > Personally I'm not convinced of having a function with this behavior, > and instead I think the normal vmap() should do. As long as you're > only allowing for order-0 allocations, that shouldn't be an issue > anyway. You mean creating an array of colored mfns (I mean with a colored machine address) and passing it to vmap()? Am I understanding you correctly? This is the only way I can see to use the original vmap() and respect the coloring configuration at the same time. But isn't it a waste of time and space to create this array? > Jan Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:32:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:32:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412685.656088 (Exim 4.92) (envelope-from ) id 1odBdU-00067m-9I; Tue, 27 Sep 2022 14:32:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412685.656088; Tue, 27 Sep 2022 14:32:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBdU-00067f-6W; Tue, 27 Sep 2022 14:32:36 +0000 Received: by outflank-mailman (input) for mailman id 412685; Tue, 27 Sep 2022 14:32:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBdS-00058c-8l for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:32:34 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38c620d7-3e71-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:32:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8219.eurprd04.prod.outlook.com (2603:10a6:10:24d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 14:32:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:32:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38c620d7-3e71-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PmsAc0ieuQllPzZnxd9c67Yj70x59m4YKkmr7khcBYjEfchZFxnaIosVBMGn3jGeDXssJZiTd77aabEEqcwkB43pTITAFTY6zb3j8L0giLGdhEtwMkdrDuXU75lvH6UUL3i4OPzc4hxeRbF6yOc+dCWlUJLaD/pHg5VSNxAwwEOdRhx3p+1X0SvkjfkALewUr18hIWjwD5QNQ2/H1rPKbAutVUAt2eATQh+fuyPe7BF9GFitnx8PWB93mzw6q8Kvo1NKiI4ImsbR7jobXG0x8e0aHzikvxQr8wqJR8ooXUK6IIhAI8jsDCWLJTtim7TXM/OCdk4PvTn6KIwMAYrbDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Ku4XqXJ2nme3DFlTvWIo5FF6eJDb7Mlwl+qeR5f+Sc=; b=Vte/a+N972z8UO5MX0nmmLz+JXGYIsqEbSIQq0D/GTwiAiuz/TE5s40iBJtV60+cMGHtaYsVG0oJj08niu7ahy7GYU7E3UaKSXP84Y4s4WZPQUlkKvX2CWGKsBmNWwtcO7R5+iyGTvKb7gC8TUdx4T2EjiBB1eBcxkfjat6DedKPcZ+jKjkUb+Q9WownoMWRFrmff222ZqMedXLhF8NCtbBKr5fkntGk+ymiDvF62dBVQXKmSe2tkbRp1K/TboWSHp9PRkqb/91G89MtbG7JaIc5CTtEpNr4SX7+aSU9xCOyEdiIsyd6LsK+BfptY3+BBQncjMlGr3kNhyfljM1yLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Ku4XqXJ2nme3DFlTvWIo5FF6eJDb7Mlwl+qeR5f+Sc=; b=h9/8uvTeufl5ajjASBYDB7k4fHjeToHZvguNwRdGe8FX0YHuBlENqTHIVFDpl0Mr1ov63P/sfap4eyNeLYJjQMpJavNZffz7h+U7UM60Z3b5dg4vKzUGHJV3qaOF1w1bWGs5JjIBGCd91DkHG8X2cgkUHswUBC3aFYG4tWlWQKEe5HKmrWGsXe0xgscZ/FSxaG8HMbvk1nrHgTAbXbj6cNLkHbmYB5zP59Uk1tsEJGp1uuIinmycNDBT1xKn7hrM1Eh9yZ/J5K0TFQ7mJZ76pYVOcnv7Qsrbd05KsjCv7yA0xTvQJBBbNuRtL+WaIdIrdvKUeZoPKmV7juzWY0I5/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 16:32:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 75f9f628-7234-4afe-258c-08daa0951adc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23uMHaaaE2e9/6r0/QjzF0JG3/R7l06G7u56yBo69CqxguxNRmmsDgdWSpF4onlJl1y6M6A0X1dfIvR3GLtzXITSZMF2+oD097sv7jBGmGm5ZcrrcD8tbwR/rxBS38yxj5hj8XG8cOlbH/3sQrFGOedoCkiSjPRfitm74czG5edoMTjlUhzhU3l3bnXgUoEO34jX1m+8Yg0XbfJaDz3G+clkt8TIS/wLYDdyiDC/zrgkt15rjBQWWqRNTnS6LjO2ipvgupKUlap7udAYtJ29p7fhznrlHivyKpht9IObHTazleJS/7DotAsRMm49iaKocZBvpei0UQyAhtXlZMpAW+6RN4UPFBo1xcrldwUcSGaEj3Eb+ey2DSuSf9yfOkf4rqxP4LIt8nOhUopANe8JZXuFS8+vsgTvo/sjkz40/e0TzLW6hPoisM0Pqwp3hsnk9HzoDSBzlcOiJIPLgsFgOLHZ96koATK5nks7GgqoXlViXO860IE2TDEIwz8nbWdJswgpotQlMQs7DLHcWgE7WOe1fKeTgOLaUMsUM7vSQ10CbEGC3ekXpzxTyHnq69tm2lMw5/rldXV4kcqzTUQw15yVj75a3whMMr6L8aNqPVHMAEQwawr5TRRl+7Wa6kQiAcqigRYK59ZtDXsClIuJ19j9TRt1bm2l3vlZIVCd0b61OVEcrkpS4NE2ElQkew2ofBnD1xJY4JNQ25DvSzv69EP4cQ/XjkjFG8W0HD+wPeA/5qBn8HD5Ews/34gAJVOCNClCqo1mEXk+gOq7slFuc+9xEbFyLY9vM390VhAzH2I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(83380400001)(31686004)(186003)(6506007)(8936002)(41300700001)(38100700002)(2906002)(2616005)(316002)(6486002)(6512007)(5660300002)(478600001)(26005)(36756003)(31696002)(4326008)(8676002)(66476007)(66946007)(66556008)(53546011)(6916009)(54906003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm5pZnNjNHg1ZHhud3J1R0FQaUoxUXVDbzNVRXRobnpIM3hmS0VoN2lHbHZz?= =?utf-8?B?TW5QMU9FcHFSVjhNVVMxT2VDa3VBQjlzbWNRS2k1bHZmVzBPTFQ0dEp5UVJD?= =?utf-8?B?U2N6WTYxbE04dVpZZEp3VWh0WElLdHh4YzZRL1VtS0JVZ0NLVTBtMytVQTR6?= =?utf-8?B?dGFITFdNQWg4bXFtNnFEOHNWWkthWnN3UE83dkJMUTRaUmZGc25HVklqRUJt?= =?utf-8?B?UFJmcUZuTUE1RVpXbFpVTVoxWUpodjFwWWFOQTV2M1BncG15NWtWdUJmNDNr?= =?utf-8?B?VDVnTm1iaVFyUVZnb1JHRXdFYkR5Y0hzOElkMjVEalg5cGYvWmMxVkF3VW9j?= =?utf-8?B?QkRUdmdNQlA0bk5wbmlDUmY1VTRsK2E0bGtWN2pkZmswRzI4VkhKeUJtcXJ1?= =?utf-8?B?Y1ZMT2krQmltSlZ3a3Awd1BhZi9IczNZRGZkT01nZ25OWk9sQXNMYTZucWM4?= =?utf-8?B?Q3RGOG5sWVFab1E4Z1BPU3dlQzJTQjZUOGI5WVpOUlA1QXF4Y1Uzb2Mxc3BM?= =?utf-8?B?cWY5WE5Bd3BDSitWYnBYZG5JdG5ldjZHOTRFaWtHZEhqQXNzUDF4T1ZKU0tm?= =?utf-8?B?aklsU2dQMUhWRlpSL0lUTHBYNHM4cTN5QklualJMbzJPVTRsWlBGNG11Yitx?= =?utf-8?B?QXdqeWp0UFJoeEFlSlpWUWdLcGo4Mnc2ajN4bnoydms0RkZCV2lvN0d6Tjdm?= =?utf-8?B?dldZWWt4a2FLbWwxS1VWTk13VzlINGd2MTIxMWhPOFlhWG5JeWt6aHJiYkhX?= =?utf-8?B?NkkwSzNabjFkSTlmQ2xLN2oreitUVVkvMUJ3ZnlqSlU4UklINHRKVkRiRXR6?= =?utf-8?B?MCtJTzlYUTJWNWNEWmNvTktjWFNZbW40Q01ZMnRZT1lNTzF1dGI0SlgyZUpG?= =?utf-8?B?end1cTFTdHRvWWp1Y1NyNkFVREUwVkdTd2J2MThnWDJBbjNVM3EzcWJPRVlK?= =?utf-8?B?bVhjb3N2eEMxY2hLWEJlNnRSa2dVQjBSNEE2cGErVlNidVBNaU1mb2hZc29M?= =?utf-8?B?TENhNllNZm9MUWFteEhYL2lURzhycjZlM2N0ZERiTlgvV2ovU3ptcERsem1X?= =?utf-8?B?QXJpVUhmU25JQUJtemFFUUozRUlCcGVnOG02N3loTitXVXAxZzZyenRtM2pZ?= =?utf-8?B?N2xTT3ZoNTdQMmE3K0ozc0NtcUdzZGdNOTczUlMyQStXLzBZRkZ1MjVRVmls?= =?utf-8?B?dEFJUmpMbnBDQStRK1RzeUJZMGVpN1l5Q1JUcStreTUrVlNRVXNyWlNFRzVn?= =?utf-8?B?RHNnTHc3aEZlY2ZRb1o1WWZtYmZ4a1ZxTURyUnZuNDRXRWVqaWcrYjBZYVNy?= =?utf-8?B?OWpubjQvSHB1U0lXSkJXVWMxZ0RsRERLeFBtVENxdTFZdkFpMVE1dTA1UEd1?= =?utf-8?B?YmRwTExMNWc0aFlHQTUxQWVyVTZUTjh3dlRCeFZqdFR4UkdjOU1KOHVla3pR?= =?utf-8?B?OWRhTUxaWUZNR01LMi9nZFJ2SUdTSk9KbDMvTStUanA2ZExFelBuNUpRTWxT?= =?utf-8?B?aElvVjNGajZGVFR5SVhMT2krWlkwVVBSUlJNTFpzenY2MXBwVkoyQzNSTFRD?= =?utf-8?B?aVpKdGRvc0FXWUpNc3lyaEdXalpOdTZReTFyeU9KUFlnQ1cwY0xabUxuY1J1?= =?utf-8?B?Q05zTittUUU4ZzdjN2FpYklWZ3JESEtrUUxvRUw0UVVSVW5XeTBUdkVtU080?= =?utf-8?B?SUtuWGFub3NTOU1zV05LTWhCcXJNRmpsTURjODlBNmozQUZCbHhXTGxoUFJP?= =?utf-8?B?Rk5MaFlqRmE4VzZiRjA4dGk3VWdKYXpPV1dXM3BHdnhodFFncXNiMVEwSmFv?= =?utf-8?B?ci9OVWczZFVVbjVBRHp6Zy90bFFPMGEyZUhxUUZrbkRZb2h4TUxGdi81R3F0?= =?utf-8?B?K3UxSjVXOFljbGgrZysvbHlKek83Zld4MXJ2VWZiSitjZXZUVWZpWnpVYzM3?= =?utf-8?B?Y0p2ekhGVXR5ZlhxUjBCVXh4dHkxUEErZDZEK0toUDN6bGwwVWpYYS9HVkFa?= =?utf-8?B?bVI4clVQSGVjV050NmpQUWdlQW5pZEp0R3RaVi9DTEVaSmJtdVk3TmtkRnJW?= =?utf-8?B?a3VGU0FvcGsyQkNjQnFNSHpveWRKeUNnRFp2VkYyRm94VUZ0aElGV3RSbk1U?= =?utf-8?Q?+so9yCYAnGhosDCFcEf2NhRom?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75f9f628-7234-4afe-258c-08daa0951adc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:32:28.8646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g8Du/NGcJnv8Iu9MItaUOfqewnVeUzOh8mAe8EsW+wgMlh49RCuAxcZ3AUmRPS+v70Tw//eWczuEHHKgFiXoLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8219 On 27.09.2022 16:14, Roger Pau Monné wrote: > On Fri, Sep 09, 2022 at 09:22:52AM +0200, Jan Beulich wrote: >> While I was suspicious of the compiler issuing a diagnostic about an >> unused linking-only option when not doing any linking, I did check this >> with a couple of gcc versions only, but not with Clang. (Oddly enough at >> least older Clang versions complain about the use of '-nopie' now that >> we actually use '-no-pie'.) Filter out the problematic option in all >> cases where the variable is consumed for compilation only (which right >> now is everywhere). >> >> Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") >> Reported-by: Stefano Stabellini >> Signed-off-by: Jan Beulich >> --- >> Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for >> compiling, the option could be omitted from that variable right away. >> But if any compile-and-link-in-one-go use appeared, there would be an >> issue. > > Is it feasible to have compile-and-link-in-one-go in one use feasible > with what we consider embedded (firmware or kernel like binaries). I > would expect those to always require a linker script and a separate > linking step. A separate linking step doesn't mean this needs doing via $(LD) - it could also be done via $(CC). There's also no connection between using a separate linking step and using a linker script - aiui the linker script could also be handed to $(CC) for it to pass on the option to the linker. >> --- a/tools/tests/x86_emulator/testcase.mk >> +++ b/tools/tests/x86_emulator/testcase.mk >> @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. >> CFLAGS := >> include $(XEN_ROOT)/tools/Rules.mk >> >> -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) >> +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > > Is the x86 emulator harness correct in using EMBEDDED_EXTRA_CFLAGS? Yes, I think it is (here): This is the script to build the blobs we then have the emulator process. Of course it wouldn't be right to use for building the actual harness executable. > TBH I'm not sure the naming and usage of the variable is very > helpful, maybe it would better be STANDALONE_EXTRA_CFLAGS, and drop > it's usage from the x86 emulator test harness, open code the needed > flags for that use-case. I agree the naming is, well, odd. I would be okay with the proposed alternative name, but I also don't view that as all-so-much-better. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:32:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:32:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412688.656099 (Exim 4.92) (envelope-from ) id 1odBdq-0006cj-Jy; Tue, 27 Sep 2022 14:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412688.656099; Tue, 27 Sep 2022 14:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBdq-0006cc-Gz; Tue, 27 Sep 2022 14:32:58 +0000 Received: by outflank-mailman (input) for mailman id 412688; Tue, 27 Sep 2022 14:32:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBdp-00058c-82 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:32:57 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44f4994c-3e71-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:32:55 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 10:32:52 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN9PR03MB6172.namprd03.prod.outlook.com (2603:10b6:408:101::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Tue, 27 Sep 2022 14:32:49 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:32:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44f4994c-3e71-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664289175; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Rjax2pG+/yf60tM/y9mg88sQ1fQaAxJyRAVjWfirX5g=; b=HbNrANurTe01PmXKPwZRDWH/NNXQFJgk946+E4ltUfEB7Go4+OGf6ePt VjLSdvRA8fvM2qfI3DhsS5pffydad3N+/OdGqJfHdi2uWN6343zpO946p 1ZKijrAtUiZxa7ssw563amC8WWr00e+Sn9Om1tNHFWUGnJUvxgpmx1ub/ s=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 81452165 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3Am7v54aPehYnR3zXvrXNrnJbmzE6nJRDYMBhcA?= =?us-ascii?q?peMyHXZr8wC29aueOYaDEMozobXot+C/f1qyJFR2vrPfGl0f9FEt/cnDBAui?= =?us-ascii?q?mzt+Blf5wePG8oER9RPa26gCeC51s+c5RdU1JNi065oR9lYFiwQjs2IxpquH?= =?us-ascii?q?EgFqQJi+nOGfyl1tj5zHOJES0VuyLHMNDxr1ce9QonkXygeq4ME6s8qqChY9?= =?us-ascii?q?izYIipGHUnfYyjak+fmkCAZbFNUMvn+FHMYuveo4k49sFUug1uNfcH7yykbm?= =?us-ascii?q?uROLDBZJTtXJG9nMs8ksKRQxql+bI+HnPsfoHthDCO47XuyAUzSHmN0NpKdJ?= =?us-ascii?q?ghIjqe5s4xFq/0kHLXt3GCzb/RZy/+F8H0pDi9xMf7FNhpQ//YIiUg6vwnvq?= =?us-ascii?q?IjcbZsjoxP57MEpT4G0/YLwbxzAYMgQqV+N9RuqR+iVHtHw64I6jDmoaYo3j?= =?us-ascii?q?NQHjY5v96IjJgNZqMBkFgi5X/24UjfHU1nUse7Qncr6+nrqUspw9hGHHZBF6?= =?us-ascii?q?8FzwP8dluGD5rnQqfj/O6GAEh6DxKAFcdirmo2sMSiFphcHHdRwRV77Zy0n4?= =?us-ascii?q?7UzwwGRqTVnh9meBnPGaay63y4/9ODqb6b3ENInf+17hw1QAXHI7pI5vxo9R?= =?us-ascii?q?iqG/fiVGZI0VmgbOYI5vr0+iRo90Hl939dRGDjO3EamfP6P4LIulEZqbsarn?= =?us-ascii?q?q5Uj1mnnpDiJ1qYl/4gVIgmF8BOdcAtdTzSmpFF/6qlhAxypBYkl0hgcUYyQ?= =?us-ascii?q?9A/ck4VbEDdTaiTCpQmN5fZIFn3803kLgQXjd1kpw02/8oSmwDt5dt/VU5tP?= =?us-ascii?q?laBh95e/oD2dy514WSoFiXXmy71frj1p0mxifehyjSrKKdvXVIXrQ8z411V5?= =?us-ascii?q?sPo19bNJsO8P9Or5WHpSmrYT2brk8M8+5Go2pvY9cHUWqyW01CF/WSqP/4Fo?= =?us-ascii?q?bDswU8k8chODKmZfvX6adrHWwjrKO2tdmtSqVnmJb9Ao5JNAmUobcJMVDIji?= =?us-ascii?q?pmcmDfsSmekgdDWlCld2TfABmgZeGsvPKFkGgypkZHbc3RFc+SCXSamPZ3es?= =?us-ascii?q?QLLNERQyqaRYcKs5XZz+7XwJs5oj0N8toLEvMa3gD7v3E+eK1AZhjttKodPo?= =?us-ascii?q?FZHL9ymk3VPnrScyDJrvlMibK+Tiia1gzMLrwP+ifV9uegRvRZYm8xT4L1/3?= =?us-ascii?q?WUZT9pOF7xpm5a9k+vu1UOJR1T/hV2wpmyyZSftC6zH3H1rRA0LASQZ0HGYq?= =?us-ascii?q?2Tt+bNN/VArSuSnZioCr5id2S6bfO6UxnKzTjd6O0mjQp6ScrAgs9vy15bqm?= =?us-ascii?q?X9sjDkm6x+1tZ3aoLPkbYRFh83Tvnr9xnq8BIxB/4O9nYWsDzGlw4gwXqRc4?= =?us-ascii?q?SeGOeZmr0gBCsI20us4DsWXSdLyAN/oeUdl33y10ExqXsYHL25fN7jC3Qqbb?= =?us-ascii?q?t22Wpg28wB/6HH5i37skv5hTcBwRHUPV0m/eemLQEaF3yOqJf9vP52Pbkebp?= =?us-ascii?q?yaAX0ojULLpMx9VT+/RSsYhiSFzXJ3naiW9D11J1rPLt2xMAq5xZ3T3n7jdA?= =?us-ascii?q?xscyzLuZmP6AJQvVYFSse1EZdO9jkTMYVrMQ5JENxXDJPdg2kYz44+eKjYIs?= =?us-ascii?q?Cdz0EjNLqinIj0jvd69YpyH5VmbcAumHFVFr1TSRaJ90kMYmdtJwp3IJH47Y?= =?us-ascii?q?n3bUyz1glQhWwYRiMHmojMJiahf6UupxxzAeGDnfhFrRmJ6OPQa4/WDoWAes?= =?us-ascii?q?IFIkKJPpdzAWB85xjVw0FJalfs1Dm23g72OC8cVTluNtMH9vvyAb9NFe7Xd1?= =?us-ascii?q?9I5TjrZkPo6i6VEwpaGQvCt8MzMXs/0bMKU6ddNnZdviYkfpz2kxnQ/EBZd0?= =?us-ascii?q?yjHpNhADGsa5/6w2Hfv6bUV9l7FuzAnV24t1f4L1FcGloV7F3m9f6ZSt67Tk?= =?us-ascii?q?FNtTKk1j60VmodG81rAAMHG69ZUGZIqEDF44LOpC3TEJuwUUtBz4BpzSagnY?= =?us-ascii?q?yEzSnVz0roLz+7U0f3aFWVl5Xx5XunzUAzZyLSg/SD83qXGjOwxc35KLpFrH?= =?us-ascii?q?zZR0V67bgpl2a5vF3Vgn4uUjRz3KbT4U4DVm48EbojOo7oQ9kQeZbm7c48tB?= =?us-ascii?q?ymaFSesUJ25b6CZNjJqcOwkPmMoB37My3+h4Q5dp8XQ/zfdy8tQrRmgvKruj?= =?us-ascii?q?wuY0SI8t5koR+pi6Zm9XvMKrlnEQemYeZlAkP+2jb+hwoRKB7XzRcFGeJjXU?= =?us-ascii?q?ftAjQhc3oEQfUPU8UqyGIdWYqCYuzSW/Mqpb5pQd2XGCENGMwlIDa/pbvO80?= =?us-ascii?q?baFrXaKQv2VKKLGgzAG1I3nwZzUNuL9J245qBhNXnlc976mYfAgh7yXV5PFn?= =?us-ascii?q?rFnk+Neah766rXGiQwXCVqEEmNzMrU4bJZWDr5KeAtbP0UBZaf6XjG3rBVmk?= =?us-ascii?q?PER1nU=3D?= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81452165" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UB7f4pj5zLjAgS9XA+tCaMAjjU3cweKIPY6XOcZ460AzeKZqm3Q7YnQXujS14yDrnu9gDEMhfnu8Ocu0DyKBT6/2/EMlcZoiGrQKg/MKeOnOd07PUOFa6d5Qudp4PA0BnatJ7XLCEkPqqSx28h2hWkd0mBaPnlOsWcJ+AfRb9BNfgMRbXQpEXvxFAH1aMOn+euEBNZCFy2/ZMQRs/c5YJCnHJlcN6wMeOkPcvGvSMo+QyM6uFBrMV1MbF2Lh7/sKbSS31q4s3bboUwQD6R6CdtnkV/a+WIbS2FamdmQSBX40GNZjmvwjC5UVOZEhlP5Gh+3T8RXnfoPESb7GLHN4cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GKpgd/uqhjgVwltKXRhN4PVYUyUCgwjzL12ncQ4bOBM=; b=oCBRolu9M0hM9J33JUPx2XYX/SOseBnLLZ48frA39Vx37fW8ljs/6vg5u59kSucY20McVgVVzo2ujbanYnaM1ENQ6KQjRGL+xNtICXJQP7Cod9qfYtukzMrWxEVlbuEXrDBbCisjuaM3z8FyrF73vYztcHcCMXxz1aTE37ggCGbLkvIRorW2tiVLFwIub21ljzMpoYm1lIygF/4oqHJc/PWfcT7Fz66h9oWm+CDboPrZq4e7BlxuAApqLRmj01GM+NR8/CfEKe37E1+hWGHraaN7D2IdKYjxvgtLTTZRIo6vaK6BFgZm2n5OzNrSVQxi+Bh8iPynJTu9SgkDdCVqtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GKpgd/uqhjgVwltKXRhN4PVYUyUCgwjzL12ncQ4bOBM=; b=sheOe/95RiYL10f6kXnYoO9e4aEHckQgnXomvzVPqDPL47kGBH7FQQ38gPNW7mUPO7tfcTFki4K5PeliYhQc/mHAfmtp9Kfz4tk3L55PGb0T6be9Xh+t6z/wc3i9/b3XZzHWsosr6B8jxUkOxlpHgoqzpO9QYTJn+tLyL571FQA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 27 Sep 2022 16:32:43 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Jane Malalane Subject: Re: [PATCH v2] x86/PVH: restore VMX APIC assist for Dom0 Message-ID: References: <59767cf0-8b1b-4418-db31-6b711518c044@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59767cf0-8b1b-4418-db31-6b711518c044@suse.com> X-ClientProxiedBy: LNXP265CA0066.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::30) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6172:EE_ X-MS-Office365-Filtering-Correlation-Id: f5b286c9-14cd-45a9-05b1-08daa09526d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Muw74U2tRGf1bfRLCXk0scv3rMdEm8NWRieyMPfgVS8vAOidc7z7PLYWUCi5DNVXIvMHxOXlhE/r1+aDyzMo1ZqHGX4N/uDd6gweEOnmDMq18NDNwD/RLQ0oX07Ot+5S+kN4BcNDKV4Ge6+UTYbFZbXRnJun7VuITDH3mF2RkYitlOIqQf4PlTU8BQ5NVz+w79X9PjaMEmQErSnI0pqNSjPKuYqxoVzt5sNQJLL+jRaUZEKXYUmfrKUiMvWL5w8//hBlVGM3ok9dTWT8Ag6tpHJ7gcA5J2+xaBF41JaHlY9wayDVWutUWMh9krujLBTbzAqtptvJ/QGWDeOa3VNJ9BHkfGFr5PDOHlmOUe+RGc/gF6QADSCM+rNZt/ZKkQ2qdL4YQxuRSWBpYvF0QH9FGz+VGO0ERchD4h2UkjOEwZ5xMoBr0x+FOk448yVDSY22RBVvWKWUmzU/S/jl6tcIX0r25Zqm+TiHeCL1DfZ2MZHzmthr1KahFLvLLM7R2S5wS/B2VYxx5jgM12pKhTaDVIV8uWfPhrjR8qDpUrQaovEGtR/35b8LQt2fCzJH911N/yIp1OfoUOalQTQ7Gl0kvzE341+Crb/sxGPVfou0XcEQdJlWLyWoPrERtQQJMtkYGGQLgxyQyTXhicATbA8qm5ASOjnxNGbYF6K85Grw66YFV5VPaaVZ95nAR2zNENMzoI3fpWwrFH0CHp3h8hGzcA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199015)(478600001)(8936002)(85182001)(86362001)(5660300002)(6486002)(9686003)(26005)(6512007)(2906002)(186003)(6506007)(6666004)(107886003)(316002)(54906003)(6916009)(83380400001)(66946007)(66556008)(8676002)(4326008)(66476007)(41300700001)(38100700002)(82960400001)(66899015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVhVTnJmdHJoZVlya21zbElCN0hPRWsxSjNPVzRvMmV6NzlHZ1o4RFNYTlJk?= =?utf-8?B?UkJRTGtEaXMyQWN2dklvaTM1RTRVWXRIWU8rRithUDhEaVRmTFNPSTNxVkN3?= =?utf-8?B?Q3Jlc0FxUXlNMk1qOUxkYUpoeWZ1NEx6aVdvai92OC9BdEhJK3d2WDgxTUJT?= =?utf-8?B?UnFuUFZGUm5Ob3FFZTMxMlFhVHgxcWs3Z3h1OUNUL1FxYzJpUm1sV0FVWnk4?= =?utf-8?B?RGRFWGRHQS92Mzh2TEhIelRRejVNR0Z4UTlIdW5iZUYveGlNRG9DaEoxbHlH?= =?utf-8?B?bmhwR0tuclZQUGpoTk5UZkM3QmZreE9la1Q1RTNTdmZ4ZmYrZEw2WVZidW9x?= =?utf-8?B?U0g2S3c1SE9JcHZKblBzS28zSEt5QUFPK3lJQ3BVazd3Z25qVVFFc21DdU0z?= =?utf-8?B?a0JUYm16OGNadHR0REFrUDZpU2VXM1VMMHArRDl1elBrelM5Um04ZVhNNE4r?= =?utf-8?B?cHRhZUQ2UXZxUGZJbnRmdGwxMkwyaWVXRGNuL0lpYlpGTmRsSklkdm1zeEFL?= =?utf-8?B?SEt1ekNKaTEyajRmTEJrU3pXSDVKekltd3dkaWZsQmZlQXkzOUcrcnFqQzhy?= =?utf-8?B?NklrZktZK3lNbHBRZVowL2t3KzRhN3BiamFFVUZNNm1ZWlN2UUpEL3d1dlMv?= =?utf-8?B?eTVxbE1kZWVUYWs1a0NhM2dZTFdQL3lZME9MRkdWUzA0MmdYOGlIeURiaGJY?= =?utf-8?B?TGhyL0dhN2pBK0VMbzhQTjFoZytEbm1ncHBHU2JSUW4ySXk5WHF6VUpMandO?= =?utf-8?B?VjZ1Si8xMTcvUUxjRHpMaVozRHRrS0hKNlUzRjNxS20yWUtUdnRDcUJteFQ5?= =?utf-8?B?T2tGajd4M2ZVLzhFZWdqWVFoRkRTSmhRNEtQVVRGNTQveG51T1gyL1ZnWDdv?= =?utf-8?B?TTZlc2RmR1JIVENlRmFHb1hzMDBDUE5KanlLQ0hEMzM0eWw3M2dOVFgrZlFB?= =?utf-8?B?NUUxdzZmdHFaVkhmZWlFZW1BbitjUkFYMXE1NDVXbHh2UXdVdERFZ1pZOHpl?= =?utf-8?B?cm9WeEwweFFWMTNBdFU5bjBSOTZaNVhBQkdEaWpUK2k0ek50RGF3a1k1OVRu?= =?utf-8?B?dTlRdGlUTHVsV1NYNUtJcnB4NVpCWFNnNDJrZHVxUU5QSzBJVmRMZnZrT254?= =?utf-8?B?RTB1cVp5TFpLVU93WExETlBxSDd4WHFxSVY3SC9rQndSUHVMMlNpYWtLZTU2?= =?utf-8?B?aFZPL1h6NEJRRFM1MmIrdUV2THk3ZUJMZ3VZS1NEQkw0L3p3TVlIa0o1UWl6?= =?utf-8?B?S0Z0a3B4NjlHSFJSS0dMZVRxODJTcU1aMXJLTGVUcVVRYVBtQnQyM3BXYVVw?= =?utf-8?B?V1hwNHFmdmVqQkJzSGlXajFCVkViWEt0dmFQTC9HZEozYWY2THRNRHZSdVQ2?= =?utf-8?B?TjJpUVJoUjB2cHFkVGg0WDF1b1pVVCt4ZncyUTd4SFRCYkVGcXRwaTY4enU4?= =?utf-8?B?SVorempkUGZNUXBoZTJkS3V0SmlTeHcwZS9TK3pVa2V6N2dIMkxWQjhwd3NY?= =?utf-8?B?RmRoaVd6VUNJcWVWY2tNTG8zSzFpYzZ0V2toUzAvR091VUx3Q1NSL0JUTTgv?= =?utf-8?B?eExjdlVKUjBHdGtUSVFTMExac1FBSEhHUkxkNmNjd3NNR05NeUpxOFRZc2o3?= =?utf-8?B?MG5EZ0l2cEhEUU02czFybkloM2ErRjR2UWVpOUhGaW5XM1VHeWdhcFFYZXh3?= =?utf-8?B?QUlxRWp0Z0p3SmlmZkZydXpNUGZsREZBcE9hY2piUzJlNm94dVFCdkdvYUhl?= =?utf-8?B?b3N2Rk9kaGNRZ0wya09RbkpmTHY0WDdOMXhJN2pDWnFxNGc1UUUycFF1TERY?= =?utf-8?B?ekRjUTZmNEw5S085NUxVQWU0L0ZmdE83bEtnZFoyWHI1U3JNSG00R0JnZCtw?= =?utf-8?B?UGZhOU0vVnVyNWdhMVNyUFY1elJlMVdPVjJ6dUJVeU1MQ3dsWlVnbkVnazRj?= =?utf-8?B?WVZOc2JGM0dTNzBpTWFjaFI4RkRDMit2QUJCOUcwNzJHb2R4QnZOR09TK1li?= =?utf-8?B?cmpjNFoyeTc2TDBha0hNY0plZU9ITHJCYkRsWGRDbUMzSmIvUFpNYXhuZkUv?= =?utf-8?B?anh4Q0YyQ2dMNUs3bmlnejhBU1ZNWWh5eEkzOUJVbFB2ckpxa0hRUmlCUjFD?= =?utf-8?B?cUJSVDlRVysvM0lkY3FpeE81VlVUTld3b3UyM0ZXRGwxTWxqYTlzMG1PQ1ZG?= =?utf-8?B?bEE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5b286c9-14cd-45a9-05b1-08daa09526d6 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:32:49.1915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x91WbHQ8jNp1bmC6PjLzB//fZ9S82gCyGfxnXoqlOKNVR3XY8M8morN3qIe197hJAoB++7jcFioY0ipLDPRy6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6172 On Mon, Sep 26, 2022 at 11:58:34AM +0200, Jan Beulich wrote: > I don't expect it was intended to default PVH Dom0 to "no assist" mode. > Introduce command line (sub-)options allowing to suppress enabling of > the assists, paralleling the guest config settings for DomU, but restore > the defaulting to "enabled". > > Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné > --- > v2: Guard the setting of XEN_X86_ASSISTED_X{,2}APIC by assists actually > being available. > --- > Besides the issue caused here (the manifestation of which appears to > correlate with the other fallout Andrew is trying to deal with) I'm > observing further warnings, but I guess these have been there for some > time (perhaps forever): When parsing AML and encountering the objects > describing the CPUs, Linux would find entries with the original APIC > IDs. If those don't match the ones we assign in pvh_setup_acpi_madt(), > the kernel will wrongly consider the entries to describe further CPUs, > which it therefore would deem hot-pluggable. This again results in > warnings, this time "NR_CPUS/possible_cpus limit of ... reached". Hm, I'm handling this differently on FreeBSD AFAICT, by using a Xen specific driver for the Processor objects when running as dom0, which replaces the usage of the native driver. The only function of that driver being the uploading of the performance states in the Processor object to Xen. I think we ought to do something similar in Linux and just use the Processor objects in order to upload the performance related data to Xen, but ignore anything else. What happens on PV when the number of vCPU available for dom0 is smaller than the number of physical CPUs? Does it also consider the unmatched Processor AML objects to be hotpluggable CPUs? > > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -767,7 +767,8 @@ Specify the bit width of the DMA heap. > > ### dom0 > = List of [ pv | pvh, shadow=, verbose=, > - cpuid-faulting=, msr-relaxed= ] > + cpuid-faulting=, msr-relaxed=, > + assisted-xapic=, assisted-x2apic= ] > > Applicability: x86 > > @@ -828,6 +829,10 @@ Controls for how dom0 is constructed on > > If using this option is necessary to fix an issue, please report a bug. > > +* The `assisted-xapic` and `assisted-x2apic` options, defaulting to true, > + allow disabling of the respective hardware assists. These are applicable > + to PVH Dom0 only, and their effect is limited to VT-x. Explicitly mentioning VT-x here is likely to become stale if AMD is also updated to support the options. I might suggest to leave it out, albeit I won insist if you have a strong opinion about it. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:34:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:34:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412703.656111 (Exim 4.92) (envelope-from ) id 1odBf7-0007Qv-U7; Tue, 27 Sep 2022 14:34:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412703.656111; Tue, 27 Sep 2022 14:34:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBf7-0007Qo-RG; Tue, 27 Sep 2022 14:34:17 +0000 Received: by outflank-mailman (input) for mailman id 412703; Tue, 27 Sep 2022 14:34:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBf6-0007QU-Sf for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:34:16 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7503acb8-3e71-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:34:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8219.eurprd04.prod.outlook.com (2603:10a6:10:24d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 14:34:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:34:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7503acb8-3e71-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k51lSCM8Zn5tEJcAJ21EFJGdnvOfpXiFMiUs8cG2Cq4w/q/4fM03HH6Abseg5XklDwXRNujnVJYE68MOKFZ1xEA+o+cGVuC3KrZvB0s0mk/a/7wu1XYD5pPlo3RgiUagaV/pGzJffu2Wf/vVcGYfDtCu+9cqJzB5bUncax+VSMAHs49e8S1r3a1TBDLVveK/1rEYtdApCfxfOT5wtCj0TW+Amu4sPXYwmy3ywE4fdeDzneF7FYL2i1db5tSC1+yRHPwxcqw/AnDeqLqhsPcerDtD0CMQkDncXEN4LojMMoL9Ui7A9rjb2STj+u58AyBB5iXQtqYHTo5Fx6VnTv6TLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DPdiUV4zY8II75gU4rSNsJ2bZZONG1hTR8i0I9CaB8k=; b=VS8M3f3AN584z01cztGPdoLc8TtCEUxa45+gfSt5mqJAY6fwFbpa4PI+FVjUY0Hz9Tw47ddSDDqphzvq4nJOwC3VtDdCfGogYC9eTkcCa1W9o31wId4kMPX9f0l3VWynFvPRjsYs13n4tr+7gGB55tSRMtf8xtdPw0Q+9wp9OPfObg3PEN4iqcszSvFuGU5+V67yEr1nU9PyMHibyTq+H4TUMtfLmndj1h5wH7r9Jt9EfUxCOOs1I7QRTUjV8U+w3PkfcDagIo2iaNA3AwMLw3GDliMS+XvwBlBdqYcA8c4MRS6cgSps5ynwTuyEyuT2gqnmseo6rM/7R4buHriw6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DPdiUV4zY8II75gU4rSNsJ2bZZONG1hTR8i0I9CaB8k=; b=duL8SXor/yNcKpWx+dx6ZGqTvyYcSr2kuyohQEg+VrpPMqckS3JUvEez1cgvONEy84BObAw6fdk4p9/oLx4OfMTczqQu2+ekHlLlK+Wjo8I8IGLZB0Vr/o1LbORsPJBxEPCfQHAnrI7vTYSEOP98UDPGJe3UP9P/BpXeM1jDGwOwzl9FTtkT7R1uBG8iD1l+EVismchFf1teqwV/FC2M/PaUetKNvYB/RtbL6sL0YKCn4kotlskie7AydHVTi2av43SoP58c0SM9gg456cInbXIVpVclOdCqAmxY+zsqZKFXExEvRS29JNcorPbluVFuCVoSbvWylOHq2+fTZagV1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b3f635f-9fff-2649-ca1c-01a52b1b8ead@suse.com> Date: Tue, 27 Sep 2022 16:34:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard , Roger Pau Monne References: <7eab9645-0c7e-e171-870b-814c330fac08@citrix.com> From: Jan Beulich In-Reply-To: <7eab9645-0c7e-e171-870b-814c330fac08@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 36e75ef4-7b9f-45c4-04b5-08daa095555f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9XEGn428J9+l9VnfVX6dbPUlOWHTVfWG2gAN2JCMjWPh4yh5aMirUGWcJGGPOTrXUCzzJwqoJyEXW4HS0CENnTEEvB/+A1teesd885MaRO5XX0037Zk5Kz8p6mbxhrlFTbXkM87XCrmZYmzl0+gCZMdV181+WV/FgzMnrFJHB2j+LNQ7KtlrgGr02ThFMt/Y3C8RUqkg2mUKfqII9k6+PIEqfh9pnZG5rPmmlMHdCWD6CpjbOWvo2vhzkfqGhTR/Cg9i8gNaSxuBPfraBXVLQhId+tPW70aMRpIlxevGeoDSOW6Ioe3vM3JyyhSMV3XqYKdWjyZcDXru2boUKXDoXpqnDHFH7L1ARL5qSZcwWpy4IKEqS5IncysrS7dMSbhqEZo79cY7n38Nnmn59n3gy9aSFDZmMbsoEkkiW3/EAF5HZmTw+uEjGzNFfcd77Z4TQxwabHP/bnIdVWi2z2lxl4OH94uH4HS9UYnh3pFNZQD93NReLq9deSoSuCQ7bssCfKE0Fk0A3suhWjevUKKNfDd+i5MNhJXgS+GqLIqcLTb3KB4GcUBpPV982tUAX++WM6cyZpm0f6zGs5COn13v8d/2dULtbDaFOjia0CNjTCECEzpLyXoqcRBu4f+lvI+/F4TryM/2/Phgq+RV/5FpW2zun/hrbtapTr5swyPn3JJO8PjKIa7Hcmy24x0LQzJHltPv2ZiWxP1XufJF+pLfHIwr+e8jDYabqXOS8AX414eMFPqBu8+O86W2TCdDmn3bdsLFr7o2OFkehEAl5NaUwCH0M3ZgsFmpgQ4jrU773P0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(83380400001)(31686004)(186003)(6506007)(8936002)(41300700001)(38100700002)(2906002)(2616005)(316002)(6486002)(6512007)(5660300002)(478600001)(26005)(36756003)(31696002)(4326008)(8676002)(66476007)(66946007)(66556008)(53546011)(6916009)(54906003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXlvWXVTLzZhbHhPMFRrYy9BOEM4VDZhVkdNb1ppYXZ3R1VWam43TEQ0bVlx?= =?utf-8?B?QllFKzlRNjZ2UUpkM2ZoTWs5RmhhM3RRWERCbTZZa3N1bU9HUGM4OGhuWHc0?= =?utf-8?B?amc4T3U4a0doa29RT0Z2OVMxdEVDU1B4SXlwcUtzQXNpQWdINzhPWHF3NmJT?= =?utf-8?B?aEtPVWwrbXpjcmQ1UVAxU3dKM01iVnVaQmpIbWNjb0RIMGtZOHdrS0I1Ly93?= =?utf-8?B?M1hRK1NKbTZHdXhaUDZwTFpKWjhJM2ZSQzFxRGoxTklxTzBXcXN2cDFZSmNN?= =?utf-8?B?Wm83TSswT1lDUjhVM3MwRG1OMyt2eUdneFJoODFyTzZEOE1Od1d4VjBKWUZZ?= =?utf-8?B?eExaTkFvRWFkYkdZSGJyN1A5WnJPd2NDVm9wV2VvR3RyTWVaWmxlYm8xeS9R?= =?utf-8?B?QUQwejd0TTN3L3MwM05vdU4xY1NHRmVEaTNxMGFDeVdwSEk0dFR0ZkxURGZu?= =?utf-8?B?bXZFUHFGVVZGK2hOOHFSU1k1UkttS2lLeDhKcGpUOHdnOSt4cWNXQklzNVl1?= =?utf-8?B?dlQzZUR1ZXZ5Y1BFdDYwUjFzTTF3dWZGbU80UWJFc2gyN1pyZnNSbHgzRGly?= =?utf-8?B?VVlKRHRPaWg3dmhBSHg5TEtIM3kyVDJSaXdhdFI3UGZ4Qm5nMjVrd3k3bEg3?= =?utf-8?B?bkVjOVM4Q21VQTZPMzR3aUdaeG4vYy9RVTcrN3gwSUdxTE1KSTV3Nndjb0RF?= =?utf-8?B?ZGFiaWlqYjVXL2tQZGNGeHVxVmdLMnFDL0VGc3Qya2hpMFlVci9NTlYxdlZz?= =?utf-8?B?ZytWVHhUemdVaFVMWjV6NEpzRVBKbnk3TC82aXJFYVhCY1FTbzRHRUNZdzN2?= =?utf-8?B?ZVBZaGloVHZRVEJvY2s3OTVLeGpQaTZxNWJ4TTJXUFdmandkdElRR0lNV3o5?= =?utf-8?B?NVVvWGtodzU0WmtQSnZlT2lBdUxjb2h1R09Nc3JFRWx0aUIxZkVCR2U5YVJS?= =?utf-8?B?VUthdHA1b3lRZyt6U1lkL3dNdmszZ05GMzhzOXhFejdRRFpZN2tsSENzNG51?= =?utf-8?B?T2g1dUdXcXpQVVU5Qnd6aXRyQVZsanFSN0g0MGNEMW15RVZwd3VUN3I3eHJT?= =?utf-8?B?TSthVzBtY1B5QUt4VjQ3ajJwelFtTDB6a3krdS9YSEdKc2lIWTV6SDg1cUxW?= =?utf-8?B?MnFHUUF6R1JyRldWelI0Y0NKc0EzQ2dkVVlhSkZDYjkyZHBLNDZNcUl0NGNP?= =?utf-8?B?TkpqaUUvcDhoNEtjN1VuTXpnSEZMMVlHUnpMaDVpWEhZbnRpWlhESzBZcHdl?= =?utf-8?B?RkV1cnhTdjRkNExPR3FKeFFERmZUNUtaYmZId1BJVlJLckNUUGpBZ29DUjJZ?= =?utf-8?B?Z21YeFdqZGRZNXBmNXgrcXFicjlUN3RQVllzY2piN0FnVnBzK3pBUFJZeUkr?= =?utf-8?B?SFlDWUdRRWRpV3RLVnBZZGJNYUdQREZLblNRWjFKUlVUdVJzUEN4UmR1WXlj?= =?utf-8?B?SkVIV3djSVd2RkVjOVhhbXRvaEpFbDZ2VVRURFFERThIL0lpZjhkdTlhK2dM?= =?utf-8?B?amVCcHYyd0t3Ym1oQXRRMkdWdkRCcU9YTk5hUmdzMHkxejFueHFEcHVsYVVv?= =?utf-8?B?NDI2QU9QVkZWcGd0WjFhRzZzQmRkNmQvWXBVS1orbXNsQmh2ZWk5dkRmdEVw?= =?utf-8?B?RExwK1YvZzk5ZVNvTEtOaTdLTllJTng0QUhLejkzNmg0Ky82OG5qVFhrRGdD?= =?utf-8?B?RjJyU0hXOElxVnVZRDVwQndDaVNKZFhGVk1mSmhvZVpkcC9mcDRLNkZCNHkz?= =?utf-8?B?YmdRc0dpQVBkOG5KQzZaYXVqd3FjVENIN0FIS0hjUlN4cFFTUjRHSGFYNzc1?= =?utf-8?B?VmJObUFPVksyNkVHN2tIZlVxTGpKNXp6c01Id0Z4MlMvOElRVkQ1QWdlbVRh?= =?utf-8?B?SGJjWkJPd2dqSkFPOFpGeTBHN3RUVy9EbUdUclo2YWFwYWZRQ21lQ004dnY1?= =?utf-8?B?RmhBTDQ3RHlPZFduaFBIZ244TXVzRG5KeFhoMktqY3dJZDQyNDFkdUtkUWti?= =?utf-8?B?OUNkUWVBSDkxWDJtM2xBQ2N4NlFPUjBNMXh2alN2dnRJc0grR1NuMWdPVHlV?= =?utf-8?B?Qk4zWXRUalJ1QzhWbUxMcytDOG5qMjJ6R0IzcENrQmV3VkpYVWIvTEN2cnJC?= =?utf-8?Q?csiZ19+53h/pEC3ya1985KNjk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36e75ef4-7b9f-45c4-04b5-08daa095555f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:34:07.2176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DNx5iXGScFu2e/ix1ia4mlP9Qm0OJ17/DZyj7zt0iaxwcf2oQe4xDjWqGkf737VqzjGaLGdZYloj1kZjb24SUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8219 On 27.09.2022 16:29, Andrew Cooper wrote: > On 27/09/2022 15:14, Roger Pau Monne wrote: >> On Fri, Sep 09, 2022 at 09:22:52AM +0200, Jan Beulich wrote: >>> While I was suspicious of the compiler issuing a diagnostic about an >>> unused linking-only option when not doing any linking, I did check this >>> with a couple of gcc versions only, but not with Clang. (Oddly enough at >>> least older Clang versions complain about the use of '-nopie' now that >>> we actually use '-no-pie'.) Filter out the problematic option in all >>> cases where the variable is consumed for compilation only (which right >>> now is everywhere). >>> >>> Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") >>> Reported-by: Stefano Stabellini >>> Signed-off-by: Jan Beulich >>> --- >>> Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for >>> compiling, the option could be omitted from that variable right away. >>> But if any compile-and-link-in-one-go use appeared, there would be an >>> issue. >> Is it feasible to have compile-and-link-in-one-go in one use feasible >> with what we consider embedded (firmware or kernel like binaries). I >> would expect those to always require a linker script and a separate >> linking step. > > As I've expressed several times previously, the entire variable is bogus. > > Just because we do have several things which are built as > non-freestanding, doesn't mean they share a common CLFLAGS environment. > > PIE is very specific to the intended use, and blindly disabling the > stack protector isn't safe either.  It only works because none of our > freestanding environments have gone to the effort of adding stack > protector support. > > -fno-exceptions is furthermore bogus in CLFLAGS, as its a CXXFLAG only. > > And no, this mess can't plausibly be used for a compile and link in one > go.  Filtering out a non-CFLAG from the collection at every call site is > nonsense. So what do you suggest we do in the short term? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:37:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412714.656122 (Exim 4.92) (envelope-from ) id 1odBiF-00085v-BV; Tue, 27 Sep 2022 14:37:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412714.656122; Tue, 27 Sep 2022 14:37:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBiF-00085o-8p; Tue, 27 Sep 2022 14:37:31 +0000 Received: by outflank-mailman (input) for mailman id 412714; Tue, 27 Sep 2022 14:37:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBiE-00085i-CE for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:37:30 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8384148-3e71-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:37:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8384148-3e71-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664289449; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kxDZ0rbJ3bMBOrYvM6g62C5B7UtbXGXUlMV/QGn+QVE=; b=At5N0qz5G5+rHg3EVfOaunA2zADflI7ZgP4gZeSbtwdsY7HT3VeyC3+a i4Cl9ndA4v149zvw8hHco/wpv6M0SI7VlZzHnRPqHcXY5hlzTIBz00kCy KBCmBBPur7RKBM38hVaCuOPem2eKhw35BjwJAmBEk/fD+K0hm7ZSSDbpL 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 80575648 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qARhVq1/wJaRtaIaOfbD5T5xkn2cJEfYwER7XKvMYLTBsI5bpzNSy mEZXWiEb66MYDGhe9AgYImx8kkEup6En9E2HQtrpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WlH5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUF1Op1X2MT8 MUIdjs/YCm63s+I6rmSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqNJ4PXG5kF9qqej lLN3kf7GE4bDcaS0hjG3E+1nrOMvDyuDer+E5Xnr6U30TV/3Fc7ChIMUkCgieKkkUP4UNVaQ 2QY/ysyt7l070GuQ9/wQwaQr3uNvxpaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLTBqoaGPTkWG+7KZqz6uIgAYNWYHIyQDSGMt4dPuvYUyhRLnVct4Hei+ididMTb0z jORpS4ynYIai8IRyr679lDKhTGrjpXRRwtz7QLSNkq66itpaYjjYJangWU39t4ZctzfFAPY+ iFZxY7Ot4jiEK1higSQbukPQrP04s+Vbjbuj2dWRrQf3T+ErivLkZ9r3BlyI0JgM8AhcDDvY VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZLlfvwc14WaKHM4kBemAImLp3B 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYH7H8iTI/ePi+D2iJuppVAtbzOzghgRtv/sneks2 4832zG24xteSvbiRSLc7JQeK1sHRVBiW86q8ZUIK7/Tc1I3cI3ENxM26exJRmCYt/4NyregE o+VAye0N2YTdVWYcF7XOxiPmZvkXIplrGJTABHAyW2AgiF7CbtDGY9FKPPbi5F7q7E4pRO1J tFZE/i97gNnGmSepG5BMcGmxGGgHTzy7T+z0+OeSGBXV/Zdq8bhoLcIoiOHGPEyMxeK IronPort-HdrOrdr: A9a23:QGtU/aiWHE4uSPWPtFJETPotpXBQXtoji2hC6mlwRA09TySZ// rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM RdmsBFebvN5DNB7PoSjjPWL+od X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="80575648" Date: Tue, 27 Sep 2022 15:37:19 +0100 From: Anthony PERARD To: Jan Beulich CC: Oleksandr Andrushchenko , Wei Liu , Dmytro Semenets , Juergen Gross , , Subject: Re: [PATCH v2 1/4] tools: remove xenstore entries on vchan server closure Message-ID: References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> <336cfa84-2f32-286a-394b-fc596b2ce03e@suse.com> <3394db68-6569-50fc-a3f9-95b9756a0d89@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3394db68-6569-50fc-a3f9-95b9756a0d89@suse.com> On Thu, Sep 22, 2022 at 08:29:52AM +0200, Jan Beulich wrote: > On 01.08.2022 10:57, Juergen Gross wrote: > > On 13.07.22 17:03, dmitry.semenets@gmail.com wrote: > >> From: Oleksandr Andrushchenko > >> > >> vchan server creates XenStore entries to advertise its event channel and > >> ring, but those are not removed after the server quits. > >> Add additional cleanup step, so those are removed, so clients do not try > >> to connect to a non-existing server. > >> > >> Signed-off-by: Oleksandr Andrushchenko > >> Signed-off-by: Dmytro Semenets > > > > Reviewed-by: Juergen Gross > > Anthony - any chance of getting an ack for at least this first patch? > The others are more like feature additions, so perhaps aren't to go > in anymore before 4.18 opens ... Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:38:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:38:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412721.656132 (Exim 4.92) (envelope-from ) id 1odBjG-0000HO-Ny; Tue, 27 Sep 2022 14:38:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412721.656132; Tue, 27 Sep 2022 14:38:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBjG-0000HH-LG; Tue, 27 Sep 2022 14:38:34 +0000 Received: by outflank-mailman (input) for mailman id 412721; Tue, 27 Sep 2022 14:38:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBjF-0000H7-TK for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:38:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f180e73-3e72-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 16:38:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7696.eurprd04.prod.outlook.com (2603:10a6:102:f1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 14:38:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:38:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f180e73-3e72-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Za0r6dVn29wcvWU3JDso1EyZ4RaSwhvIEPEhkX/aGs7XX0nM3Ai/ALUZwVC9uaEo8hZ2oDt8aGeL3ZfjsOwq1dFKxah4xEmRBNjU3MeYlmYG78zRddJ/DG3RfXG++nlJHJiaqn574XcpuMvzI/kmHQ+IIpnm7NPCMRfRzLV5ob55kEABPD33kLTyaTNAjmsUsTn5FrCGys3ZaJu382o6jE5n82XljzNcRA0ge0wozzTdzgGxQjzfvY/xf0kKPPqLoFlLylOI++kjr0Cu7C7D0+oUzdzUb4aIb0ZcLwDpkbLu4sAD9Ta0w2tYsgMTMdX97YSForrshOvcO7dko7Caqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=65M9lXvXBp2v5RsA2yy8iL3oNSjyXqFGYBQhf5j/OBo=; b=aiBO7NUxlkBfX2i2tVQsPoljL8bmKcMk8M8tp+9FeCTDxVXBCffMLQo5VU6XGckMKznOu8Bi3KR4R2s2+0KVznG7sUygIyqp03MqjZ2mPsdA9PLwv0+FF6uqV9sP8kQ2FboDHO579KzBN1b9INk7he1RQgYaAUAC5tLkmEfKes7IbXU5ig1cI8arIIKS2kVTKSQHP138oe9fUvSQtaQzybSBl9FCyfqjSo8OPEW+vWqx+ANMjd7Zd5/FwJXqCnF4E49otOeKg/whycxOG7K6pYdn+uhzXY2unJ2PkW99Dp6dY52V22/+iH3iZUFB04MslEHfVwsCXlIp75DLKGQgbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65M9lXvXBp2v5RsA2yy8iL3oNSjyXqFGYBQhf5j/OBo=; b=pYD7cZ05kfoJ7V1EoN4AOakdX9MHoK9tGHV5Pg8aEvghLxXYWUtrN3g+XI2KARMSSzhabOqcg0JRwUvsPdZINEcHO3zPQ9E3djZdfSQPmvHCQqoMI/lzA0kVHRTV0Rn3Zed1+SCiijxk5NpO7X80UVAbzzzekuvC+IaRGqmkrtBYfHiWtNqbUpiGlW8y5i154aGXQfFSz1QRfaTQdpu/2vPtXJ6WCIQKe7eQ4Yr9UdS7Ceieec/9jaBilEbCfW/aNmXjNoTMRdS9/Reyans70YqkR5f20TSrpPwdOcqEE1bmcP5uE4ryxgMrJoEXDqYLiHPGPb9nfvnMkd08O26wNQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 16:38:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/PVH: restore VMX APIC assist for Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Jane Malalane References: <59767cf0-8b1b-4418-db31-6b711518c044@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR10CA0050.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7696:EE_ X-MS-Office365-Filtering-Correlation-Id: f3502afc-7b76-4f0c-eef7-08daa095f1f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yq0+9MCjWCghJ/cCdzl8bwd+bAXfRUSIIyAZiB61AsUu44CsZG9niU4EIPpJ/l8NsYpz0GwJmXBgFaEBRCbtBEXp0j7IG0iPyAkgn80JIm1SzbEQCNZRj/dCzjcyxOczUGCpoBO0yWPW9/sADkSHqkQmtHnNue8F2hYtKfPAhI1ZzkzfiHrRsUsCM74PqcxdB8pdwe1225Qut9hVBAkxSZA0ULMdGR8bDheR0TQ6aZwXpPTN0wEfOkJFLDfmOgEpgU/gbUB/Yb9OX1wHnFRrEWbXbxVaH/iEoy2o84Iopz2b6a68KycagIqimyeps/NwZUp16m0Hpvp4qet1TPclxRKlCM1fMyrtAU3NjM4K51u3WFgvYv5EIAwaNzm+ziieCJzLkMPAryGcRiecoGacxtbwwMqj4+HZGcxUUy05aZqRPDGXLgwY3TU1+zuj4RH7CFaiEaL9mb4c6+7y+j47AtZlAio8xEDxzYGnYs6+LAzs1X2aR0iZNb9ZGOalXae4CQztykNC3hRf+e44l73eqTkRh/6Rb8yFxjxDsXrVCxJ3OnSwJzgq8ai5VdTJ0NyNcvnJgOks65AHG20bNth4qwdG8hxRw6pT6ukzpZIikNSJaIctEgMjvGDDVCSXqO3zO/ZT7izBBqaoQPK4BNEhvM/TzUeU0PkGmwOsbyPxGTeRR3WpyaAX8ROousuU39GmF4j4orEO4ePHD0VUzeOdDfn+p4d+xFl/8dmb9AenWANzYNKXsKZjbJvtiAPTg3GEpdD0dXitoFD7Gn3v2r5ntedqjz0IK7oPwvUizfsceL0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199015)(83380400001)(4326008)(6512007)(26005)(478600001)(86362001)(316002)(54906003)(66946007)(66476007)(8936002)(66556008)(6916009)(31696002)(2616005)(2906002)(38100700002)(6506007)(36756003)(41300700001)(53546011)(5660300002)(66899015)(186003)(6486002)(8676002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OW5TRVo2NmhEVGpRN0pxK2kxSWR6enZwVlZGVHZHYjZiZVAwUk9ZZnlrMStE?= =?utf-8?B?R2V1M2VWeXpKU01ZN2RzNnczbVBQK3gvRXREYnVTdlNmc0E2V3NCSnMvcFhO?= =?utf-8?B?MU8zVFJlNFBjbEtxanJ2TXM5bGVPbDVEb1VIc1RvdkJtaVZmME9PTUsyRjEz?= =?utf-8?B?ZmdQTXpqdmlRWEZCNytzQ09zN2t2QXlrRmV2MkZjVjJXRE1kUzZPN1hGQmVE?= =?utf-8?B?bmJDTFgvU0pMdUtUSTllQXIwSlpUQzc2UkRMK0JTckhtQTlvaVR5UUdCUkxh?= =?utf-8?B?MUxHVlJVQ1JCNVI1MVdqNXVZa3Y0NzFCTmt4RVRHVGNaS0pnN1VjYTIvUFBu?= =?utf-8?B?eHZ5UGhaYWJyK0FFUXNIQkE4WUdUaCtVaElwUDFtL1JMUFRvSzROSjNuTjlE?= =?utf-8?B?bTVZS1BlakdMeFYzSGNsdFZzb3ZmUjZ4MEJHa0dNcGxHcGpCMFV0eG8rWTFZ?= =?utf-8?B?dGZlY1k0WldXVWxQbWx0MHlWT0xrNThtajYrdVlmcjVjeVdzeG1JR05VeFdQ?= =?utf-8?B?RDBBSUlEL2F2d2VuUHNCTnNMQXNpY1VsK21UVTA1Y091MmZlWW9teUU3OGs4?= =?utf-8?B?SExhcVNCaXpNVStRaG5wZlNqVkZ6bWdVUnY1c3U1WmJKOGRLNHAyZ0JOTDVw?= =?utf-8?B?cHNxdW81NFpwbnVJejNoVTQ5alZRZ1NGbTMvZTl5YXVBR3kzK1FHaVdCVEoy?= =?utf-8?B?Yk1MYi9MQ3dMN2M2bWpXOHYrY2xKOVl4TVphVHNCSlA4ajVvY1czV2dDek1K?= =?utf-8?B?ek5OUWxuZWlucXEzR2toQnE5ZHBackdOcWxweGh1NnJISGJldDJFZjl5VWk2?= =?utf-8?B?OVNYK0p1WDZlQVpqWEI2ekVlMHRrYjNpQmkwTWJabFA4OVZoSHB6MDJ0bzVG?= =?utf-8?B?NjcyODVSaC9NekJ0Z3NzdTV5ZjdVMHZmSlJ5UUlOWWVlLzVWT3JuUHo4aE1Q?= =?utf-8?B?bkcrTVMvSVpaRTNGWDhoOFNNWUtOYWRlcnp3Q2lIaml4bFdoOFpPb2tzOEll?= =?utf-8?B?QnZtTEZ1R3YwejduU3ZQK0hhVkRTVENmZVZIMDlmbDFnc2ltSzIvNWNhbDVC?= =?utf-8?B?SVZTRlZ0V2V6SjZVUUJPSkRicjFnd3h6aWlyelZyVUszQVV6YmpiYmo4Sy9y?= =?utf-8?B?NVlpN09kcWMySmt5L0wwMHdZbUYvbmlTUlJVakNhUEROdkNBb3JQQVZQUGVh?= =?utf-8?B?VVpzdW5UVEFxeGs3aGE3Ny81WFFUQ1RQOEJ1Y1IveWg2c0dqd0N3R3pNaTRU?= =?utf-8?B?ZFVVelZpa0p6T1QwVWJpSWpTYUN4WVlMeDNPQms0Rm55blMySTlIY3Q3T3NQ?= =?utf-8?B?ZW1jWHVRQWRpTkN3ais4WUxIbGxOMGZxc2Faak10WjU4M25OZW5uOW9tRW9D?= =?utf-8?B?QVhwNTJYVmNNZmNNTDZoR2ZBNU8xSEpiTHc3dkttYU0xUEs0QjNRTkxQdGZ3?= =?utf-8?B?OUFTbm5mbHlUV0s5QXlISE1heklDZVZaMjlhYmdPU0JLVkhnT3dPQWRkNG56?= =?utf-8?B?VGV3Y2RSZmJEVDFPaGZ0U3IyTG9vVEpTRkhrWE1mL3kvY3E3cXdsVzZVallM?= =?utf-8?B?U1NZWmo3MWQ3TGxZQUo3M2hHSmtDeW9OZzFjL3lRRzFUNWcxUThkakpPU1A3?= =?utf-8?B?WDl2S0dvZ3N3MjM0SEI2aGM1NTN5UHgxSjZGUEw5bm9RallqdGFIOWFQaXN5?= =?utf-8?B?ZW9zdnhLZFE2MEs4c3FqZDF4YTVIWGkrM0NTMmxaSFRhUXlRMWV3enZVZGxG?= =?utf-8?B?RFNCUkZZYy93WHZqS1RHaTVPWHlQekVMdmtlNysrbEJtZVBnNm0rZW9iQ0hy?= =?utf-8?B?OUhKYTBUY2VYVnFTVVFCbk5maEZMMm1peUZLMzlvWENPZlZXQ3kzcGNseEt2?= =?utf-8?B?R09RVkFmaHFiUld6TU5iRFRtdFVTQVFKTUk4bFdTQ2NlbGlUVzB1RTFhRUJN?= =?utf-8?B?blVUcE9FQitvN1JwdjdkSnRUNzNKaVJTVmRZcVpxWXBMNTVMVnVMblY5V3lJ?= =?utf-8?B?Ykh0dllDNExvSFdjRnpwMnZiVGNaTnFscXBXQWlvUm9aNWN5TDZqV2RCTitG?= =?utf-8?B?YVI3b1hjOHBYQ211aEpDeElzZ1p0b1FxSUt3amE5YWZncEVudUNLUFJsTzhm?= =?utf-8?Q?vy7LlJqXzziUGYWRuJzeTaWsi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3502afc-7b76-4f0c-eef7-08daa095f1f8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:38:29.7947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j7n+iNcRy2vsbhdtxEOSGOzZnR07OplxMspoeg7Ti44N1Y2aqXm0BPuB5qvQYdHwFrQsMSZNqsom+Pd1mQqt7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7696 On 27.09.2022 16:32, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 11:58:34AM +0200, Jan Beulich wrote: >> I don't expect it was intended to default PVH Dom0 to "no assist" mode. >> Introduce command line (sub-)options allowing to suppress enabling of >> the assists, paralleling the guest config settings for DomU, but restore >> the defaulting to "enabled". >> >> Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") >> Signed-off-by: Jan Beulich > > Reviewed-by: Roger Pau Monné Thanks. >> --- >> v2: Guard the setting of XEN_X86_ASSISTED_X{,2}APIC by assists actually >> being available. >> --- >> Besides the issue caused here (the manifestation of which appears to >> correlate with the other fallout Andrew is trying to deal with) I'm >> observing further warnings, but I guess these have been there for some >> time (perhaps forever): When parsing AML and encountering the objects >> describing the CPUs, Linux would find entries with the original APIC >> IDs. If those don't match the ones we assign in pvh_setup_acpi_madt(), >> the kernel will wrongly consider the entries to describe further CPUs, >> which it therefore would deem hot-pluggable. This again results in >> warnings, this time "NR_CPUS/possible_cpus limit of ... reached". > > Hm, I'm handling this differently on FreeBSD AFAICT, by using a Xen > specific driver for the Processor objects when running as dom0, which > replaces the usage of the native driver. The only function of that > driver being the uploading of the performance states in the Processor > object to Xen. > > I think we ought to do something similar in Linux and just use the > Processor objects in order to upload the performance related data to > Xen, but ignore anything else. > > What happens on PV when the number of vCPU available for dom0 is > smaller than the number of physical CPUs? Does it also consider the > unmatched Processor AML objects to be hotpluggable CPUs? I have to admit that I don't recall for sure, and I'd rather not write something I'm not sure of. >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -767,7 +767,8 @@ Specify the bit width of the DMA heap. >> >> ### dom0 >> = List of [ pv | pvh, shadow=, verbose=, >> - cpuid-faulting=, msr-relaxed= ] >> + cpuid-faulting=, msr-relaxed=, >> + assisted-xapic=, assisted-x2apic= ] >> >> Applicability: x86 >> >> @@ -828,6 +829,10 @@ Controls for how dom0 is constructed on >> >> If using this option is necessary to fix an issue, please report a bug. >> >> +* The `assisted-xapic` and `assisted-x2apic` options, defaulting to true, >> + allow disabling of the respective hardware assists. These are applicable >> + to PVH Dom0 only, and their effect is limited to VT-x. > > Explicitly mentioning VT-x here is likely to become stale if AMD is > also updated to support the options. I might suggest to leave it out, > albeit I won insist if you have a strong opinion about it. At this point the statement expresses reality. Imo the half sentence wants dropping when AMD gains respective functionality. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:45:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412729.656143 (Exim 4.92) (envelope-from ) id 1odBpr-0001lv-Dz; Tue, 27 Sep 2022 14:45:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412729.656143; Tue, 27 Sep 2022 14:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBpr-0001lo-B9; Tue, 27 Sep 2022 14:45:23 +0000 Received: by outflank-mailman (input) for mailman id 412729; Tue, 27 Sep 2022 14:45:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBpq-0001li-1J for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:45:22 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 029da2a1-3e73-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 16:45:20 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id l8so6693185wmi.2 for ; Tue, 27 Sep 2022 07:45:20 -0700 (PDT) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id t11-20020a05600c41cb00b003b31fc77407sm13973030wmh.30.2022.09.27.07.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 07:45:19 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CCAFD1FFB7; Tue, 27 Sep 2022 15:45:18 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 029da2a1-3e73-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date; bh=YqMlZu51UI6h+Dt93wjUN/BRhvTP/YAJelxxJOS2OUs=; b=h2qcHCtOiMQvrC+w0Mszb+DskJWVj+QHMJ5Ejmk+rtWu2Z0XTbkA4+VOB4WSV8ecZ1 NHEMwvJsSz44pLUlrRcmC6qhoU8OPeYsjymE7BXtDNdtSF9Pnh6oHWjxyfTVOtqaTNl7 1GRmB7Zl0iOOa/5q8X/U1yQ++hJxn5Wx8OLg3hUl9sDQQzDb1nE7R70h/pYzh0G1nqM4 v+plJElglQUNlZkThh9qtYNdYG4lRDFI7qFk+gHzge8OvjfaORZhUSq3/zd0gE4EZWDJ 65I/HELy4Lj2+62z9XDcpW3Xsw61MFICUWabnihWbNapkSzSiVi3gQn3VuUfKtwlfE/0 Otdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date; bh=YqMlZu51UI6h+Dt93wjUN/BRhvTP/YAJelxxJOS2OUs=; b=z+3nyQtKwus+bJiR5mEEVU5ni4sv1RW4Y0Q8G68nVD9DSyRzglaZc89RdNu4OThZZB tWhQsKJzYiN0kLNwZpFPVvrzb6ss2io9mCr6tnEIjrkHUQ64l0YBpYQ0T5bC4q2M6YyM 07UULDxilEoGVL8XanQ3eGzfG/HcyBHXAX6wbXAL1XpAYCdrLwkoDaTX/34J3AOD1iUZ Dcec3/3RJIUnMxi13KWJl94q5yRS9tsXsahD25n7iCZ8s9eALPeTTobOR7De2KzyHjdV 36mXubRl9z2No+2tpZF6poXUDaKJ5o0wayOGLu2dSH6lPEiRMYL8ffJj8uokwoHyAQ+C 1mDg== X-Gm-Message-State: ACrzQf1HscxaGNwF8n7EGbG63j7reyShxSXsNNwYMwexse72d9mCXSNo u/fbmoH04Ah/jQwLSMbVU8y6cg== X-Google-Smtp-Source: AMsMyM5perp2J56yByk5VI6gtec0IZRw3Rv15MXQdiRREvzy81Pt4XXwWFKigkZFzFxgEJSIoaSEeg== X-Received: by 2002:a05:600c:4e11:b0:3b4:91fd:d0c with SMTP id b17-20020a05600c4e1100b003b491fd0d0cmr3019229wmq.71.1664289920068; Tue, 27 Sep 2022 07:45:20 -0700 (PDT) References: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> User-agent: mu4e 1.9.0; emacs 28.2.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Roger Pau =?utf-8?Q?Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system Date: Tue, 27 Sep 2022 15:44:11 +0100 In-reply-to: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> Message-ID: <87mtak3mgx.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jan Beulich writes: > SRAT may describe even a single node system (including such with > multiple nodes, but only one having any memory) using multiple ranges. > Hence simply counting the number of ranges (note that function > parameters are mis-named) is not an indication of the number of nodes in > use. Since we only care about knowing whether we're on a single node > system, accounting for this is easy: Increment the local variable only > when adjacent ranges are for different nodes. That way the count may > still end up larger than the number of nodes in use, but it won't be > larger than 1 when only a single node has any memory. > > To compensate populate_memnodemap() now needs to be prepared to find > the correct node ID already in place for a range. (This could of course > also happen when there's more than one node with memory, while at least > one node has multiple adjacent ranges, provided extract_lsb_from_nodes() > would also know to recognize this case.) > > Signed-off-by: Jan Beulich > --- > On my Skylake system this changes memnodemapsize from 17 to 1 (and the > shift from 20 to 63). > > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -78,7 +78,8 @@ static int __init populate_memnodemap(co > if ( (epdx >> shift) >=3D memnodemapsize ) > return 0; > do { > - if ( memnodemap[spdx >> shift] !=3D NUMA_NO_NODE ) > + if ( memnodemap[spdx >> shift] !=3D NUMA_NO_NODE && > + (!nodeids || memnodemap[spdx >> shift] !=3D nodeids[i])= ) > return -1; >=20=20 > if ( !nodeids ) > @@ -114,7 +115,7 @@ static int __init allocate_cachealigned_ > * maximum possible shift. > */ > static int __init extract_lsb_from_nodes(const struct node *nodes, > - int numnodes) > + int numnodes, const nodeid_t *n= odeids) > { > int i, nodes_used =3D 0; > unsigned long spdx, epdx; > @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes > if ( spdx >=3D epdx ) > continue; > bitfield |=3D spdx; > - nodes_used++; > + nodes_used +=3D i =3D=3D 0 || !nodeids || nodeids[i - 1] !=3D > nodeids[i]; Is that boolean short cutting worth it instead of a more easily readable: if (i =3D=3D 0 || !nodeids || nodeids[i - 1] !=3D nodeids[i]) nodes_used++; ? > if ( epdx > memtop ) > memtop =3D epdx; > } > @@ -144,7 +145,7 @@ int __init compute_hash_shift(struct nod > { > int shift; >=20=20 > - shift =3D extract_lsb_from_nodes(nodes, numnodes); > + shift =3D extract_lsb_from_nodes(nodes, numnodes, nodeids); > if ( memnodemapsize <=3D ARRAY_SIZE(_memnodemap) ) > memnodemap =3D _memnodemap; > else if ( allocate_cachealigned_memnodemap() ) --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Tue Sep 27 14:52:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 14:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412736.656155 (Exim 4.92) (envelope-from ) id 1odBwt-0003D4-7N; Tue, 27 Sep 2022 14:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412736.656155; Tue, 27 Sep 2022 14:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBwt-0003Cx-2e; Tue, 27 Sep 2022 14:52:39 +0000 Received: by outflank-mailman (input) for mailman id 412736; Tue, 27 Sep 2022 14:52:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odBwq-0003Cr-Ui for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 14:52:36 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05707605-3e74-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 16:52:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9302.eurprd04.prod.outlook.com (2603:10a6:102:2b8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 14:52:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 14:52:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05707605-3e74-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwXuAPml73UmHt/vnhY0pD5Nn8/0SmwuK/yNGsnhnidcAmxtiaiq59sTVE9ZV5Jt6oo8Rx/9YhEe+OwccLZBKMbqgSE6XtQB+NS4FVZGYlfSjnTD0QqLncoWd4U51tShDKzEbbjYhFFYXhdz8O9IghRR+I2QHCmscM5O8ZDJsOxwWEt2r6dVX3v13JAYTntVDuIBuVpP96MOy3uW1Vv+t8Gz6r2Xz4luBiacgHA6feqR1gWvOWFvUkmBCHPc4xm3p/a2Wamyx0rx181aK+htzOqNpktI05ccHIvxcjsa2nAFBKwF33A/yi3HHhKzzdyOHSlQ6tlT5epHkHTwYWs9eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XP3PNaiLaWY6VR4ZhXu1ItnyKhmSysFUsdujkPMM9JU=; b=SvxpcLpttObxHhiHpP0DT5jniz0mWBWYUxk7/X84XkH+lXOOh6wrOY60ZZGVXCDadyrGazI1u2sd/ve+I7CIklCwU7JF/8LNWksPDkCJqphheEkm65ewBB5nEx5DfzbTNv1FQvDzzFkp/wa9AeQ6rdHpO0KEB8tGq48/t1FnHfz+b1hN1/mmf+fx3zRQCjKP/NL2Ua5XWKH2TPuK8drz8+4vYzFKo1AnayY0rPocHUUBdY+2EoWhQYSLqClYsNJkfhYwkEe1T/e1Vm/CyA9ylp8eGCjWTzn1Xdm1Bg7/bmRxt5QSpgsKkERN3n4Ti7QIvHrxN1JXU+c0lKChavP4Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XP3PNaiLaWY6VR4ZhXu1ItnyKhmSysFUsdujkPMM9JU=; b=ZYJ8eH0rgRNup2w+YLTPMjn0ds48FcVQVQZxI8ONgYn3jEc00uzb7QyUHAZe3kKNJ4RQX50VpJAGlkHHwrGDsQsCcBzIO29AIIW2fLrgvZDoBDu3asc1rXlKIzVfZPYZy+qFn2LmX6k31cuFMCDzX/NgeQ5vAYC6+TInfMAsx/4pe436bMYj/NslB4jaeGKlUVqztPOt2DIRfIm926hykb07hl6Gehf4O3ZEB2NK411a2dZcej0PltDVweTxyI1ny+LSRN33zAd2HffSwZiUqI7IN8yq/loPIzECNq//ebhZ6uMqao3uWvTvHaBoQBKn+UT22KRWCkfGjs2k3WLSRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 16:52:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system Content-Language: en-US To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> <87mtak3mgx.fsf@linaro.org> From: Jan Beulich In-Reply-To: <87mtak3mgx.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P194CA0044.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9302:EE_ X-MS-Office365-Filtering-Correlation-Id: a4b3d4e7-337a-43b4-5161-08daa097e8f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dNKXuIRNK9yRPdWRP5Ev1sql+RAxAFX3RUqTBAawl2rR+8KN9kDStN5L0hokrya7hSt4Wvs71VnUO8Xd6WJ311STG768gFukfMVdvjv+HbA58R7okXAHB9zABlE4tIpDQ5lCPS/FGM/ynZtJ3YV7jEETPDNh2JEGPDELQ783QOJ/bn/VjxFayWPL/noWBWK5AakA1i9rEJACO/VcBxFgS/J4z9duEu7jBc49mAKUf3OCNxTfUOYHonGzbUvGMyJqaDUByPlQfLrTWEJ3mA8J8Mi+KQsJ1APdOsjtyEWinpNeCyRhB4qN2hMeQp7ItURW8x8mnwV3Sb1kXAFuiZnFF32Y6BhNF2KZzVh7Fdsy0+3QyKbCxsrJz0GuFJwZdYRfoZw4qz3MyGKtwoovkFw7Ak32qScCAoXsIEeBk4fb7S7wAzahsSRJozwWy8MbmyBvh5q3uZvpmK9ftIXnbvuUXRAXuHc1p0wmdNWSTmKnH4PlXPyI6LKCxdhBxH4Gzqgp2Hrmp2/7pHY+OQGqeriFEmPro/xu0xprvpn6gPg5ylYF8SGNgzRSZs4Sy9BJzHf6ZMKq3jP0F4/2PHcB9p8KFIBX/ZOqLMQXSm+9+wibYz8gw1W0PRkN3thPBmQBKksYlFBlSgxx5KS4Qf7euyeyJAsdhmdQ8oqnNL01R7sNWs9i3uBBuzalmZ4jmZXwHjNePqRUie6ip0kAOy7kRdsks/UJzKzis7RYcByJYI9JFoploAucRJJP2jyXpuGo6w80Psa1rr+wcLqYxVTBpCivB76NDoYH4KOjGHX2RL1iVZU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199015)(6506007)(53546011)(41300700001)(478600001)(6486002)(5660300002)(186003)(2906002)(6512007)(26005)(4744005)(54906003)(2616005)(6916009)(8936002)(66476007)(66556008)(66946007)(8676002)(316002)(4326008)(31696002)(38100700002)(86362001)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nlh6akd6d1IwbFNZWWpQampSS0VPOWNnNkh1ZFlMQVlYWHNBQmZ2N1h2YWFD?= =?utf-8?B?SUtaN05mWmhjSTRGQitoT2doanNlTEg2UXJvalliRWpjU1VNTjIzYWRLSU1a?= =?utf-8?B?UmF3cjVWRDdpcUJNTUNvbkZYR1JCQ2lRak5Sd2ozN2cya2lEZk5TVXl0L1BL?= =?utf-8?B?N3VjeTdwSy9vTHVKbjRxZXFSb1JFUjhWdDg0TnpHN0hzV0xtVTY0ZFYraFY5?= =?utf-8?B?UlNnWG9PZm9yQmxiQUR0VmYycnUxRjVRRTNZcTUyZWdUL0NCK2NJSVA0MVVS?= =?utf-8?B?cGVWVkR5UGZkSm9WOU4xQlJTMkFySjFqaWlFRUZrWmFKcGJYZ1BKSW14UHlv?= =?utf-8?B?Y2FGK3VDUFhpUnNkQlJ1SEN1Ly94UWxFYXIxWVA4VXJWaU1HeHhPbzZBWXlV?= =?utf-8?B?MUJzWVYydnRNWU5PVUZXVnRLbzZHdXIrY3g4am01Ky8rYzF3bmdubnNjS1Zy?= =?utf-8?B?UVZHdWwyQi9ScXVDbDlCMDcxSEU1YXFiYVVacnBsMzBjSnNRZWZPOXAvRWdC?= =?utf-8?B?YzluWkRqSWhDdDAvdDJHRXZHS3hHbWJ0T3JULzNPRnAyclFsc1R6a2svbmpB?= =?utf-8?B?UVFyNzdpamxGb2xNWUtOeFZ0TWorYVdIc3k5b3QreDBLaS9QMWtzUDRkZisx?= =?utf-8?B?cXowZlhxZHErMUNWaytnbXoxakxmTjJwRVJXb2Fsd2VtanhRSjYvRjJKUmpN?= =?utf-8?B?MkFLbjZZcjBmY0k3aEdpTjRQRm9mb0RqbUtpSUtZNkJ3WVcwQ2pYYUh2WHFP?= =?utf-8?B?ZEZ5YVcrRmVNaFViWlNqQk13am4wRkRvVThCbFNsaW1NNmZFd2VYZnhDWjI3?= =?utf-8?B?QmdhUjJLREZweFNoSzhJZHRKTDlJVXFtMXZZYnBDdmxYUVg1VDNoTmQwSEVO?= =?utf-8?B?NDVoTW5iTWNUVW9yc3hFTDNqK0RtR1g5Mm5ucVhoWVZReGEvd3UxbElEM3o0?= =?utf-8?B?cHIrZFhWYkthbExzZFJXTTNEK01FNVdmY2FYZjRoOXhLWDJ6ZWRjalJKSzRu?= =?utf-8?B?VEQwK0l4Q2pJK1ZqR3haWHJ4Znlab0xBWXRmUTR0czU0MEZYQ09xbTBYWFMw?= =?utf-8?B?OVZZb3lxRDlFcGNUZnEvOXlTUWFZNWh0MXQ3ZGpjWlc2QnlmWHJYNTdUQ1JO?= =?utf-8?B?NE9PdHRIVktKQWg2OG91cmtjeHZNMWZ3ZzczK2MwMXorOHZlS3M2Z1lRVUJv?= =?utf-8?B?WGhjRjZNaDBTOWxBeDFQU00zcmVYV2NRUGlvMjhhNFBuOWRaZ056ZXhNSnJs?= =?utf-8?B?ZlZHUFptUUxoOUNsOWxDdGhXUU0valY0MWdKNEgzNWpCblpMd3NXUWdxem5V?= =?utf-8?B?eEx6aDZGaFUrbDdHWGExeWljeDFETFhIVGQ4Z2ZCSnc0b2cvMWZUckRELzlV?= =?utf-8?B?N2k3NGV4ZFlxQW15L1hudzZPREhLTnlidGFqNm91Q2tYRU00V0hsNHVyVTdu?= =?utf-8?B?Z3lvUEZISzhRWmdLWVB2WVIxV1ZnTDFoL01CU2owdEEvbHhUSVFST3o4MVFU?= =?utf-8?B?YVFjV0xTVWdjL2pKS0w4RlhSQ2d2Q0h2U0FTbXJCcVc1V0oyWFRleDkzeEow?= =?utf-8?B?blBlNzJHVXlnQzBWWENXUmJxak91blhqaWttS2hneUovYUNUNHdySGdJMXRn?= =?utf-8?B?Y2pNeVRoM2lUamV3VmgrYVRBR3hnSUZ6UDNrdlV6MEhvS0dEbCtkY0J4RVBy?= =?utf-8?B?UTRlSjEwaFBZSzlhVmloSGtJRDhUTTRXS1g4bXdRbWIvcEdsMlZsVmxWTjFW?= =?utf-8?B?d0pTb2h1cUdpcWdPMTZiRDNiT3lmVnBZMjd0c0puR2lUY1Npc1hSeDJiYzVC?= =?utf-8?B?UGtFRGdxcS9QOXNYNFVnekZDcjhvUkxSb00zNk5OSWVSVk1Md3ZjN2JlYlR0?= =?utf-8?B?TnJBbGI1M1h5V2dpV0FzeG00dFd4bW9BakNYWC9ZUHhpbU5ZTXdYRU5aYTBx?= =?utf-8?B?L1VEdnFEVHRFMWI5dVUvcWFBRmsyYmYreVdsUG1vWEdXU0I4d3g2dmZNU3RV?= =?utf-8?B?WXJ1YU1FekJqL0V6NHV4MFdIbDZNWnpvbURJL3J0U1JRTWx1Q1V2dFQrazdB?= =?utf-8?B?cTloMlhCazVaaTIrdStMS2tJVzJzR2FndnhQLzQvZzdWSkhvLzc0UjhQU3FX?= =?utf-8?Q?PjOHKwc0gOFmIqGCjlctT3uy1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4b3d4e7-337a-43b4-5161-08daa097e8f7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 14:52:33.7249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yCruNkCojh0lGy53CZq7k/iIPTjkjiX6ezwHPVZJ3ZmtQkaKK28Z0wYvuJWEBBwlU7wg695/kFJz/+CDIQmt/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9302 On 27.09.2022 16:44, Alex Bennée wrote: > Jan Beulich writes: >> @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes >> if ( spdx >= epdx ) >> continue; >> bitfield |= spdx; >> - nodes_used++; >> + nodes_used += i == 0 || !nodeids || nodeids[i - 1] != >> nodeids[i]; > > Is that boolean short cutting worth it instead of a more easily > readable: > > if (i == 0 || !nodeids || nodeids[i - 1] != nodeids[i]) > nodes_used++; > > ? If others (especially my co-maintainers) agree, I'd be willing to switch. Generally I've come to prefer that form as it often serves as an indication to compilers to try to avoid branches. (That said, I've neither checked that this has this effect here, nor would it really matter much, as this code is run exactly once during boot.) Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:00:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412745.656166 (Exim 4.92) (envelope-from ) id 1odC4L-0004lI-3E; Tue, 27 Sep 2022 15:00:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412745.656166; Tue, 27 Sep 2022 15:00:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odC4K-0004lB-W1; Tue, 27 Sep 2022 15:00:20 +0000 Received: by outflank-mailman (input) for mailman id 412745; Tue, 27 Sep 2022 15:00:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odC4J-0004l5-J7 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:00:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17579a1c-3e75-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 17:00:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17579a1c-3e75-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664290816; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HoL8XYNsx2xbxwUQHjtR2WimqObB3a+3dKCryKwFxVM=; b=NkqLlvA/kTFPQ3uUy0u1CKxoqcX6CpInL6WmNgke89HaizBU7hmbh+7Y cmv4RE6SshluwcUwu0ZclUPyOl24qPsdimCtj8iNF2VS6qEuYhTZeC1xK 3lSif/KRstXcbco40DK4cs7IrxyBtu6epbnZhUbWWMaBK8wFu+Frfvady w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81455231 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AkRSeSKAFbova8RVWkefolGt99h7EJp4KDTa0Y?= =?us-ascii?q?r1iHsdyfbJa/94HLcsJFMlSPqH4CM41jsrWWreElGSAQAlalYX0ke7CJO57b?= =?us-ascii?q?zywN8FA2AtTw1sb4YLeJSRDX7saEgeNzBnt1HGmb/DG3zdY8X4WChI6bh2Bs?= =?us-ascii?q?rfnxZqLMTu1ac2+RelVyP7sPCNydYRXEN4btivSc2CQcnYqPfCgJN9mgeNrJ?= =?us-ascii?q?nMI7+LAwfvdQxFsYKG8NwmId7Z9Gc/vy268T/OihKaNcDJRbVNs9eVFjTecw?= =?us-ascii?q?KIkdOCirsrZsHXhq/jLnAUMC2SK3PEN9M9gK4Swri2Cdk316eC8+8KsS+n4Y?= =?us-ascii?q?DnzZOSD54yvk7LrDGHiuUF9TRaruT/OnrCDztRgSn8xYmiAmhAM8KTe+SAaQ?= =?us-ascii?q?dr7lvADECAOvD8NycIaF2mSvhaHSPFj+wDUNv/YBSrlFfjMtBfXOXRehfl/0?= =?us-ascii?q?wPmM1s68ZzcXbRn+TbEbgUk4SGD2TQysr9yoZB4YJN2r0uvypx9pL6TXs1OP?= =?us-ascii?q?OF2rh/1/cDppsImEuPHehgaTvUdnkxDiJdZkI6S9emouLbAoRBJs7l9QJxZY?= =?us-ascii?q?rlZQXqZMOM/5KWZtVLN48z3MjIMGkIaXYeW6FGd5M1NVNF73W/jJdkXJW0c4?= =?us-ascii?q?DpJyMPW4NhiGmdLm7K5Zjkvv9ebJnEQtKhe1S1GIRcGpFAKErpOnXkEaNXx/?= =?us-ascii?q?z21E8xl74wiy5rfghcbTK84mfIF+QNBqrsbMnB90LipmwaeFH9UJ1WrCIfc1?= =?us-ascii?q?pC+pCznVaCH+ZHeJxjey0ozw35CM8D1VnMGEiHD07TDhpOqGIXBQ/UIrqeR8?= =?us-ascii?q?jhmV1L7uqftJnYiXmiBwW3mRivjj59fr6InTocJpCVFLhZKWDhZmusx3+sUc?= =?us-ascii?q?7XHnE32hpcV4yOUlHG1BhHXWua4TFcQgpirYb6kexrEa0+kllMGf4dSnb2cf?= =?us-ascii?q?ddFvs8YamJT8tv8+n53Q6JxVTr94oXR7cHAeRonaNRKZbsLHLmkuMNMksEe3?= =?us-ascii?q?uZjXiv2K5k1ct3sly4tXXOR0bTIe6X/CZ9752ExduthdJlKh4gaqHKDIGojL?= =?us-ascii?q?EomRAKrsBxvtAj13a2huNfKZXqvVHcapHQGDKuJKG+3O+ffbF4gFXF5qnIMK?= =?us-ascii?q?m5qJI8u2C8X9/KHF3YfEYufC3Wg84YFWT68Wvi6IuenayJYM08McDGIxnOye?= =?us-ascii?q?9LjRzJvzrdFl0MnhErtUli+YEiUUgIc8wTU6eQr0xseksKlshOnsqBykHtvy?= =?us-ascii?q?JrrniQAOk5o3Oz586CgbJGHHUiZDhvi+DFTYo2FgKXBwaksR9D4fdFfp86BZ?= =?us-ascii?q?rutDjE5nkgn1afkEV9Yw84576aIE/L34rpxvuiqofZ0nyARhx+EpvetVzSFa?= =?us-ascii?q?tR01x4V8qiHDc8UbWv8ifuBI/CUAmV6kuE+ndXr64MxuiO7G3ZP8FvfSKiad?= =?us-ascii?q?571ycsLtGZozPpcBX16LCJLsVMCG65Ssb37aquKABZhxpQ4C0TGLZe6u4HRr?= =?us-ascii?q?IhYiJqmsWF+5ybRjuJgeK4cD01OFxa7g/MO+KVT/P3r4+bO1S4LvERO1ksgK?= =?us-ascii?q?zm8w5vHpITE0Pr2leUDjaITJgl/cJcHI5KfKNVpXrQ+n05lLeTWHiM9YfUzR?= =?us-ascii?q?9xpYQgJNRikXZKc8UXIAgE03b+bexs3vx17qhb3knej5HyT7AI/TPUL4lJkM?= =?us-ascii?q?+U9n6dJ8QDc5PfzkIjuro0f1Umv3da4cLoj5ZlwP7rVcamQZGDMsMjMwd2Mr?= =?us-ascii?q?d4aReP1LNXpsHDYgCDaHOkmcdl6Y9AD8bnVqN8V2ktYPsGZALP8dZH9qzXFC?= =?us-ascii?q?KfkMsKzS5/v+oDM6og6zkCfprHNNCQlYExeYe31/dYmif1CajPJs0WLF1s6v?= =?us-ascii?q?k9UDvQ3JcOEDZtO89O8YfqnkUorfrqc9DR0iWUcLS8H0MGn6/3AAEcxdRaxC?= =?us-ascii?q?evLgyKXQpOOvaGG0O35AOgz5M+D3J3km/PiQdfx4xCbTy7EsslBM6auTorBN?= =?us-ascii?q?XWW8cUtghWg0WIuyd3dN5UnZVArAGg8V6QiNPQIpNSH2K2di/EfRly7cenMD?= =?us-ascii?q?pzDOX+xu1unlBkqzJ4l56F/jWkUX9Vv/th7iGQDGPQSv7eyoc0LGmpUqBjNu?= =?us-ascii?q?RgF3K1LkMVsF/agO2phlUIQPHHI9ty8xONIW22IvlJc5nS5ATTptnQlqkwy8?= =?us-ascii?q?vFgRi2TsUO8SxDJTFUrqviuiqsQsRTEN+RiUxCwPySmbGGlM+y/2UTow4OBu?= =?us-ascii?q?ye48vID7PTYUN33hxlWZ6sX/sWj6RHOrHSZpadHZbYfj5ck69tcbKFuyJars?= =?us-ascii?q?wSRWGzgm4M06IOeGl4Pmgngw5LEj/Nls+oR+YucZRK6nf0/SQ4JvV+iWwL/L?= =?us-ascii?q?j5Upbd7f38dyflTemjfDBPnLsW3dR/Uhr33KqGAbpWPD4x5Bh3LZNpxIh20b?= =?us-ascii?q?+RHCf3DsuM1fEUDiQGOQmxIlUwHxDMatYzsssW0P0m5/el8uT/SE6fTdsXSh?= =?us-ascii?q?mMJDF4YtLegwYRjBCotfpXZiNwCq0YBEDFA8q8ZkeGJWrJ9obXJ3M7jOQUyT?= =?us-ascii?q?Nn3hdNZXlKTP8srM0KjqVaSWyMlXzo0ZoDOk7a132DUCmVktciTPCAGmYCl9?= =?us-ascii?q?D6jCbj6b7m37hJr+Wx+fJuEz7p7WIuDUIUDSnV7wiTb/YQX7eDb7/f29ReO7?= =?us-ascii?q?aQPBDP5Dh4XFxpb+/6EBccApp/RcOSy5IWzipaYOdHnYmamfMaGFljViztZH?= =?us-ascii?q?J6w83INeUUNEeGi+9CwG9gfyo8lox0B2l3ikXbKQztj4m97RtZd2hwgURCO5?= =?us-ascii?q?e4wxChx/LJ/STSsGbIbRM+LcFqru7AC+tlbV8+kPMCE1i7cTU6UKV4e3wwnR?= =?us-ascii?q?l0cP2QFk/zOTN+LdBAVFtoBQHbGoEkZzJHh4EPMciCVhMiBpu24SV2ZnlB20?= =?us-ascii?q?9NBFXPYz78poUKZ3EfDlLgz9Xmg2tpEyd9p?= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81455231" Date: Tue, 27 Sep 2022 16:00:10 +0100 From: Anthony PERARD To: CC: , Oleksandr Andrushchenko , Wei Liu , Juergen Gross , Dmytro Semenets Subject: Re: [PATCH v2 2/4] tools: allow vchan XenStore paths more then 64 bytes long Message-ID: References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> <20220713150311.4152528-2-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220713150311.4152528-2-dmitry.semenets@gmail.com> Hi Dmitry, On Wed, Jul 13, 2022 at 06:03:09PM +0300, dmitry.semenets@gmail.com wrote: > diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c > index 9195bd3b98..38658f30af 100644 > --- a/tools/libs/vchan/init.c > +++ b/tools/libs/vchan/init.c > @@ -259,6 +259,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base > if (!ctrl->xs_path) > return -1; > > + buf = malloc(XENSTORE_ABS_PATH_MAX); > + if (!buf) { > + free(ctrl); > + return 0; I don't understand what you are trying to achieve here. If we can't allocate `buf`, we should return an error, right? Also, `ctrl` isn't allocated in this function but by the caller, so I don't think we need to free it here. Also, if it's free here, the caller is going to continue to use the pointer, after free. > + } > + > xs = xs_open(0); > if (!xs) > goto fail; > @@ -419,13 +426,20 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, > { > struct libxenvchan *ctrl = malloc(sizeof(struct libxenvchan)); > struct xs_handle *xs = NULL; > - char buf[64]; > + char *buf; > char *ref; > int ring_ref; > unsigned int len; > > if (!ctrl) > return 0; > + > + buf = malloc(XENSTORE_ABS_PATH_MAX); > + if (!buf) { > + free(ctrl); > + return 0; Nit: could you write NULL instead of 0 here? It would makes it much easier to understand that we return a pointer. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:08:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:08:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412751.656177 (Exim 4.92) (envelope-from ) id 1odCBg-0005S7-RL; Tue, 27 Sep 2022 15:07:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412751.656177; Tue, 27 Sep 2022 15:07:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCBg-0005S0-ON; Tue, 27 Sep 2022 15:07:56 +0000 Received: by outflank-mailman (input) for mailman id 412751; Tue, 27 Sep 2022 15:07:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCBf-0005Ru-Qd for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:07:55 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 288cb6d3-3e76-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 17:07:54 +0200 (CEST) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 11:07:50 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN8PR03MB4948.namprd03.prod.outlook.com (2603:10b6:408:de::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 15:07:48 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:07:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 288cb6d3-3e76-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664291274; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5+fHJk6tIT3fkB8+FHsYCgc7qWBK8EBs8eLiFNc6+mA=; b=JIXdJCjPsbK+V8RIa0WzUFUwSIcwGXcAWOF2lIH6J352kMAVS9ujItwy Lk65HPMAf7QP93uvoJtCi0XH94H/c8Yk6PMCSprMUPSKkC2N4ozLyqJot G/2RJkJgkKQuCVZd491qZHNbVlhGky07n4XKPcOTDNDCich0OWqVFkX7+ k=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 81876203 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:p2lvl6kSWZ/48xlyYQOU3jro5gx/J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIcW2mFM66JN2D2edtwYNu//R4A6MfUxtdhSlQ6/n03FiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS83uDgNyo4GlC5g1kOqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfMTlH1 eJAEyg0NT+Dp7+wnqKCW9JTiZF2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PkGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iL11rCRx3ugMG4UPK2ErvxNh3qL/WcoL0Q2RWqQr767kFHrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+8ry62OCUTBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDY5g7IfnMsazZKx9FrMgy+vjpXRRwtz7QLSNkqv4xllfoeja8qt4ELC8PdbBI+DSx+Ku 31spiSFxOUHDJXIkTPXRuwIReut/6zdbGGahkNzFZ488Tjr42SkYY1b/DB5IgFuL9oAfjjqJ kTUvGu9+aNuAZdjVocvC6rZNijg5fGI+QjNPhwMUudzXw== IronPort-HdrOrdr: A9a23:G74NsK05BQ0pHpgoMhZCMAqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8= X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81876203" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NMQ3jb9u/eMgjvU8bZ8PoPn/6c7egQ0By1PKa/QGgbSDvARsuVeXnDibm4Vq1m3jN3m0cYBzsqgcWm3VnyslFBOr7GzhYYRJ3fjITFx2deZuOzNQ9ASA5qNB4ZqwLTCmvrt1rkBkJLsZy9ginhjX04wagIVkcCCY0g8Lk1LZvHzN1Cfvc/FbbP7llLmb/66G9Kgl9kEBidHZvKQwWlQiw80vnvc6WlsbzsP2SkNE/BY2VAWIxSjFicHG9sSi7RbsGiwB4ENVdpo5nlXKhi0zJwL5u1I1LdBrbryl/W4wefZrv0QlD5WYWjPwuV4h8lNxpL0e2yeWHCtHbVxiiWZyrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a8NygkjANRAItthHsLMhTFtd9ouVqP19cXkomjrGyf4=; b=JmKpPQ5BTlj9BzFH+4EK+AepdnhIGhWnxo2Y37q4i+dp6n0BRGjiRY5V9JeXt+xzssEDGviZKi5a4mKYfakjPA13F8qA61rRrt8ocbhViYjis1UvFSC/NuoSFEEDLAn1UcPQDAnahyCqdtR5ThlQWb5uY98MA4oMD2FMNthpl0xP5p7IKAq3ODI7+yWenXRZlhR00ztCVEi0YsK2YMryST6HNMvGEEqmv1mPAgJidT4PoJ6QP6j/RnY5RIjAinpcu9XvpK1UBJzNoX8WzezlobfvdrJ2xghh8jdbdIb7ke2qlW2jxhWTEykxXK9oEVrMZjWPL9fRGEohwgnmHqNZmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a8NygkjANRAItthHsLMhTFtd9ouVqP19cXkomjrGyf4=; b=ufpGj9+86qIlg1YkJHbshhLJajno5pCrDTfjd9c1PCcVlX0edaCg5l6XuT9OxYfh2/HQCEOPczji367KZj2d75ck4Lw6PRYHwnGTeGxqyVCuP5/pmn0Kxr1KmzrIxuJHW7nQRFj/UNLwLJzZvymebDvnpeVdFlidfNcjktH7rlA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 27 Sep 2022 17:07:43 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0094.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::9) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN8PR03MB4948:EE_ X-MS-Office365-Filtering-Correlation-Id: 721e71e3-7e80-4a69-90ae-08daa09a09dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KF5f6CJZjqYU2dD7xCnhVyF3v/mK9n6tJqUeC22Fs9N3o5EPTIJgyHbfKdTh3rVs6qzeddUF6HFBjJ/NW9UShMUfOV9Ee4K7401CTMNt2cBr239TFa6hFS2N2TmI+7++sb2seCaD2tLPFRiHW7l06/h+obArHE7HHcUHDpwYhlyb9g2PPMWvY4/p0bt7lttVEXvP28j1j6Bcjt7Tk3i/rsUjlqKcdSbOF3tL1ybtNp1IZIMn8WHhZeeq6QZLimD6Tbmubl/TTfTBvBa663AOzQV0NrfdVLZJX9nGfu1xokLjg08mkGyGZuov+G12pXojwHkOANN2euIRauGbfrFBBEaNOjkpgJDZ6dSdGvWHCxi4la1gZeQQ2tdtjaklDZFBjNzHF+GnwxKY9ErDJiE9BKn7nrR2am0e60xgaemZbu6gaaYZJk2HA18t0Q/hYxPfY6h7pDUlJwUEtn9583vfWoaknGC5G0RSfSC1KYg3z9Kkd6ZSAs+R4xJIxV4ti0y0KWyKMEmGaxM4tbcsC9MYtLIU84s4NkMsGqOrkAH00pnVcCtdmpvy/lRisFgfB9juOYkRKLdDjWDcPQN9S9yUon9oIRRpp1DHgvK9pmQTlU2BXjVfDBNzqBUu8144ZXHQsr1pphP79tNcylTWxZmcSR/9cjyN6r8B+nTTEry6uz1Is2iHVgBuPaZBs3vB4bJ66V8tT1NuGDUoutLdhhYgVZjIHVO8n1MfF8lN8kF7MoXaUygys0lus7NlYEy5f7cd46FEdiXslaJ9f6kKjCzePw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199015)(66476007)(66556008)(186003)(6506007)(4326008)(8676002)(6512007)(53546011)(85182001)(107886003)(6666004)(26005)(54906003)(316002)(5660300002)(9686003)(6916009)(2906002)(82960400001)(8936002)(38100700002)(41300700001)(86362001)(83380400001)(66946007)(478600001)(6486002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUduUGNnc1pUTElHdnR2Y2t2UXJpdHlGdDh2WFBCZUY1ZnBvUUVIUlhXcmNq?= =?utf-8?B?KzlYRm9sWlZLSnErM2x1Wk05TkRIUU9YZFNOMXpPU1c5UmVmenpaK040TEN0?= =?utf-8?B?RUtLWjIwRTR4R3dUMzhqUHJaYXc1Sit2SzBNQ01xYk4wWFNXbUIwejRLS1BP?= =?utf-8?B?R3U4c2JaRStYYnVnRzdJZXhqUWhNOTdQQkpmNkg1UTdvMkNwamQzaFhLNUFS?= =?utf-8?B?NEJWZyt6YUVsemFWWjlNcE5Bb0hkUjJ2bmFuYU9VT01nRHJUN0pVeWtXSVZX?= =?utf-8?B?V0s2YkgyMWtsb3hIYzluTk0vdUU5SE1UVWJLK0lIYmNEQUV6STF6RXNkMkVZ?= =?utf-8?B?Q3V3elpPMzJSa1ZWTGI2VElMb3QwVERENUs0a1Z6U0JhYTNLU0t3MUduYU13?= =?utf-8?B?TlZuQnpYVm1naXArR25sR3FFVmdoT01iQmpuMENGMEh0cTRJRWNTQTc1bHBE?= =?utf-8?B?Sy9wajhZZmR4VHQybTltZzJLbE1GNFppVjdSZEUvUnZIdTQ0VXhnMVpwYWFQ?= =?utf-8?B?bU82aXJZMVhZMnN5OEwxdFpSZDhmaUlQdmZMRU5PMWpQNmdYUDJRK3hrZ2NT?= =?utf-8?B?cVlHVHNHTXVUTmlrNlVvU0JZNFlBTDY3c20vMzN1QnZON2s1VlF2NkdmQXgw?= =?utf-8?B?THAwLzZvajl2VW5YZnB5bUlVMmh6SGF3dzh2d1IzK2huc3BWeDMzbXdNWXA3?= =?utf-8?B?SjBtekdMOWxueTBObWJCdTlHdCsrSWh6QlFuczY3ZG1hTEpTcldNeVhJYUdI?= =?utf-8?B?NFVzZWl5azVSU0NyMzJIcE1MbUFyVDcvM0V5UllmOFZlMTNUcGl4RnFsTmJx?= =?utf-8?B?TWZ4ZU1SNDhVYVRDbW9MWUlCcmhGOVVTV0FrZUlGdldqV1ltR1Zsbm5aTmJp?= =?utf-8?B?NC9GQ3BwdWxqVkdaVTUrWlVtdGF1RW5aK3ljWlhiaGJkUTduamJJWGJvdzl5?= =?utf-8?B?UFVISnVEUTFkcFc2bTZNdHpuZkxlVGY5UjVkVXhTQnl2YXpQdkhtRlNzc3Fk?= =?utf-8?B?endWcjFYTXY0MEJjWWd6cUJxL0x3bkk0TjJYaGRVTHlrNFdyMjRmd2Y3elFO?= =?utf-8?B?MkFqSWJEeHluQ3lEdEtsTmFjNTNWdVlJdllMWG9zSS8zb3E1a3FPMDVTUWI2?= =?utf-8?B?ek8wa20vcmZPZ3JaT0lpems5bEtBc25hcmZkeVc2Znl5K2pnM3VycHI3MEZz?= =?utf-8?B?Z1QyNlBQVTZqQkoxSklud24rR0ZOamphdjVhVlRWQ2NoNURZL09oZkxiVTNv?= =?utf-8?B?MWM3TFFZNE5YQ0RzNU5QZzNTNHF0VE9reEpBZFEzOTl5d2Y5TDRPYndxMlEz?= =?utf-8?B?NFlXR1FzMkhDV3owN0VlWFNTVlp0aFk1WG1LYUsrWTJDM0lZYUZIWXpjWWla?= =?utf-8?B?YkVEeVkxUWcyNm9xYUtTQjljYXM2bW85SnJtM1VZWVp6VmNzTUdnT2hXbG1S?= =?utf-8?B?Mjc1ZWJyVGVrVnVpdDE2WVpQNDQwRjk3R1E2ZDVUeElzbDAreGpDVDB2aXJP?= =?utf-8?B?RFppV0t2Zk5Vek10MmFtdzZ5MXF5QldIcmhtMXlKZnNYTmhaanNlL0Y3RGhE?= =?utf-8?B?WVJaQm9wSEVtK28xN3FwV09jTkhXUEo1UVZyV0ZSdVJQSjFJUktOUFVhWFli?= =?utf-8?B?ZDFZZzRTd0ZEY0hLVVFRb3BCY3VNaFdHQzNKazgrUUw0anN2NFIzZ0RCY0pv?= =?utf-8?B?MTRzeHpwQW9BMXJVdGN5LzdCdU5TYzZlOE95SnhocFlGSkp3Nk9mQXFydjJa?= =?utf-8?B?RFF1R0lITnF2REdDMk1FdkNEK2xvMHMvUm9SV0FrQmZ6SzRueHdtQkU1UkhW?= =?utf-8?B?TW9SblROb2ZNVWpwOXFyeGN4L3ZoWS9Ld1RVMjFGTVN6WldGeUZtZ1o0bFZv?= =?utf-8?B?aVZMdFBoMkR3WldvUnRGTkhHR0JpQnNqUUNnbk1CWGluWWZvOUliT1dqLzZO?= =?utf-8?B?UWpIWWpJVlY2cHhXWG1VMDRJSm94OFVDRlNwZmJPMzZPblQ4aUJIbVo3TTcv?= =?utf-8?B?OWwyTWhkblJhVEpNY09lUGx0ZjIydFMyZGZPRS8xUHJRN2hWY3RVVTRybmVX?= =?utf-8?B?Nk9Mak4vR3NZUWJ0SDNHR2xQMUM5RE5VQUNWSXFqL0hXcEw0Z1BzejNzNDVW?= =?utf-8?B?YXdHK0N0NHZiTXVjOWZUVytIVDVQQzRQaXFTMzZhV3dQTEd4MkN4TFNUSlRp?= =?utf-8?B?MUE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 721e71e3-7e80-4a69-90ae-08daa09a09dc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:07:48.0953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iKzr7P+sib9F7Fu0qbowxXuckNwSotmELGnTUeaK+iCIsOaE9RaDA/kIXuyzdE4+VxQAgKQzaN6nW5lpw0VH1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4948 On Tue, Sep 27, 2022 at 04:32:27PM +0200, Jan Beulich wrote: > On 27.09.2022 16:14, Roger Pau Monné wrote: > > On Fri, Sep 09, 2022 at 09:22:52AM +0200, Jan Beulich wrote: > >> While I was suspicious of the compiler issuing a diagnostic about an > >> unused linking-only option when not doing any linking, I did check this > >> with a couple of gcc versions only, but not with Clang. (Oddly enough at > >> least older Clang versions complain about the use of '-nopie' now that > >> we actually use '-no-pie'.) Filter out the problematic option in all > >> cases where the variable is consumed for compilation only (which right > >> now is everywhere). > >> > >> Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") > >> Reported-by: Stefano Stabellini > >> Signed-off-by: Jan Beulich > >> --- > >> Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for > >> compiling, the option could be omitted from that variable right away. > >> But if any compile-and-link-in-one-go use appeared, there would be an > >> issue. > > > > Is it feasible to have compile-and-link-in-one-go in one use feasible > > with what we consider embedded (firmware or kernel like binaries). I > > would expect those to always require a linker script and a separate > > linking step. > > A separate linking step doesn't mean this needs doing via $(LD) - it > could also be done via $(CC). There's also no connection between using > a separate linking step and using a linker script - aiui the linker > script could also be handed to $(CC) for it to pass on the option to > the linker. There's one thing that puzzles me, if we already pass -fno-pie for code generation, do we also need the -no-pie linker option explicitly added? I would expect the compiler to be clever enough to automatically pass -no-pie to the linker if -fno-pie is used, otherwise the code won't be correctly linked? I would rather prefer to remove the -no-pie option from EMBEDDED_EXTRA_CFLAGS and just add a note that users wanting to link-in-place need to review the set of options used. > >> --- a/tools/tests/x86_emulator/testcase.mk > >> +++ b/tools/tests/x86_emulator/testcase.mk > >> @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. > >> CFLAGS := > >> include $(XEN_ROOT)/tools/Rules.mk > >> > >> -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > >> +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) > > > > Is the x86 emulator harness correct in using EMBEDDED_EXTRA_CFLAGS? > > Yes, I think it is (here): This is the script to build the blobs we > then have the emulator process. Of course it wouldn't be right to > use for building the actual harness executable. Oh, OK, didn't gasp it was building blobs of code to pass to the instruction emulator. > > TBH I'm not sure the naming and usage of the variable is very > > helpful, maybe it would better be STANDALONE_EXTRA_CFLAGS, and drop > > it's usage from the x86 emulator test harness, open code the needed > > flags for that use-case. > > I agree the naming is, well, odd. I would be okay with the proposed > alternative name, but I also don't view that as all-so-much-better. Anyway, it's clearer for me, but I agree it's not much better. Let's leave the naming discussion for another time if you don't think it's much better. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:22:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:22:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412763.656197 (Exim 4.92) (envelope-from ) id 1odCPE-0007wv-9w; Tue, 27 Sep 2022 15:21:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412763.656197; Tue, 27 Sep 2022 15:21:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCPE-0007wo-78; Tue, 27 Sep 2022 15:21:56 +0000 Received: by outflank-mailman (input) for mailman id 412763; Tue, 27 Sep 2022 15:21:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCPC-0007wi-K5 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:21:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d75a580-3e78-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 17:21:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9665.eurprd04.prod.outlook.com (2603:10a6:102:240::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 15:21:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:21:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d75a580-3e78-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSbCOFTgTxAUjArXcxHAiBx2ca6znvMJncQzW2YZNhrmMTYl9xnaDR+kj1aNmxaVOQfr+sx/eAuomFW4+dKcqh3AcP+ZFSqVT6t6LJfAfIsWFXgT+J7yttS8baFLoeICkzOPpfpk+KN8865GV3mHgZYsHEsnbIOZFiEpHOdspi7mT2kP4IlkrP6yMf7Na/5rp8S3M8taGhS6f7zoQQZ5mN6u8ITx+iMDIcXzG+3+H8ueuPJs5QL7asifoyE0hNcLA/QccsS1IY/TAcqGuyVIZXm1dCDFU/xSzqSM9RTecONHkA92T7UclAo6rCSy89KxD0y/igWkKk32XfqPNl/WVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DcDSxOnQG5nOtWuyCpfsnObR5HOAxZ7DEIRp6E7ww4w=; b=EmbEZ4U3OcB1T7Vy8UBtDVF0+dCw4Eg1zyOsbIkC2xd1nI77DkXTWy/sWgnos8P0PKdzRXYz3jnUU684mMKMpIHDrhHbF/KPH7a6pND84eFWCOAdd1T90VTrB7EetwfBxZu7CAHbbreMj8GXNnE3eyps2IynGXsR58d7gNWtdrrXicG4Ulal7i0uH8p8KLj21sMpLAc3RUwQPIhGrbU7+cKzHFYDyRjaRZ67COsZph3jFB0q5P6dQkeJPQdKewrD3FqMRxTABbKtQ+AcjUZ3yNr5OPFOnljxI4LOlKJTbX/ddZ40RqxuuucKa5jNrPtJjI2ZDDNDvn2by/lHTXBBkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcDSxOnQG5nOtWuyCpfsnObR5HOAxZ7DEIRp6E7ww4w=; b=VpjXkC3cSoDzoWtzb9mwoqr+VfZ9ZHAug22mkTjf9tCMWL7LkX8kmWNBbHJPCZOxgMcMPTLYUsui7fUGOHpjwkoRAXIie6aMykkJxXmadWMeOPdfiaP6FTxPICkH5ue5Lj2o/T//mMBpa/CdoF9sPUCUeRdDSNOXwmnjJ5Pu/htmdWk0EfjySlMOr3aIYUDKJt+dHr1p9iiHD5idBEZ1fmbmey97xviCV46N4mmiFaf3gMbuPYADnpskxaZlq1qNUYfMGd9CVV0/9d8x7W2Dsu99OjA4YEY6v3eF41QIvSTJx2Fq34nBHIAzS6FgP2wZlCTHiFiptrnG+AsQRRcXZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 17:21:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0175.eurprd06.prod.outlook.com (2603:10a6:20b:45c::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9665:EE_ X-MS-Office365-Filtering-Correlation-Id: e558ed5a-ac12-4d6b-3419-08daa09c0033 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dzpfpFjLqukhN2VUMDQ2+bHIQDt33AGPsdoesZHdtBIY5YIUW3GG3+291yHhC9DLbaHesrL6AuftykJUuizh5UgH95VIrhjinTRVWflS5xaa1FY1ZOUqmvGc1rpyqt+CQ6noHyn7bosX7WS89fAU42LpNbrxGsUC6yVJ0EXKPo2IJuRX3RAgUGdIvquDOhR4M+PFBiOkfXUrMxZmVPxcN/bTBGlJm9wFNZU7pv0Ifv9YckFpcSpCZHku38P1OoKFUfS0PADb8HpgCeP8FCsAq75C70rVPL2Ms8ORvquzrWZyMJrsEUU8+PRonHVTrsrwCWgYPHmlJGH1qR0eUxchWwjZ74LfpvNRfDl+64GdtUUumdFTTuYLgOWs1dmJt4g6Q+Vl6/NTj3LOLEccWi7arlnLdNgV/WHJ5rB6LUYsMA+nHoPZoXn25sd2PugUtXLPDJppW5WUm9NbsiDXdVPnymcfO6AbpC/Q4kCHjDf1Bw/vSIIW0ODdKIXyhyZp/qxlIPUcTyc7BlKpodpgEjIwcjhjF5TszRlTeAzqMVJha5Qww6w85TlTFjrAWwJsFvZpvapD0AnmkZwcwupFKk3Adr2cJan76IPf0T+TX+AjxqlFJGOQQNWNGzPrS4LQjcdRpFm2HeyqOGgMmBliGg1Z5Qy02htoEQ+Xa9vjhSk00Zz/9d1BPALsgIhPA+LJD24Qql3q8om62SUGD0mr/ukRUXMpvmtnVJm/uKMetHXm5+vUXgmvmaxPyTG6uCatBa7XgkbU+hkNdnOqBTOd5mJ8Fe8vdJiSS7fUI3vfxcTT+x0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199015)(83380400001)(6486002)(2616005)(86362001)(31696002)(186003)(38100700002)(6666004)(8936002)(316002)(66556008)(2906002)(4326008)(5660300002)(66476007)(41300700001)(66946007)(54906003)(8676002)(478600001)(6512007)(6506007)(6916009)(26005)(53546011)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0R1YU5HemI0dFdMbEUzQkRvSDdBeCsveEgvZGtjZ0RmdTJxOEhlRVJMT3Nz?= =?utf-8?B?TVMyaGxGNHh3TzlSQ3orWnF0MVlTVDg0Y0dRQmhpYkdtVFUwYU5LaVZ5RWgy?= =?utf-8?B?Tkx0SzBick9EaDRpam9VVmYramZweVBDMWxCVStJMkh3dEhxNEQ2SXZkdk1v?= =?utf-8?B?RzhMOXA2a29sVUZYaVA2YUFCcklLUjFYenFYSnJYaTk4ZGQ5cFk3c2pKSXI5?= =?utf-8?B?OW1vN2E4SGFXMytoVXBJZHprdG9NdDh3N1UwVERqd1ZZdVhtOVcvcGVwYmdx?= =?utf-8?B?ZnkxSDBUTGhXeTMrTW1odkhUd3V4MnR2QXFFd2kyNmo5S1hnbXFoMUQ5cmVo?= =?utf-8?B?d1dxRGRXd2M3cDFUWWhDaVBhYkJxUkZFazhKNUdmM1k1TVl5RTRXbmlSaHpK?= =?utf-8?B?OHhxYkMxUlBOT0VSL2dwdlVEN2hicW1aNUlWZSs2UDhUNWVTZGthNlJtOGVo?= =?utf-8?B?YXpuSFRHc2ptdDhlbHg3eSsrcy9kT1pTcG0yR2ZnbFVMeE9BWkNrU0xodXZD?= =?utf-8?B?QldFTFZYbWM2NThTKzRjS1ErNnVQSzcvMXdnMEtVczFSWkpqMXl2bm5VS0No?= =?utf-8?B?ZHBreGRxdEM3OTJXdG15dVZvMmZsNUR1aklOcTNYSHFCV09rdTVhb0hhekZk?= =?utf-8?B?OGRsRnQvdnlKZ0JRWXpCUlgyQit2Y2pINUltbkZCR2I2RjFVTitqaDUwN0NV?= =?utf-8?B?UjFSMDZsQnBjUEdraE1TM3kyMDlpVVkzTmUxbCtYOUFraWVaWGg1SXVlUmRT?= =?utf-8?B?NGpFZjQ4a2cvN2VnNnZFMGJGRkZKNVg2Q3dtZzRtNWsyUlhjcjNvRE9BNWZo?= =?utf-8?B?anFTcWVSR3dWQ1RJeTNlTU5Ta3lBV0VmcGdiN1NReXcyT1pBakFiTjFHb2ZU?= =?utf-8?B?Z0RPT09FQlRkWHZGT2twUmNBeFFibnZNN1VmQXBqUDhKOXMrb0E4cXRtS0dX?= =?utf-8?B?NlpJRkNmdmFQNHZzUUFFamdKNHpmVkFYdkRLaUllUjN1U0NpSmx5ckFkaEdn?= =?utf-8?B?SXNYclVJZklnOHJ6b1JmcUgwTzdkaGdlcTcrc09CK3RySEZzaGw1ck1JUUlX?= =?utf-8?B?ODRtTjJWbU5aNkwxei96Ym1yV013WTd4aU1SMW5xOHJpeUs0V0ZIcCtLalc3?= =?utf-8?B?NDl3YXYyeFNJZlB4NmljT2l6bnYvSzhEdG9mNDZGSjNOdkhZRmJrZGlGZi90?= =?utf-8?B?cnlZaUZKeS9RYlZFYW9KTXB6dEVWcTQ2Q0xTUGxkNDNNSmdzTUdLTDVFZG5k?= =?utf-8?B?a3N1ZXhEOVhXckFra3k4K1A2TnRxWEJ4ZGIwWUNNRlN5aDBMTXRtb0phZzVt?= =?utf-8?B?KzhIdzVYa0Qva2hLS1V6QmZwTWQ3aWNkclhTdUNTYUtjTVpqR0xiYXp5Y3JP?= =?utf-8?B?YXhYejIwVVc2TGdkZ2l1L3pkVGw5UTJYa0QwbERNOGdleWpaZ1d3bjlZMDRl?= =?utf-8?B?TVJHZGhwSTVvTWFMSXR4SHprQ3h5dHQ5NEozK0UwY2RTR0JiMTBsMGNqQTRN?= =?utf-8?B?Q2M4TlA3NWpXVkRuZDk2LzdpTVVYcS9iZ21zSkFFbHBPMFRWbHkyR1krdW1m?= =?utf-8?B?Rm1sckc2cVJCNGJRM1R3UnlsMnFJSDhHYzB6bzZnbzJkZXpHR0s5cEVBaGl2?= =?utf-8?B?MWxUenhMbkh0S0FPT3ZHZ0xTN25EM052Y2svSFNIWjVPSmxOV2JpZURlUk02?= =?utf-8?B?TXg0L09zbm1GZjdBNDkzWkdNQzRWcW13VVJwajNkTDM1Y1o3ZjZOZWJXYUYz?= =?utf-8?B?YTJBVDdobHpBQVBYT2d4bkdSOWpyUEhoSzhJQWliTkhqWFVneU9JUXdkdkZt?= =?utf-8?B?OG83ekVVWG5zT0s4SmErc0dZS2t5aHdJTVVpdDg0OXlFd2U2ZnduQWRyRlhx?= =?utf-8?B?WEVWcVNlZzQ4NDBNeHFTd2xxU2Z5L3c1UW1VSW9aM3VLcEtvSUQ1bXpibXVS?= =?utf-8?B?d1V6U0hRV3NuOGtLT3hlbVczNlNmZUhvSzEvT0dXbENPM0hLc3JycGJZd1Rz?= =?utf-8?B?VUQ4NU5zNFdPSHE2dzZHcUl6RzkrVUhCdWxpdXV0S1JOSnNlOXk0ck92Nk0r?= =?utf-8?B?Qk5BSkZhMjA3WmdmZnNaRmJpQ0xEYjhSUU5vQXBzS2cwdDN1azg5OXVvU2Mr?= =?utf-8?Q?q91+uim1UxiMJf6LFi6DR0jIY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e558ed5a-ac12-4d6b-3419-08daa09c0033 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:21:51.6606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0VO56ivf1D96dHX+UazaaYpMUytg8wKpiepTC8tMCxLlM5aOR5rCkPcwVsbFERlKB3Fs5pjiVAWzzk2pSfIxHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9665 On 27.09.2022 17:07, Roger Pau Monné wrote: > On Tue, Sep 27, 2022 at 04:32:27PM +0200, Jan Beulich wrote: >> On 27.09.2022 16:14, Roger Pau Monné wrote: >>> On Fri, Sep 09, 2022 at 09:22:52AM +0200, Jan Beulich wrote: >>>> While I was suspicious of the compiler issuing a diagnostic about an >>>> unused linking-only option when not doing any linking, I did check this >>>> with a couple of gcc versions only, but not with Clang. (Oddly enough at >>>> least older Clang versions complain about the use of '-nopie' now that >>>> we actually use '-no-pie'.) Filter out the problematic option in all >>>> cases where the variable is consumed for compilation only (which right >>>> now is everywhere). >>>> >>>> Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") >>>> Reported-by: Stefano Stabellini >>>> Signed-off-by: Jan Beulich >>>> --- >>>> Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for >>>> compiling, the option could be omitted from that variable right away. >>>> But if any compile-and-link-in-one-go use appeared, there would be an >>>> issue. >>> >>> Is it feasible to have compile-and-link-in-one-go in one use feasible >>> with what we consider embedded (firmware or kernel like binaries). I >>> would expect those to always require a linker script and a separate >>> linking step. >> >> A separate linking step doesn't mean this needs doing via $(LD) - it >> could also be done via $(CC). There's also no connection between using >> a separate linking step and using a linker script - aiui the linker >> script could also be handed to $(CC) for it to pass on the option to >> the linker. > > There's one thing that puzzles me, if we already pass -fno-pie for > code generation, do we also need the -no-pie linker option explicitly > added? I would expect the compiler to be clever enough to > automatically pass -no-pie to the linker if -fno-pie is used, > otherwise the code won't be correctly linked? For -pie gcc doc states: "For predictable results, you must also specify the same set of options used for compilation (‘-fpie’, ‘-fPIE’, or model suboptions) when you specify this linker option." I infer there's no deriving along the lines of what you suggest. I'm also unconvinced of there necessarily being issues with correct linking. I can see there being executables where mismatched options simply don't matter. > I would rather prefer to remove the -no-pie option from > EMBEDDED_EXTRA_CFLAGS and just add a note that users wanting to > link-in-place need to review the set of options used. Which then raises the question why it was added there (in a mis-spelled manner) in the first place, years ago. That uncertainty was the only reason why in the earlier change I didn't go and remove the option altogether. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:29:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412771.656208 (Exim 4.92) (envelope-from ) id 1odCW2-0000Ge-5U; Tue, 27 Sep 2022 15:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412771.656208; Tue, 27 Sep 2022 15:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCW2-0000GX-2f; Tue, 27 Sep 2022 15:28:58 +0000 Received: by outflank-mailman (input) for mailman id 412771; Tue, 27 Sep 2022 15:28:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCW1-0000GR-35 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:28:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2042.outbound.protection.outlook.com [40.107.21.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 196af4ad-3e79-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 17:28:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7339.eurprd04.prod.outlook.com (2603:10a6:102:8b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Tue, 27 Sep 2022 15:28:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:28:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 196af4ad-3e79-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjjF/Iq7LreQgAwbyj9W8kTaVLzwqL6GWdmJfrfHSHmWEExqw3uYN5OGj5mTlOi7JyaWXtxl8qQzDKz3ZinlSpe6EyvonSb2Elok0PVhXXaBhGb8zpDSDRDMUwRnAAoOnsjt+FDwLJxsly6xzhsmCIqnnZMMXjkBsSDQWXGCEHf4sJCPWlJCYMp4A9U8V6SuJv93qEz2tEbFAXKcx17T0SVv7PyYeLKILmstX0rAHgzcN/oNh59kYdsp9wTFCHM0rtTbCbaRVkFCUBr+fl2ACF3mSJzAmKtzqLBIJgU9AyDKHQ3U6yxpitgklxeEQB7QnS6AmL4YUq8aJmm4xtLnjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53kokOxlv3mhNzEXo4N2e7qjZ7GtvDibULuNMsr4bFs=; b=QRkQjqdFfDKiPcBEpKblWJVT2vWwlaKWvwGJQY3m19gkcYNxt5/Ef53qPG3rFAgY4FvKMGil7lNJ/G8NluGHN+xD0Y5sCnd6MNJEzM1M7ZI2u2fN9cFujvixVf5JuidR8PfmAqyx/FZ78McGXuAXn44VYdk1S7Hex+dRvLSTbJ206vYy9e8q+inDFr+WAHOPvIjeyePPyeoPuHY/itBazD3b3AXe5ywAZFJ8Td2XJc3CVe3GosbS4r+hpqZvZncKMJ9V1aQP5PWOfMRd2gNTMOnfO16lbaLLZ5i/kdk6yybXYUdUcSGbMqIWv0LsJ7hPjfEtbiJWr7be0GL0ouwMcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=53kokOxlv3mhNzEXo4N2e7qjZ7GtvDibULuNMsr4bFs=; b=RFQB+EMAWxBy0xkD95icquL/r3ZxqJ2fu+nIVzTTJ4bTD7B3TcHxG17bTg8btNBUYHPeeTz/d+6UmMifwWlRUOQWY6ssRynRxBOMiPb51eKt66cz9LrmYAvzhl8NhWS8o9cqAWCI3GWZXa3IW/UldRxjJSs9vfg+EQ4oeJXLcQ+ejOVNFzokvPkakKrcqGknY7c0jK49r+8NvBFqE59NwCYNXbBLfavz+TUVuMew1bnZwRyxsC/xkuYLnGBeUAuXHmOSuvof2LeDYRqizoH+AeVaN3EPYSaf7ABic1C8Y9R5mH9uwBRpPyunb/Cm6K2Q16syrA61O7uiaooQ9Q+wRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 17:28:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 12/12] xen/arm: add cache coloring support for Xen Content-Language: en-US To: Carlo Nonato Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri , xen-devel@lists.xenproject.org References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-13-carlo.nonato@minervasys.tech> <93471d92-bc61-56fd-5b52-413303d35da1@suse.com> <8ba1ede9-cd8c-01ec-939c-e0915d7c18b4@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7339:EE_ X-MS-Office365-Filtering-Correlation-Id: 20f02266-666b-48fc-d1ff-08daa09cfc43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JRuKZtwyanOqM2y3IkuEzie1tXk4lEI2puHNwQl0cgk4mQoYubjZ2HDztzdotw7I5miquw4vDXZAVlsYrY2IvozpWGO9VzCcZCNq+sGpGPirCbZ6epmBIompc8anlmT8Uw8d49um8AD7cDoGe0f/yc+1mRgzdwquIWXAkOKNNQgUyhW/M6Fm74xRSKah7oKBHVGVUYlsR8Ci6MPOlwvrv83pPWdbxsVPWRmSoiKj9UgsIAtf7E5toHBKmJCEf9DfOditSXzBzTGv2e1c0PrFMnTlFqY0eOH/wUek6IOc14/CYeXayXzLqe5J7fH9rrxjtSIZEPpfT3MHOp0bVPpd9DncjxoCbHI9kApD2wCTANLlqvlHZ9fLlI3AqH5zdN90Wz/Pri4hfiJw/zjqCWJdQXMXn9M3HLNn+o06Uyf4w+onvh4LVmtFqTy+t2nJae5MU3+NnKF4RwLt2LXn4+TPJRtT9PkJRK1oUVwcCKJ4X+T3eAyFwmn0dL3DGMYxEcNPal2zqq7MzoKHFPt+2+bAf/1LP2URcp8jnLpDZoRYqBhZcHmpoOOAP/p2UJKvhb5Aigy8dmspC26JZIjJccuhnPw2FCV8Rua5tvCZbYWpb5h8bU8+Enp1n8vsRwOavjFWNHxLlDbphmDl7+nUtmWeTWkbGdJdnQnnqEpcxuDa3QWpxiM1izxT8z07gBeQOp1EL/Wp4WunnmyTNtSZTyUwo1zCBBq2DfkEUZoopXB2YBESPSk8+8cctVru2VKziif3Jvxgm8Vv54/V3SBvmyjNoh6gnrB0A2pSIPha0P2iziY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199015)(8936002)(316002)(6916009)(36756003)(2616005)(31696002)(86362001)(4326008)(41300700001)(8676002)(66946007)(66556008)(66476007)(5660300002)(6486002)(478600001)(2906002)(38100700002)(6506007)(26005)(53546011)(6512007)(7416002)(31686004)(186003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHltT0w1ZWk2bnhodjBXS2cxRDB6T0MzVkNCdDE1S25xenV3U0xNQ2dNNHJI?= =?utf-8?B?WUlzVG9PRzBhOHpGU2FWSUw1bzdlOFV1WUt1ZytQZVV3Q1MydUMwVUIxeUda?= =?utf-8?B?aUFtWVVPTDY5eWpBWHFEUXNaUEhqQ3gveXluUEJ5Z1JOclI3VzRvdkN1MTlY?= =?utf-8?B?bXI2OUZDN1JYVXJ6V3puQ1Z6dVV3NUZEbVBSbXRpWmx3UlN2UGlDVnBCZHln?= =?utf-8?B?aXRoN1VIRFlPSElGanRQdmJmc3dOVkNPWnVidmxvRWdFK0tTRzJmYmZjOWFQ?= =?utf-8?B?UXlvZ3RXNWR4ZFpnLy9YbVU3QWlGb0dpSHo4MWpJSm9FN1l3MXZYYVFSb1Zr?= =?utf-8?B?NWYzOCttbWY5Rk9LQVRvdEFSSXNIWDBQWjBSemFGSldTYUpwRURuREQyK1Va?= =?utf-8?B?cWFCUVdVdnNZWTBXQWIxVDI2TFdmMUZXZkVaWnBvc3RWQzR2WDN0eFBzQjVj?= =?utf-8?B?dzlZU1Vyck1tbWUwakFUUzB4SWUxWkFRY2xHTkxUVlZIZWd1ZlFzcWNadUxO?= =?utf-8?B?bm9ld3Y4K0JlZ21hQkVHVWNSUlpIYk4zeUxCVkZHeHk3NEtFbE83cllNNy95?= =?utf-8?B?T3VLQjlXU2t6Vkt1MFJjMFpXUmVMUGd1RFBrNzBZNDBtVUJEaEFBVldtanJJ?= =?utf-8?B?Y015YjVhV1Ryc0tuT3VtRzRlWlRPcGU0U2pZZSs4WEpPSFZ0Nmpoc1RSa2hU?= =?utf-8?B?Nk0vZEFBMXZERURaSFBDV0h3blJnb1diQnFJWWUwMEh2WGdZbHlyTlF0ckJL?= =?utf-8?B?OVpDeEdKeVN4TmtkQTl6MUJEWHp1bHJvZGdMWGh0UFpkVitiUjF5SUhySFpM?= =?utf-8?B?QTJRaDVmQk9FTFd3VTkrN2RWS1QrRzRaKzlqelM1dStzS3pQZWxIVWt3NENB?= =?utf-8?B?TVpSTG1mVEE0eWo3UGhpdWsxY0ljVWVENlcvVWhOTFZGQ1dmL09FTjlHaHNn?= =?utf-8?B?UXlObmxlYW9hd2ZkcmNycEVHTmszMGxxY0pYWUdJWGM5VGMvOG0rdWdmQ2FH?= =?utf-8?B?MDcwU205aHJabXZnT3Nya1NidjIyQTBON0RHUW4yU3d3NTVCbkN6NFBKdlJk?= =?utf-8?B?S09CSDErK2d2WmF1azZKc3c2M0xOWHk0MUVHRSthL3ZXZldjNG1jL0ZqekUw?= =?utf-8?B?NUZRN2NMMmdMMlAwR2Fidk11RHpEbENQUHZ2NC9UeEM2cVVIVzkzei9HeGtF?= =?utf-8?B?YUFvUFI1VW5weHBnN0ZVekpvdGFVaGd5dHJ2MTRwOEtTWW1VRzlDdlU0em1Q?= =?utf-8?B?YVFkMjRUcjVKb3hQKzZ0Z1FraUd4Snp1ZkkzQ3FhZmVKSjBmWG9GZzloalQr?= =?utf-8?B?WnhzblNOM3hVamJSM2NNcm1IVkJWY2QrcW56aWIxRm4rTjdKTmtwTUw5aXps?= =?utf-8?B?Ti9WNGJyY3NJRGtUTGF1cGhSOTA1VkRnWmdaSEYrb2R3bWxhVkQwQlp1ODJW?= =?utf-8?B?aXZRdTNtTkdUWmZVR0cwNlhYbTdQaGZTaU1FVmo1b2dtVktQVkxCcFNraGkz?= =?utf-8?B?UmNla0J2VWJVUVNoMjl0WGJuR3IwOWs0bWZwTXpwYVJLdDFEVElheEt0ckZJ?= =?utf-8?B?b2RwdVRzL2RwNktGSGpTNUxEZ0xaNnJHVGQ2WkxLWEJEM1Z3dU9IM3NKbG5r?= =?utf-8?B?Tk50VGJHOFpVekFtQTdESE5obWVUMUFWQm8yZGVWbVRLK0pIRUhTQjhjWlJI?= =?utf-8?B?WVpiMXdXdk5Nb0hyK3BTZ2JsUXpSZTM5enR3NE5kekUyaDVYTGJFelo2aHVk?= =?utf-8?B?aStNaXVQT09mQkdNTlJTWDJGWmtpOFZBa1FMSU1OcGkzbHhkUGF6TEtQODli?= =?utf-8?B?cmpxZmdaakc1V3VwYUpyWXVXQis3aEVqbXJOZEFuSmsweDRYaGU2VzVoSERD?= =?utf-8?B?OHRDSmRPaWlUc0k0YTBTa3lYZ1Qya0ZjNURIcTdPb3l0UVNLbEZMbHNES0Fn?= =?utf-8?B?V2sxUFNmaWIxR3lKK3ozc3dnWEkxWUpYaWt6ZTlueVF1MCtMME9rK1kwK0ZT?= =?utf-8?B?REF2V2tobnlwRXo1ZjRVazZFWFprMzVkcC91dEowL0o1QkNmNjlxdnNrZVRU?= =?utf-8?B?blY4YWxHV0Z0YzhxemIxSTNPSDJGUjEycUdhV01rZm9Cc3JyK3YxdDZlMWF1?= =?utf-8?Q?n5vYJDy+xXiclWhIciAsP1S9G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20f02266-666b-48fc-d1ff-08daa09cfc43 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:28:53.5710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gegTpDsOb06B3glB4CXcrd/1XA70+frG2b+DCDuz+L7nshDX3pBlznuHwmkE9KIX6rRPSwOSDV31BeVFD2UOIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7339 On 27.09.2022 16:31, Carlo Nonato wrote: > On Mon, Sep 19, 2022 at 10:38 AM Jan Beulich wrote: >> On 16.09.2022 18:07, Carlo Nonato wrote: >>> On Thu, Sep 15, 2022 at 3:25 PM Jan Beulich wrote: >>>> On 26.08.2022 14:51, Carlo Nonato wrote: >>>>> @@ -218,6 +221,28 @@ void *__vmap(const mfn_t *mfn, unsigned int granularity, >>>>> return va; >>>>> } >>>>> >>>>> +#ifdef CONFIG_CACHE_COLORING >>>>> +void * __vmap_colored(const mfn_t *mfn, unsigned int nr, unsigned int align, >>>>> + unsigned int flags, enum vmap_region type) >>>>> +{ >>>>> + void *va = vm_alloc(nr, align, type); >>>>> + unsigned long cur = (unsigned long)va; >>>>> + paddr_t pa = mfn_to_maddr(*mfn); >>>>> + >>>>> + for ( ; va && nr-- ; cur += PAGE_SIZE ) >>>>> + { >>>>> + pa = next_xen_colored(pa); >>>> >>>> This may alter the address, yet the caller expects that the original >>>> address be mapped. I must be missing something? >>> >>> If the original address color is assigned to Xen, then next_xen_colored() >>> simply returns that address. If this isn't the case, then you're right: the >>> address changes to the correct, colored, one. The caller should expect >>> this behavior since this is the colored version of vmap, the one that takes >>> into account the Xen coloring configuration. >> >> That's (to me at least) very surprising behavior, and hence needs >> properly calling out in a code comment at the least. >> >> Personally I'm not convinced of having a function with this behavior, >> and instead I think the normal vmap() should do. As long as you're >> only allowing for order-0 allocations, that shouldn't be an issue >> anyway. > > You mean creating an array of colored mfns (I mean with a colored machine > address) and passing it to vmap()? Am I understanding you correctly? Yes. > This is the only way I can see to use the original vmap() and respect > the coloring configuration at the same time. But isn't it a waste of time > and space to create this array? Well, that's the price to pay for non-contiguous vmap-s. If the added function really is just an optimization, I guess this might be acceptable if actually stated that way in the description. I intentionally say "might", because I think there's too heavy an implications here (the caller having done the allocation(s) in a way that matches the function's behavior). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:30:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:30:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412776.656219 (Exim 4.92) (envelope-from ) id 1odCX9-0001Zf-HV; Tue, 27 Sep 2022 15:30:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412776.656219; Tue, 27 Sep 2022 15:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCX9-0001Ye-D3; Tue, 27 Sep 2022 15:30:07 +0000 Received: by outflank-mailman (input) for mailman id 412776; Tue, 27 Sep 2022 15:30:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCX8-0001X1-5v for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:30:06 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4107f47d-3e79-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 17:30:04 +0200 (CEST) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 11:29:54 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5470.namprd03.prod.outlook.com (2603:10b6:a03:287::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 15:29:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.027; Tue, 27 Sep 2022 15:29:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4107f47d-3e79-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664292604; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uMXi0bGHAb5W7L4hm1OHdo6mSZbqBsXexQEA570BK+8=; b=G+TSnULIzmh3ZKD387PW5+lzv7kuhEbn67QesU2lzyXKXxE2q8l/6hd/ xKqaWIY2vc/Mn5y+bXSq5iNF78eAHG+00l4DbwPVJQwq3Hlu+4Dn5vdmo jS+tIiJLeEgfueoKQwEHDCXKDrK183BkP7uRt4OSHIjJ0S2mLbDY3LFHb g=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 81107865 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:QPDup6q5lAr5EA+ijGib/jfN3k9eBmIoZBIvgKrLsJaIsI4StFCzt garIBnQPv/ZMTfxeNB1aoy29U0HvZTcmoU2HgRvpSE0F3tGpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx ewVOm8rRUC/pN2zz4qhadFOl8goI5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJLTeXnpqA36LGV7kIVDEwpXlu2mtnniEemfc9gb HJL8yV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqfiIPUBEE/8jLsIw1yBXVQb5e/LWdi9T0HXT6x WCMpS1n3bEL15dUiOO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComVvlhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:iYVGa60WamEiWUEJW/WH9QqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY fABK5r X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81107865" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRYzW2xIQeoOI35tQ6kOFViTmewqJuzWs0xqyHa7ocL9qRnnE1yajfGiYDEvO2FYHzw8gi8z3wqEHuDB4xsDD9BzvQnuK3xBSBOzTrvhBd/IUYmDGWskovh/a9yKx37BYAx+tvplPqqU1K4Xmx9+ZE/wzlebYoRAoba2qJQZehZGiz3SB0R08SgSVIfGPDZTIUMfi+P9VYSDAKOzspjAEmARDybexN1HheHR1TbhyfyhL2ANreDXjZSyiPMLAD/Oh0NkOKvJm50Y+EX93uIILDkAJupG20tGOo+iSpNpmBA1K5iLnEwztjjuQMm+hrkWYQ7yBl96eA29oufUbAAcxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMXi0bGHAb5W7L4hm1OHdo6mSZbqBsXexQEA570BK+8=; b=bayZzdYg9n6K0PzV/dp50eLXMEk7EdutD2ekldYou/pbQ4glWpTF8nZuK/VndHDNJvqFo9uHX88uy85XmL+6LxNM1Qtl8M9hg5mSOfzJ5rtaHaGdlsql+UlyQbCy33Y5lXdgjhVc6Deh+mrAI0j0UjD6EKpojC1WG9mRYLg2bVRsCYWxeh5vMxcjtLnKcsu1pTpfokk9i/+nlhynMRbVgu6VlCcAh/Nw4j6HVbQMPSNk24K2ISojo8R3KpQTiV5fjAsV0YtSOZaKSrzQZ26t2Z9HYj+uVl/+c12+QmAX0o3mESe2L8bHCSC7uVn6sHg9d7wGYNFIV895Fa2m1NM9BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMXi0bGHAb5W7L4hm1OHdo6mSZbqBsXexQEA570BK+8=; b=hkxgm1LdEXdTK/z7T06+E3D2/LECccr4034+hqwB2rdlN7k2kCTpWXqX6WH8LouMachw+WAXGbeHBQN4Pa81YNm4H4eLyC158RY0Wazbb+hZ8up1Ie4BS3DiYU/f5UdVYQ3GF/WaRDbRagIQA7xKsVPLZ+eq85Kqi5tsToOZG+4= From: Andrew Cooper To: Jan Beulich , Roger Pau Monne CC: "xen-devel@lists.xenproject.org" , Wei Liu , Xen Security Subject: Re: [PATCH v2] x86/PVH: restore VMX APIC assist for Dom0 Thread-Topic: [PATCH v2] x86/PVH: restore VMX APIC assist for Dom0 Thread-Index: AQHY0Y6R2RqP3BeGlUSjwNPrepH9Hq3zWOSAgAABmwCAAA5YAA== Date: Tue, 27 Sep 2022 15:29:48 +0000 Message-ID: <71166f75-d44c-775b-58da-f5a8b7223839@citrix.com> References: <59767cf0-8b1b-4418-db31-6b711518c044@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5470:EE_ x-ms-office365-filtering-correlation-id: 904e55f5-013f-4926-3452-08daa09d1d58 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N9dPjAmPZoJoAGs4ZtixvDAxbDm+j+Brk6tkc4qlBQVjksd4tuvkslokK0m29HZDrdRt36W8Y57heQk4ZtRLJ6b9t9D0g/dD/pj+HAPaInK2HtZ1qtdv0YA6BVPsbUHsHiBuC1Qa24Fjj3qRHsPpPtW0jmYwnfWO7jPRaVho5Iyo3/8705hL86GZILATQTX9fT9SS6xExSRBodzuQFdN+AONh1SMs4SjdwFbLJuiXdTzmXYHHPYK2+Yslwc0m6525LwPEaLOp/TV0f9nqxmX/nvZ/QV6H6GhvuDe7a/1eZ8udubV963vGcTarvh3xO3D9wYmsvlqUu0xtb6wrnZdkcosGlwaiMwLcPnQ/jypD9IRiyQffxYPVgs7jFagxEd+gKpdxBbUaRUs8YRbfJpI5RsLECbkyOcUbKtyoPvZR/EKYsX7JzxtLhqPb1F1cIYkU7Ok4EwcLXwG8JWaVU4sMTX2jBXEaFLmoR2/j5I8UmFbzjenp9pu1Kex8HaZSQ3X0z1c2t1fpwm5z/RBjCMg5PvuIaRR7Xg6bjX7gY7rghdFtseBejRTzv9r3n4Ib0mmMPY0WBWsV/uesSkEbyiOLdOOi30YrNY+JrqrjQ2GvEskFqrNQLNAa8L7anEzg5bhHEb40L+53MlK7+BBSu+FwNDZQI0wrNeIKpLBK+VmmqZVPdKpJndyY/E/N7dDuD4cOEfh0Ol1IVSypr9Ovo/UfhGjXyg0jQ6xmvVlKiHIJe5ajUrm3mRUKvGlPeAoCSs+Pw1Ui1aK1o/memBQu4njSZroDCN5Bq+0kxPeUkTlwaRgDSpngK39H1mdhpSkaiOUgdQUgkkYmJY4njHs1b1Z9w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(366004)(451199015)(83380400001)(71200400001)(186003)(2616005)(31686004)(6506007)(110136005)(2906002)(54906003)(122000001)(6636002)(53546011)(6486002)(38100700002)(36756003)(26005)(478600001)(8936002)(5660300002)(6512007)(82960400001)(38070700005)(66556008)(8676002)(4744005)(91956017)(41300700001)(66446008)(316002)(66476007)(66946007)(86362001)(64756008)(4326008)(31696002)(76116006)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eUd3MTBhRjcvZmMzalppcDhsQUp2WHIrUDNUTjlkanRLQzQrb2FUQUhpZU90?= =?utf-8?B?SmNKRVNLVXNaN0pnaVE0eExlemN3emFVdVp3eUZWSGF0eW9CMzhJY3VwWENy?= =?utf-8?B?ZlJMVDN6M0hrQ2w3R3U2aFJyd2VVWHd0ZDRPWURKaUMxWkJqcktGckd3UE00?= =?utf-8?B?TmJqSjQ4YWxEYjVPU1doaHpsTTZhcGFzdXk5b2JQR1pYNWRMd3JtTzIvMjd1?= =?utf-8?B?N21DazlDUDQwZ3ZyVWoyQnZMTnk1SDl4NWZRVjU0Lzh2RnRpZURSK0tXOUlJ?= =?utf-8?B?Zy9aMFZFN2lYaVZRWktNdS9RTEtNRW02c2F2WGxLYU55TzhJNkFmMkxlY0M0?= =?utf-8?B?eGZmRXdmM2dUTi9va2pzWVFFcWcydUdaYTFYeURwYXdKZm8veXlnRnR2OVly?= =?utf-8?B?S1cyaWxMV0lXNXpXdmNyeGQyc0NodGdlcEhzK1VvK080VkVsdjdybXNsV2tn?= =?utf-8?B?dG9Wakl1a0pHTFpUL1Y0eEFURE0wS2tJREl3eHc1OVVZWFZKc2lJNm5ZZWRl?= =?utf-8?B?MnRIQld1cjNvVDY2elFUc1k0SnJRamwvUC8wZVRxMUZ5cG40VjhEV0VDbTg1?= =?utf-8?B?L29HbVMwY010YzIzWWxNOGFacTBCVUpoNS9aaTYxc2dZaW1VSVlXbzE2N3N0?= =?utf-8?B?K0NpRWZlYy9pWlV2aktXbkowQ0l1ZXVTUTNmOWp3UmR1SHR5ZklZcngvTmpY?= =?utf-8?B?dmE4bFU4ZEpqdnN5S3ltTkFpNERhTVVqUCtXS2ZxNmxySjVoL3pWK3lnakQ0?= =?utf-8?B?bi8xeDlMY2VVMG0yZUg1UGFTVlJwN1l0VFVlbTEzWi9zeTBPT2JiVDR1cTdO?= =?utf-8?B?KzNHckRvd3lRb0tuUnA4TzhONHBFcVlVS0hMQmJpajQ0U0F4SXBSZVFDV3B3?= =?utf-8?B?cXZvNDVtWURkTlB6N2kxbkRlTEx1djk1bzhjOUdnK29uYVF5QWZyKzNDUVJ1?= =?utf-8?B?a1o1WjFOMkl2Yi9rVUJ1U0JLY3d1RjJwOEVZSVFnWEZLcUZYbGppdUkvcUtN?= =?utf-8?B?WHpYSk80cWJ6SUdLc21HR1ZjejhDbjliN0YwVXdGdkFyM3grRm05VC90SXpw?= =?utf-8?B?aWFKeWdGdVFoN09nK2NObnJ4a25JUkdia1lBZUlvMXlxdWpOdHpkbE0zV1BW?= =?utf-8?B?NEZRWnZLSmhMSEJ2YitkYUdTUnJjZmpXMWkwSm5jWXhya1FZeDBCeXFGR3M2?= =?utf-8?B?R3hUZnpsWis5bzQ2cUhqM3VGaXlwTnVFS216REo1TGFRclExcXQ2dzA3Tzcx?= =?utf-8?B?MWVRWFpFVGJkWWVmeTBtbnJYUU1wODViMkFhMmpDdlM1VTRMYVBoYklUbmlv?= =?utf-8?B?RENBY0hnbktoUjVoK0d4SXNsdjUvdW1IVmVNQXlucEZ3YjgwWXMrMEpjaVVi?= =?utf-8?B?NStLVTRrTXMyb1pta3VPcDBqbktmellVclpvQXBsMEM1cndvV1laNURtVVlP?= =?utf-8?B?QkVuTEZDQXZWWnNpejd5cjJHb2hBbllJSTlianJsZmwwUkpwRTRjRVJVdm5F?= =?utf-8?B?bnpvYXg5cE5oaW0wMzlrb3NOZll1Qmxxb1NrZDhXWUpRYkpjUzhiZHVtc2ho?= =?utf-8?B?TmtFdUtmWWJJdG9FZ0FQM0NBS1UvYkRNMTVwZVNaK2p3ZFJJb2lwTlJ6ZFF3?= =?utf-8?B?bmRYbWRCcGhIOUNqRXkzd2V5OUpDVkxUZGdSbmRjeVB6cVdueDNvek9BK2R2?= =?utf-8?B?Y3ZNckRwR1A3a21SYnNLVC9kamVmRm45UmJhTjA5bjA1cGg0Vy9lYm1JYkFG?= =?utf-8?B?Sk1zS2tLUjE0djExRXkvOTlpMFV3OHp2OW9VR3V4TW9PWXR5WkJ2SnB5Z255?= =?utf-8?B?aDUrSW9pd2tCNFpxaG9xdFFtRERQd3d1ODZpdlVJOElFT0RQaTMzS2QxNSs0?= =?utf-8?B?aVdWczVYRGJ2OFNjVGN4cmxseGs0OWhMUXk3MExsVlRpSUZ6WUVSV3JyeWxO?= =?utf-8?B?ckhHcWhzUHpIZFpDZlpTaGMvZG4xREdxTm9jWEJ0MlpCam1jZHFDbnNWbTQx?= =?utf-8?B?ckxIYmNTQVZaVFB4TE9JOUk4VHZHOTRPZTdaL05kYmM2MnJGMmp3VTBid1lW?= =?utf-8?B?WGhDdWN0THE3SEZtK3dCVHlwMXo4MHBaN0NkcEFuQ3NFOW5lYlp0US9aTDYw?= =?utf-8?Q?yCQ+LuUJs4xzBI8uVD0WnKLmc?= Content-Type: text/plain; charset="utf-8" Content-ID: <34DE960CC63A66428DE3C1F71FCD2131@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 904e55f5-013f-4926-3452-08daa09d1d58 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 15:29:48.8351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y3T/KKJCiSJVkO7r4bgxHD5VXaNT2jgJw6B07YhXl+Jr7Hfv7nE5hVEkU62j8uHh1w043e/G6yMzX8V55AbvqiYCHgjhXUepMHJOJNQCG3g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5470 T24gMjcvMDkvMjAyMiAxNTozOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI3LjA5LjIwMjIg MTY6MzIsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+PiBPbiBNb24sIFNlcCAyNiwgMjAyMiBh dCAxMTo1ODozNEFNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBJIGRvbid0IGV4cGVj dCBpdCB3YXMgaW50ZW5kZWQgdG8gZGVmYXVsdCBQVkggRG9tMCB0byAibm8gYXNzaXN0IiBtb2Rl Lg0KPj4+IEludHJvZHVjZSBjb21tYW5kIGxpbmUgKHN1Yi0pb3B0aW9ucyBhbGxvd2luZyB0byBz dXBwcmVzcyBlbmFibGluZyBvZg0KPj4+IHRoZSBhc3Npc3RzLCBwYXJhbGxlbGluZyB0aGUgZ3Vl c3QgY29uZmlnIHNldHRpbmdzIGZvciBEb21VLCBidXQgcmVzdG9yZQ0KPj4+IHRoZSBkZWZhdWx0 aW5nIHRvICJlbmFibGVkIi4NCj4+Pg0KPj4+IEZpeGVzOiAyY2UxMWNlMjQ5YTMgKCJ4ODYvSFZN OiBhbGxvdyBwZXItZG9tYWluIHVzYWdlIG9mIGhhcmR3YXJlIHZpcnR1YWxpemVkIEFQSUMiKQ0K Pj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+IFJl dmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCg0KTkFD Sy4NCg0KWW91J3JlIGJvdGggb24gdGhlIHNlY3VyaXR5IHRlYW0gLSBzdG9wIGNodXJuaW5nIGNv ZGUgeW91IGtub3cgcGVyZmVjdGx5DQp3ZWxsIGlzIGluIGZsdXguDQoNClRoaXMgcGF0Y2ggZ29l cyBub3doZXJlIHVudGlsIHRoZSBpc3N1ZXMgYXJlIHJlc29sdmVkLCBhbmQgdGhlIEFCSSBpcw0K dW5icm9rZW4uwqAgVGhlbiBhbmQgb25seSB0aGVuICptaWdodCogdGhlcmUgbmVlZCB0byBiZSBh biBhZGp1c3RtZW50IGZvcg0KZG9tMC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:40:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412784.656229 (Exim 4.92) (envelope-from ) id 1odCgc-0002Li-DZ; Tue, 27 Sep 2022 15:39:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412784.656229; Tue, 27 Sep 2022 15:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCgc-0002Lb-AS; Tue, 27 Sep 2022 15:39:54 +0000 Received: by outflank-mailman (input) for mailman id 412784; Tue, 27 Sep 2022 15:39:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCgb-0002LS-08 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:39:53 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e6ae154-3e7a-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 17:39:49 +0200 (CEST) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 11:39:46 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5553.namprd03.prod.outlook.com (2603:10b6:208:285::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 15:39:44 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:39:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e6ae154-3e7a-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664293189; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=jbVF1ApaXdQcJ7E8u610wJV/GXmJ9p38FnsF83gSTKM=; b=gA9X7Kma8O7JnEytxXv/eBycYAW166BIf+ShepBOwdyo+CYzc/w5i8T3 AXGRHtADLf3558hfmaf1sSS72kqwzRFwrqK+dFH9p7HQalKz4fU/f1CKb IOeR8Wz/7l1+eD67cNdEIZu2hw94J6RnUUQOV/DBj5WZARK7AVvLjraGL A=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 81108824 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kmkW7qrSp8sIqN7Znal+VWpLhNpeBmK3ZBIvgKrLsJaIsI4StFCzt garIBmEP/2DYzCkKIxwa9zipBkOu57XzdJnHQRqpC9gEC4T9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mr fEHBhQdcA65h8mw0LjrVvJdhNUcBZy+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+OF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efxHqjCNJISNVU8NZhrFupnksQGSExan65n+bk12jgWItAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpc8c6vcU7QTgr0 F6hnN7zAzFr9rqPRhq19KqQrD60ETgYKykFfyBsZQEI+cX5qYc/yBfGVM9+EbWdh8fwXzr3x liiki86gLkCiN8R4I+y91vHnjGEq4DAS0g+4QC/dmCv4x59ZYWlT5e18lWd5vFFRK6GSnGRs X5CnNKRhMgMEJfLkiWOSecMGbiB5vCZPTmaillqd7Ei+iqs/Ti/fIlWyDB4OEptdM0DfFfUj FT7vApQ4NpZOiusZKouOYapUZ11lu7nCMjvUe3SYpxWeJ9teQSb/SZoI0mNw2Tql0tqmqY6U XuGTfuR4b8hIfwP5FKLqy01iNfHGghWKbvveK3G IronPort-HdrOrdr: A9a23:d0dJvaGracwd2EzfpLqFDpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAvhHP9OkPAs1NKZMDUO11HYSL2KgbGD/9SCIVyCygci79 YGT0EWMrSZYzlHZK7BkXOF+r0bsby6Gc6T9ITjJyAHd3AQV0gs1XYPNu7deXcGNTVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xA+A2frfKVy1zx0eWzRAzfML9n XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlXAnEu0KNXsBMSreCtDc6rKWG70srqs DFp1MaM8F6+xrqDxOIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8e1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh57D3xHklX6voIRiKprzOSI JVfYDhDbdtABinhknizyVSKIfGZAVyIv+EKnJyyfB9nQIm30yR9HFouvD3rk1wiK7VdKM0mN gsSp4Y8o2mbvVmGJ6VV91xNfefOyjqfS/mFl60DBDOKJwnUki926Ifpo9FrN2XRA== X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81108824" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbVxDs703tqR9Gy7AEG/EyuMDf5JzjET1vxoMlbGOgz/UG0r+yrLbO864Bd3wsuTpfvWXw1LWvvYCo+N0DBUButwqsPriU+Gi9okDlN+IFgr0Oj3XR5OpPvJMCS3JJ5J+63GAjzQU+skzbuEWeMommk6kosZAkY7GKOevtHJBgD+sO7wYv5UX6yU/e/3IhPuP5e34O2PFNNiYdwm6NZX5egezidLypP6T7oxh3A13011xFsyTiaVQCnZFEYU52J6KVJw5G218PcsAbR6mgjWKUVeM1DvVMFg9cI9sFOCXnpKVjL+B1euCWi6Z99XCmHOLPeUs9vXMdJA7IU0ZL99DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vs2CvyxKFX39SifpRkJoG8a5otnA+5XewiGOPRVHYz8=; b=Ak4P1YcoE+YSi/7tj6yEo+0VXuenWqc2ZOnHrxO7h+XC0YyBPlA8EpDXPeCnqwRDfURS/bvwdorQ7gFlSaJNFjq7FfbKiDqV5LB5DRCCNLQ/siih/7/aIg5ITfSw3tTUPJ22uhd1uWVDxu6tnX9dxnmXqdFmh5UdQI4kcZuQXfylWUSGosilZsARjSTsd0ph9dMyRCj935yFw5e2HCYkMR6hGMSDDsJCN9nv7K0hFh76/TWq4MQy3OYWffqS8cs7h5AcWD8xEmRHXY1ND5SsBm667ZdF79hXdBxKuKD4qApk+bo8Xf+43M3Ol09rzFV7u/EMppl+XW6T3h5KHfcyEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vs2CvyxKFX39SifpRkJoG8a5otnA+5XewiGOPRVHYz8=; b=WWlzJrfT7c63tR98quWSdXjk+c/XG/3L9JQ3ypTg0Ig1EXmgqrdb9Dw8YIr1Ir5DtcQTEKx0nRBlJ+IcL+phKlf7aXnv+fnGau+0pAq4JOA5e2DZmlgMSdYDOjJNM4thRwoUaTommq6T4sVdi3OCta5sVj0zebPF4ve3qrKD3ms= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v2] x86/ept: limit calls to memory_type_changed() Date: Tue, 27 Sep 2022 17:39:37 +0200 Message-Id: <20220927153937.39389-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0455.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::35) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5553:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e5446b9-cf14-4164-360a-08daa09e7ff9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o9568y+5xYG6BPdQoeIqE1qupVaU2rYW6D6Z4UVFCU5b1blSDqR3YMVN6Qu4MXSAWei62F3ZZ6t+de8j+TzUm2zMFiP4Z+1fYHT/Id98NBFrK0HLle0hWY2shoLIyig8EU5Q99OsEJWiyR4PCe3Cu+c43MZx1DsWSqnBkApu47NNj1rd8xVYtdQ+iJKH4rSmfrfvtghWpF4IEC3tVl+I+qv7D13QQlBu7aV0KTao0h8kt3hKCIPM2qjaMTS2z+QPKPqcYUa8cT++/kgqiYtWsdV9+2TVLpw2lYHBKZDjbb1lnIK+asbpGNYU8PfeC/6gQLzTq3RnBWG+TSYomEApPcRm/twOQoSrdHoDbHb8A54VJDaVsJw7zTAhO+LIDQLW1akN/Qp4annl+q7isyvpUj57KUjBlHezNQUeMxk7JOmLsob/GGY27BL4eFnGaKhOJHfvty16x99WPc9kRszLAl+EyZQTUI2xHvNmxHUDz761KJdb8ozZaavv9Bz619R7mZk+0d++D9shZKHrLCApovj27rWv/qULKhTrHcks+btJAghOu2/e/jkw6494Q9HwBkjEeNqU9YwvRhDMt0uwHeJ6XkwDnvEeBiQiVwk9jt0tN3npRzQk+C1KPOjMEG3tvM6UMAz8dAxVeNOM3G24dQTdtJ4K81Irdl0xLsc6XDla64PNuaUv/d/fsNFxrgvveulwb/+IYzgUe16kh+pazw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199015)(5660300002)(6666004)(8936002)(36756003)(26005)(6506007)(83380400001)(6512007)(41300700001)(2616005)(38100700002)(2906002)(82960400001)(186003)(1076003)(478600001)(316002)(54906003)(6916009)(6486002)(86362001)(8676002)(66946007)(66476007)(66556008)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUlqM0VXbjRBb1l5eUsraUZqTm1sc3Z3dWFndEJsdjBIU0lxVHdhUlBkMVY1?= =?utf-8?B?WFVmcU9HQU8vN3R0QUpCeG9UbDRGRUE5L05qZGQxazFRcGR1U2VOT2xUazhO?= =?utf-8?B?dW9Ra1U1S3lkZktIK29obmpSeGtnWERjZjYzdWNhWmtaWWh3ZVk3bWc5ODBr?= =?utf-8?B?S0dwYVBHcXVFOEplelVVMjE5U2ZHK0VpV2k0TndLNkk2VlNGUzcrR0dKL1NY?= =?utf-8?B?aTdnU2FZU1Z4RVRrMDNGZzlYVWFmV1dsU0JJOW51c0JwbldoNGNENzFuSm54?= =?utf-8?B?QWkrajBGbEpCMHEyZ0hxdkFYZlRxQ1FBc3JoNE5rTCt3OFA3bFVLZ3pZckZq?= =?utf-8?B?UkM3N20wR3dvNHFLU1BMTng5bGNJWTVpbm9mWkI2M0Q2N0JVZjZBbm4vTTZp?= =?utf-8?B?QkFEZVNYV1lObkEvVUl4Rll2SzAyay9yL1B6d1FkUVZEUmRpdU1LMi9oemlG?= =?utf-8?B?Yk9PZ3VwZWVxa1BjR1BWQmptVWNXVkJnc1FxLysycjUraHBzNVdZbng2b3NS?= =?utf-8?B?YWV4NWowd25mY0lGQnRGcjM3V2ZEa0REc2Q5V0liTk5peXB4VzNRY3luRy9Q?= =?utf-8?B?bGMrR0Q5aWFkQ2pIemQ2dTZ3Tk40M3djSVFjbldBSWRDLzFVdkFUK2lnNG8w?= =?utf-8?B?d0h4ajJ5dTdxSXROVkhDL2xHSXJ0U21GNmFzQ3daQzUwQ3lDUngrVUZ3MUxG?= =?utf-8?B?ZHJEcUFzdUpmSDg4RnRJSGdrYXc0TE1sNkdNaVVUSGRxbHI0ZEV6UjYvZmxJ?= =?utf-8?B?c3FXYVdsR1hUbGhJRzNtSDliSTV5UUIzdkw3Z3hnMktzcGM1TGJzNVJqczli?= =?utf-8?B?SzZOdExWbElhUk5PRmttSnNvZGh4TG9JMklpZ1RYQmcvbmNjSEJMbHIvTEkw?= =?utf-8?B?TUtnajF1K21hai9pZ0l5ZTNLQ01iRDArTCtGdDkwM1d2UjRXRlo3dUZMTjAy?= =?utf-8?B?dVhkZTVLTHJWaEJsYUlobkEzMFV6SnhBbGFnSmlDeDJGZE80bVFPaUNOeVBL?= =?utf-8?B?MHJJY0hrWklWY1YvajB0WGRDTklDMXR3TFgvbVNEWnBrSWNKb2o5QTIvdHA0?= =?utf-8?B?cEU5S2VuN1dBdGJ4ZGFTRlZEa01mQk9xTXp5aHFJUzlZcnJoYlYyd1hzdC90?= =?utf-8?B?WkZXaWEwVWZOTTk2ZWFHKzNxTlZ0dzUxVHpJbzl6YmlPeXRiMzdVNkkySFJE?= =?utf-8?B?N3BhL2NlYno4anQ3dGY0ak5XT3V0K3loOSs3YWU4VVloNUhaZUpjSmVmbnFx?= =?utf-8?B?dXhjNkN4TW4rc3htMmIzQzJleDdPSXB4eEVHL3k3dEI3d1RRbCtGNUlRVnBQ?= =?utf-8?B?eE1tT2hObDJKeVNaMFkzMldnNkw1REJyWGNxcWU3L1pNSE14SEMybVJHUDBn?= =?utf-8?B?cnRFN0FLcFk3SERHWUc3d1YweTRmNlE5SzlLQm0xWXBGQ25SbWh5UE1Hd2FY?= =?utf-8?B?UXpzaEJZQW43aWZpdC9LL0VzOXc5QnpLNEZSOC9wZHhHdDZNQTJ2QkFoR0RN?= =?utf-8?B?Y1RSVHdnZi9aRmF0U0tWK2RrUm02d0p4Z0laRzlCK3pUajdMb2NEcURmMk5j?= =?utf-8?B?TDNyRGRZWjBNSnVRRXk0SHo0bFprNGtjc2daNnRiV2dYdkp5ZTlCc2NMVnVl?= =?utf-8?B?Z3dtVHE4YVF0Y2MzVFBuOXFuNjg5eW9OTVFsY2F3Rlp3ZVFHQS9FcjY3Ykpw?= =?utf-8?B?V3dYSEFvc3BWZGJpaURyTnJpY3F5eGMzd1ExTjU1bUt4WmdiOGFxWm8xN1Fl?= =?utf-8?B?a2VqalpXeW55c00vSVlMV3JqbXZtRFZENTZGRHFPM2lNMTlLVXNEcTNNQ1pI?= =?utf-8?B?NnFRbVFaSVQyREplN1hkNGdtNTRJVjdJTW4reE5zaFBoNXZFUnQyM052bUVY?= =?utf-8?B?WmxiZFJDMlZzS3NXT1A2UlZoWHkxaDg1cG5TNGNkaDV4YWRRV3hERUNjY2pm?= =?utf-8?B?QURLaTFzcDJNcXIrWmdBQXM4RnpYUUFlRVhNOFZNTUw4QlVUOFlMM2pjSkJN?= =?utf-8?B?K0NJeXUvTzdheTI1Q1hjREtLQ2lrU1luS3puRjUvT0ZpWFRqeGxmcVk4NDlz?= =?utf-8?B?U0FETWVSM0RnZStqVi9VdFF5WjdSMEprdkdJeVpBb2FQakRFYlBvaXhoWXhI?= =?utf-8?B?U1FKZ1g4dUlkWkh3U1FBWHpuV0pnY21FdGNvWEhnQVVVYTBhR2VqRDV6S2lN?= =?utf-8?B?cXc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e5446b9-cf14-4164-360a-08daa09e7ff9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:39:44.1961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LlWbDP9KlnL8CJ4RZozv4Unh1TmrykBLn/B0ZaA2eeV5mODDQrpObr72lG1a4zTtR7lpN6pvCEWScU/Ys1kCNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5553 memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Some Arm callers (implementations of the iomem_deny_access function pointer field in gic_hw_operations struct) pass a const domain pointer to iomem_deny_access(), which is questionable. It works because the rangeset is allocated separately from the domain struct, but conceptually seems wrong to me, as passing a const pointer would imply no changes to the domain data, and denying iomem accesses does change the domain data. Fix this by removing the const attribute from the affected functions and call chain. Signed-off-by: Roger Pau Monné --- Changes since v1: - Place the calls to memory_type_changed() inside the io{ports,mem}_{permit,deny}_access() helpers. --- xen/arch/arm/gic-v2.c | 2 +- xen/arch/arm/gic-v3.c | 2 +- xen/arch/arm/gic.c | 2 +- xen/arch/arm/include/asm/gic.h | 4 ++-- xen/arch/x86/domctl.c | 4 ---- xen/arch/x86/include/asm/iocap.h | 33 +++++++++++++++++++++++---- xen/arch/x86/mm/p2m-ept.c | 4 ++++ xen/common/domctl.c | 4 ---- xen/include/xen/iocap.h | 38 ++++++++++++++++++++++++++++---- 9 files changed, 72 insertions(+), 21 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index bd773bcc67..ae5bd8e95f 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1083,7 +1083,7 @@ static void __init gicv2_dt_init(void) gicv2_extension_dt_init(node); } -static int gicv2_iomem_deny_access(const struct domain *d) +static int gicv2_iomem_deny_access(struct domain *d) { int rc; unsigned long mfn, nr; diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 64b36cec25..018fa0dfa0 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1424,7 +1424,7 @@ static void __init gicv3_dt_init(void) &vbase, &vsize); } -static int gicv3_iomem_deny_access(const struct domain *d) +static int gicv3_iomem_deny_access(struct domain *d) { int rc, i; unsigned long mfn, nr; diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 3b0331b538..9b82325442 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -462,7 +462,7 @@ unsigned long gic_get_hwdom_madt_size(const struct domain *d) } #endif -int gic_iomem_deny_access(const struct domain *d) +int gic_iomem_deny_access(struct domain *d) { return gic_hw_ops->iomem_deny_access(d); } diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h index 3692fae393..76e3fa5dc4 100644 --- a/xen/arch/arm/include/asm/gic.h +++ b/xen/arch/arm/include/asm/gic.h @@ -392,7 +392,7 @@ struct gic_hw_operations { /* Map extra GIC MMIO, irqs and other hw stuffs to the hardware domain. */ int (*map_hwdom_extra_mappings)(struct domain *d); /* Deny access to GIC regions */ - int (*iomem_deny_access)(const struct domain *d); + int (*iomem_deny_access)(struct domain *d); /* Handle LPIs, which require special handling */ void (*do_LPI)(unsigned int lpi); }; @@ -449,7 +449,7 @@ unsigned long gic_get_hwdom_madt_size(const struct domain *d); #endif int gic_map_hwdom_extra_mappings(struct domain *d); -int gic_iomem_deny_access(const struct domain *d); +int gic_iomem_deny_access(struct domain *d); #endif /* __ASSEMBLY__ */ #endif diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 020df615bd..e9bfbc57a7 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -232,8 +232,6 @@ long arch_do_domctl( ret = ioports_permit_access(d, fp, fp + np - 1); else ret = ioports_deny_access(d, fp, fp + np - 1); - if ( !ret ) - memory_type_changed(d); break; } @@ -666,8 +664,6 @@ long arch_do_domctl( "ioport_map: error %ld denying dom%d access to [%x,%x]\n", ret, d->domain_id, fmp, fmp + np - 1); } - if ( !ret ) - memory_type_changed(d); break; } diff --git a/xen/arch/x86/include/asm/iocap.h b/xen/arch/x86/include/asm/iocap.h index eee47228d4..ce83c3d8a4 100644 --- a/xen/arch/x86/include/asm/iocap.h +++ b/xen/arch/x86/include/asm/iocap.h @@ -7,10 +7,11 @@ #ifndef __X86_IOCAP_H__ #define __X86_IOCAP_H__ -#define ioports_permit_access(d, s, e) \ - rangeset_add_range((d)->arch.ioport_caps, s, e) -#define ioports_deny_access(d, s, e) \ - rangeset_remove_range((d)->arch.ioport_caps, s, e) +#include +#include + +#include + #define ioports_access_permitted(d, s, e) \ rangeset_contains_range((d)->arch.ioport_caps, s, e) @@ -18,4 +19,28 @@ (!rangeset_is_empty((d)->iomem_caps) || \ !rangeset_is_empty((d)->arch.ioport_caps)) +static inline int ioports_permit_access(struct domain *d, unsigned long s, + unsigned long e) +{ + bool flush = cache_flush_permitted(d); + int ret = rangeset_add_range(d->arch.ioport_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !flush ) + /* See comment in iomem_permit_access(). */ + memory_type_changed(d); + + return ret; +} +static inline int ioports_deny_access(struct domain *d, unsigned long s, + unsigned long e) +{ + int ret = rangeset_remove_range(d->arch.ioport_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) + /* See comment in iomem_deny_access(). */ + memory_type_changed(d); + + return ret; +} + #endif /* __X86_IOCAP_H__ */ diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b4919bad51..d61d66c20e 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -518,6 +518,10 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, return MTRR_TYPE_UNCACHABLE; } + /* + * Conditional must be kept in sync with the code in + * {iomem,ioports}_{permit,deny}_access(). + */ if ( type != p2m_mmio_direct && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) { diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 452266710a..69fb9abd34 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -716,8 +716,6 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) ret = iomem_permit_access(d, mfn, mfn + nr_mfns - 1); else ret = iomem_deny_access(d, mfn, mfn + nr_mfns - 1); - if ( !ret ) - memory_type_changed(d); break; } @@ -778,8 +776,6 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) "memory_map: error %ld removing dom%d access to [%lx,%lx]\n", ret, d->domain_id, mfn, mfn_end); } - /* Do this unconditionally to cover errors on above failure paths. */ - memory_type_changed(d); break; } diff --git a/xen/include/xen/iocap.h b/xen/include/xen/iocap.h index 1ca3858fc0..0ca4c9745f 100644 --- a/xen/include/xen/iocap.h +++ b/xen/include/xen/iocap.h @@ -7,13 +7,43 @@ #ifndef __XEN_IOCAP_H__ #define __XEN_IOCAP_H__ +#include #include #include +#include + +static inline int iomem_permit_access(struct domain *d, unsigned long s, + unsigned long e) +{ + bool flush = cache_flush_permitted(d); + int ret = rangeset_add_range(d->iomem_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !flush ) + /* + * Only flush if the range(s) are empty before this addition and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for effective cache attribute calculation purposes. + */ + memory_type_changed(d); + + return ret; +} +static inline int iomem_deny_access(struct domain *d, unsigned long s, + unsigned long e) +{ + int ret = rangeset_remove_range(d->iomem_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) + /* + * Only flush if the range(s) are empty after this removal and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for effective cache attribute calculation purposes. + */ + memory_type_changed(d); + + return ret; +} -#define iomem_permit_access(d, s, e) \ - rangeset_add_range((d)->iomem_caps, s, e) -#define iomem_deny_access(d, s, e) \ - rangeset_remove_range((d)->iomem_caps, s, e) #define iomem_access_permitted(d, s, e) \ rangeset_contains_range((d)->iomem_caps, s, e) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:47:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412793.656240 (Exim 4.92) (envelope-from ) id 1odCo1-0003sZ-Ay; Tue, 27 Sep 2022 15:47:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412793.656240; Tue, 27 Sep 2022 15:47:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCo1-0003sS-87; Tue, 27 Sep 2022 15:47:33 +0000 Received: by outflank-mailman (input) for mailman id 412793; Tue, 27 Sep 2022 15:47:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCnz-0003sM-QP for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:47:31 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b008db8e-3e7b-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 17:47:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b008db8e-3e7b-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664293649; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WTUk5bTnx2ZKsSOf3ETiJqP/Wq57G2VTdYbXU0GpZJQ=; b=K8NxtzZQuO6VXUh6PoF1G8Kl9mTSVZEaKroyDtaMAzAj+t1AODZMBbD9 4x25gI0/3huYCb0VyqEUofuiiYG2JiQosA0L7Ps7hk8XHppqL0fjTPqAS mU2kM1VvP2yF3sa+A867C8ZaGh8nk5wf//XJAdECr85QkvtuQCuyUcU9u Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81880227 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:lTg/HKh9uCJyimvRBdKKSjTNX161WBAKZh0ujC45NGQN5FlHY01je htvXGjUbKmPYDDzeNt0bN/gpk8EvZXRy4MxHAZoqy49Fykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UgHUMja4mtC5ARvP68T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWdO0 dopATcgVw6S2uSO6uinWPNdh8t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZwFzh7C/ D2uE2LROx4CbNrA9gW84lHwrNbqrA74X687G+jtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QW5y4voK4a5EGtCN7nUHWQgHOCpA9aZNNWHMUz8gTLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313pW+oC62OCMVBXQffiJCRgwAi/H4u506hB/LStdlEYa2g8fzFDW2x CqFxBXSnJ1K05RNjf/iuwma3XT8/fAlUzLZ+C3RXkaD3yp+Sbe7dtGu0XKB8eRaHYeWGwzpU Gc/p+CS6+UHDJeonSOLQfkQELzB28tpIAEwknY0QcB/qm3FF2qLONkJvWogfBsB3tMsI2eBX aPFhe9GCHa/1lOOZLQ/XY++At9CIUPIRYW8DaC8gjajj/FMmO67EMNGPxb4M4PFyhJEfUQD1 XCzLq6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+lZagLRM7FpvfvVyOkwz zq4H5Ti9vmieLemPnm/HXA7dDjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/I7Nj7dNxv0N/tokC 1nnBSe0PnKj2iCcQehLA1g/AI7SsWFX9yxmY3V2bQr1hRDOo++Htc8iSnf+RpF/nMQL8BK+Z 6JtlxmoahiXdgn6xg== IronPort-HdrOrdr: A9a23:yIAY2KHrrMK32P7tpLqE5seALOsnbusQ8zAXP0AYc31om6uj5q aTdZUgpHjJYVkqKRIdcLy7V5VoIkmskaKdg7NhX4tKNTOO0ADDQe1fBOPZskTd8kbFltK1u5 0PT0EHMqyUMWRH X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81880227" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall , Henry Wang Subject: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS Date: Tue, 27 Sep 2022 16:47:08 +0100 Message-ID: <20220927154708.15787-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This breaks all Clang builds, as demostrated by Gitlab CI. Contrary to the description in ecd6b9759919, -no-pie is not even an option passed to the linker. GCC's actual behaviour is to inhibit the passing of -pie to the linker, as well as selecting different cr0 artefacts to be linked. EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to gain such a usecase. Signed-off-by: Andrew Cooper Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") --- CC: George Dunlap CC: Roger Pau Monné CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Henry Wang Henry: This bugfix is a blocker for 4.17. --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 000e57e57b44..69af1e60d4cc 100644 --- a/Config.mk +++ b/Config.mk @@ -188,7 +188,7 @@ endif APPEND_LDFLAGS += $(foreach i, $(APPEND_LIB), -L$(i)) APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) -EMBEDDED_EXTRA_CFLAGS := -fno-pie -no-pie -fno-stack-protector -fno-stack-protector-all +EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:49:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:49:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412798.656252 (Exim 4.92) (envelope-from ) id 1odCpS-0004Ra-Mp; Tue, 27 Sep 2022 15:49:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412798.656252; Tue, 27 Sep 2022 15:49:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCpS-0004RT-Jn; Tue, 27 Sep 2022 15:49:02 +0000 Received: by outflank-mailman (input) for mailman id 412798; Tue, 27 Sep 2022 15:49:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCpR-0004RK-UK for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:49:01 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20053.outbound.protection.outlook.com [40.107.2.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7718d1a-3e7b-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 17:49:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6828.eurprd04.prod.outlook.com (2603:10a6:10:113::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 15:48:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:48:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7718d1a-3e7b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0xJC0mv7k2I5LilK/pQQDbFBLzkJK+EkJOIIzXNnvqrT8y/d6bqbs7iLuorsGgozY4u0GV4WZub+hYymrsjhVm+B0ACLK3pmc4NQeyozV88TCn5rGtHfYgdOGGkW0I/wQg6dap1/raBn8cdxwFjLtqvPl/w+tByaUIkGOAEt1hcx+dMLaHkjmYZxuM56ZUYkFdLnN14RSWXLziKnggHZGMm4rVTmOHTPdxV/Oql/i/h/wI/RTEr5dL8hUBYSPnlns4C82/QptYbyolmQFFu7uSBwGJG26mCdfJEO7KsU0ff8K5idhfJfH4ZK+JeZAqMCWLXQZPFpeZzpusSIbfz5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0AOXUC96VkhsXa8dWhvMF0s+t1yabiRdQ4QW+0xtGSQ=; b=G9VVSI/9N2oucWBEa3iwpRQbBUVvve48cW/qP5h+5VSuTGwl469j+bDOi3MWD94Co38ME6xls3hwrPfOWcQzzZvxN6A1AFirh7jqTT2YDDO3PvsWycIMgnr/C+x1l93YR32fsY/mCTjybmyUC+g6rTWfKGOZYu3L7JCK/aOgkv8B3QLbM/Tu09rwB5OU7SNgz8Z1m9IHXABd+FTon/fR8HWc2JwYBIcTbDeDR0q8gmTYTuU1BIoJ3q549VRqtoh62z/0vdWC1jndrM/ROyTOee5mfCx0+qRxbjDpJXGyyyCixTpYho50cLrLVtYNVJdCCUH7GfmweEzdSJ0KNRg7eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0AOXUC96VkhsXa8dWhvMF0s+t1yabiRdQ4QW+0xtGSQ=; b=a70KddQ0s/xKeh2v2s13lIG99S678AfZopXhRBF5UmigfYcGrmoiSEaPgkCQSBfWcEGrd/WkJE4nyVeXRzt6tF4M+TEsEJDDR9Pt8nxq4r2Y/JgM40MuT/wZ5huNdoVgCSRHwjxzhIgxFWVn7Iynx+gBes6mSa2otXbf3zLk6m9CmpQRw0o5MLlUOUN5n9ipp1UmnJ/KQhlmDi1FAqITanFXix1YIdHnCi7W+zXLI6WMXLGGk4F29ATmvIaTxuHBt9ce9Psmz39TbvIm/rqHGxPlY7tL/KQw22aVzYntx28d53z6c3PoIQqkK2GCo+bDkxVJe8FVDXbmHICyCtwKUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com> Date: Tue, 27 Sep 2022 17:48:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220920091218.1208658-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6828:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b02e11b-fe0b-4fcf-deca-08daa09fcadf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NmV71Op7B50r3ncKhEdE/NEsYSP0R0EUSKKsGnG5cK8wlVTV74mS7C9i603xUzhPp356zDibxe1blhq4X2t9Q5YFUZmDpTfAxfdRcOfC+/ZNaEMfUyrCgDStuC5z2MV+QO/gYZ17qtcMuucqptHeSutNRKvOoEuOiQGuiIHfpkyowp02ubcSJHaI6RkS4NPLSMYKXbfs6+FsyZdHnsondsHjKOLkAxCUjFBDL+C4aiEjamcYd0MtOADBjELwqLe0FYHcR1MXafqeLPbsupP9P57aLhAUBXaRY8UNdfuHgo5Z/rKT8i5pL0Twk2NZ16/Rz8bi/DK0Roxt3S+i8T8tFqV1cLtemcW4Uue3B/aXs6P5BbiSUXMMlUxbfIlb3wRW6n984uARGxSB8H+ea8invzpyl6Hr/4QbOPjo9jEOKK3yPyKHWlJgFczWSDFWP1HOHHezJMV1uzm/gAxfQCp/Rc2muU1rmxVEFqRqpptLdWzgITsE8mo+cVpLyA6gisJ+O52GAwyGU7Oo34eUq4kow11fRr1upT2p7dXA32djmKTszkpn5aYa8sC/vEe7rWk6GQG0y+t6QmoEDRum81rJsYYGdXCBgKywCRW8pN7Qcf+7h+PfAU7PGoybzzampAjIqutZs5/nqVxmXFnLszyT/K3K+8vGuPahrEHKFoONS0GhQy8qz2cqN7zg5ZrGVy5VGSQzvywDQK0On2an/z35lJiWa0GKzvQr7FVTA9EooqLLMLKe6yjJ+aE0dnOiIAEdwTv//UDC0DnjgRXcSXOke8kaY11P4/4Fhsnu/HbTbtc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199015)(41300700001)(478600001)(6486002)(8676002)(2906002)(5660300002)(31696002)(86362001)(36756003)(316002)(4326008)(54906003)(6916009)(8936002)(66476007)(66556008)(66946007)(186003)(31686004)(6512007)(26005)(38100700002)(6506007)(53546011)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eldLUU9HOStmREVQWjJ1aGh0cGdlclZKdEozeEFvMDBDNWxHQ2E0OGdyVnR6?= =?utf-8?B?bGJnTFVMekpyMGdMZjZkZlpIaW9pa2xlV0tNWUYxd3JWK0VSUGQ0VWlNMEk2?= =?utf-8?B?MUI1QUkwUmNRaVh4N2swWkFGS0hPckEyU3NzQXhJQ0RNMmNpVkJWdGpVMGxK?= =?utf-8?B?QmxrMkw3NGc5ZitZM1JJT1I2SHd1elRxV3g3Y2VOT0NySzRYV1NQQjdoVGQv?= =?utf-8?B?T2x1S01ReHA2S1BhN09pRDhrcVBNYTB1NGsxN0p5ZFAyQythc20xMU4xWlFx?= =?utf-8?B?aHRMdzZ1SUg3Qjl4ZjA0dmxoMkhXeDZXcHdpczFSSkZVWExBWG1vUy9TN2Jm?= =?utf-8?B?V0pXY2tqR0diVWVVdkxHQ2ZpdmdkU1dqdC82UU5hTE9zWkx0RzFnS2h6UkZH?= =?utf-8?B?SERRR09uTTNsWFVZNWJud2dDRm8xYWRBOUdmbEl6L2FBdXRHWGxRWXhndEds?= =?utf-8?B?aEhYNTlaZlRTcmQ5RmVtYTRZN0ZkRHdvUnJxYzRKb1RKNkxuK1gvSStyQXdE?= =?utf-8?B?cXpPc3dweDRIRHQ5WVJpYXdRVzUrWTlXK09UL0NtZE9pendKTDRyemlDWnBv?= =?utf-8?B?SlBWbjZlNWsxT2EzVEE5b1JGc1dCUXluenFMZVFXdlpQcTRTVmREQkp5Z1pU?= =?utf-8?B?eTlDbURoN0hZV2dWVHVRcVFIZlQzOTJ4a2xoZndOMFdHZW9KVjA5UTlNeHVQ?= =?utf-8?B?MlhWMURhb2p3Qi9GVlROYVk3Q013RW42RHFDeExVelEvNE04SGpFQlFCYkVF?= =?utf-8?B?ckdQNWF6VGtVdHZEN1pIdW9ySGJadzVRRVJCL29IY2N2NDN6NEVhdUNRMVZ6?= =?utf-8?B?aks3UE1FbUVZTWdDdDNmTldjd3IxK0pZUXZ2ZmZqUU1GYmNWbm0weXhRSlJs?= =?utf-8?B?MmpReTJPay80eHFSSUVZNU5hZitnL2d6OHRKOFB5ak5nWlV5VmxQUGNSaTN6?= =?utf-8?B?Z0ZIdTNwcnRTWGdVK25qSXRZOGNrdk1JSVBkUDhRbUlSU3FlMUkrUFE3dE5B?= =?utf-8?B?SUNyRUt0WDkxaTZPU2RIeDB3UE1EWEpuMDhaYzkzZTZiMjNwNE8xYXVDbUFB?= =?utf-8?B?UG51MHllT0N6a3NEVHJnbENYdUNXUUVrK2JtZ3VHMUI2WkxXQVdONVNxdmZE?= =?utf-8?B?RjB6VUc3eklnYWFxcWUzdmYrRW1NNktCMXNRS2Y4WGptWEhqOFhWMTZTTkl2?= =?utf-8?B?SThBeUc0V1ZJYWt4RW95WVFJMEhpK0x1RFk2R0ppU0dEKzFGcTl0NngySndl?= =?utf-8?B?RzRZWWdCaTZSSU1hek1yZW5PeHhzQWVqd01Ga3hEd1ZLNGFtWTErcDRhR3Zx?= =?utf-8?B?NnhHT0tHTzZ1SHpNV3pKUzNLU2F4akJXT0ZodHRSSUI0NXQ5RUs5c2FCRFdU?= =?utf-8?B?bWtoMGhKTEdtRzAvaDZMU1lJbUl1L1BYS2d1WmJKQ0g0MmZXSUVIYVc3blJu?= =?utf-8?B?Y04yVE5rU0oxVTRQU3FwSnZKZVV3dXIrUTNKWUFPdUhsajFFK0FUdE9TQlhi?= =?utf-8?B?QzFRR0lPWG5iZmwxOXJDM2dpazdJSDZCZkxiWHBkVHpZM01VQUJURmNLRHha?= =?utf-8?B?cFNiaHVBWWJMUmlYRUphN2VsM1hWd3Rqc0tUS0VtQzFjazBJdFBReVhqbE1H?= =?utf-8?B?S2JkSFI3cm9WS25HTlUrcVg3eTFIdXNhb0lHNVp0dTEyeE9EY1NUWDl0bW5q?= =?utf-8?B?Rnp4NG1qNVkzOUMzYUNmcUxaSEt3eTZVcWVmdlZDZGd5WWFUS1VrTHQ3bFlK?= =?utf-8?B?WWttc0YyTzd2Uk5LZ1VmaXU1MGJhc2R5d3dJcEJYc0ZuMkIrSUNjUUJnU1h6?= =?utf-8?B?UUk4Q05IaFZhbFQxaEp6MU1pZExBaEFjeXBXQVlZRmM5TFU3d3IwempUVTNN?= =?utf-8?B?aWd6VjJHdnp5YzA2am1BUnk2UlRSNnFpTEVWNkhuVjdsM1NCNEh5dkdTa09x?= =?utf-8?B?MWg0OGN1MFhnZUprNEE3d2MxOVQvbDVSWWdVSlRkQ3J4QVdQeXdNMXVkUDUy?= =?utf-8?B?bXBpRGlFUWYwTmF0Y2gwTXN5TDc1VFA1ZTIzTU00bEhOTkMyc3FzUmFnTUZy?= =?utf-8?B?VHlKdlI5QTdTRG9nNWtzR0hPZFRmd2FQN0hHaEZvRjlpcVVKTW5Tb1VMRW9C?= =?utf-8?Q?yRlOVWviIJ6qB3iy0w5Yx1mIg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b02e11b-fe0b-4fcf-deca-08daa09fcadf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:48:59.1041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o0F1nYZbVi13FpTWFRidQdS5RwJKcBUyRgn3fQcsgz2p0mGINm2oroiSEV5a9OT8mWTH3XdcrvJdZaEqacQkzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6828 On 20.09.2022 11:12, Wei Chen wrote: > +static bool __init nodes_cover_memory(void) > +{ > + unsigned int i; > + > + for ( i = 0; ; i++ ) > + { > + int err; > + bool found; > + unsigned int j; > + paddr_t start, end; > + > + /* Try to loop memory map from index 0 to end to get RAM ranges. */ > + err = arch_get_ram_range(i, &start, &end); > + > + /* Reached the end of the memory map? */ > + if ( err == -ENOENT ) > + break; > + > + /* Skip non-RAM entries. */ > + if ( err ) > + continue; > + > + do { > + found = false; > + for_each_node_mask ( j, memory_nodes_parsed ) > + if ( start < nodes[j].end > + && end > nodes[j].start ) Nit: Style (placement of && and indentation). Does this actually need splitting across two lines? > --- a/xen/drivers/acpi/Kconfig > +++ b/xen/drivers/acpi/Kconfig > @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP > > config ACPI_NUMA > bool > + select HAS_NUMA_NODE_FWID > select NUMA While I might guess that you've chosen the insertion point to have things sorted alphabetically, I think here it would be more natural to select the wider option first and then also select the more narrow one. One further question though: How is this going to work for Arm64 once it wants to support both the form of NUMA you're working to enable _and_ ACPI-based NUMA? There better wouldn't be a requirement to pick one of the two at build time - it would be nice for support of both forms to be able to co-exist in a single binary. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:52:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:52:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412806.656263 (Exim 4.92) (envelope-from ) id 1odCt9-0005rT-6F; Tue, 27 Sep 2022 15:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412806.656263; Tue, 27 Sep 2022 15:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCt9-0005rM-3b; Tue, 27 Sep 2022 15:52:51 +0000 Received: by outflank-mailman (input) for mailman id 412806; Tue, 27 Sep 2022 15:52:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCt7-0005qr-OS for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:52:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f751e2f-3e7c-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 17:52:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6828.eurprd04.prod.outlook.com (2603:10a6:10:113::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 15:52:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:52:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f751e2f-3e7c-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dBOgL9NA2skWMIkbHkaK3WC9jA0jsKEorr0Axzh5leTVzlvnhQEMQ7CBrC30LvDEVZ7YA34u8AD80UTVW0dRMUkhFCOF0NQY9/PwCgpWToY/kbbikgY7SUnUkAASS0YQg6/88LtP1UN1/+zOonTZ72pNywEDFWjbYw8LrVEfa7rqiwMFJxhJVF40If9iwWtRvL65W48Al10wbbV7oQizxg3AIotnyz9OXdUaFQR6JQ1vhl7tCwffr3w3hRBrXtrZXQP78HQvzE2rxTtX+8u8xOEiNA25c1Q/lwwdff9mL3y3eDkOoQjxLd5mhhGCNE6AV/N2+vhIJK6MhN0ESy1dcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=peLxow+fyZZz86PyCAEs4UsoiHFSpvnKnCocSF6eHIE=; b=WGPSzq9UXWFxy2DzzQPCo7JXGmQzsLm0xysCs1BagzVT510tjZViyNxalj2Nq86Xqor1B2vYwq6gIi8yRxrpU4wMMWP026md+C5QHwOfNkU/vQAjJXAAiGPyHJfN+JuOJV0FqL+L5kYyLuff9zaTpJD6Njt7oMGSftoXZ2rSBI1zccjuYbm+/AluflXQ/l+WIjFFgCCEYbfu1pnwBSD3wOt5ufImSMJNwQt5782KWazOK+yPDQF973d/IhPvG9PlTyiBMJ85szH0aOyaj7I7+pwxYcXxo38DauoM1Fcauh8rb1hz9xULGWMmVrYlTuF6iuhqmdjl6fw6G+xq6Wbt1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=peLxow+fyZZz86PyCAEs4UsoiHFSpvnKnCocSF6eHIE=; b=hxpBIMBYq0Tw/fI78L7r8KUzX6/BQ89QUnXQq2SGX0K6k6SxWgxCP78LsAI75aRi6cWTcVZXsKExrLDrST51JSSO4t7gOtTzkApMkXqaMzayR1iOij8PCrn9cTM9jQu2r3HDPtyLottGN8MZJcR1jaJ4bIubuvbH8+MdqzwqUcsBg9FKKsENdvl7hidWNqzzRZkTZXR1GipbD+uTpGdG5sNDza169jaoVBYBVE0iICFJHktkuH+sN0lL7a1p80V71eYhJGqXV6yZI9D3pv9UrHlL60YN1GZy1LCIBQ0pZtVVATD9+hurNwOOdVpqMMRylFODnrRG8FAb+7DbXT83TA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2d8cc77d-073b-1de4-1ccf-43427529e470@suse.com> Date: Tue, 27 Sep 2022 17:52:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Wei Liu , Henry Wang , Julien Grall , Xen-devel References: <20220927154708.15787-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220927154708.15787-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6828:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ccc30eb-3de3-4baa-f8aa-08daa0a05242 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QB6D3ZxLjZz7EjohGbn6nhRmAQPKmKBTpTCPEDLpH8Wgq+gGYdIM0RpshedJ8j2N7Xjp0VJn2rXTBy5jyjObp9FXmEVZ0Q6qBoz5Tu3QlQSMVPYjvk9R4o9aZGpqhqJrGioQ5pZkCna74GJkuTKxNOil0jgqQAHIs1C+5tAq2hETl9Mxdzwd5Fcu8P+uRI325kdxe1xhVDDvlyHry3TqlJyJqJUSAvk4IwHyHBzGQrbie6+eLb7fhn1hOe5Rez58Xj7bxupmRT7ejToMmb8bOxveLygPz0JX6yCFvuE0Xejp3gondTpvd/faOhzOmdHgkYf3SFFz5XeFriHvB7H2/tsjJ5m2NNmlHFdf31vtCV2Br94vPCVAKyDtnjyeZNh3749jkapzABt4ONVKvZRJcV9v3rIsCB861WrwnvIfWhKRgcuwEgwhIwR5gQocSTeCn9pFw22Vwk/9AUeQ31YAKahl+2riQ/KpqjYh0MmAbnpMUECukwl8v/Zvf4ChT02muUtPo/1bN8AIj7kihz/IBz7lpgweKyztcbclGeEVpxQEThOIBPYWId2TMqNjzjAxUKzDMt3BXXgm2wOgx7NEjA5QZ5PNAjPBiK4D2FV9+oMB/bqkxoOneg8z33T6/9Wf05xVdaLpIiv2fJyfVMc9Ia0bR4UorQeKwYi++9BksHS9IG0H4jvcdAeLJoWmy6mi+p6dWiJwvJF0Z5PgQ+30xaZznZgPoRrvO5rfhge0P8YoW7tX/yHfnVOgpXfoisHdn2ZN6yxcChe4e8cg6r1krZzBu7UyHSbJPDVhDEeMLPc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199015)(41300700001)(478600001)(6486002)(8676002)(2906002)(5660300002)(4744005)(31696002)(86362001)(36756003)(316002)(4326008)(54906003)(6916009)(8936002)(66476007)(66556008)(66946007)(186003)(31686004)(83380400001)(6512007)(26005)(38100700002)(6506007)(53546011)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWNtSUpoTmh0Q3MrQmgrM2EvamVrUWY5a1I4TEl5cTlKVW9ud2dXTDVydG9m?= =?utf-8?B?b0lKZk1pcm5Ma2pmUitnclVPLzYxZjVjWWZWRmRTUDNNYmU4Z0FNblBkVW83?= =?utf-8?B?VXczUnY4YnN6UjNYQmdlUmQ0UE1VMk5lUXVWUGxKM0hmRnNxQVdFM0Jtdm50?= =?utf-8?B?N1hadSs5V0lJQVlHNTQ3aXJkcW01QVRJaFRjcmovRlNLa21hcTdaV045cTFN?= =?utf-8?B?cEFBUU9FdnlvUW9GcEVmQmJScjl0dEtFWlA1alFPc3g1UWl3VkRxaFpXMXF4?= =?utf-8?B?dHJtaXlGdjhlVHQxSUFjNGRBcURrSlZzUEFnajRtN2l5elBVVGJ6U1pNYWRS?= =?utf-8?B?MUNHaGtHdHdyVjVkQW11Qmt4dW5KSis4U2NkNGhmbi91VzVHUHFNWVduR2ZP?= =?utf-8?B?UWkzN1I3MVdSeENadXdDN0p3RFpBMEdZdTQrdWVJRGpkMXVDOEc2V1JuZnJW?= =?utf-8?B?aGpOYjBaK0NSNmNOM2d4MzBsVDllSU1Xc2ZyVXl2bXBSaXF2SHpvaGw1d0pN?= =?utf-8?B?cGZjZHh1a25JL1NnRkJIN3VhQ2VtVXZUMHNIYlczR3NUeGpoNFNhc21LT3lL?= =?utf-8?B?aUxtanBrTTZnYVAxNlZ2bXZjNzlLMElETnk4eHdDL3lwdnJ1RHFEendadlVZ?= =?utf-8?B?WTJEYkRmcHdGS1BFeWpqK2NmdTlHK1Y1dTNwT1RoR0VEeGZMY20zSDQ4SnZR?= =?utf-8?B?OXlES3BvWmNOSnI5L2FlN296NjF5VmhCUWxZVFBnejdEcEM2WEVtdXIvdHhU?= =?utf-8?B?RmxWYXMvZkhJbzBRVHM0dVBQRSszQmI2dk1OZ3RjZTFyb1VObUZOWko5My9H?= =?utf-8?B?TlBndkh3OUthdUxsZWtNVy9WZjM5c0dWYW43cE9relRMaUtmcHBjalptTmRp?= =?utf-8?B?VXJZVFBUV0N3enlMeFRlTkU3REJKa0RJMzlxOEJXNk5aVjJmVThrNStacEFX?= =?utf-8?B?MWNWalhTZy95U00zRzlxUGJUM2N2UEdsTGVUOTgxOFAwaVQ1bUVVQUh5bG4w?= =?utf-8?B?a2lzNm0yS1hvOXJWRm45aDY1TWR4YjdjdEZISzBYWEthSmd6WG5zcG94NHVv?= =?utf-8?B?eURrR05FQ0hua3E3UTV5UzI0eXU2MVhHNzBFTVF0ai9SdDEvZmthcjRNZlNx?= =?utf-8?B?dzV3VHpCa0p2TFFmRGdac3lpa0d3TkIrSW1OV2xZMXJhVFYrZGVPaUEzSSt3?= =?utf-8?B?VUZPZThjVmZUS0h5MUZwOXdNbUdCQmdLNVd2T0t4SzljOTZWMUJTWEdpRkcv?= =?utf-8?B?UDMxSUx3a0puRTk4Mm9XamFNeTE0VEtiRHFDeEs0bzJITTh2NWlvVGRSM2hr?= =?utf-8?B?TGtiMnJaa0pWTkVkakM1bmgrSkg5NXEramluSWJGcTlwMzRhd2hhclVoS2Rt?= =?utf-8?B?WW4xcU5WK3lTNVlBOWpIc0d6MEVBWkJkVWlQOUgrZWJ1aXV5L3RQS2lRdDlW?= =?utf-8?B?RUYveVE3MGFNeGN0NVJPakp6UWs5TXBrSi9WOHhkL3QvdXgrdHJpcDFLTGpP?= =?utf-8?B?TEF4dHA2aFpIYlJET2p0NVB6ZnZHNUcxSFBvbit6NHdrVVZIbkEvQzhybEFv?= =?utf-8?B?bkNCaHVKQ1VMRVhhZkUvMlJ5bUhtanpUVUlsWXZ4dkZsT3M4bFNVNXdnNkNF?= =?utf-8?B?ZXFqa0x3RmFWQWI5MGNDRDhCUjdaMjJxVU9Rbzg1WHRaUmVuQzliKzBtdlRV?= =?utf-8?B?bEl0VmhaVTg2a3g4NTNTVXJvL0N5dTNkbFFxWERmVlVsek9VdzFNc3FUWG43?= =?utf-8?B?MFl6Tys3TExxVW82aDgvMnpES1R1ZnhYYmlVUk5KV2lqbktjVHdRRE4zdGIx?= =?utf-8?B?bFRCT1FEZXpNLy9KdEV4QlVVand4c2RWVDNRV2NiUTlpa3BiclNpakhmaVhC?= =?utf-8?B?c0pLYmFmOEk1cno5dnNCSXVGNVE3dFFqd3dKOHRsOWNBQzdLbUVTbyttYnZl?= =?utf-8?B?L1lYay94QnkrUSs3bkJ6bEpDUnJVS1VJSWxuWW5rSVNDQ2E3TnpLVkdnY0VH?= =?utf-8?B?SXQ0em5mY0ZMa1JISjM4RWNZdkdJalBZcG5nOWwzL21hRnhMRDZzOEoyM0VT?= =?utf-8?B?ZVUyRTRreVJEalZPRzE1ODRKRHVpTzAyYzBmL202MkNKQzJYMHc0cXcxSnYx?= =?utf-8?Q?GwNOicWjkplw/9HYbtDL5RRP9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ccc30eb-3de3-4baa-f8aa-08daa0a05242 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:52:46.3084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WjFzj4/f2JPuA9QI04yUoenLA27kyH7QDlbDOK+r4rpToOSZZWdE54TfzvtkQ6fiBW6YOYoNPrD7J+HgZyd4kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6828 On 27.09.2022 17:47, Andrew Cooper wrote: > This breaks all Clang builds, as demostrated by Gitlab CI. > > Contrary to the description in ecd6b9759919, -no-pie is not even an option > passed to the linker. GCC's actual behaviour is to inhibit the passing of > -pie to the linker, as well as selecting different cr0 artefacts to be linked. > > EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to > gain such a usecase. > > Signed-off-by: Andrew Cooper > Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") Acked-by: Jan Beulich Perhaps the Reported-by: Stefano should be kept, even if you noticed the issue as well? I would have preferred a mention of the questionable origin of the earlier misspelled -nopie, but I guess I'm not going to insist. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 15:53:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 15:53:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412811.656273 (Exim 4.92) (envelope-from ) id 1odCtg-0006NF-EW; Tue, 27 Sep 2022 15:53:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412811.656273; Tue, 27 Sep 2022 15:53:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCtg-0006N8-Bu; Tue, 27 Sep 2022 15:53:24 +0000 Received: by outflank-mailman (input) for mailman id 412811; Tue, 27 Sep 2022 15:53:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odCte-0006Lf-PJ for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 15:53:22 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8207434f-3e7c-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 17:53:21 +0200 (CEST) Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 11:53:18 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6516.namprd03.prod.outlook.com (2603:10b6:806:1c7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 15:53:14 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 15:53:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8207434f-3e7c-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664294001; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=H+VgL4WSKpP+S+SO6sL3Ai13+LdfkScFNzV9CmQm1+E=; b=QS4Glo1t2DP2P1cecDlqp6KXARJ3sjOqp18wB/6msrJKtkVHz548ZsXn X5Mc6sABdDp1eirE3NOkPcHU9OyFPlhnOPCIvRwFC+mb1LBQlSiPVZHul Z/DlaAa1j7hF7+hAE2SE6E7r4RqAkFnZuzzR4SRiOOuBUMYrFUyc4ldc2 4=; X-IronPort-RemoteIP: 104.47.55.175 X-IronPort-MID: 81109928 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yLKQUa7tjpZl85vHaQQQLQxRtCPGchMFZxGqfqrLsTDasY5as4F+v moaWj3VOKuJN2b1L4x1Pti/9RkE75aGzoc3T1ZoqiBkHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPYwP9TlK6q4mlA7wZhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5dDkZ31 fxBOQwob0i5o/P157ihTrdF05FLwMnDZOvzu1lG5BSAV7MMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGMkWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iL137eezHmrMG4UPLyA2sJa0EGi+mASCicabHiq++CCh1HrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+pQSiaPCEUKSoIY38CRA5cud37+ths01TIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPuZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:tHlep65Jr14yBfoqHQPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81109928" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XuFZgtwDOe/qQq/QeAJnmiBsZy+q+08z18T/IYth2O5fX1hWeH7jw9cBSb53+B1INbL5Gg53CjvZ5SaVQ20/BSBafD2wxwmWdmEISBcA6vQqonhMoAb/bpPpYIEaFRpyYeK7N4mR8tovEfPSCI+YVNj6nhc0F3cfmoGTxamt+lZ6PmssnOXNc5xPjfoZIfsEwrtyyjdj+AvKqyqYhU/h11TW4aaeTsfUyz13DMyVd2DetoaX8sMn1vchMyTvtYFowWGQIimzFxUq40VtZMEhFOH+FU+JPzvc8jqFBXwOmVR5d7rB2luf2S0RSp7OxxaaWYhceOvaNq/y4EhHKkjrBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVkphd21ENVtWsNYeVVgVUbFeR91ASK26PDzuyvoD+4=; b=fZUPPewzqRplyDOWiEHZCt8cMWMoRFAWB5ghv91ncwi/Af7u0glxAca/QfdNd+pqWqrWY6DNEeBsuSGxe4x8n4hVd6XNry0VbqIFuaoxAaYGmolE0uSsKT2tUw47mL2YMVPhdzoaM4+NVYkB1dl1eRb69mH2X0P+tOtrabwsJzdKMVN3WODootEJaYPNMB7GS6gD0kYpfv+fnv2UeEW+15zXepXRRdHiz+eU9eR9yW4m/KyBDvBK56IZWkExMMR3BRPyvvUU3BAKCQsgY/hi44YdR5J4VaiTJLmPjfLRPhvnFKnirwOel3iOBgTVVshMX6Ti/s4JFBqcGcP2HQXYRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVkphd21ENVtWsNYeVVgVUbFeR91ASK26PDzuyvoD+4=; b=o9E5fNOgtcgHkOCXAXyy1s8Ivk4VnPpgJwDEG9cycD0rPDNbKd/Amdg9FnLeD4SZJQ5EsAyDBC2KrZqcfq4nKvVh/ByzPA57YoA0ZIRhiZk6IyBVJYCy0s7Qt7aXPsO069Tn7dNMiv2BSPHjxFCV6qwX1S+ZQEw6BxRY8yVN0mg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 27 Sep 2022 17:53:08 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system Message-ID: References: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> X-ClientProxiedBy: LO4P123CA0173.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6516:EE_ X-MS-Office365-Filtering-Correlation-Id: b68c1521-5a55-4bf8-fc32-08daa0a061dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HHOLuuf8o0wSEMbNyJo/iHxbOgRtZzTTYnFU+aODaO82A73jy7oXsADealBkdhwbxrumEM4Vty5aDTfu8BSwm5AAAJdmvYgCKBNY7hdYscva+9ctCMkEhioFqe+tejfJHgaFHtmMYy+8DufJRhL518L9ouikvX9FVaLcbJLBE/t8A5Ju/x3Ij0rxraz8wXSpHLHCftOm6JQMg5OQ2sgkH/is8b+/8TRElnzB4PWGLwDBlydDC7xTEXDHzOEC6QUh1iPtIiNbe79p6wugGwZ3pQdZaEeDnbXckz1e/5PCaOpoYykpct8Ypx0Wz6N7D9K2QjdqVer/HmCd6HZ+apSry07oQmluyrZ6mEDOkYB/GIVYPb1t8xsusZZCOvDQLhxrtk2CLv/JxpPHFpEaYmR55l+DHO8BnLmwq9cj5XYs8ynmRPuBiw6mkSoS1XUonu1Z/75L13klVEBdoX5Btmp2xZMYbGWTY4NhADFoFBnVejH+8F5B/b7iscyspop2YytWmum9mgR6qAMS7HKP4cXiCSQTCdsvHzTwq6T1OVtGRCVBH5uJ12yGU7O567ldwjF24rBYqezpCZ5KzHAYumjyw5BrFgxbZsabqcxjdXW/ohu48cOeZKYK/IgZGqZboCxIYwvsA9pzVxnvhuUNlGD4D8vRu1b9yL+J4gG76Vpv3HLW/B/04OvrA4Q58bYtvgCH2EvKjX46LFMrfsh6d9pMlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(451199015)(38100700002)(41300700001)(6666004)(8676002)(66946007)(66556008)(66476007)(26005)(186003)(4326008)(2906002)(83380400001)(8936002)(6506007)(85182001)(9686003)(6512007)(5660300002)(86362001)(6486002)(54906003)(316002)(478600001)(82960400001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0dtdlZnbDlzdFZFWjI0R0FiQWJWNWgzakZZVThmNGIwR1FtdWRvZ1lrYkc4?= =?utf-8?B?VVZVR3o5Zmx2K0I3cXJaa0hMdEM3VVphdlJQcS9lSUhFQzYyUVRzM3dRZUYz?= =?utf-8?B?MlFXWDFLT283TGgzOTViWVVKRnhLL3RSMy9aMGFuRGhJcC9Nd3liZEpiVllE?= =?utf-8?B?dXpxVmxsV2gzRmtzWG9PRVk1MjNDYlBjM3NadnJMcE92S1luM0V0c05JZkxt?= =?utf-8?B?M044TjNUUG1MMVR2YzdnYTVtMjYraklpWCtlbzdtelpvWjlKVnMzYlpoL0xt?= =?utf-8?B?VExjTW8wODl6Ym82T1VnZEp6S1JpUUlZSUxqUEtWWHZqZDZTdmpEQ1ZzRWVP?= =?utf-8?B?RlpVckJBamxEMzdjVGhpQ0VyekxTU1MrQjFQWFF5Q0gxSzRibmlkdEp4ei9D?= =?utf-8?B?ZkZFOFBZSXBFM3p0b3hWN1RhOGNJWnZwMVMwdEVGWTArdndNcWl2L2FER2pz?= =?utf-8?B?bEZXa3pYZ2RmOHM5c25QZnF2OWhXTWtqQjg2SFBiMXA4VXo0aDVLdkhZU1Aw?= =?utf-8?B?YWNWODlmM0lVdUVBa05jOVMzR2c0d0QwUHdzZzRxVGREcVR6Zlc2WDdPZ1Jh?= =?utf-8?B?bkRLdW5WVTVHM3psOXJzR0N0SDVLOTdGaFc5UXRML1NEU01vMVNrb0ZRRTl2?= =?utf-8?B?dmdsSFlHT2VpbWRqSUVibTRTVlQyZ0pzMG1TM0NRYks0YnYzSmZXMWI4SDQv?= =?utf-8?B?WllMUTlPaGg4ZTN4S1hJU0gvUVFDajMvWTRaNStQWlhmSGVDZXd0N3RPUlYy?= =?utf-8?B?c254eHM4L3ZoRENaaVNKd01SM0lodW90Uk5rWG53WHgyTkN1RUtXV25XeGYy?= =?utf-8?B?MjhnVXcxMm5vdTZ1Z3M1VTRhZXN0NUNUL1F0VWt2OWFTZ3FvMTk3Vjg1SzF6?= =?utf-8?B?bU5TazgybU1IVnU3TFphZ1ViSWlpMlVDQlBXMEZPRkR3MWViYUFpUytzcm1z?= =?utf-8?B?Z1IvakdkRlp0cUhIZytNZFFSV0Q3U3RXQlAwMmFRaWE0ZHhQa3ROeGVkSFNl?= =?utf-8?B?bEMvNWdRMlNPcUo1MTJnU25JZVZRVlFwUlVrUjBTUCtSTlVxQ2RYaUhhSS9Q?= =?utf-8?B?cXZacyt4MnJzNUltWEt4UjQrYWhYUnc5ZW1XL1lkRHN1aWFTWHczaVhVWFE2?= =?utf-8?B?TXNkNWdwK3RnbEVxRE9iTjNYMmFTVmc0UnZJU25KbVdaREpuZXJZWTVITUl4?= =?utf-8?B?SUpPb2czMjZRcG91WmRjRVJPdk5iZmVLSjdqZmMzQ245eGNXNGwwSFdZVElD?= =?utf-8?B?S0gyNmw2NW5DM2p6aE9peGQxa0YwVFBENStCNm9qTm1Bc3F0NnEvZzlYZ3Fj?= =?utf-8?B?RFNtR1JJWUZvVlZ6VjBZak1LUVZkclRYY05wSzFRUFdhTC91QS9rSGtIQktn?= =?utf-8?B?MXlQMFAwU2pVYWZVaWZkdnVDTWhhT2s0eGIxZ2ltWjkrZ2RQNGhyOHY1cEh3?= =?utf-8?B?UlhFZ2dXV3FLeDcxTjErbVp3UUJpZ1VWb1dQWE56TXUrWXFzWDVWV20yMXd4?= =?utf-8?B?WHp6ZzdROHpRUGhwcm1sY0k2TkpPY2tNdG9zcXlZbDNZNDlZOE5rUGcvNmh6?= =?utf-8?B?emtYWXNBQW1JcWR3MUNvQi9PczJZWVFXKy9zWWlsSHVFcnhTV1lpeGlVN2xl?= =?utf-8?B?aTVqZWN2ZkhhWU52dzhOczIvZ0FNZ05WN2crZlRnbkpDck1ZaVYvYnZ2VUdL?= =?utf-8?B?dGttZTFxbXh2RWJVazArS3J1bkJKUEJHVmppYzJaenhiQUdYWlpZaGIrcUdF?= =?utf-8?B?V1lUb3J4MUt6R3cvYnV5NDVvWkJSWFEybEtQYVd4bFRadk1YeTVBV1VqNFph?= =?utf-8?B?RzkwaDJCeGMrQzBxNm1xT0xQSVR0RE1kMnVhQ3Q3dXhFUmx2OEc4ZytEQWlo?= =?utf-8?B?b2RWWlBFbDRLaVlPUmlac0d0WWJVNFNRWmE5V3p6R2E2VHMvdDRZbnNwcWRM?= =?utf-8?B?VWY2dVhHcUVFelc2SFRxc2NXVUFjS3piVXoxSkFvTkJPVzZKM2xYRzJqVmFQ?= =?utf-8?B?dnE2YjlmYk5CTzFtUFQ2TkU0cTY2MUdoaEM3ZDk3b0hHSUFWQStyRXdzSnZO?= =?utf-8?B?eklodjM4Z1pIcWM3ckJ2YkdOVS9hU3lnSzl4dUVSaVh0MU1PZGREV050azc4?= =?utf-8?B?dWw2K3YvbElsbHBod2FhS0w4cXJYaUpUcTdsYkhEcE1rTEhzZi9yWWcyTi95?= =?utf-8?B?cGc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b68c1521-5a55-4bf8-fc32-08daa0a061dc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:53:14.8132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pe6rSwS1VTj4EvjY/GdO5J+MZkjTJgrsyH1jtWc2HLJLbfo7+ODrAQple2s7DslyP9Vmt6F7odpDQcb3akVfBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6516 On Tue, Sep 27, 2022 at 04:15:19PM +0200, Jan Beulich wrote: > SRAT may describe even a single node system (including such with > multiple nodes, but only one having any memory) using multiple ranges. > Hence simply counting the number of ranges (note that function > parameters are mis-named) is not an indication of the number of nodes in > use. Since we only care about knowing whether we're on a single node > system, accounting for this is easy: Increment the local variable only > when adjacent ranges are for different nodes. That way the count may > still end up larger than the number of nodes in use, but it won't be > larger than 1 when only a single node has any memory. > > To compensate populate_memnodemap() now needs to be prepared to find > the correct node ID already in place for a range. (This could of course > also happen when there's more than one node with memory, while at least > one node has multiple adjacent ranges, provided extract_lsb_from_nodes() > would also know to recognize this case.) > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné > --- > On my Skylake system this changes memnodemapsize from 17 to 1 (and the > shift from 20 to 63). > > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -78,7 +78,8 @@ static int __init populate_memnodemap(co > if ( (epdx >> shift) >= memnodemapsize ) > return 0; > do { > - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) > + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && > + (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) > return -1; > > if ( !nodeids ) > @@ -114,7 +115,7 @@ static int __init allocate_cachealigned_ > * maximum possible shift. > */ > static int __init extract_lsb_from_nodes(const struct node *nodes, > - int numnodes) > + int numnodes, const nodeid_t *nodeids) > { > int i, nodes_used = 0; > unsigned long spdx, epdx; > @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes > if ( spdx >= epdx ) > continue; > bitfield |= spdx; > - nodes_used++; > + nodes_used += i == 0 || !nodeids || nodeids[i - 1] != nodeids[i]; I think I would also prefer the `if ( ... ) nodes_used++;` form, as it's clearer. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Sep 27 16:08:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 16:08:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412821.656285 (Exim 4.92) (envelope-from ) id 1odD8A-0000Bn-Rx; Tue, 27 Sep 2022 16:08:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412821.656285; Tue, 27 Sep 2022 16:08:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odD8A-0000Bg-P8; Tue, 27 Sep 2022 16:08:22 +0000 Received: by outflank-mailman (input) for mailman id 412821; Tue, 27 Sep 2022 16:08:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odD89-0000Ba-0T for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 16:08:21 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2072.outbound.protection.outlook.com [40.107.249.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a500345-3e7e-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 18:08:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8178.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Tue, 27 Sep 2022 16:08:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 16:08:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a500345-3e7e-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEMwUGSI834N9Oe7xPlHaXsPeo+hy9zzIlc2qULKtmEWpfYfLsX/me/fw0lVHE2kVO9M+kL0gNYDIpa/6iEuWbnJ7sN9nuDrgRNtK9bZ6CyiuBmzPAw4ffOHiMMHes6pLBafRz3V9/0WfsHmSjqZAin3PiHI2zyz4tlC6FNfPQBUTdsRpnGARA9QsG2Ka6KYWaOcEGXQu3eDBw4kkKWhM4t8NeGX0PhI4wW4MAzi1k98UqT1oAtyULTs0iijg4LsiFwc6HRC1qMtQCTEZR9O0YuZP20NNk+OZLoMaE4L7MxgQd6sqQusR/ETSTVf/MPQHk7MC6YtWVDTM+ne76uphA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s2OGboVq3PfQxxwhvFOy0FoahiAPxk8VGhf5ESu5kZo=; b=nn7LGK2hrIjOS0jdB2y4MTWtN7SjDrGx655SGVDSChoiCk7FLqFGn5hGAYRm5w1pnbEaEUO4o4/L2kAa7ZR3ubrAh4DtZxRtL4s0veBY2Hx8g3Qud4BNHFz/aZ0HgjEDowy0w9U4lmjdy6Qu25QhZpYeBbOFLrXt90sjvhdvsIMMY5IQEGUgbT4I8PCH2m2qZHhXxlCsCmvKn0k5ST1zQ2YH7tZlQ3iddqYuSEfpLstnZgBlARfwYYCpGXH6+FbT7zLZzUGuaHikW0SzSsoIFNq95gb9XvY9cXx1/h17U8HaU+Ka0s7zGpUQnsbv77i/v2rXCkCRQDNKHa7qjU0yEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s2OGboVq3PfQxxwhvFOy0FoahiAPxk8VGhf5ESu5kZo=; b=5DWyC4xymFSkleNaWF1yQUbQf64ZTKU+mRLRpfxCVDEBGJfkcPyxT3FiuaKVdNErUUYV1Ap7dN+dC+4q8xPBnqmEvoh41ARMovWdLTs33gxuezIPxrL0qDIF1x4NjU3u0xRuxJ6S9EQr/ggYbis4xeytZEx4S0lz633AjwhHB0RIoUXZoBu8/qWl9cA+T1a6rQE2tdvEi125dIgskN3cPxG2iwMMGRi6MyheQqqE4XMyjbQpJ+JgsrPHULIvpP6GhTwOwaJ3gpdpYszErij1Zywlu/BnBHiEfsEv3Yjm9a7kcbxnFGBS+FI3zt1YSfq/aLh3hhEmGYK8jVUwwn+KKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 27 Sep 2022 18:08:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8178:EE_ X-MS-Office365-Filtering-Correlation-Id: d1be4024-9c28-4f8b-9e64-08daa0a27e00 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: og2SEg+xXFJkGyiFsWcqPrs6CZwISmqWlW2jlL+GpTxfd6sreeDU+tfw+eZUmbSFP8n0NzowdKwUpOYsxj60l6e6VfCn0Nb/4rmT6ig5hp5WcYkXAZDIVudtYxFvwvsz5MMXbSky3S1qxlJLaoQN2DYXoQNMwGWFF9iKzj4tXPAs7hil63y0iIazPVgQIq4A/eUsK0JdiVlRNtraqJws2VK+cJoG1zDvPEMZLcDSMvn4MEDmpQGM64Rf5Ysh5OhLmuMEWqfQ2AgWbQGgabvWjbYWt8gzHTwcwvKhgG60eNOgmC62nOYF8WnYDjMa095rCgurFJw5H4Lin0ZtfMQ80bgyfDIA16GuVC7Dn05PcuN515BCrl9B/8+QBjZ2DdgccrFcd40NO0CoBiZHYdDHFiNdgsZmvlsSdrjrY1mo5tBq1ejwPqJ0WPzjDPz7fq2dSgnZdFGefCj0cJu8TYLjBfRr+9uu0/mN/NIfHuatUa+os9f3+8+uGnRRwc8PqsNcQK94D0mTvMXOqH9RPNTfhR3LWtFmpkmT5z8ZvefXdaZAmbb2MZu/JCkBnG/Ez9OtyrgTuGz/Ge18F6SVb7z5rfUINdBuCO9Jr+cBCBXjTQ6P93mcDo6ac7Z1y92CwX1lExwwVq59GCjbssdj0MIt7n4cNqXOWb7cngwGzxvzTUz1gGQ8G3u41f6wjUWA6qkN9kUdNXFfbUzi653xkaD9p1lY05Z+R9hLtw2KE6SkfFoy4r6NPfVeE4U8fr6brYIDdDnOMep/OltWQznwjq0/DVZMjcQ8FmcGOLUEsVlMK3g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(136003)(376002)(346002)(451199015)(4326008)(8676002)(66556008)(31686004)(36756003)(66946007)(2906002)(54906003)(316002)(6916009)(8936002)(38100700002)(86362001)(31696002)(6486002)(478600001)(83380400001)(66476007)(6506007)(53546011)(186003)(26005)(5660300002)(41300700001)(2616005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTNGY0NOdnpHdWs3T2k0dGIzT0ZMNFpLZHJELzcycy9kazYxb1YvdTlhQkIr?= =?utf-8?B?SW5TSm9MSnlBOHpFU0hPak5VT1ZsWDdnUXZsUVR2ZmpKQnhxQUlkeEZOSEty?= =?utf-8?B?SXVxbFBlRTVpelRxam9hZU1VdlB3WUFTWEJpSnJFT0RETGtVSWo0dWFyeFI5?= =?utf-8?B?NTlJTnBMNG5ZK3pzUnRHWFNHZnV2aDFCUy9jOTM3aG5hcStIQ2lHY1ptUW9q?= =?utf-8?B?MmZOTnpScVhhWFIvdTcrRnFxOU5lZlJKbUlGZVhiMHZtRVFrS1VDbURybHc4?= =?utf-8?B?K1RwWFUzUGNOSUkyM1hYUXY2WGN5cVJ3SWtrUC9vZGNNK2RZUTBraHNRcVlY?= =?utf-8?B?bytIYy9XSVBGTERkTFVaeHpQaUppYy81MVU1Z3c4eGQralV4aWYvb2lWdS9x?= =?utf-8?B?TWw1SGxOaVltSHRMd3ZrWGpnRTRsYnZ0K051aGdtU1NQbUIwbVR5aHdpSTAr?= =?utf-8?B?U3I0cXFYVUhTTmlYTGE3cGhXVXVJM2YrZ25zb2FlU1BWeGpqY2xYUkFrR2Vl?= =?utf-8?B?UXpZbUwzSkE2UXkwUzlnTHZkOHNOK3dtNnlGa2k4VXUyc1JXTzNGU1FveFp4?= =?utf-8?B?dStwZUxmWm13cm84T2ZPeWRVZ0lHOGZId05aUGxxbWpNblV0RkNZVFF1Um16?= =?utf-8?B?SEJkNnF6UEZ3L2JrMWhZRlA0SCsxZ0VmeHBMZjNPL1NCOTkvYmF6N2k4d0dV?= =?utf-8?B?VkxYdXlKbk1HdWoreUw5QTRmWWJ0RVdUVzAxM0EvUElyWkdYcVQ5KzJvK0FZ?= =?utf-8?B?RDVYSGpSZi9GZkgveENKVU9lenRIakdiNS9aaStnb2dDSW1DTU1CczVkYVRE?= =?utf-8?B?eUUrU2tXeklVL2hvTEw2STMzVUp4ckJzZW1SQjdjMjVVMlhmTzBKSkZyenAy?= =?utf-8?B?RC9Fa2p2anlqZHIwWnBmei9rcE5YN1JmdU8zd3IrRFNkYWZUS1JQbVdMS2V6?= =?utf-8?B?K1hQOVpFdXNpcGsrV2w2UDNDUjR4TFlybFkxdkdiNHlHdmhVNnphRzljR2VF?= =?utf-8?B?a0R5eGVhT1F1RVJSbFBhcDU4VlJoUjJqTWJqTnc3MEc1ejZoRC9kWGhrTFEw?= =?utf-8?B?aWRqY1ZvOW4wMFJoMUVNdW1jSkgxNTVpQThaQzFWNUpDN1owR2RLanRTcnlP?= =?utf-8?B?NXhNUmlqdnIxZ2lNaE52cGRaWFZCanRPWVlEVHZycXlMVnVORjJPZ1U2R3NF?= =?utf-8?B?Q2hkUVpVQWw2QStERHhMcTZibVVFVXJLMVBNamdFcTFtbC9GVXFLTjBUamJW?= =?utf-8?B?OFVFR3ZNNmRxNDErNHlOMWZpZ1FtcHJDMTFhZEZRbm4zeXFOUUw3amN3NGND?= =?utf-8?B?V0c0djFLdkc4QmRwSVZ5blo2NkNOc2tLMWJrWUxMQXJsM0Ftbm1WTWdiUW5D?= =?utf-8?B?aGtxS3RxSjVpeUR1bU9uc2xZMU1jZGdFa1Y5MDR1SkJoOVJnL3VQd09Bc0VL?= =?utf-8?B?d3VHMnFzL3lqR2ZSUEZteSs4NkhLOWpaTUltd1BRbTZ5cGR0cnR3ZjE3TDNr?= =?utf-8?B?amJZTDdwaEFSL2RkTy8vZnVUQUdzVDRrQ0pYM2JqdGptWEFyekpaakExeFE2?= =?utf-8?B?dVc2elI3a1NTRk9WSnYzNnYrcmZvSkptcGtXQ3VvVElud2pKRHI2Q2hjak9l?= =?utf-8?B?dEZlQ1pNUzQzQlgwVnYrVEJ6NitKWWx5M3FTMXNhQlZ0YndsRE54MGdYWVlk?= =?utf-8?B?SlpTUjVDTEdvaE84NGlFY29YZThLdHFsREd3VUxuUmhsbkF4bjYzL3BJa1U3?= =?utf-8?B?a0Z3bWs4dHNpMkhLZEx5S0U0bjJYY0lVdG9zZkVhL2VudTNTRnQ0c3NlNXJQ?= =?utf-8?B?bWhxRDJ2MFdtYTJOUUV6Q0hjM09MVDZBbW1OS2QyOVBZR29OdjIybmZ4OWVJ?= =?utf-8?B?TVNUaFFYcjJRWm11RklHMFM2b25oKzhFM0Rrcmo1d1drOHd1QWVmSURXZnU2?= =?utf-8?B?c3JjQ3FVU2ErUmZENC81YklFcFNwVSsxZ0NGVm41U0N6N25SbVRxNHdtQm9q?= =?utf-8?B?WUt3VnhlQ0lLSE80VldQUFVva09OQS95UGpjYVZiMCtwRGFnbW0xTDBScjk0?= =?utf-8?B?VVFRNUtwNWdYSEN2cTFwTitIbnpqdG8zSGk5SGhlWi93YzVVS2xhcFppMkFP?= =?utf-8?Q?GK8vKraXrPPYwi6K8BhO+CCLE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1be4024-9c28-4f8b-9e64-08daa0a27e00 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 16:08:18.6087 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oEjjKyeG/+c5GQcv+odBza7xk+z/p1IzBnC3rBL0/4tRhRw+SFr0Rp/Lmvl6eoFUaQY3z4cxLFs71tNMZnkxuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8178 On 27.09.2022 17:53, Roger Pau Monné wrote: > On Tue, Sep 27, 2022 at 04:15:19PM +0200, Jan Beulich wrote: >> SRAT may describe even a single node system (including such with >> multiple nodes, but only one having any memory) using multiple ranges. >> Hence simply counting the number of ranges (note that function >> parameters are mis-named) is not an indication of the number of nodes in >> use. Since we only care about knowing whether we're on a single node >> system, accounting for this is easy: Increment the local variable only >> when adjacent ranges are for different nodes. That way the count may >> still end up larger than the number of nodes in use, but it won't be >> larger than 1 when only a single node has any memory. >> >> To compensate populate_memnodemap() now needs to be prepared to find >> the correct node ID already in place for a range. (This could of course >> also happen when there's more than one node with memory, while at least >> one node has multiple adjacent ranges, provided extract_lsb_from_nodes() >> would also know to recognize this case.) >> >> Signed-off-by: Jan Beulich > > Acked-by: Roger Pau Monné Thanks. >> --- a/xen/arch/x86/numa.c >> +++ b/xen/arch/x86/numa.c >> @@ -78,7 +78,8 @@ static int __init populate_memnodemap(co >> if ( (epdx >> shift) >= memnodemapsize ) >> return 0; >> do { >> - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) >> + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && >> + (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) >> return -1; >> >> if ( !nodeids ) >> @@ -114,7 +115,7 @@ static int __init allocate_cachealigned_ >> * maximum possible shift. >> */ >> static int __init extract_lsb_from_nodes(const struct node *nodes, >> - int numnodes) >> + int numnodes, const nodeid_t *nodeids) >> { >> int i, nodes_used = 0; >> unsigned long spdx, epdx; >> @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes >> if ( spdx >= epdx ) >> continue; >> bitfield |= spdx; >> - nodes_used++; >> + nodes_used += i == 0 || !nodeids || nodeids[i - 1] != nodeids[i]; > > I think I would also prefer the `if ( ... ) nodes_used++;` form, as > it's clearer. Okay, will switch then. This isn't for 4.17 anyway (I think), so there's no rush. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 27 16:13:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 16:13:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412827.656296 (Exim 4.92) (envelope-from ) id 1odDCz-0001cK-Ez; Tue, 27 Sep 2022 16:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412827.656296; Tue, 27 Sep 2022 16:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDCz-0001cD-CJ; Tue, 27 Sep 2022 16:13:21 +0000 Received: by outflank-mailman (input) for mailman id 412827; Tue, 27 Sep 2022 16:13:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDCz-0001c7-0m for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 16:13:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c175c13-3e7f-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 18:13:19 +0200 (CEST) Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 12:13:10 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SA0PR03MB5642.namprd03.prod.outlook.com (2603:10b6:806:bd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 16:13:08 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::4dc1:6b11:9f99:1eec]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::4dc1:6b11:9f99:1eec%7]) with mapi id 15.20.5676.016; Tue, 27 Sep 2022 16:13:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c175c13-3e7f-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664295199; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=W7Ui61OuPdjEgYUwdZeyClV9lhVkX8/EMlQPr18LY3Y=; b=Ap6izi/tHBeAr7GWxxZh8JPw/RzZuyOPxNFjRmMrv0ypgsZyk1P+0b8m yYP1sgfSGTfGMziYvG2jkuF2ZYUQxYELjqdNqUOB443q5ILHGVMxgLXeo uzYf4nzqh0/51fvVBotpKpyUIYZ6nixYdNNZJ3W2J5ZNh2bOYXcrumsQs U=; X-IronPort-RemoteIP: 104.47.70.109 X-IronPort-MID: 81111924 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DVKJFaAUcNUf8xVW/zPiw5YqxClBgxIJ4kV8jS/XYbTApGkk12ZSn GobCGHTaa7fYTD8e9gjPoqy9k9SvJfTndJmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37a6t4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kGJ4cF3OVbEVtH/ OIKcg0zSTTAoruPlefTpulE3qzPLeHNFaZG4jRK626cCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWIA7gvN9MLb4ECKpOB1+LXhLtvTPMCNX8JWtk2Zu njH7yLyBRRy2Nm3mWPcqyv93LOncSXTd71CS52kx/9WqXKe2Ew6UDsPUXm0rqzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywqQGGUsVDNKb90i8sgsSlQCy Vuhj97vQzt1v9WopWm1876VqXa4P3cTJGpbPSscF1Jdsp/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BDjNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:T+ZmRKC2oapM19TlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.93,349,1654574400"; d="scan'208";a="81111924" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QWV82Km+U7RQPy/v2Nl724KjSDL/jq5iJBoH7+6681JaxLCD0yvHE1hpL76hUTtD7b/uZ5wyYQYdnxfLigtp1FZ8v/HJM+vUHZ08GD9ki2SHnQbu6UxZnfjRj0G0Ttrj1MRT0NSBbnp5QeuZRj2Jlv3FGFnFUZ61cjF79M9KwpM7OzvTkZx+ldaPHrHklBv/S4orOggL+j1adpW3fjITI79eDa1FqHxOu8IQ0hqHgVIyu0glRK13h++rchfGMZV4cQniKqnAxrk3EPC6sAJ4TPcDI+UNDg2/ovEj/LWDYQoyimWO/fvebd5KUGXv8bd4LpQE/6Vl8r8u+keO0TqTmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W7Ui61OuPdjEgYUwdZeyClV9lhVkX8/EMlQPr18LY3Y=; b=QrVjuuA3IFTT0QLHpzH7bnLEyX2z2KD3cm3xFK9d4YZBZOPj1bh8YGp5Gp+nnJoWtEKC8jq7I3yyqq/TAIGcoPD3i24ZKNjyyBJDy9gsVbf7Y5CoLxn3JUEdZ7FAkkWZ8aLKhkRkVsnBwR2SQcRoVPoFyFYGkKsofREweiO/4uVAyswAqTb7bT0y1TNHrtTlki15As5VCldsYJMQDAX73gr2O4gCplvh3xDhpf/1QKjPyVw7fy2Tn83hW8mElXEl2BANCmG+3J5QiMckAMCoY+a8S2Hg1quEiMziIFnn+oi401SdywIcrJuPzhUFLXS79q2qtSaxJxGmFiyun/sOHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7Ui61OuPdjEgYUwdZeyClV9lhVkX8/EMlQPr18LY3Y=; b=BqtILVyYTgFg89r4zeBv+wf1psyKqzFAgZY6/KIpg24HxGiviU+fixlVAE9zsKGpHPW3MY57IxnyTxzofqzt/joThxuIPjkFSdt/HVqP+5RVVpPVzuVIleeuEiNh8Ks1mn/jsoPSHgXMph1HlbqSHViRFRcjjmmw688ETmJ3zY8= From: Edwin Torok To: "xen-devel@lists.xenproject.org" CC: Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Thread-Topic: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Thread-Index: AQHY0mKHWIzo/zbfF0KNs+muY99n/a3zc0gA Date: Tue, 27 Sep 2022 16:13:08 +0000 Message-ID: References: <7b88cbda20e068bbce1c5dfb0a18af3f4e4b6865.1664276827.git.edvin.torok@citrix.com> In-Reply-To: <7b88cbda20e068bbce1c5dfb0a18af3f4e4b6865.1664276827.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SA0PR03MB5642:EE_ x-ms-office365-filtering-correlation-id: 9d4800eb-fa4b-4493-9b0f-08daa0a32a9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cyK8xhO4TQXMv59kUnpL+n7XSBtXOCRFy1i8TFulTCe0Kz7HfNFOITxk4ZO8EcPMPNX70t2ks1tF3xyS1ais9mO65OecaaNwpQrmX3PoPppTnjtnZTTMZRhHzNglUEdyETn2yKSKi1krizUKUjDIzM1Y7tK6hdHvXIF4F9hT2dEHAADos2M9ON8k9L8daLvcSwSf5DoOGEHARbQxSP7ltLU88sjSqLErVyDhepQAr6/JtZC4aCGszuTZpRKmSfe8iwLyt8R3qV+rfpYBuOc8lx907xA5ek/XSpH9OZ6fAYOTOHshNL3jhPfYqTzpR4ZBmH0rxaq9gEtPymHpRvxW3MwPkkI0o/5X0NACi+bGmWcpaoU0vq/6jD/Xn+U0YCt1nyd+1XHWKhc+Fretk8CGfnms6lTgyboUC+fZQUv4myL8QLzi6DgPNXe2PLQkhpTpbnO/A/DbMRlCJEAO7p0O8gmyjayy8TaI14GnhqleBLA90Aclb96FVrRCvjZ3DWUEMGeIHCWDc6Skd2yvJgjIhjHSzZURBE+2pd1dPALyvaKeldVQbPBe6m4r0rNB141i8KS6W/B9c0YGzloRlO1N+3nGUQo7KyozF9QUHCmJY5K4nNqYZlQtbQawkkxrRCH32ymF2Nm6Tz3ep3haiZje28ssnXXn+i+3jU/pEwqvMQvYpusIzjUhFRe2bbxBPh2hdItvvHGO/HzvglkYbBlIvUm7pKdWDO5oY6ndkjvK8V1TOGcekIokVhj966bF3M0Fsny47SEyRw+bwdK6ecWjNNFBnRcjFsIS4KamhaXjBAN6KptfNEw2Ipq2AuQzRUWnswWvXBhvgpUv9KBWnNqXOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199015)(45080400002)(6916009)(316002)(54906003)(6486002)(86362001)(966005)(122000001)(478600001)(71200400001)(5660300002)(36756003)(66476007)(91956017)(66946007)(66556008)(66446008)(76116006)(64756008)(8936002)(8676002)(4326008)(33656002)(41300700001)(38100700002)(38070700005)(83380400001)(6512007)(26005)(53546011)(107886003)(6506007)(186003)(2616005)(82960400001)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YjN1WlFXcGJXV1VrbnR1V0JSUWQ2S0w1TUpTQWovN1lDMkR5dHRIdzVtNzFm?= =?utf-8?B?K2I0cUswYlJzU1huTUpVMjhmY2JqanN5UUNMMW5ndEVmZUN4S1hvbkNrNG92?= =?utf-8?B?akZWckcyNUpyRU1wNnIzcVk3cU54WUtXWGJUaVMrc2lKdTVmQWZHbDkrb3hv?= =?utf-8?B?aGdHTFYvRFFxWkJSMHVpcTJKZlZ3eDFWWHNPQS80NkxaekNJc1ZQemNNcGtV?= =?utf-8?B?MW9LdFVPVElpNUFwWmJyY2JNcUw4TTkzMWFYajhyNXUwRG1Cb3duZWNIK01u?= =?utf-8?B?NGtuL29QYzBDRGlsZkhRazk5b0ZYYjBiZmUzYy9Ec2ptV1NVTG5Qa1RHTlNL?= =?utf-8?B?Y3BqNFVkOGFDa1JMSmNObkZXdHhkbTRZVGN2bFk3cm03UHpHb2QxeUloK1VQ?= =?utf-8?B?dFBBMGpnWEtXRS9WL2lIOGh2UHFWbTA3dXJqSUJ1azNCK2FscmwyYlFUSm1u?= =?utf-8?B?Q21nYUU5R2JWVmRkbXhEb0Rramp6V3NQTE8rRFZwNXFvaDJSVlM5RmdCdnc4?= =?utf-8?B?Um9ZMGRjZkRXeS9RSU9XMWVFZkYwRDN5M2FnMGE0Sm9UQ29UWTZaYlZsVGFD?= =?utf-8?B?RUNNM0ovM3pPTnB1cFlidytxSjdiOGJXZVVxajJ3QUt0Qm1FVDZmSmI5LzBl?= =?utf-8?B?TTFZMk5KRWxVVkVnZDdFc29rdm1LY3htcmNxcXl4TWwvMXdRSVFLWnk5Y3Vz?= =?utf-8?B?a01PR2lHelpoSFQzNGxZc2pPZzhCY2VuNGZlTGo1VGN5cWVGVHVwbU5IYTJ3?= =?utf-8?B?ZTUvb1FJaElwWFBMRHBpR3BJeGlSZmtDRWNweVRGTHJOQTVNUnZoRE1VM3ky?= =?utf-8?B?QW5HY1RsamMvSnE4RXpsUWpLWnI3S01SVDU5djhUdkU1UWV4d29GZS9oblp6?= =?utf-8?B?dTFUWndheHBkNWEyRndtTFN1STlmK3JPTmc4dngzSW8xZ3pkWmNqdU9STzhC?= =?utf-8?B?Q3hadjRtQlBoNE83cVJpQlhCS2JyMjlTZkZlRXBtWk5LcVA3dUd6SUxiN1FW?= =?utf-8?B?eGNWOXUwaGRXdVRKYUg0WXdLSlp1aFJMVm54eVpYOGxVdjlxazlnMDVldmNS?= =?utf-8?B?ejlONWJnNGRHdjNabzk3L1ZHd0dmZHNNV012VkkvcWlqeDlnTG5OSVlZY0lj?= =?utf-8?B?SEh3RlVzZzkzNFgwTlhGSTI3SFQ1Y2FOVGl4VDJLTjF3QWFNeldpaG4zaFlq?= =?utf-8?B?YkRtUUdqN2pIemtGMXUrZ3cva0JHWXdkYU04VktxRkErS0dlSmJZc2h6SnR0?= =?utf-8?B?OUtFb3hhVlcrUW83U1hZTVR4OWNlZWlsQzdtaUJOdkJreG9qVGxTcmFGaVc1?= =?utf-8?B?RTRmRDUxMCtxVDZxUG43NnBsME1FWW9xVWVDK2lWSmVYMFluNUJWaE9KdzI4?= =?utf-8?B?QXllUWdMU0pMcVRvNnJCUzZWcUdtYUl5ZUpObldsa0UzRkJqSDVjcmFBUXJk?= =?utf-8?B?L1J3OVkxRWV3MDNwTjNpZHozeXErMmNNVlRjZFcvZVdHQUdkeGJyN25YdkNJ?= =?utf-8?B?Sk5hV21Deis0WVphV2xzRmlzMkRsRno0R0dFTkdUbUpzN2MreVk2bXJJZElx?= =?utf-8?B?RUxYTTJkSXdQQXBPQ0tvazVqdE53b2IzeXY2TEZYMFBaZkhLMnEwZlg2czF3?= =?utf-8?B?VDJPVlhHSHVYOEhQeGxFM21FQlh3ZEU4eE9NK2V5Q1llTHMvVnhIMnNMaWNK?= =?utf-8?B?SzZabi9UZVFzbk54V3NWTEYzVkFnaTVlazJzdDZIbWhldExxdURBNmQrQVhv?= =?utf-8?B?MlZYQ0FCbTJLcGF0dk5vK3pudElPdVd0V3V1WXdwa2J0WFVPQ1JyZ2xQTjha?= =?utf-8?B?dWFYYzlvZVlNM09hSnh2YXJQZUdhc2k1RXZjT3p1Y0h4Z3BTS2w0KzlSQkNK?= =?utf-8?B?cVJiUW5ISDlDb3NvcG5QREZ5Y3JQaXNUZlM4OTAwN2FtNHlUUkRwcnBPZGts?= =?utf-8?B?MjFjVW45ZnBYSGo5TGFJS2R2Kzh3ZFVyOHFGOVdKRXJtRTM5R0FzZVB1Wk9n?= =?utf-8?B?MVEyLzVSVktjUjVQMXJ0TGVJa1FCbEtXeFFzdGNQdFh3cVo2UkppdCtyKytq?= =?utf-8?B?dm9RWlZJd0x6UVF2cDdmM1FWWE5RSW8wL1dKTVZKOVVURGJaVzEwQmlwR1JS?= =?utf-8?B?aDVPVHgwUmR3UlY0WjUrSWVXVDVyRHQwZm4yS2pnM0s2NUlTTmRERnJzOXNh?= =?utf-8?B?cEE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d4800eb-fa4b-4493-9b0f-08daa0a32a9c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 16:13:08.1053 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nyshyrr4qf+aJ57yan8CKe2hKdKk4IVhMJ6vTmKfSri4RgFl/QXbOIPRMsx9lsSVxzbqIvGdAE1/lG5U6Ay2Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5642 VGhpcyBhY2NpZGVudGFsbHkgYnJva2UgY29tcGF0aWJpbGl0eSB3aXRoIE9DYW1sIDQuMDIuMywg DQpvbmx5IHJlYWxpemVkIHdoZW4gSSB3ZW50IGJhY2sgdG8gbXkgRHVuZSBiYXNlZCBidWlsZCBz eXN0ZW0gd2hpY2ggY2FuIGF1dG9tYXRpY2FsbHkgY29tcGlsZSB3aXRoIG11bHRpcGxlIGNvbXBp bGVyIHZlcnNpb25zLg0KDQpTZWUgYmVsb3cgZm9yIGEgcGF0Y2ggZm9yIHRoYXQuIEkndmUgaW5j bHVkZWQgdGhpcyBwYXRjaCBpbiB0aGUgY29ycmVjdCBwbGFjZSAoYmVmb3JlIHRoZSBwYXRjaCB0 aGF0IGJyZWFrcyBpdCkgaW4gdGhlIGdpdCByZXBvc2l0b3J5IGF0OiANCmh0dHBzOi8vZ2l0aHVi LmNvbS9lZHdpbnRvcm9rL3hlbi9jb21wYXJlL3ByaXZhdGUvZWR2aW50L3B1YmxpYzANCg0KDQpG cm9tIDc4YTYxM2NiYjhkYjcwMzNmZTc0MTQ4ODkxMmYyMWIyNGVhYWVmNTYgTW9uIFNlcCAxNyAw MDowMDowMCAyMDAxDQpNZXNzYWdlLUlkOiA8NzhhNjEzY2JiOGRiNzAzM2ZlNzQxNDg4OTEyZjIx YjI0ZWFhZWY1Ni4xNjY0Mjk1MDQ2LmdpdC5lZHZpbi50b3Jva0BjaXRyaXguY29tPg0KRnJvbTog PT9VVEYtOD9xP0Vkd2luPTIwVD1DMz1CNnI9QzM9QjZrPz0gPGVkdmluLnRvcm9rQGNpdHJpeC5j b20+DQpEYXRlOiBUdWUsIDI3IFNlcCAyMDIyIDE3OjA2OjU3ICswMTAwDQpTdWJqZWN0OiBbUEFU Q0hdIHRvb2xzL29jYW1sOiBmaXggY29tcGF0aWJpbGl0eSB3aXRoIE9DYW1sIDQuMDIuMw0KTUlN RS1WZXJzaW9uOiAxLjANCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA0K Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdA0KDQpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBU w7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KLS0tDQogdG9vbHMvb2NhbWwvbGlicy9t bWFwL21tYXBfc3R1YnMuaCB8IDUgKysrKysNCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspDQoNCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL21tYXAvbW1hcF9zdHVicy5oIGIv dG9vbHMvb2NhbWwvbGlicy9tbWFwL21tYXBfc3R1YnMuaA0KaW5kZXggNjVlNDIzOTg5MC4uNWM2 NWNjODZmYiAxMDA2NDQNCi0tLSBhL3Rvb2xzL29jYW1sL2xpYnMvbW1hcC9tbWFwX3N0dWJzLmgN CisrKyBiL3Rvb2xzL29jYW1sL2xpYnMvbW1hcC9tbWFwX3N0dWJzLmgNCkBAIC0zMCw0ICszMCw5 IEBAIHN0cnVjdCBtbWFwX2ludGVyZmFjZQ0KIAlpbnQgbGVuOw0KIH07DQoNCisvKiBmb3IgY29t cGF0aWJpbGl0eSB3aXRoIE9DYW1sIDQuMDIuMyAqLw0KKyNpZm5kZWYgRGF0YV9hYnN0cmFjdF92 YWwNCisjZGVmaW5lIERhdGFfYWJzdHJhY3RfdmFsKHYpICgodm9pZCopIE9wX3ZhbCh2KSkNCisj ZW5kaWYNCisNCiAjZW5kaWYNCi0tDQoyLjM0LjENCg0KPiBPbiAyNyBTZXAgMjAyMiwgYXQgMTI6 MTUsIEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4g Rm9sbG93IHRoZSBtYW51YWwgdG8gYXZvaWQgbmFrZWQgcG9pbnRlcnM6DQo+IGh0dHBzOi8vbmFt MDQuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9vay5jb20vP3VybD1odHRwcyUzQSUyRiUyRnYy Lm9jYW1sLm9yZyUyRm1hbnVhbCUyRmludGZjLmh0bWwlMjNzcyUzQWMtb3V0c2lkZS1oZWFkJmFt cDtkYXRhPTA1JTdDMDElN0NlZHZpbi50b3JvayU0MGNpdHJpeC5jb20lN0M0YmYyOGY3YTMyMDc0 YTQ5Y2RmMDA4ZGFhMDc5YTgwNyU3QzMzNTgzNmRlNDJlZjQzYTJiMTQ1MzQ4YzJlZTljYTViJTdD MCU3QzAlN0M2Mzc5OTg3NDE2MzQ2MjcxMDUlN0NVbmtub3duJTdDVFdGcGJHWnNiM2Q4ZXlKV0lq b2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxDSlhWQ0k2TW4w JTNEJTdDMzAwMCU3QyU3QyU3QyZhbXA7c2RhdGE9R1UlMkJibUIxYWkwbGxRZzB6NXpXY3R6d1cw b2NVUVVPSFZsTXhrZUQzVTBVJTNEJmFtcDtyZXNlcnZlZD0wDQo+IA0KPiBObyBmdW5jdGlvbmFs IGNoYW5nZSwgZXhjZXB0IG9uIE9DYW1sIDUuMCB3aGVyZSBpdCBpcyBhIGJ1Z2ZpeC4NCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQo+ IC0tLQ0KPiB0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyB8IDExICsrKysrKy0t LS0tDQo+IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+ IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMgYi90 b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPiBpbmRleCAxOTMzNWJkZjQ1Li43 ZmY0ZTAwMzE0IDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1 YnMuYw0KPiArKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPiBAQCAt MzcsNyArMzcsNyBAQA0KPiANCj4gI2luY2x1ZGUgIm1tYXBfc3R1YnMuaCINCj4gDQo+IC0jZGVm aW5lIF9IKF9faCkgKCh4Y19pbnRlcmZhY2UgKikoX19oKSkNCj4gKyNkZWZpbmUgX0goX19oKSAq KCh4Y19pbnRlcmZhY2UgKiopIERhdGFfYWJzdHJhY3RfdmFsKF9faCkpDQo+ICNkZWZpbmUgX0Qo X19kKSAoKHVpbnQzMl90KUludF92YWwoX19kKSkNCj4gDQo+ICNpZm5kZWYgVmFsX25vbmUNCj4g QEAgLTcwLDE0ICs3MCwxNSBAQCBzdGF0aWMgdm9pZCBOb3JldHVybiBmYWlsd2l0aF94Yyh4Y19p bnRlcmZhY2UgKnhjaCkNCj4gQ0FNTHByaW0gdmFsdWUgc3R1Yl94Y19pbnRlcmZhY2Vfb3Blbih2 b2lkKQ0KPiB7DQo+IAlDQU1McGFyYW0wKCk7DQo+IC0gICAgICAgIHhjX2ludGVyZmFjZSAqeGNo Ow0KPiArCUNBTUxsb2NhbDEocmVzdWx0KTsNCj4gDQo+ICsJcmVzdWx0ID0gY2FtbF9hbGxvYygx LCBBYnN0cmFjdF90YWcpOw0KPiAJLyogRG9uJ3QgYXNzZXJ0IFhDX09QRU5GTEFHX05PTl9SRUVO VFJBTlQgYmVjYXVzZSB0aGVzZSBiaW5kaW5ncw0KPiAJICogZG8gbm90IHByZXZlbnQgcmUtZW50 cmFuY3kgdG8gbGlieGMgKi8NCj4gLSAgICAgICAgeGNoID0geGNfaW50ZXJmYWNlX29wZW4oTlVM TCwgTlVMTCwgMCk7DQo+IC0gICAgICAgIGlmICh4Y2ggPT0gTlVMTCkNCj4gKwlfSChyZXN1bHQp ID0geGNfaW50ZXJmYWNlX29wZW4oTlVMTCwgTlVMTCwgMCk7DQo+ICsJaWYgKF9IKHJlc3VsdCkg PT0gTlVMTCkNCj4gCQlmYWlsd2l0aF94YyhOVUxMKTsNCj4gLSAgICAgICAgQ0FNTHJldHVybigo dmFsdWUpeGNoKTsNCj4gKwlDQU1McmV0dXJuKHJlc3VsdCk7DQo+IH0NCj4gDQo+IA0KPiAtLSAN Cj4gMi4zNC4xDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 27 16:20:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 16:20:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412834.656308 (Exim 4.92) (envelope-from ) id 1odDK7-00033z-A1; Tue, 27 Sep 2022 16:20:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412834.656308; Tue, 27 Sep 2022 16:20:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDK7-00033s-58; Tue, 27 Sep 2022 16:20:43 +0000 Received: by outflank-mailman (input) for mailman id 412834; Tue, 27 Sep 2022 16:20:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDK5-00033m-Tm for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 16:20:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53fe70c7-3e80-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 18:20:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7475.eurprd04.prod.outlook.com (2603:10a6:20b:1d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 27 Sep 2022 16:20:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 16:20:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53fe70c7-3e80-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwSjnMmWzlFYE1uyqgmhxailnwwf0bXm3l+o6stM8IUokyaTCWbdM7VJTzCnZbScGiIQw5YwjrLln4qGVQt1czE2D4ewTwl4tji/tCnzp9JPqrYgHN05LM1dneErKHKAZXiiapmAa7QnpypXg3Mec97rs4QsidJpK2g1dxD5hssgG/yf6jcoVZiuHOg1OcgqOBJYxx7gRTQk+6k0qxmfAIdrV9C4YnwnzAduIbaKR18rEHvNpCDuVAn+BFpSUohTB89eXg7zcCvcpivq3cu5wFltGQIDxyDJ+VU+TFt2v4fKM+aEqJlCxaBEczavtkfk4O0i3Rz5jN83ZYxiwDVkwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xl2C6p9PWbUD9e4TXc1jSPxAzi12PvEP2PHorAUQ7xw=; b=JDKhCNe5oQ3SL/dQoc8+PhGajadutM/FwrhdYyeFnrjOhWYw/x15h59EuQ3VCc61ZVEVkTtH/IpP2Y/zZ8kItdF4jf9nFiIpirnPvrBv7iIlYcTta+E5cnOBZ0n3nHtkUL6bqKLHazBVvwGMqlMwj+TwJ6BbvsCUXis4CfNWH8h031P8FcO+AYJIZbsRWbBRxPqrfskMhNM+AuzkWLP9b9Hw6cbZmc+SH58kNU1n3owVPmO0Prikowsi44b8ExliMoYoy/HORYHucmHKlRnjlpVxTcxPBIwZ0tp1ExRswz5yBPjADsfTRC4n+9k56jaNN4yojA27LOWE1Ocj/8zvvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xl2C6p9PWbUD9e4TXc1jSPxAzi12PvEP2PHorAUQ7xw=; b=aYcWfYU7chvJIXAwE8E1UMB5YWydRycB6ZGCAp8Pac/4smLNHKIl+GX49OpgUmlI2DgecCQ8q4w43T9qUFzhlH3XWePLi+B8p2DTtk57+uiadGLtSqdNEURZsm1D+P3uFycRGSHRG8zBFBtpvWuZUyqkoCHaP32vxNjDIUIJoCcrqBwWdyevC/TsgJQYGr9jU/6v8qBoDwmEyuq7ygeN1/qBHxbWAuHSN0W1SEMK711mtXt0VqWkd3HLQ24HvNU9AqjNs77zIvp+8a+oV1qdO0A3YI6wYvSIXfCVJZIHtMYlq85WT3lVSxJAbzf9zHQFYCMr1De63Vz6t4URZvVLFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> Date: Tue, 27 Sep 2022 18:20:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0051.eurprd07.prod.outlook.com (2603:10a6:20b:46b::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: cf2d697f-bfea-42b4-de2a-08daa0a4377e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZgByzwk1wQz7XO7LThLU5XZBhGnr05dC7BJpeh1sJ0t01mHNEz61hIQYCTjPDtPhJhB2OOGijnjxE4nBUPFKOYMiPIb2Wh6fQDG4dxdf8B2kp92CSGYbwh4O2N0MDtHmbVZmE45y0mVM0BiHysY4i2UqVpbhVpHWn8cSRxvep9bUjlmRuglwWjz2XEtUrwP61E5jqM4I8WkQozN+CjYDl3aaW7/stk+vR69/aUxyb1Yjor1VchkJOqjDXmhaHYef0TJ5sVa/TV2qw7qAjUiDzAOgke0GTNUaVs1J1hu/qe+poZ1KVYRsa3t5xd+HsMerRsbVIdb534NBYY8jv7cvSKgQz255beUbgjPKR2Z7Pffyk1Dp/dy0sB11J4k74YIKALBworEulIrhFDi+tsaFRrcn5bzZ4jRfzKdHQsi8DKixiWwIZQHdGeVs+AqC7ZkzMCYzdhmt/gWqnYTpHbfQbg9le/ECJxQbMW3XRsSCSPMXhE731qBte2/qDI6FD/GxJ886Oa1xEruRrumtoLhkLjKogKxGSXnTeT0q0/bZ3lbW7SrbWjUt5hDFCgi2853s/VL+vcWNRTvATTT0bCLYgdVEodSOFkAD9hpNDx1sONwN1zypbbjieSS/I9I5pyo8R883XR8IUrPZihLImjEbR21H43arhRdFsE5SIe0KJmfAa+xa8VY0+PUxhddQCG1YiDhHMBExSX6BDf0gZpB2ihyABA8tldXoyFT5CDzdP+0QwBu7b1e75bf+SVZcp9pEE6exKsDCUl/AUG5v95aQxQFWRYntvhzSZpw1TqmGGI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199015)(8936002)(54906003)(66946007)(38100700002)(86362001)(31696002)(8676002)(5660300002)(66556008)(6916009)(2906002)(478600001)(6506007)(26005)(66476007)(41300700001)(6512007)(6486002)(316002)(2616005)(83380400001)(4326008)(6666004)(186003)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WU5UYTEvaWdBdmtqL3JDd00yaHN0aFFnME83OVcyRlJtK1plQXl4U3VxOHM0?= =?utf-8?B?RnVDRDRSdDdJa05icVZVRlQvbzl5Z2dLWjRtNnRveW4rSERCKzRnTkM0K2tB?= =?utf-8?B?TlkxRXQ3b0MxRlBhZEYzWldDeUJ0RFVyZEhQMDFjQk0zaE1iemx6WEtZdndm?= =?utf-8?B?OWRFL2hKazRZc3NialR2Zk1xdWFQbmhZYU1QdUVnYWNVNDRZWXB6YUNYOTdV?= =?utf-8?B?b0NWRmU0Z0FiZmYxNkpJT2ZuTG51VWNYM1NLWGVid290cE04WUlieFFDMHI2?= =?utf-8?B?ZE5CdkxhQlNNdFg3WjJpRkZyeWROS2ltZmhrNmQyUVVUQXJKdzN0eUxLM2Iz?= =?utf-8?B?bFhvbUhXQXFvWXpGU1RzbncxRGdBSkVSWEVjSWJEQXJqZ1lDeE5GY2hqb3F6?= =?utf-8?B?S0tUc3hEdm04eEFMdUZSY093dmRMd29obW1RUU1mZGwxLzhUaEFhY3IyQmN2?= =?utf-8?B?TzRKVXdvOUNlaXgzM282d1VUV3VSQldOZWpLbzNVcHlPL2JXQ2dtTDV3amMv?= =?utf-8?B?Y0F1b05vQ0tuNmFIb01CcktteWxqSTdOL1FpN0FIY3lQbkdQMXFxKzNRT094?= =?utf-8?B?RzFlanpRS1FPNS9zbnNwR2tPRE5vMG1iQ3F6aStuV0tLQmJYb0JQWlpTQk9H?= =?utf-8?B?cjRMQTI4TlgzN0krUzdZL2NRQU42SGQvRDNtWXYvNUJJR3I4QXJJVnd3RWpI?= =?utf-8?B?UXhqVzF2RDl5ZFBGc25BL3BkY0NyVXpCNXBsVlNKQVBBVXZhVnd6aGlsQk43?= =?utf-8?B?MFdtRHR1c1Vldjl3R1M3UklFWFgwZjI0ZWJaQm1NVGtRNlhJWlVJdDdKRSta?= =?utf-8?B?UWJxM0R0ZDgvcTBDZ29HdFI3WjJSK0xiWHc2ZUJFZ3BCOTNTSFBUQUsxNTVG?= =?utf-8?B?M0N2NjRDR0hyejVOYnV1R2c4dDJjZk9VMSswRlJDMVRTZXN3S2hLQ1hJUFdn?= =?utf-8?B?ODViSkF1ajVJVTE2MzhiZGppTk5ocWE4TkJ4UkxJMkZLMFJiSyttOXFIYWs5?= =?utf-8?B?bDQ1aUhxOE5Vb3JmQkkzVUZVUk1OS1NteDdXdk9uN3lCMmZIanEzZ2RFQ0t4?= =?utf-8?B?dzlReXZCREdiN0FqdjBTMllVbElQQVBQc0tPR21RTGdEVlNqSFYxNktIMmVk?= =?utf-8?B?eElpY0RlNkxVbkxBMTQxZ2hKQjAwQXNkWkxUaFpITS9TZ1JEWmxMM3pmNUZy?= =?utf-8?B?VzcvQlVKSlF6dEl2RHl6bWRMZjRLQjRBNmljNlhiSkpmb2l4eUdmZUpyRmtX?= =?utf-8?B?bk5GZVRGNjBuaHJFajIxdHd1Z0FyUjZCdFo5NXhnSmlIZ0J5ZE5ZYkZEYnZ4?= =?utf-8?B?cmRMN2lESlB2UFpLZUhCNU5jS3lPc1FZS1dUczBuV1MrSUZnTnhMU1ZEWkhV?= =?utf-8?B?cWluS1lZWXFMekx2SVJBSjFoQ1hialo4akpKMmpaUCt6R1p0eU11cm1WeHBW?= =?utf-8?B?MUU2dngvb3FrNlgxN3J5SkduLzlHU1pOVjN4L2diSGhtTnAwbHlNVld3NXNi?= =?utf-8?B?R1k5bkhPekJQeGV0Q20wM2NZL01yTmorY1ZIZXkxVjVmWU5WcHlUMVYxeWdE?= =?utf-8?B?OHFLR2lOc3hYTmxYYUd3SkhrZjlYdkY5Y0ZtblBNb1hoZWMva3MwNHFYTS85?= =?utf-8?B?NjQwVjBjcmkvYVdaVEwzdC95Z3FiOXM5Q2RiZ0NQN3EzS3hWMjhZMEJFYklM?= =?utf-8?B?YWFVWVZKOE9Oa205UTZKTTJxM1dYc0hqYnIxTmhqTUIrcXdPS3FTdzd3SC92?= =?utf-8?B?dE5OYlluTGx2ME5MdDdJQlljUG1BQ0huZHpIR2QwVmZQL0s2U1RQbDFINmRQ?= =?utf-8?B?OW5kUDNiRnV3ZjFhUjZSL0RLeE9EYUMrZ0JsNGszMk9iQ2RhMll4OE1vc3ZW?= =?utf-8?B?UTRUd1JJdUdWSlAzY0lEVlNDVmZRa1ZwRFpHTW1GV0tWK0JuVnJoZmIvVFJw?= =?utf-8?B?U1RDcEZ1emFyZG9tMHRQK2lsdy96SkRBc1AwcXFsdVg1bTAyanlVdHVLaHJm?= =?utf-8?B?RVQ2Y0hXTVV0aXZ2bUdUMXFNSG14Rkc1V3Uzbzd2ZmZzNWhqM3YzL21iVUo5?= =?utf-8?B?MVVKMlcvTDliaS9US0lTSU9jR250dGt0Qm1lY2g5MStoVjdDeFV0aEJCTXg5?= =?utf-8?Q?BB93ToG9pKW0whWOOJpg2/APv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf2d697f-bfea-42b4-de2a-08daa0a4377e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 16:20:39.3269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yYuhISNwlyPDygAt6Tf2VyPi24kPbyZnDuGmJk78D1WE8ohiS6s977PfGU2PhicShg70x/bWz4uAJsgl/+DTfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7475 SRAT may describe individual nodes using multiple ranges. When they're adjacent (with or without a gap in between), only the start of the first such range actually needs accounting for. Furthermore the very first range doesn't need considering of its start address at all, as it's fine to associate all lower addresses (with no memory) with that same node. For this to work, the array of ranges needs to be sorted by address - adjust logic accordingly in acpi_numa_memory_affinity_init(). Signed-off-by: Jan Beulich --- On my Dinar and Rome systems this changes memnodemapsize to a single page. Originally they used 9 / 130 pages (with shifts going from 8 / 6 to 15 / 16) respectively, resulting from lowmem gaps [A0,FF] / [A0,BF]. This goes on top of "x86/NUMA: correct memnode_shift calculation for single node system". --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -127,7 +127,8 @@ static int __init extract_lsb_from_nodes epdx = paddr_to_pdx(nodes[i].end - 1) + 1; if ( spdx >= epdx ) continue; - bitfield |= spdx; + if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) ) + bitfield |= spdx; if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] ) nodes_used++; if ( epdx > memtop ) --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -312,6 +312,7 @@ acpi_numa_memory_affinity_init(const str unsigned pxm; nodeid_t node; unsigned int i; + bool next = false; if (srat_disabled()) return; @@ -413,14 +414,37 @@ acpi_numa_memory_affinity_init(const str node, pxm, start, end - 1, ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); - node_memblk_range[num_node_memblks].start = start; - node_memblk_range[num_node_memblks].end = end; - memblk_nodeid[num_node_memblks] = node; + /* Keep node_memblk_range[] sorted by address. */ + for (i = 0; i < num_node_memblks; ++i) + if (node_memblk_range[i].start > start || + (node_memblk_range[i].start == start && + node_memblk_range[i].end > end)) + break; + + memmove(&node_memblk_range[i + 1], &node_memblk_range[i], + (num_node_memblks - i) * sizeof(*node_memblk_range)); + node_memblk_range[i].start = start; + node_memblk_range[i].end = end; + + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], + (num_node_memblks - i) * sizeof(*memblk_nodeid)); + memblk_nodeid[i] = node; + if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { - __set_bit(num_node_memblks, memblk_hotplug); + next = true; if (end > mem_hotplug) mem_hotplug = end; } + for (; i <= num_node_memblks; ++i) { + bool prev = next; + + next = test_bit(i, memblk_hotplug); + if (prev) + __set_bit(i, memblk_hotplug); + else + __clear_bit(i, memblk_hotplug); + } + num_node_memblks++; } From xen-devel-bounces@lists.xenproject.org Tue Sep 27 16:30:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 16:30:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412843.656318 (Exim 4.92) (envelope-from ) id 1odDTL-0004dU-B5; Tue, 27 Sep 2022 16:30:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412843.656318; Tue, 27 Sep 2022 16:30:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDTL-0004dN-7l; Tue, 27 Sep 2022 16:30:15 +0000 Received: by outflank-mailman (input) for mailman id 412843; Tue, 27 Sep 2022 16:30:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDTK-0004dD-2o; Tue, 27 Sep 2022 16:30:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDTJ-00075R-Qq; Tue, 27 Sep 2022 16:30:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odDTJ-0005b0-GD; Tue, 27 Sep 2022 16:30:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odDTJ-0005Kk-FX; Tue, 27 Sep 2022 16:30:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i5fNrMNGx2jsB5rMpThty234cpypQsF4XvD/XuVmssc=; b=4uychD/xV2OUA5s6FFQDcYgfw4 vEWZuuO1dlwiI6E6HhlRnREggJG3NQgou7Kod9H4fE4ZPRw26MJKDH/TthgGzqqrtHpJP4QZFlYVZ 7Aq3O1NolcRqjozH4IBBxq544EX0AMKfAi8kCavSGYEDg+v4s627airDNK6L79W0SEw4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173333: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5e936d11b171793c174686268c9c1df8a4fa974c X-Osstest-Versions-That: xen=bd68a5f397537eb7ba6223546c1f4d47f078d3b2 From: osstest service owner Date: Tue, 27 Sep 2022 16:30:13 +0000 flight 173333 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173333/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 5e936d11b171793c174686268c9c1df8a4fa974c baseline version: xen bd68a5f397537eb7ba6223546c1f4d47f078d3b2 Last test of basis 173320 2022-09-26 23:01:58 Z 0 days Testing same since 173333 2022-09-27 13:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bd68a5f397..5e936d11b1 5e936d11b171793c174686268c9c1df8a4fa974c -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 27 17:17:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 17:17:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412892.656346 (Exim 4.92) (envelope-from ) id 1odED7-0001l3-9R; Tue, 27 Sep 2022 17:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412892.656346; Tue, 27 Sep 2022 17:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odED7-0001kw-6j; Tue, 27 Sep 2022 17:17:33 +0000 Received: by outflank-mailman (input) for mailman id 412892; Tue, 27 Sep 2022 17:17:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odED6-0001kq-QN for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 17:17:32 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4511fb45-3e88-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 19:17:31 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id cc5so16004474wrb.6 for ; Tue, 27 Sep 2022 10:17:31 -0700 (PDT) Received: from [192.168.8.100] (94.196.228.157.threembb.co.uk. [94.196.228.157]) by smtp.gmail.com with ESMTPSA id b5-20020a05600c4e0500b003b339438733sm2507299wmq.19.2022.09.27.10.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 10:17:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4511fb45-3e88-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=gFJ/H+N6WAC6t6IyMR0gZxkOzHl2iN3HsUIPG8f/u4I=; b=L4/iTXFz7DuL5Uib4WIGjsIg0VrC7CXY9Nc3a6NaRVNsHglXDiLDyualTpBH2xBe4C NbHbXeBPxgHCg2zjPKSLOPE0Sx+LhUwzz7pp0Dp9YLLALpGgQYqFsEWeP2nObb9r3A0J JN/YeMF4UbQx3cskpQj0nbelj2yYEjpZlCyEanouYFiW5VOoN/SAc4hjNz4N1X/nUq2g TRifOA+0L3tNFcxDdUJASxezuirH17L9jRkrcMn1ujmRvAXJRQhZi6ik68pDy9zmmuCL fBixtkxBQPhzk0/an7ggX0q/eDguyIMRuNBjlWGO9qW19gRk00YQ540+09bEN/R85APk z8Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=gFJ/H+N6WAC6t6IyMR0gZxkOzHl2iN3HsUIPG8f/u4I=; b=XULXXR9rZhs5sI3VvchOnQvAOt29Pj5leqrE4D1Lc3fGM+Q1VBsddFF6vRTue15iIU 3TJUdA+IKBOpVfrNRPDIlUZOLnuk/oulxWraz1G8rKrnKKAgl/fZ2Acd9mHd+6njJFtu NBTdH5WTtQsMT/MVvbNVRa9ARTO5qvM6ORPiTNogqhlWRUc74nBnyfXOTb1OYRF5sr5K oStap2Lg5gsiX7J6M4QXXUvAuAlI5vy04hZ1aPljo38qpaZKfMUJbf6Sr3UFBSzsI+Hs 9Z0MB7BKG0ET3zsvvMTD+wMYoasmEMmtSNfU1TvammjAYE8OqUv7RJ39CECpXWkh+HRJ ZjGg== X-Gm-Message-State: ACrzQf3eKp1z9PAJvskXLkEoRUkc+VURHLissevgRyBZalLrHQwwj7+0 Gp484CAmKx0p/W7Hgn12Bck= X-Google-Smtp-Source: AMsMyM4RKN4LBXcpsUki/a4beJoIwOEKU0REj/xTHR6CD5uBK9Mb1sJXwhpfSrm7yyiPg6HtYG8mfw== X-Received: by 2002:adf:fa08:0:b0:228:c246:2a4b with SMTP id m8-20020adffa08000000b00228c2462a4bmr16991498wrr.630.1664299050980; Tue, 27 Sep 2022 10:17:30 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 18:16:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info Content-Language: en-US From: Pavel Begunkov To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> In-Reply-To: <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/27/22 15:28, Pavel Begunkov wrote: > Hello Paolo, > > On 9/27/22 14:49, Paolo Abeni wrote: >> Hello, >> >> On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: >>> struct ubuf_info is large but not all fields are needed for all >>> cases. We have limited space in io_uring for it and large ubuf_info >>> prevents some struct embedding, even though we use only a subset >>> of the fields. It's also not very clean trying to use this typeless >>> extra space. >>> >>> Shrink struct ubuf_info to only necessary fields used in generic paths, >>> namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And >>> make MSG_ZEROCOPY and some other users to embed it into a larger struct >>> ubuf_info_msgzc mimicking the former ubuf_info. >>> >>> Note, xen/vhost may also have some cleaning on top by creating >>> new structs containing ubuf_info but with proper types. >> >> That sounds a bit scaring to me. If I read correctly, every uarg user >> should check 'uarg->callback == msg_zerocopy_callback' before accessing >> any 'extend' fields. > > Providers of ubuf_info access those fields via callbacks and so already > know the actual structure used. The net core, on the opposite, should > keep it encapsulated and not touch them at all. > > The series lists all places where we use extended fields just on the > merit of stripping the structure of those fields and successfully > building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which > again uses callbacks. > > Sounds like the right direction for me. There is a couple of > places where it might get type safer, i.e. adding types instead > of void* in for struct tun_msg_ctl and getting rid of one macro > hiding types in xen. But seems more like TODO for later. > >> AFAICS the current code sometimes don't do the >> explicit test because the condition is somewhat implied, which in turn >> is quite hard to track. >> >> clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected >> before this series, and after will trigger an oops.. > > And now we don't have this field at all to access, considering that > nobody blindly casts it. > >> There is some noise due to uarg -> uarg_zc renaming which make the >> series harder to review. Have you considered instead keeping the old >> name and introducing a smaller 'struct ubuf_info_common'? the overall >> code should be mostly the same, but it will avoid the above mentioned >> noise. > > I don't think there will be less noise this way, but let me try > and see if I can get rid of some churn. It doesn't look any better for me TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY and doesn't touch core code. If we do ubuf_info_common though I'd need to convert lots of places in skbuff.c and multiple places across tcp/udp, which is much worse. And then I'd still need to touch all users to do ubuf_info -> ubuf_info_common conversion and all in a single commit to not break build. If it's about naming, I can add a tree-wide renaming patch on top. Paolo, I'd appreciate if you let know whether you're fine with it or not, I don't want the series to get stuck. For bug concerns, all places touching those optional fields are converted to ubuf_info_msgzc, and I wouldn't say 4/4 is so bad. -- Pavel Begunkov From xen-devel-bounces@lists.xenproject.org Tue Sep 27 17:21:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 17:21:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412897.656357 (Exim 4.92) (envelope-from ) id 1odEGZ-00039Q-O8; Tue, 27 Sep 2022 17:21:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412897.656357; Tue, 27 Sep 2022 17:21:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odEGZ-00039J-La; Tue, 27 Sep 2022 17:21:07 +0000 Received: by outflank-mailman (input) for mailman id 412897; Tue, 27 Sep 2022 17:21:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odEGZ-00039A-2m for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 17:21:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1f92430-3e88-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 19:21:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1f92430-3e88-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664299262; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iO4qwHzOfI2N25EDvltRySpbetX8kQ1Q0zmpmfLD0P4=; b=Co8BmQFJahSeQvJiRer8lr4flCiNz1nkTfnxLBIdU+C3CqKVmMOTWn8H Z4tVPoP9U3Jbv4BNtQiQSdQtXlOh6bhTrIW7flffhqAEzURPuMij76OgC Yu3m0J4srW+jl47l+u/DrIg+L+COi8sYkfUFa59gnUzhuLsmUnN7A+jJq Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83977139 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:G0B0fq4z8TRMSwbgU8bCVQxRtK/HchMFZxGqfqrLsTDasY5as4F+v mAYD2zTbP7Yamv9Kt4kb4Sxp0pUsMDWzdNnHQo4pHs1Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPYwP9TlK6q4mlA7wZhPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5cOlBP3 vsENQshRR/S3Oi4z6CGcPJj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozRFJoKxx3Jz o7A1z7kOS0nLuKG8x6c6UiWj7DpnnzHUqtHQdVU8dY12QbOlwT/EiY+WV6qveO+vVWzXt9ZJ lAP0ic2pK10/0uuJvH/UAe/u2WspQMHVpxbFOhSwB+Kzq3Y8gOIHF8ORzRKaMElnMIuTDls3 ViM9/vgAzV0rLSOSHOUwbOJrjK7PyUTLmgqaDcNSE0O5NyLiJE+iFfDQ8huFIaxj8bpAnfgz jaSti88ir4Py8kR2M2T8VXGnyi94IPESwMz6xnMdm2g5wJ9IoWiYuSA9lzz/ftGaoGDQTGpu 3wJmNOX6uwUOpiLmDaQW+UGHLyv5PGtPSXVhBhkGJxJyti20yf9J8YKumg4fRo3dJZfEdP0X KPNkShq1Z54O2e3VoNcbNPqAcol35XaDtuwA5g4ceFySpR2cQaG+gRnakiRw33hnSAQrE0vB XuIWZ3yVChHUMyL2BLzHr5AiuFzmkjS0EuJHfjGIwKbPa1yjZJ/YZMMKxOwY+8w98toSy2Fo o8EZ6NmJ/iyOdASgxU7E6ZJdTjmzlBhX/gaTvC7kcbcSjeK4El7V5fsLUoJIuSJZZh9mObS5 W2aUURF0lf5jnCvAVzUNCw5MeyyDMYu9SNT0ckQ0bGAhBAejXuHtv9DJ/Pbg5F+nACc8RKEZ 6ZcIJjRahi+Yj/G5y4cffHAkWCWTzzy3FrmAsZQSGJgF3KWb1CWp4SMk8qG3HVmMxdbQuNk/ eD+j1mLHcddL+mgZe6PAM+SI5qKlSB1sIpPs4Hge7G/pG2EHFBWFhHM IronPort-HdrOrdr: A9a23:lnlzbaBRPEOGGovlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.93,350,1654574400"; d="scan'208";a="83977139" Date: Tue, 27 Sep 2022 18:20:50 +0100 From: Anthony PERARD To: CC: , Oleksandr Andrushchenko , Wei Liu , Juergen Gross , Dmytro Semenets , Anastasiia Lukianenko , Volodymyr Babchuk Subject: Re: [PATCH v2 4/4] tools/xl: Add pcid daemon to xl Message-ID: References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> <20220713150311.4152528-4-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220713150311.4152528-4-dmitry.semenets@gmail.com> On Wed, Jul 13, 2022 at 06:03:11PM +0300, dmitry.semenets@gmail.com wrote: > From: Oleksandr Andrushchenko > > Add pcid daemon (based on vchan-node2) implements pcid protocol. Protocol is > OS independed and should work on ane supported OS. > > Add essential functionality to handle pcid protocol: > - define required constants > - prepare for handling remote requests > - prepare and send an error packet > > pcid server used if domain has passthrough PCI controller and we wants > assign some device to other domain. > pcid server should be launched in domain owns the PCI controller and process > request from other domains. > > Message exchange imnplementation based on JSON via libvchan. Supported > messages: > - make_assignable > - revert_assignable > - is_device_assigned > - resource_list > - reset_device > - write_bdf > > Signed-off-by: Dmytro Semenets > Signed-off-by: Oleksandr Andrushchenko > Signed-off-by: Anastasiia Lukianenko > Signed-off-by: Volodymyr Babchuk Hi Dmitry, I don't think libxl is the right place to implement a daemon, and xl isn't the place to start a new daemon either. Could you look into creating a new binary which implements only "pcid"? I understand that making use of the facilities in libxl makes writing this daemon a bit easier, but still I don't think the code belong to libxl. Maybe some of libxl's code could be moved to libxlu (utils) if that help, but I'm not sure. Also, this patch is way to big, makes too many changes, including changes to existing libxl's API which we try to avoid. (Adding new functions is fine, changing the prototype of existing one is what we try to avoid.) As for the protocol, it might be better to have the description somewhere in "docs/" instead of within a C header. I'm not sure which sub-directory as we have protocols in different one, like in "misc" or "design" or "features", but "misc" might be the one. Also, the document should say somewhere that the protocol is based on JSON, as that's missing in pcid.h. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 27 17:56:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 17:56:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412904.656368 (Exim 4.92) (envelope-from ) id 1odEoY-0006fP-DR; Tue, 27 Sep 2022 17:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412904.656368; Tue, 27 Sep 2022 17:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odEoY-0006fI-Ak; Tue, 27 Sep 2022 17:56:14 +0000 Received: by outflank-mailman (input) for mailman id 412904; Tue, 27 Sep 2022 17:56:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odEoW-0006fC-M2 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 17:56:13 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa45fde1-3e8d-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 19:56:09 +0200 (CEST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-256-j-9IhWcAMWGjMV6zqhwU-w-1; Tue, 27 Sep 2022 13:56:07 -0400 Received: by mail-wm1-f71.google.com with SMTP id n32-20020a05600c3ba000b003b5054c71faso8476983wms.9 for ; Tue, 27 Sep 2022 10:56:06 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-104-40.dyn.eolo.it. [146.241.104.40]) by smtp.gmail.com with ESMTPSA id i24-20020a1c5418000000b003a601a1c2f7sm15224452wmb.19.2022.09.27.10.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 10:56:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa45fde1-3e8d-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664301368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ylam0E0Yl8o7oIuCiSoTBfRDDfyFUS+FtVqqi8D5J/k=; b=C0MOHD62umI44M+FuCUIUujaCYv+tZZpHZTmPvmBD0Kh5RNnX5DeCg6YILNOC6+Xr/mxtv O7ZFFafdS3mgkuPm7JDj6DXv1vrrb2zLHSeEUAYFaNyv9A4gI1Qfog7sp3VGyHcpCVE+0l Uq16NKKe3ypuL1fYQtoWuN3H5pdc27U= X-MC-Unique: j-9IhWcAMWGjMV6zqhwU-w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=ylam0E0Yl8o7oIuCiSoTBfRDDfyFUS+FtVqqi8D5J/k=; b=CPQ02u1gFfeT84aTniA3cUZDABCIttLVPyFzutQONfAput4JHwpCTsiUlT1YqfRb53 /NLoblhRbenPvuElr1bPyM0xGaiVfC7b9s0QMUvFPKYpfYAXZ0fjCSgUmJz5H6m8lE8a /88GVLMxX1Lnoz2zbGx9rfIHDD71QhwPc91bU5bbmkIIQqKmn/lFjPac0tXrAGAYxctN HVHQ384Sj1hfR06NArz8WBx4N3dA6seytc5g1NNaENuhATppy740R0txKAbeiZod6BHx O2ZwWtKssoWsc9c8v/a0qcVrHiR6TrKCzEoAyzq+FuWfeJgc82VbivyoIg6sxSUiZ9l5 nQLg== X-Gm-Message-State: ACrzQf0tAU3TXMB+noBz4eBo5LJJbgzEKp4CcjpOgFbR/nyUxffWjQTE PzHqQ4zFDSt1HnA7jLmWbtfVJfdAXzQy2onmNrW4wtOkYNRRO7DiKzk+EULq4wsaM53f/rsIqVX xBEZ7MUWOo2cT32ahSInzQpxAyyI= X-Received: by 2002:a05:600c:1906:b0:3b4:c979:e639 with SMTP id j6-20020a05600c190600b003b4c979e639mr3579340wmq.10.1664301366039; Tue, 27 Sep 2022 10:56:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7FqAzRoJe8tYb81tymnL2G1w/i5A9eSO1xA6YLlCwZrMepZTryND4cUgsUZdpNmVpZgnJ9bg== X-Received: by 2002:a05:600c:1906:b0:3b4:c979:e639 with SMTP id j6-20020a05600c190600b003b4c979e639mr3579316wmq.10.1664301365775; Tue, 27 Sep 2022 10:56:05 -0700 (PDT) Message-ID: <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info From: Paolo Abeni To: Pavel Begunkov , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang Date: Tue, 27 Sep 2022 19:56:04 +0200 In-Reply-To: References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: > On 9/27/22 15:28, Pavel Begunkov wrote: > > Hello Paolo, > > > > On 9/27/22 14:49, Paolo Abeni wrote: > > > Hello, > > > > > > On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: > > > > struct ubuf_info is large but not all fields are needed for all > > > > cases. We have limited space in io_uring for it and large ubuf_info > > > > prevents some struct embedding, even though we use only a subset > > > > of the fields. It's also not very clean trying to use this typeless > > > > extra space. > > > > > > > > Shrink struct ubuf_info to only necessary fields used in generic paths, > > > > namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And > > > > make MSG_ZEROCOPY and some other users to embed it into a larger struct > > > > ubuf_info_msgzc mimicking the former ubuf_info. > > > > > > > > Note, xen/vhost may also have some cleaning on top by creating > > > > new structs containing ubuf_info but with proper types. > > > > > > That sounds a bit scaring to me. If I read correctly, every uarg user > > > should check 'uarg->callback == msg_zerocopy_callback' before accessing > > > any 'extend' fields. > > > > Providers of ubuf_info access those fields via callbacks and so already > > know the actual structure used. The net core, on the opposite, should > > keep it encapsulated and not touch them at all. > > > > The series lists all places where we use extended fields just on the > > merit of stripping the structure of those fields and successfully > > building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which > > again uses callbacks. > > > > Sounds like the right direction for me. There is a couple of > > places where it might get type safer, i.e. adding types instead > > of void* in for struct tun_msg_ctl and getting rid of one macro > > hiding types in xen. But seems more like TODO for later. > > > > > AFAICS the current code sometimes don't do the > > > explicit test because the condition is somewhat implied, which in turn > > > is quite hard to track. > > > > > > clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected > > > before this series, and after will trigger an oops.. > > > > And now we don't have this field at all to access, considering that > > nobody blindly casts it. > > > > > There is some noise due to uarg -> uarg_zc renaming which make the > > > series harder to review. Have you considered instead keeping the old > > > name and introducing a smaller 'struct ubuf_info_common'? the overall > > > code should be mostly the same, but it will avoid the above mentioned > > > noise. > > > > I don't think there will be less noise this way, but let me try > > and see if I can get rid of some churn. > > It doesn't look any better for me > > TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY > and doesn't touch core code. If we do ubuf_info_common though I'd need > to convert lots of places in skbuff.c and multiple places across > tcp/udp, which is much worse.  Uhmm... I underlook the fact we must preserve the current accessors for the common fields. I guess something like the following could do (completely untested, hopefully should illustrate the idea): struct ubuf_info { struct_group_tagged(ubuf_info_common, common, void (*callback)(struct sk_buff *, struct ubuf_info *, bool zerocopy_success); refcount_t refcnt; u8 flags; ); union { struct { unsigned long desc; void *ctx; }; struct { u32 id; u16 len; u16 zerocopy:1; u32 bytelen; }; }; struct mmpin { struct user_struct *user; unsigned int num_pg; } mmp; }; Then you should be able to: - access ubuf_info->callback,  - access the same field via ubuf_info->common.callback - declare variables as 'struct ubuf_info_commom' with appropriate contents. WDYT? Thanks, Paolo From xen-devel-bounces@lists.xenproject.org Tue Sep 27 18:13:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 18:13:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412913.656384 (Exim 4.92) (envelope-from ) id 1odF4v-0000k5-SM; Tue, 27 Sep 2022 18:13:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412913.656384; Tue, 27 Sep 2022 18:13:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odF4v-0000jy-P3; Tue, 27 Sep 2022 18:13:09 +0000 Received: by outflank-mailman (input) for mailman id 412913; Tue, 27 Sep 2022 18:13:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odF4u-0000jo-Ke; Tue, 27 Sep 2022 18:13:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odF4u-0000ad-I0; Tue, 27 Sep 2022 18:13:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odF4u-00021w-16; Tue, 27 Sep 2022 18:13:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odF4u-0008IR-0d; Tue, 27 Sep 2022 18:13:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OtDAbimNz0YGfg++q1Y4Zhd3CFgBSiiTKZ0xckLx0Ks=; b=4As9TxK+IkAiyiwXsKk7ghchmr elja3VyOlKzm19pntNMWZIu2us2jp89O3uq1kPCa0jkoDXKCOjjSs6YvvnrUOSOOiOWHs3hQ7RmtR NibKYUHlpNJKXFLzgxNlWsG+i/zwqxZBTUXrBCney8T6CH7zDGfgrLH5m6At6X6dw2rY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173327: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bd68a5f397537eb7ba6223546c1f4d47f078d3b2 X-Osstest-Versions-That: xen=bfd3e9945d1bc551ad11272c7fa752ff3d060149 From: osstest service owner Date: Tue, 27 Sep 2022 18:13:08 +0000 flight 173327 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173327/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173322 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173322 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173322 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173322 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173322 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173322 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173322 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173322 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173322 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173322 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173322 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173322 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen bd68a5f397537eb7ba6223546c1f4d47f078d3b2 baseline version: xen bfd3e9945d1bc551ad11272c7fa752ff3d060149 Last test of basis 173322 2022-09-27 01:53:14 Z 0 days Testing same since 173327 2022-09-27 08:40:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bfd3e9945d..bd68a5f397 bd68a5f397537eb7ba6223546c1f4d47f078d3b2 -> master From xen-devel-bounces@lists.xenproject.org Tue Sep 27 18:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 18:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412923.656394 (Exim 4.92) (envelope-from ) id 1odF92-0001T6-Fp; Tue, 27 Sep 2022 18:17:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412923.656394; Tue, 27 Sep 2022 18:17:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odF92-0001Sz-DH; Tue, 27 Sep 2022 18:17:24 +0000 Received: by outflank-mailman (input) for mailman id 412923; Tue, 27 Sep 2022 18:17:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odF90-0001St-Dx for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 18:17:22 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0c4e4f1-3e90-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 20:17:21 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id l14so22424917eja.7 for ; Tue, 27 Sep 2022 11:17:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0c4e4f1-3e90-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=0R5nC5NCJpjjrmOChJBMhgB1HMUIeGH06lkH4LeIZqo=; b=olFC5tpgG45V99LdL/oKNCKy0WUadcLeiWvtIgjRnX526STkaRNuoqKwHcA0W3rWJQ zSiYzvr29mJ/WwkgmsmMK2MHCPJHeDUznVuoN8IXU07tAJBsaSWuRRtXhbvWF0y1sHzx AHjGTdBlr66EdPjbLbevP9YlcKyFB0yJg0n+/9IqtNLf2g/x4qxHDRwmvRiuiDpMylRu RCsEbGkJBCWWfyetpeBotM4TkSSRX40lRwwQneFVvvI2boACnU1ECm1L821IgAiX45Vt xob1Q5aSKJFbvraBGVcb64SUM4dXxAP85QM/nLvdEDB9yhDuOkB1FtYUEc3QcoeRsrgv QCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=0R5nC5NCJpjjrmOChJBMhgB1HMUIeGH06lkH4LeIZqo=; b=leLbONVivlkyT/hqrTv8NjsVpwnsrHJbUNZgyH8S4a3T4VxhUiVv/p/Ja2HbJoOO04 IWsZiCEXqjdSTQtr2gaAsjpPOonapwx8y/sHyOxUray3Nb/Hp9h/1DIe41Lb4h7t5xWE jFyq8XjU5LYTi4PLamhhMyAgmynJiIM0nMTcHXJ5jVg1RwGmPkJcEy8RRDYxOKHrpemG dsnKAettFKYDHWlRZZzXSpTA1OLTg3DdI6xgaNJXmvbe3ra41Kr8oUr9u0pa3oepdRzv K3sHnAwCZyMTTyNB3MufhpFwNBqGbBVdkMj0UW2mUn4zYY+6ybe6iN6Yzgo8CVuxNlSV wKvA== X-Gm-Message-State: ACrzQf1E45PwGVL/9nVsgKB6/SOVM3an+armULDqocX1eycmfWVyyYDa MS/irXsXzSOboURMs0yLS79jCYhVJcBMEmD/g7w= X-Google-Smtp-Source: AMsMyM6cKMuHNyPHW/zc+vfnWtQg/yyufTmkgx+JR8tQEv+0OxkshUNwQypSeFGKVgs5k2AZ2oG8LJ8B8dvJ39cgjZA= X-Received: by 2002:a17:907:75e7:b0:77a:2378:91bb with SMTP id jz7-20020a17090775e700b0077a237891bbmr23917706ejc.329.1664302640788; Tue, 27 Sep 2022 11:17:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Vipul Suneja Date: Tue, 27 Sep 2022 23:47:09 +0530 Message-ID: Subject: Re: How to do display sharing between guests or bring up guests display To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis Content-Type: multipart/alternative; boundary="000000000000b3f8b705e9aca737" --000000000000b3f8b705e9aca737 Content-Type: text/plain; charset="UTF-8" Hi Elliott, Thanks! As per the link you shared, VNC & SDL are two ways to get GUI display up for guests. I am going through VNC & tried SDL, added below line in guest1.cfg file. *vfb = [ 'sdl=1' ]* when creating guest machine by running command "*xl create -c guest1.cfg" *then its throwing errors: *root@raspberrypi4-64:~/guest1# xl create -c guest1.cfgParsing config from guest1.cfglibxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection reset by peerlibxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connection to QEMUlibxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed, rc=-26libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not start: -26libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exitedlibxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domainlibxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy guestlibxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed* It works absolutely fine & guest1 comes up if *vfb = [ 'sdl=1' ]* is not included in the configuration file. Anything wrong with the statement added or any other steps need to be followed for this? Looking after your response asap. Regards, Vipul Kumar On Thu, Sep 22, 2022 at 12:03 AM Elliott Mitchell wrote: > On Wed, Sep 21, 2022 at 10:54:55PM +0530, Vipul Suneja wrote: > > Now I have built a custom image with GUI & ported it as a guest2(DOMU2), > > guest2 came up as a console & couldn't see the GUI screen(Display screen > > connected to rpi4 via HDMI) coming up. > > > > Can you please guide me on display sharing or how to bring up guests > > display? > > This has already been answered in several locations. The first place to > ask for help with the RP4 is their own forums. Turns out the topic is > well known: > > https://forums.raspberrypi.com/viewtopic.php?t=232323#p1775083 > > (huh, their forum moved to the raspberrypi.com domain; they really need > an entry for Xen in their other OSes area) > > > -- > (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) > \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / > \_CS\ | _____ -O #include O- _____ | / _/ > 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 > > > --000000000000b3f8b705e9aca737 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Elliott,

Thanks!

As per the link you shared, VNC & SDL are two ways to get GUI dis= play up for guests. I am going through VNC & tried SDL, added below lin= e in guest1.cfg file.
vfb =3D [ 'sdl=3D1' ]
<= div>when creating guest machine by running command "xl create -c gu= est1.cfg"=C2=A0then its throwing errors:

= root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
Parsing con= fig from guest1.cfg
libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: D= omain 3:error on QMP socket: Connection reset by peer
libxl: error: libx= l_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP conne= ction to QEMU
libxl: error: libxl_dm.c:3351:device_model_postconfig_done= : Domain 3:Post DM startup configs failed, rc=3D-26
libxl: error: libxl_= create.c:1867:domcreate_devmodel_started: Domain 3:device model did not sta= rt: -26
libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Mo= del already exited
libxl: error: libxl_domain.c:1183:libxl__destroy_domi= d: Domain 3:Non-existant domain
libxl: error: libxl_domain.c:1137:domain= _destroy_callback: Domain 3:Unable to destroy guest
libxl: error: libxl_= domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed<= /b>

It works absolutely fine &am= p; guest1 comes up if=C2=A0vfb =3D [ 'sdl=3D1' ]=C2=A0is not= included in the configuration file. Anything wrong with the statement=C2= =A0
added or any other steps need to be followed for this? Lookin= g after your response asap.

Regards,
Vip= ul Kumar

On Thu, Sep 22, 2022 at 12:03 AM Elliott Mitchell <ehem+xen@m5p.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Sep 21, 2022 at 10= :54:55PM +0530, Vipul Suneja wrote:
> Now I have built a custom image with GUI & ported it as a guest2(D= OMU2),
> guest2 came up as a console & couldn't see the GUI screen(Disp= lay screen
> connected to rpi4 via HDMI) coming up.
>
> Can you please guide me on display sharing or how to bring up guests > display?

This has already been answered in several locations.=C2=A0 The first place = to
ask for help with the RP4 is their own forums.=C2=A0 Turns out the topic is=
well known:

https://forums.raspberrypi.com/viewt= opic.php?t=3D232323#p1775083

(huh, their forum moved to the raspberrypi.com domain; they really need an entry for Xen in their other OSes area)


--
(\___(\___(\______=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --=3D> 8-) EHM <= =3D--=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ______/)___/)___/)
=C2=A0\BS (=C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ehem+sigmsg@m5p.com=C2=A0 P= GP 87145445=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 )=C2=A0 =C2=A0/=
=C2=A0 \_CS\=C2=A0 =C2=A0|=C2=A0 _____=C2=A0 -O #include <stddisclaimer.= h> O-=C2=A0 =C2=A0_____=C2=A0 |=C2=A0 =C2=A0/=C2=A0 _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/= 5445


--000000000000b3f8b705e9aca737-- From xen-devel-bounces@lists.xenproject.org Tue Sep 27 18:50:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 18:50:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412930.656405 (Exim 4.92) (envelope-from ) id 1odFeQ-0004sI-W1; Tue, 27 Sep 2022 18:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412930.656405; Tue, 27 Sep 2022 18:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odFeQ-0004sB-T0; Tue, 27 Sep 2022 18:49:50 +0000 Received: by outflank-mailman (input) for mailman id 412930; Tue, 27 Sep 2022 18:49:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odFeP-0004s5-75 for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 18:49:49 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28f8cd80-3e95-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 20:49:48 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id c192-20020a1c35c9000000b003b51339d350so7600570wma.3 for ; Tue, 27 Sep 2022 11:49:47 -0700 (PDT) Received: from [192.168.8.100] (94.196.228.157.threembb.co.uk. [94.196.228.157]) by smtp.gmail.com with ESMTPSA id f10-20020adff58a000000b002285f73f11dsm2848176wro.81.2022.09.27.11.49.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 11:49:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28f8cd80-3e95-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Uy/Lr8Tfy+eWDjAiAzx45YwI3RpsjEElaf8OKPLhdUU=; b=CBghdfSs0ZPHWHMsOLsBnh5ZpxNT2s3g56DctsO8Mf9mTpDTB6p+jLVy8bOu2+/Gdf tHL+M2v6uQVCGGRhWriixY2hCCodfeT0NIK+rYSYcft3K607LdN7ljgevSDIHv+kB3Gr HMsq/7WpVUVStI31bLmpFEsfqmJoSciNbeX25w53xC6CZIpTPnuQqWDor1eo5aXCW7wo SZpbfEGfJ6MzmHDdU111Gj1BibSRBV7O+ut5u/8Y9GWObPkyxRBc09l85ScndiwvQ9n8 YzhcWh35A87K/iIPqzydlaTmJwgvg0mI8E1jMY79EiCdwUXdWqrJ8HQb6RvUBox+QqTC T43A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Uy/Lr8Tfy+eWDjAiAzx45YwI3RpsjEElaf8OKPLhdUU=; b=rFXaxLZ+Ze5bEMTAejY5+6k0PCssHocQThbSApO2KMYMtB97ZkarJvaqOheqYbKo78 kdV8JFPS6xREkZ7LtE5V8umnDWkPwq1pZrsL5Pa1Wy/Qe1Qg6bBh64ObL/gdOu1WRyFr vKjhNiv28r1c84IXUwpyArkM6RpjClGh9brmaSsud90G+GppFP4cI96FUCtTfZJJx1PE q7ZkXVUwv3uAWdvI67k0CF1Dk7FZ0MrmuedCeF5mi6kWeOr+ELahrzlVKSY/1rYaMEAG FyikD5GTaz86NOHbUo5T7GqeyHxYQ5dIUbTHtQu+J1ufd5njxs2YSMmyWb/6FIMmET5E pb7A== X-Gm-Message-State: ACrzQf0xJADdFFElonKYFBj4OiFb3iANokp2OGSQIJdQkD6KPfc8hgjt mRV0w/OZXIJuTV0ePZJW6mQ= X-Google-Smtp-Source: AMsMyM5I8+ROinB1laAu4ZG/L6R5Rm2MX5ZivMTsJ4uvWRtjro0IKjNXqFxx0x9bEj5jkdygW04R1g== X-Received: by 2002:a05:600c:3cd:b0:3b4:8372:294c with SMTP id z13-20020a05600c03cd00b003b48372294cmr3852346wmd.191.1664304587170; Tue, 27 Sep 2022 11:49:47 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 19:48:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info Content-Language: en-US To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> From: Pavel Begunkov In-Reply-To: <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/27/22 18:56, Paolo Abeni wrote: > On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: >> On 9/27/22 15:28, Pavel Begunkov wrote: >>> Hello Paolo, >>> >>> On 9/27/22 14:49, Paolo Abeni wrote: >>>> Hello, >>>> >>>> On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: >>>>> struct ubuf_info is large but not all fields are needed for all >>>>> cases. We have limited space in io_uring for it and large ubuf_info >>>>> prevents some struct embedding, even though we use only a subset >>>>> of the fields. It's also not very clean trying to use this typeless >>>>> extra space. >>>>> >>>>> Shrink struct ubuf_info to only necessary fields used in generic paths, >>>>> namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And >>>>> make MSG_ZEROCOPY and some other users to embed it into a larger struct >>>>> ubuf_info_msgzc mimicking the former ubuf_info. >>>>> >>>>> Note, xen/vhost may also have some cleaning on top by creating >>>>> new structs containing ubuf_info but with proper types. >>>> >>>> That sounds a bit scaring to me. If I read correctly, every uarg user >>>> should check 'uarg->callback == msg_zerocopy_callback' before accessing >>>> any 'extend' fields. >>> >>> Providers of ubuf_info access those fields via callbacks and so already >>> know the actual structure used. The net core, on the opposite, should >>> keep it encapsulated and not touch them at all. >>> >>> The series lists all places where we use extended fields just on the >>> merit of stripping the structure of those fields and successfully >>> building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which >>> again uses callbacks. >>> >>> Sounds like the right direction for me. There is a couple of >>> places where it might get type safer, i.e. adding types instead >>> of void* in for struct tun_msg_ctl and getting rid of one macro >>> hiding types in xen. But seems more like TODO for later. >>> >>>> AFAICS the current code sometimes don't do the >>>> explicit test because the condition is somewhat implied, which in turn >>>> is quite hard to track. >>>> >>>> clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected >>>> before this series, and after will trigger an oops.. >>> >>> And now we don't have this field at all to access, considering that >>> nobody blindly casts it. >>> >>>> There is some noise due to uarg -> uarg_zc renaming which make the >>>> series harder to review. Have you considered instead keeping the old >>>> name and introducing a smaller 'struct ubuf_info_common'? the overall >>>> code should be mostly the same, but it will avoid the above mentioned >>>> noise. >>> >>> I don't think there will be less noise this way, but let me try >>> and see if I can get rid of some churn. >> >> It doesn't look any better for me >> >> TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY >> and doesn't touch core code. If we do ubuf_info_common though I'd need >> to convert lots of places in skbuff.c and multiple places across >> tcp/udp, which is much worse. > > Uhmm... I underlook the fact we must preserve the current accessors for > the common fields. > > I guess something like the following could do (completely untested, > hopefully should illustrate the idea): > > struct ubuf_info { > struct_group_tagged(ubuf_info_common, common, > void (*callback)(struct sk_buff *, struct ubuf_info *, > bool zerocopy_success); > refcount_t refcnt; > u8 flags; > ); > > union { > struct { > unsigned long desc; > void *ctx; > }; > struct { > u32 id; > u16 len; > u16 zerocopy:1; > u32 bytelen; > }; > }; > > struct mmpin { > struct user_struct *user; > unsigned int num_pg; > } mmp; > }; > > Then you should be able to: > - access ubuf_info->callback, > - access the same field via ubuf_info->common.callback > - declare variables as 'struct ubuf_info_commom' with appropriate > contents. > > WDYT? Interesting, I didn't think about struct_group, this would let to split patches better and would limit non-core changes. But if the plan is to convert the core helpers to ubuf_info_common, than I think it's still messier than changing ubuf providers only. I can do the exercise, but I don't really see what is the goal. Let me ask this, if we forget for a second how diffs look, do you care about which pair is going to be in the end? ubuf_info_common/ubuf_info vs ubuf_info/ubuf_info_msgzc? Are there you concerned about naming or is there more to it? -- Pavel Begunkov From xen-devel-bounces@lists.xenproject.org Tue Sep 27 19:59:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 19:59:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412974.656434 (Exim 4.92) (envelope-from ) id 1odGjc-0004fG-8R; Tue, 27 Sep 2022 19:59:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412974.656434; Tue, 27 Sep 2022 19:59:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odGjc-0004f9-5Z; Tue, 27 Sep 2022 19:59:16 +0000 Received: by outflank-mailman (input) for mailman id 412974; Tue, 27 Sep 2022 19:59:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odGja-0004f3-Sm for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 19:59:15 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db27f9ae-3e9e-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 21:59:13 +0200 (CEST) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-146-u0QsycEsPAWYxtMJsDRfNQ-1; Tue, 27 Sep 2022 15:59:10 -0400 Received: by mail-wm1-f72.google.com with SMTP id n32-20020a05600c3ba000b003b5054c71faso8616339wms.9 for ; Tue, 27 Sep 2022 12:59:10 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-104-40.dyn.eolo.it. [146.241.104.40]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c4e8c00b003b33943ce5esm17310012wmq.32.2022.09.27.12.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 12:59:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db27f9ae-3e9e-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664308751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dx5HDOePnyxgHzqa6DOD5MnqegsYWwrLtgMoZQ1P8dI=; b=dzDrfmbzZenJ4kt4SoG0g6RKdm1TcbxEVaoqmg6cma8pgOVlurVLGVxSTHZHD7BG7yGENt MqeGCwCXJ92uxWUCqISNdxluncYQzPfo0GGO11L0A8WXehN7bU+pZ+g2q9z5kmmP3rOp4+ 2EYBGNwWWiDlDnlK+DyTcmt/Ci1spQE= X-MC-Unique: u0QsycEsPAWYxtMJsDRfNQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=Dx5HDOePnyxgHzqa6DOD5MnqegsYWwrLtgMoZQ1P8dI=; b=4Ko0YdieYlt8Z5ZajUzRlmEkRSD5uiqRAHuq1rFSMQ/u82goYYe+fI8LO1D7BJIc7W c6Z2Yf84oCcvaWc6S5BbJqRgLO98saOfEA9EeZxfwmjIgSEBLAAWKTftzP01DikPlUly 6omwNEL8A/5MhiZo2f/gZJndl2aFt0jyqncYFCo8ebiOYZmyrHwvD+ocQOBitP6ncBM5 hAfY4A+9B3fS2cXmwuo9DSsvtv0Ym9ykTan35V+h6F4xmEwPiQ0mCW9aVjqI2tu7aG8c 424HJCtBBXLIuQ6PiA2yNUvm+ujMyfNwlmN1T30TlMo4wL5KRtrtqKEa6Z22wDBWyyvE t6OA== X-Gm-Message-State: ACrzQf0memo4vznEruLBv1HGYmZBVruQmTjvCvXuXA7vQYy82meCh78O lxsRExAdSIi3dJR7KTw8M9lQsVusKbV5RkMpkKO76BFl6inQDitpBHupcZFntb1ST4zaXgjAEjV dF01isoZMFoQAGvf8/ZVaXB2GZ08= X-Received: by 2002:a05:6000:1a8a:b0:22a:33aa:a907 with SMTP id f10-20020a0560001a8a00b0022a33aaa907mr17893662wry.322.1664308748211; Tue, 27 Sep 2022 12:59:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7eOWYFV9iprtkvNGfif9TK9/JHNd5re5oxCk70ig0yrmbrjCmGTXstvwdg4i4Hc1mUWp0nvA== X-Received: by 2002:a05:6000:1a8a:b0:22a:33aa:a907 with SMTP id f10-20020a0560001a8a00b0022a33aaa907mr17893654wry.322.1664308747882; Tue, 27 Sep 2022 12:59:07 -0700 (PDT) Message-ID: <6502e1a45526f97a1e6d7d27bbe07e3bb3623de3.camel@redhat.com> Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info From: Paolo Abeni To: Pavel Begunkov , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang Date: Tue, 27 Sep 2022 21:59:06 +0200 In-Reply-To: References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2022-09-27 at 19:48 +0100, Pavel Begunkov wrote: > On 9/27/22 18:56, Paolo Abeni wrote: > > On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: > > > On 9/27/22 15:28, Pavel Begunkov wrote: > > > > Hello Paolo, > > > > > > > > On 9/27/22 14:49, Paolo Abeni wrote: > > > > > Hello, > > > > > > > > > > On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: > > > > > > struct ubuf_info is large but not all fields are needed for all > > > > > > cases. We have limited space in io_uring for it and large ubuf_info > > > > > > prevents some struct embedding, even though we use only a subset > > > > > > of the fields. It's also not very clean trying to use this typeless > > > > > > extra space. > > > > > > > > > > > > Shrink struct ubuf_info to only necessary fields used in generic paths, > > > > > > namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And > > > > > > make MSG_ZEROCOPY and some other users to embed it into a larger struct > > > > > > ubuf_info_msgzc mimicking the former ubuf_info. > > > > > > > > > > > > Note, xen/vhost may also have some cleaning on top by creating > > > > > > new structs containing ubuf_info but with proper types. > > > > > > > > > > That sounds a bit scaring to me. If I read correctly, every uarg user > > > > > should check 'uarg->callback == msg_zerocopy_callback' before accessing > > > > > any 'extend' fields. > > > > > > > > Providers of ubuf_info access those fields via callbacks and so already > > > > know the actual structure used. The net core, on the opposite, should > > > > keep it encapsulated and not touch them at all. > > > > > > > > The series lists all places where we use extended fields just on the > > > > merit of stripping the structure of those fields and successfully > > > > building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which > > > > again uses callbacks. > > > > > > > > Sounds like the right direction for me. There is a couple of > > > > places where it might get type safer, i.e. adding types instead > > > > of void* in for struct tun_msg_ctl and getting rid of one macro > > > > hiding types in xen. But seems more like TODO for later. > > > > > > > > > AFAICS the current code sometimes don't do the > > > > > explicit test because the condition is somewhat implied, which in turn > > > > > is quite hard to track. > > > > > > > > > > clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected > > > > > before this series, and after will trigger an oops.. > > > > > > > > And now we don't have this field at all to access, considering that > > > > nobody blindly casts it. > > > > > > > > > There is some noise due to uarg -> uarg_zc renaming which make the > > > > > series harder to review. Have you considered instead keeping the old > > > > > name and introducing a smaller 'struct ubuf_info_common'? the overall > > > > > code should be mostly the same, but it will avoid the above mentioned > > > > > noise. > > > > > > > > I don't think there will be less noise this way, but let me try > > > > and see if I can get rid of some churn. > > > > > > It doesn't look any better for me > > > > > > TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY > > > and doesn't touch core code. If we do ubuf_info_common though I'd need > > > to convert lots of places in skbuff.c and multiple places across > > > tcp/udp, which is much worse. > > > > Uhmm... I underlook the fact we must preserve the current accessors for > > the common fields. > > > > I guess something like the following could do (completely untested, > > hopefully should illustrate the idea): > > > > struct ubuf_info { > > struct_group_tagged(ubuf_info_common, common, > > void (*callback)(struct sk_buff *, struct ubuf_info *, > > bool zerocopy_success); > > refcount_t refcnt; > > u8 flags; > > ); > > > > union { > > struct { > > unsigned long desc; > > void *ctx; > > }; > > struct { > > u32 id; > > u16 len; > > u16 zerocopy:1; > > u32 bytelen; > > }; > > }; > > > > struct mmpin { > > struct user_struct *user; > > unsigned int num_pg; > > } mmp; > > }; > > > > Then you should be able to: > > - access ubuf_info->callback, > > - access the same field via ubuf_info->common.callback > > - declare variables as 'struct ubuf_info_commom' with appropriate > > contents. > > > > WDYT? > > Interesting, I didn't think about struct_group, this would > let to split patches better and would limit non-core changes. > But if the plan is to convert the core helpers to > ubuf_info_common, than I think it's still messier than changing > ubuf providers only. > > I can do the exercise, but I don't really see what is the goal. > Let me ask this, if we forget for a second how diffs look, > do you care about which pair is going to be in the end? Uhm... I proposed this initially with the goal of remove non fuctional changes from a patch that was hard to digest for me (4/4). So it's about diffstat to me ;) On the flip side the change suggested would probably not be as straighforward as I would hope for. > ubuf_info_common/ubuf_info vs ubuf_info/ubuf_info_msgzc? The specific names used are not much relevant. > Are there you concerned about naming or is there more to it? I feel like this series is potentially dangerous, but I could not spot bugs into the code. I would have felt more relaxed eariler in the devel cycle. Cheers, Paolo From xen-devel-bounces@lists.xenproject.org Tue Sep 27 20:19:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 20:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412983.656446 (Exim 4.92) (envelope-from ) id 1odH2e-0007G9-V7; Tue, 27 Sep 2022 20:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412983.656446; Tue, 27 Sep 2022 20:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odH2e-0007G2-Rj; Tue, 27 Sep 2022 20:18:56 +0000 Received: by outflank-mailman (input) for mailman id 412983; Tue, 27 Sep 2022 20:18:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odH2c-0007Fw-Kk for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 20:18:54 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b20006a-3ea1-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 22:18:53 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id z6so16712638wrq.1 for ; Tue, 27 Sep 2022 13:18:53 -0700 (PDT) Received: from [192.168.8.100] (94.196.228.157.threembb.co.uk. [94.196.228.157]) by smtp.gmail.com with ESMTPSA id h6-20020a05600c2ca600b003b4c40378casm15913221wmc.39.2022.09.27.13.18.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 13:18:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b20006a-3ea1-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=VYiQC0+hw/YN0HXUIX2ZHIj06ZGTMESETEb91ek6mio=; b=b+d1TFFX1HXrnCaj7FfV0JH6lWEvDi7u3jNGbto0NjhdTpD6ERgE7IZlMeUVVKagS3 tAsXx4Z6ZmRtpNFpwpxDVJPUF7h5h/m+dvjMfh69N0kHhjdsGOlPbcdGFjPe3dIamT8v q7TwybO/csHrDvvde2hc5jWTaSOMBDxPgCFs4rJEcVW2Wza3nWPY1r7D8Q6xQaRVfGVO x6hQERoCR+sQon+7K602PQLtOTJI4fdHVnOIBlQyCQKkl8kKxYNVRzBpgHiZR8VozqwO dhDUyaw7//V8D4F1HfY5TRpbllYVg9mn6ql2NwHov4/vATDDt8Oa8QIsfUomFfI1owfC 8IZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=VYiQC0+hw/YN0HXUIX2ZHIj06ZGTMESETEb91ek6mio=; b=MC1hUtKfvmsvrMYPyUSo9/fhTDWUsHYyKAR29wFG0MIA7AIXDF9QGy0sxHZ3OLNnYe irnL1I8IBcKrX2gQ9bh4Tcz73BrV66uACOmC12iwBsOLUHeXMkW1wGZiWm/Jyfm5R9aU Yr17PEY9yucmdjDlIcgqZ0czmFSVSJM6PheNzezwEtaqtaUYuJnXiDwPuy82ywVYiBih arML0AuxqrKhxFQ9wUhglIii02q01laIqj2GGFmORdp/Kghl3OXfERZlTDNsgEC0Nf2P FdlRhq0xXLrQ6fgGyIlT3KnNYar/Lz7beu9CF8eyeqMPoRlWL+03LAtWcl1edh+TaCWs lFIA== X-Gm-Message-State: ACrzQf0wqkvGLRIbGYp37x6gm6lO0jPnJzMWe5AqM8Rc3gIUyiemHF1L TfAvXDuuKBcIz9Sin6QxLyykPk6X8iA= X-Google-Smtp-Source: AMsMyM72QF1jZuXSKJAZ2BYNMNBdePc6il3Rd6JK8twIGapZblKS+cSGVMGc37PNt4I9uTYnAXgKHg== X-Received: by 2002:a05:6000:186e:b0:22a:e3b1:9c7d with SMTP id d14-20020a056000186e00b0022ae3b19c7dmr19019256wri.113.1664309932648; Tue, 27 Sep 2022 13:18:52 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 21:17:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info Content-Language: en-US To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> <6502e1a45526f97a1e6d7d27bbe07e3bb3623de3.camel@redhat.com> From: Pavel Begunkov In-Reply-To: <6502e1a45526f97a1e6d7d27bbe07e3bb3623de3.camel@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/27/22 20:59, Paolo Abeni wrote: > On Tue, 2022-09-27 at 19:48 +0100, Pavel Begunkov wrote: >> On 9/27/22 18:56, Paolo Abeni wrote: >>> On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: >>>> On 9/27/22 15:28, Pavel Begunkov wrote: >>>>> Hello Paolo, >>>>> >>>>> On 9/27/22 14:49, Paolo Abeni wrote: >>>>>> Hello, >>>>>> >>>>>> On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: >>>>>>> struct ubuf_info is large but not all fields are needed for all >>>>>>> cases. We have limited space in io_uring for it and large ubuf_info >>>>>>> prevents some struct embedding, even though we use only a subset >>>>>>> of the fields. It's also not very clean trying to use this typeless >>>>>>> extra space. >>>>>>> >>>>>>> Shrink struct ubuf_info to only necessary fields used in generic paths, >>>>>>> namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And >>>>>>> make MSG_ZEROCOPY and some other users to embed it into a larger struct >>>>>>> ubuf_info_msgzc mimicking the former ubuf_info. >>>>>>> >>>>>>> Note, xen/vhost may also have some cleaning on top by creating >>>>>>> new structs containing ubuf_info but with proper types. >>>>>> >>>>>> That sounds a bit scaring to me. If I read correctly, every uarg user >>>>>> should check 'uarg->callback == msg_zerocopy_callback' before accessing >>>>>> any 'extend' fields. >>>>> >>>>> Providers of ubuf_info access those fields via callbacks and so already >>>>> know the actual structure used. The net core, on the opposite, should >>>>> keep it encapsulated and not touch them at all. >>>>> >>>>> The series lists all places where we use extended fields just on the >>>>> merit of stripping the structure of those fields and successfully >>>>> building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which >>>>> again uses callbacks. >>>>> >>>>> Sounds like the right direction for me. There is a couple of >>>>> places where it might get type safer, i.e. adding types instead >>>>> of void* in for struct tun_msg_ctl and getting rid of one macro >>>>> hiding types in xen. But seems more like TODO for later. >>>>> >>>>>> AFAICS the current code sometimes don't do the >>>>>> explicit test because the condition is somewhat implied, which in turn >>>>>> is quite hard to track. >>>>>> >>>>>> clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected >>>>>> before this series, and after will trigger an oops.. >>>>> >>>>> And now we don't have this field at all to access, considering that >>>>> nobody blindly casts it. >>>>> >>>>>> There is some noise due to uarg -> uarg_zc renaming which make the >>>>>> series harder to review. Have you considered instead keeping the old >>>>>> name and introducing a smaller 'struct ubuf_info_common'? the overall >>>>>> code should be mostly the same, but it will avoid the above mentioned >>>>>> noise. >>>>> >>>>> I don't think there will be less noise this way, but let me try >>>>> and see if I can get rid of some churn. >>>> >>>> It doesn't look any better for me >>>> >>>> TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY >>>> and doesn't touch core code. If we do ubuf_info_common though I'd need >>>> to convert lots of places in skbuff.c and multiple places across >>>> tcp/udp, which is much worse. >>> >>> Uhmm... I underlook the fact we must preserve the current accessors for >>> the common fields. >>> >>> I guess something like the following could do (completely untested, >>> hopefully should illustrate the idea): >>> >>> struct ubuf_info { >>> struct_group_tagged(ubuf_info_common, common, >>> void (*callback)(struct sk_buff *, struct ubuf_info *, >>> bool zerocopy_success); >>> refcount_t refcnt; >>> u8 flags; >>> ); >>> >>> union { >>> struct { >>> unsigned long desc; >>> void *ctx; >>> }; >>> struct { >>> u32 id; >>> u16 len; >>> u16 zerocopy:1; >>> u32 bytelen; >>> }; >>> }; >>> >>> struct mmpin { >>> struct user_struct *user; >>> unsigned int num_pg; >>> } mmp; >>> }; >>> >>> Then you should be able to: >>> - access ubuf_info->callback, >>> - access the same field via ubuf_info->common.callback >>> - declare variables as 'struct ubuf_info_commom' with appropriate >>> contents. >>> >>> WDYT? >> >> Interesting, I didn't think about struct_group, this would >> let to split patches better and would limit non-core changes. >> But if the plan is to convert the core helpers to >> ubuf_info_common, than I think it's still messier than changing >> ubuf providers only. >> >> I can do the exercise, but I don't really see what is the goal. >> Let me ask this, if we forget for a second how diffs look, >> do you care about which pair is going to be in the end? > > Uhm... I proposed this initially with the goal of remove non fuctional > changes from a patch that was hard to digest for me (4/4). So it's > about diffstat to me ;) Ah, got it > On the flip side the change suggested would probably not be as > straighforward as I would hope for. > >> ubuf_info_common/ubuf_info vs ubuf_info/ubuf_info_msgzc? > > The specific names used are not much relevant. > >> Are there you concerned about naming or is there more to it? > > I feel like this series is potentially dangerous, but I could not spot > bugs into the code. I would have felt more relaxed eariler in the devel > cycle. union { struct { unsigned long desc; void *ctx; }; struct { u32 id; u16 len; u16 zerocopy:1; u32 bytelen; }; }; btw, nobody would frivolously change ->zerocopy anyway as it's in a union. Even without the series we're absolutely screwed if someone does that. If anything it adds a way to get rid of it: 1) Make vhost and xen use their own structures with right types. 2) kill unused struct {ctx, desc} for MSG_ZEROCOPY -- Pavel Begunkov From xen-devel-bounces@lists.xenproject.org Tue Sep 27 20:23:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 20:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412988.656457 (Exim 4.92) (envelope-from ) id 1odH7I-0000Ds-HJ; Tue, 27 Sep 2022 20:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412988.656457; Tue, 27 Sep 2022 20:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odH7I-0000Dl-E2; Tue, 27 Sep 2022 20:23:44 +0000 Received: by outflank-mailman (input) for mailman id 412988; Tue, 27 Sep 2022 20:23:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odH7I-0000Df-4Y for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 20:23:44 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 474b28d9-3ea2-11ed-9374-c1cf23e5d27e; Tue, 27 Sep 2022 22:23:43 +0200 (CEST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-102-GPJ2qOvdNV6TIs-aExmuJA-1; Tue, 27 Sep 2022 16:23:40 -0400 Received: by mail-wm1-f71.google.com with SMTP id k21-20020a7bc415000000b003b4fac53006so3160065wmi.3 for ; Tue, 27 Sep 2022 13:23:40 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-104-40.dyn.eolo.it. [146.241.104.40]) by smtp.gmail.com with ESMTPSA id m17-20020a05600c461100b003a5fa79007fsm2520605wmo.7.2022.09.27.13.23.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 13:23:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 474b28d9-3ea2-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664310221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bPS2hzRpnh4vS84t7HeCrT88khQ6cmZJEXbF5+gL9zE=; b=aRMut5g2Fc25bVI2uNwj8RvheG7GkQvt5aaxifuT5P853d/VfODTbTYVRcmWNqHpHJBwWX 0qhtD0lVzN+1fCLG46+fojqWf+YrVJAWm60HOKnYmNilTO1BVbI84xAvGfkDO+QeNuYSNR LOu/JJu0GsAuoWTc+04X8//0wcyqU50= X-MC-Unique: GPJ2qOvdNV6TIs-aExmuJA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=bPS2hzRpnh4vS84t7HeCrT88khQ6cmZJEXbF5+gL9zE=; b=zS8RAnGNDQSlU5S4+9EayXeE3w1s9dZ7HkJR1xbBSPb0/9LMfKRtmXtE3+0N1HXB6b vwfv/DRf5nLhL1NwVsWBgluXvd/MYWIYytDsELqjGkXZ9d7Zi17mUMMiku8nby0uJLdp cUKKpuGivlif7m0PuCtzDcHR7WLfps+ItRNhHSAqkLJ8sNdMhs+V5yfW+93wqrXowQYL mkRxU8hnWsV6UNcnMrm/y1PPguIshRgA5Iqw7nKRDKZNkc4N+LbcG2lSWaAsGX2ufAp8 WIr2FLM4D4VgwcybUl5f0yZfss3AJqFSmWQyGEKdqomsuY3qKRJjpEPJMc3qiN9DfUeX YnMw== X-Gm-Message-State: ACrzQf22majfMmZPS9t1CPPNtHLxy0Bb4/dWhvsuDg2NAsJRFPPChOoH zdoEjk8uaxHOFsqXhZDxhEfaxzD+CYWIqt7znwwW2FelBAnjmcyJYQzIey4yFZy3XNPEGSQni3r epYfaG+HWkJDkHtEhrLRKb1dVQJ0= X-Received: by 2002:a05:6000:18ad:b0:22a:f7b5:16f8 with SMTP id b13-20020a05600018ad00b0022af7b516f8mr18132913wri.305.1664310219380; Tue, 27 Sep 2022 13:23:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ci15yCp/mYBPh7Hxm1QkwLOuat3oDTUzqTHSVWObghnWMRosUrppkyN/V4CuayXBq254sVg== X-Received: by 2002:a05:6000:18ad:b0:22a:f7b5:16f8 with SMTP id b13-20020a05600018ad00b0022af7b516f8mr18132903wri.305.1664310219067; Tue, 27 Sep 2022 13:23:39 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info From: Paolo Abeni To: Pavel Begunkov , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang Date: Tue, 27 Sep 2022 22:23:37 +0200 In-Reply-To: References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> <6502e1a45526f97a1e6d7d27bbe07e3bb3623de3.camel@redhat.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2022-09-27 at 21:17 +0100, Pavel Begunkov wrote: > On 9/27/22 20:59, Paolo Abeni wrote: > > On Tue, 2022-09-27 at 19:48 +0100, Pavel Begunkov wrote: > > > On 9/27/22 18:56, Paolo Abeni wrote: > > > > On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: > > > > > On 9/27/22 15:28, Pavel Begunkov wrote: > > > > > > Hello Paolo, > > > > > > > > > > > > On 9/27/22 14:49, Paolo Abeni wrote: > > > > > > > Hello, > > > > > > > > > > > > > > On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: > > > > > > > > struct ubuf_info is large but not all fields are needed for all > > > > > > > > cases. We have limited space in io_uring for it and large ubuf_info > > > > > > > > prevents some struct embedding, even though we use only a subset > > > > > > > > of the fields. It's also not very clean trying to use this typeless > > > > > > > > extra space. > > > > > > > > > > > > > > > > Shrink struct ubuf_info to only necessary fields used in generic paths, > > > > > > > > namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And > > > > > > > > make MSG_ZEROCOPY and some other users to embed it into a larger struct > > > > > > > > ubuf_info_msgzc mimicking the former ubuf_info. > > > > > > > > > > > > > > > > Note, xen/vhost may also have some cleaning on top by creating > > > > > > > > new structs containing ubuf_info but with proper types. > > > > > > > > > > > > > > That sounds a bit scaring to me. If I read correctly, every uarg user > > > > > > > should check 'uarg->callback == msg_zerocopy_callback' before accessing > > > > > > > any 'extend' fields. > > > > > > > > > > > > Providers of ubuf_info access those fields via callbacks and so already > > > > > > know the actual structure used. The net core, on the opposite, should > > > > > > keep it encapsulated and not touch them at all. > > > > > > > > > > > > The series lists all places where we use extended fields just on the > > > > > > merit of stripping the structure of those fields and successfully > > > > > > building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which > > > > > > again uses callbacks. > > > > > > > > > > > > Sounds like the right direction for me. There is a couple of > > > > > > places where it might get type safer, i.e. adding types instead > > > > > > of void* in for struct tun_msg_ctl and getting rid of one macro > > > > > > hiding types in xen. But seems more like TODO for later. > > > > > > > > > > > > > AFAICS the current code sometimes don't do the > > > > > > > explicit test because the condition is somewhat implied, which in turn > > > > > > > is quite hard to track. > > > > > > > > > > > > > > clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected > > > > > > > before this series, and after will trigger an oops.. > > > > > > > > > > > > And now we don't have this field at all to access, considering that > > > > > > nobody blindly casts it. > > > > > > > > > > > > > There is some noise due to uarg -> uarg_zc renaming which make the > > > > > > > series harder to review. Have you considered instead keeping the old > > > > > > > name and introducing a smaller 'struct ubuf_info_common'? the overall > > > > > > > code should be mostly the same, but it will avoid the above mentioned > > > > > > > noise. > > > > > > > > > > > > I don't think there will be less noise this way, but let me try > > > > > > and see if I can get rid of some churn. > > > > > > > > > > It doesn't look any better for me > > > > > > > > > > TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY > > > > > and doesn't touch core code. If we do ubuf_info_common though I'd need > > > > > to convert lots of places in skbuff.c and multiple places across > > > > > tcp/udp, which is much worse. > > > > > > > > Uhmm... I underlook the fact we must preserve the current accessors for > > > > the common fields. > > > > > > > > I guess something like the following could do (completely untested, > > > > hopefully should illustrate the idea): > > > > > > > > struct ubuf_info { > > > > struct_group_tagged(ubuf_info_common, common, > > > > void (*callback)(struct sk_buff *, struct ubuf_info *, > > > > bool zerocopy_success); > > > > refcount_t refcnt; > > > > u8 flags; > > > > ); > > > > > > > > union { > > > > struct { > > > > unsigned long desc; > > > > void *ctx; > > > > }; > > > > struct { > > > > u32 id; > > > > u16 len; > > > > u16 zerocopy:1; > > > > u32 bytelen; > > > > }; > > > > }; > > > > > > > > struct mmpin { > > > > struct user_struct *user; > > > > unsigned int num_pg; > > > > } mmp; > > > > }; > > > > > > > > Then you should be able to: > > > > - access ubuf_info->callback, > > > > - access the same field via ubuf_info->common.callback > > > > - declare variables as 'struct ubuf_info_commom' with appropriate > > > > contents. > > > > > > > > WDYT? > > > > > > Interesting, I didn't think about struct_group, this would > > > let to split patches better and would limit non-core changes. > > > But if the plan is to convert the core helpers to > > > ubuf_info_common, than I think it's still messier than changing > > > ubuf providers only. > > > > > > I can do the exercise, but I don't really see what is the goal. > > > Let me ask this, if we forget for a second how diffs look, > > > do you care about which pair is going to be in the end? > > > > Uhm... I proposed this initially with the goal of remove non fuctional > > changes from a patch that was hard to digest for me (4/4). So it's > > about diffstat to me ;) > > Ah, got it > > > On the flip side the change suggested would probably not be as > > straighforward as I would hope for. > > > > > ubuf_info_common/ubuf_info vs ubuf_info/ubuf_info_msgzc? > > > > The specific names used are not much relevant. > > > > > Are there you concerned about naming or is there more to it? > > > > I feel like this series is potentially dangerous, but I could not spot > > bugs into the code. I would have felt more relaxed eariler in the devel > > cycle. > > union { > struct { > unsigned long desc; > void *ctx; > }; > struct { > u32 id; > u16 len; > u16 zerocopy:1; > u32 bytelen; > }; > }; > > > btw, nobody would frivolously change ->zerocopy anyway as it's > in a union. Even without the series we're absolutely screwed > if someone does that. If anything it adds a way to get rid of it: > > 1) Make vhost and xen use their own structures with right types. > 2) kill unused struct {ctx, desc} for MSG_ZEROCOPY Ok, the above sounds reasonable. Additionally I've spent the last surviving neuron on my side to on this series, and it looks sane, so... Acked-by: Paolo Abeni From xen-devel-bounces@lists.xenproject.org Tue Sep 27 21:04:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 21:04:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.412995.656468 (Exim 4.92) (envelope-from ) id 1odHkO-0004dh-JI; Tue, 27 Sep 2022 21:04:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 412995.656468; Tue, 27 Sep 2022 21:04:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odHkO-0004da-G2; Tue, 27 Sep 2022 21:04:08 +0000 Received: by outflank-mailman (input) for mailman id 412995; Tue, 27 Sep 2022 21:04:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odHkN-0004dT-HC for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 21:04:07 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb19088f-3ea7-11ed-9648-05401a9f4f97; Tue, 27 Sep 2022 23:04:04 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso10197935wma.1 for ; Tue, 27 Sep 2022 14:04:04 -0700 (PDT) Received: from [192.168.8.100] (94.196.228.157.threembb.co.uk. [94.196.228.157]) by smtp.gmail.com with ESMTPSA id i7-20020adffc07000000b0022917d58603sm2578282wrr.32.2022.09.27.14.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 14:04:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb19088f-3ea7-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=4utwpaiX+nwZ8/aoptuiHSf3C3V/LbDfmFnwMH4/AB4=; b=jyusM2yPG8DlGbki+SxcWD6f5AVuoTEYdygVIP1p9R1YD5O0l8LILbnNLh79Kns0Cz PU2FjB4OLLFvCtesBimyiKrjAxE76xJPFK4G5iWTBnjZC9Slf5dWWzF/bNtBtvilVrM1 mU5ndgUOIZoGA3OaFQC28I30J3MVXpoenboUg/GvOz/mgpNzAztconza319TBTPc0yjP x7LwT4WqJq5UH/nWhLn2NNZVso3FZ2V8bqvYSkYKSK3KradKkiksbySeShprzUuVrx7x Up4t7mmKBdBoZ6osAnsLCMG5BVkRdKutYS2XUmqQTbrbtNMGHtRblysYOpO3k1Mol3IS kCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4utwpaiX+nwZ8/aoptuiHSf3C3V/LbDfmFnwMH4/AB4=; b=d1CAH05bpArMzO6OGuSX0jlIGGzKOO9N2D7gDWTGBEYi0H2Pxp7sWxDYglLByvnlcy vMPk4yw+RjCA/yU5gq231XvH0kEQT8u8EY4p2otqXYV/+iiqBICKgl8BknvgMwrqjU5M GwhRrd9hMXzspLRnAENGF8Zre9uGE/odv4JPo6bPJ60At5tGpRh4DyKbRdwlt2pnBxyJ VjaLDSBCqTjTiMrQzfFFn58mlvTRGpgiNUTu0pvyvlmCQsF3H8zawAndOCWZVqCSzdNN JhYEvPGgIpZGXBnEfz0xObzKrAD/rJ8dI+2PGgRu1A8GSUpKGZXcrAfUiPYSjLpM2/Sc dpDQ== X-Gm-Message-State: ACrzQf1V+Vb77jMwJrGfTikRHOXxNAuY5gf+UN+kqrSH37XNFrZ+IngN ZSmZzJUk1QfKsNI/EmgoTOQ= X-Google-Smtp-Source: AMsMyM5bRqdJoS8GkrzVBsbwQ/0Om0L4715MSQx2Luhy1dmQdbONNx03zPxwGHpo4vbTsTgRYmFHwA== X-Received: by 2002:a05:600c:35cf:b0:3b4:c0c2:d213 with SMTP id r15-20020a05600c35cf00b003b4c0c2d213mr4320200wmq.162.1664312643840; Tue, 27 Sep 2022 14:04:03 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 22:02:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info Content-Language: en-US To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Wei Liu , Paul Durrant , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Jason Wang References: <7fef56880d40b9d83cc99317df9060c4e7cdf919.camel@redhat.com> <021d8ea4-891c-237d-686e-64cecc2cc842@gmail.com> <85cccb780608e830024fc82a8e4f703031646f4e.camel@redhat.com> <6502e1a45526f97a1e6d7d27bbe07e3bb3623de3.camel@redhat.com> From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/27/22 21:23, Paolo Abeni wrote: > On Tue, 2022-09-27 at 21:17 +0100, Pavel Begunkov wrote: >> On 9/27/22 20:59, Paolo Abeni wrote: >>> On Tue, 2022-09-27 at 19:48 +0100, Pavel Begunkov wrote: >>>> On 9/27/22 18:56, Paolo Abeni wrote: >>>>> On Tue, 2022-09-27 at 18:16 +0100, Pavel Begunkov wrote: >>>>>> On 9/27/22 15:28, Pavel Begunkov wrote: >>>>>>> Hello Paolo, >>>>>>> >>>>>>> On 9/27/22 14:49, Paolo Abeni wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> On Fri, 2022-09-23 at 17:39 +0100, Pavel Begunkov wrote: >>>>>>>>> struct ubuf_info is large but not all fields are needed for all >>>>>>>>> cases. We have limited space in io_uring for it and large ubuf_info >>>>>>>>> prevents some struct embedding, even though we use only a subset >>>>>>>>> of the fields. It's also not very clean trying to use this typeless >>>>>>>>> extra space. >>>>>>>>> >>>>>>>>> Shrink struct ubuf_info to only necessary fields used in generic paths, >>>>>>>>> namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And >>>>>>>>> make MSG_ZEROCOPY and some other users to embed it into a larger struct >>>>>>>>> ubuf_info_msgzc mimicking the former ubuf_info. >>>>>>>>> >>>>>>>>> Note, xen/vhost may also have some cleaning on top by creating >>>>>>>>> new structs containing ubuf_info but with proper types. >>>>>>>> >>>>>>>> That sounds a bit scaring to me. If I read correctly, every uarg user >>>>>>>> should check 'uarg->callback == msg_zerocopy_callback' before accessing >>>>>>>> any 'extend' fields. >>>>>>> >>>>>>> Providers of ubuf_info access those fields via callbacks and so already >>>>>>> know the actual structure used. The net core, on the opposite, should >>>>>>> keep it encapsulated and not touch them at all. >>>>>>> >>>>>>> The series lists all places where we use extended fields just on the >>>>>>> merit of stripping the structure of those fields and successfully >>>>>>> building it. The only user in net/ipv{4,6}/* is MSG_ZEROCOPY, which >>>>>>> again uses callbacks. >>>>>>> >>>>>>> Sounds like the right direction for me. There is a couple of >>>>>>> places where it might get type safer, i.e. adding types instead >>>>>>> of void* in for struct tun_msg_ctl and getting rid of one macro >>>>>>> hiding types in xen. But seems more like TODO for later. >>>>>>> >>>>>>>> AFAICS the current code sometimes don't do the >>>>>>>> explicit test because the condition is somewhat implied, which in turn >>>>>>>> is quite hard to track. >>>>>>>> >>>>>>>> clearing uarg->zerocopy for the 'wrong' uarg was armless and undetected >>>>>>>> before this series, and after will trigger an oops.. >>>>>>> >>>>>>> And now we don't have this field at all to access, considering that >>>>>>> nobody blindly casts it. >>>>>>> >>>>>>>> There is some noise due to uarg -> uarg_zc renaming which make the >>>>>>>> series harder to review. Have you considered instead keeping the old >>>>>>>> name and introducing a smaller 'struct ubuf_info_common'? the overall >>>>>>>> code should be mostly the same, but it will avoid the above mentioned >>>>>>>> noise. >>>>>>> >>>>>>> I don't think there will be less noise this way, but let me try >>>>>>> and see if I can get rid of some churn. >>>>>> >>>>>> It doesn't look any better for me >>>>>> >>>>>> TL;DR; This series converts only 3 users: tap, xen and MSG_ZEROCOPY >>>>>> and doesn't touch core code. If we do ubuf_info_common though I'd need >>>>>> to convert lots of places in skbuff.c and multiple places across >>>>>> tcp/udp, which is much worse. >>>>> >>>>> Uhmm... I underlook the fact we must preserve the current accessors for >>>>> the common fields. >>>>> >>>>> I guess something like the following could do (completely untested, >>>>> hopefully should illustrate the idea): >>>>> >>>>> struct ubuf_info { >>>>> struct_group_tagged(ubuf_info_common, common, >>>>> void (*callback)(struct sk_buff *, struct ubuf_info *, >>>>> bool zerocopy_success); >>>>> refcount_t refcnt; >>>>> u8 flags; >>>>> ); >>>>> >>>>> union { >>>>> struct { >>>>> unsigned long desc; >>>>> void *ctx; >>>>> }; >>>>> struct { >>>>> u32 id; >>>>> u16 len; >>>>> u16 zerocopy:1; >>>>> u32 bytelen; >>>>> }; >>>>> }; >>>>> >>>>> struct mmpin { >>>>> struct user_struct *user; >>>>> unsigned int num_pg; >>>>> } mmp; >>>>> }; >>>>> >>>>> Then you should be able to: >>>>> - access ubuf_info->callback, >>>>> - access the same field via ubuf_info->common.callback >>>>> - declare variables as 'struct ubuf_info_commom' with appropriate >>>>> contents. >>>>> >>>>> WDYT? >>>> >>>> Interesting, I didn't think about struct_group, this would >>>> let to split patches better and would limit non-core changes. >>>> But if the plan is to convert the core helpers to >>>> ubuf_info_common, than I think it's still messier than changing >>>> ubuf providers only. >>>> >>>> I can do the exercise, but I don't really see what is the goal. >>>> Let me ask this, if we forget for a second how diffs look, >>>> do you care about which pair is going to be in the end? >>> >>> Uhm... I proposed this initially with the goal of remove non fuctional >>> changes from a patch that was hard to digest for me (4/4). So it's >>> about diffstat to me ;) >> >> Ah, got it >> >>> On the flip side the change suggested would probably not be as >>> straighforward as I would hope for. >>> >>>> ubuf_info_common/ubuf_info vs ubuf_info/ubuf_info_msgzc? >>> >>> The specific names used are not much relevant. >>> >>>> Are there you concerned about naming or is there more to it? >>> >>> I feel like this series is potentially dangerous, but I could not spot >>> bugs into the code. I would have felt more relaxed eariler in the devel >>> cycle. >> >> union { >> struct { >> unsigned long desc; >> void *ctx; >> }; >> struct { >> u32 id; >> u16 len; >> u16 zerocopy:1; >> u32 bytelen; >> }; >> }; >> >> >> btw, nobody would frivolously change ->zerocopy anyway as it's >> in a union. Even without the series we're absolutely screwed >> if someone does that. If anything it adds a way to get rid of it: >> >> 1) Make vhost and xen use their own structures with right types. >> 2) kill unused struct {ctx, desc} for MSG_ZEROCOPY > > Ok, the above sounds reasonable. Additionally I've spent the last > surviving neuron on my side to on this series, and it looks sane, so... > > Acked-by: Paolo Abeni Great, thanks for taking a look! -- Pavel Begunkov From xen-devel-bounces@lists.xenproject.org Tue Sep 27 22:22:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 22:22:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413004.656479 (Exim 4.92) (envelope-from ) id 1odIxX-0004KE-9o; Tue, 27 Sep 2022 22:21:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413004.656479; Tue, 27 Sep 2022 22:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odIxX-0004K7-73; Tue, 27 Sep 2022 22:21:47 +0000 Received: by outflank-mailman (input) for mailman id 413004; Tue, 27 Sep 2022 22:21:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odIxV-0004Jx-Rh; Tue, 27 Sep 2022 22:21:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odIxV-0005Cq-OK; Tue, 27 Sep 2022 22:21:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odIxV-0000Tj-BM; Tue, 27 Sep 2022 22:21:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odIxV-0004si-Au; Tue, 27 Sep 2022 22:21:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oOvUOA926tYNsoqWprGjEP2oKuOG20nTEAtLdhWpB1A=; b=FjFlFUHE5GjtUxbbuGFl13YxHW PUylDQhIyFIZvcg9OXabIZEleOzSGGi/OO+pMABzymi46jkTNpzWLt4VGgNCurDCW+7g09H3wtjut dHQkRdQRIv000CTX8Z4vDIUyF0CLsS7x4gXj16DVSpYj6FbrbJ4mcr/ZNyrIa6YEEpuE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173336: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=46452d3786a82bd732ba73fb308ae5cbe4e1e591 X-Osstest-Versions-That: linux=a1375562c0a87f0fa2eaf3e8ce15824696d4170a From: osstest service owner Date: Tue, 27 Sep 2022 22:21:45 +0000 flight 173336 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173336/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173326 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173326 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173326 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173326 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173326 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173326 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173326 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173326 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 46452d3786a82bd732ba73fb308ae5cbe4e1e591 baseline version: linux a1375562c0a87f0fa2eaf3e8ce15824696d4170a Last test of basis 173326 2022-09-27 05:45:59 Z 0 days Testing same since 173336 2022-09-27 14:42:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Mark Brown Martin Povišer Oder Chiou Pierre-Louis Bossart Shengjiu Wang SJLIN0 Takashi Iwai Wallace Lin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git a1375562c0a8..46452d3786a8 46452d3786a82bd732ba73fb308ae5cbe4e1e591 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Sep 27 22:48:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 22:48:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413012.656489 (Exim 4.92) (envelope-from ) id 1odJMr-0006oD-By; Tue, 27 Sep 2022 22:47:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413012.656489; Tue, 27 Sep 2022 22:47:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odJMr-0006o6-9J; Tue, 27 Sep 2022 22:47:57 +0000 Received: by outflank-mailman (input) for mailman id 413012; Tue, 27 Sep 2022 22:47:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odJMp-0006o0-Ln for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 22:47:55 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6bdca904-3eb6-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 00:47:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7FDF61BBD; Tue, 27 Sep 2022 22:47:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7624CC433C1; Tue, 27 Sep 2022 22:47:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bdca904-3eb6-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664318872; bh=zeELk7xar18qPrqlqm4D+GPKvdAP7Bc4vG0Nu9Ixlj8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TVCr27eqennulMFbet5RzZVWaMg4BHEoFf0NJwF2VDjbFS2n6uxxzP55MsJ3GtIB6 dGwCPOQNvQrJoM8sMKhOh24UiBGnrBpaPtI5ymrw/KgLu90gwfXItpq3Rgnl/HxY7C XYFwL0ZoJ/F1mF6650XAzj49OPv0f17NFZcg0gCmBqxeOMEESEv0DYfma4thK4qz6q P8TVvBfhCEp7Z7i0IKgypmCGe+71laulTc7bq/bhg/AGXBrWefj6xgRDcVuCqqqFjP Okwew2iVtASUEME9VpX6N91Bk2S7vMLa2mUH5jJutPfsADzOuNcW9MUEPBDWX9MEBg Ksx72vjVktwpA== Date: Tue, 27 Sep 2022 15:47:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Henry Wang Subject: Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test In-Reply-To: <20220926130213.28274-1-andrew.cooper3@citrix.com> Message-ID: References: <20220926130213.28274-1-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 26 Sep 2022, Andrew Cooper wrote: > buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch > which is relevant to CONFIG_XEN_IBT in 4.17 and later. > > Force it on, rather than having 50% of the jobs not testing what they're > supposed to be testing. > > Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible") > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Henry Wang > > For 4.17: This is bugfix to CI only, to avoid it producing a false negative. > Currently, the test intermittently fails to spot the error it was intended to > identify. It is very low risk as far as the 4.17 release goes. Thanks for the patch! Very recently Michal has added a similar EXTRA_XEN_CONFIG option. If you are OK with it, I'll rename EXTRA_FIXED_RANDCONFIG to EXTRA_XEN_CONFIG in this patch for consistency. I can do it on commit. > https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/3084774561#L373 for > proof that CONFIG_XEN_IBT=y is being fed into allrandom.config > --- > automation/gitlab-ci/build.yaml | 2 ++ > automation/scripts/build | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 720ce6e07ba0..65e06c858ef3 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -299,6 +299,8 @@ debian-buster-gcc-ibt: > variables: > CONTAINER: debian:buster-gcc-ibt > RANDCONFIG: y > + EXTRA_FIXED_RANDCONFIG: | > + CONFIG_XEN_IBT=y > > debian-unstable-clang: > extends: .clang-x86-64-build > diff --git a/automation/scripts/build b/automation/scripts/build > index 2f15ab3198e6..2d9dd86df904 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -12,6 +12,11 @@ cc-ver() > > # random config or default config > if [[ "${RANDCONFIG}" == "y" ]]; then > + > + # Append job-specific fixed configuration > + [[ -n "${EXTRA_FIXED_RANDCONFIG}" ]] && > + echo "${EXTRA_FIXED_RANDCONFIG}" >> xen/tools/kconfig/allrandom.config > + > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > hypervisor_only="y" > else > -- > 2.11.0 > From xen-devel-bounces@lists.xenproject.org Tue Sep 27 23:17:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 23:17:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413017.656500 (Exim 4.92) (envelope-from ) id 1odJp6-0001im-Km; Tue, 27 Sep 2022 23:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413017.656500; Tue, 27 Sep 2022 23:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odJp6-0001if-I9; Tue, 27 Sep 2022 23:17:08 +0000 Received: by outflank-mailman (input) for mailman id 413017; Tue, 27 Sep 2022 23:17:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odJp0-0001iZ-Fe for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 23:17:07 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d1813ce-3eba-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 01:17:00 +0200 (CEST) Received: from zn.tnic (p200300ea9733e7ee329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ee:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 732D21EC0426; Wed, 28 Sep 2022 01:16:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d1813ce-3eba-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664320615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=BsS2yAAp8a7eteydGjz/1IIbcCWf8fm6O9bJHVnMIgE=; b=MDAqIYvETvvwwVfPadefvCT9E+d7+i9sxLo6dDkj6g/t1gln+Ku8fF14E8fBM8W7T/0vla 3AR8k+QlxFLx1Uf0QzANuyU5aIlg8QG0tkFNTzBqUsWwqwERemmu96QmVorvJr3SDA8XHU b4cizwfQvMC9A+15M/lhgR8yDrnvnbI= Date: Wed, 28 Sep 2022 01:16:50 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> On Tue, Sep 27, 2022 at 02:21:17PM +0200, Juergen Gross wrote: > So replacing the bool with "(system_state != SYSTEM_RUNNING)" is fine > with you right now? We can later switch that to the "more elegant" > solution when it shows up. Ok, I think I have something. And it was staring me straight in the face but I didn't see it: the MTRR code needs a hotplug notifier. In that notifier it can do the immediate, i.e., non-delayed init while the delayed init becomes the default, see below. And ignore the pr_info debugging gunk pls. mtrr_ap_init() becomes the notifier callback. It doesn't need to be called in identify_secondary_cpu() anymore as in the init case that function doesn't do anything - delayed=true - and in the hotplug case the notifier runs. mtrr_aps_init() - "aps" in plural - does the delayed init after all CPUs have been brought online after the box has booted. That might need some renaming. And yes, there's a lot more to cleanup after this. This code has grown wart after wart over the years... Fun. --- diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 76d726074c16..1a3dad244bba 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -42,8 +42,6 @@ extern int mtrr_add_page(unsigned long base, unsigned long size, extern int mtrr_del(int reg, unsigned long base, unsigned long size); extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); -extern void mtrr_ap_init(void); -extern void set_mtrr_aps_delayed_init(void); extern void mtrr_aps_init(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); @@ -83,8 +81,6 @@ static inline int mtrr_trim_uncached_memory(unsigned long end_pfn) static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) { } -#define mtrr_ap_init() do {} while (0) -#define set_mtrr_aps_delayed_init() do {} while (0) #define mtrr_aps_init() do {} while (0) #define mtrr_bp_restore() do {} while (0) # endif diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 3e508f239098..deef1b5b27cc 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1948,7 +1948,6 @@ void identify_secondary_cpu(struct cpuinfo_x86 *c) #ifdef CONFIG_X86_32 enable_sep_cpu(); #endif - mtrr_ap_init(); validate_apic_and_package_id(c); x86_spec_ctrl_setup_ap(); update_srbds_msr(); diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 2746cac9d8a9..abbf7cb8a430 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -69,7 +69,6 @@ unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; static DEFINE_MUTEX(mtrr_mutex); u64 size_or_mask, size_and_mask; -static bool mtrr_aps_delayed_init; static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; @@ -176,7 +175,7 @@ static int mtrr_rendezvous_handler(void *info) if (data->smp_reg != ~0U) { mtrr_if->set(data->smp_reg, data->smp_base, data->smp_size, data->smp_type); - } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { + } else if (!cpu_online(smp_processor_id())) { mtrr_if->set_all(); } return 0; @@ -784,13 +783,16 @@ void __init mtrr_bp_init(void) } } -void mtrr_ap_init(void) +static int mtrr_ap_init(unsigned int cpu) { + pr_info("%s: single AP entry, use_intel: %d, mtrr_enabled: %d, mtrr_aps_delayed_init\n", + __func__, use_intel(), mtrr_enabled()); + if (!mtrr_enabled()) - return; + return 1; - if (!use_intel() || mtrr_aps_delayed_init) - return; + if (!use_intel()) + return 1; /* * Ideally we should hold mtrr_mutex here to avoid mtrr entries @@ -806,6 +808,8 @@ void mtrr_ap_init(void) * lock to prevent mtrr entry changes */ set_mtrr_from_inactive_cpu(~0U, 0, 0, 0); + + return 0; } /** @@ -820,37 +824,24 @@ void mtrr_save_state(void) return; first_cpu = cpumask_first(cpu_online_mask); - smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); -} -void set_mtrr_aps_delayed_init(void) -{ - if (!mtrr_enabled()) - return; - if (!use_intel()) - return; + pr_info("%s: first_cpu: %d\n", __func__, first_cpu); - mtrr_aps_delayed_init = true; + smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); } /* - * Delayed MTRR initialization for all AP's + * Delayed MTRR initialization for all APs */ void mtrr_aps_init(void) { - if (!use_intel() || !mtrr_enabled()) - return; + pr_info("%s: entry, use_intel: %d, mtrr_enabled: %d, mtrr_aps_delayed_init\n", + __func__, use_intel(), mtrr_enabled()); - /* - * Check if someone has requested the delay of AP MTRR initialization, - * by doing set_mtrr_aps_delayed_init(), prior to this point. If not, - * then we are done. - */ - if (!mtrr_aps_delayed_init) + if (!use_intel() || !mtrr_enabled()) return; set_mtrr(~0U, 0, 0, 0); - mtrr_aps_delayed_init = false; } void mtrr_bp_restore(void) @@ -869,6 +860,10 @@ static int __init mtrr_init_finialize(void) if (use_intel()) { if (!changed_by_mtrr_cleanup) mtrr_state_warn(); + + cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, "x86/mtrr:online", + mtrr_ap_init, NULL); + return 0; } diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index f24227bc3220..171acef35201 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1428,7 +1428,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) uv_system_init(); - set_mtrr_aps_delayed_init(); + pr_info("%s: set_mtrr_aps_delayed_init\n", __func__); smp_quirk_init_udelay(); @@ -1439,7 +1439,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) void arch_thaw_secondary_cpus_begin(void) { - set_mtrr_aps_delayed_init(); + pr_info("%s: set_mtrr_aps_delayed_init\n", __func__); } void arch_thaw_secondary_cpus_end(void) diff --git a/kernel/cpu.c b/kernel/cpu.c index bbad5e375d3b..fc14601b908c 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -591,6 +591,8 @@ static int bringup_cpu(unsigned int cpu) struct task_struct *idle = idle_thread_get(cpu); int ret; + pr_info("%s: CPU%d\n", __func__, cpu); + /* * Reset stale stack state from the last time this CPU was online. */ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Sep 27 23:23:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 27 Sep 2022 23:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413025.656512 (Exim 4.92) (envelope-from ) id 1odJvK-0003D3-EA; Tue, 27 Sep 2022 23:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413025.656512; Tue, 27 Sep 2022 23:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odJvK-0003Cw-BV; Tue, 27 Sep 2022 23:23:34 +0000 Received: by outflank-mailman (input) for mailman id 413025; Tue, 27 Sep 2022 23:23:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odJvJ-0003Cq-9t for xen-devel@lists.xenproject.org; Tue, 27 Sep 2022 23:23:33 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63fc3502-3ebb-11ed-9648-05401a9f4f97; Wed, 28 Sep 2022 01:23:30 +0200 (CEST) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Sep 2022 19:23:26 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW5PR03MB6878.namprd03.prod.outlook.com (2603:10b6:303:1c8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 23:23:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.027; Tue, 27 Sep 2022 23:23:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63fc3502-3ebb-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664321010; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=e1Yj/OR6wUofZ6oxF8HJMJwNFT/G5tVRxSxKLfX+1u8=; b=YEh7/HW57RNaWfBzDG/iUq7u3xiCHRaP5G/NF70vClYp2i4njilK7N1Z 8aFSowurX9+1YNNwfdy5QniqqpDL5ISlVF+txuTh+XJs/q/JFfUfr/s0O tXZ/Uc+8NMzVBj8SQoY/w3JN8oRrKZhByetRHBUThM0H59PMYOtrboEaE 0=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 81473564 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Vj6IOq/xdvnYbASdV2RjDrUDRn+TJUtcMsCJ2f8bNWPcYEJGY0x3m zFJX26HaPqCMzOheIt+PNjioxhSupXTyIJnHVZsri48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvnrRC9H5qyo4mtJ5ANmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rt+HyJV0 uAjEmEmNBbahLKO57y6cvY506zPLOGzVG8ekldJ6GiDSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujeNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8efxH+kA99MSNVU8NZ0i3u9lk0MVSRHflGk/dKnyUiOfPxAf hl8Fi0G6PJaGFaQZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq1/b6OoTS/ESMcN2MFaGkPSg5ty/nuppsiyC3GSNlLGbSwyNbyHFnNL yuiqSE/g/AZi54N3qDip1Tf2Wvz+N7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lRdlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:JHHFYqmwHI2y03lz1NGEHiP43+bpDfID3DAbv31ZSRFFG/Fwz/ re+8jy1XfP5wr5K0tQ/+xoWZPwOk80mqQFgrX5UY3OYOCighrNEGgA1/qZ/9SDIVydygc178 4JGMJD4Z/LfD1HZK3BjjVQZuxB/DDxysGVbInlo0uEkWlRGtxdBkxCe3+m+wVNNXF7OaY= X-IronPort-AV: E=Sophos;i="5.93,350,1654574400"; d="scan'208";a="81473564" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5lf/Ns9Tl9UIfu+C4MwAw/AQa0b2vIUxjL917jUuLruve8HdwJ9m9IyqEtP1Jn9XFG4FslKPmSiMeWB9d7wjQ56khyCXi90MEJrXS2+iEB1nFYffbM+EQoBe2WF1Xa2y+ipb1O4xuaMmZBLUMmARNxcm2pvSyQdh4r87tHzRNMHSx9FZdjAN5kVe8KxEI38x9AWsmdVXfe3YYAFtOykL07Wj53HU8Sc+u4vhqvSsXUw2QikvzIP5HnE1UrYFUilk4DfeMfwCvHB21GLq1TLJ5FvD58yOeUhG49IEzcenqUqaqXxNpgPif30gRnRONlalOtR52mes0oPwOeg3T6peQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e1Yj/OR6wUofZ6oxF8HJMJwNFT/G5tVRxSxKLfX+1u8=; b=PWBI6HsOnabg8YOElBWjcyEtr5moAZagv+VXFlDfmwsyCpbTy3qJD8g/76qVzHxnu/C3QGg6VVbm6w8Bft46kw81E2LR/dsC1Dxk5t9st4s9DFIhFKT2G7Y/5L6NGKYgr0h57bk5yks1IcuXNwk8ud/IuwGyYQklUhF7wEZIhhZ0IAMhEmtXDArI7A7wPTPKstmW+LoBtVBuJmaYLqn+9nhqBKDOVNpcr9/z7EOEGsemYjIkvWbsLtpDcLYlZBg5+CXkzys2t6VFR+X+AWPXGmOKX0zZ1smGgb7ImAyylScHDc+DyfxJdQNKvTcPZLP5Off8qgnTYIeyOXOKXYEC5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e1Yj/OR6wUofZ6oxF8HJMJwNFT/G5tVRxSxKLfX+1u8=; b=ql20yN8CaZR0NMTwCE7gPY5l6OjZHbzjYfJMkZBFZF0ECIJ/hyzueh80OD6PatHlIh174vpPRcOZYOp/ajCNSkjHJ3p87nVBc3TYk14SnXyUro75z/3wIRiQaGgN/nBguJQzjto+hBcoYmG3gTOfyUNDt32gyHfGp8UlEZAHpPE= From: Andrew Cooper To: Stefano Stabellini CC: Xen-devel , Doug Goldstein , Henry Wang Subject: Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Thread-Topic: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test Thread-Index: AQHY0ahGyNiffGBomUWUhynqT69//63z4wWAgAAJ64A= Date: Tue, 27 Sep 2022 23:23:20 +0000 Message-ID: <29effece-f467-0763-9b88-85d0eba076a1@citrix.com> References: <20220926130213.28274-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW5PR03MB6878:EE_ x-ms-office365-filtering-correlation-id: 914738a8-6000-483b-e953-08daa0df43d9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vSt1J/lhPn2IF72NiZuRjlqaTOQR5GQeF9cP8EHb8rjuMHUcUG1f5DZ4IFQvVlhER9j6zuXztNYfbLr4MRupVzZmExgK6Q9UcMvyhaEGkRQJArfu49YaC5A8yQPj4r9R4ww40elqU+xnHkmEBJKKW/3Nj2Nz0FOdNKOQqcgKRNR4JqmF7LNKIvFfMtyN0e1r/lorzqzkRZoy0b2EjUCNHMixrD92PvnhJZxko+3l+/q4FPSDK7XEjmPzT2+XxIgckAu4KpEufHqYsFVamNQ2890C1JdQ4AUVRWIUGfLNoJsFYW2b/edDuLAzp1v05bdu3B8NYG6U55r6QHQbFciWpcGsWbF/bEjlI/n39iy+b5it/rrz7K31TN+4RvZ9MGlBwpPmQB3xV2DruAtaVyhcaYUhhJoWCE6tfF7Eh6J7ZSb8kfbYxt10SsaJFm+1XDt1ZZqWAMsAAe3eXvcNZfRompq3D1DGqdpSigQr34lH4ibrqm8JtkGJASIjrVRUFvtblOBX4Z9hDOs6x8P77ET+jOnXTYrEcgT9Gj5iuxn3hfmxW53dRSwN1NEJNagWTGHj/SMkii8joRJUnAY+OAQJZk2bEkoKT9YeJiA2vbP2bWvLN7w2jNGmjwD6z0AvOrwCj4PVdvtq9+yOoCDIZVHbYy5gi0qvAflf46grR7xC/mjfmXuZeAgYFtEFyW4L73o6zbgYwItF1LMDNVjhjbYns1eEewhWAILWUyfi9ZvN9qjAn97dsDWQ+n+ot+RyNuO0+Ny/yn4mMpDmwdXYhbtL1aJkZJ/j8OFuHHTNKyMbdeBI9keN1ks28djhPWp43R5GJM9PNPS8hJO3yq88JqnyOw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(31686004)(38070700005)(6486002)(71200400001)(6916009)(478600001)(82960400001)(316002)(54906003)(66446008)(26005)(66476007)(91956017)(186003)(122000001)(4326008)(64756008)(38100700002)(66946007)(8676002)(76116006)(66556008)(2906002)(41300700001)(6512007)(5660300002)(86362001)(36756003)(83380400001)(2616005)(6506007)(31696002)(53546011)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aGJZT3dXY0g5N2dRTEM0aVhxOXVsaXQ3RHF6TE5tSUJlMlVsbTFheXVoakQr?= =?utf-8?B?cGF3NDltRERtVkFpSGRhWjU4VjYvRkdaTnVUeDE5MkZtL2RTamhrZjg0WWk4?= =?utf-8?B?MTVzR0U1M1BXK2xSUjhGdUl6UEovOFNYSU5NenE1WEZRZXNLYnh3UEVVeDJU?= =?utf-8?B?VHcrdmNlL0c5N0k0dTdmT0U2N2R3djlmRXZacFY2WWlmK1JuUE9uTVdsc0dy?= =?utf-8?B?MW5Vd3FncVlDM1JyTlRNS3hXdTRjOXNBSkxCL0lPRHczNkZac2NJSGwxdlEy?= =?utf-8?B?L3pvWmJoRytzN3B4Qm9pOSsxeHZ2bC9ONGRjOUs3cnFnZ0NKYisxeUxOdVNY?= =?utf-8?B?QjVnSG12RWNUb2ZYWUhGcHVXNU1jWFFnU1ROUHZNVVg0ZjBkd3UzUU00b3RN?= =?utf-8?B?VXY3aitmZzhmRGczbVFxL1RMNVNJQW5NaUdOcXdVemxwL21XQlN0cnZyb1Jt?= =?utf-8?B?clpmZGZlbTg4Z2pkYUF6NDRwL2dxem45dU1sOTREUW03WEpybnBpKzZka0ZH?= =?utf-8?B?TWd3ZmtGTDF4SS85N2kxaE1CY3hQT0lhY080MDVzZU4wMXVrOWxFck5ENzJH?= =?utf-8?B?c2ZsRTRSNEp5K2I4TTY0dmk3azRLSGdyUHgxUnNBQVBGRnBtY2lxMm1jdmFm?= =?utf-8?B?ck5kMHBmVlg5T0hDditaRlpuZ0g0dGU0VkZZSWszQ1NsSys4MWkyeW44d2x5?= =?utf-8?B?MFJFMmtpaDNMdVFCYTJzMTZYb0crOXA5QVpCaHVRSnp4bHpNTVZPR01vMVh4?= =?utf-8?B?VHFWZXB6OVhYelFCaEVSV0ZNcTBQZUR2dk1BcVBDR3BNZ1dUcU4zcmxpczZL?= =?utf-8?B?TVh4aGZBNjQxUHdwUVZPRTFyejFyRnk3eC9QTDBvVWRVckM4ZWQ0SVNPcXlp?= =?utf-8?B?N21IZmVoYzhIakRzMS9NcjM2czRKUHZnemdieUwrWGt2V3hWZS9JcDlXcFRX?= =?utf-8?B?VGhxdWswSjZZaXViYVJFYVM2QzVzWlQ0eGtZMXgvUnZzTUNjUW1BcFNHUFNG?= =?utf-8?B?djM2YVVGSjNxVEl1YjI5YytmTzh2aTJWWHRoUmZud093dlluU0pteitRaUkz?= =?utf-8?B?cWNBb25JamRrc21WU1crSENvR2lVY2Y2Wlk0alk4M1diK3R5dlVnSnNqRXZG?= =?utf-8?B?OEJxQk56R1pQRjhobThHdG5ienpLaHpqbEc4VWlXWWtrUk1sckg1VlMwNmtT?= =?utf-8?B?VTc0RFpEdzRBYmcrekxCUlNiWU0vR3IxWHRTT0Qya1lCWnBndlY0VThWeml1?= =?utf-8?B?Nm90TitmM0pkOFhIT3pKMzhTVU91VnM3RGoyYmQ1QjdRQlpKWDFSdVlBeFY0?= =?utf-8?B?VHhYT284aFZCVi9xUTVIVzcrdGZLV3Yrd0NWcGdqSWttVG5BTGtmckp2S3ov?= =?utf-8?B?MVEyM2RhRWhFYTFFZk13cGV0MTk1WGFzb2lsbFpqYlFLL1Q3czJTelNXbkg0?= =?utf-8?B?S2VTcmphUHlxSTNHcGxDSFZhbzlhVTdJMlZKR0wyVmVSbUlGYXY5VkREM3ZF?= =?utf-8?B?b3NOeERtdTQyRzNHN2FkUEVPVVRjTG8yekRsaVJwelFxWm53UVBVNTQ0VmEw?= =?utf-8?B?ZWJBUHQ0SEJBNzB6SUdLSjJXc0NwcUdGNHVEakdDTEpwTERFaWxmV1hRY0RM?= =?utf-8?B?cFdUNW5TRmZjMCtXVzhRZ1B1UWdKelJWZjBwRzdpbmFEZG80d0FkcmVDbHNQ?= =?utf-8?B?NEN0MmRzNXpEbCtYWGNMc0FXQkJSWExmMVpYR1BmS281THRzelZoclVUYjRn?= =?utf-8?B?OTFVYk5lQUpWZVlqMVNydk9WS1V5RVpPbnJoUEdWSWluWjVPYnJEQkwvVzhF?= =?utf-8?B?VkZwZUtNVkRXV01BMUdlK3dkYWd5d09hbEFIbkVoT2cwdjg2WlFwZm9mYXhP?= =?utf-8?B?K0dkNHlPczVvTnFDY2RZVEJuQndrdGJzNHY1NTRxR0pySThZVm5Gb0doRDlT?= =?utf-8?B?T09xVitVRmVLVXBNMG1ONjRnMHUrOGVhNHB3UzlNL1hMVXBTRjB1bng0TlNt?= =?utf-8?B?N3VubFBZaWVSMUdvbTBQLzhHMWdJNjBvV3RLdDlUVWFUcEx4Q0Rtdk5MK3ZG?= =?utf-8?B?MjQ0VmRDM3I5MXQzU0x1dTBDMlBGaVBublREL2FienVjQUZ2SzJ4Uy9XUkdk?= =?utf-8?Q?fzPoyhiGbFJgoFpAajNw6WaC0?= Content-Type: text/plain; charset="utf-8" Content-ID: <134BDDDBBAB3ED44AC0BF4D750AC1E31@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 914738a8-6000-483b-e953-08daa0df43d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 23:23:20.2539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1AIL7I/5H55E3zYKjQEDbXyVZ+COVBqikts0nPePPgXBEY6RMsHz6c1u/APpGjHYzLkMny5HI6NgNZhPngTAgKsu6BdKrmkFHG7LpBstxlc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6878 T24gMjcvMDkvMjAyMiAyMzo0NywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiBPbiBNb24s IDI2IFNlcCAyMDIyLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gYnVzdGVyLWdjYy1pYnQgaXMg YSBkZWRpY2F0ZWQgdGVzdCB0byBydW4gYSBub3QteWV0LXVwc3RyZWFtZWQgY29tcGlsZXIgcGF0 Y2gNCj4+IHdoaWNoIGlzIHJlbGV2YW50IHRvIENPTkZJR19YRU5fSUJUIGluIDQuMTcgYW5kIGxh dGVyLg0KPj4NCj4+IEZvcmNlIGl0IG9uLCByYXRoZXIgdGhhbiBoYXZpbmcgNTAlIG9mIHRoZSBq b2JzIG5vdCB0ZXN0aW5nIHdoYXQgdGhleSdyZQ0KPj4gc3VwcG9zZWQgdG8gYmUgdGVzdGluZy4N Cj4+DQo+PiBGaXhlczogNWQ1OTQyMTgxNWQ1ICgieDg2OiBVc2UgY29udHJvbCBmbG93IHR5cGVj aGVja2luZyB3aGVyZSBwb3NzaWJsZSIpDQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVy IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4gLS0tDQo+PiBDQzogRG91ZyBHb2xkc3Rl aW4gPGNhcmRvZUBjYXJkb2UuY29tPg0KPj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4NCj4+IENDOiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ DQo+Pg0KPj4gRm9yIDQuMTc6IFRoaXMgaXMgYnVnZml4IHRvIENJIG9ubHksIHRvIGF2b2lkIGl0 IHByb2R1Y2luZyBhIGZhbHNlIG5lZ2F0aXZlLg0KPj4gQ3VycmVudGx5LCB0aGUgdGVzdCBpbnRl cm1pdHRlbnRseSBmYWlscyB0byBzcG90IHRoZSBlcnJvciBpdCB3YXMgaW50ZW5kZWQgdG8NCj4+ IGlkZW50aWZ5LiAgSXQgaXMgdmVyeSBsb3cgcmlzayBhcyBmYXIgYXMgdGhlIDQuMTcgcmVsZWFz ZSBnb2VzLg0KPiBUaGFua3MgZm9yIHRoZSBwYXRjaCEgVmVyeSByZWNlbnRseSBNaWNoYWwgaGFz IGFkZGVkIGEgc2ltaWxhcg0KPiBFWFRSQV9YRU5fQ09ORklHIG9wdGlvbi4NCg0KSSBrbm93IC0g dGhhdCdzIHdoZXJlIEkgc3RvXlcgYm9ycm93ZWQgdGhlIGlkZWEgZnJvbS4NCg0KPiBJZiB5b3Ug YXJlIE9LIHdpdGggaXQsIEknbGwgcmVuYW1lDQo+IEVYVFJBX0ZJWEVEX1JBTkRDT05GSUcgdG8g RVhUUkFfWEVOX0NPTkZJRyBpbiB0aGlzIHBhdGNoIGZvcg0KPiBjb25zaXN0ZW5jeS4gSSBjYW4g ZG8gaXQgb24gY29tbWl0Lg0KDQpObywgdGhhdCB3aWxsIGJyZWFrIHRoZSBmaXguDQoNClRoZXNl IGFyZSBub3Qgb3B0aW9ucyB0byBiZSBpbnNlcnRlZCBpbnRvIGEgcmVndWxhciAuY29uZmlnLg0K DQpUaGVzZSBhcmUgb3B0aW9ucyBwYXNzZWQgdG8gYG1ha2UgcmFuZGNvbmZpZ2AgdmlhIGEgc2lk ZWRvb3IgKHRoZQ0KS0NPTkZJR19BTExDT05GSUc9IHZhcmlhYmxlKSBjYXVzaW5nIHRoZW0gdG8g YmUgaGFuZGxlZCBzcGVjaWFsbHkgd2hpbGUNCnRoZSByZWd1bGFyIC5jb25maWcgZmlsZSBpcyBo YXMgaXQncyBjb250ZW50cyByYW5kb21pc2VkLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 28 00:30:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 00:30:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413072.656552 (Exim 4.92) (envelope-from ) id 1odKxd-0002sz-Bt; Wed, 28 Sep 2022 00:30:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413072.656552; Wed, 28 Sep 2022 00:30:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKxd-0002sr-7c; Wed, 28 Sep 2022 00:30:01 +0000 Received: by outflank-mailman (input) for mailman id 413072; Wed, 28 Sep 2022 00:30:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKxc-0002cG-DA for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 00:30:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aec6a5f0-3ec4-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 02:29:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E0E161C14; Wed, 28 Sep 2022 00:29:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DF66C433D6; Wed, 28 Sep 2022 00:29:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aec6a5f0-3ec4-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664324997; bh=8TGSMLeg/MbeYf6qeKqB64NxPViVdqiDJeTw5wrJfC4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pvDpqqbhoRhw5mUIqpi8jLuWzK9Ev2Z6nlzRLCRZu5MN/LzVvXwU3kVG/La86dRfq SFoA48yRfcSt0xsarnYYa+rwxRI6cpg6lXauYbn9Nc4RQM7oiFB+Z/ASMrvzbYb6jV 8vSD8C9Ki80teJqe+bIl3HSLNYsjkoNTiwTYbk9BF80jNgVOUwTrrlhUx3/RGXHW35 pJKMjW1dKGq7KMM9bBAq2x2TX5zm/nMSx/87bnqF5hWhPvqyZozNuTUFr93H2/UVAv hilJR/aFc7HYHMQCRwJIPxzkNJS5Jx3leCpldf0ycTuq5fnQADoMn3KT1FfdAsDUbG a8wgZfAL+bKcg== Date: Tue, 27 Sep 2022 17:29:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v3 07/10] automation: qemu-alpine-arm64: Cleanup and fixes In-Reply-To: <20220927094727.12762-8-michal.orzel@amd.com> Message-ID: References: <20220927094727.12762-1-michal.orzel@amd.com> <20220927094727.12762-8-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 27 Sep 2022, Michal Orzel wrote: > Perform the following cleanup: > - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version > used in this test is v2, > - use fdtput to perform modifications on the dtb, > - use DEBIAN_FRONTEND=noninteractive to prevent interactive prompt being > stuck waiting for answer other than "yes", > - fix the number of cpus in the device tree because currently we generate > it with a single cpu and try to run QEMU with two, > - fix the memory size we pass when generating QEMU device tree as it does > not match the memory size with what we run QEMU. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini I pushed patches 2-10 to a "next" branch on my personal gitlab with the intention of merging it back as soon as staging reopens: https://gitlab.com/xen-project/people/sstabellini/xen > --- > Changes in v3: > - s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/, drop Ack > Changes in v2: > - none > --- > automation/scripts/qemu-alpine-arm64.sh | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/automation/scripts/qemu-alpine-arm64.sh b/automation/scripts/qemu-alpine-arm64.sh > index f4ac2d856fa0..9004c537e325 100755 > --- a/automation/scripts/qemu-alpine-arm64.sh > +++ b/automation/scripts/qemu-alpine-arm64.sh > @@ -2,6 +2,7 @@ > > set -ex > > +export DEBIAN_FRONTEND=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends u-boot-qemu \ > u-boot-tools \ > @@ -73,18 +74,17 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -display none \ > - -machine dumpdtb=binaries/virt-gicv3.dtb > + -m 2048 -smp 2 -display none \ > + -machine dumpdtb=binaries/virt-gicv2.dtb > + > # XXX disable pl061 to avoid Linux crash > -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts > -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts > -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb > +fdtput binaries/virt-gicv2.dtb -p -t s /pl061@9030000 status disabled > > # ImageBuilder > echo 'MEMORY_START="0x40000000" > -MEMORY_END="0x80000000" > +MEMORY_END="0xC0000000" > > -DEVICE_TREE="virt-gicv3.dtb" > +DEVICE_TREE="virt-gicv2.dtb" > XEN="xen" > DOM0_KERNEL="Image" > DOM0_RAMDISK="xen-rootfs.cpio.gz" > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 28 00:30:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 00:30:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413071.656541 (Exim 4.92) (envelope-from ) id 1odKxX-0002cW-2B; Wed, 28 Sep 2022 00:29:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413071.656541; Wed, 28 Sep 2022 00:29:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKxW-0002cP-Vd; Wed, 28 Sep 2022 00:29:54 +0000 Received: by outflank-mailman (input) for mailman id 413071; Wed, 28 Sep 2022 00:29:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKxV-0002cG-Hp for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 00:29:53 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa36d0e6-3ec4-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 02:29:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5FD22B81E65; Wed, 28 Sep 2022 00:29:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59383C433C1; Wed, 28 Sep 2022 00:29:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa36d0e6-3ec4-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664324989; bh=A5gWXxyFMs6hBEqdo7NTfR+D4W6n8OIuPpoPtwEiuYM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=eKRaxcf60YEh08oJTZ131D+5lmpdcwUKdcrNwwVlKZtgWhNPjUGGFQTov9zYOUBp9 7L40io48XWC8J46/hq97OQdKp2qykGQZ+1UfHRm/wEDAcvmwXd2JybUFlA9L0+Gyrq sSayn1jN0nA43kiuREGpQ6tMSOpyxD/bJV9XavmlEL7SCoO0qfwvyZznrLyny8gtgl iZ24y3mesRB7mXlX35YUjAm3u21ha2gwi9w/5XcqB9aRz8QMNVy2ymLqt70WWIW7ZO xcC4qb+yvGZKBp8nLryb4K5jvlDyQ0VjAeNL3+zCEZobc5mN3r+GH4dqtfvZ4YWEkN Fu5oFcWApwppQ== Date: Tue, 27 Sep 2022 17:29:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Henry Wang Subject: Re: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT In-Reply-To: <20220927094727.12762-2-michal.orzel@amd.com> Message-ID: References: <20220927094727.12762-1-michal.orzel@amd.com> <20220927094727.12762-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 27 Sep 2022, Michal Orzel wrote: > The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini and committed > --- > CC: Henry Wang > > Rationale for taking this patch for 4.17: > Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interaction > while installing/upgrading the system via apt-get. It accepts the default > answer to all the questions (using apt-get -y only works for "yes"/"no" > prompts). With the typo not fixed, we might get stuck in CI jobs. > The risk is very low as we perform pre-push testing using GitLab CI to make > sure the changes will not break the pipeline. > > Changes in v3: > - new patch > --- > automation/scripts/qemu-smoke-arm32.sh | 2 +- > automation/scripts/qemu-smoke-arm64.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh > index 530f3892fdd3..c8ae0bfb9b1c 100755 > --- a/automation/scripts/qemu-smoke-arm32.sh > +++ b/automation/scripts/qemu-smoke-arm32.sh > @@ -2,7 +2,7 @@ > > set -ex > > -export DEBIAN_FRONTENT=noninteractive > +export DEBIAN_FRONTEND=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends device-tree-compiler \ > curl \ > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index f803835779f4..5b566072f72a 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -38,7 +38,7 @@ fi > " > fi > > -export DEBIAN_FRONTENT=noninteractive > +export DEBIAN_FRONTEND=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends u-boot-qemu \ > u-boot-tools \ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Sep 28 00:30:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 00:30:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413073.656563 (Exim 4.92) (envelope-from ) id 1odKxq-00041B-J4; Wed, 28 Sep 2022 00:30:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413073.656563; Wed, 28 Sep 2022 00:30:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKxq-000414-Fo; Wed, 28 Sep 2022 00:30:14 +0000 Received: by outflank-mailman (input) for mailman id 413073; Wed, 28 Sep 2022 00:30:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKxp-000402-Jj for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 00:30:13 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b65a935d-3ec4-11ed-9648-05401a9f4f97; Wed, 28 Sep 2022 02:30:11 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3FABB81E5E; Wed, 28 Sep 2022 00:30:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDC45C433C1; Wed, 28 Sep 2022 00:30:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b65a935d-3ec4-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664325009; bh=Kz1u6W41ONKpo4gKhBwKXkVb6c02chGyNhjn77IIkFY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TUz/594gZKhGIvS6hWk+N4FZzW2kfBaYY3ba0AssqpU5VD1FZnEjjNb9x3IFkkC9G r2owhI5bt8ZVd1ZmvL2ibsawi5MywjH/0omB/6OxO/QpOsNybVz1BjqxXvsV0JUO6d LxjPUg/7Uv7PBGyVJFLWr1q3xOUkkCRZdKsv0yfApGHWTHuBa1UeV2joYxqHY94JpK WwZbTeWxIRqDhhxP7HN8LywIWknRrSQvaD2TsJ4bAkDKuz27y6oUi0M+LR/iCI7zQf RZj+FZqXMoprOZh8QpDIKnV5dxj+qamXAG/LyhR4I8RBssxhq3ci/pb+qLUckoBMXQ tfPHgBebit8BA== Date: Tue, 27 Sep 2022 17:30:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Xen-devel , Doug Goldstein , Henry Wang Subject: Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test In-Reply-To: <29effece-f467-0763-9b88-85d0eba076a1@citrix.com> Message-ID: References: <20220926130213.28274-1-andrew.cooper3@citrix.com> <29effece-f467-0763-9b88-85d0eba076a1@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 27 Sep 2022, Andrew Cooper wrote: > On 27/09/2022 23:47, Stefano Stabellini wrote: > > On Mon, 26 Sep 2022, Andrew Cooper wrote: > >> buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch > >> which is relevant to CONFIG_XEN_IBT in 4.17 and later. > >> > >> Force it on, rather than having 50% of the jobs not testing what they're > >> supposed to be testing. > >> > >> Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible") > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Doug Goldstein > >> CC: Stefano Stabellini > >> CC: Henry Wang > >> > >> For 4.17: This is bugfix to CI only, to avoid it producing a false negative. > >> Currently, the test intermittently fails to spot the error it was intended to > >> identify. It is very low risk as far as the 4.17 release goes. > > Thanks for the patch! Very recently Michal has added a similar > > EXTRA_XEN_CONFIG option. > > I know - that's where I sto^W borrowed the idea from. > > > If you are OK with it, I'll rename > > EXTRA_FIXED_RANDCONFIG to EXTRA_XEN_CONFIG in this patch for > > consistency. I can do it on commit. > > No, that will break the fix. > > These are not options to be inserted into a regular .config. > > These are options passed to `make randconfig` via a sidedoor (the > KCONFIG_ALLCONFIG= variable) causing them to be handled specially while > the regular .config file is has it's contents randomised. OK. I committed your original plus a minor code style fix. From xen-devel-bounces@lists.xenproject.org Wed Sep 28 00:31:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 00:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413083.656573 (Exim 4.92) (envelope-from ) id 1odKzH-000506-Uu; Wed, 28 Sep 2022 00:31:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413083.656573; Wed, 28 Sep 2022 00:31:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKzH-0004zz-SA; Wed, 28 Sep 2022 00:31:43 +0000 Received: by outflank-mailman (input) for mailman id 413083; Wed, 28 Sep 2022 00:31:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odKzG-0004zo-Mf for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 00:31:42 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebc79e2e-3ec4-11ed-9648-05401a9f4f97; Wed, 28 Sep 2022 02:31:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F95761CCB; Wed, 28 Sep 2022 00:31:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8101C433C1; Wed, 28 Sep 2022 00:31:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebc79e2e-3ec4-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664325100; bh=WavEQmSW2PYlhzC+baaXFSiw7W8/lPPErAZ6wbKQVGc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Bi0BrAQ9HLVkVWCHvm/o1miRP7lYhte86qeJy1Vz+MvKnAhTy+FM5t74MVfLdIsWp tmNwU9QoH9RSX1Y82DjOKCkF5tQZjjG4EP9rPhpBZ3YhSsCt0a6bTwEa/42ixCwhG6 VjDrvxJIGJVS0aBlpcJ3hBiZw1D8FP20BAnarsc/R0e7tUyt3wGrvIZLOgQqnITQWr pvILJ7ovCg0I3sHNoYF+LFW8nUAM5M9nIC7F96VxSKPq0oLHuOD+DCgbBPhzJbP4DN 3y1qRkuaDf+xkP5I9tOIU2BOeyyWW/3NWTZODSbzjVoJFDT+WpV27I3giDpypgTNWG fliuO4dpYU3JQ== Date: Tue, 27 Sep 2022 17:31:37 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Wei Liu , Henry Wang , Julien Grall , Xen-devel Subject: Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS In-Reply-To: <2d8cc77d-073b-1de4-1ccf-43427529e470@suse.com> Message-ID: References: <20220927154708.15787-1-andrew.cooper3@citrix.com> <2d8cc77d-073b-1de4-1ccf-43427529e470@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 27 Sep 2022, Jan Beulich wrote: > On 27.09.2022 17:47, Andrew Cooper wrote: > > This breaks all Clang builds, as demostrated by Gitlab CI. > > > > Contrary to the description in ecd6b9759919, -no-pie is not even an option > > passed to the linker. GCC's actual behaviour is to inhibit the passing of > > -pie to the linker, as well as selecting different cr0 artefacts to be linked. > > > > EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to > > gain such a usecase. > > > > Signed-off-by: Andrew Cooper > > Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") > > Acked-by: Jan Beulich > > Perhaps the Reported-by: Stefano should be kept, even if you noticed > the issue as well? > > I would have preferred a mention of the questionable origin of the > earlier misspelled -nopie, but I guess I'm not going to insist. Tested-by: Stefano Stabellini and committed From xen-devel-bounces@lists.xenproject.org Wed Sep 28 01:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 01:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413099.656597 (Exim 4.92) (envelope-from ) id 1odM4x-0002Hs-79; Wed, 28 Sep 2022 01:41:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413099.656597; Wed, 28 Sep 2022 01:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odM4x-0002Hk-1t; Wed, 28 Sep 2022 01:41:39 +0000 Received: by outflank-mailman (input) for mailman id 413099; Wed, 28 Sep 2022 01:41:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odM4w-0002Ha-Ci; Wed, 28 Sep 2022 01:41:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odM4w-0007pD-A4; Wed, 28 Sep 2022 01:41:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odM4v-00087W-PL; Wed, 28 Sep 2022 01:41:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odM4v-0005sn-OS; Wed, 28 Sep 2022 01:41:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4VB6d8HE1OFmNFJVd9Oo1wwxSJ4/M6sz/V3bpt2cUaU=; b=1PH1pJ7Wte6U+PMYQ4cpLk8SrJ YHyV4PY6HS9+Mh9Q8vt2YG6/XhJkQaHG5l+8IMLuX7OxSrxqEG9FFMfQlQaiuQ994PFXOHkvFgBCO gxwC+gUJRBaQmSKZZePSyt/Qls6/OxT1kz13w3B923tC2Bv5HX8wAHFp5xIrKrGDOfRM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173337: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c48c9c6b33d7bb2b4ffa14cd33934a37db0cd342 X-Osstest-Versions-That: qemuu=99d6b11b5b44d7dd64f4cb1973184e40a4a174f8 From: osstest service owner Date: Wed, 28 Sep 2022 01:41:37 +0000 flight 173337 qemu-mainline real [real] flight 173340 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173337/ http://logs.test-lab.xenproject.org/osstest/logs/173340/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 173340-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173317 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173317 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173317 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173317 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173317 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173317 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 173317 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173317 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173317 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu c48c9c6b33d7bb2b4ffa14cd33934a37db0cd342 baseline version: qemuu 99d6b11b5b44d7dd64f4cb1973184e40a4a174f8 Last test of basis 173317 2022-09-26 19:39:49 Z 1 days Testing same since 173337 2022-09-27 15:38:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Alex Bennée Alexandre Ratchov Alistair Francis Andrew Burgess Bernhard Beschow Bin Meng Brad Smith Cal Peake Dongwon Kim Frank Chang Gerd Hoffmann Junqiang Wang Marc-André Lureau Mauro Matteo Cascella Michael Brown Philippe Mathieu-Daudé Philippe Mathieu-Daudé Qiang Liu Rahul Pathak Stefan Hajnoczi Thomas Huth Volker Rümelin Weiwei Li Wilfred Mallawa Yang Liu Yusuke Okada jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 99d6b11b5b..c48c9c6b33 c48c9c6b33d7bb2b4ffa14cd33934a37db0cd342 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Sep 28 03:02:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 03:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413106.656608 (Exim 4.92) (envelope-from ) id 1odNKl-0002F7-Sb; Wed, 28 Sep 2022 03:02:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413106.656608; Wed, 28 Sep 2022 03:02:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odNKl-0002F0-Pn; Wed, 28 Sep 2022 03:02:03 +0000 Received: by outflank-mailman (input) for mailman id 413106; Wed, 28 Sep 2022 03:02:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odNKk-0002Eq-5m; Wed, 28 Sep 2022 03:02:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odNKk-0001MY-41; Wed, 28 Sep 2022 03:02:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odNKj-0004vs-Mg; Wed, 28 Sep 2022 03:02:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odNKj-0007xA-MI; Wed, 28 Sep 2022 03:02:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0+xWkE8mDFoiYBuHVN5myvrZUjRSU1nvRF4e8HSsOQA=; b=Fwdhs/8Yh9k2GjTZ/VKCZkOF1K NWvM2EFyL6pFRe1HNMtcJ0mc3Hsr/OPuog3JpYY6K01z9+kAZxx36gUP5Co7xfUwjf0li+ali5SKw haNFOu2Rb1TcX3rTGSE5YRAaiQZexJuKivjX+RWsfNPKnhPKpkXkEWRc7PT06B7cUYYY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173341: all pass - PUSHED X-Osstest-Versions-This: ovmf=f4d539007c706ad9a563f368720edf0920da925d X-Osstest-Versions-That: ovmf=b3dd9cb836e2aed68198aa79a1ca6afdb25adf80 From: osstest service owner Date: Wed, 28 Sep 2022 03:02:01 +0000 flight 173341 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173341/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f4d539007c706ad9a563f368720edf0920da925d baseline version: ovmf b3dd9cb836e2aed68198aa79a1ca6afdb25adf80 Last test of basis 173323 2022-09-27 03:13:30 Z 0 days Testing same since 173341 2022-09-28 00:40:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Min M Xu Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b3dd9cb836..f4d539007c f4d539007c706ad9a563f368720edf0920da925d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Sep 28 04:57:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 04:57:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413115.656619 (Exim 4.92) (envelope-from ) id 1odP8C-0004vu-5q; Wed, 28 Sep 2022 04:57:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413115.656619; Wed, 28 Sep 2022 04:57:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odP8C-0004vn-35; Wed, 28 Sep 2022 04:57:12 +0000 Received: by outflank-mailman (input) for mailman id 413115; Wed, 28 Sep 2022 04:57:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odP8B-0004vd-KF; Wed, 28 Sep 2022 04:57:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odP8B-0003aO-HL; Wed, 28 Sep 2022 04:57:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odP8B-0002Cu-1K; Wed, 28 Sep 2022 04:57:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odP8B-0004NC-0t; Wed, 28 Sep 2022 04:57:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=v/TJRZJUf4M5W9fPTLHjYxVKgbfHSth6YH8vXvCoRG0=; b=Wu7DYytMn3eNVNPI1S61IgEqDH 2OkOf9QPvxyoUVSBihBIqmzmAiNyLjvE7YEk+mQ5RtdDOIXIO8D9+pWSbvFfRFrbs0Wr7PnTJ+oEB 3yrQQjYzZCPYZy3zNlCt4UmLv+lZWqPrsIn3Od1hPWEbzraeorpqVsicC4lOP+bpWkCM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173342: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc X-Osstest-Versions-That: xen=5e936d11b171793c174686268c9c1df8a4fa974c From: osstest service owner Date: Wed, 28 Sep 2022 04:57:11 +0000 flight 173342 xen-unstable-smoke real [real] flight 173344 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173342/ http://logs.test-lab.xenproject.org/osstest/logs/173344/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 173333 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc baseline version: xen 5e936d11b171793c174686268c9c1df8a4fa974c Last test of basis 173333 2022-09-27 13:00:27 Z 0 days Testing same since 173342 2022-09-28 01:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Michal Orzel Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Author: Andrew Cooper Date: Mon Sep 26 14:02:13 2022 +0100 CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch which is relevant to CONFIG_XEN_IBT in 4.17 and later. Force it on, rather than having 50% of the jobs not testing what they're supposed to be testing. Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible") Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini [stefano: minor code style improvement] Signed-off-by: Stefano Stabellini commit 1686272d5297b2f6ebad7dcf6586d17c55b84c81 Author: Michal Orzel Date: Tue Sep 27 11:47:18 2022 +0200 automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini commit 13a7c0074ac8fb31f6c0485429b7a20a1946cb22 Author: Andrew Cooper Date: Tue Sep 27 16:47:08 2022 +0100 Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS This breaks all Clang builds, as demostrated by Gitlab CI. Contrary to the description in ecd6b9759919, -no-pie is not even an option passed to the linker. GCC's actual behaviour is to inhibit the passing of -pie to the linker, as well as selecting different cr0 artefacts to be linked. EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to gain such a usecase. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Tested-by: Stefano Stabellini Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Sep 28 05:15:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 05:15:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413125.656632 (Exim 4.92) (envelope-from ) id 1odPQ4-0007gG-UM; Wed, 28 Sep 2022 05:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413125.656632; Wed, 28 Sep 2022 05:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odPQ4-0007g9-Rg; Wed, 28 Sep 2022 05:15:40 +0000 Received: by outflank-mailman (input) for mailman id 413125; Wed, 28 Sep 2022 05:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odPQ3-0007g3-Ea for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 05:15:40 +0000 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 938ad12d-3eec-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 07:15:34 +0200 (CEST) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 22:15:31 -0700 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 27 Sep 2022 22:15:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 22:15:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 22:15:30 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 22:15:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 22:15:30 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by PH8PR11MB6730.namprd11.prod.outlook.com (2603:10b6:510:1c6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 05:15:27 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::ff76:db8b:f7e9:ac80]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::ff76:db8b:f7e9:ac80%5]) with mapi id 15.20.5676.015; Wed, 28 Sep 2022 05:15:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 938ad12d-3eec-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664342134; x=1695878134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bfOyxd0JFT9Wik7hBR/LzX5S89ipwV9LmvGZ6XanbP0=; b=dY64HL5OYVvKJhDUP0Yc7WL5noPdpj5+wNsxj+9k2XKNBPmqhq5CMBv3 8B24VvWPzlKO8hXw9FjTuWZ+HjYKU5Gv82osheHeLCNaE0s9wN51g3gY8 aHQ3EWztqHji8GvcjbeNjZHVJ1CZkjIh2FMQirO7NEL8KGTxUJu4k44hn b3w8KxoVxp7jVtBbwogDqHwuQY0RSZHlasK0IN8K511V53p+WG5MvfuaK thitiDPArG3/1I0OtCrU5eQxFP2+s3d1e5b4LYn7iN5GxzXeXIekD9RCe N3nQ15/0VAjKVbV74K5gPrfExUjbbRDzlyN88MTlnyd9PfIo+DuZNjaX5 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="363347249" X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="363347249" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="652542115" X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="652542115" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J/mOlEWQY+YwPdn5WiIm2vXMCAT8nya024Ov4haFEwRdR9iKpRPdXIE78nOb9PEi73ZUCsTL5XaBEuoaa1QtZqn7wvSaJ7ICgYu1wAz39vsMgW8mfVwMpRWeRsyb5EenuJSPYs1pp9RqocwW9Pb5hMgJLDBzGZbJauESW83iAsMmLpLVgQqe3eNqJL7r0uU5Bzju+P6c+XEpx1XtAPpi8F0bh+a1D3jt3tY+xe+4fCVC2GD96717QG5fLuTjM78EcqBR61rh2kOdP4HZJRj4EcyK0Y0BoDkvPGJajynhMz7FkrREd7SCpoHKMfnzN+RkmbIyi0PeJUD+ikFbRc6OMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bfOyxd0JFT9Wik7hBR/LzX5S89ipwV9LmvGZ6XanbP0=; b=DD9xE4waPD46yfo9M1YkWA/zrPO09FDJTTcLXwPb3f5Osww+zvUMLEYLvOgSQFQ0jIKdTbvsVVvn4hznLQB9ga8FWptD5/JAZEwQVVJ8bXrDt4DAbhiHVvLeFwbWPNsqRXoikubtyCEEIOd2v24AiGt6mEsdiv+Sue5ZylBnAsnVK0JKATqIgdxbEQ83nkgOGcpFn1ipXZ1D/2QYU6bUNtSDD3eti6JN3BGH0NnlyUDCXCRnkbzWnWonWP1jUA0dcxG3ZjuWE1hmEpTEtXZtSXa+Te43VVU7qTgzvTQgalEzgxPLutmf2PSunHwYccqnmOx1akE/SuoBZy0eRZiTEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Marczykowski, Marek" CC: "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Thread-Topic: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API Thread-Index: AQHYykB/Pv1Ek/NIGEWzHFZweNfBzq3so7bggAXOUoCAAevfEA== Date: Wed, 28 Sep 2022 05:15:27 +0000 Message-ID: References: <902f7007a679c5850bee43b1347b159e1f5eeb16.1663383053.git-series.marmarek@invisiblethingslab.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|PH8PR11MB6730:EE_ x-ms-office365-filtering-correlation-id: 896fa2eb-dad5-4792-2d01-08daa11074c4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NC2VordyZI5XlFDDtM1zjP/d2I2xUvwFqU2j1l1VvVlWRuIuuk+NZ7JbVUWzSoQFZJUsSCI8oPPioBjd4/3kUGlodUPNQP+Sx9vZ7ZiM7ejNHA6GX8jcvy6EbXANB/h9TTsZTIZzoH6EbkIZRyADRP6tkiaNYdVF+PpyP5pSg5f6/D+CdOgsQnAzOYr6l/NywERc7v9KgMLZ5B8/X0zTDG1DVPX7/y3S3JtN1Ui2xynrxvZc2mo3DCPhG6n+bK76XW3khE+X3ovKRBPAObizwAMpyF/3+ZHUbyQuAj1y/BDFAHbkZVLdj48rKADn06xgGvlEXVkGJMabndIUejjJmt97MW9MIprMYJej2fEn7xqTFToYB3h6aTk5yFyo9j580tk69bri8stLZkTyhPKbUOX+ZKEPve0Ywei0dKTchH4XWUYGREtISgRTckp6/AvEMKb8E3l6G6tqoegSEMm8N5CVB4S0JAANrkmqSlRC87ZdyHOFzuiAl38dhgN0ilMiIX4LF4MmdvGEdKfEWzlorBEuRP3fhqBBFPqTGn8ZlHmFRRVA54gzRT02S32S8hNUddGYvnUy86bme8W34rGpmsLqvibjHMgDA9MeRP3Ybbta8WGP23gpm0IxdyU8AQRh4C4nN/N2sZkseIoS1uJ69t8TVhtDIhqB6XXZTeJFVd7Nr6UP7qA44SXNsxw2xm1yE6goX9mIkQQH60KSarob8xfku9P4yPf7wJiHMYjEUwlBlmx8gYh2tIBVE0UCzaombRXoPCk9A+Fc3vJis/xdUw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199015)(2906002)(33656002)(38070700005)(86362001)(38100700002)(122000001)(82960400001)(55016003)(76116006)(5660300002)(478600001)(71200400001)(64756008)(316002)(66556008)(66946007)(66574015)(6916009)(7696005)(4326008)(52536014)(8676002)(8936002)(66446008)(66476007)(186003)(83380400001)(41300700001)(6506007)(9686003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dlRsa2dqMDFhc3cxWk5nQ3prZGpUUlllTVYzbHViZ2NNaDZkeGN3RDNiY3h2?= =?utf-8?B?ditudEZwbWhWSno5NTF2b2liMTRFeGFjbXpLRmw2WlRZTDh2MnhRbUM1WEJT?= =?utf-8?B?U3NhMG43dCsrdlE4dXVaN3MvTjhocU9BeU5CN3Z6dW9GZ2VPSUYycHl4TlNy?= =?utf-8?B?VWhHbmtrdGNXV3BqQkk2VUlUK1dvYU1mTExRWmg1S1NOYVRZWTlrL21EbHFN?= =?utf-8?B?K2M3RS9raE4xM09Pd29mMWtCT01KVm45SC9RZ2FHVnNZK0liMFNmWTFzV29C?= =?utf-8?B?ODVPQmhGVVFnNHhiVGR6bkFuRENSb2lZUkg0VGhXcDVhNUxCdjhFbkJhU25T?= =?utf-8?B?aXFzZ2t4KzRxN3Q3UWVqNHkrTTBFb2dFZDIzeUIxeithbEN3cTEzQXBiVkVF?= =?utf-8?B?V3FmYUF5RmRMekxkajlJdjcrSE1iUk5rc0Z5eDhpcjdQelg0ZG5IdXc0Z29O?= =?utf-8?B?dGJYQlAvUjRtbTZZZkIxZmo0RVlYeFNucW5LZFpHSmxsQ1RFQjNLTzFPUk1v?= =?utf-8?B?U25CWk1uVXV6bGtlOUZQTm50VDVIMTRoTDFaMFJBalZTbHJkUWZSdzE5SXhy?= =?utf-8?B?QVp1bjYrRjFkQmVHeE1Ma29CWG1vTFg2aCtYdWt0UW1WSkgrQ3UyWU53REVR?= =?utf-8?B?VUcvMStHeDJKRVNIZlowZVpoT3ZHWUhZWENqb2VPK2E0VkJ4a2IyeVpQL0d3?= =?utf-8?B?OXJkSmI4ZGtmcnNwUmR0ejZjZmlwVXgvKzFNS25pNVdGV3ExVGhWY0ovK2lF?= =?utf-8?B?L2paYXN4ZjJ2NllBTXYxK201bG0zdmtFb3U3ZGt4YnZteTVuaHdJR1BUcW95?= =?utf-8?B?aFRTWTZxWklQbWNtaDNpYXg1cUVxYUNNSSthZllTYVdpRncxbjhJaE9meDVH?= =?utf-8?B?SVNRZmQwdXFQM0tQZ25DTXlNaUNOTit4RDF4OWNsc3hIR0FhRTN6OEsxODIy?= =?utf-8?B?UkFtY0crbjhzbElwWDBCVkF6c1pBZk82NnpEVnA1clg0bnBkL0ZCOXJJdW1l?= =?utf-8?B?S0lseXVFZzhSVmRNanlRdnhRK2dTUVJ3RVhZaEhJNTdXNzZiWnNsVGVrV1F4?= =?utf-8?B?bnNyakQ1cVRMRTBVaU93RjRHSmE5NHdCdkhic2FQcmczV3V2S2daRjY0aExi?= =?utf-8?B?NW4rdGxkQ3Q3MkFSaU9QVC9PRHhQalh1TjFhcjV4ditvQ253Yi85ZFNGU1VF?= =?utf-8?B?eEZBQlAyM2JWazNleHNlTnlpMSttMlREd0RXQSs5eUpmZ20za0dvcWJTMlFr?= =?utf-8?B?NkxLZkZMUUFIc0E0Wm5wYzBObEppVlBhd0NmL1d6R2g4eVUyRFFrVXprTi83?= =?utf-8?B?emUrM1hjWkIwSHM3Yng4S2JKSDRaQWxUWFEweTdRSFdla0ViWlo0dDkvcUFq?= =?utf-8?B?YlRjSVdvQWJ2VVdqU0xQb0xkVTBFQTlPOFdOSGpETExBbjNpNUY2aTJhRm8z?= =?utf-8?B?S2YxZ0RCNHJqdVR6VWxYZkZoNDZSV2R3RkU4ZXQ2cTJ1bUpMT1dNc3dHQ0FC?= =?utf-8?B?b2VxMEZBcjBMM0N0emVRR1M2QjFmVllLTDJLQlQ4K3gxclAvRXExdlpIZGlk?= =?utf-8?B?c2lucUtUR0JlcEpMY29QamJzcWh3K2cyeUQzWHRmT0tURHlZbmcycTk1SG5v?= =?utf-8?B?NnV3a3RGVWxSWXNieUlrNHZMRVhqYUhkc0U4dGcvWC9qMmpDeGVvZHdheSsz?= =?utf-8?B?Q2ZlU0U3SzFDdXVOUEsrRW1XZGhqdGFVK1k5elg0QjhmWVBmUzJZNkd1NXE1?= =?utf-8?B?SzdXaHNreGRzZkxEaE9DU2dSS2NnVHpLVVNLbmoyQWx3ZHA3ZjNWWitGdWla?= =?utf-8?B?OVNqS2pvNkxrVDl0UUpQdXR2cGp2MytMVi9FSnpYeS9RMiszL3RoeUZ1Vnpl?= =?utf-8?B?bU95SGxTanV4VTdmTGMvZDZxY0xDLzBydlc0WU0ydVpnVWlTMWxYUjY2ZUNM?= =?utf-8?B?dVBFUTAza0hPSE9ZT2o5UUovQnNrRmc0YnVJbkx1dFVGK1NaOTdnRWxiREJS?= =?utf-8?B?Y01FanliNnJMbjdmSzJ3YUtOZ2RPeThFakk4djFoTEFSU1FzUGR6dVM1TzM0?= =?utf-8?B?dnVITHh6RnpUNnJrVDJpd21HOE8zQll1Y3FJaUVwc2g3N3pmQzQramN0NjJM?= =?utf-8?Q?ItAbCZHXCXUg3ZM5bcHbWp8mi?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 896fa2eb-dad5-4792-2d01-08daa11074c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 05:15:27.6751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IsAn+prfaHLpASTeOX4t5DgnzFFDDQx1i0a5aEP1Kmx6UrgMv36P/0wRUUev7d6CO8CpIJ52KjsoccqZ018/EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6730 X-OriginatorOrg: intel.com PiBGcm9tOiBNYXJjenlrb3dza2ksIE1hcmVrIDxtYXJtYXJla0BpbnZpc2libGV0aGluZ3NsYWIu Y29tPg0KPiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMjcsIDIwMjIgNzo1NCBBTQ0KPiANCj4g T24gRnJpLCBTZXAgMjMsIDIwMjIgYXQgMDc6MjE6MDRBTSArMDAwMCwgVGlhbiwgS2V2aW4gd3Jv dGU6DQo+ID4gPiBGcm9tOiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kNCj4gPiA+IFNlbnQ6 IFNhdHVyZGF5LCBTZXB0ZW1iZXIgMTcsIDIwMjIgMTA6NTEgQU0NCj4gPiA+DQo+ID4gPiBSZS11 c2Ugcm1ycj0gcGFyYW1ldGVyIGhhbmRsaW5nIGNvZGUgdG8gaGFuZGxlIGNvbW1vbiBkZXZpY2UN Cj4gcmVzZXJ2ZWQNCj4gPiA+IG1lbW9yeS4NCj4gPiA+DQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBN YXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kNCj4gPiA+IDxtYXJtYXJla0BpbnZpc2libGV0aGlu Z3NsYWIuY29tPg0KPiA+ID4gLS0tDQo+ID4gPiBDaGFuZ2VzIGluIHYzOg0KPiA+ID4gLSBtYWtl IE1BWF9VU0VSX1JNUlJfUEFHRVMgYXBwbGljYWJsZSBvbmx5IHRvIHVzZXItY29uZmlndXJlZA0K PiBSTVJSDQo+ID4gPiAtLS0NCj4gPiA+ICB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZG1h ci5jIHwgMjAxICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tDQo+IC0NCj4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgMTE5IGluc2VydGlvbnMoKyksIDgyIGRlbGV0aW9ucygtKQ0KPiA+ID4NCj4g PiA+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZG1hci5jDQo+ID4g PiBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFyLmMNCj4gPiA+IGluZGV4IDM2NzMw NGM4NzM5Yy4uM2RmNWY2YjY5NzE5IDEwMDY0NA0KPiA+ID4gLS0tIGEveGVuL2RyaXZlcnMvcGFz c3Rocm91Z2gvdnRkL2RtYXIuYw0KPiA+ID4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv dnRkL2RtYXIuYw0KPiA+ID4gQEAgLTg2MSwxMTEgKzg2MSwxMzkgQEAgc3RhdGljIHN0cnVjdCB1 c2VyX3JtcnIgX19pbml0ZGF0YQ0KPiA+ID4gdXNlcl9ybXJyc1tNQVhfVVNFUl9STVJSXTsNCj4g PiA+DQo+ID4gPiAgLyogTWFjcm8gZm9yIFJNUlIgaW5jbHVzaXZlIHJhbmdlIGZvcm1hdHRpbmcu ICovDQo+ID4gPiAgI2RlZmluZSBFUk1SUlVfRk1UICJbJWx4LSVseF0iDQo+ID4gPiAtI2RlZmlu ZSBFUk1SUlVfQVJHKGVydSkgZXJ1LmJhc2VfcGZuLCBlcnUuZW5kX3Bmbg0KPiA+ID4gKyNkZWZp bmUgRVJNUlJVX0FSRyBiYXNlX3BmbiwgZW5kX3Bmbg0KPiA+ID4gKw0KPiA+ID4gK3N0YXRpYyBp bnQgX19pbml0IGFkZF9vbmVfdXNlcl9ybXJyKHVuc2lnbmVkIGxvbmcgYmFzZV9wZm4sDQo+ID4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBlbmRf cGZuLA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVk IGludCBkZXZfY291bnQsDQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdWludDMyX3QgKnNiZGYpOw0KPiA+DQo+ID4gSnVzdCBtb3ZlIHRoZSBmdW5jdGlvbiBoZXJl IHRoZW4gbm8gbmVlZCBvZiBhIGRlY2xhcmF0aW9uLg0KPiANCj4gT2suDQo+IA0KPiA+ID4NCj4g PiA+ICBzdGF0aWMgaW50IF9faW5pdCBhZGRfdXNlcl9ybXJyKHZvaWQpDQo+ID4gPiAgew0KPiA+ ID4gKyAgICB1bnNpZ25lZCBpbnQgaTsNCj4gPiA+ICsgICAgaW50IHJldDsNCj4gPiA+ICsNCj4g PiA+ICsgICAgZm9yICggaSA9IDA7IGkgPCBucl9ybXJyOyBpKysgKQ0KPiA+ID4gKyAgICB7DQo+ ID4gPiArICAgICAgICByZXQgPSBhZGRfb25lX3VzZXJfcm1ycih1c2VyX3JtcnJzW2ldLmJhc2Vf cGZuLA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdXNlcl9ybXJyc1tp XS5lbmRfcGZuLA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdXNlcl9y bXJyc1tpXS5kZXZfY291bnQsDQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB1c2VyX3JtcnJzW2ldLnNiZGYpOw0KPiA+ID4gKyAgICAgICAgaWYgKCByZXQgPCAwICkNCj4g PiA+ICsgICAgICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ID4gKyAgICB9DQo+ID4gPiArICAgIHJl dHVybiAwOw0KPiA+ID4gK30NCj4gPiA+ICsNCj4gPiA+ICsvKiBSZXR1cm5zIDEgb24gc3VjY2Vz cywgMCB3aGVuIGlnbm9yaW5nIGFuZCA8IDAgb24gZXJyb3IuICovDQo+ID4NCj4gPiBJJ20gbm90 IHN1cmUgdGhlIHBvaW50IG9mICdpZ25vcmluZycuIElmIHVzZXIgc3BlY2lmaWVzIGEgd3Jvbmcg Uk1SUg0KPiA+IHJhbmdlIChvdmVybGFwLCBtZm4gaW52YWxpZCwgZXRjLikganVzdCByZXR1cm4g YW4gZXJyb3Igc2ltaWxhciB0bw0KPiA+IC1FTk9NRU0uIElnbm9yaW5nIGEgdXNlci1zcGVjaWZp ZWQgcmFuZ2UgaW1wbGllcyB0aGF0IHNvbWV0aGluZw0KPiA+IHdvdWxkIHBvdGVudGlhbGx5IGdl dCBicm9rZW4gaGVuY2UgYmV0dGVyIGZhaWwgaXQgZWFybHkuDQo+IA0KPiBUaGF0J3MgdGhlIGJl aGF2aW91ciB0aGF0IHdhcyBoZXJlIGJlZm9yZSwgSSBzaW1wbHkgYWRkZWQgYSBjb21tZW50DQo+ IGFib3V0IGl0IGV4cGxpY2l0bHkgKHByZXZpb3VzbHkgaXQgdXNlZCAnY29udGludWUnIGhlYXZp bHksIG5vdyBpdCdzIGENCj4gc2VwYXJhdGUgZnVuY3Rpb24gc28gaXQncyBhIHJldHVybiB2YWx1 ZSkuDQo+IFdoaWxlIEkgYWdyZWUgaW4gcHJpbmNpcGxlLCBJIGRvbid0IHRoaW5rIHN1Y2ggY2hh bmdlIHNob3VsZCBiZSBwYXJ0IG9mDQo+IHRoaXMgcGF0Y2guDQo+IA0KPiAoLi4uKQ0KPiANCj4g PiA+IEBAIC0xMTA4LDYgKzExMzYsMTUgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sNCj4g cGFyc2Vfcm1ycl9wYXJhbShjb25zdA0KPiA+ID4gY2hhciAqc3RyKQ0KPiA+ID4gICAgICAgICAg ZWxzZQ0KPiA+ID4gICAgICAgICAgICAgIGVuZCA9IHN0YXJ0Ow0KPiA+ID4NCj4gPiA+ICsgICAg ICAgIGlmICggKGVuZCAtIHN0YXJ0KSA+PSBNQVhfVVNFUl9STVJSX1BBR0VTICkNCj4gPiA+ICsg ICAgICAgIHsNCj4gPiA+ICsgICAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgN Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICJSTVJSIHJhbmdlICJFUk1SUlVfRk1UIiBleGNl ZWRzICJcDQo+ID4gPiArICAgICAgICAgICAgICAgICAgICBfX3N0cmluZ2lmeShNQVhfVVNFUl9S TVJSX1BBR0VTKSIgcGFnZXNcbiIsDQo+ID4gPiArICAgICAgICAgICAgICAgICAgICBzdGFydCwg ZW5kKTsNCj4gPiA+ICsgICAgICAgICAgICByZXR1cm4gLUUyQklHOw0KPiA+ID4gKyAgICAgICAg fQ0KPiA+ID4gKw0KPiA+DQo+ID4gd2h5IG1vdmluZyB0aGlzIGVycm9yIGNoZWNrIG91dCBvZiBh ZGRfb25lX3VzZXJfcm1ycigpPyBJIGRpZG4ndA0KPiA+IGdldCB3aHkgaXQncyBzcGVjaWFsIGZy b20gb3RoZXIgY2hlY2tzIHRoZXJlLCBlLmcuIGhhdmluZyBiYXNlPmVuZC4uLg0KPiANCj4gVG8g YWxsb3cgaW50ZXJuYWwgY2FsbGVycyBieXBhc3MgTUFYX1VTRVJfUk1SUl9QQUdFUywgYW5kIG1h a2UgaXQgYXBwbHkNCj4gcmVhbGx5IG9ubHkgdG8gdXNlci1wcm92aWRlZCByYW5nZXMuDQo+IA0K DQpXaXRoIGFib3ZlIGNsYXJpZmljYXRpb24gYW5kIG9yZGVyIGFkanVzdG1lbnQsDQoNClJldmll d2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 28 05:30:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 05:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413131.656645 (Exim 4.92) (envelope-from ) id 1odPeL-0001cz-8p; Wed, 28 Sep 2022 05:30:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413131.656645; Wed, 28 Sep 2022 05:30:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odPeL-0001cs-4A; Wed, 28 Sep 2022 05:30:25 +0000 Received: by outflank-mailman (input) for mailman id 413131; Wed, 28 Sep 2022 05:30:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odPeJ-0001cm-Jc for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 05:30:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5425e25-3eee-11ed-9648-05401a9f4f97; Wed, 28 Sep 2022 07:30:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 543F221A74; Wed, 28 Sep 2022 05:30:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1DACB13677; Wed, 28 Sep 2022 05:30:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Qk77Be3bM2OoCwAAMHmgww (envelope-from ); Wed, 28 Sep 2022 05:30:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5425e25-3eee-11ed-9648-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664343021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=591slOQocz3ngdqtE3H7RHke8TQLSdgTdQjqzUWhzjM=; b=K0P/PNW3DKSGCZCpgbRsy8D1JwHUvAxabYOMVJg3c0fzW9YLR3NCMW97cNjDhVALZbWdLz bX9DrdoF14c7Mp0FKkdUfydPc/CIHyj+ECt3wIgZhzRpepq+MBm0fCeMBl66Oz9DD2eVeV hCn6/JiGDpCE9+8dM9ImJLusWyZe4x0= Message-ID: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> Date: Wed, 28 Sep 2022 07:30:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------pApUDlOPKOM3yi0arxqoORwb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------pApUDlOPKOM3yi0arxqoORwb Content-Type: multipart/mixed; boundary="------------nOdhPYwk0z37KeDD2mybzqmO"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> In-Reply-To: --------------nOdhPYwk0z37KeDD2mybzqmO Content-Type: multipart/mixed; boundary="------------0PIhfvS50QHBH0ohTlAHXzC0" --------------0PIhfvS50QHBH0ohTlAHXzC0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMDE6MTYsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVHVlLCBT ZXAgMjcsIDIwMjIgYXQgMDI6MjE6MTdQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFNvIHJlcGxhY2luZyB0aGUgYm9vbCB3aXRoICIoc3lzdGVtX3N0YXRlICE9IFNZU1RF TV9SVU5OSU5HKSIgaXMgZmluZQ0KPj4gd2l0aCB5b3UgcmlnaHQgbm93PyBXZSBjYW4gbGF0 ZXIgc3dpdGNoIHRoYXQgdG8gdGhlICJtb3JlIGVsZWdhbnQiDQo+PiBzb2x1dGlvbiB3aGVu IGl0IHNob3dzIHVwLg0KPiANCj4gT2ssIEkgdGhpbmsgSSBoYXZlIHNvbWV0aGluZy4gQW5k IGl0IHdhcyBzdGFyaW5nIG1lIHN0cmFpZ2h0IGluIHRoZQ0KPiBmYWNlIGJ1dCBJIGRpZG4n dCBzZWUgaXQ6IHRoZSBNVFJSIGNvZGUgbmVlZHMgYSBob3RwbHVnIG5vdGlmaWVyLiBJbg0K PiB0aGF0IG5vdGlmaWVyIGl0IGNhbiBkbyB0aGUgaW1tZWRpYXRlLCBpLmUuLCBub24tZGVs YXllZCBpbml0IHdoaWxlIHRoZQ0KPiBkZWxheWVkIGluaXQgYmVjb21lcyB0aGUgZGVmYXVs dCwgc2VlIGJlbG93Lg0KPiANCj4gQW5kIGlnbm9yZSB0aGUgcHJfaW5mbyBkZWJ1Z2dpbmcg Z3VuayBwbHMuDQo+IA0KPiBtdHJyX2FwX2luaXQoKSBiZWNvbWVzIHRoZSBub3RpZmllciBj YWxsYmFjay4gSXQgZG9lc24ndCBuZWVkIHRvIGJlDQo+IGNhbGxlZCBpbiBpZGVudGlmeV9z ZWNvbmRhcnlfY3B1KCkgYW55bW9yZSBhcyBpbiB0aGUgaW5pdCBjYXNlIHRoYXQNCj4gZnVu Y3Rpb24gZG9lc24ndCBkbyBhbnl0aGluZyAtIGRlbGF5ZWQ9dHJ1ZSAtIGFuZCBpbiB0aGUg aG90cGx1ZyBjYXNlDQo+IHRoZSBub3RpZmllciBydW5zLg0KDQpBcmUgc3VyZSB0aGUgaG90 cGx1ZyBub3RpZmllciBkb2Vzbid0IGdldCBjYWxsZWQgaW4gdGhlIGJvb3QgYW5kIGluIHRo ZQ0KcmVzdW1lIGNhc2VzPyBJIGRvbid0IHNlZSBob3cgdGhvc2UgY2FsbHMgYXJlIGJlaW5n IG5vdCBkb25lIG9yIHJlc3VsdGluZyBpbg0Kbm90IGRvaW5nIGFueXRoaW5nLg0KDQoNCkp1 ZXJnZW4NCg== --------------0PIhfvS50QHBH0ohTlAHXzC0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0PIhfvS50QHBH0ohTlAHXzC0-- --------------nOdhPYwk0z37KeDD2mybzqmO-- --------------pApUDlOPKOM3yi0arxqoORwb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMz2+wFAwAAAAAACgkQsN6d1ii/Ey/6 dgf+KHty3N+NQlsxlB+dsqE/SLOW6Tee7Q2uBokhTrAlVd/C0YXkEe4bN4DJnwGcmMUzxyz0zi2+ UXxBejSNdWsZNWldTyq8Yk/WRsyMMDsDRCunb56n+vV030xD38VQfPUGX5KLIOvCyzeNFcQHk4e2 M9bAMRE1DlixNkm7LP3Q45DwAkw+UO0fB+I0lXZZ4Omppj8fNW+1Eop8ajp+zYuaocZ3qf1tH8ar IpG0EMoz/HTPxSy43ZRmJe9DQhw1jZO0m4KmvXO51G7pLBkG7tvBesrufETXtjgkpcRXEhQj0Dwg 3WKq+zjEe95ldaMTbygwdykc7F+7LkWynXuMHTgpCg== =ETI+ -----END PGP SIGNATURE----- --------------pApUDlOPKOM3yi0arxqoORwb-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 06:17:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 06:17:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413136.656655 (Exim 4.92) (envelope-from ) id 1odQNP-0006Hg-Mh; Wed, 28 Sep 2022 06:16:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413136.656655; Wed, 28 Sep 2022 06:16:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odQNP-0006HL-JE; Wed, 28 Sep 2022 06:16:59 +0000 Received: by outflank-mailman (input) for mailman id 413136; Wed, 28 Sep 2022 06:16:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odQNN-0006HF-JE for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 06:16:57 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2632016d-3ef5-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 08:16:55 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A11D21E53; Wed, 28 Sep 2022 06:16:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 014C013A84; Wed, 28 Sep 2022 06:16:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D1a1OtXmM2NdHAAAMHmgww (envelope-from ); Wed, 28 Sep 2022 06:16:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2632016d-3ef5-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664345814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bre+DACPL2mKV+lMG7Cg7u1j2iWJJkOeH2RR1YE7xeg=; b=DmXbcKp0Rggx7RChK7O6eERRyj7I7G1Qpg3ec/BUB6LVwPKqYSL+1W9eULnWrBiz3Y/b3Q pIUlFyiM282BKpxKF56geLUZ3JkQRU+8rU4gkdmwsC+zu2JLcrPKAdgd8owFYayD8LDPMx 2fSiXEzfeoeizt/+R6n5j0PX2HZoBkw= Message-ID: <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> Date: Wed, 28 Sep 2022 08:16:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Content-Language: en-US From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> In-Reply-To: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OyiQnYzmXwBUQx7SGaqrZO6w" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OyiQnYzmXwBUQx7SGaqrZO6w Content-Type: multipart/mixed; boundary="------------HLeIqo78kA0MCawMBb4mVCdu"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> In-Reply-To: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> --------------HLeIqo78kA0MCawMBb4mVCdu Content-Type: multipart/mixed; boundary="------------TfV3sPvPUEdgVZGQjT3iXMvs" --------------TfV3sPvPUEdgVZGQjT3iXMvs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMDc6MzAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDI4LjA5LjIy IDAxOjE2LCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6DQo+PiBPbiBUdWUsIFNlcCAyNywgMjAy MiBhdCAwMjoyMToxN1BNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+IFNvIHJl cGxhY2luZyB0aGUgYm9vbCB3aXRoICIoc3lzdGVtX3N0YXRlICE9IFNZU1RFTV9SVU5OSU5H KSIgaXMgZmluZQ0KPj4+IHdpdGggeW91IHJpZ2h0IG5vdz8gV2UgY2FuIGxhdGVyIHN3aXRj aCB0aGF0IHRvIHRoZSAibW9yZSBlbGVnYW50Ig0KPj4+IHNvbHV0aW9uIHdoZW4gaXQgc2hv d3MgdXAuDQo+Pg0KPj4gT2ssIEkgdGhpbmsgSSBoYXZlIHNvbWV0aGluZy4gQW5kIGl0IHdh cyBzdGFyaW5nIG1lIHN0cmFpZ2h0IGluIHRoZQ0KPj4gZmFjZSBidXQgSSBkaWRuJ3Qgc2Vl IGl0OiB0aGUgTVRSUiBjb2RlIG5lZWRzIGEgaG90cGx1ZyBub3RpZmllci4gSW4NCj4+IHRo YXQgbm90aWZpZXIgaXQgY2FuIGRvIHRoZSBpbW1lZGlhdGUsIGkuZS4sIG5vbi1kZWxheWVk IGluaXQgd2hpbGUgdGhlDQo+PiBkZWxheWVkIGluaXQgYmVjb21lcyB0aGUgZGVmYXVsdCwg c2VlIGJlbG93Lg0KPj4NCj4+IEFuZCBpZ25vcmUgdGhlIHByX2luZm8gZGVidWdnaW5nIGd1 bmsgcGxzLg0KPj4NCj4+IG10cnJfYXBfaW5pdCgpIGJlY29tZXMgdGhlIG5vdGlmaWVyIGNh bGxiYWNrLiBJdCBkb2Vzbid0IG5lZWQgdG8gYmUNCj4+IGNhbGxlZCBpbiBpZGVudGlmeV9z ZWNvbmRhcnlfY3B1KCkgYW55bW9yZSBhcyBpbiB0aGUgaW5pdCBjYXNlIHRoYXQNCj4+IGZ1 bmN0aW9uIGRvZXNuJ3QgZG8gYW55dGhpbmcgLSBkZWxheWVkPXRydWUgLSBhbmQgaW4gdGhl IGhvdHBsdWcgY2FzZQ0KPj4gdGhlIG5vdGlmaWVyIHJ1bnMuDQo+IA0KPiBBcmUgc3VyZSB0 aGUgaG90cGx1ZyBub3RpZmllciBkb2Vzbid0IGdldCBjYWxsZWQgaW4gdGhlIGJvb3QgYW5k IGluIHRoZQ0KPiByZXN1bWUgY2FzZXM/IEkgZG9uJ3Qgc2VlIGhvdyB0aG9zZSBjYWxscyBh cmUgYmVpbmcgbm90IGRvbmUgb3IgcmVzdWx0aW5nIGluDQo+IG5vdCBkb2luZyBhbnl0aGlu Zy4NCg0KSW4gY2FzZSBteSBzdXNwaWNpb24gaXMgY29ycmVjdDogdGhpcyBjYW4gc3RpbGwg YmUgc29sdmVkIGJ5IGFkZGluZyB0aGUNCmhvdHBsdWcgbm90aWZpZXIgb25seSBpbiBtdHJy X2Fwc19pbml0KCksIGFuZCByZW1vdmluZyBpdCBhZ2FpbiBpbg0KYXJjaF90aGF3X3NlY29u ZGFyeV9jcHVzX2JlZ2luKCkuDQoNCg0KSnVlcmdlbg0KDQo= --------------TfV3sPvPUEdgVZGQjT3iXMvs Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------TfV3sPvPUEdgVZGQjT3iXMvs-- --------------HLeIqo78kA0MCawMBb4mVCdu-- --------------OyiQnYzmXwBUQx7SGaqrZO6w Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmMz5tUFAwAAAAAACgkQsN6d1ii/Ey82 twgAhOoiZGhrh8PAUW4TmAIk4c94ArAo5sbdmO+5AeQ06eh9Kiq9lhx3W1gqc3Iq0/0JS1SuJ+6E 5hjtM0CHeJnHIRmXEB3uQS1cickhWk2J8yj58aiHy7EszYQ2qEuQAEvzpPksboOgOwnOpwouR5Rn E9ISb0EXB6z3j0bUUBhk38VWI7lhUiZL3OQ+t5/aJJJlnX+pu+dsKxdfguEgRA6CBDidMWyC2Cf0 mONXin+UMkQ/2oRpmer7UrehkWo9baabcOa4vizyfdXRf233N2ejVdB3QdqKHPFQHhSGZDZ7jdnN LerUx+0yZ/eiCehS19N+QulKR34lULiEzOIZihJWBw== =ZU6t -----END PGP SIGNATURE----- --------------OyiQnYzmXwBUQx7SGaqrZO6w-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 07:07:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 07:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413144.656669 (Exim 4.92) (envelope-from ) id 1odR9i-0003Es-Fl; Wed, 28 Sep 2022 07:06:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413144.656669; Wed, 28 Sep 2022 07:06:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odR9i-0003El-CM; Wed, 28 Sep 2022 07:06:54 +0000 Received: by outflank-mailman (input) for mailman id 413144; Wed, 28 Sep 2022 07:06:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odR9h-0003Eb-PK; Wed, 28 Sep 2022 07:06:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odR9h-0006gM-MT; Wed, 28 Sep 2022 07:06:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odR9h-00077U-Et; Wed, 28 Sep 2022 07:06:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odR9h-0000qg-EL; Wed, 28 Sep 2022 07:06:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BWHHfj3mSKep7QhI9GBdPJsO+nrpZacjER165gR/j9s=; b=MnPGATTiQvcTf2sAINmeuqMSnb yimC9n/VaPuXTWN7Gvu18BCPX2iI6iNFLWsQjAo+D0TESkTuaaQVpANdQmg6k3w45Ju6Vrstt7hCh OPkv91aEVzrCVnCTc8MasnfV4GloKN6gnRTmIlcnwQ9RW1oaVgkP4dPUqF0B2Dj6SE9g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173338: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5e936d11b171793c174686268c9c1df8a4fa974c X-Osstest-Versions-That: xen=bd68a5f397537eb7ba6223546c1f4d47f078d3b2 From: osstest service owner Date: Wed, 28 Sep 2022 07:06:53 +0000 flight 173338 xen-unstable real [real] flight 173348 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173338/ http://logs.test-lab.xenproject.org/osstest/logs/173348/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 173327 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173348-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173327 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173327 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173327 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173327 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173327 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173327 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173327 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173327 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173327 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173327 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173327 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173327 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 5e936d11b171793c174686268c9c1df8a4fa974c baseline version: xen bd68a5f397537eb7ba6223546c1f4d47f078d3b2 Last test of basis 173327 2022-09-27 08:40:00 Z 0 days Testing same since 173338 2022-09-27 18:39:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 5e936d11b171793c174686268c9c1df8a4fa974c Author: Andrew Cooper Date: Mon Sep 26 11:46:15 2022 +0100 drivers/char: Fix build when CET-IBT is enabled https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 Signed-off-by: Andrew Cooper Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and dbgp=ehci") Reviewed-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Sep 28 08:01:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 08:01:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413159.656682 (Exim 4.92) (envelope-from ) id 1odS0b-0001Tv-TB; Wed, 28 Sep 2022 08:01:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413159.656682; Wed, 28 Sep 2022 08:01:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odS0b-0001To-QQ; Wed, 28 Sep 2022 08:01:33 +0000 Received: by outflank-mailman (input) for mailman id 413159; Wed, 28 Sep 2022 08:01:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odS0a-0001Ti-BY for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 08:01:32 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60040.outbound.protection.outlook.com [40.107.6.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2e3687f-3f03-11ed-9648-05401a9f4f97; Wed, 28 Sep 2022 10:01:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6999.eurprd04.prod.outlook.com (2603:10a6:20b:de::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 08:01:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 08:01:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2e3687f-3f03-11ed-9648-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h0GEpvtgePt7+khs1D1IcmJB8+29dPegO+2B5Wq/+Ed0CMfSZprL37OpJMs59KHA3mgMfvZbd4GAt/bFJieL1LmRdGibR4vkT7C1YoFmpSefgJv7PXABVLdkpNY7bOGZ9AQdiqIxRwKCf1rwPrXCGW8uzxsAaVuE4ubNLnTyeflt4VjXD7Zir8PrySJLfqYdawdWi626538izSm+hZkTu7JOzV5NjrEWTwpjCERlcJvX4VRq825ZG1m/e01qt2ufGQgVSWMcUCnZx5Xl8TPGcZe4YcT+ChGQeySqpmvByhdZrXIWZZcrCNAusPYTY2McvtAnTZk+ICGwxW6SUvvoJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=omiiGGBA9Y0nyz+SvNAtNjvZxtSrppAg41tJmWHsaGQ=; b=GngGiJ4BbiukZFAigSBiO9koGYGIfAlWO+gHE6OUAhemaUhDLF3j/vLAW+3RaciFBteow7ai1CjVfSIuAaKJiQj/80S6KMVD9ygBB5ir4ySnpiX5TpA828sAqCQ3dGtzSNXc/TWJDpT8r1cyCedptOPLwPM9G8xzEVm8y8iAEqS1aRIlVntFmbBhPH7IsbyA7Ep5dmw6l0WjNzpxnsDpCB0BIBXVEynDprxs6ixxJrNKSdij6Mj8Cp6RyTs1P1LnR7UNwDeHkycVZmqHFPMmIfUrjvO6OJ2dke6vz9NI7E+Pl3fONUHr7RoGs5WbW27lSexApec5oazjW8fadBpwtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=omiiGGBA9Y0nyz+SvNAtNjvZxtSrppAg41tJmWHsaGQ=; b=QsJtD3var2tfBLAXRDc/hM9rL31Z5iBmKBNQVoeyvEevXiqgQ25/vkFuDk3AP/wt+ZHOPMam7y+IpSnxbwo6fRVwUzjHR0n6RaGZrR+WfzlmQ+Y2ToApM5aAHgFwKzUCF7NbgNcOMFlWiBPB3XWrU2lCBrHv5Zhwsu4sYF7ps+m82dm1UJ7nVyQotMN0w+N1ybchI28ZFHGxHnqdVT25/GrIVkS5m5aep/ZAYgfi/+qjEIcmV5h0B4Qu9aa9Qf5TI1wOWIAIH+3Q+e2BQ3p5zTdLr05cqPsDOCNUQt0pEj5QF1f2ZrB3LcBnMyxz/RDaIwt4lz9PA6TKOjI6ruza0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 28 Sep 2022 10:01:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: Roger Pau Monne Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20220927153937.39389-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220927153937.39389-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6999:EE_ X-MS-Office365-Filtering-Correlation-Id: a3a96860-6978-4c0b-7efe-08daa127a5af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8AKNAvwfdVJ97VObtNqUfrqBiiSM4tl3A8TVnkJQ0CWUFvsJlPGucNQ6h45jhbKgqsQEeM4ZiBEZNz2S3z9CNilBC2pwIGpGokHmDtymOvHPPCQs+c3o3spNmpfMpoIavmNQ69EZ7zBuZFgBHAvvBo0Nkc7FgdqaL8MrDhzWu2wjpko32IXQ0d07QF+PrPo7U07+pL7mPsR0yRx0syaJ1nUneE5/s3U9Si++o18HRwhLH5gaImw54TczHK8gAk4MQsCUuUG3lQJrofEMSq5Nh1r0SKKuG7TqN+/Nzpj30Eo2kue1up03Ex8L8bEE6YOmIEleY78Lhd1WnNNpfMc4KJfcYnk1/IPWEmgNqTBo77NcmNFUvKYU3tGYtGDppV/XikwbQHbJAWm4BwD3y/vA9PZgKPQNcylkRTZs+rHR44o+3mlbUwEh0OevrJbcu3jAqjIOwdZ9LOekphoneOL20qFYW726HMQajE1NFYueLJNjxlKrvLGi4flax22vBWc10JYViOzDVfBcW9qPpGtjEvFHOlaqr4uMeyRmGBEOndYX+ktYz2V4gT9eDWIhuRGb9/W0sYuRgUhg/+mWmwI1Az+0Ahr2Gr80wLBPpXJnAmwOKc9BI54Iibt70BWx6fBz0b+0FX0IB+5bWilLN/wn7msl3n4Mh7uRPaki8aGv3BLmlZEYK5jpBYud7EljcuQlEIBj4ZLy17pQ+09IauF20ORQwayX3X4RJiffoehkn8CLZ5ZM8kmIhZm4A9l8u6raSvw7uQq08hhLcHx7XFRKGC92uvjL+MRX4udVz/CtC5E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199015)(36756003)(54906003)(6916009)(316002)(31696002)(86362001)(7416002)(31686004)(83380400001)(38100700002)(186003)(2616005)(53546011)(26005)(6512007)(478600001)(6486002)(8676002)(6506007)(66476007)(4326008)(66946007)(66556008)(2906002)(41300700001)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlRwMm0xWVlxc0tINitjeU5xZnVrdUgrTlNubGYwQlJwVlN0TmN1VWxQZXdN?= =?utf-8?B?WGpPT2Q5VkE0aG9zazZxNWFCR3dURGtjbE12ZTBmajYxN0pOaWFQdEdzb1VH?= =?utf-8?B?aTlBMTJqVm1GVHJYNVBybVZpOVZla0N6WVVOT1oxaXVqU1FhZjU5akljdlVV?= =?utf-8?B?cFE1VEhLNkZieVc1L2VBMTBiOFNHNVN3M3FINW45dnc5bml0SCtKcjZ6SldX?= =?utf-8?B?UXh3QXJsZWtTRmoweVJ6cWlxczVpWE9JWiswY05wTThRRjhhcHVXcTYvUVpm?= =?utf-8?B?bkFndWhGZzhPTHRrMEFrcHl2U1JXVHhBWW1LaHZZMWpvd0ZsTUhFYkJ6Vk82?= =?utf-8?B?bVpRTkZMZ2VENDJQM1hxVmVzYmVQMlVnTjFIbXp4bDEwY3o3OG13eUxEZzkr?= =?utf-8?B?TVdoNlIvU0o0UDhBWVZxdy9MckozUDBRSTNEcnZnQ1VEbWE1TUlPQjhFMDVy?= =?utf-8?B?MWp1cGJnWFdpb2o1SXQyTlRuUnkvejVxaFo2clBNT3REOUFsRUVPZ2dTREJB?= =?utf-8?B?dzZrYmMxQVllQTVzUG9XSy9yb3JJRThFTGxzS1oydi85eDhMb1k3K1hEN1Y4?= =?utf-8?B?ejZyVlBCbm5FNldyQy9DRkZublNZVnFyd1JsL0I2MzNGZkRsK29mQWxXUUdG?= =?utf-8?B?UHRiRXFiOVBGYVc4M1c4WHBNQldzVmZwcXVaU2tFZEQ0cUhWbmhQb3AwK3Ux?= =?utf-8?B?bllDTDRXblZpK1gvYmxJd0szbnNJb3M2eVFQdzBtTC9EdGFpejhsSG9KNXpr?= =?utf-8?B?eHYrWHBvZW4xcWUyWjI2VDhZUXJvVXFaTkorMEVYTVBwd05zOG1qTGZIeVV6?= =?utf-8?B?T0FLc3RFTDlSTWJOalpOdHFoQ1RJWlRlempUZGN5MjNWSlQ5QmkrNnA4RTIv?= =?utf-8?B?SFhYQ3RoSEhzS2JnWTNPSG5lMnVGWG4wSDIyaFRFcFNNTnVRMWY2aW1pdWQr?= =?utf-8?B?T01VMnR1MkJoY3M1aldoQUtEYUExd0I4MUx2N1V4aFVPZ2NMVUFXNkN3cHBR?= =?utf-8?B?MG9ZQmx3cVhQdmtGOHZjSWJWd3Q3Z1F1cElKak0vQi9KbkdEQ3hrTTZ3anV2?= =?utf-8?B?RDJVbHdoVDJ4N1BJSUhtRGF0VWhTV1VZZi80VERnZXhOVlJ0UktJUEdLQzRN?= =?utf-8?B?WUExVS9ocS9RNG42bWg1eXJuSU1NbnM1UXJwMjhhWVhOanlBNlRHZG5sWFk3?= =?utf-8?B?SjhjS2d3ejFEQll6Y0VGaHFYTC9KOWk2dmtlZFJLTEl3azlvc1BrSU02SjVo?= =?utf-8?B?TDFHN0cwWWFNLzZPWlgwZEJGN21yN0JmanRuaEYxWWNsc1dLeU9aN2ZCVEtD?= =?utf-8?B?WFdlanFRZ09HSkVPdkQ5T3Y5dUMxZ201MnZ6amxjUnQzNE8wZnlaWm5NUTE3?= =?utf-8?B?amdLekZ6eklxWndXbUZmQS9yektBZHVtNjNuUEd3aVNiclJ0MGVFMHV0QUYr?= =?utf-8?B?N2sxNjAzcFBtaHdpQ1VYRXh5cmUyZUxBRW5lRTkyMlJBYlNkdWx1bGh6eGR6?= =?utf-8?B?K1VtYzNzaUxuTDEvYkxiL3JWSVdJVjhheXBoS2xPTlE1MUZib3daREZ0OG5o?= =?utf-8?B?MGU3TTBlRzdJa3NEcTRLR29IT3UyV0c5YnRCQ2VkT3pyUHRvcU94RnQwSXF5?= =?utf-8?B?ZEJLUnlUV0VBVzNpNFNOeFFLbnF5bG9sR1dVVUhGZHROOWJRMU9meXBVa2hU?= =?utf-8?B?Vms0QlFtMG10THRkZUtTNzhEM013Z0FnU2JHbVRzeEJ4eXhPWDVRQ1pEMC9R?= =?utf-8?B?OFhNUEI5Tk5ZRkhRTThGM0VRc25qa2hERlJpQUFlUEVEM0c0NDQ4d3BGREo3?= =?utf-8?B?THk2c0VFZlRSZU5YQXpKVWlHTVZ6NVBtR0lsTEgwdFFFVStUMDB4b0RKbXNr?= =?utf-8?B?aWVETm42WFBYdUwvb05kYnBiVUZCQ1ZKM3hmWnJGK2EzVG9kNnlMNGVidmV1?= =?utf-8?B?aEhMUGpMbERLYnU2Qm5sYjdMNDBCR1FQdHN5ZzRkSHBLUG9nRFFkUkNTdVpp?= =?utf-8?B?VjJNQlR4dVZXTE1JKzdaNzhsdDRtNk1jUnAreUJCbEVXSUM3T2g2SVl1Ukth?= =?utf-8?B?K0V5UDIrQmsydDNvN3A4Z3dWa1pOZjE3N09pdDBUM1kzaFVxMnZPWk5VQU5y?= =?utf-8?Q?IAe3FjuWKR4XYUD9BDADEQDbF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3a96860-6978-4c0b-7efe-08daa127a5af X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 08:01:28.3134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w8GAc+Mx1t4xBbBLqBjdooFWextzPqRXKWudR0wkkwsIH6m8Z+hvalFLS/w1wEPtoaFYXk9vlGFH8s/fc/fBOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6999 On 27.09.2022 17:39, Roger Pau Monne wrote: > memory_type_changed() is currently only implemented for Intel EPT, and > results in the invalidation of EMT attributes on all the entries in > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > when the guest tries to access any gfns for the first time, which > results in the recalculation of the EMT for the accessed page. The > vmexit and the recalculations are expensive, and as such should be > avoided when possible. > > Remove the call to memory_type_changed() from > XEN_DOMCTL_memory_mapping: there are no modifications of the > iomem_caps ranges anymore that could alter the return of > cache_flush_permitted() from that domctl. > > Encapsulate calls to memory_type_changed() resulting from changes to > the domain iomem_caps or ioport_caps ranges in the helpers themselves > (io{ports,mem}_{permit,deny}_access()), and add a note in > epte_get_entry_emt() to remind that changes to the logic there likely > need to be propagaed to the IO capabilities helpers. > > Note changes to the IO ports or memory ranges are not very common > during guest runtime, but Citrix Hypervisor has an use case for them > related to device passthrough. > > Some Arm callers (implementations of the iomem_deny_access function > pointer field in gic_hw_operations struct) pass a const domain pointer > to iomem_deny_access(), which is questionable. It works because > the rangeset is allocated separately from the domain struct, but > conceptually seems wrong to me, as passing a const pointer would imply > no changes to the domain data, and denying iomem accesses does change > the domain data. Fix this by removing the const attribute from the > affected functions and call chain. Personally I think this adjustment would better be a separate, prereq change. > --- a/xen/include/xen/iocap.h > +++ b/xen/include/xen/iocap.h > @@ -7,13 +7,43 @@ > #ifndef __XEN_IOCAP_H__ > #define __XEN_IOCAP_H__ > > +#include > #include > #include > +#include That's heavy dependencies you're adding. I wonder if the functions wouldn't better become out-of-line ones (but see also below). > +static inline int iomem_permit_access(struct domain *d, unsigned long s, > + unsigned long e) > +{ > + bool flush = cache_flush_permitted(d); > + int ret = rangeset_add_range(d->iomem_caps, s, e); > + > + if ( !ret && !is_iommu_enabled(d) && !flush ) > + /* > + * Only flush if the range(s) are empty before this addition and > + * IOMMU is not enabled for the domain, otherwise it makes no > + * difference for effective cache attribute calculation purposes. > + */ > + memory_type_changed(d); > + > + return ret; > +} > +static inline int iomem_deny_access(struct domain *d, unsigned long s, > + unsigned long e) > +{ > + int ret = rangeset_remove_range(d->iomem_caps, s, e); > + > + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) > + /* > + * Only flush if the range(s) are empty after this removal and > + * IOMMU is not enabled for the domain, otherwise it makes no > + * difference for effective cache attribute calculation purposes. > + */ > + memory_type_changed(d); > + > + return ret; > +} I'm surprised Arm's memory_type_changed() is an empty out-of-line function. This means the compiler can't eliminate this code (except when using LTO). But then cache_flush_permitted() (resolving to rangeset_is_empty()) can't be eliminated either, even if memory_type_changed() was. While gcc doc doesn't explicitly say that it may help (the talk about repeated invocations only), I wonder whether we shouldn't mark rangeset_is_empty() pure. In a reduced example that does help (once memory_type_changed() is also an inline function) with gcc12 - no call to rangeset_is_empty() remains. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 08:36:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 08:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413206.656711 (Exim 4.92) (envelope-from ) id 1odSY8-00066Z-0e; Wed, 28 Sep 2022 08:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413206.656711; Wed, 28 Sep 2022 08:36:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odSY7-00066S-TS; Wed, 28 Sep 2022 08:36:11 +0000 Received: by outflank-mailman (input) for mailman id 413206; Wed, 28 Sep 2022 08:36:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odSY6-00066I-VL; Wed, 28 Sep 2022 08:36:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odSY6-0000Yz-RR; Wed, 28 Sep 2022 08:36:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odSY6-00012U-BE; Wed, 28 Sep 2022 08:36:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odSY6-0007Bf-Ai; Wed, 28 Sep 2022 08:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uMGW9BT5vBw4ky6xq4fbSqu4PRk5AsaBpc0Cdp03EKE=; b=J7CaGG2zYQ8vRLhpsEFSvEaGAn 9A7agLiB0+Dkmo6jGn+qQU6j68wRaoxk464EBmAZkjz3JF1z5Cn+b6H9KrkyRF83aT9YzW3suqpuu CL4awsG/I9VtJ75FtPXrtV2x+MEVNftM061UVQ7hamoblTmt6akl0kOBOc6z6KnICS9M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173347: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc X-Osstest-Versions-That: xen=5e936d11b171793c174686268c9c1df8a4fa974c From: osstest service owner Date: Wed, 28 Sep 2022 08:36:10 +0000 flight 173347 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173347/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc baseline version: xen 5e936d11b171793c174686268c9c1df8a4fa974c Last test of basis 173333 2022-09-27 13:00:27 Z 0 days Testing same since 173342 2022-09-28 01:00:28 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Michal Orzel Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5e936d11b1..211d8419ef 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc -> smoke From xen-devel-bounces@lists.xenproject.org Wed Sep 28 09:38:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 09:38:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413216.656732 (Exim 4.92) (envelope-from ) id 1odTWG-00042M-O5; Wed, 28 Sep 2022 09:38:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413216.656732; Wed, 28 Sep 2022 09:38:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odTWG-00042F-KR; Wed, 28 Sep 2022 09:38:20 +0000 Received: by outflank-mailman (input) for mailman id 413216; Wed, 28 Sep 2022 09:38:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odTWE-000429-G6 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 09:38:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2056.outbound.protection.outlook.com [40.107.21.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46a3ac46-3f11-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 11:38:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8408.eurprd04.prod.outlook.com (2603:10a6:102:1c9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 09:38:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 09:38:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46a3ac46-3f11-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/fBuDx7ceGZo5IY30qdAhrQpUM4tiT8sPrpYhNk2nzcgk9qke0pzZQil1wzVfFoiAoeIY+ZRmBljngvGgBQqTBeKf8Nc29hJyxuzUAYRiiDIBlkGOVGpaYLYZro63V5oKmTxaes9jij6d5k/k/OSfDUKSBwPj5TQlkh7r/xKUZE3BUeJ7pC634KMqskp9MWXQtKUViyVbAt1k6VXb8h41N5kOOx5oDFDynyI8TsAvPU1VtU9lEUhHrsS6Cv6Hi418BkKxEfywsnL41ScyHd1TVNl6vF/4TB2cF7cntE0CxVgRK83uTmOe68cE/GKWGznjCFEhn3heOWvmcqgpAvsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3y/YFVAnQrNnOe4c3BcaM0Eb3FyoO40E7RDG6ER9dk=; b=mmm5QKH4BlU5+cXvMH4bnyAevxK8/M6TCrYnJjpiVWeOyoLqMHVQYwXail/mCw4tI7jV+U4lPBq++IT/XEPiT1MK05El6GSPtqT3dmQeKNAsLduttpYcirfx1YuaIRnp3TKYZhwwBg/AQKO98GJvtkp6K1wT5M0L9vTUzizXqtVuajii7SBfQsU+Yy6e2qFFhino5RPHGXBKQviXMUT0em2eUhhcgl1iOONtwNzyzz7oUiOGAKfKYhOghI6WAiO6+7Xku84bnpozoSPKqlsrVcPZAyN8CwjDyvnPcEiFWgT95c4vXjwfRnayH7Dukdc53wdJx1QNkytkcZMmOKKWcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3y/YFVAnQrNnOe4c3BcaM0Eb3FyoO40E7RDG6ER9dk=; b=dhMBN7l9QG1cSwxblkuvVrVXxezl6auoZaccRE6gIUzuuf4YXf9mMRf0cGlYWHXbNwg+P1rl/RmDOiafFIYO4BjSWXejljv5uBuJ6e1o12fXpdMloRQ9hWSEyvpdsG2LnM9wMc4FZSHkOSWs46muZN1giQanS+JlR7cs07TqAFVuyoUNdd39CxUHADvO4HaLKcdbdANiCTC6sx1+RHUKF73IEpB+VxPgDS06uyvsXd89VabJXw5xFvxtHhwpVnkWnoB06Y9tniV3nsyTVOvgpPmYr0KAZPX18nYuYD2AZ/ovcfnCAm7o7ldZ3ck2F5om8d3YAzd7kRpSaqfNYyBeJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <59be45ca-e6e0-f235-56d4-4f6064750825@suse.com> Date: Wed, 28 Sep 2022 11:38:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session PVH dom0 Content-Language: en-US To: Juergen Gross Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel References: <8de37e96-cf67-2306-b586-dd45019a536d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8408:EE_ X-MS-Office365-Filtering-Correlation-Id: aae7bf7c-f54c-440b-6759-08daa1352967 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vd5lYfzZ/I8gwyXgLeQn70XZfwWU7mguwaWUd/t83lii9AJX5vZ7WcutfFDl4UrNvyCzb7DmWHdcvbufWkFq3WtYt4dQbNzxyFKPHprwZxOR8jkBWZTo5VaA0tJ4VjIBWDkaXqOEu3xdobtc/KA9LhT7sorUrAXZ2Fh8W1dusVrkIk0gxohmyq//LY9yGNqF2qbwIxp86o+760/PSqZabgu/l0mwoR+gF/NpZ7BWHsasLPaSr8w3Ryr0Vb0vgHlIsw+D0QmY30PkvjWU1tJ6HwmbwPQzPRQJg0prYIeHqjsQIaVw9sxi3U19KPlPt9GkZ4V6G0k1HSJfsX8QH9divCtRLhz6ePxOHoHYusP6qwN8tkKwGiq4hUP90UUzi9xDNovy1fZk8I2I/s9l3WxlldQhei9YjJyhM90fsOJdi21uJZ44IP4/IJWBL2DoBwx455zFv0oiptBM5FhnSlx8V/PSxvU0iCL/sZSM9ujYKHdnOIA0dfwhZ7lS5s74RD3v9o1fBtskIh/CHErzM6AN8GbddbNa7TD4xwmRQC5p4Yzy7nE7P089mEoQgHLhbtlPvoRsM0pWkYrmTllB0vU9pYCr5bZvFXb+t/ghu95CaVV8KUUmp0ak/b2/58bFOm3puJike5Y+n+CRmTL+GVLnd7wE81jtyHfwqYp9m4xr9lhOZiI3h7ZxnW5rCl3BByUdMdzSP0ZyKjeYJhCdycsFvNFc01dNaYgTUyDkBaz8iCIdGUOXJWuFXkymgjCve6R7qQmg533RPvFsMATz9eK+1F0QrNloiR5RacJbQnQsVIw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(136003)(39860400002)(346002)(451199015)(2616005)(186003)(38100700002)(5660300002)(6512007)(2906002)(8936002)(41300700001)(6486002)(53546011)(26005)(478600001)(6862004)(6506007)(8676002)(4326008)(66556008)(66946007)(66476007)(316002)(6636002)(37006003)(54906003)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ymx0UHB5TEdjd3dqWExIUDl1citidncrQUkwdzI5eTlGOTNyZERnZVh4SXVI?= =?utf-8?B?UEJ5WGJ2QmptUGZUTjJ3bEt4b0M5YVVpNzYzY0RWd1o4elV1d29ibVZLWjdD?= =?utf-8?B?a05RR3ZFVlZJQTVuNGswUmVQc2UyVlpTS0IrakwxcVZIeG5veThWa3pTd3hZ?= =?utf-8?B?ZG5zRkxjMW12VDJkV2hZVkwzUEptSDY2QkZJMTlrWDFyT2dROStPTHZVd1lK?= =?utf-8?B?U0RVcTNsRGZid2kyczJLd0xjWWF0YVFYbWx4UjNEM2podng1OS9udDBLcXJX?= =?utf-8?B?KzJDUjFLbDl3VWdwb2hoMUdVdXVoVkNIeHY2TDU5ak5BZkwrbkpEOVpBRFBT?= =?utf-8?B?aVNTQndBQkJjUjJ2WjE5SVBuREw3L2ZjRWFUdWtZS0lWZWhsU3JrUGxodkZH?= =?utf-8?B?cnhETzY1RUhhTFVuZVZhRG9XODBIVTRsSkVkM0JKYjFxakpWL3dGY3Z1R3A0?= =?utf-8?B?ZDU5aURxNm5iV09ZUzltaG1Lc3JxL25STytIOXNzc2NZditEQVE2VG9XcHdD?= =?utf-8?B?UU9YaFhEL0JESUNYdUpIL0FxM1BscTJjaGpyZkV6MktMSDhZalhyZDl3WTZs?= =?utf-8?B?S1htbUNreXJuMHBsczlVT3BDdkludHZaTHBERGI0alcxNzI4UTJEUkZmS2o0?= =?utf-8?B?UGlwUHNMYjVlZDZ5MWtRYTZqMmx0dDN0cTN2a1N2V2RpZ1owZ255OXcwaWRH?= =?utf-8?B?ckdJZHIyOE9yWXlOYXNrQXo0eXhtaGk2RVFGVUFOWkZzNWw5WlNBQmtjNWxw?= =?utf-8?B?VjBRdTUwakUyWjc1dzZwWDMxRGdlUVlKZjNVcitNOXA4NmRuRXk3SkFsVXR5?= =?utf-8?B?b1JJaGx5QXg5YkNLRW1GNzkyYTFmNm1lYkx6UG1UQ3FaMXlJdWpnVXZZOEdW?= =?utf-8?B?R2tZSzVmN0YwOGZURUlaTzN0UnREZjUwRDUvc0IrUTlnZUVNZHN1aGpLcE9r?= =?utf-8?B?U0VXYkVQdnRpcTR0QkVjT3M3c0hUMURmVXN2YTNEUWhFUWhhL1RmNUVid3pY?= =?utf-8?B?ZXJPZ0ptdzUxNzQrKzU1WmdsLys5aG1UUFhVMWNQNDg2MC9xQy92bXllZHB2?= =?utf-8?B?dHdQWDNVNG96MUFPOGQ0djNFTDlaNDk4NVlwT2p6TEhRMkpVMGhHVTBMbjRQ?= =?utf-8?B?b28zbDBGc0t4YlVsYmlsWkNKU1d2UnorOGVtUm9OODRzWXM3OS9mdytiWmJ2?= =?utf-8?B?TldOUVVJZU1tT2tBME1MUVNwYnJNN2pKK3Nrb0ZWeUg3dUFwdktlcHgwWGxx?= =?utf-8?B?Q3V1SmRUYlRlbDdraDlpMXJGb1JLWWRMYkNqbWdsSDF5TWJyZWNkelpSZDNa?= =?utf-8?B?UVh0SlFabzNuRVU5TitVTFgyeHlmeDN1TUYvK0JIWGN5Qjl3Zm9yeWhCSWRy?= =?utf-8?B?VHgrSThCNUs3S1pQek8yZTJOcFNyWE91WGZvOEFtT2w4WkZwN2w4bEhoZndo?= =?utf-8?B?ZDJVOHRoeHpONXBkeW5mSmMyZXVMbWFBMkM2VENnZ1JYMk13bUxPYUc3Q01Q?= =?utf-8?B?VFlVNUFiTkNBTmc5ZlBqVmJwdXBYdTVteUx5R2UxM3UySVdQaDA1V3NPWUQ2?= =?utf-8?B?MkhTUGtqdDVIWisrKzNtZ0VhRjhDRGJOOHg0aUVUckh6UXJ3d1pGbkRnYllv?= =?utf-8?B?WlZUa0J0Vm1PT3BBdXZpT1pxdnkycjIyVVJtbm95aFE3bHRSam42LzBHYTJ5?= =?utf-8?B?T3A0TWxPcDdJZWZIMFRpYzFEK1d5U3MxVXlhTnVWZWtaQkZWNFR1RGE2dmo1?= =?utf-8?B?b2hYQWtsUFVBOFhoSkN0RjE2em5mbUdRdmlOOFVoUm8zYThMTGc2RFNCbHY5?= =?utf-8?B?QjJwS3NkU1AvNWJ4cDRsV0QzWCtYdWRIS1BaRkZ6Q0poZGllNngrZ0d4WlN0?= =?utf-8?B?ZXNTS29LWmRmVHFOT1ZNNmVwSFVqRFJiK1U4b2VLbVZTOCtCMUtlM0RHdHQ2?= =?utf-8?B?WTVvekFkcHVkaHdseXZiWGxWL1hEYit0WElZYThCTWZDYzJyNVE5aVlFRm5n?= =?utf-8?B?ODdpdnlTYmhBRkxDWlpiait5dmdrVU9IZDdkN0RBTllncHlOeGpsN3lRYUha?= =?utf-8?B?WmQ4dDlRVzA3akhVMUxPK29RUzFTQWwzNW1uR3BYTklQTkg3K2VYdzVMRS9K?= =?utf-8?Q?/1/jjnA1zyFkrHSP4ML5OaHf1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aae7bf7c-f54c-440b-6759-08daa1352967 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 09:38:12.7890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n6CR4RSwC+7BTVkTCeI5QWYU11C5h8NJaEJXZlMgJ+69aLaFk7QlMw6ETWVUpyz6d49h6jDYc1jy1yVM8fHl3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8408 On 27.09.2022 09:02, Juergen Gross wrote: > On 26.09.22 17:52, Jan Beulich wrote: >> On 26.09.2022 10:33, Juergen Gross wrote: >>> On 26.09.22 09:53, Jan Beulich wrote: >>>> On 23.09.2022 10:20, Juergen Gross wrote: >>>>> My favorite solution would be some kind of buffer address qualifier for each >>>>> buffer (e.g. virtual, physical, SG-list, maybe nested SG-list). So the new >>>>> hypercalls would not mean "physical buffer addresses", but "qualified buffer >>>>> addresses". By requiring a minimum of 4-byte alignment for each buffer (can we >>>>> do that, at least for the new hypercalls?) this would leave the 2 lowest bits >>>>> of a buffer address for the new qualifier. If by any means an unaligned buffer >>>>> is needed sometimes, it could still be achieved via a single-entry SG-list. >>>> >>>> While this might be an option, I'm not sure I'd be really happy with such >>>> re-use of the low address bits, nor with the implied further restriction >>>> on buffer alignment (most struct-s we use are 4-byte aligned at least, >>>> but I don't think it's all of them, plus we also have guest handles to >>>> e.g. arrays of char). >>> >>> The unaligned cases could be handled dynamically via the single-entry >>> SG-list. >> >> Can they? The first example you gave, the bitmap passed to collect the >> output of XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, comes as a handle-of-uint8, >> i.e. generally large but not necessarily aligned (even if in practice >> the caller likely will pass a page aligned buffer of multiple pages in >> size). If we introduced physical-address bases replacement sub-ops, I >> think we would make the buffer described by an array of GFNs, not even >> allowing sub-page alignment or size. > > In case the buffer is crossing page boundaries, the SG-list would need to > have more than one entry, of course (assuming the SG-list variant is chosen). Of course, but that wasn't the point I was trying to get at. How would the (generic, i.e. alignment unaware) copying logic know the low bits are not a descriptor in this case? I'd rather not see us have e.g. both copy_from_guest_pv() and copy_from_guest_pv_unaligned() (nor a 4th argument to the former, to express the same). Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:08:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413222.656744 (Exim 4.92) (envelope-from ) id 1odTzW-0007XU-4O; Wed, 28 Sep 2022 10:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413222.656744; Wed, 28 Sep 2022 10:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odTzV-0007XN-Vw; Wed, 28 Sep 2022 10:08:33 +0000 Received: by outflank-mailman (input) for mailman id 413222; Wed, 28 Sep 2022 10:08:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odTzV-0007XH-56 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 10:08:33 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f12e800-3f15-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 12:08:30 +0200 (CEST) Received: from mail-bn8nam04lp2040.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 06:08:25 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6680.namprd03.prod.outlook.com (2603:10b6:510:b8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 10:08:23 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 10:08:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f12e800-3f15-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664359710; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=YCiVrptvJN7Cv2+8DJANRLciWDWo97azXMqwt9oR1ew=; b=Z2i/xuFA+ZVFTOeBmzX947eosrc4mAut2G3vqYQfeWC6bjlKHanK199T zeXuZlSNjdtdKWguHZqvqLHL37fSS7TVXNLERoQkqzVuUykApF1luMdFt J3DcS3y72nJbdgBhsFUE8BwMYw5GTS+21WOVAHAwPbqlzzch2eHDK8TCl U=; X-IronPort-RemoteIP: 104.47.74.40 X-IronPort-MID: 81502650 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ahcgSKrqNsbxjjBhE2jGiPR9J6heBmK0ZBIvgKrLsJaIsI4StFCzt garIBnSOquIYGWnc4gjOdzj9BwD6pXXyt8wHgs9rS0zHiNA8JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER7AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m3 OcbNTIvMBW6mc226YuQSM5yuJoZI5y+VG8fkikIITDxK98DGcyGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MkEotiNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+WwHuhBt9KfFG+3sBjv0yW2E8UMyEPWAuEr6GdtEKgavsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ l2Um9LkAxR/vbvTTmiSnp+eoCmuIyETISkHbDUdUAoey9D5pcc4iRenZuhkFKm5n9jkAwbay jqBrDU9r7gLhMtN3KK+lXjYhxq8q56PSRQ6ji3VQ2Tj6Ap6bYykYoWA6F7H4PIGJ4GcJnGCs WYFnY6C7ekIJZCLiCGJBu4KGdmB9/uDdTHRn1NrN50g7Ci2vW6ue5hK5zNzL1svNdwLEQIFe 2fWsAJVoZVVbH2jaPcrZ5rrU5hyi6/9Cd7iS/bYKMJUZYR8fxOG+ycoYlOM22fqkw4nlqRX1 YqnTPtAxE0yUcxPpAdajc9HuVP37kjSHV/ueK0= IronPort-HdrOrdr: A9a23:fy2Tiqm35Eeul/yhflUCWPAVNF7pDfOwimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81kydkTN9VLXKOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx mMryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idirP D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1PDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7AtD6V3amFazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu UGNrCQ2B9vSyLVU5nlhBgv/DT1NU5DXituA3Jy8PB96gIm00yQlCAjtY8idnRpzuNOd3AL3Z WHDk1SrsA+ciYnV9MDOA4/e7rINoXse2O5DIvAGyWRKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.93,351,1654574400"; d="scan'208";a="81502650" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVyc6YZwEH2n+QxqjI9Dg49MTiOG+XmCYqXXAwDKWCeT8Uxxj65qxfsdy+zziEjkB/ttvryLna78J96X2WsMwinkMDCWVOi1cBwa70YDOS9uh//nJKAg6sjppeOvJlfWoDLLHU3W7BiVGQutDxzVRnAhklgFwvWizjV+rWhqcjqlaSOKtlbpsC5F0Qv/jt+cAmm33m9CcWwAQSdpJNAV1ezW9J87pnjazAeK5SJectPp2bd3HpgLi2pGpEEs/AZK90yK9q3L2DlfbL0oHCFcHrDQrJ77oZZQ7n6rGjx06KJxg3m6/LjQ4bWAgQdFaU5t+aBFqOHsPAzTuPAGOobjjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ePhxvt2zlcSYriCgVKyNQZELQ9eTrq7ZD5C+Vj2xrQ=; b=AD/al+wpka6LWjT17fTjqrZ8rbLqLDm0D7CxyqtA10ksSwVXbxHAA1T7fOHbW2m42Xxi8LoNazmSTz4OjnmC00vdSvOqTGpO8K7zwHukuE9T3dPywLFBzE40BwXBjsQvnIDPDPebZ/Zk/AXuJDoR6KFsCFkwF4wjqbQEeYBDfGpz8paVb4M3jncDvwkJkFALUEb2FYR0RNY4oarr3QzA8LkdeTntl5xfp19HbCoGnpc0ldxSSQlstr/nS6T+zetU0JgcAv5Db0MQsfWH5gHcU+ffijKTZBThnWKpzGSx0XcrEpUyv64ho1xNauS9wOlMLaF+ynl2PR1KgRbgIynK/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ePhxvt2zlcSYriCgVKyNQZELQ9eTrq7ZD5C+Vj2xrQ=; b=W3iCbXicAxJWiK6KfsYBAcRUUaO+bEafKS+mFhcRu8Iw9WtS0DF0lEe58zNg4/2g0DChmOYvRfcznc5hD8GTfMIibkznRrojo8qd9PYtxLd2dqDmA5Sq0puj6G45vHmrCf0zadI2CviB7mzBwu6c8JvarhkeHi7XbCk16Jm1hrA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 28 Sep 2022 12:08:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220927153937.39389-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6680:EE_ X-MS-Office365-Filtering-Correlation-Id: 53129023-6781-4ca4-c4e2-08daa139606f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pz6zypkpg/4M0xaPboK+HBYOjXIOBLDfsiNv8S8YxzD5nDrtqgXa/D+pUI7c6dVWSEdzlc029NrDEt5LBUFLAW8CO6K+DOjOiBH2/FILU1QGze+pj3K9jNbi8bjwuChbiAnUOQalMgA6HLSbzbUNP0evXzhU0N9KhXqwTjfr/uzu5Dh09oa3BierLEUJ+Nj2kOlRDJKOB8iTWMSHgi6WMcdM/uUWB9DK1CZc7WfhbRE+5aICdifjCmrl3Bicr3YYwDt+Kq5XAs5P2nVZ1wUY8YnUBHU8jBGWR5fRaZRbFUevTiCYCYv3ADga6D9cZkQhsUt3DjiGIOhSAC1FoTKtCTHaGqsk4Jk04eV4dnpKIPsPBuq0jHygEDqLT2M56kQt1b93KALIkOrS9vDx7JbDN549WEXJDc6FPvYuzViLMWGLZJJYa8Y9iyDRSHGaYyDlp2mKnzvPPWQB4o5pQDmZkUKpCjfsKI3zVy+rf2aKQex/WgG4R1kdJPT5cSpKXGbjIwZyLxVUCcmgRYUNpmzFeErHGGtNsnGE1z5UW05XL7mAvSvrYEKKdY40RR7J3l1TRQoi52yrt7RYcDhscypyndIyfh+0JGsyGnMHlDZTeylgCPC3J7yEnwGb9lLjiGKonvJynifZ4jAIFyYjMrg2aW8dtA4BLDljeFUy9C+6pqdERdlRlQpuSFYCWJ9zLmKz4YAosrShy5gzsmSz6ydBAw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(6486002)(85182001)(83380400001)(82960400001)(86362001)(38100700002)(186003)(478600001)(6666004)(8676002)(6506007)(26005)(9686003)(54906003)(53546011)(6916009)(316002)(6512007)(8936002)(66476007)(5660300002)(66946007)(66556008)(2906002)(41300700001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clhWbzhNMlE4OUkxK1Y5TEx3UW8veW5qNFFUVXV0Tzl3NjFGWUcvcHplYXQ1?= =?utf-8?B?b0VyMGZPQlRHb1lTV3ZXZENxbXFzOVkvUDdrWHVvNE93akp1R0pWdGhtVWs4?= =?utf-8?B?SVBtbjdhSTR3b0hvS0NSTW1NYVNSNzc0OG5aMktHcDlCbnFWTDhqeHBFWElG?= =?utf-8?B?b3lTU1hJb1RTM2hhRHlGOEpQbWg0NzlKNDI2YWUwelBJeC9kd0djN1BVaWJV?= =?utf-8?B?eGNDcEpWSk5BMFB5cTR0em5vRVp5MHJpZDFrWmdxWDBDYkxiRlJmY2lEQWtS?= =?utf-8?B?Y21GQUNrZXVZbDFlWHlFL2lPWkcvUXhxNWxta0xCWlk2YTk5TGpjMzVzWGRk?= =?utf-8?B?U1VtSHQyNTV0dTFpdWZ0Q3VmS0p0U0I0RVl6cmh6M2JqKzViNXl3ZGpaTHhz?= =?utf-8?B?Tnoydi9MWEhIQ25jUytxUnQvRHp3M1BxcDhSSHgzZUxHcmhNNFN2U3h6aVMr?= =?utf-8?B?eFJORER0OU02RS9xMkppSVM5MEEzcG9lOHp5VlRzUU9sZzlicUpiWDIvbUxX?= =?utf-8?B?MVNNUG9qcFJzU0oyNTNtZjhPaG1pT2FKZmlJaDcrazNsaUlOODZYNnlwMTBL?= =?utf-8?B?Z0FhbTFHUXM3SjdnZmtpVHFtZEFDUkNkQTFkeVJ5Y25ZTjE1b2RqQjJjZnV5?= =?utf-8?B?TW11VjVCR0lZaW1XS25BczBFWWlWYmNqNll5K1I5ZkhJeWFteklzWHRuRVBs?= =?utf-8?B?bGd2L2o4TldoWmw1eG12WVhPQzZUc2tFMDZtRTNRcTdzTkd4MW90MU0xdzhS?= =?utf-8?B?QTRhcnp6UENxUUNJK1ZjaVYyTWpNQVg0bGNSMWRJMVVsQ2lHUHN2R1d6SXNi?= =?utf-8?B?cEJzUERJdlhLenJ5eEUrR29vbmQ5cDh2ZU8yU3RLMGZLNU5QekltdE10dmpl?= =?utf-8?B?THVEQzUvbWk3YTQ2ZEZNdWovQ0Y1enIxbWJRUXdrQ0F2UXBhRmpYYnRmemdR?= =?utf-8?B?N0l2RjZ5MWs1a2MzMUhpaVlEMFBBSytSbWJnWGorcDVFVDFnaS8xQ0d6Q0E3?= =?utf-8?B?amhGZmJsUFdpMEhxa1NjK0JabUVFOFFzQ2YvMkw3YmlETHVjVllIbUZ3VmE1?= =?utf-8?B?aFpjRVRic3huTlpJUmQrOUEzdVJFU1prN1g2QUlpYXZSRUJrRGpPRTN6Z1lC?= =?utf-8?B?Q3JUNk5hMmhPNEdJM0p2UzdFUyt3bUptVnYxNDJ0cldhcVY3eWtMS3Y0QTB3?= =?utf-8?B?UnVoaHJnUEdKY1MzMzRiWVVyRUlUYy9QOCtkTkJwK0huY2VrQzd5L1RrbE9R?= =?utf-8?B?NmdoY0gyZ2tGWlV1bmJCSURXN0h0YXo5OWZlOWYwSG1Sa0krdjZ5T0YyRjk5?= =?utf-8?B?QWwwb05mb1JjWlcyaWtrUUhrWHhGenpmM09tYzBtVGJYa2ZNalE2a0dPS0Fm?= =?utf-8?B?cW5iOXF1UExSY3ZmbDB4bXB3RjFscm5obU81cFVnRlBsYmlaZGppNFhBMExl?= =?utf-8?B?T0FxckYralFQOEpMQndFZkxhY2xyRjZieTRhYnkyNkxmSWJXQVdoTnFMV25O?= =?utf-8?B?K3haekZkNGIzd002WGpvSlR5KzZrRC9ETXd5anI0Skk3aWJKNjY5VVZJVzNp?= =?utf-8?B?dlBuMDU5emc3NjNvZ0J4dnUrKzVicFB3dXNTWDBEM1h3cENNTGJmSDF4V2RU?= =?utf-8?B?TjgxditER0ZHdDVkWE1DekRjYUhSTUtWSzdCUWRWZFRvYS9QbE5iaUpZQ1hH?= =?utf-8?B?SkQ2WFZOdTc2dCs4N2JJMUNzRUNrN2JCbjJrOFcyTVZoZ3NXd25MT2w4L3Nh?= =?utf-8?B?bkd2MlZuYXJ2MktTcWZKOEd4ekJFZGFkdzRBTHUxY3UzMUZ6STBqc28vWWNR?= =?utf-8?B?eitRVWNzL2lnbFgrZXFXMXhyeXg3bHlLWC9QMzRwSDRmQ2h4Y0prTzZXVnB2?= =?utf-8?B?MmxTTko0cXlLQTFsUWFmRUFkWEFSTys0aUpEVDF5cERFdzlXV2UyU2NZTU94?= =?utf-8?B?SlpGMFVZcDd4cDQwTUVsdHRBanlWVTh4NVFxaU9qMnBwWURqZkN5aGkyeHE0?= =?utf-8?B?alhjVTJWL1l4VnFaY2xsVEFPK05TVElrcU5pR2hoaHozdXJKWnJOSnhWNFdO?= =?utf-8?B?QUxReHhjUklVUmFRUUt1Vk51Z0RRRThKblBvQi9VODU2UUdnYkh2MmdKcUFC?= =?utf-8?B?WE1WM1ByUzZnckFpR01OOXNML21PYzVjSEtkaVFiRmhMaytxY1ZNNzRPMDRU?= =?utf-8?B?MVE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53129023-6781-4ca4-c4e2-08daa139606f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 10:08:23.2460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bPXpbEymZXYNQiWZvN9c6ZYu0DfOUtKEdrhbRtG4QCbPh0ob1FhtesNAg59MUVL0anjWmFBMmFXVTP1jels/lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6680 On Wed, Sep 28, 2022 at 10:01:26AM +0200, Jan Beulich wrote: > On 27.09.2022 17:39, Roger Pau Monne wrote: > > memory_type_changed() is currently only implemented for Intel EPT, and > > results in the invalidation of EMT attributes on all the entries in > > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > > when the guest tries to access any gfns for the first time, which > > results in the recalculation of the EMT for the accessed page. The > > vmexit and the recalculations are expensive, and as such should be > > avoided when possible. > > > > Remove the call to memory_type_changed() from > > XEN_DOMCTL_memory_mapping: there are no modifications of the > > iomem_caps ranges anymore that could alter the return of > > cache_flush_permitted() from that domctl. > > > > Encapsulate calls to memory_type_changed() resulting from changes to > > the domain iomem_caps or ioport_caps ranges in the helpers themselves > > (io{ports,mem}_{permit,deny}_access()), and add a note in > > epte_get_entry_emt() to remind that changes to the logic there likely > > need to be propagaed to the IO capabilities helpers. > > > > Note changes to the IO ports or memory ranges are not very common > > during guest runtime, but Citrix Hypervisor has an use case for them > > related to device passthrough. > > > > Some Arm callers (implementations of the iomem_deny_access function > > pointer field in gic_hw_operations struct) pass a const domain pointer > > to iomem_deny_access(), which is questionable. It works because > > the rangeset is allocated separately from the domain struct, but > > conceptually seems wrong to me, as passing a const pointer would imply > > no changes to the domain data, and denying iomem accesses does change > > the domain data. Fix this by removing the const attribute from the > > affected functions and call chain. > > Personally I think this adjustment would better be a separate, prereq > change. Right - I was about to split it but didn't want to go through the hassle if the approach didn't end up being well received. Do you think placing the calls to memory_type_changed() inside the {permit,deny}_,access is acceptable? > > --- a/xen/include/xen/iocap.h > > +++ b/xen/include/xen/iocap.h > > @@ -7,13 +7,43 @@ > > #ifndef __XEN_IOCAP_H__ > > #define __XEN_IOCAP_H__ > > > > +#include > > #include > > #include > > +#include > > That's heavy dependencies you're adding. I wonder if the functions > wouldn't better become out-of-line ones (but see also below). > > > +static inline int iomem_permit_access(struct domain *d, unsigned long s, > > + unsigned long e) > > +{ > > + bool flush = cache_flush_permitted(d); > > + int ret = rangeset_add_range(d->iomem_caps, s, e); > > + > > + if ( !ret && !is_iommu_enabled(d) && !flush ) > > + /* > > + * Only flush if the range(s) are empty before this addition and > > + * IOMMU is not enabled for the domain, otherwise it makes no > > + * difference for effective cache attribute calculation purposes. > > + */ > > + memory_type_changed(d); > > + > > + return ret; > > +} > > +static inline int iomem_deny_access(struct domain *d, unsigned long s, > > + unsigned long e) > > +{ > > + int ret = rangeset_remove_range(d->iomem_caps, s, e); > > + > > + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) > > + /* > > + * Only flush if the range(s) are empty after this removal and > > + * IOMMU is not enabled for the domain, otherwise it makes no > > + * difference for effective cache attribute calculation purposes. > > + */ > > + memory_type_changed(d); > > + > > + return ret; > > +} > > I'm surprised Arm's memory_type_changed() is an empty out-of-line function. > This means the compiler can't eliminate this code (except when using LTO). > But then cache_flush_permitted() (resolving to rangeset_is_empty()) can't > be eliminated either, even if memory_type_changed() was. While gcc doc > doesn't explicitly say that it may help (the talk about repeated invocations > only), I wonder whether we shouldn't mark rangeset_is_empty() pure. In a > reduced example that does help (once memory_type_changed() is also an > inline function) with gcc12 - no call to rangeset_is_empty() remains. Can look into it, do you want it to be a prereq of this patch? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:17:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:17:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413231.656754 (Exim 4.92) (envelope-from ) id 1odU7s-0000hn-1b; Wed, 28 Sep 2022 10:17:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413231.656754; Wed, 28 Sep 2022 10:17:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odU7r-0000hg-Uz; Wed, 28 Sep 2022 10:17:11 +0000 Received: by outflank-mailman (input) for mailman id 413231; Wed, 28 Sep 2022 10:17:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odU7q-0000ha-NG for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 10:17:10 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5e1c087-3f16-11ed-9649-05401a9f4f97; Wed, 28 Sep 2022 12:17:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E090C1F8F1; Wed, 28 Sep 2022 10:17:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A30C213A84; Wed, 28 Sep 2022 10:17:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hYdWJiQfNGMYBQAAMHmgww (envelope-from ); Wed, 28 Sep 2022 10:17:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5e1c087-3f16-11ed-9649-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664360228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wz7LqQTQwqN6NuJlrmtHY6fei9eDMFzYM6kbeSQmCqQ=; b=TjkY+rledB7HirNbJDSyrYBGbMIM5nX00jcZjurberAlTXb82wxeHE7UbWoUzgGReh9+4e 8A+3nKQojGje/1y7PmnSYtnNwGRHOw0dg2HGbOPg0xRBMQHTwVVm30rWwgRoWItCF2z4ZQ uk7QFFIiDY5a46qvowKfwJkadkZyF8I= Message-ID: <699aacca-b82a-78df-3a74-4b5b82de92c2@suse.com> Date: Wed, 28 Sep 2022 12:17:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-4-jgross@suse.com> <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> Content-Language: en-US Subject: Re: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag In-Reply-To: <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------F5icf01H3NZlsmrz1JnX9ERL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------F5icf01H3NZlsmrz1JnX9ERL Content-Type: multipart/mixed; boundary="------------HLiW1ScmoygFeF2gnYyGwTIf"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <699aacca-b82a-78df-3a74-4b5b82de92c2@suse.com> Subject: Re: [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-4-jgross@suse.com> <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> In-Reply-To: <80085512-5783-7ea0-fb7d-6e852f8942e0@suse.com> --------------HLiW1ScmoygFeF2gnYyGwTIf Content-Type: multipart/mixed; boundary="------------xKotCnUiVNlmCt3z0wqbHP9g" --------------xKotCnUiVNlmCt3z0wqbHP9g Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDkuMjIgMTE6MTAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDExLjA5LjIy IDEyOjE2LCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6DQo+PiBPbiBUaHUsIFNlcCAwOCwgMjAy MiBhdCAxMDo0OTowN0FNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+IGRpZmYg LS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jYWNoZWluZm8uaCBiL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL2NhY2hlaW5mby5oDQo+Pj4gaW5kZXggODZiMmUwZGNjNGJmLi4xYWVhZmE5 ODg4ZjcgMTAwNjQ0DQo+Pj4gLS0tIGEvYXJjaC94ODYvaW5jbHVkZS9hc20vY2FjaGVpbmZv LmgNCj4+PiArKysgYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jYWNoZWluZm8uaA0KPj4+IEBA IC0yLDYgKzIsMTEgQEANCj4+PiDCoCAjaWZuZGVmIF9BU01fWDg2X0NBQ0hFSU5GT19IDQo+ Pj4gwqAgI2RlZmluZSBfQVNNX1g4Nl9DQUNIRUlORk9fSA0KPj4+ICsvKiBLZXJuZWwgY29u dHJvbHMgTVRSUiBhbmQvb3IgUEFUIE1TUnMuICovDQo+Pj4gK2V4dGVybiB1bnNpZ25lZCBp bnQgY2FjaGVfZ2VuZXJpYzsNCj4+DQo+PiBTbyB0aGlzIHNob3VsZCBiZSBjYWxsZWQgc29t ZXRoaW5nIG1vcmUgZGVzY3JpcHRpdmUgbGlrZQ0KPj4NCj4+IMKgwqDCoMKgbWVtb3J5X2Nh Y2hpbmdfdHlwZXMNCj4gDQo+IEluIHRoZSBlbmQgdGhpcyB2YXJpYWJsZSBkb2Vzbid0IHNw ZWNpZnkgd2hpY2ggY2FjaGluZyB0eXBlcyBhcmUgYXZhaWxhYmxlLA0KPiBidXQgdGhlIHdh eXMgdG8gc2VsZWN0L2NvbnRyb2wgdGhlIGNhY2hpbmcgdHlwZXMuDQo+IA0KPiBTbyB3aGF0 IGFib3V0ICJtZW1vcnlfY2FjaGluZ19zZWxlY3QiIG9yICJtZW1vcnlfY2FjaGluZ19jb250 cm9sIiBpbnN0ZWFkPw0KPiANCj4+IG9yIHNvIHRvIGRlbm90ZSB0aGF0IHRoaXMgaXMgYSBi aXRmaWVsZCBvZiBzdXBwb3J0ZWQgbWVtb3J5IGNhY2hpbmcNCj4+IHRlY2hub2xvZ2llcy4g VGhlIGNvZGUgdGhlbiB3b3VsZCByZWFkIGFzDQo+Pg0KPj4gwqDCoMKgwqBpZiAobWVtb3J5 X2NhY2hpbmdfdHlwZXMgJiBDQUNIRV9NVFJSKQ0KPj4NCj4+IFRoZSBuYW1lJ3Mgc3RpbGwg bm90IG9wdGltYWwgdGhvIC0gbmVlZHMgbW9yZSBicm9vZGluZyBvdmVyLg0KPj4NCj4+PiAr I2RlZmluZSBDQUNIRV9HRU5FUklDX01UUlIgMHgwMQ0KPj4+ICsjZGVmaW5lIENBQ0hFX0dF TkVSSUNfUEFUwqAgMHgwMg0KPj4NCj4+IEFuZCB0aG9zZSBzaG91bGQgYmUgQ0FDSEVfe01U UlIsUEFUfS4NCj4gDQo+IEZpbmUgd2l0aCBtZS4NCj4gDQo+Pj4gwqAgdm9pZCBjYWNoZWlu Zm9fYW1kX2luaXRfbGxjX2lkKHN0cnVjdCBjcHVpbmZvX3g4NiAqYywgaW50IGNwdSk7DQo+ Pj4gwqAgdm9pZCBjYWNoZWluZm9faHlnb25faW5pdF9sbGNfaWQoc3RydWN0IGNwdWluZm9f eDg2ICpjLCBpbnQgY3B1KTsNCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYva2VybmVsL2Nw dS9jYWNoZWluZm8uYyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvY2FjaGVpbmZvLmMNCj4+PiBp bmRleCA2NjU1NjgzM2Q3YWYuLjNiMDVkM2FkZTdhNiAxMDA2NDQNCj4+PiAtLS0gYS9hcmNo L3g4Ni9rZXJuZWwvY3B1L2NhY2hlaW5mby5jDQo+Pj4gKysrIGIvYXJjaC94ODYva2VybmVs L2NwdS9jYWNoZWluZm8uYw0KPj4+IEBAIC0zNSw2ICszNSw5IEBAIERFRklORV9QRVJfQ1BV X1JFQURfTU9TVExZKGNwdW1hc2tfdmFyX3QsIGNwdV9sbGNfc2hhcmVkX21hcCk7DQo+Pj4g wqAgLyogU2hhcmVkIEwyIGNhY2hlIG1hcHMgKi8NCj4+PiDCoCBERUZJTkVfUEVSX0NQVV9S RUFEX01PU1RMWShjcHVtYXNrX3Zhcl90LCBjcHVfbDJjX3NoYXJlZF9tYXApOw0KPj4+ICsv KiBLZXJuZWwgY29udHJvbHMgTVRSUiBhbmQvb3IgUEFUIE1TUnMuICovDQo+Pj4gK3Vuc2ln bmVkIGludCBjYWNoZV9nZW5lcmljOw0KPj4NCj4+IFRoaXMgc2hvdWxkIGVpdGhlciBiZSBf X3JvX2FmdGVyX2luaXQgYW5kIGluaXRpYWxpemVkIHRvIDAgb3IgeW91IG5lZWQNCj4+IGFj Y2Vzc29ycy4uLg0KPiANCj4gT2theS4NCj4gDQo+Pg0KPj4+IMKgIHUzMiBudW1fdmFyX3Jh bmdlczsNCj4+PiAtc3RhdGljIGJvb2wgX19tdHJyX2VuYWJsZWQ7DQo+Pj4gLQ0KPj4+IC1z dGF0aWMgYm9vbCBtdHJyX2VuYWJsZWQodm9pZCkNCj4+PiAtew0KPj4+IC3CoMKgwqAgcmV0 dXJuIF9fbXRycl9lbmFibGVkOw0KPj4+IC19DQo+Pj4gK3N0YXRpYyBib29sIG10cnJfZW5h YmxlZDsNCj4+DQo+PiBIbW0sIEkgZG9uJ3QgbGlrZSB0aGlzLiBUaGVyZSdzIHdheSB0b28g bWFueSBib29sZWFuIGZsYWdzIGluIHRoZSBtdHJyDQo+PiBjb2RlLiBUaGVyZSdzIG10cnJf c3RhdGUuZW5hYmxlZCB0b28uIDstXA0KPj4NCj4+IENhbiB3ZSBzZXQgKG9yIGNsZWFyKSBY ODZfRkVBVFVSRV9NVFJSIHRvIGRlbm90ZSBNVFJSIGVuYWJsZW1lbnQgc3RhdHVzDQo+PiBh bmQgZ2V0IHJpZCBvZiBvbmUgbW9yZSBib29sZWFuIGZsYWc/DQo+IA0KPiBJJ2xsIGhhdmUg YSBsb29rLg0KDQpIbW0sIHRoaXMgbWlnaHQgYmUgYSBsaXR0bGUgYml0IHJpc2t5Lg0KDQpJ dCBjYW4gYmUgZG9uZSwgYnV0IHRoZW4gWDg2X0ZFQVRVUkVfTVRSUiBjb3VsZCBiZSBzZXQg ZXZlbiBmb3IgY3B1cw0KTk9UIHN1cHBvcnRpbmcgaXQgKHRoZSAzMi1iaXQgc3BlY2lhbCBj YXNlcyBBTUQsIENFTlRBVVIsIENZUklYKS4NCg0KU28gd2UgaGF2ZSB0aGUgZm9sbG93aW5n IGFsdGVybmF0aXZlczoNCg0KLSBkbyB0aGUgc3dpdGNoIHRvIFg4Nl9GRUFUVVJFX01UUlIg cmlza2luZyBjb2RlIGJyZWFrYWdlIGZvciBsYXRlcg0KICAgY29kZSBjaGFuZ2VzIHF1ZXJ5 aW5nIFg4Nl9GRUFUVVJFX01UUlIgYW5kIGFzc3VtaW5nIHRoZSBNVFJSIE1TUnMNCiAgIGJl aW5nIGF2YWlsYWJsZQ0KDQotIGtlZXAgdGhlIGN1cnJlbnQgYm9vbA0KDQotIHJlcGxhY2Ug dGhlIGJvb2wgd2l0aCBtdHJyX2lmICE9IE5VTEwNCg0KLSBhZGQgYSBuZXcgc3ludGhldGlj IGZlYXR1cmUsIGUuZy4gWDg2X0ZFQVRVUkVfTVRSUl9FTkFCTEVEICh3aGljaCBpbg0KICAg ZmFjdCB3b3VsZCBiZSBqdXN0IGEgcmVwbGFjZW1lbnQgb2YgdGhlIGN1cnJlbnQgYm9vbCkN Cg0KTXkgcHJlZmVyZW5jZSB3b3VsZCBiZSB0aGUgcmVwbGFjZW1lbnQgd2l0aCBtdHJyX2lm ICE9IE5VTEwuDQoNCg0KSnVlcmdlbg0K --------------xKotCnUiVNlmCt3z0wqbHP9g Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------xKotCnUiVNlmCt3z0wqbHP9g-- --------------HLiW1ScmoygFeF2gnYyGwTIf-- --------------F5icf01H3NZlsmrz1JnX9ERL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM0HyQFAwAAAAAACgkQsN6d1ii/Ey/j 3wf7B3/WRDWgT5gzaKKNYA1NYwuZUjnDzHowMPGW6+BwIrde50hzjUTFy2VN+cYH+xEdWnV7Zt8s J4KEtqO/rP7+WcpgNuFre42q4Vk6yWKauU14QYzkkwcJNxvPsGYBm87HLGTKchN0jvfuWs5gCQw6 hkmWiFy8OIHm932arXoGtdbQaj1RXOKNoNWYpFpYhqk3MJwYWvZMrR2JlDx7CcUHNPS9jERiMBEM qzL/eOMluT3Uubpe4H71KYZH8Zf7B5z6lcoZD860Hwm6fvjhzoNop59+qIBvVj+v8zDzWo9mdrCZ 0xHm9ZEwYgDPtgE+Usu7Exv9imkH1gEqO2sDfs1uOg== =pGLf -----END PGP SIGNATURE----- --------------F5icf01H3NZlsmrz1JnX9ERL-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:39:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413238.656765 (Exim 4.92) (envelope-from ) id 1odUSy-0003Cw-Se; Wed, 28 Sep 2022 10:39:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413238.656765; Wed, 28 Sep 2022 10:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUSy-0003Cp-Pj; Wed, 28 Sep 2022 10:39:00 +0000 Received: by outflank-mailman (input) for mailman id 413238; Wed, 28 Sep 2022 10:38:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUSw-0003Cj-H2 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 10:38:58 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20082.outbound.protection.outlook.com [40.107.2.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c008100c-3f19-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 12:38:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8266.eurprd04.prod.outlook.com (2603:10a6:10:248::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 10:38:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 10:38:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c008100c-3f19-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUN+Zgtq/ERr9TJk+YGNrhLZszNGewLN7GwWmuUp8L9WwUDQN9rjSQALJe0aEUu4P53ZTxUmh35jCTUPiheW25GDpbLR90nxvHg/VKl8EzuiRiyy8u5EgSO+WhYZpuD3okhjuKG4T0McPfoUfyRTLPBBMQYsiCsBNhHg/KCxBTfsP3UPa6EgPkdX5NlX6K23twTCtkFW+nHkFt98wRG6ZwPpfBSwUBi/Xy+Q5kbf53g32GTn0HSub4Pdn2SVSPHs/Vl2Xu0zko9m1E3jQge5/ToRKX/k0wNPxIZZwljbWz38u7Ckgu6AAPpWqduEjFl4Pg2oMQrXgkFbwfpXJnnpHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jfWMOan+uoAcjsejIGu8nn0qvygWqJEXOw6ZleEbVkA=; b=JzWLYoRfhP+CBr6rWfgs3jp7Qma56Py4t2/p4YAHrIk0/7cjY+5yHYUXv0y3A9G0NeUcxeW95xeOUaqoez2IzsGwdPE46y9Sc+A/2UfF/NEsYzZJSVZkBweiQB5hBDn2/ESUbMqmoyMJJ+aeJwUINy9eXsaQU48WU1t3xaHOFM6FQNxMC/5jRajfzN3o9HV/YHWf+Mw9kxfpBgKWM4wEFttf8aUKyKPJBGJCG4N/HwJ3lYHBvZ9rPBOapg6sCXk1jj55ImyeniqIOpMl0ePVJquS0fynZUf6o8q6RXt+4UQyPQuqXGCP/StbVBhBM+lZK/ptRbZ2HPAn5IoAUnSIDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfWMOan+uoAcjsejIGu8nn0qvygWqJEXOw6ZleEbVkA=; b=QeL70Qk3qG8AThllaK/4Elo+w7xynZILMBS7A3o9YDd14XRjBRsyTcEXcBLPZ+qlpn2duboSMQ71VHGguZW+wOdYUMoUXhXz+YwfiaMcor+qSaIUMCg0U7wGONPpWv3QeXau3ICBG+V1ZJ/MICWYSGNJn9OWuZfrtpGMbVCMurXHK0A9S122yz4XeMLcth6ZYgH5+/LXvoUOhyay0LGsNEYwuIrWrs1i5OZahOkmDdCrFW1N3Rg8TgiUmsL77I/hUZhpZT4iJjOjmG4olyy2fVFx9+zlg/k4PmvSV0Evv52fcULTh4+nKoQ9JNGWl01vTHeHriAXiPiteXvF/Px3yQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> Date: Wed, 28 Sep 2022 12:38:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US From: Jan Beulich Subject: Proposal for physical address based hypercalls To: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8266:EE_ X-MS-Office365-Filtering-Correlation-Id: 585914db-2a87-4262-e228-08daa13da34d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xTTBOAqKT2euz2iJKsqjfK/PUwQlhqthmeKnQm4WuDqA2UViZDum1JRubq969Pldu9UpjMMgzUAx/jVWL4B6+zJ7lbxNd5f7kPh888xI6KBseGxn/1bCZ204pVd4lg5ziaU7lZFSE4MI9C/QTxIpMowySgorCxduUKDb9xNx/Ih/BbOu7wnxejU/KFYzKMR5BrPn4vNCrqOqsAOBpq3rP2QdzYASx4H87lNajkqi9KKfSoJadm5egWAAea63RBsY4nZOBGbUmERW5jLwQg6px+q/0lcLT615f3KawHIqDepNbLgz4OhIX4jlRnSODT1UW8qNLhBnoHUJ1dJuPDppx7+VDtXr5yYnhr1/59IxydNS806UgwM53askpBCcXXDaKMZ7Y8/EUFri1V8tevwWYf1ikw74GH4rZ4J1kQK0awOmh4pAEcVzpuygzrUxnSNdKkQKcD9oNi97mriisWRmSPdvB6wFGw9BGAM1R/Og/yjMWVAE5ZmEV9OjmFtwdvWH/NznWyubjFKqun3C39nFulrYAAJk1XxW3VYNsRpP/2xLYsC9kfzAX07xOQxXP5JIUDMaaIgPpr3lOTj4SdA+7e1GVporlxKoVzhWkDabWJvsR+uCTHcq3ibNfXk0Lwrl0JYv3J4joELFRgd44DonSvojUns6yh0zKRwhhWn9+4nuXdNBG1EsVRrdboKzpcXeI3h/1tn188eqTWDOzFATtohHl1402umjpqREvK4STVU6tkgnLwSzHlKkvBesgmPGlIOn80X4v5trZfxojjugko66iThQw7lRdSxwTXvMc08= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(366004)(396003)(136003)(451199015)(478600001)(6486002)(31686004)(6506007)(186003)(316002)(6916009)(2906002)(2616005)(38100700002)(83380400001)(66574015)(26005)(6512007)(36756003)(41300700001)(8676002)(66946007)(86362001)(31696002)(66556008)(8936002)(5660300002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azRCd2JoSmltUGFVSE5qcVNGblgycTdqM0dXRUpKNFBSdUdDS2xyZkVmSEdH?= =?utf-8?B?ZmwyRGVLUTkvbXRBOElZNzNLWHpJM1ZhQUI1cVZpUW1oWUZTU1lhSXNlQTRi?= =?utf-8?B?bzQvamFHMGgrQjJGMmVtSnlqeHgwK3puMGhwbUx3bzVQbVA0OXYvcnBSUFY2?= =?utf-8?B?SE9DaDUvSnZBQ0x5cnFLNDJpdisyYkcxSUlVZWd5NkpGdVZicmFCZFVIaVNx?= =?utf-8?B?d3NNbkNpSUxFdGlQamswWkY5dlhtSnFrUmhlK3ZGSVNWR0c0Mm5yUzJRV2hY?= =?utf-8?B?Z2pCdjI3bVZZanBlcWpNZExFb2VFSlZxdDBQYzcvVnpscmZXSGJwTC93Nitm?= =?utf-8?B?MTNOSjlFR0pVNlo0QkZYdVo0V2Q2OGMwRDNLY1Rkblh3azRMb0xTVzFLQi9U?= =?utf-8?B?K1FqdWNscTU1RkJrSXRRY0w0a1YxckhMOGoxdXBhaEl6Rk5qaFZRdkE0VThN?= =?utf-8?B?SjlaeFNab2NLN2dIVHVXcGgraEkvSks1bEJhSmxyREdOcSt5THI3Y0lyVmdK?= =?utf-8?B?NitvV1NZWnV4YWxhemRFWS9yTzdFUG9nYXFlR0FmanJxS2Y1cFhtWU9mWE90?= =?utf-8?B?eUsxR3h4WGdOUGJtcTdEeDdHYTdYSXYwNVV6SS96eTUwZDVlcGpmdXkrYnlC?= =?utf-8?B?ejN4aEJvdWJUZ1Y1cktodS93TTd5cDJpRVA0N2Y1ME9nTnlyaUJaemo4NVls?= =?utf-8?B?YkY4amxQRzYxMlowT2dkVkl1eHV0YjQrMDJDL0psUE5WS0NmaHpRM3JKWWhO?= =?utf-8?B?UHJyVStmajNHWnJYa3ZtYXN6N3dEdUNSUVRHVzl3TnZuYkhrdEtlcktxMzFJ?= =?utf-8?B?amZJVUNrVXl4cFNLcHA5b2pEelZjL1RHdDhKUHpQVk9CZTJYdTFqdEc2dFhp?= =?utf-8?B?VTV5Q2lneFhLRm1SQ0RVdnBuaFJWU21TK3dyU1JLTm1KSjBvTFZYMGZuQU1s?= =?utf-8?B?SE1Xak1mWkc5a1BpQ0xMYnNKQnlUbUp2Y1VxeHhCc2o4cXJrbzU2TFpmQlRw?= =?utf-8?B?Y0k3YmpiUGF4dUNlN3dpUHNVc0VOYVFGQWtwSUNpcHEzdDNISHNYaFNsZzcv?= =?utf-8?B?UllIVDNmbDY4Y0ZVMUxjTElwV2tER3BkU2VLUURrZlJscTVxOVprUTNrYUxC?= =?utf-8?B?aWFEQzJidmhWUnpSUjZiN1M0b3BuSWM1WGYyb1FMMCtDYUlIcXRLTW1rNFo4?= =?utf-8?B?S3o5YS9FSjI3TnRYSjZCZnpsZDhyR3l5WGxmYnRXWjJBWVZLQmtCY2pkeTVh?= =?utf-8?B?N1I3N3Q5NHhhbzhYaysrSUtFSmxubkF6Mit4Vk41L3BxUGJmY29jZkVKZ01M?= =?utf-8?B?YXZQYm1iVlB6MWtFUlFjUnpDSzhwVGNSb0V5eWlNRDlKZjlvMzc0UTZJT0kx?= =?utf-8?B?N1VFN29OaE9tdWMwU0lrbUpnZU00YWNDd0dlZ0RTZnEvZ3YxM0VoaFVlckxR?= =?utf-8?B?M2ovRzF4Mzd6dU1qY2pvb2FzMXJTalUvYitROTVhT254dDh4dy91ZUtIZU5U?= =?utf-8?B?d282eU9HK0g4L2lsR0Q0bTFIcG93K1k0YlVGS3lXSUppTVhOcUNNTmtSUDJo?= =?utf-8?B?L2kvSGN2RFRreEpSL1VraGo2WUQ2bkFsaFNxN2pBeUpJbFlrR1Z5R3NyUnNV?= =?utf-8?B?M2tNTWs4K3R5YS9mQjFub2hQemJYb01aaVpYQURJbWE2NmtvK0RqZUkxdm9D?= =?utf-8?B?cmVJUGNwNjJaTW9XaHhkNXpKRjZ5NGszWFhaQ3UybU53UGg1OXRwRXJzTGRh?= =?utf-8?B?c1NHUVpJbWtNSG5qTHlSK0w3bzlGeG5DMWRuWlU1RUF4OE9EYnZDUCtjdmp1?= =?utf-8?B?YjFhMGJrd0d5QmtSQnBTUE5obTNVdkxFYkljWERyWnhqMXg5NllnS3RMUDZQ?= =?utf-8?B?R09RUXBzMGJhbHpHUmJwZ1RZb2dpUVVtRjNOTXhqb3EwTkZHdit2eU1wZVU1?= =?utf-8?B?TUVmR0EwYjBvS2xMSVNYa1A1Yk16RkFyNDcwTXpxRlNSTjlIa0R2RVpBdFRj?= =?utf-8?B?OUxmaEIvQ1Nidms3ME9paGMzaEhnVE1NZXZvWjYwbDhENFhPS3l6dTR4clY5?= =?utf-8?B?MzJ6QXlXSGlNVzFId0tWT0ZkRTE4ZWxSTHdzUUkrTkJjc1lTc1hKOTNKVjh2?= =?utf-8?Q?Vm7MZPCigLSIUKhGPgsrKAUVR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 585914db-2a87-4262-e228-08daa13da34d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 10:38:53.2463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PiyrBuKRyv/0FfXvs6o9vXEaL/H+AdBCc9NDUzD4OJAx/j+/wQqUgUHE/mqlFHMCUk+gE7shQmpF9u+chuLXCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8266 For quite some time we've been talking about replacing the present virtual address based hypercall interface with one using physical addresses. This is in particular a prerequisite to being able to support guests with encrypted memory, as for such guests we cannot perform the page table walks necessary to translate virtual to (guest-)physical addresses. But using (guest) physical addresses is also expected to help performance of non-PV guests (i.e. all Arm ones plus HVM/PVH on x86), because of the no longer necessary address translation. Clearly to be able to run existing guests, we need to continue to support the present virtual address based interface. Previously it was suggested to change the model on a per-domain basis, perhaps by a domain creation control. This has two major shortcomings: - Entire guest OSes would need to switch over to the new model all in one go. This could be particularly problematic for in-guest interfaces like Linux'es privcmd driver, which is passed hypercall argument from user space. Such necessarily use virtual addresses, and hence the kernel would need to learn of all hypercalls legitimately coming in, in order to translate the buffer addresses. Reaching sufficient coverage there might take some time. - All base components within an individual guest instance which might run in succession (firmware, boot loader, kernel, kexec) would need to agree on the hypercall ABI to use. As an alternative I'd like to propose the introduction of a bit (or multiple ones, see below) augmenting the hypercall number, to control the flavor of the buffers used for every individual hypercall. This would likely involve the introduction of a new hypercall page (or multiple ones if more than one bit is to be used), to retain the present abstraction where it is the hypervisor which actually fills these pages. For multicalls the wrapping multicall itself would be controlled independently of the constituent hypercalls. A model involving just a single bit to indicate "flat" buffers has limitations when it comes to large buffers passed to a hypercall. Since in many cases hypercalls (currently) allowing for rather large buffers wouldn't normally be used with buffers significantly larger than a single page (several of the mem-ops for example), special casing the (presumably) few hypercalls which have an actual need for large buffers might be an option. Another approach would be to build in a scatter/gather model for buffers right away. Jürgen suggests that the low two address bits could be used as a "descriptor" here. Alternatively, since buffer sizes should always be known, using a multi-bit augmentation to the hypercall number could also be a viable model, distinguishing between e.g. all-linear buffers, all-single-S/G-level ones, and size-dependent selection of zero or more S/G levels. This would affect all buffers used by a single hypercall. With the level of indirection needed derivable from buffer size, in the last of the variants small buffers could still have their addresses provided directly while only larger buffers would be described by e.g. a list of GFNs or a list of (address,length) tuples, using multiple levels if even that list would still end up large. Of course any one of the models could be selected as the only one to use (in addition to the existing virtual address based one), allowing to stick to a single bit augmenting the hypercall number. Note that a dynamic model (indirection levels derived from buffer size) would be quite impactful, as the overall buffer size would need passing to the copying helpers alongside the size of the data which actually is to be copied. How to express S/G lists will want to take into account existing uses. For example, an array of (address,length) tuples would be quite inefficient to use with operations like copy_from_guest_offset(). Perhaps this would want to be an array of xen_ulong_t, with the first slot holding the offset into the first page and all further slots holding GFNs (albeit that would still require two [generally] discontiguous reads from the array for a single copy_from_guest_offset()). Otoh, since calling code will need changing anyway to use this new model, we might also require that such indirectly specified buffers are page-aligned. Virtual addresses will continue to be used in certain places. Such aren't normally expressed via handles, e.g. callback or exception handling entry points. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:45:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:45:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413245.656776 (Exim 4.92) (envelope-from ) id 1odUZ5-0004gZ-Kl; Wed, 28 Sep 2022 10:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413245.656776; Wed, 28 Sep 2022 10:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUZ5-0004gS-GH; Wed, 28 Sep 2022 10:45:19 +0000 Received: by outflank-mailman (input) for mailman id 413245; Wed, 28 Sep 2022 10:45:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUZ5-0004gM-5f for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 10:45:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a40046d6-3f1a-11ed-9649-05401a9f4f97; Wed, 28 Sep 2022 12:45:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8586.eurprd04.prod.outlook.com (2603:10a6:20b:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 10:45:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 10:45:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a40046d6-3f1a-11ed-9649-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UMZcn7a4P2sJnFXqxQejvhfyBdZTllDyoJvdHzoFFJzqZ8N9s4u06Bc9iqAySe3Oa+70B3MujTCWqSixqVu1ngX6o/vfy6Lzpzyz/LKzoK2x4GmjqRH7FNTfUPBVvylK72oAUiedqIMseGmO4KpdEiqGOFkuZF3eP6YtoBl8vFwVkuwzGxqV3QyIVEj74iTCE1nBElvJBtv9BNJme4b+KZvFrIYNsPGRwvMZ6YAeubG+xArulbTmno8wE+WVBexoOQNhAtFmQMikBmjRnkDQJqz2DhsBhC/1dgqZ51Tyc2kJ2YfzdZNYAJIhpALsJdorcWxZmIhHSfGefCFxe8GYsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQO2A70vTnbnfNQz1f2eJnM+4kaB1DowXtso/JwbOZ8=; b=i+NGv0nmAT25wlZWar3VkbGIWVQt5ZGqoLHhdgKojgZOYs2AnQR6qsFx0cXzUF1vyNGnxoj85RerjO7Ap+vQNMFzV3tsSALCmK3nZwT//4PVtqTJEC1FMXNwHtbzJjp3C02n8MtJXJlpWIqsD/vohYvVm/p1QNICS9SYoI23a/zFiU4HDwnJmJ8JxER/K9Fu2JNuguoWa7upLg2kqKGZTPvHiO8jREf2giRksN73QoRyqwr/JwY8TBOgpTLEaTnpiKjK24u0j0ZPmHQpcqiI6rjsXxh4vn/f+8t1hQKYeRKQOrjrvNdfVITznyxEeZlHl//q0tDDkWPxII4qyDVu5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wQO2A70vTnbnfNQz1f2eJnM+4kaB1DowXtso/JwbOZ8=; b=jxH9HsRfKiefCkxG62gUZRJRlyiGX3kFVF/hPRRLgUORhQ5T1Gh3JzCaI4Wa8cFkUTL8MDl+bUBiRmPLifA8tJXIbe/cSbkw3gOKmqa7euQJ1Qjojh8NsDgfsk4/UQTUJ3WXBL4MEXA+OFVZr5vbBMOxbNxfajL/C47zWraK+SItQf7/TrdJSpH5kaSGGcY0lTK8aogzteKJS4KCjgmER+rkNCd8n1wY7UysZ7kOk7Ovwgi93keex9Vf6N4i7b1Rm34yQ8p7lzBghem2asZqUaPK9hD+SbhtxsxXbAeQ6CSoRWyTzagPRS02RQFnN3zJJD8/1wqqkelgcDchVhKc6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <357195b5-bfb5-7f0d-8295-3076a6762f12@suse.com> Date: Wed, 28 Sep 2022 12:45:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20220927153937.39389-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0267.eurprd06.prod.outlook.com (2603:10a6:20b:45f::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8586:EE_ X-MS-Office365-Filtering-Correlation-Id: 608a4d7d-43b1-452a-9ce5-08daa13e8712 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PyniqaQRCwEW6IfcoZRw3/3LXBjTTqBNOLGnCBvWTIW96fukFsu0nUARvIp4/hOGteKfPxO8/v+closL5J7b1eBEc5wkzM+mSDCW311JQQ1d1MKj6WP7aI94pNEMeycG2WgrIDeG88KA3M1WjSVP54fvMnTVlGIEN8FkD/DGJdYR8+hMsvgckZQL91K6oQhqxvlnV/j1WHT2HbDH62fOaGvLAKp27OjYj+oJucE7WjoeF8huIAJQcherE4Hke9g2OYhtzCDUGC90amrCHAkFokOPomo6oBv4QfxF64VCy7Qnfi21oje/ztk/fCg9Gws5hW7Ya47aE9Bk+86g7JUNBPBn1mtUV+59sSA3Z8RKZOmFyNOXjFsGwBcs8jzAi/1g1eZUqzIrfmxZk5TL15hIvNscLzaxj6CmCFSCXQoW5R8Uw8/VE85Yc6GGvn1BVJRZhV6XKDR8fqTJD1uVjByXhOzINjEvY7E7HC0DIKyiWmt07ZW6qdDztdCDNI4sWXCBFRKVBPqbDw8F+tkGrd79Czql4Xkk/cWC3AIipcm/5bntTzmNO1xNnAM6weGFcrAUHfkjlC/swEDASJKNV73NIydI4Y7LSduxLWvXYdvllDLZITUTr+8L0iLBnhh6j0reBYK7u+uSrih127Upo1XzNFFxgtU8O8o+3i/xbIiZV80ICrZIBf3knl3xAycIt7wV07SfpD4YWROe+lBzDZpt3iUW5k++0SEglUpnPJdzi9+6dzyyj1MBselVPfRLV/xbkZQXpP8jS2KasMHPnvgww5O20hsXOuk1/0N9kadnCp0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199015)(478600001)(6486002)(6916009)(54906003)(316002)(6506007)(2616005)(26005)(6512007)(7416002)(5660300002)(8936002)(186003)(53546011)(8676002)(4326008)(66556008)(66476007)(66946007)(31696002)(36756003)(41300700001)(86362001)(31686004)(38100700002)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0pBQW05dzkzNXo1UEk1OW5EWnNYZUpPRWFJVlJsQi82UnJPZGdzSmxZV3Nq?= =?utf-8?B?MzBualY1ZkcxWURCSTUvVGNETXV4bi9TT3QrRkdGdW5CTGRJZytPNit5aWZC?= =?utf-8?B?MDZiSDA1QWpSNmdLVHlGS3FvT3k2MnNPaDZMeklob1NIWGVGcElnVkFOVzhQ?= =?utf-8?B?U3BqbFVmelNicldSQ3c2bkRYZzUyTnNiSi9MWDY2VlhVNGJLUTJmVU10RU5a?= =?utf-8?B?TGlIS0RiMlA3bVZ5eDVWNkE5Nmc4TGUrYndvRXFHeUU2aEtRQ0tXZ0hOWERC?= =?utf-8?B?QkRsN2R4RmlNdG0vT2dRVURiM25UREw3RFdZZ3A2SThabEYyNWtHME51bFJw?= =?utf-8?B?YUxITnlPZURjSWl5N05OKzhCQ245eDlBdEszcGlEeWJDRy9JS0hJdVJtVXRh?= =?utf-8?B?VHE0UjFPalIyK3ExWWM3ajA0N3RCMzUxZjFFUkpOZjk2UlRGcmFrblRCNzBI?= =?utf-8?B?enR5eDZaQUVUK3h3K3hNakQ5RTdBNmk4VnY0aytDMVU5ZkRxL0VJdlhEaWNp?= =?utf-8?B?UmxLTjlNWFpkaCtaUno0SmdvUmlmMTZ4eVo5Z0ZyNFN2M3FvUVMwTUxlSnN6?= =?utf-8?B?ZU9qOEhLZW9qL3JYdi9KNUo0ZDZpTHhjSncwQkh5M0tmaWlUYUlCQzVSd0Zk?= =?utf-8?B?dU9mRlBmazBqejRsNk9mRkxHbXRHK0VUS2QyRTk5cmlPUEdRS1d3RStpSWY5?= =?utf-8?B?eTE4cDFVUmFWT1o1dk9pbm5RaWtVS0J3TlorY2R5cEwvRktBTkppNllsbUcy?= =?utf-8?B?dHJzK2N1VElPT3ZBQ1RIMmpneG82OHl1ZFNBYk1xb1J4ZjFEZTVlekFlcXhK?= =?utf-8?B?RnkxbkMyZExKOFJYdUZkOXh3YW9QQ2tDMDVoWGZVQUdJMFhQeWcyR01zWjRQ?= =?utf-8?B?aGFNNWZPT1hZaDRoUWVtU0VnK20wV1pLcVlaUDlWZTNUVzBYOTkwNkxxT0Jp?= =?utf-8?B?bGJFZTg2OE5La0dFcWUzeXBpeGxENVRDd0tXeUxFM2hjdGZXTDFqcWhoYThx?= =?utf-8?B?WHE5WGYvclBCdk1JaUJkQWFIR1RDYTczN2FGQVFTZmdMb0xGSTVmUEwzaWty?= =?utf-8?B?YXRYVmNMdkxCYUZIYmxFL1VtbkpLcWNWZzVBaFczSnVYN3VUVHJNVXBBbWlj?= =?utf-8?B?bHZHQ3c1bmVnVTNJdFZnWXdOT1pZbXh2MlpHSGJGSERTZ0cvMzEyYUhNY3k4?= =?utf-8?B?WnFVTTVlbFZIK2hYVHBEeFF3eVMrcUdkdnM4b3BTQU1jTDJzM0tLeEhkUGVp?= =?utf-8?B?WUJIbHJOaEJJdVlCeG5sY0ZHb2s0UlNmNWt6SzVIQ1psT3pXbXp6MzVSb05F?= =?utf-8?B?U3lLU1RsUGhYdjhoV2Evdk9pN1loRGZQSmo3UXBmLzRYUjRyeUxlQmJXSFNG?= =?utf-8?B?d1pncUVWcWFjT1pGVTMzZFFyYmRPZkYvamg0dDdlMVZUb3NtZERCaDBQVmJw?= =?utf-8?B?c2pXRTcxR20rT2NvY0I3b2hjcTdzQjNMOUFmNzFLTXpLSXVTcVRPTW9IWmpW?= =?utf-8?B?OWRJRVJRKzNiMjExNW5Qb01LeDZxR2dNbXRYc280dmhZWmgyVXptVTRSdm9k?= =?utf-8?B?cTU3czd5dXdBVkFiZllOYVA3SEZ3VnlrNzRiZUs5S3VrcFJOV1g3b2IxKzFQ?= =?utf-8?B?dFNaeSthbG9tTmFyQ2FmN2pRQk9Yd05QMnA5R0Jya0phdGJNMDZ0NllneSta?= =?utf-8?B?cFdkYVY3VUdYcDRhL2ZpV1RoTUpYcnVJbUpjYWwwS1p3R2pPVUFuUDh1enlv?= =?utf-8?B?d0IxNERvNDJXbnp6VXRwS215OUNGRE5jZ20rdjZ6djlyZzhKNFlnUFBOQ3Bp?= =?utf-8?B?bFpzWERVNnlXWE0wdWpIWlhZSVNFdGJxSTVTUkhMWTEzdlpUSFAvbVV3a0NS?= =?utf-8?B?Q2lMbnNLWEE2algrUFBKWjF4N0kvd2dGcXhuYVRBQVVWZ2F0d3lKZ1JoNW1L?= =?utf-8?B?bTN2Tncrd1RHVmtvSnVhQ3QxN0tDeHBIZ1g5Qk5NZnUyZFkwWnlDdFlIS20x?= =?utf-8?B?SzFiNytSOU4rdURka1I3dEw0TGF3bnBEQ0xwVWhsZUZGZS83RUM0Y3FWeVVo?= =?utf-8?B?VVZoaDVTSEZBbjhPT3JPMmxFNXRSMDY4SGZ4Z2xqTnk2MnpiMlZ3Q0E4UEF2?= =?utf-8?Q?xBH1ysKLM6SiVj52B6nRgXUqo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 608a4d7d-43b1-452a-9ce5-08daa13e8712 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 10:45:15.4253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Y6w9iWy+NuY5snO4sIe5KgLLkM2MMnuITO0jgFWy0CRd7VWmB/1X9JUSjfWJ6i4N36fLEZbN4rhreJx6/SWjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8586 On 28.09.2022 12:08, Roger Pau Monné wrote: > On Wed, Sep 28, 2022 at 10:01:26AM +0200, Jan Beulich wrote: >> On 27.09.2022 17:39, Roger Pau Monne wrote: >>> memory_type_changed() is currently only implemented for Intel EPT, and >>> results in the invalidation of EMT attributes on all the entries in >>> the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits >>> when the guest tries to access any gfns for the first time, which >>> results in the recalculation of the EMT for the accessed page. The >>> vmexit and the recalculations are expensive, and as such should be >>> avoided when possible. >>> >>> Remove the call to memory_type_changed() from >>> XEN_DOMCTL_memory_mapping: there are no modifications of the >>> iomem_caps ranges anymore that could alter the return of >>> cache_flush_permitted() from that domctl. >>> >>> Encapsulate calls to memory_type_changed() resulting from changes to >>> the domain iomem_caps or ioport_caps ranges in the helpers themselves >>> (io{ports,mem}_{permit,deny}_access()), and add a note in >>> epte_get_entry_emt() to remind that changes to the logic there likely >>> need to be propagaed to the IO capabilities helpers. >>> >>> Note changes to the IO ports or memory ranges are not very common >>> during guest runtime, but Citrix Hypervisor has an use case for them >>> related to device passthrough. >>> >>> Some Arm callers (implementations of the iomem_deny_access function >>> pointer field in gic_hw_operations struct) pass a const domain pointer >>> to iomem_deny_access(), which is questionable. It works because >>> the rangeset is allocated separately from the domain struct, but >>> conceptually seems wrong to me, as passing a const pointer would imply >>> no changes to the domain data, and denying iomem accesses does change >>> the domain data. Fix this by removing the const attribute from the >>> affected functions and call chain. >> >> Personally I think this adjustment would better be a separate, prereq >> change. > > Right - I was about to split it but didn't want to go through the > hassle if the approach didn't end up being well received. > > Do you think placing the calls to memory_type_changed() inside the > {permit,deny}_,access is acceptable? Well, as said before - it's not pretty, but the existence of memory_type_changed() itself isn't either, nor are the present placements of calls to it. So yes, I view this as acceptable. >>> --- a/xen/include/xen/iocap.h >>> +++ b/xen/include/xen/iocap.h >>> @@ -7,13 +7,43 @@ >>> #ifndef __XEN_IOCAP_H__ >>> #define __XEN_IOCAP_H__ >>> >>> +#include >>> #include >>> #include >>> +#include >> >> That's heavy dependencies you're adding. I wonder if the functions >> wouldn't better become out-of-line ones (but see also below). >> >>> +static inline int iomem_permit_access(struct domain *d, unsigned long s, >>> + unsigned long e) >>> +{ >>> + bool flush = cache_flush_permitted(d); >>> + int ret = rangeset_add_range(d->iomem_caps, s, e); >>> + >>> + if ( !ret && !is_iommu_enabled(d) && !flush ) >>> + /* >>> + * Only flush if the range(s) are empty before this addition and >>> + * IOMMU is not enabled for the domain, otherwise it makes no >>> + * difference for effective cache attribute calculation purposes. >>> + */ >>> + memory_type_changed(d); >>> + >>> + return ret; >>> +} >>> +static inline int iomem_deny_access(struct domain *d, unsigned long s, >>> + unsigned long e) >>> +{ >>> + int ret = rangeset_remove_range(d->iomem_caps, s, e); >>> + >>> + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) >>> + /* >>> + * Only flush if the range(s) are empty after this removal and >>> + * IOMMU is not enabled for the domain, otherwise it makes no >>> + * difference for effective cache attribute calculation purposes. >>> + */ >>> + memory_type_changed(d); >>> + >>> + return ret; >>> +} >> >> I'm surprised Arm's memory_type_changed() is an empty out-of-line function. >> This means the compiler can't eliminate this code (except when using LTO). >> But then cache_flush_permitted() (resolving to rangeset_is_empty()) can't >> be eliminated either, even if memory_type_changed() was. While gcc doc >> doesn't explicitly say that it may help (the talk about repeated invocations >> only), I wonder whether we shouldn't mark rangeset_is_empty() pure. In a >> reduced example that does help (once memory_type_changed() is also an >> inline function) with gcc12 - no call to rangeset_is_empty() remains. > > Can look into it, do you want it to be a prereq of this patch? Well, if done, then it being a prereq would seem desirable. But x86 isn't affected by this, so I'd leave the "whether" aspect to be judged by Arm folks. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:48:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413253.656786 (Exim 4.92) (envelope-from ) id 1odUcM-0005Mg-79; Wed, 28 Sep 2022 10:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413253.656786; Wed, 28 Sep 2022 10:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUcM-0005MZ-4U; Wed, 28 Sep 2022 10:48:42 +0000 Received: by outflank-mailman (input) for mailman id 413253; Wed, 28 Sep 2022 10:48:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUcI-0005MQ-Kx for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 10:48:40 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ab918f4-3f1b-11ed-9649-05401a9f4f97; Wed, 28 Sep 2022 12:48:37 +0200 (CEST) Received: from zn.tnic (p200300ea9733e7ee329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ee:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B47101EC0576; Wed, 28 Sep 2022 12:48:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ab918f4-3f1b-11ed-9649-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664362111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+FjFc+W0rnawZ+U2ZgyBD+QjFQbz7q8G3FqZ2msSnSQ=; b=HQZ3JES2YaWgiRYy36DiLeVqjOXJOHZdjiQN9UU3tQ9xM+RGF1wfzc0x8X2B7dXcSC66Fw E+L9vpk/MBaDR6QXaZ19OC6tMA8Y6qjTZMC+Pb0bMH1TPlkPzflgq4bqnmgfcStxxxTY5b 66nDyM2K/OZefricc6GQCNO/gOkXE38= Date: Wed, 28 Sep 2022 12:48:26 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> On Wed, Sep 28, 2022 at 08:16:53AM +0200, Juergen Gross wrote: > > Are sure the hotplug notifier doesn't get called in the boot and in the It doesn't because it gets registered after smp_init()... > > resume cases? ... but it gets called during resume because by that time the notifier has been registered already. See my notes at the end of this mail of what the code does currently. > In case my suspicion is correct: this can still be solved by adding the > hotplug notifier only in mtrr_aps_init(), and removing it again in > arch_thaw_secondary_cpus_begin(). Pretty much. Yeah, we still need a bool. ;-( But that bool has a much smaller scope and it is perfectly clear what it does. And I've added a comment. Could've used comments for the delayed init thing. Anyway, it gets set in a thaw callback (I mean, might as well, since we call into the MTRR code anyway). I probably can make this even cleaner and not do any bool if I could query in the notifier whether I'm resuming... Thx. --- diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 76d726074c16..86b8009d2429 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -42,9 +42,8 @@ extern int mtrr_add_page(unsigned long base, unsigned long size, extern int mtrr_del(int reg, unsigned long base, unsigned long size); extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); -extern void mtrr_ap_init(void); -extern void set_mtrr_aps_delayed_init(void); extern void mtrr_aps_init(void); +extern void mtrr_aps_thaw(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); extern int amd_special_default_mtrr(void); @@ -83,9 +82,8 @@ static inline int mtrr_trim_uncached_memory(unsigned long end_pfn) static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) { } -#define mtrr_ap_init() do {} while (0) -#define set_mtrr_aps_delayed_init() do {} while (0) #define mtrr_aps_init() do {} while (0) +#define mtrr_aps_thaw() do {} while (0) #define mtrr_bp_restore() do {} while (0) # endif diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 3e508f239098..deef1b5b27cc 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1948,7 +1948,6 @@ void identify_secondary_cpu(struct cpuinfo_x86 *c) #ifdef CONFIG_X86_32 enable_sep_cpu(); #endif - mtrr_ap_init(); validate_apic_and_package_id(c); x86_spec_ctrl_setup_ap(); update_srbds_msr(); diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 2746cac9d8a9..c4089fd2b477 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -69,7 +69,7 @@ unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; static DEFINE_MUTEX(mtrr_mutex); u64 size_or_mask, size_and_mask; -static bool mtrr_aps_delayed_init; +static bool ap_notifier_disabled; static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; @@ -176,7 +176,7 @@ static int mtrr_rendezvous_handler(void *info) if (data->smp_reg != ~0U) { mtrr_if->set(data->smp_reg, data->smp_base, data->smp_size, data->smp_type); - } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { + } else if (!cpu_online(smp_processor_id())) { mtrr_if->set_all(); } return 0; @@ -784,13 +784,16 @@ void __init mtrr_bp_init(void) } } -void mtrr_ap_init(void) +static int mtrr_ap_init(unsigned int cpu) { if (!mtrr_enabled()) - return; + return 1; - if (!use_intel() || mtrr_aps_delayed_init) - return; + if (!use_intel()) + return 1; + + if (ap_notifier_disabled) + return 0; /* * Ideally we should hold mtrr_mutex here to avoid mtrr entries @@ -806,6 +809,8 @@ void mtrr_ap_init(void) * lock to prevent mtrr entry changes */ set_mtrr_from_inactive_cpu(~0U, 0, 0, 0); + + return 0; } /** @@ -823,34 +828,26 @@ void mtrr_save_state(void) smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); } -void set_mtrr_aps_delayed_init(void) -{ - if (!mtrr_enabled()) - return; - if (!use_intel()) - return; - - mtrr_aps_delayed_init = true; -} - /* - * Delayed MTRR initialization for all AP's + * Delayed MTRR initialization for all APs */ void mtrr_aps_init(void) { if (!use_intel() || !mtrr_enabled()) return; - /* - * Check if someone has requested the delay of AP MTRR initialization, - * by doing set_mtrr_aps_delayed_init(), prior to this point. If not, - * then we are done. - */ - if (!mtrr_aps_delayed_init) - return; - set_mtrr(~0U, 0, 0, 0); - mtrr_aps_delayed_init = false; + ap_notifier_disabled = false; +} + +/* + * Disable the AP notifier temporarily during resume. It is supposed to be active only + * during CPU hotplug as during resume mtrr_aps_init() takes care of the MTRR + * programming on all CPUs. + */ +void mtrr_aps_thaw(void) +{ + ap_notifier_disabled = true; } void mtrr_bp_restore(void) @@ -869,6 +866,10 @@ static int __init mtrr_init_finialize(void) if (use_intel()) { if (!changed_by_mtrr_cleanup) mtrr_state_warn(); + + cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, "x86/mtrr:online", + mtrr_ap_init, NULL); + return 0; } diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index f24227bc3220..b90780dab88a 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1428,8 +1428,6 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) uv_system_init(); - set_mtrr_aps_delayed_init(); - smp_quirk_init_udelay(); speculative_store_bypass_ht_init(); @@ -1439,7 +1437,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) void arch_thaw_secondary_cpus_begin(void) { - set_mtrr_aps_delayed_init(); + mtrr_aps_thaw(); } void arch_thaw_secondary_cpus_end(void) Notes: ------ Boot sequence: BSP: [ 0.272801] smpboot: native_smp_prepare_cpus: set_mtrr_aps_delayed_init APs: [ 0.287190] mtrr_save_state: first_cpu: 0 [ 0.287724] x86: Booting SMP configuration: [ 0.290292] .... node #0, CPUs: #1 [ 0.061135] mtrr_ap_init: single AP entry, use_intel: 1, mtrr_enabled: 1, mtrr_aps_delayed_init: 1 -> set_mtrr_from_inactive_cpu() gets skipped. After all APs booted: [ 1.544506] mtrr_aps_init: entry, use_intel: 1, mtrr_enabled: 1, mtrr_aps_delayed_init: 1 -> set_mtrr() hotplug: [ 206.112651] smpboot: CPU 11 is now offline [ 208.286030] bringup_cpu: CPU11 [ 208.286611] mtrr_save_state: first_cpu: 0 [ 208.287416] smpboot: Booting Node 0 Processor 11 APIC 0xb [ 206.116567] mtrr_ap_init: single AP entry, use_intel: 1, mtrr_enabled: 1, mtrr_aps_delayed_init: 0 -> set_mtrr_from_inactive_cpu() suspend/resume: BSP: [ 270.586643] smpboot: arch_thaw_secondary_cpus_begin: set_mtrr_aps_delayed_init APs: [ 270.587947] bringup_cpu: CPU1 [ 270.588470] mtrr_save_state: first_cpu: 0 [ 270.589207] x86: Booting SMP configuration: [ 270.597971] smpboot: Booting Node 0 Processor 1 APIC 0x1 [ 270.530418] mtrr_ap_init: single AP entry, use_intel: 1, mtrr_enabled: 1, mtrr_aps_delayed_init: 1 After all APs booted: [ 270.694168] mtrr_aps_init: entry, use_intel: 1, mtrr_enabled: 1, mtrr_aps_delayed_init: 1 [ 270.696923] ACPI: PM: Waking up from system sleep state S3 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:58:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:58:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413258.656798 (Exim 4.92) (envelope-from ) id 1odUlr-0006t7-5s; Wed, 28 Sep 2022 10:58:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413258.656798; Wed, 28 Sep 2022 10:58:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUlr-0006t0-2H; Wed, 28 Sep 2022 10:58:31 +0000 Received: by outflank-mailman (input) for mailman id 413258; Wed, 28 Sep 2022 10:58:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUlq-0006sq-29; Wed, 28 Sep 2022 10:58:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUlp-0003e7-Ui; Wed, 28 Sep 2022 10:58:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUlp-0001nG-Gc; Wed, 28 Sep 2022 10:58:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odUlp-0001kp-Fs; Wed, 28 Sep 2022 10:58:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CNZnaiEbsl7OVZECeU0/DwcJTJMoNiAaJDDwa9uD7Yo=; b=vaBj8dClmWNFPljLSwpMpxSvf+ Kud2gwG8RWoWPwyuAe3Gu+naRvfzAcjoRBrgesZCd+P6R81QGmfpLiDuJp1kt7f3d731o18DNUkog N0a66rhdwoB6uQCPljhrzy8e4eoj+6BoRqJSEGQ1kNdwMh2AOsX2w1fdy01gvWFSOIVg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173339: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl:debian-install:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=49c13ed0316d55d73f1c81c66a7e2abd743f9ae6 X-Osstest-Versions-That: linux=46452d3786a82bd732ba73fb308ae5cbe4e1e591 From: osstest service owner Date: Wed, 28 Sep 2022 10:58:29 +0000 flight 173339 linux-linus real [real] flight 173352 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173339/ http://logs.test-lab.xenproject.org/osstest/logs/173352/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 173352-retest test-armhf-armhf-xl 12 debian-install fail pass in 173352-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173352 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173352 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 173352 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 173352 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173336 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173336 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173336 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173336 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173336 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173336 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173336 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173336 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 49c13ed0316d55d73f1c81c66a7e2abd743f9ae6 baseline version: linux 46452d3786a82bd732ba73fb308ae5cbe4e1e591 Last test of basis 173336 2022-09-27 14:42:34 Z 0 days Testing same since 173339 2022-09-28 00:12:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Stein Arnd Bergmann Bhupesh Sharma Bjorn Andersson Bjorn Andersson Florian Fainelli Heiko Stuebner Jernej Skrabec Johan Hovold Krzysztof Kozlowski Linus Torvalds Linus Walleij Manivannan Sadhasivam Marek Vasut Michael Walle Philipp Zabel Randy Dunlap Richard Leitner Richard Zhu Romain Naour Romain Naour Samuel Holland Steen Hegelund on Sparx5 Steev Klimaszewski Tomer Maimon Tony Lindgren YuTong Chang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 46452d3786a8..49c13ed0316d 49c13ed0316d55d73f1c81c66a7e2abd743f9ae6 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Sep 28 10:58:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 10:58:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413261.656809 (Exim 4.92) (envelope-from ) id 1odUm0-0007BE-Dt; Wed, 28 Sep 2022 10:58:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413261.656809; Wed, 28 Sep 2022 10:58:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUm0-0007B7-B0; Wed, 28 Sep 2022 10:58:40 +0000 Received: by outflank-mailman (input) for mailman id 413261; Wed, 28 Sep 2022 10:58:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odUlz-0007AL-46 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 10:58:39 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7faa0add-3f1c-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 12:58:37 +0200 (CEST) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 06:58:34 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 10:58:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::56c6:613e:cc95:d028%6]) with mapi id 15.20.5654.027; Wed, 28 Sep 2022 10:58:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7faa0add-3f1c-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664362717; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Xwtq2mYsbEtoYgqO+YuFXU95aetesuxDjlrp/uhJasY=; b=dg3jEmsAeP6s8rY+FrL0w3uquPQqpYIBRiZmICTNqYFnI3uy0mQW0uP8 pdAMDXSPmG75SoXTGPQG9O+FsGU2UlvUPTZHYNwj0FHX0/vsEMtN7bMJg LaykFtppLsDHdIhFV1gFFd7MTaoYKrMUT8HI+lHjLumOWKK8oDvf8VPqw 4=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 81945582 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZMzxbKJxcOhfiuTvFE+Rw5QlxSXFcZb7ZxGr2PjKsXjdYENS1zBSy jROWjjUOq3ba2v8eNt3a9nio04A75PWydAySwZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4mNA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FY0z8+ZFPmxfz tgVb2k1Qy+Bt/+YxJvuH4GAhux7RCXqFKU2nyg4iBTmV7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q/T/PJti4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv Dnu9GXlGBAKcteYzFJp91r8376TwH6rAur+EpWIqadBrUaOzFYXJwRIV2K0+teXoE6xDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBONB0mLicSHbY86jOqzq3YHARNTVbPXVCShYZ6d7+po11lgjIUttoDK+yiJvyBC30x DeJ6iM5gt3/kPI26klyxnif6xrEm3QDZlRdCtn/No590j5EWQ== IronPort-HdrOrdr: A9a23:Z+5K/qz3t5U/a0PkDIrSKrPxgOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTgZUJPwC080hqQFmrX5Wo3SETUO2VHYZ72KiLGP/9SOIVybygcw78 Zdmu1FeaTN5DtB/IrHCWuDYrEdKbC8mcjG69s2jU0dKz2CAJsQjDuRfzzrd3GeMzM2Z6bReq D92uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qinl1qTmfDHOind+i1bfyJEwL8k/2 SAuRf+/L+fv/ayzQKZ/3PP7q5RhMDqxrJ4dY2xY4kuW3XRYzSTFcZcso65zXUISSaUmRIXee z30lQd1gJImjTsly+O0F3QMkLboUwTAjfZuCKlaD3Y0IPErXsBerV8bcgySGqk12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtVrQc/tQ0qbWIlUs4nkaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbPfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2FfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPIcFyZMj8a 6xJW+wdVRCCX4GJff+rKGjqCq9PllVdQ6du/129tx+pqD2QqbtPGmKVE0u+vHQ0MkiPg== X-IronPort-AV: E=Sophos;i="5.93,351,1654574400"; d="scan'208";a="81945582" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oSCYFi/SabRZCgvaGhbaAohRWX6DNAchW7axhk3Md/JbyLyh4rHexsfVLYWPuYmzEgZQI4IR+S1ExPle7A1VDv1T2O+Kv1wof0LA/JwVE/iRN2voosMEVL7/cPVGXQlSEhE1VF+E9KvqSenX4JXdmkAybhwd+7UNr2Be00ICZ7+QVs4dvexj5ZtmU4rSGBgqcITlY2DmAYbVuZXDTjTPqbyUxc/JwcdYgH1hLuzWXEeY3v1IAovTbgW5flzdg0asBU/5M1WXijVXuqne0Asp4Ew36GMpNwGlKQ/oqmr2grUkzH3IcJPmnXtpElE1CFZ8YMSLap4ZXTbpPwCYvHzamA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xwtq2mYsbEtoYgqO+YuFXU95aetesuxDjlrp/uhJasY=; b=YHA61kNxXIGQrwT3GaRajRI1h9LoY/sYVE/FJDjCCl6DZ+HRE4iftiGagtqT7h+W0NYu9VCeGQrAZxyuUOoN8tolYVrXPZhwtUqxMzHFLSHRZmPL3jlvZelGASZvyv2hpLJYPeW5+wo4zQxd4KBzopU98c1+xfkX12PDagNGCw+oG58Y4YawCEwbvMDVEFT8kS8D0D53jfw4TxHD4ZHGhvi/WozW8i0jOm30eRRzMDe1u/GGNQYqmOttmfEvqhaBJOb+9O3DZTltAqkYcgP3TlD3M3F3rcat4oXD47UEZXXIOHnlupRQQNEhntfTiv/ciNdS5pooLOpOhPgGmB951Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xwtq2mYsbEtoYgqO+YuFXU95aetesuxDjlrp/uhJasY=; b=I682XE70CuiLMqY6QG6ZPeOOngC3V667jlcafwtTjA9UgxpmY+sVIcxXSZoW1kKnJ4PbZ6cft9ZIgKgg5J2Uag/UDgPPsAQO1Fjcw870LRN876Pyl1ot1hQKv7cTocV582TN6VURePoOZ2nAe7omdxmFZuyJL7cXztlB5HSZgMM= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" Subject: Re: Proposal for physical address based hypercalls Thread-Topic: Proposal for physical address based hypercalls Thread-Index: AQHY0yaT5LEru00uSkuEONBLdSy8OK30rDEA Date: Wed, 28 Sep 2022 10:58:32 +0000 Message-ID: <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> In-Reply-To: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5414:EE_ x-ms-office365-filtering-correlation-id: fda967f4-d351-4e28-53d6-08daa1406272 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +bProapYPa5p+TIxeCKeDNYE4rqc+f9x2XRWmE39vqWv672WtWbsQOjrTdwcVKjN/TpPntJJObbMZrw5qBZ4DzTqZikXqTm1JLRQXupg7M3IPEOix1LUPe7AoI8fAFmi5/1nY5poQiouTy5mjOL43PHQAy5Rj4ErEYMN7cQW9icoc2rw8pJIGJCcMDP3e7SvSs7k6cAPYzmRna5dJT6MIgxNS+oxXF1PVg3eG4V8VEWu5eO+H2I0bz6fG9XpdyVvute92CdvK9cy3WIPMTGEqazse6X0cLIslO2EoH3k+dqkdeP1BgmfwmpaopafFOQe3Cpz0LVaTRLrggUaPkuIUDlhYTYt+v6cDn19/glxOpdEEpPQp+5UymU3hs8asFxQFvdePFQ+qkahDGXa4zT7XE/dtXWKcZ0ROO+ij2OBG1hNjUwnS9Z7TaFr5jGIPTv8yuQe0eL3g25+DTDXM4Q2i9OTs9qTZT471KrqQaPl+B1aBputhW8UVBlIXA61VVTyJKyuHDXqsS5V3/neQtM+4CeXKwid4ir8C9GrIiaiHYZvXuJKKwdsaooeyHW2u2mXaGF+FIxe0LIQr09tSiSkqhfHl/hOThAjoGZpR7B4hkQYQMhABXZ4mzRIpenZHTio9sLQg6qGZDAZ8Z5to8wheLx1bgjo0Hse3GTg4TT/udyd3JRaGYNJTUo7/tGLFzM3CqhJC7U50wvkLGXUI3oP+m+9Pd2Sk4oENBqesDPeoSMeiLbgWrTke/BF2AE7W9xOsEEfwwJinh5sBnCP23avgcpYbEqoBTQfRVuTY2bPoQK3nZPj3Rft7F1DN8bVqaFfo6ylMc2n2LVmjZKLQsRojw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199015)(36756003)(53546011)(316002)(82960400001)(6506007)(26005)(110136005)(186003)(6512007)(2616005)(66476007)(31696002)(86362001)(8936002)(8676002)(122000001)(2906002)(41300700001)(38070700005)(83380400001)(71200400001)(64756008)(38100700002)(66446008)(91956017)(66946007)(76116006)(31686004)(66556008)(6486002)(478600001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T2h0VXlsZE94TVdWbGlkdHhxbndPekd3YUdTS3hIV3U3cDlnNGkzeGlYRE1B?= =?utf-8?B?c05TMmhMQzI0U21ldDlQK2o3bU04TnNhQnRUTHI5WE9wckhhenRSQm05VTdw?= =?utf-8?B?aE1vYTVTQVVtbWROZ3RyOU1YTzI5WjFmWVlma1VDRDk2SEE2MDY4QmdkMjRP?= =?utf-8?B?RDV6UVluOHhJZ0JMVS9IUytuUU1lTHpJcEZ0ZnhWcUlTb3k2VWZlL2k3dksr?= =?utf-8?B?S3htenpncS9rNndITVdocEJKSnNhdTQzU1FzV09waXhndmFyRzh4QUtUVXlt?= =?utf-8?B?VUhYaUNteDFhOWZrTG9qTVJwakFwbHAvTDFpbUxzL3pVOHNvbjBONEV5V3Ex?= =?utf-8?B?dUp1RXdMWi90ZlJUb3paY01pck16SHFvT09KOUwraTliVW5HU2w3WnVuSGhr?= =?utf-8?B?ei9XV3NYRHd6UUE5SzV0SHBxRmJNcmJocDdlRDFEZWhmcDg2d2ZaTkhLMXp0?= =?utf-8?B?dGVTbHVaRE9iV01KSHVicHpOMmFYQXZGVHNHWEVCK0d2TFI4M2xLbkRxdUpL?= =?utf-8?B?aUlpQmEvRTBmUXo5c09FY1hic1U3MkVYMWZYcXFBTVl2YnNsVk9adUdMamt0?= =?utf-8?B?M3hwNDQwS3o4UUUzRzFNTEpVYTA2bkI4MGovZnRCcGthdGVaVVdpbFBQTnl5?= =?utf-8?B?RFJaakdsSnJ4YisxcXNiUG03eFNNY01KK1U0eHVuOFpRUlNOY1l5N0ViT2d2?= =?utf-8?B?Z3NjM0pUYWVibjZraU5FOGl0aHcrUWNZZnpqemdnSG0wY1dZWUZJREpGUFFU?= =?utf-8?B?Wjhhdklwd1lSS0VwcC9lUnRBMHlrQ0J5YmtScm1pLzZaeFZ4YlBwdWtWSU5a?= =?utf-8?B?S0xJQjRTZG9VS2dsRjRTOTY1QXc5SWdmMDYvYWNKMnhsNWFWMDZnbUNTbUtz?= =?utf-8?B?Zk9HREtLVXo3T3V2WXZ3M2p2Uzl2N1lIN3RNRmFQZUJDV1g4U1dUaXlNTVhV?= =?utf-8?B?YUdOMzNQUUVGQ3hxOUw3UkFPZnRPVE1vTGhPcSs2SlNITkhza3Fma1B5dWor?= =?utf-8?B?K0UyRGxmS3l5bWp2S3BtNkFNTWZvVzZqSU9OZTFDRUpMUXZrR1JTRGlLSDNz?= =?utf-8?B?a1FiTnhXZ3AzZmtuQ1hKQmN0VUlmS2ZyMlMydlFsczNwYlFuZWl1dU5PSHpD?= =?utf-8?B?alU4OEFWdldmOXRIKzJ2clU2TDNEZldsMzg3NEV1WklOblFydWdGZ0cxd0hn?= =?utf-8?B?bCtUQzlaN3FyVXhEUEpsZk9rdEFKdGt2azl4dU0rUFVoZVJ4clJJdVllYWJV?= =?utf-8?B?czBINUw0L0phZWtISHBUR0lkdXZQUnJSWkNOVkgraE5HSlF4cWRmZUo3UkJW?= =?utf-8?B?OXBRemNUMlZ6eDNHVjkyVTV1cm1mdDJmYXFGSmVQVzdTSEtNRkZ0a0RHRlJv?= =?utf-8?B?dzZmVUtzWlR3SHZVTmwrVFJ1WGI0MDBaTVNoeXQyRitDV0FIeFZQZzNJVWgv?= =?utf-8?B?Rk0wNFc4M1d1S01WUmQ2RE9jdndKK2JoQzQveUtEWWRRUDJobVVSVWp5MTg1?= =?utf-8?B?SjRjV2YzNGVpc05BZ2lFRU5oNGlzQnVSOFBLSEJRL0ZmdWNhb1Z1bmo1TElU?= =?utf-8?B?UG4vTHdrMDZpVjB3bm85KzloWlp0d1dqbVhYVWNxdFV6MnFWRVpzRWdTZUJW?= =?utf-8?B?T0xNLzZMdEhSY0NTbmJXNG91RlBobG1acXhIZkxFTTJPYUc3eElBakZPdk92?= =?utf-8?B?cXUzVUVRUXhqNmR0NmNPVDhYVWpnalRzQ01jM1ZabEp2dGMrTmVUNkZVYjB5?= =?utf-8?B?WHpPOWdYdzdnVEVGUGpoQUNndnJ1TWFNd3A3RWVwMngzby9QVDVBN3ZRMHFX?= =?utf-8?B?UTdoQ0cyZ0gyaXlTNWkzRndkMFF1cFpXN2h1Qm1zckVqazlNakV5MVAyTGxN?= =?utf-8?B?K09hb2d0MVowWWtMWk95cm5NdmtDZm42QlVvTTMwVVREcWUwR3lFQ00xNU1J?= =?utf-8?B?RlZBWlVkZnlUa2tGUkJJNDdwYU0wSjdOQ3J6RXpvK0RwYm85RmY1TWFtRHVr?= =?utf-8?B?V1JYRXZyNHllQ0E5cVd2Vk9mLzdLSmRFWDdVNnlqWkxrelBYdCswZmhiakJS?= =?utf-8?B?ejB5bnRObEg1RWYxQ3dyV2MxZXdKeFhmZWlhazZnRHBFZVpZV1FxemIyYXRX?= =?utf-8?Q?UJS1t7/AEwyHyhOFSlq73rjpm?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fda967f4-d351-4e28-53d6-08daa1406272 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 10:58:32.7516 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7DvR+N12RKbweTexAmnxJeerJ/xRXdwQv8tpDczNk4weDJ4n3jX+si/EJ0LwJubmMFe/n6Q+1x37lEMvlTZ2GOZm+56OCmNkhKSNDcnWFso= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5414 T24gMjgvMDkvMjAyMiAxMTozOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEFzIGFuIGFsdGVybmF0 aXZlIEknZCBsaWtlIHRvIHByb3Bvc2UgdGhlIGludHJvZHVjdGlvbiBvZiBhIGJpdCAob3IgbXVs dGlwbGUNCj4gb25lcywgc2VlIGJlbG93KSBhdWdtZW50aW5nIHRoZSBoeXBlcmNhbGwgbnVtYmVy LCB0byBjb250cm9sIHRoZSBmbGF2b3Igb2YgdGhlDQo+IGJ1ZmZlcnMgdXNlZCBmb3IgZXZlcnkg aW5kaXZpZHVhbCBoeXBlcmNhbGwuICBUaGlzIHdvdWxkIGxpa2VseSBpbnZvbHZlIHRoZQ0KPiBp bnRyb2R1Y3Rpb24gb2YgYSBuZXcgaHlwZXJjYWxsIHBhZ2UgKG9yIG11bHRpcGxlIG9uZXMgaWYg bW9yZSB0aGFuIG9uZSBiaXQgaXMNCj4gdG8gYmUgdXNlZCksIHRvIHJldGFpbiB0aGUgcHJlc2Vu dCBhYnN0cmFjdGlvbiB3aGVyZSBpdCBpcyB0aGUgaHlwZXJ2aXNvciB3aGljaA0KPiBhY3R1YWxs eSBmaWxscyB0aGVzZSBwYWdlcy4NCg0KVGhlcmUgYXJlIG90aGVyIGNvbmNlcm5zIHdoaWNoIG5l ZWQgdG8gYmUgYWNjb3VudGVkIGZvci4NCg0KRW5jcnlwdGVkIFZNcyBjYW5ub3QgdXNlIGEgaHlw ZXJjYWxsIHBhZ2U7IHRoZXkgZG9uJ3QgdHJ1c3QgdGhlDQpoeXBlcnZpc29yIGluIHRoZSBmaXJz dCBwbGFjZSwgYW5kIHRoZSBoeXBlcmNhbGwgcGFnZSBpcyAoc3BlY2lmaWNhbGx5KQ0KY29kZSBp bmplY3Rpb24uwqAgU28gdGhlIHNlbnNpYmxlIG5ldyBBQkkgY2Fubm90IGRlcGVuZCBvbiBhIGh5 cGVyY2FsbCB0YWJsZS4NCg0KQWxzbywgcmV3cml0aW5nIHRoZSBoeXBlcmNhbGwgcGFnZSBvbiBt aWdyYXRlIHR1cm5zIG91dCBub3QgdG8gaGF2ZSBiZWVuDQp0aGUgbW9zdCBjbGV2ZXIgaWRlYSwg YW5kIG9ubHkgd29ya3MgcmlnaHQgbm93IGJlY2F1c2UgdGhlIGluc3RydWN0aW9ucw0KYXJlIHRo ZSBzYW1lIGxlbmd0aCBpbiB0aGUgdmFyaWF0aW9ucyBmb3IgZWFjaCBtb2RlLg0KDQpBbHNvIGNv bnRpbnVhdGlvbnMgbmVlZCB0byBjaGFuZ2UgdG8gYXZvaWQgdXNlcnNwYWNlIGxpdmVuZXNzIHBy b2JsZW1zLA0KYW5kIGV4aXN0aW5nIGh5cGVyY2FsbHMgdGhhdCB3ZSBkbyBoYXZlIG5lZWQgc3Bs aXR0aW5nIGJldHdlZW4gdGhpbmdzDQp3aGljaCBhcmUgYWN0dWFsbHkgcHJpdmlsZWdlZCBvcGVy YXRpb25zICh3aXRoaW4gdGhlIGd1ZXN0IGNvbnRleHQpIGFuZA0KdGhpbmdzIHdoaWNoIGFyZSBs b2dpY2FsIGNvbnRyb2wgb3BlcmF0aW9ucywgc28gdGhlIGtlcm5lbCBjYW4gZXhwb3NlDQp0aGUg bGF0dGVyIHRvIHVzZXJzcGFjZSB3aXRob3V0IHJldGFpbmluZyB0aGUgZ2FwaW5nIHJvb3QgaG9s ZSB3aGljaCBpcw0KL2Rldi94ZW4vcHJpdmNtZCwgYW5kIGEgYmxvY2tlciB0byBkb2luZyBVRUZJ IFNlY3VyZWJvb3QuDQoNClNvIHllcywgc3RhcnRpbmcgc29tZSBuZXcgY2xlYW4oZXIpIGludGVy ZmFjZSBmcm9tIGh5cGVyY2FsbCA2NCBpcyB0aGUNCnBsYW4sIGJ1dCBpdCB2ZXJ5IG11Y2ggZG9l cyBub3Qgd2FudCB0byBiZSBhIHNpbXBsZSBtaXJyb3Igb2YgdGhlDQpleGlzdGluZyAwLTYzIHdp dGggYSBkaWZmZXJpbmcgY2FsbGluZyBjb252ZW50aW9uLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 28 11:14:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 11:14:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413275.656822 (Exim 4.92) (envelope-from ) id 1odV13-0001W0-Vm; Wed, 28 Sep 2022 11:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413275.656822; Wed, 28 Sep 2022 11:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odV13-0001Vt-Sk; Wed, 28 Sep 2022 11:14:13 +0000 Received: by outflank-mailman (input) for mailman id 413275; Wed, 28 Sep 2022 11:14:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odV13-0001Vn-Hd for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 11:14:13 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae659d20-3f1e-11ed-9649-05401a9f4f97; Wed, 28 Sep 2022 13:14:12 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 395891F8A3; Wed, 28 Sep 2022 11:14:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F080D13677; Wed, 28 Sep 2022 11:14:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RA1iOYMsNGOPHQAAMHmgww (envelope-from ); Wed, 28 Sep 2022 11:14:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae659d20-3f1e-11ed-9649-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664363652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tqwjTNsNpcERWjDz1fPON8xYqOIAIB1dbYDmCmw5vcU=; b=s2j/BTUEXoHigtOP0NP3smq+bX7JycHyjAEsT+lU7PpRhL8PPylsgDsoJpJ++tEcayuQXf qT4vNrvVothrRH/ywshInHHLUq2JenK90tk4X6tTSTboDFsBPfBTtvYe9y/K2+0m250bh2 kFuVBWdui+aJHO7Y5DWTvVujYQwPkx0= Message-ID: Date: Wed, 28 Sep 2022 13:14:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ETT5g0gHWN2exwGxTbC4Uq0u" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ETT5g0gHWN2exwGxTbC4Uq0u Content-Type: multipart/mixed; boundary="------------C3cZWpcpO0cpAejN1RTVDpfh"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> In-Reply-To: --------------C3cZWpcpO0cpAejN1RTVDpfh Content-Type: multipart/mixed; boundary="------------pkOBvL0jXdBhxRtMG2wraaA9" --------------pkOBvL0jXdBhxRtMG2wraaA9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMTI6NDgsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gV2VkLCBT ZXAgMjgsIDIwMjIgYXQgMDg6MTY6NTNBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+PiBBcmUgc3VyZSB0aGUgaG90cGx1ZyBub3RpZmllciBkb2Vzbid0IGdldCBjYWxsZWQg aW4gdGhlIGJvb3QgYW5kIGluIHRoZQ0KPiANCj4gSXQgZG9lc24ndCBiZWNhdXNlIGl0IGdl dHMgcmVnaXN0ZXJlZCBhZnRlciBzbXBfaW5pdCgpLi4uDQo+IA0KPj4+IHJlc3VtZSBjYXNl cz8NCj4gDQo+IC4uLiBidXQgaXQgZ2V0cyBjYWxsZWQgZHVyaW5nIHJlc3VtZSBiZWNhdXNl IGJ5IHRoYXQgdGltZSB0aGUgbm90aWZpZXINCj4gaGFzIGJlZW4gcmVnaXN0ZXJlZCBhbHJl YWR5LiBTZWUgbXkgbm90ZXMgYXQgdGhlIGVuZCBvZiB0aGlzIG1haWwgb2YNCj4gd2hhdCB0 aGUgY29kZSBkb2VzIGN1cnJlbnRseS4NCj4gDQo+PiBJbiBjYXNlIG15IHN1c3BpY2lvbiBp cyBjb3JyZWN0OiB0aGlzIGNhbiBzdGlsbCBiZSBzb2x2ZWQgYnkgYWRkaW5nIHRoZQ0KPj4g aG90cGx1ZyBub3RpZmllciBvbmx5IGluIG10cnJfYXBzX2luaXQoKSwgYW5kIHJlbW92aW5n IGl0IGFnYWluIGluDQo+PiBhcmNoX3RoYXdfc2Vjb25kYXJ5X2NwdXNfYmVnaW4oKS4NCj4g DQo+IFByZXR0eSBtdWNoLiBZZWFoLCB3ZSBzdGlsbCBuZWVkIGEgYm9vbC4gOy0oDQoNCk5v LCB3ZSBkb24ndC4NCg0KVXNpbmcgYmFzaWNhbGx5IHlvdXIgcGF0Y2gsIGJ1dCB3aXRoDQoN CisJbXRycl9vbmxpbmUgPSBjcHVocF9zZXR1cF9zdGF0ZV9ub2NhbGxzKENQVUhQX0FQX09O TElORV9EWU4sDQorCQkJCQkJIng4Ni9tdHJyOm9ubGluZSIsDQorCQkJCQkJbXRycl9hcF9p bml0LCBOVUxMKTsNCg0KbW92ZWQgdG8gdGhlIGVuZCBvZiBtdHJyX2Fwc19pbml0KCksIGFu ZDoNCg0KK3ZvaWQgbXRycl9hcHNfdGhhdyh2b2lkKQ0KK3sNCisJY3B1aHBfcmVtb3ZlX3N0 YXRlX25vY2FsbHMobXRycl9vbmxpbmUpOw0KK30NCg0KDQpKdWVyZ2VuDQo= --------------pkOBvL0jXdBhxRtMG2wraaA9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------pkOBvL0jXdBhxRtMG2wraaA9-- --------------C3cZWpcpO0cpAejN1RTVDpfh-- --------------ETT5g0gHWN2exwGxTbC4Uq0u Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM0LIMFAwAAAAAACgkQsN6d1ii/Ey/j Owf/RL1w9WJzcN+awH6cnj7SpHSu0q93P9keOjhDUnshuEl0+Are4SqCEePlZ1H7d0H7DJ8OOUl5 +GrIz88AXcTDeU+lWlzFmqB9+sPqBZH5GEMUV2mHTZsXwR9yuaoutabP7RKSxZW6XHZvQfnvZUkQ XwRiSD5fY7OIt0h9Qx5uFNA5dJipZrLNadCF+UgKD8bgOy4ah09dLoCJotottqyvhQQYaNgffsRF 8JAF7v8/0STXdpErNLyRIPdVFycKQBSh8saWyAAdkPkO2widm2gpquRmBdc4GZ2TC/iKEp/XzkYO pa97GtsV27M4g7jwdE59veoizcv166dIKA2of2PC7A== =YBSE -----END PGP SIGNATURE----- --------------ETT5g0gHWN2exwGxTbC4Uq0u-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 11:23:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 11:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413281.656834 (Exim 4.92) (envelope-from ) id 1odV9a-000312-SB; Wed, 28 Sep 2022 11:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413281.656834; Wed, 28 Sep 2022 11:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odV9a-00030v-PM; Wed, 28 Sep 2022 11:23:02 +0000 Received: by outflank-mailman (input) for mailman id 413281; Wed, 28 Sep 2022 11:23:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odV9Z-00030p-Db for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 11:23:01 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e88a9dbc-3f1f-11ed-9649-05401a9f4f97; Wed, 28 Sep 2022 13:23:00 +0200 (CEST) Received: from zn.tnic (p200300ea9733e7ee329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ee:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 163261EC059D; Wed, 28 Sep 2022 13:22:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e88a9dbc-3f1f-11ed-9649-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664364175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=H37L9qeZmmgh4Ob+dcO4c+wKevaFARZE41KleCoIqh0=; b=Upn/lR31WevfgW+y3+vXEVtSERdEAVv/TI3lRbXaQBdP4yBNc507x/E5NXBTUD1mwJTAbQ 6zfe5r3uYXbWUJqZJiPVDGL5Dvj5kw89TVpkzyfSUWsk/fehuAYYHghSVpYZf/aLwUyx4E 9zruyDj1Sf7rvxpqHONY003jfJTdkpM= Date: Wed, 28 Sep 2022 13:22:51 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Sep 28, 2022 at 01:14:11PM +0200, Juergen Gross wrote: > No, we don't. > > Using basically your patch, but with > > + mtrr_online = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, > + "x86/mtrr:online", > + mtrr_ap_init, NULL); > > moved to the end of mtrr_aps_init(), and: > > +void mtrr_aps_thaw(void) > +{ > + cpuhp_remove_state_nocalls(mtrr_online); > +} Yes, so you said. I'm not sure I like this toggling of notifier registration like that. Optimally, I'd like to be able to query the suspend code whether it is in the process of resuming. This here: static int resume_target_kernel(bool platform_mode) { ... Enable_irqs: system_state = SYSTEM_RUNNING; local_irq_enable(); Enable_cpus: pm_sleep_enable_secondary_cpus(); but being able to do: pm_sleep_enable_secondary_cpus(); system_state = SYSTEM_RUNNING | SYSTEM_RUNNING_APS_UP; which can't work, obviously. But something like that. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Sep 28 12:07:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 12:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413295.656845 (Exim 4.92) (envelope-from ) id 1odVpv-0007n0-Ko; Wed, 28 Sep 2022 12:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413295.656845; Wed, 28 Sep 2022 12:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odVpv-0007mt-I3; Wed, 28 Sep 2022 12:06:47 +0000 Received: by outflank-mailman (input) for mailman id 413295; Wed, 28 Sep 2022 12:06:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odVpu-0007mn-Vu for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 12:06:47 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0597b201-3f26-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 14:06:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7219.eurprd04.prod.outlook.com (2603:10a6:20b:1d3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 12:06:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 12:06:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0597b201-3f26-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FitsUuUCGw1Lih/g/XeVfr/+CbYixitWzXAFzUTiHRosDcI6/sOKGFBrao03ibCCCOQPpj8zl97SNA+NaUi5+FohqAk/IKBavwiwZDdapOgHZvdLgf3hWelzELsZlZQxd331eD2KqM3sui9LEDpQ61OjdwfCYWUZQ2fg9F/lltTL0VX3+D8BKyB3m8ZLM1YaILA4ggvkje+uZucs55zDw6V0Zh03ZwxuJ5BGcH2rpNhwRw/zWQY6uhTMuRq56QHtTMWue7Bf3qJQGjkrOfvv9QYVL0MNzXj28QL5ljnPSN4Jh/c3d5bQjtet+aDPNcetutjpG0HJvzsbyIOa8IIimw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OBLInMlojnTFV21wrEZ2CRy1C0KdrYkbE46O3y3IEVA=; b=esjT8gpPrUUWeExVnSAtYP2wJptpjcYBbqE2eO5zqLG5H257R3l5zX7hz3IiKZ0zIxu2AMFaEdsN08fMxFonufgsCG2HEFzICA6WmTSuZerX/ITWE9DhFSkydUKOiASEqnqcxokn9bV8TgnUS4QIhsEzJcn4SmKT64NiLBcB18vq1uRB72u98rYczkco5jLTGgNYTngECNRpEPNpN8x5uJE5CxiL5sgPKNpvE4mXHJv6lXC/Ke+8VFKnkv8Qs9d4IL5rf+zNyn0ESb/nPKTdCTYxZdHHryeo45NvTKXxpM3d68uj6lQYThcrmX37EARegZcPjkMzuE9DFI9EtesjAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OBLInMlojnTFV21wrEZ2CRy1C0KdrYkbE46O3y3IEVA=; b=nI6ZqcwezKZrdBUBOJctLr677/W+NerAR1z1YQxU0s3GlvhL2b+/8NP1WjdNmii8FuZfxKBtsIKGXX/d05zM4BrMk59p/awBWTBn5ItsyCqZKJT0IvmzO8GG8ZcceWOVXucO5bzq7T+m2gja+UjM0SEJHTd6BagNyNkfDVXI+ch9AMhqKQiofkRpSL8kA/OAmbI3UxZD0bId3p0PpRqJ9ZCG4A4c3DLrTWQ8IjCufIbI98Qewr1nkvgszU1Rp+AYczAzgok3pCcEvCncY2MiKGZrs20x8vMnfGaxIwkcQnGk3qXKOhh88orA/4t/zDKEU/DQJ1VgukvaF4Sxn3jvYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> Date: Wed, 28 Sep 2022 14:06:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Andrew Cooper References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7219:EE_ X-MS-Office365-Filtering-Correlation-Id: ebca70c6-5aed-4591-25fc-08daa149e8ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bD0STrwEUKifnOX2HbLKW4jzIDcbfYvjpK3R9IkcpdZ1JOuKpYNVUEiHil/U0avUj0ROnrVEgOySQ9m2WTxBKN43LhcsPpARJwJW+PxX4FU6XciTWurEPlK1P7ja8bZWuebTtCYeFlPwaoThexUdem6nzF/fPG1uF45WLvwNzM6UmtDpMFRq94Pc6WczK7BYJZ3oCeoV/Qoyj0/eTb1Echrl64oHxNz9AZmxOEfUQr9DDDBt+ZQVUrlQ2pMZoKpNwAp13IBE7OUfDtmQ42d3zlDm7psP7aCeIx/X53G2irusd04uICKWtgto7769zTQV90bQ6coAZ9O9UcUttENZyVlcbxh+q5awb+ggRhd/D2QYjLMvBtzef2NvRBGxbApozWw6+oXjykn21gI+FF14OEknnXjtVe9XudMtUJCW01g2C33zv9xQ5nD7ovCy6W1PrMJ/CTJKjq2hdnXDO4FHlS5y1PX9VFMgWn2K41aPpGcSv5oaZdVw3slvuBP4Pdz4IasythPjvILz85pQVTffLY/0izCUMTiZMtqWEZn8EjwXW8k7zA6v3RfkvEJEBpCQcCS2ZgKNIUAcKtcbAw+j0M2T/bSEKSEC1q4I1GKCXN9kFsPxa2mvYfTeLBF0tjj7v9s/EqI+KFPDdvatKj2l+HQi8brZSjw6+XYHEp9PlWbOPTNdKZC1fhpuJwnZXn6UkLFtwZf5QBhkXMVWOryZkuBlEc7+Mp6QKuULi0NIQcvDyxif5MnKnTvdUwaQ9u7afXYpxybG7tZL92Rj4A1kzdbACyDfE0oTlDblaAeKSFc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199015)(86362001)(31696002)(36756003)(38100700002)(316002)(6486002)(6916009)(8936002)(5660300002)(66556008)(4326008)(8676002)(41300700001)(66476007)(66946007)(2906002)(83380400001)(186003)(478600001)(2616005)(53546011)(6512007)(26005)(31686004)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZwQ3kzeW5SYzVYZUFHczl5ZVF4NDFNaTFDdWR6aXV1bFM4eW94V1Boa2VD?= =?utf-8?B?ckduaE8rUFZMQ3dibEJSbmkyR3VDSEwxTkZQUUlvUFN6MTh2ZGFJR25xdnN4?= =?utf-8?B?OWtQN0F0TW5FQmxrS3VhNU5lYjBJbG9ZRTc4djd0eDFqVWN6WG1EaUx0d3hQ?= =?utf-8?B?dGRUZkNQK3dtR2ErVm0veGo3eERpWW5USTVxNlJvWjJMZ25lUzFpbUo3KzB3?= =?utf-8?B?d0pQdlk5QlhPSkQwaDlZNjVDZHVJMmtWMFFVS3NZM1JCRnNDeG1IZHZ1eXY4?= =?utf-8?B?R0NZRE56OS9wVmZIT0Jad3RzbHowZTJ4WWZvTDR3ZXRmdVlOTzhST2U5U3lS?= =?utf-8?B?bnhBU1BhSjBTeUE5Rk9ldkx1RWJaYTZma252OUtSZ21MZ1dlSTlHN3dCK3Bj?= =?utf-8?B?UURqazVJZVlrbUVSdklleVU3WnNaNDA2QlVRZ2xiS1pMUlhMTnkxaE1iTHNn?= =?utf-8?B?NTBzUU5nSkxVOVZkbC9yS0lrM2F6MVZUMjJYRnZYV3gzNDBiTG5BR2VJd0h0?= =?utf-8?B?K2czcUFYWFVyQnFNRkYwRXBZRUp2M1poTVMrS2FQM3I0cnVZSlFtd2NFTFJV?= =?utf-8?B?ZkQyQzJFWXh2M3NhVVNXS0k3TGhabGFmbzBiZjdVaHdYREVWM3EvVlc3dUFa?= =?utf-8?B?d3o0NUhCNmJtT2hwcFlFYXpPN29WQU93Y3dxanUvemIyRzMvNHFaaUNpOE51?= =?utf-8?B?aXpvOC9EQ0U0U0NqZ2c1MjJPTUdsWS9FWmpMRGVzVkhZSGVvMzd5NEcvZkNa?= =?utf-8?B?Z3FqbzFFZExCK1M2OXJhWklBbkhyNUk0bkFEWnBMN2E1SEEva1pmdnFlV3lE?= =?utf-8?B?cGJ4ZkFnUkk5NDFOSXNFY1FLWStRSTJGZ2FaTTd3TEZPSHg1WFhITVlRZ0p5?= =?utf-8?B?cmZuem5QZG1oTytYNVdxSWFZUlBydGNKRnRRU1R6UXp5eU8zbm1IcTlWT2Zi?= =?utf-8?B?ZjhaS2FjMGplNzFtOUlGMTU4UWJmZVlueFRQbmZCRy9tQ1FpQ2NNQ2NDY3FC?= =?utf-8?B?MXZ4Wk93MThSeEx2ZkV3OGk3V25odHVmTVIvNGdEaDlkKzBscm54Z2xOZWR5?= =?utf-8?B?WGcwcEJNem1MMHBDRDE1MTA4RllLaHQxRVp5YkhnUXo0cCtTV3NGTks0MjhZ?= =?utf-8?B?V0hQZzQxUTlVOEwxNVBaYU41azNGaVNISmdCNElROFdkSUVmUzAvaExwOTdG?= =?utf-8?B?ZThaOXBZTjl2R2dCalpoWk9nbnZPRU4wK0N5VkxkWTMwQm9wcTk5aHpBUmtH?= =?utf-8?B?TldUaHM4ckpEQkhTOFNYb01EUVh2NldzSWExUDhuR1BEbnRuZlNpZ0lOVHVl?= =?utf-8?B?UDRFVGJDR1cxcXlqekZhbFUxblU1Sk9KUDZCM3dUWTNvQi9DWTVlejVkeEdh?= =?utf-8?B?OENhWHNoMXBHQTVLUWd4alNRYXMwZUh2Y2FGTzl6YVhsYjNNRDVDajZkTXlp?= =?utf-8?B?aUx4djZRTlJkeVJMMmp1NXd3U0hhWmNwWjZPRlIveGI1Y3ZzdWRSdEtFRHYz?= =?utf-8?B?d0NoWmJFaFJPcVJpM3RYQm50eHNtMjBLYURIV2hhNjliLzlJNHdDQk9DTStM?= =?utf-8?B?VGpkYmV2WnlyVzZDd0lnM2VpNWllY3Bzd3pYRHg0Um5VZTRKQ3hGZXR0Wi9K?= =?utf-8?B?VUVFdVM0QVExOXJBZGJLOVdZN0owaWdYN2YzOHRsMWJhbEVndlNNM2RMT0dk?= =?utf-8?B?Ry9HeGxiczdNZUVXeDdGR05FTDRBYUx6U2Ftb1NHUHAxZ3E4M0huY1QrQmNK?= =?utf-8?B?aFVzK093WEt4M1Y0aEtBTlY3a0NVb1BUeEV2VEh4YWZITEpNM2FnZDBQcWdk?= =?utf-8?B?MlZ1aDhUNnVOMVpuT1dNYjllQ3pvVGc5aTBjeWRqUmU1dXl6aVI4NFZML042?= =?utf-8?B?Z3RCbE5BSnZ6Y0VheFRSUXhGMEhiNGE0Q3ZvOWozdFQ4am10enVCQjRnaWpK?= =?utf-8?B?Y0NaTVlCYm5uVDdVMVd0TTVSaGlKNzNIbHB3UXpQTmdpNEJWS3F2blo1UkFP?= =?utf-8?B?UjJnMGxJQ0h5SjRHN2tkVGFpOTVYQUoybTdIY2pvRTk3N2ZHVG9HNmFjeERq?= =?utf-8?B?c3hjS2liZlArNmpLQUZaZGFCUEQxMWcvRGd4a05MU0d0T3BUOWloMjFzbG8y?= =?utf-8?Q?in9YHacQKZJ2OGRLrtBRJbF5L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebca70c6-5aed-4591-25fc-08daa149e8ff X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 12:06:44.1472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ziv8kL4TDn4QZ//zO/lpSmcvqwr+3TXf7i+4+iz9XyQcxcO8K9NLScNhwcTWqmxmYDLfAp3WECJS6gVMdzAM6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7219 On 28.09.2022 12:58, Andrew Cooper wrote: > On 28/09/2022 11:38, Jan Beulich wrote: >> As an alternative I'd like to propose the introduction of a bit (or multiple >> ones, see below) augmenting the hypercall number, to control the flavor of the >> buffers used for every individual hypercall. This would likely involve the >> introduction of a new hypercall page (or multiple ones if more than one bit is >> to be used), to retain the present abstraction where it is the hypervisor which >> actually fills these pages. > > There are other concerns which need to be accounted for. > > Encrypted VMs cannot use a hypercall page; they don't trust the > hypervisor in the first place, and the hypercall page is (specifically) > code injection.  So the sensible new ABI cannot depend on a hypercall table. I don't think there's a dependency, and I think there never really has been. We've been advocating for its use, but we've not enforced that anywhere, I don't think. > Also, rewriting the hypercall page on migrate turns out not to have been > the most clever idea, and only works right now because the instructions > are the same length in the variations for each mode. > > Also continuations need to change to avoid userspace liveness problems, > and existing hypercalls that we do have need splitting between things > which are actually privileged operations (within the guest context) and > things which are logical control operations, so the kernel can expose > the latter to userspace without retaining the gaping root hole which is > /dev/xen/privcmd, and a blocker to doing UEFI Secureboot. > > So yes, starting some new clean(er) interface from hypercall 64 is the > plan, but it very much does not want to be a simple mirror of the > existing 0-63 with a differing calling convention. All of these look like orthogonal problems to me. That's likely all relevant for, as I think you've been calling it, ABI v2, but shouldn't hinder our switching to a physical address based hypercall model. Otherwise I'm afraid we'll never make any progress in that direction. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 12:12:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 12:12:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413300.656856 (Exim 4.92) (envelope-from ) id 1odVvY-0000mb-BN; Wed, 28 Sep 2022 12:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413300.656856; Wed, 28 Sep 2022 12:12:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odVvY-0000mU-6u; Wed, 28 Sep 2022 12:12:36 +0000 Received: by outflank-mailman (input) for mailman id 413300; Wed, 28 Sep 2022 12:12:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odVvX-0000mO-72 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 12:12:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d52a396b-3f26-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 14:12:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6959.eurprd04.prod.outlook.com (2603:10a6:803:139::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 28 Sep 2022 12:12:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 12:12:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d52a396b-3f26-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F4DpHQJbFxNLQxE/1YccGtzWNZhk/bUmgAmvf5BDcM5lFOZrVyW/0iGkPaGTuBzu1LNNLU5Kap8FG6R0fN34MAFexkw4Z9bdQO3hfalllbl6bDkycx4BtJBpwIVFgdH6eTjJbLubA14sadXObaSN+e6SFNzwKhpAipabDVcRY2fcefFlRM3KGLWjlGQKs2erCIaYSwLoWiPH8qT4+wYd6j6S4wR09m3HjXcPAW7CkkBB+qogJM0XouEwxcbHP+GEnOPqavFZLL8iO+SErQZn7JV2t3NGJfyFibIQAZ0Ys0CGSW+gW3UMn1aIcUpxhB2ZZLpbRbxfM5bIv7F9yiReMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gyAqsiSzPa5o+G/D+k0KBts/58aQQznsv6CR5kobuHY=; b=ZrTKrzbq0SmLM27SKLLiZodjQvZ1tXsWxRtz2Kp16G4gaovgS5yZ5Wy0fjuaIMUwSnUWRDvEaZBi4f9gslBHVfBTS2ydX5JXODObKagppByofyvoGO5B3znpd52LFAl14NQ4hGW6UsV1Z+GN63ApyuzSwOYY8meDk9WaBuOUYLKueo1YYPQHwK5fUZ804aSHhCQYPXp8e8kLiKvANTUM3AdNCc1Uez/GWYc9uI6/9u+wEhGyii3JMVCDKT5O8CbAq2Okiy0WEp1b4Js4ZeHNc0JQNZf8dqF4Bo3BGNtZTo4oDVfvBH4d8RiP29lEJ5dJoj6p1Ps/uVeMLciI2D52yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gyAqsiSzPa5o+G/D+k0KBts/58aQQznsv6CR5kobuHY=; b=K6sMF90KmKdIoAGaEPMYWaSP/0GqgKeu0+9NGrPOUCCByHMTixOMORDAdIucK1QR+R88zoTcqaQW2n0nmnI4qG9awGJpbjY/FR7SfsAXQWL0bR/LUPeF/2DUI10BK37jDMV0K8FIAqF8pWMJI70rNzqDj2Cie+1Vx78oo7qD5dYczg0JUA6+mWxI274/7US/D8cGD6ekgcFeSVjd9sIoAtPsEBg3y46LqWBl9gIN3x5N9iM85y5aCsHHuWbH9F1UwOKz1VW5OVVb9qHCHwizNyn7+TpJShm2fLiVhwKjkJF8OBDt1vlVYPQuYhdTX/YtmT9eMgJ+2ADNEQcWw8YoRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 28 Sep 2022 14:12:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH RFC] rangeset: mark a few functions pure Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:20b:48b::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6959:EE_ X-MS-Office365-Filtering-Correlation-Id: ce531ad4-b74f-4082-4c7e-08daa14ab7f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AZTdDmwiO/ugR8yONMG/R1cip0ZYQQJQ1XfKOSUp0tGyoSlElpkOFpDwcrb2hIH75KRM3Z5tGeIhBfAXBad3fnB7Ag2qHUrpJhjlBvMsF7EfDfmjauWhAfV32R27QNUVF1tjCgvQhcoOtb1tHevM7GrUZ+vjt+mhp34rkjtqLwYo4s7JxE6Ck4Lf2Y+jMapJFS7dyE+wCY9TZhvDiwB9LyDdaMSQrQ08ftYpZ/3kkmOzcfRGfIoZFHjs27cSBcIRH2TxoLadt1n0QUE8tlKe0WFscs7UT4ZN2M9U4E3NgCyuWwyGbbWB5GC0s9IJD/67m+Ax4ydiQUvGcH9I+9n5bPWUuIPrV3oAiKohGedmz5Rv4+xWI4aeTZVd7APCKzqPg8GOSph6O7Snucnk0wRvjPwSvhtGMdPI25ZngRkHZ1jA+QmvlP9G0hJq/tV5xACuOUAzKED9/GWCFWQabM9jDUo8ozL61+RqLo1a9PVUa+xTklrhu/ZngxvWVnkWW/Qly7CiVQv8JQsVMYMIjSx5Gz5RoWYAE5hzi1VchnXybHyvJGHMoPKeu9KIn5kNMYQESUctEvlGpNr0rMgiQLz59dBsjxxq5yKuAAWyE5FnTMpg+GcLoN5aVjxQgPe9A17cxELK1aLzaj5kJidZOECbwN6XoIkOfpQmD+q2jMxo2BUR4PYxwxQPhTUNavqFb3dP5Oe4dPD5NFJi/hwPi6ls2u3FlEv4G4w1Gr4/yN4Jyo9XchgiJsopBa3IWim6hEzwMlOHyXW9G5k1u+hHJS/DVhCh9A2HFu4TasPbKdy4lmc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199015)(6916009)(5660300002)(8676002)(4326008)(6486002)(54906003)(66946007)(316002)(36756003)(31696002)(66476007)(478600001)(38100700002)(2616005)(26005)(6506007)(83380400001)(41300700001)(6512007)(8936002)(186003)(2906002)(86362001)(31686004)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmhaY3lIbXBZekF4ZGp6OGtyY3NMcTFNcHBZUDB1OFdPRWszdVQvTWJnUkkz?= =?utf-8?B?bVk2VXhHdTR2SnhXNGVnd0pPTnJaU3FMNVBKMW4zRlBDMlVPaVh0dXU1S3hl?= =?utf-8?B?S3pHVXdsMGx3b2VUbkE1RCt3TDNRVDlJQzBpK0JNYms2R09WRndhRWZSZHV5?= =?utf-8?B?ZnZrT1c3TzlERHNsWGtHeGVYRy91bW53bndmVGczK3RBZ1h2VVZ2bGYxbFFI?= =?utf-8?B?endDMjhlcVZTdXFmZzczMDFHaEh5dW9DMG1CT2RNT2R1bzVmbmk2Ri9TN3JG?= =?utf-8?B?SDgwYmo3aTRBbzkwQmZ0UHNxWDU5dWRSN1UwNWE2RVprL0hkWG5WN3RacVU5?= =?utf-8?B?NzlhSGdxOFcvdjh3b0hIM2orcTVydHprK1Iza0x1QWFseHFwNkNNVS9sQXRV?= =?utf-8?B?SUN2NVhLSkdlQmx5d1Y4a005Z0RUQkxDNUtQTXVabTE1K0hTZGdjampNSVdW?= =?utf-8?B?RStrM2NsZnJSaTVqUGo4bkpQajlsdHh2dlJzcDRUQi9ldW85c0tCcDkzRHJJ?= =?utf-8?B?NTR3Mm1zc3JFeEl1MkQvMlIrWlJ2R0dQRFdCZ1dTWkNjNHZjTWVMSDduSU5K?= =?utf-8?B?bGhrOSt6cExQbWFKR3RJQXZBQWdQQnVCMWZIQnlCY21CUGdSSW13QWVtS0hv?= =?utf-8?B?TjczVEVsczI5eldQK0lmWi9qOHowUlUwV2hPR1lYaDZ3OEVQcUxZd3RSL1Fi?= =?utf-8?B?U0c3dGNESEhYRCtpRUZiWExqMzg0ZGhDUURHejk2cE15VEErbzl3Mk50a3RP?= =?utf-8?B?ekd0WCtoNFk0YWJPSmVZNC9Id3F5RDhPVUJFd04zU0FtdmVvSWZaUzdxaFZp?= =?utf-8?B?Z1Q4RXVrZDkvSDZsZGM2dFhJVi94c002Q3R0Nk4zNVp0NVZqcHp3OEdVc2FR?= =?utf-8?B?VW8vN1J4ZWFhYU02cGNLc1ZNSnlrMG1KMXlEa29kNmMweGNXVFhIZmVWWEpF?= =?utf-8?B?bGh1VTBsV3dMYzl0eFVORWxRZUN4QmFPdEFqc1FiTlJGZXJDbGVYZ3JhWjFo?= =?utf-8?B?R0JLV0FjYUZyZ1FRYitaekZVbUpMRXBtbnZ6eEp5RWZaRHRvTUF4Qnk2N0p4?= =?utf-8?B?M291ZUxKek5rZXJ3eS8vM0libzJnbDlld3BtVFUrQ2E2Q0JNT21FWUdxV0RQ?= =?utf-8?B?bG9YYnNaUk1hc05WcXdvcm5XeVlYUm9GSDIwV2VnT0Y3cWtTWXloVlh5L0Zi?= =?utf-8?B?aTJjRHdtL2FOVTMxZ1FnTVJyVUkramtFSHNIdE5uTzI1RW5YZzlRZ3pjNjUx?= =?utf-8?B?eXZUSVcvZVl1aWJ4elhVTEEzNzc1dDRTOW5PejNKU1hqT3ZoS3YvbS91SW9O?= =?utf-8?B?Y29qRG1BZ2wzQ1R1c05MZDZkcVI5cnpxQmNpenFFbHloMnlzTklDUFdlQWh4?= =?utf-8?B?Sk5aV1ZsL3kxRHE1bFBob0pVOUtkY0w2UG1mM3BoSkMxdElYT2IrL1RkTjgw?= =?utf-8?B?TVpWcFBhODQ5cDF1YWdFbDI2bkN4NGpNemJ6bWRtQ2lPdG9ZclBvZVNmclFn?= =?utf-8?B?MkplL3FBc0dYVHc3MWJlYXBmQmdmcjdDUWI0MHFBRmhjaGdoWHBaY1F4K2Y1?= =?utf-8?B?MVJLSnQrbnhlbzFQT1piMFVYMnVFaG53UENrRXpaQlBFdGlIL0l3cmhXVWZl?= =?utf-8?B?bWMwQmMxZ3lVOVpSY01KSTZsZ3hnaFA2TmJnMWROd29QMXN6WC9SOW1lZVlI?= =?utf-8?B?TDZqTVpWQ3JndERqcHRicFNuQ0wySk5BQnBEOVNBZlJ5MWlkVVhSTGE1Q0dS?= =?utf-8?B?SnhGTzhVZWZJVjI2UFJ3MkFxV3M2OUZnK2JFYU9lK2pVaXJzb2NHM3lVL1Ns?= =?utf-8?B?dzl4bTBUVEltTWhGeGU1UEgvUzZLb3AvdGR1L3VqQjZhUWh5b3VhRlM5NG1w?= =?utf-8?B?UnVqdENMdGNUa2VLNnUyMnJwNXdpNStyR3Z5WUJzejliWDNvR2ZTR05FbWhN?= =?utf-8?B?eWV6YUFKSm1jd2cwRzJnd2xualArdmEzUWl4R2RMbnhvOUk2NEIvNGxlUU1C?= =?utf-8?B?Z1N5aGFweFdTU0VEb0tFbkFnb24vcjJ4SCs4WTcxVmpUM0lHRkVXYXRubURo?= =?utf-8?B?dFZYbmJsdnh6VnduZG01TkwyTEFnQVRpak04Qnc2RmR6YUtROVlubGdvUEtp?= =?utf-8?Q?DHqt7VuDZcucZsbXBHY47l/5M?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce531ad4-b74f-4082-4c7e-08daa14ab7f8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 12:12:31.3751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lAFAOdIjLfr8wTbrIXV9xVxDmQcZ511K4gbqulCsNlSyIK2HbfPt8/6y2BXoYE9c+FDGhG0plwCfnh1jphLuwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6959 While for some of the functions there's locking involved, the acquiring and releasing of a lock doesn't alter program state when comparing "before" and "after" the function invocations. Furthermore without (further) locking by callers, return values are stale anyway by the time they can be evaluated. Hence both CSE and DCE are okay to occur for invocations of these functions. Signed-off-by: Jan Beulich --- RFC for the (imo) ambiguous wording in documentation. I further wonder whether functions trivially wrapping others without de-referencing the rangeset pointer, like rangeset_{add,remove,contains}_singleton(), wouldn't better be inline ones. This would (afaict) eliminate the need for marking pure the one of those altered here. --- a/xen/include/xen/rangeset.h +++ b/xen/include/xen/rangeset.h @@ -52,7 +52,7 @@ void rangeset_limit( #define _RANGESETF_prettyprint_hex 0 #define RANGESETF_prettyprint_hex (1U << _RANGESETF_prettyprint_hex) -bool_t __must_check rangeset_is_empty( +bool __must_check __attribute_pure__ rangeset_is_empty( const struct rangeset *r); /* Add/claim/remove/query a numeric range. */ @@ -62,9 +62,9 @@ int __must_check rangeset_claim_range(st unsigned long *s); int __must_check rangeset_remove_range( struct rangeset *r, unsigned long s, unsigned long e); -bool_t __must_check rangeset_contains_range( +bool __must_check __attribute_pure__ rangeset_contains_range( struct rangeset *r, unsigned long s, unsigned long e); -bool_t __must_check rangeset_overlaps_range( +bool __must_check __attribute_pure__ rangeset_overlaps_range( struct rangeset *r, unsigned long s, unsigned long e); int rangeset_report_ranges( struct rangeset *r, unsigned long s, unsigned long e, @@ -88,7 +88,7 @@ int __must_check rangeset_add_singleton( struct rangeset *r, unsigned long s); int __must_check rangeset_remove_singleton( struct rangeset *r, unsigned long s); -bool_t __must_check rangeset_contains_singleton( +bool __must_check __attribute_pure__ rangeset_contains_singleton( struct rangeset *r, unsigned long s); /* swap contents */ From xen-devel-bounces@lists.xenproject.org Wed Sep 28 12:19:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 12:19:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413306.656866 (Exim 4.92) (envelope-from ) id 1odW2N-0001V4-0Z; Wed, 28 Sep 2022 12:19:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413306.656866; Wed, 28 Sep 2022 12:19:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odW2M-0001Ux-U6; Wed, 28 Sep 2022 12:19:38 +0000 Received: by outflank-mailman (input) for mailman id 413306; Wed, 28 Sep 2022 12:19:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odW2L-0001Ur-OP for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 12:19:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2046.outbound.protection.outlook.com [40.107.20.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0ffba84-3f27-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 14:19:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6805.eurprd04.prod.outlook.com (2603:10a6:20b:dc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 12:19:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 12:19:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0ffba84-3f27-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=asVf65sdeDK7hWo3DYozk5OWQHr4Jzs91yXzmA0uZfDLPd3v60eAZxS/ky/QWhYp1qwC1O6gsIJxjK50GzqYFgB6Jo1sY4s2ywLVNjNCSHxgFZzDLmg50moY6OFchW6tmXUtd9CRg964r8zoe7Z/gPVj3VlHIqDjbKuA/QOsIXqb52CbMHQ6pOz8el3JRQdImVrtUy6eiJnREPatpV1/92+fUIlJdoIrgbCQF95mpXrhpCLtl5hcAa9HZYGhTFtUeSQlmapZOco+oYJ0f9bHHa6PthsKv1V/UJRbdJnAKaCJDM0IkbnafZJFI+2iFL6z6mr5AxYSTcYZCjDcyrzVdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oNlty5GSGJXEwlDKKrNA66z9NHQdWfa/G8QT3SLNiZg=; b=jtv5eMi2gSqFop3/+MD0/GWLQxT98rmiG4zESBFJHimipUHGG0Z2K0PuWlAhasXCOH/68wFNhY9kQ7qNKR3tOZnkEAhrrWmfXgIIepd1B+EQnUkXLz2gexBbQEAl15uQTGgyIyxg+kG4vspMsmSUOhJcLxnOuTDL2kQaS3/DMXTEFt5xzRZq/r/Rn5ieZ9D5m4ZnqSawP6jTUuWxJ53uCDFkj55QlfmTc+L95KsYuFSAbGl+BnW4gKR0NYIqcHgXnr8MHNFZMxEVwURwGiwbev8YytPSnemUOwdsF5IbmRNC+f28xBUJ5vk2aRshxR15T3xaEcm4AhKfQVBnRAl0Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oNlty5GSGJXEwlDKKrNA66z9NHQdWfa/G8QT3SLNiZg=; b=3hvU/JlII1MlQ0+2m8fUzeWrt3v6KSFIj5X793VTvtS0+Qm7YDiRDZX+WCOofZqMuD7GHJuWV8gHYZLth4p9HtVGwgWWb9JcY+r7ljsJpt3u0mjIKe0HrnSew4CHM2nPNGbFIGapAiweyW0+Cy+eH/tapNUJfdksPPGC5+f/kvb2ITpwgBnhDOaJKyqW6jFaWcbEQLtcv3GdhHZQUgpSKSElhq0y2rTZKyh16lTCJMIr01bkB5x6LE6bAVNnZVCo7LGtLq+bPnGwX3vIgC0tMczWqjl0bKqSJfQtKXdhn0NHBYM9hOKWZiB1hcZnyzfF7/1nGoExfTJGPpTobQplzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7a67df6e-bab7-978e-0045-9165621d1ffd@suse.com> Date: Wed, 28 Sep 2022 14:19:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [4.17?] Re: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <87c5e6be-5ad8-fe2f-d729-4f9904a4a027@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6805:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b2227b3-640a-4582-61b2-08daa14bb3a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G1Zmu1clx26RrtwUAflD2a0P4C68uOst/EkdfsvFS8ZavjGs8ZnNrxfbktoquhP04jXBq5udp9bY7RCueWGYq47t377U3czFFo3dmM+0bfqu2ZxBL/73V5EE7TBSvOvIZnfVQ0CzS6J/Lc0BP19tIhk3VMrV+kBKM5+yhGXkV6rheDDxyUPDEL06ATT0AI9UVtfimvKOwlAcu5SGLwzTadHLEiw2hpEA27st0NDRoBR0raZkzS6Eq74B1pQAZArP1A6l3JPDT4d0JfvLonOlf2oh0WdZr6j2GdsFL7+00MEMLJfikMbmTx4Av6eGpWhs9l+SEFVfKAHjLbYsygXLni5E2z06drznDmvTL5VEbsn3wUjxZEwNnpgbqqf9I9Sg0TbM0cvbOpHIe8wSL8gYfPYUbK3fbQZr9h5kt15wnWAoSXbmbAZuEZ5qtP4PbNdoYMSGAZBB5WboIEZqyW5hl2M13Jwa3Aw/NrnF1fjnDOMJq5mRQlOBbST+rTM5VT+ispVMpQIcMR5cZQSaG7OgT2Ljoi8SntOR2PY3uK+R0sriXLiMzV5dLaa1TD23P0lm45A6VklCg7agQAOA/jR4qCCOQeWUs2f6LTR7rVyATLECg5jULGPCGz31MLcq3rxrq6peacDgAmci7Hts0FAcHPM1wrlSzJByMCmShtgDNJtGk9+w45pmn3qP9jK4ZUdhJtaVV2m7od50CpDbB7s+z5GwfSyCHyol1Iy6fGHmLjz1/TLOUQil2ZQqkjJkkU1isdkQ0XKG/dDfT37+lutxxnorPWG1tXccZBNxrqbu3LU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(376002)(396003)(346002)(39860400002)(451199015)(2616005)(186003)(38100700002)(26005)(6512007)(4744005)(5660300002)(41300700001)(2906002)(8936002)(478600001)(6486002)(53546011)(6506007)(66556008)(66476007)(4326008)(8676002)(316002)(66946007)(110136005)(54906003)(36756003)(31696002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3hPOVhDb2h4QXZCQTBuNnlMa0tFV1RMZXA3YzF0eTNqb1dOYnQxNXUxODdh?= =?utf-8?B?TUZqL0ZvRWhlZkZQUktqM213Q2JDM2h0bU5iWThFSlpUQjdTL3B2SnVTVjJu?= =?utf-8?B?OUxxNkZmZHpuTXJpVklnclA1bzRNNUhhNUR2ejdmanprd2hkUlFxYlllZVBJ?= =?utf-8?B?SUF1bXFLcThiSUxDSDYzQmxFVDk0U3NQdlAvYmJoL2V0aUxsK0NtdG43bDdY?= =?utf-8?B?NXhtMnhneHdmZDhnNzJxbjNPalo4RjNqNk9QRzRkNEZJMGhpdkFIYitsUjgr?= =?utf-8?B?Y0kvM2tGZStCelVGL1JySU9tS2pFY0NiQ3FNUUN2RzNacnlSc01Zczh0eVRB?= =?utf-8?B?MFNpek5KbXNLbEZ4VFFGUHFidEhkUFI4Yno1N2VDcHhxZks5SzE2bHIrMk9U?= =?utf-8?B?TEdCWkhxUEJEWnJEdmlvTisvUlh6NUxwQzJOdTdIbWF1b0VZSm85akVEeE5s?= =?utf-8?B?Z1BpcUpLZTYxM083Y1g5ZTdYNXBmZUNxTXNOQys3TnlaTHdqSE1kRUNQM3d6?= =?utf-8?B?WGJraXJ2MG8yU1dMdWkxMGVaUjU0MFlWM0JOZG51RHQzU2oyM3NDZTFjcWRK?= =?utf-8?B?TVh1NXV3S2w0endSZEkrdnRvdG12UUZKa1JsWCtGUG51RnRNN0pkcTlUMHdp?= =?utf-8?B?WVVINmtVenZ3NVRsakpKY21Bdm8yWlZVeVNmRlUvM2syQkkxSmlmdEVwL0ZN?= =?utf-8?B?UVdwcDhrN3MzcEdxekxSQzA1VU9ZYVdJemxDVWVyVklVTlpOMXFQM2JZSVdR?= =?utf-8?B?b3JBK1BvYXp4YjljY09NdzBlVG0yTmNuYmp5elFSdGxOYmx4RkJxckYyQnNQ?= =?utf-8?B?WTVPc3pWUVJWWXRTNWFhOEFVZHU3RTUvUTRmSW12cGx2SVhjN1VIRmpYeGNl?= =?utf-8?B?aEd0ZktVdHJ6OCsySzdaTUhXM1lmUE1DV29mMHhTSlFvSjFxb2ZmZ0tsTHZi?= =?utf-8?B?OGh1YjM1dmpEejd2YVYyY2FSTmxNdE5VbmYwQTg0dmRHM0kya0lSNUR1MDgx?= =?utf-8?B?VjhmcUdZU0NRZW02NTJhbDI4bzFiZmx1UURtOFp1SXdzNHRRSkNkQTdnSTlV?= =?utf-8?B?enZYMEFnVUUyWGFHMDgyMDE5bGdPaUNQYml3N2tKaEdRcXFQZHdmaE9pUTc5?= =?utf-8?B?M25JYldwZTdPSXpPQ3ZIa2NEd3pBTnBQYVpuVVRNcFl6dTRvaWlhWmtVZFgw?= =?utf-8?B?WmtWVFhxdXdRYVk4NzhxK2JDNjdJeTVvZVdxTG9WcVlMc2ZxMUdlYTJ3N1dE?= =?utf-8?B?Y1ZlS2szTGNhcVpsVGR3OFFCTGtRcHcvYWttaWNmTmxweHZ5ZUNCL1ExM3Qy?= =?utf-8?B?c2F6dUNaeUMyT0ZWMFFKbDF2dHdQS0lIV04rMmhQamlOSS9zNTdlS013YzhV?= =?utf-8?B?YkhaaFRlTHArdjA4T2J1SEhqVk9oVUZabzZWOUNVUG9OYXhyVnYxQ2liR2wr?= =?utf-8?B?WDlFcjNwMEVVckNGVW41Tk5VSWExaE0yR3NFYjQxOUt3SDdobUlyWG83Y2Ro?= =?utf-8?B?ZGMrOWhPTFlzblIyK2cxZURyVFg1aDJlWGtZbkFxM1VsMWRpdC8ySFVnUk8v?= =?utf-8?B?N3RwMkFYZkNqQ0M0Y2NLdElZWEtkbm9jRXhpTW96U1huWVVIRHBzRktvbW10?= =?utf-8?B?Nkt4UjdVSVBFbmpBTUV6dzJza0MrT05KL3dybjdmeGxRQ0d2WktOSzVsbkZ6?= =?utf-8?B?dUZNMTZETnFtWkV4b0lqVVpBRGxJL0ZDUG9YVW9YalBVVmFpY0ZLaEhMNVNm?= =?utf-8?B?UEJNRVJJQVQrUTIyU1JFdFMveERLeDZrVUtsRE9ja0oxKzdWNE9BazVvM1d2?= =?utf-8?B?QXlaR2xBSnJDTlhFZUJtM2FvTmRyenRCS0RkSlphMElvYUFnR0g3Z3pzQ1FQ?= =?utf-8?B?bVNMSmhWbG8yRVlhVi92QzZ5YW55amNZM0hTRzlMNm9HbGtVVGpaWkhQQnBJ?= =?utf-8?B?UVZscUVmeHVqTnBlaFRzdTF5UC9JS0tLVW96M3k0alhLRG00ZUR0MG5WdkF6?= =?utf-8?B?ZERwa0crUXV4c2JucThBYUszYmhvSi96M1dYTHBoZjRrWFZkdDZTZWI0cjVh?= =?utf-8?B?SXk4QTEwa3BhMWhZQmQ3bGxmVm83UHdGeHNTM0JHMDRKMkYrVm80VitHNEda?= =?utf-8?Q?wy0jyF4WvK2XOTlj1p3lqH4K7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b2227b3-640a-4582-61b2-08daa14bb3a2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 12:19:33.6760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3eqVBH2eT1qi1Kw7kRh4QEZZ5p8aSoNrrbfSFwErrqkhzJvX8gYDbvFIK9oEBJczn6Sb6wTAhXGoro4LLSG45w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6805 On 27.09.2022 18:08, Jan Beulich wrote: > On 27.09.2022 17:53, Roger Pau Monné wrote: >> On Tue, Sep 27, 2022 at 04:15:19PM +0200, Jan Beulich wrote: >>> @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes >>> if ( spdx >= epdx ) >>> continue; >>> bitfield |= spdx; >>> - nodes_used++; >>> + nodes_used += i == 0 || !nodeids || nodeids[i - 1] != nodeids[i]; >> >> I think I would also prefer the `if ( ... ) nodes_used++;` form, as >> it's clearer. > > Okay, will switch then. This isn't for 4.17 anyway (I think), so > there's no rush. Actually I'm not so sure anymore as to 4.17 - we're in feature freeze until the end of the week, not in code freeze. So I guess this (and the other two related patches, provided they would get acked) ought to still be eligible. I guess I'll give it a day for objections to surface, but otherwise commit v2 perhaps during the afternoon tomorrow. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 13:03:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 13:03:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413314.656878 (Exim 4.92) (envelope-from ) id 1odWin-0006rN-Ej; Wed, 28 Sep 2022 13:03:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413314.656878; Wed, 28 Sep 2022 13:03:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWin-0006rG-Bu; Wed, 28 Sep 2022 13:03:29 +0000 Received: by outflank-mailman (input) for mailman id 413314; Wed, 28 Sep 2022 13:03:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWil-0006r9-2b for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 13:03:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f01e2ec8-3f2d-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 15:03:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E90CD21C17; Wed, 28 Sep 2022 13:03:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD7C113A84; Wed, 28 Sep 2022 13:03:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OrThMBxGNGOSTwAAMHmgww (envelope-from ); Wed, 28 Sep 2022 13:03:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f01e2ec8-3f2d-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664370204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WLOKAe0Zy9onlk67rXxTb60lcTABGIARXiVSstAtl5c=; b=FDZuBMOif6+IIeMTh+ps10WqmX/Nu52Tkd2MJnzAV8O7S/9G0fexRtDmGo/kGSSQ4BAjOE NW2AGB7Miydm8h0DP+eqHJn+yqATDP4aKiQYmYb/4rrah/uIxK2biuMjvg+gVLy2zx+XrT fRGNDU8MAqbrpbYQlW/PNEywEqHezLo= Message-ID: <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> Date: Wed, 28 Sep 2022 15:03:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> From: Juergen Gross Subject: Re: Proposal for physical address based hypercalls In-Reply-To: <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YwmfFyl4MUWyXfocPzr4f48i" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YwmfFyl4MUWyXfocPzr4f48i Content-Type: multipart/mixed; boundary="------------P9mk0xTRkupVqoBidzI5Fgiy"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" Message-ID: <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> Subject: Re: Proposal for physical address based hypercalls References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> In-Reply-To: <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> --------------P9mk0xTRkupVqoBidzI5Fgiy Content-Type: multipart/mixed; boundary="------------MnthlwNHWJdKVHE8KnRxNbHZ" --------------MnthlwNHWJdKVHE8KnRxNbHZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMTQ6MDYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyOC4wOS4yMDIy IDEyOjU4LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gT24gMjgvMDkvMjAyMiAxMTozOCwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gQXMgYW4gYWx0ZXJuYXRpdmUgSSdkIGxpa2UgdG8g cHJvcG9zZSB0aGUgaW50cm9kdWN0aW9uIG9mIGEgYml0IChvciBtdWx0aXBsZQ0KPj4+IG9u ZXMsIHNlZSBiZWxvdykgYXVnbWVudGluZyB0aGUgaHlwZXJjYWxsIG51bWJlciwgdG8gY29u dHJvbCB0aGUgZmxhdm9yIG9mIHRoZQ0KPj4+IGJ1ZmZlcnMgdXNlZCBmb3IgZXZlcnkgaW5k aXZpZHVhbCBoeXBlcmNhbGwuICBUaGlzIHdvdWxkIGxpa2VseSBpbnZvbHZlIHRoZQ0KPj4+ IGludHJvZHVjdGlvbiBvZiBhIG5ldyBoeXBlcmNhbGwgcGFnZSAob3IgbXVsdGlwbGUgb25l cyBpZiBtb3JlIHRoYW4gb25lIGJpdCBpcw0KPj4+IHRvIGJlIHVzZWQpLCB0byByZXRhaW4g dGhlIHByZXNlbnQgYWJzdHJhY3Rpb24gd2hlcmUgaXQgaXMgdGhlIGh5cGVydmlzb3Igd2hp Y2gNCj4+PiBhY3R1YWxseSBmaWxscyB0aGVzZSBwYWdlcy4NCj4+DQo+PiBUaGVyZSBhcmUg b3RoZXIgY29uY2VybnMgd2hpY2ggbmVlZCB0byBiZSBhY2NvdW50ZWQgZm9yLg0KPj4NCj4+ IEVuY3J5cHRlZCBWTXMgY2Fubm90IHVzZSBhIGh5cGVyY2FsbCBwYWdlOyB0aGV5IGRvbid0 IHRydXN0IHRoZQ0KPj4gaHlwZXJ2aXNvciBpbiB0aGUgZmlyc3QgcGxhY2UsIGFuZCB0aGUg aHlwZXJjYWxsIHBhZ2UgaXMgKHNwZWNpZmljYWxseSkNCj4+IGNvZGUgaW5qZWN0aW9uLsKg IFNvIHRoZSBzZW5zaWJsZSBuZXcgQUJJIGNhbm5vdCBkZXBlbmQgb24gYSBoeXBlcmNhbGwg dGFibGUuDQo+IA0KPiBJIGRvbid0IHRoaW5rIHRoZXJlJ3MgYSBkZXBlbmRlbmN5LCBhbmQg SSB0aGluayB0aGVyZSBuZXZlciByZWFsbHkgaGFzIGJlZW4uDQo+IFdlJ3ZlIGJlZW4gYWR2 b2NhdGluZyBmb3IgaXRzIHVzZSwgYnV0IHdlJ3ZlIG5vdCBlbmZvcmNlZCB0aGF0IGFueXdo ZXJlLCBJDQo+IGRvbid0IHRoaW5rLg0KPiANCj4+IEFsc28sIHJld3JpdGluZyB0aGUgaHlw ZXJjYWxsIHBhZ2Ugb24gbWlncmF0ZSB0dXJucyBvdXQgbm90IHRvIGhhdmUgYmVlbg0KPj4g dGhlIG1vc3QgY2xldmVyIGlkZWEsIGFuZCBvbmx5IHdvcmtzIHJpZ2h0IG5vdyBiZWNhdXNl IHRoZSBpbnN0cnVjdGlvbnMNCj4+IGFyZSB0aGUgc2FtZSBsZW5ndGggaW4gdGhlIHZhcmlh dGlvbnMgZm9yIGVhY2ggbW9kZS4NCj4+DQo+PiBBbHNvIGNvbnRpbnVhdGlvbnMgbmVlZCB0 byBjaGFuZ2UgdG8gYXZvaWQgdXNlcnNwYWNlIGxpdmVuZXNzIHByb2JsZW1zLA0KPj4gYW5k IGV4aXN0aW5nIGh5cGVyY2FsbHMgdGhhdCB3ZSBkbyBoYXZlIG5lZWQgc3BsaXR0aW5nIGJl dHdlZW4gdGhpbmdzDQo+PiB3aGljaCBhcmUgYWN0dWFsbHkgcHJpdmlsZWdlZCBvcGVyYXRp b25zICh3aXRoaW4gdGhlIGd1ZXN0IGNvbnRleHQpIGFuZA0KPj4gdGhpbmdzIHdoaWNoIGFy ZSBsb2dpY2FsIGNvbnRyb2wgb3BlcmF0aW9ucywgc28gdGhlIGtlcm5lbCBjYW4gZXhwb3Nl DQo+PiB0aGUgbGF0dGVyIHRvIHVzZXJzcGFjZSB3aXRob3V0IHJldGFpbmluZyB0aGUgZ2Fw aW5nIHJvb3QgaG9sZSB3aGljaCBpcw0KPj4gL2Rldi94ZW4vcHJpdmNtZCwgYW5kIGEgYmxv Y2tlciB0byBkb2luZyBVRUZJIFNlY3VyZWJvb3QuDQo+Pg0KPj4gU28geWVzLCBzdGFydGlu ZyBzb21lIG5ldyBjbGVhbihlcikgaW50ZXJmYWNlIGZyb20gaHlwZXJjYWxsIDY0IGlzIHRo ZQ0KPj4gcGxhbiwgYnV0IGl0IHZlcnkgbXVjaCBkb2VzIG5vdCB3YW50IHRvIGJlIGEgc2lt cGxlIG1pcnJvciBvZiB0aGUNCj4+IGV4aXN0aW5nIDAtNjMgd2l0aCBhIGRpZmZlcmluZyBj YWxsaW5nIGNvbnZlbnRpb24uDQo+IA0KPiBBbGwgb2YgdGhlc2UgbG9vayBsaWtlIG9ydGhv Z29uYWwgcHJvYmxlbXMgdG8gbWUuIFRoYXQncyBsaWtlbHkgYWxsDQo+IHJlbGV2YW50IGZv ciwgYXMgSSB0aGluayB5b3UndmUgYmVlbiBjYWxsaW5nIGl0LCBBQkkgdjIsIGJ1dCBzaG91 bGRuJ3QNCj4gaGluZGVyIG91ciBzd2l0Y2hpbmcgdG8gYSBwaHlzaWNhbCBhZGRyZXNzIGJh c2VkIGh5cGVyY2FsbCBtb2RlbC4NCj4gT3RoZXJ3aXNlIEknbSBhZnJhaWQgd2UnbGwgbmV2 ZXIgbWFrZSBhbnkgcHJvZ3Jlc3MgaW4gdGhhdCBkaXJlY3Rpb24uDQoNCldoYXQgYWJvdXQg YW4gYWx0ZXJuYXRpdmUgbW9kZWwgYWxsb3dpbmcgdG8gdXNlIG1vc3Qgb2YgdGhlIGN1cnJl bnQNCmh5cGVyY2FsbHMgdW5tb2RpZmllZD8NCg0KV2UgY291bGQgYWRkIGEgbmV3IGh5cGVy Y2FsbCBmb3IgcmVnaXN0ZXJpbmcgaHlwZXJjYWxsIGJ1ZmZlcnMgdmlhDQp2aXJ0dWFsIGFk ZHJlc3MsIHBoeXNpY2FsIGFkZHJlc3MsIGFuZCBzaXplIG9mIHRoZSBidWZmZXJzIChraW5k IG9mIGENCnNvZnR3YXJlIFRMQikuIFRoZSBidWZmZXIgdGFibGUgd291bGQgd2FudCB0byBi ZSBwaHlzaWNhbGx5IGFkZHJlc3NlZA0KYnkgdGhlIGh5cGVyY2FsbCwgb2YgY291cnNlLg0K DQpJdCBtaWdodCBiZSBpbnRlcmVzdGluZyB0byBoYXZlIHRoaXMgdGFibGUgcGVyIHZjcHUg KGl0IHNob3VsZCBiZQ0KYWxsb3dlZCB0byB1c2UgdGhlIHNhbWUgdGFibGUgZm9yIG11bHRp cGxlIHZjcHVzKSBpbiBvcmRlciB0byBzcGVlZA0KdXAgZmluZGluZyB0cmFuc2xhdGlvbiBl bnRyaWVzIG9mIHBlcmNwdSBidWZmZXJzLg0KDQpBbnkgaHlwZXJjYWxsIGJ1ZmZlciBiZWlu ZyBhZGRyZXNzZWQgdmlydHVhbGx5IGNvdWxkIGZpcnN0IHRyaWVkIHRvDQpiZSBmb3VuZCB2 aWEgdGhlIFNXLVRMQi4gVGhpcyB3b3VsZG4ndCByZXF1aXJlIGFueSBjaGFuZ2VzIGZvciBt b3N0DQpvZiB0aGUgaHlwZXJjYWxsIGludGVyZmFjZXMuIE9ubHkgc3BlY2lhbCBjYXNlcyB3 aXRoIHZlcnkgbGFyZ2UgYnVmZmVycw0KbWlnaHQgbmVlZCBpbmRpcmVjdCB2YXJpYW50cyAo bGlrZSBKYW4gc2FpZDogdmlhIEdGTiBsaXN0cywgd2hpY2ggY291bGQNCmJlIHBhc3NlZCBp biByZWdpc3RlcmVkIGJ1ZmZlcnMpLg0KDQpFbmNyeXB0ZWQgZ3Vlc3RzIHdvdWxkIHByb2Jh Ymx5IHdhbnQgdG8gdXNlIHN0YXRpYyBwZXJjcHUgYnVmZmVycyBpbg0Kb3JkZXIgdG8gYXZv aWQgc3dpdGNoaW5nIHRoZSBlbmNyeXB0aW9uIHN0YXRlIG9mIHRoZSBidWZmZXJzIGFsbCB0 aGUNCnRpbWUuDQoNCkFuIHVuZW5jcnlwdGVkIFBWSC9IVk0gZG9tYWluIChlLmcuIFBWSCBk b20wKSBjb3VsZCBqdXN0IGRlZmluZSBvbmUNCmdpYW50IGJ1ZmZlciB3aXRoIHRoZSBkb21h aW4ncyBtZW1vcnkgc2l6ZSB2aWEgdGhlIHBoeXNpY2FsIG1lbW9yeQ0KbWFwcGluZyBvZiB0 aGUga2VybmVsLiBBbGwga21hbGxvYygpIGFkZHJlc3NlcyB3b3VsZCBiZSBpbiB0aGF0IHJl Z2lvbi4NCg0KQSBidWZmZXIgYWRkcmVzcyBub3QgZm91bmQgd291bGQgbmVlZCB0byBiZSB0 cmFuc2xhdGVkIGxpa2UgdG9kYXkgKGFuZA0KZmFpbCBmb3IgYW4gZW5jcnlwdGVkIGd1ZXN0 KS4NCg0KVGhvdWdodHM/DQoNCg0KSnVlcmdlbg0K --------------MnthlwNHWJdKVHE8KnRxNbHZ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------MnthlwNHWJdKVHE8KnRxNbHZ-- --------------P9mk0xTRkupVqoBidzI5Fgiy-- --------------YwmfFyl4MUWyXfocPzr4f48i Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM0RhwFAwAAAAAACgkQsN6d1ii/Ey+O 7wgAm8rH8XEEXow2ZOoAn94Js5TD73/z86wzRgzERe3ZCh9VvIR/Zp25p9bxl/OXld2tE0niNxa2 2ClNz1gGKE5j50UvD+skX4dTJel94cf8lJjOU3Kvm54pStmpT+VBOFfbbREqZD/04KoaFAwxgBy4 PtmNitPvKHTlXbBOTmXR/t0R+es8ZNnQoIhg1CsWbFcbb6ssfXVcWogGmIT4LwCEozbVv+Sf+JTk h8RRnBbXjj6wlb8tiOZL7kF+QMZB7kbinEsuztFNssW3MO6TCiHpZWITmohtR3DemqfryHsyUguZ 0CtW8IHXf2PbfHobqFPaJSlePfzba7GN9lj/8bM+kQ== =DbDR -----END PGP SIGNATURE----- --------------YwmfFyl4MUWyXfocPzr4f48i-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 13:08:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 13:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413319.656889 (Exim 4.92) (envelope-from ) id 1odWnl-0007Yb-2n; Wed, 28 Sep 2022 13:08:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413319.656889; Wed, 28 Sep 2022 13:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWnk-0007YU-UJ; Wed, 28 Sep 2022 13:08:36 +0000 Received: by outflank-mailman (input) for mailman id 413319; Wed, 28 Sep 2022 13:08:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWnj-0007YO-HT for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 13:08:35 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a65465f8-3f2e-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 15:08:33 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 09:08:29 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6482.namprd03.prod.outlook.com (2603:10b6:806:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 28 Sep 2022 13:08:21 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 13:08:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a65465f8-3f2e-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664370513; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=yPue7MoHtuj4RnLri1qlYwvWuqASZnyCotzIq0EyxII=; b=IFG9rClorRLpVZuzfQud7LW1mOSC4yF7p0wSvZYpgOMgpKXnRlK9GXjF dhGMpxY62TEKYJD6MMSzFC9de28vrtH0oRfUybAAEGa3j0aGwFFC7gPLF ciB7b4NQLTW/lmDWygw1hdIUFU3Ou22rq/KqHbnoP/Lp955ohsv83897o A=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 81534767 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AgnfAJ6J1mq5mluClFE//H55yizrwRhNe6xJEq?= =?us-ascii?q?0mlI8zMhWaLcFgCq1vmr1WN6+me0dt6G1viODzi/gQ2b3GK4eXApYjr9+/G8?= =?us-ascii?q?2rW+Uh+sC6+4jgM0ttUXVURwgi6rQZdoTcpjBtTm4Z3jpVI8Dr3+gngZLHEV?= =?us-ascii?q?g136bVcLm94ZFX6hYiPK4ET/Pvuxfv5WERFhE4p2s9bYJAgK2oo1u2yXsWqF?= =?us-ascii?q?vTCDWd4MJICsrUJX9GRuM12EQBcQ9EOn3lmaLza3ehSn492JSvZetB8z++B+?= =?us-ascii?q?tsc3Q2cnMYTj8IWyMnkhSEQ+RR47xGJ7KP3LX9GrS4XCvqFqBHWzUocCajmQ?= =?us-ascii?q?GKtA/1wIbJwK9RqD2vxNp/Wnwc5DdwBPJtP/HScPF3bp95FQCsAqJXTXsdNz?= =?us-ascii?q?r7/MdMGCvyCySOewB8kycWTkpN2DKhx3HckaHqELGIoEfKWHj9zHBain06Yd?= =?us-ascii?q?/T/h0CGpwtzA0Wzrudq1G4vqe82/XVXziVKtdIdXgx0OUg/lSkSXQX1qdQ52?= =?us-ascii?q?Z9NPjuUKZjdi8MKEiCjc6DWv+pZZXX7hebBpoZ+DD76+2ktit15aV5xluesq?= =?us-ascii?q?9YtbDhujJ5ooimcLqpkCavskXpSAD4D92376AuURhascFauKoSj+XLhXrixr?= =?us-ascii?q?V3MFvPUjn+A8RAk44U3cTqX0yKsy+DzvQEkKSJnPAFEQ74xP0RvY8nhFmJQf?= =?us-ascii?q?0oWbLqfXvQJHGc1ivMyBcyJ2zSxZn4xVvvLfDmibLUa9xlJdMt2sMFVEf1I+?= =?us-ascii?q?X+wrLRw1STGedFULe+iGE8Eii+FxT68gnQ/cxHN3CNmtGCO7/0ReI1zzHbPC?= =?us-ascii?q?/rRMYKtt9kwC9tH/mN5K9Yd0wzBebuZhv/RJm28ycav0DNnGlLNxo4xacgF4?= =?us-ascii?q?oHzI9QCIbp06Vub7CLXlPZj5fdjePOJ3enTbayY7oi0hLTCcM/Gr/Y58qaPn?= =?us-ascii?q?PGhLXM2B9YdF9jzrbKSd6EqLqzEoKUuo8Lh9r0ddRUIP+GWxye1hjaYpfRwL?= =?us-ascii?q?GUFGbbinx3RlGmcWLmwHDR88p1U1Y8kXklSVLGdpu7Q/mNVvt4jH98at5DKE?= =?us-ascii?q?bHAVFhsPi5sfNf6s/i6mJHIfKXFPAK/WO45SqFSp48ch0+H8++9dYIQiZ8iT?= =?us-ascii?q?1LOa159FLzsOOMZBfgE9vSpI+oGPMlnqL8ko/fP2EA3MByOuO3FOCiXY1+pv?= =?us-ascii?q?SxyBmEPM2PM6kXpZGcr7ZAU4C7URf4McLvfVtBoEBaccpEGiUQdzyWK23LPH?= =?us-ascii?q?9MuiLDFcBJo8CWt7KfSrNdRFzyU2zIx1qeJu2uxDts4qUn/WkzhHHIE+N1A+?= =?us-ascii?q?bReJXA18uw8RLoT4kirXVpgAY+SA+Jdr4KvyGZkCNQ9LZiMVppigPmfBJ2la?= =?us-ascii?q?H/Vqh9Ex88M2pGhzzzfnIKtumf1kA1vIPAQ6kixaHJL0xq+yKk+Gem6sJkdf?= =?us-ascii?q?1ACKyVCQTsqy5lKBBFyNE702heH+K7EZbxarMsfvabLSbH8SnTc5S8ZHIvWn?= =?us-ascii?q?3sfgtMZFBHA8G2NORZh6VEZI7YNf8LT+im9a46AFq9UtuTd7ZJdrQh7EWwxp?= =?us-ascii?q?LrbbvBe2VoPVM7XCGfuYJmQULaPpnHJ7/qYAUVJzHzqJbHTlXGhc/x/ukDpJ?= =?us-ascii?q?O7pzfJtq0CItbiG7H0U/TPI2n/8lgPkDMGoZ49GzdWJlkGFBn7K8m6RpQ659?= =?us-ascii?q?ug0lHv+KgDEMycw+9b7udPY0Yy6DkHwhQrRZc+eKawq4UUwQSsNogF+fF0zF?= =?us-ascii?q?9dYfT2LFDC7KMc6xqHeNyqPVFNI1IWCL0wWCN1RS3wDI/qTnXIqbYqCSI7S3?= =?us-ascii?q?99IdlKX09IMISQlAVn4ia2WW1ivOZFztXyWZSVNJYpTkvFTnnWkMjWzDQ/xK?= =?us-ascii?q?jy6MA62e/WhyUiXJEJobKc+PchyEOC4wCpCnZ4+qsq8Vz0U9/Hz9WlBBrVsh?= =?us-ascii?q?HZCu2Vmcr8i/LBLLaL6vUQ/Bur+lmcZGkWt8Q8NUjB32XqRCrjGsAuh2z1+W?= =?us-ascii?q?KUg8HS5tk/M9SvcjHv+mTgXPKMZ2EgeZVY7KxmG4RUW5KhlAu2Vp7XDjHp51?= =?us-ascii?q?l9tXH1CFuoictB0n7woAfKJ9oPHN3X6vtojHbyQLCYCko2yDauH0RX50/AEm?= =?us-ascii?q?HB0vJ2bUpB15Svfkd8oAVCyA2Kf3l3/L8KKk1+AH1iF1iICMLKuaFW8u1DsN?= =?us-ascii?q?lr2QOGRJAW9C5c6GomjWfxSgkCWgZSFBDMG86nHezB4ew+8aqyc2YElUoEU3?= =?us-ascii?q?kaidMMeFceqMlSIpA9W/34Pmf9ex1vQ0eBW8FbPNqyZVQNrW61DOyzjjnlLq?= =?us-ascii?q?2Ya46/4311SZOJys8tqbaAd5sVZDRBoqJXKaEHl/Q7fmurdb6RbIZqYqMOej?= =?us-ascii?q?oL1nGsqr6B968J6KpqnENVsOg8SUpza7bUVaaBke4TfLFluLMDO3+ZZoj2Wo?= =?us-ascii?q?/DBSYO6K7LKLe6tOKNrSEHNhicq3MOLmKuuMmH0FYUcflrC3fiklk5dvBagH?= =?us-ascii?q?/3YrW9+mt2AjQb2QXubfVF+f23K+snr/AQshRnrI3+p23pm6eXEH/b/0dykW?= =?us-ascii?q?j9ub1CAOieCFmVQgBKTjtvKMmi/nfrE5UCXtxyrTYimTMkj9Y4yzRCM6rU+1?= =?us-ascii?q?CtRb0NcQKDmKoE0vB2CR8NDXX8wGfdsVJW9xE+SpkWKzh1wIcB3V6JyEYsNe?= =?us-ascii?q?UbtxvFi++HdxzlwD4Dtksg/mDOmwCE+NHiFkr/QgREIKx3eiZarFPQoniBDW?= =?us-ascii?q?PD4LmJuY76ProlbXMFG/8wvJhbGi/I1psx2uHDo76wVC10bsWUDRECX5fxLC?= =?us-ascii?q?UaFwgUYdyh3+S+s5GY=3D?= X-IronPort-AV: E=Sophos;i="5.93,352,1654574400"; d="scan'208";a="81534767" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WashV8N5kFkR2+LeVTeP+5fSCuHxOmqLnSit78cqKJOBr1L1qEhokdcqIi9uU28BV44fna/7Dxoutf7qjgJN6dC4YyOthxAKlTaw1BBIzcvukFUz8svI7WsCpPFbxpvWh0sRYz5GBToOizPb1mIj0gIQ9lUNbz0oC07GW2xwQV2fdc/4z03JLKWRNyQ/1r8SbSzrOJ3BVjeHDefb1YDK0VLAYe9wSqOBro7cX9bkjxEfp1ma4MlIrNoGyVIDQGDthqQez/gtet4yVJa/7RdUGDVENCe5ezQ2KdrdEnU36+Rc+uFgR3MUooZqQDHLJiIqlYepE2MHy0NFTzQ//lTyFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6wCMjegadRp0pdZirD+3owx55y5HLmPaZcxTbkQAjdQ=; b=h3IH0j63Qf3FFRe62xWtHUc25MaDrUSlqKZZdUspUsRgqkmwzXeITdRqe69CYd8fNNeSIu++G4ge6qZJsr/jjt9OKN6neemBiNWy++Tri3pm/jnj/WbHYWVxbNyaLSAVue/YCuQJVmO4tWFJdscImIVoLzPGUuzMpBEGdoUXzL5yzSgSsTnfGU4hybM1dpmEouu+D3kkQuVBBnNuQTvCfxX9oCRnq2868mYNoF1y9ZFeCps2p4ipKcPIQLaaYcCmMXhpvz+am8lw5WvUISf4HrY0imFPr8AaLhLPzFs62PwlaLqwVFpxoY6B8uYc3lNO2QBFEX6icugSoaiyd59lpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wCMjegadRp0pdZirD+3owx55y5HLmPaZcxTbkQAjdQ=; b=iiX5wtuYJ2w6O3rOIuhDagyVtxYmmbH0czqiOCTMvcaxXLwnsoEW5UpTDuhzEKBlrk+N6oTDIDsUgEah0QFwvj7Oo1SNX32kNu42ggDK5SVbNVx1EoYMbHyeKW5448aQZg7e4vDejAtyk4u0aPom7drGIx40BKE81yeRIzCnaIs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 28 Sep 2022 15:08:16 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] x86/ept: limit calls to memory_type_changed() Message-ID: References: <20220927153937.39389-1-roger.pau@citrix.com> <357195b5-bfb5-7f0d-8295-3076a6762f12@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <357195b5-bfb5-7f0d-8295-3076a6762f12@suse.com> X-ClientProxiedBy: LO4P123CA0210.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6482:EE_ X-MS-Office365-Filtering-Correlation-Id: e7d8ac30-d241-40bb-7986-08daa152846f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q/AOo7sQtyqV+3wZhirPIbsrZ8SarL6fSsnMqcoyyzuaphdBm9W5uHMD+Vf3JN3gv9R7rG6OcLZ+GbqCJDPeAeCa6m+bo1nQmz+QFwhkf2KfcdnqXAsXbIXf0YsQl63eBjXuCXdjxTr7AOrZp1PhLtJZKq//rDP0PQJ5+nQ6A+M+PzcANEf7AGtwX0ctuNIF1oolCAuvx0ywAkXdNHjQjJNjGOtnbLSpr47umwIRIk0zqXzyJ/VtFyeiUI6Zmx30oyP4r4AzyOuXlVSgWcyOXvZu510xQDcIeuR2bvPCCJEHRdEM7N5pRpZvhP59xQ5eq5YvFwTF8YAynSd8cKsPUFEJvBHLIZBdGv4KzsY4tkWe3HfzkOfbbb4LXWcdY3M3ql8JtjU/dAacNrVBF3Rtm3pQilVNeqX6VGfVVMITiNK90dajJZ1Iy2+V7QVZcIE8t5V4oNXOhOXnvd6alEPb1Df20pyH69PW/gUKved7L/yvVSogzM3pzqi4n6srBH4bpB0Dy2StBKhJ9nTNYYsmilPNpw3BIpy//USO9uMQ9tr71BqQ6H2RbYJl0URJPjpgesLqCL5jJM2h1ytneXsfnPKrWkhv0KAKKhvpMxLetDEXdPIk4Dx3k5iTu9s6adJIBAHBL+a+5+qt1txuwipajyuYXxCqsG6XIbzgCrymiYMkW84qvCoHoMnUia61sJBr0lQAvRDz5LX4H+3Pu7AQ9g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199015)(6506007)(53546011)(478600001)(83380400001)(6666004)(9686003)(6486002)(41300700001)(186003)(6512007)(5660300002)(26005)(8936002)(2906002)(6916009)(54906003)(66556008)(66476007)(66946007)(8676002)(316002)(4326008)(82960400001)(38100700002)(86362001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEtudUF1Um11UDE2UkJhcjByQTFvWjlLckhFZGdHNWo2T291UE9ZR1RyQXdM?= =?utf-8?B?QTFqOWdsRmEwTVlNLzZPalZteVphV1dQUjZXQkVqbEYxOHB6Yit6YUgwb1VR?= =?utf-8?B?c3ozUkNONTk5U2RyZnR0ZFFKMHpwbFpoWlljZS9TeFlBNFFXS0s5Tm9ONVlR?= =?utf-8?B?WXhZaStQWWIyR3huQUQxaGhReWFhRDVxT3VJL0d3VXFoblIrVVFvKzkvU0s1?= =?utf-8?B?WURxRXFHSmlCQjBpdzh6cTRZTEUzdEJUQlFFRTRrS0NxTEZSam1NQWptOThD?= =?utf-8?B?V3NNR043YTlBUjdZQ0FHTE1yanpobWtMdDAxa21JMlQ5WlNaVDRkb1NrYnVX?= =?utf-8?B?TjgxY3RNME5yK2tMMk1LeEdIek9OdUxCbHhtTlhXNm9xQjUyOEdKQ1ZIVitq?= =?utf-8?B?OUoyNWdaamsvOTZWMXk5M3NjV0xERGNGUW1KQ013NzZzb3IzSmxUcGM1d3g4?= =?utf-8?B?Q1ljVmhCSjFhMlpVbDRxMlhxa1MwNHhOMDRoQXJQTWxvaitoNmpvNFRZM0hF?= =?utf-8?B?SFVKVGMvZUJuTGdEZXNXc0lpbW10RDVLUllOL3cwTFBzeW1CWmFrQnJxVkhX?= =?utf-8?B?dnh1TmFYRGJNYkZndmtrRDJsWnJxK1lXalVabFBtTU50ZlFkRk1IQXQyd2wx?= =?utf-8?B?Q0VYVXlxOUtMZW1XM2FnanNNUG0vejhrUkk1V2MrczFXRlhrbjlUQnJGa1JQ?= =?utf-8?B?eDhZSUpVNy80NXQ1clNOVU1UVnBmMmgvYjcxWWJmR3Y4VFNhUXVpNVFHRXd6?= =?utf-8?B?T255WTRZU0R3bGU3dHB1OEhIUnRuK2EyRVB6dzJ4V2hMZ0M1THlKaEowV3Vi?= =?utf-8?B?LytkeWxXRFA0Tm80Y29tSXRBdDlqUnJTMmU5WGVEMlEvSzFvNlVUTFZSd00x?= =?utf-8?B?T0pwb0UzOHcxZ2xmL1ZoTjIxSHUyNU4ybERSSlZGQVdCVG5uTmZQbTdqbkFn?= =?utf-8?B?dXFCZXRuWm5VWGpoazV0ZGJNRERTMDZldDI4M0lLVmdSV3E5VG1pQ2k5WHE2?= =?utf-8?B?d2RUVFlucmdTY2EvakR6eVpDWGtDU3RYTXNHcnZBazRPYUFHSHp5VmNhaXhm?= =?utf-8?B?dHczOG05OWpiMXlMVEU4R1EvVWozeHI2OEtOb0NFdGp1SDdXN1djWExkYjRi?= =?utf-8?B?YzdkcXZKVUJjbU9RK1BzVCtsYXpCbUZ2RXpsYkpRRzFpd00yeXQwOGdUc2R6?= =?utf-8?B?YjFEb1NLWHF2aGRNc21xVVlST0VpMlRNTUFuUW1ycDBxODhaRk1uV0xnR2Z5?= =?utf-8?B?cTd1cmhhdkhrRHhkb01YcW94WlBqRkkzM3Q5Yjd3VHNIcjFUZnNqaGp4NlMv?= =?utf-8?B?Mm1BNzRYZkZ3SUtQRUM3U3lZbnB2enJTaVlVeVkweDUwb1FiU2Y1c0RLenlx?= =?utf-8?B?b0JuL0dzVXc0N2lMN05LcE4wUTErQUduZVlDRi9EMDJzUTlNMHFKNytUd1Nv?= =?utf-8?B?Vjd0cFhwaEx1UWhFbXgyU2JiajF1SzA2V1RMSmMvM25obzNiZDlDa2t4SWR6?= =?utf-8?B?SncwLzJ4WEF4ZkRjVVVNMDhXZ25qQmtWS2hOY25McDIxVlZja2J1dE95OWxi?= =?utf-8?B?eE1FME05STByNUhrc3hnTmQ2ZWxjYVdwTG15UjI0cHZpT2lHUzc1ZkFKSlJO?= =?utf-8?B?R2g5dGk5V3UvMDYxZWdER2s0d3FmOWZNSVlWUmJlZ3p0OWlmUkpVNG1wc1ZI?= =?utf-8?B?eHhzdGJzblZlVS9hSWhzd0oybkZrOEhyS0ZFOXc2QTFHd3c1bVZoTWZ4bG9T?= =?utf-8?B?RUxkRGNJZmRLd2x5UDA5ZE5yQjhsaUpLMkNwNW5LamhFQStsaTJWUTRuZkJs?= =?utf-8?B?dndpOEJGUGtTb3R3QmNFdlVMYjljZmxiaHdFL2tMby9jSWhtNTV6NHNnL2lS?= =?utf-8?B?bEtRSDRXVkRQTmhDekRqbHFGSm81ajJkZ0VzQlNvVHpaYU5ucHppSlJnWmJT?= =?utf-8?B?Uy9FenN2eml3ZXBQaW5wbDJ0TmRDSVpPeEFyKytpaWNxNWV0bHNTVDFuRmdX?= =?utf-8?B?S04vRDNXd2ZJTFJGNEV3WnhmKzAzQVptRlVGSWxrbUsweVJXWWZYcVBVUHdZ?= =?utf-8?B?UTZBZG43TFVFQTgyTjdEZzBIVWxQVkRJYjQ3V0pwUFhsY0ttV2xDQVZ2clFl?= =?utf-8?B?UHFjbGVTN3hoSkpBMG9aSTcvMFhoaExOWFRrTUllaUxaUDVoT3JOcGhTTWV3?= =?utf-8?B?RWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7d8ac30-d241-40bb-7986-08daa152846f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 13:08:21.1227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G1MPhAJthzEk+VSkuEcyFo7uQBuccHLV0C4injCX4W9309QJJro5zjSSgNFV5JXIgDKCYf78KSMS010pIRcP0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6482 On Wed, Sep 28, 2022 at 12:45:13PM +0200, Jan Beulich wrote: > On 28.09.2022 12:08, Roger Pau Monné wrote: > > On Wed, Sep 28, 2022 at 10:01:26AM +0200, Jan Beulich wrote: > >> On 27.09.2022 17:39, Roger Pau Monne wrote: > >>> memory_type_changed() is currently only implemented for Intel EPT, and > >>> results in the invalidation of EMT attributes on all the entries in > >>> the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > >>> when the guest tries to access any gfns for the first time, which > >>> results in the recalculation of the EMT for the accessed page. The > >>> vmexit and the recalculations are expensive, and as such should be > >>> avoided when possible. > >>> > >>> Remove the call to memory_type_changed() from > >>> XEN_DOMCTL_memory_mapping: there are no modifications of the > >>> iomem_caps ranges anymore that could alter the return of > >>> cache_flush_permitted() from that domctl. > >>> > >>> Encapsulate calls to memory_type_changed() resulting from changes to > >>> the domain iomem_caps or ioport_caps ranges in the helpers themselves > >>> (io{ports,mem}_{permit,deny}_access()), and add a note in > >>> epte_get_entry_emt() to remind that changes to the logic there likely > >>> need to be propagaed to the IO capabilities helpers. > >>> > >>> Note changes to the IO ports or memory ranges are not very common > >>> during guest runtime, but Citrix Hypervisor has an use case for them > >>> related to device passthrough. > >>> > >>> Some Arm callers (implementations of the iomem_deny_access function > >>> pointer field in gic_hw_operations struct) pass a const domain pointer > >>> to iomem_deny_access(), which is questionable. It works because > >>> the rangeset is allocated separately from the domain struct, but > >>> conceptually seems wrong to me, as passing a const pointer would imply > >>> no changes to the domain data, and denying iomem accesses does change > >>> the domain data. Fix this by removing the const attribute from the > >>> affected functions and call chain. > >> > >> Personally I think this adjustment would better be a separate, prereq > >> change. > > > > Right - I was about to split it but didn't want to go through the > > hassle if the approach didn't end up being well received. > > > > Do you think placing the calls to memory_type_changed() inside the > > {permit,deny}_,access is acceptable? > > Well, as said before - it's not pretty, but the existence of > memory_type_changed() itself isn't either, nor are the present > placements of calls to it. So yes, I view this as acceptable. > > >>> --- a/xen/include/xen/iocap.h > >>> +++ b/xen/include/xen/iocap.h > >>> @@ -7,13 +7,43 @@ > >>> #ifndef __XEN_IOCAP_H__ > >>> #define __XEN_IOCAP_H__ > >>> > >>> +#include > >>> #include > >>> #include > >>> +#include > >> > >> That's heavy dependencies you're adding. I wonder if the functions > >> wouldn't better become out-of-line ones (but see also below). I would expect most callers to already have those dependencies TBH, and in any case definitions there not used would be dropped anyway. Or are you worried about the newly added dependencies causing a circular dependency issue in the future? > >>> +static inline int iomem_permit_access(struct domain *d, unsigned long s, > >>> + unsigned long e) > >>> +{ > >>> + bool flush = cache_flush_permitted(d); > >>> + int ret = rangeset_add_range(d->iomem_caps, s, e); > >>> + > >>> + if ( !ret && !is_iommu_enabled(d) && !flush ) > >>> + /* > >>> + * Only flush if the range(s) are empty before this addition and > >>> + * IOMMU is not enabled for the domain, otherwise it makes no > >>> + * difference for effective cache attribute calculation purposes. > >>> + */ > >>> + memory_type_changed(d); > >>> + > >>> + return ret; > >>> +} > >>> +static inline int iomem_deny_access(struct domain *d, unsigned long s, > >>> + unsigned long e) > >>> +{ > >>> + int ret = rangeset_remove_range(d->iomem_caps, s, e); > >>> + > >>> + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) > >>> + /* > >>> + * Only flush if the range(s) are empty after this removal and > >>> + * IOMMU is not enabled for the domain, otherwise it makes no > >>> + * difference for effective cache attribute calculation purposes. > >>> + */ > >>> + memory_type_changed(d); > >>> + > >>> + return ret; > >>> +} > >> > >> I'm surprised Arm's memory_type_changed() is an empty out-of-line function. > >> This means the compiler can't eliminate this code (except when using LTO). > >> But then cache_flush_permitted() (resolving to rangeset_is_empty()) can't > >> be eliminated either, even if memory_type_changed() was. While gcc doc > >> doesn't explicitly say that it may help (the talk about repeated invocations > >> only), I wonder whether we shouldn't mark rangeset_is_empty() pure. In a > >> reduced example that does help (once memory_type_changed() is also an > >> inline function) with gcc12 - no call to rangeset_is_empty() remains. > > > > Can look into it, do you want it to be a prereq of this patch? > > Well, if done, then it being a prereq would seem desirable. But x86 isn't > affected by this, so I'd leave the "whether" aspect to be judged by Arm folks. OK, let me split and prepare a new version then. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 28 13:11:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 13:11:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413326.656900 (Exim 4.92) (envelope-from ) id 1odWqW-0000Zp-JB; Wed, 28 Sep 2022 13:11:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413326.656900; Wed, 28 Sep 2022 13:11:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWqW-0000Zi-Fs; Wed, 28 Sep 2022 13:11:28 +0000 Received: by outflank-mailman (input) for mailman id 413326; Wed, 28 Sep 2022 13:11:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWqV-0000ZY-Dl; Wed, 28 Sep 2022 13:11:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWqV-0006Tm-BC; Wed, 28 Sep 2022 13:11:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWqU-0001Nm-Oz; Wed, 28 Sep 2022 13:11:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odWqU-0006fC-OX; Wed, 28 Sep 2022 13:11:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KXvZldgzhK4hT+cQmeMY4LdtXIcHUBYhJ3I6oXJ7/Q4=; b=5r/MxUl7IJC3XNLeu3pEbsnz/8 Atk7F8jpN2fUb2xL+46T8ASgtHsurjDq/vcvxJG+avOtxFHR1MSGu1uogot5zxbHJbXdoK/11Uwmx Z+AiB6YdaCfL4BBz6aEP5zU1w1E3eHnWorCXP1n7ISTabOYxeeXoAdWebyrc6ma5XsUw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173345: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=8ead926cb46f1892116cb56aa89390d194ce0b71 X-Osstest-Versions-That: libvirt=fa2a7f888c1466f2cbd6b349540c5ad5e1d54a04 From: osstest service owner Date: Wed, 28 Sep 2022 13:11:26 +0000 flight 173345 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173345/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173325 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173325 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173325 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: libvirt 8ead926cb46f1892116cb56aa89390d194ce0b71 baseline version: libvirt fa2a7f888c1466f2cbd6b349540c5ad5e1d54a04 Last test of basis 173325 2022-09-27 04:20:15 Z 1 days Testing same since 173345 2022-09-28 04:20:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Fedora Weblate Translation Jiri Denemark lu zhipeng Weblate jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git fa2a7f888c..8ead926cb4 8ead926cb46f1892116cb56aa89390d194ce0b71 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Sep 28 13:15:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 13:15:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413335.656911 (Exim 4.92) (envelope-from ) id 1odWul-0001IC-5D; Wed, 28 Sep 2022 13:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413335.656911; Wed, 28 Sep 2022 13:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWul-0001I5-1v; Wed, 28 Sep 2022 13:15:51 +0000 Received: by outflank-mailman (input) for mailman id 413335; Wed, 28 Sep 2022 13:15:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odWuj-0001HE-T8 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 13:15:50 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80080.outbound.protection.outlook.com [40.107.8.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab0335f1-3f2f-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 15:15:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7084.eurprd04.prod.outlook.com (2603:10a6:10:12e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 13:15:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 13:15:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab0335f1-3f2f-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0GFl4VqZr7DfmBRjBwzB6+L71p/hd/KnwKIoHGHWbdiWCvk4khyPekg7nLcvXUdvMDPx1bSkGHCVV9ojR7qlSGMaBqbPs3D2H1jrimy7TzMc4ueuGTYRq/R7DLinKNuMs9NvU1xZJuXXKB/PJaQS1pWU01m8fWk5E8m8XahduErUV5h36h3Xfr1eaDaPhQbYiX2xX8JJoCrX10CQPAEhoPGYkoQoIxkjnHE7WqtDc7IRM9Vk752cuh0+Wg1DN1ScIyD18JnkK3JIoCH+TsLTECgX/vaxPsGSHh6CMxpsYhFJtSmmUe0QeSiU4cOlwgtbHtnsFNT40XBobLUJUwOAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AZ9fy1MLmK7l6yRaSi2cGiNMcgrW14jSAOoPB9Z719M=; b=ItcdoAH1Ff78Z/TAc8tRk/WB+he4Kr1/vMFyapZARnKLTYa9lxvXM/DS5aFwIxgUMH784MTae59iyBpM77FoqRrwdOXqisOTqT6wBk9Dm2EIEwsOTn7Om9VI73hrMXtrUnYSOJosOU6HOLtH7CybET5bEFWaJoFWkSwBj0Wcr9XHz/cPXnsaowJrLKBNI6D2LdTBWCoxUVLO36oNzGrsZmZqlLGHS8jyRCgpJuDRZDuKCrlK6K2BDzh7Y2xtPIPDay6xBwrs+eRpDexzv78UxNo1BApv6zKtBNXipzxOb8hOADrHFoqRaXlfKvjCTvOsfDEb8BHNLw2F3pYJ7tROMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AZ9fy1MLmK7l6yRaSi2cGiNMcgrW14jSAOoPB9Z719M=; b=s3n5EEgE9zGOmY3I89WS9R0c3va6xeLzuJ8rWPDhwqsKab3cng7gu5ub+k886eQtZX/CmjvbSAP1z/nY9i2EwMOMZ6diJ16KmzQk+hMY0pTBJdj9PQkHn5ozt99GSVo2HfBrNOaIJhpDOYgClquzq0qFxsbYMFx/7JMf/5X1v+vQR1H/IK9FaL542KT/q6HN7t2945DHAU6Z2MXXio+vgH9yLLL9uLUYgclIvEQkjMknXH0J4VWzG7S4b8OWrISKrgkM3grpY5zFJ8S1BblW/EcD0jj5N44EhNdwwcnIcSBUcHYUlnFSkc1s4gpGf3hcC1WJNJ9cgvjRVGk00SrINQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 28 Sep 2022 15:15:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20220927153937.39389-1-roger.pau@citrix.com> <357195b5-bfb5-7f0d-8295-3076a6762f12@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0511.eurprd06.prod.outlook.com (2603:10a6:20b:49d::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7084:EE_ X-MS-Office365-Filtering-Correlation-Id: ba2f9c77-b702-45c3-255c-08daa1538e58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yScfhCg1I0pyx0OTL7H4L9TeMs9uUn4o09RabD315CykHk/m1Ev0Q/Sv0ZgmiKLhsdHq/MbommfWYA2ui9SxKXwaTvS9kBskjBmSr/nELQLN56BGQwxVatPUZjhCRkY9FE0KoyTDTBxoCdad46WUJx9+KtRoEDTC/fdEN1swlmld1tTpza5YazA+uzZWEch1e0lmKmt1+/BIfEWRwcvG1UClrYcT9RkSq2Z7ZhLPtAklygMno8K99TCmY1p3aIYqegsfvankUxHRzVOP8I+WMNqZXoDpnE9pd+CgRqWNS1hsoRDzDP/fpctoigT2gPDF7tZbuyqF9YWKgmbgQHiqjxqFHS+94MOTxIocSsA/ucJZFCfRWQrQh2wVKYwDiNJQwskRmMRAJ+ggzJ6+9Pvk0MiyrHOA7hd0drjzCNftzNzkXi3qnDvr60FqF9qBR63ANzApQTyoFsubDt9+jDw4AHv9ObMYw/L5LC4X35K+Q8aKFpxbeO7ULX/N+70iEpjKZPyJvCjuN49pgmPfHogmUdqqaEXYAwKPxwK3GpHDsGeAqLgWfZ68O8UbfDUiq6Ie3pcZX9sNNz7M6cxjyerTD8nOpjYk/xx7PHHEUz6hQTxFPp5mJj9R/UVuHJ1EGlk/ynGDj3efqotzIiKNY9ICiwPOgXyHrlWqirdV0ZwgJoz0JSNlHr15K4DeNM4eSC/zvH4lruZt3CnRd0r9CiKKhMbB44B+plswItGIPAUjw0EPRwWEvMxmeNOKQMMEsqE5hv/OA8K9HsOFmqpCKgP2q36sPDZw4t6t76H4m+0ct9Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199015)(31686004)(186003)(6506007)(41300700001)(26005)(2906002)(8936002)(38100700002)(2616005)(316002)(6486002)(7416002)(6512007)(66556008)(478600001)(36756003)(66476007)(8676002)(4326008)(53546011)(66946007)(5660300002)(6916009)(31696002)(54906003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDNLU3F1MGlpeXZrOTBMZU5wakoyMVRjbkV5ZWxUM1V3aFlCZFlPa2tUUVd6?= =?utf-8?B?aGNpUGxQQ1NYZU0vbjRqWENqLzU2dll5VUR2aGNveDFWSHR1d24vdFc4b2NH?= =?utf-8?B?UjZyWElQUytIaWY3QkorSStXaERNamFsSHp6VGh2Ui9kZVFNcDZUMGRtcndt?= =?utf-8?B?SHdwU0xDeDhBbW1RM004MjVKMHB2RHJWZUJjaFFzbm12YnZOM01ubjBkbWRI?= =?utf-8?B?NHNlR1FBVkhleHF1QjRqbnBPeTlucjdHQllOcHE0R3JVdWVNdEY1ZytQcmJ5?= =?utf-8?B?a21zK1VwanFRbmZ6M0NJRXlxV2owVHdJeGpITC83RU01WVhpUUQ4bHh0NW5v?= =?utf-8?B?ZWRjSjVqQythYkkzSHNuVzJEeE0xY3VmdWMvRkw0aEN2VEo5V0M5NlJNKzRZ?= =?utf-8?B?SmVXMWhZaUs3VDdjaEdLMGxFaHAwUU1sWE5JZVpqelByQU95VUp3RWdGYzdi?= =?utf-8?B?VFd6eXUwSHh2K1VyRStkdEphTWZTZnErcVhGbUZIL3hpRHkvZDVaWGcrSFZG?= =?utf-8?B?T2ZJaDQ5Tmk2WWpFUUw2WUtheG1yaXp4K3Z0VmFWMlg2N3ppTXpPRmx4V1I0?= =?utf-8?B?NnRaM0tMK2dNeUNsTVVUY082d2pMc003eTVyK2sxdmhkUEY5UmIvbmI4UStK?= =?utf-8?B?R1pDMmZ1QTZvd3VONGNQUlhIMDkwNUZvQXcwck1PckFaMmRrazd1dWI2ZUo3?= =?utf-8?B?VDczcUpieTBVcTVZV09RQmtWVEZYRjR5UWsyQVBPcjJpdmFvWkZOTmtrZE5k?= =?utf-8?B?NERQaUpIRzlZMXBBWHQ3RlgyUHJUUzQ0c3hsSW41aGttTkRVVTQrVDdnV3lS?= =?utf-8?B?K0lkdGJRd0M3T1dlTWtZWm9WNThaeEZzc3VtK1VPV2xydmhDb0xqTkJJZlJN?= =?utf-8?B?M3RHQzhva2oyYnp2T3ZXZ21oQTYzc095bXFaei80VSsram9xVXlkQ3hhd0J3?= =?utf-8?B?QjJndzVYRlBTR05qcjZWRTB5bGs5TkhDMzRmeU9SS1VHSDg2WFlLMWVEQ2Zk?= =?utf-8?B?VmdHWm9XYkxaV1hidDZMNHl2bTV2SnhDQ0FtZU8zaTlwbjZaRCtyTEUvOS9a?= =?utf-8?B?cXAyV3N3c1MvR0NGbFh4V0xUUldEU1BaallaWk52c1RRaGZ1QnJYZVdja05i?= =?utf-8?B?L2J3SnJqYzk1a0dMTTVOZVphWWxrVVV1ZElOeVhNRWVNdlMwc3FlM0pvZ3dr?= =?utf-8?B?WDFnWG9pdmlkSDRyRGlWM2xaam9aWlJFMUdnMDJxa2locEtYdDFRM202VDF6?= =?utf-8?B?MHhyMGRrUWluYzNuS1FtbUpLcHdWVElGTlN3TjJwcWFKWDlFOEp4L0ViMWMy?= =?utf-8?B?ay9GeUluWUVXZlhrdkpNWWlxdWlhcHFqYlVaaVowYmtnNGZGZ1IrRG9xVzl0?= =?utf-8?B?NEVrcURMYXJBajkxODU2eU1hVjEvNjlGV1V5YmFtUGlrTjJqNmhsWnFBUFAx?= =?utf-8?B?Zm9ROUxDVk9uR2xjNk5YQ0k0R2Y2UlRlM0huT0R4ajdzdldzRTN2aWJ0QmtL?= =?utf-8?B?d3FsTERuM0N4dGRNQzF6Y1NWcEpzMmhjTUhsZEFNOTdOT0ZvcS9Rbk96MWVS?= =?utf-8?B?MU16aDJHbHVuNERiRVBHL0JjZ2JWaE5nRVprR09QbHgzRk5zeUVoc25wWDRK?= =?utf-8?B?ZXZlZU5MY3k4dWowK2ZENXRJUGhJK3gvWnBTV1NZem0xeGs5bTIzeENaZzU1?= =?utf-8?B?cHFxaVZHbXJEWGJuUlJPTWcvRlo5eGtCc3Y4bzVmYTUwQ01xcjhwQzZFV2RT?= =?utf-8?B?TCtxOUR4cmRIVnlxMXZubzBRS3hEVWhURXVYb1pueW85bHlVUDFIekhDWThL?= =?utf-8?B?ZlhRVjJkRzh2K2FQMEY1K3NrbEVkb0VHbWRBN0JhWU5EVjJnSE1VUDJVcWZ1?= =?utf-8?B?UTJxMmZTcFlFemxzakxreVprUUxTL3hFTmJDQTQzYmNWakJYN2Y2MTlmTDU5?= =?utf-8?B?ZkpqNlcycTZseEhuQnB3a1A2UkFOVkdVMk9ENFRHQnRia0FlMXpHeXhlWmdO?= =?utf-8?B?ejhjeVFrVW9Mc3ZETmtoVkZwSXNqYmhqNWZjN0s1U1d2NjhoeEFLcVp0YWtV?= =?utf-8?B?M0YvTEJjYWdkUXRCVW5lekw3ZHJLUkhNMTg5TDhXQTFTUXpXb0hvS05qTEZ5?= =?utf-8?Q?H3Q0JZ6Y5b0lHtaYoO5HslI3x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba2f9c77-b702-45c3-255c-08daa1538e58 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 13:15:46.9939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ykdac2jVEcm0YM6PqI+zDADdQvouUj9YXKuSAivO5AmSccXyg9CPeoumd/pZS8QfqiD9H61bw6+h7JiQWOlKVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7084 On 28.09.2022 15:08, Roger Pau Monné wrote: > On Wed, Sep 28, 2022 at 12:45:13PM +0200, Jan Beulich wrote: >> On 28.09.2022 12:08, Roger Pau Monné wrote: >>> On Wed, Sep 28, 2022 at 10:01:26AM +0200, Jan Beulich wrote: >>>> On 27.09.2022 17:39, Roger Pau Monne wrote: >>>>> --- a/xen/include/xen/iocap.h >>>>> +++ b/xen/include/xen/iocap.h >>>>> @@ -7,13 +7,43 @@ >>>>> #ifndef __XEN_IOCAP_H__ >>>>> #define __XEN_IOCAP_H__ >>>>> >>>>> +#include >>>>> #include >>>>> #include >>>>> +#include >>>> >>>> That's heavy dependencies you're adding. I wonder if the functions >>>> wouldn't better become out-of-line ones (but see also below). > > I would expect most callers to already have those dependencies TBH, > and in any case definitions there not used would be dropped anyway. > > Or are you worried about the newly added dependencies causing a > circular dependency issue in the future? Yes, but maybe for no real reason: Now that I look, I see that no other header file includes */iocap.h (except, of course, xen/iocap.h including asm/iocap.h). Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 28 13:32:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 13:32:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413341.656922 (Exim 4.92) (envelope-from ) id 1odXAs-0003hN-IF; Wed, 28 Sep 2022 13:32:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413341.656922; Wed, 28 Sep 2022 13:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXAs-0003hG-FW; Wed, 28 Sep 2022 13:32:30 +0000 Received: by outflank-mailman (input) for mailman id 413341; Wed, 28 Sep 2022 13:32:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXAr-0003hA-Ca for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 13:32:29 +0000 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [2607:f8b0:4864:20::f2e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id feb71358-3f31-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 15:32:28 +0200 (CEST) Received: by mail-qv1-xf2e.google.com with SMTP id s13so8095696qvq.10 for ; Wed, 28 Sep 2022 06:32:28 -0700 (PDT) Received: from [10.10.1.154] (static-72-81-132-2.bltmmd.fios.verizon.net. [72.81.132.2]) by smtp.gmail.com with ESMTPSA id br38-20020a05620a462600b006bb208bd889sm2988237qkb.120.2022.09.28.06.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 06:32:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: feb71358-3f31-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6o+q+v2aIGZEskjyk0+qGEOnEAAO7SKQ70FzXx2J318=; b=EtiESMFRLPnc8/Cmg5kTJyidHSVPD2e0Zhn34e64gurRN4BAJFigzv9UurW4R1lx7T Juj8kNLQqAhB3mApl+//tPE8P6hDGoz+B0+QhTmqWNId6loTIGoBqnWu8FXg65MpTfEE llzZ8W4JbHndDnpws21dHcOAc+jo/uD3p+ymj9RhN6vnARvLZn5HK6qAW8qBPFclvazc XZk7pIofdB5NSX7xHv4/yfgrlR/pSD6sQa9LcoK2deDgvkJLb8Gej8bStK8o4Qt7F/Q6 pfpUb5rkEdpLCq9kgXAs79V7Suhx3Jc9LqGWzBpfbh000xfo0+GXw+XHfM+7BlaDVAkV Fpkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6o+q+v2aIGZEskjyk0+qGEOnEAAO7SKQ70FzXx2J318=; b=2KdqysUB0QwSFfP2nEy1VNDUGjSlCvpQJngNvt1VaaBNgmg/k6GeP5DM0EJLMsHqov fz09u+l5+Lu2KfeQ0CAAXWiyVSvpSiXaaBak48JkArRsv7zDYw0QYA8DyI9ndCwJW4ue 0ibLVVk4l854yicutnfn73mAz7Hr4UgdKBlOeMoPxOIv9TRwYeIPNU9XMnzCfYVBgsLE U2TES9YkUdeCs9kaphlSPqRw4mo4IvSl3flFcv0ZmMzuWRgf2QgZcnwZSS6GdSiZ7435 97zsnYVM0MITNPU6fFlsAn6wKCs/sAf0pKXtclGVa6pbZipcZqJhcihFROv3/1EB25ti p8YQ== X-Gm-Message-State: ACrzQf2Ps0HvyWHUaH+pdqLx7QQZPnkCSaUKOwkIMQHhs6ATa11a+E1C PqUpkPI46KhrxwS8jAZ+5/FCv4AwqUk= X-Google-Smtp-Source: AMsMyM7sHmtjL446ge86Qtx0vbY7S01QAHBs/oaCINxQKC8nxuOhQ7ArRP8oWkRhEJWcnMBMVdYUXA== X-Received: by 2002:a05:6214:20e6:b0:4ac:99bb:5821 with SMTP id 6-20020a05621420e600b004ac99bb5821mr25270573qvk.39.1664371947168; Wed, 28 Sep 2022 06:32:27 -0700 (PDT) Message-ID: <9340769a-d3cf-a7bb-f8f4-dc9bde463c02@gmail.com> Date: Wed, 28 Sep 2022 09:32:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> From: "dpsmith.dev" In-Reply-To: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/28/22 06:38, Jan Beulich wrote: > For quite some time we've been talking about replacing the present virtual > address based hypercall interface with one using physical addresses. This is in > particular a prerequisite to being able to support guests with encrypted > memory, as for such guests we cannot perform the page table walks necessary to > translate virtual to (guest-)physical addresses. But using (guest) physical > addresses is also expected to help performance of non-PV guests (i.e. all Arm > ones plus HVM/PVH on x86), because of the no longer necessary address > translation. Greetings Jan, I think there are multiple issues in play here, but the two major ones are 1.) eliminating the use of guest virtual addresses and 2.) handling the change in the security model for hypercalls from encrypted VMs. As Andy was pointing out, attempting to address (1) in a backwards compatible approach will likely not arrive at a solution that can address issue (2). IMHO, the only result from teaching the existing ABI to speak GPAs instead of VAs will be to break current and new kernels of the habit of using VAs. Beyond that I do not see how it will do anything to prepare current OS kernels for running as encrypted VMs, at least for AMD since that is the specification I have been focused on studying the last couple of months. As for ABIv2, I understand and can appreciate Andy's desired approach. Recently, especially with the hardware changes being introduced by SEV, I would like to have considered a naive and more radical approach. Currently hypercalls function using a more ioctl style. I would like to suggest that a packet style interface similar to netlink be considered. There are many benefits to adopting this type of interface that could be covered in a larger RFC if there was any sense of willingness to consider it. As a glimpse, a few benefits would be that arbitrary buffers, continuations/asynchronous calls, and multi-call are all natural consequence. It would also allow advanced extensions, such as an optional PF_RING-like interface for zero-copy messaging from guest user-space to hypervisor. While a packet interface could easily co-exist with the existing ioctl-style interface, it would be a paradigm shift from the past, though I feel ABIv2 was already going to be such a shift. Anyway, just my 2¢. V/r, DPS From xen-devel-bounces@lists.xenproject.org Wed Sep 28 13:44:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 13:44:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413346.656933 (Exim 4.92) (envelope-from ) id 1odXM1-0005Fu-KY; Wed, 28 Sep 2022 13:44:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413346.656933; Wed, 28 Sep 2022 13:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXM1-0005Fn-H6; Wed, 28 Sep 2022 13:44:01 +0000 Received: by outflank-mailman (input) for mailman id 413346; Wed, 28 Sep 2022 13:43:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXLz-0005Fh-Aj for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 13:43:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 99ce93d8-3f33-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 15:43:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 099E621C10; Wed, 28 Sep 2022 13:43:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B73D913677; Wed, 28 Sep 2022 13:43:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rqnjKpxPNGNkYQAAMHmgww (envelope-from ); Wed, 28 Sep 2022 13:43:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99ce93d8-3f33-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664372637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0+qgVvQ+GNlXq/zBvTYpmD3bvTKG59KN9G2baCe3L4s=; b=P5DHHumd2i+xFneCbxXiNZU52CtcBxpCKL9MIVmmVrmJGgYeR/5igZszVabPCAdZV1CcNQ crqIIxjgQ2zmZ1T0kaCBRaY6p02GE2G0aL7KND8nz3OTJl9Ayg18aWhbBm5Cjhw04nHzXr mDD9nG6UhXbW7Z8mFNsi6Xo2GV1IReg= Message-ID: Date: Wed, 28 Sep 2022 15:43:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------kLgPI4mCjxlBFdWM3iXqbGfB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------kLgPI4mCjxlBFdWM3iXqbGfB Content-Type: multipart/mixed; boundary="------------MXeAQGi5Qqv0r0hnWtTYtC8l"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> In-Reply-To: --------------MXeAQGi5Qqv0r0hnWtTYtC8l Content-Type: multipart/mixed; boundary="------------B5MVV0E1Q4UseucaNVxkMjr0" --------------B5MVV0E1Q4UseucaNVxkMjr0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMTM6MjIsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gV2VkLCBT ZXAgMjgsIDIwMjIgYXQgMDE6MTQ6MTFQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IE5vLCB3ZSBkb24ndC4NCj4+DQo+PiBVc2luZyBiYXNpY2FsbHkgeW91ciBwYXRjaCwg YnV0IHdpdGgNCj4+DQo+PiArCW10cnJfb25saW5lID0gY3B1aHBfc2V0dXBfc3RhdGVfbm9j YWxscyhDUFVIUF9BUF9PTkxJTkVfRFlOLA0KPj4gKwkJCQkJCSJ4ODYvbXRycjpvbmxpbmUi LA0KPj4gKwkJCQkJCW10cnJfYXBfaW5pdCwgTlVMTCk7DQo+Pg0KPj4gbW92ZWQgdG8gdGhl IGVuZCBvZiBtdHJyX2Fwc19pbml0KCksIGFuZDoNCj4+DQo+PiArdm9pZCBtdHJyX2Fwc190 aGF3KHZvaWQpDQo+PiArew0KPj4gKwljcHVocF9yZW1vdmVfc3RhdGVfbm9jYWxscyhtdHJy X29ubGluZSk7DQo+PiArfQ0KPiANCj4gWWVzLCBzbyB5b3Ugc2FpZC4gSSdtIG5vdCBzdXJl IEkgbGlrZSB0aGlzIHRvZ2dsaW5nIG9mIG5vdGlmaWVyDQo+IHJlZ2lzdHJhdGlvbiBsaWtl IHRoYXQuDQoNClllYWgsIGVzcGVjaWFsbHkgd2l0aCBoYXZpbmcgdG8gcmVtZW1iZXIgdGhl IHNsb3QuDQoNCldvdWxkIHlvdSBmZWVsIGJldHRlciB3aXRoIGFkZGluZyBhIG5ldyBlbnVt IG1lbWJlciBDUFVIUF9BUF9DQUNIRUNUUkxfT05MSU5FPw0KDQpUaGlzIHdvdWxkIGF2b2lk IGEgcG9zc2libGUgc291cmNlIG9mIGZhaWx1cmUgZHVyaW5nIHJlc3VtZSBpbiBjYXNlIG5v IHNsb3QNCmZvciBDUFVIUF9BUF9PTkxJTkVfRFlOIGlzIGZvdW5kIChxdWl0ZSBpbXByb2Jh YmxlLCBidXQgaW4gdGhlb3J5IHBvc3NpYmxlKS4NCg0KPiBPcHRpbWFsbHksIEknZCBsaWtl IHRvIGJlIGFibGUgdG8gcXVlcnkgdGhlIHN1c3BlbmQgY29kZSB3aGV0aGVyIGl0IGlzDQo+ IGluIHRoZSBwcm9jZXNzIG9mIHJlc3VtaW5nLg0KPiANCj4gVGhpcyBoZXJlOg0KPiANCj4g DQo+IHN0YXRpYyBpbnQgcmVzdW1lX3RhcmdldF9rZXJuZWwoYm9vbCBwbGF0Zm9ybV9tb2Rl KQ0KPiB7DQo+IA0KPiAuLi4NCj4gDQo+ICAgRW5hYmxlX2lycXM6DQo+ICAgICAgICAgIHN5 c3RlbV9zdGF0ZSA9IFNZU1RFTV9SVU5OSU5HOw0KPiAgICAgICAgICBsb2NhbF9pcnFfZW5h YmxlKCk7DQo+ICAgDQo+ICAgRW5hYmxlX2NwdXM6DQo+ICAgICAgICAgIHBtX3NsZWVwX2Vu YWJsZV9zZWNvbmRhcnlfY3B1cygpOw0KPiANCj4gDQo+IGJ1dCBiZWluZyBhYmxlIHRvIGRv Og0KPiANCj4gICAgICAgICAgcG1fc2xlZXBfZW5hYmxlX3NlY29uZGFyeV9jcHVzKCk7DQo+ IAlzeXN0ZW1fc3RhdGUgPSBTWVNURU1fUlVOTklORyB8IFNZU1RFTV9SVU5OSU5HX0FQU19V UDsNCj4gDQo+IHdoaWNoIGNhbid0IHdvcmssIG9idmlvdXNseS4gQnV0IHNvbWV0aGluZyBs aWtlIHRoYXQuDQo+IA0KDQpZb3Ugd291bGRuJ3Qgd2FudCB0byBkbyB0aGF0IHRoZXJlLCBh cyB0aGVyZSBhcmUgbXVsdGlwbGUgcGxhY2VzIHdoZXJlDQpwbV9zbGVlcF9lbmFibGVfc2Vj b25kYXJ5X2NwdXMoKSBpcyBiZWluZyBjYWxsZWQuIEFkZGl0aW9uYWxseSBub3QgYWxsDQpj YXNlcyBhcmUgY29taW5nIGluIHZpYSBwbV9zbGVlcF9lbmFibGVfc2Vjb25kYXJ5X2NwdXMo KSwgYXMgdGhlcmUgaXMNCmUuZy4gYSBjYWxsIG9mIHN1c3BlbmRfZW5hYmxlX3NlY29uZGFy eV9jcHVzKCkgZnJvbSBrZXJuZWxfa2V4ZWMoKSwNCndoaWNoIHdhbnRzIHRvIGhhdmUgdGhl IHNhbWUgaGFuZGxpbmcuDQoNCmFyY2hfdGhhd19zZWNvbmRhcnlfY3B1c19iZWdpbigpIGFu ZCBhcmNoX3RoYXdfc2Vjb25kYXJ5X2NwdXNfZW5kKCkgYXJlDQp0aGUgZnVuY3Rpb25zIHRv IG1hcmsgc3RhcnQgYW5kIGVuZCBvZiB0aGUgc3BlY2lhbCByZWdpb24gd2hlcmUgdGhlDQpk ZWxheWVkIE1UUlIgc2V0dXAgc2hvdWxkIGhhcHBlbi4NCg0KDQpKdWVyZ2VuDQo= --------------B5MVV0E1Q4UseucaNVxkMjr0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B5MVV0E1Q4UseucaNVxkMjr0-- --------------MXeAQGi5Qqv0r0hnWtTYtC8l-- --------------kLgPI4mCjxlBFdWM3iXqbGfB Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM0T5wFAwAAAAAACgkQsN6d1ii/Ey/X Sgf/crikTlJTPVcK1Ea0f8VQ0pY4rHV7agTDdfbNoN4Qh4vMLm/oYM+HM7DXpN64u68pk0b8eEwP IKE24yyYWt77yWMBLfXpO9yGtV82D3GmPD/Wc2Ma+pyYC926PHf70VNKuNe/tyXZAUL96qaEA5I0 ftsq75ktri6X323ky92q72azaAblDodwowr2RUzLRQjPlwcRJr2OwnHosrAm3RWVe8LtRuFCeHm5 clWaOCiROKuhCNa1GNvuPsmIdZUa7xPItPhf9WewfMQneGxd0WrzDpJryH8g5r16a/aThcpqret6 ujJmNQIvyIQldvfHwNP0Fid5vBagiJiz9Zkt65dJOA== =osbX -----END PGP SIGNATURE----- --------------kLgPI4mCjxlBFdWM3iXqbGfB-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:11:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:11:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413353.656944 (Exim 4.92) (envelope-from ) id 1odXme-0000SH-Ve; Wed, 28 Sep 2022 14:11:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413353.656944; Wed, 28 Sep 2022 14:11:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXme-0000SA-SX; Wed, 28 Sep 2022 14:11:32 +0000 Received: by outflank-mailman (input) for mailman id 413353; Wed, 28 Sep 2022 14:11:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXmd-0000S3-1u for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 14:11:31 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 678fe21a-3f37-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 16:11:11 +0200 (CEST) Received: from [192.168.1.219] (unknown [151.29.53.149]) by support.bugseng.com (Postfix) with ESMTPSA id 0572D4EE0785; Wed, 28 Sep 2022 16:11:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 678fe21a-3f37-11ed-9374-c1cf23e5d27e Message-ID: Date: Wed, 28 Sep 2022 16:11:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050929 Thunderbird/1.0.7 Fedora/1.0.7-1.1.fc4 Mnenhy/0.7.3.0 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Xenia Ragiadakou , Roberto Bagnara , Stefano Stabellini Cc: Bertrand Marquis , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> <12c95841-027b-ae02-1945-b0d232ffb17d@gmail.com> From: Roberto Bagnara In-Reply-To: <12c95841-027b-ae02-1945-b0d232ffb17d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Xenia. Please see below. On 9/26/22 10:50, Xenia Ragiadakou wrote: > On 9/18/22 16:02, Roberto Bagnara wrote: >>> The question is on the interpretation of Rule 20.7. Are parenthesis >>> required by Rule 20.7 in the following cases: >>> >>> - macro parameters used as function arguments >>  > [...] >>  > - macro parameter used as lhs in assignment >> >> You can obtain different semantics depending on whether parentheses >> are or are not used (in the macro call and/or macro expansion >> depending on the case): >> >> >> #include >> >> void g(int v) { >>    printf("%d\n", v); >> } >> >> #define m1(x, y, ...) g(y) >> >> void f1(int x, int y, ...) { >>    g(y); >> } >> >> #define p 0, 1 >> >> void test1() { >>    m1(p, 2); >>    f1(p, 2); >> } >> > > In the example above something bothers me. Let me explain. > > Running the above example gives: > 2 > 1 > > The results differ mainly because m1() is substituted before p. > Thus, adding parentheses around the macro parameter 'y' of m1() i.e > #define m1(x, y, ...) g((y)) > has no impact. > > If the example is changed into the following: > > #include > > void g(int v) { >    printf("%d\n", v); > } > > #define m1(y, ...) g(y) > > void f1(int y, ...) { >    g(y); > } > > #define p 0, 1 > > void test1() { >     m1(p, 2); >     f1(p, 2); > } > > if no parentheses are added around 'y' in the definition of m1(), the compiler complains with "too many arguments to function g". > If parentheses are added around 'y', the compiler does not complain but the behavior will still differ and the result will be > 1 > 0 > > This happens because in the case of m1(), p is interpreted as an expression (due to the parentheses added there) and the comma is evaluated as a comma operator, while in f1(), p is interpreted as a list of expressions and the comma is evaluated as a comma separator. > > Hence, in my opinion, parentheses should not be added around macro parameters used as function arguments because they can hide a bug due to missing parentheses around the entire macro definition. > Since macro 'p' is supposed to represent an expression, and the semantics of the comma token are those of a comma operator and not a comma separator, then parentheses need to be placed around the entire macro definition i.e > #define p (0, 1) Your analysis is correct: the example was meant only to show that the use of a macro or a function with the same actual parameters and apparently equivalent bodies can make a difference and that the addition of parentheses (around the body of p, as you suggest, or around the occurrence of p in the call to f1()) can avoid this problem. All this, however, is outside the scope of Rule 20.7, so the example may have been confusing: sorry about that. > AFAIK, there is no requirement in MISRA C guidelines to add parentheses around the entire macro definition when it is used as an expression and this is something I cannot understand. > Unless I got it all wrong I guess ... Yes, this is known and it is has also been brought to the attention of the MISRA C working group. > Can a deviation being added in the basis of C99 standard since according to the standard, E1[E2] is identical to (*((E1)+(E2))), and therefore, macro parameters used as subscript expressions are implicitly > parenthesized and can be exempted from the rule. Sure, you can always deviate any non-mandatory guideline: just be ware of the fact that complying is often cheaper than deviating. >> For instance, if you noticed Rule 20.7 reports given by >> ECLAIR and not by cppcheck, then maybe line >> >> Rule 20.7              FP >> >> should be >> >> Rule 20.7              FN+FP >> >> If you can let me have an indication of the code that >> ECLAIR is flagging for Rule 20.7 and cppcheck does not >> flag, I will be happy to double-check. > > ECLAIR flags as violations of Rule 20.7 the cases where unparenthesized macro parameters are used as (1) function arguments or (2) array indexes, while cppcheck does not. > > For instance: > (1) in xen/arch/arm/include/asm/atomic.h > #define read_atomic(p) ({                                               \ >     union { typeof(*(p)) val; char c[0]; } x_;                          \ >     read_atomic_size(p, x_.c, sizeof(*(p)));                            \ >     x_.val;                                                             \ > }) > ECLAIR flags as violations missing parentheses around 'p', when used as an argument of read_atomic_size(). ECLAIR is right in reporting these violations of Rule 20.7; these are false negatives of cppcheck. > (2) in xen/arch/arm/arm64/cpufeature.c > #define SANITIZE_REG(field, num, reg)  \ >     sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ >                  #reg, ftr_##reg) > ECLAIR flags as violations missing parentheses around 'num'. Same as above. I am probably repeating myself, but the MISRA guidelines are the result of carefully-chosen compromises between the simplicity of the guideline and its ability to protect against the targeted bad thing. As Rule 20.7 is required, any violation will have to be deviated by projects that have MISRA-compliance among their objectives. Kind regards,   Roberto >>> On Fri, 2 Sep 2022, Xenia Ragiadakou wrote: >>>> On 9/2/22 05:07, Stefano Stabellini wrote: >>>>> On Thu, 1 Sep 2022, Bertrand Marquis wrote: >>>>>> Hi Xenia, >>>>>> >>>>>>> On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: >>>>>>> >>>>>>> >>>>>>> On 9/1/22 01:35, Stefano Stabellini wrote: >>>>>>>> Patches 1, 4, and 6 are already committed. I plan to commit patches 2, >>>>>>>> 3 >>>>>>>> and 5 in the next couple of days. >>>>>>>> Patch 7 needs further discussions and it is best addressed during the >>>>>>>> next MISRA C sync-up. >>>>>>> >>>>>>> I would like to share here, before the next MISRA C sync, my >>>>>>> understandings that will hopefully resolve a wrong impression of mine, >>>>>>> that I may have spread around, regarding this rule. >>>>>>> There was a misunderstanding regarding the rule 20.7 from my part and I >>>>>>> think that Jan is absolutely right that parenthesizing macro parameters >>>>>>> used as function arguments is not required by the rule. >>>>>>> >>>>>>> The rule 20.7 states "Expressions resulting from the expansion of macro >>>>>>> parameters shall be enclosed in parentheses" and in the rationale of the >>>>>>> rule states "If a macro parameter is not being used as an expression >>>>>>> then the parentheses are not necessary because no operators are >>>>>>> involved.". >>>>>>> >>>>>>> Initially, based on the title, my understanding was that it requires for >>>>>>> the expression resulting from the expansion of the macro to be enclosed >>>>>>> in parentheses. Then, based on the rule explanation and the examples >>>>>>> given,  my understanding was that it requires the macro parameters that >>>>>>> are used as expressions to be enclosed in parentheses. >>>>>>> But, after re-thinking about it, the most probable and what makes more >>>>>>> sense, is that it require parentheses around the macro parameters that >>>>>>> are part of an expression and not around those that are used as >>>>>>> expressions. >>>>>>> >>>>>>> Therefore, macro parameters being used as function arguments are not >>>>>>> required to be enclosed in parentheses, because the function arguments >>>>>>> are part of an expression list, not of an expression (comma is evaluated >>>>>>> as separator, not as operator). >>>>>>> While, macro parameters used as rhs and lhs expressions of the >>>>>>> assignment operator are required to be enclosed in parentheses because >>>>>>> they are part of an assignment expression. >>>>>>> >>>>>>> I verified that the violation reported by cppcheck is not due to missing >>>>>>> parentheses around the function argument (though still I have not >>>>>>> understood the origin of the warning). Also, Eclair does not report it. >>>>>>> >>>>>>> Hence, it was a misunderstanding of mine and there is no inconsistency, >>>>>>> with respect to this rule, in adding parentheses around macro parameters >>>>>>> used as rhs of assignments. The rule does not require adding parentheses >>>>>>> around macro parameters used as function arguments and neither cppcheck >>>>>>> nor Eclair report violation for missing parentheses around macro >>>>>>> parameters used as function arguments. >>>>>> >>>>>> >>>>>> Thanks a lot for the detailed explanation :-) >>>>>> >>>>>> What you say does make sense and I agree with your analysis here, only >>>>>> protect when part of an expression and not use as a subsequent parameter >>>>>> (for a function or an other macro). >>>>> >>>>> Yeah I also agree with your analysis, and many thanks for >>>>> double-checking the cppcheck and Eclair's reports. >>>> >>>> Unfortunately in the specific case that I checked, it was not reported because >>>> it was actually an argument to a macro, not a function. >>>> Eclair does report as violations of Rule 20.7 the macro parameters that are >>>> used as function arguments and are not enclosed in parentheses. >>>> >>>> So, one tool reports it as violation and the other one not. >>>> >>>> The same goes, also, for the case where a macro parameter is used as index to >>>> an array. Eclair reports it as violation while cppcheck does not. >>> > From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:11:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:11:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413354.656955 (Exim 4.92) (envelope-from ) id 1odXmh-0000hf-5z; Wed, 28 Sep 2022 14:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413354.656955; Wed, 28 Sep 2022 14:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXmh-0000hY-2t; Wed, 28 Sep 2022 14:11:35 +0000 Received: by outflank-mailman (input) for mailman id 413354; Wed, 28 Sep 2022 14:11:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXmf-0000S9-4V for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 14:11:33 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7202ac3b-3f37-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 16:11:30 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 10:11:27 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA0PR03MB5596.namprd03.prod.outlook.com (2603:10b6:806:b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 14:11:25 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 14:11:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7202ac3b-3f37-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664374290; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=C/LWDynDNbuV9hcSSLexUl59+J9xjAwk6AToRd30lSE=; b=D7sLQphD6eKLheJqADumBHAHDw2DOjATSbYVfNuzPHqlu5L4G4lXyrAm JANCbt1+X2gkImhmUevvSxY8XTBT9VQbuavsvBpaE6g3qtRaiJJd7WQXH vhV3iAqcR0gpSCVmLmHeUEwUvle97ztn16tk98iMC58I2YuxdKGGXwdJF M=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 81960672 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MrWom6IAc5egAvJuFE+RfpQlxSXFcZb7ZxGr2PjKsXjdYENSgzxUm msYWmmGPq6KMDH1KYhyYYqyoB8HucDWmIVrTQNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4mNA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYEJx7paK3kNy eEddyoTcUG+neK164vuH4GAhux7RCXqFKU2nyg6iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QPT/PRni4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWPUrCry2bWncSXTcocVFLq8/69T23qc42FPKQU3EhyJmKzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yx2CGmEOQzpFadonnMw7Xzon0 hmOhdyBLT5ytLyYT1qN+7HSqim9UQAfIHUefyYCQU0A6sP6vYAophvVS5BoF6vdpuPyHTb80 jWbth8Ujr8YjdMI/6ij9FWBiDWpzrDLRAMo4gTcXkq+8xh0IoWiYuSA9lzz/ftGaoGDQTGpv mUC3c6X7+kMDJSEvC2LXOgJWrqu4p6tMzDCgFgpA5go8Rys/WKuecZb5zQWGatyGsMNeDusb EqNvwpUvcVXJCHzM/8xZJ+tAcM3y6SmDc7iSv3fcttJZN52aROD+yZtI0WX2ggBjXQRrE32A r/DGe7EMJrQIf4PIOaeLwvF7YIW+w== IronPort-HdrOrdr: A9a23:e40Q1K5/3nSw12FOcwPXwS6BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfTpyVSZNNXh7LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGg9HQjprpbTMPGhZisWC1/HqVwY+/NyLd8gYVUjtJz7tn2W /Zkzbh7qHml/2g0BfT20La8pwTstr8zdloAtCKl6EuW0PRozftQL4kd6yJvTgzru3qwFE2kO PUqxNlBMh342O5RBDGnTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZxB+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3MYiFXtuYdg99R/Bmc4a+L EENrCc2B8WSyLQU5nhhBgi/DT2NU5DXitvQSA5y7+oOnZt7TNEJnAjtbIid0c7he4AoqZ/lp v529xT5ddzp+8tHNdA7bQ6ML+KI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA= X-IronPort-AV: E=Sophos;i="5.93,352,1654574400"; d="scan'208";a="81960672" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z+KAXb7pLNjekIxqJMEimSVeLcXdwY76dxBwYvjDnVbpBg9A8mSLDuatHRtbK+EIAISk8/GF6a4hEP738de0AQmJEp3Kb0rkZrAPA9dvwBPIgxvJ/NgpYh6d2MGeb8pp3OkhWO+6EBHVtHqrzvS7jowrHivLgSQRAaEXxy7mX3JhOLb+C2bfyZ769xvOymomgtgcHViBv8vGkx0IypRxSoPI91t4glYFLW4dWTxod17xD2AhPkVI5cFgGyG3wXWTJQaa1JyUqVkgm0KhcZY4SRDMJHkhzUsZlnSSqgVy895SC5w+JE02Ds7U+ksL7sd1u+f+OrMG0FGa9C6NhWnObQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QckmXtlDiQaeZQuDTOhckAKX8c2IjxTAG/o+rQuU/OM=; b=DnuLV62IPZsEjmUwhQKEZuJxXgKSn6lmAs8PLG44Wqh1kKUiUDZfohr6jDvDAGgzmQYbDk0rmdVxA64SYy0yHTFo+echtmogc/p1qDKWtee7Xn4tGh6KJ2cJgU/0Hd4MsEZKTYyBpmioQq1vCLor1GZ8V500LYc5H7s3luS04Nm1jAiPnd8BE1c6ymm9ulaL1ufKgSR9s8zNhghaAdFB7PGp8fxbKu6oHyBL4rR+AR4YAueCa2VLJ5tuRab536lHzr7LOL2c14lOTIFTgSm5PXgYZ/m+mtLqceB+LYB5FRf8bIPsuDHD9UDCjUwtEswMmMxJwjSiPqECrkm+vhr1CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QckmXtlDiQaeZQuDTOhckAKX8c2IjxTAG/o+rQuU/OM=; b=ujmo1F3tESA2QKBKYyhFFrUGIffTk6/pChDMadjAQt71YQCsVShVGUsH8CBneaq6Y2xWJYZ+zLo+hAowLxbGemj4jV1v0BYsMZvcJnPRYJt4oBslMSa+K8cDHVVEw5CdNKnjSDbGBzmRZ1E1cLbt/z9++vh+XGyBILxucJpuKvM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Jun Nakajima , Kevin Tian Subject: [PATCH v3 0/2] Move calls to memory_type_changed() Date: Wed, 28 Sep 2022 16:11:15 +0200 Message-Id: <20220928141117.51351-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0252.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::24) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: 39ad0678-df88-4503-aa8b-08daa15b5393 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3EeDrlN0INK0bFmAzmwjFKHS0+MH1J1GgEwI4pI4wFAwUpSAnwqjy3ZoOTptUVtkAE2VsHZRh5xgsK5tXWvb7iA8gGCuhvDltZoKii7PHMUReMENJr20lFBrgvUmOLZwm2jbS8ARxYb4zb9HNdtmem4v/qPXVBI18TgePlWUaTOpRH4zz7sy7vHnzzrFVZdJmcHgbCAtbkwO23T1YF123+q4loD6kLx+6ysfQT+waRYqvxdpQIDogb/+HeoJjSSGZVdNotvwA2aaftsns6WIMp4H4/K0xZGY0IxNOkPt02u3lEz1hPCdkMrm15x88MFj9sNLKBU5LrPjdmv0Kt0KkwiMlnJ6aoNnVqsKJUIcHDN0o7U3dbE2iX0yeKZ+/HG4K66xwgcpnow4vh8N2Ls9KQtU8l33z5Z2Zb5uT+/tzkLIZkI7pOHOcE3YqixF2wkZyiCWwNC5OnTtwVH3JMEP3Bz/pzswIiUkmupTdDPsVgHh+5ZkfQnDZMtdMp03xI1dVtfiFvvthHcnU0i2XBFClYY0C0DT9pCdTGO6KeONH4I9qEAbY6cziNvf0iauCrbIV8/GGgvwTnxHBw+yk8kL/300frTDovEMKC1yqvFw0LL4+mR2abh1o/kTalTrwTFH7q+XFDVR3+PF51qkm3qyFQEdm34ZMpCN6CEiIv8oiuM1q8BW9Bib0tKHuOyY4/cgC9JG8Ag4soEPFGyn9tEKYg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(451199015)(82960400001)(6916009)(316002)(54906003)(5660300002)(8936002)(8676002)(4744005)(36756003)(41300700001)(66556008)(66476007)(4326008)(2906002)(66946007)(6512007)(186003)(83380400001)(86362001)(2616005)(26005)(38100700002)(478600001)(1076003)(6486002)(6666004)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2dmRW1pelBKRy9jb3owMGZIQ2JVelFLbEYycE5LQURXSWZEZVBuZjZEM0xR?= =?utf-8?B?U1Ywa2tzK2loZFNaUWNHbWZ3VzBhS1RtNW1ubGxmWlJUZFZaWHdpMmpQQ2Zp?= =?utf-8?B?eHRmYlZLZGFzYUxwRG9VNEhpNDJPY0FDc21iSzJTSGRvekUzYlNOM3UzNUJp?= =?utf-8?B?N2V4dVJacXdHVlJKejJpV1g2TXAwVklNZmE1K0hXbGdIRGdIL1F5cmN6SHBh?= =?utf-8?B?amlzSTNoSlhpSVMvYzNXS1hHTzgwRnFnNTdQK1BMOHd1WEMzRzg4ajZQZHk4?= =?utf-8?B?dDJHWWwrZkxmOVlGMVpjUUw2c3l0SUlqazBGajJGUktWV1JNWFJiZWYvTXFu?= =?utf-8?B?MEdHVFFBUWdsSnhDcHgyQTVKbC9ldmdkbjZ5ZlJvb0VNamt5dUdGdlVmZXl1?= =?utf-8?B?N25oekRvYnR5eG5JYWVIVnpEcmt4NWhhTm5QY1NTNmt0UWNiRXZuUXFYVU1z?= =?utf-8?B?ZVlzU1VZYmEreXJsMUFFb3FxaEVpbWY3bURCUG5DclN0aXlXVmVaTEJYWFVK?= =?utf-8?B?b3BUY29DVTlMcVAyTG9vRkJTZG1ucmhNa0kvbndZcGJWMmhnKzFsaHFMRGhE?= =?utf-8?B?NmVtckczOVZqNFowTTVjZ0pVSm80amtYK29NQzdDTUFicmRiTDBlbEoyRmt4?= =?utf-8?B?RnczT0g0bmdRSnlXNWFzWUd4NDlwQXhtVEJVdE1FMkprQU85STlOSWVzV0Zp?= =?utf-8?B?RTZ3UGQyalhzTmFsM01ENjRRUUp5TnpyN3hrK2s1blNwQVc5bnJLdnFIdFE4?= =?utf-8?B?UUgxT2o2eFdpWVlYbkpSdnArakNiL2hLTEVUWjVLMGk0UGkrdCtUY1FOSndU?= =?utf-8?B?aDdQYitPQUJ1dHVRODF2MWg0OWpuV2tPL2xpaEVOcEpKTFh1dDZUeVhXRlVT?= =?utf-8?B?QjU4c0RkYmYxNitzODJKTlplQ0oxd3hwNVdUK2VwYnIrRXJJN3NDeU1NYmlH?= =?utf-8?B?dC9uSTVQdjN1YUNSVjQvSWt0N1VEZUlLK0YxMEdOYTJlajNyZWZyVmZaTUM5?= =?utf-8?B?dEZDSzFYUTRUdFlwaGJCL0xWZGtxYkdPZmM2cVhmODJNSUxzaXpnYTZBa1Zm?= =?utf-8?B?OHJKS1A5Q2F4SXQ0UHlDUmduVG5ZT09xNllsSW9TZGZjc1lSOGZpaFFoRzhL?= =?utf-8?B?Qlhob1lqRVJiTGNSc2lXbUNuSEVuQmpxb0dvWmtlWkNkVlBabjZEN3BrQkkr?= =?utf-8?B?N2s2R2tITGp0b3paczdxU1gyTmZGWUJsZkJDQTFBeGpOUFZuVmcxYTFWNllw?= =?utf-8?B?NGQyVmphSTdhbmlEZVpoQ2pjTU0yTHZwcWdnRVo3MlBWNnRIaWw2SWdIRXpN?= =?utf-8?B?MTZQdmhtY1hOMmNxNDlpNTgrYmtBUzZoVHpJb3FGTjVBQTIrMHUzUEZXaXhp?= =?utf-8?B?RGNVaUkvN3JxMk4zNHN5dEh4NjJzWDQxM0crbW43Smx4eUtiWC9FU21UK04v?= =?utf-8?B?aStmcW8vVElFZXdZUHpRaXR6eXhsdGZLUVJPYjZOam1nMkdLUW1TYVdMNlcz?= =?utf-8?B?aGdJS09TWUtiQnZkYysrYmcwL095dEppU2diMW5vZnN5d3Z3Y3lISzN6NzNS?= =?utf-8?B?OVpzRlFTWHFISUNoV2ZEUEMvREg2b0diYlFaTWZReFJib2N4bkZ0eXUxa3BD?= =?utf-8?B?YUo0c2tYWE5VQXBuUVBVOGR4ZXdjUitrbFpjc1pkeFpjTUZ2bTNodkphVkxR?= =?utf-8?B?bFVEbWVvb2Q1Q3QwalppZXpWNHVwYXBhZHg0dnpibnRneDBjUVVieU5VR2xh?= =?utf-8?B?bHpVNnZYMHdjcityeXdGYzQ3cENkdkN4T3Z5b1krM0tRMXBGa3l5QzFwSG5r?= =?utf-8?B?djJsV2VpMXhjNHVJcGRWQ1hmcFQzaGVvN1hXb0dhejNRcXBIaEkrTTcwaVZ4?= =?utf-8?B?VnZqUUdZRS8yWFVUM0FSSWJ2T1FlZUJuY2lsUnF1QXlUUW44TWFTcGxwT3Fz?= =?utf-8?B?OXZhUndGS2M1anAySm1wVGxtcUxDTGE1eUhWa09GTG5LTVFkM2tObzhvZmZN?= =?utf-8?B?WXlpeUUzSkJ5SkdEd0VPT1UvK3BObDlTUVVRc09HQytIY251RE03WU4vVGIr?= =?utf-8?B?SEFHMCtoQ3RkTXM1UWttTEpHRENHV1RaZWFVTEhZMnVBN0RHRHFxbVdqMWZE?= =?utf-8?B?SEg0dTFkRVZtOVg5czBiVE85Rno1Mk5wL01jVkorZmFHaHRDVUNWNXpheXIr?= =?utf-8?B?N1E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39ad0678-df88-4503-aa8b-08daa15b5393 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 14:11:24.5909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M20+UmG59T2NQTrgLMDbX1WCUbvv5dChiwQfmgU2LehUUF9JwvJ6ctiabI8FQXBlSaOR69f2i8hBqI6fqHl70A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5596 Hello, The current calls to memory_type_changed() are wider than strictly necessary. Move them inside the iocap handlers and also limit to only issue them when required. I would really like to get some feedback on the Arm change, since this is now a prereq for the actual fix. Thanks, Roger. Roger Pau Monne (2): arm/vgic: drop const attribute from gic_iomem_deny_access() x86/ept: limit calls to memory_type_changed() xen/arch/arm/gic-v2.c | 2 +- xen/arch/arm/gic-v3.c | 2 +- xen/arch/arm/gic.c | 2 +- xen/arch/arm/include/asm/gic.h | 4 ++-- xen/arch/x86/domctl.c | 4 ---- xen/arch/x86/include/asm/iocap.h | 33 +++++++++++++++++++++++---- xen/arch/x86/mm/p2m-ept.c | 4 ++++ xen/common/domctl.c | 4 ---- xen/include/xen/iocap.h | 38 ++++++++++++++++++++++++++++---- 9 files changed, 72 insertions(+), 21 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:11:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413355.656966 (Exim 4.92) (envelope-from ) id 1odXms-00013S-Es; Wed, 28 Sep 2022 14:11:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413355.656966; Wed, 28 Sep 2022 14:11:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXms-00013E-BG; Wed, 28 Sep 2022 14:11:46 +0000 Received: by outflank-mailman (input) for mailman id 413355; Wed, 28 Sep 2022 14:11:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXmq-0000S3-Km for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 14:11:44 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e71850c-3f37-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 16:11:24 +0200 (CEST) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 10:11:38 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA0PR03MB5596.namprd03.prod.outlook.com (2603:10b6:806:b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 14:11:36 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 14:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e71850c-3f37-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664374301; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=xqpzPTo+tqWuVrT/dDNqz4ZD0jH2eM4n5dh29qP+bVQ=; b=eusiJvoriASupoqr9vMvZvkYVbKYRfOYJQCRomEKfQ1S3EVzEkrimdOo wve5x+Q5uYNccD0gCUQVO0HI59kcCs0pHHl/SdnpnoDVxaTNiJhePo24w BKoZh4cNE0th/2QyXIF2w+nbCed58hsWKUvUUzceM3D4wHWbri14cv0yQ A=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 81960679 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:I90kCarI8QxXXUwAdC0TTIyHKXdeBmLpZBIvgKrLsJaIsI4StFCzt garIBmGM6mPZGXzc4sgaY2+8UpX75CEzIdkQAo5qi02RSNGpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPaER7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx Po1ci00NRy4t+vn8u2lSsJLl+pgI5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUoojumF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efxHKlANxNRdVU8NZopEyomEURFiQ0XGOGjdughkXiR95mf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx750RkMhN0ay49FLGhjuEp57VQwpz7QLSNkqm4x14Ysi5ZoWuwVnd8ftEao2eSzG8U GMsnsGf6KUCCM+LnSnUGuEVRuj3trCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC KPOhT5sCFZoFCPCRcdKj0iZUKzGEYCI+QzZa83p IronPort-HdrOrdr: A9a23:T1HthaDd5+H+XKTlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dNME/N 323Ls1mxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg12w 31CNUXqFhwdL5mUUsEPpZmfSKWMB27ffueChPlHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou WKbG9l X-IronPort-AV: E=Sophos;i="5.93,352,1654574400"; d="scan'208";a="81960679" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S7AzwnHxpmN/KV8N9yvgj9FUdiQ68WAOAvVjMcQrG3XUs6PFtCsOUmQMsxtIMYZi+YIPrXUGgwv/zK+u6Mz66b/Ms7MAkCgNl9pxPuXGZWBMeYVp02pdQwNQ3Jm23pODIPl1RgQAl7Cq/G4RDXASnY7OJ4Xttt9w8SgVAVikuC/dVnutctL8/MGCym6s94HgARCikUF/WRacx/25Y7mGnMhYgFQyYOV2w2pvd5e6TM9ENY2pRo5HJjsCHYuXxuKMc2bh5Hue0s1MVO6ZLWU80hp2XQsJM0ZROhtcm6Hjzrk3ILLolmEZs+1siZ1CB26b9BEzDTSu/nEjQkBFKHbHig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rrg6TmkiWke+u14j4kPKExk7sncmIIb6n+HAE1tRCec=; b=URXKDG46zgef/aipTzYUvYzy/ZkI28GN0es8qfjUrOt8rrMf4Bpqhv/0L545Su0Gy4ruBMglI/gU7KlNllH/yBhlCVpivGhGgTrCvOKuR8EQaimq+z3nHspky+WDWQMoUTx8xlzcAOhycY5GSypb5FjhQCSziZrBlHQbrXd/EWQ26K7vrb20PtYMYx3w+I8D1X8ad87NNNafzx7dKU94YaSBdWssXNMQUJ3x1Wzj0CJh9CB5I31LcrqL4yhIx3coXqyBdLEVpfwErhI8OqgxjDa8LAD3GKEXOoHwcjSvR3wdrfoJAxYhwz3KJ66EQo84lTUCnEqHXefNtIXsVa6IJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rrg6TmkiWke+u14j4kPKExk7sncmIIb6n+HAE1tRCec=; b=TT3onQoNrLH2kcxjn0ET5qXM4WwWfLUVj3kFPNMykhCaK0u6KzMyhCX+6/ycLp3QXuwHBmISmF45m7zsAkLr+eGSgb3aohqrmitMD5nWzKuQhvhuBAIGB5n7V9eXAoWWJNzt8Rydp/aJyhy152L0N9+gLgcqIebT1O++bgCCgAU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian Subject: [PATCH v3 2/2] x86/ept: limit calls to memory_type_changed() Date: Wed, 28 Sep 2022 16:11:17 +0200 Message-Id: <20220928141117.51351-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220928141117.51351-1-roger.pau@citrix.com> References: <20220928141117.51351-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0004.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: adce3f8c-8cf4-45be-e88a-08daa15b5a9f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OnwZQzge45P4seLIah8vp128gWh5NiC+MUNgNwXSDU+v0ynal/qlMtbP5E1G/qOZi3L1R0bpMtPaa0YQbh6PYsIn5pScjh01uV9FneoOu+zfDNuxqtWzufUeJ1pLFcWtudLI/oYE8jMGQ38K0l6BduZknrkHWGqjJq98U/395YzpLKD4IPHlz+lHrYjdjRDKokzLOwR/wSdui7nQT3rYFnPQcsnrT8kd6cVYscWam1F9evtPI2W3hYwytsh+kCtqLb6S1mK4TNRJjVVx81rdJVXsFwjddsOYVNoqgNmZrER3hpfgBgpBi47o5u9ozR/6uR94n/qwUX40REhRLU2/yjNhjLKRAHXKBMj0XxOjArmQoS6C84Bh/gwoBN1b2+gGi/7ko/3QgYDndEFf8UaHgGJiqmRnSld6h53LexVnL2hjJiKR0RBxsYsRURB53UWovxBuXXsWuX5IG1hwSOFG6p3zrT7hs/1yWqGqRV46U/2GWMfjWwINRM7mSmc5cK2Vgxk323tW9VrNGqw9q6TX8BALIKOiYCH1Xbp/M/T9aWqeUiWN323aV2Gw4+nc/4sFix9pWpPA72uHIWUo+a2nRnHN3lxBvsS76FeRdWaEzTTYqfF5aWyCOGrsZqkiYoc0/RNyCMEv2LTp1/5OsDi9raYiytvWjx+OtLgEbq6hoUe35Ooh69qjSIUcLUMGaNO8UhPGNobjf0QNHDVx5Ej9pA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(451199015)(82960400001)(6916009)(316002)(54906003)(5660300002)(8936002)(8676002)(36756003)(41300700001)(66556008)(66476007)(4326008)(2906002)(66946007)(6512007)(186003)(83380400001)(86362001)(2616005)(26005)(38100700002)(478600001)(1076003)(6486002)(6666004)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3lNSXB0TTdHeVlRUWF2T0VXQW1OWG8zZmZLZmhxdVlkMjZrNXlXc2tjaU9i?= =?utf-8?B?dmRFTXhPalllNWFqMEtSRFlCOHJuTTdlVGpvS0JUeWh2K0V0SktaYmFRWFJr?= =?utf-8?B?bFF3MWxhbldjSnhzM29mc3UrTUd6bGhYWENITis4dThXVXBTZEFsa2ZsQlh4?= =?utf-8?B?QzY3Z2J6aC9BTURkeWtVbEhzdXFWTUk2VmhrRWlxMmlFSEhvQ2daemJuWlV1?= =?utf-8?B?Y1VQU0xtNVdBcTJpQnZxOW9CSVI3QjZxL0M0NHkzK0IzVDI1a3Nrb21qOVNW?= =?utf-8?B?dldFd0M4aVJndnZxM2NqeHdHSkxWOWxXN3NZQWF6a2pOTjhHeitiMEFHT08x?= =?utf-8?B?MVc4bUJXRWZ1UzJTbEJtSVc4RGtlNm00Qk5XRHhRK1QvL3d2VkE2eE5nQUJK?= =?utf-8?B?MlBpVStaZTNoY2RBTDlpSVlQb1U3NFoyODlPTkZteUpNaGY3NXpOSmRiUEhs?= =?utf-8?B?aitWZXowanF0R3NMWXpINSt3U01UUWxPNE15VGtmTkxmelk1S1JzTHBWZVRt?= =?utf-8?B?NXFraG15WFFxTUdOendRamk3Y21PQ1hvSkhraS8vRjMvUlZXbUpFcWx2dGNq?= =?utf-8?B?bGo4OHk5WmtRQ0JKcitubUJDaFJkbDhuYkxKVU1wWDZ2aStMODd3WmVNQlJJ?= =?utf-8?B?UlBISUFlQWF4bVVpMVluZDNiVElhaENjM2dzKzZxckRtQ1pZWFNDdmtwcEs5?= =?utf-8?B?eUlpRWpQZzYyVkJXaVdXUCtuSllDSUxIRGxNdWxOdTJMYWlkYkd3VzIySUZI?= =?utf-8?B?RjZxWGVBM3JxRHJlOWRKUDAvVVI1bHhGNmY2L3Jkdk1hMlowT21vbDJ0bzg5?= =?utf-8?B?WnJNODRKVXVkU2FvYWJ0dkJ2T1RPMUh0TDRJTW51b25QK1ZDa1VZK2JHUWdC?= =?utf-8?B?VDQwTncwK3U5ekdPRlROZHRGTmt3djR5TGlrSmRGOTFIY3hWQ1BZN2l5QnBy?= =?utf-8?B?dG1vN01ZanZuUXgzcnNXSklPeTVMUEZUdXY1VmtGUXR0cHhJNG0vUFVvOC9v?= =?utf-8?B?ZkZtOUh4TGV3OWVBVUw1ZnljOGZKVGVkajF6Wk9FdnlXekNoMVlNdHUvenVk?= =?utf-8?B?amdRMzJ3RTZDR2I4ZmJWZzVMVTFxbEdBclhUa0lxamNtOXJ0aWxOOUlDTWlk?= =?utf-8?B?emZDclF1SjBNZHhJcTB3Y2NRZnhOKzdRSVBzWXpkelg3Y3NYek9lRk03RHla?= =?utf-8?B?bHNDc3JRdGw3Z2gyMlJ4Yk0ydzYraHpXZkhUTmFkVUZ3Um9GQzRFMGxiOERS?= =?utf-8?B?ZnVqRHM4T3hoTkVMWXkrTG9Ed3h1cGZxN1RudEczQkZaNUhVNlFpb2E5bTl0?= =?utf-8?B?QlR2NUNIbFg2OUpqQTV1cWNNQlg0WlZVY3RMZmJhWnVQc09xdGVFRnhTdTlW?= =?utf-8?B?UUlCV0NlUGZrdkFwL01hN2JwMDNEMzBBZG15UXJnbU5FdjhsRnN0MTU3dFlX?= =?utf-8?B?dG9CYVN6NERyanloMmYwNXFOZzRqRDJIVlArK1J2Y2I5VmEyVUNaaTBpOVov?= =?utf-8?B?T0pzTFVaVHRrL3BEaWFaLytxc0tFd2lsYXpKMXVLa0tqbmxsaDBaTTZKcFY3?= =?utf-8?B?NU1jR1YrVGxkbGNRRE9xdWIrQzJSeFNCT1VIQ2U5OU1OMTdsbDVaQk9aNzlm?= =?utf-8?B?czlXcDBZNWgwcFFWZkNzYUpoaExYSzIzbHR2VXZaZFVGTTBySElWYUdqajRu?= =?utf-8?B?SkZCd2IrdmVkMis2ejl4c0NEa1o1cjhSYnJSZXplQUNERXkrb2lsM0NwM0Jx?= =?utf-8?B?bmJCNzg2UFU1WjJTWXhRdERKRUluZ3kwVklseE55N1Q3WDcwL0gzMm8vOUJF?= =?utf-8?B?RzhMcWdaazhiLzZoMWE2cmk0T2pNV21OSDBFdC8yRllDekRUL3RMNXhGd3NE?= =?utf-8?B?S1djdkxQcXJDOXBjQkgrbFp1VGY1K2RLNHNNY2RUaWl6SUptTHFsZlBiWksx?= =?utf-8?B?UHE3aVhwd21OTFcrcmEzdnRiY2pNbllaNy9QUGM3aFBZczd4ZzlwSzh4VHk4?= =?utf-8?B?bGdXMXJxY3BmbE1VemFUdFpOSGVuVlFDc1NKS1dCaEVSa0krNHZHYlJ4dUxm?= =?utf-8?B?KzBwTjhlNWMrZzAwTXBSdzY1MXZuUnhwYW5MN1AwY2NkNEdPUUdvR3JqemxM?= =?utf-8?B?bE5mTml5S2hXTldDTGU0Y2hEUnR5WjkyYkZiTUlndVZsMlpHelpYRmEyQnlJ?= =?utf-8?B?Z3c9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: adce3f8c-8cf4-45be-e88a-08daa15b5a9f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 14:11:36.4152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 49A+fQb96QSnmLFIw4zTmhfRQDazU7lgWFEAzYhbeWzRFHRsH24hX9EWlyoMYPlIBlqhC0o5WvV0Psk0hVQS+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5596 memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné --- Changes since v2: - Split the Arm side changes into a pre-patch. Changes since v1: - Place the calls to memory_type_changed() inside the io{ports,mem}_{permit,deny}_access() helpers. --- xen/arch/x86/domctl.c | 4 ---- xen/arch/x86/include/asm/iocap.h | 33 +++++++++++++++++++++++---- xen/arch/x86/mm/p2m-ept.c | 4 ++++ xen/common/domctl.c | 4 ---- xen/include/xen/iocap.h | 38 ++++++++++++++++++++++++++++---- 5 files changed, 67 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 020df615bd..e9bfbc57a7 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -232,8 +232,6 @@ long arch_do_domctl( ret = ioports_permit_access(d, fp, fp + np - 1); else ret = ioports_deny_access(d, fp, fp + np - 1); - if ( !ret ) - memory_type_changed(d); break; } @@ -666,8 +664,6 @@ long arch_do_domctl( "ioport_map: error %ld denying dom%d access to [%x,%x]\n", ret, d->domain_id, fmp, fmp + np - 1); } - if ( !ret ) - memory_type_changed(d); break; } diff --git a/xen/arch/x86/include/asm/iocap.h b/xen/arch/x86/include/asm/iocap.h index eee47228d4..ce83c3d8a4 100644 --- a/xen/arch/x86/include/asm/iocap.h +++ b/xen/arch/x86/include/asm/iocap.h @@ -7,10 +7,11 @@ #ifndef __X86_IOCAP_H__ #define __X86_IOCAP_H__ -#define ioports_permit_access(d, s, e) \ - rangeset_add_range((d)->arch.ioport_caps, s, e) -#define ioports_deny_access(d, s, e) \ - rangeset_remove_range((d)->arch.ioport_caps, s, e) +#include +#include + +#include + #define ioports_access_permitted(d, s, e) \ rangeset_contains_range((d)->arch.ioport_caps, s, e) @@ -18,4 +19,28 @@ (!rangeset_is_empty((d)->iomem_caps) || \ !rangeset_is_empty((d)->arch.ioport_caps)) +static inline int ioports_permit_access(struct domain *d, unsigned long s, + unsigned long e) +{ + bool flush = cache_flush_permitted(d); + int ret = rangeset_add_range(d->arch.ioport_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !flush ) + /* See comment in iomem_permit_access(). */ + memory_type_changed(d); + + return ret; +} +static inline int ioports_deny_access(struct domain *d, unsigned long s, + unsigned long e) +{ + int ret = rangeset_remove_range(d->arch.ioport_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) + /* See comment in iomem_deny_access(). */ + memory_type_changed(d); + + return ret; +} + #endif /* __X86_IOCAP_H__ */ diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index b4919bad51..d61d66c20e 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -518,6 +518,10 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, return MTRR_TYPE_UNCACHABLE; } + /* + * Conditional must be kept in sync with the code in + * {iomem,ioports}_{permit,deny}_access(). + */ if ( type != p2m_mmio_direct && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) { diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 452266710a..69fb9abd34 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -716,8 +716,6 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) ret = iomem_permit_access(d, mfn, mfn + nr_mfns - 1); else ret = iomem_deny_access(d, mfn, mfn + nr_mfns - 1); - if ( !ret ) - memory_type_changed(d); break; } @@ -778,8 +776,6 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) "memory_map: error %ld removing dom%d access to [%lx,%lx]\n", ret, d->domain_id, mfn, mfn_end); } - /* Do this unconditionally to cover errors on above failure paths. */ - memory_type_changed(d); break; } diff --git a/xen/include/xen/iocap.h b/xen/include/xen/iocap.h index 1ca3858fc0..0ca4c9745f 100644 --- a/xen/include/xen/iocap.h +++ b/xen/include/xen/iocap.h @@ -7,13 +7,43 @@ #ifndef __XEN_IOCAP_H__ #define __XEN_IOCAP_H__ +#include #include #include +#include + +static inline int iomem_permit_access(struct domain *d, unsigned long s, + unsigned long e) +{ + bool flush = cache_flush_permitted(d); + int ret = rangeset_add_range(d->iomem_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !flush ) + /* + * Only flush if the range(s) are empty before this addition and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for effective cache attribute calculation purposes. + */ + memory_type_changed(d); + + return ret; +} +static inline int iomem_deny_access(struct domain *d, unsigned long s, + unsigned long e) +{ + int ret = rangeset_remove_range(d->iomem_caps, s, e); + + if ( !ret && !is_iommu_enabled(d) && !cache_flush_permitted(d) ) + /* + * Only flush if the range(s) are empty after this removal and + * IOMMU is not enabled for the domain, otherwise it makes no + * difference for effective cache attribute calculation purposes. + */ + memory_type_changed(d); + + return ret; +} -#define iomem_permit_access(d, s, e) \ - rangeset_add_range((d)->iomem_caps, s, e) -#define iomem_deny_access(d, s, e) \ - rangeset_remove_range((d)->iomem_caps, s, e) #define iomem_access_permitted(d, s, e) \ rangeset_contains_range((d)->iomem_caps, s, e) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:11:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413356.656977 (Exim 4.92) (envelope-from ) id 1odXmu-0001LZ-S3; Wed, 28 Sep 2022 14:11:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413356.656977; Wed, 28 Sep 2022 14:11:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXmu-0001LS-Ov; Wed, 28 Sep 2022 14:11:48 +0000 Received: by outflank-mailman (input) for mailman id 413356; Wed, 28 Sep 2022 14:11:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odXmt-0000S3-G7 for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 14:11:47 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6faabdc5-3f37-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 16:11:26 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 10:11:33 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA0PR03MB5596.namprd03.prod.outlook.com (2603:10b6:806:b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 14:11:31 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 14:11:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6faabdc5-3f37-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664374304; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=D0ar6Be/O6ceYvTffbwdzz9tYlDXEXceF7FBXTya4eM=; b=MDFm3VWjVCFgi8ByGAL0VBnnttZtC86+KHTMDgc+DPbCpX0TV6FHAO2Z xnfNBmQFjEkaWSVfoLH5ISc0z2fWLNmxdfwHeGfWwOcedRXBCd6a6FYOG jTnNcH4YnETldy0l0vMnPLm/zirBtnhaDG0U5eXWze48o2GUHsYfFUE8N 4=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 84050010 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:whlHgq485/ZlzianDhgUQQxRtODGchMFZxGqfqrLsTDasY5as4F+v mRJWG2AaamNNjGhftwlbou29k4FvpWGndViTwA/rCpgHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPYwP9TlK6q4mlA7wZuPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5SOU1sz 6cfIgkkTR+EqM2z45m/EPdV05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMkGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLw3rKXxXqjMG4UPKe77qJkr1uM/HA8SywUcWW7juKkunfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAfVSJIYtEisM4wRBQp2 0WPktevAiZg2JWXVHac+7G8vT60fy8PIgcqbyIeUREM5dWlpYgplw/OVf5qCqvzhdrwcRnOx DSNoDk7lq8kp8cB3KWm/njKmzup4JPOS2YICh7/W2uk6kZ1YdCjbonxs1zDt68fcMCeU0WLu 2UCl46G9ucSAJqRlSuLBuIQALWu4PXDOzrZ6bJyI6QcG/2W0ybLVehtDPtWeC+F7u5slefVX XLu IronPort-HdrOrdr: A9a23:npcqvavPOi+/cWkSteZp0ITH7skC7YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczKgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxenkPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesaMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO21GkeKp ghMCjg3ocWTbvDBEqp/lWHgebcFEjbJy32DXTr4aeuontrdHMQ9Tpr+CVQpAZDyHsHceg12w 31CNUXqFhwdL5mUUsEPpZmfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou WLbG9l X-IronPort-AV: E=Sophos;i="5.93,352,1654574400"; d="scan'208";a="84050010" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQhtuQJlpcsABc5iMYnJ9Lt4IPAQdYKblhgG0lBZRFecnwNqByxg8c3AzB+dLsc3FTMzxDWRCzhyoaFL9OvwGrboISkESFKtJ9VXuGbP+2jBmCmOxFws6HawFmXZ/Tc+obmCgBq9/sUoIBtFTircROUfduW4etW/JKRXJyr/p1fHlzMNeGeT0xUlwK8MvBtgh1Kl8rJgMLzWs/yaANVG4IlEVKTeFtTOtPoZUyreuk1Em7gUFTBwOgQX7B67Mjnn6+DxOru6gnR3ZUeFQVXuaKOWjE7IzjhDawYJ3zIbeLlH2JoBDlXNNEDjaPWPA/LUlgGPspil06EaUlOH8mmcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kB9mpVtnBT/eigFVC4SQfhSkRGs0sR28/Ucd8sfyyMM=; b=U1QGVCMwLdjR+XGFnguTZA+QVt4IlMFMUkR3sOEGw1jwJDvhGgD4E7z2ampH+d2gw6OJbW2QF0h2gra6xfqwpiMFu/GnCRHvDW35R3qEjuLoBChEAraWurqI37ddETNfC8UihQa/Kv3u2j5VYFA8Fe+ObSQSoS2GN4fL+rjsUSj+PBmQ6JtSu+b3ut8gib86daF3CHAJz5Twvh9UW8QdGpqBsiK8VeQWTY6wz3mw4Jxw6enrwPm4O3QziCQyVnm0AP5CdnV3o9J31L84g9eg8PTAv3UAoX9DHySEcTiVpJ9FIe70BeeFrGLv0H7IbjtfJN5v4JmKcprCFrBqQ9z/wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kB9mpVtnBT/eigFVC4SQfhSkRGs0sR28/Ucd8sfyyMM=; b=G3ROh199xkDZHkcfduRKAfmQrrEI0KQbNo8wHorsKKyX8yrJKv9HfAHobojg85+NIFELX8cBJgYiKRmMUUc2WdEWBmdnKn1620WBH6AJeZpagicvdnNS4J9FTp6tHRfljXqOJQ2wzZ96EMqNDrQnCJGchnHEk1xDHmLW3OI3Qww= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 1/2] arm/vgic: drop const attribute from gic_iomem_deny_access() Date: Wed, 28 Sep 2022 16:11:16 +0200 Message-Id: <20220928141117.51351-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220928141117.51351-1-roger.pau@citrix.com> References: <20220928141117.51351-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0143.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::35) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: 61b6f6ec-d389-4238-ea6b-08daa15b56a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c6+lnQxUiO3yJ5JyFvukG5b8aNRSdYfOiq59lfnLV+arBxI9GMGoF1PlI4UFWzKlOCRQ/0uKhpK7+/XQG+l90TWgLF/EdBbalDIfWYS/Mmd7eC+7kc6+vVm7TEFQIH0UC4k83CYAvAECa61lveWKgxmJ9ag8bXTl0aM4n9eboTUyQkCcU+IFG7QN6oQsLuoiv+41WZn1mNPBkseEPGREN9Y+o1+kErnWdZlhpu7XgtnVEvQoU/AjHFPVPHnpqUovjui/qW2D2+tmdoV+4oOntQRVLbF5G3fGxlI/Y/iNGqg4c3mXdEyUGwnavvCEONHZtMI1iiznO9ftGYtZqvzFJ0wooMms/ShK/NCeXCSAMmxXWXLrdyzDI2YvNKKf50qV0u5zVUKK8AW1e05jbVFGjT4lFBUcAkhaErKYV3kms40JdlaT4bLkk/gsBc2Cku3fHp8nyE4ZoDAz7xRZSNOSxvCfk8hFYOxO3eYmxTPepTPIojnGSU9S9A28e7UipRQX5OMV0qjaqnbxZfKfgo+SIp8ETyyZwwaiBXh3uz8F25gF+MyUoXbsUekOeOhNR64HUdFrRfYDzseCjQgcOrQE9R4mGDZii2nKli9eEM7dPQx5H3FXI85zjv3OSSQ2g29C+zIa9CqSEEbtt50Umx2cSv32zg7jSRFD/28HaL08iQweSTw78u0/34/m1jwkCB6hS8sV5WZh52mmzNAf5YnX6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(451199015)(82960400001)(6916009)(316002)(54906003)(5660300002)(8936002)(8676002)(36756003)(41300700001)(66556008)(66476007)(4326008)(2906002)(66946007)(6512007)(186003)(83380400001)(86362001)(2616005)(26005)(38100700002)(478600001)(1076003)(6486002)(6666004)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b05QYUk3SkZwZVdaK2pZd3M5NEZxWUpwSy9DVVFaaUNUWHJMckFuT3RobHJU?= =?utf-8?B?M1hBeG4zT1JBQndpcUZKK01udUFwS0hVSVNBV3Jtbnp1bFFJNnQ0N2NsaDl2?= =?utf-8?B?Uys1TGxXRCtMTk40L3dBR3ZyRXhIYXNjckluNk5RVTVWR2MxVWFlUGRKbk9r?= =?utf-8?B?Ly84allQL295ZmNzbUNoUmxzeDhocEp5aldVNjJMdlZ4bmtWTnBGZFdiNHpW?= =?utf-8?B?MTdBZ2JmbUhXUFJuWEJjNzZxUVNBVER1YXZwa0VRVUxSZWsvWGFIZXE2cEtH?= =?utf-8?B?aTBrTkdVUUVBWDRGcEtkc09nNXBoUGphVjlrbDVFZUVqUTc5ODl1Q0JwUHg0?= =?utf-8?B?OEMyTm4xb2tYYWF5UTJmNjlkSGlQaGVGL1dzejJSVllXVWxwZzgvV3dPemls?= =?utf-8?B?RytXVnJ1aTZzZjJJWm41YlFuQkhtOU11amNrR3VaT3JWNmQ1YVhuNHdJTGhj?= =?utf-8?B?Ri9SV3UxcHV2K1dSd1lOeGMxTWdOak9MdEo0MzljT1hhUlJoUGIzWnRQL2ov?= =?utf-8?B?M1l2UDJqQW8yWHNGTkNyaWhrdCtkOEZSeTVPVUVKS1BPcnhaT215dXNReXkw?= =?utf-8?B?Y1ZPUG9EWjQyVkpJaTRmY2gxSmZzVUd6RHpqQnRrcEF0YmlUYS9mU2UwT2Ry?= =?utf-8?B?Q1cySmt3NG1aaGZFVzl5blQ4MEFzcE9IeWpMdjNMYnNtbHFQSGNkK2x2bURI?= =?utf-8?B?cUFIYytDR1VRLzZNUmE0c3YreW5Fdk1MaC80TTY1NWhHNjNQSUN2b3ErWW9M?= =?utf-8?B?UW15VWg5YzY5alB2Y08reVFqRko5MUQydWFjQWhWSEhURXVOSjVaT0dMQStH?= =?utf-8?B?YTI2cmRtbjBOYmNnSGdEck13djQ3N2UwMTlva0JUOXBHZUpFOTkzOVBTSi9I?= =?utf-8?B?ODQ0eUlWQXUwTG1RSEM2MUQ1NkJ1UlNoTXFCUDJjWjNsY2QyT3d6MWhGU0ZD?= =?utf-8?B?RVZRemtDLzIwUVpvanpiN0ZEamkxSFMyVjlLbm4vV2VISktZZjVRWjdEZEZY?= =?utf-8?B?OUxjaDdnL0grU1BEcTVWVE9hMG5ESFhodzBXd0VpTjE1K21kMDhZanc0VEYw?= =?utf-8?B?K2NZemQyL01nVVhNUXVCZGJjaHFjaE9XU2Rodk5ZNWk3QVk1ZkhXZ050dEJq?= =?utf-8?B?TlE3S0NoOHczTHJXOEtMSXZab1BhN0l2aStBU2dJVk41b2kxTitPQzdtczM3?= =?utf-8?B?cThxc1liSG5mTnVFekFNYlk4VFBTNm9mOGlGZnorRmNYbDFxVHVvREpsWSth?= =?utf-8?B?Ym1HR0JHanAwYnV3SG14NWM0NWhoK3N1T3dzVmkyanFlVWhOdHdXeUt4UEN2?= =?utf-8?B?aDlITWtIci8wQ2Nqb2lWVXBRaTNMb1ZFT1RNdmgvSFJHQ2g4T3RHWVhDcUNW?= =?utf-8?B?TG9NTjA2UWZrZGFIeTdSVnlsNHFrSGo2TTE4SkFkN2IyUTVHV2ZXTmtVaWJi?= =?utf-8?B?V3BVUWRnZ1BYcUlPSWRLVlBnY0FEZ1ZyQkdsU2J6S3YySy9KeHJHRi9wVnNF?= =?utf-8?B?a21LMnIxcGx0OTNRazNlWlFaRVlkWWptVmEzUmpMZmZENDQ2Q2JVSkJFV0sw?= =?utf-8?B?ZHVBM0ZvK0dnTVJDSXplTFV4ZG9JV3h5MTZnT2MvNTNzbXZnMVBuR3hCQWVj?= =?utf-8?B?QlI3Sk1lUEVjcHhQM2tURjVqQTZtTnhVZnFYYXdJMDRSNWpGUDFqSzBEQVZK?= =?utf-8?B?RlJRb2FYZWpTNXU1aUFlUkY4bGVtL0tob2UxSHhDS3VwZTAyMjRwZVlDQ093?= =?utf-8?B?V2dsZEVzTC94K1ExcmlkVnJYNEhwUTlJdVIvQWF1R3FqZ1JXNXlMUEU0OGRJ?= =?utf-8?B?SHZ6eDMvcVF6eHpmdUp6OVcyODI3UjhCL1BhTkF5VnVVZ0lkdGNYcXF1RzJX?= =?utf-8?B?cEhpWXY5UEJnK1gwRmF6c0kyK0lxWkVLaytvNjZvZmptT0tpb0hoZ2NaMUVq?= =?utf-8?B?VUY0OWtmUGJnb0pOTkI4VzVxbzhHdTYxT1BpemdVT0FuZlNNeWNlUjZSYkVl?= =?utf-8?B?MlRZdDBBZHlTUUtxcWFFUzR2OEk1K0gxc1ZXVlZpdXFNTjlBMkNFUEE2WkpJ?= =?utf-8?B?UnE4WUNYVWNqYVloMUMzL09DK0V6V3BKV2NEOHJpQ1pmUkpZRXRSL2hTTFMx?= =?utf-8?B?Wi81NHZoVGFsNVNyakswZ0lpMUdqUFo5OHJZemlidytVNGsrSld4cFR4MU5T?= =?utf-8?B?SWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61b6f6ec-d389-4238-ea6b-08daa15b56a8 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 14:11:31.2736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cvWCB8cyPgwk8DnmZ7u45+4WZO5WRfmFMcw8h/4+OtvU47L0b5P/FiVjWF6MuobRIK8tGBKgHIXbic+/8A4wmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5596 While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné --- xen/arch/arm/gic-v2.c | 2 +- xen/arch/arm/gic-v3.c | 2 +- xen/arch/arm/gic.c | 2 +- xen/arch/arm/include/asm/gic.h | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index bd773bcc67..ae5bd8e95f 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1083,7 +1083,7 @@ static void __init gicv2_dt_init(void) gicv2_extension_dt_init(node); } -static int gicv2_iomem_deny_access(const struct domain *d) +static int gicv2_iomem_deny_access(struct domain *d) { int rc; unsigned long mfn, nr; diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 64b36cec25..018fa0dfa0 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1424,7 +1424,7 @@ static void __init gicv3_dt_init(void) &vbase, &vsize); } -static int gicv3_iomem_deny_access(const struct domain *d) +static int gicv3_iomem_deny_access(struct domain *d) { int rc, i; unsigned long mfn, nr; diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 3b0331b538..9b82325442 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -462,7 +462,7 @@ unsigned long gic_get_hwdom_madt_size(const struct domain *d) } #endif -int gic_iomem_deny_access(const struct domain *d) +int gic_iomem_deny_access(struct domain *d) { return gic_hw_ops->iomem_deny_access(d); } diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h index 3692fae393..76e3fa5dc4 100644 --- a/xen/arch/arm/include/asm/gic.h +++ b/xen/arch/arm/include/asm/gic.h @@ -392,7 +392,7 @@ struct gic_hw_operations { /* Map extra GIC MMIO, irqs and other hw stuffs to the hardware domain. */ int (*map_hwdom_extra_mappings)(struct domain *d); /* Deny access to GIC regions */ - int (*iomem_deny_access)(const struct domain *d); + int (*iomem_deny_access)(struct domain *d); /* Handle LPIs, which require special handling */ void (*do_LPI)(unsigned int lpi); }; @@ -449,7 +449,7 @@ unsigned long gic_get_hwdom_madt_size(const struct domain *d); #endif int gic_map_hwdom_extra_mappings(struct domain *d); -int gic_iomem_deny_access(const struct domain *d); +int gic_iomem_deny_access(struct domain *d); #endif /* __ASSEMBLY__ */ #endif -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:26:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:26:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413381.656987 (Exim 4.92) (envelope-from ) id 1odY0b-0003sN-4B; Wed, 28 Sep 2022 14:25:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413381.656987; Wed, 28 Sep 2022 14:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY0b-0003sG-1d; Wed, 28 Sep 2022 14:25:57 +0000 Received: by outflank-mailman (input) for mailman id 413381; Wed, 28 Sep 2022 14:25:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY0Z-0003s6-TE; Wed, 28 Sep 2022 14:25:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY0Z-0007su-RV; Wed, 28 Sep 2022 14:25:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY0Z-0005wV-8h; Wed, 28 Sep 2022 14:25:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odY0Z-0002Oc-8I; Wed, 28 Sep 2022 14:25:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8BZxG4WNtAsBjIeUJuS7G8z3yv9fA3Nxmo59n/PDlZ4=; b=Uzeb+3qnAEsdotyF6QGv2r6ryw CLtGOQwsQDIb3EDyursB2Fc4cFmOJKQeUuDkMhSevRWMpiqINUiUljdZb4IeVc1Vwaemh/XmkplUI HXfesz/90+nqblPlQyz21WvA2hWOQFdcIg6qR+U7HxJj7CG8ZTtaltm8mlKuxyQKgPtc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173354: all pass - PUSHED X-Osstest-Versions-This: ovmf=3c0d567c3719675b9d8ecf07c31706d96467e31b X-Osstest-Versions-That: ovmf=f4d539007c706ad9a563f368720edf0920da925d From: osstest service owner Date: Wed, 28 Sep 2022 14:25:55 +0000 flight 173354 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173354/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3c0d567c3719675b9d8ecf07c31706d96467e31b baseline version: ovmf f4d539007c706ad9a563f368720edf0920da925d Last test of basis 173341 2022-09-28 00:40:28 Z 0 days Testing same since 173354 2022-09-28 10:12:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: VictorX Hsu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f4d539007c..3c0d567c37 3c0d567c3719675b9d8ecf07c31706d96467e31b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:26:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:26:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413387.656999 (Exim 4.92) (envelope-from ) id 1odY1T-0004Ou-E2; Wed, 28 Sep 2022 14:26:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413387.656999; Wed, 28 Sep 2022 14:26:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY1T-0004Ol-B9; Wed, 28 Sep 2022 14:26:51 +0000 Received: by outflank-mailman (input) for mailman id 413387; Wed, 28 Sep 2022 14:26:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY1R-0004Bv-HA for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 14:26:49 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00079.outbound.protection.outlook.com [40.107.0.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b11e39e-3f39-11ed-9374-c1cf23e5d27e; Wed, 28 Sep 2022 16:26:30 +0200 (CEST) Received: from DU2P250CA0008.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::13) by AS2PR08MB9125.eurprd08.prod.outlook.com (2603:10a6:20b:5fc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 14:26:46 +0000 Received: from DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::5) by DU2P250CA0008.outlook.office365.com (2603:10a6:10:231::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 14:26:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT064.mail.protection.outlook.com (100.127.143.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 14:26:45 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Wed, 28 Sep 2022 14:26:45 +0000 Received: from c6bf16105476.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49989FC2-0D4F-4D11-9A9B-07E5DB09BBB6.1; Wed, 28 Sep 2022 14:26:39 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c6bf16105476.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Sep 2022 14:26:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB9713.eurprd08.prod.outlook.com (2603:10a6:20b:607::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 14:26:37 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 14:26:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b11e39e-3f39-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VENKByYEBY7fRRI1GREQLI9Jp2+4IxU4hBpOjGrpQ36Xghflgr9L5Iwcwe91gIOm0/mC7fgZUv8lYxsfr8K8zDu2IbspNU12ICH3+P6lR5nWpg6trwULBnXOBBdtnk4F/F/76B6v94g/1ocounyuvHHBNOV/BMSmQjkcu1cZloQDEYXvmI8/NUWHaNxVCasFFhVvEN1QYwYAW933uzUdRYzJC0iaDXHdiwwhhxb3y2gfBaQkmaS9yGzvbYAYkoHiV44XCdk9MZHeZgc1RYK9OngWc8oKi5wx2WDtsQmHuf7uKEA5PU0p5XS4sxwDsGbgKbIkUZhZNLlmquJc8MUgtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dut5FZxIQvOieyniQrkTETxjPPlI4cVyzE43JJNsBT4=; b=JANtpLAICSxAY6YP3b3tSg8kSRv/jpOVU+fcC0wvTVaGwFX/VKvlsI7R0bmCy0wvKwpwtx1eJYZgcu7VSZinsHLtS6X5RXDS2TjWZ0qUR6E9VPy1jKWiO6p87yn4aGHV97haamRGGAwAeGNZnJnO+UT5tZ8TYLsBTwisuMzprXS9gVRhSHymWKTC1caUlHrkxveNGbFE4RQ0OviRN/jw4fgC+IkHYIGBuYwEJbdqz1e6/iwC9sLue3ocpLtkrQDGOL69l5n1J6e+v3dlMOLH/AwFMTQZgkGDleQbuCyUf6Ns4ORCXuwbXnOR28KbtMUa/P4ipG5nd+7pjsSQ7ZUXmg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dut5FZxIQvOieyniQrkTETxjPPlI4cVyzE43JJNsBT4=; b=rPTNSth6GY3vHWHQletMXRCdM1qRuNuVaf0E2iEI0zBkHPLPgcmh0CIi67og3S51o6fmn7ilTmlaXHj7V7L32UYh+miawa8DTES/f3cwp8hHZMIHHArsNt+TRbm6aThQ6GdeMUvt1lO6i1/iKel8oUDe2NNhWlv2SQ4eleNnVqU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e1c0f0b4891abb61 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NYvwbJFIj1KY73tUvNTYQaxsfZ41uq9SYCFzZJu2OREXQplyKAbsCHGjKuXiOai5XESg1rL62eg6NQMbEVgsBiiMvgLpSRXt5e50+lAVI5z7+uWr77PzTY6GZ7lOzo5sA2+zAZXOH62gvMqpty3RaFrNE5zOZ8CO5ToQj0E3SQQ3vG7RpzZh0WkvsbsA5tdaUdRrf2JyggVX+uiEHQjtkceGvXpkRtmFw/h1TtSSOCGj9kNmC6jvX2TLznWX93F/dFz1a8ecZiZaGZg/c/2hEQ51shmY9evzI2nkkbShg+bB0l7aslZL4csBzFS/PlLBH8+m3jyGGo+2Srf6oQZOMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dut5FZxIQvOieyniQrkTETxjPPlI4cVyzE43JJNsBT4=; b=SHLWbA3PRDk2cqlwBHIK0bviLdDXyLTpJzfbJJWCyDTrgJooa4UT11M1+LAVFIK52CrHIr26fluhNK99rG6j4K9m8BagNTf9JnzdALGLeP5S/Pm2Wmt61ta3J053g16iYUsl2CGbP1x9KZRTl/xLZF1O7cEYjpf/bbWSoWVt0EZ1tWxMQm6lEyRwDVx62wE7yelUYGu4f54vF6oPddFp1fU8KoDWh9TiTfVHgDH1KocYGFhHmPgaop/G0yA1KdjRGIv9mTZPYcodwODPCVRraAi5sCczODKAvtPJ3LouW1yFn3AXQD45F0w8MscEa4OqmI/7LNNSO3o/Yv/XO28wOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dut5FZxIQvOieyniQrkTETxjPPlI4cVyzE43JJNsBT4=; b=rPTNSth6GY3vHWHQletMXRCdM1qRuNuVaf0E2iEI0zBkHPLPgcmh0CIi67og3S51o6fmn7ilTmlaXHj7V7L32UYh+miawa8DTES/f3cwp8hHZMIHHArsNt+TRbm6aThQ6GdeMUvt1lO6i1/iKel8oUDe2NNhWlv2SQ4eleNnVqU= From: Bertrand Marquis To: Roger Pau Monne CC: Xen developer discussion , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 1/2] arm/vgic: drop const attribute from gic_iomem_deny_access() Thread-Topic: [PATCH v3 1/2] arm/vgic: drop const attribute from gic_iomem_deny_access() Thread-Index: AQHY00Q8lAoIzTsqYkip0fWlnJ+tE6305hgA Date: Wed, 28 Sep 2022 14:26:37 +0000 Message-ID: <6FDEAC4F-BD2A-4995-9D22-BD3356720269@arm.com> References: <20220928141117.51351-1-roger.pau@citrix.com> <20220928141117.51351-2-roger.pau@citrix.com> In-Reply-To: <20220928141117.51351-2-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB9713:EE_|DBAEUR03FT064:EE_|AS2PR08MB9125:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fa44923-8d26-4c69-c50b-08daa15d78bd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qOS/mbwazMly9Guw1nTLk7XOPHgBjrHtbrJOktV7qpekTYefQTRxbv6WVMWg0SxcJkmTZQJbpBUtXvSp0ec470g9D5rnQ0V1U2BtdJ1LeZq5ZjIUSaVYepujkoFA03AwyjHC97Sbt/uxtoZE82Ttw7/MmsPuHwldLK8nyM0zxHNvao7lSVDFsTdlG7dL0PrRfn5BFBZf8A9jI/e+7/TG7/JHNrDdnZlyiHNYhIGWsQs7y5+EDyW+8yi6BozMFCCInmL0iMNje2tbzEy4XTIWh65+DSMHHgjqnqSHT70yG4bs8Dzu4lD5uWHTVn5CigCPg/T5jLyD+gS2rp7YGKQw03ELPTI7p0lpWGOwugWOG7VSRXEQ0gyRT72T1prawzZ8kZK67ecZhVxVDqxM9r76WXynIWjtHiRbdrnmiM37EPSiNFmasrgdHa9IC9dc6yHkn0ty4qawZlPOtUwORNl6QqVCiWAirJCdJ7PSY7etu/gm6T9NJfkPvJZi4ImJnMxSprfddQ3kBbAbCq0tbfawOb9Ox8ZzGoeTDFIZZUf3qH9oKndAAF2iMs8nwbP7P53Z86wjO2IqigjKUSKTRIBjJFHltAUwxDN3KaD2/FAhMzpkZY6xUDh9hLl91YXPCBwmJ2zZRNcPM3XKjPIeCBUqL9uNq84jlA8sGV2qZ01HGYSNBPm222fn+8hS9uwIfAaZV057a7lgWEGDkUvDOwbdIwFNYN9MW8a23QWQIHnJtnM3aoUecL38bwCYVx46qfwKdGSGrv0cwfCg3GPuhx9o+nU9IpdUwNdlrsY1NwUDYqc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(53546011)(26005)(6512007)(6506007)(38100700002)(8676002)(122000001)(54906003)(6916009)(76116006)(66556008)(66946007)(71200400001)(91956017)(66476007)(66446008)(64756008)(86362001)(316002)(38070700005)(36756003)(33656002)(4326008)(478600001)(2616005)(186003)(8936002)(6486002)(83380400001)(41300700001)(2906002)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9713 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6d11d6f8-28ee-4074-454e-08daa15d73f1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6YqQOP1mAt+/BQYOLL9cBI8aVRBzIgxNL+V59hI3nVprxUPTcjIVhOyr/MnTHt/kHSSUTvnBop0M7yqPVx+QPhN85Sf2f9xLKZ0XGJgM23+IZRKwoqdTnxQ0cnomvVap6VrWCabAsOquhlWhfIwqZKpSaWxZy1K+m9Ue/11e1CXwjaC1Wmc5QOSoAToovv8Ok1oH6U9WKIT00TFkpFM12UxVGvLC4mdZ6FgoiS9WoXlGfdA+9N17sBOWyKg0DU8Yupp0Woz0iaDA85WOINcHxULxBQKsJIDG2ODTb7ylm+FJVIZMMdOTbSE2s517bMCq5D1L22y6lQ0LrjuczEuEPtoAht6Bjd8EZEOXKKyDd/whTRm6YnbpVdyq51SFJnEgXToPP9PoWkY1gymME2fLI9zfB285Y9D2lnrZGFXIIUQw43vgkRA7Z/5px0mZUBU3VyJ7Mx1UKchG6rvhTh0eW2AKY/e/pEX+6te6ujlSHf6xJwcIePgNvwChZjb1UMH0TV5AQw1tDyWJRyE6bU4L4k4wXrnUUBewd5L0ck3/R4hlPVrqNkJc4iMht2vubk9y7eZiv8H3KMfQQCNcEbfWJKZNazGFgcUXngoYyYt6RNjL8hHKb8EsoHCOPcmBFLOoo0lURUnOiKGjB8VVtZ0pmkVmJ93UqMOUvNbKFgcrTgyqeKMipmnNfDeeazHFfKtGQez1w61N3A9eI/KUBNBJv1NCsi4lwOR59tlCLj9Il8pwWRhx9HYs5deqkEP112/RjGVZSwMARVVGlo20dPXkbw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(2616005)(186003)(47076005)(336012)(82740400003)(81166007)(356005)(36860700001)(6862004)(40480700001)(8936002)(5660300002)(41300700001)(2906002)(82310400005)(40460700003)(478600001)(6486002)(26005)(6512007)(6506007)(70586007)(107886003)(70206006)(4326008)(53546011)(8676002)(316002)(54906003)(36756003)(33656002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 14:26:45.5923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6fa44923-8d26-4c69-c50b-08daa15d78bd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9125 SGkgUm9nZXIsDQoNCj4gT24gMjggU2VwIDIwMjIsIGF0IDE2OjExLCBSb2dlciBQYXUgTW9ubmUg PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IFdoaWxlIGNvcnJlY3QgZnJvbSBh IGNvZGUgcG9pbnQgb2YgdmlldywgdGhlIHVzYWdlIG9mIHRoZSBjb25zdA0KPiBhdHRyaWJ1dGUg Zm9yIHRoZSBkb21haW4gcGFyYW1ldGVyIG9mIGdpY19pb21lbV9kZW55X2FjY2VzcygpIGlzIGF0 DQo+IGxlYXN0IHBhcnRpYWxseSBib2d1cy4gIENvbnRlbnRzIG9mIHRoZSBkb21haW4gc3RydWN0 dXJlICh0aGUgaW9tZW0NCj4gcmFuZ2VzZXQpIGlzIG1vZGlmaWVkIGJ5IHRoZSBmdW5jdGlvbi4g IFN1Y2ggbW9kaWZpY2F0aW9ucyBzdWNjZWVkDQo+IGJlY2F1c2UgcmlnaHQgbm93IHRoZSBpb21l bSByYW5nZXNldCBpcyBhbGxvY2F0ZWQgc2VwYXJhdGVseSBmcm9tDQo+IHN0cnVjdCBkb21haW4s IGFuZCBoZW5jZSBpcyBub3Qgc3ViamVjdCB0byB0aGUgY29uc3RuZXNzIG9mIHN0cnVjdA0KPiBk b21haW4uDQo+IA0KPiBBbWVuZCB0aGlzIGJ5IGRyb3BwaW5nIHRoZSBjb25zdCBhdHRyaWJ1dGUg ZnJvbSB0aGUgZnVuY3Rpb24NCj4gcGFyYW1ldGVyLg0KPiANCj4gVGhpcyBpcyByZXF1aXJlZCBi eSBmdXJ0aGVyIGNoYW5nZXMgdGhhdCB3aWxsIGNvbnZlcnQNCj4gaW9tZW1fe3Blcm1pdCxkZW55 fV9hY2Nlc3MgaW50byBhIGZ1bmN0aW9uLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1 IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQpSZXZpZXdlZC1ieTogQmVydHJhbmQgTWFy cXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4g LS0tDQo+IHhlbi9hcmNoL2FybS9naWMtdjIuYyAgICAgICAgICB8IDIgKy0NCj4geGVuL2FyY2gv YXJtL2dpYy12My5jICAgICAgICAgIHwgMiArLQ0KPiB4ZW4vYXJjaC9hcm0vZ2ljLmMgICAgICAg ICAgICAgfCAyICstDQo+IHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9naWMuaCB8IDQgKystLQ0K PiA0IGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZ2ljLXYyLmMgYi94ZW4vYXJjaC9hcm0vZ2ljLXYy LmMNCj4gaW5kZXggYmQ3NzNiY2M2Ny4uYWU1YmQ4ZTk1ZiAxMDA2NDQNCj4gLS0tIGEveGVuL2Fy Y2gvYXJtL2dpYy12Mi5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9naWMtdjIuYw0KPiBAQCAtMTA4 Myw3ICsxMDgzLDcgQEAgc3RhdGljIHZvaWQgX19pbml0IGdpY3YyX2R0X2luaXQodm9pZCkNCj4g ICAgIGdpY3YyX2V4dGVuc2lvbl9kdF9pbml0KG5vZGUpOw0KPiB9DQo+IA0KPiAtc3RhdGljIGlu dCBnaWN2Ml9pb21lbV9kZW55X2FjY2Vzcyhjb25zdCBzdHJ1Y3QgZG9tYWluICpkKQ0KPiArc3Rh dGljIGludCBnaWN2Ml9pb21lbV9kZW55X2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpkKQ0KPiB7DQo+ ICAgICBpbnQgcmM7DQo+ICAgICB1bnNpZ25lZCBsb25nIG1mbiwgbnI7DQo+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC9hcm0vZ2ljLXYzLmMgYi94ZW4vYXJjaC9hcm0vZ2ljLXYzLmMNCj4gaW5kZXgg NjRiMzZjZWMyNS4uMDE4ZmEwZGZhMCAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL2dpYy12 My5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9naWMtdjMuYw0KPiBAQCAtMTQyNCw3ICsxNDI0LDcg QEAgc3RhdGljIHZvaWQgX19pbml0IGdpY3YzX2R0X2luaXQodm9pZCkNCj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJnZiYXNlLCAmdnNpemUpOw0KPiB9DQo+IA0KPiAtc3RhdGljIGlu dCBnaWN2M19pb21lbV9kZW55X2FjY2Vzcyhjb25zdCBzdHJ1Y3QgZG9tYWluICpkKQ0KPiArc3Rh dGljIGludCBnaWN2M19pb21lbV9kZW55X2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpkKQ0KPiB7DQo+ ICAgICBpbnQgcmMsIGk7DQo+ICAgICB1bnNpZ25lZCBsb25nIG1mbiwgbnI7DQo+IGRpZmYgLS1n aXQgYS94ZW4vYXJjaC9hcm0vZ2ljLmMgYi94ZW4vYXJjaC9hcm0vZ2ljLmMNCj4gaW5kZXggM2Iw MzMxYjUzOC4uOWI4MjMyNTQ0MiAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL2dpYy5jDQo+ ICsrKyBiL3hlbi9hcmNoL2FybS9naWMuYw0KPiBAQCAtNDYyLDcgKzQ2Miw3IEBAIHVuc2lnbmVk IGxvbmcgZ2ljX2dldF9od2RvbV9tYWR0X3NpemUoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCkNCj4g fQ0KPiAjZW5kaWYNCj4gDQo+IC1pbnQgZ2ljX2lvbWVtX2RlbnlfYWNjZXNzKGNvbnN0IHN0cnVj dCBkb21haW4gKmQpDQo+ICtpbnQgZ2ljX2lvbWVtX2RlbnlfYWNjZXNzKHN0cnVjdCBkb21haW4g KmQpDQo+IHsNCj4gICAgIHJldHVybiBnaWNfaHdfb3BzLT5pb21lbV9kZW55X2FjY2VzcyhkKTsN Cj4gfQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2dpYy5oIGIveGVu L2FyY2gvYXJtL2luY2x1ZGUvYXNtL2dpYy5oDQo+IGluZGV4IDM2OTJmYWUzOTMuLjc2ZTNmYTVk YzQgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9naWMuaA0KPiArKysg Yi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZ2ljLmgNCj4gQEAgLTM5Miw3ICszOTIsNyBAQCBz dHJ1Y3QgZ2ljX2h3X29wZXJhdGlvbnMgew0KPiAgICAgLyogTWFwIGV4dHJhIEdJQyBNTUlPLCBp cnFzIGFuZCBvdGhlciBodyBzdHVmZnMgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbi4gKi8NCj4gICAg IGludCAoKm1hcF9od2RvbV9leHRyYV9tYXBwaW5ncykoc3RydWN0IGRvbWFpbiAqZCk7DQo+ICAg ICAvKiBEZW55IGFjY2VzcyB0byBHSUMgcmVnaW9ucyAqLw0KPiAtICAgIGludCAoKmlvbWVtX2Rl bnlfYWNjZXNzKShjb25zdCBzdHJ1Y3QgZG9tYWluICpkKTsNCj4gKyAgICBpbnQgKCppb21lbV9k ZW55X2FjY2Vzcykoc3RydWN0IGRvbWFpbiAqZCk7DQo+ICAgICAvKiBIYW5kbGUgTFBJcywgd2hp Y2ggcmVxdWlyZSBzcGVjaWFsIGhhbmRsaW5nICovDQo+ICAgICB2b2lkICgqZG9fTFBJKSh1bnNp Z25lZCBpbnQgbHBpKTsNCj4gfTsNCj4gQEAgLTQ0OSw3ICs0NDksNyBAQCB1bnNpZ25lZCBsb25n IGdpY19nZXRfaHdkb21fbWFkdF9zaXplKGNvbnN0IHN0cnVjdCBkb21haW4gKmQpOw0KPiAjZW5k aWYNCj4gDQo+IGludCBnaWNfbWFwX2h3ZG9tX2V4dHJhX21hcHBpbmdzKHN0cnVjdCBkb21haW4g KmQpOw0KPiAtaW50IGdpY19pb21lbV9kZW55X2FjY2Vzcyhjb25zdCBzdHJ1Y3QgZG9tYWluICpk KTsNCj4gK2ludCBnaWNfaW9tZW1fZGVueV9hY2Nlc3Moc3RydWN0IGRvbWFpbiAqZCk7DQo+IA0K PiAjZW5kaWYgLyogX19BU1NFTUJMWV9fICovDQo+ICNlbmRpZg0KPiAtLSANCj4gMi4zNy4zDQo+ IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:27:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:27:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413395.657010 (Exim 4.92) (envelope-from ) id 1odY2L-00051Y-Sf; Wed, 28 Sep 2022 14:27:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413395.657010; Wed, 28 Sep 2022 14:27:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY2L-00051R-Px; Wed, 28 Sep 2022 14:27:45 +0000 Received: by outflank-mailman (input) for mailman id 413395; Wed, 28 Sep 2022 14:27:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odY2K-0004v7-3F for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 14:27:44 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b586b20f-3f39-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 16:27:42 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Sep 2022 10:27:39 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN9PR03MB6105.namprd03.prod.outlook.com (2603:10b6:408:11a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 14:27:37 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 14:27:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b586b20f-3f39-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664375262; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Rhm3ITndz6MUI9g408ycInIprXWV5pr+9oDI2U4ykcM=; b=P0I4fokH3ygEWSts/7Q9LJzhiCzZcjdZZDv3j44YJ18kgMd9Bh/F/5G6 TzoIupU41NVM2rKLVQqc/oC42s0Lcu+plEwtAPybMUEPU3WyhigHOXuyC UEnr2ZliEagL45PXWRT4nxwLsw2qfMA8BrQdTQrEGrds8nL5gtGocejaT Y=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 81542656 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3ApxagTK2qOeT2scFI8/bDix16xaGdEXBdZcB5h?= =?us-ascii?q?TgEjSJ0oekyFxJjW3jMTdpVwLd93lHzZH0GQp7dh363NtgY4IeonlOzSydJq?= =?us-ascii?q?kFIdFgxvvF6P27LQMdqxhOGCWDKLHs+PL+iGdXUOwyzgpN9M1dKpV0qOwrp4?= =?us-ascii?q?+92L95NYKqU3o7LFLiOAhM16n+vet/sykZphI5LxjMAUSkF8wd3CjK6+l8aR?= =?us-ascii?q?1/gF4ogsHjoR4cswgkxh4Ngo8tQH4CcDBg59I7b/OS3hU1X0k+48bJXIeIze?= =?us-ascii?q?KNGXUr+nshSwtCULpDB80eNE4iM/oLf893ylNAQF07BLE6cbDpvzJWdLmNJ5?= =?us-ascii?q?UorqQWEkvHvGQIZxTQuFh5Geh3qPZ6zY531GV2QSx9UCGQMb80fMLrtmFwqO?= =?us-ascii?q?j7OiEyT4Gwbz68Mtt4uXNyijw9YhOeag1SP2snBUwHSinU/PIYFrHlS+M25T?= =?us-ascii?q?RSCea3gqma/Y7AdRvW02+Zm059WaPCaQgVgqSz0fNgHcbSgDs7qOqfQ/R9Yu?= =?us-ascii?q?Kuw9Bae7YINczaz0zv34t2i54XTm6YpopjET75ty2EKgFDUp16PrhpiobHXJ?= =?us-ascii?q?+vL15jdKii7/S69matWQlg2FJR42bN6zLBDXwnNk5gWFcOFEODpiAiCJZjQy?= =?us-ascii?q?Ge3oXEkt3fowjr0+qJ9cLddXOKuznXyhcRm7V2CPsQPmmDEtlTXAxfF3wNi3?= =?us-ascii?q?OgdQ5RfOqMcPA1irBAd0t0/6EKcK2uKyq+H/p8VUvjFysioaUixN9SlE4ZeF?= =?us-ascii?q?cZs+qN/zAEf8dG0Ql37y8PEpOBn4G2E6I9N8/NGeJQ9zgJEnM2Fjvhm6GR97?= =?us-ascii?q?T3xDcR15/oQxKxS5aYxyEjyFMfIYSC1EMBZJiokA+boANlF+ba7eLMb8repg?= =?us-ascii?q?90H5NUCPcF4uv9kqAhG1GcKM16GL1vPGR0SSJDgkshoToCcUM+Qm4wFhKlpI?= =?us-ascii?q?9AotwcYvh65gOj/9Ei2FPtLlC5I3ig+T56hNQQ7BhtBEsXURwaJgrKH0IELw?= =?us-ascii?q?smFwD/1SYJjUfSrFDWUyF05XPwH1s3Muy/q9Gggt4Pe9vQKMlFfjns7zX05u?= =?us-ascii?q?jKVsmyChg426OCwBuRJ/q9KY5qBrgrJF4cONTq0lWHEqgw3nk+TMpxzlPd2i?= =?us-ascii?q?knPwsF4FM82Mb09uQUNPGymMv/0eJMR0o+O7F67F7Fs8GlDUI2PeHG2hAr8k?= =?us-ascii?q?E6X/xBt0aZipJrNi1p/NtYk9z+HUaVBvIHBwV58SPDy84uNSafZScDoDbh8P?= =?us-ascii?q?W4f0/xr+4j29tsWXVmBLZnBgMf3f3zNdo2UwEcJ3LRhV00eQcoZQZ2d49KwL?= =?us-ascii?q?usZQaT+RNxYrt8Jz3wqWulvmdHWCkq2gquTHlcSxhaci79Zri8yoJsZwPWfK?= =?us-ascii?q?so+JNYS0uhtzo2v2JjzbH/7r0SzCxc3A5VM5uh8SxMzsWYzU0laRZi24/Xih?= =?us-ascii?q?SSosyW9SJMo1lDkD44N8HhQbMgxOe1sUg9zt/7Qs5+VyPwqLKBUqg7i6cLK2?= =?us-ascii?q?8E4hudANEt+uDv0lLJDjEl4GbYWOamwuTmVZ5KsiDSJnCiNUmRc1FQ59qzUx?= =?us-ascii?q?b4EaqdB2yoktxRz/it91EwSpmt6rZGtl0GvSpYWGI4lXUJYHkTWnvAoUv5wT?= =?us-ascii?q?tdeSL31CvTAITvQhNE93h47HhdZsLondOic5//qRRESEBpR8xetS6Evrawnk?= =?us-ascii?q?VfYCDN4iRerTkdwEwt+GjjMDqRWSSkhnqE6a58irmODGnjX20p8OS4FYC5GU?= =?us-ascii?q?vgWjYunIpf7FJzCgj32Y0gOIXr2w3HefO5IxUU5XpKqi9tyPDM87oWKY1RQ5?= =?us-ascii?q?TleKOdvWcJjAmOddSTj6RkkefjaaKnUZ0ungZE3//MAwRJpsn4qnw1liTy1K?= =?us-ascii?q?2uyFDzYTfo8GYFceWYZaQ5mAPpgOBmHK8qqlxyScisEcYhtNMqplts4KWZNS?= =?us-ascii?q?+9s7jipeveZ8R0Z6FW290tUsk0E9hI5u/cI67BpWHm5mPX+tXvamxDufezz9?= =?us-ascii?q?CX4lLbcsr+D7KYJKSpIsgRHY/tfY5Cr00ut191kuXHXfRl53/oJAO9HWGVV7?= =?us-ascii?q?1bYqe4aeVYjuVlyX2n5MpuZMCQYT0BG1X+Bd3wB7exG5FjjSZYLAOaEMGznb?= =?us-ascii?q?vrHVzzitdQ/FCbRgrYCoRU+j1GkagUmt8PJdtSGhnE77NW2XWy4lw+e4SDKk?= =?us-ascii?q?8rjwb2rO2f7vE3uzmhrFeVBwmHWwVdMN/SEg4usZWhO1WyvqGLCKtvR9CiCj?= =?us-ascii?q?ohGKRrqtw7H/US4xtnt5GoTeM3ArLBqWn2/YP5Jo9upgQ/Jjt6C28LzDIb78?= =?us-ascii?q?+oKpInckyI/zMeVMJeaelWMICvfM/PDI8Akc/hDRt+L8m9THWBLYSSKSVtH4?= =?us-ascii?q?f4o97Ua1kKbudjxFT4BpNKycBshT3x9N/Mn+ZmHHkcKPexy39elbDiqh5eaA?= =?us-ascii?q?IJeLLyF8EnGY6sacscXbUjJL+5drQzBDN2uPviNlJT69Ab/i5u1ElrrZBwLe?= =?us-ascii?q?Y+TOtnAbrqvNBxnotpYPpiMiOGbaZQqGhywF+KfcBXf3PbFlIgDix8=3D?= X-IronPort-AV: E=Sophos;i="5.93,352,1654574400"; d="scan'208";a="81542656" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjQwXbgShy9SXyMgk+kNv7yYzo3I7AUd8O4fAYPhzay5r2xp785XQCgeQq1YNv16k5+3YsKyPTCjbLBUfnNFmh0nxObJ1TnoaN0jH3o7QCK16xrZCVJub3h6WdCNiQMoI5UduDzerB5aKdJ2itGD8sUDTybRerCt7X/CxWG+0iwB5l2OR1n3ZS46FJSS9XrKNw947nTlBONNoTb5cGhry4GT5cq6RoiQWvKlA++a9tbnx/hM9MMXCcOk2T/IXJVAhliWiVhXwKD6ioL2bzmzbSxy924EtjExsboujBguTUR9PzUKu1xYCt8IZJu2dyW7WZpF0GjMvZ/91sCQFnJ9AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yXpmNzie8LeUEtzFuMno5KC9eU6z0SNVvIdOvNWQ64=; b=GtX4FTyqem+Rl3AW0ku1/KizG15wtYVpj6b+FP7OWcqPBe1Z33WphzZmE5Rey78D9XKNlnWgBUOlGbsGJO5ZryGOrsE+upwhlTUkEJBJUaRZ6zzewNqAuCpbpcSbKfz5LGR8HyUA/xwvcaaUCOi3wVirxK9l29eUXxLyEY8twsFJAybUhf8NYLJNDpC0UQmyapM+vh+gnsv6swJKHhhj9z1uqgrrcGTNPBvF3b66OkeSy5h6wKyXDJiKE5tEPQ1KgrGZBYBkVwUwZpCsX4sQB5VxU6CakAB2cgnmwcjuAvKadZ128yXTsOrdMwsNFOA87WPcI+LVrSV2vopXucWPEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4yXpmNzie8LeUEtzFuMno5KC9eU6z0SNVvIdOvNWQ64=; b=pcV9vHCZYxou1dZWu+XBJh1Zzgs8/INgpF4hPI9oA14ds80SmMzmqKIskQCWFYIwoClGG+k6q8xxqpef6kE+7ERnrTBHHLQ7tg7oEvD6zkPB/+yLe4mpM+sLwtq2SPRzSM+m6lwBeot3/V1+PJybO8LcC1LHF7yoa6GWywDfg8c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 28 Sep 2022 16:27:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH RFC] rangeset: mark a few functions pure Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0560.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6105:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ca38c9a-7fa2-4c7d-f6fe-08daa15d9715 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4SfpfvASWW/R5/c2aIzV2ntUsBFnUYr2uKuLlda0eLpKUa7if0mptpUMWniL5klfLbhtz4cjfQm7uuNWQrX6Zmw7hIO/GX+qjNlDy8N6Ygtnp+MQkvaibB16w0nyez/pEvdq5J4ats78yoRtJw0zuPbVUgUQK4VH7YKMyIlb/vbd1Igo66BKhUPwLa6XBWySc+qfjmgVKiG00QcGEVwpVHlsKQa6V75Xnz99jS5/pd4U8bYoPihfm0K4evizueO+tHM7m+ryvqvyJOuO6j1Jcayc94omsYmym/7u6fqDmJ0C052WSlU0buCulpHuzYn0VUefb/SJ8c0TFzzwCSwfycoPIcB6R/eK+MDU9q3vVTAG+FmBwuGDouipZjtOLQipQI51c8451QGm/Y86C63YKAFBxf4vdbquv17K+tsm3EnNs5Z9N9f8/w+/JvgNSZeEMU3X1ni64nwCQOxol2znT5905d16i5rOciaWsRgbDFcr+56KVj5vEcmw4VouwQOSytgvDuM3puLkGhF/IHIGmQU3MyE+1Z8I+z36eocZWAZg8vnzQU9+Mh5CMipB3c3iYLVxpBPja1uyzx95uBAlxJ/rOWzbve2yFfqr/nkwjIhuLKwMphLVTWzrsQXkbY0wMBp2wUwnfhbcWOQ59Q0kBm7CFX/J5ns/GIdU+xdxG/7P3CeljbGG3D7XX620jCxCMJDhc64vaNeDx9r1h9cGjA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199015)(6506007)(9686003)(26005)(6512007)(38100700002)(8676002)(82960400001)(316002)(54906003)(4326008)(66946007)(66476007)(66556008)(85182001)(6916009)(86362001)(6666004)(186003)(478600001)(8936002)(6486002)(4744005)(41300700001)(2906002)(83380400001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0gycjFDM2ZNc1JwY2xjM0g3OWZ2V0ZETjNUN1pKeUZGWlBJcFFNZnI5UjB5?= =?utf-8?B?MCtLV2EwZWdGalk2RlBQWXhqTlRsMXRSQlBNb3pyWFVrS295aHVoRzNnSFcy?= =?utf-8?B?YzNwMUhtM0I0c21WdWl3NmgwODdvYUdrU0c5ZHZqdTNOcm5ra3hQS0h2SUhU?= =?utf-8?B?SFNURERDTmJuVVhTeDA2cDJMbTNHM0cxWWNKVXBCelVWN2RKaXNENzVtKy9N?= =?utf-8?B?OGpla1NjQ205NmVINm9aUS82cDA2UHpZYmU1V0FyMjEyb2g4VEhYWXlhdXVa?= =?utf-8?B?K1pZdzRBY1QzSlVEd2RuREZKR2dmOVhQb0YvbVAyZzduVDFpQ2Y1cmhvd1BF?= =?utf-8?B?dG1EYitPYUNXR3NydzR5Mi9UeHlYZFBTNHJ2Mzh6eE93QW5WN2dDYk9IK0Ew?= =?utf-8?B?SU5wSnlXZUVYNWZqeG1MSWhuNzF0blhIVVUwU3lVOU93enNOUDRHZUkrMHAz?= =?utf-8?B?bUpGa25xT3o2dUZSMW04czZPMVpYdXdmMzVkOHJEUmE5SFgrSERvQmFaWUNT?= =?utf-8?B?K293TDc4QWJ6YnhOeUxxWStMMXpoR1QvZ2UrYlZRYnZuMFpYYklMYnJUeUhq?= =?utf-8?B?T1VFVVdiVjFzU2NHcnpyRk9sem9McjBHODRwSG54bzNiak82QVVOWWVrQXNi?= =?utf-8?B?UHpuQ1gycDllNGFEMWNSTSttTEdPTlFnVmFuTkJtOVZnRUVFZkNBQ3grOCtQ?= =?utf-8?B?UkdYaFRSR0RrSlppbmNkT3RMTExYaVFmMEtjVXpVb1ZsOC9zcTFZYmVZanlo?= =?utf-8?B?Tms1aGNRTXVIKzg0TkNSVHduV1dsaTVTMjJrT2JnYTh5ZXhwM3dQMHFWcmwz?= =?utf-8?B?ZUhjdDVPOTdnS29LaUd1R0hCN2NZMTBtelg4eGM5T0o1aEZ5OGRIaDVjT3Mv?= =?utf-8?B?WHgwZUNoZEpacGVxS2F1dHB3R3ZWS3FRK2ZGeUtCQmR3Nk54Snc1YmllTjBC?= =?utf-8?B?TWxya0hwTGl4WTUyVmZWbmdLbTdZRlNNaUZHQUV6eXVJK29tQkVkREFvalhT?= =?utf-8?B?L21lYk9KYWIrRTQrY2wyay94R3R1ZU5Ua2ZPZllHSzJFYXVZVVFCMmt3TVVz?= =?utf-8?B?UVJvTVFHbmhIZ2JPL0FsTmpUdGUwbmdXd2JyYmR1aHhpSGhJVTNMQkpOdGhL?= =?utf-8?B?cTFqTHpUUEN6eVMvbERZbmhVdXI5eXZwbFlDWXpOa0ExRnBSTjl1ZUJRTFhq?= =?utf-8?B?NzlJQ2xUZDBKaXVUdkVWNzRTb2xNTldnYTd4Y3o3QjRhQW1qWU1oZVRQOGJ3?= =?utf-8?B?TEtNTDNRQlVVK1ZLdCtDZUdURS9DRkE0WnhmN1NxRTFoRWFzZ1dsQ0xEUGdr?= =?utf-8?B?Vml5dmJRd05ubncvUHdVWklXajdSR2lSdUZYSW5YWXg4bFVjcUFuR1c1QWFm?= =?utf-8?B?cTNFbjdLdTBLWXM4U3RIa3hFUkxrTStWTm4yemFFWHg0UW5ldXMvOTVTQWk4?= =?utf-8?B?eklKaW9QMmh4OW1oRDZOWVRKOXpRcnZwbkhsR1pHdHNWU2tzbmxoeTdCUnlT?= =?utf-8?B?bnNmcDFDOU96blYzbVlyQ0Q1NWM5UTZ5VTU5WWYyZWpBZE1Gdkhta0ErTXQx?= =?utf-8?B?bDcrRkp2Q05RK1VwbDZIWEJKOENVeVNMd0liSVg4UE9YMmZYYjBweFl4WEoz?= =?utf-8?B?eHYyUlBtMUhVaHNLMW0xamFTRUxmZm1NQ2JpdFJMZnNVbk1IM3RFTndaNVFa?= =?utf-8?B?V0JwUmx0cTlsR3dhdHhQcSthNWZjNnB3VGdXbktxVVNSaDVvS1ZPSGtTMldQ?= =?utf-8?B?TFQ1MWRXZ0JkL1QxUjlGdlMrdmtBZ1U4VTJOKytnYkxlbDhMMlhOWUlBOFVy?= =?utf-8?B?TGdRZW8wMUtkMXhJc2hnNytua1RuWE1XZkFiYVhtNW8wUnNQRi84OEg0ZThK?= =?utf-8?B?WWdGdnBDODVPV0lYV0d6dUVMUlR4b1VYMGdQRjJ1VldnRTlWdzRMRmk2ZDNQ?= =?utf-8?B?aUZaZWZqQ2FHWERxdXhnVGZiRE5sbm81RE1SQXBNVHdoQkpLT2pFSVRsR3Yv?= =?utf-8?B?dWNTUnpmcFA5VlFjNGdrdDFOZWtQN0FVVHZLdzRKQk1KWDk2U0NYNVg1NW4y?= =?utf-8?B?MVM3b0thQWJrZjc1V1ZFOSt1Y0thMlVoUDIzV3VZK1h1U3dYR2JSdnp3ZFVi?= =?utf-8?B?TWZ1SWZGTlNDNVY5aEhpY0JSTTVEUjUvRmJ0NFNJRlBnUlZHRGhGRU9Eeng1?= =?utf-8?B?N0E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ca38c9a-7fa2-4c7d-f6fe-08daa15d9715 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 14:27:37.0643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wd5pdOKclFp6tVa3sLHDSZdWIU/G6XaxzdJyj145qTqnCfowE/uuxqeEo2gI3q/Drn3oKhaamo2uywZy6uj6vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6105 On Wed, Sep 28, 2022 at 02:12:30PM +0200, Jan Beulich wrote: > While for some of the functions there's locking involved, the acquiring > and releasing of a lock doesn't alter program state when comparing > "before" and "after" the function invocations. Furthermore without > (further) locking by callers, return values are stale anyway by the time > they can be evaluated. Hence both CSE and DCE are okay to occur for > invocations of these functions. > > Signed-off-by: Jan Beulich > --- > RFC for the (imo) ambiguous wording in documentation. What happens if the contents of the rangeset is modified outside of the scope of the function. Ie: would for example: while ( !rangeset_is_empty(...) ); Become an infinite loop then, without taking into account that the rangeset can be externally modified? It's not clear to me whether the elimination of repeated calls take into account that the observed variable can be externally modified? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 28 14:59:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 14:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413403.657021 (Exim 4.92) (envelope-from ) id 1odYXN-00008W-By; Wed, 28 Sep 2022 14:59:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413403.657021; Wed, 28 Sep 2022 14:59:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odYXN-00008P-9F; Wed, 28 Sep 2022 14:59:49 +0000 Received: by outflank-mailman (input) for mailman id 413403; Wed, 28 Sep 2022 14:59:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odYXM-00008F-Pk; Wed, 28 Sep 2022 14:59:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odYXM-0008TG-Nr; Wed, 28 Sep 2022 14:59:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odYXM-0007Nl-7y; Wed, 28 Sep 2022 14:59:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odYXM-0007Hh-7U; Wed, 28 Sep 2022 14:59:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/ONxBe0+nqCKWC3M9VDGLCR53tGweuwunPqg41CwrZs=; b=pvPV44HQAttCwhkU6CwjT9BOYV k83WnMyXjl4we7UN8QgcQQQvoWw0LKJgTGGSvwnoi7m32CUSAxXRXLL34mwao8MhZ2rdrF2nD2tRE g2SWb6PVB3IaB6cHxNQuBW1BaIm7SgdsO3/OR+PTQPwTFyz8xeFuOsPUHn4vuemEMTmg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173343: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=dbc4f48b5ab3e6d85f78aa4df6bd6ad561c3d152 X-Osstest-Versions-That: qemuu=c48c9c6b33d7bb2b4ffa14cd33934a37db0cd342 From: osstest service owner Date: Wed, 28 Sep 2022 14:59:48 +0000 flight 173343 qemu-mainline real [real] flight 173355 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173343/ http://logs.test-lab.xenproject.org/osstest/logs/173355/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 173355-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173337 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173337 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173337 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173337 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173337 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173337 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 173337 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173337 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173337 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu dbc4f48b5ab3e6d85f78aa4df6bd6ad561c3d152 baseline version: qemuu c48c9c6b33d7bb2b4ffa14cd33934a37db0cd342 Last test of basis 173337 2022-09-27 15:38:41 Z 0 days Testing same since 173343 2022-09-28 01:55:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chenyi Qiang Christian Borntraeger David Hildenbrand Ding Hui Eugenio Pérez Ilya Leoshkevich Jason A. Donenfeld Jason Wang Laurent Vivier lu zhipeng Mark Cave-Ayland Matthew Rosato Nathan Chancellor Samuel Thibault Si-Wei Liu Stefan Hajnoczi Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git c48c9c6b33..dbc4f48b5a dbc4f48b5ab3e6d85f78aa4df6bd6ad561c3d152 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Sep 28 16:12:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 16:12:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413413.657031 (Exim 4.92) (envelope-from ) id 1odZfl-0000Qr-1n; Wed, 28 Sep 2022 16:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413413.657031; Wed, 28 Sep 2022 16:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZfk-0000Qk-VK; Wed, 28 Sep 2022 16:12:32 +0000 Received: by outflank-mailman (input) for mailman id 413413; Wed, 28 Sep 2022 16:12:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZfi-0000Qe-RB for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 16:12:30 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 599a3466-3f48-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 18:12:29 +0200 (CEST) Received: from zn.tnic (p200300ea9733e7ee329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ee:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9D1671EC058B; Wed, 28 Sep 2022 18:12:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 599a3466-3f48-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664381544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=P39ljKLiwuQPwtDvDuKVanquI0RYkjP1D8LuyTjtJJs=; b=Uao1ZphADuAsv6LM0PXKjLzWHVW6MpllBeF4uvmOQ+nQNKu9+hXBTS4RGyWezPZ0smbv/h IGZDd1BS828tjI6dOprjqWP0i4n19k+ZHCma3t7R0BXQ/TawsINhDvqGnP0458LIrxfMZX X0HwXQ23W2btK4ibPwovzxoqz5hFSFQ= Date: Wed, 28 Sep 2022 18:12:24 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Sep 28, 2022 at 03:43:56PM +0200, Juergen Gross wrote: > Would you feel better with adding a new enum member CPUHP_AP_CACHECTRL_ONLINE? > > This would avoid a possible source of failure during resume in case no slot > for CPUHP_AP_ONLINE_DYN is found (quite improbable, but in theory possible). Let's keep that in the bag for the time when we get to cross that bridge. > You wouldn't want to do that there, as there are multiple places where > pm_sleep_enable_secondary_cpus() is being called. We want all of them, I'd say. They're all some sort of suspend AFAICT. But yes, if we get to do it, that would need a proper audit. > Additionally not all cases are coming in via > pm_sleep_enable_secondary_cpus(), as there is e.g. a call of > suspend_enable_secondary_cpus() from kernel_kexec(), which wants to > have the same handling. Which means, more hairy. > arch_thaw_secondary_cpus_begin() and arch_thaw_secondary_cpus_end() are > the functions to mark start and end of the special region where the > delayed MTRR setup should happen. Yap, it seems like the best solution at the moment. Want me to do a proper patch and test it on real hw? :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Sep 28 16:23:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 16:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413419.657042 (Exim 4.92) (envelope-from ) id 1odZq1-0001xK-0O; Wed, 28 Sep 2022 16:23:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413419.657042; Wed, 28 Sep 2022 16:23:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZq0-0001xD-Tn; Wed, 28 Sep 2022 16:23:08 +0000 Received: by outflank-mailman (input) for mailman id 413419; Wed, 28 Sep 2022 16:23:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZq0-0001x3-6l; Wed, 28 Sep 2022 16:23:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZq0-00024x-5B; Wed, 28 Sep 2022 16:23:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZpz-0001O7-J5; Wed, 28 Sep 2022 16:23:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odZpz-0007P2-Ig; Wed, 28 Sep 2022 16:23:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DH+y57e2cz9JpVNPbQXIYkmhU/mmEGPa7I3sMGz+QCo=; b=pxCQGHOjFujDULX324xfUmJ4s0 eX6ycafi2nTIOpNCtYpl00o+dKMZxI0+Eq7plvCqLSrB6Lxy/iTUTgAcp4zWlzTN+hZ8hPVwZN2RC k8s/6LICDgnJMJdlRiOhFqN1kPvL3LXVxU3p75sbiiIramiB5x+JVTBtCt3PkCzmMRa8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173356: all pass - PUSHED X-Osstest-Versions-This: ovmf=b7213bbd59833fb0786c83a28df5f8244602ab5e X-Osstest-Versions-That: ovmf=3c0d567c3719675b9d8ecf07c31706d96467e31b From: osstest service owner Date: Wed, 28 Sep 2022 16:23:07 +0000 flight 173356 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173356/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b7213bbd59833fb0786c83a28df5f8244602ab5e baseline version: ovmf 3c0d567c3719675b9d8ecf07c31706d96467e31b Last test of basis 173354 2022-09-28 10:12:04 Z 0 days Testing same since 173356 2022-09-28 14:40:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3c0d567c37..b7213bbd59 b7213bbd59833fb0786c83a28df5f8244602ab5e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Sep 28 16:32:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 16:32:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413427.657054 (Exim 4.92) (envelope-from ) id 1odZyx-0003U7-T5; Wed, 28 Sep 2022 16:32:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413427.657054; Wed, 28 Sep 2022 16:32:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZyx-0003U0-QD; Wed, 28 Sep 2022 16:32:23 +0000 Received: by outflank-mailman (input) for mailman id 413427; Wed, 28 Sep 2022 16:32:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odZyx-0003Tu-EF for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 16:32:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 207d9acb-3f4b-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 18:32:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9896A1FA3B; Wed, 28 Sep 2022 16:32:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5BD3813677; Wed, 28 Sep 2022 16:32:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dx+KFBV3NGNZKwAAMHmgww (envelope-from ); Wed, 28 Sep 2022 16:32:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 207d9acb-3f4b-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664382741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=avuMj/GjAiWAqD95oSoKmVjHPWspt7PyvQByNGgpCKw=; b=ddaf34g91msQetgL8LBNHM2jDMS/zH8ESQt/AR0wtazTK2+6+lY6tjxzO/jgZA/ALU7XNf pzajwf0R7byrSQZH47YGHPJ2OSKo2NQQHYbW+IzQVecqQE79KPgYRKAYcrlWQ3m6K6QJr3 +NeNJCFxq4ULepSmbgtlgwll8lNczVk= Message-ID: <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> Date: Wed, 28 Sep 2022 18:32:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Qw47xpZy2e9ty4bWAzvZJ5v6" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Qw47xpZy2e9ty4bWAzvZJ5v6 Content-Type: multipart/mixed; boundary="------------SgMxD9WlHfYsoGKxfP7JRczD"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> In-Reply-To: --------------SgMxD9WlHfYsoGKxfP7JRczD Content-Type: multipart/mixed; boundary="------------39xnXyBXO94r7sm0Ta7XyWgv" --------------39xnXyBXO94r7sm0Ta7XyWgv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMTg6MTIsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gV2VkLCBT ZXAgMjgsIDIwMjIgYXQgMDM6NDM6NTZQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFdvdWxkIHlvdSBmZWVsIGJldHRlciB3aXRoIGFkZGluZyBhIG5ldyBlbnVtIG1lbWJl ciBDUFVIUF9BUF9DQUNIRUNUUkxfT05MSU5FPw0KPj4NCj4+IFRoaXMgd291bGQgYXZvaWQg YSBwb3NzaWJsZSBzb3VyY2Ugb2YgZmFpbHVyZSBkdXJpbmcgcmVzdW1lIGluIGNhc2Ugbm8g c2xvdA0KPj4gZm9yIENQVUhQX0FQX09OTElORV9EWU4gaXMgZm91bmQgKHF1aXRlIGltcHJv YmFibGUsIGJ1dCBpbiB0aGVvcnkgcG9zc2libGUpLg0KPiANCj4gTGV0J3Mga2VlcCB0aGF0 IGluIHRoZSBiYWcgZm9yIHRoZSB0aW1lIHdoZW4gd2UgZ2V0IHRvIGNyb3NzIHRoYXQgYnJp ZGdlLg0KPiANCj4+IFlvdSB3b3VsZG4ndCB3YW50IHRvIGRvIHRoYXQgdGhlcmUsIGFzIHRo ZXJlIGFyZSBtdWx0aXBsZSBwbGFjZXMgd2hlcmUNCj4+IHBtX3NsZWVwX2VuYWJsZV9zZWNv bmRhcnlfY3B1cygpIGlzIGJlaW5nIGNhbGxlZC4NCj4gDQo+IFdlIHdhbnQgYWxsIG9mIHRo ZW0sIEknZCBzYXkuIFRoZXkncmUgYWxsIHNvbWUgc29ydCBvZiBzdXNwZW5kIEFGQUlDVC4N Cj4gQnV0IHllcywgaWYgd2UgZ2V0IHRvIGRvIGl0LCB0aGF0IHdvdWxkIG5lZWQgYSBwcm9w ZXIgYXVkaXQuDQo+IA0KPj4gQWRkaXRpb25hbGx5IG5vdCBhbGwgY2FzZXMgYXJlIGNvbWlu ZyBpbiB2aWENCj4+IHBtX3NsZWVwX2VuYWJsZV9zZWNvbmRhcnlfY3B1cygpLCBhcyB0aGVy ZSBpcyBlLmcuIGEgY2FsbCBvZg0KPj4gc3VzcGVuZF9lbmFibGVfc2Vjb25kYXJ5X2NwdXMo KSBmcm9tIGtlcm5lbF9rZXhlYygpLCB3aGljaCB3YW50cyB0bw0KPj4gaGF2ZSB0aGUgc2Ft ZSBoYW5kbGluZy4NCj4gDQo+IFdoaWNoIG1lYW5zLCBtb3JlIGhhaXJ5Lg0KPiANCj4+IGFy Y2hfdGhhd19zZWNvbmRhcnlfY3B1c19iZWdpbigpIGFuZCBhcmNoX3RoYXdfc2Vjb25kYXJ5 X2NwdXNfZW5kKCkgYXJlDQo+PiB0aGUgZnVuY3Rpb25zIHRvIG1hcmsgc3RhcnQgYW5kIGVu ZCBvZiB0aGUgc3BlY2lhbCByZWdpb24gd2hlcmUgdGhlDQo+PiBkZWxheWVkIE1UUlIgc2V0 dXAgc2hvdWxkIGhhcHBlbi4NCj4gDQo+IFlhcCwgaXQgc2VlbXMgbGlrZSB0aGUgYmVzdCBz b2x1dGlvbiBhdCB0aGUgbW9tZW50LiBXYW50IG1lIHRvIGRvIGENCj4gcHJvcGVyIHBhdGNo IGFuZCB0ZXN0IGl0IG9uIHJlYWwgaHc/DQoNCkkgY2FuIGRvIHRoYXQuDQoNCg0KSnVlcmdl bg0KDQo= --------------39xnXyBXO94r7sm0Ta7XyWgv Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------39xnXyBXO94r7sm0Ta7XyWgv-- --------------SgMxD9WlHfYsoGKxfP7JRczD-- --------------Qw47xpZy2e9ty4bWAzvZJ5v6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM0dxUFAwAAAAAACgkQsN6d1ii/Ey/S 8ggAjkI9Wmvj7KWjaTdCrsG2CBD6Ax98ew3PIY+ak8M8Av6JHgAB4qvilw40t6xH8pYLXK8ocGeD r4rLjA1vFhFAWOTDjTHXK0aU5hyPdoyrAh5IPdrFZEvoaj1LU09BlYvrnH5cUEgZh7igRtV7BXhj GaSbMFXwDtUwdHyhcqUowoahUVwvIkg/T8+P4ws6sqXkLf0r4cuv8hz42stqsPH77YOY0sF3WkXt Ym2L6AkCExFNrvlbggER/LZP7Gfx6x67888byh7GVnakzm/EgraDul5z/igix3SZa042hFHGFmNa DODxrcHWtp/oEHcxUCvmyBEGDN7hIrQEB0DKx+Px0g== =TwA/ -----END PGP SIGNATURE----- --------------Qw47xpZy2e9ty4bWAzvZJ5v6-- From xen-devel-bounces@lists.xenproject.org Wed Sep 28 16:39:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 16:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413433.657065 (Exim 4.92) (envelope-from ) id 1oda5x-0004D3-Jq; Wed, 28 Sep 2022 16:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413433.657065; Wed, 28 Sep 2022 16:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oda5x-0004Cw-Gm; Wed, 28 Sep 2022 16:39:37 +0000 Received: by outflank-mailman (input) for mailman id 413433; Wed, 28 Sep 2022 16:39:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oda5w-0004Cq-0e for xen-devel@lists.xenproject.org; Wed, 28 Sep 2022 16:39:36 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2283447b-3f4c-11ed-964a-05401a9f4f97; Wed, 28 Sep 2022 18:39:35 +0200 (CEST) Received: from zn.tnic (p200300ea9733e7ee329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ee:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6D4441EC058B; Wed, 28 Sep 2022 18:39:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2283447b-3f4c-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664383174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=U0T8poAiUhpJC4gqL7M9xRcvJAMONfU1pvzFe2Yg4b8=; b=IaRofyiUD3AvVceqV3qQ+fznUI78NT4nzg25pR3wS2PP2oLISMEoeE8whqRsM0+Hj4Sour I7xVvHjDlxRnDCo/pJuBMB7KPsJWrm6c70nxqqGmGmmHzxLRcQ8cIh/ylZszMcG7XiyxZq 2jZwzLJ8dPGSXJ1vr5MetVkLcL4TlvA= Date: Wed, 28 Sep 2022 18:39:34 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> On Wed, Sep 28, 2022 at 06:32:20PM +0200, Juergen Gross wrote: > I can do that. Thx! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Sep 28 17:03:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 17:03:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413439.657080 (Exim 4.92) (envelope-from ) id 1odaT5-0007cS-G2; Wed, 28 Sep 2022 17:03:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413439.657080; Wed, 28 Sep 2022 17:03:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odaT5-0007cL-D5; Wed, 28 Sep 2022 17:03:31 +0000 Received: by outflank-mailman (input) for mailman id 413439; Wed, 28 Sep 2022 17:03:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odaT4-0007cB-4Q; Wed, 28 Sep 2022 17:03:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odaT4-0002oa-12; Wed, 28 Sep 2022 17:03:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odaT3-0002Ol-HG; Wed, 28 Sep 2022 17:03:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odaT3-0002WF-Go; Wed, 28 Sep 2022 17:03:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3WadTy+Pt68P2C4AoilcB2odMYdLOYkIPWVc3m0VslM=; b=St+d+lI7v7Nk49/UJ81/HxsiTM txsVkiNmYux3m7+xRYgxQoAszqMxzfr4B8+JFH8yxb55UQyYrXSA8Yd+tKhFMFog92nUzIQKGZV27 miC3GzLjBOXsiUHR8DBWS5Sezcq1F6s8PPItktWHLgRByh6P3FJ5jCWLNd7Zz7x8Xx8s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173349: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5e936d11b171793c174686268c9c1df8a4fa974c X-Osstest-Versions-That: xen=bd68a5f397537eb7ba6223546c1f4d47f078d3b2 From: osstest service owner Date: Wed, 28 Sep 2022 17:03:29 +0000 flight 173349 xen-unstable real [real] flight 173357 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173349/ http://logs.test-lab.xenproject.org/osstest/logs/173357/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 173357-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173327 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173327 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173327 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173327 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173327 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173327 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173327 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173327 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173327 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173327 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173327 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173327 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 5e936d11b171793c174686268c9c1df8a4fa974c baseline version: xen bd68a5f397537eb7ba6223546c1f4d47f078d3b2 Last test of basis 173327 2022-09-27 08:40:00 Z 1 days Testing same since 173338 2022-09-27 18:39:49 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bd68a5f397..5e936d11b1 5e936d11b171793c174686268c9c1df8a4fa974c -> master From xen-devel-bounces@lists.xenproject.org Wed Sep 28 19:36:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 19:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413448.657091 (Exim 4.92) (envelope-from ) id 1odcqa-0005oc-En; Wed, 28 Sep 2022 19:35:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413448.657091; Wed, 28 Sep 2022 19:35:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odcqa-0005oV-BP; Wed, 28 Sep 2022 19:35:56 +0000 Received: by outflank-mailman (input) for mailman id 413448; Wed, 28 Sep 2022 19:35:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odcqZ-0005oL-CD; Wed, 28 Sep 2022 19:35:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odcqZ-0005XP-1m; Wed, 28 Sep 2022 19:35:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odcqY-0007i4-FH; Wed, 28 Sep 2022 19:35:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odcqY-0000UH-Eq; Wed, 28 Sep 2022 19:35:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/X9cdJgvQEX5TzfJLF5dChBev6jzTByJS+zmjcHXffM=; b=VMFXq31Fj9D3F5l1ex/+5vcJjZ w02qZI+4C21PIs9TULFh1Q9jl2+j/u7w3oPkjBF6PB6xdKtvn0V3Rn1AfKI5V5Y/z+mwRlOt60GIt /Gn0I9VWHhxAeR5BeelsYbj4NOweFqLkOFX3DbsiEWmP7Nn6rHVCzHXA0/fIeOJd0dsI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 173353: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start.2:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6215647d9699cb8f1bf7333ec849242c4a9cf9a6 X-Osstest-Versions-That: linux=9f02aa34e179d1b0185a27980dd5bafd0f2e6e59 From: osstest service owner Date: Wed, 28 Sep 2022 19:35:54 +0000 flight 173353 linux-5.4 real [real] flight 173359 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173353/ http://logs.test-lab.xenproject.org/osstest/logs/173359/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 173359 pass in 173353 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 173359-retest test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 173359-retest test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173359-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 173260 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 173260 test-armhf-armhf-xl-multivcpu 19 guest-start.2 fail blocked in 173260 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173359 like 173260 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173359 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173260 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173260 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173260 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173260 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173260 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173260 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173260 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173260 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173260 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173260 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173260 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173260 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 6215647d9699cb8f1bf7333ec849242c4a9cf9a6 baseline version: linux 9f02aa34e179d1b0185a27980dd5bafd0f2e6e59 Last test of basis 173260 2022-09-20 10:44:01 Z 8 days Testing same since 173353 2022-09-28 09:15:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian Hunter Alan Stern Alex Deucher Alexander Sverdlin Andrii Staikov Ard Biesheuvel Arnaldo Carvalho de Melo Bartosz Golaszewski Benjamin Poirier Bharathi Sreenivas Bjørn Mork Borislav Petkov Brett Creeley Brian Foster Brian Norris Callum Osmotherly Carl Yin Carl Yin(殷张成) Chandan Babu R Chao Yu Christoph Hellwig Chunfeng Yun Codrin Ciubotariu Codrin.Ciubotariu@microchip.com Daniel Dao Daniel Wheeler Darrick J. Wong Darrick J. Wong Dave Chinner David Howells David Leadbeater David Rientjes David S. Miller Fabio Estevam Felipe Balbi Florian Fainelli Florian Westphal Greg Kroah-Hartman Guenter Roeck Hamza Mahfooz Hangyu Hua Heiko Stuebner Helge Deller huangwenhui Hulk Robot Hyunwoo Kim Igor Ryzhov Ikjoon Jang Ilpo Järvinen Jakub Kicinski Jan Kara Jean-Francois Le Fillatre Jens Axboe jerry meng jerry.meng Johan Hovold Johannes Berg Jon Hunter Kai Vehmanen kaixuxia kaixuxia Keguang Zhang Konrad Jankowski Leo Yan Liang He Lieven Hey Lino Sanfilippo Linus Torvalds Linux Kernel Functional Testing Lu Wei Luke D. Jones Luís Henriques Marc Kleine-Budde Mark Brown Masahiro Yamada Mateusz Palczewski Miaoqian Lin Michal Jaron Mohan Kumar Namhyung Kim Nathan Huckleberry Neil Armstrong Norbert Zulinski Ojaswin Mujoo Pablo Neira Ayuso Pali Rohár Paolo Abeni Pavle Kotarac Pawel Laszczak Peter Chen Peter Zijlstra (Intel) Piyush Mehta Randy Dunlap Richard Genoud Rob Herring Ronnie Sahlberg Sasha Levin Sean Anderson Serge Semin Sergey Shtylyov Sergiu Moga Shuah Khan Siddh Raman Pant Stefan Haberland Stefan Metzmacher Stefan Wahren Steve French Steven Rostedt (Google) Stuart Menefy Sudip Mukherjee Takashi Iwai Tejun Heo Tetsuo Handa Theodore Ts'o Thinh Nguyen Thomas Bogendoerfer Tony Nguyen Trond Myklebust Vitaly Kuznetsov Vladimir Oltean Vlastimil Babka Wei Liu Wesley Cheng Wesley Cheng Xiaolei Wang Yang Yingliang Yao Wang1 Yipeng Zou Youling Tang zain wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 9f02aa34e179..6215647d9699 6215647d9699cb8f1bf7333ec849242c4a9cf9a6 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Wed Sep 28 23:26:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 28 Sep 2022 23:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413458.657115 (Exim 4.92) (envelope-from ) id 1odgRT-0003EU-N4; Wed, 28 Sep 2022 23:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413458.657115; Wed, 28 Sep 2022 23:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odgRT-0003EN-IS; Wed, 28 Sep 2022 23:26:15 +0000 Received: by outflank-mailman (input) for mailman id 413458; Wed, 28 Sep 2022 23:26:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odgRS-0003ED-Pz; Wed, 28 Sep 2022 23:26:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odgRS-0001HX-Mw; Wed, 28 Sep 2022 23:26:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odgRS-0006iV-6d; Wed, 28 Sep 2022 23:26:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odgRS-0001T6-4m; Wed, 28 Sep 2022 23:26:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/Xi4TuMC+YJK+Lh7DqjO75mSBQJrGHR/5o5oOqpcIMQ=; b=k5L844a4TleO1vRIJ+fNQ+KhmW rpnQDEQ59HkU4a/0tKv2PGn2LvCTefEdtX6Yh79Qy4/EKrPGm/uyxHEJ3hBo7kC35Y46rxRYNXJm6 LNI//RGNFdavG6yICUGEuLZG2Lluu8EVh+ArSRYBgGe4qOT8Oa2JRHlqhu67mtmo3bWo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173358: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc X-Osstest-Versions-That: xen=5e936d11b171793c174686268c9c1df8a4fa974c From: osstest service owner Date: Wed, 28 Sep 2022 23:26:14 +0000 flight 173358 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173358/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 173349 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 173349 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173349 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173349 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173349 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173349 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173349 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173349 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173349 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173349 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173349 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173349 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173349 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173349 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc baseline version: xen 5e936d11b171793c174686268c9c1df8a4fa974c Last test of basis 173349 2022-09-28 07:10:39 Z 0 days Testing same since 173358 2022-09-28 17:10:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Michal Orzel Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5e936d11b1..211d8419ef 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc -> master From xen-devel-bounces@lists.xenproject.org Thu Sep 29 01:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 01:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413468.657125 (Exim 4.92) (envelope-from ) id 1odibf-0007ZW-Rp; Thu, 29 Sep 2022 01:44:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413468.657125; Thu, 29 Sep 2022 01:44:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odibf-0007ZP-Oj; Thu, 29 Sep 2022 01:44:55 +0000 Received: by outflank-mailman (input) for mailman id 413468; Thu, 29 Sep 2022 01:44:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odibe-0007ZF-79; Thu, 29 Sep 2022 01:44:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odibe-0002ch-4U; Thu, 29 Sep 2022 01:44:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odibd-00020f-IV; Thu, 29 Sep 2022 01:44:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odibd-0004Il-I4; Thu, 29 Sep 2022 01:44:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VdGhjk+CjLAjz98IfX7L1MB9k5TgN5zbW85S0EXNXWk=; b=cRe5roVsZdfIgPy4FEgW5KsGb2 MopzTZAouUUfB/SDkwumCR75osU13qUyQCqfhQLT1VrZk1FFmWkdXHmcaSN3v0yrx7RM0KFIU3K5F fPG7ke9pKVTNXfitV0MMYFIkAh5DavMyYrvUULX97UJP/mgCw7n21ANx6W+hhO4Fg+BQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173360: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c3e0e1e23c70455916ff3472072437b3605c6cfe X-Osstest-Versions-That: linux=49c13ed0316d55d73f1c81c66a7e2abd743f9ae6 From: osstest service owner Date: Thu, 29 Sep 2022 01:44:53 +0000 flight 173360 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173360/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 173339 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173339 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173339 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173339 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173339 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173339 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173339 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173339 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173339 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux c3e0e1e23c70455916ff3472072437b3605c6cfe baseline version: linux 49c13ed0316d55d73f1c81c66a7e2abd743f9ae6 Last test of basis 173339 2022-09-28 00:12:48 Z 1 days Testing same since 173360 2022-09-28 19:42:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian Hunter Anatoly Pugachev Antonio Borneo Borislav Petkov Brian Norris Huacai Chen Jianmin Lv Johannes Weiner Linus Torvalds Marc Zyngier Peng Fan Pierre Gondois Roman Gushchin Sergei Antonov Shakeel Butt Sudeep Holla Ulf Hansson Wenchao Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 49c13ed0316d..c3e0e1e23c70 c3e0e1e23c70455916ff3472072437b3605c6cfe -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Sep 29 02:20:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 02:20:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413476.657135 (Exim 4.92) (envelope-from ) id 1odjA3-0003pk-FU; Thu, 29 Sep 2022 02:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413476.657135; Thu, 29 Sep 2022 02:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odjA3-0003pd-Cp; Thu, 29 Sep 2022 02:20:27 +0000 Received: by outflank-mailman (input) for mailman id 413476; Thu, 29 Sep 2022 02:20:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odjA1-0003pX-Rx for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 02:20:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 455f7e0f-3f9d-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 04:20:23 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 117E961F95; Thu, 29 Sep 2022 02:20:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6FC7DC433B5; Thu, 29 Sep 2022 02:20:21 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 56BDAE21EC6; Thu, 29 Sep 2022 02:20:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 455f7e0f-3f9d-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664418021; bh=CqP6AJQBgb3mLDY8tX8RWjFHzQtZGZK5lDjmqSz457Q=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=jxWk6v5Ze0QvpoE73wtK36/dRnzL8GjGUNrU8TpMTWm4lo3rPFLDWHHwWntlXm1Bf zwzubAi+xqy50lByLS5Spj2NoK9l1v4OrzaDe8PGS8VMjs36AQueBm+CUueKtsiveF 4eNtAajPYESx6utyzoaTcXyVgWhW4SVVDdLwvPvzGgVDUw1blcHveV/AlzGdVelXOO 5NgYV4NRwrA8dezfB5NC/HdgIJg763M8c1peVPDYcBJXHIAFMTKfjxMw5qWNChz5Fk 0trMS3n5BXHlAGmFXHD2HfF5+nr9dRTvu6VQVan0eG10zxJWSaHv7XPMWcPrGlfMlL UXDN+FP6zgN7w== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next 0/4] shrink struct ubuf_info From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166441802135.18961.14047192093792393033.git-patchwork-notify@kernel.org> Date: Thu, 29 Sep 2022 02:20:21 +0000 References: In-Reply-To: To: Pavel Begunkov Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, wei.liu@kernel.org, paul@xen.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com, jasowang@redhat.com Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Fri, 23 Sep 2022 17:39:00 +0100 you wrote: > struct ubuf_info is large but not all fields are needed for all > cases. We have limited space in io_uring for it and large ubuf_info > prevents some struct embedding, even though we use only a subset > of the fields. It's also not very clean trying to use this typeless > extra space. > > Shrink struct ubuf_info to only necessary fields used in generic paths, > namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And > make MSG_ZEROCOPY and some other users to embed it into a larger struct > ubuf_info_msgzc mimicking the former ubuf_info. > > [...] Here is the summary with links: - [net-next,1/4] net: introduce struct ubuf_info_msgzc https://git.kernel.org/netdev/net-next/c/6eaab4dfdd30 - [net-next,2/4] xen/netback: use struct ubuf_info_msgzc https://git.kernel.org/netdev/net-next/c/b63ca3e822e7 - [net-next,3/4] vhost/net: use struct ubuf_info_msgzc https://git.kernel.org/netdev/net-next/c/dfff202be5ea - [net-next,4/4] net: shrink struct ubuf_info https://git.kernel.org/netdev/net-next/c/e7d2b510165f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Thu Sep 29 05:37:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 05:37:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413481.657146 (Exim 4.92) (envelope-from ) id 1odmEC-0006In-8i; Thu, 29 Sep 2022 05:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413481.657146; Thu, 29 Sep 2022 05:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odmEC-0006Ig-6B; Thu, 29 Sep 2022 05:36:56 +0000 Received: by outflank-mailman (input) for mailman id 413481; Thu, 29 Sep 2022 05:36:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odmEA-0006Ia-RZ for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 05:36:55 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-westcentralusazlp170100000.outbound.protection.outlook.com [2a01:111:f403:c112::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6ee25f8-3fb8-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 07:36:51 +0200 (CEST) Received: from PH0PR05MB8703.namprd05.prod.outlook.com (2603:10b6:510:bd::5) by DM4PR05MB9086.namprd05.prod.outlook.com (2603:10b6:8:b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 05:36:46 +0000 Received: from PH0PR05MB8703.namprd05.prod.outlook.com ([fe80::ae59:5c22:5ddd:bec8]) by PH0PR05MB8703.namprd05.prod.outlook.com ([fe80::ae59:5c22:5ddd:bec8%8]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 05:36:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6ee25f8-3fb8-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jqq/4fs061YDqJQYDt4F8La3HQDB7hmUmqFGU3YS1pN/wDmqzdfHRZl/35PwnWEk7CEZCph0yXq9Ebyss3OacDFylcvO48kaJ6Y+ZDYjiQlnnleaxkgF9qfSaXx2uIpCGFoKmpAIXp3eE238W05sGQEXrotCJ7gCKwmFUtrnJgNuXd3YKJ/bRXKNwqvokvT1c0LiwV3oFx1n8rCKxrd2D0R3R6yDcbRqQJ8VVIENwkgMw/RQvP5Rx0Bm06/5sX2w4Yo9r7YIoaSwjruu77OUOgEfCXq6NbVd+R20I7to87pZBuEaXwirO9ySRuv+EBIdnQc/fM6VTxVsM6/TVqXukg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UrOWv1ag1dIuCL8Q4/wZnOS4WGDDMGPvVBZRFbKA9p8=; b=QZEZGuicSbEFX97REXsixki3gZOWSqNKVtadELYf9V7LNC8N6PreYqNhgG4e6ct8TfaQv31d80/yYy99yiwPd6VFPdzbue9hGX7wKx6nNcsfYhlfU5oANJHqeA+YcSmiEiX6FcKyd+VMNpS66iTlPdyzw5JB/2358TdyBQpTwTeI4W4+G/jOBKZa7Xt+kFjALRG1p+Z3YdAWdxeZyZW/MWjH/TYeZE0trK3R8ipjNwART62N8HIWfd/ib9hZml1z60tMcJlBQmdegti5Ed0xA1Ej8XY5NalaJVlrB/HHQcamwnbjZmyCSZm8swnQyv2RendvPgIcjTnHWdWdURM3sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UrOWv1ag1dIuCL8Q4/wZnOS4WGDDMGPvVBZRFbKA9p8=; b=H5RxDyJh/zAHizW6UFPXFQyFFdVsnRnEJZDyTxTkUUOFnFAgir8/aaVMZ8Z6BQPes3K4qxChWQB8ZbV63RNWMDCW6MXR4wOfSSz0G4fgPcjkgjTxCAENAHKIowrGWUJ+OO9sb8lpfZ0/DGlAPzSe8/WjuqD+wHCIwbaZCJzH7Gs= From: Ajay Kaher To: Vitaly Kuznetsov CC: "x86@kernel.org" , "hpa@zytor.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , Srivatsa Bhat , "srivatsa@csail.mit.edu" , Alexey Makhalov , Vasavi Sirnapalli , "er.ajay.kaher@gmail.com" , "willy@infradead.org" , Nadav Amit , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "jailhouse-dev@googlegroups.com" , "xen-devel@lists.xenproject.org" , "acrn-dev@lists.projectacrn.org" , "helgaas@kernel.org" , "bhelgaas@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , Alexander Graf Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor Thread-Index: AQHYx28G+J2WSwxm3kmFzqoOhSDYUK3dXFQAgBj77YA= Date: Thu, 29 Sep 2022 05:36:46 +0000 Message-ID: References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> <87zgf3pfd1.fsf@redhat.com> In-Reply-To: <87zgf3pfd1.fsf@redhat.com> Accept-Language: en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/16.61.22050700 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR05MB8703:EE_|DM4PR05MB9086:EE_ x-ms-office365-filtering-correlation-id: d3fcc232-4650-4a4b-8d90-08daa1dc9995 x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AEvJCC9vSC4rRmYjtidDq/0soFb/XPk66LUpYD/Vq9pALypDD7Rmd4TYS0AF9befxPoQGY4S+qyYOKjCTtoAlqlO0Z1z/WhXm+SEfYODDFLRJPNA5YrBdFrvmbTpjqSUl7gjcuAIwisncPZfe8FeSWh4nNkUREAoMA3iqvKSgIk7Yw7GElMgqKZI1x3HlYIHktV/3wpw9Uq7+9o/zCQVchDCKe+yI32glG/7fSfSYK3OUIUw5j8d55UpxkAmxQcE9lMkMgc5rCm5Ouc/wqt995rMQ8TfucT3eXbDzOhcjklbaWkg9drOblzP0+YAxKv6BGXs4mMhX/LdpGxz3krNGpoWiNe/LWvIcK5PmChiqpGLCgxVAGrxuDkq3T4f3+/op3ff19KkV3mghopo+uInLzaygJN6sE7kg9LL1M4blJOg6n1CxgbAZPdPKE/VrArKjP/EuLLSRW0ATHuo+yhh/j2iiFaTNtnd6Tu/22F5nolgT7/Uf3FZsweMqoxMXtJvr/8PARn68C8E9ZjuKIVCaP5QooQaSuJdD0IwPfPZvnuoRFc8u52u/u1yaJFSGjiErtxe2p2u8bjI7BsgAKIszpVVkSA9FqOtCbj0hmExfETF4kirgL/Ee8Y1eKlA6YUPe99ehQg2mXydyeLA8DwjHItoyS7TqF9JvWnOM2s/eZ8CDcCaOmWYB0V9tPtuekZi2a3JFTAV0hoWj8CCn03c1FqqA8qw7/nYXOabil6KXHzjFAgkUW9LgMldROoO/eaXQ9sRtTUQdPeEEKkChRk5EylB0ugm7JLEbsLwRKY+19M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8703.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(451199015)(316002)(7416002)(6916009)(5660300002)(2906002)(66946007)(8936002)(36756003)(86362001)(38070700005)(4326008)(33656002)(54906003)(91956017)(76116006)(66446008)(66556008)(64756008)(66476007)(2616005)(186003)(478600001)(41300700001)(26005)(6486002)(6512007)(6506007)(71200400001)(38100700002)(8676002)(122000001)(83380400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UVc1dktDaWVNVUJlRGY1MEFCYm5JbFhLejhOc3Vjd0hDZXhMUXVmRHNPS2Vy?= =?utf-8?B?SGpGeTdqNHJIRU9sczF2cHQrNTVJNTdJSlBzVW5GdUZNanZqTjROMTFLeU9M?= =?utf-8?B?NHE5bmZWd1h6eDE5UUQvdmRpVnRFNlhoeHBob3FDbWM3bTBBT1VHWVNmWGkv?= =?utf-8?B?bERZSUl2ZitZdnNkWUgvTmZOYlR0UGtiWWdRamhvNytJbktEUnZmeFpBT3dl?= =?utf-8?B?cFdLcjVsWk12ejI5QjBMK1FqdlBqVndvWlkyZUFKaDRqR04zNWNVOEEybTh4?= =?utf-8?B?Tkp6UEtIUkFCd2h4RGttY3ZVdWo5d2swYkZFNkNiNk4wUm9Ha254aEJhbFFH?= =?utf-8?B?RnYvbDYwanoyYWNmaEtQR0JCUnlHTHlDV0lYc3hwREw1UGRTV0ljaG8zR0RM?= =?utf-8?B?dkpkU1N6UzUvb2hzYm55ODVKT0FwZlRmNVVrd2RaTnhoSlJ1R3p0WEtLQW9r?= =?utf-8?B?T0tnMDd4ZlppQTdFL1JqNnhoMzFHSkJVYlZJSTBPTjB6bVcyS1E4ek5adXk5?= =?utf-8?B?WDZKalNhOWxwcERRczMzZ1czRkc5KzJVSmk5N285QUNBc3V1RnZDbjFFZUVl?= =?utf-8?B?OVVmWlRFdEdyaU1GWHB2YVRITS9HeCt2eURnOTRuTG1taHk1NjFEVk4rS0Ru?= =?utf-8?B?V2EwUEhtV01RN2ZieFUzcm1rRHhFd1NWT0NsUkNHS3VkcENoaVpGRkg2YWVo?= =?utf-8?B?NVF2dXdHU0FSQU0vVU9BNm90L09MdWFJcllmaEVEVFRBMkh3d2lLZUplR050?= =?utf-8?B?L3pCNVZQWnk2ZGxVS1JCcFRsMUpyY3Q3NEdNWVhSaTIzZkZ0VGhTSmFvQVBa?= =?utf-8?B?d0VyUm9qU1pHSkZ6RGl2d0NKSnMvb3JzTm9ncU44NkRKM3BiK3ZMdVRqeU9s?= =?utf-8?B?Wi95VW4zUmwwSkpVLytIWUFLK1BUUk44MHp1WGY0OXJpcG1ZaGJOZGh5enE2?= =?utf-8?B?S0pJYnIzQUp6cXRKT2RQTEFVSWxiR3dJWmd4TTBsMVZ1c2VYc0J4U2tLNkVp?= =?utf-8?B?OXlOd0hwbXlidjVTd0x1elFEUUpVSUd2U0xmVUVCU2JjQ2xKNjJTNUFGT3Vs?= =?utf-8?B?UWpUL1BrSDRnZUZ2bGZuTTVURXNhUjIyWDNQRU1HUzF5OE5JVThjSXNRY0Jr?= =?utf-8?B?TWJ3YnlTOW11K0ZQWWpBVXNmY2NGNU5FK3pSY1E0R2VReWFmMHZxdm5RVDQw?= =?utf-8?B?NUwxMFJHVTdFM3JyNk9xc0xDenQvTzlZK2IvSFd3WUFMZ1pxRWFqWWpidmVF?= =?utf-8?B?SHJyWDJDbHh4cEFqbnZBSUxSQnZnakQ0ZkM0c2liREVqRnM2SXpEY3RNTjdH?= =?utf-8?B?ZytINWNPUTdoakpNbVpCRzIwWXNqSTZpajF0N0wzbHpyRWZYbitsYU1xTmdP?= =?utf-8?B?azQwL01iRmZTdXE2eTluQVBsZnVYUGFvV25ubUxzY1dMd1ZlYldTdGFkL1VW?= =?utf-8?B?S1UyRUdocG9IZ0pNZi82ejJaV3VNOXN3TlFJbEZhdFd6S2o0a0R0UUVyRVJm?= =?utf-8?B?TW5qaE5VVXFUdGc4ZHJOYnljQXBNcEtFOGMvMFZIenlEQ3F2UDZoQzJ0ODJF?= =?utf-8?B?OVN1MG5obDYzd1ZVVHpPWE1NUGhHWVF2K2orSENHRUZYUGNTZ3RaM2JrTEho?= =?utf-8?B?RGh2bUQxVWNZdmNrbmZtZlVGbDdhTlNveThIc0NJcG55TkRGMVJ6SnpBSDB3?= =?utf-8?B?Smdvc29GekRxRHU1VkxPb0Z6NTh3MzRMQnJMK0hIMG1pYjBWSHNJa3ZVTFlT?= =?utf-8?B?dUVOWVUzZDlBVzI5Y3dCcnpNNk9oV2dlTDdkbEMwOGtacDN6Nlh6cjVPaUpt?= =?utf-8?B?MjBZc01qeFpYdCt1UW5iRWVkcUpKbW4zRXVVL24xSmJ5ZlpZMDlFQ0V0cGhL?= =?utf-8?B?QkJtZDIzSG1pUzdJM0JLNER6dHFvUjlvOGtyQ0JEWk1wcDJpUDVXWERKODhh?= =?utf-8?B?L1RydnhiUEI3dTkycG1LekRJRHVTd25kYUEyT0ZGaEcwRE9QcjVQLzVIOWE1?= =?utf-8?B?cmVrUVRpTTh5OFJyT2FRdTFYY0szSWF1YzRDdnNGQlgxZFYwb2RNRnBTZjUv?= =?utf-8?B?UDBvMEFXNlM2R0tEN20zdzBRV2VxZW05TUpPcUR2QWJYV2NzQWRDMjEzdVJD?= =?utf-8?Q?0kon8D7pY7xbbzbxEgfirVXwz?= Content-Type: text/plain; charset="utf-8" Content-ID: <5D3D0A98AAD0B3469FE6F3A222912A7E@namprd05.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3fcc232-4650-4a4b-8d90-08daa1dc9995 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 05:36:46.7470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UKFRoiPk40nURvziT0fHiKYyP9eTOrRz5hYw/BbHB+Wa0agaBFKl4pb0t8hGKCKQ1jNOfk6z9Z98YzaqyV00dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR05MB9086 DQo+IO+7v09uIDEzLzA5LzIyLCA3OjA1IFBNLCAiVml0YWx5IEt1em5ldHNvdiIgPHZrdXpuZXRz QHJlZGhhdC5jb20+IHdyb3RlOg0KPj4NCj4+IFRoYW5rcyBWaXRhbHkgZm9yIHlvdXIgcmVzcG9u c2UuDQo+Pg0KPj4gMS4gd2UgaGF2ZSBtdWx0aXBsZSBvYmplY3RzIG9mIHN0cnVjdCBwY2lfcmF3 X29wcywgMi4gYWRkaW5nICdwcmlvcml0eScgZmllbGQgdG8gc3RydWN0IHBjaV9yYXdfb3BzDQo+ PiBkb2Vzbid0IHNlZW1zIHRvIGJlIGFwcHJvcHJpYXRlIGFzIG5lZWQgdG8gdGFrZSBkZWNpc2lv biB3aGljaCBvYmplY3Qgb2Ygc3RydWN0IHBjaV9yYXdfb3BzIGhhcw0KPj4gdG8gYmUgdXNlZCwg bm90IHNvbWV0aGluZyB3aXRoLWluIHN0cnVjdCBwY2lfcmF3X29wcy4NCj4NCj4gSSdtIG5vdCBz dXJlIEkgZm9sbG93LCB5b3UgaGF2ZSB0d28gaW5zdGFuY2VzIG9mICdzdHJ1Y3QgcGNpX3Jhd19v cHMnDQo+IHdoaWNoIGFyZSBjYWxsZWQgJ3Jhd19wY2lfb3BzJyBhbmQgJ3Jhd19wY2lfZXh0X29w cycuIFdoYXQgaWYgeW91IGRvDQo+IHNvbWV0aGluZyBsaWtlIChjb21wbGV0ZWx5IHVudGVzdGVk KToNCj4NCj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BjaV94ODYuaCBiL2Fy Y2gveDg2L2luY2x1ZGUvYXNtL3BjaV94ODYuaA0KPiBpbmRleCA3MDUzM2ZkY2JmMDIuLmZiODI3 MGZhNmM3OCAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYvaW5jbHVkZS9hc20vcGNpX3g4Ni5oDQo+ ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BjaV94ODYuaA0KPiBAQCAtMTE2LDYgKzExNiw3 IEBAIGV4dGVybiB2b2lkICgqcGNpYmlvc19kaXNhYmxlX2lycSkoc3RydWN0IHBjaV9kZXYgKmRl dik7DQo+IGV4dGVybiBib29sIG1wX3Nob3VsZF9rZWVwX2lycShzdHJ1Y3QgZGV2aWNlICpkZXYp Ow0KPg0KPiBzdHJ1Y3QgcGNpX3Jhd19vcHMgew0KPiArICAgICAgIGludCByYXRpbmc7DQo+ICAg ICAgICAgIGludCAoKnJlYWQpKHVuc2lnbmVkIGludCBkb21haW4sIHVuc2lnbmVkIGludCBidXMs IHVuc2lnbmVkIGludCBkZXZmbiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpbnQgcmVnLCBpbnQgbGVuLCB1MzIgKnZhbCk7DQo+ICAgICAgICAgIGlu dCAoKndyaXRlKSh1bnNpZ25lZCBpbnQgZG9tYWluLCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNpZ25l ZCBpbnQgZGV2Zm4sDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9wY2kvY29tbW9uLmMgYi9hcmNo L3g4Ni9wY2kvY29tbW9uLmMNCj4gaW5kZXggZGRiNzk4NjAzMjAxLi5lOTk2NWZkMTE1NzYgMTAw NjQ0DQo+IC0tLSBhL2FyY2gveDg2L3BjaS9jb21tb24uYw0KPiArKysgYi9hcmNoL3g4Ni9wY2kv Y29tbW9uLmMNCj4gQEAgLTQwLDcgKzQwLDggQEAgY29uc3Qgc3RydWN0IHBjaV9yYXdfb3BzICpf X3JlYWRfbW9zdGx5IHJhd19wY2lfZXh0X29wczsNCj4gIGludCByYXdfcGNpX3JlYWQodW5zaWdu ZWQgaW50IGRvbWFpbiwgdW5zaWduZWQgaW50IGJ1cywgdW5zaWduZWQgaW50IGRldmZuLA0KPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmVnLCBp bnQgbGVuLCB1MzIgKnZhbCkNCj4gew0KPiAtICAgICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcg PCAyNTYgJiYgcmF3X3BjaV9vcHMpDQo+ICsgICAgICAgaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8 IDI1NiAmJiByYXdfcGNpX29wcyAmJg0KPiArICAgICAgICAgICAoIXJhd19wY2lfZXh0X29wcyB8 fCByYXdfcGNpX2V4dF9vcHMtPnJhdGluZyA8PSByYXdfcGNpX29wcy0+cmF0aW5nKSkNCj4gICAg ICAgICAgICAgICAgIHJldHVybiByYXdfcGNpX29wcy0+cmVhZChkb21haW4sIGJ1cywgZGV2Zm4s IHJlZywgbGVuLCB2YWwpOw0KPiAgICAgICAgIGlmIChyYXdfcGNpX2V4dF9vcHMpDQo+ICAgICAg ICAgICAgICAgICByZXR1cm4gcmF3X3BjaV9leHRfb3BzLT5yZWFkKGRvbWFpbiwgYnVzLCBkZXZm biwgcmVnLCBsZW4sIHZhbCk7DQo+IEBAIC01MCw3ICs1MSw4IEBAIGludCByYXdfcGNpX3JlYWQo dW5zaWduZWQgaW50IGRvbWFpbiwgdW5zaWduZWQgaW50IGJ1cywgdW5zaWduZWQgaW50IGRldmZu LA0KPiAgaW50IHJhd19wY2lfd3JpdGUodW5zaWduZWQgaW50IGRvbWFpbiwgdW5zaWduZWQgaW50 IGJ1cywgdW5zaWduZWQgaW50IGRldmZuLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbnQgcmVnLCBpbnQgbGVuLCB1MzIgdmFsKQ0KPiB7DQo+IC0g ICAgICAgaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNpX29wcykNCj4gKyAg ICAgICBpZiAoZG9tYWluID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzICYmDQo+ICsg ICAgICAgICAgICghcmF3X3BjaV9leHRfb3BzIHx8IHJhd19wY2lfZXh0X29wcy0+cmF0aW5nIDw9 IHJhd19wY2lfb3BzLT5yYXRpbmcpKQ0KPiAgICAgICAgICAgICAgICAgcmV0dXJuIHJhd19wY2lf b3BzLT53cml0ZShkb21haW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVuLCB2YWwpOw0KPiAgICAgICAg ICBpZiAocmF3X3BjaV9leHRfb3BzKQ0KPiAgICAgICAgICAgICAgICAgcmV0dXJuIHJhd19wY2lf ZXh0X29wcy0+d3JpdGUoZG9tYWluLCBidXMsIGRldmZuLCByZWcsIGxlbiwgdmFsKTsNCj4NCj4g YW5kIHRoZW4gc29tZXdoZXJlIGluIFZtd2FyZSBoeXBlcnZpc29yIGluaXRpYWxpemF0aW9uIGNv ZGUNCj4gKGFyY2gveDg2L2tlcm5lbC9jcHUvdm13YXJlLmMpIHlvdSBkbw0KPg0KPiAgcmF3X3Bj aV9leHRfb3BzLT5yYXRpbmcgPSAxMDA7DQoNClRoYW5rcyBWaXRhbHksIGZvciB5b3VyIHJldmll dyBhbmQgaGVscGluZyB1cyB0byBpbXByb3ZlIHRoZSBjb2RlLg0KDQpJIHdhcyB3b3JraW5nIHRv IG1ha2UgY2hhbmdlcyBhcyB5b3Ugc3VnZ2VzdGVkLCBidXQgYmVmb3JlIHNlbmRpbmcgdjMgd291 bGQgbGlrZSB0bw0KZGlzY3VzcyBvbiBmb2xsb3dpbmc6DQoNCklmIHdlIGFkZCByYXRpbmcgd2l0 aC1pbiBzdHJ1Y3QgcGNpX3Jhd19vcHMgdGhlbiB3ZSBjYW4ndCBoYXZlIHBjaV9tbWNmZyBhcyBj b25zdCwNCmFuZCBmb2xsb3dpbmcgY2hhbmdlIGlzIG11c3QgaW4gYXJjaC94ODYvcGNpL21tY29u ZmlnXzY0LmM6DQoNCi1jb25zdCBzdHJ1Y3QgcGNpX3Jhd19vcHMgcGNpX21tY2ZnID0gew0KK3N0 cnVjdCBwY2lfcmF3X29wcyBwY2lfbW1jZmcgPSB7DQogCS5yZWFkID0JCXBjaV9tbWNmZ19yZWFk LA0KIAkud3JpdGUgPQlwY2lfbW1jZmdfd3JpdGUsDQp9Ow0KDQpTbyB0byBhdm9pZCB0aGlzIGNo YW5nZSwgaXMgaXQgZmluZSB0byBoYXZlIGdsb2JhbCBib29sIHByZWZlcl9yYXdfcGNpX2V4dF9v cHM/DQoNCkFuZCByYXdfcGNpX3JlYWQoKSB3aWxsIGhhdmUgZm9sbG93aW5nIGNoYW5nZToNCg0K LQlpZiAoZG9tYWluID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzKQ0KKwlpZiAoZG9t YWluID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzICYmDQorCSAgICAgKCFwcmVmZXJf cmF3X3BjaV9leHRfb3BzIHx8ICAhcmF3X3BjaV9leHRfb3BzKQ0KDQo+DQo+IHdoeSB3b3VsZG4n dCBpdCB3b3JrPw0KPg0KPiAoZGljbGFpbWVyOiBjb21wbGV0ZWx5IHVudGVzdGVkLCByYXdfcGNp X29wcy9yYXdfcGNpX2V4dF9vcHMNCj4gaW5pdGlhbGl6YXRpb24gaGFzIHRvIGJlIGNoZWNrZWQg c28gJ3JhdGluZycgaXMgbm90IGdhcmJhZ2UpLg0KPg0KPj4NCj4+IEl0J3MgYSBnZW5lcmljIHNv bHV0aW9uIGZvciBhbGwgaHlwZXJ2aXNvciAoc29ycnkgZm9yIGVhcmxpZXIgd3JvbmcNCj4+IFN1 YmplY3QpLCBub3Qgc3BlY2lmaWMgdG8gVk13YXJlLiBGdXJ0aGVyIGxvb2tpbmcgZm9yIGZlZWRi YWNrIGlmIGl0J3MNCj4+IGltcGFjdGluZyB0byBhbnkgaHlwZXJ2aXNvci4NCj4NCj4gVGhhdCdz IHRoZSB0cmlja3kgcGFydC4gV2UgY2FuIGNoZWNrIG1vZGVybiBoeXBlcnZpc29yIHZlcnNpb25z LCBidXQNCj4gd2hhdCBhYm91dCBhbGwgb3RoZXIgdmVyc2lvbnMgaW4gZXhpc3RlbmNlPyBIb3cg Y2FuIHdlIGtub3cgdGhhdCB0aGVyZSdzDQo+IG5vIFFFTVUvSHlwZXItVi8uLi4gdmVyc2lvbiBv dXQgdGhlcmUgd2hlcmUgTU1JTyBwYXRoIGlzIGJyb2tlbj8gSSdkDQo+IHN1Z2dlc3Qgd2UgbGlt aXQgdGhlIGNoYW5nZSB0byBWbXdhcmUgaHlwZXJ2aXNvciwgb3RoZXIgaHlwZXJ2aXNvcnMgbWF5 DQo+IHVzZSB0aGUgc2FtZSBtZWNoYW5pc20gKGxpa2UgdGhlIG9uZSBhYm92ZSkgbGF0ZXIgKGJ1 dCB0aGUgcGVyc29uDQo+IHN1Z2dlc3RpbmcgdGhlIHBhdGNoIGlzIGFsd2F5cyByZXNwb25zaWJs ZSBmb3IgdGhlIHJlc2VhcmNoIHdoeSBpdCBpcw0KPiBzYWZlIHRvIGRvIHNvKS4NCg0KT2ssIGFz IG9mIG5vdyB3ZSB3aWxsIG1ha2UgdGhpcyBjaGFuZ2Ugc3BlY2lmaWMgdG8gVk13YXJlIGh5cGVy dmlzb3IuDQoNCi0gQWpheQ0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 29 06:30:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 06:30:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413489.657158 (Exim 4.92) (envelope-from ) id 1odn3e-00044i-9i; Thu, 29 Sep 2022 06:30:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413489.657158; Thu, 29 Sep 2022 06:30:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odn3e-00044b-4l; Thu, 29 Sep 2022 06:30:06 +0000 Received: by outflank-mailman (input) for mailman id 413489; Thu, 29 Sep 2022 06:30:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odn3c-0003iZ-Dk for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 06:30:04 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061.outbound.protection.outlook.com [40.107.249.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25d9219b-3fc0-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 08:30:02 +0200 (CEST) Received: from DBBPR09CA0035.eurprd09.prod.outlook.com (2603:10a6:10:d4::23) by AS8PR08MB9409.eurprd08.prod.outlook.com (2603:10a6:20b:5a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Thu, 29 Sep 2022 06:29:49 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::a8) by DBBPR09CA0035.outlook.office365.com (2603:10a6:10:d4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Thu, 29 Sep 2022 06:29:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 06:29:49 +0000 Received: ("Tessian outbound ce981123c49d:v128"); Thu, 29 Sep 2022 06:29:48 +0000 Received: from 02771064c05e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2F5983F2-E2F5-4354-8EB3-E4441479A2C3.1; Thu, 29 Sep 2022 06:29:42 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02771064c05e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 06:29:42 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VE1PR08MB5805.eurprd08.prod.outlook.com (2603:10a6:800:1aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 06:29:38 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 06:29:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25d9219b-3fc0-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LAbOFx63XJRteHNltl+VRmxBDSki6THR2QhIW/AltE69fW4IJo2A666BE+9O9CklhNDNV4lLssaWpMDc915NijvHMc1wVgwVZAYhtUvOHyFzA0nHOtcckhsADR6IxiCFN2q82XPYF9Cs/n6OsBLGKcC2BiSNHLdLhKyjU2CHDHuOa9yqSnuuS8FEmEhC/flpaT3FPcyW9dlOGD16cYf2GB2blkM25VtMaOrfdnkFtSQjT08dg+PXU2eGxLtO8hvvPygnjasNA7+iFOoCc8ua4f3lq9GOWqWu/bIbROmClEAM27QCPutYkZxam5P+O9WOrsRw//WBFXZl3KUza9nAcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/YAw0gVf/fUr4SLwG77Ds/8+6rISHbIekQQqTPtcWXk=; b=D61087EcXnVltQeGJpEONGx8E+yylfu22FmzWNWuUtdnmCENyy3mySfaIirX2pDEGU/s8XwueqeS0Ue6bKo6Ptvoi99VeYpNPq1YNlDOwigYXMEwvlTt7RWKtVBkBfqTvB1rV2cByd32oWOk74Y4es0mpOEMpc3Daup79mgRk1sB7HyAy63uTTOOZ6TsMP0Q3SMcW3CTKhOH6hpB8fYujn6sbLqNvorttCAfAukX/vTdZdhX+bP2aeMMBe5GajL80yg0y7RFxnJRnFsXZWS0fGXjhIgPPPEcIMnsLPJFYOq9Eo7AjVIffv1/pWJgyDBHmB/oP0FKBOgCre4SjATphg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YAw0gVf/fUr4SLwG77Ds/8+6rISHbIekQQqTPtcWXk=; b=OjZADj1KdM3OVo59iqqEfYUQb/76aeV4c+YqCoCx1bG8MOE3c6DNtSqTdwFzf4MzbHfLMwZb7tyRqMpcgkTNPy2HccuSeh/CbVIcYgi1qPk/CTuKlfuWKfJ3XtXmNDHuuVfHCF/BRdM3wIrq/YHIFNYEmTmw+XcDWb4b0CrpNWk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bda4f4f6d8e593a6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ofV5m+GKBrTZ89k+aNHbnGc3dPoF5aORAxDLVVrySVTgHFaL3ZpQdyLvzzPLRY2rU6jXd9OCDMJl0wXIKRgpW/6k9HyJITy78j/JB04VWmQduQ0Iq5fnQ9IZtAItI+bq4dJjt9p2TjW7WX69q3bcicRKmCD5Wq1a8K0E8KTvKpRS3o8orRspLhEm8B797w/Z5dewU36At4kIaQ+yEH8evOneT12z+s3g495f7ZpVk/K4iW0BIsbV/ceJddvnFCbLkVC7YAcKKoS3ApuwvibZ15/eh+yQMIDJcblvKsTAaDw+BTTSKXyrmqm+hei1rZ4Bn/abNQLpFw07Gin5ptrRyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/YAw0gVf/fUr4SLwG77Ds/8+6rISHbIekQQqTPtcWXk=; b=WYVmbnUDovp/JS1XTWQuB+MkL29g7AobLN5fivkp6FoF4TAXrLMdoBPZb77Uq/0URuXVxHc0V1R2ifkDkmc99DQRck1BHXFIIs2wMzqh8CkCjEqSs3fmfuvI2sQWKy6pZadavrVc9qkLoHE3kR//7Vd8BNpFDYtJ9oNv/Mt4jy4g5jlR+hviSwKfWyhqH5cG/BCQm0FW/C7IuZKZyqebOsmZrGwWAoY8eZwIHTMPdoMbMsP35DZN0osIFU8Hp8lsndu0dbV2TKjflRmEAMSXok8V3GuC/xEMWVsvGaEn5e0idL79qe76xLXgoRN7MvxzcC+6zjIgp9xe0h81H7IwRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YAw0gVf/fUr4SLwG77Ds/8+6rISHbIekQQqTPtcWXk=; b=OjZADj1KdM3OVo59iqqEfYUQb/76aeV4c+YqCoCx1bG8MOE3c6DNtSqTdwFzf4MzbHfLMwZb7tyRqMpcgkTNPy2HccuSeh/CbVIcYgi1qPk/CTuKlfuWKfJ3XtXmNDHuuVfHCF/BRdM3wIrq/YHIFNYEmTmw+XcDWb4b0CrpNWk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <1b2c0122-19d0-1478-0b51-6cb685a5273b@arm.com> Date: Thu, 29 Sep 2022 14:29:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v5 1/6] xen/x86: Provide helpers for common code to access acpi_numa Content-Language: en-US To: Jan Beulich Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-2-wei.chen@arm.com> <5547335f-9e01-d461-f866-c0f823aa2814@suse.com> From: Wei Chen In-Reply-To: <5547335f-9e01-d461-f866-c0f823aa2814@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2P153CA0053.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::22) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|VE1PR08MB5805:EE_|DBAEUR03FT036:EE_|AS8PR08MB9409:EE_ X-MS-Office365-Filtering-Correlation-Id: dc5879bb-8c46-4ec7-d26b-08daa1e40258 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ad9r48ar7JB5HCvJJ7tGJCTG28QYX+t7yAeB9p7v8flC9akgIiEHeEtUooDBbDI3Y3wmdmG8zehVeO+ORVT3qRERtnfh+w24sHK9MxTRpkC6soSxM/XU46XFlto2wCGzOEFJvmtwLfZpvn69d7nxK7/N48VHJX+mPoFM6364QoXLwekwseVLRULB6bO+eeXYq6/tYmEJJZX9wW65HKOxiEZKPAhsK2UAC4wmnmDNPfeyoTSlrbzD/Dvua5qpm5UFs8JWGiN4ULOtD/BGcOqMXq13cXJT6xGXt5k9aJem58Vx7Ocg8a9Fg3S6n9veQib5YMmxeMA22jqNVBxrIW/NKoWHdKmte5iWCFD1FIsIn2sH1uBleFsCDL7s9XHtpP9O6wfaYmyESm3/KobGZxcvdVRdQtJtikfFs6Ud0B7h5dHSm2O2j8tle9v5zA4iUyTmeX2HeaSeI1ZQpVVwtEHs/ka30Du3tzObwD/olqA43ZCzqYu9d4YChbfPfLLb7IqjmlcbzMF75aec2hiUDnO2q4Nt9bOxLx06FeUTM+qYLlwmTnDefok3NuBPYkkVOd73gOtmySZISxm27HSAm8k57QUbATk6X7gPuOGu2EfGgoDvhUHsLcqZKZGklNXnaVpyM9rnW3Vwk4X16xm1McCH+w00DcMn4hIVe/AzySX73wIKhFqCCgtQNdRGPdrPWBJGiz1ALtRTMkIze+0OL0SfzVBoI/GrZ48S3JjtNLW5VBCzAQJYR4IK+qDzWHFHz1D8DkxRVK2dTFU3FDlH1wcPoGyJFtl1ZM0x7QfXnb0f060= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(451199015)(31696002)(8676002)(4326008)(66946007)(66556008)(66476007)(86362001)(41300700001)(6666004)(83380400001)(186003)(2616005)(38100700002)(5660300002)(36756003)(26005)(53546011)(6506007)(8936002)(2906002)(6512007)(31686004)(478600001)(6916009)(6486002)(54906003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5805 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 581a831e-13b8-44e5-6ee1-08daa1e3fbfd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QYfSsSMM5zWcwS9Xu3KWHUQgGqSkt6G7wetjIVpQ+IrFY8cZMrc0OHuHajDwd+WStT/Q1WMqoq4HMBSraXzayE1IcQg/cBQxg7tPFhRfD3HQWdtbPQw/hd8tRwrsqj+nI5rmHCkCje7CQg/z00rtISBhAIO25QkFYz0Tdlibf9rdrSqdSuM7ovBj4caK2+h2zmbVr5GqNhTLhwiZZr65Iu4a9HZ+vKX5cdHOosKoIov7mz+tUah21Hsu0qEqk9mEt3sJQun2FGWPUQDLZAOzb7McOKsPpkXPjCj+/96NFuLe9fe/gC77zQk392CaPuptXN5dxCldlO98S1z4LDSqiKSNVN0b+27CSp3poaT8MH8PP2+fVh0SMvRRVumNV+62EfxACq2vGcUn810jTqpl3oOljakUQX+751PBe7HSsUhQ/ENq2xBt9aIOFA8tcGo7GuwcAsyzG/XWR6EmBFOPSCl2hB50F3Kf/AcX/8ZdIrZsbcjREB00SN4qeNgYgFKemKCuXUa5TAmG9pXK+ifPVejT1fupO2a5aLwr6CBWpIXLWGQvbYtU53ud6IqoRTcxIUg6QEplq1+MyMCNhDUY8wY7UPv16Cq7YTi5unLPqOEYyBPbqIZbFwVDKzoCqLqgRL93sGIh45OXQgU+fVo0egeqIdIlHTdzqutZf2nEagtqVAEvj65E/u//U5gwAQxEr+lN2/Gf9IOuiZoKZ95dc0pYz6BSGJN2QQ+ORqai3sEEqafTX0QqF2jp557zLr8XgnAFZe41W4L1w2s+ZmPTgyXCq1sVHiNhsnMlXxZetoISFP9hEOuWfxOdwAZKJPOP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(31686004)(83380400001)(336012)(47076005)(2616005)(6862004)(36860700001)(5660300002)(31696002)(82740400003)(53546011)(8936002)(186003)(81166007)(70206006)(6512007)(36756003)(2906002)(26005)(356005)(82310400005)(478600001)(316002)(6486002)(70586007)(6506007)(40460700003)(4326008)(54906003)(40480700001)(8676002)(86362001)(41300700001)(6666004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 06:29:49.0337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc5879bb-8c46-4ec7-d26b-08daa1e40258 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9409 Hi Jan, On 2022/9/27 15:37, Jan Beulich wrote: > On 20.09.2022 11:12, Wei Chen wrote: >> --- a/xen/arch/x86/numa.c >> +++ b/xen/arch/x86/numa.c >> @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; >> bool numa_off; >> s8 acpi_numa = 0; >> >> -int srat_disabled(void) >> +int __init arch_numa_setup(const char *opt) >> { >> - return numa_off || acpi_numa < 0; >> +#ifdef CONFIG_ACPI_NUMA >> + if ( !strncmp(opt, "noacpi", 6) ) >> + { >> + numa_off = false; >> + acpi_numa = -1; > > When making the v5 changes, did you go over the results to check they are > actually consistent? I'm afraid they still aren't, because of the line > above: Here we disable NUMA, but that doesn't mean there's broken firmware. Yes, you're right. I had not realized it while I was modifying this patch. > Therefore I guess I need to ask for another round of renaming of the two > helper functions; I'm sorry for that. What you introduce ... > >> + return 0; >> + } >> +#endif >> + >> + return -EINVAL; >> +} >> + >> +bool arch_numa_broken(void) >> +{ >> + return acpi_numa < 0; >> +} > > ... here wants to be arch_numa_disabled(), whereas the function currently > named this way (in patch 5) wants to be e.g. arch_numa_unavailable() (or, > using inverted sense, arch_numa_available()). Of course I'll be happy to > see other naming suggestions for both functions, as long as they reflect > the respective purposes. > > Alternatively, to retain the current naming, the assignments to acpi_numa > would need revising. But I think that would be the more fragile approach. > Yes, I agree with you, I will rename these two functions. Your suggested names are reasonable, I will use them in next version. Cheers, Wei Chen > Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 07:44:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 07:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413495.657169 (Exim 4.92) (envelope-from ) id 1odoDB-00036Z-LT; Thu, 29 Sep 2022 07:44:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413495.657169; Thu, 29 Sep 2022 07:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoDB-00036S-Ic; Thu, 29 Sep 2022 07:44:01 +0000 Received: by outflank-mailman (input) for mailman id 413495; Thu, 29 Sep 2022 07:44:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoD9-00036M-TP for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 07:44:00 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50051.outbound.protection.outlook.com [40.107.5.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 783748bb-3fca-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 09:43:55 +0200 (CEST) Received: from DB6P195CA0011.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::21) by GV1PR08MB8057.eurprd08.prod.outlook.com (2603:10a6:150:97::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 07:43:51 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::6c) by DB6P195CA0011.outlook.office365.com (2603:10a6:4:cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 07:43:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 07:43:50 +0000 Received: ("Tessian outbound 99ee3885c6d5:v128"); Thu, 29 Sep 2022 07:43:50 +0000 Received: from 256e337ed6d5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5BAC8CD6-DF22-4F7B-976C-287930D5B757.1; Thu, 29 Sep 2022 07:43:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 256e337ed6d5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 07:43:43 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV1PR08MB7940.eurprd08.prod.outlook.com (2603:10a6:150:9f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 07:43:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 07:43:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 783748bb-3fca-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BzfxZfLWoX2YaoWKHDs5SonuZjOaz0FmF90jikMGAXh+wPsmj2cxgSEWQtu3+ZYeB3j0KXxzscZgJVVlDKYKtHoGf6LKVt7pdCwX0UrFQZ6iP2fLPATeKb/2m1TdpMCMXaV+cKFNcqFzOqyYRD+X8DMMXpPUulk16x2xbdbrmb7ywSP68Rb1DakLUBl5bS0JqDb2stu7cN92fp1kWkzIQ9SDNKkOtvu9yTrIAkLDcyCWIRzv/f7plr8Rjeld38oNg6Z89l1J0OC3ABSVyhRvLIe7M4SW3PxROHsRdWzL8JGen0tvZB4SXMZtB9UCFEH/h+d0o3Fez17pam8Vpo9+Sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8IsjiY1jpjUkiqZ7otyvOXn4y+HtgkY331kkTtVr94=; b=dZjlJT/PRJys08Z+1moNhFFURMT3ZVj2ctsawKm6JhBbt33p0w28YaTouCRoF9CMl/Y09pFDfpp42eoo7JSw2YcQsio9tU5Artlcjnf7FyYf80115Nw+PG6bEoo/M7vghToeubrI5xdYTtwefqu3Z2Augz+7Sr/ihgBoTfI0EGQQTWUPbi/VpJVljWmNyr69I0FvRmle4ssgGKa5+9CRWyoHRwkpyFHKVb6iTHASzsUcAQXR3zRHgNvMi5tIqwpsxkaLOUjTHkwoGocW1JqO+H18Nx+7iG/zS4aPyGcwsLMbcD44Sn9BaqX6pxedijZGm8d1YYLZnNmUvQLsmPsXQA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8IsjiY1jpjUkiqZ7otyvOXn4y+HtgkY331kkTtVr94=; b=98kvI0ghnatQBOTcIPqfqs5oVZll7ZZ98PppQw7ojLDiR2hkC8ZBcj6RVw7uGW6MNxVACt7k0nzcfMhL4s6HIdZvvX049WeLq0QU5pYk0e1BJ2MaLXoVFTyWyeth/vu3o/ytNKwKl0SleTrlQwpWwMMZXWaN6gt9XvYdBsXTbvo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 82dcdce4581aef09 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OtJh0/zViZ360IlmV79+2Sf6qK+3CIjqfEvleqfAN0sFiAIQkhKOazDLBChEg5COVkyrECmn4HqzpWl6NIzmDB4DTa+twjeamArXCT7wMfO4z0ZmkjMi/vguOlCtVTnzOfERZOWKZRUXCbbg+yAp9FQYMwkz1DUDFGS2L2dmYcUw+QRHPEmSq7c60zxqggvQmi3CYHVZ9iu0S+H8G1JMyMIgaL2z55+VX+wuIfX0RJGkTO9DP+PMxDM82DNAgepWwcT8OYMdGLDYOQvv7EC2DNBpjCJEw4SYpNF4h8nzucrvgLKtw4UGhhEstsmZaiuhCG4x6jsss690Mi8waQF0nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8IsjiY1jpjUkiqZ7otyvOXn4y+HtgkY331kkTtVr94=; b=GK4tXkcaTQRhxewDPPVFRPtpSchLNnFM1kOMUvWVSTwJ4SlAdrVug2AVM4AlGc/8w88SW4REGEaGUPhDobjZOgVpPQ+ttv6Cx3Y3SQZ/FZ1w2jo+T0ae2uwo96bbcRsA9i/oqHFWtMBDS8TWTkSnp43B1qHQJH83d3wF7Vc9NhI4vPq0zdhhLQFgYqj8tDXZhltN+cYLn6aC5fYZrYDQxrMRM/VKCKA5ALEXi+Sp+9Hxhet5yaI0zfHG/V/jDy0g4E1FCEMlHq0EHGp+mh1NDw9hEW3aAGtuZTEMfMY1u04xlUcogIILaFw+gD7cDjj9HtC3J2P+Gj88j+65JzANKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8IsjiY1jpjUkiqZ7otyvOXn4y+HtgkY331kkTtVr94=; b=98kvI0ghnatQBOTcIPqfqs5oVZll7ZZ98PppQw7ojLDiR2hkC8ZBcj6RVw7uGW6MNxVACt7k0nzcfMhL4s6HIdZvvX049WeLq0QU5pYk0e1BJ2MaLXoVFTyWyeth/vu3o/ytNKwKl0SleTrlQwpWwMMZXWaN6gt9XvYdBsXTbvo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <72691b9b-761e-a89b-97df-afd5cf0ddebb@arm.com> Date: Thu, 29 Sep 2022 15:43:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Jan Beulich Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-3-wei.chen@arm.com> <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> From: Wei Chen In-Reply-To: <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR04CA0216.apcprd04.prod.outlook.com (2603:1096:4:187::18) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|GV1PR08MB7940:EE_|DBAEUR03FT063:EE_|GV1PR08MB8057:EE_ X-MS-Office365-Filtering-Correlation-Id: ce829e70-e6a1-4114-b329-08daa1ee59dd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /OJB98wG/kMNfehpjy6MCg/uM0JusIUdL+I9KyW2laSTLIjY8qbG01UsVmFWAx7pQbUU4lxvnrvOY1XzYa+O+kp+sGu1e8Q+docgc9AG85lJCv/N3scYZj3x8fNBWVwDsFKpe2mdSLoLUjG3nR93U/FMdxUQjw9fBHPIf9pJM+zkJPs9scHDaDbxiXpWyPaGTElG/77Q/UOWtOaqXqMu0tpQxzO5PyJ9Ze50bD2ZpcKLnmVldaBIaqIQx6FwsyFJFxke8/yPHg7yUcV5Z3RJMsLGYrNWmV/o/bLE+EsiGOx9Go14z/tPpuqINXC9Qj0CafyrcCZ9CWiO0S5v4d/Gmwlq0mrcWYcbSe3CBnuPjQlCQMRzYeOFRPlxfvKeHfixDPzRx5l6Y0IWk0w6OlDpBh5oPADo1M/nZ7qzOkpc/HYQbacRLntiGvYwiCsklz7/QxgmkFPcHGEFK1NRxq34JVErHEwNsCCFyMaI/llwEIydF01SWgAJtW6mlVQP2LmHFcTXKMC0GRdxQJiRPLZ7HqSGUtho0kf9uKZYN9n9j6jydrdoNxCwsRy85B5dIIGp8m3uh/95/fJZaPhIfRn58QZc3/XChu/srqbB6MzU85BDaccd/hD+v22PJyaIueDWfOuUIW4UYC49EMcRGMZinYrgrLaX2FxyizHEElIqYOyj7E3JY3Q3oD9ziMVXPmQVk3ikRrg9+K09JLN3jHmcMD7n5TcqqL6BxWSnWvV4tBSTNEBTYwviIT3YSl+GNaR04kSLgiXPBEjw4UyDjl7aAmBke8NylRFW+AaZtrYyuB7EarBaipXYScdt2fMdpUZ9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199015)(31686004)(2616005)(66476007)(26005)(6512007)(186003)(38100700002)(478600001)(36756003)(6506007)(316002)(53546011)(6486002)(83380400001)(2906002)(6666004)(8936002)(6916009)(5660300002)(41300700001)(54906003)(66946007)(4326008)(8676002)(66556008)(86362001)(31696002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7940 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 062c7779-9b27-491e-25f0-08daa1ee52ee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cNZ6rY94jFsTvhS+6kfHB0lBmQSKwuBkuR2KztVP4DqEwZL4Uishj08RRc1ySAgwdKDdqaqplt/E8cUMiNO1j6zLi0OYYhtsXsKBtLmXV2pe6vQqY+SFHTIC8oLgK6dy8TYnnSWaWFRnMkbpJTQ8IR4FAOm8R6rsA3IjF0Hr8zbPdZ12BdYhKqxCy4yqFfVizqem76FnGEjK5wMiNY2Dr74dQusMD69f/7iZOF+BUk33AjkL9+xn4la0mNR4uwFnsoQJJ9HzAPT0gEO3owJt1V47uifxpkJcnyLL19vnmRxMgwrJOoRks+Js0cVLPxx7AW6UYcBRgr5jJSDmJRGTsAQGUHfNAv0UM/Z02dXGcLwrfjlyvWVaGrLObr1vI9zj9ziE/R8Do4I4cufqkBkSk6zQjFAbS+3MVOLXjeZr05BOuB71gyRAkZFkMwijuXwoR3X0h1SECCE5ZsEvAm3mK2BNCC4Axib7hn6ApFNSDUPeu60JTLypwSlec+lI3/eOEhX1DEPbfVtj9qznhJykzseTKhlEiix9Ae2tZM5j4rxxtmrwv1PD/qZ2pyTJKkhNfjiS40kscpv7BqlWpjDgN5IO6wfnnxi+cautg2gviBTHaNlHv5SDOH2wuCbAEFLVm8Ad2Z8HALpr50wJNLFmrhbt3c9ZQOCnQ3Qiwg4gsMzG0G/ifoBk/c554WanzDVabEAdyUO98283rHVs9Wcm4rOHUz6J5WdRaezoqYn1+QbPIFsSMci6tLieIOtM2kvtjIU6FDffCWrWMf3i1/m/HMlZl+3YUqXoI6r/6cAAGESMIu4SviQ7UcDvpbmGWlYOe1NkHLuI98W4MGybmpZLGA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(6666004)(54906003)(316002)(6862004)(86362001)(40460700003)(31696002)(8936002)(41300700001)(186003)(2616005)(8676002)(5660300002)(70586007)(70206006)(36756003)(4326008)(82740400003)(53546011)(6506007)(36860700001)(336012)(2906002)(6512007)(26005)(83380400001)(81166007)(47076005)(6486002)(31686004)(40480700001)(356005)(82310400005)(478600001)(21314003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 07:43:50.8180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce829e70-e6a1-4114-b329-08daa1ee59dd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8057 Hi Jan, On 2022/9/27 16:19, Jan Beulich wrote: > On 20.09.2022 11:12, Wei Chen wrote: >> There are some codes in x86/numa.c can be shared by common >> architectures to implememnt NUMA support. Just like some >> variables and functions to check and store NUMA memory map. >> And some variables and functions to do NUMA initialization. >> >> In this patch, we move them to common/numa.c and xen/numa.h >> and use the CONFIG_NUMA to gate them for non-NUMA supported >> architectures. As the target header file is Xen-style, so >> we trim some spaces and replace tabs for the codes that has >> been moved to xen/numa.h at the same time. >> >> As acpi_scan_nodes has been used in a common function, it >> doesn't make sense to use acpi_xxx in common code, so we >> rename it to numa_scan_nodes in this patch too. After that > > numa_process_nodes() now? Oh, yes, I will update it. > >> if we still use CONFIG_ACPI_NUMA in to gate numa_scan_nodes >> in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA >> will be selected by CONFIG_ACPI_NUMA for x86. So, we replace >> CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_scan_nodes. >> >> As arch_numa_disabled has been implememnted for ACPI NUMA, >> we can rename srat_disabled to numa_disabled and move it >> to common code as well. > > Please update the description: arch_numa_disabled() appears in patch 5 > only. Of course if you follow the comments to patch 2, the wording here > would be correct again. > I will update the description. >> +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, >> + nodeid_t numnodes) >> +{ >> + unsigned int i, nodes_used = 0; >> + unsigned long spdx, epdx; >> + unsigned long bitfield = 0, memtop = 0; >> + >> + for ( i = 0; i < numnodes; i++ ) >> + { >> + spdx = paddr_to_pdx(nodes[i].start); >> + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; >> + >> + if ( spdx >= epdx ) >> + continue; >> + >> + bitfield |= spdx; > > Perhaps to be taken care of in a separate patch: We accumulate only > the bits from the start addresses here, contrary to what the comment > ahead of the function says (and I think it is the comment which is > putting things correctly). If one node has non-zero memory, the bit of end will >= the bit of start. As we use this function to calculate LSB, I don't think only accumulate bits of start addresses will be a problem. Instead I think we should modify this function comment to say why we only need to accumulate bits of start addresses. > >> + nodes_used++; >> + if ( epdx > memtop ) >> + memtop = epdx; >> + } >> + >> + if ( nodes_used <= 1 ) >> + i = BITS_PER_LONG - 1; > > Is this actually going to be correct for all architectures? Aiui > Arm64 has only up to 48 physical address bits, but what about an > architecture allowing the use of all 64 bits? I think at the very > least we want BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG) here. > Ok I will add above BUILD_BUG_ON. And I also have question why can't we use PADDR_BITS here directly? >> + else >> + i = find_first_bit(&bitfield, sizeof(unsigned long) * 8); >> + >> + memnodemapsize = (memtop >> i) + 1; > > Again perhaps the subject of a separate patch: Isn't there an off-by-1 > mistake here? memtop is the maximum of all epdx-es, which are > calculated to be the first PDX following the region. Hence I'd expect > > memnodemapsize = ((memtop - 1) >> i) + 1; > > here. I guess I'll make patches for both issues, which you may then > need to re-base over. > Thanks, I will wait your patches. >> +static int __init cf_check numa_setup(const char *opt) >> +{ >> + if ( !strncmp(opt, "off", 3) ) >> + numa_off = true; >> + else if ( !strncmp(opt, "on", 2) ) >> + numa_off = false; >> +#ifdef CONFIG_NUMA_EMU >> + else if ( !strncmp(opt, "fake=", 5) ) >> + { >> + numa_off = false; >> + numa_fake = simple_strtoul(opt + 5, NULL, 0); >> + if ( numa_fake >= MAX_NUMNODES ) >> + numa_fake = MAX_NUMNODES; >> + } >> +#endif >> + else >> + return arch_numa_setup(opt); >> + >> + return 0; >> +} >> +custom_param("numa", numa_setup); > > Note that with this moved here at some point during your work (when > allowing NUMA=y for Arm) you'll need to update the command line doc. > I have prepared a patch for this doc in part#3 Arm part code. >> +static void cf_check dump_numa(unsigned char key) >> +{ >> + s_time_t now = NOW(); >> + unsigned int i, j, n; >> + struct domain *d; >> + const struct page_info *page; >> + unsigned int page_num_node[MAX_NUMNODES]; >> + const struct vnuma_info *vnuma; >> + >> + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, >> + now); >> + >> + for_each_online_node ( i ) >> + { >> + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); >> + >> + printk("NODE%u start->%lu size->%lu free->%lu\n", >> + i, node_start_pfn(i), node_spanned_pages(i), >> + avail_node_heap_pages(i)); >> + /* Sanity check phys_to_nid() */ >> + if ( phys_to_nid(pa) != i ) >> + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", >> + pa, phys_to_nid(pa), i); >> + } >> + >> + j = cpumask_first(&cpu_online_map); >> + n = 0; >> + for_each_online_cpu ( i ) >> + { >> + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) >> + { >> + if ( n > 1 ) >> + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); >> + else >> + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); >> + j = i; >> + n = 1; >> + } >> + else >> + ++n; >> + } >> + if ( n > 1 ) >> + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); >> + else >> + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); >> + >> + rcu_read_lock(&domlist_read_lock); >> + >> + printk("Memory location of each domain:\n"); >> + for_each_domain ( d ) >> + { >> + process_pending_softirqs(); >> + >> + printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); >> + >> + for_each_online_node ( i ) >> + page_num_node[i] = 0; > > I'd be inclined to suggest to use memset() here, but I won't insist > on you doing this "on the fly". Along with this would likely go the > request to limit the scope of page_num_node[] (and then perhaps also > vnuma and page). > memset for page_num_node makes sense, I will do it before for_each_domain ( d ). About limit the scope, did you mean, we should move: "const struct page_info *page; unsigned int page_num_node[MAX_NUMNODES]; const struct vnuma_info *vnuma;" to the block of for_each_domain ( d )? >> + spin_lock(&d->page_alloc_lock); >> + page_list_for_each ( page, &d->page_list ) >> + { >> + i = phys_to_nid(page_to_maddr(page)); >> + page_num_node[i]++; >> + } >> + spin_unlock(&d->page_alloc_lock); >> + >> + for_each_online_node ( i ) >> + printk(" Node %u: %u\n", i, page_num_node[i]); >> + >> + if ( !read_trylock(&d->vnuma_rwlock) ) >> + continue; >> + >> + if ( !d->vnuma ) >> + { >> + read_unlock(&d->vnuma_rwlock); >> + continue; >> + } >> + >> + vnuma = d->vnuma; >> + printk(" %u vnodes, %u vcpus, guest physical layout:\n", >> + vnuma->nr_vnodes, d->max_vcpus); >> + for ( i = 0; i < vnuma->nr_vnodes; i++ ) >> + { >> + unsigned int start_cpu = ~0U; >> + >> + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) >> + printk(" %3u: pnode ???,", i); >> + else >> + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); >> + >> + printk(" vcpus "); >> + >> + for ( j = 0; j < d->max_vcpus; j++ ) >> + { >> + if ( !(j & 0x3f) ) >> + process_pending_softirqs(); >> + >> + if ( vnuma->vcpu_to_vnode[j] == i ) >> + { >> + if ( start_cpu == ~0U ) >> + { >> + printk("%d", j); > > j being "unsigned int", would you mind switching to %u here and below? > Ok, I will do it and below. >> --- a/xen/include/xen/numa.h >> +++ b/xen/include/xen/numa.h >> @@ -18,4 +18,71 @@ >> (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ >> ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) >> >> +/* The following content can be used when NUMA feature is enabled */ >> +#ifdef CONFIG_NUMA >> + >> +extern nodeid_t cpu_to_node[NR_CPUS]; >> +extern cpumask_t node_to_cpumask[]; >> + >> +#define cpu_to_node(cpu) cpu_to_node[cpu] >> +#define parent_node(node) (node) >> +#define node_to_first_cpu(node) __ffs(node_to_cpumask[node]) > > I can't spot a use of this - perhaps better drop than generalize (if > done right here then along with mentioning this in the description)? > Yes, there is no code using this macro anymore, I will delete it and mention it in the commit log. Cheers, Wei Chen > Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 07:59:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 07:59:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413503.657180 (Exim 4.92) (envelope-from ) id 1odoRi-0004nk-3F; Thu, 29 Sep 2022 07:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413503.657180; Thu, 29 Sep 2022 07:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoRi-0004nd-03; Thu, 29 Sep 2022 07:59:02 +0000 Received: by outflank-mailman (input) for mailman id 413503; Thu, 29 Sep 2022 07:59:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoRg-0004nX-63 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 07:59:00 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10074.outbound.protection.outlook.com [40.107.1.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 929f1539-3fcc-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 09:58:58 +0200 (CEST) Received: from AS9PR06CA0235.eurprd06.prod.outlook.com (2603:10a6:20b:45e::34) by PAVPR08MB9532.eurprd08.prod.outlook.com (2603:10a6:102:312::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 07:58:56 +0000 Received: from AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::64) by AS9PR06CA0235.outlook.office365.com (2603:10a6:20b:45e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19 via Frontend Transport; Thu, 29 Sep 2022 07:58:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT056.mail.protection.outlook.com (100.127.140.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 07:58:55 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Thu, 29 Sep 2022 07:58:55 +0000 Received: from cf5f8e8847ca.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D2543D1F-406A-47AF-87F9-379BB5B2B3C6.1; Thu, 29 Sep 2022 07:58:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf5f8e8847ca.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 07:58:48 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB6586.eurprd08.prod.outlook.com (2603:10a6:10:23f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 07:58:44 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 07:58:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 929f1539-3fcc-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lY3UP9uQVECo3TIErkTdAEm0FG0MA3a6lgcAsjJphzMt/J6d/9QyIB1bo8HJJ2iDKglNjUhEtZDs0JKXUiTatKNIvoi3K/karYXJqa/3zsN4ee9oK9TvvdJB1dB90y0dq9wxtfopHg/IWsdoHcXZU3ZZ7QBPf9t/r65vG7uuI80239oQwQ/a0yAuMQpOglZZ+iSdJc63zbr4ECzMB6bvEYCm2jhyYbse0K0Gix9y6pPqQUMEI2fhGN4HBu+7GRrJxbcZgXajG5J0Q6lEWhWz5rDzzCDMPZcRB7AACIfLhCoTSIyC0L7LYpC787Ar+KDfase6iuMD+s6PY/RQGTFG0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVUB/AKB85Vte6N9diczScXiOxSaW3nHO/laeJK4ofA=; b=FC099LHnmm5nYx8ZdcY0/pIRoYDcJkX9x/QMdlGmsBSV0Ykv/TzC9Un5ncDEqlrnVC8zjix1b3lMtVrzS2hTmw+5/EPIWeC0Y9kenBZHz9mNPLPCXO7jvvZ7Q0vgsqVaWBVg04mu4nk02EOrq1npUL0Zc+yg6nlZO21qPQ2eNquCIeV9GpmUuwI4haThUCAcP+t//75K/CRTwUOdSOyu4I1qdO/IwTHvzYKkuIHyemuHrQJ4PSPSDxJClWHa74W5hj/C2SQrRJ7aPNzUJ+Iy4whSfovSsNkI5SI8TyQ64RveydXTtDjuP8n/56prV/0HjRe7bWAPD0u9y4evpWlX+g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVUB/AKB85Vte6N9diczScXiOxSaW3nHO/laeJK4ofA=; b=BJ5Ti1n2UVzhZgxUKdkbw3PGwO8c2gl4nLKphaOWpjcfIBdgmxkhLhHgDoAb9WmXHDxzkhLag6OlZbek5292BMNigztZjsLyiVP9sCE2mSTmgUaG6j3R8aCRgIiw5hE7Ioxu14PgSWqi884cny8gkE3AZDS1LwelPzq9YEu8hzM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cc32e94498152417 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUfqe7FQGaWOADUHnnl9vW7grI7IyKPH/Z/2DSFWC27FVNdRVXU9fYUDc7sEU8HH5qvIcfH+yLsP3JAL5380FFlN1JsDcXeRJ/L0K9hB8vvCxOjeowxiwNX9b4AOreMM+vX5BddAFaMLhe5tt5Hh9rAg8XF9arCDa1rPDe7CDtPru+09Vj8GYulfBT0752iD4yVwdpRZgnh7kOZwectleXv3e4rLgavt4H7tOagieXYkDC3fm3oPW7Prc+EAzYW4uQobeEvETbwj2MSLnRxmu+Ifuu9y2WrXd8ey4FrFaL7dHl1as/F5t0DzBZF3XIh+fOHBWzxcpED2Uyw3EpYnfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVUB/AKB85Vte6N9diczScXiOxSaW3nHO/laeJK4ofA=; b=LCmx+vl82QyxSHN+kB8lmFtESzne//vJuRVGgr1CComBIdXzizoXnYsrP5eYLRR0X3NxXvBLhSvs3DpfC8ohMmPKd9mqCAlW19AOeX9k9FSLccUoB8F7jq1/zky08DSn9MQ6xgwrYoGPCASUMdoXSe6Bk06V2Q9C5dShgcz6LfFi7K0P3JqHcqNYZV5f4TdnRYTFzJhblajkUI8etHybECWMDKFe6zE51+aWS8tSuGLAhJRxV9CsEIPLy7diflAIDV34vl154WYwbQsYWBKgBgpKAEtgdaQEIsf528o4TiK0wwypv2SYXTomijm2lD3whbBMmh02zWpXxRJgP0hb5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVUB/AKB85Vte6N9diczScXiOxSaW3nHO/laeJK4ofA=; b=BJ5Ti1n2UVzhZgxUKdkbw3PGwO8c2gl4nLKphaOWpjcfIBdgmxkhLhHgDoAb9WmXHDxzkhLag6OlZbek5292BMNigztZjsLyiVP9sCE2mSTmgUaG6j3R8aCRgIiw5hE7Ioxu14PgSWqi884cny8gkE3AZDS1LwelPzq9YEu8hzM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <82b9b153-46b6-429e-30b3-b30ee0e2f59b@arm.com> Date: Thu, 29 Sep 2022 15:58:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Jan Beulich Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-3-wei.chen@arm.com> <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> <504534ec-32bf-0bab-7a61-86d75b6e1f71@suse.com> From: Wei Chen In-Reply-To: <504534ec-32bf-0bab-7a61-86d75b6e1f71@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0045.apcprd02.prod.outlook.com (2603:1096:3:18::33) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|DB9PR08MB6586:EE_|AM7EUR03FT056:EE_|PAVPR08MB9532:EE_ X-MS-Office365-Filtering-Correlation-Id: fbcf5688-8d3f-495c-f47a-08daa1f07538 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NQVjdjayjLMgL969G6ptQz7OIAMibSD7G9dNQoGH2ccyqL609Io3nIT5mGtLNrHQTPA4Oyj2Pckeh+6g98iBEe559uazJJwn23Xub1VjGx8PAMb9mEbxEvA3qjmqmbD6BunG8qYEMck8LQJq62mAiPP52vk5B8u9j2Mpy5i/URAo6XTiufztENlm1792n1N7fiQ6tcTLopEIkMSBGAVZ5lUvNpD9tk4bVXRlphKduHO891+2lrieNjZESl29Sejo25Xtzmk+Ft5LMxaBowsp6CRELzdvKGUI7zj0elIfDDqgPvUeYRs9WLI18nXOM4yu+KJ98apk9xLi57Fqzlc1OA4vTHY0xXu5MmJpLvUsNyihV9DFRT3CGEqvOuw4hkuMpJuTMtqbyeOeND4S6MGZaAKLR0znxYg9svv7ni2tmg3+oq7q9W1UfgcHCIgTdNKfH/mHm+O0RVB6w/8ZHoUkqYLX/L+/psax8s5aj8HSz8NDJ5hu7+aCvkqawMLgc9T4lZN5TUuWPdL+ZURZ0OLaaEUSdyPsmg0QJEEUFFBibs84qscV4D6BiHyC6kvmVlE08iI1gY3dwHwio0JGaoboIm27fHHYKBOphYA6Jp0lo5Z99iSUcU/ZGVYhav/GjxDK55unnYGoj6Qhk7tFAhc09ttpKBoZf0B7TLH/Dz4bKkImb6+ul9x/EZtzPr5ivl/NuzBeJarkckSKCb/SUp6um24VOC3FrC78XaZjK5BDOac/XcUxRaamqL8zztXmP9pTCdz8KVXDp02o2u7YPmEwCoapS65O8LcZT7uI8MABZRM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199015)(6486002)(54906003)(6916009)(316002)(478600001)(66476007)(5660300002)(4326008)(8676002)(66556008)(36756003)(38100700002)(8936002)(41300700001)(66946007)(83380400001)(6506007)(53546011)(2616005)(186003)(86362001)(6666004)(6512007)(26005)(31696002)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6586 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2880dc68-78d8-4250-4b48-08daa1f06e09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cuJfhaUsGIUuKiN3M7MReB83tA38zlGxhx7ikUey0wZBgGQkHkQuVgjs2FIEyTSeH2jDw9KEXnBSxw7UNKWG5Pc97QWyD2cM02z4dEOcpxdxyuORNgZ/nfrG056KEbaPP8HIst7wywnvqGWgcPyM7bmfSUEQzw7rL/fmIXvKRzm9xx7uN+7g2Tiik/uVQr0MbkMla2Ewub2fMYRzrKizdQfGj89mpzLenAJQMeGISBBSsH6Gdwa6wJcmHGnRGYxmOwrDpl3axZxnMiTK4Tuf1nQRwsQ9SzJWPIdyrQ+uKFEzQUkYhu71nkIWnpe2Bw112qY1jm8NRg3Fh4aH6Ic8hV9/I0av03paCM+7TrN7lpspN8wK8MxJLVCLj4sVB9Gx1/jZq4DlHOk4DsYE1bTkXYz0UWoQmkJBQTmdFqW1ZlZ9V0SN4YGxNd5uf8FoqTcAQn1vPtZtTiKTXz3ECTRcb3fwIdUjGApB92kX9u/m7YSQfcOe6WzdNI100dcSusVXI3O8RF7ZSPHD8RcnhJlvPgFo8LYCxEW4aGLoUX/DeSeaaqRH9eHQqCseJpvorUUEbPaXJQK/+c0NrggURGPUCRZ56nlsVQqi/CTMFvm7jQQcm8y7trg9V5rJmN9VAEam/d5TESpHUHoqvUytOoVmpEAQpphkk1D8oCOol4n2J4eTAdp79gXtu47fggSX+X1LsxPdMsIlQoCF4mL22BSMGasZcQ+bv8qxxOQCu1TOJtOXIAvrXzkfbJMHqMwbo8hYP4yMneDDX913oQ+wk6uvwta6KipdUJDOszzePlf+BfYyfvIIpPYUyXwyyOtg9J5h X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(54906003)(316002)(31696002)(86362001)(336012)(356005)(36860700001)(81166007)(82740400003)(31686004)(186003)(47076005)(83380400001)(2616005)(2906002)(26005)(6512007)(6486002)(478600001)(6666004)(70206006)(8676002)(4326008)(6506007)(70586007)(40460700003)(53546011)(40480700001)(41300700001)(6862004)(5660300002)(8936002)(82310400005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 07:58:55.6767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbcf5688-8d3f-495c-f47a-08daa1f07538 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9532 Hi Jan, On 2022/9/27 17:39, Jan Beulich wrote: > It's the comment which is wrong - it wasn't updated in Linux commit > 54413927f022 ("x86-64: x86_64-make-the-numa-hash-function-nodemap-allocation > fix fix"). Our code was cloned from Linux'es. In fact when memory is not > contiguous, too small a shift value might be determined. This in particular > also may matter for the lowest range covered by any node: On x86 this will > always start at zero (and hence won't influence the final calculation), but > iirc on Arm memory may (and typically will) start at non-zero addresses. In > such a case the first node's start address should be ignored, as it's fine > to (kind of) associate all lower addresses (where no memory is) with this > same node. But that's now indeed something which will want taking care of > while making the code usable for other architectures Sorry, I hadn't read this before my last reply. I think I kind of understand what you mean now. If we do not ignore the lowest memory start address in the node, then the shift we calculate may contain a part of non-ram physical addresses. But if we ignore it, which address should we start from? Counting from end may ignore most of the ram area on this node. Cheers, Wei Chen From xen-devel-bounces@lists.xenproject.org Thu Sep 29 08:16:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 08:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413512.657191 (Exim 4.92) (envelope-from ) id 1odoiT-0007og-Qh; Thu, 29 Sep 2022 08:16:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413512.657191; Thu, 29 Sep 2022 08:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoiT-0007oZ-N7; Thu, 29 Sep 2022 08:16:21 +0000 Received: by outflank-mailman (input) for mailman id 413512; Thu, 29 Sep 2022 08:16:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoiR-0007oT-Ir for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 08:16:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fdf7b41b-3fce-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 10:16:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8640.eurprd04.prod.outlook.com (2603:10a6:102:21f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 08:16:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 08:16:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdf7b41b-3fce-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ygd3aHVOj266XAvXYzAQ2VXPvW05jiW9UuU4wpWVj6PgwsRuhMR9dprAw5Q9OtUnHN70IoJovYWI7psmDyEn/XDSa6OG9ER5T9cwyLX0R3AAXTHQmwDhIjpglwgdXgYd46RkHAM8nbvBawtQs7GstNmAHKC5JPUyLNkzV3FL5Fr7gaVEE5RGGR5QhgPmIq82cqNlQz8Fsig5n6juG9CIGEJKj4SmdR0r5VowbH9znhIaK6ua/gY3ag5zm1gDBY6GQ1WMKhK1i4DhGXgTGFd/qEqDhUprnAY0dlozdR8fciuvebsPcJN+ZsRValI9B4tnB1743E4XaPtbVuV8heQB4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lGv5fb0NBktJ6dJZ7eghENme7t2EHi0tAiN0dfWnS0I=; b=FaFrFlSwu9rcjSJjibwVLtZUKAtTYXmVtOhUCsEqk+TKG4kTTwbgL9mh1eEpd9VrcknL71RGQAgW1SVB012N9n77dkiGxIrWhYtYcpWR8YFJuVDZOisJmSox+r0CqV14miFfoICPrplRd9mWso6akvR5oNhNzH4Db7F2qxXsWLHB01FghaN9yX3i92Qc8eYmESTKQPiTPnu7nvJUFbhKiy1J2oGGvRCVnDFR5uQIeX3D8mCacZP5tJyn6jQSH0p2/ifxwac69bdKUBW9VkDHMcu7w+hNTiTl6rpM5PvgkeY0Vb23BSnn+3BWf9h+KaB7QwLFD1HLs0rp5oLb0Vkhgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lGv5fb0NBktJ6dJZ7eghENme7t2EHi0tAiN0dfWnS0I=; b=dC5ld7iIrNUJCLLD2E2QHs0IbMIlGgnNnGWbtCil6dloN0Dx60GIvF2MF4YkGYN+Q1OiqolJRIOORaji82TWmJxCYCHAzo74tpXVTa59BY0rF7NVpqsWT/9hPOUk4+yZ3uRaSggZgYk88rpORxwdxgwXwbSkId+G38Ksiw0ho/CDPLkT8VJM07w2K0Wc6ruOY19yUXweZglWcqWGI6QTkmIKOw9LvV/RffXxuD6ndb0VqXzwpXVei0fUzByQ5INln9+MdJl274XW9vlihITeSutN+mHaEagSYlbgY5nq8bHqFrG2afIE106C2/ZL25tFEjTz/R5R+mew+SC5IWoZSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <72674ba2-bc76-9e4c-7591-5588ff0c1f77@suse.com> Date: Thu, 29 Sep 2022 10:16:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: "dpsmith.dev" References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <9340769a-d3cf-a7bb-f8f4-dc9bde463c02@gmail.com> Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: <9340769a-d3cf-a7bb-f8f4-dc9bde463c02@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0265.eurprd06.prod.outlook.com (2603:10a6:20b:45f::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8640:EE_ X-MS-Office365-Filtering-Correlation-Id: 87093102-a3a5-462f-17b0-08daa1f2e137 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ne9uNHyj7TEJf7HlXj3u48aqMeIqEjSqct86nUuN7xVkfmZf2II+CM84/8rM1vIUHGQQPL085Ydy2pfwuwvGKcnhMly4nSrKgCPRzVHUaDYWtLSk5a5JaP4xjX/3NfWJSA69rMbNsJfX+C5AUq01yOyJPePZWuxtZ9nlWLAVfo/FYiyN3Z2Gg2rp+Y2NBP1CCcu15rRT1rQKM78QXgCppBMYsLtWEZE1/fvZGqo76eDAqLnkp0CwlOtQfClR9hV0XQNuP/Pblpz7Mi4Kk+9NcRdlIgF6HC/s4b4XM6Xo+WKDHcNs2KM5iSTU52NZZ0JiT0YzD0QWoOzehLZWVI4UrI3EgevR2s2va9g+R0GSF7HEAQidOBcpbM6pU5+c8+HevdYWARU1ZPlgxpxxJv+tV4Hw72p3n2kDz0AX2Zwk32pOVALdmfJmk2CulFWliki0YDgZHW1U1vEc1T13o9qP0Nu4V4XxjhwJe7TUJuooIWWR+aYW++ics8gcCydRr+RHFZZbu/+GYmCbKbhDwlOxaUADK/d5ARK56PiCKxB5C/LDH5kaWLlFLhVwYP3GAHhd0tfJqs49P9R8Y1jzBMPc9W/s93orgtiiUOQ13eDuBiFtl+KwgnfoGS+wZMu4IBqhl1R5RItwYgYJW9tWmoUys3WCkhShGcM5i+DbB9BATi0KyMhYYGTya8vACkWUVg/EVu5iEbvCe9moNS7H/cg+96bSDaHISvXaHs4qHmGneZ8kd7Bo4oY3kM9ZWHfTzRMDiHt0crgfW2p3lHg8//p1Jsjvl8kPrbgYNZ02rRbs46I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199015)(26005)(316002)(6916009)(6486002)(8676002)(478600001)(36756003)(4326008)(38100700002)(5660300002)(66556008)(66476007)(41300700001)(8936002)(66946007)(83380400001)(2616005)(6506007)(53546011)(86362001)(186003)(6512007)(31696002)(31686004)(2906002)(66899015)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVo1eTlMbkFPZkpDazZ3b0hjRzN5M0dONm5DenV1dnpvd2ovc3VOSVJpZHRk?= =?utf-8?B?OVN4bVNmQUVXblVGK3RzR3JWbkg2WVo1NWJoUVh3aTFKNnhvcVZvbTBIRjR2?= =?utf-8?B?b3lqQzVhVHhtS1IvNFR5eXJVNTRQYmdjaVRKRkV3TGo1SUpqWTk2aThVams3?= =?utf-8?B?bDVoOFdDeUJlM0pLNC84NkxpY3U0NFQyL2RwV3VjOG9ua1IrUGtuRGJOM0pO?= =?utf-8?B?cThtSkhQd3EzRVFxSFNqUlA0Rk1zZGh4UnlJWC9hN2NiRFVQWkhjQ2l3dFlP?= =?utf-8?B?S3BOaEhXQ09DS0Y3cW5GK0E4R0c3aGdNdjFOd3pZUkxnVTB6VXFaanU0N1pS?= =?utf-8?B?aVdMQVF3NUszdjNSQkR2OUhIQmh5OTl2V2RtOG9sTG1wM3BEZC9hVmkzMkNt?= =?utf-8?B?NGdMN0RTQTVNSmtrTVc3OXg1MTl5OHlIbVJYSDV2OWlEaXFlSHFSTG1jSVkz?= =?utf-8?B?U3lTTFhScEsxcVFyUjl2V2kzVGwrYUdsU09sb0FJbVNXUXA0LzRUMkxQSDJI?= =?utf-8?B?SkZtcW1xOGdQZ1FZdldRRGFiTXRIYUE0cUxiaGZZeWRQbnF0QmUzaGVPQkhu?= =?utf-8?B?ZUw4ZkZkLzVCVmdRVStSL3QxWGR3eE1jNXBZb0JMQUd2bTNrRDFhR294c3or?= =?utf-8?B?SG9YOSszcHYyNllEcXcxcUtRTHYxeTZZZENGQTJYSWZEWUZUVDFqVXNWMk44?= =?utf-8?B?d1VzamJsV0pmN3NibWNNSFpWU3hoTVBpbDhsVFJvZVIxbUpUUjBPNkxPcGRv?= =?utf-8?B?ZGVlaVI4MEg3b0ZyRlBBOXkrMzI1bGxCMDlySC9kamlRNjNnZ1QybFA5R2lK?= =?utf-8?B?czhNeE1vMUd2TUp3aSttaGhhY0phNUYweFZVZkhNWEl3RGd4QVBIYmROL3dR?= =?utf-8?B?anpFR2JGSVAwcDRkK2U4VEpaWU9rS0Y0V1F4eEpCTy9aWWtucmx3Mm1VUVh2?= =?utf-8?B?WEd4YTNMcERjaGNWL2E3OUN6QUdwOGoxZC90Z1phdlZHMldMdXpXTW4zaGNk?= =?utf-8?B?MWtGZkl0UFVVWWh5TE5yUHZ6QVpibTh1TlhvYm1iKzhYbzhKSTkzRWR0R0RU?= =?utf-8?B?eHJyMGxXZ0JhUFJsc0RvaEZVNmR6bmEvZzdUeWVzcExmMTNZbXluUUxaMHhU?= =?utf-8?B?Y2VDbHljMDgvRWxycGNWWFZwS25uMGZuZjZ6RkQrUlZnVEZQWGhpY3VSbmxI?= =?utf-8?B?U2lGaGZTTzlSQ3QyTlpkbEtvaHNoNWVFQnRDV01zdHBUc1FpWXM4VnRJcUEr?= =?utf-8?B?bGZCVGpQL3JoR0xzdUlpTUVVYXNRS280bmZZVjlnSXFtK1BhYjVVazZqbWZJ?= =?utf-8?B?dHBoQjRLRXVnTUovbkluQ21reDZ0NUlhRUJ2UExwWWZaYTVkMlJudjlGUzV3?= =?utf-8?B?d0Y1V2hjcFFlTFNQK0xLV3FtSHNPTDJoWlF4ZUNrdG9PQ1NiQ0NLSElVK1BR?= =?utf-8?B?YXRxN3E5YWZBamdyY0kweDMrSzA2UWZQWG5NaFFIRHRYTjFUSW42QlpnaVdP?= =?utf-8?B?b01nNWpXVU5HZDdleEcvaVp6N2ltUm1ldC9EaVR3bnJMblgrYVJyVTByYWp1?= =?utf-8?B?Y043VEg5VkU0Ujk5dUhQOWdhTWpyOGdnbEd1TWhiTWhXVmZkQzM0Qk9uWmlj?= =?utf-8?B?cUF4YUxFUFlJRGdRcXdrSUkzRDU0MVV2YVp6cDBrODIzR2NkcTFodjJOR0M4?= =?utf-8?B?VHNHUGNxS3UyNkNnQlVVY3NzL1VtKzlSUTczc3JSNHJCSlpYUmJJT0hobk9G?= =?utf-8?B?emJxWWVLSVpObUVtZFBDd05LbHZTUnl1TzJSZkkvb2xRQXNFbGN2RlpXR1VJ?= =?utf-8?B?OU1pa054cENieVZzQ3dFYlVlQlJMdW40VXk0YW90TVppRGJWK3NTRkdGUG9U?= =?utf-8?B?R1JiYmZuSnlsRUhxRk5JdDNVbWtTRmE4R3RwNnFoWmNFbThtRER1ZDVqd1lC?= =?utf-8?B?bU9neFYxOXdGM2M2VlplMnJUcXJhUVJ3Z09abU5neVRDS1RDeHZSU2ZpOHA1?= =?utf-8?B?WDBqZTVvZTd4M3VPMXpCQ2x0VWVIaDhNWG1rWXdNL3g0bUJ4Y2xaZDNyQ1d5?= =?utf-8?B?VTExTTRjeDlOTThzN3pDcEFZaURWQm5nWWpuVnB4UzhuTFdXcnE4dnZPbDJa?= =?utf-8?Q?QTAW/n6SOvseOWHkyPKF1CQoE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87093102-a3a5-462f-17b0-08daa1f2e137 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 08:16:16.0706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vyaq4yvDtwVc54ua3QNxrKE6ZY76RdITlm4phjUBiSFlvo2KXm8pky9S0mkTapKNPYQ0yTDDAYa6eO8Y1zvqMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8640 On 28.09.2022 15:32, dpsmith.dev wrote: > On 9/28/22 06:38, Jan Beulich wrote: >> For quite some time we've been talking about replacing the present virtual >> address based hypercall interface with one using physical addresses. This is in >> particular a prerequisite to being able to support guests with encrypted >> memory, as for such guests we cannot perform the page table walks necessary to >> translate virtual to (guest-)physical addresses. But using (guest) physical >> addresses is also expected to help performance of non-PV guests (i.e. all Arm >> ones plus HVM/PVH on x86), because of the no longer necessary address >> translation. > > Greetings Jan, > > I think there are multiple issues in play here, but the two major ones > are 1.) eliminating the use of guest virtual addresses and 2.) handling > the change in the security model for hypercalls from encrypted VMs. As > Andy was pointing out, attempting to address (1) in a backwards > compatible approach will likely not arrive at a solution that can > address issue (2). It may not be sufficient, but it is (can be) a prereq. > IMHO, the only result from teaching the existing ABI > to speak GPAs instead of VAs will be to break current and new kernels of > the habit of using VAs. Beyond that I do not see how it will do anything > to prepare current OS kernels for running as encrypted VMs, at least for > AMD since that is the specification I have been focused on studying the > last couple of months. Plus we'd have code in the hypervisor then which deals with physical address based hypercall buffers. One less prereq to take care of for the (huge) rest of the work needed. > As for ABIv2, I understand and can appreciate Andy's desired approach. > Recently, especially with the hardware changes being introduced by SEV, > I would like to have considered a naive and more radical approach. > Currently hypercalls function using a more ioctl style. I would like to > suggest that a packet style interface similar to netlink be considered. > There are many benefits to adopting this type of interface that could be > covered in a larger RFC if there was any sense of willingness to > consider it. As a glimpse, a few benefits would be that arbitrary > buffers, continuations/asynchronous calls, and multi-call are all > natural consequence. It would also allow advanced extensions, such as an > optional PF_RING-like interface for zero-copy messaging from guest > user-space to hypervisor. While a packet interface could easily co-exist > with the existing ioctl-style interface, it would be a paradigm shift > from the past, though I feel ABIv2 was already going to be such a shift. > Anyway, just my 2¢. I'm sorry for my ignorance, but I have no knowledge of how netlink works. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 08:20:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 08:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413518.657202 (Exim 4.92) (envelope-from ) id 1odomb-0000l3-BL; Thu, 29 Sep 2022 08:20:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413518.657202; Thu, 29 Sep 2022 08:20:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odomb-0000kw-85; Thu, 29 Sep 2022 08:20:37 +0000 Received: by outflank-mailman (input) for mailman id 413518; Thu, 29 Sep 2022 08:20:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoma-0000kq-NQ for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 08:20:36 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96f9b532-3fcf-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 10:20:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7812.eurprd04.prod.outlook.com (2603:10a6:20b:245::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 08:20:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 08:20:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96f9b532-3fcf-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SnzsTNUDRh2E0U6KCdQh+SuEwg4CM5HcJacMUksn/XC7ZlhVGi72Bw3V5QJVFI7IgIR+6bTzWzVFBS0IETYbtfXVrgWkg0+N5GymH3eVD7zkjSiiW7NKfF5ndc/wQq5yZUiN1zEbqbfeZKEp4FejASKLcKPjhJswqBjWdVm3lzcs4B3sBAVxBQ/LH41/cFpEnye1OFhCyJkZubc3EFTQnQ040YDCTXOo5o6WMD5zxhUE2HvRxYMQ7bSpNtOcqYD+EKJOS46y1MUZERV1xsbHRc2refJAvESdcmfR0YbPF2+9krkVh/ZNXb8dert5RCUudV4DmRuJjT8WY5qglxXw2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IFDh9KA9ArMw2f61TIff5eVXy26rQz8dDlZsRIL7Su8=; b=C+mKdGGpcWqjUWxkOD2eKGWvftes9/oVwXi370I9qxJw1E0FqwHQpgqn6W6bn2gmaBglorniXsxT5XRAeLFF/CRontitk5g1Do+kXw97ldYSkhhlytRvrOjC2Xi3tM1cOeS10YnJqdOLvc2qEpUqfR0Sb3Ukx5Kvqw4lO1iO02iOeuTAO+Njqr2M3WHvpAc3O/svfSEcjW1YxhS/rDl8xJ+uh8W1Wb3Rkzq/Yn88C0n6LdmnDKXxcrnc8fE19E9TnyqxpW0sAm/fpc0hgFemoe04XIK2yJ6H0tQSSMlYkuikh1RPCw2yo62855aoqJLkj1NR2wNfugp4PlfWnu+mZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IFDh9KA9ArMw2f61TIff5eVXy26rQz8dDlZsRIL7Su8=; b=rY4mS2Wa49LHZ0CEtQUAotO7Q9zm9wEitGjzEiEd8nYJoR3IVCmPqpm7HV/LJIR6a0tZ7K6uGhi1yQPmL8uSsUV2DKLw22h6BTDGBJ1SZgOdrAAx9ZPsSI8bOhl+Si1CL6vMzyTCcr7Mgc+1T4MdwP6xxrMXgMvP6tFlD20tfVM24nB1niHZfyexLpSEuCxb8GQRDhKPbzfF3Yq8wKRu8Ac+QOKtvp82IbJazan35JUQJTem2aLP6TfcbHKAeOdHX1ov/lfNwcNwbLy0zle4DA9qonM7auUNnuHdJlcN6np+vyOhqnJdJG1YpkaIMxGV8htr7esAnfR4fxA/f9MnKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0ed7940b-0e29-6c3a-cce4-f98f709535df@suse.com> Date: Thu, 29 Sep 2022 10:20:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH RFC] rangeset: mark a few functions pure Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7812:EE_ X-MS-Office365-Filtering-Correlation-Id: 1262628f-40b4-4357-16a2-08daa1f37a09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +657WgMSdd60ByRfjl1P/jATKhcwr5K17ex3ndRsnm0z3XCVO/czHYvQTRBslyNdsX/xR59G+Y1YMS+tldalF/lHhc2rKi7mhr6+i8HTdGIcK9AdzfOpZcGwHg87yd9FNlFfqqw4lfbufmYR2vOFXg2rRUAkSz2+fqUq1i7PN5jEJhaUjAjG25K9Yenr9ZaONm67vzE4E6QNWKcetQoTikbhvPjUrjpwX7OQeyip9a0QPanVzyG2uX4RRtZw5r8XEhOvlHNftCrc5PSUfmwq2zcXvXF0rjEepIs2O2UhrzFJdEe9W6yhHetZNljpmMV6g2OHUHzi/5VO2LTAAen3KD8fCEVGbdKV6rN9x13eTT5BPkdX5slpCDfdVwXo5elLuN13l/snJsCzVd8gaQtC1DKqrQf8skLBCtL//RSoVNSvm/40ftTtdBDUkwB2EIJB5mysnFMPAmvjcWAf9FHnAr+7LfRpMVzie+1oXQ7A7MJi78OqNTbhSzBXt+KLSCK2CZ3T/st1Q41LTQtZ6/zLyH8s2YKJn9cKzYgd7n2gF0Vj/OYSL0Zj9h1mzNmGLs8OAM/LjvRYeUb4kwbMFMMgaedWt3PIypUGiGk3m4/eESn7xl7QJtZQZv7pbMSryyh47+/REjF7LuTJIheYtTI7kJPLGVjlOV/+rEQGtq4WpYF+msKOCdiivL3OpFIwk0xJHKREL+sLyDAy5iD2wF6k+7S4BzyFIqRO2xOrdtejQ7Uexp7zXjqZbjTuHYR0bfyCfmLQXoq7RZ+XhtF0gRDUoe1tpeI9b7i41cWLSS7uGwM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(346002)(376002)(136003)(451199015)(54906003)(186003)(83380400001)(2616005)(38100700002)(53546011)(2906002)(5660300002)(41300700001)(6486002)(478600001)(6512007)(26005)(8936002)(66556008)(66946007)(66476007)(6506007)(8676002)(4326008)(316002)(6916009)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmcwaGluZnJlOXdoZlRXQVBGMUVhVXZFMjVZZ0Z0a1ZWYTdhamdCMUo1RXZY?= =?utf-8?B?cGFtb2pPZTc4eXc2TGR5RFdtMi9sR0R6cUVJcTMxNHJVempPTm9tWHhVRXJs?= =?utf-8?B?MXBzdXdPcXg2T3dLc2pIU1E5UzEveW9oTk9iN0gwaWpXV3lmSk9OVjF6NWg1?= =?utf-8?B?MmN4eEdkTWJTMlA1c0pDcmpOUk9nZlRid04xMEx1Y3JFd1Z3THJyYUNmckEr?= =?utf-8?B?ajc4ZnlibjAzSWZBWXMvaTA0REpTWnNMWEFIc2xvZ3pqSzJyVVpOSndUSERV?= =?utf-8?B?eXU1MDB4QTVsa2JHVUU5L1NlT1lUWlFERC9IOCtrYkJMdmlINzFiOXc4em1P?= =?utf-8?B?U0F5dzVZelBScFEyVWM1OEtnWFN1SlFLY3JGWm1QV255bHA2eXpQdlIweXZD?= =?utf-8?B?clRpeWtaSXN6bWt6aXlsa3VrNEtCdUM1TWVicFNqMTNIaU9jbm9SYUlBcVdk?= =?utf-8?B?UFlPdUVCN1NMY1dUM1k5cTM3b3loYlBCU2RDN1dIa2NLOE90N3J3dkFkTXAx?= =?utf-8?B?WGhCMloyc0VON29Wc2l4RlphR3BwRHFUajc5cHorb3NrY1FXUytON2hZSzZH?= =?utf-8?B?MDBXNXhCSW9PZ0dTQWxaWFZ5ZEUyRjUyNUVYREVrR3pZMkF2My83WmlPbjJW?= =?utf-8?B?MWVidk1SNi9YdHVlaUI3R0pIU2trUVRSdVE5KzI2SHFITTY3S0NpZldSdmpp?= =?utf-8?B?VGszRFUvR1BBeEN2alErRUM1SEFHQkMwZk9lWE9jZ2M3YXZkT083TDl2dzVh?= =?utf-8?B?M2xqUzZMTHdkbGxpYXdNNy9CR2c5TGdKZFNyVy9Oak92clFnT2Nud2hFbVhY?= =?utf-8?B?VWVoelVaWlEvaFQ4RXl5VDFWRStKQ2dzVWdNUms3MG5xaWlMM2lPRitxQmVM?= =?utf-8?B?ejVyaThJNkFXUmFVNlBwcVo3MlB6YXNuOFN0cDIwUHMvYTVQODFxdjNFRWZ4?= =?utf-8?B?dGV4bG1qK240Sjc4RTJVaE15bnQzRjRieVh6SS9QODBuNE1XM1VlelNWbHNX?= =?utf-8?B?ck1XYXVMQjkvNXRjYVM0a1ZGeWRXTjVsRWVqNkFjd0xBd3ArekhENVJ6L0FP?= =?utf-8?B?UUdLcU5xQzJaUGs1UU4wZEZDcmliVjVoQ1R3SHJYUmtZcFo1VldoTnJ6K0o3?= =?utf-8?B?OFo2VTNQcWNzbzNzNkgzQkZvRlhKWmZxU3RtYUs1S0YxdEtpUUZXRXRvNUMv?= =?utf-8?B?ME4xTTVoWFRaL2VWZ1V1MHNuVGk3RXlXM2hQcXc4TlBRZmpPVTBrL0JoTEFV?= =?utf-8?B?L3VoVzg3Ti9hZGtKK3dmS0ZJKzVvWHEwdklrZmpxZXdGZkpGYnJUN3AwUFBQ?= =?utf-8?B?blBwWjRwV3ByQ3c2YTJYMDhvc0VsZXRZdkhidndDdFZMdzhQTWYyaUhtanM4?= =?utf-8?B?YnNTeE43d2VzR3pMOG9qZGpibnNyU25lZDJxRTFGblZQRGM0WTBPL0RVZWhq?= =?utf-8?B?SHdwQXd5MnJ1TWZOR1dJMjhkU2hkWjNuYnNWQW9hdC9ncWlsV3VMUXRCVHl0?= =?utf-8?B?RktvL0NrV2QrT096ZEppQmJ6eHJnWWRuTkZTYW00MHVnelhGWWRhcVR5VVdP?= =?utf-8?B?RG5ob2Yrd2RVSW96eHlTa1pWWEVRV3NPSFVOaWVUUFJPdm04aWpRaDN2a2Zy?= =?utf-8?B?WEFnblRnSTBMZVkvRUk2S1NobnZMVE5ScmNPeU81UHlRMlduNzU4VGJ6NkVQ?= =?utf-8?B?RGY4dncrSWxHSERFSzB5N25QaS84bFB4bTNBRUpCSjhJMkZyVmYvYmF0aXRh?= =?utf-8?B?eFNpV1VOQUoyaVVFOEdMa0R4UUN4SGJUbVRjcmdLZGtwcU9ycGo5YmFDQzhL?= =?utf-8?B?Qk56YUsrdlIvdzU2Yko3Wm0zcWV1L3dZeXliWFJ0aVYvNzZtMWJpeFpIajN6?= =?utf-8?B?MVVBZGIxbHFMd3dTMFhlajNwRVdNT0NtcFVQMFdJU0lWU2xTd2VSQUR0bEJJ?= =?utf-8?B?bzRheVlBL0EzRnkvNkpvRk5INFVVWWtpaGNmQ3lKeDVidzdCVkszeGd3NjZK?= =?utf-8?B?ODFSdG9GQ21yVTc2ZzlLcWFyM0lLWEVEVWhVZkg2NDc4YkY0TG1EbWV6K2ZE?= =?utf-8?B?SEtyT2ltcEVtMVRJdnB2Ujh6QWRjcXBMSU9FSi81MUZBSlNJR3U3MEZRR2dq?= =?utf-8?Q?hOaGsVK1/QnHDCugV6aNWq+E3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1262628f-40b4-4357-16a2-08daa1f37a09 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 08:20:32.4293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AbMrZJVmyiLAd2t5jmTWm1BhocT/9uaxCg6e8wXShLk4G4zUP5ZilJXm3CM2Zwg6F5rB9gknFnnz+LwYgpp1SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7812 On 28.09.2022 16:27, Roger Pau Monné wrote: > On Wed, Sep 28, 2022 at 02:12:30PM +0200, Jan Beulich wrote: >> While for some of the functions there's locking involved, the acquiring >> and releasing of a lock doesn't alter program state when comparing >> "before" and "after" the function invocations. Furthermore without >> (further) locking by callers, return values are stale anyway by the time >> they can be evaluated. Hence both CSE and DCE are okay to occur for >> invocations of these functions. >> >> Signed-off-by: Jan Beulich >> --- >> RFC for the (imo) ambiguous wording in documentation. > > What happens if the contents of the rangeset is modified outside of > the scope of the function. Ie: would for example: > > while ( !rangeset_is_empty(...) ); > > Become an infinite loop then, without taking into account that the > rangeset can be externally modified? > > It's not clear to me whether the elimination of repeated calls take > into account that the observed variable can be externally modified? Hmm, right, this actually matches the feof() counter-example that the gcc doc has. So I guess I need to withdraw the patch and we will need to live with these functions not being possible to eliminate even in cases where it would be okay (and helpful). Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 08:21:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 08:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413524.657213 (Exim 4.92) (envelope-from ) id 1odonN-0001NX-Ni; Thu, 29 Sep 2022 08:21:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413524.657213; Thu, 29 Sep 2022 08:21:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odonN-0001NQ-Kl; Thu, 29 Sep 2022 08:21:25 +0000 Received: by outflank-mailman (input) for mailman id 413524; Thu, 29 Sep 2022 08:21:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odonL-00013i-QZ for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 08:21:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3a4e4a3-3fcf-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 10:21:22 +0200 (CEST) Received: from DB6PR0202CA0006.eurprd02.prod.outlook.com (2603:10a6:4:29::16) by AM7PR08MB5383.eurprd08.prod.outlook.com (2603:10a6:20b:102::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 08:21:21 +0000 Received: from DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::26) by DB6PR0202CA0006.outlook.office365.com (2603:10a6:4:29::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19 via Frontend Transport; Thu, 29 Sep 2022 08:21:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT004.mail.protection.outlook.com (100.127.142.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 08:21:20 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Thu, 29 Sep 2022 08:21:20 +0000 Received: from 0e9b5808d20b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 71A40CF7-2361-4EFF-B98A-4505285AF13E.1; Thu, 29 Sep 2022 08:21:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0e9b5808d20b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 08:21:14 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV2PR08MB8051.eurprd08.prod.outlook.com (2603:10a6:150:79::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Thu, 29 Sep 2022 08:21:11 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 08:21:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3a4e4a3-3fcf-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gQYiwSWvfAUJhGhAFyAYVHMYFbuv7AXPnt2jyAi/0lEygtRDmOpWyal8ym2Q3WL9WdQzmCXOWTB4yEr4kURq4IQa9sV9b7GsjixNTRDz1fVACuW4Bo0cLXvwnrXkNnAYQFOK4+TJDTSwJSWt5s2Z4Di9MRh7ODfGuH22D/i0Q8T5o7jdTAawiy4w4sTLTmzcdkCfUNP1VD6U2ZWzMsX13Xw9bLorcaPvVNEz94cSbn6hKX4vSjFcjWYSMqXM+zQq6OPLvlE8lq4ymDpGC3IXYk7JFqN0WPswQE3mIMBKL8yG6Eej+0dAo/uQ1l+z8UHjy8Ft5DZeCXl5sC12CN8l1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3e9ztFjUAK5abcVlWInf+/G3+btOG244YKSL8pbIpk=; b=Bzn0BjfsKj2V6iFul1rK5VLyExNgEXXSL9Svlgsp+6ItoYFhcQkIuHAY7KZHDzuF3nMQIdOLJK1h6QkOiRD+3YSx8ooXr8h2Ve9heHyCMMi9HAc1J5DXZ7eVZnofRioc47S7UREX8XvDDaSsNDoTzq6QbfF2neYNJNUR8Av0vKQ8lBeetOMI403A8em22mvI5e729rRqvB42KIj0U9PB8K3jHvjhkGgnMMC1Crta1F6V8cHv66zOq9CwX91VX83CH3qdfGm2pQCkUpgSf5c5y4UPOKlQQMnrv7r3vgV+C93jTTPPVx834yr7tNlaSwpKAsSVLcB7609Dp7tnipbihg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3e9ztFjUAK5abcVlWInf+/G3+btOG244YKSL8pbIpk=; b=0XpxxMHM/y7R35jWIe2gARI+qExcfBjUrsqzfReS8jbjdarNnZQBfDJu77aNkQ185oVQUrPLhufKV2fF+ZG3BTsIVoDJgWcOsYjWymXskp+kkMNOFNA2Ewk2/efpqAtek22MWbDsRdlhQHbwiccZ66Mes8nC81Iq4hkh9DUuASE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6c43a1fc89812db4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtB2f0UIFxNRpHn0F8lepaUnjxeGvJCvc7KB4BIavWJvzqSWrM7ofMCoadCJVfUDPp+sCbdX1jM9bR1bQyWE9kLkVTXpb4c1XztkXNhooNYr1Z6QbSci+OQIXBIITPwwvHbvTOvSY5BmLiCLp6+P8K5O+7jH93kZq0k3WLO11WG5l7xgAdoEzk930QSfYvNWJ9OsQLaF02WeXWLlcS96GNHXPAziWmZX0eAF4S0bzTfn9o6JCiRNgdPq6jxrzgxbr57GgCArynHu7yCi0cFkGNe5mZIkghz5OKQakD7Sgmiz1Z0775LJ8oC5zrMizh6fvziVhvF5Oworw5VEvevA+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3e9ztFjUAK5abcVlWInf+/G3+btOG244YKSL8pbIpk=; b=kEX4k7C4aveTBMhFkHyhL7ROodI8yucwqroXD7dIel9FTdjmlOu4+C03+5KBYWmF2Erw/jimJO5y1+CVbA9GDoAaxN4l0WxDQQfdPvt7xO7fwVgdbaUTAOd6Cr1j5I1pNsgHYSTNGsFfAbY86PkSSw+I0bNq/aVowB9unENqgASaBtNs88C4qIRMF/Pqpjw+adJL4Dp+8HfaqHysxokDnpCwYOnGHDc9hTguM81cBJosdup3p7ueO3KkMx4jCm2V5H5zg6T6AkTKMmvD+vY42bqYDaNLvTooTS6ZIkGbgN83SgNPdLMi6Qeue0vQEMinl4QtiY2oQdTZCi554Xeejg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3e9ztFjUAK5abcVlWInf+/G3+btOG244YKSL8pbIpk=; b=0XpxxMHM/y7R35jWIe2gARI+qExcfBjUrsqzfReS8jbjdarNnZQBfDJu77aNkQ185oVQUrPLhufKV2fF+ZG3BTsIVoDJgWcOsYjWymXskp+kkMNOFNA2Ewk2/efpqAtek22MWbDsRdlhQHbwiccZ66Mes8nC81Iq4hkh9DUuASE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Thu, 29 Sep 2022 16:21:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Jan Beulich Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-6-wei.chen@arm.com> <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com> From: Wei Chen In-Reply-To: <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0184.apcprd06.prod.outlook.com (2603:1096:4:1::16) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|GV2PR08MB8051:EE_|DBAEUR03FT004:EE_|AM7PR08MB5383:EE_ X-MS-Office365-Filtering-Correlation-Id: 24c732e9-0df5-4593-683b-08daa1f396f2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GGt4VxIt3NAaYBxIqnZlVcsTLRRUu8WDySrNsAvoJwCZtzGJdB8N8oLQhP0/1OXfDavdiCzfS6cHe+kFG3YBkNqIXxIShUn+3tmKxODhbzFF18rhncyHfSd5cutuuwpzIFaLUkN3kBZfMBb3Mb33RxAjbEBZeDxlWvl+5RjeUehleRQDwR/Q66ts9SSSc/8KE4mMSz8W6VtinHYwIonhi7+7hb0jHQd2JE9hrob6mupyoboT3qfs3NWyShhK6iPjMvk1s3leWtZ2/mL16edeAYjLS8/9bjXwdQkv94bU1/N4y4gyEuIOefGrWM9788onxUNy3k97BWcfpITylwO0M0SZ6HfyXEMINDPiuU/EJP00l3fkuZQEa00TBVV33HSQxhIcnqfOH82S86yKx1KkT4naZGga32I//vlWSx2y+fMm2XiUjeK3dzH0A82CRmz4FvOMUYB+PZ7nWQJHek8j40nYXmg/CHq5tLb8MQqT4bgfN0utatzwsKgT7bQi7P8JeKvtu2RvEmOTd8vR1MmNURF7liMVyoUnzObt/uo8bw/SorwGekITbLuBlgMBsn2JBn8vFsbYg3qSa7NCO8Z3KLUYoo6SIvKWedHfnORBYH8/gzCp67yfPPUGbvBXQx1lI1H8slsHs+xw7kQU1nzE/IFO/9STYZb/SvUpqN44GfiKKSo7Qhpj+AbABJseRU+hVi2ovt3kjGnSJN8jRLlC8E73ZyXz7h7ZYk0Y63pdPJrLzJOfAh+X63UpvcHImH/xNmbZa6hIAHKwFgzd4lGhy8mRGOpjmCMI/6u8kIcg/l4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199015)(5660300002)(54906003)(53546011)(2906002)(6916009)(83380400001)(26005)(316002)(8936002)(6666004)(6512007)(4326008)(186003)(66476007)(66946007)(36756003)(8676002)(66556008)(2616005)(41300700001)(6506007)(6486002)(38100700002)(31696002)(478600001)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8051 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b8ad77c1-8140-4cb8-783c-08daa1f390c2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vN6FdkQDKii2O4bqiJjmXoOyDqgP4OXaDept+SiTcvT4YhtYXEEoVuGbY+3z4pc7A4alFr3+lDtEXBXvv4cBHg6tZE/zjqUc4bI1S6stRIt0ClSgy8dR5T7NKZW8CYwclbmXqxpcnsRRuMtiQuYLDgrRq5E0Fiadoya1E38FCEPG+fFalmGbHgGjKXXaRTIlcQZhA/rxKqyJlVIiE0YFXyRZyNF/v+3pvIsGrrw81tqi+JnY2aYT5CBM0Wt0qQ8zDBuOsqe3fQnqr0cgwmzsGsxWkQa4FTMv7y26CCP9CSp7iNA+aVLfr9Rnouub++E7m3H6wMEAwektrnoDlP75wnUaiyJPuCuRUMBmVKMmK/UNpKG3SLyaNIM0KG1OmRT/dgySL/hvPtdSdGCFRBOIV8iC2U3DO/8DWORmxC6gzWa98DmadN0eAhzjpvbG+4gJdqDrk2Wl1aI7/t6xsUALydHaOd2whOmS1xTwQhvyxJGFvByKrCKO3ouQ93nY5bfm2yfadQjUEk6y01qj+VLn7n67r2eCiDFgJViBy8OhL1hhvlrfk0nkd0MIuhN6ph5BCL86RGPtk5LhbHxbfpg1/4LUQTh9cScu4YzrbN1WK9Z/VPRFpkynvKBp1AwxySgNgxmk0N/+cTVffPDoydxisLhIp1ggpQU1v+aAwcvMNsQzHllXPCO9TNZC+16j5JuExNRh6i6/yVGe6gjVozmT1eu3KYQ33iSsO6sfB1GBESJ8LbkQJdv2UUOFYgRO6yLQd8a9pRZilpcK2N/qZ56LYMB5p21eKxY86BB4nlHFliw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(31686004)(82740400003)(81166007)(6486002)(54906003)(70206006)(31696002)(70586007)(40480700001)(356005)(82310400005)(8676002)(6506007)(4326008)(86362001)(316002)(478600001)(6666004)(36756003)(5660300002)(53546011)(8936002)(6512007)(6862004)(36860700001)(2906002)(2616005)(40460700003)(47076005)(41300700001)(186003)(336012)(26005)(83380400001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 08:21:20.7940 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24c732e9-0df5-4593-683b-08daa1f396f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5383 Hi Jan, On 2022/9/27 23:48, Jan Beulich wrote: > On 20.09.2022 11:12, Wei Chen wrote: >> +static bool __init nodes_cover_memory(void) >> +{ >> + unsigned int i; >> + >> + for ( i = 0; ; i++ ) >> + { >> + int err; >> + bool found; >> + unsigned int j; >> + paddr_t start, end; >> + >> + /* Try to loop memory map from index 0 to end to get RAM ranges. */ >> + err = arch_get_ram_range(i, &start, &end); >> + >> + /* Reached the end of the memory map? */ >> + if ( err == -ENOENT ) >> + break; >> + >> + /* Skip non-RAM entries. */ >> + if ( err ) >> + continue; >> + >> + do { >> + found = false; >> + for_each_node_mask ( j, memory_nodes_parsed ) >> + if ( start < nodes[j].end >> + && end > nodes[j].start ) > > Nit: Style (placement of && and indentation). Does this actually need > splitting across two lines? > After covert from tab to spaces, yes, it doesn't need split into two lines. I will fix it. >> --- a/xen/drivers/acpi/Kconfig >> +++ b/xen/drivers/acpi/Kconfig >> @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP >> >> config ACPI_NUMA >> bool >> + select HAS_NUMA_NODE_FWID >> select NUMA > > While I might guess that you've chosen the insertion point to have > things sorted alphabetically, I think here it would be more natural > to select the wider option first and then also select the more > narrow one. > Ok, I will adjust the order. > One further question though: How is this going to work for Arm64 > once it wants to support both the form of NUMA you're working to > enable _and_ ACPI-based NUMA? There better wouldn't be a requirement > to pick one of the two at build time - it would be nice for support > of both forms to be able to co-exist in a single binary. We are also working in this way. In part#3, we will check ACPI first, only when ACPI is off, the DT NUMA will be used by Arm. If ACPI is on, we will skip DT NUMA. Cheers, Wei Chen > > Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 08:27:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 08:27:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413531.657224 (Exim 4.92) (envelope-from ) id 1odosp-00023v-DN; Thu, 29 Sep 2022 08:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413531.657224; Thu, 29 Sep 2022 08:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odosp-00023o-9d; Thu, 29 Sep 2022 08:27:03 +0000 Received: by outflank-mailman (input) for mailman id 413531; Thu, 29 Sep 2022 08:27:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odoso-00023i-5b for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 08:27:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d51be36-3fd0-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 10:27:01 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 813131F85D; Thu, 29 Sep 2022 08:27:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 43F6213A71; Thu, 29 Sep 2022 08:27:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1TH3DtRWNWOBGQAAMHmgww (envelope-from ); Thu, 29 Sep 2022 08:27:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d51be36-3fd0-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664440020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRyhuXmwMkLW8QlZukWqPWaxqTYhVhbGpA0KQ8ifdM8=; b=BgIt661n2anXdyW6D7SP+svUANLeuiq0//ITS+gu1sg7eJWk+x88v0xanYrnYQVHgYKMm4 1RwFbUSKfQMOStAOle29m0/GjUln8WBlPSISsW5vElok9L5MrqC5QwgH0d+H2hFPMxYuZg xAyvskX13zdmv3C91BNkm+tlqvXt/I0= Message-ID: Date: Thu, 29 Sep 2022 10:26:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------LWnRAw3GXgBlglJ5NNsTIBeg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------LWnRAw3GXgBlglJ5NNsTIBeg Content-Type: multipart/mixed; boundary="------------5WxHoVEGcQnJX10ESZlcFax9"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <314e3bd3-3405-c0c3-225c-646d88cbfb1a@suse.com> <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> In-Reply-To: <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> --------------5WxHoVEGcQnJX10ESZlcFax9 Content-Type: multipart/mixed; boundary="------------Pvv00nTI34oY5YpXg9t0w1ip" --------------Pvv00nTI34oY5YpXg9t0w1ip Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDkuMjIgMTg6MzIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDI4LjA5LjIy IDE4OjEyLCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6DQo+PiBPbiBXZWQsIFNlcCAyOCwgMjAy MiBhdCAwMzo0Mzo1NlBNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+IFdvdWxk IHlvdSBmZWVsIGJldHRlciB3aXRoIGFkZGluZyBhIG5ldyBlbnVtIG1lbWJlciBDUFVIUF9B UF9DQUNIRUNUUkxfT05MSU5FPw0KPj4+DQo+Pj4gVGhpcyB3b3VsZCBhdm9pZCBhIHBvc3Np YmxlIHNvdXJjZSBvZiBmYWlsdXJlIGR1cmluZyByZXN1bWUgaW4gY2FzZSBubyBzbG90DQo+ Pj4gZm9yIENQVUhQX0FQX09OTElORV9EWU4gaXMgZm91bmQgKHF1aXRlIGltcHJvYmFibGUs IGJ1dCBpbiB0aGVvcnkgcG9zc2libGUpLg0KPj4NCj4+IExldCdzIGtlZXAgdGhhdCBpbiB0 aGUgYmFnIGZvciB0aGUgdGltZSB3aGVuIHdlIGdldCB0byBjcm9zcyB0aGF0IGJyaWRnZS4N Cj4+DQo+Pj4gWW91IHdvdWxkbid0IHdhbnQgdG8gZG8gdGhhdCB0aGVyZSwgYXMgdGhlcmUg YXJlIG11bHRpcGxlIHBsYWNlcyB3aGVyZQ0KPj4+IHBtX3NsZWVwX2VuYWJsZV9zZWNvbmRh cnlfY3B1cygpIGlzIGJlaW5nIGNhbGxlZC4NCj4+DQo+PiBXZSB3YW50IGFsbCBvZiB0aGVt LCBJJ2Qgc2F5LiBUaGV5J3JlIGFsbCBzb21lIHNvcnQgb2Ygc3VzcGVuZCBBRkFJQ1QuDQo+ PiBCdXQgeWVzLCBpZiB3ZSBnZXQgdG8gZG8gaXQsIHRoYXQgd291bGQgbmVlZCBhIHByb3Bl ciBhdWRpdC4NCj4+DQo+Pj4gQWRkaXRpb25hbGx5IG5vdCBhbGwgY2FzZXMgYXJlIGNvbWlu ZyBpbiB2aWENCj4+PiBwbV9zbGVlcF9lbmFibGVfc2Vjb25kYXJ5X2NwdXMoKSwgYXMgdGhl cmUgaXMgZS5nLiBhIGNhbGwgb2YNCj4+PiBzdXNwZW5kX2VuYWJsZV9zZWNvbmRhcnlfY3B1 cygpIGZyb20ga2VybmVsX2tleGVjKCksIHdoaWNoIHdhbnRzIHRvDQo+Pj4gaGF2ZSB0aGUg c2FtZSBoYW5kbGluZy4NCj4+DQo+PiBXaGljaCBtZWFucywgbW9yZSBoYWlyeS4NCj4+DQo+ Pj4gYXJjaF90aGF3X3NlY29uZGFyeV9jcHVzX2JlZ2luKCkgYW5kIGFyY2hfdGhhd19zZWNv bmRhcnlfY3B1c19lbmQoKSBhcmUNCj4+PiB0aGUgZnVuY3Rpb25zIHRvIG1hcmsgc3RhcnQg YW5kIGVuZCBvZiB0aGUgc3BlY2lhbCByZWdpb24gd2hlcmUgdGhlDQo+Pj4gZGVsYXllZCBN VFJSIHNldHVwIHNob3VsZCBoYXBwZW4uDQo+Pg0KPj4gWWFwLCBpdCBzZWVtcyBsaWtlIHRo ZSBiZXN0IHNvbHV0aW9uIGF0IHRoZSBtb21lbnQuIFdhbnQgbWUgdG8gZG8gYQ0KPj4gcHJv cGVyIHBhdGNoIGFuZCB0ZXN0IGl0IG9uIHJlYWwgaHc/DQo+IA0KPiBJIGNhbiBkbyB0aGF0 Lg0KDQpPa2F5LCBsZXRzIGRlZmluZSB3aGF0IGlzIG1lYW50IGJ5ICJ0aGF0IiBqdXN0IHRv IGJlIG9uIHRoZSBzYW1lIHBhZ2UuDQoNClRoZSBpZGVhIHRvIHVzZSBhIGhvdHBsdWcgY2Fs bGJhY2sgc2VlbXMgdG8gYmUgcmF0aGVyIHJpc2t5IElNSE8uIEF0IGxlYXN0DQpDUFVIUF9B UF9PTkxJTkVfRFlOIHNlZW1zIHRvIGJlIHdheSB0b28gbGF0ZSwgYXMgdGhlcmUgYXJlIHNl dmVyYWwgZGV2aWNlDQpkcml2ZXJzIGhvb2tpbmcgaW4gd2l0aCB0aGUgc2FtZSBvciBsb3dl ciBwcmlvcml0eSBhbHJlYWR5LiBBbmQgZGV2aWNlDQpkcml2ZXJzIG1pZ2h0IHJlbHkgb24g UEFUIHNldHRpbmdzIGluIFBURXMgb2YgTVRSUiBiZWluZyBzZXR1cCBjb3JyZWN0bHkuDQoN CkFub3RoZXIgcHJvYmxlbWF0aWMgY2FzZSBpcyBDUFVIUF9BUF9NSUNST0NPREVfTE9BREVS LCB3aGljaCBpcyBleHBsaWNpdGx5DQpkb2luZyBjYWNoZSB3cml0ZWJhY2sgYW5kIGludmFs aWRhdGlvbiwgd2hpY2ggc2VlbXMgdG8gYmUgcmlza3kgd2l0aG91dA0KaGF2aW5nIGEgc2Fu ZSBQQVQvTVRSUiBzdGF0ZSBvZiB0aGUgcHJvY2Vzc29yLiBJdCBzaG91bGQgYmUgbm90ZWQg dGhhdCB0aGUNCm1pY3JvY29kZSBsb2FkZXIgaXMgcmVnaXN0ZXJlZCB2aWEgbGF0ZV9pbml0 Y2FsbCgpLCBzbyBib290IGlzbid0IGFmZmVjdGVkDQpieSB0aGUgZGVsYXllZCBNVFJSL1BB VCBpbml0IHdoZW4gYm9vdGluZy4NCg0KU28gdGhlIG9ubHkgc2VjdXJlIHdheSB0byB1c2Ug YSBob3RwbHVnIGNhbGxiYWNrIHdvdWxkIGJlIHRvIGhhdmUgYSByYXRoZXINCmVhcmx5IHBy ZXJlZ2lzdGVyZWQgc2xvdCBpbiBlbnVtIGNwdWhwX3N0YXRlLg0KDQpSZWdhcmRpbmcgcmVz dW1lIGFuZCBrZXhlYyBJJ20gbm8gbG9uZ2VyIHN1cmUgZG9pbmcgdGhlIGRlbGF5ZWQgTVRS Ui9QQVQNCmluaXQgaXMgc3VjaCBhIGdyZWF0IGlkZWEuIEl0IG1pZ2h0IHNhdmUgc29tZSBt aWxsaXNlY29uZHMsIGJ1dCB0aGUgcmlza3MNCm1lbnRpb25lZCBhYm92ZSB3aXRoIGUuZy4g bWljcm9jb2RlIGxvYWRpbmcgc2hvdWxkIGFwcGx5Lg0KDQpTbyByaWdodCBub3cgSSdtIGlu Y2xpbmVkIHRvIGJlIGJldHRlciBvbiB0aGUgc2FmZSBzaWRlIGJ5IG5vdCBhZGRpbmcgYW55 DQpjcHUgaG90cGx1ZyBob29rLCBidXQgdG8gdXNlIGp1c3QgdGhlIHNhbWUgImRlbGF5ZWQg QVAgaW5pdCIgZmxhZyBhcyB0b2RheSwNCmp1c3QgcmVuYW1pbmcgaXQuIFRoaXMgd291bGQg bGVhdmUgdGhlIGRlbGF5ZWQgTVRSUi9QQVQgaW5pdCBpbiBwbGFjZSBmb3INCnJlc3VtZSBh bmQga2V4ZWMgY2FzZXMsIGJ1dCBkZWZlcnJpbmcgdGhlIE1UUlIvUEFUIGNsZWFudXAgZHVl IHRvIHRoaXMNCnBvdGVudGlhbCBpc3N1ZSBzZWVtcyBub3QgYXBwcm9wcmlhdGUsIGFzIHRo ZSBjbGVhbnVwIGlzbid0IGNoYW5naW5nIHRoZQ0KYmVoYXZpb3IgaGVyZS4NCg0KV2Ugc2hv dWxkLCBob3dldmVyLCBoYXZlIGEgZGlzY3Vzc2lvbiBpbiBwYXJhbGxlbCBvciBsYXRlciwg d2hldGhlciB0aGUNCndob2xlIHRoYXdfc2Vjb25kYXJ5X2NwdXMoKSBoYW5kbGluZyBpcyBy ZWFsbHkgb2theSBvciB3aGV0aGVyIGl0IHNob3VsZA0KYmUgY2hhbmdlZCBpbiBzb21lIHdh eS4NCg0KDQpKdWVyZ2VuDQo= --------------Pvv00nTI34oY5YpXg9t0w1ip Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Pvv00nTI34oY5YpXg9t0w1ip-- --------------5WxHoVEGcQnJX10ESZlcFax9-- --------------LWnRAw3GXgBlglJ5NNsTIBeg Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM1VtMFAwAAAAAACgkQsN6d1ii/Ey9S Gwf+M4ca1gLNxUnvM+fmZIU2oIjgjBJ8/gX6wP3u15uRs3/Nmn/gcSfxWAP44hsxI7niAs7Xi9S6 QLjCNnpYIczLk/6OTycvn4Zt/FiCZhka2Iqwok/9EDtBH6w99vkPribqkKjSB/Ys/LGpxjrg+kML 7NEu9DLFAhrjO28FHRfzdNmu8MOIw6KFUHBQqWsCi0xrs1BDXkAcdaQ07zz8fBC2XjXAQyyx72me C7N8xDlim/lWs40PkvwR0DQ6st6FH+CDVPAICM5Ik7CVDL1KJMJxpKiweRzc3QQ6SbC/bAimt554 J7g6rxmfyuMoBEmyyFsqsEDTCMzsDxcfejMpk67FYw== =NUqX -----END PGP SIGNATURE----- --------------LWnRAw3GXgBlglJ5NNsTIBeg-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 08:36:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 08:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413536.657235 (Exim 4.92) (envelope-from ) id 1odp2G-0003ev-AA; Thu, 29 Sep 2022 08:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413536.657235; Thu, 29 Sep 2022 08:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odp2G-0003eo-7S; Thu, 29 Sep 2022 08:36:48 +0000 Received: by outflank-mailman (input) for mailman id 413536; Thu, 29 Sep 2022 08:36:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odp2F-0003ee-06; Thu, 29 Sep 2022 08:36:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odp2E-000350-Rz; Thu, 29 Sep 2022 08:36:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odp2E-00028h-2c; Thu, 29 Sep 2022 08:36:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odp2E-0004CO-27; Thu, 29 Sep 2022 08:36:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3XoRzWI6QWZMVNXfkWskArev82dTeFJOi/mFFVZrHpM=; b=Uws6uddeMKf2vKXP9016+DW/Gv w/mxct7rPatG1FLtBDESImEU8epe9tmuJPAMaCu2ubUyHVQqOFv9mf0rZtMt+y9V6adWj06cr2o8u GOHVbdsRrA5P+6ujk6HF4OuEp6WdUcBiE+DJysggkGCB8I0VkX0go9qmnKo6XTqQwNXY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173361: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Thu, 29 Sep 2022 08:36:46 +0000 flight 173361 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173361/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 173358 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173358 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173358 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173358 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173358 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173358 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173358 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173358 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173358 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173358 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173358 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173358 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173358 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173358 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173361 2022-09-29 01:54:40 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Sep 29 09:12:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 09:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413545.657245 (Exim 4.92) (envelope-from ) id 1odpay-00085f-6B; Thu, 29 Sep 2022 09:12:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413545.657245; Thu, 29 Sep 2022 09:12:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odpay-00085Y-3H; Thu, 29 Sep 2022 09:12:40 +0000 Received: by outflank-mailman (input) for mailman id 413545; Thu, 29 Sep 2022 09:12:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odpaw-00085S-JK for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:12:38 +0000 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db5256aa-3fd6-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 11:12:36 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1d-9a235a16.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 09:12:24 +0000 Received: from EX13MTAUWC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-9a235a16.us-east-1.amazon.com (Postfix) with ESMTPS id 446D78015E; Thu, 29 Sep 2022 09:12:18 +0000 (UTC) Received: from EX19D020UWC004.ant.amazon.com (10.13.138.149) by EX13MTAUWC002.ant.amazon.com (10.43.162.240) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 29 Sep 2022 09:12:17 +0000 Received: from [10.95.64.54] (10.43.160.111) by EX19D020UWC004.ant.amazon.com (10.13.138.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.12; Thu, 29 Sep 2022 09:12:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: db5256aa-3fd6-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1664442756; x=1695978756; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gbX7+1PHfMiTfg5A2mAeVk2kLj1W8TIaBDtUydjsZQ8=; b=ibOuRpg6Flpv48+oo2eSQ5uktFuiUEoR6FMIsF4L82jw0rcEjfmT8R0l G0A+wl5cCtSHzKbTCZqLsakeX6SBHECGroa1xDbljd0nETDLt7382e08n 23TB2ebI0GnuvdT/giz8ePqkzy3oTlwIURfcQjonNY28s1yJVG/dkX2/D w=; Message-ID: <1f1beb97-2a36-dcc0-f09a-59af19663ae2@amazon.com> Date: Thu, 29 Sep 2022 10:12:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor Content-Language: en-US To: Ajay Kaher , Vitaly Kuznetsov CC: "x86@kernel.org" , "hpa@zytor.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , Srivatsa Bhat , "srivatsa@csail.mit.edu" , Alexey Makhalov , Vasavi Sirnapalli , "er.ajay.kaher@gmail.com" , "willy@infradead.org" , "Nadav Amit" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "jailhouse-dev@googlegroups.com" , "xen-devel@lists.xenproject.org" , "acrn-dev@lists.projectacrn.org" , "helgaas@kernel.org" , "bhelgaas@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "Michael S. Tsirkin" References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> <87zgf3pfd1.fsf@redhat.com> From: Alexander Graf In-Reply-To: X-Originating-IP: [10.43.160.111] X-ClientProxiedBy: EX13D23UWA004.ant.amazon.com (10.43.160.72) To EX19D020UWC004.ant.amazon.com (10.13.138.149) Precedence: Bulk Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Ck9uIDI5LjA5LjIyIDA3OjM2LCBBamF5IEthaGVyIHdyb3RlOgo+PiDvu79PbiAxMy8wOS8yMiwg NzowNSBQTSwgIlZpdGFseSBLdXpuZXRzb3YiIDx2a3V6bmV0c0ByZWRoYXQuY29tPiB3cm90ZToK Pj4+IFRoYW5rcyBWaXRhbHkgZm9yIHlvdXIgcmVzcG9uc2UuCj4+Pgo+Pj4gMS4gd2UgaGF2ZSBt dWx0aXBsZSBvYmplY3RzIG9mIHN0cnVjdCBwY2lfcmF3X29wcywgMi4gYWRkaW5nICdwcmlvcml0 eScgZmllbGQgdG8gc3RydWN0IHBjaV9yYXdfb3BzCj4+PiBkb2Vzbid0IHNlZW1zIHRvIGJlIGFw cHJvcHJpYXRlIGFzIG5lZWQgdG8gdGFrZSBkZWNpc2lvbiB3aGljaCBvYmplY3Qgb2Ygc3RydWN0 IHBjaV9yYXdfb3BzIGhhcwo+Pj4gdG8gYmUgdXNlZCwgbm90IHNvbWV0aGluZyB3aXRoLWluIHN0 cnVjdCBwY2lfcmF3X29wcy4KPj4gSSdtIG5vdCBzdXJlIEkgZm9sbG93LCB5b3UgaGF2ZSB0d28g aW5zdGFuY2VzIG9mICdzdHJ1Y3QgcGNpX3Jhd19vcHMnCj4+IHdoaWNoIGFyZSBjYWxsZWQgJ3Jh d19wY2lfb3BzJyBhbmQgJ3Jhd19wY2lfZXh0X29wcycuIFdoYXQgaWYgeW91IGRvCj4+IHNvbWV0 aGluZyBsaWtlIChjb21wbGV0ZWx5IHVudGVzdGVkKToKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3BjaV94ODYuaCBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BjaV94ODYu aAo+PiBpbmRleCA3MDUzM2ZkY2JmMDIuLmZiODI3MGZhNmM3OCAxMDA2NDQKPj4gLS0tIGEvYXJj aC94ODYvaW5jbHVkZS9hc20vcGNpX3g4Ni5oCj4+ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNt L3BjaV94ODYuaAo+PiBAQCAtMTE2LDYgKzExNiw3IEBAIGV4dGVybiB2b2lkICgqcGNpYmlvc19k aXNhYmxlX2lycSkoc3RydWN0IHBjaV9kZXYgKmRldik7Cj4+IGV4dGVybiBib29sIG1wX3Nob3Vs ZF9rZWVwX2lycShzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+Pgo+PiBzdHJ1Y3QgcGNpX3Jhd19vcHMg ewo+PiArICAgICAgIGludCByYXRpbmc7Cj4+ICAgICAgICAgICBpbnQgKCpyZWFkKSh1bnNpZ25l ZCBpbnQgZG9tYWluLCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNpZ25lZCBpbnQgZGV2Zm4sCj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZWcsIGlu dCBsZW4sIHUzMiAqdmFsKTsKPj4gICAgICAgICAgIGludCAoKndyaXRlKSh1bnNpZ25lZCBpbnQg ZG9tYWluLCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNpZ25lZCBpbnQgZGV2Zm4sCj4+IGRpZmYgLS1n aXQgYS9hcmNoL3g4Ni9wY2kvY29tbW9uLmMgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMKPj4gaW5k ZXggZGRiNzk4NjAzMjAxLi5lOTk2NWZkMTE1NzYgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gveDg2L3Bj aS9jb21tb24uYwo+PiArKysgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMKPj4gQEAgLTQwLDcgKzQw LDggQEAgY29uc3Qgc3RydWN0IHBjaV9yYXdfb3BzICpfX3JlYWRfbW9zdGx5IHJhd19wY2lfZXh0 X29wczsKPj4gICBpbnQgcmF3X3BjaV9yZWFkKHVuc2lnbmVkIGludCBkb21haW4sIHVuc2lnbmVk IGludCBidXMsIHVuc2lnbmVkIGludCBkZXZmbiwKPj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZWcsIGludCBsZW4sIHUzMiAqdmFsKQo+PiB7 Cj4+IC0gICAgICAgaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNpX29wcykK Pj4gKyAgICAgICBpZiAoZG9tYWluID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzICYm Cj4+ICsgICAgICAgICAgICghcmF3X3BjaV9leHRfb3BzIHx8IHJhd19wY2lfZXh0X29wcy0+cmF0 aW5nIDw9IHJhd19wY2lfb3BzLT5yYXRpbmcpKQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiBy YXdfcGNpX29wcy0+cmVhZChkb21haW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVuLCB2YWwpOwo+PiAg ICAgICAgICBpZiAocmF3X3BjaV9leHRfb3BzKQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiBy YXdfcGNpX2V4dF9vcHMtPnJlYWQoZG9tYWluLCBidXMsIGRldmZuLCByZWcsIGxlbiwgdmFsKTsK Pj4gQEAgLTUwLDcgKzUxLDggQEAgaW50IHJhd19wY2lfcmVhZCh1bnNpZ25lZCBpbnQgZG9tYWlu LCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNpZ25lZCBpbnQgZGV2Zm4sCj4+ICAgaW50IHJhd19wY2lf d3JpdGUodW5zaWduZWQgaW50IGRvbWFpbiwgdW5zaWduZWQgaW50IGJ1cywgdW5zaWduZWQgaW50 IGRldmZuLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW50IHJlZywgaW50IGxlbiwgdTMyIHZhbCkKPj4gewo+PiAtICAgICAgIGlmIChkb21haW4g PT0gMCAmJiByZWcgPCAyNTYgJiYgcmF3X3BjaV9vcHMpCj4+ICsgICAgICAgaWYgKGRvbWFpbiA9 PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNpX29wcyAmJgo+PiArICAgICAgICAgICAoIXJhd19w Y2lfZXh0X29wcyB8fCByYXdfcGNpX2V4dF9vcHMtPnJhdGluZyA8PSByYXdfcGNpX29wcy0+cmF0 aW5nKSkKPj4gICAgICAgICAgICAgICAgICByZXR1cm4gcmF3X3BjaV9vcHMtPndyaXRlKGRvbWFp biwgYnVzLCBkZXZmbiwgcmVnLCBsZW4sIHZhbCk7Cj4+ICAgICAgICAgICBpZiAocmF3X3BjaV9l eHRfb3BzKQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiByYXdfcGNpX2V4dF9vcHMtPndyaXRl KGRvbWFpbiwgYnVzLCBkZXZmbiwgcmVnLCBsZW4sIHZhbCk7Cj4+Cj4+IGFuZCB0aGVuIHNvbWV3 aGVyZSBpbiBWbXdhcmUgaHlwZXJ2aXNvciBpbml0aWFsaXphdGlvbiBjb2RlCj4+IChhcmNoL3g4 Ni9rZXJuZWwvY3B1L3Ztd2FyZS5jKSB5b3UgZG8KPj4KPj4gICByYXdfcGNpX2V4dF9vcHMtPnJh dGluZyA9IDEwMDsKPiBUaGFua3MgVml0YWx5LCBmb3IgeW91ciByZXZpZXcgYW5kIGhlbHBpbmcg dXMgdG8gaW1wcm92ZSB0aGUgY29kZS4KPgo+IEkgd2FzIHdvcmtpbmcgdG8gbWFrZSBjaGFuZ2Vz IGFzIHlvdSBzdWdnZXN0ZWQsIGJ1dCBiZWZvcmUgc2VuZGluZyB2MyB3b3VsZCBsaWtlIHRvCj4g ZGlzY3VzcyBvbiBmb2xsb3dpbmc6Cj4KPiBJZiB3ZSBhZGQgcmF0aW5nIHdpdGgtaW4gc3RydWN0 IHBjaV9yYXdfb3BzIHRoZW4gd2UgY2FuJ3QgaGF2ZSBwY2lfbW1jZmcgYXMgY29uc3QsCj4gYW5k IGZvbGxvd2luZyBjaGFuZ2UgaXMgbXVzdCBpbiBhcmNoL3g4Ni9wY2kvbW1jb25maWdfNjQuYzoK Pgo+IC1jb25zdCBzdHJ1Y3QgcGNpX3Jhd19vcHMgcGNpX21tY2ZnID0gewo+ICtzdHJ1Y3QgcGNp X3Jhd19vcHMgcGNpX21tY2ZnID0gewo+ICAgICAgICAgIC5yZWFkID0gICAgICAgICBwY2lfbW1j ZmdfcmVhZCwKPiAgICAgICAgICAud3JpdGUgPSAgICAgICAgcGNpX21tY2ZnX3dyaXRlLAo+IH07 Cj4KPiBTbyB0byBhdm9pZCB0aGlzIGNoYW5nZSwgaXMgaXQgZmluZSB0byBoYXZlIGdsb2JhbCBi b29sIHByZWZlcl9yYXdfcGNpX2V4dF9vcHM/Cj4KPiBBbmQgcmF3X3BjaV9yZWFkKCkgd2lsbCBo YXZlIGZvbGxvd2luZyBjaGFuZ2U6Cj4KPiAtICAgICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcg PCAyNTYgJiYgcmF3X3BjaV9vcHMpCj4gKyAgICAgICBpZiAoZG9tYWluID09IDAgJiYgcmVnIDwg MjU2ICYmIHJhd19wY2lfb3BzICYmCj4gKyAgICAgICAgICAgICghcHJlZmVyX3Jhd19wY2lfZXh0 X29wcyB8fCAgIXJhd19wY2lfZXh0X29wcykKPgo+PiB3aHkgd291bGRuJ3QgaXQgd29yaz8KPj4K Pj4gKGRpY2xhaW1lcjogY29tcGxldGVseSB1bnRlc3RlZCwgcmF3X3BjaV9vcHMvcmF3X3BjaV9l eHRfb3BzCj4+IGluaXRpYWxpemF0aW9uIGhhcyB0byBiZSBjaGVja2VkIHNvICdyYXRpbmcnIGlz IG5vdCBnYXJiYWdlKS4KPj4KPj4+IEl0J3MgYSBnZW5lcmljIHNvbHV0aW9uIGZvciBhbGwgaHlw ZXJ2aXNvciAoc29ycnkgZm9yIGVhcmxpZXIgd3JvbmcKPj4+IFN1YmplY3QpLCBub3Qgc3BlY2lm aWMgdG8gVk13YXJlLiBGdXJ0aGVyIGxvb2tpbmcgZm9yIGZlZWRiYWNrIGlmIGl0J3MKPj4+IGlt cGFjdGluZyB0byBhbnkgaHlwZXJ2aXNvci4KPj4gVGhhdCdzIHRoZSB0cmlja3kgcGFydC4gV2Ug Y2FuIGNoZWNrIG1vZGVybiBoeXBlcnZpc29yIHZlcnNpb25zLCBidXQKPj4gd2hhdCBhYm91dCBh bGwgb3RoZXIgdmVyc2lvbnMgaW4gZXhpc3RlbmNlPyBIb3cgY2FuIHdlIGtub3cgdGhhdCB0aGVy ZSdzCj4+IG5vIFFFTVUvSHlwZXItVi8uLi4gdmVyc2lvbiBvdXQgdGhlcmUgd2hlcmUgTU1JTyBw YXRoIGlzIGJyb2tlbj8gSSdkCj4+IHN1Z2dlc3Qgd2UgbGltaXQgdGhlIGNoYW5nZSB0byBWbXdh cmUgaHlwZXJ2aXNvciwgb3RoZXIgaHlwZXJ2aXNvcnMgbWF5Cj4+IHVzZSB0aGUgc2FtZSBtZWNo YW5pc20gKGxpa2UgdGhlIG9uZSBhYm92ZSkgbGF0ZXIgKGJ1dCB0aGUgcGVyc29uCj4+IHN1Z2dl c3RpbmcgdGhlIHBhdGNoIGlzIGFsd2F5cyByZXNwb25zaWJsZSBmb3IgdGhlIHJlc2VhcmNoIHdo eSBpdCBpcwo+PiBzYWZlIHRvIGRvIHNvKS4KPiBPaywgYXMgb2Ygbm93IHdlIHdpbGwgbWFrZSB0 aGlzIGNoYW5nZSBzcGVjaWZpYyB0byBWTXdhcmUgaHlwZXJ2aXNvci4KCgpJcyB0aGVyZSBhIHdh eSB3ZSBjYW4gbWFrZSBpdCBhbiBBQ1BJIHByb3BlcnR5IGluIE1DRkcgdG8gaGF2ZSB0aGUgCmVu dmlyb25tZW50IHNlbGYtZGVzY3JpYmUgdGhlIGZhY3QgdGhhdCBpdCdzIHNhZmUgdG8gZG8gRUNB TSBhY2Nlc3MgZm9yIApjb25maWcgc3BhY2UgYWNjZXNzIG92ZXIgbGVnYWN5IFBJTz8gVGhhdCB3 YXkgd2UgZG9uJ3QgbmVlZCB0byBwYXRjaCAKZ3Vlc3RzIGV2ZXJ5IHRpbWUgYSBoeXBlcnZpc29y IGRlY2lkZXMgdGhhdCBpdCdzIHNhZmUgdG8gcHJlZmVyIEVDQU0uCgpBbHNvLCBNaWNoYWVsIChD QydlZCkgbWVudGlvbmVkIHRoYXQgYWNjb3JkaW5nIHRvIHNwZWMsIHlvdXIgUENJZSBob3N0IApi cmlkZ2Ugd2l0aCBQQ0lfQ09NTUFORC5NRU1PUlk9MCB3b3VsZCBzdG9wIHJlc3BvbmRpbmcgdG8g aXRzIEVDQU0gCndpbmRvdy4gR2l2ZW4gdGhhdCBtb3N0IEFSTSBzeXN0ZW1zIGhhdmUgbm8gUElP IGZhbGxiYWNrIHBhdGgsIHdlIHdhbnQgCnRvIG1ha2Ugc3VyZSB3ZSBuZXZlciBoaXQgdGhhdCBj b25kaXRpb24uCgoKQWxleAoKCgoKCkFtYXpvbiBEZXZlbG9wbWVudCBDZW50ZXIgR2VybWFueSBH bWJICktyYXVzZW5zdHIuIDM4CjEwMTE3IEJlcmxpbgpHZXNjaGFlZnRzZnVlaHJ1bmc6IENocmlz dGlhbiBTY2hsYWVnZXIsIEpvbmF0aGFuIFdlaXNzCkVpbmdldHJhZ2VuIGFtIEFtdHNnZXJpY2h0 IENoYXJsb3R0ZW5idXJnIHVudGVyIEhSQiAxNDkxNzMgQgpTaXR6OiBCZXJsaW4KVXN0LUlEOiBE RSAyODkgMjM3IDg3OQoKCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 29 09:48:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 09:48:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413551.657257 (Exim 4.92) (envelope-from ) id 1odq9u-0003GC-1Z; Thu, 29 Sep 2022 09:48:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413551.657257; Thu, 29 Sep 2022 09:48:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odq9t-0003G5-V0; Thu, 29 Sep 2022 09:48:45 +0000 Received: by outflank-mailman (input) for mailman id 413551; Thu, 29 Sep 2022 09:48:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odq9s-0003Fz-GB for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:48:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e72c624e-3fdb-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 11:48:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8240.eurprd04.prod.outlook.com (2603:10a6:102:1c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 09:48:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 09:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e72c624e-3fdb-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2NpZdMKi7fELSrxUYCmv3tXbUgUv0eaPjFn/D9Pihgaj/E0BhhaeJGolvCPlUQeqG367u3/mVaUvEFBI9/n1Lf/+jEiZ/Agdu0QNRu3I/OzN4IP5Hv/fx1+eh1FtFv+8p05+zNMxad7MzNpWx8dy5vj51iIzlSO8b4R2QqnhdkXYbacRQvmpr+zNCp5xozhcd/fPMO06eFpN03/uNcr8UM+DMCjjh4fZ6iE3vwV6W2KyXR3Eq2H1B6KpfLz7h4bSfwq0oiB1owTbS+wuOkxB99RxeIWWSpHZpvbSMLEzLWcblfgotCTQEZh4phhkTbHkPd8uJpbgiEMmXDbv3k51w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I1iPI0MR0Z3azuwjQj1UrPXlWcIts8BeWUYOsh1VkTU=; b=NWl39QZvKEvWR7P9M+mJ9Jea2dkATQjV/OXyEYRzoRCPQIMCsaelyMTgz4VgEOF8ovYkfErlbdAMNGqGF583lLTeSKVJrCt7rcxOt/Ox6Z11ZKrW7ubG+gRRCcMVmlj+5kxxi9BfFMcEsIkD+IUQWnlvlutN45tHQoMUnrRTNDoYtDW1T2rVfe9VfKZF9xU0+1bQ8djfgfC790fX8EgBv1QPOBCGgYT2Ah0FmWG6HLsP02f+SPWXmSuVKcsM2cHgSaaFpMiMmaK2QvpjlMajFqCm1pkZMnJTBUABlbw45cX3pkLikv6Snyb9dDy1VptTrRC0ZZ8EZDdyTAOrPv1eBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1iPI0MR0Z3azuwjQj1UrPXlWcIts8BeWUYOsh1VkTU=; b=cz+ScxaTMtPaIGFN5KAteAgx3hDpdRf1vbKGr9JbMTXSMPbBoYBajDaBeU5MdxHJJAfkYQ6N23JsnBAvg0jrvzfVJX2lFNxqRx3CBanOkwpzLKW6YlkTIPIbUjMC/ZN3Xwapz5ppGXtoyy1GxLVn/QthFDnrH+SqQdSVD4lnBI66iq8eiR0v9KKOFVWu1in5BZ25TgcNC0Q1eShZGt6Jt9ba80MrrJoB6jXo7HreV13wFWhW0Gyy07cHBExvxhhcnJ8ZSCPSkhhhBlC+7u6oSyeEKvjlaHep+AYhrxC0xc2KGt4UO2nK+Z9/gbf626IomnBZ8ZY4L6ffFVd2aua92g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> Date: Thu, 29 Sep 2022 11:48:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/2][4.17] x86: (re-)wire two VCPUOP_* for 32-bit guests Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8240:EE_ X-MS-Office365-Filtering-Correlation-Id: 7de71ad7-d168-4006-1369-08daa1ffc986 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lWSe1tm4maFZQWKNZrnsOjEY8fYbSy/hkRJvcFZE+0PXLyVT4sEE5SrIVob29SCBvoLZtYggBFHyNfU7ie5YjY1bEVbYIUO5uienbTVepDH6DIBzh6Uq449rLQ2IreSk0E60KlaJBY4gqxfn9NJWgivcw61GmcyAU7X7ADmGK2f9EZOHaAJx3i91oVQ4HnTyZX31V2luRX8Nx30yo3koG481b3PhvODVclG2djHHcZR2pCUQdHDm6V6Un3lm1+wVZGhxQ8JADGuPK3mGu4QNJQqPPqH84ss/JPTWrjZy4wnHfhAf7IR7XtR2diANUmhW8eN//nsXHRZScr6SVNxFAIStk3npQBiFgyPjRCyabFWxIlnREbVqdYFGRk1AXfL26SpRyloqIiUK5OIBIWbXnTnKQ6sP4kkWNvj/S6RF6CNZ2g36JthHh575TR+UeTfYRHZ7NsWEVBdtE26J/Jt7BtSKeST+yuIhK9s1QZoorVcNIiuLkK6tKMiv9kEv0PRydziL+zwR3v66gkbpHSZ8vrQSWs6cTicTICsGo3Mmcd605gumToe6uvDavAHADgdzIdrrPlid6xdhe8saNiYQMA3oe0Po6kNFt9EBN2jZJwaCG9GkYk1v9o0upRO+zJQCM1wo5l918RMj1paWUvDaEsRmky20YrX147dkDL7E07YlBReUdDjZlO/mdQ0YMMpiieFK0sPlsjnvPyN+P0WcyQBApmse4ws75JEoAEhyC+udkgqSZ66U4bnu5g6+EegggLKVbpEZnpUgq3w7gh27/aFfhqpu71+JxtZ30XXpwqo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(6916009)(54906003)(316002)(5660300002)(36756003)(8936002)(66946007)(66556008)(66476007)(558084003)(2906002)(41300700001)(8676002)(4326008)(26005)(6512007)(2616005)(186003)(478600001)(86362001)(6506007)(6486002)(38100700002)(83380400001)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3R1U3JGaUkvcXhYTEhRNHNFS2E2eTc3V3pvZWVOUmVQTEFtQVdmVzdPNkRR?= =?utf-8?B?QStoY3I2MkJ6dzNBNDRYcUxmcmhxeHVMTXpSWkpCK2tDMDNVcmRNeXBQM3JB?= =?utf-8?B?YU5xRkZDUHY1aHE0UUo4eGc3WlJkMWlvV0d4SU5zbVVHTzR6WkZKdGR5VXg2?= =?utf-8?B?NnAzMVpaTUpEdlZKamtQM1RKVlR5T3A5OVorQWxURlJjczRielBhZ1Bqc3BG?= =?utf-8?B?MVk1MHVTdTJCRUQwSmpnS05OOHZVRi9aRnFYaitGOUQ0eWhmTFFtRWNTaDlC?= =?utf-8?B?V0VYUG9VMzhDZERwdjVNNWc2YkpMMlU0YVhsdDN0UmtPS0s3S0NaTjdPblNZ?= =?utf-8?B?QmlRRVpkVDlJWGswR3hVeGU1dVN1Y05nYU1YanZsR1N0NWRhWi9nZzAwUHpN?= =?utf-8?B?WjBLU3AxMkl4U3FkVDA0UE1rQXRVYUJ5VWN6SzJBZ3M2RGsxSzFjcjBwVERm?= =?utf-8?B?U2YyZlZvSnk5ZTE0Z0t5aGk1ajZBVkdBWWVjblFMM0tYTytnVzUrcTI2Mkh2?= =?utf-8?B?ZEdXaGdPckFzcFRpNUovN1BTWmxDODlxTFZQNkhHWEorK09hYWExVUExVElt?= =?utf-8?B?R3R6MVFmWjV5b3VmWVBaN0xjS1Q0aGpTQjhxM3FRVnBYNkhVanRFVFN3VFRs?= =?utf-8?B?b25HeDZIZno3RGZ5VzJJUVpIR2N0Ykdia1R6V3kyOGZrMjJCcXh0ZFQ2TjA1?= =?utf-8?B?SzFjeVZob1RpMmx2UzhxVTY2ZERWd1pjSnRxYnZLNUQveTJad0F6dWI2cmk4?= =?utf-8?B?VlI5Qzh3OTdwL3ZPZkNCRVNmcmwremxJdzArSm9iVER5a3lKcU9Gc1VzMkQ2?= =?utf-8?B?WHFxdTVpMzV0bExvRG1zL21BN1h3ZmRUKzNBdDlsdFpWRnpoajVyWHRmK3M5?= =?utf-8?B?ajloWW90Zm9CNnVjTHlCY203MDVLWkQ0d3QzbXVORityL3FKMlFRUUxtcFhH?= =?utf-8?B?bkt2b0JHZnhqTUd4VUJjZEFQeUhXL2g2b0NsajdkN0RiREdNL011WUd2Q1Y1?= =?utf-8?B?WUtCYTRoZEpjdnNtNXhWVXRoK3h5c29Zbys2VW5rc29DMXBObnNFekpRNEhn?= =?utf-8?B?U3RTdXRUSGNhNmxkV3dSN1V1WHQ2bVQwZ0dnWC91bjNiVk9FYXpPQjZqQkVL?= =?utf-8?B?R0kxUTlGUFhTSzFNRUMvUTR4Ym5HOW1TTXV4akN6b1UzSDZTUURaK0E4ZEox?= =?utf-8?B?MTIrbUpTalluclZIL1EzUUNwSFpKcUJ6a3N2ei9mZGo1alRKL3RlRk9uNU9S?= =?utf-8?B?YllPK0MxWHRhVDRBL21jK3hiYnNCUHgxTVZGSC9QYVEvdDJTeS9TSTJIb2U0?= =?utf-8?B?dGRiWU5CRWVpWWxCWGxvaStBaGt5YWtFOCs1RmplTHJ3MzR3MmFDL1Z6YXR2?= =?utf-8?B?VjJxTXlNSnlZdGo5QWsyOTNSbHhoZUVvOGFRODIrYnl5ZXoyMVBkcmErdTlQ?= =?utf-8?B?M20rS2M1NGhFR2dWTG1samhEQ1JxdC9BYU5kVk9vdTcxaE9hZzU5eXBqS09V?= =?utf-8?B?eTFPT3AveC91eXlYK3lHWXkzbktDZDRvTU84dkhoaDkrd201ckRNcU1MNkNx?= =?utf-8?B?ODhIc0ZrS3FMS1M0ZENReTh0dE9ENDNEZzBkTnlhK1B6L2VvenF1amU1d2Nl?= =?utf-8?B?REVDN0RBd0I3bDFrWG9YdGFIVXRmVWtFSXZFR3VCMHpCeTgrbWVOQU1kSnpB?= =?utf-8?B?aXBCV05jVlZLdW5KcGpaRzFxcmppTjh3RDE5NzEvVnJnNUY2dTVuRmc5ZzF6?= =?utf-8?B?OEllQWF2dS9xWW9PS0dRZzFGWkJvTkNBNWpGbUlZVHZ5azU4M3pTbGRKZDJ5?= =?utf-8?B?SWZlZGFwbXIyZHREK3RSUW9GaHNxSVZUM2FRSzE5ZHhYV0JvYm11T1N2M1Jm?= =?utf-8?B?NmVHQWVpTUNCNW02NldHR1ZMYThtSTNndm1KcWtSeVBrZXhtR3hQOTRZMVM3?= =?utf-8?B?MHVJTWozT25WUGNzSytnTDZRMCtqaVlKRUl0QVFBejc2SDRpS2pJcFlwMGYw?= =?utf-8?B?V3l2aVlCQVRxc2M4a3QrbUdOZ3BOa2JxNDBPb0x4aU9NZkEzTHNuYnFwMXFs?= =?utf-8?B?M0F0OC9TNTN5dlpLSXNOS1gyNlFPeVlMWS93TVlkU2wyTEFVMkV2c0lZVHh6?= =?utf-8?Q?mhdLVbHnrX7ldY5NE3UVUklVq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7de71ad7-d168-4006-1369-08daa1ffc986 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 09:48:40.1867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UbFUu33HXQkk33Ee1VKzPkUPv+C4NlvCe+/j5lg2S02YDp+H2tgObjQPWWA4/j4EIUJ1PrFpNxKZrxXo01ak8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8240 1: re-connect VCPUOP_send_nmi for 32-bit guests 2: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests As to 4.17: Patch 1 addresses a recently introduced regression, while the issue patch 2 addresses has been there effectively forever (so cannot really be viewed as a regression). Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 09:51:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 09:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413556.657268 (Exim 4.92) (envelope-from ) id 1odqCE-0004cM-EN; Thu, 29 Sep 2022 09:51:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413556.657268; Thu, 29 Sep 2022 09:51:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCE-0004cF-BW; Thu, 29 Sep 2022 09:51:10 +0000 Received: by outflank-mailman (input) for mailman id 413556; Thu, 29 Sep 2022 09:51:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCC-0004c7-Iu for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:51:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d252d72-3fdc-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 11:51:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7209.eurprd04.prod.outlook.com (2603:10a6:102:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 09:51:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 09:51:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d252d72-3fdc-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWq67xcV4i9QBj90mg9Nu2eBsPYNCBSPVq0FKG55chfUeTGAa+u/RpOwbWasoMB/Ttp1cWti8rtPlfvMOh9xAJubTtO9gJlJCAsZqQK3O0Jq7qOGvUqqCSXPdGVEOkgpwm4zCcBtw+o2Y1EDxNWV77u9eHVe+bpoCnQT2nbTRrhQyYvB+Lcc5y+I3rX9NjUJVzYYuqIi3gOG4aQuWSO/bX+04F+ubPue/2Xp8nUf1ZzIwTNtSDLPBlStWa3JsXPWhFRVH8Uv3BHMyOswIsTau0Q8NEjBXBBngI1qPR1FT6xL0HIunNpkWTBFWc+uJLBt515WoU7mN+N+PEfm1CzFnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+86ZEmgrwt0Ukv/jXJFhwGTpqrhzbbbTEia7yvF+u/0=; b=YhveM2T/ZRzuDMCZCZbWpNNhZLX7uw9oJPq0CrZMNtF56VIYaTa9hX+UheXZ8KBL5v8YXpt7u1aX/IFNtsCFWeSqP4gimN/XYbq0NOCc7EPPpwJHtwHTsKVbUCZfoFcAFdY11vh3/Rhrter5H0XYm7CIP7iKvuA3iHMafvqctAwr87FBXTtXk5TsfYr0givDCG90XQ+fHKuSUk6D8UWf3wYxCU/Tw5zv0TFryiafCKDZ6T7rUlTbVunAPrLaRjGmThtJfllngl/D0zzZvSu10pblqXcL5tERonUZGy7FmaSgNGtNn8f1/JA7aHtTYgy6melIuRXhnnctylrgrV8+mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+86ZEmgrwt0Ukv/jXJFhwGTpqrhzbbbTEia7yvF+u/0=; b=fnWa6xGQpL8utn7klNM+OykDOBexy1+lgbZHntTziy3B+rUp/nnsx2gj2TEsKph5mCmhmctwcqzR3NLxWwabPMrgT2TxjUsqWlefRst1S3fzj5Ti7fErGmCbrlFw68vkYkG7ZC6qm6epaQE8hGwR4CYttdd8UMTR9w/Knn6/OsozorTwJC9vgd7WnmV539BrvAWaDfEcnT0kt+q/BofWKWdqD4LoPnpzVUVyv9fCZ2wUonVZvEV5+YW1jVFowlANzxeSzraAOAmyfLE6S+YXfcuLg7ewEmX4WQMq19ur7ltuRMOhYeH4Yb/JEchJ9Ow5DvADeT8VCjPaNZc5NjRjmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> Date: Thu, 29 Sep 2022 11:51:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> In-Reply-To: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0244.eurprd06.prod.outlook.com (2603:10a6:20b:45f::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b0ada32-8c7a-44b0-ce0c-08daa200205a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Btkv9oXTgbuermqLg0rDUEHeAmDQTpPm7F6xHZ0gPk+QqZkHCOjGoU4b8qiLg2mcjqcjJWq6VlH2wQ6NXqRVI6cNeYQe/BaxlVPWhKxl7eFtP4wk4Sbv7nw9Xu05T92We/Y0BKbW81aq15shKu6Q0Oqx9UvyKrfAU0qZzYGgvVh0R5jSxwZqrGgtQageERjGr41HaDj/gpksyYafitFRBKwl7jtUF7QLjAmfM5Ja304AyuvGinoT9XJOkYYq3ERW/h8Ih/lxrb3ogoVrvASweR2yqIUcngQGUG2k1iBnRphvoe/btnmxwJ+nAt/lGY6r2a96k82gNri+SOUk5d9DrwTlhvc0u/TP3RQQ7wVxTYA9CbD4r/vIL+8GqIMu9lr6I2ryhCa0lkUPJKw0vvAF+k0lxcYjqUxPgkZDuaVo1BgCSiQL7nHSiIuoGJN6UkHjaxlRGSwjLutzfpRc1YRnmHPivWht9nlkVtcGd11S15S/Rv8Hdv33/5pKY7MT2CYV4ltUr8lKhOFUYW0mhjrorv5qYURkabfLaVYyFt5JfzdedkcYBrocR4mAx+ZgxP/7QGvIRjrVYz+abzq/Pscp2gw90H+3BLn5oMgJh5aObXy5wV+YZxuwPifzB6SrdeshBaxbvmWcmIWA0yGzee/I3liY/ZYHAw4lQ5IvAi971ozJO2vMTU2EqE+hcnxRq6mI8Yf7cy+6t78JB05Hudfi6I7i8d8cfMkRX5U7pAv5h90yKg1hxNdmiBvxNQaIjBzrhT0Y3xFmufrIQjRvY9zurWlatLPUQkFkDe1odumv4j0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199015)(31686004)(6486002)(316002)(54906003)(6916009)(478600001)(31696002)(36756003)(2616005)(8936002)(66946007)(4326008)(8676002)(66556008)(66476007)(38100700002)(6506007)(186003)(2906002)(26005)(4744005)(6512007)(41300700001)(5660300002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2Q5SlJYZmRpUzRCaWpkTHdFRElTL0s0Y292dnZGclhMREpYRW55eW44dktB?= =?utf-8?B?ajl0Z3hWUEEwdnNqMUVsMElRbjR4c2IyRDloSUdiVTMxdStXOU8rRiswREVI?= =?utf-8?B?U3crc1QzNm41Yk5jQXBid0dKNFNEeXdLSnZ1MTNMNWx5bzlHMWw0VjA5aGdx?= =?utf-8?B?dXU5d2d2a3VuUjFTeFR5b0VBbnlSMUtKKzdwRlVIaDN5NnlSZEY0NmxBK2hj?= =?utf-8?B?Uk9UWDBKUVR3ODBLZnhVbDRmemh6cXgvcXlXY09jTXZUUHNpNnVxTzMzSDRP?= =?utf-8?B?ZnRZR3lQNHJrNEQxOUdsWUd3YkczaVY1WlJqNlZCMnVOL0IvRXpKWjlpbzBa?= =?utf-8?B?Z1RNdHdmRlpGN1FRK3p0SEFHYWc2Y0FEZzUrRzE5VXlIOG5MZlJYckFnMFh2?= =?utf-8?B?aktRbk9DYi9pVEIxY1Q2UnVERGRTQ0FWY2tCZm9BcG9MN1FhaGJPdCtKK3J0?= =?utf-8?B?MU41UTlRVWtGRHE1UjZQTGRkSHNDVkxLZXdrZ0xMcC9YaVBwT0VmVVdraUdy?= =?utf-8?B?L1V0VWlxcVRGeENkME1RVFpoN3pzdUZaT1Y4Z09xdjkxRXVXWWJ2VXE2QTBL?= =?utf-8?B?VWsxdWVZTTJVNEc0bkV2TXh4b0YrZzViNk9vOHQ5aHJYYVNFelZ1SmE5cGJE?= =?utf-8?B?ZHoxbDBUMUpaVU9GSkRlK0s3aTJtK0trWnprUmxGekFHYUdiV1p0djZjMUVO?= =?utf-8?B?QU80VFVQMmVycGp6WWJ2eUh6cTRkZHFYbm1tNExoZWdYdncxUGV1RTYrTFR2?= =?utf-8?B?Q2FlamdocEF0OWx0cm54SU1rbGx0ZUlXeDRGc0Q2Z2hqZXRVNDVzb2ZyOGc5?= =?utf-8?B?L2NkUFpuRUdGc3ZtS3dNcDZYZEtGREhsZ0JRTXJvMHMwQlBEWCtPQ3RadHNr?= =?utf-8?B?L3FuNmZtZUFuUEQ3RVZxVFBRTkplVkFHLzdZb2RseEtndVVsVE1maTdObktB?= =?utf-8?B?dVc4aFRpdFVXZW1uMU0zMG11bzRUVHFlbXFNbHBzSDBpZUZwSm1JdWJWQU9a?= =?utf-8?B?Q01IRUl2RnhBeklNQytRNXBoK2NMcThodFByRExWM2tUTjRFbllhR2dsSkNm?= =?utf-8?B?TmZKUDE1eVhnTmdXWXU4Y2pLL2E2a3dwNkhKY1RQUWFMYXZHWWpyNy81VmJI?= =?utf-8?B?YkZaMmxjRWFXek1LaGI3QVM2Yk1JaTJRd0pMaG9sTmJmaTBnN3grL011Y0xD?= =?utf-8?B?U2pHNWRVc3IrL1N6R2hlelQ2QTF0czNvUllxdUNoaXkwK25xbGk3Q0diVTdn?= =?utf-8?B?UHVMUDhtSk5QQVBwdjhxMG41WXowS1BUbllBQkozMk1VM1I2b1dHcjdhWFFI?= =?utf-8?B?dHhkK09MY0FuTGhkK3V2V2RQa2pqcmk3QjJpRXA2ZXM4MTlmU0JCRE9zdzN6?= =?utf-8?B?QXk3THo1N0JycTBOWlZ3OVR1K3c5bjRveU5oTDBReks2cG5DQ0djQUp1U1Z1?= =?utf-8?B?dFJVZ3J3S0hRUVBIUDB6amNkUldHdC96NGViK3YxSXV0SnhJWnRvNGxEdlNF?= =?utf-8?B?LzlFM01NZHl4T0crN2lnYi9NTG1EL0phTGROOUprejMwQm0xckJUTlEzVHJl?= =?utf-8?B?dHNuMXBzRG9uaHJzNDVwZDBkRzBGN01lS04yeXdESzZMcDFGdm83bU5acHBG?= =?utf-8?B?QmFIL29lckZxSkpCL0MzdHlWWExMa0t5MnNKTUMvTDhkVHpHNVdJL2htSUFs?= =?utf-8?B?bVQ3RzFHODlJc0tZYTJSbzlVTExxVy8yaFFSMUd1UmpSYTE2VjlSakd1amtG?= =?utf-8?B?MzdOUVVKaGo0UE1TQ3JXYzZOaFJUY0dBbmlIbkRHVUhLbVNUTVM3Yml3Mlda?= =?utf-8?B?M1BFMUVKUlVWM3RwQUdYNW5YVk5ZVWFOMUFQZ3JZM3o2OHNpMVV6SjA4a1NP?= =?utf-8?B?N3RvNERCNFFzRWN5MFFHQ0dZTytwVllia01wUUF3UHhBNWVHR0ZUS1J1ZEFC?= =?utf-8?B?M3UwUFZBQ3lpKytTN2pUalkwUm1nbVExeC9ZaUZiUENXRERGaUNJUzUrZ3pL?= =?utf-8?B?d1ZkdG52cytpRHRkZzJPL0RTOWVud2d6c2xDNWROTVpuNWRHMGMwckpiaE5S?= =?utf-8?B?dGdWZjVuZ0ltV1lTaVplZzVKdFBwNVhsa0R6Nzl3dzQxNDBnb2JYSmw3ZjhL?= =?utf-8?Q?ENAdDyKUHY9SrDmFqTCVs73A8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b0ada32-8c7a-44b0-ce0c-08daa200205a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 09:51:05.4586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NHyX0ytwDWk84vuu7jV52GCZ4BgrDZvCqnsomZ5/FwaW+yTBBKg4/YqmOHklLc8/zCJ9754wdmyEUpKpE+rHcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7209 With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_64/domain.c +++ b/xen/arch/x86/x86_64/domain.c @@ -58,6 +58,7 @@ compat_vcpu_op(int cmd, unsigned int vcp break; } + case VCPUOP_send_nmi: case VCPUOP_get_physid: rc = do_vcpu_op(cmd, vcpuid, arg); break; --- a/xen/common/compat/domain.c +++ b/xen/common/compat/domain.c @@ -99,7 +99,6 @@ int compat_common_vcpu_op(int cmd, struc case VCPUOP_stop_periodic_timer: case VCPUOP_stop_singleshot_timer: case VCPUOP_register_vcpu_info: - case VCPUOP_send_nmi: rc = common_vcpu_op(cmd, v, arg); break; From xen-devel-bounces@lists.xenproject.org Thu Sep 29 09:51:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 09:51:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413563.657279 (Exim 4.92) (envelope-from ) id 1odqCj-0005D7-S5; Thu, 29 Sep 2022 09:51:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413563.657279; Thu, 29 Sep 2022 09:51:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCj-0005D0-Oq; Thu, 29 Sep 2022 09:51:41 +0000 Received: by outflank-mailman (input) for mailman id 413563; Thu, 29 Sep 2022 09:51:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCj-00052L-8G for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:51:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b461dcd-3fdc-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 11:51:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b461dcd-3fdc-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664445099; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TChuXwC840w9+LOr9D+E1CZ+f718cGjtfvDJ6CjciMc=; b=Gb0LT4/qRe8ofnfQW1Gn5WgM7B/pTI9bpA6CZZ05q08S4iOadua3Iqrg 6aRlnQs9i5rEh5zQFMnBFf3WhjzDqB2lwC1WqUkYvqVgGbPO/Y+gEh4AA efieR6/+eDnGBMtDpenQkbQHcRMrTO1YuaOLgX7XgYxn+2IUdm1w3He6f o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 82031605 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ee5HTKyhI6kJdZFCdEZ6t+cExirEfRIJ4+MujC+fZmUNrF6WrkVTn 2EdWGqHPPqNYzfwKN10YYS2oBsDscWAmoVnGgNp+CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFsMpvlDs15K6o4GJC7wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2vRTEGRx3 NIkECEgRT6evO+E+6ybVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFIITRHJsNwy50o ErqwG/jPAk9HuWF2GCe0GKOo7fjlgLkDdd6+LqQqacx3Qz7KnYoID0bU0Gq58awjEGWUshab UcT/0IGpqEo+EumZtL0RRG/rTiPuRt0c99RGO0z7EeK0LjZ5y6QA2RCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdszHuMWium XbQ9nF43uhNy55Qv0mmwbzZqxK+gonMcScb2j3Gc0mL8zh0VrW7R5P9vDA38s18BIqeS1CAu l0NlM6f8P0CAPmxqcCdfAkeNOr3vqjYaVUwlXYqRsB8rGr1pxZPaKgKuFlDyFFV3tHokNMDS Gvaoktv6ZBaJxNGhocnMtvqW6zGIUUNfOkJt8w4jPIUOvCdlyfdpkmCgHJ8OEiy+HXAaYllZ f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlkUj8gOLFNSfKEeZt3L6yggcRs8u5TPj9q Y4DZ6NmNT0GOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+H+aSI0l4Uqe5/F/UU9Y690ijvruXo yrVt44x4AaXuEAr3i3UNiE9M+q0BscXQLBSFXVEAGtEEkMLOe6HhJrzvbNtFVX73ISPFcJJc sQ= IronPort-HdrOrdr: A9a23:fLl9OKMw3Ev9KMBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3/qy nOpoVi6faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrJ uIGJIeNDSfNzdHZL7BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.93,354,1654574400"; d="scan'208";a="82031605" From: Anthony PERARD To: CC: Stefano Stabellini , Michal Orzel , Henry Wang , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH v2] automation: Information about running containers for a different arch Date: Thu, 29 Sep 2022 10:51:31 +0100 Message-ID: <20220929095131.61034-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220926135838.47330-1-anthony.perard@citrix.com> References: <20220926135838.47330-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD --- Notes: v2: - reword to point out that it's an x86 thing automation/build/README.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/automation/build/README.md b/automation/build/README.md index 00305eed03..4cc1acb6b4 100644 --- a/automation/build/README.md +++ b/automation/build/README.md @@ -102,3 +102,16 @@ make -C automation/build suse/opensuse-tumbleweed PUSH=1 [registry]: https://gitlab.com/xen-project/xen/container_registry [registry help]: https://gitlab.com/help/user/project/container_registry + + +Building/Running container for a different architecture +------------------------------------------------------- + +On a x86 host, it is possible to build and run containers for other arch (like +running a container made for Arm) with docker taking care of running the +appropriate software to emulate that arch. For this, simply install the package +`qemu-user-static`, and that's it. Then you can start an Arm container on x86 +host like you would start an x86 container. + +If that doesn't work, you might find some information on +[multiarch/qemu-user-static](https://github.com/multiarch/qemu-user-static). -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 29 09:51:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 09:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413564.657290 (Exim 4.92) (envelope-from ) id 1odqCo-0005UY-4m; Thu, 29 Sep 2022 09:51:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413564.657290; Thu, 29 Sep 2022 09:51:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCn-0005UR-W5; Thu, 29 Sep 2022 09:51:45 +0000 Received: by outflank-mailman (input) for mailman id 413564; Thu, 29 Sep 2022 09:51:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqCm-00052L-Ep for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 09:51:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e9cbeeb-3fdc-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 11:51:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7209.eurprd04.prod.outlook.com (2603:10a6:102:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 09:51:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 09:51:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e9cbeeb-3fdc-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Um44iDY80XmzcMlLtS6N8A0ynJTcsxm9wFfNc4LWo3RWm+/INPezGtBGjM7F45kpxJw4IvRNHW7I5XDhx5F+/vsHV33RfEVe38hbGRKZUUxSy20QirwOeYwbM2Dyg6hkI7RyXj7FKWH+tp56rZUWZ4wTzRlXlrz+Y/6peN5o0FExo3S80Fh368MSHqno2z9PeMO8zZz+idiNmMjEReQ5E9wD7cLphLvg4Um9R00bmzqQF+gx23GVxvgg/nvTyaOMBuUANMwK1spiO8pTg+2jZhQ/UE744wE+p2b8Mb3hd5O+eQW9FuntZo+2VMhjQOA9FVv9F5+eJdn9YcQzIgG//g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ZUSWYGYKpp/n4o39lEQC3Rdxp/5hH97CjYq0VBAQYI=; b=ZOEXnSHTYYlljHNAOFp1HZw3fC+tb1hwHh8uqZ2P6IBZIlF7nREOJp1i50PDN/dqUH2YsU+HA/PPcguk0dnfIZw1pZPcoYUuHVloWzyWD8dZ6fruXT/5MFzb8LavI/rCRvCDOqnGsm5rxW0ix8FKipaPFePtU2Xwd1rNdiQgRDS/rp4dGYL0pQYzjSNYh8ApDn7llrjvCfIWsoQbGPYP5KP85aYir/RQbsdNr0kvNmgEO9pIQVjvgxGgF1kTxuLckOduJACnjmDwqeB4+8SZlp+GR8TWSk+0wf3tybxCdmTfFu8Ss1O6bIUA0ZGSfpbidSpQIPUAFIRMBKpeOotznA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZUSWYGYKpp/n4o39lEQC3Rdxp/5hH97CjYq0VBAQYI=; b=vgn2rS2nU+TPh441gnjZXXHd5YfP0wW6hMTPWaXA9krIkWu8tbrQx/TFn7i/nU3DP5IYOuhOILDsgV/oslCzP4qrgT92oVnZmHEDjFpAVhzM04zqYLoPPAjcELYT0ratAn9h3BjEEsvrqxpyjfZw64Sz1tR0AAs6vSblZTXcAMGNTs78SXcodCSQtzE8bIVvX4uaRmH7OwwMT3fGVP5kihbHGDoba8vXiyZ1mTowosHpsVN9w+rivlSqng/B0HFPXvZppAuTaKNqzt+COvtc5wsD7BQlFM+qcRCBArC7XSBwazAJEMkoga7/rmmuN0TXwy5kxnuIHWpv4/jUfM4Rmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 11:51:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 2/2][4.17?] x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> In-Reply-To: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0266.eurprd06.prod.outlook.com (2603:10a6:20b:45f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fa5ab9c-e278-4e64-acb8-08daa2003620 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qCfAdH/giAUrQedouOK+Hlbi6dndLFkoVGz9lslt9VOMNh2FghCwFhiI5secQYP+0edhdcbtLplZ7l0BQDEBxWt3UjHcMMnrXdLvu0wN+1NolagJWFBEHmqI3RkvpOIsSl+DaKuDTgJCSpxWDkLVAwRO7izVOCvrYl402lc7s5ejPK2NhJMjgvmKnggmRK5jl7dIbfcXKyN0lSDoHrsllVQtKn/6phMjYzPQpLmw7cZrN2EgUgXdrYtsTfGzEJMJMonJof8YjedOWb1vj0uTfk87QQ4VY84Oq0M/zEzzcAyXpQ2iaDHusHC1Edf6E/J/zs3/X8GqpE09UtjNCxfLeITTSaEbQI7Ob6te5R21gASqhRTX9WgnKT0VUY7HrIj92O7um9Rix3eSUZ33ujUTIjwzoSXnsLfZpPY7BGYhK5Un0bWoUD8qrhEDBU1xdIhCfxXTMYc1773/9Tor33UAYaqRydG5gE5FVG0qpYoXcJUzG35Y4KZkyjTtE30qMYssMa9L3ib5sLZLwibEUYMdh8fcXsl8RpVWQzh0YFaS6rUSndLIJlSofTjcG461S/LAOGJAal410kaS97tBkCw91SmGymI26bKKhUoV0qPSWwYR06WdDemXb8c1F0VXIVy6lHFeTQhev/DXJ0zcDIWSZr/J+tD1squLqvomuCcBFaB1malLGv3qIW77QljrfpGuLT8UdI1WF4zkeTB8hHVSOshAUfvDv/DfGQ8ZJZBQkciz2ghs+wi7LjNcfj0hg+R7a6BMnigZ+c28v4R42eXjZz2aRJhmucIVI3VeWq1JU0Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199015)(31686004)(6486002)(316002)(54906003)(6916009)(66899015)(478600001)(83380400001)(31696002)(36756003)(2616005)(8936002)(66946007)(4326008)(8676002)(66556008)(66476007)(38100700002)(6506007)(186003)(2906002)(26005)(6512007)(41300700001)(5660300002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEJXd1hJdmJTTXF2R1lXZDMyT2VZUFlaY2I3ME13U0l5cjk5SjhIay9TV0k0?= =?utf-8?B?WkhqMjIyQzhYZ0QrVWhudVBneXhaQ3k5T2FvSFBpeWpSQmdRZHdjVzRDMUZm?= =?utf-8?B?TTJVZFRuM01EdW4yR1AwNU9Pczk0czJEWG1VVzlJTS93V3Z4WHFZN3dVVWV3?= =?utf-8?B?SHRBZExPTlFwZ1pVRmRFaWE0U2MrdSttU0xvVmg3aUFtR01lT3hKbForNDJ0?= =?utf-8?B?R09DL3JSR0tOVzlwb1RMa2YzQnlneEpjL3V3djFIVUxsUTF1bFpKZ1FaWkho?= =?utf-8?B?bURURTNZVmlCSU52VVFyY3RRa0ZVNWhoVStJdmYxUDRFV2RJOHJ6bmNReDE4?= =?utf-8?B?d1dTT1k2b00yaDlsLzhmb0xQdTJENGZhTWlaT0xIanE1c1hzbkVxRlBaQ3pq?= =?utf-8?B?QVBNQjg0b29NNDArTEFKQkhVcUk3MkU4TWNKOVdnVE9CYzY5YUtKdTB2dksx?= =?utf-8?B?ME9RZHBRMmxtK2hGUFA5N0cxZzJNUGNCMTFVdklRYWlpalFnbFR4R3pmZXhy?= =?utf-8?B?Nk5pQ2EyQmVKb29POC8vMFVoS3ZrWnh6MTZQSE5VZlo1OFBSblNTWk9mR0RX?= =?utf-8?B?WVJEZEdOVjZxR1FSTVNuMDhZaDFVREtGV2l0dnhML0dHYVpQWGpLL1ovbTZL?= =?utf-8?B?WW1QaS8xWWxFc3hkR3V0dTAvUHk0Y0QyTXdDWlhOc1Jyd3pUZmRqZGY4blUr?= =?utf-8?B?d0lxYUdWR1RYeDFWQnpKZU9OK1RYclczVDIwbjJSK3ptZXFLa2xzU2owMDB1?= =?utf-8?B?Wmd4TDNFQVYybVUyZGNjN1MxbFVGcjBONlVKL0xUY3ZzL1lzNnViZ2U5NVZS?= =?utf-8?B?WXpxeWZFZEhFTjRURFNGU3Eyc0R1NmRyMHh5eDFER0k4YWpMM3N2SGZOM2Nz?= =?utf-8?B?R0EwU0NIYWwzeWJPYUxRTE1HWENnM0J5eTkxN1NKSGpEOWF2cHdNTXFvQm1Z?= =?utf-8?B?T29ER3puQ1JuTnAvL01EUG1haXF0M1NqeU1aay8rZUFrbnYwekExbzVoVlB6?= =?utf-8?B?OFhnVmtEcFprVkJiQUtsQzhMOFRnWWhrWVdCdUJldzZqdmV4T3FxSDUxdVZ5?= =?utf-8?B?aHRMYVpZY2k2T0JPSkRMV0N0WmRrL2RPTmwweXUvaGREb3RkT0NseGNqdnQ3?= =?utf-8?B?RHJmMU4wWWZ4NS85YmNObDh6T05XSitkU0x4MEV5UHpGd21ZaGJESkllUHFz?= =?utf-8?B?Q09QODdnaXg2a2JIdDkwb1ArYzJzV01IUkJjeUE4amtGSXd5NEdpNnlEdjBW?= =?utf-8?B?dEkzT0J0Q01YUFlPRXUxNGNwNlRrdksrRlA0Mm1aNHlmMnA2bEE0bGR0Skow?= =?utf-8?B?d2VNTU9jZVV5S0EvdngxVkZKQWVRNWV3MFAxaUNlblI2RjVaYlMvMFI5SHpD?= =?utf-8?B?U0EvVVdPUnViTm5kT25SaWFiN200ZjVNRG1DcUU5RDBXdkQ0RGVrRXF1VU9C?= =?utf-8?B?UHNFTi9hTkpDS1R5aDNLaGRYQWxmdExma3ovS2w2VjBXekNFTktzc3U4T1VD?= =?utf-8?B?MFpOanppUzNxQ0ZaVjB1SHdZeU5TaUxBWWpCdm1jVldnaHBZY01FaE50eDFS?= =?utf-8?B?TnV5L3NxZEkvSEVjaUU1bEZhSU1EbWhTS0NSY3o5WGU4aXNPYVBSNEplQ1Np?= =?utf-8?B?cFNwN1VvdmNzdDVFSmtHV0prZzdPOFZsaFpDdjFwYUZrajVlSmp2TVRmRS91?= =?utf-8?B?TWp2N2Rra09pQVdURkpQN2ZXek5VcnZCR25CbUNvbFkxTzJvZVJMSThZTUZw?= =?utf-8?B?aXdIdDBZVHhVK1dteW03emR1OWQwZ29MaTBQYmpRcHdBdlBpQzV3SFVqb2x6?= =?utf-8?B?MWZ1Q0xXaDFPUDlWYU9WVU9ySmNLd091Z2YrTFNteDMzVHVBSjR0bU8zS3JG?= =?utf-8?B?MUcwWEdyT2IxWVBFMllGYWNoakZod3dHSXZLMmM2MTdvMGJBM29CU0VVTCtt?= =?utf-8?B?M253SXBiSzJGSkJFYmxxTUxoSzIwcS9qVVNnWVlSTU1Fd3MvSG9xSFh5TkJY?= =?utf-8?B?SXkxTURHMnVFUGNCZlhnQzFsRVprUGlRV1RtdUZ1WlRPaVpVbU1LWUhveHgv?= =?utf-8?B?czdvQ2ZROWhTS3pBcUZyKzBpMFpRbGRzdU1CeWZZYjI3VUlwQ2YwV2c5b0hv?= =?utf-8?Q?pqfBzJIcR+11fx17bVOBtFnfz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa5ab9c-e278-4e64-acb8-08daa2003620 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 09:51:41.9875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fTFEhn9OmmkYkr65a06lMXQXXN9GlMobRnkGPwFbMmcjmxWBboH6jU0yPN13yOSYgGWneLD0UlHkmspAWH2JlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7209 Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich --- Is it actually correct for us to do cross-vCPU updates of the area here (and also in the native counterpart as well as for runstate area updates)? The virtual address may be valid for the given vCPU only, but may be mapped to something else on the current vCPU (yet we only deal with it not being mapped at all). Note how HVM code already calls update_vcpu_system_time() only when v == current. I'm surprised by Linux not using the secondary area in a broader fashion. But I'm also surprised that they would only ever register an area for vCPU 0. --- a/xen/arch/x86/x86_64/domain.c +++ b/xen/arch/x86/x86_64/domain.c @@ -58,6 +58,26 @@ compat_vcpu_op(int cmd, unsigned int vcp break; } + case VCPUOP_register_vcpu_time_memory_area: + { + struct compat_vcpu_register_time_memory_area area = { .addr.p = 0 }; + + rc = -EFAULT; + if ( copy_from_guest(&area.addr.h, arg, 1) ) + break; + + if ( area.addr.h.c != area.addr.p || + !compat_handle_okay(area.addr.h, 1) ) + break; + + rc = 0; + guest_from_compat_handle(v->arch.time_info_guest, area.addr.h); + + force_update_vcpu_system_time(v); + + break; + } + case VCPUOP_send_nmi: case VCPUOP_get_physid: rc = do_vcpu_op(cmd, vcpuid, arg); From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:03:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413576.657301 (Exim 4.92) (envelope-from ) id 1odqNu-0007TP-4c; Thu, 29 Sep 2022 10:03:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413576.657301; Thu, 29 Sep 2022 10:03:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqNu-0007TI-1K; Thu, 29 Sep 2022 10:03:14 +0000 Received: by outflank-mailman (input) for mailman id 413576; Thu, 29 Sep 2022 10:03:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqNs-0007TC-Rg for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:03:12 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8d73a19-3fdd-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 12:03:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7934.eurprd04.prod.outlook.com (2603:10a6:102:ca::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:03:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:03:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8d73a19-3fdd-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YeuWtdWhmgPoBXp1dzv43YqUEgEtt3acyGgjPZIjITbaHnDKWMCjJYkjhBWCIMpkskH/wmEFG699tmFXCfPCRbkoubwCbTZyEVugjs1Hz9sefV4+Q9HrrEwtfyedPcFjEXFv1zE+dTv+XSxMuh6ysjL8SbARbLpynl8hMducLnnWpwPsrjkxvLB3/VkumGN8CMZm095QH4CpF4wZhYHCq2X3DogROljfuqzSCtDSP2vcX/ryHv1LYvJQrbYopnfuCIwmTNRMx51HoEMg66KIcvexd2xsKc8y4F4J8/PkZgiBNMBh3E90M8BeGG5Xa4H8YDjGFGBwcXZ7swtDN+4ptA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vqHPrMRFDMxnRH3mmMDEVFzyzEdco3YGI8ccjHt7J8w=; b=SWg3hHXoPUS+SoGNLe108vvcBPcf6azLFoRwY84FAc2offB47rbUzQTo5SAe11e+eStrWfT/0UgFYkEU4PehZ7UkwLmgj2jMuu8cIogwDboI21TfsRM3CZs6A8pUXyJc6/JFxqW9fbgnjb5ZUydSmaXCZhAp7ckSJ8pQupZwaYIT7IhnL3SNtRXcYi5EWy+8zzFP59TLcVrGzdjhSrpJkmbJ5W8f/QxavlexYdk8RUxr4IhtXcA3dsPDDYa/IjI2sd1LMN0lwW2p/3Cc11+R3vU+1yuUJeL7RHAttSHjDi7Oe9Q5iXgLG+TmVoC0qwuKfP11iZcnOGDObMZ8jV7onQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vqHPrMRFDMxnRH3mmMDEVFzyzEdco3YGI8ccjHt7J8w=; b=zkuDnhrBnlTWumWCBrb4DDfXCgoy5WNI5+z8FEQ+sE7cs0woNnYUedGRF7gIWKXf25bbZddFc00kgLjDyOgZXtK/FR6GuzdDMbqK0e7DvgFHROUBPN6+ISD03vYcpldGPDOyjujLWuzALKQaO06TFiJfT0sRnHIJFC58F3sXtjvABVK4kOOaeXKbGWX8CyIuu5BswIFtdr4/HHkYF513ikq9okHHLwhvg3vunJXuq+kudBmpjpdxa/GJzMZkjS5o+88h5fTHApzLGlZmPZyMwyYXiEs070ZjGDBRRWqlc/05LG3Gl5+rpIUQHPP/IUmQ8h4OwCh46XgHVfJRfHSxyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com> Date: Thu, 29 Sep 2022 12:03:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 0/2][XTF] build: suppress GNU ld 2.39 warnings Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7934:EE_ X-MS-Office365-Filtering-Correlation-Id: fa83d8a7-e82d-4ab5-48ca-08daa201d014 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nnULCkhNu81tEgk/R6U3aspb5ncSGkV+25K7hNnFLnBnXx6SFHt3uwe3+I3VpzxumC39+t7FZ0GLrUcbKBYiMQH1yipX0/kc/o7/5vcAIOvsEkLr4inwZbK5+X4zR/snS07RBVJHr2wxH6zsGRAU4CfSGGQfgoVkfyFFKQfTaH7QwZTEODY1zSb2ft6eP5kZQP4B5nBEWz/1jKjV4PUtJT9SAbSvFO4C8PpEEUmp1mq3hXh8FomjvgGXCrXX9FS6cVnq1IMP/3+sS2IGv9JfT9UMGl5rhi+ZQhccDte4tVqeH2L/YJyCCk0/r2wdxTFDtyQaQrzwqBBYk5GGXVpDQPehjsiqWGisqi7Ol7t8YOSMGw+H0ydHPfNYAH6PFwfdX6Gz77troOX0sv6TZQu5hkEa3WMoevLcd+ldhEwvBa/pHYX/RCCiOCrGcf7dHU8TNBCQ0CAnsrXCdzgI5cg2UoiWy/J++TSpqFkMxCA+GCqUtioqqWqpDacwOwzpUTrOFjY/ZcSH+3Uy2Kkbw+RyXokO9bpA9iASUxEOhMDIKktZnFWmto/1j/kh3jHAJYmR4WCFNuU1Gq1MbuWVeTaR6QN9U2puzS84QDduL1ElMF/7qHPKr0kKX+hR3wc01AoWL7G9wrHzH0fmugaW+gSZDxuzTP/uyPBsMxSoEoF5O0JT3mSRtWIHt2lTSWCdRXm3RYoY2SGAN15mQXlLh+SU98g78Zxni0hWezMf4u9oly7ZAHj/KUrWq2IZgDVkcrd7f9HFheKuGRvJW80ISN1xYrtrjmviUDoS8VSmIy5++Dw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(31686004)(6506007)(66556008)(66476007)(4326008)(8676002)(558084003)(31696002)(86362001)(6916009)(38100700002)(36756003)(316002)(83380400001)(186003)(2616005)(26005)(6512007)(478600001)(6486002)(66946007)(8936002)(41300700001)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnhzRjU1QjFWVGlTbThCYmpyODFXbnNzSnJweTJUK3I5WG44cUEvKzljM21Y?= =?utf-8?B?WnM1WEtxWkEvTWQxMitLc251bG50dFNiSFlaWEt3d1dCaXIxYStjSE5CQ1dR?= =?utf-8?B?RlF5bmU2cFltMEpGQ0JGdjI5cVgyaTU0Umk1V2lzazNxMjhlSjg3cE1nTlkv?= =?utf-8?B?SG1ieE5pQzBjLzVweGZyN3hnU0NET0o0a1YrVHBqRzRwL0FWQnRmREN6eFB2?= =?utf-8?B?LzJtcCtZdUU2MmpNcXZGT0Q4aXZIKzA0Sk5kTk85aHBBdlZUb2xGN1JxUlhR?= =?utf-8?B?UzJVeDlKOFFJeS9mdFZWR0VsRWtTUEhRVUVhblB5d0dOK2ZDODR6NllQeUxw?= =?utf-8?B?T2xnMmFpMmJMQWpwM25jRU1KMlFFMlBEUjhETlBBNEF3S1B0STV4UGNYSjdq?= =?utf-8?B?OWdxOFoxTFQrWGk4ak9GQ3F1NXVCcGV0WmlYWlZKUVpYaVhvSTU1eGtqSGE2?= =?utf-8?B?WnJlb2c5NW5kWnUwRUYycUErc1NjYkd0eDczSis5ZGZEMG5xMmp0R0xaTUs1?= =?utf-8?B?V3hhWW9PVHVMYkxtZU84eTdENHpRQlpZb2xDQjJ2VGpJaUQwSmRiclBJS3JU?= =?utf-8?B?K1lwQ3R0Rk9CUWxqb2ZPNFlZaU9JTERLYmd5RGdZUTJpeUd1b1VnekhXdzlt?= =?utf-8?B?alBTYTFLSDhhcHlnbmZmMS8ya2tmY3I1QStoNWJvWTFkSGdTZkhSSHkwL0VZ?= =?utf-8?B?WC9BYXNVZ0VxaG4xdUVkVHIxSUdCK2ptL1BiRlNYLzlFNko0L05BYWtWckNn?= =?utf-8?B?SkJQVmZnK1ZYRng2ak9Ub3ZhZHR0a2tmR1ZoZlE0c0pzNmxrbnd1YWhCb1Ix?= =?utf-8?B?Z1RDcHp4cmVFbW5aVSt4WEtLVUxuak93ancvQzVOTnM1cWpkVXJybjZUNTRV?= =?utf-8?B?TVpFaURpUFhxcEdqREgrS2c5K3M4TUhjN1A0eHBpZUZNUEhuRDRSOG9XWmNk?= =?utf-8?B?SEtnT0Z1bitwLzI5dHRuT240cit0SGZvcEhCZ1QzYiszWVAydGRDWTgxNmtw?= =?utf-8?B?TUFsN2k3WGVDL2kwN2xVWU1ZSTZFUVNGQ0RGMi9kOTFyRnpMQVlEdVZRNFVD?= =?utf-8?B?ajQwa0gzOU9JNWRmbkI1ZUNDTlZhSWMzYjhCa3dRNGFDblkyZkNjRmQ1U3Uv?= =?utf-8?B?bWgrMnRLQklrVmNROHAvbkVnTVRoOTN2bkMvNlVZZXNoaGlZbGcrMEMvYlE1?= =?utf-8?B?UWxKWFlkc2tNUHdNVnI5akJJSHlQL0d1aWRJQWtoU2sycnViMEpXczdxMU1m?= =?utf-8?B?bjduRXJ0SG9SNjZ4UEVMZEUwZ1pTTWdJZ3J3TlE1TlBUQ0lTSSttTldSODhz?= =?utf-8?B?RlhZaDBIbm51bXdkRDdCUk5qSmFnampBQjdPbi9tOXpNTlgyNEt0RE1IejJz?= =?utf-8?B?YkRiNmZYWEdGUDY3eVpuY2JoQjRvL0Yva3BaOWFsZEJTaDJHV3BnMVkrQ3Fx?= =?utf-8?B?OGRHelNuYUJsVzRLZVNjN0I0QUJrUmJWVkZNM0h2aytoU3hMdnQ5eWw5Qkhr?= =?utf-8?B?YTJtMm1oYzFNL0YzeW1XalNuckFTTFYwR0M5RXlVY0RnMndOUHU1Q2xFUVlX?= =?utf-8?B?a1VENFk5ZW9YQXNwbTc3dFZaN2JrSjdXRWkyd3R6aUpEUWJWRjJvNE45ckw2?= =?utf-8?B?clpVclRHdlBNWlZhL3pBTFVzL043QTBjbUhWb2NoQ0kwakFXeVI4aTY3OWRz?= =?utf-8?B?WHlEbVl1UHpDRi9JNGg0ZlNSWkJtZ09aL0VRbG4zTmtLcm9iTE1FR3JnQzZ3?= =?utf-8?B?SEtpQ0NIVEdRQWZTZllZK0NOcHU1NmJncDRwSTg5MXR4bE9xYmVPdEVHVFBW?= =?utf-8?B?QXNuNHhpWFVhbXVmSEV5cFNjVUdoOXhkZXpVaWtpQUtuTC81NWxlMGZsRFZL?= =?utf-8?B?STR0Q2l4Wi9wM1ZjdEMxWHJ0QWh3NXYva3U4WmdjeFo1L0JrcnRJYlE5Vlg5?= =?utf-8?B?NjZhMlc4L01lbW12bUJWYkxSREtJWEJrdUlFYTJ5OUgyLzlSL21jTGFBMUFB?= =?utf-8?B?ZzFzWWw3cGNNV2laSk96VnAvV0lUKytIYjBZWkJ3N3Jyclh6SVdvcGQ5UVFw?= =?utf-8?B?eWJUL1RURy94ZmplRWo0Sm1FV2RGSnlDR3cxcmtnbkpOTWpSM0pXa0FxblVl?= =?utf-8?Q?H+09cbv9XkYEXITKz2o8TIQOE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa83d8a7-e82d-4ab5-48ca-08daa201d014 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:03:09.8034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w4/bnWYxdGk2Z0uZSb/ujzf20q7LerHQsG2udfS77GbkARvi+FtSYUNpXxvQ3Z/OhO8dVn5ndhubt5KiB/E9nA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7934 Like done previously for the hypervisor and elsewhere. 1: suppress GNU ld 2.39 warning about RWX load segments 2: silence GNU ld 2.39 warning about executable stacks Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:04:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413581.657311 (Exim 4.92) (envelope-from ) id 1odqPB-00081q-Eu; Thu, 29 Sep 2022 10:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413581.657311; Thu, 29 Sep 2022 10:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqPB-00081j-CL; Thu, 29 Sep 2022 10:04:33 +0000 Received: by outflank-mailman (input) for mailman id 413581; Thu, 29 Sep 2022 10:04:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqP9-00081Z-Re for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:04:31 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60046.outbound.protection.outlook.com [40.107.6.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c008c1e-3fde-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 12:04:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7934.eurprd04.prod.outlook.com (2603:10a6:102:ca::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:04:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:04:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c008c1e-3fde-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fvUQGdyaR7bSnSU6XEy/TtnYBCmy4H45jRhdDNt2Z4IakQpZctJ8JSsiq2n2e8WCj9GDafgkuZSN5DSWnCElvFEudxTAFMbtjzCzhqBavqGlZQ23SJADlrQC4NisPXZZBJY798pgVyoc/grvvH64PUtYheLIPfvCc8c3ZypQlOj246T+vm1OCB85TGWh9kqCLUiu0G7xvbhWzPM5wpFxYGI0zcfnhVlGZPIXe9Zyly4NWqOc8lDLbRYTqfpYTwnE7URvSjJwOMF1/dBL/Nztk58s+k5n71tx5uoAjek/migKeCxnVrT3iwbS3hsuI+2Aa+cgLietOv3ERgRu81GMEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=048DkF7cg76prCVEaBhWp817vBIbJM8wG6eU8S9ELqA=; b=LCCm1j21LyBijaABHeJwO6OS+J9JTrBARGcCowCe9iNYL/tAqDmFnqR9+oAWMCSlD5gPnStSgjL3E21Tqq13yVsBjhpHNTKC20mumKlNCBt+kBrp2HTO7MT9nwr8TU1n2ISHVjY2Zw+m2Bcm89HDbsNzhIvbr500vGaRVoc4tDc4bHx5Jyqevh877Pcwh3MUweRP1uzEYEkt5H6mT1i5wdFYFpu9gmdTVHMe8oFakFkcMVoKb+IHNSglkTmimyKoPZ8Li4LPWXzcp/CabWHApQllMvWoKUgippcNXrPsMaCvwWj93fVTdwW6jhQGPC/4YuMsPQuZzm0mkN/lfZATbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=048DkF7cg76prCVEaBhWp817vBIbJM8wG6eU8S9ELqA=; b=sOiusSbA2j+NDHpypxOKN6zTuuropyrLjnVButgMW1H0b3g9iU8QaawAoWSViSxaTOrlFRfISIkD1ArEH0tI/xVdK/xD5Ix3ElXq3wDmAPwbzS1w88RVa+HHRjsOYB053kvs1u7YGiSxowYQY9R61bO1EHt8G4QLieV8c7wV35/MqMMNffHS5ip/9udlwsBcGXrps9QIdT2Uu5zM7v+NTQRuSXcmAgi75EkGjkNvMWJY6usgPg9rEZRtry6U+L9Hp/3VT/izCOS3qv9PdNoXEf8gYbZvgBz5sVFEGbLuxchvrhU2lIbMBDr/GO/J3r1V175hwQSZNPkrVZTzwC0dQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4868cc00-428c-a315-1a5e-cada97957bde@suse.com> Date: Thu, 29 Sep 2022 12:04:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 1/2][XTF] build: suppress GNU ld 2.39 warning about RWX load segments Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" References: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com> In-Reply-To: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7934:EE_ X-MS-Office365-Filtering-Correlation-Id: e2d9526c-f30f-4f7d-1737-08daa201ff8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YejrkHy0VpJYtu+yPb+rwzck9kCbd8bH5dYsOjT82vRFgKaxf1r5QBsMf+EpJ+W+h5Hn9SASDC1nd3JrEUZzM+FQFPzhHpysUoouD2LMTT/4XtYxk4f3fEDAUE+Zenbpic+T8mH9L3k+aqxKYginkRDo036NCiuNskCr6Hx8NYZEr/uQjy2G/bH14Y/Z6BTHxoaYh1JEOzc7dGgEvJgKwJNajymV9fRGZuf6RL4n/xqsJFd6I3fZD9y79vo/OkxmXQ0cO61U4mh+0wgwIuYiURulkYv5AYNGR9XsrC/q/7zYYtEYjyJ4iwx4AggtTYcuJWtpWChWQgnb0YSpiI0ZpgcvrVyDRaFkDA2RmmlHasmwi/1LeqDywUAgyvlFArTZ+oxTKFVlb5C7xUU+TC3c5/g4uDywvlnx0HHZYWqoEqZQdmaoYBSduR7Kd8RaVUkxVKfpYqyxVfynBdH6xZ4UizRh646MBb343HrCEDAANgLVvFP8ZeQ58IYMnmA+F9wK5pnnf2CfE7hBwS/3wL2Ls1QA5YXcKwOeNfbDIJrXGkm6/GuMhWap5jWWIQ6ZHSr0BEkA+M3ChJXZVMz857r4zrr9UiNKfdy0Uo9rM02mmNMu0zJ2IEa3IL2WS2BTyoJ+FGTXSOHQWxVDfk+59JxuZXMj0TPq5Ra9JRuLlJfw160hdrSF3DlvVWtbT54BCwbv9p22bK1P0bTjHbeMQNvg+yXMrq1g657ZJ2VIHmmlxAFOXduE3mMzpyWJ5IAQ7PKU1vVIpvEsB7b9mb09rr8k+sKskA3Na5JTgxWhee2oUq4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(31686004)(6506007)(66556008)(66476007)(4326008)(8676002)(31696002)(86362001)(6916009)(38100700002)(36756003)(316002)(83380400001)(186003)(2616005)(26005)(6512007)(478600001)(6486002)(66946007)(8936002)(41300700001)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2ZlZUgzUWczaVdrMEVYWENzWm5uZnpQOFk2YzBmdzJyZkppajIxdHo5OFZT?= =?utf-8?B?RjZndVZ4bGJWQlVOL3ZMUTltTDMxaUVWVnVoRzhSTjFXSW1RdEZCOGRmd2VP?= =?utf-8?B?YnpMcFYyS0UveXlUOGFFNHcwM2tzVmxkdk54bXFuSFZJbnBSYTIxcGNoL2kz?= =?utf-8?B?UFM5eVA2b0hVRlpoWms2bDM4bS9UV0JSWVpVVGlqVzI5OURuWXFDaWJKd3Na?= =?utf-8?B?d3RUZGI4UXNGYkx6SzhRYVBxdnEwNVBoS2hKS0xvY0hvS0NwRFY1dkY5Nmhr?= =?utf-8?B?aUFSY0hGUURxMkJiYjN1ZEo2MDE1WmZmZi96V2Ezby9PeWdwZ0JLTlJlRkhi?= =?utf-8?B?cDVyL2tVY1hqcmJWR0xVNGI5akV3QkdzNkx1RmtDUDQvT1k4eVBqbFBwdmxD?= =?utf-8?B?MzY1WjF2TWxyL1liMjErbjZSeTFjK3BhUzdJd3AwQS8wTGREZ3lTUVRrZnZG?= =?utf-8?B?OHMxdDV0M3p1aStBa1h0M21Fd1o3QUcxTU4xSWtEQ0lJSjNGVTh4cXlNVURO?= =?utf-8?B?dFluV21JWVhGaXJseGFhblBjZHVDYXBzUG94U2dha01NVmR6Y3VWY3hDRmQ2?= =?utf-8?B?V1FTajNDcVdqeU5tVWdXYW1SdnRTQlhrdVFwQ0hTNHdvWGpOUis0RnJ3WWZw?= =?utf-8?B?cUZJdlNFQnVtRjJNajhWYlIxMHUvaGpRSjRnRUFVb284YkFGVi9VRTBsVy9v?= =?utf-8?B?aTBtNklFRUtLNWo0dWdtcGlEUnNJd3R2RkJvTzI5N0duRDFtQmRmMHo2elI0?= =?utf-8?B?WDl1eTRKNUpUb1UyM1pRSGgrc0dWVGNMNGRyZG9nYWpkcTRPZkhlNitXa3lD?= =?utf-8?B?YmtXOWZTZnEvWkRVK1dSVW9LUGlkcHdUY3k5eFZleWRJWFdQamtLZDJuWnhU?= =?utf-8?B?dW01dEJWSzRjMW01R2RVZG5UZjluRUhZdnB4UURWdEZiTGJDZTI0TThOTzlo?= =?utf-8?B?QWZXbjFKR0lPcHFuVlJ2emZta0dSR2cybVpOY3JkSUhkejdkWUpmWG00RmYr?= =?utf-8?B?OFFtYVpuM3d3RUNORS9zM0ZMbmdLMTFLK0ozNnNCRzIydmdSVEx1Yi9pMDZI?= =?utf-8?B?Q1E5RzJWd05xekhIb1RQRUUxVDlMaW1ZbVpNTXo3NzU4YmgrMFRncTY1RGlI?= =?utf-8?B?YVFGd3puL2pMOFNmZjdlSitUNlNwSzNrTjJTODc5Skp0MVNBRGRJMUtUZ1JF?= =?utf-8?B?UnBwc2FPbVgvMzVNdWx2cFhRZ3F4QlNXM1o3OG5LaU1TVkpIelJBNVFYbkFl?= =?utf-8?B?N1dCcUQwRmgxbGMwcVFpbDh3cVhjeHlXTmpHVHEvQkh4VmlZbGNNUTFNcXRr?= =?utf-8?B?a1V2QjNhZGFmZ3RmQ3hsRE12WXNEWXVJZVY2Mkt1QVhjMGwydmVzTmdZS3cr?= =?utf-8?B?N0Roc1lQd3BURWhTdUpwczhmSnUwOG5UUjF2NFBXeG5HbThVY2cvMXFQMXla?= =?utf-8?B?bW1jNml5cUFvbjBBemZHVnRZUnB3SS9oWjFsNkN1d3ljc3dNOWRwVFJRbk1Q?= =?utf-8?B?alJidGV4N2ZrME5EcHl4bE81T0srNE1KU1Q2Q2R5U1ZJaEJTd0hTVkVUdW1s?= =?utf-8?B?U3MvOG9CS2RRZzZjV1FxWHI1SmNxQ2c4c0NTUHhycVZuckY0Q0lKejJwUlpx?= =?utf-8?B?d3ViUWQrbFpPcWRrWjYwaSs3Q0RxQ2hGTTJFZHd4M2ZFUlV3SG02L2lSa0JJ?= =?utf-8?B?M3hxRU03ZDhRUkJhYitIVE9heFJTWVBTbzA2cmdka2hmSG9jdERhaFBub1pS?= =?utf-8?B?QWhtV2ZUVm5tMlZpdUkwS3QyN0JOTndmR1NXNU51b0hFU2R2SUs0Y0NDY0tD?= =?utf-8?B?TTJvWWdHNy9DMTJBNXRrUDVhRzBtTnRzdnh2Zm84R1hhS3FBVGplUUgyMGFu?= =?utf-8?B?amMxQkFkeE1jeEFjQWxKTHgydlA2WHFVZm9iUDBCdkl5TlhpV3RrUU9jZWwr?= =?utf-8?B?bmQ4THZJalZpUGpGS0JyblBxaWt4aEdlSjFMMEhsZzI3eTNLZFdTblFDc29W?= =?utf-8?B?bitDN2dyS0pyQk8xTkF0dllEdFJ2NjVOeERjRmRocHF1OGdRenZ5QVU2djNW?= =?utf-8?B?L3JpSnhrZTZmRDFlK2xDU3BuaG1OdnhFdTZWTFJrVDd3NjRHeTd1aVNUK2RV?= =?utf-8?Q?JXR0kdOKkRM+xwb2zusDP7ZVC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2d9526c-f30f-4f7d-1737-08daa201ff8e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:04:29.3609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pBNBAktvYu4iPWK1WkTBQNrc4S5QT4jAKMHEiw703xEklpq4mp011Pd9UCI26a72YfFIv1FchfG4+XJ/ecwC3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7934 We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort. Signed-off-by: Jan Beulich --- a/build/common.mk +++ b/build/common.mk @@ -20,9 +20,15 @@ COMMON_FLAGS := -pipe -I$(ROOT)/include cc-option = $(shell if [ -z "`echo 'int p=1;' | $(CC) $(1) -S -o /dev/null -x c - 2>&1`" ]; \ then echo y; else echo n; fi) +ld-option = $(shell if $(LD) -v $(1) >/dev/null 2>&1; then echo y; else echo n; fi) + # Disable PIE, but need to check if compiler supports it COMMON_CFLAGS-$(call cc-option,-no-pie) += -no-pie +# Suppress warnings about LOAD segments with RWX permissions, as what we build +# aren't normal user-mode executables. +LDFLAGS-$(call ld-option,--warn-rwx-segments) := --no-warn-rwx-segments + COMMON_AFLAGS := $(COMMON_FLAGS) -D__ASSEMBLY__ COMMON_CFLAGS := $(COMMON_FLAGS) $(COMMON_CFLAGS-y) COMMON_CFLAGS += -Wall -Wextra -Werror -std=gnu99 -Wstrict-prototypes -O3 -g From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:04:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413585.657323 (Exim 4.92) (envelope-from ) id 1odqPX-000065-S2; Thu, 29 Sep 2022 10:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413585.657323; Thu, 29 Sep 2022 10:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqPX-00005x-PH; Thu, 29 Sep 2022 10:04:55 +0000 Received: by outflank-mailman (input) for mailman id 413585; Thu, 29 Sep 2022 10:04:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqPW-00081Z-JW for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:04:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60084.outbound.protection.outlook.com [40.107.6.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29c4fcc2-3fde-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 12:04:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7934.eurprd04.prod.outlook.com (2603:10a6:102:ca::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:04:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:04:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29c4fcc2-3fde-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2Tn76ELU8cJn9UBT/rIjizIiKI55V3cwJNa68nHPM0iruUv3R2fjq8XVWGTAryZsmgoPBmXjnofSNptRdl5LFMdjSYbeEBaMcBvYkKSjrDVW1m1V8TAoQsDgU64AMI1PTovUUIzVsynaZR24Uztq7V18QlYGkXApNsOOfrZeqlBpKVdSa+h2DiR5i6duvn2zCG8tedB5tC4JJJGq6Zyi/9E7bFXjycHld4fQGqFV9fKMxUiKE6eJrDNUBkZntAYqcUBl7l/8DH8PmI0TbXWRot9CFgDfab43vVNAYRW/OV7Gjei9xGEbdBUfEvy2PMvTfJ+980olAqo8tOpcmGwTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EWt8/wR54+6m0d8cbccRfiANwhiSiGr4J0UEGqibS/I=; b=dic2qwF78P09vq1QIhZqm7y8KhV98G2eww5D9cKuqP6VNvBm7+1Jhh0ROu7ZnKtn3eijKLE7MsiL5NnT/VbaUzv45U54dvYZhtk4j4/iu3X9U6EbWda/6udHrSsay1OdwFVrLu1XiuAZk+uEX89YtPV/8FFSi8Far6pHIkUsYONl+/1MlXMhki3YkuTFrTyw2SZaoJhPFubqiwwATrEp8gqH1Jb0uJWcu/BvFLGUa+7iJ5E1tSjjiYViWmYjgO6VmVgO8udiT/5xfFcK/kW44NJnUzrskMXX1+V4czOiB8PcyerqrxRMOqK2v9CrlHxnF4frGCedR41YwDon5r2irQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EWt8/wR54+6m0d8cbccRfiANwhiSiGr4J0UEGqibS/I=; b=V/lZ2jp+sZ81bnD01IJnIOJ2nVCA5gX5GN6xWNaAHB08eQshv9JHdCqUdTa9VgPH5f3kR2HV2X7NA/Lrmmbjp8wlM4LYLrn8br4BvdDbueC7NXrl34vLr0f2j+0n6Dj7CAj4byln8t67w8CQZsHeZ2f3aWc+5dyJYiJiNHBKYS9IZeEIH5qa5jtPjb/ondGRn+9+FtayD0HOY6XniXLRnm/jd2QPjyDeCCVMMsF3+o5UhUTroyYnXWSyNZa2wv8RBya9ymZ9cOSr8OTJqecz/LbrKTrvghbrqHcaHzcrjGkwubtbN6vS7Yq78TvMeyjcrIXRmSWgbrtmeaaj4HpItg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 12:04:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 2/2][XTF] build: silence GNU ld 2.39 warning about executable stacks Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" References: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com> In-Reply-To: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7934:EE_ X-MS-Office365-Filtering-Correlation-Id: db58ce86-f134-4ec7-79d7-08daa2020d18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: keybxS16UmZuK0I1Y04CDth27iTEbbLPfsuBkfEIiZhHnGzT44yhhIOTyjzd6qxy0r9xkmAyNXO7SJbjB6YfvJdaXQPM3R9//WlmlJ+/2fAwSvi1vpveaQvtnrqwqGvNwi72TqnhOA2gj6mNrASApqZnwLU0hMyOapGGN3SuosH38amuWg69enfZVzslA8ZYpF+kpX5YCCfFt1Zf5pILu/R8hLngPzaJeZlYfiwg1daBkqnMfI86gYolViNKtrBpPkbU+NrH+gXk4C9JZOnN8YutxisnMpXFM4/I3pUMts1DBQYAK6ycQIvrl/KiIC/1j7fJFDmmld6AMPCtkFQ9uUKTn1Ap1m3RoWuyO52T2bgSRF43MCAT+GotMHm1tRxa9Qy64kUYP5ZxARiJkND1ErLh9xkzDrIXZg69HiZp53gjfF07+b3BqmwrAaYaO4HXSEivY79sTp6xeoIsDEEp7JZfkItJ2qWHjyuY6ConXK7omrXB/HAtrwoWiEPU/3gUjxsYY131uffbH2OumbIw5MfYtVjoOI23vONNFbavTWOLj8Yol54447BJSFF27VgZ/em4G4WxUttYaAaCK+PFMrwGg9sbQWUMyamuVjjN1YWNQ8jGXCN6qgkcv7L58wPIqk5G+2gMqZCV8ajdrqtZBjXKBxHbZsmQlEmzEdIV+48m2kRl5duVOzhDoy6RkF/xRlJbpk3UXA/gKwsSAsg/ZSfASPfVcAaeXY9Bi2ulyxpKro0lyOjst+7FZPz4iKtor5PGbTjunc68x4bfvkDj91foCZlZPkQw7bF3wHFNmT4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(31686004)(6506007)(66556008)(66476007)(4326008)(8676002)(31696002)(86362001)(6916009)(38100700002)(36756003)(316002)(83380400001)(186003)(2616005)(26005)(6512007)(478600001)(6486002)(66946007)(8936002)(41300700001)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWhiaXlMQXdqellqdEU4TEZmdE50eTBZN0lZYnVoendrWnpwSk5pVkI2c3Z0?= =?utf-8?B?OGU1bHQ5aUhJVGJISWphS2FXWUZBV3BYZ3k5V3FKdmRtek92KzlITnJDczMx?= =?utf-8?B?OWhzc0kzeFoxTUI2Ukk0RGthektVWFVXQjc3ZExGTE1abE9FZzM0dzNRSENH?= =?utf-8?B?dmFidGlxMWVsZmJzWFJoaHQ2WjFXWWluTStLa3U5OHlpTjZwY3ZyK3ZQNXZG?= =?utf-8?B?R1BkVEsyVlM4Z0Y0ZzI4dEl2dVdDQ2w0bUIwUXdpV0ZYdHJha0liSFc0OUVJ?= =?utf-8?B?cWFPQjRrY3FkMHEwK3N4MEpDL01NUHNFK29YcVBjaG5JUHlBZCttRkNOWnQw?= =?utf-8?B?eVAvcCtnVFhoV3BPVGQvMVp2RHBTbzZDM1VjRkhpT3VOZ2FSeitXWVczWHVM?= =?utf-8?B?Ty9kcGt3eDlJSllQRnl4TW1Pcnd3aFoyWEtIRTZZcXBoblJINE45WElPSmlT?= =?utf-8?B?WTJMZ0NSK3dTSkx4Z0d1dEdmZkt0VzZjQlFxdnkvMGt0SllhRU1Ma3ZjRkg3?= =?utf-8?B?OHRqTy9LOVVaTXVzZ2lyZmVqVkRIUHo1aFR4Q3ZYUkZFeTEyY0dYRmNxSTVq?= =?utf-8?B?eTBVU1plMnhweU5Vb3pvVE9MSGNaMUhCUnlBT0tIb2pBeEx4MVF3YUphT1pC?= =?utf-8?B?bmF0OUZhOUpIYXBlajdoNWtSSjVLY2pLWGhrTzZFeFc5bENqeGovYnpNSk80?= =?utf-8?B?aGFKNG1Jb1dZcXhIV0JXRmtvRUhaQ0N2QXdhalo3bU16LzRmVmN0R1pxZG1F?= =?utf-8?B?QkN2VkFKdHVIYkhocVE5dVpoekRVUlBWRlJGMU15TzFJemJiNVpaYml3dlB3?= =?utf-8?B?bkc5WUZkNlVMdGNiZHl4YjBOQmNwVFZWazB6VlJwU1UweDQybjE0OGhwY0pK?= =?utf-8?B?ZCtydFlQUC9qSnZzK3lGOE92RjFaNlduVk9jUEJqeVMyNnpHL0hNZVU3aHc3?= =?utf-8?B?QTdvVmpCdTV4b2ZNN3lvUVVpb0VGUThXdEdrQnJiQXRMQ1ZoZ0VnbFh6Y3c3?= =?utf-8?B?a1BrRXJHeFNMbTNUZ2ZjNDM1TkFUZVIyYUEvNGNPNUJjYUhaNTljcCtWdGtE?= =?utf-8?B?SVFMay9aMzIwSHZ0dDdNb1ZOVktoUzZ5S1dKMnk3QkdnVlBYbDRPZ3ZwbkJY?= =?utf-8?B?MktqNTk1ZjV1V1g3d0g0L2ZMQXRxRUhRamV3S0lRZFMrTlY0cDRKVFBHa3BZ?= =?utf-8?B?YjA4YVYwcDMvamlZNStaYVgyaDZWTkRiTjJBU1oya0c1TVM4bWpCN0tkUXNZ?= =?utf-8?B?RlkrUE5ZQTNJVWU1eFZOTkNTWVpST2crTW1tRVY3QUpES09nM0diT0FjWkdr?= =?utf-8?B?dFYweE5maVo4RXdZc0loUXFZRmltWmZTZ2JKRXVCWFRBMnBOS1Jpc000VkJC?= =?utf-8?B?MnQ2cmJOdGpjUTZkNER3cEEzWkcvTUpRZmJNajRJNElpcjB0eS9LYllaSktE?= =?utf-8?B?OStPb1pEd2ZXYmtQenh2RjladC9sOXRsUkpWcy9sV0lGeStheCtFeWtYL3pJ?= =?utf-8?B?bWt5S01GaUF1SUdlTjlWcDRnZWxoamFvQlZLbDVna2tDcGQxcmNuL1dLWkln?= =?utf-8?B?SjJzVEUxWnNPQU5jRFhwWk5vUjQ2aDAwT2l3NGRLZ1d4Q1ZoV0pMY3ZFVDZp?= =?utf-8?B?aG9mU1owYmc1N0kvR1hZVTNVZ2xrcnFwenBxVUFwVStSM2tUQ3FqTUpWQlUz?= =?utf-8?B?K2p1Y0RPNE9ZL0xkbXV3aEZsSUFDOG5TdnFRaUpyaU5EZllkYW9HRzBkZkVs?= =?utf-8?B?dmV3aGxDMXRKSVBFRFhOSklVMWZya1VqOHM5VzIxbmRwWUNRYlFwQ2xRN2xC?= =?utf-8?B?TmZ1VlZyWEdnL01KMFZ5SW9SUXhQTFRKOWVFeVJnZnZkejhmcjVrY2YyZjU2?= =?utf-8?B?TTlHWXdkQysydjhQWDFDQU9tZW12djN3UXhwTDJzc2FxOE53bHlMWFhQa0Jh?= =?utf-8?B?Wkw0dUlrUS9aaXFjd2plNlp1Vk96Ujl5cVY2bEEzZFpBWHZzVk9xcW1DdHBR?= =?utf-8?B?enNwbUR0RHdoek44cWlVNUVSVnRTaC8rR0pmSlpkY1EyODZ5ZzNiYlhiMXBm?= =?utf-8?B?aXJSQ0czcTE3K0NGVzdQQW0yblh3bS9QbEtscHVmRmlnMHJrRjIrdVl3YTNC?= =?utf-8?Q?Ju0visi1BvYhyNjpWxvIK8tNj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: db58ce86-f134-4ec7-79d7-08daa2020d18 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:04:52.0782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: irCVrSR3xPrtNt/xfe0IB1vGKp3GmcGQK3PlnpbJAo49sA/z2RvVoHNLrxanhdQKcZhx+K2xT8XGaw7kBTOSIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7934 While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves. For the new use of cc-option to work we cannot pass -S to the compiler anymore. We need the compiler to actually invoke the assembler, so switch to using -c. Signed-off-by: Jan Beulich --- a/build/common.mk +++ b/build/common.mk @@ -15,9 +15,11 @@ $(foreach env,$(HVM_ENVIRONMENTS),$(eval $(foreach env,$(32BIT_ENVIRONMENTS),$(eval $(env)_arch := x86_32)) $(foreach env,$(64BIT_ENVIRONMENTS),$(eval $(env)_arch := x86_64)) +comma := , + COMMON_FLAGS := -pipe -I$(ROOT)/include -I$(ROOT)/arch/x86/include -MMD -MP -cc-option = $(shell if [ -z "`echo 'int p=1;' | $(CC) $(1) -S -o /dev/null -x c - 2>&1`" ]; \ +cc-option = $(shell if [ -z "`echo 'int p=1;' | $(CC) $(1) -c -o /dev/null -x c - 2>&1`" ]; \ then echo y; else echo n; fi) ld-option = $(shell if $(LD) -v $(1) >/dev/null 2>&1; then echo y; else echo n; fi) @@ -25,11 +27,15 @@ ld-option = $(shell if $(LD) -v $(1) >/d # Disable PIE, but need to check if compiler supports it COMMON_CFLAGS-$(call cc-option,-no-pie) += -no-pie +# Arrange for assembly files to have a proper .note.GNU-stack section added, +# to silence warnings otherwise issued by GNU ld 2.39 and newer. +COMMON_AFLAGS-$(call cc-option,-Wa$(comma)--noexecstack) += -Wa,--noexecstack + # Suppress warnings about LOAD segments with RWX permissions, as what we build # aren't normal user-mode executables. LDFLAGS-$(call ld-option,--warn-rwx-segments) := --no-warn-rwx-segments -COMMON_AFLAGS := $(COMMON_FLAGS) -D__ASSEMBLY__ +COMMON_AFLAGS := $(COMMON_FLAGS) -D__ASSEMBLY__ $(COMMON_AFLAGS-y) COMMON_CFLAGS := $(COMMON_FLAGS) $(COMMON_CFLAGS-y) COMMON_CFLAGS += -Wall -Wextra -Werror -std=gnu99 -Wstrict-prototypes -O3 -g COMMON_CFLAGS += -fno-common -fno-asynchronous-unwind-tables -fno-strict-aliasing From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:07:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413595.657334 (Exim 4.92) (envelope-from ) id 1odqRy-0000xX-8R; Thu, 29 Sep 2022 10:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413595.657334; Thu, 29 Sep 2022 10:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqRy-0000xQ-5l; Thu, 29 Sep 2022 10:07:26 +0000 Received: by outflank-mailman (input) for mailman id 413595; Thu, 29 Sep 2022 10:07:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqRw-0000xG-VY for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:07:24 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f3e0c6a-3fde-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 12:07:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7080.eurprd04.prod.outlook.com (2603:10a6:20b:11b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 10:07:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:07:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f3e0c6a-3fde-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgWPxgD7KXszi3hdLbXy6NqibUB7qgpn6NbfCLY5ranUgmD4PDdxqspP10iae0IYTlmuo6kTsyY05I9GT8XwHwoOPNTsk+aPqzX+HETk14VLWtzILTbz1mnzvBz6LW8NXdoaCHUEKsEkYYxlpDFC+GgQQbL32rwsD8i95psnx1oSIOyMucyqisSRk9S1SyK3UYAxDBWFyjdXQmnsoSpp2EVAXdUxLp2XZ+n3NMW4IX9g1SIT57Nrd1apdWxrcC9RncLyXpAlsBQIccFZfwaD1orOwf1CqUIUYyMkUWaiKOYOQ0XiEG2EF6/BTsFwGlQlrKm5HwZXn1Cz2CQShpVKuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TVb9/T5Csgw7sBGxek7HE/E32HbXBuBKpU1/gKEShl0=; b=nD/iSZGDo955uRatswfnRDrKaMINS71LrdzIDwInbV+X6xe7p0yYRvUpncGIzIK+EVBy3pDiFYo0k+U7bvDgH/sXT8pb9ZktdpQ2pjBE9aLIk7Kcct33nwynjLqZs61jZl0dz1/uql3bE0zva1HS2GzSt2XdKn1lo0bS5/Sl0o59AipGAPtFMfUA1yiFoUjsjSpTu0ioufsfx1iqQ/p+JvKbNO27zem1EOvjoD4fFJQEkmastH+fyuy+/5fJNX6crnpYHP9/SRwN84BIOXjDckd85+KOsI7UPgxp3cESo+iJ58nrRRLi3eRLgYkr7MQCa5gjr0hPwlZIhTkV0gsx1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TVb9/T5Csgw7sBGxek7HE/E32HbXBuBKpU1/gKEShl0=; b=pmA+kXSOboVAIX1iao9V+v2ufHP0Ln/whHgSTIefOed81icuQGMc6R3qK70oX1iSZwz5iNFYfOIGyxbOPqN46QdUuSzdzgnxqfVPWzIREBK+FlFo/RBI7IN7YAyojwZztxH14kHVX5rPzDGfWCSES2PgHCSXrUCoXdEm5rz1KAOuWVHTiG0M+iC02yCMceJIAGkoxg4hrY6lSi+0bKWpECC6TLBt4iQJlD+sZ46bZ08ymQ52aXYl0C0k6STFeTvfTqg8tfVydOT6SjyEkHBTnTkZyz7QshfGxwTxer3yilNaAGUOBl6ywaiCW9p4LrsNrTxRzmpNKN4EpJ8M27kIUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <77d1bd6f-fce6-bcd2-96f1-a672aedaa7f6@suse.com> Date: Thu, 29 Sep 2022 12:07:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Wei Liu , Julien Grall , Henry Wang , Xen-devel References: <20220927154708.15787-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220927154708.15787-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7080:EE_ X-MS-Office365-Filtering-Correlation-Id: 30e3ca3b-3e97-4c50-afd1-08daa2026618 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FXAmflrenJQJ8DSF35Caip9F4OI9c1E/0VdzC3F1VyacNSZB8iRSv1XvQ6yIbDiy28H/XyFEdKpAjqzvjeOZ0HHzJ0N0FFNXSKjwji1qjofzV30cTb73ejtC6X9VY0echOp5OBXEzq079EJ4fdl7RrBmN/sDSLOxClUDuS3wOByv5Xz7pvBQSfy/8JoICHX5PouiBUwYeOgMdZiUe5R6X2+m0flemPB4dYsrQlfBIBMuoQ3f9Qm8wjZ05LwXxg6MvHaM0VG+dc/KizpKQMsSBMT0plmh6yvrD15rSrQb4Q8D2QFA1+REhSr2J4GSyO4tS/7LZ6IyUA973qcgDFhhwU8ShaMLH4M/E6NwDgf6/PH6Gtj79fsPJ9kifRExQVzVZdB1qCF03wFD0a9CcOR93cFwdlrpJOrbfOSKflvt7aD5eZBithjsW3BhBx1FQYCF4EJ0Mt2wThV9dJVvoJ1AEj5nF1ULMyTc2AxLEeW3jU/nOLLx6nfEaoXbZpzs62ZA0zXt+pCOMII207YD99B/YK9jsdPpa91Nwgqx8wCcWfAwL7zvpoNoV3akKA3bPlzLrr1JyMFgLobOy4ZBQN4q4anCSm00L1ADNm2qWG16XCc2e9FgoYnz2xIaH8quGHVHZwk4Feg5ANiAsjmLoL3zExxD0am1BkPGM+Xs2crKFBF/pgfhWNj7S7bmZ1VgMISay+dWDS33OhSR912gzaU/Rtqcknux/Z1JSBEHWfI3cyHDRiGGoeSxn77kxdiGYe/T5ZeEdBS3mCDgwwAw/D5mFnG7qYn3I5yX5h6PkmQWIvY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39850400004)(136003)(376002)(346002)(451199015)(8676002)(4326008)(66946007)(6486002)(66556008)(54906003)(83380400001)(66476007)(6916009)(316002)(86362001)(31696002)(478600001)(36756003)(6506007)(38100700002)(5660300002)(4744005)(26005)(8936002)(2906002)(186003)(2616005)(6512007)(41300700001)(53546011)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OExVNUh4MXRhWjZrVEVrRW9TRWExTG9PUnU4K1hOK0pXRkdzWE4rSGFjYTVK?= =?utf-8?B?N3VEZUJHa2d3MksxWlQ5eUtwck9wN2lsNmJXYWdSeGZ6eWl2M1pGSmFXZGc1?= =?utf-8?B?Y0ZGSVQ4R3Y0djFtQWpPN0Njb1Nsc2NDSlF1b1FiSzBRYng4dGJHTTdjVUhX?= =?utf-8?B?Z2gxWmZVN3NMMzVGdDJIaC9Mbzh3SEtBVGpJNER3NEFKU1BOVFhlUnFFaFRl?= =?utf-8?B?UXRkSEdvaU9KVytlRUFSMCtqUnhtbUVDOHd2T1RNQTFvcWo5OUNaM1lQQ2di?= =?utf-8?B?WTBaNis4bUhuMU9MaUw4Y1dhWWNvOVd5a3JvcTZUZzJyV2ZoOUhFNENvYzMz?= =?utf-8?B?RmlKajlHNGxiT0dCZ0lwNzhVd0NFS096bVNKWUxNOExhOUN4bGk2elpZWnM5?= =?utf-8?B?MkFLS3A1UmtLMHozYm94Z1M4OGlqRXJocjg3L1BFSTFpSXN4L01YRUJLQXYz?= =?utf-8?B?S0hvWkZRY1c3cVd2eExmdWljeGdDamwvaDJpSm9JdzFFbTd4bEpXQzFTRWEz?= =?utf-8?B?czRLUFRxZkN2RGhmaFkybFN5bUNzc3FOS2JVc012VzBnYVEvVitWQjhZOEV3?= =?utf-8?B?V2NPeWZydkFoRTZtekZaTnJXRlN1Q3NEaUhFbE1maGwyR2o5QXpEVHdnc2tu?= =?utf-8?B?Lzg0K1hZdnBvdFdQRHFVckdvZytLTCtLMG9TaDl6QVFQUVhURjBCNUREUC91?= =?utf-8?B?ejl5amJ1Uk1Rc0RxSlRMUTM5T3ZSTVhYdDdsV0xTQ2VrK3RnU1JENnRXSVQw?= =?utf-8?B?OVVkUDdIMmIwd2pOYXlaSDFYancybDhkTGJEbTZFNjN0OGdJTUQ5TDNVanZs?= =?utf-8?B?ME5sVHNVelJ3VEI0MVYvczgxTC9LNjJOL1pZYUdobEIreXgwRGZnRVRvQW16?= =?utf-8?B?RHBFRUp2TzFPR2VnNkJFVTZGNDluUUpNOUdNM0lrU1JTdFlXN3ZBZFFrMGZt?= =?utf-8?B?K2ozSm9ueFpzR25FeUlWbkVQdC85QU1vUXVXTXUvZ2VOdkEwcTYzUm5mdnNq?= =?utf-8?B?OEYrK2pMRjhFSWxqQzFGYUU0ZEM1OE9Kc1pBc1FHUW5xVkV5d0dacXVOVHNJ?= =?utf-8?B?ZFdpa0FveU9wSk1zT0lxWi9lZVo0dEpQT29HaW1ZeWtGQWlGTXFGZHlwZ0tv?= =?utf-8?B?RFZ4ZjJUdUFrdm9XcVVoUWxIc2duQkVnWUFZRzJ3RGZvYkdWNzdjZ2ZiVkFQ?= =?utf-8?B?Qnlsa0dDMTFiNlRWMVpqb0RsNXVaVzZERFFzWWN2UmVyN0l2aGpQT2F6bjhV?= =?utf-8?B?ejl2VlJLRWVrck9qQXE3ZGo0SnNudk9OOW1jQTZJOGFvQkh0dW1BMnpWenlu?= =?utf-8?B?TklrMFp5ajZoTllXdlBIS3lzWTNaWi9jVmtwYktzbWt5RWZUUXRXdGh4UG9Y?= =?utf-8?B?SFdRcCtiTmRGNmtsR1VzRkpzS2N6eUIrQTdyR1lSd1Nja0pDbTlKRXFNZlRY?= =?utf-8?B?b1NQNVVwRU5VMGlXUWNlRHQyY0xPUTdMRytnNHc0UC9OKzI1bVgxZjg0a2ww?= =?utf-8?B?aDhQZkJVZit0NWMwSkF5Qm5WU3BiSWpaajIrMkczc1B3ck5BWWVEMGdBZ3g5?= =?utf-8?B?VFJzQ0ljR0hyMlE4RExaQzNYUmFFSmV3WXd0eVJXWktiTlVwa0ViYlZSUS92?= =?utf-8?B?c0dXYWpnL3BDeSttTnRwZDBxNXhxaEtHZGxTMGxJeUFVRVhoKzFITUt2YTYz?= =?utf-8?B?bWRXYWYzMzRHbkRXeTY5V3dmekhkMGhxOEdpWVd3MmdOR1NrUUdPM1FJR3RH?= =?utf-8?B?ZUNFVWxQd3M5WENLdm9peTFlZEtWU05jZy9kMDY4WVBnUFNreXdnMVF4YVZT?= =?utf-8?B?eGJCSCt3QWZBc2F0ZFVUc0lBSlVDYlFOYnQrR05mT2REanRTR2pZVm1uMkVp?= =?utf-8?B?d0F4VS93QWtWcTJxSnhTTlE2WXZHSDhVRDAyZ1phVTFPejV3WmpNc3B2OFRh?= =?utf-8?B?ei90R2lOSjJLRlB4MG9QZzJSOHAwL09VeTA5T29vN0VWUU83VDNCd0VzdFAr?= =?utf-8?B?dVl0cnpjdGtJampjSlVHVHh0U01PNWllMG9ERExrRkFLQXdtVG40TWJ4bW5E?= =?utf-8?B?ajNrcENVMW5XRlphOVhMK2F2UG1OMEdKVlNwQTQxQmdaTURjODhzdXhjOWxD?= =?utf-8?Q?oIlJ0+G3tcoDsUBSYNMdXCwjV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30e3ca3b-3e97-4c50-afd1-08daa2026618 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:07:21.4905 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a2Y31Oj9Wo4DnOyscCbCGQN7OEyCd03TJOAnnjL2M4njh+EgqohyoLEbTTyxCZJtB5/KXJNOyeo21JqBVBLNXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7080 On 27.09.2022 17:47, Andrew Cooper wrote: > This breaks all Clang builds, as demostrated by Gitlab CI. > > Contrary to the description in ecd6b9759919, -no-pie is not even an option > passed to the linker. GCC's actual behaviour is to inhibit the passing of > -pie to the linker, as well as selecting different cr0 artefacts to be linked. > > EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to > gain such a usecase. Since it was largely unavoidable for me to notice this while putting together the two XTF patches just sent - isn't the current way of using -no-pie there bogus then as well? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:13:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:13:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413600.657344 (Exim 4.92) (envelope-from ) id 1odqXU-0002Ne-S4; Thu, 29 Sep 2022 10:13:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413600.657344; Thu, 29 Sep 2022 10:13:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqXU-0002NX-PJ; Thu, 29 Sep 2022 10:13:08 +0000 Received: by outflank-mailman (input) for mailman id 413600; Thu, 29 Sep 2022 10:13:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqXS-0002NR-WD for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:13:07 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2054.outbound.protection.outlook.com [40.107.249.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a5187f1-3fdf-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 12:12:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7895.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:13:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:13:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a5187f1-3fdf-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SnpLKKgB7opppae7lPf1b3VhYqZKhWxG1tvB13HPVe7QUYBEP4tncH5PID4fRCP470N/O4hK1jqx7h86ZaQCkZ8Z9TQQk2ENX4r32RRelIa52XVAbq6CGBuKbgLXYjw75QOMpHsJloPjNclAEMRPimasr8GSq83vMC44B6Kxs6UVmRZzOvL7qB+SPzqfg3AOleJJ4iPgT03GV3M2UmJXVq9FrMTluj4VKOyHgTHl3bcVuoiXWMhmhmBzHVDIABqYRQA2oPsoguWPbJcLWD72SVRs9W3e2Htzrdm7G0DaxB6ACm7aJaDsCRK7D2+p8H+WRsUe71Z8oBXiAfOx6XyWAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJZngrMWEoKajva0wgPHwnrMgCW/c9vOJB5xxRh7SaE=; b=QUG9mrR6GnBfSaaBJClkAvOUAtwjeEw8xqEBlJ2O8043yPVfr2P2ZyrguZgioXBS7iaKF1mgAK0Os/RpWwKOB/2SoF+JDy1VnBl8TkdteiopQV4ETV0C5tn4h9lhLNCnDLGl/zSem+J7qApdiFaI7Q4V0nDQN+r5aX2vFDpjDEC83EIo1Bwj53OxWjwIkubRZmEh9nsKkYlIvSeQD7SKjTlcfl4FWHw9UozXK4LiL0evHphmDEd3MerWwIb3Hy+wVqVPE/mV8c4/Oeey4G9Px0b48dkqLIyksKrHhNCogEkv8zNnd960XPEhcZRD+1Seq3D0DiL+FbiOv8MXnlbk9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJZngrMWEoKajva0wgPHwnrMgCW/c9vOJB5xxRh7SaE=; b=y4PF+/zv4Wul8bjUirYKYQlYE2ajtBV1Ty12eGjUU3ZvSJCxgrHaWllXB8UfRoym8b7hVQ5+f7/B+nVIU0YoL2Bv+WM4SXRn3gTdFdd7uF03bBMuMRSSxwMNuoWAALZTFnW1MeuRoqxFwp+LHY8M49qvCU+FzNmyQDUdJda0NWECO5YJS4+Mhg+0dfjew8dGBj4pSvuDz2335VDapzODv+yJzk4wtLoHu+NpSb+xzLtxrWzyAg21EW7Q03FOeKu+IBqIk0K9jgs1D43fLePqfzoemx4HW+jjT10IgwdBukuNpCDkQpIGBrszcs33YpnDqli8W5AXRZXFoPRnipjNcw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <576b8ac4-7ebe-e8eb-2fb8-2cb7f592d585@suse.com> Date: Thu, 29 Sep 2022 12:13:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 2/2] x86/ept: limit calls to memory_type_changed() Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org, Bertrand Marquis References: <20220928141117.51351-1-roger.pau@citrix.com> <20220928141117.51351-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220928141117.51351-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7895:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e1c1201-7052-4d31-7603-08daa2033134 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P5eDTYX9FqhzQZveq3kX2I7nxXziQYn13lH4hvEREJXfhQ0VBVs1lbn3Q+m1w/g4PYNOLekVo5iHmtLgNIUy8JzPaYiQU2/orSebfLKkHeVbJqUjRbxb0Zu3EX8S6isU+onD1vGr+wbZrGDpz8mmPWC4Myu+y3r3xxwr7+mLidRTmGlG8Swt6B4vgbNuG6ZkBFKO0wP2BkhUjP5oyA76Sk9bm9znXTchNwR8kohM07rNtFrF9/mUQX7+G7ezKpd6oejxbVAaWHyktjs9hZ1NRMAD4qsA9mxyff9R+4kdcigTBxsjff2y/neMv223k2RktSf85WKdwbwMOMS32d9+Hl+RblhQavlqS0lKbBYGXv+f3egITt1stywnw9uQQ14WEghC0OnhFkrrS993WgkpTyV4zA+kjCEhnRSKwupRvolQGefxIv+tVBTr6PFZ0xsVkTOYuxjsK6JhY0W2d+Sw0c9FHKAqKltcl+tDq2f+Ke7sx02wzG+R4wAiFPb1KuxGrLlJMT8M11b+pfHGFJRC0Lm84oZwKF2XwZoii4acmhzEDl41fzEilVmQFy8d2lveIx84vEq2LSoc/JUuR+VFglkjymfWorkK80N3qRH+W4leEe/sYtkoGppOgqR/zeHa3EOgqPmXjOyLEwDDH8Idr243UP6XvPSiUGBlgJpz4K9mRXepPCQlFYtpxksEC94BvqWW8R5h5gSsSnYb/RTIiT4aX1mm93X8WqC8T8sB6QdUXnHdubUorZro9TipQzsfdgB4JlZTdCnDfjGeG2jiNmoV76eAtu4v1pJ+W5jjTIE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(136003)(346002)(366004)(451199015)(2616005)(186003)(2906002)(83380400001)(38100700002)(86362001)(31696002)(36756003)(31686004)(66556008)(66476007)(66946007)(316002)(6486002)(54906003)(478600001)(6916009)(41300700001)(6506007)(6512007)(26005)(7416002)(53546011)(5660300002)(8936002)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NE1KdVh6UTM5ZENXVGNwVmFJMHhWb2dKSUw1R2NBclZYTEwvQWZWQ0pkdDhu?= =?utf-8?B?ZmdiZkR6bktUN25ReHhRbGJreHRuaVRSK2txTk52U1NvWDB0VlNsWnJhWUVr?= =?utf-8?B?N25HM0F1REc0czVpOFRMelp4eVhRMFlCSUtpaVNRUmRPQWNwbVRNTzFYZEF0?= =?utf-8?B?NHJrZTk4UVZXTjZEaDA3dFJUdTNrYmZLMzljVjV0LzFGUm44blE3clRVSmVx?= =?utf-8?B?RnZVbGYyTDRWQ254TU92bEtiQis0RFptM1V4akhNYm10b2syd1hrREZoMWRy?= =?utf-8?B?a011ckcvTHdzTGp1bXY3VDNFZjVrVW9KR1hVaDFnQUhIWlpqeFpubkJnQUJR?= =?utf-8?B?L2thYi82VzdvTysrUzJRY1pxcUtIY1BlS3FiOFJHajJubVN6TTgydU9iRHVz?= =?utf-8?B?U0lZK2xudFVKMFRuNWlvV0NOUTFZVzlEeEtCdlduNnowRlZTeVg2Q0FrT0RL?= =?utf-8?B?S251RlE3azFuaWZ4RUZ1ZTlBTFB6Z0ZwUTQ2QTVLN3NsSXlqKzlJQ0Q0U0xi?= =?utf-8?B?bFIvTk9QVFRheTh4NlJUOWVBSW9rMk5MK0t0MlpKSklFWU5TVkNRSWk2M2Rv?= =?utf-8?B?ZHZhOGt2S0xaMmtVT3hSOGRaZGZKTnpwdnowZVB4blNzOHFJaVZ0QTNBT2lM?= =?utf-8?B?WDM5NGl3eUpnYk1RM1dGTFRvSUE4dWFCSUhzTkxhUW1DR1ZHTUFhQWY4OUEz?= =?utf-8?B?OFpDTVRDLzVhK2xmNmpDdVNlcWpkYjA3UlhCY1EvNkxnZHJUUkFkTUE0NW1i?= =?utf-8?B?YXUyS1piNHkzeG5VOXZlTmxlQkNyK0lPN1B0UkRJVWpFM2YvVlZOZURja2V3?= =?utf-8?B?L1lKUklPN3Q0ZkxnNUdqWWc1N0xJY0d5Q2JWaDVGVFhPc2hIamtvcDFCVnZO?= =?utf-8?B?RzdOS1VGRisvdXRvR0Z6aHJlcXpVNzZCYnNFbjlOSnpQTzI0UkxGMjNJcmFR?= =?utf-8?B?ejR3OGF1NzJIZVZtSWZkZHNUUXk5QlpEZjNSdGd6SDZvWC9IKzQreTMybzNq?= =?utf-8?B?ZnRDOGRtTUZmZUZ3VGgvejVMUExiS3ZtOUFsZytQV3JubWNaZDM2MnpoNHhL?= =?utf-8?B?ZmRxR1ZlUmpZMHFqSXc2cjRiL04zSHNYV3BCZUtDVmk5cXo0d0E5cFA3VHlG?= =?utf-8?B?em9KcXB0T1JUT0pTODJITnJRbVdTTTNiK1BFSitCRFd3RXNFY0cwYU96Rk1h?= =?utf-8?B?SWYwd2RoYUF4dCtzdytUTC9qdTl3SkU0VnIzbHJnbDZIbXdZaXRqUDU4WVp6?= =?utf-8?B?SnAwMGFpNnNDNlJpQVoxSVF3WTlUZWhMRGFRV3dSTFRMd01HbUFkbGI0Ly8v?= =?utf-8?B?ZllhWmJEdVQ4RnBwZEE4c0pCNlQxTW10bHUyRUpHZXR1OEF2SkI4WFEveFF6?= =?utf-8?B?K0wvZ0tvVFQ1c0ZZMWlhN3gyOTcrdExhckdGQUgzQ1dQUW04RlJxK0VocitF?= =?utf-8?B?M0NUeW9wN0QvRVYwQzNNbldkazNVQ05XU28rMmJoZW5OZGY2UzE2QkN0ODdV?= =?utf-8?B?Q1RQeU9QRUJhei9oaUFvOFE1NkU3OTkxbW1pR2l1alF5YWxFSW1NUU9XMXE4?= =?utf-8?B?NjRod0FKOG1SRllhWGg4bmVwU0I2Z1ppWjc1cEtUczc0MWRXZCszczhSckZp?= =?utf-8?B?eE90RWZpV2tySTJKWFp1dTZlTC9NMjJYeU9Rak5ja3B3ZUVHV1JidEFXL3Ri?= =?utf-8?B?SEljSGVkb1pHZ0xLZXBucjNCT3JzeWgyc2gyaEJvaVA0OExIeXhCV1MwY1RJ?= =?utf-8?B?MlBMRlRJZE1GVGJleThaQTBNb0dNajN6SXF1RUpNdjdLZGltTGFUL3V4SGVt?= =?utf-8?B?VUhJVTlrVHBXRFlvY2cwUFJvbGNRbTQxUGNPWEJQVWtPTFJDRkxBTXR6angv?= =?utf-8?B?RW55RDJySWxuTTdLaVFZdzRYNWdSbktjWmdQSC9TSTlEQnZNeDhOazMxNWVx?= =?utf-8?B?TVlWQ0c4UEY1YlgyaGk1S2o0M1VXaER0OTZPME5PV1BsMXcxdHN4VFBRVlNO?= =?utf-8?B?YkcyUHJ5U1p4WUorR0FaM3BhNy91NHUza1NuQTlKOXlkZW1qLzNISW5IdG5i?= =?utf-8?B?MW5vVW9MWU05d3N2Y0ovVFFadkhPNi9MZUtlUkxPWWhGZFhiVGhVRW12Yi9s?= =?utf-8?Q?Rz79ld5yTp8LxVkQnDL3rJIKu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1c1201-7052-4d31-7603-08daa2033134 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:13:02.1563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 06hVF4Xe+Vuq0bgEDUFfuQPjg17N6UWQuGEYUtjWBUTBfQiTovgXc42Jujs9lK84A9WhgBDcINlJiDUGNv8teQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7895 On 28.09.2022 16:11, Roger Pau Monne wrote: > memory_type_changed() is currently only implemented for Intel EPT, and > results in the invalidation of EMT attributes on all the entries in > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > when the guest tries to access any gfns for the first time, which > results in the recalculation of the EMT for the accessed page. The > vmexit and the recalculations are expensive, and as such should be > avoided when possible. > > Remove the call to memory_type_changed() from > XEN_DOMCTL_memory_mapping: there are no modifications of the > iomem_caps ranges anymore that could alter the return of > cache_flush_permitted() from that domctl. > > Encapsulate calls to memory_type_changed() resulting from changes to > the domain iomem_caps or ioport_caps ranges in the helpers themselves > (io{ports,mem}_{permit,deny}_access()), and add a note in > epte_get_entry_emt() to remind that changes to the logic there likely > need to be propagaed to the IO capabilities helpers. > > Note changes to the IO ports or memory ranges are not very common > during guest runtime, but Citrix Hypervisor has an use case for them > related to device passthrough. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich with one minor remark at the end, which can be taken care of while committing. > --- > Changes since v2: > - Split the Arm side changes into a pre-patch. Despite this I'd prefer to have an Arm maintainer view on this as well. As previously pointed out the resulting code is going to be sub-optimal there. > --- a/xen/include/xen/iocap.h > +++ b/xen/include/xen/iocap.h > @@ -7,13 +7,43 @@ > #ifndef __XEN_IOCAP_H__ > #define __XEN_IOCAP_H__ > > +#include > #include > #include > +#include > + > +static inline int iomem_permit_access(struct domain *d, unsigned long s, > + unsigned long e) > +{ > + bool flush = cache_flush_permitted(d); > + int ret = rangeset_add_range(d->iomem_caps, s, e); > + > + if ( !ret && !is_iommu_enabled(d) && !flush ) > + /* > + * Only flush if the range(s) are empty before this addition and > + * IOMMU is not enabled for the domain, otherwise it makes no > + * difference for effective cache attribute calculation purposes. > + */ > + memory_type_changed(d); > + > + return ret; > +} > +static inline int iomem_deny_access(struct domain *d, unsigned long s, A blank line would be nice between these two (and similarly for the x86-only pair). Omitting such blank lines is imo advisable only for trivial inline functions. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:14:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:14:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413607.657356 (Exim 4.92) (envelope-from ) id 1odqYb-0002y8-Az; Thu, 29 Sep 2022 10:14:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413607.657356; Thu, 29 Sep 2022 10:14:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqYb-0002y1-82; Thu, 29 Sep 2022 10:14:17 +0000 Received: by outflank-mailman (input) for mailman id 413607; Thu, 29 Sep 2022 10:14:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqYZ-0002xj-C5 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:14:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77a4c1e4-3fdf-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 12:14:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7895.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:14:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:14:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77a4c1e4-3fdf-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HUtNBzFtINmLDs9tDVFQ77g4tROKK5GEhHAHVINGd46ZX/NF+XFp0xlYRrxs+So8h2eLB1GuLwfwrz6wfUR22/LV1aZAcE4F6KULc+qORseaVzp8PX9gqsvYgtxwpgaMUXXuFWc2X6MfJCOCFSDw7qJmLKCMqgn7Qwo3W+IwQdOnyRmz8vHoSSoEGo/Yy4rHqawZgNiXza6okniPRV4/wyc743LGMsTcLxAP2oF7KalY8kW6I9Lbyg1kH+454XTzB2WaCtww2hXW1lSb5DEaQe71urCHS1wtS4qqXVK5SImoSVrmJO7ZaOMWKBuQTHnQQAeb2kb7DxhbeGOlyb9w7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u5byEB4klimubibUmKd4ySR5qKSA6zBTcFHhQJgghXc=; b=HLnYGKP6YnhUddHidxrgxh4iHlk/exEZhhsjr+w4UM7u7PtID175TvNBeBHheARnKRDmCjaOIOVijjYRJxeAgvbkpOXRNuXH70CJAnrTperEeLHktBY5jdkbj2SUqyom0iLdhpuQiWZD8jvt3bnAkulBx+Iwr0ZbcAlI7eQkD7ZhY/e/+qGsgyOb8ySLi78r5vH3yeRX6XR6JC3hdKRVG+T8WUGCgsa2HQGRmirYSjqBGfaIJb8tKKvG+LSYtO31w5DxEw0O1oH/UGkDbepZUdVGwhf+4YKvtD+PirPWWDNDIHxZVFqv4E/5vRG2qQR/tSSKK82903kgM+o4SeeUfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5byEB4klimubibUmKd4ySR5qKSA6zBTcFHhQJgghXc=; b=SI01AiB3nOIp1YRUf1oTXi3CVN4g6t9kYX4aJtBieWN1EqWRCkq+yLNOCx2PKuPlft6BcFronifQRdVhX8SdM0xjQ8XIX6LwriPFtjA/y+JjHcZ4ziI1dcUvSWQjFNGRGlFueaPsYv2ID/ppB3rx43UPXCyHHnBoIkUGH90InMtk7uY3CmQ+A+BlnvJnswlHdHPgkSMBuzwWVdn9jR9fWFAT4TA0jZGkPoq7BGHS0SBBCcrKg3OTjJgOYVHrzzvwDF/avPD1dY/N8X5+mnC2T0wtLxlQrL09Nc/09S7zCpmejA2Q19McD4rqDJl46JE9nDPyCvrijUbKNX3upChcpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 12:14:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 0/2] Move calls to memory_type_changed() Content-Language: en-US To: Roger Pau Monne Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Wei Liu , George Dunlap , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20220928141117.51351-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220928141117.51351-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7895:EE_ X-MS-Office365-Filtering-Correlation-Id: db3fb867-8811-4045-c686-08daa2035b04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4neij07Aaw3z2XSkwRUN0CTug8i9xh0lh1VJNKksxStJcMjehExWEHDPMr5PMYYSNuY4QezsvwbSAQNvkKRwk448lAwP5B3oX+JI1iZzezxjkHKId3W8zEbpwz/EtikgXmQ/hcqyxqekpPHfVNsInAdRd/g+kpwWnq40hwZUIDr729tGbZiIsLda7Tf1TLQ7iCNl5ynQWl5u6yebsZoEwvrVQigv5w1qq2olLTu/n7D69y4CObGiJEQWhrsP5gfbv/7U93p+gK/FfTIKMZtzqw5BRxXNVctEupMSZZx31wtP6uhVVlHfNBoLL0k6cJ1e0GiaqIsvktKSRNzq9jkM3kTuKIKLeyIbUsYU/NDJyQOYp4hHrqpPMAkn+DEawD+ZfEDrTRhxB8rhYXp/9IG4nrWFyUd/W5s0Qduwt5y46Loycvj3tGPUbRQjKHXuv+KR7aSvumICSxPuXidwVD7aJg1t5fw4vvsQ4vxH8uzKKAMnb57WuQYeoFt9DLbCgwvKysNzBqq504/s6ACyGtVF6XRJL9ovFAHY3cDp19seVxupIz2PAiVcBRhe2393aaUtsWgsx5g5HvzMXfLe5cZ/oQUj1ZHvoL3Qz3iZ1jPbHOkDE04bti4oMR0ZDxX3OObutZBDiImrfAq8Ue7ilPWa2WfFve5oM2Z4VTIcBoQaSMwzcjDhFQqvHOHrcMqixwIb7eoSjGu2QXgpx9/szWLtiVdcxk+PVcBzXwSijLrcB5uuCyRzca5nkQTLDrcKq6oM21qJ8KHaA/9m4OQ9XvMiIZJdsk2ZvyqRIGqwZXG1ebA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(136003)(346002)(366004)(451199015)(2616005)(186003)(2906002)(83380400001)(38100700002)(86362001)(31696002)(36756003)(31686004)(66556008)(66476007)(66946007)(316002)(6486002)(54906003)(478600001)(6916009)(41300700001)(6506007)(6512007)(4744005)(26005)(7416002)(53546011)(5660300002)(8936002)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFpyUm9hUGFQMld2QzZ3b1ZLNllVRjRBZE5oa3hUcUgvbHFMaExFMThZR0ph?= =?utf-8?B?NW9EbDVaNFk2c0Jsb1REVUFNaXJTSUtsVXRXR2h6LzhjVytEUEk4dUEzc2o4?= =?utf-8?B?a1kxNS9semw4cysya0N2dFphQStTWjgzd1lOYXVvU0M1SVlIanFnWjdwWDdF?= =?utf-8?B?YVczOGRTNWwvVzFiOFV6QjBQckZXWHQxRmhLMUJQWU8yQTcwSlgwV3lkbEtW?= =?utf-8?B?Ny8yVjNZUWNEbXNYRGw2b1Z2RW92NlBMRGE3QTJYWnMwY0xOaWhqeVlrRU5Q?= =?utf-8?B?RUlQTWIvL3BQcGJOMXlQTFQwSXdLbTZ2WWdJUm5za3FpT1lLcFhjUXBGU1VT?= =?utf-8?B?QzVON280OUpWSzd6aE5jR2UrZmhHZ2t2NXdFMU5DZDU3enpkRnUrc1lTWlFr?= =?utf-8?B?WDhucE9ibHdJR3F2NGQ0bFlOYnY2ZHpvclB2Z0l4QUVGOGc1WVc4Q2JkRzBJ?= =?utf-8?B?M1lGcEVJYWwybUZCMUw2RkxiR3BvLzVOY3JqRDI1YWZUbDJ5UGtPU0lxMHJ3?= =?utf-8?B?TjJaK21MZ1VvU3RwMmhMUlI0dnJRQUJJYytEdG5sb0V4UWlENFZ4bkEvOGZ1?= =?utf-8?B?TzdsUmcySityd0lCamhzL3FvQVhtaUtTYXlOSkE2TTdyNXBwVUFEOFVXUS9t?= =?utf-8?B?OWx1QUV5bGFiQllmS1hIVDJiTUx3R1o3VU1Fc0J4VGlSMG1vMjdxSFdqLzdR?= =?utf-8?B?K1NNdHliNEZpOGVaV1loaGUrUFpjWHJJMW1HN1hvdFdLUnNQR2VYbXFRdndU?= =?utf-8?B?d2Y0V3VvTEF0V2c2alZtM2d1b0xMOTErUWY0N0xaeFR4ZTllMy9zZEJOTk1o?= =?utf-8?B?WjZtOE5tLzdBREtYbDhvb1N2TEQwSVNIbkE3Vlp4WjBaMDdLRk83Vkw4bkFh?= =?utf-8?B?MmtESkJpa2pHK2x6ZU8xS2ZxRnQ1WnRraytvMFM3U0dybVlaMFU5empmMzZO?= =?utf-8?B?Wld5b3VoRVl6dFN1SWRHVC82U1R5RUVIdWg4UVRLT1JaZDVSNUl4QU1mcWc5?= =?utf-8?B?Uit1UDJlSTBUQ1BveXRTWmV1bFlpUnE5aHlVbWlEUlJGZUtNUDVLb3JrNTlB?= =?utf-8?B?WjRIVitHMDE5Ymk5ZHFqcTNhdkc1ZEZoOWw5K0xOV0t3R2xRMGQ0MGQvcldE?= =?utf-8?B?Y00yc3JzZzB6OElCZlV4OG52dldvRmdiOEUyMVd1b2lsSTF0VllWQ21veHl2?= =?utf-8?B?bHNOYmhiNGtBMlBPUUdlRXVGUStxS1l5d1NpUURicDg4YWRBbDVSRW9HbEtI?= =?utf-8?B?eVZmVWg3N0dMcDZPbENlMXNXMlVaN3ViaG9aclVPemMxdVBmdUt3TGdaZ3FW?= =?utf-8?B?NGNHWEp1cytsNHJQdHdYQ0tON1psdXNpQVZBeFJTVUlQUGNZaWp2YlNFdTda?= =?utf-8?B?bHhUVnNONFAvSDRpVHpXZ0FkYWduWGlqQ0twYzREVGVkRE5sQ2p3UjRGeXp0?= =?utf-8?B?SE9OQ29MV2pVeUZYd2xVb3hKeGhFL1AyRmNXSWY4RUpubmZMWlNqMzB3V1FM?= =?utf-8?B?RHA0cFhjR0ZWVUx3OWdLMVpWanZCazBKYU91VHV5V2pFNVU2aTE2ZlpKVWw1?= =?utf-8?B?WUVWSTBkZEMyNmJ6M250ZDhIQzhQN0wyR2puMnJrSzJjN050MjB5V2xISlhw?= =?utf-8?B?YmJld0RXNTlVWEhVRHI0dDhNcWVjWS85aFRHMnhkZjk3c1h1WEdVdWxTRVVI?= =?utf-8?B?aUFhNjhLT09WZGlUVksveVJIVHNQbjUrSlRJeS8ydjVjOEpaZVZwMEtWZ1Rn?= =?utf-8?B?Um96RVJnUzFNc2JHeEQyWTRRdXNOZTZza0ZxZUJWNzI4UUdCY2FEOHV1THdD?= =?utf-8?B?ay9ENzM0cURxbXcvYkdjQW1FTmJvSzRXZVVOVWFTSVJVT3pIV1lYUmlkVzFp?= =?utf-8?B?aDNjY0NMcXJKdXlGcjFDSWNFQTZ0a0VsMU01cjRHWjh4K3dGYktyUFQ2NVM2?= =?utf-8?B?Qk4wRkhLL21uNk5UaDcrQWt6QXR0Ykd2RXVaOEFNeitFeE9VanlVckxLNHdX?= =?utf-8?B?cXpySGFteVhQeFpXL0RuVjNZbHN0RTROcHJyeWhkZWh3dXBuRlN3MjJVNjBK?= =?utf-8?B?UmluNzhrQi8zS1FUUGlMVXJ6UktFdStvSy91QWlPNm5pMXMyL2xwQnB6SWpM?= =?utf-8?Q?/pdFmzPYjk+Mj3mFoECdeGlP6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: db3fb867-8811-4045-c686-08daa2035b04 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:14:12.3237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ucRmLTxTuDOhC8G4hneoDEv3B1cnZKkVj8eQEEwU+Dd8IcBet6NAt7HhNi1u9yuvmgweHRQPi8K3PWpPlgr+Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7895 On 28.09.2022 16:11, Roger Pau Monne wrote: > The current calls to memory_type_changed() are wider than strictly > necessary. Move them inside the iocap handlers and also limit to only > issue them when required. > > I would really like to get some feedback on the Arm change, since this > is now a prereq for the actual fix. > > Thanks, Roger. > > Roger Pau Monne (2): > arm/vgic: drop const attribute from gic_iomem_deny_access() > x86/ept: limit calls to memory_type_changed() Are there intentions for having these on 4.17? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:16:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:16:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413613.657367 (Exim 4.92) (envelope-from ) id 1odqb1-0003he-OR; Thu, 29 Sep 2022 10:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413613.657367; Thu, 29 Sep 2022 10:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqb1-0003hX-LU; Thu, 29 Sep 2022 10:16:47 +0000 Received: by outflank-mailman (input) for mailman id 413613; Thu, 29 Sep 2022 10:16:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odqb0-0003hO-7i for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:16:46 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2065.outbound.protection.outlook.com [40.107.249.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc924bd8-3fdf-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 12:16:37 +0200 (CEST) Received: from FR0P281CA0099.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::17) by AS8PR08MB6646.eurprd08.prod.outlook.com (2603:10a6:20b:350::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 10:16:41 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a9:cafe::d1) by FR0P281CA0099.outlook.office365.com (2603:10a6:d10:a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Thu, 29 Sep 2022 10:16:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 10:16:40 +0000 Received: ("Tessian outbound 99ee3885c6d5:v128"); Thu, 29 Sep 2022 10:16:40 +0000 Received: from ce2d016f213c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0A6ED90B-257D-4A39-8A3F-5AED41A35E84.1; Thu, 29 Sep 2022 10:16:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ce2d016f213c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 10:16:33 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV2PR08MB9325.eurprd08.prod.outlook.com (2603:10a6:150:d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:16:30 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 10:16:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc924bd8-3fdf-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gp2ha6BUKsQ9C0+K/WnSKTlliDYy82YqnDLbRbEakxBwucsS0JmoiF/0WIEWnGV0hghm2AJ/7fU11QOV4BcWo6+skUlzSSIwTScMPTKNFDnVBWCyvzd/NKVyrZNrKPwPK1cWHkvwjImyZNipUBIK0atvdwzufacMWcfitVEcQDPiPfLpnRUGq0OxP4WAtsuVuSQRsLmvvIiMhVel8614RsvhMFNfGBzdBGsDtxCLyqfmOC7ROUFH2xsxMmehUrq4VZv/pUQHIYTHCfFSrCg1pB3Hk+KmEFjjgYC3ICxeIKWdtqbNE+iAMpcFNSAO83uV6DF8sV6sUy0sW8/DBwNRfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkOnfQJNOiimrsmcpCV6O+uwz8ue26vjLsIXsPctdZ8=; b=RQnAIrk7xBHyauJgLLz0Olul2lVVaJ/BJ40dBTCLKVh+/BBBVlG9iv3tWF72uhuCSC0jYBvz4uHPBcwsxjqMFVwPNNelQ++lpOroiaSmte4XE48m9O3XoO0tLsmF3BP9rkRUws1GLtH01IPsvlEyEqoXwOU8R5xZVPOYYc8LK9SEiflczny2uaAllgy9xhlRyp49EXXPajz5r3yZS7HopNruDelv96zpZaH43UPdGqhEWQjeuHMIIM2qeyXKrgh0K2cw2tblJ6GkvG/jwMor8yhTFbkvjdrSMvf8knBZnNKhF2t6svUxHz8NI9nio1xBOWLh0SOhg0REKmbm2H8mZA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkOnfQJNOiimrsmcpCV6O+uwz8ue26vjLsIXsPctdZ8=; b=tgKG9Sad8zc5qb6KUwS4SL7Jl+hGZ9qfVOq5Ew8cuZrWPqe3JwsoGw93i/gNL8Y1KM8fnF/qPawDYaxHTNRJ7R36MdQQUP4HB1p4HgdVAYC2g2uO/VW2h2iFoTyr/IWbjHLNn7Ky8wXG+sffpWOFHh0AjP39Kd0iNur/mx6XXsE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: af7643d1c2dac946 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFWcw2ucuDzCSJz7Gg78emEh0Aq6mVFB36W65pGBNK9ZIzicdGZyybKScWnB80VwxKomRlOIUWMIvBx0IHjXiOq7ozqWIuxz+2EO6wvphY5RbrGp01IoLoCBN5I7WnX9DrbQ5PhAZTg+IgUez5q7WC4NsuAHgHC0BI1zMmBqC0STHr8d3J0yJfB2m8qOiYMXwxRWvSCAca4eS3YSPI7a1lpGpN3tkbqKucyOl6j+1HpUesmdNcyU0pgIw0oWiCyEFUzYa6cGfhLudrfTjZaDzmC/faQhF4drxnPWo2lTIk8U2OkyD+vdD7vt6ZwPHtA2zq1sQDmv0OPWFu8zfglw/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkOnfQJNOiimrsmcpCV6O+uwz8ue26vjLsIXsPctdZ8=; b=MIE8vnV8I52664Mic2wXrGO8KgPRlZu9fOvuH1xFqlEUVdFgGbxw1TV2+tmzIThDfBjZgNIUw+sLYKfcx324w/gNwffK4WyFvFvLwiz45N8Z3X8b39+mufr8Hrig/d+nClVuITkSQuDh0PoXc91AsQysU7FAo2/rW9pgrw0e8dtSLmtfSlkW59heX6zNpD3hYdzatBA2iu0d7iKDJGJdI7xrLVoc7Vl1EXe9ap52jUH19rodBChutQm7ezgPwtxxd2CBb6KmRZEAjvxBlxyHmiGrCVz7tNLh7uuVURdTrcB9lnLJvHgHtXIpqTXymtGzB2YTQNBtW8D+j3+pVczK9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkOnfQJNOiimrsmcpCV6O+uwz8ue26vjLsIXsPctdZ8=; b=tgKG9Sad8zc5qb6KUwS4SL7Jl+hGZ9qfVOq5Ew8cuZrWPqe3JwsoGw93i/gNL8Y1KM8fnF/qPawDYaxHTNRJ7R36MdQQUP4HB1p4HgdVAYC2g2uO/VW2h2iFoTyr/IWbjHLNn7Ky8wXG+sffpWOFHh0AjP39Kd0iNur/mx6XXsE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <11496e1a-b6bc-f878-9bb7-766fcd505ac7@arm.com> Date: Thu, 29 Sep 2022 18:16:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Juergen Gross , Jan Beulich , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> From: Wei Chen In-Reply-To: <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR04CA0153.apcprd04.prod.outlook.com (2603:1096:4::15) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|GV2PR08MB9325:EE_|VE1EUR03FT022:EE_|AS8PR08MB6646:EE_ X-MS-Office365-Filtering-Correlation-Id: 01b8ba2e-aa20-4c82-bf0a-08daa203b3b6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nitDpHFVG5pYcXAa+/YnfFsKxS36KbTsJ2Ed/svMg8TKBCGT3e4SfBU7LX9QAz4rWs33ifNfpQEFCMcDqsmo6632V4pUF9Fxi5UHa4lfebGgnYS2Dxdc5JeSaLW87AKsKgGKI7mLMzWE9kRCDi4qJC3TdXh3x4oNxrc3PhVffogvWSyVizHExHUPJgID/s1A0uazM8R8Hv7djF9prLtt52xal2URbGHHXA2Y66/7oaWnP3kHCluv5QUH0Op6buU5+O+B2bjt+ulfh6oU6vTkDBiZ8RF4DzCuiCo/OgOXzkAKkyhusJiq2HLpxHxcrpKPx2DBjpYI0llqamBkrtLvga3hVzp9tvWeUEnT1wEq/UkcBjg+gnDHAmZAzGtByv65JqdgZ8IPrmGt43aOI/c1OA4XRmdvh+1XZUsX3lbrQS0ITw0/ie10ZQc9lmy+rsJSCjtYBRI/Za3rBL2FXNoqjBXSeLdnT50eUG/1RRWBmNcHl/0rpkdKG2EdpRa0P9vyAMZNfi7t9YlFz+alFq8hpvRyfmh783Rs5JKMk7q11QzgQ2zxjVI73ROGDpIThJ8SK1bhLSejDVUyvwYp30RrCzyiLbfSZeZFz30QjxNdy5dHZQxGVynuCkaMP11C3d0uTEH8ZONxeU5nt3rrrzsEFgrsej2MLpZpBwwf7Go/lwpUGXdSsNPBGxa+JV/fRHLbdW7s+weTa3MPoWlMTbZR33RBI5JbSfJrUjetSbWk11HH68xlFt10yjuiWDMyVBTQHNiBiossndAZs6w1CtIWzd70Ed0XSNuy8utm8+ZM7ko= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199015)(6486002)(6512007)(26005)(2616005)(6506007)(53546011)(31686004)(38100700002)(8676002)(110136005)(316002)(4326008)(86362001)(31696002)(36756003)(186003)(83380400001)(478600001)(6666004)(2906002)(5660300002)(66946007)(66556008)(66476007)(8936002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9325 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b93d55f6-c3d8-48d6-dc22-08daa203ad2b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l8/8KN546srKX7C4f5ohKgKjDFQFgnuq2oPbwf9AAViWb7q5UCrD/EA2IIPTVsWy3y5wa25/H28fhxpbVJEfS7TQt8+JHkbTCByJRWkV4C91bEAbFKVV8FzqpZJlaF5k5KQ6kjSKkAgRXR/UCtTowiKf7k6l4k3oZ01foZUPL3OAxFpttRIzszG7bV8ck5hRW3lfjGxcKt21pXB79Jp5M558sUlZ+M25wJQA20HB/7Omkm1w1f8nXSczBuAdAWRzDNWwJl9yBSSz8ZoP0Ds1lZaI5cbbmJlT6WhOcsm/8MmIq73dbibVC8/liYLN/BeQtBAIMJbtCk7evk+G9zEuUgI8+Tw8TXfEaJeLTa7vTbRM3cDU1jHRDKXK1j6Pg0PuleZOPGJisRVSmxEhvqYlq71nuzJByTFFTT3SUG+LRS9NvrDtWqazLXASGu1YvCUm/ePSIvzMrI0alj+Gf2WHXluf5RvAHH7bG5D3mZH0FTpDjuoRwsmXHy6uAhibFoq0ZA6/yuWLSJNoozskJg+BDSqYJC82LIQFyi2RqSyae/2YE+vryscYZ0lLQ7NCXFk6+QNHIcCEPAvHp1n/HQV7mqRd/AWwRBbFNWUjTu7DFTa+SM4XPTs95kx7F/nYRuKKSrDYbxHWTmTAgkcmRXZajkS60qvxe8Pk5eTw/VK35JfuJeC06+bfKuELSWQcfwzxbumsTVettUytquzpHg5R+BmNgXNJwx/IFTv2wF7RMndGpHqi0ZhRQCHPCtCicgSLmL11SkUFpmawNNzK0jr4uxQQa3Y4V8TDDc9zcu3T2qGZYAFSud1oqFh8uWInQ7pT X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(26005)(36860700001)(36756003)(356005)(81166007)(40480700001)(40460700003)(316002)(82740400003)(86362001)(31696002)(70586007)(6486002)(110136005)(70206006)(8936002)(2906002)(41300700001)(4326008)(8676002)(5660300002)(47076005)(2616005)(336012)(186003)(83380400001)(6666004)(6512007)(6506007)(478600001)(82310400005)(53546011)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:16:40.8952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01b8ba2e-aa20-4c82-bf0a-08daa203b3b6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6646 Hi Juergen， On 2022/9/28 21:03, Juergen Gross wrote: > On 28.09.22 14:06, Jan Beulich wrote: >> On 28.09.2022 12:58, Andrew Cooper wrote: >>> On 28/09/2022 11:38, Jan Beulich wrote: > > What about an alternative model allowing to use most of the current > hypercalls unmodified? > > We could add a new hypercall for registering hypercall buffers via > virtual address, physical address, and size of the buffers (kind of a > software TLB). The buffer table would want to be physically addressed > by the hypercall, of course. > > It might be interesting to have this table per vcpu (it should be > allowed to use the same table for multiple vcpus) in order to speed > up finding translation entries of percpu buffers. > > Any hypercall buffer being addressed virtually could first tried to > be found via the SW-TLB. This wouldn't require any changes for most > of the hypercall interfaces. Only special cases with very large buffers > might need indirect variants (like Jan said: via GFN lists, which could > be passed in registered buffers). > > Encrypted guests would probably want to use static percpu buffers in > order to avoid switching the encryption state of the buffers all the > time. > I agree with this one. When we were working on Arm Realm, we were also concerned about how buffers in hypercalls were shared between Xen and realm VM. Dynamically switching between protected and unprotected (can be accessed by VM and Xen, could not execute code) states of memory can be very expensive. And these uncertainties are also very easy to cause security problems. We have thought about explicitly reserving a section of unprotected memory for the realm VM for hypercall buffers, but that means Xen drivers of Linux need to be modified. It's great to see the community starts to do design about this. Cheers, Wei Chen > An unencrypted PVH/HVM domain (e.g. PVH dom0) could just define one > giant buffer with the domain's memory size via the physical memory > mapping of the kernel. All kmalloc() addresses would be in that region. > > A buffer address not found would need to be translated like today (and > fail for an encrypted guest). > > Thoughts? > > > Juergen From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:57:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413619.657378 (Exim 4.92) (envelope-from ) id 1odrEB-0008Dq-Qw; Thu, 29 Sep 2022 10:57:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413619.657378; Thu, 29 Sep 2022 10:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrEB-0008Dj-OD; Thu, 29 Sep 2022 10:57:15 +0000 Received: by outflank-mailman (input) for mailman id 413619; Thu, 29 Sep 2022 10:57:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrEA-0008Dc-5V for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:57:14 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 736b67e3-3fe5-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 12:57:05 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A0DF8320014C; Thu, 29 Sep 2022 06:57:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 29 Sep 2022 06:57:09 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 06:57:06 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 736b67e3-3fe5-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664449028; x= 1664535428; bh=jGPatLXErhfKlARxhbJZGrfudntfdRJfb+3Mv7JEM7Y=; b=M N2HmM16tJlaUFxccpa+u+B0QGbB4cnfCe9MRiBk0sEXsEZrJzbh6XRsQxSzLLWvx PXXBhbZ8ctwi71muB1IDrbJNTTm5NfORodZYZx+gE3TO6ghlDrifqVSmHJ4APpV3 lJ/oA2e9a4CPuQ6Cg27nKKTFpd7i41vV6vGJ5hXCzkcY3HCPudmPYhEYGlx5kq9K CXxEdHhYK9GdTPhme86NvphdzEWsebK9mX1DYJdV/PpnkKEAWOLdj1EbzmxLAXMS EBLgsZSv8Kw7qsL1CSL78L2VQInO0BNd5hZhyoIerpqvdS6i0FEvnFhAAzhtTN2M XZl3C6WFffjF6RvnqXhBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664449028; x=1664535428; bh=jGPatLXErhfKlARxhbJZGrfudntf dRJfb+3Mv7JEM7Y=; b=GDfVhNBo2bEGTrBHHYMxnuw3PnHYDFoxDTWGcb9xSU2X +ieQByQsBxPiYYkPJmG0gSzX1TUlLQ/whVmUsL/OBD0E0ZQWX8q0WizEdpGdEFL/ sLEuP/W3qOX1542kEl7c4rqZcllT1hMvORPIi6Om0n7XsmXoX02V2EWQKeAOb1u1 AfA15+5xTjf7o6hWupALoMD8xqxbcXWUT4awcYc65pdiytFaPtjYo01SidUXEwFt 1rZJB6gidoiAGjp7CTjjVs2qxOqpY/yydfLajziHwq7q7pG8aa+7MSVXN5AqAeVV fJQhUsl1qfn6V+/XhWUeALTo6YMEFsr1Xgq+BYy/mg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehtddgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 29 Sep 2022 12:57:03 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, George Dunlap , Roger Pau =?utf-8?B?TW9ubsOp?= , Anthony PERARD Subject: Re: Design session "MSI-X support with Linux stubdomain" notes Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="z8TbrM2K6lu4hpvf" Content-Disposition: inline In-Reply-To: --z8TbrM2K6lu4hpvf Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 29 Sep 2022 12:57:03 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, George Dunlap , Roger Pau =?utf-8?B?TW9ubsOp?= , Anthony PERARD Subject: Re: Design session "MSI-X support with Linux stubdomain" notes On Mon, Sep 26, 2022 at 02:47:55PM +0200, Jan Beulich wrote: > On 26.09.2022 14:43, Marek Marczykowski-G=C3=B3recki wrote: > > On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: > >> On 22.09.2022 18:05, Anthony PERARD wrote: > >>> WARNING: Notes missing at the beginning of the meeting. > >>> > >>> session description: > >>>> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn= =E2=80=99t > >>>> support MSI-X. For the device to (partially) work, Qemu needs a patc= h masking > >>>> MSI-X from the PCI config space. Some drivers are not happy about th= at, which > >>>> is understandable (device natively supports MSI-X, so fallback path = are > >>>> rarely tested). > >>>> > >>>> This is mostly (?) about qemu accessing /dev/mem directly (here: > >>>> https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) -= lets > >>>> discuss alternative interface that stubdomain could use. > >>> > >>> > >>> > >>> when qemu forward interrupt, > >>> for correct mask bit, it read physical mask bit. > >>> an hypercall would make sense. > >>> -> benefit, mask bit in hardware will be what hypervisor desire, = and device model desire. > >>> from guest point of view, interrupt should be unmask. > >>> > >>> interrupt request are first forwarded to qemu, so xen have to do some= post processing once request comes back from qemu. > >>> it's weird.. > >>> > >>> someone should have a look, and rationalize this weird path. > >>> > >>> Xen tries to not forward everything to qemu. > >>> > >>> why don't we do that in xen. > >>> there's already code in xen for that. > >> > >> So what I didn't pay enough attention to when talking was that the > >> completion logic in Xen is for writes only. Maybe something similar > >> can be had for reads as well, but that's to be checked ... > >=20 > > I spent some time trying to follow that part of qemu, and I think it > > reads vector control only on the write path, to keep some bits > > unchanged, and also detect whether Xen masked it behind qemu's back. > > My understanding is, since 484d7c852e "x86/MSI-X: track host and guest > > mask-all requests separately" it is unnecessary, because Xen will > > remember guest's intention, so qemu can simply use its own internal > > state and act on that (guest writes will go through qemu, so it should > > have up to date view from guest's point of view). > >=20 > > As for PBA access, it is read by qemu only to pass it to the guest. I'm > > not sure whether qemu should use hypercall to retrieve it, or maybe > > Xen should fixup value itself on the read path. >=20 > Forwarding the access to qemu just for qemu to use a hypercall to obtain > the value needed seems backwards to me. If we need new code in Xen, we > can as well handle the read directly I think, without involving qemu. I'm not sure if I fully follow what qemu does here, but I think the reason for such handling is that PBA can (and often do) live on the same page as the actual MSI-X table. I'm trying to adjust qemu to not intercept this read, but at this point I'm not yet sure of that's even possible on sub-page granularity. But, to go forward with PoC/debugging, I hardwired PBA read to 0xFFFFFFFF, and it seems it doesn't work. My observation is that the handler in the Linux driver isn't called. There are several moving part (it could very well be bug in the driver, or some other part in the VM). Is there some place in Xen I can see if an interrupt gets delivered to the guest (some function I can add debug print to), or is it delivered directly to the guest? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --z8TbrM2K6lu4hpvf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM1egAACgkQ24/THMrX 1yxQKgf/Qh0hPYMpmvE3TeHRDj54VKnKLM3LoqCPSaDJQDGoFWXOw5brfeJ7ftnq AcNNfVSyZSuJoUmH89CO/ktZoE3telNIQhakM6JCTXRfwI7GUhbZuGao7KVaNlqe YdVstc2vBX9N3xLs1IUaZrkrJLlHle7y/2pZSyvrsGY25qujagE4EmVyH0j8kxM0 z65IJTPpuw+heemP7TFyLEuWeIpOijo+OhPLNqTTUcxhotrPqHbindz+4QyUwYRj 6yTBvthXqWXKFB0I/VVRJ32jInkBJEvmrDqtXtAvKqy0lWaIKXdEQnnjF/NUiCZt +dGcw+cvZ1bAY+NNFrUxhBCK5gwDLA== =SjgZ -----END PGP SIGNATURE----- --z8TbrM2K6lu4hpvf-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 10:58:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 10:58:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413626.657389 (Exim 4.92) (envelope-from ) id 1odrFZ-0000P9-9L; Thu, 29 Sep 2022 10:58:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413626.657389; Thu, 29 Sep 2022 10:58:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrFZ-0000P2-6U; Thu, 29 Sep 2022 10:58:41 +0000 Received: by outflank-mailman (input) for mailman id 413626; Thu, 29 Sep 2022 10:58:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrFX-0000Os-Tm for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 10:58:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa66a45a-3fe5-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 12:58:37 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Sep 2022 06:58:32 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6787.namprd03.prod.outlook.com (2603:10b6:510:123::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 10:58:29 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Thu, 29 Sep 2022 10:58:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa66a45a-3fe5-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664449116; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4jJ213CpqjVAViAZ5WEl+damVcCsVRSluuW681vtrcA=; b=GV+EFrWfaU3DrWTcJJpgDlMjf4fYhKwjWhaVTB92BMbMa3MGhOTTjku6 ma2fQonrYaGcQXNRZeyMkAoyiRxK6S2IsyKWQFgxganRapwoukhZLQ10f NVuGVxUt87F60f7Q9tvQbeqATIdRpjlapgcAN0rwmIUsV4AYxs6O9RFlD I=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 81617831 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AOdNPZKLfdVfP3dP8FE//H55ynAfxRhNe8xJyq?= =?us-ascii?q?0mlJ83Iv2s+/A1BKwYKpYUu6wEK28F0isbSNJTe5bO4tq4DKQk6O1Tqd/fT+?= =?us-ascii?q?mdqRDR5wIJWCaTeLwqnoycapJ0iSKZVb2rAfaWu9KkeU+fDGD3tFp/TPPaVi?= =?us-ascii?q?+VhRnh4nW8rvlQqf/ZyEmblA1pKVRxjCDgGs/hbRgLEa49pPI71GfCwoWfv8?= =?us-ascii?q?HGGFCItA231CZ/l+I9KPGSX4YXfB18jaoIbcXCsIMHzKwzBuO0J+jRy8msvr?= =?us-ascii?q?qRtHgtioRJh7iPM7byBYpaJbt7bKKhvll3MhkxYicpFIoDk1kAmORwxSef1q?= =?us-ascii?q?mZ3/wR0Z0vVRawuJBxkS52AbSuuEmAC9nG1Iv1lT3vsvEG8R1SeAuqaMOHqD?= =?us-ascii?q?vfqDsB4PYXXx+YWVAjQ6eC84P0n4EBNZGELd1isuLHutjAJL7IcaL+a3BJ4n?= =?us-ascii?q?N+dv4Eqq+d9u2tk7r4yqVJn/iKaUkF1bUQH+io/7tSM5JJN0hYMMalEcSf9Q?= =?us-ascii?q?jgJ0Bl2lLJz1FGhFXE5+KMZ9aNTqGhXCKPEdV+5WhuR88bCxEJwh9zYmfmnR?= =?us-ascii?q?BQPVdGkeaCf9rWwhYQ/9ZpR4sAh8XmjpdLoIkYjZ6dRV56R/hxUacWIKL4Yb?= =?us-ascii?q?pZU+XJ8cGo3ocltbvyQcgcpzq+x9qyArBEqyAoO2XCbr6uM9fFmrR1woZfKR?= =?us-ascii?q?tGxHZEt+JNk1piBDQoohpYkh0nWlgFbYv/QqKk5z1prasRutI81eE6ulYNA2?= =?us-ascii?q?nH+3ImTmVujDl936dFPdjk/v50/MxokeS5zBYKzpNgRM/9nSID2VyAm/xsHE?= =?us-ascii?q?f6MGcXlvFkcwVvnZY8K/Abv9vR1JXgQyDo6wuSMxi1PJTrdJthRKDAs5BMeF?= =?us-ascii?q?gUj0m+IXS+UevZoRp8JbWlpypTO2PLPZqgSXeR6CBWEDdDQSoi2/mxejh5+e?= =?us-ascii?q?voKVFe2XDO8VVeQej/SgBhwhxxdZTSnupkMF29V2JakGbusCAIaTc4sAKl1H?= =?us-ascii?q?CbWrj/o0E8rdvCKRzQ6QrSu1+PFUUVMmrnwU3WOj6kG/BCoqqv82yx+YSUlG?= =?us-ascii?q?ULyVRK+qpEsT/da1O8JEextDoCMISbIaeTKlaJwvTjQwXkyhQ/k+ldtoZ2iR?= =?us-ascii?q?ohSqk1Wz3UUNEMjK5GNKGFNSvSQ/Ivb+zXYsgWarG/f8dgauD3WOqIC5ammU?= =?us-ascii?q?NU2Y2T590Rl5mdjKfARQIrs6P1OPCoEgTMaWi6ONcV73mdrE5YE0NL9SlkVl?= =?us-ascii?q?7KzuWDSO4Hf0Oa3yG1Tm0oeOQEAG9YerrdfIRlikmQUM5xxC2z8FaS1rm0c5?= =?us-ascii?q?HETVUs7ifLa/lMYa+E/uH6pWEoAT7QOpL+l4oEMaxbw5FsGX4rwoNZXmWjvi?= =?us-ascii?q?Nm5S+ilO3A+djAGmL9/vK8/Apy6ew7OWfeCrfalfSc58NU2ltYGsz1Tcstbl?= =?us-ascii?q?BFaEBqEpocIRXtYpacNTfTstR7otZSKCM7qtsXHhHj8E3gZeSQzEB/DXWKTd?= =?us-ascii?q?LJ8Jq7B5CIYAkdwUzWjMMSozQMy4JtPcPtEvPf9kHqSP+P+7YndZV9A+TizL?= =?us-ascii?q?z+3oWxge4yJYhtw9CsNG7Y7pitOFS1WICByep037QoBuv+QmlmBjBOGjmsW+?= =?us-ascii?q?6qNCbl9iIDtQgGrllsIgPpNWAGTb4x9R5rI+d+KTW1648F12auz1GG1mU+i3?= =?us-ascii?q?Ou5Vw7N/d2PG79ckN8n4x8z6UuyV8xDxm6YjyLU25t8mWtV+/SjXfHCyJIZU?= =?us-ascii?q?s8e3ywxFPm5CSIkHsnmXi5SjIX3s/xtATVBGD4qM0hNU3XoCTD2i6qJa+IKW?= =?us-ascii?q?yoQKY+z3CEvRQQII00qLpDkAtYclURwr0x4R8X9AoefiA3yvdpNrTVffeU6h?= =?us-ascii?q?UWcYU1b9gPmRe0Qjv8Xy24maUx/yaQDb2J2gh5XIlHd3P2vsSU87Q722jyEm?= =?us-ascii?q?6mDa5R9qKKvC4dD4AKEUHzXG9wDhSfpUsHYGqJNpLSzFSGnalwSfiJvjTtua?= =?us-ascii?q?Ur144dtos+g9iLIR+wjCmE9k32qXMy420LmWlm8sJUdQVa2f3jMD/DRqAjf+?= =?us-ascii?q?zIT5oQjJERz+OlvuKMiFvL/b+WU47caT70l/akS0WHQxR4UY3NBcYD+Sjwa2?= =?us-ascii?q?OVE3pN7L/HblIj0pG4oHLZmVUxv05XqwkYj8EcQJ/cYOKiG9JbxclEghGyp2?= =?us-ascii?q?ExBY44Rw2PE5JQp83Qh+A+McT4s1Y5iT6dkGXswInX/H/PJwr033RADY4uTI?= =?us-ascii?q?CLidAsjZqpW2980VRkLmLuiys2D9EMZej7A3uy4orXNmjrYh/j99LIj5xYoh?= =?us-ascii?q?suyEpny15YhqvzkfjRIBZ5FrUZxrnKmhG1hQ0LXKsnV19tXg4fn0Ceds9j9b?= =?us-ascii?q?0vR7Ihjd7YbO7axF82bDfMlaMERxqNSh4/Sl539IOUys2MoT0NhvknhChno/?= =?us-ascii?q?AMu7KkfotzVMrEkuY0UyFfM7VdrmvDLLd3Zqtt/mKIEw861T8rfCEdCo+mhM?= =?us-ascii?q?vQWHVYQ1YDje1js8IAl+XL2d7BsqCi0mDQKe49QtRUrRicPwQWxEf+vU/FCD?= =?us-ascii?q?suMF0u99oohmN1FroxfzKl9NZklcGO7ZBCJYqDyFznZs6/zgADiGWbZX6EQc?= =?us-ascii?q?n8p+QlkSACUCocYzqzw+StgCDHu1ztUEtkven88oEsoY25Adzk4+JlOTuknu?= =?us-ascii?q?v1kvjo57Mr4tLVQMTsbI53GQAFc7KBhOseg3zNMTtSMGzN6tuEdfsgftdv94?= =?us-ascii?q?71nzhxU5v1ZFrD7Zl2lbAbwQ1um4mX8V6pxerwcoQsIzcv8wQuBWOFXgu5Nf?= =?us-ascii?q?V3HuO2a4cVpHK2KIITwRf3G52HDIcrAQxa5DcBVVRCc9/3orUYASTGlPvcwA?= =?us-ascii?q?NWw4wxsGeSV0ABzrYpD7GOie2BIhUigueDD+nHEIA=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,354,1654574400"; d="scan'208";a="81617831" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acSnkaCl+cBAqFlhqdweU94J83H8l6KfBAAKl5lVQBXbXeq05rrKY8nYw6HshRy+mr98s/Y5p+UabtPpvrxnIj+HrfJexpLx1EjZZR4ISOhjXJYPw1Mx/1OMvMoqAOmu+vT567CkC3Hr/T1UYhFR17BBP5/a75qx97mtLpOsgT4GtMiz9ZxuDO4Xx7lCiDQ5MJdGH4/UWueX//sWNMcS0PhLf4RGi8gnPosAdRA1kCCpZzebOjxnl7T4mp2WNDnk2eqikn7L7IQV1g3KconwC5Oaq7n2kQh+QGZN5Bvs3DOUuEXn0lau9QSHzxw9BsTCW6PPLSWD37Lc1CKkXnywPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7psNnl26cukPzWtA35vTcODbt1tXfttRr4illCx02fQ=; b=TuYdGM2/lmhe4uzc+nrkhhQF5af0c+xI8AN4TTzl/IDM14hx/peXRwCpSZtcH0Fg91/KvFFaw4wiyi6P9FoPrcH3hUcKAs6QDIJhuFGcRolWMXMB0wjUsN0J/oLu9i4qqxDVgMbsjrKK9xyISBit0M4eSSRdI1rlGZd+81VCIWA1Q5lxH/32Kt04HGoXzQqOjDjBEHZqRHyzkW//lzyJcsKh1xV4BBIuN06l7IsyQF83IaVAnbqYvFcR7TIt+eoxzRn/CSpKRdWskn0up2BkduaTTCb/UZZW9mMCC9sY3t2/aUfMF28vtTqLfrFeeDbJxcggqnFov4IOPsMl8mnAQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7psNnl26cukPzWtA35vTcODbt1tXfttRr4illCx02fQ=; b=XKsObqaVRLEd06FVmMSYW6F8dzTQCvrX85cIb39ooF42mi3Y1MZOsF8pj3LPV2c3G+RkND1EDKo6BheGhCdjH3bnBzzkaScu07/fPGV4/N5cZzg3hfCcGhTUSJaTsMsxqCOX82UKmB/xVQzOsnaSlhbwdGM6/c8gNdoTSYi9swM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 29 Sep 2022 12:58:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich , Henry Wang Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Wei Liu , George Dunlap , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org Subject: For 4.17 (was: Re: [PATCH v3 0/2] Move calls to memory_type_changed()) Message-ID: References: <20220928141117.51351-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0633.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6787:EE_ X-MS-Office365-Filtering-Correlation-Id: 90b6ff70-86cf-42a5-ff22-08daa2098a51 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CpT0gO8a3It+R2ub1fjQBmdl8Pnfrr2iINZ27SxGBXR1s1x25VgcE2c3HO7a3bIx+C/urWVZXWVLG1fBvcUUCX9p1nhFz1DjyZnlJ8qqUxPZn/sooZ21/JuHNABpJ10WYVNPpmme1xy4+je5aUvOMPT2peK3mzTwThjbehsQJ6oFZ5a/cerc2++VtgwErvsaYDud4XdrQDvgR2DPD6anxHflqFUpjeiO788ppkptsfw9v8ppKgV/tTBIAfdXdyMJPpqjB+Rl6aJjIYTAD8txff3lQzmrsgSXAtYFk2hOKBnMN1w8OxsJGqDBA4Gm8TpaTA+SPfcXgCMyCCaGd0kCYJMt5TQ7bacAXNuHgViYqQ+TC0d1JXj6gGhBPqPpHG303Vr6Qwzupb5ifvMjqljzECx7BdAPRxSZ3m+f1J9HDI0JI4H+qrYvRi+wJAAQhvOZrsD3z7mY8p4WcrW5whTvU4iTuEpd/mjJUlS8uIOaKroQfYcWEoFnvJ0qctxh9lUT9HzSms6K1LgI+L8JZHvyHmtU39bv61/20rEz007CvKPr9XWhLY1oOmM/ZCGnmGnu62eyrmvmw09GdiRpebVRWwoLkAhYs7rJB+vBJof1tzDYnIfCHJPKqC0Z2RYUGwCwFwyYzH3aWhYBTxHxKM1vODa46bEvW6jkKwnTlEtemknWNFOEg8xI5drxW3+LW5q901ZJfiVbQSMPJJaQMEDQrQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(451199015)(186003)(38100700002)(82960400001)(85182001)(86362001)(83380400001)(110136005)(5660300002)(41300700001)(54906003)(53546011)(8936002)(7416002)(4326008)(316002)(66476007)(66556008)(66946007)(8676002)(478600001)(2906002)(6512007)(6666004)(6506007)(9686003)(26005)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0pkYlhqOXNlZlphcXM5TVRBRUQ4eXlCVlEvUnBUbHRyUnFhUEw5UVY2STZr?= =?utf-8?B?Wk8zZzVpVnltaHJWSXBjZitSQ2J1cERnWVk4NFZpZHBrK3dIaDZZQnY2Mk1G?= =?utf-8?B?T0ovOTVlaHdETUsyZTNyYmpTUmJDV2R3aWxORHdLNWVteFVXdkpLNEtTdksx?= =?utf-8?B?WXJ2bWNJMFd2UDVycXQ0MHdwNkU2Z2xZZHpOSGJXMjI0aDI3VnUwOEUzdXY4?= =?utf-8?B?ejJGK0ZPTHU5VUxERjUyR0Y5dGc4ZDZzRGpTWjVUWWJra2hnNUhGN3BVai92?= =?utf-8?B?QTByM1VCeEJtQUQ4YVc3RTlYNHJoZ3BGS29BTGFkQi9KSGloUUhYOS9jQ1pF?= =?utf-8?B?bFpZdzdGYjhVbmJUcS9QOWxhRFZyZ1RqT3VzYXMwaWFDNDk2a2xxb01SbFRi?= =?utf-8?B?TlhSeHp6OCtPdUxsMlVzVTJZbXkwYnFmWVA4NWh4alM2VVRtMC9UKzQzV3VW?= =?utf-8?B?VDF1bXovci81WFE4eWg3a1pBbWVjSno2WnZhQ3BuVkhJRVBPREpxdWFvWTAv?= =?utf-8?B?bTBZK2JWNVNSQzVBMFl6aUM2eEJDYkNMOU9GM05sZW9XZ0lLbnJWM2hqUGJR?= =?utf-8?B?S1p6NVhGallkQ0JFaFl4K2FXNndsaUVsYmdyWGk5NzAzYXVOcitqRS84U2Zr?= =?utf-8?B?djY0N09WM1F1UEdiK3RZSEsyOEVEcmtQZ1ErK3ZCNTg4SnhkenVIQzVjdWZh?= =?utf-8?B?VVVkOXNYNTZOT0RwZERkTXVkZjRDa0p3SlhUaTdWQllpR0NkOTllM253aWsy?= =?utf-8?B?QkpCcGM1Q1k4S2pDUnk5QVNCQXhOU2hPS0ZXd00yYURYVDlMc1RhM004WkJI?= =?utf-8?B?QnFRazJtQjlLZ3NhSTh0NU5QQ3BzV0luaEdTRGFESU92dGFKSnNldGVGQkl0?= =?utf-8?B?QTNWQ3hXVWRmOUlvTmJDazBKMjBYVGpYSjd6ZkVJNjFXc1JLOUJMSzJscFZR?= =?utf-8?B?OU5RQnhtNlQyamE0ZWRQZDkrb0NlWjkvRGQxZ1BkYWRSWHQwN0FkN0xFN1BS?= =?utf-8?B?d2FEM0VwdUxhQkJ0aThGZ21JcEdEbnIzandKQk1EMGNNa04yWGtFOXArQ1Zr?= =?utf-8?B?NG5NTFA0RFd6S3c3MTdFL1VDR01rVnJvRkpJcW1jR0hNTi91ZU0xd292b3ZV?= =?utf-8?B?OE41Q3czdVFwR3ZVWG1QU1hiWUFvNkJScURNUE5oTERzTkMyY0ZjUWNBYWl5?= =?utf-8?B?V0NjYm8wM2J3VUpqWDhuUEQxeHRDRHpjdmVYQTJEVk9tNGliRTF2RG1EZ0pH?= =?utf-8?B?b041QkNFU0VzYndBVDlkZUM4RFdKbmFiYWI5MlUyMnhKVHF3TUZvVjZSRDVN?= =?utf-8?B?ODRHRUlQcU4wQ0tzbDR1MFFVRkxCR25rSWNUWGVxY28wSXZKY3F5WXFUMUNT?= =?utf-8?B?enVJRVp5L3dMeklFcDFQcXF4QitKbnpRNzQ3SGZpOEVTY1E0VnVyY1FqZ0Y4?= =?utf-8?B?cnBRV2Q0QXdJalo5aDlCVEtSMHBQZGZiZVQyYUEvdDlRNWRBYy9RakhCaHR4?= =?utf-8?B?cHQwd2FsU25UTnJsMGh2L1R3L3l3RURqZCtkZXZ2d3JHMURFajBPNnBDWWs2?= =?utf-8?B?OU5peGVSRC91cGc3RDFIVllKU1hQcWxWZm95V3hpaVJrZjM4dXNaRlVBQkdw?= =?utf-8?B?RGtHWVhER2Uvd245b0FFbHA4NkkyQ090ZmROZ0ZTREN4WFpjbllJbWw5V2dN?= =?utf-8?B?c2FadVlwUk5qQWxpL3NJT1N2cTdmNCs1QzZJZTZEbFMxWkthOWR1b2I1RnVN?= =?utf-8?B?WnBMU2tFOGVyQXNlUVowaUphYW1CRVpSS1FnakZ4QVdsbjdXUDVMdzFiMi9j?= =?utf-8?B?OGc2UnR6SXlVUDB4RUpoQ3FlcGhBWUNzUEZVUitCV1Y2REtGUGt4M1VzVEpj?= =?utf-8?B?NnhmQksyTTUyL2JlU3pzaVhMcDRnNWhmZll2Nkl4ZE1iam1tbWR0VjBZK2Nr?= =?utf-8?B?SlNCc1ZBU251bjY4NHQrRG1kdm4wQ1FZd09oOVFyVzVwNndNRFd3SzRqNStN?= =?utf-8?B?UkNhOC80dEppR2Qxc2poczJpNzNxVHkwMUw4YU5FdlpCWmZQTTh4UUdRNkZr?= =?utf-8?B?V0lSTzhmVVZKN1pNYk9GenlXdTRlMWdpVDlNaGllaFI3MDE3T2swMEtWR0J4?= =?utf-8?B?RzhxQkovRjVWbXFzNXBYdHN2OHl3MlpOaEUrUnVnOG15MFAzRHZUcTlEMWVN?= =?utf-8?B?eWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90b6ff70-86cf-42a5-ff22-08daa2098a51 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 10:58:28.8349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PN8mnFNYRyzwqRiFOPV8ULYt/S2zeJQcTKoQTlMs9tecT2ilf4wb+HJgMwp8V3Zb6vVGqdjKcRJPX3Lh8F6ycw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6787 On Thu, Sep 29, 2022 at 12:14:10PM +0200, Jan Beulich wrote: > On 28.09.2022 16:11, Roger Pau Monne wrote: > > The current calls to memory_type_changed() are wider than strictly > > necessary. Move them inside the iocap handlers and also limit to only > > issue them when required. > > > > I would really like to get some feedback on the Arm change, since this > > is now a prereq for the actual fix. > > > > Thanks, Roger. > > > > Roger Pau Monne (2): > > arm/vgic: drop const attribute from gic_iomem_deny_access() > > x86/ept: limit calls to memory_type_changed() > > Are there intentions for having these on 4.17? I wasn't sure. From XenServer PoV it's certainly a bug fix, otherwise some workloads related to GPU passthrough are simply too slow to be usable. I would certainly be fine with it making it's way into 4.17, let me add Henry: Cons: - Changes the number of issued memory_type_changed(), so there's a risk I misplaced some of the conditions and we end up with wrong cache types in the guest p2m due to missing memory_type_changed() calls. That however won't affect Xen itself, just the guest. Pros: - Removes unneeded memory_type_changed(), thus making some operations faster. It's effect it's greatly dependent on using a set of hypercalls against a domain, which doesn't seem common in upstream. It's possible other products based on Xen apart from XenServer will also see an speedup as a result. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:11:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:11:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413633.657400 (Exim 4.92) (envelope-from ) id 1odrRh-0002oP-E0; Thu, 29 Sep 2022 11:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413633.657400; Thu, 29 Sep 2022 11:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrRh-0002oI-A9; Thu, 29 Sep 2022 11:11:13 +0000 Received: by outflank-mailman (input) for mailman id 413633; Thu, 29 Sep 2022 11:11:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrRg-0002oC-1W for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:11:12 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bb75825-3fe7-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 13:11:09 +0200 (CEST) Received: from AM5PR0701CA0012.eurprd07.prod.outlook.com (2603:10a6:203:51::22) by AM8PR08MB5604.eurprd08.prod.outlook.com (2603:10a6:20b:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 11:10:57 +0000 Received: from AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::1a) by AM5PR0701CA0012.outlook.office365.com (2603:10a6:203:51::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 11:10:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT019.mail.protection.outlook.com (100.127.140.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 11:10:56 +0000 Received: ("Tessian outbound 99ee3885c6d5:v128"); Thu, 29 Sep 2022 11:10:56 +0000 Received: from 6e54db4d7f2c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9F27D4E1-332D-4281-8DE4-8EAB79B7897F.1; Thu, 29 Sep 2022 11:10:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6e54db4d7f2c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 11:10:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAWPR08MB9805.eurprd08.prod.outlook.com (2603:10a6:102:2e6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Thu, 29 Sep 2022 11:10:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%4]) with mapi id 15.20.5676.019; Thu, 29 Sep 2022 11:10:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bb75825-3fe7-11ed-964a-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PDH00GmQZvLXQEyJSdALQMOgOgmJXUOQKl2f3fj19rCw7y2jAQvEdvdPVqU9uq26CDWuVtZzFCNVwJRsJ5vl2ljyCMpCfVvzJW6jjwaZNP9B1vxFnGr8kqbmlr3eW3zumfubydBKICOAdAqxJFHRD0Ee+LOahfo/BbJoYuAwmRV5cWqiFXg9lTwyzsaZ407NXneUl/b3obkvJTccCWkVM4aQF7sv3DA1vGjBoj90vWGEOWw51+bhvksTN9oZW+RHbfQQGQp3/R+E79g3D4DpA7AlsAnoJqJVSSAV4hIuX7+U/mtRYjSO+/7p0zObk4mNqWw8D0y4SoziJpeDrDMbQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UmblhuZKYvHL5h1slSavwTVzyTtCnxNQQDsr42mAx8g=; b=YQn4N3IYwsD5I/E6yHM+oYRaEcmU1+WudPrG+4UpbJtvYM/vP+3bQQUOyEOYbzGIKkEc7pBzS8Vs2iMM4KV0lnNkLy8ZznjIO1KCZCV+UT+WLLUZ24i29AYJdErKhA5Xtv6GqyNeac/QsfIr0lT0ebUGL6LlHA0H8dosxCJ5ckqFOuVRHedPQHGjnC6gQ9XiY3AYu1QU6HQE1WfwWJPzSNwTlJpK8DEkVgxeN9O3+M/42atIdJ1iK5wypDrQQVhinIbJCXM5wJNwPA4RwzZvY+SiXfZwfUV6K2CwL59B4IfU4VS2xRGvc9YRvUvbXtNiInyYuC6Tm2k1hcJQ7bT8ZQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmblhuZKYvHL5h1slSavwTVzyTtCnxNQQDsr42mAx8g=; b=q1ntSiyUPT9xCEWOhat9k8Vc45Mqt7oKLbSo7DTIkqrxf1NVbVeisoxIkdo5pwIrfI4XIPi6cluEBD7FG+MKPTMIGSd9mzg1Lm7VCKQNzGrGjht/B3K3sOeXwIsIRoEbwrUw9gXTcEXvF8YYFo/YiFIy6/n4TBQbVeKIm/ZAO3A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bWO+FA7NbxjLP9w32xIf4oCKUzAncf8H/Ujr4G89WsCLbb/ZP5U7A1/P+wO+o+m4Jr+s0jetIuU6HNiPK2pLV2pPoZV5FfTONlf5pQAelvW47dqP4fkQAHr5cgLTo8spN0sQTlL9CaoGaW/+Hhn46dYldQ/WXYDkWqVhwKJegxVFlVR8y0CifYYf9wvgGklXkCU+qIWJRAUkCg32Sr9NkcZyJufW4SrtmifzO3ZYZ07dWZaEtrlSWpq/PNqam0xjTDpdFL6yrsml0h7dszAgbGVNXnHepCAqQrH+uWRE6ivL8M9T03T9b4xQrwOIgzLHlGDU/Tf+bcv6pTiZnF4d2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UmblhuZKYvHL5h1slSavwTVzyTtCnxNQQDsr42mAx8g=; b=jiz+SDAZb0VyevDQJbiFaxTYgjNKoUvPmfilmRt0IMd66C+MH+vR24i8w5cgO+24Y1+DQqVHcQ75jmRsDrTxNB4hHQf9dUnnnuz40sDOW54wPPcyHOdBWkHFFE0ZPWLyP74FQRN8vOPs8sU2DOxJRXFrh/OB0XtMB7xE9YrcHgBfSq5E5tBlxKXujV1Z44JxTdvhJXv9KQ2NF/W2KnNtWlWL88j62qtX8UO7TwhSYMIF4uHzZMQovBHlBYqzbAQg25mduNqGPZKXsAG8yclwWuEcAnEcEKohhvfiJH/b7waCSrX+ov8+g1S3j23HMvlu6cJMJLch2Jtj0fOsMKMyNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmblhuZKYvHL5h1slSavwTVzyTtCnxNQQDsr42mAx8g=; b=q1ntSiyUPT9xCEWOhat9k8Vc45Mqt7oKLbSo7DTIkqrxf1NVbVeisoxIkdo5pwIrfI4XIPi6cluEBD7FG+MKPTMIGSd9mzg1Lm7VCKQNzGrGjht/B3K3sOeXwIsIRoEbwrUw9gXTcEXvF8YYFo/YiFIy6/n4TBQbVeKIm/ZAO3A= From: Henry Wang To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Wei Liu , George Dunlap , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" Subject: RE: For 4.17 (was: Re: [PATCH v3 0/2] Move calls to memory_type_changed()) Thread-Topic: For 4.17 (was: Re: [PATCH v3 0/2] Move calls to memory_type_changed()) Thread-Index: AQHY0/KB5XPe3+0pEU6tJMlnQ9n+0632PsWw Date: Thu, 29 Sep 2022 11:10:44 +0000 Message-ID: References: <20220928141117.51351-1-roger.pau@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BF2EDA4F0ED47141AA97CD42FF157982.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAWPR08MB9805:EE_|AM7EUR03FT019:EE_|AM8PR08MB5604:EE_ X-MS-Office365-Filtering-Correlation-Id: 9399d22f-3c36-4982-bf1a-08daa20b4868 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IAVXN5eQaULaR2aJTX1UVRRqXTCi8Pxa8hs9YQNEP2fazC1jqs0sQnxM5ZbNEu6CHqiiuVwc9SVeVYQnPvl6maY4RueP9V8XicbtPZ/uQ24qZt6v14LNiTY2gWpm/T4azIKeehSGdskJbeiFxCMoj74VzGvOnT6zU/aXBaV4A+KhpQqC3bstpiaCjZWLFMJ+jV+yeOBMbgzjKWBK1aA7ZywNZpowUveJC708uHch1vCTaW5Mcao4IXbzZRDJ9e7pXpMp5XcbXoc+J2I+6NvcSM9arPlrpdvlbpzdImhVj4wTM0MhOeWWRlgaC87vXrMYnRhqq8bAhyWcZylSzBo79LrinKDkIOWZd7/5pxUSPpJF/52efUS9eYCoD8RL+dWRGV2UTStdDiypF3ZfJ3Aq/XBDFbHGGl88lMyguU6OY0h30BUn1kE/DcQfajT3+zxJwvXFV6a+7itJPbvEHp80Ku5XclW2QWL2gHh0YCRE2bh/uantlIoVdWr+oHvOI01v2Vsfr9YJZ2ESSd2p3QJdmKbfah+9PLAQ+aQef+gLniyECpPNV8+hNGAnaf5RrBFNWE+3CGxDIp++a/DYNSiQse/okRBpLaUgZ1z6RyuWH9JV8kvHMpdOTByfygY5Ar8AbieLitbbT1E0hFRaShJ1oMnRmFK0w7ynOnLeWneHww8lZuu3PDj6hNqJEcivEPSqBShtMzIGPeNI61xlqLioT/SEUmmkqFKkxQXuLENEoRplZDjno6l/S1QzeL23mg3okjPOfu6gwhLAVLwbcvB01w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(41300700001)(55016003)(7696005)(53546011)(6506007)(26005)(9686003)(478600001)(54906003)(71200400001)(110136005)(316002)(8676002)(86362001)(83380400001)(38100700002)(33656002)(2906002)(186003)(76116006)(66946007)(4326008)(38070700005)(52536014)(122000001)(66556008)(7416002)(66476007)(64756008)(5660300002)(66446008)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9805 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 22cb03c3-8a0f-4b08-0b47-08daa20b40d2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6XkAB7qP1tVi2DO1YFe5Oe5syoz5cVxSPoTr18tnwmxN0LqN5fq8mqio88yrOwhTYQJSThnl0f2ip2bpiL27RuFQLTwgiBmAtTI9FpQu0h5RqPYojwM6fAKBnCN2dSHanSb3IsRCqdf2Y8b5Rat8XOq6OKyL6ey/iCZvexfNLTSEplZUkfXYOQGap8R4djxxqSvztuxGYaKha8vQWwSaJC/oqENaT6X5RV0oj3/rnxhj4LAdz1zET6ZenNJadBBpO/XcfLGp4AWKE+WSDFWBiAx6Lbm30BQikOiiCXwrlsYTkjlKVgOWuDhenxFpcr7IinGKUCFhSR5w7JUxe9pVfzf4HqzcmuLAX731zCCGg2mmKZWgPbRleeQ+xb8xaS7HoajMFUViSWG3jkx1LdJy9Z/wRgy1VhH5RKP8W9V8GkGlZC48X7vgITOtVwUNgYCRnV5HwZQTPFVZBCXUXrCT2+E6hP8FD4rsd5nhtWHlpAWuYWuqinmvvKO2HxBQAy4/AGWiQoEXe/YlbZ12PFiGyKp45ioGxW1NS3ovxFrt+YUPx1iHVEU9zaF0lba1XdcCgxEtDGwi8fFFxymGX4QRzBAts/qsNn1GsemCPEpcmbf32jnLzMKYJf4rGUwgUH5H7hnA6BFYwhpfmUmdBggKeqSCNJKlHZjsKgIcgDfXWBDrJ5vtOwhSl9DBojUUmFgdHu+5IzuXBJ3w4fnXIdu2dlkPqu6W8f0oONC9AXgYgm/xrL/wCxIG7dmzyH8MnrwUcKGqBMV8jMV8YM08JLVYJw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(4326008)(33656002)(86362001)(316002)(40480700001)(81166007)(356005)(55016003)(40460700003)(47076005)(82740400003)(8676002)(110136005)(54906003)(70206006)(70586007)(478600001)(52536014)(41300700001)(2906002)(5660300002)(83380400001)(336012)(8936002)(186003)(82310400005)(9686003)(6506007)(26005)(7696005)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:10:56.8885 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9399d22f-3c36-4982-bf1a-08daa20b4868 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5604 SGkgUm9nZXIgYW5kIEphbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogRm9y IDQuMTcgKHdhczogUmU6IFtQQVRDSCB2MyAwLzJdIE1vdmUgY2FsbHMgdG8NCj4gbWVtb3J5X3R5 cGVfY2hhbmdlZCgpKQ0KPiANCj4gT24gVGh1LCBTZXAgMjksIDIwMjIgYXQgMTI6MTQ6MTBQTSAr MDIwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4gT24gMjguMDkuMjAyMiAxNjoxMSwgUm9nZXIg UGF1IE1vbm5lIHdyb3RlOg0KPiA+ID4gVGhlIGN1cnJlbnQgY2FsbHMgdG8gbWVtb3J5X3R5cGVf Y2hhbmdlZCgpIGFyZSB3aWRlciB0aGFuIHN0cmljdGx5DQo+ID4gPiBuZWNlc3NhcnkuICBNb3Zl IHRoZW0gaW5zaWRlIHRoZSBpb2NhcCBoYW5kbGVycyBhbmQgYWxzbyBsaW1pdCB0byBvbmx5DQo+ ID4gPiBpc3N1ZSB0aGVtIHdoZW4gcmVxdWlyZWQuDQo+ID4gPg0KPiA+ID4gSSB3b3VsZCByZWFs bHkgbGlrZSB0byBnZXQgc29tZSBmZWVkYmFjayBvbiB0aGUgQXJtIGNoYW5nZSwgc2luY2UgdGhp cw0KPiA+ID4gaXMgbm93IGEgcHJlcmVxIGZvciB0aGUgYWN0dWFsIGZpeC4NCj4gPiA+DQo+ID4g PiBUaGFua3MsIFJvZ2VyLg0KPiA+ID4NCj4gPiA+IFJvZ2VyIFBhdSBNb25uZSAoMik6DQo+ID4g PiAgIGFybS92Z2ljOiBkcm9wIGNvbnN0IGF0dHJpYnV0ZSBmcm9tIGdpY19pb21lbV9kZW55X2Fj Y2VzcygpDQo+ID4gPiAgIHg4Ni9lcHQ6IGxpbWl0IGNhbGxzIHRvIG1lbW9yeV90eXBlX2NoYW5n ZWQoKQ0KPiA+DQo+ID4gQXJlIHRoZXJlIGludGVudGlvbnMgZm9yIGhhdmluZyB0aGVzZSBvbiA0 LjE3Pw0KPiANCj4gSSB3YXNuJ3Qgc3VyZS4gIEZyb20gWGVuU2VydmVyIFBvViBpdCdzIGNlcnRh aW5seSBhIGJ1ZyBmaXgsDQo+IG90aGVyd2lzZSBzb21lIHdvcmtsb2FkcyByZWxhdGVkIHRvIEdQ VSBwYXNzdGhyb3VnaCBhcmUgc2ltcGx5IHRvbw0KPiBzbG93IHRvIGJlIHVzYWJsZS4NCj4gDQo+ IEkgd291bGQgY2VydGFpbmx5IGJlIGZpbmUgd2l0aCBpdCBtYWtpbmcgaXQncyB3YXkgaW50byA0 LjE3LCBsZXQgbWUNCj4gYWRkIEhlbnJ5Og0KPiANCj4gQ29uczoNCj4gIC0gQ2hhbmdlcyB0aGUg bnVtYmVyIG9mIGlzc3VlZCBtZW1vcnlfdHlwZV9jaGFuZ2VkKCksIHNvIHRoZXJlJ3MgYQ0KPiAg ICByaXNrIEkgbWlzcGxhY2VkIHNvbWUgb2YgdGhlIGNvbmRpdGlvbnMgYW5kIHdlIGVuZCB1cCB3 aXRoIHdyb25nDQo+ICAgIGNhY2hlIHR5cGVzIGluIHRoZSBndWVzdCBwMm0gZHVlIHRvIG1pc3Np bmcgbWVtb3J5X3R5cGVfY2hhbmdlZCgpDQo+ICAgIGNhbGxzLiAgVGhhdCBob3dldmVyIHdvbid0 IGFmZmVjdCBYZW4gaXRzZWxmLCBqdXN0IHRoZSBndWVzdC4NCj4gDQo+IFByb3M6DQo+ICAtIFJl bW92ZXMgdW5uZWVkZWQgbWVtb3J5X3R5cGVfY2hhbmdlZCgpLCB0aHVzIG1ha2luZyBzb21lDQo+ IG9wZXJhdGlvbnMNCj4gICAgZmFzdGVyLiAgSXQncyBlZmZlY3QgaXQncyBncmVhdGx5IGRlcGVu ZGVudCBvbiB1c2luZyBhIHNldCBvZg0KPiAgICBoeXBlcmNhbGxzIGFnYWluc3QgYSBkb21haW4s IHdoaWNoIGRvZXNuJ3Qgc2VlbSBjb21tb24gaW4gdXBzdHJlYW0uDQo+ICAgIEl0J3MgcG9zc2li bGUgb3RoZXIgcHJvZHVjdHMgYmFzZWQgb24gWGVuIGFwYXJ0IGZyb20gWGVuU2VydmVyIHdpbGwN Cj4gICAgYWxzbyBzZWUgYW4gc3BlZWR1cCBhcyBhIHJlc3VsdC4NCg0KVGhhbmtzIGZvciB0aGUg aW5mb3JtYXRpb24gYW5kIHRoZSBkZXRhaWxlZCBzdW1tYXJ5IQ0KDQpJIHRoaW5rIG15IHVuZGVy c3RhbmRpbmcgaXMgdGhlIHNhbWUgYXMgd2hhdCBKYW4gaGFzIGluIA0KIng4Ni9OVU1BOiBjb3Jy ZWN0IG1lbW5vZGVfc2hpZnQgY2FsY3VsYXRpb24gZm9yIHNpbmdsZSBub2RlIHN5c3RlbSIsDQot IHdlIGFyZSBzdGlsbCBub3QgaW4gY29kZSBmcmVlemUgYnV0IGluIGZlYXR1cmUgZnJlZXplLCBz byBwcm9wZXJseS1yZXZpZXdlZA0KZml4ZXMgYXJlIGVsaWdpYmxlIGZvciB0aGUgcmVsZWFzZS4g Rm9yIHRoaXMgc3BlY2lmaWMgc2VyaWVzLCAodG8gbWUpIGl0IGxvb2tzIG9rDQphbmQgSSB3aWxs IG5vdCBibG9jayB0aGUgbWVyZ2luZyBvZiB0aGlzIHNlcmllcyBpZiBtYWludGFpbmVycyB3YW50 IHRvIG1lcmdlDQppdCA6KSkNCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gVGhhbmtz LCBSb2dlci4NCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:12:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:12:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413638.657411 (Exim 4.92) (envelope-from ) id 1odrSS-0003Mk-Pz; Thu, 29 Sep 2022 11:12:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413638.657411; Thu, 29 Sep 2022 11:12:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrSS-0003Md-NB; Thu, 29 Sep 2022 11:12:00 +0000 Received: by outflank-mailman (input) for mailman id 413638; Thu, 29 Sep 2022 11:11:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrSR-0003MR-Hu for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:11:59 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83470939-3fe7-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 13:11:50 +0200 (CEST) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Sep 2022 07:11:51 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6625.namprd03.prod.outlook.com (2603:10b6:806:1c8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Thu, 29 Sep 2022 11:11:49 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Thu, 29 Sep 2022 11:11:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83470939-3fe7-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664449917; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=YHhBQo1nqW0Mu2OkQEJ2sy4knnmAYYis86Nw7yg4uPc=; b=ZuaEcTBVvVz9wX/gKh5XG0Ui/2hRVTKG4OD1CFSKp4236IxjriQZysSn /7CHkq28Bfy2zcQ90Qc2rHAoqyhsYyqXFH/rKqaUIym7PwOQi15XlDjfq HTvQPnUT0CU3EJcTdiKvrSPh6CyZKlvtwAkrsrM0V1qZpf2SVmr8Dz6DP E=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 84126404 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qJSmqqJG8gThWeihFE+RDpQlxSXFcZb7ZxGr2PjKsXjdYENS1zMDz WIZW22EOvaLYzSgLt5/a9uyph4PvseHmNNrGVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4mJA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbUn66VwKmh2z 8MzFTIhVA+pqLOS/73uH4GAhux7RCXqFKU2nyg6iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q/T/PVpi4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWbcqCzw3rOncSXTQYBDDeGa76FQvWaQmzwZLl4Sfnu/vqzs4qK5c5cFQ 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neLgtfoCDpHoLCTD3WH+d+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXrnUdJLAKOzyNrvFlnY4 z2Mtjl4uLwVguYCzaD99lfC6w9AvbDMRw8xow/RDmSs61ojYJb/PtP2r1/G8fxHMYCVCEGbu 2QJkNSf6+ZICoyRkCuKQ6MGG7TBC+u5DQAwSGVHR/EJnwlBMVb6FWyMyFmS/HtUD/s= IronPort-HdrOrdr: A9a23:pAHr7688VR9nRLzMoTFuk+FDdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.93,354,1654574400"; d="scan'208";a="84126404" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qzn3/WPWjBYLUqC9KkO8G7SK4JpiMZYL4vPizTsQlCo3KA+F1VNIal57dKmDKrVT2w2Z/6Z+mINVmj4AZrBLeORJbVnMN5kEo+DteLDwFh6ruSMCsecJgK+QcdpfvcWpl6BWxZOcoLeGkc9eu0oV2D11gBoIDPiFEfgqM9nlsrG7882mxlOriAq3+XVmlXGJ7XTYxyr/oNOEcKPa6PqvUI04uZC4bryCObVHnjQ2w4xpH/htEUZVEEDTTf/dd3TusZfLw20uRfbXqxglnpE0iNfwJ+Ti6nP4SeTSU+umoeNcL/+685UaBhk90EcrpVSqhM6YQrNGKEixUMfzFj9u4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4COfsltNZK/AWvNwM+XQ+1QAEOsZ+dW/FHxAu99r5M=; b=ElGYeODdXz7JaBpquI6oga9/kYb2bfsCmayWVyqQGdTIk0z7uM5o7Zws5nQUKfaPl1DyyKjVXSnm7Gay1xGMOyEfAp7OuJcvxicDQw81dsv5vdFQ/2wtUhHj1a6QrBk69AWJSjDnH3+J+mW5y22PoqR1l1w7/259YcCcTlFka0If0przW7XdQF90PJSRy3hMBe3nK52QPfZR488IlCGe8o09I59rAnt0g+BmSUUWho4pgXEh9qByMVGdwuDPZOixwAtvm1+wLG6t0q1aGiFOE35EuzvakvT47VVRT8gv5kvySbO70jEdiW/3oRY23Br3gNSFeZ5HdstYXEnY/Ay9vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4COfsltNZK/AWvNwM+XQ+1QAEOsZ+dW/FHxAu99r5M=; b=f/T++lc5wnuQXwSdvOGdvU5UkJj/iLWQYvNFIC5MH6DkiBsC1PJ+TaaqAWWYzHk1TiCPlHBtUprzwvFU2Nv+ZZzQZb5pM+KliOQEJ4JNN+SzABR/kIj5gkWzAe4ijF513E72+teOBa0jw0blgBblad/BQ3yk+4VcEpIZMDb6i6E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 29 Sep 2022 13:11:45 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Subject: Re: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests Message-ID: References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> X-ClientProxiedBy: BN9PR03CA0119.namprd03.prod.outlook.com (2603:10b6:408:fd::34) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6625:EE_ X-MS-Office365-Filtering-Correlation-Id: 157157ea-b685-40d0-df45-08daa20b66ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XS7mB7MIwxSHnmp0zEaM3zhWZZhOqPJGC8BJeosaeTcR49KGzwIMg4bx1AOs5pohU63xkhL1L4MkdoMxCqPbzrXrpfbMrDnqzzq5aZCzzZIEFxylCJ0LhnRkMt2r8bGt5zITVQ6eyWmyWmfoLUEkEOCl2LrKJgQF/eptxHpjbMesysPOcnBuxpXSV11L4FztI2mF1/u0NEexWs6ba8Hn7fxA1cgtNUurgXqhR7mdFj/B21/M1OrLtYB4fLEOPdhu0yhjvtbo8IFwKsohDo6TKQ4mufc70dohIkT7n9dIjKTBp1Zbn4sMAenCIAf7EMITKCFn/CK8wIBkO202Dh32JHhxjgwtrdzwITNPy37tKq9C9fyY3NETWTeQ6xWvuOxHk8QwSWw815p6/0X5tYSt6uk/bwLhtkLhFzkgcCjffmbCnOfdEFUOUvjvLsXEVcMLJLrQxyjuMbpRWkAzvQwiH7PzT1fEO+dBur4zzrPJuB56ewJxjDDh0McSvQb62aQD6FAicM030I2h1GOAE6zvgInN6b5KG2en1RNYwnbggxT80aNGuirpgbvQbYUNA/clkuru3Iy0v720gQdOeb6CsMbVgdwMwsMkgp+rAnO3NyuZU1Z0xj1DCfVmrXe8iuav2l1oKIOufcgjECas04BlI0JUHgATTaYJMoDFMsgBAPEqNgvrmPu3YL11ss+ODLLUMW7RYonm4IzCFkyrHY014g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(136003)(376002)(451199015)(26005)(2906002)(186003)(6486002)(66946007)(85182001)(41300700001)(6506007)(8936002)(54906003)(478600001)(4326008)(6666004)(8676002)(66476007)(86362001)(66556008)(9686003)(4744005)(5660300002)(38100700002)(6512007)(316002)(82960400001)(6916009)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlJJVFphRkhRYnJZV2t4MGh0aU5NRG1EdjhwSkhJeWZ5QmN1VnM0QUJNTEh5?= =?utf-8?B?Z3IxR2svMEs3TWo1ZVltVlNQV3JtYzd4S3hsSFQ1MW1oTlB1d285RTJxQ3JW?= =?utf-8?B?V3diT1RPaDdXSGpqS3dsdXNpMWduK2tSN2txY1lkQ2ZIeCtZUGUvNndWUGJy?= =?utf-8?B?bHVtZDdlTmRxQUhIMjR4R25hb2cxVzZmWklLWFlUekZETkQyTFFveENBQ1lr?= =?utf-8?B?RXg5QmZIaWRVaGIwdlJtWk1lSXppTmxXeVY1ZE8wL240N3d3eitsKzRSTjJ4?= =?utf-8?B?RHM4K1NrbEVhTUlUZUNJTlJEajVBSXRqMXBET2VHSURkTjRxUWRZZCs1eXhR?= =?utf-8?B?LzJrb0R0TWJXV3NEMCtqdFJ4a0JHT01CY1FwUjgrNkJoY2FKZElvU3NLSnlp?= =?utf-8?B?RDMxTCt1Rm9Sc1BIT0xmVnpkdWxhbi90N0VVVjF1b2FLYmhqY1hNRHRBemRG?= =?utf-8?B?ZmpSUnlqcjJsb3lzamg1bG9QSDRoQnBvUU1UUFJlQkVOcDFkdmN3UFpRMTBL?= =?utf-8?B?dHordXc1VWJ2M29ZUEk3c0lMRktSMHpLdE01VHdSNFY1NnJhYzk5akpHZmJ4?= =?utf-8?B?d3R5Smk1WGJWTTgxeGdzUSsxMytoaXNkNjRPZW00M05ZbkpwT3ZSdWFjS1h5?= =?utf-8?B?dXQ1c05XdlNxaGJyTW9mcFFyTEM5dFpTaXNCb1J0cXhUdGVoS2I5d3h1YjFo?= =?utf-8?B?d2YxV3hnTDlsMWZwelhUNDNLcWFNTVFZaWdRNFY0M2htQTllVE1TWTYyNGZ0?= =?utf-8?B?SDhocUFlYndrRUl4RUJDY0MzTmlYZzJtbVo4WEpZL0hMTEphS2tFeUY1NTc4?= =?utf-8?B?M1Z2czFIM29uNGE1bHJ1cjFCVXRXZVZpRnpDQS85MURML2N1bkxNTURodmFB?= =?utf-8?B?NTBUWFdmYm5XMFlPUmlJMU8zWW1Db0FyVERRSm5UdHpXbWgvR1gwbTZ5UVBZ?= =?utf-8?B?TldJS2RZNnRmRlZlK25kSlQ0RGdYWEJRQ0Z3TjF2d1A1U25WTlRQc29xZWhr?= =?utf-8?B?R01QWCtaN2liRFFMZVhUYW1Nc0QvNTF3WnZKRitrSWtmdjJodUxNeDh3Umxh?= =?utf-8?B?WStzRWszRjNnVUtJZW9SZ0FWUEFnRkRIeWFGRXhxaTk3RXoweDRyclUvQUox?= =?utf-8?B?UnhMSnhtVTk5Rk14YWdEdEhZcnRZeEticVpSdTA2RWRzRGhLQ1hHbHRSU05M?= =?utf-8?B?K2xITmI1R1ZCYTNMZjlrMElQTXYwbitOajRCRE9mREszQ0JDMjN0OVlFVUEw?= =?utf-8?B?aTdFUWo5czNHZXVxci9NWVNlelNoSTZ1VnlxWXZhZkdLM3JkWW8rZnlHZ1VY?= =?utf-8?B?OVdkVk45RUlJRGRleGk2M0J4YUJncEtNUFZGVHAzdWtsR3V6dmZvdytDeDR5?= =?utf-8?B?T2toZFF4LzliMjBMNU5YM3BqMmZQYWxYMmQ0ckVSSVJCTDRlSlhnbUJUSkIv?= =?utf-8?B?MnhTRjZqcHFySnpOS3crVm1WcmdYbHAwS3FkWGsrMmZLYXRoRXBsOXI2MVlZ?= =?utf-8?B?ZXFHWHgvZ3M4empxZFhnemZ5RU8yeDNuV1JyZEZJNUdSaUtpZThSWENaQ1JC?= =?utf-8?B?Z1J3R1Y0aDg1K1R4WWovbVE2YWxGdUJmZFNqeXZTOXF0YmlWeUJKTjNFbGR2?= =?utf-8?B?eHhZNUgyOVArK29CeXdla0Z2OFI1Nm5EKzl0bGxBVk5DOXJhSC9Gc1pQYUcr?= =?utf-8?B?RFlsY0Zad0RHMjJYdm9NSG9QOXYxaUlCTUxkSnpwdTVOM0srVVk3cEwxbTM2?= =?utf-8?B?OTVyQkN5RVl5ZlZQZ0ZLeVV3RDFya01QSkhMd0FDM1JGOG1sZXRCYTZvWUhh?= =?utf-8?B?N3p5VzRzbWdUc1NTV0lwUDEzMmd4SjIyY1AyeGpiaXloRDlXZUxKSVMrUHZv?= =?utf-8?B?UVAwaVQxa09STWh6NXJQUGV5THYxZGoxRkxQQ2g4dHppbFZvakpPek9BRlBz?= =?utf-8?B?dERKTVBWNkJUWVRpT293eFlUT1N6U1gwWUY5bXc4dzJyTHBDU0g1cytDNDNX?= =?utf-8?B?cUdNbFNXRXJ5TW56OGtkbnBMOGRRK08yYmFnanJLRVZQMEtmd0dSeTBrSWlI?= =?utf-8?B?R3pvcWxPSVJLKzJ0SWNzVXJSNGt1T24yOURuRGluRVFRM3RQSmxEZ1JNTVN3?= =?utf-8?B?VlNONFZ0OWJvWmo2T3lrSWRjSFBGWi9rU3M3SHdOemVvUkZOMG52VWozV0dY?= =?utf-8?B?T0E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 157157ea-b685-40d0-df45-08daa20b66ff X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:11:48.5376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SVxjYdgjlaStY6+Zj/eUIjNJuFlSsamJxu9t3sqr3I6Df7I/GjnsmwKNqo0itnNcc6Vfrkf1IVqVORhISHDN2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6625 On Thu, Sep 29, 2022 at 11:51:03AM +0200, Jan Beulich wrote: > With the "inversion" of VCPUOP handling, processing arch-specific ones > first, the forwarding of this sub-op from the (common) compat handler to > (common) non-compat one did no longer have the intended effect. It now > needs forwarding between the arch-specific handlers. > > Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné This seems prone to errors, I wonder if we should add a note to do_vcpu_op() to notice that hypercalls handled there need to be explicitly forwarded from compat_vcpu_op. I've also noticed that compat_common_vcpu_op() forwards VCPUOP_set_singleshot_timer to do_vcpu_op(), but that seems to be an useless jump, shouldn't it forward directly to common_vcpu_op()? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:17:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413647.657422 (Exim 4.92) (envelope-from ) id 1odrXC-00049N-Cf; Thu, 29 Sep 2022 11:16:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413647.657422; Thu, 29 Sep 2022 11:16:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrXC-00049G-9Y; Thu, 29 Sep 2022 11:16:54 +0000 Received: by outflank-mailman (input) for mailman id 413647; Thu, 29 Sep 2022 11:16:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrXB-00049A-2W for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:16:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32834d9f-3fe8-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 13:16:43 +0200 (CEST) Received: from AS9PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:20b:46a::15) by GV1PR08MB8258.eurprd08.prod.outlook.com (2603:10a6:150:89::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Thu, 29 Sep 2022 11:16:36 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46a::4) by AS9PR04CA0045.outlook.office365.com (2603:10a6:20b:46a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Thu, 29 Sep 2022 11:16:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 11:16:35 +0000 Received: ("Tessian outbound 86cf7f935b1b:v128"); Thu, 29 Sep 2022 11:16:35 +0000 Received: from 83a413327a4b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BE80D890-6B86-4121-8D1A-B5E767AB51BB.1; Thu, 29 Sep 2022 11:16:29 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 83a413327a4b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 11:16:29 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB8PR08MB5402.eurprd08.prod.outlook.com (2603:10a6:10:11b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 11:16:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%4]) with mapi id 15.20.5676.019; Thu, 29 Sep 2022 11:16:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32834d9f-3fe8-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NikX2UhJ6u9tmNp4B4/jqkLUo3DmAs9MxTjPKorpQnDEs7qpoE9VrNEARYhc2S01eMunwK2gOKzukI+pRnCN5KnEcK+sQ7zQ/ygVsDL6jV+gvZL6JUTjEvIkrzJ8kPVkTFEZUImLgzh/zAvzpE73b2JjgLx2ahwFD9LlzrJky9GmI6/KEcRLlTb/13yaGnml56NjIBDdimGQ+TF6NgglYcNojltrmoSiqXFBjLiVSb/xCpdNSZzJmzsXKKoxNzK4VblXfv/s+0xnSUq3qj1o0UoWCIEuFLO6nxFzebpt8kP9I1C59cHE0t4F0KuMjpLTRs7rom+dW6VXff3xJkr12Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nue1Q+h37LMaipuMDMdJFIXXqxiH4nrmJDPBE8izBvw=; b=OL1lcyuOSF0tOu6HGXvbjP3rDV1Hz6Ag3mvnVqYA/4FeKTmk92LjheG/QHAMQO8zoBPcEKZLPBRIjEcN5bF7T4/BsEBPG3K4TuisgZyJcjVOZrVjoScbJxZNl6keJ/3A6D3ginW0ju0/rdOfbTxdt2lmeXOz68nGoEDRxkN2XKn1FG80wWof5ox2+a8M6a8y0SC7ylstENrgGeFB108mUhqLLx8eRG/iedBqgjCN9/BSwGjvQUcUjrGHIqQzABHzH2C4q0PdOYwoo9rxW7jdllr1XYML7i++PlrzLFf7m/vY72j49Le1mGH7tLZDrSjLtthDWDDae22+HiRL0UTIvQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nue1Q+h37LMaipuMDMdJFIXXqxiH4nrmJDPBE8izBvw=; b=Vzs87Tqh6Bk5QYm+8Y6Zs9XQBYHuJPjgmAyjq3NiG1Y6a0c2UQxm4qPMlEnAmLJLiS34nBOaV8MgmmRN7JsnQQxTqn8iAYN/egctEpUMrN+ToMKAvGHx7oBkgoO8Ul+esna4qBN7eMxvhqgkeGCTnqndqZOYUzTe83IQh93VRlw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IX4Xo98LkfbjBU5fbbJx4G8JbBdym75wD8HAYhQ/ypEsxhzVXmCEWtw1dMgocxpb19asjvx+8vLdw2i4pK+nw0CqNv39B5X4N1OMv4MFvCUBxLOMcenJ7Vc33w+nD6y4eUHrTwJlS8XmqWAgUSGZ82+z1uHFRK5iO3KL1tgezBb0COLyP0Qnm1EvTNLuuDHYi7hTLvslFO65RYSNdxs1Eu8xYXuoxQYJ91eKEHook0jzCdpOfflDJSKRCI/yrYp/lYm2TpxGv33qa1WtC06gvlWX0q7lg0iWEhltwVwtET2tqQ+Vccs0wzdJf3mb2UXXsXUqhGoEWALPcXEi5S4mXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nue1Q+h37LMaipuMDMdJFIXXqxiH4nrmJDPBE8izBvw=; b=PYNCwImi9+Hr1G3NT5rak4q1lKhCSdqKO/uEoj3D7nOxKfAuV6oqqVrhciEaJOCH9Kg+wB8Tkol3PSzQzInqMMfDZfhl0lMgotu9qEZpu5N6rlcmGQgBf7MGTuqNnFtEU9GxUGuA3RSGxd5x3lOGrI/haY3pqsEx7ECuJxfqazDZCFrAn2oe5c7y5bHF3o1jxBD7CY1arrihFY13bD4J8th+Aep8GXpWBwQllIOlVofcadUWmRDcH/zYznFs43V23uSEU4fcQPut35gvUbkeB5QRcBYwax8HXbQVGwopDDx+yPwdHo4XrDbCKOfY3ZuSJwTC6LcV/wyNWcnz8XXN+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nue1Q+h37LMaipuMDMdJFIXXqxiH4nrmJDPBE8izBvw=; b=Vzs87Tqh6Bk5QYm+8Y6Zs9XQBYHuJPjgmAyjq3NiG1Y6a0c2UQxm4qPMlEnAmLJLiS34nBOaV8MgmmRN7JsnQQxTqn8iAYN/egctEpUMrN+ToMKAvGHx7oBkgoO8Ul+esna4qBN7eMxvhqgkeGCTnqndqZOYUzTe83IQh93VRlw= From: Henry Wang To: Anthony PERARD , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Michal Orzel , Doug Goldstein Subject: RE: [XEN PATCH v2] automation: Information about running containers for a different arch Thread-Topic: [XEN PATCH v2] automation: Information about running containers for a different arch Thread-Index: AQHY0+kahUHESaJZ20SwAAiPmBTh5q32QMNw Date: Thu, 29 Sep 2022 11:16:26 +0000 Message-ID: References: <20220926135838.47330-1-anthony.perard@citrix.com> <20220929095131.61034-1-anthony.perard@citrix.com> In-Reply-To: <20220929095131.61034-1-anthony.perard@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 363FA94BFAB6ED4D8BF0A401152DAA91.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB8PR08MB5402:EE_|AM7EUR03FT023:EE_|GV1PR08MB8258:EE_ X-MS-Office365-Filtering-Correlation-Id: 209b4fb5-67d4-4319-18cb-08daa20c1271 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C+Udl+Ty3c1bObCzEe5gYObfEgpYTZdUjhDRBKThbopgpN3esaiBQf/5/Zk0n+2K/UM37u4XSygONQdxAgH2GcyTSnIV/tkAVH2tWZRHvIEnzD2nmtGqYL1XBxB0qLrssQfcIyoIK58FLpd/aay+A1nVMutGL4ly1AzgR0KoQhU8TSvbjhjVOylePZfrX7z9bpdoX+bH8sD7SR/AqPxUDti7lrYFVfaf03RcS8ktpoCdTGJMXGU6EPYLLUy/9KS/wwGlqkX839BhTAO1nzUjHpzP3FaK18PFKxNdu8ABuH4G0cEjILoGiuS+kHGb9pMdtqiThswmns5I3vQxN4wGwMhgMvR9HQD9ZYqVGRcxv2oYyVBvYzxwdQgBX1bvMRI1JjzTpcJPAskGwp1WIJDJ66LcvOlJCVBrr6OR/3fxAjcEbxCgV53EJA0q/drGizJ2JxQhcVf1kaROpEhfxJ9uQIdk4Am9/NV+1TQK5Qn/2oaiw+XqcJvUSi2p9nnUxPCrPuxmVtsjZN5+8982EvZ+Vccz3bO9CfrisDKtM4eaBQbLDX77VXz0L4R5uaeA1rVHglJiwJkGFXVcN/dMyC2MB07U+qUVffVyp061zEZsivqsq0LZRJSgchFDh6sno8J7/smIceyhjyOoS61dI7g6qFUD0G0RN/VEyS+n2uUirIgTgBlysILxoUrf1GI8lFLnp1gwM6k++1OmXWjJIgTT2FsVePRikVoVHjEZnO1TbZdT0EminJK8cSdRtd3DIEZ6nlmOHnDPDJq/mLOQ7ffAx9M1hSiOkterv6E9w4xwlZoGRERPjE6wbtaJ/Ix2WtKa5fBnSWmJZQx3rlNJ15OPWw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(451199015)(83380400001)(122000001)(33656002)(71200400001)(38070700005)(38100700002)(186003)(86362001)(478600001)(966005)(6506007)(9686003)(26005)(52536014)(7696005)(5660300002)(2906002)(316002)(76116006)(54906003)(110136005)(64756008)(66446008)(66476007)(66556008)(4326008)(66946007)(55016003)(8676002)(8936002)(41300700001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5402 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba2842e4-624d-4150-3f74-08daa20c0d20 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o4OpQMzqnSFV/TdHlTyU2ugdMyLqZz6BaI23MX5+oKgesA850oPrtd3TAwE1QaIv4vPBrqkryfZy8tTVi7DpqAifNd/G5mEPlCXdollk5ki38MrNP00I5Brc3i9dCULPx9AxPdEQ0Uy5MlCxkAmP9edwgNeS1wAvfynCjYZ1s1AfscebdQrXBzA8F5RXmyoJANCUFT9LP3G4UG6mZTJ6X7lhlwNBwYk6UIpqTtkCh+614dRaRMcTj4co5PUI3u7Fe7G8wMz9A9YjNAxJ5HIAUQam+nx8ZSQf8oxjH8aEsebSr9y+bd6ktH1jW5/FyiVxzEZtOwAt6Uo/8fLsB6WEafMVoPK17FgczYRKwf7JTzg2YfLn+9NFzZzNTiU55/TyDS5YtAu6yj4p1YyuQLe/6Q6b+N3tEvcecyUtqpX1jCKfVq0UNSotQ3SP5sY5iIM5tZXt8E81u5UWH7dUUCMUbZBTDt8HPyp7HTjjaUb94Kq1dbr77K8da3iKzcAdWOSeFfXYkqsov1qrsBB3pf4sqJYDIykgIr87EdYolgED87gBLPZhohgR2Ls8wzt8Q4+VmkoCBlVxFm3iWIn91pvDH10dSPVAPnzjP+HqiUCOU6l3PDPwwHQQhl0H051QCaJ2ZvC/ZOHUSTasNd3bKJN9Z3MGUxa7k0/Mub9NZkHGhMLVwGuahW8LstMMr5gVT4vQX4ISK8b51bSsBvmbia46H8JFlSFxo9iTw8ag0k9eK45m04ooVC7YbVHAYKSShp1NbKkrQxhk2zw58HBnCn+X1x3ikFIu52l47v6cyQjEz5gtsfN5TOpBFemQTMzCE6eYO+ikq1l1x2/4cdL8nSsuGw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(107886003)(110136005)(40480700001)(33656002)(82310400005)(55016003)(54906003)(41300700001)(86362001)(356005)(52536014)(5660300002)(336012)(47076005)(8936002)(966005)(26005)(9686003)(40460700003)(4326008)(316002)(478600001)(7696005)(8676002)(70206006)(2906002)(186003)(70586007)(36860700001)(81166007)(6506007)(82740400003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:16:35.8430 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 209b4fb5-67d4-4319-18cb-08daa20c1271 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8258 Hi Anthony, > -----Original Message----- > From: Anthony PERARD > Subject: [XEN PATCH v2] automation: Information about running containers > for a different arch >=20 > Adding pointer to 'qemu-user-static'. >=20 > Signed-off-by: Anthony PERARD I didn't see the for-4.17 tag in the title but I assume you want this patch to go into the release since I am in the CC. Since this is a pure doc change and everyone can be benefited from this, so if this patch is acked/reviewed by CI maintainers, feel free to add my: Release-acked-by: Henry Wang Kind regards, Henry > --- >=20 > Notes: > v2: > - reword to point out that it's an x86 thing >=20 > automation/build/README.md | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/automation/build/README.md b/automation/build/README.md > index 00305eed03..4cc1acb6b4 100644 > --- a/automation/build/README.md > +++ b/automation/build/README.md > @@ -102,3 +102,16 @@ make -C automation/build suse/opensuse- > tumbleweed PUSH=3D1 >=20 > [registry]: https://gitlab.com/xen-project/xen/container_registry > [registry help]: https://gitlab.com/help/user/project/container_registry > + > + > +Building/Running container for a different architecture > +------------------------------------------------------- > + > +On a x86 host, it is possible to build and run containers for other arch= (like > +running a container made for Arm) with docker taking care of running the > +appropriate software to emulate that arch. For this, simply install the > package > +`qemu-user-static`, and that's it. Then you can start an Arm container o= n > x86 > +host like you would start an x86 container. > + > +If that doesn't work, you might find some information on > +[multiarch/qemu-user-static](https://github.com/multiarch/qemu-user- > static). > -- > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:20:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413653.657433 (Exim 4.92) (envelope-from ) id 1odram-0005Vz-Ro; Thu, 29 Sep 2022 11:20:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413653.657433; Thu, 29 Sep 2022 11:20:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odram-0005Vs-PD; Thu, 29 Sep 2022 11:20:36 +0000 Received: by outflank-mailman (input) for mailman id 413653; Thu, 29 Sep 2022 11:20:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odral-0005Vk-Nk for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:20:35 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50063.outbound.protection.outlook.com [40.107.5.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b83700df-3fe8-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 13:20:27 +0200 (CEST) Received: from AS8PR05CA0001.eurprd05.prod.outlook.com (2603:10a6:20b:311::6) by PAWPR08MB9541.eurprd08.prod.outlook.com (2603:10a6:102:2eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Thu, 29 Sep 2022 11:20:32 +0000 Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::a1) by AS8PR05CA0001.outlook.office365.com (2603:10a6:20b:311::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Thu, 29 Sep 2022 11:20:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 11:20:31 +0000 Received: ("Tessian outbound 86cf7f935b1b:v128"); Thu, 29 Sep 2022 11:20:31 +0000 Received: from 19d93a11e58c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9FEEDE0D-4B01-4EDE-87AE-F0A58530CD9D.1; Thu, 29 Sep 2022 11:20:25 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 19d93a11e58c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 11:20:25 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6582.eurprd08.prod.outlook.com (2603:10a6:20b:339::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 11:20:22 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%4]) with mapi id 15.20.5676.019; Thu, 29 Sep 2022 11:20:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b83700df-3fe8-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bo9/r33X2ATnXqtQKIklI8uWpfIOjx6DTiTw7TyZpKOYlT8sOUz2smV4zfGZr5raza7sTfw7J33UTeyBqGUXgl1PpO6GR2wLPQYJ2vSFRPodr5YskeIWG9tmdZNhuh84x5/JemG/L7RFWyseHOZcmtRuz8+UaRwLCmUUX7ixfqS8qMds57QEbuuZqLnev6kTjK0O2prwEU37XzUtyULwBLYzXdkaf+VcCENCS/EF4RzqzxC/caQIT2Ato7yAkqabV1xYu9K9jM5/iI35kfcUwuQspmvgQTaKKdWgj7LeJ+NAFme9RyZ5N8PxVupsHHNyaiH4S+/Ci7teAMqWOw7NfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HZ6yen5hHm/BGIZDZqAwbmOmKBPhJ4d/K7xEQF5KqbY=; b=ZlwW1TVK5wWTPJ3+0g8UeNFQiOYUkWXWnkr2gRnUgUXPVN3YrtHBguYW/YqtUpdAJt8f6loRkOc/GftgIyjlOJ9kDfozaVcmIEd0URtdzRdZCWiof1YZ2mZ/T1NI3Z5DmS+ST5HFPGuu6cuXVFM0u+tLelVP5ObTwKxVLFHNoVjGIBrH3m1udO1Ilc2Yb/FfmpGRScWVxOXZgzRlddhl1mp+ajk56lUMIk6mc6Z6aV3Dj4HHV/e2xVdavWERbrBxF4ulDMWUU8jPejDOYbfob12R70lITCU9Y3IjrhM+7N4gBAc2iHsEa4CpIWSQYt0THGef+iSMkCXuYFAS4Iw8jQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HZ6yen5hHm/BGIZDZqAwbmOmKBPhJ4d/K7xEQF5KqbY=; b=TAI1334HfFBGX/DDkYiAAXjzBTKg2E1C1joEfPFpnjKcJmZiTyhF2DB8qmPMvqdGHHrR8xsVvIaufDpxgUb2Yi/WiydW3FjB2U13PHOhd809aAQbsLXGGKmibx/H0FfIF4/jxH0TOVlpZaU0yti6Du+T2qwZzZJwT7aKb7G3WxQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/IvJ3z1TU4OrQLT4IIWSfFO2Y0+N68HQ74GV4OfctRVj2jMHasAxVUye0VUXRyhuwLfFWbThl2ts8pMA8aN5jpyHx+6+lefAwV500JkeH4dZC2cUwBOOhTIMRjoSGjtcotTuIuCUSZLEIqmIbIY79Ix7ZrOFEkZauBste2B7+VYXvFFLpT997eKzFNJfkrzxSR4Dh5xDnjYclaOqiFTPveVxu67K06PSqd6m3/C6G1DPwUcii3AJJGvQb7dwUk/qsZOOvpmtPuCeEqVE1kQJnyOdwhCbUtq+XzTvFJE6ppdt7lKlHZAxoDirCEFQv6nNESiPlgCcGgf2JAeUG7e/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HZ6yen5hHm/BGIZDZqAwbmOmKBPhJ4d/K7xEQF5KqbY=; b=TQChPkqVy4tv6lKexcBKKqIDdsDDLvmahba3EPipeTN6jP0fc+aocUKQomTPeKNIntYACIv/yDczArNBKWzGsR5UIaforeZXRy5xkG/Ff1/B6V+KPCsuIFsiq7JjTaEvedaDseEkmdyJwFyg7vxNrK8qsC9/E0xRtIHdUNnZxJGT5EctBAnnpNxvtGs/fvrIxF8nefBvv7w7usMgJZ7KjAwU7HEQOok+0Lj6W6b7MI+OWDjRgEG23Qb1YzT51+RX8ChC/lPYM9kPSdW8MKJqSOhMsmTGZ3xKM2RqOCtg01KktEZoZNXvQOfnRISTn84WwRMrDudFuF29l41RYekz+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HZ6yen5hHm/BGIZDZqAwbmOmKBPhJ4d/K7xEQF5KqbY=; b=TAI1334HfFBGX/DDkYiAAXjzBTKg2E1C1joEfPFpnjKcJmZiTyhF2DB8qmPMvqdGHHrR8xsVvIaufDpxgUb2Yi/WiydW3FjB2U13PHOhd809aAQbsLXGGKmibx/H0FfIF4/jxH0TOVlpZaU0yti6Du+T2qwZzZJwT7aKb7G3WxQ= From: Henry Wang To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests Thread-Topic: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests Thread-Index: AQHY0+kC7K8cMpFO9kiDPRVs5xcyXa32QqHA Date: Thu, 29 Sep 2022 11:20:22 +0000 Message-ID: References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> In-Reply-To: <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 019FA9DE7B0D9741AB5FD0DADF4D9CF7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6582:EE_|AM7EUR03FT033:EE_|PAWPR08MB9541:EE_ X-MS-Office365-Filtering-Correlation-Id: 09366daf-0c51-4bc5-c026-08daa20c9efa x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8DBTLhZzdqT/jzb767fwcjD7KY+Td/V18cSEZU3l+JueGCIVogCCP/+BtDpGHrGXw63nPuJRo5ctiVpuvoDS+sNjCp6ml5rN5Dvbtjn9tjAhnn/msptI9eoYYyDtHvPUQshEhaszRTYo2jmglAq3HL0R2hbgsqHjCGHNKG7noxolYBcp0CYYPIR9l8hVLz3CKO7qP8iwJZ0KP1nzVC5nQTKCAcY3p8QSyweK7vBbzWjmz1I90dI6VYxz7BRHsOi/qrohwqEMRU/veXtQ5x20E6IZQ1UFLz2EDKSIyV5wOhe6YoxO6PZvalP34bJzsrSy7byFQj9m+19dSmz3uwItFW44lWJ/4mzT2ou/PRnmDDo/0Rl/NDBXb4oGMI79oN7v4Ry6jFtmdL9YJfTkU2kHWcgTG2B1aCsQFiCdPqvXoAUHfRGpqashW/GA+IrYO/1t7RrvzHTOAeR7ZmaWGrRMSqqdcNGdCnHnsml/ddtoJoHeE4TNEuumzLMSKBN+ddC0Ml6BEruFaN4FC77zzn+lieHLevbRQzMGUMM3bflAlNW+1A5alTL2xQuWykwKl1ATzxvJHnInrZJOe4FneQflgXdwIM6REI3Mv3RnDEKqwB48WtN0ZWP6GWPbgRcvKEEcylLbSbH+0TYJyEzvJ02RemDI3LrXPwxKT7BkpewdOL0foqTB7mAH+R0I3J+J1hcs76loHhBwOqJ84mynR5S8yUN2KJhAsbR/L2FvFQgAHgwkdM1E5Q1OXjukZGGUCDQubikrjSidSO1QFFRuQ608Gg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(396003)(39860400002)(136003)(451199015)(122000001)(4744005)(38100700002)(38070700005)(86362001)(55016003)(33656002)(26005)(5660300002)(6506007)(41300700001)(4326008)(7696005)(64756008)(8676002)(2906002)(66476007)(66556008)(52536014)(8936002)(66446008)(478600001)(54906003)(110136005)(76116006)(66946007)(316002)(83380400001)(9686003)(186003)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6582 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 51fb5a28-49ae-4496-9ff0-08daa20c9987 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iw2qGVTtmnFYPyr9l1937eF0+k3hIMLb2uW7M5t74oYYZRnTp+pzNatMPcfRnArW5UiVskqZcHTP3IE72xJcu1SU2uz1k/BoWG+HA5MBGfqJRZfSgZNymjNcNGjy3q17o4q1l4pbDf3yABV4s+M28Ofa1SFiWTtBqMm+AijKkR2n7vg8BRAFHCTC6sPb1aW8CfiKHVOdyrBA2JiZMxOwrWzoAw3nfm/qllHbsswwkkJNzZi+gYgjOlFiC9Tm6/2CA1ggiFSovixlgGX9DAQDs8T1Y8pufuylHAL61GpDwC5Zlli0DiTSnIqjz4EkVvfUkbq/EbFRXZ542PqVmeZzYRZsyHm9JQnffS7dVbem2MsWF97axsSgmmsVQBIuRdO+QYGKwFeUK2GsjxzwW3mAVIxG8oy/+6Hl22HUMrY22At+eaGA7y0Avxpsezt+dtgIZl6ogDcCU5F0Y+AUDAbHvulSYYRPbXT15gQhNVRaPe+/cHrd/budU+hd1pBHYUPZ/Bu9ghG2oNO7oCTdv1D//w+KH+TTgi4rhNk+agL5zrVcuAPlNNV5BQvAkozi9inoh/tROq1Q58utXaRGVu1XlmJYVXVrtlx+1xc+xfx8P/KjGFIbFfQsJf7FCGEyIpidlX7yhjt2GtjfiBnkzKfa4GUWsr6Z7gA0i029bPvc6TpjCCrhmh4VYFgH0BSjqE/CrhrL/kATXM+TMHSE9BHfAy96hpudf8TbrgCfJdDF9kFqNv5lgBSXq52C54gOySqSgEwS8zPNK8jMIMYh+ZWlKg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(41300700001)(478600001)(8936002)(107886003)(40460700003)(6506007)(26005)(9686003)(7696005)(5660300002)(110136005)(55016003)(2906002)(54906003)(40480700001)(86362001)(4744005)(316002)(82310400005)(33656002)(4326008)(8676002)(70586007)(47076005)(70206006)(81166007)(52536014)(356005)(83380400001)(36860700001)(82740400003)(336012)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:20:31.6262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09366daf-0c51-4bc5-c026-08daa20c9efa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9541 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIDEvMl1bNC4xN10geDg2 OiByZS1jb25uZWN0IFZDUFVPUF9zZW5kX25taSBmb3IgMzItYml0DQo+IGd1ZXN0cw0KPiANCj4g V2l0aCB0aGUgImludmVyc2lvbiIgb2YgVkNQVU9QIGhhbmRsaW5nLCBwcm9jZXNzaW5nIGFyY2gt c3BlY2lmaWMgb25lcw0KPiBmaXJzdCwgdGhlIGZvcndhcmRpbmcgb2YgdGhpcyBzdWItb3AgZnJv bSB0aGUgKGNvbW1vbikgY29tcGF0IGhhbmRsZXIgdG8NCj4gKGNvbW1vbikgbm9uLWNvbXBhdCBv bmUgZGlkIG5vIGxvbmdlciBoYXZlIHRoZSBpbnRlbmRlZCBlZmZlY3QuIEl0IG5vdw0KPiBuZWVk cyBmb3J3YXJkaW5nIGJldHdlZW4gdGhlIGFyY2gtc3BlY2lmaWMgaGFuZGxlcnMuDQo+IA0KPiBG aXhlczogOGE5NmMwZWE3OTk5ICgieGVuOiBtb3ZlIGRvX3ZjcHVfb3AoKSB0byBhcmNoIHNwZWNp ZmljIGNvZGUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j b20+DQoNCkZyb20gdGhlIGNvdmVyIGxldHRlciBJIGZvdW5kIHRoaXMgaXMgYSBidWcgZml4IGZv ciBhIHJlY2VudGx5IGludHJvZHVjZWQNCnJlZ3Jlc3Npb24uIFNvIEkgYmVsaWV2ZSB0aGlzIHNo b3VsZCBiZSBtZXJnZWQgZm9yIDQuMTcsIGhlbmNlOg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5y eSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:28:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:28:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413660.657444 (Exim 4.92) (envelope-from ) id 1odrij-0006Ks-Qg; Thu, 29 Sep 2022 11:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413660.657444; Thu, 29 Sep 2022 11:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrij-0006Kl-NX; Thu, 29 Sep 2022 11:28:49 +0000 Received: by outflank-mailman (input) for mailman id 413660; Thu, 29 Sep 2022 11:28:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrii-0006Kf-MS for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:28:48 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10080.outbound.protection.outlook.com [40.107.1.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de22d551-3fe9-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 13:28:40 +0200 (CEST) Received: from DB8PR06CA0047.eurprd06.prod.outlook.com (2603:10a6:10:120::21) by AM9PR08MB5969.eurprd08.prod.outlook.com (2603:10a6:20b:2dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 11:28:45 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::b0) by DB8PR06CA0047.outlook.office365.com (2603:10a6:10:120::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 11:28:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 11:28:45 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Thu, 29 Sep 2022 11:28:44 +0000 Received: from d85168a4fb85.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D43FDDE3-4EE3-47DA-9C54-439F74430800.1; Thu, 29 Sep 2022 11:28:37 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d85168a4fb85.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 11:28:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5592.eurprd08.prod.outlook.com (2603:10a6:10:1a8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 11:28:35 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::10bf:2915:c966:b45a%4]) with mapi id 15.20.5676.019; Thu, 29 Sep 2022 11:28:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de22d551-3fe9-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RCMxNK11gWgSQ1PQzq/mQnWn2vfBlxlU6pyKIcaXT3kspkF4apapAVPKIeRZ/savfi5IHWUrHdteJlV7yALfQt0Eya7P2jV1UUsqL7lHAF5+fawqrBi+a3xXSslDVycnIzCwtm+czW/DASqloEtn+wwzkI3Bh2Wy/TTNijSTqYfGqcUAtCwBLCvx/J3vvXzyiC4OgvkP/1/rh1SahISOMvWfbXYjno+Xf1wp/p7YTEg5DiKWp4qOXPl1bHpZyWQQao1NaA+DRpaTpjIcK3onKaR4ODYVbJbZ3H5BoHC7IX8NMjAWTVzwt7dmC9AT7vxoQoyoDJsHEhWUdkY7LwOFrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+626US4mQEEhB7vlL6+Yu7x2uTa5CoTKT1x0hMiyn4Q=; b=cMkGzk7FcpFlDGDGh10SL0ram2AWCqRFqIONtOr7PtPgutwuRC9FF9JJ4Z87KmTc+5Retiu+VHcfqJMPACCwfb42EfSB8DbMLciPgsGqGoJgRw1DhebhrdLuKr7t3Pkr29CzkJjXtrVuTPKlet8SiGNM3tXr839SugC5NaVyUJstCAWq2Ub04AtB9WmjgrRdQLixK+2TwKtCn9C9UMr0o7i1cMUpCg2NsZtF9qqZACv2V+zXt4PL/oswnZ7jN6kNv8+41UJ2RnurMBI1TDBcYiPmfnQSo/1+FDfaLJsriC4TpC44CPTZD/z2QmzQt1s1dTt08Cbi5W/w3m7rAEBprg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+626US4mQEEhB7vlL6+Yu7x2uTa5CoTKT1x0hMiyn4Q=; b=DRPvzPw4KbBKmenacpTYIbaF7Id9TkaKterSo8f2xQZk7emgWt4CBK/eLo0YOGW9YSfJt0CM2D5L63Th0UQ++Ltc8zptNAm7BKaeEAPFUXgAy6ohTmzYrb0ymTtZxpp7jP8/siAKnDYlx+gOYjPa2dEmHyn3QVzflTpd8MgpS8g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ws4UuZAA6g8+RIV0kGGpqNNoQkYcJ3B99+AvDjdijgM9RIGwPSK+WT5d0k8WTP3qRLpzQLOrD5E/sxRlrOG77vOcudBk39DtgWzSBMfbzhhJ7wajb+Boh/T65rY7ZXhp94TYGi8aT24LN/sYgf0pBv+6TanTobFeMKW1Oa0mh9uZgOU/6jOdS43uaDxXgmJeiT6nVV3nz8fHWGC+lkhZUKRvSOrs3g+ZM5CoUyxq4sX9dZ1RebkQMJIhwwVyJ7lSGs24PVkCcR50Dv91D3DyA2FA2Ki1RpptyhQKXFW9SyneV0wG0JMDBQcu35yVNTHQTffE9/RtfE8kBWauquI0gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+626US4mQEEhB7vlL6+Yu7x2uTa5CoTKT1x0hMiyn4Q=; b=csd1Y2lrQW0BGcMZ5+WcNo2aIPZrITXVe5zJ+TzGAtmUlJUlJxTRXDk6M6HHTKBSy3MdK7ZR7+3Vz8irQ9zsIICJKB3aHlAstUEJtSePl2F/5DLHRMwNGDVvqaVv61NWIOGyWq48N7rJibftwwHPb0p5H+ajHIszOpLu1H78Gz77i0zd7x3QjGYuffLHJYspU+WnLXxDXiKUFcTh0AbqXTB3q0pRNzSf8heAUqj9rSrKK7SgehF//6VoqULg2dH+GdSEPqZDHIu0wfNPrXzbkFnqC/Wp7MLS1jeGU+fOm+/0sdVgsPSkclGq0Cs8B0X3Gz/UfBdug27XY5JK1kSt6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+626US4mQEEhB7vlL6+Yu7x2uTa5CoTKT1x0hMiyn4Q=; b=DRPvzPw4KbBKmenacpTYIbaF7Id9TkaKterSo8f2xQZk7emgWt4CBK/eLo0YOGW9YSfJt0CM2D5L63Th0UQ++Ltc8zptNAm7BKaeEAPFUXgAy6ohTmzYrb0ymTtZxpp7jP8/siAKnDYlx+gOYjPa2dEmHyn3QVzflTpd8MgpS8g= From: Henry Wang To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [PATCH 2/2][4.17?] x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Thread-Topic: [PATCH 2/2][4.17?] x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Thread-Index: AQHY0+kbd8ERHzF1s0C8/K+O8mIiH632Q3hw Date: Thu, 29 Sep 2022 11:28:35 +0000 Message-ID: References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 78E6713D3868284CA0A88DC2D91D6405.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DBAPR08MB5592:EE_|DBAEUR03FT026:EE_|AM9PR08MB5969:EE_ X-MS-Office365-Filtering-Correlation-Id: e18d25f4-05be-4860-1930-08daa20dc50a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ftd2pi7ucwdBA2g9lPQ81M81xJeYLa4xw7r3MrlgyfNb9TclPJAsTnb0ZuEJFG3eAKlEDwAA/jPx8qrM+9GLs0JPq1AiHKSAssS/qq9IWDew5nzt3OZjKapXy7h/fg37MEVSZzux2feleYE0WBwE0EgOKukdL5n4ukvjmVeA/WSHy8oyKeZzrlAKLRePFhVEMxT345s8oh6uHhZKLxy0+SBts2hquh1op6t2GS4Dz5hquGdwv4Pp1qMekDMjSB727960rI68E1K59Tu1unRoL2SraGcvSoxHT1e+mL8UldOon2W+7+HjYnG8r/Vi9/HTnUgKIu2PqlhJbU3lX6E5y5TWGDB1IwB3c2i2C5EfuiO2tzmZY3il/uTJVtnEthTltmTH99wsiIrRKDGdBaeU7GW+sZxrQ9jteqfdEP4kJV/Ok8UhEe2uy1S87h0AWHFOyCveJQc55yEs27SU8LwxNNgBnyY6XA7YW5/IMn3Mf8NV1Y0lG6PQOBsJuYbRkjzs4pohCHfUREgmIr866GpOs18uawMtfxcKErWopAQr9haUz8apSF5sH/SxvEVkVkcipBh7UvmLiAUoF6U2yn1qjibINKBFu8ubHsxxfjbUmwJpqvjY8zsLqVENZC/xrrmK6I1G7Mdexk1Wt07+Qy6CH+m5D44U7VDd/NH4rZ2L4pObAvxH6rxT4MZ0dtSAWSlm3nG0CiZi8mLaz7hlm7q6HQM6lHBKVzL8Vm5qjROiY2EPhI8Z9k8dlf8Yw5eYcnWHJd0Vl/7eJdmc4Z431gModQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(451199015)(66476007)(86362001)(478600001)(38100700002)(122000001)(83380400001)(38070700005)(186003)(52536014)(41300700001)(66446008)(8936002)(66556008)(2906002)(9686003)(64756008)(66946007)(5660300002)(6506007)(4326008)(76116006)(7696005)(54906003)(55016003)(316002)(110136005)(26005)(71200400001)(33656002)(8676002)(66899015);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5592 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 81ff1b17-4cbc-4521-3d64-08daa20dbf60 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y3SdjBUg2Dyki9brQK1hcgyshFC/wKiFAjCSIAvxAC1Y8HUdxltppgLGOIT+7MqUWKeYnuNzauvMKnxZr77mFXp/Z4IUnjRY/iLNVx4dvAMISvnPD/4Wwbc8doIN5mEHk4pYRImUgmMPOp1z4DsMK72oTKv5HoZxWj1OVnUbLzeHAynz9MrTM0F85gc4BZKGMLNAfbmfzXnIv5Hf9kaQl975uRY/n8uK+fShbxReUgoHGaG9s08X80pmhWrYEroJJse9ijDIXmbu40SvTG4NKuAXKMa7zpwRW4u/IeTcvYlkexvGcl5an4WG2w6r/xaf97EP3Tmn9g5/G2lAXJOo773bCrWQfdBVwPK2t6DjwAdQ+OnD5KPTddJ61zjK4L8HXtZ0RjNTMqIdV1ylIZOqiOEXk9PZBCSu1D2ietkC5utoJs3wJS74RloyT7VQMUH8l3qgFKFxF2PHnqAZ5psguOAv9se1nlBsYHczjTHgdwrBZe2b3K4JlKDz/qJv9JnYVs+Np9JvPKyXcqID4CWSi26+wmWkZVEiOIOTQ5Iu7CLuiLTwwFybcViICdE/H8Q9UBC5NvxrdpbUTF+7Y89bx/Q6T2RJwgpK9pybJpC2OkHL9KzzkIHo02jAADeMJdzAuVLUiVSQ6hHdZ3dS84gYc7Uxo+vN/ZrxKn2RILmmtyAvcbVdLGM3lc3VT69I+rmiZKBpiwcSa4GuOumG0kQ6jt33LmFYTnPdzDrvgF8aODhTxpFEbf5aRlpe+cPhlVBv/If+93IoZKjg0xZFArCvHg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(40470700004)(36840700001)(46966006)(66899015)(336012)(47076005)(82310400005)(356005)(33656002)(40460700003)(81166007)(5660300002)(26005)(6506007)(107886003)(41300700001)(8676002)(4326008)(7696005)(82740400003)(55016003)(86362001)(40480700001)(83380400001)(2906002)(186003)(36860700001)(54906003)(110136005)(9686003)(478600001)(70206006)(8936002)(52536014)(316002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:28:45.0238 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e18d25f4-05be-4860-1930-08daa20dc50a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5969 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIDIvMl1bNC4xNz9dIHg4 Njogd2lyZSB1cA0KPiBWQ1BVT1BfcmVnaXN0ZXJfdmNwdV90aW1lX21lbW9yeV9hcmVhIGZvciAz Mi1iaXQgZ3Vlc3RzDQo+IA0KPiBGb3JldmVyIHNpbmNlZCBpdHMgaW50cm9kdWN0aW9uIFZDUFVP UF9yZWdpc3Rlcl92Y3B1X3RpbWVfbWVtb3J5X2FyZWENCj4gd2FzIGF2YWlsYWJsZSBvbmx5IHRv IG5hdGl2ZSBkb21haW5zLiBMaW51eCwgZm9yIGV4YW1wbGUsIHdvdWxkIGF0dGVtcHQNCj4gdG8g dXNlIGl0IGlycmVzcGVjdGl2ZSBvZiBndWVzdCBiaXRuZXNzIChpbmNsdWRpbmcgaW4gaXRzIHNv IGNhbGxlZA0KPiBQVkhWTSBtb2RlKSBhcyBsb25nIGFzIGl0IGZpbmRzIFhFTl9QVkNMT0NLX1RT Q19TVEFCTEVfQklUIHNldCAod2hpY2gNCj4gd2UNCj4gc2V0IG9ubHkgZm9yIGNsb2Nrc291cmNl PXRzYywgd2hpY2ggaW4gdHVybiBuZWVkcyBlbmdhZ2luZyB2aWEgY29tbWFuZA0KPiBsaW5lIG9w dGlvbikuDQo+IA0KPiBGaXhlczogYTVkMzk5NDdjYjg5ICgiQWxsb3cgZ3Vlc3RzIHRvIHJlZ2lz dGVyIHNlY29uZGFyeSB2Y3B1X3RpbWVfaW5mbyIpDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IElzIGl0IGFjdHVhbGx5IGNvcnJlY3Qg Zm9yIHVzIHRvIGRvIGNyb3NzLXZDUFUgdXBkYXRlcyBvZiB0aGUgYXJlYSBoZXJlDQo+IChhbmQg YWxzbyBpbiB0aGUgbmF0aXZlIGNvdW50ZXJwYXJ0IGFzIHdlbGwgYXMgZm9yIHJ1bnN0YXRlIGFy ZWENCj4gdXBkYXRlcyk/IFRoZSB2aXJ0dWFsIGFkZHJlc3MgbWF5IGJlIHZhbGlkIGZvciB0aGUg Z2l2ZW4gdkNQVSBvbmx5LCBidXQNCj4gbWF5IGJlIG1hcHBlZCB0byBzb21ldGhpbmcgZWxzZSBv biB0aGUgY3VycmVudCB2Q1BVICh5ZXQgd2Ugb25seSBkZWFsDQo+IHdpdGggaXQgbm90IGJlaW5n IG1hcHBlZCBhdCBhbGwpLiBOb3RlIGhvdyBIVk0gY29kZSBhbHJlYWR5IGNhbGxzDQo+IHVwZGF0 ZV92Y3B1X3N5c3RlbV90aW1lKCkgb25seSB3aGVuIHYgPT0gY3VycmVudC4NCj4gDQo+IEknbSBz dXJwcmlzZWQgYnkgTGludXggbm90IHVzaW5nIHRoZSBzZWNvbmRhcnkgYXJlYSBpbiBhIGJyb2Fk ZXINCj4gZmFzaGlvbi4gQnV0IEknbSBhbHNvIHN1cnByaXNlZCB0aGF0IHRoZXkgd291bGQgb25s eSBldmVyIHJlZ2lzdGVyIGFuDQo+IGFyZWEgZm9yIHZDUFUgMC4NCg0KSSByZS1yZWFkIHRoZSBn dWlkZSBmb3IgcmVsZWFzZSBtYW5hZ2VyLCBhbmQgaXQgdGVsbHMgbWUgdGhhdCAiaW4gZmVhdHVy ZQ0KZnJlZXplIGFuZCBlYXJseSBzdGFnZSBvZiBjb2RlIGZyZWV6ZSwgYnVnIGZpeGVzIGFyZSBl bmNvdXJhZ2VkIHRvIGJlDQptZXJnZWQsIHdoaWxlIGluIHRoZSBsYXRlIHN0YWdlIG9mIGNvZGUg ZnJlZXplLCBjb21wbGV4IGJ1ZyBmaXhlcyBtaWdodA0KYmUgcmVqZWN0ZWQgaWYgdGhlIHJpc2sg b2YgYWNjZXB0aW5nIGlzIGhpZ2hlciB0aGFuIHRoZSByaXNrIG9mIHJlamVjdGluZyBpdCIuDQoN CkhlbmNlIEkgZ3Vlc3MgaW4gY3VycmVudCBzdGFnZSwgSSB3b3VsZCBub3QgYmxvY2sgdGhpcyBw YXRjaCBmb3IgcmVsZWFzZS4NCklmIHRoaXMgcGF0Y2ggaXMgYWNrZWQvcmV2aWV3ZWQgYnkgb3Ro ZXIgeDg2IG1haW50YWluZXJzLCBmZWVsIGZyZWUgdG8gYWRkOg0KDQpSZWxlYXNlLWFja2VkLWJ5 OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5 DQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:32:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413665.657455 (Exim 4.92) (envelope-from ) id 1odrmj-0007kk-Ai; Thu, 29 Sep 2022 11:32:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413665.657455; Thu, 29 Sep 2022 11:32:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrmj-0007kd-7v; Thu, 29 Sep 2022 11:32:57 +0000 Received: by outflank-mailman (input) for mailman id 413665; Thu, 29 Sep 2022 11:32:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrmi-0007kX-JD for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:32:56 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75cefc35-3fea-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 13:32:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7971.eurprd04.prod.outlook.com (2603:10a6:20b:234::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 11:32:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 11:32:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75cefc35-3fea-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTsnRs6Axqqt8YPX3oDUz9pwkC/7LH3wKjBfM4/06+FNzkuqhb2yDePGkKlv/imZVUMMtNhy0OadqIY8Y9E8Ov6aVwYHVIld/1cJcr3xHPFrOmjP7RfPCcY6N+isnCPExW6mJHaaQyFn5GFBmvyzbKS6xq9dRjJOipnSwgXhhgDr8U9aTAJUHqZYeZFg2zrAkD3xsz8DCRBm3AAeczVSuVPhLB3ymBlFz7vO/d/FICQDJWJXegCasy/FBo2u8l8VmTmHDjDpcAsKrCCbKYSjkRFeAwanePgWXWUYGVsm/86mW6+ruJMnfUHBa+Iu+rcoNvWZ0yQk6GMWmbRh2I7Tfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3e8biq75uQu/4U7m+07C5R7B/p4UnYz5av0tcBksW6I=; b=jRW2SMfJVJkpbnRB4DFesDhVCZj5qRiW8k2LzFNpcdnXJ4jNfd3ThO2MeuVP0CUlDG5EsrEYb9zJ9QhU9m18gu3zBsXPI/iXqFWwd55iauAnIWuvE4+J5PDVTYW7K+lE3pqdUbXaMlHczHniE/aoKLSkzVonQR/Geq2bA/7eKXi8NsvCz2cSXMr9LIezlVBa0xNPfdL+nHucWsK2Rks6O16QEhFkCcdwLWpJf1rks1I5lmkDcnEYkq3cKRqUWp9uN8HjrAIDnQDBq1uo57dboHWV2K91ladeOK3pqUfhGqtYfwqOe/QWnKZTM1r1OvxAeu3fvUK5/LnrWzkVGTsUDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3e8biq75uQu/4U7m+07C5R7B/p4UnYz5av0tcBksW6I=; b=h0BhWPkXEo8KdQogHx8GWxHZByz9m4E9gPhpQZWpAu6gasV6QinAjLoSU3p9vOe4LKja2JaA2qhmjVjsaNdcGw5aTrYcfyL9K2Mg8jw8BBwuH+XyhvMExL5ylxzkCTbWAgRT1lxepkZpOOQNBOgJ9xWTgPkI2hiSUD1LhzbGDzNs9DFWaArWq4oVNsNgAZwWHalWaLK10Fhxzs1lrJoYGAo1k3k9UMtHhO2ncGidsiC997aUh1vCgRFgp2I7K9emsl7Z2z9cENEywfsZys/1gB/+pKEy8UU4K1BvcRzPNir4zDqedKh6rsz1C7tjLaURXT+uC3DfinhOf0ldrItcag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> Date: Thu, 29 Sep 2022 13:32:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> From: Jan Beulich In-Reply-To: <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR0601CA0072.eurprd06.prod.outlook.com (2603:10a6:206::37) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7971:EE_ X-MS-Office365-Filtering-Correlation-Id: c1127a95-e1a1-4676-a070-08daa20e58cd X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KYqFDHe8u7Ijczu0v24/xeXTDqq6HchmS/X5d5ynI3RUsIJ0LIYB+ZptbQl/U5Yw852ahr8PxJ1fKV7DEVt5xy99/PQa4OOnXhKo0mlTshvENEAwH5tnlbKxlEfFue0YtPJ3tEzNF4AI6SnY+NDQI8LhgOglXIDlTXZu5xAKwiLGo343s07xJdD7PvJFxakVVSXLg9foqAbUMOm+WCGuDl9jVGapEWxAu5WltIN1whN84HII7QJEjVcps6LRMehuDMVZko25GehpuZ/jZVaE7ULjTkTWOrHnahOHhJ2OSHRPyjg3QGzWwkf5aFwPxWZ4sL0zaML64AK+o9yULoSi5/96mLM5VuW3o2WZc5roiHYpCPg38zhmsUpyy/1IIqdKk0vsVbCdcDizo8mihEVgomol4tsSGjborgoqMlCZZhK7s4rUOYr7xKmNhl/hGapCmKGEQ2Bri/9+/iOutsa9Kfh6FaR0/LvOBRElSNeG5yHTd4XshMM6kRbwiafFRjGrqxsEP6asb8rX9RQF2MyTRQJoY+vienXlri+I6jVSW4hcbzKNBmMG0oSWWSuBGv6W+QtFhWQ67Oa8u9N3xNrK9AG6Cjsr104/hh5K19T6K3IZXKd/0AwDt6Die4uPJxgHeAwcqWI05lXoaVKvlmHfNCVkAUpyJQRkpOrYRz2Kcr0UrO17j+3ogmJgRyP+RgREhJ1w9BUQcyuRJBwoBIcHbSdruaY4B2q4i+s0dmWQdle1yP9ZbCcIRk7DaTyoAtejultRdN4KjwTu6nFrFgLUF0siTH4EIwPnxaqOEF6W1TNBVFl55hOyzm0WuvtwVKfEzaWvwbFHsKCaAQr8FciBiA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(346002)(136003)(451199015)(186003)(53546011)(2616005)(26005)(966005)(54906003)(6486002)(31696002)(6506007)(478600001)(6512007)(38100700002)(36756003)(86362001)(83380400001)(5660300002)(8936002)(41300700001)(66946007)(66556008)(8676002)(4326008)(66476007)(31686004)(66899015)(2906002)(6636002)(6862004)(37006003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1RXWVE2T2VlYk1IK0dQb3B2ckk5Ulh0RTFWTldpeGxocGFtdzZiWjgvTzRL?= =?utf-8?B?dG1YU25idSttT05zMXZHTmEzMmp1SkhWYmNSMTlzMWJoZ0xieUZhMnFheTR0?= =?utf-8?B?NWRMdm1KRUp4eHN1ejlWZ0Z3aEJhMFh2ZlJlUUN0eXJOTllDNTc5eEQ3S09w?= =?utf-8?B?Q3FwN1ZwMko2SlFqNVJidDR5TEsxbWRkNTZEUHpEdmNHOHhOUXdpNTl3WFpC?= =?utf-8?B?TStxQm9NTi8rNS9VOVNQN2ZzcUl1N1dDb09Qd1JrMEo3SmJGRktZbDE0TEhj?= =?utf-8?B?MWlxNG5udGc0c1lWK3NnMituWFJ3cW9ZK0ZHTnRwMHBKRDMzR2lZa1VseThN?= =?utf-8?B?dVVRc0JqNkNxTkREOTBrZGhBaHo2ZWdSRXNGcFNLVHp1bWdhYjhLeTJTR3F2?= =?utf-8?B?cHdyRG9PNFlWbXFQNmVxV3lpUEwzbUdpbytLVEhTbWZVblE4cXVTZ3JFK3Rj?= =?utf-8?B?TDdjR1VZSnZEZ0FPTU5lL3l2VE9sREMwa3VKemJYeXJFZnZHdHhrUmhueW5l?= =?utf-8?B?UWl0djRsQis4N1ZLNVdSWUkxSXdwQmJTTkREYnU5Z0dQNDhxL2d5VVc4THQ3?= =?utf-8?B?TWY3MnZ2TjVva2xUL2l2ckpBMjFXUXd0TDVoUnJzbllhdTQxa01oWWFxa25p?= =?utf-8?B?N1N6YmdFUHkvUnBwYWw3S1RsUzVjeXc3ckhUZ3hFREx5eVhESXFPbnVBUEEv?= =?utf-8?B?SHJtajJ3eTRuKzRXS3N1ZXFDSTN0VDU0S1A0bklpbFo3QjcvWkIraW5ybDEr?= =?utf-8?B?eVVOZlpWemtia2VyR3AwOWw3UGVUTTdERWdVcjlaTktCdDB0ZDdIUDRsWVJH?= =?utf-8?B?TndkWUV6cEZLN3lLTGhrb1E3VFYyQ2JGdnluRmJYT1M2UHBmOE45cSt0dmM5?= =?utf-8?B?cmR1UGlaeDQvdXNlZjZuekVpNGdyUXFmZU1IbERnR1VUckF1Wi91aXVTTnJr?= =?utf-8?B?UFgwZE85ZWJxc0lvTEtwQ0JaYzY3UEUyYllIL0I1RnJrYXQ5WkFXSlczSG9T?= =?utf-8?B?UEkvRk1HS2I2emNiTHcrSDVFQ3FIdXhEVUxBb3VLSjR6TlFMMWpzc3VDNUlj?= =?utf-8?B?VW1hV25IbnBVQm9rK1FpYTk1VzNvUWVZSUNXOTNhRmJVZVpmbURMcTZCVnls?= =?utf-8?B?cWk3am1hOUVVVXprWmttN28vZUVPQ3JDQ3V0ZFF2aFZDNjluYUJFWHc5cEZB?= =?utf-8?B?MVUvdCtxN1dzZVNPQjlvWnlUK1JFdHI5ZWNjNjBTdjlSU2N2WVpvNUFMMGt0?= =?utf-8?B?TW9JSi8vbkRlMFI0ZUtodjMxTkVOeUJXVnlTS3lCSlpsZ0FxKzQ3QTZDdE40?= =?utf-8?B?WmJieU1EUDZpd0JWWWZvTzNYMDBHOXlndTN6TFF6KzJnOEhwcXFiVjlDSHZC?= =?utf-8?B?K0x2WEVyV3RkVGl4b3AxNThDRWlIYkpuR0JKUnhWdTgxbjRYTzZ1M2lvTHpo?= =?utf-8?B?Q0hWc2dRODBlOEI1ek1aSjZIS09XWSs1S05aYm9LVnh0dHF5Zm01ZmJVbVBy?= =?utf-8?B?dHpVRitXd25NYkNEWVNwTDNPSGFGSE9MUjZUR2xZMVY0SWd5VXM2QXRvcEh2?= =?utf-8?B?OHphaFlCeEZkT3EyR0dwc29saEVmb0Z2T2dWZWVXZkROTjB6NVBOcG5ROFpP?= =?utf-8?B?VUc4RHhvTlJDaTFuZ0hKNW9vcWZwc2R5a29vWnBUc3BDbHpBeEZDbFJkUnIz?= =?utf-8?B?clZJU1AvYTREMjBLVDZMWmlrd3lFeVAzNnUyVGtpbGd1RGhUeE5uNGgxa2tK?= =?utf-8?B?aVo1dC9Cb3M4Mm1IendQOHFUekw4QmJaOU5NYk1ON0prdGN6eGQ0ZHBOdTl4?= =?utf-8?B?azRjMkl3blpmZW9IcFJYWDExNEptQkFhMUxRWnNicWQzdzl4cG85dG5WN3g1?= =?utf-8?B?TWJtQ1l2Y0hGODZmMHVPcFZNRU5KT2RlSnRJOTMxMTlIQnhxSm1nZnhnMVkx?= =?utf-8?B?NHM0K09PNVErU0FDR3V3SGF1Y0ZyZXZRWTJmNVVmRjBCYlRpUDBrRHphNHNC?= =?utf-8?B?ZjlSbjNnK1BWbVVUR0tCTHlQWmdXUXdtbmhtSjV1dkVjZFZEbXovNmozU1Ax?= =?utf-8?B?T08xUEFpS0Z5RHRXMktLYWw3dG5tMCtrYmZOUmVSc1p3VCthbUw5Y3hVM2lB?= =?utf-8?Q?fFwJsBPL3VC6s9Q0UVGjt9e1W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1127a95-e1a1-4676-a070-08daa20e58cd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:32:53.0552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UJlVrly2YDEStgB18moR24qWUqKVJ0c/i/fdVXBksJ9v/9XKUEUQ3xHMmjt7dkrRzHHGhEp7XOsGvowUf0l0gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7971 On 28.09.2022 15:03, Juergen Gross wrote: > On 28.09.22 14:06, Jan Beulich wrote: >> On 28.09.2022 12:58, Andrew Cooper wrote: >>> On 28/09/2022 11:38, Jan Beulich wrote: >>>> As an alternative I'd like to propose the introduction of a bit (or multiple >>>> ones, see below) augmenting the hypercall number, to control the flavor of the >>>> buffers used for every individual hypercall. This would likely involve the >>>> introduction of a new hypercall page (or multiple ones if more than one bit is >>>> to be used), to retain the present abstraction where it is the hypervisor which >>>> actually fills these pages. >>> >>> There are other concerns which need to be accounted for. >>> >>> Encrypted VMs cannot use a hypercall page; they don't trust the >>> hypervisor in the first place, and the hypercall page is (specifically) >>> code injection.  So the sensible new ABI cannot depend on a hypercall table. >> >> I don't think there's a dependency, and I think there never really has been. >> We've been advocating for its use, but we've not enforced that anywhere, I >> don't think. >> >>> Also, rewriting the hypercall page on migrate turns out not to have been >>> the most clever idea, and only works right now because the instructions >>> are the same length in the variations for each mode. >>> >>> Also continuations need to change to avoid userspace liveness problems, >>> and existing hypercalls that we do have need splitting between things >>> which are actually privileged operations (within the guest context) and >>> things which are logical control operations, so the kernel can expose >>> the latter to userspace without retaining the gaping root hole which is >>> /dev/xen/privcmd, and a blocker to doing UEFI Secureboot. >>> >>> So yes, starting some new clean(er) interface from hypercall 64 is the >>> plan, but it very much does not want to be a simple mirror of the >>> existing 0-63 with a differing calling convention. >> >> All of these look like orthogonal problems to me. That's likely all >> relevant for, as I think you've been calling it, ABI v2, but shouldn't >> hinder our switching to a physical address based hypercall model. >> Otherwise I'm afraid we'll never make any progress in that direction. > > What about an alternative model allowing to use most of the current > hypercalls unmodified? > > We could add a new hypercall for registering hypercall buffers via > virtual address, physical address, and size of the buffers (kind of a > software TLB). Why not? > The buffer table would want to be physically addressed > by the hypercall, of course. I'm not convinced of this, as it would break uniformity of the hypercall interfaces. IOW in the hypervisor we then wouldn't be able to use copy_from_guest() to retrieve the contents. Perhaps this simply shouldn't be a table, but a hypercall not involving any buffers (i.e. every discontiguous piece would need registering separately). I expect such a software TLB wouldn't have many entries, so needing to use a couple of hypercalls shouldn't be a major issue. > It might be interesting to have this table per vcpu (it should be > allowed to use the same table for multiple vcpus) in order to speed > up finding translation entries of percpu buffers. Yes. Perhaps insertion and purging could simply be two new VCPUOP_*. As a prereq I think we'd need to sort the cross-vCPU accessing of guest data, coincidentally pointed out in a post-commit-message remark in https://lists.xen.org/archives/html/xen-devel/2022-09/msg01761.html. The subject vCPU isn't available in copy_to_user_hvm(), which is where I'd expect the TLB lookup to occur (while assuming handles point at globally mapped space _might_ be okay, using the wrong vCPU's TLB surely isn't). > Any hypercall buffer being addressed virtually could first tried to > be found via the SW-TLB. This wouldn't require any changes for most > of the hypercall interfaces. Only special cases with very large buffers > might need indirect variants (like Jan said: via GFN lists, which could > be passed in registered buffers). > > Encrypted guests would probably want to use static percpu buffers in > order to avoid switching the encryption state of the buffers all the > time. > > An unencrypted PVH/HVM domain (e.g. PVH dom0) could just define one > giant buffer with the domain's memory size via the physical memory > mapping of the kernel. All kmalloc() addresses would be in that region. That's Linux-centric. I'm not convinced all OSes maintain a directmap. Without such, switching to this model might end up quite intrusive on the OS side. Thinking of Linux, we'd need a 2nd range covering the data part of the kernel image. Further this still wouldn't (afaics) pave a reasonable route towards dealing with privcmd-invoked hypercalls. Finally - in how far are we concerned of PV guests using linear addresses for hypercall buffers? I ask because I don't think the model lends itself to use also for the PV guest interfaces. Jan > A buffer address not found would need to be translated like today (and > fail for an encrypted guest). > > Thoughts? > > > Juergen From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:37:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413671.657466 (Exim 4.92) (envelope-from ) id 1odrqh-0008TA-TR; Thu, 29 Sep 2022 11:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413671.657466; Thu, 29 Sep 2022 11:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrqh-0008T3-Oz; Thu, 29 Sep 2022 11:37:03 +0000 Received: by outflank-mailman (input) for mailman id 413671; Thu, 29 Sep 2022 11:37:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrqh-0008Sx-9e for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:37:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60056.outbound.protection.outlook.com [40.107.6.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04bed8e6-3feb-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 13:36:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7259.eurprd04.prod.outlook.com (2603:10a6:102:8a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 11:37:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 11:37:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04bed8e6-3feb-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VM+3TZtINoasvtGEVEYpAboIUZ0ImJ23DMTp3RJpU+Y8LamuYjhgsYIW+4IS9t36a7vanb7kLCh6i/PHUNDW084v9i8ABO1udnFAnTIDsO393nWBJXci5BFe21d1/CWYgVCat65Zo3q+sEztj1lfCXi7MwS1U9ksvXV8qFyw53bvLaqqTkw3ufXGxqr4gGZHn0ZnLeiySuvrKprqGkVIqDPVKBV4gSxZr7mcftoNNoXanUX0+vgxAh9mUVem6wW2Le3a6Te92g5qX1xdA51BqBokv1JmH7gKjmq6sDbYtCw/xHWHGisZHoAwCfpyEPUFfp+EOGgdl1EEc28h19VpvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bgKbuTtxwB5RtkrPvwUQF0tbEkL00g2FQRFac3RiNEk=; b=MmN1S+FkcQydi9UsqlVAiBelzOsaHPXhXcYH/uRJYhp7lIzV2j4A93eIPHkCpBLUweSR4ZGq+o/1ByVtLLapU5KvE5vmMOgIz6KVX8Kr6r+B3NPP37zJFMcSkFrJINVZkRtHD2qVDu6Aveukeub5UhbW8iCHK5RCxYO2lK+dFpfNxcIixGj7a8FNE+Z9VV5BX+dWBiwNYOoquxdXnukoJRT7z6m+BP8K9KYQzk6tNuNt6BSbjDkLdpmawRgnt0ITDwI8cGhFV5jUs8lysqZXwHbLFu1iBzkSZRiH8HQRkntPLyoa9B4I3M3yeweb7mGmfMULg84n4hnLCSrSLO6lkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bgKbuTtxwB5RtkrPvwUQF0tbEkL00g2FQRFac3RiNEk=; b=pVSHPGRjP+TqLkOfnX5fhlLIW7Ier3ItNuWjXgNzFWO5kYGUF3+20ckevbSRbR0AdrFOoIpCvJbtiTesZKIRsAtA3Yk5xXqVh4RVNe0lIZdxwBaOKzkOz8LTBh30WsajQlHsjxbaXOvjV7yaul8jqXzh9zqU2Ygcekq1aEJvAR3k66d3FMU85XsowoKPpNhHzn4fnJxhEV1Y4IfYm8di557oxxH91fpgV7dTdQjNIackMiVe/24q6mhOYIZmvGFIDb9l3EXiwnyrLPOZGlvQsbmfBuWBDmwv1LvUuVy+Ay6Zrdr4McErBe8smyN0nimWY5O6tdaxqQDpOt4UmrkFLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 13:36:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: For 4.17 (was: Re: [PATCH v3 0/2] Move calls to memory_type_changed()) Content-Language: en-US To: Henry Wang , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Wei Liu , George Dunlap , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" References: <20220928141117.51351-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7259:EE_ X-MS-Office365-Filtering-Correlation-Id: 981535a3-8b18-4e19-b7e1-08daa20eec50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: weIY4XDxtM2B3QhhAueqkAVY0EMb40NdBtmgZ+rPQ/6gSXTuk60+tQx6yfap2Frq0xTCtOAR7v34m2pLS0T64d+L7w21q77ICj12Le86W/7WOckmxRYE5A5MKoPXja+G8PWMvRvwWe8ZDt86n6jgc244YJNmulXKtCBcFYrpwDgol/YfHoH+HovC7+zeVw9mK/NI548QshTgJ19FCa3Vq5XyPdhR1dA2hTJN6usHpeMENCTvy8arB/+pDTLLzpGBjUebqbcuGcv+mc9tz5wFi0IYG4whT23cHzlWjoPskR5pPA1hQDiEoz3iEIhOwtNID56UgM7NwPjEJhDdMXETnl67PhJ0i9N1jyvqA5rzBlQF+4qUU7rqhtRNkrdoX4p+ybtCW9FP33lRLpAcoOHqXzOQ3n/PQVdyMW6iCYdQ/Jzps3dNFLyziEkjTi+uREmeGoOH3OkPrPco0vr/0zUXfJQ/OCaS4g0721tsC2WIBHmQaq7DbRBNPD14TiXB/OZG45vL0b5o/TFp9V5149C8CK72fh7uyG8Zzlh4CzKZDPXG0zeI3+eRS9Pb2LpvO36xxE4n3V0wbaGI3ly/EhxoQHbcIIRd7hJrC0/eioxAPjDKZYjYumtC07e/TkKYfsKweH2z9C04UIY6WGn9HIbnLtDepJrKz9wwzA/c5WYYzHzW+JQToBTobrH/51t/bOadaHNFaTXnxCDvN1DQ/Qo9knZcPEdCcsStAHUWo+Kd0M96xFrB6vYGRA++2wbb1DIRJ6iDzUnj+ouTD7slJZLU7MMUaOThh40Nn+K6ryjgVq0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199015)(31686004)(2906002)(7416002)(5660300002)(8936002)(31696002)(36756003)(86362001)(83380400001)(316002)(110136005)(54906003)(6512007)(66556008)(8676002)(4326008)(66476007)(66946007)(41300700001)(2616005)(6506007)(478600001)(26005)(6486002)(38100700002)(186003)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1RQQ0NVSHM0MVlVYW9iejdabzBVb2FuNjZQK082eERJNG9rRmRvTUU4enpy?= =?utf-8?B?RGtPdnNXenBUZzVlVHp4MlRjenBrYUZEa3RLTWVpUzV4ODhsakJKRU9XRzI2?= =?utf-8?B?Z21SdEVXOEVDSGJFK3JBcmNXcWVVcVdpeEo5S2ZaeVRDZlJyTzZ6TE1sSDBl?= =?utf-8?B?U01wRjZIWGNuVFNmN3hiWjZyczhvUTQ0ZWVBWFhqS3dwRWJyUTg2K1RmOU9l?= =?utf-8?B?UTEvN0ovYnlxTkpFSU1zSy9rQWpidk9VWmIzVm4zcGNxYytKVGhoNTF2Wlc4?= =?utf-8?B?RjYzZkpyUGcycDBTNDM3aHdKanZmS3FjbWUwUGQ1cEVWRjRLb0Fab2Fsay8w?= =?utf-8?B?ODlpamlDNnRaMkxCdmpGa0ZRaGYyVTQ4S3FzeFdscG9abTV2NFpGaW5yQzZU?= =?utf-8?B?bGJDV3JtL2dSdWlTam8rd1Z6T3VmdFhWQUx0QVFSTjQ1cUduYlV1RmpwUDFJ?= =?utf-8?B?b2JVQmFiUktnakRQUWNFWmFwRFpJUEJ5RHhqaVcwS2ZGcDlMY0lhVTBqZGVP?= =?utf-8?B?dlVYZmNVS1JSdExacFNLUytaNEcxaHkxNitkUTlmdGFRbnhUZXFzeFh5RjJO?= =?utf-8?B?S2FtaEdRTDd3dDBLMEJHQ3dBb1NsRzJleHJUc08wYXVaamdrbzBnTWRZKzIz?= =?utf-8?B?SnRKNFMyU1psVXp2RHVmUVZIc3dDeTFtWVJSVWhtV1A5cnY4N0J6OFIyZks3?= =?utf-8?B?dEkzbk9sZkNQZzJjaDhqZHNMWVZ2R29POGg1aEhPQktYUzFzejZxdGxZZkRq?= =?utf-8?B?dXdwcmYyVVIreVdkakxJVGtneWNxSE9rU1pQU2R4aTVHeVZHdlk3Ui9CNkh2?= =?utf-8?B?M0l0SUxNSmp3aXlxNGlrR3I1N2NpTUdYenpkc1pRbmk1VUppNDJhVDIxTG5k?= =?utf-8?B?K1lEcjBsYUYvR28vOU9yRm1oQjNKMGFqZTBlODQ3Wi9SYXVzQlRxVEVWSWhz?= =?utf-8?B?Z2pKSDRaN2ZTeEswR0ZzNWx0dFE2M05GWXJwbGpDNnBibE16QmkvUmtvalN1?= =?utf-8?B?SE1uSU5peElzb3dmRitnWUtHZzdCSVBVbGVyOXV1VFhhZXlWM2tvckV3Vnli?= =?utf-8?B?RjN5RTNCUzdQWjhxOEplTWZsZk9WREpuU3hWTEc0Sk9iK3F4Q3RLWEpKZUVj?= =?utf-8?B?VDUzRnlLaURqSzFXQTZLQTZXMTBhT05kWCtrRDRobE5SMUZURGNDcm9aQnJC?= =?utf-8?B?VUZ3a2lsNit1MGNZQlU0WmQ3bUZtdGc4SHgyZlNRdUNyWm12VWNUU0Z6Zmsz?= =?utf-8?B?ek1GVUVXaWo0aHIwQXVDdTUyTS8rYmdBMHdGQ3pkcUdoaSt3aDRMdUNuZEsy?= =?utf-8?B?UFgraFdvM0QwTlF2SmZrczRZODhGZXlzQzNQWFZybHRhb04yWVRyTVpPRnlH?= =?utf-8?B?b0YzT0VsSkRJMUkrZEVXTm5NcjY1UnpVTVZaVk5RSFZtbE52b29ndWxGeENE?= =?utf-8?B?aFFvZWtnbzUzSVA5cG0vLzczQW1VN0dGeE9wQWFmbTJLdi9mUmpWaHFLQVdm?= =?utf-8?B?R0tEQTA0aGp0d1hNaEt3akVydEhtVVB2L2lxeUR0OGxUclFUL2cySlRDTXpm?= =?utf-8?B?TWdhRVJrS3VyWVhnTWZ5bFQxb2h3by9uRHdteXVROTc3bU1mYkV0bFpicHhH?= =?utf-8?B?Q1J1eWVMeDRXdEVDZWJiN2U4dldHOUl5dnBYVDN2MFZ3NXlRc1lzLzdtb2hl?= =?utf-8?B?RHdBQlFaa2hpK3ZKR0NMZTdwU1c3UG55ZnBCTlNKaW0rZmhoVnFMUDAvN0pl?= =?utf-8?B?emQ1dWpVWk1ibGNFK3RZcnB1a2FjK1Z2S210WDlsNU92cUd4WHJzT3NRTEFq?= =?utf-8?B?SUMrQ0ZjZUlhYjlsZ29WakFTdWF5RmJpRTZQTTlrTHF3MzRQS0RYUHNranJv?= =?utf-8?B?eW5FSy9qL1lkZXVaNmwydVVkUXZWSGJKcUl2RFdmcDhJME5GdkNSMDIzdFpF?= =?utf-8?B?T3lEVDlaTytyVHNWZUZlZCtvK2dSbWJ2M3g2WnAvODFiWHpKV01ad1hBRkNq?= =?utf-8?B?SHJSNEY5dUdWSDVBdW0yVGxRV1VHa0N6WG1BbkVUWW4zWm1ubnZPYWNnK0hF?= =?utf-8?B?MnBDZnBaTVp0WEdjdUMrWW81YlJHMlEwY2owK3FuMTRycnVpUXFpT1o3emMz?= =?utf-8?Q?jOAIcLBGq2BMDA35pmZcQ7ga5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 981535a3-8b18-4e19-b7e1-08daa20eec50 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:37:00.5082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PW2UqR00YxRUTvF1IA09sb6C5063lgagmyAMuBpvpLVjPIPjpn2mRAUTERE6THc8ZA54MMJBn7d2mLV13mLcsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7259 On 29.09.2022 13:10, Henry Wang wrote: >> -----Original Message----- >> From: Roger Pau Monné >> >> On Thu, Sep 29, 2022 at 12:14:10PM +0200, Jan Beulich wrote: >>> On 28.09.2022 16:11, Roger Pau Monne wrote: >>>> The current calls to memory_type_changed() are wider than strictly >>>> necessary. Move them inside the iocap handlers and also limit to only >>>> issue them when required. >>>> >>>> I would really like to get some feedback on the Arm change, since this >>>> is now a prereq for the actual fix. >>>> >>>> Thanks, Roger. >>>> >>>> Roger Pau Monne (2): >>>> arm/vgic: drop const attribute from gic_iomem_deny_access() >>>> x86/ept: limit calls to memory_type_changed() >>> >>> Are there intentions for having these on 4.17? >> >> I wasn't sure. From XenServer PoV it's certainly a bug fix, >> otherwise some workloads related to GPU passthrough are simply too >> slow to be usable. >> >> I would certainly be fine with it making it's way into 4.17, let me >> add Henry: >> >> Cons: >> - Changes the number of issued memory_type_changed(), so there's a >> risk I misplaced some of the conditions and we end up with wrong >> cache types in the guest p2m due to missing memory_type_changed() >> calls. That however won't affect Xen itself, just the guest. >> >> Pros: >> - Removes unneeded memory_type_changed(), thus making some >> operations >> faster. It's effect it's greatly dependent on using a set of >> hypercalls against a domain, which doesn't seem common in upstream. >> It's possible other products based on Xen apart from XenServer will >> also see an speedup as a result. > > Thanks for the information and the detailed summary! > > I think my understanding is the same as what Jan has in > "x86/NUMA: correct memnode_shift calculation for single node system", > - we are still not in code freeze but in feature freeze, so properly-reviewed > fixes are eligible for the release. For this specific series, (to me) it looks ok > and I will not block the merging of this series if maintainers want to merge > it :)) Thanks. Then, according to my reply to patch 2, the only open thing is to have at least informal agreement there by (at least) one of the Arm maintainers. There's no guarantee this will arrive by tomorrow. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:37:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413675.657477 (Exim 4.92) (envelope-from ) id 1odrr9-0000ZW-91; Thu, 29 Sep 2022 11:37:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413675.657477; Thu, 29 Sep 2022 11:37:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrr9-0000ZN-5H; Thu, 29 Sep 2022 11:37:31 +0000 Received: by outflank-mailman (input) for mailman id 413675; Thu, 29 Sep 2022 11:37:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrr7-0000T0-O4 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:37:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 181cbee2-3feb-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 13:37:28 +0200 (CEST) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Sep 2022 07:37:17 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 11:37:16 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Thu, 29 Sep 2022 11:37:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 181cbee2-3feb-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664451448; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ycxZwFHCB931tFqyjgwca885edihkPfYOhlxs9d1eEc=; b=DtNXrDE+BQrjLXAZOKDKH4ti7L/I1hLCbFKpTquFP6NUfe+XGdQbIqWr YLIhlrJKf2Q+2oqPqvQYXa6bi5ihCAc1GLZmOBYUEAPoJ221HVyC/PPIc 34W3s579unJueKB0N2XLSKAf3qTY3lR8sGmmGxdj7zV4gtkHVhjBzmhsn 4=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 80737034 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0TkOMKyKMHD1oh+Ppih6t+cAxyrEfRIJ4+MujC+fZmUNrF6WrkUHy DNJWGrUMvbcZzDwLYsgb4mxox4E6pTRytdqGlNuryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFsMpvlDs15K6o4GJC7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw4PduByZ16 cEhczVcdwGOnN6Ex7SxRbw57igjBJGD0II3nFhFlGucIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9OxuvTm7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVqi332beUwUsXXqpIEKOX2cd7oWednE1QAhgaRErlpr623xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht8ztLSxitvuSU3313peZqymjfxccK2AqbDUBCwAC5rHeTJobixvOSpNvFfCzh9isQzXom WnU/W45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 RDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:nITTb6w4v9TXPWnzmx41KrPxt+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIG/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF9nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvGOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1sop5PzuN+d3B+3Z W1Dk1ZrsAxciYoV9MNOA4ge7rCNoWfe2O6DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK j8 X-IronPort-AV: E=Sophos;i="5.93,355,1654574400"; d="scan'208";a="80737034" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gz4TSSKIyuzLxCVuyn4IN8IhTbisufBU9W3Yk9Z/Bl1CHgqwc3Snq0JeopDqVbYR2Iii8wmDTa75zN4WlXiRjkcLjO9twN5knfBZvWWU12y76kK78W1803P4QhvdJT+B/gXogO89P5i/4Ii8+Zbg6TgZ9I0u5/ZqcSKpksfuvvj663uMDwr8l4Uk3sOBALfMUEqJ7wF/NAVIY0W+IwBYMq1POEr6ZZGUGH1hCPRBfLFDETPCsrT22uATFQ3sCkYN+xnulNIRR4R9eOtzJJ/r+AeEyGOX9r9ax8CadkkuxOx5mXV9YjnHQqRiY8mXqnJ4j/MjLSZhBK1zjXkeVexPmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCtmtNtTvmJofNZPAWpDFpE1cdKbChfHB56VffTLgGo=; b=kVJwFYr/JP/VxLuC6GHnUQNVtEWykpqnqD7v5TrqRnMzAX7XlphS0O8b36h0NAzvF2AsnlOK8sXj/xoXxeKmLNYXzvCLIg9o9Y/bPLwCaRjo3SVTOFYT6iViWBUcwDj460uEY9x3MRGBdSa9JvZHLBkkN9NadhKOsk80pxnFZn3k6fAkW4aMg5yFghtQwFyxnqa+laBMTR8IkYVVbEKUOgdRMmIm8nWetztb+Bap/hgUHvWAorWKhi9pTUFWziygumf0yHt+6nU1TQLczXUmuH8kfRkT6TdRBRx/JAPrQzv3LdVY/YMK/FjqtUipU8mEtoEGUm5Hzd96ikkdVD0IAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCtmtNtTvmJofNZPAWpDFpE1cdKbChfHB56VffTLgGo=; b=vtuxBkIy7HTNSM+V9I0vn9cxLOv63LcSxg7Aq2mpecbilUUVbYv1YeGO12XrSE9q7OMYAvAFxm8wn+GBlhcw25r17ThNxEyfRrnf6ZfBk2VQ8fpIvg2J3uwNxY9fsb4sUiLnGNGKfIFpyxEPTJ7Soj8aSW1Xaw38eOs/aogVnho= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 29 Sep 2022 13:37:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Henry Wang Subject: Re: [PATCH 2/2][4.17?] x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Message-ID: References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0249.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6964:EE_ X-MS-Office365-Filtering-Correlation-Id: 7086bb55-c01c-4286-4ad9-08daa20ef551 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LiP/byPlsnxHDnkorsvz2q0NkwkmSbs25UiQXTQyqfd561Pe70HliwylLoLSxYcSH1KQGaC+K1cCvWthlemZDLhKIUDuppMDMTRY7eMnwEj8zmSVjTDjgovZjKaQj5jCZnHIyVIGatY8Lbd/rDuwt7lPuH+nToy7WEhdh8fJEopcjJ4Ch6bF+afA/NGxF6nlN2UN7FFuVsyzX3flyOBfsEclkXirF3nDuAXF7zVWEIofbX4r3k+FnWGlk08lIfjuo7tDQg3tY6v7bR1+v1RSob03fCeLl13D47FjO30COaOuCZnYSlGaXYwSBJSC79F8e2jQQ/BSXfNk6oDBsy/n0xwPpVBjA4zB5R2Ec8bXAUEmtKzaJa24xhqi3aR4Yu1/YrtYkTWElJ/1yvvCFVYkJqyOUbxavIhDI1q8YtujfZ5t2o16VlyZwuwVW/AKYfueRNYgZoZBtPuC2vsSWFPSTA4Wv5oJL4Q/0rEuA4EZelOh+Kjkqhg5nK0qsRthgSbqHew0NUc4uhC8xIgsOIRUrNgGpkoszDleyG5z43eW9Snydyiscw/2loDGu4TOvry7NfQETvQ0OlgN0z5vDm3bjJ8wyJeM/YS8mWkB1ImVw4tJS0oiPxK0xLQVwOtpQ86BWCmDtdSWSmcJEzn48TO6teTZNL4eD249lF+Cp5XJSJ+RrPjf4LJpMuM9kxaPAb974tXelml3+rg9/N1XNCmz+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(83380400001)(186003)(82960400001)(38100700002)(9686003)(6512007)(2906002)(41300700001)(5660300002)(8936002)(316002)(6486002)(478600001)(6506007)(26005)(6666004)(4326008)(66476007)(66556008)(66946007)(6916009)(54906003)(85182001)(8676002)(66899015)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEJxK29LTjlFRW81V3JPYjRmVFA2OGwxNTVCTytHcnhtTjVySzRqSTlJRWlJ?= =?utf-8?B?U0ZiOXU0Wnh4QVZCY1RTUVVrK0hJdm11b0JkdVlKdFY0MHNLWWg4N25xT3Q1?= =?utf-8?B?MVdESVc4TjFhTkdGYTNWeGhtemQxcUJJS0tZSzJ5dFIwL21rUzVYQXdOaEty?= =?utf-8?B?SmljdndOeXFnS0hkMnA2bmJBWngxdUpEODRnTkVjamRMQWgxQS9HZzZqSU1Y?= =?utf-8?B?dEZUaHpCUG1abHJCK1BLejVwNWRuWW01ZFNhSEVQanRsUXkxY3Y3NlJVWCs1?= =?utf-8?B?Y2s1SXNxZHJ4YjUyVjFBREVPbGxVTy9TRHo5azBiSXltM0NMZUVYN0ZKbnVp?= =?utf-8?B?WFpxUnR1MHluMHZQU2I4dGRzQzB3Y0RZLzkrUmNIVzdrQ2hlVnltYzlrRzdX?= =?utf-8?B?c2loeHRCWHNqTHB5aXM0U0did0lHcE94OXZzSzkxbVdreHRBa3BOa3daUVlq?= =?utf-8?B?UXJJeis1MkR5RW5tNkx2ajFOSHFiWDZsaW9ad0RsM0xLUFlQdmJtdnJnUU00?= =?utf-8?B?TWxjWmNVRlZaM0dacHBjWkZ5L2pORUFzK1F6UmlUM0RWcXB0RnV0Zm1IUkFr?= =?utf-8?B?azFzZ1ovUGpyMnFIQ1lqZG1hMWF1L0JDSDVLcURsNVRPNEpLalZ6UG01YjA5?= =?utf-8?B?WXA0TE5SL0lzVHJiVk9JTEVyWTYrbVVicytCMW9nOElaRlZtNU42dys4ZHNn?= =?utf-8?B?eVpHRHRwcGRFN2t1TjlSZmpxREs4Z3lwczBYUjRhY2ZEQXJwei9HSy9NQTM3?= =?utf-8?B?VDk2cDhiUzB5aGdxNmpxN3BIQ2lKNFYxSVJBSmkwdVgrR3hpaEErbHJlV08r?= =?utf-8?B?MENBUXJvRmUrREZua2dnV1ZUNkRLK3lhQUpYQytoV2tmS3BwUTh0dDRhcWwy?= =?utf-8?B?aDFWSFpCN0didy9wQ0lNYXpHaTczejk3M0hSK0VPQWllcHhNZlZ5eG1pNzhL?= =?utf-8?B?WElIZXd1Rk0vVWRHWVFDMmNtQWxrUk5BbHgvWS93YXJDYkI5dkZCUG5CVEFn?= =?utf-8?B?TmNoV2h1RkVJMkI4RU10MzBlYk1VTmJSdjJsSnBGYXZhaUlSbXZqamwzUTFQ?= =?utf-8?B?bVJYUnZCRTY4RGlWY2M0cVFOd0Z2OERndzNBWndXZUJCT3Q0d2hZWEhzd2V5?= =?utf-8?B?TUxvVHNIVWRMYjErU0JQcmtnQzU5VzdHYnh1eTI4cTl4NUk5Nm9YbXJBS3hj?= =?utf-8?B?bmxibnFUSFR2Y2VRMktlNVNVVDB1QlVpbmU0ektKaXI5cUE3TGZKUTc1VHFZ?= =?utf-8?B?ZkhWd0pvRkppbTFBSklsaWJwVHNGT3Z6eUhHOVp0YTdGbmd5L3RxcGdaTCtZ?= =?utf-8?B?d3lqcytZZjI4R3BrSnhUOVpJTlRrdGs5WVp5bXViU0JtM3BPS2puN0luQ0dR?= =?utf-8?B?UGk1MFFya3ljeXFWZGRtUkRQbXUxdjhpaEFuKzl2ZFI1WmwzZFZxTGNydTQz?= =?utf-8?B?U0tCdDZGcHJCcENZdEQ4RldlTG5RMVRiMXRlUE94UmNrd2Fmejk3dTZBVitJ?= =?utf-8?B?akY4V3RHdHB5dThDTExxTnVoZkh4dWlkcmlqalhkSjNNVFhBSW5HRTlzT1p2?= =?utf-8?B?YlhKaTVRcnpaSGdRYVdIVW5ialF6VENkcWlJM1AyMVZ6YldCL2UwVVhEdEFB?= =?utf-8?B?cVlyYUpXZTE4STRrdEcxcmx2a3ZuS2JzTmwyQ0ttWE0xSjM2WmpGeGpFdEho?= =?utf-8?B?YVBCbDZDaGNlSWh2UGNBaEFJV2pjeWI0YkpRZXRQT3hWZGJBM3BQWTlCUllE?= =?utf-8?B?K3VVM2JyL3hoeWh1QnczUnRZVkgzdDdTM3lWeUVrdC9vQjloYThXNWNDZXdS?= =?utf-8?B?Tk8vdlAwdENGSk42ZWd4S3VjZDZ4MTlWL0tKY1kvY3VmN3UvYVlKeTFtY1Bn?= =?utf-8?B?SHpLbG94UExhQjlLaFYvS085aHU4UGtJTTRUTDg3NjgzbGxqejhoSmY4dmNG?= =?utf-8?B?ZnBPYXVvclhUaUFGU282NUNVUGtyS2JBcGlPdUd5YXNYZUxLNGMrZlhRUEdo?= =?utf-8?B?eFNnamE4TUxoRW5GaU9VVWpDM3B0dStjK3hSaEdOYi94cG5KVHB3QWNoaHli?= =?utf-8?B?QVhoM2JSZ1k3d0RiUDRZcXEzU01XR3Ztc05RMjZqOWc0cVZ3ZlN2dVo3WU5W?= =?utf-8?B?U2xRTG5EeTVvOGRSWXl6cDZPTFcyRTIwblEydURJQ0g3a3FtRGVRWTBMWmpa?= =?utf-8?B?VHc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7086bb55-c01c-4286-4ad9-08daa20ef551 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:37:15.8158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v5qGK1usX3EfwcsdTFqD/itkVei0i3qsMEiQ+GA3qUe3FlYEBXbwK+njzxozoK9MC7XzlM6rk80vzsEZh4GoXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6964 On Thu, Sep 29, 2022 at 11:51:40AM +0200, Jan Beulich wrote: > Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area > was available only to native domains. Linux, for example, would attempt > to use it irrespective of guest bitness (including in its so called > PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we > set only for clocksource=tsc, which in turn needs engaging via command > line option). > > Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Albeit I have concerns with the notes you raise below, not sure we also want to introduce a (broken') compat version of the same hypercall wrt v != current. > --- > Is it actually correct for us to do cross-vCPU updates of the area here > (and also in the native counterpart as well as for runstate area > updates)? The virtual address may be valid for the given vCPU only, but > may be mapped to something else on the current vCPU (yet we only deal > with it not being mapped at all). Note how HVM code already calls > update_vcpu_system_time() only when v == current. > > I'm surprised by Linux not using the secondary area in a broader > fashion. But I'm also surprised that they would only ever register an > area for vCPU 0. Would be better to update locally just when v == current, otherwise issue an IPI to the remote vCPU dirty mask and force an update on resume to guest path? > > --- a/xen/arch/x86/x86_64/domain.c > +++ b/xen/arch/x86/x86_64/domain.c > @@ -58,6 +58,26 @@ compat_vcpu_op(int cmd, unsigned int vcp > break; > } > > + case VCPUOP_register_vcpu_time_memory_area: > + { > + struct compat_vcpu_register_time_memory_area area = { .addr.p = 0 }; Why not just use { } to initialize? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413685.657488 (Exim 4.92) (envelope-from ) id 1odry0-00026F-1K; Thu, 29 Sep 2022 11:44:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413685.657488; Thu, 29 Sep 2022 11:44:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrxz-000268-Uh; Thu, 29 Sep 2022 11:44:35 +0000 Received: by outflank-mailman (input) for mailman id 413685; Thu, 29 Sep 2022 11:44:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odrxy-000262-33 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:44:34 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10054.outbound.protection.outlook.com [40.107.1.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15956b67-3fec-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 13:44:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7355.eurprd04.prod.outlook.com (2603:10a6:102:8f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Thu, 29 Sep 2022 11:44:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 11:44:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15956b67-3fec-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/N9mLbiDXl/ORyakW87VFrCL7wAKGxNweYj7GFmTJ7NCKK3SF0QM/VHQB1C6ZHvj4HYuVYFwPJGA3pmqJWfOwf/xCZM1KMy5ZAyWbXu3fzbJ2GGskVmxawcOcKARQpC/EdiiPQtE8r17xsgIx7xeNPFdXtnbUskgeL0Ax2UPESOfDY3HIZf1ViLFNbqVpm5iPE18861yKX5Bl2+ILhL2Bd1/OKy6C1mgOhH8hWl1uv6WAqxhk+iwVudhFGWQxHTAnnkkGOEtP9ih18yrMMGgEFn6z7H/IFSJDjGH9DfCH1ULjx+KZWp3vC5hmKGgkM+ZfLsyV1Xv0mM86XIfN9rFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dcZOI9nh7RvLNCNIgUq3HQSOUXZLasPQX4dPaC0wD+0=; b=NLg2jvqkYvAmTL5yq8zWNkoPxXM5ydHWbP6SAaEdmvl0DteO1GeTtuoF4z8a9pLyuX4cs/YdSrNbtzjoEBTp2WFn6eACfZt1idg7iwx/kh58GogeJH72dguo36YSxHYnYhk9UiSJjtyvf1L0iO7yg+ROWbshsiP1gGn62MsxTckcsbtLkjjP/rTmHDQw/wrEevWDCAdYChYtXa7EdYvOqHCqEf1ptSKqNSLbQIMAVRV1NoY6a2jKMMg/y+8XPmzeekzwWfpOCWKCN5CL113MlsArpem//gd3y+DkUquHf/Iom7NY2mtYgEUzvj1my/30Bt3Pcyq16eyAKRzn/05hPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dcZOI9nh7RvLNCNIgUq3HQSOUXZLasPQX4dPaC0wD+0=; b=L6h8P7VBfhmmp5LqIJ/Bjt2LUyJHHVgV6Hai8Rs1qAXfdRXAthwVcrGykWSQhenMsSQHb+jrTOrXSeK2he4Yurv+pkbzWHmd66oK2wDFA7QaRfkcttRJAeizFM7Z8m5Zt2RsZkmsgcp4yCxyB16O+t2bQMnilj8N+Y95WT9gKNfOBrMxlfPZRxlrcw1CN4+sqY6MSsgGqE9/K3yBDPAtZZXxuGPGjn6qiGb6sUxbAiIH0ZNZa+DIJpFOMzdB1pSlFnHA7pdSKWoX/24MpKcMSGCjrLq1VU+JfUCsRJfHfsF7Ho9MsOiWL2Ur6XRdu25/EyFgUwpF2hk4S9y3gMPEPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 13:44:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Design session "MSI-X support with Linux stubdomain" notes Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel@lists.xenproject.org, George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM7PR02CA0027.eurprd02.prod.outlook.com (2603:10a6:20b:100::37) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7355:EE_ X-MS-Office365-Filtering-Correlation-Id: 86830c3a-8a3d-4ae9-72f6-08daa20ff7ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bEWKcqudjmlg7NBClMWh8UliJkN7ckLL3Y5YYfRm5yD0CNfDD7VPpnAVr8kjbxX6dmuCnU4ulvaoKm1E0JhvlO+pBhM8QUYhVJLwCf5CX4/5u3JMGrzp7tnv/yRZA4Qiiq/kiQxwGjogNPVcyFCHs0a0K3T0oEF32fEmqLluRBX0AirmgRFXp4Yha1JKsjHOy9DJnOFmn9Hl3PYRfg2wd4dEIYpDG4fgp5NFz3c5hrQKA0vqOxZ0gxoqbmaoL7ZTpiy6gIulZy9bSKpd7oJu9Pkfh9zuOvUJnqJbNUyFyEcsJBlSVEX/7u/2wl8tVaIcE4CPF0FIab3zj54bApUFLAJh7nQU94HbMVC0EeHEXRjmQ/gb6KMoKBGkIMB6AxAu3SQPajsTwEDkH+XMbBxUY3OSQ3qSEpxT4olmjIxZBGyBs5GySwZzWHNd2Uh0tcdnkWcZlNQGgquIMnD64Jj8zZO8oVoTBUJIGwogxv24sLEIpZDnONxQZkyNW7NzU3E9ACQQkT83OobidrRbV7/p814Pe5XGOEDYmSWzJK1YWhzYN84NXon9TH7JyHwanmtmKXtHU0w3RnavfsICVMw5qChBc2YxDctNb/9HvTqX54SYnqbB7XQORFiQo+1M1iPtMUqPyGtKl51vO2LtFGpfYmugQO80RejOtaNckBAHAyehNWsDAf63W0/CDG6kzAwvMJLfRpCTxIx2Rakpjva5YJ/Xb4c5YlsM0Udbz0iXWSqxRvcQMwE5zWV08BHHsztwURCu+r2tGc8DOYrFUcVRru6RmXGQkYExQ48d6FWQ2xI8mSXmZjKlMtM+HbkO6oetXVNjDTqcDLTXPQUlJDwIaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199015)(966005)(54906003)(31686004)(2616005)(6916009)(4326008)(66556008)(316002)(6486002)(8676002)(478600001)(31696002)(86362001)(66476007)(66946007)(53546011)(6506007)(8936002)(6512007)(5660300002)(66574015)(36756003)(26005)(38100700002)(186003)(2906002)(83380400001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUsxRXVFTDlFUmhvZklFR0xHWXlPRUV4cW8rQ1M5NUpJS0srY2lyTk41ZG1N?= =?utf-8?B?eWVlUDJzZkdwUU9nTi9uNXl3NkVRem5hSzBVeGV2SXdMdTgyWG1FZFBnN3VK?= =?utf-8?B?aUJiQTRidkd1SXBFaWM0NURHNzl4N2RjM0ZTeHVvdGlIUGpKa05weDFjTHk1?= =?utf-8?B?WHdTZDJSYWg4TS9XVzFobFozWnpkdGF6WTJBdi9vY1hJYkRQdnhPbnBkaE9m?= =?utf-8?B?ei9mMmUwd3NVaWtoei9GajBFanBJMm9lZTcvRVo1UDdONGxRQWdTSnFGVjQv?= =?utf-8?B?eEZMWGE4TlhhdldWRm45dHBxY3orRnJnS3M1Zy81eU4raG5VeTA5SmJlU3dZ?= =?utf-8?B?R3M0ekRBQ0lTQWowZUM2alRnT0o2NTNDSkp4M2lBQTNIQ1FJcmUrRlJxeC93?= =?utf-8?B?dTFqYVk3SnhEZloyVjVNQUZtWEd5cGpvbkdQeThXY1ArMHM0RkYvRjJ4MmVT?= =?utf-8?B?V0FBamE3MFdGeVltb3lwRzRBY29nV09jSTNkWEluN2RzQjQyME9DSTYyY2h1?= =?utf-8?B?S25XZStUZ3UweENQSGJzcWpvdVVMS0VJei9uRVNTdEljZTJ6bHA2N0hUYTA5?= =?utf-8?B?bW5CVFdkUWEra0RFTzg0d2p1Wkd2NEQ3bXBmOFlVajhtbEFGQStxS1lqSUcv?= =?utf-8?B?MU5iZk1kTGNuMnMrVVN2NU1QRnB6SDlwN0ZkQnRFa1k2OWZVeENJRmluVW4z?= =?utf-8?B?K0p0Yzc2Z0xVSzZRN0tkd0lYMm9iUmI3bW9Eand2K3d1MlJ4MGd6Sjc0dDl5?= =?utf-8?B?bUUxVVRibFZrc1ZGazN5MHBKa244alRuWlZBcjE4SWFYSE1US29MVnErVi93?= =?utf-8?B?YXVUUE1meW1tbEIvRHNmQ1FtR0FxTjE1R2o2ZER1bVhtK1NvRG1lRlpwWlJm?= =?utf-8?B?aUNKWG1WQWRWa3haSlRWSDk5VmJJS3lmczV1YURBMmlYWGR0RGdQMDZGbXhC?= =?utf-8?B?SUkzL2NRWGVJZUsyMjZTbXFCV2F2Q1FpbE82SGFoK2dsUG8zcVlMK3JnZU1Q?= =?utf-8?B?WmxTdW5JazZaM296VllPOFNTcUZvZHBFVU1sSFZHMlhaTVVoWEpkMGVVdVVL?= =?utf-8?B?VzA2Um5tK29FNkkrTlczdEhFVFVxdVoxWE5CeDF6a2dZc2gva1VWYUhyc2dD?= =?utf-8?B?RSs3Z2VyNUdPSXFOMU8waVp4SDc5S3Y4RWFzaGd0TzdzN3BiVndCVGVpTytv?= =?utf-8?B?SzdxSldPMkN0aUNWV2RxcEMxLzd1SG8wQ2NCeWlyUmxpbjIyR0lsSzZkdVFY?= =?utf-8?B?V3FPL2lVcDYzOGh6NUp4Q3hoUk80YmZESmdVNEpUQkVtVjVXL2RzbkhHWGxr?= =?utf-8?B?NHAvbnR6U3J5R3pMSE1iU0QvTDZrdDBmZnZUVDhTb2QrL2lqUTR5K0dCMWpK?= =?utf-8?B?czJpYXgyenhtbEl2U2ZlMlkxVkVXeVhBMG91MFczWnhHK2RZR2xubU1tSVBj?= =?utf-8?B?a0M5bVZiaHdmZUtmOGJadnB6NFBscGtEV21mSXk3TTVKYmhSQnliKzNVeWxH?= =?utf-8?B?UXBFNEl2NFd0R0hXdnhxbjB6akppS3RsQUJDZWRjN2tLa2FYTkxpOFVhZXNE?= =?utf-8?B?M1dvSE1sOEljbjllUmw4MEUxQlFTZ3FYQUc0czNVak1xWHYvQUc3Uzd3YXJL?= =?utf-8?B?YUdPMWs1Yjd2OGxEVDBqaUtJWHVuWThaQmFIZVczWVNhMk8xcjZXN0twZ1BB?= =?utf-8?B?RWJYSU9QbGpkRTZqSkQvVWxqVlZ2OEZXRmxKajlzSFJPOCtCcFVQYlIzdWFI?= =?utf-8?B?c3l3K0RsUVdXS09ZQUd3c0JKSEs5MHNvRmM2Ni90QnpKbjYzUnFZMFlNVDFU?= =?utf-8?B?ODNmVkZlamUzVlRFSjNEcnlEODFlc3RYQVZOam5MZjBVdjVhZ1ByeGtXVUNi?= =?utf-8?B?b3greUlZa1FYdEdNb0FVRGM4VVZwbk4xTURpZktybU5jUVUxTXhFYmtML2Vn?= =?utf-8?B?QXhRVXYrZXcxY01UeWQ1eGVxc3JRV3BBRDVGVDhTV0t6UHhFemF4T3dkdkd5?= =?utf-8?B?NUFmamdGT3hZV2Z4UG9Ec2ZzdDVsTEh0N0pDRlorczVyKzdYMjVxZnRobmo0?= =?utf-8?B?MmJZVTRIZmJ0R3ZocjFreXVhOFo5ODV0TE9OVFA2UVUvZS9WZEhkek1ZaER2?= =?utf-8?Q?hXliNeB7Ea3LJpX26hw2TPp06?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86830c3a-8a3d-4ae9-72f6-08daa20ff7ff X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:44:29.6050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dDHVU/0Y6H/krXGecMxKa9pWSoy2mUd1g9vvVU9VNP0hi9Dn2O6s095TXSuaJQXSxH+GkWETFbjIMJ8knVBOeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7355 On 29.09.2022 12:57, Marek Marczykowski-Górecki wrote: > On Mon, Sep 26, 2022 at 02:47:55PM +0200, Jan Beulich wrote: >> On 26.09.2022 14:43, Marek Marczykowski-Górecki wrote: >>> On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: >>>> On 22.09.2022 18:05, Anthony PERARD wrote: >>>>> WARNING: Notes missing at the beginning of the meeting. >>>>> >>>>> session description: >>>>>> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn’t >>>>>> support MSI-X. For the device to (partially) work, Qemu needs a patch masking >>>>>> MSI-X from the PCI config space. Some drivers are not happy about that, which >>>>>> is understandable (device natively supports MSI-X, so fallback path are >>>>>> rarely tested). >>>>>> >>>>>> This is mostly (?) about qemu accessing /dev/mem directly (here: >>>>>> https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) - lets >>>>>> discuss alternative interface that stubdomain could use. >>>>> >>>>> >>>>> >>>>> when qemu forward interrupt, >>>>> for correct mask bit, it read physical mask bit. >>>>> an hypercall would make sense. >>>>> -> benefit, mask bit in hardware will be what hypervisor desire, and device model desire. >>>>> from guest point of view, interrupt should be unmask. >>>>> >>>>> interrupt request are first forwarded to qemu, so xen have to do some post processing once request comes back from qemu. >>>>> it's weird.. >>>>> >>>>> someone should have a look, and rationalize this weird path. >>>>> >>>>> Xen tries to not forward everything to qemu. >>>>> >>>>> why don't we do that in xen. >>>>> there's already code in xen for that. >>>> >>>> So what I didn't pay enough attention to when talking was that the >>>> completion logic in Xen is for writes only. Maybe something similar >>>> can be had for reads as well, but that's to be checked ... >>> >>> I spent some time trying to follow that part of qemu, and I think it >>> reads vector control only on the write path, to keep some bits >>> unchanged, and also detect whether Xen masked it behind qemu's back. >>> My understanding is, since 484d7c852e "x86/MSI-X: track host and guest >>> mask-all requests separately" it is unnecessary, because Xen will >>> remember guest's intention, so qemu can simply use its own internal >>> state and act on that (guest writes will go through qemu, so it should >>> have up to date view from guest's point of view). >>> >>> As for PBA access, it is read by qemu only to pass it to the guest. I'm >>> not sure whether qemu should use hypercall to retrieve it, or maybe >>> Xen should fixup value itself on the read path. >> >> Forwarding the access to qemu just for qemu to use a hypercall to obtain >> the value needed seems backwards to me. If we need new code in Xen, we >> can as well handle the read directly I think, without involving qemu. > > I'm not sure if I fully follow what qemu does here, but I think the > reason for such handling is that PBA can (and often do) live on the same > page as the actual MSI-X table. I'm trying to adjust qemu to not > intercept this read, but at this point I'm not yet sure of that's even > possible on sub-page granularity. > > But, to go forward with PoC/debugging, I hardwired PBA read to > 0xFFFFFFFF, and it seems it doesn't work. My observation is that the > handler in the Linux driver isn't called. There are several moving > part (it could very well be bug in the driver, or some other part in the > VM). Is there some place in Xen I can see if an interrupt gets delivered > to the guest (some function I can add debug print to), or is it > delivered directly to the guest? I guess "iommu=no-intpost" would suppress "direct" delivery (if hardware is capable of that in the first place). And wait - this option actually default to off. As to software delivery - I guess you would want to start from do_IRQ_guest() and then see where things get lost. (Adding logging to such a path of course has a fair risk of ending up overly chatty.) Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:51:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413691.657499 (Exim 4.92) (envelope-from ) id 1ods4Z-0003dY-NX; Thu, 29 Sep 2022 11:51:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413691.657499; Thu, 29 Sep 2022 11:51:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ods4Z-0003dR-KK; Thu, 29 Sep 2022 11:51:23 +0000 Received: by outflank-mailman (input) for mailman id 413691; Thu, 29 Sep 2022 11:51:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ods4Y-0003dL-6A for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:51:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08dc0cd5-3fed-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 13:51:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9515.eurprd04.prod.outlook.com (2603:10a6:150:24::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 11:51:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 11:51:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08dc0cd5-3fed-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PjI51F9RBc+L/9/ya6KIMWisD5uK1+DLpiZ5TpuETCQgCC/lBg4b8REkB8XzuhFCRFjtYgYWst5VT5bTN8zCV1yTMmraGZ74MMiuqtkF99c8ckTxuH8fc27CfSHrfb5vvCUfOEfXyduRHCWVTlMpWpGkObbbDoM8B4TtQCxShlzEvb3Ewcmp2r6MF7IFrHpAoJosoJgfhm46ZxdOHsM7xPqGv8zsupmI34K1IymU/K+BW5yap7Ckp4ZObxAIBKu8Z7dSq63dF+IistzwWyWmuIfzTRIMZ3twZqpU1lVew2asD/EfBfSYiH1LQoI6rjOseXuNM0BM9+S5uzL6kRVBDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2PtSB3OT0mrizKCvgBTMsnzXOjkkCSAzDqw7JVJSiA=; b=eAfJDaOxOEvI9/53tBPx4wN9GZBZkY7nuY9ASjvIdvIflWVe1toFaebrFpcZ1kQVOTbRrsAhmtUMX6/OFF2/RBdaDUs6N8OOH3gC6g28MhNLpHghD7F17pcIvEn96LxZfR2kHCrWOkVubYhXWGjwWg9bdz2XS99hJOgb2vT5V+d5TJB8W8G4JO1EI1MAFGnnPT3Wly8bFtPF/8ePptDtUIKLptz0ily0bG0HGt3J7i7lDbcD2xOLW04Yp6j48s1kmxLxREramd+BNerwmKA6l5mYi6fPNkDLn4NiM/jtl9O3xktW2SHcwKSONPVm3c2ZeDj/h/W9LOw3ExfXsCn5lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z2PtSB3OT0mrizKCvgBTMsnzXOjkkCSAzDqw7JVJSiA=; b=WDqRn+eubXHmjWKFHitSNCYr7SACDzYyhANB9vtPs2i7ai2Ye6Mb61fSJy3CjsDv/unbbf0mmypW3mks/Sy2v8uqJwpRNpbBSS3lQd8THmNcmDAFhtc3siZImy/Nioi/f32PzckZGgQ4VgkCV3KWFrZADWOA0yN0XKBJxikpvYuzEMyeyVjUluT6SF8KuQQPMXzMZC7YbcWIpqsbxjPslx9GNSGco4pn7BxgT2yIKehrX4Y5UFwkXuEDrA276yJpX5BkcxYbP4Qrs4IX/dbBo2eKtrV1H7XjqsdR/WcaHNW7I3AKXLx4EDr7qDgEm0qt8rknOhe748aoZFdZz5YoWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <98012eb3-a591-e6ec-8ce9-baf00506992d@suse.com> Date: Thu, 29 Sep 2022 13:51:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> <8b5c0b8f-b243-47b1-2ce9-f315d5c7138c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9515:EE_ X-MS-Office365-Filtering-Correlation-Id: 67938630-4d63-4309-5139-08daa210eba7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MxXd3qrP5pQkbbrhlY47c9SXl0CLRpu3oLpAz9eiZarNnAotHgjSwG7a50bCpJgAfs+zqDMmfb8gOCUr3lzlwyNlE6egHMD419LiNb9/lYiLqhBlu5MnvIOmjnaCbrJS/ee5hiligaeYtHmIG+vE6640aplFCNJ/ZQP5k7Q7QGsHDcdVVVU9OLy1wOpNTJSzbtGg3OpYU4JuxSXX+RUCMKmA3EOGccI7m1FvQ+yOXTnDX20hHUgdB7qx+t+5XUQ7vpOYO4SrntSOr/DjbmZO14kSPW5chK0dzN7bt8oCWQ3BKAvEiQep5nudqVW2dwDqTL3EPObVKFVsQl5QVeFgXA4ZJ1kz928yTYdViP4g+nIBRqs/LZU2LTtfowAXyzJWpooGil1eYCotODdQj2w0fvtnv+QgWvY2iw5XsvqA3iI5beCTKTigfeNYvOtIMPYDQE7Fxp0FeL43eDW3xHurYLXMKI13EesXVWOErARvrp7JoRHf9R4gDGlYtB78KHmcX8Gvgr7rLNA4VchRc5FwKKs/2ec47LtfwjlQv1AS+oWyQHWHxFub5Eag/xqtPuVmccpUMvwAylEnMldY/hoMxfGM13rJr6DNQ1kDC4MYp9FfXm36h3Lql6X5Yd6LG1xHtByO3f29eVjt3UV8yA81k0IDVsiIU3R7XBo1PsXmZWik5sIegZW09VrLcwRbrKdL7mIaK20JkZx6TFZ6sHIZokJz3RIAJFfI1+rlFXL0m3AeejZHoP2/Vf7ePRP7dYQj8UdkyMAQdb2paDnXqCRg4AYK9EgGbjX4xYv1EsvPsOY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199015)(31686004)(36756003)(5660300002)(26005)(66556008)(6506007)(41300700001)(66476007)(8676002)(4326008)(86362001)(31696002)(38100700002)(83380400001)(2906002)(2616005)(186003)(6486002)(6512007)(6916009)(54906003)(53546011)(478600001)(66946007)(8936002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0JXNUdNMkpoOGU4Z2l5RitDblNJaFpWdVVkc1Avdk02Q0dYVEZMVFk1QUZY?= =?utf-8?B?SkwzV3ZCbHFDSHJuK1BUeEwxWlRtN3pEbVBkWGtseW11akUraElUWXQ3NVls?= =?utf-8?B?VFphMGlCYjV6TDBDU1hCS0syZGt0WDlOSFVwRTY1QW9TQU5vVTl4TnhyZ1pH?= =?utf-8?B?SEdwVTgvcml2Y2hyT1UyRXVZT1A4bGFzQzVaV01FU29VcWdhNU5waGpPdEx0?= =?utf-8?B?NlVnT2V2R3E0NGRDdXI4THhXaVczdkQvR0d0Z3pNV1hMTkZzeUNoYTcvclRh?= =?utf-8?B?N1lOTDVTMCtKM01GcElvUWVDd09OYWgwc2ZPU1gybUJaWEtUMmVaRE8xQ2RW?= =?utf-8?B?T3RvRWFwUUdOZnBzcEJzUmtJcFBmNUJoM296c1NsNUxSWmFPQmVoY2taQWo3?= =?utf-8?B?aTFQQTRWeENieTRjSHkvVTVJcklIcjBZYTBJNEhPZ21NbEY4T2pEYkRUTk1T?= =?utf-8?B?MUlwN2tNMU9kYnNVcklHMURhOVhwYmJNakpQTEJ1L1kvN05VQ2tvYjl0T0kz?= =?utf-8?B?Q2lTTU1WUVN5YmdNbzR4UW13MU0rLzc1YUlxbXZ6dlBtWWw1SERyZ0tRRzNp?= =?utf-8?B?Yk96TEw2cXpSZDdUWk5sNlduOGovbXVMMmhPbGFOREVQNDJjVVlLV2duOVVQ?= =?utf-8?B?WXE3UW91Zld1QXBUL2Z6L3MxWHlHWkFtUWVUeU1OZUFsNEZKYmF5aEtWdWpI?= =?utf-8?B?cUdaQVRpckdOTENlY2ZzTzNreXlwMU5tenZiN3Izc2xZcEpsbTdGQk1BUm9W?= =?utf-8?B?WFdXTjhmNmpiVU1pSTJOV1BkaFNqRUNtbHRrUzVoRkdudmpuaHN0VHFHaG9T?= =?utf-8?B?eTR0S3M2bm8wbC81VmtaeFNmUEZsQ1pmS09BOUpneWtNQjJKSVhUNk1ZN09F?= =?utf-8?B?eXZjcC9zd21jY2FWWmEwbnpXd3Z0NFliOWhHS0VndllsSWJhbm9tTldON0RH?= =?utf-8?B?cU5lR2MrUFJNSFdvd3BUbTZ5Lzg3c09vZzhieVN2WXdQRHlyTkhEZFMyS3Mv?= =?utf-8?B?Ly9QS0c5UDVKK2NmbytqUzhHTG95VGJVUng4dEpWb2RpbHNLUENSQi9BNVEy?= =?utf-8?B?dVNmNXhweGpDRXZ5c3g1Wk1xWm44Q0NxTkRXaXRadjUxOWpyV3o1bFFLZ1ht?= =?utf-8?B?T3ROZGN2QkdvN0swdGNRZEYxS1pxdm8yQjRPNFRqa1AyOWZHbWRJL2YxQVNY?= =?utf-8?B?UWp0M3BvcFB2bi9LZElDVllWcjk2RiswaG5zMy9abTFXcEdYb2NHYWZnbGlk?= =?utf-8?B?akc1MjQrZ3NQRVdMQUI2aWp6QXZCN1FVMlZFR251eXZaUUJEbnV5ejFUM3FW?= =?utf-8?B?dkJOY3Y5TFBoNVNTSWo0QUljM21yRkRXTm1WR21vNkx2cDJYZE9iRXVmM0w1?= =?utf-8?B?eU1EMnAwNHZoaUdGdlRETjBJM3JMOGRwUEpLelFNRHRYcVpISHR1anh2a2Vr?= =?utf-8?B?Z2Ivb2lwbEJ5S3lMZzNYaFd3bEtRNzZieFJLdWRubThMbFFYeHBiVDh4cjdF?= =?utf-8?B?RVJNVk9FNzAvQ2FzbWhBMlg0dTlISnhWYUUxcThHV0dzVzUzbCtPLzU4YXFj?= =?utf-8?B?T2E1RWJYWWRMemMyTEllWVN5cTJ5WHRqUURIbVRGdlorSEFwSHh1V2tzMzY0?= =?utf-8?B?MWl6UzVGMG9HcGljSXZobEdpSmxpRjFHQVNKTVppb3pTVVJndGs2NUViOS96?= =?utf-8?B?bkl2OWxURm5zbEZnL3JTRlpBSkxhOThkbjJteUYrZGJBTzZsdVl2L1Jjd0Vq?= =?utf-8?B?bDdSUWNWWjRlNTloMWtxaEp1L2htWTI2Y1FaVkFseTd2aGEwZjU5MnJka1Yy?= =?utf-8?B?Rnl1d3BUeWJiMm8zNjdWdVlPS2p0VlVpRE1nUFYwVzJyT1BMRTk3a1AzSTFs?= =?utf-8?B?QVZIRzNxOXdIQlhyQmw4N3NOOFE1bjZkVlkzR09iZ3gybzRsNUcvT3ZxTVZM?= =?utf-8?B?ZXNwQnl4Y2F4d1BELy8xZHFrbWVYQjZ2QUxCVWVrSzlpdXUvS1pzNit4aC9V?= =?utf-8?B?MG5LTk9RV3MrMW9nQU91WHF2YUIxa0ZjYkw1WE0rQzlmRUkzbHNsMk9UU28w?= =?utf-8?B?UC9SZkNmd2M2VXpJajl0VDhTeVp5cExRZ1JZQ0x5OTBJWWh2bXNaMzVPNjhF?= =?utf-8?Q?UbWmyHvoc2zAjtTa8Qb6GasgK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67938630-4d63-4309-5139-08daa210eba7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:51:18.4071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lhHeH5d36/Q1+Fv2hervA5+ilRdxAjsNeH/czMxPF9snFUwNwFxRV7VJIpptM176jY5TtfdQbkh5/x1Htn/FOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9515 On 29.09.2022 13:11, Roger Pau Monné wrote: > On Thu, Sep 29, 2022 at 11:51:03AM +0200, Jan Beulich wrote: >> With the "inversion" of VCPUOP handling, processing arch-specific ones >> first, the forwarding of this sub-op from the (common) compat handler to >> (common) non-compat one did no longer have the intended effect. It now >> needs forwarding between the arch-specific handlers. >> >> Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") >> Signed-off-by: Jan Beulich > > Reviewed-by: Roger Pau Monné Thanks. > This seems prone to errors, I wonder if we should add a note to > do_vcpu_op() to notice that hypercalls handled there need to be > explicitly forwarded from compat_vcpu_op. Perhaps. I guess if such a comment had been added by the original change, the mistake corrected here would have been noticed right away. > I've also noticed that compat_common_vcpu_op() forwards > VCPUOP_set_singleshot_timer to do_vcpu_op(), but that seems to be an > useless jump, shouldn't it forward directly to common_vcpu_op()? Looks like another (less severe) oversight, yes. Do you want to make a patch or should I? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 11:52:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 11:52:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413698.657510 (Exim 4.92) (envelope-from ) id 1ods5a-0004EL-4I; Thu, 29 Sep 2022 11:52:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413698.657510; Thu, 29 Sep 2022 11:52:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ods5a-0004EC-0f; Thu, 29 Sep 2022 11:52:26 +0000 Received: by outflank-mailman (input) for mailman id 413698; Thu, 29 Sep 2022 11:52:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ods5Y-0004Ay-FD for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 11:52:24 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28fc0660-3fed-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 13:52:16 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Sep 2022 07:52:20 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5069.namprd03.prod.outlook.com (2603:10b6:208:1a2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 11:52:18 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Thu, 29 Sep 2022 11:52:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28fc0660-3fed-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664452343; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=kuje+827cbvf8jP7uZ8RWEcrgtFakvL3/F53IBDuhs4=; b=h5gLr+vHTrWEUxEZm6pVcau4WNPIP0g2YoH9lpzByQVscp31BZ/mmzym fkf4o7EPzMpVom4geBJNP2RnQ7tNZJx7z7/IteDdop+H+y0s+LJlX2rJN OOsByrx5lOZZ4ATn7FxASywK6hJSqjzuHAeSqt0RK6lOBsTr7NoTSuZVY U=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 81599636 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6FXwXalSHVxFcZhIaMtlkOvo5gy3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWW2nQP/2JazGked8nYdux9BkOu5/XydA1TFNp+SE8RCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS83uDgNyo4GlC5g1kNKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWUREy tY9CDQxbEq+27Kkh+OXU/VFmZF2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1YZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r837KezH2gBur+EpXmp9tOqnmhgVcXBV4Ge2ewiL6WkgmXDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8U/4RuIw7DZ4C6YAHYFVT9LbNE6tM4wSicu3 1XPlNTsbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bs/7UZtNqEarwgtirHzj1m mqOtHJn2O9VitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:R9SGrqhlOU8nMgGD6iSJFRn0xXBQX0F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nGPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SuV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A7eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1whq7VBaM0pd gsCZ4Y5I2mfvVmE56VO91xMPdfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q 6xG29liQ== X-IronPort-AV: E=Sophos;i="5.93,355,1654574400"; d="scan'208";a="81599636" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=duLq3JHCUo1EKJjhhuEhA+eZ2kOfVVkV5BbIhQj6zPdoJBXLrWT5YclXbBQKcZGmaJCkJr+s7jQokr6fZPcW2bA5gTBs5yIFEUf2MN1chAQP6V39u/3KtuukMx7j0/q7AT+wCeenpUCHkCXyntUUeK6HtE4Ka8EneIPOunaZ2ZrT1IXzqTRiOG+XZbeJyHULdOSLZQp1W1XPywMWKltpUbtr9G2LPoQDwho1+LFVRZYYA4+/AZS2CJ2b+IzwEcZLEUhNeSSBSC0cTX2jGbEBgAVt7wTPNc/H2t/xaIyLQvBN6gS7XXGoKqjD5TY5FkR2lZbGGXSlPO1URUjjEDZHRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgHz8MTh19YK53dT4jZv66nPGZ4MpH2L//3viF4uduw=; b=NLrvIqOm172/6eSRHi4m7dUSSio13yVwOZ4OxsvkB6eaKWFOqxN/1sRX4j/xFezHf0CBBLRHtCWQhpee+jzZXQIDEHqqXEjfzNi5plBLxp2gZ6PbDEV9Jgh8zF2fyH6PZhUKc4MQnAjPC3CQbw8x6n8w12Dj3c0AP5MWpVa2LfIFprmLWLtYCV9l729naP/ycBz/HdlVGMXwW7wPEUyKiY0IXExRQGUflQkCNMYOWM58meckBio3qv+MVo+/OIMn57EqGrzmraBfQfkgILGrNpQVd8RIELCpcz4qCyvaECTJc7KELpIhJez1f53W88ZnR5b2UO6rtuevBAKGX6JWAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgHz8MTh19YK53dT4jZv66nPGZ4MpH2L//3viF4uduw=; b=WPe+6TbtADNhNm52et42UXWKf2orZ+OtHFZlRP+9Xm4QYU8SRmpZSNif5FmpZGo4+ApjuD0DTdXBomaVGqFrrlcOVVyVKonIyFYIs3zryLuMQDERZPSvROHcBwd4I1+bgn+IdBEsMZlRbsHfoWsCEYwR+tpudVGElUOsqgWWtpc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 29 Sep 2022 13:52:14 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, George Dunlap , Anthony PERARD Subject: Re: Design session "MSI-X support with Linux stubdomain" notes Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BN9PR03CA0968.namprd03.prod.outlook.com (2603:10b6:408:109::13) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5069:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b76d9e7-7511-46e4-9d8e-08daa2110f38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o1HSQ4HXVgujQCjayVOQjyUi5KWPBe0KSNcYKKZRBaJbMC4aGftD0Z3K6QgFKr1Fw3bwdl5hqluXQE8UtRVTPvw++CH6NEpixJ4cw2/T18dfMZ9lReu04rsgVC3vmONTtlZrGj6F8sFoIh20/7yXv41OzksWIfLq8e9o6+NlTUjGDhcWsec9c09jX/TQRrz9bEcW1YxAeJTUnAPhhNd//ZReB/SvJVetrNnj949e3PefN0+o9o9K1Nl44AIoZkSQkithY1cDTPAxNXqOrtCrfPdnHBUDXDt8TVkMNISDJVMvAJ27jwy6x7XYglnkTb/8sfCML/d3TKzvP5+SFlBN66JE4pqmg16WGfle6KytP7LBUPll181ybeHGffg2ldBNPCZvpOsOSiHmm79oyaSiZsNXv1ut0dJkuldlagKefIgUY9vJ3pCBbX3cxGiUuc5w7FX/FnS9AjPQJ7XBkLa0asUlvPwOmHQzws2ZlHarsKXkYlNgVNlaxxZwA2vdfFx19JyUF4cfpqBkqK7JIIWBXE/6Kj0IxxnSJQigTGLKCjYyis7LtuwT/1nXxYhl6N3GY+RY2JJsfQFXBJjD+dh9Z6bxH01XuCHevn2Fom+a9Id2O3TTJlUHztG3GZBVapZmdv9AK1rans/Ptjx4aaetPpEepBe26vVJKEx5P9HYdUN32ZfX3Kx+nW4bFO7zDUaaee/9tVsv8wiSLmmVyusFCYV3I0cMqrUcUus9ugTJENo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199015)(66574015)(66899015)(85182001)(26005)(5660300002)(66556008)(66476007)(6506007)(6666004)(107886003)(41300700001)(8676002)(4326008)(82960400001)(86362001)(38100700002)(83380400001)(2906002)(186003)(478600001)(966005)(6916009)(6512007)(54906003)(9686003)(8936002)(53546011)(316002)(6486002)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWpGRFE0eGdPOW1vYVM5UmdySnE4emVuTGVFR0ZDcHBCemlQeUhBNnBVMVB1?= =?utf-8?B?UktJaWV5MXU0VzJnN2dPRWFmaXdYblo0Y3lFVTVERnY1cnpYVlpENVRJcDR3?= =?utf-8?B?YXhKNEo2RmQ0RExuWHBwQ0hKcGtXcUNOM1BxeEd6RGdVQzhzZkRzVEsrU1k4?= =?utf-8?B?bVBuZE91VTl4S3RFOUFHbEtMTVUvbFRFMDh4N0IzKzNTY05wRy9vV3lwSG9i?= =?utf-8?B?UGp0RDY1aDZvaVpMSmJITHRXZTRiUlp0c1d5VVVvN2tOQ1F2VnJVQWwzVW1y?= =?utf-8?B?amlIWHpkdVZkMGdwMUgrclpQUDZrQml2anRVa0ZsZVRTUTZ0S2lRNU4wQjJj?= =?utf-8?B?S2hpQ0pVdE5KaEt1QldscDQzT05CbHY1N0pOMWs0d0QwV0JHU1dKUHlvdERm?= =?utf-8?B?bU43NU1sVkl3NmNxVWJNZEZPQUVSVzJGd2doZy9nMnh5NU1RaTJnMm5tQUJw?= =?utf-8?B?MWVDd1ZsZW5VUndUTHRJR3RqM1lHSk1yd1Ivbi9RaHFNS2xJQmR1V2o4UE1D?= =?utf-8?B?VVR1Y24rOXhWZW9UVkJxNytZak9QekY3dWR0QzhZTEpGZng3SmNBaG9qSkZi?= =?utf-8?B?T2pQNEkyWXo2U1ZkUGJINGVoQjh3c1J3UjgrT21Ybm9ra2ZhbUlQcDFrbml1?= =?utf-8?B?cDhTdFlZQmFXenRxbHpMNWRkRUtWN1JJd0x5QWdoc1I2bWZ6WnM2Vmk0bkRR?= =?utf-8?B?eHdCVUJmRVdLZVNyenpKeHJFbDdqN3dQdGJMU1JQTW1OdHlGb3d4Qmh0Uk5D?= =?utf-8?B?RjlCVTJWS3lxamdFbUMzVUdsbDJpb0g3RC8zelJzZ2RZeGo5K2o0dHhqNFh0?= =?utf-8?B?S2Z2ZXNSTEgvNktIRFBpWU0veFdkRFNMWVEzWVRBZmMrWU1IZzMrdjZ4Y0Nj?= =?utf-8?B?MXV3MG1NNDRkNklCUWtzT2lscmlZbk51QVh5YkU5dW1VRCtSU3crQVJlSnMy?= =?utf-8?B?S1FobHlhSjdFejh5UDlCdWxyZ0g0bTRnOSt0U0VsdU1TamNyOGducHYxWnNq?= =?utf-8?B?YWc2M1QvcmpFQyt2d0RmSlpsTkdTZXNzWityYmRzcHdXYXN4N21MN1VRQnlz?= =?utf-8?B?L3VJbnc5WlBlN0h0RFpUZjdFb1hTS2l2QWh6VkloWDNEOTRYZ1IzNkNwMmNR?= =?utf-8?B?VnVnRzlTUmVEVlVmTXNBakJkc0c2NjY1QjY3elEwbkNXOEJJYVpyc0hWaGxX?= =?utf-8?B?aGdNaTFlRjF3M0Z6NFNFcE1HQVJiOFVBLzJkdjVhOHgxSXlSbjRhSElEQ3lq?= =?utf-8?B?SWN0ZHl1dzdiOTJnOVgyK1h1L2dhT0gvTHYrNzJmbEJUajYvNkpkbzJwMEJ2?= =?utf-8?B?cWxKZzlOdWl5eUt5aDgzWGsxR0ZYWGZ1OGZtOVFxRW91UG80Q2lqc1cwYUh2?= =?utf-8?B?Mmd3cEtFS0x5dDNnQWlJaTFqNC9DL21odzFKS2tVNm5LZmZDbjJYU2FZb3RO?= =?utf-8?B?RktnVVJpRHo1aHlCdWdrcEVQdlh3eGkwUUFjMko2MDF3dmlXYlU2ZUdrQ3hp?= =?utf-8?B?R0F1UzUzVndsd25FT1o4cHcyNFpXaExlT1BGTXJtelZHWDlCZXpBTnduaDFa?= =?utf-8?B?S0NrQjFYWC9HTjFzKy9KUXVPeXd0RmxHWGpuc2hIWFlLaWxXYjFTNmFsUVBS?= =?utf-8?B?RUZDUk5MdC9sMW9tQzFvZ3RwemdYQ205cWNsOW55WW1vVXpNc0krSW9jckNC?= =?utf-8?B?ODJZNW15L2tBYzZoeDg5RnZqdVFLSjgvN2swdHJtak53WjFDYkVYSGh3V0p1?= =?utf-8?B?a0ViWWdGeURFR1hYc08ralFMU2NBYllZamYrdFphNDdKWStZS3puSVAzc3FK?= =?utf-8?B?cjkzc2FhMUVDUXI0LzB5bThTemFySlFlSWtaM2ZNZ1l5dlZOK1ZTUVJXZGJV?= =?utf-8?B?YjdUd0oraXA5OGN1NU0xUm83VzRrYis0QmZkeEZhUnlRMklnMXArTk94TCtS?= =?utf-8?B?TTlQQ1pvZjU5T1pzTytmcEdaOUZhaUxNN3BCYldrL3Y4REtYaVpnWHl3RFdG?= =?utf-8?B?MzhLRTM1WXp1U2RtcTRNNEdwZklIWEtPOUh3OFFLamFTMVppSk9GN3FibVYw?= =?utf-8?B?VUFnMVpmcS9UMk11QUN2bGprS2JCSU53amlSOHhlNkxuQlFzYUdwNFM5THls?= =?utf-8?B?aldtbUtCaVZtMFNxRFo5QzBEVmE4ckh4YTJ5SnF0YWJ6RXJCbW80QWhhZmRZ?= =?utf-8?B?c1E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b76d9e7-7511-46e4-9d8e-08daa2110f38 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 11:52:18.2827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XP6UAkkkwjTBc0KSfH9FtSIicir8N/879D8gG+25q1qUdSipE9Zl7KFB3nfm0zxeNqpnZ7/edoRLSIOU0vXOpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5069 On Thu, Sep 29, 2022 at 01:44:28PM +0200, Jan Beulich wrote: > On 29.09.2022 12:57, Marek Marczykowski-Górecki wrote: > > On Mon, Sep 26, 2022 at 02:47:55PM +0200, Jan Beulich wrote: > >> On 26.09.2022 14:43, Marek Marczykowski-Górecki wrote: > >>> On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: > >>>> On 22.09.2022 18:05, Anthony PERARD wrote: > >>>>> WARNING: Notes missing at the beginning of the meeting. > >>>>> > >>>>> session description: > >>>>>> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn’t > >>>>>> support MSI-X. For the device to (partially) work, Qemu needs a patch masking > >>>>>> MSI-X from the PCI config space. Some drivers are not happy about that, which > >>>>>> is understandable (device natively supports MSI-X, so fallback path are > >>>>>> rarely tested). > >>>>>> > >>>>>> This is mostly (?) about qemu accessing /dev/mem directly (here: > >>>>>> https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_msi.c#L579) - lets > >>>>>> discuss alternative interface that stubdomain could use. > >>>>> > >>>>> > >>>>> > >>>>> when qemu forward interrupt, > >>>>> for correct mask bit, it read physical mask bit. > >>>>> an hypercall would make sense. > >>>>> -> benefit, mask bit in hardware will be what hypervisor desire, and device model desire. > >>>>> from guest point of view, interrupt should be unmask. > >>>>> > >>>>> interrupt request are first forwarded to qemu, so xen have to do some post processing once request comes back from qemu. > >>>>> it's weird.. > >>>>> > >>>>> someone should have a look, and rationalize this weird path. > >>>>> > >>>>> Xen tries to not forward everything to qemu. > >>>>> > >>>>> why don't we do that in xen. > >>>>> there's already code in xen for that. > >>>> > >>>> So what I didn't pay enough attention to when talking was that the > >>>> completion logic in Xen is for writes only. Maybe something similar > >>>> can be had for reads as well, but that's to be checked ... > >>> > >>> I spent some time trying to follow that part of qemu, and I think it > >>> reads vector control only on the write path, to keep some bits > >>> unchanged, and also detect whether Xen masked it behind qemu's back. > >>> My understanding is, since 484d7c852e "x86/MSI-X: track host and guest > >>> mask-all requests separately" it is unnecessary, because Xen will > >>> remember guest's intention, so qemu can simply use its own internal > >>> state and act on that (guest writes will go through qemu, so it should > >>> have up to date view from guest's point of view). > >>> > >>> As for PBA access, it is read by qemu only to pass it to the guest. I'm > >>> not sure whether qemu should use hypercall to retrieve it, or maybe > >>> Xen should fixup value itself on the read path. > >> > >> Forwarding the access to qemu just for qemu to use a hypercall to obtain > >> the value needed seems backwards to me. If we need new code in Xen, we > >> can as well handle the read directly I think, without involving qemu. > > > > I'm not sure if I fully follow what qemu does here, but I think the > > reason for such handling is that PBA can (and often do) live on the same > > page as the actual MSI-X table. I'm trying to adjust qemu to not > > intercept this read, but at this point I'm not yet sure of that's even > > possible on sub-page granularity. > > > > But, to go forward with PoC/debugging, I hardwired PBA read to > > 0xFFFFFFFF, and it seems it doesn't work. My observation is that the > > handler in the Linux driver isn't called. There are several moving > > part (it could very well be bug in the driver, or some other part in the > > VM). Is there some place in Xen I can see if an interrupt gets delivered > > to the guest (some function I can add debug print to), or is it > > delivered directly to the guest? > > I guess "iommu=no-intpost" would suppress "direct" delivery (if hardware > is capable of that in the first place). And wait - this option actually > default to off. > > As to software delivery - I guess you would want to start from > do_IRQ_guest() and then see where things get lost. (Adding logging to > such a path of course has a fair risk of ending up overly chatty.) Having dealt with interrupt issues before, try to limit logging to the IRQ you are interested on only - using xentrace might be a better option depending on what you need to debug, albeit it's kind of a pain to add new trace points as you also need to modify xenalyze to print them. Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:04:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:04:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413708.657521 (Exim 4.92) (envelope-from ) id 1odsGw-0005xJ-B7; Thu, 29 Sep 2022 12:04:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413708.657521; Thu, 29 Sep 2022 12:04:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsGw-0005xC-8J; Thu, 29 Sep 2022 12:04:10 +0000 Received: by outflank-mailman (input) for mailman id 413708; Thu, 29 Sep 2022 12:04:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsGu-0005x6-90 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:04:08 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2041.outbound.protection.outlook.com [40.107.249.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d150181f-3fee-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 14:04:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8381.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 12:04:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 12:04:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d150181f-3fee-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U8HMXv0+rnkx0Pm+t6xrnCDccqCkHnYaN4WNv2971ynbaEoXPNBoTpu49PQflylbUWCMl1sXZoW8upnrBEOo/MzGVLe/aCdXtTJBMJPxquQaTAHIumLm3edKkyoCqOlJryx9evV3uqMBj23xHOAG4GohW8To7ijmOONHCxslMCg43lUt4zM3YFFVBbWxsbraZMQ/A+d8EQUImG4c/WLx8mxhPRUCuf7S4VGXWaA9RSDzuBh6UtKLYpGZEBQS6FtlscVtUYZSOQfDyaeZu/YBxdYydcBt3KI3YZXyINCT+6MT9ueSsltVepwlb+YDKKNxCNXdNtCXUggqJtZYkPHQtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v/GPkFlpiV1Fn20lTbvZ1wTNglpXT2SVatLeLOg9XLw=; b=ZraZ9qlQr9ZWtDXNF5Qvv9ropbPAEp2JUO3/ejDz0mSC1pEdnH4TBueCUKroap0v4ZJflZsnXjpNN1cx4tZvjX3lf8Ult/72+pi/OMI0KvT4qAts9hyWKLqJaB6SDpj4l31KQo4Fgs9Dlv6CyZqDmpO+pK8Lev0uuLHg7T5KHCglULZlIJETFkdKR9B1z7FTYoGG64w6qhOE5q8kFQHn6+KsCC8MB7iPKZr4rVheCjRuj3UW6LRaWNISvhqPSQ4mzQRL0f7RS21cSl9n3QNjCC9opuf0YQBVwnCkhY20bAvcOyxSDxcNAXQvSgefz0Fl8kIYb3ijrXoI94eMNr4haQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v/GPkFlpiV1Fn20lTbvZ1wTNglpXT2SVatLeLOg9XLw=; b=hWqariAOE3wTs4MJAKSAybDvk4p9OUpZJ2WWTYmnW4q6cC6MNgQDt5+cJ5lDlaHD2O1PHv+iDzmnfrUlWxVW65hdOTt8Fi6InfFaVDl9OO7PJPopc6Kjz5cKmFIMvY/PFzHDgB5zoyJmeOi720XZl6328dKCBIK8Bn/2V1bwpX4S5nq1goB0jrVv8BEg3gIJYQbzSEnvRTiPiNXA4i5GCuCmZ+b+5frbcmTyKd1Cnyak6bgPozw5BF9FXmWCL1+H40/hB70DT0Udg0oFBYUjxapcnwhnnD0PGbNDoFVPScmRHsjGji5z9l1IQz7V5S4FtPvaskHjELEafiBDv/+OuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 14:04:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/2][4.17?] x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Henry Wang References: <96adeb88-dcc4-5ca2-54a4-883058169dbb@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR1001CA0062.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::39) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8381:EE_ X-MS-Office365-Filtering-Correlation-Id: 78556c5a-3e58-4d16-c6f4-08daa212b45a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eNfm0S8R16zSDlyzErKveHC8kpRlFMKAaO8n/qkO0/gIdKQXd//pDs5zUKD4tLvDGKBeblimZm/hD0h2p4anA1iAfm8pOdshRsko7vIgdXt2NKgS3aAFy5N2J3/QwMYbPuzKBDvg8m84+szbeP9q3XE/5E5ghIiHn6L2EpOt/mbLZVVLlVodazm2VZOA3EPG0nTrBHNeeIBB1WnIpQTRIhB6RmOvmrsStWSDBgtVkcyoQx2kK/Fe/cqnu3yGyThcRkRMqO2x5EFEs0iE6ivLmT96EEI+5K0Pa3XeI9kJKVEjFm5uzUnmMEiTRvd2vk+4QbkEFwbpR3HSwci2idBxxVUhVih+ES0LPtqOLr8mcLSf8TOXiNiHEe9tI6MntUVVeITX2NKWZhJe2PC3hO3YUs7gYSlzXnSUKFI2GAOr/4Bs7oVBIi2G3vOv6nLVhVkui8CpD7gM1OmxplN67BitZPIFw24xrwWyYDUaf2yoV6tXtgoRMEMr2tOyXD4lb4zP+je9zVKeO1vR30621+CWq5udCTLU+NzNK5ZihdxHIjrqxgB5PJ1vMnYNu57T5l1/rort3bSc1RvxlFs+NA2xUX34aGb3TrMVQunD56/2lnly0xHw+MAFJrgeHPm7hb50L4RAfmrPofYiGh5VS9KHABxfEWuF5HDJ5JL77RKKhKXqYTshcNJ5ehONAUY6liqM4kCbwKg1bpQvCGR8QY+PhN90RisMZhmMwJPDtNGCr+j05C2YNZ8OQAEGSiACvZ8n8R/51mLokQF4SGGFka/G9l/GOUXP0pFqsLyyYlRM93g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199015)(8676002)(36756003)(316002)(83380400001)(6916009)(2616005)(54906003)(53546011)(86362001)(6486002)(6512007)(5660300002)(31696002)(2906002)(26005)(41300700001)(6506007)(186003)(4326008)(8936002)(66556008)(66476007)(478600001)(66946007)(38100700002)(31686004)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGZQTWtNTThBaWRha2VCb1VSeW5hNUlwRUNKNTdvNHhPSTBUNDhsN1hhbnNQ?= =?utf-8?B?OFNoUkU2aVU5VC9NTDJ0TENnRVZYYlQ1RDRkUWQxcWlKMWFiY3padG12TThy?= =?utf-8?B?MTRySm4wNmdJZ1cxdFN6N1l2b0lhMStxazNYczBrK2xpQ2FTc296NkdNaGlW?= =?utf-8?B?ZklxWWVDODlpSG94eCt4a0hreER3WGQvdVRDWUY4VmtkMWdVSktESERFZ3dZ?= =?utf-8?B?VGtkdzBCdkVLaU9OaTM1RnhSRmd5NlBzZ2t0SVFaL2E4cmxNZ0daNExBZFIv?= =?utf-8?B?c29XZ3JmNWNmUEp5MGFLSUREZlNseWMxMUFhK3RoUjVyUUZoRE0wRTBJdnJC?= =?utf-8?B?T3RXcm5JeG9WTGJTNUk1bkV4cmlGRmdFcEVyK2VnaWtIYnl3ZEtwK3pzSkh5?= =?utf-8?B?UUJNNFllTWp6V1dKclJJODd1K3piL0l0Y09ZL0kwVllOK0dKK3VBWmFwM1VX?= =?utf-8?B?QnVCaWlvTVZiVGZPWUg1MmkzZkZWRXlENXU2S081T2FEbC90cnF5ckR6Q056?= =?utf-8?B?RkJJTlVzVmxZT0lzT0x4SWpwN2dOeXZtc3kyOG0rd0Y0UUhCeCtoQWJTNVVr?= =?utf-8?B?WTRzbHFvMDhMOE5kZ096U29WTzBRaDdUdEd2OUUrS0llUzBGVWZ0YTJxUXd0?= =?utf-8?B?emVWejluNk9pYS9BTlRXOFZuTmVUekZjQ0psZmFRN3RnMUc0RGllb25UWm83?= =?utf-8?B?aGtUZnAyZWZTL1EzZkpnRitEODdLVVovTDhmYjFsNG94Zis2L3FndHowUlJH?= =?utf-8?B?S2dNclRXbWRleUd4ZjFGZTRpTXVaMVdvVVVEZUs0UnNGbk1JU1h4K0N1MWNa?= =?utf-8?B?SlhVckxFY3oxYnIzRjhkUlZ1SHJjSFk5bHpkUEdYYTR0d25KeWs1dTNDZGxu?= =?utf-8?B?SXZodFFUUVV2d1g0K0RSZyt2VC83TW1RZk0xUk5XZ0xpTS9kUVJ2c1RuWTNm?= =?utf-8?B?blhEWmVtdW04bHFRZnZ4cDdrS0p3MUFsZDRkTkQrR21jRTlkVzhJbUhXaWwy?= =?utf-8?B?Z0U0UXl3SGhlV25qSDVSZkpqdE8wYzd2bUhIZUVkbmRKRC9GWnRXTmFRMk9t?= =?utf-8?B?UGhkdnhDc1QvVEVkTmVVazVXR1BBc0IxbzFWdkN3OG1Va3NRNVZDbmdabGgr?= =?utf-8?B?ekF0UkFtMStLQVJ0ZThJRW9mUXBhMitLVFRDYkx5TFhkaXVmb1Y3Z1hNaHlI?= =?utf-8?B?ZmFvbUgwdlNJbzYreTZ3dlI1S29VbzZwckZ5OTNkemd1TUtyeGRWODZ1QVNj?= =?utf-8?B?a1ordFJDNVE1RGtKNXp0Ulg0SDk5QXcwS0tpQk8xZ1lQUVNYcE5RQTU5RU9G?= =?utf-8?B?TG9kWTFSbTZrc3I2aFZiT2RYbDJFMDdta3JYNlNqY0huYlVwcWF6R0JPRVQv?= =?utf-8?B?ekV5NGVoUUJLSkxTNjc0bjd0UWh3R1hFUWdVM3R0ZlVUL2dJOXNPbGtBTUY0?= =?utf-8?B?OHlreGRRd2dBQWpXZnJyTzFNUTh1YTNMaUNQVjdtSEdTVXlhV0pPc2Rjb2Iw?= =?utf-8?B?UlFMTlRSNzN3OWY3UHdUb2Yzb0RZYUVCMFRuTk1aakRQVFhvMnVQaHRlUVQ1?= =?utf-8?B?ZnVMTTd1bTVtUlpNUFZGa210Ym5Mb3FWR1B4c01YMUVXQnhJZWwvam5PWVl4?= =?utf-8?B?eTB1VWQrbXg5QVUxcjkyeWt5T2dyNHBYR0ZWd1JHcUFjRFNYNkdMeVh2T25Y?= =?utf-8?B?UHdEVDR4elNLUnFJQ1NwWkFpSmRiSGlRWVFhQzB6VFZjYjcrYnplV0lKc1Bi?= =?utf-8?B?ejhYUkRQWUhvTEQvZzF1V1RDWWZ6TndzRG9lKzJJRkt6MjRjSnRFMUlxZWJM?= =?utf-8?B?Tm9tb1F1K3NvSUsvZUI4ZXRpSDhNdlZycGNBVTBwSFZ4WStsU3ZwQ3p1dlpM?= =?utf-8?B?ZUtoSkVzdUt4emtzVUhkaDRocXluMjJ2RFB4VVhhZFhqOEJyNVBKSDZ2dFFk?= =?utf-8?B?clVETmFIMmlsZDhXSTZOSjVBdFZVVU1OOGhZNHVvdEdqcTNCRlVHTEFNZUgv?= =?utf-8?B?VElaaFd3bnkrNGNhaTQyd25sL0gxVU5hOGpKWXVMYmRKOUhkM3FlRFRiQ0JC?= =?utf-8?B?cFFGYlVCUkw4dEN0TG8vZlY4WnQ2L1lOdWYzQjF6eWZRSm9xZFJFaFNJNEJ2?= =?utf-8?Q?D5USjWsxa8SUXEmpTuS7daSzR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78556c5a-3e58-4d16-c6f4-08daa212b45a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 12:04:04.6555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a/HjGaEQrjgoD7M3yfnoNxFrPZVI4Z0yXIDbe9QZjNW+A0yTxAVAfXIDrGWUbjBNjXyOCCsvUpKyCYQoiHojLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8381 On 29.09.2022 13:37, Roger Pau Monné wrote: > On Thu, Sep 29, 2022 at 11:51:40AM +0200, Jan Beulich wrote: >> Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area >> was available only to native domains. Linux, for example, would attempt >> to use it irrespective of guest bitness (including in its so called >> PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we >> set only for clocksource=tsc, which in turn needs engaging via command >> line option). >> >> Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") >> Signed-off-by: Jan Beulich > > Acked-by: Roger Pau Monné Thanks. > Albeit I have concerns with the notes you raise below, not sure we > also want to introduce a (broken') compat version of the same > hypercall wrt v != current. Since "compat" is ambiguous in this context - I guess you don't mean just the variant for compat guests? Independent of that I'm afraid I don't see how a separate variant would help: If the cross-vCPU copying is not okay, then existing users as affected already, and would rather have the single variant work correctly. And if the newly added variant would be the one with the broken behavior, why would anyone switch to using it? >> --- >> Is it actually correct for us to do cross-vCPU updates of the area here >> (and also in the native counterpart as well as for runstate area >> updates)? The virtual address may be valid for the given vCPU only, but >> may be mapped to something else on the current vCPU (yet we only deal >> with it not being mapped at all). Note how HVM code already calls >> update_vcpu_system_time() only when v == current. >> >> I'm surprised by Linux not using the secondary area in a broader >> fashion. But I'm also surprised that they would only ever register an >> area for vCPU 0. > > Would be better to update locally just when v == current, otherwise > issue an IPI to the remote vCPU dirty mask and force an update on > resume to guest path? Yes, that's the outline of how to deal with this _if_ we determine the present behavior is flawed. Determination is difficult since, like with so many things, this is something that's not spelled out anywhere. >> --- a/xen/arch/x86/x86_64/domain.c >> +++ b/xen/arch/x86/x86_64/domain.c >> @@ -58,6 +58,26 @@ compat_vcpu_op(int cmd, unsigned int vcp >> break; >> } >> >> + case VCPUOP_register_vcpu_time_memory_area: >> + { >> + struct compat_vcpu_register_time_memory_area area = { .addr.p = 0 }; > > Why not just use { } to initialize? I wanted to match (a) the VCPUOP_register_runstate_memory_area handling further up, just without using a separate assignment and (b) this line if ( area.addr.h.c != area.addr.p || And yes, initially I did consider using just { }. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:08:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:08:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413713.657532 (Exim 4.92) (envelope-from ) id 1odsL7-0006gI-Ty; Thu, 29 Sep 2022 12:08:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413713.657532; Thu, 29 Sep 2022 12:08:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsL7-0006gB-PL; Thu, 29 Sep 2022 12:08:29 +0000 Received: by outflank-mailman (input) for mailman id 413713; Thu, 29 Sep 2022 12:08:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsL6-0006g5-2v for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:08:28 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 684743eb-3fef-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 14:08:20 +0200 (CEST) Received: from AM6PR10CA0022.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::35) by AS2PR08MB9426.eurprd08.prod.outlook.com (2603:10a6:20b:5ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 12:08:16 +0000 Received: from AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::e8) by AM6PR10CA0022.outlook.office365.com (2603:10a6:209:89::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 12:08:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT043.mail.protection.outlook.com (100.127.140.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 12:08:16 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Thu, 29 Sep 2022 12:08:16 +0000 Received: from 0e942f836745.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 04ED3472-6FFE-4F9D-B03C-6A98DB09931B.1; Thu, 29 Sep 2022 12:08:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0e942f836745.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Sep 2022 12:08:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB8277.eurprd08.prod.outlook.com (2603:10a6:10:40f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 12:08:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.019; Thu, 29 Sep 2022 12:08:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 684743eb-3fef-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KsRYhraHtBLQWR+tc7+CGVxQttQnjlHd228DMD+EXLoNFatvEZdTp6XU5NilEq+JnIcNZJAV6gDYW+0DtbuCQXEMW+njNc6z9JZ+pPjKYYiSmqSm8jek/A80Ze1mXXHElofQAWP5wwCn7MW4/Gvei9+77QFjygdYTj2yJZZIa3B2T296okSubylEA3noFCPgPMr72PBx7+gvtAU3imhqOEcRnRRHObiP5BezU0YmLA0WRL+uzDecsX0VXffstkuAQDzuIQGWxDZqAzy6MNRNPy23gYSbFEHz1/OOPt6Izya98Rc9RFPi6NKaGoku4rilw55ohKaANeyKw5b9oJ0GdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bNYnYCt5wgmdmTpjs8A09erpqq+3ycDz7WjGP6Qvkyc=; b=TSesAkwLL8y6RGexku4G3pRVcIWcM/igMOx9BIVBieFckspn/CqUlYlSwTqOh2EwgDc+BpnmVvc5H5pROXBNUeYlETknrm+rSTmn18JRbL1Rv8xiL5lKibKaIU0Hn5y0Hfv0QbpHymjRGtQzuc4jdmerV75mbCA3g0Na35lvo5VqyacK8TKGFCryI7EhptXvFJcE2q0cT0eGrSFZsvcTYBBz/NWPZZlMoUrcdz9YCGur6aR70chMl8d28Djcn6H7WTGs2L7er3NYEYypVBTp7cSWOsVKwFYw9misd4FX4Q3fNH9xhVAwahOOzIoZeYk9mW7n3U+7T5ioAfQCTG/8sg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNYnYCt5wgmdmTpjs8A09erpqq+3ycDz7WjGP6Qvkyc=; b=RnAvmnxMRypWOQM0BoE16au/MF7ybgji+5zmTsmi/Kn6B6bUBHxwrdmEeqtvBfzG/NSxDZQn+x+RYC+n/wpZD04+KCCih3Qr8prw6yTR2whaOLLiZ3wGDN3QihPkaI58rHBxagE4PuE3l3ESlpPjM2UiXH01rKjnx9rXnj6Dh10= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a777a96faeb21193 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IefyNYxyP218Q+Mp7WaJ8Q2eRZIaGvnprB2PFntuGDnk6jC5uD8rkVA3hfiNVgTMQh9moXr9eneei3V8OauB95SClpTM+o28BVZZwSFO1iUY9vJYjZcBFrmGnqdqbesC1U27B7928I/mtDzLC5jwNWqzambz45BV6bauFelSEIUEXuxYxALV7PG0mKVXe+zc4tjmQr8G9X+vwbezeOQn6vIymJu+YTIQN+bf0nDJZU9TBnWHxgM/zRjdKrLRgYQOp4a44U/69Ik/maryHc+FB9lfXfG/8+WxM2eD6fiWk+40zAIJ+88aLp+iBSEy/1vbomzqhtyoQ8RadgzSSaTYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bNYnYCt5wgmdmTpjs8A09erpqq+3ycDz7WjGP6Qvkyc=; b=LmhbobdKD+L19OvKHH8rmMK2yvJapAr99678BImqR5lBHhyIzezJqP+1gZWUXLrpIIrRtB8wkXsdm+DYmW6ti0rE/1+61Rkrs3+8Fvvjxp24vsHcZXDmXHAqQIAHDdbwK2ADgOhqChJupr3gYkeJRWk1S9rL9Z3uyrh+PMBBrOpWLu17MhZV+4gEnwr3nFhrYKtyCUGKEB+MBFT8bY4Kw7gUZz9FN/zD1iiiRiQx3ys9FipIyKNWW88+c7o79PEgWTjz6OLcSc7qdID0Iv2hJL0a0Cipbjmg9lRfCFZj/t++512OThtX1kpMM3+vekDLWzidGTxpI2fAdyvcD4A6+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNYnYCt5wgmdmTpjs8A09erpqq+3ycDz7WjGP6Qvkyc=; b=RnAvmnxMRypWOQM0BoE16au/MF7ybgji+5zmTsmi/Kn6B6bUBHxwrdmEeqtvBfzG/NSxDZQn+x+RYC+n/wpZD04+KCCih3Qr8prw6yTR2whaOLLiZ3wGDN3QihPkaI58rHBxagE4PuE3l3ESlpPjM2UiXH01rKjnx9rXnj6Dh10= From: Bertrand Marquis To: Jan Beulich CC: Roger Pau Monne , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 2/2] x86/ept: limit calls to memory_type_changed() Thread-Topic: [PATCH v3 2/2] x86/ept: limit calls to memory_type_changed() Thread-Index: AQHY00RZ62t9oHqr90W0wJ20vCS6F632MZIAgAAgIIA= Date: Thu, 29 Sep 2022 12:08:01 +0000 Message-ID: <7764D305-5415-4AAE-9B36-5E123A5FA5E1@arm.com> References: <20220928141117.51351-1-roger.pau@citrix.com> <20220928141117.51351-3-roger.pau@citrix.com> <576b8ac4-7ebe-e8eb-2fb8-2cb7f592d585@suse.com> In-Reply-To: <576b8ac4-7ebe-e8eb-2fb8-2cb7f592d585@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DU0PR08MB8277:EE_|AM7EUR03FT043:EE_|AS2PR08MB9426:EE_ X-MS-Office365-Filtering-Correlation-Id: de457755-5f36-4083-5e6d-08daa2134a94 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f5sFy2aAwyKaBmDOGXvP28VSgY02p3VfYtfsyWBAmJi3qGpygat1SLb6jNlKc2x3SfOX8YJchMHAOCWNQwW8afFzC83g5STjP/N2BB7mQItzBh0Voq9gqTKL64GGf0OIZLmN+27YaI/RBcX13M34PZQ00e5KWVffd+7r4+VYbiBYlpXPtPyMlNO8+UJqMbTJEkxCMflKD20ZPS7+q8fO4/DKsW5RoPak00OqccEge4EUQwolOI7zc5VdNptxB89BN6BI5LXxO7d0zFwj9XrFUZHgcvU9P4bhc7RwHB9HpzKtpuWPJ0OR7kdJwpS5yWniQXY28C0kxiAB07jiJc0Vj6sICcBPoekiavp77CAoZr31ujwHcOTKFlFjllIuipOk9djXSQ0RfO+oVV4eUf9cZkXvi7x5bnS2UtWRAsZSYPG61LlkTd9/b0OSv0Zfh8vu1b9MCA3KthQZxO7DScFxNuHshXA/6+eej3oQf76kF1jwrCdgZgtJH8Zu5mAmms3xDNqvmTVYIMuYL7cIjgQadzf/s/NonswMAA6bUFhusJORJWDGlAyDj0QXit3NOJ/buvSr3kjguFxjwqEWVsBb0SJPdf1TNFHMudhjPIYyBkOqn5UEVuqZ4iRPwUHfv5BLnxiru8eclG0Uq8D0xcjQP7bmhDxXAFfK5frKsZPataz/+/2FzD/W5fhjTpJ7nQb+hnLBUZ84qycL7uPUy1aYX33rKAQoQN2bRbteCIIllEWZCgRHItka0ZW7fJFaLPKomClIE8AuAPQFoFG+82T06jNgLIVFHa3HDSvtURZz4xc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199015)(53546011)(71200400001)(2906002)(66446008)(6486002)(6506007)(54906003)(36756003)(83380400001)(478600001)(38070700005)(38100700002)(33656002)(316002)(122000001)(66946007)(8676002)(76116006)(64756008)(4326008)(66556008)(41300700001)(86362001)(91956017)(8936002)(7416002)(6916009)(5660300002)(2616005)(186003)(66476007)(6512007)(26005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8277 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3248398a-07f5-4743-c502-08daa213416e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zc3lYZAopX/wmbCh9RR1qjtNJfuDZEhxNAj/j3aOFHlOaSu6I2i7MKi6ZDQJvry2xzwK9gbmvrJ/Iu4PMOsM1GL1DkyD9GSVDaiYtz9CEHMdHFQFi/O7tgMlJbxkE+yb7oESl9kqdbsZ4g1ki+iEIvB+opadqpr5KeB8Z4BOzACTMqo6bZ5SAoNGfm+yQUImbj6Y7fCTOhNNpR9kej4lfYHdBzELiiFj7YMS1IxYUGrzVUikk24VcCT0tNkD5+qEZItgRgGaa9BJx47QJHttnWX4fuQ6tlEDU9csOICqsi0gIYgZBkOFHQK4u03Y9B4WDCfTL0e1KwxAywKkIl3BXrpOMbZreTpPMueRSuy7U3wOTux9YQvp30Wh5MCQnZnWqEDVNCw5cUY2grP9NfaprMOr31K75wVpi77JfYY5rSGQ1WVn7EBjdIXlJ+jR6UCAc7QbetQ8s2idzhC1ENbLDDF6MbX+IA+5PV7qhIgW18GRxdOy0kPbYW7uTYzForwAwZZvM5eKcpuRmJMSAbx5X9ifZiVxKNZNAfoNAXWXOC9mZ6nvrzHZmEUp2advtBYGYBjAUKPt1sffiuxRutkgnHLd/UEqsM10ybe+FsGLWdrb2Lw8Aprc8VtMoeFNm5o5GkFp1EceXq4kgrVzAXb0hfGPPqDJrFW0PvvVmdSmheg2ZdUeZN/0xqHUQxZhzP9/Lxwg8+khTH1aSIgFVQmj9geHhv+NLYt5QPWTQhu+7HQPkH7JfUDkx8U14elqTkw7UxM7Sc9vDEOgW/MdUAFBag== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(316002)(6486002)(54906003)(70206006)(70586007)(6862004)(5660300002)(8936002)(53546011)(8676002)(4326008)(6506007)(478600001)(41300700001)(6512007)(336012)(82740400003)(81166007)(356005)(47076005)(82310400005)(26005)(83380400001)(2616005)(2906002)(186003)(36756003)(33656002)(40480700001)(86362001)(40460700003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 12:08:16.5193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de457755-5f36-4083-5e6d-08daa2134a94 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9426 SGkgSGFuLA0KDQo+IE9uIDI5IFNlcCAyMDIyLCBhdCAxMjoxMywgSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDI4LjA5LjIwMjIgMTY6MTEsIFJvZ2VyIFBh dSBNb25uZSB3cm90ZToNCj4+IG1lbW9yeV90eXBlX2NoYW5nZWQoKSBpcyBjdXJyZW50bHkgb25s eSBpbXBsZW1lbnRlZCBmb3IgSW50ZWwgRVBULCBhbmQNCj4+IHJlc3VsdHMgaW4gdGhlIGludmFs aWRhdGlvbiBvZiBFTVQgYXR0cmlidXRlcyBvbiBhbGwgdGhlIGVudHJpZXMgaW4NCj4+IHRoZSBF UFQgcGFnZSB0YWJsZXMuICBTdWNoIGludmFsaWRhdGlvbiBjYXVzZXMgRVBUX01JU0NPTkZJRyB2 bWV4aXRzDQo+PiB3aGVuIHRoZSBndWVzdCB0cmllcyB0byBhY2Nlc3MgYW55IGdmbnMgZm9yIHRo ZSBmaXJzdCB0aW1lLCB3aGljaA0KPj4gcmVzdWx0cyBpbiB0aGUgcmVjYWxjdWxhdGlvbiBvZiB0 aGUgRU1UIGZvciB0aGUgYWNjZXNzZWQgcGFnZS4gIFRoZQ0KPj4gdm1leGl0IGFuZCB0aGUgcmVj YWxjdWxhdGlvbnMgYXJlIGV4cGVuc2l2ZSwgYW5kIGFzIHN1Y2ggc2hvdWxkIGJlDQo+PiBhdm9p ZGVkIHdoZW4gcG9zc2libGUuDQo+PiANCj4+IFJlbW92ZSB0aGUgY2FsbCB0byBtZW1vcnlfdHlw ZV9jaGFuZ2VkKCkgZnJvbQ0KPj4gWEVOX0RPTUNUTF9tZW1vcnlfbWFwcGluZzogdGhlcmUgYXJl IG5vIG1vZGlmaWNhdGlvbnMgb2YgdGhlDQo+PiBpb21lbV9jYXBzIHJhbmdlcyBhbnltb3JlIHRo YXQgY291bGQgYWx0ZXIgdGhlIHJldHVybiBvZg0KPj4gY2FjaGVfZmx1c2hfcGVybWl0dGVkKCkg ZnJvbSB0aGF0IGRvbWN0bC4NCj4+IA0KPj4gRW5jYXBzdWxhdGUgY2FsbHMgdG8gbWVtb3J5X3R5 cGVfY2hhbmdlZCgpIHJlc3VsdGluZyBmcm9tIGNoYW5nZXMgdG8NCj4+IHRoZSBkb21haW4gaW9t ZW1fY2FwcyBvciBpb3BvcnRfY2FwcyByYW5nZXMgaW4gdGhlIGhlbHBlcnMgdGhlbXNlbHZlcw0K Pj4gKGlve3BvcnRzLG1lbX1fe3Blcm1pdCxkZW55fV9hY2Nlc3MoKSksIGFuZCBhZGQgYSBub3Rl IGluDQo+PiBlcHRlX2dldF9lbnRyeV9lbXQoKSB0byByZW1pbmQgdGhhdCBjaGFuZ2VzIHRvIHRo ZSBsb2dpYyB0aGVyZSBsaWtlbHkNCj4+IG5lZWQgdG8gYmUgcHJvcGFnYWVkIHRvIHRoZSBJTyBj YXBhYmlsaXRpZXMgaGVscGVycy4NCj4+IA0KPj4gTm90ZSBjaGFuZ2VzIHRvIHRoZSBJTyBwb3J0 cyBvciBtZW1vcnkgcmFuZ2VzIGFyZSBub3QgdmVyeSBjb21tb24NCj4+IGR1cmluZyBndWVzdCBy dW50aW1lLCBidXQgQ2l0cml4IEh5cGVydmlzb3IgaGFzIGFuIHVzZSBjYXNlIGZvciB0aGVtDQo+ PiByZWxhdGVkIHRvIGRldmljZSBwYXNzdGhyb3VnaC4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTog Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IA0KPiBSZXZpZXdlZC1i eTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiB3aXRoIG9uZSBtaW5vciByZW1h cmsgYXQgdGhlIGVuZCwgd2hpY2ggY2FuIGJlIHRha2VuIGNhcmUgb2Ygd2hpbGUgY29tbWl0dGlu Zy4NCj4gDQo+PiAtLS0NCj4+IENoYW5nZXMgc2luY2UgdjI6DQo+PiAtIFNwbGl0IHRoZSBBcm0g c2lkZSBjaGFuZ2VzIGludG8gYSBwcmUtcGF0Y2guDQo+IA0KPiBEZXNwaXRlIHRoaXMgSSdkIHBy ZWZlciB0byBoYXZlIGFuIEFybSBtYWludGFpbmVyIHZpZXcgb24gdGhpcyBhcyB3ZWxsLiBBcw0K PiBwcmV2aW91c2x5IHBvaW50ZWQgb3V0IHRoZSByZXN1bHRpbmcgY29kZSBpcyBnb2luZyB0byBi ZSBzdWItb3B0aW1hbCB0aGVyZS4NCg0KT24gYXJtIG5vbmUgb2YgdGhvc2Ugd2lsbCBiZSBjYWxs ZWQgYXQgcnVudGltZSwgaXQgaGFwcGVucyBvbmx5IGR1cmluZyBndWVzdCBjcmVhdGlvbg0Kc28g dGhlIHBvdGVudGlhbCBwZXJmb3JtYW5jZSBpbXBhY3QgaXMgdmVyeSByZWR1Y2UuDQoNCkNoZWVy cw0KQmVydHJhbmQNCg0KPiANCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9pb2NhcC5oDQo+PiAr KysgYi94ZW4vaW5jbHVkZS94ZW4vaW9jYXAuaA0KPj4gQEAgLTcsMTMgKzcsNDMgQEANCj4+ICNp Zm5kZWYgX19YRU5fSU9DQVBfSF9fDQo+PiAjZGVmaW5lIF9fWEVOX0lPQ0FQX0hfXw0KPj4gDQo+ PiArI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPj4gI2luY2x1ZGUgPHhlbi9yYW5nZXNldC5oPg0K Pj4gI2luY2x1ZGUgPGFzbS9pb2NhcC5oPg0KPj4gKyNpbmNsdWRlIDxhc20vcDJtLmg+DQo+PiAr DQo+PiArc3RhdGljIGlubGluZSBpbnQgaW9tZW1fcGVybWl0X2FjY2VzcyhzdHJ1Y3QgZG9tYWlu ICpkLCB1bnNpZ25lZCBsb25nIHMsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBsb25nIGUpDQo+PiArew0KPj4gKyAgICBib29sIGZsdXNoID0gY2Fj aGVfZmx1c2hfcGVybWl0dGVkKGQpOw0KPj4gKyAgICBpbnQgcmV0ID0gcmFuZ2VzZXRfYWRkX3Jh bmdlKGQtPmlvbWVtX2NhcHMsIHMsIGUpOw0KPj4gKw0KPj4gKyAgICBpZiAoICFyZXQgJiYgIWlz X2lvbW11X2VuYWJsZWQoZCkgJiYgIWZsdXNoICkNCj4+ICsgICAgICAgIC8qDQo+PiArICAgICAg ICAgKiBPbmx5IGZsdXNoIGlmIHRoZSByYW5nZShzKSBhcmUgZW1wdHkgYmVmb3JlIHRoaXMgYWRk aXRpb24gYW5kDQo+PiArICAgICAgICAgKiBJT01NVSBpcyBub3QgZW5hYmxlZCBmb3IgdGhlIGRv bWFpbiwgb3RoZXJ3aXNlIGl0IG1ha2VzIG5vDQo+PiArICAgICAgICAgKiBkaWZmZXJlbmNlIGZv ciBlZmZlY3RpdmUgY2FjaGUgYXR0cmlidXRlIGNhbGN1bGF0aW9uIHB1cnBvc2VzLg0KPj4gKyAg ICAgICAgICovDQo+PiArICAgICAgICBtZW1vcnlfdHlwZV9jaGFuZ2VkKGQpOw0KPj4gKw0KPj4g KyAgICByZXR1cm4gcmV0Ow0KPj4gK30NCj4+ICtzdGF0aWMgaW5saW5lIGludCBpb21lbV9kZW55 X2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIHMsDQo+IA0KPiBBIGJsYW5r IGxpbmUgd291bGQgYmUgbmljZSBiZXR3ZWVuIHRoZXNlIHR3byAoYW5kIHNpbWlsYXJseSBmb3Ig dGhlDQo+IHg4Ni1vbmx5IHBhaXIpLiBPbWl0dGluZyBzdWNoIGJsYW5rIGxpbmVzIGlzIGltbyBh ZHZpc2FibGUgb25seSBmb3INCj4gdHJpdmlhbCBpbmxpbmUgZnVuY3Rpb25zLg0KPiANCj4gSmFu DQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:14:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:14:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413719.657543 (Exim 4.92) (envelope-from ) id 1odsQu-00087d-Hb; Thu, 29 Sep 2022 12:14:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413719.657543; Thu, 29 Sep 2022 12:14:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsQu-00087W-EI; Thu, 29 Sep 2022 12:14:28 +0000 Received: by outflank-mailman (input) for mailman id 413719; Thu, 29 Sep 2022 12:14:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsQt-00087Q-8I for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:14:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e2d33f1-3ff0-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 14:14:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7826.eurprd04.prod.outlook.com (2603:10a6:20b:234::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 12:14:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 12:14:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e2d33f1-3ff0-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EMOfPDvj4j/8z0LjBPkgBj6Xm5VfC46Rw3IDDmYOg1M+Dzdt5BpOURS7yBE4NVd/FCKEbsCFAY4v0SE0+hbZzHFGU1OhxKg76B0zOiyfpCqKyhN5cLtrNh1ijKoGei5Uv54c70i8N/E2JMPn7k0xRhzhF4fq9buENGK+ItWlJTcwrYtP0DldsaMEL3U5okl98BW8hnMqp1rLLJ7CXuZsmOYfU9xtWslhgdsMVpVR6EEVLaVqpxI57v7HM08jTNuNtPEfQAFn4TPBCr+O8NSqeCfz/2V22cReqkEP07QWKoJHkMNFCPIcBTM+tRiEjhB/0hZ1hEXNFPuQi16nJ3R9Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDU6tXQT2buWFt9FYQoSuPAwWiJbHddAM8qHfvetIcg=; b=oewFvrelCFVyPVHDNQ9Gs8O+aC900vBLOdP1sk0FAPZ8y7uyl0R/2kXMIcXW/0703Qcc1ecc3dmYeoeSCM6j3b4wNKKrzZqB+cCNfPrGAsDSKTAabiIYmV1Ae7NUgPHmS+UCz2RyrCVWv4NYvpWgQDz+YhmhByZTec3+Fkf0M68vJuVMQvfocpUmvv7RiBuC9dWRW/I0k8J2kM3m9gwsx6twz61Ga3QEjLGURx30vJ0oJIoZAlgHBCV2l/RYJLLLSREiE2EU0n8Bh3FQ8ZYa5SVVzhLIPm5araWHjK2Ot3o2sfg7ioWfFxLBKIazf5Y4jcMKTEiHhTbqgU+Gc8FVvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDU6tXQT2buWFt9FYQoSuPAwWiJbHddAM8qHfvetIcg=; b=ByZlflqj3fatG1lKPmfh1J3iyNiF3IdWMzKq9U+f80+6B/8suPUd3dgjE1JHyA9Ipc7UdGpPYHCjRcInKTcQhUFcbMG3SjbYMykIOWaQZ75UqCID1oKDxTG9xDbcqbmFrtfhfjC3QEXScrfCSf5SGodXX5OcGCHQu4XR2TeXjdL1BadLKDPFplgb6sfYcv9KmY5AI3NIhYcz8Q9CGGDKKe5wG9IZu+D+SWlR3csSUF0GsIJC0t034lWOqrdApB86+KSOa5zd+KDgolQqyt19eJCuEyw70wtGmxj3uQR/GO+K9WzCr1GjIj3wgbV8L441teMC89QlcRk9qT25wG27pw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 14:14:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-3-wei.chen@arm.com> <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> <72691b9b-761e-a89b-97df-afd5cf0ddebb@arm.com> From: Jan Beulich In-Reply-To: <72691b9b-761e-a89b-97df-afd5cf0ddebb@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7826:EE_ X-MS-Office365-Filtering-Correlation-Id: c662ee49-b7af-4ca4-4a29-08daa214241c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sPagWQKikqSYtln1SNTiFLECvrlFfhBAKVGJbJmf7M590+Ln/W9alAlLSaffzZTw31AvBvoN6mFUHepDiBoJpS9lzrMWPkkJozET5fDAP4PdA1NCEAtrghcy5Xo0JKcz+buSEvEDJgRnK7tW8QdMbsq//O9yrW4H8XmL39/WiVE/PW/ptNgreAb8lILPDuNOHNMAvaWghrzXe/KpqJdsgd/DldH2qLnaPQuu6tPxTAV22T1CjENGb89iIJnoGz2nEjICl8ng0G54rLaYdft1Ritm6lLvG8tsc33oyEgeHs42aCRFhvRxiJGeHjcshRk4rd/UZxlpp3DDtKFBBM2YPjyHArVXAVWaDtxnYhRbuQurXRMjJZb9UUxAkIuzxiJPdr/0LBVUOj2BQmtGEJrQqeen/UAAHsKX9Eo6SJ4YB7MBiqQIprt8v76hj73Nqc/TQIhlrYBhaMU4yTzu/k2IGq9JMIIHNj6bavnesMlTYkAdvRcPXX9jMQUuRM+tf4msvX4UnK4sIspadeJbdLUwMXfrGjCCaZi4GsFrAyLMrqZYx/ASyq+wPtwej2uBm2VUn5fNIOup/fddhEinG5fyPOWYaqKVnq+374Ghk2DkMnWBwsMgd+aYaiW7/u7nHfFjkKEopL6VQeKXBrm3Y2iwwYGg5TIzKViDsdLEjE2y8vZOC3LpJJxEOGWBwaEEoqu9VbhQ0G8wUjnAoczRGQkTrwAEEmERs4E31q7norW0V26+UUWB/05jztGZBly1MtN0u9RZjJr8j+SYDnDvLI8fxT1VfWnGFkaHCemrTvE9YQE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199015)(316002)(6916009)(54906003)(86362001)(41300700001)(31696002)(8936002)(2616005)(186003)(5660300002)(66946007)(66476007)(66556008)(36756003)(4326008)(8676002)(53546011)(2906002)(6506007)(6512007)(26005)(83380400001)(6486002)(31686004)(478600001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cExoMnZmcDJLOEVuY2E0MzI0V05CUDl5dnF6R0RtWVVmU05WRzkvNTJHVXk1?= =?utf-8?B?dFFPMUwzTmw2ckUzalVodGVqRDA3MlZ2WHh6MUlOTXJaZ1ZzVUNUeDZwT0lW?= =?utf-8?B?eThTcW9ObU5HMXA1YWZuQlo5b01Gd0N6K2MvRUs5ay9GM21DTTc5cVI1Uisr?= =?utf-8?B?TmhnNC80MVNING9FUTR2YU9lOFZyNWNuMy9RNjREZWMrbDZvZlRwZEJJU2cr?= =?utf-8?B?UFVEdjBmRTVLYnFUaTV3cFZQbXJ3aTV3QWs0Vi9BeDJkcUtZeFhHcnBGbUQv?= =?utf-8?B?S2V6RllYUFhJSmE3RGZxYnVETjFuUnJwM0dtcW9xMFQ0MkFONFVwdkVoVGpM?= =?utf-8?B?Zlcwd1YwVms3YTZWK3M0cXcxQXA1KzRGSzkxSm9yQXJqdGh3Tkl4NlFyZ3Q4?= =?utf-8?B?M3k1K1IzSkdxRFd2YzlHLzdDVEVBaXU2dHVickJxcnlrMkhkNHg5L2IyZGk4?= =?utf-8?B?cW1PcDBoaVNrR1piYzYwWjlDQW0xTUVIN0c5aW9wNzJSMzF5cjg4N01NcmZU?= =?utf-8?B?OHdTMjRZUEF1VnY4b21zZ0VPNmUzTTdmc0ZIbkZkR3lRb2oycHRCajFLRCtE?= =?utf-8?B?aWpjdXJTS1VsbGxoak11K1Rxbnhob3k1SzIrdVhZc2RSOEtWM3ZjK3ZxNUc1?= =?utf-8?B?Q0QxVDZBS2lqWFZkRDFQSTZ2dW1TTU1scUtRalQ1M21acGFvdzdTSnpEbkI2?= =?utf-8?B?OFNiNUlKVElieXovK043eUJoUGkzM0FKVjc4UXBQRkowZ3JUTVdPcU95ZTJa?= =?utf-8?B?dGlwZ1lqOFhUcFlSM2lQODVZV0VyMjl4SUpiV0h5UGJjWTY5U0xGNnJ3cmU3?= =?utf-8?B?elhIR2VmVUdmc0hZSnAxeDc0Q0YzY0FXdXFRM2NTQzRTUXNjZmI5Qkx0Q3JH?= =?utf-8?B?ZGJEUENVVDYyV3Uwek9MdHhsRjlTUFBaVmhuQW9hTVVlSHY4d2NwUUhsZ1lr?= =?utf-8?B?YkhtK1JGTlB6ZGE0bGp1bm9NWTNLWEtZS1lOWTdOclFDdmkrTEVnWjI1Z1Vl?= =?utf-8?B?ZlQxcURudFdqSXZ1UXpRTTFUS0haSW5Bamk3dlpqWVRWU01wQUtuazZUcFN0?= =?utf-8?B?VFlqUEYxSUlLWVpHQWZuM2lJb0ZaQ3NLQUIzd0xKWkVNUUtOYm42VCt0ZmZP?= =?utf-8?B?ZUd6ZURHTDRZK3lQbmxkdm9YdW9JRStHZHZLYyttbXU3Yno1WitpVkdPWnMy?= =?utf-8?B?ajZiM090N0hsRXR3eGNrQXlzUE5PZ0U4NlllR2h1aWFWd0poTWJrNkZ2ZWsx?= =?utf-8?B?QXBFYm1CYjFjdWs2TEhjQWVDWXJSZUZoU1R4MTJXb0RvV0JNRVNaS1F3Vmkz?= =?utf-8?B?Z002RE9odE1tbEprRmhNdkZERFNuQm5TRmlOTUx5VkRhN2ZuSXB0cjlsMC9a?= =?utf-8?B?bVJTOFBvNmZsTTI4c3E5K081NElOTHgycHVJTUVuSlU1ZUJsWFNkc2xxQyt6?= =?utf-8?B?bFV6TXVUdTZFSzQ1UU9yT3k0cTlVT1dtVEVYZGJzUnBFWnBHOTJESkZKV3c3?= =?utf-8?B?ekhQTEVMVGZMUTNGWFduYkRXcWRVY25McVE3aHVWSkp5elFyM25zNTRtWlRD?= =?utf-8?B?amw5TUpxdjhDeGpKYnV1M1JwSzlQd1BVclo2UWpKQkVDQis2ZFltaDZBZlk5?= =?utf-8?B?Z1FaZHdTYkFpaFZKb2U5aFMwRVA0cmZiL3FPbm1lZUNlREUzcVlQM3hQWko1?= =?utf-8?B?NUNqTkNVZ2ZyZVBaTE8vRFJwbnRQaHZXUEMxa1prRmc0RDFUdlh0c3JUVU91?= =?utf-8?B?ZzQ5TnllUXR5cVhuaGoyRzR4QWFCQ0FUckNJYldIOHptMFJIZk9qMW5wU1NE?= =?utf-8?B?SHFTZ2NqbHRzT0RteEdWdE5Mb1dFOWN1MzdZdFF1Nyt5MldFVnRiNkNDWGxy?= =?utf-8?B?NkVpVUMzVUp2cGc4T1BqVmR0anpTb2RlYlcxQ0k5UStmMVhMQVR1Q2J6SjZP?= =?utf-8?B?WEZRdmh4bmhzanVjcStaMmFYNlgwT1dCSngzK3lISVpvODNGU2ZacURwUTdP?= =?utf-8?B?cEl2RHI2d3JNMmhkc08rdC9BZXRFUWtxeGxsYVpoUm9Nczg1YWcwZTBHRnRq?= =?utf-8?B?Z2l1VXZLU0JMdkdYZDZPeHhOOXZjdUI1NjRaVE1ST0Qwa1VIQVpTa3oyRjBs?= =?utf-8?Q?+wtvWDZtIFocc4CThfAhUMRRP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c662ee49-b7af-4ca4-4a29-08daa214241c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 12:14:21.6632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RTZk7JX6XFmOfJDjagAG8bC3cIUoL05E36VNQDXchbmEuhiKzcFZYVXjjlCR82NRtz94s86h/8OMwIZM8kEufw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7826 On 29.09.2022 09:43, Wei Chen wrote: > On 2022/9/27 16:19, Jan Beulich wrote: >> On 20.09.2022 11:12, Wei Chen wrote: >>> + nodes_used++; >>> + if ( epdx > memtop ) >>> + memtop = epdx; >>> + } >>> + >>> + if ( nodes_used <= 1 ) >>> + i = BITS_PER_LONG - 1; >> >> Is this actually going to be correct for all architectures? Aiui >> Arm64 has only up to 48 physical address bits, but what about an >> architecture allowing the use of all 64 bits? I think at the very >> least we want BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG) here. >> > > Ok I will add above BUILD_BUG_ON. And I also have question why can't > we use PADDR_BITS here directly? Well, if you used PADDR_BITS, then you would use it without subtracting 1, and you'd be in trouble again when PADDR_BITS == BITS_PER_LONG. What may be possible to do instead of BUILD_BUG_ON() is if ( nodes_used <= 1 ) i = min(PADDR_BITS, BITS_PER_LONG - 1); >>> + else >>> + i = find_first_bit(&bitfield, sizeof(unsigned long) * 8); >>> + >>> + memnodemapsize = (memtop >> i) + 1; >> >> Again perhaps the subject of a separate patch: Isn't there an off-by-1 >> mistake here? memtop is the maximum of all epdx-es, which are >> calculated to be the first PDX following the region. Hence I'd expect >> >> memnodemapsize = ((memtop - 1) >> i) + 1; >> >> here. I guess I'll make patches for both issues, which you may then >> need to re-base over. >> > > Thanks, I will wait your patches. Already sent out yesterday. >>> +static void cf_check dump_numa(unsigned char key) >>> +{ >>> + s_time_t now = NOW(); >>> + unsigned int i, j, n; >>> + struct domain *d; >>> + const struct page_info *page; >>> + unsigned int page_num_node[MAX_NUMNODES]; >>> + const struct vnuma_info *vnuma; >>> + >>> + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, >>> + now); >>> + >>> + for_each_online_node ( i ) >>> + { >>> + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); >>> + >>> + printk("NODE%u start->%lu size->%lu free->%lu\n", >>> + i, node_start_pfn(i), node_spanned_pages(i), >>> + avail_node_heap_pages(i)); >>> + /* Sanity check phys_to_nid() */ >>> + if ( phys_to_nid(pa) != i ) >>> + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", >>> + pa, phys_to_nid(pa), i); >>> + } >>> + >>> + j = cpumask_first(&cpu_online_map); >>> + n = 0; >>> + for_each_online_cpu ( i ) >>> + { >>> + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) >>> + { >>> + if ( n > 1 ) >>> + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); >>> + else >>> + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); >>> + j = i; >>> + n = 1; >>> + } >>> + else >>> + ++n; >>> + } >>> + if ( n > 1 ) >>> + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); >>> + else >>> + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); >>> + >>> + rcu_read_lock(&domlist_read_lock); >>> + >>> + printk("Memory location of each domain:\n"); >>> + for_each_domain ( d ) >>> + { >>> + process_pending_softirqs(); >>> + >>> + printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); >>> + >>> + for_each_online_node ( i ) >>> + page_num_node[i] = 0; >> >> I'd be inclined to suggest to use memset() here, but I won't insist >> on you doing this "on the fly". Along with this would likely go the >> request to limit the scope of page_num_node[] (and then perhaps also >> vnuma and page). >> > > memset for page_num_node makes sense, I will do it before > for_each_domain ( d ). That won't be right - array elements need clearing on every iteration. Plus ... > About limit the scope, did you mean, we should move: > > "const struct page_info *page; > unsigned int page_num_node[MAX_NUMNODES]; > const struct vnuma_info *vnuma;" > > to the block of for_each_domain ( d )? ... this limiting of scope (yes to your question) would also conflict with the movement you suggest. It is actually (among other things) such a mistaken movement which the more narrow scope is intended to prevent. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:21:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:21:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413727.657553 (Exim 4.92) (envelope-from ) id 1odsXe-0001Iq-C7; Thu, 29 Sep 2022 12:21:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413727.657553; Thu, 29 Sep 2022 12:21:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsXe-0001Ij-9O; Thu, 29 Sep 2022 12:21:26 +0000 Received: by outflank-mailman (input) for mailman id 413727; Thu, 29 Sep 2022 12:21:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsXc-0001Ia-Ly for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:21:24 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140082.outbound.protection.outlook.com [40.107.14.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ab11d61-3ff1-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 14:21:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8775.eurprd04.prod.outlook.com (2603:10a6:10:2e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Thu, 29 Sep 2022 12:21:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 12:21:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ab11d61-3ff1-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vr02ompGWdaXk3rWvA0Wakzpu5X3AOPCvJaZOTM2PWDAAEeqzoeQW/6p2/lEb/MvtDvBm/pKt0Y3DBKYxlL6sdHz7AkCGU3WR2tBE7VAUMTZHf942aIpkI67J2ct8It6/KCqaGgoAh1EG/eFNr3mUjxAAwc7MTktzFPLaMBvWikJFTE9VzQSRiVJPsSmTX28prXSvJOj21uQNWOFAakxRKDyWosR0HBVJ8VjqPgadVl6tfblGNnGJxdWkf0HisQCr7KhJcCk2ROoO+JREMpaa0GYibp6VcqNl6tQheHoVHEIVYXRuuGKhObrpPS2DChSmwO66M9Eh5wN4MZ4Mc/I+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EASFL+Yy2MgNjdTH+kUTqgOKursNorO1SSpvvIuqxfg=; b=Z08Mp8q7j1ZXvD69MxCTNuFly+UjpQR7cap/SF7q3etAck6GVCHKX+3GsJEukJtXfnPD/hr8f5fyle0o/dGs3YVGWfMKAQ15/wGDZt+20NuZe1A1YAXVRi8vrWkkgq7zuYvbVtlsbTxDFDADFZFmjLhlH/qgvj9oKxegYjeKNK5Sq5Hq3CsfNAsSYuBpRwTTRQlgDdRj+63v3zQqJXNKx57huweCr+Bq49spFxXM2zjh6mMz5UQpjOaI8wZQqtHgjyOz2eIYOe5GJkoQWpH+z05fKaY22i9vsvRx9LuiXz3N+QBV+ILGsJhBSr18RNxS45bWmkt548p0VsGNSsSQLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EASFL+Yy2MgNjdTH+kUTqgOKursNorO1SSpvvIuqxfg=; b=jkEoh6Y+xUyIQx7DWslS+i1++cx8fdQ0xQU3tXLOaTkHW7kKORInowy04jG5fMD3RQpizLIiLg6OgkqJ3OMUEq6l0K86LhjtfWkpUPoRIqmaU4zAYPwxCXhDbgYMw6DKWmO/3eC8NNYhUfsWsNGuEw/lFVm81VNj5wUg5BD17J7+MEefl3Gs+RVpyi2y5oNvDCALLvql1jBT4lx8LJcUTrrYZXcSq0AgZhYDwCOCaorxcpnauc3zSYUQqDWEkMll+W0C57B60XFhPXeXU+lDqCEQWFJe1L6jMw1AGQc3s7FXorcSnPNZRnvMIefqqdPi3UlDCT6FU0DGvrxN5wK5mQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com> Date: Thu, 29 Sep 2022 14:21:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-6-wei.chen@arm.com> <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0142.eurprd04.prod.outlook.com (2603:10a6:20b:48a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8775:EE_ X-MS-Office365-Filtering-Correlation-Id: 093b64b9-ecd1-4342-f54b-08daa2151dd8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /rwO3weJEMDqQM4PJaeAt/X4PClAjonYFmJcYNMfPp6YbaxpqXcFQOcE07KwVwu2Z0pM8KQhAH211XE94FzWgc2rp4DE+CfjUFn+AG7qBhanH7XUjFu90gErFlHaHJSl9hk6EJSmeR1inro955kUJq02BygYXMlbFH2+FfbbGkvf/flD/xMCN8QszNxX3KnIjTr2DCaHPzQ9ab722OvZwRfKoxJjopTfITVLzqetffOqQwlorkADKyCXAE7R7OODiNI25FsG/m/tf+RbKCLEyEkRAiHPsNCk9/zXWxkjOKqMcbTTlrhKBPKPmkTqAMlTrhsRcqtc/NgVg+bNtyHWu1/pfTSaRfAwGXT8arA+Fm+SseurulBrnapB5mqfQh3UsbwuVgUR8oRW8q6u0zDoRIdL1tDXn522rK0u0z0rNjmy4v2nq6ep/nkRHNRM7OjCnreCyhh/d4WzOenNem56YSBl3LonSVdIY7+yOThZdDlLAfHfpG2asGIF/WSe1/xXcE4IS35UZN2jIhwbMRSvQwSDKYOixoc/wEuXnNbqiwzzF9whmrMVEz8WLe4fX7pn9bbcbCDmiujLscePxMmNAQOqhzRXjISzgh9BCcGcDaJAw4M7MVzHL98BrQ13ZwKOl3U+5WU8PL2tUmF0F+r0U8bHhwqFDOv8uC1Q5ibpfT9SQocH2hCVEpeCH+TzhhBDLyZUlrj95IpSKPjHXuVnp8FZ6y4qFS81YOvBN3JXwV/JEgZI7RrnflT9NEiBGlJcE30nH+qRkANE9O1BbYgoCYOykVR3ay+vhQV6sisicm8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(39860400002)(346002)(376002)(451199015)(316002)(54906003)(8676002)(6916009)(478600001)(31696002)(86362001)(66556008)(8936002)(66476007)(66946007)(5660300002)(38100700002)(4326008)(36756003)(6512007)(26005)(83380400001)(41300700001)(6506007)(53546011)(186003)(2616005)(31686004)(6486002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDc2aWRRNVhTYy8vQytJZk9ySzlTRTl4OGw1eE9PamJiNTdsbTZXYkoxMFVF?= =?utf-8?B?MngwZFBHcnZvRzViMWR4Kyt2Y0h2Qy8zN2hWN2xZSTZKNE5JUkJFUTFjMDU0?= =?utf-8?B?VWZrSlBBQjh0RlNzMjZibkJLOFp2M3ZqTmVaNi9vWjJZU2UvWTUxcWVTbDdT?= =?utf-8?B?QW5pcGNyWEE5YXRhQ0N1a1M3WUlHc1dGOE1lZE1sTVpkZUxqekJMRXRaZmxR?= =?utf-8?B?elUrVTFweG9sYjAxY3ZSd0h0OEJWSlJHK3NXWHdIbnFXazZucEVpS0YyS3R2?= =?utf-8?B?anZwU3dQaHQ4WDBjL0ZRc1B5czMwWU9DS3Rhdk5VajBZaWVpN05FYnZ3aVRy?= =?utf-8?B?cytnclVKcXVWcVdsdlJWSjZzMVM5TkJjTkhoWkI2ZjIxUExpNGlrZUVVR0FI?= =?utf-8?B?ZVFXTWNwdVdYOC9nSzVWV2hoZUFLa212Z2c2YWhSK2cvbGo4ZExjdjNvVzZr?= =?utf-8?B?b0pFcVdjdkh1NE5BTkFJMjhkcGQwWjdKQW5WYUkxbDJGYUQ2OEFyeUFORytY?= =?utf-8?B?QmVGdlM0emY5N0k1SE4rb2gwb2Q2QlRXR0xvaWsvZlVsSExVRUMyVm81R2ox?= =?utf-8?B?RGhhVVdEZHVaN2p2SUhYT0lkMHRkc2x3R0REbXdOR2k2ZjZoRWhkTWJJUDdO?= =?utf-8?B?Sm9RSDROcEh6Z21RNVFEcHhtSElhM2VWTExXQkRJdm9kRC9yeld1ckl2TE1n?= =?utf-8?B?YUR3bi9TNGh3L0VYUEwrL3R1eXdkSGN4azV6dkp0UFdIakdNUktCVG1NUFlm?= =?utf-8?B?dU93K2I1YXNWYzJoL0pWNDRYN1ZDT2MzM2hFb25oWXNBWk5vZUR1eFpjeVdq?= =?utf-8?B?eGZzZGcwaDByczdxOUlTUzQzUTUyelNFSTNPaTFFeURScFhSdTBmdlV6NjRv?= =?utf-8?B?cDBKM25nOVIvOGRKNm1MeTIxQzhQd0JRd0ZhMm1NSHhpZUhuZG9DT2IrTUs3?= =?utf-8?B?WVd4ZzRDMHNIeW5uOXE2d1NlNlFaalJIU2Q5bnZvbStmcmNyQnM5bG5EUjgx?= =?utf-8?B?bThsVWFqZ3EvczFNTHFQNy8rM1EzR3lNdGcxMWIwL2llSkpscDUyS2VUZEdN?= =?utf-8?B?UDBjaW0xTWtSWHVuaS91RUNhNDY0NGtoUGkyVXlrYkhjSVJralI3VjBhR1lz?= =?utf-8?B?NlhYQXBTOXlhclhVSmFkYXVlRFVpczREd2tGL2U1aG9ZeGZxL1krMkNMVjhB?= =?utf-8?B?VjB5NnlLMUpJNEhJUlZDU2pSeFE1eHpyOElKaUtqaEw1amhqbHI1ZTdPY2VM?= =?utf-8?B?dURYRy80YUdNN3gvMzk1YjYrakdMMW1mK2kvbzlESkUxWjFIYVBvbFErOHpn?= =?utf-8?B?TExrRjhmNDlha3N5bldmQXU4RGFUT2J6QmFCb25pUjRIYzcyOXVwOENtTE5o?= =?utf-8?B?cUR4cXlJcFdQOUI5UEIxbWwyQ2NFVDRIbUFDOVJpQlhQVkk1U3pYZjYrNGhj?= =?utf-8?B?cEYwSHVTaDJpaXFlYm1zMTlEUk9oK0hLMldqSEtvMXRPb1RhajNMUTJGV1F4?= =?utf-8?B?cWxQMkJVOWc4VGZxaFFhdEtFeDllN3VDc1BUNFJkUWhnYVJvRjdlaGFCaFBo?= =?utf-8?B?TzRuWG1YaXgxaDBrZW1YVnB0aW9hZ2FmV1BReGt0c1d6Qnh2RlJaVTAyWDdO?= =?utf-8?B?MUZKTU15LzBoZmdqdkxDTFZhV0RaalFYM3g5dlV3ZEovMlhxM01aa2EyYVdn?= =?utf-8?B?RXp6OEFaSkh0T0xJMzdTZjF2dGIvb2VScWJtRTl3anRXTXNORUR1S0dLY0dX?= =?utf-8?B?REM5YXZSUURsMVE4bnU0endLMTltcVVkbDlZd2d0am5UMHJ2bmp0UjR0Vkg5?= =?utf-8?B?M0VraEM5ckUrSCtuQ2s4U3ZTYnQ3WkRpUXROaU12QkhsTHVYbzUyMFJ2cTNX?= =?utf-8?B?alNlNnkxazlTZzNnUjZ5RjArQXB3SnA3c3NjS2JKbENxWjg1NTNVZXpQMGZx?= =?utf-8?B?UUhXRytBVDB0RFptWXJ5SFVRU3FvUEx3emNoUEFXdVREVUtGdlJ3L1V5Z1Jq?= =?utf-8?B?c1NEN0d0cHYvbSszRXpTUmdYOFdzSElGVXVrMEduZmxaK2hmL29DYzRxck1q?= =?utf-8?B?dHpIc0Vqa05kZGVEb0hZTXdqMVdkNVRKSEFYY29OKytIRFJta0s5MVJ0WVA1?= =?utf-8?Q?iRUSjfXAopPpEpqvEh7IoXMze?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 093b64b9-ecd1-4342-f54b-08daa2151dd8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 12:21:20.9023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7tQmAu1p/tE/rS8XFdTTxkP6BYBrqcFNRGBc2SCAWVSUuTvmLUGHz7silfQS3l4ZYlZSJr1V8cZihIFJwj4Wfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8775 On 29.09.2022 10:21, Wei Chen wrote: > On 2022/9/27 23:48, Jan Beulich wrote: >> On 20.09.2022 11:12, Wei Chen wrote: >>> --- a/xen/drivers/acpi/Kconfig >>> +++ b/xen/drivers/acpi/Kconfig >>> @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP >>> >>> config ACPI_NUMA >>> bool >>> + select HAS_NUMA_NODE_FWID >>> select NUMA >> >> While I might guess that you've chosen the insertion point to have >> things sorted alphabetically, I think here it would be more natural >> to select the wider option first and then also select the more >> narrow one. >> > > Ok, I will adjust the order. > >> One further question though: How is this going to work for Arm64 >> once it wants to support both the form of NUMA you're working to >> enable _and_ ACPI-based NUMA? There better wouldn't be a requirement >> to pick one of the two at build time - it would be nice for support >> of both forms to be able to co-exist in a single binary. > > We are also working in this way. In part#3, we will check ACPI first, > only when ACPI is off, the DT NUMA will be used by Arm. If ACPI is on, > we will skip DT NUMA. Even more so an answer to my question would be nice: You'll then have CONFIG_HAS_NUMA_NODE_FWID=y even on Arm (using PXM as mandated by ACPI when in ACPI mode). But then what's the FWID for DT? I know it was me to suggest this build time distinction, but I'm afraid I wasn't doing much good with that (and I'm sorry). Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:26:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413732.657565 (Exim 4.92) (envelope-from ) id 1odscB-00022T-VB; Thu, 29 Sep 2022 12:26:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413732.657565; Thu, 29 Sep 2022 12:26:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odscB-00022M-RI; Thu, 29 Sep 2022 12:26:07 +0000 Received: by outflank-mailman (input) for mailman id 413732; Thu, 29 Sep 2022 12:26:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odscA-00022G-7x for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:26:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2f71841-3ff1-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 14:26:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6731B21ACA; Thu, 29 Sep 2022 12:26:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 46A3813A71; Thu, 29 Sep 2022 12:26:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +2PAD9yONWPwCQAAMHmgww (envelope-from ); Thu, 29 Sep 2022 12:26:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2f71841-3ff1-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664454364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vzhHfRpxXyEv6WWqeSCNWRHN3DX48/STB8aa8BgBzKk=; b=kbARSbJSd4pO/MEeEYk8ON3TYk4kAhPCHYTdRISZSGPHTF5/D6M8csLcTn+Ew8Y+dSn2Dy 1WfySbJZF3in7PeqKqKgg5SlzgxxfdORoAeCPyaq03ePQiZ4NmIhKLLT3vhzMua7JVyb60 2DzpfVST41vW43t1adNDJ15Ni9Y3vIY= Message-ID: Date: Thu, 29 Sep 2022 14:26:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> From: Juergen Gross Subject: Re: Proposal for physical address based hypercalls In-Reply-To: <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OsMdKIpIa0zwkKoQTlwnp6Cu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OsMdKIpIa0zwkKoQTlwnp6Cu Content-Type: multipart/mixed; boundary="------------pKU3qZcOplYvdAfbRELrqIH3"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper Message-ID: Subject: Re: Proposal for physical address based hypercalls References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> In-Reply-To: <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> --------------pKU3qZcOplYvdAfbRELrqIH3 Content-Type: multipart/mixed; boundary="------------r18k0fRizENOOn2wOjCHJ1mU" --------------r18k0fRizENOOn2wOjCHJ1mU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDkuMjIgMTM6MzIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyOC4wOS4yMDIy IDE1OjAzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjguMDkuMjIgMTQ6MDYsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDI4LjA5LjIwMjIgMTI6NTgsIEFuZHJldyBDb29w ZXIgd3JvdGU6DQo+Pj4+IE9uIDI4LzA5LzIwMjIgMTE6MzgsIEphbiBCZXVsaWNoIHdyb3Rl Og0KPj4+Pj4gQXMgYW4gYWx0ZXJuYXRpdmUgSSdkIGxpa2UgdG8gcHJvcG9zZSB0aGUgaW50 cm9kdWN0aW9uIG9mIGEgYml0IChvciBtdWx0aXBsZQ0KPj4+Pj4gb25lcywgc2VlIGJlbG93 KSBhdWdtZW50aW5nIHRoZSBoeXBlcmNhbGwgbnVtYmVyLCB0byBjb250cm9sIHRoZSBmbGF2 b3Igb2YgdGhlDQo+Pj4+PiBidWZmZXJzIHVzZWQgZm9yIGV2ZXJ5IGluZGl2aWR1YWwgaHlw ZXJjYWxsLiAgVGhpcyB3b3VsZCBsaWtlbHkgaW52b2x2ZSB0aGUNCj4+Pj4+IGludHJvZHVj dGlvbiBvZiBhIG5ldyBoeXBlcmNhbGwgcGFnZSAob3IgbXVsdGlwbGUgb25lcyBpZiBtb3Jl IHRoYW4gb25lIGJpdCBpcw0KPj4+Pj4gdG8gYmUgdXNlZCksIHRvIHJldGFpbiB0aGUgcHJl c2VudCBhYnN0cmFjdGlvbiB3aGVyZSBpdCBpcyB0aGUgaHlwZXJ2aXNvciB3aGljaA0KPj4+ Pj4gYWN0dWFsbHkgZmlsbHMgdGhlc2UgcGFnZXMuDQo+Pj4+DQo+Pj4+IFRoZXJlIGFyZSBv dGhlciBjb25jZXJucyB3aGljaCBuZWVkIHRvIGJlIGFjY291bnRlZCBmb3IuDQo+Pj4+DQo+ Pj4+IEVuY3J5cHRlZCBWTXMgY2Fubm90IHVzZSBhIGh5cGVyY2FsbCBwYWdlOyB0aGV5IGRv bid0IHRydXN0IHRoZQ0KPj4+PiBoeXBlcnZpc29yIGluIHRoZSBmaXJzdCBwbGFjZSwgYW5k IHRoZSBoeXBlcmNhbGwgcGFnZSBpcyAoc3BlY2lmaWNhbGx5KQ0KPj4+PiBjb2RlIGluamVj dGlvbi7CoCBTbyB0aGUgc2Vuc2libGUgbmV3IEFCSSBjYW5ub3QgZGVwZW5kIG9uIGEgaHlw ZXJjYWxsIHRhYmxlLg0KPj4+DQo+Pj4gSSBkb24ndCB0aGluayB0aGVyZSdzIGEgZGVwZW5k ZW5jeSwgYW5kIEkgdGhpbmsgdGhlcmUgbmV2ZXIgcmVhbGx5IGhhcyBiZWVuLg0KPj4+IFdl J3ZlIGJlZW4gYWR2b2NhdGluZyBmb3IgaXRzIHVzZSwgYnV0IHdlJ3ZlIG5vdCBlbmZvcmNl ZCB0aGF0IGFueXdoZXJlLCBJDQo+Pj4gZG9uJ3QgdGhpbmsuDQo+Pj4NCj4+Pj4gQWxzbywg cmV3cml0aW5nIHRoZSBoeXBlcmNhbGwgcGFnZSBvbiBtaWdyYXRlIHR1cm5zIG91dCBub3Qg dG8gaGF2ZSBiZWVuDQo+Pj4+IHRoZSBtb3N0IGNsZXZlciBpZGVhLCBhbmQgb25seSB3b3Jr cyByaWdodCBub3cgYmVjYXVzZSB0aGUgaW5zdHJ1Y3Rpb25zDQo+Pj4+IGFyZSB0aGUgc2Ft ZSBsZW5ndGggaW4gdGhlIHZhcmlhdGlvbnMgZm9yIGVhY2ggbW9kZS4NCj4+Pj4NCj4+Pj4g QWxzbyBjb250aW51YXRpb25zIG5lZWQgdG8gY2hhbmdlIHRvIGF2b2lkIHVzZXJzcGFjZSBs aXZlbmVzcyBwcm9ibGVtcywNCj4+Pj4gYW5kIGV4aXN0aW5nIGh5cGVyY2FsbHMgdGhhdCB3 ZSBkbyBoYXZlIG5lZWQgc3BsaXR0aW5nIGJldHdlZW4gdGhpbmdzDQo+Pj4+IHdoaWNoIGFy ZSBhY3R1YWxseSBwcml2aWxlZ2VkIG9wZXJhdGlvbnMgKHdpdGhpbiB0aGUgZ3Vlc3QgY29u dGV4dCkgYW5kDQo+Pj4+IHRoaW5ncyB3aGljaCBhcmUgbG9naWNhbCBjb250cm9sIG9wZXJh dGlvbnMsIHNvIHRoZSBrZXJuZWwgY2FuIGV4cG9zZQ0KPj4+PiB0aGUgbGF0dGVyIHRvIHVz ZXJzcGFjZSB3aXRob3V0IHJldGFpbmluZyB0aGUgZ2FwaW5nIHJvb3QgaG9sZSB3aGljaCBp cw0KPj4+PiAvZGV2L3hlbi9wcml2Y21kLCBhbmQgYSBibG9ja2VyIHRvIGRvaW5nIFVFRkkg U2VjdXJlYm9vdC4NCj4+Pj4NCj4+Pj4gU28geWVzLCBzdGFydGluZyBzb21lIG5ldyBjbGVh bihlcikgaW50ZXJmYWNlIGZyb20gaHlwZXJjYWxsIDY0IGlzIHRoZQ0KPj4+PiBwbGFuLCBi dXQgaXQgdmVyeSBtdWNoIGRvZXMgbm90IHdhbnQgdG8gYmUgYSBzaW1wbGUgbWlycm9yIG9m IHRoZQ0KPj4+PiBleGlzdGluZyAwLTYzIHdpdGggYSBkaWZmZXJpbmcgY2FsbGluZyBjb252 ZW50aW9uLg0KPj4+DQo+Pj4gQWxsIG9mIHRoZXNlIGxvb2sgbGlrZSBvcnRob2dvbmFsIHBy b2JsZW1zIHRvIG1lLiBUaGF0J3MgbGlrZWx5IGFsbA0KPj4+IHJlbGV2YW50IGZvciwgYXMg SSB0aGluayB5b3UndmUgYmVlbiBjYWxsaW5nIGl0LCBBQkkgdjIsIGJ1dCBzaG91bGRuJ3QN Cj4+PiBoaW5kZXIgb3VyIHN3aXRjaGluZyB0byBhIHBoeXNpY2FsIGFkZHJlc3MgYmFzZWQg aHlwZXJjYWxsIG1vZGVsLg0KPj4+IE90aGVyd2lzZSBJJ20gYWZyYWlkIHdlJ2xsIG5ldmVy IG1ha2UgYW55IHByb2dyZXNzIGluIHRoYXQgZGlyZWN0aW9uLg0KPj4NCj4+IFdoYXQgYWJv dXQgYW4gYWx0ZXJuYXRpdmUgbW9kZWwgYWxsb3dpbmcgdG8gdXNlIG1vc3Qgb2YgdGhlIGN1 cnJlbnQNCj4+IGh5cGVyY2FsbHMgdW5tb2RpZmllZD8NCj4+DQo+PiBXZSBjb3VsZCBhZGQg YSBuZXcgaHlwZXJjYWxsIGZvciByZWdpc3RlcmluZyBoeXBlcmNhbGwgYnVmZmVycyB2aWEN Cj4+IHZpcnR1YWwgYWRkcmVzcywgcGh5c2ljYWwgYWRkcmVzcywgYW5kIHNpemUgb2YgdGhl IGJ1ZmZlcnMgKGtpbmQgb2YgYQ0KPj4gc29mdHdhcmUgVExCKS4NCj4gDQo+IFdoeSBub3Q/ DQo+IA0KPj4gVGhlIGJ1ZmZlciB0YWJsZSB3b3VsZCB3YW50IHRvIGJlIHBoeXNpY2FsbHkg YWRkcmVzc2VkDQo+PiBieSB0aGUgaHlwZXJjYWxsLCBvZiBjb3Vyc2UuDQo+IA0KPiBJJ20g bm90IGNvbnZpbmNlZCBvZiB0aGlzLCBhcyBpdCB3b3VsZCBicmVhayB1bmlmb3JtaXR5IG9m IHRoZSBoeXBlcmNhbGwNCj4gaW50ZXJmYWNlcy4gSU9XIGluIHRoZSBoeXBlcnZpc29yIHdl IHRoZW4gd291bGRuJ3QgYmUgYWJsZSB0byB1c2UNCj4gY29weV9mcm9tX2d1ZXN0KCkgdG8g cmV0cmlldmUgdGhlIGNvbnRlbnRzLiBQZXJoYXBzIHRoaXMgc2ltcGx5IHNob3VsZG4ndA0K PiBiZSBhIHRhYmxlLCBidXQgYSBoeXBlcmNhbGwgbm90IGludm9sdmluZyBhbnkgYnVmZmVy cyAoaS5lLiBldmVyeQ0KPiBkaXNjb250aWd1b3VzIHBpZWNlIHdvdWxkIG5lZWQgcmVnaXN0 ZXJpbmcgc2VwYXJhdGVseSkuIEkgZXhwZWN0IHN1Y2ggYQ0KPiBzb2Z0d2FyZSBUTEIgd291 bGRuJ3QgaGF2ZSBtYW55IGVudHJpZXMsIHNvIG5lZWRpbmcgdG8gdXNlIGEgY291cGxlIG9m DQo+IGh5cGVyY2FsbHMgc2hvdWxkbid0IGJlIGEgbWFqb3IgaXNzdWUuDQoNCkZpbmUgd2l0 aCBtZS4NCg0KPiANCj4+IEl0IG1pZ2h0IGJlIGludGVyZXN0aW5nIHRvIGhhdmUgdGhpcyB0 YWJsZSBwZXIgdmNwdSAoaXQgc2hvdWxkIGJlDQo+PiBhbGxvd2VkIHRvIHVzZSB0aGUgc2Ft ZSB0YWJsZSBmb3IgbXVsdGlwbGUgdmNwdXMpIGluIG9yZGVyIHRvIHNwZWVkDQo+PiB1cCBm aW5kaW5nIHRyYW5zbGF0aW9uIGVudHJpZXMgb2YgcGVyY3B1IGJ1ZmZlcnMuDQo+IA0KPiBZ ZXMuIFBlcmhhcHMgaW5zZXJ0aW9uIGFuZCBwdXJnaW5nIGNvdWxkIHNpbXBseSBiZSB0d28g bmV3IFZDUFVPUF8qLg0KDQpBZ2FpbiBmaW5lIHdpdGggbWUuDQoNCj4gQXMgYSBwcmVyZXEg SSB0aGluayB3ZSdkIG5lZWQgdG8gc29ydCB0aGUgY3Jvc3MtdkNQVSBhY2Nlc3Npbmcgb2Yg Z3Vlc3QNCj4gZGF0YSwgY29pbmNpZGVudGFsbHkgcG9pbnRlZCBvdXQgaW4gYSBwb3N0LWNv bW1pdC1tZXNzYWdlIHJlbWFyayBpbg0KPiBodHRwczovL2xpc3RzLnhlbi5vcmcvYXJjaGl2 ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMi0wOS9tc2cwMTc2MS5odG1sLiBUaGUNCj4gc3ViamVj dCB2Q1BVIGlzbid0IGF2YWlsYWJsZSBpbiBjb3B5X3RvX3VzZXJfaHZtKCksIHdoaWNoIGlz IHdoZXJlIEknZA0KPiBleHBlY3QgdGhlIFRMQiBsb29rdXAgdG8gb2NjdXIgKHdoaWxlIGFz c3VtaW5nIGhhbmRsZXMgcG9pbnQgYXQgZ2xvYmFsbHkNCj4gbWFwcGVkIHNwYWNlIF9taWdo dF8gYmUgb2theSwgdXNpbmcgdGhlIHdyb25nIHZDUFUncyBUTEIgc3VyZWx5IGlzbid0KS4N Cg0KQW55IHBlci12Y3B1IGJ1ZmZlciBzaG91bGQgb25seSBiZSB1c2VkIGJ5IHRoZSByZXNw ZWN0aXZlIHZjcHUuDQoNCj4+IEFueSBoeXBlcmNhbGwgYnVmZmVyIGJlaW5nIGFkZHJlc3Nl ZCB2aXJ0dWFsbHkgY291bGQgZmlyc3QgdHJpZWQgdG8NCj4+IGJlIGZvdW5kIHZpYSB0aGUg U1ctVExCLiBUaGlzIHdvdWxkbid0IHJlcXVpcmUgYW55IGNoYW5nZXMgZm9yIG1vc3QNCj4+ IG9mIHRoZSBoeXBlcmNhbGwgaW50ZXJmYWNlcy4gT25seSBzcGVjaWFsIGNhc2VzIHdpdGgg dmVyeSBsYXJnZSBidWZmZXJzDQo+PiBtaWdodCBuZWVkIGluZGlyZWN0IHZhcmlhbnRzIChs aWtlIEphbiBzYWlkOiB2aWEgR0ZOIGxpc3RzLCB3aGljaCBjb3VsZA0KPj4gYmUgcGFzc2Vk IGluIHJlZ2lzdGVyZWQgYnVmZmVycykuDQo+Pg0KPj4gRW5jcnlwdGVkIGd1ZXN0cyB3b3Vs ZCBwcm9iYWJseSB3YW50IHRvIHVzZSBzdGF0aWMgcGVyY3B1IGJ1ZmZlcnMgaW4NCj4+IG9y ZGVyIHRvIGF2b2lkIHN3aXRjaGluZyB0aGUgZW5jcnlwdGlvbiBzdGF0ZSBvZiB0aGUgYnVm ZmVycyBhbGwgdGhlDQo+PiB0aW1lLg0KPj4NCj4+IEFuIHVuZW5jcnlwdGVkIFBWSC9IVk0g ZG9tYWluIChlLmcuIFBWSCBkb20wKSBjb3VsZCBqdXN0IGRlZmluZSBvbmUNCj4+IGdpYW50 IGJ1ZmZlciB3aXRoIHRoZSBkb21haW4ncyBtZW1vcnkgc2l6ZSB2aWEgdGhlIHBoeXNpY2Fs IG1lbW9yeQ0KPj4gbWFwcGluZyBvZiB0aGUga2VybmVsLiBBbGwga21hbGxvYygpIGFkZHJl c3NlcyB3b3VsZCBiZSBpbiB0aGF0IHJlZ2lvbi4NCj4gDQo+IFRoYXQncyBMaW51eC1jZW50 cmljLiBJJ20gbm90IGNvbnZpbmNlZCBhbGwgT1NlcyBtYWludGFpbiBhIGRpcmVjdG1hcC4N Cj4gV2l0aG91dCBzdWNoLCBzd2l0Y2hpbmcgdG8gdGhpcyBtb2RlbCBtaWdodCBlbmQgdXAg cXVpdGUgaW50cnVzaXZlIG9uDQo+IHRoZSBPUyBzaWRlLg0KDQpUaGlzIG1vZGVsIGlzIGVz cGVjaWFsbHkgaW50ZXJlc3RpbmcgZm9yIGRvbTAuIFRoZSBtYWpvcml0eSBvZiBpbnN0YWxs YXRpb25zDQppcyBydW5uaW5nIGEgTGludXggZG9tMCBBRkFJSywgc28gaGF2aW5nIGFuIGVh c3kgd2F5IHRvIHNwZWVkIHRoaXMgY2FzZSB1cA0KaXMgYSBiaWcgcGx1cy4NCg0KPiBUaGlu a2luZyBvZiBMaW51eCwgd2UnZCBuZWVkIGEgMm5kIHJhbmdlIGNvdmVyaW5nIHRoZSBkYXRh IHBhcnQgb2YgdGhlDQo+IGtlcm5lbCBpbWFnZS4NCg0KUHJvYmFibHksIHllcy4NCg0KPiBG dXJ0aGVyIHRoaXMgc3RpbGwgd291bGRuJ3QgKGFmYWljcykgcGF2ZSBhIHJlYXNvbmFibGUg cm91dGUgdG93YXJkcw0KPiBkZWFsaW5nIHdpdGggcHJpdmNtZC1pbnZva2VkIGh5cGVyY2Fs bHMuDQoNClRvZGF5IHRoZSBoeXBlcmNhbGwgYnVmZmVycyBhcmUgYWxsIGFsbG9jYXRlZCB2 aWEgdGhlIHByaXZjbWQgZHJpdmVyLiBJdA0Kc2hvdWxkIGJlIGZhaXJseSBlYXN5IHRvIGFk ZCBhbiBpb2N0bCB0byBnZXQgdGhlIGJ1ZmZlcidzIGtlcm5lbCBhZGRyZXNzDQppbnN0ZWFk IG9mIHVzaW5nIHRoZSB1c2VyIGFkZHJlc3MuDQoNCk11bHRpLXBhZ2UgYnVmZmVycyBtaWdo dCBiZSBwcm9ibGVtYXRpYywgdGhvdWdoLCBzbyBlaXRoZXIgd2UgbmVlZCB0bw0KaGF2ZSBz cGVjaWFsIHZhcmlhbnRzIGZvciBoeXBlcmNhbGxzIHdpdGggc3VjaCBidWZmZXJzLCBvciB3 ZSBhcmUganVzdA0KZmFsbGluZyBiYWNrIHRvIHVzZSB2aXJ0dWFsIGFkZHJlc3NlcyBmb3Ig dGhlIGNhc2VzIHdoZXJlIG5vIGd1ZXN0DQpwaHlzaWNhbGx5IGNvbnRpZ3VvdXMgYnVmZmVy IGNvdWxkIGJlIGFsbG9jYXRlZCAoZG9lc24ndCBhcHBseSB0bw0KZW5jcnlwdGVkIGd1ZXN0 cywgb2YgY291cnNlLCBhcyB0aG9zZSBuZWVkIHRvIGhhdmUgbGFyZ2UgZW5vdWdoIGJ1ZmZl cnMNCmFueXdheSkuDQoNCj4gRmluYWxseSAtIGluIGhvdyBmYXIgYXJlIHdlIGNvbmNlcm5l ZCBvZiBQViBndWVzdHMgdXNpbmcgbGluZWFyDQo+IGFkZHJlc3NlcyBmb3IgaHlwZXJjYWxs IGJ1ZmZlcnM/IEkgYXNrIGJlY2F1c2UgSSBkb24ndCB0aGluayB0aGUgbW9kZWwNCj4gbGVu ZHMgaXRzZWxmIHRvIHVzZSBhbHNvIGZvciB0aGUgUFYgZ3Vlc3QgaW50ZXJmYWNlcy4NCg0K R29vZCBxdWVzdGlvbi4NCg0KQXMgbG9uZyBhcyB3ZSBzdXBwb3J0IFBWIGd1ZXN0cyB3ZSBj YW4ndCBkcm9wIHN1cHBvcnQgZm9yIGxpbmVhciBhZGRyZXNzZXMNCklNTy4gU28gdGhlIHF1 ZXN0aW9uIGlzIHdoZXRoZXIgd2UgYXJlIGZpbmUgd2l0aCBQViBndWVzdHMgbm90IHVzaW5n IHRoZQ0KcHJlLXJlZ2lzdGVyZWQgYnVmZmVycywgb3IgaWYgd2Ugd2FudCB0byBpbnRyb2R1 Y2UgYW4gaW50ZXJmYWNlIGZvciBQVg0KZ3Vlc3RzIHVzaW5nIEdGTnMgaW5zdGVhZCBvZiBN Rk5zLg0KDQpKdWVyZ2VuDQoNCj4+IEEgYnVmZmVyIGFkZHJlc3Mgbm90IGZvdW5kIHdvdWxk IG5lZWQgdG8gYmUgdHJhbnNsYXRlZCBsaWtlIHRvZGF5IChhbmQNCj4+IGZhaWwgZm9yIGFu IGVuY3J5cHRlZCBndWVzdCkuDQo+Pg0KPj4gVGhvdWdodHM/DQo+Pg0KPj4NCj4+IEp1ZXJn ZW4NCj4gDQoNCg== --------------r18k0fRizENOOn2wOjCHJ1mU Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------r18k0fRizENOOn2wOjCHJ1mU-- --------------pKU3qZcOplYvdAfbRELrqIH3-- --------------OsMdKIpIa0zwkKoQTlwnp6Cu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM1jtsFAwAAAAAACgkQsN6d1ii/Ey/q 0Af9EUBYGZC3o41QIMlsXEiOKcm9teR3KpH/7ThI6QkE9al7gM/O2sN8BKg4sosFs4wrRDegnDgX IwGAlOfzj04m3CRDs6wFZh6u8gpZpStKLkRHSATQ4UH26GP3iLqPPZbHq9nUx8LMujv+Wvo0DG9m R5Z4kHfMOchgIru5iwwbwomuPGYBhpPqVXu1vuGEv0LzUm1W83TgzQKx4j4pEv95j7hlsPiyuT04 5HgzADT+7ORMnSnjnNPvYSQNUQZp7iubAVXc4rZ+53Iav8Vbiuo1WfSUIBuXwY5fs5Uw9TEFNb53 QMYtedou5WxKMoworI+aFvDyntX2/qRil0rdFiI8ZQ== =7nPV -----END PGP SIGNATURE----- --------------OsMdKIpIa0zwkKoQTlwnp6Cu-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:48:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413738.657576 (Exim 4.92) (envelope-from ) id 1odsy1-0004c0-QD; Thu, 29 Sep 2022 12:48:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413738.657576; Thu, 29 Sep 2022 12:48:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsy1-0004bt-M1; Thu, 29 Sep 2022 12:48:41 +0000 Received: by outflank-mailman (input) for mailman id 413738; Thu, 29 Sep 2022 12:48:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odsy0-0004bn-2r for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:48:40 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 096c0ca3-3ff5-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 14:48:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 661871F8AC; Thu, 29 Sep 2022 12:48:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F05813A71; Thu, 29 Sep 2022 12:48:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TsohCiWUNWM3FAAAMHmgww (envelope-from ); Thu, 29 Sep 2022 12:48:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 096c0ca3-3ff5-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664455717; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uLsehPzgf1NzdIM2zihWeDPeH/qncTm8rTQfUdL7g/c=; b=QDm+BY05RwpDHLrxSfCX+Ks9KJsvmqYEa3yTzftovNHaUs12L1KKvwL4HUVwiZiJcHxzap hlG8jis6LBBOz1BcztvXMADZ21Zs9dx2DKU3dsxl5c+HaGKsEbp7Z2YudjXmZioi8aH6Yk d/71e/5k7hx7TafktwZgoFBrirYeS/s= Message-ID: Date: Thu, 29 Sep 2022 14:48:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Design session "MSI-X support with Linux stubdomain" notes Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, George Dunlap , Anthony PERARD References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------J4iYMt0drmJiDu0OWpGbxuLc" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------J4iYMt0drmJiDu0OWpGbxuLc Content-Type: multipart/mixed; boundary="------------HGqH6ml0z1AtNDwQzi3t07wY"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, George Dunlap , Anthony PERARD Message-ID: Subject: Re: Design session "MSI-X support with Linux stubdomain" notes References: In-Reply-To: --------------HGqH6ml0z1AtNDwQzi3t07wY Content-Type: multipart/mixed; boundary="------------ccSbqRsr12ee6YczIQzsk0Dd" --------------ccSbqRsr12ee6YczIQzsk0Dd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDkuMjIgMTM6NTIsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIFRodSwg U2VwIDI5LCAyMDIyIGF0IDAxOjQ0OjI4UE0gKzAyMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0K Pj4gT24gMjkuMDkuMjAyMiAxMjo1NywgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdy b3RlOg0KPj4+IE9uIE1vbiwgU2VwIDI2LCAyMDIyIGF0IDAyOjQ3OjU1UE0gKzAyMDAsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAyNi4wOS4yMDIyIDE0OjQzLCBNYXJlayBNYXJj enlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+Pj4+PiBPbiBUaHUsIFNlcCAyMiwgMjAyMiBh dCAwODowMDowMFBNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+PiBPbiAyMi4w OS4yMDIyIDE4OjA1LCBBbnRob255IFBFUkFSRCB3cm90ZToNCj4+Pj4+Pj4gV0FSTklORzog Tm90ZXMgbWlzc2luZyBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBtZWV0aW5nLg0KPj4+Pj4+ Pg0KPj4+Pj4+PiBzZXNzaW9uIGRlc2NyaXB0aW9uOg0KPj4+Pj4+Pj4gQ3VycmVudGx5IGEg SFZNIHdpdGggUENJIHBhc3N0aHJvdWdoIGFuZCBRZW11IExpbnV4IHN0dWJkb21haW4gZG9l c27igJl0DQo+Pj4+Pj4+PiBzdXBwb3J0IE1TSS1YLiBGb3IgdGhlIGRldmljZSB0byAocGFy dGlhbGx5KSB3b3JrLCBRZW11IG5lZWRzIGEgcGF0Y2ggbWFza2luZw0KPj4+Pj4+Pj4gTVNJ LVggZnJvbSB0aGUgUENJIGNvbmZpZyBzcGFjZS4gU29tZSBkcml2ZXJzIGFyZSBub3QgaGFw cHkgYWJvdXQgdGhhdCwgd2hpY2gNCj4+Pj4+Pj4+IGlzIHVuZGVyc3RhbmRhYmxlIChkZXZp Y2UgbmF0aXZlbHkgc3VwcG9ydHMgTVNJLVgsIHNvIGZhbGxiYWNrIHBhdGggYXJlDQo+Pj4+ Pj4+PiByYXJlbHkgdGVzdGVkKS4NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBUaGlzIGlzIG1vc3Rs eSAoPykgYWJvdXQgcWVtdSBhY2Nlc3NpbmcgL2Rldi9tZW0gZGlyZWN0bHkgKGhlcmU6DQo+ Pj4+Pj4+PiBodHRwczovL2dpdGh1Yi5jb20vcWVtdS9xZW11L2Jsb2IvbWFzdGVyL2h3L3hl bi94ZW5fcHRfbXNpLmMjTDU3OSkgLSBsZXRzDQo+Pj4+Pj4+PiBkaXNjdXNzIGFsdGVybmF0 aXZlIGludGVyZmFjZSB0aGF0IHN0dWJkb21haW4gY291bGQgdXNlLg0KPj4+Pj4+Pg0KPj4+ Pj4+Pg0KPj4+Pj4+Pg0KPj4+Pj4+PiB3aGVuIHFlbXUgZm9yd2FyZCBpbnRlcnJ1cHQsDQo+ Pj4+Pj4+ICAgICAgZm9yIGNvcnJlY3QgbWFzayBiaXQsIGl0IHJlYWQgcGh5c2ljYWwgbWFz ayBiaXQuDQo+Pj4+Pj4+ICAgICAgYW4gaHlwZXJjYWxsIHdvdWxkIG1ha2Ugc2Vuc2UuDQo+ Pj4+Pj4+ICAgICAgLT4gYmVuZWZpdCwgbWFzayBiaXQgaW4gaGFyZHdhcmUgd2lsbCBiZSB3 aGF0IGh5cGVydmlzb3IgZGVzaXJlLCBhbmQgZGV2aWNlIG1vZGVsIGRlc2lyZS4NCj4+Pj4+ Pj4gICAgICBmcm9tIGd1ZXN0IHBvaW50IG9mIHZpZXcsIGludGVycnVwdCBzaG91bGQgYmUg dW5tYXNrLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBpbnRlcnJ1cHQgcmVxdWVzdCBhcmUgZmlyc3Qg Zm9yd2FyZGVkIHRvIHFlbXUsIHNvIHhlbiBoYXZlIHRvIGRvIHNvbWUgcG9zdCBwcm9jZXNz aW5nIG9uY2UgcmVxdWVzdCBjb21lcyBiYWNrIGZyb20gcWVtdS4NCj4+Pj4+Pj4gICAgICBp dCdzIHdlaXJkLi4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gc29tZW9uZSBzaG91bGQgaGF2ZSBhIGxv b2ssIGFuZCByYXRpb25hbGl6ZSB0aGlzIHdlaXJkIHBhdGguDQo+Pj4+Pj4+DQo+Pj4+Pj4+ IFhlbiB0cmllcyB0byBub3QgZm9yd2FyZCBldmVyeXRoaW5nIHRvIHFlbXUuDQo+Pj4+Pj4+ DQo+Pj4+Pj4+IHdoeSBkb24ndCB3ZSBkbyB0aGF0IGluIHhlbi4NCj4+Pj4+Pj4gICAgICB0 aGVyZSdzIGFscmVhZHkgY29kZSBpbiB4ZW4gZm9yIHRoYXQuDQo+Pj4+Pj4NCj4+Pj4+PiBT byB3aGF0IEkgZGlkbid0IHBheSBlbm91Z2ggYXR0ZW50aW9uIHRvIHdoZW4gdGFsa2luZyB3 YXMgdGhhdCB0aGUNCj4+Pj4+PiBjb21wbGV0aW9uIGxvZ2ljIGluIFhlbiBpcyBmb3Igd3Jp dGVzIG9ubHkuIE1heWJlIHNvbWV0aGluZyBzaW1pbGFyDQo+Pj4+Pj4gY2FuIGJlIGhhZCBm b3IgcmVhZHMgYXMgd2VsbCwgYnV0IHRoYXQncyB0byBiZSBjaGVja2VkIC4uLg0KPj4+Pj4N Cj4+Pj4+IEkgc3BlbnQgc29tZSB0aW1lIHRyeWluZyB0byBmb2xsb3cgdGhhdCBwYXJ0IG9m IHFlbXUsIGFuZCBJIHRoaW5rIGl0DQo+Pj4+PiByZWFkcyB2ZWN0b3IgY29udHJvbCBvbmx5 IG9uIHRoZSB3cml0ZSBwYXRoLCB0byBrZWVwIHNvbWUgYml0cw0KPj4+Pj4gdW5jaGFuZ2Vk LCBhbmQgYWxzbyBkZXRlY3Qgd2hldGhlciBYZW4gbWFza2VkIGl0IGJlaGluZCBxZW11J3Mg YmFjay4NCj4+Pj4+IE15IHVuZGVyc3RhbmRpbmcgaXMsIHNpbmNlIDQ4NGQ3Yzg1MmUgIng4 Ni9NU0ktWDogdHJhY2sgaG9zdCBhbmQgZ3Vlc3QNCj4+Pj4+IG1hc2stYWxsIHJlcXVlc3Rz IHNlcGFyYXRlbHkiIGl0IGlzIHVubmVjZXNzYXJ5LCBiZWNhdXNlIFhlbiB3aWxsDQo+Pj4+ PiByZW1lbWJlciBndWVzdCdzIGludGVudGlvbiwgc28gcWVtdSBjYW4gc2ltcGx5IHVzZSBp dHMgb3duIGludGVybmFsDQo+Pj4+PiBzdGF0ZSBhbmQgYWN0IG9uIHRoYXQgKGd1ZXN0IHdy aXRlcyB3aWxsIGdvIHRocm91Z2ggcWVtdSwgc28gaXQgc2hvdWxkDQo+Pj4+PiBoYXZlIHVw IHRvIGRhdGUgdmlldyBmcm9tIGd1ZXN0J3MgcG9pbnQgb2YgdmlldykuDQo+Pj4+Pg0KPj4+ Pj4gQXMgZm9yIFBCQSBhY2Nlc3MsIGl0IGlzIHJlYWQgYnkgcWVtdSBvbmx5IHRvIHBhc3Mg aXQgdG8gdGhlIGd1ZXN0LiBJJ20NCj4+Pj4+IG5vdCBzdXJlIHdoZXRoZXIgcWVtdSBzaG91 bGQgdXNlIGh5cGVyY2FsbCB0byByZXRyaWV2ZSBpdCwgb3IgbWF5YmUNCj4+Pj4+IFhlbiBz aG91bGQgZml4dXAgdmFsdWUgaXRzZWxmIG9uIHRoZSByZWFkIHBhdGguDQo+Pj4+DQo+Pj4+ IEZvcndhcmRpbmcgdGhlIGFjY2VzcyB0byBxZW11IGp1c3QgZm9yIHFlbXUgdG8gdXNlIGEg aHlwZXJjYWxsIHRvIG9idGFpbg0KPj4+PiB0aGUgdmFsdWUgbmVlZGVkIHNlZW1zIGJhY2t3 YXJkcyB0byBtZS4gSWYgd2UgbmVlZCBuZXcgY29kZSBpbiBYZW4sIHdlDQo+Pj4+IGNhbiBh cyB3ZWxsIGhhbmRsZSB0aGUgcmVhZCBkaXJlY3RseSBJIHRoaW5rLCB3aXRob3V0IGludm9s dmluZyBxZW11Lg0KPj4+DQo+Pj4gSSdtIG5vdCBzdXJlIGlmIEkgZnVsbHkgZm9sbG93IHdo YXQgcWVtdSBkb2VzIGhlcmUsIGJ1dCBJIHRoaW5rIHRoZQ0KPj4+IHJlYXNvbiBmb3Igc3Vj aCBoYW5kbGluZyBpcyB0aGF0IFBCQSBjYW4gKGFuZCBvZnRlbiBkbykgbGl2ZSBvbiB0aGUg c2FtZQ0KPj4+IHBhZ2UgYXMgdGhlIGFjdHVhbCBNU0ktWCB0YWJsZS4gSSdtIHRyeWluZyB0 byBhZGp1c3QgcWVtdSB0byBub3QNCj4+PiBpbnRlcmNlcHQgdGhpcyByZWFkLCBidXQgYXQg dGhpcyBwb2ludCBJJ20gbm90IHlldCBzdXJlIG9mIHRoYXQncyBldmVuDQo+Pj4gcG9zc2li bGUgb24gc3ViLXBhZ2UgZ3JhbnVsYXJpdHkuDQo+Pj4NCj4+PiBCdXQsIHRvIGdvIGZvcndh cmQgd2l0aCBQb0MvZGVidWdnaW5nLCBJIGhhcmR3aXJlZCBQQkEgcmVhZCB0bw0KPj4+IDB4 RkZGRkZGRkYsIGFuZCBpdCBzZWVtcyBpdCBkb2Vzbid0IHdvcmsuIE15IG9ic2VydmF0aW9u IGlzIHRoYXQgdGhlDQo+Pj4gaGFuZGxlciBpbiB0aGUgTGludXggZHJpdmVyIGlzbid0IGNh bGxlZC4gVGhlcmUgYXJlIHNldmVyYWwgbW92aW5nDQo+Pj4gcGFydCAoaXQgY291bGQgdmVy eSB3ZWxsIGJlIGJ1ZyBpbiB0aGUgZHJpdmVyLCBvciBzb21lIG90aGVyIHBhcnQgaW4gdGhl DQo+Pj4gVk0pLiBJcyB0aGVyZSBzb21lIHBsYWNlIGluIFhlbiBJIGNhbiBzZWUgaWYgYW4g aW50ZXJydXB0IGdldHMgZGVsaXZlcmVkDQo+Pj4gdG8gdGhlIGd1ZXN0IChzb21lIGZ1bmN0 aW9uIEkgY2FuIGFkZCBkZWJ1ZyBwcmludCB0byksIG9yIGlzIGl0DQo+Pj4gZGVsaXZlcmVk IGRpcmVjdGx5IHRvIHRoZSBndWVzdD8NCj4+DQo+PiBJIGd1ZXNzICJpb21tdT1uby1pbnRw b3N0IiB3b3VsZCBzdXBwcmVzcyAiZGlyZWN0IiBkZWxpdmVyeSAoaWYgaGFyZHdhcmUNCj4+ IGlzIGNhcGFibGUgb2YgdGhhdCBpbiB0aGUgZmlyc3QgcGxhY2UpLiBBbmQgd2FpdCAtIHRo aXMgb3B0aW9uIGFjdHVhbGx5DQo+PiBkZWZhdWx0IHRvIG9mZi4NCj4+DQo+PiBBcyB0byBz b2Z0d2FyZSBkZWxpdmVyeSAtIEkgZ3Vlc3MgeW91IHdvdWxkIHdhbnQgdG8gc3RhcnQgZnJv bQ0KPj4gZG9fSVJRX2d1ZXN0KCkgYW5kIHRoZW4gc2VlIHdoZXJlIHRoaW5ncyBnZXQgbG9z dC4gKEFkZGluZyBsb2dnaW5nIHRvDQo+PiBzdWNoIGEgcGF0aCBvZiBjb3Vyc2UgaGFzIGEg ZmFpciByaXNrIG9mIGVuZGluZyB1cCBvdmVybHkgY2hhdHR5LikNCj4gDQo+IEhhdmluZyBk ZWFsdCB3aXRoIGludGVycnVwdCBpc3N1ZXMgYmVmb3JlLCB0cnkgdG8gbGltaXQgbG9nZ2lu ZyB0byB0aGUNCj4gSVJRIHlvdSBhcmUgaW50ZXJlc3RlZCBvbiBvbmx5IC0gdXNpbmcgeGVu dHJhY2UgbWlnaHQgYmUgYSBiZXR0ZXINCj4gb3B0aW9uIGRlcGVuZGluZyBvbiB3aGF0IHlv dSBuZWVkIHRvIGRlYnVnLCBhbGJlaXQgaXQncyBraW5kIG9mIGEgcGFpbg0KPiB0byBhZGQg bmV3IHRyYWNlIHBvaW50cyBhcyB5b3UgYWxzbyBuZWVkIHRvIG1vZGlmeSB4ZW5hbHl6ZSB0 byBwcmludA0KPiB0aGVtLg0KDQpEaWQgeW91IGNvbnNpZGVyIHVzaW5nIGRlYnVndHJhY2Vf cHJpbnRrKCk/DQoNCg0KSnVlcmdlbg0K --------------ccSbqRsr12ee6YczIQzsk0Dd Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ccSbqRsr12ee6YczIQzsk0Dd-- --------------HGqH6ml0z1AtNDwQzi3t07wY-- --------------J4iYMt0drmJiDu0OWpGbxuLc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM1lCQFAwAAAAAACgkQsN6d1ii/Ey+U SQgAj/oxIabwSm6gy83Df/opPv/IeoGq/qBIvsU2mog92/6ns840S6nig/2rEYQ1FX0IU0wp+4S6 sS3CPu6RY3aDZGGRd2zMWjyFv8Dpa4duczMOTfegmQ7YRBpC2ewxOSihyVkFfzyQ5twm4ha7zB3e vt1ppDlBaj8XEZE9mgjadfByaqVTEvMDqgAbmGWmcIpDZaFlMFxU/aBBKdf5SWRMXM4A3B712swm 1Ai1St6tNgk6AxGAI1Fs2KnOnj3ZJifK49qFVI+1354bQ9JJyxNA5xZVl39HH2eyC25Bv31iVsRO x+pSy6LSHYW7l04dRs0arYUPW4uipEqnrSJ01MpSGA== =dEpo -----END PGP SIGNATURE----- --------------J4iYMt0drmJiDu0OWpGbxuLc-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:53:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:53:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413745.657586 (Exim 4.92) (envelope-from ) id 1odt2h-00065q-Et; Thu, 29 Sep 2022 12:53:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413745.657586; Thu, 29 Sep 2022 12:53:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odt2h-00065j-CK; Thu, 29 Sep 2022 12:53:31 +0000 Received: by outflank-mailman (input) for mailman id 413745; Thu, 29 Sep 2022 12:53:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odt2g-00065d-J6 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:53:30 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5f59966-3ff5-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 14:53:29 +0200 (CEST) Received: from [10.10.1.154] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1664456004116355.737884699642; Thu, 29 Sep 2022 05:53:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5f59966-3ff5-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; t=1664456006; cv=none; d=zohomail.com; s=zohoarc; b=SbWAnXOxx1ZcwQr/sUhPaorj8/ibOPgLPYg7Njl4qv2d97FGb54Dol3oIrLPgnboFRCVg36ux6mW6z09k92ZDH2S+FiGFtIKT9u0k85GQRvdxDU/0WcVb7VVKYPuS66bFchi8TZylH6vRoshUi+bSwROO98/SpHysB4osh2DGSY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664456006; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yFGTgHnFvEN4b6/Gk134JfVTIbDgE+a85Uu/E3nLISc=; b=fVz7rTYoNW67hRXE/4ZXjmpUc4bXtc27O4zTYp2j2K6t4qfhf4sayC7kOs4Sc0WENB2zDmMcIRtTX4tcNLmjQUZoh4xrYwJy8p30U9fBeQHqDVqqKaonw2PYrkqZ8DIAspi6u/syhrZRgTtOy7CL4jxvXZNDd9vXwoir0xZ+DFc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1664456006; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=yFGTgHnFvEN4b6/Gk134JfVTIbDgE+a85Uu/E3nLISc=; b=f4/k9VQ0RfmiqEVE8wgijZtbw6MZ5XLos5lHVPBxvJ9SEmSThb7cSdMKDEwRsIgT TTnCMtrYQ25y23r2TWVIbrNvKuQGhGjug2mVyKLTN1XXok/NOnWM6dfbFGxXRY+fTFy WFe8GaBdWOJQ9RUAENIU+WdWach4coM/csMDLgCw= Message-ID: Date: Thu, 29 Sep 2022 08:53:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <9340769a-d3cf-a7bb-f8f4-dc9bde463c02@gmail.com> <72674ba2-bc76-9e4c-7591-5588ff0c1f77@suse.com> From: "Daniel P. Smith" In-Reply-To: <72674ba2-bc76-9e4c-7591-5588ff0c1f77@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/29/22 04:16, Jan Beulich wrote: > On 28.09.2022 15:32, dpsmith.dev wrote: >> On 9/28/22 06:38, Jan Beulich wrote: >>> For quite some time we've been talking about replacing the present virtual >>> address based hypercall interface with one using physical addresses. This is in >>> particular a prerequisite to being able to support guests with encrypted >>> memory, as for such guests we cannot perform the page table walks necessary to >>> translate virtual to (guest-)physical addresses. But using (guest) physical >>> addresses is also expected to help performance of non-PV guests (i.e. all Arm >>> ones plus HVM/PVH on x86), because of the no longer necessary address >>> translation. >> >> Greetings Jan, >> >> I think there are multiple issues in play here, but the two major ones >> are 1.) eliminating the use of guest virtual addresses and 2.) handling >> the change in the security model for hypercalls from encrypted VMs. As >> Andy was pointing out, attempting to address (1) in a backwards >> compatible approach will likely not arrive at a solution that can >> address issue (2). > > It may not be sufficient, but it is (can be) a prereq. As I stated below, it will start setting the precedent for using GPAs. The concern is two-fold, how much benefit can actually be achieved for an API/ABI that cannot be used in the final solution. And by focusing effort on an unusable API/ABI, how much will that reduce effort/focus on crafting an API/ABI that can be used. >> IMHO, the only result from teaching the existing ABI >> to speak GPAs instead of VAs will be to break current and new kernels of >> the habit of using VAs. Beyond that I do not see how it will do anything >> to prepare current OS kernels for running as encrypted VMs, at least for >> AMD since that is the specification I have been focused on studying the >> last couple of months. > > Plus we'd have code in the hypervisor then which deals with physical > address based hypercall buffers. One less prereq to take care of for > the (huge) rest of the work needed. A question I would have is why not just RFC a GPA buffer helper framework for the hypervisor since it will get used by the new ABI and not spend effort retrofitting the current ABI. Some follow-on questions I would also ask is, moving forward would it be expected that new revisions of guests using the existing ABI would be expected to move to GPAs and how long do people see the existing ABI to continue in new guest revisions after the new ABI is adopted. >> As for ABIv2, I understand and can appreciate Andy's desired approach. >> Recently, especially with the hardware changes being introduced by SEV, >> I would like to have considered a naive and more radical approach. >> Currently hypercalls function using a more ioctl style. I would like to >> suggest that a packet style interface similar to netlink be considered. >> There are many benefits to adopting this type of interface that could be >> covered in a larger RFC if there was any sense of willingness to >> consider it. As a glimpse, a few benefits would be that arbitrary >> buffers, continuations/asynchronous calls, and multi-call are all >> natural consequence. It would also allow advanced extensions, such as an >> optional PF_RING-like interface for zero-copy messaging from guest >> user-space to hypervisor. While a packet interface could easily co-exist >> with the existing ioctl-style interface, it would be a paradigm shift >> from the past, though I feel ABIv2 was already going to be such a shift. >> Anyway, just my 2¢. > > I'm sorry for my ignorance, but I have no knowledge of how netlink > works. Understood, and you are not the first. A very quick, and very loose, comparison is that currently hypercalls are managed as ioctl remote call with per version defined payload. This proposal would move to a packet dispatch where the packet is a free-form TLV that allows unknown elements/parameters to be present. This enables a newer toolstack , without requiring a constantly moving compatibility layer, to send a packet to an older hypervisor which can reject unknown elements and hypercalls to silently ignore unknown parameters. Similarly, an older toolstack will be able to send packets to a new hypervisor. And as I stated above, this approach naturally enables continuations/async operations and multi-call invocations. It is a significant departure, and thus would require substantial design and implementation work, but there is an opportunity here to do this work. V/r, DPS From xen-devel-bounces@lists.xenproject.org Thu Sep 29 12:58:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 12:58:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413758.657626 (Exim 4.92) (envelope-from ) id 1odt7q-00077M-Cy; Thu, 29 Sep 2022 12:58:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413758.657626; Thu, 29 Sep 2022 12:58:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odt7q-00077F-A0; Thu, 29 Sep 2022 12:58:50 +0000 Received: by outflank-mailman (input) for mailman id 413758; Thu, 29 Sep 2022 12:58:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odt7p-000779-93 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 12:58:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7521031e-3ff6-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 14:58:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9407.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Thu, 29 Sep 2022 12:58:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 12:58:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7521031e-3ff6-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTeN9qCubmt9GBZ7j08i7yj6tabaeSqtFWVV+LTWziTw5ykX/5CODZQIa/NXdzBkNAAjjNeNLCaKGQQCd3t7DNBklpV3tmukj7Xy36eUqSu405PlqvB8tVl9rr5S5NSPzF+lEFRA8NkvVOhT/XzeN8WHcn9VA5GV38H291FNKhWZJozrFbP9qxaNaJWb7CzyCt3JyL04RooaYWl+rS3GubGm7a5Dny1rzRHmEzmiHDf+238WgCwIY+6mKi3oiUvnSqKD9vWamJmGiPZmaqsrVzAJ6zGjyLGqqmnLGoleDT9ZJKeLKVrbfILNfQ+k5TtCZnr2hbPGQ7+xOH+QIO+P2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PAoIfGkUUecPBnAXkD2bFSWzkQhWxhdnL3EJzl3/6a0=; b=XVEyWZPeosp4SepSW+6ow3bfMjJIQp8WXkG9RklUP5vjNchFICwJ5RprtQTQNDwGnZ63TM20S8s9ShKYDfqINUbMXl5niW9wbgcOKyNertV+ZGdaoH3ANwElpoCsIB/W8EHRFd6vTLi1Du1y6vykU3UDjxcEe8KK29rhC56vkVAHa9+6itMUIxywRw3m3aArFAYHZGye4eg8Dhbbt9Bh4BDq5nD08yzh4NnLs7OuEVD5hWk4QPS/QTmQMs53LTtMEVPPu97BgS5Hneg2mYlIclSvKGOCHjqETDnsWOnzJZTDCrvh67NirfMmWrldOAvg4iexifx+vGiFVQTT7ue+Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAoIfGkUUecPBnAXkD2bFSWzkQhWxhdnL3EJzl3/6a0=; b=K3U1h03KwqMjb2oyexhItBpT7bjrwquwpagK0l+n2dbR7YFFllTyXF+nkW1ToMjvtkjFLOMy2kOIwUiuRcF+oS0a530KjM3kacPeOGxYxWXya2+C2MDKQ7VaCYrPDtXPsEJqo34tDN8ffmkg1hT5j7Zs0rbnPhXo6r0DM7kFvrZZ+dIqNHyJIDi3cWrU9sA5rE/ZX11reJXNW8h2RD3na3Q6irNWmjscyNx71d69VOB4AEKXsyDqjU2nBjKJUmT0FN6O9Kg2UOmubNDMnyBjYyNzppaZ5COOfVbFG1bQmPnhGUPid0DSEN6ciMu6Ar913IqIEIjkou0pzqKMKzwuCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6b766de0-90bb-db4c-e90d-d5c8baafae9a@suse.com> Date: Thu, 29 Sep 2022 14:58:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9407:EE_ X-MS-Office365-Filtering-Correlation-Id: d6d233a7-51d1-4614-a906-08daa21a581e X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R9MTsxJfyuwJaePTpgKQZ9xDWuXEjWpCL3EP1S+KKE9la9Nwye/KZJ1DjIGaLUgfqxmosST6PJh2jxdG+d0abhKGQZMgVHmeZBR5i9NaP270kWPQXGiNiYs9+j/KiBH+BfsxwB2lr2b5F1e6SBMluOzYmxVKIxgk91WpCnNwZa4MEZcivjFkIexrVTkk27M5zxaqxGqEn9QX8H0RZP5k0U5vFaJw6bFKpQyuja3yACywYG8MgezWYhT5lrrmkdPn8nzi0az/29AKthnawB3DTj3CdVzf3O+/Y+fQ1Pmz9of6WFYPLYIanMI2am23DoDZePq6UuQmm2Z2jOHTx0SEDOSflmrgfo8X8lLlXNHI542CVS57AlDVoN4ic5Gj3sn6fbCeBBQP2k2l1dRDdN3BcqM6f7SaVVB+xBMHgAiPROKWQt8f5sx8GWP/SaDhHMGBmGhGA5dvs4WCm+qAUkENo5Sb88mMTS0F7PCOToA15USZlahSR5cpHZMYBerbOX3l6NsWXMSnZljl0sFHGwVQJx45Vde14moxlXcXz8EC3TVeVRVsyVI88N8MbrloXw7xfIxOUp1zO9lCnJpcC07SvqJ/syleJvcpxSCa/0cnXCr0ZnZI+L78D6phwdV9bJcb6Q2AQuV4miQsORFqOMbY7IM3E0cWtez/oB21y7mYXvJ4PKP9K2UyWI+VgW1TM4fx3Rjs/Pqd8T0D6MdHmTOO5PKO4eCyoPoeDtMh1c76LwMq4KhyMgnxvdCJpm9++GB1fvgH9iXb9svnnzxg04BJ+H7abjAwsJ1FA/5Cnyy5Tn0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199015)(4326008)(37006003)(54906003)(31686004)(316002)(66556008)(86362001)(31696002)(66946007)(6486002)(66476007)(8676002)(5660300002)(8936002)(53546011)(6506007)(26005)(36756003)(83380400001)(6862004)(41300700001)(6512007)(6636002)(186003)(478600001)(2906002)(2616005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnduKzQ4ZC9ZaDdMTVVvSjNGY1lOTGo1cjZxZVJOQVZicGNFUi9uSXlDOGVJ?= =?utf-8?B?MVRJck1hcm1mMFFERUpHVURzenA3UTAxMFFPS3lFNzNId1loNHpmMEpPZG1r?= =?utf-8?B?QzJkWENlWDhoeXhZSytNbnpURE9Yc2JsaWE1emJxcFRhcUNOWk9oSG9wWVRY?= =?utf-8?B?RWZIZHp0bFQxTzdSUWVRQkIyN0FDSEdBNHplTEZJWHYrN0VxeEUwRjdZMmVV?= =?utf-8?B?VE1RUnlkSnJ2bHh1MExKb0R3cUVLbDBlcmRFVzdLSWVtNTJaTENBQkRsL1Va?= =?utf-8?B?eFFlYXJCZEZma2hCTjY5eGZOODAvMlpNRmFCWmZtZXJZblI4UWNCN2h5akVP?= =?utf-8?B?QlczamhLdzZaSGxpSitrQkNYc09uTXduNkNlallyODBTUW41R2FONkNGUktt?= =?utf-8?B?dnFncUU1L2xvRGJzeE9DRjVvYmM4UTRZZ0llYjZXK3Z5K1B1bVhSMXB0K3Q5?= =?utf-8?B?aDUyckJyQTFtSzViVElnNzJNa0V5T1h1VllLWEZrYWQ3ZGZLS2hVaFZkd1FZ?= =?utf-8?B?WDNvVWIzVXVQaWVUWjB1SU9VRStHbmtuUVJGU3FiSDNybHlHbG0veUlHTkw0?= =?utf-8?B?a0V2ZHIyK3NFQk4xR0hORVR0MzY5ajN4QUVpMWpTaGZtK1NGOFYvelFqTlJS?= =?utf-8?B?WWJDVnYzUG1UZ2N3R3dJVWs2eHJMdXRJRFozaXBBTmhuSGdkMktGalJiL2dS?= =?utf-8?B?Y1ltNnNFMTVzUldTV2hEWXVFc08vQU56d09pZXpGamdwNEdoUHRlamdkbUx5?= =?utf-8?B?em9kazVpUUV5Q0hPRUYyUUZCdFZtNTJDSDgyNU0yak4yVGFiTTBqTXZ2V0dj?= =?utf-8?B?dzdHRU5OQ0FTdXp6RTRzNGVtbUZXd1VNTTF6SUlCMkJLMHNxQUZqekJnaVFz?= =?utf-8?B?aXovbHpGK2drSmRJOTR6T0lxTVlEV25FL0cxb1NIcUhDa3Q0WWcvMU5zRXFT?= =?utf-8?B?ODc2anZrNjhQaTY0OGd5L0xRYWlDN1hjbTFiN2VRWmtLNU5lTlF6K3pjRzNl?= =?utf-8?B?dWNGL1E0c0dUdEV3RUhLQTY0KzJWVXp1QVVzNTErUkNEZUdWZHZKZVBuZXRH?= =?utf-8?B?Zks1KzJFYjFDZmxWamdRMHBJR2FZenh3cTNOUjdmMGg4V0piUWVnTDF2V2FL?= =?utf-8?B?ZVc4OFVkRTk2OGV6YmtjT0dYYjhRYndaeXR0SmtPbVV3bTVlVjBtbFZYTXRS?= =?utf-8?B?US96amxKd2l6OGhUMUJ1QUNzaVBUZXFWaDVqZmFHOE5kKzcyNWVnSjZpODM0?= =?utf-8?B?Nk9USEdReTJRbUhBVkFEeVVEdDdvVUhTaHBOQ3Z2TnJETGFOQWkwTlRNNzBh?= =?utf-8?B?U0pXWlE5akRxRHp4aXc3VU9CNGZ0YnUyVDRkYmdqQlgxdjJ3TTdOcEFNTUVY?= =?utf-8?B?Z2NMY3lnV0hkM1BSejk4N2NDSlpzelJpZXNnU1cxN0Yxc1U2cFRXU0MxOGVX?= =?utf-8?B?bVdWcUd1aWpNWFRuVDd4NFJQTWEzdTJHbXgxQnRrTmt5UmJqMmJPZWFQSEdC?= =?utf-8?B?R01LRzh6SHpjN2NrWVBRemZndmhSejFOaklPa0dXV0FESG15amVPdkRyN0h2?= =?utf-8?B?RmpMcWVIQTJjUXVZUmFnaXdpM2tEd0lXNVJ6ZHpVbEdkdWZLV3MwdU1DZ0t6?= =?utf-8?B?Sk1DRnNXLzNsSVBDVzBLaGVHdDlRY2hEN2JyZjJQUGVuMHc5OVZqWDAzN3lZ?= =?utf-8?B?NVZyemNYR0g4TjJRUlNwdnl4MVg5M1YyWTkvSDcvcUVyMVJZZVVNcVl0VjFm?= =?utf-8?B?TE9JVVdjWHNtdzlCSWpHYzZTVlNwY1Nmc0ZIZGFOL0djOEhFNHROZ2RoTjFs?= =?utf-8?B?ZndJMEVxc2pMKzVtRVM0L0dDVFF1ZS9HNkw3MFVtY2o1MWdoOHdaOFlFZVMx?= =?utf-8?B?d241amxGR3ZyU0xzWW40NmtPaDd0azBZVVNSeGtGV3Y0dWl1a0JrV2lUelJV?= =?utf-8?B?QnRnbGVld094NnhaMHZabWJESndiUy9Walo3REVLRllyNkNVU0o0TmpkWjdi?= =?utf-8?B?cjloaGVYUmlnbGpKZE5rYmNyZFBRYmR4djc4YW82RnRTRjdWNHdNOGVtWGMy?= =?utf-8?B?TXJvaC9iSERXMTA0amdKNmJSaDJ0UUhBSEx2WGpsaHp6UGNmMzFseXR1MDBZ?= =?utf-8?Q?1uhGcotSZpVGPqA8PjNXWpfEA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6d233a7-51d1-4614-a906-08daa21a581e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 12:58:45.9006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: obU8JaqDsiSeMuuwI7KNpdc0heSlT5R/LHHqBXbE7Crexog7zhuVonl7n7Gxdb6TW+HU7BI1z4QJztXKXuTWjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9407 On 29.09.2022 14:26, Juergen Gross wrote: > On 29.09.22 13:32, Jan Beulich wrote: >> Finally - in how far are we concerned of PV guests using linear >> addresses for hypercall buffers? I ask because I don't think the model >> lends itself to use also for the PV guest interfaces. > > Good question. > > As long as we support PV guests we can't drop support for linear addresses > IMO. So the question is whether we are fine with PV guests not using the > pre-registered buffers, or if we want to introduce an interface for PV > guests using GFNs instead of MFNs. GFN == MFN for PV, and using PFN space (being entirely controlled by the guest) doesn't look attractive either. Plus any form of translation we'd need to do for PV would involve getting and putting page references (for writes also type references), along the lines of what is already happening for HVM. Since "put" may involve freeing a page, which in turn require locks to be taken, we'd need to carefully check that no such translation can occur from an inappropriate call chain. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:03:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:03:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413764.657637 (Exim 4.92) (envelope-from ) id 1odtCN-00007U-VM; Thu, 29 Sep 2022 13:03:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413764.657637; Thu, 29 Sep 2022 13:03:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtCN-00007N-Sm; Thu, 29 Sep 2022 13:03:31 +0000 Received: by outflank-mailman (input) for mailman id 413764; Thu, 29 Sep 2022 13:03:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtCM-00007H-Nw for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:03:30 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cf69c9c-3ff7-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 15:03:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3F65421CF4; Thu, 29 Sep 2022 13:03:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 225821348E; Thu, 29 Sep 2022 13:03:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 08DTBqGXNWNtGwAAMHmgww (envelope-from ); Thu, 29 Sep 2022 13:03:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cf69c9c-3ff7-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664456609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KIxb67JcftxEENpWL1/xaTe3LEWiMHpVX+wSLAbp8nE=; b=lkkzFncLpeFux4ku3O3Wmdxl7bJMAyVqfMB0+68SzTaiDf7Gfa5ugstkcxKKI0ThTMDpLE Fahh5l8/4dDtTRokaLf2zix53dUWYdh1S3rj8q+T2Osiw7DY4vOYzh+DqMw3Y6Neh11MI9 SWHne7cocAdDEB8ed4FSII2Lf5UMpoA= Message-ID: <6fea6ec4-0181-22fa-808f-ea66e43bbeba@suse.com> Date: Thu, 29 Sep 2022 15:03:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Proposal for physical address based hypercalls Content-Language: en-US To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> <6b766de0-90bb-db4c-e90d-d5c8baafae9a@suse.com> From: Juergen Gross In-Reply-To: <6b766de0-90bb-db4c-e90d-d5c8baafae9a@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------krG5JfJceoew4vetuW93qR9U" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------krG5JfJceoew4vetuW93qR9U Content-Type: multipart/mixed; boundary="------------W9PBFNGWKlEAjqJRH3SLjP1p"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper Message-ID: <6fea6ec4-0181-22fa-808f-ea66e43bbeba@suse.com> Subject: Re: Proposal for physical address based hypercalls References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com> <850214fa-7e26-8a19-c318-9ded849fffda@citrix.com> <6d2e1b23-2299-01fd-0e79-1c9ab1b5bace@suse.com> <94aab958-c141-4c43-a249-a55d8e5be735@suse.com> <6a3d38a8-bac3-fa59-e882-0d95a8d3e5d0@suse.com> <6b766de0-90bb-db4c-e90d-d5c8baafae9a@suse.com> In-Reply-To: <6b766de0-90bb-db4c-e90d-d5c8baafae9a@suse.com> --------------W9PBFNGWKlEAjqJRH3SLjP1p Content-Type: multipart/mixed; boundary="------------0NzgRnHWvACaQlxWpdYliY83" --------------0NzgRnHWvACaQlxWpdYliY83 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDkuMjIgMTQ6NTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyOS4wOS4yMDIy IDE0OjI2LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjkuMDkuMjIgMTM6MzIsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IEZpbmFsbHkgLSBpbiBob3cgZmFyIGFyZSB3ZSBjb25j ZXJuZWQgb2YgUFYgZ3Vlc3RzIHVzaW5nIGxpbmVhcg0KPj4+IGFkZHJlc3NlcyBmb3IgaHlw ZXJjYWxsIGJ1ZmZlcnM/IEkgYXNrIGJlY2F1c2UgSSBkb24ndCB0aGluayB0aGUgbW9kZWwN Cj4+PiBsZW5kcyBpdHNlbGYgdG8gdXNlIGFsc28gZm9yIHRoZSBQViBndWVzdCBpbnRlcmZh Y2VzLg0KPj4NCj4+IEdvb2QgcXVlc3Rpb24uDQo+Pg0KPj4gQXMgbG9uZyBhcyB3ZSBzdXBw b3J0IFBWIGd1ZXN0cyB3ZSBjYW4ndCBkcm9wIHN1cHBvcnQgZm9yIGxpbmVhciBhZGRyZXNz ZXMNCj4+IElNTy4gU28gdGhlIHF1ZXN0aW9uIGlzIHdoZXRoZXIgd2UgYXJlIGZpbmUgd2l0 aCBQViBndWVzdHMgbm90IHVzaW5nIHRoZQ0KPj4gcHJlLXJlZ2lzdGVyZWQgYnVmZmVycywg b3IgaWYgd2Ugd2FudCB0byBpbnRyb2R1Y2UgYW4gaW50ZXJmYWNlIGZvciBQVg0KPj4gZ3Vl c3RzIHVzaW5nIEdGTnMgaW5zdGVhZCBvZiBNRk5zLg0KPiANCj4gR0ZOID09IE1GTiBmb3Ig UFYsIGFuZCB1c2luZyBQRk4gc3BhY2UgKGJlaW5nIGVudGlyZWx5IGNvbnRyb2xsZWQgYnkg dGhlDQoNClNpZ2guIEkgbWVhbnQgdG8gd3JpdGUgUEZOcywgb2YgY291cnNlLg0KDQo+IGd1 ZXN0KSBkb2Vzbid0IGxvb2sgYXR0cmFjdGl2ZSBlaXRoZXIuIFBsdXMgYW55IGZvcm0gb2Yg dHJhbnNsYXRpb24gd2UnZA0KPiBuZWVkIHRvIGRvIGZvciBQViB3b3VsZCBpbnZvbHZlIGdl dHRpbmcgYW5kIHB1dHRpbmcgcGFnZSByZWZlcmVuY2VzIChmb3INCj4gd3JpdGVzIGFsc28g dHlwZSByZWZlcmVuY2VzKSwgYWxvbmcgdGhlIGxpbmVzIG9mIHdoYXQgaXMgYWxyZWFkeQ0K PiBoYXBwZW5pbmcgZm9yIEhWTS4gU2luY2UgInB1dCIgbWF5IGludm9sdmUgZnJlZWluZyBh IHBhZ2UsIHdoaWNoIGluIHR1cm4NCj4gcmVxdWlyZSBsb2NrcyB0byBiZSB0YWtlbiwgd2Un ZCBuZWVkIHRvIGNhcmVmdWxseSBjaGVjayB0aGF0IG5vIHN1Y2gNCj4gdHJhbnNsYXRpb24g Y2FuIG9jY3VyIGZyb20gYW4gaW5hcHByb3ByaWF0ZSBjYWxsIGNoYWluLg0KDQpTb3VuZHMg bGlrZSBhIGdvb2QgcmVhc29uIHRvIGNvbnRpbnVlIHVzaW5nIGxpbmVhciBhZGRyZXNzZXMg dGhlbi4NCg0KDQpKdWVyZ2VuDQo= --------------0NzgRnHWvACaQlxWpdYliY83 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0NzgRnHWvACaQlxWpdYliY83-- --------------W9PBFNGWKlEAjqJRH3SLjP1p-- --------------krG5JfJceoew4vetuW93qR9U Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM1l6AFAwAAAAAACgkQsN6d1ii/Ey+/ mQf+K/t/QM0SB/F84lP30njxetrja+wvtS2ctxli9P6d+yxE1eIfAnr5aSceuHhArqXdMZWn9vMF BhDzZmfpyDkASaoRl/xOtyp/C/4JNpW4CoaBWdoOGLso1atUWYdhldwEFQWs58B8ruhjdi3d36QA brZzp9A3ubea9vZe/OOXWKnIW07+6uqANVReyHoEcTs7Gqnh88uGE7TPVC+9Cqb4IMmgdQ/mVen0 AzZ8Xi3aT1M51SvvjuAbfk3Xz0ngEW8Io4W0gEPYCeyPNy8+t28GvfczmyqwRXefEYpycBDZZcqh UdHblWlh4YnlxbJ3PtynP3r2FSE17PyxhFPcDvxJxA== =eQnt -----END PGP SIGNATURE----- --------------krG5JfJceoew4vetuW93qR9U-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:07:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413769.657647 (Exim 4.92) (envelope-from ) id 1odtG8-0000r7-FA; Thu, 29 Sep 2022 13:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413769.657647; Thu, 29 Sep 2022 13:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtG8-0000r0-CB; Thu, 29 Sep 2022 13:07:24 +0000 Received: by outflank-mailman (input) for mailman id 413769; Thu, 29 Sep 2022 13:07:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtG6-0000qu-WC for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:07:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7461d9d-3ff7-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 15:07:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7727.eurprd04.prod.outlook.com (2603:10a6:102:e0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 13:07:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 13:07:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7461d9d-3ff7-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iIGduCOaAG9+ABf0J0xeynLvK1ci1wVth51loXunr61/Chu214LyzbmUNhEejLbK/zJZlKfKzFMHTQK7HZY0Ki0eZKsuyMk/BUhG8EoaICbdxM79LyyVF4WAu6nLl8gDpKlm/1yzhGAiRy2xnXwv6G2egXOP7qlDuZZHKLpG6pxO7FwrxGlpZB4oda5H9yyFTxOJy4NSK9gTA5pbh9B1BAml0q6Hv6Mb08ZLft9eWgY3bzgeHW7ZqVm567CrneQJ4wPpgpEuhE/EjUZsk5lDZaK9QxdaBOlacWrIBa1pTLaixq0kbvXyknYPaNxjlbSrdrKr4pp671wM+8El75aXew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CbUiIJBfrFotvWwnCl6u8JrOebjzPe2CR3v7xnTIDoU=; b=RzI77qdvTT+3gcXTpyZq+vTcZHEi811I78dW2crgjm3dt/sKNsZFJydwhLpvDK7zKaxxzDImm6Yl9VO9Knd80QMNfXp9Dr5ejwfwo1aLY6xfR+64/TTfwkcx4ikKAbPbIU0LcZJSTdIQ4sWnyodHVKammCBd2x0jSKFWR8gd5RModiuWVvs8iV4BGEBb4ugpj0oJTdG8Co2c/nq6Dw79S/USNW6mHdMFR5GGpPHQ+IXXuAuNVNgc1OCTHyRRbUVtpVrEc5h1Sj+qga6K6ex3lSlHTKzpsMTRMx9dRdOd3Ps8fRKxBnVsWZVh65DvgWra/T8ZPvTAAsFgoOE3LolA3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CbUiIJBfrFotvWwnCl6u8JrOebjzPe2CR3v7xnTIDoU=; b=l3GoX17mBZ2DarvqK+hxN/B8J4A1diQL23QzDRXHa7Jv0MZqEMF9uLinbqPZLjJcCHITK3nhdYCnPGgCKS830xeH6C5IYPHWFe7n7Ln8DilJQiK58JLbzLoMNnhnXwfVP00EQcK/ilv/0WSVxQT9xqklny1TP/9AJCtpxqFjWMp+XLltgse3THD6BGGOu+OFw/Dqp+WuLsHq0x42WV2o0fzyxvQamS7mLmrXMrTS25rbgmvFdnd+z2EOZq4oBuFzfqsG/gpzbRIUWyagt8NQw6ny6hkWZYOKcgGorCeNZk9DmMV3qpqVHgRvonGvZra/Evjgn6S3q2tRxVhH8ptZMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1e9f75e3-c59c-e3a4-f26d-59a440d366aa@suse.com> Date: Thu, 29 Sep 2022 15:07:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Tamas K Lengyel , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Boris Ostrovsky References: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> <7a469ef7-5ad7-5abf-2c1f-fa29496fa2a5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7727:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ea5acf2-ae3f-432d-3047-08daa21b8a67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VzpqVv/R2+uVvEePXM7rO+ATwpRkOz8VJhTw5dkzPpcFPnKeH92zbHw383bXDuiS1RcC7Ft3LyFZEmTnEfpDKexPqqe73rqSocYKDVJd9SMW5vVe6eHNaLZNs2+TMVg4K2am+f82JQrfEQ3kaxtRhtrwgqg/SygiD0PC20bAe0I97GehXANGQ3daEPoxhplXObe4HD9ARkfe3fg9iWSeLTKZHs9vBEolT82yoNM6d+c1J0P2pKTymqeHmd84IeailON8tu38vmK3OKYmJc57N6ds5Jpv0MQ06Ol/JyCKhRFH3Zb4HEeqRCUAaUsqJNU1mh4Nr5JZqM2EQLLunl4M3X8rCtr46mvIfet5wmbJyheIFBpA8Y5Ew0ntiayMSKwQz1x0wUpl5hCLrzB61JGB4v7+H5e8i9yRwyI5+T9K/irx/BRzLX8/BlRaw6uFCLQ+IxbVwZ8CnKA1Yoag5jNOQvyp9Hju+iaz43NQG23l+IHMQuH8937Vx2zmwOOwpzDcSxV+gd/HI6DPF3LluYj/zHUfPssti7BJT0lGzgkGRUsV0pmLnbVQgItiVxR8K/Ba+6ZBrO15Ci9N5v8+VEn0q4xapmSEEYtosn8JbEyWK0h9cwAbRPNgUCj8Y864dij2zMHus+fuJHAYK8GylSoyxfEul5QzXKUacOPP+tYDGgYKWhhtSq6E7A/z2RyjrgO0LjO6oYRCiW72HV9qJeYQ1w8H0LAaYGIbcs8ddbgE5Iq3n8WzaQPk5Pc2JYX2coJQa3CVe4DbsFesIdr4nx9oN8TL37RefT0CDStTefuZobw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199015)(2616005)(186003)(26005)(83380400001)(38100700002)(6512007)(41300700001)(2906002)(8936002)(6486002)(478600001)(316002)(53546011)(6506007)(5660300002)(66556008)(66476007)(8676002)(66946007)(6916009)(54906003)(36756003)(4326008)(86362001)(31696002)(31686004)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE5ZVnlJa1pwWGwyaXl1NnplWTdwL0NaUHhDa3BtQ0dzUEJ2aFQ2VytqczUw?= =?utf-8?B?bDc1V3dNRDZsRUphUnR4L0hDOTN6SHg5ZzRzZXgrNHdIbndkVkc2S29IOGl2?= =?utf-8?B?S0dTVjVsN2oyNFMvOGZFSVNmYVJmbm1tU2hISUlraUVaRXhocXFyd3QwQlpm?= =?utf-8?B?RUtLMDczVk5lRG56S3BQKzhUUzFzNUtiWjJvVjVHSVNnQTFGWEEyTEFJMWZn?= =?utf-8?B?d0RqUGdLdjV4VnlqRlp5RkpMSWVkcWhvdEZZQnBoaVlkR1VvNE9QRkd1RVpG?= =?utf-8?B?WTc5WjJxMHlTUGxrTFJic3E4UU15VC9NUVVkVEFSTytlc0didGtxV1IreTZK?= =?utf-8?B?eFVwY1pUWXhHcTN3MXZqOGJ1b1lKQ1NmdXkvclkyV1IwVTUwK0t5aU5WSlc0?= =?utf-8?B?S0ZkVDZYWGJocHVoQUpkRWNMSFhmZUlCMjdVUlptSjdqckU4emJES1hBek5D?= =?utf-8?B?QUNVZzZUcVBhUFQ1MEhTR3RkSGhCWFZPeFJKa004LzlML2JRVFE0SmtuZUhI?= =?utf-8?B?MksvSTdjbWJzTUFES3pOUEYyUmxTY2FJM1g1ZG1CcS9ZRGJaRStJMFVVVWRp?= =?utf-8?B?eS9GUXgxUG1YdWZ5YVMvekhFWFlFOHJ6N2JLLzd6a1JxNlV3czZ3TkpsNjlv?= =?utf-8?B?Q1lSWWU2T3p3TXBUQlRPNG93WVdPd1l6OXMzYVNWQVJ0Z3RFeDh5ZGNSOVV0?= =?utf-8?B?NHp2Z3hXTFlsNllGMGk0UEV4MTdMeEVPbWpGV2ZmM2dGM1p0UnI4ajBNM2dv?= =?utf-8?B?bVllQ3JaOEZFNzhjU2N6cTdNbG1HVFJ3cXZYUEZGUjJnSXlBazhnMlNDalM0?= =?utf-8?B?VkFOV0NPMzVtOXZIcElIN0dYTG4yQzBvaWMrTEU5b3ZhcFQ3czZYN1ZjcnI5?= =?utf-8?B?WmFMcERSaU9Fb3JrejUzZDVzVjdZcktNRnJiWmZ5cUVIdXU0Mm14dTJKSGZE?= =?utf-8?B?RlRPekpQVkY5WXpMaTB2ZmxJMzQ3Y2Y4SVB5Z09HTXlFMTdMdWI2UjNYNUhH?= =?utf-8?B?eE9zYnlxWmZESWY0MzNDVkhuczE1SGVOUE5Rc2h1VkVMMGNCQWFpVEV0U3VX?= =?utf-8?B?TWNyd05sMjgzaVRkNG1RM3JRNVhxSTRMMTZIUkpXUGpQM0FSTnJxM0dFNlpD?= =?utf-8?B?cERrM2tqaHBselZoSitoY3ljYVd4WFNNcExuRFY3Tmhkd3RGd2kxUWFQakFU?= =?utf-8?B?M25mTU8xd3IwYTlZeGpTZEVCN01BZ0RZdFBpWU9XV2IwaGQxdStFZE0yOUcx?= =?utf-8?B?cUVhV0UwYmRvY1pHTlN4UXdGc1J5bjc4Qmo4QXZxSWlCUFJNdU9DVDlQSFUv?= =?utf-8?B?NGgrOFB4WjdKbEg5NDZTdDJFeU1mc1dzbGZnNU9OclJOb0QyM3J5eVJXT3py?= =?utf-8?B?bTFCajRLQlA1TTV0RUxkU3pZVThiby81akp1QjVRazAvSUt0Y1FLcEJFVmsr?= =?utf-8?B?VXc5cHhSdVlwYnk0bWRsS0NIWm4vU1FvSHNVWDRpaVYxbU9Ud3lDTXhPKzZW?= =?utf-8?B?MTFoOTMwRzh2OUxoU01PWTJ5VkpRSGVzRGFPZGtZS0x2TlNweEcrSkZpODBR?= =?utf-8?B?QWJnb2JqeTZ0WDRkUXREak9KRkJPQ3QxcWNkVSszeE9qcUtPYzh3eElSL2Vl?= =?utf-8?B?akJWQm1ZbE1qQ1FEWmtkRmZ6dmRoWGRLRzd1U1VnV09EY1NaTlFJcXhobFpZ?= =?utf-8?B?RE1YLzZDRHRWL1I0ZGVEWElsK0RTaWE1REtIelNJdXBlUUR1WnNLN1JMdnI0?= =?utf-8?B?S3dSb1ZMYWpCMm5tSlVCUHZVZTllRVo1aFpqWkxPS1AxbEhDN2g4UmpBTHoy?= =?utf-8?B?V1pCWTFDY3NPUUd0RW1rUnFaZUh1TnBkMWM0OFRSS0JMRmNnMENkRFpscUx6?= =?utf-8?B?KzdTbjdzMDdWZmJlT3BjWmgxL0RFc0tpSDl6U2R2a3pCN0NpZTh2bGc5OTZr?= =?utf-8?B?Z2ZKOFRYY2ZISE5IYmVrMTkycjdCT3VZZWsrTUJCM2NZeGUvODlkT1BLNk0x?= =?utf-8?B?azZhZG5TbW5tcHpsV1dpSnVOclA1a1JPam0xbHl3M0dPUG5HaFo5VzcyazAz?= =?utf-8?B?K0NqRDYxOUE0aERtdHUvbnJicUlhNmZRZzlMWk1yeERINXNEb2JMTWdYZjlX?= =?utf-8?Q?BoSsj+GeiBIDABzot+gs+XyDE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ea5acf2-ae3f-432d-3047-08daa21b8a67 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 13:07:19.7587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FIDWHT4r+vFBBr/M690/bZy/RuuUxQQFyTgxWx+3pEmmAKejsdHvxKsww5lyS8qIEFpn40rjG+1OdHvSzGAFIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7727 On 26.09.2022 16:22, Tamas K Lengyel wrote: > On Mon, Sep 26, 2022 at 10:12 AM Jan Beulich wrote: >> On 22.09.2022 22:48, Tamas K Lengyel wrote: >>> --- a/xen/arch/x86/cpu/vpmu.c >>> +++ b/xen/arch/x86/cpu/vpmu.c >>> @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) >>> vpmu->last_pcpu = pcpu; >>> per_cpu(last_vcpu, pcpu) = v; >>> >>> + vpmu_set(vpmu, VPMU_CONTEXT_SAVE); >>> + >>> if ( alternative_call(vpmu_ops.arch_vpmu_save, v, 0) ) >>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>> >>> + vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); >>> + >>> apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); >>> } >>> >>> int vpmu_load(struct vcpu *v, bool_t from_guest) >>> { >>> struct vpmu_struct *vpmu = vcpu_vpmu(v); >>> - int pcpu = smp_processor_id(), ret; >>> - struct vcpu *prev = NULL; >>> + int ret; >>> >>> if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) >>> return 0; >>> >>> - /* First time this VCPU is running here */ >>> - if ( vpmu->last_pcpu != pcpu ) >>> - { >>> - /* >>> - * Get the context from last pcpu that we ran on. Note that if >> another >>> - * VCPU is running there it must have saved this VPCU's context >> before >>> - * startig to run (see below). >>> - * There should be no race since remote pcpu will disable >> interrupts >>> - * before saving the context. >>> - */ >>> - if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) >>> - { >>> - on_selected_cpus(cpumask_of(vpmu->last_pcpu), >>> - vpmu_save_force, (void *)v, 1); >>> - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>> - } >>> - } >>> - >>> - /* Prevent forced context save from remote CPU */ >>> - local_irq_disable(); >>> - >>> - prev = per_cpu(last_vcpu, pcpu); >>> - >>> - if ( prev != v && prev ) >>> - { >>> - vpmu = vcpu_vpmu(prev); >>> - >>> - /* Someone ran here before us */ >>> - vpmu_save_force(prev); >>> - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>> - >>> - vpmu = vcpu_vpmu(v); >>> - } >>> - >>> - local_irq_enable(); >>> - >>> /* Only when PMU is counting, we load PMU context immediately. */ >>> if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || >>> (!has_vlapic(vpmu_vcpu(vpmu)->domain) && >> >> What about the other two uses of vpmu_save_force() in this file? I looks >> to me as if only the use in mem_sharing.c needs to be retained. > > I don't know, maybe. I rather focus this patch only on the issue and its > fix as I don't want to introduce unintended side effects by doing a > cleanup/consolidation at other code-paths when not strictly necessary. While I see your point, I'm afraid I don't think I can ack this change without knowing whether the other uses don't expose a similar issue. It would feel wrong to fix only one half of a problem. I may, somewhat hesitantly, give an ack if e.g. Boris offered his R-b. Else the only other option I see is that some other maintainer give their ack. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:14:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413777.657659 (Exim 4.92) (envelope-from ) id 1odtMo-0002L2-9e; Thu, 29 Sep 2022 13:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413777.657659; Thu, 29 Sep 2022 13:14:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtMo-0002Kv-6r; Thu, 29 Sep 2022 13:14:18 +0000 Received: by outflank-mailman (input) for mailman id 413777; Thu, 29 Sep 2022 13:14:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtMm-0002Kk-Qv for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:14:17 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9dd91064-3ff8-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 15:14:15 +0200 (CEST) Received: by mail-ed1-x52d.google.com with SMTP id a13so1961656edj.0 for ; Thu, 29 Sep 2022 06:14:15 -0700 (PDT) Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75]) by smtp.gmail.com with ESMTPSA id d23-20020aa7d697000000b00456ff7d4283sm1556637edr.5.2022.09.29.06.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 06:14:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dd91064-3ff8-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=y4mGqivhiQmUV8ipfVZW3SYpSuTWtk+iojxfx05uBbA=; b=FeE41N8AaAWMAXhdBjoSeQOcB8/xkRu6HTMlCOkbSfaYahZIwIKAkLcasU247vxR3M Z41oGs452qlua62bLO7xGiKH7ZL6zJc9w+7Qp/maRR/soZ6vrRxoTrrptI28WjWfQhbM /SiHNJygLFybZehB9gLtSm3ylOPXKojFMoXX9Po5iyDJzi3EToz/Mb03EGOjs/WPbEiW ug7yHZNtRpRJg+B3Bw9TWmEPOvpt6kcT5nNCrMY5lXPVCokyZD77oBY8ng1U4yS3hYKw 4N6LbvDb902I01pXgCbsu+Hlsq1IslL4/KR3B4B8GLZN9fveo6dDRr4yKceAQS+4OPCp jtCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=y4mGqivhiQmUV8ipfVZW3SYpSuTWtk+iojxfx05uBbA=; b=cIxmDrVzKB8kq1FjquVmR/kB86vGUkLn24D5h3FeNBNrNROjIwLTolZZ+94MIyYnmo leU6OL9mvU4HRFRfBB/wwlYwHKAc+XwbrxlAFMMe53xLj/71KDAKA3ewFylOTDW6hBTn 1tN8pL/8RaivUR6PnYkb2t6fR7T6unS808j+DklgjgfnjS7vqNH+CtvKbpGBVdTn4j4C 9Udepr96c1te6MdkDco21g9d33Bbg79lD8PfBVxifrTNVA4oj2R9cXMx5ZHnCDc+Ksyg 9aS+eM1SRfGK9nFincBJK7SFGlOXozOgYOwL6jE7W8BNvSGjV4u2Ncg/UQxZFyNPxLUb rTOg== X-Gm-Message-State: ACrzQf0P/IetgAkHULjYqTljD/4N4dQ+H/fuilT2wCE7YUkztI4wqjkY wbVA4g6qs/8axIGCoTHhTrM= X-Google-Smtp-Source: AMsMyM7hB9flUAQunU1fNM6208XFtFZd5WDG0e5dt8N/E7ctFXeaztsdgmE66YaVlZj7zVHwlzUIWA== X-Received: by 2002:a05:6402:1e8d:b0:441:58db:b6a2 with SMTP id f13-20020a0564021e8d00b0044158dbb6a2mr3203163edf.277.1664457254593; Thu, 29 Sep 2022 06:14:14 -0700 (PDT) Message-ID: <4336e65e-23a7-9b8e-3548-55b06d0203ec@gmail.com> Date: Thu, 29 Sep 2022 16:14:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations Content-Language: en-US To: Roberto Bagnara , Stefano Stabellini Cc: Bertrand Marquis , xen-devel , Julien Grall , Volodymyr Babchuk , "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220819194359.1196539-1-burzalodowa@gmail.com> <44eb89f1-67db-6232-e28f-ab380e71b9fc@gmail.com> <6A69A0CA-087F-4260-9371-8EEEAD3926A3@arm.com> <422ad42f-8bfa-55a9-2e70-4ae857632a94@gmail.com> <12c95841-027b-ae02-1945-b0d232ffb17d@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Roberto, On 9/28/22 17:11, Roberto Bagnara wrote: > On 9/26/22 10:50, Xenia Ragiadakou wrote: >> On 9/18/22 16:02, Roberto Bagnara wrote: >>>> The question is on the interpretation of Rule 20.7. Are parenthesis >>>> required by Rule 20.7 in the following cases: >>>> >>>> - macro parameters used as function arguments >>>  > [...] >>>  > - macro parameter used as lhs in assignment >>> >>> You can obtain different semantics depending on whether parentheses >>> are or are not used (in the macro call and/or macro expansion >>> depending on the case): >>> >>> >>> #include >>> >>> void g(int v) { >>>    printf("%d\n", v); >>> } >>> >>> #define m1(x, y, ...) g(y) >>> >>> void f1(int x, int y, ...) { >>>    g(y); >>> } >>> >>> #define p 0, 1 >>> >>> void test1() { >>>    m1(p, 2); >>>    f1(p, 2); >>> } >>> >> >> In the example above something bothers me. Let me explain. >> >> Running the above example gives: >> 2 >> 1 >> >> The results differ mainly because m1() is substituted before p. >> Thus, adding parentheses around the macro parameter 'y' of m1() i.e >> #define m1(x, y, ...) g((y)) >> has no impact. >> >> If the example is changed into the following: >> >> #include >> >> void g(int v) { >>     printf("%d\n", v); >> } >> >> #define m1(y, ...) g(y) >> >> void f1(int y, ...) { >>     g(y); >> } >> >> #define p 0, 1 >> >> void test1() { >>      m1(p, 2); >>      f1(p, 2); >> } >> >> if no parentheses are added around 'y' in the definition of m1(), the >> compiler complains with "too many arguments to function g". >> If parentheses are added around 'y', the compiler does not complain >> but the behavior will still differ and the result will be >> 1 >> 0 >> >> This happens because in the case of m1(), p is interpreted as an >> expression (due to the parentheses added there) and the comma is >> evaluated as a comma operator, while in f1(), p is interpreted as a >> list of expressions and the comma is evaluated as a comma separator. >> >> Hence, in my opinion, parentheses should not be added around macro >> parameters used as function arguments because they can hide a bug due >> to missing parentheses around the entire macro definition. >> Since macro 'p' is supposed to represent an expression, and the >> semantics of the comma token are those of a comma operator and not a >> comma separator, then parentheses need to be placed around the entire >> macro definition i.e >> #define p (0, 1) > > Your analysis is correct: the example was meant only to show that > the use of a macro or a function with the same actual parameters > and apparently equivalent bodies can make a difference and that the > addition of parentheses (around the body of p, as you suggest, or around > the occurrence of p in the call to f1()) can avoid this problem. > All this, however, is outside the scope of Rule 20.7, so the example > may have been confusing: sorry about that. > >> AFAIK, there is no requirement in MISRA C guidelines to add >> parentheses around the entire macro definition when it is used as an >> expression and this is something I cannot understand. >> Unless I got it all wrong I guess ... > > Yes, this is known and it is has also been brought to the attention of > the MISRA C working group. > >> Can a deviation being added in the basis of C99 standard since >> according to the standard, E1[E2] is identical to (*((E1)+(E2))), and >> therefore, macro parameters used as subscript expressions are implicitly >> parenthesized and can be exempted from the rule. > > Sure, you can always deviate any non-mandatory guideline: just be ware > of the fact that complying is often cheaper than deviating. > >>> For instance, if you noticed Rule 20.7 reports given by >>> ECLAIR and not by cppcheck, then maybe line >>> >>> Rule 20.7              FP >>> >>> should be >>> >>> Rule 20.7              FN+FP >>> >>> If you can let me have an indication of the code that >>> ECLAIR is flagging for Rule 20.7 and cppcheck does not >>> flag, I will be happy to double-check. >> >> ECLAIR flags as violations of Rule 20.7 the cases where >> unparenthesized macro parameters are used as (1) function arguments or >> (2) array indexes, while cppcheck does not. >> >> For instance: >> (1) in xen/arch/arm/include/asm/atomic.h >> #define read_atomic(p) ({                                               \ >>      union { typeof(*(p)) val; char c[0]; } >> x_;                          \ >>      read_atomic_size(p, x_.c, >> sizeof(*(p)));                            \ >> >> x_.val;                                                             \ >> }) >> ECLAIR flags as violations missing parentheses around 'p', when used >> as an argument of read_atomic_size(). > > ECLAIR is right in reporting these violations of Rule 20.7; > these are false negatives of cppcheck. > AFAIU, the rationale of Rule 20.7 is to ensure that the precedence of the expression, produced after the macro parameter expansion, will be higher (a parenthesized expression is a primary expression and has the highest precedence) than the precedence of any operator performed on that expression after the substitution. These two examples refer to cases where either no operator is applied to the expression or the applied operator precedence is the lowest possible (comma operator) and for this reason the rationale of the guideline may be considered insufficient to justify the need of parentheses. I guess, that ECLAIR flags the above as violations because there is no formal exemption in the body of the rule. Cppcheck intentionally considers those cases compliant but unfortunately there is no justification in the commit messages of the respective changes. >> (2) in xen/arch/arm/arm64/cpufeature.c >> #define SANITIZE_REG(field, num, reg)  \ >>      sanitize_reg(&system_cpuinfo.field.bits[num], >> new->field.bits[num], \ >>                   #reg, ftr_##reg) >> ECLAIR flags as violations missing parentheses around 'num'. > > Same as above. > > I am probably repeating myself, but the MISRA guidelines are the result > of carefully-chosen compromises between the simplicity of the guideline > and its ability to protect against the targeted bad thing.As Rule 20.7 > is required, any violation will have to be deviated by projects that > have MISRA-compliance among their objectives. There are two things that have come to my attention and may cause confusion around Rule 20.7. They may have also been brought to the attention of the MISRA C working group. 1) Rule 12.1 (Advisory), which suggests the use of parentheses to make operator precedence explicit, does not require the operands of a comma operator/separator to be parenthesized because it recognizes that overuse of parentheses can clutter the code. Since both Rules 20.7 and 12.1 aim to address basically the same issue, why they are not aligned? 2) Rule 20.7 maps to the CERT-C Rule PRE01 which has a formal exemption (PRE01-C-EX1) for the above case. Maybe this sounds irrelevant but it struck me as odd. I forgot in my previous email to thank you for your help that it's really much appreciated and needed. Thanks a lot. > Kind regards, > >   Roberto > >>>> On Fri, 2 Sep 2022, Xenia Ragiadakou wrote: >>>>> On 9/2/22 05:07, Stefano Stabellini wrote: >>>>>> On Thu, 1 Sep 2022, Bertrand Marquis wrote: >>>>>>> Hi Xenia, >>>>>>> >>>>>>>> On 1 Sep 2022, at 10:27, Xenia Ragiadakou >>>>>>>> wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 9/1/22 01:35, Stefano Stabellini wrote: >>>>>>>>> Patches 1, 4, and 6 are already committed. I plan to commit >>>>>>>>> patches 2, >>>>>>>>> 3 >>>>>>>>> and 5 in the next couple of days. >>>>>>>>> Patch 7 needs further discussions and it is best addressed >>>>>>>>> during the >>>>>>>>> next MISRA C sync-up. >>>>>>>> >>>>>>>> I would like to share here, before the next MISRA C sync, my >>>>>>>> understandings that will hopefully resolve a wrong impression of >>>>>>>> mine, >>>>>>>> that I may have spread around, regarding this rule. >>>>>>>> There was a misunderstanding regarding the rule 20.7 from my >>>>>>>> part and I >>>>>>>> think that Jan is absolutely right that parenthesizing macro >>>>>>>> parameters >>>>>>>> used as function arguments is not required by the rule. >>>>>>>> >>>>>>>> The rule 20.7 states "Expressions resulting from the expansion >>>>>>>> of macro >>>>>>>> parameters shall be enclosed in parentheses" and in the >>>>>>>> rationale of the >>>>>>>> rule states "If a macro parameter is not being used as an >>>>>>>> expression >>>>>>>> then the parentheses are not necessary because no operators are >>>>>>>> involved.". >>>>>>>> >>>>>>>> Initially, based on the title, my understanding was that it >>>>>>>> requires for >>>>>>>> the expression resulting from the expansion of the macro to be >>>>>>>> enclosed >>>>>>>> in parentheses. Then, based on the rule explanation and the >>>>>>>> examples >>>>>>>> given,  my understanding was that it requires the macro >>>>>>>> parameters that >>>>>>>> are used as expressions to be enclosed in parentheses. >>>>>>>> But, after re-thinking about it, the most probable and what >>>>>>>> makes more >>>>>>>> sense, is that it require parentheses around the macro >>>>>>>> parameters that >>>>>>>> are part of an expression and not around those that are used as >>>>>>>> expressions. >>>>>>>> >>>>>>>> Therefore, macro parameters being used as function arguments are >>>>>>>> not >>>>>>>> required to be enclosed in parentheses, because the function >>>>>>>> arguments >>>>>>>> are part of an expression list, not of an expression (comma is >>>>>>>> evaluated >>>>>>>> as separator, not as operator). >>>>>>>> While, macro parameters used as rhs and lhs expressions of the >>>>>>>> assignment operator are required to be enclosed in parentheses >>>>>>>> because >>>>>>>> they are part of an assignment expression. >>>>>>>> >>>>>>>> I verified that the violation reported by cppcheck is not due to >>>>>>>> missing >>>>>>>> parentheses around the function argument (though still I have not >>>>>>>> understood the origin of the warning). Also, Eclair does not >>>>>>>> report it. >>>>>>>> >>>>>>>> Hence, it was a misunderstanding of mine and there is no >>>>>>>> inconsistency, >>>>>>>> with respect to this rule, in adding parentheses around macro >>>>>>>> parameters >>>>>>>> used as rhs of assignments. The rule does not require adding >>>>>>>> parentheses >>>>>>>> around macro parameters used as function arguments and neither >>>>>>>> cppcheck >>>>>>>> nor Eclair report violation for missing parentheses around macro >>>>>>>> parameters used as function arguments. >>>>>>> >>>>>>> >>>>>>> Thanks a lot for the detailed explanation :-) >>>>>>> >>>>>>> What you say does make sense and I agree with your analysis here, >>>>>>> only >>>>>>> protect when part of an expression and not use as a subsequent >>>>>>> parameter >>>>>>> (for a function or an other macro). >>>>>> >>>>>> Yeah I also agree with your analysis, and many thanks for >>>>>> double-checking the cppcheck and Eclair's reports. >>>>> >>>>> Unfortunately in the specific case that I checked, it was not >>>>> reported because >>>>> it was actually an argument to a macro, not a function. >>>>> Eclair does report as violations of Rule 20.7 the macro parameters >>>>> that are >>>>> used as function arguments and are not enclosed in parentheses. >>>>> >>>>> So, one tool reports it as violation and the other one not. >>>>> >>>>> The same goes, also, for the case where a macro parameter is used >>>>> as index to >>>>> an array. Eclair reports it as violation while cppcheck does not. >>>> >> -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:28:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:28:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413783.657670 (Exim 4.92) (envelope-from ) id 1odtaZ-00045r-Gw; Thu, 29 Sep 2022 13:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413783.657670; Thu, 29 Sep 2022 13:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtaZ-00045k-EA; Thu, 29 Sep 2022 13:28:31 +0000 Received: by outflank-mailman (input) for mailman id 413783; Thu, 29 Sep 2022 13:28:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtaY-00045e-J2 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:28:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a6851a4-3ffa-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 15:28:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8781.eurprd04.prod.outlook.com (2603:10a6:102:20c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 13:28:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 13:28:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a6851a4-3ffa-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UU1VjUGyM+BFKosLL2/szadoDW7tvBmUW3Z7YhPNpq/9ombWJnXYnAD3tOWxsepDO9IjJ04AuZj6iZE5U+H6sdMrS9AEKvhPFT3GMADUKtf6XXKUPqWDzvXrTfHY2fwLKefPHzotJqhpdf7p5W6sevYO80BgAtTEQ6WWqw63EfeIAJfwf/13PPuaNlezNOAqyHP4fJvYVhYhAy1Degtg2ZL9I/f3xXf/MP+3Tx3JB/YvPfFHmV4+mhqSYKvDwfFcygqOqttlIiCOOOXtRTxEgu+h/QxwRZagdzCst87UFlnEAw47L12gD5XJFsh2dZPT7PPIGPAEQ+/zcwUJ/Slk3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sz5ivruGwQ7eYnIntAddcPznpIkbdaPX6SM0pE+4IHo=; b=kcVgtXOsAqwMVLPkVfRRqTQ+tiE3Xa9q4htv30Y3/r8dgKuMvyyNyEb1+yEe717Iu/i4n5fXoVehGisoFL0akOgjiQfh8xVWQY1VnKDBYYHMhcrl5iUzsM15YxbT+FMd/wTWjEFWmHq8r+li5Lc7o7DIiON41nEIoabGf9jCwfVi807UBjH+Pm83S3hQAwpUxwZ1gDNgsDR0u+0NlcBVFtAmHFQ1S41A5TMnXMccCvSi9BOwdiBw2AvIbNB/hMjbivHz8RyGk54vOIZMyxz6DjSKXp/LJXCh90r4LEq/aB2EAONTpo1f3vysNdUNBeW/rBCUXnxCpThMYT6hAkIbpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sz5ivruGwQ7eYnIntAddcPznpIkbdaPX6SM0pE+4IHo=; b=0PoLODgE1G8DlBG65+3CzGHGwIyneBSFw07KWYcvxZbuMl6NjhiwfZpXyc4pzIKwVxCpNuP/K4bN4dVIkzzSvXVIhcWbVM6VaPfzRx8ODcUWHxajgMzaPcfzRh+vi1izDW48+9XtoQDiaLkemiZGL6lmdk/BGwRSrrj3//Rj73XedX/hmM9LbjJjYMIzrEiNgfWiCLiuMr9hXAQcm0+9JXcvoAQI0erD4UnuBGb/9ohZyM9YW5TP0JRJx8k+FZOFdH21y2qI1py/JAzQqbh6r2lQ7lbA3iuFH9QC3TQfqm9Y4YEovPuwkBrRm/d/+2GnX9WKin8e9T3Ip0P13mvdeg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 29 Sep 2022 15:28:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: Proposal for consistent Kconfig usage by the hypervisor build system Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0057.eurprd06.prod.outlook.com (2603:10a6:20b:463::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8781:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ba79a6d-88ee-4f91-1a25-08daa21e7d7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ti+sL+gzFykRBnI3F6xJmDS5WBDNGiUwltMbuRPr7MAnNYy5ESvxGL0pAtq4wnLw7HS0uli0eGp8tcqnvyGxZdIzUcxSHpFuF1lHOPViAsAHercOFcHK50uHGgF5XwxueIqs5qU2Ka5Na993AllTojQWpWJXrG2XMmUFnLiuhCPqQpJJLXW6l6Lo0wGMECKmOjsfIAOXay3Foy3pEOnqillrIYhG+saBFwGM9TpBe+Diitx/KvXNADnLX/Y06nJ4zm5d9Foxdzy59TpiMmR8sT0ln5T8AqrUS8R6bUZbxbEmY8Bhn8C6IrSeSLK5ZEw+1ZwgtbxlMCThIYwo3nMZge69hKe9fpFtnZr/bpmcbM7G8ymzXkEZA7XBuLBQekSQWfHdP2hrDPDTUWhzGgmzBQ3G16IAUcRjCUM/DblT35JElmAE3SQP9+K2Peng+MyeOjpPovXJDrV8TCqD023Cf/cSbgCEbTEzT8IY1FhbKlk9SnIM/7hSpD4yxvp5XrkHTuC4hXq8MvCW6QUDXc2QPXLPhU5pVnlJzKrVYWQ3dNvUY20MJ2XTrLAFRq9dcGHJgXpjMPW6KjTW3UzSvcby3WmjjaVxtIOamnjIZl23GPZI6BZAF3P0++1z3/Y57Qr5GLPa7OBtfb8dp+L3hRoPeOxo9G0umf/KWlPSPSqk1DrJXnvOgkDrSL6rnyZoNg8JtirsOUpa2bJGR7pKqdtM/KREj7YYrV+8cucIVGZXizRLOUKRHRkzBsZHwTodaWOysqR2XWlMBdZTq8M/IlkgAwI2y4NNi2K7C0DedQbFDkk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199015)(31686004)(66899015)(36756003)(5660300002)(8676002)(6506007)(41300700001)(86362001)(31696002)(38100700002)(83380400001)(2616005)(186003)(478600001)(6486002)(6916009)(26005)(66556008)(6512007)(66476007)(8936002)(2906002)(316002)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzdCdlhtYUo1c3ltV3VPWVlGRG1OdElIdFRua0ZaMndTamw4UFVkeUc2NnU2?= =?utf-8?B?Y2R1bTJMK3A3bzlyOFBhNk9jdzlNOE9ybm9rZ0d4cmttaFJpVWhDVVMrN1BW?= =?utf-8?B?Rm9PVFhUZGNZdkZRRlFIcDNWWlZjTW8rQ0F2MmIwV1Rya0gySFRiUkpPam5G?= =?utf-8?B?eXZMMVphS1AyZXJYODdJY25ES2tTam9XMmFaVjY0R2h1dU03R0RPbTVyazlH?= =?utf-8?B?c2RoV2tHL2NsamQxS0xWdnk4dE5HRHdRTVZrdktoZjNWTHp0aExKeVJmVys4?= =?utf-8?B?THY4NmdMZ3ZWRHE2NU9tT1lLRklxQlZxQ0tWL1VTR2Q4SU8yQkVaemNTTG80?= =?utf-8?B?WUgxME5QYzZ2UHVRQzdQalJvSzhQNzA5cXNDVkJMdk9mYVF1SE1VWU83bFVl?= =?utf-8?B?NllMUXJMUGVxSmVUZit1NFNmWmhRMTlEYUgzdVlkOTB5bktILzltaXQrbVFR?= =?utf-8?B?ZTNWbDVPNDFUeW8wMGFabWcwOW1GUnhnbk9xUkJNNWZaNkVIL05Ia05DUnJv?= =?utf-8?B?dUhqRjl3ZGVDQ1hEQ3JjcDU5RGlsNXhZZXFrb3pDM1dyMURhZ3dGQWF2TS9s?= =?utf-8?B?TFBWUGpPWlRQYllTakF4TVVIeWlaZmZKUnIzQlNPS25RMWYvWG9KRElRbTZh?= =?utf-8?B?S2F2Y3NsTTM1dWFwclJDaVl5S2NnNkFyZTNMclNub1ErUFNXbWh6K0JCVFND?= =?utf-8?B?LzV5TlgwTC82T2ZGcTlPNVVVZmhLNlpuU1BweUVIUXpXSTZXanBjS2V5bkJQ?= =?utf-8?B?bDBoQ0l4R0h0M3M5MklEZlhFUm9QckhVNHBxMkRpK0ZLOWd5WnZJZWQ4cmd5?= =?utf-8?B?QTZJblliU094cmEzeDRRRHRSQmJhY2pOMjRRdmVrbTlPamZCbHN1eXVva29h?= =?utf-8?B?QVhsTSs5TFJISHdjQTFjNDFWMTErRWFFQitYYzF2elppaDNrOVBOUEdyN2px?= =?utf-8?B?bFhCa3Z6dUxQQmVVbk5GZVF6ZDhrOTBLTHNUemVRa3krVmh4azJLa2JrTlNx?= =?utf-8?B?SWJ0Q0hzUWpzdlhiY3RsamI5L2Q2bGZwMU5HWmVLYXgwUHVBRkhMK0srMUhw?= =?utf-8?B?MFdVY21Dc1BLSzBvenN6eHpKZVNZeTBuRW1UR1p4S2VMUWE2M0Erdk9qNXNs?= =?utf-8?B?VkpXdEJZMlFPaDRCZFN5eUMybkUxT2lnWURRcDlZa1ZndEwwdFUzYWhxUEhL?= =?utf-8?B?U3ZteURBRlQ1WTcwbjIxRzlaZHNuQW9TYzlwcDRUcElJc1FlTEtOaWY4WjND?= =?utf-8?B?S0ZrZjhaWHlXckFwbVpiK1JHd0plV3FTVERRcFk4TjM0MUo1MElMSGlCYUpB?= =?utf-8?B?bVlIY2RHWFZHUk5LNFVDU3FmV0Rwem4xWXFkMUh3UzY2cEo3blZnSytnaWRR?= =?utf-8?B?S0pneDRSdUxjWGdoWlJYVDFBcWlPc1V0eU1QZWkyQWdMSTNVR0M4ZGVzWUU4?= =?utf-8?B?dU5qK1NJaUcrQldkSkEydWo3NE1CQzZXMjA3bkVHbHdsV25nb3FMVDZ1bFJS?= =?utf-8?B?T0VTV3dxUERVR2tVSTNmMHo3bGY3MXZEWXZnZ0VDVFgzTG83UEFGSER1Vi9O?= =?utf-8?B?YVNaS2NVMldTY3JzMisvbGMyOTcvTyt0cnRKUENBMVpqU0I4WFprMkw5ZmJH?= =?utf-8?B?dHdYZk1QT1c0bDh1TnJiNU9PR1ZMdEU4WHk3VlFSZnJad05uMWdOVVIxQnkw?= =?utf-8?B?dE1jYkhDd0J1OUxsZHlLVTBMWFZGbDZYUTR1aFo0VE9wTE56UTZwUmxYUFBS?= =?utf-8?B?b29NcXVzM3hxRmJBS3hzUjJGdWhzSUJESEhVNXBQaC9jWUhSbkVjTmtkWWFk?= =?utf-8?B?eVphU1oybjFwRGRvU0M0VU5WalE5UkIxMUVhazM1dU9SVVlVeDlhcUpKbUxI?= =?utf-8?B?UG5FYmNsTVlGMTBKeCszWUFVWGM3aEFJb0RPN2F5RW1aMjZPZ3UvRVRDQ1ZT?= =?utf-8?B?ZGZGQ043S0h5WENBR1VDdGdDRG12cm9GVFBJa2xpQ2tzbDAyaEZ6WnVXaldn?= =?utf-8?B?SHR2Q0NpSS9jV2ZGZFRoUzhuOWE4a2c4bmxHVXp5QzZXbk0xYTFvMVlDMWVO?= =?utf-8?B?cHBzQ0wvcnNuM3c0NzcrRitaMkxaV2NMdU1ZOE1mWkdGLzVUZ0lHVTZ3b1Vw?= =?utf-8?Q?F6kkcvmTP3mmzcvviE3eq1aA5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ba79a6d-88ee-4f91-1a25-08daa21e7d7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 13:28:26.5847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pfpr/xna2DGCpu06QPglGiH5sw06/zalicUL6gwSQwQPHOqtAhp8Tw2D1NFuUkmAKzwK4H1Qq3dB7Dmr4G7DSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8781 At present we use a mix of Makefile and Kconfig driven capability checks for tool chain components involved in the building of the hypervisor. What approach is used where is in some part a result of the relatively late introduction of Kconfig into the build system, but in other places also simply a result of different taste of different contributors. Switching to a uniform model, however, has drawbacks as well: - A uniformly Makefile based model is not in line with Linux, where Kconfig is actually coming from (at least as far as we're concerned; there may be earlier origins). This model is also being disliked by some community members. - A uniformly Kconfig based model suffers from a weakness of Kconfig in that dependent options are silently turned off when dependencies aren't met. This has the undesirable effect that a carefully crafted .config may be silently converted to one with features turned off which were intended to be on. While this could be deemed expected behavior when a dependency is also an option which was selected by the person configuring the hypervisor, it certainly can be surprising when the dependency is an auto-detected tool chain capability. Furthermore there's no automatic re-running of kconfig if any part of the tool chain changed. (Despite knowing of this in principle, I've still been hit by this more than once in the past: If one rebuilds a tree which wasn't touched for a while, and if some time has already passed since the updating to the newer component, one may not immediately make the connection.) Therefore I'd like to propose that we use an intermediate model: Detected tool chain capabilities (and alike) may only be used to control optimization (i.e. including their use as dependencies for optimization controls) and to establish the defaults of options. They may not be used to control functionality, i.e. they may in particular not be specified as a dependency of an option controlling functionality. This way unless defaults were overridden things will build, and non-default settings will be honored (albeit potentially resulting in a build failure). For example config AS_VMX def_bool $(as-instr,vmcall) would be okay (as long as we have fallback code to deal with the case of too old an assembler; raising the baseline there is a separate topic), but instead of what we have currently config XEN_SHSTK bool "Supervisor Shadow Stacks" default HAS_AS_CET_SS would be the way to go. It was additionally suggested that, for a better user experience, unmet dependencies which are known to result in build failures (which at times may be hard to associate back with the original cause) would be re-checked by Makefile based logic, leading to an early build failure with a comprehensible error message. Personally I'd prefer this to be just warnings (first and foremost to avoid failing the build just because of a broken or stale check), but I can see that they might be overlooked when there's a lot of other output. In any event we may want to try to figure an approach which would make sufficiently sure that Makefile and Kconfig checks don't go out of sync. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:32:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413789.657681 (Exim 4.92) (envelope-from ) id 1odtes-0005VD-2S; Thu, 29 Sep 2022 13:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413789.657681; Thu, 29 Sep 2022 13:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odter-0005V6-Ve; Thu, 29 Sep 2022 13:32:57 +0000 Received: by outflank-mailman (input) for mailman id 413789; Thu, 29 Sep 2022 13:32:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odteq-0005Uv-Lg for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:32:56 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39468bc9-3ffb-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 15:32:55 +0200 (CEST) Received: from BN0PR02CA0050.namprd02.prod.outlook.com (2603:10b6:408:e5::25) by DM6PR12MB4910.namprd12.prod.outlook.com (2603:10b6:5:1bb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 13:32:52 +0000 Received: from BN8NAM11FT041.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e5:cafe::61) by BN0PR02CA0050.outlook.office365.com (2603:10b6:408:e5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Thu, 29 Sep 2022 13:32:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT041.mail.protection.outlook.com (10.13.177.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 13:32:51 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 29 Sep 2022 08:32:50 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 29 Sep 2022 06:32:50 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 29 Sep 2022 08:32:48 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39468bc9-3ffb-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWIhZEC5ggFZNKf30GqM0MYQ+ILlV8A0poVJ5R98LZOFdq97hWunBUnJCTHT+ZlD2HsT6wjX7gvSOGYO/ErPdKNMILIVaXEEwZjDXWVMdr23zwYLpDkfBZyRpPRwoQbp7R943YTPw0Lx1FSWqxSZLUme9yaZw5kCKgGmSj7VdAXuU3EJR3RTjAjoWEia3T0vdKVYY4qP2DpTuM3DK+fPZV+mkq1CcNlVqs60ZU/G4CPnpYw1NAx/U0alSoB/Fr3CI36080KqlpxdkGcuxwFtf7j0bZlUrV6n8qchsKJa+I3nAQUdYUdHrztKVGCdfvl2/nqR1wstydYQplC3HeiukQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2bZOgUC+eGrVpc1D4MLGuSGxUlynpxq/Qic03RuiFp4=; b=W9xFrEDmeQ1dlKcnzqbXutY6afYDlPAHeSTBY+uKoNE9jPe3yPujicQp1gWbOV/KDOyKtae2ivnG4YvawFbjxaMnbc+ZDMfsfD77S73ssuTfKI3TzxuGRQwgtIEWZ9e3AR4TZ1HeYjAURz4EaiisGkl0Qa/mHheKGa02EyFdWAKaC8AUeSJeYVv55d+K45xZNZuPq55CIzsLSEi6FeC4t17F5S0oZ0ZrNiDMGq6mXVg3NEbsfwD+KdlTyuA3aPRaMzPgX8XWprt7aAafM1GBvo5a2Hoc3My2vl8whsruLtUi4NFPdM3mWFeYvHQRS8FANz68cUjg0tU3nDB6JOQ0cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2bZOgUC+eGrVpc1D4MLGuSGxUlynpxq/Qic03RuiFp4=; b=Mt93EoODI53yJosZoTXFgvsZpyyz1r+e99m9bupH10lzRFqaYXmDYYPBdxwdUIjETzfuP21vIN5JVvEeRHBUcvddyKcW9hucEq24W4luIJPcgjGdHUPmlS4SbcRoN3uQbXaBsM1ifY3F6dDuk/OcqVBj1Dr42oRi3NNy6ZouU1o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 29 Sep 2022 15:32:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [XEN PATCH v2] automation: Information about running containers for a different arch To: Anthony PERARD , CC: Stefano Stabellini , Henry Wang , Doug Goldstein References: <20220926135838.47330-1-anthony.perard@citrix.com> <20220929095131.61034-1-anthony.perard@citrix.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20220929095131.61034-1-anthony.perard@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT041:EE_|DM6PR12MB4910:EE_ X-MS-Office365-Filtering-Correlation-Id: 93f78151-fe26-4266-d260-08daa21f1bc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDokZIceEiQA945C40hqFjPc/dmcP32kIPmwaCsARtvDNNrvPXm2h/UC5rj92MPL8gjz6pyqKxNOOII3eZxzEuhge0Z0XV/uzO8N/wo5OgQI5/IgCsBScOIh9lPgkixwQswncZZu6KfhluU8R7c7ltEmbVH0ezCxPoh/sd+CiAmpJF9ETawzI6Tizqv//DLKMsWr2xtWOjmjrXHr2wE9XwlSMpGgbmh+5YWYMUvTyNAW5KyVKFZWbdkTYPy1rNk56ji4Ia9urI3fG7YFhJBWZs76KH9yC/JLYiZLIaCWs0IUv3uVGBIzcHRFCrQBYqBeFbAWzmTDaTw91rD5/fwI7r3BHqFJ/EgDKDzk8tGP3zSbywwt7RnXfAb8V/9W5DNzc4pagOxbHRtgV9yHW1u992t8tNbyC77Tx01w7zTmmaQDDcqPWtz4oK54TBv1il0ks4SPrVwi68wgl0sNC+i4Omme193fAsvHa/omNIhElIW25RYI3Rlvj9ZhIsoQ0b4kAn7ddSy3fYvnMo3m7jkMC+g4upe0a3DgiJtaUpj6yY/U6S5pZEBYUEWMgiZ9TwX9jYzJBoRTv2OucGJE7Fysc/HPSkHPsSty1ODu+y/8GY75oFWekse+GS28ZTz8ezTOHnPaKwH/xOOlyNpFqlPaqBxRJGXjPln4CoInn8/WkGF9A4m+B0IPmK3howysRWaHBgW0S0mHcbSoo8Iopixw55/KmZCXSlDj/EM6tl1MTZRVhstoZbMDi/hpM3oxNvh5Bfj+lepAlADmuT9oxdi0f0F3QBfjM78EP6o65JUoHkzC+AHbIgTnXDbun5cPi9ZkVv5cGRl1de7hUMKZI+Mgsw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(31686004)(186003)(8936002)(53546011)(54906003)(40480700001)(86362001)(31696002)(47076005)(336012)(4326008)(426003)(8676002)(40460700003)(356005)(478600001)(2616005)(26005)(82310400005)(316002)(16576012)(558084003)(70206006)(70586007)(41300700001)(44832011)(82740400003)(110136005)(2906002)(36756003)(81166007)(36860700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 13:32:51.8938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93f78151-fe26-4266-d260-08daa21f1bc1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4910 Hi Anthony, On 29/09/2022 11:51, Anthony PERARD wrote: > > > Adding pointer to 'qemu-user-static'. > > Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:33:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:33:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413794.657692 (Exim 4.92) (envelope-from ) id 1odtfN-00062L-He; Thu, 29 Sep 2022 13:33:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413794.657692; Thu, 29 Sep 2022 13:33:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtfN-00060z-Df; Thu, 29 Sep 2022 13:33:29 +0000 Received: by outflank-mailman (input) for mailman id 413794; Thu, 29 Sep 2022 13:33:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtfM-00060d-QC for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:33:29 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c300216-3ffb-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 15:33:27 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7111E5C0129; Thu, 29 Sep 2022 09:33:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 29 Sep 2022 09:33:26 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 09:33:25 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c300216-3ffb-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1664458406; x=1664544806; bh=6HSOENZNpW S8PT5EAsCWrJ5UsVb56LeYD/1s5PWTopw=; b=JgffH9L3iodrpb6r9ox9HtxaTR RctI/YHNwFjgye6EwqqiNRu48qS0vUJYie+QuCanG6/IIKeLwp6fgFuxgPY0bbfm wemK5EN6QhaBWJYb7c5BOjlEjZl5hey16d987dvvN1sNWy/a5ARARYhionAkqFKe fSvmFpc3ws/OJ2JHe3qvdTjN7eCe+rCj23QlfMzXgh7NYGDZGwOCZ9KBEP8CEa10 9bd15nBeZ/RLCrF/+T87Ns4r35fxg8nByc42In4NERrjtcIQ+neVQOp2d9DTBXNP xLIioQXjy1ZPhsjKt7SG1R856zZadb1+h+tx7MYywrYUt0CC6CteMkp7BfSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664458406; x= 1664544806; bh=6HSOENZNpWS8PT5EAsCWrJ5UsVb56LeYD/1s5PWTopw=; b=f 6WbqKIpDEHWE+YijzWQawVUCRhfQ8psn8+9ai1IwJGc4vfpslmI9kpk5OMQ9aNvv uqaERAnjRtok6bOveRxqKFxIpTs5aLthT+46YTj8iQzt6l7Sk87OudrfxfrZW5aO qkfdq/EGEkjRkSWtuHPSSzB1ENvz9HcT43mrLVrSr4DcdTFvlPhCTLhVhomBC2Y5 maK0jZeLTRmkREwErkkNdI6Aaq1NvDofgj3lwcNHJyqvccizjnGbWnZ+xd/q5fRr 3pcFjFFDW2n1AlHcYO5LoBNSGw2ToQ3ETa1G3nvDf9VIUwF8M/IlphHbF9T5V5WU JXbeZ/ULIrp1UnfF/ulEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehtddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Date: Thu, 29 Sep 2022 15:33:12 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-use rmrr= parameter handling code to handle common device reserved memory. Move MAX_USER_RMRR_PAGES limit enforcement to apply only to user-configured ranges, but not those from internal callers. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Kevin Tian --- Changes in v8: - move add_one_user_rmrr() function earlier - extend commit message Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 196 +++++++++++++++++------------- 1 file changed, 114 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 367304c8739c..78c8bad1515a 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -861,113 +861,136 @@ static struct user_rmrr __initdata user_rmrrs[MAX_USER_RMRR]; /* Macro for RMRR inclusive range formatting. */ #define ERMRRU_FMT "[%lx-%lx]" -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn +#define ERMRRU_ARG base_pfn, end_pfn -static int __init add_user_rmrr(void) +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf) { struct acpi_rmrr_unit *rmrr, *rmrru; - unsigned int idx, seg, i; - unsigned long base, end; + unsigned int idx, seg; + unsigned long base_iter; bool overlap; - for ( i = 0; i < nr_rmrr; i++ ) + if ( iommu_verbose ) + printk(XENLOG_DEBUG VTDPREFIX + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\n", + dev_count, sbdf[0], ERMRRU_ARG); + + if ( base_pfn > end_pfn ) { - base = user_rmrrs[i].base_pfn; - end = user_rmrrs[i].end_pfn; + printk(XENLOG_ERR VTDPREFIX + "Invalid RMRR Range "ERMRRU_FMT"\n", + ERMRRU_ARG); + return 0; + } - if ( base > end ) + overlap = false; + list_for_each_entry(rmrru, &acpi_rmrr_units, list) + { + if ( pfn_to_paddr(base_pfn) <= rmrru->end_address && + rmrru->base_address <= pfn_to_paddr(end_pfn) ) { printk(XENLOG_ERR VTDPREFIX - "Invalid RMRR Range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", + ERMRRU_ARG, + paddr_to_pfn(rmrru->base_address), + paddr_to_pfn(rmrru->end_address)); + overlap = true; + break; } + } + /* Don't add overlapping RMRR. */ + if ( overlap ) + return 0; - if ( (end - base) >= MAX_USER_RMRR_PAGES ) + base_iter = base_pfn; + do + { + if ( !mfn_valid(_mfn(base_iter)) ) { printk(XENLOG_ERR VTDPREFIX - "RMRR range "ERMRRU_FMT" exceeds "\ - __stringify(MAX_USER_RMRR_PAGES)" pages\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + break; } + } while ( base_iter++ < end_pfn ); - overlap = false; - list_for_each_entry(rmrru, &acpi_rmrr_units, list) - { - if ( pfn_to_paddr(base) <= rmrru->end_address && - rmrru->base_address <= pfn_to_paddr(end) ) - { - printk(XENLOG_ERR VTDPREFIX - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", - ERMRRU_ARG(user_rmrrs[i]), - paddr_to_pfn(rmrru->base_address), - paddr_to_pfn(rmrru->end_address)); - overlap = true; - break; - } - } - /* Don't add overlapping RMRR. */ - if ( overlap ) - continue; + /* Invalid pfn in range as the loop ended before end_pfn was reached. */ + if ( base_iter <= end_pfn ) + return 0; - do - { - if ( !mfn_valid(_mfn(base)) ) - { - printk(XENLOG_ERR VTDPREFIX - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - break; - } - } while ( base++ < end ); + rmrr = xzalloc(struct acpi_rmrr_unit); + if ( !rmrr ) + return -ENOMEM; - /* Invalid pfn in range as the loop ended before end_pfn was reached. */ - if ( base <= end ) - continue; + rmrr->scope.devices = xmalloc_array(u16, dev_count); + if ( !rmrr->scope.devices ) + { + xfree(rmrr); + return -ENOMEM; + } - rmrr = xzalloc(struct acpi_rmrr_unit); - if ( !rmrr ) - return -ENOMEM; + seg = 0; + for ( idx = 0; idx < dev_count; idx++ ) + { + rmrr->scope.devices[idx] = sbdf[idx]; + seg |= PCI_SEG(sbdf[idx]); + } + if ( seg != PCI_SEG(sbdf[0]) ) + { + printk(XENLOG_ERR VTDPREFIX + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + scope_devices_free(&rmrr->scope); + xfree(rmrr); + return 0; + } - rmrr->scope.devices = xmalloc_array(u16, user_rmrrs[i].dev_count); - if ( !rmrr->scope.devices ) - { - xfree(rmrr); - return -ENOMEM; - } + rmrr->segment = seg; + rmrr->base_address = pfn_to_paddr(base_pfn); + /* Align the end_address to the end of the page */ + rmrr->end_address = pfn_to_paddr(end_pfn) | ~PAGE_MASK; + rmrr->scope.devices_cnt = dev_count; - seg = 0; - for ( idx = 0; idx < user_rmrrs[i].dev_count; idx++ ) - { - rmrr->scope.devices[idx] = user_rmrrs[i].sbdf[idx]; - seg |= PCI_SEG(user_rmrrs[i].sbdf[idx]); - } - if ( seg != PCI_SEG(user_rmrrs[i].sbdf[0]) ) - { - printk(XENLOG_ERR VTDPREFIX - "Segments are not equal for RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - scope_devices_free(&rmrr->scope); - xfree(rmrr); - continue; - } + if ( register_one_rmrr(rmrr) ) + printk(XENLOG_ERR VTDPREFIX + "Could not register RMMR range "ERMRRU_FMT"\n", + ERMRRU_ARG); - rmrr->segment = seg; - rmrr->base_address = pfn_to_paddr(user_rmrrs[i].base_pfn); - /* Align the end_address to the end of the page */ - rmrr->end_address = pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAGE_MASK; - rmrr->scope.devices_cnt = user_rmrrs[i].dev_count; + return 1; +} - if ( register_one_rmrr(rmrr) ) - printk(XENLOG_ERR VTDPREFIX - "Could not register RMMR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - } +static int __init add_user_rmrr(void) +{ + unsigned int i; + int ret; + for ( i = 0; i < nr_rmrr; i++ ) + { + ret = add_one_user_rmrr(user_rmrrs[i].base_pfn, + user_rmrrs[i].end_pfn, + user_rmrrs[i].dev_count, + user_rmrrs[i].sbdf); + if ( ret < 0 ) + return ret; + } return 0; } +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) +{ + u32 sbdf_array[] = { id }; + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); +} + +static int __init add_extra_rmrr(void) +{ + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NULL); +} + #include /* ACPI tables may not be DMA protected by tboot, so use DMAR copy */ /* SINIT saved in SinitMleData in TXT heap (which is DMA protected) */ @@ -1010,7 +1033,7 @@ int __init acpi_dmar_init(void) { iommu_init_ops = &intel_iommu_init_ops; - return add_user_rmrr(); + return add_user_rmrr() || add_extra_rmrr(); } return ret; @@ -1108,6 +1131,15 @@ static int __init cf_check parse_rmrr_param(const char *str) else end = start; + if ( (end - start) >= MAX_USER_RMRR_PAGES ) + { + printk(XENLOG_ERR VTDPREFIX + "RMRR range "ERMRRU_FMT" exceeds "\ + __stringify(MAX_USER_RMRR_PAGES)" pages\n", + start, end); + return -E2BIG; + } + user_rmrrs[nr_rmrr].base_pfn = start; user_rmrrs[nr_rmrr].end_pfn = end; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:33:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413796.657703 (Exim 4.92) (envelope-from ) id 1odtfP-0006JR-PP; Thu, 29 Sep 2022 13:33:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413796.657703; Thu, 29 Sep 2022 13:33:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtfP-0006Ix-LA; Thu, 29 Sep 2022 13:33:31 +0000 Received: by outflank-mailman (input) for mailman id 413796; Thu, 29 Sep 2022 13:33:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtfO-0005tj-Tj for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:33:31 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d1eb5f4-3ffb-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 15:33:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 024475C00CF; Thu, 29 Sep 2022 09:33:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 29 Sep 2022 09:33:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 09:33:26 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d1eb5f4-3ffb-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1664458407; x=1664544807; bh=qgXc+yc9Ry MnxEvi8RZARrA6p2JmQMlq7M1cItFijWE=; b=X6O2BdtiKpBYB5bgMgn7AgtQnu ZjxFCTJhi56VsQP2un9+b/IkcNcrXEIDsUtu6RlKGHTcCUmlsvD14mZ7yGCpTnOW Lu/3w2NL+IfE4/IY9/+8ZvR+lDrGQsRQLYb7YcLFfKLLVeKNI3WFoZW5tyFPO70d h0i2cNxoTBeKPzk3/i8+XtGaVrzu2/ibc6uumo9lLRfQ/SKSzB1q/5VojGAV7NQu VBRUuSRVzB73gb6Qwyx+UK5vloq2PFXJPN9fFyMKOy59CU4qiWH77R0VHPB0dlJq Wu59cw7i3hZibjxHrb9uy439rD8a4uOmYHVExGjmDEF2jyCtHhajAAH3+7/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664458407; x= 1664544807; bh=qgXc+yc9RyMnxEvi8RZARrA6p2JmQMlq7M1cItFijWE=; b=K iSjwQ8O8Y6D6pGICQNeiOl6hlUXXxAh8w6Vm1sUGGzSjUilxovjGzjNqYKlwIflR lONxo2jxLqpn0t2cppCuiqlLRNhpqg1hMa2yjttMwBvYWCjD33azP9PbVLNXdJrY 4iz4D72Q3dMsMn/sBEA9EP9UcOYAyiCm+ituukQ1LiPph9blSvoHrJXz1Z6/Fn1H Y2ONZ3wUVsV2zJzzojiRLj646kG+U7i1JtjrtSuaZJ12IDfZfR3b0dx9zIq+vvSS YRMuyfjCdBYt4U4Rf1vOnULlsnNaKCZW6lOF6eHEIDIBRwcug4Q71ZLk/28eUFxo UMOEr1YdYYvOkvlRE20LQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehtddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v8 2/2] drivers/char: suspend handling in XHCI console driver Date: Thu, 29 Sep 2022 15:33:13 +0200 Message-Id: <5ebc3a1176fcb9f1e4852826edfe67fe62062d05.1664458360.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Similar to the EHCI driver - save/restore relevant BAR and command register, re-configure DbC on resume and stop/start timer. On resume trigger sending anything that was queued in the meantime. Save full BAR value, instead of just the address part, to ease restoring on resume. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v8: - move 'bool suspended' to other bools New in v7 Without this patch, the console is broken after S3, and in some cases the suspend doesn't succeed at all (when xhci console is enabled). Very similar (if not the same) functions might be used for coordinated reset handling. I tried to include it in this patch too, but it's a bit more involved, mostly due to share=yes case (PHYSDEVOP_dbgp_op can be called by the hardware domain only). --- xen/drivers/char/xhci-dbc.c | 55 +++++++++++++++++++++++++++++++++----- 1 file changed, 49 insertions(+), 6 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 43ed64a004e2..86f6df6bef67 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -251,14 +251,17 @@ struct dbc { struct xhci_string_descriptor *dbc_str; pci_sbdf_t sbdf; - uint64_t xhc_mmio_phys; + uint64_t bar_val; uint64_t xhc_dbc_offset; void __iomem *xhc_mmio; bool enable; /* whether dbgp=xhci was set at all */ bool open; + bool suspended; enum xhci_share share; unsigned int xhc_num; /* look for n-th xhc */ + /* state saved across suspend */ + uint16_t pci_cr; }; static void *dbc_sys_map_xhc(uint64_t phys, size_t size) @@ -358,8 +361,9 @@ static bool __init dbc_init_xhc(struct dbc *dbc) pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); - dbc->xhc_mmio_phys = (bar0 & PCI_BASE_ADDRESS_MEM_MASK) | (bar1 << 32); - dbc->xhc_mmio = dbc_sys_map_xhc(dbc->xhc_mmio_phys, xhc_mmio_size); + dbc->bar_val = bar0 | (bar1 << 32); + dbc->xhc_mmio = dbc_sys_map_xhc(dbc->bar_val & PCI_BASE_ADDRESS_MEM_MASK, + xhc_mmio_size); if ( dbc->xhc_mmio == NULL ) return false; @@ -979,6 +983,9 @@ static bool dbc_ensure_running(struct dbc *dbc) uint32_t ctrl; uint16_t cmd; + if ( dbc->suspended ) + return false; + if ( dbc->share != XHCI_SHARE_NONE ) { /* @@ -1213,9 +1220,11 @@ static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) * page, so keep it simple. */ if ( rangeset_add_range(mmio_ro_ranges, - PFN_DOWN(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset), - PFN_UP(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset + - sizeof(*uart->dbc.dbc_reg)) - 1) ) + PFN_DOWN((uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + + uart->dbc.xhc_dbc_offset), + PFN_UP((uart->dbc.bar_val & PCI_BASE_ADDRESS_MEM_MASK) + + uart->dbc.xhc_dbc_offset + + sizeof(*uart->dbc.dbc_reg)) - 1) ) printk(XENLOG_INFO "Error while adding MMIO range of device to mmio_ro_ranges\n"); #endif @@ -1255,6 +1264,38 @@ static void cf_check dbc_uart_flush(struct serial_port *port) set_timer(&uart->timer, goal); } +static void cf_check dbc_uart_suspend(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + dbc_pop_events(dbc); + stop_timer(&uart->timer); + dbc->pci_cr = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + dbc->suspended = true; +} + +static void cf_check dbc_uart_resume(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, dbc->bar_val & 0xFFFFFFFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, dbc->bar_val >> 32); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, dbc->pci_cr); + + if ( !dbc_init_dbc(dbc) ) + { + dbc_error("resume failed\n"); + return; + } + + dbc_enable_dbc(dbc); + dbc->suspended = false; + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); +} + static struct uart_driver dbc_uart_driver = { .init_preirq = dbc_uart_init_preirq, .init_postirq = dbc_uart_init_postirq, @@ -1262,6 +1303,8 @@ static struct uart_driver dbc_uart_driver = { .putc = dbc_uart_putc, .getc = dbc_uart_getc, .flush = dbc_uart_flush, + .suspend = dbc_uart_suspend, + .resume = dbc_uart_resume, }; /* Those are accessed via DMA. */ -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 29 13:33:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 13:33:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413797.657714 (Exim 4.92) (envelope-from ) id 1odtfR-0006af-0U; Thu, 29 Sep 2022 13:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413797.657714; Thu, 29 Sep 2022 13:33:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtfQ-0006aU-T8; Thu, 29 Sep 2022 13:33:32 +0000 Received: by outflank-mailman (input) for mailman id 413797; Thu, 29 Sep 2022 13:33:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odtfP-0005tj-U0 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 13:33:32 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bb8058c-3ffb-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 15:33:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8033C5C0178; Thu, 29 Sep 2022 09:33:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 29 Sep 2022 09:33:25 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 09:33:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bb8058c-3ffb-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664458405; x=1664544805; bh=lGhOS0ndxVwarjq2rY27WoL7WTl8n59n9cj /5HY9Z1o=; b=QQSD+yp65nFxY3MUHhLBrv3wiXopCJ8BhD5soRg8zQgethPmNSA HWwBKMB5IfBZGM9V3ccC7hcVxgiYZ2uEOmUz3DsMifMbzhNptqbHqTH4d5JeyzXM a0wBND0Kv7tORNIHiYpi3LMSYo+P5u82Pgrk3W0AVFJp0eVCtQMDZdUMg3NywHqz BPQwF+GYagPQ9zWZ14ti7gCPo20nXcsAg08lknxZnGZO4RB7rAO/GFs7cwj4xvQx SdmrVRQt0oRpl8rvHtjAf8PGMumZs/gRdoafVEzTDuu8qW48cM2+mByQp/RihHSh pTlrKZ7ttYVBIS5y4M/Hpi5ttkkvBLfO37w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664458405; x=1664544805; bh=lGhOS0ndxVwar jq2rY27WoL7WTl8n59n9cj/5HY9Z1o=; b=mEsBP4usaqa1WAEHl5TDfMOXkzQb3 JEs8nByKn3UnGv2xpVSqFJ+pio15MOyitAiFYLWTe+AMLkelrtiH2wJndOC6mhrh v0rZkIbb//eJBIz1BgyVekN5M3aHhNaRUs4ea+WY+wmDZNrFjISu1LyW8J3rsVQI hU4MCavcpvsQi/gtVffraEe7ubN0hQX5HQ+fb8yF0imZnVpR7dhumqPSfQxk+Ork p+4c2XNighWN810rJ72QNpqRKCEyn2g4dxGDg9ArkJUn21EID3viWRsOxPYuCn5S /sLZA8GZuKwVU6sdIxtZWUazupXQ5KZC6fCLY0Uk9Cuf95PGPYVPppC5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehtddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefgffg geevhffggfetfefhffeuvefhvdevkeehkedttddtgeefkeduheevffduleenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Paul Durrant , Kevin Tian , Connor Davis Subject: [PATCH v8 0/2] Add Xue - console over USB 3 Debug Capability Date: Thu, 29 Sep 2022 15:33:11 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports console via USB3 debug capability. The capability is designed to operate mostly independently of normal XHCI driver, so this patch series allows dom0 to drive standard USB3 controller part, while Xen uses DbC for console output. Changes since RFC: - move the driver to xue.c, remove non-Xen parts, remove now unneeded abstraction - adjust for Xen code style - build for x86 only - drop patch hidding the device from dom0 Changes since v1: - drop ehci patch - already applied - adjust for review comments from Jan (see changelogs in individual patches) Changes since v2: - add runtime option to share (or not) the controller with dom0 or other domains - add RX support - several smaller changes according to review comments Changes since v3: - put controller sharing behind experimental kconfig option - several other changes according to review comments Changes since v4: - drop first 4 patches - already applied to staging - split dbgp=xhci into dbc=xhci Changes since v5: - roll dbc=xhci back into dbgp=xhci, but make it work together with dbgp=ehci Changes since v6: - reorder patches - put acked ones early (I've put acked IOMMU ones early too, even without VT-d, because they do make it work on AMD, and it's kind of required to get the console work with IOMMU enabled) - drop barriers patch (at least for now) - new patches for suspend support and console=ehci alias Changes since v7: - drop commited already patches - drop "onsole: support multiple serial console simultaneously" as there is no interest in including it - adjust VT-d patch according to Kevin's request Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Paul Durrant Cc: Kevin Tian Cc: Connor Davis Marek Marczykowski-Górecki (2): IOMMU/VT-d: wire common device reserved memory API drivers/char: suspend handling in XHCI console driver xen/drivers/char/xhci-dbc.c | 55 +++++++- xen/drivers/passthrough/vtd/dmar.c | 196 +++++++++++++++++------------- 2 files changed, 163 insertions(+), 88 deletions(-) base-commit: b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 29 14:29:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 14:29:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413820.657725 (Exim 4.92) (envelope-from ) id 1oduX9-0004hi-5j; Thu, 29 Sep 2022 14:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413820.657725; Thu, 29 Sep 2022 14:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oduX9-0004hb-2h; Thu, 29 Sep 2022 14:29:03 +0000 Received: by outflank-mailman (input) for mailman id 413820; Thu, 29 Sep 2022 14:29:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oduX7-0004hU-0Q for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 14:29:01 +0000 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [2607:f8b0:4864:20::b2c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d8cbe33-4003-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 16:28:58 +0200 (CEST) Received: by mail-yb1-xb2c.google.com with SMTP id e145so1734228yba.11 for ; Thu, 29 Sep 2022 07:28:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d8cbe33-4003-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=2XJDa8DBA7HGi039FsBbQeQ2BhJjxhBLQe2Bio1+Kqc=; b=GWwRNwX/Z6et92Ckt7fyGExyf0V+SQ2iyhdgEGUEZ7X3yFUMx04bydYTgl8xyVPaOs KE91zVfK/LKrVPmA1JTTv0oH/lJ1lEdjr+nuML4hzjUIL9F2UfaXWqTKOhSAkrP3ETYN nsnbgKYjqaIu3EknSkNqiZOBTfTIbCkx/re8FpBcRUoiEJcQVslmkEyRaIF0qySpOUOS IS5Vcmc59BSXMzJjbwVqOb/Z5Ll1w3e90hD/oqAmxucp9Xyts4hOHOpkC/kNFL8/9aqD ChJAZOULj5SxdrkafgPgRRChtPpelYgS+E2b1IHglFSBkq16EGWCqGb152pHqkJxtOfP cWSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2XJDa8DBA7HGi039FsBbQeQ2BhJjxhBLQe2Bio1+Kqc=; b=6XGO9t3fx13OTew4i+arfEQUmn08yBRE2khSPpCcvngGYxellHm5JdgJBoW+zyVNWz WW4d9LLR92JS+R2BEy1hwrUEdcSsTo5cECrJsuR6QZcUH1cK+eau5pjr+ANPK4d3kV/e Gl5HhT1ZTtV2MV5IeLZzy++qojthecrFUo4gkTMEZJsy4+4EpacJALtDebfQr63k3/FQ vLNlt5mxSmkeez9cKcUZ39XO91pVm4d5vfqX44RYs2djegPB1bN8H8sbJMGpL2GpUNDU 97LtT+k1pQOoFvHAJj0B6M6e8t7xuia2hv5jdAlSzEaKrRjKV5dffnLaL/PGUzSB4Blx 7e7w== X-Gm-Message-State: ACrzQf3OlNxEG6R9rDQ0ydgCOXaE0uqXWA3fbvYvrpB6NwwhhjnivUAm t4QzhZB/6FXPYEywjl1GnUJeTiKNhDci8lxBjbQ= X-Google-Smtp-Source: AMsMyM7CQ0lLy3HueYb2zHtqVG1+8vLYuqtefellxhA1KylXQJiOD+w43PJfsMhqOpZ0vNDmrixuLJKuGdtT5quEqxE= X-Received: by 2002:a25:2597:0:b0:6bc:c8a4:77bf with SMTP id l145-20020a252597000000b006bcc8a477bfmr1962740ybl.213.1664461736975; Thu, 29 Sep 2022 07:28:56 -0700 (PDT) MIME-Version: 1.0 References: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> <7a469ef7-5ad7-5abf-2c1f-fa29496fa2a5@suse.com> <1e9f75e3-c59c-e3a4-f26d-59a440d366aa@suse.com> In-Reply-To: <1e9f75e3-c59c-e3a4-f26d-59a440d366aa@suse.com> From: Tamas K Lengyel Date: Thu, 29 Sep 2022 10:28:20 -0400 Message-ID: Subject: Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load To: Jan Beulich Cc: Tamas K Lengyel , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Boris Ostrovsky Content-Type: multipart/alternative; boundary="0000000000009322e705e9d1b299" --0000000000009322e705e9d1b299 Content-Type: text/plain; charset="UTF-8" On Thu, Sep 29, 2022 at 9:07 AM Jan Beulich wrote: > On 26.09.2022 16:22, Tamas K Lengyel wrote: > > On Mon, Sep 26, 2022 at 10:12 AM Jan Beulich wrote: > >> On 22.09.2022 22:48, Tamas K Lengyel wrote: > >>> --- a/xen/arch/x86/cpu/vpmu.c > >>> +++ b/xen/arch/x86/cpu/vpmu.c > >>> @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) > >>> vpmu->last_pcpu = pcpu; > >>> per_cpu(last_vcpu, pcpu) = v; > >>> > >>> + vpmu_set(vpmu, VPMU_CONTEXT_SAVE); > >>> + > >>> if ( alternative_call(vpmu_ops.arch_vpmu_save, v, 0) ) > >>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > >>> > >>> + vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); > >>> + > >>> apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); > >>> } > >>> > >>> int vpmu_load(struct vcpu *v, bool_t from_guest) > >>> { > >>> struct vpmu_struct *vpmu = vcpu_vpmu(v); > >>> - int pcpu = smp_processor_id(), ret; > >>> - struct vcpu *prev = NULL; > >>> + int ret; > >>> > >>> if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) > >>> return 0; > >>> > >>> - /* First time this VCPU is running here */ > >>> - if ( vpmu->last_pcpu != pcpu ) > >>> - { > >>> - /* > >>> - * Get the context from last pcpu that we ran on. Note that if > >> another > >>> - * VCPU is running there it must have saved this VPCU's > context > >> before > >>> - * startig to run (see below). > >>> - * There should be no race since remote pcpu will disable > >> interrupts > >>> - * before saving the context. > >>> - */ > >>> - if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) > >>> - { > >>> - on_selected_cpus(cpumask_of(vpmu->last_pcpu), > >>> - vpmu_save_force, (void *)v, 1); > >>> - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > >>> - } > >>> - } > >>> - > >>> - /* Prevent forced context save from remote CPU */ > >>> - local_irq_disable(); > >>> - > >>> - prev = per_cpu(last_vcpu, pcpu); > >>> - > >>> - if ( prev != v && prev ) > >>> - { > >>> - vpmu = vcpu_vpmu(prev); > >>> - > >>> - /* Someone ran here before us */ > >>> - vpmu_save_force(prev); > >>> - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); > >>> - > >>> - vpmu = vcpu_vpmu(v); > >>> - } > >>> - > >>> - local_irq_enable(); > >>> - > >>> /* Only when PMU is counting, we load PMU context immediately. */ > >>> if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || > >>> (!has_vlapic(vpmu_vcpu(vpmu)->domain) && > >> > >> What about the other two uses of vpmu_save_force() in this file? I looks > >> to me as if only the use in mem_sharing.c needs to be retained. > > > > I don't know, maybe. I rather focus this patch only on the issue and its > > fix as I don't want to introduce unintended side effects by doing a > > cleanup/consolidation at other code-paths when not strictly necessary. > > While I see your point, I'm afraid I don't think I can ack this > change without knowing whether the other uses don't expose a similar > issue. It would feel wrong to fix only one half of a problem. I may, > somewhat hesitantly, give an ack if e.g. Boris offered his R-b. > Else the only other option I see is that some other maintainer give > their ack. > I may have misunderstood what you are asking. I thought you were asking if the other two remaining users of vpmu_save_force could be switched over to vpmu_save as a generic cleanup, to which my answer is still maybe. From the perspective of this particular bug those use-cases are safe. On is acting on the current vcpu and doesn't try to run vpmu_save_force on a remote vcpu, the other one is being called when the domain is being shut down so the vcpu cannot be in a runnable state. Tamas --0000000000009322e705e9d1b299 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 29, 2022 at 9:07 AM Jan B= eulich <jbeulich@suse.com> w= rote:
On 26.09.2= 022 16:22, Tamas K Lengyel wrote:
> On Mon, Sep 26, 2022 at 10:12 AM Jan Beulich <jbeulich@suse.com> wrote:
>> On 22.09.2022 22:48, Tamas K Lengyel wrote:
>>> --- a/xen/arch/x86/cpu/vpmu.c
>>> +++ b/xen/arch/x86/cpu/vpmu.c
>>> @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v)
>>>=C2=A0 =C2=A0 =C2=A0 vpmu->last_pcpu =3D pcpu;
>>>=C2=A0 =C2=A0 =C2=A0 per_cpu(last_vcpu, pcpu) =3D v;
>>>
>>> +=C2=A0 =C2=A0 vpmu_set(vpmu, VPMU_CONTEXT_SAVE);
>>> +
>>>=C2=A0 =C2=A0 =C2=A0 if ( alternative_call(vpmu_ops.arch_vpmu_s= ave, v, 0) )
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTEX= T_LOADED);
>>>
>>> +=C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTEXT_SAVE);
>>> +
>>>=C2=A0 =C2=A0 =C2=A0 apic_write(APIC_LVTPC, PMU_APIC_VECTOR | A= PIC_LVT_MASKED);
>>>=C2=A0 }
>>>
>>>=C2=A0 int vpmu_load(struct vcpu *v, bool_t from_guest)
>>>=C2=A0 {
>>>=C2=A0 =C2=A0 =C2=A0 struct vpmu_struct *vpmu =3D vcpu_vpmu(v);=
>>> -=C2=A0 =C2=A0 int pcpu =3D smp_processor_id(), ret;
>>> -=C2=A0 =C2=A0 struct vcpu *prev =3D NULL;
>>> +=C2=A0 =C2=A0 int ret;
>>>
>>>=C2=A0 =C2=A0 =C2=A0 if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOC= ATED) )
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return 0;
>>>
>>> -=C2=A0 =C2=A0 /* First time this VCPU is running here */
>>> -=C2=A0 =C2=A0 if ( vpmu->last_pcpu !=3D pcpu )
>>> -=C2=A0 =C2=A0 {
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 /*
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* Get the context from last= pcpu that we ran on. Note that if
>> another
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* VCPU is running there it = must have saved this VPCU's context
>> before
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* startig to run (see below= ).
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* There should be no race s= ince remote pcpu will disable
>> interrupts
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* before saving the context= .
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( vpmu_is_set(vpmu, VPMU_CONTE= XT_LOADED) )
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 {
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 on_selected_cpus(cp= umask_of(vpmu->last_pcpu),
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpmu_save_force, (void *)v, 1)= ;
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_reset(vpmu, VP= MU_CONTEXT_LOADED);
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>>> -=C2=A0 =C2=A0 }
>>> -
>>> -=C2=A0 =C2=A0 /* Prevent forced context save from remote CPU = */
>>> -=C2=A0 =C2=A0 local_irq_disable();
>>> -
>>> -=C2=A0 =C2=A0 prev =3D per_cpu(last_vcpu, pcpu);
>>> -
>>> -=C2=A0 =C2=A0 if ( prev !=3D v && prev )
>>> -=C2=A0 =C2=A0 {
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu =3D vcpu_vpmu(prev);
>>> -
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Someone ran here before us */<= br> >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_save_force(prev);
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu_reset(vpmu, VPMU_CONTEXT_LOA= DED);
>>> -
>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 vpmu =3D vcpu_vpmu(v);
>>> -=C2=A0 =C2=A0 }
>>> -
>>> -=C2=A0 =C2=A0 local_irq_enable();
>>> -
>>>=C2=A0 =C2=A0 =C2=A0 /* Only when PMU is counting, we load PMU = context immediately. */
>>>=C2=A0 =C2=A0 =C2=A0 if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(!has_vlapic(vpmu_vcpu= (vpmu)->domain) &&
>>
>> What about the other two uses of vpmu_save_force() in this file? I= looks
>> to me as if only the use in mem_sharing.c needs to be retained. >
> I don't know, maybe. I rather focus this patch only on the issue a= nd its
> fix as I don't want to introduce unintended side effects by doing = a
> cleanup/consolidation at other code-paths when not strictly necessary.=

While I see your point, I'm afraid I don't think I can ack this
change without knowing whether the other uses don't expose a similar issue. It would feel wrong to fix only one half of a problem. I may,
somewhat hesitantly, give an ack if e.g. Boris offered his R-b.
Else the only other option I see is that some other maintainer give
their ack.

I may have misunderstood wha= t you are asking. I thought you were asking if the other two remaining user= s of vpmu_save_force could be switched over to vpmu_save as a generic clean= up, to which my answer is still maybe. From the perspective of this particu= lar bug those use-cases are safe. On is acting on the current vcpu and does= n't try to run vpmu_save_force on a remote vcpu, the other one is being= called when the domain is being shut down so the vcpu cannot be in a runna= ble state.

Tamas
--0000000000009322e705e9d1b299-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 14:46:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 14:46:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413825.657735 (Exim 4.92) (envelope-from ) id 1oduoF-0007Cm-In; Thu, 29 Sep 2022 14:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413825.657735; Thu, 29 Sep 2022 14:46:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oduoF-0007Cf-GB; Thu, 29 Sep 2022 14:46:43 +0000 Received: by outflank-mailman (input) for mailman id 413825; Thu, 29 Sep 2022 14:46:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oduoE-0007CZ-6D for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 14:46:42 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 873f4adc-4005-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 16:46:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8753.eurprd04.prod.outlook.com (2603:10a6:20b:42c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 14:46:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 14:46:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 873f4adc-4005-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TsEruHbi4XeZVVhxGWzAZFXmu7HScyErAl+KylPl2f/09DoVFHSFEWDBVGncrKeprfbY7n6OuAegc+8HVIE5AvQ+3VGf2tLj+Kj7pDR956EaocINwPKh4wwYcAk+Odb7xE5GXDbMzjnG8k7J+8Ng9l1xnvbEqIGHN8NVMWzKiJDTlakeybntbq2oYKNO/fiocuHhzRnTeoT9hxlhJb2/uv68WWBDFbO5aA1/lvApc8HfNKUOCk3x+QSrbm0ntsiRJ1WSHPjdcMmkBomWvopZ53zaeTGI6E5PgSL8lQ4Ej2U1XuzrajS2sF5B7ulwHZc3q/blh5SMIS4uVlkcgtb01A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=opqA64Q+nuXWr4AFVA5z2MJl0UtnOwe+MyWlPkxBOEw=; b=JaTnEBFdpuzvj3nMvR8a2pS05tgOHOZuBT9WmsCaqToiZ1i6r+/FkR4UGwcbn8GKWuCkfsBWHBNCebIJN4BBf/QL6fo5t9qfQdKP873lxqecmYu8N1ZTXckeqbtnRmI2D5GnYDgWWXzUZ10bnqwuwLygkZ3IFFBFKxNiWN3O7Qyj46Ll630rgjqjHaP6eEpFgIk9DThsO0DZ1VTNaOtxvEcLqQETh8ArwYw1fLHf9iBWrgtIvhv6ufF/ZhsMrhhyRidbMFwWILStUkxagqcOCZUa88x4gqXzjn+K8MkPdAIxfI4PDw2Rjnj0brgL33cTChqMClRs9YhGynRv7Z4O8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=opqA64Q+nuXWr4AFVA5z2MJl0UtnOwe+MyWlPkxBOEw=; b=HhW0GsFLRuTddAggDlAOaCrvn4wsYuedPaNU9/DFFtVFSX0ZJ+xe7IevT9Pr1uVUrZ9MpKtZaivgVkvjXJudBOKoJFS5XkPqGW/oR3Rm+TgdlZN+0cbxq2z7ovbld+Ig+vdZubeFoD0lglKIj6Uqf6+bAQ7b08ytY9nDjh+axT3Lua2rLrtH00z7vc4ZEHYQb4StID/iUmqSByxm58cQ2iofL4kDpgnGOJtDnKOWiWij7EAYNnkR/zHXY0YdTwjHkAYU31hG4fsBwOZhN8H5F434Ns04boEurBhnoXwn6H2WNkFBeoQE/tip1guQG871Wf2D1HdbDuNUpZWwZWtyew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <38f7cc1c-59ed-dead-8623-2eabcae4607e@suse.com> Date: Thu, 29 Sep 2022 16:46:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load Content-Language: en-US To: Tamas K Lengyel Cc: Tamas K Lengyel , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Boris Ostrovsky References: <86f8a095ff18e4dc41ecb9cef5153438158b91ce.1663878942.git.tamas.lengyel@intel.com> <7a469ef7-5ad7-5abf-2c1f-fa29496fa2a5@suse.com> <1e9f75e3-c59c-e3a4-f26d-59a440d366aa@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8753:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a693a8e-c6a7-427a-1ecf-08daa22969f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vj/BPdhT+FJMs1nEmneh92HGEyvfvawdDKGNUuvLD2CVhL5CJFPX5JDLNhXDt1EcIcH38LXKhmqNWY/BtsMYN9ECRy3Dt9ZkyaS9d7OpijjctjxERBw3J3UL+DORtZ29yaYi9A5tF1FIv6dva6KV9TfMaoyItnDTUWrvo7bpmYJU1Xe5gpwHqYrSpjLoZURovI8+iuS10iq5QLOt9ftIicMBjZ7iZppVs2jQfdv9RYW9qxd/Uj3UYKpfARdPcGyd96GXc1xyFD3SUIAJr7gsipGGGHZYXfpd2LHMVft8U2Nied3kwnzczrBpplGATT+y+2NM2vkYZ8mWuPA1CmU6EYo7YKfbBB5w3Rm9LGHp4hyNFT8plUKyF/XRpm28AUx+JfOpVxUeMLEHanWYn3a5VhOYlik/j+/9vBqfEb5K08iu15Yd/F862u/JgR3NMLSi5DRwvBWspK6BuSdwkRz2hgWhmhwsTAFTVSQwxsOoDh+mdxcsmOF129ivl1OnnqPG9G8JXCkqxkGpGMYr/EcQCuB3SBsZV5ezQjV5JG52itKGrDClgCrIHpXjP4zgKect7STtWRjbrQw5tNoXJ24p4ryoahctsVIM5z7CFRLpduVamxZCWiqHtwBlu11Q59/metiGhO2tne/6MDotZgsHl1xSm2V7N15Mo655RKXrUHvq+kGNDkX19i7cqMYOIVt8ROT2LCwmvjdnOwZlHhHABFvfOdlizYmq48VChLL7KMMnCNK65fRvD8sIcI1dXXJa3vFoQrF9zJuYraDop3iP9wL5aNmOwnBjJJcAmyy0Ji4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(396003)(376002)(366004)(136003)(451199015)(6486002)(478600001)(31686004)(53546011)(66899015)(6506007)(8936002)(316002)(2616005)(54906003)(2906002)(6916009)(38100700002)(66556008)(26005)(6512007)(36756003)(83380400001)(41300700001)(8676002)(4326008)(66946007)(86362001)(31696002)(5660300002)(66476007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUdWTERXdFpzQmxReEJoTHFjd3NjNERtalJ2QzR2bnlrU0N5VzlUWndhcDBD?= =?utf-8?B?RE1QUSsyRExOOFJIeFovWmpMdlpHTHB0b0tObXNHYjJKVWtCa3UvdUpEa0NX?= =?utf-8?B?NnFkOWYyRVJhTEhSMVhMNERydVU2V001MXRLVG5SOGdYck5lbVZHK0pRS2tl?= =?utf-8?B?UGxSNjdBQllDNTlBVmdZZ3FnU2lxMlEva2ZubUJXOVAybjI2aGZvcnlVOG5T?= =?utf-8?B?OWZJRnkrREEvdzBhdTgxdHZnNndOWGc0c0syZXJaU1pzRnd5UlRNcm11TXdF?= =?utf-8?B?SEhPMWFFYmxNT2FGNjVGK0Y2V2tqS1dyRkZEWTNzZ1kyaDNtbGNaR2dUL0cy?= =?utf-8?B?YUZKdzNQMmxVbC8xVmtZYVJIQ3kyVVlreHZqemc4Z1g2MFlnYUNZSWN6REpB?= =?utf-8?B?Q3BQdW93T1pOZEtycWIzV0JWb2gvL1BON2p0NHpRcTc0NUNRM2I4eXErL3c0?= =?utf-8?B?ZDdmamx3ZHFNVnVNMU5OZnBLRDR3SE9raExIejBzRzRjaFgwR3VHV2w2aEFi?= =?utf-8?B?ZjlIZU9pL3gvSXRqcmFmSkQrR2ZCL0tjcy9PT0NZZFhqWFgrMitaNkRyVEIx?= =?utf-8?B?SnVkb05ISmQyMm5lejMvQlhqQU53cTFNRUxZYVZnQU95ZU1GcEg1TFhNMVoz?= =?utf-8?B?azNtUDZiOUlBZG1kVkJPNGQ3QXpnZjg0VlAyY2JSUG1BQmNhalBjbnVMMXpw?= =?utf-8?B?RWRIdEFxcVEyZjZsQnhRdDBTWUpQSjJuN3g2THgrZnJodjF6djFaQUorUVoz?= =?utf-8?B?WHU0eHBPVGlNY0tUV1Fxb29MbDU4SWFLTTFHNUtlc2swQVVoVFFSd3NQNVJ4?= =?utf-8?B?UDJBZG03RlZTTlR5a0l3cmpkQ2NmV1pkeDNQSzJwR1AzMDAwK2p0Q3AySmwr?= =?utf-8?B?OTlraTgraGZJRStrYkZWT2tDS2Q0aEhxVHJTTU9FenhScnhudWRZUi9mbXJ6?= =?utf-8?B?ci9TZk5GUUp1WG5UejhWVlR4YXozZnpzMkRQV2lOOHZUMk1rQlZ6OVo0b2kw?= =?utf-8?B?MFlMM3ZWaEhDTGgxeGhjZjZXVU1qTFVNNURoa1NqeDFwYWd5VXp5RFp2Q0Vj?= =?utf-8?B?dGE2MDlWdEZDTjJqOVJRMXppNVJISWJ2ZnJwKzBZSkQwT2JlNmN6YTlIeW9M?= =?utf-8?B?MVJUc21rMG0zazVCckMzWm91T0hUU09zbFUyekZhTzVSaklQWmhmNnlaUWR5?= =?utf-8?B?QzNVS0pZUkU4ZjNLVlE3eGxoSi84a2hqaFdjL1dZL0tTNXI2NXNvWWtWUjRv?= =?utf-8?B?NnMrL3U5VWJjcU12QVBsYmlTMjBlSmlKY1ZrNm9OWmFHK3d6NGlmckplZVRy?= =?utf-8?B?WjZIbGJYdCs0VzVtU0w5WlZTazU5b1puMm1IMytnUDJnZ0JMOThXeDJ4Zk42?= =?utf-8?B?LzN5RmRsMmZNbjArNGM2aGVlOVdFa1ZxNzBjTDNWdmN5U1ZrYTZpQ1N1b05Y?= =?utf-8?B?Z2UzQm8xa0tmN2prMG50OHJrdGRJV3pnVXJFSWs1dk9Pd3k2UVZzWFNjbk1W?= =?utf-8?B?bDgzS2E4L3FkSDlmNTAzbHJlQitnTmpVMm4rZmFCcmFWM3NmdXdyTXRxbkoy?= =?utf-8?B?MjNBWEZwa0hHaS9NRHZXSTJXUU1FZ1hZZEdkcHhrb0MyV1ZPN0pQVllzL3FG?= =?utf-8?B?V2Uzb2xybEs3d0RqZm5SMCtGZFMxYSt5eVJDdTZOdkNRaHJhRzZQYWtJVGd5?= =?utf-8?B?QTVGTVIwaDlESVA2U1J4RGE2dmwwRjZIeVNmRmxJc3pOczdtcm0xdXBJWUIr?= =?utf-8?B?ZVVDVVkxQUN3YVl3Qkk3WldDeTI5am9JcVYyTEFxTG1nbytoMEQxNkl0bDZz?= =?utf-8?B?Wk4rak9ndWczdmJnVUE1UGNLNnVkcTBSTmowYytGdFNWRE4wVUJJRTBBa0pY?= =?utf-8?B?dnJWMFllN2oxRGpSMzBZUEZmMFZUc1RWQ1ArYlk4WUgxeGtHNmwyS1M4VHFH?= =?utf-8?B?TXVXdWQ4eldRdUpHTW9IRElwYXhhZFdzTWVISHAvRE5hTHJuZDRQaHllRWcr?= =?utf-8?B?Ryt0VWRNRkNTbGh2b2l5SXg4Z0Y0UVpWNHBJRWp4a3RUKzFnNTh4a3ZHODdS?= =?utf-8?B?TEExNnFNSy9KS0gzdktRbmlMYW94MDB5VStkcXFQbkpabFBnemlUdG9velg1?= =?utf-8?Q?io30QQiLprkv0JXoT10H25Chi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a693a8e-c6a7-427a-1ecf-08daa22969f4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 14:46:38.3967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2a6ke1cu+dYMemWaub1T8UMFonLdyhDUGlhXrWExXWRs01YcOeSSkH4INd/pgo4u6QNKHkg1VgtRzx5VViMBtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8753 On 29.09.2022 16:28, Tamas K Lengyel wrote: > On Thu, Sep 29, 2022 at 9:07 AM Jan Beulich wrote: > >> On 26.09.2022 16:22, Tamas K Lengyel wrote: >>> On Mon, Sep 26, 2022 at 10:12 AM Jan Beulich wrote: >>>> On 22.09.2022 22:48, Tamas K Lengyel wrote: >>>>> --- a/xen/arch/x86/cpu/vpmu.c >>>>> +++ b/xen/arch/x86/cpu/vpmu.c >>>>> @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) >>>>> vpmu->last_pcpu = pcpu; >>>>> per_cpu(last_vcpu, pcpu) = v; >>>>> >>>>> + vpmu_set(vpmu, VPMU_CONTEXT_SAVE); >>>>> + >>>>> if ( alternative_call(vpmu_ops.arch_vpmu_save, v, 0) ) >>>>> vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>> >>>>> + vpmu_reset(vpmu, VPMU_CONTEXT_SAVE); >>>>> + >>>>> apic_write(APIC_LVTPC, PMU_APIC_VECTOR | APIC_LVT_MASKED); >>>>> } >>>>> >>>>> int vpmu_load(struct vcpu *v, bool_t from_guest) >>>>> { >>>>> struct vpmu_struct *vpmu = vcpu_vpmu(v); >>>>> - int pcpu = smp_processor_id(), ret; >>>>> - struct vcpu *prev = NULL; >>>>> + int ret; >>>>> >>>>> if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) >>>>> return 0; >>>>> >>>>> - /* First time this VCPU is running here */ >>>>> - if ( vpmu->last_pcpu != pcpu ) >>>>> - { >>>>> - /* >>>>> - * Get the context from last pcpu that we ran on. Note that if >>>> another >>>>> - * VCPU is running there it must have saved this VPCU's >> context >>>> before >>>>> - * startig to run (see below). >>>>> - * There should be no race since remote pcpu will disable >>>> interrupts >>>>> - * before saving the context. >>>>> - */ >>>>> - if ( vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) >>>>> - { >>>>> - on_selected_cpus(cpumask_of(vpmu->last_pcpu), >>>>> - vpmu_save_force, (void *)v, 1); >>>>> - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>> - } >>>>> - } >>>>> - >>>>> - /* Prevent forced context save from remote CPU */ >>>>> - local_irq_disable(); >>>>> - >>>>> - prev = per_cpu(last_vcpu, pcpu); >>>>> - >>>>> - if ( prev != v && prev ) >>>>> - { >>>>> - vpmu = vcpu_vpmu(prev); >>>>> - >>>>> - /* Someone ran here before us */ >>>>> - vpmu_save_force(prev); >>>>> - vpmu_reset(vpmu, VPMU_CONTEXT_LOADED); >>>>> - >>>>> - vpmu = vcpu_vpmu(v); >>>>> - } >>>>> - >>>>> - local_irq_enable(); >>>>> - >>>>> /* Only when PMU is counting, we load PMU context immediately. */ >>>>> if ( !vpmu_is_set(vpmu, VPMU_RUNNING) || >>>>> (!has_vlapic(vpmu_vcpu(vpmu)->domain) && >>>> >>>> What about the other two uses of vpmu_save_force() in this file? I looks >>>> to me as if only the use in mem_sharing.c needs to be retained. >>> >>> I don't know, maybe. I rather focus this patch only on the issue and its >>> fix as I don't want to introduce unintended side effects by doing a >>> cleanup/consolidation at other code-paths when not strictly necessary. >> >> While I see your point, I'm afraid I don't think I can ack this >> change without knowing whether the other uses don't expose a similar >> issue. It would feel wrong to fix only one half of a problem. I may, >> somewhat hesitantly, give an ack if e.g. Boris offered his R-b. >> Else the only other option I see is that some other maintainer give >> their ack. >> > > I may have misunderstood what you are asking. I thought you were asking if > the other two remaining users of vpmu_save_force could be switched over to > vpmu_save as a generic cleanup, to which my answer is still maybe. From the > perspective of this particular bug those use-cases are safe. On is acting > on the current vcpu and doesn't try to run vpmu_save_force on a remote > vcpu, the other one is being called when the domain is being shut down so > the vcpu cannot be in a runnable state. Hmm, yes - I can accept that. Thanks for the clarification. Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 14:57:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 14:57:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413837.657756 (Exim 4.92) (envelope-from ) id 1oduys-0000Wu-ON; Thu, 29 Sep 2022 14:57:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413837.657756; Thu, 29 Sep 2022 14:57:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oduys-0000Wn-Ka; Thu, 29 Sep 2022 14:57:42 +0000 Received: by outflank-mailman (input) for mailman id 413837; Thu, 29 Sep 2022 14:57:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oduyr-0000Wh-OH for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 14:57:41 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f00bdcf-4007-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 16:57:39 +0200 (CEST) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Sep 2022 10:57:26 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5679.namprd03.prod.outlook.com (2603:10b6:a03:2db::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 14:57:25 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Thu, 29 Sep 2022 14:57:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f00bdcf-4007-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664463459; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9z4YDhr3dQB+hc/d1y800HmTu/KFahLn3u0qMIcv90Q=; b=hYdO3v3XnaDoqu45N+WQlb7aDXSbnFZAEhBCsC5uGYT+vY9A5S5EzDeh G1WJBLzOuUwhCPC/XrRssCqny1iRH5K7Yq0DIJqBmEHUxXtT8lDt7OQOs HzYe+JKjN8MZOTN/deOGR+judEN8b17aC++bFVhmEimcW6EzX5+qU5lhf 8=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 80757216 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2VW29KvlDRvNFsOYZjouQkJwMufnVE1fMUV32f8akzHdYApBsoF/q tZmKT2POKncNmHyKdFzb4ji90sA75HQx9cxSQE6+C5hEiwX+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI01BjOkGlA5AZmNKoa5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkR+ dICdSg9Xiq7pOecy6zgZtZvos0KeZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpj9ABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+Xwn6kAttMfFG+3t83owHUmlMcMz8Pdl2e+tnhu1GXR+sKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9KGYDYWoISFUD6ty6+IUr1EuXEZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:zv8IJK6aI6ayAD6eJQPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.93,355,1654574400"; d="scan'208";a="80757216" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jh3zgQU1UGG7Ueb2dPn/hoFRSLSuCw0APxOFdLbKzUb4SsX6ny1e/n4BnINEt3w1ya6L/Igfyw+Eo/NfB/4pcizKWRcNASJ01raAU8NZChbCA5BX521ds9EyC7umIr2lvcR7ndkB3097yfj0yQ3/YJ+NH3NgV0XjNopTSBtwgxXKVXB301zuDcJT0FGpVubkyMebW6shcozKQ4sG5NujEWeBsqUpyehKmfqxtl4vU+BOlxNQ7u70gy0U9xFAYdoAv+/Jn+SI5IffekG0oTZiC7SnOntE41obplKenNZIV0Ti/ai9O6gUg8ZFpPk3GUWFqOt8Rq97Lma8ySH2fvmk3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZVQOwU8zTN9mB4zbEtBGlzQz2eWfvIeCIwyb0JHS7Ic=; b=BbEFJUCehlDsS2pkRlL2G7/QHjZYA0cCNXQVXIGviSvGXneTn1zwstR82Yfk37Xn7bOF25ua3MmZ/Uga7WvbRvvKTi/ViMPzJwr60TI6J7tFhzVtyO8Qoz5WiWZySiqftbJ6x2meHIDNnnn+YQBhxARAXlhOTssfMskbQcnhG1yD+igGdnLo8i5NQdgkO8qQnQnWI1+52jvQsaYDW6stu38a+oh3GNrxcour1LVzT9Si2hfg5K31ZrtSx0ZTSr7vAutGvbRhtesZ5QfBW9peJ5rSQ/2h7kip6Uxzai2UI11+laYU+5YnFLTySkd49YTeJmSmOlvi6enxqNQmAweRfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZVQOwU8zTN9mB4zbEtBGlzQz2eWfvIeCIwyb0JHS7Ic=; b=dQktyZozoDtiZCLk9ifIAhmTViFsM3+vxWlNXSxckkvBZEgC4cfpfqMI+bgEebXD4IAikXxW3HDKtfbpnon2IEuNaqHQmlaYHCzDcjR94ut8GcjLETCCqyM1K0GL/wvejPku+tfABuZXeE9yHAymjyNlTelIu07U5NJhOCN2nSo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 29 Sep 2022 16:57:18 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/NUMA: correct off-by-1 in node map size calculation Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0046.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::34) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5679:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e98f2d0-dba4-451b-c61e-08daa22aeac0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v19eMwh/cNvnOEsB5tJCqKmcYeIlFbf0KaXSX4oTUa1vpd1krLo2k6PU2GKyyxdzTSM9mTJqSNhPxWhd2BHMwqWPaWDrVZ/bWW7RLYn65D/Sf8ZAWpRnvxN6oUt66hq6Ib7WCuBnsLSk6LQ4Vank23lRiBtYrwsN6UZCATMX+fTO4XDeci+DVHhmIMXuU8tU3BUSdO1w7zajTvXdSRXFxIP1Uk28JZRq+26KsCK4dGpzoJaMvoUUsQAj6Nh0GE+SnhFW20FGvwKWNBqKc/wf2VyU6HRR8J1ar2CUzAmw9Y4vZbj3VAAM5CDRryKrYlE3NfZEztkmz/zL3afwFVrAPO7ybGI30VcZ9aNed3OyIBaIJamil60pLnmxgR3w/7EgSn2040MnW1eeBqaXdbL2jvvaL/zrWBgf/7e8B5L8QoSaGtuiCntsvAHblBokNj51X0GMV1HYL4lNDwJzcJ51AHQhrCHRpVUxAxqGyawuqp2s20X1l6aFdsjtqHjXnyoEk68LQh9bf4aFE6xSJ0E8pNEZ55Uxbzj5y7QjuN95uy9zzKVTyNusbZkzWtjSjRK0EEyi1TdmVcKH244KDFWI9p/Yo8buVWeqtEMS3YqSeM8Nk91E5H6qXpLG7r7GDfp0oDiiAtA6rAG23/L3G9xBMTkFY048AdyGG+kN1CgrJRx64AS2E/Zy6YrP0il0dii2P7UXo7/Ra++LXzBuRHgIkA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(451199015)(6512007)(9686003)(83380400001)(66476007)(66946007)(8676002)(186003)(26005)(66556008)(6916009)(41300700001)(478600001)(38100700002)(316002)(2906002)(86362001)(4326008)(6486002)(8936002)(85182001)(6506007)(82960400001)(6666004)(5660300002)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXFJZVV2bzJTUURTSFJ6b2tQNG9tUzVwend4N0xpMFhPRnYwYjl4aVNWRW1k?= =?utf-8?B?a0VuN25EMWFzb1VxUmpuS0RXdHhiOWlqcVlTeXlqOW1XRjlNQU9mbHFuWUZN?= =?utf-8?B?VGtKOHFFYmNQelVrVDNSYk9vTVRiMzc5aFVBYXBncWNnalRFT1pRRnZUUTZU?= =?utf-8?B?SkxJSXVKaWlkSTdRcnRNS1pVNU1IY0xCZGs5dDh5eDZTY0Q3RzVvU0prQWpT?= =?utf-8?B?Tm5TQTl3aXVxc0RZSE16MWp0OVBraGJSVXI4T1dnVVlxKzhFaS9aV2ZOUUFz?= =?utf-8?B?am9GeW8vaTBGNDR1Umx1SmIrTkFhMXg5K0J2Uy9vNnUxY0JLU0JaemtNYjBi?= =?utf-8?B?VjNQU2NvNVowRXluYXlxYlBGd29zU0Q2NWpWbTFzSzhzdHdkSVhFY3h6YnRv?= =?utf-8?B?bFVrNTVhQ2J1Y0JCVktrdWtjSnZmN0REVHlVbHFvWkd2L0xSZnhPbkJEVzRM?= =?utf-8?B?NWxGWUc5QU5IbTJpVEN3dnNmd2kvcmdOZmJWcWZjRnhJMk9MNC9jOUV0WUQ4?= =?utf-8?B?T3Qyb3lDaUk5YzEzeGg2ZjdOZ1RzVWREQUZtUnlSLzIyTS8xck0xcTkraFM4?= =?utf-8?B?aEtVa1F2V1BNRDhsYW9QQThTZHYyUWliaG9NTnh4emdBY0IzKzhhSDQvTHpy?= =?utf-8?B?a2huUFpoMit4YUhZSnkyUHZhb3ptV3VKMkVQVWlUZVBSM25YZzErdUkybXhQ?= =?utf-8?B?ZDVZYXcrUXV0YUJ0YjRBc3IybXk1WVdycWlOTk9pelQ0ZmFYSytpRXRpR2xQ?= =?utf-8?B?UlBUQnUyY0ZYMUtYV25nbHl4OUdvTzlSZytjTCtsckphd214NmlkQTI0YTU2?= =?utf-8?B?aktrTFF4am45ZERHNjdYMHJGTGxLWnNkSUhUalA2UmlzaHd1ODcydTRQM0dD?= =?utf-8?B?MUc5c2JxS2dQczJ1ZEQ4ZlRtNXFDWnBxdUpqVER2RHJtK1lHMCtxejZUOGlm?= =?utf-8?B?SGhobVozWnA2RVRoQmhvMUpDV2Z5RFZqOXRQZW44djQvUDBydVBvMmpTdXo1?= =?utf-8?B?ZDJNOExaM0xlcDJIaktOcXhOSEtKY2JQSGpuMzU3RlJjay9EaWhJQUUydk9Z?= =?utf-8?B?TjJkbUtkZTl3bjR6d2YrV1ovK2JlcXErcWhrdXNBTWJwYzRtM0hsZ1pCT29q?= =?utf-8?B?MGdoTHNrV2lGcXdVYkxtN0JiMXdmSGhpVDhzc1Q5M3ZKS0ViRVBjZWRkTy9O?= =?utf-8?B?dDM5eDAyZEw5SHJVUWxRQ21FTERwVG5OZTBMMVprNjcrMkt0RUxQRVZhMFBI?= =?utf-8?B?dG5vQ0hxcVpnMWUxSHJHOTVGajdCbjBMTlhSOGVlMkRBd0dodC9QbitpVFR2?= =?utf-8?B?Q3pVTjdQaXp5aGpJUjZPa3R2ZzBRckxKR3lQMTBveWRncks3bElWRG92c2dl?= =?utf-8?B?SStXMjYxQTFhc2phRzhQb1pVVzdsZ2xFNEpBWFdXMWE4V0tMSGxsKzg5Wk9X?= =?utf-8?B?eGRZaXhSc1ZHZmg4bVV3aFh0dEVFY0dsSndBejJ5TWpDOFBKbzNDbVZrc1lM?= =?utf-8?B?WERPTy9aMnVodEdVbG52T2ZGYWpuTEtLZEV3SHpITGkvdWJDQ3dvN2VaYXJ5?= =?utf-8?B?V3dDaGFhNWFWUDRwU1ljbktaelR6MVZrdFhuSnhtUVlQcmdXV0hJWVVmSTJD?= =?utf-8?B?a3RpeFY1OHVvSW1VbkczWnhxVE9KRnJXamNneGpoMFRjSWpkcTFGU0cwaU8x?= =?utf-8?B?elZaUUptL1prMGZBTWpOdENmb1NybUg0M2EyTWhneU9UcEVJeTlMTjlTdXZT?= =?utf-8?B?Y0hjSTA5cHdpc1JZRmZVakNya0xIRUEvQUt2cWJ3azcvVTRUakI3Yno0VXpx?= =?utf-8?B?THowa1BNNU5UbFd2Rm81VmNITEZXaEJ1V1BaZFVveW5BVEVKQlg5TldkN0VB?= =?utf-8?B?R2ZZd0J4VU9Rekgrblh6NDNsaFFUNTRXYXRYNW5QT0xJa09xclV1dWNmL1Rv?= =?utf-8?B?UmcrNWU0dldoN0RQNnpqMlZXTFo1cTh5Y3dsRGViY2pxNUFuMiszR1gya0lk?= =?utf-8?B?YXdWMFdpQnUyd3VqTVJ5ZnQ5QXNiZDVZQVM4YjRCc0NjR3QvbVFObUVvdGE1?= =?utf-8?B?d3dFOHZMdGpRUlptbHczd0ZtT1NqcjgzZ2dhMW1RMVJtcWw1MWcwcUR4K0Rw?= =?utf-8?Q?XPQ1JYxD7UQhx7jh/SQKOOHN/?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e98f2d0-dba4-451b-c61e-08daa22aeac0 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 14:57:24.7263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r75pwLCbpuoTjaArs3NFVC4VGJ4Smx/ViKIDJ8lZWBlH415zLZ1L3XzaWYFFBDlITkDo4qOy6u4hE0l2GvMN/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5679 On Tue, Sep 27, 2022 at 04:14:21PM +0200, Jan Beulich wrote: > extract_lsb_from_nodes() accumulates "memtop" from all PDXes one past > the covered ranges. Hence the maximum address which can validly by used > to index the node map is one below this value, and we may currently set > up a node map with an unused (and never initialized) trailing entry. In > boundary cases this may also mean we dynamically allocate a page when > the static (64-entry) map would suffice. > > While there also correct the comment ahead of the function, for it to > match the actual code: Linux commit 54413927f022 ("x86-64: > x86_64-make-the-numa-hash-function-nodemap-allocation fix fix") removed > the ORing in of the end address before we actually cloned their code. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné > --- > Really the shift value may end up needlessly small when there's > discontiguous memory. Within a gap, any address can be taken for the > node boundary, and hence neither the end of the lower range nor the > start of the higher range necessarily is the best address to use. For > example with these two node ranges (numbers are frame addresses) > > [10000,17fff] > [28000,2ffff] > > we'd calculate the shift as 15 when 16 or even 17 (because the start of > the 1st range can also be ignored) would do. I haven't tried to properly > prove it yet, but it looks to me as if the top bit of the XOR of lower > range (inclusive) end and higher range start would be what would want > accumulating (of course requiring the entries to be sorted, or to be > processed in address order). This would then "naturally" exclude lowest > range start and highest range end. I'm not familiar with the logic in the NUMA code, seems like a possible optimization. It might be good to include in which way a bigger shift is beneficial. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Sep 29 15:53:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 15:53:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413847.657767 (Exim 4.92) (envelope-from ) id 1odvqe-000732-2w; Thu, 29 Sep 2022 15:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413847.657767; Thu, 29 Sep 2022 15:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odvqe-00072v-00; Thu, 29 Sep 2022 15:53:16 +0000 Received: by outflank-mailman (input) for mailman id 413847; Thu, 29 Sep 2022 15:53:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odvqc-00072p-1q for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 15:53:14 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d28071f5-400e-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 17:53:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C0630B820D1; Thu, 29 Sep 2022 15:53:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B513C433C1; Thu, 29 Sep 2022 15:53:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d28071f5-400e-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664466790; bh=ttMe8cMmwtVdgjTvUp5hN4+IDIVKDcGidIj7uh1vLOs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=k1tUwjNyp7OfN2npaE8ib+esU/bmk5XIAyzVA/So3MwUruMruZzL7VZqoK30JvypK drJgawCfpdSamVt5VRyKK8RzjvmtJBqaGVOK46PAW0Rmm0YOEJ1i4V744bZXTQfgQF xMGd3H2MJVDQrkwf540fD3MUqhGPNItAId/lwxm6LQp7hJH7vRINXThRfMbD9tz2cW fpXOnReZCZt+KMGMruvLeNLiWvJ1QbocbrcehKNWxW0SurQXitC/GSLQU3N1gWlqLk q7SPGID9oVVhEyshLiTeO9s9YhMMEj8NlcsNTke/zcWix3gFPv/zsCgsMl24uddhfk FFoc7MnvOSaHg== Date: Thu, 29 Sep 2022 08:53:08 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [for-4.17 v2] xen/arm: domain_build: Always print the static shared memory region In-Reply-To: <20220919183737.14067-1-michal.orzel@amd.com> Message-ID: References: <20220919183737.14067-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 19 Sep 2022, Michal Orzel wrote: > At the moment, the information about allocating static shared memory > region is only printed during the debug build. This information can also > be helpful for the end user (which may not be the same as the person > building the package), so switch to printk(). Also drop XENLOG_INFO to be > consistent with other printk() used to print the domain information. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > The other motivation for this patch is to be consistent with regards > to the format of the informative logs. We do not really use dprintk with > XENLOG_INFO unconditionally as it results in printing additionally filename > and line number which may be misleading for someone reading the boot log. > Such extra information is helpful on error conditions to make the process > of debugging easier. > > Rationale for taking this patch for 4.17: > Useful information printed always instead of only during the debug build. > > Changes in v2: > - use different argumentation > - drop XENLOG_INFO > --- > xen/arch/arm/domain_build.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 01c2aaccd82d..40e3c2e1195c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -844,9 +844,8 @@ static int __init assign_shared_memory(struct domain *d, > unsigned long nr_pages, nr_borrowers, i; > struct page_info *page; > > - dprintk(XENLOG_INFO, > - "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > - d, pbase, pbase + psize); > + printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > + d, pbase, pbase + psize); > > smfn = acquire_shared_memory_bank(d, pbase, psize); > if ( mfn_eq(smfn, INVALID_MFN) ) > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 29 15:53:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 15:53:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413848.657778 (Exim 4.92) (envelope-from ) id 1odvqz-0007ON-AZ; Thu, 29 Sep 2022 15:53:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413848.657778; Thu, 29 Sep 2022 15:53:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odvqz-0007OG-7f; Thu, 29 Sep 2022 15:53:37 +0000 Received: by outflank-mailman (input) for mailman id 413848; Thu, 29 Sep 2022 15:53:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odvqy-00072p-2o for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 15:53:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df94dc87-400e-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 17:53:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E0A36618CF; Thu, 29 Sep 2022 15:53:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71B49C433D6; Thu, 29 Sep 2022 15:53:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df94dc87-400e-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664466813; bh=whn/UAHZJvwOFIN2kO0KyEB44LZVp5inAO5r8KE1yZI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=GUX+Cks27vleV4d6ZEEIYhuMZ/YpE4HQWM9FIXhJNqY1gauHb3MkevSq1dL54HrHf rBcTlY3+MikCjYU7YvXHeSwriR4L/uV/Y6XazOnHLbDLz4gkXpS5SYtiZtgxgGsf5j lTYrhLXjtHrspX378vwTTyeULYk8iqI85wb4IUtFO15OKWUFs/0sgfypZF22Qst8nh iAfuDP3QO5w+jtZg62+44+GFFw269VZpeNknhSfN067kPJeCGzED1JzMP4yFRV9Z/D f9jHTUFkANt839CSG/FCbhtsnnQ7liq4ME0/GdwzgAn1LOoc34MF+wVM8WNfLa+WGE Gx4Rj1vEUX2Sg== Date: Thu, 29 Sep 2022 08:53:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Anthony PERARD , xen-devel@lists.xenproject.org, Stefano Stabellini , Henry Wang , Doug Goldstein Subject: Re: [XEN PATCH v2] automation: Information about running containers for a different arch In-Reply-To: Message-ID: References: <20220926135838.47330-1-anthony.perard@citrix.com> <20220929095131.61034-1-anthony.perard@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 29 Sep 2022, Michal Orzel wrote: > Hi Anthony, > > On 29/09/2022 11:51, Anthony PERARD wrote: > > > > > > Adding pointer to 'qemu-user-static'. > > > > Signed-off-by: Anthony PERARD > > Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Thu Sep 29 15:55:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 15:55:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413860.657797 (Exim 4.92) (envelope-from ) id 1odvtG-0008Ph-P6; Thu, 29 Sep 2022 15:55:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413860.657797; Thu, 29 Sep 2022 15:55:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odvtG-0008PZ-M0; Thu, 29 Sep 2022 15:55:58 +0000 Received: by outflank-mailman (input) for mailman id 413860; Thu, 29 Sep 2022 15:55:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odvtF-0008PN-TU for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 15:55:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60076.outbound.protection.outlook.com [40.107.6.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33ef614e-400f-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 17:55:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8394.eurprd04.prod.outlook.com (2603:10a6:10:244::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 15:55:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 15:55:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33ef614e-400f-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fdxf3/w43/9yBQaMh3z+KZfjVmWDwPulXFOqpuo3WvIqQD3VTkzYbYO6aTDLoy3gFzX61f0LCN2CaM+bdwDZlc8pCbMEfHTAFHr18yokR+ODw4xyRPxlv/1uXW+tPo8uizkIg97JbbgtNLgKGGTa76ZgsOD6Q2pa631yac8r6BloKgk76Ic+SOO0o57tbungB4fNYmBRDCI3WieqwpmCeX+qmhid/MSEYYG80DG6mxzajY9OjKXjV14LmAjkc/mtqJg1ebXdEaU5RRiJRVV40WEfpTHRjWg9tr24RwtScL/KVZ1mKFsFOgt2ZjrW0pKitD4DKfaFtWikAFffk69r4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tTJ0JxJTsuGT4ZSkMcbdE9s23cbnZWxbni1648Q9U0k=; b=L2IAvtzvYy48zM/aJq8tMONakdnFh5o0Y7WXqaIbnKFFV/kA2wdpGAxKAi/rKBETtGVluzLZZvHS35vJiB5ubak7VAqBClrkksztuuKTf2Hb+yivoHrlLdRLiVexhPcvT9a4LSUhqbSwy3tMuIVRzdgWAN3ajYFeaXTq3Mu4WQr/adUG/4Tey4K50atE4jx+Jd6W8s1yh7SVVjo5S4nQ7kZ6Y7JRma3n7Fi5MCWRZW/cVXY86/avfBoCkDFFORPx7WaApaoQib5/K1u6pswiK0vEzJ9hQ75m0Wfv9vR5rt5tRoMCR9YB+VVHxV4xEXwg5T4fFqZJOdkbX32H3ZT6UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tTJ0JxJTsuGT4ZSkMcbdE9s23cbnZWxbni1648Q9U0k=; b=wvxVsk/nnSbUMWfRP9R0GQPV/sWRTKy90fVpaA2lSgWVMaALXZ1ykIgXm8ejlaaV0tI7NiOYzX3bB/A9uu59AreznjpyWgkqukRWeSA2Y1kfC4l64ih1pwABBiQTxNu1+RvzMDtQIPMs6bgztrW2SaUoner37AH5aZpcsXYURCeByRiyGWeHLbwcCDJujvOoU0uG0zYix2XTpVGBG7MRuv6X0nAJjXUG7wp7uPJtvh/rO1vn7c/lbcDfMGz05BlbJ+wZ/AeEgVTI3kCFyMQZwNIYx+RTY2g8Ae0yJZfUi+9UisvVVlVNz6P5WNI1AKSwky3vLHGKO2t1OG1ZO57UsA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <268f8c2c-57ba-e4e3-59ef-45ed3cd794de@suse.com> Date: Thu, 29 Sep 2022 17:55:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [RFC PATCH v1 0/2] Add a new acquire resource to query vcpu statistics Content-Language: en-US To: Matias Ezequiel Vara Larsen Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , Anthony PERARD , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0176.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8394:EE_ X-MS-Office365-Filtering-Correlation-Id: 76855dc8-229c-4f54-fbc1-08daa23315c5 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bq2K339RTfg+7KjfdsUQoq6xxwTG8VOv8DUw5WPTnDuCt0kHWzg4jb5+h0zCbFVWvMn/0/U2BrC0fentqTBUDkWtIo43lIPCGHBHiC5wBdjsTTWPJ1y5VHDva7gChaYtr3A8OtqRTtfQ+OFfq1E5R1XBpzwthSNadQTai9RrPyXcpSOg496vEnk3cTtXlExNtGy8e7/G4wWBftotvhKblNKcbtLEReQAqa4vDd9lZvxA9OcW+Ol7MSdB6bizF2VzyXEovx2zsxx06n8OkCJYlilLeMOpUoH8UPGQcNRWg/A36Mnyc8ZC3LzyrS8KfOn4dR5hmhFoXvnE6YzUNVBuZPVFKnhVXyzMiKSOzczYUWNJo2YIMyfAkmP+ec2VbZSGQwqS6mfFFj3t6FhJw3iP5mWhvZpvdLJwmFmjXlhzpv2xD5+KkaLuqUvYLbBollwdwKUObtPY5Bjka9FZVD/aQPzXpv4APGJjeM27IXvHJzLHlKtcqGmAukOLWzW2zpSq5wq5L12brOUB8l+NhrfoYGwih/imLiH2HqXIcn9SVVFSz25Fjwvaj4OjOTr9F146nr6vChJ3Q4si5XckW9Gem7vM39JmOB2I3PG/6eLhNqbuS2JzF5573Tt9jVg4EI+fPS4qIvcR5VLdHqwGar/+QWTMsoRQraUDO11iMAevGuGlfeko3Rt4UA0x/6Qc4p9e/bCNArYnUf48LelVlI2ueUX7ksqSRQkJNmvRszSlMKDUlRJnE9FopeljyZ0YkfEY9xo4rWacPt0WpRJhmXXSrAQk9mlp7nxw8TmaeHTjAVk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199015)(8676002)(83380400001)(186003)(2616005)(38100700002)(2906002)(41300700001)(5660300002)(8936002)(316002)(6486002)(478600001)(53546011)(6506007)(26005)(6512007)(4326008)(66476007)(66556008)(66946007)(54906003)(6916009)(36756003)(31696002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekR4QWJ5VW5xSk5VVEtzT1NJZ2I4OS93WVRZcktHVjVUMWFLbG4rU28xdXR4?= =?utf-8?B?OEFybG0waWJvSERBQWtORVZYYktHY0YydlpYZGo2bzJFSEgyZFU3SFdmSHdl?= =?utf-8?B?blh5VmVZRjRLS01TOHRPQWcyemZCZU54UkxqY1J1OFJLRUN1UStXOFBGYjRS?= =?utf-8?B?S2R5QTJSc1ZsdjUrdHhub3RDZnlNSkFDN2JJOHVxVkZHUEFCekI5SDNINWhQ?= =?utf-8?B?eFBRc1Mra2ZnWkcxZjBCV1N5cEczcE5qYnk2WklPT2hCN3ZwdXJNd3JaUHZM?= =?utf-8?B?NXI2SGtGYVRPODM1Vmw0ekVVOEo5MEtTTlk2eFV6S0xFcG4wbGFYTzltMGVV?= =?utf-8?B?MGszRXFTMEpqbnB5Z0FEUHVGcXNvamZyWEN3ejUrd1NxeEJ0ZVM1QktnZ0p4?= =?utf-8?B?WHpRZTNNQkFqajdUUkdad0dHaWJBYWlLSWZmUlVhQWltSjRlUWd4b29FRmtm?= =?utf-8?B?NkxlOVdiT2MzOWI4Z2xhTExJZnNtcWxJZEV3RWtLN3VmQ3Z5akp1Z2hDSDJh?= =?utf-8?B?NEJBR3duNjBOWmlkd3dTOFJkeDQ4M2VpcS9LZDJsZXNEL2R5Z0hla1YwSVhU?= =?utf-8?B?a3lCK3BUdzFWVFBHQmVsTHA0TlQ1ajBwemVYbEVhN09Oc0Z1alloRUJHaG9Q?= =?utf-8?B?SGtJRDFhSTRqbjJxL0oyZ2RrM3IxTFlYQ3o3WjRpWHRkcG0ydlZKMlV3aU50?= =?utf-8?B?Zk81NEVmYmlnbXlUbTlBNzUwVHVsd3d2VXhNVlhOMXpvWGNjSGJ5VkFDQnNr?= =?utf-8?B?Q0R1SlRMSWwwNlFiTGdQNVV3V3JySGt0cWUydkJkY3RLRndDTXBIUFdFdW9R?= =?utf-8?B?NEdneGlMa1c1QVBnUEZDMFdrZE5ubThPZngrOVJWUEpqaGFqdkVONUljdEdL?= =?utf-8?B?ZkQrTzJTMm9EaWxrbUlzcUpVSDVqaWF2cHlLZ1pBUjkzZEtzMElsRVNSMW5x?= =?utf-8?B?ZE5ubDVxT3QyY2pJRi9odkFORTBMUUE5anBSdU0yR2FpblRTb3oyMWoxQXZS?= =?utf-8?B?SGNuOW1zazdWSkJ5NS8wMjh4dWVQa3Nta3JMSSsyYnBuNEV1VTRSUG15MHND?= =?utf-8?B?S0NUT2JpdmhDK1d4OTRLS3h6SGs5ajdHM2FnTXppZXdCQm1lT0hHYnVzWFJ3?= =?utf-8?B?NUxwTGF4bWViNjY4T1RMeFVTSmtucVR3LzBZZnRnZ0NWWXZZalpaM1R3cGJ1?= =?utf-8?B?Z2RTYXE2SEg1czF6MURnVmFkSWliTmQ5NGVJYWRrVDBBR0I5WTV5dlFLL2pr?= =?utf-8?B?ckM0NHBuTnBpOEFONXV5ODR0aDR2dzlRdEcyQ3h5V2tSNkJlSmlYSDZWaGlF?= =?utf-8?B?c1FaSDlRWDBHSzNTdGdoWWFJbmhpQlpzOTVkR0FiTXhyZUNobXNtK0dJV3dw?= =?utf-8?B?YjhXWDJBNDViL0RkNTQwdHV0aDk4c3VuQy9DQWVTSzVxU2JhUVBud0ptUkxG?= =?utf-8?B?WDZheG9iVHVCRmd0Sm42UnZPQTFUdHlsUVhHNVJORUtOUnV0V0pUV09oQWZJ?= =?utf-8?B?R0NwNXQ4bDRHZ2J4RGpoMTBQS1FvNkN1V3FGNG1jeTladm9EMUltZUJTdmpz?= =?utf-8?B?ZnZtamI2NmJFdXpGQ0NQdWl1NnhzV091Tng0RHFseVdMcWRCNG1NNVBualkv?= =?utf-8?B?eTJsYnhBSmdWRDFvdnVZWmVyODBldVliY2pNbHBTS2p6N3hyS21SbTlOVzNH?= =?utf-8?B?U2gwUGJKeVRFeUNWcytEcnh0TUhQUFBtL0xwNkczdG10czhHQStMeFFGN3pQ?= =?utf-8?B?V2R0RUppNlNNbkRId3lIOTBnSWtEcE50bytrN05xVEdnWTYrdUdjdWwxTm5L?= =?utf-8?B?b2x0cCtSWm14ZVpJQVl1L3FWMjdqNXRQellkODJhTm93VGsyRFdKWG14MXJo?= =?utf-8?B?V1krOWcxSWdhN0p2bktac1NyTFUxTGF3SnNSdm5aR0oyWHM0ZklYOTZxd1R2?= =?utf-8?B?LzJqSUU5N0Z3SmFMZTRhZ3FSbVJPcVB0TjQrR2ZadXZyb1h0bGw5WEx0NW84?= =?utf-8?B?SEEyVkRVVmp5NFJiNmk3MVlNalk4amdac2JMb0JOYWMyNE9EVkdkOG45YlJx?= =?utf-8?B?OHB4M2Nmd2VVR0FwUGpQT2JpUTl6NnFpTXltbThHRWdGNEpscmFpZDdIbWcw?= =?utf-8?Q?WzSkLEO9JwYMerKfni6rkj4Fd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76855dc8-229c-4f54-fbc1-08daa23315c5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 15:55:52.4612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LRI52cTzHgch3CF8KyvNyNbg76+fOCnXte+BwWFs5MUetEN9LcqLLpMFFEelaFH+uChB+Qmzk+adcLDKTB8JJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8394 On 24.08.2022 15:27, Matias Ezequiel Vara Larsen wrote: > The purpose of this RFC is to get feedback about a new acquire resource that > exposes vcpu statistics for a given domain. The current mechanism to get those > statistics is by querying the hypervisor. This mechanism relies on a hypercall > and holds the domctl spinlock during its execution. When a pv tool like xcp-rrdd > periodically samples these counters, it ends up affecting other paths that share > that spinlock. By using acquire resources, the pv tool only requires a few > hypercalls to set the shared memory region and samples are got without issuing > any other hypercall. The original idea has been suggested by Andrew Cooper to > which I have been discussing about how to implement the current PoC. You can > find the RFC patch series at [1]. The series is rebased on top of stable-4.15. > > I am currently a bit blocked on 1) what to expose and 2) how to expose it. For > 1), I decided to expose what xcp-rrdd is querying, e.g., XEN_DOMCTL_getvcpuinfo. > More precisely, xcp-rrd gets runstate.time[RUNSTATE_running]. This is a uint64_t > counter. However, the time spent in other states may be interesting too. > Regarding 2), I am not sure if simply using an array of uint64_t is enough or if > a different interface should be exposed. The remaining question is when to get > new values. For the moment, I am updating this counter during > vcpu_runstate_change(). > > The current series includes a simple pv tool that shows how this new interface is > used. This tool maps the counter and periodically samples it. > > Any feedback/help would be appreciated. Before looking more closely - was there perhaps kind-of-review feedback during the summit, which would make it more reasonable to look through this once a v2 has appeared? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 29 16:13:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 16:13:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413866.657807 (Exim 4.92) (envelope-from ) id 1odwA1-0002zo-7O; Thu, 29 Sep 2022 16:13:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413866.657807; Thu, 29 Sep 2022 16:13:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwA1-0002zh-4g; Thu, 29 Sep 2022 16:13:17 +0000 Received: by outflank-mailman (input) for mailman id 413866; Thu, 29 Sep 2022 16:13:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwA0-0002zb-9z for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 16:13:16 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f168445-4011-11ed-964a-05401a9f4f97; Thu, 29 Sep 2022 18:13:14 +0200 (CEST) Received: by mail-ed1-x531.google.com with SMTP id c30so2655591edn.2 for ; Thu, 29 Sep 2022 09:13:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f168445-4011-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=flhFeICuQT8/y+9AVAFFUYd5hifnxYkJzhAO79vKcmg=; b=EhY8JIY2vNyhwun3cvL+gwk4TrnS7fE6wyz6JcP7/jDMYo6WAeulvPvh/B41SbrsN/ dy1H78vZh/fKYgMpQiK+5nTh1T7+/5xmzAdEzEBvpFpeI5KXta1HriQGlxgeq4uRxcFb xm05bxX/1bOn4PTSTu6RTdUOEZY1QgdWvvCVCSyPKS3wph+OjISkizrlmTNOQCkfOpoa Ets3BpRX9bmJeHJaP1SgQ41lIGXcEkKpb5LasChk7F64ivMgXg0HG36oVcOkEVelK90e MAnU3J5Pg20sAnB6NVtPrRhkE+aQzTTpijBsSWnsnnr8JzumCM4piFXDgbgUFuxZnVWI 6PwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=flhFeICuQT8/y+9AVAFFUYd5hifnxYkJzhAO79vKcmg=; b=uVKzQdbQJn2qp9L+C+uTWkPIBoHjbtX/YQEK6fZJSHASujlZC/hNRtF4VWWbqugoGA p5ZY7WKh0CWBZjVu2+YvnL0l25LJ8iiegjNnc4e4mwRLX92Av/TcGjAZLGDp/r5LgRtN j6cLukVwz5NgndnR+q4HPKaSEayoV9jD0UyUE7kDIqhjyh2DnR7Qe0YE9HP0V4uo10JC z1asnQ5HaJKetFbDHk0OCfew/KiqYBht2vq9KPk+NPwm+VW6FcXwxgFaLioVHFEY32Hh W9Z9XvAQJy2XQLpk6Ygs4axn5rhtAIXYiAcgPJSZ00lcXU+L2I+AxONqCSVK10LSXnzD q7Ag== X-Gm-Message-State: ACrzQf1Qhwx7R6QFLw2ijpIwXxQRFPzUJ9B1LRRMDry2lxGvgslvpuMN 2z2g/4sSiF4GN62pS75Iu2vlPQpnb5cf0+Sc3ms= X-Google-Smtp-Source: AMsMyM54iankNpI//+Sl0NdaWe4qDjetwyVTsrK9LCND5wGNFoiqaKM2Q7SvxkKkNPy9hQMykurk6zytYdx4eBUXju8= X-Received: by 2002:a05:6402:5188:b0:452:5395:a271 with SMTP id q8-20020a056402518800b004525395a271mr4099193edd.383.1664467994131; Thu, 29 Sep 2022 09:13:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Vipul Suneja Date: Thu, 29 Sep 2022 21:43:02 +0530 Message-ID: Subject: Re: How to do display sharing between guests or bring up guests display To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis Content-Type: multipart/alternative; boundary="00000000000087bfc605e9d327bc" --00000000000087bfc605e9d327bc Content-Type: text/plain; charset="UTF-8" Hi Elliott, Thanks! Any input from your side on this issue will be really helpful. Looking forward to hearing from you asap. Regards, Vipul Kumar On Tue, Sep 27, 2022 at 11:47 PM Vipul Suneja wrote: > Hi Elliott, > > Thanks! > > As per the link you shared, VNC & SDL are two ways to get GUI display up > for guests. I am going through VNC & tried SDL, added below line in > guest1.cfg file. > *vfb = [ 'sdl=1' ]* > when creating guest machine by running command "*xl create -c > guest1.cfg" *then its throwing errors: > > > > > > > > > > > *root@raspberrypi4-64:~/guest1# xl create -c guest1.cfgParsing config from > guest1.cfglibxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error > on QMP socket: Connection reset by peerlibxl: error: > libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP > connection to QEMUlibxl: error: > libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup > configs failed, rc=-26libxl: error: > libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did > not start: -26libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device > Model already exitedlibxl: error: libxl_domain.c:1183:libxl__destroy_domid: > Domain 3:Non-existant domainlibxl: error: > libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy > guestlibxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain > 3:Destruction of domain failed* > > It works absolutely fine & guest1 comes up if *vfb = [ 'sdl=1' ]* is not > included in the configuration file. Anything wrong with the statement > added or any other steps need to be followed for this? Looking after your > response asap. > > Regards, > Vipul Kumar > > On Thu, Sep 22, 2022 at 12:03 AM Elliott Mitchell > wrote: > >> On Wed, Sep 21, 2022 at 10:54:55PM +0530, Vipul Suneja wrote: >> > Now I have built a custom image with GUI & ported it as a guest2(DOMU2), >> > guest2 came up as a console & couldn't see the GUI screen(Display screen >> > connected to rpi4 via HDMI) coming up. >> > >> > Can you please guide me on display sharing or how to bring up guests >> > display? >> >> This has already been answered in several locations. The first place to >> ask for help with the RP4 is their own forums. Turns out the topic is >> well known: >> >> https://forums.raspberrypi.com/viewtopic.php?t=232323#p1775083 >> >> (huh, their forum moved to the raspberrypi.com domain; they really need >> an entry for Xen in their other OSes area) >> >> >> -- >> (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) >> \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / >> \_CS\ | _____ -O #include O- _____ | / _/ >> 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 >> >> >> --00000000000087bfc605e9d327bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Elliott,

Thanks!

Any input from your side on this issue will be really helpful. Lookin= g=C2=A0forward to hearing from you asap.

Regards,<= /div>
Vipul Kumar

On Tue, Sep 27, 2022 at 11:47 PM Vipul Suneja &l= t;vsuneja63@gmail.= com> wrote:
Hi Elliott,

Thanks!

As per the link you shared, VNC & SDL are two ways to get GUI = display up for guests. I am going through VNC & tried SDL, added below = line in guest1.cfg file.
vfb =3D [ 'sdl=3D1' ]
when creating guest machine by running command "xl create -c= guest1.cfg"=C2=A0then its throwing errors:

root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
Parsing = config from guest1.cfg
libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback= : Domain 3:error on QMP socket: Connection reset by peer
libxl: error: l= ibxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP co= nnection to QEMU
libxl: error: libxl_dm.c:3351:device_model_postconfig_d= one: Domain 3:Post DM startup configs failed, rc=3D-26
libxl: error: lib= xl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not = start: -26
libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device= Model already exited
libxl: error: libxl_domain.c:1183:libxl__destroy_d= omid: Domain 3:Non-existant domain
libxl: error: libxl_domain.c:1137:dom= ain_destroy_callback: Domain 3:Unable to destroy guest
libxl: error: lib= xl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed

It works absolutely fine = & guest1 comes up if=C2=A0vfb =3D [ 'sdl=3D1' ]=C2=A0is = not included in the configuration file. Anything wrong with the statement= =C2=A0
added or any other steps need to be followed for this? Loo= king after your response asap.

Regards,
= Vipul Kumar

On Thu, Sep 22, 2022 at 12:03 AM Elliott Mitchell <ehem+xen@m5p.com>= ; wrote:
On Wed,= Sep 21, 2022 at 10:54:55PM +0530, Vipul Suneja wrote:
> Now I have built a custom image with GUI & ported it as a guest2(D= OMU2),
> guest2 came up as a console & couldn't see the GUI screen(Disp= lay screen
> connected to rpi4 via HDMI) coming up.
>
> Can you please guide me on display sharing or how to bring up guests > display?

This has already been answered in several locations.=C2=A0 The first place = to
ask for help with the RP4 is their own forums.=C2=A0 Turns out the topic is=
well known:

https://forums.raspberrypi.com/viewt= opic.php?t=3D232323#p1775083

(huh, their forum moved to the raspberrypi.com domain; they really need an entry for Xen in their other OSes area)


--
(\___(\___(\______=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --=3D> 8-) EHM <= =3D--=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ______/)___/)___/)
=C2=A0\BS (=C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ehem+sigmsg@m5p.com=C2=A0 P= GP 87145445=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 )=C2=A0 =C2=A0/=
=C2=A0 \_CS\=C2=A0 =C2=A0|=C2=A0 _____=C2=A0 -O #include <stddisclaimer.= h> O-=C2=A0 =C2=A0_____=C2=A0 |=C2=A0 =C2=A0/=C2=A0 _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/= 5445


--00000000000087bfc605e9d327bc-- From xen-devel-bounces@lists.xenproject.org Thu Sep 29 16:22:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 16:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413874.657819 (Exim 4.92) (envelope-from ) id 1odwIV-0004cG-5U; Thu, 29 Sep 2022 16:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413874.657819; Thu, 29 Sep 2022 16:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwIV-0004c9-21; Thu, 29 Sep 2022 16:22:03 +0000 Received: by outflank-mailman (input) for mailman id 413874; Thu, 29 Sep 2022 16:22:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwIT-0004bz-Eh; Thu, 29 Sep 2022 16:22:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwIT-0003tG-Ab; Thu, 29 Sep 2022 16:22:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwIS-0005Pu-QG; Thu, 29 Sep 2022 16:22:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odwIS-0000uf-Pm; Thu, 29 Sep 2022 16:22:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A3GR2xn7mpDa7At34ptkY2xpADNGKzBGly3G2DW7zDk=; b=L9NQGNOCRdpOFfl5U9xceDM2pw 1Wl8SsDWJVNgv2pYS2yeAm8dntUK4MlAG+p90ijE+e9LK8E0JCnKr89QnkdhpvBzwrcJHdljBNpOL j9QRaXnzrxLUaRwty1VYbLGNo9ceQhgSsgya0tuiPPR3loQj9fbYqgGlX3vYd8gp9RNk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173362: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Thu, 29 Sep 2022 16:22:00 +0000 flight 173362 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173362/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 173347 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 1 days Testing same since 173362 2022-09-29 13:03:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stewart Hildebrand jobs: build-arm64-xsm fail build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Sep 29 16:25:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 16:25:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413881.657830 (Exim 4.92) (envelope-from ) id 1odwLw-0005Iz-MI; Thu, 29 Sep 2022 16:25:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413881.657830; Thu, 29 Sep 2022 16:25:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwLw-0005Is-JM; Thu, 29 Sep 2022 16:25:36 +0000 Received: by outflank-mailman (input) for mailman id 413881; Thu, 29 Sep 2022 16:25:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odwLv-0005Im-GY for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 16:25:35 +0000 Received: from ppsw-40.srv.uis.cam.ac.uk (ppsw-40.srv.uis.cam.ac.uk [131.111.8.140]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56768bee-4013-11ed-9374-c1cf23e5d27e; Thu, 29 Sep 2022 18:25:34 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:55564) by ppsw-40.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1odwLq-000ZHL-K8 (Exim 4.96) (return-path ); Thu, 29 Sep 2022 17:25:30 +0100 Received: from [10.80.2.8] (default-46-102-197-194.interdsl.co.uk [46.102.197.194]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id E362E1FC8A; Thu, 29 Sep 2022 17:25:29 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56768bee-4013-11ed-9374-c1cf23e5d27e X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> Date: Thu, 29 Sep 2022 17:25:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [xen-unstable-smoke test] 173362: regressions - FAIL Content-Language: en-GB To: osstest service owner , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang , Bertrand Marquis References: From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/09/2022 17:22, osstest service owner wrote: > flight 173362 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/173362/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-arm64-xsm 6 xen-build fail REGR. vs. 173347 arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access': arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of 'iomem_deny_access' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]          rc = iomem_deny_access(d, mfn, mfn + nr);                                 ^ In file included from arch/arm/gic-v3-its.c:24: ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but argument is of type 'const struct domain *'  static inline int iomem_deny_access(struct domain *d, unsigned long s,                                      ~~~~~~~~~~~~~~~^ cc1: all warnings being treated as errors Bug in 9982fe275ba4ee1a749b6dde5602a5a79e42b543. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Sep 29 19:30:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 19:30:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413900.657861 (Exim 4.92) (envelope-from ) id 1odzEi-0007rl-1u; Thu, 29 Sep 2022 19:30:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413900.657861; Thu, 29 Sep 2022 19:30:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odzEh-0007re-VZ; Thu, 29 Sep 2022 19:30:19 +0000 Received: by outflank-mailman (input) for mailman id 413900; Thu, 29 Sep 2022 19:30:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odzEg-0007rU-Pz; Thu, 29 Sep 2022 19:30:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odzEg-0007DE-KC; Thu, 29 Sep 2022 19:30:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1odzEg-00080L-70; Thu, 29 Sep 2022 19:30:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1odzEg-00060p-6S; Thu, 29 Sep 2022 19:30:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HLk4B/IzCTPP4PRha2R3UiXHC6ww9giTeDWtYiMkSkI=; b=zih+zDb9KVPS9EhGxWxbnXz+d/ 7wgFYNHWsCGR/JtbOdg23Djyut8zD2qngiyjv/wgQNH++a6mwhL9bVPqG89q4aSVWGhGtghew7Lrc RmxtwbxrTrB6uTsaneF/c7lVrDBK9xhyfaUSZrTcI9qOgNr6dpfLHN/vIqjeqWJni3fY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173367: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Thu, 29 Sep 2022 19:30:18 +0000 flight 173367 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173367/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 173347 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 1 days Failing since 173362 2022-09-29 13:03:03 Z 0 days 2 attempts Testing same since 173367 2022-09-29 17:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand jobs: build-arm64-xsm fail build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Author: Anthony PERARD Date: Thu Sep 29 10:51:31 2022 +0100 automation: Information about running containers for a different arch Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit a210e94af38a957fcc99db01d2cfcc3039859445 Author: Michal Orzel Date: Mon Sep 19 20:37:37 2022 +0200 xen/arm: domain_build: Always print the static shared memory region At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Sep 29 21:19:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 21:19:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413912.657885 (Exim 4.92) (envelope-from ) id 1oe0vj-0001kj-UJ; Thu, 29 Sep 2022 21:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413912.657885; Thu, 29 Sep 2022 21:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe0vj-0001kc-RV; Thu, 29 Sep 2022 21:18:51 +0000 Received: by outflank-mailman (input) for mailman id 413912; Thu, 29 Sep 2022 21:18:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe0vi-0001kS-Bt; Thu, 29 Sep 2022 21:18:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe0vi-0000lB-9G; Thu, 29 Sep 2022 21:18:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe0vh-0003ZR-Qt; Thu, 29 Sep 2022 21:18:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oe0vh-0006He-QV; Thu, 29 Sep 2022 21:18:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MgWpGRkOSv+xvAnHtYVouOfElNdVHFLThcap+KghIkE=; b=RtHliTZs89HLp9wKHtBhJPBBUD e+kwkVY40HdCDTvrW26V/64BV4By6hOkhwBwcsC6ACe3YC8z7m+v5x10TsCEPnbkZUlWQMOQvaHA1 VvWkG0xzRSyIRNquXDtvUu6wEUGGyHlr12yNL0k46i7VJIsrMXPljjamEL0ZCiNaJ3HY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 173363: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c8de6ec63d766ca1998c5af468483ce912fdc0c2 X-Osstest-Versions-That: qemuu=dbc4f48b5ab3e6d85f78aa4df6bd6ad561c3d152 From: osstest service owner Date: Thu, 29 Sep 2022 21:18:49 +0000 flight 173363 qemu-mainline real [real] flight 173371 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173363/ http://logs.test-lab.xenproject.org/osstest/logs/173371/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 173371-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173343 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173343 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173343 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173343 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173343 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173343 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 173343 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173343 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173343 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu c8de6ec63d766ca1998c5af468483ce912fdc0c2 baseline version: qemuu dbc4f48b5ab3e6d85f78aa4df6bd6ad561c3d152 Last test of basis 173343 2022-09-28 01:55:44 Z 1 days Testing same since 173363 2022-09-29 15:08:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Liu Alex Williamson Anthony PERARD Bin Meng Daniel P. Berrangé fanwenjie Helge Deller Ilya Leoshkevich Jameson Nash Jiaxun Yang Kunkun Jiang Laurent Vivier Michael Labiuk Michael S. Tsirkin Nicolin Chen Peter Maydell Richard Henderson Ruili Ji Stefan Hajnoczi Thomas Huth Xuzhou Cheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git dbc4f48b5a..c8de6ec63d c8de6ec63d766ca1998c5af468483ce912fdc0c2 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Sep 29 22:38:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 22:38:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413923.657902 (Exim 4.92) (envelope-from ) id 1oe2AU-0001uT-26; Thu, 29 Sep 2022 22:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413923.657902; Thu, 29 Sep 2022 22:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2AT-0001uM-VW; Thu, 29 Sep 2022 22:38:09 +0000 Received: by outflank-mailman (input) for mailman id 413923; Thu, 29 Sep 2022 22:38:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2AS-0001uC-3W; Thu, 29 Sep 2022 22:38:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2AR-00026G-VO; Thu, 29 Sep 2022 22:38:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2AR-0005eR-JT; Thu, 29 Sep 2022 22:38:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oe2AR-0000K3-J1; Thu, 29 Sep 2022 22:38:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZQRCgaeKNOnQWBGwSPm8bHqGK4pd+Hohul0U9/cEEM0=; b=tq7LKatvrYTE98vpg1ZzjwfLu8 XDXXotOcNjUcc7FmuCeOHmTr5FHtt+VnSgk68jEzHdwQBXeaxn/LQEESsLTlfDcnbaTRxoykw6kiq tV/koJFYZP7MEE/bdrF53ASgw+OBuLw3MmOr4WzxEFMXxhOXs9OEhTuAOmrTYWX2eX/Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173370: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Thu, 29 Sep 2022 22:38:07 +0000 flight 173370 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173370/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 173347 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 1 days Failing since 173362 2022-09-29 13:03:03 Z 0 days 3 attempts Testing same since 173367 2022-09-29 17:01:55 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand jobs: build-arm64-xsm fail build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Author: Anthony PERARD Date: Thu Sep 29 10:51:31 2022 +0100 automation: Information about running containers for a different arch Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit a210e94af38a957fcc99db01d2cfcc3039859445 Author: Michal Orzel Date: Mon Sep 19 20:37:37 2022 +0200 xen/arm: domain_build: Always print the static shared memory region At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Sep 29 23:02:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 23:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413931.657913 (Exim 4.92) (envelope-from ) id 1oe2YI-0005KI-21; Thu, 29 Sep 2022 23:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413931.657913; Thu, 29 Sep 2022 23:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2YH-0005KB-VE; Thu, 29 Sep 2022 23:02:45 +0000 Received: by outflank-mailman (input) for mailman id 413931; Thu, 29 Sep 2022 23:02:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2YF-0005K5-SV for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 23:02:44 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0964e26-404a-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 01:02:41 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8D5E35C00CD; Thu, 29 Sep 2022 19:02:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 29 Sep 2022 19:02:38 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 19:02:37 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0964e26-404a-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1664492558; x= 1664578958; bh=IK4PrtYlt6FvEILgVx+LXMjgInjbFPmYscTeYJuAF2k=; b=B 9FYF+x8IemmpwNug/0+PvLzlGj142TfSnr3GFIaTbQEEBVeAGSiXBQsyJCUBywQ6 DA1gf7WDSj5bCP1VwD7f1C9nrK3zoVs0t17lcksaa2NuzFjRAcRzlczrQ+e0bZKx SJZJbtH5X7oOnM7AXIsCuSsR7s0KQKKjHC7xJSHO95HN+kBUvPpa4p8Vtp4ZIqW2 iQRQrP/Hz5aaTUyDUx5wd1HJUT5KkbfUEezbRAtxScWhUFux1j+JJsD/RLFJnpY3 yt3EHXZuQXGJl8XImdkwRDa8AfNsOi8jxGfxiqrUBuM21w2CEtzrbZUs7xoD2eIu BU5pvDRNCENa+/RHjjMTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1664492558; x=1664578958; bh=IK4PrtYlt6FvEILgVx+LXMjgInjbFPmYscT eYJuAF2k=; b=BgAAD495EGOd59wToNbmIlyZc+H5Op0eAmRs3YQq09AIP9WKGj5 gEzKsOri8EQ/012E7gggifcBkirf7+UN66UYNn944kpkoPNguV9ZPmRwVdGwjkKF MPJ2w+s1nzG7ICpKRWeTfVzoDPjfG7kIkgXjZZo4vqLrjvEKMxYWj61HB7snTCw8 oSxHyUw0WpmPJ/Gj0NtrYGgdMqJR7K6uYwto7UjUaH/zIX2tgnR7al6h/xKbxpKY 9HHOVuuIgf9M27oekogmgGG96eyJZHoLi5+z9LfIiFIYklR5kLbBylJlXzGREWAX fWxM9MkrjRQB2L+TV/ofL0bHEQSCZ9xwFyw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehuddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: [PATCH v4 0/2] EFI improvements for Xen dom0 Date: Thu, 29 Sep 2022 19:02:02 -0400 Message-Id: X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This fixes EFI table processing in Xen dom0 and adds ESRT support in that configuration. Changes since v3: - Check location of all configuration tables, not just the ESRT. - Move most Xen-specific code to drivers/xen/. - Allow configuration tables to be in EFI_ACPI_RECLAIM_MEMORY. Demi Marie Obenour (2): Avoid using EFI tables Xen may have clobbered Support ESRT in Xen dom0 drivers/firmware/efi/efi.c | 8 ++++--- drivers/firmware/efi/esrt.c | 43 ++++++++++++++++++++++++++----------- drivers/xen/efi.c | 35 ++++++++++++++++++++++++++++++ include/linux/efi.h | 9 ++++++++ 4 files changed, 79 insertions(+), 16 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Thu Sep 29 23:02:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 23:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413932.657923 (Exim 4.92) (envelope-from ) id 1oe2YP-0005bG-8k; Thu, 29 Sep 2022 23:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413932.657923; Thu, 29 Sep 2022 23:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2YP-0005b7-64; Thu, 29 Sep 2022 23:02:53 +0000 Received: by outflank-mailman (input) for mailman id 413932; Thu, 29 Sep 2022 23:02:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2YO-0005ab-K4 for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 23:02:52 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d69ee175-404a-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 01:02:50 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E6E2C5C003D; Thu, 29 Sep 2022 19:02:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 29 Sep 2022 19:02:48 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 19:02:47 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d69ee175-404a-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664492568; x=1664578968; bh=mbINTmtX+Y203Gs79+//9ThUmGM7WPRVX3Y jlp+Pb+E=; b=vxd3Go1eRAYVPxf7nsO+YRDw1szNfJ8CzuPTeQNfwTfgiJlFIxI VvgDFfpaW5wMgxgS3D83epM+1HAHUJZGhZ9SFUZ6SSMI5p3FME/rjK0D/8IA3fKw 0h1itKzOloZ7akksTAd+m2krDesB5O5VqO3fgQScFXQH4fJx9BabnCSoduDqk1Rc wlMwY09jMfwZKKvn9dgSEDWudIqFS95I8JV6F4uUa/Sy+t8Cnwf4/xgHyy5dA9mI SDyG+W+hB5cUxOfHHsUSxmb0ufoDyitGCSejg0L5Ys4fqF+XWfE9gsUKmrjQj4/d lH1KjM+GJAqKXkWfwmN6bMcgnzekVLcfLWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664492568; x=1664578968; bh=mbINTmtX+Y203 Gs79+//9ThUmGM7WPRVX3Yjlp+Pb+E=; b=wG00Lo+VdSJSoiPuNxmPp/TGitdWe 6j6Ow3nEs7qDSSQ7r7av1J88lp+ABlJIKhc2EnPTKsgZ7fhYyaLqUgChpB4jVSJh KqT5bJSBPUXdJ8OU4mROTF4/R40c6TB+DIurEaTILCPrNi1ml/lfXqa2X0rOGPYT zHWU8M8zbXu6y5Benrbom8ZEEl6EN6nSer8C51hkr4bMuV37ii/QNDF+BJpAXjri yP0qFq3x++pbVvWrG29YYhfD38sqt/j8yNekJY3Gomz0AXCrDLpwPx78RLGatbec 2BaXzhOenHhP/Ll7mISZtmKOz2W5kqNqaQlORr/nKD1gZU4M9K64HrlrA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehuddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Date: Thu, 29 Sep 2022 19:02:03 -0400 Message-Id: X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DATA, EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by Xen before Linux gets to start using it. Therefore, Linux under Xen must not use EFI tables from such memory. Most of the remaining EFI memory types are not suitable for EFI tables, leaving only EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only use tables that are located in one of these types of memory. This patch ensures this, and also adds a function (xen_config_table_memory_region_max()) that will be used later to replace the usage of the EFI memory map in esrt.c when running under Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, but I have not implemented this. Signed-off-by: Demi Marie Obenour --- drivers/firmware/efi/efi.c | 8 +++++--- drivers/xen/efi.c | 35 +++++++++++++++++++++++++++++++++++ include/linux/efi.h | 9 +++++++++ 3 files changed, 49 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index e4080ad96089abd7f84745dd8461c548bcbb7685..d344f3ff73d1c5ed0c67e3251a9502e66719741d 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -574,7 +574,6 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, unsigned long table; int i; - pr_info(""); for (i = 0; i < count; i++) { if (!IS_ENABLED(CONFIG_X86)) { guid = &config_tables[i].guid; @@ -585,7 +584,6 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, if (IS_ENABLED(CONFIG_X86_32) && tbl64[i].table > U32_MAX) { - pr_cont("\n"); pr_err("Table located above 4GB, disabling EFI.\n"); return -EINVAL; } @@ -594,10 +592,14 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, table = tbl32[i].table; } +#ifdef CONFIG_XEN_EFI + if (efi_enabled(EFI_PARAVIRT) && !xen_config_table_memory_region_max(table)) + continue; +#endif + if (!match_config_table(guid, table, common_tables) && arch_tables) match_config_table(guid, table, arch_tables); } - pr_cont("\n"); set_bit(EFI_CONFIG_TABLES, &efi.flags); if (efi_rng_seed != EFI_INVALID_TABLE_ADDR) { diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c index d1ff2186ebb48a7c0981ecb6d4afcbbb25ffcea0..c2274ddfcc63304008ef0fd78fd9fa416f75d073 100644 --- a/drivers/xen/efi.c +++ b/drivers/xen/efi.c @@ -28,6 +28,7 @@ #include #include #include +#include #include @@ -271,6 +272,40 @@ static void xen_efi_reset_system(int reset_type, efi_status_t status, } } +__init u64 xen_config_table_memory_region_max(u64 addr) +{ + static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); + struct xen_platform_op op = { + .cmd = XENPF_firmware_info, + .u.firmware_info = { + .type = XEN_FW_EFI_INFO, + .index = XEN_FW_EFI_MEM_INFO, + .u.efi_info.mem.addr = addr, + .u.efi_info.mem.size = U64_MAX - addr, + } + }; + union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info; + int rc = HYPERVISOR_platform_op(&op); + + if (rc) { + pr_warn("Failed to lookup header %llu in Xen memory map: error %d\n", + (unsigned long long)addr, rc); + return 0; + } + + switch (info->mem.type) { + case EFI_RUNTIME_SERVICES_CODE: + case EFI_RUNTIME_SERVICES_DATA: + case EFI_ACPI_RECLAIM_MEMORY: + return info->mem.addr + info->mem.size; + default: + pr_warn("Table %llu is in memory of type %d, ignoring it\n", + (unsigned long long)addr, info->mem.type); + return 0; + } +} + /* * Set XEN EFI runtime services function pointers. Other fields of struct efi, * e.g. efi.systab, will be set like normal EFI. diff --git a/include/linux/efi.h b/include/linux/efi.h index d2b84c2fec39f0268324d1a38a73ed67786973c9..fc81e4b984398cdb399e7886b2cae7f33bf91613 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -1324,4 +1324,13 @@ struct linux_efi_coco_secret_area { /* Header of a populated EFI secret area */ #define EFI_SECRET_TABLE_HEADER_GUID EFI_GUID(0x1e74f542, 0x71dd, 0x4d66, 0x96, 0x3e, 0xef, 0x42, 0x87, 0xff, 0x17, 0x3b) +#ifdef CONFIG_XEN_EFI +/* + * Returns the end of the memory region containing the given config table, + * or 0 if the given address does not reside in memory that can validly + * contain EFI configuration tables. + */ +__init u64 xen_config_table_memory_region_max(u64 addr); +#endif + #endif /* _LINUX_EFI_H */ -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Thu Sep 29 23:02:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 29 Sep 2022 23:02:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413933.657935 (Exim 4.92) (envelope-from ) id 1oe2YQ-0005rS-Fp; Thu, 29 Sep 2022 23:02:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413933.657935; Thu, 29 Sep 2022 23:02:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2YQ-0005rH-D3; Thu, 29 Sep 2022 23:02:54 +0000 Received: by outflank-mailman (input) for mailman id 413933; Thu, 29 Sep 2022 23:02:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe2YP-0005K5-Nz for xen-devel@lists.xenproject.org; Thu, 29 Sep 2022 23:02:53 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d86dea90-404a-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 01:02:52 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E78175C00D0; Thu, 29 Sep 2022 19:02:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 29 Sep 2022 19:02:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 19:02:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d86dea90-404a-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1664492571; x=1664578971; bh=XZWfM4q7thLJRlIL5LnhobWSY3gDTnmsDKZ GlT+eoxU=; b=CDfcAP8wxrv+yGaGY/hgh8nOq8xIjHWFytgIF58pO3FJayIaXxB WeYKUZGE7d8fQfMSvaZuSFYKQ8fFxC4IdUIxWnKW9O4/ojiXtmTWTqS24+TzP35I ofRbuBpkds4F0EslcpT0IXbD3wHJB7KN5lSGHt3P5/y17f8RKHyJBG8vWt22dlqC FDmjfp6qqgtvBwDItPyFemGkb3w+xJo7DK2lEw444jsbfKaOoDcst8SEeMRg/Zkt gPst1/tk7hVJ4SRB02ktkYfO1Br0ZR+rxwwUhUIHtl9V4mB8Qrsu9rChOcczf3l2 JkwrCMD+K2cq8kodNdqjD8BLNkWnbf9Gw+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1664492571; x=1664578971; bh=XZWfM4q7thLJR lIL5LnhobWSY3gDTnmsDKZGlT+eoxU=; b=Vl6NCdiZc+gz2Ku60HaxtUtPNiwBb URRhV82z1PM/85XgMqFqjDLuGhS0OTCzjlkUzFphL515COHxZNNHMUshccNa3vSb LQ5URwP15JvAS5TzO6MlkIFhncp9hoKnRwy8i6IDrRMpGltkqUbAAqlXNfhy7/5k FccgNXMpJAd1A/fffa6p/pZiS+kh1jGAIINf2Uh+bA9UZYaE/3JbKuvjR6awcKgd g3CLbVNm3IdpMRZ8sV4jdbb9Q/6SiIF/vKWk8sJT4qIFidKm+Grlo2b2wJ3JMYHZ T+eQ5xzVkJSNtEku5+wnExs+PqBcH4fPaNNm5AesR/Y1jMQY1dlK1WdkA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehuddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: [PATCH v4 2/2] Support ESRT in Xen dom0 Date: Thu, 29 Sep 2022 19:02:04 -0400 Message-Id: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fwupd requires access to the EFI System Resource Table (ESRT) to discover which firmware can be updated by the OS. Currently, Linux does not expose the ESRT when running as a Xen dom0. Therefore, it is not possible to use fwupd in a Xen dom0, which is a serious problem for e.g. Qubes OS. Before Xen 4.17, this was not fixable due to hypervisor limitations. The UEFI specification requires the ESRT to be in EfiBootServicesData memory, which Xen will use for whatever purposes it likes. Therefore, Linux cannot safely access the ESRT, as Xen may have overwritten it. Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData memory, Xen replaces the ESRT with a copy in memory that it has reserved. Such memory is currently of type EFI_RUNTIME_SERVICES_DATA, but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. This ensures that the ESRT can safely be accessed by the OS. When running as a Xen dom0, use the new xen_config_table_memory_region_max() function to determine if Xen has reserved the ESRT and, if so, find the end of the memory region containing it. This allows programs such as fwupd which require the ESRT to run under Xen, and so makes fwupd support in Qubes OS possible. Signed-off-by: Demi Marie Obenour --- drivers/firmware/efi/esrt.c | 43 ++++++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 2a2f52b017e736dd995c69e8aeb5fbd7761732e5..a0642bc161b4b1f94f818b8c9f46511fe2424bb2 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -243,27 +243,44 @@ void __init efi_esrt_init(void) void *va; struct efi_system_resource_table tmpesrt; size_t size, max, entry_size, entries_size; - efi_memory_desc_t md; - int rc; phys_addr_t end; - - if (!efi_enabled(EFI_MEMMAP)) - return; + u32 type; pr_debug("esrt-init: loading.\n"); if (!esrt_table_exists()) return; - rc = efi_mem_desc_lookup(efi.esrt, &md); - if (rc < 0 || - (!(md.attribute & EFI_MEMORY_RUNTIME) && - md.type != EFI_BOOT_SERVICES_DATA && - md.type != EFI_RUNTIME_SERVICES_DATA)) { - pr_warn("ESRT header is not in the memory map.\n"); + if (efi_enabled(EFI_MEMMAP)) { + efi_memory_desc_t md; + + if (efi_mem_desc_lookup(efi.esrt, &md) < 0 || + (!(md.attribute & EFI_MEMORY_RUNTIME) && + md.type != EFI_BOOT_SERVICES_DATA && + md.type != EFI_RUNTIME_SERVICES_DATA)) { + pr_warn("ESRT header is not in the memory map.\n"); + return; + } + + type = md.type; + max = efi_mem_desc_end(&md); +#ifdef CONFIG_XEN_EFI + } else if (efi_enabled(EFI_PARAVIRT)) { + max = xen_config_table_memory_region_max(efi.esrt); + /* + * This might be wrong, but it doesn't matter. + * xen_config_table_memory_region_max() checks the type + * of the memory region, and if it returns 0, the code + * below will fail without looking at the type. Choose + * a value that will not cause * subsequent code to try + * to reserve the memory containing the ESRT, as either + * Xen or the firmware has done so already. + */ + type = EFI_RUNTIME_SERVICES_DATA; +#endif + } else { return; } - max = efi_mem_desc_end(&md); if (max < efi.esrt) { pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n", (void *)efi.esrt, (void *)max); @@ -333,7 +350,7 @@ void __init efi_esrt_init(void) end = esrt_data + size; pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end); - if (md.type == EFI_BOOT_SERVICES_DATA) + if (type == EFI_BOOT_SERVICES_DATA) efi_mem_reserve(esrt_data, esrt_data_size); pr_debug("esrt-init: loaded.\n"); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Sep 30 00:06:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 00:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413956.657957 (Exim 4.92) (envelope-from ) id 1oe3Xk-0005UU-K7; Fri, 30 Sep 2022 00:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413956.657957; Fri, 30 Sep 2022 00:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3Xk-0005UN-HM; Fri, 30 Sep 2022 00:06:16 +0000 Received: by outflank-mailman (input) for mailman id 413956; Fri, 30 Sep 2022 00:06:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3Xi-0005UD-Oq; Fri, 30 Sep 2022 00:06:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3Xi-0004Ic-MJ; Fri, 30 Sep 2022 00:06:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3Xi-0007tW-Dk; Fri, 30 Sep 2022 00:06:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oe3Xi-00030R-DA; Fri, 30 Sep 2022 00:06:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=yy+dUFVMF/t5TsC8QgU58o0M7+ZireSy+nHw5HA/Rl8=; b=JWCRKiAoSB+dhWAisLjkzrkJik 2oUJGnghV8gnZ03el/L2miJv7F7QZ0C1Hb6FIYtMd9e2IdsL2Jnx225S2q1kdfv1nQ85xDOBTP70Y tyJEPAfvFjJ65h2Do3oRFsNyJJoM/FcHgOaFQlOyxu70zGEOEtnIFfTQdHfJS22f/43Y=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable-smoke bisection] complete build-arm64-xsm Message-Id: From: osstest service owner Date: Fri, 30 Sep 2022 00:06:14 +0000 branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-arm64-xsm testid xen-build Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: c4e5cc2ccc5b8274d02f7855c4769839989bb349 Bug not present: 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173377/ commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build --summary-out=tmp/173377.bisection-summary --basis-template=173347 --blessings=real,real-bisect,real-retry xen-unstable-smoke build-arm64-xsm xen-build Searching for failure / basis pass: 173370 fail [host=rochester0] / 173347 [host=rochester1] 173342 [host=rochester1] 173333 ok. Failure / basis pass flights: 173370 / 173333 Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Basis pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5e936d11b171793c174686268c9c1df8a4fa974c Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#5e936d11b171793c174686268c9c1df8a4fa974c-fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Loaded 5001 nodes in revision graph Searching for test results: 173373 pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9982fe275ba4ee1a749b6dde5602a5a79e42b543 173362 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a 173365 pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5e936d11b171793c174686268c9c1df8a4fa974c 173366 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a 173368 pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 e1de23b7c1bfa02447a79733e64184b3635e0587 173367 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f 173369 pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9982fe275ba4ee1a749b6dde5602a5a79e42b543 173372 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c4e5cc2ccc5b8274d02f7855c4769839989bb349 173370 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f 173374 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c4e5cc2ccc5b8274d02f7855c4769839989bb349 173376 pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9982fe275ba4ee1a749b6dde5602a5a79e42b543 173377 fail b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c4e5cc2ccc5b8274d02f7855c4769839989bb349 173333 pass b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5e936d11b171793c174686268c9c1df8a4fa974c 173342 [host=rochester1] 173347 [host=rochester1] Searching for interesting versions Result found: flight 173333 (pass), for basis pass For basis failure, parent search stopping at b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9982fe275ba4ee1a749b6dde5602a5a79e42b543, results HASH(0x55d736404278) HASH(0x55d736414c98) HASH(0x55d7364189a8) For basis failure, parent search stopping at b746458e1ce1bec85e58b458386f8b7a0bedfaa6 e1de23b7c1bfa02447a79733e64184b3635e0587, results HASH(0x55d73640b428) For basis failure, parent search stopping at b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5e936d11b171793c174686268c9c1df8a4fa974c, results HASH(0x\ 55d73640c950) HASH(0x55d736421170) Result found: flight 173362 (fail), for basis failure (at ancestor ~575) Repro found: flight 173365 (pass), for basis pass Repro found: flight 173367 (fail), for basis failure 0 revisions at b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9982fe275ba4ee1a749b6dde5602a5a79e42b543 No revisions left to test, checking graph state. Result found: flight 173369 (pass), for last pass Result found: flight 173372 (fail), for first failure Repro found: flight 173373 (pass), for last pass Repro found: flight 173374 (fail), for first failure Repro found: flight 173376 (pass), for last pass Repro found: flight 173377 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: c4e5cc2ccc5b8274d02f7855c4769839989bb349 Bug not present: 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173377/ commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/build-arm64-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 173377: tolerable ALL FAIL flight 173377 xen-unstable-smoke real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/173377/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-arm64-xsm 6 xen-build fail baseline untested jobs: build-arm64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Fri Sep 30 00:16:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 00:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413963.657969 (Exim 4.92) (envelope-from ) id 1oe3hW-00078P-LS; Fri, 30 Sep 2022 00:16:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413963.657969; Fri, 30 Sep 2022 00:16:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3hW-00078I-HM; Fri, 30 Sep 2022 00:16:22 +0000 Received: by outflank-mailman (input) for mailman id 413963; Fri, 30 Sep 2022 00:16:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3hV-000788-CR; Fri, 30 Sep 2022 00:16:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3hV-0004Ts-7V; Fri, 30 Sep 2022 00:16:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe3hU-00087a-PM; Fri, 30 Sep 2022 00:16:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oe3hU-0004tw-Os; Fri, 30 Sep 2022 00:16:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fXoFNjneieN7lN/xqWV8pBoNbfIoarTd+FgwQafeayQ=; b=dj3VMCENnchONjo9/GWHFmua8n ButuGoiBEUr9jPK2oaZ1r1kHNIK35nBE9upxgkhQgHGkJb1tPX/gem2RClLGXyiFybThMveqO3wvB NYt+8ElMz9Pyz3Nx1V65k4y2RK6oamvPVSq7wyaqI1IZFCCpGP8Vvkm5RpOGZQGtn/+k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173364: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=511cce163b75bc3933fa3de769a82bb7e8663f2b X-Osstest-Versions-That: linux=c3e0e1e23c70455916ff3472072437b3605c6cfe From: osstest service owner Date: Fri, 30 Sep 2022 00:16:20 +0000 flight 173364 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173364/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173360 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173360 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173360 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173360 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 173360 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173360 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173360 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173360 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173360 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 511cce163b75bc3933fa3de769a82bb7e8663f2b baseline version: linux c3e0e1e23c70455916ff3472072437b3605c6cfe Last test of basis 173360 2022-09-28 19:42:17 Z 1 days Testing same since 173364 2022-09-29 15:40:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Couzens Alexander Wetzel Andy Moreton Benjamin Poirier Bjørn Mork Damien Le Moal Daniel Golle David S. Miller Dmitry Torokhov Edward Cree Felix Fietkau Florian Fainelli Frank Wunderlich George Kuruvinakunnel Hangyu Hua Hans de Goede Huacai Chen Jacob Kroon Jakub Kicinski Jason Wang Jeff LaBundy Jimmy JS Chen Johannes Berg John Garry Jun Yi Junxiao Chang Lech Perczak Linus Torvalds Looi, Hong Aun Lorenzo Bianconi Lukas Bulwahn Lukas Wunner Maciej Fijalkowski Marc Kleine-Budde Marek Szyprowski Mark Pearson Martin Kepplinger Mat Martineau Menglong Dong Niklas Cassel Paolo Abeni Patrick Rohr Paweł Lenkow Peilin Ye Peng Wu Radhey Shyam Pandey Rafael Mendonca ruanjinjie Sasha Levin Sebastian Krzyszkowiak Tamizh Chelvam Raja Tony Nguyen Vladimir Oltean Wang Yufen Yang Yingliang Yanteng Si jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git c3e0e1e23c70..511cce163b75 511cce163b75bc3933fa3de769a82bb7e8663f2b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Sep 30 01:41:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 01:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413972.657980 (Exim 4.92) (envelope-from ) id 1oe51N-0006LF-Rv; Fri, 30 Sep 2022 01:40:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413972.657980; Fri, 30 Sep 2022 01:40:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe51N-0006L7-N5; Fri, 30 Sep 2022 01:40:57 +0000 Received: by outflank-mailman (input) for mailman id 413972; Fri, 30 Sep 2022 01:40:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe51M-0006KC-Kg for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 01:40:56 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e923dd09-4060-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 03:40:49 +0200 (CEST) Received: from DU2P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::14) by AS2PR08MB9073.eurprd08.prod.outlook.com (2603:10a6:20b:5fd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 01:40:47 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::d1) by DU2P251CA0004.outlook.office365.com (2603:10a6:10:230::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 01:40:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 01:40:46 +0000 Received: ("Tessian outbound ce981123c49d:v128"); Fri, 30 Sep 2022 01:40:46 +0000 Received: from b2432e3c2801.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5194CCC3-2CFE-4053-9746-DECB8C1803CD.1; Fri, 30 Sep 2022 01:40:39 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2432e3c2801.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 01:40:39 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DU0PR08MB9155.eurprd08.prod.outlook.com (2603:10a6:10:416::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 30 Sep 2022 01:40:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Fri, 30 Sep 2022 01:40:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e923dd09-4060-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IAlHIPUh9VXr9pv1OX+pqiwmCzvyOvKl02/jhlqujytW7JqycJOX6ZYCCUoDx1d9CfuVgSaEcs3Zuv3JolPdUqJ5J3rme9zQXIwRuAif/K4vPA67tSh6mt5SyBOpfs5y7Wwa3wILLuklB2RvLaryy/cgVEkyvXiy5w2DTfDoEXwexIINtFQqwbJc/MSEA6PaRl43UMpyb1XQIelKbfDIPpj4itMzagyovu2psAMYvBhFbWisUdDPZxqYaW3LDpE16S0OYCJjh8/5dk6rg8yQVPyWfx1NZ2jlM+kfkzxm8ieyNqBR/UbMFnmYowwbNshV/d/Q6xjdWOVjtFsJEsw5iA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0tYdRF1uMknpB0KEvfUZ1am4t4d6QbYvKcLNfle6uc=; b=nbFVVT4pFAh2cuhCCvaFFumMUOghMfJX+IHrqsM/jvFg8QTvC3BP3YDs/ZWbu9Wl19gdIjZLxwXlful4zq/4ZL0Rtq3vwAFcNNU61J/tRbAU/sAO1rHe/vPg+21OA2F8KhpROTzq5kDhj8JPyQ+Iz4QET/isirZfyE8OyzpULmRwPyV6NSYDPvTUdwoZjfZulqnZlxv2ADoOWYA3+vw3aug/s4+za64qdNDwgKi4xChClkbbYH9zZ89wBiRxdiZ28DbIl/ukXSeYveWkjay2Dsoy76BHNRyjyQcxu+OvUgmxboQbGXPZ2M1oq15iYwwg8Ngl47xzkE8s4g7SV8Q1iw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0tYdRF1uMknpB0KEvfUZ1am4t4d6QbYvKcLNfle6uc=; b=yZi6V61AOrLnTpfTDKzmohWMUc97ODCzkYjIzDnpUFUN3wk1EPNcgvPUbaS+M+Nq2pkZfk2FICW27cHZv0hupmzLx0igqV6aOx2YAPyC8yuWvgoQ4q3k9ZBC/SIrp5UZ4L98wY/IG3TpqsgfhdHmYcggtqYAoOJf7CNUIKkMihU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TnS0oYYDMoVzeBwDxHW6IplaSWK6BsFmSv6gQlPr2w/UIJ3UjCosNpGCjCUfjEMuCnqfyAnV2QabJiQzSeI0yqZtiaW5NLjv826K9zF1qvKKvLYzQfPPJVgAtcLeyfwNBwh2MO8VcGd0fMmXJk3z7DEq3UIBtmPkqP+ifPHugK2nfPOuoHUVJ/RbjQW4BnK+ZwRj5eNtpUba+WbuBrpz1xplmoy1Kk5tNu8PlUUR37U21rp/aTUbQYfE/53vLwtwUxoqUQ9OKSOrGRM+VnehpVyeO6Z4d6FGWSU037LW/w/d7XI4SBw6Jt3E0aQypFXhPq2ujrSNNla3hjHC8Au8vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0tYdRF1uMknpB0KEvfUZ1am4t4d6QbYvKcLNfle6uc=; b=GOVCAOqlytqcbjUn85dz60ZLNrUZZwWeVMdLWWhQha6wICUxr6J1R5Y04DB5YGSe1xKfCjXB0nfuRcR0FU2jgd/JtyqZAv0R5v+dLefcA0R5iORjHzx8q4gDZQ2haCpsVkjniluOq1p9wXmV3pdeDQLyocCGTZ5729IlF1ErPEVysFRejnd4lVEcTJ/dcF5Km51hexQNzLj0QerrE+iFbkjcCaOCGxYs/w6NxIVpi5t0ldgsOlgHMCT9Q506puua3+e8tZArZ7ao/0/JUWiU/XYaduINxQQ1+Jyp7m6bk+nj0yN1RSmHXfSmAOdIQw6R6xGkP1v0CBGzNN378qQxkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0tYdRF1uMknpB0KEvfUZ1am4t4d6QbYvKcLNfle6uc=; b=yZi6V61AOrLnTpfTDKzmohWMUc97ODCzkYjIzDnpUFUN3wk1EPNcgvPUbaS+M+Nq2pkZfk2FICW27cHZv0hupmzLx0igqV6aOx2YAPyC8yuWvgoQ4q3k9ZBC/SIrp5UZ4L98wY/IG3TpqsgfhdHmYcggtqYAoOJf7CNUIKkMihU= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Topic: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Index: AQHYzNExhaWvtVxVf06aoC2sQxI0u63zd60AgAKngwCAAEMigIAA3nNw Date: Fri, 30 Sep 2022 01:40:36 +0000 Message-ID: References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-6-wei.chen@arm.com> <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com> <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com> In-Reply-To: <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F4017657489D804FADC1EB523F820560.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DU0PR08MB9155:EE_|DBAEUR03FT038:EE_|AS2PR08MB9073:EE_ X-MS-Office365-Filtering-Correlation-Id: d31b5ffb-51d2-4da8-5474-08daa284cbea x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pZ1s/wvvBkm2C+pZS+mXL6WR1ZFihla4rWMgPFowZxYAK6k81TBXnUXmto8J4bMrHr0wrLVXTyFNBkzy9g+Yh8sAt9MpCem7wIsfalaMNvPYjKR/xtGvp//8/DOiJ9ovzb3lMa6C9WBcD/6ZPH+UNjqn62S13HG/E+v+LV2VOkYMbiKN69ElXv216agFmdWlyxFqepjlcTLn56W8T5GHSwgw47UENYg+Ap+10tJFQ31rQdOzSOfbkMlDRy/4cU7DhiXa/aMGwiU3KptyVXGIzaDbm8iQhAVpD/iUqZbcGWtYYBz4/Uo2dds8TRUT6AYe7+01LT2gry15zvLKqr44aNLYUWsT9Dcf0X9JKcMEkxcQ1YjAEreGz0yoWL6bFq76LltndLg3VXmIqYcH4nWlUORrNJSo/lrzuOQ2/kwx+fvHTkXtdLMybhvA1Er/cmPW8Dtu5TOeq/BKoJHmSURq2+qyg6TOgTbuu2L+Pof2//twjzWGomqXOj41LHBCBzJQ+382iVEC8341pEpjBw4D2Zh512ikcgAXESZ0gjdf+kz2Ih9gqwb948SEZhihQ3xGE/ye2RztjnX17+O41z7/9w8gRNt5vOwlOLYKFVXxGdrNBSw6kBMWrnqCeP/OaIKF24wN2iFk4iuMoniqXy0jINoPaKlfVwRVdv0XeZSYJnNfI29Gka5+kAE1Ooj3XAmWSM/8XpezN8yTHG0RC8HS9ZSGxeN5MoQNhVgrpJAm43b6ev0G+oNq9ijemRRc2nuO X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199015)(54906003)(316002)(6916009)(7696005)(52536014)(86362001)(8936002)(41300700001)(33656002)(186003)(8676002)(66946007)(66476007)(76116006)(66556008)(64756008)(4326008)(66446008)(53546011)(6506007)(2906002)(5660300002)(9686003)(83380400001)(55016003)(38070700005)(478600001)(71200400001)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9155 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba54014a-978d-4dd7-398b-08daa284c5d8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rvzqxzoAuyAlyA4w1JgRxmXVNr0AklbMuH0gOFv7wXjZcAPdd/2d3d3i6tah5kUS3/RZf5A6Jn/Ljt3NyleA8tboqp1kGmBBoebSNJ45avY6YUrRqtjQBBtJjT3NPCpVM7GnoG3anepMEpwlzHVjDmMuHyTjXqKC9p5uDex/ol2eUPceLaUpjEr/LLBt4tYA83gQuuAky7W7u++VwZf1ath8N2w1whTBqifvA0Bvx+I+pracXUyVWHWjOKbYHfnt5wsgI5hMiRnKIxt79/z7yoXJodpYI9F9PuNDYHv/pcYgWS9DErzb/LJmGgjdHWN+r9PftkiY4jTHygsDXo1Wrtqo3kaCDNere/lJX0BGoFGnegpScAZURba2LFsES1qhzniLDeGrr3w8p+TN8FXP073IqRRUcLNIRGKvtmm19dcXxCIFoHFe5xBY+Lyby7JLvERPQgf0wzWtXn1Y5Joa7CVe0f8CRwXzs61K/GeJmhxql/ZhjxpmntZlwlTqR/nOTvKHuTtXhj9oX4k7TiRenw0OzLsTAvp6CHAf6Xy26WwmZvUW1HVdYu/Ajri7DvnStGSe5JDPLQxzHau5aGeILoEke4nGPixrgaGR4/sIOeiTGBw+Lql0B/aGPO6TNEHaljUA4UAE+BVWDF6KjbMTv+2FIidqyJG8X8OSzvfMt+W0M9DNtOMWovi4NumJGxwtusSkgzIuDiOkxHeZEjIxV7bPmYjJjKsbd8Q24ZMQzDJA7branm2Bfb/nVlBFKarfVYn7JFmYMw6nWtJ4CN0l9Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(47076005)(2906002)(26005)(6862004)(8936002)(33656002)(52536014)(70586007)(70206006)(9686003)(41300700001)(53546011)(36860700001)(8676002)(4326008)(86362001)(336012)(54906003)(40460700003)(6506007)(7696005)(186003)(5660300002)(316002)(478600001)(55016003)(81166007)(40480700001)(83380400001)(356005)(82310400005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 01:40:46.6861 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d31b5ffb-51d2-4da8-5474-08daa284cbea X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9073 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIgyOeaXpSAyMDoyMQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjUgNS82XSB4ZW4veDg2OiBtb3ZlIE5VTUEgc2NhbiBub2RlcyBjb2RlcyBmcm9tIHg4Ng0K PiB0byBjb21tb24NCj4gDQo+IE9uIDI5LjA5LjIwMjIgMTA6MjEsIFdlaSBDaGVuIHdyb3RlOg0K PiA+IE9uIDIwMjIvOS8yNyAyMzo0OCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+IE9uIDIwLjA5 LjIwMjIgMTE6MTIsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4gLS0tIGEveGVuL2RyaXZlcnMvYWNw aS9LY29uZmlnDQo+ID4+PiArKysgYi94ZW4vZHJpdmVycy9hY3BpL0tjb25maWcNCj4gPj4+IEBA IC03LDQgKzcsNSBAQCBjb25maWcgQUNQSV9MRUdBQ1lfVEFCTEVTX0xPT0tVUA0KPiA+Pj4NCj4g Pj4+ICAgY29uZmlnIEFDUElfTlVNQQ0KPiA+Pj4gICAJYm9vbA0KPiA+Pj4gKwlzZWxlY3QgSEFT X05VTUFfTk9ERV9GV0lEDQo+ID4+PiAgIAlzZWxlY3QgTlVNQQ0KPiA+Pg0KPiA+PiBXaGlsZSBJ IG1pZ2h0IGd1ZXNzIHRoYXQgeW91J3ZlIGNob3NlbiB0aGUgaW5zZXJ0aW9uIHBvaW50IHRvIGhh dmUNCj4gPj4gdGhpbmdzIHNvcnRlZCBhbHBoYWJldGljYWxseSwgSSB0aGluayBoZXJlIGl0IHdv dWxkIGJlIG1vcmUgbmF0dXJhbA0KPiA+PiB0byBzZWxlY3QgdGhlIHdpZGVyIG9wdGlvbiBmaXJz dCBhbmQgdGhlbiBhbHNvIHNlbGVjdCB0aGUgbW9yZQ0KPiA+PiBuYXJyb3cgb25lLg0KPiA+Pg0K PiA+DQo+ID4gT2ssIEkgd2lsbCBhZGp1c3QgdGhlIG9yZGVyLg0KPiA+DQo+ID4+IE9uZSBmdXJ0 aGVyIHF1ZXN0aW9uIHRob3VnaDogSG93IGlzIHRoaXMgZ29pbmcgdG8gd29yayBmb3IgQXJtNjQN Cj4gPj4gb25jZSBpdCB3YW50cyB0byBzdXBwb3J0IGJvdGggdGhlIGZvcm0gb2YgTlVNQSB5b3Un cmUgd29ya2luZyB0bw0KPiA+PiBlbmFibGUgX2FuZF8gQUNQSS1iYXNlZCBOVU1BPyBUaGVyZSBi ZXR0ZXIgd291bGRuJ3QgYmUgYSByZXF1aXJlbWVudA0KPiA+PiB0byBwaWNrIG9uZSBvZiB0aGUg dHdvIGF0IGJ1aWxkIHRpbWUgLSBpdCB3b3VsZCBiZSBuaWNlIGZvciBzdXBwb3J0DQo+ID4+IG9m IGJvdGggZm9ybXMgdG8gYmUgYWJsZSB0byBjby1leGlzdCBpbiBhIHNpbmdsZSBiaW5hcnkuDQo+ ID4NCj4gPiBXZSBhcmUgYWxzbyB3b3JraW5nIGluIHRoaXMgd2F5LiBJbiBwYXJ0IzMsIHdlIHdp bGwgY2hlY2sgQUNQSSBmaXJzdCwNCj4gPiBvbmx5IHdoZW4gQUNQSSBpcyBvZmYsIHRoZSBEVCBO VU1BIHdpbGwgYmUgdXNlZCBieSBBcm0uIElmIEFDUEkgaXMgb24sDQo+ID4gd2Ugd2lsbCBza2lw IERUIE5VTUEuDQo+IA0KPiBFdmVuIG1vcmUgc28gYW4gYW5zd2VyIHRvIG15IHF1ZXN0aW9uIHdv dWxkIGJlIG5pY2U6IFlvdSdsbCB0aGVuIGhhdmUNCj4gQ09ORklHX0hBU19OVU1BX05PREVfRldJ RD15IGV2ZW4gb24gQXJtICh1c2luZyBQWE0gYXMgbWFuZGF0ZWQgYnkgQUNQSQ0KPiB3aGVuIGlu IEFDUEkgbW9kZSkuIEJ1dCB0aGVuIHdoYXQncyB0aGUgRldJRCBmb3IgRFQ/IEkga25vdyBpdCB3 YXMgbWUNCj4gdG8gc3VnZ2VzdCB0aGlzIGJ1aWxkIHRpbWUgZGlzdGluY3Rpb24sIGJ1dCBJJ20g YWZyYWlkIEkgd2Fzbid0IGRvaW5nDQo+IG11Y2ggZ29vZCB3aXRoIHRoYXQgKGFuZCBJJ20gc29y cnkpLg0KDQpIb3cgYWJvdXQgaW50cm9kdWNpbmcgYSBmbGFnIGZvciBzZWxlY3RlZCBOVU1BIGlt cGxlbWVudGF0aW9uIHRvDQpzZXQgaXQgaW4gcnVudGltZT8NCkZvciBleGFtcGxlOg0KYm9vbCBu dW1hX2hhc19md19ub2RlaWQ7DQoNCkFDUEkgTlVNQSB3aWxsIHNldCB0aGlzIGZsYWcgdG8gMSwg YnV0IDAgZm9yIERUIE5VTUEuDQoNCkNoZWVycywNCldlaSBDaGVuIA0KDQo+IA0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 30 01:46:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 01:46:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413977.657991 (Exim 4.92) (envelope-from ) id 1oe56F-00073J-BY; Fri, 30 Sep 2022 01:45:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413977.657991; Fri, 30 Sep 2022 01:45:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe56F-00073C-8t; Fri, 30 Sep 2022 01:45:59 +0000 Received: by outflank-mailman (input) for mailman id 413977; Fri, 30 Sep 2022 01:45:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe56D-000733-Rr for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 01:45:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ffd302d-4061-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 03:45:56 +0200 (CEST) Received: from AM5PR0602CA0012.eurprd06.prod.outlook.com (2603:10a6:203:a3::22) by PAXPR08MB7600.eurprd08.prod.outlook.com (2603:10a6:102:23f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 01:45:40 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::db) by AM5PR0602CA0012.outlook.office365.com (2603:10a6:203:a3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 01:45:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 01:45:39 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Fri, 30 Sep 2022 01:45:38 +0000 Received: from c60807f225ed.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D7EF0F20-6BD0-49E5-BF29-3268CD2D2F52.1; Fri, 30 Sep 2022 01:45:33 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c60807f225ed.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 01:45:33 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DBBPR08MB6153.eurprd08.prod.outlook.com (2603:10a6:10:20e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 30 Sep 2022 01:45:31 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Fri, 30 Sep 2022 01:45:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ffd302d-4061-11ed-964a-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=F94RCtdB+kJr0FyeDwQ6rNS9UgaVHWfXJdyn1Yo2VpQfihJ1pQ+kUcBirsO4HLIGrHP94pJMH2Wvz2BxkrOCNwc0GeET4HD7pspxnPc05oMvOxNZoUZyrkDBoyqO+xgZq/kyXMS7gCBa4RRE1SleW630VnrvJnSiWUpHLYGOVa6yMyIJNPl16N3uQnuJBJz12qRXRQPLqFiSjRA3g4EomDCfb07k42Q+/rsJuNoOVof5uBrR9Y+6Z9FIJ3HBs8cdgUag7/2C7cawJHl1JZCzR51q3L3pUeFfZM0QQ9fxkC7w9DTbhw9qtiNav6bweR7y+vGmY5T9E1m5U88sg+SkTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZAEitwMsMioq+jgAgQnYyC/ecnmIWHIZugmig0g7+8=; b=IpsgJGdAlDLuY1nusz6r9t9d8hO0FPpc7mP/6Z9MQb4PFePErf2VpljO34KgQ5GJ2UkytCE/UkVkbVKHdu9y3wRxDjHwe2tv9JSZY1OyoTOkmlvPH8tSndHwU2SXKthq8wYwnNW3JOiT58QCgybz6/VBEs9oeJfASozRqg4ULImhKi3kIZXB0NXcm24iMKrJ4WdB2MVPDjSqQ5a7qK19j6wEGHi8cHf58kV61ZEj6cqAWCS4UYHhnAcSDPro0PWnm9f11x9BcxouUu6UMxEaFXoX+muBn7Goe9MfgSFNO64L5BXID4keNT8aJc6wNKNrEkvT8mILiuNcn8egXXvhbg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZAEitwMsMioq+jgAgQnYyC/ecnmIWHIZugmig0g7+8=; b=fFHO5jMgJbLKxRMTuU2sJpDOkJ0iDe6Sww6C7wNsInUA1OiMEOUuyHNf6k/mkKFaQK3Ay0b0O7q4vwA4aPOKFmLruoapjnQjQM+K+NIePhRhoCC4lIsvi9dnIvx+IRw1m8rAm7+F3nEEeVoQ5DGGY+k4CTUg/ma2YT8n5n/H2C0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DMlIF1jSABlRT6hhFH1pdSCG3LVApvrEG+Q/K/gw/snY3BX0YB+e6oNFx+KwCprEmgzz4BrWAxa6vHqFSJ9VF3KUt/T+LfslHAQtMfrYc68BDPaq8ezTIQNFLYOSbc+8Q1ZfbNkMYpw5BikszOoTCwCi738fY09G/Vgh/4pllMqzqPukpz6EBQ7URvCq8CCIrOnb91y0RUbQwveZoWCAo+HpY0mb+1A+RpvAtk5hSq+yllzS1mN/sCfH6L/EWxKgBXfITM1417YR1MeT94XIVGpM9gN/P9j+TO4rWqUlf2/wZMwGChQ23bDkI64KrzKFZ0clJJQPQx1RIGUeWwnXKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZAEitwMsMioq+jgAgQnYyC/ecnmIWHIZugmig0g7+8=; b=Qgjl57/WCN08TPGOgNw0CgJnQQMPjPCuqbPOwaj/47tcETe+BX1o0Q1ed2/rn7s6869CE9N5IT6hZJdjKpifz/Z4BNjxPc2udyK6KVSWja0AwjbTKlQ8fOHOsmyx2DU5lzd+EJ+I4zTUrr4yALYCUmZByI5b0oYl7zsZUWomjezEPhVUkYbQfHv352oBVv0A5uFhKgCYQ+BNJ9C897copqsyJvNajxMv7TDO/udjg0tfQ6YNQYb/P5KmFo3ZJ59PdVvFJvBui0wlLvMdTusEZjK93HHEMGP6bmou9LrDxMNJb7jagjrGI0lcgOK560yY6G07uIXj7TXoad/KsevLbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZAEitwMsMioq+jgAgQnYyC/ecnmIWHIZugmig0g7+8=; b=fFHO5jMgJbLKxRMTuU2sJpDOkJ0iDe6Sww6C7wNsInUA1OiMEOUuyHNf6k/mkKFaQK3Ay0b0O7q4vwA4aPOKFmLruoapjnQjQM+K+NIePhRhoCC4lIsvi9dnIvx+IRw1m8rAm7+F3nEEeVoQ5DGGY+k4CTUg/ma2YT8n5n/H2C0= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Thread-Topic: [PATCH v5 2/6] xen/x86: move generically usable NUMA code from x86 to common Thread-Index: AQHYzNEmJs18WyT35kWq9bNIXVbTQ63y+hyAgAMalwCAAEusAIAA4YSw Date: Fri, 30 Sep 2022 01:45:31 +0000 Message-ID: References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-3-wei.chen@arm.com> <359e87d9-aec7-2198-86ab-1d0f76bf567d@suse.com> <72691b9b-761e-a89b-97df-afd5cf0ddebb@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 723DE3EA7D5B6143AEE4F82FD2DE8C57.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DBBPR08MB6153:EE_|VE1EUR03FT012:EE_|PAXPR08MB7600:EE_ X-MS-Office365-Filtering-Correlation-Id: ec4d504e-35ea-4308-8e0d-08daa2857a6f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 368gDz3DIt1DBRJ+YXpi9maZHm1e/uo8MV5agoFxfFkrOWhwueh/T6wK/OaYOUSP/Dp6WY76wz1cV/7lGzCH9e+aV+VPLrW4y9mDAmxszHA6zO6dMplN8DWV8Z2DThzWvgQ0rIeoY17JEicmYaIa7ndykEEEt2U2LhP2RWcS9/qfHfpTkMxZ5hGt3piENB2ox7hvaI7zQTVTuBEFsXuiEF7LbqXkFJuRVs5kA26oUGUamdO+hFk/25S9664DICWrpSYMUdTK+UNZBhDdaFl4YU7ED8hFrlUUx56oo0qfO0VwFqHCg0FEtMmtoVjktl3v7AupuUhrGKMDJGYPYV2ZctXiPOfM7vEVIrysC4ocA2cmOVz1wBaLnIKwlSrQa2XUOHFYJUlHnuaGZBiKII7fCkIEHf+K4Iz6wB+R4oX0DNxHUAu5breLHNr+0PN+wes+Wmis0PmjOTk/Hs+JxFBG7uRZU+BRAwQ1FAGlMPeZZHabTu7bONoSdQUHtVl9lTmov/qb+9E9CkmzkVGBshJZ5otAixGCCf8DAQnYaicZWHr+uz3+q8y2Yw86kLpWvH9RD8aOM3UMgsfYUaG75TiFTsSGBsGB8X+IeFN4yWB9WXRX0IjaxQWV/elhKF6jQTqgYtsoQ+A+5Tj+SooiB82sLeJQpHW4pV1cHu6MFcvUgdU3L/nHGOodlia2R3GDBFmPY4A7YpKtkPE0un6Hi0PFtnQX6CuyNL3ddvF+d3mj4F6aIgMzBUvsUl82yJ42TgbrJUQAbFRhKDTtORcoiuK7cQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199015)(38100700002)(33656002)(38070700005)(86362001)(122000001)(83380400001)(186003)(2906002)(55016003)(71200400001)(53546011)(7696005)(6506007)(478600001)(9686003)(54906003)(8676002)(5660300002)(41300700001)(316002)(6916009)(52536014)(66446008)(64756008)(66946007)(4326008)(76116006)(66476007)(66556008)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6153 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 78d8d145-464c-408c-9a2b-08daa28575a8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6oeihYaunJDmBrj6k5STvnXyZPXt743TNPueD4GZgpSOTpBQ6Q7PT6N+LQ737b5aXvo0U8/xN9PaLSzxgRotihwZKIXS/aO2c/melpd1xPr8cVtVJPU7X9ROJvy0GN7b1KawbgjsRsJBYMZc8XEHyYznFBzGvRZMF2p7qc3Cr3JJOjbDurzjmyM6dyuwUMk0QQSV/H9sYbJo/cKsNocED1Zrs/dMTDz+jCwd5fubKLm68BGbs5yBcuWUE7YPrgPrYViCXQ0YTRdixLaH724KxTNQwmJ4qSLyC9XFeyQgtqbSh1mAZn8yzJQTpSH1bNDjRteBop6j8o/xdQuG0118gNJgGLMpStqnCtWtm8DyJkGPh9yMOLsFqtXV7m5EqTL60OiqCwO3Yl07x+Ctdi62Op5fxYEHvjNfZyroUlJ7PJe8mEcIKZQ0BGMBm+B8PUSoQon04ng/uweP46AvWPoZJj82/dr/e1DLpvIFBVbBD4aiXnZZAbVhzmwMJs4WQf71Ao88ShZig94frXVCBZKB81gEOQ9MhIQknU11ITAo64Z2jukj37oWN9SYn2Tbkq/QPcDw2KKAz8Eg/rAKngWWjUrcQblNG38hd9H+0KJUnRlRa6zH7VJZSkI7cubPwtHla6JsIwZA4A9omp4gJ/sTwSHpt7j7EPlL0P1IQGIxbjPWceHH6UjMZ5NmsSDoh2NygYX1Wu0YeLM1CimPoAWcSxqguWlfXvM407u43SMV5C9z4JOrtIIOKrDWNcTXbnTHB28l2hKATVwrxTqsvj+5xQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(81166007)(356005)(82740400003)(40460700003)(55016003)(86362001)(316002)(33656002)(5660300002)(83380400001)(8936002)(2906002)(6862004)(70586007)(52536014)(40480700001)(54906003)(4326008)(41300700001)(8676002)(70206006)(7696005)(82310400005)(186003)(47076005)(6506007)(478600001)(336012)(53546011)(9686003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 01:45:39.3265 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec4d504e-35ea-4308-8e0d-08daa2857a6f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7600 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIgyOeaXpSAyMDoxNA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjUgMi82XSB4ZW4veDg2OiBtb3ZlIGdlbmVyaWNhbGx5IHVzYWJsZSBOVU1BIGNvZGUNCj4g ZnJvbSB4ODYgdG8gY29tbW9uDQo+IA0KPiBPbiAyOS4wOS4yMDIyIDA5OjQzLCBXZWkgQ2hlbiB3 cm90ZToNCj4gPiBPbiAyMDIyLzkvMjcgMTY6MTksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+PiBP biAyMC4wOS4yMDIyIDExOjEyLCBXZWkgQ2hlbiB3cm90ZToNCj4gPj4+ICsgICAgICAgIG5vZGVz X3VzZWQrKzsNCj4gPj4+ICsgICAgICAgIGlmICggZXBkeCA+IG1lbXRvcCApDQo+ID4+PiArICAg ICAgICAgICAgbWVtdG9wID0gZXBkeDsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4gKw0KPiA+Pj4gKyAg ICBpZiAoIG5vZGVzX3VzZWQgPD0gMSApDQo+ID4+PiArICAgICAgICBpID0gQklUU19QRVJfTE9O RyAtIDE7DQo+ID4+DQo+ID4+IElzIHRoaXMgYWN0dWFsbHkgZ29pbmcgdG8gYmUgY29ycmVjdCBm b3IgYWxsIGFyY2hpdGVjdHVyZXM/IEFpdWkNCj4gPj4gQXJtNjQgaGFzIG9ubHkgdXAgdG8gNDgg cGh5c2ljYWwgYWRkcmVzcyBiaXRzLCBidXQgd2hhdCBhYm91dCBhbg0KPiA+PiBhcmNoaXRlY3R1 cmUgYWxsb3dpbmcgdGhlIHVzZSBvZiBhbGwgNjQgYml0cz8gSSB0aGluayBhdCB0aGUgdmVyeQ0K PiA+PiBsZWFzdCB3ZSB3YW50IEJVSUxEX0JVR19PTihQQUREUl9CSVRTID49IEJJVFNfUEVSX0xP TkcpIGhlcmUuDQo+ID4+DQo+ID4NCj4gPiBPayBJIHdpbGwgYWRkIGFib3ZlIEJVSUxEX0JVR19P Ti4gQW5kIEkgYWxzbyBoYXZlIHF1ZXN0aW9uIHdoeSBjYW4ndA0KPiA+IHdlIHVzZSBQQUREUl9C SVRTIGhlcmUgZGlyZWN0bHk/DQo+IA0KPiBXZWxsLCBpZiB5b3UgdXNlZCBQQUREUl9CSVRTLCB0 aGVuIHlvdSB3b3VsZCB1c2UgaXQgd2l0aG91dCBzdWJ0cmFjdGluZw0KPiAxLCBhbmQgeW91J2Qg YmUgaW4gdHJvdWJsZSBhZ2FpbiB3aGVuIFBBRERSX0JJVFMgPT0gQklUU19QRVJfTE9ORy4gV2hh dA0KPiBtYXkgYmUgcG9zc2libGUgdG8gZG8gaW5zdGVhZCBvZiBCVUlMRF9CVUdfT04oKSBpcw0K PiANCj4gICAgIGlmICggbm9kZXNfdXNlZCA8PSAxICkNCj4gICAgICAgICBpID0gbWluKFBBRERS X0JJVFMsIEJJVFNfUEVSX0xPTkcgLSAxKTsNCj4gDQoNClRoaXMgb25lIHNlZW1zIGJldHRlciwg SSB3aWxsIGZvbGxvdyBpdC4NCg0KPiA+Pj4gKyAgICBlbHNlDQo+ID4+PiArICAgICAgICBpID0g ZmluZF9maXJzdF9iaXQoJmJpdGZpZWxkLCBzaXplb2YodW5zaWduZWQgbG9uZykgKiA4KTsNCj4g Pj4+ICsNCj4gPj4+ICsgICAgbWVtbm9kZW1hcHNpemUgPSAobWVtdG9wID4+IGkpICsgMTsNCj4g Pj4NCj4gPj4gQWdhaW4gcGVyaGFwcyB0aGUgc3ViamVjdCBvZiBhIHNlcGFyYXRlIHBhdGNoOiBJ c24ndCB0aGVyZSBhbiBvZmYtYnktMQ0KPiA+PiBtaXN0YWtlIGhlcmU/IG1lbXRvcCBpcyB0aGUg bWF4aW11bSBvZiBhbGwgZXBkeC1lcywgd2hpY2ggYXJlDQo+ID4+IGNhbGN1bGF0ZWQgdG8gYmUg dGhlIGZpcnN0IFBEWCBmb2xsb3dpbmcgdGhlIHJlZ2lvbi4gSGVuY2UgSSdkIGV4cGVjdA0KPiA+ Pg0KPiA+PiAgICAgIG1lbW5vZGVtYXBzaXplID0gKChtZW10b3AgLSAxKSA+PiBpKSArIDE7DQo+ ID4+DQo+ID4+IGhlcmUuIEkgZ3Vlc3MgSSdsbCBtYWtlIHBhdGNoZXMgZm9yIGJvdGggaXNzdWVz LCB3aGljaCB5b3UgbWF5IHRoZW4NCj4gPj4gbmVlZCB0byByZS1iYXNlIG92ZXIuDQo+ID4+DQo+ ID4NCj4gPiBUaGFua3MsIEkgd2lsbCB3YWl0IHlvdXIgcGF0Y2hlcy4NCj4gDQo+IEFscmVhZHkg c2VudCBvdXQgeWVzdGVyZGF5Lg0KPiANCg0KT2suDQoNCj4gPj4+ICtzdGF0aWMgdm9pZCBjZl9j aGVjayBkdW1wX251bWEodW5zaWduZWQgY2hhciBrZXkpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBz X3RpbWVfdCBub3cgPSBOT1coKTsNCj4gPj4+ICsgICAgdW5zaWduZWQgaW50IGksIGosIG47DQo+ ID4+PiArICAgIHN0cnVjdCBkb21haW4gKmQ7DQo+ID4+PiArICAgIGNvbnN0IHN0cnVjdCBwYWdl X2luZm8gKnBhZ2U7DQo+ID4+PiArICAgIHVuc2lnbmVkIGludCBwYWdlX251bV9ub2RlW01BWF9O VU1OT0RFU107DQo+ID4+PiArICAgIGNvbnN0IHN0cnVjdCB2bnVtYV9pbmZvICp2bnVtYTsNCj4g Pj4+ICsNCj4gPj4+ICsgICAgcHJpbnRrKCInJWMnIHByZXNzZWQgLT4gZHVtcGluZyBudW1hIGlu Zm8gKG5vdyA9ICUiUFJJX3N0aW1lIilcbiIsDQo+IGtleSwNCj4gPj4+ICsgICAgICAgICAgIG5v dyk7DQo+ID4+PiArDQo+ID4+PiArICAgIGZvcl9lYWNoX29ubGluZV9ub2RlICggaSApDQo+ID4+ PiArICAgIHsNCj4gPj4+ICsgICAgICAgIHBhZGRyX3QgcGEgPSBwZm5fdG9fcGFkZHIobm9kZV9z dGFydF9wZm4oaSkgKyAxKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgICAgIHByaW50aygiTk9ERSV1 IHN0YXJ0LT4lbHUgc2l6ZS0+JWx1IGZyZWUtPiVsdVxuIiwNCj4gPj4+ICsgICAgICAgICAgICAg ICBpLCBub2RlX3N0YXJ0X3BmbihpKSwgbm9kZV9zcGFubmVkX3BhZ2VzKGkpLA0KPiA+Pj4gKyAg ICAgICAgICAgICAgIGF2YWlsX25vZGVfaGVhcF9wYWdlcyhpKSk7DQo+ID4+PiArICAgICAgICAv KiBTYW5pdHkgY2hlY2sgcGh5c190b19uaWQoKSAqLw0KPiA+Pj4gKyAgICAgICAgaWYgKCBwaHlz X3RvX25pZChwYSkgIT0gaSApDQo+ID4+PiArICAgICAgICAgICAgcHJpbnRrKCJwaHlzX3RvX25p ZCglIlBSSXBhZGRyIikgLT4gJWQgc2hvdWxkIGJlICV1XG4iLA0KPiA+Pj4gKyAgICAgICAgICAg ICAgICAgICBwYSwgcGh5c190b19uaWQocGEpLCBpKTsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4gKw0K PiA+Pj4gKyAgICBqID0gY3B1bWFza19maXJzdCgmY3B1X29ubGluZV9tYXApOw0KPiA+Pj4gKyAg ICBuID0gMDsNCj4gPj4+ICsgICAgZm9yX2VhY2hfb25saW5lX2NwdSAoIGkgKQ0KPiA+Pj4gKyAg ICB7DQo+ID4+PiArICAgICAgICBpZiAoIGkgIT0gaiArIG4gfHwgY3B1X3RvX25vZGVbal0gIT0g Y3B1X3RvX25vZGVbaV0gKQ0KPiA+Pj4gKyAgICAgICAgew0KPiA+Pj4gKyAgICAgICAgICAgIGlm ICggbiA+IDEgKQ0KPiA+Pj4gKyAgICAgICAgICAgICAgICBwcmludGsoIkNQVSV1Li4uJXUgLT4g Tk9ERSVkXG4iLCBqLCBqICsgbiAtIDEsDQo+IGNwdV90b19ub2RlW2pdKTsNCj4gPj4+ICsgICAg ICAgICAgICBlbHNlDQo+ID4+PiArICAgICAgICAgICAgICAgIHByaW50aygiQ1BVJXUgLT4gTk9E RSVkXG4iLCBqLCBjcHVfdG9fbm9kZVtqXSk7DQo+ID4+PiArICAgICAgICAgICAgaiA9IGk7DQo+ ID4+PiArICAgICAgICAgICAgbiA9IDE7DQo+ID4+PiArICAgICAgICB9DQo+ID4+PiArICAgICAg ICBlbHNlDQo+ID4+PiArICAgICAgICAgICAgKytuOw0KPiA+Pj4gKyAgICB9DQo+ID4+PiArICAg IGlmICggbiA+IDEgKQ0KPiA+Pj4gKyAgICAgICAgcHJpbnRrKCJDUFUldS4uLiV1IC0+IE5PREUl ZFxuIiwgaiwgaiArIG4gLSAxLA0KPiBjcHVfdG9fbm9kZVtqXSk7DQo+ID4+PiArICAgIGVsc2UN Cj4gPj4+ICsgICAgICAgIHByaW50aygiQ1BVJXUgLT4gTk9ERSVkXG4iLCBqLCBjcHVfdG9fbm9k ZVtqXSk7DQo+ID4+PiArDQo+ID4+PiArICAgIHJjdV9yZWFkX2xvY2soJmRvbWxpc3RfcmVhZF9s b2NrKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcHJpbnRrKCJNZW1vcnkgbG9jYXRpb24gb2YgZWFj aCBkb21haW46XG4iKTsNCj4gPj4+ICsgICAgZm9yX2VhY2hfZG9tYWluICggZCApDQo+ID4+PiAr ICAgIHsNCj4gPj4+ICsgICAgICAgIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcygpOw0KPiA+Pj4g Kw0KPiA+Pj4gKyAgICAgICAgcHJpbnRrKCJEb21haW4gJXUgKHRvdGFsOiAldSk6XG4iLCBkLT5k b21haW5faWQsDQo+IGRvbWFpbl90b3RfcGFnZXMoZCkpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICAg ICAgZm9yX2VhY2hfb25saW5lX25vZGUgKCBpICkNCj4gPj4+ICsgICAgICAgICAgICBwYWdlX251 bV9ub2RlW2ldID0gMDsNCj4gPj4NCj4gPj4gSSdkIGJlIGluY2xpbmVkIHRvIHN1Z2dlc3QgdG8g dXNlIG1lbXNldCgpIGhlcmUsIGJ1dCBJIHdvbid0IGluc2lzdA0KPiA+PiBvbiB5b3UgZG9pbmcg dGhpcyAib24gdGhlIGZseSIuIEFsb25nIHdpdGggdGhpcyB3b3VsZCBsaWtlbHkgZ28gdGhlDQo+ ID4+IHJlcXVlc3QgdG8gbGltaXQgdGhlIHNjb3BlIG9mIHBhZ2VfbnVtX25vZGVbXSAoYW5kIHRo ZW4gcGVyaGFwcyBhbHNvDQo+ID4+IHZudW1hIGFuZCBwYWdlKS4NCj4gPj4NCj4gPg0KPiA+IG1l bXNldCBmb3IgcGFnZV9udW1fbm9kZSBtYWtlcyBzZW5zZSwgSSB3aWxsIGRvIGl0IGJlZm9yZQ0K PiA+IGZvcl9lYWNoX2RvbWFpbiAoIGQgKS4NCj4gDQo+IFRoYXQgd29uJ3QgYmUgcmlnaHQgLSBh cnJheSBlbGVtZW50cyBuZWVkIGNsZWFyaW5nIG9uIGV2ZXJ5IGl0ZXJhdGlvbi4NCj4gUGx1cyAu Li4NCj4gDQoNCk9oLCBZZXMuDQoNCj4gPiBBYm91dCBsaW1pdCB0aGUgc2NvcGUsIGRpZCB5b3Ug bWVhbiwgd2Ugc2hvdWxkIG1vdmU6DQo+ID4NCj4gPiAiY29uc3Qgc3RydWN0IHBhZ2VfaW5mbyAq cGFnZTsNCj4gPiB1bnNpZ25lZCBpbnQgcGFnZV9udW1fbm9kZVtNQVhfTlVNTk9ERVNdOw0KPiA+ IGNvbnN0IHN0cnVjdCB2bnVtYV9pbmZvICp2bnVtYTsiDQo+ID4NCj4gPiB0byB0aGUgYmxvY2sg b2YgZm9yX2VhY2hfZG9tYWluICggZCApPw0KPiANCj4gLi4uIHRoaXMgbGltaXRpbmcgb2Ygc2Nv cGUgKHllcyB0byB5b3VyIHF1ZXN0aW9uKSB3b3VsZCBhbHNvIGNvbmZsaWN0DQo+IHdpdGggdGhl IG1vdmVtZW50IHlvdSBzdWdnZXN0LiBJdCBpcyBhY3R1YWxseSAoYW1vbmcgb3RoZXIgdGhpbmdz KQ0KPiBzdWNoIGEgbWlzdGFrZW4gbW92ZW1lbnQgd2hpY2ggdGhlIG1vcmUgbmFycm93IHNjb3Bl IGlzIGludGVuZGVkIHRvDQo+IHByZXZlbnQuDQo+IA0KDQpUaGFua3MsDQpXZWkgQ2hlbg0KDQo+ IEphbg0K From xen-devel-bounces@lists.xenproject.org Fri Sep 30 02:03:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 02:03:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413984.658002 (Exim 4.92) (envelope-from ) id 1oe5Mz-0001TP-SJ; Fri, 30 Sep 2022 02:03:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413984.658002; Fri, 30 Sep 2022 02:03:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe5Mz-0001TI-PQ; Fri, 30 Sep 2022 02:03:17 +0000 Received: by outflank-mailman (input) for mailman id 413984; Fri, 30 Sep 2022 02:03:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe5My-0001TC-7I for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 02:03:16 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0af8761f-4064-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 04:03:14 +0200 (CEST) Received: from DB6PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:6:2d::19) by DB9PR08MB9827.eurprd08.prod.outlook.com (2603:10a6:10:460::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 02:03:12 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::e8) by DB6PR07CA0009.outlook.office365.com (2603:10a6:6:2d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 02:03:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 02:03:11 +0000 Received: ("Tessian outbound 7e4a920b87c0:v128"); Fri, 30 Sep 2022 02:03:11 +0000 Received: from 978746b0b2c0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AAB31E6B-6D28-4B49-A19A-527454D04EEE.1; Fri, 30 Sep 2022 02:03:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 978746b0b2c0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 02:03:05 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS2PR08MB8288.eurprd08.prod.outlook.com (2603:10a6:20b:557::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 02:03:04 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::6f9a:a2b6:e5d3:349e%7]) with mapi id 15.20.5676.017; Fri, 30 Sep 2022 02:03:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0af8761f-4064-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KGTYM85lprnTuWLTQqCEVCC5nHoZbK/w6pAyA2O8AG/xKo3I2qryJA6purGSAiG/4eyJp6+kIlCpggAgRPrFZk4IlIAiEn+Z+ALgw/nfqECadZgjt1e+brRw3p662q6bKVoyVyfpVA0K9w+H3lpFZ5es5iTPstHTsM5Q8g9O9VVRQInAv4CbYEzWNGwlnwgcOu44mccrUvm/CVwLC4wDiweaqZlx5XrRrg4eKRNplmSvbGba6PyyEB30WoDvybD3LfmUkAWyBJug8VZNn11fSj4Txp4tRwXg/UBzs/wIjZieVIuOg0BPzCYK0snuCx37HeKeUdUr7CuimpMG/e4NLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUIrSkDojgIsAMGB4NZOMta2ZWq8pre8E8cSdPjMHLU=; b=j+4Oiml/TLIygP+R1W8n6ZHVmrLfT8dYStpLNzogzM8PJIlZ0zHguQ9i9BTMXRuQ8aaVHtbrhgMSRpGi+KYHS3WsGO4P+IUgn30H0rBSQGg5C5rr+V7iEJCL081PJi55TJ3/QT6XhJIVbMXY7glxckHce7vYXi2/hRJjsIasqtOR0mHxSbiVN2pWvi0Dr3Ohz/g7xFfZuzitemVBFBXlI7C5hMKReW7nMG3nxo5NAiuH1St4/6sPwQ9LDq42D6Vw7Qm5oNjmRg2f1f3LjYdHnYRMq+6XcotThEdd0qr6nVyo3emsb/tpI1bUvPKbwfNWR0KUfIYdYyTPkegKDTtiPg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUIrSkDojgIsAMGB4NZOMta2ZWq8pre8E8cSdPjMHLU=; b=HdBwm7mZZApWfHdPzGbbNTPlaKpiz25Zb7+srhvcK5Kfnk7xE+t4lrj+FpRXkORcdXDA8oxHqduAjmMYqwMsrzVQZHi42LAF7CJFEKJVlAVcC9jr6iXsfEXFNTXzJvXGDx+Vx+l4nqdGWHIZg6M0in1iVwLH451hfrnBPA7GHb4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LthxgXcQbw5QHZvE10jFllByKjwJfQXh9/lCU4Md7F95pB+BnpjlT7Fka94BRYlIBpe5FSDLb3Ran8inr1VBM/PDyzVWwhXFCq/BgN/ViXpTJtHwmabTc4pgbCW9Y8a4fHOcOMAUHOwk2qXjxJ6YiD1YSDcvQmoQOlK+ZfJVVn4amXWfRJNNjei7QVW53f/bFBIY4x4aFRXosPuvNV2mvd5S/EIU0xeuXWoCcy5eewgZYajr0BN4SpSwUt7TnWXks7c8bXkiQOMvSmC+KLx1NnDkbRGTCvNv9yPjsjwBxd+JDom8jBGBYdiZwSbUgBmBZLiR7W4hAor4RBP1m90Adw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUIrSkDojgIsAMGB4NZOMta2ZWq8pre8E8cSdPjMHLU=; b=VfBBte5k7PCoy5ZIsIqGa22gWvPG3XL0P7+tO2TUoCuJDEHbX4D9o8On3+t1PpSyidpLsgpQkgQPpHPS7Kuy6J6jm0tXCz6EdQA6Rk53o3TivkAnsdrPw9qm0/iusBJmFkzm2DYsDL4PtOBKuZo+z11q+rDeB7QU5PpS0Q+L9+Jp7LKeK+DseAhp8WNnH3BU1JzIOGPDRhn3+8SIV1sj8AOv7+8PelIr+qL1I/0W+4/AV0RD1+P13DYXLr9ArNYbmiicZmqsyvAKr3vdTfkz2tD6uP1W7YGkoNEzUWzBQJVTSPQBPPl0p6PLBGJtzDjZhqDVm1kEB+QJ8fOwev4KmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUIrSkDojgIsAMGB4NZOMta2ZWq8pre8E8cSdPjMHLU=; b=HdBwm7mZZApWfHdPzGbbNTPlaKpiz25Zb7+srhvcK5Kfnk7xE+t4lrj+FpRXkORcdXDA8oxHqduAjmMYqwMsrzVQZHi42LAF7CJFEKJVlAVcC9jr6iXsfEXFNTXzJvXGDx+Vx+l4nqdGWHIZg6M0in1iVwLH451hfrnBPA7GHb4= From: Wei Chen To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [PATCH] x86/NUMA: correct off-by-1 in node map size calculation Thread-Topic: [PATCH] x86/NUMA: correct off-by-1 in node map size calculation Thread-Index: AQHY0nuHFsNZDqjVQEGO++a4qSB4Ua33PGOQ Date: Fri, 30 Sep 2022 02:03:04 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 555C03A4ACB96E448546ECF8F2E899FA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS2PR08MB8288:EE_|DBAEUR03FT046:EE_|DB9PR08MB9827:EE_ X-MS-Office365-Filtering-Correlation-Id: 1455d7fa-dc43-4250-2025-08daa287ed9f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1iLzZtggbvxfNA3n+wkGBfAa+jasieGn4k/EgniVcsyP3YA2ipGb6mjS1bt6UEsh1RzIuSX0O7gTY3AQz7vjpi9tc6ca9lZDhfJLvi3J1evPPJEQnmGYYWkWWlKI1OagWBwUia9YkYzdSv0cZdKYA40IK4rnYPjvriJwepuSJTz+Q/8flh4r2pAIkFNjdB4nfC7xYrR3dwxVrOF51boEGO51LVg2CS2aznn1NYI9R3WY7KqxKK5BfvHL/X56amsTEmx3YU3ncNPjA0mVuWxQ1gL6hH/LgnYwGjZlzDi7WMaOnQ7J7RtOW7paPqJQRCNOutGBXJDhv8lwUegoGSteUkTpGTQYhqcGZ1kS3JzQcyvD7TFlLrpSH26oZyGgAZHjI7oVx9lJ/DC0bU76ohvmolG2C5RDMfFgsb81blamVyjDdFMQXz5/0cFC0DTjcAVQmTn3iz0E7DGTc6qjPoSrdJp9m9J6Hyx4lNUPnETDBKv2HBBHDs2TFPsReJ801v8A4WmB0g6DnJlpfXA6i1DuOZlIBG2GcDeaT5oK/Py5walCglLAoYtPtoXV4z9eBmZV15piKz5uGe0O2EXt3kAAGdeV3/YkYWjoCsk9986H4AHJpcc4zW75XIh7eqH3V6rSg2lj5PBNUzO+XVnbbYvYnUtPQHTqz6AgnEcbiDTNwntFJzp10hjC+TmQVYR2WPtaxsCkRxVDhcjglyV1OhsyoMzuVLy03SNepYWjv5MLb2DhkIvflsyzYiq0BSfb/oSwuxWsY6QvrvzMpXvhJgHXlg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(451199015)(8936002)(5660300002)(52536014)(316002)(6506007)(76116006)(66946007)(54906003)(53546011)(86362001)(66556008)(7696005)(4326008)(64756008)(41300700001)(8676002)(110136005)(66446008)(66476007)(83380400001)(55016003)(71200400001)(38070700005)(38100700002)(122000001)(33656002)(478600001)(186003)(2906002)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8288 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e10c119b-04e9-4ef6-e0b4-08daa287e94e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +9BdM/KzjJRqOQDXD27u3Gsy5nb969EzNls5GwZjVPNHAKXFnen1roWKENL2DJ/SKWwbHrqoeab18M9nopd2DkSDw5miNRwlxSMGT9SLpvgDQE8+93/KOtodbLNLVETjCgPLaML4ErMgYY5vjJGEr29vyxGxdzxfaXtZMQsymireXF9ty/REquyzBW49ggFxFY91HIXqGhsQOzh7WjSwp/xXPzUzXXkeyYv8rxS4ioFotqmOqnRg9Ae3vrSM21UWSLvcI8n6RIeMzGxur5NSFC1k8MLIeeXUuoittCDNpad9Z2WV65gl8GOcz8s7dU90HBxVjeVXGfz+CiwvTv4m0KTeQtf2NfRaKtblVdQG/P4jmyY/Og3bEG6GeEr1RiO5MZuwg7V88zCkrufhhg54p0c8vsuSN4/x9YI4iHnF1BLfFqLZGNNKISbPfLm3QVFKzgbgSuiEKeckVYrDQOOZLZk+TKMB7Mm/nX0UjxyUTYhurqHKsYcvbwGDHK0qFVaS31rTARxydrn3TwvKa0r1ogze23N+Hmb+t3jHcCj6XotPT16X7qYVBsLSskqegDwBHMAlr1NfT0/yHKhzJk3fQTu2c7WNk+CkY2yeu7udQVFFRMhNLxXRxb2VGAd4Lpod25rBYtaUYbs2ztzy4tBobN+FbL5Q0n08oxBV9Yop7k96C1rI8iSc6djm545vcwb0Jc1oQSXbYJj9sPG8TQaK3jvLmsQImweseWPrkVRXoFMxTSqEjAr1tunDZtM/990CtjTQMRHc9WGoEVzu4TMaBg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(54906003)(86362001)(36860700001)(110136005)(5660300002)(52536014)(33656002)(8936002)(356005)(83380400001)(7696005)(26005)(53546011)(40480700001)(2906002)(70206006)(70586007)(55016003)(82740400003)(6506007)(107886003)(41300700001)(316002)(478600001)(336012)(81166007)(82310400005)(47076005)(9686003)(8676002)(186003)(40460700003)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 02:03:11.7103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1455d7fa-dc43-4250-2025-08daa287ed9f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9827 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhlbi1kZXZl bCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZiBK YW4NCj4gQmV1bGljaA0KPiBTZW50OiAyMDIy5bm0OeaciDI35pelIDIyOjE0DQo+IFRvOiB4ZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgUm9nZXINCj4gUGF1IE1v bm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFtQQVRDSF0geDg2L05VTUE6 IGNvcnJlY3Qgb2ZmLWJ5LTEgaW4gbm9kZSBtYXAgc2l6ZSBjYWxjdWxhdGlvbg0KPiANCj4gZXh0 cmFjdF9sc2JfZnJvbV9ub2RlcygpIGFjY3VtdWxhdGVzICJtZW10b3AiIGZyb20gYWxsIFBEWGVz IG9uZSBwYXN0DQo+IHRoZSBjb3ZlcmVkIHJhbmdlcy4gSGVuY2UgdGhlIG1heGltdW0gYWRkcmVz cyB3aGljaCBjYW4gdmFsaWRseSBieSB1c2VkDQo+IHRvIGluZGV4IHRoZSBub2RlIG1hcCBpcyBv bmUgYmVsb3cgdGhpcyB2YWx1ZSwgYW5kIHdlIG1heSBjdXJyZW50bHkgc2V0DQo+IHVwIGEgbm9k ZSBtYXAgd2l0aCBhbiB1bnVzZWQgKGFuZCBuZXZlciBpbml0aWFsaXplZCkgdHJhaWxpbmcgZW50 cnkuIEluDQo+IGJvdW5kYXJ5IGNhc2VzIHRoaXMgbWF5IGFsc28gbWVhbiB3ZSBkeW5hbWljYWxs eSBhbGxvY2F0ZSBhIHBhZ2Ugd2hlbg0KPiB0aGUgc3RhdGljICg2NC1lbnRyeSkgbWFwIHdvdWxk IHN1ZmZpY2UuDQo+IA0KPiBXaGlsZSB0aGVyZSBhbHNvIGNvcnJlY3QgdGhlIGNvbW1lbnQgYWhl YWQgb2YgdGhlIGZ1bmN0aW9uLCBmb3IgaXQgdG8NCj4gbWF0Y2ggdGhlIGFjdHVhbCBjb2RlOiBM aW51eCBjb21taXQgNTQ0MTM5MjdmMDIyICgieDg2LTY0Og0KPiB4ODZfNjQtbWFrZS10aGUtbnVt YS1oYXNoLWZ1bmN0aW9uLW5vZGVtYXAtYWxsb2NhdGlvbiBmaXggZml4IikgcmVtb3ZlZA0KPiB0 aGUgT1JpbmcgaW4gb2YgdGhlIGVuZCBhZGRyZXNzIGJlZm9yZSB3ZSBhY3R1YWxseSBjbG9uZWQg dGhlaXIgY29kZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4NCj4gLS0tDQo+IFJlYWxseSB0aGUgc2hpZnQgdmFsdWUgbWF5IGVuZCB1cCBuZWVk bGVzc2x5IHNtYWxsIHdoZW4gdGhlcmUncw0KPiBkaXNjb250aWd1b3VzIG1lbW9yeS4gV2l0aGlu IGEgZ2FwLCBhbnkgYWRkcmVzcyBjYW4gYmUgdGFrZW4gZm9yIHRoZQ0KPiBub2RlIGJvdW5kYXJ5 LCBhbmQgaGVuY2UgbmVpdGhlciB0aGUgZW5kIG9mIHRoZSBsb3dlciByYW5nZSBub3IgdGhlDQo+ IHN0YXJ0IG9mIHRoZSBoaWdoZXIgcmFuZ2UgbmVjZXNzYXJpbHkgaXMgdGhlIGJlc3QgYWRkcmVz cyB0byB1c2UuIEZvcg0KPiBleGFtcGxlIHdpdGggdGhlc2UgdHdvIG5vZGUgcmFuZ2VzIChudW1i ZXJzIGFyZSBmcmFtZSBhZGRyZXNzZXMpDQo+IA0KPiBbMTAwMDAsMTdmZmZdDQo+IFsyODAwMCwy ZmZmZl0NCj4gDQo+IHdlJ2QgY2FsY3VsYXRlIHRoZSBzaGlmdCBhcyAxNSB3aGVuIDE2IG9yIGV2 ZW4gMTcgKGJlY2F1c2UgdGhlIHN0YXJ0IG9mDQo+IHRoZSAxc3QgcmFuZ2UgY2FuIGFsc28gYmUg aWdub3JlZCkgd291bGQgZG8uIEkgaGF2ZW4ndCB0cmllZCB0byBwcm9wZXJseQ0KPiBwcm92ZSBp dCB5ZXQsIGJ1dCBpdCBsb29rcyB0byBtZSBhcyBpZiB0aGUgdG9wIGJpdCBvZiB0aGUgWE9SIG9m IGxvd2VyDQo+IHJhbmdlIChpbmNsdXNpdmUpIGVuZCBhbmQgaGlnaGVyIHJhbmdlIHN0YXJ0IHdv dWxkIGJlIHdoYXQgd291bGQgd2FudA0KPiBhY2N1bXVsYXRpbmcgKG9mIGNvdXJzZSByZXF1aXJp bmcgdGhlIGVudHJpZXMgdG8gYmUgc29ydGVkLCBvciB0byBiZQ0KPiBwcm9jZXNzZWQgaW4gYWRk cmVzcyBvcmRlcikuIFRoaXMgd291bGQgdGhlbiAibmF0dXJhbGx5IiBleGNsdWRlIGxvd2VzdA0K PiByYW5nZSBzdGFydCBhbmQgaGlnaGVzdCByYW5nZSBlbmQuDQo+IA0KPiAtLS0gYS94ZW4vYXJj aC94ODYvbnVtYS5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9udW1hLmMNCj4gQEAgLTExMCw3ICsx MTAsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBhbGxvY2F0ZV9jYWNoZWFsaWduZWRfDQo+ICB9DQo+ IA0KPiAgLyoNCj4gLSAqIFRoZSBMU0Igb2YgYWxsIHN0YXJ0IGFuZCBlbmQgYWRkcmVzc2VzIGlu IHRoZSBub2RlIG1hcCBpcyB0aGUgdmFsdWUgb2YNCj4gdGhlDQo+ICsgKiBUaGUgTFNCIG9mIGFs bCBzdGFydCBhZGRyZXNzZXMgaW4gdGhlIG5vZGUgbWFwIGlzIHRoZSB2YWx1ZSBvZiB0aGUNCj4g ICAqIG1heGltdW0gcG9zc2libGUgc2hpZnQuDQo+ICAgKi8NCj4gIHN0YXRpYyBpbnQgX19pbml0 IGV4dHJhY3RfbHNiX2Zyb21fbm9kZXMoY29uc3Qgc3RydWN0IG5vZGUgKm5vZGVzLA0KPiBAQCAt MTM1LDcgKzEzNSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGV4dHJhY3RfbHNiX2Zyb21fbm9kZXMN Cj4gICAgICAgICAgaSA9IEJJVFNfUEVSX0xPTkcgLSAxOw0KPiAgICAgIGVsc2UNCj4gICAgICAg ICAgaSA9IGZpbmRfZmlyc3RfYml0KCZiaXRmaWVsZCwgc2l6ZW9mKHVuc2lnbmVkIGxvbmcpKjgp Ow0KPiAtICAgIG1lbW5vZGVtYXBzaXplID0gKG1lbXRvcCA+PiBpKSArIDE7DQo+ICsgICAgbWVt bm9kZW1hcHNpemUgPSAoKG1lbXRvcCAtIDEpID4+IGkpICsgMTsNCj4gICAgICByZXR1cm4gaTsN Cj4gIH0NCj4gDQoNClRoYW5rcyBmb3IgdGhpcyBmaXguDQoNClJldmlld2VkLWJ5OiBXZWkgQ2hl biA8V2VpLkNoZW5AYXJtLmNvbT4NCg0K From xen-devel-bounces@lists.xenproject.org Fri Sep 30 02:50:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 02:50:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413990.658012 (Exim 4.92) (envelope-from ) id 1oe66q-0006wV-9b; Fri, 30 Sep 2022 02:50:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413990.658012; Fri, 30 Sep 2022 02:50:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe66q-0006wO-6p; Fri, 30 Sep 2022 02:50:40 +0000 Received: by outflank-mailman (input) for mailman id 413990; Fri, 30 Sep 2022 02:50:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe66o-0006wE-Ok; Fri, 30 Sep 2022 02:50:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe66o-0005tK-M4; Fri, 30 Sep 2022 02:50:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe66o-00051W-7Y; Fri, 30 Sep 2022 02:50:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oe66o-0000Yj-5Q; Fri, 30 Sep 2022 02:50:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aF0AyUPaONcCqT7pDSBuV7ucZ4T0K+5DtLzlzaFJopg=; b=osxpjl2Gnp+9k97MHC53PoaUpE eoZk8qVWwiIaJ3gT4nIHINhP/jsO0XaTavV26lNbotOvw9WIY0ISJrRhWCm2nRrfpEABmLHXtEQfD 2mlAFtmYScqKJD/Nz4yxIy+5EGEyu+GgFbVUX7cQwUY+kxaUEhE6MYjHImnHSDPiouyE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173375: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Fri, 30 Sep 2022 02:50:38 +0000 flight 173375 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173375/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 173347 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 1 days Failing since 173362 2022-09-29 13:03:03 Z 0 days 4 attempts Testing same since 173367 2022-09-29 17:01:55 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand jobs: build-arm64-xsm fail build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Author: Anthony PERARD Date: Thu Sep 29 10:51:31 2022 +0100 automation: Information about running containers for a different arch Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit a210e94af38a957fcc99db01d2cfcc3039859445 Author: Michal Orzel Date: Mon Sep 19 20:37:37 2022 +0200 xen/arm: domain_build: Always print the static shared memory region At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Sep 30 05:50:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 05:50:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.413997.658024 (Exim 4.92) (envelope-from ) id 1oe8uZ-0000eo-BO; Fri, 30 Sep 2022 05:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 413997.658024; Fri, 30 Sep 2022 05:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe8uZ-0000eh-8M; Fri, 30 Sep 2022 05:50:11 +0000 Received: by outflank-mailman (input) for mailman id 413997; Fri, 30 Sep 2022 05:50:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe8uY-0000eX-26; Fri, 30 Sep 2022 05:50:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe8uX-00013P-Ve; Fri, 30 Sep 2022 05:50:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe8uX-0008SL-GW; Fri, 30 Sep 2022 05:50:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oe8uX-00027K-G4; Fri, 30 Sep 2022 05:50:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kz8Q2/3HFWTwVJHeyBvKm/NiNnBM6lo46QjaidjH/24=; b=VAxLXayUzRyRGkvSSt4MDhFjAj hetM6RgLYZGFcpG6Q3kemqMWMcmQD+NdcvvnpN4rVxvZp6O4xH656zkKpPmxOf5JZ8z2j9LuEeEAy N/5iRX44RRHnVTnRm86DpRGZ6EHVjWd0LSCjFQz1GCCAjJJ4TfBpZ3HI2P1XuFCZEOQs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173380: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Fri, 30 Sep 2022 05:50:09 +0000 flight 173380 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173380/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 173347 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 2 days Failing since 173362 2022-09-29 13:03:03 Z 0 days 5 attempts Testing same since 173367 2022-09-29 17:01:55 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand jobs: build-arm64-xsm fail build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Author: Anthony PERARD Date: Thu Sep 29 10:51:31 2022 +0100 automation: Information about running containers for a different arch Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit a210e94af38a957fcc99db01d2cfcc3039859445 Author: Michal Orzel Date: Mon Sep 19 20:37:37 2022 +0200 xen/arm: domain_build: Always print the static shared memory region At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Sep 30 06:03:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 06:03:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414006.658035 (Exim 4.92) (envelope-from ) id 1oe97A-0002P3-Kx; Fri, 30 Sep 2022 06:03:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414006.658035; Fri, 30 Sep 2022 06:03:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe97A-0002Ow-Hj; Fri, 30 Sep 2022 06:03:12 +0000 Received: by outflank-mailman (input) for mailman id 414006; Fri, 30 Sep 2022 06:03:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe978-0002Oo-FT for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 06:03:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e962169-4085-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 08:03:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8539.eurprd04.prod.outlook.com (2603:10a6:20b:436::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 06:03:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 06:03:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e962169-4085-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vrk9YMtOHxGMoSilWjWs8cDIQfwS2WkOjBiQ3V5qWgEk/49KKENO7W0+j3yeyoGxKlADZo5/L5ZGtRHPQym0B5ZTbQNJK58SqI8+tGxLgVisZi5ft8m8mNkEK+n2osEO4Y244cXrnQMV3dLEBriFR08T24s9hAFPwEDxY8T/DY5Q2EbNk3oi7dm8pKyuopMV424TEwrHYDKi3adFTTxzwkxE45VP+hLkx8QDO4LNJ9fn3B1VySFq+MXPJjV5wmNsuey0u1cx4KvHxEP4MXwnZ4SOvlanKDlAagPz0WmfhdMBoEON1xsr8zGerUUrfQNbsTAGD4YIbv65TmXGLigxLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rzF0cIUBeYdqvVoYkE0XVVR+Tf936AZ26VIG5zcHCUA=; b=RnXuP3CrbYfkx556gAOqQ5YcTwagotnWThGbL1yJ+Ek0cPS7Tzx5zlPjWqoKo4duG1StRNt6OZSgCPvqyUe5HfdVGNAFmDIqFgVbRTfHa0cxdqZEydXqOVKGEF76ROPiG3o50/pvlTO8etlmpE7xEfhPXbA7+unMmVlhrsSTQXeG4qDsVuSux/Ul6hKGmwWyMmc74z2+CvED0uY/zmU4oKT9j1Xanatz0baG/OYAtznjqPUea70CwHWSMeTjhfIx4Qdonu8ofPE8/oLhPgzMZ+a4cFBkCHPIq5ourtfaEl7Tg4otklc5ebVqD9OnEYiZAUkQGIcJAvWPcettjcGkmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzF0cIUBeYdqvVoYkE0XVVR+Tf936AZ26VIG5zcHCUA=; b=1QxKJFMV0q5fZYgstRurg97q+x2b5WDTV+HJkBRCkXepKePQ3cQVGNSZbnqOSD0ft6jM7Wd2G6QQqH2l5cXByCEl3b790v1XCGEJjgD5fSaMdGoCcl6kv6cd35DoxrFRTAkVOGS6TYCPYBxDihoz6eb8him3riz0u1tYoyTOoMl9vXO3aJR+oABS469qlxJezxPjOZWzKO2nwXSIsdolFF5htEpVAAdYx9/NVz3SQFDD6N4Lsn+QR1uGOpljUdsAYB03fnqrmHFmHwugAwWA/ouUGMPOoq0Z/Z7ylvBSHSI3W7pfBNRjeFkI6pQspchgHjkfbp1KJmAbf5iABhNZbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c32c4a9-d319-8886-c026-f33820a4f77b@suse.com> Date: Fri, 30 Sep 2022 08:03:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20220920091218.1208658-1-wei.chen@arm.com> <20220920091218.1208658-6-wei.chen@arm.com> <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com> <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8539:EE_ X-MS-Office365-Filtering-Correlation-Id: 423ffa34-f241-4c55-8db4-08daa2a97180 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jbi/t6JmELGusGaCKWus9XhFk+UIVJ4KnDialSM3oKuy05ttGMASDRy+8herhAy8OzZTHbi3DDxOErzVcVnrllaJ/zLsQkhhZIFYVVORFqDkAkjjn8YfOEhj7ZyBAQQrEGUsk+JIvjDbnKzOSym/CJqfkrTsqcAtrlNjuuIM2QT0CKfHFlJz/eTdQKerVY8rItH+CC3YsS3pBC5mJENjeIf+rmjHm/YTBOF+iRmmj32aV7xbmdWZj/cK5pz2Xyr5wcW71NhAbLrGZ7GuRDg0+G9iSRLhwG8ql5TtK04QTCC7tkErl6d1iUTkudzNMB7nLrd4iKJHXkn9picSYN29Jj6Llr/T+F/oimGEVAinnJsxLawf+KTK7h64QTV6ABurRTmqTnFxKYma4PRDGzWMSrp/TfWUspWo/R5Xuot5DdK7y2+bw8/SeuYiNr828t2VKqsQUgpRWwIKCRYS92B5AP0z5/vwcj5KMpEMOa/xpI7LTyOhbcg2kRyemwOPfgHfw/0ybXLd804O58/GY8dfDpvfpfA5lEAlr7iXZKlfb+u1LfDnH1ysFFJs/rcIOfTvtflyLtfbaFPuTa+WaazK5JPZc1pPrSohgvZU/aNlniXRpYuAbCfVnm/gCrE24n9NjleeNwu6lsTv/jdwRDV+/BGUZ4XTk+NX/vpPc+Qdh/mVMnqUu152A1Fjoj5b1I+ORC6I92H56sUWXtxifqUCI4s2N/OcwRCkijApF2Pnpnh9UVa2alxEiHJ3BrsjfmSRRBpCfucCu64CikQSDAdt1vllW+4Zev9yi6QVbr/Uhbo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199015)(26005)(316002)(53546011)(6506007)(6512007)(41300700001)(36756003)(2616005)(66476007)(4326008)(66946007)(186003)(8676002)(66556008)(31696002)(86362001)(6486002)(478600001)(54906003)(6916009)(8936002)(5660300002)(83380400001)(2906002)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3hyaEJTSENiNFZmM0VQVlFEcXVFd3RCdi95RThqL0t1NTdtNk0vRVNadVNT?= =?utf-8?B?Q3l3NkM3S0VvNzFZQUlEWkdXVXJDdU9OMU5mRlJSSk1FUTlJMnVUUlB5MnpB?= =?utf-8?B?ek5ENWdmeU9nT0hWdjdTbk10S1MzYXFOSVJNSjQ0Qy9vYkZ5Y2NOS0FOalJR?= =?utf-8?B?Y21PVmJrQWdjTzdEUXZXTG5YQnVIYndIcmdVaW9lUFkrTzF0cWNUbktPMmk1?= =?utf-8?B?S043dTJ1c2E3TzhUeU1yK0crMFk0U2daaWdxMWFEaWdxREtoenFJZzFUWGxQ?= =?utf-8?B?OFVpamtmZm50a1dSVzk4WVdYbFNMMTRUNFZOUkZPL0Rwbmh6M0wxVlI0VXJN?= =?utf-8?B?M2Zib0J6NkpPcy8yMHNuVm1aMW5JSHRRK1hUWlBucG5mSCtGL1h5NFFFSklk?= =?utf-8?B?am9XWk5SQ0twZEpkS3Q4VWdZNTY0Z2k5Tzk0N1NENzhTOWJzUWs4QUc4VXpN?= =?utf-8?B?NGp1MzR1VlpvMnVNQm4ydG1VVFVwQi91bGdHMEVZbjhMSFhJblN0ait3ZlZ2?= =?utf-8?B?NDBvcmsxbCtrRVByMnZvMFRuQWpNdEE3emxyeEpCSHNaQmFpOVF3UlZocWEw?= =?utf-8?B?emNvTElqakh6elM5a2pUQ2hOdW0xU2plcmdLdkNtbjVFbFh2ejNRT1FscXNW?= =?utf-8?B?UnhxczRsdTJNZlp5K2U3MSsrU0I2MXFRRTZPY05zZitsemJRQzh6SkVDWlFZ?= =?utf-8?B?dEQ3enM1UWZOYVM0d0E2UVQ5SFhDaTkrYk5YRERBblRmRjJpZFBYZHBhMDNj?= =?utf-8?B?LzYwdmJnaUV4ZXRCZ3NhckdUM0lCQktVQ0VYei9LS0RxQkF4TStXRlZUV2R2?= =?utf-8?B?ZnAzQ29PbkMyRkY4MG0yZEZWeUN5eithbENTdnNqYVR0NENwWkhxaTIxYmlk?= =?utf-8?B?RkVzVFdJS0VyRHArTS91SmFsR3NrSnJZRjZ1UXQ3dC9yY0NjUEgxY2VtZ2ZJ?= =?utf-8?B?MkM4cFRpSXh6b3Z3TFdqQktzRVd3aFlhbGN1RlZtVUtLMlR5b0x5YjltY1Jy?= =?utf-8?B?WDJWeElyZ29NTysyYW5wQjJWTHBjOElRWTZVY2t0SWJkN1dZWWpNRnpuYkJQ?= =?utf-8?B?aG03dEorb2I0SGhZUnZvWVVkUXgrVTRqZlRiMXZraDBwM0MyL2ZCckNxOWtT?= =?utf-8?B?ZFMyaXhPaVVyU1liOEJPTDUrUmtXNHJZYTF3ZGY2a3I3OFhaeTBRQTZMTk01?= =?utf-8?B?K0Jhc05ib0hiNEhNWk5QMjFBUE9xMFJEc0xIcUEzb1lyYnExL1ZtbWZybXRp?= =?utf-8?B?OHNkakJ4a0hja2FGUFBqTWZweEJ5bkhuRDdaZzFRci9HOEtWYmxVbkhWdDdC?= =?utf-8?B?RFF0M0VZUW5tRzFRTW5NdmFBTjZ6elNhV2xxdGZ2UFBadk9DSGk0MmR3cjhU?= =?utf-8?B?WkxKSEpFbmdhZFR3V3YxSCt1QVhydkFDdUpWYmFzUkRXOUpTeFpFbFdJdG9z?= =?utf-8?B?OVN6VHh5SFVhYWJKUzBLcjBqR0pUYWt5ODBzNFRmci9hTlU5U0VwY2FXeCts?= =?utf-8?B?NW5Fak9rcUlYL2ZCZ3F1WGFqYzFnVE9pdUluM0JJMVlqaFJmQnB2Q2x4ZmRW?= =?utf-8?B?NVJhL2J1bnZrbWlBRjUrUmpqem0xYzhsT3poblhxcC9BVHBoQkVvazNUaGdo?= =?utf-8?B?QitKeWQ3bEVkKzlCdS9OTExIWFAvYkJXTlNMeDdrYXdNUDRteXlhU2lXWDRZ?= =?utf-8?B?eUdEZGJobnNiQnZtT3dKbnhOYTV2MDJEeUxqMUxkYzhYSXpoWmRERFpLMG9O?= =?utf-8?B?YWxqZEpJcERHRnVEYmxnWGVrdTFnTkIwZkltVFZYUlpHcUN2bXMwMS9sMzJh?= =?utf-8?B?eEV6WnoxUkxVNm5lVXZNaVhMb3FZV3BvNlpWUE5XQ05NNDhqY3FaSXV2VjAw?= =?utf-8?B?QlN4cWZ5N0Z1a0dkKzhwM0ozbEcyeDR6dS9ydVdYRnBnOURpN3k5MXR1RUpR?= =?utf-8?B?TEd5aWhad2IxWlB1UTJwazlZaVZDSndOaFFHc0xkeG5QTUkvd1ZjSWczVTlp?= =?utf-8?B?UnZvMjhoc21oK090R3o3V3d0OS9QZStIOUhjMzhBVDhOOHNYYTQydVFvYjZR?= =?utf-8?B?R0NEelF4c055SndGWTVVUDh0bm5OQmdsenoxcUliMENiTFdnSjV1OG1idGFC?= =?utf-8?Q?eg/yQDJ7EhO1BLltUh8qx/S2Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 423ffa34-f241-4c55-8db4-08daa2a97180 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 06:03:06.5175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R9OpK6n8rg6xeknXk9AoqXWmmcHW8BuPDZ88Z3Iic2fgKajeBeOr3vVm0wpP8CgWQMSqsTR2nX3N/tRK4EuYuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8539 On 30.09.2022 03:40, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年9月29日 20:21 >> >> On 29.09.2022 10:21, Wei Chen wrote: >>> On 2022/9/27 23:48, Jan Beulich wrote: >>>> On 20.09.2022 11:12, Wei Chen wrote: >>>>> --- a/xen/drivers/acpi/Kconfig >>>>> +++ b/xen/drivers/acpi/Kconfig >>>>> @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP >>>>> >>>>> config ACPI_NUMA >>>>> bool >>>>> + select HAS_NUMA_NODE_FWID >>>>> select NUMA >>>> >>>> While I might guess that you've chosen the insertion point to have >>>> things sorted alphabetically, I think here it would be more natural >>>> to select the wider option first and then also select the more >>>> narrow one. >>>> >>> >>> Ok, I will adjust the order. >>> >>>> One further question though: How is this going to work for Arm64 >>>> once it wants to support both the form of NUMA you're working to >>>> enable _and_ ACPI-based NUMA? There better wouldn't be a requirement >>>> to pick one of the two at build time - it would be nice for support >>>> of both forms to be able to co-exist in a single binary. >>> >>> We are also working in this way. In part#3, we will check ACPI first, >>> only when ACPI is off, the DT NUMA will be used by Arm. If ACPI is on, >>> we will skip DT NUMA. >> >> Even more so an answer to my question would be nice: You'll then have >> CONFIG_HAS_NUMA_NODE_FWID=y even on Arm (using PXM as mandated by ACPI >> when in ACPI mode). But then what's the FWID for DT? I know it was me >> to suggest this build time distinction, but I'm afraid I wasn't doing >> much good with that (and I'm sorry). > > How about introducing a flag for selected NUMA implementation to > set it in runtime? > For example: > bool numa_has_fw_nodeid; > > ACPI NUMA will set this flag to 1, but 0 for DT NUMA. That's an option alongside going back to what you had in an earlier version. Another would be (name subject to improvement) const char *__ro_after_init numa_fw_nid_name; which for ACPI would be set to "PXM" (eliminating the need to pass it to certain functions, albeit the fw_nid will continue to need to be passed anyway). I guess I'm not really certain which of this and your earlier approach I prefer; the boolean you suggest above looks less desirable to me, though. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 06:27:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 06:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414011.658045 (Exim 4.92) (envelope-from ) id 1oe9UZ-00057Y-En; Fri, 30 Sep 2022 06:27:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414011.658045; Fri, 30 Sep 2022 06:27:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe9UZ-00057R-CH; Fri, 30 Sep 2022 06:27:23 +0000 Received: by outflank-mailman (input) for mailman id 414011; Fri, 30 Sep 2022 06:27:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe9UX-00057L-DF for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 06:27:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efc3c131-4088-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 08:27:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 06:27:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 06:27:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efc3c131-4088-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l2Q9p1sIDILL7OpiEi4w7iNJY9C0tqvvgxr6AEQLzur7INJiO2vA5zAAHjTytlBd8xTBtRF5aJ6rF3fpD9WbpFnjxkwWKH8WyQuAiJ+gFNm1j2IvICNDZCtQBLjUtaWzM8HdOne5yWjRJGfsAR5uooJqzmx7XryXgpVkX7ARrOIEbSYbSfNE0xwoyQ3rOmdhxmMAc190MOl+Pza3HBBG1j3IeyqBN7EWsfbIX3rlpJBDMqLBAp6BMT2UH/0d+vu3fqU9HWPtwioZWnYE72Ew4KMC2bDbqhsM/l5JgG1oXoO84ECMc1NqzBYm9br5pwyNer/zHajsri3pmw3Qdhbc+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8vSe6zMJQMKQZY0HkfJTH4TFHIMwGZdcGx5JC1qH/AM=; b=cBpKfkN602BL/rw+Nwad7afXmSwd8eW54YFXDeB9rcdYsBfHnBk1Fy4Q2+Ni9DX0p+gFH5iWhGKhzw7u+kSzm6w7Nf9dfSlPGIEGz74sVsv5CbtW/ZThI/IIvMFrFrSY1PE38EfZsUm7VxAfUsTr+THb5QVmjsnpZX0thXoR+PjfzPOJ/vZTx67lBSPnE+DDW8wiu/oXXZgMc1x2z3Efkky77z1d3CAuqXaGGPHzwzJ5hC36OzcCn1/w0o4psiizxK+ADn4SbRLBlAyu7603+cs1Q/C0EJeM3M00d9T/sbXLtGYwBRBy2TmssNa6FbSXq/qOYEDMBv8sHmhPpc4pLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8vSe6zMJQMKQZY0HkfJTH4TFHIMwGZdcGx5JC1qH/AM=; b=O9T662CGC/XmWh3zFIE9/i5Owmz9SssPZYh7MrnQNxvApD/ASQ4LcNjsMGkjoPSW8e7TbDYHA+eD2/5VLt4KC5F6WnjS8ZW4Y+OHnIcbB+xYJX5/GlIqI/bBnfkTYWXqthRloVfsnwQ+lokPKwxQGuliuLH3Nwkhtceh6xgPXtcoNLVSx5CbJy4oh/WWKvtC9JJu/lQT2Htj3wvNqrnszO1ONr/McqqMnqIVVCG/gSbUhMJTxcV0fJ/S5BEf+QYy1FprLjn5sRysGRvFWzgSmbNZTG0xFVncoUgyLsTSir4OLQQUmjsaJ4pVt8LQqUU3gFG5DyN57l8WPfZ5XozC5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 30 Sep 2022 08:27:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper From: Jan Beulich Subject: [PATCH] Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access( Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: a12b3e58-b036-4186-ee86-08daa2acd2e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JHyYW33sgvpauSVa59/t8GvhZXSMIjjWEe8LIPAhO8lcEAO2ghWA20uChYX5mpLudKfo3PdR12yrysMv5wOSeyToLRwVersAE/neB0whHSqUt9wu/MIbPF+o0+LXEg6GxmNlgIGyR2drT1wXbHCMg5aUgCqjoMlvQ/A972EP2URa/RRUv0Q9Ti5QYh5miXK965KlvA8aVPcmQYV/sfpugX1jmm5Y7fYIaZI3VBoD01k22L4q+OJntm75Qv48WdckyYPpLy0Muc2xulAqguNqe6ZvPdStG+V8r1hBJVvjsjgTwv2RdvlrY0/hudikSfZbh26tfoPU/NVucKa4dzbFx4BMgLyZxgrRSGmCfA5Sg/khe0GviUj31FKx/5lQwGHIH5rDH3weNWguIXg+ZANZiZ/YmsD01UUFxQc3bbiUrjUsxFvUjuG3Fx2ZnPML7zNNBKsupXfaT7c0YQdETtfVxZv1GaRPoic+JHQPu2MUHDI2AmQGAV6EdIlRwZH+PwFdNefqdHUH0hNArcxagz3euhFTKvidiot60GIKV2VhNf6co7RgbItvXG60BGQoyya808poC5MxwP+Ib7P229h7NfF7YpAvSOWL66lRwExalHHTMZ9YPgr9EeSLqlubsIncFlXpaiVX1SJ0ElA03eNYfQMgEprHKARQQpAJSebLCP487Ea7elenij2fc048uzeQSDZ8iqmfkr2W+AQMeVHu0rEH+QAWn7QXc0c7i3OMnsqcXJnzaWhfn9ferj14YfYyeT/Wuzhy3eGAAk6ZToc2Ob/vzOxdPHQQAaCNwfeDRC4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(346002)(39860400002)(366004)(376002)(451199015)(8676002)(316002)(6916009)(478600001)(86362001)(6486002)(31696002)(4326008)(2906002)(54906003)(41300700001)(38100700002)(8936002)(31686004)(36756003)(6506007)(5660300002)(6512007)(186003)(26005)(66946007)(66556008)(66476007)(83380400001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGFIaFlkbFNkc0pMUDQydTd0Z2lTaEVRMzRFaEhib0k0WGdCQktYTGMxVmZm?= =?utf-8?B?M1orenZNTzA0MjNRUFdUVXAvRk0zNmZQR05hR1lRWjc2aDE0eHZ0VTZiU29k?= =?utf-8?B?WjdEU1pYckZleVRXN1Vaa21xTU13eFBtYm1Kckg2UEo4b1djdFJYcnJGRU9p?= =?utf-8?B?L0RoR1dLdm05RDk5ZndKRWZEZ3VDU21JZnlrTG45ODNka25aUXViNzR4RnpP?= =?utf-8?B?ODk3b2h6RzRNNkVmTERTRDdQR2R3NElObjZuS2lpK3RKdGtMVWs3TGYzV2FQ?= =?utf-8?B?dDZUeVNRckxXZGYxMVVJM3FTQklKbStLUzVScEx2VzRMOWF6dDIrRUp0VnRJ?= =?utf-8?B?T2FnOG9aemxSZUpwMlJhdVZpQXhTUnR4eGY2U3drcnhIcGRMQmVYM3RoNDF0?= =?utf-8?B?dGNRTkoyZ3RaSW03MXIwcWhNdEtHSFp5R0V3MnJwQ2pLNTRwTk9vUE5rWGJV?= =?utf-8?B?SWZ0K0h3M2F2MEFIR2xpcWlJY0cwNHRLaW5WdkF5MVJlTDg2YWsyS0g5M2FL?= =?utf-8?B?ZjZQbUhnMWZZMkJoTDFjOEphN2I3ZWpoWHFjZXhSSFQrWlViclRNZHA1THNr?= =?utf-8?B?WnIycHZnOXAvaFRIRVM4QzZPc1g4bFZVUHliOHNFRmo5OFNuSi9VRFJrZ3Nh?= =?utf-8?B?a3ZtSTF4S0tVbkpTQ0s3RS9BZmF5WFRUd0VmZHVZNXI2bVJkR3ZpNFlaSDl1?= =?utf-8?B?T2UxU1U0bC9KVGFOeGtnY0JXakN4OVMyWXIzbklUVVBhMVBxcTFpd1RxQnVs?= =?utf-8?B?OE1SZ3lET0dqME1NejJYU0ZPWkVQODlTTjlvSVlPNStkSlNXZjIveW1yVk9M?= =?utf-8?B?Z2pMZ01oOEJ6MGhmem5mb1NKbmVQaC9PVlBoT3FBRG0yYUpSTENLUEFYdHRv?= =?utf-8?B?aGpvN01pNU5ZMXNZSklXUmV4YWZBbzkzeG1WL0Fhc1VaQmxvbjBJZFpKeUpq?= =?utf-8?B?eHlCYUpLbFE5TEZJQ0Z0WHMwSFRNVVdlN0syc0tsYTF3b2lCSUZNNy9wdkhs?= =?utf-8?B?SERuM1E0R25NaGU4NWZET2JueTBxb05nNklRM1BWWlRzM1JDemkrVGRlR2dh?= =?utf-8?B?bFVwcXBsaE5GaXp4VktZbmdTbWQ3bThXVWJOSDZSYnEvbXVkUmNXRWgrOFJM?= =?utf-8?B?aWk5akVYSlF3d3pqUmRTcE1BNmdlZUxCdHJEaDRlUnpPWk83anVIRlhQVGlM?= =?utf-8?B?bTBGUEtJSmJqVnhCb0JSU0VwdVloR3h6VGtCNnBGUjdNZjJoQmxsT01SWWQ0?= =?utf-8?B?SlVSOVk5TUNsS25PYS9kZjB3bVFkdnFncFo2a3RxQjRRWjZKSm9wcGN1VVZk?= =?utf-8?B?dWVOQ3o3R29OTlBQdFhRaWdreVlMVHQvcnlBUzdGL0JSUW1Vcmo1ZFZSbTA2?= =?utf-8?B?d0kzcENmazlxSkxic2lhTFl3bUVkYjRvOVdvd0hKNXVnWGZOZXFQVTdlcXEx?= =?utf-8?B?RXNWcGlXUlVMZVEyZVVBbEpWVmdzdk1OR1BzejdMVmV4M1FtcFBtWFQ0aTdT?= =?utf-8?B?bVN0SUZjRldrMHVPN1dhN0VqVjl1c0YzQWlVYnkxbWRreVZsMm5TdXovVnFM?= =?utf-8?B?bDZtcGVrQngxN0VPTGdtUXV3NEVvblRGYU9FQ0FKQ0hhRDFQbFQ1R2dYc1Zn?= =?utf-8?B?MWdZUlluakFXNGdlenY3MVhaMXc4Z0pMVTU0YnVDS3dvQ2NsM2F3TDBFYzJp?= =?utf-8?B?MHBzKzluL1k1MVJaeHRwaGt1UHF4L2Y1QnFuYktsdGgrMW51NDlYb0dlVGV5?= =?utf-8?B?UVI2aFdocWZvWUV5ZEYxWHhOSFlUS0kzNzdiVG9UR1ZsUTFDdElST2t1Wndv?= =?utf-8?B?UFVGdTRPeDJoYUl0b3RnUG50L0loaVJTeDFtV1lCT24ranFmRUIwVGZBWXpF?= =?utf-8?B?WUhWeS9qMzFXSHgvODIwSHhiQlZVaTlTaHlXR3V1NGNvRkpWZTE5U3lHWHp6?= =?utf-8?B?MVJGcHZJUFl2UzljOElqdkZsZktEN3RFbUN0MEQvV2dFS2FqR2thOXM2aGhY?= =?utf-8?B?c3FOQmdUdVVhL3VGeUE5T3hleWdhbDM4ZTExQUNSWkN4S1UzK1ZJVGovdVdI?= =?utf-8?B?b0wrZTZUU0grUzRvLy8wSWFna2wya2J3emk1R2VkSDIzUUFMU2VFekMvZ1hz?= =?utf-8?Q?2zE7PvQ/WWpdw+U+OGnUNUEb0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a12b3e58-b036-4186-ee86-08daa2acd2e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 06:27:18.3627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5e/YEhhVqjej1cxJWe3oIXWIsHVZi2IaNHlkaIOUroq7vnScr8fKTzsXfsiBiGozQMsBupib+rE57cpiM7so/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute from gic_iomem_deny_access()"), the issue really became apparent only when iomem_deny_access() was switched to have a non-const first parameter. Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -892,7 +892,7 @@ struct pending_irq *gicv3_assign_guest_e return pirq; } -int gicv3_its_deny_access(const struct domain *d) +int gicv3_its_deny_access(struct domain *d) { int rc = 0; unsigned long mfn, nr; --- a/xen/arch/arm/include/asm/gic_v3_its.h +++ b/xen/arch/arm/include/asm/gic_v3_its.h @@ -139,7 +139,7 @@ unsigned long gicv3_its_make_hwdom_madt( #endif /* Deny iomem access for its */ -int gicv3_its_deny_access(const struct domain *d); +int gicv3_its_deny_access(struct domain *d); bool gicv3_its_host_has_its(void); @@ -206,7 +206,7 @@ static inline unsigned long gicv3_its_ma } #endif -static inline int gicv3_its_deny_access(const struct domain *d) +static inline int gicv3_its_deny_access(struct domain *d) { return 0; } From xen-devel-bounces@lists.xenproject.org Fri Sep 30 06:31:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 06:31:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414016.658057 (Exim 4.92) (envelope-from ) id 1oe9YS-0006Vz-Uw; Fri, 30 Sep 2022 06:31:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414016.658057; Fri, 30 Sep 2022 06:31:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe9YS-0006Vs-SE; Fri, 30 Sep 2022 06:31:24 +0000 Received: by outflank-mailman (input) for mailman id 414016; Fri, 30 Sep 2022 06:31:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe9YS-0006Vm-Di for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 06:31:24 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50057.outbound.protection.outlook.com [40.107.5.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8094a03e-4089-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 08:31:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8642.eurprd04.prod.outlook.com (2603:10a6:20b:429::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 06:31:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 06:31:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8094a03e-4089-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R2zc8z6T1/veP371HRPmaA2UVSDyKVLdtthIck+D+xSuEW9sLEGMv93BqvO5pkHp9MYn3vfPHfXHep78HAiBaXj8xHNBfxtZwABxiyfV0IcDHdjJVWqWqnp1mDXtlgC+QvKoxx+VdcRJTEG2/dZNPn+/F3joNzYyYjU2oHJb++xnvnH9RV6Og1jlFBGfm+4k6zOR9ZauuaESLMt0xu7Z9QvJaMpLAsBfVzLj50sSbVzhrSQwJmKORrOj4itSZZY3DUKDeLCK4Livk7QDlHv/mqXuGKdDjfRzorsheVwKOGpA4wcOq98aOnew5miy941KC4RljM+c2ZpOYe2KVFzmxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=voDLLDHCY6rNgMrvMGlmbiyaLN/WryVYRRTD6zoVL7E=; b=jlJE5MVU9rJ1gh+r7yByZyLYERQbOgkALPmeSyqE9ikm0no3YZ1Kc5sTdJ1DiK/1g5m7PLGhxN0slgOusHdu7eymbLSxG+ACBsIxOsUmPUHVfAQE6sw9Fjwumne73fHLXiX/VCbbho8NIaJ2LozlUpITLUafLCrJjdzozL8cSVLn9O4cw7sRJ7CGzNEGvcnYGNyDnGF1MUER/leGXoDjBaJ0nrp/KF5oJq5h9E1cKZCLNYIC2dcBRraChOLG6xYwDfSfPyo1PRILsjPBsdEE8K+Np5eS8lIJttCPqFdfGruSA1TRVV67y0zzToVMNA9BgclsxzQm14edKIXU/cy2Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=voDLLDHCY6rNgMrvMGlmbiyaLN/WryVYRRTD6zoVL7E=; b=ZFKmyJe/JRHvoBnIq2DjpzuLzkMmkXkZQI2wG683/oZ0NS0NFI45awQiCwhGzQsXdwQkQGaJkuB9oJu/IlYcuHN642ooH+9AsrDPGv4bpUt12rHIcIjh8ZvsM6l+6Ii0rcG+Ti8t7A6wKP0HO2QKWs/tjLiza8UJRYqDyyZYvuJTu1LzGWGo0GYr57a17GbuxqXswWZNyjRM0QemZY55lhPME00yS46gJ1dP1lm4VY+gwt13+9P8LUd6Kl/A+w+JApEwHBey6ER5t1nfaJ1N7OySj+Sn4hOC+3diJ+Au1jn9x98Z8NAM45WtVureduiHClMrlQ1TjUWFdHZSiJKB/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 30 Sep 2022 08:31:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [xen-unstable-smoke test] 173362: regressions - FAIL Content-Language: en-US To: Andrew Cooper , osstest service owner References: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> Cc: xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang , Bertrand Marquis From: Jan Beulich In-Reply-To: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8642:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a4e07f1-320e-49ed-cfc4-08daa2ad63d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gA+KJuT200mXY2R8nJg9nATe6/d7UBpCtTU3v5jcqXr0lpViRbKO1WBM56dyWB9Fukb1qYzEebH1+SVyMR8V0/uwYhnOGYW6lqI7Aw7leKHtJy0Ql9AohAHsPa2bmmX7PQXee2I1tGM37Y2BUk9K293Y0tK3Kx6WFxhTW9bENKhH5Bo0zoOLc4YXodm5mlrmOavBtKuRhjKcoawWfE2h78vezP6ROky+pkJEYGoZ1W7UqeZlPGoqh8RYx4pOOjBqpn1N0/e07enf4yt3R4+B2uQijKImJN7iZMXzf0FuG7/UU7dNUhW8L0HUUcKXotgzHyhjQWEA6L/n50lHYdyp1dOWG05nrU0g72dg+4UoXRGOWcWRmpH+wT6XcpasMxU3rU7HD1I2lmUVShQX/4DWWCUEytDCHwAVtHctRp51K9RJl90xuIzdkcnHBDO7s8PFDYebTQ50lxpCHMjTvvt1D41Cr6CkpGAchI80kUbcydQ+GmT/0NGsAWfYWuMcQhpPBFs6ULCMkkmX6Tib6ubflrzFM5BR7RJQIejpdAhjFzUmKnc78Sdf6s/p7xVrfyzEkAB214cD3MBT+ZMu5PCaFvH3LmW6bI9TNH60IfeDVOha2SE8CV8R7+WDt2ejAaPkgWYFiaD+j6mRFApFlo8ZNVVF3yyqJbkA1K0IpVsJ4rtL9aWn4yD+mbLKTkdhi6OgpqZHpWdWykKVyKdJGK8DN6quMXOEKSGJ1jpmRh1WRinnNTVSCl+B6HNy7Vi3bFM3FH2DOYRdMhvjotVCQtO+t9Uqjxe2Cw90Ua+So55hzrEA2zlMUDSPmWKZdecB4yeJApjPa5y75C9zc59lsFI3gA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(316002)(110136005)(966005)(54906003)(6486002)(478600001)(31686004)(4326008)(66476007)(8676002)(2906002)(66556008)(66946007)(186003)(38100700002)(41300700001)(6512007)(2616005)(53546011)(5660300002)(31696002)(86362001)(26005)(6506007)(36756003)(8936002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2NZV1J0TzBrNlpuVWZjUWxMMG4relpOdWtkZEhUSmZ2d2I0eGZVMnM2S1h0?= =?utf-8?B?MzFwSDR2bnhTRnJ4cjVabWtKVUdkUzVyZlZNU2xCQWJKOHZ1QWl0b1FOeVgv?= =?utf-8?B?cjhaWlFUa2h6OGRBRFRZSnpCTlE0bkpWYjlGcWlvTWlwV1Z0OVlic3ByQWxx?= =?utf-8?B?cDZPUVhGeVpFNXJwZDQ4WXZUcXpQNnkwZFVHcVJSRmYrVXdDemU2YkVJaUNs?= =?utf-8?B?VFU2RUhUdFBvNktheVNmM1hHb2x5ZUM3U2dHbmpSWlNFN0hVa3hrdkI3TzNK?= =?utf-8?B?VmY1WVNoMElRdEtjTFRxK3l2bmlQQ2lMc2VrRnBqb0Y3M25NTjduUytiMjFi?= =?utf-8?B?VkJtRG5kbzdYTWltZlN1U2NoaUQxOXlNL2EvT2trY2xUbDJGRTY4RE53SlQr?= =?utf-8?B?bUdHMm5IUEFRVFVCSlU0VkR6M2Ria1drbVRBNXoreXFVWnpWd054c2FVSjRF?= =?utf-8?B?ek5BT3l1eE9lZUxmSng2Q2pFdmJvMzF5RG5BYzRyUy85SkdnS0g0RmgzSTZy?= =?utf-8?B?bU1iVmRKeTBEdmJOMEtwMWdTc2lSUkUyVHF6OHFwY1BQalhNaWJvUSsrRnJ4?= =?utf-8?B?eE4yMk8ra25CVzVTQTZ0SHZkS0VNWWhiZU51b1J2WTJvOXVqdTZRd3dzMjJ4?= =?utf-8?B?SU1lMUNNaHhnQWNKenYxV0Nmb3FCYVpYQ3hvOG5FbS90NzFCYndnYThNSS92?= =?utf-8?B?T0hwZjkvK0s4aFhrQjI3amQxK2psUmh4anJEWlhaWnd1VGtxeVY3eGxoNkd2?= =?utf-8?B?WXQwNFpLWCt2SzZxWTBVRFRyQ1RxeEpmanA0ZnNCd3YwQmJheUhkWWtUUi85?= =?utf-8?B?azEzdWhzNXRpbTNWb3NvZEI0K2tCdDZIUlE2TkVwTWJubzduMExKbHk0VnQv?= =?utf-8?B?eWlzVGtwZytOL0FBaEJRZFFEd3dpYzcyak1GdGNUTStYbmRvem1Ka2E3OEh5?= =?utf-8?B?REtiQkNpZ2laVStQQTR4UFB4dzdHME5HNUpVMHN6N1BwNnlmNkU2bi9GMjhy?= =?utf-8?B?S3NZTzlQQlNWd2RWNVFTUitpRU9NWkVNYWtZSlo4VURRek5wSEl3SGY0RjBs?= =?utf-8?B?NmxyY0tRMno2UnFEM2MxT25qcjZ4YW81eC9WTUhRU2ZRYSswRXdmTFN3bjhm?= =?utf-8?B?ampJZm5ROW9ya3N3YjMvc211T3J1M1NlYUl2cnhVK3AzZEM2U2ExTkR1RnFM?= =?utf-8?B?b2xJTURseEo2WVNKL1lBcVM3Q1loazRRc2dQQ0pYZlpVUUd1WEltN1RldXp2?= =?utf-8?B?WWVmQ0RkU0Q2Q0Ywb0oxZ0Nyd0tnWVRNRFNnVkFKUzJobXcweENqNE4rM1Qw?= =?utf-8?B?K3RsMWc3c2YyenlzaHZKZFl5TExGNmpCKzlUcWhwZDd0NVJEUjRNSjRKOTZv?= =?utf-8?B?Qjd6bHAyV3A1QXNHM0VtRjhRS2RwZnU5VXd0M2N0bEpBelJyOHZ6K3hpMTk1?= =?utf-8?B?ejZGelBadHM5blhrTjRXejQ3U2IyNXM4V2Ricmk4K2ZDRFJ5ODU1aUp6N01L?= =?utf-8?B?VnNkc09xOVlQOE0rMFRpeGU4VWJITHdBbnpiTXlic3BkVmFmTXppNWFCWlhm?= =?utf-8?B?WjBEamZPRTAvdXlKNVgwV0tackV0TEllUXlmOUtNWEFrSHB2enJwMGN0MmNp?= =?utf-8?B?S2Z2cUg1aGNiS2VyckNzZGEvRE5sU09oTHJ1M0UzV01zNFplYmJWVjliRHBO?= =?utf-8?B?bzRIN2gvQjBaN3l5YWdSSUZpYVlTNU1NVkZFRnpOSm1VckZBYW5BdDBzcmVM?= =?utf-8?B?M0F2WHlYYmZsTERiREVFV1QvU0pMeTBwQ2hoelRtZWg0dnRDUGM1RjFBOFFt?= =?utf-8?B?YlNwQ2g2VENKd3BZUGxWbk5tUDhBMUFBajRyYW5PYnNTaGNkUXRiK2ZZMVl4?= =?utf-8?B?RS9UZm1uVllKamVGV05TNmJQS3VNRkRPNkUzUWcvL2lFeXhtNzI2dG0wN1BH?= =?utf-8?B?bXBPa2cxMmtrTHU5cE5uZTB6emNCNTBWT0VFNmpsUEFSbnl3TEIxbFhaeEp6?= =?utf-8?B?bHJ4WWNRQVZiR2hEcE1FT2Fic1F1WTdTVVlESjcvVHgzUGcxcUI0S09aMUh5?= =?utf-8?B?Rk14N3djUyt5Ky9YQ3N2S1JZZWN0OEI4M1g4R2hRR1BrRXViUFByQ2tkWUZ4?= =?utf-8?Q?xi4swyaa9EsqhCwmB8b3JN8Zh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4e07f1-320e-49ed-cfc4-08daa2ad63d6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 06:31:21.7066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ideM6g4h6DDrOL2/ncw44gayvRwQ1JJ+Pnl7fXmsTmvfL2NZRG1CdgG4/5WAgHTLCQPRkH1+atJNr4i3CIwjWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8642 On 29.09.2022 18:25, Andrew Cooper wrote: > On 29/09/2022 17:22, osstest service owner wrote: >> flight 173362 xen-unstable-smoke real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/173362/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> build-arm64-xsm 6 xen-build fail REGR. vs. 173347 > > arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access': > arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of > 'iomem_deny_access' discards 'const' qualifier from pointer target type > [-Werror=discarded-qualifiers] >          rc = iomem_deny_access(d, mfn, mfn + nr); >                                 ^ > In file included from arch/arm/gic-v3-its.c:24: > ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but > argument is of type 'const struct domain *' >  static inline int iomem_deny_access(struct domain *d, unsigned long s, >                                      ~~~~~~~~~~~~~~~^ > cc1: all warnings being treated as errors I've sent a patch, but this raises another question: Why does the smoke test (try to) build an unsupported configuration? HAS_ITS (which is necessary to be set for the issue to surface) has its prompt depend on UNSUPPORTED, and (implicitly) defaults to N. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 06:44:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 06:44:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414023.658068 (Exim 4.92) (envelope-from ) id 1oe9l6-00089n-72; Fri, 30 Sep 2022 06:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414023.658068; Fri, 30 Sep 2022 06:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe9l6-00089g-2z; Fri, 30 Sep 2022 06:44:28 +0000 Received: by outflank-mailman (input) for mailman id 414023; Fri, 30 Sep 2022 06:44:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oe9l5-00089a-7G for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 06:44:27 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20042.outbound.protection.outlook.com [40.107.2.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 533fa9bf-408b-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 08:44:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 06:44:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 06:44:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 533fa9bf-408b-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMhftuYmIpZd2kcU82FdL1vpqKzb+hHWeXh/AJsbK4XyDn3QBsdBqIC/F0x2Voei2EWL7ta9Fc2cUaWLUzySBm4o2HSKO9rL8MtX9fbFgO6lpdW+qXUV2XJqq7gycrlAAV6EwHMCiJiFvUbquICRMgfP9JV7fBe7NPBMjYRCTAnjVewFiR7/1FKgFGHGFLA+XTbDW0fLDRg3RSX7OwZRpwY/mCaM4WSEWoKBHAC6wVJePaPFvAf/knCZJpzNB3fJfQ6gmyEsCyh/tQGNpvnZ4vX8F5oVNoL0p/yT+NjBbwvfus8QG6oeUjpf5sdPILGuyYk2gN8GsHMmbZEoEJrvDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ig5/f9yGkJ9lGAtU8YAhY4+anw7sGzZbBu/lcG43jwk=; b=cgHtxCOIMcQ+1xKN/dfS27i4LCeSxos2wF+ome7jtPjd2CiAYKQm9aVX6Tvv6BJqPZBGeNUGRWOIqG2amb1BAmenee2ZNa3CbmiX+rUvunzbJ2eV3eFptTETX4v3xIFBNzZ2r0LmqBwa0cSK7A2oh6oCbhTAl2lqIMpAbnsUPC12uwxS9TZJvshSXdYyzXD7tdEiYxgECf0nxq/KoMfaW24b3GCbYokSeNpHZhJP7Nkg3O7AioVAGhqMSjlkW4/VDB3qfO4zY4bBIKFOGXCgcYDKUK5QFtX8tRSHNYLcKqiNeB8PuKwC5kve2piWWES3oK8VKC/epjPyGgaOd0TCEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ig5/f9yGkJ9lGAtU8YAhY4+anw7sGzZbBu/lcG43jwk=; b=YrHo/l8tL+I9+xzdq2f6HTJhx0KMWPTwKNtVJreIA9fAY8IscYwQE7rF7JeYVput+Ck1XQXFqXTDHxZthzFJA/gC8+3IgUnh3AsW1AmtWWq+4CdzLLYWrdx4C2DYOJ3qtspZH+seVp8kIqfcL6fORmvo8PlPsZNntHl9fsCXbh1upZlZiHjRm5Lo+ShT7Vs0rT586s91EETfP8q7nLa9chuka6BfEPY5sZCSMPUeiL2ii6sDTEeX+K+QJWZ6tJ6cIAqmQj6pLaaU3gj2TQR+JBxcRLQ9/3maNggQWK/upskHiy4ieB9kbFSsc8CbaN7n1b04UIIiATlU/0yUDGXQNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> Date: Fri, 30 Sep 2022 08:44:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Content-Language: en-US To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c3e36ac-11b0-44f5-5e38-08daa2af3571 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fdiBvFBMCuhOYcClgqCAmmK5Oj3HkE72rjo5wKVmRpr40GAPp/yuhJpEYWyJUMht+ZJ/1iKcNiDCj8LFeJYFAwvMuXX8/Qm7bQ2gHb4VaWMLdspf6PldtVn+f8hJAdPdD11hYvevZbzBa0oiusWEa4xrRSXkZ8U99P35WGGynW/GsWWOjzhfqyU4vfBPBia7iqg6mMSZGwQNGzPx9QJiZHaVAEOgQMuKSyXddjqYHxfNVJJBBGaMUz2KgzxJQWj2z+INzpMlwZHNEu1Pn67HjxGu0sEIRhwwzijFHdVgGnh7M23AWluYBXtKKQ8tlUWiV7loewSIplTvTTlmamL6b1CJpq+Wqn4cybI6lyf/oiPFLtaMhzy/dYFdkXzyTxOqHc6d3rlfFKLc/p7II0vxAL5xU2ZwFMJOEaHjCFgyjeutXvhAzzDqA+/A2UJqDpUR4fAmekO5kDF1vky82Ta1ntQLagfIJS4vxp3Xghgbt033l8gBVrBhjM3quttfO5BFsaBe/jPsKL08eXtm2psEAoEx8P9wsjJ4WHtVX4j4sk+a3mDEaEyTcW8nJPBzI+VoWjkXC6aro9991OrwrZ3KPzu9Oq6ta4LYAhM+pGiNGW+Jtkx+zJ2mbs8rarLGel9Xsc9DeIjutvr5WMgA7DZMH3DXnsFknH97PM+Q7EhjWmvbgsKeu2NtnOsYITpl3xQqW4jM8TK0WZWknEjit8d6lM6XVyRQP+CsjwWyMy0Z4P831wv5/8MFj7nMuCk2dTuILn29KePYpHDoR7rTVPl3+5fzi7bMIx98pGvhEPnzJOk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(346002)(39860400002)(376002)(451199015)(31686004)(2906002)(7416002)(26005)(8676002)(6506007)(41300700001)(36756003)(4326008)(38100700002)(86362001)(31696002)(2616005)(186003)(6486002)(316002)(54906003)(6916009)(478600001)(53546011)(5660300002)(6512007)(66476007)(8936002)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjFpZGhHWFFudDI5TnZUdmJ6RkdPSm1FcGFxc2tZVWg4dE1XdEtVZmpFT3Vq?= =?utf-8?B?Q1J3czVNZWZUWG9hQmVKSFBQZWY2Nm9xdC9ZVWFzQ1lvMWxrWHg5YWtrTHhl?= =?utf-8?B?S01ya1RCNTVOYk1xN1NiM3hzNWZRN0twUzhHdzFUUHp6MExBd0s0bkRjdVhs?= =?utf-8?B?OExvRjROekFXOEtUUnZraVJsQWg2Nmw0bVB3Z2syMUcwbS9FSnVaenpvWWNh?= =?utf-8?B?UXJFbWJzLzE5ZVdQUHI4SGZvV20xV0sveE5JK2lueTFmUGhEUlB2NDJVWlVm?= =?utf-8?B?dkk0M3dsR2ttT0JEaHlYSFFzL1Q0a01scEF4TE9EMVdLTXJaTU9kM2tET2VB?= =?utf-8?B?TTVOMmJrdHNJUzdzOGwwTDBQVUZMYTJwZWRFZEZ1b2FVWk56N21oNUZqcFNz?= =?utf-8?B?eEdIbzBibEJtRkxKanVYWGtnZjNoM29sMC9hV0hXbC9wbEJTTStqbTM2MFRT?= =?utf-8?B?YTQyREhpcnEwVlllRWZBTWM2UmZ2Vm13czdhL1o0S1lpVnVwS1hUSnc4TVpB?= =?utf-8?B?ZkRzcUhnVngrVXB1a1hyOE1pdUQ2REtyT3Z1QUxEVDdmcGdGbEJveGh5Q3Z4?= =?utf-8?B?ZnZGMDU4WGFjYWQ0Z3BVRXhmMDdkbmx0WkxKVGhaMkVxYXNSOENOVWdRYkU5?= =?utf-8?B?a3pYeERvQ2MwNjBRcnZiU3JiWkVwQXR6UjIwS2pGYjM5Z3VDSVpDNmh1WStY?= =?utf-8?B?T3A1WWo3Z0xlQ0hSeGc1NjJFZmkzMUM5cUdUbkZReitmQjZnSS9XNlpNSDNl?= =?utf-8?B?UEsrTmtuU3Y1WGJZUTFEeW96RGN3VUpOSkQwWFJUeVQyNnc5Z2NpcS9pVU14?= =?utf-8?B?Z29oTC8yWUpnUXF3Ykl3KzhQSkk3SWZnaHZJdmF5Mld2NUJwdGZwejNIRnE1?= =?utf-8?B?ZkMvR1FDamg5amZCMUpkcGNxaW5VZTl1ZlpkTW5haGhIaFVGcTMvZlJnSTBP?= =?utf-8?B?Z01FZnR0dEl6Z0l2aFJYdkNsUTNYSGhrMTc5ZTNRSnRkS2JtdXNxWkZORDI1?= =?utf-8?B?ZjN3Y3NFWk9CL2VZUHlhdFdLaWJpK3VQeTdyeTNrcDdFSEppMkhJNVZuK3hL?= =?utf-8?B?Tnc0K3BReGxzYjREUWZFbVhkTU9TYnUzeXF0Zjd6SndWZ0RyNjBZSkVpandy?= =?utf-8?B?RU5yZ0txMTkrOVF1WmFpWEo4TG9sNkl0b0M0TkNYTHVqTkhkelQrTzNDZUVI?= =?utf-8?B?VlFraThQTm9MWVEwa3V0ZmQ5VGN2TklPNXRIb3l6RVQ4RXlyRkVRYTVPcnFP?= =?utf-8?B?djlhSWJlTE5FWjhob0YyUFU5V1hNeVpqOWNYdTIzSmVZZkZpZVpaMEplcXNW?= =?utf-8?B?RjVUN0dUZWtIbTRXSzc5TVBZYlV4TkRBL2JCNGpEZTVwTHZhTVJnRng5TkFt?= =?utf-8?B?ZEpWQWF4aG1uV2k0ZVFsdEpVUWlqc3Z0aHJxZ0R0K1hrcmlFVXFYUzN6VkVX?= =?utf-8?B?Z0dscWpCSFBUdWpDSUF5aC9RbmxqK2xXVEgzc2hjdGo5ZG5mUFFBbXJzWG5q?= =?utf-8?B?RFZ5Y3dWZlVoMDhPREc0L2FHZEpLTi84U1JnWFZkOFdPNUF4MGgvQktQQy9q?= =?utf-8?B?K29qbkRXVWx1c1J5cUpncDJVNDdseHpUZm5LaTNPTW44S1JXZXRDMzJra1Zy?= =?utf-8?B?UC9sUEIyTXZualpUOWFRN3RjM2VEWXh4dDZtNmJ5U2oyU25qYzUyZjNuRFRu?= =?utf-8?B?TUVPMklldlh4d0pJTDlYQlpYbFpsNU9ULzJCcTFvME9IL3JxSUc4ZXRjckpa?= =?utf-8?B?aldnUnlNOEYzS2NXajRJYjJFZzVqYUkxdjRGc3ppM0VWZHZGa21EbzRHZk5R?= =?utf-8?B?RExRemUxUFRtVU5TMGlabEIyYm1lV3pzYlBuK3hDUW5Ka0pSUzBHV0hQU3lz?= =?utf-8?B?RGxkL05VRzNwNXROU0tycVk1WE9oVTdaV1RwcDBxZjhINlNkazhTU2trbTBh?= =?utf-8?B?R2VZdUZuaFkyeE0zS2dJVC9wV25tdGZ5WmJhb0VRTFVidnVYQnNkSHBCV0FK?= =?utf-8?B?SlpJbG5HMzkzcEpmdFZVbHNubUtyUFA4Q1hZTjFLM3R6R1VMaTBlTGQ1Szdl?= =?utf-8?B?aG9BWXlBVHdUeU1iMGVqaVhMRW9KelkvY1RiVGhqTFp5Z1hEdlRDTWpHSDd4?= =?utf-8?Q?As/S/jjNhCRkUFvM/3TGdo8VH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c3e36ac-11b0-44f5-5e38-08daa2af3571 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 06:44:22.7351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JK4TLx9Mlmq6iDe2pHvLEl9vzDDLN3esgfaVZQbkls7E7M10lZx7mGfuwsKPfLmpx+4Has+jda+B3AY0/LG1SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 On 30.09.2022 01:02, Demi Marie Obenour wrote: > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DATA, > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > Xen before Linux gets to start using it. Therefore, Linux under Xen > must not use EFI tables from such memory. Most of the remaining EFI > memory types are not suitable for EFI tables, leaving only > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > use tables that are located in one of these types of memory. > > This patch ensures this, and also adds a function > (xen_config_table_memory_region_max()) that will be used later to > replace the usage of the EFI memory map in esrt.c when running under > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > but I have not implemented this. > > Signed-off-by: Demi Marie Obenour In Xen we don't clobber EfiBootServices{Code,Data} when xen.efi was passed "-mapbs". Should we perhaps extend the interface such that Dom0 can then also use tables located in such regions, perhaps by faking EFI_MEMORY_RUNTIME in the attributes returned by XEN_FW_EFI_MEM_INFO? Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 07:16:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 07:16:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414028.658079 (Exim 4.92) (envelope-from ) id 1oeAFj-0003bk-Jt; Fri, 30 Sep 2022 07:16:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414028.658079; Fri, 30 Sep 2022 07:16:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAFj-0003bd-Gs; Fri, 30 Sep 2022 07:16:07 +0000 Received: by outflank-mailman (input) for mailman id 414028; Fri, 30 Sep 2022 07:16:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAFh-0003bT-SQ; Fri, 30 Sep 2022 07:16:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAFh-0002dj-P2; Fri, 30 Sep 2022 07:16:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAFh-00041O-Bb; Fri, 30 Sep 2022 07:16:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeAFh-0000Le-B8; Fri, 30 Sep 2022 07:16:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=b5JUTz9dQDYYitHA00fNq8nmyrgrbZlMc/tD1dxx/wo=; b=dfP3KGIBCCL3GsmMsImqNGKWj7 0XxNO60Y1MqcLuEeU3KFZW2qxxSnM1XePRig2aPmqxFOeNXLdpQpDHalJaN9MT9Dvn4m3mPbjfBm+ 0fp9mUkyOHFe+YVjmGxDi9TMF06IA2coVud9pYAu3ofBGNEFZZOdXSHevJICPtZBSsg4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173382: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-arm64-xsm:xen-build:fail:regression xen-unstable-smoke:build-armhf:host-build-prep:fail:regression xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Fri, 30 Sep 2022 07:16:05 +0000 flight 173382 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173382/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-arm64-xsm 6 xen-build fail REGR. vs. 173347 build-armhf 5 host-build-prep fail REGR. vs. 173347 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 2 days Failing since 173362 2022-09-29 13:03:03 Z 0 days 6 attempts Testing same since 173367 2022-09-29 17:01:55 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand jobs: build-arm64-xsm fail build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. ------------------------------------------------------------ commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Author: Anthony PERARD Date: Thu Sep 29 10:51:31 2022 +0100 automation: Information about running containers for a different arch Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit a210e94af38a957fcc99db01d2cfcc3039859445 Author: Michal Orzel Date: Mon Sep 19 20:37:37 2022 +0200 xen/arm: domain_build: Always print the static shared memory region At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Sep 30 07:20:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 07:20:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414035.658090 (Exim 4.92) (envelope-from ) id 1oeAJe-000516-5x; Fri, 30 Sep 2022 07:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414035.658090; Fri, 30 Sep 2022 07:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAJe-00050z-2J; Fri, 30 Sep 2022 07:20:10 +0000 Received: by outflank-mailman (input) for mailman id 414035; Fri, 30 Sep 2022 07:20:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAJc-0004wP-LP for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 07:20:08 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e19f65d-4090-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 09:20:05 +0200 (CEST) Received: from MW4PR03CA0240.namprd03.prod.outlook.com (2603:10b6:303:b9::35) by PH0PR12MB5679.namprd12.prod.outlook.com (2603:10b6:510:14f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 07:20:02 +0000 Received: from CO1NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::b1) by MW4PR03CA0240.outlook.office365.com (2603:10b6:303:b9::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Fri, 30 Sep 2022 07:20:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT054.mail.protection.outlook.com (10.13.174.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 07:20:01 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 30 Sep 2022 02:20:00 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 30 Sep 2022 00:20:00 -0700 Received: from [10.71.192.107] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Fri, 30 Sep 2022 02:19:59 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e19f65d-4090-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EbtHyPFLanhy7yFZ9pa/F/s+AbhrA+Tvo3ooOBwM1npS6VGLDW6HGi7XCjE30dAmbEV3QlGBTDzy2TG/SgLkQhrtQ0ERCSYST+tMriGU5+n+8phCH4LMBVV0AYeIW9fn85nUzU4n+M3jJ9ajPZuSXIiAB6Aufr/S7UuDEbEkECJsYMD5VqOtLKe6o5noxskRTOsRhxijCMEKrARpX1jlamcRmllR9UJEHD+4ktfd266kY2AjBiqoqDlczLiYDHogiDUfujyIp2Z26vE8ZJgVaPNV61O5LgG1KLVFrUl/UuThsOw4vZibDe2uTZwwkJ2++5cSQuq1iBbXg0FeaVRXsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pZwBUYhZNRcuDMqjCLwSliugum2OGY17CECp89P5Xcg=; b=NnCuZlewd7Efp9M99inR/AaU3HOC92YG+i/9l8GD45iS4KRohe4zYNppYr52X3hwL+ESD5Eo2pLf2wlzmOo4/LGwH0jsF77UqfOe/dloxeM6HDJSHGssVVKI0pQTmkIPRMFclAuKTfn56RSZRbDtSYFltLl9ixT+MmFZa/F6pmt2yIHPu70AKyr57p0ezx7O+DaVn0ifuyO/Gyi4746IzvCSHozb/IzW5lbwXtDuyzPCrrOtd+ORLt6hV81Kas4teyYJd46b8ezfKmESKAli7M/Ebi0xOV6NwTjp/sw93GGQneLcvmsI7/Yg/KFjEAvqxtc2Khfxyt923FzDKDiNrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZwBUYhZNRcuDMqjCLwSliugum2OGY17CECp89P5Xcg=; b=srEBfyfEEzCPGb/U/PGfzrtAOHXl+YstrK5QWOCFm2V2oUjPQHknuRWaBg4tf/m2CzS9TBgR8oyEHhOY7GP+G5523zsjYda3+gBDdDa2f6/nm19k5MRJ0PQWHSVpjPKTxPMcdeHTKo3KY015Ko0KY5WcY/nvZMd02pW99Ru+Y18= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <4603ca0c-55a9-489f-1f21-79bcc741fcd4@amd.com> Date: Fri, 30 Sep 2022 09:19:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access( To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper References: Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT054:EE_|PH0PR12MB5679:EE_ X-MS-Office365-Filtering-Correlation-Id: e16adde8-8128-4960-77a8-08daa2b430a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qiXkGGAd7FTWKD7bCJYOchhWaeN/JuVbK+1IgovZPjmrdOASU7DDhtnwHu7dbGH/JK85uPhvAC8Aw7OzGzGORvkV/NCi1lTD8xGVEBqu1nWmbs86WXjupR4+XQYkOxrLc6YHXc17sVZrpfYazpFN/gAEeUWao0vlTWmkw6urZ56Ti4iJbII5Xfnp166C4aTNA8D+ZN1vlc4ER5h7dqZhqk+zrH3012JEas1LC0de6oWYdh/VdvdrnB+h9VA7L7wgkg5YW31dJ9WG0OkfLtm4SqUXU0N9bBgd7Eq7xGtSad/0W0KPCiQ7QXYsYvU0tj6X7A/fcaLZrDC69oFjIxaELVH6LryfwCP/LeXkzKi7KMUNIxTyHoEgcJu0yrH9/53bnfAlVGe2xFpDMIy33kwZnIC3/3DQ7Ia4rSo1gtsNUEHbKRB598gSlBXejydamkh8sycki6UbIdbtOlAvK8cxt6vgPVlCLspjhxDoUOy8emWK/UX4QyI8VxcATYUkagP0+5yHRShriMr2SB6xI5942O2ZikxHA2dn2N19Lvb+7VjpukqzJJGodtHjbogc4kQPbaSblCZagYkGeS/ziBukRf/F1xO0kydmnLNd9oqpH+Pr/NTXs5s/SkuxXpRRpk2D077kxxNeLkzBq0mgKKDZfWJV3OqGioprSUsVnObfjdXaLSBNRpGk+ws1SPebVEj7LfeqSqzj3QMBrRDki9RO/aQo0S6lWaVRum3TEoiQoIQsCAPuHgNvHHKFUwO9+epWPJaWLoV7Y2Pfd/F8grjfGAI9qglB5ycnK9uSA4s/PxhB+DQR/pLrxv+/RbnWtkdQl3GsjGmTtrvS/xgVOiAJaQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(478600001)(316002)(5660300002)(83380400001)(36756003)(16576012)(41300700001)(54906003)(2906002)(40460700003)(53546011)(70206006)(8936002)(186003)(4326008)(40480700001)(70586007)(4744005)(26005)(336012)(86362001)(44832011)(47076005)(356005)(8676002)(2616005)(426003)(31696002)(82310400005)(81166007)(31686004)(82740400003)(36860700001)(110136005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 07:20:01.8697 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e16adde8-8128-4960-77a8-08daa2b430a9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5679 On 30/09/2022 08:27, Jan Beulich wrote: > > > While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute > from gic_iomem_deny_access()"), the issue really became apparent only > when iomem_deny_access() was switched to have a non-const first > parameter. > > Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Michal Orzel and Tested-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Fri Sep 30 07:45:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 07:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414042.658100 (Exim 4.92) (envelope-from ) id 1oeAhy-0007mU-9s; Fri, 30 Sep 2022 07:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414042.658100; Fri, 30 Sep 2022 07:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAhy-0007mN-7G; Fri, 30 Sep 2022 07:45:18 +0000 Received: by outflank-mailman (input) for mailman id 414042; Fri, 30 Sep 2022 07:45:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAhw-0007mD-Pb; Fri, 30 Sep 2022 07:45:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAhw-00036I-Mr; Fri, 30 Sep 2022 07:45:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAhw-0004qU-3g; Fri, 30 Sep 2022 07:45:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeAhw-0008Gu-3C; Fri, 30 Sep 2022 07:45:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=23uw5rouVk+z4IFAF6zNxHdQsXT/gvESsC/w4cx1+C4=; b=UHp2KQ68cnPLJKqiPkQqd2rOwE GBby/CCpHLMb8GGTGvMw7FkipcgGjTJBmwCOtSRwC8qb7Z+y4UfQCdHTUre77NRbS41rojyuFzW8r clxWjxSqurre+FLaFOkh9xZw7VSPcORMJzdXYwUfG+5szppSdV2o+x6GaOptnqDCUdP4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173378: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=987a926c1d8a40e4256953b04771fbdb63bc7938 X-Osstest-Versions-That: linux=511cce163b75bc3933fa3de769a82bb7e8663f2b From: osstest service owner Date: Fri, 30 Sep 2022 07:45:16 +0000 flight 173378 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173378/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 173364 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173364 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173364 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173364 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173364 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173364 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173364 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173364 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173364 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 987a926c1d8a40e4256953b04771fbdb63bc7938 baseline version: linux 511cce163b75bc3933fa3de769a82bb7e8663f2b Last test of basis 173364 2022-09-29 15:40:21 Z 0 days Testing same since 173378 2022-09-30 00:41:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 987a926c1d8a40e4256953b04771fbdb63bc7938 Merge: 511cce163b75 06bbaa6dc53c Author: Linus Torvalds Date: Thu Sep 29 14:37:45 2022 -0700 Merge tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs Pull coredump fix from Al Viro: "Fix for breakage in dump_user_range()" * tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: [coredump] don't use __kernel_write() on kmap_local_page() commit 06bbaa6dc53cb72040db952053432541acb9adc7 Author: Al Viro Date: Mon Sep 26 11:59:14 2022 -0400 [coredump] don't use __kernel_write() on kmap_local_page() passing kmap_local_page() result to __kernel_write() is unsafe - random ->write_iter() might (and 9p one does) get unhappy when passed ITER_KVEC with pointer that came from kmap_local_page(). Fix by providing a variant of __kernel_write() that takes an iov_iter from caller (__kernel_write() becomes a trivial wrapper) and adding dump_emit_page() that parallels dump_emit(), except that instead of __kernel_write() it uses __kernel_write_iter() with ITER_BVEC source. Fixes: 3159ed57792b "fs/coredump: use kmap_local_page()" Signed-off-by: Al Viro From xen-devel-bounces@lists.xenproject.org Fri Sep 30 07:46:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 07:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414048.658112 (Exim 4.92) (envelope-from ) id 1oeAjX-0008SW-Mx; Fri, 30 Sep 2022 07:46:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414048.658112; Fri, 30 Sep 2022 07:46:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAjX-0008SP-Jy; Fri, 30 Sep 2022 07:46:55 +0000 Received: by outflank-mailman (input) for mailman id 414048; Fri, 30 Sep 2022 07:46:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAjW-0008S7-Aw for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 07:46:54 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70051.outbound.protection.outlook.com [40.107.7.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c0b5d02-4094-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 09:46:52 +0200 (CEST) Received: from AS9PR06CA0270.eurprd06.prod.outlook.com (2603:10a6:20b:45f::31) by AS8PR08MB8802.eurprd08.prod.outlook.com (2603:10a6:20b:5bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 07:46:50 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::5c) by AS9PR06CA0270.outlook.office365.com (2603:10a6:20b:45f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 07:46:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 07:46:49 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Fri, 30 Sep 2022 07:46:49 +0000 Received: from 1b106df4208a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F915DF3-7D1D-4D61-82FD-D5EEF1E372DA.1; Fri, 30 Sep 2022 07:46:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1b106df4208a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 07:46:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB6541.eurprd08.prod.outlook.com (2603:10a6:102:15a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 07:46:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 07:46:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c0b5d02-4094-11ed-964a-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CxV5N4XlJEWIvnXf/0sB4SEo/zwhrdIR8obLbJxMoKUds7Ss04iIC9vHum5RPhhiD01S/cTYkOz9tGTNP9UPZffGusM6HCvKIZD1J4fYpgXov4zS+L64/qBeSvN26HybUMpjX2LpfOMr1tMcChu3Yr48EYbLoS9AeqyyZm1CnfdKb2Ewd8E8DTw4A5iLFbU5ny0pRT4qEywbaNlrvrcFxXvy/7Lrk7HOWiheR9smKTeOlIfzR+R85tWFA1tczkDJWPAZ47duXMV0H8UadIf/ttXF6hZ/yKcEzBSTXiuEu76RinVP3I6b3bwd/8RVj7IJwQIvjMtdfxtN2cIlA6qH4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duczp9xmZ1EtJaoMyzJypPcQrxGkGzVNp++Mc8qTau4=; b=IEeyP/XwjkcZ9u6ljFQ1e+ZNsWHUyABoLoibdSzAd3SObBRhbW2qnR9Lal7avj+nxW4oUqYCiF55JjFjKQis/KzXeteCwM4WiCh+6oFLG2ekL1A5kGj0Q4Xni9RU0MTxUw/LlWkubKwVndz1cyMqDPiYP0BT3xLmSU3ZxGFbEuwmsMGn3izaP3fHb+4fKXE2ATFWnR2+MSnJZ1rFVite3S/LlBGBdzztHcbLuhulBZanZy1tCrnJzvj2q2Eyaev2Q12Upiy2CzcasMbmdolgCbSMYQTRKX6SSkpTWg/Os/RfvypXAzHqQ73wR6+rxXWOUoGCb9ZcKrwZw5wMXJFFfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duczp9xmZ1EtJaoMyzJypPcQrxGkGzVNp++Mc8qTau4=; b=CnIL5m1qYIcRLt1hT+VO/AI03B2f0wdv6j/SEjBbbFRFIsiaXCEGAioI2GvjczYY2BVKxwXEQcpFYquOH1NMessbvkG5Kq0+/xsGwN6e4aikl2tjnyvY1SW9cmssqrLXu5eNHoQNDK6WqYaM/ZlHYcz4ouLzsMR4BCukzofY8Fg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1bd59b1bcf44b60c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLmnM1ceSkbAwwoRw5dzOelsF3yMuKpr4JG0dx4+2boNq6tdvwIMAjYlDBulnspTO3R+m+MmgmFTL27xADl28HaRj5d/Q709UDl8DOJ6QwThUhVx7lNMRZZqf3FzXwSnFpwm5+80CqZTaC56ms1EQ+XtICQadeRTHrD5WamqAkhJsJUg+HhGbWaFJGvgnq0qHAH6Yp0Afv0bleywn8RYbzPuEBXsf+CZnW3N2LNHvPaC9upYbnyHr+EDZx78HpX3eDV9IIKD7UdRMIFb4B+p53SqHRE9euYM1tEd4cQreZcP2Ti/iAHvaasO7PGB9+CW+TDKxlMa68NJrTeByFYBVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duczp9xmZ1EtJaoMyzJypPcQrxGkGzVNp++Mc8qTau4=; b=iD6kPTdinW4nk2vGBRlKp6fOYgCOGarIAnEe4F5ZlN834jxYDPquFP4qBJD1+p3zej29h6gWC1SY9ktTeOO84w2YZorPQVu3kPRpiGtqLxtCAcD3Uolrojq15iiF9KJ+BXhQxcK8B3WrZ3vZjN8Ijq+K7KD/ZQn6zLQBmW1TIzkzZO2GzcETQig95J4qNFxj4kPw/cBLQclo9TdfHgyTQVpKYuidpK/1lH90a0/5qkbYXY8xn1vNagOXv+XeYKlm11hfzpjOgUuuJi0Tx8mDbmcUCIZubBYTj0RvlQn8VSjZxOwPm7o8mXsqbRjz2J98IXlrGwKd6rmWMNbkaHz4gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duczp9xmZ1EtJaoMyzJypPcQrxGkGzVNp++Mc8qTau4=; b=CnIL5m1qYIcRLt1hT+VO/AI03B2f0wdv6j/SEjBbbFRFIsiaXCEGAioI2GvjczYY2BVKxwXEQcpFYquOH1NMessbvkG5Kq0+/xsGwN6e4aikl2tjnyvY1SW9cmssqrLXu5eNHoQNDK6WqYaM/ZlHYcz4ouLzsMR4BCukzofY8Fg= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper Subject: Re: [PATCH] Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access( Thread-Topic: [PATCH] Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access( Thread-Index: AQHY1JW5H0TZSlF74UKUACaulgO1oa33mGCA Date: Fri, 30 Sep 2022 07:46:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAXPR08MB6541:EE_|VE1EUR03FT016:EE_|AS8PR08MB8802:EE_ X-MS-Office365-Filtering-Correlation-Id: 78e7dcda-3818-4758-e3c2-08daa2b7eef8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LxSJ8V34OWczJU49vrtowmJ/z6LQEbrfVhYSS2i8fVUT4g96pTla7TB27fOMagR8WKVT9SjlvTNH2B66RFUVKN4zM5I4zkaX4qi943VdGPCv/LjaUPW8ofoPK3k7HOQpIOtMWXTa0Faaax36ulUC2WEnP0EHvC2TRjhrl/MXBJ2fNkPTDI95PCWD/Vb6oWPSA6pWlVLTRHkDA4M40MIa3Eym/UqOmoLKacdJvRk/Muq6HnvpJG5QrOmxe9dgqt7zmR83vJKcnGw/kAG01ivmQHt4t3jur+8rgFH6eP9cPT0mCilDZmbA2R0NKzKbUUfEwqgiYfWxzsPrqS8KPIYmVEiyQRcUpQ9kB5TuAlohDRSKmrwOLnkg1dmhwomOi+BliEY0Aa7ZhjNUVvx6FefkwaRWqOLjX2gx0nVz+3w6g+DKc+pdLCvUSg/RIF63ofbsqBJtsO3H+fFnCo4uJtEUHO0WIpEOdmviktptaO1eVklRldiYYdw+6obcMzX90lon5KZsR8kaxD0FFz/5Z/P14Rfl/qdFmf1lZccBkCd924Rpr4UsMD6A+rbE2D4GDYyn1Dje9TtlM2eET1OrHhwTOebCmcX8jehicc+uHeQWBvaXZ3Auh8IJIH2ShMweQgGswQftINX9wDQ/NKZUlWcz67m0a9q291p50aYqDrOZXFYFkO96FwPKQnPqFjVl8UUL4pVLejjYqwpKZADKsr7k5ROVHeMYaoATIVjUaPDGutU+i2DKa8UONR+4DoHOawWWXmjhCG4BfSzDOl7MR97pLQRE8qlUeVgAHUAMZUssmPs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(71200400001)(8936002)(5660300002)(38070700005)(6512007)(6506007)(53546011)(316002)(478600001)(41300700001)(2906002)(91956017)(36756003)(8676002)(4326008)(2616005)(64756008)(76116006)(66946007)(66556008)(66476007)(66446008)(38100700002)(186003)(86362001)(6916009)(33656002)(83380400001)(122000001)(6486002)(54906003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <618859E48F4F2247A67ED3A55DA7D968@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6541 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8a7daed3-9548-46ea-ffa3-08daa2b7e929 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /ISsk7Yj2RMsg+4kwnZB+0o1MH306d//ZmZVlV26l8LqPviKvNM3OOYWgHd9AwtA9r1hYMuO0ehiPhahByaQfa3x35ZWooBuKA1vR0I4K7OFmSwqjTNIlIIRp/oYJ2oAer20WbeHRs5TaSmhoS70aQUuOuI3q31uSvoS93/0qw6B5hkFd7FAyRa6128uFMrT5FnILVWIs0k5uL8XPSDdWlIhRRQgXLSciIjGtTKYgNpxyg7X8/RW8+HPf0FO+RXba6zOQwM9CRdlQJbgNK3oueZkhNnjUtZ0AQQk9LKzNC7TuQsYSVwvrB6JaMFMR9layuEAQWQXCF9DnPryz9BhVqO2P6KbBCJtKEJdlyKovIXq11Gjf649NaLDE/lqhe+9hQrQwJJrKD8J5EyDZm0wsuR1z4UYZRwKoTPEYuH+i/QWYq/8XopTorgq5WnRkkL2hY8Xd/sMwl0/UZIXbGUyfWkUeprnv7z7XphlkNnodQmY2vH1ST15iW2MVKLnPgR9F/XsxiilM7FtuaCJDSDO6jy03VyfKlqYCvdmY9K+e9louJYJjogWYEiBvblPEvKDBFy9PUt0C7h37aU+QKF5XXgDjqJVzPylkUT5LZTa9Ud3Yy48ui3ejZUJnK2jwHq/F9Tcv3UhwUbtLq7cuKi1BlJqNIZAfu7YwGytNefFhic6KQX+X646nz3qnQ3NZZ+BU1N3ZHLIWdvDjKKeuLHiT67xA2XvsbNuHPiXal5holQe7OOANT1mwW3+TZVuvodqPpYj6I2FoqpVso5idpy8Rw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(2906002)(82740400003)(33656002)(36756003)(70586007)(70206006)(8676002)(4326008)(41300700001)(83380400001)(6486002)(40460700003)(478600001)(356005)(6512007)(6506007)(40480700001)(53546011)(47076005)(107886003)(26005)(82310400005)(316002)(54906003)(186003)(2616005)(81166007)(86362001)(336012)(6862004)(8936002)(5660300002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 07:46:49.7256 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78e7dcda-3818-4758-e3c2-08daa2b7eef8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8802 Hi Jan, > On 30 Sep 2022, at 08:27, Jan Beulich wrote: >=20 > While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute > from gic_iomem_deny_access()"), the issue really became apparent only > when iomem_deny_access() was switched to have a non-const first > parameter. >=20 > Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- a/xen/arch/arm/gic-v3-its.c > +++ b/xen/arch/arm/gic-v3-its.c > @@ -892,7 +892,7 @@ struct pending_irq *gicv3_assign_guest_e > return pirq; > } >=20 > -int gicv3_its_deny_access(const struct domain *d) > +int gicv3_its_deny_access(struct domain *d) > { > int rc =3D 0; > unsigned long mfn, nr; > --- a/xen/arch/arm/include/asm/gic_v3_its.h > +++ b/xen/arch/arm/include/asm/gic_v3_its.h > @@ -139,7 +139,7 @@ unsigned long gicv3_its_make_hwdom_madt( > #endif >=20 > /* Deny iomem access for its */ > -int gicv3_its_deny_access(const struct domain *d); > +int gicv3_its_deny_access(struct domain *d); >=20 > bool gicv3_its_host_has_its(void); >=20 > @@ -206,7 +206,7 @@ static inline unsigned long gicv3_its_ma > } > #endif >=20 > -static inline int gicv3_its_deny_access(const struct domain *d) > +static inline int gicv3_its_deny_access(struct domain *d) > { > return 0; > } From xen-devel-bounces@lists.xenproject.org Fri Sep 30 07:50:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 07:50:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414057.658123 (Exim 4.92) (envelope-from ) id 1oeAnF-0001Uv-BU; Fri, 30 Sep 2022 07:50:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414057.658123; Fri, 30 Sep 2022 07:50:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAnF-0001Un-8g; Fri, 30 Sep 2022 07:50:45 +0000 Received: by outflank-mailman (input) for mailman id 414057; Fri, 30 Sep 2022 07:50:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeAnE-0001Uh-Eu for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 07:50:44 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130053.outbound.protection.outlook.com [40.107.13.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95c4e5a6-4094-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 09:50:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9314.eurprd04.prod.outlook.com (2603:10a6:20b:4e5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 30 Sep 2022 07:50:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 07:50:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95c4e5a6-4094-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMnNtvO6FeD5ShvoaBrPOg5sVvAIJMKK3V9n6nIW0etyeqr9SN8kg7sV/sI49/nBOeY+FSYZatzIKAcYPIdm7uRNVuhqID+mYpnZcl6EVK1tlhVl22Cbu9x+cffBEmYAvkVkz6V5LqOyROBF5f6uBPIVhSbs0+1mZhq0c1a+bqKG5R+4tzC8mV+B6awfap9cXrSvgYqI5DSSFi49eRDbkoOaKdIHwMiDAMnaVWe4Fr/zgnfJPuGhfCkHOU8HCsGmkXPGtkLhgzB6q3ilKczuWNiePSUEXOh+OcOoiv3qeVCqcIE2747FfhsKl4JenLBR7UAOTZsrEGVJs6fMSfhzMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NCZxGTOUES+JAZXxkpQ5pJdIxnnVHQ/0Tkkf2ZdiNJI=; b=QeB6H93h070IAd2C1LdnQozW4GCeY41Nen+kqPXnH+b1cJfp9wLCsItiyZA5NeMNCCXsowmidgkV5oHOYU4EJnNf4mcmYXdB4aROX8VvejPjV/1qgEN7aMbKunMBunCJLiRW+u63x7RUxS47QD+R+yw0SVDGRexL0KVK1aoqOpTUx+oMKpqYjm7iWN5FtZfU/3SZWH7eT3+OAQ5YaF54JFtcATVrgyWq9KzSIyG9X+kjVaZ0v7+KnLzXhk2aH2SKzbElbMOUUrXCc6h9aBO0ydjH3ClGhyoASJP6B6ZuubjaJRx78ndMJCSPm/fjs1Y7fbgirr0OPLySt5+i3xzmgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NCZxGTOUES+JAZXxkpQ5pJdIxnnVHQ/0Tkkf2ZdiNJI=; b=y0DR18OzL9/2LuQlfEMzVJCpdqnqOGvbKcgqsoo27Bb22BfU64cal0oUbtCv3YzujsfSCOEM2iQMJqgBa/br/ucmtOUgYsuEOoWqsn+sRoB8GrdpfzP6Z2ZL5iA5aw+UY+MNlalqRWyNFEaiyIZM/2/wB6ZCMrzS0iKRi3nvF8CRvT9+jcOBnGi3IgKcTfN+kFUDKUMLj9bOPT8PKISdQr/M8bnZAG/cKy865HKBxa0VCMEBkqrYG4QmLC8c4n1Nma8imorYVEDrMCuCWU3gm/HHL+TdKuPqSoX9TPmuPX6xofxrPjRb6LD/qExsvqzLYlLf/s0QAjNpHGDgpfFnfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 30 Sep 2022 09:50:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Henry Wang From: Jan Beulich Subject: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9314:EE_ X-MS-Office365-Filtering-Correlation-Id: d868520f-6d78-42eb-b8b1-08daa2b878bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q/W4TAiQ/nS9ULjd2lCh3472Tsnl59oPrbi4VUvK3MLkjf1oYQIe6i8f/RAnLTicxYcJ2rBwfkxiFzcxs4Ng4KJQvUBiwfJ/FEfiiYWpjdy/wMZuxkFEMnfoq9W7kMBNNN/2l7aYUHh63xyggUp0I8bkUHYtpaQFvJ+wEkZimZXOZnISE5i35nC/TOlgEmxOKaKl1dAoknFkUuLf1LJrX6D51cXYhh2FlmoJT6wl8NtbJy3qmbL24T/r3nQaW91dqUWhqNuWTJYlkaCtkxD1l51tB5BaS+aJIgtaVfMNmWN4llhKjPdvU6MfbpjnTidgRGdatGMuAogWrYMvwhlNdLu+8vfhBPDcHMcrx48dLMkkxqfDDZXE7vsqY9Zxrs3eBw1SG2zL/s+9q0Up83AR0u8BwCHphvALchFPBX2+OSPW8FHn949MTscGI8BQv6C3pP5PX72VRado3xa9EXDAhzr5yLOnn6QqcmFOwp8+ZYxfg2I42Uo0fAIphq1/i5q7AKJk1wzFlyQIxMZZPJV9LHhiZ3uDsHOqfsw8vWCG0COWnr3jXrBtbWOeWkWhkSjRTCN+/u7dlLL4RnEboxP4aH91RFLjWnxTk+5aoLHG6pD8JJcmiQD/4q+RUH/f5mgqb1nIx60rZ6pmfoLqmRl5u1qORH1J9O+DojI34EhzzWdCS+oXrC3LJ6No8hacqjDAquHlWOfPzCQFxIlm52hOXOJgA1M1+Dj4ZI68gGJCWxQbfbw7/Nl9/i84AhgTFxMV0A4RdU4TS+4MB7mXrDZWDS5aEVD4HdF1VkDdo0ltROc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(346002)(376002)(39860400002)(451199015)(36756003)(54906003)(6916009)(86362001)(31686004)(31696002)(38100700002)(2616005)(5660300002)(83380400001)(2906002)(478600001)(6512007)(316002)(8676002)(186003)(66946007)(4326008)(6486002)(6506007)(66556008)(66476007)(8936002)(41300700001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmhPSWtxME5lTkN1aVNkQzV6QjlvaVBVd3llUXdSdnc0NUsxaXhlUWJBQmt1?= =?utf-8?B?czNjb3l6dVhuZ1YyQVlsZDB3S1grWTZrTEwzWGFiNVJNWHZ2bjcvN3lvUU1x?= =?utf-8?B?UFNRY3RzMGwydWcyeXFoS2JNRzhucHpNNkpMbEhUSjVhSGc3R0hKYVgvdWYr?= =?utf-8?B?WDdMd0M4bUJ0VEZyeERvamFCKzZCQUtsSWZLY2lzenZQSVZCQ3NaL0xYOXpv?= =?utf-8?B?Y3Q3TXRPZGpLU1kwOUFCQXRybHVid1RDYmxYK0d3UVJReTNGRXZrek4xcnJI?= =?utf-8?B?dys4VDhjM1Z1QlpxTGtCa2hPUnVyU3RaOWlwV0ltZm1KS002RERVMG5UR1JE?= =?utf-8?B?a2lqblVQNUNEWTh4Tm1SNGZ2TEQ1VmRKNmplRC9XYkVtMnI1eTJTSmQxdnZZ?= =?utf-8?B?dE5VOHNiRmt3ZWdHQXNvNkNURWk5Y0RBTFJ4bnA1eFBPSU5mUU40VFU4bXhu?= =?utf-8?B?MmRJb0RqVCtZTEJ6UFpxb1V0NitMSHRQejdCTDdDdFVQWWhQWHdqWDBNRjNQ?= =?utf-8?B?cFlFa2xaOXVPYk9JSmg1R1RvNFVyU1J4OU1VM043RnovQStBYlJzK2NiZUc5?= =?utf-8?B?azNHTFdsR0psZVo3TW05bXN1bjlRNlVhRE9IN09GQUZONk8ySXZvZm5PbktK?= =?utf-8?B?cGZiUWNvSml5QjNvMkZ4SzhCTWd0eTErMWJ1VUZzYnRUVlAyVU40ZmtKZTVk?= =?utf-8?B?Q1JFTGd0bGZkM285SDlDUjduSzVIRmg3QWFRcWk0bjZPMld1OVhFYVhVS0lD?= =?utf-8?B?QjRGRmtDWHkrUVpjeGhGMWtrYVZJNEZsVWF5VDhCK1N0OE1MVENtVU5FaVRn?= =?utf-8?B?RzRjaE5TNWZ6TnorMWhHQ1hIRURNQm1OVExra3JCanU5MHpJV1NjbU14RDVC?= =?utf-8?B?eWpRMDR2ckJxak9qcUZkKzJDVUh6NVg2cmVLalg2YWR0UmpQVmFxMVBQTW1I?= =?utf-8?B?VGRZLzN5VXloa25BeGx6WWxhc0NwWWxTWDh5OXNhMUlWcFRQRW1TR2R3Qkl4?= =?utf-8?B?REJmUU9Ib0poV0w4YnR5TENlZ3BpOFhyKy9NNWJsQXhmQnhKcW5Bd2FqY1NI?= =?utf-8?B?dlNoVnI3anpKOXlJLzZrMThUME4yR0J5cHp3S3dNWGhXVFRLeFY0Uks2TW5I?= =?utf-8?B?TWxqZWtvMHZDdk5MTzJvNnJvTzI4VzRxSVg5QS91ODZuTk5TdWx1a1BxNGRU?= =?utf-8?B?ekR1K2Y0SmR2RGVCMTdsV0lkWXhBR3EyZmhyVzEzbDZZSFU4RkxBL3M3cDNJ?= =?utf-8?B?a0NJL3U0dUVVQzVuYTRMakhCMzRZcFlSa0tGRXh0Mk1vR1lxbUdtYVNmb2RF?= =?utf-8?B?ZkpmNm56YkJYVE1kd1FvR0pZZkF3ZWh1UGRJNEhsUFBrT3lOZUNHcEszVzk0?= =?utf-8?B?QTZJWVVobEVnNU9JU3Exa09PNmZRZFBMSlRsb1ZmM0lwVXVBcGdKb2djcUhN?= =?utf-8?B?QTMrd2VEYXBuay9RbmJRNjg3dm1FUmhNTkNxYkE0MFd3NDE4VEtWSXNxNU9i?= =?utf-8?B?WHYzdXh2Z0VOa1hPZUswd1Z2WU5SeTlkMm1aNjdlN3Y1UUp6YlFaelJWNW5y?= =?utf-8?B?L1l2OEQ0OTZGcEhIbW9HNU9HTFphbXVRbzhIdTVJZHIvbS9UQ2JhbTZSZm5l?= =?utf-8?B?NVFWc3hEVWtRQjNkV1QrY1RrdmU5ZmhUUWRONnpzTk1VOThHWjlsTGtkUm81?= =?utf-8?B?MlhIZlNTYS9WTmNMS1I5djl0VE1WT2Y5QjgrN2FTelZ5MU15bHRWMm5hVEtV?= =?utf-8?B?WE9mL1pkY0RncjB0Nis1blladVlxVlFuTHhZSmQybkF0OHk0QVJjd1lRYlIy?= =?utf-8?B?MmoxQkJUeEx3OUxzSGlOVW9jLy9XeGVuNFNpSVBxcDVCdzBpdi9WM3dCVkkz?= =?utf-8?B?a1NtM2x3bWo0U3NDVVp0Q0gzVnNWZ1BsK25QOTFTS3AzNlNtV3NnakpkM3FK?= =?utf-8?B?OFRrQ1RsOHVwQVUwV1FKRzM1T3hNSGwzMGhpc3hqNWtLQTZMR01QMlh4UXdk?= =?utf-8?B?MXFGRkZvM01qZ1VETFFFK2VYdG1uelk0SXVsNXZxa0d2RjFYZGduR2xRVjVT?= =?utf-8?B?ZEJYdFBqQlI5MTcybG5ZOXNPSnFhQWs1ZXNHcGxzbFFuYVZrcjlKZG55MFdY?= =?utf-8?Q?NnqjK94Zk6LIEvWK92Pn6+e0g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d868520f-6d78-42eb-b8b1-08daa2b878bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 07:50:41.1068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N0w6Nq7u/BzLdqyY/gLQJaClzPriz9WFQxv7RDWmvfz5pgfTI96fMPqzfPWXwbyR4voLXSpsKovz4qf+GBEd8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9314 efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME higher priority than the type of the range. To avoid accessing memory at runtime which was re-used for other purposes, make efi_arch_process_memory_map() follow suit. While on x86 in theory the same would apply to EfiACPIReclaimMemory, we don't actually "reclaim" E820_ACPI memory there and hence that type's handling can be left alone. Fixes: bf6501a62e80 ("x86-64: EFI boot code") Fixes: facac0af87ef ("x86-64: EFI runtime code") Fixes: 6d70ea10d49f ("Add ARM EFI boot support") Signed-off-by: Jan Beulich --- Partly RFC for Arm, for two reasons: On Arm I question the conversion of EfiACPIReclaimMemory, in two ways: For one like on x86 such ranges would likely better be retained, as Dom0 may (will?) have a need to look at tables placed there. Plus converting such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to me as well. I'd be inclined to make the latter adjustment right here (while the other change probably would better be separate, if there aren't actually reasons for the present behavior). On Arm efi_init_memory() is compiled out, so adjusting Arm code here is perhaps more for consistency (not leaving a trap for someone to later fall into) than a strict requirement. I wonder though how Arm has managed to get away without at least some parts of efi_init_memory() for all the years that ACPI support has been present there. I guess this is connected to most of runtime.c also being compiled out, but that continuing to be the case is another aspect puzzling me. --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -183,13 +183,15 @@ static EFI_STATUS __init efi_process_mem for ( Index = 0; Index < (mmap_size / desc_size); Index++ ) { - if ( desc_ptr->Attribute & EFI_MEMORY_WB && - (desc_ptr->Type == EfiConventionalMemory || - desc_ptr->Type == EfiLoaderCode || - desc_ptr->Type == EfiLoaderData || - (!map_bs && - (desc_ptr->Type == EfiBootServicesCode || - desc_ptr->Type == EfiBootServicesData))) ) + if ( desc_ptr->Attribute & EFI_MEMORY_RUNTIME ) + /* nothing */; + else if ( (desc_ptr->Attribute & EFI_MEMORY_WB) && + (desc_ptr->Type == EfiConventionalMemory || + desc_ptr->Type == EfiLoaderCode || + desc_ptr->Type == EfiLoaderData || + (!map_bs && + (desc_ptr->Type == EfiBootServicesCode || + desc_ptr->Type == EfiBootServicesData))) ) { if ( !meminfo_add_bank(&bootinfo.mem, desc_ptr) ) { --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -185,7 +185,9 @@ static void __init efi_arch_process_memo /* fall through */ case EfiLoaderCode: case EfiLoaderData: - if ( desc->Attribute & EFI_MEMORY_WB ) + if ( desc->Attribute & EFI_MEMORY_RUNTIME ) + type = E820_RESERVED; + else if ( desc->Attribute & EFI_MEMORY_WB ) type = E820_RAM; else case EfiUnusableMemory: From xen-devel-bounces@lists.xenproject.org Fri Sep 30 08:26:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 08:26:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414070.658146 (Exim 4.92) (envelope-from ) id 1oeBLA-0005vk-Gs; Fri, 30 Sep 2022 08:25:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414070.658146; Fri, 30 Sep 2022 08:25:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBLA-0005vd-EF; Fri, 30 Sep 2022 08:25:48 +0000 Received: by outflank-mailman (input) for mailman id 414070; Fri, 30 Sep 2022 08:25:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBL8-0005vX-Rp for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 08:25:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7956d500-4099-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 10:25:44 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 04:25:35 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5164.namprd03.prod.outlook.com (2603:10b6:5:247::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 08:25:31 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 08:25:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7956d500-4099-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664526344; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3htbdq08XU20V81TZSBPxc0PtkQVXb3Jox+AYgGdSec=; b=gNBjfdEiZ/R8+zci0UCUMVQBKOqLg67BnuJTM2GOsBqcyNtm8ZdU9GOX shPcHRKPuzXWkFtK1mxc8G47T3xEmDhfk5D7oKokKiVQYsXqZZ4o0QrSx PKkSSZA323MxlDEzWyPErxqxkvhwsMVut5j3m0cxjboTRJsDHR+FMjrjv M=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 81341343 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:WFLNCq8LbNO4SzqO9izoDrUDm3+TJUtcMsCJ2f8bNWPcYEJGY0x3m mYcXzrQOfiDMTbxet5xPYzn9EJQusXczdVgSwptrSA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvnrRC9H5qyo4mtJ5QRmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sNrK3B2/ P8yFB8Uakmvpv+u37CEa/Y506zPLOGzVG8ekldJ6GiDSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PtxujeIpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toiv32raUwXiTtIQ6EL+9xOFXqn+p/TYONyw3cUPnmvyXoxvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/v2ARR/vbvTTmiSnop4thu3MCkRaGMHOykNSFJf58G5+d5oyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsjDGJ5T+REMWTm0Ms= IronPort-HdrOrdr: A9a23:9bdxi6/YBmwzn5d1Gbpuk+E9db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlGl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFfJccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiT7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri+knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYd099RrBmc8a+d RVfY/hDK48SyLaU5mZhBgl/DWUZAV+Iv/cKXJy+vB80FBt7QNEJgUjtY8id0w7heMAoql/lp v525tT5c9zp+8tHNdA7bQ6ML+KI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA= X-IronPort-AV: E=Sophos;i="5.93,357,1654574400"; d="scan'208";a="81341343" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYLAVYIUWR98079RZFIHkGyGWzrbH3NTkHJ1EFWe4pd4J3xwXW/px96LiU83KnAwjYBLjDZmaxJ+WRU0oXovBD4471ZfPxuF4MzS238FtiQHCydHDjN+Ha7D35Bt/9ZTUBNW6QNg5tByTU1bIuYJpGRjwKrrGOd+WKb+ov1jlewUNOjxe+RuFRvnB6xbJX/NzjpGJgE64lI4Q4vnsImwd4++00dO7xtqdhM4mL2WLblBcSZ+Mxcog4XWJBWg0fVWDNLx8987Zo4qWqE+3k/r4fulfYBYdqaR7JvpspcDnHqsbFW4MImxdjLkknP4SVIPzdvNymGgmakQHqo71nShaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uh2r5wrtrLXWOlC57QQzNkBMW+t6CAM4JjuYa45kB4s=; b=PxCM6fIjGrpU2rnsSYGCWL4XRuvQP1POZpCusEyWBs9weUiLYGkQgO3yKeWBt+zlPg1OxUCWH2wlrvOUB1ao7JE4iMgvK7tGrBeacouHmR4sc7jsKTzGBWEw1iDkEBBKeGWHfjQC3lzhPMnac4DHDrDPBJK4uKAXJfuJ1yF3VFoqywTsfyl9yhKL15m/FPd/W4IjxO1AanowuYg5ySF6HAobX/m2DYWYVTn0SkMTKHKBXHkoBks0FCH9j0Uct+7A2eJAnxSSOgtsArKjMoDsrAvBqSZpqO1iA14b58cbJKJ5C536SabfYieMfmX2yZIavnE4w4NeeQUAY9R2Xi73Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uh2r5wrtrLXWOlC57QQzNkBMW+t6CAM4JjuYa45kB4s=; b=aHJHRPYIA/MaxgTVyGfelrvKfUi9YX4VnnNUwsEbQZBCIGVA6vpzdZcca//65DB6D6sFR7IirPka+xxM8EnKkbkGIPqBRI2uC45aa7Aboi29lWlFhO4zgYTDdxXAiUhqGg01dZgEDxUKSSJJI32UgPLCCeVq4b812eEGoh0Q6BY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 30 Sep 2022 10:25:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Message-ID: References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> X-ClientProxiedBy: LO4P123CA0135.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5164:EE_ X-MS-Office365-Filtering-Correlation-Id: 79db51f4-c70f-4655-20a9-08daa2bd566b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YCSvdnTVaJD6CjYGmcrVcuqvyYvKbiVZ9irgrfbwQMDUUKIiNoqZoELrbIPhhX0DtU5tKzgr9w0i2DLggR5nNzC70ZPoeXxWlaauSmZvbelYgZ8rfjE6aZDwgJbeFl8iX0iStYpN3DdHLcbK/5VCm19MBrBRuJKMo5v+k9A+/AjiIbCm6I2/0Tacy9cxluaoOwfvst5KALriwCO6a7XoAmgF2bmOfib4Zzk9xMH/j0UJyPWEEZO/wy5+NK8+n9uQXv4xOnNSnidaFwyuLEGBhDohkFZhaUWN5VncpXgKH1hus6G8ObsDm8OWtDP9pFbELHa7lgFAK3l+gFqmYu53IniC8t6kjezQOXZYdtpG5PQ1fTPSgNyq+BKdeS/lRzoY92Un5BR1nsgjaM2fsAnhb7DYnlDbFRRCizqHQYW90osD7/afyRhytjxcIiYK8nK5s+rkK2BOncz+K8hJ/CagH3T9iTxNMH14Js5/UA3HZ8DKP4T8IQgE9q+xr4c2xg9rLnN1cLaWXwoanjDAztKJUug3KxBibUdGLHlqxanUJjLoU+yNiM0gKzM9CKbcLg4plSu3aXCuQkXR2nlvKnn9cL5f7A8/Hoq421B6nWwBZwkF8CiStlalPbahNtJfMtwqr7kORLgClOlRH+JMdA4dy1Qlng0Olyt9HpVeZGjW6+eBjJiLKniLzqG80sDzC7UQn/DpPTcshLoEL5jMfJ66BA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199015)(316002)(82960400001)(6506007)(8676002)(4326008)(66946007)(9686003)(66556008)(66476007)(6512007)(186003)(26005)(86362001)(478600001)(6486002)(83380400001)(6666004)(54906003)(6916009)(38100700002)(85182001)(8936002)(5660300002)(2906002)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDN4eVJOZ0xOWkNqd1R4bG9Pd1k3enJteWtoSVYxZmdxUnBWQk9XVUhpdU5Z?= =?utf-8?B?aENJWENXYk1HVHhYYUQ2QWl6RWpzZjFTSitCZGlQMUJRN1pLd2k5NStHZmV1?= =?utf-8?B?dXNjRGx0L1ZaK0Fxdy9abFdzNTM5SWtGZ05kS0NQN1RuZE9TZkJFMXRUdjFJ?= =?utf-8?B?b3dVU1hMQUNiSW9BZU5BZFJkbGRDa1BtOUNyenlrMjBxaGRxWEhFaEVNTUJh?= =?utf-8?B?Wmw5bUNIdjhzbzlOek5OYkxLbnBCbmh6V0ZNRGNucnZlWHFzUGs1UTVNbkZw?= =?utf-8?B?dktHWjBJQ1JmOXFnZStkRVpOcW9zeWN6VnhWLzNiMllVK2FrV2Y2cFZGeFJX?= =?utf-8?B?V1huM2VHOXlJenFpMDQwWHdiTXdyVkZZa09rUS9hbHZnTWFZSW11bWMwWTlH?= =?utf-8?B?b2RiVkUzd1pxTHhrNSs1VlZNYnNWK2JCcHJHbzR0NFFsc290RGlIc1NxYkFu?= =?utf-8?B?MXY3S2QyOE13QjJEWkVJT2phTGpCT0d5TzFrOUYzSU5GWW1ZdG8wK3MxTmJP?= =?utf-8?B?ODhCVmtWZXR3aGVWTWI2U2FpV3dHaU1LUHU4ZHBGRnJiaUVGcGRoemFuVlNT?= =?utf-8?B?cjFVWlpNWGVNbHByUFN1b01uQ1V4dU1BVkRpQm1XdHQwNDVjeEFxTjNRbE5a?= =?utf-8?B?STZGaERyMXdZM1VuWmNVaWxCUS90VHFNZGN4NjVJam85bFUwWlo0MnZ3SGl6?= =?utf-8?B?alhxUmZNcFBUcG5LMzhzRnF3ZnFFeHA3SDFua0xuUmRQN0ROeVhhOW1CY0p0?= =?utf-8?B?SlJ1YUFrTXplcnovN0pWQnpoNWpmQWs0ZExYeVhSNmNaTjc5YStQejdURS9Y?= =?utf-8?B?RDcvUXg4cUE4U0trcEJaWWdBNmFOQTAxbVowRjdHMUJmaHFYZ3Q3c1g2QjRx?= =?utf-8?B?a1U2TnVGWFJSYjEyUXhNQ1BkVitTS2JJYjM4VndNS0RXNFRWVjNmSmMzb05D?= =?utf-8?B?Q1pYNWhud0c1WCt1NG5YV0kwY3I5TlUyVjNOSFZqQ3ZFNnVZcWdiZ2wyZTNF?= =?utf-8?B?ZXJLN0JBSUZldkNQZTI0cTVRTHVnQy9SVTFsS1lBTndqWEM4RVU4TVpqOXVN?= =?utf-8?B?NCsvdVY4QWZ0amVKLzF1VzV6UmxOZ1orMGV0eWhtRUtud0ZBdUxXbGlaRkNj?= =?utf-8?B?TjYyZVVDSDR5UkVSbHhHeFJCc0F0SlRqdUczV1FXMGhBMFkvV1FSaEFicEM3?= =?utf-8?B?N3J6ckVDOWVuNE1sVlVyczAzSzJUcHZlRmJFSDZRcDBscDJKU01yeXJreDZZ?= =?utf-8?B?V2hFMWRqZmJzbE10SVd1cnF0bmdhdzBhSDZCNWJ5OVFuTSs5cEZqZHBPdkRQ?= =?utf-8?B?L0JvTUR6WE9QcmphQzM1YmJaZE1CQVZzTXdqUDNWSTBPRlFZMmtGcXc3OVd3?= =?utf-8?B?Y3NMTXlBWmdQVENwU0ExRnZURDBHY01aZVlJa3BKR3JaYzJvSm44Y3hjNmRi?= =?utf-8?B?UzZXQnNyR0VmNHVhWFBmWGluYWQvbmJPN0FFQVlyUFFJL1ZsRW1Ic0lPaHA0?= =?utf-8?B?eW1oUmlMcmRBa3kvK3o2SE45MWlxOUFCT0Yxb05KeXBxTHA4b0x1NDYzYWxS?= =?utf-8?B?TGpsNFlWMm1VWU1TdW10elFWd25xWnZqaFdHcnpIWHdSRWpPMUNEazlVdFFP?= =?utf-8?B?NUxBWkZxamUzVFA4WEpjYjlhcWN0MWJTNEFvMkNKb0tQaFNpQzllVGwydkVY?= =?utf-8?B?QUtUMVFnNUFoYXc3NnNYNTh5UkVSWkxRd2pEaGZDdEk4K3oxdk4xOVZGVGdq?= =?utf-8?B?M2RzZGhJTHIvb3pvU0d3bVl1UGt6alRoejAxTVFQQ285OU1iVFlLY1N1V1Zy?= =?utf-8?B?eW1NMTVzVjBjcHNwZXg5NEJpbm83T2g0Vi95c2M4SEp2bHlrSHpDZHdBRkFI?= =?utf-8?B?eTdmUnphNkt5NDdncHZDL3RBSGJWR0FHcjlhc1R0eE0wU2RFV1E5WFlkY00r?= =?utf-8?B?VFFFbVVQZFRrc2pZSHJ1NjNLRldRNytONDFLd1IrQndmcE5Ra2crcVJSR1dJ?= =?utf-8?B?OGNoazlsNzQwQUlKVGlXOGFjYWI4ekhHU0VRVWZPd0NsRFpqNWcyd1VtRDli?= =?utf-8?B?RXprN2cyMUl0UzcxS3ZVUDFCUG1tQWlpZ0RTT2tONGlHYTRVanhMZksyb0xT?= =?utf-8?Q?QJWdYMVjySjTiV6LBqr2N6Phj?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79db51f4-c70f-4655-20a9-08daa2bd566b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 08:25:31.1237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Np+Dw3b0Uptw/zHfVHw+paxzUr52r9wjw/h41AYCtinK3WNgCWu4+0XA6crXnqE/+VB+m0nyF7PlFpu6mK4FfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5164 On Tue, Sep 27, 2022 at 06:20:35PM +0200, Jan Beulich wrote: > SRAT may describe individual nodes using multiple ranges. When they're > adjacent (with or without a gap in between), only the start of the first > such range actually needs accounting for. Furthermore the very first > range doesn't need considering of its start address at all, as it's fine > to associate all lower addresses (with no memory) with that same node. > For this to work, the array of ranges needs to be sorted by address - > adjust logic accordingly in acpi_numa_memory_affinity_init(). Speaking for myself (due to the lack of knowledge of the NUMA stuff) I would benefit from a bit of context on why and how memnode_shift is used. > Signed-off-by: Jan Beulich > --- > On my Dinar and Rome systems this changes memnodemapsize to a single > page. Originally they used 9 / 130 pages (with shifts going from 8 / 6 > to 15 / 16) respectively, resulting from lowmem gaps [A0,FF] / [A0,BF]. > > This goes on top of "x86/NUMA: correct memnode_shift calculation for > single node system". > > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -127,7 +127,8 @@ static int __init extract_lsb_from_nodes > epdx = paddr_to_pdx(nodes[i].end - 1) + 1; > if ( spdx >= epdx ) > continue; > - bitfield |= spdx; > + if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) ) > + bitfield |= spdx; > if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] ) > nodes_used++; > if ( epdx > memtop ) > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -312,6 +312,7 @@ acpi_numa_memory_affinity_init(const str > unsigned pxm; > nodeid_t node; > unsigned int i; > + bool next = false; > > if (srat_disabled()) > return; > @@ -413,14 +414,37 @@ acpi_numa_memory_affinity_init(const str > node, pxm, start, end - 1, > ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); > > - node_memblk_range[num_node_memblks].start = start; > - node_memblk_range[num_node_memblks].end = end; > - memblk_nodeid[num_node_memblks] = node; > + /* Keep node_memblk_range[] sorted by address. */ > + for (i = 0; i < num_node_memblks; ++i) > + if (node_memblk_range[i].start > start || > + (node_memblk_range[i].start == start && Maybe I'm confused, but won't .start == start means we have overlapping ranges? > + node_memblk_range[i].end > end)) > + break; > + > + memmove(&node_memblk_range[i + 1], &node_memblk_range[i], > + (num_node_memblks - i) * sizeof(*node_memblk_range)); > + node_memblk_range[i].start = start; > + node_memblk_range[i].end = end; > + > + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], > + (num_node_memblks - i) * sizeof(*memblk_nodeid)); > + memblk_nodeid[i] = node; > + > if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { > - __set_bit(num_node_memblks, memblk_hotplug); > + next = true; > if (end > mem_hotplug) > mem_hotplug = end; > } > + for (; i <= num_node_memblks; ++i) { > + bool prev = next; > + > + next = test_bit(i, memblk_hotplug); > + if (prev) > + __set_bit(i, memblk_hotplug); > + else > + __clear_bit(i, memblk_hotplug); Nit: I think you could avoid doing the clear for the last bit, ie: else if (i != num_node_memblks) __clear_bit(...); But I'm not sure it's worth adding the logic, just makes it more complicated to follow. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 08:28:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 08:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414075.658156 (Exim 4.92) (envelope-from ) id 1oeBO4-0006Wx-Uk; Fri, 30 Sep 2022 08:28:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414075.658156; Fri, 30 Sep 2022 08:28:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBO4-0006Wq-S4; Fri, 30 Sep 2022 08:28:48 +0000 Received: by outflank-mailman (input) for mailman id 414075; Fri, 30 Sep 2022 08:28:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBO3-0006Wg-MB; Fri, 30 Sep 2022 08:28:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBO3-0004Pl-Hr; Fri, 30 Sep 2022 08:28:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBO3-00065Z-AT; Fri, 30 Sep 2022 08:28:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeBO3-0002o5-9z; Fri, 30 Sep 2022 08:28:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4O3ibnnXtBfHvRSmgiYjZHtysRD/5ClbbR7hR5dUt0s=; b=lHGQJjAc1Th5Ol/FGYzuBvHDis bBRmM2OvTjZvBfJ2QntAk0hu8Jrd0wE9WtIRDbJ1WmGicFLkKoGvGh2Lg+2nm8ZrohVsvXGN+gpXt 21mlI7HddtrzjpYwQ6PwyU+WzW8tNhq33B/lJ+AIi1yOBsKuKB6lx/6D5uZXJJ9ChYeE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 173381: regressions - trouble: blocked/broken/pass X-Osstest-Failures: libvirt:build-armhf::broken:regression libvirt:build-armhf:host-build-prep:fail:regression libvirt:build-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=85aafea4499b20a43d5c208143fc1582ab3d6c84 X-Osstest-Versions-That: libvirt=8ead926cb46f1892116cb56aa89390d194ce0b71 From: osstest service owner Date: Fri, 30 Sep 2022 08:28:47 +0000 flight 173381 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173381/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 5 host-build-prep fail REGR. vs. 173345 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass version targeted for testing: libvirt 85aafea4499b20a43d5c208143fc1582ab3d6c84 baseline version: libvirt 8ead926cb46f1892116cb56aa89390d194ce0b71 Last test of basis 173345 2022-09-28 04:20:21 Z 2 days Testing same since 173381 2022-09-30 04:18:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kristina Hanicova Lin Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken Not pushing. ------------------------------------------------------------ commit 85aafea4499b20a43d5c208143fc1582ab3d6c84 Author: Lin Ma Date: Thu Sep 8 15:07:22 2022 +0800 qemu: Remove host-passthrough validation check for host-phys-bits=on Besides the -cpu host, The host-phys-bits=on applies to custom or max cpu model, So the host-passthrough validation check is unnecessary for maxphysaddr with mode='passthrough'. Signed-off-by: Lin Ma Reviewed-by: Jim Fehlig commit ba884de786e07e2a3addd68f2e587e306ee16cab Author: Kristina Hanicova Date: Thu Sep 29 13:56:30 2022 +0200 virdomainjob: preserveJob: memdup the cb structure instead of copying it In case of variable 'oldjob' (job structure) in qemuProcessReconnect() the cb pointer was just copied from the existing job structure in virDomainObjPreserveJob(). This caused the job and oldjob sharing the same pointer, which was later freed at the end of the qemuProcessReconnect() function by automatic call to virDomainObjClearJob(). This caused an invalid read in and subsequent daemon crash as the job structure was trying to read cb which had been already freed. This patch changes the copying to g_memdup that allocates different pointer, which can be later safely freed. Signed-off-by: Kristina Hanicova Reviewed-by: Michal Privoznik From xen-devel-bounces@lists.xenproject.org Fri Sep 30 08:36:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 08:36:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414087.658168 (Exim 4.92) (envelope-from ) id 1oeBVX-0008DK-VS; Fri, 30 Sep 2022 08:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414087.658168; Fri, 30 Sep 2022 08:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBVX-0008DD-R7; Fri, 30 Sep 2022 08:36:31 +0000 Received: by outflank-mailman (input) for mailman id 414087; Fri, 30 Sep 2022 08:36:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeBVW-0008D7-H7 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 08:36:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2083.outbound.protection.outlook.com [40.107.20.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa6bc32f-409a-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 10:36:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6919.eurprd04.prod.outlook.com (2603:10a6:20b:10e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 08:36:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 08:36:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa6bc32f-409a-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gt0QJJNnmV9AlTrf6BZnVs/voyMgwzzAWtQSzKPCiFbyZlJO7BQ8Wwq4okSbjW1tMoUZr7fvAg+BPBhxb8kbTNZGWPAaYWVHWro8DrhyEb9GjZfZXO+1Y3gYNBE7naWMykkIXZx9cgTsHxv+3AhJoLnA2BsfXPHHHSEA0b8B8EerR4nP04X0FaYydYRJKTTOZVh88Lz5AYm18l3KPafebJtu7B+hTPLh+PhAAwP2h93YR0YeIAL85D0rWqtsX2uiYOdGDyZ3upfkGIXr/lpdiTXdwp06mIUu/WmmeqSefsohO/xMJh/rUrSMPa4qrbN3RJE7O5WsJES0l4vXiKplsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qvE2Hj0t5QUvQsd6fn3XoiQAlMmNPdrwVTOWgCLm0ew=; b=NDPoDbiuIqsUX2PNI0njmS3XEVK3b5ZmhnoxDPBiDLaA50FT2qNazFPHspyQ70z5sav/NNhl1MfHgY3f5j1R7TFLTEhtgcWIPEeODcKr/NnRRDYJefqwS9qmQKzq5UE0RsTuC8/5L/kdkE61ppQe90D+MoySoHKdFuvYtGdJgc1V0q8UmkNydt6KvTM8Iyz1jtNjYxFrOD0UmP3COiBSoM6uvk98+DFuCrxgIdl/MupQU59Fl3xS6YY6a15poz4t5w7brIf9x300BN0egW/FgxIJygnt3MfzLOjCPpfK7ldrEUhBhUBjBpOQ4Tg5670nB8M56+22d2iaUTai/jWPrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qvE2Hj0t5QUvQsd6fn3XoiQAlMmNPdrwVTOWgCLm0ew=; b=X4IfrEkYeXKYwB0Ap0Z+qV1H0yCMPdlstEdreetRygQlknpy3wxOMxTK54tk4SU6HzEoVyH8Ys+2Mup3Zi3bK1paO1Lk02C916gYQmhiEkiNPEydwHO5lCYSKwumYBxCmj5H6LPK+HBs8JG1OKQQnktYt0cOZtCposziwVPw9yuuBtnmnVyjbGFBz8eNWD4V+Y6FIJRnK8uo5GyXxQvjzSOCKoytS9Xank4l3TW0qbERYD0S3mNAoX6dzWWY0ozDQOdkip6u6kIW3gCx5hbXcqamu326W8f0apVnvt9yIRJTMPS7CDfNw96FTHSYvGFkKfZlRd0nKcoMX5ZtWpmUKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 30 Sep 2022 10:36:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P192CA0008.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6919:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e22e528-3aaa-4b70-7140-08daa2beda3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QZeWY4d2HXa7nnPdhaS/0YAUwPEG3m9BK8CEH2tZ/f9g+/jbTwrXctjVyxrjG+jKWMha6iiczS490J96wvSvfhvnobrUYCrwNi0BA14ADwjifMmTxoeeJlIUoNoIxxq1TcWZpUISt0UEI+S5pVHHtE1sai02LVQSAI7bqKuiTHl62jXIBPiqiBpHXhkZ6XHGFeP5zq10hPCh9J4hDM8ap48k3xJDUfyMlJ3ubHZIrJnEenXMKhKeInusGE+oidktYISeXqL+0ylXtp+BVQz0vWWMvjhYdSuiV8gshV7+kIvDO51LAOKWwKlbqqUEDj3cKg7G7VNVykiIIl2cD6ocFIbcIcl7zPeY6Fuq3fhDXz2qjmsjFBl7NXZJjJvwkANfGoHmun8p/0aYUwE2ALkgz9u9BKh4JKYIrcA6F1X4MPRfAe7075PCEnmftAXkLtEoBs4uE5P2ltARsGouNEmHtwaeN51N1GEgWb4u25Ev2PLbNimZ3JkXPlGbieHg2pJG3TqEJlNiRlmgKmRTFkonyVZt04iJyIF/mBfVmRIsmRTaJVnQ8cJ+8H6W1Ugd7LVcJrGPSRZLxPAnwCx1R7nVz80gyF9BlgdOuGpcS8EHwyMlHShDXVONXDo37Pu4QNjX9BCl0kn9A2osD47s1J+TV92eIcMlRwE6oWYdVp255Ca3iH4SE9wpqKxuAdeFbYOdkMOdLTS3DS1bGmNY1WYSDiDFcjV1e15V10bw4UYLO9Hq8hJoRTvQUf+9AqAEEs14NBKfLMQPZd3TioEJwoLPcNIrrwIadWFziP/lG/OqsRo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(346002)(39850400004)(136003)(451199015)(38100700002)(5660300002)(86362001)(26005)(8936002)(6506007)(31696002)(6512007)(53546011)(36756003)(4326008)(8676002)(66476007)(66556008)(66946007)(41300700001)(83380400001)(186003)(2616005)(31686004)(6486002)(2906002)(316002)(54906003)(6916009)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGhZdEVEa3JiRCtsVk1WOHVWUEYvNFNjaEpQcjVUeXRydmZPelcvUGlJWC92?= =?utf-8?B?TjJWck5kTnlqYzI2SVdpYlRjRW5aWGNxU243OGJvK1Y2eDJtSXUrOFZuMUVT?= =?utf-8?B?TjhhdmV5Sjg4SXRybE5wVW0rUlhHeFNKNGZySWJQcHFLb1lKR3RuWTQxbjVX?= =?utf-8?B?UmhkTUFUR003SEZ2akVzdmxiM1RKTktPUjNJRlBvTExFc1BqaXpNOFVBd3dD?= =?utf-8?B?WmZVZGd0VysyYytzRjFxTytnMnQ5YnFWQ1RNRnFvR00yQzN1TWUyem9WdXJl?= =?utf-8?B?RjRFVDV2K3JNaFQzRXVNQmc4R28rVW9iOTBNam93TU9FYVdpRWhqUnpvWUlq?= =?utf-8?B?THFMRE5ROExVUjB6VTVHdEhNaXVBQUdDM2kwQm5kMWtYd2R6bXpBcWltMDdt?= =?utf-8?B?bHVCZEVmQzF4VE44MzZSeFpndjUxUjJjaDM1cWZQTGx4QjRNQ3dzVUIySENY?= =?utf-8?B?R1ZLQXhFOFc1bTJSMEdISkhNYUhBTjhxdzR1empQbnVnZTNXSnBhQVN2aXlG?= =?utf-8?B?SjV5ZDYzaTJtZWxUdFRYWGs1ci82L1pucWRkM1pKTWh0OG43cVN0VlpCdENI?= =?utf-8?B?R3NKZUQ0MFV5aGRWSHFYZkxYZi8vWGJCY0hWNW1aNUNpS1h6OE96ZEZlMHRJ?= =?utf-8?B?RzluczJVMnB5WnVYRm5FRW9BWE85ejVEZ1VDU2NPd00wNzJaY1pVK0YzSmlm?= =?utf-8?B?MnJIbXNvZnpZckExODc5UjRRT1FNVWE5bDdCK2doVEJ2dVRnN2lKZ3RwTUxQ?= =?utf-8?B?VHpSYSsyUXlSeHV3LzRqZmx2WUcwdytWQ3VHcllndHBGNHRvV3RGZWswTFp5?= =?utf-8?B?M0tYRmgrdUVKTld6NWFOSW1VUzBoRktZd0dtaitFYThQakNsRXZkc2R3ZGJ1?= =?utf-8?B?UTVodXplNGFkOHdWa0hLdDRyS3ZkSUlwQWtLTWVLaFdZNXdVQm9xRzd5YnVJ?= =?utf-8?B?N1FDb3BhYldmeHYzU1lYQ05ZNjlJa1BBRlc2WU1DMXE4MnVBSXVENHRxS2Nn?= =?utf-8?B?ZnF5Ky9QT25IVU45cW9RQzhUOU14MHZoSGQ4RXNhTG03eGR3OWE5NWRsQ2k5?= =?utf-8?B?di9RNVZaS2JaNGFQSXNKcmt1MVVXMHUvZHJNTzdoZ0ZaSGY2amhqTHJWZGd1?= =?utf-8?B?aHVWdUpyQS9NTW5DNVZPdERPWnh6cmtMTEd0VDdnNmJqY3dXZm9pSzhUek12?= =?utf-8?B?SWx2VnlDRmlCWC91bHVHbzRuZ3RscHh5a2xBVExBZysyVkl3M3ZNRlJud2VS?= =?utf-8?B?bnJwTkJmY1dWNElxN09qTm44ekpZU1grSURYN0YyRVBWL0VvYXJxUVBzZlMy?= =?utf-8?B?QWY2cXpHMnkxdVUrVDBxdFdIN21QcndHUGVYaklmekdKVnRkZGw1Q21GdDk4?= =?utf-8?B?T0h0M2ExWVJucjVZVG5zd21XV1NCVDR4eC8vTVRRMHJ2bnlwK3RFeHVRYlBL?= =?utf-8?B?L3BzTVdZRHRlTlpPejRnRm9ZRHpBL2FmZGpFejl4ZU5QMHdIWThnNC8yc0k3?= =?utf-8?B?ZE1ra3h2Sjhyaks2dGdGS01pZEd6MXlkY2M1Mk1MU01OWWF0QnRsdCtNQlB5?= =?utf-8?B?QkFWcHZPU2ZKWE1SdThUMTd0NXlOTmFoQ2J2K2JmNmtKTkNXQkJwMzhwWVRT?= =?utf-8?B?UFU0UWdlQzYzZ1BoV3l4UjlPRWkxZzdmeXJUUXQvNERDVERWTm5oaEUyZDdt?= =?utf-8?B?dG5BUzdyZE15OWRRN0FVa1hSNWJ4ZXdqc1JoNXBXZGN5NW85R2c2Nlk1Mnl4?= =?utf-8?B?RGpmQXA0cWtDeDlKdW9aWmRQWVdFbitKQ2wxa0krNGZvQlVsSzNmY3RxM2JV?= =?utf-8?B?Y1hYYy9iYnJIelhIZEZkR1Zlb3NWa1NPQldZOUhZQWdJNUdMd05qMXBpL2xp?= =?utf-8?B?bFlUS3JIZ2s0L0tBVHRJKzQ2Rmo4N2RKWTd5QzhtUjJtYVNBSkw0YmJ6QlFT?= =?utf-8?B?Y1d4VTFRQ0VSNE9NZ0NrTmNjQnJtWHU2VVRZYVBrUXVRdi9BRHZiS3VlUlVT?= =?utf-8?B?aW8wVTc0bnIxUGFrYzlmNjFIOFNNbHU3OTBmNklmVmhnSjVPVHJabTlYSXFP?= =?utf-8?B?YWh4TlZLeERxVFdVa2hINGQ2Nlo0UFQybGIwV1Z6U05NWUdQM09ENW4rWXMz?= =?utf-8?Q?E8ot/+NrEiAgmsjZISAemuffH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e22e528-3aaa-4b70-7140-08daa2beda3a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 08:36:21.7126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1kfwdal+UMvsYNmaauWfXauxv9i/eXGVzHJUboMtXqw+umA4hPSpERV3i5CiciX3bjmX8JiUUPYuNK13EcQf2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6919 On 30.09.2022 10:25, Roger Pau Monné wrote: > On Tue, Sep 27, 2022 at 06:20:35PM +0200, Jan Beulich wrote: >> SRAT may describe individual nodes using multiple ranges. When they're >> adjacent (with or without a gap in between), only the start of the first >> such range actually needs accounting for. Furthermore the very first >> range doesn't need considering of its start address at all, as it's fine >> to associate all lower addresses (with no memory) with that same node. >> For this to work, the array of ranges needs to be sorted by address - >> adjust logic accordingly in acpi_numa_memory_affinity_init(). > > Speaking for myself (due to the lack of knowledge of the NUMA stuff) I > would benefit from a bit of context on why and how memnode_shift is > used. It's used solely to shift PDXes right before indexing memnodemap[]. Hence a larger shift allows for a smaller array (less memory and, perhaps more importantly, less cache footprint). Personally I don't think such needs mentioning in a patch, but I know others think differently (George for example looks to believe that the present situation should always be described). In the case here a simple grep for memnode_shift would tell you, and even if I described this here it wouldn't really help review I think: You'd still want to verify then that what I claim actually matches reality. >> @@ -413,14 +414,37 @@ acpi_numa_memory_affinity_init(const str >> node, pxm, start, end - 1, >> ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); >> >> - node_memblk_range[num_node_memblks].start = start; >> - node_memblk_range[num_node_memblks].end = end; >> - memblk_nodeid[num_node_memblks] = node; >> + /* Keep node_memblk_range[] sorted by address. */ >> + for (i = 0; i < num_node_memblks; ++i) >> + if (node_memblk_range[i].start > start || >> + (node_memblk_range[i].start == start && > > Maybe I'm confused, but won't .start == start means we have > overlapping ranges? Yes, except when a range is empty. >> + node_memblk_range[i].end > end)) >> + break; >> + >> + memmove(&node_memblk_range[i + 1], &node_memblk_range[i], >> + (num_node_memblks - i) * sizeof(*node_memblk_range)); >> + node_memblk_range[i].start = start; >> + node_memblk_range[i].end = end; >> + >> + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], >> + (num_node_memblks - i) * sizeof(*memblk_nodeid)); >> + memblk_nodeid[i] = node; >> + >> if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { >> - __set_bit(num_node_memblks, memblk_hotplug); >> + next = true; >> if (end > mem_hotplug) >> mem_hotplug = end; >> } >> + for (; i <= num_node_memblks; ++i) { >> + bool prev = next; >> + >> + next = test_bit(i, memblk_hotplug); >> + if (prev) >> + __set_bit(i, memblk_hotplug); >> + else >> + __clear_bit(i, memblk_hotplug); > > Nit: I think you could avoid doing the clear for the last bit, ie: > else if (i != num_node_memblks) __clear_bit(...); > > But I'm not sure it's worth adding the logic, just makes it more > complicated to follow. Indeed. I did consider both this and using a single __change_bit() wrapped in a suitable if(). Both looked to me like they would hamper proving the code is doing what it ought to do. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 10:04:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 10:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414093.658179 (Exim 4.92) (envelope-from ) id 1oeCsN-00014J-B3; Fri, 30 Sep 2022 10:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414093.658179; Fri, 30 Sep 2022 10:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeCsN-00014C-8A; Fri, 30 Sep 2022 10:04:11 +0000 Received: by outflank-mailman (input) for mailman id 414093; Fri, 30 Sep 2022 10:04:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeCsL-000146-CO for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 10:04:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3771adcc-40a7-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 12:04:07 +0200 (CEST) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 06:03:58 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CO6PR03MB6209.namprd03.prod.outlook.com (2603:10b6:5:355::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 10:03:55 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 10:03:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3771adcc-40a7-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664532247; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=dyvhQqM3zw+q+Z2ExMdiluhz3OfGCk8UrPbZafiZ0ok=; b=OMtemyNiJkzMcLrxYq3BKmPCRudE0domi3AvxtcZX3c8n/4nr4hYfF8+ fTAuCZuic5aVFP3F2AdJBuU/JOOAHgKZXaHfXUH1rsrohZCiNrGWntHm1 /rI1k4EWNGb7bdVgfeG7BSrUMtR/7JR4kstBNbIun0uDr8KV4itUfMZtt w=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 80819171 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UNA/5qOMrnKptEzvrR2+lsFynXyQoLVcMsEvi/4bfWQNrUp01DJRy GQcDDqHOPrcYGCkLoxwPoi3/UsAvsXdmIUySQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaQr414rZ8Ek15KWp4GtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eMLEA9uF9Qlp03 6ISKRQPTi2Ntd/nz+fuIgVsrpxLwMjDGqo64ygl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTM+vRfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv GPWuW/+B3n2MfTPkWrcoyvz34cjmwu4cdwNLpe+2sVhkVu23kgxJwdPBFSC9KzRZkmWHog3x 1Yv0igkoLU29UerZsLgRBD+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ kCNt8PkA3poqrL9dJ6G3rKdrDf3NS1LK2YHPHYAVVFcvIelp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjvNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:UfOf+ah7LuSnb8FSXBTph7azm3BQX0F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nGPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SuV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A7eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1whq7VBaM0pd gsCZ4Y5I2mfvVmE56VO91xMPdfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q 6xG29liQ== X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="80819171" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fu8nIvjnh96LP+CYkujMPyOa8i05hnIG4SwTAXfsPzIFjlsuZuGkFF686mhTlyzWPrGDN8eZG2YF5XCrHwvGzskfRAwI1O7bGGwmGhloID1pzbllk7sjSMk4znmrVslMe0pKdyQ1CZnrFqYHpcgVuSQeXL7uOnKkIQv46/uGsTOuDsd5Ybz3zmU026yTCaE7BCh7K6DLhoMoJv2xSfw/S81E0pC23QBtk7QdIaFoSXZF9084uP6B5RpqSeWaVybTM44DXrXNyp9wsqTbO50HuPelPypgJRK5PSJJa4mllbujnjAI6N+RQnXNdtFg4Bb8xaI2j+zNzbG/zt9pCGHhPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuE1sTqW25DiE+I//Yzl82T6trxfFKMDCtda5z28jSI=; b=IWUBfX+tpmulQfB3+JCrlvTydGbZk8qANJ4kTuRQjbTTfVuP5KJHaGHeawER79BoflPfLxRDG+Mk5gyPciMb/MpRtLyLGk/iglP+CWvdeJU9OnwMUMxLCJgkD/zFKvtgPCt+AT5KC3yNbh+XuZM3n/Uw+QqPseKUVK2a2mrKD2MhzwdLvQvkXx+xJPzuiWq+ImU3AyizZEEEu9S2gJM9umgd6YzH+ltv5HnxfEZm1S3tBsX4oz83DUfDrNiZjIJAY+9c1SmkT3FgTeS1HjxKyMmDOWc572WeXl1xHGpb5IewREWt50rpGTHVW5Xk5TE7OCPNco+bGC0vwsCp2xKYwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kuE1sTqW25DiE+I//Yzl82T6trxfFKMDCtda5z28jSI=; b=Lsw0kRn8/+0nsvElMLVvnIVPShBjNu99P0HMiX1laEPtCo41Np/IiSYKHnjW70oYz7uPuawl7JoFeuf5rhNJ+WhKgxFcwpX4bq51Vuig/gJG2LLwjiDlt/iPiLR+6E3QJmMEd8T9dBmXYZPx3EQQwee2Z7rm66SZIh9yGSoPKUs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 30 Sep 2022 12:03:45 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Message-ID: References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0246.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO6PR03MB6209:EE_ X-MS-Office365-Filtering-Correlation-Id: 00ec9233-569e-4f71-e437-08daa2cb1547 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ccZ8Lbj4qAC/rxqvzc6bvtq/9LMLbyFjNL313vc5eScYAB7PslF31d2LQN7RIh+4FuSBaCWrXuVw67tNxwDoDv1pauF3u44luTBWdv9DTpUcYcZIT0JgScDu7JytGdcCxWUF7vL5xtXmCDWoKuU5CVVmtBekXL4aRChZYh839kyQQyJK1NszL9+prWzfpvNBLvZPA5UqOkEB77imqa1Jrk1mY7sSRSyBkDeC8JJLjD01otnXxhFb2UQue5P4lFUsQWvQMM0sqibumKoSZJIpduCUel56iEojUtya6RW/0PMdwuJ26idGlGr5rCt/yB/S91P+TL5FVvA7N8JzgXcVby2dyU0tJfpT2i56/yu5J8IT7hbZR4Wo5u5bUZ6E1ZNfORLvABiUGWzMLVWi2SKFcT+kvfFWax0KcJKI9EQ4INwnPPkVDdjwxWZubGHeqPLEPkClXBiu750ETwbmDkAtasnM4YFlb6zS+JBCyanumtJaS5/xR0h5jwQss3HHbDLksFOVxy3QxTnkccG0t6LOyhbDXb9X9cD6w+WPVTkMtORsaGsum+qa1o7xPq9I0TuyQ8uymWtxPSBYKuzw6VwzVA8ppIOG/WZYouM1dkY5iELvYXIE3wME+OUBLmSnbKZiY4lGml+fsuJgbHxEVLB3m10IyN+cYn15Pc0Oa9oqH7s+nh1jLhdfWoaMppXVPpszULTkxtkjvJiTI3XyHvSX0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199015)(83380400001)(478600001)(6486002)(82960400001)(6512007)(26005)(85182001)(8936002)(2906002)(6666004)(86362001)(38100700002)(5660300002)(186003)(316002)(4326008)(41300700001)(66556008)(66946007)(8676002)(66476007)(9686003)(53546011)(6506007)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGtLeVdCMFlNVjloK3hpbHBhVCtVUWMvRFBZY3BNLzVPd2lNRTRMTEcrU1Ex?= =?utf-8?B?N3Bhdk00NW9mV3h0WlZPTEsrdUZ1ZVhzbjQ3Ym81T2lyUUQ2Ni9NZkUxN0hB?= =?utf-8?B?RzVJUXBxTWVaVmhPL1JoNU56d1F2eWRlVVo5T1EwY1hYVGFMVmFEOXI5U1ZO?= =?utf-8?B?NEc5aE9mQktpeWhzcXZRNkE4Qjd5Q3NKam53SGxwSXJLcHdVT3pMZzBIR2VQ?= =?utf-8?B?S3FHUllFT1NBRk16OGlQV3dST3NndEJ4enIxdHFNNE1PbTEyWlZLQkJEc3lY?= =?utf-8?B?dUMvdmgzV2kyMDB5cWxZMG5oSG1XbFEraXRGLzZFUmh2L3FMU2RWRmN6ZDhB?= =?utf-8?B?VElrRFRzMUFRcXhybHNmeGpuRG9IcDlVcStMZ2RzcEpmOTJpVGFzUWU3QkVI?= =?utf-8?B?TmVwRWplTTJueGNKRE9GMGVBUC9pczZoYTRWMFY4Mk1CNDFKVm96OHZRbkpT?= =?utf-8?B?dzlKam1SZUYvRys2ZnM5NTRnRStjbmdVQTBEUVc1L2Q0UDZ2RVhUcWw2RUsw?= =?utf-8?B?OFhzU2Nya2RoekNrWkRzaDMvMFhsbEdrZS9RaXY4N1lyMmlOOC96ZVlVMmtG?= =?utf-8?B?NnVyTGx4eWphNzREaDlWS2U3SlBmR3FTcGJjSndZcUVvNzR1bnQ4M2JNVTNn?= =?utf-8?B?VHBNL0M5dUYyUTJ0TW5ISy9ubnZaQzduYTVqcU9TWnNldnl4VVV3emhyWkJz?= =?utf-8?B?Um8yQWpmcU1NdDVFRm56aFJ6Sm9ZTmpDbTd3dVdKc1BVZVZIa29pZlovelYx?= =?utf-8?B?ZnhwaUdmQkhXUUExanNZZmlhMzdPUGVvNWRrc0pzUjBHWmM4WVBwL05NZXFN?= =?utf-8?B?Q0pFSHVhd2NYTEZKeEJOeUdGVWlaVUtnUkNpZTNYRnhsbTkrMmtRa0tYdTVr?= =?utf-8?B?WmdmTHlzbzlPamd4VHltb2RMeWM0enIzd2F4eHZ5L3JhaDFBdHFGMWo5YTJy?= =?utf-8?B?MkY2ZFc5dmFTY2N2K1JBT1YvTWVoYnh0WUl1Q0pzcW40T0tVdmFoTjVUL1p4?= =?utf-8?B?R2I5OVQ4d1hDNU80UjQrdlIxQlhhbHVjdmZXdEd2eHlrL2F1V21EbDZpdjdh?= =?utf-8?B?VDNYSytROGtUOGNiN21lNElaU3MvaEtRNE94OWdrR0VQTytuK2VtdkREZzBt?= =?utf-8?B?cytoQXB3R0twVmhzOEc1SnloRXJzRzI5bXA1L3UvSSs4TnpkdW8xZ0RzWVJj?= =?utf-8?B?Z3NOWENlY1gyVXdpdTVzR2JQV0tCR2s0a21aTUJLd3VqMTRWdnJhR1RubFdy?= =?utf-8?B?ZmJxNUdNczdOWXZuaEpUQ3ZmVE01L2o1blg1NFVYUnpRdVNoZ3hqai9VTWs5?= =?utf-8?B?SDFUWGtXZEdDZGxCK1pJdkdYTXpobWRRd2VwUDJ1a0pQSnpQREVSanMwc2g0?= =?utf-8?B?aDZ0bklPT2Q0RVFCYS9NeWhLdnhIMGo4TWlyanpWY0ZydW5acUhxcndCZTdl?= =?utf-8?B?TWZiNWhKaStETzFXaGN5Z1dZcEtJRC9MSnpyZDNXMG0rd1JzYlFKNmVjMEVL?= =?utf-8?B?ZDJWalIvWEhTVkVWUW1pK21UOU05aHBSY0l1RWVBUmU1cVQxVzhpcVJ2MzVo?= =?utf-8?B?ZThZRjZNamx6RTlNVHFPN1ZpRVNnSGJMemhFMU10V1p6eE9EM3VVTGRLcks0?= =?utf-8?B?SHdJMWk1dmYzemVaanZSdlA3cXhQVmlqMlJFYlhJR01BS3FUT2dRRzlJRS9y?= =?utf-8?B?WXdLU0Y1eEN5N3FINUV0NThqcFd4U3J2NnU4N3g1cTdwNGx4NmNmWFNPZ2Vl?= =?utf-8?B?RDhib1lOcVdpalRlekk3TStVU1F4cDVkdDE0dm01ZmF0c091dzdlR1RxQ1dK?= =?utf-8?B?UVhISllRdVhRLy9BcFgwN1hIbVFuZlNYMkwyTGlBR05Rc1NmRWFUQUh3SkRM?= =?utf-8?B?M2JpM2RNM25UREh1ZHN0aVh1dUc0SCszRFErMXZoVnRvUE5lL0JQWTZjbWdx?= =?utf-8?B?Q1RaRkRjNDB5OE9OczVuR2hHTVdkNFNvVkt2Skt3UUdZQXl2b1UrM1dZQlNE?= =?utf-8?B?VlhaUmtrL2pENkplcVhWZDJQV3JkengxK2lJSElpc3lvVGZ3cTNyWitQamgz?= =?utf-8?B?cmpBVHoxV01KWEhiYWwyZlh4dTl5YmpiTXNEbk1XNzJuMWV4QXpoU0xIcENh?= =?utf-8?Q?GYPc2kRpyHPXa1KAnj0/hDQ2y?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00ec9233-569e-4f71-e437-08daa2cb1547 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 10:03:54.7471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RBj/o/lb1nVbuVaPFyyhrIVD195yjXct/99p001TeQ/ok/bMYqMhXQSjRiOOVUA5LTXwiDD625EtJz9lrdpfrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6209 On Fri, Sep 30, 2022 at 10:36:20AM +0200, Jan Beulich wrote: > On 30.09.2022 10:25, Roger Pau Monné wrote: > > On Tue, Sep 27, 2022 at 06:20:35PM +0200, Jan Beulich wrote: > >> SRAT may describe individual nodes using multiple ranges. When they're > >> adjacent (with or without a gap in between), only the start of the first > >> such range actually needs accounting for. Furthermore the very first > >> range doesn't need considering of its start address at all, as it's fine > >> to associate all lower addresses (with no memory) with that same node. > >> For this to work, the array of ranges needs to be sorted by address - > >> adjust logic accordingly in acpi_numa_memory_affinity_init(). > > > > Speaking for myself (due to the lack of knowledge of the NUMA stuff) I > > would benefit from a bit of context on why and how memnode_shift is > > used. > > It's used solely to shift PDXes right before indexing memnodemap[]. > Hence a larger shift allows for a smaller array (less memory and, > perhaps more importantly, less cache footprint). Personally I don't > think such needs mentioning in a patch, but I know others think > differently (George for example looks to believe that the present > situation should always be described). In the case here a simple > grep for memnode_shift would tell you, and even if I described this > here it wouldn't really help review I think: You'd still want to > verify then that what I claim actually matches reality. Right, that's why I like some context with the patches. Sometimes (and I'm saying it's the case here) the context analysis done by the patch submitter is wrong, and hence it's easier to detect and point out if it's part of the commit message. IMO it also helps when looking at git history. > >> @@ -413,14 +414,37 @@ acpi_numa_memory_affinity_init(const str > >> node, pxm, start, end - 1, > >> ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); > >> > >> - node_memblk_range[num_node_memblks].start = start; > >> - node_memblk_range[num_node_memblks].end = end; > >> - memblk_nodeid[num_node_memblks] = node; > >> + /* Keep node_memblk_range[] sorted by address. */ > >> + for (i = 0; i < num_node_memblks; ++i) > >> + if (node_memblk_range[i].start > start || > >> + (node_memblk_range[i].start == start && > > > > Maybe I'm confused, but won't .start == start means we have > > overlapping ranges? > > Yes, except when a range is empty. Hm, OK. Won't overlapping ranges be bad if not empty? Shouldn't Xen complain if it finds overlapping ranges, or that's taken care somewhere else? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 10:22:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 10:22:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414099.658189 (Exim 4.92) (envelope-from ) id 1oeDA7-0003d8-S7; Fri, 30 Sep 2022 10:22:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414099.658189; Fri, 30 Sep 2022 10:22:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDA7-0003d1-PS; Fri, 30 Sep 2022 10:22:31 +0000 Received: by outflank-mailman (input) for mailman id 414099; Fri, 30 Sep 2022 10:22:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDA6-0003cv-Dg for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 10:22:30 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c7794aa1-40a9-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 12:22:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7794aa1-40a9-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664533348; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=f3fBpBJIOAqOcNPfoBhqYqPs8zVDx2UAQszlf+fEb6I=; b=DgJ4d9HIQAPPbTETs9c/iCSO7Z83jj6ff6R24TLA+9tAhSKSqqmzTh57 v8iamcTh09NZd6UBW45qZmK70Jn5MV6+AhuQ6BHC3bl07HFaHZL2SxlOx g0W2pm7aSrtlKtk3CC/0XXFolv16zSHHOlvj1a8aYWpYvgQqGj0hQ2q9i s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 81347272 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:wCl5cK+iehaQg2Uvdi/sDrUDVH6TJUtcMsCJ2f8bNWPcYEJGY0x3y WJNWjqBafeDZGCnfIsgbIjnp0kF65fWzNVkQFRvrSo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvnrRC9H5qyo4mtJ5QRmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sprInNQ/ PomEyw2cTugo7Od5ZyceuY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9KoXRGZoPwRzwS mTu3l7EDRU6L9+m0T+54muwg82Wn3qkcddHfFG/3qEz2wDCroAJMzUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiF6JuAQNHeVZFeIS4RuIjKHT5m6xLGUeUiRIbtBgkcYsXCErz XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsRA4OsofLu5s4gFTJQ8oLOKmulcH4Ai21y jyPrS4Wl7gVldQM1aiw4RbAmT3Em3TSZldrvEONBDvjt14nIt7+D2C11bTFxdpcD5SHR1+/h 2Q/hOO9yLElKL+qpCPYFY3hA4qVz/qCNTTdh3tmEJ8g6ymh9hafQGxA3N1tDBw3a5hZIFcFd GeW4FoMv8ELYBNGeIctO+qM59IWIb8M/DgPftTddZJwb5d4b2drFwk+NBfLjwgBfKXB+JzT2 Kt3k+72VR726ow9llJaotvxNpd0rh3SPUuJGfjGI+2PiNJynkK9R7YfK0epZesk9q6Cqwi92 48BaZfWlEsAAbKnP3G/HWsvwbcichAG6W3e8ZQLJoZv3CI/cI3eNxMh6ex4INE090ikvuzJ4 mu8Sidl9bYLvlWecF3iV5yWQOmwNXqJhS5kYHdE0JfB8yRLXLtDG49GK8ZtJ+R7qb09pRO2J tFcE/i97j10Ymyv01wggVPV9uSOqDzDadqyAheY IronPort-HdrOrdr: A9a23:CH0UaqyJG+5PVlVro7wKKrPwFL1zdoMgy1knxilNoRw8SK2lfu SV7ZMmPHjP+VAssRAb6LS90ca7LU80maQb3WBVB8baYOCEghrMEGgB1/qA/9SIIUSXnYQx6U 4jSdkdNDSZNykDsS+Q2mmF+rgbruW6zA== X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81347272" Date: Fri, 30 Sep 2022 11:22:17 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , osstest service owner , , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Henry Wang , Bertrand Marquis Subject: Re: [xen-unstable-smoke test] 173362: regressions - FAIL Message-ID: References: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Sep 30, 2022 at 08:31:20AM +0200, Jan Beulich wrote: > On 29.09.2022 18:25, Andrew Cooper wrote: > > On 29/09/2022 17:22, osstest service owner wrote: > >> flight 173362 xen-unstable-smoke real [real] > >> http://logs.test-lab.xenproject.org/osstest/logs/173362/ > >> > >> Regressions :-( > >> > >> Tests which did not succeed and are blocking, > >> including tests which could not be run: > >> build-arm64-xsm 6 xen-build fail REGR. vs. 173347 > > > > arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access': > > arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of > > 'iomem_deny_access' discards 'const' qualifier from pointer target type > > [-Werror=discarded-qualifiers] > > rc = iomem_deny_access(d, mfn, mfn + nr); > > ^ > > In file included from arch/arm/gic-v3-its.c:24: > > ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but > > argument is of type 'const struct domain *' > > static inline int iomem_deny_access(struct domain *d, unsigned long s, > > ~~~~~~~~~~~~~~~^ > > cc1: all warnings being treated as errors > > I've sent a patch, but this raises another question: Why does the smoke > test (try to) build an unsupported configuration? HAS_ITS (which is > necessary to be set for the issue to surface) has its prompt depend on > UNSUPPORTED, and (implicitly) defaults to N. According to osstest sources: # ITS driver is required to boot the Hardware Domain # on Xen. For now (Xen 4.10/4.11 at at least), # will be not built by default and gated by expert mode echo >>xen/.config CONFIG_HAS_ITS=y https://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=ts-xen-build;h=c294a51eafc26e53b5417529b943224902870acf;hb=HEAD#l131 > > Jan > -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Sep 30 10:37:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 10:37:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414108.658200 (Exim 4.92) (envelope-from ) id 1oeDOR-0005S5-9G; Fri, 30 Sep 2022 10:37:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414108.658200; Fri, 30 Sep 2022 10:37:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDOR-0005Ry-6b; Fri, 30 Sep 2022 10:37:19 +0000 Received: by outflank-mailman (input) for mailman id 414108; Fri, 30 Sep 2022 10:37:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDOP-0005Rs-RH for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 10:37:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da22486a-40ab-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 12:37:16 +0200 (CEST) Received: from AS9PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:20b:489::32) by DU0PR08MB9417.eurprd08.prod.outlook.com (2603:10a6:10:420::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 10:37:13 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::e5) by AS9PR05CA0058.outlook.office365.com (2603:10a6:20b:489::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 10:37:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 10:37:13 +0000 Received: ("Tessian outbound d354c7aef2bc:v128"); Fri, 30 Sep 2022 10:37:13 +0000 Received: from 14ecf6b5f0eb.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7FEBAC6C-CE12-4022-8E95-B31B56112FDA.1; Fri, 30 Sep 2022 10:37:06 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 14ecf6b5f0eb.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 10:37:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM9PR08MB6273.eurprd08.prod.outlook.com (2603:10a6:20b:2d7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 10:37:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 10:37:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da22486a-40ab-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wyt1gxEi6zPs33FoiqOx0WUtwOFXTLzwGfaPctQ9PyzOKeRjrMfuvH2467S8kdH6wFgCyanZrh+ZAJP1ivDMbMJBYcm44l7xLVjMT9Jvw/XQFLfSACVpJrgRJCu0zwjl2lDShXNY8CMII6t24etSt4zN8ifF8j5yZ+kdibfBcIf8s+AWGmk49Q9WIvKn9yo9Qd618kGPqPdpy0GVrRsW22LQr9+894Y3lojtwLehGq3KOT7eR7rm4xYZu1QKDOjQP920Enw+R5F0p+XuBZHf9Nk9+2e0JXPtwHiWzbBSC0+cflH1kimFn0Vlu5bUiquyJO4kHWonWsPjxPrq8tkv2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Og+NroRc5H16Hufeu0AtsVJ2qr8qFDmqiSiAVm1Xa8=; b=D7kq+iWlGwngbTYk0jmJdQFC/77ugOnAS9ibrLXZgjQKtbOT/AA2LBE0WphVOgRY2B2lbbGp38AXNU6ZovFdh9BJx1D/uymRlKDkrzZ1VSIlinMtC2OUg5dgj0TX9HDnREMfjcrI9qE8JdVact0lt2/uCNKxIGU0NRMzpQmjaGqFoXhDxEvq17i4G7byYCR6zJYsCh/bjp8gI0oDKkxa/kpTyoAXYIKbsXAo/him5A0WwdFpddVNMvGKqeTskjKS1c3YSL3ouRGCOLM97Yc6vW8jtj517VTW5cjniDPjseg0p07+FxGg+BvD6H3BncnMsSsIR7SLfGkGJnyXK1pCMQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Og+NroRc5H16Hufeu0AtsVJ2qr8qFDmqiSiAVm1Xa8=; b=L5khijSSRUkakwIT/I1qYxoLdwpwcihFyIBzOl0MEIRaZIXzW1TtNdVaHMOEDA9XjNONA1cXTu8P97R6gEGjUpI4qAOyVFEQcRbH1eWship8NJnToYGqC2ZZmqRoG8HtbxbAJ+0SUY2Bth7TDZ4uOl75D18u939dbTngfoQ1/lM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7b31788505c63ac1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hUd0VOIzXF1NXGP1+pRTZF6OO/DvsTXFvKyOOh7WG9Syp9i7ETXKA/moo8MinJaW6W7h2AOT04Qnvo6wrCp2Phl39JEX/GxhDKxoKGtIM0TX1b3dr2E0Hp/IFHuAVbbHLCWFNUANfbrWfZEOKM5GF25FiiBRK8ILpgHbNkXueHzAtRoGq0eFsMUyVqzLAl5zVC4piVDqtA2MtiTeOA342O+wHrNeqGuf7VV7YA6QfIvJfo4bPXDOiIkdH+Is51pZG2SBQqjaM5QMFVdHdHBoDHL+769BLl/bDdWm0r7leCmISEJuWuBI5gF18HtKdT36SvbPLJRdseJ9AqkFO3EY4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Og+NroRc5H16Hufeu0AtsVJ2qr8qFDmqiSiAVm1Xa8=; b=bXSXXthqIDpW/DrRmreDOxJM2drA4I/e3zY+Dm+rJkddrTTKmQQr6lUADvSi7sHrQFatKftXOMJngRwC1LvlvYgOxZoC9S0eIBYrmi46r2BgrgEMkMeGQQBDjY5O9ZUGesbOB4xBlgiE45gfYLla/hK44zr9a44Ihr1sEl9dGvUZBWILCm721n7xFH+szEiXvBwJ4KjIYYe/zH73ZqK5klQk1WKBY2KXEkITc4At/hZP9B8hxT7ChIyT/HMmWul/laWqTVb8VcpTAhYpnQr1uHd/xNiCLCyv92U2VKDvDufKxG9cg7SVbiSS0ozgmT65lktUUOZR9m8bgur2n6gTBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Og+NroRc5H16Hufeu0AtsVJ2qr8qFDmqiSiAVm1Xa8=; b=L5khijSSRUkakwIT/I1qYxoLdwpwcihFyIBzOl0MEIRaZIXzW1TtNdVaHMOEDA9XjNONA1cXTu8P97R6gEGjUpI4qAOyVFEQcRbH1eWship8NJnToYGqC2ZZmqRoG8HtbxbAJ+0SUY2Bth7TDZ4uOl75D18u939dbTngfoQ1/lM= From: Bertrand Marquis To: Rahul Singh CC: Xen developer discussion , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series Thread-Topic: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series Thread-Index: AQHYzzwi5SkcTjaGIEa7tDBb5ugVda330q4A Date: Fri, 30 Sep 2022 10:37:03 +0000 Message-ID: References: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> In-Reply-To: <0c53abc972264b0ea13864b7056fa2149cd78f9f.1663928523.git.rahul.singh@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM9PR08MB6273:EE_|AM7EUR03FT004:EE_|DU0PR08MB9417:EE_ X-MS-Office365-Filtering-Correlation-Id: fa06611d-1203-4cb1-486d-08daa2cfbc96 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fjhEZlKEcLWnvMyOmAU/KV4YDwqqmSJHo1/PsTNxpEnwh4gLugZEkSKl4ExFFe9uY81nxnT5gXClVubfOCyNJKRNxHG2YK81VNzL6vDUXtj5AqNpfEJQd9+UKnkhEe2HYFwPmlRnWEGYo+10liJubMEjGrx/OfuySeVskYH9DFHg8XCtTF2OatsjyJ6CM24oIoKtfv4mmekwePIo1R7V2TR+WpVi1i0huqlh8HpjHgZqAXepbJ2gb/TMwAitoy/w7aqYeQx+afBYzztZo4nvPajoJPSPMpiGYaJ4weR5fkssGStxk/+bnMoK4rYPSU9WjKzvDBxaCWl4r2ud9dsFa4t3vqEskVuD3bIto6Kxtw5NCkHajT2mpOwLzNQZ2jGyTAUP1x6j+utKCD52PGL8zl4dLuvhhozAxhL6xccFE95MkFT+SuHO76bC2l5SRIjXnSIlicoShMwmiBRpXbGISSTJkFPkj/xkQQBOcnpQrNYVx7+w8c6mjQJzIrH1Trp/FehEPjXFY2SlvI1h+xFfzJXhZTHUmuPS1kQZPBVhWzf22rfGN2+W4ZUKqhcWyuJrmdxzhQhE1z/QAS+w3+qA2OmtB7rfbd9DzBSKrg3zCxQiO/fZ6CjuQSKn//DfMFaFT+rA8B1aafz0lAxrq+Rxw5JtNfHPmIAjrytPQ8+7aOC/HajQaWMwuNAT91mQN0tgGfN1e7Rdp5G9qEOC+9w2v1XD8ydDq9gz79rEIL7VY8n+EwaR3yHYqeHGeufL6xv13QrhWIyiXusJe1IoWT2lJ2iLZNiqkvaJ5L7cxulLE/I= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(366004)(136003)(451199015)(83380400001)(186003)(2616005)(5660300002)(38070700005)(122000001)(38100700002)(2906002)(41300700001)(6862004)(8936002)(71200400001)(6486002)(478600001)(53546011)(26005)(6512007)(6506007)(91956017)(316002)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(4326008)(54906003)(37006003)(6636002)(33656002)(36756003)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6273 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8123d22e-7ae0-4772-f7b7-08daa2cfb6f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zGTTEKq6ZoAwms2CIjpnLLP5q5CxqmaY8GdwN/tYd9PmS9RALV3tKDNDv7Z1c/L79MFEaeDEs5QcCgySfiU4L0rgMgKpOmy9ScRHsP19x2QFd26dPRgmMVFXsv1oX2Th7xkIP1THtzmMVLw6vpXlIQ0KwbZAtwMYJcedrKw1bt6XV9dYu2spn2Rv5AxVBriUYKfgi5NHTga0ruVZ1IlIw93GpqEV9ITr7VGW8vp2b5uGRWaDqadF0vRjtF4+qoNvuJ8nSiZwSPIY6l/Brpy9H0bO0zlnEGuJGuzhanOj8+930vqKRyCzeFwmP4x4kZWEWxGW3rvCGsdYdgk8IN3n5vA96w4D2Dcw2p9cu9grLVkZfRVUOezEWYllK3moBuXcOHNl5lH7uPRtab5B31oPNDyyY/2X7HT4wUCtiMI9vEA8v+aabhCt4SxI7CpYIDWlEbxErb0Ww8KhNHO+KXO4nf8rN0SELXnpmYp6fSu2yojGpry2vqRm9eBu0wCTArgASBrFTquSEjNPFafdqfgqDFPvH7pnM6kHOT93ZA01FA5TgpvVQPlbl7jc1QyxhvVtdlbquwg0hiJzkSBM3IyIT1mzD2PleTgVeprsOnXt/Hvwoax6HF5/504WSguxQX8fvDrutBzEr5t1jWypkuJ91Hw5OFLQN338IaTUoyvWUIfRyTDotLcoqciXyV7YjcZ4ticjbh1TsHjDwyJVEI40f28mDuaQbVky/8JSyn4L+JBXQIRQ4UxMLK2tECq9avQtB6ltTcxahylYaanzvGdWsQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199015)(46966006)(40470700004)(36840700001)(107886003)(36756003)(37006003)(6636002)(33656002)(54906003)(316002)(86362001)(336012)(356005)(36860700001)(82740400003)(186003)(81166007)(83380400001)(47076005)(2616005)(26005)(2906002)(6486002)(6512007)(70206006)(8676002)(40460700003)(4326008)(6506007)(53546011)(70586007)(478600001)(6862004)(5660300002)(8936002)(41300700001)(40480700001)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 10:37:13.1617 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa06611d-1203-4cb1-486d-08daa2cfbc96 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9417 Hi, > On 23 Sep 2022, at 13:02, Rahul Singh wrote: >=20 > When ACPI is enabled and the system booted with ACPI, BUG() is observed > after merging the static event channel series. As there is not DT when > booted with ACPI there will be no chosen node because of that > "BUG_ON(chosen =3D=3D NULL)" will be hit. >=20 > (XEN) Xen BUG at arch/arm/domain_build.c:3578 >=20 > Move call to alloc_static_evtchn() under acpi_disabled check to fix the > issue. >=20 > Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property) > Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis This is needed to fix ACPI build issues and was release-acked already. Cheers Bertrand > --- > xen/arch/arm/setup.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 61b4f258a0..4395640019 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offs= et, > printk(XENLOG_INFO "Xen dom0less mode detected\n"); >=20 > if ( acpi_disabled ) > + { > create_domUs(); > - > - alloc_static_evtchn(); > + alloc_static_evtchn(); > + } >=20 > /* > * This needs to be called **before** heap_init_late() so modules > --=20 > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Sep 30 10:38:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 10:38:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414113.658212 (Exim 4.92) (envelope-from ) id 1oeDPE-0005yU-Ik; Fri, 30 Sep 2022 10:38:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414113.658212; Fri, 30 Sep 2022 10:38:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDPE-0005yN-Fw; Fri, 30 Sep 2022 10:38:08 +0000 Received: by outflank-mailman (input) for mailman id 414113; Fri, 30 Sep 2022 10:38:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDPC-0005la-Ik for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 10:38:06 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f75a1a21-40ab-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 12:38:05 +0200 (CEST) Received: from AS9PR06CA0126.eurprd06.prod.outlook.com (2603:10a6:20b:467::25) by AS8PR08MB8184.eurprd08.prod.outlook.com (2603:10a6:20b:561::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 30 Sep 2022 10:37:48 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::55) by AS9PR06CA0126.outlook.office365.com (2603:10a6:20b:467::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 10:37:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 10:37:47 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Fri, 30 Sep 2022 10:37:47 +0000 Received: from db5078d7b243.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 972BF105-8173-4FDC-9B92-E427C1642D86.1; Fri, 30 Sep 2022 10:37:40 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id db5078d7b243.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 10:37:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8325.eurprd08.prod.outlook.com (2603:10a6:20b:536::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 10:37:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 10:37:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f75a1a21-40ab-11ed-964a-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZYZfTYkaZ+g3+e2+bLK4LWBqTSiQaNPl04+WrcNAW7SaY/nrB0FKr7NpmfojnfK3246haIaJ6VUbSfZegkcPUpluN+TBGSSuXBz+OluJsZOQ1EOlcSJaRKt5RqblMA1EbSqRSISpGf1vio7TvGUe++BNxJ4tHleUCcNY2qp6xO1afFtKfzaNxMuY5IskVXuYRm9yNesTxKFZnpvbFAOCCnEou9D+J+jNuNJhqrpGe0k0pg0/vUydnyFLFmMOi2wWRCQaNc3xaOw/2w9M0AmHJkDKoKWLRrWJAsk3eSsK5njpzITjmi1K1v4PLvpJTKG1WrVosY+jVNrn1EtLqNGeng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nsyBqG8rWrUKKDWdmfQbLNWTbc83X4k6EIjjOXRfDNQ=; b=RXV8iFGLvBaeDwM9Tn6wbdocBoMln4nIhPHtqEx8KCgSj9lAyz16JD6XUhRtF70fBiZPLWNIPUNnaZqAJ0OgDM9gOQoe7aFxDuqn4jX7ci6tHvbFhxnoepcXgrEqcMBAfIbRtBqWX7tL2SpIgvFedAEIQPZULMggPtGptROPzquDFNGNqv1FpB51mQHQgx8RwSFYDy4Qe7XWBws+EiCCPo61mOI1HWpCrsAuqzvau3dV7bcl6cn34tuaQqOFKAnW5VGyHXqHa984Xz1T2FXU+rmyIU1+VRLmyMj5AQ2ltX30P9ibVwvYdyo+l+pqJ+JuVmnGGxnNVAo7IvzuK9acHg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nsyBqG8rWrUKKDWdmfQbLNWTbc83X4k6EIjjOXRfDNQ=; b=SwG1UaF0HFuo6mV1WemzvdLOSYNx73vT4SL+b/auszmmCSVRG0ogCCj1jq3RRmKQhGv17z27U7vnKeBCsgzOvXYBCeCbpSN0yIJtTbCXA0xs2J3C15uRSORZHT7COjx16Y76UED7NJCJMsTr8R8A3d0QMPvUBHx9XVq4n1B5KEY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b9ad60c8fec4493b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRpaRtPfmpDj/frVxQySKKt+Y+2QZBqdPELsyIv2Pz6vMUZzrQ2JROcVnmQf0CWp2I+JBh8P9DULc6So9LtjkOejzbEe7sP8U/+vz998GLX1xTGSjEJn4OuTAhX2eUwVM74W5DYUVA4co9D5BUTrvJuJvA3WobfiANXt2pcuUPAEEtSuMLR/zAwyPEuo8XE2BPF3y/ihYcdRNxDtsUZog/lmp9hOEfoP20GPid888hz901s+69zqOwFuZrqwC8fAH96chfJ0m7l8ezW53ukj63UCMhMFRB64cPwtakjcSKpqlg3yU8rwxR6ctra7uAHP4Lg6SCpmldzHaL7zw2oDYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nsyBqG8rWrUKKDWdmfQbLNWTbc83X4k6EIjjOXRfDNQ=; b=E3NAgUJeP0JfAGKCLoOjEknDrBwc6pYBMgHKlsO81IBNapHRzcllq/FmZLWM1b+b/rj/MMwR/YAOuizu89Hm/RKz8EJAR4bP6NHJF+lIq5XqeZIHT8hgfsxSkLB14NNoxhx4AmTEYaKIyKBZ+ycBN7jvTLDYnbXF7HTyR3fvQnr1KtT3NEHNehjSavDza2KUXuJdTXja/dFf09eJr/22IiCCI5AGR1dXlIZgN0/amFUOa5cagGW1hSIPCujoxYmdkotwV+rHqhH+tTguaK95tNUNsS/8lZxPabS59c1LTLM4xROIeA8YPNMbG3dcQ8O9xL4iHHyQAh0ZVTlignoo/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nsyBqG8rWrUKKDWdmfQbLNWTbc83X4k6EIjjOXRfDNQ=; b=SwG1UaF0HFuo6mV1WemzvdLOSYNx73vT4SL+b/auszmmCSVRG0ogCCj1jq3RRmKQhGv17z27U7vnKeBCsgzOvXYBCeCbpSN0yIJtTbCXA0xs2J3C15uRSORZHT7COjx16Y76UED7NJCJMsTr8R8A3d0QMPvUBHx9XVq4n1B5KEY= From: Bertrand Marquis To: Rahul Singh CC: Xen developer discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 1/2] xen: Add static event channel in SUPPORT.md on ARM Thread-Topic: [PATCH 1/2] xen: Add static event channel in SUPPORT.md on ARM Thread-Index: AQHYzzwfdk70jfLcAUikH+g7arl1t6330tqA Date: Fri, 30 Sep 2022 10:37:39 +0000 Message-ID: <34888A16-D236-42A3-B020-ADF873537C14@arm.com> References: <02a4499694dec9fd48791a2d0c24a0d450b907ac.1663928523.git.rahul.singh@arm.com> In-Reply-To: <02a4499694dec9fd48791a2d0c24a0d450b907ac.1663928523.git.rahul.singh@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB8325:EE_|VE1EUR03FT006:EE_|AS8PR08MB8184:EE_ X-MS-Office365-Filtering-Correlation-Id: 42931e8f-113e-4e94-8b12-08daa2cfd13c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GXnIaNNsrUtp4Og0UlCWGPfw/sizom/iUb9H87nJiQq1AjpPrCf8vK1Cx0zhvzfwjiko1S+rnDQe7dwIx0UFMuWuNFkywb6zj1kWIdSRdvibGnj1AWB3aENADzVVxRuxU9/ZB44tol5j5rFF3YbQbWHLHBLjfbn90o5q1Ouyx82tbAj4dt6zCpDvZ7q4F5BGwvlDGQ0RqyhN2dcsT5NLBOk2Z1p1sZZWgtC7DpFbFJ146HntWmTeInay4foAlL2nmiCzceTqVjHBlen0NGxBCar6RB8891XiLLyKSINBAfxoVyC54ZxuuSzfkebQX2DWv9urRe6ms25Db4YxGebqj6sMg5ALKdVVH9yJ/R9TUB/x5bmPMpR6xtZIMbieiQ3+kqp0ZU16DCU9bHWYioes8aFyJ+WpIpANJL+kBfTAkSFjTW3/DhToeZtE3hwZ/MDu8uP2seRjTFpXDTjCdLyZBol1qcXxKAvFr2kjWwxZee5Gwj//53NXxXmNKkeWe/1WJFI6reLish3VbikCzK+ccP5mM4jxyY16zcLEzusPGX4IToE/clf11ROGeeuF/1qo9yGLGIW0BhuZxVNjYMlkoijjfLds/zlsKO4yU7yRDRIKNkMH2HaXcB1vs1MBv294hLa9iI27lGwX+U1q1reaVw7GpaKMutlkHVBOWW7rkxqxLsPTNgJrQIwKIzVydCM9Z6cc9J/sVp28EmHQFD/Aluor4EuvDSTpAqk4C32C5kqoPElajaqKGszVYmW9ryGFNI3fvDRnAZ1RvIy3iT5ruqmWmt011lccs5Lz4pEIGJQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(41300700001)(36756003)(122000001)(4744005)(38070700005)(6862004)(8936002)(478600001)(38100700002)(6486002)(2616005)(71200400001)(5660300002)(26005)(186003)(6512007)(6506007)(53546011)(86362001)(66446008)(91956017)(66476007)(66556008)(66946007)(76116006)(8676002)(64756008)(4326008)(83380400001)(37006003)(6636002)(33656002)(316002)(54906003)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <52C15BF968E4914B8773EA2C86E9410F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8325 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ecdd3f22-6bf8-475c-5b2f-08daa2cfcc43 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PXtbwbqVXai4UP5FJxBRi86a5DOGKQ/bw0Zx5IzKQelvVEM7NuEUPgWf6eliBScOj/ySTWvCz8NwpArcDOKebH8hACP4FUUjz2vFAN9Vnd09iijUs6Mp0rBlK7ZbGeFhSCsFC4fi01KsLH0t8lh+MoFPzn1tZFvOPskl4mZiuSE4gB0r7pQ3p0S4T9JG3ixt+L+50uIhGYm/9Jcf3fGxukzb/JJDV2LLXOviobq3dw1ethmpyREPql1kslz/9SLIuJkzQMvDx3flL5mgZlivo49J8eVPTWvi1Ej8WwgjB5ky03eYcsULi68lEl0f5xvNhfEb5FuvIGVT4+ifI97GzgkNff8eyhhK7M0MkApHub2JnSyt0rBKzQfv1fe37OECmTABaYyXCfB6lqXe7spawseqxYbM6llchj5lBXcyJNi3MTR3bpvjR3O/KjCuN02EdnqpxKGqo6xFVyVG6S1dELrXa7D+2w8gC/1qLw7b7uSTwGmgfDIoCa/MK96K2Rv6lGwXMIZ9dTLQdn0WNVSa9asBfbkZiR4MndU8RK6Pba687E8qp9oHwGl1J37fwy5ZqyLDCgmwd92X3PbVGb9nK29zCkjye3FCnQZcIDcPab4FygzRstq6YOCnduC3yiO92KKrfY27KmMQWhRbgF+x0mGZVvjp4k2kXrgCKdqHb9B+zC8EN0KgAiD2XSg8uMUeQk53vSsMGPqrK52CM+6uCojGBz7zUtjSvVIPgCQI0q9gTzAo/3JuAZp3GnrB8/SQTOnBOzzwUSa/OFdPm2sNjw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(6512007)(26005)(54906003)(40460700003)(36756003)(4326008)(356005)(81166007)(36860700001)(6486002)(86362001)(33656002)(316002)(82740400003)(40480700001)(6636002)(70586007)(70206006)(8936002)(6862004)(4744005)(41300700001)(37006003)(8676002)(5660300002)(83380400001)(186003)(2616005)(336012)(82310400005)(2906002)(478600001)(47076005)(6506007)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 10:37:47.7432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42931e8f-113e-4e94-8b12-08daa2cfd13c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8184 Hi Rahul, > On 23 Sep 2022, at 13:02, Rahul Singh wrote: >=20 > Static event channel support is tech preview, which shall be documented > in SUPPORT.md >=20 > Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > SUPPORT.md | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/SUPPORT.md b/SUPPORT.md > index 8ebd63ad82..29f74ac506 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -922,6 +922,13 @@ bootscrub=3Doff are passed as Xen command line param= eters. (Memory should > be scrubbed with bootscrub=3Didle.) No XSAs will be issues due to > unscrubbed memory. >=20 > +## Static Event Channel > + > +Allow to setup the static event channel on dom0less system, enabling dom= ains > +to send/receive notifications. > + > + Status, ARM: Tech Preview > + > # Format and definitions >=20 > This file contains prose, and machine-readable fragments. > --=20 > 2.25.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Fri Sep 30 10:50:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 10:50:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414119.658223 (Exim 4.92) (envelope-from ) id 1oeDax-0008Rj-Lu; Fri, 30 Sep 2022 10:50:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414119.658223; Fri, 30 Sep 2022 10:50:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDax-0008Rc-J3; Fri, 30 Sep 2022 10:50:15 +0000 Received: by outflank-mailman (input) for mailman id 414119; Fri, 30 Sep 2022 10:50:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDav-0008RW-PI for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 10:50:13 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8d1a219-40ad-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 12:50:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6809.eurprd04.prod.outlook.com (2603:10a6:10:11b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 10:50:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 10:50:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8d1a219-40ad-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eQ6MyUsEH6aLgQc1OTGQ9p7o8Feax54P6Zys6xBlJsDDqLMazuf6f66G6d4wOlPfWhIFvwPJaVIa7UnHzOO4XBi4Dgwy9HY7sY/yricgj5fZUwvA9hwDdtpoxldgkumYgM7j5+ocWx3eIy5fYhcovFtGQpz3rUKeE/lyuwcYrTUdoiR9TEUoCHTMSITK6IGpIBUuEHXbTuZv2wWeI7DlXTmubPdEpseuH9IFKgJynKeV+XZXmkdthmU5vKc/fsHPDMic2Lu0aVqktq5tK9VcwKUJxGifAoxZ2f1ks62pp3p5B4iQRD9aEWBQwe3V9eqBzc239AuQFiuoQj7iFrh/Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qj2a+dRMWO6m3CB7A4f7HIhY6I6eKhA/SbsW2g4szgM=; b=UbALCuewkdfGGQHtj8ZvKffifn0GH0v+JU4lOAnzHRlefHu8/b0qj8lVb9LUMdNKU4xvXFGWflZt0+2SlcplBMzae3Mkn0nFIQnt3co7/4wXow4bBrh+J3+ugRXoheJj1SMVMY/fZXD4kD2eJyU7qTSXGrgEkiyqMTgXkWhPjYcoPQSk3A+b+YnpjnRUOsAiU7/d7N3uhqv2oU4xTnM2Ii1gQWS5207VEIBou8/gA+C2ObEvMhTw4qyCla5g8K25DRtFrIvx8CJbtyRa1ZmnIQRMNdWtZNFJd2QvokFL9yAvjdINjKEVDq9XFF8S895dbxiPkpesg2jUodpM7uVqsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qj2a+dRMWO6m3CB7A4f7HIhY6I6eKhA/SbsW2g4szgM=; b=liZsuHlq+4rp+ZQnlWplSiEdMy1caN2I+SLMv5/SQrDgzgmo0nR+TLz31SrIMDdTM15jV6eGEFG1bM/KxOcdNvJcZk/XvmFyoJjU84tdOw/Sy1XW6ygmLSJT1KSdezCuDS1rljnFeoPI/qjPMfM2zLX0844LX0fEHfTl+60Gy68qDwawgGpLrvBI4pxNgTHor6R+K0gfrV6uT1+LKF2h/4Ut9YIYp5fISBiDOvepgoh8hNdkEVPZE/yOrJerJAuqrDV/CzGDTKaxzWaFjPbpfifUoYXEs3R450zUrxpLrDZhFOO5ADnwF8wjSabma0Xneb5naYA6gRK/KR6qKBYyxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6816f9ec-ecf4-0d6b-4eaa-eefcf7b07a6c@suse.com> Date: Fri, 30 Sep 2022 12:50:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6809:EE_ X-MS-Office365-Filtering-Correlation-Id: 254d62c8-bf54-454c-996e-08daa2d18c5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6DbFOg0+VSzuRgDjwtMPJV+yR9W8w0lUMQdtLfLmZkzH+UuYB6RAq/gU5zAYGUWhL/ZJgAb5aqAgGKgvQ0MZ4RMVUxKIKAJZPrYrA8qe47WLAa/QZlheVMA1ojvl5pE1jwczDaycZI3Dtuc1VSqgYGc21gYS3WP3atJ56aA7VUNXu2uLoqhgwPA+2Pd3+OppWC3yZz3X6kEFoXHoOOq9xWl6ryKHf8TgqN61MzVVmBEuEqIOIWA8NC5akH0bJjO7YGggYNlCgVglCH675r6IvxA96jBJbSipbuJij1DJ147TIx1WzOh1CbVWDpD7b8j9XNKmQh1hUihm4WMIk9TEc/SaUIMyTywM8TJzBrEwAPgJf9Rbgg5pItmgpm3rg5LMkc2oPV7278CGV18TvaeJqDaVSsWMZDi/Ti/jSdhxf/fGJcrPc3ZnMNKTuDgDEnVwXN+kA9BQnDCViNduoQCD+sYzSsTiB/BL+2/bX3YFDBhkVrVsWhTMEIUMScLwrJvtVhF1LyEG8E9a8sHZsBwtuoiIqwvJYaiqvuc/I/sOflt7TI9SYk9gdQmtzqo0lTxpLyPxKYn1dcTkoGnaljLgeLts9H85PqniTIF2WR+ZXb5WwlGW0I9dCd8UwELda9m08zeugux0sb0O2Wd2PCE2a+NNRbMar7p/bXXUKpl7cyqAvxTon1eDCsAChwPp1EkfF8jclbvpC7JI+tAQQahtyFjKJ7fhyyHjD4QG1Ru0pAHyuCrVwGvosrZS4aTjO1nEykx56TrRXiZf8KK69wTgq3rAu+V2A7VVY6ELaulDnSk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(346002)(376002)(451199015)(66899015)(478600001)(31686004)(6916009)(316002)(54906003)(8676002)(66476007)(36756003)(2616005)(2906002)(41300700001)(66556008)(66946007)(38100700002)(4326008)(31696002)(6506007)(53546011)(6486002)(5660300002)(26005)(6512007)(8936002)(186003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUwzWG9kTDA0K3BBNUgzTSthNWxmUnJzUFdRSWl1Q0V2VDJhdEFPd0tSSFNE?= =?utf-8?B?Vk1pS1h0VVdaSm9UTE1CRTVXRkpLcVVHVVNWT01LaEVWU1Y0OGFyR3BVQUx5?= =?utf-8?B?Uk9mSEI1M0s1TnFacERQeHRrcm05bXg0akN3cUI2Z2RKRHNmY2NQUTBzalJG?= =?utf-8?B?eGY1blJUSDk1b3l1aUdRVFA5UzVVWTV0ZENLVlRtYnQxS2sxeEdQb1dqSFJR?= =?utf-8?B?cExlVVBFYlBXK3JSZ2YxMTBpdnVacEJzcTZ6dGl6M1Y4Ris4U2FETUhpajdF?= =?utf-8?B?MFRqL0tia0JPdlJ3MmoxV2ZDS1hiUWFRdlh3T1c0YWs5bHdSMlJmS3U0UlY1?= =?utf-8?B?NjlwYmFRcXd3RFFEV1lPMW5DWEcxSTdKYllyK0VDQktUWmE4VXliQm1WVEhK?= =?utf-8?B?b2JsOFF4alBZc1lYeHE5N1k3SkpOMjYyUWsxTTNQMTMzTnI2c0d0cjRFTDZF?= =?utf-8?B?NEFzc1hBQ3BaQ0JmaFlFczlBUW9rSDlhTktqbUFOTGpqMzV3R0JhMlhNMjd3?= =?utf-8?B?ZHBOMW54S1lxbWRzT0k2ZEFKczJidTVVaW8yZHVJZk5iSmVqV25EeklrOFU2?= =?utf-8?B?TG1lYk4reHh1OElGM2hkTmdTWXhPTElCRFRueHZpUnpoZERHbThuY005Q0J6?= =?utf-8?B?Vkd1ZHFocWMzRWlVTEZpd3UwWmI2eDRsTklwK2JHQUhQeXZ1cmMyZU42c3RR?= =?utf-8?B?MG84SzZ3SmFpbmdvdXBYOU9iQUx6ZUoxRjc1OHBhZnhjWjZFeUhUOStXNC94?= =?utf-8?B?UFpRSkRvNjlZUHNNMlFnelNQUldjR0tURk8vSzR4ZzZ5akxhclA2dWRraXo0?= =?utf-8?B?NzVrZ09ibFowcVE1VjRCNDlnMElmQWJ6WVMzczlhR3QvMTNhYmhyaHJYT1BF?= =?utf-8?B?NlZTNGVsMEdIZllNWTNkc1Zic2s2UzNkclQ3U1l6L0s2ZHRoTlZENTd2d3NT?= =?utf-8?B?MURjTG1Ja1pTQ0Zyb2hDWjlVUjVLdkgvRnl6ZzhTNGN6VHZqTU9OZHlJbitH?= =?utf-8?B?Y2lCVEExVWhnMUZLeE9yMVpldDJLSlVrSzdlaVYvS0M1eVk5Z0NIOTVDNUVY?= =?utf-8?B?TDVoYTF6TExIbzZUOUl4cE1YQUYzRWpnOVlQakMzMWkyeEs1MUJFVFpob2Jt?= =?utf-8?B?NDNiWlFTWEFQR1lsUmNoczBxNE4vSFpwRmFYVEZ4eTR5b1BmVjR3MFU2RzBF?= =?utf-8?B?bzEyN1ZtUnhyTFg0QlR1RUNEaWwyMncyVGNHOFNzNnpzak9GZGQxL2NCcEcx?= =?utf-8?B?a1V1QUVPbFFkSndBZS85TUFlVWJmNWZqaG1wa0JLbW1uYktYS3U1Rll4RnV3?= =?utf-8?B?ek9reVZ4Wk9SWUQ1NWpaNHVWN3lEd0h6cWxRVjAydUsva3FwaGlDc0tnYUNh?= =?utf-8?B?anZGR2ZEbUVxZ3QxUzlTNlhiMVQxTkNFOUlwdDN3OHhGMHlCOGlraXE4c2V0?= =?utf-8?B?WG5KRnJwdUFVd2YvbC9WeUtJdCt0NGV0Z29maVBHOTZCam9ZQlRNNGd6MDA3?= =?utf-8?B?aHBnY3RCWU9VMlI3aW52cGVEL2lkVHhQRy9QellQNVc5NU9UakNkNXYvWW9l?= =?utf-8?B?VEc2NXk5ZVl4VWNJcVpWc3l0YzZ4Y3J4Z1p1L05xQkFSa2c2aktPbFJwUElE?= =?utf-8?B?MWE5SUVBRjVQL2tZZ0hraUNLa0xKWjd6KzFTL0tpR2d2a1QyaDNISUtSenB1?= =?utf-8?B?UC8xTVh1bjJ5ajZKZkpOL1lYRFJlay9JTHlab2txNWVZTUw5RkMrVll1S2Zo?= =?utf-8?B?VEFIaEl2VVNsTkpnUkRRRG1DbXlSNGM4YXpuUjR3SmFqeUN2OGV3dk1lRVNl?= =?utf-8?B?WCtIZVV4bFRiK3lod0lxVlU1SWlrRkZ1NUVVOXY2RG12NzgzNGFaTGRHM011?= =?utf-8?B?MTl1a3ZkdE1NNGRZdVpxbWRLK054MkZNNGMvN1Nkd1ludEk3TXBRNU9wdTB0?= =?utf-8?B?MnhXRGpPc2JQNms4amtLVWFUdXhncDVLUVVZNjlrcnFnRnh5ellsclMzdFpy?= =?utf-8?B?N2xraWhLMGJlazd3UEUvU203aWgyS3d1TVlYcUtRNHJ0MlVYYXJrRnR4WlpH?= =?utf-8?B?cERYOVNRN1BIT3RNaGZUTFpCYkgraEthSU54MHcxWXdUQldsbVRUYXFWMUlP?= =?utf-8?Q?rOoIdHSwlijEC3S59JvPeRWsH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 254d62c8-bf54-454c-996e-08daa2d18c5c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 10:50:11.4339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PfvZWP8kPx4gVUHrYmcDSDVHVRvzRwUxkHACI4iE1GeDvWjdnXx8MDkQ9mXGC5LcuH9tBTizMt7a4zWb0sjkBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6809 On 30.09.2022 12:03, Roger Pau Monné wrote: > On Fri, Sep 30, 2022 at 10:36:20AM +0200, Jan Beulich wrote: >> On 30.09.2022 10:25, Roger Pau Monné wrote: >>> On Tue, Sep 27, 2022 at 06:20:35PM +0200, Jan Beulich wrote: >>>> @@ -413,14 +414,37 @@ acpi_numa_memory_affinity_init(const str >>>> node, pxm, start, end - 1, >>>> ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); >>>> >>>> - node_memblk_range[num_node_memblks].start = start; >>>> - node_memblk_range[num_node_memblks].end = end; >>>> - memblk_nodeid[num_node_memblks] = node; >>>> + /* Keep node_memblk_range[] sorted by address. */ >>>> + for (i = 0; i < num_node_memblks; ++i) >>>> + if (node_memblk_range[i].start > start || >>>> + (node_memblk_range[i].start == start && >>> >>> Maybe I'm confused, but won't .start == start means we have >>> overlapping ranges? >> >> Yes, except when a range is empty. > > Hm, OK. Won't overlapping ranges be bad if not empty? They are and ... > Shouldn't Xen complain if it finds overlapping ranges, or that's taken > care somewhere else? ... we do, elsewhere. Still I'd like this code to be generic, at the very least to - as said - deal with empty ranges as well. It didn't seem indicated to me to special case empty ranges here, when the code is more clear when written in a more generic manner. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 10:57:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 10:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414126.658234 (Exim 4.92) (envelope-from ) id 1oeDhv-0000tf-IB; Fri, 30 Sep 2022 10:57:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414126.658234; Fri, 30 Sep 2022 10:57:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDhv-0000tY-F2; Fri, 30 Sep 2022 10:57:27 +0000 Received: by outflank-mailman (input) for mailman id 414126; Fri, 30 Sep 2022 10:57:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDhu-0000tQ-2s for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 10:57:26 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140084.outbound.protection.outlook.com [40.107.14.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa5950b4-40ae-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 12:57:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8775.eurprd04.prod.outlook.com (2603:10a6:10:2e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 10:43:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 10:43:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa5950b4-40ae-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nbxmmxnJ89KUNEbarObmRdogoCx9pVe+cx+FvvvCTAvtSPw5JUzBtY5C6HvgmOr71StJ8d+ODK7BjKSDfEPWqQ9kBmDACPsJiqw6tvElQB9scYqX0OvdYCF/f2Mj6tiswMyQhDqQzxULevaCraWc0LXu//u32FZ8nF75WWosFmJfaO3V+MiY5PcgDUcg77qfg+5wO2GjNXYR1SOCk9RSNXjcW49r5jWWeiblmFb+pKPeXZlwTTMoC96w56axbvRlMxiZY8e+SHq1h6dDBluZDFeOopDt4TotudnSYdXHQ3J7bM8eh2nJx52VeFXV48n7PmsRv7OYwCEcSXcZVr847Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvSjxosn18P1pUVmH32IK52tnSDDCwqm+h+Rhh6OsdE=; b=XRCZr6yTnIUYeFa9jWbxbIUM2fQvaE3+aPRWnWZeln2AUdSV3Tmr4Gq+ba0QDhhm6XiEfxWNSAc2Srv1CBPXhHa4KFYYVwKog36qHJNneK3qgkh9WplsIAjG6wLxqzdBcvtCeh+n97vtHR9qUS7aVKLF0+K/pZpaE7tgRjGy5/1inEZIeBDJFeZnqrXp4Go9NnBGWuuXEm17eowXTQ+sUhxn7egntFkqtmbqxJGPzGtkdkwv2L9R1AeM898eoeHT3dKRx1ZmO0R5uaymGEX/B4ekGToFmxWI4CyLeOXi0Uc2sJcBDvjU3t7n5J92xBVwBU11tra9baSY5POA6EC4Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvSjxosn18P1pUVmH32IK52tnSDDCwqm+h+Rhh6OsdE=; b=YJ0jLuC689IG4KVCTCtvrM4Eq0GMOqwkZ2hDbWLMPCV0SYSfwhjXdY7A2SK5BLc+n+R7cHzOy2QZsGzH5/CBsskSIHwXqI33k36/+MdNaCF4Apk37T6VWiFyEg8yqXqs5NgvYUUfC/skDs8i9RhE//TQGiS58ZPFdQl/bxNpolM2a/xQi+Bb7QJhps2eZEavnKHcq/LkIAVP9HqO+/q6QJUMXTyqVV+LQhK2FA0/1zGlIPntYFfsFfCLbDdUbzLuOhSXk3xno8cZnoyqcBY+PU6l869dEWrmlVfMKsyqE1JKU5J/z0fYd6GqVp5Bl7c8nc2Sr8PnKJNbxvdWJKCidA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 30 Sep 2022 12:43:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [xen-unstable-smoke test] 173362: regressions - FAIL Content-Language: en-US To: Anthony PERARD , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Cc: Andrew Cooper , osstest service owner , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang References: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0390.eurprd06.prod.outlook.com (2603:10a6:20b:460::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8775:EE_ X-MS-Office365-Filtering-Correlation-Id: 957188f1-26d5-4b07-88bd-08daa2d08f9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tcbdhvV9JyuVTNEitjnVKDiiKg9c9yryOvKu/yGgPpU0ll8uCIqMw0BDZl0lUsa7ZmWMtj2vcVFDaoTX3NQHI4hGq/Xy79ZHUaBsBT5rFKOI6Ch9tQPeUWPciVtQtd9W05YSNL24ORp37mlOdzd6x6BpoCm1Ue6Vbal6wI6xFbC/+uMCHVOiqhj4o8Zg/sQ8WRwupcLy492hGrs+zxEF025obFZKgtMsfNYLjcuc3MZNdr3kL5mX8Q6WfrM/Cnm2I5ixDrXOaqPmvlU2a6c7eg5EUnUcAn06rePktzFLMVR+7ieNjqmCN+2dCnz83L7z9xVL32XFTwJvGiByKCh2GCCl7KQtOhY/fc+i71j+tm8USR845mFPbws7zgBcTBMr4mPlmCO+5tlJaA9qmBRc8okWmfc6fEEOz+qwOJexAC+6DDEmqgMLVKjsoPFyhmfNv3f3wd3XT6jIJ0vTYOe2U+GP+9pULdsvoB+z7u0F87C/vUFmDbviFRUh6iWakkiOI1JhfjwwwGqrLtzE9WTBzI7whhVde1dVjQ9A+KX6EM7/F6WtTyJQu3qzUXVckVvjcMdgUn9/e76RgEOe+ECWMcQF0RMnwmwf+KZE09xZW56+zDg2zK/r5DM7zdFqPjmcKUTFESeM8UcC6SGLynVr5Yg3rOnDOLLr+nnz4PykxCYaSdiPSgq6iaaAM5PrFwSAvJiq/ASO+zWIHO2sIQVvIHtpBDqXqvLRApVtQHt/vuprb53iiYjIblHpXHMghdd2dXCK5jc5o5fpWra178pcjBK6VHAgayzk8UAHvSUXdJs29vxngklBxZvKnw8FoXPH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199015)(478600001)(6512007)(26005)(6506007)(2616005)(83380400001)(186003)(5660300002)(2906002)(7416002)(54906003)(41300700001)(110136005)(316002)(966005)(6486002)(8936002)(4326008)(66946007)(8676002)(53546011)(66476007)(66556008)(31686004)(31696002)(36756003)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzBPT1FzblZRQkdIbkRldWFScGJzTGY4WWlWQjZJbi9lR1U0ZnVXY0N5N3l4?= =?utf-8?B?cThqcy9JQkYwYUZFMXUrSHdhRC9xekR3QXVrZFFxSGViZlk1bWJUKzk2d0Y4?= =?utf-8?B?SjZxdDgyZlNYbkhiajdld3FKdU9JWndnYVErakxXWVhOemdyTHdvRk5SRDlE?= =?utf-8?B?L2dTSnFLUmNGYTJIZEk2YkQ5YjlDR3BnY0xWY1BjZ01Ia2JIRnhSOW9sck1O?= =?utf-8?B?bnU2ZExEdThTNjJ2ZG14SkFJeVdIVFJjN1Y4ZTJ4QjVwWXpnQVJzMW94ckNH?= =?utf-8?B?ZUdNNEhzWitHSnN6bTAzTTBDcXl6Nm5ZdGM2ekR2TGxrdm92UGxiWkFzWkdS?= =?utf-8?B?eFp6ajFRZXU3Nng3VHZGWFRxTENhSWMvNXEzOWxlT0JobTYySmJTNVZCcTlQ?= =?utf-8?B?LzhpOTE5ZHVBd3lFRS81djNNK0FuS3NQaFVMMmVkcVhoSTh3M1lSUG9TZkJ2?= =?utf-8?B?TmxRdnRGdEIrR3FBVHR6cStkd2dwaTVFSXRSUEpFdGNFenpZc1J1Lzkxc3ds?= =?utf-8?B?WkRrL281YWlwWnp6MFNtUktqZFFvQUx3QmQvNlB3Zk82Y3FiUzlYK0UwTmsz?= =?utf-8?B?Vk5Gc1NZNFVoc3E3RXp1cFFWeVRXZEw2ZHVobjBYQ05Cd3RpbEdNTmpMR3dK?= =?utf-8?B?YjFIcUtnQUl0RTB0dkkxa2lxWXUvbVErV1VEVjJ2S3hZeVYways4WHZKZS9s?= =?utf-8?B?a1FkZmRLcXhBSjFLR0Z0TkgycjZmOURIdE1UblFKWENmVWptWTU0R3Z1ZmJ5?= =?utf-8?B?Mkx3a3VUV2pZUFd5L2lVbkM3d3ZsbkhmTEJZTGdSMStNMWJ2MmcwWnNGeVBR?= =?utf-8?B?Z1RHYkpTTWpIK2F6ZHIwVWRSRGc3Z3kwS3RmUi92QkNZN1pCUXMvVGNRaEJu?= =?utf-8?B?NzZYY2hnbXVGNTVwcWFXb2lLR3JlVm1Ga2FpYjdGVnF6eExNbkZ0aUc2dE5h?= =?utf-8?B?dUkvL0hEM3hMa2xSTDNOYlYwYXB3cHNjbnlhRGQ5cWlYNGJCeFRreUNvcGRz?= =?utf-8?B?WnBQZyttTFNmU2lJUExQYnZBaVdpYVhIeTlNOS9OVkF4U3NuRzhvRDljUzlH?= =?utf-8?B?ZUlYS0JKSjk0RzZMeTJCVk9yb1hvcTlieE8yVXM5bnNWNFJZL3F3WnRRWEx4?= =?utf-8?B?amw1YXhEYnhsMWJmeGxDeGdzcDNBc1RocWpFNjZYbXlUUlUvOENTa3BnM3I2?= =?utf-8?B?MnJpTVlFMjg3YVl0REtrMnRPNmQxYis3anRmV3NsT0ZZS2dsQ3h0dGp1Nkk1?= =?utf-8?B?TWNlVW9jK2tjTkxXSGpDYlJiWCt1S3RCUnFoRDBjZUZZdTZ2OVYxU2VqalpN?= =?utf-8?B?d0JKYm51cGFXSHBpVHpFVzJjTlVPbFdsN2dQcHFrdldkd2pyWC91VlZqMmZt?= =?utf-8?B?RHlZS01SSmU0ZjhMWW1PbE9FcU1TRnVUcm8rbXZDRzJHaUxubWVmTTZSbE1V?= =?utf-8?B?eXRoZXlCTWt3RWc0L0NOZ2w2azl3SkF3Ty9Gd3U2UXI0TlRoMFNzS1Mxd09p?= =?utf-8?B?dUhiVWF4VFZySzJNRmtQS0tydlY0SWh3QmpqcmRicmo3bDFuWnlOMEZhbmJi?= =?utf-8?B?NWN6MnZlaUR1WHY3RE9IM1A1eUgzanJiUXp3V01vTlRqZWxUNlJ3QTNvS3Ni?= =?utf-8?B?OHJReEswVHViOERodlFleVdqVVNGeUROY1AwWmMva2JvUUFLMkFzTUdoQWEw?= =?utf-8?B?cVljTDRSODMrMHhjbW0vWVBjMEdBVzdjK0hyTDd3ZzkrdHVQYXhDM01MVTV5?= =?utf-8?B?ZzlkZEhWaE9PTlJPRk0yZzY4Q3BuUDg4Tng0N082cktKcWdoRi93OUlUVUVK?= =?utf-8?B?Y0hWTElpT3UvZVVJSjhOYitaNlE5OEJOMlVFWDFyWHRVM2ZaenZ2dGFUNGJT?= =?utf-8?B?SE96aFNDMThjdytMbmtYWG9YREVtbGpmeVM3ODJLNXFBQlh1NmNJK3FSSDZO?= =?utf-8?B?REFVSkMvMkoyOHlScGM2ZXVJTXpBT0szZWpEYkRVOE8raDZPaG5PYlFRMmd0?= =?utf-8?B?MTYvSXNSM2hYL2ZUSktsNDBZMENaaVZGbEJCd1oyVmlmM0pORWZXTnR6Njcx?= =?utf-8?B?TlhPcDB5VElDbmVzRmsxT0c5cTVtVFRnY1dIZ0NnRTQ3Q3k3dEtDSWJhd0ZS?= =?utf-8?Q?byLRixynjh2uNqJvblDkBN3Gc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 957188f1-26d5-4b07-88bd-08daa2d08f9b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 10:43:07.3984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yBX0KUkyqEn2p6WwG3jVXdWE9nZ6xuD9BhoCUW0BJIqKOLU4F8C6rEF8mYS6EDW3A9zTMuI7Rugw+lFTxTI8gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8775 On 30.09.2022 12:22, Anthony PERARD wrote: > On Fri, Sep 30, 2022 at 08:31:20AM +0200, Jan Beulich wrote: >> On 29.09.2022 18:25, Andrew Cooper wrote: >>> On 29/09/2022 17:22, osstest service owner wrote: >>>> flight 173362 xen-unstable-smoke real [real] >>>> http://logs.test-lab.xenproject.org/osstest/logs/173362/ >>>> >>>> Regressions :-( >>>> >>>> Tests which did not succeed and are blocking, >>>> including tests which could not be run: >>>> build-arm64-xsm 6 xen-build fail REGR. vs. 173347 >>> >>> arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access': >>> arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of >>> 'iomem_deny_access' discards 'const' qualifier from pointer target type >>> [-Werror=discarded-qualifiers] >>>          rc = iomem_deny_access(d, mfn, mfn + nr); >>>                                 ^ >>> In file included from arch/arm/gic-v3-its.c:24: >>> ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but >>> argument is of type 'const struct domain *' >>>  static inline int iomem_deny_access(struct domain *d, unsigned long s, >>>                                      ~~~~~~~~~~~~~~~^ >>> cc1: all warnings being treated as errors >> >> I've sent a patch, but this raises another question: Why does the smoke >> test (try to) build an unsupported configuration? HAS_ITS (which is >> necessary to be set for the issue to surface) has its prompt depend on >> UNSUPPORTED, and (implicitly) defaults to N. > > According to osstest sources: > # ITS driver is required to boot the Hardware Domain > # on Xen. For now (Xen 4.10/4.11 at at least), > # will be not built by default and gated by expert mode > echo >>xen/.config CONFIG_HAS_ITS=y Hmm, that's been quite a number of revisions back, without things having changed. Arm maintainers - what's the plan here? What use is it to test an unsupported configuration (for years)? But there's a more general aspect here: EXPERT is forced to Y here as well, which is fine by itself. But it implies UNSUPPORTED also getting enabled. That latter aspect is what I consider wrong for smoke flights at least. Yet (as said) HAS_ITS depends on it (and its setting to Y by the script would have no effect if UNSUPPORTED was off). Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:07:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:07:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414132.658245 (Exim 4.92) (envelope-from ) id 1oeDqx-0002XW-Ek; Fri, 30 Sep 2022 11:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414132.658245; Fri, 30 Sep 2022 11:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDqx-0002XP-By; Fri, 30 Sep 2022 11:06:47 +0000 Received: by outflank-mailman (input) for mailman id 414132; Fri, 30 Sep 2022 11:06:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDqw-0002XF-GL; Fri, 30 Sep 2022 11:06:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDqw-0007Jx-CK; Fri, 30 Sep 2022 11:06:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDqw-00058A-0D; Fri, 30 Sep 2022 11:06:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeDqv-0006tB-W0; Fri, 30 Sep 2022 11:06:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LsmFiGXrInE/IxJGjJIaJPIX6pXEgVfbbJm22TpXlEU=; b=GdNoJ6VsC1duHv8Hqys3FQvzGo lajjvJUzB4+tkaevOkiZABbVkAJy+dCCO91A9hPXH32Yq+zTBx2O0PAX11+S7ofNB/Ynf9GoKhXTW TyTZBHXs+NBqyTxJe/7LslFtbKABylJHqnDehvRA6jI4kEklenEwxzTaeOGfIet2wy7A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173384: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=38e1276db4c5457cd6e7811b4e168aa85c8a0b06 X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Fri, 30 Sep 2022 11:06:45 +0000 flight 173384 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173384/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail like 173342 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 38e1276db4c5457cd6e7811b4e168aa85c8a0b06 baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173347 2022-09-28 05:07:54 Z 2 days Failing since 173362 2022-09-29 13:03:03 Z 0 days 7 attempts Testing same since 173384 2022-09-30 08:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand Tamas K Lengyel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 211d8419ef..38e1276db4 38e1276db4c5457cd6e7811b4e168aa85c8a0b06 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:10:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:10:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414139.658255 (Exim 4.92) (envelope-from ) id 1oeDuM-0003sf-V5; Fri, 30 Sep 2022 11:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414139.658255; Fri, 30 Sep 2022 11:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDuM-0003sY-SN; Fri, 30 Sep 2022 11:10:18 +0000 Received: by outflank-mailman (input) for mailman id 414139; Fri, 30 Sep 2022 11:10:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeDuL-0003sN-E2 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:10:17 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 765fcefe-40b0-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 13:10:16 +0200 (CEST) Received: by mail-wr1-x42d.google.com with SMTP id f11so3645196wrm.6 for ; Fri, 30 Sep 2022 04:10:16 -0700 (PDT) Received: from horizon ([2a01:e0a:19f:35f0:dde5:d55a:20f5:7ef5]) by smtp.gmail.com with ESMTPSA id f15-20020a05600c154f00b003b476cabf1csm2035101wmg.26.2022.09.30.04.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 04:10:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 765fcefe-40b0-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=lVCtHc1fCKHeC5BSoXyZa1ptlA+WKPf5+big9WGJfI0=; b=jJlFUetdRlTeP/0Ko5VUnKadL0jy0TdptdQJf1PmjbZZkvZtW7107l9fPK69O1rRgV wLjgSTBU1gf1oPO+AUoVkFf0GvS0E7Ysmd5q+MEqWagfhB4f/EGSvZ+4DppWsNyDC3H1 Eh9T0zjRISFE7vOwgSXyOLxoBku4kig/p0YCf10CsRKGUQlvn5kXKxnykYUfmBtBv+Uq 7EX73zdiTSbN6A36rCAanNP2G3RV7gloFKeYdv0FxQwr+r4O3Hj9zLH7ZxaIqDQP5PIN vNL5GHm5C5rEszRqqeaVpkFamqf8IewF/PotUWjxIgi3fCJ28BdHcAlIIX3ikSo5gNqM qWcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=lVCtHc1fCKHeC5BSoXyZa1ptlA+WKPf5+big9WGJfI0=; b=7Pkv0VGeBT+NyYeBrg80HtaSU0AoJ1KVSd/Gl91B1iK80zDTDsWaEo8+PTWTjE5Sz7 u5ccIb1mErE2I4uRiB/ymB1OiWkx7l0WKCHRbyFZe+qxE6gv5WIOYtYEvmtynFNoTUwS IU3RqshRd8NrIr476cQoVmolpwqxixf/nMOAmyeKrMwbmRTWCyzps3oaKc5J9dkc299d XYfyWW6G8cQ5DFD4DV2F7E7op9tb2wRcsaQCCttrdy29WXkJ5NSNEReshk3wVpgW2LJ9 SuNnT/qvplGr5BSmJ+8LTRYTj22v7WzpIATKV3KpFR1bqDsVykLAT7oXCGRLUt+wGZFr qbZg== X-Gm-Message-State: ACrzQf2TKaC/57nDvH9sV0VhJfvIbIRIBEPI3cWdvFI3mrVXIw3CHbP5 PLuBYakdd4s9Pd02M6wp8WE= X-Google-Smtp-Source: AMsMyM4CGNwgviKo/7SRCRqGE2nZLkkYBntwCb8kA16Km+Hfz3CsOCXEsF9zKEFZxFE9iD/SRV/eFA== X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr5083143wrf.142.1664536215792; Fri, 30 Sep 2022 04:10:15 -0700 (PDT) Date: Fri, 30 Sep 2022 13:10:13 +0200 From: Matias Ezequiel Vara Larsen To: Jan Beulich Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH v1 0/2] Add a new acquire resource to query vcpu statistics Message-ID: <20220930111013.GA877987@horizon> References: <268f8c2c-57ba-e4e3-59ef-45ed3cd794de@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <268f8c2c-57ba-e4e3-59ef-45ed3cd794de@suse.com> On Thu, Sep 29, 2022 at 05:55:50PM +0200, Jan Beulich wrote: > On 24.08.2022 15:27, Matias Ezequiel Vara Larsen wrote: > > The purpose of this RFC is to get feedback about a new acquire resource that > > exposes vcpu statistics for a given domain. The current mechanism to get those > > statistics is by querying the hypervisor. This mechanism relies on a hypercall > > and holds the domctl spinlock during its execution. When a pv tool like xcp-rrdd > > periodically samples these counters, it ends up affecting other paths that share > > that spinlock. By using acquire resources, the pv tool only requires a few > > hypercalls to set the shared memory region and samples are got without issuing > > any other hypercall. The original idea has been suggested by Andrew Cooper to > > which I have been discussing about how to implement the current PoC. You can > > find the RFC patch series at [1]. The series is rebased on top of stable-4.15. > > > > I am currently a bit blocked on 1) what to expose and 2) how to expose it. For > > 1), I decided to expose what xcp-rrdd is querying, e.g., XEN_DOMCTL_getvcpuinfo. > > More precisely, xcp-rrd gets runstate.time[RUNSTATE_running]. This is a uint64_t > > counter. However, the time spent in other states may be interesting too. > > Regarding 2), I am not sure if simply using an array of uint64_t is enough or if > > a different interface should be exposed. The remaining question is when to get > > new values. For the moment, I am updating this counter during > > vcpu_runstate_change(). > > > > The current series includes a simple pv tool that shows how this new interface is > > used. This tool maps the counter and periodically samples it. > > > > Any feedback/help would be appreciated. > > Before looking more closely - was there perhaps kind-of-review feedback > during the summit, which would make it more reasonable to look through > this once a v2 has appeared? > Yes, there was. I will submit v2 from feedback during summit. Thanks for point it. Matias From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:23:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:23:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414145.658266 (Exim 4.92) (envelope-from ) id 1oeE6w-0005dM-3e; Fri, 30 Sep 2022 11:23:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414145.658266; Fri, 30 Sep 2022 11:23:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE6w-0005dF-0a; Fri, 30 Sep 2022 11:23:18 +0000 Received: by outflank-mailman (input) for mailman id 414145; Fri, 30 Sep 2022 11:23:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE6u-0005d5-Id; Fri, 30 Sep 2022 11:23:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE6u-0007en-D6; Fri, 30 Sep 2022 11:23:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE6t-0005ZM-Rw; Fri, 30 Sep 2022 11:23:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeE6t-00082Z-RX; Fri, 30 Sep 2022 11:23:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=14X4GnmQIz2LPMQM0ZQ5EvUBdpMh+hlOcaesPmUtzW0=; b=QrrfGYsIJHskxBHgVDc+ywD79i D/grAXNNcw6O0rWU4YCtnArARrZnveSpkrdC0o3/Tmfpje6TI+QywRzBHQNZ+2L2vOgCQKzY0M9Ev SHUz0sEEH/+XlsTqsYccCG/gg9O1S31X9aICB7KPFNtw9rOjCrCFc4/8TMJq2DbOVY64=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173379: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Fri, 30 Sep 2022 11:23:15 +0000 flight 173379 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173379/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail pass in 173361 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173361 like 173358 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173361 like 173358 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 173361 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173361 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173361 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 173361 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173361 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 173361 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173361 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 173361 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173361 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173361 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 173361 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173361 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173361 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173379 2022-09-30 01:52:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:23:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:23:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414150.658278 (Exim 4.92) (envelope-from ) id 1oeE7J-00065X-IT; Fri, 30 Sep 2022 11:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414150.658278; Fri, 30 Sep 2022 11:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE7J-00065Q-F8; Fri, 30 Sep 2022 11:23:41 +0000 Received: by outflank-mailman (input) for mailman id 414150; Fri, 30 Sep 2022 11:23:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE7H-0005yl-Jo for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:23:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 533daf19-40b2-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 13:23:38 +0200 (CEST) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 07:23:31 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5229.namprd03.prod.outlook.com (2603:10b6:208:1e9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 11:23:29 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 11:23:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 533daf19-40b2-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664537017; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=74AUi90DdxL6dGcaAMIOBr+kSPxXx8XY4KCnUqBMJWQ=; b=RehfuoKk5OMMhTKbD13zvoZ/MWMM+Scxw/eQe/qVSEv0KorbP1oVEiI2 T16RvvrIL4PscO/dewjJQh5BCnKdOz02DlL+EpUY6WcN6DhCRRihodLza ugZvf+FVHyWiMX48ONwah7oJfEW1mqkHiruuuTGmzAXr4fhOh47tWGsXS I=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 81350636 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jIrfx6nFp0AETarqolrStkDo5gxfJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZUWrSMv3Yamb9f4twaYm180MEvpXQnNU3SQc6rn9jFiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS83uDgNyo4GlC5g1lPagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLEMey KRfBWo3Qxmmps2/27y/bq5emZF2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFMZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r837SSxX2gBur+EpW/9tJEvUO/7VAXAQURfES0kaKEuk+xDoc3x 0s8v3BGQbIJ3EWuRYijdwaiq3DCuBMAM/JXCPYm5RqRj6PY5gefLngJSCZbb94rv9NwQiYlv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty/nuppsiyC3GSNlLGbSwyNbyHFnY6 T2QsDI3gblVqMcRzri65njOmTfqrZ/MJjPZ/S3SV2Ohqwl/O4isYtXw7UCBtK4faoGEUlOGo X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhknTKu1Gq7ooQPUX XI= IronPort-HdrOrdr: A9a23:tz8LIqHfo+hTJUMdpLqFc5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczKgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxenkPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesaMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO21GkeKp ghMCjg3ocWTbvDBEqp/lWHgebcFEjbJy32DXTr4aeuontrdHMQ9Tpr+CVQpAZDyHsHceg12w 31CNUXqFhwdL5mUUtcPpZ0fSLlMB27fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81350636" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FsUDK18RerMm3gKiQFA9lglvS3fqK52kemDsgDvpCgaYzqJsDRdPJ4B63AvvchAeXIatE0VSixZDyY/2vmvW/VuEyKWuAVBoyYO2s/MS60+AazecqKXFk6PHBBp9l35Ot5c0eI2sNf1bfJIxtGxadJZA8xHQzTBHmRZS9/RTVXDRQrwZ692wIPKfLqVZFl5PChWfcYq4dPCW7R2S9ze3HXE8ueih4pLJgMPc3g/25zV9UwDOK8yx0//ohPUwaedGxtUOvWDlc+vjLbc5Scw+kgLZsBUUFWnnvFGq7IuwA3vRtNiAXAbyDtE31Qp1etd+nqMpPjP+KHRZibpKE888uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fDSz2XNfzQl42ZLB5NRyxoIDse+60zT/s21jP13h+WI=; b=Xa0tbglmE6FS9PVPM32J/1JyvDnhTCcWUfW17h4YAfwMjC4Hg9nbtCYSWsquJu+evxQaDKmZhTdfTQSb+mbz4dRcw9C9leCiO6hvy2mc7seevdsEae2aj2xYuAn4e28AIiplOOSRJi1ToRz6fcRgJs/uR6TTT65w9iL+IG3N0qdopknBkDu9RDqHwqjGgXC7UttIOLYdgU80B6dCcubcWLhYpLkxPatTM7AD0KLL8WU4YvJTxEgnu1lChhZJwjaz7BQ4p88k+4kqPDrEzM5tWSaRMmPHmPW/2O9NbVV42R5gyOHsKmZ92lwpBYTqZUvyYAeO8grUU1zGAOZsfiHguA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fDSz2XNfzQl42ZLB5NRyxoIDse+60zT/s21jP13h+WI=; b=aQ0JBTiOimfZxdJu/kQrHc38meDXnHDbbYqskqHQpP8Tz3skMiPMdJwzuSeZVNJrdX72NAX8KfGihvWb3xeol8lq7TSM/U8nIMwzEBEnvGgEw8JtDXJMTe/hH3H0cl0ulxjoPAkTLdRPjbOP23Iw+kOtwk0oA+FrncUXtxE88wg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 30 Sep 2022 13:23:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: osstest service owner , xen-devel@lists.xenproject.org, Henry Wang , Bertrand Marquis Subject: Re: [xen-unstable-smoke test] 173362: regressions - FAIL Message-ID: References: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> X-ClientProxiedBy: BN8PR04CA0052.namprd04.prod.outlook.com (2603:10b6:408:d4::26) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5229:EE_ X-MS-Office365-Filtering-Correlation-Id: c5f9178a-7e4a-40b5-02f6-08daa2d63313 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gBrtRdwmbtnEVEDDjnsE8q50ui30eNpeiupY7yqMrxGUwE4CaOwCIctW9tX8L97w9DkT3l9ysE+UF9lZj33hl/ZouRgIrmlrYbOvYJWYDDeTUW8kU+y5AaXR+Dx6uNbCm86Y+5O/iGtoVF5+3BEzoperZnf132C3S0eII7C+ACvDL0dRAQJQ92qiXD4iy8YwdVjmNUK7nMn94zYz09JnnoXQ9TVp9bQ1o2VJBXmb0TnpV/nyLem0QDQ75EkGMmPYdpE0RGlVLm1bHmPuCaOV5aNdPibFn6WgUAoGHNr8HZHEWaTdRKNUy6am0AOpAxedgw3J5GssDEjfAb0D+E6qXlcjtyU/hq6UfqOv4R4Mf9nQMhL/fn1UWS36wsYwrZAMg5Cv3atVg4HXtRubAj44MGLkx9MmUnQOAOUVQefnA8qh499KgRCh6liCKT5rIcVPpDRJ8lvkjQKgjp4Bgtt+FzJF2yH1m6jD3eO0WR8vK155CbUmtPQz+wEMyNscUWEdNbTm7U+LXRx4tVAhQGtzrx99uUajxLCOCh7vUmSaZfykZFrd2Q+oBmH4Vmm/P0kCFHS5APSUSqX1DMiRsueBKAJCr+jn+wWLGA1X33HICD897DLp//LBUG4fbIIEpK/AZ8XZoUIaR2tmtQI5C5bqJv1MS9mojO4mkZuGubNSYTLTNL9E3bVQsieCNR33Ce2OtgyOJFzwuLcoG4TY5T8RXf9EgPi5b5npMom0Q2taQCdkfgdP9QanhmjLzDXnAijvPgJBYu+78JW2Qa8IiCAnpJJKNXWoAPBDaDaMYTLXu5o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199015)(6512007)(316002)(54906003)(66946007)(66476007)(66556008)(6486002)(966005)(8936002)(5660300002)(8676002)(4326008)(53546011)(6506007)(478600001)(6916009)(9686003)(26005)(41300700001)(6666004)(82960400001)(85182001)(83380400001)(2906002)(186003)(38100700002)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGUvY0NWSDB5cG0xdlFMTVJYMUNyVkkxN1V0Sjl3YkZQeUVlSmNpUXBuaUJH?= =?utf-8?B?MmZxUG5UL0swcGxoZCsrclVKL3hicFJtaXBqVloxbHVEdkdPOWNybFltV1Z1?= =?utf-8?B?L1FuQm9kckJzUHJUMFdOMVBVZXlhS3pwNFNONm1zQmZVOEs3NUUySGNJZGt0?= =?utf-8?B?Z21WaWxucStUU3UvWVVRc28xbFgzbVkrUUYyVkV6YzlJWWY2QUJhekt3SXpE?= =?utf-8?B?WmtQVFRIeFZTTk1OMU9DSnBNLzRDbEVhT0QyZlFqS2phV0JVYVpsZU5tWEVs?= =?utf-8?B?Q2l0bGtSSmY5U1RPdGFiNWtNd3VEZmFzUHF3VTl1Y0dFRFNOV3lmdW9SOVE3?= =?utf-8?B?REFCOTdqei9aNlNINkZyQk9KR1ROYjh2NXJTVWRVT2JFTXFLSGNDbjd5R2dV?= =?utf-8?B?OVVjK2RnWXhleGowbGxNZ2JxeFJuSjdwSTNKajhja0JST0YzVVRHQnJzOUJs?= =?utf-8?B?d1VSczVIRGJLSndIVWI1bjZLZ1RsV3F1MXcxTlA5VDJOK1krMjh5Z1hDbVU3?= =?utf-8?B?NXQ3TE5jSDFMVFcxVGxhUW84enhoYkdZOEY2bG04c0d5ODBrd1hxRERPcnpu?= =?utf-8?B?R3l0UWR5YmZKTzhoS0s0QlNLT0w4M01tblVLa3RHeTMvUUJYR3lGNHhYMlA1?= =?utf-8?B?MENUdXU5aWROT09ZQ1g4aHcxbkx0eVFvL2tvK3NMVlBCNytscUpMOG40YlFq?= =?utf-8?B?WktnTUFQQi9ZQzcvbndBcTlXbEdzY1piNmZ0ZTZCTmlDVzhhR0xSeTN1N1l5?= =?utf-8?B?a09uNlhhNzhzY2N3UUp0N0JoUHpDRExJQnp3THBCVk5jRHFjL3pCUWJTUHE0?= =?utf-8?B?aEt3c3FmblNsVU1PNGdOQ2tOZlNJZjNMRlQ3dWgxbHJMQ2ZGYzJsWmV3b0l4?= =?utf-8?B?d1g3VEFSSWkyZkVLZkVDNTVVeGJwTnpmMUwyZlcvcmtMTVRSU3N2U1J5ZEFr?= =?utf-8?B?YW9qajc3UnVWRkxVM1VLTDFDbUxHemQvR29qaU82NWtTMGcra0VqRmx2MHhO?= =?utf-8?B?MEZTRGRKT2dvWXFTK0p5VGE5YUptdXl4L2xqZVdrL1pGZ0Yyd3IwdG53TVBY?= =?utf-8?B?eU51MHVTTlk2K2ZvWjBpMjhpTDhiMjNWbVFIQmplU3E5Mmt5SGt4ZGpBSnUx?= =?utf-8?B?aTdWRFdMVHRUVFh3bVkvUUliQTl1eS96YzVkTGRUOFVIZWZqb0l5Rkx3RkVN?= =?utf-8?B?cWx1VU4zUEZiT2VLYTlCeTgrd2NJck1QYlJaMnZaWS9lQmdJMVhmUlg4VUln?= =?utf-8?B?aGV0WHdPZFRXSzFVQlZBNEd6cnRrY2NhY2VRSC8wYlR1QkxPYjVleTVMTmJh?= =?utf-8?B?Qm5RNU80dHVQdnpnNWRZaWhOaktJdXhmSmRJTFN4ZHF3NjFOL3B0bm4vWlIy?= =?utf-8?B?a2drS2ljNFFmY21hSmlNOWtnUzJvZnJoQnJKQmhMYlNjTWFqdmpTSm1Wb0hh?= =?utf-8?B?Q0gvVktxMlI2RFVnRWlmNDlpaEdYMGRnZi9iUHhVeGJjVFpFbmZxOGxKQ1Vl?= =?utf-8?B?MktXK1RwVDEzQWYzTjVud3VhRFF2NGVGWThFWkVyQjJtSjVTRG00WVRDcXJV?= =?utf-8?B?NWZTaUNaU0k5UEJBT2tjWmlTc29UditKN2JoNXlYY3lwVHBCVWoxT3dPNllr?= =?utf-8?B?eXMzc0hJVzlRWnRKeWNLcllCaGUzMlVMb0tLbW1zMjFEbWNLUkw5bEt5ZkVB?= =?utf-8?B?Q2lBaFFiNWFjaE5MTmhlS3B5TUtSaUkwd0hDaHRHdXdFVlAzeFVkVHlKSDM2?= =?utf-8?B?cStNZ084TzdwWEtjZHRlcEMzRWN6NjVydmZhNWxOTzF3cG9Fd0NhQ2d4eGRm?= =?utf-8?B?azgxZkNiTm92SklqR045WE55dUJlUHQyK2ZHTXNFYlhEd2wzN2Z5RGtIQ1Mx?= =?utf-8?B?R2h1aWJSRnM5bFZTTGd0STlVMWgvRjJFNU8xY0hMZTgzdDFNaGtUTTdqRE54?= =?utf-8?B?TllaQWdCR1JHWXF5bTI4UDhncXlLUGd2djUyZ0p1QXpmSFh5K09MVjlRUVdq?= =?utf-8?B?WTJMSGZBS1hyOGR1UkVwTitWMjFYMjhSSXNNcU1qUWtUalZ2TndwRzhjaUdl?= =?utf-8?B?ZklPMW1xTjY4UVNVYThIUkRUMlpySkpyd2xaQzBqbzRLaUpzeWtDK21MU211?= =?utf-8?B?ZUh4Qmc0RWhvMHZSb2RZcXhKMTFwenhpcmlvU01XalNqTGdNNzhhTExFQWNj?= =?utf-8?B?b0E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5f9178a-7e4a-40b5-02f6-08daa2d63313 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 11:23:29.2587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /bTZHx/dJwaGNfd1dJfS162Tu9AoM+wtESae8/NErZpruef4ZProx7REO65doOyibvgfMm+wxJCzbZaZJc0Oeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5229 On Thu, Sep 29, 2022 at 05:25:29PM +0100, Andrew Cooper wrote: > On 29/09/2022 17:22, osstest service owner wrote: > > flight 173362 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/173362/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > build-arm64-xsm 6 xen-build fail REGR. vs. 173347 > > arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access': > arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of > 'iomem_deny_access' discards 'const' qualifier from pointer target type > [-Werror=discarded-qualifiers] >          rc = iomem_deny_access(d, mfn, mfn + nr); >                                 ^ > In file included from arch/arm/gic-v3-its.c:24: > ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but > argument is of type 'const struct domain *' >  static inline int iomem_deny_access(struct domain *d, unsigned long s, >                                      ~~~~~~~~~~~~~~~^ > cc1: all warnings being treated as errors Hm, sorry. I've tested on gitlab but seems like I didn't hit that combination. Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:25:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:25:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414160.658289 (Exim 4.92) (envelope-from ) id 1oeE8x-0006yp-VF; Fri, 30 Sep 2022 11:25:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414160.658289; Fri, 30 Sep 2022 11:25:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE8x-0006yi-SB; Fri, 30 Sep 2022 11:25:23 +0000 Received: by outflank-mailman (input) for mailman id 414160; Fri, 30 Sep 2022 11:25:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE8x-0006ya-3M for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:25:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f3ae2b6-40b2-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 13:25:20 +0200 (CEST) Received: from mail-sn1anam02lp2042.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 07:25:15 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6652.namprd03.prod.outlook.com (2603:10b6:303:12f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 11:25:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 11:25:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f3ae2b6-40b2-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664537120; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=u4hVsaWZGVndS8Y965KFmTSBHmyhvKBwGtz1v68xNPI=; b=gufcfH8MRt17lAaH4Mc+CpFU31FRXjNNbrnzXZ3f29gs6cxnCUhLgSLv pW+ZSfPxfsC/ArYSkKlDxMUJG1JGhUYUQTEJdG2quiku1OJd4F/bbcTUc lojo13MaRZrMNz/gnsSpzgxTqF0kmaW9iO7Vp+ExLSNGA902oFrRlILd5 0=; X-IronPort-RemoteIP: 104.47.57.42 X-IronPort-MID: 81687832 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:URCcv6JRctZ/BbC/FE+RKJQlxSXFcZb7ZxGr2PjKsXjdYENS0GBTy 2QZDDuFbq6MYzSkedEgbN7loU0BupLWx9QxTAtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj42tA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbEY+71NEV1fz OJGBA8ITiK9renx5q3uH4GAhux7RCXqFKU2nyk6iAr/VLMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T+fBfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2iL12L+QzXihMG4UPJO+z/wpvm+i/GIaMRZGaGCl4um7smfrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBByFrsbCTYWKQ8PGTtzzaETMOMWYIaCsATA0Ey9ruuoc+ilTIVNkLOLGxps34H3f32 T/ihCQzgrQ7jMgV1r6691TKnzKtoJfSSgc/oA7QWwqNzg5/fp/jWIWu5nDS9/MGJ4GcJmRtp 1ABksmaqfsIVJiLnSnVGuEVRun1vbCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC KPOhT5sCFZoFCPCRcdKj0iZV6zGEYCI+QzZa83p IronPort-HdrOrdr: A9a23:vKA4cKBWNE4nq8TlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81687832" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OEFbQJUMhGBdYvcCteJ35gkzmXv8PrG6K/E5KXW02LHmGd0q0OCvphW63A1hSjFmnjEPFW7vBGgW+I0+WVvUbAcmbgeZXvWp4d5I1GVwR1ReAqrVMb0hE5SO5hoHQsTXC4e5NYdZXjswWn/I5eDt7EaU39xHV5R9zvM2ryFt3OOYRaEJ+f/VkmqIvrCzF9NU/EVUvkMok7Hq0fVpuc1G77XlK/+306hQfJfvmg+MNIT3DLlT5dOd3LTssJIP0r03j3j0oE5I4ugSmseoj2LIuCUC5zBIktEOEp1HWv4bvd3q23sk1d4GMndMPkXkmgT510VY+McRGSWhkkXyY26P+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u4hVsaWZGVndS8Y965KFmTSBHmyhvKBwGtz1v68xNPI=; b=HM1/n8b7ERoUsdoc5PJKJchUpzGPxk2cZzU2cKPBgwKRC/Q4JixvT4iRnnKrZlOOuevSkq9l2jDDgfV6IipHE9f3X1Jfi+vRY/mH8sgGrCovHCY5X6ZJmq9gv5puBE4U8bIoPr0y9adUx6rhnBWae5UaIxui3l2ruKkD8aOQQ7IBOp8XoUSUWIEQOr45r/31v7GlnzmH7F3Qhw1c9N8amkKxWNL9gMk7npiSW1R/zI+h2x6Ke/+SQnHYZotfUFhv4mp8PsQ0pLqFPhImLwH3KW+gvhqfhkdwv8wOgheDntvl/ZMsJp0m84lE2A0imvCzuBRhDpoRPY0bPuJE/Fg/mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u4hVsaWZGVndS8Y965KFmTSBHmyhvKBwGtz1v68xNPI=; b=WTWNJF3qogOKiEt1ItlmDUfslOlHrjNpHNXaVOB2PsSPx2ZVvh1jSfPxQLNS2iBScaCHjyB1If4XNKEq4RANrBUrMojoRopaWPPO2NYmKTB5Mejdw4iditJzm/9phIshbl8E8tTRZhgD5RmF28TWzdZeGzYFEe89XeTrYg6XbgI= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau Monne , Demi Marie Obenour , Henry Wang Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode Thread-Topic: [PATCH for-4.17?] x86: support data operand independent timing mode Thread-Index: AQHYyOqg1ICCMP96kUmBwLmrDRKGKa337MYA Date: Fri, 30 Sep 2022 11:25:12 +0000 Message-ID: <8f07c532-e742-fa02-27ee-b08c56299d09@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6652:EE_ x-ms-office365-filtering-correlation-id: 6735e46b-4c60-4b31-d800-08daa2d670c1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P/LSBn8/rFYm51gbItN6+teEfdCqkpWQosWT274YoZZn2n7f6DWUFfyGDQLOvy0CqosSJfoBxyPwXO43+QFkCU6dmsXErx6lZ/QZJ7CAFvSk1jzNBZsU+A+xbTrs7aAzZxaYNcuTjK6TXGZLrNxnq0O2PGv38C54Y6zES0K8tcoVUJgtF8KhJS6N6Pj12tIi35CmIFWSuCSAKaOVMPyieYCDsxuqQu5jVhPZds91nFhbuo/U40RInoxNQCiR5edvbFhtXW2h0DtDYQw5dldBYgOq8LpKhcIVKi+tfKXxC1T2mkLgSBWmRV7oglXuNDXTzzldxaUN7SwTUKY1mpNK7fsB5lC65718E6uCr/wBtOBha5VGGReSr3CQkV7USWzwfZgzGezp+dpYZiP6ZFKFOE+eRVSaryJdVAPp6D0LBy1L/qB2fif1p9/9OxAmfmCN2sZ8ZdoLOYCTtK8PRtnyNA32BS3wPABcJAT18+FomLoAAZ+Tp68E6oYPHHaoBQfsFVpANe/sJGltYLsqKGT65rugqmcDxC4XzmMQJiIsnYjfz1pQ8gsffr/qdXFzaT8oh1MHiciN+gwH+G+nHlmIX1HSGU2+t9SsDxo18+KXwvmZ9yhNuEHnh3hZGlQhryWPE9Zfi568oYxMLJl4wr1emZTFBfOwJeTOIrePCjIPdf4KaINVg+Tm924lGlYMqFILBWhVy6Xnysvohjkilf+O2DsPFqI/qsX3f+XrKEqia5RJHMQscICHegKK7Pw5QsG0UnZxd+DoLjapCfY0bgUbvdomM0ZuH7elM1WA0DvKcd3IU2VD+a2mPBXDIchGRTLBVB9hKaak3usYNVTO69IgPAL0Yhgp3YgUSV/yrF1uTVU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199015)(66476007)(41300700001)(83380400001)(82960400001)(8676002)(66446008)(66946007)(64756008)(76116006)(66556008)(91956017)(4326008)(5660300002)(36756003)(8936002)(38070700005)(71200400001)(53546011)(6506007)(31696002)(186003)(6512007)(26005)(966005)(6486002)(478600001)(86362001)(2616005)(316002)(31686004)(122000001)(38100700002)(2906002)(110136005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YmFVd3FHQTlpbW9sR29PYnZMRE40REIxMUdLZzB0NkljZFI3dytCY3llODlw?= =?utf-8?B?QUk3cGdRUHplc2xOMnorUVVzdUVVc2RVMVBIWjA4NEE1Lzg3MzNnSXVUT0ZP?= =?utf-8?B?bGVqZG90RnYrc213U205SEc4YmJzZDFNOTRDaXJucks3V3Rjb1BLKzhzcjgv?= =?utf-8?B?SytDY1lWa3RKM0JJc21KNHVwK1ZaUEYzL0JHeStWYVZQVEpGRlVSeG5ya3VK?= =?utf-8?B?SmsvTFFmWWtnSC83NjlITVRxN1RheWczZFhaWFFpZVd3OUF4b0xqd0lVOXEw?= =?utf-8?B?b2xtcGFtVklITnpBUE55Nk5ub29EbUVna3RwY1dVWXQ5WmJndEZ2WFg5T1Yw?= =?utf-8?B?M09hMkJ6b1FzQi90WjZUa3JaMjY1NzlUcFRXcHNaVjRpcVZ1Mk5EdW9oL05x?= =?utf-8?B?bFJvMWY0Zlh0b2Q0ZllBNUZjeVFDU2lISnZUMXF4Mm9qT2RhZ0JwVzdscWtu?= =?utf-8?B?dXlMN0FFZHhpUFM3OFhsN3VhU3hVcDJzVzB2dnh1K0FieWhGQkVhU0VEQ1lj?= =?utf-8?B?Q1pvV2dpd0hEdjIwQTNaVkxzaUoxYW9NV294MFplMk0zdlZYNTZNY2RCdjcv?= =?utf-8?B?ajlQNjYxd1oyYXdqRytJcVNlOTdwS3U0WVl5OStaKy83NFA1aDZEbG5qSXV6?= =?utf-8?B?SHpwMTA1a2ZsT2dMa1ZrdDg3N2tBcWg4Ui9xS25Db0NEUHpWUFh2SW9rd05C?= =?utf-8?B?WVVQbHFJZkFPcW5ocUxISGtwaFlzQXEyQlcwSUFaaXNZWEFnc2RhaG9RSzB4?= =?utf-8?B?YiszNUlMaGxRaUFUV3h6cGJkUkJncm53T3VYb1JXOStNRFA3enFFc0pTbDNq?= =?utf-8?B?Y0NoREFNRU9jbkJyTk51S3QwWFpoUkNEVUxkcVhQdHhaRHFxdmRqTm9Jc3FS?= =?utf-8?B?d3BPNjFuQVF6VVptbnJsK0QzK092emxjdml2a0NoMFlnYzFaejkyMmw4SVR6?= =?utf-8?B?d1Jsd0hNQkl0M1ovVVExdjcrRnh2WGhKS05pVHBST3lOSWtHZzd4SmhCdzVB?= =?utf-8?B?K2I3d0FNcC9Ddm5mQnJGbU5CZXZJbFovY0h5VDdHYWxtdy90WWNuc2g5NjRo?= =?utf-8?B?K0lSSlcrbUJGNjh0UUp1eHMxUGgyU1NUMVRWYks3MUYvcmdaTTYyMmIwVU9B?= =?utf-8?B?WTQ1YjZsZElabEdFcTlKTHVORUxjTktFL2VtVms1WExLY1NRSVEwQUNqZlNU?= =?utf-8?B?RFhMblpHeFp2MTZLR3dJV0hlNkxtOXQ4UWhJRlpRVDJHcE16TEhWZW1SWHpj?= =?utf-8?B?d1JibzE1SEhkODFlbDNwOUl1dGtBSFVLMnRmekVXSnFrSDI3d1MvSHIvZ2kx?= =?utf-8?B?M0RRRDF3S1BrdVBFMmcwQm9GUEFZaFJWamZzRmdVb0pRcnBOL25UVnBEdXp3?= =?utf-8?B?OHRLZnRwaGpTUGNuWjBCZTQ4dW5kSHh0TE9nazE2WXROTm1NdmlwMlBMWjBq?= =?utf-8?B?eGVkRy9PRXZYUlVtUlVCd3VmRTNBUzY3dEs5UkVzRlVFUXN4T1pPaDdnNUU0?= =?utf-8?B?STd1L0prb2pIdERaY3lXWU1FcGVuQ09XZzZDWVJlY1Roam15SW44b1NvRGpU?= =?utf-8?B?VGtSUTRRY05OYndXeXhMS2NnLzMwdzdBVXJOUkc3V3R0aHROLytVSnF2SzFO?= =?utf-8?B?YldBemxPN0JzU0J1T3BYekhPK3YzSFQrNjZYWFdscUx0UlpXclE3TjVxOEZn?= =?utf-8?B?cWlrbTI0VzB3VE1IcDJiOTVJaEJVczdXVWFaSTFtaFFBMnBNL25vNXQ4VVBt?= =?utf-8?B?YktiRitLUE5jK0JRVW1FUjVzMGlXNk50TDhlWWJaOXJkcUljRDdYRjJtSFVD?= =?utf-8?B?ZEJVQmRYbUprNGZwSk9ZbzgzWE10MUwySENLTmgrSEZRSVVQem9pUnhPM0c3?= =?utf-8?B?RWJNQ0xpT0o4K3UzalBTcCtLbDdrYzJiWG0yZkhWQ2R1dnE4TnJqNHl6N3kw?= =?utf-8?B?V054cTZTaU5nd2dkZzdraFJRRDkvTHMxK1Z5YWEwR251eXd0cThReGVmTmt2?= =?utf-8?B?Tm4vTGdvdEE3eC9pdks5R2JRekNsQ1h1WDVQN3RkaWpCOU9CYjVUbTdyVlh3?= =?utf-8?B?SkhsRG5mRVlnZkZBelNpMHYyTUxrRWYzTTR6aFlqQkZnWlFNL3lGdGZlV1Ez?= =?utf-8?Q?SbWANKgIm6zOCJI7jTcyf4VY0?= Content-Type: text/plain; charset="utf-8" Content-ID: <6F2F245944539E4FB19CA548858A3EBD@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6735e46b-4c60-4b31-d800-08daa2d670c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 11:25:12.4486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 07bEuQpQEXJP1pr7hqmcEgB4Q1ofbgPOBXwo1zstkTU2q8g0ctxs/Rup9MXnM0yZEPhrtezmsXfdo4KuHLJFHM2PxY+5HoJI0YUNZ8yEn3o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6652 T24gMTUvMDkvMjAyMiAxMTowNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFsxXSBzcGVjaWZpZXMg YSBsb25nIGxpc3Qgb2YgaW5zdHJ1Y3Rpb25zIHdoaWNoIGFyZSBpbnRlbmRlZCB0byBleGhpYml0 DQo+IHRpbWluZyBiZWhhdmlvciBpbmRlcGVuZGVudCBvZiB0aGUgZGF0YSB0aGV5IG9wZXJhdGUg b24uIE9uIGNlcnRhaW4NCj4gaGFyZHdhcmUgdGhpcyBpbmRlcGVuZGVuY2UgaXMgb3B0aW9uYWws IGNvbnRyb2xsZWQgYnkgYSBiaXQgaW4gYSBuZXcNCj4gTVNSLiBQcm92aWRlIGEgY29tbWFuZCBs aW5lIG9wdGlvbiB0byBjb250cm9sIHRoZSBtb2RlIFhlbiBhbmQgaXRzDQo+IGd1ZXN0cyBhcmUg dG8gb3BlcmF0ZSBpbiwgd2l0aCBhIGJ1aWxkIHRpbWUgY29udHJvbCBvdmVyIHRoZSBkZWZhdWx0 Lg0KPiBMb25nZXIgdGVybSB3ZSBtYXkgd2FudCB0byBhbGxvdyBndWVzdHMgdG8gY29udHJvbCB0 aGlzLg0KPg0KPiBTaW5jZSBBcm02NCBzdXBwb3NlZGx5IGFsc28gaGFzIHN1Y2ggYSBjb250cm9s LCBwdXQgY29tbWFuZCBsaW5lIG9wdGlvbg0KPiBhbmQgS2NvbmZpZyBjb250cm9sIGluIGNvbW1v biBmaWxlcy4NCj4NCj4gWzFdIGh0dHBzOi8vd3d3LmludGVsLmNvbS9jb250ZW50L3d3dy91cy9l bi9kZXZlbG9wZXIvYXJ0aWNsZXMvdGVjaG5pY2FsL3NvZnR3YXJlLXNlY3VyaXR5LWd1aWRhbmNl L2Jlc3QtcHJhY3RpY2VzL2RhdGEtb3BlcmFuZC1pbmRlcGVuZGVudC10aW1pbmctaXNhLWd1aWRh bmNlLmh0bWwNCj4NCj4gUmVxdWVzdGVkLWJ5OiBEZW1pIE1hcmllIE9iZW5vdXIgPGRlbWlAaW52 aXNpYmxldGhpbmdzbGFiLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPg0KDQpUaGlzIHBhdGNoIHNob3VsZCBub3QgYmUgdGFrZW47IGF0IGxlYXN0 IG5vdCBpbiB0aGlzIGZvcm0uwqAgVGhlIHdob2xlDQpET0lUTSBpbmZyYXN0cnVjdHVyZSBpcyBj dXJyZW50bHkgdW5kZXIgYXJndW1lbnQsIGZvciBiZWluZyBpbXBvc3NpYmxlDQp0byB1c2UgYXBw cm9wcmlhdGVseS4NCg0KSSB1bmRlcnN0YW5kIHdoeSBRdWJlcyB3YW50IHRoaXMgYmxhbmtldCBz ZXQsIGJ1dCBpdCBpcyBhIHN0ZWVwIHBlbmFsdHkNCnRvIHBheTvCoCBJdCdzIG9ubHkgY29kZSB3 aGljaCBpcyBhbHJlYWR5IHdyaXR0ZW4gdHJ5aW5nIHRvIGJlIGNvbnN0YW50DQp0aW1lL2NhY2hl IHdoaWNoIGdhaW5zIGFueSBzZWN1cml0eSBmcm9tIHRoaXMuwqAgT24gY3VycmVudCBwYXJ0cywg dXNpbmcNClNTQkQgaGFzIHRoZSBzYW1lIGJlaGF2aW91ciwgYnV0IHRoaXMgaXNuJ3QgZXhwZWN0 ZWQgdG8gcmVtYWluIHRydWUgaW4NCnRoZSBmdXR1cmUuDQoNCkZvcmNpbmcgaXQgb24gYmVoaW5k IHRoZSBiYWNrIG9mIGEgVk0gaXMgbXV0dWFsbHkgZXhjbHVzaXZlIHdpdGgNCmVudW1lcmF0aW5n IGl0IGZvciBWTXMgdG8gdXNlIGF0IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZSB3aGVuIHdlIGhh dmUNCnRoZSBjYXBhYmlsaXR5IHRvLsKgIGkuZS4gc3BlY2lmaWNhbGx5LCB5b3UgYXJlIG5vdCBh YmxlIHRvIG1haW50YWluIHRoZQ0KQUJJL0FQSSBpbiB0aGlzIHBhdGNoIGluIHRoZSBmdXR1cmUu DQoNCklmIHdlIGRvIG1vdmUgZm9yd2FyZCB3aXRoIHNvbWV0aGluZyBsaWtlIHRoaXMgKHVuZGVy IHRoZSBzdHJpY3QNCnVuZGVyc3RhbmRpbmcgdGhhdCB0aGUgYmVoYXZpb3VyIGlzIGdvaW5nIHRv IGNoYW5nZSBpbiB0aGUgZnV0dXJlKSwgdGhlbg0KIkRJVCIgaXMgdG9vIHNob3J0IG9mIGFuIGFj cm9ueW0gdG8gdXNlLsKgIEFtb25nc3Qgb3RoZXIgdGhpbmdzLCBpdCdzIG5vdA0KImRhdGEgaW5k ZXBlbmRlbnQgdGltaW5nIjsgaXQncyAiY29udHJvbHMgZm9yIGZvcmNpbmcgLi4uIiB3aGljaCBp cw0KaW1wb3J0YW50IGJlY2F1c2UgdGhlc2UgYXJlIGdvaW5nIHRvIGJlIHZlbmRvciBzcGVjaWZp YywgaWYgZXZlbiBuZWVkZWQNCmluIHRoZSBmaXJzdCBwbGFjZS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:26:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414164.658300 (Exim 4.92) (envelope-from ) id 1oeEA1-0007Ys-9Y; Fri, 30 Sep 2022 11:26:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414164.658300; Fri, 30 Sep 2022 11:26:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEA1-0007Yl-5N; Fri, 30 Sep 2022 11:26:29 +0000 Received: by outflank-mailman (input) for mailman id 414164; Fri, 30 Sep 2022 11:26:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeE9z-0007Yc-Jh for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:26:27 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b70c2bde-40b2-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 13:26:25 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 07:26:16 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6393.namprd03.prod.outlook.com (2603:10b6:303:120::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Fri, 30 Sep 2022 11:26:14 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 11:26:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b70c2bde-40b2-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664537185; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Tt1bQpVV3h3z7//rg9HjAm52F8uM0cKBWpBVCs5ZJW0=; b=Y6zKSiSiXp9XnRo6+o2hpdfcBiXhExcVckzUXUT0zSeJvXCAjEvqPpPF HVtoCjV6b1vq3a+iVftfA4lVPKiBJ0D+80wYVJiCOVLXHYojjbZ+kLFO+ h138lmwExH3QR3q1uOwUxNSUzpERRnzuRP9oON7zEOuJ97+bffaz6GVJp s=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 84217873 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UaK/QK5sUqTWga9+8puWCwxRtCPGchMFZxGqfqrLsTDasY5as4F+v jEdWWiAbvmMNmLxeI9yOdy+pxkGvZfQzdBkHgU9rXgzHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPYwP9TlK6q4mlA7wdmPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5KBz1I6 c4UIwwWc1Oittmkh7emFPtV05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMl2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLw3LaQzXygMG4UPKWb0PEzn0XM/zI8UjhHSFeG//m/lXfrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+pQSiaPCEUKSoOYHECRA5cud37+ths1VTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPeZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:/plNIqAm5XzuKP7lHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr18jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvS/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kda11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvjklLYIk7zU9HakGOul5Dt T/Q9pVfY51P74rhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc= X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="84217873" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q3nogbHadWH9TygPO1iZsPy7/jId0l/OXIKKc6r6by4n48Gxxql5n1Dd2O4o37HrkGFT8Fom7Fx9ziOzFCMQXuwzdvzb7PD5I9nTkr0keF8N4RQv3HA5FmS8Vh+BysFKTt0fzOMUgG6mWynSchSrD9DcrWute/XrVChrXo1coeMhQJebsDEc2pJK0e4uCMmG3iVA4MygbhabbuAHGcMt4QwBL6gnPqBVa/39IOr0asAXdGgrEDWMtrbdog7h5nTYSSbw0fV1Et3C+F49wu7Q4LrqXrmYa71QIWhdgSlgshaCVyIUkE8OIuk8hhFiVDlOWHBCYU+9c9yRuSdqv6Mrlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FIVZAUxhb/UXh54YljxTBVUeQ60jqhMwKGiOgwkAB7Q=; b=c1QjcJKEcGXh7ZJvt+Ul52i/y7CemyvEEyKapQOiQdtmYPLm98eqiZk09ANpOjodQF23cxr8lZo19dqdv6DiIxNESHkfSJ9Ki2hnIfP0sKR65ls2907K1+jG4bfKEmY5H9TMcX/C9YamvLGdHSyP1mQkrFYJyQB/EXNlY6ny/EbdkgBZa9LOW0Z3CYBObwoqCZXdBbYJAV6ptR7+Cs0L/sAH8bGpm9Qi15HTBYLO5X8j58pZmFcfM40M0riy0Rj6ja/BFuuKKRhOp1n+3ZinAdDm8njqtvhUNeiG0JAisT0gZdTb2ESQk7opm0LLc/SlxD9Dq9DEMs5NqLQngrCdog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FIVZAUxhb/UXh54YljxTBVUeQ60jqhMwKGiOgwkAB7Q=; b=Om6uhJzLJ8LFt+egYGufYSZjFr18bt8xsdnZvp5cShxEIO9qqG0pRTeccMhwcvNv49Fu6DdJyceKCoVl8h3iWW86xj8NRD0enRZHZ6knGTUvMj4BvdtBBELK5oOjdeYCF/il9fnZ1ZpMXT8gxAAwCo3XAB0vZo4DOWRhqzjv9Ec= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 30 Sep 2022 13:25:29 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Message-ID: References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> X-ClientProxiedBy: LO2P265CA0222.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6393:EE_ X-MS-Office365-Filtering-Correlation-Id: 71f1fee0-85f9-4fd7-a220-08daa2d69592 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eMzc20VeAfpZpPHqXTqbKbd38H1Q6+5NtOWk6rE7Hm3aOti0wnyRtXoyQPSKAOpFX06gOR2Sm7G4Ab/RgR1zYFcgO6my0IeH9tgwjR37S3GAGKZPPbdpiwa0cb1f3WzWFuSHanI1rwzi/cRMRcaA9QRd69Q0vaXHMibukDtObDaKJIUW0XaZ88vpCwkcfp1tvfBnRMyEa2i5/UFkPMtL57AHcsbqA+Pd8Dpw/PSCIy8/J+ovHy+H0z6XKKd1Qka5xzvh2isoHuYSawRU3HVvJ82SGrL8M/vauLbjApNBQCus7MqIlgBGOFnpNFmVYFvMIpDTQqmOExRhEPkK6fcwsdnw0v8nstjQrC7bcqMwsbOaUw0xOgC8Zw06LLiE4X9FZ4CzHnAGhegH0kL1vrUzUjDsqakIVOdWL3RIcF+D1pIJkEKQiy/ABEGRkJ06JlaJ4PYP65pY0k1MiXrO0Sr23dFx3z1xDilngbA4JwW92axI5o/6hXgQDX9yydf87v3/WxfNwYc/roz4Ea5DmxQt8Dr8ler8reaaDm1GRD/+mBDt2VdcZAMj6jH/w9ypC9WKme0Vvx3ZoIal4VtsVpJUxTqqxNgMepvpinI54LOrLytoAiBRE3aHsx0tY9Bs9aGoL+gWPvBVtmmDrp9IG24oCDbT3QgqrnpRbxDly++3IFMJWW6HnvdgPL+XYg6gEHey3zL1VTx4mM9xjqVuolJDIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(6666004)(54906003)(9686003)(86362001)(38100700002)(6486002)(316002)(41300700001)(8936002)(83380400001)(4326008)(85182001)(26005)(6916009)(66946007)(186003)(5660300002)(6506007)(6512007)(4744005)(478600001)(82960400001)(2906002)(8676002)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEJQRU4rOWwxNW94ZUVETlowSzRNZW5mNlluR2ZPZlo1dUk4K1VFekZLODYy?= =?utf-8?B?cTlFWC9WbWY0dlZOYy9HMjl5VzBlSFJSUkpoNVpsVkFWSFZuajAxc3lRem0v?= =?utf-8?B?bzZJblN5dUh4WVY0bHdudkpVL0s3aGpMT1YxN2wrRlNjN2hPOEQxUnpoNGtU?= =?utf-8?B?QmE0bVBnVUsvY2tYb3pHYW1uWkFqUldMY0xnTVFYdzI4cnI0MmdmNGpYVUV4?= =?utf-8?B?WEZDRXNVSDBHcE8vcTJhUTVvNUFtaGRlaDhKcWp2VllNZ0FEd2NIbG4zeWI0?= =?utf-8?B?VHlseUova3FmVll3OUh5Q1BtYlJvcEpkSFFaRXRsbXBVWUtycndpUnQ2aU9p?= =?utf-8?B?NzEvWDlTMzRzSkx2bHM4VjIwTEFueEVkQTJ0VEljQ3p2emNqRXZQZWd0WEFs?= =?utf-8?B?U1BRUWEzOFplMVh2VTdURFJBcmRUZVpHcWNya2hjdGZBbFFhN0s3M3VWdzVh?= =?utf-8?B?VHVQZWw3Wmxnc1kxY2laSHQwRlo1Z1NQMkgzNWxmWWppUk1reXkrWkxVNzdQ?= =?utf-8?B?YkVyQk5UejZ6RjlrOUF2dzErSnJyRzc5TXR4VGZiM1RDVFZmSE8xbDRjTEFx?= =?utf-8?B?UW9UaVpGbnFaTS9NamowQUowZjdFVGsrVG9NTy9iV3NCMEJ3WlhTQ25QalQx?= =?utf-8?B?dVRDZFZlMUxKNWg3aFRYcWRZY05XWDZSRXBnek9GYjJ5b04rdldvNmRTRlJy?= =?utf-8?B?S0VlRFdYUVJNdGh2eHJacHVXT1E3V04vOFVyeHcrRTh2S1FkbjVZeG84VWtB?= =?utf-8?B?dnFqTGkrQWE3OUx0SXFmeHN5cXhFaWZwZHo0cjhoRHdYQVh3aFUvMGZVQStG?= =?utf-8?B?THZ3MnJjcVlENHBYWTVhemdvRkNhdzVJano1b09NbDlhVkEzOXg2MWVKUTNO?= =?utf-8?B?dVB3Z3FmWEU3SXZMbVNvVm9UMmY5R1dYSkVrNGtIZWZnVzRDQVp1WGdaREtv?= =?utf-8?B?TDN5dllsS3l6MnpvcDhkbzBKMExyMmhzK1dGU3R4TXRMNDRVK0ZLSURETjJB?= =?utf-8?B?UzFPMDdyWC9wTlYvNUJ2S1plcUxxSmxkWWlEWTF1ZWxuTDFBdkNsOUhMT2pL?= =?utf-8?B?Qm9La21kaTV6WjVxL3YySGUyUnNyRnJMdlEwWlhvZVFoNDdHYlFlQ0NCNEo5?= =?utf-8?B?R3pTakxmZHNicGYzQ3NVNEF0V1I4RFRqUStqVDErVXBldkhaWjE1cGt0a2tN?= =?utf-8?B?ZHZtVkxIbzlyOWZCSkQxR25reDMwUnVEMVdxc215cllHejJ1RFpNYytFSDJG?= =?utf-8?B?SndvQzd1alJkbjdrUGtORGZpVjhVVXpwVkZIaDFzdkJvYlh5QVNSemxuak5D?= =?utf-8?B?RWxTZytCYytjRWFmN0NSOWhueDNxZUtjZ3Vmb2xOMDN5Si8rVzFtcDBscU9U?= =?utf-8?B?ZG5TdjJuVUowc3Nndzl1Mk14MjNMaitYNy9wdjV3V2hSR2w3blFmT21LcFF4?= =?utf-8?B?N0o5Y25UWFRiUyt1TldBMXFLOHZ0VzZ3eXowVjIybG9iSHl6RUkydzhxMUV6?= =?utf-8?B?Z2cvWG1WVitPTExQQndMNVZ0R2c2ek5Vd1BjcHFDbDBtYWsyTUsvbjdLeTZa?= =?utf-8?B?N1pIY242TmVDRU1Qd1VhSDVCczFqUW55NXJiWjFjaHphSmtRN01vSEQ3U0xY?= =?utf-8?B?NFJWb1YyWTE1dXZRcnIxdktxZ2FzZE9CdTdaR1p5MnBHYnowK0xGcERsKzla?= =?utf-8?B?RUtJQkJxaVFUbVBUMFdURzBoK2xNMHRIUUJ3T0RyRk14dU52VkZ6djRRVkNm?= =?utf-8?B?YmlGSVFoYlZ3dlFFM1pXeE1Cd29vV09lNHJWcDUraFQ5cGhEZ2NIUXJZUFBC?= =?utf-8?B?WVF1R05DdW9raXVYb3dhMktrMkNZOFlKclllZFBFd2x6ZG5RUG9YaWFFME5F?= =?utf-8?B?YzJITW8xcEN6RnFKNUVrRTc2d05QVE1YM3BoS2x4T1BsZHdSWmIyVUVoQytn?= =?utf-8?B?OFFZcThJckRleEJwVlhCK3d6UVRyS2FOTjRja1JoVjVwVDNPK2l4TlpJY0Fo?= =?utf-8?B?MGRFajVIMWh0bG14QUFjVlBjdVRQQSs0S1ZoY3dTdzd4MW9jUkQwYXAvOWpN?= =?utf-8?B?dnBYZWtEcFFXZms0eGZXVzBpVEhBQlc5ZEsxL1hMbTN3dzlpdW1CU0xLT1p5?= =?utf-8?B?K3ZsRExIUGNxT3dqSzJRT1NubHdFcVZFR1plbGlDSlk1Zkg4c3R1cC9YRjRi?= =?utf-8?B?SXc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71f1fee0-85f9-4fd7-a220-08daa2d69592 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 11:26:14.4024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kJjvWVuxSuZxiFdw4r/p/Vvb7Q5XcJTZeWNLpyLXCWErxb2V8MAeeDPHng1Drq5xeQ0r90KP4lDIR1EUVjXcVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6393 On Tue, Sep 27, 2022 at 06:20:35PM +0200, Jan Beulich wrote: > SRAT may describe individual nodes using multiple ranges. When they're > adjacent (with or without a gap in between), only the start of the first > such range actually needs accounting for. Furthermore the very first > range doesn't need considering of its start address at all, as it's fine > to associate all lower addresses (with no memory) with that same node. > For this to work, the array of ranges needs to be sorted by address - > adjust logic accordingly in acpi_numa_memory_affinity_init(). > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:55:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:55:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414176.658311 (Exim 4.92) (envelope-from ) id 1oeEbf-0002qa-L0; Fri, 30 Sep 2022 11:55:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414176.658311; Fri, 30 Sep 2022 11:55:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEbf-0002qT-Hs; Fri, 30 Sep 2022 11:55:03 +0000 Received: by outflank-mailman (input) for mailman id 414176; Fri, 30 Sep 2022 11:55:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEbe-0002qN-6A for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:55:02 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4f130eb-40b6-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 13:54:59 +0200 (CEST) Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 07:54:52 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5102.namprd03.prod.outlook.com (2603:10b6:208:1ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 11:54:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 11:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4f130eb-40b6-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664538899; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=8YYF/cnDZqENZwZKC0XF58Oanh/6Pdqhed9NsNBsj04=; b=XRvH5DIwuFdEGuYAT+35z/R2hlqaVxtWA7B+Ejc+NTORRQZMf1a7m51y 2ES7u3nl/ZdhPHkX79e0zwb+l7dhl4ADscdGZ924doDqTbGg6C34b2ov2 5OoNaoh2k8jQPHA1/5Y1B+ZuMYTTkcHVMgA8POWyRKlu2lGxc28zEFRC6 k=; X-IronPort-RemoteIP: 104.47.55.103 X-IronPort-MID: 81352186 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5wbYuK5NG9dZ08cUEO3JtgxRtB7GchMFZxGqfqrLsTDasY5as4F+v mAYCj/UPfaINzbxe9h0boy+phkPup/Wyt9iG1drq3tkHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPYwP9TlK6q4mlA7wdmPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5qWiJQy 6MXMgtTawzev/71xZmkb8Vj05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLl2Sd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzXqgBdhLROPQGvhCgh6a6TcxJ0ctf3ySodiBsFOeXIoYN BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACA4aud/qpdhrigqVF444VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTxgbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:vYNqP6jquAoKSQ6VbxMRtT4TY3BQX3l13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+ O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv fbAuMlP8Pe X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81352186" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ngy22XyzvK9eZZG0QekNFveK6INVQS4Bo/6oEPeU/0I8S0j3KMdOHrQwDVZ40TSYPVt5KQyh1+bbA80nrSyr31G2ntpyWMWBgJp2jFR5mUIO7420Q7lUOz/Zx/dWE5df/MRzqHincij5W470NLi+xGSFxBa6G88fLFBlRVcCACdMFZK7xz94V4w+g+5m/TPzK5mArU0RsoilMZts5Slv2C1vHzM3K/xRJUv1iX34opvVnRNbeUe72HpiU04DtVo2DRxKasJRR738Ln+j3n6KVn6AmU4yb6/bsrAvwm3i9NvgnjPsEr92aGjdRagVGNx+Mqmc3UP1ZevDrMV6AchROA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8YYF/cnDZqENZwZKC0XF58Oanh/6Pdqhed9NsNBsj04=; b=fO/OaoSucwEcNUWyrMjuawSJQMGYExhdx+BIxuT1MeIc1z0r368/RUd5FHhnSlPWssrxuYDyFKJ8IwOOlfwiEzmmEjSipXBqqeffIXtD0wH0JyVO3s0WDYJD5ruI3VHw30oQ+kIPyDJ+nVs+00fcJNRNH4+HQ/XncL/PHu+TBhCSNxYq0YxL6uf/WSc42i0HvTYB1ztF5Oe6zwfLKepdOBVWtL8QWJ0MiONnsFTCWnme2IpEO7SSysyWkR0up/aD7E401lT7Y3a6zxqDmpTbn9M4eWwYSYGidc+s2l6mQHHNj2KlMT3DbDFNgTVz4sXpso2JGwpH9xTXEABI/6U0mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8YYF/cnDZqENZwZKC0XF58Oanh/6Pdqhed9NsNBsj04=; b=Y0IDtsjTL01aRX+3mPYZPYRbzGOL5nSG+eefRTmDqq0lVDtTqqb5tZaU9O5QDW5RFTXKV3MQOv+95M2mxqkW/lZ3XboqzQMzeC+cIxHpWIqgvQX9igKD7WafycHeOg5Qy+nykwtCySo8GzowJHNXUvw/2CoElVA87xnSK5i7ZoY= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Thread-Topic: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Thread-Index: AQHY0o0ZBOomZIkt5kiwNmpgdKrIoa334ciA Date: Fri, 30 Sep 2022 11:54:49 +0000 Message-ID: <21e773a0-9082-86de-be81-9fcc8ea2e07e@citrix.com> References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> In-Reply-To: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5102:EE_ x-ms-office365-filtering-correlation-id: 47b9895c-8469-427c-61ec-08daa2da93df x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9/VnU0zbCAHub2jsMf+zvOMlUf6f1BdPZoNpPzmtzi4x01lxSTmEH3ttqffz6yPSrjRlnHsf4uVK0WobIjthWdq9US6CoG6bQkE6xfuhYpmwPb2Pozo1+abOw3nW1yaUFrVuiuYhDp+tnKgNWhxqObvBDLmSFip18HdZQvaHcoij3A+Cp3Cyccwcb3GGAD2B10UpEkO6NKcNmRlqendENUfqXN8g4m++ik/M1GzoHeBvrNQ6UILeCsogiAn1tEZNgl7vpXJyKowfgOhFq2AHOjF7Kp5yi60kwLUHwROMKW85G6+y4Pb4I4rCKnb8zmaAjRN3Aq/Gd7iCjTV5m+h6KZcShhB+r3qDMxAg+I4+n46hbMXCD/K9IEcHqQQP1/aWt0VbjNdENfCtHI3IuiYUxRq3Y2oQ/+nLahZpo/T2kg3fOLpIWaYXuz3q4t5BciGga6gxjm/e5d1ru/naUaGBwsDzkL5VrU+IXOaIwoW1FdS2ceuWAMra8SrOh4Gf0djB7hhC7VyGn5mlGVm/s+LiXN2uP/bAVhc/6rJxla13e6g/JplwJR3XEtEnkORsTMZmB8bG/gq23COUoHNUYxxuOv6dTUCeWxWiDmpk+RVLk+dIEEaN/2W0fNyimRNaSCeJuwAQQv6OZZCJb1VVxJDWw8Q3Pbd8W4k5BHu4vvXAK17HpirafgnwAwAqTiAhnEwCW0/kSEQVC+KdETgK9kBtxS0OO5NHLhezNYAeJ2y4bGhcOQnfdg/zoLc8g+UngfUh7u245ehiSgAnejxJsBKD40GJEPlA2awzJSan32dxvNlVBbOnNl1q7jNAi5jYoAAj23jUQjHUSyD9gSOodanB3w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199015)(83380400001)(82960400001)(110136005)(122000001)(91956017)(6486002)(478600001)(2906002)(76116006)(66476007)(4326008)(64756008)(66446008)(66556008)(66946007)(8936002)(107886003)(6506007)(41300700001)(53546011)(316002)(54906003)(8676002)(36756003)(26005)(6512007)(31696002)(86362001)(5660300002)(186003)(31686004)(71200400001)(38100700002)(38070700005)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UjN1UGwxV3pPVndPMWpQdEx2aTVjRzUvdy82YWJLV0dENi8rVk43dE02NlpK?= =?utf-8?B?clEzMHVaRWNZWUluRkhZMm83UjczSVlFVlRvRUE5dktOa3MwNXdIVzA0ZDBT?= =?utf-8?B?bzAzNWNmZHh6TDc0ZjBjWmtSOGpMbjZocGxVaW9DaFE2WXl3VHdqZXB0N3dv?= =?utf-8?B?RjU3dWgzcUZocm92VFRGSzh6NjhrU0xxZ0FUbFBCLzlVR0drSTRld1VHcCtY?= =?utf-8?B?NHlOWGdSY1BJdUpPc3ozeG5waFZKRlVLSFZJb2dTbWNaUjd0RjlZT1RxbTJt?= =?utf-8?B?WnMyY1lITThENkN6VWRqTG1wN095LzZHdWxiWUVRakV3STlHajBsYXlyWmMr?= =?utf-8?B?VDJ5TnU5RGE2cStvMXQ4ZUxZN3pTNUhzUUFaZmRMNmlZZG52ODBnRE9qcVBw?= =?utf-8?B?WThnN0swTi82Z1Z1STB1dERNeDNKbGtzSUdJQmVvc2xDZHFhN2dXQlprbjV4?= =?utf-8?B?WVJ3dG1LdUVKSFFlR3RjcUI0VlAySVp0YXZMSm9aZzZOeWlGdUtFdUxHcWZw?= =?utf-8?B?RjN5bGxPT1psWHdOK2ZqdW55eXArVUx4K2g2d0ZUeEFHdGVWUEU0SExzL2ZJ?= =?utf-8?B?UTBvYUZUZVYybVpSUDNiR2hPWWxiMzhNZDdmT3JoNlFnNDk4ck15VUUrNkNZ?= =?utf-8?B?cDFmR21acEFPckVtaXlucmFHdm1iTFFHSlpXQTI0Ukx6OHlhRDFRNGRjclFH?= =?utf-8?B?RkdLeG1uQ3YxU3JwUGJGTkxIN2N0WnJpTlkrWTJLSUVyclMxdkdSRGloVnM4?= =?utf-8?B?Nk9ucUZMUFd1V1htS3p5M3YrR0tFY09ZRGQ1QmRWWXFjVmR6TXFWYmRuZTdC?= =?utf-8?B?REM0YTh1UmRuNFF6Umw4SVY3WlJVSzU0a1g0TkxPWEZ5KzF3V3B3K0gyTFRt?= =?utf-8?B?enB1QzhRVVI1SkpkcUZaejlrQzB4T2ZTYnFOY0pxTjNaeTg1YUs0MStzQnpN?= =?utf-8?B?MEZHc1R3Y0daYURMM0VrWWRZTVJ1cXJLVStjejlkZVo0OEcwWFp5S3ZFWDFy?= =?utf-8?B?aUFsSGZUQzZhWlNEVkRzTWsyMDlQTndsN2lPc0ZBZ0RDZEt0NDJKT0lsd0wx?= =?utf-8?B?TlZHSWc3STlYLy8vd3BQMG1HdCt3VkxJTlFtdlQ0YU9uNnArc3JOclVUZ1p5?= =?utf-8?B?am9LNVl1OC9tMENvTi9ucnFvdEE3bkpYL1cyeXJBUEg5V2FtRDhUcmY3dURp?= =?utf-8?B?TkNBQjNMazhqNHVBdnIvR2ZWZ3pEVXpyWFRmdXNCMjVNQ1k2T0Nmc1RPdGh0?= =?utf-8?B?RWUxTkpVTUYzQWxvT3VvckdFK1FPem1PdGI4Y29Pd2g1VlZaczB2QlQ4SU10?= =?utf-8?B?SVVzT2ZwVE0wNkdUUHhqbytiNzhadDdWRkozaGpyWWE2WWMzUHFLaWs1a3RZ?= =?utf-8?B?bVdIN0VVRGF2YmhyV3M1KzIzMjluRFJxYW8wZWl4cjlEbmpiMlp2S2VXcElC?= =?utf-8?B?YlNTVk1PZXpwRTBXNS81VGVaWVNTaUV5dU5oVmpLOFAzbWI0NUNEalcxMG8w?= =?utf-8?B?M1ZvVmlkMDl0OTdNcFdjc2xEcG1yVHN5dWV3MHFsWFJEWk5Ed3pEenQwbTky?= =?utf-8?B?dEkwdTFOR000QTNCRlpEYVN6T0E5VTVoejBrNDUrdDdwdjVDdG1vSlN4b0ow?= =?utf-8?B?bjVFeFNtVzBRWFNPV0ZaSGRuYkNocUJXQ1dDNVhhVGREOExGdmE1LytDL2Iy?= =?utf-8?B?c3R6V0FDeitXT3ZlRlhuOUdwYk5XMkc5NS84UEhQVXhsdlJjSFpzMFM2MWo5?= =?utf-8?B?cHkrNmNMQjhTamZPVGFXWC9sT2VQQjY4cDljQWxNWER6dzYydkRTU0dHSTFO?= =?utf-8?B?ck1hT0NQMFZUZ0hqcHR6V0RrT2c2cElpNlE0ZHV3U1BLT29ZMmxhalJRYWFk?= =?utf-8?B?L0pGM0V6ZW1BUWhXUk9ueDVPenhBSXdKWHVkTG1qTVdHcVJRREVzMGY2SklJ?= =?utf-8?B?RlUxKzk0aThIc3I2UWlWR2xLL1V4L0o3VUYxWVdURlkvMWtrbUhJKzBnL2tM?= =?utf-8?B?em1CZWVsdEZpSWhNalVhS2loekFabERVRUZoeCtsZHVSSEV3VllOZkxyQjZi?= =?utf-8?B?OTl3VmlhSW1JNmpvRjhHYzZLUkJPZmxEcGlpckpHUVRrM3RlRXV0Y0h1dWQ2?= =?utf-8?Q?2sQyns//tGtOQ8zggbsTwGy37?= Content-Type: text/plain; charset="utf-8" Content-ID: <4D018FE1A05C10418CCD65C60D9C11E4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b9895c-8469-427c-61ec-08daa2da93df X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 11:54:49.3338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmsCfkmRsAaoEgNEmKAsbHfNxDDnCAHFsl+fpuNf72I+ofoj0WbYFJGlcJrPE1P8nlX4lW5bY1CU45v5zOSiR4tjD+824W37r8GIMlgfru4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5102 T24gMjcvMDkvMjAyMiAxNzoyMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IC0tLSBhL3hlbi9hcmNo L3g4Ni9zcmF0LmMNCj4gKysrIGIveGVuL2FyY2gveDg2L3NyYXQuYw0KPiBAQCAtNDEzLDE0ICs0 MTQsMzcgQEAgYWNwaV9udW1hX21lbW9yeV9hZmZpbml0eV9pbml0KGNvbnN0IHN0cg0KPiAgCSAg ICAgICBub2RlLCBweG0sIHN0YXJ0LCBlbmQgLSAxLA0KPiAgCSAgICAgICBtYS0+ZmxhZ3MgJiBB Q1BJX1NSQVRfTUVNX0hPVF9QTFVHR0FCTEUgPyAiIChob3RwbHVnKSIgOiAiIik7DQo+ICANCj4g LQlub2RlX21lbWJsa19yYW5nZVtudW1fbm9kZV9tZW1ibGtzXS5zdGFydCA9IHN0YXJ0Ow0KPiAt CW5vZGVfbWVtYmxrX3JhbmdlW251bV9ub2RlX21lbWJsa3NdLmVuZCA9IGVuZDsNCj4gLQltZW1i bGtfbm9kZWlkW251bV9ub2RlX21lbWJsa3NdID0gbm9kZTsNCj4gKwkvKiBLZWVwIG5vZGVfbWVt YmxrX3JhbmdlW10gc29ydGVkIGJ5IGFkZHJlc3MuICovDQo+ICsJZm9yIChpID0gMDsgaSA8IG51 bV9ub2RlX21lbWJsa3M7ICsraSkNCj4gKwkJaWYgKG5vZGVfbWVtYmxrX3JhbmdlW2ldLnN0YXJ0 ID4gc3RhcnQgfHwNCj4gKwkJICAgIChub2RlX21lbWJsa19yYW5nZVtpXS5zdGFydCA9PSBzdGFy dCAmJg0KPiArCQkgICAgIG5vZGVfbWVtYmxrX3JhbmdlW2ldLmVuZCA+IGVuZCkpDQo+ICsJCQli cmVhazsNCj4gKw0KPiArCW1lbW1vdmUoJm5vZGVfbWVtYmxrX3JhbmdlW2kgKyAxXSwgJm5vZGVf bWVtYmxrX3JhbmdlW2ldLA0KPiArCSAgICAgICAgKG51bV9ub2RlX21lbWJsa3MgLSBpKSAqIHNp emVvZigqbm9kZV9tZW1ibGtfcmFuZ2UpKTsNCj4gKwlub2RlX21lbWJsa19yYW5nZVtpXS5zdGFy dCA9IHN0YXJ0Ow0KPiArCW5vZGVfbWVtYmxrX3JhbmdlW2ldLmVuZCA9IGVuZDsNCj4gKw0KPiAr CW1lbW1vdmUoJm1lbWJsa19ub2RlaWRbaSArIDFdLCAmbWVtYmxrX25vZGVpZFtpXSwNCj4gKwkg ICAgICAgIChudW1fbm9kZV9tZW1ibGtzIC0gaSkgKiBzaXplb2YoKm1lbWJsa19ub2RlaWQpKTsN Cj4gKwltZW1ibGtfbm9kZWlkW2ldID0gbm9kZTsNCg0KVGhpcyBpcyBub3cgdGhlIDR0aCBleGFt cGxlIHdlIGhhdmUgb2YgbG9naWMgd2FudGluZyBhIHNvcnRlZCBhcnJheS7CoA0KKHR3byBleGFt cGxlcyBpbiBBUk0gY29kZSB3aGljaCB3YW50IHRvIHN3aXRjaCBhd2F5IGZyb20gdXNpbmcgc29y dCgpLA0KYW5kIHRoZSBWTVggTVNSIGxpc3RzKS4NCg0KSSB3YXMgYWxyZWFkeSBjb250ZW1wbGF0 aW5nIGRvaW5nIGEgc21hbGwgbGlicmFyeSAoc3RhdGljIGlubGluZSwgb3INCnBlcmhhcHMgZXh0 ZXJuIGlubGluZSBub3cgd2UndmUgc3RhcnRlZCB1c2luZyB0aGF0KSB0byBhYnN0cmFjdCBhd2F5 IHRoZQ0KaW5zZXJ0L2ZpbmQvZGVsZXRlIG9wZXJhdGlvbnMgYW5kIHRoZWlyIGRlY2lkZWRseSBu b24tdHJpdmlhbCBwb2ludGVyDQpvcGVyYXRpb25zLg0KDQpUaGUgc2Vjb25kYXJ5IHB1cnBvc2Ug d2FzIHRvIGJlIGFibGUgdG8gZG8gc29tZSBhY3R1YWwgdW5pdCB0ZXN0cyBvZiB0aGUNCmxpYnJh cnksIHNvIHdlIGNhbiBiZSByYXRoZXIgYmV0dGVyIGFzc3VyZWQgb2YgY29ycmVjdG5lc3MuDQoN Cg0KRm9yIHRoaXMgY2FzZSwgYW5kIHRoZSB0d28gQVJNIGNhc2VzLCB0aGUgZmlybXdhcmUgZGF0 YSBpcyBzdXBwb3NlZCB0bw0KYmUgc29ydGVkIHRvIGJlZ2luIHdpdGgsIHNvIHRoZSBzZWFyY2gt Zm9yLWluc2VydGlvbiBsb29wIHNob3VsZCBsb29rIGF0DQp0aGUgbnVtX25vZGVfbWVtYmxrcyBl bnRyeSBmaXJzdCBiZWNhdXNlIHRoZSBvdmVyd2hlbG1pbmcgY29tbW9uIGNhc2UgaXMNCnRoYXQg dGhlIGVuZCBpcyB0aGUgY29ycmVjdCBwbGFjZSB0byBwdXQgaXQuwqAgSWYgbm90LCBpdCBzaG91 bGQgYmluYXJ5DQpzZWFyY2ggYmFja3dhcmRzIHJhdGhlciB0aGFuIGRvaW5nIGEgbGluZWFyIHNl YXJjaC4NCg0KT2J2aW91c2x5IG5vdCB3b3JrIGZvciA0LjE3LCBidXQgdGhlcmUncyBhIGxvdCBv ZiB2YWx1ZSBpbiBzdWNoIGEgbGlicmFyeS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:55:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:55:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414178.658322 (Exim 4.92) (envelope-from ) id 1oeEcB-0003Il-Uf; Fri, 30 Sep 2022 11:55:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414178.658322; Fri, 30 Sep 2022 11:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEcB-0003Ie-Rz; Fri, 30 Sep 2022 11:55:35 +0000 Received: by outflank-mailman (input) for mailman id 414178; Fri, 30 Sep 2022 11:55:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEc4-0002qN-PL for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:55:33 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c598e04c-40b6-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 13:55:27 +0200 (CEST) Received: from zn.tnic (p200300ea9733e70a329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e70a:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8EAC51EC04DA; Fri, 30 Sep 2022 13:55:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c598e04c-40b6-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664538921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=gkGioLVwMetICdzznJX5cuKeLXApeRahk/YbtSiNyOU=; b=aA9q7N+ze4YFGknkpfR9jdXxBnhAVBgLCb23/0jyqrX4Kv2W199DybFAnMSyRcyvZHrvvc iot1HFSDMFiYy9cire3ECf+VUH+/aLETNsDlelNvoo00IpP3IlN+hVYO67aaAbRmog1xm0 x2D1aAtd3QHeyXZIVJHvAZbQ7tXox+c= Date: Fri, 30 Sep 2022 13:55:16 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Sep 29, 2022 at 10:26:59AM +0200, Juergen Gross wrote: > So right now I'm inclined to be better on the safe side by not adding any > cpu hotplug hook, but to use just the same "delayed AP init" flag as today, > just renaming it. This would leave the delayed MTRR/PAT init in place for > resume and kexec cases, but deferring the MTRR/PAT cleanup due to this > potential issue seems not appropriate, as the cleanup isn't changing the > behavior here. Ok, what's wrong with adding a special hotplug level just for that thing and running it very early? Practically pretty much where it was in time, in identify_secondary_cpu()? Having a special one is warranted, as you explain, I'd say. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Fri Sep 30 11:55:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 11:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414180.658333 (Exim 4.92) (envelope-from ) id 1oeEcN-0003d8-5z; Fri, 30 Sep 2022 11:55:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414180.658333; Fri, 30 Sep 2022 11:55:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEcN-0003cx-33; Fri, 30 Sep 2022 11:55:47 +0000 Received: by outflank-mailman (input) for mailman id 414180; Fri, 30 Sep 2022 11:55:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEcM-0003aL-4T for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 11:55:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d060205d-40b6-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 13:55:44 +0200 (CEST) Received: from AS8P189CA0020.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::8) by AS1PR08MB7499.eurprd08.prod.outlook.com (2603:10a6:20b:4dc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 30 Sep 2022 11:55:42 +0000 Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31f:cafe::26) by AS8P189CA0020.outlook.office365.com (2603:10a6:20b:31f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 11:55:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 11:55:41 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Fri, 30 Sep 2022 11:55:41 +0000 Received: from 8a43963fe985.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E318703-57C2-4351-BDAC-5FC3B3C059AD.1; Fri, 30 Sep 2022 11:55:29 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8a43963fe985.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 11:55:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAWPR08MB9471.eurprd08.prod.outlook.com (2603:10a6:102:2e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 11:55:26 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 11:55:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d060205d-40b6-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jArTLkhlcgQ0vfjfgK5vX0KRdL0q3b27LUMKInBe/EZ+wCTc7njQR2RMkcQG4AoNRRJEmmR6iRaXVjksqiP3MpD3y/mfFIUZc+AKoQNa3LhZhkTj8A7oWZynea0jhYPlnCGPMBAYRL1aObHaiyzPS98+QNOJ/WQJ2547X9LzmTSvvSlYAqsRgG9tGZdMi9QHwOis7shqGZgtjACHIe2q/lJd/m4u+j8VSZiDFKLaKkgeh/YJZxCfq5KA8+3k7GIyWabEBCWkbLtgnivJ45Hgy18a/UdPwaisMg5K7VuJh0hqIqzFTem2flk11+xc2QvnxqrIoJL1pGNiDLSW7IpEBQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=anL1P0itDgHK7+ScI98pOYbc099ObRlXgl+VxysqEc8=; b=SMqBIKUFrZuz1lgaDCZN5ROKeRmZ8minm/3mNtQ/qOq5mr0XmrBHkDxnQoBLUt71Opuodhkm89lqdFDLBJ0qqLS2EwnUecOwm/UQk9HjjM6LNqU7M59Eo5nxjncX5SrFKLl438q9X9m9L8OpLfc//ji8O5thNdEfktGJEjXR+FAv2nmVBsgK0x19j0TKch8xlZAu4llxVIxS3bFSjpPbtoV68HSe+s4YUgUxViOpotMs7vPx2dsi5215EHfUF6+SAL2BikQRcixco63tCZjO815lKo5/MoEYVuytpjtBwKqMnhksK+PkA1a3blUThkkcRZTdJT8Q0nILSaKIVVYKng== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=anL1P0itDgHK7+ScI98pOYbc099ObRlXgl+VxysqEc8=; b=7VaZNaAlRqB095bkEhtrFY9WqIiML1IWCBEqAbUzYsBQ8L9pjvm2q0pkSni/T8aBBom9DH66CtsmmMo4gkVvkj0pUALM7yf7EjL6Ocz20Jh3oqHc4h0+vqX+uQeSU1L50fZIxFBVt28VIkBiqEXEebnCgVSdTJ7uswrREJ0cods= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4b63e313d73a78da X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSwcUQVZq7bfKZJAasAusjHcnJwuyzuq3HW9Uh+P+w9Gf6kweEE7z5n2WE1l1bgqkJVYAvVBGSbvcAmtIgUcytsdHZM53DaCKUJFI9Irx8vlRTVMnh+K9JZzjXxB8ltSAQ7s0939Og3/Z2VtD2H5kGuen4q6iC7+UjMAi8rpCVn9WO2uKbUPuWHynJ6ir8Uc/KWWo0owA0QZeumwPK2piAN9ZUWS6xaKGmX1NcMN3ChGKj0HMGqmXf1L5z/FhbDLPAezM6ztUGsFYDUl+RvDBkD44ZaqEya2jdzNHxB6k/jcK6naRLEHcIv6W76Y4ijwWTJiPU45/Q/v4PURJQGQ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=anL1P0itDgHK7+ScI98pOYbc099ObRlXgl+VxysqEc8=; b=bmEfo0JAosO+AV2pn9GVVE/nsymANbARsh9weCJ37hw53wy8avS7nb5ptEgQkr2hvhd9/oyqSdHgeBpBI2BDeMECwBMMf2vDkft0MC39QPvwdCSIt2C25ZHW4y8WC3tIbno9+Lr5+JM1jjbfz32If/KSUnyWGq5A1148cDzfifrL4nJQiisf91/xe2q8knbRJX/lHKw0y1YUHQhqAeWdXP6e83zoEd83kUlVsyfxadw2E3OiObcr/JYyc7SZ45HLq0m1JiWhgRk7VTVOD9LyI/FZpZ+UN7cP1gY+ChIqWCcLvkGaVH3qQXyTzck44qKGeNYdoI3q3+ojbxSMVJ1qWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=anL1P0itDgHK7+ScI98pOYbc099ObRlXgl+VxysqEc8=; b=7VaZNaAlRqB095bkEhtrFY9WqIiML1IWCBEqAbUzYsBQ8L9pjvm2q0pkSni/T8aBBom9DH66CtsmmMo4gkVvkj0pUALM7yf7EjL6Ocz20Jh3oqHc4h0+vqX+uQeSU1L50fZIxFBVt28VIkBiqEXEebnCgVSdTJ7uswrREJ0cods= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Henry Wang Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Index: AQHY1KFdAull5ChokkeaXft6EPXQra333cqA Date: Fri, 30 Sep 2022 11:55:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAWPR08MB9471:EE_|AM7EUR03FT012:EE_|AS1PR08MB7499:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e12f89c-b4b8-4dd5-cb4f-08daa2dab324 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0hdElaNGETxu9zz811R1vak7rp584UCj/dPMyo7x3oq2voXMYFIf90+gA1Up/wBs391DjbI8RnyHv/4/cKLsOZoL/26JFO3u0DAA3wmaV9iEXW9JZEcKL3uehexb+8Izta2me/UYeuG5XIOb42/t5yblfp9NdXkKTEKJl8gA2RFHylcqW6enVCagTdjSYrYeRk6r4l4k84H0Fz93i29EgZwDbjEaL2wDpbifb6S24G6DwCYM/3XTETGVbspkwwfEFDJ3xiT0uM7zpnBeQTTPg4X13U7DFxNJXDtZ27EsXMy937i+x4h7tUvMsHDP3iwOTze6/bFjMKF51fTtGs5Gvc60sTgtrU5AfG6e48JOAp+JmMWyQ61pqKvv7W63iBC5e3ZBy9BumupAjcxiHzd49HGfhJlsEm2hAqhCJEzgcmHNy0c0raUxHDhl8F4vQCyFUODl0h8Ld3Ni0X6NeXWPMpx7D43WwY+SZLB4DfY5YnjcV/P2ejcOI/bLbmnKfHIJ7vLhg/EH/B3OLDDDFaePRWfZcIq1ZlUaizuqhND2koEsIjPsB4EzC18DfOdB+/dD9Eu7GBdFGGbLqFSkvAMA2laaI3YVXTiy8xHGVK0j4wFB85fEe0mcYEJPS3yGBTXPCgOlio9UhLL3DMr7FUZB3UXq5Gow+KGYm1kNhrJVjBWxcraR0SOYRG//yrbmvDr3lrDzxSpc/XJSsg1vVcIC1x4fXioKRnfcUbP7Z9j8B/v6B/LatwhbYA84BnknXpZ8ShB9fp6N7p00GRgyI5a/XarEOYO0Vtam4wRisSCc/Ig= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199015)(186003)(2616005)(36756003)(53546011)(2906002)(41300700001)(6512007)(5660300002)(86362001)(26005)(6506007)(38100700002)(122000001)(38070700005)(8936002)(83380400001)(33656002)(478600001)(54906003)(6916009)(316002)(6486002)(4326008)(8676002)(64756008)(66446008)(91956017)(66946007)(76116006)(66556008)(71200400001)(66476007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9471 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 050c9c11-e09d-4fc2-9304-08daa2daa9c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QYfT/6d3E+ORiu4hbz83ZOVxwQIcyZNw/7QW5T17Iy5NOJTfLLWL0Donz9qXin+Owhdbylkt3DYzgMk4gqqsvPi0wfm8zwSHa8RLr1Df8I+JjqZHwzfNpG0OXPyfmPAPxhhqudPX6xIkEgqXge1EU/4kbEiZk+Ter5cp2ySVoT0Mwd+nSkN+kfIU7+a810kdKvnMyVWVSiwKRkFz9gfbRAQ494IVtFvKoNSfG36it3jCVoTy8cK4SNuaHVumB7jJk7187EnIpJdyDmhYd+1oZd5UBu4aLSDhA50UnihnDNLSsSVbuv3eRTyH1LK5HZjtbTvMnGj4TcHTJDZ1WnRegFRSJtyHHerDAefxtDOVU848XbV9ec6+wfDKBJe7iXq+QruFMsKI5i7PBsMeX/72OOjlTs0TY5zVAToFZbpWp1bv0jQpYS5ozkycii7fDsg+lbbDixJIcp6OHTG+makI6EBo/iM1QyLaO6nPUzzfc8ufDJ9vMxkiyjtWFae6TMVZ2qcqidhgCTMrgnwzby8hC65QlkhogFgyHAJ7dCCc+u9GFnZIxiJgWeh9zM6MXzvc7BIRFSZAGrT/DCi9DQ87bov+bFJ32s1fpRh/P2NUcL8tv6Yt83bTXAB4V2Q5TPRspESYC/xXgqtSa4VaK8mCogExzTNyJ8nCFu1xYJqfxhla/WglzIPu+1DLrGz7iFw5gxa0Y11Kaqiq1bElPL00PamriNmIufUX1i6ytZRK7idWq0SMrgqG07DvByI/pov7puAdpkjZoOGys9Ut9JEqSw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(36860700001)(336012)(40460700003)(81166007)(478600001)(33656002)(36756003)(8676002)(6506007)(5660300002)(41300700001)(4326008)(356005)(82740400003)(86362001)(83380400001)(40480700001)(2616005)(2906002)(82310400005)(53546011)(26005)(54906003)(6512007)(8936002)(6862004)(316002)(186003)(70206006)(6486002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 11:55:41.7668 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e12f89c-b4b8-4dd5-cb4f-08daa2dab324 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7499 Hi Jan, We will review and test the arm part (even though it is modifying some unus= ed code at the moment) but I wanted to answer you on some questions you have = .. > On 30 Sep 2022, at 09:50, Jan Beulich wrote: >=20 > efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME > higher priority than the type of the range. To avoid accessing memory at > runtime which was re-used for other purposes, make > efi_arch_process_memory_map() follow suit. While on x86 in theory the > same would apply to EfiACPIReclaimMemory, we don't actually "reclaim" > E820_ACPI memory there and hence that type's handling can be left alone. >=20 > Fixes: bf6501a62e80 ("x86-64: EFI boot code") > Fixes: facac0af87ef ("x86-64: EFI runtime code") > Fixes: 6d70ea10d49f ("Add ARM EFI boot support") > Signed-off-by: Jan Beulich > --- > Partly RFC for Arm, for two reasons: >=20 > On Arm I question the conversion of EfiACPIReclaimMemory, in two ways: > For one like on x86 such ranges would likely better be retained, as Dom0 > may (will?) have a need to look at tables placed there. Plus converting > such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to > me as well. I'd be inclined to make the latter adjustment right here > (while the other change probably would better be separate, if there > aren't actually reasons for the present behavior). >=20 > On Arm efi_init_memory() is compiled out, so adjusting Arm code here is > perhaps more for consistency (not leaving a trap for someone to later > fall into) than a strict requirement. I wonder though how Arm has > managed to get away without at least some parts of efi_init_memory() for > all the years that ACPI support has been present there. I guess this is > connected to most of runtime.c also being compiled out, but that > continuing to be the case is another aspect puzzling me. On arm we only use the boot services in Xen and we do not provide any efi services to dom0. The required info is passed through a simple devi= ce tree. There was a discussion on that subject some weeks ago and it is still an op= en point to be solved. Also APCI is officially unsupported on arm. Cheers Bertrand >=20 > --- a/xen/arch/arm/efi/efi-boot.h > +++ b/xen/arch/arm/efi/efi-boot.h > @@ -183,13 +183,15 @@ static EFI_STATUS __init efi_process_mem >=20 > for ( Index =3D 0; Index < (mmap_size / desc_size); Index++ ) > { > - if ( desc_ptr->Attribute & EFI_MEMORY_WB && > - (desc_ptr->Type =3D=3D EfiConventionalMemory || > - desc_ptr->Type =3D=3D EfiLoaderCode || > - desc_ptr->Type =3D=3D EfiLoaderData || > - (!map_bs && > - (desc_ptr->Type =3D=3D EfiBootServicesCode || > - desc_ptr->Type =3D=3D EfiBootServicesData))) ) > + if ( desc_ptr->Attribute & EFI_MEMORY_RUNTIME ) > + /* nothing */; > + else if ( (desc_ptr->Attribute & EFI_MEMORY_WB) && > + (desc_ptr->Type =3D=3D EfiConventionalMemory || > + desc_ptr->Type =3D=3D EfiLoaderCode || > + desc_ptr->Type =3D=3D EfiLoaderData || > + (!map_bs && > + (desc_ptr->Type =3D=3D EfiBootServicesCode || > + desc_ptr->Type =3D=3D EfiBootServicesData))) ) > { > if ( !meminfo_add_bank(&bootinfo.mem, desc_ptr) ) > { > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -185,7 +185,9 @@ static void __init efi_arch_process_memo > /* fall through */ > case EfiLoaderCode: > case EfiLoaderData: > - if ( desc->Attribute & EFI_MEMORY_WB ) > + if ( desc->Attribute & EFI_MEMORY_RUNTIME ) > + type =3D E820_RESERVED; > + else if ( desc->Attribute & EFI_MEMORY_WB ) > type =3D E820_RAM; > else > case EfiUnusableMemory: From xen-devel-bounces@lists.xenproject.org Fri Sep 30 12:05:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 12:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414195.658343 (Exim 4.92) (envelope-from ) id 1oeEm0-0005hm-8h; Fri, 30 Sep 2022 12:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414195.658343; Fri, 30 Sep 2022 12:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEm0-0005hf-64; Fri, 30 Sep 2022 12:05:44 +0000 Received: by outflank-mailman (input) for mailman id 414195; Fri, 30 Sep 2022 12:05:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeEly-0005hZ-KZ for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 12:05:42 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2077.outbound.protection.outlook.com [40.107.105.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 343a7de8-40b8-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 14:05:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9197.eurprd04.prod.outlook.com (2603:10a6:150:28::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Fri, 30 Sep 2022 12:05:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 12:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 343a7de8-40b8-11ed-9374-c1cf23e5d27e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLqj6hGi2IxAiMbgvhNYLM1FPENQ3bBclC+OBjKehSlU0aEqiv9jWt1TYIy0C/OKausc/tTi5XPjVr0ZUQAu4jKGU8WhDinURR8AheO394lb/vQczp1fcWVWhE6x1pgMAy89uWe2h99GSuA4Cys9Vhaqo/ML+u4dphGa7+1QordUrskDZbUdYHxNWZKWPS17iAKhp5XSUMLCG1OVPXWvhyCuPvldIoWf9GYa538+syWA2ImB5CEiEchjG64Uv0dDG8ArDJQtglqTrMa3fFb8/TLZWOrYo0LFnCZDpzs/c4r9bZdzj+3cydRGMpQoYyjOszT+YW0Y4PcFHwc6FFyxhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RA5Xpy1wR8IWHIfULTS1aAulT92HxfuCIyp3kr9DfCU=; b=ft2smnQGxf9UhyonMfoMhsMWVrx/Q6q5nqugY5BpZQwWTEwT6LElaPs++6FJgHdL7WpiKGyUGtgUG+TOGOqTC32kFaD+sQ94NwVABscMKKgqjg/j4I2HLTr2fzYI7hjXFUybgpdQhWipbYlsl2n/fqKeGIoGSg90OwCLQZpDl7PEDn9NJGUBWgr9VH0EwKBwhEfROWyvycOnRS7Kl9BEJxUYKArws2SdTI1WEAGdwuSQhii/etqsWBQ14CUGRcLcT7rGDDmHniw4mBjPPyWNjf1FNt3QBCXe0VXovdVvVNPR2e9Dknrc+UzgC/foajk2UCdep33bWuLDIYRSZ2ZN8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RA5Xpy1wR8IWHIfULTS1aAulT92HxfuCIyp3kr9DfCU=; b=EOzdeUdfeWTrbqD3v8CRA/DtbL7+JEURq5g5JhAZfxNFAT50AKV5JVzonDfjdAR54mECO+aXIiTPOkNGD7YWNAJlaT5Hs0AKL0ZwTlFPsPgv/oOXQN1DV55hT80Uf06ALmWVWIqTsm0VHY0DjOEaurgqvHhVZ8qo+It0xv6eKPpBvpkKSh6f1fAIzTzlUgviYhEmRzAxg4e8LwZrlv8RX8q5djQCWZlJ61C3itJV8S4pro+NN7RC+qU33lfDYn2jMiktvAvc/ea+dod4sLkssNx1kYt0Xk/Qnav8eBG0VDKbHflz3hIeNF3H6aTO00CS6NsyVUTJGnozo/zNwR+rpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <708ef4d2-9f9c-e4e5-d9e8-db8d4d633262@suse.com> Date: Fri, 30 Sep 2022 14:05:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] x86/NUMA: improve memnode_shift calculation for multi node system Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Wei Liu , Roger Pau Monne References: <84f1b8e4-3927-1986-9ca7-043790ed7011@suse.com> <21e773a0-9082-86de-be81-9fcc8ea2e07e@citrix.com> From: Jan Beulich In-Reply-To: <21e773a0-9082-86de-be81-9fcc8ea2e07e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9197:EE_ X-MS-Office365-Filtering-Correlation-Id: c184b047-e1a7-49bf-2b1e-08daa2dc175e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 49dTu2WWVOfkWfl5ryu8zJBUruxta3Y4o4QxUEcFPq8Pm/NlgaNpguIfQ61WBUWh5xFecW9BjSyQrkIJzWpwawuJPil8h9Rbz8G9J+m5QHSdWwMi8wbBUBM1BgEFyXT2daPmN8WtHZzHFVb5MfCzFOB0NQENle+dugIL2nD5kNXxQ0nyxiag6p2WgcWgAvuVGGo988IsUM09ppjg8e20WDg4vv+Asvim8wOh0DtldZ6wcVVqxmLndvbUGzokfS58k2eRU04CaJJ2Cl7dlouZTCTlj26rqAOL1k/FZsiRYaRqWerCgNnhsu8dT9mnYEjwEldqR/W2xKlozPkzqxLAoBVDkJDscnYz0uXvoo/UFs9vFeT39kHmnQ5e21Dr5evYAYQ67t9vQFOZa6clmgCgmmRpxzvFEC924UVujPER2ZSkK8HZIg9HV4j55NJhDuwof8AnGNAuX9hSgw+S18valpSkm4gI+gmYpK+vSpmfSAYBvzf6fmpkBxE07iHcWLQYUWS+9IGFDwxrUJYuVXGj2A0+W3cQ+fbSQwN7eUDqEu2p7ymqYbsk5LigZLimteBGJ+ED/LOvcgqLbC/pl4f9UyKHELx7qRKKhvZfe/i1Ac0rn216zJXe4OVhvj0gf+alzdV0kELaKw8STf0cP7rJdol/XdiVQl0Rtl5Z+9HR6u98e9r2fdA8+t2jJf02Zg5YwAhw/q6u4qTb7xTZ6rV3LRuNJs1PZUdjQUHwnYxj92lvAUV1HJzPKvBmdBzzXj4V1Fi1KIelZDb6peg6mtmUjPK5u2+cajWZDUJ/gR87oec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(346002)(366004)(396003)(451199015)(2906002)(5660300002)(8676002)(41300700001)(4326008)(83380400001)(86362001)(38100700002)(53546011)(31696002)(316002)(66476007)(54906003)(110136005)(26005)(186003)(66946007)(6486002)(2616005)(6506007)(478600001)(66556008)(6512007)(36756003)(31686004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1ZYUVJHdkNkc1VTakZjNGNhQ05RV0t5Y3dqU2gxRFQveXk4ZVRlTW1SNlBa?= =?utf-8?B?WStDOGtBZ3hTYXpxVThjWllPKzFES3NwOGZhTVlsTU9kRkk3TGtsU0JxQjFq?= =?utf-8?B?VDQ4a2xDWXpmNDNTTzhtajNNb1owSDlyRXQ0Tm1relF4czU4ejBOd1FIZnNp?= =?utf-8?B?bTJNK3J3ZFkyL2hNZ244WnQ5b0xZQmg3WFhkVlRnOEh2U291d0w4VjFXRXRP?= =?utf-8?B?c0NGUjgrUG5HZ0JJS1Jab3FrY3I4c3pRQzFwMWtHTEM2eG9vaUpndTJxSS9i?= =?utf-8?B?eXVYTm9nd3JWenBLYkNGdXltRzRpbWJZekJGdld3eWpCOU5xWGxGbERSU1pC?= =?utf-8?B?RGtnRDlBT0EvQnYxYVhYc0UxQlRDbitTRSs4OG9kbmtibUtpa2k3M3N0RVVy?= =?utf-8?B?YWZXNkFZcHlyd3NyQUo0USs2ejNsNFpvak9sZUlHd2p2MHBkYWkyZ3lKa0VI?= =?utf-8?B?SDhjak1MM1RpYkQ0SGlSclM3RVBvVmY1RUd0VUJja3FyV2luS2g1UWJPVnFr?= =?utf-8?B?SFEwWXpEb08vMFduNXMvYjhkeFBGUDkvMXhvNFdQUmVVQVlXQmhTYkdxdUVz?= =?utf-8?B?UHhtN3YzTWJHVmlJV1dZNERxTUNXbENZeDFDMmlzM0VDTnFEdW9qS3dQcFUy?= =?utf-8?B?L0N5SWh3YkxTblVOV1VhN1BFUFdwdFdKd05Ra0RLWDZIYWpxTERhS2E4RDR6?= =?utf-8?B?NmJwcWxGSXNWeG1jVVN1V2V4UUxScmhieWxjYk9pdFl6TEN5Y1U1NENTN1dz?= =?utf-8?B?VUFmS2RpSVZldDkwdEdIQk9ZZ0ZFNTNyYlRNMTJlcTVVUkpOOE55OWFSdkI0?= =?utf-8?B?NVREMDNKMGVBR01VdzBkOVlxYnY3MGprVXN3K1J6eTFNajBvOWh6cGNOd2pq?= =?utf-8?B?Rjk2VmZXSkM5ZmJFUU5UU2VzVUNCR0tteTR4clFsQ2paZ0dJdEZBQjNiQlZV?= =?utf-8?B?RVkvUGFYdWd6OUdBcmpPSTJBQ2NQQjhpUW9IRGJkS2FZU3pYVUx0c0hGcDU2?= =?utf-8?B?eVIzVnEvdGZvL1JQWS9qZHRqMmNBUjB2emswdmxHd3RBOWpvK0ZGOTVybmR1?= =?utf-8?B?eFNzOHo1azMyYnhOZnNFVnBzMXFmYjJ1ZGNFb3owUmNuTGxaYVhOZVB3dWtv?= =?utf-8?B?djBYU2NKWWRaR1ZVdzg2SEE2TEVJTCtLSDB6UEdHaUMxb1p3ZCsrN1p6Wlky?= =?utf-8?B?NkoyaUFCaksvM09nUE1NalNLMXA0OU40Z0hCbkRPQ2hWclRWS2U2bUthUWpv?= =?utf-8?B?NGJMUGEvcnFKUVpnOGYwUDVRWlV3dmlQTUlZMUYwUlI2anVaN0dNRmpNSWhN?= =?utf-8?B?RlJOR1VyZDF5ZmQyRnBJZmVld0dIamFLMC9Jc0pLOVlOVU8xNlY1MUNOdi9S?= =?utf-8?B?b2VxVGM2NFBhd1NBRVN6U0pvYzR4ZVB4VlJjMkhtNDNIUmpQN2N0R1VvVWtV?= =?utf-8?B?YUdLSnZQTEF1ZHk4MmFsWVhWTDdsTHNjbHhtM3RlVEU2c1hzU0ZDQTdEZ0d5?= =?utf-8?B?NG5oSDcvSXBEcURPTlgxc25rWEVFUEFOMEJnaVJMbXNvQUs0SURMQlF5L3lK?= =?utf-8?B?SWNpSEdqSXVqR01LUS9QbDBxbGY2cDdqMVhUcEo3QXd0cktzdFNucGhLQ1h1?= =?utf-8?B?MXQ1N1Mzcnd6Y3Y2VFkyVjFWOVI4b0x5Y1VhRFgrTzVjdzNNZDNhcno4YUJ6?= =?utf-8?B?Z2hVNkFxclZ2N1hkYjlSU1E4bEd3L3NuWUMvWS9iRFRDcjJRUnFzTWZQMXB0?= =?utf-8?B?aFdsMlRVaTVFa0JsdUZpNTdRdktxUHRwb2ppbzZUUTF4eTNWa3BCdVI0MjVz?= =?utf-8?B?RWEwVm9rRy8zak9BRThXZG1xbnhFdm5YRmpnd2tOTE9hUkw3bFFienJpOCtL?= =?utf-8?B?eVpyQ0NVdGVmeUFxRzZTem9VY3ZUc0xPeFZtK2hVOW1kaHFiNk9rY3JJYU5m?= =?utf-8?B?ODFpazZFMHhUdUc4TWRhL0dSVDBkLzFrQUE5SG81dzFDUmdOSjVJeGNSekNt?= =?utf-8?B?b2VxYVhFM0JEbUxBbGhuRmZWblRSaFMvaVFhVWovZCtkbUxLb1NpOFVWZ29P?= =?utf-8?B?NjhsSjYrT3JHVW5obFBxTTFWM3k5WHFaVm0xU0QxUFVOWXV1RDhRZWJsQm5w?= =?utf-8?Q?SUTX3va7oe/dcWiwb6NGr1EPz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c184b047-e1a7-49bf-2b1e-08daa2dc175e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 12:05:39.5836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HkBxUhlziy/lfFKy0+9F6HDrdyDds5i1AEFqPeZFNlvH/hh22vxOFLxoaMgX+CT6DFTilRQJW7SxMaDNHrbPTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9197 On 30.09.2022 13:54, Andrew Cooper wrote: > On 27/09/2022 17:20, Jan Beulich wrote: >> --- a/xen/arch/x86/srat.c >> +++ b/xen/arch/x86/srat.c >> @@ -413,14 +414,37 @@ acpi_numa_memory_affinity_init(const str >> node, pxm, start, end - 1, >> ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); >> >> - node_memblk_range[num_node_memblks].start = start; >> - node_memblk_range[num_node_memblks].end = end; >> - memblk_nodeid[num_node_memblks] = node; >> + /* Keep node_memblk_range[] sorted by address. */ >> + for (i = 0; i < num_node_memblks; ++i) >> + if (node_memblk_range[i].start > start || >> + (node_memblk_range[i].start == start && >> + node_memblk_range[i].end > end)) >> + break; >> + >> + memmove(&node_memblk_range[i + 1], &node_memblk_range[i], >> + (num_node_memblks - i) * sizeof(*node_memblk_range)); >> + node_memblk_range[i].start = start; >> + node_memblk_range[i].end = end; >> + >> + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], >> + (num_node_memblks - i) * sizeof(*memblk_nodeid)); >> + memblk_nodeid[i] = node; > > This is now the 4th example we have of logic wanting a sorted array.  > (two examples in ARM code which want to switch away from using sort(), > and the VMX MSR lists). > > I was already contemplating doing a small library (static inline, or > perhaps extern inline now we've started using that) to abstract away the > insert/find/delete operations and their decidedly non-trivial pointer > operations. For using such library routines the data structures here would need re-organizing first: We're inserting into two arrays and a bitmap at the same time. > The secondary purpose was to be able to do some actual unit tests of the > library, so we can be rather better assured of correctness. > > > For this case, and the two ARM cases, the firmware data is supposed to > be sorted to begin with, so the search-for-insertion loop should look at > the num_node_memblks entry first because the overwhelming common case is > that the end is the correct place to put it.  If not, it should binary > search backwards rather than doing a linear search. Well, yes, perhaps. Of course we don't expect there to be very many entries, at which point I guess a linear search can be deemed acceptable. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 12:48:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 12:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414201.658354 (Exim 4.92) (envelope-from ) id 1oeFRE-0002P9-At; Fri, 30 Sep 2022 12:48:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414201.658354; Fri, 30 Sep 2022 12:48:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFRE-0002P2-8D; Fri, 30 Sep 2022 12:48:20 +0000 Received: by outflank-mailman (input) for mailman id 414201; Fri, 30 Sep 2022 12:48:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFRC-0002Ow-2S for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 12:48:18 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140042.outbound.protection.outlook.com [40.107.14.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 269ed208-40be-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 14:48:15 +0200 (CEST) Received: from DB9PR01CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::7) by VE1PR08MB5568.eurprd08.prod.outlook.com (2603:10a6:800:1a8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:48:12 +0000 Received: from DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::54) by DB9PR01CA0002.outlook.office365.com (2603:10a6:10:1d8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20 via Frontend Transport; Fri, 30 Sep 2022 12:48:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT020.mail.protection.outlook.com (100.127.143.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 12:48:11 +0000 Received: ("Tessian outbound 7e4a920b87c0:v128"); Fri, 30 Sep 2022 12:48:11 +0000 Received: from 6dd2fec3417e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5367F612-DBC9-4400-8498-5755776CF933.1; Fri, 30 Sep 2022 12:48:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6dd2fec3417e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 12:48:01 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS2PR08MB8901.eurprd08.prod.outlook.com (2603:10a6:20b:5f0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:47:58 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 12:47:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 269ed208-40be-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O/lWuoDZS/+9lTTFcokIAProszSZwkX2QsUSIJ0gHKSERQAP+4Moh/7de1F0yqsGMPVxA84FP5MLuHFEep+CAUR0+TuLsv628hQBxa7HPz2uZXFE4zQmnYfNSbuCyVaMY6KZU1KxVOHZMGx+DWVWn/0EqFf8yrAvz3QNL8HSMsfUZ7IwblUL4Gl4NFYU2TyVsShJK//QMZdSVhht1RtsEvHO5U7eUcl7KWXCCdBCftPUd3dcOpvaYJGBW4J1VutLdx5hplduyWTFORaNLDTsN8HcW6RkWmjq2/IWOpdkr4KCr8dgEYDc8cMbP5VYxB18JmK4MmdrIAY8JCYzZHPn1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2TnTgGY9U3j/bL/Zn2HiBAWv15w+rYlWg7GYB2jmkKo=; b=ZVVU3QGUqbYzZrZjEh0EREKTvM3p3E8pcuvf1M1ZvjYFGTMBTLdkTbNzLMCar6xe35InvjZCZL1VuxmjklLbbW0GU+mpdAD5FOv6KBBSdezZqYcUCJVfdd9Oj/il0XLoU+eK5AId2FWGygLwsZ6T7co7XW/03JjlMAR/ghVm6n54dypqGErA6xr/rkRD/GSztR4eQVJQdlYl1n2TMWAmgvugqitwDlpKDuFxqg49N2VDx9I9qMor8cUm9Vko6SSVA86YoL0Bx1CLaBtruxlwIO9A5Jb4T2KIwLk4ygEDFuh9U8KOd0rJqY0qOErTbMJn2erLnPsPQqFhkqfdE4jZhg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2TnTgGY9U3j/bL/Zn2HiBAWv15w+rYlWg7GYB2jmkKo=; b=yIRlLGrXdq8XBTRp36RbZFOXYyJiVXLGf9b9rnl4B3/+RhyUVSZ7mGMiWXbMR9AXWgVovNNdOuy+Y303AFOwPfk+5B+HCKZXxaQaTIi01494nqEXbNbksH7u1nyoocLFmvZ4nXmzyu202BARemdL3HNb6h1rUp+zqqEPoPNg6Rs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c9e7b0682d8b9abc X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfflKIS3xQBIxo4bZdDjn1qXWIiWL8FhqEjcNetYKVFAUMWEz6AXPWDDI27Xxo1+1gelMonLO+FSIK+uGOw1XYphGetcIlDBSnz5NpimeNucDlSVgm7NdfcrR+biL9l3UxWOM6Q10EqRER6dLnzZ9sCjvevSZW4GNOlgQ/hN7sBAX59AXRg2tokJKEvMiytqKn1MbwH3Pr/P1lM6Zn/iOIt5dfUy81+nchtgXTBCLtgAWdLmI286+3sG2GnwOTK67v2X/CWgmK+HIQbJyse420214RQQHH2C+Vt6BgT6YXGVoDZ0xx44LmQuuG3lpdikH+QDbdSMEUomKvMJCtg7tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2TnTgGY9U3j/bL/Zn2HiBAWv15w+rYlWg7GYB2jmkKo=; b=hC/WFOKTxdzE0/H7ZM+gkCRSCQ1y0X0dYKDr9DyAZ91uSWYFpxSL/oxvVg5eoanAmmnxoE1MLCIk6JY0TpF9PrKHUlOBnYZU7EUnWv3CNX1f9G+e0fj2uKhcZeXDLMxd8UfrOPW2mnzrAMk4rmV2hP4f7Utgf7oiCm3eWJiXCMe3Ow/WU53EfPZqxtMoNRiXKb0eDxtpuAGe6qOmqJrvuNyeynfPCogYaZKhUyej3DG7cbYE3A5HWspZmDkrWPp/X0G7RtZFVcstL7zeveNIwXgzKwVcN57xO73wcpdgBn/OGuYyL8mdkJGN9Dg5vyotjiO7vMdHb6K9qhm5+1PVsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2TnTgGY9U3j/bL/Zn2HiBAWv15w+rYlWg7GYB2jmkKo=; b=yIRlLGrXdq8XBTRp36RbZFOXYyJiVXLGf9b9rnl4B3/+RhyUVSZ7mGMiWXbMR9AXWgVovNNdOuy+Y303AFOwPfk+5B+HCKZXxaQaTIi01494nqEXbNbksH7u1nyoocLFmvZ4nXmzyu202BARemdL3HNb6h1rUp+zqqEPoPNg6Rs= From: Luca Fancellu To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Henry Wang Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Index: AQHY1KFr9QM2MLmHw02Oz3qGbH+jNq337HYA Date: Fri, 30 Sep 2022 12:47:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AS2PR08MB8901:EE_|DBAEUR03FT020:EE_|VE1PR08MB5568:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9649e0-cdd9-4864-fdec-08daa2e20890 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: r7phDFEtQ7PJKw32maT+MOW/6jMSrcF17/Nk5kng/C/xpgQvy8XkWYs/qkQ9NzrO+++C6Vq0dJ+2tGGw2/32cVbAhQBbKjMoX9zf2Hqha6lnzr8+iIxgvilq/ajcxDWkYHJvaPcdgvz75KoIIrbQOSKaWqawDSR1jyxRwwHgqlTj7+YeZk/6/wLDA+lKOgrI3JMUBsHjTIPeCRu3ohKjflB+gbCQwhaTwjqMWsvW3U2KOzvP0wLVpdhBDB3UqEs/xV9kbLFYUeb01al1slEtgG3+Qw+UsrZeo6CtGcJQJQVg9IYELsOWh7wA7NeHmq6+6jutK/YfR+1NpiR4Ceg/93968530zV0X5bKyliG7bN6VQFCG8dYfb7eI/OcsUxc5rd7DgQsqUszhhjBCACkFSYgfuQ58+9RIrdBnFLypB1SyABOHNahnSlBIWDfJD9X9/MMPlKkSTLjVobywZdBYdxWfebNrfsnh3VOzPz97573FmNhVQBj0wO7rK4DM+3G92R9QShmPU4VAv1JQDZv/JJCx/eQD/+kZKe1zXBAnCzNJHNfTsRLaySYbmov40aiw7SlOTBzMYDt+CFzHGBDr/In/XNYuw+sf7EgRe6CY8vytVtxY+dmnfL1joAGe3gpL4aXKCmqtu6MpHn2LlDldkahElMPuSgb/yyKmBqIIqRdxkfPc1gmEx6+B/vmLUw7v0+3XHFmzSmiRlPh4hnFFliCh8o6XXiHAbi5715NlnOMV7TdV3UHe62foFpF9LI0P8bCGKRTpvwF8da4B/D0Id9j7bFWjTAlAi+OTYLS20ks= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(83380400001)(53546011)(6916009)(316002)(4744005)(5660300002)(8936002)(38070700005)(41300700001)(2906002)(76116006)(66946007)(66556008)(64756008)(66476007)(8676002)(66446008)(33656002)(91956017)(4326008)(122000001)(54906003)(2616005)(186003)(6486002)(36756003)(6512007)(86362001)(26005)(6506007)(478600001)(71200400001)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <974668DDB4687B4B8B9392CC69821C5A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8901 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 348a4a7e-41d2-45c0-f829-08daa2e2004b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jx9sBs1tKRW2xezOoSpgNt4Awn7nhQNio0vPHT/V5WHw34/85JLkyHKnBxcvww5dsdsn8DXgpu/qKlK93SryoEGWYjscrrejpE7M/3QNFoRupKQWuK535xrDovXXCJQfEezOfjeidSxe8pCcIeB7c6rBrUV9YgrD9oOfkoAHmpvCDWi88KNQ8YL4js/zrbXSdo4fIJspYoSB/lzr0o5znMFH6HZg2RE4KcJBWecnILrA1f2FBlDE6Ji0nV9j7ZjOEab7dn/ZoAin8ZvmOWCElORgCEUzoNauYIvNhaBaZx0mm++8S4eHDSb/txh+dhxumbD9RFIajCt238/nUOKbqKlL40exy9nJ+ZP+zHh8+LUp3twrMmqjON3rfk56Fzq8sKm3E2NAyoGPezaInlpTtOq4Isyk9VoHvKCA+3R9cl7PPEx79K6OZyek5S5SZSxcWDAzblwq60oKozirajuLNKx5KBl1Q5oHubR8pxC/dsOXKJPmHdM4dMtAl90q2WQFecmLWUfH1lWF4Y9zKZFiezJ8/EBgsMEbbPjDsvg6BmhuMaVELRXOiZ1+61BSlA6NoZe2NmU/3/gPKJU18uCyNEEQYfwZS28TDYpCIFPztn2aAgOm5G8HKF7idfBzOkKNQzVvzCI4GzKgWm6cUaEFQHLDiBAlKmfvfZVkO3U6g4Y4IZ1Yj4t2FIaSp3aOsh41kySKxKQuGhipV8fp2k0m6wYw/MznkWVyBLGzO2U2AWMsZA6Fc+HTl/GrNav5uF0qeU8DH3HfIbhyuqJz2GK96w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(39850400004)(451199015)(36840700001)(40470700004)(46966006)(356005)(40480700001)(81166007)(36756003)(82740400003)(82310400005)(33656002)(36860700001)(47076005)(478600001)(6486002)(8676002)(26005)(6512007)(2616005)(2906002)(186003)(40460700003)(336012)(4326008)(70586007)(4744005)(53546011)(8936002)(6862004)(70206006)(41300700001)(86362001)(54906003)(316002)(5660300002)(6506007)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 12:48:11.6218 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce9649e0-cdd9-4864-fdec-08daa2e20890 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5568 DQoNCj4gT24gMzAgU2VwIDIwMjIsIGF0IDA4OjUwLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gZWZpX2luaXRfbWVtb3J5KCkgaW4gYm90aCByZWxldmFudCBw bGFjZXMgaXMgdHJlYXRpbmcgRUZJX01FTU9SWV9SVU5USU1FDQo+IGhpZ2hlciBwcmlvcml0eSB0 aGFuIHRoZSB0eXBlIG9mIHRoZSByYW5nZS4gVG8gYXZvaWQgYWNjZXNzaW5nIG1lbW9yeSBhdA0K PiBydW50aW1lIHdoaWNoIHdhcyByZS11c2VkIGZvciBvdGhlciBwdXJwb3NlcywgbWFrZQ0KPiBl ZmlfYXJjaF9wcm9jZXNzX21lbW9yeV9tYXAoKSBmb2xsb3cgc3VpdC4gV2hpbGUgb24geDg2IGlu IHRoZW9yeSB0aGUNCj4gc2FtZSB3b3VsZCBhcHBseSB0byBFZmlBQ1BJUmVjbGFpbU1lbW9yeSwg d2UgZG9uJ3QgYWN0dWFsbHkgInJlY2xhaW0iDQo+IEU4MjBfQUNQSSBtZW1vcnkgdGhlcmUgYW5k IGhlbmNlIHRoYXQgdHlwZSdzIGhhbmRsaW5nIGNhbiBiZSBsZWZ0IGFsb25lLg0KPiANCj4gRml4 ZXM6IGJmNjUwMWE2MmU4MCAoIng4Ni02NDogRUZJIGJvb3QgY29kZSIpDQo+IEZpeGVzOiBmYWNh YzBhZjg3ZWYgKCJ4ODYtNjQ6IEVGSSBydW50aW1lIGNvZGUiKQ0KPiBGaXhlczogNmQ3MGVhMTBk NDlmICgiQWRkIEFSTSBFRkkgYm9vdCBzdXBwb3J0IikNCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJl dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCg0KSGkgSmFuLA0KDQpGb3IgdGhlIEFy bSBwYXJ0Og0KDQpSZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0u Y29tPg0KDQpJ4oCZdmUgYWxzbyB0ZXN0ZWQgdGhlIEVGSStBQ1BJIGJvb3Qgb24gdHdvIGFybSBi b2FyZHMNCg0KVGVzdGVkLUJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+ DQoNCg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 30 12:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 12:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414207.658366 (Exim 4.92) (envelope-from ) id 1oeFUf-0003n7-RH; Fri, 30 Sep 2022 12:51:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414207.658366; Fri, 30 Sep 2022 12:51:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFUf-0003n0-Nq; Fri, 30 Sep 2022 12:51:53 +0000 Received: by outflank-mailman (input) for mailman id 414207; Fri, 30 Sep 2022 12:51:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFUf-0003mu-1H for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 12:51:53 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20049.outbound.protection.outlook.com [40.107.2.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a71445b9-40be-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 14:51:52 +0200 (CEST) Received: from AS9PR05CA0023.eurprd05.prod.outlook.com (2603:10a6:20b:488::13) by DBBPR08MB6315.eurprd08.prod.outlook.com (2603:10a6:10:209::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:51:36 +0000 Received: from VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::a8) by AS9PR05CA0023.outlook.office365.com (2603:10a6:20b:488::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 12:51:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT018.mail.protection.outlook.com (10.152.18.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 12:51:35 +0000 Received: ("Tessian outbound d354c7aef2bc:v128"); Fri, 30 Sep 2022 12:51:35 +0000 Received: from 07e9c60d7ce5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B3189B6B-B52A-48B7-AB16-1B9ABD5ECD67.1; Fri, 30 Sep 2022 12:51:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07e9c60d7ce5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 12:51:24 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB6427.eurprd08.prod.outlook.com (2603:10a6:10:25a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:51:22 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 12:51:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a71445b9-40be-11ed-964a-05401a9f4f97 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bpURE/B+Behnan9NxmICtJt9sFmPgtdY0Nn55r92OJfTFCZ9RfWGZgXkE4Hbsf4LNVaiKAz/kDkdIrCZ3Wbec3QxYeSCD/vJ1d5UDQEAdqihJyHj9SPWhXO4Np8Xe9JVvfZz9dTGU3jx7ui9M+gRNqofSW2w+/YoKCejoU0I+kSIaxFMYwFJaG2qgRC9Uu7EDb49Aj/lzS6S5eI7kPnFMpqgM74wXrZYIABSrr1G6fQ9CyCMLDDpZFKC2PGG69+JvzZPF1XA0PRz7+l35XXmYZLAFMbpY8N6/P9o1QVlqqZs6H7NUeoxYHqI6fBHhbaWQIfkHUTRxkInEhP6wFau+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=21iZ/I1t58/hVVNe+uIVrGyzT/3xrRxSHAag3wNb6pA=; b=kxJ0d+UXzG+W8d4xFQh7wy90AVCQyhnYVIczmQ7OraVsOWXYpBobVvj66xHSAOTgeekoR/LxyLMHpCaf47vs59HnkZbmaUMtFdVAdGzmEa7j/Xp6N6MBU5A6+RG2QJqhnxeBbpzT2mSlFPjLMNhamrfZO46dnapVkl5xSe45uXX5t21ZNDefIW3+7Ej4CEXUc4fuSgN3uGjGq7+ZQO6M6luDzzdG79V4yEZh35RvhGCUnOJBd1HENAtc+GoYDDm4KeT1+2psQGvlzqCxUdPAFAkdd6i1X0IOd57g5ou0NZd8QQ3vvX+wOlpzQuQ0iI/YbEvgbRKiBLqcfQFPeGDR5g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21iZ/I1t58/hVVNe+uIVrGyzT/3xrRxSHAag3wNb6pA=; b=GSiAWYZJY5Bx+JxaRkjUnaeOsESmCpQ0RAAIF1puNk/C3AMVqzR3EonYonwo+0IE5GeAteFUwXFhhNcdegNFfOs1qSljMpwaaAmEsFpnMBVT8gw4mka43VkAKXCk9ATOWMEYIYiyjUFLPGZVtWLCTp9jfzB8ZPPBSooJG+FC+Yw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 666b24c32a37d632 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CB3z5E8TLM7SJYakQzQmjlnObOSWaQq6mI4i3Dwm2eFxxtMJOPaecTytIOsPz178GLjQs5vlhOyPaWCFqGlGiwUvnsJcITsUtG81S+mSjgcxFco0Nt9mMIm6Qc4HJv7MqRn/bYdK53mUZusZfwqEnQ2B3pTv4OiBRERm5g8Zkl46U137tc6QOazdQOJ+DZ3v1SaruUN2anWOC+/7/L2ja4D1ifvjUboIrWlgPSSNZh6jMxMsabUGMKt+Xv7jh5ZqXJx1yRlIWxxat1jIcPRU7FghXinvNhiUhidfGVCVYn4veCXo2O+RK/KgoGaOpedGJHkP1l7pwspVNqXPIDNuxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=21iZ/I1t58/hVVNe+uIVrGyzT/3xrRxSHAag3wNb6pA=; b=DGKl3BlVT5Ioajp6ASi8aWKi9a4ARWv6UcIjs/IbImq4hkDGfRcllzOHjNVTSYI7TsfnNTiWpfJWRkfGZixPfOEQhPcBfifQ6Xxbc5fmyb3UNpqMxhNI8wR70SChoDAcxiQwyuVWzFXi9e2RjNRQKGVonOPQaaD0yQcC0pGvmlI1Yg9+3P/8jh5k5K3u0UMXuD6bMkkzou9kgyHJ2UoN/owTgTbheH3MhlCkPflgmC+4krODqWUOiejRDL0zSTKJCW5XRgFXSdpaEEih68IzmQe8aJHE/BNLmPRLNiO8Nl8JF17PoR36DExv69qMcAi7mmi6zcJfi+vwj0XURIXXhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21iZ/I1t58/hVVNe+uIVrGyzT/3xrRxSHAag3wNb6pA=; b=GSiAWYZJY5Bx+JxaRkjUnaeOsESmCpQ0RAAIF1puNk/C3AMVqzR3EonYonwo+0IE5GeAteFUwXFhhNcdegNFfOs1qSljMpwaaAmEsFpnMBVT8gw4mka43VkAKXCk9ATOWMEYIYiyjUFLPGZVtWLCTp9jfzB8ZPPBSooJG+FC+Yw= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Henry Wang Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Index: AQHY1KFdAull5ChokkeaXft6EPXQra337WuA Date: Fri, 30 Sep 2022 12:51:22 +0000 Message-ID: <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB6427:EE_|VE1EUR03FT018:EE_|DBBPR08MB6315:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cfe1840-c066-4667-2f36-08daa2e28243 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XKLP/RbFK2ETrgyutLeLQmwUWvFAtyZ+YkuPN34oB7vgpf4Q+CGnpqHhVtcgd1nMwWKfsLrhlvi5pA5mTfWskf0sP3afF9CiFEnjMAcJLCN07XmtILPSMt3b+QFDVqYuslLO2aXqMURXObSd6j7IkxCFsFNIgpJAtHVNryVpP7DdCNQHjzpSqPf1l75F1Mm4ZqLPJbXUNoBeQdTa8Ekl6RysqOw3Vi5XLImGaTSC7ay613yhMevPKqmLJlvyxiQcHB2PsCcHDQaNoROWvl0PhBM0bic5qRO3McPZNXcEK2J0gF8wX6EL07p52chd/nQLP4fL4l+V8JdNWqlSU4/LxM449mo4IX4NYBr+5XDm8cjZb3SMmqkg4OhVg4v+w8OgTjqwQGbM8aZP6hyADGc7QmrhxrjmYMz4pzsLYFEFP+yr9xvPcenRdJbfJICfIw+4netw7VlKZhqL7s5EIVjN2y9Su02mw7kVm9tDVnqoVC/fJnHhObCRKvQ+rJ2kPcrK6YvP/7gAyQGwfdUi578goKmrj4bFeqPn3syKS9ayePDWV9UTQknCrn+u3dgWLI4zRisoGQFul8f8Dgu0ijPeXsi3ejRaNVse+FD6i3wc4CcrDNaZ31Y3hll1zgrLoT8oyNV66967dSlw2Rxi8J1uhSpeNw0+GXyy4ufzqBrgt19t6qgh9n3Gfkug2mvUEiB5O8s9WMHOu3a7m7BXYfMmlq0lPPzvaX4zfBxUZuWEXnd72qyOc7O9gBW133NiUeYSN7a8yImq7uRNzLaAO6SsCrmMbNB8fvXqLS/h9hteHMg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(451199015)(36756003)(53546011)(6506007)(8936002)(6512007)(26005)(54906003)(8676002)(6916009)(86362001)(5660300002)(71200400001)(316002)(478600001)(6486002)(33656002)(2906002)(83380400001)(91956017)(38070700005)(76116006)(2616005)(41300700001)(38100700002)(122000001)(66476007)(66556008)(66946007)(4326008)(186003)(64756008)(66446008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <99A4B43BC6A4ED49A72EF5DE87C65946@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6427 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e76967d3-b2e5-4f51-e491-08daa2e27a39 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xgrKJWTo2iaqp85gUwFewa+Tf202pU88lzrY+3qyFKzxFUc98VcDv+cweyTl9AFBQPUS32Y+88goUHcBplUC60h5q12ef1Gi0P8XSh59jXvT7nADZnp4CpfL7/+vb8G7TzvA13FYRuFo3SXKfzSpZFyeJ8kM7Iuyc7dsqYdMets5c8umaeMHc2UjL1fc5JtlNU0l8UBOASFuT0Hysq4xSu7E/0NCOBXc4wmrMM6MZxG1/Wveuk/Au//7erTzUaQPC+F+AkwZkG0qTed3LoJ44y8P8UicZWFBupo46RU9oXOI9k5fyZ4Lc/iNBOxVLmi6B43J8Xo9z1U8Vh/P+nGFrtxU3igDLsW1rgvlCFfHejS8mguRCPgUyJnX8O7906Doolceg0NqMP4Iby2tk90jm3hSR74i7fdygZ+IyIoHDh5ME8SDTh5u4WegW4bSqteKE/wLLTCKyrh2Wm/LYiIoAgBbKyJA26/8tIqS1zZIvG3/iPyT16sjYvb+BJhCNWAHkX0JQ7RmaSOzV/xZJCvS0D1CIjTYKQhRu0l4XYGlrOzQ5JRRE5iwfuE9wTUakc+M/Yh2bLwfWxbS4lBgqeP9FBSNDfucvDKDXk687OknwljS/1ELDWy4jWDmUhxc081Fsu0pMtadEnDNX+VPA3Y+qG9Viic+sVWh2o5XDKYHQUkI4x52XzIAN0txnVkQvs5PdU5Ahromug3/yFetnv9Lsj64DKMYppx8jw6NzYXMrfMivp58nQ1knr4WRjvo+2Tdfbiv2XUvzd+upo3p1KCQUg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(6862004)(8936002)(82310400005)(36756003)(5660300002)(41300700001)(4326008)(8676002)(40460700003)(83380400001)(47076005)(53546011)(40480700001)(186003)(336012)(33656002)(70586007)(86362001)(316002)(70206006)(54906003)(2906002)(478600001)(81166007)(356005)(36860700001)(82740400003)(6486002)(6512007)(26005)(2616005)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 12:51:35.7002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cfe1840-c066-4667-2f36-08daa2e28243 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6315 Hi Jan, > On 30 Sep 2022, at 09:50, Jan Beulich wrote: >=20 > efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME > higher priority than the type of the range. To avoid accessing memory at > runtime which was re-used for other purposes, make > efi_arch_process_memory_map() follow suit. While on x86 in theory the > same would apply to EfiACPIReclaimMemory, we don't actually "reclaim" > E820_ACPI memory there and hence that type's handling can be left alone. >=20 > Fixes: bf6501a62e80 ("x86-64: EFI boot code") > Fixes: facac0af87ef ("x86-64: EFI runtime code") > Fixes: 6d70ea10d49f ("Add ARM EFI boot support") > Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis #arm Cheers Bertrand > --- > Partly RFC for Arm, for two reasons: >=20 > On Arm I question the conversion of EfiACPIReclaimMemory, in two ways: > For one like on x86 such ranges would likely better be retained, as Dom0 > may (will?) have a need to look at tables placed there. Plus converting > such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to > me as well. I'd be inclined to make the latter adjustment right here > (while the other change probably would better be separate, if there > aren't actually reasons for the present behavior). >=20 > On Arm efi_init_memory() is compiled out, so adjusting Arm code here is > perhaps more for consistency (not leaving a trap for someone to later > fall into) than a strict requirement. I wonder though how Arm has > managed to get away without at least some parts of efi_init_memory() for > all the years that ACPI support has been present there. I guess this is > connected to most of runtime.c also being compiled out, but that > continuing to be the case is another aspect puzzling me. >=20 > --- a/xen/arch/arm/efi/efi-boot.h > +++ b/xen/arch/arm/efi/efi-boot.h > @@ -183,13 +183,15 @@ static EFI_STATUS __init efi_process_mem >=20 > for ( Index =3D 0; Index < (mmap_size / desc_size); Index++ ) > { > - if ( desc_ptr->Attribute & EFI_MEMORY_WB && > - (desc_ptr->Type =3D=3D EfiConventionalMemory || > - desc_ptr->Type =3D=3D EfiLoaderCode || > - desc_ptr->Type =3D=3D EfiLoaderData || > - (!map_bs && > - (desc_ptr->Type =3D=3D EfiBootServicesCode || > - desc_ptr->Type =3D=3D EfiBootServicesData))) ) > + if ( desc_ptr->Attribute & EFI_MEMORY_RUNTIME ) > + /* nothing */; > + else if ( (desc_ptr->Attribute & EFI_MEMORY_WB) && > + (desc_ptr->Type =3D=3D EfiConventionalMemory || > + desc_ptr->Type =3D=3D EfiLoaderCode || > + desc_ptr->Type =3D=3D EfiLoaderData || > + (!map_bs && > + (desc_ptr->Type =3D=3D EfiBootServicesCode || > + desc_ptr->Type =3D=3D EfiBootServicesData))) ) > { > if ( !meminfo_add_bank(&bootinfo.mem, desc_ptr) ) > { > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -185,7 +185,9 @@ static void __init efi_arch_process_memo > /* fall through */ > case EfiLoaderCode: > case EfiLoaderData: > - if ( desc->Attribute & EFI_MEMORY_WB ) > + if ( desc->Attribute & EFI_MEMORY_RUNTIME ) > + type =3D E820_RESERVED; > + else if ( desc->Attribute & EFI_MEMORY_WB ) > type =3D E820_RAM; > else > case EfiUnusableMemory: From xen-devel-bounces@lists.xenproject.org Fri Sep 30 12:53:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 12:53:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414215.658377 (Exim 4.92) (envelope-from ) id 1oeFWe-0004RU-AR; Fri, 30 Sep 2022 12:53:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414215.658377; Fri, 30 Sep 2022 12:53:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFWe-0004RN-7R; Fri, 30 Sep 2022 12:53:56 +0000 Received: by outflank-mailman (input) for mailman id 414215; Fri, 30 Sep 2022 12:53:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFWc-0004RH-Ic for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 12:53:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee39a2f6-40be-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 14:53:52 +0200 (CEST) Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 08:53:48 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6611.namprd03.prod.outlook.com (2603:10b6:806:1ca::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:53:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 12:53:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee39a2f6-40be-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664542432; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=J7061ZzpFfw9cltov4YtMRU1Bm+P+oDbBUi0e9qeKnw=; b=Nuf34+XrWmU+6gBc4PiKvP5p4D+hMcW2BPrbJYsK7KqwOxQnyH+n98YM Ki7bMQBLSwnvZUt/m8GRPKJPL1y5PSph6LHCEagjqA1/Oq3XhT/yBSyMK VSRJ4wUvhaz6mslg8x3vJwhyCna8OWXI/En1y2A1b128vZZSJ2qQ6dX5s A=; X-IronPort-RemoteIP: 104.47.58.109 X-IronPort-MID: 81715032 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AfKSKsq7RD3rZYrxOikp99gxR2vbMJc67UCYv2?= =?us-ascii?q?ybI2n9qXhjvZKvfOBssXYv8Wpfo+PeyQoVEoa+/cxN6ZIJ+4YuAx8zB1MK+9?= =?us-ascii?q?aFtG1Ws5A2WgEhWToypr6DmCQ5shkJMLLsDjgZpzCWkm4ZkjSK7VWu5Z6faI?= =?us-ascii?q?w6/B3yNhnyGnCyiuGTnhoQMSBwPtd0fB3dE9yZA8oT4hGgLjMLP7qUquXjXW?= =?us-ascii?q?GDyci335vdvkTKnT2ln0s0N743uQd7RDqHJG47eyF5tARZmD6pyklETFmfg+?= =?us-ascii?q?10acZPqP+R0BDYGTVea3ejJSeU0DohZaBV+UFoFzXLHAt00SkqqdbVfiqWtd?= =?us-ascii?q?AKwxJKfMXeDTOnqFnBYsiRj6txcSRzkie2HiRbB4qp/gwhW0oxgkrQFlAR/q?= =?us-ascii?q?BaxTzsGCxhLxoK0oFMBVSvnsJ7d/A/Mszf6xJzpVMY+4xbJm+uy77e92AKat?= =?us-ascii?q?I/2cCjdvuUy3TycUelu9O8dH4jCz/ejMBzHqn88lOyNiMsKtpP9XjETIrZtc?= =?us-ascii?q?vZhtfys/JGvV1akNCJ/qtSdVm27+/opUPr8nxjqiaoiby3Ch/yb9Wwh2ZOsT?= =?us-ascii?q?fCustnQ844r/oKGNxtjQDEeXqcBzTy+0BYynv3psbbKZ1PudOVoDW2+WZG0a?= =?us-ascii?q?xHHhkEV2R3jctaov5QGShfoZc1fGdaY9HQJUMTR0gX+NPBW3qTMS9Ol88DYq?= =?us-ascii?q?YWyIYN0L/tL8J7ADQoXMngpEk1obBHTzp8r8+nfeeCt6uzSxlWEF7flWV5Gw?= =?us-ascii?q?BnzgbtujdsiD1x3+ZOuU+Lk/83i6Lnjx9fHX2z81AIZ8MFGxJi0fM914w4/Y?= =?us-ascii?q?z5Oxu/3vN9ewVuXdZoxGDLv9vR1PXQWxlFZo0T/JJM4mqMleciuwRD/lWYWm?= =?us-ascii?q?TidqNfj2Vs52ODeMq2N+sGvnwE7uRqCFCCLk3NaptgStwyEqkXMm+ltw/xju?= =?us-ascii?q?CHGlIM0WDVjGOy4VewiuKqDp6vM141NxBXkMz7YzLP9uT8bvfa5fx17RI2RC?= =?us-ascii?q?QFEiAfzgS9VqfPNZOr+4tXxVkZEWYco2fJQIzUOEWlKykDmvQVToMUOLz5fq?= =?us-ascii?q?zMiBlUBaWjajCrbhdnrACrLYzzV2tUh2JdgSxc1NnfeaHEcek1dJwd78jKVS?= =?us-ascii?q?hT9nzjZ2tBcdaVX9jb3pKHhMIhmq5PU0kN0DHRMJvCkIk9aBoPAd3IzduaLS?= =?us-ascii?q?P6OSoRMpbj8FYt1Cz/es2pN2k3Fkx2wJ+QfSBDt9tfDefpICnoWiG5YZNfJh?= =?us-ascii?q?mkKDfoNay3Ua/rxKPqh3Y8n7kHx5DmqYe7EPUiFrxBMpRR5OwvX+230Pir7x?= =?us-ascii?q?UUVNbxnptzKKm4RR6rYiC4cgeQtxrsxu0u7aroA7y1rv9ROwFkOitZfFVYBq?= =?us-ascii?q?QWyyjg30KJ18o7qPMmMB3UYqbMd4FRaXsKiSXxKOkZCWnQ8wz+rabxrIPq1e?= =?us-ascii?q?pZ70QCwq+RMafmGdpUvJ+8bHIXjeIPd9ygdO7oHcE9d+z2dxnnZKLzEveeei?= =?us-ascii?q?x5mY4MJzDWS1V0M+dqVK7Ck17F4FIxwnqC3r8HTCn1H8ArEcww0M4uc3okLR?= =?us-ascii?q?ZhXtwbwc7sdJli4AA1fpFpMhyHH29a7FbQZlnkvSYAmHEu+CgawZy4Mc7MSI?= =?us-ascii?q?z0gluqWA4bsaw3ygjdN3as6KucDFSDTMkawrGg9qlDj4DykgzZzWrGlprAa8?= =?us-ascii?q?Wz1itKKD+1DbQkcUjDgCAO0WgWXH05Xr9QHQztkyruEi+0QmTfdoam82rBJU?= =?us-ascii?q?i+XmYblJIfTv379ho6Y87QuI5tqFAqVddUOtSgKWde/swaoDOKMywQjeQ0B0?= =?us-ascii?q?1cq3i3TUb8hQDZI62uqZn2ikVyN9Er6bkOYfAZIW7YsYIduSMekusdN/WZ5a?= =?us-ascii?q?h9vVMh+lW7FDri8cvToGXOnJjg7wmKNqH1sY765SlWCOYG84y1DFrYg6oIdi?= =?us-ascii?q?Is5bLk92cMgGQRPZpRS65NTFFnmi8vmxaWOdEUqg7Vh87nUnkmaJPzA5X8DA?= =?us-ascii?q?387XS9XsqjJeTz0qraXX+tXNu9/Y9hIQ4v0TIpontdFbGSjgeWGpukd/P0Sb?= =?us-ascii?q?ECT8f44DEEj8HP4WJdnh6i8oN+TVs+58ZflLaBmaBMIe5IKqgxE60iV55QjS?= =?us-ascii?q?YN3rmyDpt/5pTv/8JGxBE5IwgxTZ8x8Ph9Y+/v/8NAoapJYMx5JuGmVkzzKu?= =?us-ascii?q?EJUK4tq12dpc+QXHCuiFXXy7NRClTBfckYH8q4wl41gci76QtYTXvBfdwaxr?= =?us-ascii?q?db95p0TFWvKZkAyAh/eclIMtoaTNlZfXZiA8Pf0cfNJnGNwWbCz5KVe9OeqH?= =?us-ascii?q?gBlwutwNKW13P9a7vrp6YoJvobjmYmGb6Gg9HpFQdvOOfFjIWPku4zlstlFN?= =?us-ascii?q?z+RIghHMw3HpvWVOvvI6m596mrEsfwVbp6LYtjndzBX8oVb/yELUSVj35v8u?= =?us-ascii?q?Ax1M6iD5NjWCnAEyRUi+CZGQ8Az33vwoPqj/lKzRLYifLNZlcfs9M0E3eXVB?= =?us-ascii?q?val2iRonYu5khFwp8OdUgTT6EyuH7jUZai617eDrEVqp4/82MTqjRy0CNSMg?= =?us-ascii?q?1Fks/vcPyevEMeEkXiMjGtozV/Xqo1JCAYLb8AI3ataZSI2mHz8BwbsW95p3?= =?us-ascii?q?rcSJpE7sSW+yPO6wfUrRbqwz4s7FhGTWmsw7lq+LEwsF2qY/oO87zqcayXG2?= =?us-ascii?q?I4l5hDlkNzv6re0NHbcLp35KKOx1XcDpC1BNiRH15rSjI8OrCD5AWAcRzKvo?= =?us-ascii?q?ZTGDoIYmLkSbNSNsBSqyyssrQ4oCW/2fDGYAU4pYLjzj5KsAvg4SRhSG5OUc?= =?us-ascii?q?NipMAQa6jAS3tys5GY=3D?= X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81715032" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHDkf7kzY8IERtupepBlHZOTeD2Lx7cvGCo5g3NS8Fkp2JhOJnloaIWuLJPziE2Mf1o2YRKchiPjPstAG8Rj+1OWG519UYk1qwCZnQbZggtbOPix68PIVV4PUjxFMN1lXe3TJtrAy78jTaXoodyUGCBQd1O68qAups51Dg9uxhsxd4JvNoQN0gzJ/HbdU3eHQ1gGm+PvslQ4uIQemnK1zBgQ1dLwhCKpOBa0kdP/bkFh5mI9zkKJ8VwfK20VBd/AB0z2r+TfWcY0zSwYtMjJdAvmX/DRb5tk5cekHFO0w0ZE8xjkVnYoBMGTXuz+YPBpPsPuaTPY3AHU9x4zvP9Cwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7061ZzpFfw9cltov4YtMRU1Bm+P+oDbBUi0e9qeKnw=; b=PskeCwYpiRxJVTU+6hKCyIC1QBq6ZFf7+u0u3bfl5mUbtsiecpn4IhtcLrzKkzo0O4BJOulgGwMYN2c/CSuJrBS6ncy8uVkai3Cu4oIeMfWvTDDIb9mfeUXoChUgeGDxUOCcETj6b7k1Y4TlZWbOA+/jgSksCL6pokVqlMy2PEMW6+P+egcAWyXU5f4alEV4/AuKWjAZ4oUkoZYSRWKLZ8B0oPSlyD968mZxdWl+sIou78RGeijqsfFehdWFyYbD2w8OGJsGcQuqeMt4qvEejMdLA9znONJQYqRUjl3B7njlE/iLBunIIYlOq9TfnLieb6AvkugP3gDoW9pXj2vpDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J7061ZzpFfw9cltov4YtMRU1Bm+P+oDbBUi0e9qeKnw=; b=di2A8F95AlU/qcjrbpNRZn4l1Hb2osKDHqNansus4u/3EWvtZBUgz4U4KJRWLuRRVaPBwYyd/w4K1sSg9xthR9EKaxe1es+00C2aDIH0s0qSgdloIkzsEz9u5ji6VDu3X1lWfXtpY5q6StUp8iAFy48j7Ymq/aZk65r4a4HzySw= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Henry Wang Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Index: AQHY1KFbLsYTqKjbvUaNuuSOaOWfM6337hgA Date: Fri, 30 Sep 2022 12:53:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA1PR03MB6611:EE_ x-ms-office365-filtering-correlation-id: 97943b65-5a0d-48e1-a326-08daa2e2d067 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ipbP8+mWepCjwegmMYhHUk/55D/NXCE/2l9NYcjVEWklQ+TLX9zk42XCrGFMVloHcywxiVLrcMIQAx5u5O84sXPTGiCJDf5xnuJJ87wujYSH+AvC11b3n3DKSpiZOlOGYXq0wFWNgWJHXSnvcJxCgZJmhGDjC6LyhAIJcNPeYsDACKVVPy9MWwaXrR5IK6+XnoqBhtygLLFOoAUTY/WXIY6ObyAzZCVatlgUHqaW0HU8XxrRDYtyqqZVsvXuKTV0mKAdpXZyoR7xopO5OzAESHu1Rx81XAnTc8DJ/9C7qBjKFJ78SlW7z/Bt5LHq2strFoV2ck203dRD+ERazSHyVG1veClnbUBY5S9vNEdkMpKEvY5bBM5cA1raHHZgTrlswIhcfnaMiBoDn4CaZty0oPD8cx/lZ3RdFHXPE1v2lq3eCaglDPA5cNLvGcNn1Z0b0V+bDoHk679sYcQNZp2rUD+8RRGl24Bx1zIPrx9n0p3hyyAv/JbfgcdutaUUjbBp8UWAxg1FoM1cWKXN01CMmMu289MBOenURR6TI5x7kZJMKNpl6Y3kE5rZdZlA4JkeXxgInQYzJlX3oBEeqkoqGlxGS8FFIUcUdi0q/V6Ycz/rYWo/Bni2oDBCzNWF/x+f+ZdJA+0wmjI3SZ2GGTKenWvP91o0kPDvRwxJdsjMSqfb5QDExkuiSN1Vek5mYU2VV5q3I2cOzIgs8ahIOoUOR2pd/+BV07lpkuzMfV8z1QE96rIFJyH75OyCVTubbRjUO8H+loFytXSw7Xe7rvKTpzoCCYBoXwf6qDjtyKo2pQjXzRUeWz5nLXjiQjDmWH3qqTqAlRzZ08jJVOks0tJPdw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199015)(122000001)(4326008)(8676002)(316002)(82960400001)(66946007)(76116006)(91956017)(64756008)(66446008)(66476007)(66556008)(38100700002)(6506007)(6486002)(2616005)(478600001)(71200400001)(186003)(53546011)(26005)(31696002)(54906003)(110136005)(6512007)(86362001)(36756003)(83380400001)(8936002)(31686004)(4744005)(5660300002)(41300700001)(2906002)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NUVOM0NmaU9mVThQc241YWxKOVJLV0NPOGRDSnc3UlJCbWpEb0R2WmVaQ3Zo?= =?utf-8?B?eFJXY25tK29OS1BqRE1ubTFUWEExK0dLNExtU0VtUmFwbm5kZlhjM001WSsv?= =?utf-8?B?UDNCcXhzMzQyZmdZbTBjanViL3pGT2xxUXpVVlU1aWd3RGJBd214Z3hPYzJm?= =?utf-8?B?SFBxYWZVbzkyWjRNbWtoSWZrL3lqb055Vjd6bk5UQWZab1NLYlVzUmdrUEVZ?= =?utf-8?B?eFpya1RMaG5GZFFzNTI3dnJEdjAwZjRwUlFPMVI0eHM0bHNlSk85ZVFXRy9N?= =?utf-8?B?RTF3Yk9URVFKZjVxZEFHN2RmNjhZMEY5ZnlsMVJOQkphVmxzR1MrUCt6SXh0?= =?utf-8?B?WTdrSUJuNm1ydnFxSG9LMG9pekJReEtiZUxYTVlxc0hRUHJxMkJabnZQTVlq?= =?utf-8?B?cExkZEloNS83UHR2SWJSYnBsN2lzUytxRXFWTGFPZndrV1pLQjRtdFVYSTYw?= =?utf-8?B?OXBORllJL0tsWDFkekJWbkFFbTQ4QlBJaTdFQ3BhVnREcjNiRlh6RVBNWDVj?= =?utf-8?B?L2tONVpnbklHM21nQUpTZ1R0TWI5WjJiZ2RSYld4QXBGcXUyeUpQQy9TRkt1?= =?utf-8?B?ZVVNWVJ6cnBZR0E0TlBGMEJyZjliaVpBakpOeDBlQit2Y0hjR0dQSFA1bmdN?= =?utf-8?B?d0J2K0pwbzVCejY3QkIwZDEwWEp0c0tJMW5yb2hXbGh5SVl6aFFSd3ZrZWlr?= =?utf-8?B?MERybnI0c0hoTXRpcHFPdTRXaWxMQjNiWThLbkcvbWpWVzRUOUlOL21vTUJE?= =?utf-8?B?SDgzd3Z5SDRZSmlvQ21PUDlSTm9rVTRIa29zazMzMHlCa2orVDEyQjNCUjBI?= =?utf-8?B?TzhjeXpEamMyMlZHRUk1ZFZ0LzdEMDZJYndjQUdsNXZpVUtwRkZ5RkFBWUo4?= =?utf-8?B?YXEzWGJ3b3cycitnRTlxQlF1TStnY1hpaEhsS1BqT01lQmlkV0M5K21LKzF4?= =?utf-8?B?WkVrSGhWRS8wZEM3aFRHWFJRbjJWZExjc3pTNGVQTGY3MHNXRm1HUmY2czRO?= =?utf-8?B?WjloMnJNcWlrenlabUZNdEFjcDl2TmJOQ2llWEhsdE1XRGt4K3R1c0UxeWRy?= =?utf-8?B?UTg1ZXI1ZU5heGpWTzhIcE5qVEhSbFM3a1VKRmQ1eVZRNmtGY0tFYjN6NnFI?= =?utf-8?B?WExWZzV1V0VvMjUwZ2tFUjJCK2llbExXelBiS2dTbWNvRGhoR0dkV2syTEow?= =?utf-8?B?V0tRckVKZ2dsQjJreG9wTnpWb20wQ2p3ZTJDTUNieTgzMzdvZGVZTGYwUkRX?= =?utf-8?B?WWJVMUdiMldrbXRzbUdubVZRZ2dEQmxEQWlySXFKbUkwa09hR0RPT2VzNFBU?= =?utf-8?B?WmhUZnptQXRZd2dMMkF6ZUFxbTdFUm5ONjcrUmZUNlNHYlhCZUl3ZEJ6NExL?= =?utf-8?B?blFmTEVBSTV4Q1hoMy9NOHRuUU9kc1VoY1VXQ2lGOUVrS3lDS2puVUpidXZh?= =?utf-8?B?VVlTVTZwaTFMVWhaWGF3WGM4dlB2bmdSUmtvd2VITC9uaWJaTU9uM1NjRCth?= =?utf-8?B?RjZjdGNmTkFYQ2VxMDBJYmJvblFjZnNpR3VlTUpVZVY1cGlCeENacmRkVVhh?= =?utf-8?B?TlVaVEM4L2RTQTZQcjBtQ1NNdHMvaXhPeEJqZ2djc2tJUVVOUVVHNzE4dmJT?= =?utf-8?B?MGh3alpsakZFVFFralJUOE9iN20xOU1ZU29VZW50S2UwVlJrMUx0QVRYT2tU?= =?utf-8?B?UzZYelM3TDhRaUhkdDdrZmNVOTRSeXdiZVB1V0F5QlBxeVM4eEFyMENKd2VL?= =?utf-8?B?TGROeEJ2WWViUEZGZmcyVGpkV01xVlRjNTJpMUt0VlhVenlmcDlvMVFlMXBY?= =?utf-8?B?dkZGcVVCZzkyWUdPZVJzbUM5VDdGdWc1NGF1amloM0F0aFJZOTVVN1JhZjlM?= =?utf-8?B?T3FPR2lCU0RQK3M2N0R1VEx0eHdRY0pPdnp5c2F1dDZuanptNUNMSE8xSGtQ?= =?utf-8?B?OG9XdEJzNmk5TzBNeVdzVjBJaUVXbkVvODBZWkRuVFJVS2E3dWppTTcvZ09u?= =?utf-8?B?YnFpbXNHdkxSR2FrNGk2WmVpaVFpRnBZamwvWEh1RTc5bTNsaXRDR2l5RkR5?= =?utf-8?B?cmx6TXNzMWEveHRoZHZ0TVJ5Z2EvYkgwc2xUNUxKRTdGZmlvcFdPSEVrb2p6?= =?utf-8?Q?KOU1b241oHznS7Q5MZ4NXGU8n?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97943b65-5a0d-48e1-a326-08daa2e2d067 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 12:53:46.8483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TVffPJQMsezRkJeTh6sNi0mVsFQpri4Jqvwsp30cVFvGvyDM0Lfg9APyd3TmMB2+wiLdl86tVkU4udh5g1B/Ov9nFUqUN9Ts6tEwVJuXNbc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6611 T24gMzAvMDkvMjAyMiAwODo1MCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IGVmaV9pbml0X21lbW9y eSgpIGluIGJvdGggcmVsZXZhbnQgcGxhY2VzIGlzIHRyZWF0aW5nIEVGSV9NRU1PUllfUlVOVElN RQ0KPiBoaWdoZXIgcHJpb3JpdHkgdGhhbiB0aGUgdHlwZSBvZiB0aGUgcmFuZ2UuIFRvIGF2b2lk IGFjY2Vzc2luZyBtZW1vcnkgYXQNCj4gcnVudGltZSB3aGljaCB3YXMgcmUtdXNlZCBmb3Igb3Ro ZXIgcHVycG9zZXMsIG1ha2UNCj4gZWZpX2FyY2hfcHJvY2Vzc19tZW1vcnlfbWFwKCkgZm9sbG93 IHN1aXQuIFdoaWxlIG9uIHg4NiBpbiB0aGVvcnkgdGhlDQo+IHNhbWUgd291bGQgYXBwbHkgdG8g RWZpQUNQSVJlY2xhaW1NZW1vcnksIHdlIGRvbid0IGFjdHVhbGx5ICJyZWNsYWltIg0KPiBFODIw X0FDUEkgbWVtb3J5IHRoZXJlIGFuZCBoZW5jZSB0aGF0IHR5cGUncyBoYW5kbGluZyBjYW4gYmUg bGVmdCBhbG9uZS4NCj4NCj4gRml4ZXM6IGJmNjUwMWE2MmU4MCAoIng4Ni02NDogRUZJIGJvb3Qg Y29kZSIpDQo+IEZpeGVzOiBmYWNhYzBhZjg3ZWYgKCJ4ODYtNjQ6IEVGSSBydW50aW1lIGNvZGUi KQ0KPiBGaXhlczogNmQ3MGVhMTBkNDlmICgiQWRkIEFSTSBFRkkgYm9vdCBzdXBwb3J0IikNCj4g U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpJc24ndCB0 aGlzIGFsc28gbGlhYmxlIHRvIGJlIHRoZSByb290IGNhdXNlIG9mIHRoZSBjcmFzaCByZXBvcnRl ZCBvbg0KSVJDLCB3aGVyZSBhIHJlYWQtb25seSBwYWdlIHdhcyBiZWluZyBpbnNlcnRlZCBpbnRv IHRoZSBoZWFwPw0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Sep 30 13:08:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 13:08:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414221.658388 (Exim 4.92) (envelope-from ) id 1oeFk9-0006JT-IQ; Fri, 30 Sep 2022 13:07:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414221.658388; Fri, 30 Sep 2022 13:07:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFk9-0006JM-ED; Fri, 30 Sep 2022 13:07:53 +0000 Received: by outflank-mailman (input) for mailman id 414221; Fri, 30 Sep 2022 13:07:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFk8-0006JG-Br for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 13:07:52 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80079.outbound.protection.outlook.com [40.107.8.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3398d31-40c0-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 15:07:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8620.eurprd04.prod.outlook.com (2603:10a6:20b:43b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 13:07:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 13:07:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3398d31-40c0-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgQ8V09LVWLjXwftwhDJ0pXFoHLvGNRqSd9AZsxIWD1BLNGrlVlNoogRkMYvFHuC9cZYi+a/9CVa2Mra5+VwzJcOmlPARYtIVoJOqheuZBYC92DAFINW3Io7fnT27TPAx9P8vVkxaUJydaBj31sVi0wh9d2U3X0haY1nxtWiZImxbc9RuSPMCjnxENC02WHCsW2KV3DizXrk/bLwGH57zkOLL+SbZsNjkPjsII0wJKezssfYkqg2kfYZqnfWW28yJWDci0kMT/ELHb3YIwq7+8Yl8XlDHOXzf3tgqy7NPlPMKEB9o9VuyDUi7Li0q8uXQIyQzIBMUDOEXGc2EaE/zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bzLpBGp7hs+UwkFZ3efQGLxJLr0RpDbq77EgNcKa3jQ=; b=VVyZjotN3kAZ+P6rZpdIFlSj0SNaETjpfUfsvjLOyScduFdO0kzNEiGiicz6zKSOahED2I3hTeF2PH+BeoYzGZFyXvQnKMiB4z94xWbi6o2INut2CsBS/zlVyJvSb/jFRrmhMKt7kFcU81/2eTYWLKpac9qN6flGV4uq9ddfq/vfcX2J55nwQkLFTU2bGMAZrm/5frgzmILnBgINlOEiJFJnUBla1gJ62EwdfcjC9Ha+XOtE/IxKigL5T2ixfHWnChT5ggsBH6c3fcp3SSWfEjQutwhefz7YRr399bxwfK8WmPm6cf7PYC2GHHHQrsrEF9XMHuaxy9zpJNyu8JbkWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bzLpBGp7hs+UwkFZ3efQGLxJLr0RpDbq77EgNcKa3jQ=; b=i1da9KxnOYxKcYPpUBTTrKIRQQbpU0vDMkmxUP7NPFZwrjFMRBeTaFdRTpilZx2kJ0bZzp2tY3kcC28I042kG4vjofqypw9oenhXMCJbA4X9/Njh7xXaNGweF3eca+u8XVGmPdNQkwTO8y27faSRB5ApfkMx8nHXM8eB8IteAaZFLBI4ADqDNW27J96pIjuBTJD+7hT2SSLGwdvlsVRIUK6jb/5bjIahq0wwVPlIDWLNpEttku8L4je/KkFYzk1icgJIBT2pmyHrT37AN8M8SX2IZTJU7RuikUBgsOAhX/kBW8UpHq+bybfNEU4ngzvrvmOCQiHi3Ar1puXxCU6s9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0cb3e6f6-2d80-ca27-bce7-3cde8770972a@suse.com> Date: Fri, 30 Sep 2022 15:07:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0194.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8620:EE_ X-MS-Office365-Filtering-Correlation-Id: ba2d7870-8c6d-4142-4776-08daa2e4c689 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ui3HNZOTZTD0B4PjHbHYmknm5cPe6s2jGbYQ+F3jv4ftQgtuuc9Hotb4rIhS5neFA4SBcIXSY+5yaz3o01f3PXQoL5Nkugqetx6At99UTrWLTzWE4YCoh58bs4PnYddMR1FuWflWnF7XFKm+L8eOFvbtrHy1R1lLt3GfVcZycMh4IoMHqCVHec156TTuundfZLR9oRXIGXNgUP3QkQYPNT+mwSAC3sxyNrsP3UxSyg2ARu71O4BzC1rIR8rHkKQHxFLVXioHRaKG0wshTRGeuDQIH+X2Hk1uvu5btdYRClxhImyfvIJ5nHU1dXzivWKIOoAuIwH7wENv8uaPyC16rPUWZ+jYn6zgXGdRjW8V6X0rkZjAvBlooxX1P00KbDkfAIejOtlOaKapxDzTnyKBOPjJDuv8C+cIbSdskcBqBAUVagpqD3E64whNA8Vrv1Nzkq5xts8ueN3NY19ioY3Ui6G5Q0+u0ui7y4RQJ489vqrEY3R2Xmq6o6pKenCXqY4HGK2b3pPcOmKrfDXGzCFMnUQocOoIzzEuZqGGqK6CWzwFCIdvYN2zlfwpISNynxfvx8q0jj9fV4g5jZ7QDxwm2zNz8REc76wSyyrrSut/XVt4XnU73WuOhD7E26+tzhKawB9dt9aLDvO4kDhjgFENROiv/vNa6yV2REMf+E5fn/B0oTEop1vuAmyZY/6vYAJ2MNxH3yzvzTWUBj3px/kCapoPMV98W7nly0oa4wfW4L2seXGON8iRydvsrdLyYkqq6rIZwEfNC5ivw4kN+E7sAcE05Iu1XeesCu67oI62Rtk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199015)(83380400001)(36756003)(54906003)(6916009)(66556008)(31686004)(31696002)(86362001)(4744005)(2616005)(6512007)(5660300002)(38100700002)(186003)(478600001)(66946007)(6506007)(4326008)(53546011)(8676002)(6486002)(316002)(26005)(66476007)(41300700001)(2906002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Um9Wd1psbHhubHRCT2RJaXJSN0RKWDlNRTRhWDI5WUwrcDdoWEZpOHAzRlgz?= =?utf-8?B?S1VEcXNnUFhTazBhWm4ydEtpTGI3amF3NGpwcGxJUXVLUkhhODZ5M2ZPOGhr?= =?utf-8?B?dHg4NmhMa2R5VnpyZXZGZHpSVVVTSEpwZEpuMEFNZnpFREVXckpIY25CU0k1?= =?utf-8?B?RzhBdUtwOUZUaFJLVDNBRWJiWUh3RXBhRDNGVEQrRzNJRUlMWnlSOWJtaENq?= =?utf-8?B?cWxodk96YkpNVk9MajROek5Gb1g4Y2tRQWVCaytWM1FQZ3ZGMHYraUpQSFZJ?= =?utf-8?B?MkdRWm5heDUvcDV4WXR3WWpQazlFemtHVmQydUh0a2w5MkREbWd4a2Z2cllF?= =?utf-8?B?NXpscFpIM1BNcFdyczVNOFB1WVp5bkcvZHlyckx4OEMrOVZRc2lRdXp6VGhX?= =?utf-8?B?ajZLVWMwZGhOV01ZaTVsL3MyWVJMeUtkT0FGY2oyc1dyME91NlNkQXhGZWlv?= =?utf-8?B?S2hVNXFBVVBFREZweFRDbWpqRWgrbTFOem9qaEpaZEx2RWZnaS9xVTVodHd0?= =?utf-8?B?OFlmSDRiMjhzV2ZDeXhjVTdiZ0JrMllQMnYwRmMzZ1RTdzM4cElidWY1ay9G?= =?utf-8?B?ZGk1WDUrd2VBT2FpRCtFZ0syczdvTExPMXo1ditPNW5EUlhPKy9QZC9lV1Fv?= =?utf-8?B?NXBjUHZ4SmV3RnQvTGp1bXhFVzJCV2NCWDg0Z2lHU1FNWmJlRmJxZWJkSU92?= =?utf-8?B?TmdSMzVFbk0vVDBJZVZmVU4yOUp0eDVnME5aaXI1US9kcnRvb2VPZVp5dFdR?= =?utf-8?B?L2R4aWhkYy9XenVLZEJiN0E0cWZWZVVkbll5ZDhEamkwUHdNSktBc0t2ZHBq?= =?utf-8?B?cU51cVVCK3dyOWZoclZhbFNYSkJrMEg3SU5QbE00ZXlHU0ZwZ21RcW9BdFB4?= =?utf-8?B?Yk12MmZJR0NLYXdyV005UjVlVG80eVdtY0dHQUZTbGcyTUhjN0U0NVlKS2Nm?= =?utf-8?B?MEJGd01FZWtIWUJ5dFlJUUFsTnRGY2poZWt1MEVSbThRS2lOWC9iZko2Q3Zt?= =?utf-8?B?c2dKeUJLT0N6bXdUa0pZVE9qUzgrSjRpTG9FbysxMGpQNUlkakZ6alR0eTNa?= =?utf-8?B?WkhGMytKNkxYL3R1QXA0Syt4TFIvSkdHbkNOaGVoc1o3TmxBTlc5b3l6L29w?= =?utf-8?B?OFI0WldWRERoS0VMVGhBWGRhZ3RnRWdNenB4VjB0QnJ5ZzFQMjZqUmZ0aTJ6?= =?utf-8?B?RS9ZdUR6U2ZmSS83SmhMYW5zdXo5T3prT0w4bHdOUldxNFM3S0NGM1BackxQ?= =?utf-8?B?NDQxK0NLaThpTU9CNTNSNDdEamRhd1V4ZzNKVXdRMUdFak1JQzQ3UHkzQmJo?= =?utf-8?B?akVRRzI5eTE5dWtCL2FGZDdTMlF4YmNKeXJlRXpmTFNCZVVQWHZOKytPQzFW?= =?utf-8?B?RWdLbklRRDJmazQzT3NRYnVOcGduS25ES09Qb0FhK0hJeHpXWFd3dGlOa081?= =?utf-8?B?ZjBIYWtScjhsTzhVaWdmekd2YmhnRENqZWMxUk1CWlJ5bnB6OHp5L0tHemFy?= =?utf-8?B?aVFnSDJDMDU2aXJRRDBUMUNWQUVDc3RycmNUV3hQNHFlekhWY2xvcDh4U3BJ?= =?utf-8?B?SUZnSGI5S3Njbm1nRmduNmRDVFBnM3hNMkRYekJoWWo5YnlleHA0a1JlaFFl?= =?utf-8?B?eC9mczAzcXNJTE5mWXA4VnhpTktOZWFBVUNxQTBMa1FxNFA4TnVHK0htN1hN?= =?utf-8?B?aFQ0YlNjVlQ5dWF2Zi9IWGdheFJHOW1pYndjMDFUNi9aMm1KMVFjTHhISldQ?= =?utf-8?B?bXptVXUyMXpVR1ZVbWdRU2RJRE5weDFURG1xWlE3MTVUbkVqclRuOUtQcXZq?= =?utf-8?B?SW1oSUFzbEE4OU9vMFdQUjFXbkhHdVl3RU15MXZzZHlMaXZJZkxrUVBRcFNl?= =?utf-8?B?RC9oSzJndGY0NHJnVXpkaEtoQWJYZmZ1Uy9nbEpRdy8xZGZnVzZPUnpYRUlZ?= =?utf-8?B?RkpiV0V3bkFQcGNmS21FVkluLzRpek5ZYmtkNXlUVE5jb0tpRVVFaG05S1VN?= =?utf-8?B?ZThvNTJWT2YzSWtLMnNjVjRJcUdid2xsV2Y0NFpQclZ4U2V0dGtSYVY5cFR5?= =?utf-8?B?WWpLMnFFN0tHM1ZoRGZLeUVFRzVJZTNwc0FabFhFcnRsUCtsd1VIN1JVdE0x?= =?utf-8?Q?mR9/BMuerhsh2rEmNDlFoknrt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba2d7870-8c6d-4142-4776-08daa2e4c689 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 13:07:49.4568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mFHgA/fJbWQsjT6H0eJ0rkmA2o+07i41V8XNcou3k82Xx97Y34WwgM3PD1SLTLDpVrmvQOwSJzED5NzT7ep69g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8620 On 30.09.2022 14:53, Andrew Cooper wrote: > On 30/09/2022 08:50, Jan Beulich wrote: >> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME >> higher priority than the type of the range. To avoid accessing memory at >> runtime which was re-used for other purposes, make >> efi_arch_process_memory_map() follow suit. While on x86 in theory the >> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim" >> E820_ACPI memory there and hence that type's handling can be left alone. >> >> Fixes: bf6501a62e80 ("x86-64: EFI boot code") >> Fixes: facac0af87ef ("x86-64: EFI runtime code") >> Fixes: 6d70ea10d49f ("Add ARM EFI boot support") >> Signed-off-by: Jan Beulich > > Isn't this also liable to be the root cause of the crash reported on > IRC, where a read-only page was being inserted into the heap? I wouldn't be able to make the connection, I'm afraid. What was asked there was lacking details, though. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 30 13:11:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 13:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414225.658399 (Exim 4.92) (envelope-from ) id 1oeFnL-0007gl-W7; Fri, 30 Sep 2022 13:11:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414225.658399; Fri, 30 Sep 2022 13:11:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFnL-0007ge-So; Fri, 30 Sep 2022 13:11:11 +0000 Received: by outflank-mailman (input) for mailman id 414225; Fri, 30 Sep 2022 13:11:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeFnK-0007gW-1n for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 13:11:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5914f574-40c1-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 15:11:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4543721901; Fri, 30 Sep 2022 13:11:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 059E513776; Fri, 30 Sep 2022 13:11:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FC12O+vqNmN6OgAAMHmgww (envelope-from ); Fri, 30 Sep 2022 13:11:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5914f574-40c1-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664543468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FM4f4tXnXj3U/kFNpq1mFmA1c6yYY+Wn6io+sfM0N34=; b=tA0H2CDFor/7qw1oq9VkLVkn+QtmfE6XRpUSTlwmJi8bA8mgvk8LEyJhLgANYKDug9iBA/ obXTOKusKzvyz5JS2Qbm4uHRzqNGMz4BoSPeUp1/hrRxyZfUl2w5NhreXE/JCfu6u8F2Bi q70ZPdjriYLebSzLKDJe47X29Vyey60= Message-ID: <2e843e28-2836-910e-bcd8-f35872adf21a@suse.com> Date: Fri, 30 Sep 2022 15:11:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" References: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------bcOyG0ujFtoERu0bGw1r6lJq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------bcOyG0ujFtoERu0bGw1r6lJq Content-Type: multipart/mixed; boundary="------------E1J2klAWh1q7JORXFxdUMsr4"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Message-ID: <2e843e28-2836-910e-bcd8-f35872adf21a@suse.com> Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init References: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> In-Reply-To: --------------E1J2klAWh1q7JORXFxdUMsr4 Content-Type: multipart/mixed; boundary="------------r0LnBELVCjdRvxjqn4e77Bb0" --------------r0LnBELVCjdRvxjqn4e77Bb0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDkuMjIgMTM6NTUsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVGh1LCBT ZXAgMjksIDIwMjIgYXQgMTA6MjY6NTlBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFNvIHJpZ2h0IG5vdyBJJ20gaW5jbGluZWQgdG8gYmUgYmV0dGVyIG9uIHRoZSBzYWZl IHNpZGUgYnkgbm90IGFkZGluZyBhbnkNCj4+IGNwdSBob3RwbHVnIGhvb2ssIGJ1dCB0byB1 c2UganVzdCB0aGUgc2FtZSAiZGVsYXllZCBBUCBpbml0IiBmbGFnIGFzIHRvZGF5LA0KPj4g anVzdCByZW5hbWluZyBpdC4gVGhpcyB3b3VsZCBsZWF2ZSB0aGUgZGVsYXllZCBNVFJSL1BB VCBpbml0IGluIHBsYWNlIGZvcg0KPj4gcmVzdW1lIGFuZCBrZXhlYyBjYXNlcywgYnV0IGRl ZmVycmluZyB0aGUgTVRSUi9QQVQgY2xlYW51cCBkdWUgdG8gdGhpcw0KPj4gcG90ZW50aWFs IGlzc3VlIHNlZW1zIG5vdCBhcHByb3ByaWF0ZSwgYXMgdGhlIGNsZWFudXAgaXNuJ3QgY2hh bmdpbmcgdGhlDQo+PiBiZWhhdmlvciBoZXJlLg0KPiANCj4gT2ssIHdoYXQncyB3cm9uZyB3 aXRoIGFkZGluZyBhIHNwZWNpYWwgaG90cGx1ZyBsZXZlbCBqdXN0IGZvciB0aGF0IHRoaW5n DQo+IGFuZCBydW5uaW5nIGl0IHZlcnkgZWFybHk/IFByYWN0aWNhbGx5IHByZXR0eSBtdWNo IHdoZXJlIGl0IHdhcyBpbiB0aW1lLA0KPiBpbiBpZGVudGlmeV9zZWNvbmRhcnlfY3B1KCk/ DQoNClllcywgdGhpcyBjYW4gYmUgZG9uZS4gSXQgd291bGQgcHJhY3RpY2FsbHkgaGF2ZSB0 byBiZSB0aGUgZmlyc3Qgb25lIGp1c3QNCmFmdGVyIENQVUhQX0JSSU5HVVBfQ1BVLg0KDQpU aGUgcXVlc3Rpb24gaXMgd2hldGhlciB3ZSByZWFsbHkgd2FudCB0byBjYWxsIHRoZSBNVFJS L1BBVCBpbml0aWFsaXphdGlvbg0Kb24gaG90cGx1Z2dlZCBjcHVzIG9ubHkgYWZ0ZXIgZW5h YmxpbmcgaW50ZXJydXB0cy4gTm90ZSB0aGF0IHRoZSBjYWxsYmFja3MNCmFyZSBhY3RpdmF0 ZWQgb25seSBhdCB0aGUgZW5kIG9mIHN0YXJ0X3NlY29uZGFyeSgpLCB3aGlsZSB0b2RheSBN VFJSL1BBVA0KaW5pdGlhbGl6YXRpb24gaXMgY2FsbGVkIHNvbWUgdGltZSBlYXJsaWVyIGJ5 Og0KDQogICBzdGFydF9zZWNvbmRhcnkoKQ0KICAgICBzbXBfY2FsbGluKCkNCiAgICAgICBz bXBfc3RvcmVfY3B1X2luZm8oKQ0KICAgICAgICAgaWRlbnRpZnlfc2Vjb25kYXJ5X2NwdSgp DQogICAgICAgICAgIG10cnJfYXBfaW5pdCgpDQoNCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBh IHJlYWwgcHJvYmxlbSwgYnV0IEkgd2FudGVkIHRvIG1lbnRpb24gaXQuDQoNClRoZSBuZXh0 IHF1ZXN0aW9uIHdvdWxkIGJlLCB3aHkgTVRSUi9QQVQgaW5pdCBzaG91bGQgYmUgc3BlY2lh bCAobWVhbmluZzoNCndoeSBhcmUgYWxsIHRoZSBvdGhlciBmdW5jdGlvbnMgY2FsbGVkIHRo YXQgZWFybHkgbm90IHJlYWxpemVkIHZpYQ0KY2FsbGJhY2tzKT8gSXMgaXQganVzdCBiZWNh dXNlIG9mIHRoZSBzcGVjaWFsIGhhbmRsaW5nIGR1cmluZyBib290L3Jlc3VtZT8NCg0KSXQg bWlnaHQgYmUgd29ydGggYSBkaXNjdXNzaW9uIHdoZXRoZXIgdGhlcmUgc2hvdWxkbid0IGJl IGEgc3BlY2lhbCBncm91cA0Kb2YgY2FsbGJhY2tzIGFjdGl2YXRlZCBCRUZPUkUgaW50ZXJy dXB0cyBhcmUgYmVpbmcgZW5hYmxlZC4NCg0KPiBIYXZpbmcgYSBzcGVjaWFsIG9uZSBpcyB3 YXJyYW50ZWQsIGFzIHlvdSBleHBsYWluLCBJJ2Qgc2F5Lg0KDQpUaGFua3MuIEknbGwgd3Jp dGUgYSBwYXRjaCBmb3IgdGhhdC4NCg0KDQpKdWVyZ2VuDQoNCg== --------------r0LnBELVCjdRvxjqn4e77Bb0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------r0LnBELVCjdRvxjqn4e77Bb0-- --------------E1J2klAWh1q7JORXFxdUMsr4-- --------------bcOyG0ujFtoERu0bGw1r6lJq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM26usFAwAAAAAACgkQsN6d1ii/Ey8J zwgAgSAXDKiemWugJj/aDeRfSfU/ea6aRbt66SfEPZISqoadWEqq7HqpA6Wu/dT/U4eZvkFU2MzR Ksa7uxVqDuesv8O02H3lymc2XSB8vUFR3sBW1yQnHnaH7rnKZiK97q/McKuBgYOHzGTZxDAffpdw XpLgvwxyp+CnQ5lWX0OKaAzOCb88nr+PAuolzIDI6U74Dr+GJCoNSFdD83AVl1kkPk7P3zCrFo1n WkWpaRmiD6Nj8ccIzFGFOMZrrsUzHA/uuKjWI5J+WLFPTJCqFfqTS1mG038i6qG5zAANJqLNRn9a dSeT1G5MmH5wFuvnzLEgAvxO4W4f4SYumg3JOHibvA== =nWua -----END PGP SIGNATURE----- --------------bcOyG0ujFtoERu0bGw1r6lJq-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 13:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 13:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414241.658413 (Exim 4.92) (envelope-from ) id 1oeG1q-0001Ca-Ia; Fri, 30 Sep 2022 13:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414241.658413; Fri, 30 Sep 2022 13:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeG1q-0001CT-FD; Fri, 30 Sep 2022 13:26:10 +0000 Received: by outflank-mailman (input) for mailman id 414241; Fri, 30 Sep 2022 13:26:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeG1o-0001CN-W6 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 13:26:09 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6db0d935-40c3-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 15:26:02 +0200 (CEST) Received: from zn.tnic (p200300ea9733e70a329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e70a:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C59271EC04DA; Fri, 30 Sep 2022 15:25:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6db0d935-40c3-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664544357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=lp7hZW6fL4gPkdYmrpDiNF39G6gXzVijhgQhSUy+zh0=; b=Pcn8be89+VAVOJS0cfzE1/U0IVaPLFkQ9HorTbZuSeS7l+DUWA95HnMsYl1o+vezldXhfz TB0JHqgFCWgM/ZYj95/+5sLKmuOcoWlHI9gq12TYtXWDZ3l76bqJRXdlXEfI0otvyjLbmv WJws7lZZcATn54MEu2WjdWfl5QYuZK0= Date: Fri, 30 Sep 2022 15:25:53 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> <2e843e28-2836-910e-bcd8-f35872adf21a@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2e843e28-2836-910e-bcd8-f35872adf21a@suse.com> On Fri, Sep 30, 2022 at 03:11:07PM +0200, Juergen Gross wrote: > Yes, this can be done. It would practically have to be the first one just > after CPUHP_BRINGUP_CPU. Right. > The question is whether we really want to call the MTRR/PAT initialization > on hotplugged cpus only after enabling interrupts. Note that the callbacks > are activated only at the end of start_secondary(), while today MTRR/PAT > initialization is called some time earlier by: > > start_secondary() > smp_callin() > smp_store_cpu_info() > identify_secondary_cpu() > mtrr_ap_init() > > I don't think this is a real problem, but I wanted to mention it. Yep, I saw that too but I don't think there will be a problem either. I mean, it should be early enough as you point out not to need proper MTRR/PAT settings yet. But we'll make sure we test this real good too. > The next question would be, why MTRR/PAT init should be special > (meaning: why are all the other functions called that early not > realized via callbacks)? Well, our init code is crazy. Frankly, I don't see why not more of the "init stuff on the freshly hotplugged CPU" work is done there... > Is it just because of the special handling during boot/resume? ... unless this is the case, ofc. Right. > It might be worth a discussion whether there shouldn't be a special group > of callbacks activated BEFORE interrupts are being enabled. That's a good question. /me writes it down to ask tglx when he gets back. I mean, that early I don't think it matters whether IRQs are enabled or not. But this'll need to be audited on a case by case basis. As I said, our boot code is nuts with stuff bolted on everywhere for whatever reasons. > Thanks. I'll write a patch for that. Thanks too. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Fri Sep 30 13:36:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 13:36:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414249.658425 (Exim 4.92) (envelope-from ) id 1oeGBd-0002nv-Hj; Fri, 30 Sep 2022 13:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414249.658425; Fri, 30 Sep 2022 13:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeGBd-0002no-DS; Fri, 30 Sep 2022 13:36:17 +0000 Received: by outflank-mailman (input) for mailman id 414249; Fri, 30 Sep 2022 13:36:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeGBb-0002ni-L5 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 13:36:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id daab3ba9-40c4-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 15:36:14 +0200 (CEST) Received: from AM5PR0201CA0002.eurprd02.prod.outlook.com (2603:10a6:203:3d::12) by GV1PR08MB7731.eurprd08.prod.outlook.com (2603:10a6:150:52::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Fri, 30 Sep 2022 13:36:06 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::a) by AM5PR0201CA0002.outlook.office365.com (2603:10a6:203:3d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 13:36:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 13:36:06 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Fri, 30 Sep 2022 13:36:05 +0000 Received: from 2534b0f46798.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BBF45B78-C332-4517-A018-4C3637A4B9B1.1; Fri, 30 Sep 2022 13:35:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2534b0f46798.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 13:35:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB6580.eurprd08.prod.outlook.com (2603:10a6:20b:369::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 13:35:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::29d8:8cbc:8a55:811a%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 13:35:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daab3ba9-40c4-11ed-9374-c1cf23e5d27e ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=j0E8Aj23k9p9RmM1BVNGRYDOxgRxHSjFk2GaPHlJiilPiMqSToCwoUHADIUYB6KNsr0119CahAMI5wcG1l98gWFy4QNEvxsOW+HHpgmrg+Q45hCs5ko/kQG5AaHjameMYdCIxZZseXSjNKsHl2LilzdoV0dm2nqEOifgtKedTmEk4dtwKE9Yy4KdWsfeUi07Bcx7sThVZXLp5wjbQrm1lYtp2CicAi6l1j3v4C2pevraxjYinsKMZen3v+GONWYUxWL7JxjrTXVNs/ySiOiZUHCeRhCxvvldFTQSdh8jHleaI5tJzRRXBHZiH3hRzXi/5xlzV/6MCamvlN2rvWy+ZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9y+lBaMls16rVioLuUsn0KwrXVphZcG9st/d78u+DP8=; b=FQ2rVT+qHPoaUfvuedma58hhky7iDvPK1EVkjx7hawBoAcchH5gH8fASq51XC9ez0Tp3WiaBu8vRPOIjid/pDICE60koAo5PVy7wm5UO2mKSiI65UL5ZRNhwnMC9EShKXgRqQ6X3GyYy3f7SeYZEfltHMPIzBN4hHuH91QlMVRcgrOF1ujSzjxtQbODiUmte1VGTcnUiR2TdzDvG5ZhWl19Bu5Y29m6XMdu75Ci5QXt/UgB1RX0kwQ+kdQ7fJSzcuh6SuvSyTCfFjLHaioHslqM4ZZp1P3OKrdHpr7nzrqyUKtbhWTtpE+M29MVGsni2V/+YbuMjvvlXSj8WOG7oZA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9y+lBaMls16rVioLuUsn0KwrXVphZcG9st/d78u+DP8=; b=hh+hACxzVgOxPLJVL2tqzBgikdWcAP/E6+gyflnRrcKXLrcpd536Jfsp77lJEZWh0OvbXgKXZZbHumSns5dGQktpS0tnuaDFUASg0MK9Gs770u3xmiH3zlY9iNlNBZR1OKzP7/LuZdufoIbM5f9ohNvqcYj4k+h0A85y3mNZbyk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 43ee581f62df41a3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsW8GYKVLOb/jIixFNXrWjukyl6FShddFtmx1/Q9qHEnp2O1Bbr0Tqhv3/T2qyMYReVubV1YEi3dNAxl7FXi5/9qIokp56NmPM8EzAjl30hrowEUDxd6M1/3D1R/czmBAxi3QVpBDHuKmPIb7CmwI8gzBeS+PdzGgMOoTIkGdE2xFgW/10yjySMcB4dQ6/LEKsK2HqoVYWpz3FbtpIQ8wEQ8a/9VxJ4/g4EWkhP4LKVZUpplebxeDct+OX+DKfIA0yCqnut7jL6ebccJlD66PX+uEahbHkyOG+ciBVL48tgqIGt/00MNGF3Rez+8g+XjBt8DrCJpkTTy58RbsivGww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9y+lBaMls16rVioLuUsn0KwrXVphZcG9st/d78u+DP8=; b=bR4Fs+e6fOFZLliXD72lBR5slaAcFArXBLJQdOzJEdXbfFQ3I6ZYnd/oSlNXoysaPL/ynsmTydqaHTig4fAplSjeUmkCgwbtYLAr48EXA2G2niCy1aJceoT7Cbac8NInnLDVLqhVZA8cDUXdK/oHguaZXzu/V1EI8KFpF94h1HfXRqfB4scj3MnxvzTwG1rvf8MwfT83rLnJdM9jg5wROexNFDH5/b9ipbshDKQlkQ+QzBCdBM1hTbF4wa6agsjrGXGmNk+93ovuKO8E09JVipmC9a9FAGC2GqHb6rvJ4P5Aki/HWYndDcVocUayCwbVlpKyziM5bqmrg+N2iihZBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9y+lBaMls16rVioLuUsn0KwrXVphZcG9st/d78u+DP8=; b=hh+hACxzVgOxPLJVL2tqzBgikdWcAP/E6+gyflnRrcKXLrcpd536Jfsp77lJEZWh0OvbXgKXZZbHumSns5dGQktpS0tnuaDFUASg0MK9Gs770u3xmiH3zlY9iNlNBZR1OKzP7/LuZdufoIbM5f9ohNvqcYj4k+h0A85y3mNZbyk= From: Bertrand Marquis To: Andrew Cooper CC: Jan Beulich , "xen-devel@lists.xenproject.org" , Wei Liu , Roger Pau Monne , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Henry Wang Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Thread-Index: AQHY1KFdAull5ChokkeaXft6EPXQra337hgAgAALwoA= Date: Fri, 30 Sep 2022 13:35:51 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM8PR08MB6580:EE_|AM7EUR03FT005:EE_|GV1PR08MB7731:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b3d6d4d-8214-49eb-3e76-08daa2e8b9e1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IWBhi0yfHG/5+VGn22f0mhDU4VwuEuTkqjjyCZDVUJ7Lx7JKOTzKVUs38OA0fN4s2p/b35U5nxVIZiKzEcLJQR5+XTpvQLkyjrozsg8Jy8tGr/J9ZyzbbKOPvDsSKrTDovEUaWPciaMxhBzmVFKuToo2KfnPkydrXxNbQD2rLBfSOCJR7qujg6B1fkA0Fuon+PTbsf5SsgoHgVU3IzzQ5VbCcwqfEdB0TInddUMeD5YOAzktjrY3DfWmHX1StCS3lhZTBrx+OMQUm+OMueCHqJqSwiCOxOEN5AWy+W4RI386bO/W2ZxXfgbaaeOR0R544LSkVxNOAmsOJfdLmhxP5e36Nm8LMAPr+Y0zUQBwj8EApOJnpee0vFbcUPtO5r14G8tPVkfJQTo7u4V8s2oUqypEbJkQ4QEkqrFuRvlLKIjtBOBvPTOPGlIgrcyJWtdYpcV8+/gy2lOdVn7J49UfvXBZV1IflUkliwbUtHS503ji4rwz1GjHdAom2dn7TaKfZ73W/DT9K0ZhWF14d7TuionezinN87a9cgVqHgblhvMAlAjns4KgZLFZbeHGPNj8wdfUsSlDqDHhVK10zhRatYCxJn5BU2/z7mHMyNC22zeM7hSkHvRG8yDVwQFKypCee6sgVvP6TyWCO4e7zu4ipITE55Oe/FSZ2DcV13Rn9DsFe8QTyNrI6B0We2751xJ96rXkx65S1CawwpeCa54d4WbkCu5MkUSOo+aPITNWllmowOlh6BYLwn1j/3erpMZW4FHMCh143/nNSxvFnBhZ+r89xkZSgPYtwvtSTfsUHOQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(451199015)(4326008)(41300700001)(64756008)(8676002)(66476007)(66446008)(6916009)(54906003)(66556008)(91956017)(76116006)(66946007)(316002)(122000001)(38070700005)(33656002)(38100700002)(86362001)(71200400001)(478600001)(6506007)(83380400001)(6486002)(26005)(6512007)(2616005)(186003)(53546011)(36756003)(4744005)(8936002)(2906002)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5502F0C1115CDD498108F180601ACB22@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6580 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e7e02943-f62d-47e3-bf1e-08daa2e8b17a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qjebGNbTy634WMUYJrgl1ZoGyyCSgL5VsxWwcvYHL+kV9M9580ctTKz78Ctn13jZrARzKUe4ESGfDYBEHUunf2Ia+VEicVkmyhWCKlXuM2vLGlmV9x2ZsLhKfi7oNeXa+ouZubVc6lviCZT5rhD5XaYi4LwIGToDx/x+AROuw5a5RaJHRNQXD/FgCHYkwOv/y6P/C2iqRDEQmCeeWuQKWoVOQVovbqTp2sL219LmNmUzXbUfXVJAjQoro6oyCcYZz1aWIMS5qF7hAe58yEvPBfruKosYRNOClBw/CH/VR4r8BO/O5heE0CShSPbwWA2H8BaRXizYlnvYkDPz+5iVuTZ3JRRoM/kK3j0Olgv6x0KsGtuGLf5HYsE9xtkupdcVr9zp2UWRhtbY2uP5wKHfhv1ennt8AeFwYv/hul1+SJL+dPrn9Cn6bj+V9Hbzr+vlFNnvucnCnWvQB2LNttB7LuNsELYhkFiNcWNy6U908cb2AgOTA1/elsQA21FAmkcP4Du3styT3JqX3F07HmK+60wBBj1KQnA54g/JiTIvqOxFIUbgvi6cZUBBPRJgY5e6XJr3DCpBdOHZ4qgWT522DFojYQz0LRpTrX9xG1FeIv+v3kr39VebB/d2V+fU+sgWzPwU9QR27FOmS8iwootpODo16w+l8fwCuygEeH+yr4qgrnzezqndUD/Ivx9bsVA9aDeC1tFpi+kPWTHRe3iJeKezM+whXGuGScKmLeZdMVuvjGDvTENSXFHctw+2yC4xFaNqOPWhC6JrumBJE+HTYg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(186003)(4326008)(8676002)(70206006)(6486002)(478600001)(336012)(2616005)(70586007)(47076005)(316002)(6862004)(6512007)(26005)(5660300002)(4744005)(86362001)(8936002)(53546011)(6506007)(40460700003)(41300700001)(2906002)(54906003)(82740400003)(40480700001)(36756003)(356005)(81166007)(36860700001)(83380400001)(82310400005)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 13:36:06.0380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b3d6d4d-8214-49eb-3e76-08daa2e8b9e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7731 Hi Andrew, > On 30 Sep 2022, at 14:53, Andrew Cooper wrote= : >=20 > On 30/09/2022 08:50, Jan Beulich wrote: >> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME >> higher priority than the type of the range. To avoid accessing memory at >> runtime which was re-used for other purposes, make >> efi_arch_process_memory_map() follow suit. While on x86 in theory the >> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim" >> E820_ACPI memory there and hence that type's handling can be left alone. >>=20 >> Fixes: bf6501a62e80 ("x86-64: EFI boot code") >> Fixes: facac0af87ef ("x86-64: EFI runtime code") >> Fixes: 6d70ea10d49f ("Add ARM EFI boot support") >> Signed-off-by: Jan Beulich >=20 > Isn't this also liable to be the root cause of the crash reported on > IRC, where a read-only page was being inserted into the heap? No this should not be related at all. Cheers Bertrand >=20 > ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Sep 30 14:18:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 14:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414255.658435 (Exim 4.92) (envelope-from ) id 1oeGqT-0007kk-Ls; Fri, 30 Sep 2022 14:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414255.658435; Fri, 30 Sep 2022 14:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeGqT-0007kd-J9; Fri, 30 Sep 2022 14:18:29 +0000 Received: by outflank-mailman (input) for mailman id 414255; Fri, 30 Sep 2022 14:18:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeGqR-0007kW-MM for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 14:18:28 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd23ca75-40ca-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 16:18:23 +0200 (CEST) Received: from mail-sn1anam02lp2041.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 10:18:07 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6426.namprd03.prod.outlook.com (2603:10b6:303:121::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Fri, 30 Sep 2022 14:18:02 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 14:17:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd23ca75-40ca-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664547503; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=oVBivcDr06qSaBZ5ml9C89E83mR/cBbKZM2vlB7zlwo=; b=VLpgt/Tp+9vkWo3Uencg0Opl+lKDdJ3mMr0u1P0ffu5T5bRYFbNDTRot Ns09SjNWJuDco1nQUQeLFGquvN9nIwdbLSk0iiPKGiz7Om+4/4K5aDtsP Duir25Y6Z0lty9xdVQSEDPnOaZjWGPhOIdS12hkC+Rt+j4uDsmOIsLHSv A=; X-IronPort-RemoteIP: 104.47.57.41 X-IronPort-MID: 84231282 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hWokVK14EVjRqnVx9PbD5chwkn2cJEfYwER7XKvMYLTBsI5bp2dVn 2VMXWzSbqyDNzH2fY92Oou18R9QusTRx4VnSAJtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WhA5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVB3vtMGmIN2 8UbDzsJKRWnq7Kk64u0H7wEasQLdKEHPas5k1Q4l3TiK69jRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/K4/Zui4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWbfqSv21rWncSXTYpI8OYei3eRW3geBwExCEhQbTX2Hvqzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv neWm/v5CDopt6eaIU9x7Z+RpDK2fDMTdGYEbCpcFw8duYG/+cc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNs2uVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:tN/7MKnf60JbDsVOtGH7ZWbOxezpDfPDimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhRYtKPTOWwVdASbsP0WKM+UyFJ8STzI5gPM RbAtVD4aPLfD9HZK/BiWHXcurIqOP3ipxA7t2uqkuFIzsaCJ2JuGxCe32m+wBNNX17LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGg9HQjprpbTMPGhZisWC1/EWVwY+/NyLd8gYVUjtJz7tn2W /Zkzbh7qHml/2g0BfT20La8pwTstr8zdloAtCKl6EuW0LRozftQL4kd6yJvTgzru3qwFE2kO PUqxNlBMh342O5RBDHnTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZtB+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3MciFXtuYds99R/Bmc8a+L EENrCT2B8WSyLTU5nhhBgj/DT2NU5DXytvQSA5y7yoOnZt7TBEJnAjtbIid0c7he4AoqZ/lp v529xT5ddzp+8tHNBA7bQ6ML6KI12IZy7wG0SvBnmiPJ07Ghv22u/KCfMOlaiXRKA= X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="84231282" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMYiRb0O5Zn71KJz/eIohqSr0RY+a+NJkIeU8kgLK2gbpWx4wEYuga140uLED4BbhJPI5Z+4NigNWwOQc429G4d2iMuSytRUChkK904ShKvwK2nWsPy+62Q810nRIpY7sMhh12g/TFkeA+azfZJyxao8bkYo4fULyKishDgfgvCfJLJMKJK56pAT4VEzueT/1Zf7wH+71b0f8r+0LeUiN4k8NpOz/LhZausIK1R2PODMjKRSAMklrxYmmTcA7dKfW1X+AaVrBtpQZKNJOX+7ykIqJxBxgLSqBXONXYt1/HrkdozZxFC3JG7bUxH615N9i4A6aE9jBq0WnxE6MW5uPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j4P5LOK2FjEE0nC05OzIne4cDkC1S7mT9I06GQuHXkk=; b=HKCW9PdC2i40ul2g/XM9sNKGl+O/hWgGG0oE3JFL1DMk/7eHrlGmokX/hkqtuKCEvjjj0+ydujWjHiuCykbpEzROrWiPZ217yGZIDxNondSu4qH6g4QyTAuInEHmTQ7Orxiayq/05ELeQKp1BZNizPEWzZzNsWhclg3qHyikg++BdWGkLbhd4RKsEYlwSyYDRJnOy0LATkZWYpj/XOjVY4+GGMIzjq8GPzSatORM/xnH55c2dWNskRHyAOGtCya+HAOh6JuhAqG2Rsqlr93F6A9bToarC47UEr0DXlvsS45F0Qjm4MjOZwxDmaTY8sJMyjEdQrtMDbilW8hYddEv/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4P5LOK2FjEE0nC05OzIne4cDkC1S7mT9I06GQuHXkk=; b=DamFVzewKgQKBqvHaRauCT4FFcr9m/xULubJWpPwO+ECKhtwJwUwmdd86YaLYLdF6sNEUABj3d0jyy9bQkcIrr0mk5d8jBID1KgFXd6stjPWhnJBtKSI03aVD3gdvyb5/Ny7HRRTMPZQiGWs1GTjoYLSyKVHTwhOD4zdRSRRZYs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO regions to e820 RESERVED Date: Fri, 30 Sep 2022 16:17:37 +0200 Message-Id: <20220930141737.67574-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0032.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6426:EE_ X-MS-Office365-Filtering-Correlation-Id: 0645b985-7297-4f63-f5c3-08daa2ee913b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TWLayYEPdSXq4AV27btDCGKj4GgQ06OqZIYAiAFmCYbPGbd6/BnDLLQHIagSD4ndI8F4OcyKJ67Um2cIZvB6p9zgSIj1WE6zE8OmGqUiz5BHSt3raP9yJV8Th89/lGC1r0GZWicNlTh4/99Tbqw5Xy5sQJLWUV7Cs5AH406asGJDI0oMiYAWv3ym6RueRfLIXb1L1iS8SDTphROB2KX7voCU/qU9ViS42evDFiMNm5Dx4DD1dQl2ntBvLL9Me7f6Az0rr9pBZ3pO3uNsA1ixIWzp+EFSTxZ2qXzy/+Y7vE2NjG6k+NeLCGtn2HPsw3uzd60eiirw163pGiImLFkKwbxr3n5wdOIvA4fksLfIFXC56GFdqLDAEtumLJyF/wDtDlYfmFTKo7ZTXkFLiqa8IC6MvnR7t8mzcLNeniGL/hWZDMK/jWXFHGS0jpgBF6AyEGxPRNQrmRyoYuwjJ8XLM55EeV2t5tu7UHAz0jNQGuQgWdMB7+GIJfO3LIuPJrhMJ2l54tdtn0Wz148TeV1ry3KmN58lzuHGYs/WAB9DX/vPqcmG1QB+QqDUjHYdKYneKvywLGe5fo/upL79pEpoqXXs+PfRXiit36isNFIt4NkOSQ/N98fEOwujZ6f1yE02qNLc9MHt6j74OLdWVP8HwTJxx786MvcOgV1wwX5U6p2jH8Qp01VTo+XxBPiqnM6BGcSxZXD+2H33WGwAAqmwDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(6486002)(6916009)(478600001)(6512007)(26005)(186003)(6506007)(1076003)(2616005)(54906003)(86362001)(83380400001)(66946007)(82960400001)(4326008)(38100700002)(8676002)(66556008)(316002)(66476007)(6666004)(36756003)(8936002)(5660300002)(41300700001)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVR6bCtvNUVyL1FLZDVya2FBQkR4QlhUcGk4b3E3Tm9nWnhuWEpZYnFvMUF0?= =?utf-8?B?NW1sVEd3Y1d0djQ2SndUemJwbTlGZFBpTk9WTVFHZlVVMmVRYUFRYWxxcWFX?= =?utf-8?B?QVJ3WWUvTnZmdGs4WHRZOWJKREpGUndrRFZDWXMrenNkM3pIR3JmMW5TRXdP?= =?utf-8?B?U1Z5TEk1K3pqRjFXNEQvYVNCZ3B0YzU4YTdQOEhqVEphUk9NTGFyS0VET0ha?= =?utf-8?B?ZmgwOU45VnZRT0IxMEZZa1AyaThlQXdIcUNrVXhDUDF4bi8vVDA1anZxTnhl?= =?utf-8?B?bVNPZElNUHVlNS9kL0w1c2o4Q05DNzBhbzNpKzdxYWtPeVIzQ3Zid25pN2ZY?= =?utf-8?B?ODFpZnh0RVFGVk9QTHZZOG1BOVlCUUFsR3Fmb1JTSjRMY0kxdENwd29LZ3c3?= =?utf-8?B?TmV4SzE3cVhTQ2RQQ0tEUlRjRGVDY1kycG9oYjRLYmlVVXZxVUFMcVppWXkz?= =?utf-8?B?aXdkWk9mbjdpN0MrSU9nSHN2cnc3RFhyYzhDcEE0Ui9sRSs2SHg3L09CZlZq?= =?utf-8?B?bGxGMnJ1bW13bzJFeWFDWEZ0RU14c3lwdnVVcEpFT2dyWjVxTW5NVHp4ZWVq?= =?utf-8?B?Nm1JN1BqV1kzaXkrYVVYd0xBRU5Vc1JEKzN5NEZLZXdvM1N2T2xZNFdCZW5G?= =?utf-8?B?aHpXL1JXZitCencvK014cnZBbFU3dmJHUUFEa2YvQ2pRUmh3ZTJXQkczYVMr?= =?utf-8?B?THJNb2I3Q3lRQWYyeWh6OTcwSUY0bTVUN1djQmpTZVUvd3J1RndQWjVxemUy?= =?utf-8?B?WUd2bjZYRWc2UTd3aG9hNG9CbklBYkxMK2xpSGJEZFdzUUZ2bXVvUmI5VDhh?= =?utf-8?B?KzZHNzZEaFdvWFFGQkozTzVNN3dXYlRwQ3ZhUitjZ05kVnFHbXVVZXd4M3F4?= =?utf-8?B?Skpjc3E2S0pYY2o4Z2JUbVdWTE9ubllLbi94UGJKbWR6eVlWbGZ3a1UzVWtw?= =?utf-8?B?UXM1aUJaQXVxVDdjWXQ4WjlaOS95cXdTRHVqbUl1am5IczBvSlVpYXB0dEpS?= =?utf-8?B?UWhXL3l3RUZrWk4yaDhQYVRucVl6ZUxiT3RaK3M4bVYvajVrblY1L1NjblhS?= =?utf-8?B?RzRFVFdSemt4OG0zamJSVDZMQUhoNjRKR3Zsek10K1lSQXF0dU90a21ENExY?= =?utf-8?B?ZkhpMlVac2xOV3Evbk03bjV2a1Q4RjVsQ01iVjVBMitIa2FkakNFcEdMWElB?= =?utf-8?B?NWsyTUgwVG8zdWR4NUVzRDc3WVljaG84Z1p0RCswdmhkb25lT2J0ekVKNkF0?= =?utf-8?B?RGxUcDUrNDBvdEwwbm04a2hsOFJmV2tqMFJBWU0rRCtldFp6bnQ0b0pscXV0?= =?utf-8?B?SXRnRi9RY3RtTnk3cjZDRzlEUTRkVU9KSWt4WWFsQi9iYnVuaEJ0SUQrWktU?= =?utf-8?B?WnNFQXp3YmNlZ0ZMQ0xwMFV4SzdTZlVNc1FTdWg5NEM5bW93RStrbXNhYUsx?= =?utf-8?B?Z2V5cVFCN29NRUJqcjVxUlExZGQ3STN6ZzhlUlZOSzNYZk81SlAyb085V3lK?= =?utf-8?B?aldOZXVDY284NWU3LzlkN0g5Q2ROYUJSS1NQeGxNN1hBNTQzRDFKbmJqelJU?= =?utf-8?B?UGNkVlk0ZE04U1F6NnNyNWZqZU1DQ1RCL0haQWZZLy9MVGhiOWJpOUUrR2Ro?= =?utf-8?B?THN2YitjVmhucTh4YnJ4dU1BbjZ2Mk9lMkt6LzVGNVZhUURHTmJSYWVhNnU3?= =?utf-8?B?WkNseEtLeS9ndkVTMWttVUl6OEZrb05aUXdVTVZKZVBPcjJ1dXVuTEthTkc4?= =?utf-8?B?YnBKQWxPTk5hRkVLUEJyck40a0o2TUdKYmtGMkxUdElnbWFNYzh1cXVNdWdk?= =?utf-8?B?N2pCTTBhd0FUOWhUN1FYSWNFZmZyWFRQcmpTN29UaHNoYzh4S1lnaFR0dkJ0?= =?utf-8?B?WHd6Vm1LcWNFcGlveURyd3FiL1l4UjZqQm9ZWm5NNUFkaldsUEJYZ05tdE9E?= =?utf-8?B?L25vNnBIeEdPVUQvVnAzd2MvWDQyWHpCcHFRUWF4R3BGb2ZYVExMUjgxTC9W?= =?utf-8?B?OUw1TDlRN1E5amZpRk8yZUt4TGV5a3RBRTUxUUt1cjZhK2lPNGlFbnIvV2pq?= =?utf-8?B?VVI1clhxOThhRDA0OXFXVWcrTmU1L0V2VjBUeXk0MHpUd29CaE5rUDBXR2hY?= =?utf-8?Q?sXJYCNt1qhTwXbmFeHIv2aK4x?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0645b985-7297-4f63-f5c3-08daa2ee913b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 14:17:56.2792 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Av1mww0o+RvYKGOMSN+nrCWAHBZAzS8xVCi8lpU+YcPpdi3VDKYFyQ55kqm0owYLCmfrhFtrpnQ0YCutsxpbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6426 The EFI memory map contains two memory types (EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace) used to describe IO memory areas of devices used by EFI. The current parsing of the EFI memory map was translating EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on x86. This is an issue because device MMIO regions (BARs) should not be positioned on reserved regions. Any BARs positioned on non-hole areas of the memory map will cause is_memory_hole() to return false, which would then cause memory decoding to be disabled for such device. This leads to EFI firmware malfunctions when using runtime services. The system under which this was observed has: EFI memory map: [...] 00000fd000000-00000fe7fffff type=11 attr=800000000000100d [...] 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map The device behind this BAR is: 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09) Subsystem: Super Micro Computer Inc Device 091c Flags: fast devsel Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well For the record, the symptom observed in that machine was a hard freeze when attempting to set an EFI variable (XEN_EFI_set_variable). Fix by not adding regions with type EfiMemoryMappedIO or EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to be positioned there. Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned') Signed-off-by: Roger Pau Monné --- I don't understand the definition of EfiMemoryMappedIOPortSpace: "System memory-mapped IO region that is used to translate memory cycles to IO cycles by the processor." But given its name I would assume it's also likely used to mark ranges in use by PCI device BARs. It would also be interesting to forward this information to dom0, so it doesn't attempt to move the BARs of this device(s) around, or else issues will arise. And of course the device must not be passed through to domUs, as disabling memory decoding on it can lead to a host DoS. Not that it makes much sense to pass devices like the one above to guests. It also makes me wonder whether this playing with the decoding bit that we do in Xen is safe. It might be more resilient to only disable memory decoding when the BARs overlap a RAM region, as that would indeed cause issues. We should also consider moving away from the e820 and instead using the EFI memory map for things like is_memory_hole(), but that would involve translating e820 memory maps into EFI format, which might be easier and more reliable than the other way around which we currently do. --- xen/arch/x86/efi/efi-boot.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 836e8c2ba1..12ad94cd71 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -169,6 +169,14 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable, switch ( desc->Type ) { + case EfiMemoryMappedIO: + case EfiMemoryMappedIOPortSpace: + /* + * There no suitable e820 memory type to represent a MMIO area + * except a hole. + */ + continue; + case EfiBootServicesCode: case EfiBootServicesData: if ( map_bs ) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Sep 30 14:28:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 14:28:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414264.658447 (Exim 4.92) (envelope-from ) id 1oeH0E-00011r-Qj; Fri, 30 Sep 2022 14:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414264.658447; Fri, 30 Sep 2022 14:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeH0E-00011k-NO; Fri, 30 Sep 2022 14:28:34 +0000 Received: by outflank-mailman (input) for mailman id 414264; Fri, 30 Sep 2022 14:28:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeH0D-00011e-NO for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 14:28:33 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26e916af-40cc-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 16:28:32 +0200 (CEST) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 10:28:27 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6677.namprd03.prod.outlook.com (2603:10b6:510:a8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 14:28:25 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 14:28:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26e916af-40cc-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664548112; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=yN8aX2w6ysv9gmyusSCXRZ8DxvHaYjoSo/jbbLk8qS4=; b=HiA+4RkYoi4jpDGbQAnjWYg/ewL/V4sZBXEKHV7WeLfGTc4SfBlUQsmN 4z24+gNbMwGzJIKt9oWaab/BEw3lS6E6bqbMo+jXCOSxgnCrnQKHo9GSo A62VUZT0ANKWa6TE9FAljkbHDmlA+jUlXSTYV2YLRa2NB5yG/9I5QgH5q w=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 81704191 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:TDaCMaIF9JurQFdOFE+RRJQlxSXFcZb7ZxGr2PjKsXjdYENSgzVVy TcYXziPP6yPYGGmKIx1a9m19htUvZ/Xx4U2TQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj42tA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fb9J071tB1hqz qQRczcqbSm4l/i60YvuH4GAhux7RCXqFKU2nyg5iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T/PVui4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWPaqi7117ancSXTSI1LF6/i5vpRvVCtlmohLgY7flCwmKzs4qK5c5cFQ 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neWm/v5CDopt6eaIVqf67OVoDWaKSUTa2gYakcsVhAZ6tPupIUyiBPnTdt5FqOxyNrvFlnY3 TeOqyQvgqQJusQC3a674FPvjiqlo97CSQtdzg/aRH6/5wV1IousfZW16EPz5OxFao2eSzGpn HUCgdnY0+kIArmEjinLS+IIdIxF/N6AOTzYxFJqQZ8o8m30/2b5JN8JpjZjOE1uL8AIPyfzZ 1Pesh9Q45kVO2a2aahwYMS6DMFCIbXcKOkJn8v8NrJmCqWdvifclM2yTSZ8B1zQrXU= IronPort-HdrOrdr: A9a23:q8VeZK+nROn2tnuLlPtuk+E9db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlGl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFfJccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiT7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri+knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYd099RrBmc8a+d RVfY/hDK48SyLaU5mZhBgl/DWUZAV+Iv/cKXJy+vB80FBt7QNEJgUjtY8id0w7heMAoql/lp v525tT5c9zp+8tHNdA7bQ6ML+KI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA= X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81704191" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GLoqPYdS9HvAqttfBdixfa/FGkRKO4GohRKI4hPA+sKCe0IhqqLJiSIrhCubsiSX7EgduTxC9JZNBjl++IgHxADM1IeY1KJMa/WhwS/oBnGx9/LLxaUNtaNt+RdNUutrZ/46+lYCxisgT3qxTTb1881zjtKgjNikVkToA33DAwx7Qbs5cSzfPH1rX4e009JLxKSd2feSk5DbpE4BjaswufLx/FckuxNlqBsf1uRmoVI5lQqB0t6APqZG1lYNRMpiOkoye9HhpijELgAcrZi0jQRhTDOEgHxdxINoC3WtzKfrQGpzkaFdpLhGjDETxvOst7ZtrJMd1YHD1EoRO2eyiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xwhTf2lz/q61mjjxjbo1LO93Bx7bYXQd6Hzs+E5lv/o=; b=NtyyJHlBr5NKSupaoRaYrD2678NL9RJtsn7ZHudC40PcndmXo4yXOGgRmgo02yjUUdEyE1qXcQnB6PK1G2IA8Srm/MzytUxw0hWxYZ+nx+t2SaVcK8p0NTFe1AH+dyi9KtUjyyOFPM2nEARyCN6I9VlW61TABP2VSHRRD+RUcowcrEUMOPiilzPj7f8QPSxUyAgME5YpT6SZHqiFPznbBnSkBrrx4RSo66A+6dAE6SXidejtYe7QFBDHn2jVM9Wy65ovzYTLYw5/l1RDYyXW5DHknWtp1cP61JQOQBvEp24l2EDVaDhBTRTBUSKZKjG4pt9t6LIfrY68DyHhR8Z4JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwhTf2lz/q61mjjxjbo1LO93Bx7bYXQd6Hzs+E5lv/o=; b=w5TmR9HmZmaqc3cuf67XopjZpu/Xys8ynmiZqLB4APJBT15qHtmvozgiFjUpYxAK3dfQwOCducqBU/MKsI1A9v6ee1KC2r/4sqPfc/AIDTNq1WOGFbw4dbV6lpjSLVMgVGhD/EEgS9BPRNaQCkjHi54tPm794KnVYE5yS++V2jk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 30 Sep 2022 16:28:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Henry Wang Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0147.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6677:EE_ X-MS-Office365-Filtering-Correlation-Id: 60782ad2-fba1-49fc-8921-08daa2f008a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eG0y9hnBU8B/JBeniYurLiIQKKOuNTuDmUeiDxmV0EyoDiSuXYk2fhNFJVTN3bflFUbAYZbE/ndnKEaNzmyscJdUzsgVslO7xZ5a+MsarnfiV+TJgHFgeLIi5+vN+UpR1YhpgtEDDtWvT2syZR5X0WtIKL05PP1LCOtKXECvRXDL3jJhxGMT331CfjdDkY7qrtArLdW9ilgF4kkxolEeJ0nlpL64d7NwVstRZmPYfL1BvigZv3go7Kb4ihERhPfuEzyXR4LPbAEWm4Ag+Wb0hL2KlRf6rNK6x1PsaRyt14kTQlCeb4zLrFVqj+wy5mMvCI24YN+GccFBmXoaI5O/tofljiEiDeTfdqiZWNNKGpGE7gX4DapxNtH4EJuV+03OM/P5FPol6q2pb+Am4Fxni0cUX4dC27ui1obwgHyXS17sLQE2baR+sPMoa5N/4xOS+t9pqGKTFgMlOpI6DOFzTbVsIjHIvYNBngUbGkqJQ+KneN0xUU3uEPCuQq0zGZVBY+zV9aNUkAxeHQMftBkQydZYE5WG88vwYyo/wUdRC4fWEgUF4BHj9P/7E9OsGkY4NwrhWSczULuBPwZ6zbOV6zrcmCCMnT/iqEsHCrEn/UAtX6Hk0Nx/1bdnQkWGgRDmUkL6PzkyC8r7swhg/XTS01EWU+aJImVqMVuK4rrKDbwhHiaGVqrQrQDvfKq+GVy7JLx2hEHExEwVCYC+i/yRcA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(346002)(136003)(39860400002)(451199015)(82960400001)(186003)(6916009)(316002)(66556008)(54906003)(9686003)(26005)(5660300002)(6512007)(6666004)(4326008)(66476007)(6506007)(66946007)(85182001)(2906002)(8936002)(8676002)(41300700001)(4744005)(38100700002)(6486002)(478600001)(83380400001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0hWNFBJS1pod2l0VUdxVm5ZQ0xRWHpkaWtSM1p3WDYrQ1h0Ymg0U2d6M2FS?= =?utf-8?B?LzF1RDE1ZEVjY2pEK0wyYkZCOElqUEtPdjFMS0hmNi9RWGV5M1M4Nm11dFhH?= =?utf-8?B?dWo3TkhQT25VYjlTZWNSUmE4V3U2TWpJcUh3djdKQVVQT2hPbWVqNzhjbjRL?= =?utf-8?B?OW8zbEdsanNSckdCdHYwVzhQMGg5UjVuT3ZBUmZRUUhMeVUzRUppbEk3K0Mw?= =?utf-8?B?WHZiSG9ib1dyQytaeEd3ejFRSDhPYlJVM2RLc1hsVjI5TEVISzZMdnlPWXJp?= =?utf-8?B?VXp4K2NwVDNwMEVmZlBxcEd2WG9vc1liRjcwYUM0N2l6UmJXTUx3d25kNTBT?= =?utf-8?B?dzJmSXNNbFBEZEFwNXV4dEpjNFVRME4zb1VTZW4rMUpHVEZGbFVUeEMrdlU5?= =?utf-8?B?b2VHNi8rWFJXOEpDWHJZV2MyK2dDei9yeHhvRStyZ2VUNnNxbDFra3dNMk1C?= =?utf-8?B?Y0drcXZmYXlaT21TQ0t5TjdBdXhkeUlsL1FFSzNmb2JodW1NUDhtTDFwd2VH?= =?utf-8?B?R0VoNnV6QmduYXNaYU8wNWdDaGVFZTBNNnNVUTFEWmVDU1lBRlgzVzJ5UkRq?= =?utf-8?B?ejNKZTR2Um44MFhjM0VvMmlJSlFrM2h6K01VOG9pcjM3Skd3SVdhY1hhYWJv?= =?utf-8?B?TmFOOXFWbjJwUUZGSTVuYzBmNVdIbUlZeXVlcnJpWldGQWhwY0JQZG1kMGw3?= =?utf-8?B?ZDlNdnNNcWdVZlkrdWllMGt3aHZmUm53ckd0bS93MTFvcUZsN0pGaHFrK2VP?= =?utf-8?B?V0w2RXRCZUVZQ1ByUHFKNmZ5eWluZXJRMFFVWHJRUW1uZ1NhV2w3STBkWmV5?= =?utf-8?B?Q2ZBZTlpUEIwUVlWdHZHYTcwcU02REZXYzJ0dnZqS1JtNXVkTWtnU0hkcmQ3?= =?utf-8?B?bkhrVDZlZURQRmFwUnhCZ2srRkVMRGYyalRnRDI3RWVKTkN6N2xFK0JEUHJo?= =?utf-8?B?NWN6VlVUNjJrcmpxK21VZmVFbEJ1TDYxU3FRS1oxaG9vL0Q4dGlHTWltZVVC?= =?utf-8?B?ZUNHc2xVcENITjlhZmtoVzBuVC9Cb3ppZW1ITjVkUzBZOWJkdTY5YXI2dmtz?= =?utf-8?B?NGt2bjNQdXpxdC9EZ0dST2dKbnJ2K3JWYXVUaFZVR29rYTVsYXF1VGZQbE1I?= =?utf-8?B?cWVpVnJUdDNheUloV25OSU1qTEl5Q1UwSklIRTZzMlZTTnlSTWJJRW83Y0xV?= =?utf-8?B?RkF0UTZqMmpETGVSSzcxWWF1dGhhcFZXUzR2OWNndUQ5aVBsdWI1SThZKzlr?= =?utf-8?B?Ym5JcXRRelhpQ0ZveDdiemtBMDRNbjJVMXNvMmxYOTh5ZnluRmFDVTNDcHkz?= =?utf-8?B?TVl0VmYrTkRGdHNPcktpOEJKTVRlTE5LWmlSbnpzcXFOUUJETEc3eEZYQ0l5?= =?utf-8?B?V1lLcjZGWk96Z1B5S2hBRmFRVVZOOGY0cnJ6djZ6RUVpK1FpRzVTdjZSU0FO?= =?utf-8?B?a09uQ2hSZXljdWtwc0NzLytzQWZHQncyR0luOXpNdURjanltRFAxRFF1M1RJ?= =?utf-8?B?ckVGMlUweThQTEV3VTRkajMwaE1jZHUwSVRPamVuRTRSVnZ5SmJZSGxtR1BZ?= =?utf-8?B?cWdsLzVmUTRXbmJ3YUxKYUljdnBLdksySjBKYm9mSmQraUFydlQyak1sYm9J?= =?utf-8?B?L0praFl5L3lreHB2RmNCeFRob2t3SldYWUw0bi9vT0pzYXJ6RWNtaVR2dVdV?= =?utf-8?B?U3J6aFZNekdSTjhFRmpXVE1aRHlkQXIwRlgzVzI0L2pYbEpxZlljUVJ2R3I0?= =?utf-8?B?TWo5R1RXazZhbnZQUzMwYS9NbnJkZ1hsSS9zVUV3azB1ZU1maU41NHlFamdQ?= =?utf-8?B?U2xXcUV4NGRPRGRnQkY3NEhVejQycHJyOEpRcURlc3hhZFNEbEtnKzg5UlNu?= =?utf-8?B?Nmhpa3IzaitrWXlqc25UbjRFc0pIbjZOaUR6M3U5KzlrbE9lcVNYTk8ranJY?= =?utf-8?B?RG1zY3N2TDdneXdSTmpQN1JRVUl5c0ZpK1J4QzBXdlNLN1E0Q1gzSU90TzJs?= =?utf-8?B?VDB0WEZVcGJaQXFmYUJEOTRDV3AyaUo2eWpnSCs2cFhqNDFQS21BdTRJNFgz?= =?utf-8?B?clQ0NHdwOE5vRlh6V1oyQTY0R1RhdTlmaUh1dWZqU3U1c2hhT3hMNWN0U2JJ?= =?utf-8?B?UlBKNTBMRXlnNGRqYUM4Q2M4ZU1ERjJYQnk0SG5ra3JXNS8rTHBFcmpGOExR?= =?utf-8?B?OVE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60782ad2-fba1-49fc-8921-08daa2f008a7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 14:28:24.9113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kkSILGrbc9jS4unwl+2Sar2Ns7D2uGWy+6bi1ofAMxDwqEp5cnc5YcdbGvtWPsn0N/M/aWzC3fjEXsrDqT6LFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6677 On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote: > efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME > higher priority than the type of the range. To avoid accessing memory at > runtime which was re-used for other purposes, make > efi_arch_process_memory_map() follow suit. While on x86 in theory the > same would apply to EfiACPIReclaimMemory, we don't actually "reclaim" > E820_ACPI memory there and hence that type's handling can be left alone. What about dom0? Should it be translated to E820_RESERVED so that dom0 doesn't try to use it either? I guess using E820_RESERVED could also confuse dom0 about ACPI data placement. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 15:00:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 15:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414271.658458 (Exim 4.92) (envelope-from ) id 1oeHUY-0004p1-7k; Fri, 30 Sep 2022 14:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414271.658458; Fri, 30 Sep 2022 14:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHUY-0004ou-4q; Fri, 30 Sep 2022 14:59:54 +0000 Received: by outflank-mailman (input) for mailman id 414271; Fri, 30 Sep 2022 14:59:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHUX-0004oo-F6 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 14:59:53 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 879e5f76-40d0-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 16:59:51 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 10:59:43 -0400 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by DS7PR03MB5639.namprd03.prod.outlook.com (2603:10b6:5:2c6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 14:59:41 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::fef5:dc53:67d3:3498]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::fef5:dc53:67d3:3498%6]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 14:59:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 879e5f76-40d0-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664549991; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=WMQpZm3HSu3S7zdP39USfEMSqo83saX/tKwg2Rhrdms=; b=T+KIg68z8QAXkcb0c52aBIp3wiljIMdI9a/QEXw9HSADPkjKzyk5UvrM v5lQ24aZCZrSSk1Kiboje0RQiUDSUWAhE6UO5xUgBEs/Np2U6MaL0NEO/ PVB5wZIBs9vh23W4HoOZU3Psq4rnw6b/2ThfpU53kL/U9wk0u5uOXoZa6 g=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 80841302 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FcLgmK1sgS8BTWb2s/bD5fVwkn2cJEfYwER7XKvMYLTBsI5bp2MHn zdLWWvSb66OM2T8LtsnaYm0phgO75SGy9A1QFc+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WhA5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVb3uBlXm9K8 sU9NWEqfE6bhOCn6Z2SH7wEasQLdKEHPas5k1Q5lHTzK6ZjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/F4/NpsgA/zyQouFTpGNHVYN2RWcRcmACcp 2TK/mvRCRAGLt2PjzGC9xpAg8efxXOnAdlKTtVU8NZGowSV7z0XFyEQbku/itCAj3CUaYNAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpZNU4uecsSDct1 1vPmMnmbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICUCHQ0M5oC6pJlp10yeCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:bw7jka6F9XRANusjXQPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCfx+g4uuspx37 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE6EbLAYYo/gNiuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="80841302" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFvcqo/1w+EvbDM0TFtnxi0e5RF3cRHUooUtf8byMwQOMMYfURUf2ntwUAqS0sykI8AveK9tDBaA9sXJiOeXXy1ygn9p5enKsUsLdJRjmECjxwZC7+qKKJ05zKDmpp69TAc/0Lz1fIbRRRPTzoYumyukp2pVeveMzdIrRVTBKwJjrxMCxin/XRCf3/xrT2gsjo9tZHGZQ/aE8WuhJwd++JFPMoGXXr6abcH3V21wByUe24QAWwKifbDDeOaTqJXOfGZGBEVkHz1BqAYV33F3oQGm8e3pgCBpBnADPRStDBiNTDRlcZqrk8zAZ/pMW/Dm4eDkdK0AXYIemVFW1CZE0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMQpZm3HSu3S7zdP39USfEMSqo83saX/tKwg2Rhrdms=; b=WKRnCjA1qbQ+BdwNUDzL4Lufv1IZ3MDCoTDJA60GMCPS5rIVDauM3ck+dGS2T3ULSYhYmnhVqEwu04cor/Lu7aebh2K6QH6csPefIDoolDzqwPUweST1qm95MaFwAazhup1LsxtbLjnKm9Uk5i8FaRj2DFr8oO4kg1Ueku96pElSxYGRqIunAEX4i4V9cO66aFnKVYHziDdDnz++BhQxTO3OB4nrxq5ijMjY2T6b4ibb+eG/PSX8jNGJxCM3teWD2Sov0UH3T0JYCYryxp3in0AXjxESlHh4Lz6Up4iWOuGIoWouYhFIYCdWtmQhrsz3K1aohbKV/8g9WrkmsUtJUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WMQpZm3HSu3S7zdP39USfEMSqo83saX/tKwg2Rhrdms=; b=JSO7KkbaOnQXMEG2XX+LomiIJmKxNQkfl3xGF3VUU/MhVlNakXm+Jsk9YkUsaYXydt/051xMPICd4KkRmg02bvpDJGtS3oI5FdL7WjVTof8PT3YDqerbzF4a6KI4nNsH0O486cgChJnzmTyzo2Iv1a9RWG6XX2AjiI7HAUi37MA= From: Christian Lindig To: Edwin Torok CC: "xen-devel@lists.xenproject.org" , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Thread-Topic: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Thread-Index: AQHY0mKHZPP9Gr0D7k+Nf4GjgykKFK3zc0sAgASidwA= Date: Fri, 30 Sep 2022 14:59:41 +0000 Message-ID: <18C55ABC-CE37-4740-A516-86D4FCE83EC6@citrix.com> References: <7b88cbda20e068bbce1c5dfb0a18af3f4e4b6865.1664276827.git.edvin.torok@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|DS7PR03MB5639:EE_ x-ms-office365-filtering-correlation-id: bcfd6267-74db-48b1-2884-08daa2f4672f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8NKUDInmOY/FXmnnJUvN+N0C1mYpyOO7HxQ7zAIY5jNduhdBEJE0BfQO+6AHjya11eyD7YErCmo3WtiJW9KVS6ZCUu4ZoI+hx7ovEKjEPCAAlCl5zxAIfZ8GACgn3RQhY886S9yjtC37M4rG3l7X9oD36XU1HCU8zgq6BR+d/XgLFTSj+7QjUNvvygp+SbeDEmKu7M8JbgKgXh4dici1W3LA9Jar3mbv/RcJfvjZYdUNqc2kmPcp2KY4jByaIlSEW04PgETh1IKD3HPJve3K5GX9owKcmliOfbMdzk88YHvoFh+pEd+jFiWuSTJs8yJbgLtJwmET8DBNIOFtd6UQ0ipOlW+RSQggd2fhCkGgg8EHfZYGa0eXNbaAzBVD7m4xnwiNF4txnUxVZcxfkX9/BVPL6x9KqaiqMf2XmbnmcnBZWWJDHFwyjuoYjwEU41EhZhU5d9ejEc33dnqr2TFeM++1GyKbhZZ3+YCLLPzv78cHop6T+VX86zO6X8fOSYlvdqU6s1wMYJiDlItQz2DhdOUBe97Erz62ZSrF/My0eO9IcqvLtLFGACr9wHmqpppJoIKeFJLn/n3frvwLBEVFdUwxdkiRxiGkHxeTlVyfvX8puDOw904Ngf4hQzjUJaHVFGEMiSMKv9s0HbaX8JFklzo523jlbd/wgeoOyZ+uzTB10g8+zzm35rZqR5G7VY57+9DEfDgz0AhNcSW4R0V3RYdvAutHWhJY8pLjjZwLOM5ft+BWA1A0KcVBsp3RSZF4pBh8cNgEbkVbYhAAgnlGkkduSxQug+q+26SiOczPwsWA2R/cS4NlFeS6x2G0qSrLIkX1cpQi6QSzYVG3WWysuw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199015)(82960400001)(6636002)(122000001)(2906002)(76116006)(6486002)(91956017)(66446008)(64756008)(66476007)(66556008)(66946007)(4326008)(6862004)(8936002)(33656002)(478600001)(6506007)(107886003)(53546011)(41300700001)(37006003)(316002)(44832011)(36756003)(54906003)(6512007)(8676002)(966005)(86362001)(26005)(5660300002)(186003)(71200400001)(38100700002)(38070700005)(2616005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YXN0K1lMekJNa2lQR3hoUGduUkRIVUp5bnUvZ0puYW5kNjVpY3RjY0llSk9Y?= =?utf-8?B?ejhWbzUwMEhZZVJBVEh4UjBjZzB1YkZzS2tkNDkra0ZxNUVlKytzYXFMR0kx?= =?utf-8?B?cVlLUVduZTcvUUNMckp1S0VDVjdBVndmR0V5YkxTclNkWlczTFhrU1JvVWFF?= =?utf-8?B?TnY2MmVveno4d2dEK3Ezc280eWVLVS9nYTcrcU42ZFVpYzNNUHZFLzN4WjVx?= =?utf-8?B?YjJuZ1hMWnlvakxOSmtNc3VIS25NVGlobEVPdHI3S1JQd0V0YlpYUlVwcDY1?= =?utf-8?B?WEdHQ0JXTitIWllpcFN5Z2pmbm9wR0U0WGQ1ZlB6T3RmbmhTM3BUelFSakJJ?= =?utf-8?B?cUFoMWFDTEduYjRzcGUyQWJoT3ZWU2ppN1lzSGVNRW41UzJIV0xhd1NIYVBn?= =?utf-8?B?Z3BVbFViMGpFbDNSaVdhQXNvNTdNM2NDLy9zUUhxaUwxbmc1ZDdvbXlERnpm?= =?utf-8?B?dHBnVXZvbzVHMUFIS3h2ME1NdnZRckJOeG5TZ2ZGcHVIVGV5ZTRxK0NBdTdQ?= =?utf-8?B?anFqSHRlRDdPRWxEa2NFY2JqeWVOWmdYYlN2OVV3eG9TMTdZRmtlbEtsRW4r?= =?utf-8?B?SU95dUUrZFhPS3lqMjZNTWJqVGdRZndFYldSVXpvSHJhUTVFMnpGVEY1UzJS?= =?utf-8?B?YXVkNG8vZC80Nzk3MWc1ODU5S0JRRWgvOUtBK2lzR2VsaU1tYjd4cVFnTjJZ?= =?utf-8?B?ek5xZ3VOb0JFcG5xeHowcmM1TTN0VjJnYWxuZ05QdjVGM2Z6U3N1bEtHdzFC?= =?utf-8?B?WUxpZkl6d0hqRWRNTUpjWVRyaGI4a1lZVWVRYTdrRWRHZXhxSU9NR0hTTDF0?= =?utf-8?B?enBsNWlMVElJOUFFUHRYd2FUMmNnZVR2cmhFTUtzNDlvQTA2RWx5YlNRdkNv?= =?utf-8?B?QXpMYWZTS0ZmbW9YQzRxTmh4ZXV0VFVJbzhwb2RVWHgzVWsweVc5ZEJEb1ox?= =?utf-8?B?bVFxQURtN2NaK1ZxclFMaUM2dHF5RG82Y1d3aSs0M1ZVMmZCREtHRmR5MDA4?= =?utf-8?B?SVAyNXlpVFRwRVhrTnpUazEyeTdJS1JMNS9qeGk2NUE1NFEzei9UZU5Tc2Ix?= =?utf-8?B?VVFTYnFSWTdlMUk4MkFSVVNkMEZLbXhqTlpjMTRudGoxQUdRUEFhQUlPVGdl?= =?utf-8?B?bTU5RHA0VldqYXdBaGV2Szc2ZEttL1lQVUlHb2E0WllJNDZhN282ZE9DRlpH?= =?utf-8?B?UmJlZnV4cXhPanlkNytOMGdKRm9HZXhDOHh4SmppU2cyZFhuR2FJM0lGNXgy?= =?utf-8?B?QnVadTJXc2xkTkNTVTZXdUFORlBGRzNUNFFEcGExSURoVVNXY0VTQ0pMV2pV?= =?utf-8?B?TkxxakE3dFFmUGRSSHlPb1kxQkt1U01nV0w0ZkFMTXdJdi8vZ2tBZXhzTEhH?= =?utf-8?B?angyN2JBRlYvNnNuZ2JxaWZKeUtKQnFtcERpcmE4M2tEMmVsdUtjSHMvcTBT?= =?utf-8?B?dE9kVm8zYlN6YkhNcU5ONU94ckNlWndsRWZtajVZTy9xRjB2b1ZFU1hSK3ps?= =?utf-8?B?a2wxZDUzY0NvZTlGQlhaR1Q2MWpPTHVSb0lESDZGTnhvVy95OGFvM05vaFIw?= =?utf-8?B?WmtHbUFOaHg4emxaSlo0REtxbmV6S1E4aUtrZENyRnltTWxZRENtcFBiOWFD?= =?utf-8?B?OU91ajBYR0hlZW02WVlYNTQzVlNocnpNeDhCVGU1amgrcDBGTmVpRXJwZGVi?= =?utf-8?B?clY2WFF1K3ZYaEV2SjhuOFJDYzJGTml4MnhQd0xWVkZtNFl4N0svQ25WOE1s?= =?utf-8?B?MmI1MlRpYWc3TnJtZ00yTUNPaHk1N0M3NzlrVHNwVE8xZ2s0U1NLeSt4ZXpG?= =?utf-8?B?dWZIYXFBTnAxWnBHWHozK21jMXNtQ2xqTFFPbXljZ3d3aXVvajcwMEg1U2lM?= =?utf-8?B?ZDVxTG5neCthNjZxNHJndXpvRko1UWROc1Y4R3RqQktuRGlLMXhjYXoreDds?= =?utf-8?B?c3NJN21tOEZtaXlxd2hYTC8rZHVCQ2ZpbnJ1cUdnRUVsMVpjVlg1ZlIzWFc3?= =?utf-8?B?L2szWjJRZFYxeHhlTE9LR3dCM0huV0s1YXZpNVE1akxSeC9HblQ0K1dKb0d4?= =?utf-8?B?VlZneExZNkdjWDkzWjUxTkRhdlZZUEJxcXRvZnZBWm5TT1kzSVJZNVhsbURr?= =?utf-8?B?aTVlWktWZG9JUElVM1BrMWVReUFsOGJSQjNkcmxlaC9GSzhXQWpTb2t3c3lM?= =?utf-8?B?VWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <747B60737504434EAB9F81C77CEB1A96@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcfd6267-74db-48b1-2884-08daa2f4672f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 14:59:41.2897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sMaCusP/W3ujsSw0oSV1g1lpEtcJ2BBUczd9paBLb/IxJQiFJ9A3uwyr2t5UkDqMZMwkMxA2GoXv0DJC0wCeMVJskfygvrPg+HOA8yBedtw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5639 DQoNCj4gT24gMjcgU2VwIDIwMjIsIGF0IDE3OjEzLCBFZHdpbiBUb3JvayA8ZWR2aW4udG9yb2tA Y2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gU2VlIGJlbG93IGZvciBhIHBhdGNoIGZvciB0 aGF0LiBJJ3ZlIGluY2x1ZGVkIHRoaXMgcGF0Y2ggaW4gdGhlIGNvcnJlY3QgcGxhY2UgKGJlZm9y ZSB0aGUgcGF0Y2ggdGhhdCBicmVha3MgaXQpIGluIHRoZSBnaXQgcmVwb3NpdG9yeSBhdDogDQo+ IGh0dHBzOi8vZ2l0aHViLmNvbS9lZHdpbnRvcm9rL3hlbi9jb21wYXJlL3ByaXZhdGUvZWR2aW50 L3B1YmxpYzANCj4gDQoNCg0KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5s aW5kaWdAY2l0cml4LmNvbT4NCg0KSSBiZWxpZXZlIHRoZXNlIGNoYW5nZXMgYXJlIGZpbmUuIFdl IGFyZSBub3cgYWxsb2NhdGluZyB0aGUgZXZlbnQgY2hhbm5lbCBkeW5hbWljYWxseSBhbmQgdGhp cyByZXF1aXJlcyB1c2luZyBhIGZpbmFsaXNlciB0byBmcmVlIHRoYXQgbWVtb3J5LiANCg0KDQo+ IC1pZm5lcSAoJChNQUtFQ01ER09BTFMpLGNsZWFuKQ0KPiAraWZlcSAoLCQoZmluZHN0cmluZyBj bGVhbiwkKE1BS0VDTURHT0FMUykpKQ0KPiAub2NhbWxkZXAubWFrZTogJChBTExfT0NBTUxfT0JK X1NPVVJDRVMpIE1ha2VmaWxlICQoT0NBTUxfVE9QTEVWRUwpL01ha2VmaWxlLnJ1bGVzDQo+IAkk KGNhbGwgcXVpZXQtY29tbWFuZCwgJChPQ0FNTERFUCkgJChBTExfT0NBTUxfT0JKX1NPVVJDRVMp ICoubWxpICRvLE1MREVQLCkNCj4gZW5kaWYNCg0KSXMgdGhpcyB0aGUgcmlnaHQgbG9naWM/IE1v dmluZyBmcm9tIGlmbmVxIHRvIGlmZXEgaGVyZS4NCg0KSSBhbSBub3Qgc28gZmFtaWxpYXIgd2l0 aCB0aGUgTWFrZmlsZSBydWxlcy4gVGhlIGdpc3Qgc2VlbXMgdG8gYmU6IHdlIGRlcGVuZCBvbiBh dXRvLWdlbmVyYXRlZCBNYWtlIGRlcGVuZGVuY2llcyB0aGF0IHRoZSBNYWtlZmlsZSBpbiBnZW5l cmFsIGRlcGVuZHMgb24uIEJ1dCBpbiBhIOKAnG1ha2UgY2xlYW7igJ0gKG9yIG90aGVyIOKAnCpj bGVhbuKAnSBpdCBpcyB3YXN0ZWZ1bCB0byBnZW5lcmF0ZSB0aGVzZSBvbmx5IHRvIGxhdGVyIHJl bW92ZSB0aGVtLiBIb3dldmVyLCB0aGVzZSBraW5kIG9mIHN1YnRsZXRpZXMgYXJlIG9idmlvdXMg ZW5vdWdoIHdoaWxlIHdlIGFyZSB3b3JraW5nIG9uIHRoaXMgYnV0IG92ZXIgdGltZSBhY2N1bXVs YXRlIHRvIE1ha2VmaWxlcyB0aGF0IGFyZSBoYXJkIHRvIGNoYW5nZS4gU28gSSB3b25kZXIgaWYg dGhpcyBraW5kIG9mIG9wdGltaXNhdGlvbiwgd2hpbGUgY29ycmVjdCwgaXMgd29ydGggaXQsIGJ1 dCBmaW5lIGdvaW5nIGFsb25nIHdpdGggaXQuDQoNCuKAlCBD From xen-devel-bounces@lists.xenproject.org Fri Sep 30 15:14:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 15:14:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414277.658469 (Exim 4.92) (envelope-from ) id 1oeHiB-0007K0-Ea; Fri, 30 Sep 2022 15:13:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414277.658469; Fri, 30 Sep 2022 15:13:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHiB-0007Jt-B8; Fri, 30 Sep 2022 15:13:59 +0000 Received: by outflank-mailman (input) for mailman id 414277; Fri, 30 Sep 2022 15:13:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHi9-0007Jh-Kj; Fri, 30 Sep 2022 15:13:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHi9-0003NL-HP; Fri, 30 Sep 2022 15:13:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHi9-0006jX-2o; Fri, 30 Sep 2022 15:13:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeHi9-00053Q-2K; Fri, 30 Sep 2022 15:13:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PcbMcl7PqpaCDv74Og6Jlx1jeae9blV8UooObJ/qG3c=; b=npgbZVYFPQR431rio1uJUPE43G mb24GLAXV05dHgyw3NpcABoRqoOWAVKhXq8JEWMgKWyqcdVOiIBolo+K70bqvg40k3Xw26ErfZru0 uDtaF0YGMrgCRDBdTAMUp1fzWD2k6alQwHBVOGY94v9lP1X6sRwyyhdPm1Hs2HjdTo/w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 173383: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm::broken:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:host-install(5):broken:heisenbug linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=987a926c1d8a40e4256953b04771fbdb63bc7938 X-Osstest-Versions-That: linux=511cce163b75bc3933fa3de769a82bb7e8663f2b From: osstest service owner Date: Fri, 30 Sep 2022 15:13:57 +0000 flight 173383 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173383/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm broken build-arm64-pvops 6 kernel-build fail in 173378 REGR. vs. 173364 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 5 host-install(5) broken pass in 173378 test-armhf-armhf-xl-arndale 8 xen-boot fail pass in 173378 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 173378 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 173378 n/a test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173378 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173378 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173364 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173364 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173364 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173364 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173364 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173364 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173364 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173364 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 987a926c1d8a40e4256953b04771fbdb63bc7938 baseline version: linux 511cce163b75bc3933fa3de769a82bb7e8663f2b Last test of basis 173364 2022-09-29 15:40:21 Z 0 days Testing same since 173378 2022-09-30 00:41:06 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm broken test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemut-debianhvm-i386-xsm broken broken-step test-amd64-amd64-xl-qemut-debianhvm-i386-xsm host-install(5) Not pushing. ------------------------------------------------------------ commit 987a926c1d8a40e4256953b04771fbdb63bc7938 Merge: 511cce163b75 06bbaa6dc53c Author: Linus Torvalds Date: Thu Sep 29 14:37:45 2022 -0700 Merge tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs Pull coredump fix from Al Viro: "Fix for breakage in dump_user_range()" * tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: [coredump] don't use __kernel_write() on kmap_local_page() commit 06bbaa6dc53cb72040db952053432541acb9adc7 Author: Al Viro Date: Mon Sep 26 11:59:14 2022 -0400 [coredump] don't use __kernel_write() on kmap_local_page() passing kmap_local_page() result to __kernel_write() is unsafe - random ->write_iter() might (and 9p one does) get unhappy when passed ITER_KVEC with pointer that came from kmap_local_page(). Fix by providing a variant of __kernel_write() that takes an iov_iter from caller (__kernel_write() becomes a trivial wrapper) and adding dump_emit_page() that parallels dump_emit(), except that instead of __kernel_write() it uses __kernel_write_iter() with ITER_BVEC source. Fixes: 3159ed57792b "fs/coredump: use kmap_local_page()" Signed-off-by: Al Viro From xen-devel-bounces@lists.xenproject.org Fri Sep 30 15:20:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 15:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414287.658480 (Exim 4.92) (envelope-from ) id 1oeHo6-0000Sy-7T; Fri, 30 Sep 2022 15:20:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414287.658480; Fri, 30 Sep 2022 15:20:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHo6-0000Sr-4A; Fri, 30 Sep 2022 15:20:06 +0000 Received: by outflank-mailman (input) for mailman id 414287; Fri, 30 Sep 2022 15:20:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeHo4-0008Sd-Ie for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 15:20:04 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59e00149-40d3-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 17:20:02 +0200 (CEST) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 11:19:59 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by MN2PR03MB5102.namprd03.prod.outlook.com (2603:10b6:208:1ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 15:19:57 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::4dc1:6b11:9f99:1eec]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::4dc1:6b11:9f99:1eec%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 15:19:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59e00149-40d3-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664551202; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=V+BixSDR6+CZUGjA2DhpsAiniclHuPYa3vaa9LickZw=; b=QB8a2CZNYytFU0KkmSMLJquAkLt3ciRBDmWrtn0Ftdzp9qTYiQAdPe3p ElEgtKoRf3mqA/qCRu0MMfhgTKk2DCFPJ1ZbfgN5YjvuHSzjazm80XZ/S MRtH0wHtmGRB+ycJeoLYQdxOVaIC0ZnYz2bslHUk+JBI6WY7855pMBEa3 E=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 81709137 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cwW69a2ddBVrcW54mPbD5chwkn2cJEfYwER7XKvMYLTBsI5bp2YHz WMZCjrSOKmLMDDweN52bdm/8x8OsZHXzYNgSAY+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WhA5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU+9/hJEz9x/ sY+ISIWNB6Bod2/4u+SH7wEasQLdKEHPas5k1Q5lHTyKq9jRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/L4/NouQA/zyQouFTpGNfZZN2MA9lShEGbj mnH4374ElcRM9n3JT+toivz3r6WxnyTtIQ6Ma+0yvFhugGqxEswWQZLXHmwo92blRvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmQNUDNpctEts84yAzsw2 TehgNfBFTFp9rqPRhqgGqy8qDqzPW0eKjYEbCpdFA8duYC8+sc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:CNQhE6uIHmrdnONq9OhRnRrz7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208";a="81709137" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYTFrp4bR1q6M1q2CWU5cm2vGfW7ZR+Uvg1NxEcW2veKbwz7QL03E0ZYo+pUOelzS5Nwv+fWUmYpg1NC5RLA98M6mkFRR4uaYYY3gv6iMBpJs3JAcqlTIt6icpQu3f93dmpi4ggIRxQ20N3GZrom4vP2vbeSjkMVmb9+rf9+dsnoV6b4WWEhMBg2YFts9JW0QVM2ELR3Oq835QPWmQ+LJInVNjOwMMnqlZIfUIMMcUmlKoLkSM+J5FVGJa0kJn3245l9HcUt8fX5wlzw8Pwbh0mhnY2aDhdHFVK3jw/5REaJKHhUw7LjUfkP1As7IOn5yiMJKVxy6fvG6WO46D6YyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V+BixSDR6+CZUGjA2DhpsAiniclHuPYa3vaa9LickZw=; b=YhQRczJg9DpCCRim52YepDdm4b9Pve4jPnccOFLk36lfF1KuK92NnuoOsQ2rtO96m+T1gcU9Fm1KT2ATAUcEGmrD/bgvp4cLNdyoeHjP/f2LvUSP9e0ywcUN3CrWqxqqH6Kf4sZecgSwmtdMEtjrndBBdtZ8wW3+pWSiChdZIPVJoczkh2klfOoSPKYhA9zckWTYyUl0HFmK7e6eq4tOyMUKcNhwZ42lbVnE1tc5TIZG61/s3mGPJfSQJ4JaqiwJ0+OkMwAeNIj3j60nCQIblLwbJCORwN8zte9RdsM+0n507KNx4XhlWcKId1W4srom0xbajtaDsT3H+5NfhMIEng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V+BixSDR6+CZUGjA2DhpsAiniclHuPYa3vaa9LickZw=; b=Kpir8Aynzvr/6tmJT0+MqHmj3wSTqzfBgbylVd2+kmweLFUFVQuwrwCobU5zPs9uVKiBF4JMyvQ4miY7DJidmWt7yLNEbUMEvaPqazC/vmCZ286ViPZZQ59iKTw9aWbiaRpHkvHtJLapY7Y9d90/soW2WkcOV/5qwkFX09gJeOY= From: Edwin Torok To: Christian Lindig CC: "xen-devel@lists.xenproject.org" , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Thread-Topic: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility Thread-Index: AQHY0mKHWIzo/zbfF0KNs+muY99n/a3zc0gAgASifICAAAWpgA== Date: Fri, 30 Sep 2022 15:19:57 +0000 Message-ID: <6D0F2229-345A-448E-88AC-7B598C534F49@citrix.com> References: <7b88cbda20e068bbce1c5dfb0a18af3f4e4b6865.1664276827.git.edvin.torok@citrix.com> <18C55ABC-CE37-4740-A516-86D4FCE83EC6@citrix.com> In-Reply-To: <18C55ABC-CE37-4740-A516-86D4FCE83EC6@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|MN2PR03MB5102:EE_ x-ms-office365-filtering-correlation-id: cc9595a8-468b-467b-4071-08daa2f73c16 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gOvJ6QVIWiB9BC8jY2mES6sC8jwxXjTfXfILT5GMy8jNCNadA9vtTliKaHcLuyF0ZFj7WuJZh/4to+ESK1tr9uCpP0va8uopHhaupG4IQx2g36L7pIkPppgNFS5fR+Mkzf+5al5Uw5Qe4Ewmq8MlNTCoEdAePeJEdzlVA8B8RrWPBxUHab6oZnvwExp9qpqoH4V8wyEvjkhOg4RBrq9ub1FRUBx8ZX5lauO1jMVF2Nyd1GbAIJBnywnUq0nF2+ZhBP7BJf82ufU/WTA0V07sdFUC3uyZIQXP6UMlainx+4hO2ja3OBB4iFGcuQDRO4lswFhfRKzJkKbeRiBnDFDGYON17DldjfZ+6PHkCF4+B1a3CdteKMH6/y4CdgwNhEOzRnnpvLCHF2D2XpzlHbA4IlOs7efzuMey10plFyl2QeW+e4FlBuHYyqNOQrYMLAiM3oJoYIPOVm4r1G2cQFkiYNSAHfGxBVpT/KiMT1tWWZwJXmXW/rsP518zQL/0QKND6r1nGlg5xJDR1QNnzABHA1erkuTkgVTCwxshspicLosQD4K9OkrynYHybcmmHgmqqXvzFyqME6ainvO9bnPDyPVb++iehCvwEt3GihOvnPD3aKszkSnlavsxR1+uhF0q8DwfRcKAAeE0KFm3hTQt0/Vp8W1Y/bFtyu4SAPfEoXrvd4UcrdLCuqvotPC6yDNtAINbsLd9n7CxDr7U6gdNgU8x/KvgybqOUyf+F7AYOpILfCphEMae3NhQf2XX3Y+0sQ0kadwgbMZVhmHY6FU3rTkG7pftNZ4fv/l1/b52CEuSGLoDi4PBRRw+a8w6orLrK61a3CM0q9eCgk35s/UQDQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(366004)(396003)(376002)(451199015)(82960400001)(6636002)(122000001)(91956017)(6486002)(478600001)(66946007)(76116006)(2906002)(66476007)(4326008)(64756008)(66446008)(66556008)(8936002)(6862004)(33656002)(6506007)(107886003)(41300700001)(53546011)(316002)(37006003)(8676002)(36756003)(54906003)(26005)(6512007)(966005)(86362001)(5660300002)(186003)(71200400001)(38100700002)(38070700005)(2616005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1kzaFVHemxDSStwTnVndFBYU0phN0VLUk4zNVJ2S2NjT2krU1VWV1hMNVdj?= =?utf-8?B?d2ovZ1FKSCt0R0xIZzRFc2NUQ3hTaUxPSXRldlloTVM0TE1SVTJVYTBNN1E1?= =?utf-8?B?WnlXYzA4UXVQYndTNFY1MEFONUcxODJSYnhwQjNSV0FUSCtsdHB1cmIwV3hN?= =?utf-8?B?TS93S0tPYi8xNzBFODFRYURsOUZKZGFIMnJZQlV6MzZGVHdTaVlIYnBPUlhF?= =?utf-8?B?OGwyUDZzeDkzK042N3dlYnZuWThrUWl5K0xpWEYyNEVSa04wUnMzQ3B2ZEQz?= =?utf-8?B?YVRKazB4Y0xhamZXeHNkbUtlSnVQWVUxdVZVaFd0RStXejQzOFFrUzdIbXM5?= =?utf-8?B?dGpUVTIzcWMwS3VRQzE2RDJOMVRReW56V0ZVYUlnS0pIREtoTU1xSENvT3Iv?= =?utf-8?B?YW5VRXFnWCtHbmZJTTNkUWVucXQzdDhUR2dQa2ZXaWlGWmh6SDhOSFFETFJG?= =?utf-8?B?YTNRQnM0b3dMY3hXU0hNa1FyUkt2dzhIbTd1elhJSWk3ZFkzcjlLQVkwNGgy?= =?utf-8?B?d3F2bytVSzlqUXRPaFl3Nmh4citDcUp1blFqVXZCYXd5MGpHZlJYU3p0VUYr?= =?utf-8?B?dkFNLy9WMmVna3BSOHJqYlIzdnNKSUJzU2VrQmMyNUI4c3VYQWR4WURyQVJw?= =?utf-8?B?NmxZdUVvQ0lWQTZFS0g1cEpLS0lQMVh1Q2RjZW1FRVN0QjQrdE4vQVhTWDdp?= =?utf-8?B?ckx6ZHVIUkxTWGllY29BOUxZN3oydXhPS1FNTHp6T0dycW1tNG9ZdTVuYVNw?= =?utf-8?B?MzdWSytndUZpb2hFUStkdjI2WTQ3S0laOHBlRGlUNDQzOGEvRCs4YVQvcUxL?= =?utf-8?B?aitONXoxa05pS1V6NXVlV2E0M1ROd2tGMU5Od3JvcU5pZHVjbjJxRWxaK0VI?= =?utf-8?B?T0t3bkgyZlFYTWJSSXJUWnJNZ2F2a0NDSm41dFNtQXBmK1BXbUNFR1k5TW1v?= =?utf-8?B?T3JKMnJkUldaeDdZbjhveEkwZ0loTHVXTFZTNEJjSGQvdHRvYnRDMXZwSnNG?= =?utf-8?B?YTJ0MWlxa2FvOUxMSEtwRHp0cWpBbXBOUzdodmlRaTNoYUdlZEFybmhnR0la?= =?utf-8?B?MEpURjMvT1c2V05EaFNSUzl1OTdGOG5mcmNQdEFhNk9DTjFvYkVVTG95MWJh?= =?utf-8?B?T1ZCeUxtcHBqWS83ZWdlbFVjLzdKWGd6V2c1M3JTZVZmUUl1U3BJcHA1WTcy?= =?utf-8?B?WG9UZnM3WlB5dUd1Qml0TENSV0gza1E3UWlQLzVVRkd1NXF2RDBlN25XZXFS?= =?utf-8?B?S0U0aS9xTWtqemI0Y0RWMUlHTisxNkN1ckdyYjlidUg5RHNDQ0hvRk1JOG1S?= =?utf-8?B?eXp3anBEa2hnTUZHK1NEcnkxM3VRMU4zaitpWjBmNzdpN0RhT1hwVDV3NEN3?= =?utf-8?B?aFp5RGVydy9oTDF6OHArd0lydTJwVEljOHNjZXhUZm1CVkhrQmxBelluZjht?= =?utf-8?B?eDdGVGlnU0xtYk82cE9lUUNrQkZwZFJta3FNS1BMZXJsRjNNUFFTYlY0MCtn?= =?utf-8?B?Rm4ydFMvRDF5VlVya2hUMnk0WWlkU0t4QXdnNWptMjMwOVRxR1pYNWJvQmJL?= =?utf-8?B?b0kvVENXaFhSSW8yZjh1bXpJQ3BwOWhsZjNTeHF3emV0UHI2NXpLS0F4YmdY?= =?utf-8?B?dXhvbWRvUUx0a2xuM2ExVGh0YUFBUFkyL2YvR3MzNVYvc2RrYU1vUW1hVFVS?= =?utf-8?B?b2pudDZZWmU3bVhPT3o3ZitBM1V1azhqR3hTZ1F2Zzlhb3ovcEpFcnNvVVQx?= =?utf-8?B?Tk5tblZGYU0rMFo3SFl0OTRQdnZkT0FVUURnUzdGSFhnRUVGdE1BYk0vcEI4?= =?utf-8?B?a2w5Q3FxcTA1T241cC9iMndqOVpCM2lSUWpOcUVDbXQ2NHpZZWJESGFhU3Zz?= =?utf-8?B?VDdSV2N6R1VYZEVVMWV1bkxlajhQZnJ4WHE0STV1YUNsS0FxU09YNElOLy9D?= =?utf-8?B?aDFPUmlLZ0dVT01sbExGUkhmMEV0dEZhdnhtRVhVOHVkMWk0VzJ2M1hiOW9J?= =?utf-8?B?UkRza2JOaE01OE9SemJwZFJlWi81S0JwM3Q3Um9GSXFTalJ4ODBsTjNIR1Ra?= =?utf-8?B?d1JWc2lKVGdIMkVNcU5Rd1Y2Y295T2ZFdWZJTG0rcDY0cEZnNWc4T3NsdjAw?= =?utf-8?B?UzNXWkpkRm1rWVNqMTBOMnVXUXdXT2tZV1JSVllKaGkrMmVxR20zK1RpZ011?= =?utf-8?B?WlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <0C6CA076E21DC743922B20CEE084FF8F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc9595a8-468b-467b-4071-08daa2f73c16 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 15:19:57.4590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gy8bgY2BktVbmXszyTm7PzPliH1A0cyH7FF/YQEYcBOXgPzTD49fq4PL1Rw38EdYC64Xe3S2IT+HFIJtbq8ruA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5102 DQoNCj4gT24gMzAgU2VwIDIwMjIsIGF0IDE1OjU5LCBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3Rp YW4ubGluZGlnQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gMjcgU2VwIDIw MjIsIGF0IDE3OjEzLCBFZHdpbiBUb3JvayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4gd3JvdGU6 DQo+PiANCj4+IA0KPj4gU2VlIGJlbG93IGZvciBhIHBhdGNoIGZvciB0aGF0LiBJJ3ZlIGluY2x1 ZGVkIHRoaXMgcGF0Y2ggaW4gdGhlIGNvcnJlY3QgcGxhY2UgKGJlZm9yZSB0aGUgcGF0Y2ggdGhh dCBicmVha3MgaXQpIGluIHRoZSBnaXQgcmVwb3NpdG9yeSBhdDogDQo+PiBodHRwczovL2dpdGh1 Yi5jb20vZWR3aW50b3Jvay94ZW4vY29tcGFyZS9wcml2YXRlL2VkdmludC9wdWJsaWMwDQo+PiAN Cj4gDQo+IA0KPiBBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0Bj aXRyaXguY29tPg0KPiANCj4gSSBiZWxpZXZlIHRoZXNlIGNoYW5nZXMgYXJlIGZpbmUuIFdlIGFy ZSBub3cgYWxsb2NhdGluZyB0aGUgZXZlbnQgY2hhbm5lbCBkeW5hbWljYWxseSBhbmQgdGhpcyBy ZXF1aXJlcyB1c2luZyBhIGZpbmFsaXNlciB0byBmcmVlIHRoYXQgbWVtb3J5LiANCg0KVGhhbmtz LA0KDQo+IA0KPiANCj4+IC1pZm5lcSAoJChNQUtFQ01ER09BTFMpLGNsZWFuKQ0KPj4gK2lmZXEg KCwkKGZpbmRzdHJpbmcgY2xlYW4sJChNQUtFQ01ER09BTFMpKSkNCj4+IC5vY2FtbGRlcC5tYWtl OiAkKEFMTF9PQ0FNTF9PQkpfU09VUkNFUykgTWFrZWZpbGUgJChPQ0FNTF9UT1BMRVZFTCkvTWFr ZWZpbGUucnVsZXMNCj4+IAkkKGNhbGwgcXVpZXQtY29tbWFuZCwgJChPQ0FNTERFUCkgJChBTExf T0NBTUxfT0JKX1NPVVJDRVMpICoubWxpICRvLE1MREVQLCkNCj4+IGVuZGlmDQo+IA0KPiBJcyB0 aGlzIHRoZSByaWdodCBsb2dpYz8gTW92aW5nIGZyb20gaWZuZXEgdG8gaWZlcSBoZXJlLg0KPiAN Cj4gSSBhbSBub3Qgc28gZmFtaWxpYXIgd2l0aCB0aGUgTWFrZmlsZSBydWxlcy4gVGhlIGdpc3Qg c2VlbXMgdG8gYmU6IHdlIGRlcGVuZCBvbiBhdXRvLWdlbmVyYXRlZCBNYWtlIGRlcGVuZGVuY2ll cyB0aGF0IHRoZSBNYWtlZmlsZSBpbiBnZW5lcmFsIGRlcGVuZHMgb24uIEJ1dCBpbiBhIOKAnG1h a2UgY2xlYW7igJ0gKG9yIG90aGVyIOKAnCpjbGVhbuKAnSBpdCBpcyB3YXN0ZWZ1bCB0byBnZW5l cmF0ZSB0aGVzZSBvbmx5IHRvIGxhdGVyIHJlbW92ZSB0aGVtLiBIb3dldmVyLCB0aGVzZSBraW5k IG9mIHN1YnRsZXRpZXMgYXJlIG9idmlvdXMgZW5vdWdoIHdoaWxlIHdlIGFyZSB3b3JraW5nIG9u IHRoaXMgYnV0IG92ZXIgdGltZSBhY2N1bXVsYXRlIHRvIE1ha2VmaWxlcyB0aGF0IGFyZSBoYXJk IHRvIGNoYW5nZS4gU28gSSB3b25kZXIgaWYgdGhpcyBraW5kIG9mIG9wdGltaXNhdGlvbiwgd2hp bGUgY29ycmVjdCwgaXMgd29ydGggaXQsIGJ1dCBmaW5lIGdvaW5nIGFsb25nIHdpdGggaXQuDQo+ IA0KDQpNYWtlZmlsZSBmdW5jdGlvbnMgY2FuIGJlIGEgYml0IGNvbmZ1c2luZyB0byByZWFkLg0K DQoiaWZuZXEgKCQoTUFLRUNNREdPQUxTKSwgY2xlYW4pIiBtZWFucyAkKE1BS0VDTURHT0FMUykg IT0gImNsZWFuIg0KImlmZXEgKCwkKGZpbmRzdHJpbmcgY2xlYW4sJChNQUtFQ01ER09BTFMpKSki IG1lYW5zIHRoYXQgImNsZWFuIiBpbiAkKE1BS0VDTURHT0FMUykgPT0gIiIgKHRoZSBlbXB0eSBz dHJpbmcpLCBvciBpLm8udy4gImNsZWFuIiBub3QgaW4gJChNQUtFQ01ER09BTFMpLCB3aGljaCBp cyBhIGJpdCBtb3JlIGdlbmVyaWMgdGhhbiB0aGUgcHJldmlvdXMgb25lLA0Kc2luY2Ugd2UgaGF2 ZSBhbGwgc29ydHMgb2YgcnVsZXMgaW4gdGhlIE1ha2VmaWxlIChlc3BlY2lhbGx5IGFyb3VuZCBz dWJkaXJzKSB3aGVyZSAnY2xlYW4nIGlzIGEgc3Vic3RyaW5nLg0KVGhpcyBpcyBxdWl0ZSBzdWJ0 bGUgYW5kIEkgaGFkIHRvIHJlcmVhZCB0aGlzIGxpbmUgbWFueSB0aW1lcyB0b28gdG8gY2hlY2sg aXQgaXMgY29ycmVjdC4NCg0KVGhlIHJlYWwgc29sdXRpb24gaGVyZSB3b3VsZCBiZSB0byBoYXZl IGEgc2luZ2xlIG5vbi1yZWN1cnNpdmUgTWFrZWZpbGUgKGFuZCB0aGVyZSBpcyBzb21lIGRpc2N1 c3Npb24vcGF0Y2hlcyBoZWFkaW5nIGluIHRoYXQgZGlyZWN0aW9uIGluIHhlbi1kZXZlbCBwYXJ0 aWN1bGFybHkgZnJvbSBBbnRob255KSwgYW5kIHRoZW4gZXZhbHVhdGluZyB0aGUgImNsZWFuIiBy dWxlcyB3b3VsZCBiZSBhIGxvdCBsZXNzIGV4cGVuc2l2ZSwgaXQnZCBvbmx5IGhhdmUgdG8gYmUg ZG9uZSBvbmNlLiBCdXQgdGhlcmUgbWlnaHQgYmUgYSB3aGlsZSB1bnRpbCB3ZSBnZXQgdGhlcmUs IGFuZCBtZWFud2hpbGUgdGhlc2UgY2xlYW4gcnVsZXMgc2xvdyBkb3duIHRoZSBPQ2FtbCBidWls ZCB0b28gbXVjaCAoanVzdCBydW5uaW5nIHRoZSAiY2xlYW4iIHRha2VzIGEgbG90IGxvbmdlciB0 aGFuIGJ1aWxkaW5nIHRoZSBlbnRpcmUgT0NhbWwgbGlicmFyaWVzIGFuZCBveGVuc3RvcmVkIHNl cXVlbnRpYWxseSkuDQoNCkFsdGhvdWdoIEkgb25seSBuZWVkIHRvIHVzZSAnY2xlYW4nIHdoZW4g dXNpbmcgdGhlIHVwc3RyZWFtIE1ha2VmaWxlcyAod2hlcmUgYWxtb3N0IGV2ZXJ5IGluY3JlbWVu dGFsIGNoYW5nZSByZXF1aXJlcyBhICdjbGVhbicgaW5iZXR3ZWVuIGJlY2F1c2UgdGhlIE1ha2Vm aWxlcyBleHByZXNzIHRoZSBkZXBlbmRlbmNpZXMgaW5jb3JyZWN0bHkpLA0Kb3Igd2hlbiBzd2l0 Y2hpbmcgZnJvbSB1cHN0cmVhbSBNYWtlZmlsZSB0byAnZHVuZScgKGEgb25lLW9mZiBldmVudCB1 c3VhbGx5KS4NClNpbmNlIEkgdXNlICdEdW5lJyBmb3IgbXkgZGFpbHkgd29yayBhbnl3YXkgKGFu ZCB0aGUgbWFrZWZpbGUgaXMgdXNlZCBpbiBvdXIgaW50ZXJuYWwgYnVpbGQgc3lzdGVtKSBwZXJo YXBzIHRoaXMgTWFrZWZpbGUgcGF0Y2ggaXMgbm90IG5lZWRlZCBhdCBhbGwsIEkgY2FuIGNoYW5n ZSAnTWFrZWZpbGUuZHVuZScgdG8gbm90IGNhbGwgJ21ha2UgY2xlYW4nIGF0IGFsbCwgYW5kIEkn bGwga25vdyB0byByZW1lbWJlciB0byBydW4gaXQgaWYgdGhpbmdzIGZhaWwgYW55d2F5IChpdCds bCBiZSBwcmV0dHkgb2J2aW91cyB3aGVuIER1bmUgc2F5cyB5b3UndmUgZ290IGEgYnVpbGQgYXJ0 aWZhY3QgaW4gdGhlIHdyb25nIHBsYWNlKS4NCg0KQmVzdCByZWdhcmRzLA0KLS1FZHdpbg== From xen-devel-bounces@lists.xenproject.org Fri Sep 30 15:42:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 15:42:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414294.658491 (Exim 4.92) (envelope-from ) id 1oeI9I-0003DZ-UO; Fri, 30 Sep 2022 15:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414294.658491; Fri, 30 Sep 2022 15:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeI9I-0003DS-Rl; Fri, 30 Sep 2022 15:42:00 +0000 Received: by outflank-mailman (input) for mailman id 414294; Fri, 30 Sep 2022 15:41:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeI9G-0003DM-Om for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 15:41:59 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6889d696-40d6-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 17:41:56 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 366FD3200A6C; Fri, 30 Sep 2022 11:41:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 30 Sep 2022 11:41:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 11:41:50 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6889d696-40d6-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664552511; x= 1664638911; bh=MoxlBPfavur2f0fkyMZHSvl38jBS4cY0CP1Xr97RuWs=; b=w mJgPw6AQVVBPpTkIYPNLKCmzFhfbgxeN7PWEajBymBf7szY6m17L+kAZpxJbhhGG EKgQBRYoKxLous0ITyN5kx5x7YWgoAKZzxvt9ZUuARoACfIJachZ5uULvNGSS8J5 Yj6Wo/nw/TRFX7VmG6X/xf8snXTFCJ+Np6Jt2uS+gBPHl3ThxR6lDRXIBc6xzznk ACm4MTyTXt89+B4M74j93lTQWxzGYKTDGVs2p0dxxaqh3y5sSDkmH/k8qiOlG4sM z9pos5adhQ0DCtvEheMxcqPxzDgBTLzQmheJR/uTCJzdPbFIsVGD/4W6c5Lh4uRu QtnlZQl7xNu1+dazygQ0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664552511; x=1664638911; bh=MoxlBPfavur2f0fkyMZHSvl38jBS 4cY0CP1Xr97RuWs=; b=pfaa6Ed3HG+qFHzzEDf+QyfRW1XwVz8TGay93t18iuq4 IyV5gyIc66vagePE0vpbBGqtRe70DSxsetM68b0SsuLO/Fojn9ogFROfK7ENxJDd QcgZJ+yXHfdZW0Bu7aUnS9kPKBOuoKaJnBu/Aobq/cdbh7RR9D5IxYeo+2YQcOfI Jky6/SsPJx8Ut5kSbz2LdlOyI10VRbySLDMP2nkxlZpMIghJ5jzpumLJD8DYrpbZ 3RyQW9xClX/N/tTyk5PxYyc37nZD0yP40i3Vgbfz9GjiePFvHi7ssLHsnbbl3+ht Rl/PBibIpxytsLgULGFnSMT32u1acU4QekMeX0sDNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeeu tedugfevvdeuuefhhfeiueettedvhedvtedvgeffkefhfedtjeegjeethfejnecuffhomh grihhnpehinhhtvghlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 30 Sep 2022 17:41:46 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau Monne , Demi Marie Obenour , Henry Wang Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode Message-ID: References: <8f07c532-e742-fa02-27ee-b08c56299d09@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cO/Gq9L8hbdMYZtR" Content-Disposition: inline In-Reply-To: <8f07c532-e742-fa02-27ee-b08c56299d09@citrix.com> --cO/Gq9L8hbdMYZtR Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 17:41:46 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau Monne , Demi Marie Obenour , Henry Wang Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode On Fri, Sep 30, 2022 at 11:25:12AM +0000, Andrew Cooper wrote: > On 15/09/2022 11:04, Jan Beulich wrote: > > [1] specifies a long list of instructions which are intended to exhibit > > timing behavior independent of the data they operate on. On certain > > hardware this independence is optional, controlled by a bit in a new > > MSR. Provide a command line option to control the mode Xen and its > > guests are to operate in, with a build time control over the default. > > Longer term we may want to allow guests to control this. > > > > Since Arm64 supposedly also has such a control, put command line option > > and Kconfig control in common files. > > > > [1] https://www.intel.com/content/www/us/en/developer/articles/technica= l/software-security-guidance/best-practices/data-operand-independent-timing= -isa-guidance.html > > > > Requested-by: Demi Marie Obenour > > Signed-off-by: Jan Beulich >=20 > This patch should not be taken; at least not in this form.=C2=A0 The whole > DOITM infrastructure is currently under argument, for being impossible > to use appropriately. >=20 > I understand why Qubes want this blanket set, but it is a steep penalty > to pay;=C2=A0 It's only code which is already written trying to be consta= nt > time/cache which gains any security from this.=C2=A0 Based on the bit description, I'd say rather "prevent _breaking_ security of the code already written". It is not setting this bit that change behaviour on new parts, but it's not setting it that breaks previous guarantees. It's really bizarre design choice from Intel... > On current parts, using > SSBD has the same behaviour, but this isn't expected to remain true in > the future. >=20 > Forcing it on behind the back of a VM is mutually exclusive with > enumerating it for VMs to use at some point in the future when we have > the capability to.=C2=A0 i.e. specifically, you are not able to maintain = the > ABI/API in this patch in the future. Regarding the current behavior of the hypervisor (without this patch): will guest see DOITM present but not set? Or will they not see it at all? Documentation clearly state: For Intel=C2=AE Core=E2=84=A2 family processors based on microarchitect= ures before Ice Lake and Intel Atom=C2=AE family processors based on microarchitectures before Gracemont that do not enumerate IA32_UARCH_MISC_CTL, developers may assume that the instructions listed here operate as if DOITM is enabled. So, if guests will not see the feature at all, it Xen should set it unconditionally, to remain compliant with expected hardware behaviour. If guests will see the thing (and see it not enabled), then indeed it's less clear what should be done right now (but I'd still like to have an option to enable it). > If we do move forward with something like this (under the strict > understanding that the behaviour is going to change in the future), then > "DIT" is too short of an acronym to use.=C2=A0 Amongst other things, it's= not > "data independent timing"; it's "controls for forcing ..." which is > important because these are going to be vendor specific, if even needed > in the first place. >=20 > ~Andrew --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --cO/Gq9L8hbdMYZtR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM3DjoACgkQ24/THMrX 1yzH1Af/br1iJEur2UD5UsjIgXfGVASYmz9Mi0FDGbveUzX1abkvr8UYdkUI7DHX /7RU1evWnR7pirWg0SZrgLub8Heh2o6nepUi1UZ0o3rZWkw7bg83rqHZqKjV6Vdb B8iu6zAdKFL3Sa98Oa4+REnxG7j+7JzQd+fLjfEjCjKKyco/IRkH+fOtcp0o/KwD NoqknvMETfYmQtyUrITh9YnoJX3lP1/vL0gbHSnd/a5NAJlQJZXuYKvdt8ZElW0T YxdHiVUGcORcVjNzgTk2AB53IP0cgycLmFBLoL2c7gUhqllLqTefjZJDyrsof4bN kFqoZC7qUYiz+5qAcd5juqYTUfKcaQ== =27VJ -----END PGP SIGNATURE----- --cO/Gq9L8hbdMYZtR-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 15:59:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 15:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414301.658502 (Exim 4.92) (envelope-from ) id 1oeIQ0-0005Db-DY; Fri, 30 Sep 2022 15:59:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414301.658502; Fri, 30 Sep 2022 15:59:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIQ0-0005DU-9j; Fri, 30 Sep 2022 15:59:16 +0000 Received: by outflank-mailman (input) for mailman id 414301; Fri, 30 Sep 2022 15:59:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIPy-0005DO-WF for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 15:59:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d3e68156-40d8-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 17:59:13 +0200 (CEST) Received: from VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) by AS8PR04MB7991.eurprd04.prod.outlook.com (2603:10a6:20b:289::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 15:59:10 +0000 Received: from VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::90be:f320:716c:5bf8]) by VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::90be:f320:716c:5bf8%6]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 15:59:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3e68156-40d8-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BXS5iPq5qlqtdXODDEJczn1rcgkZr0T3n29C2XfinOFA5exB3pdpEqxbJdIrwxxG/jDyPXRFU4cpBVbhtQxA0KBNiLJP/BnZBgVqWYUFnbIMltXiS0efz8r4XWpTL9iiXHQ+KWjpT8FjAoJlODWo/Ml9Zf+aDaYelwkKG1nIiGtuOrmDjpZ5R8Sy9CCoEDd57ykLg2gWgp258lneL/fw2cCGAGVV8Wyp7qXrk2y/7v9XVLkk/w8RJNodu2UvqtkterAOrv1NEWTvRI4GXfLppCnwLl+6y+lpj9b6lOakPGBTTmB0pIABnmLNYW/C26AqJAqKgdb5cLGmZMsokAuPNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/3yUG1c11tvYKcCImeHGQqZxgmPU/OgLyrCkHuKjaE=; b=OUW8vDWYreFzdITxXex62lMsF1syrfT1j2a+l2aQ8hjw4ePC4581ETswCq02T3pwhPWRfHe70YGCSI59mguhhgsNdkISsTm37PboUbsflXcMoOq4cdelxvtJ44k6ytu4VKImwdL9n6dqUGwQ4vyCSuBVlwUlaxpZa8IkEFRecAS4vOPD8IrG2mdKNTieYUTF8qaId+AmuYe0ied59Z1+te0KLNV065yxCQfaNSLevlcoiwM4gtEffyuK+13D7jEudTJfUhYDrtEC1nAJFRUxGz17hUB98+9XkUGrhe52fylEgfBezyR8d3W+QPLKqXXUFlQ18V9qGRJmy0CMs6ULTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2/3yUG1c11tvYKcCImeHGQqZxgmPU/OgLyrCkHuKjaE=; b=U/WupuXdpxUYAqNHh948CICCxbqP0k0frlxicswLWmCW0DMJZSQQufQKRKEGYQWGRAfq7yoiwTNeHHZTYBO6wwS/+O559Zw6RPHqRR5yNoR8LNfTHJVn8ZIPsSgKsdD82FpeCo7mvPNGQ4EvpbSBIQ9GsnHAYLiGUhnfrNnqnZA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; From: "Andrei Cherechesu (OSS)" To: xen-devel@lists.xenproject.org Cc: viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: [ImageBuilder][PATCH v4 0/1] Imagebuilder dynamic addresses and sizes Date: Fri, 30 Sep 2022 18:58:48 +0300 Message-Id: <20220930155849.2210574-1-andrei.cherechesu@oss.nxp.com> X-Mailer: git-send-email 2.35.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AS4P250CA0018.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5e3::13) To VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB5056:EE_|AS8PR04MB7991:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a6e64fd-2af6-4eab-f40b-08daa2fcb66b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fc5E6Uz2SdaDk4ge2XpVOHYehI24NG8TiU13HhIPk9qiIjzmxBMJ2Rp3pxYnBRbTcVofZTHzucIbYlwWLCw/36fWoF7WuOv/IDhHq44umgVei5xWPk2sMIR+ZwiNgz8OOxf4Vchs6iv9z2ySGnT5/e3PGDwx94PwvFXtpv+gevlulnUonK0HpWFSXaGAz2D5guwaMLuTkCzgcWQelBF/ulciCwcMWjyUK3TUn39HHZgkhx5hgJ8/VqNN0838l/fpM/nVzsTtxktzmSTRcEIJmEq0DESAxidcI5EJjNUvkm2WfgZs8XWdnTAp1Fp/0wQXLFQy4qq/ncmq89sVN2b4G/8M/uiBjjPKG3N0/ZM/kYo35L5AdmI4+9fsuLnkOFvWxtk5wXYvvTCaGTfppkbIWJYo83fRkHFeEqb11v7VMyaeYHuxpDmeCtJm9qH/68OISnNDKZCnRtSUWZcisuoMQky66k6gj7qMNbOWoVY0w/C3z46A6GCWMDkd7pFVDzfejZNarxvxCpEdllVzdGb9zI0UpiwSRb2GT8W1EP43K9vmvs8E3nnsfD0o9g32sdmhSIFFAN9KDxTc3jbxfelaq7sibgMePGXPyf8N6hsBgecdp1RrULNN0h9TSVQaqz+jKBMOublVn5ffpChfbCMutCZyJR9dJMOo/kb0CakiM8H1jqEVWAM6Qu7zntC57R2K7ZAPkTgtJXSi4up3njg5eAGUD4CJaSmbe1u9/xSmKkE3ZzooMgXL4LnBqQt1r7bu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5056.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199015)(4326008)(8676002)(66946007)(66476007)(66556008)(38100700002)(6486002)(2616005)(186003)(478600001)(38350700002)(6506007)(1076003)(52116002)(6666004)(316002)(6916009)(86362001)(83380400001)(6512007)(26005)(8936002)(41300700001)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w2At8N316aica1rKTB93dEqnVoLajKraOX9qRSD9WnqYo+GkqojtqdqRjCZA?= =?us-ascii?Q?qlfPbN2iAQh1n8qpN9284UJI+MK3UIQGTgROrF5f+CiZSx/CAFzcmiJfCRyO?= =?us-ascii?Q?In+YlT3MlOTDZ3ascJ+f9VcMvTti3ywh5PDfwwEAYtXAi9adnJfK+8PsR/uQ?= =?us-ascii?Q?MxYGXMm3uUKlpADTBB1lKkUtgWt5jyFNuKEOsByKewHLFBDlyq0bVVcdiNwW?= =?us-ascii?Q?MDGXP6sbLLVkzEeSX/el4Rl0X+w7o20cIyfcXFoPMUMZLg4uRG+efF7pP4ch?= =?us-ascii?Q?PJK1NHLJcpWX62V/Az/UrVxS+5wBLtsPw9SRTi73Ux87V+9PDs4BNBYh0obb?= =?us-ascii?Q?qUj1BD9whBkPv5AAU6ygGWXANGlD++WqPFPOUUBt9Mi5CQ7IMBvIfJQfXvso?= =?us-ascii?Q?kiZHGBSO6kFsk0383SxExJ7mVD1EY8dC6UJ9/cz6Q83pKHcUkQ03HswW91p8?= =?us-ascii?Q?RRq3JQDo5v8pGaVxLAgn7GeO2ydY2NS53qSX2t2Dhua4eD6hj1SAu/h74fFe?= =?us-ascii?Q?90HoMoRabi+UUaX3CzvJYNeEArcIBKRcyoKg0XLkVSl49TbNWEbWrxV36W2Y?= =?us-ascii?Q?8tXzWukvc21k/T2UQj0CulXdCOkUGE+zHjjUMrXxeZLlVXnGue+W6Xru8SBr?= =?us-ascii?Q?i6SS352NGl5wWnagfQJde31esda4bchF5+dN24INx2/VjztHs7X/HHAdUIHJ?= =?us-ascii?Q?Ja5bEMM1bMRRXs0bjeUTknik8nBCjf2ukbpOcgb3o3++cpIlGsZKKT90wBOa?= =?us-ascii?Q?/RB2HT+dJppyX38Cy1p/+2CsNbXuTdw0v9l6QrcbfG9Gzy4yl3xau5yjsmyP?= =?us-ascii?Q?/tYi7qmk8JSnlex9eWxLk09RvLIFjJ2xGv0o2z5qP68AeTceFLUzWMia+pvA?= =?us-ascii?Q?OmyPNQCK+fvklFfT36jRtMvy2YXMpUnskfWOOKf1jA2lbTNA/t0JnffQfVko?= =?us-ascii?Q?Lh5WAf6vhl6MmtQ/S2E498wd25SI9eHvt1OgNKzdu6vn++UNec+NsrlHyoek?= =?us-ascii?Q?oMl81r0nq2tihRus4PZ2SpimEPWTcgJRKsmCjBVBQvzYkz3UmhHd8/uo1Vun?= =?us-ascii?Q?rWc3S0EtRDAvhnfYFygNSr8kLkEYy/7puVqH695GH7/LruOMTE9HbT0Xa28Y?= =?us-ascii?Q?DL3ZUyYLg3JlHbSnT6UAiXT2UyM1VDI4sB1FadktpaQWjF/1XP2qWSW0zzOc?= =?us-ascii?Q?NYYPqcE5edOU/KSfAGpqym8zqNmnzrM1w1JXKCAfPn15tWwsE19vpeEMQT7C?= =?us-ascii?Q?oK1+sAgsjSTbG6U1y4dEGomBlta+AIEkrv/DSU7gduCVgvjdVwHvn8szMEFi?= =?us-ascii?Q?yfQeFqex97bJKtVbVWjqvsVk6o+VsLjgVGUnHvJjsMIWqxRsZdqwDZem4PfF?= =?us-ascii?Q?ji/0rzJ8cTY5y//b64id4HIsA0Wb55+uB/jD2nLQUH8q3j/7l26Id/g0geT6?= =?us-ascii?Q?HXPcDqkNUWbSb6lFQsBNWuiO21pbOW3ndtpDRcWVQRLGU63OxhgzdCpr5ixn?= =?us-ascii?Q?kowmkfOdOWaPXNdwZgtQ4EbZIP0m9mA6o2KCj1A+2e1vtWDNaeU62MURedhY?= =?us-ascii?Q?gSJencpQCSPffqoXUoBvcBhAbIyvLIaaKk2CefIWV/5kCYKA71W4hGrjkYSL?= =?us-ascii?Q?1A=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6e64fd-2af6-4eab-f40b-08daa2fcb66b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5056.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 15:59:10.5457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IKVyyG/Lw7NZ7sWmaeHSAuhAevyo48N1dQ07Mce9XFtIq7BgKge+d/bqSX7+4B3EoZlgv3ksvKB/7cMTj6COSpTUEe/Jk5UcaO6nYsEfP5U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7991 From: Andrei Cherechesu This sent patch adds support for dynamically computing the addresses and sizes for loaded binaries via the boot script generated by Imagebuilder. Compared to the v3 version of the patch, this includes Stefano's suggestions of not adding as many "if" statements on the $dynamic_loading_opt parameter added by the patch, along with keeping compatibility with the FDTEDIT case. The sent patch extends Stefano's suggestion, by also keeping the normal flow (without "-s" parameter) mostly unaltered: the addresses inside the generated script are literals, and the $memaddr variable is not re-computed after each binary loaded since it's unused. The only difference in the normal flow is that the binaries' sizes and addresses are stored after loading each binary. Also, removed the "0x" prefix of $memaddr set on the first line in the generated script. These mentioned changes, compared to Stefano's suggestion, need an additional 2 "if" branches on $dynamic_loading_opt, which I find a worthy tradeoff for keeping the normal flow mostly unaltered. Otherwise, I'm also happy to go with Stefano's suggestion, but the script generated on the normal flow would contain many unnecessary steps. Andrei Cherechesu (1): uboot-script-gen: Dynamically compute addr and size when loading binaries scripts/uboot-script-gen | 114 +++++++++++++++++++++++++++------------ 1 file changed, 80 insertions(+), 34 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 30 15:59:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 15:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414302.658513 (Exim 4.92) (envelope-from ) id 1oeIQB-0005X7-Oc; Fri, 30 Sep 2022 15:59:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414302.658513; Fri, 30 Sep 2022 15:59:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIQB-0005Wy-Ln; Fri, 30 Sep 2022 15:59:27 +0000 Received: by outflank-mailman (input) for mailman id 414302; Fri, 30 Sep 2022 15:59:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIQ9-0005DO-Ph for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 15:59:26 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dad37a75-40d8-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 17:59:24 +0200 (CEST) Received: from VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) by AS8PR04MB7991.eurprd04.prod.outlook.com (2603:10a6:20b:289::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 15:59:22 +0000 Received: from VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::90be:f320:716c:5bf8]) by VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::90be:f320:716c:5bf8%6]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 15:59:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dad37a75-40d8-11ed-964a-05401a9f4f97 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyIZ4ti9MzAOu0++a4afSh2u9ooiJw6OSX7/5jV/ML9OuYJ52/UoMiBdNFVDsYH3It6CusYGpp07r5CkfIb/MbGHuyC4G8WjYD3o2tg+vJ/eL/iiqVkvzSnyPm4A/3+2wqDvN+f21SkbpRtaWLHMj3vL/Qk10reEqEJSvazfjoBIVX7BfqlBIYdhKCsTeUEGPLwFzNoukeJgJ16ByUjbLWg2ZBkiK3K1bZ5pQmLx1CTClVAt+byZp45n1ijf5X3SS3lzOae/jNIBcZdbG+Ytg99DtmyYH3ORubgAtgnHBC3vs3l02uSmqizbfKE4NSpWbSFzPCYy2ofDAZCKx/spfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cdzjZTKmnGZB4Jrjg5RvYEjwLWaqX1ih9fF/MAq9rCo=; b=ibi6XMArHCGt2F5aJI1hiuC05tieosBtzNe1cbzGljgitaQBqfo1tiwVsyTwfg8NOZuQwOsw1h4cxC2Uyggq3oZpIHv6XsCvi24BT6aAC3PziWnnl0qcpXEN3yrEj2bM4uGOfPqHj/EeoNyfLOy3yhH/4hbi2jvt0f/k0FBMZyT4TqALppJi8dBRZH6D79Q5YxqUdlnD0sVnQSo04ClensRWP8LATG4ec/HpN9OJn/ecUdNKr43XYjMMCjvTe1F2K0yF0vA46+c9pr7CQ/E0u4hyZZnOV3xMUJvvcjctRSxt1xZWNl3UTcn3ynGTxkgl40fUf8X4M7B69u2rtdzSaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdzjZTKmnGZB4Jrjg5RvYEjwLWaqX1ih9fF/MAq9rCo=; b=cXeTB/Gc7yVvZdcTKgn+73N/MKdcPPp4WJiedDRFfEheul2SLnVQCO+qUm0wyf5+M7wDtJvmypgPGcOw1FqE6b7d4opARLLTgejnUZuXybCmu1HkZB7M+JkWRYRICRzJBP8JGQrSl9y6AggcMd7v96mUxCCG1cx0uLqOvUmCjJo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; From: "Andrei Cherechesu (OSS)" To: xen-devel@lists.xenproject.org Cc: viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu , Stefano Stabellini Subject: [PATCH v4 1/1] uboot-script-gen: Dynamically compute addr and size when loading binaries Date: Fri, 30 Sep 2022 18:58:49 +0300 Message-Id: <20220930155849.2210574-2-andrei.cherechesu@oss.nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220930155849.2210574-1-andrei.cherechesu@oss.nxp.com> References: <20220930155849.2210574-1-andrei.cherechesu@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AS4P250CA0018.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5e3::13) To VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB5056:EE_|AS8PR04MB7991:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ce8de5e-3de6-43be-9380-08daa2fcbd46 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iiRHUdK78Fz7ux3lKq3MVTlGqpMcRAoqAfgzp5/zcEQlKT+ShmvTbEm88v1vO/EmN9aMlnPTmlL07PUr9KkYIQet9rKqphfnRN0Q7a1k6nYnqEiL+7XRTzfL+FQDVFieII2N/5Xn4oi5+vjZhhxT2cUrSU3qHZH+/fQ2OwTDXFYHN+VkszkVY6LP4OwJMPlgO/OX6CoGd9qJXzmG+hRiDl/NiTAhk6ZhKJ08WkgoB89raKd+YP80ecVHtOU8AnTfuXlxPCiolOcd8psK+jZIZrIu++ww07lxz/vxtd+OnQ/JMCQ4x0l4dqn4domj4CmT4VuOKKw03wYJw/2EaAUWZ8aC/9vBnLNpzXH35g+vdkGA0REHL7vz8SZTSlwYmr2L2nlTuHmy9wCT/k5ZUbG+Acq8dVMcVGIVTljH1fV533Zl1Gv3APkNiezjZrvjX4+BIDzkGMpccpm7swNZmy1nBZW0e1UHvsQ7NVEen5UQNHMdVe4KeMU65yo5h/SzEwzwWgxJOTbmoFDVAW/r+BGyUSlVl46WMURQVFUBnVHFIYfk9EO1U4hlA6QLIPi5dQbkr4SKmOo0uqnK9UgoUYkCm326/w18CODIq/G4ukppNWLmoJi5jUOHl2CNdy6PY2ykHq0VKSewy6lThOtRluU9T7G6QKOyqmSmuPSPUfTgTAxbs4L1x2RVnbnOHVDxlsxfRLshq+fHqA3fV7Hd7ofqLCeLqTTt1+gqmABR7skscxM3pPhviCBHTnLgIoXv9Lgr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5056.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199015)(4326008)(8676002)(66946007)(66476007)(66556008)(38100700002)(6486002)(2616005)(186003)(478600001)(38350700002)(6506007)(1076003)(52116002)(6666004)(316002)(54906003)(6916009)(86362001)(83380400001)(6512007)(26005)(8936002)(30864003)(41300700001)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MOXhr70FC9vvsg/fAYGSnDBcDYrz2VcAWsI1mj818929LCU+eSXOkB5tdyfs?= =?us-ascii?Q?YgFZuz6qlnu2vq3rGfQkYZXABlpPNiQkgmNsbAMV2fwuu/ki4QB3NXmnC+h6?= =?us-ascii?Q?I93w9xlGttcMYwFMFp9veH8tMc/ryOtxhieLWMAdgrVo2l/ISZ/eAaVnKXnL?= =?us-ascii?Q?tCA5o0g3Du+4Q48aLg2MQJd4XV/XKmk1v9CUi4G8SB7fyMC0CozOsiNyMFAx?= =?us-ascii?Q?J684J3fJR68pDcuzlDEYAG0YdqAY4gCIaDg7azC0BXxM0GMoL54i5x9hqMFz?= =?us-ascii?Q?KSRCzjR2Loov2+tGvA4YfQjBCiETfBegsSgEiaLoVqMvk25uJ1bgVlD1Qn46?= =?us-ascii?Q?sy8i6/HvgokZquWgjbWOkhY1LVJk/krUwG3g7sI7Hlr4Zg5M/d0i35t0gm5v?= =?us-ascii?Q?LcYUj1K6TkMdQfPtHcNauETsh+WYDrO4nwDAoaA4ogasDYMKzV5hE/bfrxX4?= =?us-ascii?Q?/k+2ls3l1F1W+UZamoxu383X2PrWPN8LOVSIoizO3v2TnlflW9o8BpotPnMx?= =?us-ascii?Q?xn//49XPxbq8xWXXUnTnvGc1B7BLYvx6g2gml8pOTjIbCazX6pqBRjA4pato?= =?us-ascii?Q?vXLj1EiLE3xq4at3gDZcDCRBRGGz+3eDA8mxD68l1rsnTXKr6nwcO6AWol9a?= =?us-ascii?Q?V2fEUYqOR0r4iDEAupN/Z1IdC2O01pnwW+YNEgw7TCVfTSGtUQ9k6RTpvzSa?= =?us-ascii?Q?UtT4w2WcT4ZwDzrnZmoI4yNIekE/1iNgU8hQWb5GDarbWhM8rCAA5lK36wBc?= =?us-ascii?Q?0BKA9/i1wMEx4yiGy3AkPRIQf4z+CiQQ8yO2SasQzhCsL0mqdh44uAGLtZNV?= =?us-ascii?Q?MMOQ1VdrDzLZ4LmhcO/HjDAWUkReVCV7liwavUhwC/txQB2rLgqOV38iVqKU?= =?us-ascii?Q?uIVrXLAV1SosDfct3SnvH351bs+qiy+qKSru/J/I0g6kMFjeJz8PpPOD1dpv?= =?us-ascii?Q?778gfmN9fRvw4MeTHbvpIRPSLrsBpgQN7GCuWg/tfC2tn55RcAo4a/mtoPuo?= =?us-ascii?Q?6CRtPIs7Lw7knyUyx3fmWtlOHa0l6HOmOCTs63WXLVasMpqe4XTuVGf0nYih?= =?us-ascii?Q?Uykpb0QEJAOohPQDYarvLn3uLVfEyH1TfHfjqrlQrpJQI0F2zqSGk8Vh4Cqw?= =?us-ascii?Q?ktEDGBvzVIzzGWNH0drwAtWiEZu4yh/bqw7/Bnb+s2+mQLRbrEPsyYeE/Jf8?= =?us-ascii?Q?QAVxsjy5kJf7zOdzpaGnwmivM9L19UW6jaEd3nx0KUWmxb2x+iPx3WBeHgdB?= =?us-ascii?Q?iFblljgUbABHhXDWDXMDouguqZeaUluUD1yhGT55JmzU+FBEI0uqbqINbqr6?= =?us-ascii?Q?Dx5tzf/+l1EC3zIeFf4rQpIh6rGxBdnWAVAmwwKzqvoqvCbL/Y0uoKZ9ROb5?= =?us-ascii?Q?qhFWmgCFBgJAV6yazv3zzcBo5LaOZibAf8+40bYhC/1DO2KyTDwP3alV10KN?= =?us-ascii?Q?hhxfGEhwMZRy/JgMpIXYPN+da2rNDMZWwyHAFPUp707OxW6Gw1xSSaaHRF1a?= =?us-ascii?Q?81kHMLF/AvLbd1ZgHpv2zIzqYaPJwalAuzf9xnJinRz1dTRptdBQyJXWaNBu?= =?us-ascii?Q?yiQhdbTyHiA9YR0+tNNNeKQDUL9ioGw9sXzhr4vBqlMsWbGCRnrUKwqWm6R4?= =?us-ascii?Q?Cw=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ce8de5e-3de6-43be-9380-08daa2fcbd46 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5056.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 15:59:22.0761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O5ie2XGDesjONBOGahqR4kChDbugPQ2uHWyyHnAgtJjoxIECh3uXL5mQ/xFopAXhNeZzaChBkSTqbPW1y31/qTsRYK5WCltVL7vn108T86U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7991 From: Andrei Cherechesu Normally, the Imagebuilder would precompute the sizes of the loaded binaries and addresses where they are loaded before generating the script, and the sizes and addresses that needed to be provided to Xen via /chosen would be hardcoded in the boot script. Added an option via "-s" parameter to avoid hardcoding any address in the boot script, and dynamically compute the loading addresses for binaries. The first loading address is based on the MEMORY_START parameter and after loading each binary, the loading address and the size of the binary are stored in variables with corresponding names. Then, the loading address for the next binary is computed and aligned to 0x200000. If the "-s" parameter is not used, the normal flow is executed, where the loading addresses and sizes for each binaries are precomputed and hardcoded inside the script, but the loading addresses and sizes for each binary are now also stored for eventual later use. Signed-off-by: Andrei Cherechesu Signed-off-by: Stefano Stabellini --- scripts/uboot-script-gen | 114 +++++++++++++++++++++++++++------------ 1 file changed, 80 insertions(+), 34 deletions(-) diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index b24dca2..16269f0 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -4,6 +4,9 @@ offset=$((2*1024*1024)) filesize=0 prog_req=(mkimage file fdtput mktemp awk) +padding_mask=`printf "0x%X\n" $(($offset - 1))` +padding_mask_inv=`printf "0x%X\n" $((~$padding_mask))` + function cleanup_and_return_err() { rm -f $UBOOT_SOURCE $UBOOT_SCRIPT @@ -28,6 +31,7 @@ function dt_mknode() # str # str_a # bool +# var function dt_set() { local path=$1 @@ -35,11 +39,26 @@ function dt_set() local data_type=$3 local data=$4 + if test $data_type = "var" + then + eval data_addr_var="$data"_addr + eval data_addr=\$"$data_addr_var" + eval data_size_var="$data"_size + eval data_size=\$"$data_size_var" + fi if test "$UBOOT_SOURCE" && test ! "$FIT" then var=${var/\#/\\#} - if test $data_type = "hex" || test $data_type = "int" + if test $data_type = "var" + then + if test $dynamic_loading_opt + then + echo "fdt set $path $var <0x0 0x\${"$data_addr_var"} 0x0 0x\${"$data_size_var"}>" >> $UBOOT_SOURCE + else + echo "fdt set $path $var <0x0 $data_addr 0x0 $data_size>" >> $UBOOT_SOURCE + fi + elif test $data_type = "hex" || test $data_type = "int" then echo "fdt set $path $var <$data>" >> $UBOOT_SOURCE elif test $data_type = "str_a" @@ -63,7 +82,10 @@ function dt_set() if test $FDTEDIT then - if test $data_type = "hex" + if test $data_type = "var" + then + fdtput $FDTEDIT -p -t x $path $var 0x0 "$data_addr" 0x0 "$data_size" + elif test $data_type = "hex" then fdtput $FDTEDIT -p -t x $path $var $data elif test $data_type = "int" @@ -87,38 +109,35 @@ function dt_set() function add_device_tree_kernel() { local path=$1 - local addr=$2 - local size=$3 - local bootargs=$4 + local varname=$2 + local bootargs=$3 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,kernel multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" - dt_set "$path/module$addr" "bootargs" "str" "$bootargs" + dt_mknode "$path" "module-$varname" + dt_set "$path/module-$varname" "compatible" "str_a" "multiboot,kernel multiboot,module" + dt_set "$path/module-$varname" "reg" "var" "$varname" + dt_set "$path/module-$varname" "bootargs" "str" "$bootargs" } function add_device_tree_ramdisk() { local path=$1 - local addr=$2 - local size=$3 + local varname=$2 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,ramdisk multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + dt_mknode "$path" "module-$varname" + dt_set "$path/module-$varname" "compatible" "str_a" "multiboot,ramdisk multiboot,module" + dt_set "$path/module-$varname" "reg" "var" "$varname" } function add_device_tree_passthrough() { local path=$1 - local addr=$2 - local size=$3 + local varname=$2 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,device-tree multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + dt_mknode "$path" "module-$varname" + dt_set "$path/module-$varname" "compatible" "str_a" "multiboot,device-tree multiboot,module" + dt_set "$path/module-$varname" "reg" "var" "$varname" } function add_device_tree_mem() @@ -260,7 +279,7 @@ function xen_device_tree_editing() then dt_mknode "/chosen" "dom0" dt_set "/chosen/dom0" "compatible" "str_a" "xen,linux-zimage xen,multiboot-module multiboot,module" - dt_set "/chosen/dom0" "reg" "hex" "0x0 $dom0_kernel_addr 0x0 $(printf "0x%x" $dom0_kernel_size)" + dt_set "/chosen/dom0" "reg" "var" "dom0_linux" dt_set "/chosen" "xen,dom0-bootargs" "str" "$DOM0_CMD" fi @@ -268,7 +287,7 @@ function xen_device_tree_editing() then dt_mknode "/chosen" "dom0-ramdisk" dt_set "/chosen/dom0-ramdisk" "compatible" "str_a" "xen,linux-initrd xen,multiboot-module multiboot,module" - dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 $ramdisk_addr 0x0 $(printf "0x%x" $ramdisk_size)" + dt_set "/chosen/dom0-ramdisk" "reg" "var" "dom0_ramdisk" fi i=0 @@ -315,14 +334,14 @@ function xen_device_tree_editing() dt_set "/chosen/domU$i" "colors" "hex" "$(printf "0x%x" $bitcolors)" fi - add_device_tree_kernel "/chosen/domU$i" ${domU_kernel_addr[$i]} ${domU_kernel_size[$i]} "${DOMU_CMD[$i]}" + add_device_tree_kernel "/chosen/domU$i" "domU${i}_kernel" "${DOMU_CMD[$i]}" if test "${domU_ramdisk_addr[$i]}" then - add_device_tree_ramdisk "/chosen/domU$i" ${domU_ramdisk_addr[$i]} ${domU_ramdisk_size[$i]} + add_device_tree_ramdisk "/chosen/domU$i" "domU${i}_ramdisk" fi if test "${domU_passthrough_dtb_addr[$i]}" then - add_device_tree_passthrough "/chosen/domU$i" ${domU_passthrough_dtb_addr[$i]} ${domU_passthrough_dtb_size[$i]} + add_device_tree_passthrough "/chosen/domU$i" "domU${i}_fdt" fi i=$(( $i + 1 )) done @@ -350,7 +369,7 @@ function device_tree_editing() if test $UBOOT_SOURCE then - echo "fdt addr $device_tree_addr" >> $UBOOT_SOURCE + echo "fdt addr \${host_fdt_addr}" >> $UBOOT_SOURCE echo "fdt resize 1024" >> $UBOOT_SOURCE if test $NUM_DT_OVERLAY && test $NUM_DT_OVERLAY -gt 0 @@ -375,11 +394,33 @@ function device_tree_editing() function add_size() { local filename=$1 + local fit_scr_name=$2 + local binary_name_addr="${fit_scr_name}_addr" + local binary_name_size="${fit_scr_name}_size" + eval "$fit_scr_name"_addr=$memaddr + local size=`stat -L --printf="%s" $filename` + filesize=$size + eval "$fit_scr_name"_size=`printf "0x%X\n" $size` + eval binary_name_size_value=\$"$binary_name_size" + + if test $dynamic_loading_opt + then + echo "setenv $binary_name_addr \${memaddr}" >> $UBOOT_SOURCE + echo "setenv $binary_name_size \${filesize}" >> $UBOOT_SOURCE + # Compute load addr for next binary dynamically + echo "setexpr memaddr \${memaddr} \+ \${filesize}" >> $UBOOT_SOURCE + echo "setexpr memaddr \${memaddr} \+ $padding_mask" >> $UBOOT_SOURCE + echo "setexpr memaddr \${memaddr} \& $padding_mask_inv" >> $UBOOT_SOURCE + else + # Store load addr and size as literals + echo "setenv $binary_name_addr $memaddr" >> $UBOOT_SOURCE + echo "setenv $binary_name_size $binary_name_size_value" >> $UBOOT_SOURCE + fi + memaddr=$(( $memaddr + $size + $offset - 1)) memaddr=$(( $memaddr & ~($offset - 1) )) memaddr=`printf "0x%X\n" $memaddr` - filesize=$size } function load_file() @@ -394,10 +435,13 @@ function load_file() if test "$FIT" then echo "imxtract \$fit_addr $fit_scr_name $memaddr" >> $UBOOT_SOURCE + elif test "$dynamic_loading_opt" + then + echo "$LOAD_CMD \${memaddr} ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE else echo "$LOAD_CMD $memaddr ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE fi - add_size $filename + add_size $filename $fit_scr_name } function check_file_type() @@ -978,7 +1022,7 @@ function print_help { script=`basename "$0"` echo "usage:" - echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH]" + echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH] [-s]" echo " $script -h" echo "where:" echo " CONFIG_FILE - configuration file" @@ -995,6 +1039,7 @@ function print_help echo " U-BOOT_DTB - u-boot control dtb so that the public key gets added to it" echo " -f - enable generating a FIT image" echo " PREPEND_PATH - path to be appended before file names to match deploy location within rootfs" + echo " -s - enable dynamic loading of binaries by storing their addresses and sizes u-boot env variables" echo " -h - prints out the help message and exits " echo "Defaults:" echo " CONFIG_FILE=$cfg_file, UBOOT_TYPE=\"LOAD_CMD\" env var, DIRECTORY=$uboot_dir" @@ -1002,7 +1047,7 @@ function print_help echo " $script -c ../config -d ./build42 -t \"scsi load 1:1\"" } -while getopts ":c:t:d:ho:k:u:fp:" opt; do +while getopts ":c:t:d:ho:k:u:fp:s" opt; do case ${opt} in t ) case $OPTARG in @@ -1044,6 +1089,9 @@ while getopts ":c:t:d:ho:k:u:fp:" opt; do p ) prepend_path="$OPTARG" ;; + s ) + dynamic_loading_opt=y + ;; h ) print_help exit 0 @@ -1223,6 +1271,8 @@ uboot_addr=$memaddr # 2MB are enough for a uboot script memaddr=$(( $memaddr + $offset )) memaddr=`printf "0x%X\n" $memaddr` +start_addr=`printf "%x\n" $memaddr` +echo "setenv memaddr $start_addr" >> $UBOOT_SOURCE if test "$os" = "xen" then @@ -1266,11 +1316,7 @@ fi if [ "$BOOT_CMD" != "none" ] then - echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE -else - # skip boot command but store load addresses to be used later - echo "setenv host_kernel_addr $kernel_addr" >> $UBOOT_SOURCE - echo "setenv host_fdt_addr $device_tree_addr" >> $UBOOT_SOURCE + echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE fi if test "$FIT" -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 30 16:26:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 16:26:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414314.658524 (Exim 4.92) (envelope-from ) id 1oeIq6-0001m6-Sp; Fri, 30 Sep 2022 16:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414314.658524; Fri, 30 Sep 2022 16:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIq6-0001lz-P8; Fri, 30 Sep 2022 16:26:14 +0000 Received: by outflank-mailman (input) for mailman id 414314; Fri, 30 Sep 2022 16:26:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIq5-0001lt-9x for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 16:26:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 964a3532-40dc-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 18:26:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C4126235A for ; Fri, 30 Sep 2022 16:26:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E37FC433D6 for ; Fri, 30 Sep 2022 16:26:06 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id a14so5331367ljj.8 for ; Fri, 30 Sep 2022 09:26:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 964a3532-40dc-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664555166; bh=oqLfbEYe4oKYjxRzZLjsJo81ZyVL6bMsqLMXt0kKL6M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mvZZtkBFmQi2x7GpRI8lcYjKOiCtRcni2tTvr/2Gci5jhQMmE2AuH9RBHqqD/N4xY DFfBNLSu3bR3hzPaU8LR+H+WA2hS/wi7NFe3qS4JrM3OEVkWYietrU1eNf84V89n+z C162Ou3Uy7FvA0Pxzr2OfbKiNwbHiDIWzmR+77c4zXVOXp6EyeaZaqpjYowx+TWLfa P1/5W6TTZsvX2HH6fN9SsGnFCxAjT1ZQbcmaGwINTkbw2tKvwFJppaLE8MI3EiSM72 K+Mg8KrB6iYjxiYISadp+yWX6SO4Nnv7Ad9ddEMCtT8nkcSsSgXNLc7EprHbS7ouW0 QN02UEV9iB+5g== X-Gm-Message-State: ACrzQf1sTNE5ZrBSx4E5ZgI9wbORQnBMG1eBPIyk/LooGrUTNq3mVmx2 1IaFl4wbZQ6Hpyy8XdbNUpgGoZLLSoOsA4B1yGY= X-Google-Smtp-Source: AMsMyM6CuK5x63b6fiVGIdEPxEPIkgUe0csGlqkji9OKq4ixVNWcF+qZD6wm6VZbn3AEbq4Pb+HCOlGex3PeGRJSdRE= X-Received: by 2002:a05:651c:239c:b0:26d:94b8:781d with SMTP id bk28-20020a05651c239c00b0026d94b8781dmr2937124ljb.189.1664555164446; Fri, 30 Sep 2022 09:26:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Fri, 30 Sep 2022 18:25:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered To: Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour wrote: > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DATA, > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > Xen before Linux gets to start using it. Therefore, Linux under Xen > must not use EFI tables from such memory. Most of the remaining EFI > memory types are not suitable for EFI tables, leaving only > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > use tables that are located in one of these types of memory. > > This patch ensures this, and also adds a function > (xen_config_table_memory_region_max()) that will be used later to > replace the usage of the EFI memory map in esrt.c when running under > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > but I have not implemented this. > > Signed-off-by: Demi Marie Obenour > --- > drivers/firmware/efi/efi.c | 8 +++++--- > drivers/xen/efi.c | 35 +++++++++++++++++++++++++++++++++++ > include/linux/efi.h | 9 +++++++++ > 3 files changed, 49 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index e4080ad96089abd7f84745dd8461c548bcbb7685..d344f3ff73d1c5ed0c67e3251a9502e66719741d 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -574,7 +574,6 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, > unsigned long table; > int i; > > - pr_info(""); Why are you removing these prints? > for (i = 0; i < count; i++) { > if (!IS_ENABLED(CONFIG_X86)) { > guid = &config_tables[i].guid; > @@ -585,7 +584,6 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, > > if (IS_ENABLED(CONFIG_X86_32) && > tbl64[i].table > U32_MAX) { > - pr_cont("\n"); > pr_err("Table located above 4GB, disabling EFI.\n"); > return -EINVAL; > } > @@ -594,10 +592,14 @@ int __init efi_config_parse_tables(const efi_config_table_t *config_tables, > table = tbl32[i].table; > } > > +#ifdef CONFIG_XEN_EFI We tend to prefer IS_ENABLED() for cases such as this one. That way, the compiler always gets to see the code inside the conditional block, which gives better build test coverage (even if CONFIG_XEN_EFI is disabled). > + if (efi_enabled(EFI_PARAVIRT) && !xen_config_table_memory_region_max(table)) So the question here is whether Xen thinks the table should be disregarded or not. So let's define a prototype that reflects that purpose, and let the implementation reason about how this should be achieved. So if (IS_ENABLED(CONFIG_XEN_EFI) && efi_enabled(EFI_PARAVIRT) && xen_efi_config_table_valid(guid, table) continue I should note here, though, that EFI_PARAViRT is only set on x86 not on other architectures that enable CONFIG_XEN_EFI so this will not work anywhere else. > + continue; > +#endif > + > if (!match_config_table(guid, table, common_tables) && arch_tables) > match_config_table(guid, table, arch_tables); > } > - pr_cont("\n"); > set_bit(EFI_CONFIG_TABLES, &efi.flags); > > if (efi_rng_seed != EFI_INVALID_TABLE_ADDR) { > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c > index d1ff2186ebb48a7c0981ecb6d4afcbbb25ffcea0..c2274ddfcc63304008ef0fd78fd9fa416f75d073 100644 > --- a/drivers/xen/efi.c > +++ b/drivers/xen/efi.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > > #include > > @@ -271,6 +272,40 @@ static void xen_efi_reset_system(int reset_type, efi_status_t status, > } > } > > +__init u64 xen_config_table_memory_region_max(u64 addr) It is more idiomatic for Linux to put __init after the return type. And if we adopt my suggestion above, this becomes bool __init xen_efi_config_table_valid(const efi_guid_t *guid, u64 table) Alternatively, you could pass the string identifier of the table instead of the guid (or both) to print in the diagnostic message. > +{ > + static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, > + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); Is this the only place where this matters? And this never happens on x86, right? > + struct xen_platform_op op = { > + .cmd = XENPF_firmware_info, > + .u.firmware_info = { > + .type = XEN_FW_EFI_INFO, > + .index = XEN_FW_EFI_MEM_INFO, > + .u.efi_info.mem.addr = addr, > + .u.efi_info.mem.size = U64_MAX - addr, > + } > + }; > + union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info; > + int rc = HYPERVISOR_platform_op(&op); > + > + if (rc) { > + pr_warn("Failed to lookup header %llu in Xen memory map: error %d\n", > + (unsigned long long)addr, rc); > + return 0; > + } > + > + switch (info->mem.type) { > + case EFI_RUNTIME_SERVICES_CODE: > + case EFI_RUNTIME_SERVICES_DATA: > + case EFI_ACPI_RECLAIM_MEMORY: If we are listing all memory types that Xen preserves, you might add EFI_RESERVED_MEMORY here. Otherwise, please only list the ones that you need to permit explicitly. > + return info->mem.addr + info->mem.size; > + default: > + pr_warn("Table %llu is in memory of type %d, ignoring it\n", > + (unsigned long long)addr, info->mem.type); > + return 0; > + } > +} > + > /* > * Set XEN EFI runtime services function pointers. Other fields of struct efi, > * e.g. efi.systab, will be set like normal EFI. > diff --git a/include/linux/efi.h b/include/linux/efi.h > index d2b84c2fec39f0268324d1a38a73ed67786973c9..fc81e4b984398cdb399e7886b2cae7f33bf91613 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -1324,4 +1324,13 @@ struct linux_efi_coco_secret_area { > /* Header of a populated EFI secret area */ > #define EFI_SECRET_TABLE_HEADER_GUID EFI_GUID(0x1e74f542, 0x71dd, 0x4d66, 0x96, 0x3e, 0xef, 0x42, 0x87, 0xff, 0x17, 0x3b) > > +#ifdef CONFIG_XEN_EFI Please drop this #ifdef > +/* > + * Returns the end of the memory region containing the given config table, > + * or 0 if the given address does not reside in memory that can validly > + * contain EFI configuration tables. > + */ > +__init u64 xen_config_table_memory_region_max(u64 addr); You can drop the __init here > +#endif > + > #endif /* _LINUX_EFI_H */ > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab > From xen-devel-bounces@lists.xenproject.org Fri Sep 30 16:31:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 16:31:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414322.658534 (Exim 4.92) (envelope-from ) id 1oeIuy-0003Em-JR; Fri, 30 Sep 2022 16:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414322.658534; Fri, 30 Sep 2022 16:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIuy-0003Ef-GT; Fri, 30 Sep 2022 16:31:16 +0000 Received: by outflank-mailman (input) for mailman id 414322; Fri, 30 Sep 2022 16:31:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeIux-0003EZ-AC for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 16:31:15 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b616f4a-40dd-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 18:31:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6EE6623C6 for ; Fri, 30 Sep 2022 16:31:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38D0EC433C1 for ; Fri, 30 Sep 2022 16:31:10 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id a8so7632904lff.13 for ; Fri, 30 Sep 2022 09:31:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b616f4a-40dd-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664555470; bh=942mhlsPgXt/goX0aW+X613nTk5Qs5Pp3COTvOdUwZ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QQaItIyYxi0HLaL4oqDkDYh05o8FbZWsbNU2Y0NT8kfZub1XP2IlO80nVvphwfoss Gj/++qo/ntHKK12oR+56pq5jRBesGpWCKimqBXV8vwP9toEB8f0gCD38Es5z/EU7VT VsqktOXdiERPDC+Vii8DyivL3vp4liDmw58t3AvpGteE+STVh8QvyYD1SXoaoPUTAB Fu50V06BvneE1AOB9NyhkkhHe3/KhprXgrGip/9zei+PqUoLPuLy7E+fmvvnGtPaun 2I+F1ZtSPJ7krbco6i4pnvW/YoXrVynpr0OLtnnO+B4XC40hn8SKW9Iq797zMlxH3b Yd/7X7L1ncJRw== X-Gm-Message-State: ACrzQf2jkavlV/9y0GAZrt+VKsJEKEaxOp3F5M4FZ4eiIswUGclhKrXx g+HDhXz9BsMl/ncRBzU9Z88SAdiclDj7aCv7GXM= X-Google-Smtp-Source: AMsMyM7t5cQJ9hJx6xjrAJTWEfjKbUDevZQY6USEnBYzXwQs0wF27IzFulILlj/o9uw7ykYh3FpqgxTj+d47/dk/PFQ= X-Received: by 2002:a05:6512:3691:b0:4a1:f82a:9067 with SMTP id d17-20020a056512369100b004a1f82a9067mr3981182lfs.110.1664555468264; Fri, 30 Sep 2022 09:31:08 -0700 (PDT) MIME-Version: 1.0 References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> In-Reply-To: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> From: Ard Biesheuvel Date: Fri, 30 Sep 2022 18:30:57 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered To: Jan Beulich Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" On Fri, 30 Sept 2022 at 08:44, Jan Beulich wrote: > > On 30.09.2022 01:02, Demi Marie Obenour wrote: > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DATA, > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > must not use EFI tables from such memory. Most of the remaining EFI > > memory types are not suitable for EFI tables, leaving only > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > > use tables that are located in one of these types of memory. > > > > This patch ensures this, and also adds a function > > (xen_config_table_memory_region_max()) that will be used later to > > replace the usage of the EFI memory map in esrt.c when running under > > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > > but I have not implemented this. > > > > Signed-off-by: Demi Marie Obenour > > In Xen we don't clobber EfiBootServices{Code,Data} when xen.efi was passed > "-mapbs". Should we perhaps extend the interface such that Dom0 can then > also use tables located in such regions, perhaps by faking > EFI_MEMORY_RUNTIME in the attributes returned by XEN_FW_EFI_MEM_INFO? > I know this ship has sailed for x86, but for the sake of other architectures, I'd strongly recommend leaving the EFI_MEMORY_RUNTIME bits alone, for the same reasons I gave earlier. (Runtime mappings for the firmware code itself, page table fragmentation etc etc) I know very little about Xen, but based on the context you provided in this thread, I'd say that the best approach from the Xen side is to convert all EfiBootServicesData regions that have configuration tables pointing into them into EfiAcpiReclaimMemory. I take it XEN_FW_EFI_MEM_INFO is an existing interface? If so, you might do the same for the returned type - EfiBootServicesData -> EfiAcpiReclaimMemory, and not muck about with the EFI_MEMORY_RUNTIME attribute. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 16:36:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 16:36:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414328.658546 (Exim 4.92) (envelope-from ) id 1oeJ02-000413-7V; Fri, 30 Sep 2022 16:36:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414328.658546; Fri, 30 Sep 2022 16:36:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJ02-00040w-3F; Fri, 30 Sep 2022 16:36:30 +0000 Received: by outflank-mailman (input) for mailman id 414328; Fri, 30 Sep 2022 16:36:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJ00-00040q-SV for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 16:36:28 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 076f86c5-40de-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 18:36:27 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 578D6B8297A for ; Fri, 30 Sep 2022 16:36:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA7AC4347C for ; Fri, 30 Sep 2022 16:36:24 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id u18so7689251lfo.8 for ; Fri, 30 Sep 2022 09:36:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 076f86c5-40de-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664555784; bh=d5fbtNueKCYf5qrhI39a/V/E1KUCYIuE45yESH9w0fI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=az3Q7K5BivT3YLm8upnn9kAtlBofJ74pM/wDynsT7Tf08HBKpOxjxZTMuDjT/byHI vgYEGtFl4EyOWHbC6OF5AED9AiNnx5OYQ32fmAlRPcOvHH2LFYQxPrkmYQi8Y0UOxz IlmIvN6KetN7b8MkROEShqggJTJX1lSyyIxMqxxlrzgPmuGqtrBFV8LIH6v+Vlj6cv O0Dmro/Vo4PmvaAaLHuR4/JrdnneFXS1J6xAamcxwVN8tfeQwlJQQISi6tCwjzvMZR q2dhPzWG494v9ghKKOwEld9J7UUhOVAcIAGTDect00ZeB1tvr4UxxuFOhfiH7LkWtF a4xFuKbJP6OnA== X-Gm-Message-State: ACrzQf2gOIhfpmCoaqTGnrHhX6+sJdZZ/XHcQaeC9Hc6tN9LDVNDmExZ RV5N5Gv+ndYqg4+JoTl6CnoBX9CKDQWqAdGTYvk= X-Google-Smtp-Source: AMsMyM5ve12n8cLZyYpZa8LVcCls8VBD0vJc2Cot7/WlR3erswFDemOYoPS7+eQy3jck7egBvRR0BP8HVox+kYBUJWo= X-Received: by 2002:a05:6512:c0f:b0:49b:1e8c:59fd with SMTP id z15-20020a0565120c0f00b0049b1e8c59fdmr3421440lfu.426.1664555782378; Fri, 30 Sep 2022 09:36:22 -0700 (PDT) MIME-Version: 1.0 References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> In-Reply-To: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> From: Ard Biesheuvel Date: Fri, 30 Sep 2022 18:36:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour wrote: > > fwupd requires access to the EFI System Resource Table (ESRT) to > discover which firmware can be updated by the OS. Currently, Linux does > not expose the ESRT when running as a Xen dom0. Therefore, it is not > possible to use fwupd in a Xen dom0, which is a serious problem for e.g. > Qubes OS. > > Before Xen 4.17, this was not fixable due to hypervisor limitations. > The UEFI specification requires the ESRT to be in EfiBootServicesData > memory, which Xen will use for whatever purposes it likes. Therefore, > Linux cannot safely access the ESRT, as Xen may have overwritten it. > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData > memory, Xen replaces the ESRT with a copy in memory that it has > reserved. Such memory is currently of type EFI_RUNTIME_SERVICES_DATA, > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. This > ensures that the ESRT can safely be accessed by the OS. > > When running as a Xen dom0, use the new > xen_config_table_memory_region_max() function to determine if Xen has > reserved the ESRT and, if so, find the end of the memory region > containing it. This allows programs such as fwupd which require the > ESRT to run under Xen, and so makes fwupd support in Qubes OS possible. > > Signed-off-by: Demi Marie Obenour Why do we need this patch? I'd expect esrt_table_exists() to return false when patch 1/2 is applied. > --- > drivers/firmware/efi/esrt.c | 43 ++++++++++++++++++++++++++----------- > 1 file changed, 30 insertions(+), 13 deletions(-) > > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > index 2a2f52b017e736dd995c69e8aeb5fbd7761732e5..a0642bc161b4b1f94f818b8c9f46511fe2424bb2 100644 > --- a/drivers/firmware/efi/esrt.c > +++ b/drivers/firmware/efi/esrt.c > @@ -243,27 +243,44 @@ void __init efi_esrt_init(void) > void *va; > struct efi_system_resource_table tmpesrt; > size_t size, max, entry_size, entries_size; > - efi_memory_desc_t md; > - int rc; > phys_addr_t end; > - > - if (!efi_enabled(EFI_MEMMAP)) > - return; > + u32 type; > > pr_debug("esrt-init: loading.\n"); > if (!esrt_table_exists()) > return; > > - rc = efi_mem_desc_lookup(efi.esrt, &md); > - if (rc < 0 || > - (!(md.attribute & EFI_MEMORY_RUNTIME) && > - md.type != EFI_BOOT_SERVICES_DATA && > - md.type != EFI_RUNTIME_SERVICES_DATA)) { > - pr_warn("ESRT header is not in the memory map.\n"); > + if (efi_enabled(EFI_MEMMAP)) { > + efi_memory_desc_t md; > + > + if (efi_mem_desc_lookup(efi.esrt, &md) < 0 || > + (!(md.attribute & EFI_MEMORY_RUNTIME) && > + md.type != EFI_BOOT_SERVICES_DATA && > + md.type != EFI_RUNTIME_SERVICES_DATA)) { > + pr_warn("ESRT header is not in the memory map.\n"); > + return; > + } > + > + type = md.type; > + max = efi_mem_desc_end(&md); > +#ifdef CONFIG_XEN_EFI > + } else if (efi_enabled(EFI_PARAVIRT)) { > + max = xen_config_table_memory_region_max(efi.esrt); > + /* > + * This might be wrong, but it doesn't matter. > + * xen_config_table_memory_region_max() checks the type > + * of the memory region, and if it returns 0, the code > + * below will fail without looking at the type. Choose > + * a value that will not cause * subsequent code to try > + * to reserve the memory containing the ESRT, as either > + * Xen or the firmware has done so already. > + */ > + type = EFI_RUNTIME_SERVICES_DATA; > +#endif > + } else { > return; > } > > - max = efi_mem_desc_end(&md); > if (max < efi.esrt) { > pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n", > (void *)efi.esrt, (void *)max); > @@ -333,7 +350,7 @@ void __init efi_esrt_init(void) > > end = esrt_data + size; > pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end); > - if (md.type == EFI_BOOT_SERVICES_DATA) > + if (type == EFI_BOOT_SERVICES_DATA) > efi_mem_reserve(esrt_data, esrt_data_size); > > pr_debug("esrt-init: loaded.\n"); > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab > From xen-devel-bounces@lists.xenproject.org Fri Sep 30 16:39:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 16:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414333.658556 (Exim 4.92) (envelope-from ) id 1oeJ2p-0004cQ-KQ; Fri, 30 Sep 2022 16:39:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414333.658556; Fri, 30 Sep 2022 16:39:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJ2p-0004cJ-Hp; Fri, 30 Sep 2022 16:39:23 +0000 Received: by outflank-mailman (input) for mailman id 414333; Fri, 30 Sep 2022 16:39:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJ2o-0004cA-Oz for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 16:39:22 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6eb993b2-40de-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 18:39:21 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 52D043200A6D; Fri, 30 Sep 2022 12:39:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 30 Sep 2022 12:39:19 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 12:39:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eb993b2-40de-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664555957; x= 1664642357; bh=DoeBKhNM231m+VnHzmoAfyLlv634Z/C2yHlE48QGwmE=; b=R AnXKkXOMSU+BfY4Svif+GgKtE3EZZR3FiZYcOA+s2P9XKphqptvxQcDvtBL7PzQP shp5xMoQBmWW7RNxGlVd+Bv6xE3OjATiKgCM5XGEBiwRC8AW7A4F1ux6kk0nCg2L XqhnZ6kb177nOJAU82R92cE+AupGNIelZS/xmvzxPgj2umJEpRHAHVbCrzbZYCbQ roKywPaJxZyfBR66TVyA4HuO1fWoQWza6Y5ASQ66iEVO3Y1+gBPG9ckXc+qR9ScY 9QV7w5uWcsqdHoPxO5anCFwFHmfNBQ/2BbrUMvcrcFJbloqMtfwsEUk5+IwwsPGd awuq5w4dEiAtXBAqhPc2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664555957; x=1664642357; bh=DoeBKhNM231m+VnHzmoAfyLlv634 Z/C2yHlE48QGwmE=; b=v6oSJCSW4ufsZYuHvjpdFCKETWg0LBcB5eaRsQ5vdWpt vxPD8C9cZc7gDuOAL2nzs3mEj6S9FW/e5pICSLp+1mnoZgBu4cBtpOhGeeD++oQ7 7ZxUDAT511KNqeKQbk3ZgjdUKToYMY4zj2y7lXAIFn0N3kb+Wbg151SA2NqpXwBs srg9BqzDYH+w4tKSBGE5TQlVjS8hEnvnfucrPZoVVL9lYfNbAw1GqBzQVmmxGcxM Km0eT72RYcDN7q5QfGUDuISqLdBHYtnmSMNpsL9/mBmRvcCOFFOQnTf4urccjJtj V/myZcCnbX+TV4MQuV+i5mfsExXXNpEbumvzg9C5Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekteegiefhteehffegvdeggeej udelleeltdffveevtdetfeejuefgieeuhfeuleenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 12:38:44 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Message-ID: References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SGczFINJLmmUm2Ge" Content-Disposition: inline In-Reply-To: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> --SGczFINJLmmUm2Ge Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 12:38:44 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered On Fri, Sep 30, 2022 at 08:44:21AM +0200, Jan Beulich wrote: > On 30.09.2022 01:02, Demi Marie Obenour wrote: > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DAT= A, > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > must not use EFI tables from such memory. Most of the remaining EFI > > memory types are not suitable for EFI tables, leaving only > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > > use tables that are located in one of these types of memory. > >=20 > > This patch ensures this, and also adds a function > > (xen_config_table_memory_region_max()) that will be used later to > > replace the usage of the EFI memory map in esrt.c when running under > > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > > but I have not implemented this. > >=20 > > Signed-off-by: Demi Marie Obenour >=20 > In Xen we don't clobber EfiBootServices{Code,Data} when xen.efi was passed > "-mapbs". Should we perhaps extend the interface such that Dom0 can then > also use tables located in such regions, perhaps by faking > EFI_MEMORY_RUNTIME in the attributes returned by XEN_FW_EFI_MEM_INFO? I can add a check for EFI_MEMORY_RUNTIME, but only if I can require a Xen version with https://lore.kernel.org/xen-devel/cc0fbcb4-5ea3-178c-e691-9acb= 7cc9a3a7@suse.com/t/#u. This is easy in Qubes OS via RPM dependencies, but I am not sure if it is suitable for upstream without a mechanism for dom0 to verify that the patch has been included. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --SGczFINJLmmUm2Ge Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3G7MACgkQsoi1X/+c IsGoBxAA1qb1ePsiOtinAK894ShZXnVAj3jNHthhWj963jYXw6jD9iX2hYAeRFvw ViOU6LodPurxZl4DJpiOW738pLkTYWf6CDfA01oPf2PD9nUA+kdD1doldC3PQ5Pf yBpX0cPWDmP7xnNzdHW/ogcBCBVs6RBwiVFJsklGfKtQ9CfxRCW0q9KGL+YJTkL8 uSNTPe1v+4Q+ZdXs0Qsn/Yj33mOcg7ECO00cT8lgfF4lV/xIvi8jTgWjHVlkK3Qs yxhmIiH0tvdegEu4uLcA15EmcFNi+l3Dkx8WU1674wDy/ZG1DdLljbFRSxp3HUjq i5G2sixSYHn/PH6f6b8mOJFwHDasyDnV3FZbE9oEXAhz8Qz1zp6BlCQ3g/bFTyhU lTVoMNL6AuXFFQ9eRAy5YWcNc/Ypt2eg/IBPXZDBP35Uq/BhYdzVkrlWUvYBhm82 iPZ7yyUsmjots3iLJkHgmA85ZbSDV1oMallsRmosYgTiam9N4/F7eHM3kIAjmnMD yDaD4rQBPYY7a8+GEXfdS1EirIR94Ysb+D6zuMl0f9onBg1eW22955zWYtCgo4pW dNE0NoMzSwdwvHi6VIA51K9Qz/LJMtXiin01RSbmk0vVyIuOnmKQElueQmw8S97O tcxYwdZ6+4h6CZr3Iez+UXsH1rvB89qlW7bdkS3ETJH2RgGCsOo= =pxje -----END PGP SIGNATURE----- --SGczFINJLmmUm2Ge-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 17:12:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 17:12:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414340.658568 (Exim 4.92) (envelope-from ) id 1oeJZ2-0000kv-5E; Fri, 30 Sep 2022 17:12:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414340.658568; Fri, 30 Sep 2022 17:12:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJZ2-0000ko-2W; Fri, 30 Sep 2022 17:12:40 +0000 Received: by outflank-mailman (input) for mailman id 414340; Fri, 30 Sep 2022 17:12:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJZ0-0000kS-IY for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 17:12:39 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11836a74-40e3-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 19:12:35 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 57A833200A35; Fri, 30 Sep 2022 13:12:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 30 Sep 2022 13:12:30 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 13:12:27 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11836a74-40e3-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664557948; x= 1664644348; bh=SmV33aTbZLMaSc7e6x6/a0yD1YxjcfyZWd4pX2uyxNI=; b=u pjub1rvphcp2BMPPN6KmzumKuGefLUM0bp0cVVJSfuTe+Og2D+VZzMDUA3IlqOOI 46cWvOn4Piowd35V+LAQz3UNHY+7bOT5QJnX8RbTeDi8fJTORVfaRttziHhUXzIP 3Ncp91P5Wc31GMsotZmhgvVKodWCCkCuX6iKyexRpaPicUcg4p6/aB5uAOPvIB58 vi8TaEsBy9RMnslMiJORLxTkvwcqiyL84H6FVONEoJg9sc7mL4z3c21AmFaJDCrh Q1fbpOWck9E9wDjO70BhxUjsfFcbEX9dQJ/WhdK4VeRpmE0HO3Ct9z7JrivxJD77 t2drz5P7gpFGrc8I+TIYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664557948; x=1664644348; bh=SmV33aTbZLMaSc7e6x6/a0yD1Yxj cfyZWd4pX2uyxNI=; b=MfoCeDlA0AzErgpeRbND50svu3p1X6qY5uB1ykZoN2Lp 4jNTzojKDLLTEUu/DLSBWJuuK3KLP7cuUywLuZOEzd6ttE+iklRiabpAm0Tc+Ddr qU4lQdua9KF9BtePgXlviNc+EFvuWmCiMlhmnzbhioQXznJdJppc7OkhTe6JedmN NCG6lavcPLHcSWniFut3ZUa1PfFzfSLr3TMvcDh1FaAxBrqVRU0wlD4fEfcXmLtN aCicyEH5Q50Vry9j/HBKoA0XdizN/OZchTX2JnQk/NSQCkJeX4xi3Cg+Ttz73OW2 +8sKOWQws3ibpwiIHH4VF4OAF9AxOIeDTFRNtK6Uiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffej geejgeffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 13:11:59 -0400 From: Demi Marie Obenour To: Ard Biesheuvel , Jan Beulich Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Message-ID: References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+TWbr9kogh5/wchI" Content-Disposition: inline In-Reply-To: --+TWbr9kogh5/wchI Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 13:11:59 -0400 From: Demi Marie Obenour To: Ard Biesheuvel , Jan Beulich Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered On Fri, Sep 30, 2022 at 06:30:57PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 08:44, Jan Beulich wrote: > > > > On 30.09.2022 01:02, Demi Marie Obenour wrote: > > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_D= ATA, > > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > > must not use EFI tables from such memory. Most of the remaining EFI > > > memory types are not suitable for EFI tables, leaving only > > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > > > use tables that are located in one of these types of memory. > > > > > > This patch ensures this, and also adds a function > > > (xen_config_table_memory_region_max()) that will be used later to > > > replace the usage of the EFI memory map in esrt.c when running under > > > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > > > but I have not implemented this. > > > > > > Signed-off-by: Demi Marie Obenour > > > > In Xen we don't clobber EfiBootServices{Code,Data} when xen.efi was pas= sed > > "-mapbs". Should we perhaps extend the interface such that Dom0 can then > > also use tables located in such regions, perhaps by faking > > EFI_MEMORY_RUNTIME in the attributes returned by XEN_FW_EFI_MEM_INFO? > > >=20 > I know this ship has sailed for x86, but for the sake of other > architectures, I'd strongly recommend leaving the EFI_MEMORY_RUNTIME > bits alone, for the same reasons I gave earlier. (Runtime mappings for > the firmware code itself, page table fragmentation etc etc) Why do you say that it has sailed for x86? > I know very little about Xen, but based on the context you provided in > this thread, I'd say that the best approach from the Xen side is to > convert all EfiBootServicesData regions that have configuration tables > pointing into them into EfiAcpiReclaimMemory. Should Xen convert the entire region, or should it try to reserve only the memory it needs? The latter would require it to parse the configuration tables. Is there a list of configuration tables that can legitimately be in EfiBootServicesData regions? > I take it XEN_FW_EFI_MEM_INFO is an existing interface? If so, you > might do the same for the returned type - EfiBootServicesData -> > EfiAcpiReclaimMemory, and not muck about with the EFI_MEMORY_RUNTIME > attribute. It is indeed an existing interface, and this is a much better idea than what you proposed. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --+TWbr9kogh5/wchI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3I3kACgkQsoi1X/+c IsHimRAAopJdHd1YzyxGmCQs/5C27GsZ6O2Z2oo4shynl65qxosa4wjyQ+hf0uBh 9UUbiWVqVuQHlw2SNR4RklZ9a4lVENb85rfkvFkGkb5JrGVU7PgCpYsNZJ0ZSDiW SW4w4QR87BwF23Bk6GEiCL+dWTq1wH4iq89tX/S1LhvjaAh88tMf6Xm2lKuS2nek EjfjWnWDtHLoj7K7M09b5m/8ofqofqiLvqCup6JRvambXHezEEgisxE3FeX3jmOA Iw8e656o0sia+GK1mMfa1vf7+lHt+bmULbM9Qtjh4OzAim7NIycRj+8mNfnXmhWW 2hozW1E5ALre+lmdDuV9cRStlRmaXVv7YXNav+ia36xMDcxsTQP6V1scmdbkKk29 GxGq8fIU9ySZXmtrygIAF+RU4V4BLe72sqee/K+FcnHcUqJ6WaHW1TYP57eDNfoL XThEJy7ZSwhVn7KxtQhr16aqysit7XeVr1OjRooP8ju5DouAumAdpEqZTUO8ruLH dg2AN5DlD3WB8g5x5jFc/UHRvF5cEbNawEfEO6wkPVFozynIDXdvWQDQ/+0t5LnB TbrEnfoeuiGn5PMB0paCrQKdr4mOxyZHe/EigAEhnMkWo4QyseG6yBme+Ee6N7sv 3A3g8YohKWHsRxRPHc7cdgVjAgc5Wsb1SlNNdgYwBVxW2udbzJ8= =ag4U -----END PGP SIGNATURE----- --+TWbr9kogh5/wchI-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 17:24:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 17:24:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414349.658579 (Exim 4.92) (envelope-from ) id 1oeJkc-0002Ue-Aq; Fri, 30 Sep 2022 17:24:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414349.658579; Fri, 30 Sep 2022 17:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJkc-0002UX-89; Fri, 30 Sep 2022 17:24:38 +0000 Received: by outflank-mailman (input) for mailman id 414349; Fri, 30 Sep 2022 17:24:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJkb-0002UA-2B for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 17:24:37 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf18a866-40e4-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 19:24:34 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Sep 2022 13:24:26 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5904.namprd03.prod.outlook.com (2603:10b6:a03:2d3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 17:24:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 17:24:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf18a866-40e4-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1664558674; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=C0xqu+XdbbFM/6298Hdd8iGax2hDaPe0NzyWhFnr83I=; b=fqaYopuA2TiAX7TKoalqwQREFhyeSWXeTimpjE6pPw1RUa4Gilelj0+1 /RtVtn2bSdQHBYXI4/LXftxT7oc3tNLowIk5jsPWmTHEz8KNkTQqZ4RIP LtpA/U/6JexXyeFVGBbQWIHVNOeAgJ34uGsc+VJWG94zURWsWeUY/XWPe g=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 81381861 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4oETwqw9FgLZYM942y56t+evxyrEfRIJ4+MujC+fZmUNrF6WrkUCy WBJXTrQM/3bZDD0f90gaNuz8ExX75HWy9BnGVA9+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFsMpvlDs15K6o4GJD5gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwMYoGVNhx PohOD0IaBu43/3ny6udVbw57igjBJGD0II3nFhFlGmcJ9B5BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/exuuzi7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+WxnOiCNxLfFG+3qdPvFe5/lEvNB5ISl6+hcCGsx+MXOsKf iT4/QJr98De7neDS9DnWhSirX2svxgCWsFRGek39AGMzKXP5w+TQGMDS1ZpatYrqcs3TjwCz UKSkpXiAjkHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXrnTMtnEaOzps34H3f32 T/ihDMlm7wZgMoP1qO61VPKmTShot7OVAFdzhrTdnKo6EV+foHNT4Cl7Fnz7PBeLZ2YRF2Mo HgFnceF6OkES5qKkUSlYOgLBqDv2P+DPxXVm1spFJ4knwlB4FamdIFUpTt4e0FgN59cfSezO ReD/wRM+JVUIX2mK7dtZJ68ANgryq6mEsn5UvfTbZxFZZ0ZmBK7wRyCrHW4hwjF+HXAW4lkU XtHWa5A1UonNJk= IronPort-HdrOrdr: A9a23:XXbxxayZlbeFesUNw1ZVKrPxmuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFjUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZDN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GbQMkHboUoTAjnZuBOlaDLY0LLErHhRMbs/uatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAiqqOYmwtUrQcotQ0obaIOLLtK6YAP9kJcF5kNWCr89YA8Ce FrSMXR/uxff1+WZ23Q+jAH+q3mYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/ nNdq5oiLZNRMkLar8VPpZIfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4uKfaWK 6xJW+wmVRCCH4GU/f+raGj2iq9MFmVTHDq1txU4YR/t/n1WKfrWBfzOmwTrw== X-IronPort-AV: E=Sophos;i="5.93,358,1654574400"; d="scan'208,217";a="81381861" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAxDhf4kVq7DMoAsd60UOk8vW0EyV0d+UZaQ/yOP2NzQ85L+to7Jp2U5EeSIaa4jVS495EqMgCKr6AHaYRtlKK/5Hd5YKB0KZPSRxZq7w/Qp7q41c1IPW6lllOfhI7f4lmLDkQzz2tWEfMpi6iUoCTnSEboLmghU8fNzEBgNP+wAau1Bk0HnFwUY/2Qf17K2iKv2ICOfTJ8yzDCBE55cNDrCSW5xs3lGf5wXoqshjpip8jxK1HlYaos7R8FOfcUJut2LKoskA7ILp3O7YxbsPCrEUQQewRhWGUAk6UM4OY8dxLb7HHhLu70D29dgnQHs7kjCifV6kt7bckS7uPhLag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C0xqu+XdbbFM/6298Hdd8iGax2hDaPe0NzyWhFnr83I=; b=iMg24y1WfS+6JIrDSaRAgPZ0daC1s0RlvqHMa4+IXcS4g7gKJ96w39day1WFtSgNzFrKgY41qMXiqU5s13mHoazz+FpExIOoLvFJRJJSMLV1c4Pq7xjS8eLXLla6Z7kE/4mi2v8MIydqOJAL7ygWn+85YX34L5VHC3GpBNuEEGjO2vz0eMAj4LDaIfTqOY+GtHP0VLrvnrXJzcDAVJxpEbTHX2MNUvw6o86VB1az/t0vhuWEUogto4Df7+wL6namZuyD1FHHVh7bMVsPG3LD5qBfqUv2VRD2PX4T0rTnLzCjbT01tptpbjgRVMlFydjENMPgry3P8hsEmnRfHijsZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C0xqu+XdbbFM/6298Hdd8iGax2hDaPe0NzyWhFnr83I=; b=k4TcSOFQi8QAJ7gOYQVbha2+WQL7Dsk3frX/ZQPHA34gS2SsVAmEoiJScUMAojU21VUvEsZ0XY8gST5d/GbmlePWvB2PFTtdD0C/iGywW7zJPDDwQ+8rVehzENHdzu2f7jrTv23pus9KG4Ia7/Ghb3WfQUaklstbfjO/x4lyKUk= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: Jan Beulich , "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau Monne , Demi Marie Obenour , Henry Wang Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing mode Thread-Topic: [PATCH for-4.17?] x86: support data operand independent timing mode Thread-Index: AQHYyOqg1ICCMP96kUmBwLmrDRKGKa337MYAgABHrwCAAByoAA== Date: Fri, 30 Sep 2022 17:24:21 +0000 Message-ID: <04f7de01-4e8e-b964-d676-d756265c2776@citrix.com> References: <8f07c532-e742-fa02-27ee-b08c56299d09@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5904:EE_ x-ms-office365-filtering-correlation-id: 9c784290-132d-4af8-ef84-08daa3089cf7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wID4IZFZ09AQvGr5606Hf4guW9MbOAT1Qesf5f/VpLHjAwydbsMdWjHDIAm2q49Aniwyw43euA+I2LsOoKGjzcBcHKYlSaR2yM8l2EUNorV8uWBN5hYOVKL9Vz5pClG4yGK7gIxoJoqFh3bPdUKwvDlby1sUE+8CsbPGXoOPBvMIv/B3ZGG2AUyADmgPPCGX9u+M9FAwBsUZWZHhiFdErfAH6p+LqlwXJhUWHjf7nfNIuhExHSP+8jP+efXRD7TlrIyTvZiaLnUOm0yIZ2qbQg1sxfDNCKkAogNqiCEe/aSCWr4Z8Z0WJ97ktD5EjNef4V0ISAI4dgR3ai2iEeANVeypEztHBC2ohPkHC3mk5swz007xsOgvnw2AS/okxTCDDy1u2fwDV+v3FcV8iTLEGQeOsqiTqivLGAxv+B9oUgZTVpRu5OjpIG/7qKQiu/iPOOB4P7E63qGONyt4Zp2iRL/3RNDnfJIG01B7e7VZNrrw1Qb3t0JqAUnTIxaK/hP9vatFtPp3UKpiA9eeOp9CHvH2cUY/Ad5YVM8Wjavzfs1rrZTDZpVzDqc7scl6qgiytNSVfYZvoz0RgXcYE17hY+Fp6jCPqZS2k99bGbOW8RiSV9+wR5z9gUoLil54no0eaJ0Zq7k9pcRQ0DExwEtSBQEjUncF2exKEBGT0wD0wIRW/Z8ekRV3J5arizfc/hiQZkm+0Y1J2lD8aDnxFDrgDHsyy+NiUdaQXqbhhCckdGCBL1Zh12bsVuFKfcELq1kv2B9b78P1I4beyrJQetk2orr4FvMlm/tZTWSq6cQyMMQFfyG1Hfe3idnhdLOnN381lsou49cx/Q1BGa2BUreD1nBMn6Rzr5BLCvDTuw2BVE0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(6486002)(6916009)(31686004)(316002)(54906003)(86362001)(31696002)(8676002)(966005)(478600001)(71200400001)(53546011)(91956017)(6506007)(66476007)(66556008)(64756008)(66946007)(41300700001)(76116006)(26005)(6512007)(8936002)(4326008)(38100700002)(66446008)(38070700005)(5660300002)(21615005)(166002)(2906002)(2616005)(36756003)(186003)(66574015)(122000001)(82960400001)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UTRpd3NXeHZBOEhYcHdkdmErM1hYa1lPelNWaERjdkhoZUpIc04rSXNXQldR?= =?utf-8?B?ZldOTisxWWhmazgybDRPT2hoMmRmSU0rS1BJb21WblhCWDdFaUZBdUZaeTFE?= =?utf-8?B?a1ArYktORFpyaWM1RmdNZ01wbndtaE94ZENIWE5TRTl1REJsS3BTRDVML1NG?= =?utf-8?B?TUI4YXBQNWIvVHBUcjE3aUJLMEE0bG1MZmZxQkRpcWpvWjliRHE4Z2ZLTzNs?= =?utf-8?B?c3ROQkZtWGZrMzJWdUNiNFBQUEpUVHluQ1Jxb2N5dFVLTHlrM0NwVk5YVnJr?= =?utf-8?B?Skt2cUFRZHBNcCs3M2pRcDNpTld3Y1dMZDROYlE3ZTlBTWE2eFlsTlhPMUQv?= =?utf-8?B?MkQ5d2FUQ1RLaHZzYTdJbERQaHpKa0ZCWVhiZzRmNnRmMjdiQXVpaVhWRkpq?= =?utf-8?B?dmpzcmNoZVFpNkdJaFVDQk5JZVorK2RiYlhybWxXNXpPUUxpMk41STJ1NVF3?= =?utf-8?B?bkZ4T1RBVUxwcVYrMkJXNEtyV2RQUzBnMVE1Z21odmFwN1ZyeVRhYi94Zzg5?= =?utf-8?B?WlcvNWxSK2dJTEdSWWc1Nnphd3N0aWxnamtJTjlCVFEzQmk0RmM4ZWlVV0Rt?= =?utf-8?B?Y3ZNRU82YURvMjBtRElMKytKMWpMZmcxeGJwbnVDTUN2SjdoWERtT1B0dlhm?= =?utf-8?B?VVNLZkYvSGxUUzVSRUUvZk1YTnlFZHhsTUJTRHJtQWxLMVFOSEZrZU03QXhi?= =?utf-8?B?M0JacW44RmRTYnBwL2ZDc3N3Z3hNMGxNSW9zZFBjcjNJWDJORlY4eFQ5U3Yz?= =?utf-8?B?NE1kQmZQaGVscHh2bnNrdmcvdTZBNy8rZG1ub2hDZ09pV0RhSGpZTDRPYTZE?= =?utf-8?B?cGpXTVQwR2JEekVtMjlCNE83VmxPaWlNWDJlZFh6T3lDQkFuTDZnUTJPQU1y?= =?utf-8?B?TUFOWWF5bWdJZkh5R2VNVGFIbWJ5SkJXS0tSa2RFTjJNMExkMHZWVnoxb2RG?= =?utf-8?B?NjM5MzBmRVpHbDdwdDA1RHp5MzYzWkR0ZGpLL1JKL0N5YTZEejJvODVxczV3?= =?utf-8?B?SW1DRWJaSUNkT3F2QTYxSmFLWlJYZUw0L1o5Qm1FRjhkN2Z3NHVJdHoxYkho?= =?utf-8?B?QTBWZFVYdUl1ejVpSitTYTQxMWJOaDdONk93YmNSOUFtSG40ZWVTR0FNV2Vu?= =?utf-8?B?NzRXZWpIQ3FRV0VmNlp4TTVFT0ErblhvbjAvdmhQS0pUUzM2ZVFiYnhnRitW?= =?utf-8?B?a3pYS0V5T2ZyeFhJSXVPYVd1SERsOUNRVmZPS0hzMHd4c0lYQm45TFVGS201?= =?utf-8?B?SVhCdnMvbVBmbjdyMGpjTkZWZThRWmJiYmhIMDdMVFloV0RnRnJZejFiQkti?= =?utf-8?B?RFJMWmJBMmNycmhBUC90Z3dCcHdDS3F5eXdWQmloN055dTg2Nk1oaFd3Snl5?= =?utf-8?B?SU9ra1BRdGZyT2I2YSt6UUZLRjVSbGs2SU9idnk5Wjdha2R0MU5ZbG1zR0dM?= =?utf-8?B?aHp0c01IaDFmS2tFbEp6WFhLV3I5blJvem9tUEJlN2o2YWZmbmtVUGRrSnJa?= =?utf-8?B?b2xINXhRZmdiemVvSTRwV085aFpyMkljbVNGbGVJOU9OVWFTVFZyNHZXaUNh?= =?utf-8?B?aEQrT3BOTVhBV1BxZWJJV3EzekJSN0o0MVFGQUwwTG1SZXN5Z1A2L2dFK0NH?= =?utf-8?B?MEJkZWk5UXJseFQ3TVBYRSt1QVJJQWhHRjlxdkJlTXVUeEJjaEp3NVlvRVE0?= =?utf-8?B?alE1ZXZWK0lTWURKZ3NJMUp1YlBkck5QY3M3TTBxUTNiMUZPc1Z0WFNSS3RG?= =?utf-8?B?dmFNaDFMUDVtSHBoRUdtbGRsUDJQdHgvcDRxYUJLUFNzaWU5VU9TVzN2b3lV?= =?utf-8?B?eDFQeUhnQ0xDOFdtUFBWWlM4OVlnRko5UGVQdDRaSVhyaWNMbEkxSlBac1Nw?= =?utf-8?B?M2NvQ01ZUVNpK1gxUUJXTVpHQm82aVZtTkdzbElpRHBZcHZzcVl2V244OWFJ?= =?utf-8?B?ZFdPYWtoTzFneDZPT2paMUJTZ0wxclVvMWRWZGUrRnhoZUp5VkprY1BaSnVC?= =?utf-8?B?TTFSSVl6OHlOYWZiOGRDdDB2aXI4QWR5akZ0S1ZuZXhnVCsxeFdmV1drcldP?= =?utf-8?B?V0ZXYmJwM3JhcUxMYnIxSEgyUkVTTXM1UG11VXdsc2Z5d1JaS08yb21yaWJK?= =?utf-8?Q?3v5K5IHHW8t8eEIZ0Nv72s5hP?= Content-Type: multipart/alternative; boundary="_000_04f7de014e8eb964d676d756265c2776citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c784290-132d-4af8-ef84-08daa3089cf7 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 17:24:21.4594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dTMD2cvOejYP7ir3qI3RHBPwc2o6F4svhqNiNxqEgzGbzUZ5zpHESaCLOFUgDecCUiFKubIBVzEgxB4DaW/mqWAW2EZkFffVgrT+ZUK1j+E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5904 --_000_04f7de014e8eb964d676d756265c2776citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gMzAvMDkvMjAyMiAxNjo0MSwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K DQpPbiBGcmksIFNlcCAzMCwgMjAyMiBhdCAxMToyNToxMkFNICswMDAwLCBBbmRyZXcgQ29vcGVy IHdyb3RlOg0KDQoNCk9uIDE1LzA5LzIwMjIgMTE6MDQsIEphbiBCZXVsaWNoIHdyb3RlOg0KDQoN ClsxXSBzcGVjaWZpZXMgYSBsb25nIGxpc3Qgb2YgaW5zdHJ1Y3Rpb25zIHdoaWNoIGFyZSBpbnRl bmRlZCB0byBleGhpYml0DQp0aW1pbmcgYmVoYXZpb3IgaW5kZXBlbmRlbnQgb2YgdGhlIGRhdGEg dGhleSBvcGVyYXRlIG9uLiBPbiBjZXJ0YWluDQpoYXJkd2FyZSB0aGlzIGluZGVwZW5kZW5jZSBp cyBvcHRpb25hbCwgY29udHJvbGxlZCBieSBhIGJpdCBpbiBhIG5ldw0KTVNSLiBQcm92aWRlIGEg Y29tbWFuZCBsaW5lIG9wdGlvbiB0byBjb250cm9sIHRoZSBtb2RlIFhlbiBhbmQgaXRzDQpndWVz dHMgYXJlIHRvIG9wZXJhdGUgaW4sIHdpdGggYSBidWlsZCB0aW1lIGNvbnRyb2wgb3ZlciB0aGUg ZGVmYXVsdC4NCkxvbmdlciB0ZXJtIHdlIG1heSB3YW50IHRvIGFsbG93IGd1ZXN0cyB0byBjb250 cm9sIHRoaXMuDQoNClNpbmNlIEFybTY0IHN1cHBvc2VkbHkgYWxzbyBoYXMgc3VjaCBhIGNvbnRy b2wsIHB1dCBjb21tYW5kIGxpbmUgb3B0aW9uDQphbmQgS2NvbmZpZyBjb250cm9sIGluIGNvbW1v biBmaWxlcy4NCg0KWzFdIGh0dHBzOi8vd3d3LmludGVsLmNvbS9jb250ZW50L3d3dy91cy9lbi9k ZXZlbG9wZXIvYXJ0aWNsZXMvdGVjaG5pY2FsL3NvZnR3YXJlLXNlY3VyaXR5LWd1aWRhbmNlL2Jl c3QtcHJhY3RpY2VzL2RhdGEtb3BlcmFuZC1pbmRlcGVuZGVudC10aW1pbmctaXNhLWd1aWRhbmNl Lmh0bWwNCg0KUmVxdWVzdGVkLWJ5OiBEZW1pIE1hcmllIE9iZW5vdXIgPGRlbWlAaW52aXNpYmxl dGhpbmdzbGFiLmNvbT48bWFpbHRvOmRlbWlAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NClNpZ25l ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT48bWFpbHRvOmpiZXVsaWNo QHN1c2UuY29tPg0KDQoNCg0KVGhpcyBwYXRjaCBzaG91bGQgbm90IGJlIHRha2VuOyBhdCBsZWFz dCBub3QgaW4gdGhpcyBmb3JtLiAgVGhlIHdob2xlDQpET0lUTSBpbmZyYXN0cnVjdHVyZSBpcyBj dXJyZW50bHkgdW5kZXIgYXJndW1lbnQsIGZvciBiZWluZyBpbXBvc3NpYmxlDQp0byB1c2UgYXBw cm9wcmlhdGVseS4NCg0KSSB1bmRlcnN0YW5kIHdoeSBRdWJlcyB3YW50IHRoaXMgYmxhbmtldCBz ZXQsIGJ1dCBpdCBpcyBhIHN0ZWVwIHBlbmFsdHkNCnRvIHBheTsgIEl0J3Mgb25seSBjb2RlIHdo aWNoIGlzIGFscmVhZHkgd3JpdHRlbiB0cnlpbmcgdG8gYmUgY29uc3RhbnQNCnRpbWUvY2FjaGUg d2hpY2ggZ2FpbnMgYW55IHNlY3VyaXR5IGZyb20gdGhpcy4NCg0KDQoNCkJhc2VkIG9uIHRoZSBi aXQgZGVzY3JpcHRpb24sIEknZCBzYXkgcmF0aGVyICJwcmV2ZW50IF9icmVha2luZ18NCnNlY3Vy aXR5IG9mIHRoZSBjb2RlIGFscmVhZHkgd3JpdHRlbiIuIEl0IGlzIG5vdCBzZXR0aW5nIHRoaXMg Yml0IHRoYXQNCmNoYW5nZSBiZWhhdmlvdXIgb24gbmV3IHBhcnRzLCBidXQgaXQncyBub3Qgc2V0 dGluZyBpdCB0aGF0IGJyZWFrcw0KcHJldmlvdXMgZ3VhcmFudGVlcy4gSXQncyByZWFsbHkgYml6 YXJyZSBkZXNpZ24gY2hvaWNlIGZyb20gSW50ZWwuLi4NCg0KDQoNCiBPbiBjdXJyZW50IHBhcnRz LCB1c2luZw0KU1NCRCBoYXMgdGhlIHNhbWUgYmVoYXZpb3VyLCBidXQgdGhpcyBpc24ndCBleHBl Y3RlZCB0byByZW1haW4gdHJ1ZSBpbg0KdGhlIGZ1dHVyZS4NCg0KRm9yY2luZyBpdCBvbiBiZWhp bmQgdGhlIGJhY2sgb2YgYSBWTSBpcyBtdXR1YWxseSBleGNsdXNpdmUgd2l0aA0KZW51bWVyYXRp bmcgaXQgZm9yIFZNcyB0byB1c2UgYXQgc29tZSBwb2ludCBpbiB0aGUgZnV0dXJlIHdoZW4gd2Ug aGF2ZQ0KdGhlIGNhcGFiaWxpdHkgdG8uICBpLmUuIHNwZWNpZmljYWxseSwgeW91IGFyZSBub3Qg YWJsZSB0byBtYWludGFpbiB0aGUNCkFCSS9BUEkgaW4gdGhpcyBwYXRjaCBpbiB0aGUgZnV0dXJl Lg0KDQoNCg0KUmVnYXJkaW5nIHRoZSBjdXJyZW50IGJlaGF2aW9yIG9mIHRoZSBoeXBlcnZpc29y ICh3aXRob3V0IHRoaXMgcGF0Y2gpOg0Kd2lsbCBndWVzdCBzZWUgRE9JVE0gcHJlc2VudCBidXQg bm90IHNldD8gT3Igd2lsbCB0aGV5IG5vdCBzZWUgaXQgYXQNCmFsbD8NCg0KRG9jdW1lbnRhdGlv biBjbGVhcmx5IHN0YXRlOg0KICAgIEZvciBJbnRlbMKuIENvcmXihKIgZmFtaWx5IHByb2Nlc3Nv cnMgYmFzZWQgb24gbWljcm9hcmNoaXRlY3R1cmVzDQogICAgYmVmb3JlIEljZSBMYWtlIGFuZCBJ bnRlbCBBdG9twq4gZmFtaWx5IHByb2Nlc3NvcnMgYmFzZWQgb24NCiAgICBtaWNyb2FyY2hpdGVj dHVyZXMgYmVmb3JlIEdyYWNlbW9udCB0aGF0IGRvIG5vdCBlbnVtZXJhdGUNCiAgICBJQTMyX1VB UkNIX01JU0NfQ1RMLCBkZXZlbG9wZXJzIG1heSBhc3N1bWUgdGhhdCB0aGUgaW5zdHJ1Y3Rpb25z IGxpc3RlZA0KICAgIGhlcmUgb3BlcmF0ZSBhcyBpZiBET0lUTSBpcyBlbmFibGVkLg0KDQpTbywg aWYgZ3Vlc3RzIHdpbGwgbm90IHNlZSB0aGUgZmVhdHVyZSBhdCBhbGwsIGl0IFhlbiBzaG91bGQg c2V0IGl0DQp1bmNvbmRpdGlvbmFsbHksIHRvIHJlbWFpbiBjb21wbGlhbnQgd2l0aCBleHBlY3Rl ZCBoYXJkd2FyZSBiZWhhdmlvdXIuDQoNCklmIGd1ZXN0cyB3aWxsIHNlZSB0aGUgdGhpbmcgKGFu ZCBzZWUgaXQgbm90IGVuYWJsZWQpLCB0aGVuIGluZGVlZCBpdCdzDQpsZXNzIGNsZWFyIHdoYXQg c2hvdWxkIGJlIGRvbmUgcmlnaHQgbm93IChidXQgSSdkIHN0aWxsIGxpa2UgdG8gaGF2ZSBhbg0K b3B0aW9uIHRvIGVuYWJsZSBpdCkuDQoNCkhtbS4gIFNvIHllcywgbGV0cyBhcHByb2FjaCB0aGUg cHJvYmxlbSBmcm9tIHRoZSBvdGhlciBzaWRlLCBhcyAidGhpcyBiaXQgbmVlZHMgc2V0dGluZyB0 byB1bmJyZWFrIGNyeXB0byBjb2RlIi4NCg0KT24gaGFyZHdhcmUgc3VwcG9ydGluZyBET0lUTSwg d2hlcmUgd2UgZG8gbm90IGFkdmVydGlzZSB0aGUgZmVhdHVyZSB0byBndWVzdHMgKGFsbCBndWVz dHMgcmlnaHQgbm93KSwgdGhlIGd1ZXN0IGtlcm5lbCB3b3VsZCBjb25jbHVkZSB0aGF0IGl0IGlz IHNhZmUsIHdoZW4gaW4gZmFjdCBpdCBpcyBub3QuDQoNClNvIFhlbiBzaG91bGQgc2V0IHRoZSBi aXQgYmVoaW5kIHRoZSBiYWNrIG9mIGEgZ3Vlc3Qgd2hpY2ggZG9lc24ndCBoYXZlIHRoZSBET0lU TSBlbnVtZXJhdGlvbiBwcmVzZW50ZWQgKHdoaWNoIGlzIGFsbCBndWVzdHMgcmlnaHQgbm93KS4N Cg0KQnV0IEkgZG9uJ3QgdGhpbmsgd2Ugd2FudCBhbnkgS2NvbmZpZyBhYm91dCB0aGlzLCBvciBh IGRlZGljYXRlZCBjbWRsaW5lIG9wdGlvbi4gIFNvIGhvdyBhYm91dCB0aGlzIGZvciBhIHBsYW4g d2hpY2ggYXZvaWRzIHBhaW50aW5nIG91cnNlbHZlcyBpbnRvIGEgY29ybmVyLg0KDQoxKSBFeHRl bmQgY3B1aWQ9IHdpdGggYSBuby1kb2l0bSBvcHRpb24uICBJIGtub3cgaXQncyBub3QgYWN0dWFs bHkgYSBDUFVJRCBlbnVtZXJhdGlvbiwgYnV0IE1TUl9BUkNIX0NBUFMgc2hvdWxkIGhhdmUgYmVl biBDUFVJRCBkYXRhLCBhbmQgdGhpcyBpcyB0aGUgbWVjaGFuaXNtIHdlIGhhdmUgbWVhbmluZyAi cHJldGVuZCB0aGlzIGZlYXR1cmUgaXNuJ3QgZW51bWVyYXRlZCIuDQoNCjIpIE9uIGJvb3QsIGFu ZCBTMyByZXN1bWUsIGlmIERPSVRNIGFuZCBhdmFpbGJsZSwgc2V0IGludmFyaWFudCBtb2RlLg0K DQpUaGF0IHNob3VsZCBkbyBhcyBhIHN0b3BnYXAgZm9yIG5vdyB0aGF0IGtlZXBzIHNvZnR3YXJl IHNhZmUuDQoNCg0KVGhlbiwgd2hlbiB3ZSd2ZSBnb3QgTVNSX0FSQ0hfQ0FQUyB3b3JraW5nIGZv ciBndWVzdHMsIHRoZSBpbnRlcm5hbHMgb2YgTVNSX1VBUkNIX01JU0NfQ1RMIGNoYW5nZSB0byBi ZWluZyBhIGNvbnRleHQgc3dpdGNoZWQgdGhpbmcgd2hpY2gsIGxpa2UgTVNSX1NQRUNfQ1RSTCwg d2UgaGF2ZSBvcHRpb25zIGZvciBiaXRzIHNldCBiZWhpbmQgdGhlIGd1ZXN0J3MgYmFjay4gIFRo ZW4gd2Ugc2V0IERPSVRNIGJlaGluZCB0aGUgZ3Vlc3RzIGJhY2sgaWYgbGV2ZWxsaW5nIGNhdXNl cyB0aGUgZmVhdHVyZSB0byBiZSBoaWRkZW4uICBXZSBkbyB0aGlzIGZvciBzb21lIGJpdHMgYWxy ZWFkeSwgYW5kIG5lZWQgdG8gZG8gc28gZm9yIG1vcmUgY29udHJvbHMgdG9vLg0KDQp+QW5kcmV3 DQo= --_000_04f7de014e8eb964d676d756265c2776citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i bW96LWNpdGUtcHJlZml4Ij5PbiAzMC8wOS8yMDIyIDE2OjQxLCBNYXJlayBNYXJjenlrb3dza2kt R8OzcmVja2kgd3JvdGU6PGJyPg0KPC9kaXY+DQo8YmxvY2txdW90ZSB0eXBlPSJjaXRlIiBjaXRl PSJtaWQ6WXpjT09sdjF6cXpXbEg5ZUBtYWlsLWl0bCI+DQo8cHJlIGNsYXNzPSJtb3otcXVvdGUt cHJlIiB3cmFwPSIiPk9uIEZyaSwgU2VwIDMwLCAyMDIyIGF0IDExOjI1OjEyQU0gKzAwMDAsIEFu ZHJldyBDb29wZXIgd3JvdGU6DQo8L3ByZT4NCjxibG9ja3F1b3RlIHR5cGU9ImNpdGUiPg0KPHBy ZSBjbGFzcz0ibW96LXF1b3RlLXByZSIgd3JhcD0iIj5PbiAxNS8wOS8yMDIyIDExOjA0LCBKYW4g QmV1bGljaCB3cm90ZToNCjwvcHJlPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSI+DQo8cHJlIGNs YXNzPSJtb3otcXVvdGUtcHJlIiB3cmFwPSIiPlsxXSBzcGVjaWZpZXMgYSBsb25nIGxpc3Qgb2Yg aW5zdHJ1Y3Rpb25zIHdoaWNoIGFyZSBpbnRlbmRlZCB0byBleGhpYml0DQp0aW1pbmcgYmVoYXZp b3IgaW5kZXBlbmRlbnQgb2YgdGhlIGRhdGEgdGhleSBvcGVyYXRlIG9uLiBPbiBjZXJ0YWluDQpo YXJkd2FyZSB0aGlzIGluZGVwZW5kZW5jZSBpcyBvcHRpb25hbCwgY29udHJvbGxlZCBieSBhIGJp dCBpbiBhIG5ldw0KTVNSLiBQcm92aWRlIGEgY29tbWFuZCBsaW5lIG9wdGlvbiB0byBjb250cm9s IHRoZSBtb2RlIFhlbiBhbmQgaXRzDQpndWVzdHMgYXJlIHRvIG9wZXJhdGUgaW4sIHdpdGggYSBi dWlsZCB0aW1lIGNvbnRyb2wgb3ZlciB0aGUgZGVmYXVsdC4NCkxvbmdlciB0ZXJtIHdlIG1heSB3 YW50IHRvIGFsbG93IGd1ZXN0cyB0byBjb250cm9sIHRoaXMuDQoNClNpbmNlIEFybTY0IHN1cHBv c2VkbHkgYWxzbyBoYXMgc3VjaCBhIGNvbnRyb2wsIHB1dCBjb21tYW5kIGxpbmUgb3B0aW9uDQph bmQgS2NvbmZpZyBjb250cm9sIGluIGNvbW1vbiBmaWxlcy4NCg0KWzFdIDxhIGNsYXNzPSJtb3ot dHh0LWxpbmstZnJlZXRleHQiIGhyZWY9Imh0dHBzOi8vd3d3LmludGVsLmNvbS9jb250ZW50L3d3 dy91cy9lbi9kZXZlbG9wZXIvYXJ0aWNsZXMvdGVjaG5pY2FsL3NvZnR3YXJlLXNlY3VyaXR5LWd1 aWRhbmNlL2Jlc3QtcHJhY3RpY2VzL2RhdGEtb3BlcmFuZC1pbmRlcGVuZGVudC10aW1pbmctaXNh LWd1aWRhbmNlLmh0bWwiPmh0dHBzOi8vd3d3LmludGVsLmNvbS9jb250ZW50L3d3dy91cy9lbi9k ZXZlbG9wZXIvYXJ0aWNsZXMvdGVjaG5pY2FsL3NvZnR3YXJlLXNlY3VyaXR5LWd1aWRhbmNlL2Jl c3QtcHJhY3RpY2VzL2RhdGEtb3BlcmFuZC1pbmRlcGVuZGVudC10aW1pbmctaXNhLWd1aWRhbmNl Lmh0bWw8L2E+DQoNClJlcXVlc3RlZC1ieTogRGVtaSBNYXJpZSBPYmVub3VyIDxhIGNsYXNzPSJt b3otdHh0LWxpbmstcmZjMjM5NkUiIGhyZWY9Im1haWx0bzpkZW1pQGludmlzaWJsZXRoaW5nc2xh Yi5jb20iPiZsdDtkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20mZ3Q7PC9hPg0KU2lnbmVkLW9m Zi1ieTogSmFuIEJldWxpY2ggPGEgY2xhc3M9Im1vei10eHQtbGluay1yZmMyMzk2RSIgaHJlZj0i bWFpbHRvOmpiZXVsaWNoQHN1c2UuY29tIj4mbHQ7amJldWxpY2hAc3VzZS5jb20mZ3Q7PC9hPg0K PC9wcmU+DQo8L2Jsb2NrcXVvdGU+DQo8cHJlIGNsYXNzPSJtb3otcXVvdGUtcHJlIiB3cmFwPSIi Pg0KVGhpcyBwYXRjaCBzaG91bGQgbm90IGJlIHRha2VuOyBhdCBsZWFzdCBub3QgaW4gdGhpcyBm b3JtLiZuYnNwOyBUaGUgd2hvbGUNCkRPSVRNIGluZnJhc3RydWN0dXJlIGlzIGN1cnJlbnRseSB1 bmRlciBhcmd1bWVudCwgZm9yIGJlaW5nIGltcG9zc2libGUNCnRvIHVzZSBhcHByb3ByaWF0ZWx5 Lg0KDQpJIHVuZGVyc3RhbmQgd2h5IFF1YmVzIHdhbnQgdGhpcyBibGFua2V0IHNldCwgYnV0IGl0 IGlzIGEgc3RlZXAgcGVuYWx0eQ0KdG8gcGF5OyZuYnNwOyBJdCdzIG9ubHkgY29kZSB3aGljaCBp cyBhbHJlYWR5IHdyaXR0ZW4gdHJ5aW5nIHRvIGJlIGNvbnN0YW50DQp0aW1lL2NhY2hlIHdoaWNo IGdhaW5zIGFueSBzZWN1cml0eSBmcm9tIHRoaXMuJm5ic3A7DQo8L3ByZT4NCjwvYmxvY2txdW90 ZT4NCjxwcmUgY2xhc3M9Im1vei1xdW90ZS1wcmUiIHdyYXA9IiI+DQpCYXNlZCBvbiB0aGUgYml0 IGRlc2NyaXB0aW9uLCBJJ2Qgc2F5IHJhdGhlciAmcXVvdDtwcmV2ZW50IF9icmVha2luZ18NCnNl Y3VyaXR5IG9mIHRoZSBjb2RlIGFscmVhZHkgd3JpdHRlbiZxdW90Oy4gSXQgaXMgbm90IHNldHRp bmcgdGhpcyBiaXQgdGhhdA0KY2hhbmdlIGJlaGF2aW91ciBvbiBuZXcgcGFydHMsIGJ1dCBpdCdz IG5vdCBzZXR0aW5nIGl0IHRoYXQgYnJlYWtzDQpwcmV2aW91cyBndWFyYW50ZWVzLiBJdCdzIHJl YWxseSBiaXphcnJlIGRlc2lnbiBjaG9pY2UgZnJvbSBJbnRlbC4uLg0KDQo8L3ByZT4NCjxibG9j a3F1b3RlIHR5cGU9ImNpdGUiPg0KPHByZSBjbGFzcz0ibW96LXF1b3RlLXByZSIgd3JhcD0iIj4g T24gY3VycmVudCBwYXJ0cywgdXNpbmcNClNTQkQgaGFzIHRoZSBzYW1lIGJlaGF2aW91ciwgYnV0 IHRoaXMgaXNuJ3QgZXhwZWN0ZWQgdG8gcmVtYWluIHRydWUgaW4NCnRoZSBmdXR1cmUuDQoNCkZv cmNpbmcgaXQgb24gYmVoaW5kIHRoZSBiYWNrIG9mIGEgVk0gaXMgbXV0dWFsbHkgZXhjbHVzaXZl IHdpdGgNCmVudW1lcmF0aW5nIGl0IGZvciBWTXMgdG8gdXNlIGF0IHNvbWUgcG9pbnQgaW4gdGhl IGZ1dHVyZSB3aGVuIHdlIGhhdmUNCnRoZSBjYXBhYmlsaXR5IHRvLiZuYnNwOyBpLmUuIHNwZWNp ZmljYWxseSwgeW91IGFyZSBub3QgYWJsZSB0byBtYWludGFpbiB0aGUNCkFCSS9BUEkgaW4gdGhp cyBwYXRjaCBpbiB0aGUgZnV0dXJlLg0KPC9wcmU+DQo8L2Jsb2NrcXVvdGU+DQo8cHJlIGNsYXNz PSJtb3otcXVvdGUtcHJlIiB3cmFwPSIiPg0KUmVnYXJkaW5nIHRoZSBjdXJyZW50IGJlaGF2aW9y IG9mIHRoZSBoeXBlcnZpc29yICh3aXRob3V0IHRoaXMgcGF0Y2gpOg0Kd2lsbCBndWVzdCBzZWUg RE9JVE0gcHJlc2VudCBidXQgbm90IHNldD8gT3Igd2lsbCB0aGV5IG5vdCBzZWUgaXQgYXQNCmFs bD8NCg0KRG9jdW1lbnRhdGlvbiBjbGVhcmx5IHN0YXRlOg0KICAgIEZvciBJbnRlbMKuIENvcmXi hKIgZmFtaWx5IHByb2Nlc3NvcnMgYmFzZWQgb24gbWljcm9hcmNoaXRlY3R1cmVzDQogICAgYmVm b3JlIEljZSBMYWtlIGFuZCBJbnRlbCBBdG9twq4gZmFtaWx5IHByb2Nlc3NvcnMgYmFzZWQgb24N CiAgICBtaWNyb2FyY2hpdGVjdHVyZXMgYmVmb3JlIEdyYWNlbW9udCB0aGF0IGRvIG5vdCBlbnVt ZXJhdGUNCiAgICBJQTMyX1VBUkNIX01JU0NfQ1RMLCBkZXZlbG9wZXJzIG1heSBhc3N1bWUgdGhh dCB0aGUgaW5zdHJ1Y3Rpb25zIGxpc3RlZA0KICAgIGhlcmUgb3BlcmF0ZSBhcyBpZiBET0lUTSBp cyBlbmFibGVkLg0KDQpTbywgaWYgZ3Vlc3RzIHdpbGwgbm90IHNlZSB0aGUgZmVhdHVyZSBhdCBh bGwsIGl0IFhlbiBzaG91bGQgc2V0IGl0DQp1bmNvbmRpdGlvbmFsbHksIHRvIHJlbWFpbiBjb21w bGlhbnQgd2l0aCBleHBlY3RlZCBoYXJkd2FyZSBiZWhhdmlvdXIuDQoNCklmIGd1ZXN0cyB3aWxs IHNlZSB0aGUgdGhpbmcgKGFuZCBzZWUgaXQgbm90IGVuYWJsZWQpLCB0aGVuIGluZGVlZCBpdCdz DQpsZXNzIGNsZWFyIHdoYXQgc2hvdWxkIGJlIGRvbmUgcmlnaHQgbm93IChidXQgSSdkIHN0aWxs IGxpa2UgdG8gaGF2ZSBhbg0Kb3B0aW9uIHRvIGVuYWJsZSBpdCkuPC9wcmU+DQo8L2Jsb2NrcXVv dGU+DQo8YnI+DQpIbW0uJm5ic3A7IFNvIHllcywgbGV0cyBhcHByb2FjaCB0aGUgcHJvYmxlbSBm cm9tIHRoZSBvdGhlciBzaWRlLCBhcyAmcXVvdDt0aGlzIGJpdCBuZWVkcyBzZXR0aW5nIHRvIHVu YnJlYWsgY3J5cHRvIGNvZGUmcXVvdDsuPGJyPg0KPGJyPg0KT24gaGFyZHdhcmUgc3VwcG9ydGlu ZyBET0lUTSwgd2hlcmUgd2UgZG8gbm90IGFkdmVydGlzZSB0aGUgZmVhdHVyZSB0byBndWVzdHMg KGFsbCBndWVzdHMgcmlnaHQgbm93KSwgdGhlIGd1ZXN0IGtlcm5lbCB3b3VsZCBjb25jbHVkZSB0 aGF0IGl0IGlzIHNhZmUsIHdoZW4gaW4gZmFjdCBpdCBpcyBub3QuPGJyPg0KPGJyPg0KU28gWGVu IHNob3VsZCBzZXQgdGhlIGJpdCBiZWhpbmQgdGhlIGJhY2sgb2YgYSBndWVzdCB3aGljaCBkb2Vz bid0IGhhdmUgdGhlIERPSVRNIGVudW1lcmF0aW9uIHByZXNlbnRlZCAod2hpY2ggaXMgYWxsIGd1 ZXN0cyByaWdodCBub3cpLjxicj4NCjxicj4NCkJ1dCBJIGRvbid0IHRoaW5rIHdlIHdhbnQgYW55 IEtjb25maWcgYWJvdXQgdGhpcywgb3IgYSBkZWRpY2F0ZWQgY21kbGluZSBvcHRpb24uJm5ic3A7 IFNvIGhvdyBhYm91dCB0aGlzIGZvciBhIHBsYW4gd2hpY2ggYXZvaWRzIHBhaW50aW5nIG91cnNl bHZlcyBpbnRvIGEgY29ybmVyLjxicj4NCjxicj4NCjEpIEV4dGVuZCBjcHVpZD0gd2l0aCBhIG5v LWRvaXRtIG9wdGlvbi4mbmJzcDsgSSBrbm93IGl0J3Mgbm90IGFjdHVhbGx5IGEgQ1BVSUQgZW51 bWVyYXRpb24sIGJ1dCBNU1JfQVJDSF9DQVBTIHNob3VsZCBoYXZlIGJlZW4gQ1BVSUQgZGF0YSwg YW5kIHRoaXMgaXMgdGhlIG1lY2hhbmlzbSB3ZSBoYXZlIG1lYW5pbmcgJnF1b3Q7cHJldGVuZCB0 aGlzIGZlYXR1cmUgaXNuJ3QgZW51bWVyYXRlZCZxdW90Oy48YnI+DQo8YnI+DQoyKSBPbiBib290 LCBhbmQgUzMgcmVzdW1lLCBpZiBET0lUTSBhbmQgYXZhaWxibGUsIHNldCBpbnZhcmlhbnQgbW9k ZS48YnI+DQo8YnI+DQpUaGF0IHNob3VsZCBkbyBhcyBhIHN0b3BnYXAgZm9yIG5vdyB0aGF0IGtl ZXBzIHNvZnR3YXJlIHNhZmUuPGJyPg0KPGJyPg0KPGJyPg0KVGhlbiwgd2hlbiB3ZSd2ZSBnb3Qg TVNSX0FSQ0hfQ0FQUyB3b3JraW5nIGZvciBndWVzdHMsIHRoZSBpbnRlcm5hbHMgb2YgPHNwYW4g Y2xhc3M9ImNvZGUtc2ltcGxlIj4NCk1TUl9VQVJDSF9NSVNDX0NUTCBjaGFuZ2UgdG8gYmVpbmcg YSBjb250ZXh0IHN3aXRjaGVkIHRoaW5nIHdoaWNoLCBsaWtlIE1TUl9TUEVDX0NUUkwsIHdlIGhh dmUgb3B0aW9ucyBmb3IgYml0cyBzZXQgYmVoaW5kIHRoZSBndWVzdCdzIGJhY2suJm5ic3A7IFRo ZW4gd2Ugc2V0IERPSVRNIGJlaGluZCB0aGUgZ3Vlc3RzIGJhY2sgaWYgbGV2ZWxsaW5nIGNhdXNl cyB0aGUgZmVhdHVyZSB0byBiZSBoaWRkZW4uJm5ic3A7IFdlIGRvIHRoaXMgZm9yIHNvbWUgYml0 cyBhbHJlYWR5LA0KIGFuZCBuZWVkIHRvIGRvIHNvIGZvciBtb3JlIGNvbnRyb2xzIHRvby48YnI+ DQo8YnI+DQp+QW5kcmV3PGJyPg0KPC9zcGFuPg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_04f7de014e8eb964d676d756265c2776citrixcom_-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 17:33:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 17:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414356.658590 (Exim 4.92) (envelope-from ) id 1oeJsV-000490-5B; Fri, 30 Sep 2022 17:32:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414356.658590; Fri, 30 Sep 2022 17:32:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJsV-00048t-2W; Fri, 30 Sep 2022 17:32:47 +0000 Received: by outflank-mailman (input) for mailman id 414356; Fri, 30 Sep 2022 17:32:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJsT-00048g-KJ; Fri, 30 Sep 2022 17:32:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJsT-0006KM-I9; Fri, 30 Sep 2022 17:32:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeJsT-0002Fl-2t; Fri, 30 Sep 2022 17:32:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeJsT-00021J-00; Fri, 30 Sep 2022 17:32:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y5LMvpTokqT/Asb/EJVFnBFmdCQDsNN+Y8iAF81Mr9o=; b=S1egQl1fHHVwUJRoFfUjwajYbx RLT20UFGnOTxgq/zCKAhjtbABbh02izcCuSMiER7yjZ7KF8k96sbCNE7AQ2m2+SKBBWhJx4fZn7P0 OkSXeusgJmZ4EWHuxH5e03JsHj9zCZcxqypav1UqB64ijiPxopQnWrOE+nGg3rlXUn+E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 173387: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1666086b00442b23e4fd70f4971e3bcf1a16b124 X-Osstest-Versions-That: xen=38e1276db4c5457cd6e7811b4e168aa85c8a0b06 From: osstest service owner Date: Fri, 30 Sep 2022 17:32:45 +0000 flight 173387 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173387/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 1666086b00442b23e4fd70f4971e3bcf1a16b124 baseline version: xen 38e1276db4c5457cd6e7811b4e168aa85c8a0b06 Last test of basis 173384 2022-09-30 08:00:25 Z 0 days Testing same since 173387 2022-09-30 14:01:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 38e1276db4..1666086b00 1666086b00442b23e4fd70f4971e3bcf1a16b124 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Sep 30 18:17:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 18:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414366.658601 (Exim 4.92) (envelope-from ) id 1oeKZe-00010B-Kw; Fri, 30 Sep 2022 18:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414366.658601; Fri, 30 Sep 2022 18:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKZe-000104-Hf; Fri, 30 Sep 2022 18:17:22 +0000 Received: by outflank-mailman (input) for mailman id 414366; Fri, 30 Sep 2022 18:17:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKZc-0000zy-Lr for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 18:17:21 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1cba6010-40ec-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 20:17:18 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A4AC63200A07; Fri, 30 Sep 2022 14:17:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 30 Sep 2022 14:17:14 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 14:17:11 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cba6010-40ec-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664561833; x= 1664648233; bh=VpYTTsodVQHL/iFliX+gGBf/BbYg00nAJ9Xv1F4ugA4=; b=3 e65tjs+7F3/HNpFfNnYu6g+RWANNRgNCFWuScT5j+7LlSBh703nntOn1JzO2djaR 8+icN8UwVz6eqwrVVpovvILbczGwVr3erAvm1GHYJrIUy9Olkm1eIPPuqzozWN+V emZTZOZ6ODtVeh9XxNW58qTNe+Q66UiniFj6jBAB19eOBGj+bBTTo2rwe9DArIjG 8r0jPFUNBjVzxTXT0fxpcF5QY+n5UB1g+3n4K9uZfgcqpVSob/VSts2fxA1f5+OJ 94EM0WzShtRhaxWcTH3Wp8hQFm8BtIQ5M12l+2x0kpg1KUvRWh5S51w66w1j66Oh hlnf2zYsAkZch4J6Q0U7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664561833; x=1664648233; bh=VpYTTsodVQHL/iFliX+gGBf/BbYg 00nAJ9Xv1F4ugA4=; b=RpbMDvD2QHg/KXDWKztkGAqmq/6hrla6dvE1nI3LDWwS hlTbl89LFNJ58QjKgDw267Yvdv3UzqEvN65RSeZY0JHEmRVvT4bVFcazvmBmnzgN gy0xcmNfkWCbXkQz0I7wh3DNwlO3tXxdJhn+p+E2FQKf7bmALQU2+CewScG/OAjo kmJlLpY1pjbULuiQZdk4DI7jNScC8MMzKli9nnddYwdgj4slIZbCk7RJJmJ4VGk9 j6UCaBOrzaaJvLSG7ZtSyTfTsly1HeZBSWUlwb/I6HJVSKqNIkaDy7SIklgsF3uf zlfqn3czhoZ/8CAthumZnqoQt8p0vh4oPqbjaPgDyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeuueevleehvedvuedvhfeihfel ffdtheeuvdefgfevgeefgfeihfduheevhedtfeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 14:15:37 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5yHUO7Al/LX7+UiX" Content-Disposition: inline In-Reply-To: --5yHUO7Al/LX7+UiX Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 14:15:37 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered On Fri, Sep 30, 2022 at 06:25:53PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > wrote: > > > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DAT= A, > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > must not use EFI tables from such memory. Most of the remaining EFI > > memory types are not suitable for EFI tables, leaving only > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > > use tables that are located in one of these types of memory. > > > > This patch ensures this, and also adds a function > > (xen_config_table_memory_region_max()) that will be used later to > > replace the usage of the EFI memory map in esrt.c when running under > > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > > but I have not implemented this. > > > > Signed-off-by: Demi Marie Obenour > > --- > > drivers/firmware/efi/efi.c | 8 +++++--- > > drivers/xen/efi.c | 35 +++++++++++++++++++++++++++++++++++ > > include/linux/efi.h | 9 +++++++++ > > 3 files changed, 49 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > index e4080ad96089abd7f84745dd8461c548bcbb7685..d344f3ff73d1c5ed0c67e32= 51a9502e66719741d 100644 > > --- a/drivers/firmware/efi/efi.c > > +++ b/drivers/firmware/efi/efi.c > > @@ -574,7 +574,6 @@ int __init efi_config_parse_tables(const efi_config= _table_t *config_tables, > > unsigned long table; > > int i; > > > > - pr_info(""); >=20 > Why are you removing these prints? If I left them, I would need to include a pr_cont("\n") later. Checkpatch recommends against that. What is the purpose of this print? I assumed that since it prints an empty string it is superfluous. > > for (i =3D 0; i < count; i++) { > > if (!IS_ENABLED(CONFIG_X86)) { > > guid =3D &config_tables[i].guid; > > @@ -585,7 +584,6 @@ int __init efi_config_parse_tables(const efi_config= _table_t *config_tables, > > > > if (IS_ENABLED(CONFIG_X86_32) && > > tbl64[i].table > U32_MAX) { > > - pr_cont("\n"); > > pr_err("Table located above 4GB, disabl= ing EFI.\n"); > > return -EINVAL; > > } > > @@ -594,10 +592,14 @@ int __init efi_config_parse_tables(const efi_conf= ig_table_t *config_tables, > > table =3D tbl32[i].table; > > } > > > > +#ifdef CONFIG_XEN_EFI >=20 > We tend to prefer IS_ENABLED() for cases such as this one. That way, > the compiler always gets to see the code inside the conditional block, > which gives better build test coverage (even if CONFIG_XEN_EFI is > disabled). Can I count on the compiler eliminating the code as unreachable? With CONFIG_XEN_EFI disabled xen_config_table_memory_region_max() would be an undefined symbol. > > + if (efi_enabled(EFI_PARAVIRT) && !xen_config_table_memo= ry_region_max(table)) >=20 > So the question here is whether Xen thinks the table should be > disregarded or not. So let's define a prototype that reflects that > purpose, and let the implementation reason about how this should be > achieved. xen_config_table_memory_region_max() doesn=E2=80=99t just return whether the table should be disregarded, but also (if the table should not be ignored) the end of the memory region containing it. I will make xen_efi_config_table_valid() a wrapper around xen_config_table_memory_region_max(), as the former also needs to print a warning if the table is in an invalid location. > So >=20 > if (IS_ENABLED(CONFIG_XEN_EFI) && > efi_enabled(EFI_PARAVIRT) && > xen_efi_config_table_valid(guid, table) > continue >=20 > I should note here, though, that EFI_PARAViRT is only set on x86 not > on other architectures that enable CONFIG_XEN_EFI so this will not > work anywhere else. What should I use instead? > > + continue; > > +#endif > > + > > if (!match_config_table(guid, table, common_tables) && = arch_tables) > > match_config_table(guid, table, arch_tables); > > } > > - pr_cont("\n"); > > set_bit(EFI_CONFIG_TABLES, &efi.flags); > > > > if (efi_rng_seed !=3D EFI_INVALID_TABLE_ADDR) { > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c > > index d1ff2186ebb48a7c0981ecb6d4afcbbb25ffcea0..c2274ddfcc63304008ef0fd= 78fd9fa416f75d073 100644 > > --- a/drivers/xen/efi.c > > +++ b/drivers/xen/efi.c > > @@ -28,6 +28,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > > > @@ -271,6 +272,40 @@ static void xen_efi_reset_system(int reset_type, e= fi_status_t status, > > } > > } > > > > +__init u64 xen_config_table_memory_region_max(u64 addr) >=20 > It is more idiomatic for Linux to put __init after the return type. > And if we adopt my suggestion above, this becomes >=20 > bool __init xen_efi_config_table_valid(const efi_guid_t *guid, u64 table) >=20 > Alternatively, you could pass the string identifier of the table > instead of the guid (or both) to print in the diagnostic message. Will fix in v5. > > +{ > > + static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT, > > + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHI= FT"); >=20 > Is this the only place where this matters? And this never happens on x86,= right? My understanding is that it should never happen on any architecture. That=E2=80=99s why I static_assert() it. I have no idea if this is the only place it matters, though. > > + struct xen_platform_op op =3D { > > + .cmd =3D XENPF_firmware_info, > > + .u.firmware_info =3D { > > + .type =3D XEN_FW_EFI_INFO, > > + .index =3D XEN_FW_EFI_MEM_INFO, > > + .u.efi_info.mem.addr =3D addr, > > + .u.efi_info.mem.size =3D U64_MAX - addr, > > + } > > + }; > > + union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_info; > > + int rc =3D HYPERVISOR_platform_op(&op); > > + > > + if (rc) { > > + pr_warn("Failed to lookup header %llu in Xen memory map= : error %d\n", > > + (unsigned long long)addr, rc); > > + return 0; > > + } > > + > > + switch (info->mem.type) { > > + case EFI_RUNTIME_SERVICES_CODE: > > + case EFI_RUNTIME_SERVICES_DATA: > > + case EFI_ACPI_RECLAIM_MEMORY: >=20 > If we are listing all memory types that Xen preserves, you might add > EFI_RESERVED_MEMORY here. Otherwise, please only list the ones that > you need to permit explicitly. My understanding was that EFI_RESERVED_MEMORY should never be touched by the OS, so I left it out. Which types would you permit? > > + return info->mem.addr + info->mem.size; > > + default: > > + pr_warn("Table %llu is in memory of type %d, ignoring i= t\n", > > + (unsigned long long)addr, info->mem.type); > > + return 0; > > + } > > +} > > + > > /* > > * Set XEN EFI runtime services function pointers. Other fields of str= uct efi, > > * e.g. efi.systab, will be set like normal EFI. > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index d2b84c2fec39f0268324d1a38a73ed67786973c9..fc81e4b984398cdb399e788= 6b2cae7f33bf91613 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -1324,4 +1324,13 @@ struct linux_efi_coco_secret_area { > > /* Header of a populated EFI secret area */ > > #define EFI_SECRET_TABLE_HEADER_GUID EFI_GUID(0x1e74f542, 0x71dd, 0x= 4d66, 0x96, 0x3e, 0xef, 0x42, 0x87, 0xff, 0x17, 0x3b) > > > > +#ifdef CONFIG_XEN_EFI >=20 > Please drop this #ifdef Will fix in v5. > > +/* > > + * Returns the end of the memory region containing the given config ta= ble, > > + * or 0 if the given address does not reside in memory that can validly > > + * contain EFI configuration tables. > > + */ > > +__init u64 xen_config_table_memory_region_max(u64 addr); >=20 > You can drop the __init here Will fix in v5. > > +#endif > > + > > #endif /* _LINUX_EFI_H */ > > -- > > Sincerely, > > Demi Marie Obenour (she/her/hers) > > Invisible Things Lab > > --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --5yHUO7Al/LX7+UiX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3MqYACgkQsoi1X/+c IsGqLg/+LrbdkNwJvPos2mErIP/759qjWMrHuwkpugajU5HC3On9q3mpBvKkO49o 5hPrK7Bs4AoP/g2CPc+w4XFtEqAPhRUu6eADfXff83bIbKmlqlzbBn/EUmSG6uz+ 7UGw+WmiizX1ycoimA4BuK2OjfnxS/RVUwXIO8aaeVEoSK8vA2iJMZLNTVlLffAf XjcaHqfX5TeuqGR4hAmtcBUwzSqHly932UE/RoACBiuRJ0bLl9VuW8iaafzHqkPJ CWJsEInho4cR+DXrEZMKOfPpnFzsKHQ8EzdQYkaF2p6Jp5acZmA2Szy3yQgJF+6B imsLzNK8xcqrrdP7HcFBZHSEt5x7h5HMz3KQ0jzLos47e+uIyMhN70AdXBdGf4Ae kNYJ7P/3795g3/wLh74FvJLj6+CS1nXC8bYgHvSmyu596/bebYRhUveZn2p/9OxT 1DZBNLvdX38gI/GmqZ5qeevVuXy+rrVff9gti9K9ruKF9J5R33ROxI6yUhfcPNhU 7QF2QbrPh59DprG/sIAUptS1pXpoXl9KTsWaUC/9oC81gGVTbZDVM5ud3W5C0GR8 8VWWHTToKr8H6NqDredfQKvmDrs6LTosiv7RYfwf5x/uBJYp2tWO//eVCzAvd1+X x5FA+raBCIhvvn0OB2386X7El4qS0AnINvGfXpHGPWBQK8CSFR0= =C5Ld -----END PGP SIGNATURE----- --5yHUO7Al/LX7+UiX-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 18:21:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 18:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414373.658612 (Exim 4.92) (envelope-from ) id 1oeKdl-0002Pf-4r; Fri, 30 Sep 2022 18:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414373.658612; Fri, 30 Sep 2022 18:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKdl-0002PY-1v; Fri, 30 Sep 2022 18:21:37 +0000 Received: by outflank-mailman (input) for mailman id 414373; Fri, 30 Sep 2022 18:21:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKdj-0002PS-Q1 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 18:21:35 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b391cf1e-40ec-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 20:21:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2D4083200A18; Fri, 30 Sep 2022 14:21:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 30 Sep 2022 14:21:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 14:21:25 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b391cf1e-40ec-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664562086; x= 1664648486; bh=e9mWRDSbNU3lBOaLJleKvf4YDJLq5iVN7Gaa45dLAu0=; b=s nn98HHSNuhi3ixoc4JBKtRoSarpSwIzv8QIzY/HjTivpnB/cRuiJasWAdzvVscHH Bd9Ub77cyHSSJv6idIOLFQy29F7Bi9nZtsNdRlvxalXLCeMHrlLWgyxDVsqJ12QB myHVwnJVouWzicw2arC2kVRHxvKimqRA19NOlJ6oK3E2w197E0dBgKB7ZYHB9sU+ cEc1FdGRenklW5uWtWpSCnTJ4kD1Ytx/mMsB0ZvwBQ+iyFQSGxB9HvIyvCHx7gbh kPf5QtAGK3vuxHDPpFr3ixV1f2gy8kjf3wrMUZPa1ybRk+JQ8NcBbY2U/yD+vEBm 2WfJi2sr9XxgVv8PsDwJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664562086; x=1664648486; bh=e9mWRDSbNU3lBOaLJleKvf4YDJLq 5iVN7Gaa45dLAu0=; b=kf/2V7MPo2jv5ypQKwCOo6lhzcB3nNQa7uLF0RCb9APA KnsPi7pJWsBkDd+az9ituznaWkb7XeJbxCTnh2jsQCe1zwynwd+Jjdrwg3ZMOfbl lAzZvNRz8i7qsAgRZVTLHboT+S9OgaCWRuo2+C4kDbc38ueMeaWv68gZy3I+6xFd SNBHdo2PUWkR/Jp+DVt6qi3ItjQ422ijUn73n8DhD5kv50mZENuC5NHOlwfSXBeO kUG4htEut87siYWHrKgkqLaYxACOEY1ZWA2gsEjUvBFwbdTGaWRJ203EAPb8bbv0 NE5D4cWWfztws0DayP8I3DkYA5QpUuq/479k5kcu6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffej geejgeffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 14:21:22 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 Message-ID: References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rkGwejpOEGtuhYbs" Content-Disposition: inline In-Reply-To: --rkGwejpOEGtuhYbs Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 14:21:22 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > wrote: > > > > fwupd requires access to the EFI System Resource Table (ESRT) to > > discover which firmware can be updated by the OS. Currently, Linux does > > not expose the ESRT when running as a Xen dom0. Therefore, it is not > > possible to use fwupd in a Xen dom0, which is a serious problem for e.g. > > Qubes OS. > > > > Before Xen 4.17, this was not fixable due to hypervisor limitations. > > The UEFI specification requires the ESRT to be in EfiBootServicesData > > memory, which Xen will use for whatever purposes it likes. Therefore, > > Linux cannot safely access the ESRT, as Xen may have overwritten it. > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData > > memory, Xen replaces the ESRT with a copy in memory that it has > > reserved. Such memory is currently of type EFI_RUNTIME_SERVICES_DATA, > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. This > > ensures that the ESRT can safely be accessed by the OS. > > > > When running as a Xen dom0, use the new > > xen_config_table_memory_region_max() function to determine if Xen has > > reserved the ESRT and, if so, find the end of the memory region > > containing it. This allows programs such as fwupd which require the > > ESRT to run under Xen, and so makes fwupd support in Qubes OS possible. > > > > Signed-off-by: Demi Marie Obenour >=20 > Why do we need this patch? I'd expect esrt_table_exists() to return > false when patch 1/2 is applied. efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be an alternative way to get the end of the memory region containing the ESRT. That is what this patch provides. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --rkGwejpOEGtuhYbs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3M6QACgkQsoi1X/+c IsFLUA//apV6j+1dncTlLgNl3AH30fnqZeCd+rz5EobZ3RLvMQ/Py7QYzqIZ8jkW bhrWcNj1EH+0WcGME1oKob9/OEjEg/sb9WKXvQqvf5Wm9wlM2bzWrQrBSYyN3epM /qeVHH4JWvze6WDUvcESiDUkUHS2iqkUflTAcU4ViAwo4fYIQWoBgKphI60ZAshv IVZiL3tRQAO3/a/iyrl6JMWuPBE0EvM8AJznohdzgelrg9OgZxy2Mk7iQS5fiB9W vBTWOBeQGlakoecfOZcKQmu7d0Rmoe5SJW968A61u6Aou/FQWYDzWyRyvlu12fVV r72gpf2QZzaZuP4xyf9I+ezZ+yvs67eL7dARnmdbgABqyYi/Mp5cIxcN2O6us/I6 LD/e3vQJ5GdI3cHSOo1pjPh3obs9MpJbOfQ/eqXKajjWiamBZ8sHlqj14BGyTMvT Is8+7ppdvQV6wcEs09akZDbDxB0e+bhZdFE69MoLzCrnW9qam9rYdGzsfkWNSdYy OAFpjW+YSyo0zNPbKJALRouTPyshN/faRWV3pFEtNZQv+tWzmNunly7Q23bA+XIB 8UHv3qUvbaYXXeNRkhUt0W3gXF1gcWmx7I9sH+cfU4MpdFY8fXZc80KsJuxJPG5S YcDiShwAhGN7nF33xN3HAOmx0qFQcqKhqVq+dXFctiXKYKsIXt4= =SfaK -----END PGP SIGNATURE----- --rkGwejpOEGtuhYbs-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 18:27:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 18:27:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414380.658624 (Exim 4.92) (envelope-from ) id 1oeKjQ-0003CO-QP; Fri, 30 Sep 2022 18:27:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414380.658624; Fri, 30 Sep 2022 18:27:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKjQ-0003CH-Lf; Fri, 30 Sep 2022 18:27:28 +0000 Received: by outflank-mailman (input) for mailman id 414380; Fri, 30 Sep 2022 18:27:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKjO-0003CB-Rn for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 18:27:26 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8836e81a-40ed-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 20:27:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E33CFB82991 for ; Fri, 30 Sep 2022 18:27:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13EF7C43140 for ; Fri, 30 Sep 2022 18:27:23 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id bu25so8117637lfb.3 for ; Fri, 30 Sep 2022 11:27:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8836e81a-40ed-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664562443; bh=Tx1IcPFyiS0Zrex2PgsIGkAL7OtkU2ITCcqG7KbiFro=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NWucGDDPih9u95p/yPzaHce/aZIKQL5Kc2Y0NxMqlv6R0CJgAVyAPrFaVMcpbiHqz 9N4akp4bUp0IlBoXmMVvCUjs21l2+T8V/osOVgZK0xWes/D2P8ulcmxEzFSQ4Oghmg 0KRrGrXskganSE3ZcqMCFjuW36Svi0mYkYOLKiETzqbXWllH7RnYzVAXZ6gXp4U7HH shQoMl30l0bmimcGlVB7iEsqkTtAInCzqyOzTSKbW3ne4BuwA2KhGI0IfmJ4452/hx dbStiUYPSrFD0N6KuEeP6jzzXMdY/S44PSPoopOn2w07t0qKx3TRNoI2CzDCMVpl1a alZERQnM5KOqQ== X-Gm-Message-State: ACrzQf2kuwFpNwSi3WI2jgi+L4Q+PiFHVlpP5nVNHIYjSqs5NHedh5Jj BfrFQt6XjoyesB5i1pK+dIAe70K2Sq3yRlbamrc= X-Google-Smtp-Source: AMsMyM7h3P9nOYUCPle0jRTt0XlCF6hd235OqFbcs7iHdktBvXYS0LEMSwqmhcZaPeZNIcnz0sB/fObE53n24tKpFtw= X-Received: by 2002:a05:6512:150e:b0:492:d9fd:9bdf with SMTP id bq14-20020a056512150e00b00492d9fd9bdfmr3559636lfb.583.1664562440957; Fri, 30 Sep 2022 11:27:20 -0700 (PDT) MIME-Version: 1.0 References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 30 Sep 2022 20:27:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered To: Demi Marie Obenour Cc: Jan Beulich , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" On Fri, 30 Sept 2022 at 19:12, Demi Marie Obenour wrote: > > On Fri, Sep 30, 2022 at 06:30:57PM +0200, Ard Biesheuvel wrote: > > On Fri, 30 Sept 2022 at 08:44, Jan Beulich wrote: > > > > > > On 30.09.2022 01:02, Demi Marie Obenour wrote: > > > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_DATA, > > > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered by > > > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > > > must not use EFI tables from such memory. Most of the remaining EFI > > > > memory types are not suitable for EFI tables, leaving only > > > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > > > > use tables that are located in one of these types of memory. > > > > > > > > This patch ensures this, and also adds a function > > > > (xen_config_table_memory_region_max()) that will be used later to > > > > replace the usage of the EFI memory map in esrt.c when running under > > > > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c, > > > > but I have not implemented this. > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > In Xen we don't clobber EfiBootServices{Code,Data} when xen.efi was passed > > > "-mapbs". Should we perhaps extend the interface such that Dom0 can then > > > also use tables located in such regions, perhaps by faking > > > EFI_MEMORY_RUNTIME in the attributes returned by XEN_FW_EFI_MEM_INFO? > > > > > > > I know this ship has sailed for x86, but for the sake of other > > architectures, I'd strongly recommend leaving the EFI_MEMORY_RUNTIME > > bits alone, for the same reasons I gave earlier. (Runtime mappings for > > the firmware code itself, page table fragmentation etc etc) > > Why do you say that it has sailed for x86? > The x86 EFI code in Linux makes changes to the EFI memory map in many different places in the code. On other architectures, we have managed to avoid this, so that the EFI memory map is always identical to the one provided by the firmware at boot. > > I know very little about Xen, but based on the context you provided in > > this thread, I'd say that the best approach from the Xen side is to > > convert all EfiBootServicesData regions that have configuration tables > > pointing into them into EfiAcpiReclaimMemory. > > Should Xen convert the entire region, or should it try to reserve only > the memory it needs? The latter would require it to parse the > configuration tables. Is there a list of configuration tables that can > legitimately be in EfiBootServicesData regions? > Not really, no. So you would have to convert the entire region /unless/ Xen knows the GUID, and therefore knows how to derive the size of the table, allowing it to reserve memory more conservatively. However, I doubt whether this is worth it: splitting entries implies rewriting the memory map, which is a thing I'd rather avoid if I were in your shoes. > > I take it XEN_FW_EFI_MEM_INFO is an existing interface? If so, you > > might do the same for the returned type - EfiBootServicesData -> > > EfiAcpiReclaimMemory, and not muck about with the EFI_MEMORY_RUNTIME > > attribute. > > It is indeed an existing interface, and this is a much better idea than > what you proposed. Right. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 18:43:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 18:43:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414387.658633 (Exim 4.92) (envelope-from ) id 1oeKyT-0005lc-6d; Fri, 30 Sep 2022 18:43:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414387.658633; Fri, 30 Sep 2022 18:43:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKyT-0005lV-3p; Fri, 30 Sep 2022 18:43:01 +0000 Received: by outflank-mailman (input) for mailman id 414387; Fri, 30 Sep 2022 18:43:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeKyS-0005lP-BE for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 18:43:00 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b36f995f-40ef-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 20:42:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11F3DB8298E for ; Fri, 30 Sep 2022 18:42:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B788CC4347C for ; Fri, 30 Sep 2022 18:42:54 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id c2so1800677lfb.10 for ; Fri, 30 Sep 2022 11:42:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b36f995f-40ef-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664563374; bh=n9d8fxGykif2j8j4F1jsMpGoXvGjd8rFgZONy58Z89w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oImJ3SVrV4qtHCa7McyX2vxcpImY8bcQz2VRQ3WJXyxbZb1c9yHyz6jge1CrH9umm l4UObWWzJk/u7yEhGUXV5UFQgGYPPkPbYREs1FGrMd++LZthzRYb/TBaGLBj8+hr2X lYYz+94fOyADOZakHkUJvBv17Nc6VvGmiz/34nFpsl2AaGyXd8Xzd0fgOgtDYvzr5h iH5gAsZwSlqXj8FP2+bd/1/3Cr7sDiigCJGTMN0wiovWKL7VEDXvXl8Ex3Poooa1NM pwGbSgPCKoUQu3xrV2vr8bGm6+SOO/FikzVh3Gg7MHyQAEfE/ZYqwV+8+FQzP+hyBD rNt6IO6rvCTzw== X-Gm-Message-State: ACrzQf13yKNRAIETSp+XMld5O0VXljZRw9NKWRdXvgUDqF8rIoThRy6X /5XCnDUYOK07YXOYe0uwR9iy1yuYYciiUQGnDTc= X-Google-Smtp-Source: AMsMyM7CHH3GPZ0kxZJ2HbQZGpOplacL0pdSDamKzttlOPDQ9yS7xWVJ1bbSbuTtQSkczRLlrgOWyPTw1L13q1cMFqI= X-Received: by 2002:a05:6512:3da0:b0:4a1:e17a:2305 with SMTP id k32-20020a0565123da000b004a1e17a2305mr3720927lfv.228.1664563372632; Fri, 30 Sep 2022 11:42:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Fri, 30 Sep 2022 20:42:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered To: Demi Marie Obenour Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 30 Sept 2022 at 20:17, Demi Marie Obenour wrote: > > On Fri, Sep 30, 2022 at 06:25:53PM +0200, Ard Biesheuvel wrote: > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > wrote: > > > > > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER_D= ATA, > > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered b= y > > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > > must not use EFI tables from such memory. Most of the remaining EFI > > > memory types are not suitable for EFI tables, leaving only > > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should only > > > use tables that are located in one of these types of memory. > > > > > > This patch ensures this, and also adds a function > > > (xen_config_table_memory_region_max()) that will be used later to > > > replace the usage of the EFI memory map in esrt.c when running under > > > Xen. This function can also be used in mokvar-table.c and efi-bgrt.c= , > > > but I have not implemented this. > > > > > > Signed-off-by: Demi Marie Obenour > > > --- > > > drivers/firmware/efi/efi.c | 8 +++++--- > > > drivers/xen/efi.c | 35 +++++++++++++++++++++++++++++++++++ > > > include/linux/efi.h | 9 +++++++++ > > > 3 files changed, 49 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > > index e4080ad96089abd7f84745dd8461c548bcbb7685..d344f3ff73d1c5ed0c67e= 3251a9502e66719741d 100644 > > > --- a/drivers/firmware/efi/efi.c > > > +++ b/drivers/firmware/efi/efi.c > > > @@ -574,7 +574,6 @@ int __init efi_config_parse_tables(const efi_conf= ig_table_t *config_tables, > > > unsigned long table; > > > int i; > > > > > > - pr_info(""); > > > > Why are you removing these prints? > > If I left them, I would need to include a pr_cont("\n") later. There should always be one at the end of the loop, no? Or is this related to the diagnostic that gets printed in your helper? > Checkpatch recommends against that. What is the purpose of this print? > I assumed that since it prints an empty string it is superfluous. > It prints the leading [invisible] loglevel marker, and the 'efi: ' prefix. > > > for (i =3D 0; i < count; i++) { > > > if (!IS_ENABLED(CONFIG_X86)) { > > > guid =3D &config_tables[i].guid; > > > @@ -585,7 +584,6 @@ int __init efi_config_parse_tables(const efi_conf= ig_table_t *config_tables, > > > > > > if (IS_ENABLED(CONFIG_X86_32) && > > > tbl64[i].table > U32_MAX) { > > > - pr_cont("\n"); > > > pr_err("Table located above 4GB, disa= bling EFI.\n"); > > > return -EINVAL; > > > } > > > @@ -594,10 +592,14 @@ int __init efi_config_parse_tables(const efi_co= nfig_table_t *config_tables, > > > table =3D tbl32[i].table; > > > } > > > > > > +#ifdef CONFIG_XEN_EFI > > > > We tend to prefer IS_ENABLED() for cases such as this one. That way, > > the compiler always gets to see the code inside the conditional block, > > which gives better build test coverage (even if CONFIG_XEN_EFI is > > disabled). > > Can I count on the compiler eliminating the code as unreachable? With > CONFIG_XEN_EFI disabled xen_config_table_memory_region_max() would be an > undefined symbol. > If you drop the #ifdef in the .h file (as I suggested below) the code will compile fine, and the symbol reference will not be emitted into the object, so it will link fine even if the Xen objects are not being built. We rely on this behavior all over the Linux kernel. > > > + if (efi_enabled(EFI_PARAVIRT) && !xen_config_table_me= mory_region_max(table)) > > > > So the question here is whether Xen thinks the table should be > > disregarded or not. So let's define a prototype that reflects that > > purpose, and let the implementation reason about how this should be > > achieved. > > xen_config_table_memory_region_max() doesn=E2=80=99t just return whether = the > table should be disregarded, but also (if the table should not be > ignored) the end of the memory region containing it. But the calling code never uses that value, right? > I will make > xen_efi_config_table_valid() a wrapper around > xen_config_table_memory_region_max(), as the former also needs to print > a warning if the table is in an invalid location. > > > So > > > > if (IS_ENABLED(CONFIG_XEN_EFI) && > > efi_enabled(EFI_PARAVIRT) && > > xen_efi_config_table_valid(guid, table) > > continue > > > > I should note here, though, that EFI_PARAViRT is only set on x86 not > > on other architectures that enable CONFIG_XEN_EFI so this will not > > work anywhere else. > > What should I use instead? > > > > + continue; > > > +#endif > > > + > > > if (!match_config_table(guid, table, common_tables) &= & arch_tables) > > > match_config_table(guid, table, arch_tables); > > > } > > > - pr_cont("\n"); > > > set_bit(EFI_CONFIG_TABLES, &efi.flags); > > > > > > if (efi_rng_seed !=3D EFI_INVALID_TABLE_ADDR) { > > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c > > > index d1ff2186ebb48a7c0981ecb6d4afcbbb25ffcea0..c2274ddfcc63304008ef0= fd78fd9fa416f75d073 100644 > > > --- a/drivers/xen/efi.c > > > +++ b/drivers/xen/efi.c > > > @@ -28,6 +28,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include > > > > > > @@ -271,6 +272,40 @@ static void xen_efi_reset_system(int reset_type,= efi_status_t status, > > > } > > > } > > > > > > +__init u64 xen_config_table_memory_region_max(u64 addr) > > > > It is more idiomatic for Linux to put __init after the return type. > > And if we adopt my suggestion above, this becomes > > > > bool __init xen_efi_config_table_valid(const efi_guid_t *guid, u64 tabl= e) > > > > Alternatively, you could pass the string identifier of the table > > instead of the guid (or both) to print in the diagnostic message. > > Will fix in v5. > > > > +{ > > > + static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT, > > > + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_S= HIFT"); > > > > Is this the only place where this matters? And this never happens on x8= 6, right? > > My understanding is that it should never happen on any architecture. EFI_PAGE_SHIFT is always 12, on any architecture and regardless of the page size used by the OS itself. AFAICT, the same applies to XEN_PAGE_SHIFT. > That=E2=80=99s why I static_assert() it. I have no idea if this is the o= nly > place it matters, though. > I don't mind adding this here, but it's kind of orthogonal to the rest of the patch so please make a mention in the commit log why you are adding it. > > > + struct xen_platform_op op =3D { > > > + .cmd =3D XENPF_firmware_info, > > > + .u.firmware_info =3D { > > > + .type =3D XEN_FW_EFI_INFO, > > > + .index =3D XEN_FW_EFI_MEM_INFO, > > > + .u.efi_info.mem.addr =3D addr, > > > + .u.efi_info.mem.size =3D U64_MAX - addr, > > > + } > > > + }; > > > + union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_info= ; > > > + int rc =3D HYPERVISOR_platform_op(&op); > > > + > > > + if (rc) { > > > + pr_warn("Failed to lookup header %llu in Xen memory m= ap: error %d\n", > > > + (unsigned long long)addr, rc); > > > + return 0; > > > + } > > > + > > > + switch (info->mem.type) { > > > + case EFI_RUNTIME_SERVICES_CODE: > > > + case EFI_RUNTIME_SERVICES_DATA: > > > + case EFI_ACPI_RECLAIM_MEMORY: > > > > If we are listing all memory types that Xen preserves, you might add > > EFI_RESERVED_MEMORY here. Otherwise, please only list the ones that > > you need to permit explicitly. > > My understanding was that EFI_RESERVED_MEMORY should never be touched by > the OS, so I left it out. Which types would you permit? > Well, given the purpose of the function (i.e, to reject EfiBootServicesData in spite of the spec), I'd only permit EFI_ACPI_RECLAIM_MEMORY and EFI_RUNTIME_SERVICES_DATA. However, the EFI spec does mention that prior versions permitted the reserved memory type as well for ACPI and SMBIOS tables (although that may be a very long time ago). Bottom line is that you want to permit only regions that Xen is guaranteed not to clobber, right? In any case, I'm not going to obsess over this so if you prefer to keep it this way, that's also fine. > > > + return info->mem.addr + info->mem.size; > > > + default: > > > + pr_warn("Table %llu is in memory of type %d, ignoring= it\n", > > > + (unsigned long long)addr, info->mem.type); > > > + return 0; > > > + } > > > +} > > > + > > > /* > > > * Set XEN EFI runtime services function pointers. Other fields of s= truct efi, > > > * e.g. efi.systab, will be set like normal EFI. > > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > > index d2b84c2fec39f0268324d1a38a73ed67786973c9..fc81e4b984398cdb399e7= 886b2cae7f33bf91613 100644 > > > --- a/include/linux/efi.h > > > +++ b/include/linux/efi.h > > > @@ -1324,4 +1324,13 @@ struct linux_efi_coco_secret_area { > > > /* Header of a populated EFI secret area */ > > > #define EFI_SECRET_TABLE_HEADER_GUID EFI_GUID(0x1e74f542, 0x71dd, = 0x4d66, 0x96, 0x3e, 0xef, 0x42, 0x87, 0xff, 0x17, 0x3b) > > > > > > +#ifdef CONFIG_XEN_EFI > > > > Please drop this #ifdef > > Will fix in v5. > > > > +/* > > > + * Returns the end of the memory region containing the given config = table, > > > + * or 0 if the given address does not reside in memory that can vali= dly > > > + * contain EFI configuration tables. > > > + */ > > > +__init u64 xen_config_table_memory_region_max(u64 addr); > > > > You can drop the __init here > > Will fix in v5. > > > > +#endif > > > + > > > #endif /* _LINUX_EFI_H */ > > > -- > > > Sincerely, > > > Demi Marie Obenour (she/her/hers) > > > Invisible Things Lab > > > > > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Sep 30 18:51:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 18:51:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414392.658645 (Exim 4.92) (envelope-from ) id 1oeL6p-0007Mq-3q; Fri, 30 Sep 2022 18:51:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414392.658645; Fri, 30 Sep 2022 18:51:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeL6o-0007Mj-Vi; Fri, 30 Sep 2022 18:51:38 +0000 Received: by outflank-mailman (input) for mailman id 414392; Fri, 30 Sep 2022 18:51:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeL6n-0007MK-Mt for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 18:51:37 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e828aa26-40f0-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 20:51:36 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 016DA32009EF; Fri, 30 Sep 2022 14:51:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 30 Sep 2022 14:51:34 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 14:51:31 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e828aa26-40f0-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664563892; x= 1664650292; bh=fYpDprIN3a0QBYjQ4tUxQgz2zg/uZs+W5f8j5BODhiU=; b=n QJzj1FvmL8Kwk0PhtwriiOt+wNGQq+LIzGENkfG+EsF0IRd5Xw7WtfGA+DDsCe9p +PpQuFwBbGpwjIuutkWKiOyKiGGOncOghxsAjoD3BjuUTOmbYrq+oupT7fNICvVS 0hK2inyzRhkzO+E0wbOjer52jWrojjLB6G77fcK5OkeKA03rvsV4APnf2l4tacqd CoI6hS7q6gYq6q4tWmMbRMfQ46VpkWBNJMABJ55mVhtYnMgaeCPcmkbHN+GTEe4V Fkp3qrz4gxY2VC0/WUmzVnV1kXw3tjH93jNHjb8IWZvsJYBox+JG11zaONzqCl6R iXfOpR5rk8uJQ9ue82v5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664563892; x=1664650292; bh=fYpDprIN3a0QBYjQ4tUxQgz2zg/u Zs+W5f8j5BODhiU=; b=viHjFCA0aDXrouvCHGo4zHi8dFMSnEOyn5bXsrYmOkm3 0baiUtYd8KEB/pBkUIjkCNpA5+HJzbrodX6VySobo+jVIBpkDvnDJB0Ti/za0YXY e8OvS9lIsJ+YDm6EjAeana9Zo5VDMaPAv5i91rNfZ/M5NvczcRf8B9S1zSDbo/lF DkpyZhKmCRNctXCIONbhz6Y3O0/o6fpJA+6sbqbaVeyyYCo2UOitS8+Y2865UlzR DiCS4ztWciFzRAZJCAiZ6rqU61ILmh0IXHiRKmxH1K+IQMH9BVGwgrWezBS522MS ICrneDu/OZRCLEoQjMrSEDbvEoUz8skyy0hl3vIEmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffej geejgeffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 14:50:40 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Jan Beulich , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Message-ID: References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n+z3R9W5aeSXpiDo" Content-Disposition: inline In-Reply-To: --n+z3R9W5aeSXpiDo Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 14:50:40 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Jan Beulich , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered On Fri, Sep 30, 2022 at 08:27:09PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 19:12, Demi Marie Obenour > wrote: > > > > On Fri, Sep 30, 2022 at 06:30:57PM +0200, Ard Biesheuvel wrote: > > > On Fri, 30 Sept 2022 at 08:44, Jan Beulich wrote: > > > > > > > > On 30.09.2022 01:02, Demi Marie Obenour wrote: > > > > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOAD= ER_DATA, > > > > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobber= ed by > > > > > Xen before Linux gets to start using it. Therefore, Linux under = Xen > > > > > must not use EFI tables from such memory. Most of the remaining = EFI > > > > > memory types are not suitable for EFI tables, leaving only > > > > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > > > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should = only > > > > > use tables that are located in one of these types of memory. > > > > > > > > > > This patch ensures this, and also adds a function > > > > > (xen_config_table_memory_region_max()) that will be used later to > > > > > replace the usage of the EFI memory map in esrt.c when running un= der > > > > > Xen. This function can also be used in mokvar-table.c and efi-bg= rt.c, > > > > > but I have not implemented this. > > > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > > > In Xen we don't clobber EfiBootServices{Code,Data} when xen.efi was= passed > > > > "-mapbs". Should we perhaps extend the interface such that Dom0 can= then > > > > also use tables located in such regions, perhaps by faking > > > > EFI_MEMORY_RUNTIME in the attributes returned by XEN_FW_EFI_MEM_INF= O? > > > > > > > > > > I know this ship has sailed for x86, but for the sake of other > > > architectures, I'd strongly recommend leaving the EFI_MEMORY_RUNTIME > > > bits alone, for the same reasons I gave earlier. (Runtime mappings for > > > the firmware code itself, page table fragmentation etc etc) > > > > Why do you say that it has sailed for x86? > > >=20 > The x86 EFI code in Linux makes changes to the EFI memory map in many > different places in the code. On other architectures, we have managed > to avoid this, so that the EFI memory map is always identical to the > one provided by the firmware at boot. >=20 > > > I know very little about Xen, but based on the context you provided in > > > this thread, I'd say that the best approach from the Xen side is to > > > convert all EfiBootServicesData regions that have configuration tables > > > pointing into them into EfiAcpiReclaimMemory. > > > > Should Xen convert the entire region, or should it try to reserve only > > the memory it needs? The latter would require it to parse the > > configuration tables. Is there a list of configuration tables that can > > legitimately be in EfiBootServicesData regions? > > >=20 > Not really, no. Is there a list of tables that can be in EfiBootServicesData and which Linux cares about? > So you would have to convert the entire region > /unless/ Xen knows the GUID, and therefore knows how to derive the > size of the table, allowing it to reserve memory more conservatively. My worry is that this will wind up being equivalent to mapping all (or most) of EfiBootServicesData memory. > However, I doubt whether this is worth it: splitting entries implies > rewriting the memory map, which is a thing I'd rather avoid if I were > in your shoes. Xen actually uses a different approach: instead of rewriting the memory map, it uses the EFI pool allocator to allocate memory of the desired type, copies the table to the newly allocated memory, and installs the new table in place of the old one. That only works for tables Xen understands, though. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --n+z3R9W5aeSXpiDo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3OrEACgkQsoi1X/+c IsFXVw//fXEjFMwU9Qb0gHHWn8DmCyj0+4RN+aQXRl+6ZAQ++x44gm2ltJs7G9xS wnTtwQruHfGhQZKtFxFANBBSGEcpnZCPjRdjphnsmsAwq+bLEPEEW32XQJqNTrRX WD+Zor4IM35Mi+rX8o5+V5MfeNt6GnKUYd9AE7o/9+mOK6VwSGG+hbRsbhDqN7+6 d4mJO6lv44jepmB7Kr5RsmCSbBdhVomq7wI4Lp35pDmWxUm7FYT89eGGV1uZC3ew J6Gyl3V1I2w+ioDC4ap6wMMsIfv10m7JQ9s0/tArE7tjQ6PcxtazO+DuI6B2tce2 icXbKXzaKpnhHGECV+k+brhXLLpNbSTPLiMRA8zkbRQpHFmvEdxtNv6gqyUZTGfp REFFselwm4RSiNDTXZgq4xA+ZR9B5FapuihyD0ka94EjMvOgo+U7Q9p3qy1edcC6 4LbwGiQ02fdlxKKF61RB2NX4YJf9Im/98jzUxZ5Z5ke36fy7osSlJsfO4/E/MOjf dO2cEyt08MyDFUt/pcPriE3ZPNKqVncHEArv6cHwOhLDbBRAKe4w8S+0ul7ebGP5 WTzPiLBxioOD750zg354ULE78WikH/5Ir8H3zvTSG52/76dgZKUodOUiuhOXmHOu BZc7XikDleUdGinwUR7SBf0cYqjHhucnJ9wusRtj4vODQaQ7a0o= =nfqH -----END PGP SIGNATURE----- --n+z3R9W5aeSXpiDo-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 19:00:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 19:00:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414398.658656 (Exim 4.92) (envelope-from ) id 1oeLFJ-0000Xx-UL; Fri, 30 Sep 2022 19:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414398.658656; Fri, 30 Sep 2022 19:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeLFJ-0000Xq-Qg; Fri, 30 Sep 2022 19:00:25 +0000 Received: by outflank-mailman (input) for mailman id 414398; Fri, 30 Sep 2022 19:00:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeLFI-0000Xk-48 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 19:00:24 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 221153a4-40f2-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 21:00:22 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 7B4ED3200AE9; Fri, 30 Sep 2022 15:00:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 30 Sep 2022 15:00:20 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 15:00:17 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 221153a4-40f2-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664564419; x= 1664650819; bh=1He9L4siapS9LUXcCLtJSWJnW6PFsjgj1kBDJr0eMDw=; b=l 0/zpu9Sf/NROKRkT6ABsdO4PeJJjirO0FastIrVTb3qWfj9KT1KuTtnmj1tLVQWm 7LdbBQJhhr0J+BbFvg2QEaK8rLkbSPCGgBl6o5L+0p/FFipJsQPQAvj9MD+Aou6a Vzu/rx6qqADDZQFOREbpb3Ioqz8wgYlZcZhfqjVZ1EmGIVtt+kVpS2+HcAoGYzfC HfgGy2ML4qVvv9FofmlfAriXE2mx2RUX7ef3nMWB0+0mHdHHdBw29Fb7os+hooEG Gt2hHBaQm4HaGDg7yeEEhi0Ffg4Hn8GnMrVpe0hfx1Scn5pOLXDdY40eLOmr6qbV 86M7fpkZKsJElw640cVRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664564419; x=1664650819; bh=1He9L4siapS9LUXcCLtJSWJnW6PF sjgj1kBDJr0eMDw=; b=E1EZ4nR4Rc40L0gTD+yy3+bGuW+VAIMNJUElqJU1ohWQ sO4UNfVFW/THiRNZ0SZwlM4Aqxr8R74gNdx2GnqkSQUMxhfxfgQOvcJVIs5yqZYw K6vLRpKhQCyVUTOHytOoYCvHrMjX44p8wgO3zAYIs6sjWuRbxQRQDe4Qsy+zF+1z 05Jaq2pmPE/0t3QvxGjg39Z2+7abZKwhEoOZMHS6PxkPSZ+CO1vYEsftMCUAYWwE /pHD+9O9sdxNbSXq2e2oSPzQH6CpEGNOhTtlCiplniQzmf8ewMplmDFgzbEFrHyj He4YCxAzSUteo9oQFC8MXCysRePIwaC8cf6G/uxZ0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 15:00:08 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="si9cRwJ00DjE2kEi" Content-Disposition: inline In-Reply-To: --si9cRwJ00DjE2kEi Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 15:00:08 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered On Fri, Sep 30, 2022 at 08:42:41PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 20:17, Demi Marie Obenour > wrote: > > > > On Fri, Sep 30, 2022 at 06:25:53PM +0200, Ard Biesheuvel wrote: > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > > wrote: > > > > > > > > Memory of type EFI_CONVENTIONAL_MEMORY, EFI_LOADER_CODE, EFI_LOADER= _DATA, > > > > EFI_BOOT_SERVICES_CODE, and EFI_BOOT_SERVICES_DATA may be clobbered= by > > > > Xen before Linux gets to start using it. Therefore, Linux under Xen > > > > must not use EFI tables from such memory. Most of the remaining EFI > > > > memory types are not suitable for EFI tables, leaving only > > > > EFI_ACPI_RECLAIM_MEMORY, EFI_RUNTIME_SERVICES_DATA, and > > > > EFI_RUNTIME_SERVICES_CODE. When running under Xen, Linux should on= ly > > > > use tables that are located in one of these types of memory. > > > > > > > > This patch ensures this, and also adds a function > > > > (xen_config_table_memory_region_max()) that will be used later to > > > > replace the usage of the EFI memory map in esrt.c when running under > > > > Xen. This function can also be used in mokvar-table.c and efi-bgrt= =2Ec, > > > > but I have not implemented this. > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > --- > > > > drivers/firmware/efi/efi.c | 8 +++++--- > > > > drivers/xen/efi.c | 35 +++++++++++++++++++++++++++++++++++ > > > > include/linux/efi.h | 9 +++++++++ > > > > 3 files changed, 49 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > > > index e4080ad96089abd7f84745dd8461c548bcbb7685..d344f3ff73d1c5ed0c6= 7e3251a9502e66719741d 100644 > > > > --- a/drivers/firmware/efi/efi.c > > > > +++ b/drivers/firmware/efi/efi.c > > > > @@ -574,7 +574,6 @@ int __init efi_config_parse_tables(const efi_co= nfig_table_t *config_tables, > > > > unsigned long table; > > > > int i; > > > > > > > > - pr_info(""); > > > > > > Why are you removing these prints? > > > > If I left them, I would need to include a pr_cont("\n") later. >=20 > There should always be one at the end of the loop, no? Or is this > related to the diagnostic that gets printed in your helper? My helper emits a diagnostic (at severity KERN_WARNING) if the table is in memory that Xen has not reserved. > > Checkpatch recommends against that. What is the purpose of this print? > > I assumed that since it prints an empty string it is superfluous. > > >=20 > It prints the leading [invisible] loglevel marker, and the 'efi: ' prefix. Okay, that makes sense. > > > > for (i =3D 0; i < count; i++) { > > > > if (!IS_ENABLED(CONFIG_X86)) { > > > > guid =3D &config_tables[i].guid; > > > > @@ -585,7 +584,6 @@ int __init efi_config_parse_tables(const efi_co= nfig_table_t *config_tables, > > > > > > > > if (IS_ENABLED(CONFIG_X86_32) && > > > > tbl64[i].table > U32_MAX) { > > > > - pr_cont("\n"); > > > > pr_err("Table located above 4GB, di= sabling EFI.\n"); > > > > return -EINVAL; > > > > } > > > > @@ -594,10 +592,14 @@ int __init efi_config_parse_tables(const efi_= config_table_t *config_tables, > > > > table =3D tbl32[i].table; > > > > } > > > > > > > > +#ifdef CONFIG_XEN_EFI > > > > > > We tend to prefer IS_ENABLED() for cases such as this one. That way, > > > the compiler always gets to see the code inside the conditional block, > > > which gives better build test coverage (even if CONFIG_XEN_EFI is > > > disabled). > > > > Can I count on the compiler eliminating the code as unreachable? With > > CONFIG_XEN_EFI disabled xen_config_table_memory_region_max() would be an > > undefined symbol. > > >=20 > If you drop the #ifdef in the .h file (as I suggested below) the code > will compile fine, and the symbol reference will not be emitted into > the object, so it will link fine even if the Xen objects are not being > built. >=20 > We rely on this behavior all over the Linux kernel. Okay, thanks! > > > > + if (efi_enabled(EFI_PARAVIRT) && !xen_config_table_= memory_region_max(table)) > > > > > > So the question here is whether Xen thinks the table should be > > > disregarded or not. So let's define a prototype that reflects that > > > purpose, and let the implementation reason about how this should be > > > achieved. > > > > xen_config_table_memory_region_max() doesn=E2=80=99t just return whethe= r the > > table should be disregarded, but also (if the table should not be > > ignored) the end of the memory region containing it. >=20 > But the calling code never uses that value, right? The code in this patch does not use that value. Patch 2 of 2 does use it. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --si9cRwJ00DjE2kEi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3PL4ACgkQsoi1X/+c IsEIYA/9HsripL4/hkzbWBNFzQ1cou4naD3dTA15yeQYQxvydJtvrC0YAVVzAwet BaLPdw6RnrFIV37yB/T3K2Q3MYWae7/d5taOjmSQMVxF8x2EVyLGfovsNkFtfWJ6 18esuHpVR4khfW7WI6380ZHgs1XpQtHAqzOGrYTnOYUShAu45w8S44/2QrV2KGV1 FKbsJp8yD4dHY/bmRM1EhCnb/cLjSPu0sFvTe2a0DIuJAyqFmWj3LzTPquOR54eH zDhzWlsg8gYlQhYdIo2mgEA1Zb5xrakI8mwaG7tKPEFv2/yzorCT2EEA9dfJ1vo6 pUme0UgV0gjxrOEaTlPHCYM1s0Qm7yu4O1gdIMPaqC7vuHswoACCWuczdViCVzPZ n8AIFefEjgAYLyPoiZ3SRvisWPBF8hxd+BHvF/f3Ij9GKxsmrNtQ2fSQ0nmWu5Ac /JgLkz2cioulUl8ks+IO1/h607HYf7YYpxwc2DnnX63rykzwB2J7mIQeJx/PcPQI bGrjFTBw70sI0OtG9vGL1j52Y5zpTU8CxMKdZzI6Jf007tYlLhzia6qqjNmJxb7Q 4ZYSmWxZYb36KwbnDw6PLIr762oYuR7623gmlgclySia3YnQjC30Ga5/vYIodMQ1 nQa5WE9WzYdeudxJv+mZGDuBFAA/nEt0Wi67Q/rpHSYmsj6Ufzc= =Hyrk -----END PGP SIGNATURE----- --si9cRwJ00DjE2kEi-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 19:11:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 19:11:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414407.658667 (Exim 4.92) (envelope-from ) id 1oeLQA-0002GD-2Q; Fri, 30 Sep 2022 19:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414407.658667; Fri, 30 Sep 2022 19:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeLQ9-0002G6-VI; Fri, 30 Sep 2022 19:11:37 +0000 Received: by outflank-mailman (input) for mailman id 414407; Fri, 30 Sep 2022 19:11:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeLQ8-0002G0-Fh for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 19:11:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b2f3cb5b-40f3-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 21:11:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1F216242D for ; Fri, 30 Sep 2022 19:11:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32CDEC43140 for ; Fri, 30 Sep 2022 19:11:33 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id 10so8286652lfy.5 for ; Fri, 30 Sep 2022 12:11:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2f3cb5b-40f3-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664565093; bh=DpuzkSTpdIljztqf44fhe5W4QnPtXnDJDl0MM448ZSA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Yu+WvHfHfGIDERp3rGJw/Xo+T7KR5JXnWliHX2BfVnsPYHNj9dYu9HWaA8emZRFzp WP2RZn3PxpJhCTr/rEvWhDjqSXHIsIszDxu/yDsxYzD+0N1IHgI4eIZ9MvkFBQHPmw DEda+6g0QFLgSxla7ZBIuEgqIHZ3G5tVBO/ydJ9ZzXhMZKMNnkLAoi9NAYAItVLmZH 1Yr/20aKScBzpbJjOs1KLfcHUcozKb5yCP0ZOwUPI7fEBY6fA26DkQ6lEoAdZ+Kr8k BkyW4HJA1QtT6HOZXiOXBK8dcomZS9euTg8oRwOdsPMIEd+ryFFcAcebZBOPkeHLKJ vR4dng0BTd5yg== X-Gm-Message-State: ACrzQf3fGSe/qKvSKRuNDai17ju3DTgpyROd4VSNMVi9LMMAWr9QCaCP QDPh3e73qyubNuIJ8EFs4geFCOpHjGuRr/4Ik1U= X-Google-Smtp-Source: AMsMyM6FMMowE7tQWhR4Sq9LW0sZJqpKjwTPTYH1uPBheNCSsYgu+96uM6IHl9lGbwAD0/no5/Q6kEg0CtZpAWItDo4= X-Received: by 2002:a05:6512:c0f:b0:49b:1e8c:59fd with SMTP id z15-20020a0565120c0f00b0049b1e8c59fdmr3582078lfu.426.1664565091147; Fri, 30 Sep 2022 12:11:31 -0700 (PDT) MIME-Version: 1.0 References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 30 Sep 2022 21:11:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 To: Demi Marie Obenour , Peter Jones Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour wrote: > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > wrote: > > > > > > fwupd requires access to the EFI System Resource Table (ESRT) to > > > discover which firmware can be updated by the OS. Currently, Linux does > > > not expose the ESRT when running as a Xen dom0. Therefore, it is not > > > possible to use fwupd in a Xen dom0, which is a serious problem for e.g. > > > Qubes OS. > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limitations. > > > The UEFI specification requires the ESRT to be in EfiBootServicesData > > > memory, which Xen will use for whatever purposes it likes. Therefore, > > > Linux cannot safely access the ESRT, as Xen may have overwritten it. > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServicesData > > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServicesData > > > memory, Xen replaces the ESRT with a copy in memory that it has > > > reserved. Such memory is currently of type EFI_RUNTIME_SERVICES_DATA, > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. This > > > ensures that the ESRT can safely be accessed by the OS. > > > > > > When running as a Xen dom0, use the new > > > xen_config_table_memory_region_max() function to determine if Xen has > > > reserved the ESRT and, if so, find the end of the memory region > > > containing it. This allows programs such as fwupd which require the > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS possible. > > > > > > Signed-off-by: Demi Marie Obenour > > > > Why do we need this patch? I'd expect esrt_table_exists() to return > > false when patch 1/2 is applied. > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be an > alternative way to get the end of the memory region containing the ESRT. > That is what this patch provides. OK. I don't think we need that to be honest. When running under Xen, we should be able to assume that the ESRT does not span multiple memory regions arbitrarily, so we can just omit this check if !efi_enabled(EFI_MEMMAP) IIRC (and Peter would know), we are trying to filter out descriptors that are completely bogus here: zero lenght, zero address, etc etc. I don't think we need that for Xen. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 20:21:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 20:21:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414415.658678 (Exim 4.92) (envelope-from ) id 1oeMVn-0001sC-15; Fri, 30 Sep 2022 20:21:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414415.658678; Fri, 30 Sep 2022 20:21:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeMVm-0001s5-Uh; Fri, 30 Sep 2022 20:21:30 +0000 Received: by outflank-mailman (input) for mailman id 414415; Fri, 30 Sep 2022 20:21:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeMVl-0001rz-0Y for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 20:21:29 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74a3b5a5-40fd-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 22:21:26 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id ACA2032009DE; Fri, 30 Sep 2022 16:21:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 30 Sep 2022 16:21:23 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 16:21:21 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74a3b5a5-40fd-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664569282; x= 1664655682; bh=84YQ6t1Q62lDEfE85H9mFCEwx6xIrWnJ1go7THDuksI=; b=d BzXQfbJioxFl13JRwhDDRVWlna7IqFGwpswqsTZfAk7e7oW56bkRJccVdDmpq5q1 RVfpdlwkzilQ+pkqPpqulH3t1/vamByed7X74XUvHFt54+1pZ5PqFJbCdPYKE6Ad mvsG0pmNUN4lVkgxP967a7mZBkcTaOAw9vA9k65bKKC/L1F1282Db2lhinwy9DA9 zpUiJdTm0j4IHiN2Qu+9BXq6hHVV0bQsUosyVnWd9N9p9yYxoxFiTITW85slPE2g vKDwKf8W3nPy6JtmUQwp0TuiMIlZU5GcztZDXA/5oi5r4MB5Y3M6EiaAnYAM7Kn8 xS407msLguGO8wkqp4eGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664569282; x=1664655682; bh=84YQ6t1Q62lDEfE85H9mFCEwx6xI rWnJ1go7THDuksI=; b=ErRJOnvvMEnQxfGMllCeFVhHvrLbPoGFlN2HBfK9IuAK bnwMhmytF6bzReu/BQp8QjwMAC7xCe82L1Pf8HLRg8/PkAFJ350x3KFlY68YuK6/ +MokEcEjz7KnIEzt5QHQawltz5TQC2pim127Oh57SiFpK6GUlo7wO4Adwu/njcw0 6/wC2VcWpvbeL4g6G66V1pkscqTiXPb4EQS636r/HbCUUKoBpF8JmyJEGuQlJ8Tc JxO8/I/MX5Ujqfyoop5wmzxAL3kDxnVjJJY0DqESPdTPsB2pGCaR1VuyjAlwCXv/ eRVULSGqKZPvTpobNfdQrlMIEphXvUxrz7L/P3+K5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 16:20:51 -0400 From: Demi Marie Obenour To: Ard Biesheuvel , Peter Jones Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 Message-ID: References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yKB7OHjMbPEa6C9c" Content-Disposition: inline In-Reply-To: --yKB7OHjMbPEa6C9c Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 16:20:51 -0400 From: Demi Marie Obenour To: Ard Biesheuvel , Peter Jones Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 On Fri, Sep 30, 2022 at 09:11:19PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour > wrote: > > > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > > wrote: > > > > > > > > fwupd requires access to the EFI System Resource Table (ESRT) to > > > > discover which firmware can be updated by the OS. Currently, Linux= does > > > > not expose the ESRT when running as a Xen dom0. Therefore, it is n= ot > > > > possible to use fwupd in a Xen dom0, which is a serious problem for= e.g. > > > > Qubes OS. > > > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limitations. > > > > The UEFI specification requires the ESRT to be in EfiBootServicesDa= ta > > > > memory, which Xen will use for whatever purposes it likes. Therefo= re, > > > > Linux cannot safely access the ESRT, as Xen may have overwritten it. > > > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootService= sData > > > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootService= sData > > > > memory, Xen replaces the ESRT with a copy in memory that it has > > > > reserved. Such memory is currently of type EFI_RUNTIME_SERVICES_DA= TA, > > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. This > > > > ensures that the ESRT can safely be accessed by the OS. > > > > > > > > When running as a Xen dom0, use the new > > > > xen_config_table_memory_region_max() function to determine if Xen h= as > > > > reserved the ESRT and, if so, find the end of the memory region > > > > containing it. This allows programs such as fwupd which require the > > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS possi= ble. > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > Why do we need this patch? I'd expect esrt_table_exists() to return > > > false when patch 1/2 is applied. > > > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be an > > alternative way to get the end of the memory region containing the ESRT. > > That is what this patch provides. >=20 > OK. I don't think we need that to be honest. When running under Xen, > we should be able to assume that the ESRT does not span multiple > memory regions arbitrarily, so we can just omit this check if > !efi_enabled(EFI_MEMMAP) >=20 > IIRC (and Peter would know), we are trying to filter out descriptors > that are completely bogus here: zero lenght, zero address, etc etc. I > don't think we need that for Xen. Xen doesn=E2=80=99t uninstall bogus ESRTs, so there is no less reason to wo= rry under Xen than on bare hardware. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --yKB7OHjMbPEa6C9c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3T78ACgkQsoi1X/+c IsFx7g/7BRp/7YBEuzU1LNbSnhRm6J9VM6ymA3kACNbZTwvhMoFDGftYiS8N//Bf 275dq6kanlCN68p69Eksa6ze+GdEmgfdRzY0vbGdFSZXACLSySlIPBr7jRr/yXzp 5Ys2MZgfps8wwXCzpjIXq/lobVHPS+C9m5Rlf3rsrEaR2RMV+eaEZLtTSfCyOwGT hKfkmte/pFShv0Z/TdSq9IT1l4CvyhFXJKMH2vyiQ8dF9Cfdw5heW2CLaD/WI1DA 0ddE23IMlLd9tGaxlL1Hce6wVMCWsu9KCghOQXDX6J9swv9jynPvx+fo3CzyC4Ng 98xq9LdZRs8dWiUTpaxtkFaqvkPbBO4l5SQx79NwEzI9sH/R8PN5a8qtWmzCXv3h rjt7E1qYRYoi86in1ealzvb2jm09hMavAiXxHU/TpnT8kDpid2X4ztCWD2haYQm5 zBWFpAz4iNtDw2MkaoaIUnTmi9mAI2UxEZnIxF0EdIBis9eSn2yBrWFJGADFdCPU pbNkJ6KVp02kwj8+Vmju56905z5Ny99wASK+DJlZl7TybUdXG3O4b+hPwhg4WjyQ VFjY4rOoceNvnPI7BnuuGB6B0HJA8z8+ZgucaTPavbXmA1rjNy7LYKGbI3hIDWag E4I/IB/8LT4lQdcckCtDln+0VSSMAWUBYoEuuBZihH85c4JwoGM= =IY+Q -----END PGP SIGNATURE----- --yKB7OHjMbPEa6C9c-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 21:00:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 21:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414422.658689 (Exim 4.92) (envelope-from ) id 1oeN7A-0006eF-0s; Fri, 30 Sep 2022 21:00:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414422.658689; Fri, 30 Sep 2022 21:00:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeN79-0006e8-S0; Fri, 30 Sep 2022 21:00:07 +0000 Received: by outflank-mailman (input) for mailman id 414422; Fri, 30 Sep 2022 21:00:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeN78-0006Za-TF for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 21:00:07 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db3c4329-4102-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 23:00:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C8F8162502 for ; Fri, 30 Sep 2022 21:00:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5714C43142 for ; Fri, 30 Sep 2022 21:00:02 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id a8so8590172lff.13 for ; Fri, 30 Sep 2022 14:00:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db3c4329-4102-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664571602; bh=vkwsIzcGS2jETeiJRp/8RutxMOCJl7Zv/6Fd6qBBQLM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LjxK9Gt2NBW7WLTNzEZIz0QlS1LRUB5Uz1+M45mYi0Im0Nz+dSMfiHhIy26kWWxiL hWqPn3QSegLK4YRVGqftKVGFKeuFYcMYHr0tvdMKE1HkYHKqsixXGjhI3HNWUWXt1K s7877yOhSq2eu4+vOTU80hhHSr+9dzlHrSS6TSKI14PGUg9PVgELcYQw4GEKUQ3Va+ cCNVRzkpCMFMi4VVQMBHf7gwZSmC4JtPHYtNtukyHwadNwilBaKFSWzOmuiYXgiCjO GxBSDazC8jDVbgTlpLZCI1I1U2/I3KeCvGUGNhDSC68PsU6YVfcFR7R3QJZuRCuxB6 SZhtKkmNTJfwA== X-Gm-Message-State: ACrzQf3gbKgmMWmD0GYfA2bCLsddzKAOT0MhzXGdRpELU2XWU9JSvRmf o4anYMPHzbTqhfWij0inqZRfBmHOyJ8raLteRtY= X-Google-Smtp-Source: AMsMyM76JzlePLAxTaPu+4BrMa6gPr+Ax0OkeuNIJlRyNAL2lYOchpuPlVaNfch3zgsaxDjFCwvhwxcgW/xIMQfm6C4= X-Received: by 2002:a05:6512:261b:b0:4a1:abd7:3129 with SMTP id bt27-20020a056512261b00b004a1abd73129mr4091546lfb.637.1664571600418; Fri, 30 Sep 2022 14:00:00 -0700 (PDT) MIME-Version: 1.0 References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 30 Sep 2022 22:59:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 30 Sept 2022 at 22:21, Demi Marie Obenour wrote: > > On Fri, Sep 30, 2022 at 09:11:19PM +0200, Ard Biesheuvel wrote: > > On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour > > wrote: > > > > > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > > > wrote: > > > > > > > > > > fwupd requires access to the EFI System Resource Table (ESRT) to > > > > > discover which firmware can be updated by the OS. Currently, Lin= ux does > > > > > not expose the ESRT when running as a Xen dom0. Therefore, it is= not > > > > > possible to use fwupd in a Xen dom0, which is a serious problem f= or e.g. > > > > > Qubes OS. > > > > > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limitatio= ns. > > > > > The UEFI specification requires the ESRT to be in EfiBootServices= Data > > > > > memory, which Xen will use for whatever purposes it likes. There= fore, > > > > > Linux cannot safely access the ESRT, as Xen may have overwritten = it. > > > > > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootServi= cesData > > > > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootServi= cesData > > > > > memory, Xen replaces the ESRT with a copy in memory that it has > > > > > reserved. Such memory is currently of type EFI_RUNTIME_SERVICES_= DATA, > > > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. Th= is > > > > > ensures that the ESRT can safely be accessed by the OS. > > > > > > > > > > When running as a Xen dom0, use the new > > > > > xen_config_table_memory_region_max() function to determine if Xen= has > > > > > reserved the ESRT and, if so, find the end of the memory region > > > > > containing it. This allows programs such as fwupd which require = the > > > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS pos= sible. > > > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > > > Why do we need this patch? I'd expect esrt_table_exists() to return > > > > false when patch 1/2 is applied. > > > > > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be an > > > alternative way to get the end of the memory region containing the ES= RT. > > > That is what this patch provides. > > > > OK. I don't think we need that to be honest. When running under Xen, > > we should be able to assume that the ESRT does not span multiple > > memory regions arbitrarily, so we can just omit this check if > > !efi_enabled(EFI_MEMMAP) > > > > IIRC (and Peter would know), we are trying to filter out descriptors > > that are completely bogus here: zero lenght, zero address, etc etc. I > > don't think we need that for Xen. > > Xen doesn=E2=80=99t uninstall bogus ESRTs, so there is no less reason to = worry > under Xen than on bare hardware. That may be true. But if Xen needs dom0 to be able to cross reference the EFI memory map, it should provide one (and set EFI_MEMMAP to enabled). From xen-devel-bounces@lists.xenproject.org Fri Sep 30 21:02:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 21:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414428.658700 (Exim 4.92) (envelope-from ) id 1oeN9H-0007EP-Cj; Fri, 30 Sep 2022 21:02:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414428.658700; Fri, 30 Sep 2022 21:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeN9H-0007EI-9l; Fri, 30 Sep 2022 21:02:19 +0000 Received: by outflank-mailman (input) for mailman id 414428; Fri, 30 Sep 2022 21:02:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeN9F-0007EC-NQ for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 21:02:17 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2759a43f-4103-11ed-9374-c1cf23e5d27e; Fri, 30 Sep 2022 23:02:15 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B958332009E9; Fri, 30 Sep 2022 17:02:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 30 Sep 2022 17:02:11 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 17:02:09 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2759a43f-4103-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1664571730; x= 1664658130; bh=SrvXwx1KQz8zocMSydwkAX7BOT6io7TjAP4ceCsuvq8=; b=G cPez/6imDEcCLPKSAwMZ+T0mXC2WbOBpFAP+z614HahyyUV1BKV1Hz+rDp7nHx3o htUR83paP3zDWPFC+x3hX4QUMs1oVqKXHOMniWMEwdVCp1rf4DeqXZ/AU5ITnqvz 0Sazg8evd0o8+aswiB8OfGrHwG1L+xhuvCkmBNE84RYHZod9Ub8XenfaYFg62v2P nKyCeTx42qOHf4LG+adBxDciKGofU4z8pSoFpXwoD6FVyHsSGxR/+1G/xlt7aKhT m36wefLKFDmiKYAwgIA7r3IoBS2A3r6SI9V6GLk+YuaOWbU/H5/4xDuEKDcxdD7P DyQASn74eJGt/7Kw6fbiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1664571730; x=1664658130; bh=SrvXwx1KQz8zocMSydwkAX7BOT6io7TjAP4 ceCsuvq8=; b=DVuCfkM9aIsEGLGQR6GbcOmIdAowjXoErUnFdLwUYpPjvsnOCOX H7WukfPJb0hWaPrNkpwFGtv7P7hPERIzlcYXF5OUHJHPz4VUuAudvGbRVr9curRG vBPl2YtyHTnNqIeqymdlaQvtt8UKlZmkS0zVuCDPwYQ3MvpAvloLtX7B32zcIelc A0QMlt8+RrzWMnLxgzBLn7GFpEakSnZhHviKwqD/XDn4c6UGaKL7mFe0tjAgaVJc zLQ4luemYmLb0T+Qfns66GRAIN2tYGVqaGwHKIxGla1JsQIaiFpZmayJQdUTKS1q zS7QSwllnjS9yBkurZP6ea6acMAwYVW0gOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvfeegkedvkefgffegkefhieejtdff keehhfelheefjeeutefgleeggfdtveeileenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Jan Beulich , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH] Use EfiACPIReclaimMemory for ESRT Date: Fri, 30 Sep 2022 17:02:02 -0400 Message-Id: <2561c7fc38d9b4d17cb0205fec49b941894cfcc0.1664570575.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As discussed on xen-devel, using EfiRuntimeServicesData for more than is absolutely necessary is a bad idea. --- xen/common/efi/boot.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index db0340c8e2628314226c618dda11ede4c62fdf3b..dba23439758d1e842d267dcd19448e0f9113b115 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -601,11 +601,13 @@ static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) if ( physical_start > esrt || esrt - physical_start >= len ) return 0; /* - * The specification requires EfiBootServicesData, but accept - * EfiRuntimeServicesData, which is a more logical choice. + * The specification requires EfiBootServicesData, but also accept + * EfiRuntimeServicesData (for compatibility) and EfiACPIReclaimMemory + * (which will contain the tables after successful kexec). */ if ( (desc->Type != EfiRuntimeServicesData) && - (desc->Type != EfiBootServicesData) ) + (desc->Type != EfiBootServicesData) && + (desc->Type != EfiACPIReclaimMemory) ) return 0; available_len = len - (esrt - physical_start); if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) ) @@ -1144,18 +1146,19 @@ static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) for ( i = 0; i < info_size; i += mdesc_size ) { /* - * ESRT needs to be moved to memory of type EfiRuntimeServicesData + * ESRT needs to be moved to memory of type EfiACPIReclaimMemory * so that the memory it is in will not be used for other purposes. */ void *new_esrt = NULL; - size_t esrt_size = get_esrt_size(memory_map + i); + const EFI_MEMORY_DESCRIPTOR *desc = memory_map + i; + size_t esrt_size = get_esrt_size(desc); if ( !esrt_size ) continue; - if ( ((EFI_MEMORY_DESCRIPTOR *)(memory_map + i))->Type == - EfiRuntimeServicesData ) + if ( desc->Type == EfiRuntimeServicesData || + desc->Type == EfiACPIReclaimMemory ) break; /* ESRT already safe from reuse */ - status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, + status = efi_bs->AllocatePool(EfiACPIReclaimMemory, esrt_size, &new_esrt); if ( status == EFI_SUCCESS && new_esrt ) { -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Sep 30 21:25:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 21:25:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414437.658711 (Exim 4.92) (envelope-from ) id 1oeNVA-0001Kv-B0; Fri, 30 Sep 2022 21:24:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414437.658711; Fri, 30 Sep 2022 21:24:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeNVA-0001Ko-84; Fri, 30 Sep 2022 21:24:56 +0000 Received: by outflank-mailman (input) for mailman id 414437; Fri, 30 Sep 2022 21:24:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeNV8-0001Ki-8E for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 21:24:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51f60d58-4106-11ed-964a-05401a9f4f97; Fri, 30 Sep 2022 23:24:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6EFBD62508 for ; Fri, 30 Sep 2022 21:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C3A3C43143 for ; Fri, 30 Sep 2022 21:24:50 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id o7so1454438lfk.7 for ; Fri, 30 Sep 2022 14:24:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51f60d58-4106-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664573090; bh=30nChzLQuXr92StWJJlgPGxevZR3popgF5oyJwpVxYk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=n2OJlhNEJosXyp17WUQOqLLVp4MocrMWY81zEE4SYAT1+tqJ7GtsTJ57gzSMucPrd TmrQUgv5XHAWTSfRsx7KOCSQnEf9l4uWzkofvmfkUp6T+0ni4kv/lHrf3FFp2HiHt7 qWTOhJ5s+WDdkVBRlBN90Y+84iQntqF0J9q1M486bdYhurXHtES8qLQeL4X35GAKrh p2PauqyERpzLydcCxYKbsbG1lFOKZqRhJilQT4aYIlSQafWUZGve8pjMUME5s7nNi9 vAL2ecckDsn0DQXhnBVZf3cv8zmiocsK2BaaRSzzeYSMEvN0fgcR8fCipf9JRHqpzv yJdEuQJU0E5Rw== X-Gm-Message-State: ACrzQf0T9Zhfdss5pXaU2BczIEz+KytkBqhnCA/EirwY7O8yU0cE6xcW bdh/4ZpQ+f5Ph7/qjgQGNulLURgmqjpP9IlpkTc= X-Google-Smtp-Source: AMsMyM7PA/FdfwX29hZGmfUQ+efLBEEjqC3yYjmOMXwajxKUALIR8Lh25MoQk0mQ5O4TFL/l6csXOIwF0WTfV82/2Pg= X-Received: by 2002:a05:6512:3691:b0:4a1:f82a:9067 with SMTP id d17-20020a056512369100b004a1f82a9067mr4317344lfs.110.1664573088377; Fri, 30 Sep 2022 14:24:48 -0700 (PDT) MIME-Version: 1.0 References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 30 Sep 2022 23:24:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 To: Demi Marie Obenour Cc: Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 30 Sept 2022 at 22:59, Ard Biesheuvel wrote: > > On Fri, 30 Sept 2022 at 22:21, Demi Marie Obenour > wrote: > > > > On Fri, Sep 30, 2022 at 09:11:19PM +0200, Ard Biesheuvel wrote: > > > On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour > > > wrote: > > > > > > > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > > > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > > > > wrote: > > > > > > > > > > > > fwupd requires access to the EFI System Resource Table (ESRT) t= o > > > > > > discover which firmware can be updated by the OS. Currently, L= inux does > > > > > > not expose the ESRT when running as a Xen dom0. Therefore, it = is not > > > > > > possible to use fwupd in a Xen dom0, which is a serious problem= for e.g. > > > > > > Qubes OS. > > > > > > > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limitat= ions. > > > > > > The UEFI specification requires the ESRT to be in EfiBootServic= esData > > > > > > memory, which Xen will use for whatever purposes it likes. The= refore, > > > > > > Linux cannot safely access the ESRT, as Xen may have overwritte= n it. > > > > > > > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootSer= vicesData > > > > > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootSer= vicesData > > > > > > memory, Xen replaces the ESRT with a copy in memory that it has > > > > > > reserved. Such memory is currently of type EFI_RUNTIME_SERVICE= S_DATA, > > > > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. = This > > > > > > ensures that the ESRT can safely be accessed by the OS. > > > > > > > > > > > > When running as a Xen dom0, use the new > > > > > > xen_config_table_memory_region_max() function to determine if X= en has > > > > > > reserved the ESRT and, if so, find the end of the memory region > > > > > > containing it. This allows programs such as fwupd which requir= e the > > > > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS p= ossible. > > > > > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > > > > > Why do we need this patch? I'd expect esrt_table_exists() to retu= rn > > > > > false when patch 1/2 is applied. > > > > > > > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be an > > > > alternative way to get the end of the memory region containing the = ESRT. > > > > That is what this patch provides. > > > > > > OK. I don't think we need that to be honest. When running under Xen, > > > we should be able to assume that the ESRT does not span multiple > > > memory regions arbitrarily, so we can just omit this check if > > > !efi_enabled(EFI_MEMMAP) > > > > > > IIRC (and Peter would know), we are trying to filter out descriptors > > > that are completely bogus here: zero lenght, zero address, etc etc. I > > > don't think we need that for Xen. > > > > Xen doesn=E2=80=99t uninstall bogus ESRTs, so there is no less reason t= o worry > > under Xen than on bare hardware. > > That may be true. But if Xen needs dom0 to be able to cross reference > the EFI memory map, it should provide one (and set EFI_MEMMAP to > enabled). Btw the efi_mem_reserve() for the ESRT is also redundant if it is guaranteed to be in RT services data or ACPI reclaim memory. From xen-devel-bounces@lists.xenproject.org Fri Sep 30 21:48:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 21:48:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414442.658721 (Exim 4.92) (envelope-from ) id 1oeNra-0003pV-8C; Fri, 30 Sep 2022 21:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414442.658721; Fri, 30 Sep 2022 21:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeNra-0003pO-4Y; Fri, 30 Sep 2022 21:48:06 +0000 Received: by outflank-mailman (input) for mailman id 414442; Fri, 30 Sep 2022 21:48:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeNrZ-0003pE-Db; Fri, 30 Sep 2022 21:48:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeNrZ-0002aq-85; Fri, 30 Sep 2022 21:48:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeNrY-00033o-Mi; Fri, 30 Sep 2022 21:48:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oeNrY-0001cX-MI; Fri, 30 Sep 2022 21:48:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eBcBbIAFfXUHcOhRfoEVeqDVUDQz5zhYjiOE7egBkEs=; b=6XCZu2rYP6YQHJqsZiOuIb/zqF Yoz8wSamHb7VCIIBzGqRlikQ9lZsQuM05pEc7OY3c4iwMpEaZMdPqKcI7pK2O8P/aNZpJvlf/xjSW e5zXT68aeuWvhIEusAfBqyHQxYZchd6M/BiFYrUdYIISjNeYHsi7JBmndHJ8ilG7wTRA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 173385: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable:build-i386::broken:regression xen-unstable:build-i386-prev::broken:regression xen-unstable:build-i386-pvops::broken:regression xen-unstable:build-i386-xsm::broken:regression xen-unstable:build-i386-xsm:host-install(4):broken:regression xen-unstable:build-i386-pvops:host-install(4):broken:regression xen-unstable:build-i386-prev:host-install(4):broken:regression xen-unstable:build-i386:host-install(4):broken:regression xen-unstable:test-arm64-arm64-xl-xsm:xen-boot:fail:regression xen-unstable:test-arm64-arm64-libvirt-raw:guest-start:fail:regression xen-unstable:test-amd64-i386-examine-bios:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine-uefi:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking xen-unstable:build-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=38e1276db4c5457cd6e7811b4e168aa85c8a0b06 X-Osstest-Versions-That: xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc From: osstest service owner Date: Fri, 30 Sep 2022 21:48:04 +0000 flight 173385 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173385/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386 broken build-i386-prev broken build-i386-pvops broken build-i386-xsm broken build-i386-xsm 4 host-install(4) broken REGR. vs. 173379 build-i386-pvops 4 host-install(4) broken REGR. vs. 173379 build-i386-prev 4 host-install(4) broken REGR. vs. 173379 build-i386 4 host-install(4) broken REGR. vs. 173379 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173379 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 173379 Tests which did not succeed, but are not blocking: test-amd64-i386-examine-bios 1 build-check(1) blocked n/a test-amd64-i386-examine-uefi 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-livepatch 1 build-check(1) blocked n/a test-amd64-i386-migrupgrade 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-examine 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173379 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 173379 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173379 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173379 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 173379 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173379 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173379 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 173379 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 38e1276db4c5457cd6e7811b4e168aa85c8a0b06 baseline version: xen 211d8419ef8d8a237ff914fd8304b8fefc3ff2cc Last test of basis 173379 2022-09-30 01:52:22 Z 0 days Testing same since 173385 2022-09-30 11:39:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Dmytro Semenets Jan Beulich Michal Orzel Nathan Studer Oleksandr Andrushchenko Roger Pau Monné Stefano Stabellini Stewart Hildebrand Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm broken build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 broken build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt blocked build-amd64-prev pass build-i386-prev broken build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops broken test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch blocked test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-i386 broken broken-job build-i386-prev broken broken-job build-i386-pvops broken broken-job build-i386-xsm broken broken-step build-i386-xsm host-install(4) broken-step build-i386-pvops host-install(4) broken-step build-i386-prev host-install(4) broken-step build-i386 host-install(4) Not pushing. ------------------------------------------------------------ commit 38e1276db4c5457cd6e7811b4e168aa85c8a0b06 Author: Jan Beulich Date: Fri Sep 30 09:56:27 2022 +0200 Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access( While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute from gic_iomem_deny_access()"), the issue really became apparent only when iomem_deny_access() was switched to have a non-const first parameter. Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Michal Orzel Tested-by: Michal Orzel Reviewed-by: Bertrand Marquis commit b1f4b45d02cac2bf704c2fcc61c70c3567cfaa5b Author: Jan Beulich Date: Fri Sep 30 09:55:34 2022 +0200 x86/NUMA: correct off-by-1 in node map size calculation extract_lsb_from_nodes() accumulates "memtop" from all PDXes one past the covered ranges. Hence the maximum address which can validly by used to index the node map is one below this value, and we may currently set up a node map with an unused (and never initialized) trailing entry. In boundary cases this may also mean we dynamically allocate a page when the static (64-entry) map would suffice. While there also correct the comment ahead of the function, for it to match the actual code: Linux commit 54413927f022 ("x86-64: x86_64-make-the-numa-hash-function-nodemap-allocation fix fix") removed the ORing in of the end address before we actually cloned their code. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Reviewed-by: Wei Chen commit defa4e51d20a143bdd4395a075bf0933bb38a9a4 Author: Tamas K Lengyel Date: Fri Sep 30 09:53:49 2022 +0200 x86/vpmu: Fix race-condition in vpmu_load The vPMU code-bases attempts to perform an optimization on saving/reloading the PMU context by keeping track of what vCPU ran on each pCPU. When a pCPU is getting scheduled, checks if the previous vCPU isn't the current one. If so, attempts a call to vpmu_save_force. Unfortunately if the previous vCPU is already getting scheduled to run on another pCPU its state will be already runnable, which results in an ASSERT failure. Fix this by always performing a pmu context save in vpmu_save when called from vpmu_switch_from, and do a vpmu_load when called from vpmu_switch_to. While this presents a minimal overhead in case the same vCPU is getting rescheduled on the same pCPU, the ASSERT failure is avoided and the code is a lot easier to reason about. Signed-off-by: Tamas K Lengyel Acked-by: Jan Beulich commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f Author: Anthony PERARD Date: Thu Sep 29 10:51:31 2022 +0100 automation: Information about running containers for a different arch Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit a210e94af38a957fcc99db01d2cfcc3039859445 Author: Michal Orzel Date: Mon Sep 19 20:37:37 2022 +0200 xen/arm: domain_build: Always print the static shared memory region At the moment, the information about allocating static shared memory region is only printed during the debug build. This information can also be helpful for the end user (which may not be the same as the person building the package), so switch to printk(). Also drop XENLOG_INFO to be consistent with other printk() used to print the domain information. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Release-acked-by: Henry Wang commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a Author: Jan Beulich Date: Thu Sep 29 14:47:45 2022 +0200 x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area was available only to native domains. Linux, for example, would attempt to use it irrespective of guest bitness (including in its so called PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we set only for clocksource=tsc, which in turn needs engaging via command line option). Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Release-acked-by: Henry Wang commit 9214da34a3cb017ff0417900250bd6d18ca89e15 Author: Jan Beulich Date: Thu Sep 29 14:46:50 2022 +0200 x86: re-connect VCPUOP_send_nmi for 32-bit guests With the "inversion" of VCPUOP handling, processing arch-specific ones first, the forwarding of this sub-op from the (common) compat handler to (common) non-compat one did no longer have the intended effect. It now needs forwarding between the arch-specific handlers. Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-acked-by: Henry Wang commit c4e5cc2ccc5b8274d02f7855c4769839989bb349 Author: Roger Pau Monné Date: Thu Sep 29 14:44:10 2022 +0200 x86/ept: limit calls to memory_type_changed() memory_type_changed() is currently only implemented for Intel EPT, and results in the invalidation of EMT attributes on all the entries in the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits when the guest tries to access any gfns for the first time, which results in the recalculation of the EMT for the accessed page. The vmexit and the recalculations are expensive, and as such should be avoided when possible. Remove the call to memory_type_changed() from XEN_DOMCTL_memory_mapping: there are no modifications of the iomem_caps ranges anymore that could alter the return of cache_flush_permitted() from that domctl. Encapsulate calls to memory_type_changed() resulting from changes to the domain iomem_caps or ioport_caps ranges in the helpers themselves (io{ports,mem}_{permit,deny}_access()), and add a note in epte_get_entry_emt() to remind that changes to the logic there likely need to be propagaed to the IO capabilities helpers. Note changes to the IO ports or memory ranges are not very common during guest runtime, but Citrix Hypervisor has an use case for them related to device passthrough. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543 Author: Roger Pau Monné Date: Thu Sep 29 14:41:13 2022 +0200 arm/vgic: drop const attribute from gic_iomem_deny_access() While correct from a code point of view, the usage of the const attribute for the domain parameter of gic_iomem_deny_access() is at least partially bogus. Contents of the domain structure (the iomem rangeset) is modified by the function. Such modifications succeed because right now the iomem rangeset is allocated separately from struct domain, and hence is not subject to the constness of struct domain. Amend this by dropping the const attribute from the function parameter. This is required by further changes that will convert iomem_{permit,deny}_access into a function. Signed-off-by: Roger Pau Monné Reviewed-by: Bertrand Marquis commit 0db195c1a9947240b354abbefd2afac6c73ad6a8 Author: Jan Beulich Date: Thu Sep 29 14:39:52 2022 +0200 x86/NUMA: correct memnode_shift calculation for single node system SRAT may describe even a single node system (including such with multiple nodes, but only one having any memory) using multiple ranges. Hence simply counting the number of ranges (note that function parameters are mis-named) is not an indication of the number of nodes in use. Since we only care about knowing whether we're on a single node system, accounting for this is easy: Increment the local variable only when adjacent ranges are for different nodes. That way the count may still end up larger than the number of nodes in use, but it won't be larger than 1 when only a single node has any memory. To compensate populate_memnodemap() now needs to be prepared to find the correct node ID already in place for a range. (This could of course also happen when there's more than one node with memory, while at least one node has multiple adjacent ranges, provided extract_lsb_from_nodes() would also know to recognize this case.) Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné commit e1de23b7c1bfa02447a79733e64184b3635e0587 Author: Stewart Hildebrand Date: Thu Sep 29 14:38:22 2022 +0200 MAINTAINERS: ARINC 653 scheduler maintainer updates Add Nathan Studer as co-maintainer. I am departing DornerWorks. I will still be working with Xen in my next role, and I still have an interest in co-maintaining the ARINC 653 scheduler, so change to my personal email address. Signed-off-by: Stewart Hildebrand Acked-by: Nathan Studer commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd Author: Oleksandr Andrushchenko Date: Thu Sep 29 14:38:02 2022 +0200 tools: remove xenstore entries on vchan server closure vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets Reviewed-by: Juergen Gross Acked-by: Anthony PERARD (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Sep 30 22:24:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 22:24:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414452.658733 (Exim 4.92) (envelope-from ) id 1oeOQK-00088T-5Y; Fri, 30 Sep 2022 22:24:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414452.658733; Fri, 30 Sep 2022 22:24:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeOQK-00088M-1Z; Fri, 30 Sep 2022 22:24:00 +0000 Received: by outflank-mailman (input) for mailman id 414452; Fri, 30 Sep 2022 22:23:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeOQI-00088G-GE for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 22:23:58 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 90954788-410e-11ed-964a-05401a9f4f97; Sat, 01 Oct 2022 00:23:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D443932009A8; Fri, 30 Sep 2022 18:23:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 30 Sep 2022 18:23:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 18:23:49 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90954788-410e-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664576630; x= 1664663030; bh=RX384jPlUWMAwZzt1xsK9je9R67ehV0OxhWWNtDc/gk=; b=k pD7cEtjbCxE5nVCLEl/0YbAgI6yENgCfHjBA57XcStaWJyv6QXYfjknx0W7MDM9t vyh08oGvHiRvNSTvd0utQKRno1Nshjbr9spNXjkMC/phqsttU8kI6ymP8rhVnlFb wvBLEuLRZoa97gJIrQS7IJf2D0Lt02IhT9cFXe2mGjdKvWLLsquf0zddjFCg9wqs ljJ3KS8S+smFRnSJtQPKEh3qYqmnhh3yXxJbDwLEIDNIBeZbBaATmvUXq2c3G/Gh 7KSpgd8PwlvaxA9yj4HHNKXqPfo6Xvrh3Sv5jUuiaVhmSdsjlqmrcxcypHrhOavj w7vFQmrsUbbRMsrHhKItQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664576630; x=1664663030; bh=RX384jPlUWMAwZzt1xsK9je9R67e hV0OxhWWNtDc/gk=; b=pXvbizsEhFw8zh6954MAZ+w4xmpNnTLvhevaVkLwpVtD Dol0MkD1QAowrlujkHWwpoM68NT8bh31071mehu6aDzo6cvCA7nNgskyILXqo/+I K+euqrbCNOUx3TjUKCEHqhZVprZzEkaXb9YhXVNWm9YfYJE/ljzxS0umjrydjsbA VeB4+N5YrZi+4OfpJLWuuJAjEtcIYJ8ff0+SJyo99UtjDX0HAeXxNJFQUTiAQ5O5 k0sSg3Zi/zkwd+DxNXLIgOmSy6Z4g3ndGSQxuzonARGC/287p8+iZVkhXxtZdviM kZz46uFz29qyznAh/GS+qNH6v8KxWHxsBQtKX+OtDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehfedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 18:22:48 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 Message-ID: References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O0m4X08RcO4y0b4+" Content-Disposition: inline In-Reply-To: --O0m4X08RcO4y0b4+ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 18:22:48 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 On Fri, Sep 30, 2022 at 11:24:37PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 22:59, Ard Biesheuvel wrote: > > > > On Fri, 30 Sept 2022 at 22:21, Demi Marie Obenour > > wrote: > > > > > > On Fri, Sep 30, 2022 at 09:11:19PM +0200, Ard Biesheuvel wrote: > > > > On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour > > > > wrote: > > > > > > > > > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > > > > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > > > > > wrote: > > > > > > > > > > > > > > fwupd requires access to the EFI System Resource Table (ESRT)= to > > > > > > > discover which firmware can be updated by the OS. Currently,= Linux does > > > > > > > not expose the ESRT when running as a Xen dom0. Therefore, i= t is not > > > > > > > possible to use fwupd in a Xen dom0, which is a serious probl= em for e.g. > > > > > > > Qubes OS. > > > > > > > > > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limit= ations. > > > > > > > The UEFI specification requires the ESRT to be in EfiBootServ= icesData > > > > > > > memory, which Xen will use for whatever purposes it likes. T= herefore, > > > > > > > Linux cannot safely access the ESRT, as Xen may have overwrit= ten it. > > > > > > > > > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootS= ervicesData > > > > > > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootS= ervicesData > > > > > > > memory, Xen replaces the ESRT with a copy in memory that it h= as > > > > > > > reserved. Such memory is currently of type EFI_RUNTIME_SERVI= CES_DATA, > > > > > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY.= This > > > > > > > ensures that the ESRT can safely be accessed by the OS. > > > > > > > > > > > > > > When running as a Xen dom0, use the new > > > > > > > xen_config_table_memory_region_max() function to determine if= Xen has > > > > > > > reserved the ESRT and, if so, find the end of the memory regi= on > > > > > > > containing it. This allows programs such as fwupd which requ= ire the > > > > > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS= possible. > > > > > > > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > > > > > > > Why do we need this patch? I'd expect esrt_table_exists() to re= turn > > > > > > false when patch 1/2 is applied. > > > > > > > > > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be = an > > > > > alternative way to get the end of the memory region containing th= e ESRT. > > > > > That is what this patch provides. > > > > > > > > OK. I don't think we need that to be honest. When running under Xen, > > > > we should be able to assume that the ESRT does not span multiple > > > > memory regions arbitrarily, so we can just omit this check if > > > > !efi_enabled(EFI_MEMMAP) > > > > > > > > IIRC (and Peter would know), we are trying to filter out descriptors > > > > that are completely bogus here: zero lenght, zero address, etc etc.= I > > > > don't think we need that for Xen. > > > > > > Xen doesn=E2=80=99t uninstall bogus ESRTs, so there is no less reason= to worry > > > under Xen than on bare hardware. > > > > That may be true. But if Xen needs dom0 to be able to cross reference > > the EFI memory map, it should provide one (and set EFI_MEMMAP to > > enabled). >=20 > Btw the efi_mem_reserve() for the ESRT is also redundant if it is > guaranteed to be in RT services data or ACPI reclaim memory. It=E2=80=99s needed on bare hardware. On Xen it=E2=80=99s unreachable code. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --O0m4X08RcO4y0b4+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3bHMACgkQsoi1X/+c IsELVxAArRvWRhFqD/HZjNwD8miJSVhkUC762UgZ3NMbiQ0XEB+cjEpOxs6cEGWg zyclHhXXkl2SUxuOC/PyIDj5WngwTIHGmGxvWEnq4zr4PAJWYptR1MeAo4zYWU1k dBcBH/GZ8+ofW3hjfQdS9B8mnJQanp4BubEN0wY9mQOPetx8Fh0my7Pz36xVuUhf Nl1QgdrB8+Akmya4m7KN0ZxdMTm+e/QNSWogtsCpNls+nNDo6Rz7rjsKZJVpULQW 3GyptvapCv/tneLk7XgevsTP2FqWIIkV9DHag8HOrMCdv26xkyH2BrRXAYOvMzae N5H6dJYuZsdAnRptOzD74OeRRHo7Jgeb6oiqRSmmVG4VdfSVMrnJ5k4ZoN3tb0bx lBgWDLVQRwoqdYDP6i0d5sf5ZPe+iopD2L1U2+doE8MfNETOxF9BRXolzYS1qwzS w9ypAkP0NymMO2yCpDxm5mpNwyK/fr40SPBx+E0HgqezKAB5JimPuNI2B54Gb7P7 pbn24u3NyLDnEKSMOaDUmaExTVQqfv4vHmhLYnxya0+bWSqzQ1ia/VAI7SfHZqR7 xwOkstQ1VDwSnZsVoZJebsGDEg5G3B3G21MPFuQd2I6G2KPJRQlQG+kqlLn0vV4J rJWlWzvlSQZNtoh0h3HL8+KfiT8ztRBJmDfKnCfxB14LWGOVBHw= =FSrg -----END PGP SIGNATURE----- --O0m4X08RcO4y0b4+-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 22:25:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 22:25:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414457.658744 (Exim 4.92) (envelope-from ) id 1oeORi-0000FX-H0; Fri, 30 Sep 2022 22:25:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414457.658744; Fri, 30 Sep 2022 22:25:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeORi-0000FQ-Cj; Fri, 30 Sep 2022 22:25:26 +0000 Received: by outflank-mailman (input) for mailman id 414457; Fri, 30 Sep 2022 22:25:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oeORh-0000Be-07 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2022 22:25:25 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c637f499-410e-11ed-964a-05401a9f4f97; Sat, 01 Oct 2022 00:25:24 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8E439320099F; Fri, 30 Sep 2022 18:25:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 30 Sep 2022 18:25:22 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 18:25:20 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c637f499-410e-11ed-964a-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664576721; x= 1664663121; bh=T7Mg2JlqK1o7pUqTdBwT/w1PsDHF5gVYItjasG+Yjaw=; b=4 Qo0fVOVATLnXNgpBfGgE2nZRkka8lvb+5XXCI/rpwkByGxjkKiagYk3eNdUm6336 LQ/tvMQJHNBUa/fG1ACB+37mh+5YT4/dCMchhJcj3MXV8i1VFf2n+4xhHsNs6ByH q8pmV9ZDcvAZtWuVPek94nvd0KQfP2gaZjvaX3nlBZHXyu88YnY5mLdq6BRDl5q7 vWIcL04AuqMRRlYZSGQjz8eXxyRnMBXSyCD+PDta93YFnc/IlGOpYDe91E7PP2VE 4OcZS3HETZhyPIak5fE4r2ovOBQAVn2KvG4J6NRTAeSyXl5Fku+152WMQsdmoKV9 IjWLxWJUwlgLit6von9EA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664576721; x=1664663121; bh=T7Mg2JlqK1o7pUqTdBwT/w1PsDHF 5gVYItjasG+Yjaw=; b=qoSpnm9F1vihQXumi7xwH/hjgZ9MOQ2yvOX2uOnvf8ST WTbTGiF8zmrfz6Ym5gVYQOA/uqYmJGfsUg08fQLjM6DTv6b1eRHaufHwC96CmBVs OlWiLFpKsdUcEn1VWmZskNrav/p6AhfjCQzFJK2727FIXHA3v3tdo5wpdU9Efz8k UsJmVrkXaOe8CRAU/TzLu+s+2R50Vvm8Dqg7DIyL674AQgWetQXLGs11B4J9pKl6 Tq37IwdElNtVPI2IKoAMVlCnBdZ7XuIVUublUqcuMZYl62gID4AanZqPDPp1xQwD 0FxiF3zBdALeVc1pP7UY3rQ/NImrxpZqyKlMxu5GPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehfedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueeuveelheevvdeuvdfhiefhleff tdehuedvfefgveegfefgiefhudehveehtdefnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 30 Sep 2022 18:25:14 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 Message-ID: References: <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="W3TkS4UfiBitGDRa" Content-Disposition: inline In-Reply-To: --W3TkS4UfiBitGDRa Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Sep 2022 18:25:14 -0400 From: Demi Marie Obenour To: Ard Biesheuvel Cc: Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0 On Fri, Sep 30, 2022 at 10:59:49PM +0200, Ard Biesheuvel wrote: > On Fri, 30 Sept 2022 at 22:21, Demi Marie Obenour > wrote: > > > > On Fri, Sep 30, 2022 at 09:11:19PM +0200, Ard Biesheuvel wrote: > > > On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour > > > wrote: > > > > > > > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote: > > > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour > > > > > wrote: > > > > > > > > > > > > fwupd requires access to the EFI System Resource Table (ESRT) to > > > > > > discover which firmware can be updated by the OS. Currently, L= inux does > > > > > > not expose the ESRT when running as a Xen dom0. Therefore, it = is not > > > > > > possible to use fwupd in a Xen dom0, which is a serious problem= for e.g. > > > > > > Qubes OS. > > > > > > > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limitat= ions. > > > > > > The UEFI specification requires the ESRT to be in EfiBootServic= esData > > > > > > memory, which Xen will use for whatever purposes it likes. The= refore, > > > > > > Linux cannot safely access the ESRT, as Xen may have overwritte= n it. > > > > > > > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootSer= vicesData > > > > > > or EfiRuntimeServicesData memory. If the ESRT is in EfiBootSer= vicesData > > > > > > memory, Xen replaces the ESRT with a copy in memory that it has > > > > > > reserved. Such memory is currently of type EFI_RUNTIME_SERVICE= S_DATA, > > > > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY. = This > > > > > > ensures that the ESRT can safely be accessed by the OS. > > > > > > > > > > > > When running as a Xen dom0, use the new > > > > > > xen_config_table_memory_region_max() function to determine if X= en has > > > > > > reserved the ESRT and, if so, find the end of the memory region > > > > > > containing it. This allows programs such as fwupd which requir= e the > > > > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS p= ossible. > > > > > > > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > > > > > Why do we need this patch? I'd expect esrt_table_exists() to retu= rn > > > > > false when patch 1/2 is applied. > > > > > > > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be an > > > > alternative way to get the end of the memory region containing the = ESRT. > > > > That is what this patch provides. > > > > > > OK. I don't think we need that to be honest. When running under Xen, > > > we should be able to assume that the ESRT does not span multiple > > > memory regions arbitrarily, so we can just omit this check if > > > !efi_enabled(EFI_MEMMAP) > > > > > > IIRC (and Peter would know), we are trying to filter out descriptors > > > that are completely bogus here: zero lenght, zero address, etc etc. I > > > don't think we need that for Xen. > > > > Xen doesn=E2=80=99t uninstall bogus ESRTs, so there is no less reason t= o worry > > under Xen than on bare hardware. >=20 > That may be true. But if Xen needs dom0 to be able to cross reference > the EFI memory map, it should provide one (and set EFI_MEMMAP to > enabled). I agree, but it is also a significant amount of work compared to this patch. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --W3TkS4UfiBitGDRa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3bM4ACgkQsoi1X/+c IsGviA/9Ew7nTKujqShHMt0PH3J+T4Z7VEpnyrbvswGUdPqEwfkDIwWTVdXkY7LY gP2IdAm6BeBxi6FM8+PC3Q27bXNgb79bEMTq2EkKSg6GRCNFr//A+CycEpUV8PIB tawXGOkdstjChGDJcFGeYZv7vhWGjFhMWDAKkSBEKMA4ULwTOfSkAm7PKqa8Cdkz oP6owcGuakCjzvb8Tneqp2ekAdGeENgpaEFS03WreCne6V1j3BH0iZh89q0Ztyq1 +6gowf5kkx+/4AFsUjBEnMJmTGaeumvc4HaqF1NCWJ1JD5MkdG7LYfe5mF3PZ9x6 xdb4NZQIBO5aooeGw4EiKa0k385DXLB2NuAAD/d/wn/vLdcjSCoVf3ox5qLGy5U6 dz7Vw6/bG4HTXxtwsCvQbr7+MTyVfHlv+u14/l0ESJw1+tGMXT5gylr6EJe6N7kX nw7q+Cx2hUb8zhQuZpJNndAO0Z7u3lMiQwTNplO75SIVBzaX+JUDoN9yHUYNQc/A 8y7ZxatLuM9EEatkRfW3LWwMOXANlkHLoKOdTK7d7KbgliasMc2lCn3KRVsen/Q5 qxH8UpVicsSuMtucJ3d+TsnssjOnGBN9Lvpkphs2tTGkNbRu/SlBLzbm+6c6AAuu g+riK0KOtO5qcExucLSQe3AKP8/9tYtWR+i85xcDz2ZhN88nVB4= =hWqs -----END PGP SIGNATURE----- --W3TkS4UfiBitGDRa-- From xen-devel-bounces@lists.xenproject.org Fri Sep 30 23:16:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 30 Sep 2022 23:16:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.414464.658754 (Exim 4.92) (envelope-from ) id 1oePFF-0005Zd-8K; Fri, 30 Sep 2022 23:16:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 414464.658754; Fri, 30 Sep 2022 23:16:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oePFF-0005ZW-5V; Fri, 30 Sep 2022 23:16:37 +0000 Received: by outflank-mailman (input) for mailman id 414464; Fri, 30 Sep 2022 23:16:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oePFD-0005ZM-FR; Fri, 30 Sep 2022 23:16:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oePFD-00046F-Df; Fri, 30 Sep 2022 23:16:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oePFC-0005Z0-T1; Fri, 30 Sep 2022 23:16:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oePFC-0007dF-SZ; Fri, 30 Sep 2022 23:16:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=v9BgQgSMN4bp+gB1dFqg0ZqypuJU3SbqIs4UeiieeeA=; b=Fgae6w0LCJcaJkq4zKP2ZRNLd6 Cos4oZj2OF9Njxt1WGvnNR2YN6+UR4FkGENnjnokTk1KGZdw5kaukuQwRMl0N1OU3WgAcaLttw9v1 tWxLKHLstYJywV4ue82mlLRdQHDFdRhc+f+eHGSYwpDsrnKaMn8+9yhDpVW2AY08Edt4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 173386: trouble: blocked/broken/pass X-Osstest-Failures: ovmf:build-i386::broken:regression ovmf:build-i386-pvops::broken:regression ovmf:build-i386-xsm::broken:regression ovmf:build-i386-xsm:host-install(4):broken:regression ovmf:build-i386:host-install(4):broken:regression ovmf:build-i386-pvops:host-install(4):broken:regression ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=7aa06237b856fd6f8187cc1715a3fe08ab4e98ed X-Osstest-Versions-That: ovmf=b7213bbd59833fb0786c83a28df5f8244602ab5e From: osstest service owner Date: Fri, 30 Sep 2022 23:16:34 +0000 flight 173386 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173386/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386 broken build-i386-pvops broken build-i386-xsm broken build-i386-xsm 4 host-install(4) broken REGR. vs. 173356 build-i386 4 host-install(4) broken REGR. vs. 173356 build-i386-pvops 4 host-install(4) broken REGR. vs. 173356 Tests which did not succeed, but are not blocking: build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed baseline version: ovmf b7213bbd59833fb0786c83a28df5f8244602ab5e Last test of basis 173356 2022-09-28 14:40:29 Z 2 days Testing same since 173386 2022-09-30 12:10:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rodrigo Gonzalez Del Cueto jobs: build-amd64-xsm pass build-i386-xsm broken build-amd64 pass build-i386 broken build-amd64-libvirt pass build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops broken test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-i386 broken broken-job build-i386-pvops broken broken-job build-i386-xsm broken broken-step build-i386-xsm host-install(4) broken-step build-i386 host-install(4) broken-step build-i386-pvops host-install(4) Not pushing. ------------------------------------------------------------ commit 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed Author: Rodrigo Gonzalez Del Cueto Date: Thu Sep 22 15:35:36 2022 +0800 SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077 Following the design described in the TCG specification, the driver implementation of the CRB protocol does not require enforcing completing the transition to goIdle at the end of a command sequence. Signed-off-by: Rodrigo Gonzalez Del Cueto Cc: Jiewen Yao Cc: Jian J Wang Reviewed-by: Jian J Wang